From xen-devel-bounces@lists.xenproject.org Wed Feb 01 00:22:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 00:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487978.755821 (Exim 4.92) (envelope-from ) id 1pN0sv-0002Go-5Z; Wed, 01 Feb 2023 00:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487978.755821; Wed, 01 Feb 2023 00:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN0sv-0002Gh-2y; Wed, 01 Feb 2023 00:21:57 +0000 Received: by outflank-mailman (input) for mailman id 487978; Wed, 01 Feb 2023 00:21:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN0ss-0002Gb-Vl for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 00:21:54 +0000 Received: from ppsw-42.srv.uis.cam.ac.uk (ppsw-42.srv.uis.cam.ac.uk [131.111.8.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cf0116f-a1c6-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 01:21:53 +0100 (CET) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43156) by ppsw-42.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1pN0sl-0010SJ-EJ (Exim 4.96) (return-path ); Wed, 01 Feb 2023 00:21:47 +0000 Received: from [192.168.1.10] (host-92-12-62-6.as13285.net [92.12.62.6]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 132C91FBCC; Wed, 1 Feb 2023 00:21:47 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cf0116f-a1c6-11ed-933c-83870f6b2ba8 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> Date: Wed, 1 Feb 2023 00:21:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-GB To: Alistair Francis Cc: Oleksii , xen-devel@lists.xenproject.org, Bob Eshleman , Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman , Julien Grall References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> From: Andrew Cooper Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 31/01/2023 11:17 pm, Alistair Francis wrote: > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: >> On 31/01/2023 11:44, Alistair Francis wrote: >>> On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: >>> >> From my understanding, on RISC-V, the use of PC-relative address is >> only guaranteed with medany. So if you were going to change the cmodel >> (Andrew suggested you would), then early_*() may end up to be broken. >> >> This check serve as a documentation of the assumption and also help the >> developer any change in the model and take the appropriate action to >> remediate it. >> >>> I think this is safe to remove. >> Based on what I wrote above, do you still think this is safe? > With that in mind it's probably worth leaving in then. Maybe the > comment should be updated to make it explicit why we want this check > (I find the current comment not very helpful). The presence of this check pre-supposes that Xen will always relocate itself, and this simply not true.  XIP for example typically does not. Furthermore it's not checking the property wanted.  The way C is compiled has no bearing on what relocation head.S uses to call it. It is a given that we compile the hypervisor with a consistent code model, meaning that the properly actually making the check do what is wanted is also the property that means it is not needed in the first place. This check is literally not worth the bytes it's taking up on disk, and not worth the added compiler time, nor the wasted time of whoever comes to support something like XIP in the future finds it to be in the way.  Xen as a whole will really genuinely function as intended in models other than medany, and it demonstrates a misunderstanding of the topic to put in such a check to begin with. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 01 00:32:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 00:32:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487983.755832 (Exim 4.92) (envelope-from ) id 1pN12Y-00041u-3s; Wed, 01 Feb 2023 00:31:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487983.755832; Wed, 01 Feb 2023 00:31:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN12Y-00041n-0Z; Wed, 01 Feb 2023 00:31:54 +0000 Received: by outflank-mailman (input) for mailman id 487983; Wed, 01 Feb 2023 00:31:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN12W-00041d-Py; Wed, 01 Feb 2023 00:31:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN12W-0002f2-Mw; Wed, 01 Feb 2023 00:31:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN12W-0003lb-8M; Wed, 01 Feb 2023 00:31:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN12W-0000AB-7v; Wed, 01 Feb 2023 00:31:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4LWiZPUUrL6cEphH+WDsSQHMZ0gx+5KIvfYHPLKPFsI=; b=D2vatyWou5xq0Ubi0b82O5nPB6 H+g7LwyOAuj1cxQyH4cwU3B9TE4abMsL8+1avZwlvxJDvmVZYMW25AwV9DQLmPPrBzxa6IR13XkyZ NsuQFQ5dl8135m7+FbT5199AbG9mDQ7qSyf/oqPKh469S95UvPHaDq+9QXsIXpK86SAk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176303: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 00:31:52 +0000 flight 176303 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176303/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 5 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf host-install(4) broken-step build-armhf capture-logs Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 01:31:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 01:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.487995.755843 (Exim 4.92) (envelope-from ) id 1pN1xi-0001nm-JT; Wed, 01 Feb 2023 01:30:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 487995.755843; Wed, 01 Feb 2023 01:30:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN1xi-0001ne-F4; Wed, 01 Feb 2023 01:30:58 +0000 Received: by outflank-mailman (input) for mailman id 487995; Wed, 01 Feb 2023 01:30:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN1xg-0001nY-OP for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 01:30:57 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 101c0c5c-a1d0-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 02:30:52 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 826536098A; Wed, 1 Feb 2023 01:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D550C433D2; Wed, 1 Feb 2023 01:30:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 101c0c5c-a1d0-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675215050; bh=U/1z8e8d/tq25Kzt4j9FU3/4jdlftRctNW3sDc8LYMU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uSQYvBKeoBUcvjvW5ebm6NIqwCITlhkHHCAYxwqZhtL2Jc8SQxcEmpXq7XNJ7FNj6 Qp1jwa6jBJ67Fj1lqX/0u31GQEKe4sJbe11GyhWmKzl5pecUvNKXgRqF7091S2h87n PUXHzXuEFGeQa+a2yLsVoUs8tLBotGI74Y028ufwpYB/GSv05mwDzKRJvcCYPuLUcd ARcdWWz06MIufid0p+eAvBI5VF/RhCe5OAA6F+C4A3cr7j59Dmh+IVc0m1ZSxQ9IpX avbSortQG5UZkY1JItv939cd2wVeM/b5Yf3ss2mjBxgeKFZkIhshntRqt5Duz4g5WS Xrp+oBCrx+FMg== Date: Tue, 31 Jan 2023 17:30:47 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Oleksii , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 07/14] xen/riscv: introduce exception context In-Reply-To: Message-ID: References: <652289358975cf869e4bc0a6a70e3aba7bd2fbf6.1674818705.git.oleksii.kurochko@gmail.com> <75328420-0fbd-92ae-40c7-9fee1c31c907@suse.com> <792bc4533d3604acd4321b4b15965adec22431a4.camel@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-900873961-1675215050=:132504" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-900873961-1675215050=:132504 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 30 Jan 2023, Jan Beulich wrote: > On 30.01.2023 12:54, Oleksii wrote: > > Hi Jan, > > > > On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: > >> On 27.01.2023 14:59, Oleksii Kurochko wrote: > >>> --- /dev/null > >>> +++ b/xen/arch/riscv/include/asm/processor.h > >>> @@ -0,0 +1,82 @@ > >>> +/* SPDX-License-Identifier: MIT */ > >>> +/***************************************************************** > >>> ************* > >>> + * > >>> + * Copyright 2019 (C) Alistair Francis > >>> + * Copyright 2021 (C) Bobby Eshleman > >>> + * Copyright 2023 (C) Vates > >>> + * > >>> + */ > >>> + > >>> +#ifndef _ASM_RISCV_PROCESSOR_H > >>> +#define _ASM_RISCV_PROCESSOR_H > >>> + > >>> +#ifndef __ASSEMBLY__ > >>> + > >>> +/* On stack VCPU state */ > >>> +struct cpu_user_regs > >>> +{ > >>> +    unsigned long zero; > >>> +    unsigned long ra; > >>> +    unsigned long sp; > >>> +    unsigned long gp; > >>> +    unsigned long tp; > >>> +    unsigned long t0; > >>> +    unsigned long t1; > >>> +    unsigned long t2; > >>> +    unsigned long s0; > >>> +    unsigned long s1; > >>> +    unsigned long a0; > >>> +    unsigned long a1; > >>> +    unsigned long a2; > >>> +    unsigned long a3; > >>> +    unsigned long a4; > >>> +    unsigned long a5; > >>> +    unsigned long a6; > >>> +    unsigned long a7; > >>> +    unsigned long s2; > >>> +    unsigned long s3; > >>> +    unsigned long s4; > >>> +    unsigned long s5; > >>> +    unsigned long s6; > >>> +    unsigned long s7; > >>> +    unsigned long s8; > >>> +    unsigned long s9; > >>> +    unsigned long s10; > >>> +    unsigned long s11; > >>> +    unsigned long t3; > >>> +    unsigned long t4; > >>> +    unsigned long t5; > >>> +    unsigned long t6; > >>> +    unsigned long sepc; > >>> +    unsigned long sstatus; > >>> +    /* pointer to previous stack_cpu_regs */ > >>> +    unsigned long pregs; > >>> +}; > >> > >> Just to restate what I said on the earlier version: We have a struct > >> of > >> this name in the public interface for x86. Besides to confusion about > >> re-using the name for something private, I'd still like to understand > >> what the public interface plans are. This is specifically because I > >> think it would be better to re-use suitable public interface structs > >> internally where possible. But that of course requires spelling out > >> such parts of the public interface first. > >> > > I am not sure that I get you here. > > I greped a little bit and found out that each architecture declares > > this structure inside arch-specific folder. > > > > Mostly the usage of the cpu_user_regs is to save/restore current state > > of CPU during traps ( exceptions/interrupts ) and context_switch(). > > Arm effectively duplicates the public interface struct vcpu_guest_core_regs > and the internal struct cpu_user_regs (and this goes as far as also > duplicating the __DECL_REG() helper). Personally I find such duplication > odd at the first glance at least; maybe there is a specific reason for this > in Arm. But whether the public interface struct can be re-used can likely > only be known once it was spelled out. struct vcpu_guest_core_regs is used as part of struct vcpu_guest_context, which is used for VCPUOP_initialise, which is not used on ARM and RISC-V (we use a standard firmware interface instead), and for save/restore, which also is not going to work any time soon on ARM and RISC-V. This is to say that we are probably not going to need the public interface for the next year or two, so it is difficult to tell at this stage if it aligns well with struct cpu_user_regs. I think we'll have to cross that bridge when we come to it. > > Also some registers are modified during construction of a domain. > > Thereby I prefer here to see the arch-specific register names instead > > of common. > > Not sure what meaning of "common" you imply here. Surely register names > want to be arch-specific, and hence can't be "common" with other arch-es. I think Oleksii misunderstood your request and believed you were asking him to make struct cpu_user_regs common across arches. --8323329-900873961-1675215050=:132504-- From xen-devel-bounces@lists.xenproject.org Wed Feb 01 01:46:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 01:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488001.755854 (Exim 4.92) (envelope-from ) id 1pN2Cu-0003wi-Tn; Wed, 01 Feb 2023 01:46:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488001.755854; Wed, 01 Feb 2023 01:46:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2Cu-0003wb-QO; Wed, 01 Feb 2023 01:46:40 +0000 Received: by outflank-mailman (input) for mailman id 488001; Wed, 01 Feb 2023 01:46:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2Ct-0003wT-5p for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 01:46:39 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 437946d4-a1d2-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 02:46:37 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C8AEB81FC9; Wed, 1 Feb 2023 01:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87DB7C433D2; Wed, 1 Feb 2023 01:46:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 437946d4-a1d2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675215995; bh=UbVxoOjw8i3l8goMfd82dxxxjM0aV0oN+XWGPGYvEoc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=G9K7O+9+tJVa6jxgjSwEHqXf6enFDsq26zquy4PYUuGjdt0ju2JYt9ceuBSZqr1OS dc6oztbN2Ldh0wBbWBIlVmBIk3UOYs/z07eqRgOKLdr5oXk18EhqwAlR/3SuHWM5e1 nsug5ruo6nTkS3OwqroFBy1qzhUNw8FicC0rIVJRe46dyR8QvCs9MIz5viFienO/UA BR2PDngSQXryWBADGYhGVcDEzsbfAXZhV7jpSZ7zVs6HpclAVoeXnYv77pLk4BmhWF /w5ORkDWCZsxAWuO9QhGATErxCBgTC00sQw0FKSfr6z3RZz8MSrKW+OpSxZFRPgCZZ 8wxKPKWAEEoSA== Date: Tue, 31 Jan 2023 17:46:31 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Vikram Garhwal cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Peter Maydell , Stefano Stabellini , Anthony Perard , Paul Durrant , "open list:ARM TCG CPUs" Subject: Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine In-Reply-To: <20230131225149.14764-10-vikram.garhwal@amd.com> Message-ID: References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-10-vikram.garhwal@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 31 Jan 2023, Vikram Garhwal wrote: > Add a new machine xenpvh which creates a IOREQ server to register/connect with > Xen Hypervisor. > > Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a > TPM emulator and connects to swtpm running on host machine via chardev socket > and support TPM functionalities for a guest domain. > > Extra command line for aarch64 xenpvh QEMU to connect to swtpm: > -chardev socket,id=chrtpm,path=/tmp/myvtpm2/swtpm-sock \ > -tpmdev emulator,id=tpm0,chardev=chrtpm \ > -machine tpm-base-addr=0x0c000000 \ > > swtpm implements a TPM software emulator(TPM 1.2 & TPM 2) built on libtpms and > provides access to TPM functionality over socket, chardev and CUSE interface. > Github repo: https://github.com/stefanberger/swtpm > Example for starting swtpm on host machine: > mkdir /tmp/vtpm2 > swtpm socket --tpmstate dir=/tmp/vtpm2 \ > --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini > --- > docs/system/arm/xenpvh.rst | 34 +++++++ > docs/system/target-arm.rst | 1 + > hw/arm/meson.build | 2 + > hw/arm/xen_arm.c | 182 ++++++++++++++++++++++++++++++++++ > include/hw/arm/xen_arch_hvm.h | 9 ++ > include/hw/xen/arch_hvm.h | 2 + > 6 files changed, 230 insertions(+) > create mode 100644 docs/system/arm/xenpvh.rst > create mode 100644 hw/arm/xen_arm.c > create mode 100644 include/hw/arm/xen_arch_hvm.h > > diff --git a/docs/system/arm/xenpvh.rst b/docs/system/arm/xenpvh.rst > new file mode 100644 > index 0000000000..e1655c7ab8 > --- /dev/null > +++ b/docs/system/arm/xenpvh.rst > @@ -0,0 +1,34 @@ > +XENPVH (``xenpvh``) > +========================================= > +This machine creates a IOREQ server to register/connect with Xen Hypervisor. > + > +When TPM is enabled, this machine also creates a tpm-tis-device at a user input > +tpm base address, adds a TPM emulator and connects to a swtpm application > +running on host machine via chardev socket. This enables xenpvh to support TPM > +functionalities for a guest domain. > + > +More information about TPM use and installing swtpm linux application can be > +found at: docs/specs/tpm.rst. > + > +Example for starting swtpm on host machine: > +.. code-block:: console > + > + mkdir /tmp/vtpm2 > + swtpm socket --tpmstate dir=/tmp/vtpm2 \ > + --ctrl type=unixio,path=/tmp/vtpm2/swtpm-sock & > + > +Sample QEMU xenpvh commands for running and connecting with Xen: > +.. code-block:: console > + > + qemu-system-aarch64 -xen-domid 1 \ > + -chardev socket,id=libxl-cmd,path=qmp-libxl-1,server=on,wait=off \ > + -mon chardev=libxl-cmd,mode=control \ > + -chardev socket,id=libxenstat-cmd,path=qmp-libxenstat-1,server=on,wait=off \ > + -mon chardev=libxenstat-cmd,mode=control \ > + -xen-attach -name guest0 -vnc none -display none -nographic \ > + -machine xenpvh -m 1301 \ > + -chardev socket,id=chrtpm,path=tmp/vtpm2/swtpm-sock \ > + -tpmdev emulator,id=tpm0,chardev=chrtpm -machine tpm-base-addr=0x0C000000 > + > +In above QEMU command, last two lines are for connecting xenpvh QEMU to swtpm > +via chardev socket. > diff --git a/docs/system/target-arm.rst b/docs/system/target-arm.rst > index 91ebc26c6d..af8d7c77d6 100644 > --- a/docs/system/target-arm.rst > +++ b/docs/system/target-arm.rst > @@ -106,6 +106,7 @@ undocumented; you can get a complete list by running > arm/stm32 > arm/virt > arm/xlnx-versal-virt > + arm/xenpvh > > Emulated CPU architecture support > ================================= > diff --git a/hw/arm/meson.build b/hw/arm/meson.build > index b036045603..06bddbfbb8 100644 > --- a/hw/arm/meson.build > +++ b/hw/arm/meson.build > @@ -61,6 +61,8 @@ arm_ss.add(when: 'CONFIG_FSL_IMX7', if_true: files('fsl-imx7.c', 'mcimx7d-sabre. > arm_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmuv3.c')) > arm_ss.add(when: 'CONFIG_FSL_IMX6UL', if_true: files('fsl-imx6ul.c', 'mcimx6ul-evk.c')) > arm_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_soc.c')) > +arm_ss.add(when: 'CONFIG_XEN', if_true: files('xen_arm.c')) > +arm_ss.add_all(xen_ss) > > softmmu_ss.add(when: 'CONFIG_ARM_SMMUV3', if_true: files('smmu-common.c')) > softmmu_ss.add(when: 'CONFIG_EXYNOS4', if_true: files('exynos4_boards.c')) > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c > new file mode 100644 > index 0000000000..eaca65af37 > --- /dev/null > +++ b/hw/arm/xen_arm.c > @@ -0,0 +1,182 @@ > +/* > + * QEMU ARM Xen PVH Machine > + * > + * > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to deal > + * in the Software without restriction, including without limitation the rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > + * THE SOFTWARE. > + */ > + > +#include "qemu/osdep.h" > +#include "qemu/error-report.h" > +#include "qapi/qapi-commands-migration.h" > +#include "qapi/visitor.h" > +#include "hw/boards.h" > +#include "hw/sysbus.h" > +#include "sysemu/block-backend.h" > +#include "sysemu/tpm_backend.h" > +#include "sysemu/sysemu.h" > +#include "hw/xen/xen-legacy-backend.h" > +#include "hw/xen/xen-hvm-common.h" > +#include "sysemu/tpm.h" > +#include "hw/xen/arch_hvm.h" > + > +#define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh") > +OBJECT_DECLARE_SIMPLE_TYPE(XenArmState, XEN_ARM) > + > +static MemoryListener xen_memory_listener = { > + .region_add = xen_region_add, > + .region_del = xen_region_del, > + .log_start = NULL, > + .log_stop = NULL, > + .log_sync = NULL, > + .log_global_start = NULL, > + .log_global_stop = NULL, > + .priority = 10, > +}; > + > +struct XenArmState { > + /*< private >*/ > + MachineState parent; > + > + XenIOState *state; > + > + struct { > + uint64_t tpm_base_addr; > + } cfg; > +}; > + > +void arch_handle_ioreq(XenIOState *state, ioreq_t *req) > +{ > + hw_error("Invalid ioreq type 0x%x\n", req->type); > + > + return; > +} > + > +void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section, > + bool add) > +{ > +} > + > +void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) > +{ > +} > + > +void qmp_xen_set_global_dirty_log(bool enable, Error **errp) > +{ > +} > + > +#ifdef CONFIG_TPM > +static void xen_enable_tpm(XenArmState *xam) > +{ > + Error *errp = NULL; > + DeviceState *dev; > + SysBusDevice *busdev; > + > + TPMBackend *be = qemu_find_tpm_be("tpm0"); > + if (be == NULL) { > + DPRINTF("Couldn't fine the backend for tpm0\n"); > + return; > + } > + dev = qdev_new(TYPE_TPM_TIS_SYSBUS); > + object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp); > + object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp); > + busdev = SYS_BUS_DEVICE(dev); > + sysbus_realize_and_unref(busdev, &error_fatal); > + sysbus_mmio_map(busdev, 0, xam->cfg.tpm_base_addr); > + > + DPRINTF("Connected tpmdev at address 0x%lx\n", xam->cfg.tpm_base_addr); > +} > +#endif > + > +static void xen_arm_init(MachineState *machine) > +{ > + XenArmState *xam = XEN_ARM(machine); > + > + xam->state = g_new0(XenIOState, 1); > + > + xen_register_ioreq(xam->state, machine->smp.cpus, xen_memory_listener); > + > +#ifdef CONFIG_TPM > + if (xam->cfg.tpm_base_addr) { > + xen_enable_tpm(xam); > + } else { > + DPRINTF("tpm-base-addr is not provided. TPM will not be enabled\n"); > + } > +#endif > +} > + > +#ifdef CONFIG_TPM > +static void xen_arm_get_tpm_base_addr(Object *obj, Visitor *v, > + const char *name, void *opaque, > + Error **errp) > +{ > + XenArmState *xam = XEN_ARM(obj); > + uint64_t value = xam->cfg.tpm_base_addr; > + > + visit_type_uint64(v, name, &value, errp); > +} > + > +static void xen_arm_set_tpm_base_addr(Object *obj, Visitor *v, > + const char *name, void *opaque, > + Error **errp) > +{ > + XenArmState *xam = XEN_ARM(obj); > + uint64_t value; > + > + if (!visit_type_uint64(v, name, &value, errp)) { > + return; > + } > + > + xam->cfg.tpm_base_addr = value; > +} > +#endif > + > +static void xen_arm_machine_class_init(ObjectClass *oc, void *data) > +{ > + > + MachineClass *mc = MACHINE_CLASS(oc); > + mc->desc = "Xen Para-virtualized PC"; > + mc->init = xen_arm_init; > + mc->max_cpus = 1; > + mc->default_machine_opts = "accel=xen"; > + > +#ifdef CONFIG_TPM > + object_class_property_add(oc, "tpm-base-addr", "uint64_t", > + xen_arm_get_tpm_base_addr, > + xen_arm_set_tpm_base_addr, > + NULL, NULL); > + object_class_property_set_description(oc, "tpm-base-addr", > + "Set Base address for TPM device."); > + > + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS); > +#endif > +} > + > +static const TypeInfo xen_arm_machine_type = { > + .name = TYPE_XEN_ARM, > + .parent = TYPE_MACHINE, > + .class_init = xen_arm_machine_class_init, > + .instance_size = sizeof(XenArmState), > +}; > + > +static void xen_arm_machine_register_types(void) > +{ > + type_register_static(&xen_arm_machine_type); > +} > + > +type_init(xen_arm_machine_register_types) > diff --git a/include/hw/arm/xen_arch_hvm.h b/include/hw/arm/xen_arch_hvm.h > new file mode 100644 > index 0000000000..8fd645e723 > --- /dev/null > +++ b/include/hw/arm/xen_arch_hvm.h > @@ -0,0 +1,9 @@ > +#ifndef HW_XEN_ARCH_ARM_HVM_H > +#define HW_XEN_ARCH_ARM_HVM_H > + > +#include > +void arch_handle_ioreq(XenIOState *state, ioreq_t *req); > +void arch_xen_set_memory(XenIOState *state, > + MemoryRegionSection *section, > + bool add); > +#endif > diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h > index 26674648d8..c7c515220d 100644 > --- a/include/hw/xen/arch_hvm.h > +++ b/include/hw/xen/arch_hvm.h > @@ -1,3 +1,5 @@ > #if defined(TARGET_I386) || defined(TARGET_X86_64) > #include "hw/i386/xen_arch_hvm.h" > +#elif defined(TARGET_ARM) || defined(TARGET_ARM_64) > +#include "hw/arm/xen_arch_hvm.h" > #endif > -- > 2.17.0 > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 01:47:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 01:47:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488004.755865 (Exim 4.92) (envelope-from ) id 1pN2Ds-0004Sk-7h; Wed, 01 Feb 2023 01:47:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488004.755865; Wed, 01 Feb 2023 01:47:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2Ds-0004Sc-3X; Wed, 01 Feb 2023 01:47:40 +0000 Received: by outflank-mailman (input) for mailman id 488004; Wed, 01 Feb 2023 01:47:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2Dq-0004SV-Ah for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 01:47:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66191834-a1d2-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 02:47:35 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA42E609AD; Wed, 1 Feb 2023 01:47:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63CC9C433EF; Wed, 1 Feb 2023 01:47:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66191834-a1d2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675216053; bh=T6t348sa1zb1HOH4YbhFvrYzWl+VEyEuZWqTiGVDjmk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=L+a8oMwXYk+2j7sgjXxzw6wH9ungFieDnEDpO1k6wVpoLM7RdzY/BiOEj+tR1uavM bDI5TFoaSwK6rU/eJ8z8FXziJyN2wxY4h5Z5b19dsvZ5spuSU6anzFAk2YZGxzsi+H gGtZDp4DCCa5y+YBrrUaYYmLeUDids9OppR9fnpK0KqKDV0/LhHm4IoOc7a1COAMym Nj3W8KmJyR1f/TW/GAfcxbxM+0twk0B+YW0gxkaaTbCQnPvV72R6TcgMurzycAp9RH 64OBnHuIAqW2stB1zFmqXV1kNkoCn08Jl2uVniiLZx3ynbxV0o9IbCFCbcBYXCQfEm 2s4YGBLca764w== Date: Tue, 31 Jan 2023 17:47:29 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Vikram Garhwal cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Stefano Stabellini , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: Re: [QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common In-Reply-To: <20230131225149.14764-5-vikram.garhwal@amd.com> Message-ID: References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-5-vikram.garhwal@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 31 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > This patch does following: > 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in > preparation for moving most of xen-hvm code to an arch-neutral location, > move the x86-specific portion of xen_set_memory to arch_xen_set_memory. > Also, move handle_vmport_ioreq to arch_handle_ioreq. > > 2. Pure code movement: move common functions to hw/xen/xen-hvm-common.c > Extract common functionalities from hw/i386/xen/xen-hvm.c and move them to > hw/xen/xen-hvm-common.c. These common functions are useful for creating > an IOREQ server. > > xen_hvm_init_pc() contains the architecture independent code for creating > and mapping a IOREQ server, connecting memory and IO listeners, initializing > a xen bus and registering backends. Moved this common xen code to a new > function xen_register_ioreq() which can be used by both x86 and ARM machines. > > Following functions are moved to hw/xen/xen-hvm-common.c: > xen_vcpu_eport(), xen_vcpu_ioreq(), xen_ram_alloc(), xen_set_memory(), > xen_region_add(), xen_region_del(), xen_io_add(), xen_io_del(), > xen_device_realize(), xen_device_unrealize(), > cpu_get_ioreq_from_shared_memory(), cpu_get_ioreq(), do_inp(), > do_outp(), rw_phys_req_item(), read_phys_req_item(), > write_phys_req_item(), cpu_ioreq_pio(), cpu_ioreq_move(), > cpu_ioreq_config(), handle_ioreq(), handle_buffered_iopage(), > handle_buffered_io(), cpu_handle_ioreq(), xen_main_loop_prepare(), > xen_hvm_change_state_handler(), xen_exit_notifier(), > xen_map_ioreq_server(), destroy_hvm_domain() and > xen_shutdown_fatal_error() > > 3. Removed static type from below functions: > 1. xen_region_add() > 2. xen_region_del() > 3. xen_io_add() > 4. xen_io_del() > 5. xen_device_realize() > 6. xen_device_unrealize() > 7. xen_hvm_change_state_handler() > 8. cpu_ioreq_pio() > 9. xen_exit_notifier() > > 4. Replace TARGET_PAGE_SIZE with XC_PAGE_SIZE to match the page side with Xen. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini > --- > hw/i386/xen/trace-events | 14 - > hw/i386/xen/xen-hvm.c | 1019 ++----------------------------- > hw/xen/meson.build | 5 +- > hw/xen/trace-events | 14 + > hw/xen/xen-hvm-common.c | 874 ++++++++++++++++++++++++++ > include/hw/i386/xen_arch_hvm.h | 11 + > include/hw/xen/arch_hvm.h | 3 + > include/hw/xen/xen-hvm-common.h | 98 +++ > 8 files changed, 1067 insertions(+), 971 deletions(-) > create mode 100644 hw/xen/xen-hvm-common.c > create mode 100644 include/hw/i386/xen_arch_hvm.h > create mode 100644 include/hw/xen/arch_hvm.h > create mode 100644 include/hw/xen/xen-hvm-common.h > > diff --git a/hw/i386/xen/trace-events b/hw/i386/xen/trace-events > index a0c89d91c4..5d0a8d6dcf 100644 > --- a/hw/i386/xen/trace-events > +++ b/hw/i386/xen/trace-events > @@ -7,17 +7,3 @@ xen_platform_log(char *s) "xen platform: %s" > xen_pv_mmio_read(uint64_t addr) "WARNING: read from Xen PV Device MMIO space (address 0x%"PRIx64")" > xen_pv_mmio_write(uint64_t addr) "WARNING: write to Xen PV Device MMIO space (address 0x%"PRIx64")" > > -# xen-hvm.c > -xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx" > -xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i" > -handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > -handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > -handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > -cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > -cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" > -cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" > -cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > -xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p" > -cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" > -cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" > - > diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c > index 06c446e7be..4219308caf 100644 > --- a/hw/i386/xen/xen-hvm.c > +++ b/hw/i386/xen/xen-hvm.c > @@ -10,43 +10,21 @@ > > #include "qemu/osdep.h" > #include "qemu/units.h" > +#include "qapi/error.h" > +#include "qapi/qapi-commands-migration.h" > +#include "trace.h" > > -#include "cpu.h" > -#include "hw/pci/pci.h" > -#include "hw/pci/pci_host.h" > #include "hw/i386/pc.h" > #include "hw/irq.h" > -#include "hw/hw.h" > #include "hw/i386/apic-msidef.h" > -#include "hw/xen/xen_common.h" > -#include "hw/xen/xen-legacy-backend.h" > -#include "hw/xen/xen-bus.h" > #include "hw/xen/xen-x86.h" > -#include "qapi/error.h" > -#include "qapi/qapi-commands-migration.h" > -#include "qemu/error-report.h" > -#include "qemu/main-loop.h" > #include "qemu/range.h" > -#include "sysemu/runstate.h" > -#include "sysemu/sysemu.h" > -#include "sysemu/xen.h" > -#include "sysemu/xen-mapcache.h" > -#include "trace.h" > > -#include > +#include "hw/xen/xen-hvm-common.h" > +#include "hw/xen/arch_hvm.h" > #include > > -//#define DEBUG_XEN_HVM > - > -#ifdef DEBUG_XEN_HVM > -#define DPRINTF(fmt, ...) \ > - do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0) > -#else > -#define DPRINTF(fmt, ...) \ > - do { } while (0) > -#endif > - > -static MemoryRegion ram_memory, ram_640k, ram_lo, ram_hi; > +static MemoryRegion ram_640k, ram_lo, ram_hi; > static MemoryRegion *framebuffer; > static bool xen_in_migration; > > @@ -73,27 +51,8 @@ struct shared_vmport_iopage { > }; > typedef struct shared_vmport_iopage shared_vmport_iopage_t; > #endif > -static shared_vmport_iopage_t *shared_vmport_page; > > -static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i) > -{ > - return shared_page->vcpu_ioreq[i].vp_eport; > -} > -static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) > -{ > - return &shared_page->vcpu_ioreq[vcpu]; > -} > - > -#define BUFFER_IO_MAX_DELAY 100 > - > -typedef struct XenPhysmap { > - hwaddr start_addr; > - ram_addr_t size; > - const char *name; > - hwaddr phys_offset; > - > - QLIST_ENTRY(XenPhysmap) list; > -} XenPhysmap; > +static shared_vmport_iopage_t *shared_vmport_page; > > static QLIST_HEAD(, XenPhysmap) xen_physmap; > static const XenPhysmap *log_for_dirtybit; > @@ -102,38 +61,6 @@ static unsigned long *dirty_bitmap; > static Notifier suspend; > static Notifier wakeup; > > -typedef struct XenPciDevice { > - PCIDevice *pci_dev; > - uint32_t sbdf; > - QLIST_ENTRY(XenPciDevice) entry; > -} XenPciDevice; > - > -typedef struct XenIOState { > - ioservid_t ioservid; > - shared_iopage_t *shared_page; > - buffered_iopage_t *buffered_io_page; > - xenforeignmemory_resource_handle *fres; > - QEMUTimer *buffered_io_timer; > - CPUState **cpu_by_vcpu_id; > - /* the evtchn port for polling the notification, */ > - evtchn_port_t *ioreq_local_port; > - /* evtchn remote and local ports for buffered io */ > - evtchn_port_t bufioreq_remote_port; > - evtchn_port_t bufioreq_local_port; > - /* the evtchn fd for polling */ > - xenevtchn_handle *xce_handle; > - /* which vcpu we are serving */ > - int send_vcpu; > - > - struct xs_handle *xenstore; > - MemoryListener memory_listener; > - MemoryListener io_listener; > - QLIST_HEAD(, XenPciDevice) dev_list; > - DeviceListener device_listener; > - > - Notifier exit; > -} XenIOState; > - > /* Xen specific function for piix pci */ > > int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) > @@ -246,42 +173,6 @@ static void xen_ram_init(PCMachineState *pcms, > } > } > > -void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr, > - Error **errp) > -{ > - unsigned long nr_pfn; > - xen_pfn_t *pfn_list; > - int i; > - > - if (runstate_check(RUN_STATE_INMIGRATE)) { > - /* RAM already populated in Xen */ > - fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT > - " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n", > - __func__, size, ram_addr); > - return; > - } > - > - if (mr == &ram_memory) { > - return; > - } > - > - trace_xen_ram_alloc(ram_addr, size); > - > - nr_pfn = size >> TARGET_PAGE_BITS; > - pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn); > - > - for (i = 0; i < nr_pfn; i++) { > - pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i; > - } > - > - if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) { > - error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT, > - ram_addr); > - } > - > - g_free(pfn_list); > -} > - > static XenPhysmap *get_physmapping(hwaddr start_addr, ram_addr_t size) > { > XenPhysmap *physmap = NULL; > @@ -471,144 +362,6 @@ static int xen_remove_from_physmap(XenIOState *state, > return 0; > } > > -static void xen_set_memory(struct MemoryListener *listener, > - MemoryRegionSection *section, > - bool add) > -{ > - XenIOState *state = container_of(listener, XenIOState, memory_listener); > - hwaddr start_addr = section->offset_within_address_space; > - ram_addr_t size = int128_get64(section->size); > - bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA); > - hvmmem_type_t mem_type; > - > - if (section->mr == &ram_memory) { > - return; > - } else { > - if (add) { > - xen_map_memory_section(xen_domid, state->ioservid, > - section); > - } else { > - xen_unmap_memory_section(xen_domid, state->ioservid, > - section); > - } > - } > - > - if (!memory_region_is_ram(section->mr)) { > - return; > - } > - > - if (log_dirty != add) { > - return; > - } > - > - trace_xen_client_set_memory(start_addr, size, log_dirty); > - > - start_addr &= TARGET_PAGE_MASK; > - size = TARGET_PAGE_ALIGN(size); > - > - if (add) { > - if (!memory_region_is_rom(section->mr)) { > - xen_add_to_physmap(state, start_addr, size, > - section->mr, section->offset_within_region); > - } else { > - mem_type = HVMMEM_ram_ro; > - if (xen_set_mem_type(xen_domid, mem_type, > - start_addr >> TARGET_PAGE_BITS, > - size >> TARGET_PAGE_BITS)) { > - DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n", > - start_addr); > - } > - } > - } else { > - if (xen_remove_from_physmap(state, start_addr, size) < 0) { > - DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr); > - } > - } > -} > - > -static void xen_region_add(MemoryListener *listener, > - MemoryRegionSection *section) > -{ > - memory_region_ref(section->mr); > - xen_set_memory(listener, section, true); > -} > - > -static void xen_region_del(MemoryListener *listener, > - MemoryRegionSection *section) > -{ > - xen_set_memory(listener, section, false); > - memory_region_unref(section->mr); > -} > - > -static void xen_io_add(MemoryListener *listener, > - MemoryRegionSection *section) > -{ > - XenIOState *state = container_of(listener, XenIOState, io_listener); > - MemoryRegion *mr = section->mr; > - > - if (mr->ops == &unassigned_io_ops) { > - return; > - } > - > - memory_region_ref(mr); > - > - xen_map_io_section(xen_domid, state->ioservid, section); > -} > - > -static void xen_io_del(MemoryListener *listener, > - MemoryRegionSection *section) > -{ > - XenIOState *state = container_of(listener, XenIOState, io_listener); > - MemoryRegion *mr = section->mr; > - > - if (mr->ops == &unassigned_io_ops) { > - return; > - } > - > - xen_unmap_io_section(xen_domid, state->ioservid, section); > - > - memory_region_unref(mr); > -} > - > -static void xen_device_realize(DeviceListener *listener, > - DeviceState *dev) > -{ > - XenIOState *state = container_of(listener, XenIOState, device_listener); > - > - if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { > - PCIDevice *pci_dev = PCI_DEVICE(dev); > - XenPciDevice *xendev = g_new(XenPciDevice, 1); > - > - xendev->pci_dev = pci_dev; > - xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev), > - pci_dev->devfn); > - QLIST_INSERT_HEAD(&state->dev_list, xendev, entry); > - > - xen_map_pcidev(xen_domid, state->ioservid, pci_dev); > - } > -} > - > -static void xen_device_unrealize(DeviceListener *listener, > - DeviceState *dev) > -{ > - XenIOState *state = container_of(listener, XenIOState, device_listener); > - > - if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { > - PCIDevice *pci_dev = PCI_DEVICE(dev); > - XenPciDevice *xendev, *next; > - > - xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev); > - > - QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) { > - if (xendev->pci_dev == pci_dev) { > - QLIST_REMOVE(xendev, entry); > - g_free(xendev); > - break; > - } > - } > - } > -} > - > static void xen_sync_dirty_bitmap(XenIOState *state, > hwaddr start_addr, > ram_addr_t size) > @@ -716,277 +469,6 @@ static MemoryListener xen_memory_listener = { > .priority = 10, > }; > > -static MemoryListener xen_io_listener = { > - .name = "xen-io", > - .region_add = xen_io_add, > - .region_del = xen_io_del, > - .priority = 10, > -}; > - > -static DeviceListener xen_device_listener = { > - .realize = xen_device_realize, > - .unrealize = xen_device_unrealize, > -}; > - > -/* get the ioreq packets from share mem */ > -static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu) > -{ > - ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu); > - > - if (req->state != STATE_IOREQ_READY) { > - DPRINTF("I/O request not ready: " > - "%x, ptr: %x, port: %"PRIx64", " > - "data: %"PRIx64", count: %u, size: %u\n", > - req->state, req->data_is_ptr, req->addr, > - req->data, req->count, req->size); > - return NULL; > - } > - > - xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */ > - > - req->state = STATE_IOREQ_INPROCESS; > - return req; > -} > - > -/* use poll to get the port notification */ > -/* ioreq_vec--out,the */ > -/* retval--the number of ioreq packet */ > -static ioreq_t *cpu_get_ioreq(XenIOState *state) > -{ > - MachineState *ms = MACHINE(qdev_get_machine()); > - unsigned int max_cpus = ms->smp.max_cpus; > - int i; > - evtchn_port_t port; > - > - port = xenevtchn_pending(state->xce_handle); > - if (port == state->bufioreq_local_port) { > - timer_mod(state->buffered_io_timer, > - BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); > - return NULL; > - } > - > - if (port != -1) { > - for (i = 0; i < max_cpus; i++) { > - if (state->ioreq_local_port[i] == port) { > - break; > - } > - } > - > - if (i == max_cpus) { > - hw_error("Fatal error while trying to get io event!\n"); > - } > - > - /* unmask the wanted port again */ > - xenevtchn_unmask(state->xce_handle, port); > - > - /* get the io packet from shared memory */ > - state->send_vcpu = i; > - return cpu_get_ioreq_from_shared_memory(state, i); > - } > - > - /* read error or read nothing */ > - return NULL; > -} > - > -static uint32_t do_inp(uint32_t addr, unsigned long size) > -{ > - switch (size) { > - case 1: > - return cpu_inb(addr); > - case 2: > - return cpu_inw(addr); > - case 4: > - return cpu_inl(addr); > - default: > - hw_error("inp: bad size: %04x %lx", addr, size); > - } > -} > - > -static void do_outp(uint32_t addr, > - unsigned long size, uint32_t val) > -{ > - switch (size) { > - case 1: > - return cpu_outb(addr, val); > - case 2: > - return cpu_outw(addr, val); > - case 4: > - return cpu_outl(addr, val); > - default: > - hw_error("outp: bad size: %04x %lx", addr, size); > - } > -} > - > -/* > - * Helper functions which read/write an object from/to physical guest > - * memory, as part of the implementation of an ioreq. > - * > - * Equivalent to > - * cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i, > - * val, req->size, 0/1) > - * except without the integer overflow problems. > - */ > -static void rw_phys_req_item(hwaddr addr, > - ioreq_t *req, uint32_t i, void *val, int rw) > -{ > - /* Do everything unsigned so overflow just results in a truncated result > - * and accesses to undesired parts of guest memory, which is up > - * to the guest */ > - hwaddr offset = (hwaddr)req->size * i; > - if (req->df) { > - addr -= offset; > - } else { > - addr += offset; > - } > - cpu_physical_memory_rw(addr, val, req->size, rw); > -} > - > -static inline void read_phys_req_item(hwaddr addr, > - ioreq_t *req, uint32_t i, void *val) > -{ > - rw_phys_req_item(addr, req, i, val, 0); > -} > -static inline void write_phys_req_item(hwaddr addr, > - ioreq_t *req, uint32_t i, void *val) > -{ > - rw_phys_req_item(addr, req, i, val, 1); > -} > - > - > -static void cpu_ioreq_pio(ioreq_t *req) > -{ > - uint32_t i; > - > - trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr, > - req->data, req->count, req->size); > - > - if (req->size > sizeof(uint32_t)) { > - hw_error("PIO: bad size (%u)", req->size); > - } > - > - if (req->dir == IOREQ_READ) { > - if (!req->data_is_ptr) { > - req->data = do_inp(req->addr, req->size); > - trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr, > - req->size); > - } else { > - uint32_t tmp; > - > - for (i = 0; i < req->count; i++) { > - tmp = do_inp(req->addr, req->size); > - write_phys_req_item(req->data, req, i, &tmp); > - } > - } > - } else if (req->dir == IOREQ_WRITE) { > - if (!req->data_is_ptr) { > - trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr, > - req->size); > - do_outp(req->addr, req->size, req->data); > - } else { > - for (i = 0; i < req->count; i++) { > - uint32_t tmp = 0; > - > - read_phys_req_item(req->data, req, i, &tmp); > - do_outp(req->addr, req->size, tmp); > - } > - } > - } > -} > - > -static void cpu_ioreq_move(ioreq_t *req) > -{ > - uint32_t i; > - > - trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr, > - req->data, req->count, req->size); > - > - if (req->size > sizeof(req->data)) { > - hw_error("MMIO: bad size (%u)", req->size); > - } > - > - if (!req->data_is_ptr) { > - if (req->dir == IOREQ_READ) { > - for (i = 0; i < req->count; i++) { > - read_phys_req_item(req->addr, req, i, &req->data); > - } > - } else if (req->dir == IOREQ_WRITE) { > - for (i = 0; i < req->count; i++) { > - write_phys_req_item(req->addr, req, i, &req->data); > - } > - } > - } else { > - uint64_t tmp; > - > - if (req->dir == IOREQ_READ) { > - for (i = 0; i < req->count; i++) { > - read_phys_req_item(req->addr, req, i, &tmp); > - write_phys_req_item(req->data, req, i, &tmp); > - } > - } else if (req->dir == IOREQ_WRITE) { > - for (i = 0; i < req->count; i++) { > - read_phys_req_item(req->data, req, i, &tmp); > - write_phys_req_item(req->addr, req, i, &tmp); > - } > - } > - } > -} > - > -static void cpu_ioreq_config(XenIOState *state, ioreq_t *req) > -{ > - uint32_t sbdf = req->addr >> 32; > - uint32_t reg = req->addr; > - XenPciDevice *xendev; > - > - if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) && > - req->size != sizeof(uint32_t)) { > - hw_error("PCI config access: bad size (%u)", req->size); > - } > - > - if (req->count != 1) { > - hw_error("PCI config access: bad count (%u)", req->count); > - } > - > - QLIST_FOREACH(xendev, &state->dev_list, entry) { > - if (xendev->sbdf != sbdf) { > - continue; > - } > - > - if (!req->data_is_ptr) { > - if (req->dir == IOREQ_READ) { > - req->data = pci_host_config_read_common( > - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > - req->size); > - trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, > - req->size, req->data); > - } else if (req->dir == IOREQ_WRITE) { > - trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, > - req->size, req->data); > - pci_host_config_write_common( > - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > - req->data, req->size); > - } > - } else { > - uint32_t tmp; > - > - if (req->dir == IOREQ_READ) { > - tmp = pci_host_config_read_common( > - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > - req->size); > - trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, > - req->size, tmp); > - write_phys_req_item(req->data, req, 0, &tmp); > - } else if (req->dir == IOREQ_WRITE) { > - read_phys_req_item(req->data, req, 0, &tmp); > - trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, > - req->size, tmp); > - pci_host_config_write_common( > - xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > - tmp, req->size); > - } > - } > - } > -} > - > static void regs_to_cpu(vmware_regs_t *vmport_regs, ioreq_t *req) > { > X86CPU *cpu; > @@ -1030,226 +512,6 @@ static void handle_vmport_ioreq(XenIOState *state, ioreq_t *req) > current_cpu = NULL; > } > > -static void handle_ioreq(XenIOState *state, ioreq_t *req) > -{ > - trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr, > - req->addr, req->data, req->count, req->size); > - > - if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) && > - (req->size < sizeof (target_ulong))) { > - req->data &= ((target_ulong) 1 << (8 * req->size)) - 1; > - } > - > - if (req->dir == IOREQ_WRITE) > - trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr, > - req->addr, req->data, req->count, req->size); > - > - switch (req->type) { > - case IOREQ_TYPE_PIO: > - cpu_ioreq_pio(req); > - break; > - case IOREQ_TYPE_COPY: > - cpu_ioreq_move(req); > - break; > - case IOREQ_TYPE_VMWARE_PORT: > - handle_vmport_ioreq(state, req); > - break; > - case IOREQ_TYPE_TIMEOFFSET: > - break; > - case IOREQ_TYPE_INVALIDATE: > - xen_invalidate_map_cache(); > - break; > - case IOREQ_TYPE_PCI_CONFIG: > - cpu_ioreq_config(state, req); > - break; > - default: > - hw_error("Invalid ioreq type 0x%x\n", req->type); > - } > - if (req->dir == IOREQ_READ) { > - trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr, > - req->addr, req->data, req->count, req->size); > - } > -} > - > -static bool handle_buffered_iopage(XenIOState *state) > -{ > - buffered_iopage_t *buf_page = state->buffered_io_page; > - buf_ioreq_t *buf_req = NULL; > - bool handled_ioreq = false; > - ioreq_t req; > - int qw; > - > - if (!buf_page) { > - return 0; > - } > - > - memset(&req, 0x00, sizeof(req)); > - req.state = STATE_IOREQ_READY; > - req.count = 1; > - req.dir = IOREQ_WRITE; > - > - for (;;) { > - uint32_t rdptr = buf_page->read_pointer, wrptr; > - > - xen_rmb(); > - wrptr = buf_page->write_pointer; > - xen_rmb(); > - if (rdptr != buf_page->read_pointer) { > - continue; > - } > - if (rdptr == wrptr) { > - break; > - } > - buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM]; > - req.size = 1U << buf_req->size; > - req.addr = buf_req->addr; > - req.data = buf_req->data; > - req.type = buf_req->type; > - xen_rmb(); > - qw = (req.size == 8); > - if (qw) { > - if (rdptr + 1 == wrptr) { > - hw_error("Incomplete quad word buffered ioreq"); > - } > - buf_req = &buf_page->buf_ioreq[(rdptr + 1) % > - IOREQ_BUFFER_SLOT_NUM]; > - req.data |= ((uint64_t)buf_req->data) << 32; > - xen_rmb(); > - } > - > - handle_ioreq(state, &req); > - > - /* Only req.data may get updated by handle_ioreq(), albeit even that > - * should not happen as such data would never make it to the guest (we > - * can only usefully see writes here after all). > - */ > - assert(req.state == STATE_IOREQ_READY); > - assert(req.count == 1); > - assert(req.dir == IOREQ_WRITE); > - assert(!req.data_is_ptr); > - > - qatomic_add(&buf_page->read_pointer, qw + 1); > - handled_ioreq = true; > - } > - > - return handled_ioreq; > -} > - > -static void handle_buffered_io(void *opaque) > -{ > - XenIOState *state = opaque; > - > - if (handle_buffered_iopage(state)) { > - timer_mod(state->buffered_io_timer, > - BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); > - } else { > - timer_del(state->buffered_io_timer); > - xenevtchn_unmask(state->xce_handle, state->bufioreq_local_port); > - } > -} > - > -static void cpu_handle_ioreq(void *opaque) > -{ > - XenIOState *state = opaque; > - ioreq_t *req = cpu_get_ioreq(state); > - > - handle_buffered_iopage(state); > - if (req) { > - ioreq_t copy = *req; > - > - xen_rmb(); > - handle_ioreq(state, ©); > - req->data = copy.data; > - > - if (req->state != STATE_IOREQ_INPROCESS) { > - fprintf(stderr, "Badness in I/O request ... not in service?!: " > - "%x, ptr: %x, port: %"PRIx64", " > - "data: %"PRIx64", count: %u, size: %u, type: %u\n", > - req->state, req->data_is_ptr, req->addr, > - req->data, req->count, req->size, req->type); > - destroy_hvm_domain(false); > - return; > - } > - > - xen_wmb(); /* Update ioreq contents /then/ update state. */ > - > - /* > - * We do this before we send the response so that the tools > - * have the opportunity to pick up on the reset before the > - * guest resumes and does a hlt with interrupts disabled which > - * causes Xen to powerdown the domain. > - */ > - if (runstate_is_running()) { > - ShutdownCause request; > - > - if (qemu_shutdown_requested_get()) { > - destroy_hvm_domain(false); > - } > - request = qemu_reset_requested_get(); > - if (request) { > - qemu_system_reset(request); > - destroy_hvm_domain(true); > - } > - } > - > - req->state = STATE_IORESP_READY; > - xenevtchn_notify(state->xce_handle, > - state->ioreq_local_port[state->send_vcpu]); > - } > -} > - > -static void xen_main_loop_prepare(XenIOState *state) > -{ > - int evtchn_fd = -1; > - > - if (state->xce_handle != NULL) { > - evtchn_fd = xenevtchn_fd(state->xce_handle); > - } > - > - state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io, > - state); > - > - if (evtchn_fd != -1) { > - CPUState *cpu_state; > - > - DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__); > - CPU_FOREACH(cpu_state) { > - DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n", > - __func__, cpu_state->cpu_index, cpu_state); > - state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state; > - } > - qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state); > - } > -} > - > - > -static void xen_hvm_change_state_handler(void *opaque, bool running, > - RunState rstate) > -{ > - XenIOState *state = opaque; > - > - if (running) { > - xen_main_loop_prepare(state); > - } > - > - xen_set_ioreq_server_state(xen_domid, > - state->ioservid, > - (rstate == RUN_STATE_RUNNING)); > -} > - > -static void xen_exit_notifier(Notifier *n, void *data) > -{ > - XenIOState *state = container_of(n, XenIOState, exit); > - > - xen_destroy_ioreq_server(xen_domid, state->ioservid); > - if (state->fres != NULL) { > - xenforeignmemory_unmap_resource(xen_fmem, state->fres); > - } > - > - xenevtchn_close(state->xce_handle); > - xs_daemon_close(state->xenstore); > -} > - > #ifdef XEN_COMPAT_PHYSMAP > static void xen_read_physmap(XenIOState *state) > { > @@ -1309,178 +571,17 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data) > xc_set_hvm_param(xen_xc, xen_domid, HVM_PARAM_ACPI_S_STATE, 0); > } > > -static int xen_map_ioreq_server(XenIOState *state) > -{ > - void *addr = NULL; > - xen_pfn_t ioreq_pfn; > - xen_pfn_t bufioreq_pfn; > - evtchn_port_t bufioreq_evtchn; > - int rc; > - > - /* > - * Attempt to map using the resource API and fall back to normal > - * foreign mapping if this is not supported. > - */ > - QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0); > - QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1); > - state->fres = xenforeignmemory_map_resource(xen_fmem, xen_domid, > - XENMEM_resource_ioreq_server, > - state->ioservid, 0, 2, > - &addr, > - PROT_READ | PROT_WRITE, 0); > - if (state->fres != NULL) { > - trace_xen_map_resource_ioreq(state->ioservid, addr); > - state->buffered_io_page = addr; > - state->shared_page = addr + TARGET_PAGE_SIZE; > - } else if (errno != EOPNOTSUPP) { > - error_report("failed to map ioreq server resources: error %d handle=%p", > - errno, xen_xc); > - return -1; > - } > - > - rc = xen_get_ioreq_server_info(xen_domid, state->ioservid, > - (state->shared_page == NULL) ? > - &ioreq_pfn : NULL, > - (state->buffered_io_page == NULL) ? > - &bufioreq_pfn : NULL, > - &bufioreq_evtchn); > - if (rc < 0) { > - error_report("failed to get ioreq server info: error %d handle=%p", > - errno, xen_xc); > - return rc; > - } > - > - if (state->shared_page == NULL) { > - DPRINTF("shared page at pfn %lx\n", ioreq_pfn); > - > - state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid, > - PROT_READ | PROT_WRITE, > - 1, &ioreq_pfn, NULL); > - if (state->shared_page == NULL) { > - error_report("map shared IO page returned error %d handle=%p", > - errno, xen_xc); > - } > - } > - > - if (state->buffered_io_page == NULL) { > - DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn); > - > - state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid, > - PROT_READ | PROT_WRITE, > - 1, &bufioreq_pfn, > - NULL); > - if (state->buffered_io_page == NULL) { > - error_report("map buffered IO page returned error %d", errno); > - return -1; > - } > - } > - > - if (state->shared_page == NULL || state->buffered_io_page == NULL) { > - return -1; > - } > - > - DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn); > - > - state->bufioreq_remote_port = bufioreq_evtchn; > - > - return 0; > -} > - > void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion **ram_memory) > { > MachineState *ms = MACHINE(pcms); > unsigned int max_cpus = ms->smp.max_cpus; > - int i, rc; > + int rc; > xen_pfn_t ioreq_pfn; > XenIOState *state; > > state = g_new0(XenIOState, 1); > > - state->xce_handle = xenevtchn_open(NULL, 0); > - if (state->xce_handle == NULL) { > - perror("xen: event channel open"); > - goto err; > - } > - > - state->xenstore = xs_daemon_open(); > - if (state->xenstore == NULL) { > - perror("xen: xenstore open"); > - goto err; > - } > - > - xen_create_ioreq_server(xen_domid, &state->ioservid); > - > - state->exit.notify = xen_exit_notifier; > - qemu_add_exit_notifier(&state->exit); > - > - /* > - * Register wake-up support in QMP query-current-machine API > - */ > - qemu_register_wakeup_support(); > - > - rc = xen_map_ioreq_server(state); > - if (rc < 0) { > - goto err; > - } > - > - /* Note: cpus is empty at this point in init */ > - state->cpu_by_vcpu_id = g_new0(CPUState *, max_cpus); > - > - rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true); > - if (rc < 0) { > - error_report("failed to enable ioreq server info: error %d handle=%p", > - errno, xen_xc); > - goto err; > - } > - > - state->ioreq_local_port = g_new0(evtchn_port_t, max_cpus); > - > - /* FIXME: how about if we overflow the page here? */ > - for (i = 0; i < max_cpus; i++) { > - rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid, > - xen_vcpu_eport(state->shared_page, i)); > - if (rc == -1) { > - error_report("shared evtchn %d bind error %d", i, errno); > - goto err; > - } > - state->ioreq_local_port[i] = rc; > - } > - > - rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid, > - state->bufioreq_remote_port); > - if (rc == -1) { > - error_report("buffered evtchn bind error %d", errno); > - goto err; > - } > - state->bufioreq_local_port = rc; > - > - /* Init RAM management */ > -#ifdef XEN_COMPAT_PHYSMAP > - xen_map_cache_init(xen_phys_offset_to_gaddr, state); > -#else > - xen_map_cache_init(NULL, state); > -#endif > - > - qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); > - > - state->memory_listener = xen_memory_listener; > - memory_listener_register(&state->memory_listener, &address_space_memory); > - > - state->io_listener = xen_io_listener; > - memory_listener_register(&state->io_listener, &address_space_io); > - > - state->device_listener = xen_device_listener; > - QLIST_INIT(&state->dev_list); > - device_listener_register(&state->device_listener); > - > - xen_bus_init(); > - > - /* Initialize backend core & drivers */ > - if (xen_be_init() != 0) { > - error_report("xen backend core setup failed"); > - goto err; > - } > - xen_be_register_common(); > + xen_register_ioreq(state, max_cpus, xen_memory_listener); > > QLIST_INIT(&xen_physmap); > xen_read_physmap(state); > @@ -1520,59 +621,11 @@ err: > exit(1); > } > > -void destroy_hvm_domain(bool reboot) > -{ > - xc_interface *xc_handle; > - int sts; > - int rc; > - > - unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff; > - > - if (xen_dmod) { > - rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason); > - if (!rc) { > - return; > - } > - if (errno != ENOTTY /* old Xen */) { > - perror("xendevicemodel_shutdown failed"); > - } > - /* well, try the old thing then */ > - } > - > - xc_handle = xc_interface_open(0, 0, 0); > - if (xc_handle == NULL) { > - fprintf(stderr, "Cannot acquire xenctrl handle\n"); > - } else { > - sts = xc_domain_shutdown(xc_handle, xen_domid, reason); > - if (sts != 0) { > - fprintf(stderr, "xc_domain_shutdown failed to issue %s, " > - "sts %d, %s\n", reboot ? "reboot" : "poweroff", > - sts, strerror(errno)); > - } else { > - fprintf(stderr, "Issued domain %d %s\n", xen_domid, > - reboot ? "reboot" : "poweroff"); > - } > - xc_interface_close(xc_handle); > - } > -} > - > void xen_register_framebuffer(MemoryRegion *mr) > { > framebuffer = mr; > } > > -void xen_shutdown_fatal_error(const char *fmt, ...) > -{ > - va_list ap; > - > - va_start(ap, fmt); > - vfprintf(stderr, fmt, ap); > - va_end(ap); > - fprintf(stderr, "Will destroy the domain.\n"); > - /* destroy the domain */ > - qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR); > -} > - > void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) > { > if (unlikely(xen_in_migration)) { > @@ -1604,3 +657,57 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp) > memory_global_dirty_log_stop(GLOBAL_DIRTY_MIGRATION); > } > } > + > +void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section, > + bool add) > +{ > + hwaddr start_addr = section->offset_within_address_space; > + ram_addr_t size = int128_get64(section->size); > + bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA); > + hvmmem_type_t mem_type; > + > + if (!memory_region_is_ram(section->mr)) { > + return; > + } > + > + if (log_dirty != add) { > + return; > + } > + > + trace_xen_client_set_memory(start_addr, size, log_dirty); > + > + start_addr &= TARGET_PAGE_MASK; > + size = TARGET_PAGE_ALIGN(size); > + > + if (add) { > + if (!memory_region_is_rom(section->mr)) { > + xen_add_to_physmap(state, start_addr, size, > + section->mr, section->offset_within_region); > + } else { > + mem_type = HVMMEM_ram_ro; > + if (xen_set_mem_type(xen_domid, mem_type, > + start_addr >> TARGET_PAGE_BITS, > + size >> TARGET_PAGE_BITS)) { > + DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n", > + start_addr); > + } > + } > + } else { > + if (xen_remove_from_physmap(state, start_addr, size) < 0) { > + DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr); > + } > + } > +} > + > +void arch_handle_ioreq(XenIOState *state, ioreq_t *req) > +{ > + switch (req->type) { > + case IOREQ_TYPE_VMWARE_PORT: > + handle_vmport_ioreq(state, req); > + break; > + default: > + hw_error("Invalid ioreq type 0x%x\n", req->type); > + } > + > + return; > +} > diff --git a/hw/xen/meson.build b/hw/xen/meson.build > index 19d0637c46..008e036d63 100644 > --- a/hw/xen/meson.build > +++ b/hw/xen/meson.build > @@ -25,4 +25,7 @@ specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss) > > xen_ss = ss.source_set() > > -xen_ss.add(when: 'CONFIG_XEN', if_true: files('xen-mapcache.c')) > +xen_ss.add(when: 'CONFIG_XEN', if_true: files( > + 'xen-mapcache.c', > + 'xen-hvm-common.c', > +)) > diff --git a/hw/xen/trace-events b/hw/xen/trace-events > index 2c8f238f42..02ca1183da 100644 > --- a/hw/xen/trace-events > +++ b/hw/xen/trace-events > @@ -42,6 +42,20 @@ xs_node_vscanf(char *path, char *value) "%s %s" > xs_node_watch(char *path) "%s" > xs_node_unwatch(char *path) "%s" > > +# xen-hvm.c > +xen_ram_alloc(unsigned long ram_addr, unsigned long size) "requested: 0x%lx, size 0x%lx" > +xen_client_set_memory(uint64_t start_addr, unsigned long size, bool log_dirty) "0x%"PRIx64" size 0x%lx, log_dirty %i" > +handle_ioreq(void *req, uint32_t type, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p type=%d dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > +handle_ioreq_read(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p read type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > +handle_ioreq_write(void *req, uint32_t type, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p write type=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > +cpu_ioreq_pio(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p pio dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > +cpu_ioreq_pio_read_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio read reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" > +cpu_ioreq_pio_write_reg(void *req, uint64_t data, uint64_t addr, uint32_t size) "I/O=%p pio write reg data=0x%"PRIx64" port=0x%"PRIx64" size=%d" > +cpu_ioreq_move(void *req, uint32_t dir, uint32_t df, uint32_t data_is_ptr, uint64_t addr, uint64_t data, uint32_t count, uint32_t size) "I/O=%p copy dir=%d df=%d ptr=%d port=0x%"PRIx64" data=0x%"PRIx64" count=%d size=%d" > +xen_map_resource_ioreq(uint32_t id, void *addr) "id: %u addr: %p" > +cpu_ioreq_config_read(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" > +cpu_ioreq_config_write(void *req, uint32_t sbdf, uint32_t reg, uint32_t size, uint32_t data) "I/O=%p sbdf=0x%x reg=%u size=%u data=0x%x" > + > # xen-mapcache.c > xen_map_cache(uint64_t phys_addr) "want 0x%"PRIx64 > xen_remap_bucket(uint64_t index) "index 0x%"PRIx64 > diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c > new file mode 100644 > index 0000000000..c2e1e08124 > --- /dev/null > +++ b/hw/xen/xen-hvm-common.c > @@ -0,0 +1,874 @@ > +#include "qemu/osdep.h" > +#include "qemu/units.h" > +#include "qapi/error.h" > +#include "trace.h" > + > +#include "hw/pci/pci_host.h" > +#include "hw/xen/xen-hvm-common.h" > +#include "hw/xen/xen-legacy-backend.h" > +#include "hw/xen/xen-bus.h" > +#include "hw/boards.h" > +#include "hw/xen/arch_hvm.h" > + > +MemoryRegion ram_memory; > + > +void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr, > + Error **errp) > +{ > + unsigned long nr_pfn; > + xen_pfn_t *pfn_list; > + int i; > + > + if (runstate_check(RUN_STATE_INMIGRATE)) { > + /* RAM already populated in Xen */ > + fprintf(stderr, "%s: do not alloc "RAM_ADDR_FMT > + " bytes of ram at "RAM_ADDR_FMT" when runstate is INMIGRATE\n", > + __func__, size, ram_addr); > + return; > + } > + > + if (mr == &ram_memory) { > + return; > + } > + > + trace_xen_ram_alloc(ram_addr, size); > + > + nr_pfn = size >> TARGET_PAGE_BITS; > + pfn_list = g_malloc(sizeof (*pfn_list) * nr_pfn); > + > + for (i = 0; i < nr_pfn; i++) { > + pfn_list[i] = (ram_addr >> TARGET_PAGE_BITS) + i; > + } > + > + if (xc_domain_populate_physmap_exact(xen_xc, xen_domid, nr_pfn, 0, 0, pfn_list)) { > + error_setg(errp, "xen: failed to populate ram at " RAM_ADDR_FMT, > + ram_addr); > + } > + > + g_free(pfn_list); > +} > + > +static void xen_set_memory(struct MemoryListener *listener, > + MemoryRegionSection *section, > + bool add) > +{ > + XenIOState *state = container_of(listener, XenIOState, memory_listener); > + > + if (section->mr == &ram_memory) { > + return; > + } else { > + if (add) { > + xen_map_memory_section(xen_domid, state->ioservid, > + section); > + } else { > + xen_unmap_memory_section(xen_domid, state->ioservid, > + section); > + } > + } > + > + arch_xen_set_memory(state, section, add); > +} > + > +void xen_region_add(MemoryListener *listener, > + MemoryRegionSection *section) > +{ > + memory_region_ref(section->mr); > + xen_set_memory(listener, section, true); > +} > + > +void xen_region_del(MemoryListener *listener, > + MemoryRegionSection *section) > +{ > + xen_set_memory(listener, section, false); > + memory_region_unref(section->mr); > +} > + > +void xen_io_add(MemoryListener *listener, > + MemoryRegionSection *section) > +{ > + XenIOState *state = container_of(listener, XenIOState, io_listener); > + MemoryRegion *mr = section->mr; > + > + if (mr->ops == &unassigned_io_ops) { > + return; > + } > + > + memory_region_ref(mr); > + > + xen_map_io_section(xen_domid, state->ioservid, section); > +} > + > +void xen_io_del(MemoryListener *listener, > + MemoryRegionSection *section) > +{ > + XenIOState *state = container_of(listener, XenIOState, io_listener); > + MemoryRegion *mr = section->mr; > + > + if (mr->ops == &unassigned_io_ops) { > + return; > + } > + > + xen_unmap_io_section(xen_domid, state->ioservid, section); > + > + memory_region_unref(mr); > +} > + > +void xen_device_realize(DeviceListener *listener, > + DeviceState *dev) > +{ > + XenIOState *state = container_of(listener, XenIOState, device_listener); > + > + if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { > + PCIDevice *pci_dev = PCI_DEVICE(dev); > + XenPciDevice *xendev = g_new(XenPciDevice, 1); > + > + xendev->pci_dev = pci_dev; > + xendev->sbdf = PCI_BUILD_BDF(pci_dev_bus_num(pci_dev), > + pci_dev->devfn); > + QLIST_INSERT_HEAD(&state->dev_list, xendev, entry); > + > + xen_map_pcidev(xen_domid, state->ioservid, pci_dev); > + } > +} > + > +void xen_device_unrealize(DeviceListener *listener, > + DeviceState *dev) > +{ > + XenIOState *state = container_of(listener, XenIOState, device_listener); > + > + if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) { > + PCIDevice *pci_dev = PCI_DEVICE(dev); > + XenPciDevice *xendev, *next; > + > + xen_unmap_pcidev(xen_domid, state->ioservid, pci_dev); > + > + QLIST_FOREACH_SAFE(xendev, &state->dev_list, entry, next) { > + if (xendev->pci_dev == pci_dev) { > + QLIST_REMOVE(xendev, entry); > + g_free(xendev); > + break; > + } > + } > + } > +} > + > +MemoryListener xen_io_listener = { > + .name = "xen-io", > + .region_add = xen_io_add, > + .region_del = xen_io_del, > + .priority = 10, > +}; > + > +DeviceListener xen_device_listener = { > + .realize = xen_device_realize, > + .unrealize = xen_device_unrealize, > +}; > + > +/* get the ioreq packets from share mem */ > +static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu) > +{ > + ioreq_t *req = xen_vcpu_ioreq(state->shared_page, vcpu); > + > + if (req->state != STATE_IOREQ_READY) { > + DPRINTF("I/O request not ready: " > + "%x, ptr: %x, port: %"PRIx64", " > + "data: %"PRIx64", count: %u, size: %u\n", > + req->state, req->data_is_ptr, req->addr, > + req->data, req->count, req->size); > + return NULL; > + } > + > + xen_rmb(); /* see IOREQ_READY /then/ read contents of ioreq */ > + > + req->state = STATE_IOREQ_INPROCESS; > + return req; > +} > + > +/* use poll to get the port notification */ > +/* ioreq_vec--out,the */ > +/* retval--the number of ioreq packet */ > +static ioreq_t *cpu_get_ioreq(XenIOState *state) > +{ > + MachineState *ms = MACHINE(qdev_get_machine()); > + unsigned int max_cpus = ms->smp.max_cpus; > + int i; > + evtchn_port_t port; > + > + port = xenevtchn_pending(state->xce_handle); > + if (port == state->bufioreq_local_port) { > + timer_mod(state->buffered_io_timer, > + BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); > + return NULL; > + } > + > + if (port != -1) { > + for (i = 0; i < max_cpus; i++) { > + if (state->ioreq_local_port[i] == port) { > + break; > + } > + } > + > + if (i == max_cpus) { > + hw_error("Fatal error while trying to get io event!\n"); > + } > + > + /* unmask the wanted port again */ > + xenevtchn_unmask(state->xce_handle, port); > + > + /* get the io packet from shared memory */ > + state->send_vcpu = i; > + return cpu_get_ioreq_from_shared_memory(state, i); > + } > + > + /* read error or read nothing */ > + return NULL; > +} > + > +static uint32_t do_inp(uint32_t addr, unsigned long size) > +{ > + switch (size) { > + case 1: > + return cpu_inb(addr); > + case 2: > + return cpu_inw(addr); > + case 4: > + return cpu_inl(addr); > + default: > + hw_error("inp: bad size: %04x %lx", addr, size); > + } > +} > + > +static void do_outp(uint32_t addr, > + unsigned long size, uint32_t val) > +{ > + switch (size) { > + case 1: > + return cpu_outb(addr, val); > + case 2: > + return cpu_outw(addr, val); > + case 4: > + return cpu_outl(addr, val); > + default: > + hw_error("outp: bad size: %04x %lx", addr, size); > + } > +} > + > +/* > + * Helper functions which read/write an object from/to physical guest > + * memory, as part of the implementation of an ioreq. > + * > + * Equivalent to > + * cpu_physical_memory_rw(addr + (req->df ? -1 : +1) * req->size * i, > + * val, req->size, 0/1) > + * except without the integer overflow problems. > + */ > +static void rw_phys_req_item(hwaddr addr, > + ioreq_t *req, uint32_t i, void *val, int rw) > +{ > + /* Do everything unsigned so overflow just results in a truncated result > + * and accesses to undesired parts of guest memory, which is up > + * to the guest */ > + hwaddr offset = (hwaddr)req->size * i; > + if (req->df) { > + addr -= offset; > + } else { > + addr += offset; > + } > + cpu_physical_memory_rw(addr, val, req->size, rw); > +} > + > +static inline void read_phys_req_item(hwaddr addr, > + ioreq_t *req, uint32_t i, void *val) > +{ > + rw_phys_req_item(addr, req, i, val, 0); > +} > +static inline void write_phys_req_item(hwaddr addr, > + ioreq_t *req, uint32_t i, void *val) > +{ > + rw_phys_req_item(addr, req, i, val, 1); > +} > + > + > +void cpu_ioreq_pio(ioreq_t *req) > +{ > + uint32_t i; > + > + trace_cpu_ioreq_pio(req, req->dir, req->df, req->data_is_ptr, req->addr, > + req->data, req->count, req->size); > + > + if (req->size > sizeof(uint32_t)) { > + hw_error("PIO: bad size (%u)", req->size); > + } > + > + if (req->dir == IOREQ_READ) { > + if (!req->data_is_ptr) { > + req->data = do_inp(req->addr, req->size); > + trace_cpu_ioreq_pio_read_reg(req, req->data, req->addr, > + req->size); > + } else { > + uint32_t tmp; > + > + for (i = 0; i < req->count; i++) { > + tmp = do_inp(req->addr, req->size); > + write_phys_req_item(req->data, req, i, &tmp); > + } > + } > + } else if (req->dir == IOREQ_WRITE) { > + if (!req->data_is_ptr) { > + trace_cpu_ioreq_pio_write_reg(req, req->data, req->addr, > + req->size); > + do_outp(req->addr, req->size, req->data); > + } else { > + for (i = 0; i < req->count; i++) { > + uint32_t tmp = 0; > + > + read_phys_req_item(req->data, req, i, &tmp); > + do_outp(req->addr, req->size, tmp); > + } > + } > + } > +} > + > +static void cpu_ioreq_move(ioreq_t *req) > +{ > + uint32_t i; > + > + trace_cpu_ioreq_move(req, req->dir, req->df, req->data_is_ptr, req->addr, > + req->data, req->count, req->size); > + > + if (req->size > sizeof(req->data)) { > + hw_error("MMIO: bad size (%u)", req->size); > + } > + > + if (!req->data_is_ptr) { > + if (req->dir == IOREQ_READ) { > + for (i = 0; i < req->count; i++) { > + read_phys_req_item(req->addr, req, i, &req->data); > + } > + } else if (req->dir == IOREQ_WRITE) { > + for (i = 0; i < req->count; i++) { > + write_phys_req_item(req->addr, req, i, &req->data); > + } > + } > + } else { > + uint64_t tmp; > + > + if (req->dir == IOREQ_READ) { > + for (i = 0; i < req->count; i++) { > + read_phys_req_item(req->addr, req, i, &tmp); > + write_phys_req_item(req->data, req, i, &tmp); > + } > + } else if (req->dir == IOREQ_WRITE) { > + for (i = 0; i < req->count; i++) { > + read_phys_req_item(req->data, req, i, &tmp); > + write_phys_req_item(req->addr, req, i, &tmp); > + } > + } > + } > +} > + > +static void cpu_ioreq_config(XenIOState *state, ioreq_t *req) > +{ > + uint32_t sbdf = req->addr >> 32; > + uint32_t reg = req->addr; > + XenPciDevice *xendev; > + > + if (req->size != sizeof(uint8_t) && req->size != sizeof(uint16_t) && > + req->size != sizeof(uint32_t)) { > + hw_error("PCI config access: bad size (%u)", req->size); > + } > + > + if (req->count != 1) { > + hw_error("PCI config access: bad count (%u)", req->count); > + } > + > + QLIST_FOREACH(xendev, &state->dev_list, entry) { > + if (xendev->sbdf != sbdf) { > + continue; > + } > + > + if (!req->data_is_ptr) { > + if (req->dir == IOREQ_READ) { > + req->data = pci_host_config_read_common( > + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > + req->size); > + trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, > + req->size, req->data); > + } else if (req->dir == IOREQ_WRITE) { > + trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, > + req->size, req->data); > + pci_host_config_write_common( > + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > + req->data, req->size); > + } > + } else { > + uint32_t tmp; > + > + if (req->dir == IOREQ_READ) { > + tmp = pci_host_config_read_common( > + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > + req->size); > + trace_cpu_ioreq_config_read(req, xendev->sbdf, reg, > + req->size, tmp); > + write_phys_req_item(req->data, req, 0, &tmp); > + } else if (req->dir == IOREQ_WRITE) { > + read_phys_req_item(req->data, req, 0, &tmp); > + trace_cpu_ioreq_config_write(req, xendev->sbdf, reg, > + req->size, tmp); > + pci_host_config_write_common( > + xendev->pci_dev, reg, PCI_CONFIG_SPACE_SIZE, > + tmp, req->size); > + } > + } > + } > +} > + > +static void handle_ioreq(XenIOState *state, ioreq_t *req) > +{ > + trace_handle_ioreq(req, req->type, req->dir, req->df, req->data_is_ptr, > + req->addr, req->data, req->count, req->size); > + > + if (!req->data_is_ptr && (req->dir == IOREQ_WRITE) && > + (req->size < sizeof (target_ulong))) { > + req->data &= ((target_ulong) 1 << (8 * req->size)) - 1; > + } > + > + if (req->dir == IOREQ_WRITE) > + trace_handle_ioreq_write(req, req->type, req->df, req->data_is_ptr, > + req->addr, req->data, req->count, req->size); > + > + switch (req->type) { > + case IOREQ_TYPE_PIO: > + cpu_ioreq_pio(req); > + break; > + case IOREQ_TYPE_COPY: > + cpu_ioreq_move(req); > + break; > + case IOREQ_TYPE_TIMEOFFSET: > + break; > + case IOREQ_TYPE_INVALIDATE: > + xen_invalidate_map_cache(); > + break; > + case IOREQ_TYPE_PCI_CONFIG: > + cpu_ioreq_config(state, req); > + break; > + default: > + arch_handle_ioreq(state, req); > + } > + if (req->dir == IOREQ_READ) { > + trace_handle_ioreq_read(req, req->type, req->df, req->data_is_ptr, > + req->addr, req->data, req->count, req->size); > + } > +} > + > +static bool handle_buffered_iopage(XenIOState *state) > +{ > + buffered_iopage_t *buf_page = state->buffered_io_page; > + buf_ioreq_t *buf_req = NULL; > + bool handled_ioreq = false; > + ioreq_t req; > + int qw; > + > + if (!buf_page) { > + return 0; > + } > + > + memset(&req, 0x00, sizeof(req)); > + req.state = STATE_IOREQ_READY; > + req.count = 1; > + req.dir = IOREQ_WRITE; > + > + for (;;) { > + uint32_t rdptr = buf_page->read_pointer, wrptr; > + > + xen_rmb(); > + wrptr = buf_page->write_pointer; > + xen_rmb(); > + if (rdptr != buf_page->read_pointer) { > + continue; > + } > + if (rdptr == wrptr) { > + break; > + } > + buf_req = &buf_page->buf_ioreq[rdptr % IOREQ_BUFFER_SLOT_NUM]; > + req.size = 1U << buf_req->size; > + req.addr = buf_req->addr; > + req.data = buf_req->data; > + req.type = buf_req->type; > + xen_rmb(); > + qw = (req.size == 8); > + if (qw) { > + if (rdptr + 1 == wrptr) { > + hw_error("Incomplete quad word buffered ioreq"); > + } > + buf_req = &buf_page->buf_ioreq[(rdptr + 1) % > + IOREQ_BUFFER_SLOT_NUM]; > + req.data |= ((uint64_t)buf_req->data) << 32; > + xen_rmb(); > + } > + > + handle_ioreq(state, &req); > + > + /* Only req.data may get updated by handle_ioreq(), albeit even that > + * should not happen as such data would never make it to the guest (we > + * can only usefully see writes here after all). > + */ > + assert(req.state == STATE_IOREQ_READY); > + assert(req.count == 1); > + assert(req.dir == IOREQ_WRITE); > + assert(!req.data_is_ptr); > + > + qatomic_add(&buf_page->read_pointer, qw + 1); > + handled_ioreq = true; > + } > + > + return handled_ioreq; > +} > + > +static void handle_buffered_io(void *opaque) > +{ > + XenIOState *state = opaque; > + > + if (handle_buffered_iopage(state)) { > + timer_mod(state->buffered_io_timer, > + BUFFER_IO_MAX_DELAY + qemu_clock_get_ms(QEMU_CLOCK_REALTIME)); > + } else { > + timer_del(state->buffered_io_timer); > + xenevtchn_unmask(state->xce_handle, state->bufioreq_local_port); > + } > +} > + > +static void cpu_handle_ioreq(void *opaque) > +{ > + XenIOState *state = opaque; > + ioreq_t *req = cpu_get_ioreq(state); > + > + handle_buffered_iopage(state); > + if (req) { > + ioreq_t copy = *req; > + > + xen_rmb(); > + handle_ioreq(state, ©); > + req->data = copy.data; > + > + if (req->state != STATE_IOREQ_INPROCESS) { > + fprintf(stderr, "Badness in I/O request ... not in service?!: " > + "%x, ptr: %x, port: %"PRIx64", " > + "data: %"PRIx64", count: %u, size: %u, type: %u\n", > + req->state, req->data_is_ptr, req->addr, > + req->data, req->count, req->size, req->type); > + destroy_hvm_domain(false); > + return; > + } > + > + xen_wmb(); /* Update ioreq contents /then/ update state. */ > + > + /* > + * We do this before we send the response so that the tools > + * have the opportunity to pick up on the reset before the > + * guest resumes and does a hlt with interrupts disabled which > + * causes Xen to powerdown the domain. > + */ > + if (runstate_is_running()) { > + ShutdownCause request; > + > + if (qemu_shutdown_requested_get()) { > + destroy_hvm_domain(false); > + } > + request = qemu_reset_requested_get(); > + if (request) { > + qemu_system_reset(request); > + destroy_hvm_domain(true); > + } > + } > + > + req->state = STATE_IORESP_READY; > + xenevtchn_notify(state->xce_handle, > + state->ioreq_local_port[state->send_vcpu]); > + } > +} > + > +static void xen_main_loop_prepare(XenIOState *state) > +{ > + int evtchn_fd = -1; > + > + if (state->xce_handle != NULL) { > + evtchn_fd = xenevtchn_fd(state->xce_handle); > + } > + > + state->buffered_io_timer = timer_new_ms(QEMU_CLOCK_REALTIME, handle_buffered_io, > + state); > + > + if (evtchn_fd != -1) { > + CPUState *cpu_state; > + > + DPRINTF("%s: Init cpu_by_vcpu_id\n", __func__); > + CPU_FOREACH(cpu_state) { > + DPRINTF("%s: cpu_by_vcpu_id[%d]=%p\n", > + __func__, cpu_state->cpu_index, cpu_state); > + state->cpu_by_vcpu_id[cpu_state->cpu_index] = cpu_state; > + } > + qemu_set_fd_handler(evtchn_fd, cpu_handle_ioreq, NULL, state); > + } > +} > + > + > +void xen_hvm_change_state_handler(void *opaque, bool running, > + RunState rstate) > +{ > + XenIOState *state = opaque; > + > + if (running) { > + xen_main_loop_prepare(state); > + } > + > + xen_set_ioreq_server_state(xen_domid, > + state->ioservid, > + (rstate == RUN_STATE_RUNNING)); > +} > + > +void xen_exit_notifier(Notifier *n, void *data) > +{ > + XenIOState *state = container_of(n, XenIOState, exit); > + > + xen_destroy_ioreq_server(xen_domid, state->ioservid); > + if (state->fres != NULL) { > + xenforeignmemory_unmap_resource(xen_fmem, state->fres); > + } > + > + xenevtchn_close(state->xce_handle); > + xs_daemon_close(state->xenstore); > +} > + > +static int xen_map_ioreq_server(XenIOState *state) > +{ > + void *addr = NULL; > + xen_pfn_t ioreq_pfn; > + xen_pfn_t bufioreq_pfn; > + evtchn_port_t bufioreq_evtchn; > + int rc; > + > + /* > + * Attempt to map using the resource API and fall back to normal > + * foreign mapping if this is not supported. > + */ > + QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_bufioreq != 0); > + QEMU_BUILD_BUG_ON(XENMEM_resource_ioreq_server_frame_ioreq(0) != 1); > + state->fres = xenforeignmemory_map_resource(xen_fmem, xen_domid, > + XENMEM_resource_ioreq_server, > + state->ioservid, 0, 2, > + &addr, > + PROT_READ | PROT_WRITE, 0); > + if (state->fres != NULL) { > + trace_xen_map_resource_ioreq(state->ioservid, addr); > + state->buffered_io_page = addr; > + state->shared_page = addr + XC_PAGE_SIZE; > + } else if (errno != EOPNOTSUPP) { > + error_report("failed to map ioreq server resources: error %d handle=%p", > + errno, xen_xc); > + return -1; > + } > + > + rc = xen_get_ioreq_server_info(xen_domid, state->ioservid, > + (state->shared_page == NULL) ? > + &ioreq_pfn : NULL, > + (state->buffered_io_page == NULL) ? > + &bufioreq_pfn : NULL, > + &bufioreq_evtchn); > + if (rc < 0) { > + error_report("failed to get ioreq server info: error %d handle=%p", > + errno, xen_xc); > + return rc; > + } > + > + if (state->shared_page == NULL) { > + DPRINTF("shared page at pfn %lx\n", ioreq_pfn); > + > + state->shared_page = xenforeignmemory_map(xen_fmem, xen_domid, > + PROT_READ | PROT_WRITE, > + 1, &ioreq_pfn, NULL); > + if (state->shared_page == NULL) { > + error_report("map shared IO page returned error %d handle=%p", > + errno, xen_xc); > + } > + } > + > + if (state->buffered_io_page == NULL) { > + DPRINTF("buffered io page at pfn %lx\n", bufioreq_pfn); > + > + state->buffered_io_page = xenforeignmemory_map(xen_fmem, xen_domid, > + PROT_READ | PROT_WRITE, > + 1, &bufioreq_pfn, > + NULL); > + if (state->buffered_io_page == NULL) { > + error_report("map buffered IO page returned error %d", errno); > + return -1; > + } > + } > + > + if (state->shared_page == NULL || state->buffered_io_page == NULL) { > + return -1; > + } > + > + DPRINTF("buffered io evtchn is %x\n", bufioreq_evtchn); > + > + state->bufioreq_remote_port = bufioreq_evtchn; > + > + return 0; > +} > + > +void destroy_hvm_domain(bool reboot) > +{ > + xc_interface *xc_handle; > + int sts; > + int rc; > + > + unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff; > + > + if (xen_dmod) { > + rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason); > + if (!rc) { > + return; > + } > + if (errno != ENOTTY /* old Xen */) { > + perror("xendevicemodel_shutdown failed"); > + } > + /* well, try the old thing then */ > + } > + > + xc_handle = xc_interface_open(0, 0, 0); > + if (xc_handle == NULL) { > + fprintf(stderr, "Cannot acquire xenctrl handle\n"); > + } else { > + sts = xc_domain_shutdown(xc_handle, xen_domid, reason); > + if (sts != 0) { > + fprintf(stderr, "xc_domain_shutdown failed to issue %s, " > + "sts %d, %s\n", reboot ? "reboot" : "poweroff", > + sts, strerror(errno)); > + } else { > + fprintf(stderr, "Issued domain %d %s\n", xen_domid, > + reboot ? "reboot" : "poweroff"); > + } > + xc_interface_close(xc_handle); > + } > +} > + > +void xen_shutdown_fatal_error(const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + vfprintf(stderr, fmt, ap); > + va_end(ap); > + fprintf(stderr, "Will destroy the domain.\n"); > + /* destroy the domain */ > + qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR); > +} > + > +static void xen_register_backend(XenIOState *state) > +{ > + /* Initialize backend core & drivers */ > + if (xen_be_init() != 0) { > + error_report("xen backend core setup failed"); > + goto err; > + } > + xen_be_register_common(); > + > + return; > + > +err: > + error_report("xen hardware virtual machine backend registration failed"); > + exit(1); > +} > + > +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, > + MemoryListener xen_memory_listener) > +{ > + int i, rc; > + > + state->xce_handle = xenevtchn_open(NULL, 0); > + if (state->xce_handle == NULL) { > + perror("xen: event channel open"); > + goto err; > + } > + > + state->xenstore = xs_daemon_open(); > + if (state->xenstore == NULL) { > + perror("xen: xenstore open"); > + goto err; > + } > + > + xen_create_ioreq_server(xen_domid, &state->ioservid); > + > + state->exit.notify = xen_exit_notifier; > + qemu_add_exit_notifier(&state->exit); > + > + /* > + * Register wake-up support in QMP query-current-machine API > + */ > + qemu_register_wakeup_support(); > + > + rc = xen_map_ioreq_server(state); > + if (rc < 0) { > + goto err; > + } > + > + /* Note: cpus is empty at this point in init */ > + state->cpu_by_vcpu_id = g_malloc0(max_cpus * sizeof(CPUState *)); > + > + rc = xen_set_ioreq_server_state(xen_domid, state->ioservid, true); > + if (rc < 0) { > + error_report("failed to enable ioreq server info: error %d handle=%p", > + errno, xen_xc); > + goto err; > + } > + > + state->ioreq_local_port = g_malloc0(max_cpus * sizeof (evtchn_port_t)); > + > + /* FIXME: how about if we overflow the page here? */ > + for (i = 0; i < max_cpus; i++) { > + rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid, > + xen_vcpu_eport(state->shared_page, i)); > + if (rc == -1) { > + error_report("shared evtchn %d bind error %d", i, errno); > + goto err; > + } > + state->ioreq_local_port[i] = rc; > + } > + > + rc = xenevtchn_bind_interdomain(state->xce_handle, xen_domid, > + state->bufioreq_remote_port); > + if (rc == -1) { > + error_report("buffered evtchn bind error %d", errno); > + goto err; > + } > + state->bufioreq_local_port = rc; > + > + /* Init RAM management */ > +#ifdef XEN_COMPAT_PHYSMAP > + xen_map_cache_init(xen_phys_offset_to_gaddr, state); > +#else > + xen_map_cache_init(NULL, state); > +#endif > + > + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state); > + > + state->memory_listener = xen_memory_listener; > + memory_listener_register(&state->memory_listener, &address_space_memory); > + > + state->io_listener = xen_io_listener; > + memory_listener_register(&state->io_listener, &address_space_io); > + > + state->device_listener = xen_device_listener; > + QLIST_INIT(&state->dev_list); > + device_listener_register(&state->device_listener); > + > + xen_bus_init(); > + > + xen_register_backend(state); > + > + return; > +err: > + error_report("xen hardware virtual machine initialisation failed"); > + exit(1); > +} > diff --git a/include/hw/i386/xen_arch_hvm.h b/include/hw/i386/xen_arch_hvm.h > new file mode 100644 > index 0000000000..1000f8f543 > --- /dev/null > +++ b/include/hw/i386/xen_arch_hvm.h > @@ -0,0 +1,11 @@ > +#ifndef HW_XEN_ARCH_I386_HVM_H > +#define HW_XEN_ARCH_I386_HVM_H > + > +#include > +#include "hw/xen/xen-hvm-common.h" > + > +void arch_handle_ioreq(XenIOState *state, ioreq_t *req); > +void arch_xen_set_memory(XenIOState *state, > + MemoryRegionSection *section, > + bool add); > +#endif > diff --git a/include/hw/xen/arch_hvm.h b/include/hw/xen/arch_hvm.h > new file mode 100644 > index 0000000000..26674648d8 > --- /dev/null > +++ b/include/hw/xen/arch_hvm.h > @@ -0,0 +1,3 @@ > +#if defined(TARGET_I386) || defined(TARGET_X86_64) > +#include "hw/i386/xen_arch_hvm.h" > +#endif > diff --git a/include/hw/xen/xen-hvm-common.h b/include/hw/xen/xen-hvm-common.h > new file mode 100644 > index 0000000000..2979f84ee2 > --- /dev/null > +++ b/include/hw/xen/xen-hvm-common.h > @@ -0,0 +1,98 @@ > +#ifndef HW_XEN_HVM_COMMON_H > +#define HW_XEN_HVM_COMMON_H > + > +#include "qemu/osdep.h" > +#include "qemu/units.h" > + > +#include "cpu.h" > +#include "hw/pci/pci.h" > +#include "hw/hw.h" > +#include "hw/xen/xen_common.h" > +#include "sysemu/runstate.h" > +#include "sysemu/sysemu.h" > +#include "sysemu/xen.h" > +#include "sysemu/xen-mapcache.h" > + > +#include > + > +extern MemoryRegion ram_memory; > +extern MemoryListener xen_io_listener; > +extern DeviceListener xen_device_listener; > + > +//#define DEBUG_XEN_HVM > + > +#ifdef DEBUG_XEN_HVM > +#define DPRINTF(fmt, ...) \ > + do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0) > +#else > +#define DPRINTF(fmt, ...) \ > + do { } while (0) > +#endif > + > +static inline uint32_t xen_vcpu_eport(shared_iopage_t *shared_page, int i) > +{ > + return shared_page->vcpu_ioreq[i].vp_eport; > +} > +static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) > +{ > + return &shared_page->vcpu_ioreq[vcpu]; > +} > + > +#define BUFFER_IO_MAX_DELAY 100 > + > +typedef struct XenPhysmap { > + hwaddr start_addr; > + ram_addr_t size; > + const char *name; > + hwaddr phys_offset; > + > + QLIST_ENTRY(XenPhysmap) list; > +} XenPhysmap; > + > +typedef struct XenPciDevice { > + PCIDevice *pci_dev; > + uint32_t sbdf; > + QLIST_ENTRY(XenPciDevice) entry; > +} XenPciDevice; > + > +typedef struct XenIOState { > + ioservid_t ioservid; > + shared_iopage_t *shared_page; > + buffered_iopage_t *buffered_io_page; > + xenforeignmemory_resource_handle *fres; > + QEMUTimer *buffered_io_timer; > + CPUState **cpu_by_vcpu_id; > + /* the evtchn port for polling the notification, */ > + evtchn_port_t *ioreq_local_port; > + /* evtchn remote and local ports for buffered io */ > + evtchn_port_t bufioreq_remote_port; > + evtchn_port_t bufioreq_local_port; > + /* the evtchn fd for polling */ > + xenevtchn_handle *xce_handle; > + /* which vcpu we are serving */ > + int send_vcpu; > + > + struct xs_handle *xenstore; > + MemoryListener memory_listener; > + MemoryListener io_listener; > + QLIST_HEAD(, XenPciDevice) dev_list; > + DeviceListener device_listener; > + > + Notifier exit; > +} XenIOState; > + > +void xen_exit_notifier(Notifier *n, void *data); > + > +void xen_region_add(MemoryListener *listener, MemoryRegionSection *section); > +void xen_region_del(MemoryListener *listener, MemoryRegionSection *section); > +void xen_io_add(MemoryListener *listener, MemoryRegionSection *section); > +void xen_io_del(MemoryListener *listener, MemoryRegionSection *section); > +void xen_device_realize(DeviceListener *listener, DeviceState *dev); > +void xen_device_unrealize(DeviceListener *listener, DeviceState *dev); > + > +void xen_hvm_change_state_handler(void *opaque, bool running, RunState rstate); > +void xen_register_ioreq(XenIOState *state, unsigned int max_cpus, > + MemoryListener xen_memory_listener); > + > +void cpu_ioreq_pio(ioreq_t *req); > +#endif /* HW_XEN_HVM_COMMON_H */ > -- > 2.17.0 > > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 02:15:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 02:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488036.755904 (Exim 4.92) (envelope-from ) id 1pN2ep-0001QG-4v; Wed, 01 Feb 2023 02:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488036.755904; Wed, 01 Feb 2023 02:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ep-0001Q7-21; Wed, 01 Feb 2023 02:15:31 +0000 Received: by outflank-mailman (input) for mailman id 488036; Wed, 01 Feb 2023 02:15:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2en-000179-HZ for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 02:15:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4bbd7035-a1d6-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 03:15:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 208284B3; Tue, 31 Jan 2023 18:16:10 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 979223F882; Tue, 31 Jan 2023 18:15:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bbd7035-a1d6-11ed-933c-83870f6b2ba8 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem Date: Wed, 1 Feb 2023 10:15:11 +0800 Message-Id: <20230201021513.336837-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230201021513.336837-1-Henry.Wang@arm.com> References: <20230201021513.336837-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As we are having more and more types of static region, and all of these static regions are defined in bootinfo.reserved_mem, it is necessary to add the overlap check of reserved memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early stage of boot time. Currently we have 3 types of static region, namely (1) static memory (2) static heap (3) static shared memory (1) and (2) are parsed by the function `device_tree_get_meminfo()` and (3) is parsed using its own logic. All of parsed information of these types will be stored in `struct meminfo`. Therefore, to unify the overlap checking logic for all of these types, this commit firstly introduces a helper `meminfo_overlap_check()` and a function `check_reserved_regions_overlap()` to check if an input physical address range is overlapping with the existing memory regions defined in bootinfo. After that, use `check_reserved_regions_overlap()` in `device_tree_get_meminfo()` to do the overlap check of (1) and (2) and replace the original overlap check of (3) with `check_reserved_regions_overlap()`. Signed-off-by: Henry Wang Reviewed-by: Stefano Stabellini --- Stefano - I kept your reviewed-by tag since there is no actual code change in v4. Hope you'd be fine with this and thanks for the review. v3 -> v4: 1. Correct printk error message, end should be exclusive. 2. Add comment explaining the unhandled case where '*_end' could be 0 if the bank/region is at the end of the physical address space. 3. Add Stefano's reviewed-by tag. v2 -> v3: 1. Use "[start, end]" format in printk error message. 2. Change the return type of helper functions to bool. 3. Use 'start' and 'size' in helper functions to describe a region. v1 -> v2: 1. Split original `overlap_check()` to `meminfo_overlap_check()`. 2. Rework commit message. --- xen/arch/arm/bootfdt.c | 13 +++++---- xen/arch/arm/include/asm/setup.h | 2 ++ xen/arch/arm/setup.c | 45 ++++++++++++++++++++++++++++++++ 3 files changed, 53 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0085c28d74..e2f6c7324b 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -88,6 +88,9 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ ) { device_tree_get_reg(&cell, address_cells, size_cells, &start, &size); + if ( mem == &bootinfo.reserved_mem && + check_reserved_regions_overlap(start, size) ) + return -EINVAL; /* Some DT may describe empty bank, ignore them */ if ( !size ) continue; @@ -482,7 +485,9 @@ static int __init process_shm_node(const void *fdt, int node, return -EINVAL; } - if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + if ( check_reserved_regions_overlap(paddr, size) ) + return -EINVAL; + else { if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) continue; @@ -493,12 +498,6 @@ static int __init process_shm_node(const void *fdt, int node, return -EINVAL; } } - else - { - printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", - mem->bank[i].start, bank_end); - return -EINVAL; - } } } diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..f0592370ea 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -143,6 +143,8 @@ void fw_unreserved_regions(paddr_t s, paddr_t e, size_t boot_fdt_info(const void *fdt, paddr_t paddr); const char *boot_fdt_cmdline(const void *fdt); +bool check_reserved_regions_overlap(paddr_t region_start, paddr_t region_size); + struct bootmodule *add_boot_module(bootmodule_kind kind, paddr_t start, paddr_t size, bool domU); struct bootmodule *boot_module_find_by_kind(bootmodule_kind kind); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90..28c79a413f 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -261,6 +261,36 @@ static void __init dt_unreserved_regions(paddr_t s, paddr_t e, cb(s, e); } +/* + * TODO: '*_end' could be 0 if the bank/region is at the end of the physical + * address space. This is for now not handled as it requires more rework. + */ +static bool __init meminfo_overlap_check(struct meminfo *meminfo, + paddr_t region_start, + paddr_t region_size) +{ + paddr_t bank_start = INVALID_PADDR, bank_end = 0; + paddr_t region_end = region_start + region_size; + unsigned int i, bank_num = meminfo->nr_banks; + + for ( i = 0; i < bank_num; i++ ) + { + bank_start = meminfo->bank[i].start; + bank_end = bank_start + meminfo->bank[i].size; + + if ( region_end <= bank_start || region_start >= bank_end ) + continue; + else + { + printk("Region: [%#"PRIpaddr", %#"PRIpaddr") overlapping with bank[%u]: [%#"PRIpaddr", %#"PRIpaddr")\n", + region_start, region_end, i, bank_start, bank_end); + return true; + } + } + + return false; +} + void __init fw_unreserved_regions(paddr_t s, paddr_t e, void (*cb)(paddr_t, paddr_t), unsigned int first) @@ -271,7 +301,22 @@ void __init fw_unreserved_regions(paddr_t s, paddr_t e, cb(s, e); } +/* + * Given an input physical address range, check if this range is overlapping + * with the existing reserved memory regions defined in bootinfo. + * Return true if the input physical address range is overlapping with any + * existing reserved memory regions, otherwise false. + */ +bool __init check_reserved_regions_overlap(paddr_t region_start, + paddr_t region_size) +{ + /* Check if input region is overlapping with bootinfo.reserved_mem banks */ + if ( meminfo_overlap_check(&bootinfo.reserved_mem, + region_start, region_size) ) + return true; + return false; +} struct bootmodule __init *add_boot_module(bootmodule_kind kind, paddr_t start, paddr_t size, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 01 02:15:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 02:15:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488035.755893 (Exim 4.92) (envelope-from ) id 1pN2el-0001Ac-U8; Wed, 01 Feb 2023 02:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488035.755893; Wed, 01 Feb 2023 02:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2el-0001AV-RC; Wed, 01 Feb 2023 02:15:27 +0000 Received: by outflank-mailman (input) for mailman id 488035; Wed, 01 Feb 2023 02:15:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ek-0001AP-GA for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 02:15:26 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 484018e8-a1d6-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 03:15:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAA242F4; Tue, 31 Jan 2023 18:16:04 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5BF3D3F882; Tue, 31 Jan 2023 18:15:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 484018e8-a1d6-11ed-b63b-5f92e7d2e73a From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 0/3] Memory region overlap check in device tree Date: Wed, 1 Feb 2023 10:15:10 +0800 Message-Id: <20230201021513.336837-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As we are having more and more types of memory region defined in the device tree, it is necessary to add the overlap check of these memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early stage of boot time. The first patch introduces the basic memory overlap check mechanism, and does the memory check for memory regions in bootinfo.reserved_mem. Following patches extend the overlap check to include bootmodules and EfiACPIReclaimMemory. v3 -> v4: 1. Correct printk error message, end should be exclusive. 2. Add comment explaining the unhandled case where '*_end' could be 0 if the module/region is at the end of the physical address space. 3. Add Stefano's reviewed-by tag. v2 -> v3: 1. Use "[start, end]" format in printk error message. 2. Change the return type of helper functions to bool. 3. Use 'start' and 'size' in helper functions to describe a region. v1 -> v2: - Split original `overlap_check()` to `meminfo_overlap_check()` and `bootmodules_overlap_check()`. - Rework commit message. Henry Wang (3): xen/arm: Add memory overlap check for bootinfo.reserved_mem xen/arm: Extend the memory overlap check to include bootmodules xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory xen/arch/arm/bootfdt.c | 13 +++-- xen/arch/arm/efi/efi-boot.h | 10 +++- xen/arch/arm/include/asm/setup.h | 2 + xen/arch/arm/setup.c | 90 ++++++++++++++++++++++++++++++++ 4 files changed, 106 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 01 02:15:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 02:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488037.755915 (Exim 4.92) (envelope-from ) id 1pN2ex-0001lM-DG; Wed, 01 Feb 2023 02:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488037.755915; Wed, 01 Feb 2023 02:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ex-0001lF-A4; Wed, 01 Feb 2023 02:15:39 +0000 Received: by outflank-mailman (input) for mailman id 488037; Wed, 01 Feb 2023 02:15:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ev-0001AP-42 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 02:15:37 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4f450631-a1d6-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 03:15:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADFD44B3; Tue, 31 Jan 2023 18:16:16 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 30FBE3F882; Tue, 31 Jan 2023 18:15:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f450631-a1d6-11ed-b63b-5f92e7d2e73a From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 2/3] xen/arm: Extend the memory overlap check to include bootmodules Date: Wed, 1 Feb 2023 10:15:12 +0800 Message-Id: <20230201021513.336837-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230201021513.336837-1-Henry.Wang@arm.com> References: <20230201021513.336837-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Similarly as the static regions defined in bootinfo.reserved_mem, the bootmodule regions defined in bootinfo.modules should also not be overlapping with memory regions in either bootinfo.reserved_mem or bootinfo.modules. Therefore, this commit introduces a helper `bootmodules_overlap_check()` and uses this helper to extend the check in function `check_reserved_regions_overlap()` so that memory regions in bootinfo.modules are included. Use `check_reserved_regions_overlap()` in `add_boot_module()` to return early if any error occurs. Signed-off-by: Henry Wang Reviewed-by: Stefano Stabellini --- v3 -> v4: 1. Correct printk error message, end should be exclusive. 2. Add comment explaining the unhandled case where '*_end' could be 0 if the module/region is at the end of the physical address space. 3. Add Stefano's reviewed-by tag. v2 -> v3: 1. Use "[start, end]" format in printk error message. 2. Change the return type of helper functions to bool. 3. Use 'start' and 'size' in helper functions to describe a region. v1 -> v2: 1. Split original `overlap_check()` to `bootmodules_overlap_check()`. 2. Rework commit message. --- xen/arch/arm/setup.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 28c79a413f..1ea42a0386 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -291,6 +291,36 @@ static bool __init meminfo_overlap_check(struct meminfo *meminfo, return false; } +/* + * TODO: '*_end' could be 0 if the module/region is at the end of the physical + * address space. This is for now not handled as it requires more rework. + */ +static bool __init bootmodules_overlap_check(struct bootmodules *bootmodules, + paddr_t region_start, + paddr_t region_size) +{ + paddr_t mod_start = INVALID_PADDR, mod_end = 0; + paddr_t region_end = region_start + region_size; + unsigned int i, mod_num = bootmodules->nr_mods; + + for ( i = 0; i < mod_num; i++ ) + { + mod_start = bootmodules->module[i].start; + mod_end = mod_start + bootmodules->module[i].size; + + if ( region_end <= mod_start || region_start >= mod_end ) + continue; + else + { + printk("Region: [%#"PRIpaddr", %#"PRIpaddr") overlapping with mod[%u]: [%#"PRIpaddr", %#"PRIpaddr")\n", + region_start, region_end, i, mod_start, mod_end); + return true; + } + } + + return false; +} + void __init fw_unreserved_regions(paddr_t s, paddr_t e, void (*cb)(paddr_t, paddr_t), unsigned int first) @@ -315,6 +345,11 @@ bool __init check_reserved_regions_overlap(paddr_t region_start, region_start, region_size) ) return true; + /* Check if input region is overlapping with bootmodules */ + if ( bootmodules_overlap_check(&bootinfo.modules, + region_start, region_size) ) + return true; + return false; } @@ -332,6 +367,10 @@ struct bootmodule __init *add_boot_module(bootmodule_kind kind, boot_module_kind_as_string(kind), start, start + size); return NULL; } + + if ( check_reserved_regions_overlap(start, size) ) + return NULL; + for ( i = 0 ; i < mods->nr_mods ; i++ ) { mod = &mods->module[i]; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 01 02:15:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 02:15:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488038.755926 (Exim 4.92) (envelope-from ) id 1pN2ez-00023G-Km; Wed, 01 Feb 2023 02:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488038.755926; Wed, 01 Feb 2023 02:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ez-000239-He; Wed, 01 Feb 2023 02:15:41 +0000 Received: by outflank-mailman (input) for mailman id 488038; Wed, 01 Feb 2023 02:15:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2ey-0001AP-N7 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 02:15:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 517cf61f-a1d6-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 03:15:38 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57DF04B3; Tue, 31 Jan 2023 18:16:20 -0800 (PST) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CED7E3F882; Tue, 31 Jan 2023 18:15:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 517cf61f-a1d6-11ed-b63b-5f92e7d2e73a From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v4 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory Date: Wed, 1 Feb 2023 10:15:13 +0800 Message-Id: <20230201021513.336837-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230201021513.336837-1-Henry.Wang@arm.com> References: <20230201021513.336837-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Similarly as the static regions and boot modules, memory regions with EfiACPIReclaimMemory type (defined in bootinfo.acpi if CONFIG_ACPI is enabled) should also not be overlapping with memory regions in bootinfo.reserved_mem and bootinfo.modules. Therefore, this commit reuses the `meminfo_overlap_check()` to further extends the check in function `check_reserved_regions_overlap()` so that memory regions in bootinfo.acpi are included. If any error occurs in the extended `check_reserved_regions_overlap()`, the `meminfo_add_bank()` defined in `efi-boot.h` will return early. Signed-off-by: Henry Wang Reviewed-by: Stefano Stabellini --- v3 -> v4: 1. No changes. v2 -> v3: 1. Rebase on top of patch #1 and #2. 2. Add Stefano's Reviewed-by tag. v1 -> v2: 1. Rebase on top of patch #1 and #2. --- xen/arch/arm/efi/efi-boot.h | 10 ++++++++-- xen/arch/arm/setup.c | 6 ++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 223db0c4da..bb64925d70 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -161,13 +161,19 @@ static bool __init meminfo_add_bank(struct meminfo *mem, EFI_MEMORY_DESCRIPTOR *desc) { struct membank *bank; + paddr_t start = desc->PhysicalStart; + paddr_t size = desc->NumberOfPages * EFI_PAGE_SIZE; if ( mem->nr_banks >= NR_MEM_BANKS ) return false; +#ifdef CONFIG_ACPI + if ( check_reserved_regions_overlap(start, size) ) + return false; +#endif bank = &mem->bank[mem->nr_banks]; - bank->start = desc->PhysicalStart; - bank->size = desc->NumberOfPages * EFI_PAGE_SIZE; + bank->start = start; + bank->size = size; mem->nr_banks++; diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1ea42a0386..6f9f4d8c8a 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -350,6 +350,12 @@ bool __init check_reserved_regions_overlap(paddr_t region_start, region_start, region_size) ) return true; +#ifdef CONFIG_ACPI + /* Check if input region is overlapping with ACPI EfiACPIReclaimMemory */ + if ( meminfo_overlap_check(&bootinfo.acpi, region_start, region_size) ) + return true; +#endif + return false; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 01 02:27:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 02:27:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488056.755937 (Exim 4.92) (envelope-from ) id 1pN2qG-0004hH-NK; Wed, 01 Feb 2023 02:27:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488056.755937; Wed, 01 Feb 2023 02:27:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2qG-0004hA-Jw; Wed, 01 Feb 2023 02:27:20 +0000 Received: by outflank-mailman (input) for mailman id 488056; Wed, 01 Feb 2023 02:27:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN2qF-0004h4-Hm for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 02:27:19 +0000 Received: from ppsw-33.srv.uis.cam.ac.uk (ppsw-33.srv.uis.cam.ac.uk [131.111.8.133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f150e70d-a1d7-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 03:27:16 +0100 (CET) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44954) by ppsw-33.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1pN2q0-000nkw-Rq (Exim 4.96) (return-path ); Wed, 01 Feb 2023 02:27:04 +0000 Received: from [192.168.1.10] (host-92-12-62-6.as13285.net [92.12.62.6]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 448BE1FB3A; Wed, 1 Feb 2023 02:27:04 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f150e70d-a1d7-11ed-b63b-5f92e7d2e73a X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Wed, 1 Feb 2023 02:27:03 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-GB To: Julien Grall , Jan Beulich , Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman , xen-devel@lists.xenproject.org References: <652289358975cf869e4bc0a6a70e3aba7bd2fbf6.1674818705.git.oleksii.kurochko@gmail.com> <75328420-0fbd-92ae-40c7-9fee1c31c907@suse.com> <792bc4533d3604acd4321b4b15965adec22431a4.camel@gmail.com> <7fe303b6-9d01-783b-f24a-12605fe62e5f@xen.org> From: Andrew Cooper Subject: Re: [PATCH v2 07/14] xen/riscv: introduce exception context In-Reply-To: <7fe303b6-9d01-783b-f24a-12605fe62e5f@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/01/2023 10:44 pm, Julien Grall wrote: > Hi Jan, > > On 30/01/2023 13:50, Jan Beulich wrote: >> On 30.01.2023 12:54, Oleksii wrote: >>> Hi Jan, >>> >>> On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: >>>> On 27.01.2023 14:59, Oleksii Kurochko wrote: >>>>> --- /dev/null >>>>> +++ b/xen/arch/riscv/include/asm/processor.h >>>>> @@ -0,0 +1,82 @@ >>>>> +/* SPDX-License-Identifier: MIT */ >>>>> +/***************************************************************** >>>>> ************* >>>>> + * >>>>> + * Copyright 2019 (C) Alistair Francis >>>>> + * Copyright 2021 (C) Bobby Eshleman >>>>> + * Copyright 2023 (C) Vates >>>>> + * >>>>> + */ >>>>> + >>>>> +#ifndef _ASM_RISCV_PROCESSOR_H >>>>> +#define _ASM_RISCV_PROCESSOR_H >>>>> + >>>>> +#ifndef __ASSEMBLY__ >>>>> + >>>>> +/* On stack VCPU state */ >>>>> +struct cpu_user_regs >>>>> +{ >>>>> +    unsigned long zero; >>>>> +    unsigned long ra; >>>>> +    unsigned long sp; >>>>> +    unsigned long gp; >>>>> +    unsigned long tp; >>>>> +    unsigned long t0; >>>>> +    unsigned long t1; >>>>> +    unsigned long t2; >>>>> +    unsigned long s0; >>>>> +    unsigned long s1; >>>>> +    unsigned long a0; >>>>> +    unsigned long a1; >>>>> +    unsigned long a2; >>>>> +    unsigned long a3; >>>>> +    unsigned long a4; >>>>> +    unsigned long a5; >>>>> +    unsigned long a6; >>>>> +    unsigned long a7; >>>>> +    unsigned long s2; >>>>> +    unsigned long s3; >>>>> +    unsigned long s4; >>>>> +    unsigned long s5; >>>>> +    unsigned long s6; >>>>> +    unsigned long s7; >>>>> +    unsigned long s8; >>>>> +    unsigned long s9; >>>>> +    unsigned long s10; >>>>> +    unsigned long s11; >>>>> +    unsigned long t3; >>>>> +    unsigned long t4; >>>>> +    unsigned long t5; >>>>> +    unsigned long t6; >>>>> +    unsigned long sepc; >>>>> +    unsigned long sstatus; >>>>> +    /* pointer to previous stack_cpu_regs */ >>>>> +    unsigned long pregs; >>>>> +}; >>>> >>>> Just to restate what I said on the earlier version: We have a struct >>>> of >>>> this name in the public interface for x86. Besides to confusion about >>>> re-using the name for something private, I'd still like to understand >>>> what the public interface plans are. This is specifically because I >>>> think it would be better to re-use suitable public interface structs >>>> internally where possible. But that of course requires spelling out >>>> such parts of the public interface first. >>>> >>> I am not sure that I get you here. >>> I greped a little bit and found out that each architecture declares >>> this structure inside arch-specific folder. >>> >>> Mostly the usage of the cpu_user_regs is to save/restore current state >>> of CPU during traps ( exceptions/interrupts ) and context_switch(). >> >> Arm effectively duplicates the public interface struct >> vcpu_guest_core_regs >> and the internal struct cpu_user_regs (and this goes as far as also >> duplicating the __DECL_REG() helper). Personally I find such duplication >> odd at the first glance at least; maybe there is a specific reason >> for this >> in Arm. But whether the public interface struct can be re-used can >> likely >> only be known once it was spelled out. > > There are some force padding, a different ordering and some extra > fields in the internal version to simplify the assembly code. > > The rationale is explained in 1c38a1e937d3 ("xen: arm: separate guest > user regs from internal guest state"). > > We also have a split between 32-bit and 64-bit to avoid doubling up > the size in the former case. And on top of these reasons, I feel I need to remind you that we still need to break these apart on x86 to fix a stack OoB access in the #DF handler, and to fix stack alignment for UEFI, and to remove the relics of vm86 mode, and not to mention adding support for FRED. It was a fundamental design error that Xen's internal representation ever made it into the public API, and it absolutely does not want repeating again. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 01 03:06:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 03:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488064.755948 (Exim 4.92) (envelope-from ) id 1pN3Rx-0001ot-QR; Wed, 01 Feb 2023 03:06:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488064.755948; Wed, 01 Feb 2023 03:06:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3Rx-0001om-NO; Wed, 01 Feb 2023 03:06:17 +0000 Received: by outflank-mailman (input) for mailman id 488064; Wed, 01 Feb 2023 03:06:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3Rw-0001oa-24; Wed, 01 Feb 2023 03:06:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3Rv-0001Y4-Vs; Wed, 01 Feb 2023 03:06:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3Rv-00024S-He; Wed, 01 Feb 2023 03:06:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN3Rv-0006Pj-H1; Wed, 01 Feb 2023 03:06:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4S7Q8ok3zkGLhN5SFr1Xz6G2psuN9qzXJaw87s9ax4Y=; b=CJy4PqgACEwhWe3dCAIbYBPm99 m7+aaUH4ddlGjWbwfUuA2pn/PkG8w5h8lSyty4mDbJnJkPRw5tghfFRJQdPKck7Ft36gEeVdsgGcj TAhYJZaAGD5BaU9N0I+3QRdqIvszI/NYGU3LS72LO9nd3gb0Bg/ugJIikA2tnyakpdpc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176305: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 03:06:15 +0000 flight 176305 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176305/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 5 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 03:25:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 03:25:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488071.755959 (Exim 4.92) (envelope-from ) id 1pN3jv-0004WB-C5; Wed, 01 Feb 2023 03:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488071.755959; Wed, 01 Feb 2023 03:24:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3jv-0004W4-7t; Wed, 01 Feb 2023 03:24:51 +0000 Received: by outflank-mailman (input) for mailman id 488071; Wed, 01 Feb 2023 03:24:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3jt-0004Vu-SA; Wed, 01 Feb 2023 03:24:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3jt-000207-OC; Wed, 01 Feb 2023 03:24:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN3jt-0002X2-9B; Wed, 01 Feb 2023 03:24:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN3jt-0001eP-8e; Wed, 01 Feb 2023 03:24:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ak/mcpPdBgKk+sByJHW3PY6v6HnhTETkmwFjR4TzcbA=; b=ntUeaO5Z3QJO+fZ3TvPQmPQZom Aey992xItpbZo9sc+LpN2lix3L5BEOUnAw1IZXFdReBrxekuO2I12S11+ufiJsmF4GAwZ/UxfWTL7 3SR40Ydn3oI6VKzlwtQKliftVyZB4FMo8ffujY0UiI/UOQ5DNQp+s/QmEF722Mz/M60w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176300: trouble: blocked/broken/fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl-rtds::broken:regression xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-amd64-xl-credit2::broken:regression xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-pair::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64::broken:regression xen-4.17-testing:test-amd64-i386-pair::broken:regression xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-intel::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-amd64-xl:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-pair:host-install/dst_host(7):broken:heisenbug xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-intel:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-pair:capture-logs/dst_host(33):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-ping-check-xen:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:xen-boot:fail:heisenbug xen-4.17-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Wed, 01 Feb 2023 03:24:49 +0000 flight 176300 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176300/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-i386-xl-qemut-ws16-amd64 broken test-amd64-amd64-xl-rtds broken build-armhf broken test-amd64-amd64-xl-credit2 broken test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken test-amd64-amd64-pair broken build-armhf 4 host-install(4) broken REGR. vs. 175447 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken in 176275 test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken in 176275 test-amd64-amd64-xl broken in 176275 test-amd64-amd64-xl-qemuu-ovmf-amd64 broken in 176275 test-amd64-i386-pair broken in 176290 test-amd64-i386-qemut-rhel6hvm-intel broken in 176290 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken in 176295 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken in 176295 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-amd64-xl 5 host-install(5) broken in 176275 pass in 176300 test-amd64-amd64-xl-qemuu-debianhvm-amd64 5 host-install(5) broken in 176275 pass in 176300 test-amd64-amd64-xl-qemuu-ovmf-amd64 5 host-install(5) broken in 176275 pass in 176300 test-amd64-i386-pair 7 host-install/dst_host(7) broken in 176290 pass in 176300 test-amd64-i386-qemut-rhel6hvm-intel 5 host-install(5) broken in 176290 pass in 176300 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 176295 pass in 176300 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken in 176295 pass in 176300 test-amd64-i386-xl-qemut-ws16-amd64 5 host-install(5) broken pass in 176281 test-amd64-amd64-xl-rtds 5 host-install(5) broken pass in 176290 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken pass in 176295 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken pass in 176295 test-amd64-amd64-xl-credit2 5 host-install(5) broken pass in 176295 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken pass in 176295 test-amd64-amd64-pair 33 capture-logs/dst_host(33) broken pass in 176295 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 176261 pass in 176300 test-amd64-amd64-xl-rtds 10 host-ping-check-xen fail in 176275 pass in 176261 test-amd64-i386-xl-qemut-win7-amd64 8 xen-boot fail in 176275 pass in 176295 test-amd64-amd64-xl-xsm 20 guest-localmigrate/x10 fail in 176275 pass in 176300 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 176275 pass in 176300 test-amd64-i386-xl-qemut-ws16-amd64 8 xen-boot fail in 176281 pass in 176275 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 176281 pass in 176300 test-amd64-amd64-xl-rtds 8 xen-boot fail in 176290 pass in 176275 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175447 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken in 176275 like 175437 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail in 176275 like 175447 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 176275 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 176275 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 176275 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 176275 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 176281 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 176281 never pass test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail in 176295 like 175447 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 176295 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 176275 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 41 days Testing same since 176224 2023-01-26 22:14:43 Z 5 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 broken test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair broken test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds broken test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-amd64-xl-rtds broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken broken-job test-amd64-amd64-pair broken broken-step build-armhf host-install(4) broken-step build-armhf capture-logs broken-step test-amd64-i386-qemuu-rhel6hvm-intel host-install(5) broken-step test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm host-install(5) broken-step test-amd64-amd64-xl-credit2 host-install(5) broken-step test-amd64-i386-xl-qemut-ws16-amd64 host-install(5) broken-step test-amd64-i386-xl-qemut-win7-amd64 host-install(5) broken-step test-amd64-amd64-pair capture-logs/dst_host(33) broken-step test-amd64-amd64-xl-rtds host-install(5) broken-job build-armhf broken broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken broken-job test-amd64-amd64-xl broken broken-job test-amd64-amd64-xl-qemuu-ovmf-amd64 broken broken-job build-armhf broken broken-job test-amd64-i386-pair broken broken-job test-amd64-i386-qemut-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job build-armhf broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 04:36:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 04:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488083.755970 (Exim 4.92) (envelope-from ) id 1pN4qd-0005hy-Pd; Wed, 01 Feb 2023 04:35:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488083.755970; Wed, 01 Feb 2023 04:35:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN4qd-0005hr-LD; Wed, 01 Feb 2023 04:35:51 +0000 Received: by outflank-mailman (input) for mailman id 488083; Wed, 01 Feb 2023 04:35:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN4qb-0005hh-SU; Wed, 01 Feb 2023 04:35:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN4qb-0003kG-RU; Wed, 01 Feb 2023 04:35:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN4qb-0005sM-Bb; Wed, 01 Feb 2023 04:35:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN4qb-0006fH-B9; Wed, 01 Feb 2023 04:35:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qpcnOXJLWopuyB5HFH48RuI8dvRfqueGgwYP3CwRr/M=; b=Jdrv5eVDgx/s72fT3wVb4eOzum XknD+6xaajx/wfvUfqJ8X2YD0TdNTUUhY7K+Zg+Hlm6Ic+n4LIjKn/rCSv03gp4UUYAGiP194gH/j RHRW5dSuh3Ezh8XHxw+2TCtOqmWrZF4gTKzUEoekb0zR4+rvgJP3IClv1K4tYax3qGVE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176306: all pass - PUSHED X-Osstest-Versions-This: ovmf=bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 X-Osstest-Versions-That: ovmf=2f2fd79fc4000a9ef89792677e85c99224e5a035 From: osstest service owner Date: Wed, 01 Feb 2023 04:35:49 +0000 flight 176306 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176306/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 baseline version: ovmf 2f2fd79fc4000a9ef89792677e85c99224e5a035 Last test of basis 176299 2023-01-31 15:11:11 Z 0 days Testing same since 176306 2023-02-01 02:42:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chao Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2f2fd79fc4..bda715bf6d bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 01 04:47:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 04:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488091.755981 (Exim 4.92) (envelope-from ) id 1pN526-0007bq-QG; Wed, 01 Feb 2023 04:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488091.755981; Wed, 01 Feb 2023 04:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN526-0007bj-NA; Wed, 01 Feb 2023 04:47:42 +0000 Received: by outflank-mailman (input) for mailman id 488091; Wed, 01 Feb 2023 04:47:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN525-0007bd-98 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 04:47:41 +0000 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b6db635-a1eb-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 05:47:37 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 20:47:33 -0800 Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 31 Jan 2023 20:47:33 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 20:47:32 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 20:47:32 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 20:47:31 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by DS0PR11MB7786.namprd11.prod.outlook.com (2603:10b6:8:f2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 04:47:28 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 04:47:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b6db635-a1eb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675226857; x=1706762857; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kFjD2zj6aJjG+o2lSli+t3S8WH0BY1DmT6LK2G+iY7I=; b=LbuDo/78mmTrfg6EBenCh1M3yHSbqJsTRudC/heJh/+Man9OWVYjpKzk iclntU1uMLYBXKnVbSDx39zOS3YqH5uH+Xh9aaKFD1tcaj1cmtBZefm9N CEZc+reQnYrqroBDpS7TLBfhmwAZNCUrhLRJR9eHxCjyEBmk4mAEwyjyz Cmpage9KLCVq4zDwq01ioIe+XX3riWUqRDqt3kmEmaQ12ofGHHnY4206+ /RxElusSyUX1d8JkroXP0ARO47WieBYXtjQonwyVcr2hnvXNTPBp2puiC WZmx3ItXLPOsf1ZRuRtvf9yDYLb+05Xtw2ISk09sOvTgt6JVBipLhjUvD g==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="392596328" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="392596328" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="993543069" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="993543069" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxtGd0LCkkULl+/TZwzWbqAHZUbphv3olrnbeRS9w35n6XoQIA3U9G/FljUrMVRiG5WCD5fCZQH35WzflshyHZlKkPy/h6FPnNjINjj5W1kEsUq0QbwKSAJeNjdAE6gloT2oD5b3xEdgDFDICF5VuKFd+NEx6vlEwL/KkxzIQUY3zhSaLYxv5K/jbGZOjki2aw8JYKAapmgC6QHPzsmKCobk/bFn6+db5mqqKLkH1ARiltEEyFY33juc82vt8OA4bWLsbZGDwnEBx7llkd49fb7wceqbWzWqyopHvGI15UVTNPmxHMENJ9rL3TMqJxiDadz4w4mvd+VbAyUfO6Mytg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kFjD2zj6aJjG+o2lSli+t3S8WH0BY1DmT6LK2G+iY7I=; b=fUOFGey2naTP/hYEXNlq/6tQIOzRmdY/IlUXC+U5SZa01OEyubWd4fgexZFo1nHvl95GvJyzGSLEV7lEyOWTtI7BqFnSjWzWeYOoM3FQ38oqRlpiFCYCl1YZm8reJF+mlpzYNIESGb4PIGG+Bi9h+qtbVWJqNX7l2i1YHzbr3pzJZp9e6F+f62qPIfxn939/QSPtOkl0+um3Lqh6LdMdRFq4+ssmL1PRvp+PBOcUQ7lvFhxi+Uk4NmFDEVwSEYwyohz7mqDZobH6kbElGl3129WuHgKrPRn5vDanzZWISx1wx8AtkrfjkQTAN/hZ8qPn92wh0sE/cRo5XRb6Cc8aHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Beulich, Jan" , "xen-devel@lists.xenproject.org" CC: "andrew.cooper3@citrix.com" , Wei Liu , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , Tim Deegan , George Dunlap , "Paul Durrant" , Xenia Ragiadakou Subject: RE: [PATCH v2] x86/shadow: make iommu_snoop usage consistent with HAP's Thread-Topic: [PATCH v2] x86/shadow: make iommu_snoop usage consistent with HAP's Thread-Index: AQHZLKt8IVjqligRc0qxDetLKfU0DK65lxGw Date: Wed, 1 Feb 2023 04:47:28 +0000 Message-ID: References: <8d41b8ca-decb-e175-c77a-1c8f91fd2046@suse.com> In-Reply-To: <8d41b8ca-decb-e175-c77a-1c8f91fd2046@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|DS0PR11MB7786:EE_ x-ms-office365-filtering-correlation-id: e0cd8861-92c7-45e0-0213-08db040f6bfc x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xl+1TrIEM9wA6fQhAA8bL65kIL4dKu01sEYc28Jm47POwJydPGGbmECI+uR7OxxkD140E4GuJyLFvxeP8wmnj+96p51c8SSe5m7J5rGw+QG8phpcgjGQXaaHdOWi5/j+T4borRqpzSGOXBGpsHraeFDVW7W2hCPcXJrMBi4SKSUQJaQKHQvm/rjWzigpICIpM+Vtn+00gGyh5vSSuNCG7+FM9QKIravGBCxh0eRSm6jl9jz7Mka+DOtBolqiemQaIpujl6v7uXM9otYNDZyViwMYM1WXfsFBPlqa5sUXtaIBwJcvJyvoMa/HSDRZE1RBmcdFvClpkr+df+AJ3jsUgVLe7Yvc5+jbVs4dzvA/pPDT4wjpeWoCJIs6cWecm7SYekzrecOruuejaGPlpFPRpidshzLZEKl8TxYmIwkWGX1v+0L2ZyfuDZSPR7mo17A5iIX8N9LlHIkMYHhAB6h7YBjAGsVn5CKkmazodbKcQPIym1ErRFDb+N/1nKA9puRLnLwSc6njwIVzNvsIKSyXitji6L3uVbAukOZodFXtz81WlEn7FnCSGWB0MjeUuDagNKFjMbvqmidotnC96m3BQjvj7urAkZ0DwnqY/j1XaCgj1Yzaq1+Hls08ciUDz8+hjUXHzYPmZWXoREGBPv/smBMQ33tsopIS9wF6CIb4fSgNOaA74FFtM5TjE2VgaFQpvmWR31DQLteUiafZJmVUTA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199018)(55016003)(71200400001)(4326008)(66476007)(7696005)(6506007)(478600001)(9686003)(2906002)(8676002)(8936002)(41300700001)(64756008)(26005)(4744005)(66446008)(66556008)(186003)(66946007)(76116006)(83380400001)(316002)(54906003)(110136005)(52536014)(5660300002)(122000001)(38100700002)(82960400001)(86362001)(38070700005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eDk0U0Y5d3lVUEtPYWp1ajJOZHdCTVVaQ1QyYm0vRW5GRDFib1ZndDIzNjQr?= =?utf-8?B?NjI2NmF6SkpvYno5NzdxbWhrR3B4YlV3dHNWTEdyUk5CLzNRZ2VKZHZvYk52?= =?utf-8?B?dlhhbE5qellvaTZUeU9XWW9JNitBTW5CZkdheFRoa2xDMjEyWkZpeHRLeDBP?= =?utf-8?B?RUJBelY1YkExblYrNnFpWnVreGZJakRueUFPd0ZVVHY5UmpDWHoyNit2dEVW?= =?utf-8?B?bmtBMFNwNVlnQkkxcmRwRU8yYlBZMEk4L3pWWGYwQjAxaWpDVGdHWmhIREdp?= =?utf-8?B?TTF2ZUdJTFpWZEtNMGU5Wlp4TjcwalhvdThySTZkMjMrSXpPYWhYNmwrRHpF?= =?utf-8?B?ZGQwUC9zemd3SXFSSjR1U2lxMjJyMjU4Si8xVFpmZWdKakJFTlFDVGdWUVNY?= =?utf-8?B?OER0YlBUbFZJczJTVDBJUnpHM0pGWi8zenlPcGFXdGt6Z0hOeUlhSm9JWU9V?= =?utf-8?B?YWxZUGlaWUVkbTBVQ285eU41OFREd0djem80eUR4ZmtIYXEva2trS0pZWEY5?= =?utf-8?B?YTl0K2wwdURCMTNTQ1Q3SitRSVJmUXFkTzd4V204dEZBTVg4K0FhUGZkN2wr?= =?utf-8?B?SFFqbjltZWgrTVVmOVE0NkZlRFhFNmp1UUpvQVE2UzlCWXVwQ09CS1k0SEtu?= =?utf-8?B?RHFuMW9POWlCNlBFVS9Ub0pCallLSENYUUNoWGMyZGZOdE9EZ2QvRWdibGZw?= =?utf-8?B?dWJXY0YxMjJYT2RVdG8yL0U0aHMyckJ1OEVQV0pPZGNCemJicHY5QWliRzk1?= =?utf-8?B?OFB0eCtkdzRlcnk1VjFHMUdFeHgrN0NoWTRGajF6WS9RRStDRWcxdTlIUWpE?= =?utf-8?B?Ty8zWFNieE9xL2JQU1RXNFRWcXI3WTcxMldJVVBic3hxMjVSOENySjV0Vkpp?= =?utf-8?B?S0VSdGZQTjVxczFHaW5JekJkOE1SZTYxY0p2WVhWRzJSL2ZXdFlvQWNVM01G?= =?utf-8?B?RkNQMkFLRzRSU3BIYWpoRE45ZEpEY1RhKzJFSVVBQ2M4eGc0S0ljampmcGtq?= =?utf-8?B?aGIxSWwrczNjWHVxTERNM0FjSFV5VW8wbnFGY3pkVXV5RGYwd2NTZTdUQVVt?= =?utf-8?B?TDVIclowK2xjMFY3bXgvbVZ1b29LcGNsdWZiamxKcEtvejYweTJING4yTUVP?= =?utf-8?B?aFlqcndiYlZqUEhWdXQvUFZrL0xwVm9pOE9Majd2RllWYTYzdDZqUlpGMHFN?= =?utf-8?B?NkhxN1oyb3NGYmJJTE9jWFVTUjMyRytzRXB3SStocHptOUk1QVVkMFJRWm95?= =?utf-8?B?bGRTU1J0UnptK1JCZ1dIVEZoN1FQK0hzN1c5d1U3bHVNdXRMUzhuZUtaYmNL?= =?utf-8?B?elBtSi9PWUNoNTNVMWNyNmRyZ01WZjZIU25mdDJiVi9KeWprekdwYTZsQlNJ?= =?utf-8?B?ay8rejk5M0xIK2tVdGJ5R3FMU1FSSWxwWmRiVCswQmpEc0l0WFBXUGN6c1gv?= =?utf-8?B?Zldaa1lSRWJjTjkzRjNqTFFVZTVsMU9LVVNvMjlYcFZmTEk1MlFYN2Zuam90?= =?utf-8?B?OXh5cVRFUHcyRE9ucW5TUThMVjQzb3EwcXVnNjJkMzlGSzRmK01LY1JwRVJi?= =?utf-8?B?Y0xvOXA5eCtlb2tDNU54OEdMbjJqQ1JSanJEbWkvMElPNVhDMCtRNGFLMTZm?= =?utf-8?B?SG1HNTZqejVMVWdwK1paRmhjcDlDTjZiZmtyVzFQOWx6Q2ZjR3VwY3hkTjVq?= =?utf-8?B?TWZpblR3SjRySGtvV2gzelUrUC9XaCs0YjJQRTQ0MnhWbkFyUVFyQW9yZFFX?= =?utf-8?B?TERVUFh6a0IwR002SkkvNDRTU3lxN2R6TEFmdURoTmxjNktYZVRpNzJJNGh6?= =?utf-8?B?dklqcHowdWt6SW14RDNMTFVOL01mZ013aFJZY1V2L3FhZzYrWm1kdE90WFI0?= =?utf-8?B?Vm1ReUZLbmJoVTlma25KZEZyY3puM1JJTzBTSFlhaEJYZTUxMitNbE1nandu?= =?utf-8?B?dC9IeDg4UUdoZlhOWFVDNm8vVCtlOWJtVytFSkNJMngrZE4zalk2YTVjd2F3?= =?utf-8?B?eVNvOVlYRnFkMk1kZ0MzUDlvSVZ2YTRQVW5EeWFwWm8wNllPTERXSFJsMi9L?= =?utf-8?B?TjNqU1NQY0hKRktxN3hhaWF3VlFJS1JNQjFKU1p1RkFKaUVJNUcwMmxwRTB4?= =?utf-8?Q?DhNKUYAGDNYkL9A/IQ/NDblix?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0cd8861-92c7-45e0-0213-08db040f6bfc X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 04:47:28.5442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nz3j5PHBvh7+Fug8RT0yjpLguVwi+C4r0HIfBvfAD4cmbLBfLodLv0jZ0s8V1ZggvVsES24gOcN3RWZYjyPuUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7786 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IEZyaWRheSwg SmFudWFyeSAyMCwgMjAyMyA0OjQ0IFBNDQo+IA0KPiBGaXJzdCBvZiBhbGwgdGhlIHZhcmlhYmxl IGlzIG1lYW5pbmdmdWwgb25seSB3aGVuIGFuIElPTU1VIGlzIGluIHVzZSBmb3INCj4gYSBndWVz dC4gUXVhbGlmeSB0aGUgY2hlY2sgYWNjb3JkaW5nbHksIGxpa2UgZG9uZSBlbHNld2hlcmUuIEZ1 cnRoZXJtb3JlDQo+IHRoZSBjb250cm9sbGluZyBjb21tYW5kIGxpbmUgb3B0aW9uIGlzIHN1cHBv c2VkIHRvIHRha2UgZWZmZWN0IG9uIFZULWQNCj4gb25seS4gU2luY2UgY29tbWFuZCBsaW5lIHBh cnNpbmcgaGFwcGVucyBiZWZvcmUgd2Uga25vdyB3aGV0aGVyIHdlJ3JlDQo+IGdvaW5nIHRvIHVz ZSBWVC1kLCBmb3JjZSB0aGUgdmFyaWFibGUgYmFjayB0byBzZXQgd2hlbiBpbnN0ZWFkIHJ1bm5p bmcNCj4gd2l0aCBBTUQgSU9NTVUocykuDQo+IA0KPiBTaW5jZSBpdCBtYXkgZW5kIHVwIG1pc2xl YWRpbmcsIGFsc28gcmVtb3ZlIHRoZSBjbGVhcmluZyBvZiB0aGUgZmxhZyBpbg0KPiBpb21tdV9z ZXR1cCgpIGFuZCB2dGRfc2V0dXAoKSdzIGVycm9yIHBhdGguIFRoZSB2YXJpYWJsZSBzaW1wbHkg aXMNCj4gbWVhbmluZ2xlc3Mgd2l0aCBJT01NVShzKSBkaXNhYmxlZCwgc28gdGhlcmUncyBubyBw b2ludCB0b3VjaGluZyBpdA0KPiB0aGVyZS4NCj4gDQo+IEZpbmFsbHkgYWxzbyBjb3JyZWN0IGEg cmVsZXZhbnQgbmVhcmJ5IGNvbW1lbnQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50 aWFuQGludGVsLmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Wed Feb 01 05:08:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 05:08:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488097.755992 (Exim 4.92) (envelope-from ) id 1pN5LW-0002UA-Es; Wed, 01 Feb 2023 05:07:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488097.755992; Wed, 01 Feb 2023 05:07:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5LW-0002U3-Bw; Wed, 01 Feb 2023 05:07:46 +0000 Received: by outflank-mailman (input) for mailman id 488097; Wed, 01 Feb 2023 05:07:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5LU-0002Tt-TP for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 05:07:45 +0000 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a23eb06-a1ee-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 06:07:42 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 21:07:39 -0800 Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2023 21:07:37 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:07:37 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 21:07:36 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 21:07:36 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by SJ1PR11MB6180.namprd11.prod.outlook.com (2603:10b6:a03:459::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 05:07:34 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 05:07:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a23eb06-a1ee-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675228062; x=1706764062; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SyOIbm9Tko8Y6FhaRs8AOgk8lWyPeSs6F//NeVjr2/U=; b=WnNVWlJgmo+N5A4u5HFA5MFZnM0JxUr5MH3EHREA6nvzLi+kOi3tuSuJ kczMlPfVWtxk476MHeKornTCMKwMGbrCN8xQTsiTE+fKu1Pm8E1HPd7EF D7/tJS0eC3rWu6AuJF7EsMDwvlkBUprY4N4Lq/CxVJHmUBJ+bH50CHVfG LBj+O0mxS7n84buzpt/UGtsXsf7iTnxrxPAu9kIAlZTLkKu3HBBpnGk3x ecb4AVJxm8tGgWsQMHLCBbhAcv7OfWB4b3/sZ5czfM3WiVHv6sGo8JyUe iGTAcgfoeIG2G9Thlv90OmkeM5Ue7bSSsuU7+cLZqvxkkcp5pRUW+4jwT Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="330154157" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="330154157" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="614718406" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="614718406" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxDw4H8jSF6flxmkd2RMiSqa55zJXe8Qu3Dm7a792MdRju/SwfbO5sMk7JlN5MzniYbxsWqMQRyugnAqrK0DsAfKpMAGeWOLXbWNTS0BgC4j3RG8g7ptE3Ta6l9CFUP6d44Ui0QVYQmrZ19F7rNWM8HbbrfdYptxXagozOvARi5bqoHhg6h3m3qCYFWSnP32X8M6mKh+AETXfF/kKgoZyoEqugplxsXwT27BcNBgwH2NQUZPk7UeWS7T0HCRXtc2V8ASp30L2eRNr+vtgUznLEI0zvS866NSqxJbaaeVAw8g8VxEctef5hwBlFePGj597JRRbzkchGHBea4Qh+Nf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SyOIbm9Tko8Y6FhaRs8AOgk8lWyPeSs6F//NeVjr2/U=; b=mCHJDWKIuSND0JNzK07bScKmm+dCMhM/1iZktezkIbRtu9nulNxYRWHlMDE0cMHrat0tOFU6aK0EmJJpZS7/b796KxbMGepMT7w7se/fHiLhWF8lJ7RlXJ4fY4866oejmW+ZBrmmJmlZQoCotSOVroeaRm0pN17t3SBLfQ3Vu3Y79dqc2YQ1G7QLSCbr5Kr/m3GTyDsGIhhOwbuMX5RKrRnWCIuqJc7HmbLpjCpYcTka2TXrzqkKnlMuN0oek4755BoXbFhyVoP+seU3YipQp4q73opSKXD3Mqx6b36KwFt2ie1rwbEBwRj/hh2oJAvgRSAGh7YxF8xoq/+i82JbkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: "Beulich, Jan" , Paul Durrant , =?iso-8859-1?Q?Pau_Monn=E9=2C_Roger?= Subject: RE: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Thread-Topic: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Thread-Index: AQHZL/FVJOdom3IWD0Wag5ryo7ERT665k35w Date: Wed, 1 Feb 2023 05:07:34 +0000 Message-ID: References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-3-burzalodowa@gmail.com> In-Reply-To: <20230124124142.38500-3-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|SJ1PR11MB6180:EE_ x-ms-office365-filtering-correlation-id: 9e9bba5e-4387-44f4-9819-08db04123aa1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2vtiLBIMX2Zcq5e7IcFB+BWkJDzzzqb9Qkc1HzUbm2eheQhAVMn3lrqc7N7tBYAYB0gWpazKcGcmWhSL9jyBb1Y9LPA12bs/aS8zNCexAqzEzoV9kz1tZG/TNKVhYBYUXcj2maTQZ9oY7h8obmLkBjoiAlisjLDslDf3p5QN6Hd+bE5OCAmp69q94c487zV256ItrtEmoAzEoPgwfcjKqimnAjOY74caxXNx1fxHj8FzRExmxYTBEtJ/buA3OKCVfMEvpikuIu1IsP6c6APWbmJz54RMSEIGGXZhczNAsQzUN1agTRnCL9V5P32Pi49Le0z8Zb5muyMi2erOWMY8Qp2Nqpkn7txAXjahiZnT7sQQlWDI6KIRFvyT0krMbP37X25xd7qBNAaylsBRqwv/eQVewcq/QbIIr6+FX+VYZSOFcQfPNk5Dn1vew1fhOogaQCsFWbgmxvNL7BOzSCiV3cYkGQi4GAsxcCKvzNOuHr8CSViMizo0iy8v/FLRE+qkaKpqRsmRbdIROprFWlFyoHs7Bl+DT9PgB4OASht9PaWza0YWTYWVLizzXfiMPSuV7Asg4WYV4kyzrtie0Atd9bFJ0FiD4b9y+ZrW7/NFy2eVR8bycoq03ano773znXRNV6ScAdadcyFEzVJ2bUlJisArZAkweCanKVNtltCjXyqkqrRyy9bD9s5XX4YfkaAXKme1+0hyTlMIB67DMVTR7rP1QDRi8AehYMJhyu5hAwM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199018)(8676002)(64756008)(66556008)(66476007)(66946007)(66446008)(76116006)(83380400001)(110136005)(316002)(54906003)(6506007)(966005)(26005)(9686003)(186003)(478600001)(33656002)(71200400001)(122000001)(7696005)(38100700002)(86362001)(38070700005)(2906002)(55016003)(4326008)(82960400001)(5660300002)(52536014)(8936002)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6NmcPFXxqiNr9mReET9I09Lljt3DPeCE3N/Qx9uZgqv93bnC54U7Njz7Rc?= =?iso-8859-1?Q?bFYy9piyylEBPICsHunbb+rPGZFgXReGeplBnfAz3YBAVqAVuNWKaNl03u?= =?iso-8859-1?Q?m4WqYercR1Xc7xGUhKAqbgUEf45pGKALTU76E/BBciGZOdT86uQILZekWa?= =?iso-8859-1?Q?+JPr2XxGR3w9K/d2yjOEujZCUAgdRheX7wemWitvsrwKxD28q05kfEpqEh?= =?iso-8859-1?Q?vta0maHl/vRkjKzKNyX3qLk/+h18F0l9VDmQyLC3lE1+3qLyCQjxD4EF+r?= =?iso-8859-1?Q?NrYlHu/6lQ1Rov42k+9fxmuNECjhXQ8PLFA3mc362aze6GzfUTPE+RvjEz?= =?iso-8859-1?Q?E2JRS1B6y5uqRKSKCTKekasbA2Z7giS92My3UaRJRUM5AEHmjtSe9qxn6g?= =?iso-8859-1?Q?NHxkZipaXL1pJkMxCyQsnYsVaSd0QcEvxGmr46YOSV7Msuh6m71mGRLai3?= =?iso-8859-1?Q?ljjG+VvLfNi4TuoQFnVKxb+7twXp33SLnqojKCYcsumuigx+O41Lnrl8sO?= =?iso-8859-1?Q?0e3liAMFsoEm5Uf5Aov0xr6vsfik52fX2NSlbqJpXtLNsV+rCk0DjR6Jbb?= =?iso-8859-1?Q?miLX/HpNLJnzUNK1xVywluwlwrVJZpZSsVhaAk45AibzPnCPd6FQwiNA9r?= =?iso-8859-1?Q?5TIReIPLf7O5BomUItsPynlIFUliLQkxeCsRhbgUHgXl7JSqGbAA+lbrcF?= =?iso-8859-1?Q?oDPPC8r0AuW2K/ZlaELKaj/ag6RV1DXl2AWkAsF22IHTrwYRAT7Br+Db/F?= =?iso-8859-1?Q?FQ1Lx/Ja6vL3ymDzEoNyhUe4GNihvfYn/whGcIQ59MZtkvoBGvkbMVPOgh?= =?iso-8859-1?Q?FkiU7JdyXYMsC35VadDy9Yca4HZ3d+saV7ViV/I6QCbI+HmBt8ypFgZppu?= =?iso-8859-1?Q?w8Rjwu2zAb9Q72wUudtSp/lKAxVIAcoEdiMtISXNTq1LW0R0jVJF6xk4Cm?= =?iso-8859-1?Q?UjkJc58O+uD3UyZOMzQqhZM+ZXGwe23YkU+mrf2TgQFMTjCU2JyR29sfXk?= =?iso-8859-1?Q?ejrVuF6ey4K4dlJOvySSOtSPMAoJ0X+C3ISllu0vQ10AxvYO9BEqaWFYcj?= =?iso-8859-1?Q?/6q/35mKI8c6DDU18Ra6sR6naWh2oY3aKJkxf5CLTZp5J2BOIwGhJNOqCR?= =?iso-8859-1?Q?jlqGhEyaY/Er/jQKdnx2lxnw2LUxhAqGwBqCD3hVx63uHTilfa5mUnv0au?= =?iso-8859-1?Q?e6fIHgVnxHn7WNASHpikySU92CppjMlzvCfsebKvdoxjOaS61zG2QWW0QT?= =?iso-8859-1?Q?S1YkbDS2FOTtKVo40fGl9wJUx8hky8+/aeP8RjutNi+zxdO7VP+MDKiPNs?= =?iso-8859-1?Q?CSJm55BhkCsFkOPe+fNrUeN91QghGvmrJcHIDWDJlbfofKmvJr73b3udw8?= =?iso-8859-1?Q?7TOHBGTJuZzaWzVhHgcnzoeXfxL4GWdOMJimBU9Jr2NKL91xNH8SsjjyVa?= =?iso-8859-1?Q?PMotpzM7JTMf3Ij3XEvKFw+69bBzl5+TqMl+LBR1QfIBU/5y1UFDQQlqzU?= =?iso-8859-1?Q?AN1Sks9X5+qOvu5LQ4fKvWWtVYIcovgKHCUdz4neBLP/6lLQsltBZwYvxg?= =?iso-8859-1?Q?te0eU78AnBIajd6Ina2auWTLycdYXh9dkD29Lfzygh0stN6sKUTlZ6lRRy?= =?iso-8859-1?Q?2yc1B2ui7N+Yoff6nd1vKqu9c854SpWESm?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e9bba5e-4387-44f4-9819-08db04123aa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 05:07:34.2179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ka1CFagxje9Ign07ggGQBjKXYaPpaqj3OA6vu1Jzbp4FIAoX8r157+V5UTiPptLE8+tX2asu/Z2Ox/uIHOM2gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6180 X-OriginatorOrg: intel.com > From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM >=20 > The variable untrusted_msi indicates whether the system is vulnerable to > CVE-2011-1898 due to the absence of interrupt remapping support. > Although AMD iommus with interrupt remapping disabled are also affected, > this case is not handled yet. Given that the issue is not VT-d specific, > and to accommodate future use of the flag for covering also the AMD iommu > case, move the definition of the flag out of the VT-d specific code to th= e > common x86 iommu code. >=20 > Also, since the current implementation assumes that only PV guests are > prone > to this attack, take the opportunity to define untrusted_msi only when PV= is > enabled. >=20 I'm fine with this change given no functional change. But I'm curious about the statement here that the current code only applies to PV guest. I didn't see such statement in original mail [1] and in concept a HVM guest with passthrough device can also do such attack w/o interrupt remapping. Any more context? [1] http://old-list-archives.xenproject.org/archives/html/xen-devel/2011-05= /msg00687.html From xen-devel-bounces@lists.xenproject.org Wed Feb 01 05:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 05:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488101.756003 (Exim 4.92) (envelope-from ) id 1pN5Pf-0003uV-1l; Wed, 01 Feb 2023 05:12:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488101.756003; Wed, 01 Feb 2023 05:12:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5Pe-0003uO-TE; Wed, 01 Feb 2023 05:12:02 +0000 Received: by outflank-mailman (input) for mailman id 488101; Wed, 01 Feb 2023 05:12:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5Pd-0003uI-HY for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 05:12:01 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3afa98c-a1ee-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 06:12:00 +0100 (CET) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 21:11:57 -0800 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 31 Jan 2023 21:11:57 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:11:56 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:11:56 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 21:11:56 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 21:11:56 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by SJ0PR11MB5150.namprd11.prod.outlook.com (2603:10b6:a03:2d4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 05:11:52 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 05:11:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3afa98c-a1ee-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675228320; x=1706764320; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=b+bBWUPbIBEuR2EhtfZsUh0jZolhdTF7A/ADX3h27Nc=; b=B2wngUx5C0tIItj5xm/Ece9EA867sT4YSRFL4aYSl19LqNAGh4wkxric Pfmvbi/m1xsOBU4tmxFCpfhoZy+jV8WFfcaGZXNX6OL1l8oTN1q/IPP4/ +P1QQsN/q/Oco8uEeVxYTIW4JUOdgwyup7sOV6gkbsXczz7MwLL8oLWfE UsDu53xPrqqActlRcchteD5euFCimyYYMZXWbeWwsRp1UGNX0vLgbgHlt BcJfq34Nqp+x4MqgthV4PTb8RgEOwcGI/do6faszMVNMvFGGxF1p0p0Lf OuCst3g09kzrOQQK3UpYvY0K2N6NnTJRg2qnekTR/siGoQt9aBjpJ4p47 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="326702799" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="326702799" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="666781073" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="666781073" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkoBXURUBpQ+y2D+EHVyOpBN3shn6m5B8pUdBfCFAPT18P4sf7/HnElWpkQw1qKUaDSWnjw59K3EA0BxmM6ETB3VczhXfKoG4IP+j526slrA0+RurUW+xMqu9ZfZ7uufV7mRWgYDLvkE9WDEXoJcG/GdQNRMJ1jHjrqmQaWff1LJJv7kLdkUsUi3hprtu5UDUF13IQFWpJeLftR4w0FxjAJRDmcN380vNazgWJgMRwfFxPGENoDFM9lq8+lffMI8iLjyrL7gooVIGw16Kly1eXqt2o+YRjBgwsHYbnQonDKKRXSMLfGkK6CO+98e6m5clzQVsxOjBAxlHIfoymt00A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+bBWUPbIBEuR2EhtfZsUh0jZolhdTF7A/ADX3h27Nc=; b=BgmDy6tTgUoC18RkbLpSN4YrpFoJ0paT22cWJ561DYN7IWfmULat8c9B8ME4dk+HJ3tyEIZGjdEUmz8uNa3N3eZ6RHWZiF7OTAQCkSAeH4CXPPnrJj7tpr7fvtSgCWBSAB/x3BBXbRKZGExy0keY8rGRwq2G7x4nU2WAAEOcfr0h1TQR7ZGEl7AAsJtz36s/dQm25vXCCkK7tdP3t+WHkRLNAeF1zf66WuUfv49g8J0F+WtQxYphzTWD/0TWTllglBlAQVsq1CZQTaLcBzJKV8y7ynV1FS7WGFOco8bUh+7oCfVuoiwFvfU5GEbw7FgULO4/Nhv8/Zevi6jvVZymFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: "Nakajima, Jun" , "Beulich, Jan" , "andrew.cooper3@citrix.com" , =?iso-8859-1?Q?Pau_Monn=E9=2C_Roger?= , Wei Liu , Paul Durrant Subject: RE: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback Thread-Topic: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback Thread-Index: AQHZL/FBdWHP+udJ1U++j3LNg3bXBK65l2Zw Date: Wed, 1 Feb 2023 05:11:52 +0000 Message-ID: References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-4-burzalodowa@gmail.com> In-Reply-To: <20230124124142.38500-4-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|SJ0PR11MB5150:EE_ x-ms-office365-filtering-correlation-id: 0a41bcfb-6ec6-4c2e-9ef1-08db0412d49d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: brZKKLlo0i0vjdZRq4HCX12i3WStHRuD6bo3GxV3ZgnDNJC5uMvlnxgScrDNlEUKMQT0CQYWhu3PQOK9HBl71gTaIO8fv5cRBtXHtzXxSl6HMugBXN2U+Ure7TL7WrMOI5gaqONAq6zMCfqXKGkj71SdewBAfgZWkIQE5yKSBSlEroKfqMDI6B+Xj/Xd2LfY2QFM689ArnH6LHKBMvrg5S837dzLMYFQLLUgwtxPrh4dQmCIbeBeUjo7pN3c/J896lc6CnxZnRh0h0b02NFEwRFlZN8pdiXRTpRobtnD+7bktCNL/FKBbexxUft6uPZRx4LnxJcZN5XTynmT8KiaHO72wWOdlwVsVYOY2ghteJobru+B9LMipLGuGdkg74kKB7rC2fEZCdZ4Nx0kAKkWrr2FXRwI3UUEozj/0TL9OqhAlfJwjIrWWR/O8AhiQwYiSncxJyUbOa2J6S4iP3pkhXvfp6AIxT50R7NrNPd42NCjLfmDDCZq7lPDCMMQbczJLd/xKQDYFFTwHZE66vi5QbmnHNMFYHjr+gnNovq4xiGkrUdoVWpA41l37WiaF7IbE0CJVh/UCgSOYAoAevJ82DY60MQL0EOTy7Lt85jpWzBfQBCmAFnDdo+MQurjkeQU3P/fXk2QuQXzuouYtkAsoFWN1OViOIT/QzeaqqsuOB7HHMpbOoQrRRd/p0z+x+Ho8gGFC6t4iz/+R2sW8vfVGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(346002)(39860400002)(396003)(136003)(451199018)(82960400001)(122000001)(6506007)(38100700002)(83380400001)(38070700005)(86362001)(7696005)(33656002)(478600001)(26005)(186003)(9686003)(110136005)(54906003)(316002)(71200400001)(8936002)(41300700001)(2906002)(66476007)(76116006)(64756008)(66556008)(66946007)(66446008)(8676002)(4326008)(55016003)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HROv6qy7nZNtbzzjiuVSHEXdiTc+YDlxZtbwHZFU3I5IXqrMdjHOuHYboq?= =?iso-8859-1?Q?hrCYRf2zHKFs9g8t1SfGRi1hakeYeusrhPtIE+sFE1inpRl8GP7kCmW0JD?= =?iso-8859-1?Q?wF7T5g/YHaacpTQ+KqDXkKcK7un2kVDLyh5Cfp5saNFyhL7bESXA61SbIx?= =?iso-8859-1?Q?B1adC3PePPvS/aHfS4ZrgYAziRtQLlv5ehoMQ0sjw8gK0NwT8dK4+r2e64?= =?iso-8859-1?Q?OVLWFaM1hoyCjhsQo1qVOqHCU1tOPho70n+RvRMO2ImIzryFvmqFvZqNbm?= =?iso-8859-1?Q?Gx6XAOocTA4+JZ/GwVEKAHu7SkD4goCaYtcalTC1M4NE4nBJZuQflctZI1?= =?iso-8859-1?Q?w7JfRdMdEDaaTqmyju/YK5WcdjvdgtpEs4ZjymHrijjmZCjSzbLjsDB2i5?= =?iso-8859-1?Q?W8REaxkVxledlWOoqOFGt35SzLC/mGiNhYvXeSsn4wEtkm1ci7GiIZB0KA?= =?iso-8859-1?Q?nLnMDxSMdqL1HE8Ccikg4qwjlZUk9EYKMc4bH0PB+eRkfv2+15r0jV4EQS?= =?iso-8859-1?Q?sjC3e26/MjYNsmrAMjwCr8OImpGxF7NadTd5dgipZ5WzMRw+3+X8GxjIHu?= =?iso-8859-1?Q?+/YyzTfWrHS04PWBMrPVMkr5gBeSDwRe6ZPVhg/YhQFEucPbzWbB3bNtj4?= =?iso-8859-1?Q?OEGynzFSb9qMEPm6BTGfNXnwYCT4kmT1P7eiI+VjTPNpi2bMoUUv3AuY7B?= =?iso-8859-1?Q?aPFyY9VOtBCExzNnObSvrHsysZKKG4rxlAlDmlE3nxOXIESS/CM38gpIIc?= =?iso-8859-1?Q?DOzwKfU2F4sRILuqUJ/lcf5gQUDEWf5WBvCdWPA5p6VLFRpQRv6wSGxg4e?= =?iso-8859-1?Q?JS+wh4kj4I7G8Pu6tCc8tz2YMVOdYNrCH1TR5mKkbZokhBFIdMkHFPzz9V?= =?iso-8859-1?Q?B9CgTb/xJGt3VqMFt/HqaXujCSvfujg9Ng+jSonk9ZQRjTgMPxosTH5W0k?= =?iso-8859-1?Q?x+CPooNiN8VVr0tx3TfZyk8eqxIUzD5tMCFwIZqPZMi4O7DDLXWTUMIHYt?= =?iso-8859-1?Q?xeojnkJZKy8IUULRb2yjLNG+NJ+R54xMVYEYYJYmoCozgOndK6PmFrppKs?= =?iso-8859-1?Q?0HatBweOEW2Y+217tMUfMV1GFhAJ5cic+Z+VWlRqfjy/WGQcsecr9JVhUw?= =?iso-8859-1?Q?7T0XqwJ1i1+UrivagLgdwc5oGzNXXM9i2AWM1bZK1kNYqVWChwwrHJotMr?= =?iso-8859-1?Q?z8qEo/m7tQ+GavCBkBTCIJptlMlv3XPNKYOd+KQWAHHdW5gdJsomFwSVv/?= =?iso-8859-1?Q?/sKbBOLg8actZ1aqCv+2s0G4oWLEdzu7As5E7mjgFAmAFPJZBeCv+8c7ql?= =?iso-8859-1?Q?jYvdWHWnlu8ed7e8dtuquw217tPjTe1SxmlK46d1s/ldlADS6WJUIq+z6i?= =?iso-8859-1?Q?1rgM3e6yGInG80yryC7l6Q3I3+a7sBtnFJv18Qy2FEOgKAc6cu51t9v8RH?= =?iso-8859-1?Q?oCsAgxGnDjIRsABEPCneOjfK7xSHxO/luh++vboMFg0+jOCfn/TkEty4GM?= =?iso-8859-1?Q?aVzzpA4KQ71Y/3nDRNcX399yJPQTM03tCDGC4MQSUXAlidpQmvmUvsXlBk?= =?iso-8859-1?Q?yI1chl76jgaJMlmcRlefN4bI5Uge6QT3U6W2CUK0qM6rQwXrCMVFDNXYWY?= =?iso-8859-1?Q?ByVSTJHavxXLxoTmSSWarRXd/wtGwFi9mK?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a41bcfb-6ec6-4c2e-9ef1-08db0412d49d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 05:11:52.5610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SP+liOAcgTHp02Dk0N7ggmDM+BGUHw4juIj3y8TPKxmSC2aoP4vBXWVg3FASL/1BOUqdlBDKGf0tV2B+W6N/HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5150 X-OriginatorOrg: intel.com > From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM >=20 > Posted interrupt support in Xen is currently implemented only for the > Intel platforms. Instead of calling directly pi_update_irte() from the > common hvm code, add a pi_update_irte callback to the hvm_function_table. > Then, create a wrapper function hvm_pi_update_irte() to be used by the > common hvm code. >=20 > In the pi_update_irte callback prototype, pass the vcpu as first paramete= r > instead of the posted-interrupt descriptor that is platform specific, and > remove the const qualifier from the parameter gvec since it is not needed > and because it does not compile with the alternative code patching in use= . >=20 > Since the posted interrupt descriptor is Intel VT-x specific while > msi_msg_write_remap_rte is iommu specific, open code pi_update_irte() > inside > vmx_pi_update_irte() but replace msi_msg_write_remap_rte() with generic > iommu_update_ire_from_msi(). That way vmx_pi_update_irte() is not > bound to > Intel VT-d anymore. >=20 > Remove the now unused pi_update_irte() implementation. >=20 > No functional change intended. >=20 > Signed-off-by: Xenia Ragiadakou Reviewed-by: Kevin Tian From xen-devel-bounces@lists.xenproject.org Wed Feb 01 05:22:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 05:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488107.756014 (Exim 4.92) (envelope-from ) id 1pN5Zq-0005jz-3N; Wed, 01 Feb 2023 05:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488107.756014; Wed, 01 Feb 2023 05:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5Zq-0005js-0d; Wed, 01 Feb 2023 05:22:34 +0000 Received: by outflank-mailman (input) for mailman id 488107; Wed, 01 Feb 2023 05:22:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5Zo-0005jm-CB for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 05:22:32 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b808c5f-a1f0-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 06:22:30 +0100 (CET) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 21:22:28 -0800 Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 31 Jan 2023 21:22:28 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:22:27 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 21:22:27 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 21:22:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 21:22:27 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by MN6PR11MB8170.namprd11.prod.outlook.com (2603:10b6:208:47c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 05:22:25 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 05:22:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b808c5f-a1f0-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675228950; x=1706764950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zOTlIpf2oigtCg5VIk1QqY2SReEAL5oHdH2ha8N45rY=; b=YxJGYV6TLfT+/A4u62n47ptvbUCwgnkw3jFmq/ULutPq+tdJMsXP3+Lq 9Bp6swRlYExQOP1ixclx+vRE3zESEuuO9r6B0Fvzaz+JNlTU1gSKRn607 tHvy5evRX5rDgnC8Rzu4jWwLWVaLMcvi1TLyIF0p8BNgGzzt8hafhhoyz nYyspBvqy0IWwhjTn1S4MFQNeKEQ1hQ/2XQ8OrB/y+j+AxevIbCfQk6NK fi2SixWyM/p2E6swKq0qENlbGD9Cc4wipZZmEgbd0WmmpaPvhsY5/csLg dJKNoEqsWeU+A3iMqWOnK/c0Ym+vhyEfKkJmWefZZw5m3DVQzAlj/zl1V w==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="326704959" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="326704959" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="728247281" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="728247281" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IBOf+shBrKvyh7hnkx1WdyBEJrYclSQrtoCT1Oc3UYyWn7CFW1YnBcOv7J4NWLOrulbg1QJ/uYLEqYPesiTJcbkQQrVyIEbihx+6FKVbOLt3/7Qq/GIYs6B5eH4ZX8zgWnX9sb3TvLibyCozJ/Rh7fd3YHF9GoW3OVan0YgZInHIhJrCmnBBj3Gj1xcCUyF07qWlE86P3hAWvTKHNrpIF/ILI1UIX0XPFaXpN4YnZco7j7dJLjtwM4hNXepCmxBXrmmYkf5TdnjlfCUGmjfPZmeAhK6K95bXOwc2NwgNKNYLJeENaMV/Ism76TPzokR6J/BKImmk1aYv/2BcAhFI5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zOTlIpf2oigtCg5VIk1QqY2SReEAL5oHdH2ha8N45rY=; b=GjjSQae7cV38KSYWNg41Y9GKgeCf6Puck2BOnBWpfxak6H0RNhwc9hJjUpJWwmPaxwfWThS+XcgWq4I3+BWvBmmtDG+sFHIylaViDDkzSI+MDLY5mjP3AR/SVx8De2wvPVLAR7blVYPSi8pjiWz4ONibOo/zubFcsqH/vuILPthxSloosmzJpy8G9vwIzIKUxBNDOTQ3NCzh3LBoXEDLZVGJmh33DqT46aTpBBav0h2fKWaBSTn30Qrhu5uQxpzBg8kPhk7nliy5LYCygbiXFzE544GNF34P9EipeT0AhqaP1SwyYmJI8aa8paUb/AggVhG70NDvWwOuCdmbG3f6bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: "Beulich, Jan" , Paul Durrant , =?iso-8859-1?Q?Pau_Monn=E9=2C_Roger?= Subject: RE: [PATCH v4 4/5] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code Thread-Topic: [PATCH v4 4/5] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code Thread-Index: AQHZL/FFtoM+gBrgKEi9hv9HYuOhzK65mlrA Date: Wed, 1 Feb 2023 05:22:25 +0000 Message-ID: References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-5-burzalodowa@gmail.com> In-Reply-To: <20230124124142.38500-5-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|MN6PR11MB8170:EE_ x-ms-office365-filtering-correlation-id: 7f122c90-6fe6-4e0b-13f7-08db04144db9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KjXE9ECx6qWJLCsbwYT1nPfKlfKZ2ZQzdvbfDENVXiBaFBpd2HOWMDAKt3O82X9cidy1tSvGG9APsTNf+TN3F4enN7ZQNZB9ZmNuqlL9f6vcmIg72P571ehUBb8Db/4uqWbo/Qcc2bqnJiWtz63z7SWj2Bs6tmpEWpvScd7s1w8dHA7ExlAp/9aqzZmmajjoCQgSHN2U58J0b3TRrdbfUgF8otGHtw/2TiQw4VZ0V7z4NeYEAcGyEWBdwX/tsEo9OYIpcKndQmJmLXIUnDOFsgIsrTaUFgkdfH8IioQxYyVdXi1wE9wTfFcOrW8rFbaAyRKfgIy1ioGRemR+NenU+zxqg65+H6M19tF5eY/JTXHcWvX6sVDtbfMUqifglSG11AfYiF82zqxx42vgJ+TC0lqg4S9YOMNPX62OisQV0cGzy8o1xKEtBc3zN1mLcNeVByhoEg22p4IrfwE8zMfOKXeRaH6n8mHaNKMQpBzn+7AbMiPwxugDZpPLbKPCmYoxovEQGAoUNbWMjwZfvd1U5stEoRXlQuOUW0IJruBz1X3HKGrl8IVwEGsmw+2JvmlOfFqSdgUNt5/LwE3XrLpEfVGi6nwGkcidAigZlW4DOw8jBelymZqjxD2h7yCpmsKVURyB0aBPRuPerp+q47dPC7czxAEgvmC6O4/yfy8r40WQjdefUpnSuKjYOGPnIMgIyimlj7NiuL1q9FmgOEBE6dcG2L6t5FjmZnFPSc15nKY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199018)(8676002)(64756008)(66556008)(66476007)(66946007)(66446008)(76116006)(110136005)(316002)(54906003)(6506007)(26005)(9686003)(186003)(478600001)(33656002)(71200400001)(122000001)(7696005)(38100700002)(86362001)(4744005)(38070700005)(2906002)(55016003)(4326008)(82960400001)(5660300002)(52536014)(8936002)(41300700001)(41533002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?z+GWMihmly/zX7lG4IPxfQ/uoZ5eloCN03e87F52UA0XuhB1YEl0TOLdSG?= =?iso-8859-1?Q?IBI8MEyTi2mv/LkwzzHP9GBB74gGrka+h9CUu/E89QUSRVh3i6c83Tb78Q?= =?iso-8859-1?Q?DQ5ZbRFm23oxtwuch/35yDv1y/GtX7bPM96B/9Udin2+TnEb96V+TCAmpt?= =?iso-8859-1?Q?xlNhyeV/Ns7Lte26cn8jTgG7M1MqT4AuhaKewy6hxpW8mN+1RNcylV7b0Z?= =?iso-8859-1?Q?7ydc1S/TDEO/xgn3tZtxF0yV3bUZKuL6tcFUaDUaUEcNJdw93xzhNYcPWV?= =?iso-8859-1?Q?4zBoy2iXvtWBnL3otpmgxheyye2KeDB/6ag6+qVZa0IndX4nBhbOBivNaA?= =?iso-8859-1?Q?c3OPohJgvXNhYN19qJlpSWhYLvLtenY3dCpYGHFOs2DizvO47d0Ndxlo/Z?= =?iso-8859-1?Q?DYNA41Oy0qLx/f8Z8bTq2cq21rWVbCPJERH4h/EH1h8nphqrUycY29PYcw?= =?iso-8859-1?Q?XU5N/nilPBTQI1i+lgBzSlobp5he3gY9t+UcHIHBktCQs82jIAUzyvc824?= =?iso-8859-1?Q?zkuDwgnnoPx+bg6MM9nVsldpGNsJaiRUq9XfN6P5ke3T3sn5XAayz2VbWE?= =?iso-8859-1?Q?LrDg4v2XuNdxSqMXdlZh8LqKYuHKhk4gmMuK10bNh0Ae7oGJ9Xun9yzYaB?= =?iso-8859-1?Q?+dojKR6EolpwLTgtjoWTatpWAm33iOKAq84gTK0HhGLKzkopFmRFtDLKcH?= =?iso-8859-1?Q?V72I/utXA6FXasj6OmcWgc/TlHUA+Y71peLMBBkV1aXd15qsPQbgnMFb0J?= =?iso-8859-1?Q?XhUkyV5vavBEGnMKQdC0BnKdH99BtJsFQOFThmxOb4jkZL/KiJzbDM4fhU?= =?iso-8859-1?Q?bWaf0d/lWqDprIwa+5hJWfC4OyeGV9Q85ZnM1v/Tswj3vTEG8Utdwsz2nV?= =?iso-8859-1?Q?nwHp5Pj8pmRKKbQgVwi+WlABkIVD+8s3A2dmh4e9FIE5+WwS02CwtoJcjq?= =?iso-8859-1?Q?D066sSMmHFOewoCAnO0kq822utq/FxZC/NfV+DEoJ3YiPmOu+49ic/T92Z?= =?iso-8859-1?Q?npdmp8dOU9I67zKzR26dvXzBCU83OD4PSA5ox9192hPPqSlxmHVA+WKfB4?= =?iso-8859-1?Q?7AvY2AgG/YPRffAV+NsX5rDOyZ/rnGik+Z9UVzvnOhRwhMAcYFMkFmQkI0?= =?iso-8859-1?Q?cGCnPY//IWSU5t0jNP35brkBy+FAQhXRRXb2EjMF1MBLvezWBvy/NRqJ5t?= =?iso-8859-1?Q?51wlJYByR+JIDUK18yzONWmS7JlwWT5Tb6I48+oXr7zm39Sv4XM/W4U3ra?= =?iso-8859-1?Q?w3OCA4+KTUwvXqHcmo+hRmP6FMXiv7dgJxZNqkaebAfwkKXhwbslouxFH3?= =?iso-8859-1?Q?FbrsusvxlaP4StFpRJk/bNZEnRM3D/17/lxVUirdLwEL7sFji3jpB+Kd7e?= =?iso-8859-1?Q?lyrpYyj5RIHzZK57QZKIbq40k1MalmAY1n+JXS5C8RRA6U43JyNLg9ij/g?= =?iso-8859-1?Q?IELAUksxutkWSJwXDAZCs2R0d6vtsws3vrAZ3fbG6bPCR9M/pxSS128iam?= =?iso-8859-1?Q?sqSnVVNeMOCFxA51Mx/8C6/9Q36H3nTJZ/jJND0YdbOwK2joPkn/F3Uc6f?= =?iso-8859-1?Q?0MEapjBobDbeCggVHb4bOCWGo1t57sR0N3SXIfiTZ1UCvllE1pzw/OjJjy?= =?iso-8859-1?Q?vJzLkcesF0i24CBFIQkOca0R3NSn9KCum3?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f122c90-6fe6-4e0b-13f7-08db04144db9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 05:22:25.2264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pUAizSI0aHD5KhbvPBFkcYlU0NFSTkph6wno2SpUfTLEPJJyyCixlE7DpQWV/f7WCttTtXg9rLxhO1y2OH67Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8170 X-OriginatorOrg: intel.com > From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM >=20 > The function hvm_dpci_isairq_eoi() has no dependencies on VT-d driver > code > and can be moved from xen/drivers/passthrough/vtd/x86/hvm.c to > xen/drivers/passthrough/x86/hvm.c, along with the corresponding > copyrights. >=20 > Remove the now empty xen/drivers/passthrough/vtd/x86/hvm.c. >=20 > Since the function is used only in this file, declare it static. >=20 > No functional change intended. >=20 > Signed-off-by: Xenia Ragiadakou > Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian From xen-devel-bounces@lists.xenproject.org Wed Feb 01 05:37:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 05:37:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488111.756025 (Exim 4.92) (envelope-from ) id 1pN5o1-0007ri-CU; Wed, 01 Feb 2023 05:37:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488111.756025; Wed, 01 Feb 2023 05:37:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5o1-0007rb-9c; Wed, 01 Feb 2023 05:37:13 +0000 Received: by outflank-mailman (input) for mailman id 488111; Wed, 01 Feb 2023 05:37:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5ny-0007rV-VN for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 05:37:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7814f4a4-a1f2-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 06:37:09 +0100 (CET) Received: from DB6PR0202CA0036.eurprd02.prod.outlook.com (2603:10a6:4:a5::22) by VE1PR08MB5869.eurprd08.prod.outlook.com (2603:10a6:800:1b2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 05:36:38 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::5) by DB6PR0202CA0036.outlook.office365.com (2603:10a6:4:a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 05:36:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Wed, 1 Feb 2023 05:36:37 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Wed, 01 Feb 2023 05:36:37 +0000 Received: from 97096a545cad.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B6E975F8-7FB2-4E21-B814-6E705E253785.1; Wed, 01 Feb 2023 05:36:27 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97096a545cad.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Feb 2023 05:36:27 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by VI1PR08MB5326.eurprd08.prod.outlook.com (2603:10a6:803:12d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 1 Feb 2023 05:36:23 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 05:36:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7814f4a4-a1f2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BT21zr4Nl+/QLQGdK/DwuS3nyz3Qu8fhNThFiYh00LI=; b=L9VxUrnkcyAre+nXYdS7K2+bqeTROr7uhCq2PHpWwkaAOqmhD4uoRrghId2TrVCkLOwydYpbkqoGarAAXLZ77BdW4HbvpzYJMqgBHcZ+B6BLVPzgP5BO5FxlfEsDMLfGcr4gWPBKAHuiEVLjo2+mqFNL4bFM2IyUZj8Du6w/x4s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YBdkYK/oBTqmVKFX4w1bgwf2LzCedfL7S6s3fkOa1759H6y+sc38DXtU1EMau0n2sMAEl8Hf8woxhY/nCaoCIPnVPvpF+d2PLSudsbX6Hu+aQlBcmZ/cGu5V+Oa/4Edkeu+iLQbTGT58ExRPeOlY6d/uIsR3vfbJZ9UBjypFUqIazTHnu3TgJwG5Wbh9D41j+q/xNU5nvouqe7eaeyH+SBa8J2G/VkD9j+7sXhORfn0SrK4DEnwUGQJ3aLeQHIdxyugkndCieLKu9BYoM+MSCRuAjAznGXGi1x1I9FncU6y5iggYvESaZbVrHOGYlzVTWGqok+Odo7m1bpfkWnAPpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BT21zr4Nl+/QLQGdK/DwuS3nyz3Qu8fhNThFiYh00LI=; b=c7U3UJOMozlM0NNZll5vzSLBgT8k1SNQTblop+5FGbbvKbmqNgSpU5Hj/Y40eBSsRqUppaQUD8ZgIMoE3JiZavBH2NgZ6bnmbCqXeAzmg1yZpYUVCnvRv4LSbyvn6incuN+nCeHt6rGmF8jkBBKcsXkoGrXIMAhJWmn0OsXcL0qmtzVpn1leyG1rLiGYm4PjfPcECgcaA9S94N3Dt4ewSag1DARRrk5RJPaaV3jpDD+tcQ197kHsHXfbKAKlcLayJvmB0Qt4b6mFkDDOBNYyYd6//CAcRNHy++eU8k5f0dTtEUtjQpUknHradWkmwBTQJhi2sw0IRhnmEhTxLtd43g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BT21zr4Nl+/QLQGdK/DwuS3nyz3Qu8fhNThFiYh00LI=; b=L9VxUrnkcyAre+nXYdS7K2+bqeTROr7uhCq2PHpWwkaAOqmhD4uoRrghId2TrVCkLOwydYpbkqoGarAAXLZ77BdW4HbvpzYJMqgBHcZ+B6BLVPzgP5BO5FxlfEsDMLfGcr4gWPBKAHuiEVLjo2+mqFNL4bFM2IyUZj8Du6w/x4s= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Thread-Topic: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Thread-Index: AQHZJxAoM+nWeUC5lUC+09eIkdu2V66uAIMAgAb9FDCAAB73gIABdWjwgABDKoCAATGeAIAAW6iAgAABNtA= Date: Wed, 1 Feb 2023 05:36:22 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-14-Penny.Zheng@arm.com> <23f49916-dd2a-a956-1e6b-6dbb41a8817b@xen.org> <33bddc11-ae1e-b467-32d7-647748d1c627@xen.org> <49329992-3203-78a7-fc61-d6494e37705c@xen.org> <14f9c89a-6eea-204e-cd1b-6bc1cca99716@xen.org> In-Reply-To: <14f9c89a-6eea-204e-cd1b-6bc1cca99716@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0E85207116D7884AA944408F36F00FBC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|VI1PR08MB5326:EE_|DBAEUR03FT018:EE_|VE1PR08MB5869:EE_ X-MS-Office365-Filtering-Correlation-Id: b225bcbf-a448-4743-8151-08db041649f9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 23Qls41S6fVnnVnixjCkct34u8TzcTFdjdKPQtZvkWAAM34pr4SQucdRzgMK7tYVHo13L+PJeAOwRzDiGlV5ZIfS6+yOLMRmKfayYRVzopbdX1Ii1lii0Q/vUocZiLEgVGcwG3nuV77FzAsWbaM0hXoJONbjTsYEOxa3zL2e7Y/IpF8mIArG5X4+rcYZ4NewlcZ7/L9OkHXMdTEoawhX4sq2Q3FxRphjcjWRQfYp+Xulv8cjygY7lVUM56AeWySRjyHwLSBhir44sbgq9XObqXj/qDXZN8x1KUJS0kM0nhVItrVqOjay6mQCHgND1iYBeE7FgsYYrSK+fCSVf1yFp+IFNkSl2ZUIOWOy9eQmuQ53Yy3aNQy52K/XRtEWpvR5R5N3uNm1KveH22aCfOfAyOzgIw2o0cJ2SZY6C3yXxbZnXRoZt7j8HSYz1+UyS4DNuD7o83GnFfMI3k9/3mM25PEOGwKMTtkZll/5Emf0AocOE3XWffwCkPzEQpRWI+sHJXjCIJzZF8q2PS63iB5mItav/cv7wNI+i9JZgFIApohyKr+hBr7+ijl2ukd51NXGXreTlBwmG5g1spdkLK8kAz1REsKhE2tEW99RjJh6YNz0nqgoIcyahrlwpf39OCF43cvTh6L84uWgl0BUfxQeOxes4SU7rhqA0V5Rreas53isHa5oi0Q1Ts+PJTft4Sged3bXovRclYIl6+D7DGWsoBkuoC4Maap5MY9jmiQcVyZArKLTGtO03AhG75kHatiZeG3WtDzH7xGqI4x2Pm3tfw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199018)(316002)(110136005)(54906003)(8936002)(33656002)(55016003)(2906002)(52536014)(5660300002)(38070700005)(30864003)(86362001)(122000001)(38100700002)(66946007)(66556008)(4326008)(66476007)(66446008)(64756008)(76116006)(8676002)(83380400001)(41300700001)(7696005)(966005)(478600001)(186003)(26005)(9686003)(53546011)(6506007)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5326 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b1a82679-a448-482d-98c8-08db041640fd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5lMkk4DB5Oc/e7TIezWAaHQP1ii3tug4Y2SUMtTMxcS1y1WITM/KVpaFEo0AcTUSTivfYgPQrQi6NbuN3pZkrIqyLFfAOlXCLSImqtQ/8UC4wx3CvzJZXUadxPy+dYd31J5cjDltX0ttR3gM5xqDXs7VB29fSSPXNy5LruyZa7m24g7usBy7iaosD1ez0ZJ4QGn7PLkR7TIDfe8QlbR5CUX+knsBF+uzXtrHQrDJryQ3+k4QUSLZgkXJK8Z4xLtk6yKLhxFf2yI8WIS08xC9wSUVBbnAJhh2MFaqsfX02noZVlYxM8YpL45vgy/WLLCUGUH9eW4LyodX19JMtk02pktYVziJK0cLdUNc+Qg9LjS67y6h/oeOvXQbt0a5ROguSL8ZWSPjj+tchiqQNgKJ8EmAfLZBXedM+/fwWLKul2Uw8q7OTwgKuwiqQfbdh77udJ2E50KS9bDjZlVXxbJgniu1+3MzcrUa6IQ8L/EhwT38AG7rcDlDPM1v4BAOfD6W6jkllWKolMI5HtbjiI6EBrE7I4g3/8r4iCzcwE0NGy7zpH46n6zXXJF2EMqVaHm7MR5OkqXUTWHzqG7lXDWNFW4OZ6Csomjf3iNUigIn0Y12QOgEaZLnmDO3CehuHMYJMcrEZXIYEoXeepSO/rXX3um+fQRsAd7RqgNWqLaALb0WLfgH1DTwy3XR7h1EhoMtQiTFQg6qOGTc3B7rSZWCxi1KrowUS/vIFnFYm+gxhHg8axbI0r0Qt+jQdiZpPRGpPSh58DsslYljXmsLA2ncIQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199018)(40470700004)(36840700001)(46966006)(9686003)(186003)(26005)(36860700001)(53546011)(6506007)(82740400003)(81166007)(107886003)(2906002)(478600001)(40460700003)(356005)(52536014)(33656002)(7696005)(966005)(316002)(30864003)(336012)(55016003)(40480700001)(5660300002)(54906003)(47076005)(8936002)(110136005)(86362001)(82310400005)(70586007)(41300700001)(70206006)(83380400001)(4326008)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 05:36:37.9780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b225bcbf-a448-4743-8151-08db041649f9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5869 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogVHVlc2RheSwgSmFudWFyeSAzMSwgMjAy MyA1OjQyIFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5j b20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0 cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFi Y2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gg djIgMTMvNDBdIHhlbi9tcHU6IGludHJvZHVjZSB1bmlmaWVkIGZ1bmN0aW9uDQo+IHNldHVwX2Vh cmx5X3VhcnQgdG8gbWFwIGVhcmx5IFVBUlQNCj4gDQo+IEhpIFBlbm55LA0KPiANCj4gT24gMzEv MDEvMjAyMyAwNTozOCwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVz c2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+ IFNlbnQ6IE1vbmRheSwgSmFudWFyeSAzMCwgMjAyMyA2OjAwIFBNDQo+ID4+IFRvOiBQZW5ueSBa aGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcNCj4gPj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBTdGFi ZWxsaW5pDQo+ID4+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcw0K PiA+PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4gPj4g PFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiA+PiBTdWJqZWN0OiBSZTogW1BBVENIIHYy IDEzLzQwXSB4ZW4vbXB1OiBpbnRyb2R1Y2UgdW5pZmllZCBmdW5jdGlvbg0KPiA+PiBzZXR1cF9l YXJseV91YXJ0IHRvIG1hcCBlYXJseSBVQVJUDQo+ID4+DQo+ID4+DQo+ID4+DQo+ID4+IE9uIDMw LzAxLzIwMjMgMDY6MjQsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+Pj4gSGksIEp1bGllbg0KPiA+ Pg0KPiA+PiBIaSBQZW5ueSwNCj4gPj4NCj4gPj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KPiA+Pj4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+Pj4gU2Vu dDogU3VuZGF5LCBKYW51YXJ5IDI5LCAyMDIzIDM6NDMgUE0NCj4gPj4+PiBUbzogUGVubnkgWmhl bmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tDQo+ID4+IGRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnDQo+ID4+Pj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBT dGFiZWxsaW5pDQo+ID4+Pj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJx dWlzDQo+ID4+Pj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVr DQo+ID4+Pj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiA+Pj4+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggdjIgMTMvNDBdIHhlbi9tcHU6IGludHJvZHVjZSB1bmlmaWVkIGZ1bmN0aW9uDQo+ ID4+Pj4gc2V0dXBfZWFybHlfdWFydCB0byBtYXAgZWFybHkgVUFSVA0KPiA+Pj4+DQo+ID4+Pj4g SGkgUGVubnksDQo+ID4+Pj4NCj4gPj4+PiBPbiAyOS8wMS8yMDIzIDA2OjE3LCBQZW5ueSBaaGVu ZyB3cm90ZToNCj4gPj4+Pj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+Pj4+PiBG cm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+Pj4+Pj4gU2VudDogV2VkbmVz ZGF5LCBKYW51YXJ5IDI1LCAyMDIzIDM6MDkgQU0NCj4gPj4+Pj4+IFRvOiBQZW5ueSBaaGVuZyA8 UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi0NCj4gPj4+PiBkZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZw0KPiA+Pj4+Pj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBT dGFiZWxsaW5pDQo+ID4+Pj4+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kIE1h cnF1aXMNCj4gPj4+Pj4+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFi Y2h1aw0KPiA+Pj4+Pj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiA+Pj4+Pj4gU3Vi amVjdDogUmU6IFtQQVRDSCB2MiAxMy80MF0geGVuL21wdTogaW50cm9kdWNlIHVuaWZpZWQgZnVu Y3Rpb24NCj4gPj4+Pj4+IHNldHVwX2Vhcmx5X3VhcnQgdG8gbWFwIGVhcmx5IFVBUlQNCj4gPj4+ Pj4+DQo+ID4+Pj4+PiBIaSBQZW55LA0KPiA+Pj4+Pg0KPiA+Pj4+PiBIaSBKdWxpZW4sDQo+ID4+ Pj4+DQo+ID4+Pj4+Pg0KPiA+Pj4+Pj4gT24gMTMvMDEvMjAyMyAwNToyOCwgUGVubnkgWmhlbmcg d3JvdGU6DQo+ID4+Pj4+Pj4gSW4gTU1VIHN5c3RlbSwgd2UgbWFwIHRoZSBVQVJUIGluIHRoZSBm aXhtYXAgKHdoZW4gZWFybHlwcmludGsNCj4gPj4+Pj4+PiBpcw0KPiA+Pj4+IHVzZWQpLg0KPiA+ Pj4+Pj4+IEhvd2V2ZXIgaW4gTVBVIHN5c3RlbSwgd2UgbWFwIHRoZSBVQVJUIHdpdGggYSB0cmFu c2llbnQgTVBVDQo+ID4+Pj4gbWVtb3J5DQo+ID4+Pj4+Pj4gcmVnaW9uLg0KPiA+Pj4+Pj4+DQo+ ID4+Pj4+Pj4gU28gd2UgaW50cm9kdWNlIGEgbmV3IHVuaWZpZWQgZnVuY3Rpb24gc2V0dXBfZWFy bHlfdWFydCB0bw0KPiA+Pj4+Pj4+IHJlcGxhY2UgdGhlIHByZXZpb3VzIHNldHVwX2ZpeG1hcC4N Cj4gPj4+Pj4+Pg0KPiA+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56 aGVuZ0Bhcm0uY29tPg0KPiA+Pj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hl bkBhcm0uY29tPg0KPiA+Pj4+Pj4+IC0tLQ0KPiA+Pj4+Pj4+ICAgICAgeGVuL2FyY2gvYXJtL2Fy bTY0L2hlYWQuUyAgICAgICAgICAgICAgIHwgIDIgKy0NCj4gPj4+Pj4+PiAgICAgIHhlbi9hcmNo L2FybS9hcm02NC9oZWFkX21tdS5TICAgICAgICAgICB8ICA0ICstDQo+ID4+Pj4+Pj4gICAgICB4 ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZF9tcHUuUyAgICAgICAgICAgfCA1Mg0KPiA+Pj4+Pj4gKysr KysrKysrKysrKysrKysrKysrKysrKw0KPiA+Pj4+Pj4+ICAgICAgeGVuL2FyY2gvYXJtL2luY2x1 ZGUvYXNtL2Vhcmx5X3ByaW50ay5oIHwgIDEgKw0KPiA+Pj4+Pj4+ICAgICAgNCBmaWxlcyBjaGFu Z2VkLCA1NiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQ0KPiA+Pj4+Pj4+DQo+ID4gWWVz LCBJJ2xsIGRyYXcgdGhlIGxheW91dCBmb3IgeW91Og0KPiANCj4gVGhhbmtzIQ0KPiANCj4gPiAn JycNCj4gPiAgIFhlbiBNUFUgTWFwIGJlZm9yZSByZW9yZzoNCj4gPg0KPiA+IHhlbl9tcHVtYXBb MF0gOiBYZW4gdGV4dA0KPiA+IHhlbl9tcHVtYXBbMV0gOiBYZW4gcmVhZC1vbmx5IGRhdGENCj4g PiB4ZW5fbXB1bWFwWzJdIDogWGVuIHJlYWQtb25seSBhZnRlciBpbml0IGRhdGEgeGVuX21wdW1h cFszXSA6IFhlbg0KPiA+IHJlYWQtd3JpdGUgZGF0YSB4ZW5fbXB1bWFwWzRdIDogWGVuIEJTUyB4 ZW5fbXB1bWFwWzVdIDogWGVuIHN0YXRpYw0KPiA+IGhlYXAgLi4uLi4uDQo+ID4geGVuX21wdW1h cFttYXhfeGVuX21wdW1hcCAtIDddOiBTdGF0aWMgc2hhcmVkIG1lbW9yeSBzZWN0aW9uDQo+ID4g eGVuX21wdW1hcFttYXhfeGVuX21wdW1hcCAtIDZdOiBCb290IE1vZHVsZSBtZW1vcnkNCj4gc2Vj dGlvbihrZXJuZWwsDQo+ID4gaW5pdHJhbWZzLCBldGMpIHhlbl9tcHVtYXBbbWF4X3hlbl9tcHVt YXAgLSA1XTogRGV2aWNlIG1lbW9yeQ0KPiBzZWN0aW9uDQo+ID4geGVuX21wdW1hcFttYXhfeGVu X21wdW1hcCAtIDRdOiBHdWVzdCBtZW1vcnkgc2VjdGlvbg0KPiA+IHhlbl9tcHVtYXBbbWF4X3hl bl9tcHVtYXAgLSAzXTogRWFybHkgRkRUDQo+IHhlbl9tcHVtYXBbbWF4X3hlbl9tcHVtYXAgLQ0K PiA+IDJdOiBYZW4gaW5pdCBkYXRhIHhlbl9tcHVtYXBbbWF4X3hlbl9tcHVtYXAgLSAxXTogWGVu IGluaXQgdGV4dA0KPiA+DQo+ID4gSW4gdGhlIGVuZCBvZiBib290LCBmdW5jdGlvbiBpbml0X2Rv bmUgd2lsbCBkbyB0aGUgcmVvcmcgYW5kIGJvb3Qtb25seQ0KPiByZWdpb24gY2xlYW4tdXA6DQo+ ID4NCj4gPiBYZW4gTVBVIE1hcCBhZnRlciByZW9yZyhpZGxlIHZjcHUpOg0KPiA+DQo+ID4geGVu X21wdW1hcFswXSA6IFhlbiB0ZXh0DQo+ID4geGVuX21wdW1hcFsxXSA6IFhlbiByZWFkLW9ubHkg ZGF0YQ0KPiA+IHhlbl9tcHVtYXBbMl0gOiBYZW4gcmVhZC1vbmx5IGFmdGVyIGluaXQgZGF0YQ0K PiANCj4gSW4gdGhlb3J5IDEgYW5kIDIgY291bGQgYmUgbWVyZ2VkIGFmdGVyIGJvb3QuIEJ1dCBJ IGd1ZXNzIGl0IG1pZ2h0IGJlDQo+IGNvbXBsaWNhdGVkPw0KPiANCg0KSW4gdGhlb3J5LCBpZiBp biBDIG1lcmdpbmcgY29kZXMsIHdlIGRvIG5vdCB1c2UgYW55IHJlYWQtb25seSBkYXRhIG9yIHJl YWQtb25seS1hZnRlci1pbml0DQpkYXRhLCB0aGVuLCBpZywgaXQgd2lsbCBiZSBvay4NClNpbmNl LCBJbiBNUFUgc3lzdGVtLCB3aGVuIHdlIGltcGxlbWVudCBDIG1lcmdpbmcgY29kZXMsIHdlIG5l ZWQgdG8gZGlzYWJsZSByZWdpb24gMSBhbmQgMg0KZmlyc3RseSwgYW5kIGVuYWJsZSB0aGUgbWVy Z2VkIHJlZ2lvbiBhZnRlci4gVGhlIHJlYXNvbiBpcyB0aGF0IHR3byBNUFUgcmVnaW9ucyB3aXRo IGFkZHJlc3Mgb3ZlcmxhcHBpbmcNCmlzIG5vdCBhbGxvd2VkIHdoZW4gTVBVIG9uLg0KIA0KPiA+ IHhlbl9tcHVtYXBbM10gOiBYZW4gcmVhZC13cml0ZSBkYXRhDQo+ID4geGVuX21wdW1hcFs0XSA6 IFhlbiBCU1MNCj4gPiB4ZW5fbXB1bWFwWzVdIDogWGVuIHN0YXRpYyBoZWFwDQo+ID4geGVuX21w dW1hcFs2XSA6IEd1ZXN0IG1lbW9yeSBzZWN0aW9uDQo+IA0KPiBXaHkgZG8geW91IG5lZWQgdG8g bWFwIHRoZSAiR3Vlc3QgbWVtb3J5IHNlY3Rpb24iIGZvciB0aGUgaWRsZSB2Q1BVPw0KPiANCg0K SG1tbSwgIkd1ZXN0IG1lbW9yeSBzZWN0aW9uIiBoZXJlIHJlZmVycyB0byAqQUxMKiBndWVzdCBS QU0gYWRkcmVzcyByYW5nZSB3aXRoIG9ubHkgRUwyIHJlYWQvd3JpdGUgYWNjZXNzLg0KDQpGb3Ig Z3Vlc3QgdmNwdSwgdGhpcyBzZWN0aW9uIHdpbGwgYmUgcmVwbGFjZWQgYnkgZ3Vlc3QgaXRzZWxm IG93biBSQU0gd2l0aCBib3RoIEVMMS9FTDIgYWNjZXNzLg0KDQoNCj4gPiB4ZW5fbXB1bWFwWzdd IDogRGV2aWNlIG1lbW9yeSBzZWN0aW9uDQo+IA0KPiBJIG1pZ2h0IGJlIG1pc3Npbmcgc29tZSBj b250ZXh0IGhlcmUuIEJ1dCB3aHkgdGhpcyBzZWN0aW9uIGlzIG5vdCBhbHNvDQo+IG1hcHBlZCBp biB0aGUgY29udGV4dCBvZiB0aGUgZ3Vlc3QgdkNQVT8NCj4gDQo+IEZvciBpbnN0YW5jZSwgaG93 IHdvdWxkIHlvdSB3cml0ZSB0byB0aGUgc2VyaWFsIGNvbnNvbGUgd2hlbiB0aGUgY29udGV4dCBp cw0KPiB0aGUgZ3Vlc3QgdkNQVT8NCj4gDQoNCkkgdGhpbmssIGFzIFhlbiBpdHNlbGYsIGl0IHNo YWxsIGhhdmUgYWNjZXNzIHRvIGFsbCBzeXN0ZW0gZGV2aWNlIG1lbW9yeSBvbiBFTDIuDQpJaywg aXQgaXMgbm90IGFjY3VyYXRlIGluIGN1cnJlbnQgTU1VIGltcGxlbWVudGF0aW9uLCBvbmx5IGRl dmljZXMgd2l0aCBzdXBwb3J0ZWQgZHJpdmVyDQp3aWxsIGdldCBpb3JlbWFwLg0KDQpCdXQgbGlr ZSB3ZSBkaXNjdXNzZWQgYmVmb3JlLCBpZiBmb2xsb3dpbmcgdGhlIHNhbWUgc3RyYXRlZ3kgYXMg TU1VIGRvZXMsIHdpdGggbGltaXRlZA0KTVBVIHJlZ2lvbnMsIHdlIGNvdWxkIG5vdCBhZmZvcmQg bWFwcGluZyBhIE1QVSByZWdpb24gZm9yIGVhY2ggZGV2aWNlLg0KRm9yIGV4YW1wbGUsIE9uIEZW UHY4UiBtb2RlbCwgd2UgaGF2ZSBmb3VyIHVhcnRzLCBhbmQgYSBHSUN2My4gQXQgbW9zdCwgd2Ug bWF5IHByb3ZpZGUNCmZvdXIgTVBVIHJlZ2lvbnMgZm9yIHVhcnRzLCBhbmQgdHdvIE1QVSByZWdp b25zIGZvciBEaXN0cmlidXRvciBhbmQgb25lIFJlZGlzdHJpYnV0b3IgcmVnaW9uLg0KU28sIEkg dGhvdWdodCB1cCB0aGlzIG5ldyBkZXZpY2UgdHJlZSBwcm9wZXJ0eSDigJxtcHUsZGV2aWNlLW1l bW9yeS1zZWN0aW9uID0gPDB4MCAweDgwMDAwMDAwIDB4MCAweDdmZmZmMDAwPjvigJwNCnRvIHJv dWdobHkgbWFwIGFsbCBzeXN0ZW0gZGV2aWNlIG1lbW9yeSBmb3IgWGVuIGl0c2VsZi4NCg0KRm9y IGd1ZXN0LCBpdCBzaGFsbCBvbmx5IHNlZSB2Z2ljLCB2cGwwMTEsIGFuZCBpdHMgb3duIHBhc3N0 aHJvdWdoIGRldmljZS4gQW5kIGhlcmUsIHRvIG1haW50YWluIHNhZmUgYW5kDQppc29sYXRpb24s IHdlIHdpbGwgYmUgbWFwcGluZyBhIE1QVSByZWdpb24gZm9yIGVhY2ggZGV2aWNlIGZvciBndWVz dCB2Y3B1Lg0KRm9yIGV4YW1wbGUsIHZnaWMgYW5kIHZwbDAxMSBhcmUgZW11bGF0ZWQgYW5kIGRp cmVjdC1tYXAgaW4gTVBVLiBSZWxldmFudCBkZXZpY2UNCm1hcHBpbmcoR0ZOID09IE1GTiB3aXRo IG9ubHkgRUwyIGFjY2Vzcyl3aWxsIGJlIGFkZGVkIHRvIGl0cyAqUDJNIG1hcHBpbmcgdGFibGUq LCBpbiB2Z2ljX3YzX2RvbWFpbl9pbml0IFsxXS4NCg0KTGF0ZXIsIG9uIHZjcHUgY29udGV4dCBz d2l0Y2hpbmcsIHdoZW4gc3dpdGNoaW5nIGZyb20gaWRsZSB2Y3B1LCBkZXZpY2UgbWVtb3J5IHNl Y3Rpb24gZ2V0cyBkaXNhYmxlZA0KYW5kIHN3aXRjaGVkIG91dCBpbiBjdHh0X3N3aXRjaF9mcm9t IFsyXSwgbGF0ZXIgd2hlbiBzd2l0Y2hpbmcgaW50byBndWVzdCB2Y3B1LCB2Z2ljIGFuZCB2cGww MTEgZGV2aWNlIG1hcHBpbmcNCndpbGwgYmUgc3dpdGNoZWQgaW4gYWxvbmcgd2l0aCB0aGUgd2hv bGUgUDJNIG1hcHBpbmcgdGFibGUgWzNdLiANCg0KV29yZHMgbWlnaHQgYmUgYW1iaWd1b3VzLCBi dXQgYWxsIHJlbGF0ZWQgY29kZSBpbXBsZW1lbnRhdGlvbiBpcyBvbiBNUFUgcGF0Y2ggc2VyaWUg cGFydCBJSSAtIGd1ZXN0IGluaXRpYWxpemF0aW9uLCB5b3UgbWF5DQpoYXZlIHRvIGNoZWNrIHRo ZSBnaXRsYWIgbGluazoNClsxXSBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxl L3dlaWMveGVuLy0vY29tbWl0L2E1MWQ1YjI1ZWIxN2E1MGEzNmIyNzk4N2EyZjQ4ZTE0NzkzYWM1 ODUgDQpbMl0gaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS93ZWljL3hlbi8t L2NvbW1pdC9jNmEwNjlkNzc3ZDk0MDdhZWRhNDJiN2U1YjA4YTA4NmExYzE1OTc2IA0KWzNdIGh0 dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvd2VpYy94ZW4vLS9jb21taXQvZDhj NjQwOGI2ZWVmMTE5MGQ3NWM5YmQ0ZTU4NTU3ZDM0ZmM4YjRkZiANCg0KPiA+IHhlbl9tcHVtYXBb Nl0gOiBTdGF0aWMgc2hhcmVkIG1lbW9yeSBzZWN0aW9uDQo+ID4NCj4gPiBYZW4gTVBVIE1hcCBv biBydW50aW1lKGd1ZXN0IHZjcHUpOg0KPiA+DQo+ID4geGVuX21wdW1hcFswXSA6IFhlbiB0ZXh0 DQo+ID4geGVuX21wdW1hcFsxXSA6IFhlbiByZWFkLW9ubHkgZGF0YQ0KPiA+IHhlbl9tcHVtYXBb Ml0gOiBYZW4gcmVhZC1vbmx5IGFmdGVyIGluaXQgZGF0YSB4ZW5fbXB1bWFwWzNdIDogWGVuDQo+ ID4gcmVhZC13cml0ZSBkYXRhIHhlbl9tcHVtYXBbNF0gOiBYZW4gQlNTIHhlbl9tcHVtYXBbNV0g OiBYZW4gc3RhdGljDQo+ID4gaGVhcCB4ZW5fbXB1bWFwWzZdIDogR3Vlc3QgbWVtb3J5IHhlbl9t cHVtYXBbN10gOiB2R0lDIG1hcA0KPiA+IHhlbl9tcHVtYXBbOF0gOiB2UEwwMTEgbWFwDQo+IA0K PiBJIHdhcyBleHBlY3RlZCB0aGUgUEwwMTEgdG8gYmUgZnVsbHkgZW11bGF0ZWQuIFNvIHdoeSBp cyB0aGlzIG5lY2Vzc2FyeT8NCj4gDQo+ID4geGVuX21wdW1hcFs5XSA6IFBhc3N0aHJvdWdoIGRl dmljZSBtYXAoVUFSVCwgZXRjKSB4ZW5fbXB1bWFwWzEwXSA6DQo+ID4gU3RhdGljIHNoYXJlZCBt ZW1vcnkgc2VjdGlvbg0KPiA+DQo+ID4+Pg0KPiA+Pj4gVGhhdCB3aWxsIGJlIGFscmVhZHkgYXQg bGVhc3QgMTMgTVBVIHJlZ2lvbnMgO1wuDQo+ID4+DQo+ID4+IFRoZSBzZWN0aW9uIEkgYW0gdGhl IG1vc3QgY29uY2VybiBvZiBpcyBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uDQo+ID4+IGJlY2F1 c2UgaXQgd291bGQgbGlrZWx5IG1lYW4gdGhhdCBhbGwgdGhlIGRldmljZXMgd2lsbCBiZSBtYXBw ZWQgaW4gWGVuLg0KPiA+PiBJcyB0aGVyZSBhbnkgcmlzayB0aGF0IHRoZSBndWVzdCBtYXkgdXNl IGRpZmZlcmVudCBtZW1vcnkgYXR0cmlidXRlPw0KPiA+Pg0KPiA+DQo+ID4gWWVzLCBvbiBjdXJy ZW50IGltcGxlbWVudGF0aW9uLCBwZXItZG9tYWluIHZnaWMsIHZwbDAxMSwgYW5kDQo+ID4gcGFz c3Rocm91Z2ggZGV2aWNlIG1hcCB3aWxsIGJlIGluZGl2aWR1YWxseSBhZGRlZCBpbnRvIHBlci1k b21haW4gUDJNDQo+ID4gbWFwcGluZywgdGhlbiB3aGVuIHN3aXRjaGluZyBpbnRvIGd1ZXN0IHZj cHUgZnJvbSB4ZW4gaWRsZSB2Y3B1LA0KPiA+IGRldmljZSBtZW1vcnkgc2VjdGlvbiB3aWxsIGJl IHJlcGxhY2VkIGJ5IHZnaWMsIHZwbDAxMSwgcGFzc3Rocm91Z2gNCj4gZGV2aWNlIG1hcC4NCj4g DQo+IFBlciBhYm92ZSwgSSBhbSBub3QgZW50aXJlbHkgc3VyZSBob3cgeW91IGNvdWxkIHJlbW92 ZSB0aGUgZGV2aWNlIG1lbW9yeQ0KPiBzZWN0aW9uIHdoZW4gdXNpbmcgdGhlIGd1ZXN0IHZDUFUu DQo+IA0KPiBOb3cgYWJvdXQgdGhlIGxheW91dCBiZXR3ZWVuIGluaXQgYW5kIHJ1bnRpbWUuIEZy b20gcHJldmlvdXMgZGlzY3Vzc2lvbiwNCj4geW91IHNhaWQgeW91IGRpZG4ndCB3YW50IHRvIGhh dmUgaW5pdCBzZWN0aW9uIHRvIGJlIGZpeGVkIGJlY2F1c2Ugb2YgdGhlDQo+IHNlY3Rpb24gIlhl biBzdGF0aWMgaGVhcCIuDQo+IA0KPiBGdXJ0aGVybW9yZSwgeW91IGFsc28gbWVudGlvbiB0aGF0 IHlvdSBkaWRuJ3Qgd2FudCBhIGJpdG1hcC4gU28gaG93DQo+IGFib3V0IHRoZSBmb2xsb3dpbmcg Zm9yIHRoZSBhc3NlbWJseSBwYXJ0Og0KPiANCj4geGVuX21wdW1hcFswXSA6IFhlbiB0ZXh0DQo+ IHhlbl9tcHVtYXBbMV0gOiBYZW4gcmVhZC1vbmx5IGRhdGENCj4geGVuX21wdW1hcFsyXSA6IFhl biByZWFkLW9ubHkgYWZ0ZXIgaW5pdCBkYXRhIHhlbl9tcHVtYXBbM10gOiBYZW4gcmVhZC0NCj4g d3JpdGUgZGF0YSB4ZW5fbXB1bWFwWzRdIDogWGVuIEJTUw0KPiB4ZW5fbXB1bWFwWzVdOiBFYXJs eSBGRFQNCj4geGVuX21wdW1hcFs2XTogWGVuIGluaXQgZGF0YQ0KPiB4ZW5fbXB1bWFwWzddOiBY ZW4gaW5pdCB0ZXh0DQo+IHhlbl9tcHVtYXBbOF06IEVhcmx5IFVBUlQgKG9wdGlvbmFsKQ0KPiAN Cj4gVGhlbiB3aGVuIHlvdSBzd2l0Y2ggdG8gQywgeW91IGNvdWxkIGhhdmU6DQo+IA0KPiB4ZW5f bXB1bWFwWzBdIDogWGVuIHRleHQNCj4geGVuX21wdW1hcFsxXSA6IFhlbiByZWFkLW9ubHkgZGF0 YQ0KPiB4ZW5fbXB1bWFwWzJdIDogWGVuIHJlYWQtb25seSBhZnRlciBpbml0IGRhdGEgeGVuX21w dW1hcFszXSA6IFhlbiByZWFkLQ0KPiB3cml0ZSBkYXRhIHhlbl9tcHVtYXBbNF0gOiBYZW4gQlNT DQo+IHhlbl9tcHVtYXBbNV06IEVhcmx5IEZEVA0KPiB4ZW5fbXB1bWFwWzZdOiBYZW4gaW5pdCBk YXRhDQo+IHhlbl9tcHVtYXBbN106IFhlbiBpbml0IHRleHQNCj4gDQo+IHhlbl9tcHVtYXBbbWF4 X3hlbl9tcHVtYXAgLSA0XTogRGV2aWNlIG1lbW9yeSBzZWN0aW9uDQo+IHhlbl9tcHVtYXBbbWF4 X3hlbl9tcHVtYXAgLSAzXTogR3Vlc3QgbWVtb3J5IHNlY3Rpb24NCj4geGVuX21wdW1hcFttYXhf eGVuX21wdW1hcCAtIDJdOiBTdGF0aWMgc2hhcmVkIG1lbW9yeSBzZWN0aW9uDQo+IHhlbl9tcHVt YXBbbWF4X3hlbl9tcHVtYXAgLSAxXSA6IFhlbiBzdGF0aWMgaGVhcA0KPiANCj4gQW5kIGF0IHJ1 bnRpbWUsIHlvdSB3b3VsZCBrZWVwIHRoZSAiWGVuIHN0YXRpYyBoZWFwIiByaWdodCBhdCB0aGUg ZW5kIG9mDQo+IHRoZSBNUFUgYW5kIGtlZXAgdGhlIG1pZGRsZSBlbnRyaWVzIGFzIHRoZSBzd2l0 Y2hhYmxlIG9uZS4NCj4gDQo+IFRoZXJlIHdvdWxkIGJlIG5vdCBiaXRtYXAgd2l0aCB0aGlzIHNv bHV0aW9uIGFuZCBhbGwgdGhlIGVudHJpZXMgZm9yIHRoZQ0KPiBhc3NlbWJseSBjb2RlIHdvdWxk IGJlIGZpeGVkLg0KPiANCg0KVGhhdCdzIHJlYWxseSBzbWFydCEgVGhhbmtzIQ0KDQpJJ3ZlIGRv bmUgYSBsaXR0bGUgdHdpc3Qgb24geW91ciBkZXNpZ246IEkndmUgcHV0IGFsbCBzd2l0Y2hhYmxl IG9uZXMgaW4gdGhlIG1pZGRsZQ0KYWZ0ZXIgcmVnaW9ucyBkZWZpbmVkIGluIGFzc2VtYmx5LiBJ ZiBuZWFyIFhlbiBoZWFwIHJlZ2lvbiwgSSdtIGFmcmFpZCBpZiBvbmUgZGF5IGluIHRoZSBmdXR1 cmUsDQpzb21lb25lIGlzIGludHJvZHVjaW5nIGFub3RoZXIgZml4ZWQgcmVnaW9uIGluIEMsIHdl IHdpbGwgbGVhdmUgaG9sZXMgdGhlcmUuDQoNCnhlbl9tcHVtYXBbMF0gOiBYZW4gdGV4dA0KeGVu X21wdW1hcFsxXSA6IFhlbiByZWFkLW9ubHkgZGF0YQ0KeGVuX21wdW1hcFsyXSA6IFhlbiByZWFk LW9ubHkgYWZ0ZXIgaW5pdCBkYXRhDQp4ZW5fbXB1bWFwWzNdIDogWGVuIHJlYWQtd3JpdGUgZGF0 YQ0KeGVuX21wdW1hcFs0XSA6IFhlbiBCU1MNCiggRml4ZWQgTVBVIHJlZ2lvbiBkZWZpbmVkIGlu IGFzc2VtYmx5ICkNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQp4ZW5fbXB1bWFwWzVdOiBYZW4gaW5pdCBk YXRhDQp4ZW5fbXB1bWFwWzZdOiBYZW4gaW5pdCB0ZXh0DQp4ZW5fbXB1bWFwWzddOiBFYXJseSBG RFQNCnhlbl9tcHVtYXBbOF06IEd1ZXN0IG1lbW9yeSBzZWN0aW9uDQp4ZW5fbXB1bWFwWzldOiBE ZXZpY2UgbWVtb3J5IHNlY3Rpb24NCnhlbl9tcHVtYXBbMTBdOiBTdGF0aWMgc2hhcmVkIG1lbW9y eSBzZWN0aW9uDQooIGJvb3Qtb25seSBhbmQgc3dpdGNoaW5nIHJlZ2lvbnMgZGVmaW5lZCBpbiBD ICkNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tDQouLi4NCnhlbl9tcHVtYXBbbWF4X3hlbl9tcHVtYXAgLSAx XSA6IFhlbiBzdGF0aWMgaGVhcA0KKCBGaXhlZCBNUFUgcmVnaW9uIGRlZmluZWQgaW4gQyApDQot LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQ0KDQpBZnRlciByZS1vcmc6DQp4ZW5fbXB1bWFwWzBdIDogWGVuIHRl eHQNCnhlbl9tcHVtYXBbMV0gOiBYZW4gcmVhZC1vbmx5IGRhdGENCnhlbl9tcHVtYXBbMl0gOiBY ZW4gcmVhZC1vbmx5IGFmdGVyIGluaXQgZGF0YQ0KeGVuX21wdW1hcFszXSA6IFhlbiByZWFkLXdy aXRlIGRhdGENCnhlbl9tcHVtYXBbNF0gOiBYZW4gQlNTDQooIEZpeGVkIE1QVSByZWdpb24gZGVm aW5lZCBpbiBhc3NlbWJseSApDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KeGVuX21wdW1hcFs4XTogR3Vl c3QgbWVtb3J5IHNlY3Rpb24NCnhlbl9tcHVtYXBbOV06IERldmljZSBtZW1vcnkgc2VjdGlvbg0K eGVuX21wdW1hcFsxMF06IFN0YXRpYyBzaGFyZWQgbWVtb3J5IHNlY3Rpb24NCiggU3dpdGNoaW5n IHJlZ2lvbiApDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KLi4uDQp4ZW5fbXB1bWFwW21heF94ZW5fbXB1 bWFwIC0gMV0gOiBYZW4gc3RhdGljIGhlYXANCiggRml4ZWQgTVBVIHJlZ2lvbiBkZWZpbmVkIGlu IEMgKQ0KDQpJZiB5b3UncmUgZmluZSB3aXRoIGl0LCB0aGVuIG5leHQgc2VyaWUsIEknbGwgdXNl IHRoaXMgbGF5b3V0LCB0byBrZWVwIGJvdGgNCnNpbXBsZSBhc3NlbWJseSBhbmQgcmUtb3JnIHBy b2Nlc3MuDQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQoNCkNoZWVycywN Cg0KLS0NClBlbm55IFpoZW5nDQo= From xen-devel-bounces@lists.xenproject.org Wed Feb 01 05:40:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 05:40:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488116.756035 (Exim 4.92) (envelope-from ) id 1pN5qy-0000si-VC; Wed, 01 Feb 2023 05:40:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488116.756035; Wed, 01 Feb 2023 05:40:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5qy-0000sb-SU; Wed, 01 Feb 2023 05:40:16 +0000 Received: by outflank-mailman (input) for mailman id 488116; Wed, 01 Feb 2023 05:40:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN5qx-0000sV-DQ for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 05:40:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7e1b::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e680eadf-a1f2-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 06:40:14 +0100 (CET) Received: from DB9PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:1d9::22) by GV2PR08MB8076.eurprd08.prod.outlook.com (2603:10a6:150:7a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 05:39:59 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::fb) by DB9PR02CA0017.outlook.office365.com (2603:10a6:10:1d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Wed, 1 Feb 2023 05:39:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22 via Frontend Transport; Wed, 1 Feb 2023 05:39:58 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Wed, 01 Feb 2023 05:39:58 +0000 Received: from fb9d6ac4874c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 26F5AC15-6185-4D59-A10C-DE4A3B8618CB.1; Wed, 01 Feb 2023 05:39:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fb9d6ac4874c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Feb 2023 05:39:48 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by VI1PR08MB5326.eurprd08.prod.outlook.com (2603:10a6:803:12d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 1 Feb 2023 05:39:45 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 05:39:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e680eadf-a1f2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hxpFKNHzViWLAA9DiG4Oxyfyq64BtVV1CnamlGeQP+Y=; b=PK+oWnUkcJ8BbHzCVR1czHotJY5BhEBD+njgf1nvtTKQ+fvJNuWaaF8iYukCzPtDhQ6+7Rgt0bR9vpXjmmorDivYeXJV7v+G4j12iIViIgulaV6U7dMvqk2SNEEDiaqI8W33sxlfJzWt0z3sERIyypS1WUEJ1y77RwaNGS+CFM4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nl7io+6UkzJg9Vuok5eG3vzbeCVV8HE1O5L+N0ZyxBkuKNDSq4u5gkq6xD44djO3tUSc1HwN2ZtPEPuehB6JjF7AtxPUBYHz2UmyK9w+GfYNHfKuoHIGtG/8ynAZcw6mXS/ATyzdlZq324SPj+v92EIZyWg8BQa361qF3/5p1QcRRfKhE+h8zozi36ZUQIHLZqZ1Tniwmm1LftHwurpb6V4dNaDI10BKup4u6Tq7t/fYhjICiHR+5Q0/iAIWKgu9GJsfuSSOFDI9aeLld+91VP9VG3psmqwApTSrQOx54SdCfUkHfNlswf5FzkOxD+x7ie/1bdFU7RBIhYcbgxwhJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hxpFKNHzViWLAA9DiG4Oxyfyq64BtVV1CnamlGeQP+Y=; b=V+IaacA+j10K+dvrO6isV4CcC3+51OTBOwm/aR9qAvMWX1Ve/lHE0mmFFMHbVzCzKXitG0tOMlSeT+dZ+yz2qH28uYzyf2bknA0uOTFqeqDhU47h6fkGgxyKBKOxRjYnnRaW/tW/I4YN4owbGfdc+nnP17+gD35On8IwyrV7O+cgCFwxjMowx3BrsvTxPXuZ7qcIb9ZlZOTfcTxczhRRS7MVUBrR4VrT1gWUj+DTbPC1/dSQw+D+6r81jaMMQ/osSqfGOKEY4YBB0NQCPiCkT6s39QS3fcf7Ltx7e2p2URS5CPCeTNoV63Xk32VG6yXgh6acKH3LgZYyb59wxrZRwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hxpFKNHzViWLAA9DiG4Oxyfyq64BtVV1CnamlGeQP+Y=; b=PK+oWnUkcJ8BbHzCVR1czHotJY5BhEBD+njgf1nvtTKQ+fvJNuWaaF8iYukCzPtDhQ6+7Rgt0bR9vpXjmmorDivYeXJV7v+G4j12iIViIgulaV6U7dMvqk2SNEEDiaqI8W33sxlfJzWt0z3sERIyypS1WUEJ1y77RwaNGS+CFM4= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , "ayan.kumar.halder@xilinx.com" CC: Volodymyr Babchuk Subject: RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Topic: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Index: AQHZJxAhTWb1zeTHm029bSgcZo/2Yq6l4H6AgA7nVJCAAFMfgIAAHOxggAGXmACAARsywIAAc7oAgAFRxNA= Date: Wed, 1 Feb 2023 05:39:45 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-12-Penny.Zheng@arm.com> <7931e70f-3754-363c-28d8-5fde3198d70f@xen.org> <3c915633-ddb8-d1e4-f42e-064aaff168b2@xen.org> <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> In-Reply-To: <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4460F5F35D43C946BBD5A339B6084B94.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|VI1PR08MB5326:EE_|DBAEUR03FT049:EE_|GV2PR08MB8076:EE_ X-MS-Office365-Filtering-Correlation-Id: baeaa7b1-21f6-4767-ce03-08db0416c18c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YQ0PtNHaH53FJzyoHO+b5+2sIgyoVIS+EBf8NwL87GntckRSrWFy+zpjJuuVyKiz8FH7IddIB2Af4WIrugxvLx4yvFM5imQ9o3hBfmh1SsZMCI/co2I4sM5aPwoCU1x6C0R5SbUWgUbPCev7AApRKT1jc+8ZsTq+cJ+zg8Swg2ijnPPy4n48FenkNVryM6wlFz6hZ8wjSmGfsjSLBX/b/VbLWaRk9oyaCpxQNx77Hq6FfAnyNmA5QiG4rjBU/+t5OJD/zlF91nL14w8ATSVr0pigLhx/r7ASqqmrCHLl+CWAM9pg7DSl0n8XaoHlFMoSuEEHMOafETcX10tNOJ7A5D8YixPYsyNVCbCukgqcnXH6O8RDRCitu8bJmmIpElAhXQzFRyb8XMfvMqfCLU3MjqDK9t0LoBQQGsIlFEvW2pwL49RsIrSgxXJoUMriObLla0N1XnI2HeLkn7kC0qm5xgnwcSlRARUoIGDh2efVJu/3B5ddO1TBRKA2pLI1RxVPybXmEugdPb5I/m0j6vH1UUs44BXY8Hp/ciwWsRcvRuXw00hA4JIRbPMu3SeHT2iNyDKh3oktnyhzFj0ojf8lRDbRtvxl8afyvQv8TWvrUF5kfZ41ZIIcFUxqK/1sGNYkzArxxRDPcGiZ22IAIsufsdljCpPwg7sM5otIb0cPXM6DF4F8YEC47u3CHtvdBCjORehuZNb0qcy+Y3ZefndKyw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199018)(316002)(110136005)(8936002)(33656002)(55016003)(2906002)(52536014)(5660300002)(38070700005)(86362001)(122000001)(38100700002)(66946007)(66556008)(4326008)(66476007)(66446008)(64756008)(76116006)(8676002)(83380400001)(41300700001)(7696005)(478600001)(186003)(26005)(9686003)(53546011)(6506007)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5326 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6d3db0a5-c615-450f-6a95-08db0416b9c6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2xtmIhHISOY15rl6u7agtCaZNKlSJDFeftMe+QlO+j3O8NVzmHNJpEL848IFCCD7ZB2HL0oOx6nxryOS8mYJKEGbPtq92k1D912JokV0my5UlI3sWEKqWM+w2dmnVzTQTI3VghOWehm1Y350tntWFD6U6c1MvSg5kl6idFeA0hwPyept2rZ0SFj9CjiGRb3rjzy1J9ESyeQxRdybE2A/HQzqbbUWsRbezp7MctKVeAnGtSotobb03byHtNS/SdFJT6rRObr+O5nhQN+yPE0dHjIDo7vpSZitmoAqiS/RuLYI52lMgw6iV4U3egjp1Sfyx1+oTMNO0008CIgpt7R9wGafpW0qCHhRsZTXrw5Pk0+YmGRpuDaKEo39KTzMj67wOsR+20GgB0GfZ7TZA3JuATiMhy6+faURSRsDZei8nSldQ2PAUjTXczdNr4lodB0X5yS4CQmCPBp9ngsUf//JLGwu7MocxgcLwr8Ap/5JAcqVV7UhdShFP0brk3QJIb2pz3Vb3lRCyrMCd+fAqzc2SKArg4uHhODenQ7CV8+5coXKSUdZUBMDqy7T2uFKFD1jkP8t+A+Ye1k4jNmYYyUqzpXY8RucHp+fCCAmMiI6QJ9ZJNPGz+JPrhaJpOPjtuiozTL2lVdgJnhp9Gdqnv/aSP7vkxoDvLpTXwK4H2S4nIJKYRAHJs74sohqkDV26/gRHhxJDI0hJJIy03sKoMyE1w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(136003)(376002)(346002)(451199018)(36840700001)(40470700004)(46966006)(40460700003)(5660300002)(53546011)(6506007)(81166007)(356005)(186003)(9686003)(26005)(82740400003)(107886003)(82310400005)(316002)(52536014)(110136005)(40480700001)(33656002)(478600001)(70206006)(55016003)(7696005)(83380400001)(336012)(2906002)(4326008)(86362001)(8676002)(47076005)(70586007)(8936002)(36860700001)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 05:39:58.6079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baeaa7b1-21f6-4767-ce03-08db0416c18c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8076 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFR1ZXNkYXksIEphbnVhcnkgMzEsIDIw MjMgNToyOCBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7DQo+IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29t PjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJh bmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4gYXlhbi5rdW1hci5oYWxk ZXJAeGlsaW54LmNvbQ0KPiBDYzogVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVr QGVwYW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDExLzQwXSB4ZW4vbXB1OiBidWls ZCB1cCBzdGFydC1vZi1kYXkgWGVuIE1QVQ0KPiBtZW1vcnkgcmVnaW9uIG1hcA0KPiANCj4gDQo+ IA0KPiBPbiAzMS8wMS8yMDIzIDA0OjExLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBIaSBKdWxp ZW4NCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+PiBGcm9tOiBKdWxp ZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+PiBTZW50OiBNb25kYXksIEphbnVhcnkgMzAs IDIwMjMgNTo0MCBQTQ0KPiA+PiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+ OyB4ZW4tDQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4+IENjOiBXZWkgQ2hlbiA8 V2VpLkNoZW5AYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+PiA8c3N0YWJlbGxpbmlA a2VybmVsLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJt LmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ID4+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNv bT4NCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxMS80MF0geGVuL21wdTogYnVpbGQgdXAg c3RhcnQtb2YtZGF5IFhlbiBNUFUNCj4gPj4gbWVtb3J5IHJlZ2lvbiBtYXANCj4gPj4NCj4gPj4g SGkgUGVubnksDQo+ID4+DQpbLi4uXQ0KPiA+Pg0KPiA+PiBJIHdvdWxkIHN1Z2dlc3QgdG8gaW52 ZXN0aWdhdGUgdGhlIGNvc3Qgb2YgImh1bnRpbmcgZG93biBlYWNoIHNlY3Rpb24iLg0KPiA+PiBE ZXBlbmRpbmcgb24gdGhlIHJlc3VsdCwgd2UgY2FuIGRpc2N1c3Mgd2hhdCB0aGUgYmVzdCBhcHBy b2FjaC4NCj4gPj4NCj4gPg0KPiA+IENvcnJlY3QgbWUgaWYgSSdtIHdyb25nLCB0aGUgY29tcGxp Y2F0ZWQgdGhpbmdzIGluIGFzc2VtYmx5IHlvdSBhcmUNCj4gPiB3b3JyaWVkIGFib3V0IGlzIHRo YXQgd2UgY291bGRuJ3QgZGVmaW5lIHRoZSBpbmRleCBmb3IgaW5pdGlhbCBzZWN0aW9ucywgbm8N Cj4gaGFyZGNvZGVkIHRvIGtlZXAgc2ltcGxlLg0KPiANCj4gQ29ycmVjdC4NCj4gDQo+ID4gQW5k IGZ1bmN0aW9uIHdyaXRlX3ByLCBpaywgaXMgcmVhbGx5IGEgYmlnIGNodW5rIG9mIGNvZGVzLCBo b3dldmVyIHRoZQ0KPiA+IGxvZ2ljIGlzIHNpbXBsZSB0aGVyZSwganVzdCBhIGJ1bmNoIG9mICJz d2l0Y2gtY2FzZXMiLg0KPiANCj4gSSBhZ3JlZSB0aGF0IHdyaXRlX3ByKCkgaXMgYSBidW5jaCBv ZiBzd2l0Y2gtY2FzZXMuIEJ1dCB0aGVyZSBhcmUgYSBsb3Qgb2YNCj4gZHVwbGljYXRpb24gaW4g aXQgYW5kIHRoZSBpbnRlcmZhY2UgdG8gdXNlIGl0IGlzLCBJTUhPLCBub3QgaW50dWl0aXZlLg0K PiANCj4gPg0KPiA+IElmIHdlIGFyZSBhZGRpbmcgTVBVIHJlZ2lvbnMgaW4gc2VxdWVuY2UgYXMg eW91IHN1Z2dlc3RlZCwgd2hpbGUgdXNpbmcNCj4gPiBiaXRtYXAgYXQgdGhlIHNhbWUgdGltZSB0 byByZWNvcmQgdXNlZCBlbnRyeS4NCj4gPiBUQkgsIHRoaXMgaXMgaG93IEkgZGVzaWduZWQgYXQg dGhlIHZlcnkgYmVnaW5uaW5nIGludGVybmFsbHkuIFdlIGZvdW5kDQo+ID4gdGhhdCBpZiB3ZSBk b24ndCBkbyByZW9yZyBsYXRlLWJvb3QgdG8ga2VlcCBmaXhlZCBpbiBmcm9udCBhbmQNCj4gPiBz d2l0Y2hpbmcgb25lcyBhZnRlciwgZWFjaCB0aW1lIHdoZW4gd2UgZG8gdmNwdSBjb250ZXh0IHN3 aXRjaCwgbm90DQo+ID4gb25seSB3ZSBuZWVkIHRvIGh1bnQgZG93biBzd2l0Y2hpbmcgb25lcyB0 byBkaXNhYmxlLCB3aGlsZSB3ZSBhZGQgbmV3DQo+ID4gc3dpdGNoLWluIHJlZ2lvbnMsIHVzaW5n IGJpdG1hcCB0byBmaW5kIGZyZWUgZW50cnkgaXMgc2F5aW5nIHRoYXQgdGhlDQo+IHByb2Nlc3Mg aXMgdW5wcmVkaWN0YWJsZS4gVW5jZXJ0YWludHkgaXMgd2hhdCB3ZSB3YW50IHRvIGF2b2lkIGlu IEFybXY4LVINCj4gYXJjaGl0ZWN0dXJlLg0KPiANCj4gSSBkb24ndCB1bmRlcnN0YW5kIHdoeSBp dCB3b3VsZCBiZSB1bnByZWRpY3RhYmxlLiBGb3IgYSBnaXZlbiBjb21iaW5hdGlvbg0KPiBvZiBw bGF0Zm9ybS9kZXZpY2UtdHJlZSwgdGhlIGJpdG1hcCB3aWxsIGFsd2F5cyBsb29rIHRoZSBzYW1l LiBTbyB0aGUNCj4gbnVtYmVyIG9mIGN5Y2xlcy9pbnN0cnVjdGlvbnMgd2lsbCBhbHdheXMgYmUg dGhlIHNhbWUuDQo+IA0KDQpJbiBib290LXRpbWUsIGl0IHdpbGwgYmUgYWx3YXlzIHRoZSBzYW1l LiBCdXQgaWYgd2Ugc3RpbGwgdXNlIGJpdG1hcCB0byBmaW5kIGZyZWUNCmVudHJ5KGZvciBzd2l0 Y2hpbmcgTVBVIHJlZ2lvbnMpIG9uIHJ1bnRpbWUsIGhtbW0sIEkgdGhvdWdodCB0aGlzIHBhcnQg d2lsbA0KYmUgdW5wcmVkaWN0YWJsZS4NCg0KPiBUaGlzIGlzIG5vdCB2ZXJ5IGRpZmZlcmVudCBm cm9tIHRoZSBjYXNlIHdoZXJlIHlvdSBzcGxpdCB0aGUgTVBVIGluIHR3bw0KPiBiZWNhdXNlDQo+ IA0KPiA+DQo+ID4gSG1tbSwgVEJILCBJIHJlYWxseSByZWFsbHkgbGlrZSB5b3VyIHN1Z2dlc3Rp b24gdG8gcHV0DQo+ID4gYm9vdC1vbmx5L3N3aXRjaGluZyByZWdpb25zIGludG8gaGlnaGVyIHNs b3QuIEl0IHJlYWxseSBzYXZlZCBhIGxvdA0KPiA+IHRyb3VibGUgaW4gbGF0ZS1pbml0IHJlb3Jn IGFuZCBhbHNvIGF2b2lkcyBkaXNhYmxpbmcgTVBVIGF0IHRoZSBzYW1lDQo+ID4gdGltZS4gVGhl IHNwbGl0IGlzIGEgc2ltcGxlIGFuZCBlYXN5LXRvLXVuZGVyc3RhbmQgY29uc3RydWN0aW9uIGNv bXBhcmVkDQo+IHdpdGggYml0bWFwIHRvby4NCj4gDQo+IEkgd291bGQgbGlrZSB0byBwcm9wb3Nl IGFub3RoZXIgc3BsaXQuIEkgd2lsbCByZXBseSB0byB0aGF0IGluIHRoZSB0aHJlYWQgd2hlcmUN Cj4geW91IHByb3ZpZGVkIHRoZSBNUFUgbGF5b3V0Lg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0N Cj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Wed Feb 01 06:27:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 06:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488121.756047 (Exim 4.92) (envelope-from ) id 1pN6Zx-0006m6-F8; Wed, 01 Feb 2023 06:26:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488121.756047; Wed, 01 Feb 2023 06:26:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN6Zx-0006lz-Br; Wed, 01 Feb 2023 06:26:45 +0000 Received: by outflank-mailman (input) for mailman id 488121; Wed, 01 Feb 2023 06:26:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN6Zw-0006lp-Kw; Wed, 01 Feb 2023 06:26:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN6Zw-0006aT-Ji; Wed, 01 Feb 2023 06:26:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN6Zw-00029E-63; Wed, 01 Feb 2023 06:26:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN6Zw-00062U-5d; Wed, 01 Feb 2023 06:26:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y1dTmUFOFpsLraV8oZQjYbRLp+zErQJ4tikItCON5IM=; b=xLVEwR56sh24grayoojIyGbYoJ nMem4Bdjg/561oGLMyp72uMJkjTNI/SyLx9xN88Z8ChyFVSVqbp4ZdkfEAe6XNxxxflMeMxkDoQPc GVkIU/EK83SZTJBHvUvD2yjXFmIvqf8LBAOXlYeAzRix319Ef8n9Im8jNAa1t2oBxIUI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176308: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 06:26:44 +0000 flight 176308 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176308/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 5 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 07:24:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 07:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488130.756058 (Exim 4.92) (envelope-from ) id 1pN7TI-00062V-Mx; Wed, 01 Feb 2023 07:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488130.756058; Wed, 01 Feb 2023 07:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7TI-00062O-Je; Wed, 01 Feb 2023 07:23:56 +0000 Received: by outflank-mailman (input) for mailman id 488130; Wed, 01 Feb 2023 07:23:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7TH-00062E-A5; Wed, 01 Feb 2023 07:23:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7TH-0007ph-6i; Wed, 01 Feb 2023 07:23:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7TG-0004zH-P9; Wed, 01 Feb 2023 07:23:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN7TG-0006DF-Ok; Wed, 01 Feb 2023 07:23:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3aQbv57jt+VgUt260FgT0cgC8BsjqeHO9KmafQ2uwGU=; b=j+bZbtMtIXYth6xGqj9plTQd8c lXimEvDpPLD1jjspGzW0jFfNEGlfimEEKCZQlbTzcAXz7sVMzkMIoszi314znC4Zp3wJlQJtH7FFA ow9g5cvlJl+oZH4AmeJ7vK6uEkl7LzVwxcK9hfzTp2u4ZTkZBkh2tOtEwx6CwbdvFEgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176297: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow::broken:regression xen-unstable:build-armhf::broken:regression xen-unstable:build-armhf:host-install(4):broken:regression xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64::broken:regression xen-unstable:test-amd64-amd64-xl-pvhv2-intel::broken:regression xen-unstable:test-amd64-i386-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:build-armhf:syslog-server:running:regression xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-pvhv2-intel:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-examine:host-install:broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:host-ping-check-native:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:build-armhf:capture-logs:broken:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=10b80ee5588e8928b266dea02a5e99d098bd227a X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Wed, 01 Feb 2023 07:23:54 +0000 flight 176297 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176297/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 175994 test-amd64-i386-xl-qemuu-ovmf-amd64 broken in 176268 test-amd64-amd64-xl-pvhv2-intel broken in 176268 test-amd64-i386-libvirt-pair broken in 176268 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 176284 build-arm64-pvops 6 kernel-build fail in 176266 REGR. vs. 175994 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 5 host-install(5) broken in 176268 pass in 176297 test-amd64-amd64-xl-pvhv2-intel 5 host-install(5) broken in 176268 pass in 176297 test-amd64-i386-libvirt-pair 6 host-install/src_host(6) broken in 176268 pass in 176297 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 176284 pass in 176297 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 5 host-install(5) broken pass in 176277 test-amd64-amd64-examine 5 host-install broken pass in 176277 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail in 176268 pass in 176266 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 176268 pass in 176297 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176268 pass in 176297 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 6 host-ping-check-native fail in 176277 pass in 176268 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 176277 pass in 176297 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 176277 pass in 176297 test-amd64-i386-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail in 176277 pass in 176297 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176277 pass in 176297 test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail in 176284 pass in 176297 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail pass in 176284 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 176266 n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175994 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 176284 like 175994 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 176277 n/a version targeted for testing: xen 10b80ee5588e8928b266dea02a5e99d098bd227a baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 11 days Failing since 176003 2023-01-20 17:40:27 Z 11 days 23 attempts Testing same since 176222 2023-01-26 22:13:29 Z 5 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken broken-job build-armhf broken broken-step build-armhf capture-logs broken-step test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow host-install(5) broken-step build-armhf host-install(4) broken-step test-amd64-amd64-examine host-install broken-job build-armhf broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemuu-ovmf-amd64 broken broken-job test-amd64-amd64-xl-pvhv2-intel broken broken-job test-amd64-i386-libvirt-pair broken broken-job build-armhf broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken broken-job test-amd64-i386-xl-qemuu-ovmf-amd64 broken Not pushing. (No revision log; it would be 1225 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 07:31:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 07:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488139.756068 (Exim 4.92) (envelope-from ) id 1pN7aF-0007rb-I8; Wed, 01 Feb 2023 07:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488139.756068; Wed, 01 Feb 2023 07:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7aF-0007rU-FE; Wed, 01 Feb 2023 07:31:07 +0000 Received: by outflank-mailman (input) for mailman id 488139; Wed, 01 Feb 2023 07:31:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7aE-0007rO-6o for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 07:31:06 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6224fcd2-a202-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 08:31:04 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso2073111wmb.0 for ; Tue, 31 Jan 2023 23:31:04 -0800 (PST) Received: from [192.168.1.93] (adsl-184.109.242.224.tellas.gr. [109.242.224.184]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c310a00b003db30be4a54sm835517wmo.38.2023.01.31.23.31.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 23:31:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6224fcd2-a202-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JCnrAqJEVHxPW26rKJcQaouQVlcy/LvyniwfBABmy9A=; b=Upepx/mL8v8t/75DyHuAfV7cncRLiuGRg8qsNZLgendg8s45aaYTQ1rfiCR2HVjGN0 6Rc7fVFueSx0W7P6wnPriRjbKSJlzr9cWB8OLR8vTuO6QAul6A5aSFZ0twIWwm/ZkwqQ gNXDcY5epCbXhDOxchVD3p2x5r3UsMnBc0f/OQ/XRZk5on55tqwZO/dPqWOcnhjtQRNX z7f7gxj2Bb+8RzoNKJnyLhuVsnby3pQSbVz7/GzDGIojUtTUpQbtoaS41Hs05y5zCPLN XoQO2FeO5gT2jT1GFIZwfxmXlG8TsKuBPjAS8FTUbbYBBdqsZ/7sOwIDx3AEG+OFgRZk hBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JCnrAqJEVHxPW26rKJcQaouQVlcy/LvyniwfBABmy9A=; b=peftM/b+vfHgyDt63iYNUNF3+vZmM46KeE9e2SQ6mLmi8DPK8xe2ceJqDAORVblLyX kRCLr9xxjtJOzmnk5IYF9u9011WkwzoD9QW9Y1VqiJalzbduVuTVsrXnTAj8XNTEldoI KLjIP3/bqgHsnlS8wgPuSnyd1Qk+gxTIh1fYDtxAQC8/H2lTmI3+FDlJGE5TLemeFv+h IowvZrpd7OhdppKM8nFwGvQ3kyXuIJeAPTfdyfVoyxsBATnKsTXLoo/N5pzDrPAdEObw 0EgsSKXcpitR6wDbNuLuEx+8ItlnaTdka6QSbqECargl9jrVhXi2gy12jziqRHpIlmk8 OEYw== X-Gm-Message-State: AO0yUKVlA3Le8Lkb6mVmk+lOt7Viaf7nEngDocrU+pqwfkKgCujmvhmt TFA0v2aA9K6MHTuUyat8MWE= X-Google-Smtp-Source: AK7set92n7LTq8tO2jp4NicCauKVDFLRK0yHDSiDCYdWUWvIwqMmjzpVz/s+GGlA627bH8laZqpx6w== X-Received: by 2002:a05:600c:3489:b0:3da:f670:a199 with SMTP id a9-20020a05600c348900b003daf670a199mr898894wmq.36.1675236663422; Tue, 31 Jan 2023 23:31:03 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 09:31:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Content-Language: en-US To: "Tian, Kevin" , "xen-devel@lists.xenproject.org" Cc: "Beulich, Jan" , Paul Durrant , =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/1/23 07:07, Tian, Kevin wrote: >> From: Xenia Ragiadakou >> Sent: Tuesday, January 24, 2023 8:42 PM >> >> The variable untrusted_msi indicates whether the system is vulnerable to >> CVE-2011-1898 due to the absence of interrupt remapping support. >> Although AMD iommus with interrupt remapping disabled are also affected, >> this case is not handled yet. Given that the issue is not VT-d specific, >> and to accommodate future use of the flag for covering also the AMD iommu >> case, move the definition of the flag out of the VT-d specific code to the >> common x86 iommu code. >> >> Also, since the current implementation assumes that only PV guests are >> prone >> to this attack, take the opportunity to define untrusted_msi only when PV is >> enabled. >> > > I'm fine with this change given no functional change. > > But I'm curious about the statement here that the current code only > applies to PV guest. I didn't see such statement in original mail [1] > and in concept a HVM guest with passthrough device can also do such > attack w/o interrupt remapping. > > Any more context? I agree. I phrased it that way because currently the mitigation addresses only maliciously injected PV traps. > > [1] http://old-list-archives.xenproject.org/archives/html/xen-devel/2011-05/msg00687.html -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Feb 01 07:54:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 07:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488144.756080 (Exim 4.92) (envelope-from ) id 1pN7wx-0002XG-Em; Wed, 01 Feb 2023 07:54:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488144.756080; Wed, 01 Feb 2023 07:54:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7wx-0002X9-BD; Wed, 01 Feb 2023 07:54:35 +0000 Received: by outflank-mailman (input) for mailman id 488144; Wed, 01 Feb 2023 07:54:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN7wv-0002X3-Ai for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 07:54:33 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a53a09c3-a205-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 08:54:25 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id bg26so6133738wmb.0 for ; Tue, 31 Jan 2023 23:54:30 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id b9-20020a05600c150900b003daf672a616sm859085wmg.22.2023.01.31.23.54.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 23:54:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a53a09c3-a205-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=tF6b+FZ/vwEGQ06h3xdBxOjcTdoCvjB2eFH4X/PWMV4=; b=Zbid6yH79dOqTUGKoJSIoLLd2f6TRIAjljirZ81diqB8MS7s7mlxRLkroDfxceGSdl bXyXP9+QrRy3Q+k8RZzahbPnaGmVWtJQPPlvliRPAdS+Ygu6ZXBr7OWuTerjNKgWAoo+ 4JXUGRVPtwVxD71yAQFIrfGDtERb5og505GUm/0fItQ/KzQYqxDgviYHEWG5xJHPTTYK MVIQyErxK/kfaYA5EXEY31LbrULJy0XNYjHdk2kaWeFVqBvouHwTxa1czRsBXFu1ExZb AKQspaREGPTMp3SKBdso7g9xn9nBkwanoJ+2Xck11QIU+cFzFddXHc09yHjmTTH+TPI+ EsiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tF6b+FZ/vwEGQ06h3xdBxOjcTdoCvjB2eFH4X/PWMV4=; b=60sLo7lnFAp6lmZSPrFcX84w3Mf5vkuf5ugHPlpCEOu2TZsNMaF1vfujG7cErzcJJX Xj6P8yeF1Q3wB7Fqrnzce1fILYMkt6WBNUukBldUByUuMUjzaSgj6fB/bNVx4Iim9Etp nT+IettsKUJjQ38UgXj9tmEdFXX5dRVoM+mIhPIp3p8N36rkiDr3QH5cUuanFBhlLlZM +C5c6fiYQ37jd9WTOf2mfoonNfMNK0yfzYwfTDGjXMPArte14thAERiOs6+cM3MiJs42 1/dzmYToYLd8JcXo5/pUxNqX6chzN9ht/AoZ0xw9AQkbJgwdGLScTERi2Pwq176gReLH 2U1Q== X-Gm-Message-State: AO0yUKURarMVg57mG2FeAx2qOwVu3nY0SukgEPbP39NcnjsVMeVl6fxH YZd255ejDAlf8aunJZqBcgA= X-Google-Smtp-Source: AK7set8UFjNEV3CqydT78jA5XvU/Hwp9p7Lzv1PCa3cZdV7qvdbW/Vp4fBbafqW4ng7hwbxQO7e/5g== X-Received: by 2002:a05:600c:b88:b0:3d3:5a4a:9103 with SMTP id fl8-20020a05600c0b8800b003d35a4a9103mr1022429wmb.31.1675238070338; Tue, 31 Jan 2023 23:54:30 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <8b43c153-8c7c-1834-11d6-b3d9c73e2893@xen.org> Date: Wed, 1 Feb 2023 07:54:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Stefano Stabellini , Anthony Perard References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-2-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-2-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > xen-mapcache.c contains common functions which can be used for enabling Xen on > aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it > accessible for both aarch64 and x86. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini > --- > hw/i386/meson.build | 1 + > hw/i386/xen/meson.build | 1 - > hw/i386/xen/trace-events | 5 ----- > hw/xen/meson.build | 4 ++++ > hw/xen/trace-events | 5 +++++ > hw/{i386 => }/xen/xen-mapcache.c | 0 > 6 files changed, 10 insertions(+), 6 deletions(-) > rename hw/{i386 => }/xen/xen-mapcache.c (100%) > Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:01:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:01:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488150.756091 (Exim 4.92) (envelope-from ) id 1pN83Q-0004pf-E8; Wed, 01 Feb 2023 08:01:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488150.756091; Wed, 01 Feb 2023 08:01:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN83Q-0004pY-Ay; Wed, 01 Feb 2023 08:01:16 +0000 Received: by outflank-mailman (input) for mailman id 488150; Wed, 01 Feb 2023 08:01:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN83P-0004pS-4V for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:01:15 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 991e6a5c-a206-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:01:14 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id q8so11978227wmo.5 for ; Wed, 01 Feb 2023 00:01:14 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id e18-20020a05600c4e5200b003dc1f466a25sm950849wmq.25.2023.02.01.00.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:01:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 991e6a5c-a206-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=tymDbNnZpQDXwy3rfuwrhJj7HPDQs8cQ+0cSJgozvc4=; b=NJzFFqJ2YsatpZ7udiQFrj0iSc3ZzMp6IojPkq6WMXGf4ov2khQi3tFnGi8nlfSnNL UDmBuUHFoH3rLj992LsptKLq0VJ4K6+H13vpqkzo4q42PyMgIPA6+5B1V1oND0NCQA4g dCNn04zmEei837pXi8wkud02fyAJ7IEiTLunmdVs2m0N1G6iq5Mjs7t3xhmZ9aH75+6g PJXKu4DnTb+OS9EJ6OHtCB9hpyQvx5enBhz3L8BK6yP8BY/OL/zDN2+8jH1fP4+qgcu+ n6dMnssALHBR6g+SBGpCwqezx70TNrGZsWmCEGtJ5n2sy3r9E99qKOgsrepjECqRJqKA aChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tymDbNnZpQDXwy3rfuwrhJj7HPDQs8cQ+0cSJgozvc4=; b=Wx+3G2A0HJZyi0irRvHQ3Q/ellwM4Yj0t1meaxbDOG7MHSZna9ozXQlD0Y2b7uWq8M mc4WVdSfG/P5UtU0fDWXFREDF70n+tXNYPjnXP/d2831ItOf8g3hW/t2KYUPOq1JPlBv Me1VFQpCiFg5j6+E0rUrskObdc0Kc8Co+RCZ/f/WJEpXUC0oBjcsvGbtrHKkWRC6F1JA yUU729G4wuqzcBXI9Nimlsg/8lBcghwErXF4b3PCbcYP7ulViq1Smn828PQe5+uTzEYe aHc/PSBLaWmw4Vc7tpeTxLJWsI9nOZ4gwCH4KuBqJu+yQ6NSweDqjaYwEde0EWaR2zP5 OgOw== X-Gm-Message-State: AO0yUKVWkjJWM4YLGRWgtW0xAKJVnZSDrm9zEYT2EKyYcr6U4Nf/13eJ pbBpm/qbCACEfrykAKtCIdA= X-Google-Smtp-Source: AK7set+rqD7bnAoFLZkN+q1G35EYiojdGNZQpQwl/easXWfAl2aoQ7RNm2jDhDyB8vx+pvg4MYsrTQ== X-Received: by 2002:a05:600c:42ca:b0:3dc:58fb:c1eb with SMTP id j10-20020a05600c42ca00b003dc58fbc1ebmr1069408wme.8.1675238473672; Wed, 01 Feb 2023 00:01:13 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <3c54b871-b14c-9fc1-fd80-1d01d506035c@xen.org> Date: Wed, 1 Feb 2023 08:01:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Stefano Stabellini , Anthony Perard , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-5-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-5-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > From: Stefano Stabellini > > This patch does following: > 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in > preparation for moving most of xen-hvm code to an arch-neutral location, > move the x86-specific portion of xen_set_memory to arch_xen_set_memory. > Also, move handle_vmport_ioreq to arch_handle_ioreq. > > 2. Pure code movement: move common functions to hw/xen/xen-hvm-common.c > Extract common functionalities from hw/i386/xen/xen-hvm.c and move them to > hw/xen/xen-hvm-common.c. These common functions are useful for creating > an IOREQ server. > > xen_hvm_init_pc() contains the architecture independent code for creating > and mapping a IOREQ server, connecting memory and IO listeners, initializing > a xen bus and registering backends. Moved this common xen code to a new > function xen_register_ioreq() which can be used by both x86 and ARM machines. > > Following functions are moved to hw/xen/xen-hvm-common.c: > xen_vcpu_eport(), xen_vcpu_ioreq(), xen_ram_alloc(), xen_set_memory(), > xen_region_add(), xen_region_del(), xen_io_add(), xen_io_del(), > xen_device_realize(), xen_device_unrealize(), > cpu_get_ioreq_from_shared_memory(), cpu_get_ioreq(), do_inp(), > do_outp(), rw_phys_req_item(), read_phys_req_item(), > write_phys_req_item(), cpu_ioreq_pio(), cpu_ioreq_move(), > cpu_ioreq_config(), handle_ioreq(), handle_buffered_iopage(), > handle_buffered_io(), cpu_handle_ioreq(), xen_main_loop_prepare(), > xen_hvm_change_state_handler(), xen_exit_notifier(), > xen_map_ioreq_server(), destroy_hvm_domain() and > xen_shutdown_fatal_error() > > 3. Removed static type from below functions: > 1. xen_region_add() > 2. xen_region_del() > 3. xen_io_add() > 4. xen_io_del() > 5. xen_device_realize() > 6. xen_device_unrealize() > 7. xen_hvm_change_state_handler() > 8. cpu_ioreq_pio() > 9. xen_exit_notifier() > > 4. Replace TARGET_PAGE_SIZE with XC_PAGE_SIZE to match the page side with Xen. > > Signed-off-by: Vikram Garhwal > Signed-off-by: Stefano Stabellini > --- > hw/i386/xen/trace-events | 14 - > hw/i386/xen/xen-hvm.c | 1019 ++----------------------------- > hw/xen/meson.build | 5 +- > hw/xen/trace-events | 14 + > hw/xen/xen-hvm-common.c | 874 ++++++++++++++++++++++++++ > include/hw/i386/xen_arch_hvm.h | 11 + > include/hw/xen/arch_hvm.h | 3 + > include/hw/xen/xen-hvm-common.h | 98 +++ > 8 files changed, 1067 insertions(+), 971 deletions(-) > create mode 100644 hw/xen/xen-hvm-common.c > create mode 100644 include/hw/i386/xen_arch_hvm.h > create mode 100644 include/hw/xen/arch_hvm.h > create mode 100644 include/hw/xen/xen-hvm-common.h > Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:08:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488154.756102 (Exim 4.92) (envelope-from ) id 1pN8AB-0005le-5P; Wed, 01 Feb 2023 08:08:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488154.756102; Wed, 01 Feb 2023 08:08:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8AB-0005lX-1c; Wed, 01 Feb 2023 08:08:15 +0000 Received: by outflank-mailman (input) for mailman id 488154; Wed, 01 Feb 2023 08:08:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8A9-0005lR-Tw for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:08:13 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92c48f74-a207-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:08:13 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id t18so16478051wro.1 for ; Wed, 01 Feb 2023 00:08:13 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id z14-20020a5d4c8e000000b002bfc2d0eff0sm16515779wrs.47.2023.02.01.00.08.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:08:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92c48f74-a207-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=XLlFUHrB4dqS6ExW87vO+DxepZQxoiFn7C/Z7E/edp4=; b=J5lsL/WvlJtpwlCkxaBIktDEmFrZq9do3LodWXecQIlaSN808M3PUJdPiaBlVjjEfL mxHMkeTCQm4kjvhJbIgJHNjua+Vongih/8x+9hB2vYXgA3xloASuVblM7sxGSRht/cUI 7ni5SibR3vBuLiyowBC55G/fcqCcBaPRqsuJNE7BKVFMRj2jqkCTt9/aY9WDUn3o7Tsk YF5AOhzcXH9EVGMR53rq5US5f268bcqn5JQ/YiH4cGmD5co84T28Hl161CAGeNvn9Qlr Oc883oIWTm3Q8ZpdOW6FHtZvgsYNtqYBDpgHpFo22uCXCog+UvdpCC3OuP5RZlR0N5GS jnmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XLlFUHrB4dqS6ExW87vO+DxepZQxoiFn7C/Z7E/edp4=; b=eZuqEaEmMEcEzGuhcfP8aSyw2qwwuzAZSJlJjDI8ldv7WRdxm6iCR7o/ZKFU0bCoqv 6lcog/VnqV3oizPkLtm6LSZq/3HXq8kK4p8kJmHBEScOF+NGKX+n/LH8r7R9FM29qjdY e9N2iODQPlO281RshSyJe22uPAfQ1J4fcVjqcUCCzM0oJvdPRcnarc/bBI6voHp1EPhg Yskx9e/ShwMusGY9qLcnArfqbFovekf7zdxMGXDOPZ1Lww3L0Q7GRb+w+Quk8+QN9X1K jRb7QqyXWeO/vAq0UDzzTSVhJ3YEK5B6neQmJqlNV1gA07n9qFdGlolNlEdpuyIrM0LK T5/w== X-Gm-Message-State: AO0yUKWtqudO9Bg1IWV/IGE8ETv5+R2SKEUHgLgooRgagpI0RYQlSp80 s2K18rMdjo1pT5eRJpRVqAM= X-Google-Smtp-Source: AK7set8LPP76RGbDt/11bG6XWEjesbfQuJXYL/6cDcAr8FSy4JhHXJC9/IJSIGblrRI1R1oIYFvIMQ== X-Received: by 2002:adf:f54a:0:b0:2bf:e7f0:b273 with SMTP id j10-20020adff54a000000b002bfe7f0b273mr1521846wrp.18.1675238892660; Wed, 01 Feb 2023 00:08:12 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <6153d2e4-c00b-f966-f2f8-7eb34270dfd1@xen.org> Date: Wed, 1 Feb 2023 08:08:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Stefano Stabellini , Anthony Perard References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-6-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-6-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > From: Stefano Stabellini > > This is done to prepare for enabling xenpv support for ARM architecture. > On ARM it is possible to have a functioning xenpv machine with only the > PV backends and no IOREQ server. If the IOREQ server creation fails, > continue to the PV backends initialization. > > Signed-off-by: Stefano Stabellini > Signed-off-by: Vikram Garhwal > Reviewed-by: Stefano Stabellini > --- > include/hw/xen/xen_common.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:11:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488158.756113 (Exim 4.92) (envelope-from ) id 1pN8D7-00079h-K1; Wed, 01 Feb 2023 08:11:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488158.756113; Wed, 01 Feb 2023 08:11:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8D7-00079a-GC; Wed, 01 Feb 2023 08:11:17 +0000 Received: by outflank-mailman (input) for mailman id 488158; Wed, 01 Feb 2023 08:11:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8D6-00079U-1k for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:11:16 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff56a7be-a207-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:11:15 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id y11so16808336edd.6 for ; Wed, 01 Feb 2023 00:11:15 -0800 (PST) Received: from [127.0.0.1] (dynamic-089-014-206-008.89.14.pool.telefonica.de. [89.14.206.8]) by smtp.gmail.com with ESMTPSA id w11-20020a50fa8b000000b0049e09105705sm9323996edr.62.2023.02.01.00.11.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:11:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff56a7be-a207-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SVVZZ7wS6QUXc/pYLeaK5exDkUy3Zt8bVZPG8D5u1No=; b=NNBDDLFB7AAMeRRFqJyd16OykOpWZFx+Aa0wFjgE6eFwenVdG/7sfGnHLqv/pYLL3h iW0X8t01DYuVnr+K87C7he1+16XUTSRBH1V3Xah0KYa+N9ZBDhfSVEO4GUxZat+VT8TB 6laEuto6OZmr5tLV0GM6/GKNeWTtduYs3wTD4QeH8HD2Wqq6jOQy7QFpTJ98D2hXj6EV oSc2isVI4P9iXMMC7HLxcAphkIJsX7tK24mMoaFq0nF00NopIbAVisOv3fgk/dnGFriU nIo+X+ujkZRPMfsrQMPlVW1qgDIXpxJAn0l+Wix2Wiy7IYvJ1QQsVATPHNXkYOvvF5qy bO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SVVZZ7wS6QUXc/pYLeaK5exDkUy3Zt8bVZPG8D5u1No=; b=a+7LP+3Lkf7o3854ntsVAhYydP9G0Fo8g5qju6GKI7b2Lzk5AiutQvFnN7c2Q9q1M6 ndhVDy19LYDT2S1lDyJdPOg0zrW6Jwvwc7VQTn+r3ICyJEAs3413e7WF/rmvhzCoJ4Nq mOEoN2wVSvNfdEhv+YaF1VawztbtN+Ps9Rs7CeGS36xE14MMkl5uyywqf+XWhTXPdztn rnGxFJXz/4l1btoh1im2iUWJW5sao0tpPYIwieYN2w4kXq0xEhqW8bmaGqju6HnxKmzY MMYvRVdZ95Hg6XQDMvaM+tv0heoPjj6mpLsSWmZLhE3QpElSBY2Q2wBRnFFGyLswORV4 pTPw== X-Gm-Message-State: AO0yUKUhj5jWHS3owaZUQ5BbuGu8r4nkVXhy4GPOTDOftV+C+DTc15y+ +Og6EQI7ErfZWchPoAN1RsA= X-Google-Smtp-Source: AK7set+7Bf1JJ24v+v8g+VmLgOtiu+gqip0P1fEsOqCRHaUKiWt1HbYwUVeskgGrEKFjwvxZ7zjEhQ== X-Received: by 2002:aa7:c602:0:b0:499:d199:6614 with SMTP id h2-20020aa7c602000000b00499d1996614mr1058466edq.36.1675239074680; Wed, 01 Feb 2023 00:11:14 -0800 (PST) Date: Wed, 01 Feb 2023 08:11:10 +0000 From: Bernhard Beschow To: Anthony PERARD CC: qemu-devel@nongnu.org, Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Paolo Bonzini , Eduardo Habkost , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski , "Michael S. Tsirkin" Subject: Re: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE In-Reply-To: <0C2B1FE4-BB48-4C38-9161-6569BA1D6226@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230118051230-mutt-send-email-mst@kernel.org> <0C2B1FE4-BB48-4C38-9161-6569BA1D6226@gmail.com> Message-ID: <96A4863B-D6BA-48B5-B5E4-54DD103FEBAA@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 24=2E Januar 2023 17:07:30 UTC schrieb Bernhard Beschow : > > >Am 24=2E Januar 2023 16:11:47 UTC schrieb Anthony PERARD : >>On Wed, Jan 18, 2023 at 05:13:03AM -0500, Michael S=2E Tsirkin wrote: >>> On Wed, Jan 04, 2023 at 03:44:31PM +0100, Bernhard Beschow wrote: >>> > This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finall= y removes >>> > it=2E The motivation is to 1/ decouple PIIX from Xen and 2/ to make = Xen in the PC >>> > machine agnostic to the precise southbridge being used=2E 2/ will be= come >>> > particularily interesting once PIIX4 becomes usable in the PC machin= e, avoiding >>> > the "Frankenstein" use of PIIX4_ACPI in PIIX3=2E >>>=20 >>> Looks ok to me=2E >>> Reviewed-by: Michael S=2E Tsirkin >>>=20 >>> Feel free to merge through Xen tree=2E >> >>Hi Bernhard, > >Hi Anthony, > >>The series currently doesn't apply on master=2E And a quick try at >>applying the series it is based on also failed=2E Could you rebase it , = or >>maybe you would prefer to wait until the other series "Consolidate >>PIIX=2E=2E=2E" is fully applied? > >Thanks for looking into it! > >You can get the compilable series from https://patchew=2Eorg/QEMU/2023010= 4144437=2E27479-1-shentey@gmail=2Ecom/ =2E If it doesn't work for you let m= e know, then I can rebase onto master=2E All necessary dependencies for the= series are upstreamed meanwhile=2E Ping > >Thanks, >Bernhard >> >>Thanks=2E >> >>> > Testing done: >>> > None, because I don't know how to conduct this properly :( >>> >=20 >>> > Based-on: <20221221170003=2E2929-1-shentey@gmail=2Ecom> >>> > "[PATCH v4 00/30] Consolidate PIIX south bridges" >> From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:14:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:14:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488166.756124 (Exim 4.92) (envelope-from ) id 1pN8G2-0007qC-6c; Wed, 01 Feb 2023 08:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488166.756124; Wed, 01 Feb 2023 08:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8G2-0007q5-2v; Wed, 01 Feb 2023 08:14:18 +0000 Received: by outflank-mailman (input) for mailman id 488166; Wed, 01 Feb 2023 08:14:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8G1-0007py-Gw for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:14:17 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b6fc810-a208-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:14:16 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id j32-20020a05600c1c2000b003dc4fd6e61dso708680wms.5 for ; Wed, 01 Feb 2023 00:14:16 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id y21-20020a05600c17d500b003dc5b59ed7asm908852wmo.11.2023.02.01.00.14.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:14:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b6fc810-a208-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=F/Vw/HJ9804TPjURiNeMztP8GKmGdQ0ZmBWYFwpo6sU=; b=ZlfifIyYcmm5osq4qaA8KWeuTssdtaKbzI/RxY9BNRRxJdulfcKxI6RCF67Sg0HEjw 33uA6ueES666tBkvQCRFXxSvGDmvKPpm1fofdsA9pYbDV06C1SHaIWzRvFMYn3xxiDSM 2u10WnEyeMXV3flwSzSHXkW7fSmEtnqJVAZqAZuPnbvviJdQ4txp6BhDTvSN61betrMk mlh/AsHTHef0/Z28IwContLr5JlV5ActEY7xbeQnVaEhOkQL9MIWfvL4kZwMfbvzSCkf M+MEaxrJ5eDEeZHZnp/PLfC2Gc9dsHb2pnOUk+P9G++yvtD0Z7tfP5+HJPpC7v0UcH+C jdmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F/Vw/HJ9804TPjURiNeMztP8GKmGdQ0ZmBWYFwpo6sU=; b=HeikW5a/3KPip/MrVOV5OJH8d+ej05am1GSj3YJ3FRejlwier6nu+N9bmpnjEe56ur wii5tQT2Z3MD8OYvcMNnIJUzSDzU1zvYUQZo7u+iETf9hWzfSaRUy7qhcveZUNrYVoBR jxyG75vVdKgngcWdh8PWUmtIyAUS9NhtSEciAV0Gj0+75QIV5Z2H8nvmCB8H9CpznimA ZaIGy/04Ed7J5Y/r1/TeNgfNRX7uvqSX7woqKet+PkRy00NsaXMh5X06v9OTL4sNLL54 t6TpJXReXufTBKzUrjeFEEFChBoZS0p/jYbEwMSbaZH4h+ZVdV/MDaSaaBf4LUdy/0KK W2/w== X-Gm-Message-State: AO0yUKUPbgwkvicZj0qrCI+KqT9FJ38mQIk2SFEaUY2W27rDDfrNTRhz oIlbbJxvs7dw/4yS/TJ1Imw= X-Google-Smtp-Source: AK7set8FYyYat2mEAdrY3TWWOr2r1XU7G6WQmgtbej6WHPHtT9bkmmiNACZfL1ZRdyn4QWCiJ9vWCg== X-Received: by 2002:a05:600c:4e09:b0:3dc:4633:9844 with SMTP id b9-20020a05600c4e0900b003dc46339844mr1219238wmq.17.1675239256096; Wed, 01 Feb 2023 00:14:16 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <38dbb7bf-91aa-8254-728e-53001a4f0439@xen.org> Date: Wed, 1 Feb 2023 08:14:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Stefano Stabellini , Anthony Perard References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-7-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-7-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > From: Stefano Stabellini > > On ARM it is possible to have a functioning xenpv machine with only the > PV backends and no IOREQ server. If the IOREQ server creation fails continue > to the PV backends initialization. > > Also, moved the IOREQ registration and mapping subroutine to new function > xen_do_ioreq_register(). > > Signed-off-by: Stefano Stabellini > Signed-off-by: Vikram Garhwal > Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-hvm-common.c | 53 ++++++++++++++++++++++++++++------------- > 1 file changed, 36 insertions(+), 17 deletions(-) Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:15:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:15:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488171.756135 (Exim 4.92) (envelope-from ) id 1pN8HB-0000Fb-H6; Wed, 01 Feb 2023 08:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488171.756135; Wed, 01 Feb 2023 08:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8HB-0000FT-DP; Wed, 01 Feb 2023 08:15:29 +0000 Received: by outflank-mailman (input) for mailman id 488171; Wed, 01 Feb 2023 08:15:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8HA-0000FG-PR for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:15:28 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 960bd83f-a208-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:15:28 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id k16so12024016wms.2 for ; Wed, 01 Feb 2023 00:15:28 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id b14-20020adff90e000000b002be34f87a34sm16872031wrr.1.2023.02.01.00.15.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:15:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 960bd83f-a208-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=oP9kZX1kICyLQTDEKEZ6//nF1VpBMEFgrmkqWWC3qqk=; b=mjKa84MaEQpoKPLz1KTv3MoYcbwR/zi12wF5wCEO4OIguVkj8UrILO803jdyuzCfHp l1chHz4jfmGnoZh3FWv3v7NLSsIA2+X66r+9OBxa/Tatkz/zKQWL6H6vjidwL+/XfKA7 wbmkzZbgi03FpIMjDf9Up8EOElzocb3kHaQQ3JApIJuWleq419nlAYfcLiWivVKEDNzr SCDrA2nWktdMLaMd80Nv+tcWuUWm/13foUtAdJBkDRx8KlrmJJs1qkmEWbUuTCivPoX/ Hx8vhradxqVciJCzgJb+xK1x3XbAL/8OSluDGes1nv/25RQed6tQBMrdrsUiiIEfMnje fcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oP9kZX1kICyLQTDEKEZ6//nF1VpBMEFgrmkqWWC3qqk=; b=3Rw8Fhp5DwmxOUiV7C64KOKCLVtNTYZ6Vq9RUsnNGjPR+heEm8anRxlnFMC017AFnT GhE3F4CsdDyJQR0x42o02QJiYbqF2r9mNl2PwKaFHFH/eKEtG1K1auHw6zmORKDJU3bF cbGt4OomucQWn1OBOE4a3N6NfgDiQoPEf4Q5+RgeKc5agFzEBhBSQjhKEv2IXHHDIN9C HOrYUT/cxC6aa4gIb7fb/EZ+tb2Pd92cOcDBXeJ7s3M/lfIZM3prtBMtFnd3wx32I6R4 F/dck4NGWEQPWm5Rw43Rva4jGYRh127s1agHapxCFTXiD68D4Xhgthfn3X6d4MVt2hbu FDvQ== X-Gm-Message-State: AO0yUKUJyVoHaXKUvOG6PWWrEFnIEYfQwb44yxAhcgvuced+JOQzaPRJ nXf9rjTURpeC3mYnu+eJU00= X-Google-Smtp-Source: AK7set+HyCLzXLubjcb8nQT7eucxTBk7xcdTcj02Xm/L114C4sDworlfM0TcgU2EXLB2g8Xx8WQlkw== X-Received: by 2002:a05:600c:4fd1:b0:3dd:1ac2:989 with SMTP id o17-20020a05600c4fd100b003dd1ac20989mr6480850wmq.39.1675239327594; Wed, 01 Feb 2023 00:15:27 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <9a8b8d11-099b-0263-3283-5e49d8dd7513@xen.org> Date: Wed, 1 Feb 2023 08:15:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 07/10] hw/xen/xen-hvm-common: Use g_new and error_report Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Stefano Stabellini , Anthony Perard References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-8-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-8-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > Replace g_malloc with g_new and perror with error_report. > > Signed-off-by: Vikram Garhwal > Reviewed-by: Stefano Stabellini > --- > hw/xen/xen-hvm-common.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Feb 01 08:30:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 08:30:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488197.756162 (Exim 4.92) (envelope-from ) id 1pN8VW-0003nM-1j; Wed, 01 Feb 2023 08:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488197.756162; Wed, 01 Feb 2023 08:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8VV-0003nF-VI; Wed, 01 Feb 2023 08:30:17 +0000 Received: by outflank-mailman (input) for mailman id 488197; Wed, 01 Feb 2023 08:30:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN8VU-0003n6-2N for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 08:30:16 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a66d1e21-a20a-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 09:30:14 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id k16so12049747wms.2 for ; Wed, 01 Feb 2023 00:30:15 -0800 (PST) Received: from [192.168.9.204] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id f31-20020a05600c491f00b003dc3d9fb09asm922456wmp.47.2023.02.01.00.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 00:30:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a66d1e21-a20a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=I/e7owFfcePnLRzxpORdL+Ugp/T7FuArUHTWMklHSZE=; b=EHcHSKQDWrNLfrV+Zaa/V6XU/gSZoD0Nre3JE13SUBQh3px4OSMGL+aMGglogy5m4G T5/0+KUbLG5vUwYM0WZEJrMxk029b7oaDq96zZ9p+akCHZBRfL79n3bYkbwR1sDSzXsz daQko7c6Q07LbIjQADi4sTGv44JTGn9W8gRgt1tApbYSYuu2ddh3IGDOv4nvaPtV5vuD iF7KUbJIxQoU8Voq/qIFP7yvkLopvYsGlltoguRNw8y0RRWzW5jECBSxRd+y+1ehGaC/ GnGELYZ/vMMGOaJPdbRakzxkSc8RfBdP570p5tYDV6PWqGr9cBuUNKlZrS8g6P7MbXYo EiYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I/e7owFfcePnLRzxpORdL+Ugp/T7FuArUHTWMklHSZE=; b=AngwNeK6oqaSD+b9YhtWA/SsXNVKUlSTRde7qsudocfgiy4St4bNcniSUq7jULEYeX TklcTL/51I1T76z8We9YTWLnAXD3SaGxRjM5OQXzCHhebxujhbFp3fhA6QBBmGZmKnwb IGgGcbb9USos6cPW6oZIz23jtLfB4E31pXl5XORECTKkdQlWfZ5VBg6bsRadhxDjL9Yi 32vBaBcD7DretVFhzBdzCU+ZyA85hj6gr5zUi6yHWoqTQdXiq1CjcLvgwVQayg5EkVBi TJGOBcCjq6ftNe513xzV0ooi1h6vkUVeQPOfP3+U1kbkNNp1+HZSBE8e3t+uZ7qFM1Uh sjUw== X-Gm-Message-State: AO0yUKXEa8O/J93F6F/FW8YOyiBg7S1sg5DIUHI+CWMtKQ+uZZar9L0N 9v7HGJlfycPXGmS5Diog3uA= X-Google-Smtp-Source: AK7set8U7h6JgTIUz/GSAXKxVEMdwMw6uPhYD8pbylUmygyycWG1uyrxwtyWU9ELgp5Jz13+EJJG8w== X-Received: by 2002:a1c:7c0e:0:b0:3dc:561a:79d8 with SMTP id x14-20020a1c7c0e000000b003dc561a79d8mr1285631wmc.35.1675240214862; Wed, 01 Feb 2023 00:30:14 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <179d773b-2634-b52b-8836-8d8f882e1495@xen.org> Date: Wed, 1 Feb 2023 08:30:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Peter Maydell , Stefano Stabellini , Anthony Perard , "open list:ARM TCG CPUs" References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-10-vikram.garhwal@amd.com> Organization: Xen Project In-Reply-To: <20230131225149.14764-10-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/01/2023 22:51, Vikram Garhwal wrote: > Add a new machine xenpvh which creates a IOREQ server to register/connect with > Xen Hypervisor. > Is this really the right way? Is it not possible to do the Xen initialization (including ioreq server registration) off the back of the accelerator init (i.e. AccelOpsClass ops_init function), which seems like the right place to do it now that it's no longer architecture specific. Paul From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:06:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488211.756174 (Exim 4.92) (envelope-from ) id 1pN94U-0000Aj-QG; Wed, 01 Feb 2023 09:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488211.756174; Wed, 01 Feb 2023 09:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN94U-0000Ac-Lm; Wed, 01 Feb 2023 09:06:26 +0000 Received: by outflank-mailman (input) for mailman id 488211; Wed, 01 Feb 2023 09:06:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN94T-0000AW-9o for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 09:06:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN94S-0002X2-5U; Wed, 01 Feb 2023 09:06:24 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pN94R-0002Vu-Up; Wed, 01 Feb 2023 09:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=m2obYo8VF0262euVcLhlmIca1IIMvx+h7vlIhXldtK8=; b=AqDRYpBmUZJwC1FklR7lsjwugD QxSO0IafPCLph1OXHJeec3pOPE5ozfs+UHzn+LBVp1JmeGHIHtp7xq3FL3lHpYrgDCzMHDbWEpm4d INEABfMskBh9ZgAo3SQBSCZ8kX693A9yjzR+yn0qJ2zwkwD3TjPLeWGc7kJVzo7DWRBs=; Message-ID: <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> Date: Wed, 1 Feb 2023 09:06:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Andrew Cooper , Alistair Francis Cc: Oleksii , xen-devel@lists.xenproject.org, Bob Eshleman , Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> From: Julien Grall Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff In-Reply-To: <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 01/02/2023 00:21, Andrew Cooper wrote: > On 31/01/2023 11:17 pm, Alistair Francis wrote: >> On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: >>> On 31/01/2023 11:44, Alistair Francis wrote: >>>> On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: >>>> >>> From my understanding, on RISC-V, the use of PC-relative address is >>> only guaranteed with medany. So if you were going to change the cmodel >>> (Andrew suggested you would), then early_*() may end up to be broken. >>> >>> This check serve as a documentation of the assumption and also help the >>> developer any change in the model and take the appropriate action to >>> remediate it. >>> >>>> I think this is safe to remove. >>> Based on what I wrote above, do you still think this is safe? >> With that in mind it's probably worth leaving in then. Maybe the >> comment should be updated to make it explicit why we want this check >> (I find the current comment not very helpful). > > The presence of this check pre-supposes that Xen will always relocate > itself, and this simply not true.  XIP for example typically does not > > Furthermore it's not checking the property wanted.  The way C is > compiled has no bearing on what relocation head.S uses to call it. I think we are still cross-talking each other because this is not my point. I am not sure how to explain differently... This check is not about how head.S call early_*() but making sure the C function can be executed with the MMU off. In which case, you will likely have VA != PA. In theory head.S could apply some relocations before hand, but it may be too complicated to do it before calling early_*(). > > It is a given that we compile the hypervisor with a consistent code > model, meaning that the properly actually making the check do what is > wanted is also the property that means it is not needed in the first place. See above. > > This check is literally not worth the bytes it's taking up on disk, and > not worth the added compiler time, nor the wasted time of whoever comes > to support something like XIP in the future finds it to be in the way. > Xen as a whole will really genuinely function as intended in models > other than medany, and it demonstrates a misunderstanding of the topic > to put in such a check to begin with. Then enlight me :). So far it looks more like you are not understanding my point: I am talking about C function call with MMU off (e.g. VA != PA) and you are talking about Xen as a whole. I guess the only way to really know is to implement a different model. At which point there are three possible outcome: 1) We had the compiler check, it fired and the developper will take action to fix it (if needed). 2) We have no compiler check, the developper knew what to do it and fixed it. 3) We have no compiler check, the developper where not aware of the problem and we will waste time. Even if you disagree with the check, then I think 1 is still the best because it would explain our assumption. Yes it may waste a few minutes to the developer switching the model. But that probably nothing compare to the time you could waste if you don't notice it. Anyway, Alistair has now all the information to take an informative decision. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:10:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488214.756185 (Exim 4.92) (envelope-from ) id 1pN982-0001Tt-98; Wed, 01 Feb 2023 09:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488214.756185; Wed, 01 Feb 2023 09:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN982-0001Tm-4V; Wed, 01 Feb 2023 09:10:06 +0000 Received: by outflank-mailman (input) for mailman id 488214; Wed, 01 Feb 2023 09:10:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN981-0001P0-JG for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 09:10:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN980-0002b1-OZ; Wed, 01 Feb 2023 09:10:04 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pN980-0002xg-JI; Wed, 01 Feb 2023 09:10:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=R68mslSISWV/PVyXhw0lWkynSaPc9GK1IfNvlK9R7rw=; b=uNAj4RJmp5F6PvLWsJ7vsJceDH dMq1T/VCktLDtqzvFJ+95UKl2TZOeLU02rGZn+J3UEawX8zDF/Sv5pRAYJyKyf1+9Y0oZpFyi5QM9 dGy3Inza3PneSy+4mPB6mAnjbTFg4QGPDt5S+YasLr5FnYNLOpI+07XpHjruZ7LXRR3I=; Message-ID: Date: Wed, 1 Feb 2023 09:10:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff From: Julien Grall To: Andrew Cooper , Alistair Francis Cc: Oleksii , xen-devel@lists.xenproject.org, Bob Eshleman , Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> In-Reply-To: <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/02/2023 09:06, Julien Grall wrote: > Hi Andrew, > > On 01/02/2023 00:21, Andrew Cooper wrote: >> On 31/01/2023 11:17 pm, Alistair Francis wrote: >>> On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: >>>> On 31/01/2023 11:44, Alistair Francis wrote: >>>>> On Sat, Jan 28, 2023 at 12:15 AM Oleksii >>>>> wrote: >>>>> >>>>   From my understanding, on RISC-V, the use of PC-relative address is >>>> only guaranteed with medany. So if you were going to change the cmodel >>>> (Andrew suggested you would), then early_*() may end up to be broken. >>>> >>>> This check serve as a documentation of the assumption and also help the >>>> developer any change in the model and take the appropriate action to >>>> remediate it. >>>> >>>>> I think this is safe to remove. >>>> Based on what I wrote above, do you still think this is safe? >>> With that in mind it's probably worth leaving in then. Maybe the >>> comment should be updated to make it explicit why we want this check >>> (I find the current comment not very helpful). >> >> The presence of this check pre-supposes that Xen will always relocate >> itself, and this simply not true.  XIP for example typically does not >> >> Furthermore it's not checking the property wanted.  The way C is >> compiled has no bearing on what relocation head.S uses to call it. > > I think we are still cross-talking each other because this is not my > point. I am not sure how to explain differently... > > This check is not about how head.S call early_*() but making sure the C > function can be executed with the MMU off. In which case, you will > likely have VA != PA. > > In theory head.S could apply some relocations before hand, but it may be > too complicated to do it before calling early_*(). > >> >> It is a given that we compile the hypervisor with a consistent code >> model, meaning that the properly actually making the check do what is >> wanted is also the property that means it is not needed in the first >> place. > > See above. > >> >> This check is literally not worth the bytes it's taking up on disk, and >> not worth the added compiler time, nor the wasted time of whoever comes >> to support something like XIP in the future finds it to be in the way. >> Xen as a whole will really genuinely function as intended in models >> other than medany, and it demonstrates a misunderstanding of the topic >> to put in such a check to begin with. > > Then enlight me :). So far it looks more like you are not understanding > my point: I am talking about C function call with MMU off (e.g. VA != Just to clarify, I meant a C function executing with MMU off here. > PA) and you are talking about Xen as a whole. > > I guess the only way to really know is to implement a different model. > At which point there are three possible outcome: >   1) We had the compiler check, it fired and the developper will take > action to fix it (if needed). >   2) We have no compiler check, the developper knew what to do it and > fixed it. >   3) We have no compiler check, the developper where not aware of the > problem and we will waste time. > > Even if you disagree with the check, then I think 1 is still the best > because it would explain our assumption. Yes it may waste a few minutes > to the developer switching the model. But that probably nothing compare > to the time you could waste if you don't notice it. > > Anyway, Alistair has now all the information to take an informative > decision. > > Cheers, > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:22:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:22:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488219.756196 (Exim 4.92) (envelope-from ) id 1pN9K9-0003Pk-D0; Wed, 01 Feb 2023 09:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488219.756196; Wed, 01 Feb 2023 09:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9K9-0003Pd-AA; Wed, 01 Feb 2023 09:22:37 +0000 Received: by outflank-mailman (input) for mailman id 488219; Wed, 01 Feb 2023 09:11:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN99P-00026F-9t for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 09:11:31 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69c06197-a210-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 10:11:30 +0100 (CET) Received: by mail-ed1-x52a.google.com with SMTP id cw4so11827043edb.13 for ; Wed, 01 Feb 2023 01:11:29 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id k27-20020a05600c081b00b003de77597f16sm1072830wmp.21.2023.02.01.01.04.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 01:04:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69c06197-a210-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MuOMiMCaIb4W5xDLrZ5AT/uU/AgC110LiidElfA2tjQ=; b=l++JAFYn28aYNtbNWPcV4jSY0b8Lq7PTBPkz7oSquxQloMwiaOVlS0v5Xv93vPXbRJ RshAJLcKR/QAFJWXEPvxvy0mN18MWMARvi6gLaidufuNzkH7tEQ6xzlE3T7HzS0lRIxm oOW9L8IAFd+kwGBP4rPwFguA3C3hyjmypzBQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MuOMiMCaIb4W5xDLrZ5AT/uU/AgC110LiidElfA2tjQ=; b=Jpposja9EUKxK8i0CpGzSvQgUrZ0kb47e9pMkXqmNIn0YaGXWXWS4QCeIwdXWplJk/ WTkNjMrpinEqWkD6vCtTmL+Cli9olNYQxkhGvAEjsdbnW4A975suXHWymHRnV4Npz6eR Jv64PInIgxAgKpi1DKfTIfL+7NzDgcL35S96CIMFHAPfbldcXDUreZ5jqu1iuOQxcX5X y9rXs4Px8AFUtupiUtDn57ZkOvQkcNCcNmoIXz8gPK8F6Yx/vOFjMmmHAAjuolINXShU FB8hI2Zrgdtul8kje8C3hSdTkkAZn+QzjueAYnfoMQP+q3rOodnQoliIWACWTJ6ffgGD 9hwQ== X-Gm-Message-State: AO0yUKXw2u5Wy/0REmaKlngodkUMNYL+mRgcHJCM1+7hWVvIi0fJ+wyR T5ZBhOjqq9Yccw52mGmSwwOusahHK4AwPFLQwiH2cw== X-Google-Smtp-Source: AK7set/6/CR8MPQ4iWHTfaKeGWi8T0K3tIKOSg+YA6OZuFVgUy2pCSK3EwDOtWBiMKtP9gvWI2zNeg== X-Received: by 2002:a05:600c:1546:b0:3dc:58d5:3a80 with SMTP id f6-20020a05600c154600b003dc58d53a80mr6591921wmg.24.1675242284043; Wed, 01 Feb 2023 01:04:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH 0/7] tools/ocaml: Memory corruption fixes in bindings From: Christian Lindig In-Reply-To: <20230131212913.6199-1-andrew.cooper3@citrix.com> Date: Wed, 1 Feb 2023 09:04:42 +0000 Cc: Xen-devel , Christian Lindig , David Scott , =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , Rob Hoes Content-Transfer-Encoding: quoted-printable Message-Id: <0962AEC0-72C5-4A03-BF97-AFB3455B9EDE@cloud.com> References: <20230131212913.6199-1-andrew.cooper3@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 31 Jan 2023, at 21:29, Andrew Cooper = wrote: >=20 > It turns out there have been some latent memory corruption bugs and = other > errors in the bindings since they were first introduced. >=20 > These were discovered after realising that we'd introduced other = memory > corruption bugs as part of the Ocaml 5 fixes, and in the case of the = evtchn > bindings, backported this as part of the oxenstored-lu fixes. >=20 > This series addresses all the memory corrupution issues we're aware of = that > can occur in an entirely well-formed program. >=20 > Deferred for now are the (hopefully latent) memory corruption errors = which > happen due to bad parameter passing, and a substantial pile of related = cleanup. >=20 > Andrew Cooper (3): > tools/ocaml/libs: Allocate the correct amount of memory for = Abstract_tag > tools/ocaml/evtchn: Misc cleanup > tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock = released >=20 > Edwin T=C3=B6r=C3=B6k (4): > tools/ocaml/libs: Don't declare stubs as taking void > tools/ocaml/evtchn: Don't reference Custom objects with the GC lock = released > tools/ocaml/xc: Fix binding for xc_domain_assign_device() > tools/ocaml/xc: Don't reference Custom objects with the GC lock = released >=20 > tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 89 ++--- > tools/ocaml/libs/mmap/Makefile | 2 + > tools/ocaml/libs/mmap/xenmmap_stubs.c | 6 +- > tools/ocaml/libs/xb/xenbus_stubs.c | 5 +- > tools/ocaml/libs/xc/xenctrl_stubs.c | 494 = ++++++++++++++------------ > 5 files changed, 323 insertions(+), 273 deletions(-) >=20 > --=20 > 2.11.0 >=20 Really pleased with the attention to this. Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:30:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:30:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488229.756207 (Exim 4.92) (envelope-from ) id 1pN9Re-0005GC-A6; Wed, 01 Feb 2023 09:30:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488229.756207; Wed, 01 Feb 2023 09:30:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9Re-0005G5-5r; Wed, 01 Feb 2023 09:30:22 +0000 Received: by outflank-mailman (input) for mailman id 488229; Wed, 01 Feb 2023 09:30:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9Rc-0005Fz-Pk for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 09:30:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b195b07-a213-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 10:30:19 +0100 (CET) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS1PR04MB9700.eurprd04.prod.outlook.com (2603:10a6:20b:473::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 1 Feb 2023 09:30:17 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::bf72:b6d5:ae40:e192]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::bf72:b6d5:ae40:e192%7]) with mapi id 15.20.6043.036; Wed, 1 Feb 2023 09:30:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b195b07-a213-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2p9BN4x+iFuVaExdg6k77YJleSlv2se5R2I3E682ztZOv4t+KilkAsbYpiCP4SGOkfsXiwE9KrwJJJj1n10sApOy5X8mSOfTAQ2Ks9i5tWFgn5l8FiCNvWQefv1iooQcoBA8KffBWeB8nLV1a5QUc5eX0s6h24f5cxRpwAVZEID17BX3Xpd1O/YYrrtdXqBhncvJlConUQIRl9As0Gg/g6BokSEJeF8cRVVSB5lT3w8A4+NLsXY0bf+0I+bXmPx24MN5yNsBhGQdA4Ag5CmyS8fcp/MYvVDV3qV4dYpIpS0Gry17AUmfHAvyHxEf9MeGFET749QTjBIqSi7YRbZgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zTLRIiWcvo51/3o5VlJ0WQIdoSCIxoUaX4X6Ha3xogo=; b=bG8OhZu3SqJkuEl4vEzbRfvjDHOQZxmVDlDIY0YrUwKUuW2WlU90vkx1x1kD5nBF8PLaqT/evay2UXfSu1oaSIENJnlpWtqLKBI/HvaGQfF+M4jsbyrUVKlCwhAlCcoNKKO/JdcBoQ+fSbnS1SLhb4w4d5L8BHoF5EM6RFnNv2ae6EO8t3lF4t6c/gcCYJCbPl6LvNt9HPQn8lud8Gs+S7D3n+dEC4NsaZowiTsp0s4r0q+Dnzwz9cOSs9eUaEtXkWCXlw/bOTh7u1C8FwkAaYDAeoD/XflYXfARHdCFrv0Bihuqx9M6iMUqs2EkRJo/WAkGiCrYDxTqHcZ45I8pDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zTLRIiWcvo51/3o5VlJ0WQIdoSCIxoUaX4X6Ha3xogo=; b=kZqb7FtOj09QA8isnkUVHJUfFCKjtc5/tSMTHKgEfoOPB8zKQQpHCKKh4jk4GXfAJr2j5pwySyCwbsBgAKz1uEDOVhbrWsA3PPgEpG6m6vMtKwjdYKNIWG4O2CSnhoUO6d3XrIHJUDYA79W0+LiCStR5HgVmhRO3+tFO941lHM/uiCeMZfB0dB/gzH8exh7eLtR0Ra6PQJnHVOML1wtOgsfYxWHb5e2ISF4U6FmxLBh3caWvntvBsIYheB4sFuvNlIFbX2gZD7fXiBB82HxsP/kr+q89FUIaFOc4pynTMUEHgXVoDQRArA97IyiruWNzM0DX5/Gmk0LGgkYskX2FNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <34649fa5-4676-1e45-e1cc-ea57d7027c5f@suse.com> Date: Wed, 1 Feb 2023 10:30:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Content-Language: en-US To: "Tian, Kevin" Cc: Paul Durrant , =?UTF-8?Q?Pau_Monn=c3=a9=2c_Roger?= , Xenia Ragiadakou , "xen-devel@lists.xenproject.org" References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::12) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS1PR04MB9700:EE_ X-MS-Office365-Filtering-Correlation-Id: caeb639d-7ec9-4af5-7c03-08db0436ee34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oxneE1vImDf/nbd3dfRfg9YZmaBsduQ2stdkTKqpcLgMuLkffT6hwH0cTdYPoau7991F7ZOZ9tVbYRWgSgo26DulyGbS1HLGuDQM+S521E8pcuiyz37P79K+oeYtAXd4Opqpv4dcaEKbyyWy2UKgLbp3swEOVi0cE9XccjDhhjb0OEQF4+CS/bDN9khN5lMsqgBErkXM3/0cbAoai+5yQ7+h1ACQODIUFKYhB1cloDlUFkD/khjhYAQhawLvmJs7LgluMht/LsqHWFCgeotHA6kxsbAlagsfPFUp5d+kB2sPkJjtPhWtZ3+5UInl/A3kLMRqTO8ZZWV7n9/EobDh8T/KAzQQN+0Sx7HTspMoZP/Zr+hQjDdEwPThkgJCFB3OfZJuKHNB4i+KhoRmdWYLdE3sfFo5+9+whshRjfjcxdkFtcrgsBDLsQyniT69aWPxeNp2AJWgqR1XskMD9QZgPhysmzKS8G0RZG3Xs4gDFPjfUhklq8HxFe6E/lJ0Omszwlh8gq3QBj7z1SLKFl2nyJ6XY2GlIOQn//IDznm4gC4Jo7tT6IIqYvihS9VhQtBtYCc9GH8DuoLXbAuWVIPP0ie2o68VbFf3tW/qZY5vjf8Ytu8JOohTTh1XuESPZ/rf/qPg5yYQLWdcaAD764hgh8En2kPWaBpYZWjWajufyQkwOu5PnkHxxG6s9nn3ymoMKt4m1D9GTJCtTXi3oEtgezR8H7HBd/aGJhU1AxIrPCo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199018)(31686004)(66556008)(6916009)(66476007)(4326008)(66946007)(41300700001)(8936002)(8676002)(83380400001)(6506007)(53546011)(2616005)(54906003)(316002)(38100700002)(5660300002)(31696002)(186003)(36756003)(26005)(6512007)(86362001)(2906002)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MERLTUlEc3R5U2ozdHp1U0hkNjhFdHRNVWNyaTFzNHROdjRtUXcwZi94NTFY?= =?utf-8?B?Y05PUXNCbVNlcmEweE1FRlpqNk4rV3IzMm5QcmVMSXhNbkpyT2hnTkRHWmda?= =?utf-8?B?RzZ5WW1VVk9BVjRZM2VqcmpSZGd6azBWWkFJZTQzVHZmbHBHWDhvQWJVOFlz?= =?utf-8?B?ZTE0UVBtRjBEb1JxMnpJNWJVU0c3TjFGdUxoT2FwcStremVOVXRraDQ5d1Fw?= =?utf-8?B?bTkzOEplVFptWHJHUzQ5VWtuMm5FZW1ZaHhoLzFhV0xMV3JBVGVnaUozTTVG?= =?utf-8?B?cXhZNGdZZStQMzBWanpyeGZ0UFdaYmFDcHJ5dHVFNk9RK0tweVFTazZkSzRa?= =?utf-8?B?SDlZN1BDUjlLU0twSlNFTE1QQU1SNG9BK0ZVYWNYcFpuSmdMbFYrSDFudnhK?= =?utf-8?B?d0kwWTdyamlPcUJTUS9QMXpheVhNdHQrWnRkd0FWRm9Cd05pZENlNHFsczZq?= =?utf-8?B?N3cxbTdhaE5OU2d4OUZzd1Fpdm5WeGZDVXVYeG4zcUg5amxYTlJreE1HYnpo?= =?utf-8?B?NUdVK1RsRG9MWmovY1F6aG1iYWIwNDhkMjcwalc0UjNsWmdscWFJWGIwUDVT?= =?utf-8?B?MWp3dld6Zmh0bDNOVG9zd2RIMzFINlJiUFhEeW4zcC9WOS9FMzY0WWg3R2FE?= =?utf-8?B?WXBzc3NEOG9HcXQvZSt0NE5Lck5yd1pJQjN5ZmRKTGdOcVhQbkJxeHR1aXNo?= =?utf-8?B?aXJUbGtoYW1Ed0Vnd0pmR1FJZ1hYOVJCSlpFYTNpT1pVY0FNcjNTbU5sbGRD?= =?utf-8?B?VytDV3lKbHZ1bDNHM3h1OVRVTE5JMXdGZEFnWStDT29XeUx4YUZXM2tyUmEw?= =?utf-8?B?b3J1ZzFiUHRsSzY3SWJCN2hBQmNmLzRJQ1l0UWVSWTJJZTU1ODh2eUFRVGJs?= =?utf-8?B?eHUzUDhUMFlNektJcEp5T0dtUHU3c2RMb3FtY3hMTExSZ3VCUzRnL2I5eExx?= =?utf-8?B?MDZZRkRmL0dNR3ZKMTdxdUZ6YjEwK3RxSWRiZU8wcTRqZUs2TDhrRWRzUUdY?= =?utf-8?B?YVRtdFFmMXN0ZFhaczJUa2NZTld0enhUNlNYUDI0VlZZZ3VVMnZ0TExzclB3?= =?utf-8?B?cnpXNWxRcFhGQ3U5UG82dWhxYnZnSmdXUzZjQzUyUnkyU080RWYzb3F0N01G?= =?utf-8?B?L1ZNZ2lmVzVGVmNoUWI3MThrdWdMLzVocTNMZUFlaTlmUXJEYWp4OWhacitD?= =?utf-8?B?ZGJSV2pDTmVpQytMY1RJRXZJUUZlbyt0cG9oa2dPTmJjZENoN3ZOWmthZFcy?= =?utf-8?B?eld1U0x0dFVCUTJENkFucUYrdS9pUnlLVm9YZVh5QzhBYWZvOWtSS2c5Sk1W?= =?utf-8?B?SDRmRlFHWG1uSU4vVXBrWkZ3bGZYZXVlaXVid0tnaTJZTzhDYVNHQVo5Q3Zj?= =?utf-8?B?eG9qdlRHZE5SMzVpclpjaENKb1U1WEtuZFJ1WnBUYXNET3ZCWFNwWUJxY1Bw?= =?utf-8?B?QTQ4ZW5jVjZZN29uOGxST2hGMFhBMlZGNFB5OCtnYlhmcWQ3K2FuV0ozMGlk?= =?utf-8?B?bmhCTTlRaVVmaU9kdEdsUlJqbWFrZ3YvMFhtY2haZTRkV2ZBL0NMQWZMWVg1?= =?utf-8?B?NElmRkZjQ0JweTBBMFNZTHNoQUFDTUVhTlBleUZSVEpGKzNaTDdqOUJNZCs2?= =?utf-8?B?TkkxWWVJTFFWYmFNaUhnVkpTTWIzbjMxT2x1VGdFN2MvaURvYUh3T1pKcUtC?= =?utf-8?B?cHhTT2J0dXBpOERSZDNsMld1SmhsMWJCc2NUbHB2ME1zYkozZVZTUFRRMDBs?= =?utf-8?B?dXdHVmxnb3ljY2FTbmpvZVpPQ1R0ZVlaN2pqTXZBbkVKdGhPbWV1dlZDSWRP?= =?utf-8?B?NWRiOFpJejBlUjBrWFBtQ25FZEE3bWVZYzNYRXNNNW5FUFBGSExJVnJDdFhL?= =?utf-8?B?dENXdFk3d2lWdDlWNlQvdjVNQklUNkN0N1Q1WTNFaWUxZlpUdmdvMXNIdnZo?= =?utf-8?B?Q3lxQysrWlBSNTQxQmI0dTFjbS9ISjVHTWo0TzVFNnFId1ZNQUIwcXY5S2N4?= =?utf-8?B?emV2d2s3VFJydG4vWHVpVG5ubThFYkxrcHE3OVlFd1d1ZjNFOVZZaVZMYTVp?= =?utf-8?B?QWJRTElob21lbVVjUkhmRUMvLy9GWGhUVElvbnRZR3U1NHByMXY1WTNaV0hm?= =?utf-8?Q?iwU2VWQWtL8mq1cmWl/3QY2vR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: caeb639d-7ec9-4af5-7c03-08db0436ee34 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 09:30:17.5469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pLRSGAgb/l6VloIVu0cxbRPbDxDWnd7muyPoLcdUM/NbJhtMo8sxCCWPfeo6Xb0+jpMaJ6JOSpWyi86pu0eiKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9700 On 01.02.2023 06:07, Tian, Kevin wrote: >> From: Xenia Ragiadakou >> Sent: Tuesday, January 24, 2023 8:42 PM >> >> The variable untrusted_msi indicates whether the system is vulnerable to >> CVE-2011-1898 due to the absence of interrupt remapping support. >> Although AMD iommus with interrupt remapping disabled are also affected, >> this case is not handled yet. Given that the issue is not VT-d specific, >> and to accommodate future use of the flag for covering also the AMD iommu >> case, move the definition of the flag out of the VT-d specific code to the >> common x86 iommu code. >> >> Also, since the current implementation assumes that only PV guests are >> prone >> to this attack, take the opportunity to define untrusted_msi only when PV is >> enabled. >> > > I'm fine with this change given no functional change. > > But I'm curious about the statement here that the current code only > applies to PV guest. I didn't see such statement in original mail [1] > and in concept a HVM guest with passthrough device can also do such > attack w/o interrupt remapping. > > Any more context? Isn't this simply because we don't allow HVM to have devices assigned without intremap? (I'm not sure, but even for PV allowing this may have been limited to the xend tool stack.) Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:30:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:30:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488232.756218 (Exim 4.92) (envelope-from ) id 1pN9S2-0005gH-Hf; Wed, 01 Feb 2023 09:30:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488232.756218; Wed, 01 Feb 2023 09:30:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9S2-0005fv-DV; Wed, 01 Feb 2023 09:30:46 +0000 Received: by outflank-mailman (input) for mailman id 488232; Wed, 01 Feb 2023 09:30:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9S0-0005e7-F5; Wed, 01 Feb 2023 09:30:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9S0-00037O-Cn; Wed, 01 Feb 2023 09:30:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9Rz-0000eX-VP; Wed, 01 Feb 2023 09:30:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pN9Rz-0004C0-V0; Wed, 01 Feb 2023 09:30:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p5YrptGOTGNbxifUC+JZYm2oB1KTK77AEe7CvnV2ns4=; b=cq00M5cq52X59+T32WwAlZgvA0 v2tJR0Pig+8sakjFCbYgFgK/hoTN7kJOZZgiLLaS4+3OA9wY4LRZVayAqZTPic7U5689YoARDdUGo 6Qf0dutdiZkVR6hMukCXiw7HrbvKv2ABUkunz4f5Nlbd/JWyyK6t9MxSu0HfSsHoYkAw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176310: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 09:30:43 +0000 flight 176310 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176310/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 5 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 09:49:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 09:49:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488241.756228 (Exim 4.92) (envelope-from ) id 1pN9jw-00083M-2u; Wed, 01 Feb 2023 09:49:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488241.756228; Wed, 01 Feb 2023 09:49:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9jw-00083F-04; Wed, 01 Feb 2023 09:49:16 +0000 Received: by outflank-mailman (input) for mailman id 488241; Wed, 01 Feb 2023 09:49:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pN9ju-000839-B0 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 09:49:14 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20623.outbound.protection.outlook.com [2a01:111:f400:7e8a::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab5fa491-a215-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 10:49:08 +0100 (CET) Received: from DM5PR08CA0028.namprd08.prod.outlook.com (2603:10b6:4:60::17) by IA1PR12MB6257.namprd12.prod.outlook.com (2603:10b6:208:3e7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Wed, 1 Feb 2023 09:49:04 +0000 Received: from DS1PEPF0000E63A.namprd02.prod.outlook.com (2603:10b6:4:60:cafe::88) by DM5PR08CA0028.outlook.office365.com (2603:10b6:4:60::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38 via Frontend Transport; Wed, 1 Feb 2023 09:49:04 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000E63A.mail.protection.outlook.com (10.167.17.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.21 via Frontend Transport; Wed, 1 Feb 2023 09:49:03 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 03:49:03 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 1 Feb 2023 03:48:36 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab5fa491-a215-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FpgUljH8EvM+GG/7Zrt+aMZ85SomS+8TxX7sP1gQNTp+kWNwBOlZW3+/rImbQm90itHByht4Z43vnX3y8NLP8qPgWL0/D+lfnsnSTBmlCTyVR4q9nx9TKSD1iYlt3y+y37guvSnkjjQ4smbfj0XrudkQqUgl/9sS4+0jDFqS0ZNrjzy+HnQB8/kA0bvctJPhvURQIH3+mSPfcSCecqUpQ1zjwhMM4Vszy6r8qgY683QGRxo46+ZCF/nv70NWPmrTnUfh/71w+w979I0vbh7azTjIGqbonG8c/GtC6H4K7f/ZdhcZCYIOI2GhlhEBxiUdWhvKalN7YRQTkucHwkm3zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=olJacfv0aDshew5Y8dFglBHZkl47e7DRxAu0qEsJnzg=; b=XjYZuHVZDz6ztggE+1M7tHbqSjA4WPCXt62OQRVA/T/kdgvoVSKpCiLarLfJegTadnEDOLdfbBvUKMQ1Icl3Rgl9Oe983pAK0f6YoIQj5xeKRwI+sXO2kj0dpC2Tn+g7PAmVsKMUasiFE5QrG6yTBTShDJ2LbGUbSCp7kd+5yeaO7QlvFPq3rORaXxfSaJtkIdt9iSZCutPQRmnfI/e8Rq390lkJfiZlAo4NtB43B1HDJ4gWhuV47f4MCba5Bt35+RT8cL5kZcoA2MHEG1FWKWgXKYqCCQFqv6H3n8SDHZFSmmGXz9vBPAlWzTPbglbZuODcl/25IVauIGqHdhQHiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=olJacfv0aDshew5Y8dFglBHZkl47e7DRxAu0qEsJnzg=; b=yok0QMUAbtPiD6upI4ayYJbis9F/7q3BPbCIof0c4HkQ0GkUbZkRH1QfFF9RzuE59xUSG6qnmpYTSNxDqwSYmfqJ82tlNAKcpFktnYypWsmzsJglwIBIdzJfT8QWBvHDPO8GUcY+EAiGZD0T+aiQIfvfNv8l3lbU3cwnRONKrYM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> Date: Wed, 1 Feb 2023 10:48:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E63A:EE_|IA1PR12MB6257:EE_ X-MS-Office365-Filtering-Correlation-Id: 53589b67-b16e-4be5-d6bb-08db04398da3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +SCTI+nM/L5JBIkets4KojmKhZYau3tq3vYpmMoQuOYuzeGWc/5Im/jZocOI0yQDDSdR8o37T5o/rgvU7A7DfoJy5fKt1ZR+jVhtcB11UJef8lagF6NlXbQzldRqwwm1MLZXO0dG3avql4Ia1bWvzX9OZYrvcTeJq/W8CtRWxieoiHW+VrtoB/37Wudk5nHivcwzpw1/+w20Lc2qxdjpVhc70+EiaE36Ku/dO9wnlUCrJcnScLkROLMokZmLgFOH9xcmzJft58x7aFztCXByOEBET3n1KWqLU9xrUAN3Wu+R3RSFn32LegyWpTYVYudX+HYA2OkoDrZlFgerA8wqZ9mT1sZoPvXrbfbhVE26p1oa+RBwPNEtCPHZ5NfO8XL/A387TIlndAvPKkhxQMkrfR2zA56Lue7WMAAAoH/8H8AEaKQvBrF5DFyBYTjXr4JcJNHdidW9gEWgmt+hoZ/HbAHIm1R+gFNFIOld8bYZQnOjnEbpjyclNv/iT/0edWT4Iyo/nwLVrV0fR8i8buA1LGhbNQCEIBCiUNnuguJFXOr/zBpyhCio8NHlmZqyhw6Rm+/9iZyvp+8toqwO12xkEWlGIIystH96Gd/UTOyZ2YqwicqNh6nAtARYPC2PPTSRBFjyds2nqG3k3ihmRptgsJefPG97f9RN9d204VD72T6vJN1rJy9z3cJXEbTXV85Hzgy37Da5MDmj0l8BsTNmSugPC2Jgoso41H8p/JqXrVmabU0yMsB+nnwq5fJhg7x4egwUX+7PQMkfBeTNan596g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199018)(36840700001)(46966006)(40470700004)(36756003)(110136005)(426003)(47076005)(16576012)(54906003)(83380400001)(82310400005)(2906002)(44832011)(82740400003)(316002)(81166007)(36860700001)(31686004)(2616005)(53546011)(478600001)(186003)(70586007)(26005)(70206006)(8676002)(31696002)(336012)(40460700003)(41300700001)(356005)(5660300002)(86362001)(4326008)(8936002)(40480700001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 09:49:03.8247 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53589b67-b16e-4be5-d6bb-08db04398da3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E63A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6257 Hi Julien, On 31/01/2023 21:20, Julien Grall wrote: > > > Hi, > > On 31/01/2023 15:13, Michal Orzel wrote: >> At the moment, Xen does not support booting gzip compressed uImages. >> This is because we are trying to decompress the kernel before probing >> the u-boot header. This leads to a failure as the header always appears >> at the top of the image (and therefore obscuring the gzip header). >> >> Move the call to kernel_uimage_probe before kernel_decompress and make >> the function self-containing by taking the following actions: >> - take a pointer to struct bootmodule as a parameter, >> - check the comp field of a u-boot header to determine compression type, >> - in case of compressed image, modify boot module start address and size >> by taking the header size into account and call kernel_decompress, >> - set up zimage.{kernel_addr,len} accordingly, >> - return -ENOENT in case of a u-boot header not found to distinguish it >> amongst other return values and make it the only case for falling >> through to try to probe other image types. >> >> This is done to avoid splitting the uImage probing into 2 stages (executed >> before and after decompression) which otherwise would be necessary to >> properly update boot module start and size before decompression and >> zimage.{kernel_addr,len} afterwards. > > AFAIU, it would be possible to have a zImage/Image header embedded in > the uImage. So any reason to only handle a compressed binary? Not sure if I understand you correctly as what you say is already supported. The split or moving decompression is only needed in case of compressed uImage, as u-boot header (not being part of compression) appears before gzip header. This is not the case for zImage/Image header that is embedded into image and gzip header is at the top. In case of uImage added on top of zImage/Image, the load address/entry point are taken from uImage header so basically the zImage/Image header is not parsed (this is documented in our booting.txt). This patch makes the uImage compression works as the other combinations work fine already. You can boot what you can already: - zImage/Image - compressed zImage/Image - zImage/Image,raw with u-boot header + this patch allows to boot: - compressed uImage (i.e. zImage/Image/raw compressed with u-boot header) > >> >> Remove the limitation from the booting.txt documentation. >> >> Signed-off-by: Michal Orzel >> --- >> docs/misc/arm/booting.txt | 3 --- >> xen/arch/arm/kernel.c | 51 ++++++++++++++++++++++++++++++++++----- >> 2 files changed, 45 insertions(+), 9 deletions(-) >> >> diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt >> index bd7bfe7f284a..02f7bb65ec6d 100644 >> --- a/docs/misc/arm/booting.txt >> +++ b/docs/misc/arm/booting.txt >> @@ -50,9 +50,6 @@ Also, it is to be noted that if user provides the legacy image header on >> top of zImage or Image header, then Xen uses the attributes of legacy >> image header to determine the load address, entry point, etc. >> >> -Known limitation: compressed kernels with a uboot headers are not >> -working. >> - >> >> Firmware/bootloader requirements >> -------------------------------- >> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c >> index 068fbf88e492..ea5f9618169e 100644 >> --- a/xen/arch/arm/kernel.c >> +++ b/xen/arch/arm/kernel.c >> @@ -265,11 +265,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >> #define IH_ARCH_ARM 2 /* ARM */ >> #define IH_ARCH_ARM64 22 /* ARM64 */ >> >> +/* uImage Compression Types */ >> +#define IH_COMP_GZIP 1 >> + >> /* >> * Check if the image is a uImage and setup kernel_info >> */ >> static int __init kernel_uimage_probe(struct kernel_info *info, >> - paddr_t addr, paddr_t size) >> + struct bootmodule *mod) >> { >> struct { >> __be32 magic; /* Image Header Magic Number */ >> @@ -287,6 +290,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >> } uimage; >> >> uint32_t len; >> + paddr_t addr = mod->start; >> + paddr_t size = mod->size; >> >> if ( size < sizeof(uimage) ) >> return -EINVAL; >> @@ -294,13 +299,21 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >> copy_from_paddr(&uimage, addr, sizeof(uimage)); >> >> if ( be32_to_cpu(uimage.magic) != UIMAGE_MAGIC ) >> - return -EINVAL; >> + return -ENOENT; >> >> len = be32_to_cpu(uimage.size); >> >> if ( len > size - sizeof(uimage) ) >> return -EINVAL; >> >> + /* Only gzip compression is supported. */ >> + if ( uimage.comp && uimage.comp != IH_COMP_GZIP ) >> + { >> + printk(XENLOG_ERR >> + "Unsupported uImage compression type %"PRIu8"\n", uimage.comp); >> + return -EOPNOTSUPP; >> + } >> + >> info->zimage.start = be32_to_cpu(uimage.load); >> info->entry = be32_to_cpu(uimage.ep); >> >> @@ -330,8 +343,26 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >> return -EINVAL; >> } >> >> - info->zimage.kernel_addr = addr + sizeof(uimage); >> - info->zimage.len = len; >> + if ( uimage.comp ) >> + { >> + int rc; >> + >> + /* Prepare start and size for decompression. */ >> + mod->start += sizeof(uimage); >> + mod->size -= sizeof(uimage); > > kernel_decompress() will free the compressed module once it is > decompressed. By updating the region it means the free page will be not > be freed (assuming start was previously page-aligned). Ok, so the start address was previously page-aligned and by adding the uimage size to it, it is no longer aligned. True. Do I understand you correctly that you refer to the fw_unreserved_regions call from kernel_decompress where we will pass unaligned address? This could be solved by doing (not harmful in my opinion for common case) addr &= PAGE_MASK. > >> + >> + rc = kernel_decompress(mod); >> + if ( rc ) >> + return rc; >> + >> + info->zimage.kernel_addr = mod->start; >> + info->zimage.len = mod->size; >> + } >> + else >> + { >> + info->zimage.kernel_addr = addr + sizeof(uimage); >> + info->zimage.len = len; >> + } >> >> info->load = kernel_zimage_load; >> >> @@ -561,6 +592,16 @@ int __init kernel_probe(struct kernel_info *info, >> printk("Loading ramdisk from boot module @ %"PRIpaddr"\n", >> info->initrd_bootmodule->start); >> >> + /* >> + * uImage header always appears at the top of the image (even compressed), >> + * so it needs to be probed first. Note that in case of compressed uImage, >> + * kernel_decompress is called from kernel_uimage_probe making the function >> + * self-containing (i.e. fall through only in case of a header not found). >> + */ >> + rc = kernel_uimage_probe(info, mod); >> + if ( rc != -ENOENT ) >> + return rc; >> + >> /* if it is a gzip'ed image, 32bit or 64bit, uncompress it */ >> rc = kernel_decompress(mod); >> if ( rc && rc != -EINVAL ) >> @@ -570,8 +611,6 @@ int __init kernel_probe(struct kernel_info *info, >> rc = kernel_zimage64_probe(info, mod->start, mod->size); >> if (rc < 0) >> #endif >> - rc = kernel_uimage_probe(info, mod->start, mod->size); >> - if (rc < 0) >> rc = kernel_zimage32_probe(info, mod->start, mod->size); >> >> return rc; > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Feb 01 10:14:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 10:14:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488248.756240 (Exim 4.92) (envelope-from ) id 1pNA7e-0003f9-6H; Wed, 01 Feb 2023 10:13:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488248.756240; Wed, 01 Feb 2023 10:13:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNA7e-0003f2-1Z; Wed, 01 Feb 2023 10:13:46 +0000 Received: by outflank-mailman (input) for mailman id 488248; Wed, 01 Feb 2023 10:13:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNA7c-0003ew-La for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 10:13:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNA7c-000437-7l; Wed, 01 Feb 2023 10:13:44 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.6.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNA7c-000613-1A; Wed, 01 Feb 2023 10:13:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yFgcVU7yIt0jV6VMzqw7JlDsUdET62UioCDmcwDUnO0=; b=aJ/0CSHpQReevYbqpysqTln4VS 5u6DNuvG7DJqLY4y/mngtETDbk9XKuhalbmRgYIJG5DwLHwqXGa72Pk3UA9axY864rZJ1W8pndiqc fAO/TrJDbcxPN98fUxxOfW8P1uQtdfe+y/0Jkh38eWp3CfEbHOgUO2ZC/C8VvZJqrFg4=; Message-ID: Date: Wed, 1 Feb 2023 10:13:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> Content-Language: en-US From: Julien Grall In-Reply-To: <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2023 09:48, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 31/01/2023 21:20, Julien Grall wrote: >> >> >> Hi, >> >> On 31/01/2023 15:13, Michal Orzel wrote: >>> At the moment, Xen does not support booting gzip compressed uImages. >>> This is because we are trying to decompress the kernel before probing >>> the u-boot header. This leads to a failure as the header always appears >>> at the top of the image (and therefore obscuring the gzip header). >>> >>> Move the call to kernel_uimage_probe before kernel_decompress and make >>> the function self-containing by taking the following actions: >>> - take a pointer to struct bootmodule as a parameter, >>> - check the comp field of a u-boot header to determine compression type, >>> - in case of compressed image, modify boot module start address and size >>> by taking the header size into account and call kernel_decompress, >>> - set up zimage.{kernel_addr,len} accordingly, >>> - return -ENOENT in case of a u-boot header not found to distinguish it >>> amongst other return values and make it the only case for falling >>> through to try to probe other image types. >>> >>> This is done to avoid splitting the uImage probing into 2 stages (executed >>> before and after decompression) which otherwise would be necessary to >>> properly update boot module start and size before decompression and >>> zimage.{kernel_addr,len} afterwards. >> >> AFAIU, it would be possible to have a zImage/Image header embedded in >> the uImage. So any reason to only handle a compressed binary? > Not sure if I understand you correctly as what you say is already supported. > The split or moving decompression is only needed in case of compressed uImage, > as u-boot header (not being part of compression) appears before gzip header. > This is not the case for zImage/Image header that is embedded into image > and gzip header is at the top. [...] > > In case of uImage added on top of zImage/Image, the load address/entry point are taken > from uImage header so basically the zImage/Image header is not parsed (this is > documented in our booting.txt). This is the case I am talking about. I think we need to parrse zImage/Image because it may contain additional information about the placement (for instance Image has a field to indicate the real size in memory). > > This patch makes the uImage compression works as the other combinations work fine already. > You can boot what you can already: > - zImage/Image > - compressed zImage/Image > - zImage/Image,raw with u-boot header > + this patch allows to boot: > - compressed uImage (i.e. zImage/Image/raw compressed with u-boot header) > >> >>> >>> Remove the limitation from the booting.txt documentation. >>> >>> Signed-off-by: Michal Orzel >>> --- >>> docs/misc/arm/booting.txt | 3 --- >>> xen/arch/arm/kernel.c | 51 ++++++++++++++++++++++++++++++++++----- >>> 2 files changed, 45 insertions(+), 9 deletions(-) >>> >>> diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt >>> index bd7bfe7f284a..02f7bb65ec6d 100644 >>> --- a/docs/misc/arm/booting.txt >>> +++ b/docs/misc/arm/booting.txt >>> @@ -50,9 +50,6 @@ Also, it is to be noted that if user provides the legacy image header on >>> top of zImage or Image header, then Xen uses the attributes of legacy >>> image header to determine the load address, entry point, etc. >>> >>> -Known limitation: compressed kernels with a uboot headers are not >>> -working. >>> - >>> >>> Firmware/bootloader requirements >>> -------------------------------- >>> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c >>> index 068fbf88e492..ea5f9618169e 100644 >>> --- a/xen/arch/arm/kernel.c >>> +++ b/xen/arch/arm/kernel.c >>> @@ -265,11 +265,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >>> #define IH_ARCH_ARM 2 /* ARM */ >>> #define IH_ARCH_ARM64 22 /* ARM64 */ >>> >>> +/* uImage Compression Types */ >>> +#define IH_COMP_GZIP 1 >>> + >>> /* >>> * Check if the image is a uImage and setup kernel_info >>> */ >>> static int __init kernel_uimage_probe(struct kernel_info *info, >>> - paddr_t addr, paddr_t size) >>> + struct bootmodule *mod) >>> { >>> struct { >>> __be32 magic; /* Image Header Magic Number */ >>> @@ -287,6 +290,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>> } uimage; >>> >>> uint32_t len; >>> + paddr_t addr = mod->start; >>> + paddr_t size = mod->size; >>> >>> if ( size < sizeof(uimage) ) >>> return -EINVAL; >>> @@ -294,13 +299,21 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>> copy_from_paddr(&uimage, addr, sizeof(uimage)); >>> >>> if ( be32_to_cpu(uimage.magic) != UIMAGE_MAGIC ) >>> - return -EINVAL; >>> + return -ENOENT; >>> >>> len = be32_to_cpu(uimage.size); >>> >>> if ( len > size - sizeof(uimage) ) >>> return -EINVAL; >>> >>> + /* Only gzip compression is supported. */ >>> + if ( uimage.comp && uimage.comp != IH_COMP_GZIP ) >>> + { >>> + printk(XENLOG_ERR >>> + "Unsupported uImage compression type %"PRIu8"\n", uimage.comp); >>> + return -EOPNOTSUPP; >>> + } >>> + >>> info->zimage.start = be32_to_cpu(uimage.load); >>> info->entry = be32_to_cpu(uimage.ep); >>> >>> @@ -330,8 +343,26 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>> return -EINVAL; >>> } >>> >>> - info->zimage.kernel_addr = addr + sizeof(uimage); >>> - info->zimage.len = len; >>> + if ( uimage.comp ) >>> + { >>> + int rc; >>> + >>> + /* Prepare start and size for decompression. */ >>> + mod->start += sizeof(uimage); >>> + mod->size -= sizeof(uimage); >> >> kernel_decompress() will free the compressed module once it is >> decompressed. By updating the region it means the free page will be not >> be freed (assuming start was previously page-aligned). > Ok, so the start address was previously page-aligned and by adding the uimage size > to it, it is no longer aligned. True. Do I understand you correctly that you refer > to the fw_unreserved_regions call from kernel_decompress where we will pass unaligned > address? Correct. > This could be solved by doing (not harmful in my opinion for common case) > addr &= PAGE_MASK. I don't quite understand your argument here. We need a check that work for everyone (not only in the common case). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 11:02:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 11:02:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488252.756251 (Exim 4.92) (envelope-from ) id 1pNAs6-00022x-ML; Wed, 01 Feb 2023 11:01:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488252.756251; Wed, 01 Feb 2023 11:01:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNAs6-00022q-J5; Wed, 01 Feb 2023 11:01:46 +0000 Received: by outflank-mailman (input) for mailman id 488252; Wed, 01 Feb 2023 11:01:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNAs5-00022k-9G for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 11:01:45 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20606.outbound.protection.outlook.com [2a01:111:f400:7e8a::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cdd614b3-a21f-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 12:01:43 +0100 (CET) Received: from BL1PR13CA0344.namprd13.prod.outlook.com (2603:10b6:208:2c6::19) by SA1PR12MB8096.namprd12.prod.outlook.com (2603:10b6:806:326::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 11:01:36 +0000 Received: from BL02EPF0000EE3D.namprd05.prod.outlook.com (2603:10b6:208:2c6:cafe::9e) by BL1PR13CA0344.outlook.office365.com (2603:10b6:208:2c6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.23 via Frontend Transport; Wed, 1 Feb 2023 11:01:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL02EPF0000EE3D.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.17 via Frontend Transport; Wed, 1 Feb 2023 11:01:35 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 05:01:34 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 03:01:34 -0800 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 1 Feb 2023 05:01:33 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdd614b3-a21f-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoLtJllTs53MF2baJot+Vq82a+7GBG9McejUP0WgiglhY5jyn5V6m8L+lioT1Y0JLZLmj+E2IcNP1Dpu03MwzD4rrLRsAxDjNNbr6AEktGWnNLKqSRpXXyNL4dZMn00AqRf/e8bkSY33BwAJh7MIiuSuPyf7mzmlc7/ZM6HGxprgHcC2YbBu0pdaNKIbAz588GvpI73fACSRkWC64RrkGMGDVEKDfvBEont1TUrhVsgo6gcJbo3Be3iECWbE5oO3hQIN9KuRWxVkk0rDcvaR1cDHGBwt3l7uft13x/keDnKSm1gbAoWOoYBo1vAjrAIClLx5E0yi68mmdIM1MKkCIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4rSbgbvsXDXbX9imJdiM0rAQK/eUPXBqxvzJH2t3+LA=; b=Ve7MexTTRE5hmEYxYgZdWIZBoU/yWVzLmwq9jG5OCfvhI0Qmf8+0qBIopLxl9bJqbl2UKK76k0WsZVNvZlZ+cpBrFJxtj6VXyyizpElRGNn20irTerQC5rwEMzaX0SU88eGmX2r2wBSQkd/2ZqBAU57h/A4N2Fqz2P0RTgYoXcqkJ20wI0cJfOGCT5zUXSrQ6mvi97k5gTldmgZcwgadir5NR2Edpq04PBiPX3J04moEnfpLEmAX7wMGXIWjir1oISi7bIHnBiBiE8LT7rE//teB+GzvW1ijPt8Ug2WJiyXjpPBIBbqu6am4srebXhmxdfE2a6bxTbk02b6C2bLalw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4rSbgbvsXDXbX9imJdiM0rAQK/eUPXBqxvzJH2t3+LA=; b=rCCnznG/5qEjsRE5Xffg1O/hpeC7RPoM1G7g5459DFzOkAG5qGhyT0uL/TBk4am6ckLH2jYhFSl7Nn8mYLrWkCeim7mECjiOGkVzgQgVUwY8Y7/zZDPMzpAZZBYzBd/YgCIfxPJlK8o9aCbHOEkbRfrRiaN7YbsTsf5TeYsHLxM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> Date: Wed, 1 Feb 2023 12:01:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3D:EE_|SA1PR12MB8096:EE_ X-MS-Office365-Filtering-Correlation-Id: fc2a5a31-e8f0-4239-4607-08db0443af68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MzHxsjyq6NoeBSNid97Y5fdlhPysJ6pEhqMSRo2ErL0ciKTtCPwZayFvkcpjhF87WDEpkbfV5DFcwGu2YvIPiBlWx6PoQ+hryj803zUm40GxOgxr61q9O//v5ejIo1yxFo7Wv3Iu9Jnh4GS0aqdevpRD656t3KiSyZQb/tM0dsAKqehpyiAEOcg/TKKm9xr08HL1zady4bc/YIkBxuPovXd2A12i/8fB88MFSqRpck/FU4C95+vMk1/4YqgnI30lP40vPD38rOHtcPlAJPHMmC66/a7fHsjcAm686JA2zH3JBS9YjrplvgJrSVVs9Ir17hYpXYlaxv8yosK5tBnChCJekKGS2Dwq8QJPfF6lWO/bNKCzBLZeBThdEE08bOBW78hQT68NgC2sOl9XNItEQCyWo+GTKNxP6jW6ilfO+4rK3n0EZ5YoA1HNvo9IXEqfBqbw5kCnp57WXozAg42gDYzdEgwHHHv7HxQt65QZeicBqCygfBB9XR5PT0eDJ3fDO2AE+cvODtiKCZOSEMd0W5+F0qdXuMKG0SktYJguw/kYNFDlCKo36wzY5Bbq08fSZiJ2OcNbLG8rJHJh3B9iQEaoCVWolfzzZ8Ki3q2e/ipHo1BeyNAznb4fCpGR6vw/hdiKY1rPMTK464yidcjDEsuglsdYYHH3zCGHCkWKt/fPK5Jm5l85ZJOSsG2Lw7I8lTygLt9tj0jXIaJdYIjEdLsxdK96Macn/xSdSXxzIDd9brRY4OpYl5Wky9hs3JjEB8iCDjUzr24X4xV1ZFI+tw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(396003)(136003)(346002)(451199018)(36840700001)(46966006)(40470700004)(356005)(81166007)(86362001)(70206006)(31696002)(82740400003)(54906003)(16576012)(36756003)(5660300002)(316002)(4326008)(36860700001)(70586007)(8936002)(8676002)(40460700003)(2906002)(40480700001)(44832011)(41300700001)(82310400005)(336012)(83380400001)(426003)(47076005)(478600001)(2616005)(26005)(186003)(53546011)(31686004)(110136005)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 11:01:35.4754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc2a5a31-e8f0-4239-4607-08db0443af68 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3D.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8096 Hi Julien, On 01/02/2023 11:13, Julien Grall wrote: > > > On 01/02/2023 09:48, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> >> On 31/01/2023 21:20, Julien Grall wrote: >>> >>> >>> Hi, >>> >>> On 31/01/2023 15:13, Michal Orzel wrote: >>>> At the moment, Xen does not support booting gzip compressed uImages. >>>> This is because we are trying to decompress the kernel before probing >>>> the u-boot header. This leads to a failure as the header always appears >>>> at the top of the image (and therefore obscuring the gzip header). >>>> >>>> Move the call to kernel_uimage_probe before kernel_decompress and make >>>> the function self-containing by taking the following actions: >>>> - take a pointer to struct bootmodule as a parameter, >>>> - check the comp field of a u-boot header to determine compression type, >>>> - in case of compressed image, modify boot module start address and size >>>> by taking the header size into account and call kernel_decompress, >>>> - set up zimage.{kernel_addr,len} accordingly, >>>> - return -ENOENT in case of a u-boot header not found to distinguish it >>>> amongst other return values and make it the only case for falling >>>> through to try to probe other image types. >>>> >>>> This is done to avoid splitting the uImage probing into 2 stages (executed >>>> before and after decompression) which otherwise would be necessary to >>>> properly update boot module start and size before decompression and >>>> zimage.{kernel_addr,len} afterwards. >>> >>> AFAIU, it would be possible to have a zImage/Image header embedded in >>> the uImage. So any reason to only handle a compressed binary? >> Not sure if I understand you correctly as what you say is already supported. >> The split or moving decompression is only needed in case of compressed uImage, >> as u-boot header (not being part of compression) appears before gzip header. >> This is not the case for zImage/Image header that is embedded into image >> and gzip header is at the top. > > [...] > >> >> In case of uImage added on top of zImage/Image, the load address/entry point are taken >> from uImage header so basically the zImage/Image header is not parsed (this is >> documented in our booting.txt). > > This is the case I am talking about. I think we need to parrse > zImage/Image because it may contain additional information about the > placement (for instance Image has a field to indicate the real size in > memory). As it was said during discussion on Ayan's patch, adding u-boot header on top of zImage/Image is not a common behavior and the purpose is questionable. Also I've never heard of any SW that would parse both headers. After all that is why u-boot has booti (Image), bootz (zImage) and bootm (uImage) commands. When using bootm to load Image/zImage with u-boot header, u-boot does not read the Image/zImage header but only u-boot header (this is what Xen does at the moment and was writeen by Ayan in documentation). If we really decide to do such a step (quite innovative :)) I would prefer not to do this in this series as the goals are different. This series is to remove the known Xen limitation. > >> >> This patch makes the uImage compression works as the other combinations work fine already. >> You can boot what you can already: >> - zImage/Image >> - compressed zImage/Image >> - zImage/Image,raw with u-boot header >> + this patch allows to boot: >> - compressed uImage (i.e. zImage/Image/raw compressed with u-boot header) >> >>> >>>> >>>> Remove the limitation from the booting.txt documentation. >>>> >>>> Signed-off-by: Michal Orzel >>>> --- >>>> docs/misc/arm/booting.txt | 3 --- >>>> xen/arch/arm/kernel.c | 51 ++++++++++++++++++++++++++++++++++----- >>>> 2 files changed, 45 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt >>>> index bd7bfe7f284a..02f7bb65ec6d 100644 >>>> --- a/docs/misc/arm/booting.txt >>>> +++ b/docs/misc/arm/booting.txt >>>> @@ -50,9 +50,6 @@ Also, it is to be noted that if user provides the legacy image header on >>>> top of zImage or Image header, then Xen uses the attributes of legacy >>>> image header to determine the load address, entry point, etc. >>>> >>>> -Known limitation: compressed kernels with a uboot headers are not >>>> -working. >>>> - >>>> >>>> Firmware/bootloader requirements >>>> -------------------------------- >>>> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c >>>> index 068fbf88e492..ea5f9618169e 100644 >>>> --- a/xen/arch/arm/kernel.c >>>> +++ b/xen/arch/arm/kernel.c >>>> @@ -265,11 +265,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >>>> #define IH_ARCH_ARM 2 /* ARM */ >>>> #define IH_ARCH_ARM64 22 /* ARM64 */ >>>> >>>> +/* uImage Compression Types */ >>>> +#define IH_COMP_GZIP 1 >>>> + >>>> /* >>>> * Check if the image is a uImage and setup kernel_info >>>> */ >>>> static int __init kernel_uimage_probe(struct kernel_info *info, >>>> - paddr_t addr, paddr_t size) >>>> + struct bootmodule *mod) >>>> { >>>> struct { >>>> __be32 magic; /* Image Header Magic Number */ >>>> @@ -287,6 +290,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>>> } uimage; >>>> >>>> uint32_t len; >>>> + paddr_t addr = mod->start; >>>> + paddr_t size = mod->size; >>>> >>>> if ( size < sizeof(uimage) ) >>>> return -EINVAL; >>>> @@ -294,13 +299,21 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>>> copy_from_paddr(&uimage, addr, sizeof(uimage)); >>>> >>>> if ( be32_to_cpu(uimage.magic) != UIMAGE_MAGIC ) >>>> - return -EINVAL; >>>> + return -ENOENT; >>>> >>>> len = be32_to_cpu(uimage.size); >>>> >>>> if ( len > size - sizeof(uimage) ) >>>> return -EINVAL; >>>> >>>> + /* Only gzip compression is supported. */ >>>> + if ( uimage.comp && uimage.comp != IH_COMP_GZIP ) >>>> + { >>>> + printk(XENLOG_ERR >>>> + "Unsupported uImage compression type %"PRIu8"\n", uimage.comp); >>>> + return -EOPNOTSUPP; >>>> + } >>>> + >>>> info->zimage.start = be32_to_cpu(uimage.load); >>>> info->entry = be32_to_cpu(uimage.ep); >>>> >>>> @@ -330,8 +343,26 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>>> return -EINVAL; >>>> } >>>> >>>> - info->zimage.kernel_addr = addr + sizeof(uimage); >>>> - info->zimage.len = len; >>>> + if ( uimage.comp ) >>>> + { >>>> + int rc; >>>> + >>>> + /* Prepare start and size for decompression. */ >>>> + mod->start += sizeof(uimage); >>>> + mod->size -= sizeof(uimage); >>> >>> kernel_decompress() will free the compressed module once it is >>> decompressed. By updating the region it means the free page will be not >>> be freed (assuming start was previously page-aligned). >> Ok, so the start address was previously page-aligned and by adding the uimage size >> to it, it is no longer aligned. True. Do I understand you correctly that you refer >> to the fw_unreserved_regions call from kernel_decompress where we will pass unaligned >> address? > > Correct. > >> This could be solved by doing (not harmful in my opinion for common case) >> addr &= PAGE_MASK. > I don't quite understand your argument here. We need a check that work > for everyone (not only in the common case). As we assume the kernel module is at page aligned address (otherwise the issue you observed can happen not only in uImage compressed case), having a check like this is generic. I.e. for normal usecase (no uImage compressed), addr &= PAGE_MASK does not modify the address. For uImage compressed usecase it causes the addr to get back to the previous value (before we added header size to it). Apart from the addr, we need to pass the correct size (as we extracted header size from it). We could have the following (with appropriate comment): size += addr - (addr & PAGE_MASK); addr &= PAGE_MASK; fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); It does not look great but solves the uImage issue and does not modify the previous behavior. Anyway, I'm open for suggestions. > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Feb 01 11:03:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 11:03:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488256.756262 (Exim 4.92) (envelope-from ) id 1pNAtt-0002b8-2I; Wed, 01 Feb 2023 11:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488256.756262; Wed, 01 Feb 2023 11:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNAts-0002b1-VS; Wed, 01 Feb 2023 11:03:36 +0000 Received: by outflank-mailman (input) for mailman id 488256; Wed, 01 Feb 2023 11:03:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNAtr-0002am-Tk for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 11:03:35 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 123e4fa7-a220-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 12:03:34 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id x7so14040140edr.0 for ; Wed, 01 Feb 2023 03:03:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 123e4fa7-a220-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=63E4bZcnjXxPCZ2oFpyFmXycec1XlTZ7Jkl0VBk2Mvs=; b=FPRx/DtSNYaBlMl7IXslAF1yMzYdZ2mGwF7+5h3DkaIZgsPGJV3C57+ey/YSc5LI0W 5aZ/VK6iDxbgmLjZ1IG609Wg3Ox3Y+52OeLljlw28/ssH7qukoHkfYzbzANbYDE6FTkP dx0w6r2+k2b+Bn5czhBtPFb+oVKaYLnLGZOSE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=63E4bZcnjXxPCZ2oFpyFmXycec1XlTZ7Jkl0VBk2Mvs=; b=fQMfvIs8F4g3TNyHGTK7duTBYnrOj/aGN2CMMaw9O0wEDeNU1Abx0MOIR9cS4JIoHw 1xCChfbQ8brdsGfY7hHduuE+Q1NJRtckXpLoQAz0u0yGcmJCr5HBC9d0A4EUV5zgWR2o 8xqAI44ydxgidTF/3xtP+37uLgb2FEv1sFXC3LQx6Rqf84hC0mFpg+ZFaLhozKdEXZ8R 4qk9RW9GpyVXqQwFUiyebW6se2ozNv3BVEWazTpyRBO9cR6OM+zwFSJNR82N98/B2JuH zsjt1b8xR2E3qhLnGvlT+9nepWBAq7uuos5QoCej8Wyb8wRaJB8LgVGF56LZ0RGVW3NU X9wQ== X-Gm-Message-State: AO0yUKWl2cUxBf69rgo6zz4/JHUTyeLKKyTW8mp22PBLuI/G7u/mwb2E oECq/PEQRHh9/4YMsNNTLLkWo3EfLpQW4OSxJ6mOLw== X-Google-Smtp-Source: AK7set8EZ4UFaQcUzeYpafO5v2NyXKToIe7pKGbheHfCHGvrOM/seow1TIFQbDVmvF87VXYyK/PEvibLmW2tFIt4t00= X-Received: by 2002:a05:6402:43c7:b0:4a2:5b0:264 with SMTP id p7-20020a05640243c700b004a205b00264mr468915edc.55.1675249414274; Wed, 01 Feb 2023 03:03:34 -0800 (PST) MIME-Version: 1.0 References: <20230120220004.7456-1-andrew.cooper3@citrix.com> <9abcfc06-1401-cdb7-a1f1-670cd307a593@srcf.net> In-Reply-To: <9abcfc06-1401-cdb7-a1f1-670cd307a593@srcf.net> From: George Dunlap Date: Wed, 1 Feb 2023 11:03:23 +0000 Message-ID: Subject: Re: [PATCH] Changelog: Add details about new features for SPR To: Andrew Cooper Cc: Henry Wang , Andrew Cooper , Xen-devel , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Content-Type: multipart/alternative; boundary="0000000000003f938d05f3a166d1" --0000000000003f938d05f3a166d1 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 30, 2023 at 3:54 PM Andrew Cooper wrote: > On 27/01/2023 11:40 am, Henry Wang wrote: > > Hi Andrew, > > > >> -----Original Message----- > >> From: Andrew Cooper > >> Subject: [PATCH] Changelog: Add details about new features for SPR > >> > >> Signed-off-by: Andrew Cooper > > Thanks for remembering this :) > > > > Acked-by: Henry Wang > > Thanks. > > I'll commit this when OSSTest has become unblocked. > > > > >> --- > >> A reminder to everyone, write the changelog as it happens, rather than > >> scrambling to remember 8 months of development just as the release is > >> happening. > > I wonder if there is a way to automate this in our CI so we can avoid > > forgetting this. But currently I am not really sure if the solution in > my mind > > is simple enough... I will try to keep this issue in my mind so that > probably I > > can come back with some solutions. > > The automated version is `git log $PREV_RELEASE > changelog.log`, and > this is very deliberately not that. > > It needs the maintainers / committers to keep "interesting user visible > changes" in mind at some point after the patches have gone in, are > logically complete, and have been around long enough that major > catastrophes (i.e. those liable to incur a full revert) are likely to > have happened. > > But I would like to stress. While it is the Release Maintainer's job to > make sure this gets done, it is not the Release Maintainers job to write > it. That is an unreasonable burden. > One approach would be to have someone / something (either the release manager, or an automated script) periodically (monthly? Bi-weekly?) email each maintainer a list of the commits under their remit, with an encouragement to consider what entries could be added to CHANGELOG.md. i.e., something like this: 8<--- Dear $MAINTAINER_NAME, During the last $TIME_PERIOD, the commits below have been checked into the tree which modify code under your maintainership. Please ensure that necessary changes to CHANGELOG.md have also been comitted. Thanks, $SENDER $GIT_LOG ---->8 Ideally this would prompt maintainers to get into the habit of always asking for CHANGELOG entries to be added during review (which would also get developers into the habit of always including them); at which point the maintainers could just skim the commits in the email and only add he odd CHANGELOG that they may have forgotten. Thoughts? -George --0000000000003f938d05f3a166d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jan 30, 2023 at 3:54 PM Andre= w Cooper <amc96@srcf.net> wrote= :
On 27/01/2023 = 11:40 am, Henry Wang wrote:
> Hi Andrew,
>
>> -----Original Message-----
>> From: Andrew Cooper <andrew.cooper3@citrix.com>
>> Subject: [PATCH] Changelog: Add details about new features for SPR=
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Thanks for remembering this :)
>
> Acked-by: Henry Wang <Henry.Wang@arm.com>

Thanks.

I'll commit this when OSSTest has become unblocked.

>
>> ---
>> A reminder to everyone, write the changelog as it happens, rather = than
>> scrambling to remember 8 months of development just as the release= is
>> happening.
> I wonder if there is a way to automate this in our CI so we can avoid<= br> > forgetting this. But currently I am not really sure if the solution in= my mind
> is simple enough... I will try to keep this issue in my mind so that p= robably I
> can come back with some solutions.

The automated version is `git log $PREV_RELEASE > changelog.log`, and this is very deliberately not that.

It needs the maintainers / committers to keep "interesting user visibl= e
changes" in mind at some point after the patches have gone in, are
logically complete, and have been around long enough that major
catastrophes (i.e. those liable to incur a full revert) are likely to
have happened.

But I would like to stress.=C2=A0 While it is the Release Maintainer's = job to
make sure this gets done, it is not the Release Maintainers job to write it.=C2=A0 That is an unreasonable burden.

One approach would be to have someone / something (either the release ma= nager, or an automated script) periodically (monthly?=C2=A0 Bi-weekly?) ema= il each maintainer a list of the commits under their remit, with an encoura= gement to consider what entries could be added to CHANGELOG.md.=C2=A0 i.e.,= something like this:

8<---
Dear $MAI= NTAINER_NAME,

During the last $TIME_PERIOD, the co= mmits below have been checked into the tree which modify code under your ma= intainership.=C2=A0 Please ensure that necessary changes to CHANGELOG.md ha= ve also been comitted.

Thanks,
=C2=A0$SE= NDER

$GIT_LOG
---->8

Ideally this would prompt maintainers to get into the habit of alw= ays asking for CHANGELOG entries to be added during review (which would als= o get developers into the habit of always including them); at which point t= he maintainers could just skim the commits in the email and only add he odd= CHANGELOG that they may have forgotten.

Thoughts?=

=C2=A0-George
--0000000000003f938d05f3a166d1-- From xen-devel-bounces@lists.xenproject.org Wed Feb 01 11:20:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 11:20:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488262.756273 (Exim 4.92) (envelope-from ) id 1pNB9y-0005h1-IO; Wed, 01 Feb 2023 11:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488262.756273; Wed, 01 Feb 2023 11:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNB9y-0005gu-EF; Wed, 01 Feb 2023 11:20:14 +0000 Received: by outflank-mailman (input) for mailman id 488262; Wed, 01 Feb 2023 11:20:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNB9w-0005go-M0 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 11:20:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNB9w-0005dw-4C; Wed, 01 Feb 2023 11:20:12 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.6.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNB9v-0000NU-SQ; Wed, 01 Feb 2023 11:20:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hg8uX44vBfViCGrkaX0dzp9s2UNwI8RN/ZaXh1/ViiU=; b=vCgURObd3RJCpODVwCFeXAP7T2 SOItSSSNUkRCZ4PcWZTvwQ4H/67tKQLy1sIBJhpEHEH6w4tttTQ34/fZAXoUxpiGw5ANzAxeCicZI /2N3v0G3ITWX6KbQBy4bKr0H0119OdHyM+K/Wk0l+l4gevkd7L16DrKMDx5J6CPxKDPg=; Message-ID: <6d3638e0-5613-ee7b-d919-1db3cd0ca2fb@xen.org> Date: Wed, 1 Feb 2023 11:20:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> From: Julien Grall In-Reply-To: <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2023 11:01, Michal Orzel wrote: > I would prefer not to do this in this series as the goals are different. This series is to remove > the known Xen limitation. The reason I am asking is it effectively change the way you would implement. If we were going to support zImage/Image within uImage, then we would need to fallthrough rather than calling kernel_decompress(). I am not aware of any at the moment. Better asking now than realizing after the fact that there is a need... >>> This could be solved by doing (not harmful in my opinion for common case) >>> addr &= PAGE_MASK. >> I don't quite understand your argument here. We need a check that work >> for everyone (not only in the common case). > As we assume the kernel module is at page aligned address (otherwise the issue you observed > can happen not only in uImage compressed case) I am not aware of such assumption. It is allowed to use non page-aligned address and it is correct for Xen to not free the first part if it is not page aligned because the first part may contain data from another module (or else). > , having a check like > this is generic. I.e. for normal usecase (no uImage compressed), addr &= PAGE_MASK > does not modify the address. For uImage compressed usecase it causes the addr to get > back to the previous value (before we added header size to it). > > Apart from the addr, we need to pass the correct size (as we extracted header size from it). > We could have the following (with appropriate comment): > size += addr - (addr & PAGE_MASK); > addr &= PAGE_MASK; > fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); > > It does not look great but solves the uImage issue and does not modify > the previous behavior. Anyway, I'm open for suggestions. Two options: 1) Move the call to fw_unreserved_regions() outside of kernel_decompress(). 2) Pass the offset of the gzip header to kernel_decompress(). Something like where it would be sizeof(uimage) in the uImage case or 0 otherwise. I have a slight preference for the latter. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 12:05:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 12:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488274.756284 (Exim 4.92) (envelope-from ) id 1pNBqy-00035t-7i; Wed, 01 Feb 2023 12:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488274.756284; Wed, 01 Feb 2023 12:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNBqy-00035m-4F; Wed, 01 Feb 2023 12:04:40 +0000 Received: by outflank-mailman (input) for mailman id 488274; Wed, 01 Feb 2023 12:04:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNBqw-00035c-Ud; Wed, 01 Feb 2023 12:04:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNBqw-0006bC-RT; Wed, 01 Feb 2023 12:04:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNBqw-00010O-DI; Wed, 01 Feb 2023 12:04:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNBqw-0007o2-Cq; Wed, 01 Feb 2023 12:04:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6JFJDn/imlW59rvHvnTjoBg/PhvT1SGSHwKoNu0n8u4=; b=SXW6c0pZBCpEoGi7jqp82UXGpa K/6Vb7mGnOU/Mb0L3bhQwWcmixxFesHTMorxWqo3d4cjqRQUzwTCQKczLXy06rxkDOW+n6dip/Eqm jObt196tyLXuhuXFT0oYNe8jzUyJFbpPWMIhMykrjeTD2smIk44xofkH2wSObL7SfLN8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176312: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 12:04:38 +0000 flight 176312 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176312/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 5 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 12:57:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 12:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488286.756299 (Exim 4.92) (envelope-from ) id 1pNCfr-00022u-8a; Wed, 01 Feb 2023 12:57:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488286.756299; Wed, 01 Feb 2023 12:57:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCfr-00022n-5z; Wed, 01 Feb 2023 12:57:15 +0000 Received: by outflank-mailman (input) for mailman id 488286; Wed, 01 Feb 2023 12:57:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCfp-00022h-6s for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 12:57:13 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20613.outbound.protection.outlook.com [2a01:111:f400:7e89::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id edd8ca91-a22f-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 13:57:08 +0100 (CET) Received: from DS7PR03CA0284.namprd03.prod.outlook.com (2603:10b6:5:3ad::19) by CH3PR12MB7739.namprd12.prod.outlook.com (2603:10b6:610:151::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 12:56:58 +0000 Received: from DM6NAM11FT010.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3ad:cafe::84) by DS7PR03CA0284.outlook.office365.com (2603:10b6:5:3ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Wed, 1 Feb 2023 12:56:58 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT010.mail.protection.outlook.com (10.13.172.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6043.22 via Frontend Transport; Wed, 1 Feb 2023 12:56:57 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 06:56:57 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 1 Feb 2023 06:56:57 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 1 Feb 2023 06:56:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edd8ca91-a22f-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LvwyuiccdLpsKc4WckWj6G4ZADxbfwCdjbS5d69Yl+kDuGLGC3TvR8RH2hQkPnBL0+SX5PMC2bQqCbLOLoFA7gPXmB/kaZgiolCXwMpJpQU2bixpU+qvVsQ00jYZoWW8KPQ3q8C6Z2frcvk0D0i7oEIHwd8taVnf3Yk75NUOulJlDy+cC1usFx0H1tdevzEqywY8TGhfePQtgBhc8J4j5cUF0ImjeTvUDUijn6ciGkhQzHv7XInIT7pNv1H+f75LuI1xqufjG/iqG+feDbZ1a0a4CiFBiIx2QAfX/9mfEpby7REsMikDTnB/AnVBjkGWQEPKuBSwPeR1W9i7q7nykg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WvqYw0/lNPG2MdgZ9v8aXe2CpdozdWz6QrasYdhRl5A=; b=apwarLKg0qk/YSn8PsrJNNzWc8E4mLgdIEOEzw6bRYqToqigI6I0XAiVIshwgAwNKAPEbh+mJ0mhdfn/fAqrSHyesHKzjOc4wTqai3HplBFatdd4U+3BlF3SHgqqo2mx8JBX4byQPm8BCzShorRXE4zCJ2NBtyv4lax4uUGcHOH1ZsmfASrc9pNj4svZe8F1g0KvAYmS41PfXbkGayEkQSTnPxBXAH5rNz0cxllHKS2cHgJhXT0RQPeMx7aqBhxYMuLnSrod2UOrbbZyKG3NJuV4I0JXp5tcET7nfEcF6vP4k0g51KBrGET0bKBvYXnLrS4f11SanDgivarxwAam5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WvqYw0/lNPG2MdgZ9v8aXe2CpdozdWz6QrasYdhRl5A=; b=41PKH6kBk0wM7vLSYPW1ZIUliv3ny5m/k86+2WLukdj2chI7IRDbp2kqqbHwWDENIhY8Kn4BGGKKCmz4fanPMGugvD1YvLde/jIifhjqMMfVi520qfr7KpWK4swSBo6Nsk1tdbg9fTWeu7Q81v0gOe5sViAwPQhTxdrbUcJpWRo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Wed, 1 Feb 2023 13:56:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> <6d3638e0-5613-ee7b-d919-1db3cd0ca2fb@xen.org> From: Michal Orzel In-Reply-To: <6d3638e0-5613-ee7b-d919-1db3cd0ca2fb@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT010:EE_|CH3PR12MB7739:EE_ X-MS-Office365-Filtering-Correlation-Id: a8997248-9c50-4ce5-e502-08db0453cd83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rjy8ZrcqC5UlpEbd5pkRAiczCudkympnTfHpZ8aM9WwjpN7yxsugEsTP39pzdl8BlJZWjuQ6nWRxC3cfzcuehmVC44mmcgVtKzWiwlw1mois7XJOr3q03KIva0PzBhV+RjnZiZPALRTaLtJkeveUwo63nU8IrO8j5FlI2Ird7SNFHNEUB8RbJZYA0geqZCkmqBRD3YKppUnJdA+8Tg4y1sr9rA/+t2DmTh797ne2GruaB8GrlkGpQ+n1lCkNWjALqM5MrksJCdRE5Fm5SV4JNxAxx4TqCUSGAWAfwKm21Nx8JUaivF358HekURYZCc/3gCuxGgCiyyFrP0tuM7c8fUY/s9TfMn8xvS06Agoziq2j5xWCFO0HY2gcfglmsNSQr+e4CkFF/uIhqJsQ61f/JwUih2a6+bokZySSHvK5qcSYlL/eTRyrjYnRZq53jJ3r8k/54kUbpFp6+Wx9O39U8QBVkNti0jaqkV69HvJ7aqfP/gjBHyHyiAjxJgXZdZfnhqtJIVk4rZJKgDsTwIjl7jhJtzkGqSJz8jRk4x5FXlF9poASddDJso6AheWob6xJw4HW9L8T0oVewyp4UiO+K5jUJg8ku8y5+3CAfRtt9/Cumywfrn1JbbZOpFb1kHqGySgvt2Qah21/7/1jjImEAIEUUZvB1KeWiABcRDamvKK5FxhehUVt7nw8cs/KOj++ItxEFYDaioDGKFKRl1rUreopDZYETCsLwonzARGuAWj6y8B/Envlar1nWhW4WR323Vib5KL5LiOE3Dz/i1jZMQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199018)(36840700001)(40470700004)(46966006)(36860700001)(44832011)(81166007)(40460700003)(41300700001)(478600001)(86362001)(31696002)(40480700001)(110136005)(16576012)(316002)(356005)(70206006)(70586007)(4326008)(8676002)(54906003)(186003)(26005)(8936002)(36756003)(53546011)(82740400003)(5660300002)(47076005)(426003)(83380400001)(82310400005)(31686004)(2616005)(2906002)(336012)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 12:56:57.8574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8997248-9c50-4ce5-e502-08db0453cd83 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT010.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7739 Hi Julien, On 01/02/2023 12:20, Julien Grall wrote: > > > On 01/02/2023 11:01, Michal Orzel wrote: >> I would prefer not to do this in this series as the goals are different. This series is to remove >> the known Xen limitation. > > The reason I am asking is it effectively change the way you would > implement. If we were going to support zImage/Image within uImage, then > we would need to fallthrough rather than calling kernel_decompress(). > > I am not aware of any at the moment. Better asking now than realizing > after the fact that there is a need... We need uImage support as there is more and more need to support booting raw images of some RTOSes (there is always additional concern \wrt booting requirements but at least the header allows to try to boot them). We are not aware of any need to do some special handling to parse more than one header + from what I said earlier, this is an unusual approach not seen to be handled by anyone. > >>>> This could be solved by doing (not harmful in my opinion for common case) >>>> addr &= PAGE_MASK. >>> I don't quite understand your argument here. We need a check that work >>> for everyone (not only in the common case). >> As we assume the kernel module is at page aligned address (otherwise the issue you observed >> can happen not only in uImage compressed case) > > I am not aware of such assumption. It is allowed to use non page-aligned > address and it is correct for Xen to not free the first part if it is > not page aligned because the first part may contain data from another > module (or else). > >> , having a check like >> this is generic. I.e. for normal usecase (no uImage compressed), addr &= PAGE_MASK >> does not modify the address. For uImage compressed usecase it causes the addr to get >> back to the previous value (before we added header size to it). >> >> Apart from the addr, we need to pass the correct size (as we extracted header size from it). >> We could have the following (with appropriate comment): >> size += addr - (addr & PAGE_MASK); >> addr &= PAGE_MASK; >> fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); >> >> It does not look great but solves the uImage issue and does not modify >> the previous behavior. Anyway, I'm open for suggestions. > > Two options: > 1) Move the call to fw_unreserved_regions() outside of > kernel_decompress(). > 2) Pass the offset of the gzip header to kernel_decompress(). > Something like where it would be sizeof(uimage) in the uImage case or 0 > otherwise. > > I have a slight preference for the latter. That is cool. I'm in favor of this as well because it would allow not to set mod->start,size from kernel_uimage_probe. Everything can be done in kernel_decompress: Diff: -static __init int kernel_decompress(struct bootmodule *mod) +static __init int kernel_decompress(struct bootmodule *mod, uint32_t offset) { char *output, *input; char magic[2]; @@ -201,8 +201,14 @@ static __init int kernel_decompress(struct bootmodule *mod) struct page_info *pages; mfn_t mfn; int i; - paddr_t addr = mod->start; - paddr_t size = mod->size; + + /* + * It might be that gzip header does not appear at the start address + * (i.e. in case of compressed uImage) so take into account offset to + * gzip header. + */ + paddr_t addr = mod->start + offset; + paddr_t size = mod->size - offset; if ( size < 2 ) return -EINVAL; @@ -250,6 +256,13 @@ static __init int kernel_decompress(struct bootmodule *mod) for ( ; i < (1 << kernel_order_out); i++ ) free_domheap_page(pages + i); + /* + * When freeing the kernel, we need to pass the module start address and + * size as they were before taking an offset to gzip header into account. + */ + addr -= offset; + size += offset; + /* * Free the original kernel, update the pointers to the * decompressed kernel > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Wed Feb 01 13:17:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 13:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488294.756316 (Exim 4.92) (envelope-from ) id 1pNCzH-0005J0-2O; Wed, 01 Feb 2023 13:17:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488294.756316; Wed, 01 Feb 2023 13:17:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCzG-0005It-TO; Wed, 01 Feb 2023 13:17:18 +0000 Received: by outflank-mailman (input) for mailman id 488294; Wed, 01 Feb 2023 13:17:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCzG-0005Ij-6l; Wed, 01 Feb 2023 13:17:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCzG-0008Ng-4P; Wed, 01 Feb 2023 13:17:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNCzF-0002o5-Ip; Wed, 01 Feb 2023 13:17:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNCzF-0003qp-IJ; Wed, 01 Feb 2023 13:17:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LUdF5yE/EWLwYoLRkvMnkCfr6c4cpQJw2mGhRBZ5tXk=; b=7AalDdeMpZpPbvB0VDUhqgEVhx 2uCcKndXadDycuo7gcQWi88lXXhFbSC+qVdLT35tuoYYbwfvDPl4KkjMoxA7RFeCJzNskdRiCauxf YpnrED2ZSji4RadPcOv+mBbWCHkOjc8xykpjiTXZyoEXxaZKrPr86/SAVcsLkiZymhiE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176304: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-linus:build-armhf::broken:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel::broken:regression linux-linus:test-amd64-amd64-freebsd12-amd64::broken:regression linux-linus:test-amd64-amd64-qemuu-nested-intel::broken:regression linux-linus:test-amd64-amd64-pygrub::broken:regression linux-linus:test-amd64-amd64-freebsd12-amd64:host-install(5):broken:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:host-install(5):broken:regression linux-linus:build-armhf:host-install(4):broken:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:host-install(5):broken:regression linux-linus:test-amd64-amd64-pygrub:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:build-armhf:syslog-server:running:regression linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:build-armhf:capture-logs:broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c0b67534c95c537f7a506a06b98e5e85d72e2b7d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Wed, 01 Feb 2023 13:17:17 +0000 flight 176304 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-xl-pvhv2-intel broken test-amd64-amd64-freebsd12-amd64 broken test-amd64-amd64-qemuu-nested-intel broken test-amd64-amd64-pygrub broken test-amd64-amd64-freebsd12-amd64 5 host-install(5) broken REGR. vs. 173462 test-amd64-amd64-qemuu-nested-intel 5 host-install(5) broken REGR. vs. 173462 build-armhf 4 host-install(4) broken REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 5 host-install(5) broken REGR. vs. 173462 test-amd64-amd64-pygrub 5 host-install(5) broken REGR. vs. 173462 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 19 guest-localmigrate/x10 fail REGR. vs. 173462 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 173462 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 173462 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: linux c0b67534c95c537f7a506a06b98e5e85d72e2b7d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 116 days Failing since 173470 2022-10-08 06:21:34 Z 116 days 239 attempts Testing same since 176304 2023-02-01 00:13:30 Z 0 days 1 attempts ------------------------------------------------------------ 3468 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 broken test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel broken test-amd64-amd64-xl-pvhv2-intel broken test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub broken test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-job test-amd64-amd64-xl-pvhv2-intel broken broken-job test-amd64-amd64-freebsd12-amd64 broken broken-job test-amd64-amd64-qemuu-nested-intel broken broken-job test-amd64-amd64-pygrub broken broken-step build-armhf capture-logs broken-step test-amd64-amd64-freebsd12-amd64 host-install(5) broken-step test-amd64-amd64-qemuu-nested-intel host-install(5) broken-step build-armhf host-install(4) broken-step test-amd64-amd64-xl-pvhv2-intel host-install(5) broken-step test-amd64-amd64-pygrub host-install(5) Not pushing. (No revision log; it would be 533994 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 13:29:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 13:29:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488306.756327 (Exim 4.92) (envelope-from ) id 1pNDBM-0007FA-7Q; Wed, 01 Feb 2023 13:29:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488306.756327; Wed, 01 Feb 2023 13:29:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNDBM-0007F3-4S; Wed, 01 Feb 2023 13:29:48 +0000 Received: by outflank-mailman (input) for mailman id 488306; Wed, 01 Feb 2023 13:29:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNDBL-0007Ex-2o for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 13:29:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b984eb3-a234-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 14:29:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b984eb3-a234-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675258185; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=i7KYkpkwLrJeQiqmARu1gX5bVgBma3PSiIgTw8YCdtg=; b=BqXbCe6Rw7/XZPc23VsWNCLjRJQWmGcu5CBaE4286l1g/fd5doaCmH3z Wkiyg0gDMHe6z8/y7s2BpiS14/KlHWXcFgjGkLOiYQ0JWOo+Huxayie8W vHfqkBpyVS3/yj9F22IWv0OUS2VL2sKbqu4ia0gB8KOWdMHsRjU2vGMnf c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 94615550 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:NrphE6r6zarhWHiGlHUtIfI9N0ReBmIZZRIvgKrLsJaIsI4StFCzt garIBnVPfffYmH9L9tzPonkpE4Hu5LczNc3Tldo+S8wFXlH8JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACgmd0yDoMWr+ayQTNN9h/wkdND0YIxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jOaoT2kX0xCXDCZ4Rar2HKmm9/9oR3iAboxMpfh9dhFr2TGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U24R+A4rDZ6AGYAi4DVDEpVTA9nJZoH3pwj AbPxo63Q2U169V5VE5x6J+MhiruOQ8yMFYcTik+XAo95IH6v90820enoslYLIa5idj8GDfVy j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPdTA1LTN0RpXwG91pHGlt WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHRcFJG9eFoSTLkWVsDNZWei9U3j4sI2OBX aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CK+JN4sWOsAsLlXYlM2LWaJ39zm9+HXAbIllY cvLGSpSJSly5VtbIMqeGL5GjO5DKtEWzmLPX5HrpylLIpLHDEN5vYwtaQPUBshgtfPsnekg2 4oHXyd840kFAbKWj+i+2dJ7EG3m2lBhWMmp95QLJrHaSuekcUl4Y8LsLXoaU9QNt8xoei3gp BlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:UlC0ka+vJp881wKjHJ9uk+DQI+orL9Y04lQ7vn2ZHyYlF/Bw8P re/sjztCWE6wr5PUtLpTnuAsS9qB/nmaKdgrNwAV7BZmfbUQKTRekI0WKI+Vzd8kPFmdK0ZM xbAsxDNOE= X-IronPort-AV: E=Sophos;i="5.97,263,1669093200"; d="scan'208";a="94615550" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Rob Hoes Subject: [PATCH] tools/ocaml/libs: Fix memory/resource leaks with caml_alloc_custom() Date: Wed, 1 Feb 2023 13:29:24 +0000 Message-ID: <20230201132924.28711-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit All caml_alloc_*() functions can throw exceptions, and longjump out of context. If this happens, we leak the xch/xce handle. Reorder the logic to allocate the the Ocaml object first. Fixes: 8b3c06a3e545 ("tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free") Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak") Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Török CC: Rob Hoes --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 6 ++++-- tools/ocaml/libs/xc/xenctrl_stubs.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index 34dcfed30275..1980acf405a5 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -63,6 +63,8 @@ CAMLprim value stub_eventchn_init(value cloexec) if ( !Bool_val(cloexec) ) flags |= XENEVTCHN_NO_CLOEXEC; + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + caml_enter_blocking_section(); xce = xenevtchn_open(NULL, flags); caml_leave_blocking_section(); @@ -70,7 +72,6 @@ CAMLprim value stub_eventchn_init(value cloexec) if (xce == NULL) caml_failwith("open failed"); - result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); *(xenevtchn_handle **)Data_custom_val(result) = xce; CAMLreturn(result); @@ -82,6 +83,8 @@ CAMLprim value stub_eventchn_fdopen(value fdval) CAMLlocal1(result); xenevtchn_handle *xce; + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); + caml_enter_blocking_section(); xce = xenevtchn_fdopen(NULL, Int_val(fdval), 0); caml_leave_blocking_section(); @@ -89,7 +92,6 @@ CAMLprim value stub_eventchn_fdopen(value fdval) if (xce == NULL) caml_failwith("evtchn fdopen failed"); - result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 0, 1); *(xenevtchn_handle **)Data_custom_val(result) = xce; CAMLreturn(result); diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index f9006c662382..ed1cbafdb488 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -98,6 +98,8 @@ CAMLprim value stub_xc_interface_open(value unit) CAMLlocal1(result); xc_interface *xch; + result = caml_alloc_custom(&xenctrl_ops, sizeof(xch), 0, 1); + caml_enter_blocking_section(); xch = xc_interface_open(NULL, NULL, 0); caml_leave_blocking_section(); @@ -105,7 +107,6 @@ CAMLprim value stub_xc_interface_open(value unit) if ( !xch ) failwith_xc(xch); - result = caml_alloc_custom(&xenctrl_ops, sizeof(xch), 0, 1); *(xc_interface **)Data_custom_val(result) = xch; CAMLreturn(result); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Feb 01 14:54:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 14:54:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488313.756338 (Exim 4.92) (envelope-from ) id 1pNEV1-0001xx-7R; Wed, 01 Feb 2023 14:54:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488313.756338; Wed, 01 Feb 2023 14:54:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNEV1-0001xq-4h; Wed, 01 Feb 2023 14:54:11 +0000 Received: by outflank-mailman (input) for mailman id 488313; Wed, 01 Feb 2023 14:54:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNEV0-0001xg-BT; Wed, 01 Feb 2023 14:54:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNEV0-0002Rc-6L; Wed, 01 Feb 2023 14:54:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNEUz-0008Cz-QQ; Wed, 01 Feb 2023 14:54:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNEUz-0004Rs-Py; Wed, 01 Feb 2023 14:54:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eCBTHJEnLpdSiuvizkj+qa0kj93lJWJNvCa+i2maTYA=; b=iSEqwuJEutuFF7DqIWuuwYRoUP AgpdIrFVSUJFV0onMexep+d4rX7rJt80DgUYFxl18Om1TV1ADpuB7m6BShAKVaVwY1MVHJ7Bik4Wj 7uisGtCKRGLIXXFt8QOMlThqKcxgMBuamvUyctFlIc6AYH2svD5sVq6GxxLtbhwTiGjI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176313: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 14:54:09 +0000 flight 176313 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176313/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 15:34:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 15:34:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488320.756349 (Exim 4.92) (envelope-from ) id 1pNF7i-0007dl-8c; Wed, 01 Feb 2023 15:34:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488320.756349; Wed, 01 Feb 2023 15:34:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNF7i-0007de-5d; Wed, 01 Feb 2023 15:34:10 +0000 Received: by outflank-mailman (input) for mailman id 488320; Wed, 01 Feb 2023 15:34:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNF7h-0007dI-AA for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 15:34:09 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd0daf19-a245-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 16:34:06 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso1765810wmq.5 for ; Wed, 01 Feb 2023 07:34:06 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id f31-20020a05600c491f00b003dc3d9fb09asm2072405wmp.47.2023.02.01.07.34.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 07:34:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd0daf19-a245-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pmru7z6DNxabZ+7LeeevMB28YXFl7Ld5NjLT+3YrBUU=; b=F2EHC15HNiw32S7SlueGiSWDfGzcdoyfq6yb34HBZ0hvnmXvab1QWNzE3NAso2FtUY EX3svebRlAJ/l7c13EqBoZaMxg2ogVIKYMwAT5Oy4gpOhrl2JhdX9rH3Tld38HWUzIcN w8Im6PlqnmJs3I5z6114smK1MyMn2+4Qdwpfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pmru7z6DNxabZ+7LeeevMB28YXFl7Ld5NjLT+3YrBUU=; b=WQANcj4rEkHAEr0N0K+lXwP3Ez4Gu9Vgvs07UeK00VzDWwlW7RD+zXLnw07321LGIV uHx+xdjyVXRSwUkp5hyewMwx9mX0nboWGAM6ZO4dT+HYIbQYHyqX6fGNfJn6mNqNk78P sLWr96bDpQ/zd8BB+EXEV5FpfveUG1wGt3Rs0Kcvr4Ly2XLG4pyG3C4px9llMay/l8Cq xUWd85CUscg0cL1nJ3UUlvo47r+N0Kj+DPWZhDUHd4K46x7gVxS31D70JSNCkak40HYA M/m4pB9iOzbsD3C66zC0TSjKfdOwWUp/w+bK41SsU3TXr40Y/R8lXJ5Npy17bbeAglnz 9u4Q== X-Gm-Message-State: AO0yUKW0qK4fLa4iGV0xGcoVZdfuBkOy8y4fOUVsV9eywN34HlwvEzpU wq725gvoXRffR7ssnZyGipUhdQ== X-Google-Smtp-Source: AK7set/UnIcy0ea0yzVVqftCsucuQhKgEK49RhXevmX/sbrqnHC4Z2Z+yOOOODZUl6L/Vd3mDb2OHA== X-Received: by 2002:a05:600c:538e:b0:3dc:2c7c:6616 with SMTP id hg14-20020a05600c538e00b003dc2c7c6616mr2332323wmb.21.1675265646535; Wed, 01 Feb 2023 07:34:06 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] tools/ocaml/libs: Fix memory/resource leaks with caml_alloc_custom() From: Christian Lindig In-Reply-To: <20230201132924.28711-1-andrew.cooper3@citrix.com> Date: Wed, 1 Feb 2023 15:34:05 +0000 Cc: Xen-devel , Christian Lindig , David Scott , =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , Rob Hoes Content-Transfer-Encoding: quoted-printable Message-Id: <3F433EFB-199F-44F8-AE80-C3AFCF5159C0@cloud.com> References: <20230201132924.28711-1-andrew.cooper3@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 1 Feb 2023, at 13:29, Andrew Cooper = wrote: >=20 > All caml_alloc_*() functions can throw exceptions, and longjump out of > context. If this happens, we leak the xch/xce handle. >=20 > Reorder the logic to allocate the the Ocaml object first. >=20 > Fixes: 8b3c06a3e545 ("tools/ocaml/xenctrl: OCaml 5 support, fix = use-after-free") > Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix = potential resource leak") > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig > CC: David Scott > CC: Edwin T=C3=B6r=C3=B6k > CC: Rob Hoes > --- > tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 6 ++++-- > tools/ocaml/libs/xc/xenctrl_stubs.c | 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488355.756377 (Exim 4.92) (envelope-from ) id 1pNGYA-0004mn-7S; Wed, 01 Feb 2023 17:05:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488355.756377; Wed, 01 Feb 2023 17:05:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGYA-0004mg-4e; Wed, 01 Feb 2023 17:05:34 +0000 Received: by outflank-mailman (input) for mailman id 488355; Wed, 01 Feb 2023 17:05:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGY8-0004ma-HW for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:05:32 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20627.outbound.protection.outlook.com [2a01:111:f400:7e8a::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1294a0d-a252-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 18:05:30 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by MN0PR12MB5979.namprd12.prod.outlook.com (2603:10b6:208:37e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 17:05:27 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%5]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 17:05:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1294a0d-a252-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keDqcSU0e2Tbb5l1nzlpF3mVhZ7hDzNJnMiuvQxCbU9VG+eIWPZFq0xlyEUvU/sYSLbMJ9xIPalSnOZvJlGKk7AkDtC5EmBVeZeSdBCzxJo1a6N6gDt7+vmrXm7RZhYW8tkYu1DcMkvceNh2YfcOKxipBSrfKDVQC7d2f8CMO/5UvWPcqBZS+u4cwPkbVfQSsXFSivNFcZsw0yItuXzqgd0B7itVe/xhC9WkdKFhs9SVf2NKyLcLLh/0SIhYg3dEUE2wgf8jZxD2Zy4Fd7BygAptc9OKI5X0MDnwHST5WA5VBTwDCOeqlhmkUPQYTnT0+Jw9mZ60fFLG7VV9Inh7TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GA94RVLce3o5GlWAMhI7az39HzBXE50ceQe87PcPDdE=; b=d/gvSInXtqhQCTuA9jNvbuw2hIbqQUsaMCM1P0VIW93QIbEPrTZzCRDWUNvHnGGQHkW02LCOTKPJczlgICG9yOo3bbme6reWyydWEmkwU6rWVv/dIYrNmMIpBnm0IpSZJ7I3C3I6uKQDP79zNwDD232Jn8w3OC91MYliocfkY0Y/bUOmihHlFAaE6q4PY3js16oOaUG6rbSFGv9hfceYOOPdXhelgEIj8q8f2HPVRngjWDbeqzloej6N+rDiVDghbOrGBO6NbXuzvxd/vBc//WKaumYWbdno1AfZv1I+SNBX7o52ID8wv+90pE5TIirOk4XGdkVKmntqnsNHCFre/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GA94RVLce3o5GlWAMhI7az39HzBXE50ceQe87PcPDdE=; b=NozZG80Z39oqWXcoMkj3kD8agrIqMJnIybMEokEi6a36rCfG4K7U+2yIjrZ9lRz5LfqHP0L3slFZalpeCrNQJqIrC5mmf2XMo4aQ6cRKUxwiALMqB+GIEtqivbeArGYMiQ8AETp+rgs+gNEoNJs41pdQblDU/Pp6Q8G1ZvamqIU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <796a88a8-03d2-14f8-be50-10085d785eed@amd.com> Date: Wed, 1 Feb 2023 09:05:24 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 11/16] common/device_tree: Add rwlock for dt_host Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Luca.Fancellu@arm.com References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-5-vikram.garhwal@amd.com> <9560a124-020c-6a5c-d4ce-c26e52413bd2@xen.org> From: Vikram Garhwal In-Reply-To: <9560a124-020c-6a5c-d4ce-c26e52413bd2@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR05CA0115.namprd05.prod.outlook.com (2603:10b6:a03:334::30) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|MN0PR12MB5979:EE_ X-MS-Office365-Filtering-Correlation-Id: a7d57085-96f0-47e3-8371-08db047683cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4lXCrSXRoc6ZUQBB45Pqov8cDQTPobiYeiXc/N6F6C1xtqqEBU2ZeZNa1TsZUEzR3Bv1QcGZK+46039k23uhHXvzM4zTXDeSIfLH87VhbPomDHv+XwesNryl2NZ3vnILpSsPdAe+WaYj8ok9yOmOL3hs8MIiCCfxBxZmA01v6/CU5JHYQLiLFXVNVxvzpPTA9AIfnf0hj2YzfRUMWqMMA37NwI7lYpxN0BNY825jK/xuB251IWcTLYXr3u7knp7s+IrDVlZqeHUz4lqhUc1oajAlgSyO9ogfA7+Ftg3Fofp6Scm7x38fOlI7ZSGQ6K47CD6lK21IW/eZXVS8+EQEa+tvFfEUjtgely3jbIWlJgCgCkDhdpy6jdDACSDn3PiTsNI/j9AwNpDnm6CsfjtXNuCr7mSb2FhD6oZhAp/4NL9QzKQFBCP1OF4DSUFYhK/nqKa4KrDLb69fps5gYM8PiLY8BNHpM67+Eosvnlp+b+GmhcgABEl1Nh/gqJzmKxQITr/WKNV7w7HZEwOK+9eJ+MU1GY01wVumXaaWmcxNJKzP3J7uwXrj9/ZvVxBqB6zAAgwkfqhi2x3uwyZRcPE6R2XBcvS1eRCqfDmREiN1Gvt+FM978Ga1UPRoxYnB/sEkId46nW4nvc3Ir0j4Eh1tujYWfpvn51SOZNLIW8uViQNASVgj0CcvoDxokHgFXWU7x8iSMzPUwZu+JwLLrGdbC+FIYRqvZ8iLBGDqOhZYNm0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199018)(44832011)(26005)(36756003)(83380400001)(2906002)(6506007)(478600001)(66476007)(186003)(6512007)(53546011)(86362001)(31696002)(6486002)(4326008)(66946007)(2616005)(8936002)(5660300002)(41300700001)(316002)(8676002)(66556008)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkFBOTdZR094V0xtaGFEWVJhUm1FZ0xJcmg0aFlDUjEvT240NU5QYTRLaVhV?= =?utf-8?B?WFBtQWlTYm9qNFprc2xLcHN1eWxYV2NwdVNSTStwcjNqYU4vVjRXeWVNVyti?= =?utf-8?B?bm5Xa1RpVXpkNzBGOVJZOG9acnVGeHE3RnBiMGZyYzIvR2g5cVNLekFobjR2?= =?utf-8?B?bXY3QVpiVkpoUXJlaFYyM2Nma3ZQVWtjcjhaeTgxMXBYN0ZoVTBwVWpEZnJJ?= =?utf-8?B?emdlRjBKeGdlcHpsakJteGlxRDU2Wi9TMXkyeFY2YVVoT0s0SmRnSGE3ZWpT?= =?utf-8?B?L09GSDhNZk9GQ1JJSmt5Mmo0bWNZSXJaMFlIRlNISDZPK0NWRHhUZmpvYXEv?= =?utf-8?B?cDBKaDBXNmcwdk9ZNXlYa2I3MlRYUDJsZ1hTcW5RRDVrVE4rTmlDUE9LTFZj?= =?utf-8?B?Y2NQU1RzTSt2TDdjOUlFRURhMk5TUjFzY05kelJvV090dlJuMFBsK0ZnSndl?= =?utf-8?B?K3lqa0ZyZHpwajVZTWxSUTdEdTM0bWNQblJrNUYyMW56Zk9ZQXpMVXF5T1E3?= =?utf-8?B?bWxOaXFuaVUrOXpBOXg3cGZQZHZpbE4vZzFML1d6ZnZ1SVNSdDNYY3czeEhG?= =?utf-8?B?S3BQdXg3RldFU2grdlVUdE83NU0ydlczWmJ1TGZud25EdmlhZGF4bWI1OEQz?= =?utf-8?B?Q1lLYUVzVUVpRmVyc2VHT0ZiTTJhQm1pZm12Zk1jeGZSb1RUUnJzajRsRDVM?= =?utf-8?B?QmJjaHJFRlJLK0VwTThhSWFRcGY1N2tYUG1pZ1JPY1YvdHBQMG91akwvOTVE?= =?utf-8?B?My90cGRDS0VsOVh4bmx6K1VLNFk2MzBwWFZPdEEzaDRTWFVTb2VReENUWHcr?= =?utf-8?B?bGpDL2Zaai95Mk5LcGtvb3RZSGh3bXhDQ2hHMjM4bFN6MVJUUDVpUkJaMUE4?= =?utf-8?B?dVNqVXNpUU1JMEV2cllHcFRvVTFmblh4ZVhkMGRxMHpnQnN1Y081STd3QVhx?= =?utf-8?B?eE94SjVFV0ZETnp1WW5vMzh2MVRrblR1dVlkRkdYOFdwRFRsOFNUQlBuS0Nq?= =?utf-8?B?ZldHYmhUdldldHFGeHdOOUJlV2hlNXdteThUK2sraGV6V1lDc0hMUGpjWW5T?= =?utf-8?B?SGdWTnZuY0JjQ2QydDdnVUxYVUJvQkI2UDlRd2hNUzlabFBFdWtPT2t1QzlT?= =?utf-8?B?NTIrV09WZXBKNVNIZHpaOXZDVHFpemVya0RJMGlZQVlkY09GMm1iaVI0b0g2?= =?utf-8?B?clBvcUlBbGNjVkg2anNScW1IcGhIVWoxbnNLSHlDOFg5MGhaaXVrWTlGcEZq?= =?utf-8?B?dTdmWFJNMnoyRlJtdDl2UWdUOXR3Q1NoTmtURVY1UVFDYmFTWUxQTTNWOVJv?= =?utf-8?B?REt1NlFpZHBrQUh2MUIzb3V1bGwvMzlYNFN5eVU0OWowT1dBMjROR21nSzhp?= =?utf-8?B?eXdudzFLQ2ZRRjFtQnlpYzFXNkRJb0l2Z2VRV0xjRXZrZzRRTGE0TnhhRE9k?= =?utf-8?B?Y0h0cVBITGYyL0ZJY0NMdG1yc1g0N1hzaHNyVzlYbTlCT3pGeXNlS1Q1MTJj?= =?utf-8?B?NE04Y2Mrd3pzK0p3a3ZpcmpqdWpLeWQrK1RPcmNqakVCTWpYdE9ibHQ4NENE?= =?utf-8?B?a2RKVzhDSmF0emFyczFpbkZFZE5rM3BGUTJrQjl2VHRodjRMMVY0T3B6ODNM?= =?utf-8?B?UXZibXVBYU9DbndyTzhLQmxqZFhkUkkzSEJzdHExNTRmeXVPNjNVam9EMGFw?= =?utf-8?B?VnQreG5IUXVEaFBUUjYxbXBTbG9JZ1Q4WStHcHl4QUIvc2g0cU5Hc21oVnY4?= =?utf-8?B?amE2bnM0UldLdXJhMEJUNVF3K21uYTFiUGljTUdvY0VrcnAwcTJMNktUR0o3?= =?utf-8?B?RTdqVlFtSVNLMGE4MER2T3M0SWVlVllKZHhqQUdCYTh0elByRDV0Sk5OQzN4?= =?utf-8?B?L2xyQ1JiUHVRbUt6dGdtVEExMUxDaFdoWGR5L3pwNnkxcm56dCt1b1kxVHo3?= =?utf-8?B?Nzg1TjZ4dXlzY1EwOVBWbzZnSDcyd3Qzai85U0pjOWRzeFNCckJyT3VuWnp1?= =?utf-8?B?TklrckZFTW9mZmpNY2swbVExSUpoYXVaaGxUWEpGSVE4M3RwdklQZ1Z1b2Ry?= =?utf-8?B?ZzZxTzJrS2RnWEYva0VzRGZpRWlGdmMwd1FjRUZ2alo1d1NrY1VwS3VITDVD?= =?utf-8?Q?WClVO3eawjZlACepjqEGrSiAC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7d57085-96f0-47e3-8371-08db047683cc X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 17:05:26.8646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ruEzhbb4DtV4F5/5rTrFgJrvJK7mFEGTkDaVP97U3/GYrdbK3k+ASXGLoNkX8iS3oa1sIWKtrzHfCxPADtdZaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5979 Hi Julien, On 12/7/22 8:31 AM, Julien Grall wrote: > Hi Vikram, > > On 07/12/2022 06:18, Vikram Garhwal wrote: >>   Dynamic programming ops will modify the dt_host and there might be >> other >>   function which are browsing the dt_host at the same time. To avoid >> the race >>   conditions, adding rwlock for browsing the dt_host. > > Looking at the user below, it is not entirely clear what the lock is > actually protecting. For instance... Purpose of the lock was to protect the read/scanning of dt_host while we remove the add/nodes. This lock is also used when nodes are added/removed in "[XEN][RFC PATCH v4 12/16]: static int remove_nodes(const struct overlay_track *tracker)". > >> >> Signed-off-by: Vikram Garhwal >> --- >>   xen/common/device_tree.c      | 27 +++++++++++++++++++++++++++ >>   xen/include/xen/device_tree.h |  6 ++++++ >>   2 files changed, 33 insertions(+) >> >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index acf26a411d..51ee2a5edf 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -140,6 +140,8 @@ const struct dt_property *dt_find_property(const >> struct dt_device_node *np, >>       if ( !np ) >>           return NULL; >>   +    read_lock(&dt_host->lock); >> + >>       for ( pp = np->properties; pp; pp = pp->next ) >>       { >>           if ( dt_prop_cmp(pp->name, name) == 0 ) >> @@ -150,6 +152,7 @@ const struct dt_property *dt_find_property(const >> struct dt_device_node *np, >>           } >>       } >>   +    read_unlock(&dt_host->lock); >>       return pp; >>   } >>   @@ -336,11 +339,14 @@ struct dt_device_node >> *dt_find_node_by_name(struct dt_device_node *from, >>       struct dt_device_node *np; >>       struct dt_device_node *dt; >>   +    read_lock(&dt_host->lock); >> + >>       dt = from ? from->allnext : dt_host; >>       dt_for_each_device_node(dt, np) >>           if ( np->name && (dt_node_cmp(np->name, name) == 0) ) >>               break; >>   +    read_unlock(&dt_host->lock); >>       return np; > > ... I was expecting the read lock to also protect the value returned > from being freed. But this is not the case. > Okay. Shall I remove the lock from here and perhaps add it when dt_find_node_by_name() and other related functions are called? > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:21:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:21:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488361.756388 (Exim 4.92) (envelope-from ) id 1pNGna-0007Wj-Mz; Wed, 01 Feb 2023 17:21:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488361.756388; Wed, 01 Feb 2023 17:21:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGna-0007Wc-K4; Wed, 01 Feb 2023 17:21:30 +0000 Received: by outflank-mailman (input) for mailman id 488361; Wed, 01 Feb 2023 17:21:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGnZ-0007WV-U7 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:21:29 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20615.outbound.protection.outlook.com [2a01:111:f400:7eaa::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc4454f6-a254-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 18:21:27 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by CH2PR12MB4280.namprd12.prod.outlook.com (2603:10b6:610:ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 17:21:24 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%5]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 17:21:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc4454f6-a254-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2cGSR5B30bsixMo38uqQPPdVZvna43o6TopMT4vIaRaUR+BsuV+VwFy76E3yrkWNEpgJofq6S/dPhc/xjGGIq/ZOnUZI5MH6VMX2MwoJ04RNE2T4Tgw6r9yClrnfJXgZxyOOOBZARH7hADd0yGFc1fbTu6XbIgKnjkynv+sNv2qJLcnMl+Y6AiQXTWsEEI129auzK387l0QLeMNQx+H+/Jg6r5mW3iWwaOZxCeBThgWTa9tQD0EUASKtnfpz0q8dZlIZi6K0FuJjuQsADtrqHBP9/LelGYXjoBP5NYeXzsR7ZU/YtDSFFK7EahdN6/AiSiXaMYEItulAPoG1USGmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mD1OrwwWiDuw+YEwSJ75bfvbEzk3Wgg4euOqwnrY2M8=; b=Nqx8gakPXw3biSamjKI18tcd/4dfdojsFKtiS3RNJV8KAysjHhgGMG6lqlp7z9q5xkdsb4vWOg8JpgHmM9cEzIZdLrHjUMA7dDumWEJKuB0ntjfkFrVvDZI3DSPk+gcxa8J6aZOUG79lvbu4NxZ4PcOWkpKl0UwinFvPz7FzvX7bZoyau3/SGekC4j+zvofGYiVqmaPPrdJH97Rsfii/8AGimh4AXADvU8aV1UFj27xmxwcu2wELhXYWhK6tklvvFdE8qv92FOYwjQeguY+jSiNKqTMa7NaGhW+NR7xTRinH7JOb3y6k2I7PqBEVF/BXsG665PedTL4KwT1ZAvfAgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mD1OrwwWiDuw+YEwSJ75bfvbEzk3Wgg4euOqwnrY2M8=; b=obwLNqyk4v+XxLGUHdasyS3CpM5b7du0YUT3H/2Pj2JCgetWX4lQYOBx8o+Eyp2//zj5z6AOkUWkbWrhdHvxCDzEuQnYBMSIapfZPOHh0YVWz6sbrhbbwvsKdywUDg8QxzfIxHsqs7tehjALlv2D6kN9uYNjyhUQNLcEPvm3fLA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <13031ce2-6d66-104c-4a3e-d4a08883f89d@amd.com> Date: Wed, 1 Feb 2023 09:21:21 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 12/16] xen/arm: Implement device tree node removal functionalities Content-Language: en-US To: Jan Beulich Cc: sstabellini@kernel.org, julien@xen.org, Luca.Fancellu@arm.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-6-vikram.garhwal@amd.com> <786addf7-2698-5a18-26c4-b6b88bba1d67@suse.com> From: Vikram Garhwal In-Reply-To: <786addf7-2698-5a18-26c4-b6b88bba1d67@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR06CA0035.namprd06.prod.outlook.com (2603:10b6:a03:d4::48) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|CH2PR12MB4280:EE_ X-MS-Office365-Filtering-Correlation-Id: dd6c4b61-12ca-446e-9472-08db0478be6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lZTi0whffj/hx/tfE2jHTdeh5DNMx1A/8JS/tXAwNVxgK3XPd0r1cQd70R3gXWlEsD0f6rT+PUfhi4XIaZG8lPFaL6sXpmFqmM2Sv51OYY9bizwHsD6g2q2LIOOKsz57FSSGFvFhkFghYekARyPgJMrOAdUwQvMkutQJeghxVhq1YciOGM5k8NOczCtjQ36OimbMe7TxP1+EsG4fDYln89UqbGTw+J4Jo6r5wqeKWI3OZ4ZXx7cJaeIzJRuHWc4AdRR8qz88AgkQXGkbORd38X2pxqWaG7dfNdAZcewQT/IHmOFV8KC/GZ0vwWyD31v/UJue9vg58NMD93IjqZKymMuNitlppRwj8h/OmSyFoi12ummfMDEu3IEaIzxap4N0c31mfGx/Q2sMo0a+/bcs2HAT0T+lMhtGR6EOc3jJsl3bdEGfgNZmZ9R9Uvcgl8LM3oksRVwoGz36XVVkgEibOxtflAC4nOVCRoahcfAO4i5CnJ1Kk3CiB+In3aZDo2Ih22yK9eMB6wHu5oaJZAIrkjnYw5ekVSYGGCQScpz3m5utfC6TQgFIX7wr6Z7DespCAkSw6JDaVGpzVYQnBcmL7GVlnJ5blQLwv6TzykilUr+YxlqXEOqLCKgaBHbcDrfN/uojYV4wDdgxiNkhjPMXIzl/9cELL1WzLpJjwyqIFs7Guqb9Yw0V5P/S37xGt6qOhps8aq3K4ndu/4pBQCeSRNhqNHqMsrOZWlk6mPn6tc4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199018)(31696002)(31686004)(36756003)(86362001)(44832011)(5660300002)(2906002)(38100700002)(478600001)(4326008)(8676002)(54906003)(316002)(41300700001)(66476007)(6916009)(66946007)(66556008)(8936002)(83380400001)(186003)(53546011)(6506007)(6666004)(26005)(6512007)(6486002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWZiWXlKTEYxd2paeFlsU3R4VnBuZ1ZNbm1zOUhWZkJKRmhmc0taditlYnhI?= =?utf-8?B?dlVvYVJFR1Nkb0VjNXRqcStkM3IvU0tIdmkzUXZOUG9Kb2RLZDdId1dDR0w4?= =?utf-8?B?c3lFSHdrcEQ5eHFkMTRCdXZTZTlWYjltYUM3dEU0UzE2Nk5La2R6MC9pRjQ0?= =?utf-8?B?M1ZIdHdBbmU5OEhaNkFyQXRMT3dqWkgxc0dtcWNOdVlyS093a01NcVp5eUNY?= =?utf-8?B?eXRESm16VVV0dmUwNzFhU0VoOUVndzdVdkhzNy9yK2NNRnJYN29JNGRYUWlT?= =?utf-8?B?UlJrODlzWFJrMzlkblhBU1ZXOE9zNVI1QmEvRzA3VW00UTRpYmhTZEZTMExy?= =?utf-8?B?Y3BVU3c1dGU4NEhvSHp4cVhEZW00NzJ1OFFvRUlVQXAzSnFtZFkveWNtVVFv?= =?utf-8?B?ZlRKQ3pnOGtwV1d0ZWFyRXVFdWQ3WTBRVDEvSnJWeS9MLzdjUUZCWU5UQ1lo?= =?utf-8?B?MWsyYVdjNFo5RjJXZkhwc1dvWmsxUlQ3Ly9EeU9PM1gwcmJ0clhRMHlSM2Ju?= =?utf-8?B?dy9CUnhKZVhud2dMRVMrTFNiWlNuTkJGTU1TVXhTRlJmSlAxWFBvbVFMQmpS?= =?utf-8?B?UjhjNThNd1Y0NXR1eW5LUDNmSHFScDVQNkl5c05RVXhkL1duM0R2SHcwT2Fi?= =?utf-8?B?UW1wRE1JU3hrZUt5eEp1NE5SUWxGNlNqZ004cEY1OFhtZ2JnWHFRb0J1blBO?= =?utf-8?B?ekhCS0kzc1ZYUUh0VGxDMXdZNU14N3dXQUNuR25ZdW84UXpIU3lpQ2VqOXUx?= =?utf-8?B?VzVwMW5obHNTOUoxNXMwcTdlOEhrVkkxZGRvaExPQzV3MmxoS3N0UkFNWjNT?= =?utf-8?B?bFJ5bWNQbzRuakRBbkhwQWVTSzNIYnVMaXdScENhVnBWdHZWZ285UDF5Y0t4?= =?utf-8?B?cWxpL2lFam16TzF0RWFncG1WWVpyZHJNTkJJY0ZOR21HM2dxcnlIU3U1VW8z?= =?utf-8?B?SjhzL2g0TEpKeUM1dDIzRXN6RXkyRUovREJuQXNlZEpoRmlWU1hIL05SbS9j?= =?utf-8?B?ZHNoQ1FHc3Y2MEcxcHRsbHZZKy84cmFiNUY2UWlXV2k4cm1UbEhxcG04NzJK?= =?utf-8?B?dTY4dklqcnZBNHpIU2tXbTVXZ25wV29lbXpHUE9aZlZvRm9lZjI0aC9EZjZL?= =?utf-8?B?WTd1OEVYeFAwUUpPVXVtcC8raGNKVEt3aHh5TDhJaTJxZVRJaEIydHcvWm1r?= =?utf-8?B?ZVFKbVp0dXRmZ3dPSWVVRmxNeWR4amtqN3VHbnM5MitkQ1I4cmU4dWVYZ29p?= =?utf-8?B?UXpLNkJ5cnl5S0tEb2VhVUtSOUNSMlN6a0hHTXJKbCtPZ2FKSWJ5MW9HTGhj?= =?utf-8?B?VHVpNnJPVmVHZEZEdnVDT2E1ME5PKzhhZ2MreU5lWm1YUXdDSjY0UnU5VFgx?= =?utf-8?B?ckJYOXFjWmJYTm8wQWhGSCtLay9QWnhFQnl0VjlHNjBOVEdMTkNzbUNzZW40?= =?utf-8?B?SW9oaVQzRkFJWTV5R2swS3RkOGVwMFlTcmpzT2xIbTZ4Y1hGTExMYUh3cTIz?= =?utf-8?B?NVdRbng2Y3V1V0thSHZIWlByaWV4Mndad1FpNFJ2dlBwZ1BuZzdnTThyMTFr?= =?utf-8?B?dVV5ZkhrdG80Wm52RXVBU1dNYUMxYWdKMlluMGt6UlRpYWR6Q0MreStJbVM5?= =?utf-8?B?bHJrWldEbktUY0pVVXcvKzNYRlBUd1l1TVVoMDBCWEZHZUxoM1lxR3l0YXBF?= =?utf-8?B?dkhOV01JRGhpdFpwa1JWZlk1NDVhZE11aUloZTRrekl5YU12WFJNTDBIMVp4?= =?utf-8?B?c3M2R1BpRGUvRUhaazhTUUdJVE12NE9pUVBveG0zSjJXbU51VlhzSEV3SWRG?= =?utf-8?B?L1Rwc1EzcnNVN2s5aFVROWFXenV1WHppeUdrOHExRmRkTjZZRm8yVC96YjVr?= =?utf-8?B?YTdwL2NJajIxUmhqdXprNmdWbGVBODNIZlNxRGlGd3RDUFlpSXBsZlBUejBI?= =?utf-8?B?dEpuYWVNTEEySDNva2d6VmRrdDFxUk1HdUR3clVmNzc5R0Zxa1Z6OWhweGJO?= =?utf-8?B?RkJtTG9zdDA4OW9VMzdhQXd3WGJkMXl3SG1WQStidjhFZ3IyNFN1bE9nb3ZL?= =?utf-8?B?a3JrTDB4dzROaDRrbVJjSDFIV1ZOcG5mUlhrNFloNmF0WmN6U0NobVluSjFT?= =?utf-8?Q?O5ziE3RgOPylm79Xo4c2rPzxq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd6c4b61-12ca-446e-9472-08db0478be6a X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 17:21:24.2174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8vQhypn0qtGaBRCzZcnZHp4+B/Ij2cf/40mNCXtxfaRGT/iWfxWd7Ri6VXJHCwe8FSQdl64PTMQj245RAm/H0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4280 Hi Jan, On 12/7/22 12:41 AM, Jan Beulich wrote: > On 07.12.2022 07:18, Vikram Garhwal wrote: >> --- a/xen/include/public/sysctl.h >> +++ b/xen/include/public/sysctl.h >> @@ -1079,6 +1079,23 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; >> DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); >> #endif >> >> +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 >> +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 >> + >> +/* >> + * XEN_SYSCTL_dt_overlay >> + * Performs addition/removal of device tree nodes under parent node using dtbo. >> + * This does in three steps: >> + * - Adds/Removes the nodes from dt_host. >> + * - Adds/Removes IRQ permission for the nodes. >> + * - Adds/Removes MMIO accesses. >> + */ >> +struct xen_sysctl_dt_overlay { >> + XEN_GUEST_HANDLE_64(void) overlay_fdt; >> + uint32_t overlay_fdt_size; /* Overlay dtb size. */ >> + uint8_t overlay_op; /* Add or remove. */ >> +}; >> + >> struct xen_sysctl { >> uint32_t cmd; >> #define XEN_SYSCTL_readconsole 1 >> @@ -1109,6 +1126,7 @@ struct xen_sysctl { >> #define XEN_SYSCTL_livepatch_op 27 >> /* #define XEN_SYSCTL_set_parameter 28 */ >> #define XEN_SYSCTL_get_cpu_policy 29 >> +#define XEN_SYSCTL_dt_overlay 30 >> uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */ >> union { >> struct xen_sysctl_readconsole readconsole; >> @@ -1139,6 +1157,7 @@ struct xen_sysctl { >> #if defined(__i386__) || defined(__x86_64__) >> struct xen_sysctl_cpu_policy cpu_policy; >> #endif >> + struct xen_sysctl_dt_overlay dt_overlay; > For now your additions are Arm-only, aren't they? You want to use > #ifdef-ary similar to what you see in context in this last hunk then, > to avoid undue exposure. In v2 there was a comment regarding "No CONFIG_* dependencies in public headers". So, i remove the ifdef. Will add "if defined(__arm__) || defined (__aarch64__)" > > Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:21:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488363.756399 (Exim 4.92) (envelope-from ) id 1pNGo1-0007wv-UT; Wed, 01 Feb 2023 17:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488363.756399; Wed, 01 Feb 2023 17:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGo1-0007wo-Rq; Wed, 01 Feb 2023 17:21:57 +0000 Received: by outflank-mailman (input) for mailman id 488363; Wed, 01 Feb 2023 17:21:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGo0-0007wR-VI; Wed, 01 Feb 2023 17:21:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGo0-0006GA-UL; Wed, 01 Feb 2023 17:21:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGo0-0004Cf-FA; Wed, 01 Feb 2023 17:21:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNGo0-00025X-Eh; Wed, 01 Feb 2023 17:21:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gaAVbU6MRJ/aTk0Rng4hUQdiJgu8hyYietAyyyNarsc=; b=ivMdUI8Y+kbO83NoDJPHQaNYsO yv2FKX4YmMCdKCuCOCUpb6ciegCXx1f1trhJ+j+heVT/NDrjG6YCXfOodWanOKTkpbJZdklgU8MOc KM37BZuyJk70Kg4AQbaAH2xQWStBUJzOPrvzS8D/IGArITZqX+zy+dzUU+/MACCDNRFc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176315: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 17:21:56 +0000 flight 176315 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176315/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:23:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:23:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488371.756410 (Exim 4.92) (envelope-from ) id 1pNGp9-0000Aa-9Z; Wed, 01 Feb 2023 17:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488371.756410; Wed, 01 Feb 2023 17:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGp9-0000AT-5O; Wed, 01 Feb 2023 17:23:07 +0000 Received: by outflank-mailman (input) for mailman id 488371; Wed, 01 Feb 2023 17:23:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGp7-00007c-D1 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:23:05 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061d.outbound.protection.outlook.com [2a01:111:f400:fe59::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 147b78ab-a255-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 18:23:03 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by IA1PR12MB7589.namprd12.prod.outlook.com (2603:10b6:208:42b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 17:23:00 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%5]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 17:22:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 147b78ab-a255-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aadjURwlSwYvRmgmN8Vt8w9rYNvlnAYHAWjjzf0M4f4rDD/tnkHRcegt6RxbJ5z3AJAfuux/+P7GQb4yUrMkO8btu6YjZnjhvitboayctBOqh2cuF8EowDmkGnTX9WJliu5rqKC5IS8e/9v9rZsn7CN+ZUb591I3jTDl4f9ho0t1YLtdfDN796LfuL4ZuOzOY2FuPA5agaa8XJNExaudTzdTczMqkqdJEqZVIbFQo6OnU7wku/gVrw1jR73CnRNQfX2X1OqDFvF1497Awc3KIJO+daVF54NxaP0pjhjwoPwIGfXEBUi6mFC+RVy1pvrool++Zu1hHOXl+u8AxphnLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vT3+Q0FqEUI+MrO5MSmCjiNIjXIEaPuJjz3zdnfZubw=; b=EWQM8suds/988UpY2pt1GuoIWtyAntHq5bLYXusU7zQi6wApCmwg6UxKYm3mC9lCDK9Cir21KVNthzuk1iGDg21RDzsoZEsutiKdcqMiIx6R8ALysbm3NXir2ql62oZQgSvDTvYgHUCqtnwAa73yxm0Ppv4sgfLHJkEMfU2UUodco/wwk/v8gIpPANxa+yv6Jl60PzT/j79Zto9bSxkvD5K4mhs+mrX8wplA6g9NMu+5Bx2a0t3W9mNemmvxmkGwlCi8m0vurhrcZGPwk5bqEcsZ38CcphAQB9KWQH4+jEI1S3azx9Yn9TZTjzGVTMuLHWcgSe7gfKf0PjFvBWII3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vT3+Q0FqEUI+MrO5MSmCjiNIjXIEaPuJjz3zdnfZubw=; b=IeG9HbdNdCLykbh0xlkcZQyS1CgwlWf2Z+Urf4KDWT/rZVTfcN8WIUCxhdfA3nFs4MyUYJuZUshnS1998OYKHNMP+ndm6VU0qP7FipMVWG61dIstl+6SfT9EUZLvnhRaPkLxxY5/p1P0kWJAiQf5Q9iH5WOtyycaYGRy+UKsN08= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 1 Feb 2023 09:22:57 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 15/16] tools/libs/light: Implement new libxl functions for device tree overlay ops Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Luca.Fancellu@arm.com, Wei Liu , Juergen Gross References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-9-vikram.garhwal@amd.com> From: Vikram Garhwal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR06CA0017.namprd06.prod.outlook.com (2603:10b6:a03:d4::30) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|IA1PR12MB7589:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b92a1a5-35cd-4bf8-d870-08db0478f770 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PZDw5SQncV+qYa/ea1OvJKtYLT3f7iV7vmti6JUE6qkiXlbREGUqDhv+tGPE8PEHskM/lZ7IO9Qj+oRhLuIqbLGHKXTII1W/GfMJVu1Pw1eAqxuf8PlXEdfkjDMpMR+mH2kFxmaIVpkAKtsQ/+XfOE6Q4lHVN/MOcZ9s6R23vxLj/HUN34rKslxAt4EIULLnejZc62fGtiVFHC9+bVgI3SxsV89QSb1//WFatpn1EqsvxjIDvxbVgdkTSOzj8TJXbIajhuOfzq/smdf9AGp/f+BfsKmkIRVwNH2s583NYE7EQt7XByqXTgSX1Zhuhx/Dzy4iA76Ih5WlL39s07/gs0fLj+sbsL0pHelag6Bm5nadvx1ktFIQbnvzZVh+8aT1/XZDzskQjnbbCIFYgpwUrPAua+pX3L+sB8IDaHJsEzSoZjK87/d43Ey0thoY4jb05tcVGpls/fF7ILxXaGr3y/fXi0xOJf5D8PJkOLzYlpWYde4WkErX4bBY82YVFiextqmzoknWQrhGtTvcYYLNY54hRgd68o1JONu9Gl1bPSu8Ce6Kg4/ls6r3JTG+hoyo6bFA9pw2pvavNzliNHlYoGzFRynWDZTtlZAISf8ubD7lbSXEi6KrnQozUrIcWHsqVfXQeDn2y30zBGPAMyxF9/Awmmku0u1TX4OoMh7X+N2onU+merLtmDBi3c5lf5o03f8PzUmYPz+PpAkUvTCsX8yY3jbrbBjWVw14RuggU30= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199018)(41300700001)(44832011)(53546011)(8936002)(86362001)(66556008)(5660300002)(38100700002)(2616005)(66476007)(31696002)(4326008)(6916009)(6486002)(66946007)(8676002)(316002)(54906003)(478600001)(36756003)(6512007)(186003)(26005)(6506007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zlc1a2dMUHFsbTl0MEwxRkI4T3dNWm83eGJIMjN0ZEZxUDdXRXBjT3JMWGFr?= =?utf-8?B?NHNGMW5OVGZhMlFPbEdVM0Y5Q0R0VG92WTlVcXhUeVFYeWViKzVwWWJFcjNP?= =?utf-8?B?UXorbUlWRE8yYlhCSkZYR1JuaUNMUEgva3hRMldaeWw5L1BLRGh4MmQ4TE9B?= =?utf-8?B?YkNsSTYzTVMzRk8xZjdaUmZ2TDltZld5bFNESE1ReVNjNENLdXhHMGVodjlu?= =?utf-8?B?clNZN3lRcmNMRi9neENMbDY4M1BJMEs5MG51RUM1N3lOeUtxME9NQTVjUmps?= =?utf-8?B?dTJhM1J5YzFGdDZSYmIzSWhpWC9LWU9Ba2hRa2RxMytGdGROSlIyYmVxZUR2?= =?utf-8?B?Tyt5N3JVTWVNdGhITkZYcStTSis3MlNONGlpVVgxZzc1T09iMFZEcnZHTmZX?= =?utf-8?B?c3dyYTFKZVh3WmpMdHdBMGJCcmhuQVQxSmJJUGpkTHc1RGNJeU5CdktoMXFk?= =?utf-8?B?Mk1PMVd6aGQ4VUpNK2dhOG90WDFsem00Q3FCUUpTUDdLQ3lJVkVPNmdZaXhy?= =?utf-8?B?NEp1UmpDVVVlWXl4TjJiVXFhMVJuL2JOV1JuZnJDSHIzbjM3VXZSWCtjUkRX?= =?utf-8?B?bmgvcTc3NWt5SGNiQVZkUHkxb25MWUpFSWJVQVpaV0wrRC90NlF6YWdVdUs3?= =?utf-8?B?WXFrK3R5bFpQQjJLVEFxU1hpc082ZWcrOW5SZ2FoeHRMMGVHV2xUSUkxcis3?= =?utf-8?B?dXN6bnlWRWZVTHNvSzhlYW1HQU5vaVV3L2t0Q01lQTZKSkhDUUpjaFNWTVpX?= =?utf-8?B?a1dTUUZxc0FPbXJBSzJoOFlnQzR6VmhVbnlZdHR4ZjF3eVdmcmZhSVpGUzFR?= =?utf-8?B?Lzd6amVVU0ZBVkpCcGtvS3RNK3dycVZEcXlQQmhUTlJQdjdwQXZzdTBqeXk0?= =?utf-8?B?OWRmMGkrNTVXZXJUK3NHZHBFTm50d1BpUnZLS1dwdzdIWk1GUExPZ2ZZTVVt?= =?utf-8?B?VnZhaE1sU3AwRHBXaWlQUnN6SktjalhGUEczUXlDdE5zVVhqMWRid1FQZUZE?= =?utf-8?B?WG54YmpGME9JQmN0S0NuTVlDM0ZUdGVnVE8wblcweU5jemI4WThpZFp2ejFS?= =?utf-8?B?NUxmZTZkdnExYWVEWFZQMXdEWENmM3p3Sk9KR3ZPb2J3T25YWmVDK1VWYVM5?= =?utf-8?B?U1VyR3UvcmoycWFGbUc5M21KNXJkQ2lGTWZOWjlHNEFQYjBxZHNCVmVKL0Vw?= =?utf-8?B?UThwWGgvNlNlMEc1RzJudW9zTkdPSTg1cWRiU3VKRDhEdHVUQ0hOYkpjNkJR?= =?utf-8?B?dTNwMFgyck5kd2x6VDlabVh2ZFl6bzhhOFNvck9QZGoxdG92bjRMbEFZUFNr?= =?utf-8?B?UmMrdDRkUHBsYjJWb2pMbVRVNlN6ZUMwWnYwNmtqMTlNemZEZEZSdldmWkw1?= =?utf-8?B?THJDRkl0ckw0SHEvTmM4bkFFRzY1ZEhYOU1vYndnUXgrY3FMMndiSVFCV3gv?= =?utf-8?B?ZnptWjFvTGt4RGhhQzRraFZpRzVud0l1VmZydkFhd0VHSnU3NmQva05wOGdv?= =?utf-8?B?d1ZuZHFrU1MvZFBJVXIrQ1U2YUpPQVNCNnM3RjU1d3phQWZFbnllTXk4UE5z?= =?utf-8?B?TFpNMmJHZkNiNjZRM200ZnBYL2NJN3VSMVhvUXUwSXBKUUdzYmJoa09RbzFZ?= =?utf-8?B?RXdFdkRLVERoa1NIWU5mMnVXZ3lOQmRtaGdOUEQ2R2d0a3NSbVArdjVTSjBR?= =?utf-8?B?bXVzaVNFcjM2cEpvMW5jNmZjWngxb1RCeU9kcjNISUtnanMrOFVIU0VBeWNJ?= =?utf-8?B?VXBtWFFUSm9qT0xYR1JrQ1NOMlY4RjRrS2JFT2xBNEVpSzlxRld0MUwyN1hy?= =?utf-8?B?Q0d1K2VuZHZMd2RhTzFZVkpzbkpvL3YxZTZSSzljdWxBNWdBZDU1N3lheDcy?= =?utf-8?B?TEY3RVJQSkgzMkg0YTBJOGRESWhrd2dzYWhUNmc4NmxIUVZrT0tQRm5UcmhS?= =?utf-8?B?LysvV3FuakR0VHpvdmI2a29Ldi9KZWJXQlA4VzhUdXFHNnZSNXQ0TUcvVTJs?= =?utf-8?B?U3dSZmx0WHpQc0kyZTVPcWgrSVdLc3F0T0ZIV2FqYXZvYWZhRkJQY0xmNDg0?= =?utf-8?B?NWJqakpoNG9MRVpVQUtvSkVDUUhObktoanBrQ2xjajRkeTMxenMvM0xDcVBQ?= =?utf-8?Q?p08/kPfbixCKjEGsmM2Ss7/3z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b92a1a5-35cd-4bf8-d870-08db0478f770 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 17:22:59.8401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HCQ3ZbuzLfrGLRmXbq9E/OxgfoAy9kXHvTxhNbidW7h1FBvFIEl/HfEnFmPySyw7EzRw9+hwpbGT3Yd/gkku5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7589 Hi Anthony, On 12/9/22 8:59 AM, Anthony PERARD wrote: > On Tue, Dec 06, 2022 at 10:18:14PM -0800, Vikram Garhwal wrote: >> diff --git a/tools/include/libxl.h b/tools/include/libxl.h >> index 2321a648a5..82fc7ce6b9 100644 >> --- a/tools/include/libxl.h >> +++ b/tools/include/libxl.h >> @@ -245,6 +245,11 @@ >> */ >> #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1 >> >> +/** >> + * This means Device Tree Overlay is supported. >> + */ >> +#define LIBXL_HAVE_DT_OVERLAY 1 >> + >> /* >> * libxl_domain_build_info has device_model_user to specify the user to >> * run the device model with. See docs/misc/qemu-deprivilege.txt. >> @@ -2448,6 +2453,9 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, uint32_t domid, >> int *num); >> void libxl_device_pci_list_free(libxl_device_pci* list, int num); >> >> +int libxl_dt_overlay(libxl_ctx *ctx, void *overlay, >> + uint32_t overlay_size, uint8_t overlay_op); >> + > Could you guard both the LIBXL_HAVE_* macro and this prototype with "#if > arm"? Since the dt_overlay operation to libxl built on arm. Will do this in v5 > >> /* >> * Turns the current process into a backend device service daemon >> * for a driver domain. >> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile >> index 374be1cfab..2fde58246e 100644 >> --- a/tools/libs/light/Makefile >> +++ b/tools/libs/light/Makefile >> @@ -111,6 +111,9 @@ OBJS-y += _libxl_types.o >> OBJS-y += libxl_flask.o >> OBJS-y += _libxl_types_internal.o >> >> +# Device tree overlay is enabled only for ARM architecture. >> +OBJS-$(CONFIG_ARM) += libxl_dt_overlay.o >> + >> ifeq ($(CONFIG_LIBNL),y) >> CFLAGS_LIBXL += $(LIBNL3_CFLAGS) >> endif >> diff --git a/tools/libs/light/libxl_dt_overlay.c b/tools/libs/light/libxl_dt_overlay.c >> new file mode 100644 >> index 0000000000..38cab880a0 >> --- /dev/null >> +++ b/tools/libs/light/libxl_dt_overlay.c >> +#include "libxl_osdeps.h" /* must come before any other headers */ >> +#include "libxl_internal.h" >> +#include >> +#include >> +#include > Don't you need just xenctrl.h and not xenguest.h? (They both already are > libxl_internal.h so I'm not sure if xenguest.h is needed., but > xc_dt_overlay() is in xenctrl.h) Thanks for spotting this. I will remove xenguest.h > > Thanks, > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:24:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488377.756421 (Exim 4.92) (envelope-from ) id 1pNGqA-0000pB-O0; Wed, 01 Feb 2023 17:24:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488377.756421; Wed, 01 Feb 2023 17:24:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGqA-0000p4-Jl; Wed, 01 Feb 2023 17:24:10 +0000 Received: by outflank-mailman (input) for mailman id 488377; Wed, 01 Feb 2023 17:24:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGq9-0000oy-2K for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:24:09 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061c.outbound.protection.outlook.com [2a01:111:f400:7e88::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a7d7f8a-a255-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 18:24:06 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by SA0PR12MB4381.namprd12.prod.outlook.com (2603:10b6:806:70::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 17:24:03 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%5]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 17:24:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a7d7f8a-a255-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eGSW8OWujuZuGjZcsqsXLG0eUR/hLu8bvGEbQN/Buo+/mrNMXVTkdM1dZbmtg6s1zOqEBV6iO4XCuRmrCxNkGGiNhl5tILGdwsmbKVY0Mjo4sj9Z9ovzMUg8MrNDWvOlg+5eRwsw8pSGVDlgMu4fj/giElSGrMrLP2vjxYpF9mLRjUPxKejY6xkBU4s4aK31Qc48msfTO+yBuAiyq5+DX+WS8lvwzZF+RcV21AmBsMVMmznKs26F0BTzxUkgt5Uxv0xS8mn94KbwvVN1cs58Hut7g58mBapVUVpWlNSlDRwFlMxCTHrDD6srNkqSB9VZRLeSmooOeUQYywqouqQyWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OexwS3EpqzFx25dS57WVA010nSmNvsdKxI61GuOTzQg=; b=InrT+1M84HNstYAFzufkW1F9RsdX+R2MiHuBR4Z8nRzz010QmR6RMpzfa34O7B+ylE/YCei/xq3FxOj+OZsRz1Wovf4aCJ47/S7jRzFKUdvJVzlTTnXlA/6zwubsrQqxjWNxCFpjczCNGfOpsJPOps+eJi8ML8GEgB1BRIyANmQWbDuS7ULyAoWwTUyLcei/vwFD38Cs/d8ciarC+P8bhE7AwAfySNMifjFJBKJXjNzpZuE3/Q88z4FHHhAh5R6JM8myyyN+jH7fsTIpacDFAeHFE+gU2q4M/JBoLrSFtcUqUd9S0EmjtjsUeHGHT8e8eTrGkm5mfNlXREL6dZfl6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OexwS3EpqzFx25dS57WVA010nSmNvsdKxI61GuOTzQg=; b=rYSKEMWpb8NKXZKUoWYzlDTNIpttq9rHBXdpvW5T6CR76Mo4PejsIfHXYNYoVHEfsO3ZHf7cbXEDvr6txjLsx9t98+BaOyfxRRKzHas0+3fKAQG4W35QCupm+4yFwNiXaoeHqBmpLmhVk1RMzKoEdrGsK2qU9s5jY82XOIDW7o0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <2f6df3dc-acdb-3625-5724-4e61da99270f@amd.com> Date: Wed, 1 Feb 2023 09:24:01 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 16/16] tools/xl: Add new xl command overlay for device tree overlay support Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Luca.Fancellu@arm.com, Wei Liu References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-10-vikram.garhwal@amd.com> From: Vikram Garhwal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0160.namprd03.prod.outlook.com (2603:10b6:a03:338::15) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|SA0PR12MB4381:EE_ X-MS-Office365-Filtering-Correlation-Id: bfd26ae1-54e9-4679-5651-08db04791d84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Viw+BU3U38Q1aW9JcN2JBpaE6y+GPFzwMLrkhZTa8P7NdQZ8DkQxcX7z4xIt8X3DDywr0Dp+GqPcFTSHB2dtsu1WlpPGgbwy7md8U/bl2oEJILIBfu3/1hX3hx3jpzNgNFbI9bZmCpwZqITDPaPSjVNH1xlsxs3Rbe12h309ZFjLkR55rDFsdSSv/Tqm8VKNlW5OXSoMoy5OU+z3LjdmyBnhZrJCKzWTp7EngnKNGkRVQNgFSV3LqMn1oZXzLl59tZ+MwekC7FnRIza2JIAh+P8Kyd1Pk7GK8hEyMIcd2dPrxcIsV9nLx+tTS3MRYYCyE+7YkeZxldnPdNZKlu+2c0SOkpDgghgrR1J6B4LLerESiHVofxeLwZs7RsqCLZ2P2h4uf6qx867fF8oDSaPOPVqJ+DKrnO3t1hzgnt0ISqP+oYJqfMGC6BODP01CAhbvBWzjvwtrteDKvz2o9IqOdEGQax0zi4SZpx7p5Sfc/+BSErAqNBfyssclRRgwE7uHPayKMJYC95wDTL1kUvy7h0Jpkbc42cE2lB4svVedeOPzSZzIE38CzY/PmHjJa2lc1Pb893WSrbfCaRTFKSlAunqwZSuSFXwCFQ/gFKmxotO05PXFWZkjWHkBTs6ExVmI+pY3NPzADM5pW8Z09LTyH7F8C28IJU+xtCBPV4yGxsL8zbhVrSBJ9FVlnU0Gy/HDzJeFiA+/oaMVBj+5dPgMvVyLOUXLHcmKB2TB59THi8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199018)(5660300002)(31686004)(44832011)(41300700001)(8936002)(66556008)(66476007)(6916009)(4326008)(31696002)(66946007)(8676002)(478600001)(6512007)(26005)(36756003)(53546011)(6506007)(186003)(83380400001)(2616005)(2906002)(38100700002)(86362001)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnplaTJ2aHJlcVZOa0R3WUNCTlpoaWI1WXA3dkppODRwVDNOM2p6STVYQ2JW?= =?utf-8?B?SElMVGZnSkhUbjBEY1FLTHhOTzF6RHlIbGQ2cVh5MWtOVWJXUXZ0MW85QVFh?= =?utf-8?B?S0VyanZPUzVTcmpwMXJDYUhHbzhmb1d0VWY2blhZcGROVzM4NWc3TkxDc3E4?= =?utf-8?B?NEVuOTlDV2V1MC9DblNpeWtzeFFrTDdycUpYQUVSdW5Ob3NBVlpNZlJDRUN6?= =?utf-8?B?SkFRS29oY1hvNXlSNXl0N0RVZUN1bkxFbHVleWk5REZRcG5Kd1pDRXBic1Yw?= =?utf-8?B?bFdSMloxdGYrdWNGbm45WGRybnlHc1BSekpiWDk1ZWt2cjhJVS95WFZnNHM4?= =?utf-8?B?UFc4QUI1c0ZvZ1FTQkdZcGw4ZjlnVjJuL01hRE5RMm03NzZjZ1ZGcUtkTTVO?= =?utf-8?B?WXhTRzZaYml5Wk91THlyR3gwOTlueXltWDBzYTRwYVNIK1FEbm1QRVZVTVpM?= =?utf-8?B?dTkzZkU3dG9BcUFNSWNabEtndVFSa2c2Nm1GMUtPSWhYMmMxMkJMOWd0NmI3?= =?utf-8?B?bUhiYW9lRzlIUFJWNDZpUmdIalpMeERZbkU5LzdkR3kxWTJsUEhGVHk2am1m?= =?utf-8?B?Sjh0ci9ITE5OVklaODlSMGowWXRrVGdxNjhzdDdMenZuTk5xOXNIMlp3ZE9n?= =?utf-8?B?aVhaWGVxWU5iSVV1cEZCdEVRRlA5eGpKOUhBaVNDTG41VktvLzU3Z1p1S1FI?= =?utf-8?B?V2p0NzJnWnFlMStQU3pTeUtlMTRFTDc1L0N3YUVLamg5YmY0VXNsNWdGUWRT?= =?utf-8?B?UFVISE12Snk2ZFhOUVdYS2FYU0E2VW02UXpyWlkwMXBLVmY5Vys0YTVrenVu?= =?utf-8?B?YlpPSlNuQzBoLzVZOVJhNGM0M2xMZkFTRzMvMGV0akVnTElyRjBxVjhGblNO?= =?utf-8?B?bWVPYmxuSjhQYldibjd3U3dlVVVnRTA4MGFuRU9wNkdZZmNoUHBGYkd3dHB3?= =?utf-8?B?Q1pUWEF4OGM0VUkwVFRIV21CNVFRQU9vaXpLdXdlb29PQlBxdE8wZUJxRW9m?= =?utf-8?B?eDFLZVNYNDcvK2hlQnhyWDRnWWpqM1l1RXo4VXdKaU8raHBpSXF1ckdBa0k4?= =?utf-8?B?M1JKUktRUEs3UVZMQnlPMG00VG9YdmVkMHl2M0Qxd2xTSjZwaGtXZ1pYSndm?= =?utf-8?B?V2lEclNHaWkzd25xTEhYUVZQZ1NUVXNRSFY5cldyOW03aUxndzd6Rm5QUUt2?= =?utf-8?B?bjcxZXhTcnhKdFJkVEtEaHVoZHdvc2NENERVRFJMbTdiaXEwcnJVVmZTa0VG?= =?utf-8?B?SWd3QVR4eGdLQXR5V3pMeFd4RWpuUUxmQnIzaXE3UlNHNzRmcWZiV2Zybity?= =?utf-8?B?OFU5VUdrb2FvS25nNGFWMGg5SE9TMFJlQUo4RktrU0ZxNXJNbzg5NFV2Vk9y?= =?utf-8?B?VHVld1ppTnNiMzllY3pKT3RxNmVmS2ovY3psbWhhVXByRjZFSUpLVmQxRXVF?= =?utf-8?B?SWtRa2pMemZqdzQzN01CSTNEN1o0cDNWcGUzdVFTZHlIMVlIVmF6R3FldlVD?= =?utf-8?B?WmdnbHE2NkpsKzZIU0ttMDh1KzZONnl6ZlZpeVJPZU13UUxwTkEvMklkNHFO?= =?utf-8?B?UHhqc3p1d2JHcHBjQmhxcC84aTE1UmlTVmJ3dU85cGZwb201ZnlnUC80dlJk?= =?utf-8?B?Ri9JSlBGc0pRanNVakg0TzNmdmM2SGl2QWhveHB4WGxlYkFGb292Y1N1Ry9C?= =?utf-8?B?NE9EWFB4ZmZVZ2syZnphY0thVHl3ZmJhNVhnWmRIZTJSZ2xxQ2xDU1hjTTFJ?= =?utf-8?B?YTBMcndMM0RPL0NVUFF0Mi9kK3ZpZ3Z0MmNWdGc2M0l0U0VYQ2dzbG9ZbFR4?= =?utf-8?B?NkJZWmRseEkzSUcrcldORnRzamxYKy9qRXEwUld0VnRFcEplYmgrWDdsR25V?= =?utf-8?B?VUI1YXd5Wi9CVXJobVlVaDFNTkY3YngrcHdKUjZhQXBhNDVqVkU2bzRiaTgy?= =?utf-8?B?M1h0c1UyWWh1TVJCWERhM1Z5UWZtb3BUSXE0V3pYNkpLc1p5RWw4SlJQb2xa?= =?utf-8?B?em9hSDNTT1cvRWJMeFpoeVpzYy9aZFVXaXo5MDFaVnJQTGNMRXI2eGIxS01m?= =?utf-8?B?UHMzTVh6SnZLbTh2cTFjNC9nV3J4ZkNvWXFiUm5RRjdOdmNpbkdXUUJPQ3c2?= =?utf-8?Q?1Jsb+6KJOcPukEhY5WzT9NsR/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfd26ae1-54e9-4679-5651-08db04791d84 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 17:24:03.7385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6FTMpZ3k09d6DhdECWmrqvssmJkSMXI517qfHsAZiU+pnOtCC8bMwPHHciBaAfpINjvOLXhqZU1fQ+XwXcBIMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4381 Hi Anthony, On 12/9/22 9:55 AM, Anthony PERARD wrote: > On Tue, Dec 06, 2022 at 10:18:15PM -0800, Vikram Garhwal wrote: >> diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c >> index 35182ca196..868364c58d 100644 >> --- a/tools/xl/xl_cmdtable.c >> +++ b/tools/xl/xl_cmdtable.c >> @@ -630,6 +630,12 @@ const struct cmd_spec cmd_table[] = { >> "Issue a qemu monitor command to the device model of a domain", >> " ", >> }, >> + { "dt_overlay", > Command with multiple words are using '-' instead of '_', could you > rename the command to "dt-overlay"? understood. > >> + &main_dt_overlay, 0, 1, >> + "Add/Remove a device tree overlay", >> + "add/remove <.dtbo>" >> + "-h print this help\n" >> + }, >> }; >> >> const int cmdtable_len = ARRAY_SIZE(cmd_table); >> diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c >> index 5518c78dc6..b5f04e2741 100644 >> --- a/tools/xl/xl_vmcontrol.c >> +++ b/tools/xl/xl_vmcontrol.c >> @@ -1265,6 +1265,54 @@ int main_create(int argc, char **argv) >> return 0; >> } >> >> +int main_dt_overlay(int argc, char **argv) >> +{ >> + const char *overlay_ops = NULL; >> + const char *overlay_config_file = NULL; >> + void *overlay_dtb = NULL; >> + int rc; >> + uint8_t op; >> + int overlay_dtb_size = 0; >> + const int overlay_add_op = 1; >> + const int overlay_remove_op = 2; >> + >> + if (argc < 2) { >> + help("dt_overlay"); >> + return EXIT_FAILURE; >> + } >> + >> + overlay_ops = argv[1]; >> + overlay_config_file = argv[2]; >> + >> + if (strcmp(overlay_ops, "add") == 0) >> + op = overlay_add_op; >> + else if (strcmp(overlay_ops, "remove") == 0) >> + op = overlay_remove_op; >> + else { >> + fprintf(stderr, "Invalid dt overlay operation\n"); >> + return ERROR_FAIL; > ERROR_FAIL isn't really a value to be used when exiting the programme, > it's value is -3. It's from libxl API. > > Instead, could you return EXIT_FAILURE? Will address this in next version. >> + } >> + >> + if (overlay_config_file) { >> + rc = libxl_read_file_contents(ctx, overlay_config_file, >> + &overlay_dtb, &overlay_dtb_size); >> + >> + if (rc) { >> + fprintf(stderr, "failed to read the overlay device tree file %s\n", >> + overlay_config_file); >> + free(overlay_dtb); >> + return ERROR_FAIL; >> + } >> + } else { >> + fprintf(stderr, "overlay dtbo file not provided\n"); >> + return ERROR_FAIL; >> + } >> + >> + rc = libxl_dt_overlay(ctx, overlay_dtb, overlay_dtb_size, op); > Value returned by libxl_*() are going to be negative when there's an > error, so not something to be return by main(). Could you check if > there's an error and return EXIT_FAILURE instead? Okay. >> + free(overlay_dtb); >> + return rc; >> +} > Thanks, > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:34:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:34:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488382.756431 (Exim 4.92) (envelope-from ) id 1pNGzn-0002hj-Jx; Wed, 01 Feb 2023 17:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488382.756431; Wed, 01 Feb 2023 17:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGzn-0002hc-HE; Wed, 01 Feb 2023 17:34:07 +0000 Received: by outflank-mailman (input) for mailman id 488382; Wed, 01 Feb 2023 17:34:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNGzl-0002hW-Vq for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:34:06 +0000 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [2607:f8b0:4864:20::42c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9daa0f9c-a256-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 18:34:02 +0100 (CET) Received: by mail-pf1-x42c.google.com with SMTP id a184so13118073pfa.9 for ; Wed, 01 Feb 2023 09:34:02 -0800 (PST) Received: from localhost (c-73-164-155-12.hsd1.wa.comcast.net. [73.164.155.12]) by smtp.gmail.com with ESMTPSA id k81-20020a628454000000b00589a7824703sm11777283pfd.194.2023.02.01.09.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 09:33:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9daa0f9c-a256-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2hmwrUgUOIbjgvFn8W+IluO6qX/UXyIsHKI+wzMRXgg=; b=U9ZjveU9+peSh8EQCXwF2AHmHoS6Un9vWLs8lReKU/0kGU/mNenp5pUgy7TRvbNebB UiNAMboijyauBoIOvzS9PQyzTJoDfgiZaTFjlpT+YToDglGdMgHTST0tTvt4rl48wG25 v2vyThYls+IwQUmbDAQ8FYI/CzUQ4pDB6a7U9MHU+6o4htIWTFu/7yeNf9s7WhbGqZ34 QpuJlUBD20PjYJlVxjHCu0+FU43Ofu4oKsfTbJFkCdPUANpeO1VkhQDtf725AO1ViQKB 2kO+DLll2egLhDUC9e2H20xQ/6qgZBv138uaj5TGjgQSsohJ8hIO6J2rT5FMn037VSXB Ay3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2hmwrUgUOIbjgvFn8W+IluO6qX/UXyIsHKI+wzMRXgg=; b=bu6Rji0nyTJUHVfx/qFalIJAa+1dkmwMgLBDUqZXRnXKv2mxotUJQyaJBv+t5d+YXS FlHJSgN4xnTE0yVkWSNeFl9C5fGqLQKSNVuCDpqhXhZoay43NzrWX4kMcLVTRno52EaV GW9zh7RWa1uC72Ghk/2jPpnv+pydbLslA6ystDjgP+tHCL2cPXfQY1dDGr+fvrbzfUgb B4eHPytCelBRekAjtlFDPEcwzyBiKPjtTIOQNoRIr5kYDIQ4lBoLHgACDS6xj6ZCO+w9 qWu8PbdTBTfX4pTUAj5ur/fezI1sAmB+lII+a50r1fRZ0uzlHwLHkUJIje7pVmRPpP3z gdKQ== X-Gm-Message-State: AO0yUKWjkCXjUnW13m4EdsHsGAIYgl0DRvq+aN+mfIqWVp2q/O4B1LSb /SLePmKVjlvm2NDB2rKCeHM= X-Google-Smtp-Source: AK7set9QVGlj7ScO2rzN3XQJ0Wjt5oaaNjxzcbyA8EaCvKipqHYHSsHwEHMVK5Jmp3pOiQ8iCvJnsQ== X-Received: by 2002:a62:d0c1:0:b0:593:e6d9:d4c0 with SMTP id p184-20020a62d0c1000000b00593e6d9d4c0mr3203892pfg.32.1675272840635; Wed, 01 Feb 2023 09:34:00 -0800 (PST) Date: Wed, 1 Feb 2023 17:33:59 +0000 From: Bobby Eshleman To: Julien Grall Cc: Andrew Cooper , Alistair Francis , Oleksii , xen-devel@lists.xenproject.org, Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff Message-ID: References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> On Wed, Feb 01, 2023 at 09:06:21AM +0000, Julien Grall wrote: > Hi Andrew, > > On 01/02/2023 00:21, Andrew Cooper wrote: > > On 31/01/2023 11:17 pm, Alistair Francis wrote: > > > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: > > > > On 31/01/2023 11:44, Alistair Francis wrote: > > > > > On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > > > > > > > > > From my understanding, on RISC-V, the use of PC-relative address is > > > > only guaranteed with medany. So if you were going to change the cmodel > > > > (Andrew suggested you would), then early_*() may end up to be broken. > > > > > > > > This check serve as a documentation of the assumption and also help the > > > > developer any change in the model and take the appropriate action to > > > > remediate it. > > > > > > > > > I think this is safe to remove. > > > > Based on what I wrote above, do you still think this is safe? > > > With that in mind it's probably worth leaving in then. Maybe the > > > comment should be updated to make it explicit why we want this check > > > (I find the current comment not very helpful). > > > > The presence of this check pre-supposes that Xen will always relocate > > itself, and this simply not true. XIP for example typically does not > > > > Furthermore it's not checking the property wanted. The way C is > > compiled has no bearing on what relocation head.S uses to call it. > > I think we are still cross-talking each other because this is not my point. > I am not sure how to explain differently... > > This check is not about how head.S call early_*() but making sure the C > function can be executed with the MMU off. In which case, you will likely > have VA != PA. > > In theory head.S could apply some relocations before hand, but it may be too > complicated to do it before calling early_*(). > > > > > It is a given that we compile the hypervisor with a consistent code > > model, meaning that the properly actually making the check do what is > > wanted is also the property that means it is not needed in the first place. > > See above. > > > > > This check is literally not worth the bytes it's taking up on disk, and > > not worth the added compiler time, nor the wasted time of whoever comes > > to support something like XIP in the future finds it to be in the way. > > Xen as a whole will really genuinely function as intended in models > > other than medany, and it demonstrates a misunderstanding of the topic > > to put in such a check to begin with. > > Then enlight me :). So far it looks more like you are not understanding my > point: I am talking about C function call with MMU off (e.g. VA != PA) and > you are talking about Xen as a whole. > > I guess the only way to really know is to implement a different model. At > which point there are three possible outcome: > 1) We had the compiler check, it fired and the developper will take action > to fix it (if needed). > 2) We have no compiler check, the developper knew what to do it and fixed > it. > 3) We have no compiler check, the developper where not aware of the > problem and we will waste time. > I tend to favor the check because outcome #1 is so desirable, and I do think that checking for medany is sufficient for the bulk of future work. But that said, I do see Andrew's point now. If Xen were to a) not relocate itself, b) be executed under the 2GB range, c) be compiled under medlow, and d) the MMU is off or on but Xen is identity mapped, then C functions should still be safe to call in early boot. Checking medany does protect developers from accidental bad configuration now, but it is a somewhat imperfect proxy. One alternative that may be more long term is for the self relocation code to be Kconfig-able and to require/force medany. Anyone wanting to develop something like XIP could deselect relocation, which would allow them to use medlow if they wanted/needed. The early C functions would still be callable under both in this case. The help strings could offer explanation too. Thanks, Bobby > Even if you disagree with the check, then I think 1 is still the best > because it would explain our assumption. Yes it may waste a few minutes to > the developer switching the model. But that probably nothing compare to the > time you could waste if you don't notice it. > > Anyway, Alistair has now all the information to take an informative > decision. > > Cheers, > > -- > Julien Grall > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 17:40:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 17:40:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488386.756443 (Exim 4.92) (envelope-from ) id 1pNH5m-0004U5-AY; Wed, 01 Feb 2023 17:40:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488386.756443; Wed, 01 Feb 2023 17:40:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNH5m-0004Ty-5t; Wed, 01 Feb 2023 17:40:18 +0000 Received: by outflank-mailman (input) for mailman id 488386; Wed, 01 Feb 2023 17:40:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNH5l-0004Ts-Cf for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 17:40:17 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7b36fc91-a257-11ed-b63b-5f92e7d2e73a; Wed, 01 Feb 2023 18:40:13 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id q19so8543832edd.2 for ; Wed, 01 Feb 2023 09:40:13 -0800 (PST) Received: from pc-879.home (83.29.153.188.ipv4.supernova.orange.pl. [83.29.153.188]) by smtp.gmail.com with ESMTPSA id l15-20020a1709066b8f00b00886faa3d569sm5975586ejr.58.2023.02.01.09.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 09:40:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b36fc91-a257-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qxlgy+K9IFZtcWWXRrEqrrLEcHZBvcbfbri0YPA3hLQ=; b=nt82oSHl/qXQ0D0wPaiLQvvfyhh2coXVDt7nTounhAQ/oFmu/6PdEbD4sAN/2McQ+N obR7SMxl2hzJTvYsrLRuA8YzhN+ykdtZV5cQGkVICROKj2M4HrANquiFqvGh0TyLWRGz 9gIwT2ZQRNGuAXc3XoJMPz91+Po3KLVAs0Uh87BzmQMy9bp+TxrBwsO1lU5xpuv/59lB 8CmiNHjjgZLEaczfxz1xT0FqSzZKDRBJhptWIwinr8X7fQ6ozgDkkpjCdWLZGeOfITsL Mqwb1sTWUc7x5HYefv9zoxV0ZdQqn1lz+vGGOk4CubFOZrg1ATVhyyporTVrvM75PigC /rwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qxlgy+K9IFZtcWWXRrEqrrLEcHZBvcbfbri0YPA3hLQ=; b=pc1q1mioLKCHxG2d1Y1VXguWVJekrTjsbVhHibpceiFfqfcyveGxFTFnRj/6AOnYfx /9wt5V5yijSmZ23FBYlvT+lDhEev33oT7YBjJ1faVNdeEsjPn7VNpY/fNGwaOcAJ548H ZGIab7JO3giMMlqvCZC7I8uHiWmb81Uhp0IHxrkEvd1YW3lcsko8JiuQqCE2aonGPGMS PUoDO+Dkexd38jYa0BhH+StvzEfXhWmKpw6Ezb//crnsrPPcEM10j0vRJ3U9JMUVr48d i85fziwpz+7FMCnBHcak85++hkwifQ2J5ENtIgvv02EZGmCtRHqWcNIzwJGBlNxLI2tm C4pQ== X-Gm-Message-State: AO0yUKVYPFquhGBjoLt/Cblp4VvVdgQzJEXoIo3MCGcvxdJFYc7k4B4b SwdgUlReFwciK9SznCgrjbs= X-Google-Smtp-Source: AK7set/kTW0IAZdCDT/QGVJQRp03sMZVKUSmzDO8mlU+1E5fd6Ct5c18tAG+L0RxPlntWEgdvS1akQ== X-Received: by 2002:aa7:c551:0:b0:48b:c8de:9d1a with SMTP id s17-20020aa7c551000000b0048bc8de9d1amr3080912edr.37.1675273212788; Wed, 01 Feb 2023 09:40:12 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Wed, 01 Feb 2023 19:40:11 +0200 In-Reply-To: <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGkgSnVsaWVuLAoKT24gTW9uLCAyMDIzLTAxLTMwIGF0IDIyOjI4ICswMDAwLCBKdWxpZW4gR3Jh bGwgd3JvdGU6Cj4gSGkgT2xla3NpaSwKPiAKPiBPbiAzMC8wMS8yMDIzIDExOjM1LCBPbGVrc2lp IHdyb3RlOgo+ID4gSGkgSnVsaWVuLAo+ID4gT24gRnJpLCAyMDIzLTAxLTI3IGF0IDE2OjAyICsw MDAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gPiA+IEhpIE9sZWtzaWksCj4gPiA+IAo+ID4gPiBP biAyNy8wMS8yMDIzIDEzOjU5LCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ID4gPiA+IFRoZSBw YXRjaCBpbnRyb2R1Y2VzIG1hY3JvczogQlVHKCksIFdBUk4oKSwgcnVuX2luX2V4Y2VwdGlvbigp LAo+ID4gPiA+IGFzc2VydF9mYWlsZWQuCj4gPiA+ID4gCj4gPiA+ID4gVGhlIGltcGxlbWVudGF0 aW9uIHVzZXMgImVicmVhayIgaW5zdHJ1Y3Rpb24gaW4gY29tYmluYXRpb24KPiA+ID4gPiB3aXRo Cj4gPiA+ID4gZGlmZnJlbnQgYnVnIGZyYW1lIHRhYmxlcyAoZm9yIGVhY2ggdHlwZSkgd2hpY2gg Y29udGFpbnMgdXNlZnVsCj4gPiA+ID4gaW5mb3JtYXRpb24uCj4gPiA+ID4gCj4gPiA+ID4gU2ln bmVkLW9mZi1ieTogT2xla3NpaSBLdXJvY2hrbyA8b2xla3NpaS5rdXJvY2hrb0BnbWFpbC5jb20+ Cj4gPiA+ID4gLS0tCj4gPiA+ID4gQ2hhbmdlczoKPiA+ID4gPiDCoMKgwqAgLSBSZW1vdmUgX18g aW4gZGVmaW5lIG5hbWluZ3MKPiA+ID4gPiDCoMKgwqAgLSBVcGRhdGUgcnVuX2luX2V4Y2VwdGlv bl9oYW5kbGVyKCkgd2l0aAo+ID4gPiA+IMKgwqDCoMKgwqAgcmVnaXN0ZXIgdm9pZCAqZm5fIGFz bShfX3N0cmluZ2lmeShCVUdfRk5fUkVHKSkgPSAoZm4pOwo+ID4gPiA+IMKgwqDCoCAtIFJlbW92 ZSBidWdfaW5zdHJfdCB0eXBlIGFuZCBjaGFuZ2UgaXQncyB1c2FnZSB0byB1aW50MzJfdAo+ID4g PiA+IC0tLQo+ID4gPiA+IMKgwqAgeGVuL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vYnVnLmggfCAx MTgKPiA+ID4gPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ID4gwqDCoCB4ZW4v YXJjaC9yaXNjdi90cmFwcy5jwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAxMjgKPiA+ID4gPiArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ID4gwqDCoCB4ZW4vYXJjaC9yaXNjdi94 ZW4ubGRzLlPCoMKgwqDCoMKgwqDCoMKgIHzCoCAxMCArKysKPiA+ID4gPiDCoMKgIDMgZmlsZXMg Y2hhbmdlZCwgMjU2IGluc2VydGlvbnMoKykKPiA+ID4gPiDCoMKgIGNyZWF0ZSBtb2RlIDEwMDY0 NCB4ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+IAo+ID4gPiA+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+IGIveGVuL2Fy Y2gvcmlzY3YvaW5jbHVkZS9hc20vYnVnLmgKPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ ID4gPiA+IGluZGV4IDAwMDAwMDAwMDAuLjRiMTVkOGViYTYKPiA+ID4gPiAtLS0gL2Rldi9udWxs Cj4gPiA+ID4gKysrIGIveGVuL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vYnVnLmgKPiA+ID4gPiBA QCAtMCwwICsxLDExOCBAQAo+ID4gPiA+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BM LTIuMCAqLwo+ID4gPiA+ICsvKgo+ID4gPiA+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTIgUmVnZW50 cyBvZiB0aGUgVW5pdmVyc2l0eSBvZiBDYWxpZm9ybmlhCj4gPiA+ID4gKyAqIENvcHlyaWdodCAo QykgMjAyMS0yMDIzIFZhdGVzCj4gPiA+IAo+ID4gPiBJIGhhdmUgdG8gcXVlc3Rpb24gdGhlIHR3 byBjb3B5cmlnaHRzIGhlcmUgZ2l2ZW4gdGhhdCB0aGUKPiA+ID4gbWFqb3JpdHkgb2YKPiA+ID4g dGhlIGNvZGUgc2VlbXMgdG8gYmUgdGFrZW4gZnJvbSB0aGUgYXJtIGltcGxlbWVudGF0aW9uIChz ZWUKPiA+ID4gYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVnLmgpLgo+ID4gPiAKPiA+ID4gV2l0aCB0 aGF0IHNhaWQsIHdlIHNob3VsZCBjb25zb2xpZGF0ZSB0aGUgY29kZSByYXRoZXIgdGhhbgo+ID4g PiBkdXBsaWNhdGluZwo+ID4gPiBpdCBvbiBldmVyeSBhcmNoaXRlY3R1cmUuCj4gPiA+IAo+ID4g Q29weXJpZ2h0cyBzaG91bGQgYmUgcmVtb3ZlZC4gVGhleSB3ZXJlIHRha2VuIGZyb20gdGhlIHBy ZXZpb3VzCj4gPiBpbXBsZW1lbnRhdGlvbiBvZiBidWcuaCBmb3IgUklTQy1WIHNvIEkganVzdCBm b3Jnb3QgdG8gcmVtb3ZlIHRoZW0uCj4gPiAKPiA+IEl0IGxvb2tzIGxpa2Ugd2Ugc2hvdWxkIGhh dmUgY29tbW9uIGJ1Zy5oIGZvciBBUk0gYW5kIFJJU0NWIGJ1dCBJCj4gPiBhbQo+ID4gbm90IHN1 cmUgdGhhdCBJIGtub3cgaG93IHRvIGRvIHRoYXQgYmV0dGVyLgo+ID4gUHJvYmFibHkgdGhlIGNv ZGUgd2FudHMgdG8gYmUgbW92ZWQgdG8geGVuL2luY2x1ZGUvYnVnLmggYW5kIHVzaW5nCj4gPiBp ZmRlZiBBUk0gJiYgUklTQ1YgLi4uCj4gCj4gT3IgeW91IGNvdWxkIGludHJvZHVjZSBDT05GSUdf QlVHX0dFTkVSSUMgb3IgZWxzZSwgc28gaXQgaXMgZWFzaWx5IAo+IHNlbGVjdGFibGUgYnkgb3Ro ZXIgYXJjaGl0ZWN0dXJlLgo+IAo+ID4gQnV0IHN0aWxsIEkgYW0gbm90IHN1cmUgdGhhdCB0aGlz IGlzIHRoZSBiZXN0IG9uZSBvcHRpb24gYXMgYXQKPiA+IGxlYXN0IHdlCj4gPiBoYXZlIGRpZmZl cmVudCBpbXBsZW1lbnRhdGlvbiBmb3IgeDg2XzY0Lgo+IAo+IE15IG1haW4gY29uY2VybiBpcyB0 aGUgbWFpbnRhaW5hbmNlIGVmZm9ydC4gRm9yIGV2ZXJ5IGJ1Zywgd2Ugd291bGQKPiBuZWVkIAo+ IHRvIGZpeCBpdCBpbiB0d28gcGxhY2VzLiBUaGUgcmlzayBpcyB3ZSBtYXkgZm9yZ2V0IHRvIGZp eCBvbmUKPiBhcmNoaXRlY3R1cmUuCj4gVGhpcyBpcyBub3QgYSB2ZXJ5IGlkZWFsIHNpdHVhdGlv bi4KPiAKPiBTbyBJIHRoaW5rIHNoYXJpbmcgdGhlIGhlYWRlciBiZXR3ZWVuIFJJU0MtViBhbmQg QXJtIChvciB4ODYsIHNlZQo+IGJlbG93KSAKPiBpcyBhdCBsZWFzdCBhIG11c3QuIFdlIGNhbiBk byB0aGUgM3JkIGFyY2hpdGVjdHVyZSBhdCBhIGxlaXN1cmUgcGFjZS4KPiAKPiBPbmUgb3B0aW9u IHdvdWxkIGJlIHRvIGludHJvZHVjZSBhc20tZ2VuZXJpYyBsaWtlIExpbnV4IChJSVJDIHRoaXMK PiB3YXMgYSAKPiBzdWdnZXN0aW9uIGZyb20gQW5kcmV3KS4gVGhpcyB3b3VsZCBhbHNvIHRvIHNo YXJlIGNvZGUgYmV0d2VlbiB0d28gb2YKPiB0aGUgYXJjaHMuCj4gCj4gQWxzbywgZnJvbSBhIGJy aWVmIGxvb2ssIHRoZSBkaWZmZXJlbmNlIGluIGltcGxlbWVudGF0aW9uIGlzIG1haW5seSAKPiBi ZWNhdXNlIG9uIEFybSB3ZSBjYW4ndCB1c2UgJWMgKHNvbWUgdmVyc2lvbiBvZiBHQ0MgZGlkbid0 IHN1cHBvcnQKPiBpdCkuCj4gSXMgdGhpcyBhbHNvIHRoZSBjYXNlIG9uIFJJU0MtVj8gSWYgbm90 LCB5b3UgbWF5IHdhbnQgdG8gY29uc2lkZXIgdG8KPiB1c2UgCj4gdGhlIHg4NiB2ZXJzaW9uLgo+ IApJIGRpZCBzZXZlcmFsIGV4cGVyaW1lbnRzIHJlbGF0ZWQgdG8gJyVjJyBpbiBpbmxpbmUgYXNz ZW1ibHkgZm9yIFJJU0MtVgphbmQgaXQgc2VlbXMgdGhhdCAnJWMnIGRvZXNuJ3Qgc3VwcG9ydCBh bGwgZm9ybXMgb2YgdGhlIHVzZSBvZiAnJWMnLgpJIHdyb3RlIHRoZSBmb2xsb3dpbmcgbWFjcm9z IGFuZCB0aGV5IGhhdmUgYmVlbiBjb21waWxlZCB3aXRob3V0IGFueQplcnJvcnM6CiAgICAgICAg ICAgICAgICAgICAgICAgIC4uLi4uCiNkZWZpbmUgX0FTTV9CVUdGUkFNRV9URVhUKHNlY29uZF9m cmFtZSkgICAgICAgICAgICAgICAgICAgICAgIFwKwqAgwqAgIi5MYnVnJT06IGVicmVha1xuIiAg ICAgICAgICAgICAgICAgICAgICAgICAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXArCoCDCoCAiLnB1 c2hzZWN0aW9uIC5idWdfZnJhbWVzLiVjW2JmX3R5cGVdLCBcImFcIiwgQHByb2diaXRzXG4iIFwK wqAgwqAgIi5wMmFsaWduIDJcbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXArCoCDCoCAiLkxmcm0lPTpcbiIgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgXArCoCDCoCAiLmxvbmcgKC5MZnJtJT0pXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgXArCoCDCoCAiLmxvbmcgKDB4NTU1 NTU1NTUpXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIFwKwqAgwqAgIi5sb25nICguTGJ1ZyU9KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKwqAgwqAgIi5sb25nICgweDU1 NTU1NTU1KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBcCsKgIMKgICIubG9uZyAlY1tiZl9saW5lX2hpXVxuIiDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcCsKgIMKgICIubG9uZyAoMHg1NTU1 NTU1NSlcbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgXArCoCDCoCAiLmxvbmcgJVtiZl9saW5lX2hpXVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKwqAgwqAgIi5sb25nICgweDU1NTU1 NTU1KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBcCsKgIMKgICIubG9uZyAlW2JmX2xpbmVfbG9dXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgXArCoCDCoCAiLmxvbmcgKDB4NTU1NTU1 NTUpXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIFwKwqAgwqAgIi5sb25nICVbYmZfcHRyXVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKwqAgwqAgIi5sb25nICgweDU1NTU1 NTU1KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBcCsKgIMKgICIubG9uZyAoLkxidWclPSAtIC5MZnJtJT0pICsgJWNbYmZfbGluZV9oaV1c biIgwqAgwqAgwqAgwqAgwqAgwqAgXArCoCDCoCAiLnBvcHNlY3Rpb25cbiIgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBcCgoj ZGVmaW5lIF9BU01fQlVHRlJBTUVfSU5GTyh0eXBlLCBsaW5lLCBwdHIsIG1zZykgwqAgwqAgwqAg wqAgwqAgwqAgwqAgXArCoCDCoCBbYmZfdHlwZV0gwqAgwqAiaSIgKHR5cGUpLCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcCsKgIMKgIFtiZl9wdHJd IMKgIMKgICJpIiAocHRyKSwgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqBcCsKgIMKgIFtiZl9tc2ddIMKgIMKgICJpIiAobXNnKSwgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBcCsKgIMKgIFtiZl9s aW5lX2xvXSAiaSIgKChsaW5lICYgKCgxIDw8IEJVR19MSU5FX0xPX1dJRFRIKSAtIDEpKSDCoFwK wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgPDwgQlVHX0RJU1BfV0lEVEgpLCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKwqAgwqAgW2JmX2xpbmVfaGldICJpIiAoKChs aW5lKSA+PiBCVUdfTElORV9MT19XSURUSCkgPDwgQlVHX0RJU1BfV0lEVEgpCgojZGVmaW5lIEJV R19GUkFNRSh0eXBlLCBsaW5lLCBwdHIsIHNlY29uZF9mcmFtZSwgbXNnKSBkbyB7ICAgICBcCsKg IMKgIF9fYXNtX18gX192b2xhdGlsZV9fICggX0FTTV9CVUdGUkFNRV9URVhUKHNlY29uZF9mcmFt ZSkgwqAgwqBcCsKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgOjogX0FTTV9CVUdGUkFNRV9J TkZPKHR5cGUsIGxpbmUsIHB0ciwgbXNnKSApOyBcCn0gd2hpbGUgKDApCiAgICAgICAgICAgICAg ICAgICAgICAgICAgLi4uLgoKCkJ1dCBpZiBhZGQgIi5sb25nICVjW2JmX3B0cl1cbiIgdGhlbiB0 aGUgZm9sbG93aW5nIGNvbXBpbGF0aW9uIGVycm9yCndpbGwgb2NjdXI6IFsgZXJyb3I6IGludmFs aWQgJ2FzbSc6IGludmFsaWQgdXNlIG9mICclYycuIF0KCklmIHlvdSBsb29rIGF0IHRoZSBkaXNz ZW1ibGVyIG9mIF9idWdfZnJhbWVzXy4uLgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Li4uLi4uCsKgIMKgIDgwMjAxMDEwOiDCoCAxMDEwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgYWRkaSDCoCDCoGEyLHNwLDMywqDCoCAjIC5MZnJtJT0KwqAgwqAgODAyMDEwMTI6IMKgIDgw MjAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAuMmJ5dGUgwqAweDgwMjAKwqAgwqAgODAy MDEwMTQ6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBsaSDCoCDCoCDCoGEw LC0xMQrCoCDCoCA4MDIwMTAxNjogwqAgNTU1NSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oGxpIMKgIMKgIMKgYTAsLTExCsKgIMKgIDgwMjAxMDE4OiDCoCAzMDIyIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgLjJieXRlIMKgMHgzMDIywqAgIyAuTGJ1ZyU9CsKgIMKgIDgwMjAxMDFh OiDCoCA4MDIwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgLjJieXRlIMKgMHg4MDIwCsKg IMKgIDgwMjAxMDFjOiDCoCA1NTU1IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGkgwqAg wqAgwqBhMCwtMTEKwqAgwqAgODAyMDEwMWU6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqBsaSDCoCDCoCDCoGEwLC0xMQrCoCDCoCA4MDIwMTAyMDogwqAgMDAwMCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoHVuaW1wwqDCoMKgwqDCoMKgwqDCoMKgwqAjICVjW2JmX2xp bmVfaGldCsKgIMKgIDgwMjAxMDIyOiDCoCAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgdW5pbXAKwqAgwqAgODAyMDEwMjQ6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqBsaSDCoCDCoCDCoGEwLC0xMQrCoCDCoCA4MDIwMTAyNjogwqAgNTU1NSDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoGxpIMKgIMKgIMKgYTAsLTExCsKgIMKgIDgwMjAxMDI4OiDCoCAw MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdW5pbXDCoMKgwqDCoMKgwqDCoMKgwqDC oCAjICVbYmZfbGluZV9oaV0KwqAgwqAgODAyMDEwMmE6IMKgIDAwMDAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqB1bmltcArCoCDCoCA4MDIwMTAyYzogwqAgNTU1NSDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoGxpIMKgIMKgIMKgYTAsLTExCsKgIMKgIDgwMjAxMDJlOiDCoCA1NTU1 IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGkgwqAgwqAgwqBhMCwtMTEKwqAgwqAgODAy MDEwMzA6IMKgIDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB1bmltcMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAjICVbYmZfbGluZV9sb10KwqAgwqAgODAyMDEwMzI6IMKgIDE2MDAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBhZGRpIMKgIMKgczAsc3AsODAwCsKgIMKgIDgwMjAx MDM0OiDCoCA1NTU1IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGkgwqAgwqAgwqBhMCwt MTEKwqAgwqAgODAyMDEwMzY6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBs aSDCoCDCoCDCoGEwLC0xMQrCoCDCoCA4MDIwMTAzODogwqAgMTBiOCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoGFkZGkgwqAgwqBhNCxzcCwxMDTCoMKgICMgJVtiZl9wdHJdCsKgIMKgIDgw MjAxMDNhOiDCoCA4MDIwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgLjJieXRlIMKgMHg4 MDIwCsKgIMKgIDgwMjAxMDNjOiDCoCA1NTU1IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg bGkgwqAgwqAgwqBhMCwtMTEKwqAgwqAgODAyMDEwM2U6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqBsaSDCoCDCoCDCoGEwLC0xMQrCoCDCoCA4MDIwMTA0MDogwqAgMjAxMiDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoC4yYnl0ZSDCoDB4MjAxMsKgwqAgIyAoLkxidWcl PSAtCi5MZnJtJT0pICsgJWNbYmZfbGluZV9oaV0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC4uLi4uCi4uLiBpdCBsb29rcyBsaWtlIHRoZSBlcnJvciB3aWxsIGJlIGdlbmVyYXRlZCBp ZiB0aGUgbmFtZSBpbiAlY1tuYW1lXQppc24ndCBlcXVhbCB0byAwLgoKQW5vdGhlciB0aGluZyBJ IG5vdGljZWQgaXMgdGhhdCAlW25hbWVdIGNhbiBiZSB1c2VkIGluc3RlYWQgb2YgJWNbbmFtZV0K Zm9yIFJJU0MtViAoIGkgZGlkIGEgcXVpY2sgY2hlY2sgYW5kIGl0IHdvcmtzKSBzbyBpdCBpcyBz dGlsbCBwb3NzaWJsZQp0byBmb2xsb3cgSW50ZWwgaW1wbGVtZW50YXRpb24gYnV0IHJlcXVpcmVk IGEgcmVkZWZpbml0aW9uIG9mwqAKX0FTTV9CVUdGUkFNRV9URVhUIHdoZXJlICVjWy4uLl0gd29u J3QgYmUgdXNlZC4gQWxsIHRoZSByZXN0IHdpbGwgYmUKdGhlIHNhbWUgYXMgaW4geDg2IGltcGxl bWVudGF0aW9uOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC4uLi4uCiNkZWZpbmUg X0FTTV9CVUdGUkFNRV9URVhUKHNlY29uZF9mcmFtZSkgIMKgIMKgIMKgIMKgIMKgIMKgIMKgICAg ICAgIFwKwqAgwqAgIi5MYnVnJT06IGVicmVha1xuIiAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgICAgICAgICAgICAgICAgXArCoCDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVz LiVbYmZfdHlwZV0sIFwiYVwiLCBAcHJvZ2JpdHNcbiIgXArCoCDCoCAiLnAyYWxpZ24gMlxuIiDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoFwKwqAgwqAgIi5MZnJtJT06XG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgXArCoCDCoCAiLmxvbmcgKC5M YnVnJT0gLSAuTGZybSU9KSArICVbYmZfbGluZV9oaV1cbiIgwqAgwqAgwqAgwqAgwqAgwqAgXArC oCDCoCAiLmxvbmcgKCVbYmZfcHRyXSAtIC5MZnJtJT0pICsgJVtiZl9saW5lX2xvXVxuIiDCoCDC oCDCoCDCoCDCoCBcCsKgIMKgICIuaWYgIiAjc2Vjb25kX2ZyYW1lICJcbiIgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXArCoCDCoCAiLmxvbmcgMCwgJVti Zl9tc2ddIC0gLkxmcm0lPVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oFwKwqAgwqAgIi5lbmRpZlxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKwqAgwqAgIi5wb3BzZWN0aW9uXG4i IMKgIMKgIMKgIMKgwqDCoCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uLi4KCk9uZSB0aGluZyBJIHdvdWxkIGxpa2Ug dG8gYXNrIHlvdSBpcyB3aHkgaXQncyBiZXR0ZXIgdG8gZm9sbG93L3VzZSB4ODYKaW1wbGVtZW50 YXRpb24gaW5zdGVhZCBvZiBBUk0/Ckl0IHNlZW1zIHRoYXQgIiVjWy4uLl0iIGhhcyB0aGUgYmVz dCBzdXBwb3J0IG9ubHkgZm9yIEludGVsIEdDQyBhbmQKdGhlcmVieSBBUk0gaW1wbGVtZW50YXRp b24gbG9va3MgbW9yZSB1bml2ZXJzYWwsIGRvZXNuJ3QgaXQ/Cgo+IENoZWVycywKPiAKCn4gT2xl a3NpaQoK From xen-devel-bounces@lists.xenproject.org Wed Feb 01 18:17:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 18:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488392.756453 (Exim 4.92) (envelope-from ) id 1pNHfA-0000yo-4G; Wed, 01 Feb 2023 18:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488392.756453; Wed, 01 Feb 2023 18:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHfA-0000yh-1P; Wed, 01 Feb 2023 18:16:52 +0000 Received: by outflank-mailman (input) for mailman id 488392; Wed, 01 Feb 2023 18:16:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHf8-0000yX-BU; Wed, 01 Feb 2023 18:16:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHf8-0007Z5-82; Wed, 01 Feb 2023 18:16:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHf7-0005TK-Lu; Wed, 01 Feb 2023 18:16:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNHf7-0000F4-LQ; Wed, 01 Feb 2023 18:16:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l9QSM3ek6Se0r1q1yGJROhvKgDfKqqhlSkcflV/cALg=; b=B3zmjEofS1dDm/OHr/XU+AYZGa YiII0tIxuaDmO0z36MROAaenBQdBiB9ICdfy5b2emZcJshoYPg/S7F1XjunzGjvMeT+cvCLr2+Xxs LSHWbXGDX/4jtYVkxYOWmA1Je/dyRmorWQxkv6DRO5A3CcwZPoJwbWbIbHsa0z+4TIqk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176307: trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl-rtds::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-amd64-migrupgrade::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-xl::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64::broken:regression xen-4.17-testing:test-amd64-i386-pair::broken:regression xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-intel::broken:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-4.17-testing:test-amd64-amd64-xl-credit2::broken:regression xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-pair::broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-amd64-xl:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-pair:host-install/dst_host(7):broken:heisenbug xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-intel:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-credit2:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-pair:capture-logs/dst_host(33):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-migrupgrade:host-install/dst_host(7):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-ping-check-xen:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:xen-boot:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-xsm:guest-localmigrate/x10:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:xen-boot:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:heisenbug xen-4.17-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Wed, 01 Feb 2023 18:16:49 +0000 flight 176307 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176307/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-rtds broken test-amd64-amd64-xl-qemut-debianhvm-amd64 broken build-armhf broken test-amd64-amd64-migrupgrade broken build-armhf 4 host-install(4) broken REGR. vs. 175447 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken in 176275 test-amd64-amd64-xl broken in 176275 test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken in 176275 test-amd64-amd64-xl-qemuu-ovmf-amd64 broken in 176275 test-amd64-i386-pair broken in 176290 test-amd64-i386-qemut-rhel6hvm-intel broken in 176290 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken in 176295 test-amd64-i386-xl-qemut-ws16-amd64 broken in 176295 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken in 176295 test-amd64-amd64-xl-credit2 broken in 176300 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken in 176300 test-amd64-amd64-pair broken in 176300 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-amd64-xl 5 host-install(5) broken in 176275 pass in 176307 test-amd64-amd64-xl-qemuu-debianhvm-amd64 5 host-install(5) broken in 176275 pass in 176307 test-amd64-amd64-xl-qemuu-ovmf-amd64 5 host-install(5) broken in 176275 pass in 176307 test-amd64-i386-pair 7 host-install/dst_host(7) broken in 176290 pass in 176307 test-amd64-i386-qemut-rhel6hvm-intel 5 host-install(5) broken in 176290 pass in 176307 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 176295 pass in 176307 test-amd64-i386-xl-qemut-ws16-amd64 5 host-install(5) broken in 176295 pass in 176307 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken in 176295 pass in 176307 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 176300 pass in 176307 test-amd64-amd64-xl-credit2 5 host-install(5) broken in 176300 pass in 176307 test-amd64-amd64-pair 33 capture-logs/dst_host(33) broken in 176300 pass in 176307 test-amd64-amd64-xl-rtds 5 host-install(5) broken pass in 176290 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken pass in 176295 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken pass in 176295 test-amd64-amd64-migrupgrade 7 host-install/dst_host(7) broken pass in 176300 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 176261 pass in 176307 test-amd64-amd64-xl-rtds 10 host-ping-check-xen fail in 176275 pass in 176261 test-amd64-i386-xl-qemut-win7-amd64 8 xen-boot fail in 176275 pass in 176295 test-amd64-amd64-xl-xsm 20 guest-localmigrate/x10 fail in 176275 pass in 176307 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 176275 pass in 176307 test-amd64-amd64-xl-rtds 8 xen-boot fail in 176290 pass in 176275 test-amd64-i386-xl-qemut-ws16-amd64 8 xen-boot fail pass in 176275 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175447 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken in 176275 like 175437 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken like 175437 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail in 176275 like 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail in 176295 like 175447 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 176275 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176295 n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 41 days Testing same since 176224 2023-01-26 22:14:43 Z 5 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 broken test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade broken test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds broken test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-migrupgrade broken broken-step build-armhf host-install(4) broken-step build-armhf capture-logs broken-step test-amd64-i386-qemuu-rhel6hvm-intel host-install(5) broken-step test-amd64-amd64-migrupgrade host-install/dst_host(7) broken-step test-amd64-amd64-xl-qemut-debianhvm-amd64 host-install(5) broken-step test-amd64-i386-xl-qemut-win7-amd64 host-install(5) broken-step test-amd64-amd64-xl-rtds host-install(5) broken-job test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-i386-pair broken broken-job test-amd64-i386-qemut-rhel6hvm-intel broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemuu-debianhvm-i386-xsm broken broken-job test-amd64-amd64-xl broken broken-job test-amd64-amd64-xl-qemuu-debianhvm-amd64 broken broken-job test-amd64-amd64-xl-qemuu-ovmf-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-amd64-xl-credit2 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm broken broken-job test-amd64-amd64-pair broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 18:23:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 18:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488400.756465 (Exim 4.92) (envelope-from ) id 1pNHlD-0002UB-Uz; Wed, 01 Feb 2023 18:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488400.756465; Wed, 01 Feb 2023 18:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHlD-0002U4-S6; Wed, 01 Feb 2023 18:23:07 +0000 Received: by outflank-mailman (input) for mailman id 488400; Wed, 01 Feb 2023 18:23:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNHlC-0002Tx-O6 for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 18:23:06 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2046.outbound.protection.outlook.com [40.107.92.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77b9bb88-a25d-11ed-933c-83870f6b2ba8; Wed, 01 Feb 2023 19:23:05 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by CH3PR12MB7571.namprd12.prod.outlook.com (2603:10b6:610:147::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Wed, 1 Feb 2023 18:23:02 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%5]) with mapi id 15.20.6043.038; Wed, 1 Feb 2023 18:23:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77b9bb88-a25d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JGgrSY68mqhhyfbIfc9q+zjV/5nePDs/2KSqI24GpjzFsqaha4xtqT5ezmiRwgjsH0HSE2kPvc6I4c/B8sKLl5bMT7HUsQL2r1LHp8iRcLoEbh9uvpIGGaC18/nKFlTsoaU4MQm8Vvb/g4i7j7+QNNbrfo9rhblRnP2wMU1SwMIyRuRRUoTefcwLwXTuq6Oh0yPvDR7k3fbH4mzd4vaJqp8bXFAUYAd7GfKwqbjL8mKqPM64iQXYS7ViZUGSpY7efi/RUZM62KUepRRVRDs48NgBA3EnwtULxhBpRgD5JxsCahjMtrR6Dkj6jkr3ADWM7SSL8Y7KG3fMq6QMNXZ6yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJHdhOt+uWK46pydYRq/wR/+sKCJiZxU66jmvJ8H9eA=; b=Uto7vb5JLW+1+5urJo4XCwDwASxw/6ZW0J3RtXpK1F3EegMpO2Fo8tYpQVuwYa9UwBR8Oj5xZ9xkdhnCfFhYyhl9x4U0lUiPOTb2LpKZk4xTxEvEu7xIyK7S4fFsDBxM6E4JpTsIKELoxRqy3h+DdhNtzg3wsTQYcxX1NFJvW1xaZQ1U/C8zlDjUq/h9XFlyiKrQK4MmuhJN21VJ5FalVEl0pZvyU1jUR8JXP+YGPJeB/SEYJf7L6lILIpAh0kyAa34zemnxPb6GZZH0ZUPti1/PWbStVN0/gAW6N5Z/8Yrn0GZ9GTdEbk+WJ0LMLaVz3c767wRwJ25NyIMiRNxKVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJHdhOt+uWK46pydYRq/wR/+sKCJiZxU66jmvJ8H9eA=; b=EmE66mEANAA5VJ4IKcvQeWjEeFl/P6w4TFbkfZS5b8w2FvYOqV+pUrNhURCN1wsExy77R0uh7JkEfmvPfKzVmAZYNQzdh+tMO9PueRmawcGyy/vmzfcu2EotVouuLkG3UOSkdMbYtsBjkgyaDkqfGvvL6Wo6i3z5r5dnrwnIXIE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <3e205146-5113-861d-ef39-c463257b54a1@amd.com> Date: Wed, 1 Feb 2023 10:22:59 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine Content-Language: en-US To: paul@xen.org, qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Peter Maydell , Stefano Stabellini , Anthony Perard , "open list:ARM TCG CPUs" References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-10-vikram.garhwal@amd.com> <179d773b-2634-b52b-8836-8d8f882e1495@xen.org> From: Vikram Garhwal In-Reply-To: <179d773b-2634-b52b-8836-8d8f882e1495@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR07CA0066.namprd07.prod.outlook.com (2603:10b6:a03:60::43) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|CH3PR12MB7571:EE_ X-MS-Office365-Filtering-Correlation-Id: 760ecaa7-c0d4-46c5-2387-08db04815a73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tZHu1iQgamGBPEfZITCcBxKY0f7ZFz3qjWjilkrPh/wH6o3DP7sk3l3wG9/nbmcdTpm/B9Zr4evdhBg8pHj72xEsWUVBCK27SQDj0rxMMi9p+8wOzStDkXUG/jlw0T+gH1eMQVzXaOlowFH2t8NuVS4rGMdmjsuQCBef/3BDXd/c0OlTpW+dhaDbWEjzLYhiSlxdcknpgjO+HycSWAp4sivXaMTjWxQcHv8Tu41iCwDXtY7mlVipjAz4xSAQrxjMn3jScm9poQ5Ui0OAtoPxiFFDIp1p/pQjNKUknr/nK9FxXGb0PrD7fmdKW6vbfZc7yCl5jHepaZTj4RvhOkDEU1IyJq2ed3AhaFYln4XvpXC05rNneIpeYUovlefdwt9GpGytBMrYjAvG8J8vVLEnvHycsyk0HezkpFlB5GlmaQLh5hpPbxuDqopFh9F1eysLUUmyH64lAGdoLOXgfZVtcL6i6noNBml6G3esKa2ncXDnXQhc0ARy+j9OdcQgZzLGtmMD33rsBAs6qz1a4ptYSIYingSQtkRtBGmzsG6jhf75qSCl9dqurRgUfOCvjEBzNiPjdBwJ8J2zZmZ8SvehvOYa4BCuRgGNifw47MjWm/0XFICf2EwMa1AGOrAEYNjYSQzmtUixpNRshSdDtY4FDv2u8lKq9yZAIIntLJ62DYvejpmDWwqObRI4V0/YUjqKYIUyi17lwjUkJZPjv4RO60ppa+c1A3kBTGKl5PjmTAc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199018)(316002)(38100700002)(2616005)(186003)(6512007)(26005)(44832011)(36756003)(6506007)(54906003)(53546011)(6666004)(5660300002)(2906002)(478600001)(31696002)(6486002)(86362001)(66946007)(66556008)(66476007)(8676002)(8936002)(41300700001)(31686004)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bldORmx1TWlPaUg2TmZVdjlsWVNJZFVYKzExcE1JdGZJZW9GSVlJZENSUFc1?= =?utf-8?B?Y1JaeHplRFJCbnNscWVBeHRLVEpBdFpUY0RnejFoSDMzV3luakxsMG5KQXl4?= =?utf-8?B?MWpiemo5L1VrMWV6TGxJSno0WFNIcW1mOS9kUUhZaCt2NGJIanQxampJWTUz?= =?utf-8?B?OHg4bGNmcjQwZjJFZFIrbTFRdHFrUWg4NXdiYm9qZ1dUazF1UkhtZGQ3ay8v?= =?utf-8?B?dWFXUFRsQkgrN0pMcmJ0aGpLbU1LQTRXTHMvbzRSTlpBcnNQaEFReXRGTS82?= =?utf-8?B?MGlUaGFTK2cxeWVoaGN2SEl2NWx3NUpiRVowQy9Od01Rb2wvL1hiekpNaUJX?= =?utf-8?B?NUtETHlEWUpvMU1WL3hsVlRhWktra1ZqUGFGRDdERUVGR0ZET09tZDVGM1Fv?= =?utf-8?B?aXdFTm5jTmx2NDdNQXh1MlFnRFV6MVNOdzlQN0t3NGFlVlZTZm1OU3JaQS8x?= =?utf-8?B?a0d2eTh3b1o3eUNybHRwU0ZLWUJNRTRKWlJBNEJKL3hhcWZQVHJPMzErTFVh?= =?utf-8?B?STZkWGhMbHhPYVZGWjZIb1B0UTQzano0b0JMbWZmMTY1MjJKakdMZTljQ3Jp?= =?utf-8?B?N1A5L2NLZzhvZktjN2ZUcHNiYzdnSDZaaUp2SUZEOXhWUW5ST0VZalJFZFJC?= =?utf-8?B?dFVlQ3UrbGw2UDFsSlpweGxkMnljdFdFVTA5R3NVMlZBTXNESU13M2pXam5a?= =?utf-8?B?dVRtNkl0M2dSNFFIWkRUWFZLTi9seHo0QTJHbUo5N0hRakRRamUvbE12SlN3?= =?utf-8?B?N3k1ZEcveGZ4cjUwNENYcGdyMlp2VmFuVzFXVVBPWGtuc3gxMlRYKzFzOXVt?= =?utf-8?B?YXd3N09vR2RXZWZGdTIxdVBsVFpPZU9vOEVtdEc5WDF1YVNqNGVPV3N1eFIv?= =?utf-8?B?Q0RHQ2p6UmtpemtoeGNJY1JVQXhRdGFaaDM0SmQxTmRiV2owVllyY3dySnZC?= =?utf-8?B?NFFvcTNuZ0hSWUxLeURGT29HQkM4bHZBcFY4d0hwWHdIYURzSGdQcThJbksw?= =?utf-8?B?RThwR0V4aXJ2UDhEV3A1NDZZNzVMSjZEOEZUQndEcFExYkJBeERqVHNtU1Nv?= =?utf-8?B?d042Vnd5R1UzOXdaQUJaVUJEMmNnR29HWVBURnBxSWdEU3Vqc2YwaFd2R2ww?= =?utf-8?B?RUUyUUEzYkwzczdQbVllcE5paElEWkE0ZklWaFZpSGxBZHVoWE5Edm5Zbytj?= =?utf-8?B?VFVWQ3hJaEZTNHlqMmloL3NDa2ZiN0dMVmFUOVg5Tlc0Wm1Eb3VqWVcwMVFI?= =?utf-8?B?d0xTYVB0WVZVT3p2YU82NGN5aHA4QjM2Ymd6NlRJNGFhdGxleVUwSzBobksx?= =?utf-8?B?RmRtMld1M0d2MTVxTVp5SVZwbFNmVDlVY2k5SUt2MHk3ODhldk1kSlZjZkN6?= =?utf-8?B?TGwvWXJic29kcHZ2YW1VUjFjZmgzS3ZvcGZqbFVQMEJ3UUVYdkJ2cVo0S2dy?= =?utf-8?B?WnNpZVFtdHlIZFJoRWhNUHlaMWlSaTU4cHdSOVJCV2lqV2xRc3h0VWM0RFJT?= =?utf-8?B?OW1CN2lWbk43WmhodlVzOWtPYjlFYkhsSXgwMHNVclBRU0xRa09pemtSVFlC?= =?utf-8?B?eFQ0REpJNkFiWis4aVMycHEveGpNbE9mUzJRbSthL0pXaEtnNDRsYkR2b05k?= =?utf-8?B?NkhCTTVWUlFUOE11dGFxaGVMU0NaU3I5S2hhOHY0djBERXhLQVFRTTdaYmc1?= =?utf-8?B?MHdKdHJOaElqWWtHbDYyVGloQkZ4elRKZHpjMTA5QWY4d1B2TzVLN3hBSmhI?= =?utf-8?B?SFo1MHpBUEtkZlN4VXlMUlBsLzF4UU05R2Q4amwzSVRLWm8rb3lZQkJIZ3Zj?= =?utf-8?B?V2NSUzh5RWN3NjdxZWd4VmhZSGZRTmlMUmswZi9tQkZ6WXY3THhqb3FSN2Za?= =?utf-8?B?R295U0FDTW1RY29PTGlmZ2NDYmpzR0ZRU0o4YnhHcE10RzFHUTQxZjYrMTBk?= =?utf-8?B?YWJvSFlqdC9NYlVqdk9JQmpNSjg5eit3QVlPMTVoVnBaMExFYmhSdEZwWWJQ?= =?utf-8?B?N09UMXkwRmJ1WFZyaUFrdWtmd1NJbmlKYkJybisyNzE3ZDFnajVxcExjQll4?= =?utf-8?B?bkFsMmJRcmFNeE5KVEg1ZDB5K3k5bEdhTURBSTk4TGVlSHFGVG50eXV1VVFE?= =?utf-8?Q?OGiRDZjShbHz3jMKTJLrux+LJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 760ecaa7-c0d4-46c5-2387-08db04815a73 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 18:23:01.9406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kPGV15H/KqjO1Oh/cUXl/zOk8gR0HQET2K9SGL8/l1+nbaTzQTrwCua9nW+ftlLN+heG1d4d3swMXYsXRpwzHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7571 Hi Paul, Thanks for reviewing this and other patches in series. Please see my reply below. On 2/1/23 12:30 AM, Paul Durrant wrote: > On 31/01/2023 22:51, Vikram Garhwal wrote: >> Add a new machine xenpvh which creates a IOREQ server to >> register/connect with >> Xen Hypervisor. >> > > Is this really the right way? Is it not possible to do the Xen > initialization (including ioreq server registration) off the back of > the accelerator init (i.e. AccelOpsClass ops_init function), which > seems like the right place to do it now that it's no longer > architecture specific. > There are few other machines using the "accel=xen" option and few of these machines aren't using IOREQ and other Xen related initialization. Example: /xenpv/ machine under /hw/xenpv/xen_machine_pv.c /and few other machines under /hw/i386/pc_piix.c//. /So, that's//why we moved the IOREQ and other common initialization parts in hw/xen/xen-hvm-common.c and call them as needed for the particular machine. @stefano, just checking if you want to add any other suggestion here. >   Paul > From xen-devel-bounces@lists.xenproject.org Wed Feb 01 18:54:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 18:54:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488406.756475 (Exim 4.92) (envelope-from ) id 1pNIFK-0006tz-A6; Wed, 01 Feb 2023 18:54:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488406.756475; Wed, 01 Feb 2023 18:54:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIFK-0006ts-7a; Wed, 01 Feb 2023 18:54:14 +0000 Received: by outflank-mailman (input) for mailman id 488406; Wed, 01 Feb 2023 18:54:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIFI-0006tm-Tt for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 18:54:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIFI-0008NG-Cm; Wed, 01 Feb 2023 18:54:12 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.6.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNIFI-0008N3-54; Wed, 01 Feb 2023 18:54:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5uar8H+UiIAISs0jgk8bFueS38CCQU7oBvO/P0VyO2I=; b=jIBqPk3uoIegniH0DB2a+Z/dnc 8i6mpxfgVxMtPX345at7qcGzkVXQRB4YmBSxL2FED0StMjprL/hSKMjRMApSHAKiW17IwlH89KWiA d0CFOtaCoNZ0NaFqESsrMbvJW1Ug7ByZMQKY/lorJim9Bm71q/QMpeQqFQDob8SW2jp4=; Message-ID: <1c9d7bcb-9ef1-8940-f709-a361285ad206@xen.org> Date: Wed, 1 Feb 2023 18:54:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> <6d3638e0-5613-ee7b-d919-1db3cd0ca2fb@xen.org> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2023 12:56, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 01/02/2023 12:20, Julien Grall wrote: >> >> >> On 01/02/2023 11:01, Michal Orzel wrote: >>> I would prefer not to do this in this series as the goals are different. This series is to remove >>> the known Xen limitation. >> >> The reason I am asking is it effectively change the way you would >> implement. If we were going to support zImage/Image within uImage, then >> we would need to fallthrough rather than calling kernel_decompress(). >> >> I am not aware of any at the moment. Better asking now than realizing >> after the fact that there is a need... > We need uImage support as there is more and more need to support booting > raw images of some RTOSes (there is always additional concern \wrt booting requirements > but at least the header allows to try to boot them). We are not aware of any need > to do some special handling to parse more than one header + from what I said earlier, > this is an unusual approach not seen to be handled by anyone. > >> >>>>> This could be solved by doing (not harmful in my opinion for common case) >>>>> addr &= PAGE_MASK. >>>> I don't quite understand your argument here. We need a check that work >>>> for everyone (not only in the common case). >>> As we assume the kernel module is at page aligned address (otherwise the issue you observed >>> can happen not only in uImage compressed case) >> >> I am not aware of such assumption. It is allowed to use non page-aligned >> address and it is correct for Xen to not free the first part if it is >> not page aligned because the first part may contain data from another >> module (or else). >> >>> , having a check like >>> this is generic. I.e. for normal usecase (no uImage compressed), addr &= PAGE_MASK >>> does not modify the address. For uImage compressed usecase it causes the addr to get >>> back to the previous value (before we added header size to it). >>> >>> Apart from the addr, we need to pass the correct size (as we extracted header size from it). >>> We could have the following (with appropriate comment): >>> size += addr - (addr & PAGE_MASK); >>> addr &= PAGE_MASK; >>> fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); >>> >>> It does not look great but solves the uImage issue and does not modify >>> the previous behavior. Anyway, I'm open for suggestions. >> >> Two options: >> 1) Move the call to fw_unreserved_regions() outside of >> kernel_decompress(). >> 2) Pass the offset of the gzip header to kernel_decompress(). >> Something like where it would be sizeof(uimage) in the uImage case or 0 >> otherwise. >> >> I have a slight preference for the latter. > That is cool. > I'm in favor of this as well because it would allow not to set mod->start,size > from kernel_uimage_probe. Everything can be done in kernel_decompress: > > Diff: A few comments because you resend the patch with it included. > > -static __init int kernel_decompress(struct bootmodule *mod) > +static __init int kernel_decompress(struct bootmodule *mod, uint32_t offset) > { > char *output, *input; > char magic[2]; > @@ -201,8 +201,14 @@ static __init int kernel_decompress(struct bootmodule *mod) > struct page_info *pages; > mfn_t mfn; > int i; > - paddr_t addr = mod->start; > - paddr_t size = mod->size; > + > + /* > + * It might be that gzip header does not appear at the start address > + * (i.e. in case of compressed uImage) so take into account offset to NIT: I would use 'e.g.' because in the future we may have multiple reason where the offset is not zero. > + * gzip header. > + */ > + paddr_t addr = mod->start + offset; > + paddr_t size = mod->size - offset; You want to check that mod->size is at least equal to offset. > > if ( size < 2 ) > return -EINVAL; > @@ -250,6 +256,13 @@ static __init int kernel_decompress(struct bootmodule *mod) > for ( ; i < (1 << kernel_order_out); i++ ) > free_domheap_page(pages + i); > > + /* > + * When freeing the kernel, we need to pass the module start address and > + * size as they were before taking an offset to gzip header into account. > + */ > + addr -= offset; > + size += offset; > + > /* > * Free the original kernel, update the pointers to the > * decompressed kernel Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 18:57:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 18:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488411.756487 (Exim 4.92) (envelope-from ) id 1pNIHx-0007oi-N1; Wed, 01 Feb 2023 18:56:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488411.756487; Wed, 01 Feb 2023 18:56:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIHx-0007ob-K8; Wed, 01 Feb 2023 18:56:57 +0000 Received: by outflank-mailman (input) for mailman id 488411; Wed, 01 Feb 2023 18:56:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIHw-0007oV-FF for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 18:56:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIHw-0008Qq-1r; Wed, 01 Feb 2023 18:56:56 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.6.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNIHv-00006d-SK; Wed, 01 Feb 2023 18:56:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NfY9kjkm/cwAWcRbTiBDNQZ8ivxxe8HKdIkz54f9Efs=; b=Q7OJtuHq8tKlDEK4RE31ZHIarQ xoYQdwYBT2akyremhP4AICp64uME8Ba/9uvd6qXdPDZIExGDnHjk4o5DuFIEaskbcPokSw/26hRwN hHksM+NlUakrCJH5GEuCemBP/jlVUTH4m/U9MnVAzCor/Lhs7Kfg5IdzVD6y41Pc9GOg=; Message-ID: <1f360356-b143-e732-5a4a-197ed56b2cd1@xen.org> Date: Wed, 1 Feb 2023 18:56:53 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , "ayan.kumar.halder@xilinx.com" Cc: Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-12-Penny.Zheng@arm.com> <7931e70f-3754-363c-28d8-5fde3198d70f@xen.org> <3c915633-ddb8-d1e4-f42e-064aaff168b2@xen.org> <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 01/02/2023 05:39, Penny Zheng wrote: >>> If we are adding MPU regions in sequence as you suggested, while using >>> bitmap at the same time to record used entry. >>> TBH, this is how I designed at the very beginning internally. We found >>> that if we don't do reorg late-boot to keep fixed in front and >>> switching ones after, each time when we do vcpu context switch, not >>> only we need to hunt down switching ones to disable, while we add new >>> switch-in regions, using bitmap to find free entry is saying that the >> process is unpredictable. Uncertainty is what we want to avoid in Armv8-R >> architecture. >> >> I don't understand why it would be unpredictable. For a given combination >> of platform/device-tree, the bitmap will always look the same. So the >> number of cycles/instructions will always be the same. >> > > In boot-time, it will be always the same. But if we still use bitmap to find free > entry(for switching MPU regions) on runtime, hmmm, I thought this part will > be unpredictable. I know this point is now moot as we agreed on not using a bitmap but I wanted to answer on the unpredictability part. It depends on whether you decide to allocate more entry at runtime. My assumption is you won't and therefore the the time to walk the bitmap will always be consistent. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 19:27:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 19:27:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488415.756498 (Exim 4.92) (envelope-from ) id 1pNIks-0003om-UD; Wed, 01 Feb 2023 19:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488415.756498; Wed, 01 Feb 2023 19:26:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIks-0003of-RY; Wed, 01 Feb 2023 19:26:50 +0000 Received: by outflank-mailman (input) for mailman id 488415; Wed, 01 Feb 2023 19:26:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIkr-0003oZ-IP for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 19:26:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNIkr-0000hH-4O; Wed, 01 Feb 2023 19:26:49 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.6.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNIkq-0001eo-UD; Wed, 01 Feb 2023 19:26:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gyuImUdBmr1Ji/IiyVAftkCsRP2FpRMtSRol289FyCQ=; b=4X7Zg+O8x8o33uCx83S3+fBxWj K+I67zLp/x7dn9ll2NOWFzeov1FykczJThQgp98wh813g2T9wKvf9nWoyKkGJM5f5ztlUXE6ToVGk 4jh+y7/GHgqEk3fhon/3VSY75GZqCRWh5lbHvlqEKCo7ijAYJsmR+8O0ePlSMXKdBSfY=; Message-ID: <6e96eaa7-a8a3-eaf3-ca44-3432c88e71d1@xen.org> Date: Wed, 1 Feb 2023 19:26:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-14-Penny.Zheng@arm.com> <23f49916-dd2a-a956-1e6b-6dbb41a8817b@xen.org> <33bddc11-ae1e-b467-32d7-647748d1c627@xen.org> <49329992-3203-78a7-fc61-d6494e37705c@xen.org> <14f9c89a-6eea-204e-cd1b-6bc1cca99716@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/02/2023 05:36, Penny Zheng wrote: > Hi Julien Hi Penny, > >> -----Original Message----- >> From: Julien Grall >> Sent: Tuesday, January 31, 2023 5:42 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function >> setup_early_uart to map early UART >> >> Hi Penny, >> >> On 31/01/2023 05:38, Penny Zheng wrote: >>>> -----Original Message----- >>>> From: Julien Grall >>>> Sent: Monday, January 30, 2023 6:00 PM >>>> To: Penny Zheng ; xen- >> devel@lists.xenproject.org >>>> Cc: Wei Chen ; Stefano Stabellini >>>> ; Bertrand Marquis >>>> ; Volodymyr Babchuk >>>> >>>> Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function >>>> setup_early_uart to map early UART >>>> >>>> >>>> >>>> On 30/01/2023 06:24, Penny Zheng wrote: >>>>> Hi, Julien >>>> >>>> Hi Penny, >>>> >>>>>> -----Original Message----- >>>>>> From: Julien Grall >>>>>> Sent: Sunday, January 29, 2023 3:43 PM >>>>>> To: Penny Zheng ; xen- >>>> devel@lists.xenproject.org >>>>>> Cc: Wei Chen ; Stefano Stabellini >>>>>> ; Bertrand Marquis >>>>>> ; Volodymyr Babchuk >>>>>> >>>>>> Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function >>>>>> setup_early_uart to map early UART >>>>>> >>>>>> Hi Penny, >>>>>> >>>>>> On 29/01/2023 06:17, Penny Zheng wrote: >>>>>>>> -----Original Message----- >>>>>>>> From: Julien Grall >>>>>>>> Sent: Wednesday, January 25, 2023 3:09 AM >>>>>>>> To: Penny Zheng ; xen- >>>>>> devel@lists.xenproject.org >>>>>>>> Cc: Wei Chen ; Stefano Stabellini >>>>>>>> ; Bertrand Marquis >>>>>>>> ; Volodymyr Babchuk >>>>>>>> >>>>>>>> Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function >>>>>>>> setup_early_uart to map early UART >>>>>>>> >>>>>>>> Hi Peny, >>>>>>> >>>>>>> Hi Julien, >>>>>>> >>>>>>>> >>>>>>>> On 13/01/2023 05:28, Penny Zheng wrote: >>>>>>>>> In MMU system, we map the UART in the fixmap (when earlyprintk >>>>>>>>> is >>>>>> used). >>>>>>>>> However in MPU system, we map the UART with a transient MPU >>>>>> memory >>>>>>>>> region. >>>>>>>>> >>>>>>>>> So we introduce a new unified function setup_early_uart to >>>>>>>>> replace the previous setup_fixmap. >>>>>>>>> >>>>>>>>> Signed-off-by: Penny Zheng >>>>>>>>> Signed-off-by: Wei Chen >>>>>>>>> --- >>>>>>>>> xen/arch/arm/arm64/head.S | 2 +- >>>>>>>>> xen/arch/arm/arm64/head_mmu.S | 4 +- >>>>>>>>> xen/arch/arm/arm64/head_mpu.S | 52 >>>>>>>> +++++++++++++++++++++++++ >>>>>>>>> xen/arch/arm/include/asm/early_printk.h | 1 + >>>>>>>>> 4 files changed, 56 insertions(+), 3 deletions(-) >>>>>>>>> >>> Yes, I'll draw the layout for you: >> >> Thanks! >> >>> ''' >>> Xen MPU Map before reorg: >>> >>> xen_mpumap[0] : Xen text >>> xen_mpumap[1] : Xen read-only data >>> xen_mpumap[2] : Xen read-only after init data xen_mpumap[3] : Xen >>> read-write data xen_mpumap[4] : Xen BSS xen_mpumap[5] : Xen static >>> heap ...... >>> xen_mpumap[max_xen_mpumap - 7]: Static shared memory section >>> xen_mpumap[max_xen_mpumap - 6]: Boot Module memory >> section(kernel, >>> initramfs, etc) xen_mpumap[max_xen_mpumap - 5]: Device memory >> section >>> xen_mpumap[max_xen_mpumap - 4]: Guest memory section >>> xen_mpumap[max_xen_mpumap - 3]: Early FDT >> xen_mpumap[max_xen_mpumap - >>> 2]: Xen init data xen_mpumap[max_xen_mpumap - 1]: Xen init text >>> >>> In the end of boot, function init_done will do the reorg and boot-only >> region clean-up: >>> >>> Xen MPU Map after reorg(idle vcpu): >>> >>> xen_mpumap[0] : Xen text >>> xen_mpumap[1] : Xen read-only data >>> xen_mpumap[2] : Xen read-only after init data >> >> In theory 1 and 2 could be merged after boot. But I guess it might be >> complicated? >> > > In theory, if in C merging codes, we do not use any read-only data or read-only-after-init > data, then, ig, it will be ok. > Since, In MPU system, when we implement C merging codes, we need to disable region 1 and 2 > firstly, and enable the merged region after. The reason is that two MPU regions with address overlapping > is not allowed when MPU on. Good to know! I think it should be feasible to avoid accessing read-only variable while doing the merge. Anyway, this looks more like a potential optimization for the future. > >>> xen_mpumap[3] : Xen read-write data >>> xen_mpumap[4] : Xen BSS >>> xen_mpumap[5] : Xen static heap >>> xen_mpumap[6] : Guest memory section >> >> Why do you need to map the "Guest memory section" for the idle vCPU? >> > > Hmmm, "Guest memory section" here refers to *ALL* guest RAM address range with only EL2 read/write access. For what purpose? Earlier, you said you had a setup with a limited number of MPU entries. So it may not be possible to map all the guests RAM. Xen should only need to access the guest memory in hypercalls and scrubbing. In both cases you could map/unmap on demand. > > For guest vcpu, this section will be replaced by guest itself own RAM with both EL1/EL2 access. > > >>> xen_mpumap[7] : Device memory section >> >> I might be missing some context here. But why this section is not also >> mapped in the context of the guest vCPU? >> >> For instance, how would you write to the serial console when the context is >> the guest vCPU? >> > > I think, as Xen itself, it shall have access to all system device memory on EL2. > Ik, it is not accurate in current MMU implementation, only devices with supported driver > will get ioremap. So in the MMU case, we are not mapping all the devices in Xen because we don't exactly know which memory attributes will be used by the guest. If we are using different attributes, then we are risking to break coherency. Could the same issue happen with the MPU? If so, then you should not mapped those regions in Xen. > > But like we discussed before, if following the same strategy as MMU does, with limited > MPU regions, we could not afford mapping a MPU region for each device. > For example, On FVPv8R model, we have four uarts, and a GICv3. At most, we may provide > four MPU regions for uarts, and two MPU regions for Distributor and one Redistributor region. > So, I thought up this new device tree property “mpu,device-memory-section = <0x0 0x80000000 0x0 0x7ffff000>;“ > to roughly map all system device memory for Xen itself. Why do you say "roughly"? Is it possible that you have non-device region in the range? > > For guest, it shall only see vgic, vpl011, and its own passthrough device. And here, to maintain safe and > isolation, we will be mapping a MPU region for each device for guest vcpu. > For example, vgic and vpl011 are emulated and direct-map in MPU. Relevant device I am confused. If the vGIC/vPL011 is emulated then why do you need to map it in the MPU? IOW, wouldn't you receive a fault in the hypervisor if the guest is trying to access a region not present in the MPU? > mapping(GFN == MFN with only EL2 access)will be added to its *P2M mapping table*, in vgic_v3_domain_init [1]. > > Later, on vcpu context switching, when switching from idle vcpu, device memory section gets disabled > and switched out in ctxt_switch_from [2], later when switching into guest vcpu, vgic and vpl011 device mapping > will be switched in along with the whole P2M mapping table [3]. > > Words might be ambiguous, but all related code implementation is on MPU patch serie part II - guest initialization, you may > have to check the gitlab link: > [1] https://gitlab.com/xen-project/people/weic/xen/-/commit/a51d5b25eb17a50a36b27987a2f48e14793ac585 > [2] https://gitlab.com/xen-project/people/weic/xen/-/commit/c6a069d777d9407aeda42b7e5b08a086a1c15976 > [3] https://gitlab.com/xen-project/people/weic/xen/-/commit/d8c6408b6eef1190d75c9bd4e58557d34fc8b4df I have looked at the code and this doesn't entirely answer my question. So let me provide an example. Xen can print to the serial console at any time. So Xen should be able to access the physical UART even when it has context switched to the guest vCPU. But above you said that the physical device would not be accessible and instead you map the virtual UART. So how Xen is supported to access the physical UART? Or by vpl011 did you actually mean the physical UART? If so, then if you map the device one by one in the MPU context, then it would likely mean to have space to map them one by one in the idle context. > xen_mpumap[0] : Xen text > xen_mpumap[1] : Xen read-only data > xen_mpumap[2] : Xen read-only after init data > xen_mpumap[3] : Xen read-write data > xen_mpumap[4] : Xen BSS > ( Fixed MPU region defined in assembly ) > -------------------------------------------------------------------------- > xen_mpumap[5]: Xen init data > xen_mpumap[6]: Xen init text > xen_mpumap[7]: Early FDT > xen_mpumap[8]: Guest memory section > xen_mpumap[9]: Device memory section > xen_mpumap[10]: Static shared memory section > ( boot-only and switching regions defined in C ) > -------------------------------------------------------------------------- > ... > xen_mpumap[max_xen_mpumap - 1] : Xen static heap > ( Fixed MPU region defined in C ) > -------------------------------------------------------------------------- > > After re-org: > xen_mpumap[0] : Xen text > xen_mpumap[1] : Xen read-only data > xen_mpumap[2] : Xen read-only after init data > xen_mpumap[3] : Xen read-write data > xen_mpumap[4] : Xen BSS > ( Fixed MPU region defined in assembly ) > -------------------------------------------------------------------------- > xen_mpumap[8]: Guest memory section > xen_mpumap[9]: Device memory section > xen_mpumap[10]: Static shared memory section > ( Switching region ) > -------------------------------------------------------------------------- > ... > xen_mpumap[max_xen_mpumap - 1] : Xen static heap > ( Fixed MPU region defined in C ) > > If you're fine with it, then next serie, I'll use this layout, to keep both > simple assembly and re-org process. I am ok in principle with the layout you propose. My main requirement is that the region used in assembly are fixed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 19:49:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 19:49:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488421.756509 (Exim 4.92) (envelope-from ) id 1pNJ6x-00070o-Rr; Wed, 01 Feb 2023 19:49:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488421.756509; Wed, 01 Feb 2023 19:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNJ6x-00070h-OX; Wed, 01 Feb 2023 19:49:39 +0000 Received: by outflank-mailman (input) for mailman id 488421; Wed, 01 Feb 2023 19:49:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNJ6w-00070V-Ar; Wed, 01 Feb 2023 19:49:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNJ6w-0001ET-9T; Wed, 01 Feb 2023 19:49:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNJ6v-0008UM-W7; Wed, 01 Feb 2023 19:49:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNJ6v-0005ym-Ve; Wed, 01 Feb 2023 19:49:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=00AOAx5V5ZMdML4Y+LciO8r1NdM6nf3DuNDJLio0tCQ=; b=IREDgsrUPL/2PvCwp0M19D/sUH 2/TVU0Na+5NgQfGcQfcKzLsz9JwaZL5QolLuN6RNNyCLJ62blVM66QDeLJj9zL9Q9qEZdIcqSnGG+ iCj0LsTotiUhUEEgaQl8cu0tc9QLCsWvk4bXzJqDDFJdLjSoIOllUr/vogrLQv3TVMyA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176316: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 19:49:37 +0000 flight 176316 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176316/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 1 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 01 20:49:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 20:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488429.756520 (Exim 4.92) (envelope-from ) id 1pNK2Z-0006uV-2s; Wed, 01 Feb 2023 20:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488429.756520; Wed, 01 Feb 2023 20:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNK2Z-0006uO-0D; Wed, 01 Feb 2023 20:49:11 +0000 Received: by outflank-mailman (input) for mailman id 488429; Wed, 01 Feb 2023 20:49:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNK2X-0006uE-Ie; Wed, 01 Feb 2023 20:49:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNK2X-0002jB-Fe; Wed, 01 Feb 2023 20:49:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNK2W-0003Jc-W8; Wed, 01 Feb 2023 20:49:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNK2W-0001hv-Vj; Wed, 01 Feb 2023 20:49:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gnmkZ6T6BIv8W0JQi9B1xsC9T0p/LbKTFeUpXhm8emc=; b=ohQE2RiP5mlWoXyBB1+2BDXXCv hYUfkQEgq3zKe+SmXvxpYe4ZWN95c1Kspq30nyVZRur+gXY8EHgm2vUvG3giOsJKCCiYHv8bNHO8v f53fEdcaq6GK1EIhZzhAYw9squcRs3n6LxkCWjQMLqTEFU3Jry5qAz6LMgF9mlik3bKQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176309: trouble: blocked/broken/pass X-Osstest-Failures: libvirt:build-armhf::broken:regression libvirt:build-armhf:host-install(4):broken:regression libvirt:build-armhf:syslog-server:running:regression libvirt:build-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:build-armhf:capture-logs:broken:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=648391f170ddbb0e92832d543a940bcc84fc2309 X-Osstest-Versions-That: libvirt=95a278a84591b6a4cfa170eba31c8ec60e82f940 From: osstest service owner Date: Wed, 01 Feb 2023 20:49:08 +0000 flight 176309 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176309/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176139 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176139 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: libvirt 648391f170ddbb0e92832d543a940bcc84fc2309 baseline version: libvirt 95a278a84591b6a4cfa170eba31c8ec60e82f940 Last test of basis 176139 2023-01-26 04:18:49 Z 6 days Failing since 176233 2023-01-27 04:18:53 Z 5 days 6 attempts Testing same since 176289 2023-01-31 04:18:49 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Martin Kletzander Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 648391f170ddbb0e92832d543a940bcc84fc2309 Author: Jiri Denemark Date: Thu Jan 26 16:54:06 2023 +0100 remote: Fix memory leak in remoteDomainMigrateFinish3* Theoretically, when remoteDomainMigrateFinish3* is called without a pointer for storing migration cookie or its length (i.e., either cookieout == NULL or cookieoutlen == NULL), we would leak the freshly created virDomain object referenced by rv. Signed-off-by: Jiri Denemark Reviewed-by: Erik Skultety commit 6f3f6c0f763b9ffd8ef93eb124c88dd0b79138fc Author: Michal Privoznik Date: Mon Jan 30 10:55:22 2023 +0100 virsh: Make domif-setlink work more than once In virsh, we have this convenient domif-setlink command, which is just a wrapper over virDomainUpdateDeviceFlags() and which allows setting link state of given guest NIC. It does so by fetching corresponding XML snippet and either putting into it, OR if the element already exists setting the attribute to desired value. The XML is then fed into the update API. There's, however, a small bug in detecting the pre-existence of the element and its attribute. The code looks at "link" attribute, while in fact, the attribute is called "state". Resolves: https://gitlab.com/libvirt/libvirt/-/issues/426 Fixes: e575bf082ed4889280be07c986375f1ca15bb7ee Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko commit 9f8fba7501327a60f6adb279ea17f0e2276071be Author: Jiri Denemark Date: Thu Jan 26 16:12:00 2023 +0100 remote: Fix version annotation for remoteDomainFDAssociate The API was added in libvirt 9.0.0. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa commit a0fbf1e25cd0f91bedf159bf7f0086f4b1aeafc2 Author: Michal Privoznik Date: Thu Jan 26 16:48:50 2023 +0100 rpc: Use struct zero initializer for args In a recent commit of v9.0.0-104-g0211e430a8 I've turned all args vars in src/remote/remote_driver.c to be initialized wit {0}. What I've missed was the generated code. Do what we've done in v9.0.0-13-g1c656836e3 and init also args, not just ret. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé commit 2dde3840b1d50e79f6b8161820fff9fe62f613a9 Author: Martin Kletzander Date: Thu Jan 26 16:57:20 2023 +0100 qemuxml2argvdata: Fix missing device in crypto-builtin XML Another forgotten fix after a post-review rebase. Signed-off-by: Martin Kletzander commit f3c9cbc36cc10775f6cefeb7e3de2f799dc74d70 Author: Martin Kletzander Date: Thu Jan 26 16:57:20 2023 +0100 qemuxml2argvdata: Fix watchdog parameters in crypto-builtin Forgotten fix after a post-review rebase. Signed-off-by: Martin Kletzander commit a2c5c5dad2275414e325ca79778fad2612d14470 Author: Martin Kletzander Date: Fri Jan 20 18:22:34 2023 +0100 news: Add information about iTCO watchdog changes Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit 2fa92efe9b286ad064833cd2d8b907698e58e1cf Author: Martin Kletzander Date: Fri Jan 20 18:22:30 2023 +0100 Document change to multiple watchdogs With the reasoning behind it. Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit 926594dcc82b40f483010cebe5addbf1d7f58b24 Author: Martin Kletzander Date: Fri Jan 20 11:22:22 2023 +0100 qemu: Add implicit watchdog for q35 machine types The iTCO watchdog is part of the q35 machine type since its inception, we just did not add it implicitly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2137346 Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit d81a27b9815d68d85d2ddc9671649923ee5905d7 Author: Martin Kletzander Date: Fri Jan 20 14:15:06 2023 +0100 qemu: Enable iTCO watchdog by disabling its noreboot pin strap In order for the iTCO watchdog to be operational we must disable the noreboot pin strap in qemu. This is the default starting from 8.0 machine types, but desirable for older ones as well. And we can safely do that since that is not guest-visible. Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit 5b80e93e42a1d89ee64420debd2b4b785a144c40 Author: Martin Kletzander Date: Fri Jan 20 10:26:21 2023 +0100 Add iTCO watchdog support Supported only with q35 machine types. Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit 1c61bd718a9e311016da799a42dfae18f538385a Author: Martin Kletzander Date: Tue Nov 8 09:10:57 2022 +0100 Support multiple watchdog devices This is already possible with qemu, and actually already happening with q35 machines and a specified watchdog since q35 already includes a watchdog we do not include in the XML. In order to express such posibility multiple watchdogs need to be supported. Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit c5340d5420012412ea298f0102cc7f113e87d89b Author: Martin Kletzander Date: Fri Jan 20 10:28:52 2023 +0100 qemuDomainAttachWatchdog: Avoid unnecessary nesting Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik commit 1cf7e6ec057a80f3c256d739a8228e04b7fb8862 Author: Jiri Denemark Date: Wed Jan 25 15:25:06 2023 +0100 remote: Drop useless cleanup in remoteDispatchNodeGet{CPU,Memory}Stats The function cannot fail once it starts populating ret->params.params_val[i].field. Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik commit d0f339170f35957e7541e5b20552d0007e150fbc Author: Jiri Denemark Date: Wed Jan 25 15:06:33 2023 +0100 remote: Avoid leaking uri_out In case the API returned success and a NULL pointer in uri_out, we would leak the preallocated buffer used for storing the uri_out pointer. Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik commit 4849eb2220fb2171e88e014a8e63018d20a8de95 Author: Jiri Denemark Date: Wed Jan 25 11:56:28 2023 +0100 remote: Propagate error from virDomainGetSecurityLabelList via RPC The daemon side of this API has been broken ever since the API was introduced in 2012. Instead of sending the error from virDomainGetSecurityLabelList via RPC so that the client can see it, the dispatcher would just send a successful reply with return value set to -1 (and an empty array of labels). The client side would propagate this return value so the client can see the API failed, but the original error would be lost. Signed-off-by: Jiri Denemark Reviewed-by: Michal Privoznik commit 0211e430a87a96db9a4e085e12f33caad9167653 Author: Michal Privoznik Date: Thu Jan 26 13:19:31 2023 +0100 remote: Initialize args variable Recently, in v9.0.0-7-gb2034bb04c we've dropped initialization of @args variable. The reasoning was that eventually, all members of the variable will be set. Well, this is not correct. For instance, in remoteConnectGetAllDomainStats() the args.doms.doms_val pointer is set iff @ndoms != 0. However, regardless of that, the pointer is then passed to VIR_FREE(). Worse, the whole args is passed to xdr_remote_connect_get_all_domain_stats_args() which then calls xdr_array, which tests the (uninitialized) pointer against NULL. This effectively reverts b2034bb04c61c75ddbfbed46879d641b6f8ca8dc. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander commit c3afde9211b550d3900edc5386ab121f5b39fd3e Author: Michal Privoznik Date: Thu Jan 26 11:56:10 2023 +0100 qemu_domain: Don't unref NULL hash table in qemuDomainRefreshStatsSchema() The g_hash_table_unref() function does not accept NULL. Passing NULL results in a glib warning being triggered. Check whether the hash table is not NULL and unref it only then. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko From xen-devel-bounces@lists.xenproject.org Wed Feb 01 22:11:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 22:11:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488460.756547 (Exim 4.92) (envelope-from ) id 1pNLK6-0002jn-AX; Wed, 01 Feb 2023 22:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488460.756547; Wed, 01 Feb 2023 22:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLK6-0002jg-80; Wed, 01 Feb 2023 22:11:22 +0000 Received: by outflank-mailman (input) for mailman id 488460; Wed, 01 Feb 2023 22:11:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLK4-0002ja-Nn for xen-devel@lists.xenproject.org; Wed, 01 Feb 2023 22:11:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLK4-0004SO-63; Wed, 01 Feb 2023 22:11:20 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNLK3-0008OS-WF; Wed, 01 Feb 2023 22:11:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=jipR7+cbugD8Ubdec53EWNKrD2peULlIM1gaiRNjkFE=; b=Z7cjQCqsldVlqdkbFtLQEKq9sw itWMSW+kygLPe4R3Xo4T54mgHZJo+27ixCJrBYoJrLarusguMojq9/K8JXcrFjimpku0eEqC+s+Ae FB5aW3t84PqRcb5p/10jAYdLdiPymp8a5oqHoznrqnewH44BfZHgSh13Iutj0OxQB43I=; Message-ID: Date: Wed, 1 Feb 2023 22:11:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> From: Julien Grall Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/02/2023 17:40, Oleksii wrote: > Hi Julien, Hi Oleksii, > On Mon, 2023-01-30 at 22:28 +0000, Julien Grall wrote: >> Hi Oleksii, >> >> On 30/01/2023 11:35, Oleksii wrote: >>> Hi Julien, >>> On Fri, 2023-01-27 at 16:02 +0000, Julien Grall wrote: >>>> Hi Oleksii, >>>> >>>> On 27/01/2023 13:59, Oleksii Kurochko wrote: >>>>> The patch introduces macros: BUG(), WARN(), run_in_exception(), >>>>> assert_failed. >>>>> >>>>> The implementation uses "ebreak" instruction in combination >>>>> with >>>>> diffrent bug frame tables (for each type) which contains useful >>>>> information. >>>>> >>>>> Signed-off-by: Oleksii Kurochko >>>>> --- >>>>> Changes: >>>>>     - Remove __ in define namings >>>>>     - Update run_in_exception_handler() with >>>>>       register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); >>>>>     - Remove bug_instr_t type and change it's usage to uint32_t >>>>> --- >>>>>    xen/arch/riscv/include/asm/bug.h | 118 >>>>> ++++++++++++++++++++++++++++ >>>>>    xen/arch/riscv/traps.c           | 128 >>>>> +++++++++++++++++++++++++++++++ >>>>>    xen/arch/riscv/xen.lds.S         |  10 +++ >>>>>    3 files changed, 256 insertions(+) >>>>>    create mode 100644 xen/arch/riscv/include/asm/bug.h >>>>> >>>>> diff --git a/xen/arch/riscv/include/asm/bug.h >>>>> b/xen/arch/riscv/include/asm/bug.h >>>>> new file mode 100644 >>>>> index 0000000000..4b15d8eba6 >>>>> --- /dev/null >>>>> +++ b/xen/arch/riscv/include/asm/bug.h >>>>> @@ -0,0 +1,118 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>>> +/* >>>>> + * Copyright (C) 2012 Regents of the University of California >>>>> + * Copyright (C) 2021-2023 Vates >>>> >>>> I have to question the two copyrights here given that the >>>> majority of >>>> the code seems to be taken from the arm implementation (see >>>> arch/arm/include/asm/bug.h). >>>> >>>> With that said, we should consolidate the code rather than >>>> duplicating >>>> it on every architecture. >>>> >>> Copyrights should be removed. They were taken from the previous >>> implementation of bug.h for RISC-V so I just forgot to remove them. >>> >>> It looks like we should have common bug.h for ARM and RISCV but I >>> am >>> not sure that I know how to do that better. >>> Probably the code wants to be moved to xen/include/bug.h and using >>> ifdef ARM && RISCV ... >> >> Or you could introduce CONFIG_BUG_GENERIC or else, so it is easily >> selectable by other architecture. >> >>> But still I am not sure that this is the best one option as at >>> least we >>> have different implementation for x86_64. >> >> My main concern is the maintainance effort. For every bug, we would >> need >> to fix it in two places. The risk is we may forget to fix one >> architecture. >> This is not a very ideal situation. >> >> So I think sharing the header between RISC-V and Arm (or x86, see >> below) >> is at least a must. We can do the 3rd architecture at a leisure pace. >> >> One option would be to introduce asm-generic like Linux (IIRC this >> was a >> suggestion from Andrew). This would also to share code between two of >> the archs. >> >> Also, from a brief look, the difference in implementation is mainly >> because on Arm we can't use %c (some version of GCC didn't support >> it). >> Is this also the case on RISC-V? If not, you may want to consider to >> use >> the x86 version. >> > I did several experiments related to '%c' in inline assembly for RISC-V > and it seems that '%c' doesn't support all forms of the use of '%c'. Thanks for checking! > I wrote the following macros and they have been compiled without any > errors: > ..... > #define _ASM_BUGFRAME_TEXT(second_frame) \ >     ".Lbug%=: ebreak\n"               \ >     ".pushsection .bug_frames.%c[bf_type], \"a\", @progbits\n" \ >     ".p2align 2\n"                                             \ >     ".Lfrm%=:\n"                                               \ >     ".long (.Lfrm%=)\n"                                        \ >     ".long (0x55555555)\n"                                     \ >     ".long (.Lbug%=)\n"                                        \ >     ".long (0x55555555)\n"                                     \ >     ".long %c[bf_line_hi]\n"                                   \ >     ".long (0x55555555)\n"                                     \ >     ".long %[bf_line_hi]\n"                                    \ >     ".long (0x55555555)\n"                                     \ >     ".long %[bf_line_lo]\n"                                    \ >     ".long (0x55555555)\n"                                     \ >     ".long %[bf_ptr]\n"                                        \ >     ".long (0x55555555)\n"                                     \ >     ".long (.Lbug%= - .Lfrm%=) + %c[bf_line_hi]\n"             \ >     ".popsection\n"                                            \ > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg)               \ >     [bf_type]    "i" (type),                                   \ >     [bf_ptr]     "i" (ptr),                                    \ >     [bf_msg]     "i" (msg),                                    \ >     [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1))  \ >                       << BUG_DISP_WIDTH),                      \ >     [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) > > #define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ >     __asm__ __volatile__ ( _ASM_BUGFRAME_TEXT(second_frame)    \ >                    :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ > } while (0) > .... > > > But if add ".long %c[bf_ptr]\n" then the following compilation error > will occur: [ error: invalid 'asm': invalid use of '%c'. ] > > If you look at the dissembler of _bug_frames_... > ...... >     80201010:   1010                    addi    a2,sp,32   # .Lfrm%= >     80201012:   8020                    .2byte  0x8020 >     80201014:   5555                    li      a0,-11 >     80201016:   5555                    li      a0,-11 >     80201018:   3022                    .2byte  0x3022  # .Lbug%= >     8020101a:   8020                    .2byte  0x8020 >     8020101c:   5555                    li      a0,-11 >     8020101e:   5555                    li      a0,-11 >     80201020:   0000                    unimp          # %c[bf_line_hi] >     80201022:   0000                    unimp >     80201024:   5555                    li      a0,-11 >     80201026:   5555                    li      a0,-11 >     80201028:   0000                    unimp           # %[bf_line_hi] >     8020102a:   0000                    unimp >     8020102c:   5555                    li      a0,-11 >     8020102e:   5555                    li      a0,-11 >     80201030:   0000                    unimp           # %[bf_line_lo] >     80201032:   1600                    addi    s0,sp,800 >     80201034:   5555                    li      a0,-11 >     80201036:   5555                    li      a0,-11 >     80201038:   10b8                    addi    a4,sp,104   # %[bf_ptr] >     8020103a:   8020                    .2byte  0x8020 >     8020103c:   5555                    li      a0,-11 >     8020103e:   5555                    li      a0,-11 >     80201040:   2012                    .2byte  0x2012   # (.Lbug%= - > .Lfrm%=) + %c[bf_line_hi] > ..... > ... it looks like the error will be generated if the name in %c[name] > isn't equal to 0. > > Another thing I noticed is that %[name] can be used instead of %c[name] > for RISC-V ( i did a quick check and it works) so it is still possible > to follow Intel implementation but required a redefinition of > _ASM_BUGFRAME_TEXT where %c[...] won't be used. All the rest will be > the same as in x86 implementation: > ..... > #define _ASM_BUGFRAME_TEXT(second_frame)               \ >     ".Lbug%=: ebreak\n"                       \ >     ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" \ >     ".p2align 2\n"                                            \ >     ".Lfrm%=:\n"                                              \ >     ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n"             \ >     ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n"           \ >     ".if " #second_frame "\n"                                 \ >     ".long 0, %[bf_msg] - .Lfrm%=\n"                          \ >     ".endif\n"                                                \ >     ".popsection\n"           \ > ..... > > One thing I would like to ask you is why it's better to follow/use x86 > implementation instead of ARM? IMHO, the x86 version is cleaner. But... > It seems that "%c[...]" has the best support only for Intel GCC and > thereby ARM implementation looks more universal, doesn't it? ... you are right, the Arm version is more portable. Although, I do wonder how GCC managed to have a different behavior between architecture as I would have expected %c to be a generic implementation. Anyway, if you are basing on the Arm one, then you should be able to 1) move arch/arm/include/asm/bug.h in asm-generic/bug.h (or similar) 2) Rename the guard and remove arm specific code.(I am not sure from where to include arm{32, 64}/bug.h) 3) Define BUG_INSTR to ebreak on RISC-V. 4) Find a place for all the RISC-V specific header 5) Move do_bug_frame() in common/bug.c I am happy to help testing the Arm version and/or help moving the code to common. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 01 22:30:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Feb 2023 22:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488466.756559 (Exim 4.92) (envelope-from ) id 1pNLcI-0005ur-3C; Wed, 01 Feb 2023 22:30:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488466.756559; Wed, 01 Feb 2023 22:30:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLcH-0005uk-VR; Wed, 01 Feb 2023 22:30:09 +0000 Received: by outflank-mailman (input) for mailman id 488466; Wed, 01 Feb 2023 22:30:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLcG-0005q6-Kn; Wed, 01 Feb 2023 22:30:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLcG-0004tz-CZ; Wed, 01 Feb 2023 22:30:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNLcF-0007NN-Qi; Wed, 01 Feb 2023 22:30:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNLcF-0005C8-QE; Wed, 01 Feb 2023 22:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EFK9kdlTBw/Q3fBUpLL0J/BrqheIRhSQhcJhHpiLFXg=; b=aXN3YZYZ8NKE4HnXOE1LEOLWON 97XEQ/8yynSC1rCVJh87PiRtKW+4mFIE64ZNNpaflH3ZFkYp2P3Cco3/UfbKW3B4LXZc7HBn9Y/kc jAJ+z3ylrWrAvfMWGRdkxXD8oxVwypXDLIVjopZt8fvbw6ubH2LjKgworptU77Z988fE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176318: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Wed, 01 Feb 2023 22:30:07 +0000 flight 176318 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176318/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 00:16:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 00:16:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488476.756570 (Exim 4.92) (envelope-from ) id 1pNNHC-0003GT-Ni; Thu, 02 Feb 2023 00:16:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488476.756570; Thu, 02 Feb 2023 00:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNHC-0003GM-KB; Thu, 02 Feb 2023 00:16:30 +0000 Received: by outflank-mailman (input) for mailman id 488476; Thu, 02 Feb 2023 00:16:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNHB-0003GC-4i; Thu, 02 Feb 2023 00:16:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNHB-0008Ig-3e; Thu, 02 Feb 2023 00:16:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNHA-0002Zh-Oy; Thu, 02 Feb 2023 00:16:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNNHA-0005vN-OY; Thu, 02 Feb 2023 00:16:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x3kSfcYFkcIShkUcdsJn8bqB0smvgKs00Gi0xJTGy2M=; b=zyEiqZ1XIMYQuDBsgkUWw9kU0v oydcqTcpBijBZCFpn2lSTaVimneD5Nm+K+1ScLvRHjC5T/IaA/uVEmoUhRmvNaIo8F1fLSyddOdFf L36hqfgVbdjpsXJpHiCwzNbCdnYgjGrqKg5mng0Sf0ITNj4pZf11jsfjayBK1RkFhT0U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176319: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 00:16:28 +0000 flight 176319 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176319/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 00:57:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 00:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488484.756581 (Exim 4.92) (envelope-from ) id 1pNNuX-0000v0-S6; Thu, 02 Feb 2023 00:57:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488484.756581; Thu, 02 Feb 2023 00:57:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNuX-0000ut-NO; Thu, 02 Feb 2023 00:57:09 +0000 Received: by outflank-mailman (input) for mailman id 488484; Thu, 02 Feb 2023 00:57:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNuW-0000uj-Hy; Thu, 02 Feb 2023 00:57:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNuW-0000oj-Cj; Thu, 02 Feb 2023 00:57:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNNuV-0003bf-Ra; Thu, 02 Feb 2023 00:57:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNNuV-00019G-R6; Thu, 02 Feb 2023 00:57:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PNAHqRdqI/g7+Rk8QWsfWJK+hXz4W1NFOiNdE4eiVYE=; b=ZFyHqNsn51Eko0yJJl3ELxyl4q eyl5UUkgg/RhjR83dt/1/VKNWPk7qOageZVpC2J5XzqB2lp9FK9HFlFY5VMJrhGvM1xTRnzmFVgMS l/Diu+zCvykbRUbaJK8m8c1Xp0xXH/QmMffLXlq8AzyXFMM2yQyjqiPvtwY05+7ZeVtE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176317: trouble: blocked/broken/fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64::broken:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-migrupgrade::broken:regression xen-4.17-testing:test-amd64-amd64-xl-rtds::broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel::broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-intel:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-migrupgrade:host-install/dst_host(7):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:xen-boot:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-4.17-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Thu, 02 Feb 2023 00:57:07 +0000 flight 176317 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176317/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 broken build-armhf broken test-amd64-amd64-qemuu-freebsd11-amd64 broken build-armhf 4 host-install(4) broken REGR. vs. 175447 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken in 176295 test-amd64-i386-xl-qemut-ws16-amd64 broken in 176295 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken in 176295 test-amd64-amd64-migrupgrade broken in 176307 test-amd64-amd64-xl-rtds broken in 176307 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 176307 test-amd64-i386-qemuu-rhel6hvm-intel broken in 176307 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 176295 pass in 176317 test-amd64-i386-xl-qemut-ws16-amd64 5 host-install(5) broken in 176295 pass in 176317 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken in 176295 pass in 176317 test-amd64-i386-qemuu-rhel6hvm-intel 5 host-install(5) broken in 176307 pass in 176317 test-amd64-amd64-migrupgrade 7 host-install/dst_host(7) broken in 176307 pass in 176317 test-amd64-amd64-xl-rtds 5 host-install(5) broken in 176307 pass in 176317 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken pass in 176295 test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken pass in 176307 test-amd64-i386-xl-qemut-ws16-amd64 8 xen-boot fail in 176307 pass in 176317 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 176307 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175447 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 176307 like 175437 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail in 176295 like 175447 test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 176307 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 176307 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 176307 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 176307 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 176307 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 176307 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved n/a test-arm64-arm64-xl 1 build-check(1) starved n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved n/a build-arm64-pvops 2 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 42 days Testing same since 176224 2023-01-26 22:14:43 Z 6 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops starved build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 broken test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken broken-step build-armhf host-install(4) broken-step build-armhf capture-logs broken-step test-amd64-amd64-qemuu-freebsd11-amd64 host-install(5) broken-step test-amd64-i386-xl-qemut-win7-amd64 host-install(5) broken-job test-amd64-amd64-migrupgrade broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel broken broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 02:05:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 02:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488494.756592 (Exim 4.92) (envelope-from ) id 1pNOyP-0002x3-VF; Thu, 02 Feb 2023 02:05:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488494.756592; Thu, 02 Feb 2023 02:05:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNOyP-0002wv-Pm; Thu, 02 Feb 2023 02:05:13 +0000 Received: by outflank-mailman (input) for mailman id 488494; Thu, 02 Feb 2023 02:05:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNOyO-0002wg-7c for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 02:05:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05hn20305.outbound.protection.outlook.com [2a01:111:f400:7e1a::305]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 040448e0-a29e-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 03:05:08 +0100 (CET) Received: from AS9PR06CA0389.eurprd06.prod.outlook.com (2603:10a6:20b:460::7) by PAWPR08MB10133.eurprd08.prod.outlook.com (2603:10a6:102:35f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Thu, 2 Feb 2023 02:05:04 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::cc) by AS9PR06CA0389.outlook.office365.com (2603:10a6:20b:460::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 02:05:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 02:05:03 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Thu, 02 Feb 2023 02:05:03 +0000 Received: from 131d2ce7d17e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C73D70E6-7536-4C1A-901D-498A9A0CF5D1.1; Thu, 02 Feb 2023 02:04:56 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 131d2ce7d17e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Feb 2023 02:04:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB7944.eurprd08.prod.outlook.com (2603:10a6:20b:541::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Thu, 2 Feb 2023 02:04:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.6064.022; Thu, 2 Feb 2023 02:04:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 040448e0-a29e-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svshDtxdWN2s21Wp+aLP/i0FD33vykjikRArmQiPEp8=; b=jWDtVlsW1PkiLOmvOb6OIdWDio9eoUFjKcSPXB1xZUmrIDZqKoMoJWtxk7oLd297BezPM7cwcx8cNGka2F3CzyQt/sk1dSyu1wHzOLTQza41PZmtxmt33K7NLEUT0kGldqwpDMqqRffhat61Onz2xgmZJerCY0C07Hj3SWHx3lY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFs9hOLp0ntjPwh5Dw9JuJVqXLS6gVJ/31qNW1IPPMBZMJx5tdVaolJRTgHy3dILOGtnfmVTvozZphsaXcvtfKwvS1whDm1QnrJXIcaOc6lSPr1bWCwZlK7765VvukMGI143bD/Dk7juhbfPVVQ8BOyxkOmxyprEPEhDmdoxShR2M1AM9iWHC/ZnLreOv9911EDErS35Mm7wqMMzFlMsEsFVzl/bsgeje0lGbPtkN1WVguus6lCZOyyasntzLNhKn5hbJiIHGfJ4mKAb6XPu9lqpZZNFDNKhI3h1HoYH16UVQcXcEafco8SifjaaL/35s4bb6xSd9hziDHUow4kqag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=svshDtxdWN2s21Wp+aLP/i0FD33vykjikRArmQiPEp8=; b=bBSzF4aP1ISPTRA5xsyIG9DfiihhOYsWk9aWJjS7pJDxp1A7jIvzVmiWy+zzDLnLfWuGvEBeLCQqPpxPz/7q2mlERfriGMFMf4Uy3aGsM55sFDbTOzCtIL/+q9vMmk0Q7nkO+/1DP3hJx/PSKvWyWakuicTXBzVg+Zvt3PUzrupaCqilG47MxoDxofPE2mg206qXLK3CWHfKi2ZTSpyeKsCn/GhrYFJ1ZTHnfX0TaMRe9oa9crNzQeUPPtIk+1AoqIzQ11ow4b9FZ0/1BejFPe8PWlM291GepexJckrQ21+NgOJZLMciSF6H4whMkZMI8kkugWjAwVYvJfYVC8OULw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svshDtxdWN2s21Wp+aLP/i0FD33vykjikRArmQiPEp8=; b=jWDtVlsW1PkiLOmvOb6OIdWDio9eoUFjKcSPXB1xZUmrIDZqKoMoJWtxk7oLd297BezPM7cwcx8cNGka2F3CzyQt/sk1dSyu1wHzOLTQza41PZmtxmt33K7NLEUT0kGldqwpDMqqRffhat61Onz2xgmZJerCY0C07Hj3SWHx3lY= From: Henry Wang To: George Dunlap , Andrew Cooper CC: Andrew Cooper , Xen-devel , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: RE: [PATCH] Changelog: Add details about new features for SPR Thread-Topic: [PATCH] Changelog: Add details about new features for SPR Thread-Index: AQHZLRqZNJwiiBkqnku+FjPpsLRxRa6yKKGwgATxtwCAAuUMgIAA90ow Date: Thu, 2 Feb 2023 02:04:53 +0000 Message-ID: References: <20230120220004.7456-1-andrew.cooper3@citrix.com> <9abcfc06-1401-cdb7-a1f1-670cd307a593@srcf.net> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5744EA9EC61DB146A3D38AADF5D99964.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB7944:EE_|AM7EUR03FT023:EE_|PAWPR08MB10133:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c7f153a-b530-431f-1792-08db04c1e5db x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?/5ZbOihbcrF5JLldV+6iEPuVVjwVkcfoAlvOXzUjf/vLNnPNkQU+SE9B3gXL?= =?us-ascii?Q?KSIw/p0I5j0w7mKPWUead9YosExnCm1CKwYUlSlvI50f05BZMT7UJddqA7OH?= =?us-ascii?Q?At6MMi+pz9x8lqw8lZ6rnNdTJ3kQHqXjeEii0xMTK9wtXCT+xacrErfjt5vJ?= =?us-ascii?Q?XtFynPfVCuq64PYaDT7Nes4IRKSmZaVluZ+5poXQMieq6fI7z/MI1r/HuPw4?= =?us-ascii?Q?WQrS+1IoSk44zgk2YD/i0QnUqBoHjznPmISEVqDOzvs01tmbKYloigNG8RQo?= =?us-ascii?Q?YwZPcked86ncBsBb47m6fWsKzpR5/TKpYEbH+DyJXZUGkGAi1jjJzRdRYKqY?= =?us-ascii?Q?fHp8H9yPRy7GEm91+hZ4pnGV+VxutJ9KNs76sCxRrRwhD52Wyj7g+O9d8YAe?= =?us-ascii?Q?wmnsu1wT087fCr9qY0HcjKyCJbA4x6wAPzUe0SHgJpHpSBIuEpn+7qcYh21X?= =?us-ascii?Q?p0LkbZgdGAczr2Ou7Wfm+Y2vG3ilB41E23lWXRuVGE3zidLvLKrQRIwsRuBE?= =?us-ascii?Q?dO+HpbmR+/VUN6rTlasmaW6pl1n2lIGGFII170CbQAlDZvzkWH5OxEWIvtz0?= =?us-ascii?Q?jGDAkTE6gHMMJ9w/mDJMp+WOQxZz6oZLFRMMzSfJJJ+K8AVgNR9/XuPDlk9j?= =?us-ascii?Q?FA1egtR9Mj3C4bl+gx+yW9hShdJgUqpuhkDFhYobQVEHG0oKH5OCNh6zR2Pm?= =?us-ascii?Q?kU8ar8blBj2MaNbdRH7FW0PMMgDo4eeuU9Z9h6y0lNpCzkgNPfl0nmc2bVuT?= =?us-ascii?Q?KcTu1DF6vlTS5UTkmQJGW9PvWm8VOR0qO5fvBIjdFS5daTR4yo9lGtIKVxzr?= =?us-ascii?Q?Fuxu+JYjqMc3it95AaOcX21XsPqQAJn483kVOYrHb6lqqygDKFRFtc2Qclso?= =?us-ascii?Q?rb8IiMpnlqUcg15dNK8bjtpd4ajGlyURduFJz+OENRZ534y5EI0wPFq4e4+i?= =?us-ascii?Q?CfFE5SwuqjK0PsUfz11qYADx5unnQEAAXf+UsUi2rc7jm7qbEH1GfEeFT555?= =?us-ascii?Q?yo2WKZEukdUx/08ElnKXnUVGd5qEHa+CrOVxQt6TaSP6WgYHXF3Uj8uUS6lp?= =?us-ascii?Q?VfBzexsipRdXs/3RUaQ2VTKXsKHf1y9heBWLewdP7ugXPQpYkhvkWwos+7Ah?= =?us-ascii?Q?jJYxWZ018xy/HhUPvs5qB1xaRiMVa9U8g1wUOBOx82HwwpbWshaNmMs=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:5;SRV:;IPV:NLI;SFV:SPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:OSPM;SFS:(13230025)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199018)(66899018)(9686003)(83380400001)(38070700005)(2906002)(26005)(186003)(6506007)(86362001)(5660300002)(4326008)(33656002)(41300700001)(71200400001)(7696005)(478600001)(122000001)(55016003)(110136005)(76116006)(66946007)(9326002)(316002)(8676002)(8936002)(52536014)(66556008)(54906003)(66446008)(38100700002)(66476007)(64756008)(71176010)(59356011)(207903002);DIR:OUT;SFP:1501; Content-Type: multipart/alternative; boundary="_000_AS8PR08MB7991C8898F8008BB64E4DCB092D69AS8PR08MB7991eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7944 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b8611f22-328d-4c8a-f6e5-08db04c1e01e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkMremlCa29kUytUcXpvQkxLMlhZVnBRL0t1bGNibFRoS3BMME40QW52dzYv?= =?utf-8?B?UDdScmhRRCtvWk5LWUNJWVcwemN2cTl0dE1qNGo0UzhEZSt4NDRpVENmQkVo?= =?utf-8?B?b21VdHNjdVM3NUlkaEFZeXdBeHBiODlOR3NWNTR3aFVIL2hiVnhHVmFSemhh?= =?utf-8?B?VlQxSkEyOGN3dElJTVA4MTBHSk5BV25BMUhrT0VYZy9GZUtidjFrMHVpQXFs?= =?utf-8?B?R0QySzY1bTN6Q1R6dFUwNEdtSXV2b1RjUG03dmk2NHlrMzFLSHp3RTBTTWRK?= =?utf-8?B?L2MzM2ZGQk1kS3o4SCtvaEluZkpTYXl1bTl4T0dDeXYwcFJteXhwRkNyM2Rq?= =?utf-8?B?UEhlSXVEcU5tdjJFeEc0eFBDQ2M0eCtlYWhYcVFJbEs5QWViRHFzM0g4UmFx?= =?utf-8?B?bkREMUZxbkJMeGRyVWZQM09xSm9wU2U4aUV0Z29kcEprMGJwM1l0L2NGVTd5?= =?utf-8?B?RzZqdDl6cWhON2dIVVgveWx2Z0x6cC9DQUpURXhQd1FSQ1NHWkZtUVluckRN?= =?utf-8?B?NVg4Rmh1cEMyaVJ3WXVUNnFrQ1lNQ0VjVGZZQTBUQVF4bTlvY0Fmd1IxWGpB?= =?utf-8?B?WVVQbnZNUHNnbk9leUI0dXJnSlN2YVVPczBWK0NhZHBZejdvTHZrSmovckZa?= =?utf-8?B?UERQWC9rQkh5ZkF6M0FSK2I3RkxQazVVTVRyMGpyWDhEYThkWDFWMis1dU1m?= =?utf-8?B?RndGbksvZUpQLzV6aVBGWFlRWnplOUpJTy9SNzlkbENscUNIK3NERTIza1V2?= =?utf-8?B?dXNqWWdYUHVPcGhOR2NIMjZ0cnhncXdnMGh2cUNxWTVZeGc1TERacnhPdkUz?= =?utf-8?B?cjBvYXROOXdrUWc2cytlejQyR0M2d2szMmxwQllydjVtSWppZ1NvaDJlbzdR?= =?utf-8?B?U0lMenoxRjRPQ2RZc2VMRng3bFJjL0NYc1o2T1hrOTgrMzNCZzY1RTAwL1Bh?= =?utf-8?B?SVY2aEZHRytmUE11MGJPbjNXbTZXUmswRUNwejJRdERTR3h1WUk2QjBTd2lJ?= =?utf-8?B?MFlES3FXSUw5Q0dFd0taYXJkeUM1dGVFeTdkUDRsTmxnUWNCRmtKR3BjaEd4?= =?utf-8?B?bTM1Tm9lTThDYzhkV1BmOUYzRm10aHA2bk41L3RqaGhMSS9HckNMenVvcEZC?= =?utf-8?B?MS9KcnExQS9Na3pZWGtjcXo4RUovUVUvWWx1MmRJS3p4TUNPckVHNGY1NkxP?= =?utf-8?B?dmJOL20rK3lTR2FoSnliNlhOWFpwYlJlMVpCNVJybDluZFRkSURoRVYzNDFR?= =?utf-8?B?Zzd4MmZxaDBRRm9tRWdNVmdBRmNZSThXanVuNEVoalVNVEZSbEJTS0pIZkVT?= =?utf-8?B?WnJ4YnNRM2lPaW16TEFYQzZhL0JaS3ZLREFYMUEyc1BMb3AxbXFxZHVWemxC?= =?utf-8?B?Zkt3cDJFeVV5akd4SWsybHpXUEYyc2NoL0o2NkIxVWZuVEpYWElGS2V3MVIr?= =?utf-8?B?NTNuOExoM3QwRmJVS2lWMEFrWkw4WlR3Y09RTC9ValVtSWRLTHEwb0RCMk5L?= =?utf-8?B?Qkl6RXVpZEZXSm53L3cySmllenJQcGRzWlJTNnpKa3pXcThLRWRRUFhIMVRK?= =?utf-8?B?M2U3UT09?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:5;SRV:;IPV:CAL;SFV:SPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:OSPM;SFS:(13230025)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199018)(40470700004)(46966006)(36840700001)(66899018)(47076005)(83380400001)(36860700001)(6506007)(2906002)(186003)(9686003)(26005)(33964004)(86362001)(8676002)(33656002)(4326008)(82310400005)(41300700001)(7696005)(478600001)(5660300002)(40480700001)(82740400003)(496002)(110136005)(356005)(336012)(70206006)(55016003)(70586007)(316002)(52536014)(54906003)(9326002)(81166007)(40460700003)(8936002)(71196009)(71176010);DIR:OUT;SFP:1501; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 02:05:03.3816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7f153a-b530-431f-1792-08db04c1e5db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10133 --_000_AS8PR08MB7991C8898F8008BB64E4DCB092D69AS8PR08MB7991eurp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgR2VvcmdlLA0KDQo+IEZyb206IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2xvdWQu Y29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBDaGFuZ2Vsb2c6IEFkZCBkZXRhaWxzIGFib3V0 IG5ldyBmZWF0dXJlcyBmb3IgU1BSDQo+DQo+IE9uZSBhcHByb2FjaCB3b3VsZCBiZSB0byBoYXZl IHNvbWVvbmUgLyBzb21ldGhpbmcgKGVpdGhlciB0aGUgcmVsZWFzZSBtYW5hZ2VyLCBvciBhbiBh dXRvbWF0ZWQgc2NyaXB0KQ0KDQpBbiBhdXRvbWF0ZWQgc2NyaXB0IHdvdWxkIGJlIGJlc3QgaWYg cG9zc2libGUgSU1ITywgYXMgdGhlIGVtYWlsDQpjb250ZW50IHdvdWxkIGJlIHByZXR0eSBtdWNo IGZpeGVkL3ByZWRpY3RhYmxlIGFuZCB0aGUgZW1haWwgaXMNCnNlbnQgcGVyaW9kaWNhbGx5Lg0K DQo+IHBlcmlvZGljYWxseSAobW9udGhseT8gIEJpLXdlZWtseT8pIGVtYWlsIGVhY2ggbWFpbnRh aW5lciBhIGxpc3Qgb2YgdGhlIGNvbW1pdHMgdW5kZXIgdGhlaXIgcmVtaXQsIHdpdGggYW4gZW5j b3VyYWdlbWVudCB0byBjb25zaWRlciB3aGF0IGVudHJpZXMgY291bGQgYmUgYWRkZWQgdG8gQ0hB TkdFTE9HLm1kLiAgaS5lLiwgc29tZXRoaW5nIGxpa2UgdGhpczoNCj4NCj4gODwtLS0NCj4gRGVh ciAkTUFJTlRBSU5FUl9OQU1FLA0KPg0KPiBEdXJpbmcgdGhlIGxhc3QgJFRJTUVfUEVSSU9ELCB0 aGUgY29tbWl0cyBiZWxvdyBoYXZlIGJlZW4gY2hlY2tlZCBpbnRvIHRoZSB0cmVlIHdoaWNoIG1v ZGlmeSBjb2RlIHVuZGVyIHlvdXIgbWFpbnRhaW5lcnNoaXAuICBQbGVhc2UgZW5zdXJlIHRoYXQg bmVjZXNzYXJ5IGNoYW5nZXMgdG8gQ0hBTkdFTE9HLm1kIGhhdmUgYWxzbyBiZWVuIGNvbWl0dGVk Lg0KPg0KPiBUaGFua3MsDQo+ICRTRU5ERVINCj4NCj4gJEdJVF9MT0cNCj4gLS0tLT44DQo+DQo+ IElkZWFsbHkgdGhpcyB3b3VsZCBwcm9tcHQgbWFpbnRhaW5lcnMgdG8gZ2V0IGludG8gdGhlIGhh Yml0IG9mIGFsd2F5cyBhc2tpbmcgZm9yIENIQU5HRUxPRyBlbnRyaWVzIHRvIGJlIGFkZGVkIGR1 cmluZyByZXZpZXcgKHdoaWNoIHdvdWxkIGFsc28gZ2V0IGRldmVsb3BlcnMgaW50byB0aGUgaGFi aXQgb2YgYWx3YXlzIGluY2x1ZGluZyB0aGVtKTsgYXQgd2hpY2ggcG9pbnQgdGhlIG1haW50YWlu ZXJzIGNvdWxkIGp1c3Qgc2tpbSB0aGUgY29tbWl0cyBpbiB0aGUgZW1haWwgYW5kIG9ubHkgYWRk IGhlIG9kZCBDSEFOR0VMT0cgdGhhdCB0aGV5IG1heSBoYXZlIGZvcmdvdHRlbi4NCj4NCj4gVGhv dWdodHM/DQoNCkkgbGlrZSB0aGlzIGlkZWEgdmVyeSBtdWNoIDopIEp1c3QgYSBzbWFsbCBxdWVz dGlvbjogQXMgYSBkZXZlbG9wZXIsIGl0IGlzDQpub3QgcmVhbGx5IGNsZWFyIHRvIG1lIHRoYXQg dW5kZXIgd2hhdCBjcml0ZXJpYSB3b3VsZCBhIHBhdGNoL3Nlcmllcw0KZGVzZXJ2ZSBmb3IgYSBj aGFuZ2Vsb2cgZW50cnkuIFBlcnNvbmFsbHkgSSB3b3VsZCB0cnkgdG8gaW5jbHVkZSB0aGUNCkNI QU5HRUxPRyBpbnRvIG15IGNoYW5nZXMgaW4gdGhlIGZ1dHVyZSBpZiB0aGlzIGNyaXRlcmlhIGlz IGNsZWFyZWQuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4NCj4gIC1HZW9yZ2UNCg== --_000_AS8PR08MB7991C8898F8008BB64E4DCB092D69AS8PR08MB7991eurp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 PGh0bWwgeG1sbnM6dj0idXJuOnNjaGVtYXMtbWljcm9zb2Z0LWNvbTp2bWwiIHhtbG5zOm89InVy bjpzY2hlbWFzLW1pY3Jvc29mdC1jb206b2ZmaWNlOm9mZmljZSIgeG1sbnM6dz0idXJuOnNjaGVt YXMtbWljcm9zb2Z0LWNvbTpvZmZpY2U6d29yZCIgeG1sbnM6bT0iaHR0cDovL3NjaGVtYXMubWlj cm9zb2Z0LmNvbS9vZmZpY2UvMjAwNC8xMi9vbW1sIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv VFIvUkVDLWh0bWw0MCI+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIg Y29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjxtZXRhIG5hbWU9IkdlbmVyYXRv ciIgY29udGVudD0iTWljcm9zb2Z0IFdvcmQgMTUgKGZpbHRlcmVkIG1lZGl1bSkiPg0KPHN0eWxl PjwhLS0NCi8qIEZvbnQgRGVmaW5pdGlvbnMgKi8NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6 IkNhbWJyaWEgTWF0aCI7DQoJcGFub3NlLTE6MiA0IDUgMyA1IDQgNiAzIDIgNDt9DQpAZm9udC1m YWNlDQoJe2ZvbnQtZmFtaWx5OkRlbmdYaWFuOw0KCXBhbm9zZS0xOjIgMSA2IDAgMyAxIDEgMSAx IDE7fQ0KQGZvbnQtZmFjZQ0KCXtmb250LWZhbWlseTpDYWxpYnJpOw0KCXBhbm9zZS0xOjIgMTUg NSAyIDIgMiA0IDMgMiA0O30NCkBmb250LWZhY2UNCgl7Zm9udC1mYW1pbHk6IlxARGVuZ1hpYW4i Ow0KCXBhbm9zZS0xOjIgMSA2IDAgMyAxIDEgMSAxIDE7fQ0KLyogU3R5bGUgRGVmaW5pdGlvbnMg Ki8NCnAuTXNvTm9ybWFsLCBsaS5Nc29Ob3JtYWwsIGRpdi5Nc29Ob3JtYWwNCgl7bWFyZ2luOjBp bjsNCglmb250LXNpemU6MTEuMHB0Ow0KCWZvbnQtZmFtaWx5OiJDYWxpYnJpIixzYW5zLXNlcmlm O30NCnNwYW4uRW1haWxTdHlsZTE5DQoJe21zby1zdHlsZS10eXBlOnBlcnNvbmFsLXJlcGx5Ow0K CWZvbnQtZmFtaWx5OiJDYWxpYnJpIixzYW5zLXNlcmlmOw0KCWNvbG9yOndpbmRvd3RleHQ7fQ0K Lk1zb0NocERlZmF1bHQNCgl7bXNvLXN0eWxlLXR5cGU6ZXhwb3J0LW9ubHk7DQoJZm9udC1zaXpl OjEwLjBwdDsNCglmb250LWZhbWlseToiQ2FsaWJyaSIsc2Fucy1zZXJpZjt9DQpAcGFnZSBXb3Jk U2VjdGlvbjENCgl7c2l6ZTo4LjVpbiAxMS4waW47DQoJbWFyZ2luOjEuMGluIDEuMGluIDEuMGlu IDEuMGluO30NCmRpdi5Xb3JkU2VjdGlvbjENCgl7cGFnZTpXb3JkU2VjdGlvbjE7fQ0KLS0+PC9z dHlsZT48IS0tW2lmIGd0ZSBtc28gOV0+PHhtbD4NCjxvOnNoYXBlZGVmYXVsdHMgdjpleHQ9ImVk aXQiIHNwaWRtYXg9IjEwMjYiIC8+DQo8L3htbD48IVtlbmRpZl0tLT48IS0tW2lmIGd0ZSBtc28g OV0+PHhtbD4NCjxvOnNoYXBlbGF5b3V0IHY6ZXh0PSJlZGl0Ij4NCjxvOmlkbWFwIHY6ZXh0PSJl ZGl0IiBkYXRhPSIxIiAvPg0KPC9vOnNoYXBlbGF5b3V0PjwveG1sPjwhW2VuZGlmXS0tPg0KPC9o ZWFkPg0KPGJvZHkgbGFuZz0iRU4tVVMiIGxpbms9ImJsdWUiIHZsaW5rPSJwdXJwbGUiIHN0eWxl PSJ3b3JkLXdyYXA6YnJlYWstd29yZCI+DQo8ZGl2IGNsYXNzPSJXb3JkU2VjdGlvbjEiPg0KPHAg Y2xhc3M9Ik1zb05vcm1hbCI+SGkgR2VvcmdlLDxvOnA+PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1z b05vcm1hbCI+PG86cD4mbmJzcDs8L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4mZ3Q7 IEZyb206IEdlb3JnZSBEdW5sYXAgJmx0O2dlb3JnZS5kdW5sYXBAY2xvdWQuY29tJmd0OyA8bzpw PjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiZndDsgU3ViamVjdDogUmU6IFtQQVRD SF0gQ2hhbmdlbG9nOiBBZGQgZGV0YWlscyBhYm91dCBuZXcgZmVhdHVyZXMgZm9yIFNQUjxvOnA+ PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OzxvOnA+Jm5ic3A7PC9vOnA+PC9w Pg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyBPbmUgYXBwcm9hY2ggd291bGQgYmUgdG8gaGF2 ZSBzb21lb25lIC8gc29tZXRoaW5nIChlaXRoZXIgdGhlIHJlbGVhc2UgbWFuYWdlciwgb3IgYW4g YXV0b21hdGVkIHNjcmlwdCkNCjxvOnA+PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+ PG86cD4mbmJzcDs8L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5BbiBhdXRvbWF0ZWQg c2NyaXB0IHdvdWxkIGJlIGJlc3QgaWYgcG9zc2libGUgSU1ITywgYXMgdGhlIGVtYWlsPG86cD48 L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5jb250ZW50IHdvdWxkIGJlIHByZXR0eSBt dWNoIGZpeGVkL3ByZWRpY3RhYmxlIGFuZCB0aGUgZW1haWwgaXM8bzpwPjwvbzpwPjwvcD4NCjxw IGNsYXNzPSJNc29Ob3JtYWwiPnNlbnQgcGVyaW9kaWNhbGx5LiA8bzpwPjwvbzpwPjwvcD4NCjxw IGNsYXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05v cm1hbCI+Jmd0OyBwZXJpb2RpY2FsbHkgKG1vbnRobHk/Jm5ic3A7IEJpLXdlZWtseT8pIGVtYWls IGVhY2ggbWFpbnRhaW5lciBhIGxpc3Qgb2YgdGhlIGNvbW1pdHMgdW5kZXIgdGhlaXIgcmVtaXQs IHdpdGggYW4gZW5jb3VyYWdlbWVudCB0byBjb25zaWRlciB3aGF0IGVudHJpZXMgY291bGQgYmUg YWRkZWQgdG8gQ0hBTkdFTE9HLm1kLiZuYnNwOyBpLmUuLCBzb21ldGhpbmcgbGlrZSB0aGlzOjxv OnA+PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OzxvOnA+Jm5ic3A7PC9vOnA+ PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyA4Jmx0Oy0tLTxvOnA+PC9vOnA+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyBEZWFyICRNQUlOVEFJTkVSX05BTUUsPG86cD48L286 cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4mZ3Q7PG86cD4mbmJzcDs8L286cD48L3A+DQo8 cCBjbGFzcz0iTXNvTm9ybWFsIj4mZ3Q7IER1cmluZyB0aGUgbGFzdCAkVElNRV9QRVJJT0QsIHRo ZSBjb21taXRzIGJlbG93IGhhdmUgYmVlbiBjaGVja2VkIGludG8gdGhlIHRyZWUgd2hpY2ggbW9k aWZ5IGNvZGUgdW5kZXIgeW91ciBtYWludGFpbmVyc2hpcC4mbmJzcDsgUGxlYXNlIGVuc3VyZSB0 aGF0IG5lY2Vzc2FyeSBjaGFuZ2VzIHRvIENIQU5HRUxPRy5tZCBoYXZlIGFsc28gYmVlbiBjb21p dHRlZC48bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiZndDs8bzpwPiZuYnNw OzwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiZndDsgVGhhbmtzLDxvOnA+PC9vOnA+ PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyZuYnNwOyRTRU5ERVI8bzpwPjwvbzpwPjwv cD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPiZndDs8bzpwPiZuYnNwOzwvbzpwPjwvcD4NCjxwIGNs YXNzPSJNc29Ob3JtYWwiPiZndDsgJEdJVF9MT0c8bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJN c29Ob3JtYWwiPiZndDsgLS0tLSZndDs4PG86cD48L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9y bWFsIj4mZ3Q7PG86cD4mbmJzcDs8L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj4mZ3Q7 IElkZWFsbHkgdGhpcyB3b3VsZCBwcm9tcHQgbWFpbnRhaW5lcnMgdG8gZ2V0IGludG8gdGhlIGhh Yml0IG9mIGFsd2F5cyBhc2tpbmcgZm9yIENIQU5HRUxPRyBlbnRyaWVzIHRvIGJlIGFkZGVkIGR1 cmluZyByZXZpZXcgKHdoaWNoIHdvdWxkIGFsc28gZ2V0IGRldmVsb3BlcnMgaW50byB0aGUgaGFi aXQgb2YgYWx3YXlzIGluY2x1ZGluZyB0aGVtKTsgYXQgd2hpY2ggcG9pbnQgdGhlIG1haW50YWlu ZXJzIGNvdWxkDQoganVzdCBza2ltIHRoZSBjb21taXRzIGluIHRoZSBlbWFpbCBhbmQgb25seSBh ZGQgaGUgb2RkIENIQU5HRUxPRyB0aGF0IHRoZXkgbWF5IGhhdmUgZm9yZ290dGVuLjxvOnA+PC9v OnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OzxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyBUaG91Z2h0cz88bzpwPjwvbzpwPjwvcD4NCjxwIGNs YXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1h bCI+SSBsaWtlIHRoaXMgaWRlYSB2ZXJ5IG11Y2ggOikgSnVzdCBhIHNtYWxsIHF1ZXN0aW9uOiBB cyBhIGRldmVsb3BlciwgaXQgaXM8bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi Pm5vdCByZWFsbHkgY2xlYXIgdG8gbWUgdGhhdCB1bmRlciB3aGF0IGNyaXRlcmlhIHdvdWxkIGEg cGF0Y2gvc2VyaWVzPG86cD48L286cD48L3A+DQo8cCBjbGFzcz0iTXNvTm9ybWFsIj5kZXNlcnZl IGZvciBhIGNoYW5nZWxvZyBlbnRyeS4gUGVyc29uYWxseSBJIHdvdWxkIHRyeSB0byBpbmNsdWRl IHRoZTxvOnA+PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Q0hBTkdFTE9HIGludG8g bXkgY2hhbmdlcyBpbiB0aGUgZnV0dXJlIGlmIHRoaXMgY3JpdGVyaWEgaXMgY2xlYXJlZC48bzpw PjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwiPjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0K PHAgY2xhc3M9Ik1zb05vcm1hbCI+S2luZCByZWdhcmRzLDxvOnA+PC9vOnA+PC9wPg0KPHAgY2xh c3M9Ik1zb05vcm1hbCI+SGVucnk8bzpwPjwvbzpwPjwvcD4NCjxwIGNsYXNzPSJNc29Ob3JtYWwi PjxvOnA+Jm5ic3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OzxvOnA+Jm5i c3A7PC9vOnA+PC9wPg0KPHAgY2xhc3M9Ik1zb05vcm1hbCI+Jmd0OyAmbmJzcDstR2VvcmdlPG86 cD48L286cD48L3A+DQo8L2Rpdj4NCjwvYm9keT4NCjwvaHRtbD4NCg== --_000_AS8PR08MB7991C8898F8008BB64E4DCB092D69AS8PR08MB7991eurp_-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 02:13:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 02:13:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488500.756602 (Exim 4.92) (envelope-from ) id 1pNP6k-0004n5-MW; Thu, 02 Feb 2023 02:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488500.756602; Thu, 02 Feb 2023 02:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNP6k-0004my-Jk; Thu, 02 Feb 2023 02:13:50 +0000 Received: by outflank-mailman (input) for mailman id 488500; Thu, 02 Feb 2023 02:13:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNP6j-0004ms-Er for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 02:13:49 +0000 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [2607:f8b0:4864:20::f34]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3a0c366f-a29f-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 03:13:48 +0100 (CET) Received: by mail-qv1-xf34.google.com with SMTP id x18so237884qvl.1 for ; Wed, 01 Feb 2023 18:13:48 -0800 (PST) Received: from localhost ([64.18.11.67]) by smtp.gmail.com with ESMTPSA id d12-20020a05620a204c00b007201df7ff47sm6813568qka.45.2023.02.01.18.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 18:13:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a0c366f-a29f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koconnor.net; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Mqmz7hu2G9r/RJV/8jS2mx0R656hA6RTcJf6/8HTqaY=; b=baI0Ri1uaTAy7OVcrgqlkjfEVxnbv/d/D57DrefkM6vzmBFg5cMAFSunTAKp3qNWSF 0rb5BWRrxTsAX3ih7Ln+hhctf7eRxPFKVT+V0CmQ/GIbejuBhxNXgIBNu4MZc0jAW6e9 NK0wp3ROS8bNgUAhpDS98ROaEGLM0zGqVCO5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mqmz7hu2G9r/RJV/8jS2mx0R656hA6RTcJf6/8HTqaY=; b=tyrNhoZ154WIFZF7EG1QVkSP7WfXHvU8Qcw6oPeC0rXbCOFF11B7iHm8sv25jlLH+Q E9uwDhJkujDri3qr5YIFzhrHHZ3wqhnEhez/17Ram8cPft5Oo4q7lD6iR5LruTlCFohW qFSa0r4nmjT3mkHfgbgjVE4WJzNAp6kWAd1ZtG6Xjfu7VdEZEWWJangrg//Naoaz0cEc 4jeOXIndJrHBftJMgQSeXbjshRaoqWmpn2Pr7j9YlbxY/CgVFi3koQYbtGTMBxAyNQD3 bV7xFjrMGnGgJZJbDbpP26qOS1cYu0BOsXPPGSbtwI/bYPZLKYbfVJlX2Sbypn5NNvLV XZdg== X-Gm-Message-State: AO0yUKV5KlThGd9Z43HPqLw0EBH4KkYm/Ad0r20AVAbQPdGgobEo0I2A DhTniv7/bjmHVJfJMHlZtf30xQ== X-Google-Smtp-Source: AK7set81ROSrZYyNA3Puq1cqPfaXketVTob01gsC5RRs9n4SXF9f3GSnPc5BNKsdHUb/wxPFQQbCUQ== X-Received: by 2002:a0c:fa07:0:b0:53a:3a20:4200 with SMTP id q7-20020a0cfa07000000b0053a3a204200mr6544477qvn.31.1675304027070; Wed, 01 Feb 2023 18:13:47 -0800 (PST) Date: Wed, 1 Feb 2023 21:13:45 -0500 From: Kevin O'Connor To: David Woodhouse Cc: seabios , xen-devel , qemu-devel , paul Subject: Re: [SeaBIOS] [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 20, 2023 at 11:33:19AM +0000, David Woodhouse wrote: > From: David Woodhouse > > When running under Xen, hvmloader places a table at 0x1000 with the e820 > information and BIOS tables. If this isn't present, SeaBIOS will > currently panic. > > We now have support for running Xen guests natively in QEMU/KVM, which > boots SeaBIOS directly instead of via hvmloader, and does not provide > the same structure. > > As it happens, this doesn't matter on first boot. because although we > set PlatformRunningOn to PF_QEMU|PF_XEN, reading it back again still > gives zero. Presumably because in true Xen, this is all already RAM. But > in QEMU with a faithfully-emulated PAM config in the host bridge, it's > still in ROM mode at this point so we don't see what we've just written. > > On reboot, however, the region *is* set to RAM mode and we do see the > updated value of PlatformRunningOn, do manage to remember that we've > detected Xen in CPUID, and hit the panic. > > It's not trivial to detect QEMU vs. real Xen at the time xen_preinit() > runs, because it's so early. We can't even make a XENVER_extraversion > hypercall to look for hints, because we haven't set up the hypercall > page (and don't have an allocator to give us a page in which to do so). > > So just make Xen detection contingent on the info structure being > present. If it wasn't, we were going to panic anyway. That leaves us > taking the standard QEMU init path for Xen guests in native QEMU, > which is just fine. Thanks. I committed this change. -Kevin From xen-devel-bounces@lists.xenproject.org Thu Feb 02 02:46:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 02:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488505.756614 (Exim 4.92) (envelope-from ) id 1pNPc7-00019K-5r; Thu, 02 Feb 2023 02:46:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488505.756614; Thu, 02 Feb 2023 02:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNPc7-00019D-35; Thu, 02 Feb 2023 02:46:15 +0000 Received: by outflank-mailman (input) for mailman id 488505; Thu, 02 Feb 2023 02:46:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNPc5-00018w-Gt; Thu, 02 Feb 2023 02:46:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNPc5-0004Ls-FC; Thu, 02 Feb 2023 02:46:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNPc5-00088K-3I; Thu, 02 Feb 2023 02:46:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNPc5-0007qv-2V; Thu, 02 Feb 2023 02:46:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=79HsdhJe+iwcOhKDU/HbMSdnCXLcIZhXg851VyGCAFA=; b=0ZQTAU44P5OWx21nAAZDf0rGZd BGsdH8AHozA/G3InEAaE6Z21+VddR5eTg5ClnGgysCLaVdvnLGX52CozV29ZRrOt58l2CILE2KwqX gbWJ+NVpSjjQaLsMUutjdU2p4fMlo0UU0pB+J9oj1UJn3Yp2cW+91L9UldZZUnTMU8j8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176320: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 02:46:13 +0000 flight 176320 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176320/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 03:47:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 03:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488515.756625 (Exim 4.92) (envelope-from ) id 1pNQZQ-00016Y-Tm; Thu, 02 Feb 2023 03:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488515.756625; Thu, 02 Feb 2023 03:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNQZQ-00016R-R1; Thu, 02 Feb 2023 03:47:32 +0000 Received: by outflank-mailman (input) for mailman id 488515; Thu, 02 Feb 2023 03:47:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNQZO-00015z-SG for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 03:47:31 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e9d9d41-a2ac-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 04:47:28 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 19:47:15 -0800 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 01 Feb 2023 19:47:14 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 19:47:14 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 19:47:14 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 19:47:13 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by SN7PR11MB7091.namprd11.prod.outlook.com (2603:10b6:806:29a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 03:47:11 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 03:47:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e9d9d41-a2ac-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675309648; x=1706845648; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BE+zvSmVO6w/55TnSEmoRkCo49DJVphCeVu/vQLoedw=; b=barx7AsaHGQQTQGcj5O9hrd1UGVHjt6CXaGogYKW/cCj0+wDUWDUHIWP nlxbqTbVLFmnd6NOD1pmpvqBMeidS840POEIVtui15ZRQ7Kwl47tcLEWX DWE/Jyg2w55S45rxNU+jlAfHQiiqrKo5FoT2dL14Opg59PkvSvPtP2dtF AFyWmeheIxNPxiGtcwNbJTQHv1lfP+0r3CfspTX6uaHY/WwBPYy9u3mOi awqbr3WmsVaFjv4iAFXJJTw7DlaV7+YAZ87KdY2C+lLiwY8UFn1Co95E0 iLSNRdhbE0Q3oriIdosvfQSEzkpYMBTc3Uraq1y1URnFQOqLYT4L2iAVV g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="414548889" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="414548889" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="697543012" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="697543012" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWAe8qafv9lh/kmrSXmGCPkPOYYmM9JRAZeSuaQGYBVeuU1h5NDJ/ym4/EEx09y6JrzlGlZti/AcVvoOzuneyI+9rEACjJoC0S7DveWp/juINwv7nTPjkuI+VFLyvRC6xPbaD+aRZSAEY83TtO1SOsr+CzPqrb9a/0uP96jUQ0pZpfWWt4PlEKtiuTihyr6m7NhMIquCDG0UTG9KK+rQFp7W7xMutKYkzTB6Q/2AyVAdpCIzGEVhQKHOaK91T2xxCPNo2IwIUrW8tR+jhaG3VwIG65qw5jzpDPSFt0LsRRlzGZ3IhAgtHJ0DWiBvKho99zluBSicNPVNDjV/vu2N0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BE+zvSmVO6w/55TnSEmoRkCo49DJVphCeVu/vQLoedw=; b=b+Ob07ObT3VWL4Z9Pco2DLGvpuj7s63HwibTxGli0DSR0ZjlnoZdGHwcARvy030ukMG9thiBRUVK9jAAsV0PJMG69ogHqZ/tE2wPITf4smcoCh2/hHXVsJM7KOXjcgetaJK/Sqjsdhgdozs5HWQ7Ft/1AUuXUTtJkomvfCeaRj9gE3T3ae6ecmnynwyLlgINCjkLnm5c41tZInSx3XLgGK1X98fYZIABtjT/1hppgQjzHvSODh5hLhM2rtCrLpmtfymw7e3JSgSI0xpTmJr60J32Act/LzralmO+Y/0dqC9kfi3GJWgKWUr/tJGih44Thk7dn820R0w9c7smXCEjwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Beulich, Jan" CC: Paul Durrant , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , Xenia Ragiadakou , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Thread-Topic: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific Thread-Index: AQHZL/FVJOdom3IWD0Wag5ryo7ERT665k35wgABMM4CAATJKcA== Date: Thu, 2 Feb 2023 03:47:11 +0000 Message-ID: References: <20230124124142.38500-1-burzalodowa@gmail.com> <20230124124142.38500-3-burzalodowa@gmail.com> <34649fa5-4676-1e45-e1cc-ea57d7027c5f@suse.com> In-Reply-To: <34649fa5-4676-1e45-e1cc-ea57d7027c5f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|SN7PR11MB7091:EE_ x-ms-office365-filtering-correlation-id: be52e16a-b4d7-461a-a9ee-08db04d02a47 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ikKm38PK6HpSEQ0SwUav2FjBc5DPxaXXxENpaE8QtzVAvpjLEqwdrByrlFWhFEp6AffpdQ2MWnedPcpVkCGoxfzu2UFQKoyJndjiokhz4z/qplTUCZ5UELfaSf0iHp5XbtLjtRLp4s8MwJ7HoplesgTy79AJdOVMiKQwdlU7/f2kARmGQEbrz8Z6BE5S7kpLoA+jDBQ6wrmGoyeWbACHXnET5FUaVAk8NI8Y2qkuAhPArTgxkEyBL3GhapD5/C2toJsV7k83YgFh1Us3Ur6wyZ/KMzQDK3u4xSvj/2WUdCxHxWLmGwQR/XeqIGeoyVfXQvoihnwuV/9+TWcwi9c8qHw8Gy2OAUr/MIZ14kO1TktwN6metq4x60QyAXVy885W0P4oclzD4obwS944IfG/ny/Ffp9Ef1sQQPABHrBOUmusTy1UdxpYUYCeWBtWjChLNITiuDdPyx42MGYlCrNdl2p1ffGz8Q9AO/SjKVbKYfSgqgAwg1MgpV+/gv0HcB9p+GtOHrkHszVO016ZZ4d93ps8ZZOeGWBZZ2dFp0Lfcs3HrjFgMK77FTnMG+32spBMbZcIxa1JprLp+bgLNA5bq8CXfdwkchR9uQndhhWd6EulepkO2lJ8s5ZCt+GGMLFpE2VWY0kBofrcrza+8tTkdjjMfIgaO8uELUhvcgbHhiWGq705avENODGtctqrLS5RBBt5sxpjIdS8UwqOxTBYvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(376002)(346002)(136003)(396003)(451199018)(122000001)(33656002)(54906003)(71200400001)(316002)(83380400001)(2906002)(66556008)(38100700002)(82960400001)(66446008)(53546011)(64756008)(6916009)(66476007)(52536014)(6506007)(76116006)(478600001)(26005)(186003)(9686003)(55016003)(8676002)(86362001)(66946007)(8936002)(5660300002)(41300700001)(38070700005)(7696005)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VUtHZ3NkYzlGMXdyTmkrOW03RTVSZWduZGR6dk1jTlZNNXgzR2Q3Y21rWHFy?= =?utf-8?B?ZUZjNDVSRXR3SHBZNW1jQm9zeWZsbHRtWERKeTc4bnJNS29qU29wcmN6RnpC?= =?utf-8?B?UXVBbmVSS2hXeWlYRUxjNTI2cVJFWU8yanE4LzNoc3pSc0ZWdXZXcmtZc2dj?= =?utf-8?B?Z3FpQVk2QnBSSHdIMjEyd0FmR01VMXhWYk0za1JqWlJZcGUyZk9lamNwaUI2?= =?utf-8?B?dFlJbCtGWVAyQUdGckhrQ2xPRStRR1R1VjRNRWs2SHBwSEZFYTFBdXloMEhP?= =?utf-8?B?ZWJBdkpVU2lsUEp1OUZYa0VHeHNEQXlaakRLbnBQV2ZtTC9hYzdRakZ5R1NH?= =?utf-8?B?aGNjWUR2ZGp2KzdPYmhkUVg2cTh3eTZTTnVrSkVtUUlGMy9kK1ZwZnJMeHpk?= =?utf-8?B?ZExKQ3N2MER3SWxRWmU1T1kwdVI3YmZGY3Z0ek1kcVdHSmJuallCMlpXNUV5?= =?utf-8?B?eS9mSjZCdHdKQnZaSUM3YVgyUWI1OS9UWXc1dGN6THArcGhxWmNPc3BwZjUw?= =?utf-8?B?cjRBcEFaaklUeGZZUkFqODJOQmR0MFQ3Z0htUCsrcHpBYS9sclY5cHNVTUNL?= =?utf-8?B?RytDTVlmN3pOSnNUWkJuaGxkNWxiRG11WFo2bFFKRUJhUzgrd2FoQjRuNVht?= =?utf-8?B?VzJaRFF1amF5UXVuaVZDRDVpdmR5T3NjVmVzUTJQa1oxcXdxRUtDQ1JNZWFI?= =?utf-8?B?Uk5yeC9CUERTVXZ2UGUzdlJ3OThJTFRLM04veVVBSE5lQlQwWFF3dlhyTnAv?= =?utf-8?B?eERZQjBMMGgxb0VRWkFPeVNpZ1hKK3ZEYTJleWRzOXc5YmI1enVTdXN0Sm9C?= =?utf-8?B?RC9oK1JjbVVLQXZCVkZScWtWNmorVzArbHlLSzVaSVRCWjloQURFYmhNUDZ2?= =?utf-8?B?TXZZenhhQmYvbGNxVEdkNDZzTUEyL1BtWnpscXJSMWxsTlRDSm5CM01GK1JU?= =?utf-8?B?cWtqcVF2Y1Vyb1FMR2h2TWMxSkN5UWtiOWZ5eEQxV2djWnFtdi9GQVdTWkg0?= =?utf-8?B?Y1Bjc005ZVYycjVJUXA4NlFsY3ZjUjVPUUd6MlFtSGtSSmJDYVZHWS8wUlR2?= =?utf-8?B?YlVXZlhob2dIWUNKT1QrcDJYTTBuTDhhMStKRlRSMElzMVBjdzBZU1Y4bWZD?= =?utf-8?B?MUVwejRReXJ2elNQWU1kV05qM21aYUNUckhXQ1Yxa3FORmhHeW5GdnVUZkJB?= =?utf-8?B?T0xvWDVOVFMxdk9odkE5ekptWldNR205RnlTNXFKd1p5akVBNEhKaDNOalBL?= =?utf-8?B?SzFsVHlmeXpZQ0lpbG1qUmxROEo4Y2tnNjlHY2ZXRnNNNG9GcEJRdDQ2MG5C?= =?utf-8?B?OXdKOXkzWEJ5dUFHTmhoWHdOZWF2MzNEWm9Fb3lRUDhaSzRJTHFrK3hHam83?= =?utf-8?B?VXlkS1BOaW9ObHJ5eEVtTjNkNVA5MEt2dGxINGVJYWk5c2kvemRaMk5sTDRP?= =?utf-8?B?dUNlMWQ4dTdncDdFZUJrek4wWkh2SW9sVXQreU1MUmFmWVBTODE5bXdBcEdl?= =?utf-8?B?MXhrNHAraUQ5TnRRQVVmUjlodUROUHRHUzliZXZjRGhvb1NUNThMcmN1Y1Jr?= =?utf-8?B?b1hIZmZRUWNEbDUzVkFJa3ZleGRnY3JPM1dmcW51Rk4wbVgxVE14N2xvUDlh?= =?utf-8?B?VjAzN2Vxc1dzR2hjYkZEdUFmMzJLYmhxL3lwUjVOSUwxWXZCL1NhYkFXOFhJ?= =?utf-8?B?VGFUckRvRkJrVklqUGVOTXYxOFJpV3pyMFpBdVh0ak5RdTg0aytwSW9vbGs0?= =?utf-8?B?WitDMUEybGc4TkNRTXRsM2I0cENXM0pSOCtnckhiUE5sZTJJWTViTno3ZlJn?= =?utf-8?B?SUhzUXBvK3JWOVBET0E0clN4bXQ2d3FqUEI2b2gzWHFZZ2cyOWo0cTIyVndP?= =?utf-8?B?TUVkUkJVOEdrWXpaby9MUzkwc1pLTmExQmlXODNra0dmQm9jOWRqNWVRdzJE?= =?utf-8?B?dldoMlVobnlvVm9ITTJhSy90ZVZOWXBpY3lCQldmV2toOUE0bVVvUjFhb3gv?= =?utf-8?B?aHhaSW9PNis4Wm5wSEsxalhxRE50b2RLM2FtbllIZnFzR2tLNTFiNDdCSHJH?= =?utf-8?B?VVoyK3EwMGNiem50aGFrd3RkZWxVUDdMaFo4V1VnclFjSUlCbWZqY1d4dUk4?= =?utf-8?Q?lH0zfYHXVXaBvfrX8fZ258Upy?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be52e16a-b4d7-461a-a9ee-08db04d02a47 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 03:47:11.1793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uA76qjeX8y7HbhFeSyq3PZUQ41y+cJAkpIvFpk8mRiNbjrCOJdHIfKJrLyhvHc+SCer2ZzMgHP5CSFNaChoSjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7091 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFdlZG5lc2Rh eSwgRmVicnVhcnkgMSwgMjAyMyA1OjMwIFBNDQo+IA0KPiBPbiAwMS4wMi4yMDIzIDA2OjA3LCBU aWFuLCBLZXZpbiB3cm90ZToNCj4gPj4gRnJvbTogWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rv d2FAZ21haWwuY29tPg0KPiA+PiBTZW50OiBUdWVzZGF5LCBKYW51YXJ5IDI0LCAyMDIzIDg6NDIg UE0NCj4gPj4NCj4gPj4gVGhlIHZhcmlhYmxlIHVudHJ1c3RlZF9tc2kgaW5kaWNhdGVzIHdoZXRo ZXIgdGhlIHN5c3RlbSBpcyB2dWxuZXJhYmxlIHRvDQo+ID4+IENWRS0yMDExLTE4OTggZHVlIHRv IHRoZSBhYnNlbmNlIG9mIGludGVycnVwdCByZW1hcHBpbmcgc3VwcG9ydC4NCj4gPj4gQWx0aG91 Z2ggQU1EIGlvbW11cyB3aXRoIGludGVycnVwdCByZW1hcHBpbmcgZGlzYWJsZWQgYXJlIGFsc28N Cj4gYWZmZWN0ZWQsDQo+ID4+IHRoaXMgY2FzZSBpcyBub3QgaGFuZGxlZCB5ZXQuIEdpdmVuIHRo YXQgdGhlIGlzc3VlIGlzIG5vdCBWVC1kIHNwZWNpZmljLA0KPiA+PiBhbmQgdG8gYWNjb21tb2Rh dGUgZnV0dXJlIHVzZSBvZiB0aGUgZmxhZyBmb3IgY292ZXJpbmcgYWxzbyB0aGUgQU1EDQo+IGlv bW11DQo+ID4+IGNhc2UsIG1vdmUgdGhlIGRlZmluaXRpb24gb2YgdGhlIGZsYWcgb3V0IG9mIHRo ZSBWVC1kIHNwZWNpZmljIGNvZGUgdG8gdGhlDQo+ID4+IGNvbW1vbiB4ODYgaW9tbXUgY29kZS4N Cj4gPj4NCj4gPj4gQWxzbywgc2luY2UgdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gYXNzdW1l cyB0aGF0IG9ubHkgUFYgZ3Vlc3RzIGFyZQ0KPiA+PiBwcm9uZQ0KPiA+PiB0byB0aGlzIGF0dGFj aywgdGFrZSB0aGUgb3Bwb3J0dW5pdHkgdG8gZGVmaW5lIHVudHJ1c3RlZF9tc2kgb25seSB3aGVu IFBWDQo+IGlzDQo+ID4+IGVuYWJsZWQuDQo+ID4+DQo+ID4NCj4gPiBJJ20gZmluZSB3aXRoIHRo aXMgY2hhbmdlIGdpdmVuIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLg0KPiA+DQo+ID4gQnV0IEknbSBj dXJpb3VzIGFib3V0IHRoZSBzdGF0ZW1lbnQgaGVyZSB0aGF0IHRoZSBjdXJyZW50IGNvZGUgb25s eQ0KPiA+IGFwcGxpZXMgdG8gUFYgZ3Vlc3QuIEkgZGlkbid0IHNlZSBzdWNoIHN0YXRlbWVudCBp biBvcmlnaW5hbCBtYWlsIFsxXQ0KPiA+IGFuZCBpbiBjb25jZXB0IGEgSFZNIGd1ZXN0IHdpdGgg cGFzc3Rocm91Z2ggZGV2aWNlIGNhbiBhbHNvIGRvIHN1Y2gNCj4gPiBhdHRhY2sgdy9vIGludGVy cnVwdCByZW1hcHBpbmcuDQo+ID4NCj4gPiBBbnkgbW9yZSBjb250ZXh0Pw0KPiANCj4gSXNuJ3Qg dGhpcyBzaW1wbHkgYmVjYXVzZSB3ZSBkb24ndCBhbGxvdyBIVk0gdG8gaGF2ZSBkZXZpY2VzIGFz c2lnbmVkDQo+IHdpdGhvdXQgaW50cmVtYXA/IChJJ20gbm90IHN1cmUsIGJ1dCBldmVuIGZvciBQ ViBhbGxvd2luZyB0aGlzIG1heQ0KPiBoYXZlIGJlZW4gbGltaXRlZCB0byB0aGUgeGVuZCB0b29s IHN0YWNrLikNCj4gDQoNCk9LLCB0aGlzIGlzIHdoYXQgSSdtIHNlZWtpbmcuDQoNClJldmlld2Vk LWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Thu Feb 02 04:48:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 04:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488521.756636 (Exim 4.92) (envelope-from ) id 1pNRWD-0001FZ-B0; Thu, 02 Feb 2023 04:48:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488521.756636; Thu, 02 Feb 2023 04:48:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRWD-0001FS-77; Thu, 02 Feb 2023 04:48:17 +0000 Received: by outflank-mailman (input) for mailman id 488521; Thu, 02 Feb 2023 04:48:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRWC-0001FI-A0; Thu, 02 Feb 2023 04:48:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRWC-0007Mw-7m; Thu, 02 Feb 2023 04:48:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRWB-0006ia-P0; Thu, 02 Feb 2023 04:48:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNRWB-0000va-Oa; Thu, 02 Feb 2023 04:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qr3Ep3LlPZPDrWpyHH7n41EaNGeRXJd8oqgqA/9td54=; b=bzeBIKM/rwA1wvStHYfqkAkTCg nMy5lrOgg//2baYwEXrRczMboPdRfwlMJgHrQQeuntDWax80FNBGJghpu0OITI+a4PFq/eF49zCeA MwfxVx9TmvJAWK9DIKwO7DsNAgVr9B78PKNiHZmzi391I5x3Mdx8gFia7ugGdbTdVkHQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176324: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 04:48:15 +0000 flight 176324 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176324/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 04:53:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 04:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488530.756647 (Exim 4.92) (envelope-from ) id 1pNRbT-0002jN-WC; Thu, 02 Feb 2023 04:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488530.756647; Thu, 02 Feb 2023 04:53:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRbT-0002jG-Rr; Thu, 02 Feb 2023 04:53:43 +0000 Received: by outflank-mailman (input) for mailman id 488530; Thu, 02 Feb 2023 04:53:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRbT-0002j6-2z; Thu, 02 Feb 2023 04:53:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRbS-0007TA-Qs; Thu, 02 Feb 2023 04:53:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNRbS-0006yt-CJ; Thu, 02 Feb 2023 04:53:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNRbS-0003BL-Bq; Thu, 02 Feb 2023 04:53:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TvGuvfNXlu/UrnPQMf46wBYjYLh/Cu0MJlpUv7sOzgE=; b=HKlScRE3Lz6CUWj8H8yqgd9LJM qiffhfkm7/+NpK10eIJCC9n8m7bH5mhsSQlsA8Iq26lwI2RTaJ9BgrJFCf8a1i4dllBqY/e1AkKJe 6T9xT1mB/gZT1B2MeLnaDfHx5N5UkRxMzhKYKH141vLDOfgC6dcJgoL+X6rTQqXA6jYg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176311: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow::broken:regression xen-unstable:build-armhf::broken:regression xen-unstable:test-amd64-amd64-migrupgrade::broken:regression xen-unstable:build-armhf:host-install(4):broken:regression xen-unstable:test-amd64-i386-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-xl-pvhv2-intel::broken:regression xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64::broken:regression xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:build-armhf:syslog-server:running:regression xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-xl-pvhv2-intel:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:host-install/src_host(6):broken:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:host-install(5):broken:heisenbug xen-unstable:test-amd64-amd64-examine:host-install:broken:heisenbug xen-unstable:test-amd64-amd64-migrupgrade:host-install/dst_host(7):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:host-ping-check-native:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:build-armhf:capture-logs:broken:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=10b80ee5588e8928b266dea02a5e99d098bd227a X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Thu, 02 Feb 2023 04:53:42 +0000 flight 176311 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176311/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken build-armhf broken test-amd64-amd64-migrupgrade broken build-armhf 4 host-install(4) broken REGR. vs. 175994 test-amd64-i386-libvirt-pair broken in 176268 test-amd64-amd64-xl-pvhv2-intel broken in 176268 test-amd64-i386-xl-qemuu-ovmf-amd64 broken in 176268 test-amd64-amd64-xl-qemut-debianhvm-amd64 broken in 176284 build-arm64-pvops 6 kernel-build fail in 176266 REGR. vs. 175994 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 5 host-install(5) broken in 176268 pass in 176311 test-amd64-amd64-xl-pvhv2-intel 5 host-install(5) broken in 176268 pass in 176311 test-amd64-i386-libvirt-pair 6 host-install/src_host(6) broken in 176268 pass in 176311 test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken in 176284 pass in 176311 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 5 host-install(5) broken pass in 176277 test-amd64-amd64-examine 5 host-install broken pass in 176277 test-amd64-amd64-migrupgrade 7 host-install/dst_host(7) broken pass in 176297 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 12 debian-hvm-install fail in 176268 pass in 176266 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail in 176268 pass in 176311 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176268 pass in 176311 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 6 host-ping-check-native fail in 176277 pass in 176268 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 176277 pass in 176311 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail in 176277 pass in 176311 test-amd64-i386-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail in 176277 pass in 176311 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176277 pass in 176311 test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail in 176284 pass in 176297 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail in 176297 pass in 176311 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176284 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 176297 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 176266 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 176266 n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175994 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 176284 like 175994 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 3 hosts-allocate starved in 176277 n/a version targeted for testing: xen 10b80ee5588e8928b266dea02a5e99d098bd227a baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 12 days Failing since 176003 2023-01-20 17:40:27 Z 12 days 24 attempts Testing same since 176222 2023-01-26 22:13:29 Z 6 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade broken test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken broken-job build-armhf broken broken-job test-amd64-amd64-migrupgrade broken broken-step build-armhf capture-logs broken-step test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow host-install(5) broken-step build-armhf host-install(4) broken-step test-amd64-amd64-migrupgrade host-install/dst_host(7) broken-step test-amd64-amd64-examine host-install broken-job build-armhf broken broken-job test-amd64-i386-libvirt-pair broken broken-job test-amd64-amd64-xl-pvhv2-intel broken broken-job test-amd64-i386-xl-qemuu-ovmf-amd64 broken broken-job build-armhf broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemuu-ovmf-amd64 broken broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken Not pushing. (No revision log; it would be 1225 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 05:42:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 05:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488541.756658 (Exim 4.92) (envelope-from ) id 1pNSMK-0001hU-LF; Thu, 02 Feb 2023 05:42:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488541.756658; Thu, 02 Feb 2023 05:42:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNSMK-0001hN-IG; Thu, 02 Feb 2023 05:42:08 +0000 Received: by outflank-mailman (input) for mailman id 488541; Thu, 02 Feb 2023 05:42:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNSMJ-0001hD-DU; Thu, 02 Feb 2023 05:42:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNSMJ-0000PE-AE; Thu, 02 Feb 2023 05:42:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNSMI-0000vD-Vf; Thu, 02 Feb 2023 05:42:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNSMI-0003bU-VD; Thu, 02 Feb 2023 05:42:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2z9oUQpyi74edL7LvNI5Mbu+KlGndAbDW8L4hannf+E=; b=jQ7sI4KXHvCPwCRESx6CjcOV/X W7f3RL51qeLmncJA1ihLuu/AW/w7ODi25BNEk1PCTBw/BlICF2Pa4Uq+jx1YKR3Rpe5JtfQJfkRky VqRTRsh9NlY9bj+KBoxat2vQE3uMQX7S1otQ5AnSdwsNeNdUTEkyhvBe6vYUeXj+QsyI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176323: all pass - PUSHED X-Osstest-Versions-This: ovmf=d375273c899bfa279c2732c509caf455af285006 X-Osstest-Versions-That: ovmf=bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 From: osstest service owner Date: Thu, 02 Feb 2023 05:42:06 +0000 flight 176323 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176323/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d375273c899bfa279c2732c509caf455af285006 baseline version: ovmf bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 Last test of basis 176306 2023-02-01 02:42:07 Z 1 days Testing same since 176323 2023-02-02 02:10:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yuan Yu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git bda715bf6d..d375273c89 d375273c899bfa279c2732c509caf455af285006 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 02 06:58:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 06:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488553.756669 (Exim 4.92) (envelope-from ) id 1pNTXf-0003LF-B9; Thu, 02 Feb 2023 06:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488553.756669; Thu, 02 Feb 2023 06:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNTXf-0003L8-8I; Thu, 02 Feb 2023 06:57:55 +0000 Received: by outflank-mailman (input) for mailman id 488553; Thu, 02 Feb 2023 06:57:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNTXd-0003Ky-R4; Thu, 02 Feb 2023 06:57:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNTXd-0002OV-OR; Thu, 02 Feb 2023 06:57:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNTXd-0003zH-Av; Thu, 02 Feb 2023 06:57:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNTXd-00020F-AP; Thu, 02 Feb 2023 06:57:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P+J2W5CozWk7kWCFkfMj+X08529tW3+1zT0y6bmyDpU=; b=GPLQyVe+lU0pEhoWIE1YxHoPy+ +6OuwhgA1b07jo9QR1u1FeMKLN9ElsdV3qTAMbH1LQYB002AWu4QopLYrmRVEO/fxUla5lvNH/cSh F6tMAX4NR6CydLM+tNbCttbySUwO6kJIJvelpelEezgQKeP3XogS4gNkt86SmfveyS3A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176327: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 06:57:53 +0000 flight 176327 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176327/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 07:45:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 07:45:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488562.756680 (Exim 4.92) (envelope-from ) id 1pNUHX-0001ZT-Pd; Thu, 02 Feb 2023 07:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488562.756680; Thu, 02 Feb 2023 07:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUHX-0001ZM-Mm; Thu, 02 Feb 2023 07:45:19 +0000 Received: by outflank-mailman (input) for mailman id 488562; Thu, 02 Feb 2023 07:45:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUHW-0001ZC-6W; Thu, 02 Feb 2023 07:45:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUHW-0003Q7-3Q; Thu, 02 Feb 2023 07:45:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUHV-0006i3-Pc; Thu, 02 Feb 2023 07:45:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNUHV-0003Gn-P5; Thu, 02 Feb 2023 07:45:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6lDOzJ8SuMW6+DFuDm4P7S53UwJgD0Ne+S+OCgZAP2A=; b=I6nq65UnGs1NHmgTk8d0BKIQ87 EleRfZD25YfWgVy8M2Sjl2s1cghsaed8ma1Gx3uIIqQ8CASYqWTxy5aOFJxo6+bvworsnSAXPwxd2 LNW9YP+v/18YwGIdabmT0LxlsHSKDxpVlvlDqYM/4nW/iDepmPzbrvHVrwhNxEfMHhpo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 176322: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=ea1b7a0733906b8425d948ae94fba63c32b1d425 X-Osstest-Versions-That: seabios=645a64b4911d7cadf5749d7375544fc2384e70ba From: osstest service owner Date: Thu, 02 Feb 2023 07:45:17 +0000 flight 176322 seabios real [real] flight 176329 seabios real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176322/ http://logs.test-lab.xenproject.org/osstest/logs/176329/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail pass in 176329-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174947 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174947 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174947 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174947 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174947 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios ea1b7a0733906b8425d948ae94fba63c32b1d425 baseline version: seabios 645a64b4911d7cadf5749d7375544fc2384e70ba Last test of basis 174947 2022-11-23 16:41:39 Z 70 days Testing same since 176322 2023-02-02 01:57:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Woodhouse jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git 645a64b..ea1b7a0 ea1b7a0733906b8425d948ae94fba63c32b1d425 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488575.756702 (Exim 4.92) (envelope-from ) id 1pNUb6-0005qI-46; Thu, 02 Feb 2023 08:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488575.756702; Thu, 02 Feb 2023 08:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUb6-0005qB-0d; Thu, 02 Feb 2023 08:05:32 +0000 Received: by outflank-mailman (input) for mailman id 488575; Thu, 02 Feb 2023 08:05:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUb3-0005Ed-UP for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:05:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0c::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a25ff54-a2d0-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 09:05:27 +0100 (CET) Received: from AM6P192CA0030.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::43) by DB4PR08MB8053.eurprd08.prod.outlook.com (2603:10a6:10:38a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Thu, 2 Feb 2023 08:05:22 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::cc) by AM6P192CA0030.outlook.office365.com (2603:10a6:209:83::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Thu, 2 Feb 2023 08:05:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 08:05:21 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Thu, 02 Feb 2023 08:05:21 +0000 Received: from 3de4e5565c63.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D670AF53-CE07-49EC-BE0B-6FE59ADA29A7.1; Thu, 02 Feb 2023 08:05:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3de4e5565c63.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Feb 2023 08:05:11 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS2PR08MB9197.eurprd08.prod.outlook.com (2603:10a6:20b:57b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 08:05:08 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Thu, 2 Feb 2023 08:05:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a25ff54-a2d0-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3/CM8sKhqkKBKnls5AwJqB4jP4SaSDy5KU+HPlQIMs=; b=o/uv4nf0n8NMO7GslhGs/p51lGnV8kM4hUawZU26ccX7fDatTnQxFe8uTso+f3kwLvyL2o47B3pEMyLd+u3cfD6bQS5c9RkLeu5b0DUacRFBMaTH5So1WJC9fACO4tBwNQqHsKZ6XW+rFMrw+OvwqNj2skOjeBWlEWUC4oK6j48= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dr95XFpkcvZMchzCUf2FDCEOKeBfV6qmEDT38bi4bpEn9Mwb1yp8pwSBrR8zBtzIYveJAOhLxuRass6cGgt/rFaD+w+/3qpXd7RVtYzMbHUAH2TgNNZhsBbFCl0KW5Q4WoQND5CJK02A/Rgjxg4Jc5MI3CBZqu1VL2tZUC90Ok1bWlCUWxKEaZ369WZ7aivhBGq3mR/Rhoqi5TycecbDlowe8vaWxHlDF/ff0tMwpcg1+h0Cktyrk41Xf8AcQ2Xs16KOCf+HE5iwkLtqzkhB3VjnnefPNvFgvsYYMtl4BXHudQWgB7+v+/uvoZta80U/MaXnVgZaBcC07fz+rhJlZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3/CM8sKhqkKBKnls5AwJqB4jP4SaSDy5KU+HPlQIMs=; b=OfT//t9Ctk3b7jHVngYyV2eXxnsQ67g0k4gv6nuG4HKN13UomvWWYy1tJxD575jCFnEJ/bomZnvgHkRQAy86WbtQ4V9dfyenIsR8b5xyFDH8rQZC1HEPeBiIniiRq/ggt65lndw6oMechDr5LTLcQImXWlQt3DULTWokke2XOSzkO0vTjdUTgIEC8t9n0Kzys+O0ybl1feuGrJh8TD7er6B4D22BMq+9mgSvCcAbP+7RoqSXPXanCrVJ88VmmY+rFTYtYJ6gsI5x6eEHZ4jz0G9H/s8AvE2URBkGAinJG+o5gIuPDxEkrKZ3OCpP64mLqHm88B61VVuqzfGqc1X6mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3/CM8sKhqkKBKnls5AwJqB4jP4SaSDy5KU+HPlQIMs=; b=o/uv4nf0n8NMO7GslhGs/p51lGnV8kM4hUawZU26ccX7fDatTnQxFe8uTso+f3kwLvyL2o47B3pEMyLd+u3cfD6bQS5c9RkLeu5b0DUacRFBMaTH5So1WJC9fACO4tBwNQqHsKZ6XW+rFMrw+OvwqNj2skOjeBWlEWUC4oK6j48= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Thread-Topic: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Thread-Index: AQHZJxAoM+nWeUC5lUC+09eIkdu2V66uAIMAgAb9FDCAAB73gIABdWjwgABDKoCAATGeAIAAW6iAgAABNtCAAjSCAIAAq5mg Date: Thu, 2 Feb 2023 08:05:06 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-14-Penny.Zheng@arm.com> <23f49916-dd2a-a956-1e6b-6dbb41a8817b@xen.org> <33bddc11-ae1e-b467-32d7-647748d1c627@xen.org> <49329992-3203-78a7-fc61-d6494e37705c@xen.org> <14f9c89a-6eea-204e-cd1b-6bc1cca99716@xen.org> <6e96eaa7-a8a3-eaf3-ca44-3432c88e71d1@xen.org> In-Reply-To: <6e96eaa7-a8a3-eaf3-ca44-3432c88e71d1@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 17532BEA79C88041BEA80380F2CD2E37.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS2PR08MB9197:EE_|AM7EUR03FT023:EE_|DB4PR08MB8053:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ceef517-49e2-489b-91f6-08db04f43b33 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ChKa1XdZ1rKDGqaDqyFx3trnI4PmcmExsWaRJ2mIyHF5IYKcpefHoZyKXTq5qYp8ecuCjc7EIMJFGxvOWtFDFvvkSmzH78l0suVku9d8lZmsu49480DrhnkcVKFX3maxv1HI3Zs+tdDXdG0rJ6tiYuGaBxemH5z0Q1QeIlYDemfL+/ZNe1O++uVIJTMJyCE5Q2da5zfEl+Wv6elxLRpO50VxfTv6gV1CHFT4rRZZFNjm5kY9JP0Kc3dVPEWNmNyzNP94DyrL4cU2d2GDQh2MoaPS+F44SYaz1vmVdiD7YAYN1aGMHR5KJyuLah2nIvR3g9NCnL5w4F19RfR4/WJjl+yJdlj1lKlRZNQU5Odg07YZfpOH0yW7X1DKpf5tGikQQ0gbo0NngJSe+nzHfvG6QPbRZH0ezqvWfOOYy8wTnD3C2LPItax186+U6bseI0cfAnIQW3s6XuXLh6bEjAHCidSI2kL4de+0L1oZp2gpn5J8AwY1SJkuqs8rkL5clgUYmGRu9osjeKBqBseHwPWJgDQW0TQVCB/oZIm8NbSEd8N1d2XjR0EWhHBJ0Dg2M6R4jY+WviPjmedNfCYmBoahYe+Zb/s/lbY7sbsG9e9xVBzdHyNwDZoHp4dBaZ9yoOmzuIWaaBRH7Lh1aU8eryVUmnHoNE50WYQmfM25d/5MSHQVj7FtiM67X6s6Cg0nQUwIoJ2zuVTmoqzBc1jinnveYMQa7/MEu77lvTNFAJkenxQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199018)(66946007)(76116006)(86362001)(2906002)(41300700001)(316002)(122000001)(33656002)(7696005)(52536014)(38100700002)(478600001)(8936002)(55016003)(38070700005)(966005)(6506007)(53546011)(26005)(186003)(9686003)(8676002)(66476007)(54906003)(66556008)(66446008)(64756008)(110136005)(5660300002)(4326008)(71200400001)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9197 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 96adb3f5-5940-4f09-0447-08db04f43289 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tqqbUaZcxtMbvf8rg7Cz9kzGjyA1RISbifhsiubVEUfQ+KoBPH0UbpOAXRIJvqvLPCIqCqZClBUudT9wEi210PY8BjCrbT/g31Ld/zqBHkJOhReam4DZQ+AnrulOg+R76bUY/Ty86Xl4bKuI7pP3rDSdfJ90/aw6KDkoo8Womqvr7hxZCPfMFO3zoKtKut+yXO91OZApwagXZaongBhusnosvbee5sNViw86q806QJ+QVK4neSP5b65b9M8CPOJpRxxOZYMdfN8PLuzcO7BCiNRMt0U/O6lRbh6UooKPdhwMwdw67iJFOWNkJ2VK2eiSsaX7XsbvwVDRyoysw011W3Nm0hCW4IkSdHpBVjqsdSCFRIm5HYFaZo2eKyktwgW3LW5e0FtBTL+PTd56SYMfBMeh9JELkuDmMFoiwU7RBBdR+1tBY4qmi9+cmJGOPJKtDEjmQmD2mztBSSzki95Rs607hhGPLNvzgCYX/wUYX+/N11KxmUrl3DalFnSUn+rdCwu47egCUWmP1kbHn2XDti0Wd/DMBeOO+vU58rPzNKnzY4szuVP+ywUX6KudkgwhctA5lXu2cyxnikXrUYpArXxQhbCRdekwiNV1zNSNVdWT+VJGtAzGO755TBNbIkxvIDPIEgasolcF9vFKEgkGkW8UZEIaLDV8CC88Se7LmL2OwrSV/OR63H7ZeldW48BVPnkWOuTJZvkZQFRFaLMRaK+b8HfNeyfqkkh44vJ+RZU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199018)(36840700001)(40470700004)(46966006)(70586007)(70206006)(82310400005)(8676002)(82740400003)(4326008)(86362001)(36860700001)(41300700001)(47076005)(8936002)(52536014)(316002)(356005)(83380400001)(336012)(81166007)(53546011)(5660300002)(54906003)(9686003)(110136005)(186003)(26005)(478600001)(40460700003)(966005)(55016003)(2906002)(107886003)(40480700001)(7696005)(6506007)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:05:21.4042 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ceef517-49e2-489b-91f6-08db04f43b33 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8053 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPg0KPiBTZW50OiBUaHVyc2RheSwgRmVicnVhcnkgMiwgMjAyMyAzOjI3IEFNDQo+ IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZw0KPiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5v IFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlz IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5 bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMTMvNDBdIHhl bi9tcHU6IGludHJvZHVjZSB1bmlmaWVkIGZ1bmN0aW9uDQo+IHNldHVwX2Vhcmx5X3VhcnQgdG8g bWFwIGVhcmx5IFVBUlQNCj4gDQo+IA0KPiANCj4gT24gMDEvMDIvMjAyMyAwNTozNiwgUGVubnkg Wmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0KPiBIaSBQZW5ueSwNCj4NCg0KSGkgSnVs aWVuLA0KIA0KPiA+DQpbLi4uXQ0KPiA+Pj4geGVuX21wdW1hcFszXSA6IFhlbiByZWFkLXdyaXRl IGRhdGENCj4gPj4+IHhlbl9tcHVtYXBbNF0gOiBYZW4gQlNTDQo+ID4+PiB4ZW5fbXB1bWFwWzVd IDogWGVuIHN0YXRpYyBoZWFwDQo+ID4+PiB4ZW5fbXB1bWFwWzZdIDogR3Vlc3QgbWVtb3J5IHNl Y3Rpb24NCj4gPj4NCj4gPj4gV2h5IGRvIHlvdSBuZWVkIHRvIG1hcCB0aGUgIkd1ZXN0IG1lbW9y eSBzZWN0aW9uIiBmb3IgdGhlIGlkbGUgdkNQVT8NCj4gPj4NCj4gPg0KPiA+IEhtbW0sICJHdWVz dCBtZW1vcnkgc2VjdGlvbiIgaGVyZSByZWZlcnMgdG8gKkFMTCogZ3Vlc3QgUkFNIGFkZHJlc3MN Cj4gcmFuZ2Ugd2l0aCBvbmx5IEVMMiByZWFkL3dyaXRlIGFjY2Vzcy4NCj4gDQo+IEZvciB3aGF0 IHB1cnBvc2U/IEVhcmxpZXIsIHlvdSBzYWlkIHlvdSBoYWQgYSBzZXR1cCB3aXRoIGEgbGltaXRl ZCBudW1iZXINCj4gb2YgTVBVIGVudHJpZXMuIFNvIGl0IG1heSBub3QgYmUgcG9zc2libGUgdG8g bWFwIGFsbCB0aGUgZ3Vlc3RzIFJBTS4NCj4gDQoNClRoZSAiR3Vlc3QgbWVtb3J5IHNlY3Rpb24i IEkgcmVmZXJyZWQgaGVyZSBpcyB0aGUgbWVtb3J5IHNlY3Rpb24gZGVmaW5lZCBpbiBteSBuZXcN CmludHJvZHVjaW5nIGRldmljZSB0cmVlIHByb3BlcnR5LCAibXB1LGd1ZXN0LW1lbW9yeS1zZWN0 aW9uID0gPC4uLj4iLiAgSXQgd2lsbCBpbmNsdWRlDQoiQUxMIiBndWVzdCBtZW1vcnkuDQoNCkxl dCBtZSBmaW5kIGFuIGV4YW1wbGUgdG8gaWxsdXN0cmF0ZSB3aHkgSSBpbnRyb2R1Y2VkIGl0IGFu ZCBob3cgaXQgc2hhbGwgd29yazoNCkluIE1QVSBzeXN0ZW0sIGFsbCBndWVzdCBSQU0gKk1VU1Qq IGJlIHN0YXRpY2FsbHkgY29uZmlndXJlZCB0aHJvdWdoICJ4ZW4sc3RhdGljLW1lbSIgdW5kZXIg ZG9tYWluIG5vZGUuDQpXZSBmb3VuZCB0aGF0IHdpdGggbW9yZSBhbmQgbW9yZSBndWVzdHMgaW4s ICB0aGUgc2NhdHRlcmluZyBvZiAgInhlbixzdGF0aWMtbWVtIiBtYXkNCmV4aGF1c3QgTVBVIHJl Z2lvbnMgdmVyeSBxdWlja2x5LiBUQkgsIGF0IHRoYXQgdGltZSwgSSBkaWRuJ3QgZmlndXJlIG91 dCB0aGF0IEkgY291bGQgbWFwL3VubWFwIG9uIGRlbWFuZC4NCkFuZCBpbiBNTVUgc3lzdGVtLCBX ZSB3aWxsIG5ldmVyIGVuY291bnRlciB0aGlzIGlzc3VlLCBzZXR1cF9kaXJlY3RtYXBfbWFwcGlu Z3Mgd2lsbCBtYXAgdGhlIHdob2xlIHN5c3RlbQ0KUkFNIHRvIHRoZSBkaXJlY3RtYXAgYXJlYSBm b3IgWGVuIHRvIGFjY2VzcyBpbiBFTDIuIA0KU28gaW5zdGVhZCwgIm1wdSxndWVzdC1tZW1vcnkt c2VjdGlvbiIgaXMgaW50cm9kdWNlZCB0byBsaW1pdCB0aGUgc2NhdHRlcmluZyBhbmQgbWFwIGlu IGFkdmFuY2UsIHdlIGVuZm9yY2UNCnVzZXJzIHRvIGVuc3VyZSBhbGwgZ3Vlc3QgUkFNKHRocm91 Z2ggInhlbixzdGF0aWMtbWVtIikgbXVzdCBiZSBpbmNsdWRlZCB3aXRoaW4gIm1wdSxndWVzdC1t ZW1vcnktc2VjdGlvbiIuDQplLmcuDQptcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb24gPSA8MHgwIDB4 MjAwMDAwMDAgMHgwIDB4NDAwMDAwMDA+Ow0KRG9tVTE6DQp4ZW4sc3RhdGljLW1lbSA9IDwweDAg MHg0MDAwMDAwMCAweDAgMHgyMDAwMDAwMD47DQpEb21VMjoNCnhlbixzdGF0aWMtbWVtID0gPDB4 MCAweDIwMDAwMDAwIDB4MCAweDIwMDAwMDAwPjsNCg0KPiBYZW4gc2hvdWxkIG9ubHkgbmVlZCB0 byBhY2Nlc3MgdGhlIGd1ZXN0IG1lbW9yeSBpbiBoeXBlcmNhbGxzIGFuZA0KPiBzY3J1YmJpbmcu IEluIGJvdGggY2FzZXMgeW91IGNvdWxkIG1hcC91bm1hcCBvbiBkZW1hbmQuDQo+IA0KDQp0aGFu a3MgZm9yIHRoZSBleHBsYW5hdGlvbi4NCkluIG15IHVuZGVyc3RhbmRpbmcsIGR1cmluZyBib290 LXVwLCB0aGVyZSBhcmUgdHdvIHNwb3RzIHdoZXJlIFhlbiBtYXkgdG91Y2ggdGhlIGd1ZXN0IG1l bW9yeToNCm9uZSBpcyB0aGF0IGRvaW5nIHN5bmNocm9ub3VzIHNjcnViYmluZyBpbiBmdW5jdGlv biB1bnByZXBhcmVfc3RhdGljbWVtX3BhZ2VzLg0KQW5vdGhlciBpcyBjb3BpbmcgYW5kIHBhc3Rp bmcga2VybmVsIGltYWdlIHRvIGd1ZXN0IG1lbW9yeS4NCkluIGJvdGggY2FzZXMsIHdlIGNvdWxk IG1hcC91bm1hcCBvbiBkZW1hbmQuIA0KQW5kIGlmIHlvdSB0aGluayBtYXAvdW5tYXAgb24gZGVt YW5kIGlzIGJldHRlciB0aGFuICJtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rpb24iLCBJJ2xsIHRyeSB0 byBmaXggaXQgaW4gbmV4dCBzZXJpZQ0KIA0KPiA+DQo+ID4gRm9yIGd1ZXN0IHZjcHUsIHRoaXMg c2VjdGlvbiB3aWxsIGJlIHJlcGxhY2VkIGJ5IGd1ZXN0IGl0c2VsZiBvd24gUkFNIHdpdGgNCj4g Ym90aCBFTDEvRUwyIGFjY2Vzcy4NCj4gPg0KPiA+DQo+ID4+PiB4ZW5fbXB1bWFwWzddIDogRGV2 aWNlIG1lbW9yeSBzZWN0aW9uDQo+ID4+DQo+ID4+IEkgbWlnaHQgYmUgbWlzc2luZyBzb21lIGNv bnRleHQgaGVyZS4gQnV0IHdoeSB0aGlzIHNlY3Rpb24gaXMgbm90DQo+ID4+IGFsc28gbWFwcGVk IGluIHRoZSBjb250ZXh0IG9mIHRoZSBndWVzdCB2Q1BVPw0KPiA+Pg0KPiA+PiBGb3IgaW5zdGFu Y2UsIGhvdyB3b3VsZCB5b3Ugd3JpdGUgdG8gdGhlIHNlcmlhbCBjb25zb2xlIHdoZW4gdGhlDQo+ ID4+IGNvbnRleHQgaXMgdGhlIGd1ZXN0IHZDUFU/DQo+ID4+DQo+ID4NCj4gPiBJIHRoaW5rLCBh cyBYZW4gaXRzZWxmLCBpdCBzaGFsbCBoYXZlIGFjY2VzcyB0byBhbGwgc3lzdGVtIGRldmljZSBt ZW1vcnkgb24NCj4gRUwyLg0KPiA+IElrLCBpdCBpcyBub3QgYWNjdXJhdGUgaW4gY3VycmVudCBN TVUgaW1wbGVtZW50YXRpb24sIG9ubHkgZGV2aWNlcw0KPiA+IHdpdGggc3VwcG9ydGVkIGRyaXZl ciB3aWxsIGdldCBpb3JlbWFwLg0KPiANCj4gU28gaW4gdGhlIE1NVSBjYXNlLCB3ZSBhcmUgbm90 IG1hcHBpbmcgYWxsIHRoZSBkZXZpY2VzIGluIFhlbiBiZWNhdXNlIHdlDQo+IGRvbid0IGV4YWN0 bHkga25vdyB3aGljaCBtZW1vcnkgYXR0cmlidXRlcyB3aWxsIGJlIHVzZWQgYnkgdGhlIGd1ZXN0 Lg0KPiANCj4gSWYgd2UgYXJlIHVzaW5nIGRpZmZlcmVudCBhdHRyaWJ1dGVzLCB0aGVuIHdlIGFy ZSByaXNraW5nIHRvIGJyZWFrIGNvaGVyZW5jeS4NCj4gQ291bGQgdGhlIHNhbWUgaXNzdWUgaGFw cGVuIHdpdGggdGhlIE1QVT8NCj4gDQo+IElmIHNvLCB0aGVuIHlvdSBzaG91bGQgbm90IG1hcHBl ZCB0aG9zZSByZWdpb25zIGluIFhlbi4NCj4gDQo+ID4NCj4gPiBCdXQgbGlrZSB3ZSBkaXNjdXNz ZWQgYmVmb3JlLCBpZiBmb2xsb3dpbmcgdGhlIHNhbWUgc3RyYXRlZ3kgYXMgTU1VDQo+ID4gZG9l cywgd2l0aCBsaW1pdGVkIE1QVSByZWdpb25zLCB3ZSBjb3VsZCBub3QgYWZmb3JkIG1hcHBpbmcg YSBNUFUNCj4gcmVnaW9uIGZvciBlYWNoIGRldmljZS4NCj4gPiBGb3IgZXhhbXBsZSwgT24gRlZQ djhSIG1vZGVsLCB3ZSBoYXZlIGZvdXIgdWFydHMsIGFuZCBhIEdJQ3YzLiBBdA0KPiA+IG1vc3Qs IHdlIG1heSBwcm92aWRlIGZvdXIgTVBVIHJlZ2lvbnMgZm9yIHVhcnRzLCBhbmQgdHdvIE1QVSBy ZWdpb25zDQo+IGZvciBEaXN0cmlidXRvciBhbmQgb25lIFJlZGlzdHJpYnV0b3IgcmVnaW9uLg0K PiA+IFNvLCBJIHRob3VnaHQgdXAgdGhpcyBuZXcgZGV2aWNlIHRyZWUgcHJvcGVydHkNCj4gPiDi gJxtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uID0gPDB4MCAweDgwMDAwMDAwIDB4MCAweDdmZmZm MDAwPjvigJwgdG8NCj4gcm91Z2hseSBtYXAgYWxsIHN5c3RlbSBkZXZpY2UgbWVtb3J5IGZvciBY ZW4gaXRzZWxmLg0KPiANCj4gV2h5IGRvIHlvdSBzYXkgInJvdWdobHkiPyBJcyBpdCBwb3NzaWJs ZSB0aGF0IHlvdSBoYXZlIG5vbi1kZXZpY2UgcmVnaW9uIGluDQo+IHRoZSByYW5nZT8NCj4gDQo+ ID4NCj4gPiBGb3IgZ3Vlc3QsIGl0IHNoYWxsIG9ubHkgc2VlIHZnaWMsIHZwbDAxMSwgYW5kIGl0 cyBvd24gcGFzc3Rocm91Z2gNCj4gPiBkZXZpY2UuIEFuZCBoZXJlLCB0byBtYWludGFpbiBzYWZl IGFuZCBpc29sYXRpb24sIHdlIHdpbGwgYmUgbWFwcGluZyBhDQo+IE1QVSByZWdpb24gZm9yIGVh Y2ggZGV2aWNlIGZvciBndWVzdCB2Y3B1Lg0KPiA+IEZvciBleGFtcGxlLCB2Z2ljIGFuZCB2cGww MTEgYXJlIGVtdWxhdGVkIGFuZCBkaXJlY3QtbWFwIGluIE1QVS4NCj4gPiBSZWxldmFudCBkZXZp Y2UNCj4gDQo+IEkgYW0gY29uZnVzZWQuIElmIHRoZSB2R0lDL3ZQTDAxMSBpcyBlbXVsYXRlZCB0 aGVuIHdoeSBkbyB5b3UgbmVlZCB0bw0KPiBtYXAgaXQgaW4gdGhlIE1QVT8gSU9XLCB3b3VsZG4n dCB5b3UgcmVjZWl2ZSBhIGZhdWx0IGluIHRoZSBoeXBlcnZpc29yIGlmDQo+IHRoZSBndWVzdCBp cyB0cnlpbmcgdG8gYWNjZXNzIGEgcmVnaW9uIG5vdCBwcmVzZW50IGluIHRoZSBNUFU/DQo+IA0K PiA+IG1hcHBpbmcoR0ZOID09IE1GTiB3aXRoIG9ubHkgRUwyIGFjY2Vzcyl3aWxsIGJlIGFkZGVk IHRvIGl0cyAqUDJNDQo+IG1hcHBpbmcgdGFibGUqLCBpbiB2Z2ljX3YzX2RvbWFpbl9pbml0IFsx XS4NCj4gPg0KPiA+IExhdGVyLCBvbiB2Y3B1IGNvbnRleHQgc3dpdGNoaW5nLCB3aGVuIHN3aXRj aGluZyBmcm9tIGlkbGUgdmNwdSwNCj4gPiBkZXZpY2UgbWVtb3J5IHNlY3Rpb24gZ2V0cyBkaXNh YmxlZCBhbmQgc3dpdGNoZWQgb3V0IGluDQo+ID4gY3R4dF9zd2l0Y2hfZnJvbSBbMl0sIGxhdGVy IHdoZW4gc3dpdGNoaW5nIGludG8gZ3Vlc3QgdmNwdSwgdmdpYyBhbmQNCj4gdnBsMDExIGRldmlj ZSBtYXBwaW5nIHdpbGwgYmUgc3dpdGNoZWQgaW4gYWxvbmcgd2l0aCB0aGUgd2hvbGUgUDJNDQo+ IG1hcHBpbmcgdGFibGUgWzNdLg0KPiA+DQo+ID4gV29yZHMgbWlnaHQgYmUgYW1iaWd1b3VzLCBi dXQgYWxsIHJlbGF0ZWQgY29kZSBpbXBsZW1lbnRhdGlvbiBpcyBvbg0KPiA+IE1QVSBwYXRjaCBz ZXJpZSBwYXJ0IElJIC0gZ3Vlc3QgaW5pdGlhbGl6YXRpb24sIHlvdSBtYXkgaGF2ZSB0byBjaGVj ayB0aGUNCj4gZ2l0bGFiIGxpbms6DQo+ID4gWzFdDQo+ID4gaHR0cHM6Ly9naXRsYWIuY29tL3hl bi1wcm9qZWN0L3Blb3BsZS93ZWljL3hlbi8tDQo+IC9jb21taXQvYTUxZDViMjVlYjE3YTUNCj4g PiAwYTM2YjI3OTg3YTJmNDhlMTQ3OTNhYzU4NSBbMl0NCj4gPiBodHRwczovL2dpdGxhYi5jb20v eGVuLXByb2plY3QvcGVvcGxlL3dlaWMveGVuLy0NCj4gL2NvbW1pdC9jNmEwNjlkNzc3ZDk0MA0K PiA+IDdhZWRhNDJiN2U1YjA4YTA4NmExYzE1OTc2IFszXQ0KPiA+IGh0dHBzOi8vZ2l0bGFiLmNv bS94ZW4tcHJvamVjdC9wZW9wbGUvd2VpYy94ZW4vLQ0KPiAvY29tbWl0L2Q4YzY0MDhiNmVlZjEx DQo+ID4gOTBkNzVjOWJkNGU1ODU1N2QzNGZjOGI0ZGYNCj4gDQo+IEkgaGF2ZSBsb29rZWQgYXQg dGhlIGNvZGUgYW5kIHRoaXMgZG9lc24ndCBlbnRpcmVseSBhbnN3ZXIgbXkgcXVlc3Rpb24uDQo+ IFNvIGxldCBtZSBwcm92aWRlIGFuIGV4YW1wbGUuDQo+IA0KPiBYZW4gY2FuIHByaW50IHRvIHRo ZSBzZXJpYWwgY29uc29sZSBhdCBhbnkgdGltZS4gU28gWGVuIHNob3VsZCBiZSBhYmxlIHRvDQo+ IGFjY2VzcyB0aGUgcGh5c2ljYWwgVUFSVCBldmVuIHdoZW4gaXQgaGFzIGNvbnRleHQgc3dpdGNo ZWQgdG8gdGhlIGd1ZXN0DQo+IHZDUFUuDQo+IA0KDQpJIHVuZGVyc3RhbmQgeW91ciBjb25jZXJu IG9uICJkZXZpY2UgbWVtb3J5IHNlY3Rpb24iIHdpdGggeW91cg0KRXhhbXBsZSBoZXJlLiBUcnVl LCB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBpcyBidWdneS4NCg0KWWVzLCBpZiB2cGwwMTEg aXMgbm90IGVuYWJsZWQgaW4gZ3Vlc3QgYW5kIHdlIGluc3RlYWQgcGFzc3Rocm91Z2ggYSBVQVJU IHRvDQpndWVzdCwgaW4gY3VycmVudCBkZXNpZ24sIFhlbiBpcyBub3QgYWJsZSB0byBhY2Nlc3Mg dGhlIHBoeXNpY2FsIFVBUlQgb24gZ3Vlc3QgbW9kZS4NCg0KQWxsIGd1ZXN0cyBpbiBNUFUgYXJl IGRpcmVjdC1tYXAsIFNvIGxpa2UgeW91IHNhaWQgYWZ0ZXIsIHRoZSBtYXBwaW5nIGZvcg0KdnBs MDExIG9uIGd1ZXN0IG1vZGUgaXMgdGhlIHNhbWUgd2l0aCB0aGUgcGh5c2ljYWwgVUFSVC4gIEFu ZCB0aGlzIGhpZGVzIHRoZSBwcm9ibGVtLCB0bw0KbGV0IFhlbiBiZWluZyBhYmxlIHRvIGFjY2Vz cyB0byB0aGUgcGh5c2ljYWwgVUFSVC4NCg0KSSdsbCBkcm9wIHRoZSBkZXNpZ24gb24gImRldmlj ZSBtZW1vcnkgc2VjdGlvbiIsIGFuZCBsZXQgZGV2aWNlIGRyaXZlciBtYXANCm9uIGRlbWFuZCBp biBib290LXRpbWUuDQogIA0KPiBCdXQgYWJvdmUgeW91IHNhaWQgdGhhdCB0aGUgcGh5c2ljYWwg ZGV2aWNlIHdvdWxkIG5vdCBiZSBhY2Nlc3NpYmxlIGFuZA0KPiBpbnN0ZWFkIHlvdSBtYXAgdGhl IHZpcnR1YWwgVUFSVC4gU28gaG93IFhlbiBpcyBzdXBwb3J0ZWQgdG8gYWNjZXNzIHRoZQ0KPiBw aHlzaWNhbCBVQVJUPw0KPiANCj4gT3IgYnkgdnBsMDExIGRpZCB5b3UgYWN0dWFsbHkgbWVhbiB0 aGUgcGh5c2ljYWwgVUFSVD8gSWYgc28sIHRoZW4gaWYgeW91DQo+IG1hcCB0aGUgZGV2aWNlIG9u ZSBieSBvbmUgaW4gdGhlIE1QVSBjb250ZXh0LCB0aGVuIGl0IHdvdWxkIGxpa2VseSBtZWFuDQo+ IHRvIGhhdmUgc3BhY2UgdG8gbWFwIHRoZW0gb25lIGJ5IG9uZSBpbiB0aGUgaWRsZSBjb250ZXh0 Lg0KPiANCj4gPiB4ZW5fbXB1bWFwWzBdIDogWGVuIHRleHQNCj4gPiB4ZW5fbXB1bWFwWzFdIDog WGVuIHJlYWQtb25seSBkYXRhDQo+ID4geGVuX21wdW1hcFsyXSA6IFhlbiByZWFkLW9ubHkgYWZ0 ZXIgaW5pdCBkYXRhIHhlbl9tcHVtYXBbM10gOiBYZW4NCj4gPiByZWFkLXdyaXRlIGRhdGEgeGVu X21wdW1hcFs0XSA6IFhlbiBCU1MgKCBGaXhlZCBNUFUgcmVnaW9uIGRlZmluZWQgaW4NCj4gPiBh c3NlbWJseSApDQo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+IC0tLS0NCj4gPiB4ZW5fbXB1bWFwWzVd OiBYZW4gaW5pdCBkYXRhDQo+ID4geGVuX21wdW1hcFs2XTogWGVuIGluaXQgdGV4dA0KPiA+IHhl bl9tcHVtYXBbN106IEVhcmx5IEZEVA0KPiA+IHhlbl9tcHVtYXBbOF06IEd1ZXN0IG1lbW9yeSBz ZWN0aW9uDQo+ID4geGVuX21wdW1hcFs5XTogRGV2aWNlIG1lbW9yeSBzZWN0aW9uDQo+ID4geGVu X21wdW1hcFsxMF06IFN0YXRpYyBzaGFyZWQgbWVtb3J5IHNlY3Rpb24gKCBib290LW9ubHkgYW5k IHN3aXRjaGluZw0KPiA+IHJlZ2lvbnMgZGVmaW5lZCBpbiBDICkNCj4gPiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t DQo+ID4gLS0tLQ0KPiA+IC4uLg0KPiA+IHhlbl9tcHVtYXBbbWF4X3hlbl9tcHVtYXAgLSAxXSA6 IFhlbiBzdGF0aWMgaGVhcCAoIEZpeGVkIE1QVSByZWdpb24NCj4gPiBkZWZpbmVkIGluIEMgKQ0K PiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAtLS0tDQo+ID4NCj4gPiBBZnRlciByZS1vcmc6DQo+ID4g eGVuX21wdW1hcFswXSA6IFhlbiB0ZXh0DQo+ID4geGVuX21wdW1hcFsxXSA6IFhlbiByZWFkLW9u bHkgZGF0YQ0KPiA+IHhlbl9tcHVtYXBbMl0gOiBYZW4gcmVhZC1vbmx5IGFmdGVyIGluaXQgZGF0 YSB4ZW5fbXB1bWFwWzNdIDogWGVuDQo+ID4gcmVhZC13cml0ZSBkYXRhIHhlbl9tcHVtYXBbNF0g OiBYZW4gQlNTICggRml4ZWQgTVBVIHJlZ2lvbiBkZWZpbmVkIGluDQo+ID4gYXNzZW1ibHkgKQ0K PiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAtLS0tDQo+ID4geGVuX21wdW1hcFs4XTogR3Vlc3QgbWVt b3J5IHNlY3Rpb24NCj4gPiB4ZW5fbXB1bWFwWzldOiBEZXZpY2UgbWVtb3J5IHNlY3Rpb24NCj4g PiB4ZW5fbXB1bWFwWzEwXTogU3RhdGljIHNoYXJlZCBtZW1vcnkgc2VjdGlvbiAoIFN3aXRjaGlu ZyByZWdpb24gKQ0KPiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAtLS0tDQo+ID4gLi4uDQo+ID4geGVu X21wdW1hcFttYXhfeGVuX21wdW1hcCAtIDFdIDogWGVuIHN0YXRpYyBoZWFwICggRml4ZWQgTVBV IHJlZ2lvbg0KPiA+IGRlZmluZWQgaW4gQyApDQo+ID4NCj4gPiBJZiB5b3UncmUgZmluZSB3aXRo IGl0LCB0aGVuIG5leHQgc2VyaWUsIEknbGwgdXNlIHRoaXMgbGF5b3V0LCB0byBrZWVwDQo+ID4g Ym90aCBzaW1wbGUgYXNzZW1ibHkgYW5kIHJlLW9yZyBwcm9jZXNzLg0KPiANCj4gSSBhbSBvayBp biBwcmluY2lwbGUgd2l0aCB0aGUgbGF5b3V0IHlvdSBwcm9wb3NlLiBNeSBtYWluIHJlcXVpcmVt ZW50IGlzDQo+IHRoYXQgdGhlIHJlZ2lvbiB1c2VkIGluIGFzc2VtYmx5IGFyZSBmaXhlZC4NCj4g DQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0KDQpDaGVlcnMsDQoNCi0tDQpQ ZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488574.756690 (Exim 4.92) (envelope-from ) id 1pNUat-0005V5-NA; Thu, 02 Feb 2023 08:05:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488574.756690; Thu, 02 Feb 2023 08:05:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUat-0005Uy-KY; Thu, 02 Feb 2023 08:05:19 +0000 Received: by outflank-mailman (input) for mailman id 488574; Thu, 02 Feb 2023 08:05:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUar-0005Ed-KE for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:05:18 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50d7c5de-a2d0-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 09:05:11 +0100 (CET) Received: from [2001:8b0:10b:5::bb3] (helo=u3832b3a9db3152.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNUab-00DCu7-R7; Thu, 02 Feb 2023 08:05:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50d7c5de-a2d0-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3O1h4pbUCfZjJxageF80vcxvuNGjkEh9LQSJTXdH+gk=; b=Z3qvABEdpMlUo41TiYy1gHZEDm S0BRxwgdijxvfOYNOJ91gdlj5zlB2Y6+1GsL8B5qMcP2IxJWw6886qj6Mgkh7l1SwUvY2cqk3cUtx xiXzcH0qc0wTt/nrl836BfXfxLPt2kuu9978iftB8W57OX5Ya6xUuGWZM+i14+QMHUigwUgCP6Yp2 9qTiCTQ2G8/0sYOHY4ofpjloSFYAQ8dJZpQa9iEI/GSCIMfJ9mtzpnMG/Yki8azoxLqJquOD4uJAV 6e+ShS6j8JuMEg9JsKCWr2pCmeojsbCtsEjsVFgyLdvADE6TKK13NBON6qBiai/P5K9i6TIaZVF5j ESsVfdqA==; Message-ID: Subject: Re: [SeaBIOS] [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen From: David Woodhouse To: Kevin O'Connor , Gerd Hoffmann Cc: seabios , xen-devel , qemu-devel , paul Date: Thu, 02 Feb 2023 08:05:01 +0000 In-Reply-To: References: Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-sroW6G48O+5dXLLiahn3" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-sroW6G48O+5dXLLiahn3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2023-02-01 at 21:13 -0500, Kevin O'Connor wrote: > On Fri, Jan 20, 2023 at 11:33:19AM +0000, David Woodhouse wrote: > > From: David Woodhouse > >=20 > > When running under Xen, hvmloader places a table at 0x1000 with the e82= 0 > > information and BIOS tables. If this isn't present, SeaBIOS will=20 > > currently panic. > >=20 > > We now have support for running Xen guests natively in QEMU/KVM, which > > boots SeaBIOS directly instead of via hvmloader, and does not provide > > the same structure. > >=20 > > As it happens, this doesn't matter on first boot. because although we > > set PlatformRunningOn to PF_QEMU|PF_XEN, reading it back again still > > gives zero. Presumably because in true Xen, this is all already RAM. Bu= t > > in QEMU with a faithfully-emulated PAM config in the host bridge, it's > > still in ROM mode at this point so we don't see what we've just written= . > >=20 > > On reboot, however, the region *is* set to RAM mode and we do see the > > updated value of PlatformRunningOn, do manage to remember that we've > > detected Xen in CPUID, and hit the panic. > >=20 > > It's not trivial to detect QEMU vs. real Xen at the time xen_preinit() > > runs, because it's so early. We can't even make a XENVER_extraversion > > hypercall to look for hints, because we haven't set up the hypercall > > page (and don't have an allocator to give us a page in which to do so). > >=20 > > So just make Xen detection contingent on the info structure being > > present. If it wasn't, we were going to panic anyway. That leaves us > > taking the standard QEMU init path for Xen guests in native QEMU, > > which is just fine. >=20 > Thanks.=C2=A0 I committed this change. >=20 > -Kevin Thanks, Kevin. I'd like to get the rest of the Xen platform support in to qemu 8.0 if possible. Which is currently scheduled for March. Is there likely to be a SeaBIOS release before then which Gerd would pull into qemu anyway, or should I submit a submodule update to a snapshot of today's tree? That would just pull in this commit, and the one other fix that's in the SeaBIOS tree since 1.16.1? $ git shortlog rel-1.16.1.. David Woodhouse (1): xen: require Xen info structure at 0x1000 to detect Xen Qi Zhou (1): usb: fix wrong init of keyboard/mouse's if first interface is not boo= t protocol --=-sroW6G48O+5dXLLiahn3 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwMjAyMDgwNTAxWjAvBgkqhkiG9w0BCQQxIgQgXb8x9FP2 dLdzxyp5RSIdrPlq7/qDMQk4hDF89xX3h/Uwgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgCqRncvkU1L7LeqmTzvESKUO40Gr2DHKjEi RGTQ5dohjRGVUKHnKQDSmL3cYbJXRsAKnvy4hfzFzlgriC5zU2LoI84Rq0Bt1nskIL9lRaD9pvUN JNINB9tykaxomB8NhZfvFDVy1MlT7uLRgs34yic/yFhKr4N9wyCUuR2x8PRYUNIzUSYATdAkrwc4 aPqCKzcpXPcIAk326ifhzC+g+vcdrVPLmdMuQX2p4Gd864zTq8QiLl6cbt2yxHSwRonc17YSbONG M4u6tQWkCId2sVDhDz3fGmX3AWbpc8PN+qmaP08+sa9rty/M+4O2JX1cKlM/mF6U2vG1oQu4VCRX 9GteBwOD1SUYdz+nO51kisxUgXnOslOZ1QaCV9QiWAkBs47wwypEqPpEJG+YKB921l60J3+pWxZL IIXTmZTCcMxlMxVWxMxn3iAKlhwFNpBI2/i3Lu169dmy0lvGXq+HSsHfUPMSlQWLug2vKWG9TArf /9KBXH7UJrSsZ+blvwxmBB+4ZBGQ645LKL/COQsxRc6NbmAlmjYZ4f/pR55S23u9qmdbWI2ktQ7B Iquj1KS/sLRqBhb7NmDkr19UlfJ3IC+E0w3UIrR9JFTRj50QWdn4T2M/4Q5ZOVqKHmpf8DYLX635 QlGdo7Z1oqKnqj9WO9MTHMps8MuLCA4vGDZisZPJDAAAAAAAAA== --=-sroW6G48O+5dXLLiahn3-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:06:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488585.756713 (Exim 4.92) (envelope-from ) id 1pNUcA-0006gn-EJ; Thu, 02 Feb 2023 08:06:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488585.756713; Thu, 02 Feb 2023 08:06:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUcA-0006gg-B6; Thu, 02 Feb 2023 08:06:38 +0000 Received: by outflank-mailman (input) for mailman id 488585; Thu, 02 Feb 2023 08:06:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNUc9-0005Ed-En for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:06:37 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2061e.outbound.protection.outlook.com [2a01:111:f400:7eb2::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 813f7dc2-a2d0-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 09:06:33 +0100 (CET) Received: from DM6PR02CA0116.namprd02.prod.outlook.com (2603:10b6:5:1b4::18) by CH0PR12MB5217.namprd12.prod.outlook.com (2603:10b6:610:d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 08:06:29 +0000 Received: from DM6NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1b4:cafe::88) by DM6PR02CA0116.outlook.office365.com (2603:10b6:5:1b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Thu, 2 Feb 2023 08:06:29 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT067.mail.protection.outlook.com (10.13.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 08:06:28 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:06:24 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:06:21 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 02:06:20 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 813f7dc2-a2d0-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRtbGVeTBKtkpfJcQG1VdvQnehbswqo7QDHWa4TgQVDrU/IQOSVc1t+3HQsqowqIMZe2/TWNx2fpAdFmV1AxGiP7zUwn9+zYDw26u+IUjD/JaFU9l/hpwRXICiIeP5nkiZGtkdftllXfC9MGljAfRk2++mECiyFNvoc2GiI1AxyWINnMMajtKR1mQriBdxT53WeihdRGuW2Yu20QF4rvLM8a9KbGyDAEhMrn3tOZDUt7IKixuotVbOufTQsfa9vppuPRlVN99T7Z4k5+N9flQ+YT/STJaAiBD2eVs3LUT6gnCr6uG7BB8Ymw/zXjPe/r1C49RHhErZ/qaGUhMEmz/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C7VC1h+8je+j4d4guKURpOqcDAiPdLiwramoPfCIikg=; b=bLESw6IL0/GHPSTVP/8kNOxrQutaXSgPiEg/QqwdBkRV9cFKkqWy8yKrNiifVV1qQM3c47Sof4cVydAFJP1B/jbyfSxxbaBogqW3LfZVBwhqc73/hX43AEx4uN/mOY5Fk95eNkN71b/BYs5cxKAGiR5yk/wRLIwqXiXOoASGs2fuERsGDNZ0Rto4K50H9OpfAqn8+uBTcp8XeGd4eIxrbh0w0DvCAq9+0vlepEMJBKsm4He2vezaP40hasiUesM26QUii4Ut2tHSwCLnz0ICZoxFKCoVe2dLuiVkiZyuC1NUawkpaLAumwvedru9v72/C17zSn9EpLJniDWY/6Ijhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C7VC1h+8je+j4d4guKURpOqcDAiPdLiwramoPfCIikg=; b=1gkcNles5cerb5VVw31kyPoey2aflHmjib9LYuP4Gzmh7+2frQ0ePY0tYmEnFNM5quuF9sb8eNrPFofQqBLheNChb1IQhb2b3E0sz/PZYE31bJVRjDdy9SzAJGquvS2bmynijjokLX7oOR40HIeS2AWgzb6zBr0CF9pSSGGbXq8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 2 Feb 2023 09:06:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230131151354.25943-1-michal.orzel@amd.com> <20230131151354.25943-3-michal.orzel@amd.com> <653d05c1-a860-052c-4ce2-55998c77db42@xen.org> <442d7e6b-9b51-69bc-48ea-c844427a4a97@amd.com> <7c09b900-6568-e57d-3256-2cf72a73690c@amd.com> <6d3638e0-5613-ee7b-d919-1db3cd0ca2fb@xen.org> <1c9d7bcb-9ef1-8940-f709-a361285ad206@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <1c9d7bcb-9ef1-8940-f709-a361285ad206@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT067:EE_|CH0PR12MB5217:EE_ X-MS-Office365-Filtering-Correlation-Id: 542277da-ec06-4079-61fc-08db04f46370 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D8+8VKL9GfYLkS3emGDRrAMXHVvqIAa58T8K8sFtyekj9065IMcCKaBs8gCRZHzEtAv89/w9mvSkur8fTNNLTP9INC57WShjNUlNtZdTR2gFeJD6DJV/aI3hK2OnWoa/lh5ljxhUxK5K0oAaqUvhyi/AxU4OOAhRC3D12cyW+oGEUsYUrUD1nzFE4QtJbglxH0NwVJTOwNk4p7gGsOdrIBGT9FpTeLqPGLnV7yelBp8D9lDqicRN6KRIwT5zNM6352T+vVSVSLsi/kchcpC8tFIIiGAts1h7Lw+UONUDBUiA5ejdGBsK/mpM2BzNxmcS8vTuWShkqDtgHX0HqsNSapVfzyNFv5t5frHRVKkpHzkC7Fzx6ztzV7/y2rgFXgDvcZ3qJ1XcbHpt2XbtZ3yN6Z6+CY7rM/h9G1iM6N3yke0/gSKIxYdFT54xCp0uuD97iaQ/qworwFoCKqht4/KZmqjRFon05TswFT+nKk5yHHO6tK3iXSEglMcFH+7Kd98dSSrA1LFkIi755vXk482Om8Ew41Mdag1yjkiRa7r4gkvy9CSMlFwNmGX02cDyAqW/BN3dwFqy1UgjlgkpYQh6FFk+PBwXJTtscDeEVYKVvwsE5wd+aUqVe0g6oPLrByqyQs5roZp7RXQHwAg4eDD31gTGEU6umsE76/FWGgYRFQ0XLFm+QRLBxKyl9AOgMtOYHwHZr4DcrcDxG3hGCCsz0jTtVLZpCph86S4+SXISaPQ1vO71JF5mSYAFXE/UUVQ4CjlDc8p23EJ70atmVype0Q== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199018)(46966006)(36840700001)(40470700004)(47076005)(356005)(81166007)(82310400005)(86362001)(40460700003)(36756003)(31696002)(40480700001)(36860700001)(82740400003)(31686004)(44832011)(4326008)(8676002)(41300700001)(2906002)(8936002)(110136005)(54906003)(16576012)(5660300002)(316002)(2616005)(83380400001)(336012)(426003)(478600001)(26005)(70586007)(70206006)(186003)(53546011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:06:28.9116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 542277da-ec06-4079-61fc-08db04f46370 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5217 Hi Julien, On 01/02/2023 19:54, Julien Grall wrote: > > > On 01/02/2023 12:56, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 01/02/2023 12:20, Julien Grall wrote: >>> >>> >>> On 01/02/2023 11:01, Michal Orzel wrote: >>>> I would prefer not to do this in this series as the goals are different. This series is to remove >>>> the known Xen limitation. >>> >>> The reason I am asking is it effectively change the way you would >>> implement. If we were going to support zImage/Image within uImage, then >>> we would need to fallthrough rather than calling kernel_decompress(). >>> >>> I am not aware of any at the moment. Better asking now than realizing >>> after the fact that there is a need... >> We need uImage support as there is more and more need to support booting >> raw images of some RTOSes (there is always additional concern \wrt booting requirements >> but at least the header allows to try to boot them). We are not aware of any need >> to do some special handling to parse more than one header + from what I said earlier, >> this is an unusual approach not seen to be handled by anyone. >> >>> >>>>>> This could be solved by doing (not harmful in my opinion for common case) >>>>>> addr &= PAGE_MASK. >>>>> I don't quite understand your argument here. We need a check that work >>>>> for everyone (not only in the common case). >>>> As we assume the kernel module is at page aligned address (otherwise the issue you observed >>>> can happen not only in uImage compressed case) >>> >>> I am not aware of such assumption. It is allowed to use non page-aligned >>> address and it is correct for Xen to not free the first part if it is >>> not page aligned because the first part may contain data from another >>> module (or else). >>> >>>> , having a check like >>>> this is generic. I.e. for normal usecase (no uImage compressed), addr &= PAGE_MASK >>>> does not modify the address. For uImage compressed usecase it causes the addr to get >>>> back to the previous value (before we added header size to it). >>>> >>>> Apart from the addr, we need to pass the correct size (as we extracted header size from it). >>>> We could have the following (with appropriate comment): >>>> size += addr - (addr & PAGE_MASK); >>>> addr &= PAGE_MASK; >>>> fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); >>>> >>>> It does not look great but solves the uImage issue and does not modify >>>> the previous behavior. Anyway, I'm open for suggestions. >>> >>> Two options: >>> 1) Move the call to fw_unreserved_regions() outside of >>> kernel_decompress(). >>> 2) Pass the offset of the gzip header to kernel_decompress(). >>> Something like where it would be sizeof(uimage) in the uImage case or 0 >>> otherwise. >>> >>> I have a slight preference for the latter. >> That is cool. >> I'm in favor of this as well because it would allow not to set mod->start,size >> from kernel_uimage_probe. Everything can be done in kernel_decompress: >> >> Diff: > > A few comments because you resend the patch with it included. > >> >> -static __init int kernel_decompress(struct bootmodule *mod) >> +static __init int kernel_decompress(struct bootmodule *mod, uint32_t offset) >> { >> char *output, *input; >> char magic[2]; >> @@ -201,8 +201,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >> struct page_info *pages; >> mfn_t mfn; >> int i; >> - paddr_t addr = mod->start; >> - paddr_t size = mod->size; >> + >> + /* >> + * It might be that gzip header does not appear at the start address >> + * (i.e. in case of compressed uImage) so take into account offset to > > NIT: I would use 'e.g.' because in the future we may have multiple > reason where the offset is not zero. > >> + * gzip header. >> + */ > + paddr_t addr = mod->start + offset; >> + paddr_t size = mod->size - offset; > > You want to check that mod->size is at least equal to offset. Sounds reasonable. Thanks. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:49:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:49:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488597.756746 (Exim 4.92) (envelope-from ) id 1pNVHh-0004gt-Bp; Thu, 02 Feb 2023 08:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488597.756746; Thu, 02 Feb 2023 08:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHh-0004gi-8J; Thu, 02 Feb 2023 08:49:33 +0000 Received: by outflank-mailman (input) for mailman id 488597; Thu, 02 Feb 2023 08:49:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHf-0004Po-40 for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:49:31 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062b.outbound.protection.outlook.com [2a01:111:f400:7e8a::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 807f5548-a2d6-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 09:49:29 +0100 (CET) Received: from BN0PR07CA0027.namprd07.prod.outlook.com (2603:10b6:408:141::29) by MN2PR12MB4144.namprd12.prod.outlook.com (2603:10b6:208:15f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 08:49:26 +0000 Received: from BN8NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::89) by BN0PR07CA0027.outlook.office365.com (2603:10b6:408:141::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 08:49:26 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT100.mail.protection.outlook.com (10.13.177.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 08:49:25 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:49:25 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:49:24 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 02:49:23 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 807f5548-a2d6-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kuVJthUGCa09GTKS0EdP6f4hTLpeMnnkTLSwgnm826TtFbAyRU+B8pxNsZh43Hn6Bggt85iiWSXz+LjqjumrNG4c04oRNXAJeXRjwniUNrim1QhCFbrSAVkF9gd+7CNsWpSt4VrPQx+dI+XmTwVztbDF8aEiznnQd9ZZP/oHg7Jnmw0Ep8Eyl0rdYVB5OpndnK89dC9Q1PL4oOvFSi94Cf3kUyOuW9IWOD5EWIGmIxDoPFYlOWIEQS6U6bI/a5hIFVB5Vd6TJaXnhieYV5znmgmB9VTsA6ymbSdSWv/qAgj0XRUVrTUn7FwWoPMydtz4D2sg7SGlvR4zTjlGWmdPqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=miuqtHseJ/K4LAnHtbyabXWBQMCXuBv77extmOJaVLI=; b=WfhLy2kk80raGa+6whBBrfBbW5XRL8UIZAnPnYXjFYnTvkzy83SpmI7wk2Lot7VLdcoSRCIIrqNXo30zcuPNm8I10uxmUMI8RS31+Pf3UwSEoSfUrkAmfqkavJwe0J7BUn/p7nBsfG/er2aWByMO+dcf5OlB7y3UFOoLH0EGl9IxDZp7CKx0R+wywQhTcaAMsgCoj8deqy2IkPuUjF0jLh8gXnz3HcOOSnjZpb3WB5sh7ZEowc79/7o02mVoqb6IZOPgVzA0STR2G02DqRw4tNLEphNLKDVrrQAD0vQz/riT6wm5hfdobv5g+320061bKVr2ISsBp01xZDyGqA9YpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=miuqtHseJ/K4LAnHtbyabXWBQMCXuBv77extmOJaVLI=; b=u4leEexpxx66l2PnCRg+IZAoMYDUDbU/j70UFFRQqZFWx7aXMaE5N0IzIBU5EGKYNgTfN+UBf0B3IHLIiNImLoOYCEjQa7HUhfMWWSOR2Z8N7W7kbl3X/GzUl+CMFA1U8iDSinWDQFkQeENtvEMlEknftWPc8qlXvXabyEg5PiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Subject: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Date: Thu, 2 Feb 2023 09:49:05 +0100 Message-ID: <20230202084905.6950-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202084905.6950-1-michal.orzel@amd.com> References: <20230202084905.6950-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT100:EE_|MN2PR12MB4144:EE_ X-MS-Office365-Filtering-Correlation-Id: 4668ee20-1fd5-4fcb-dfc4-08db04fa6323 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QKH7W3GkJDN+g6OsPSdY3ZpHlhljVW4Yqaczo3RUqtl5u5y3CdvhJIPxCeUMiweKd6czLlHcU9o9UeVQYbhBCj3064TkBRGFafE0Jv8G+3b8ltZU6Foc04Hu/CL/goEfFji8N+XPzdaICndsbTElI2ZiSALRi0iuovWrwfDd08AQw2s/zUIk0/g1L2gj/vtfQMe2EVyvliLAc0at1TvOk5D/nB57mflE23LjeI2Qlc6K+MSU5+YYHlKyHrshRMB3cGLv/Hu3psyEiTBUQEx1Hu2+D6/Ss1H5+IKgVVeQ5ycUWE2JmhhpipJQXfV6v/yljS8nPXRvFmfRBvEbrYVwkFRgqmBQP9cpC4Z5RWzgjzH7l9Ej+AXgRoN6c9uH5ZtzkbQ0gkszit88sOcU/YzTeQfcyddqPmppa/TrXM6X8sFPqXVsN9oAWc0MQiktaN1LsQ2Inkd7H/hVL1ClErX2pKWTayZ4sxYP0bO52JT4wQt32v2fLSrTSBEMI1SEG+sd5NEDWt5fNrLSz/GLcMXt0nbfdWx5s8PN7W3VKoCdF1AV1X3zPb1/kQhhJGtGJ4llEsC/5B83gtxT/atKx8WHhdEKgWAv1yOX3aSzTBuFy3YGDY2m+ga7r7Z9psssbO1HwIPSqaFqucvIbOArKh9lvFBg2qmD++n12Sp7uCK0P7GDfxFOh+NhMsJCvThr0gztt204Nik4cXKTZERgqZGLX5F0XbEt6cZwH9yW15GBcZo= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199018)(36840700001)(40470700004)(46966006)(40460700003)(36860700001)(478600001)(316002)(54906003)(186003)(26005)(36756003)(1076003)(6666004)(82310400005)(86362001)(5660300002)(2906002)(44832011)(4326008)(6916009)(70586007)(70206006)(8676002)(41300700001)(8936002)(40480700001)(426003)(83380400001)(336012)(2616005)(47076005)(356005)(81166007)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:49:25.4375 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4668ee20-1fd5-4fcb-dfc4-08db04fa6323 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4144 At the moment, Xen does not support booting gzip compressed uImages. This is because we are trying to decompress the kernel before probing the u-boot header. This leads to a failure as the header always appears at the top of the image (and therefore obscuring the gzip header). Move the call to kernel_uimage_probe before kernel_decompress and make the function self-containing by taking the following actions: - take a pointer to struct bootmodule as a parameter, - check the comp field of a u-boot header to determine compression type, - in case of compressed image, call kernel_decompress passing uImage header size as an offset to gzip header, - set up zimage.{kernel_addr,len} accordingly, - return -ENOENT in case of a u-boot header not found to distinguish it amongst other return values and make it the only case for falling through to try to probe other image types. Modify kernel_decompress to take an additional parameter being an offset to a gzip header from start address. This is needed so that a function can first operate on a region containing actually compressed kernel (in case of compressed uImage, size of u-boot header is an offset to a gzip header) and then at the end pass the entire region (as it was before taking an offset into account) to fw_unreserved_regions for freeing. This approach avoids splitting the uImage probing into 2 stages (executed before and after decompression) which otherwise would be necessary to properly parse header, update boot module start and size before decompression and update zimage.{kernel_addr,len} afterwards. Remove the limitation from the booting.txt documentation. Signed-off-by: Michal Orzel --- Changes in v2: - modify kernel_decompress to take an offset to gzip header --- docs/misc/arm/booting.txt | 3 -- xen/arch/arm/kernel.c | 81 ++++++++++++++++++++++++++++++++++----- 2 files changed, 72 insertions(+), 12 deletions(-) diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt index bd7bfe7f284a..02f7bb65ec6d 100644 --- a/docs/misc/arm/booting.txt +++ b/docs/misc/arm/booting.txt @@ -50,9 +50,6 @@ Also, it is to be noted that if user provides the legacy image header on top of zImage or Image header, then Xen uses the attributes of legacy image header to determine the load address, entry point, etc. -Known limitation: compressed kernels with a uboot headers are not -working. - Firmware/bootloader requirements -------------------------------- diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 068fbf88e492..7dd082b5772c 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -191,7 +191,7 @@ static __init uint32_t output_length(char *image, unsigned long image_len) return *(uint32_t *)&image[image_len - 4]; } -static __init int kernel_decompress(struct bootmodule *mod) +static __init int kernel_decompress(struct bootmodule *mod, uint32_t offset) { char *output, *input; char magic[2]; @@ -204,6 +204,17 @@ static __init int kernel_decompress(struct bootmodule *mod) paddr_t addr = mod->start; paddr_t size = mod->size; + if ( size < offset ) + return -EINVAL; + + /* + * It might be that gzip header does not appear at the start address + * (e.g. in case of compressed uImage) so take into account offset to + * gzip header. + */ + addr += offset; + size -= offset; + if ( size < 2 ) return -EINVAL; @@ -250,6 +261,14 @@ static __init int kernel_decompress(struct bootmodule *mod) for ( ; i < (1 << kernel_order_out); i++ ) free_domheap_page(pages + i); + /* + * When freeing the kernel, we need to pass the module start address and + * size as they were before taking an offset to gzip header into account, + * so that the entire region will be freed. + */ + addr -= offset; + size += offset; + /* * Free the original kernel, update the pointers to the * decompressed kernel @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) #define IH_ARCH_ARM 2 /* ARM */ #define IH_ARCH_ARM64 22 /* ARM64 */ +/* uImage Compression Types */ +#define IH_COMP_GZIP 1 + /* * Check if the image is a uImage and setup kernel_info */ static int __init kernel_uimage_probe(struct kernel_info *info, - paddr_t addr, paddr_t size) + struct bootmodule *mod) { struct { __be32 magic; /* Image Header Magic Number */ @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, } uimage; uint32_t len; + paddr_t addr = mod->start; + paddr_t size = mod->size; if ( size < sizeof(uimage) ) return -EINVAL; @@ -294,13 +318,21 @@ static int __init kernel_uimage_probe(struct kernel_info *info, copy_from_paddr(&uimage, addr, sizeof(uimage)); if ( be32_to_cpu(uimage.magic) != UIMAGE_MAGIC ) - return -EINVAL; + return -ENOENT; len = be32_to_cpu(uimage.size); if ( len > size - sizeof(uimage) ) return -EINVAL; + /* Only gzip compression is supported. */ + if ( uimage.comp && uimage.comp != IH_COMP_GZIP ) + { + printk(XENLOG_ERR + "Unsupported uImage compression type %"PRIu8"\n", uimage.comp); + return -EOPNOTSUPP; + } + info->zimage.start = be32_to_cpu(uimage.load); info->entry = be32_to_cpu(uimage.ep); @@ -330,8 +362,27 @@ static int __init kernel_uimage_probe(struct kernel_info *info, return -EINVAL; } - info->zimage.kernel_addr = addr + sizeof(uimage); - info->zimage.len = len; + if ( uimage.comp ) + { + int rc; + + /* + * In case of a compressed uImage, the gzip header is right after + * the u-boot header, so pass sizeof(uimage) as an offset to gzip + * header. + */ + rc = kernel_decompress(mod, sizeof(uimage)); + if ( rc ) + return rc; + + info->zimage.kernel_addr = mod->start; + info->zimage.len = mod->size; + } + else + { + info->zimage.kernel_addr = addr + sizeof(uimage); + info->zimage.len = len; + } info->load = kernel_zimage_load; @@ -561,8 +612,22 @@ int __init kernel_probe(struct kernel_info *info, printk("Loading ramdisk from boot module @ %"PRIpaddr"\n", info->initrd_bootmodule->start); - /* if it is a gzip'ed image, 32bit or 64bit, uncompress it */ - rc = kernel_decompress(mod); + /* + * uImage header always appears at the top of the image (even compressed), + * so it needs to be probed first. Note that in case of compressed uImage, + * kernel_decompress is called from kernel_uimage_probe making the function + * self-containing (i.e. fall through only in case of a header not found). + */ + rc = kernel_uimage_probe(info, mod); + if ( rc != -ENOENT ) + return rc; + + /* + * If it is a gzip'ed image, 32bit or 64bit, uncompress it. + * At this point, gzip header appears (if at all) at the top of the image, + * so pass 0 as an offset. + */ + rc = kernel_decompress(mod, 0); if ( rc && rc != -EINVAL ) return rc; @@ -570,8 +635,6 @@ int __init kernel_probe(struct kernel_info *info, rc = kernel_zimage64_probe(info, mod->start, mod->size); if (rc < 0) #endif - rc = kernel_uimage_probe(info, mod->start, mod->size); - if (rc < 0) rc = kernel_zimage32_probe(info, mod->start, mod->size); return rc; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:49:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:49:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488596.756735 (Exim 4.92) (envelope-from ) id 1pNVHf-0004Qi-3h; Thu, 02 Feb 2023 08:49:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488596.756735; Thu, 02 Feb 2023 08:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHf-0004Qb-0B; Thu, 02 Feb 2023 08:49:31 +0000 Received: by outflank-mailman (input) for mailman id 488596; Thu, 02 Feb 2023 08:49:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHe-0004Po-2O for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:49:30 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20613.outbound.protection.outlook.com [2a01:111:f400:fe5b::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fa8a137-a2d6-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 09:49:27 +0100 (CET) Received: from BN9P223CA0018.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::23) by MN2PR12MB4566.namprd12.prod.outlook.com (2603:10b6:208:26a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 08:49:23 +0000 Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::5f) by BN9P223CA0018.outlook.office365.com (2603:10b6:408:10b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 08:49:23 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 08:49:23 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:49:23 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 02:49:21 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fa8a137-a2d6-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyRUAm/cHRaiZzLVhUFT09Xd8ko0DaHnNBubjdzjLI3pbXVNb1ip5qV1V7sqUEoGLmBupkyd9u9h98SN7BjbG5eQncvb06uEfUx6R83F3n9d7lF480A8gcgGEhb8z+qgj5s7BPXt0LnwuYQkNo/Ks40lRUJOQXnV1k087b7VuyNjT4LQcKTqrD2GktdAS3WLUF7VsF2C/xCTlLPlaSjZqHrtLKadT5UdZbq2AQHqvgaFx/3O1fLaf9BN0dZTJMit7ED0nJJC26ZRNuUvf6hrKnEv/lUl1y3UtzvXdaR9OrCXf8j6VoAWT5pD3Tahdw2Lg9Q4JZPT3y15EVVL9vAUpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uBLNfq0kNGD8ONWUKgdnR9q15jFiaFT0XCVIzdVZEEQ=; b=HdSCxB4cmaEp3gMxkc7lZ8ajtDdppAjoNG4IAzFNPJAE7tudJjNsqnzeLsqgR8+BImrNgjA2wZ0SSlfaARnu+MkQyB4cEc/JBJQkq5u6YfhNQ+8uAzZYtTQYAP4RVhuiggbFqE6as4yudezNvREj6B7WdFDeEQ1DvMp1Q3v4GQzzjf/edYbPfl7VTeMdrrFyZbQ5ggU93UDbMh+xUC+G2NNJlUHMTebYRRYaBu22ChoIBYza8Z0GtnLcjLe3QWJcJMIvDEakKGvxlBojMsHHcaEtTY6F6Uy+bylZN4gleVQMecwOKXOVNzd6zf1F5Civ7TsQwgHw/YEmh7Xe011gVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBLNfq0kNGD8ONWUKgdnR9q15jFiaFT0XCVIzdVZEEQ=; b=rE0oexAgbSG2eNPfXT3Qm+4P6dIxL7KP1I7Zs/fBEEEgbjScC+rdvUgyAFEXIlvchlCfq2u+iFvY4AWReIHBDmWoIPpyPYETbPYsoZD+n2xx95kFTdZZbFO6N5uK4ztld8dihtuRt0OpNM/VGN1vdlBYNSa+EVbxGINd9D85oQE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , , Ayan Kumar Halder , "Julien Grall" Subject: [PATCH v2 1/2] xen/arm: Move kernel_uimage_probe definition after kernel_decompress Date: Thu, 2 Feb 2023 09:49:04 +0100 Message-ID: <20230202084905.6950-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202084905.6950-1-michal.orzel@amd.com> References: <20230202084905.6950-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|MN2PR12MB4566:EE_ X-MS-Office365-Filtering-Correlation-Id: c8f362ae-692a-4ced-581a-08db04fa61fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6YaMZPcBI8LpF1WcIFBuro0VZRysGKakmq/xz/mJv+ArpSo1zJqrh32QjBcq19dhf46tqgcJ/ItzvrbN/u1yOrRX1lNbWKYKWOWc8gjnXqnTqAjUDf/BF76yauoV5DKJdEiVm13XHXNOh7hf4f0QHV/sxFd+c3W4RDIlAVR6AEMDpSmQKzhIkQ4bEXmS5iK1ygd/PTamSNrbUH/lL+rlYK4QcXtpGSXwbeRVZgmeG1O384eTHgkpcgvaB5LA+XpKQdx3enkGhQO/VtVmJToGcMbNBuDmjeB2rlqNqdhBKfbEYmHDFCcE0qkXtKuq+ZM3WJxCmTi29s+JWZdrcO6UbpZRslXW82FR8hC5F62pA5QkV4mm1hhArZjmgVmSvIz6tASCAYWq1iRBXCVMgLigC4SekuQ2SUWYwuLHwtalgPbhZ2Y0YhWqqPFoc/xSZfSZr0o9aG3O0aPN97lI5DlBFPhuzL6kA8NcGAMJFYyrfN/VL0lPjOLs7Z0U7adQymKEwUqSGAz8/YBHncWrBJDcszFqpqoehUP529bF5x9tMOP5xLEgh0N85YfJhiQpuW62UREsqCQAwbl3RFQZKQrH0yUi2hCG68A0tXFfmyoKfqgx0xks8BN+S6FrO6AwZGlmkELcnpplo9NCy9WrIi/AwlaLQf04kUFDXK6qweJ2HfH/AYEVS06FFlNjvA9ZLEvPKlJ3dXorPwSpY18+swUeUfRNY8PHSoVF3IAUhwT/BZU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(396003)(376002)(451199018)(40470700004)(36840700001)(46966006)(2616005)(336012)(40460700003)(40480700001)(82310400005)(36756003)(36860700001)(86362001)(82740400003)(8936002)(5660300002)(316002)(44832011)(356005)(54906003)(41300700001)(426003)(47076005)(81166007)(2906002)(83380400001)(6916009)(1076003)(4326008)(186003)(8676002)(478600001)(26005)(6666004)(70206006)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:49:23.4720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8f362ae-692a-4ced-581a-08db04fa61fa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4566 In a follow-up patch, we will be calling kernel_decompress function from within kernel_uimage_probe to support booting compressed images with u-boot header. Therefore, move the kernel_uimage_probe definition after kernel_decompress so that the latter is visible to the former. No functional change intended. Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder Acked-by: Julien Grall --- Changes in v2: - add Rb and Ab --- xen/arch/arm/kernel.c | 146 +++++++++++++++++++++--------------------- 1 file changed, 73 insertions(+), 73 deletions(-) diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 36081e73f140..068fbf88e492 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -186,6 +186,79 @@ static void __init kernel_zimage_load(struct kernel_info *info) iounmap(kernel); } +static __init uint32_t output_length(char *image, unsigned long image_len) +{ + return *(uint32_t *)&image[image_len - 4]; +} + +static __init int kernel_decompress(struct bootmodule *mod) +{ + char *output, *input; + char magic[2]; + int rc; + unsigned int kernel_order_out; + paddr_t output_size; + struct page_info *pages; + mfn_t mfn; + int i; + paddr_t addr = mod->start; + paddr_t size = mod->size; + + if ( size < 2 ) + return -EINVAL; + + copy_from_paddr(magic, addr, sizeof(magic)); + + /* only gzip is supported */ + if ( !gzip_check(magic, size) ) + return -EINVAL; + + input = ioremap_cache(addr, size); + if ( input == NULL ) + return -EFAULT; + + output_size = output_length(input, size); + kernel_order_out = get_order_from_bytes(output_size); + pages = alloc_domheap_pages(NULL, kernel_order_out, 0); + if ( pages == NULL ) + { + iounmap(input); + return -ENOMEM; + } + mfn = page_to_mfn(pages); + output = __vmap(&mfn, 1 << kernel_order_out, 1, 1, PAGE_HYPERVISOR, VMAP_DEFAULT); + + rc = perform_gunzip(output, input, size); + clean_dcache_va_range(output, output_size); + iounmap(input); + vunmap(output); + + if ( rc ) + { + free_domheap_pages(pages, kernel_order_out); + return rc; + } + + mod->start = page_to_maddr(pages); + mod->size = output_size; + + /* + * Need to free pages after output_size here because they won't be + * freed by discard_initial_modules + */ + i = PFN_UP(output_size); + for ( ; i < (1 << kernel_order_out); i++ ) + free_domheap_page(pages + i); + + /* + * Free the original kernel, update the pointers to the + * decompressed kernel + */ + fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); + + return 0; +} + /* * Uimage CPU Architecture Codes */ @@ -289,79 +362,6 @@ static int __init kernel_uimage_probe(struct kernel_info *info, return 0; } -static __init uint32_t output_length(char *image, unsigned long image_len) -{ - return *(uint32_t *)&image[image_len - 4]; -} - -static __init int kernel_decompress(struct bootmodule *mod) -{ - char *output, *input; - char magic[2]; - int rc; - unsigned int kernel_order_out; - paddr_t output_size; - struct page_info *pages; - mfn_t mfn; - int i; - paddr_t addr = mod->start; - paddr_t size = mod->size; - - if ( size < 2 ) - return -EINVAL; - - copy_from_paddr(magic, addr, sizeof(magic)); - - /* only gzip is supported */ - if ( !gzip_check(magic, size) ) - return -EINVAL; - - input = ioremap_cache(addr, size); - if ( input == NULL ) - return -EFAULT; - - output_size = output_length(input, size); - kernel_order_out = get_order_from_bytes(output_size); - pages = alloc_domheap_pages(NULL, kernel_order_out, 0); - if ( pages == NULL ) - { - iounmap(input); - return -ENOMEM; - } - mfn = page_to_mfn(pages); - output = __vmap(&mfn, 1 << kernel_order_out, 1, 1, PAGE_HYPERVISOR, VMAP_DEFAULT); - - rc = perform_gunzip(output, input, size); - clean_dcache_va_range(output, output_size); - iounmap(input); - vunmap(output); - - if ( rc ) - { - free_domheap_pages(pages, kernel_order_out); - return rc; - } - - mod->start = page_to_maddr(pages); - mod->size = output_size; - - /* - * Need to free pages after output_size here because they won't be - * freed by discard_initial_modules - */ - i = PFN_UP(output_size); - for ( ; i < (1 << kernel_order_out); i++ ) - free_domheap_page(pages + i); - - /* - * Free the original kernel, update the pointers to the - * decompressed kernel - */ - fw_unreserved_regions(addr, addr + size, init_domheap_pages, 0); - - return 0; -} - #ifdef CONFIG_ARM_64 /* * Check if the image is a 64-bit Image. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 08:49:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 08:49:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488595.756724 (Exim 4.92) (envelope-from ) id 1pNVHc-0004Be-R8; Thu, 02 Feb 2023 08:49:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488595.756724; Thu, 02 Feb 2023 08:49:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHc-0004BX-OY; Thu, 02 Feb 2023 08:49:28 +0000 Received: by outflank-mailman (input) for mailman id 488595; Thu, 02 Feb 2023 08:49:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVHb-0004BR-Vk for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 08:49:28 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20616.outbound.protection.outlook.com [2a01:111:f400:7e8b::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e8c2c50-a2d6-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 09:49:25 +0100 (CET) Received: from BN9PR03CA0635.namprd03.prod.outlook.com (2603:10b6:408:13b::10) by SA0PR12MB7092.namprd12.prod.outlook.com (2603:10b6:806:2d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 08:49:22 +0000 Received: from BN8NAM11FT080.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13b:cafe::fa) by BN9PR03CA0635.outlook.office365.com (2603:10b6:408:13b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Thu, 2 Feb 2023 08:49:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT080.mail.protection.outlook.com (10.13.176.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 08:49:21 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 02:49:21 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 02:49:19 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e8c2c50-a2d6-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekFfT8jY++frHPAdzxDLftK0xJsyhat1XmOaBf87Nt3t9DQ4bLlRv1G4sawboGhZDu/Ku4yWem6czwSO3uAdoiqqFFInggJ0QT7aGo6DLwDesGJgzQNnjq6kz/pluPFdc1wPZFu89nrwm1/jsgLQBsi2K3GsODrFTsC2id50pNDfTtq79yF5FASL3cjHuJyc8Im1+kbVvpH2B3dYJTvfOgIVsdw+E45OJlDkjC5fVStYlanON9EmxJROYyuDXAX8fW8lP4hpnI4Pl/EHyO1KLOhk/dMbS8TrjmZaYVT/oLe/Hpf9DtCIMZW7GHmrhL420OLbOBlECJpc0oZAIHF67g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+6Eo5jZUWqNLVzdk/vGpM1jEX2B1rRX1AXUhmQQCXhs=; b=BwTsKNk9iwvVGlEVpgEifjjfngN2uCjTxArBxM4T622sjhNEnPCX5GIU2wRk+JdBwDgC2hjNv5GGNznsoxI42HiRRrHPHMpPHtFBw8nR81kutNCPoDMvyuRjJqV5XWrsYRPEVw6B6QsoisZnVkf1PliVLlfjtL94I4NB9AgSXmJWJz3ZiL9v/0qlHMYKG1uANC1ntrcxnQz4B0U6OeDT77ChvdZw65/FX5exDHMxVWgedsY/zjIK9/72GXd2DaVAx5QLmrme/QKKtAsux6PbhK55Kpt6A7jjETgd0VKEdppY7WAsSXEtUCH+dOYTj1EiA4MPbT9hm83fUlTFcKmi4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+6Eo5jZUWqNLVzdk/vGpM1jEX2B1rRX1AXUhmQQCXhs=; b=g3x2Ww96wbCdBeWlxKZHWkg2zREUK0jb2pqRQtg4EmuXk0B8h9MJotgND8lyvbo3UQpoXxY5W3kYPJ8ofO6CLP9qtKCz+CMrQJxCecUVHqvxnxMFGTuKr3PCKdGmSwndaPy1HSC141Hk3Tq5CYyX0aXvgRNM+ruVZCq02RlnAL0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Subject: [PATCH v2 0/2] xen/arm: Support compressed uImages Date: Thu, 2 Feb 2023 09:49:03 +0100 Message-ID: <20230202084905.6950-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT080:EE_|SA0PR12MB7092:EE_ X-MS-Office365-Filtering-Correlation-Id: 76d1f9e4-7376-4f2c-c897-08db04fa60c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: carQG3Gw2jJm24uj+vddp0JZnsDMtW5qhf6S5aYxRVBM6X4+dMwrt2QAvI/1JnfIPEeNC+5IA/bikOlFIieHrwp+jLqV8gVhh3NroqrH8rtsq9APrXAm7ZDy+ETIR0amfIs87mP86thDzcRsg2qp3pGM0I5jCO+uJ6tlSTfJ4MVqdhj+uURw2pIaBY79Ol3LuyFIVBWxyZRmd/vN5EEAw73tuvJIrJYl2gFdo5wia3rjwzfumrPqQH1yIk73EM3DhJzCKRyvjNYweqZnvzbpJWbMXXo+cLMzZPCmMvM55URJ1Wp/fshc2ufd+4VOlKAAvXkTbVlCD1FBy0eostIAaYwOP05Cv/saUQHSpahf2+POBTHgV9kLNk9DcJkAMGlt25is2+sIM1alEkLbux6tp290nlnb5iYWNG3ujVfJ46ayHJHclhJAspaeIE7ZoX6A1tk1r9yb8xIfXWNc7CQrESeTHwRhwA9bvGlEZ0jr2F2DfYkYW6/Gpio+P/SMw621x9zCqG6xrhoTNVAT6RH/k/j4woOU5pVWrALnynYr60GOGQZ4hnk9SI4MiLzsu2kXNMLszbXh6uDGTMYl6gzIzXrQlMlD6/UpFjSTRawp7YVVotFmk5xcW3OV7eYPW5s369S73Z2weczHEScJi2i4TZd+6bIOEAnPPhkh9XOSDTxQjZ8e+KelFkWdfCv1EwoWRfUZAnxnpYkRQao7g52wrod0xtNkQk/RvZGO0K7MUqw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199018)(36840700001)(46966006)(40470700004)(8936002)(2616005)(54906003)(5660300002)(316002)(4326008)(2906002)(41300700001)(8676002)(70586007)(6916009)(70206006)(6666004)(478600001)(26005)(1076003)(186003)(426003)(83380400001)(336012)(82310400005)(356005)(81166007)(47076005)(44832011)(40480700001)(86362001)(40460700003)(36756003)(36860700001)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 08:49:21.4432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76d1f9e4-7376-4f2c-c897-08db04fa60c4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT080.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7092 This series adds support for booting gzip compressed images with u-boot header. Currently Xen does not support such images because we are trying to decompress the kernel before probing uImage header. The problem can be solved using 2 different approaches: 1) Split uImage probing into 2 stages. The first stage is called before decompression, does the usual probing and sets up correctly module start address and size by taking the uImage header size into account. The second stage is called after decompression to update the zimage.{kernel_addr,len}. 2) Call the decompression function (modified to take gzip offset) from within the uImage probing to avoid the split and to make the function self-containing. This way the only case for falling through to try to probe other image types is when there is no u-boot header detected. In this series the second approach is taken that results in a better looking code. Michal Orzel (2): xen/arm: Move kernel_uimage_probe definition after kernel_decompress xen/arm: Add support for booting gzip compressed uImages docs/misc/arm/booting.txt | 3 - xen/arch/arm/kernel.c | 225 ++++++++++++++++++++++++-------------- 2 files changed, 144 insertions(+), 84 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 09:02:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 09:02:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488612.756756 (Exim 4.92) (envelope-from ) id 1pNVUM-00084M-Jn; Thu, 02 Feb 2023 09:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488612.756756; Thu, 02 Feb 2023 09:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVUM-00084F-GR; Thu, 02 Feb 2023 09:02:38 +0000 Received: by outflank-mailman (input) for mailman id 488612; Thu, 02 Feb 2023 09:02:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVUL-000843-8D; Thu, 02 Feb 2023 09:02:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVUL-0005ov-65; Thu, 02 Feb 2023 09:02:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVUK-0002Fc-RG; Thu, 02 Feb 2023 09:02:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNVUK-0005Xu-Qo; Thu, 02 Feb 2023 09:02:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UFfMNsg/uFbWRlKk2krYdJsX81oRXNvoPfo1UYD6Dt8=; b=gNViaiClOJXAPZOSJ0Ft+T1HTN xnWtzjSOAkfKK20es0mKQYlF4Zbx+klnB8ASompZDUwAvIioPcgcnO3CmSdR+/sr+P8xbPZkEHOO0 6mqee5T8kY7nAvMn1yAUQ5FbHDc/XIAGtQUNx8U5qRRrPOlEAH/A40R1jmCowd59/orE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176330: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 09:02:36 +0000 flight 176330 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176330/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 09:10:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 09:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488619.756767 (Exim 4.92) (envelope-from ) id 1pNVcA-0001Uv-ET; Thu, 02 Feb 2023 09:10:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488619.756767; Thu, 02 Feb 2023 09:10:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVcA-0001Uo-Bv; Thu, 02 Feb 2023 09:10:42 +0000 Received: by outflank-mailman (input) for mailman id 488619; Thu, 02 Feb 2023 09:10:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNVc9-0001Ui-0j for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 09:10:41 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72f4c341-a2d9-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 10:10:35 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-3wgXyEPcNUqvvKI41lMPKQ-1; Thu, 02 Feb 2023 04:10:33 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 742D0183B3C6; Thu, 2 Feb 2023 09:10:33 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 388DB112132C; Thu, 2 Feb 2023 09:10:33 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 987DB180061B; Thu, 2 Feb 2023 10:10:31 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72f4c341-a2d9-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675329035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oInIPsGtgF1SdUE94O8ESsQmc4oBdOS27jmpiGR5HWs=; b=YSR2sjcK4ZxLucgdHowxm4cHqQOeNeI/32yI3ZuOjtWbvuvKpbzKZDW5EmNsYrW/OykgqT KvqUNppGq4BXuTH8TKcV6L8pP6EEQ9h8SC15lCRyxl3E9h+Pw6D/9G8B8RXClr0EImzt2X vHSh0P+AeusPDwD4X/IAYg99xGAWeL0= X-MC-Unique: 3wgXyEPcNUqvvKI41lMPKQ-1 Date: Thu, 2 Feb 2023 10:10:31 +0100 From: Gerd Hoffmann To: David Woodhouse Cc: Kevin O'Connor , seabios , xen-devel , qemu-devel , paul Subject: Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at 0x1000 to detect Xen Message-ID: <20230202091031.xmnao56wziptjak2@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 > Thanks, Kevin. > > I'd like to get the rest of the Xen platform support in to qemu 8.0 if > possible. Which is currently scheduled for March. > > Is there likely to be a SeaBIOS release before then which Gerd would > pull into qemu anyway, or should I submit a submodule update to a > snapshot of today's tree? That would just pull in this commit, and the > one other fix that's in the SeaBIOS tree since 1.16.1? Tagging 1.16.2 in time for the qemu 8.0 should not be a problem given that we have only bugfixes in master. Roughly around soft freeze is probably a good time for that. take care, Gerd From xen-devel-bounces@lists.xenproject.org Thu Feb 02 10:05:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 10:05:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488625.756779 (Exim 4.92) (envelope-from ) id 1pNWSb-0000AX-Dj; Thu, 02 Feb 2023 10:04:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488625.756779; Thu, 02 Feb 2023 10:04:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNWSb-0000AQ-Ax; Thu, 02 Feb 2023 10:04:53 +0000 Received: by outflank-mailman (input) for mailman id 488625; Thu, 02 Feb 2023 10:04:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNWSa-0000AJ-EG for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 10:04:52 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05b97a15-a2e1-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 11:04:47 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id bk15so4385187ejb.9 for ; Thu, 02 Feb 2023 02:04:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05b97a15-a2e1-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MQDiLZo7zTWXPLch69kob9AYmFaKQp5JLZ/Kup7RSmw=; b=CbEyipfp6XEPDGORaqazWtoePPd7FsnWFxWc/sPlrdV9hWgennvo7g5JTVsXPj44to R67li+Id1XZzUmSbfvfMrxYllaNLUk3qtzhjTMIrxsqU+adTcExsHzsFst8/Bm/pIqwE LkGlIi6g+LOphoMwFQbVeu+aU/UuC+PgTMMxo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MQDiLZo7zTWXPLch69kob9AYmFaKQp5JLZ/Kup7RSmw=; b=hDJ7c6E6lCDlvHwSTD7ZdoC7KfWf3bbBgOHG8rn71PcoEixbDJLA3xbwdU2VKdy0TZ 8AV9GiOnGPTv8tqWtJDN/NGpTMC92XH3jklAsVdSsgP7e6l+qr77omcqbtXpBH3brREd CbRhxMvEJcVmRreJaczt2ZxPtw6CsHLNn+2cTrmipx34fD73dFsZst5FhhlKuJAjHIqJ zjakXUPcpYYYCu3TfLWss6/IOfZMVTN8ZOqC17l2g15S1eDBLeZTDSaa+NmjoQpOThKH qMr84owRTj5GYdue11B/dUpeVCGIloD9/0fY5EbuYQtC6GV/XDZXr5QvTd5+Z4J0a4re iW6g== X-Gm-Message-State: AO0yUKV/WGj1j4QT0veqTPi9zpL+LP1xYdZIAvSRPyRV3I8rv6HRvV8y gNT/JbOSg54mccRgdzeiUgYcwIq8By3mtGssoYfyaQ== X-Google-Smtp-Source: AK7set+aDB8eCGU7tcCR6hKyAYPMkRAd95qykUBBqHOhAIPAHAV92fYAfSQTTFIpvLn7i+ZRvLvYo5W7th+7Up9Tp1g= X-Received: by 2002:a17:906:31cf:b0:850:2768:735e with SMTP id f15-20020a17090631cf00b008502768735emr1791639ejf.64.1675332288477; Thu, 02 Feb 2023 02:04:48 -0800 (PST) MIME-Version: 1.0 References: <20230120220004.7456-1-andrew.cooper3@citrix.com> <9abcfc06-1401-cdb7-a1f1-670cd307a593@srcf.net> In-Reply-To: From: George Dunlap Date: Thu, 2 Feb 2023 10:04:37 +0000 Message-ID: Subject: Re: [PATCH] Changelog: Add details about new features for SPR To: Henry Wang Cc: Andrew Cooper , Andrew Cooper , Xen-devel , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Content-Type: multipart/alternative; boundary="000000000000ef90e305f3b4b177" --000000000000ef90e305f3b4b177 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 2, 2023 at 2:05 AM Henry Wang wrote: > Hi George, > > > > > From: George Dunlap > > > Subject: Re: [PATCH] Changelog: Add details about new features for SPR > > > > > > One approach would be to have someone / something (either the release > manager, or an automated script) > > > > An automated script would be best if possible IMHO, as the email > > content would be pretty much fixed/predictable and the email is > > sent periodically. > > > > > periodically (monthly? Bi-weekly?) email each maintainer a list of the > commits under their remit, with an encouragement to consider what entries > could be added to CHANGELOG.md. i.e., something like this: > > > > > > 8<--- > > > Dear $MAINTAINER_NAME, > > > > > > During the last $TIME_PERIOD, the commits below have been checked into > the tree which modify code under your maintainership. Please ensure that > necessary changes to CHANGELOG.md have also been comitted. > > > > > > Thanks, > > > $SENDER > > > > > > $GIT_LOG > > > ---->8 > > > > > > Ideally this would prompt maintainers to get into the habit of always > asking for CHANGELOG entries to be added during review (which would also > get developers into the habit of always including them); at which point the > maintainers could just skim the commits in the email and only add he odd > CHANGELOG that they may have forgotten. > > > > > > Thoughts? > > > > I like this idea very much :) Just a small question: As a developer, it is > > not really clear to me that under what criteria would a patch/series > > deserve for a changelog entry. Personally I would try to include the > > CHANGELOG into my changes in the future if this criteria is cleared. > What I would personally like to see is something that can create a document like this: https://go.dev/doc/go1.20 I'm not sure exactly how to quantify that level of description; nor exactly what other people have in mind. -George > --000000000000ef90e305f3b4b177 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 2, 2023 at 2:05 AM Henry = Wang <Henry.Wang@arm.com> w= rote:

Hi George,

=C2=A0

> From: George Dunlap <george.dunlap@cloud.com>

> Subject: Re: [PATCH] Changelog: Add details abo= ut new features for SPR

>=C2=A0

> One approach would be to have someone / somethi= ng (either the release manager, or an automated script)

=C2=A0

An automated script would be best if possible IMHO, = as the email

content would be pretty much fixed/predictable and t= he email is

sent periodically.

=C2=A0

> periodically (monthly?=C2=A0 Bi-weekly?) email = each maintainer a list of the commits under their remit, with an encouragem= ent to consider what entries could be added to CHANGELOG.md.=C2=A0 i.e., so= mething like this:

>=C2=A0

> 8<---

> Dear $MAINTAINER_NAME,

>=C2=A0

> During the last $TIME_PERIOD, the commits below= have been checked into the tree which modify code under your maintainershi= p.=C2=A0 Please ensure that necessary changes to CHANGELOG.md have also bee= n comitted.

>=C2=A0

> Thanks,

>=C2=A0$SENDER

>=C2=A0

> $GIT_LOG

> ---->8

>=C2=A0

> Ideally this would prompt maintainers to get in= to the habit of always asking for CHANGELOG entries to be added during revi= ew (which would also get developers into the habit of always including them= ); at which point the maintainers could just skim the commits in the email and only add he odd CHANGELOG that they= may have forgotten.

>=C2=A0

> Thoughts?

=C2=A0

I like this idea very much :) Just a small question:= As a developer, it is

not really clear to me that under what criteria woul= d a patch/series

deserve for a changelog entry. Personally I would tr= y to include the

CHANGELOG into my changes in the future if this crit= eria is cleared.


What= I would personally like to see is something that can create a document lik= e this:


I'm not sure exa= ctly how to quantify that level of description; nor exactly what other peop= le have in mind.

=C2=A0-George
<= div lang=3D"EN-US" style=3D"overflow-wrap: break-word;">
--000000000000ef90e305f3b4b177-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 10:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 10:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488631.756790 (Exim 4.92) (envelope-from ) id 1pNX8M-0006LK-M2; Thu, 02 Feb 2023 10:48:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488631.756790; Thu, 02 Feb 2023 10:48:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNX8M-0006LD-IC; Thu, 02 Feb 2023 10:48:02 +0000 Received: by outflank-mailman (input) for mailman id 488631; Thu, 02 Feb 2023 10:48:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNX8K-0006L3-OH; Thu, 02 Feb 2023 10:48:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNX8K-0008Ow-La; Thu, 02 Feb 2023 10:48:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNX8K-00071I-34; Thu, 02 Feb 2023 10:48:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNX8K-0008N0-2b; Thu, 02 Feb 2023 10:48:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9QCOdvUPP9mkbBoq8ylT0wfK9Li5b7WzRdWcCag7YMg=; b=DuAoByb0e8HUZ2gFMAgYXZC9NZ ZeukDrbeX+Gw+hbMV1/TBK+dJkcQArCuw64m5wSC0+ZHZtjej6izc2PIngh4fcXHhphBWRqt5pvXr oYB0SixE4w+oSD4B9d5+xfYVW+iO/uSyXdMhswUxDtWe/xGJuBVOmGKFRTffINsSAxCw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176314: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-linus:build-armhf::broken:regression linux-linus:test-amd64-amd64-xl-pvshim::broken:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel::broken:regression linux-linus:test-amd64-amd64-xl-multivcpu::broken:regression linux-linus:test-amd64-amd64-freebsd11-amd64::broken:regression linux-linus:test-amd64-amd64-freebsd12-amd64::broken:regression linux-linus:test-amd64-amd64-qemuu-nested-intel::broken:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:host-install(5):broken:regression linux-linus:test-amd64-amd64-freebsd12-amd64:host-install(5):broken:regression linux-linus:build-armhf:host-install(4):broken:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:host-install(5):broken:regression linux-linus:test-amd64-amd64-pygrub::broken:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-localmigrate/x10:fail:regression linux-linus:build-armhf:syslog-server:running:regression linux-linus:test-amd64-amd64-pygrub:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-freebsd11-amd64:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-pvshim:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-multivcpu:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:build-armhf:capture-logs:broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c0b67534c95c537f7a506a06b98e5e85d72e2b7d X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 02 Feb 2023 10:48:00 +0000 flight 176314 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176314/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-xl-pvshim broken test-amd64-amd64-xl-pvhv2-intel broken test-amd64-amd64-xl-multivcpu broken test-amd64-amd64-freebsd11-amd64 broken test-amd64-amd64-freebsd12-amd64 broken test-amd64-amd64-qemuu-nested-intel broken test-amd64-amd64-qemuu-nested-intel 5 host-install(5) broken REGR. vs. 173462 test-amd64-amd64-freebsd12-amd64 5 host-install(5) broken REGR. vs. 173462 build-armhf 4 host-install(4) broken REGR. vs. 173462 test-amd64-amd64-xl-pvhv2-intel 5 host-install(5) broken REGR. vs. 173462 test-amd64-amd64-pygrub broken in 176304 test-amd64-amd64-xl-multivcpu 8 xen-boot fail in 176304 REGR. vs. 173462 test-amd64-amd64-freebsd11-amd64 19 guest-localmigrate/x10 fail in 176304 REGR. vs. 173462 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-amd64-pygrub 5 host-install(5) broken in 176304 pass in 176314 test-amd64-amd64-freebsd11-amd64 5 host-install(5) broken pass in 176304 test-amd64-amd64-xl-pvshim 5 host-install(5) broken pass in 176304 test-amd64-amd64-xl-multivcpu 5 host-install(5) broken pass in 176304 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail in 176304 pass in 176314 test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 176304 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 173462 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: linux c0b67534c95c537f7a506a06b98e5e85d72e2b7d baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 117 days Failing since 173470 2022-10-08 06:21:34 Z 117 days 240 attempts Testing same since 176304 2023-02-01 00:13:30 Z 1 days 2 attempts ------------------------------------------------------------ 3468 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 broken test-amd64-amd64-freebsd12-amd64 broken test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel broken test-amd64-amd64-xl-pvhv2-intel broken test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu broken test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim broken test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-job test-amd64-amd64-xl-pvshim broken broken-job test-amd64-amd64-xl-pvhv2-intel broken broken-job test-amd64-amd64-xl-multivcpu broken broken-job test-amd64-amd64-freebsd11-amd64 broken broken-job test-amd64-amd64-freebsd12-amd64 broken broken-job test-amd64-amd64-qemuu-nested-intel broken broken-step build-armhf capture-logs broken-step test-amd64-amd64-freebsd11-amd64 host-install(5) broken-step test-amd64-amd64-qemuu-nested-intel host-install(5) broken-step test-amd64-amd64-xl-pvshim host-install(5) broken-step test-amd64-amd64-freebsd12-amd64 host-install(5) broken-step build-armhf host-install(4) broken-step test-amd64-amd64-xl-pvhv2-intel host-install(5) broken-step test-amd64-amd64-xl-multivcpu host-install(5) broken-job test-amd64-amd64-qemuu-nested-intel broken broken-job build-armhf broken broken-job test-amd64-amd64-pygrub broken broken-job test-amd64-amd64-freebsd12-amd64 broken broken-job test-amd64-amd64-xl-pvhv2-intel broken Not pushing. (No revision log; it would be 533994 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 10:54:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 10:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488642.756801 (Exim 4.92) (envelope-from ) id 1pNXES-0007r4-H7; Thu, 02 Feb 2023 10:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488642.756801; Thu, 02 Feb 2023 10:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXES-0007qx-DN; Thu, 02 Feb 2023 10:54:20 +0000 Received: by outflank-mailman (input) for mailman id 488642; Thu, 02 Feb 2023 10:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXEQ-0007qr-Ew for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 10:54:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20628.outbound.protection.outlook.com [2a01:111:f400:7d00::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef206388-a2e7-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 11:54:15 +0100 (CET) Received: from DUZPR01CA0008.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::17) by DBBPR08MB6234.eurprd08.prod.outlook.com (2603:10a6:10:202::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 10:54:13 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::fd) by DUZPR01CA0008.outlook.office365.com (2603:10a6:10:3c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 10:54:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 10:54:12 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Thu, 02 Feb 2023 10:54:11 +0000 Received: from 4efdd1b395a8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 102F4761-BE47-4965-90CC-2416857026DF.1; Thu, 02 Feb 2023 10:54:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4efdd1b395a8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Feb 2023 10:54:03 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by VI1PR08MB5438.eurprd08.prod.outlook.com (2603:10a6:803:12e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 10:53:49 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Thu, 2 Feb 2023 10:53:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef206388-a2e7-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8zDiyK6YJsVCYrPJUju7DlAZqnio3eZKfnYF6EoOTc=; b=pXzDC9WJ2xrmBKcJOEEbjiNbQv03mWI6VJEXDHzJTPrYP6/9yyRorV2OcMd6hg8VW5pVlPkUK+o1eVRT3XxQRPzWPtMvaQ66fX/Yc/r/v9+yVYOxeSgXMp20iEhGajcEdtRrp/kxOv19Dvahk4Q+kpE1sH2eg+eIwGVMHNqa4f8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLPr/p2BB3AFeGv2cirohC7JVK8xJ6RvfK/hHT21BcutC+z04KoJhGWgNMnCD4LegXeb9TQhgYWCfrkktaTYirE98iE3aUqs2qK2SCy+LjJF1xSZCWJ/+Me6/PamXODo8TPbEe+rq3rftNTb+xpOnjGRxm0jOdAbRylKDAJqcaInfAAemszRtPPDgukNjQ0kj0ZadjqjduLTUnpLYjwIWR2dob1/fT/Cac888381WFFA6JZKzRFhrihiXs7/Jlkyt0c5LyQPQ1b5Ho6Rib7i4vu30yWkzM7ujwYveaHWrnsZxkjCDihv9/FOmxtHRZy/KdlB0kPJeR99/ed/feQ9Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n8zDiyK6YJsVCYrPJUju7DlAZqnio3eZKfnYF6EoOTc=; b=OYlAOqdUWTdG2rOyzXPDEIH3rtWdlOVEbwc6Y3BlEPlBATUlV+J5GmGeqRBbKnwgCv9bHDxjX8P5rEBGbMo7aVCL0yriLDVysoYoPsFpc8KZ9PkUoFVK4c4xfGH7t0mbW+h60YOwP8GaPznoNqJb4GamzTEZRAcGMc/9q7HwKRdvhlm8EcSUn/Sce2ncgDEUUJSfymNvhg4LJ0Vmj6jIHjM9Bn1BZsC+XwKmmosAoomUJIRIllnDq9kDRZXask0lX16Pjde7khUWnr7bQ7km1Qx77SiDLYkTR4gHKluCN2plpKW982nOGR0jTMUU9QX0gRJSBhuQkAx/agxJuNUyLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8zDiyK6YJsVCYrPJUju7DlAZqnio3eZKfnYF6EoOTc=; b=pXzDC9WJ2xrmBKcJOEEbjiNbQv03mWI6VJEXDHzJTPrYP6/9yyRorV2OcMd6hg8VW5pVlPkUK+o1eVRT3XxQRPzWPtMvaQ66fX/Yc/r/v9+yVYOxeSgXMp20iEhGajcEdtRrp/kxOv19Dvahk4Q+kpE1sH2eg+eIwGVMHNqa4f8= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , "ayan.kumar.halder@xilinx.com" CC: Volodymyr Babchuk Subject: RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Topic: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Index: AQHZJxAhTWb1zeTHm029bSgcZo/2Yq6l4H6AgA7nVJCAAFMfgIAAHOxggAGXmACAARsywIAAc7oAgAFRxNCAAN+ggIABBK2A Date: Thu, 2 Feb 2023 10:53:49 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-12-Penny.Zheng@arm.com> <7931e70f-3754-363c-28d8-5fde3198d70f@xen.org> <3c915633-ddb8-d1e4-f42e-064aaff168b2@xen.org> <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> <1f360356-b143-e732-5a4a-197ed56b2cd1@xen.org> In-Reply-To: <1f360356-b143-e732-5a4a-197ed56b2cd1@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 61C03A09695A79439F36ED5FFCBF44FC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|VI1PR08MB5438:EE_|DBAEUR03FT055:EE_|DBBPR08MB6234:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ad2b6c-02e9-4cc0-c4a6-08db050bd18c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YKe/3zNOWLqizCX4tZQWJSkW85Rcsnl2wNijfE2aAS3zw1L7QNBPsp1RMdXdnRTTjRBpZscnMQY6hIghuYEALCAx7bd3VCCjpzdAA0wlZnhV6uH/oI7d7eb57lzR5ygVXplzMH+p0tzuZ7Z6MWGilbcwecSvYtNjShEAQWGYzSX3e9qR0Pee5lmyVz35AY3qo9JCN8Q4wRWDArf5ysdx+ABC+wtjaMIk69/JMW027Gn9+xWBuiaLx/4ncnwpAtSSUVKDMAy54JqsflSvaIt9cSyPRlnIGBuIotqRHZXbiBi0FegMrdgUA91U1bNCqwUbb3zOh9KKAu1OPQ9kYBsmTZv7U4vSeE9ax/3GeV9/HCLtJxUMUCl6uc95XL57CxBn84Eo8i/TkTN8Hq38jDSrysn8dU+Vy6wW33ocJl5LKDBmE0EaehsrmpakjKxbarJxis8IPC1GiH/Vx56PE90k/KKpxlXpX95H5GbALz2LsxCDC3cRSgB3YZTD2tk9c8HNMYwsY86SwfYnpkAID2EMrvyCmyBVAhbMgQApLlQ7k9mEG+bs81wN9aJ7sW86SGIVPJ5z75JUCsX1+v2Kt++oAsIVnunxnwTbga367R8+C6pxucpRiQ7wurrUI5GakJImga0GRyMT+Fk2pbGzdJ6b3axOydxZLMvS7pFlq8Lrw5m+GJypbfhWg94ZbQCXcTMGxK37bmS+oNvTTenpzJk0pg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199018)(478600001)(66946007)(66556008)(76116006)(38100700002)(4326008)(66476007)(66446008)(64756008)(83380400001)(8676002)(122000001)(110136005)(316002)(6506007)(53546011)(26005)(186003)(33656002)(9686003)(5660300002)(86362001)(41300700001)(38070700005)(7696005)(55016003)(71200400001)(8936002)(52536014)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5438 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 641b4adc-e7c0-412f-1b8c-08db050bc3d7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0UzaUnc8hkodRH8y8+1snGB/+9j4ZoLjtwuHQePRRGNslyB8GAjLnpu356gijmqZwfHXDneKLziTrBMPSquPbW4sgDkM/wgJMGS1rYkrE3fd7N97GPodnZwj1F6GT+xFHdI7yyChMjEpTbDQesv8qObOqceeoDlGBAc5v5n7Ga2gELSiMC/i317ncTubu16MbPk3aZF8RHHoK4TgJkylTTotEd7S4cKbQqaCH7s2btp9U2BhNYn8p0AATyv2hLamuORnahR7SOKcocyLiSNMb/1aEzllRGU678gDs3NHDmVh8dotBaTFSzSbgG0US6ItddnOV3MaPAORK4j4oiddCh5Y8Di6megKZmD/hJlj8JH6vOagD7JwI+6f4uLI8YBfcPgMv1HtbTV+sllNrtYzMa0JLwPeMWtaChWiNpZ+954j+95FbJEUfAfDszApmz1jzuUyJ39mc03tDIwE7hsI20B1oj1lPFs1zIgQobnlWEQIBVdVvaScsjthZQcP44jT73KhlQmXccrIeTV4jzMZmNsDyP9/dOIGP0CQtYFCR+4fIqbF2RQ4/DSvb7Fi15Ta4OGHTqVIXDfbGic0BYweHdkVqtXYU/xzzs0ViTHmeZdm+aB0QyVHKtNJCQcVpxj+yx4G07CmVw3BYwg1SoM9GjJlHUjhErvhEdiD2S5OiFrToh4sIKziQqLOt1l2fGhMgQvnDcruGkVI99OsCRACtw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199018)(40470700004)(46966006)(36840700001)(81166007)(478600001)(107886003)(52536014)(8936002)(5660300002)(40460700003)(70206006)(70586007)(83380400001)(33656002)(4326008)(8676002)(26005)(9686003)(36860700001)(186003)(82310400005)(316002)(86362001)(47076005)(356005)(110136005)(55016003)(40480700001)(6506007)(7696005)(82740400003)(336012)(2906002)(53546011)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 10:54:12.1187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e2ad2b6c-02e9-4cc0-c4a6-08db050bd18c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6234 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFRodXJzZGF5LCBGZWJydWFyeSAyLCAy MDIzIDI6NTcgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IGF5YW4ua3VtYXIuaGFs ZGVyQHhpbGlueC5jb20NCj4gQ2M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1 a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxMS80MF0geGVuL21wdTogYnVp bGQgdXAgc3RhcnQtb2YtZGF5IFhlbiBNUFUNCj4gbWVtb3J5IHJlZ2lvbiBtYXANCj4gDQo+IEhp IFBlbm55LA0KPiANCj4gT24gMDEvMDIvMjAyMyAwNTozOSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ ID4+PiBJZiB3ZSBhcmUgYWRkaW5nIE1QVSByZWdpb25zIGluIHNlcXVlbmNlIGFzIHlvdSBzdWdn ZXN0ZWQsIHdoaWxlDQo+ID4+PiB1c2luZyBiaXRtYXAgYXQgdGhlIHNhbWUgdGltZSB0byByZWNv cmQgdXNlZCBlbnRyeS4NCj4gPj4+IFRCSCwgdGhpcyBpcyBob3cgSSBkZXNpZ25lZCBhdCB0aGUg dmVyeSBiZWdpbm5pbmcgaW50ZXJuYWxseS4gV2UNCj4gPj4+IGZvdW5kIHRoYXQgaWYgd2UgZG9u J3QgZG8gcmVvcmcgbGF0ZS1ib290IHRvIGtlZXAgZml4ZWQgaW4gZnJvbnQgYW5kDQo+ID4+PiBz d2l0Y2hpbmcgb25lcyBhZnRlciwgZWFjaCB0aW1lIHdoZW4gd2UgZG8gdmNwdSBjb250ZXh0IHN3 aXRjaCwgbm90DQo+ID4+PiBvbmx5IHdlIG5lZWQgdG8gaHVudCBkb3duIHN3aXRjaGluZyBvbmVz IHRvIGRpc2FibGUsIHdoaWxlIHdlIGFkZA0KPiA+Pj4gbmV3IHN3aXRjaC1pbiByZWdpb25zLCB1 c2luZyBiaXRtYXAgdG8gZmluZCBmcmVlIGVudHJ5IGlzIHNheWluZw0KPiA+Pj4gdGhhdCB0aGUN Cj4gPj4gcHJvY2VzcyBpcyB1bnByZWRpY3RhYmxlLiBVbmNlcnRhaW50eSBpcyB3aGF0IHdlIHdh bnQgdG8gYXZvaWQgaW4NCj4gPj4gQXJtdjgtUiBhcmNoaXRlY3R1cmUuDQo+ID4+DQo+ID4+IEkg ZG9uJ3QgdW5kZXJzdGFuZCB3aHkgaXQgd291bGQgYmUgdW5wcmVkaWN0YWJsZS4gRm9yIGEgZ2l2 ZW4NCj4gPj4gY29tYmluYXRpb24gb2YgcGxhdGZvcm0vZGV2aWNlLXRyZWUsIHRoZSBiaXRtYXAg d2lsbCBhbHdheXMgbG9vayB0aGUNCj4gPj4gc2FtZS4gU28gdGhlIG51bWJlciBvZiBjeWNsZXMv aW5zdHJ1Y3Rpb25zIHdpbGwgYWx3YXlzIGJlIHRoZSBzYW1lLg0KPiA+Pg0KPiA+DQo+ID4gSW4g Ym9vdC10aW1lLCBpdCB3aWxsIGJlIGFsd2F5cyB0aGUgc2FtZS4gQnV0IGlmIHdlIHN0aWxsIHVz ZSBiaXRtYXANCj4gPiB0byBmaW5kIGZyZWUgZW50cnkoZm9yIHN3aXRjaGluZyBNUFUgcmVnaW9u cykgb24gcnVudGltZSwgaG1tbSwgSQ0KPiA+IHRob3VnaHQgdGhpcyBwYXJ0IHdpbGwgYmUgdW5w cmVkaWN0YWJsZS4NCj4gDQo+IEkga25vdyB0aGlzIHBvaW50IGlzIG5vdyBtb290IGFzIHdlIGFn cmVlZCBvbiBub3QgdXNpbmcgYSBiaXRtYXAgYnV0IEkNCj4gd2FudGVkIHRvIGFuc3dlciBvbiB0 aGUgdW5wcmVkaWN0YWJpbGl0eSBwYXJ0Lg0KPiANCj4gSXQgZGVwZW5kcyBvbiB3aGV0aGVyIHlv dSBkZWNpZGUgdG8gYWxsb2NhdGUgbW9yZSBlbnRyeSBhdCBydW50aW1lLiBNeQ0KPiBhc3N1bXB0 aW9uIGlzIHlvdSB3b24ndCBhbmQgdGhlcmVmb3JlIHRoZSB0aGUgdGltZSB0byB3YWxrIHRoZSBi aXRtYXAgd2lsbA0KPiBhbHdheXMgYmUgY29uc2lzdGVudC4NCj4gDQoNCkluIE1QVSwgd2UgZG9u J3QgaGF2ZSBzb21ldGhpbmcgbGlrZSB2dHRicl9lbDIgaW4gTU1VLCB0byBzdG9yZSBzdGFnZSAy DQpFTDEvRUwwIHRyYW5zbGF0aW9uIHRhYmxlLiBYZW4gc3RhZ2UgMSBFTDIgbWFwcGluZyBhbmQg c3RhZ2UgMiBFTDEvRUwwDQptYXBwaW5nIGFyZSBib3RoIHNoYXJpbmcgb25lIHRhYmxlLg0KU28g d2hlbiBjb250ZXh0IHN3aXRjaGluZyBpbnRvIGRpZmZlcmVudCBndWVzdCwgdGhlIGN1cnJlbnQg ZGVzaWduIGlzIHRvIGRpc2FibGUNCkRPTTEncyBndWVzdCBSQU0gbWFwcGluZyBmaXJzdGx5LCB0 aGVuIGVuYWJsZSBET00yJ3MgZ3Vlc3QgUkFNIG1hcHBpbmcsDQp0byBlbnN1cmUgaXNvbGF0aW9u IGFuZCBzYWZldHkuDQoNCj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Thu Feb 02 10:58:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 10:58:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488647.756812 (Exim 4.92) (envelope-from ) id 1pNXIB-0000OH-0u; Thu, 02 Feb 2023 10:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488647.756812; Thu, 02 Feb 2023 10:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXIA-0000OA-U1; Thu, 02 Feb 2023 10:58:10 +0000 Received: by outflank-mailman (input) for mailman id 488647; Thu, 02 Feb 2023 10:58:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXIA-0000O4-0r for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 10:58:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXI9-00009T-Ol; Thu, 02 Feb 2023 10:58:09 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.13.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNXI9-0007ms-Gz; Thu, 02 Feb 2023 10:58:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=nFBwOcL5ETnooULiT7DPoLFzZtiIJrQ9WH30Pi4Zs4k=; b=TOEX+c219RHCHtFRmfhu377KYd lUfD+K1q+hx51O5eSmHNJB9ukqp6sDEgO7oYwg7aTQdT4EzqjY9ZD/UL31DNtjdS/gFk3hp9g4TtW kBJ72Af19ACwsQ8a8SjZLCdBU0L/X0vPZWfuDSuecFo5hzFVqS1zt/3nQmrGwBKFb62c=; Message-ID: <83ba0e60-1a3f-f91a-05b3-79ec32ba4caa@xen.org> Date: Thu, 2 Feb 2023 10:58:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , "ayan.kumar.halder@xilinx.com" Cc: Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-12-Penny.Zheng@arm.com> <7931e70f-3754-363c-28d8-5fde3198d70f@xen.org> <3c915633-ddb8-d1e4-f42e-064aaff168b2@xen.org> <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> <1f360356-b143-e732-5a4a-197ed56b2cd1@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2023 10:53, Penny Zheng wrote: > Hi Julien, Hi, >> -----Original Message----- >> From: Julien Grall >> Sent: Thursday, February 2, 2023 2:57 AM >> To: Penny Zheng ; xen-devel@lists.xenproject.org; >> Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> ayan.kumar.halder@xilinx.com >> Cc: Volodymyr Babchuk >> Subject: Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU >> memory region map >> >> Hi Penny, >> >> On 01/02/2023 05:39, Penny Zheng wrote: >>>>> If we are adding MPU regions in sequence as you suggested, while >>>>> using bitmap at the same time to record used entry. >>>>> TBH, this is how I designed at the very beginning internally. We >>>>> found that if we don't do reorg late-boot to keep fixed in front and >>>>> switching ones after, each time when we do vcpu context switch, not >>>>> only we need to hunt down switching ones to disable, while we add >>>>> new switch-in regions, using bitmap to find free entry is saying >>>>> that the >>>> process is unpredictable. Uncertainty is what we want to avoid in >>>> Armv8-R architecture. >>>> >>>> I don't understand why it would be unpredictable. For a given >>>> combination of platform/device-tree, the bitmap will always look the >>>> same. So the number of cycles/instructions will always be the same. >>>> >>> >>> In boot-time, it will be always the same. But if we still use bitmap >>> to find free entry(for switching MPU regions) on runtime, hmmm, I >>> thought this part will be unpredictable. >> >> I know this point is now moot as we agreed on not using a bitmap but I >> wanted to answer on the unpredictability part. >> >> It depends on whether you decide to allocate more entry at runtime. My >> assumption is you won't and therefore the the time to walk the bitmap will >> always be consistent. >> > > In MPU, we don't have something like vttbr_el2 in MMU, to store stage 2 > EL1/EL0 translation table. Xen stage 1 EL2 mapping and stage 2 EL1/EL0 > mapping are both sharing one table. > So when context switching into different guest, the current design is to disable > DOM1's guest RAM mapping firstly, then enable DOM2's guest RAM mapping, > to ensure isolation and safety. I understood that but I don't understand how this is related to my point here. The entries you are replacing are always going to be the same after boot. So if you have a bitmap indicate the fixed entries and you don't add more fixed one at runtime, then it will always take the same time to walk it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:02:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488652.756823 (Exim 4.92) (envelope-from ) id 1pNXLg-0001q1-FP; Thu, 02 Feb 2023 11:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488652.756823; Thu, 02 Feb 2023 11:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXLg-0001pu-Ci; Thu, 02 Feb 2023 11:01:48 +0000 Received: by outflank-mailman (input) for mailman id 488652; Thu, 02 Feb 2023 11:01:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXLf-0001po-SN for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:01:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXLf-0000G1-IS; Thu, 02 Feb 2023 11:01:47 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.13.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNXLf-00082D-AP; Thu, 02 Feb 2023 11:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Wfa34thKVwZD18phf0vy2KO2zCRZpkb0b2cZCkSZawk=; b=osgO4KywStz4KDi1svzX3yjSYV r+NsGHaPfSpo/QIapDLMMsQ6GMni0SQ8jgEBDjYiD92VjczpfdWDjiaGqkV1pWoRYgfvUE4k9SJm2 gYRD8+HAx+8weyTOOauqpIBd9fxZEhltqbBr9FZJFWWpY8jvM5WbpaQqd1irtu//naIc=; Message-ID: <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> Date: Thu, 2 Feb 2023 11:01:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230202084905.6950-1-michal.orzel@amd.com> <20230202084905.6950-3-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20230202084905.6950-3-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 02/02/2023 08:49, Michal Orzel wrote: > @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) > #define IH_ARCH_ARM 2 /* ARM */ > #define IH_ARCH_ARM64 22 /* ARM64 */ > > +/* uImage Compression Types */ > +#define IH_COMP_GZIP 1 > + > /* > * Check if the image is a uImage and setup kernel_info > */ > static int __init kernel_uimage_probe(struct kernel_info *info, > - paddr_t addr, paddr_t size) > + struct bootmodule *mod) > { > struct { > __be32 magic; /* Image Header Magic Number */ > @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, > } uimage; > > uint32_t len; > + paddr_t addr = mod->start; > + paddr_t size = mod->size; > > if ( size < sizeof(uimage) ) > return -EINVAL; Shouldn't we return -ENOENT here? The rest look good to me. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488660.756844 (Exim 4.92) (envelope-from ) id 1pNXSD-00038E-GW; Thu, 02 Feb 2023 11:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488660.756844; Thu, 02 Feb 2023 11:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSD-000386-Dp; Thu, 02 Feb 2023 11:08:33 +0000 Received: by outflank-mailman (input) for mailman id 488660; Thu, 02 Feb 2023 11:08:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSB-0002sY-FL for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ebbc30de-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B66DF1042; Thu, 2 Feb 2023 03:09:10 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 75BF03F64C; Thu, 2 Feb 2023 03:08:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ebbc30de-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 01/10] xen/arm: enable SVE extension for Xen Date: Thu, 2 Feb 2023 11:08:07 +0000 Message-Id: <20230202110816.1252419-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot only when SVE resources are accessed. While there, correct coding style for the comment on coprocessor trapping. Now cptr_el2 is part of the domain context and it will be restored on context switch, this is a preparation for saving the SVE context which will be part of VFP operations, so restore it before the call to save VFP registers. To save an additional isb barrier, restore cptr_el2 before an existing isb barrier and move the call for saving VFP context after that barrier. Change the KConfig entry to make ARM64_SVE symbol selectable, by default it will be not selected. Create sve module and sve_asm.S that contains assembly routines for the SVE feature, this code is inspired from linux and it uses instruction encoding to be compatible with compilers that does not support SVE. Signed-off-by: Luca Fancellu --- Changes from RFC: - Moved restoring of cptr before an existing barrier (Julien) - Marked the feature as unsupported for now (Julien) - Trap and un-trap only when using SVE resources in compute_max_zcr() (Julien) --- xen/arch/arm/Kconfig | 10 +++-- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 ++-- xen/arch/arm/arm64/sve.c | 49 ++++++++++++++++++++++++ xen/arch/arm/arm64/sve_asm.S | 48 +++++++++++++++++++++++ xen/arch/arm/cpufeature.c | 6 ++- xen/arch/arm/domain.c | 9 +++-- xen/arch/arm/include/asm/arm64/sve.h | 43 +++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 1 + xen/arch/arm/include/asm/cpufeature.h | 14 +++++++ xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/include/asm/processor.h | 2 + xen/arch/arm/setup.c | 5 ++- xen/arch/arm/traps.c | 28 ++++++++------ 14 files changed, 200 insertions(+), 24 deletions(-) create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/arm64/sve_asm.S create mode 100644 xen/arch/arm/include/asm/arm64/sve.h diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c7f..41f45d8d1203 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -112,11 +112,15 @@ config ARM64_PTR_AUTH This feature is not supported in Xen. config ARM64_SVE - def_bool n + bool "Enable Scalar Vector Extension support (UNSUPPORTED)" if UNSUPPORTED depends on ARM_64 help - Scalar Vector Extension support. - This feature is not supported in Xen. + Scalar Vector Extension (SVE/SVE2) support for guests. + + Please be aware that currently, enabling this feature will add latency on + VM context switch between SVE enabled guests, between not-enabled SVE + guests and SVE enabled guests and viceversa, compared to the time + required to switch between not-enabled SVE guests. config ARM64_MTE def_bool n diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 6d507da0d44d..1d59c3b0ec89 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -12,6 +12,7 @@ obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o obj-y += smc.o obj-y += smpboot.o +obj-$(CONFIG_ARM64_SVE) += sve.o sve_asm.o obj-y += traps.o obj-y += vfp.o obj-y += vsysreg.o diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index d9039d37b2d1..b4656ff4d80f 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -455,15 +455,11 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = { ARM64_FTR_END, }; -#if 0 -/* TODO: use this to sanitize SVE once we support it */ - static const struct arm64_ftr_bits ftr_zcr[] = { ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ ARM64_FTR_END, }; -#endif /* * Common ftr bits for a 32bit register with all hidden, strict @@ -603,6 +599,9 @@ void update_system_features(const struct cpuinfo_arm *new) SANITIZE_ID_REG(zfr64, 0, aa64zfr0); + if ( cpu_has_sve ) + SANITIZE_REG(zcr64, 0, zcr); + /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c new file mode 100644 index 000000000000..1c8024b44cd8 --- /dev/null +++ b/xen/arch/arm/arm64/sve.c @@ -0,0 +1,49 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#include +#include +#include +#include +#include + +extern unsigned int sve_get_hw_vl(void); + +register_t compute_max_zcr(void) +{ + register_t cptr_bits = get_default_cptr_flags(); + register_t zcr = vl_to_zcr(SVE_VL_MAX_BITS); + unsigned int hw_vl; + + /* Remove trap for SVE resources */ + WRITE_SYSREG(cptr_bits & ~HCPTR_CP(8), CPTR_EL2); + isb(); + + /* + * Set the maximum SVE vector length, doing that we will know the VL + * supported by the platform, calling sve_get_hw_vl() + */ + WRITE_SYSREG(zcr, ZCR_EL2); + + /* + * Read the maximum VL, which could be lower than what we imposed before, + * hw_vl contains VL in bytes, multiply it by 8 to use vl_to_zcr() later + */ + hw_vl = sve_get_hw_vl() * 8U; + + /* Restore CPTR_EL2 */ + WRITE_SYSREG(cptr_bits, CPTR_EL2); + isb(); + + return vl_to_zcr(hw_vl); +} + +/* Takes a vector length in bits and returns the ZCR_ELx encoding */ +register_t vl_to_zcr(uint16_t vl) +{ + return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; +} diff --git a/xen/arch/arm/arm64/sve_asm.S b/xen/arch/arm/arm64/sve_asm.S new file mode 100644 index 000000000000..4d1549344733 --- /dev/null +++ b/xen/arch/arm/arm64/sve_asm.S @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Arm SVE assembly routines + * + * Copyright (C) 2022 ARM Ltd. + * + * Some macros and instruction encoding in this file are taken from linux 6.1.1, + * file arch/arm64/include/asm/fpsimdmacros.h, some of them are a modified + * version. + */ + +/* Sanity-check macros to help avoid encoding garbage instructions */ + +.macro _check_general_reg nr + .if (\nr) < 0 || (\nr) > 30 + .error "Bad register number \nr." + .endif +.endm + +.macro _check_num n, min, max + .if (\n) < (\min) || (\n) > (\max) + .error "Number \n out of range [\min,\max]" + .endif +.endm + +/* SVE instruction encodings for non-SVE-capable assemblers */ +/* (pre binutils 2.28, all kernel capable clang versions support SVE) */ + +/* RDVL X\nx, #\imm */ +.macro _sve_rdvl nx, imm + _check_general_reg \nx + _check_num (\imm), -0x20, 0x1f + .inst 0x04bf5000 \ + | (\nx) \ + | (((\imm) & 0x3f) << 5) +.endm + +/* Gets the current vector register size in bytes */ +GLOBAL(sve_get_hw_vl) + _sve_rdvl 0, 1 + ret + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index c4ec38bb2554..83b84368f6d5 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -9,6 +9,7 @@ #include #include #include +#include #include DECLARE_BITMAP(cpu_hwcaps, ARM_NCAPS); @@ -143,6 +144,9 @@ void identify_cpu(struct cpuinfo_arm *c) c->zfr64.bits[0] = READ_SYSREG(ID_AA64ZFR0_EL1); + if ( cpu_has_sve ) + c->zcr64.bits[0] = compute_max_zcr(); + c->dczid.bits[0] = READ_SYSREG(DCZID_EL0); c->ctr.bits[0] = READ_SYSREG(CTR_EL0); @@ -199,7 +203,7 @@ static int __init create_guest_cpuinfo(void) guest_cpuinfo.pfr64.mpam = 0; guest_cpuinfo.pfr64.mpam_frac = 0; - /* Hide SVE as Xen does not support it */ + /* Hide SVE by default to the guests */ guest_cpuinfo.pfr64.sve = 0; guest_cpuinfo.zfr64.bits[0] = 0; diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 99577adb6c69..adb6ace2e24d 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -181,9 +181,6 @@ static void ctxt_switch_to(struct vcpu *n) /* VGIC */ gic_restore_state(n); - /* VFP */ - vfp_restore_state(n); - /* XXX MPU */ /* Fault Status */ @@ -234,6 +231,7 @@ static void ctxt_switch_to(struct vcpu *n) p2m_restore_state(n); /* Control Registers */ + WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); WRITE_SYSREG(n->arch.cpacr, CPACR_EL1); /* @@ -258,6 +256,9 @@ static void ctxt_switch_to(struct vcpu *n) #endif isb(); + /* VFP */ + vfp_restore_state(n); + /* CP 15 */ WRITE_SYSREG(n->arch.csselr, CSSELR_EL1); @@ -548,6 +549,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); + v->arch.cptr_el2 = get_default_cptr_flags(); + v->arch.hcr_el2 = get_default_hcr_flags(); v->arch.mdcr_el2 = HDCR_TDRA | HDCR_TDOSA | HDCR_TDA; diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h new file mode 100644 index 000000000000..bd56e2f24230 --- /dev/null +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#ifndef _ARM_ARM64_SVE_H +#define _ARM_ARM64_SVE_H + +#define SVE_VL_MAX_BITS (2048U) + +/* Vector length must be multiple of 128 */ +#define SVE_VL_MULTIPLE_VAL (128U) + +#ifdef CONFIG_ARM64_SVE + +register_t compute_max_zcr(void); +register_t vl_to_zcr(uint16_t vl); + +#else /* !CONFIG_ARM64_SVE */ + +static inline register_t compute_max_zcr(void) +{ + return 0; +} + +static inline register_t vl_to_zcr(uint16_t vl) +{ + return 0; +} + +#endif + +#endif /* _ARM_ARM64_SVE_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 463899951414..4cabb9eb4d5e 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -24,6 +24,7 @@ #define ICH_EISR_EL2 S3_4_C12_C11_3 #define ICH_ELSR_EL2 S3_4_C12_C11_5 #define ICH_VMCR_EL2 S3_4_C12_C11_7 +#define ZCR_EL2 S3_4_C1_C2_0 #define __LR0_EL2(x) S3_4_C12_C12_ ## x #define __LR8_EL2(x) S3_4_C12_C13_ ## x diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index c62cf6293fd6..6d703e051906 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -32,6 +32,12 @@ #define cpu_has_thumbee (boot_cpu_feature32(thumbee) == 1) #define cpu_has_aarch32 (cpu_has_arm || cpu_has_thumb) +#ifdef CONFIG_ARM64_SVE +#define cpu_has_sve (boot_cpu_feature64(sve) == 1) +#else +#define cpu_has_sve (0) +#endif + #ifdef CONFIG_ARM_32 #define cpu_has_gicv3 (boot_cpu_feature32(gic) >= 1) #define cpu_has_gentimer (boot_cpu_feature32(gentimer) == 1) @@ -323,6 +329,14 @@ struct cpuinfo_arm { }; } isa64; + union { + register_t bits[1]; + struct { + unsigned long len:4; + unsigned long __res0:60; + }; + } zcr64; + struct { register_t bits[1]; } zfr64; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 0e310601e846..42eb5df320a7 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -190,6 +190,7 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 1dd81d7d528f..0e38926b94db 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -583,6 +583,8 @@ void do_trap_guest_serror(struct cpu_user_regs *regs); register_t get_default_hcr_flags(void); +register_t get_default_cptr_flags(void); + /* * Synchronize SError unless the feature is selected. * This is relying on the SErrors are currently unmasked. diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90e3..5459cc4f5e62 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -135,10 +135,11 @@ static void __init processor_id(void) cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No", cpu_has_el1_32 ? "64+32" : cpu_has_el1_64 ? "64" : "No", cpu_has_el0_32 ? "64+32" : cpu_has_el0_64 ? "64" : "No"); - printk(" Extensions:%s%s%s\n", + printk(" Extensions:%s%s%s%s\n", cpu_has_fp ? " FloatingPoint" : "", cpu_has_simd ? " AdvancedSIMD" : "", - cpu_has_gicv3 ? " GICv3-SysReg" : ""); + cpu_has_gicv3 ? " GICv3-SysReg" : "", + cpu_has_sve ? " SVE" : ""); /* Warn user if we find unknown floating-point features */ if ( cpu_has_fp && (boot_cpu_feature64(fp) >= 2) ) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd68..a78a99ddadd0 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -93,6 +93,21 @@ register_t get_default_hcr_flags(void) HCR_TID3|HCR_TSC|HCR_TAC|HCR_SWIO|HCR_TIDCP|HCR_FB|HCR_TSW); } +register_t get_default_cptr_flags(void) +{ + /* + * Trap all coprocessor registers (0-13) except cp10 and + * cp11 for VFP. + * + * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. + * + * On ARM64 the TCPx bits which we set here (0..9,12,13) are all + * RES1, i.e. they would trap whether we did this write or not. + */ + return ((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | + HCPTR_TTA | HCPTR_TAM); +} + static enum { SERRORS_DIVERSE, SERRORS_PANIC, @@ -122,6 +137,7 @@ __initcall(update_serrors_cpu_caps); void init_traps(void) { + register_t cptr_bits = get_default_cptr_flags(); /* * Setup Hyp vector base. Note they might get updated with the * branch predictor hardening. @@ -135,17 +151,7 @@ void init_traps(void) /* Trap CP15 c15 used for implementation defined registers */ WRITE_SYSREG(HSTR_T(15), HSTR_EL2); - /* Trap all coprocessor registers (0-13) except cp10 and - * cp11 for VFP. - * - * /!\ All coprocessors except cp10 and cp11 cannot be used in Xen. - * - * On ARM64 the TCPx bits which we set here (0..9,12,13) are all - * RES1, i.e. they would trap whether we did this write or not. - */ - WRITE_SYSREG((HCPTR_CP_MASK & ~(HCPTR_CP(10) | HCPTR_CP(11))) | - HCPTR_TTA | HCPTR_TAM, - CPTR_EL2); + WRITE_SYSREG(cptr_bits, CPTR_EL2); /* * Configure HCR_EL2 with the bare minimum to run Xen until a guest -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488661.756851 (Exim 4.92) (envelope-from ) id 1pNXSD-0003Bb-Rs; Thu, 02 Feb 2023 11:08:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488661.756851; Thu, 02 Feb 2023 11:08:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSD-0003AH-Kt; Thu, 02 Feb 2023 11:08:33 +0000 Received: by outflank-mailman (input) for mailman id 488661; Thu, 02 Feb 2023 11:08:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSC-0002sY-4x for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ecc1a21b-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 740A41424; Thu, 2 Feb 2023 03:09:12 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CD8333F64C; Thu, 2 Feb 2023 03:08:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc1a21b-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH 02/10] xen/arm: add sve_vl_bits field to domain Date: Thu, 2 Feb 2023 11:08:08 +0000 Message-Id: <20230202110816.1252419-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add sve_vl_bits field to arch_domain and xen_arch_domainconfig structure, to allow the domain to have an information about the SVE feature and the number of SVE register bits that are allowed for this domain. The field is used also to allow or forbid a domain to use SVE, because a value equal to zero means the guest is not allowed to use the feature. Check that the requested vector length is lower or equal to the platform supported vector length, otherwise fail on domain creation. Signed-off-by: Luca Fancellu --- Changes from RFC: - restore zcr_el2 in sve_restore_state, that will be introduced later in this serie, so remove zcr_el2 related code from this patch and move everything to the later patch (Julien) - add explicit padding into struct xen_arch_domainconfig (Julien) - Don't lower down the vector length, just fail to create the domain. (Julien) --- xen/arch/arm/arm64/sve.c | 9 ++++++++ xen/arch/arm/domain.c | 32 ++++++++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/sve.h | 12 +++++++++++ xen/arch/arm/include/asm/domain.h | 5 +++++ xen/include/public/arch-arm.h | 3 +++ xen/include/public/domctl.h | 2 +- 6 files changed, 62 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index 1c8024b44cd8..eee39caa9efa 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include @@ -47,3 +48,11 @@ register_t vl_to_zcr(uint16_t vl) { return ((vl / SVE_VL_MULTIPLE_VAL) - 1U) & ZCR_ELx_LEN_MASK; } + +/* Get the system sanitized value for VL in bits */ +uint16_t get_sys_vl_len(void) +{ + /* ZCR_ELx len field is ((len+1) * 128) = vector bits length */ + return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * + SVE_VL_MULTIPLE_VAL; +} diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index adb6ace2e24d..8d64e3c08edf 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -13,6 +13,7 @@ #include #include +#include #include #include #include @@ -550,6 +551,8 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); v->arch.cptr_el2 = get_default_cptr_flags(); + if ( is_sve_domain(v->domain) ) + v->arch.cptr_el2 &= ~HCPTR_CP(8); v->arch.hcr_el2 = get_default_hcr_flags(); @@ -594,6 +597,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) unsigned int max_vcpus; unsigned int flags_required = (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap); unsigned int flags_optional = (XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_vpmu); + unsigned int sve_vl_bits = config->arch.sve_vl_bits; if ( (config->flags & ~flags_optional) != flags_required ) { @@ -602,6 +606,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) return -EINVAL; } + /* Check feature flags */ + if ( sve_vl_bits > 0 ) { + unsigned int zcr_max_bits = get_sys_vl_len(); + + if ( !cpu_has_sve ) + { + dprintk(XENLOG_INFO, "SVE is unsupported on this machine.\n"); + return -EINVAL; + } + else if ( !is_vl_valid(sve_vl_bits) ) + { + dprintk(XENLOG_INFO, "Unsupported SVE vector length (%u)\n", + sve_vl_bits); + return -EINVAL; + } + else if ( sve_vl_bits > zcr_max_bits ) + { + dprintk(XENLOG_INFO, + "The requested SVE vector length (%u) must be lower or \n" + "equal to the platform supported vector length (%u)\n", + sve_vl_bits, zcr_max_bits); + return -EINVAL; + } + } + /* The P2M table must always be shared between the CPU and the IOMMU */ if ( config->iommu_opts & XEN_DOMCTL_IOMMU_no_sharept ) { @@ -744,6 +773,9 @@ int arch_domain_create(struct domain *d, if ( (rc = domain_vpci_init(d)) != 0 ) goto fail; + /* Copy sve_vl_bits to the domain configuration */ + d->arch.sve_vl_bits = config->arch.sve_vl_bits; + return 0; fail: diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index bd56e2f24230..f4a660e402ca 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -13,10 +13,17 @@ /* Vector length must be multiple of 128 */ #define SVE_VL_MULTIPLE_VAL (128U) +static inline bool is_vl_valid(uint16_t vl) +{ + /* SVE vector length is multiple of 128 and maximum 2048 */ + return ((vl % SVE_VL_MULTIPLE_VAL) == 0) && (vl <= SVE_VL_MAX_BITS); +} + #ifdef CONFIG_ARM64_SVE register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); +uint16_t get_sys_vl_len(void); #else /* !CONFIG_ARM64_SVE */ @@ -30,6 +37,11 @@ static inline register_t vl_to_zcr(uint16_t vl) return 0; } +static inline uint16_t get_sys_vl_len(void) +{ + return 0; +} + #endif #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 42eb5df320a7..1bd669e0a5c1 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -31,6 +31,8 @@ enum domain_type { #define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) +#define is_sve_domain(d) ((d)->arch.sve_vl_bits > 0) + /* * Is the domain using the host memory layout? * @@ -114,6 +116,9 @@ struct arch_domain void *tee; #endif + /* max SVE vector length in bits */ + uint16_t sve_vl_bits; + } __cacheline_aligned; struct arch_vcpu diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced5097a..3094aeb57990 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -304,6 +304,9 @@ struct xen_arch_domainconfig { uint16_t tee_type; /* IN */ uint32_t nr_spis; + /* IN */ + uint16_t sve_vl_bits; + uint16_t _pad1; /* * OUT * Based on the property clock-frequency in the DT timer node. diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 51be28c3de7c..616d7a1c070d 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -21,7 +21,7 @@ #include "hvm/save.h" #include "memory.h" -#define XEN_DOMCTL_INTERFACE_VERSION 0x00000015 +#define XEN_DOMCTL_INTERFACE_VERSION 0x00000016 /* * NB. xen_domctl.domain is an IN/OUT parameter for this operation. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488659.756833 (Exim 4.92) (envelope-from ) id 1pNXSC-0002sq-67; Thu, 02 Feb 2023 11:08:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488659.756833; Thu, 02 Feb 2023 11:08:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSC-0002sj-35; Thu, 02 Feb 2023 11:08:32 +0000 Received: by outflank-mailman (input) for mailman id 488659; Thu, 02 Feb 2023 11:08:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSB-0002sX-AQ for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id eb3fd583-a2e9-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 12:08:28 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60140C14; Thu, 2 Feb 2023 03:09:09 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 046C93F64C; Thu, 2 Feb 2023 03:08:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb3fd583-a2e9-11ed-b63b-5f92e7d2e73a From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Nick Rosbrook , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 00/10] SVE feature for arm guests Date: Thu, 2 Feb 2023 11:08:06 +0000 Message-Id: <20230202110816.1252419-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This serie is introducing the possibility for Dom0 and DomU guests to use sve/sve2 instructions. SVE feature introduces new instruction and registers to improve performances on floating point operations. The SVE feature is advertised using the ID_AA64PFR0_EL1 register, SVE field, and when available the ID_AA64ZFR0_EL1 register provides additional information about the implemented version and other SVE feature. New registers added by the SVE feature are Z0-Z31, P0-P15, FFR, ZCR_ELx. Z0-Z31 are scalable vector register whose size is implementation defined and goes from 128 bits to maximum 2048, the term vector length will be used to refer to this quantity. P0-P15 are predicate registers and the size is the vector length divided by 8, same size is the FFR (First Fault Register). ZCR_ELx is a register that can control and restrict the maximum vector length used by the exception level and all the lower exception levels, so for example EL3 can restrict the vector length usable by EL3,2,1,0. The platform has a maximum implemented vector length, so for every value written in ZCR register, if this value is above the implemented length, then the lower value will be used. The RDVL instruction can be used to check what vector length is the HW using after setting ZCR. For an SVE guest, the V0-V31 registers are part of the Z0-Z31, so there is no need to save them separately, saving Z0-Z31 will save implicitly also V0-V31. SVE usage can be trapped using a flag in CPTR_EL2, hence in this serie the register is added to the domain state, to be able to trap only the guests that are not allowed to use SVE. This serie is introducing a command line parameter to enable Dom0 to use SVE and to set its maximum vector length that by default is 0 which means the guest is not allowed to use SVE. Values from 128 to 2048 mean the guest can use SVE with the selected value used as maximum allowed vector length (which could be lower if the implemented one is lower). For DomUs, an XL parameter with the same way of use is introduced and a dom0less DTB binding is created. The context switch is the most critical part because there can be big registers to be saved, in this serie an easy approach is used and the context is saved/restored every time for the guests that are allowed to use SVE. Luca Fancellu (10): xen/arm: enable SVE extension for Xen xen/arm: add sve_vl_bits field to domain xen/arm: Expose SVE feature to the guest xen/arm: add SVE exception class handling arm/sve: save/restore SVE context switch xen/arm: enable Dom0 to use SVE feature xen/physinfo: add arm SVE arch capability and vector length tools: add SVE capability and SVE vector length for physinfo xen/tools: add sve parameter in XL configuration xen/arm: add sve property for dom0less domUs docs/man/xl.cfg.5.pod.in | 11 ++ docs/misc/arm/device-tree/booting.txt | 9 ++ docs/misc/xen-command-line.pandoc | 13 ++ tools/golang/xenlight/helpers.gen.go | 6 + tools/golang/xenlight/types.gen.go | 3 + tools/include/libxl.h | 13 ++ tools/libs/light/libxl.c | 3 + tools/libs/light/libxl_arm.c | 2 + tools/libs/light/libxl_types.idl | 3 + tools/ocaml/libs/xc/xenctrl.ml | 4 +- tools/ocaml/libs/xc/xenctrl.mli | 4 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 17 +- tools/python/xen/lowlevel/xc/xc.c | 17 +- tools/xl/xl_info.c | 10 ++ tools/xl/xl_parse.c | 22 ++- xen/arch/arm/Kconfig | 10 +- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/cpufeature.c | 7 +- xen/arch/arm/arm64/sve.c | 118 ++++++++++++++ xen/arch/arm/arm64/sve_asm.S | 189 +++++++++++++++++++++++ xen/arch/arm/arm64/vfp.c | 79 ++++++---- xen/arch/arm/arm64/vsysreg.c | 39 ++++- xen/arch/arm/cpufeature.c | 6 +- xen/arch/arm/domain.c | 48 +++++- xen/arch/arm/domain_build.c | 11 ++ xen/arch/arm/include/asm/arm64/sve.h | 72 +++++++++ xen/arch/arm/include/asm/arm64/sysregs.h | 4 + xen/arch/arm/include/asm/arm64/vfp.h | 10 ++ xen/arch/arm/include/asm/cpufeature.h | 14 ++ xen/arch/arm/include/asm/domain.h | 8 + xen/arch/arm/include/asm/processor.h | 3 + xen/arch/arm/setup.c | 5 +- xen/arch/arm/sysctl.c | 7 + xen/arch/arm/traps.c | 40 +++-- xen/include/public/arch-arm.h | 3 + xen/include/public/domctl.h | 2 +- xen/include/public/sysctl.h | 11 +- 37 files changed, 751 insertions(+), 73 deletions(-) create mode 100644 xen/arch/arm/arm64/sve.c create mode 100644 xen/arch/arm/arm64/sve_asm.S create mode 100644 xen/arch/arm/include/asm/arm64/sve.h -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488662.756855 (Exim 4.92) (envelope-from ) id 1pNXSE-0003GF-3K; Thu, 02 Feb 2023 11:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488662.756855; Thu, 02 Feb 2023 11:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSD-0003E3-V8; Thu, 02 Feb 2023 11:08:33 +0000 Received: by outflank-mailman (input) for mailman id 488662; Thu, 02 Feb 2023 11:08:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSD-0002sY-53 for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ed7dffbc-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:31 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD2BC1480; Thu, 2 Feb 2023 03:09:13 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A4C63F64C; Thu, 2 Feb 2023 03:08:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed7dffbc-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 03/10] xen/arm: Expose SVE feature to the guest Date: Thu, 2 Feb 2023 11:08:09 +0000 Message-Id: <20230202110816.1252419-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a guest is allowed to use SVE, expose the SVE features through the identification registers. Signed-off-by: Luca Fancellu --- Changes from RFC: - No changes --- xen/arch/arm/arm64/vsysreg.c | 39 ++++++++++++++++++++++++++++++++++-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c index 758750983c11..10048bb4d221 100644 --- a/xen/arch/arm/arm64/vsysreg.c +++ b/xen/arch/arm/arm64/vsysreg.c @@ -18,6 +18,7 @@ #include +#include #include #include #include @@ -295,7 +296,28 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(MVFR0_EL1, mvfr, 0) GENERATE_TID3_INFO(MVFR1_EL1, mvfr, 1) GENERATE_TID3_INFO(MVFR2_EL1, mvfr, 2) - GENERATE_TID3_INFO(ID_AA64PFR0_EL1, pfr64, 0) + + case HSR_SYSREG_ID_AA64PFR0_EL1: + { + register_t guest_reg_value = guest_cpuinfo.pfr64.bits[0]; + + if ( is_sve_domain(v->domain) ) + { + /* 4 is the SVE field width in id_aa64pfr0_el1 */ + uint64_t mask = GENMASK(ID_AA64PFR0_SVE_SHIFT + 4 - 1, + ID_AA64PFR0_SVE_SHIFT); + /* sysval is the sve field on the system */ + uint64_t sysval = cpuid_feature_extract_unsigned_field_width( + system_cpuinfo.pfr64.bits[0], + ID_AA64PFR0_SVE_SHIFT, 4); + guest_reg_value &= ~mask; + guest_reg_value |= (sysval << ID_AA64PFR0_SVE_SHIFT) & mask; + } + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } + GENERATE_TID3_INFO(ID_AA64PFR1_EL1, pfr64, 1) GENERATE_TID3_INFO(ID_AA64DFR0_EL1, dbg64, 0) GENERATE_TID3_INFO(ID_AA64DFR1_EL1, dbg64, 1) @@ -306,7 +328,20 @@ void do_sysreg(struct cpu_user_regs *regs, GENERATE_TID3_INFO(ID_AA64MMFR2_EL1, mm64, 2) GENERATE_TID3_INFO(ID_AA64AFR0_EL1, aux64, 0) GENERATE_TID3_INFO(ID_AA64AFR1_EL1, aux64, 1) - GENERATE_TID3_INFO(ID_AA64ZFR0_EL1, zfr64, 0) + + case HSR_SYSREG_ID_AA64ZFR0_EL1: + { + /* + * When the guest has the SVE feature enabled, the whole id_aa64zfr0_el1 + * needs to be exposed. + */ + register_t guest_reg_value = guest_cpuinfo.zfr64.bits[0]; + if ( is_sve_domain(v->domain) ) + guest_reg_value = system_cpuinfo.zfr64.bits[0]; + + return handle_ro_read_val(regs, regidx, hsr.sysreg.read, hsr, 1, + guest_reg_value); + } /* * Those cases are catching all Reserved registers trapped by TID3 which -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488663.756877 (Exim 4.92) (envelope-from ) id 1pNXSF-0003oU-Lk; Thu, 02 Feb 2023 11:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488663.756877; Thu, 02 Feb 2023 11:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSF-0003mZ-D6; Thu, 02 Feb 2023 11:08:35 +0000 Received: by outflank-mailman (input) for mailman id 488663; Thu, 02 Feb 2023 11:08:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSE-0002sY-5K for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:34 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ee36cf06-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:32 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E62A414BF; Thu, 2 Feb 2023 03:09:14 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C35FE3F64C; Thu, 2 Feb 2023 03:08:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee36cf06-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 04/10] xen/arm: add SVE exception class handling Date: Thu, 2 Feb 2023 11:08:10 +0000 Message-Id: <20230202110816.1252419-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SVE has a new exception class with code 0x19, introduce the new code and handle the exception. Signed-off-by: Luca Fancellu --- Changes from RFC: - No changes --- xen/arch/arm/include/asm/processor.h | 1 + xen/arch/arm/traps.c | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 0e38926b94db..625c2bd0cd6c 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -426,6 +426,7 @@ #define HSR_EC_HVC64 0x16 #define HSR_EC_SMC64 0x17 #define HSR_EC_SYSREG 0x18 +#define HSR_EC_SVE 0x19 #endif #define HSR_EC_INSTR_ABORT_LOWER_EL 0x20 #define HSR_EC_INSTR_ABORT_CURR_EL 0x21 diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index a78a99ddadd0..c2e30feafd5a 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -2160,6 +2160,13 @@ void do_trap_guest_sync(struct cpu_user_regs *regs) perfc_incr(trap_sysreg); do_sysreg(regs, hsr); break; + case HSR_EC_SVE: + GUEST_BUG_ON(regs_mode_is_32bit(regs)); + gprintk(XENLOG_WARNING, + "Domain id %d tried to use SVE while not allowed\n", + current->domain->domain_id); + inject_undef_exception(regs, hsr); + break; #endif case HSR_EC_INSTR_ABORT_LOWER_EL: @@ -2189,6 +2196,11 @@ void do_trap_hyp_sync(struct cpu_user_regs *regs) case HSR_EC_BRK: do_trap_brk(regs, hsr); break; + case HSR_EC_SVE: + /* An SVE exception is a bug somewhere in hypervisor code */ + printk("SVE trap at EL2.\n"); + do_unexpected_trap("Hypervisor", regs); + break; #endif case HSR_EC_DATA_ABORT_CURR_EL: case HSR_EC_INSTR_ABORT_CURR_EL: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488664.756889 (Exim 4.92) (envelope-from ) id 1pNXSH-0004C6-SX; Thu, 02 Feb 2023 11:08:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488664.756889; Thu, 02 Feb 2023 11:08:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSH-0004By-Ov; Thu, 02 Feb 2023 11:08:37 +0000 Received: by outflank-mailman (input) for mailman id 488664; Thu, 02 Feb 2023 11:08:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSG-0002sY-FB for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id ef050eaa-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A34F1515; Thu, 2 Feb 2023 03:09:16 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 08F443F64C; Thu, 2 Feb 2023 03:08:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef050eaa-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 05/10] arm/sve: save/restore SVE context switch Date: Thu, 2 Feb 2023 11:08:11 +0000 Message-Id: <20230202110816.1252419-6-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Save/restore context switch for SVE, allocate memory to contain the Z0-31 registers whose length is maximum 2048 bits each and FFR who can be maximum 256 bits, the allocated memory depends on how many bits is the vector length for the domain and how many bits are supported by the platform. Save P0-15 whose length is maximum 256 bits each, in this case the memory used is from the fpregs field in struct vfp_state, because V0-31 are part of Z0-31 and this space would have been unused for SVE domain otherwise. Create zcr_el{1,2} fields in arch_vcpu, initialise zcr_el2 on vcpu creation given the requested vector length and restore it on context switch, save/restore ZCR_EL1 value as well. Remove headers from sve.c that are already included using xen/sched.h. Signed-off-by: Luca Fancellu --- Changes from RFC: - Moved zcr_el2 field introduction in this patch, restore its content inside sve_restore_state function. (Julien) --- xen/arch/arm/arm64/sve.c | 65 ++++++++++- xen/arch/arm/arm64/sve_asm.S | 141 +++++++++++++++++++++++ xen/arch/arm/arm64/vfp.c | 79 +++++++------ xen/arch/arm/domain.c | 7 ++ xen/arch/arm/include/asm/arm64/sve.h | 13 +++ xen/arch/arm/include/asm/arm64/sysregs.h | 3 + xen/arch/arm/include/asm/arm64/vfp.h | 10 ++ xen/arch/arm/include/asm/domain.h | 2 + 8 files changed, 281 insertions(+), 39 deletions(-) diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index eee39caa9efa..bb3229ead005 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -5,14 +5,29 @@ * Copyright (C) 2022 ARM Ltd. */ -#include -#include +#include +#include #include -#include -#include -#include extern unsigned int sve_get_hw_vl(void); +extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); +extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, + int restore_ffr); + +static inline uint16_t sve_zreg_ctx_size(uint16_t vl) +{ + /* + * Z0-31 registers size in bytes is computed from VL that is in bits, so VL + * in bytes is VL/8. + */ + return (vl / 8U) * 32U; +} + +static inline uint16_t sve_ffrreg_ctx_size(uint16_t vl) +{ + /* FFR register size is VL/8, which is in bytes (VL/8)/8 */ + return (vl / 64U); +} register_t compute_max_zcr(void) { @@ -56,3 +71,43 @@ uint16_t get_sys_vl_len(void) return ((system_cpuinfo.zcr64.bits[0] & ZCR_ELx_LEN_MASK) + 1U) * SVE_VL_MULTIPLE_VAL; } + +int sve_context_init(struct vcpu *v) +{ + uint64_t *ctx = _xzalloc(sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) + + sve_ffrreg_ctx_size(v->domain->arch.sve_vl_bits), + L1_CACHE_BYTES); + + if ( !ctx ) + return -ENOMEM; + + v->arch.vfp.sve_context = ctx; + + return 0; +} + +void sve_context_free(struct vcpu *v) +{ + xfree(v->arch.vfp.sve_context); +} + +void sve_save_state(struct vcpu *v) +{ + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) / sizeof(uint64_t)); + + v->arch.zcr_el1 = READ_SYSREG(ZCR_EL1); + + sve_save_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} + +void sve_restore_state(struct vcpu *v) +{ + uint64_t *sve_ctx_zreg_end = v->arch.vfp.sve_context + + (sve_zreg_ctx_size(v->domain->arch.sve_vl_bits) / sizeof(uint64_t)); + + WRITE_SYSREG(v->arch.zcr_el1, ZCR_EL1); + WRITE_SYSREG(v->arch.zcr_el2, ZCR_EL2); + + sve_load_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); +} diff --git a/xen/arch/arm/arm64/sve_asm.S b/xen/arch/arm/arm64/sve_asm.S index 4d1549344733..8c37d7bc95d5 100644 --- a/xen/arch/arm/arm64/sve_asm.S +++ b/xen/arch/arm/arm64/sve_asm.S @@ -17,6 +17,18 @@ .endif .endm +.macro _sve_check_zreg znr + .if (\znr) < 0 || (\znr) > 31 + .error "Bad Scalable Vector Extension vector register number \znr." + .endif +.endm + +.macro _sve_check_preg pnr + .if (\pnr) < 0 || (\pnr) > 15 + .error "Bad Scalable Vector Extension predicate register number \pnr." + .endif +.endm + .macro _check_num n, min, max .if (\n) < (\min) || (\n) > (\max) .error "Number \n out of range [\min,\max]" @@ -26,6 +38,54 @@ /* SVE instruction encodings for non-SVE-capable assemblers */ /* (pre binutils 2.28, all kernel capable clang versions support SVE) */ +/* STR (vector): STR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (vector): LDR Z\nz, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_v nz, nxbase, offset=0 + _sve_check_zreg \nz + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85804000 \ + | (\nz) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* STR (predicate): STR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_str_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0xe5800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + +/* LDR (predicate): LDR P\np, [X\nxbase, #\offset, MUL VL] */ +.macro _sve_ldr_p np, nxbase, offset=0 + _sve_check_preg \np + _check_general_reg \nxbase + _check_num (\offset), -0x100, 0xff + .inst 0x85800000 \ + | (\np) \ + | ((\nxbase) << 5) \ + | (((\offset) & 7) << 10) \ + | (((\offset) & 0x1f8) << 13) +.endm + /* RDVL X\nx, #\imm */ .macro _sve_rdvl nx, imm _check_general_reg \nx @@ -35,11 +95,92 @@ | (((\imm) & 0x3f) << 5) .endm +/* RDFFR (unpredicated): RDFFR P\np.B */ +.macro _sve_rdffr np + _sve_check_preg \np + .inst 0x2519f000 \ + | (\np) +.endm + +/* WRFFR P\np.B */ +.macro _sve_wrffr np + _sve_check_preg \np + .inst 0x25289000 \ + | ((\np) << 5) +.endm + +.macro __for from:req, to:req + .if (\from) == (\to) + _for__body %\from + .else + __for %\from, %((\from) + ((\to) - (\from)) / 2) + __for %((\from) + ((\to) - (\from)) / 2 + 1), %\to + .endif +.endm + +.macro _for var:req, from:req, to:req, insn:vararg + .macro _for__body \var:req + .noaltmacro + \insn + .altmacro + .endm + + .altmacro + __for \from, \to + .noaltmacro + + .purgem _for__body +.endm + +.macro sve_save nxzffrctx, nxpctx, save_ffr + _for n, 0, 31, _sve_str_v \n, \nxzffrctx, \n - 32 + _for n, 0, 15, _sve_str_p \n, \nxpctx, \n + cbz \save_ffr, 1f + _sve_rdffr 0 + _sve_str_p 0, \nxzffrctx + _sve_ldr_p 0, \nxpctx + b 2f +1: + str xzr, [x\nxzffrctx] // Zero out FFR +2: +.endm + +.macro sve_load nxzffrctx, nxpctx, restore_ffr + _for n, 0, 31, _sve_ldr_v \n, \nxzffrctx, \n - 32 + cbz \restore_ffr, 1f + _sve_ldr_p 0, \nxzffrctx + _sve_wrffr 0 +1: + _for n, 0, 15, _sve_ldr_p \n, \nxpctx, \n +.endm + /* Gets the current vector register size in bytes */ GLOBAL(sve_get_hw_vl) _sve_rdvl 0, 1 ret +/* + * Save the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Save FFR if non-zero + */ +GLOBAL(sve_save_ctx) + sve_save 0, 1, x2 + ret + +/* + * Load the SVE context + * + * x0 - pointer to buffer for Z0-31 + FFR + * x1 - pointer to buffer for P0-15 + * x2 - Restore FFR if non-zero + */ +GLOBAL(sve_load_ctx) + sve_load 0, 1, x2 + ret + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/arm64/vfp.c b/xen/arch/arm/arm64/vfp.c index 47885e76baae..2d0d7c2e6ddb 100644 --- a/xen/arch/arm/arm64/vfp.c +++ b/xen/arch/arm/arm64/vfp.c @@ -2,29 +2,35 @@ #include #include #include +#include void vfp_save_state(struct vcpu *v) { if ( !cpu_has_fp ) return; - asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" - "stp q2, q3, [%1, #16 * 2]\n\t" - "stp q4, q5, [%1, #16 * 4]\n\t" - "stp q6, q7, [%1, #16 * 6]\n\t" - "stp q8, q9, [%1, #16 * 8]\n\t" - "stp q10, q11, [%1, #16 * 10]\n\t" - "stp q12, q13, [%1, #16 * 12]\n\t" - "stp q14, q15, [%1, #16 * 14]\n\t" - "stp q16, q17, [%1, #16 * 16]\n\t" - "stp q18, q19, [%1, #16 * 18]\n\t" - "stp q20, q21, [%1, #16 * 20]\n\t" - "stp q22, q23, [%1, #16 * 22]\n\t" - "stp q24, q25, [%1, #16 * 24]\n\t" - "stp q26, q27, [%1, #16 * 26]\n\t" - "stp q28, q29, [%1, #16 * 28]\n\t" - "stp q30, q31, [%1, #16 * 30]\n\t" - : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_save_state(v); + else + { + asm volatile("stp q0, q1, [%1, #16 * 0]\n\t" + "stp q2, q3, [%1, #16 * 2]\n\t" + "stp q4, q5, [%1, #16 * 4]\n\t" + "stp q6, q7, [%1, #16 * 6]\n\t" + "stp q8, q9, [%1, #16 * 8]\n\t" + "stp q10, q11, [%1, #16 * 10]\n\t" + "stp q12, q13, [%1, #16 * 12]\n\t" + "stp q14, q15, [%1, #16 * 14]\n\t" + "stp q16, q17, [%1, #16 * 16]\n\t" + "stp q18, q19, [%1, #16 * 18]\n\t" + "stp q20, q21, [%1, #16 * 20]\n\t" + "stp q22, q23, [%1, #16 * 22]\n\t" + "stp q24, q25, [%1, #16 * 24]\n\t" + "stp q26, q27, [%1, #16 * 26]\n\t" + "stp q28, q29, [%1, #16 * 28]\n\t" + "stp q30, q31, [%1, #16 * 30]\n\t" + : "=Q" (*v->arch.vfp.fpregs) : "r" (v->arch.vfp.fpregs)); + } v->arch.vfp.fpsr = READ_SYSREG(FPSR); v->arch.vfp.fpcr = READ_SYSREG(FPCR); @@ -37,23 +43,28 @@ void vfp_restore_state(struct vcpu *v) if ( !cpu_has_fp ) return; - asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" - "ldp q2, q3, [%1, #16 * 2]\n\t" - "ldp q4, q5, [%1, #16 * 4]\n\t" - "ldp q6, q7, [%1, #16 * 6]\n\t" - "ldp q8, q9, [%1, #16 * 8]\n\t" - "ldp q10, q11, [%1, #16 * 10]\n\t" - "ldp q12, q13, [%1, #16 * 12]\n\t" - "ldp q14, q15, [%1, #16 * 14]\n\t" - "ldp q16, q17, [%1, #16 * 16]\n\t" - "ldp q18, q19, [%1, #16 * 18]\n\t" - "ldp q20, q21, [%1, #16 * 20]\n\t" - "ldp q22, q23, [%1, #16 * 22]\n\t" - "ldp q24, q25, [%1, #16 * 24]\n\t" - "ldp q26, q27, [%1, #16 * 26]\n\t" - "ldp q28, q29, [%1, #16 * 28]\n\t" - "ldp q30, q31, [%1, #16 * 30]\n\t" - : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + if ( is_sve_domain(v->domain) ) + sve_restore_state(v); + else + { + asm volatile("ldp q0, q1, [%1, #16 * 0]\n\t" + "ldp q2, q3, [%1, #16 * 2]\n\t" + "ldp q4, q5, [%1, #16 * 4]\n\t" + "ldp q6, q7, [%1, #16 * 6]\n\t" + "ldp q8, q9, [%1, #16 * 8]\n\t" + "ldp q10, q11, [%1, #16 * 10]\n\t" + "ldp q12, q13, [%1, #16 * 12]\n\t" + "ldp q14, q15, [%1, #16 * 14]\n\t" + "ldp q16, q17, [%1, #16 * 16]\n\t" + "ldp q18, q19, [%1, #16 * 18]\n\t" + "ldp q20, q21, [%1, #16 * 20]\n\t" + "ldp q22, q23, [%1, #16 * 22]\n\t" + "ldp q24, q25, [%1, #16 * 24]\n\t" + "ldp q26, q27, [%1, #16 * 26]\n\t" + "ldp q28, q29, [%1, #16 * 28]\n\t" + "ldp q30, q31, [%1, #16 * 30]\n\t" + : : "Q" (*v->arch.vfp.fpregs), "r" (v->arch.vfp.fpregs)); + } WRITE_SYSREG(v->arch.vfp.fpsr, FPSR); WRITE_SYSREG(v->arch.vfp.fpcr, FPCR); diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 8d64e3c08edf..4a9a19189dd2 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -552,7 +552,12 @@ int arch_vcpu_create(struct vcpu *v) v->arch.cptr_el2 = get_default_cptr_flags(); if ( is_sve_domain(v->domain) ) + { + if ( (rc = sve_context_init(v)) != 0 ) + goto fail; v->arch.cptr_el2 &= ~HCPTR_CP(8); + v->arch.zcr_el2 = vl_to_zcr(v->domain->arch.sve_vl_bits); + } v->arch.hcr_el2 = get_default_hcr_flags(); @@ -582,6 +587,8 @@ fail: void arch_vcpu_destroy(struct vcpu *v) { + if ( is_sve_domain(v->domain) ) + sve_context_free(v); vcpu_timer_destroy(v); vcpu_vgic_free(v); free_xenheap_pages(v->arch.stack, STACK_ORDER); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index f4a660e402ca..28c31b329233 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -24,6 +24,10 @@ static inline bool is_vl_valid(uint16_t vl) register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); uint16_t get_sys_vl_len(void); +int sve_context_init(struct vcpu *v); +void sve_context_free(struct vcpu *v); +void sve_save_state(struct vcpu *v); +void sve_restore_state(struct vcpu *v); #else /* !CONFIG_ARM64_SVE */ @@ -42,6 +46,15 @@ static inline uint16_t get_sys_vl_len(void) return 0; } +static inline int sve_context_init(struct vcpu *v) +{ + return 0; +} + +static inline void sve_context_free(struct vcpu *v) {} +static inline void sve_save_state(struct vcpu *v) {} +static inline void sve_restore_state(struct vcpu *v) {} + #endif #endif /* _ARM_ARM64_SVE_H */ diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 4cabb9eb4d5e..3fdeb9d8cdef 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -88,6 +88,9 @@ #ifndef ID_AA64ISAR2_EL1 #define ID_AA64ISAR2_EL1 S3_0_C0_C6_2 #endif +#ifndef ZCR_EL1 +#define ZCR_EL1 S3_0_C1_C2_0 +#endif /* ID registers (imported from arm64/include/asm/sysreg.h in Linux) */ diff --git a/xen/arch/arm/include/asm/arm64/vfp.h b/xen/arch/arm/include/asm/arm64/vfp.h index e6e8c363bc16..8af714cb8ecc 100644 --- a/xen/arch/arm/include/asm/arm64/vfp.h +++ b/xen/arch/arm/include/asm/arm64/vfp.h @@ -6,7 +6,17 @@ struct vfp_state { + /* + * When SVE is enabled for the guest, fpregs memory will be used to + * save/restore P0-P15 registers, otherwise it will be used for the V0-V31 + * registers. + */ uint64_t fpregs[64] __vfp_aligned; + /* + * When SVE is enabled for the guest, sve_context contains memory to + * save/restore Z0-Z31 registers and FFR. + */ + uint64_t *sve_context; register_t fpcr; register_t fpexc32_el2; register_t fpsr; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 1bd669e0a5c1..4d1066750a9b 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -195,6 +195,8 @@ struct arch_vcpu register_t tpidrro_el0; /* HYP configuration */ + register_t zcr_el1; + register_t zcr_el2; register_t cptr_el2; register_t hcr_el2; register_t mdcr_el2; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488665.756900 (Exim 4.92) (envelope-from ) id 1pNXSJ-0004U2-Ac; Thu, 02 Feb 2023 11:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488665.756900; Thu, 02 Feb 2023 11:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSJ-0004Td-4Z; Thu, 02 Feb 2023 11:08:39 +0000 Received: by outflank-mailman (input) for mailman id 488665; Thu, 02 Feb 2023 11:08:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSI-0002sX-Dp for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id f0699365-a2e9-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 12:08:36 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 079C4152B; Thu, 2 Feb 2023 03:09:18 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 615443F64C; Thu, 2 Feb 2023 03:08:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0699365-a2e9-11ed-b63b-5f92e7d2e73a From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: [PATCH 06/10] xen/arm: enable Dom0 to use SVE feature Date: Thu, 2 Feb 2023 11:08:12 +0000 Message-Id: <20230202110816.1252419-7-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a command line parameter to allow Dom0 the use of SVE resources, the command line parameter dom0_sve controls the feature on this domain and sets the maximum SVE vector length for Dom0. Signed-off-by: Luca Fancellu --- Changes from RFC: - Changed docs to explain that the domain won't be created if the requested vector length is above the supported one from the platform. --- docs/misc/xen-command-line.pandoc | 13 +++++++++++++ xen/arch/arm/arm64/sve.c | 5 +++++ xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/include/asm/arm64/sve.h | 4 ++++ 4 files changed, 26 insertions(+) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 923910f553c5..5ccda7037f5a 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -995,6 +995,19 @@ restrictions set up here. Note that the values to be specified here are ACPI PXM ones, not Xen internal node numbers. `relaxed` sets up vCPU affinities to prefer but be not limited to the specified node(s). +### dom0_sve (arm) +> `= ` + +> Default: `0` + +Enable arm SVE usage for Dom0 domain and sets the maximum SVE vector length. +Values above 0 means feature is enabled for Dom0, otherwise feature is disabled. +Possible values are from 0 to maximum 2048, being multiple of 128, that will be +the maximum vector length. +Please note that the platform can supports a lower value, if the requested value +is above the supported one, the domain creation will fail and the system will +stop. + ### dom0_vcpus_pin > `= ` diff --git a/xen/arch/arm/arm64/sve.c b/xen/arch/arm/arm64/sve.c index bb3229ead005..6f6bf30b5c4c 100644 --- a/xen/arch/arm/arm64/sve.c +++ b/xen/arch/arm/arm64/sve.c @@ -5,10 +5,15 @@ * Copyright (C) 2022 ARM Ltd. */ +#include #include #include #include +/* opt_dom0_sve: allow Dom0 to use SVE and set maximum vector length. */ +unsigned int __initdata opt_dom0_sve; +integer_param("dom0_sve", opt_dom0_sve); + extern unsigned int sve_get_hw_vl(void); extern void sve_save_ctx(uint64_t *sve_ctx, uint64_t *pregs, int save_ffr); extern void sve_load_ctx(uint64_t const *sve_ctx, uint64_t const *pregs, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c2b97fa21e20..fbfdf3417cef 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -4076,6 +4077,9 @@ void __init create_dom0(void) if ( iommu_enabled ) dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; + if ( opt_dom0_sve > 0 ) + dom0_cfg.arch.sve_vl_bits = opt_dom0_sve; + dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) panic("Error creating domain 0\n"); diff --git a/xen/arch/arm/include/asm/arm64/sve.h b/xen/arch/arm/include/asm/arm64/sve.h index 28c31b329233..dc6e747cec9e 100644 --- a/xen/arch/arm/include/asm/arm64/sve.h +++ b/xen/arch/arm/include/asm/arm64/sve.h @@ -21,6 +21,8 @@ static inline bool is_vl_valid(uint16_t vl) #ifdef CONFIG_ARM64_SVE +extern unsigned int opt_dom0_sve; + register_t compute_max_zcr(void); register_t vl_to_zcr(uint16_t vl); uint16_t get_sys_vl_len(void); @@ -31,6 +33,8 @@ void sve_restore_state(struct vcpu *v); #else /* !CONFIG_ARM64_SVE */ +#define opt_dom0_sve (0) + static inline register_t compute_max_zcr(void) { return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488666.756911 (Exim 4.92) (envelope-from ) id 1pNXSK-0004nh-P6; Thu, 02 Feb 2023 11:08:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488666.756911; Thu, 02 Feb 2023 11:08:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSK-0004mv-Jv; Thu, 02 Feb 2023 11:08:40 +0000 Received: by outflank-mailman (input) for mailman id 488666; Thu, 02 Feb 2023 11:08:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSI-0002sY-ST for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id f10c0395-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:37 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B92C9C14; Thu, 2 Feb 2023 03:09:19 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E93D3F64C; Thu, 2 Feb 2023 03:08:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f10c0395-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH 07/10] xen/physinfo: add arm SVE arch capability and vector length Date: Thu, 2 Feb 2023 11:08:13 +0000 Message-Id: <20230202110816.1252419-8-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the arm platform supports SVE, advertise the feature by a new flag for the arch_capabilities in struct xen_sysctl_physinfo and add a new field "arm_sve_vl_bits" where on arm there can be stored the maximum SVE vector length in bits. Update the padding. Bump XEN_SYSCTL_INTERFACE_VERSION for the changes. Signed-off-by: Luca Fancellu --- Changes from RFC: - new patch --- Here I need an opinion from arm and x86 maintainer, I see there is no arch specific structure in struct xen_sysctl_physinfo, hw_cap is used only by x86 and now arch_capabilities and the new arm_sve_vl_bits will be used only by arm. So how should we proceed here? Shall we create a struct arch for each architecture and for example move arch_capabilities inside it (renaming to capabilities) and every arch specific field as well? (is hw_cap only for x86?) --- xen/arch/arm/sysctl.c | 7 +++++++ xen/include/public/sysctl.h | 11 +++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index b0a78a8b10d0..d65f8be498f4 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -11,11 +11,18 @@ #include #include #include +#include #include void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm | XEN_SYSCTL_PHYSCAP_hap; + + if ( cpu_has_sve ) + { + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_ARM_sve; + pi->arm_sve_vl_bits = get_sys_vl_len(); + } } long arch_do_sysctl(struct xen_sysctl *sysctl, diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 001a4de27375..5acbb41256bc 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -18,7 +18,7 @@ #include "domctl.h" #include "physdev.h" -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015 +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000016 /* * Read console content from Xen buffer ring. @@ -94,6 +94,12 @@ struct xen_sysctl_tbuf_op { /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */ #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2 +/* Arm platform is SVE capable */ +#define XEN_SYSCTL_PHYSCAP_ARM_sve (1u << 0) + +/* Max XEN_SYSCTL_PHYSCAP_ARM_* constant. Used for ABI checking. */ +#define XEN_SYSCTL_PHYSCAP_ARM_MAX XEN_SYSCTL_PHYSCAP_ARM_sve + struct xen_sysctl_physinfo { uint32_t threads_per_core; uint32_t cores_per_socket; @@ -104,7 +110,8 @@ struct xen_sysctl_physinfo { uint32_t cpu_khz; uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */ uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */ - uint32_t pad; + uint16_t arm_sve_vl_bits; + uint16_t pad; uint64_aligned_t total_pages; uint64_aligned_t free_pages; uint64_aligned_t scrub_pages; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488667.756922 (Exim 4.92) (envelope-from ) id 1pNXSN-0005BK-5L; Thu, 02 Feb 2023 11:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488667.756922; Thu, 02 Feb 2023 11:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSN-0005Az-2F; Thu, 02 Feb 2023 11:08:43 +0000 Received: by outflank-mailman (input) for mailman id 488667; Thu, 02 Feb 2023 11:08:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSL-0002sY-5V for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id f2312453-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:39 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 952361042; Thu, 2 Feb 2023 03:09:21 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0B6F3F64C; Thu, 2 Feb 2023 03:08:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2312453-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH 08/10] tools: add SVE capability and SVE vector length for physinfo Date: Thu, 2 Feb 2023 11:08:14 +0000 Message-Id: <20230202110816.1252419-9-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Recent changes added in struct xen_sysctl_physinfo a new flag for arch_capabilities to understand when the platform is SVE capable, another field having the maximum SVE vector length in bits was added as well, so update the tools to handle these new fields. Signed-off-by: Luca Fancellu --- Changes from RFC: - new patch --- This patch is mostly dependent on the decisions we make in the previous, anyway I touched some part of the toolstack where my knowledge is limited (ocaml) so I might need a feedback for something I may have done wrong. --- tools/golang/xenlight/helpers.gen.go | 4 ++++ tools/golang/xenlight/types.gen.go | 2 ++ tools/include/libxl.h | 8 ++++++++ tools/libs/light/libxl.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/ocaml/libs/xc/xenctrl.ml | 4 +++- tools/ocaml/libs/xc/xenctrl.mli | 4 +++- tools/ocaml/libs/xc/xenctrl_stubs.c | 17 +++++++++++++---- tools/python/xen/lowlevel/xc/xc.c | 17 +++++++++++++++-- tools/xl/xl_info.c | 10 ++++++++++ 10 files changed, 63 insertions(+), 8 deletions(-) diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 3ac4938858f2..0e2c1b3acc74 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -3455,6 +3455,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace) x.CapVpmu = bool(xc.cap_vpmu) x.CapGnttabV1 = bool(xc.cap_gnttab_v1) x.CapGnttabV2 = bool(xc.cap_gnttab_v2) +x.CapArmSve = bool(xc.cap_arm_sve) +x.ArmSveVlBits = uint16(xc.arm_sve_vl_bits) return nil} @@ -3489,6 +3491,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace) xc.cap_vpmu = C.bool(x.CapVpmu) xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1) xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2) +xc.cap_arm_sve = C.bool(x.CapArmSve) +xc.arm_sve_vl_bits = C.uint16(x.ArmSveVlBits) return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 16ce879e3fb7..d4b67c97bb54 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -1051,6 +1051,8 @@ CapVmtrace bool CapVpmu bool CapGnttabV1 bool CapGnttabV2 bool +CapArmSve bool +ArmSveVlBits uint16 } type Connectorinfo struct { diff --git a/tools/include/libxl.h b/tools/include/libxl.h index d652895075a0..ce2997486953 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -520,6 +520,14 @@ */ #define LIBXL_HAVE_PHYSINFO_CAP_GNTTAB 1 +/* + * LIBXL_HAVE_PHYSINFO_CAP_ARM_SVE indicates that libxl_physinfo has a + * cap_arm_sve field, which indicates the availability of Arm SVE feature for + * guests and has arm_sve_vl_bits fields which indicates the supported maximum + * vector length for the platform. + */ +#define LIBXL_HAVE_PHYSINFO_CAP_ARM_SVE 1 + /* * LIBXL_HAVE_MAX_GRANT_VERSION indicates libxl_domain_build_info has a * max_grant_version field for setting the max grant table version per diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index a0bf7d186f69..ed9bd0ff520b 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -409,6 +409,9 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v1); physinfo->cap_gnttab_v2 = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2); + physinfo->cap_arm_sve = + !!(xcphysinfo.arch_capabilities & XEN_SYSCTL_PHYSCAP_ARM_sve); + physinfo->arm_sve_vl_bits = xcphysinfo.arm_sve_vl_bits; GC_FREE; return 0; diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 0cfad8508dbd..5bd44b37c74d 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -1106,6 +1106,8 @@ libxl_physinfo = Struct("physinfo", [ ("cap_vpmu", bool), ("cap_gnttab_v1", bool), ("cap_gnttab_v2", bool), + ("cap_arm_sve", bool), + ("arm_sve_vl_bits", uint16), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 7442bbbfc5e0..ce8ce2d1a663 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -128,7 +128,8 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 -type arm_physinfo_cap_flag +type arm_physinfo_cap_flag = + | CAP_sve type x86_physinfo_cap_flag @@ -150,6 +151,7 @@ type physinfo = capabilities : physinfo_cap_flag list; max_nr_cpus : int; arch_capabilities : arch_physinfo_cap_flags; + arm_sve_vl_bits : int; } type version = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 82def5a17cc2..ac479f44ddb2 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -113,7 +113,8 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 -type arm_physinfo_cap_flag +type arm_physinfo_cap_flag = + | CAP_sve type x86_physinfo_cap_flag @@ -133,6 +134,7 @@ type physinfo = { capabilities : physinfo_cap_flag list; max_nr_cpus : int; (** compile-time max possible number of nr_cpus *) arch_capabilities : arch_physinfo_cap_flags; + arm_sve_vl_bits : int; } type version = { major : int; minor : int; extra : string; } type compile_info = { diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 2fba9c5e94d6..d85e4a20e6d0 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -810,7 +810,7 @@ CAMLprim value stub_xc_physinfo(value xch) /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */ (c_physinfo.capabilities); - physinfo = caml_alloc_tuple(11); + physinfo = caml_alloc_tuple(12); Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus)); @@ -825,13 +825,22 @@ CAMLprim value stub_xc_physinfo(value xch) #if defined(__i386__) || defined(__x86_64__) arch_cap_list = Tag_cons; - arch_cap_flags_tag = 1; /* tag x86 */ + arch_cap_flags = caml_alloc_small(1, 1); + Store_field(arch_cap_flags, 0, arch_cap_list); + Store_field(physinfo, 11, Tag_cons); +#elif defined (__arm__) || defined(__aarch64__) + /* + * capabilities: arm_physinfo_cap_flag list; + */ + arch_cap_flags = c_bitmap_to_ocaml_list + /* ! arm_physinfo_cap_flag CAP_ lc */ + /* ! XEN_SYSCTL_PHYSCAP_ARM_ XEN_SYSCTL_PHYSCAP_ARM_MAX max */ + (c_physinfo.arch_capabilities); + Store_field(physinfo, 11, Val_int(c_physinfo.arm_sve_vl_bits)); #else caml_failwith("Unhandled architecture"); #endif - arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag); - Store_field(arch_cap_flags, 0, arch_cap_list); Store_field(physinfo, 10, arch_cap_flags); CAMLreturn(physinfo); diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c index fd008610329b..516fa57161a6 100644 --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -870,6 +870,11 @@ static PyObject *pyxc_physinfo(XcObject *self) const char *virtcap_names[] = { "hvm", "pv" }; const unsigned virtcaps_bits[] = { XEN_SYSCTL_PHYSCAP_hvm, XEN_SYSCTL_PHYSCAP_pv }; +#if defined(__aarch64__) + const char py_buildval[] = "{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s,s:i}"; +#else + const char py_buildval[] = "{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s}"; +#endif if ( xc_physinfo(self->xc_handle, &pinfo) != 0 ) return pyxc_error_to_exception(self->xc_handle); @@ -893,10 +898,14 @@ static PyObject *pyxc_physinfo(XcObject *self) for ( i = 0; i < ARRAY_SIZE(virtcaps_bits); i++ ) if ( pinfo.capabilities & virtcaps_bits[i] ) p += sprintf(p, "%s_directio ", virtcap_names[i]); +#if defined(__aarch64__) + if ( pinfo.arch_capabilities & XEN_SYSCTL_PHYSCAP_ARM_sve ) + p += sprintf(p, "%s ", "arm_sve"); +#endif if ( p != virt_caps ) *(p-1) = '\0'; - return Py_BuildValue("{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s}", + return Py_BuildValue(py_buildval, "nr_nodes", pinfo.nr_nodes, "threads_per_core", pinfo.threads_per_core, "cores_per_socket", pinfo.cores_per_socket, @@ -906,7 +915,11 @@ static PyObject *pyxc_physinfo(XcObject *self) "scrub_memory", pages_to_kib(pinfo.scrub_pages), "cpu_khz", pinfo.cpu_khz, "hw_caps", cpu_cap, - "virt_caps", virt_caps); + "virt_caps", virt_caps +#if defined(__aarch64__) + , "arm_sve_vl_bits", pinfo.arm_sve_vl_bits +#endif + ); } static PyObject *pyxc_getcpuinfo(XcObject *self, PyObject *args, PyObject *kwds) diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 712b7638b013..44345d405873 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -210,7 +210,11 @@ static void output_physinfo(void) info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7] ); +#if defined(__aarch64__) + maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s%s\n", +#else maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s\n", +#endif info.cap_pv ? " pv" : "", info.cap_hvm ? " hvm" : "", info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "", @@ -222,6 +226,9 @@ static void output_physinfo(void) info.cap_vpmu ? " vpmu" : "", info.cap_gnttab_v1 ? " gnttab-v1" : "", info.cap_gnttab_v2 ? " gnttab-v2" : "" +#if defined(__aarch64__) + , info.cap_arm_sve ? " arm_sve" : "" +#endif ); vinfo = libxl_get_version_info(ctx); @@ -240,6 +247,9 @@ static void output_physinfo(void) maybe_printf("free_cpus : %d\n", n); free(cpumap.map); } +#if defined(__aarch64__) + maybe_printf("arm_sve_max_vl_bits : %d\n", info.arm_sve_vl_bits); +#endif libxl_physinfo_dispose(&info); return; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488670.756931 (Exim 4.92) (envelope-from ) id 1pNXSO-0005Su-Lg; Thu, 02 Feb 2023 11:08:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488670.756931; Thu, 02 Feb 2023 11:08:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSO-0005Rk-EP; Thu, 02 Feb 2023 11:08:44 +0000 Received: by outflank-mailman (input) for mailman id 488670; Thu, 02 Feb 2023 11:08:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSN-0002sY-7c for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:43 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id f3c94b04-a2e9-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:08:42 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FEC4C14; Thu, 2 Feb 2023 03:09:24 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CBAC3F64C; Thu, 2 Feb 2023 03:08:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3c94b04-a2e9-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 10/10] xen/arm: add sve property for dom0less domUs Date: Thu, 2 Feb 2023 11:08:16 +0000 Message-Id: <20230202110816.1252419-11-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a device tree property in the dom0less domU configuration to enable the guest to use SVE. Update documentation. Signed-off-by: Luca Fancellu --- Changes from RFC: - Changed documentation --- docs/misc/arm/device-tree/booting.txt | 9 +++++++++ xen/arch/arm/domain_build.c | 7 +++++++ 2 files changed, 16 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 3879340b5e0a..d74bf9ab1c8b 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -193,6 +193,15 @@ with the following properties: Optional. Handle to a xen,cpupool device tree node that identifies the cpupool where the guest will be started at boot. +- sve + + Optional. A number that, when above 0, enables SVE for this guest and sets + its maximum SVE vector length. The default value is 0, that means this + guest is not allowed to use SVE, the maximum value allowed is 2048, any + other value must be multiple of 128. + Please note that if the platform supports a lower value of bits, then the + domain creation will fail. + - xen,enhanced A string property. Possible property values are: diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fbfdf3417cef..3752e2c7dc16 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3960,6 +3960,13 @@ void __init create_domUs(void) d_cfg.max_maptrack_frames = val; } + if ( dt_property_read_u32(node, "sve", &val) ) + { + if ( val > UINT16_MAX ) + panic("sve property value (%"PRIu32") overflow\n", val); + d_cfg.arch.sve_vl_bits = val; + } + /* * The variable max_init_domid is initialized with zero, so here it's * very important to use the pre-increment operator to call -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:08:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488672.756942 (Exim 4.92) (envelope-from ) id 1pNXSQ-0005pE-HK; Thu, 02 Feb 2023 11:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488672.756942; Thu, 02 Feb 2023 11:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSP-0005ng-VS; Thu, 02 Feb 2023 11:08:45 +0000 Received: by outflank-mailman (input) for mailman id 488672; Thu, 02 Feb 2023 11:08:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXSN-0002sX-UL for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:08:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id f364e0bf-a2e9-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 12:08:41 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 168111424; Thu, 2 Feb 2023 03:09:23 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB6483F64C; Thu, 2 Feb 2023 03:08:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f364e0bf-a2e9-11ed-b63b-5f92e7d2e73a From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross Subject: [PATCH 09/10] xen/tools: add sve parameter in XL configuration Date: Thu, 2 Feb 2023 11:08:15 +0000 Message-Id: <20230202110816.1252419-10-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202110816.1252419-1-luca.fancellu@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add sve parameter in XL configuration to allow guests to use SVE feature. Signed-off-by: Luca Fancellu --- Changes from RFC: - changed libxl_types.idl sve field to uint16 - now toolstack uses info from physinfo to check against the sve XL value - Changed documentation --- docs/man/xl.cfg.5.pod.in | 11 +++++++++++ tools/golang/xenlight/helpers.gen.go | 2 ++ tools/golang/xenlight/types.gen.go | 1 + tools/include/libxl.h | 5 +++++ tools/libs/light/libxl_arm.c | 2 ++ tools/libs/light/libxl_types.idl | 1 + tools/xl/xl_parse.c | 22 ++++++++++++++++++++-- 7 files changed, 42 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 024bceeb61b2..bb138322e290 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -2903,6 +2903,17 @@ Currently, only the "sbsa_uart" model is supported for ARM. =back +=item B + +To enable SVE, user must specify a number different from zero, maximum 2048 and +multiple of 128. That value will be the maximum number of SVE registers bits +that the hypervisor will impose to this guest. If the platform has a lower +supported bits value, then the domain creation will fail. +A value equal to zero is the default and it means this guest is not allowed to +use SVE. + +=back + =head3 x86 =over 4 diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index 0e2c1b3acc74..a58b5f1ea268 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1117,6 +1117,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} x.ArchArm.GicVersion = GicVersion(xc.arch_arm.gic_version) x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) +x.ArchArm.Sve = int(xc.arch_arm.sve) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } @@ -1602,6 +1603,7 @@ default: return fmt.Errorf("invalid union key '%v'", x.Type)} xc.arch_arm.gic_version = C.libxl_gic_version(x.ArchArm.GicVersion) xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) +xc.arch_arm.sve = C.int(x.Sve) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index d4b67c97bb54..f1ba391d2d3e 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -537,6 +537,7 @@ TypeUnion DomainBuildInfoTypeUnion ArchArm struct { GicVersion GicVersion Vuart VuartType +Sve uint32 } ArchX86 struct { MsrRelaxed Defbool diff --git a/tools/include/libxl.h b/tools/include/libxl.h index ce2997486953..6385db38bf8c 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -278,6 +278,11 @@ */ #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1 +/* + * libxl_domain_build_info has the arch_arm.sve field. + */ +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SVE 1 + /* * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing * 'soft reset' for domains and there is 'soft_reset' shutdown reason diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..31f30e054bf4 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -211,6 +211,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + config->arch.sve_vl_bits = d_config->b_info.arch_arm.sve; + return 0; } diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 5bd44b37c74d..29a1c86ce3b5 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -663,6 +663,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), + ("sve", uint16), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ])), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 853e9f357a1a..25af5d5dfafb 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1316,8 +1316,6 @@ void parse_config_data(const char *config_source, exit(EXIT_FAILURE); } - libxl_physinfo_dispose(&physinfo); - config= xlu_cfg_init(stderr, config_source); if (!config) { fprintf(stderr, "Failed to allocate for configuration\n"); @@ -2828,6 +2826,26 @@ skip_usbdev: } } + if (!xlu_cfg_get_long (config, "sve", &l, 0)) { + if (!physinfo.cap_arm_sve) { + fprintf(stderr, "SVE is not supported by the platform\n"); + exit(-ERROR_FAIL); + } else if (((l % 128) != 0) || (l > 2048)) { + fprintf(stderr, + "Invalid sve value: %ld. Needs to be <= 2048 and multiple" + " of 128\n", l); + exit(-ERROR_FAIL); + } else if (l > physinfo.arm_sve_vl_bits) { + fprintf(stderr, + "Invalid sve value: %ld. Platform supports up to %u bits\n", + l, physinfo.arm_sve_vl_bits); + exit(-ERROR_FAIL); + } + b_info->arch_arm.sve = l; + } + + libxl_physinfo_dispose(&physinfo); + parse_vkb_list(config, d_config); d_config->virtios = NULL; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488694.756955 (Exim 4.92) (envelope-from ) id 1pNXVa-0001Xd-63; Thu, 02 Feb 2023 11:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488694.756955; Thu, 02 Feb 2023 11:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXVa-0001XW-1b; Thu, 02 Feb 2023 11:12:02 +0000 Received: by outflank-mailman (input) for mailman id 488694; Thu, 02 Feb 2023 11:12:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXVY-0001XQ-Tz for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:12:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXVY-0000Sp-IH; Thu, 02 Feb 2023 11:12:00 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.13.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNXVY-000069-CW; Thu, 02 Feb 2023 11:12:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xi5FAIr9Ftd8CPC1i9gpjjh2DeZ5R57YdiAxh3bAKbg=; b=oTVjY0WVygZ0Lt2Js2NSlR4Mc3 V4Zb3kxsaeb9uRkDWSu4G+tBm3R9ZeXH2x7BecjYD82/bVCW9iBV6ABBlLWWTudxNk1YDmmkV4505 OSlMvFxrwODt37WzxBeL6DeQ5AETND2JBDrHW2CmTmHKgomXdgbDi7fS8IP0OabyqX+0=; Message-ID: <814100fd-5624-7d67-764d-dc6f0f493af9@xen.org> Date: Thu, 2 Feb 2023 11:11:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-14-Penny.Zheng@arm.com> <23f49916-dd2a-a956-1e6b-6dbb41a8817b@xen.org> <33bddc11-ae1e-b467-32d7-647748d1c627@xen.org> <49329992-3203-78a7-fc61-d6494e37705c@xen.org> <14f9c89a-6eea-204e-cd1b-6bc1cca99716@xen.org> <6e96eaa7-a8a3-eaf3-ca44-3432c88e71d1@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 02/02/2023 08:05, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Thursday, February 2, 2023 3:27 AM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified function >> setup_early_uart to map early UART >> >> >> >> On 01/02/2023 05:36, Penny Zheng wrote: >>> Hi Julien >> >> Hi Penny, >> > > Hi Julien, > >>> > [...] >>>>> xen_mpumap[3] : Xen read-write data >>>>> xen_mpumap[4] : Xen BSS >>>>> xen_mpumap[5] : Xen static heap >>>>> xen_mpumap[6] : Guest memory section >>>> >>>> Why do you need to map the "Guest memory section" for the idle vCPU? >>>> >>> >>> Hmmm, "Guest memory section" here refers to *ALL* guest RAM address >> range with only EL2 read/write access. >> >> For what purpose? Earlier, you said you had a setup with a limited number >> of MPU entries. So it may not be possible to map all the guests RAM. >> > > The "Guest memory section" I referred here is the memory section defined in my new > introducing device tree property, "mpu,guest-memory-section = <...>". It will include > "ALL" guest memory. > > Let me find an example to illustrate why I introduced it and how it shall work: > In MPU system, all guest RAM *MUST* be statically configured through "xen,static-mem" under domain node. > We found that with more and more guests in, the scattering of "xen,static-mem" may > exhaust MPU regions very quickly. TBH, at that time, I didn't figure out that I could map/unmap on demand. > And in MMU system, We will never encounter this issue, setup_directmap_mappings will map the whole system > RAM to the directmap area for Xen to access in EL2. > So instead, "mpu,guest-memory-section" is introduced to limit the scattering and map in advance, we enforce > users to ensure all guest RAM(through "xen,static-mem") must be included within "mpu,guest-memory-section". > e.g. > mpu,guest-memory-section = <0x0 0x20000000 0x0 0x40000000>; > DomU1: > xen,static-mem = <0x0 0x40000000 0x0 0x20000000>; > DomU2: > xen,static-mem = <0x0 0x20000000 0x0 0x20000000>; > >> Xen should only need to access the guest memory in hypercalls and >> scrubbing. In both cases you could map/unmap on demand. >> > > thanks for the explanation. > In my understanding, during boot-up, there are two spots where Xen may touch the guest memory: > one is that doing synchronous scrubbing in function unprepare_staticmem_pages. > Another is coping and pasting kernel image to guest memory. > In both cases, we could map/unmap on demand. > And if you think map/unmap on demand is better than "mpu,guest-memory-section", I'll try to fix it in next serie I think it would be better for a few reasons: 1) You are making the assumption that all the RAM for the guests are contiguous. This may not be true for various reason (i.e. split bank...). 2) It reduces the amount of work for the integrator 3) You increase the defense in the hypervisor but it is more difficult to access the guest memory if there is a breakage I don't expect major rework because you could plug the update to the MPU in map_domain_page(). >> I have looked at the code and this doesn't entirely answer my question. >> So let me provide an example. >> >> Xen can print to the serial console at any time. So Xen should be able to >> access the physical UART even when it has context switched to the guest >> vCPU. >> > > I understand your concern on "device memory section" with your > Example here. True, the current implementation is buggy. > > Yes, if vpl011 is not enabled in guest and we instead passthrough a UART to > guest, in current design, Xen is not able to access the physical UART on guest mode. So all the guests are using the same UART? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:12:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:12:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488697.756966 (Exim 4.92) (envelope-from ) id 1pNXVq-0001xh-IE; Thu, 02 Feb 2023 11:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488697.756966; Thu, 02 Feb 2023 11:12:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXVq-0001xY-D9; Thu, 02 Feb 2023 11:12:18 +0000 Received: by outflank-mailman (input) for mailman id 488697; Thu, 02 Feb 2023 11:12:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXVo-0001vc-Oc for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:12:17 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20624.outbound.protection.outlook.com [2a01:111:f400:7eaa::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 721e1f12-a2ea-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:12:14 +0100 (CET) Received: from BN8PR15CA0056.namprd15.prod.outlook.com (2603:10b6:408:80::33) by CH0PR12MB5218.namprd12.prod.outlook.com (2603:10b6:610:d1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 11:12:12 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:80:cafe::ce) by BN8PR15CA0056.outlook.office365.com (2603:10b6:408:80::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 11:12:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 11:12:12 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 05:12:12 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 05:12:10 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 721e1f12-a2ea-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhTMi5YTZZPnRDDb9CFv5S/T5HkXiFknjQeZKtRA+I4lkQG/dtTuSTdGczb58NtleOJvWJm/EoXYgdU0iZqqWkk1KhPG/BhEs8U2yS/dQu1rBTMc2uInsMkbOvcpgVpG2PFiy78xcASGDkAWV0MWMACyZgGtdUW/Ls9oUtUX3amatsbpxOz01GgP8NmxZjEiztfprKI8Z+o8SbrekMIyXTkcGlxq4giglW8QnXzCbwiZ+OPXPsigNqkg4UrWzTFBQokBsm09LGUk7u1EyeD1JG/7lat44l6JBfDbv6HUcYjBVF/lL745pstb8SmYv/zdghliSB0xy1EF0HUfZmHiJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BOOdZC2Gys58TDEiEBfUnSIl8yoQUjGHUk8cDgdbzVQ=; b=Y/DWlRiGct0VcyqKaJKL8eNPQfewKe1PHk98HEHwfc/46hPhbmoS/4NFFitu/URwFuX/wk50mZUe1LO7rWySaKBQy1spYqiCgxCZpbtVT6Hfvy87XmtyYatDZ9Tw4yDAdX0jYFze8M0JkZymT1daDbW5Q1OYXlS05HRLemSenuHz7UBF3fDsFRBpMFjEDSmg+slYeYUa4VttLTQpSuVmt+NHLJZon1RBHjAJSIFywscs/JLwJe2WXQrKZxEPhKjoQtY3MKwUvn6wrvkC1JctFru8ktXFjA6gQXZYgQoSAjY09uw2e3GmH6m1swsrgVs5L4KzhDIxIKWJVcpT+6lNqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BOOdZC2Gys58TDEiEBfUnSIl8yoQUjGHUk8cDgdbzVQ=; b=gjjTDTA98daZ/YVez2aGaKS+Dhng9YQ6C7ChFiPwqx5EcgOgaGIc9Sg5F7aqbbF0qO4p2XRwTLbvYjcY+IWRDP/CtW6ILnZf3DMhtfoZ7igeYAV7eFoz4yl1HLKmSEEaOdhXrAUC4mttwo893PBAC9V/mP0zRooxd98qw7TYPeQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 2 Feb 2023 12:12:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230202084905.6950-1-michal.orzel@amd.com> <20230202084905.6950-3-michal.orzel@amd.com> <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> From: Michal Orzel In-Reply-To: <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT052:EE_|CH0PR12MB5218:EE_ X-MS-Office365-Filtering-Correlation-Id: 914353b0-b120-4cc7-0f76-08db050e5581 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD9hjCGuY/g44DHVHhM0x5KS1nTr1urAAac9z2NTakcEVDw/WttbHCdWg++8M58FNAbvAxK/wrlxlMhHxgTlTNFRtYRJ92ajO6lLFZRVhf8OJgoV3CvgP3pYYC9PgzH4vnyOOPORh863H5MfAAdHfY+2aas/vYZfETwDrOhxWa/3QgItWG88MDhsbbU9Z/VMLtSNLDVEqXgxpVfJ+7PnCtRguQyYr2yW0W8Ah5suMuG+wgyvMfy0c0shR1DJCBdPlgfW4cR9jFDSwgClT8EHPzX4h4UsmPmprSZuvAUnIzS+/ptGRBWIaAR168ZIeJU7l/YEGaeiEZNLot0Y/zMKE1ugEi89I28fHzJM1fAR7/ZfkOECTSBwBasuD5JsrhRPQRqXoaGnox3XksfYejXnBXYaM8Q4i5WaLl75kEVwCFqBTprS8AoJw2x9qYKrP6OmB47PTuv+9780I9ZMXv6XGPtL6JA6obnMQOd79s72R6yslmbF7dmqdQ2waG2QFd78HO3aNfEAFtlOMvffmuQxlSy4EVFQeXI8/zXM/9EJ3Ws2nkYSttmdh575xxy3ZcTO6TZi6Ls848DtNX2ytScndW2wyk5AaYb+IerJbXzZNt+geaKGAsfixvy8s5tr9v7zN7Rr1jN60GRbZ68EtPasAWQe2zJVs+6ttufubtjhkyI5E09H5tUlDZdhN/wG16KcyCQy82DJ5qbUGnMbdsiEnH7c8+4Q2nD/F8qai4Sebq+BcVSLwsF39966GjHT6D3mNftm53cjZNE4Q2GwDkd2tQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(31686004)(47076005)(26005)(31696002)(82310400005)(86362001)(478600001)(2616005)(186003)(336012)(40460700003)(4326008)(70206006)(41300700001)(70586007)(44832011)(36860700001)(8936002)(82740400003)(53546011)(426003)(36756003)(40480700001)(8676002)(316002)(356005)(2906002)(16576012)(81166007)(110136005)(54906003)(5660300002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 11:12:12.4790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 914353b0-b120-4cc7-0f76-08db050e5581 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5218 Hi Julien, On 02/02/2023 12:01, Julien Grall wrote: > > > Hi Michal, > > On 02/02/2023 08:49, Michal Orzel wrote: >> @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >> #define IH_ARCH_ARM 2 /* ARM */ >> #define IH_ARCH_ARM64 22 /* ARM64 */ >> >> +/* uImage Compression Types */ >> +#define IH_COMP_GZIP 1 >> + >> /* >> * Check if the image is a uImage and setup kernel_info >> */ >> static int __init kernel_uimage_probe(struct kernel_info *info, >> - paddr_t addr, paddr_t size) >> + struct bootmodule *mod) >> { >> struct { >> __be32 magic; /* Image Header Magic Number */ >> @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >> } uimage; >> >> uint32_t len; >> + paddr_t addr = mod->start; >> + paddr_t size = mod->size; >> >> if ( size < sizeof(uimage) ) >> return -EINVAL; > > Shouldn't we return -ENOENT here? Frankly speaking, I do not want to fall through in such a case. If a kernel size is less than 64B, something is wrong, isn't it? I am not sure if Xen would handle a kernel whose size is less than a page. I do not like the whole falling through in kernel_probe even in case of obvious violations. But this is something not related to this series so I added to my TODO to properly handle the return types from kernel_probe path. If you really think, we should return -ENOENT here, then ok (although I do not like it). Could this be done on commit if you insist on that? > > The rest look good to me. Thanks, > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:23:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:23:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488748.756977 (Exim 4.92) (envelope-from ) id 1pNXgf-0004CQ-Fk; Thu, 02 Feb 2023 11:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488748.756977; Thu, 02 Feb 2023 11:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXgf-0004CJ-Cq; Thu, 02 Feb 2023 11:23:29 +0000 Received: by outflank-mailman (input) for mailman id 488748; Thu, 02 Feb 2023 11:23:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXge-0004CD-41 for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:23:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXgd-0000po-L8; Thu, 02 Feb 2023 11:23:27 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=[192.168.13.48]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNXgd-0000Vt-FR; Thu, 02 Feb 2023 11:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=x/EtjnLXPMVGOEp5mtmu9HbFmS/ExaZ1FcZQ0QFbics=; b=W1OVWcPb9l+azIY8WynzO2Xr7U GVAygdQ9FM90Af2Or2UXkPuNig6uqvURU8dmLlvlmCgnQnkMgmGLDNMvwA1DbkGqX0pET33ve39BM KloEsp4kzKOVT6qgIojEit41Jf+/zEf1MHgI7QHmeQFxahtVyG6JEemFAzmw7mZY9Y9Q=; Message-ID: Date: Thu, 2 Feb 2023 11:23:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230202084905.6950-1-michal.orzel@amd.com> <20230202084905.6950-3-michal.orzel@amd.com> <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2023 11:12, Michal Orzel wrote: > Hi Julien, Hi Michal, > > On 02/02/2023 12:01, Julien Grall wrote: >> >> >> Hi Michal, >> >> On 02/02/2023 08:49, Michal Orzel wrote: >>> @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >>> #define IH_ARCH_ARM 2 /* ARM */ >>> #define IH_ARCH_ARM64 22 /* ARM64 */ >>> >>> +/* uImage Compression Types */ >>> +#define IH_COMP_GZIP 1 >>> + >>> /* >>> * Check if the image is a uImage and setup kernel_info >>> */ >>> static int __init kernel_uimage_probe(struct kernel_info *info, >>> - paddr_t addr, paddr_t size) >>> + struct bootmodule *mod) >>> { >>> struct { >>> __be32 magic; /* Image Header Magic Number */ >>> @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>> } uimage; >>> >>> uint32_t len; >>> + paddr_t addr = mod->start; >>> + paddr_t size = mod->size; >>> >>> if ( size < sizeof(uimage) ) >>> return -EINVAL; >> >> Shouldn't we return -ENOENT here? > Frankly speaking, I do not want to fall through in such a case. > If a kernel size is less than 64B, something is wrong, isn't it? I agree something is likely wrong but this should not be the job of kernel_uimage_probe() to enforce this for everyone. To give a concrete example, let's imagine we decide to re-order the call so kernel_uimage_probe() happens *after* an new header A than would require 128 bytes (the number is made up). It would be wrong for A to return -EINVAL because the other protocol may require a smaller size. The same goes here even at least for consistency. So if you really want to enforce a minimum size, then such check should be in the caller. Then each probe could return -ENOENT if the size is too small. > I am not sure if Xen would handle a kernel whose size is less than a page. I don't see any reason why it would not be. > > I do not like the whole falling through in kernel_probe even in case of obvious violations. > But this is something not related to this series so I added to my TODO to properly handle > the return types from kernel_probe path. If you really think, we should return -ENOENT here, > then ok (although I do not like it). Could this be done on commit if you insist on that? See above for an alternative proposal. Depending on the version we settle on I can do it on commit (but this is not going to happen today as OSSTEst is still blocked). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:30:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488753.756988 (Exim 4.92) (envelope-from ) id 1pNXnX-00065X-7C; Thu, 02 Feb 2023 11:30:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488753.756988; Thu, 02 Feb 2023 11:30:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXnX-00065Q-4T; Thu, 02 Feb 2023 11:30:35 +0000 Received: by outflank-mailman (input) for mailman id 488753; Thu, 02 Feb 2023 11:30:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXnV-00065K-Vx for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:30:34 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7e1a::612]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0089cb87-a2ed-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:30:32 +0100 (CET) Received: from DUZPR01CA0087.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::18) by DU0PR08MB7544.eurprd08.prod.outlook.com (2603:10a6:10:316::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 11:30:24 +0000 Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46a:cafe::f7) by DUZPR01CA0087.outlook.office365.com (2603:10a6:10:46a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24 via Frontend Transport; Thu, 2 Feb 2023 11:30:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Thu, 2 Feb 2023 11:30:23 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Thu, 02 Feb 2023 11:30:22 +0000 Received: from 641cd612e235.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1DA986EB-F0FE-4DBF-9054-E6E8D2F16CEA.1; Thu, 02 Feb 2023 11:30:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 641cd612e235.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Feb 2023 11:30:12 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by GV2PR08MB8366.eurprd08.prod.outlook.com (2603:10a6:150:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 11:30:09 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Thu, 2 Feb 2023 11:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0089cb87-a2ed-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81oPDZqnenrFmE/c1UvH/EDyHHSndpEg2rKs9xVhYcs=; b=h1tcbVAVEf7bB2X0r8kLm4bgsMmlynyuzl1DdqxSAYz1tPj9y//Pr2L7VqUrQvr/78qQc2HTqE6YZ1b4sYJqa/53ZTkcvG+w1iw6go+Zxuql1ZXrEZgasFNeXDqjREYRe1+2BJ4XMAvXOls6IFsrQO42TuKIAFvlDfBKfEiHXMU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MRdvzyHZU2uE6hDiLDbm2z4gfqHWB9zm3k5qS6oadCsK9dTGZvQXbGYvZ2RkeEkMCc0aBPNZ45TPZQaVvG7ZIbOvpDufb4AKKJntq4ZHGZ1rAn24ozvHcFsslMO8BOFq7CZmYnqD+WFzXnao64dqzS3pbq1pFjvw5wqn8SpncceyjhyVkSkCWkVFZnEAIN3XRIMoGS2fxkODf9YbwBRNPd+UnnN0Gk7Woy26/H79mtbYPkqZO3bpLMZrjIW3ULkLwXCdBTdBJJscwNoyrFfmKiz4tAItvyRNDFbFDJzygujyjk0+1Ys0XdpZ7w0Wif286aEvQa/PC7qYg00FW6ZyDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81oPDZqnenrFmE/c1UvH/EDyHHSndpEg2rKs9xVhYcs=; b=gar6Qx4aRkK2gFX+EzNcj0UPNIeGSwyNCL944dPk5vfo2ZuA2nJ8X+9KfmM7ESzkiIhfDgTeuOP6ko46zDowztn/tTRxcAUzCj8p57kWRSJurKLurMOusX0vjsC14DgHlM15DKu4Va8SmNCY+/u0AH8qi5fE8US/BHcSiUaZIO1nJdszqBIEPaTDypNLzHVstEUxfqn3xDOlNNfGR0Wb0kxmtrQfVyCxuf38pK+dDuoJ7FBnrICTYHP2KYSCCB2w9cq95rqtHUR8JiNEyrM2YtO4bGEnOg/1+ue+bUdzR+yFhDPZo7BuDalWwqO7jZE6zArEPgdBv66NE76H/bqyvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81oPDZqnenrFmE/c1UvH/EDyHHSndpEg2rKs9xVhYcs=; b=h1tcbVAVEf7bB2X0r8kLm4bgsMmlynyuzl1DdqxSAYz1tPj9y//Pr2L7VqUrQvr/78qQc2HTqE6YZ1b4sYJqa/53ZTkcvG+w1iw6go+Zxuql1ZXrEZgasFNeXDqjREYRe1+2BJ4XMAvXOls6IFsrQO42TuKIAFvlDfBKfEiHXMU= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , "ayan.kumar.halder@xilinx.com" CC: Volodymyr Babchuk Subject: RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Topic: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map Thread-Index: AQHZJxAhTWb1zeTHm029bSgcZo/2Yq6l4H6AgA7nVJCAAFMfgIAAHOxggAGXmACAARsywIAAc7oAgAFRxNCAAN+ggIABBK2AgAAH44CAAAdVIA== Date: Thu, 2 Feb 2023 11:30:08 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-12-Penny.Zheng@arm.com> <7931e70f-3754-363c-28d8-5fde3198d70f@xen.org> <3c915633-ddb8-d1e4-f42e-064aaff168b2@xen.org> <509eafac-bbe7-ed18-ce11-3fede7ca691d@xen.org> <1f360356-b143-e732-5a4a-197ed56b2cd1@xen.org> <83ba0e60-1a3f-f91a-05b3-79ec32ba4caa@xen.org> In-Reply-To: <83ba0e60-1a3f-f91a-05b3-79ec32ba4caa@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7DDC2E287A20F44F848ABE3981F9F1D8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|GV2PR08MB8366:EE_|DBAEUR03FT009:EE_|DU0PR08MB7544:EE_ X-MS-Office365-Filtering-Correlation-Id: c6354f3f-2daa-4d42-0c81-08db0510df8e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: A1BqRfC/WpiRc1mfQjnLwBzUYzisMS0b3ETriD942gUw185Iqc9Pwx4b314ueKJmnGf4aT5itLX+28aKMIO4XjjXgRsEoDeFFNRxfWvkOC/c3z0r62Mzc2KwdDnHXHEySKmDSZAk5O139qn2biNq8YdkyU9yLlQWAm5vc4txB2SrMRXnLXS/QjiBIX4PbJpC29UnQRL6tnsMJHWD3LBAdcuhXIGkhEcTVXBOBZ9G9qejUT7IjlYDlGEPNYftvNbT71Q6JuDsafK4RKrj0HIOBOfhohvtf/v+u7Urt+/EU/+5QPK3zIQXyYDpf2gYzHKFbB1yiwnMLGTPPTfjld60MPrDUcLnfzxiksLWLCSvRo2EoD/gPLR4Pib7Vo8mDw9lwLSxouPauJQ+CawekpOLgpcg+MjZHb7gYN2yd/PFkBpqmeGLmLB9VTETXhOEM6wmbJmqKYhlz/06bxPfdZjuHUDQhsGgoNG/S78SQclE7wFe1iDYaPvLXK2o/iwQ2O1/39OBE7UW3j+WVLWIXm4qUrHw1FERfp+mxIIdu1teURmR8cDgqOb9G4M0y+ihzd3G++QmKD3vfwdbhAdCGAc2t5eeL4pij8dv/JTJ+2XZDhpdgLEA1Y1ip0tnsHZIprKW1fDVLFg9CqqMSfXXkYF6pkve/sW1HfbpOWmQs8a6TrS+KzLqCHqaMCNEEiz5v6s48N7tfph30bUhazW02wqa7A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199018)(8676002)(26005)(6506007)(53546011)(66446008)(9686003)(186003)(64756008)(66476007)(66556008)(4326008)(66946007)(76116006)(71200400001)(83380400001)(2906002)(5660300002)(55016003)(316002)(7696005)(38100700002)(110136005)(122000001)(52536014)(8936002)(86362001)(478600001)(41300700001)(38070700005)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8366 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c684e9ec-3ee6-4c67-eeac-08db0510d71f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l0caGJwa+YoKqw0KlWr+IxUdfNeegEsuYUhgsc1kazLqI8VSw1a41e3hUJ7Wta1+y/AQ9SabXstBvmRhqdeSdocH+UOLB4IcXw6wtcySyFT9M2/H/6XmTlgiZJqzjyeAL23DPJjyNCw6DxPLfrIRh99TBpou2dvnZ07T7FCDS5zXHvg8rhjbqlFuRrQG1hYc4qWWW7zog5P88I4bYE3XT5kC/evrfZAkyZ/tAfj3paCr6OPg2/5BXGvCupgbDiJN61CQwtCEIiq3qV0FKzPI67GQTQc/hdmOAPInlTgIULukMu0X58lgFI+Tnf2EogbF8C0kLT21M25yeuxdyxWwl6Qapf33pdjfva3+9GGd2jtgcEYj2d45kIf8WaZhwi7vBV0cyAFlwHHrzUijzW1amtK4FfCd9qo37zJL5Lu6SodmofyOR8FNmFOzin+7CezhOeFYNPiWOPejL8csi3ySKbiSpJ33vmr97Al9DsMtQ412K1litFaNV91yRX7T+pj61HrO4VWDIzXyU71D9GGTCleUBV9zRV2U5Pwll/rxj7aITm7ID5aT7YnUl2t0foj2UAefNM00UdvO3d15AdPjr6fMryUDog32dQ5utSgZIFthQZfalrR6oE6tFqB/gjB0C0CNYJ7h+VX4G/cmxdE+X1OISuB4Lo5lKmOEvmFKaR1yGcURPHA0ssVUMTzm++JyebOK0i3iZgXEn4SntgkKvg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199018)(46966006)(36840700001)(40470700004)(70586007)(33656002)(70206006)(40460700003)(4326008)(83380400001)(81166007)(316002)(36860700001)(110136005)(82740400003)(82310400005)(53546011)(186003)(26005)(47076005)(5660300002)(9686003)(107886003)(478600001)(40480700001)(41300700001)(6506007)(356005)(8676002)(7696005)(336012)(52536014)(8936002)(55016003)(86362001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 11:30:23.0832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6354f3f-2daa-4d42-0c81-08db0510df8e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7544 SGksIEp1bGllbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IFRodXJzZGF5LCBGZWJydWFyeSAyLCAy MDIzIDY6NTggUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOw0KPiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IGF5YW4ua3VtYXIuaGFs ZGVyQHhpbGlueC5jb20NCj4gQ2M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1 a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxMS80MF0geGVuL21wdTogYnVp bGQgdXAgc3RhcnQtb2YtZGF5IFhlbiBNUFUNCj4gbWVtb3J5IHJlZ2lvbiBtYXANCj4gDQo+IA0K PiANCj4gT24gMDIvMDIvMjAyMyAxMDo1MywgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVs aWVuLA0KPiANCj4gSGksDQo+IA0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiA+PiBTZW50OiBUaHVyc2Rh eSwgRmVicnVhcnkgMiwgMjAyMyAyOjU3IEFNDQo+ID4+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnku WmhlbmdAYXJtLmNvbT47DQo+ID4+IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+Ow0KPiBTdGVmYW5vDQo+ID4+IFN0YWJlbGxpbmkgPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4+IDxCZXJ0cmFuZC5N YXJxdWlzQGFybS5jb20+OyBheWFuLmt1bWFyLmhhbGRlckB4aWxpbnguY29tDQo+ID4+IENjOiBW b2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+DQo+ID4+IFN1Ympl Y3Q6IFJlOiBbUEFUQ0ggdjIgMTEvNDBdIHhlbi9tcHU6IGJ1aWxkIHVwIHN0YXJ0LW9mLWRheSBY ZW4gTVBVDQo+ID4+IG1lbW9yeSByZWdpb24gbWFwDQo+ID4+DQo+ID4+IEhpIFBlbm55LA0KPiA+ Pg0KPiA+PiBPbiAwMS8wMi8yMDIzIDA1OjM5LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPj4+Pj4g SWYgd2UgYXJlIGFkZGluZyBNUFUgcmVnaW9ucyBpbiBzZXF1ZW5jZSBhcyB5b3Ugc3VnZ2VzdGVk LCB3aGlsZQ0KPiA+Pj4+PiB1c2luZyBiaXRtYXAgYXQgdGhlIHNhbWUgdGltZSB0byByZWNvcmQg dXNlZCBlbnRyeS4NCj4gPj4+Pj4gVEJILCB0aGlzIGlzIGhvdyBJIGRlc2lnbmVkIGF0IHRoZSB2 ZXJ5IGJlZ2lubmluZyBpbnRlcm5hbGx5LiBXZQ0KPiA+Pj4+PiBmb3VuZCB0aGF0IGlmIHdlIGRv bid0IGRvIHJlb3JnIGxhdGUtYm9vdCB0byBrZWVwIGZpeGVkIGluIGZyb250DQo+ID4+Pj4+IGFu ZCBzd2l0Y2hpbmcgb25lcyBhZnRlciwgZWFjaCB0aW1lIHdoZW4gd2UgZG8gdmNwdSBjb250ZXh0 DQo+ID4+Pj4+IHN3aXRjaCwgbm90IG9ubHkgd2UgbmVlZCB0byBodW50IGRvd24gc3dpdGNoaW5n IG9uZXMgdG8gZGlzYWJsZSwNCj4gPj4+Pj4gd2hpbGUgd2UgYWRkIG5ldyBzd2l0Y2gtaW4gcmVn aW9ucywgdXNpbmcgYml0bWFwIHRvIGZpbmQgZnJlZQ0KPiA+Pj4+PiBlbnRyeSBpcyBzYXlpbmcg dGhhdCB0aGUNCj4gPj4+PiBwcm9jZXNzIGlzIHVucHJlZGljdGFibGUuIFVuY2VydGFpbnR5IGlz IHdoYXQgd2Ugd2FudCB0byBhdm9pZCBpbg0KPiA+Pj4+IEFybXY4LVIgYXJjaGl0ZWN0dXJlLg0K PiA+Pj4+DQo+ID4+Pj4gSSBkb24ndCB1bmRlcnN0YW5kIHdoeSBpdCB3b3VsZCBiZSB1bnByZWRp Y3RhYmxlLiBGb3IgYSBnaXZlbg0KPiA+Pj4+IGNvbWJpbmF0aW9uIG9mIHBsYXRmb3JtL2Rldmlj ZS10cmVlLCB0aGUgYml0bWFwIHdpbGwgYWx3YXlzIGxvb2sNCj4gPj4+PiB0aGUgc2FtZS4gU28g dGhlIG51bWJlciBvZiBjeWNsZXMvaW5zdHJ1Y3Rpb25zIHdpbGwgYWx3YXlzIGJlIHRoZQ0KPiBz YW1lLg0KPiA+Pj4+DQo+ID4+Pg0KPiA+Pj4gSW4gYm9vdC10aW1lLCBpdCB3aWxsIGJlIGFsd2F5 cyB0aGUgc2FtZS4gQnV0IGlmIHdlIHN0aWxsIHVzZSBiaXRtYXANCj4gPj4+IHRvIGZpbmQgZnJl ZSBlbnRyeShmb3Igc3dpdGNoaW5nIE1QVSByZWdpb25zKSBvbiBydW50aW1lLCBobW1tLCBJDQo+ ID4+PiB0aG91Z2h0IHRoaXMgcGFydCB3aWxsIGJlIHVucHJlZGljdGFibGUuDQo+ID4+DQo+ID4+ IEkga25vdyB0aGlzIHBvaW50IGlzIG5vdyBtb290IGFzIHdlIGFncmVlZCBvbiBub3QgdXNpbmcg YSBiaXRtYXAgYnV0DQo+ID4+IEkgd2FudGVkIHRvIGFuc3dlciBvbiB0aGUgdW5wcmVkaWN0YWJp bGl0eSBwYXJ0Lg0KPiA+Pg0KPiA+PiBJdCBkZXBlbmRzIG9uIHdoZXRoZXIgeW91IGRlY2lkZSB0 byBhbGxvY2F0ZSBtb3JlIGVudHJ5IGF0IHJ1bnRpbWUuDQo+ID4+IE15IGFzc3VtcHRpb24gaXMg eW91IHdvbid0IGFuZCB0aGVyZWZvcmUgdGhlIHRoZSB0aW1lIHRvIHdhbGsgdGhlDQo+ID4+IGJp dG1hcCB3aWxsIGFsd2F5cyBiZSBjb25zaXN0ZW50Lg0KPiA+Pg0KPiA+DQo+ID4gSW4gTVBVLCB3 ZSBkb24ndCBoYXZlIHNvbWV0aGluZyBsaWtlIHZ0dGJyX2VsMiBpbiBNTVUsIHRvIHN0b3JlIHN0 YWdlDQo+ID4gMg0KPiA+IEVMMS9FTDAgdHJhbnNsYXRpb24gdGFibGUuIFhlbiBzdGFnZSAxIEVM MiBtYXBwaW5nIGFuZCBzdGFnZSAyIEVMMS9FTDANCj4gPiBtYXBwaW5nIGFyZSBib3RoIHNoYXJp bmcgb25lIHRhYmxlLg0KPiA+IFNvIHdoZW4gY29udGV4dCBzd2l0Y2hpbmcgaW50byBkaWZmZXJl bnQgZ3Vlc3QsIHRoZSBjdXJyZW50IGRlc2lnbiBpcw0KPiA+IHRvIGRpc2FibGUgRE9NMSdzIGd1 ZXN0IFJBTSBtYXBwaW5nIGZpcnN0bHksIHRoZW4gZW5hYmxlIERPTTIncyBndWVzdA0KPiA+IFJB TSBtYXBwaW5nLCB0byBlbnN1cmUgaXNvbGF0aW9uIGFuZCBzYWZldHkuDQo+IA0KPiBJIHVuZGVy c3Rvb2QgdGhhdCBidXQgSSBkb24ndCB1bmRlcnN0YW5kIGhvdyB0aGlzIGlzIHJlbGF0ZWQgdG8g bXkgcG9pbnQNCj4gaGVyZS4gVGhlIGVudHJpZXMgeW91IGFyZSByZXBsYWNpbmcgYXJlIGFsd2F5 cyBnb2luZyB0byBiZSB0aGUgc2FtZSBhZnRlcg0KPiBib290Lg0KPiANCj4gU28gaWYgeW91IGhh dmUgYSBiaXRtYXAgaW5kaWNhdGUgdGhlIGZpeGVkIGVudHJpZXMgYW5kIHlvdSBkb24ndCBhZGQg bW9yZQ0KPiBmaXhlZCBvbmUgYXQgcnVudGltZSwgdGhlbiBpdCB3aWxsIGFsd2F5cyB0YWtlIHRo ZSBzYW1lIHRpbWUgdG8gd2FsayBpdC4NCj4gDQoNCkFoLCBzb3JyeSBmb3IgdGFraW5nIHNvIGxv bmcgdG8gdW5kZXJzdGFuZCA7Ly4gVHJ1ZSwgdGhlIGZpeGVkIGVudHJpZXMgd2lsbCBuZXZlcg0K Y2hhbmdlIGFmdGVyIGJvb3QtdGltZSwgZWFjaCB0aW1lIHdoZW4gc3dpdGNoaW5nIHRvIGd1ZXN0 IHZjcHUsIHdlIGFsd2F5cyBjaG9vc2UNCnRoZSBzYW1lIGVudHJ5Lg0KDQo+IENoZWVycywNCj4g DQo+IC0tDQo+IEp1bGllbiBHcmFsbA0KDQpDaGVlcnMsDQoNCi0tDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:36:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:36:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488762.756999 (Exim 4.92) (envelope-from ) id 1pNXt8-0007CU-13; Thu, 02 Feb 2023 11:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488762.756999; Thu, 02 Feb 2023 11:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXt7-0007CN-Ub; Thu, 02 Feb 2023 11:36:21 +0000 Received: by outflank-mailman (input) for mailman id 488762; Thu, 02 Feb 2023 11:36:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNXt6-0007CH-NG for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:36:20 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20608.outbound.protection.outlook.com [2a01:111:f400:fe59::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc4b33b6-a2ed-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 12:36:14 +0100 (CET) Received: from DM6PR04CA0021.namprd04.prod.outlook.com (2603:10b6:5:334::26) by DM6PR12MB4330.namprd12.prod.outlook.com (2603:10b6:5:21d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 11:36:11 +0000 Received: from DM6NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:5:334:cafe::3a) by DM6PR04CA0021.outlook.office365.com (2603:10b6:5:334::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 11:36:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT027.mail.protection.outlook.com (10.13.172.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.25 via Frontend Transport; Thu, 2 Feb 2023 11:36:11 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 05:36:10 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 2 Feb 2023 03:36:10 -0800 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Thu, 2 Feb 2023 05:36:09 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc4b33b6-a2ed-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IesUDQu8yBkMglXG9eGxZpQfTktYe7RsB45Zy4e5IvdXbikwCuMXvnxpiH9CBYwES8FGU+woFAsQou/AKsoTEOz0E7+byezZnPtKAiIMQTMSKARbqkOTy0NDP6UKl2K2FUvv/abRvrI+ZaRqzhhEBXrUMsrooTQ65akPCcHkbyzcS0cp9yAZudEd1/6oKvEdlHpCQNnamQf3mwtxtIYBBqwEIDuca3/6SaK1vN+D3Jnry4wPBeqjV2UlgMpLLqp2yX1ivf2tlhCAzqt1gDNQKEqKRG9CJ2/mz6t+fj5PqR63TYGe8pYRAbNdLhIlQNpC1vdt/6dtzW9nMGDUB6GeDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVmF857VLxY7+N9tbF7LRK02QVtYsE24P1F2f4HL7P4=; b=HcRM9IC6RYm9SChHtc7s2CtzMCJ61amNnfT2oa/GpaisPn0YfxV2r48piLk35fkzFDtKZyqFRbcXVZWOfLhjfTmK4B4dGkEFWsAGJ6BeVDb56AUBxW51/l29DREtOl2fLjLtb2Wv4EKlrT+C0WzBh/M7Q+IcgY8xlb3sW+Bf6abU2iSmxdUw3yMOVdJYXfPnO1AYsxnJ/pwDqg18vcIaIhyduSOkgxF88yHLfEpMcTAh62UWoxujm+5lDTv3bvfpxH97qADB4yJGTJ0Smmf9Rs8r5qYlPsLEqlTcfBQ2qCPdmeHe3EtB+YUm80f4RsP6KbizPesDgkoI/KVF0Pn3Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVmF857VLxY7+N9tbF7LRK02QVtYsE24P1F2f4HL7P4=; b=c4YH6Oz1sHP2wj5u8ReI3fxQ3htiqUMmIepXIRC1HKOYtSszbyT+4yzvD87M4Y4mPn0veNAUAIoa0byYGGNkXU69+EJK8/lPnGXd0sMs4cWsXf6gskNh/s2ApFoE6aMkh+E9WGWzg34tRyj9r4QRsgYVA3M9EoFOgjPOdEbQ6ys= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 2 Feb 2023 12:36:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Julien Grall , CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , References: <20230202084905.6950-1-michal.orzel@amd.com> <20230202084905.6950-3-michal.orzel@amd.com> <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT027:EE_|DM6PR12MB4330:EE_ X-MS-Office365-Filtering-Correlation-Id: c41bd84f-d210-4eee-415b-08db0511af34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NGDVNA50RuSi8alZD+cxsohB3wTg1p9puxgetTfNyVoFrCb2C1WMDqFMA7KwawD1KE6bW/6HM5O3K5akZCe8V/7Xx3QWNzgYippjut9eEMYBM2nGkwzquejxrrZ05cfF2dfYGanvkoKk787L0O1it/1oCKKZTnoq32mc//3sq7KUG3HQS5ZmcGAw1qpzDKTus+gyqZDbUXANdr6h7Loqk6i3BnKTGZqB+rCchsVxEOudxPCJOvoXr3Vh/JGZapDtL5SZBqmr7dpP7sRtopocrBFr9qCNAZSCmVaqiYhq/vJFLJE5OQoSvyCjPV0IWlFmNry4Qe+55SpS4F3SnHYSd/+EKxjPsnqWu/xYCzWRlaCMTxyUIj0L+tyFb95S7b/t6mrzvhuwiH/XW0gyqwwSMF5GrKVn7unHv9VxW4RTduImYwGeBv2uSVxaVVoJfvT08jJE+dOYCIVmdxgrn1Xzn95deGIMSUAEJKVh27cnQAAThlIwshKr5JYYHbyiDba3fnlq6cqpsCBNS9zhHTvPFhGcM89ok+3YpBz0Y/SQubjlegZM9TCMv+L/uUdLya2Pea21h//0ZrsPPWkzVl6p6k2mg0GwE6CF92R5sr6htVoT+95J9Lq9UNYF50GvyANzv7YQv3HBYvpZtiqDX/vRCxrVdONdruQdouZzIQFvuXdRU/VMNngW2vEqOnEpEhsphPnNMiI++uj9Y7AOZBC+5zoXr19tmWlShQHriSjh9fkRjnhQ2NritB+OlOWkDV/rB/OBKeZAU3o/1DtMS1If5A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(83380400001)(31686004)(82310400005)(426003)(2906002)(336012)(2616005)(81166007)(40460700003)(316002)(44832011)(36860700001)(8936002)(36756003)(26005)(186003)(53546011)(47076005)(5660300002)(82740400003)(31696002)(86362001)(16576012)(40480700001)(110136005)(41300700001)(478600001)(356005)(54906003)(70586007)(70206006)(8676002)(4326008)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 11:36:11.4296 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c41bd84f-d210-4eee-415b-08db0511af34 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4330 Hi Julien, On 02/02/2023 12:23, Julien Grall wrote: > > > On 02/02/2023 11:12, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> >> On 02/02/2023 12:01, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 02/02/2023 08:49, Michal Orzel wrote: >>>> @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >>>> #define IH_ARCH_ARM 2 /* ARM */ >>>> #define IH_ARCH_ARM64 22 /* ARM64 */ >>>> >>>> +/* uImage Compression Types */ >>>> +#define IH_COMP_GZIP 1 >>>> + >>>> /* >>>> * Check if the image is a uImage and setup kernel_info >>>> */ >>>> static int __init kernel_uimage_probe(struct kernel_info *info, >>>> - paddr_t addr, paddr_t size) >>>> + struct bootmodule *mod) >>>> { >>>> struct { >>>> __be32 magic; /* Image Header Magic Number */ >>>> @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>>> } uimage; >>>> >>>> uint32_t len; >>>> + paddr_t addr = mod->start; >>>> + paddr_t size = mod->size; >>>> >>>> if ( size < sizeof(uimage) ) >>>> return -EINVAL; >>> >>> Shouldn't we return -ENOENT here? >> Frankly speaking, I do not want to fall through in such a case. >> If a kernel size is less than 64B, something is wrong, isn't it? > > I agree something is likely wrong but this should not be the job of > kernel_uimage_probe() to enforce this for everyone. > > To give a concrete example, let's imagine we decide to re-order the call > so kernel_uimage_probe() happens *after* an new header A than would > require 128 bytes (the number is made up). > > It would be wrong for A to return -EINVAL because the other protocol may > require a smaller size. The same goes here even at least for consistency. > > So if you really want to enforce a minimum size, then such check should > be in the caller. Then each probe could return -ENOENT if the size is > too small. > >> I am not sure if Xen would handle a kernel whose size is less than a page. > > I don't see any reason why it would not be. > >> >> I do not like the whole falling through in kernel_probe even in case of obvious violations. >> But this is something not related to this series so I added to my TODO to properly handle >> the return types from kernel_probe path. If you really think, we should return -ENOENT here, >> then ok (although I do not like it). Could this be done on commit if you insist on that? > > See above for an alternative proposal. Depending on the version we > settle on I can do it on commit (but this is not going to happen today > as OSSTEst is still blocked). Ok, lets stick to your original suggestion with s/-EINVAL/-ENOENT/ and I will come up with something for a future patch as this will require more changes to make it generic. I also do not like at all the fact that we are not informing the user about the error code when calling panic from construct_{dom0,domU}... > > Cheers, > > -- > Julien Grall ~Michal From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:51:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:51:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488767.757010 (Exim 4.92) (envelope-from ) id 1pNY75-0001Xp-7H; Thu, 02 Feb 2023 11:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488767.757010; Thu, 02 Feb 2023 11:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY75-0001Xi-4Y; Thu, 02 Feb 2023 11:50:47 +0000 Received: by outflank-mailman (input) for mailman id 488767; Thu, 02 Feb 2023 11:50:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY73-0001Xc-Rb for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 11:50:46 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe16::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d2b9a16b-a2ef-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 12:50:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8479.eurprd04.prod.outlook.com (2603:10a6:10:2c5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 11:50:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.024; Thu, 2 Feb 2023 11:50:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2b9a16b-a2ef-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dq/9WdFCw8j+OV9ujHzb21m47feA424DnFN6ULugtF1QAuqCVOhCyYpOUu2EjpLdKc850yImlTpA9FK4EiV83Tf+t8vAVFQseSVf34YpX47cECOrC0E1Y+1I6rjoecl+iTtcWNYclsF4vAh70mWdjjVbK1j+56MkDfwCJk8+wpoYOo7xamGOo45E6ro3YSsmlkFnoC+WO/bB8hUj/2un616rbiiIUefEmfKwyCACjnj5rYVTvpfNHy1RL2LxhNj18of6FDmM6Q343tk/dScoLEUhbJflmFXR4vPJSUY4SVTRdhIRldDTdV2neshYkv/EuHWZcaTUu0oQO5LvpHPghA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ml+veEjEwYmlA5aBnex8Kj6IT16gjIKNEqJmPsjzHYA=; b=jvr60OQov3wI4djmNIfIUI6XoRrceWd+gcOJAEiqLK6VkqXW6ntXG8EamFhK1eYfolDvheP/y3YOOgSWT+b/Z1gFY0vAtXZ7bspghjgRme/LdtcqwYcyF655wuFsLGtmF1/CNAwBSE6Qn1ZxDwAW+OF8epT5wWuF6kuF/26meA4Ive1N0hjcYHV9AFeWrgpCkOgDhNsCJsst2IssQyNtAF8TeHMGssbnq1oPze6i+CmuS4gKHNyb9jYMzFJyudqjSk/GGHEtYQenVg7U37+wdZATQyvgZSJyADaaLeGuZXksY0HK6CIaa14eauQ3nbMkdfVIkF4Tg2W6D65pEtwmcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ml+veEjEwYmlA5aBnex8Kj6IT16gjIKNEqJmPsjzHYA=; b=t85ImZix1Dv2Lq1Bb6xBGHRr0iktD/FT4QmHUdTELzfv3Ov2PofvV5ZVdFAwk3W3KqSnkjAA7GOx0CiYyusSa4UcV4/+NsxdLKZt1HyGEABeEDAnXtgXVRJA+Tknnal5TjFu495fwaCcrdRmX8dbdq1jYNRVWEoRm9TCVogymznfL1n3GI1qcgZG5lnjCcbIwgUmIhCjFcou58jcqm11OxVsBJ11ewALYVL9h4UnjBTENE2oJMR65KCEI22GGPlx4T3g4XPuUoh597OngqB327wZxFkWEU0OHd+J0kJ8sZezk+GJL2yd3qC6x1Ta6uz3RuaiksSw+elyOuKXWUqWBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c649ad7-ddee-8a3f-485b-3e056f1e9c73@suse.com> Date: Thu, 2 Feb 2023 12:50:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii , xen-devel@lists.xenproject.org References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8479:EE_ X-MS-Office365-Filtering-Correlation-Id: f6fbfbca-aaf2-45a5-afa1-08db0513b555 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FWTOmDo3EVC14jLf82xDdIMfkgjWPCAVa3V1fv7F3pOsuPrvQ3xchaJv/hrHpOd63swv07L4RlBQ6NrL0flEKpqeC7jhm8K7KhXdRF6kppyPGTBYVBX+Nuln5rwMFlWSdJ4W2D724T4UWW+l1tH23Zqu4k7k8ABdOs62F0VMw2cfW9Ca2d7b5K1DS4LH03e0O2gCj+k96LLQGFlv5iJ/VFUFm0Zm5UCrEjmBIZf5wn7hgDAkxdPIqvGHdXRz5XcTIAboGrAvVs+YNVwS6v9Q/FfPwlD2wXnIHXJNMQvNbNYtWI3FUDxPgTW25zMDZzSU5Jukj0d3AKgH4a00HatH6aulTriH1JOMO/V6hgG0K3l9ypGSSnDzbUZC6tIpPyn+KWDgJ6tTwJAenVRJARJ3HUHminwhEVqr/7s+doUuRdpTdtIZBdSwzuQN9iSZUNYuox7NNbnkwuuA/BsXq8xjvyQZ6kMNgCir6ssSKYJy+jHG5negr5qE0R6BnQfSXOkOQknDLzizmOdZLA7098YBSIrujMFLfOGtGwY4/0PzWeFemLb6pqy6+0yaLwg1ohHTwiALU+ZGZcifxCf6Xw5aCh+0L4sdrxyujHvnl6b8ijFsTtyEJ2JTx77bGtKWvsvl2XSysgMsNmQS9pHDo+8GefW9Dma4TcvIYOiJsmbvnYXMiUgIJTHWrHtzYF42uKLBs7vts+iF7hy1+K/cOgA5PfxYKMAw6ksLEbrfUded4k8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(366004)(136003)(376002)(39860400002)(451199018)(36756003)(66556008)(66476007)(66946007)(38100700002)(4326008)(83380400001)(8676002)(6916009)(54906003)(316002)(53546011)(478600001)(26005)(186003)(6512007)(6666004)(6506007)(6486002)(5660300002)(86362001)(41300700001)(31696002)(2616005)(8936002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlNaSU9BWjVSSTAyZ21GeUpZV0VTRWpOeXlsTkFDNSs5Wkdra2NLY21Pa2Vr?= =?utf-8?B?bjM3d3RYZ0l4U0k3eHQrTEI2VSt2OHNpZWlvb3M0OWtxS0pDV09nN0xJUFJx?= =?utf-8?B?cVpUR2tubTdWVjY0SGttaEtZMURuQ0RaQVdIK05FR2J6SDlNMlB2VjJRWDgz?= =?utf-8?B?NmtUZ0VXVW85ZG9waDJwNTNGcUtZaHdHQlZaRUlBb252V3Z4T2RjblBkMUVW?= =?utf-8?B?R2dqc240a1Z3MHFZaWV3Q2d5T2xEZXBORk5qdU5jbUpDejR0YWI1MHVCRm5R?= =?utf-8?B?SXpaTlg1M0lpY2dHUHBIRktNa3NMQnl4dzhyYll1N3BuTnFZeG5UbHhNWnU5?= =?utf-8?B?eEJZZDN1TTluVGhNbWpPTDRsL3NHZWptaXIwVDlPQTZWMENZeDNyY2t2ODlw?= =?utf-8?B?YmJwajRXQVNieEFnWUtLdmFBdUZ5aUZCZUtHZ3lTbWxZVnJod1Mxc3VsdEtX?= =?utf-8?B?K0ZJS2NaRHBFRGJSVFpRR1lUc2VWMkF5bG01ZVBjNXh5bFRPWVZsc09ENy96?= =?utf-8?B?NUNybVhXTkY2MXlFMmhQbjMxKzJxc2pFa214TGhPbGljVzlhV0xDbHpVdmtT?= =?utf-8?B?dEtiSmN1MnZTSkYya2VLU0VQQW8zemJ6QVE0dk53TFNxNzhCZHQ0TUIzK1NV?= =?utf-8?B?VmF3bzZldEdZUHB4VGEzRWRmRTJDMytGK0FwaFRzTkptRHkvWnVYcFBiK1Ez?= =?utf-8?B?UnJ1Z0RpQVhURWtNcWpDSlg1bWZKb3RSbmg3dFBkNHRJSjdvak5IUElSbyts?= =?utf-8?B?a0pEUEx1bnNQc3FORWRJdmM0cjlkREttMTZKRE05N3VZTzVKRWdJb0NydS9q?= =?utf-8?B?QVJvdFI1SW9keXlkYXNTWTNOT3hoa0s0VGgxdnZpZlc4cEt3c2dLSGhJSXk1?= =?utf-8?B?SXV5VSt5cDBOM1l1UGhKVlFYT3hRSnAwaWpvQzk2OUJNK0liM2NSN2EzYnFr?= =?utf-8?B?ZEQrUHpRblkyZE1OMDFsUjlWb2VKbWhOOHNIQ2pEd3NKSGRYWFpmczJrU3FS?= =?utf-8?B?eFNSWXN3WkVNZGxoN2Fjc3FRSzQrODAyS1NEb2x6NStQVHNwZDJvOTVRWk1C?= =?utf-8?B?ZUdkeTc5ZER6eElhRlU2WVV1SXEvcUNTRzFRMGNSMVRYdFQ2Q2N4bHZzYlJi?= =?utf-8?B?ODBWdno1WGdkQndxS2hzeGxYTTdBL080dTJsWnd3dWExbmNlTlZ4OWhVb1dm?= =?utf-8?B?Q2NzN0loaHdvRU9HMXVJR3VQMU8vSFFnRk5sMkZZZjYyb0ZiV2VxRzVKTUp3?= =?utf-8?B?N3l1WFRTc0lUbDhSUG0xQmQwVlZyMFBEZ0NBcktmbmtPUnd1MXd1UE1jb2R6?= =?utf-8?B?ak5LWjhaNVlpOXRuYWp4U0dSZmlmaDVRaFJqNW8xVWE5amo4aGVVQTdEV3lG?= =?utf-8?B?TWZnMHNUTUVkOGRLQkI0SU9MZ0x3bXZoL2p4OXhqNy9Ca0xXanIxSEJtNy9K?= =?utf-8?B?VTFMdkZNWGt3dWF0WWx1N052bVp2NFY4TUIyNEo4WDRYeUFPYzVXYjY1ckw1?= =?utf-8?B?bEhEQ0M5NWVPa1lXOGRtd2F2L1JjSWliVHlSSDBpakFnQzRheHNpTDdOaDF4?= =?utf-8?B?bTN3WWVIL0hqdTZqSlMwbng5VVJTLzl2ZEJRK2U5TVUvYnh0VWZOUXdrU204?= =?utf-8?B?TDNUemZ2ZG5iOGlLQjZQNzB4U1RTNXdmK281R1BCek9uZEVkTDhiQ0szQ2Vk?= =?utf-8?B?YWV2UkNPT1N4dHMwVFJvTnVOS0pOTTkrUE9XeGZxV0U2ckVLMExQaVl2Zm9W?= =?utf-8?B?b1ZxWlN3RlBwblh3aWdZUTh1OUpjWjRxK05VOSsyM240QXZqYkpsT1l2bXN4?= =?utf-8?B?Zy8rd096MkJ1RkQwSGg2SE40T2xQNFEyVE1GMkgzZHFZTVdPci9BTkNZWkRO?= =?utf-8?B?cXgxa2xnei9mWkd2Sm0zT3NCNEtHMXZiVjN2UVBMdDdpcDVCOTY2QmNocWxY?= =?utf-8?B?ZzRyakJycndMOGhXV3JxRUFDSFQxSlBoYlN4ekY4ZmdtYWtGaDRHdDdjSzRu?= =?utf-8?B?SjF5UzdVanlKN3ArRVVsK0VrbnA3dW4vbnRGOHRLZmkrUk5NTUNiTTFTY3Zl?= =?utf-8?B?UDAwdTBORGJjKzFVYko5dERQL05oVFgya0FxZlhVY1Z6QnFyYzhPU2VqVjFN?= =?utf-8?Q?pcfLZJplPx5R+nM/jl6GH+vWl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6fbfbca-aaf2-45a5-afa1-08db0513b555 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 11:50:40.9428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dWN17cggRfpWcM+koCFUHryNEb3TqFuxQeCoLd3cZPpXd2gD61ADN0CxR5B2C8ha7D3ksxyR0F7y/00QGNOBQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8479 On 01.02.2023 23:11, Julien Grall wrote: > On 01/02/2023 17:40, Oleksii wrote: >> I wrote the following macros and they have been compiled without any >> errors: >> ..... >> #define _ASM_BUGFRAME_TEXT(second_frame) \ >>     ".Lbug%=: ebreak\n"               \ >>     ".pushsection .bug_frames.%c[bf_type], \"a\", @progbits\n" \ >>     ".p2align 2\n"                                             \ >>     ".Lfrm%=:\n"                                               \ >>     ".long (.Lfrm%=)\n"                                        \ >>     ".long (0x55555555)\n"                                     \ >>     ".long (.Lbug%=)\n"                                        \ >>     ".long (0x55555555)\n"                                     \ >>     ".long %c[bf_line_hi]\n"                                   \ >>     ".long (0x55555555)\n"                                     \ >>     ".long %[bf_line_hi]\n"                                    \ >>     ".long (0x55555555)\n"                                     \ >>     ".long %[bf_line_lo]\n"                                    \ >>     ".long (0x55555555)\n"                                     \ >>     ".long %[bf_ptr]\n"                                        \ >>     ".long (0x55555555)\n"                                     \ >>     ".long (.Lbug%= - .Lfrm%=) + %c[bf_line_hi]\n"             \ >>     ".popsection\n"                                            \ >> >> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg)               \ >>     [bf_type]    "i" (type),                                   \ >>     [bf_ptr]     "i" (ptr),                                    \ >>     [bf_msg]     "i" (msg),                                    \ >>     [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1))  \ >>                       << BUG_DISP_WIDTH),                      \ >>     [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) >> >> #define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ >>     __asm__ __volatile__ ( _ASM_BUGFRAME_TEXT(second_frame)    \ >>                    :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ >> } while (0) >> .... >> >> >> But if add ".long %c[bf_ptr]\n" then the following compilation error >> will occur: [ error: invalid 'asm': invalid use of '%c'. ] >> >> If you look at the dissembler of _bug_frames_... >> ...... >>     80201010:   1010                    addi    a2,sp,32   # .Lfrm%= >>     80201012:   8020                    .2byte  0x8020 >>     80201014:   5555                    li      a0,-11 >>     80201016:   5555                    li      a0,-11 >>     80201018:   3022                    .2byte  0x3022  # .Lbug%= >>     8020101a:   8020                    .2byte  0x8020 >>     8020101c:   5555                    li      a0,-11 >>     8020101e:   5555                    li      a0,-11 >>     80201020:   0000                    unimp          # %c[bf_line_hi] >>     80201022:   0000                    unimp >>     80201024:   5555                    li      a0,-11 >>     80201026:   5555                    li      a0,-11 >>     80201028:   0000                    unimp           # %[bf_line_hi] >>     8020102a:   0000                    unimp >>     8020102c:   5555                    li      a0,-11 >>     8020102e:   5555                    li      a0,-11 >>     80201030:   0000                    unimp           # %[bf_line_lo] >>     80201032:   1600                    addi    s0,sp,800 >>     80201034:   5555                    li      a0,-11 >>     80201036:   5555                    li      a0,-11 >>     80201038:   10b8                    addi    a4,sp,104   # %[bf_ptr] >>     8020103a:   8020                    .2byte  0x8020 >>     8020103c:   5555                    li      a0,-11 >>     8020103e:   5555                    li      a0,-11 >>     80201040:   2012                    .2byte  0x2012   # (.Lbug%= - >> .Lfrm%=) + %c[bf_line_hi] >> ..... >> ... it looks like the error will be generated if the name in %c[name] >> isn't equal to 0. >> >> Another thing I noticed is that %[name] can be used instead of %c[name] >> for RISC-V ( i did a quick check and it works) so it is still possible >> to follow Intel implementation but required a redefinition of >> _ASM_BUGFRAME_TEXT where %c[...] won't be used. All the rest will be >> the same as in x86 implementation: >> ..... >> #define _ASM_BUGFRAME_TEXT(second_frame)               \ >>     ".Lbug%=: ebreak\n"                       \ >>     ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" \ >>     ".p2align 2\n"                                            \ >>     ".Lfrm%=:\n"                                              \ >>     ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n"             \ >>     ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n"           \ >>     ".if " #second_frame "\n"                                 \ >>     ".long 0, %[bf_msg] - .Lfrm%=\n"                          \ >>     ".endif\n"                                                \ >>     ".popsection\n"           \ >> ..... >> >> One thing I would like to ask you is why it's better to follow/use x86 >> implementation instead of ARM? > > IMHO, the x86 version is cleaner. But... > >> It seems that "%c[...]" has the best support only for Intel GCC and >> thereby ARM implementation looks more universal, doesn't it? > > ... you are right, the Arm version is more portable. Although, I do > wonder how GCC managed to have a different behavior between architecture > as I would have expected %c to be a generic implementation. While the implementation is common, the condition when 'c' is legitimate can be customized by arch-specific code. While all code for all of the four architectures does so, perhaps x86'es goes farther with what it permits. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 02 11:51:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 11:51:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488769.757021 (Exim 4.92) (envelope-from ) id 1pNY7W-000208-GB; Thu, 02 Feb 2023 11:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488769.757021; Thu, 02 Feb 2023 11:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY7W-000201-D4; Thu, 02 Feb 2023 11:51:14 +0000 Received: by outflank-mailman (input) for mailman id 488769; Thu, 02 Feb 2023 11:51:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY7U-0001zj-WD; Thu, 02 Feb 2023 11:51:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY7U-0001Sd-Tv; Thu, 02 Feb 2023 11:51:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNY7U-0001Mg-EH; Thu, 02 Feb 2023 11:51:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNY7U-0004Sn-Dk; Thu, 02 Feb 2023 11:51:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kpv2bgIirgMLJUxPtcIrTVMa67M/DSqFWrUCpda7lE8=; b=5lORFc09Q0ekIO78AFkjHA9CeV fkbTh1wXy5NbvPO6IHrQ51X+aVq555waT08aa5kBljH1fpyh/m9l01RB/0urmM0uX7Ev75W7vQNCy HufMhPQmGHkjLw6fz6xivgxyYsLIThuEf69l8WrRlwveYZbSPXeahnQA49+A0qDCOALM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176331: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 11:51:12 +0000 flight 176331 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176331/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 12:06:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 12:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488790.757032 (Exim 4.92) (envelope-from ) id 1pNYLq-0004kM-78; Thu, 02 Feb 2023 12:06:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488790.757032; Thu, 02 Feb 2023 12:06:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNYLq-0004kF-3N; Thu, 02 Feb 2023 12:06:02 +0000 Received: by outflank-mailman (input) for mailman id 488790; Thu, 02 Feb 2023 12:06:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNYLo-0004k9-Ky for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 12:06:00 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe12::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2d3862d-a2f1-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 13:05:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7616.eurprd04.prod.outlook.com (2603:10a6:102:e7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 12:05:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.024; Thu, 2 Feb 2023 12:05:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2d3862d-a2f1-11ed-b63b-5f92e7d2e73a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdDvCT4xAJjvTIsHAPA9sl+VjtIIaQynlCt1DZlUmNMMDViX19pFw1jOv23cFoG3H8pChqYRb00bMBACSsGzriCvyvaQFyEGgVDQ5UEb93RdAlJj8vDRGfbXR8hDFXwPQOhst76d76vBKZi1nLqz+PrjwSiqJUmiALrWSW1SnaSi4DuYeY8EZIoMnU0fnsfUs1S3qKNnV2ENCgkRCxgg6bcZ+9Ypq1OqJ/cDhqtbC+dpnZzARMGA3JYToSfXHYp9NdgV4DIJcQAvyEuSf3TK13ReGm+VzlS9/gtcjBa2rLsMHjbUzHelXD3v9cP7/SJpl0ELiwHiTHI//3zaVq10AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtHsB2GsIBUsPcnfySCFMm62xZmAg6mkNF7ot1sFLCo=; b=K1yPE12nYqsesP/NITffp6unYVKgVTsiMK5ahpG7620AsSLAxCrBuXYPP4sGTUa7tzAYkFmvxEGgbnGtVST0kSaIywGy1qfRVN46YufF8kSnqqcUXsxO/Jb5yoavJuyKMAEirXbur75WRDhmmAHSafxtGywY8DGpU2fD0Vreng7NfRru3MPKniu3UarJDq8LXMIiBct1uPW5SGuuEWdy6+4+LgZGFiUnQODNlpzl2lpQnAnYl2bLDyGBOx7fzk5vr3TqgTaYpw99sDmCj4QOk1NC0/lgf0RQ5bjTcQn4UxHCB05NLfskJDuWvRxANnaN/HLitOxop4bJxs3Tu18wUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtHsB2GsIBUsPcnfySCFMm62xZmAg6mkNF7ot1sFLCo=; b=tZfafhIektJwGbK7ztbwCzkL9QEM7g/t2MGXlV++jblW67IiVPpzcSA/T7ozb+z0K3LrP5V0i4Pw2EKjylHkVBNr9gh/zxqfIJ+RoPL4W/uaGadkk9VJ9WTNMBDyi7o8KRCYOFxwKiWdjsyZNDjvBOfKCPd942ERAMwhxFo51I4j/oYyunB3rROtCAp7pvV+VmBMosEBqt2iB7gw+CebhM1bQnEDD/k05WnGDMchFApdQIOuhUjSUZ2gOjOarReoddOMMv7zxs4Vlpmlw3qPIigdQFhdGTlvMpe+ZkTMPPuHLg9x7VmvpGP8YoAKvKenqZvLpkeFUD9KvxgsQ1GQXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 2 Feb 2023 13:05:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 07/10] xen/physinfo: add arm SVE arch capability and vector length Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230202110816.1252419-1-luca.fancellu@arm.com> <20230202110816.1252419-8-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20230202110816.1252419-8-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7616:EE_ X-MS-Office365-Filtering-Correlation-Id: 91c224a5-317e-42fb-a8be-08db0515d59c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z0R866sjO8mlbLJ9m3bu8qbbWQfhqKK4gao8NglyqVZqsVhM9VRlEoKcCpep0/Fa0oGjzYzT4KDOeBTbj/CwbH3FOMBLtMtNrh5R7/YDmcdmcz/5lRHZMkqXLt01pIkZN+R+xxO1gOJ2YEcua4azo1XSNqZZxps1b+R8H4GjlfxbMiQMrz0IXIDtvy73X5md98xfHWREVC+XSoy6QfTnk5Qh312LkyRtawu5AgE67DDmDeETtWJ4QUp3mH5Edz99zO0r4xiq2bECLr2JqcXZnxbqzwl9Sco4lK7zhF6O51rNdxZUoQ+0dbimCkc3R/0ofNH0gGpF1xA2GqrsEtxxAvmVMcf4Ew06IzivAAGsk+VSTg9Hv6MrHbORD1lusveakUVDVwgO5fcE70y7jdwgnh+3fFKCBxYxSzwPm3i+dR8UEF/v2ZMfHVbidFgsUL5Wvmprfwg/QHPBYHBF3Qqu1/J2tFohIZIKOnbt0HhzyRJXF0UMTg4PIUhDnmv31aLG5scEN9tbOluGaJ8DBgge8vjPQuwBrf76m0Pw6Rfta2/WHFWWYLt8erqtY3BrOC9vgj5mM20UYsEDULJKzw8meAVRUM89K/sAAQUWBvL7oEu5x1xL/wtGce+l4Irro37PLb5BQYjx2cdaAl4TemWHxDUMskGamqjLK+WpTXhB36KO3qfyJpJOZGapmE5Y68dYDuOHgR+TQ450rpZzK23o+loWM+7exls6qw1PRlW7Sho= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199018)(38100700002)(31686004)(36756003)(2906002)(31696002)(41300700001)(6916009)(66476007)(66946007)(4326008)(186003)(8936002)(5660300002)(316002)(54906003)(8676002)(6486002)(86362001)(7416002)(66556008)(478600001)(26005)(6512007)(53546011)(6506007)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUsybEx0RmVnSFVnVDVYSDE2cmpjWnRpYlJwbWpZREQrZEljclVWQjNDaFNu?= =?utf-8?B?QS9odmt0NG1hNVhGeFg4TXQ0NEJ0bHZ0d01oUzEzTE01ZWZUUHFSeEo4c2t0?= =?utf-8?B?c2tlMTVKYmZkR1dTYklwSHFpdjNWVjB0dGp2Z2daeXFaQUU0cXl3RytqdDVL?= =?utf-8?B?VDlRek02UWM3OWQzS1VPVEJSVFcyTlh4NEUwaGlHZ21HMUU4VlBrd2ZldVdE?= =?utf-8?B?UzRiMzFJQUU3UU5YZlpFRmhrU1FNN1Q3bFZKUzhvL2kxMExYYUlTQ3dETmlE?= =?utf-8?B?RTNyODNyRXdVK3JsOERxWmlvWTFROUNya2V5R1FwY21KYlorY25wc2xqWWxY?= =?utf-8?B?NTVSZ2VxK3Nob0RxR3lRQkxLQ2JWNGZVWGJ2QXNSaEZNU3JBbk15cHF5Yk1t?= =?utf-8?B?Yll4RGxrQTRkWU5DWHFkdHdQcmFYc0p2SGdKa2xiRWlDNFpyak9FKzFZSDh1?= =?utf-8?B?VE1xSlFqeG10R29ycFU2UjR6SnJhcGZsN3R5QW8wL1NTYmpOR2RXYVV6NGhK?= =?utf-8?B?bnhEdWZnNlF4T2cyejZCc25JNHB6T09PNkF0c1FBTVoyaHJWaml5V1NSQlBv?= =?utf-8?B?cTBwUTV3TmtzaUNRUk91MTVoeDA0TFJrK0ErOTd6a2xYN1RBR0VqZE04Szg1?= =?utf-8?B?eWpTTnhwMnRIQVAxSllHRm9LWDlMN0tpcUt0N2JNT0FodWdOMG5IOUxCMFht?= =?utf-8?B?M2JpQ1NKenhja3k3cm5OYVdlZUQwc2NRY0FSVlhodTR2OUk1TFdwbUtQaDMv?= =?utf-8?B?OE9ncHpNRlAydjUxTEk2dTVaWWVDWlU4dFMxQmtQa0h6dWNxYnF6c2ZMTFp0?= =?utf-8?B?QUhPT2p0djRvNk5JZFV1ZTVPQUdlc2NmVkJQSk54YWFrM2RqMHczbjd6a1d6?= =?utf-8?B?SVRLSGRjZVNpR3d6Tll6dVY2QWRXWXVlSm5SeVJnallDM21ZS3JhL2lJQTVo?= =?utf-8?B?VmRpREU2TE1YL2xUMXNMME4wVWVPeis2WmtWNlU0ZEVkbmQ3UzdOS1lpQnRi?= =?utf-8?B?d25ZaTNZUXNOb3RlYTJ5YjhaZ2xmdHhpU3JiWVRoaE9Ta1B0VkNuT093NTU5?= =?utf-8?B?RGZuUGxkWmpEK3dreUw5ck51Mi9pcUEyaWh0dmozUzV2UUhmRHFjaEVzQVB4?= =?utf-8?B?OUNFcnBTeXNld2J6WGx1Y3cyMitwRmV0eThHdVVNY1ptQ2cwUWk5cWRNZyt1?= =?utf-8?B?VElmZDRhc0pySEhCQ1QzVzVzMUtsUllCL0ppV1VaL1JZR2xyMWl4NUkreWNy?= =?utf-8?B?akhIQkE1dFF1ZVpuY0FLQUdzL0hqMmF5OXFuVGhMQ3Q4SDRUNDNveWZZTWZw?= =?utf-8?B?QmlPL25wSS8yL3JTRUZhYTJydWhYUmZSd3pvQ0RSNHFUazl0dEIrRjlEWncw?= =?utf-8?B?SFh5NnFxV2F3cUtBMVliakRmR2xIZ3pJaHpWV05pUWhHLzlNREhuSHhJTitP?= =?utf-8?B?T1FiVEptSEJGWnhha1dvV0Noa0FFQmFQa2xaTDRLVE15V3hjMnZiSWo5Z1Jp?= =?utf-8?B?T2I3MHM3QWI1amNudklqZERCVWhndEhTWGplZWlwbzg4RnRBRnM0L050U21O?= =?utf-8?B?dzNYcFVrMzIrNi93Tzh6QmpiUDIxN3pQRTA0UHk3VFpxZ2JJNklQZGlMT2JM?= =?utf-8?B?ZzhvL2Y4c0g5ZFdkaHJ4MUlXc0x6ZkdDayt5VWxKSjg4SGJzYmlmbWJ1RzlP?= =?utf-8?B?OFRSRk9ISU5XUEZXWmN4R2cvVDEyMGx2ZEhZVjBjb1BlK3EyZDJDT0ljVGhh?= =?utf-8?B?WklDUDdtYW9MRWU0YTdUWWhJMFZWTno0YnpYeFEyMVFkaVh4QWpJbk5xZW5S?= =?utf-8?B?L0d5RG8yNUZjUFp3UGdLdzY1QStFejMxcmdrNmlvNmVDTDZ4ellWVG9WS2pi?= =?utf-8?B?VlpYa3JiTDZyaWZNeERHYkZXM1ZXR05WRSswcjVBZy9TYzllenNWemlyR1Vz?= =?utf-8?B?L2pRU0pORENGM3dock5HaW1zREtRWklnQmh0TmU0T3VSSzNpUHo2Z0UvbVVI?= =?utf-8?B?Ky9FMFptTDRyWVBIdVd0VGNNdFNKODN1VjRGQzFDTmVtbW8vd1ZNRXJNY0xq?= =?utf-8?B?eEZOeU00ZVIyS2NBbEM0VXd0dkJIdTRHWE9LaUFCMEpvN3loYU41U21NdkxI?= =?utf-8?Q?nS+cXiR1KBXbxXtge7eaMSFvJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91c224a5-317e-42fb-a8be-08db0515d59c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 12:05:54.0729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lsEzL2P16YXRKkHhCzKnEwoJ7I+sM89jZNZbVwL71O7brUoSp0Ju/+snpf5qDc/x6D2Ty09c0gBsnTLjZDZxJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7616 On 02.02.2023 12:08, Luca Fancellu wrote: > When the arm platform supports SVE, advertise the feature by a new > flag for the arch_capabilities in struct xen_sysctl_physinfo and add > a new field "arm_sve_vl_bits" where on arm there can be stored the > maximum SVE vector length in bits. > > Update the padding. > > Bump XEN_SYSCTL_INTERFACE_VERSION for the changes. > > Signed-off-by: Luca Fancellu > --- > Changes from RFC: > - new patch > --- > Here I need an opinion from arm and x86 maintainer, I see there is no arch > specific structure in struct xen_sysctl_physinfo, hw_cap is used only by x86 > and now arch_capabilities and the new arm_sve_vl_bits will be used only by arm. > So how should we proceed here? Shall we create a struct arch for each > architecture and for example move arch_capabilities inside it (renaming to > capabilities) and every arch specific field as well? Counter question: Why don't you use (part of) arch_capabilities (and not just a single bit)? It looks to be entirely unused at present. Vector length being zero would sufficiently indicate absence of the feature without a separate boolean. > (is hw_cap only for x86?) I suppose it is, but I also expect it would better go away than be moved. It doesn't hold a complete set of information, and it has been superseded. Question is (and I think I did raise this before, perhaps in different context) whether Arm wouldn't want to follow x86 in how hardware as well as hypervisor derived / used ones are exposed to the tool stack (XEN_SYSCTL_get_cpu_featureset). I guess there's nothing really precluding that data to consist of more than just boolean fields. > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -18,7 +18,7 @@ > #include "domctl.h" > #include "physdev.h" > > -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015 > +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000016 Why? You ... > @@ -104,7 +110,8 @@ struct xen_sysctl_physinfo { > uint32_t cpu_khz; > uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */ > uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */ > - uint32_t pad; > + uint16_t arm_sve_vl_bits; > + uint16_t pad; > uint64_aligned_t total_pages; > uint64_aligned_t free_pages; > uint64_aligned_t scrub_pages; ... add no new fields, and the only producer of the data zero-fills the struct first thing. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 02 12:39:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 12:39:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488797.757043 (Exim 4.92) (envelope-from ) id 1pNYrL-0000xn-OT; Thu, 02 Feb 2023 12:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488797.757043; Thu, 02 Feb 2023 12:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNYrL-0000xg-L4; Thu, 02 Feb 2023 12:38:35 +0000 Received: by outflank-mailman (input) for mailman id 488797; Thu, 02 Feb 2023 12:38:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNYrJ-0000xa-LL for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 12:38:33 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e9cccc1-a2f6-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 13:38:30 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7AED05C01F8; Thu, 2 Feb 2023 07:38:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 02 Feb 2023 07:38:28 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 07:38:26 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e9cccc1-a2f6-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675341508; x= 1675427908; bh=Nbhfetj4q7Jidpu3nEODg31NIwL6ONjLl92f2Tx9Dac=; b=U D8w4DFKgWjuvd5CiNES2LdbzrrC+l/Seeb7uh+ySiUZ1wivIAkZbpLGPTRDcbQke vP0T+Vq9VTOLp8oXvDvQXQ2rF6bMVIsuBcgIrB13eQs5YXWPebqlCivh7vv/FOW6 LPX+h6yLJCZMFowFvug0QAgDnAfkccuHX+1YoY9VDbZXlMM/x00VLSYANy6XnkEH gqMGnc4Z/aXSxsFLDq7G8bxTYzEpaZMPl4BVUuF3E/SkIQWB9ar5D+x0xzrobgfw hZlRwD8HE1PrVVCk0cNo+Y30SQ9D/86Ny9pq4s6gIFpIYzl6bawty+hORUNC/Eep yuBWk5RBLzyU9ZNQXG+OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675341508; x=1675427908; bh=Nbhfetj4q7Jidpu3nEODg31NIwL6 ONjLl92f2Tx9Dac=; b=kEKsHklBDRdmNPsVStjFTVIWgXhd4AKph7hwrtJlxbNv iTX+uZpYbSON3/aH/B5EudLQGCWIyhjs1/PMI8Gip1kpVJBWFwRHFB7zVC2Yj5Ux FJIGG2oj1/3IGV703dj24eHS5HCtVdU/a9gOQQMvD7FJBgYjRtfpDx+x0SgF3eMC AynRBAVOdECoDq7VRsULeLTMqoHo61iB4XZYRIyWDdhX11ICOiX8Cp7pYJM6pj02 /3GfT6D3WOngQPK37K353bmva0z94f3EJ24AAxtFvhtRlz/ByQF5001NzfzfDnwK a38W8ACdDTd2SldE6neYT3QlhNr4aL6ibXXbCylp0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhephfet udegleeuvdekudfghedufeekuefgffeukeejvdfgkeegtdehhfegueejteelnecuffhomh grihhnpehphihthhhonhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Thu, 2 Feb 2023 13:38:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Luca Fancellu Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott Subject: Re: [PATCH 08/10] tools: add SVE capability and SVE vector length for physinfo Message-ID: References: <20230202110816.1252419-1-luca.fancellu@arm.com> <20230202110816.1252419-9-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BT18ovfx2ox7lBH2" Content-Disposition: inline In-Reply-To: <20230202110816.1252419-9-luca.fancellu@arm.com> --BT18ovfx2ox7lBH2 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 2 Feb 2023 13:38:23 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Luca Fancellu Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Juergen Gross , Christian Lindig , David Scott Subject: Re: [PATCH 08/10] tools: add SVE capability and SVE vector length for physinfo On Thu, Feb 02, 2023 at 11:08:14AM +0000, Luca Fancellu wrote: > Recent changes added in struct xen_sysctl_physinfo a new flag for > arch_capabilities to understand when the platform is SVE capable, > another field having the maximum SVE vector length in bits was > added as well, so update the tools to handle these new fields. >=20 > Signed-off-by: Luca Fancellu > --- > Changes from RFC: > - new patch > --- > This patch is mostly dependent on the decisions we make in the previous, = anyway > I touched some part of the toolstack where my knowledge is limited (ocaml= ) so > I might need a feedback for something I may have done wrong. > --- > tools/golang/xenlight/helpers.gen.go | 4 ++++ > tools/golang/xenlight/types.gen.go | 2 ++ > tools/include/libxl.h | 8 ++++++++ > tools/libs/light/libxl.c | 3 +++ > tools/libs/light/libxl_types.idl | 2 ++ > tools/ocaml/libs/xc/xenctrl.ml | 4 +++- > tools/ocaml/libs/xc/xenctrl.mli | 4 +++- > tools/ocaml/libs/xc/xenctrl_stubs.c | 17 +++++++++++++---- > tools/python/xen/lowlevel/xc/xc.c | 17 +++++++++++++++-- > tools/xl/xl_info.c | 10 ++++++++++ > 10 files changed, 63 insertions(+), 8 deletions(-) For the python part: > diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowleve= l/xc/xc.c > index fd008610329b..516fa57161a6 100644 > --- a/tools/python/xen/lowlevel/xc/xc.c > +++ b/tools/python/xen/lowlevel/xc/xc.c > @@ -870,6 +870,11 @@ static PyObject *pyxc_physinfo(XcObject *self) > const char *virtcap_names[] =3D { "hvm", "pv" }; > const unsigned virtcaps_bits[] =3D { XEN_SYSCTL_PHYSCAP_hvm, > XEN_SYSCTL_PHYSCAP_pv }; > +#if defined(__aarch64__) > + const char py_buildval[] =3D "{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s= :s,s:i}"; > +#else > + const char py_buildval[] =3D "{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s= :s}"; > +#endif I don't like this #if for a different return format depending on the architecture, especially when the underlying structure is in fact the same (just not all fields are used for every arch). It would make adding further fields unnecessarily error-prone. Instead, you can do common stuff with Py_BuildValue and then add architecture-specific stuff with PyDict_SetItemString: https://docs.python.org/3/c-api/dict.html > if ( xc_physinfo(self->xc_handle, &pinfo) !=3D 0 ) > return pyxc_error_to_exception(self->xc_handle); > @@ -893,10 +898,14 @@ static PyObject *pyxc_physinfo(XcObject *self) > for ( i =3D 0; i < ARRAY_SIZE(virtcaps_bits); i++ ) > if ( pinfo.capabilities & virtcaps_bits[i] ) > p +=3D sprintf(p, "%s_directio ", virtcap_names[i]); > +#if defined(__aarch64__) > + if ( pinfo.arch_capabilities & XEN_SYSCTL_PHYSCAP_ARM_sve ) > + p +=3D sprintf(p, "%s ", "arm_sve"); > +#endif > if ( p !=3D virt_caps ) > *(p-1) =3D '\0'; > =20 > - return Py_BuildValue("{s:i,s:i,s:i,s:i,s:l,s:l,s:l,s:i,s:s,s:s}", > + return Py_BuildValue(py_buildval, > "nr_nodes", pinfo.nr_nodes, > "threads_per_core", pinfo.threads_per_core, > "cores_per_socket", pinfo.cores_per_socket, > @@ -906,7 +915,11 @@ static PyObject *pyxc_physinfo(XcObject *self) > "scrub_memory", pages_to_kib(pinfo.scrub= _pages), > "cpu_khz", pinfo.cpu_khz, > "hw_caps", cpu_cap, > - "virt_caps", virt_caps); > + "virt_caps", virt_caps > +#if defined(__aarch64__) > + , "arm_sve_vl_bits", pinfo.arm_sve_vl_bits > +#endif > + ); > } > =20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --BT18ovfx2ox7lBH2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPbrr8ACgkQ24/THMrX 1yzfCwgAmpkAq19Pvn0kVPjPK954zXeSLHlrmqHavsUyhd9gCly+GRdGWJu1Q70o CCm03amB/4peUPWhJIlGvmriQYxfcv4XeLAq8ONBtpCcv6FYjtUALthag0YUEgfx EM1Jg949vBhb59MDXxELvCjs5lMf51NC64Rf2M0KoHpvnKn1DiVvorCilY2Lhwyl MQm/FbXu5aB5emwtHqclCT52FJh2+ml6Q3IRC/Z51PyKmFFdb3bU0Xf3R3lfTGqE dU2TJ1kMJoxJWbIxW/GkFmW7HsdDUNoURFpZWEi7xlJlwzeMSZmYY3KL6gtk4wCc HPEVUY3H6+R7H5NTWtaZL+Npi67AsA== =32B2 -----END PGP SIGNATURE----- --BT18ovfx2ox7lBH2-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 13:02:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 13:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488804.757053 (Exim 4.92) (envelope-from ) id 1pNZEA-00055b-IQ; Thu, 02 Feb 2023 13:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488804.757053; Thu, 02 Feb 2023 13:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZEA-00055U-Fo; Thu, 02 Feb 2023 13:02:10 +0000 Received: by outflank-mailman (input) for mailman id 488804; Thu, 02 Feb 2023 13:02:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZE9-00055K-At; Thu, 02 Feb 2023 13:02:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZE9-00035r-8X; Thu, 02 Feb 2023 13:02:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZE8-0004Tn-TO; Thu, 02 Feb 2023 13:02:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNZE8-0006zS-Ss; Thu, 02 Feb 2023 13:02:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UMUePj0OSorIRcM+jDa+7lbrrPhIyLQRjYq+Tld13Cw=; b=vqFp5c3b3NlL6jHA1IIuxkn17U Sf4tYJb3FR4tBgXCLKB4SRKwog65i+mNIdytE/khiCO0YWLg49AZLppvRJQzelm/MF9U8GFiCWJWG FTheHqvmNuVsLXmrdUxk7Z9a5dO3Dt8RLDa98SvfmqfvDT1dFak5fM+gdnHIyugJlo2c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176328: all pass - PUSHED X-Osstest-Versions-This: ovmf=ae6e470252d9312dce20d0b21e7f622c4ca9ad0a X-Osstest-Versions-That: ovmf=d375273c899bfa279c2732c509caf455af285006 From: osstest service owner Date: Thu, 02 Feb 2023 13:02:08 +0000 flight 176328 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176328/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ae6e470252d9312dce20d0b21e7f622c4ca9ad0a baseline version: ovmf d375273c899bfa279c2732c509caf455af285006 Last test of basis 176323 2023-02-02 02:10:46 Z 0 days Testing same since 176328 2023-02-02 06:12:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeshua Smith Ranbir Singh jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d375273c89..ae6e470252 ae6e470252d9312dce20d0b21e7f622c4ca9ad0a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 02 13:39:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 13:39:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488813.757065 (Exim 4.92) (envelope-from ) id 1pNZo8-0001qM-DI; Thu, 02 Feb 2023 13:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488813.757065; Thu, 02 Feb 2023 13:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZo8-0001qF-9a; Thu, 02 Feb 2023 13:39:20 +0000 Received: by outflank-mailman (input) for mailman id 488813; Thu, 02 Feb 2023 13:39:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZo6-0001q5-KZ; Thu, 02 Feb 2023 13:39:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZo6-0003xB-J1; Thu, 02 Feb 2023 13:39:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNZo6-0006r3-6z; Thu, 02 Feb 2023 13:39:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNZo6-0000rh-6W; Thu, 02 Feb 2023 13:39:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0YJRqTL5xnwTogplKdn6Pu3T4dFHFYsiMO0Cm981F60=; b=JrngV4M7SWkwNmyOdI0DVKeYkD /CDhNiqbf/Enh89wONzrWKFR88RW3RBPbdvEf1xY7tIZPgSABO3r5EgQRM14VZBrDTj4W9NSWxU5i UNuzypaSquuQsrt2SCmg47sL7qnxhqv/4qdgSiOOhbH5F4Aeqz8ortvqxJgt2TiU6+R4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176334: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 13:39:18 +0000 flight 176334 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176334/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 6 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 14:12:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 14:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488823.757076 (Exim 4.92) (envelope-from ) id 1pNaKK-0007W6-6D; Thu, 02 Feb 2023 14:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488823.757076; Thu, 02 Feb 2023 14:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNaKK-0007Vz-3L; Thu, 02 Feb 2023 14:12:36 +0000 Received: by outflank-mailman (input) for mailman id 488823; Thu, 02 Feb 2023 14:12:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNaKI-0007Vt-5A for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 14:12:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a07ad59c-a303-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 15:12:31 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Feb 2023 09:12:20 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5508.namprd03.prod.outlook.com (2603:10b6:208:290::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 2 Feb 2023 14:12:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 14:12:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a07ad59c-a303-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675347151; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=AkG9rxP+ZEPqw2Hizx4kttgs4IHxAxKaJs4Zx50f7qI=; b=SlZuARRBBBi0anQNKW+ynuKQrb/i6diNAMwoVxnE4rjE59nTKmV3hkwj S1tFKOGwOsjRRlfi245wqWkHnA88/dB/9pXWR1+PHvqtP65EX2b6poRom z59TpXtipEKPy5AjgShTlDdQOjHGliVve5jcQHazzFhR+cg6vwRn706wl Q=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 94798497 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2e6cl6ppyNNP6+labo8406qDGiVeBmKzZBIvgKrLsJaIsI4StFCzt garIBnXM/2KMWrzLoxwb4q+8x9Q65bXxtA1TFA+qH01QX4R8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADxKSDCmv/Pp+byATM9JvN8CfePxO7pK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIS9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzkqa863AzMroAVIB1OUFeiqtSothH9QdBWJ HI/2gUV6rdnoSRHSfG4BXVUukWsugMXUpxeGusx5QWJ14Ld+QPfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESIYN3MYbCkICw4M+cD+oZobhwjKCN1kFcadkdD0Xzrwz jaipTI7wb4UiKYjzaKg90rAhDGqjpfMRw8xoA7QWwqN8QdRdIOjIYuy5jDz7/laK52CZkKcp 3VCkM+bhMgCBI+AvDaAS+IMGPeu/fntGDjVm1tmBZQi3zWr5X+4fIpU7S1+JUFmKcINc3niZ 0q7hO9KzJpaPX/vaLAtZYu0Up4u1fK4SYqjUe3IZN1TZJQ3bBWA4CxleU+X2SbqjVQolqY8f 5ycdK5AEEonNEiu9xLuL8917FPh7ntWKb/7LXwj8yma7A== IronPort-HdrOrdr: A9a23:RUesVKzxZlZ7umaXswzlKrPxAugkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2jnC6l87nzFjmfx1M7XylUybkv3G DZm0ihj5/T882T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHBmxulf4NoXpyFpXQQrPu04Fgnvd HQq1MLPth16VnWYmapyCGdmjXI4XIL0TvP2FWYiXzsrYjSXzQhEfdMgopfb1/w91cglMsU6t MI40up875sST/QliX04NbFEztwkFCvnHYkmekPy1RCTIolbqNLp4B3xjIRLH5AJlO/1GkUKp gpMCju3ocOTbpcVQGAgoBb+q3qYp30JGbcfqFNgL3O79EcpgEF86JR/r1iop5HzuN/d3AM3Z W7Dkwj/os+MfM+fOZzAvwMTtCwDXGISRXQMHiKKVCiD60fPWnRwqSHqIndS9vaCqDg4aFC7q gpamko/FIaagbrE4mDzZdL+hfCTCG0Wins0NhX49x8tqfnTLTmPCWfQBR2+vHQ6ck3E4neQb K+KZhWC/jsIS/nHptIxRT3X91XJWMFWMMYt94nUxaFo97NKIftquvHGcyjb4bFAHIhQCfyE3 EDVD/8KIFJ6V2qQGbxhFzLV3bkaiXEjOVN+WjhjpwuIaQ2R/5xW1Iu+CWED+mwWE1/m71zel diK7X6la7+rXWq/A/znhBUBiY= X-IronPort-AV: E=Sophos;i="5.97,267,1669093200"; d="scan'208";a="94798497" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MysIp9coAib2aXdssfLSqvjZjWrYZbZMtfl0drh5yPB93+Ftrg0e/6FOSr5mIYsjvVDJ3QsjYGmCnDSRXYPfFNtEByjEq+2e+JbSjn2PhUG9X47GKOuX53gNfe9BQMkCjszFpzRqF8OJCoJLvpz9J8ulU/cSsioyrwg/CrZ7+YEAM6Ud7XY3dBlMmQrQ1doZHdLAly7vlDmjOymWJmHPTkUNGe2mRS36KbbwkmQhw+KfsQR2RQljp8s/DSDrY9dHdV3sZJ0k1eL+RrRudnNh0IsIh41GImNWfgkJLgLp3xhj9OeDXl41SgH1JxK35mce8k/Z73ZjZmYVQimvCUMC5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkG9rxP+ZEPqw2Hizx4kttgs4IHxAxKaJs4Zx50f7qI=; b=N65czH0t7Dq1KBjKh5ALdNdSJv21bNzJ5zw3DOzcxxbICs/EczOzW8A8kGoivZ6gD6JKn7W9CqeHP7aU/k3XZDgxjWKEVXkSUXYJChmuipp6ouQa2K/Sonlc0HaZenCNooCBj8K3QnrxUK2GWhbx0DDXWeL0nA25Un4Pzytk5+2FZrhHYYWWMcz3UIAMmFlZp0drMG/Cn1JDurgvHczFH/c8pvDk4QJ3Y3uHG3KSyYY0qiixvFA6/vunxy6YkZwatvp86QTpNWZbWaLc0xyxvLaqtHW9hO9lvuQ6kyjP/z4GbzRJRc0YBGsnG1PR8eHFfdoZNCwuyJq4tBKhSUzhcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkG9rxP+ZEPqw2Hizx4kttgs4IHxAxKaJs4Zx50f7qI=; b=SS53snOklmRvrH9XTQebFoBYKKV0bqyFWSWUjtl3hTNlOFZrirppfVHo1Fd29qrcHCxfibaRnO/frqPlhkywuWATrxjyVtlkV2evb6r8vWu4G+MNI3pd+NCWhi0KKD2DV7SOIMgGzkI+E6v0V9Rv+oaTnpvPYMiw/mpIxPrS/Bw= From: Andrew Cooper To: Luca Fancellu , "xen-devel@lists.xenproject.org" CC: "bertrand.marquis@arm.com" , "wei.chen@arm.com" , George Dunlap , Nick Rosbrook , Wei Liu , Anthony Perard , Juergen Gross , Christian Lindig , David Scott , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= Subject: Re: [PATCH 08/10] tools: add SVE capability and SVE vector length for physinfo Thread-Topic: [PATCH 08/10] tools: add SVE capability and SVE vector length for physinfo Thread-Index: AQHZNvbB4qIHmh0j0EaFJcqzBgELUa67ssiA Date: Thu, 2 Feb 2023 14:12:18 +0000 Message-ID: <47f742d1-de3e-f1c1-5139-de37353545ea@citrix.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> <20230202110816.1252419-9-luca.fancellu@arm.com> In-Reply-To: <20230202110816.1252419-9-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR03MB3623:EE_|BLAPR03MB5508:EE_ x-ms-office365-filtering-correlation-id: 542241c5-a095-4062-3321-08db05277e52 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l+NqtCdmqen1jjelunJv+4w5iH2WHszvZ42DWWSfc7g0f9GB3rnM/Tyv2JkJvnyKYx1ee1eZoWuVeo6OS8aR+6XoaBPByhNiT3nJN6/ktVvqurbht0PuQACT95yLvza3xSPKtk96o4yanOW9Y/QATrkebyBBjH7acZbHU6UiBxOWqAeVy+NSc6bu1yVWXgzVo8J0eo9VV5pmll+ZP1X5UdvaLbMPfSPwo/2QB8cnf/YmXQRLEl8hEdN3FxIxiX/Thvhy4z2lr1xQqxLTG85iM/WbHfRPku151t/fYC7QgliHdKEJx46BZF9qEL8ERSbKytQHtmUQZWZFUMWcSVkhPYXi7zZo8OMCkW8eCP57uXwCEx6yl7ilwbMEdi9A8+B6wSBuFxPjMZgdcVouUyU7fK4vIQmHc7LxCst/VNjspxa5loYpgSY5E+fi6fTLf5GDusd8u/3Z1vCRR1tdeljC4LEn4+vR4qLzWgls2ieTRQ2/wcAkt8joFCqbEFSSyWWpcMiOCwtcl1WxmBrv+ciTMhIxIfrvwubj1F+rrtKbGAC9oEhtKsu6/trg2G6UdNPo093pBTTZ/+/9Mthpuy+o3paPiu7S03iO2CGeWc1EWF+8/8Qd+0do89lotTCOZEXxlEsTl/HAOLMtX5atL+BsScZ+b3BSMuPPahY4G7/Ddz3qxhLRodD/6jbMqlJrR6zH7cnEtIiPZzgD6/lK5M89umUwYv0SGanR++IA1ia64xr9eg4wlFemkfkmDwkGkLP10pPyxn21Rhsx2Z5oAOgtTg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199018)(82960400001)(38070700005)(38100700002)(122000001)(71200400001)(66446008)(66476007)(66946007)(66556008)(91956017)(4326008)(76116006)(41300700001)(64756008)(8936002)(31686004)(31696002)(86362001)(83380400001)(2616005)(186003)(6486002)(478600001)(36756003)(316002)(8676002)(110136005)(54906003)(6512007)(26005)(53546011)(6506007)(5660300002)(2906002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZTRva29QWE43bXVQcVJQRUFwS2lyM09STDRLaXlLY3UrWFJIWDJmK2ZzNWo4?= =?utf-8?B?SHJSNkdyNWY1THIyZE5QRVFiV0Z1RzBYZDI1UE5uTE1xdzFXN0hUK3ZGRi9t?= =?utf-8?B?MklEcFRQaExtaUowa0ZuUk5Zam0wTWlHRHJIZzBaYXc4aEVDZVB5d0k5d2kz?= =?utf-8?B?OTJ5aWw5alpRVTA0dmtqbjZPUzhKQ3Mrc3VGNlNjYXBKRko2Tzd3bitSOHkw?= =?utf-8?B?MFYvSlpXZ1p2Tk00L1I4UElmSEpnVUszblE1ejJWUTlvUFhROXZGbHRBYmpI?= =?utf-8?B?Sk92RCtxZ3NuSkg1a203N25KeEpibm54THRrZnQxTmZLSTFkbUlQUkhMZzRn?= =?utf-8?B?NVY4NUxLRFNUWEtjVHpLVDU1R0tVSi9pNHNIZ1NhVDFnYjVDYlQzQm9JekJT?= =?utf-8?B?YVpEVEZoNjNFRmRCRjNYNDFHdmc5d1lXM3VsVm4xSE9BbnJYRzdWL2duV204?= =?utf-8?B?aHpmMDZxV01xbUJWOWd6elZXZXBLYkFuZ0ZKdW5pL3pLNW13cDA1SlVCekVG?= =?utf-8?B?STVzZFJJTkxkWFU4U0hONlAxQWNSZUs4aVNWRDA0eHJ4c2FMUllBRHFKTmJO?= =?utf-8?B?YTdnbWhYRkJXbFZ0dmJ3eDdkS0VKYlB4empqaExmTVM0VzdjSjdWWnZSQm1Q?= =?utf-8?B?SjVmYkl5aVV3ZEVEUkhqNjVKTzExOWFaOHh5ZFhwdVFhNTA5d3hCczc2eHFx?= =?utf-8?B?cisyNE9wWjF2MHZJLzlqTWFDR1EzYzVPMFhqWTk5SWY5dzRNLzhRd2RoS3gv?= =?utf-8?B?MkJIb2YvbXFlbUNRejN4OGZBcDJkTDNoWmV0TzM0MDM4RWxYdUF3QlVTeWdD?= =?utf-8?B?bFRBMklkSXFGNW1ZTWl4ek1OK3duSlZacHNxZ0MvL3c2eVJmcGZsTlk4NjZX?= =?utf-8?B?VjhwQndTTFA1MjVvUkNWSWJEN3F5L081MlhEY3ZRTk1GcWczZXQ0b0k1T3Az?= =?utf-8?B?a0x0M1U0d3duZENXWllPN3poVVVJSC9qaWhNK3JJdU9xQmVkTzJDc2FGWXdz?= =?utf-8?B?a29GYU8rYmJZcGVhaFd5V0NlZ0VxcTdMbk1tOFJWVE14czZqdGF6V1IyMVpN?= =?utf-8?B?b096MEIxNzlrV25xOHZuUWtudFhPQkJiaVJtT0tFUDFUdXZlR01qV3Bqa0NS?= =?utf-8?B?UzlYc256VUhZNGNsWWcxckI4UkNWRFRzUUhGTzFjY3RsT3JWTkNER1pTd1Bu?= =?utf-8?B?MjRhOTBENERYMHhhdGtCdjlOMVM2S3ZCT0xOU0Y4cnA2dWNiK2x2Y2JUdG53?= =?utf-8?B?YkpxejcySlNYMjlRQy9VUzd5S1h0UGl6K3FtZlJSaFF3ZUUwdUNjQ1VJaCsz?= =?utf-8?B?aUowK1BhcVlmeFZzdGoxQ3Nzc1FsQlpoUlBacjJjcno0UllTQVp5OFZhN3BO?= =?utf-8?B?MmpHdkpWMW1lYlBLRUFCZFBZc0d3dCtLb0lITlNndzlSQjd1dkltNUZPTVpo?= =?utf-8?B?OTdJV1VvNEl6WnlvUFBLQndncVBTMTg0WU0zak01TDZsZ3hwMTMwdUltNEY1?= =?utf-8?B?MFB3K0J3dmpkT2o3Q1NFcDllczd0SXVLVmQ0dDRCc2lkUlgyVEpoMm1HVFdH?= =?utf-8?B?Nnp0bzlyMzNRTDZpeVlRVnpsakpKWjNxbmVYbWVhRDMweWd3enlyQkltT1dO?= =?utf-8?B?YkhhUzUyWXNBbDltZk85bUg2NVlZUVhOOUlramFtR2VZS1M2eG1Ua0MxWDht?= =?utf-8?B?SlluMURUaTJTbmJsUDVtbWg5NkJSV2tXZEdwQUR1R1pseDFlWVFlMUJacE9t?= =?utf-8?B?YTQwUXBSWEFhUWliYWJtUi9VcUd0RXZxQjhCaDFKUWRDelU0Nnh3dVh6ZmVn?= =?utf-8?B?TnhGbGsvbnl3b1B1SG5XWnBWcHJzSVdGeVdDa2xGTC9yN3M1UWVsYVA3TCth?= =?utf-8?B?TE45N1VyY2pxUzhrWHVGWlV6bGxaRjZzTlQwTzRTZ3lUUFdhb0RTYTRNRldL?= =?utf-8?B?cDB6R0J4Q3QzcTN5MVRHcDltZGlhSVNZU0syLzFzTGdNTnd1eWZzMVU2NUNt?= =?utf-8?B?ekVOMVI5SUpqVWtwcEJsNHRhU21OKzh1QjArRXVSOC9GZmhTMVRIYWZTY21s?= =?utf-8?B?enhEU0pnZXlwOE4zQk1uZlFjVlYyRkNmNnl6Q1pyWWhCUnJkVmp1TTFkM2Vj?= =?utf-8?Q?GzQ+BkZEE8ZayoCB7H/iBhetw?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Z2pPY0NvN0o2TGpQZVE3M0wvaG1FcXFmNXpGSS83ajUvUGNYckJiZUdHdm1K?= =?utf-8?B?TEZFemk0WUVJT1BVY1d4UEFxUVBocmhCNnZnUWJaVkZWbmI1WDRWZG5Jb2hm?= =?utf-8?B?dVVsT05VWW5TNGR1a1lVVUIzNWprREd3WGUzYTJhTWlhUGtDMDY1RzlWSCtk?= =?utf-8?B?bitGbzVGczdDSlZ5NVIrVDFDRkNRbkN1SkU0ZWZ5QUtMU0o4Mjg5dm1sektI?= =?utf-8?B?elcxamZLTmxjVzQwUU52QXlWWVpndkJISldpVXBwdnhpQ1lxbUQrTnRBcFJr?= =?utf-8?B?aHk2a284WktpY2lpMnBiZ1dBQ0YraUo0R05JMHpUWldxTy8vUzB5eUoyRVpR?= =?utf-8?B?M0pqb0FvY2NhZnVHUTBrT01UOWxEa1FBRDA3SWdQYSt6alR0RUlNa3RCYUl0?= =?utf-8?B?RDVlY3U1QnovYVFoMVBEd1YwczNISkkxTm9SS3VWRE52SEg0RWMwZ1JXaHJR?= =?utf-8?B?NlRZVVdPdm1mUVNGbjRXNjdXZU1uazl2YzUwVkNhWTFkbWtJdTFTa0FLWEtU?= =?utf-8?B?U3paU0xoNi9INmpHMXNTNENyOW5FMk9IRWEvMnhNTzVFdCsxVFpDN1NPbU4x?= =?utf-8?B?L0VTY0w4NkNsVUZqRi9yOTArRUhXOGY3UzIwT1ZGblM3ZDRKVGs3NTJUZXNF?= =?utf-8?B?ZmpSYlVZZ2srRWJIR0hNK0h0WUFPYldEYkpibERmMHM3ZXBvSTc0KzZDcWIz?= =?utf-8?B?QjF0T0xYVGN2eEdyN21jNmZieUQ3VHFFZHlxZkFXZkhwYWp0eHVIazdDZVFP?= =?utf-8?B?S3RTc0JDc2wzOStYaCtFYjZ3cG93TVkvZ3VxeFdnUW1hWlpwS2JDWVNBQklu?= =?utf-8?B?Ym5JVlBWRGV4K2ovcU8rdC9GUkpIbThwUHNESkFXMDI4Q3R5bm4zYkprK1U5?= =?utf-8?B?c2d3eDM3RGpyNnE4M2orbmNQaWlHMXk2MVdzNERDMzBaVjJ0UXBXelhjZUha?= =?utf-8?B?MEswSFlOYWlKck9yekpJMGtkRmhLR3NSWHd0dTc5UDNxMFVNV1daUkY4cFVn?= =?utf-8?B?czJha2pxd0Zyb1dqMnZGRU1BTWIrd1RQWERRZ244TzAwWEU1cGloNCttUUtQ?= =?utf-8?B?VzA2aENWeFdSNWNabVQ2bndVTURVakZxMWhCcTU5eTg2Zmp6K1NvZmxzQVNx?= =?utf-8?B?T0xMSUdROUtMcTYrdGVuT0ZkcENyRmhEdmUxRk9hRHhJeXA3N2xxQWhMckdX?= =?utf-8?B?LzAyTVFyWjZsU1BDLzNXajI4dndyUzJORkVSOWt3bmc1Ny9BeG9aM2p5SjFE?= =?utf-8?B?UlFLcXNIYUIycmtqbzNnM01nU0k4TXIrbjVEcDlDZGJtQllKUT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 542241c5-a095-4062-3321-08db05277e52 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 14:12:18.3768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tJvZzJt6DHBoxqOpRkmPeE/Equn6oiRFet8pDoG9b6lsUVcQvh2ulmCoDwXgOrNG8KTWZ38eVbsxcmw/M6f5GFSiIQh3k0WwWdMK1dLLeVs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5508 T24gMDIvMDIvMjAyMyAxMTowOCBhbSwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4gUmVjZW50IGNo YW5nZXMgYWRkZWQgaW4gc3RydWN0IHhlbl9zeXNjdGxfcGh5c2luZm8gYSBuZXcgZmxhZyBmb3IN Cj4gYXJjaF9jYXBhYmlsaXRpZXMgdG8gdW5kZXJzdGFuZCB3aGVuIHRoZSBwbGF0Zm9ybSBpcyBT VkUgY2FwYWJsZSwNCj4gYW5vdGhlciBmaWVsZCBoYXZpbmcgdGhlIG1heGltdW0gU1ZFIHZlY3Rv ciBsZW5ndGggaW4gYml0cyB3YXMNCj4gYWRkZWQgYXMgd2VsbCwgc28gdXBkYXRlIHRoZSB0b29s cyB0byBoYW5kbGUgdGhlc2UgbmV3IGZpZWxkcy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogTHVjYSBG YW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPiAtLS0NCj4gQ2hhbmdlcyBmcm9tIFJG QzoNCj4gIC0gbmV3IHBhdGNoDQo+IC0tLQ0KPiBUaGlzIHBhdGNoIGlzIG1vc3RseSBkZXBlbmRl bnQgb24gdGhlIGRlY2lzaW9ucyB3ZSBtYWtlIGluIHRoZSBwcmV2aW91cywgYW55d2F5DQo+IEkg dG91Y2hlZCBzb21lIHBhcnQgb2YgdGhlIHRvb2xzdGFjayB3aGVyZSBteSBrbm93bGVkZ2UgaXMg bGltaXRlZCAob2NhbWwpIHNvDQo+IEkgbWlnaHQgbmVlZCBhIGZlZWRiYWNrIGZvciBzb21ldGhp bmcgSSBtYXkgaGF2ZSBkb25lIHdyb25nLg0KDQpUaGVyZSdzIGEgbG90IG9mIGlmZGVmYXJ5IGhl cmUgd2hpY2ggaXMgZ29pbmcgdG8gbWFrZSB0aGUgY29kZQ0KaW1wb3NzaWJsZSB0byBtYWludGFp biwgZXNwZWNpYWxseSBpbiBweXRob24gYW5kIHhsIHdoZXJlIHlvdSdyZSBwbGF5aW5nDQpnYW1l cyB3aXRoIHRoZSBwb3NpdGlvbiBvZiB0aGUgY29tbWEuDQoNCkJ1dCB0YWtpbmcgYSBzdGVwIGJh Y2suwqAgRmlyc3QsIHNwbGl0IHRoaXMgc2VyaWVzIGludG8gdHdvIChldmVuIGlmIGl0J3MNCmZp cnN0IGhhbGYgLyBzZWNvbmQgaGFsZiBvZiBhIHNpbmdsZSBzZXJpZXMgdGhhdCB5b3UgZW1haWwg b3V0KS7CoCBIb3cgdG8NCnJlcG9ydCB0aGUgcHJlc2VuY2Ugb2YgYSBjYXBhYmlsaXR5IGlzIGRp ZmZlcmVudCBmcm9tIGhvdyB0byBjb25maWd1cmUNCnRoZSBjYXBhYmlsaXR5IGZvciBhIGd1ZXN0 LCBhbmQgc2hvdWxkIGJlIGRvbmUgc2VwYXJhdGVseS4NCg0KQnV0IGV2ZW4gc3RpbGwuwqAgU1ZF IGlzIGEgc2luZ2xlIGJpdCBmZWF0dXJlLsKgIHBoeXNpbmZvIGlzIHRoZSB3cm9uZw0KcGxhY2Ug dG8gcmVwb3J0IGl0LCBhbmQgSSBkb250IHNlZSBhbnkgbmVlZCBmb3IgaXQgdG8gYmUgaW4gdGhl IGRvbWFpbg0KY29uc3RydWN0aW9uIGh5cGVyY2FsbC7CoCBCb3RoIGFyZSBjcml0aWNhbGx5IHNw YWNlLWxpbWl0ZWQgc3RydWN0dXJlcy4NCg0KQVJNIG5lZWRzIHRvIGdhaW4gc29tZXRoaW5nIHNp bWlsYXIgdG8geDg2J3MgY3B1IHBvbGljeSBhcmNoaXRlY3R1cmUsDQpib3RoIGluIHRlcm1zIG9m IHN5c2N0bHMgcmVwb3J0aW5nIHN5c3RlbSBjYXBhYmlsaXRpZXMsIGFuZCBkb21jdGxzIHRvDQpn ZXQvc2V0IGRvbWFpbiBjb25maWd1cmF0aW9uLg0KDQpMb29raW5nIGF0IHlvdXIgY292ZXIgbGV0 dGVyLCBTVkUgKGluIHRlcm1zIG9mIHdoYXQgaXQgbWVhbnMgZm9yIFhlbikNCmxvb2tzIHF1aXRl IHNpbWlsYXIgdG8geDg2J3MgQU1YIGFuZCBBcmNoLUxCUiBpbnNvZmFyIGFzIGl0J3MgYSBsYXJn ZQ0KYW1vdW50IG9mIG5ldyByZWdpc3RlciBzdGF0ZSB0aGF0IHdlIGRvbid0IHdhbnQgdG8gYWxs b2NhdGUgZm9yIGd1ZXN0cw0Kbm90IG1ha2luZyB1c2Ugb2YgaXQuDQoNCk9uIHg4Niwgd2hhdCB3 ZSdyZSBwbGFubmluZyB0byBkbyAoSXQncyBub3QgZG9uZSB5ZXQsIGJlY2F1c2UgSSBrZWVwIG9u DQpnZXR0aW5nIHByZWVtcHRlZCB3aXRoIHNlY3VyaXR5IHdvcmspIGlzIHRvIHJlcXVpcmUgdGhl IHRvb2xzdGFjayB0bw0KbWFrZSBhIHNldF9jcHVfcG9saWN5IGh5cGVyY2FsbCBiZXR3ZWVuIGNy ZWF0ZWRvbWFpbiBhbmQgbWF4Y3B1cyB0bw0KY29uZmlndXJlIHRoZSBzaXplIG9mIFhTQVZFIHN0 YXRlLCBhZnRlciB3aGljaCB2Y3B1X2NyZWF0ZSgpIGluIHRoZQ0KaHlwZXJ2aXNvciBoYXMgdGhl IGluZm8gaXQgbmVlZHMgdG8gY29uc3RydWN0IGJhY2tpbmcgc3RhdGUgY29ycmVjdGx5Lg0KDQoN Ckkga25vdyBJJ20gdGVsbGluZyB5b3UgdG8gZG8gYSBsb3Qgb2Ygd29yaywgYnV0IGJvZGdpbmcg U1ZFIGluIGxpa2UgdGhpcw0KaXNuJ3Qgb2suwqAgU29tZW9uZSAqaXMqIGdvaW5nIHRvIGhhdmUg dG8gZG8gcHJvcGVyIGZlYXR1cmUgY29uZmlndXJhdGlvbg0Kb24gQVJNLCBhbmQgSSBndWFyYW50 ZWUgeW91IHRoYXQgaXQgd2lsbCBiZSBsZXNzIGVmZm9ydCB0byBkbyBpdA0KcHJvcGVybHkgbm93 LCB0aGFuIHRvIHJldHJvZml0IGl0IGluIHRoZSBmdXR1cmUuwqAgeDg2IGhhcyBiZWVuIGENCm5p Z2h0bWFyZSB0byB1bnRhbmdsZSAxNSB5ZWFycyBvZiBiYWQgaW50ZXJmYWNlIGRlc2lnbiBpbiBh IHdheSB0aGF0DQpkb2Vzbid0IHJlZ3Jlc3MgYmVoYXZpb3VyLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Feb 02 14:32:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 14:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488828.757087 (Exim 4.92) (envelope-from ) id 1pNadB-0002L5-OL; Thu, 02 Feb 2023 14:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488828.757087; Thu, 02 Feb 2023 14:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNadB-0002Ky-LD; Thu, 02 Feb 2023 14:32:05 +0000 Received: by outflank-mailman (input) for mailman id 488828; Thu, 02 Feb 2023 14:32:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNadA-0002Kq-CS for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 14:32:04 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c5fcce3-a306-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 15:32:03 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id y1so1900481wru.2 for ; Thu, 02 Feb 2023 06:32:03 -0800 (PST) Received: from [10.95.156.231] (54-240-197-230.amazon.com. [54.240.197.230]) by smtp.gmail.com with ESMTPSA id e28-20020a5d595c000000b002bfd8ad20a0sm16175013wri.44.2023.02.02.06.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 06:32:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c5fcce3-a306-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=I6dyQOgZukQ54QDK6aIe7WXm73Yx6J7f4p/XUgBjaiQ=; b=gYEzfD17n8nHeGoo5M7J1IahG2YNPvjdBolDnNH1dKlwLIQXMWw5VU0hROBTqSsbWm Npz0Q/sEvU9Pvv6n+f33YCfowllVjSHQofRAnH4e6OvqHfY4aYJ3iY1L6yRYpwNPNbmY VI6gWJfW8NBJaQYAgGel+y5tvn51iZ3Ky+OAt/opWL3Gmkwx0qezwoZKvXvva4g1nXQh IimNUx1q+fZliP6fbn4t2d+dyycwzO3lQKu0VqbQMomqkgPAL+BVeDucNBeEk42SdHEd ztaaXz6nwQvW7Q2rJfuhQDam4dWfsPjwyqs3RdNhBr+gZZXgE7a20uII9ldSfZgOEMm8 8gQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I6dyQOgZukQ54QDK6aIe7WXm73Yx6J7f4p/XUgBjaiQ=; b=cLXDlijECiEzNxVcGwfUmId3c5ayWWQNWWK9x1h7eQOp0l/8xfgppz3j3HDrI++fls sSc1tewfdavJcZh3MB+C0WCjzIc7vlzue3He1x1nH2NNIfQHLzvcFzeyUoQGpumFRpUt PvsEhSA6zB8QjQ68RrSOpZPQ9X2AaCIPYt/KVg8paRAQ/5dlZ+h4Q6JkGvqMiAfb/vDL ivBtoWpjEdYE4FTbORFo285tVyfQ0i9nwg/0jmYL89h22LEesRiPBa9ghJTM0DDzUTJB I1ZSFvSfyOY/MzDVhozNw63IT9bKbF9Aac9XNm4j+WVBZHocj8JZHVnCPWjWIMbxCKuZ WAOQ== X-Gm-Message-State: AO0yUKW3tH0kHSEBzIUWR38ew/2i14lMAB0KT+SAc8Ul4Qi3RDR7Bygk k1DcNWVVRBGT6xVCk9cuxzg= X-Google-Smtp-Source: AK7set/Ded8UbNBqMS274a0klw1pXZiUb0FG0DCX0n76UwKL6fmeBdzYOvVoqjnvG9oAyaz0U8rRew== X-Received: by 2002:a5d:464a:0:b0:2bf:b1f0:7bab with SMTP id j10-20020a5d464a000000b002bfb1f07babmr5097051wrs.47.1675348322958; Thu, 02 Feb 2023 06:32:02 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <5b7c223a-2c96-4bd2-7150-79a56281dd57@xen.org> Date: Thu, 2 Feb 2023 14:31:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Reply-To: paul@xen.org Subject: Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine Content-Language: en-US To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Peter Maydell , Stefano Stabellini , Anthony Perard , "open list:ARM TCG CPUs" References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-10-vikram.garhwal@amd.com> <179d773b-2634-b52b-8836-8d8f882e1495@xen.org> <3e205146-5113-861d-ef39-c463257b54a1@amd.com> Organization: Xen Project In-Reply-To: <3e205146-5113-861d-ef39-c463257b54a1@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/02/2023 18:22, Vikram Garhwal wrote: > Hi Paul, > > Thanks for reviewing this and other patches in series. > > Please see my reply below. > > On 2/1/23 12:30 AM, Paul Durrant wrote: >> On 31/01/2023 22:51, Vikram Garhwal wrote: >>> Add a new machine xenpvh which creates a IOREQ server to >>> register/connect with >>> Xen Hypervisor. >>> >> >> Is this really the right way? Is it not possible to do the Xen >> initialization (including ioreq server registration) off the back of >> the accelerator init (i.e. AccelOpsClass ops_init function), which >> seems like the right place to do it now that it's no longer >> architecture specific. >> > There are few other machines using the "accel=xen" option and few of > these machines aren't using IOREQ and other Xen related initialization. > Example: /xenpv/ machine under /hw/xenpv/xen_machine_pv.c /and few other > machines under /hw/i386/pc_piix.c//. Ok. TBH the concept of 'accel=xen' is probably somewhat broken then. (QEMU isn't even running the VM in question, so how can it be accelerated?). Maybe abstract machine types really are the right way then. Paul > /So, that's//why we moved the IOREQ and other common initialization > parts in hw/xen/xen-hvm-common.c and call them as needed for the > particular machine. > > @stefano, just checking if you want to add any other suggestion here. > >>   Paul >> From xen-devel-bounces@lists.xenproject.org Thu Feb 02 15:18:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 15:18:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488835.757098 (Exim 4.92) (envelope-from ) id 1pNbLe-0000Ga-6X; Thu, 02 Feb 2023 15:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488835.757098; Thu, 02 Feb 2023 15:18:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbLe-0000GT-1Q; Thu, 02 Feb 2023 15:18:02 +0000 Received: by outflank-mailman (input) for mailman id 488835; Thu, 02 Feb 2023 15:18:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbLc-0000GI-LQ; Thu, 02 Feb 2023 15:18:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbLc-0006Ki-Gd; Thu, 02 Feb 2023 15:18:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbLc-0003PC-3s; Thu, 02 Feb 2023 15:18:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNbLc-0005Wo-3B; Thu, 02 Feb 2023 15:18:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ke525gWmgUiqbRu/CeXxDSJMPrh08YMED6NgAJ4cRL8=; b=fOIBqvuHcTq1SFuDxAYm6lHeQ0 m0472FhT+8gf18QrGJe//9WjaXmiP2hIHmCXSs1NNm6qnlDKOvLFKVY1klthb7rcXo8si0n2M/1gS cuYTS6LggcaucPYkYRu+HajLGsgY75hNwK/MbOnT5DpQRO7dEsIbV3EQqCSoz8nHCp2s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176332: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:build-armhf::broken:regression qemu-mainline:build-armhf:host-install(4):broken:regression qemu-mainline:build-arm64-pvops:kernel-build:fail:regression qemu-mainline:build-armhf:syslog-server:running:regression qemu-mainline:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:build-armhf:capture-logs:broken:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=026817fb69414c9d3909d8b1a209f90180d777d6 X-Osstest-Versions-That: qemuu=13356edb87506c148b163b8c7eb0695647d00c2a From: osstest service owner Date: Thu, 02 Feb 2023 15:18:00 +0000 flight 176332 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/176332/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176096 build-arm64-pvops 6 kernel-build fail REGR. vs. 176096 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176096 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail like 176096 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 176096 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176096 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176096 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 026817fb69414c9d3909d8b1a209f90180d777d6 baseline version: qemuu 13356edb87506c148b163b8c7eb0695647d00c2a Last test of basis 176096 2023-01-24 12:38:02 Z 9 days Testing same since 176332 2023-02-02 10:37:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dongdong Zhang John Snow Maksim Davydov Marc-André Lureau Peter Delevoryas Peter Maydell Vladimir Sementsov-Ogievskiy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 026817fb69414c9d3909d8b1a209f90180d777d6 Merge: 13356edb87 bd4c0ef409 Author: Peter Maydell Date: Wed Feb 1 16:15:55 2023 +0000 Merge tag 'python-pull-request' of https://gitlab.com/jsnow/qemu into staging Python Bits and pieces, kibbles'n'bits # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCAAdFiEE+ber27ys35W+dsvQfe+BBqr8OQ4FAmPQlMIACgkQfe+BBqr8 # OQ5RIxAAqaG8Dx63CXa8WHMsGWc0CKTOcwTcRDw92GT3qhVkebZiNmNlZwckaU/c # CkVunJnU5T6T2qkploysUXwdlQ+XsY4fQlACNciZeffmT2E4siNQ/4H1uPB4xca6 # 8Sgmg2VH7OF+EWwuBihY1pbe7g+sOJg9w9isRduBnLGrLbOrewGIJBNbiVzFlz5W # 30RdvfLoUUak5qTlMT/6yl98r6fkkDmfPX653iYmpA/H/Ah+17ZJXB2XNigkqBdD # Cp8OxtFceKQdZOqNiADJRzT3Gore4lBkPnULKwct/5U0B/tUiBdZ2YDJW8EObUMY # zFE7giE5mCnyFSmfBmjKu8yS8zJm9NooYEjunTcodop/FDb96c3sh8376ZLamTii # /p5WSwfo4a6DXPUTx0aiCkqpeCdPncRgwKc5TvqyKLKxQHbfjt6UZrcL6iYbe6O6 # ltBcdvfdzL41TNjS678QqiGuYkADVa/nhig3ano4msx/Tf5e0O8eMoK9bDbVS9KF # QuONtOcut1YhnAHJp4oYN2Nimtr0t8j07iOOfc4X3+WwdbMCfR+toDM4wWVJ3u/O # 8Phy8hinfndMXdP9Q4eeFAiJ1zuD/XkpaKoDe0gHcEvp3zMEXmHiEOdv4hFeWTQB # ivU3oM/j2uVcHU4CSxra3B54vfLc1gudJ2yLPvhwPKoIRbJ/kbc= # =36NA # -----END PGP SIGNATURE----- # gpg: Signature made Wed 25 Jan 2023 02:32:34 GMT # gpg: using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E # gpg: Good signature from "John Snow (John Huston) " [full] # Primary key fingerprint: FAEB 9711 A12C F475 812F 18F2 88A9 064D 1835 61EB # Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76 CBD0 7DEF 8106 AAFC 390E * tag 'python-pull-request' of https://gitlab.com/jsnow/qemu: python/qemu/machine: use socketpair() for QMP by default python/qmp/legacy: make QEMUMonitorProtocol accept a socket python/qmp/protocol: add open_with_socket() python/qmp: increase read buffer size python/machine: Fix AF_UNIX path too long on macOS python: QEMUMachine: enable qmp accept timeout by default Fix some typos Signed-off-by: Peter Maydell commit bd4c0ef409140bd1be393407c04005ac077d4574 Author: Marc-André Lureau Date: Wed Jan 11 12:01:01 2023 +0400 python/qemu/machine: use socketpair() for QMP by default When no monitor address is given, establish the QMP communication through a socketpair() (API is also supported on Windows since Python 3.5) Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20230111080101.969151-4-marcandre.lureau@redhat.com [Resolved conflicts, fixed typing error. --js] Signed-off-by: John Snow commit 603a3bad4b9a95b524dc8d6a41b1be4d5c5cacdf Author: Marc-André Lureau Date: Wed Jan 11 12:01:00 2023 +0400 python/qmp/legacy: make QEMUMonitorProtocol accept a socket Teach QEMUMonitorProtocol to accept an exisiting socket. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20230111080101.969151-3-marcandre.lureau@redhat.com Signed-off-by: John Snow commit a3cfea92e2030926e00a2519d299384ea648e36e Author: Marc-André Lureau Date: Wed Jan 11 12:00:59 2023 +0400 python/qmp/protocol: add open_with_socket() Instead of listening for incoming connections with a SocketAddr, add a new method open_with_socket() that accepts an existing socket. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-id: 20230111080101.969151-2-marcandre.lureau@redhat.com Signed-off-by: John Snow commit 166464c6ce82f748e33b24361a72e9d310130fa0 Author: Maksim Davydov Date: Thu Jan 12 18:28:03 2023 +0300 python/qmp: increase read buffer size Current 256KB is not enough for some real cases. As a possible solution limit can be chosen to be the same as libvirt (10MB) Signed-off-by: Maksim Davydov Reviewed-by: John Snow Message-id: 20230112152805.33109-3-davydov-max@yandex-team.ru Signed-off-by: John Snow commit f9922937d173f50fe59fd1b20fadc445fb6b2564 Author: Peter Delevoryas Date: Tue Jan 10 00:29:30 2023 -0800 python/machine: Fix AF_UNIX path too long on macOS On macOS, private $TMPDIR's are the default. These $TMPDIR's are generated from a user's unix UID and UUID [1], which can create a relatively long path: /var/folders/d7/rz20f6hd709c1ty8f6_6y_z40000gn/T/ QEMU's avocado tests create a temporary directory prefixed by "avo_qemu_sock_", and create QMP sockets within _that_ as well. The QMP socket is unnecessarily long, because a temporary directory is created for every QEMUMachine object. /avo_qemu_sock_uh3w_dgc/qemu-37331-10bacf110-monitor.sock The path limit for unix sockets on macOS is 104: [2] /* * [XSI] Definitions for UNIX IPC domain. */ struct sockaddr_un { unsigned char sun_len; /* sockaddr len including null */ sa_family_t sun_family; /* [XSI] AF_UNIX */ char sun_path[104]; /* [XSI] path name (gag) */ }; This results in avocado tests failing on macOS because the QMP unix socket can't be created, because the path is too long: ERROR| Failed to establish connection: OSError: AF_UNIX path too long This change resolves by reducing the size of the socket directory prefix and the suffix on the QMP and console socket names. The result is paths like this: pdel@pdel-mbp:/var/folders/d7/rz20f6hd709c1ty8f6_6y_z40000gn/T $ tree qemu* qemu_df4evjeq qemu_jbxel3gy qemu_ml9s_gg7 qemu_oc7h7f3u qemu_oqb1yf97 ├── 10a004050.con └── 10a004050.qmp [1] https://apple.stackexchange.com/questions/353832/why-is-mac-osx-temp-directory-in-weird-path [2] /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/sys/un.h Signed-off-by: Peter Delevoryas Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-id: 20230110082930.42129-2-peter@pjd.dev Signed-off-by: John Snow commit ada73a492cb29b9c3a9f88c5e6d3407fa0d999e7 Author: Vladimir Sementsov-Ogievskiy Date: Fri Jun 24 22:52:52 2022 +0300 python: QEMUMachine: enable qmp accept timeout by default I've spent much time trying to debug hanging pipeline in gitlab. I started from and idea that I have problem in code in my series (which has some timeouts). Finally I found that the problem is that I've used QEMUMachine class directly to avoid qtest, and didn't add necessary arguments. Qemu fails and we wait for qmp accept endlessly. In gitlab it's just stopped by timeout (one hour) with no sign of what's going wrong. With timeout enabled, gitlab don't wait for an hour and prints all needed information. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-Id: <20220624195252.175249-1-vsementsov@yandex-team.ru> [Fixed typing. --js] Signed-off-by: John Snow commit af76484e54f6c5e20452c2b329378026b8f2c59d Author: Dongdong Zhang Date: Wed Nov 30 09:53:58 2022 +0800 Fix some typos Fix some typos in 'python' directory. Signed-off-by: Dongdong Zhang Reviewed-by: Philippe Mathieu-Daudé Message-id: 20221130015358.6998-2-zhangdongdong@eswincomputing.com [Fixed additional typo spotted by Max Filippov. --js] Reviewed-by: John Snow Signed-off-by: John Snow From xen-devel-bounces@lists.xenproject.org Thu Feb 02 15:51:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 15:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488845.757108 (Exim 4.92) (envelope-from ) id 1pNbs7-0005in-V2; Thu, 02 Feb 2023 15:51:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488845.757108; Thu, 02 Feb 2023 15:51:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbs7-0005ig-SF; Thu, 02 Feb 2023 15:51:35 +0000 Received: by outflank-mailman (input) for mailman id 488845; Thu, 02 Feb 2023 15:51:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbs6-0005ia-Nq for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 15:51:35 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73df9ac3-a311-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 16:51:31 +0100 (CET) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Feb 2023 10:51:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6008.namprd03.prod.outlook.com (2603:10b6:208:30a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Thu, 2 Feb 2023 15:51:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 15:51:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73df9ac3-a311-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675353091; h=message-id:date:from:to:cc:references:subject: in-reply-to:content-transfer-encoding:mime-version; bh=IIh3rOzHrWbMRQwF6khqiAhmlTKEMfgvvlBC2BHiQ6A=; b=LzZnQBRI4IaW/yq97GTXoJvOjPE5kfdCpbUqqw7c/Ux98M+T4pdk5+LL 39vRvLiTEgccY8xj7e6imhK8MbirjiajnkUwZn6RxwMyv0+nJ+2Vfae1i gsp/7hLb2zvmYMLluyoHA32QZPRPvHDR2pYNTKAGMGPmcRcFur1lM92Jr w=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 95402703 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:F9L4pKtmCR/dZptNgoE52UNaXufnVJxfMUV32f8akzHdYApBsoF/q tZmKTqAOf7eZzCnKIggaYvk9B9TvJWAztBhQAFkrCk0FS4W+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWGzSFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwE3cmdw+j29yKxuineLU1rcoxPOq3BdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60bou9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzlqqYw3wXIroAVIB0pa0Pmmf+ysFe/CtREI E8Q03VtlpFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarTwLzcqzelp5yMQgtr4AzSBzih9lkgOt/jYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr32/FF6KLFWyI3AxDGQ== IronPort-HdrOrdr: A9a23:LeZi/q2lwWLftGmDQsu4wAqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-IronPort-AV: E=Sophos;i="5.97,267,1669093200"; d="scan'208";a="95402703" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2S+lt0o7rkZ7WZcr7KvrXJenaPyUhHiTpanwrvjB4hT9arm/FtKbVoppWBNAp5j20awxsC1hJ4UU4WZxzYRN86EbCFRtj400gyOBmddjpwOS8WzK3C6Lhj9TrXlY2+bOsK3jAFBh5Ou1uCRvx6ayNAGpW8HiRA8Tup8NbevEQ+xYK79kCwwsjtQKSJpVUsWipbWpFvsL9P9xvWDh503X0lri87W0wz9fqjrxwCejYvbtm0xx9Zf0ngO0y44aeAxctwBvTPGl4MSLDDlj+2FQkXPNRcgwDF9xUX99+AzCQZGpNALWGJXiJtwKN0Q6YkIGM3i97WRr4QJ6EfnycHe8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZqStkqnQ+mR7F3QJ1g3SimZ7kMr6Edjvzbno+Xi1kE=; b=MBmaazjReMnVZ9iN9bQtAvKGCwZkGoJYb5DacjEwCsLvKScICmAamwEGKxqRsfD/6ek6MlQmkTnxiznXdKzuXBKyYH9BZUFR7bNIBgOvxHE+TmFBtCuP3T/Cml4Ff6ydehSKI5qBmJs4TWAbkvBFmBUZOga5RUSHAowGDF3OitT+t2rFEMiBhQDYvOuQfPzVpIA22vf8UoRlvK523qiKPGKKqjVVaaFhsQgUHte/mQGiVoQiKeYAVwHPX3nUcRP6JEWvwGyoK5IiMphLUEp6rjM8pBU/eJLfsrx0vRupNnr1DiOfuk/5f3FfVj3OAyan37dhgee0DkAbIJXOOnBFtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EZqStkqnQ+mR7F3QJ1g3SimZ7kMr6Edjvzbno+Xi1kE=; b=UIabk9xBnENaiYWhfqIAoFCxChTl/tYkn/QKpC3byAsZoBdZ1p9YZN6sFHDIU302g7grU2eRZLzIAgND2psYbMQ2E7ovSSGkKcWQIKc/GU+rkMIR7qRRM2ATbJDuGltVZlzTBMCUxlclKn5cUyyQFKNu66DgsVywSFgdixJqrGc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> Date: Thu, 2 Feb 2023 15:51:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: Content-Language: en-US, en-GB Subject: Re: Proposal for consistent Kconfig usage by the hypervisor build system In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0170.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6008:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d93dea6-73d9-490c-538b-08db05355446 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YQsZ915/QPu9AR4AQ6ar+5hSnUfhR0OhVfGRMf4YPriTbINAEfCp6k4l5Sz47Gnz5fFD0CPcDtTsHx/43Hg3XazgCjHN22DoTfVJONC+NXBzEikbeYJeyfN0Bk1g7e8Qsw8Jv4o/Pp09dK8tvNDyXiiU0Fk8yY4J3Drlx5L0IKGYoMEwQzRZu0XosGFACYQkPH8wbalg04swY43rdPNYxy4FYSWxx5yozphKxGF4M22d+ADv6oTGpGuH4HIWc0sjJAEY/cY5ck36lrbu+c87krtve/TXfg4T4fI0zOsk13yGrUtVzVg8wvu6z9XV9ZFM9ivAflNThWMlzKxHhqwyWdJ+P1/KBvSSbmXCxLJMs+zMOKZ7nY48NvlxqA/DRraC52JRu6ysVnGF4ibFlENVIh5Hvon6Zro+Lter99tCTqUQEuST0tBalKRPDChwHJcTpyT36XNlblNsRId1H1CgjXlzY4sLkeMEQ/+VksG4zVv0BMS2eKXOGWXMlPNUamRanL1WNf/VHILiTstKE4S4wlIR6dU0cFcpjLLkmtPV7BGG+EcXzIgM8d99GZGh6G85KV28a72wGQrVwTjlP/ZkUIZ3vYSn/BVGhB8gOrO5LrP2nzfPuZ1T+hlrObWaehUxJu9hh5yj/XbnSewISZxQTmZL9de/4W4tAy0vlh7G0llacvGXUNxxqoDB2AELsFlb/Tyv5JZOPhSPcEDCZjn0nFUovVfcKuV9wpHrLnAUCM8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199018)(2906002)(6512007)(38100700002)(186003)(5660300002)(26005)(82960400001)(6666004)(66946007)(31696002)(8676002)(4326008)(83380400001)(41300700001)(8936002)(66476007)(6506007)(54906003)(110136005)(316002)(66556008)(478600001)(53546011)(66899018)(86362001)(6486002)(36756003)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0RLYUE1UDBMZWdMNVROOUdGamhyd2ZmdEJaRkoxak02Vm5kNjMyQU9jNkkx?= =?utf-8?B?azNpSUFmenVNSDBwVUZxWWlZcU00Ung2U2lEeGU4NzQrb0xCUXZ5MEpDZk9V?= =?utf-8?B?WVJRR3VYcjRHRW0yYVhjSHQxOGRmZWdxQnBOLzlmZVBBb2xmcUlNQ2lzamVG?= =?utf-8?B?SHlHSGlMSnE5UkxrWjRZSlZPK0ZwYzAyMGJ5ZzNSY2J4M083dFBFSjVTcWdr?= =?utf-8?B?S0p6TVdrSWlpT3RoakZyQ2tPL3BUaWE5SktWRUovbWJvSktlYnNacEx6bHI3?= =?utf-8?B?Tkhwa1cxeDZjSnF0Q1ZKaVBoNXpWajVJa1p6Y1hDeE81VE4wQnI0WU5EZVdy?= =?utf-8?B?OUx1eUxKVGtNN0xhbDBUTjJ4SUlBQzBRVFRhZmZvNGVwdGlLOVo1dDIxSTJY?= =?utf-8?B?L0VKRzBwcGl3cW9OckdiaUoxelltYjlvK25PaXN1ZUFhOUVVWHNQTjFKRmJv?= =?utf-8?B?NnRLN25MQlYrY0RCaFhjSFRIcDAzYllZZ1BkNWhJSk9pY09MK0ZxcmJ1TE1m?= =?utf-8?B?NjFmcHBzemdXRjFmTXZYMGlFSkx1djB3ZDhJQ2lubWVBcnlRQXZ0U0NsMkYv?= =?utf-8?B?d0QwYXY0ZUg2eUdtS3VreWNRZHBvbDhPd2JJZGFVeUgvVTJhZ0kxeXJySW15?= =?utf-8?B?ZENtYWN5c1ZJcURtTTBkU1JWbVdSd0cxL28xaGVvVWFNRG5FRldOM2xLQTJO?= =?utf-8?B?YWNsSExod0lTMkM3WHZyYVZZajhSZ2Fqa29ReUNKcWpYRGdVMkhOR0Q1V2dZ?= =?utf-8?B?MHRZQUNCY203RWZrWEx3YXFGbC9YWjhHdkgyaFBPbTRMVHhXY1BmMG1JWVlx?= =?utf-8?B?VElhNlcyTVc2WVRYZEhwblFqU2hIbVk2VU9GNmlyeXhhMjRWUnorWXlWOWsr?= =?utf-8?B?bSt4ZzFPTkp1SjJ0eGdOblZLWVdhVER4UU95VHBxSHdpeVNsRGFvaGRSUkdz?= =?utf-8?B?VTlPWEJVeE1lcm1kT0ZGMHhoT29xUi9yOHlSWVVsUVdLTlUxOFllMmpiaS9j?= =?utf-8?B?Sy93SXVGNGdkYmVuMXR0NWhjSlpVaG9CUTgzaHU1V25QVzZXZWErNkt2S3Nl?= =?utf-8?B?aXg1RjNPanNCOUprMEYrdVpzcXJNaENCSnBwNkZCRGFHajlVT2gyMVRibVdL?= =?utf-8?B?K2oyS0pDS0h1QWxBTkswUkhndHY1T0R4MVFUK2Vqb0x2NHJDdmtORVhCajFG?= =?utf-8?B?UVRwTy9Demg2bE9tZmlCdDBpU1l4d1A0Z0duVVBISzEwaDZuR0xRbjVFbmtt?= =?utf-8?B?d0VCcm16YU1DY0hEMmpONzhSNUloL3h1Q25FQkZUQTQrcG9URzFKUndnRFQv?= =?utf-8?B?RFRmZEc3Q3VqRGI0ZWRpVVRITzhwdFdVczhPUTR3V1JyNnc3UU5qK09KK1Ji?= =?utf-8?B?dmt4UlVRRHQreUZTQkVjQ3g4QzRoSDN2d0VzdnQ1bVFXd1JvYW9Kb0VXQVBn?= =?utf-8?B?aGY4UmZ2NmN6K2VPem9hTExuMjlzT0FHTUFUT0d1bVB1MTZiRE9sRGo0L1ZZ?= =?utf-8?B?SDU3d1dVMTlpM1RDVVlaNXB4bnQxN1l0Y21iTklZdVkrNWt6ZldKUWRVdHFR?= =?utf-8?B?NjFxQ3FUV2d4TElhRjFlV2JyYW5abFVpVS9jYzJSeitQSFFVZEJuWGtHaTcw?= =?utf-8?B?RzcwVkhQVHdPVFpxUE5uVTFHbnZQNUNiWUJhU0FSdGo4Z0d4c1owTGFhbERV?= =?utf-8?B?SGJRQXdQTEFMTWlIbTJuN1NSRWplOSs4QU9IenVhSWdnNWNPaCtBcWd1S3o1?= =?utf-8?B?OWo2emdXNlREeWUraUJRYnExVHZ4V2F0QURlL3Q2eDZyMFdNMEw0anN2RzZF?= =?utf-8?B?d3c0UTdtWEVldmMrR01oNUlkZ2szNitIcmEwakxtc2l4QXQzN2FKN1pYdEll?= =?utf-8?B?Y1ZBUks2TWN0QUNaWWpzdlc0TGhlbFNDZ25EYitEeEdYV1UwSENmNFQwNzll?= =?utf-8?B?OFNxNXl2M09ZYVVRS09UbDBTU2EweEZHLzJNWTFRb2V6ZHo0M2JuUGdMUENH?= =?utf-8?B?bEY1NVlYQmZDQjI2NkpJb09EcTNYTGk4ZEwxZy9UOW90cXJCTUdyQWF1Y2xB?= =?utf-8?B?Rk4wZC9iNTRzMy9MVnNmb3ZMMWZZMW16Yy85ZXJFTXRBT1hIcnBwdnpEWlda?= =?utf-8?B?VVNsbU44RktocVVnWFovVnVJNitKMVFSNVZ0SFpvVXoyRjl0cVJvbFUzM0lT?= =?utf-8?B?dXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Cvh4TvivdRo/jZkbTbTgxht4J2EMF8ks4U+s54++VvOdipROvnUFs1C/Pu/5u+8xGIKD/enMkJiRUXR1+b9CC7MmYB+2E+ZFh3hSi9mfkuZGsy32P8n6aUfXE4qNjbTMeMAWw86VtvRlPbEOmr1OpZall1i7sDdu3fqJp2ldEJrLo7ReZy3e6SwTN4QhtmreTgvaNSOm6et8/HOpdIBW/L9UWHfoRQU6nBMY3ec0WOpBDMHkpJ1Tha4NlGrfAADn/IN+Y2LF84RqjwJ3yqONi1gMSpcHM9MemikEmx+1Gw+8GuTzRBESdDTntntErqGvXwHsD9TzPj8zdL0mdIFoO7Kha9Vv/xUJmLkzSRaICC6qLbK322DeC/RTZ90BAZA8zVC9braOJ8qz4ZpIhd4AUT9QP/Pp5WJdGSRFzS3yL/QwD9DLdvLX/UYvvQoT00pnbrpka+4/4/05LDc2FnHjeGNxsjhKwv0vDN2h7HlOtWeyqQ7ldYH12Xs3S2NzeTmboJzt6vg26IFOrBjTG/1qYGhu4Rt8osiZ5emAQas8NHib5IXgEVbeFS0nXEgRCBXE6m99lx8mK0q+3H78/ULqpfXyAdhvJM0OJ1AoHSYVqHQmOH8LUSw7RwtS9P2XTJDmPDMTCbAAo52MVU41BomHpL6TiRdICBlzlItpe1cJqD97fm7Ek/KbZv68m2MD7pEe8SFQmekI1NHKHbLRv+yZPebYRKXJn0o+oJGKJn36kCzobQtvOaTgHNRhzrtg2hxVkoCo3LljAyIgj12WZXhpNqO+1pXKVe2UP55GdnjIQEVinbDcPf2aTpgZyx2g/vqysd7yUB7BQxMkNPLnzjLB0VDZCcbqsi1/9fVcciGdcmw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d93dea6-73d9-490c-538b-08db05355446 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 15:51:21.1482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2qeDWBm9jzhLkxFKZmCKL3xI8ZahwYBoeyAG46nB8lvc7LzK9smz5LhisUPEpojm28Ddbyc5BypRzA93RC0emPTxjs1Us8EfLvUNXJ/Fv+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6008 On 12/01/2023 4:52 pm, Jan Beulich wrote: > (re-sending with REST on Cc, as requested at the community call) > > At present we use a mix of Makefile and Kconfig driven capability checks for > tool chain components involved in the building of the hypervisor. What approach > is used where is in some part a result of the relatively late introduction of > Kconfig into the build system, but in other places also simply a result of > different taste of different contributors. Switching to a uniform model, > however, has drawbacks as well: > - A uniformly Makefile based model is not in line with Linux, where Kconfig is > actually coming from (at least as far as we're concerned; there may be > earlier origins). This model is also being disliked by some community > members. > - A uniformly Kconfig based model suffers from a weakness of Kconfig in that > dependent options are silently turned off when dependencies aren't met. This is deliberate behaviour of Kconfig, and not related to toolchain dependences. Exactly the same thing happens for a change that edits a regular dependency, or inserts/removes an option. > This > has the undesirable effect that a carefully crafted .config may be silently > converted to one with features turned off which were intended to be on. The Makefile model does exactly the same.  It *will* check feature availability of the toolchain, and *will* modify code generation as a result. The programmer just doesn't get to see this because there's no written record of it happening when it's not encoded in Kconfig. > While this could be deemed expected behavior when a dependency is also an > option which was selected by the person configuring the hypervisor, it > certainly can be surprising when the dependency is an auto-detected tool > chain capability. Furthermore there's no automatic re-running of kconfig if > any part of the tool chain changed. (Despite knowing of this in principle, > I've still been hit by this more than once in the past: If one rebuilds a > tree which wasn't touched for a while, and if some time has already passed > since the updating to the newer component, one may not immediately make the > connection.) > > Therefore I'd like to propose that we use an intermediate model: Detected tool > chain capabilities (and alike) may only be used to control optimization (i.e. > including their use as dependencies for optimization controls) and to establish > the defaults of options. They may not be used to control functionality, i.e. > they may in particular not be specified as a dependency of an option controlling > functionality. This way unless defaults were overridden things will build, and > non-default settings will be honored (albeit potentially resulting in a build > failure). > > For example > > config AS_VMX > def_bool $(as-instr,vmcall) > > would be okay (as long as we have fallback code to deal with the case of too > old an assembler; raising the baseline there is a separate topic), but instead > of what we have currently > > config XEN_SHSTK > bool "Supervisor Shadow Stacks" > default HAS_AS_CET_SS Yes.  This is very intentional, and is AFAICT an example of something which cannot be encoded in the existing Makefile scheme. There is a tonne of stuff we can only do with proper toolchain support.  CET (both shstk, and ibt) are examples, and plenty more to come, where playing around with .byte in older toolchains simply will not work. There are also plenty of cases where it would be technically possible, but the cost of doing so is so large that it's not going to happen. > would be the way to go. > > It was additionally suggested that, for a better user experience, unmet > dependencies which are known to result in build failures (which at times may be > hard to associate back with the original cause) would be re-checked by Makefile > based logic, leading to an early build failure with a comprehensible error > message. Personally I'd prefer this to be just warnings (first and foremost to > avoid failing the build just because of a broken or stale check), but I can see > that they might be overlooked when there's a lot of other output. In any event > we may want to try to figure an approach which would make sufficiently sure that > Makefile and Kconfig checks don't go out of sync. This is a brand new feature request.  But it looks like you're trying to reinvent ./configure without using ./configure. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 02 16:08:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 16:08:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488850.757120 (Exim 4.92) (envelope-from ) id 1pNc7p-0000D5-Br; Thu, 02 Feb 2023 16:07:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488850.757120; Thu, 02 Feb 2023 16:07:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNc7p-0000Cy-7V; Thu, 02 Feb 2023 16:07:49 +0000 Received: by outflank-mailman (input) for mailman id 488850; Thu, 02 Feb 2023 16:07:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNc7n-0000Co-K5; Thu, 02 Feb 2023 16:07:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNc7n-0007tc-Fr; Thu, 02 Feb 2023 16:07:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNc7n-0005oH-3p; Thu, 02 Feb 2023 16:07:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNc7n-0003vo-3I; Thu, 02 Feb 2023 16:07:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A5YxtgVBQFbEamuD1P/I73gWVCvlT0X6nK2UcgADQFM=; b=Fj7/xUe7irN2f4bxOSMfln5d/2 URXuLDQsvX61pioQOwQqkzW6uHvJy+PJPiM8CetnPbr06PMU32KtpOGTDlJnIbRyArdLp/KtHYAql pxnKsGZEFB3aJ18M5XI0RmySRHK4Rcd8zhaXQYuWVYBaodvHBGBjewq9C+TiUIhLDQsU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176335: trouble: blocked/broken/pass X-Osstest-Failures: xen-unstable-smoke:build-armhf::broken:regression xen-unstable-smoke:build-armhf:host-install(4):broken:regression xen-unstable-smoke:build-armhf:syslog-server:running:regression xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable-smoke:build-armhf:capture-logs:broken:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 16:07:47 +0000 flight 176335 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176335/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176151 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176151 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 7 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf broken build-amd64-libvirt pass test-armhf-armhf-xl blocked test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. ------------------------------------------------------------ commit 78e93e6e57c218eead498a664785f414bcb12460 Author: Ayan Kumar Halder Date: Wed Jan 25 11:21:31 2023 +0000 xen/arm: Probe the load/entry point address of an uImage correctly Currently, kernel_uimage_probe() does not read the load/entry point address set in the uImge header. Thus, info->zimage.start is 0 (default value). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach would be to read "uimage.load" and set info->zimage.start. This will ensure that the binary is loaded at the correct address. Also, read "uimage.ep" and set info->entry (ie kernel entry address). If user provides load address (ie "uimage.load") as 0x0, then the image is treated as position independent executable. Xen can load such an image at any address it considers appropriate. A position independent executable cannot have a fixed entry point address. This behavior is applicable for both arm32 and arm64 platforms. Earlier for arm32 and arm64 platforms, Xen was ignoring the load and entry point address set in the uImage header. With this commit, Xen will use them. This makes the behavior of Xen consistent with uboot for uimage headers. Users who want to use Xen with statically partitioned domains, can provide non zero load address and entry address for the dom0/domU kernel. It is required that the load and entry address provided must be within the memory region allocated by Xen. A deviation from uboot behaviour is that we consider load address == 0x0, to denote that the image supports position independent execution. This is to make the behavior consistent across uImage and zImage. Signed-off-by: Ayan Kumar Halder [stefano: minor doc improvement] Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 16:29:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 16:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488858.757131 (Exim 4.92) (envelope-from ) id 1pNcSA-0003XM-2u; Thu, 02 Feb 2023 16:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488858.757131; Thu, 02 Feb 2023 16:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNcS9-0003XF-VK; Thu, 02 Feb 2023 16:28:49 +0000 Received: by outflank-mailman (input) for mailman id 488858; Thu, 02 Feb 2023 16:28:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNcS8-0003X9-W8 for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 16:28:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9bd4f1e-a316-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 17:28:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAC0461BE0; Thu, 2 Feb 2023 16:28:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B729AC433EF; Thu, 2 Feb 2023 16:28:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9bd4f1e-a316-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675355324; bh=vtD2jzguhzCVkXCD7bfBMkIilEwFWfya//AvKlmwY0I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rCVgvkQnmNmcR4PhhmrhGhiSlnMKjyNb/Ap5GZI+hmnRfsZ/aPO3rLmsNpKaml9D0 XWr50Xfpqjt7fRJUCNQOaR+izO8Q1dfo81aLWXnVRBup6D32OYhToBte07XP+Fjylo UAPYZa74c3c4G1oBxO1DelFvi8HSnr/dVquOSU+az78imh8JrCX1J4qVJalndBZjxr 0FKCGPZ0XMQBL0CQGeNrKrBt1MeVN20mrnegegNN9ETgLCMQYLuayM83+6xq1uZtgb fP4zBj9iUfiousknNUKHA72qCs1OCOaA9Y2Lpd646ZVgxyhBUpqZCb6VMXUV/XprSK 1vSZLjfOOpE4A== Date: Thu, 2 Feb 2023 08:28:41 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: paul@xen.org cc: Vikram Garhwal , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org, Peter Maydell , Stefano Stabellini , Anthony Perard , "open list:ARM TCG CPUs" Subject: Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine In-Reply-To: <5b7c223a-2c96-4bd2-7150-79a56281dd57@xen.org> Message-ID: References: <20230131225149.14764-1-vikram.garhwal@amd.com> <20230131225149.14764-10-vikram.garhwal@amd.com> <179d773b-2634-b52b-8836-8d8f882e1495@xen.org> <3e205146-5113-861d-ef39-c463257b54a1@amd.com> <5b7c223a-2c96-4bd2-7150-79a56281dd57@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1274086482-1675355324=:132504" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1274086482-1675355324=:132504 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 2 Feb 2023, Paul Durrant wrote: > On 01/02/2023 18:22, Vikram Garhwal wrote: > > Hi Paul, > > > > Thanks for reviewing this and other patches in series. > > > > Please see my reply below. > > > > On 2/1/23 12:30 AM, Paul Durrant wrote: > > > On 31/01/2023 22:51, Vikram Garhwal wrote: > > > > Add a new machine xenpvh which creates a IOREQ server to > > > > register/connect with > > > > Xen Hypervisor. > > > > > > > > > > Is this really the right way? Is it not possible to do the Xen > > > initialization (including ioreq server registration) off the back of the > > > accelerator init (i.e. AccelOpsClass ops_init function), which seems like > > > the right place to do it now that it's no longer architecture specific. > > > > > There are few other machines using the "accel=xen" option and few of these > > machines aren't using IOREQ and other Xen related initialization. Example: > > /xenpv/ machine under /hw/xenpv/xen_machine_pv.c /and few other machines > > under /hw/i386/pc_piix.c//. > > Ok. TBH the concept of 'accel=xen' is probably somewhat broken then. (QEMU > isn't even running the VM in question, so how can it be accelerated?). Maybe > abstract machine types really are the right way then. Yes, it doesn't quite match QEMU as device model for Xen. However, as an internal API in QEMU it can be useful to Xen as well occasionally. It is just that in this specific case it doesn't look like it is the right fit. > > /So, that's//why we moved the IOREQ and other common initialization parts in > > hw/xen/xen-hvm-common.c and call them as needed for the particular machine. > > > > @stefano, just checking if you want to add any other suggestion here. > > > > >   Paul > > > > --8323329-1274086482-1675355324=:132504-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 16:51:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 16:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488866.757142 (Exim 4.92) (envelope-from ) id 1pNco7-0007lB-2B; Thu, 02 Feb 2023 16:51:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488866.757142; Thu, 02 Feb 2023 16:51:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNco6-0007l4-Uu; Thu, 02 Feb 2023 16:51:30 +0000 Received: by outflank-mailman (input) for mailman id 488866; Thu, 02 Feb 2023 16:50:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNcnK-0007jK-D7 for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 16:50:42 +0000 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b93cdf18-a319-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 17:50:40 +0100 (CET) Received: by mail-qt1-f173.google.com with SMTP id w3so2518250qts.7 for ; Thu, 02 Feb 2023 08:50:40 -0800 (PST) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id t9-20020a05620a034900b0071eddd3bebbsm31687qkm.81.2023.02.02.08.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 08:50:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b93cdf18-a319-11ed-b63b-5f92e7d2e73a X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1tztcBchRZ+ahQ+Rv8slGEZ3rlEReGoboay+wBElNpk=; b=X620MAly2Vy6OEgASJxhu7lIpwNz9UWg8EIk8uzA7zbeMqdfA2mZCLmYVnsSCfsnvV +o3IrQG1ExVx6eS4nQy8hqZvcmNpIsOMmwavleu0cnEWmNiIGgisSD8nkDXd2AuwSI73 bTWUpNWpbUae6qxXHup06Zlcl+9sEE32aihqiK8TgnoY/AGZfafM9UWOg+WNKNPgOVJC 6xjTs7FBzZXgair6hGi6r7IAXzLltUm+unmjV4RostwRcBAGGuNzFN35yGG3OXoFisgM TYS36YcqW/8hz6m8mhQh17pUc51jpSE2ISvQpr99HKf33wC4DlviktRoksRHMF6jAxk/ mKhw== X-Gm-Message-State: AO0yUKUmwCgaexzJVBY058Lmz2OOHSvjXLdtAB4qFjA14+abNyLCzxjE KgMYmQ1Zuguy/nq58XzmsqO/ X-Google-Smtp-Source: AK7set+4Pyeb5ompgmUg0JYUv54bCb2ceknHgU0XW/UAy594tQAOCFstY5279x2+bA/W3Ae7xhvLGQ== X-Received: by 2002:a05:622a:1788:b0:3b8:2ea9:a093 with SMTP id s8-20020a05622a178800b003b82ea9a093mr13141578qtk.1.1675356639078; Thu, 02 Feb 2023 08:50:39 -0800 (PST) Date: Thu, 2 Feb 2023 11:50:37 -0500 From: Mike Snitzer To: Demi Marie Obenour Cc: Jens Axboe , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Alasdair Kergon , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230126033358.1880-1-demi@invisiblethingslab.com> On Wed, Jan 25 2023 at 10:33P -0500, Demi Marie Obenour wrote: > This work aims to allow userspace to create and destroy block devices > in a race-free and leak-free way, "race-free and leak-free way" implies there both races and leaks in existing code. You're making claims that are likely very specific to your Xen use-case. Please explain more carefully. > and to allow them to be exposed to > other Xen VMs via blkback without leaks or races. It’s marked as RFC > for a few reasons: > > - The code has been only lightly tested. It might be unstable or > insecure. > > - The DM_DEV_CREATE ioctl gains a new flag. Unknown flags were > previously ignored, so this could theoretically break buggy userspace > tools. Not seeing a reason that type of DM change is needed. If you feel strongly about it send a separate patch and we can discuss it. > - I have no idea if I got the block device reference counting and > locking correct. Your headers and justifcation for this line of work are really way too terse. Please take the time to clearly make the case for your changes in both the patch headers and code. Mike From xen-devel-bounces@lists.xenproject.org Thu Feb 02 17:13:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 17:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488875.757153 (Exim 4.92) (envelope-from ) id 1pNd9j-0002kQ-S0; Thu, 02 Feb 2023 17:13:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488875.757153; Thu, 02 Feb 2023 17:13:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNd9j-0002kJ-PK; Thu, 02 Feb 2023 17:13:51 +0000 Received: by outflank-mailman (input) for mailman id 488875; Thu, 02 Feb 2023 17:13:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNd9j-0002kD-6r for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 17:13:51 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f426a6fb-a31c-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 18:13:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f426a6fb-a31c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675358029; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fFiWgEXEsgneyrj55bhkya8ez9VyVvITW6NA9kQZf4U=; b=MEuTu4Gj5kBB8kWrAdg4tbpelVsDTzxxsEI/4SFx9iGuIT40ae0ZFiLv PJ8d2Qr8slC1WWUcAP954MFPm2XVBKdTje0X6mWGKamqJ5cjSB83AsCLP vVQQfEgbyh6DGaxS0yfEYbd+/CZmA3Ui9gkXbhC+8x5QqNz+GR/7ZJD5k M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 94276427 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6euqAKphfD5ZWn7e2l+dr6MPP7heBmIdZRIvgKrLsJaIsI4StFCzt garIBmCO/2DZmWgeY93aoS18xkF656GzNdrHQBqpSszFilD85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyNNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGstVCKhjMWV+7/lablQheUDDe6zOapK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVypUiTpaMt7y7wxQ133LzFO9vJYN2aA85Smy50o 0qXoz6mXE1Aa7RzzxKh0mjri87Cgx/bAoAdEreH5rlFkFOqkzl75Bo+CgLg/KjRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS9wWl2qfSpQGDCQA5oiVpMYJ88pVsHHpzi wHPxomybdByjFGLYSm9zIW2phSRAiVLDj8+Zg4kbCxd5vC29enfkSnzZtpkFae0iPj8Fjfx3 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWG2TaD/LF7rVxBHkJPmqgOiAyS3G8zbq45lcbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+Som/Ca6INoUeOcIZmOq7EMZGPB744owQuBJ0zfFX1 WmzLq5A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI503P7FZqX1bMEe1tGALXPogEAFas/F29H yB3a5HblH2ykYTWPkHqzGLkBQtScyhmVcqs9JM/myzqClMOJVzNwsT5mdsJE7GJVYwM/gsU1 hlRgnNl9Wc= IronPort-HdrOrdr: A9a23:n+zQTaMS8lK3wcBcTv6jsMiBIKoaSvp037Dk7TEJdfU1SL3hqy nKpp4mPHDP+VMssR0b6LK90ey7MBDhHP1OgLX5X43SODUO0VHAROpfBMnZowEIcBeOkdK1u5 0QFZSWy+edMbG5t6vHCcWDfOrICePozJyV X-IronPort-AV: E=Sophos;i="5.97,268,1669093200"; d="scan'208";a="94276427" From: Bernhard Kaindl To: , CC: Wei Liu , Andrew Cooper , "Anthony PERARD" Subject: [XEN PATCH] tools/xenmon: Fix xenmon.py for with python3.x Date: Thu, 2 Feb 2023 18:13:19 +0100 Message-ID: <20230202171319.285548-1-bernhard.kaindl@citrix.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Fixes for Py3: * class Delayed(): file not defined; also an error for pylint -E * Inconsistent use of tabs and spaces for indentation (in one block) Signed-off-by: Bernhard Kaindl --- tools/xenmon/xenmon.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xenmon/xenmon.py b/tools/xenmon/xenmon.py index 175eacd2cb..3a81e43edf 100644 --- a/tools/xenmon/xenmon.py +++ b/tools/xenmon/xenmon.py @@ -533,7 +533,7 @@ def show_livestats(cpu): # simple functions to allow initialization of log files without actually # physically creating files that are never used; only on the first real # write does the file get created -class Delayed(file): +class Delayed(): def __init__(self, filename, mode): self.filename = filename self.saved_mode = mode @@ -677,8 +677,8 @@ def main(): if os.uname()[0] == "SunOS": xenbaked_cmd = "/usr/lib/xenbaked" - stop_cmd = "/usr/bin/pkill -INT -z global xenbaked" - kill_cmd = "/usr/bin/pkill -KILL -z global xenbaked" + stop_cmd = "/usr/bin/pkill -INT -z global xenbaked" + kill_cmd = "/usr/bin/pkill -KILL -z global xenbaked" else: # assumes that xenbaked is in your path xenbaked_cmd = "xenbaked" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 02 17:19:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 17:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488881.757164 (Exim 4.92) (envelope-from ) id 1pNdEl-0003nO-Es; Thu, 02 Feb 2023 17:19:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488881.757164; Thu, 02 Feb 2023 17:19:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdEl-0003nH-Bq; Thu, 02 Feb 2023 17:19:03 +0000 Received: by outflank-mailman (input) for mailman id 488881; Thu, 02 Feb 2023 17:19:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdEk-0003nB-LX for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 17:19:02 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae2141a9-a31d-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 18:19:00 +0100 (CET) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Feb 2023 12:18:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6437.namprd03.prod.outlook.com (2603:10b6:a03:398::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Thu, 2 Feb 2023 17:18:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 17:18:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae2141a9-a31d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675358341; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=om4Mispae7qfbeGGYaLA9HONW4UBMOuq3jndDWWwPrM=; b=WzFGHOF32WgJqtywk0GAU5AjjFvOfDP5GR+Tc/Kc276iU7DErOjOitYN JjpTT7Jgk/r4vQChZs8bC5rl3rp9TmqXmJO1iyhFYd4lQ0jW3hQVNrOfs 7tEYdYjAILcWFBE0mT7u/a/dGiJXc1Gx0acGewqmVbbvV/meZvnRre0gR Q=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 94277445 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pWJI/aJyoGNY9qQmFE+RwJQlxSXFcZb7ZxGr2PjKsXjdYENS1D0Bz mQXC2qOPvyNYmb1L4xyPdu3/UsBsMLWyYVrHlNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5ARkPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5GClF+7 tohEwosYyy5h7roz4uxYbdj05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzH+hB91OSODQGvhCmX+6+n1QLgUtTlL8pvXj2h+4eIt5N BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz FDhoj/yLTlmsbnQQnXE8L6R9Gq2IXJMcjFEYjIYRwwY5dWluJs0kh/EUtdkFuiyk8HxHjbzh TuNqUDSmokusCLC7I3jlXivvt5mjsOhotIdjukPYl+Y0w== IronPort-HdrOrdr: A9a23:ciaej6iDxLzw3f7vB3ggNxua5nBQXuUji2hC6mlwRA09TyVXrb HWoB17726NtN91YhsdcL+7Scy9qB/nhPxICMwqTNSftWrd2VdATrsSibcKqgeIc0bDH6xmtZ uIGJIOb+EYY2IK6/oSIzPVLz/j+rS6GWyT6ts2Bk0CcT1X X-IronPort-AV: E=Sophos;i="5.97,268,1669093200"; d="scan'208";a="94277445" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akixs6SIItLMZfVwWyzRyi4XtGFIJwx2A0myaXni/AnV0RbAuLyiTZLYQGjgtyFbB93NLHTRtZGcYvAov6EzN+N2iF3AXNUprg7WbtqOcYWICB85Oc+zIo+kNFGmik48zFj/FFiIVLvwfK6TccSkL961o+jJSRv68iNzBVajtd3bCaGnFpWG6iyntquyKGpYWSTCFyUn7BimL3wG67GI/oHFuQlialDY1bRr0opSVrKQApzp6HaZmKfsu7BqqkdtU0Nydv+H21FL3e1LKOcTUxfgLKGjpj9foDvFXEI/QTu7IGmtUPEQKHE1BSNhKiUftbx6QIyM1cDFPMUHS9v4lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=om4Mispae7qfbeGGYaLA9HONW4UBMOuq3jndDWWwPrM=; b=hBTwK9wd4dPoFpNgx9aEhzPZPvMg9W7ABFiBBBRXPQxiZhmmEDIHwuKdBTMrpgA+KzuFqEgFCuDKa0+sWM/qif9AsgYcDiSgz9HIjl3ijI4NfS3Pkx+3hlVtf3hSkXylHA8U4u6SfCh3cjujjp73Uw8yAMkc4rPFfL7wj5Z4cS/xgIy7+8uKWQ8L/8OsxVBo3+mfzicFhFuorgc7RIEKVwApagQLV8zNB227Cfj4Yy1E4UDsqgyiih1DwQRUfS1eD0wReE6qsH9cBRxYzu7Recx8+bj2n3G3IrQzKhvmH7pMekXEHen+t2nF20Xq/t+tOWd4dipH2AAx6EaBOo5FNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=om4Mispae7qfbeGGYaLA9HONW4UBMOuq3jndDWWwPrM=; b=JUuKj+O8l7VLgglK5h2dZTBnCGbbh6gCOLTPQfKM9qQvNJxhyEW5ZosF+o2fskCWF6ZBZt3L3RVcztyxr0Zj+SXTUUTX3Nn9PcHkSRsCb0TH9jx1AK/qMLEwDqgbFW9ahvD4Mr+UmiP0ZejlxrM7epNEM8H+zebfj1GbcNXdPrM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3412a0d5-899b-4db8-b6bd-9c532e9f84eb@citrix.com> Date: Thu, 2 Feb 2023 17:18:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] tools/xenmon: Fix xenmon.py for with python3.x Content-Language: en-GB To: Bernhard Kaindl , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230202171319.285548-1-bernhard.kaindl@citrix.com> From: Andrew Cooper In-Reply-To: <20230202171319.285548-1-bernhard.kaindl@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0678.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6437:EE_ X-MS-Office365-Filtering-Correlation-Id: d1fc4b12-e3c4-43c8-6ffc-08db054190d9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +CZ7MrYmk4r/88MJxnT7VgZ7Z9nb3QC2rD6J77wOO4S7BUpa3CI8w81k+RjnLgK6usVEOe/3LA2GccEfmW+bguSZzf3vzbJ2cZejRARm5g9tgkx3junazWi/ME6YoQ/aqyHfrToairh4Y9T6uSJHpmLQrS8puS6f9RZ5gQ4G9eNiv27D06WO9frcUHQoL9jhSTxLYsfPOatfSxGziKgkS9xsvPhaWjCXanoQcDpmCGn6A8LAepnr+4HUVfKYv2l5s+j1clfGvpEkAAHbLtyAYRxJJ9978fUbR4QHN/Z1YcZcbpMmfIGUGEY2Egs2fSpECtB+4SBc88QxhzKIAvdBO/sJxKwXXkr2ex/Zruyx6fRGgGMd7SW+d1687qF3gb9t9U9MSW4K/BJbgy1Tas3Z3h/AQxqVW1PU4HA9lRqrYyGVSBd/3wRW9ILtExeMIb0CEAKF1YkBTKno4nnCEsl9svpC9IVEa8KwTx4lnyuF82RCAHOW3j4A6crkOjgTfcjycoPfCREYikIx/82oos89ZIMAps5FKArvrw92C25vp9+MrO6/f/DCoSTzty2TwzBo5RZ5qAEAvcq79ZG8uO2xVw8tZpCbteYQZYjgEDOGC36CIznQ93VR/RQPQGN+JX6pRskw962ccNtENcjwHoLgyUWkv0t/B4FGou0Hb47LypE1pknYitw0BP49aRRknzrDCFNHhhIyk28smDwFOCKCTMJ/R4jUyEovO9I1W/lFSv8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(451199018)(316002)(36756003)(186003)(2616005)(38100700002)(82960400001)(6512007)(26005)(83380400001)(5660300002)(54906003)(53546011)(6666004)(107886003)(2906002)(4744005)(6506007)(66556008)(478600001)(6486002)(86362001)(66946007)(31696002)(66476007)(8676002)(41300700001)(8936002)(31686004)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUpXelNubzNBQnRRMWUwczZjMkhIQisrV25QVDh2cmNkZ1VQQVZqYUc1eTZ3?= =?utf-8?B?MnFIUStoem9MSVpIQ3E1eEJQWWgxSGdncy9jcTBHTFlLMzZwM242VXV4MklZ?= =?utf-8?B?cDNUZjJNdklqdHpmODRwREU2MDBnRi9COGZEellQbE5MTFBhMzA3b1hUU3F1?= =?utf-8?B?UXMvMDczMW5SMXlRdUdTQ051MXVjSEJJM3UxNTZXWlVad0l3eFZJNkRiK0Mr?= =?utf-8?B?SCtjeDdReURiKzlMNlRPSGFJTW53L3VNcU9zdlUvQlYwaHhUM29oVkZKaS9p?= =?utf-8?B?Z0VmSXdEb21wQkJOWU9CajlqbG44dmc0ZFBxQ1VPUUFKQ2pTQ1NnK1ZncXNw?= =?utf-8?B?Z2Rvam5NelB6UHN2M2loL1g3QXpYV0I1dUU2YkcwNXF0RXduWGdBc2hxS0JT?= =?utf-8?B?SFQvaXFGQko1RHBEclNKaEM1RFJ0UlVpdWVrSDNvUGhCa2QrWkk4U01SaFRh?= =?utf-8?B?Y2EzWG1uS0pkakhNM3h2MmxZNWFVTmNCNUNkR1h0UEhCUUpEeEp4Tm9TWW5M?= =?utf-8?B?T3JEWVJVNk5RNkdOWCsrdzlwTjNEaVJnQ3JhWTZ5SnRlQVlUZGRYbVp0ZUZK?= =?utf-8?B?UmVJbHNsRUhTOHdjSnJySm5OOEY2bEFpNzZMR2xFNy9EY1VlODVZM3YzVXRC?= =?utf-8?B?WWxMV09kUVZRTGZEK0FsT0Q5bzhONXgzK0ZmbkhPWUFIcHhCNDh6aGY4MThJ?= =?utf-8?B?ekdGb3ZKYUxBZEZTdTkwZHZLUThGWjRuWDNhS09mR2dDd2lhRm5JU3hKNWx3?= =?utf-8?B?U3dJTW13REJQMi9LSDI1LzQxZTZmYVBOVXp1TmtqKzFwUEEycU42bG94TmQ1?= =?utf-8?B?OUVNTFdXRG1zRUtNVUxQRTZvNzIwMEdhbm44d3d1Mm4yd1Z4NkZHdjdncHZQ?= =?utf-8?B?SmVBZ2hSK3pQeWcydDVoSjlEc3g5YUNqTG9lQnhhOTRydDlNa2JwQWxVUUN3?= =?utf-8?B?cFNvYndoMFJWd0dXZGt3RWV6OW15MS9zcGhMUmdMVEFwNC92VUFoaUFUKzBP?= =?utf-8?B?WGhMcldGQy9wK3k3RndDNDJiY0IxWHlVdGJlOERRMFFUSGdkMzA5ejc4VktK?= =?utf-8?B?OTdnMk5uYitqY1JmOUx6aXpua0wwZnlvemthY2MzanhWUzJrbm5DNGV2Vngx?= =?utf-8?B?UXJNMTdMVWp6UXVhSW1ZNjI0WkRxQkhMd3V5dGF0NjRWM0VwOFhuZVR5azJF?= =?utf-8?B?ZDFOZlVZc2R1eWxtelNEZnI4YllQcG42SEFIbjM2QUxDVTh5N3RncVV4cTh2?= =?utf-8?B?Z0swaDVQOE5kcm14MGVadkhiVUkwTlh3U0k4dGlhdjlMNmlCb1h0RGlncnky?= =?utf-8?B?b3U4RnlYZm1SbisxQ2xoWEJ2S3FweFdwc3ZNdzlDMW9WOGFHdWdYUElTaXM3?= =?utf-8?B?bWhRRkNjeEpHaDBNUGdKbTlubG1lektVYVRJVnZjY1I1MkJrNzhtMVFIVjcx?= =?utf-8?B?Vk5iUXI5K0doL0FFamp0bnNlVEtjcVpEOCt0bDZuMXNzMTRMWlFkelhsanF0?= =?utf-8?B?RzV4VHltRFc0am0vZlV0WkJ1ampSWlNveUhtR2IrZ0xzK2pTSlUzYjZKc3Fa?= =?utf-8?B?eEVTeFFtZjR5VFcvMkVmVnB4dUJ3YnphaktvRnc2RklWaGowQWxjU3dQSWVq?= =?utf-8?B?S2JuUXY5UXZ1MVcrTW5RV01URWp0Qkp6WmVRQ3A2NHJseVVSRThpTzRQdUZT?= =?utf-8?B?WTgyeTNjZmlHZlUwMC9hM1lhdUJaL0hPdnA5N0lYN29FeVhnaktiTURmYk1p?= =?utf-8?B?enl1YXBzdVlJTkNRdUFuVEIzZE02VFllSFFWRGErVnUzZzcrY1BWOW9xdGZa?= =?utf-8?B?RzhzbERRSGwvZm9nUkJYVzZZS2hHeUVUOEFBU0JIQlBHSjRicUExZjR4eDJD?= =?utf-8?B?Mk03VlNYMHJhZmthS0VzbnBhZXJBZFJKSDgzVVF1NXVwVE8xamVmN0JJaW9z?= =?utf-8?B?T1ZWT0dzZVNsUHptY1JIMVhodVVJUHhucnFRcVlWUEp3aThPWVpzRkd1V0pF?= =?utf-8?B?TW13VTFnUmhvZjlyZEk1a1IzYXJZQTFuUzl2K3BaVFlEaTk4elIrWkVWNVdx?= =?utf-8?B?a3lSQWlNZVNHSktsM04vMHJidXJVY1JiZnNNZUNCMnBMNlB5d1BST2dsTTdP?= =?utf-8?B?OUhsSGNpUm5mVkc4Mk43eDRZMUVSZ3hEZTFVY3VsTUY3bnhlT2l0TFlSNVNK?= =?utf-8?B?VHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: B/kWyU7iaQv3HTFEJQZum0hQfNf0+jMKTkb6cITXGoh/if9vmwSw0eoY5kyE9dOvJLJGPcKYHm47pM7NjY9fJWs4N3j3sUQ7aoby+7twkxuTICgTimgGRUINxmjIG91qtAR9z5yjHsobhlt1e68wzfTwi6dQJ/mI8xVACDI0d5YZreHF74IZHK/LFnES080NQmf5mPi6+WhlPuj+1M35Wo4rNf5c2OK1oEsu/w2w23PZ7zKJktF+s5bl92C6gBlU1/wsaFcN1hLWpJxRdZmoDoU3/8yrmSjmZQs+qBpc0PXR/UhsRKCMwVZAo4+htPFB+cpvKStzddbhcByaJDEal0Q5BARpXqzDJqYyNEXTOsp7339/Pddgnou3Llo30hHTUxUWtnmEi5dZcR5NRwzwxFxlbHfOO0NwNYcB1rQfYAuxh0IJAJdbIhlhKumLdXR3V6qtLKFPRIAPl+CfYviWNytL+CxdXRsQBrDdWqe0SACqfXBMOPpmNqGYywfezs+hdyUXPswLRoTHQ9qCHdUAU1/FUuvwitKFI0Zc0Jz1sNxwllUDvaZsiTQoqmrclArecl+kCzs+1jNFbrxy/cXOvFzxqyFmkkKQ7rzAt534c6td58tKhlDeeX5KS8WaqA5quyDRyP/50sI4Pvm1rRCWJTsOJSvEvGs4EOnEMIX2DzMz06oR3OnTBv1hw+BKWBiGjpPR8cp+BFs2NWPXF4QUhkzCbODwG7SJOzNOYIPCMyuuwwKSPi2+nbqrKerEuEVzC1NNKADuHSOBkt4GtZrJgTcskms1/BFoLc03ArQjy7U= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1fc4b12-e3c4-43c8-6ffc-08db054190d9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 17:18:56.7832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DMrrxGVTzsBJM9LnO35LGQu7Wbn3mowtGkxkyCwS5hqqRMxRtyXcifzlyHjG5ZKSTxITZCFq3b0NzV6tNR65sd8FY8RYanItF2pCA18qBc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6437 On 02/02/2023 5:13 pm, Bernhard Kaindl wrote: > Fixes for Py3: > * class Delayed(): file not defined; also an error for pylint -E > * Inconsistent use of tabs and spaces for indentation (in one block) > > Signed-off-by: Bernhard Kaindl Acked-by: Andrew Cooper I'll add this to my pending queue while staging is blocked. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 02 17:35:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 17:35:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488886.757175 (Exim 4.92) (envelope-from ) id 1pNdUG-0006aT-RB; Thu, 02 Feb 2023 17:35:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488886.757175; Thu, 02 Feb 2023 17:35:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdUG-0006aM-Nu; Thu, 02 Feb 2023 17:35:04 +0000 Received: by outflank-mailman (input) for mailman id 488886; Thu, 02 Feb 2023 17:35:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdUE-0006aE-Tl for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 17:35:02 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e98dcc94-a31f-11ed-b63b-5f92e7d2e73a; Thu, 02 Feb 2023 18:35:00 +0100 (CET) Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Feb 2023 12:34:56 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7061.namprd03.prod.outlook.com (2603:10b6:510:2be::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Thu, 2 Feb 2023 17:34:52 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 17:34:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e98dcc94-a31f-11ed-b63b-5f92e7d2e73a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675359299; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=D5f/0BLLLKz2PwhTm0VXKvlZl0Q4b67/vLFGb/u45kw=; b=JGPk09ip6gmxT4rr8hJdpxZahdtT3Yphk+FG9MW+ruA4EnwNlV5rhnAY cZMlDj0TdE/CVvkxBHcBJX669zNNlTndDGYVMmV3fXCmiZ326G6mRmWvU aWMGfj0xKsmlz5CDCMX8MJPYMLBdpcrQVOyse4/kUaX2EZgv3prxrdxuy 0=; X-IronPort-RemoteIP: 104.47.73.47 X-IronPort-MID: 95820048 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2niN5qpHI4izEx5MUHA9RafSWhJeBmIOZBIvgKrLsJaIsI4StFCzt garIBmFMq6OZWDxLt0gbIqx9E0F7cTdm9NkQFc/+3oyFS8W8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpAFc+E0/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyNNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAA8pTTak186c+ouUbbZygegACeTKOKpK7xmMzRmBZRonabbqZv2WoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+OrbIW9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzlpqQy2AHDroAVIBQaX1W7+NuBs1OzR+57N EFP1iEIgbdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQ10 neZktWvAiZg2IB5UlqY/7aQ6D+3Zy4cKDdeYTdeFVdapd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:obaiMq1I4Ix7IWc9xsUWcgqjBI0kLtp133Aq2lEZdPWaSL3gqy nOpoVi6faQslwssR4b6LW90cW7MBHhHNtOkOos1NSZPTUO2lHYSL2KhLGKq1bd8m/FltK1vp 0QFJSWZueAa2SSTvyX3OB7KbsdKRW8n5xATN2x80tQ X-IronPort-AV: E=Sophos;i="5.97,268,1669093200"; d="scan'208";a="95820048" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmV5Mi/P4xgv845sOxxf6TpliA6lKHr1fOIakMQGwbtp4ajhBN5Kpa8LPprvUhG18fMpcDFPRCVSaj4Wr6SYmB5icGf41aH6QK358pVgga6Bj035xXAsgAY2IViSMzHd1NqLpDixDGzA+uY5KAg69xZi5x9ODRBP+FNL3vKhASZPGwgc/nUO0yaf60tq5xf3m0QsFQbJGKvp0+NlLsDlulEgGCO59w0MC+1KLUrGbqwKRnbwlWpDoV5GPsX7stkLR49AMzTjoYCJXsQLHrKkyTBfVY+L6FxkEkkykxBwNg5isUyJWvDukZHoz9SSqLXLtJHBnxZ+xV/vI1UA9TIzcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D5f/0BLLLKz2PwhTm0VXKvlZl0Q4b67/vLFGb/u45kw=; b=P8et/lJfVatSOoDHQ3L5iwac+jqSrfMzsz5eilGY7NxGGYMwQM8+QOhs85qLT4N6bNH2H8GzLUXvKFVc2yj5kr4OOhwENJSwBPpa+mEwYEawbYaHibGfLQR8+UdmCgG7EvHXbCv2SS4PIaBtZ8R95Mb8/IPjeaJ4laQsMcHNB+T8L/CD8Pv3qoSQAqL6rBvBdFEypRheCgkD+2BCmgQbvLAPsB0U9GzmfWsoZyyl2xww9SrW6I8EDrZAggkILggq0VxknecfipksiUzEw4Rt/+kMFljg4cLnOA6aJVH6sINjo0rgsnfS1jnbHJFxNe4RyvrSs8VUjUUajl75VeaSbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D5f/0BLLLKz2PwhTm0VXKvlZl0Q4b67/vLFGb/u45kw=; b=F12V123AOEY7fg+jobL3VDFnDRkm0QbMmntMPXDA8f7azDIveX1rToQYDIMTTokqg/Sid8cQMP+mq9LVwWoNe8IBhNC07biWIpUgg+ULWbaY7NodmPRYxoV+Eci4q6LNKC8C9eYjU6M474zWY7BBITgp5cEZwAT1e1Zfu0akDjU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 2 Feb 2023 17:34:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] tools/xenmon: Fix xenmon.py for with python3.x Content-Language: en-GB From: Andrew Cooper To: Bernhard Kaindl , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230202171319.285548-1-bernhard.kaindl@citrix.com> <3412a0d5-899b-4db8-b6bd-9c532e9f84eb@citrix.com> In-Reply-To: <3412a0d5-899b-4db8-b6bd-9c532e9f84eb@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0040.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7061:EE_ X-MS-Office365-Filtering-Correlation-Id: 35cf062e-5206-4eeb-adc7-08db0543ca3c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gVluNiM3mdZ61TimdX9HXNKQgp30fJsv688VEGJ6pDWDgRq/sU6I160M1PXXQSmcbiZUpvu40nU4NzvfCfeGryJ0eAIKtTjg/phntT3/YkYzX/HMop+I/mTwNqddyoa67Ty3au6v8r3p2PhK26zhT3MppTjjAyOP4FWgBYnnM42Hy9G1A+ZQDuNZbfLeQDeNloDQS1OyMAjLcEkCcoiYBA2eIF+KSAG8WOBN5EzVZt2cBG/OIspeWblF2x8hgBzcsklbPFgdC4+JRUEcCpVwmjv6Ac+K0f2Ngh7PhVaayPlKKhCmjzvei24vgBkKLn3K8oZ5ZFss0Gm4uiWk9FwaHxnm6F2e3EoGm4LLiaioSzBuJFTyEgeOXayqAx4O2k5K0nn6EkylPDUAN/GGTmN77D1dWmlMH2qJJ9hJrQFWZ3UGVGu+dn9Y5sDhG3yBNFhka/tzPYeucD8DA9XbiCJbwXCuWl0iu/nPjzmZ+hQp7jIZ46zLgNec4fJS0jfTkr/38T1OjtIg6+91/j29DdnlEes6HyTGPzqHvg6kVzKSSWcbjv7piRkghnWYBIC3vY7EyE6VOG3IAxThL8YW+Qq1YbiUNaKbCznqOV3XvZpyQG6bnGMc1r/BGPIKe6GlY3pRjDcXLgy2IAfWu11J727noJCvh1LMSwcKaGqkaz7JC2UER2BStmWm4hpAOUwVGHBoOSef4y928WlHtKoFB/PZ0KieBbbWUZbFrl6oH/746rE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(451199018)(86362001)(31686004)(2906002)(54906003)(4744005)(82960400001)(83380400001)(8936002)(6512007)(41300700001)(31696002)(36756003)(26005)(478600001)(186003)(53546011)(5660300002)(6666004)(6506007)(107886003)(66476007)(2616005)(4326008)(6486002)(38100700002)(66556008)(66946007)(316002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2t2QkxlOEJGQXlUTDFBNDZpVzJuamlPdkF2THFSaXRoWWJ6em1LTm5SYmlq?= =?utf-8?B?OUtZajRYZ1ptaE52Szk0UEtSNGRUWlVtY0J4dTV1YkVpeE5CK205OVRRVWl2?= =?utf-8?B?T05FUS95SGZFQjNMY2ZqRFM5Z2ZKWE54YlhLZHFSdmRURm9KUXNWUTNTVXR6?= =?utf-8?B?b2RFTEZEeG5MVmlaazg1eURQMVFlb2JiU2N4RmJFaWF1bEphQlE3WENIRU9k?= =?utf-8?B?QU9HWjMxbm9lOG5oQlQ3SmhuU25ET1FQUHFVeWgyZ2s3YmhuUmYyNHkrTnNX?= =?utf-8?B?OWkxd0lIZVN3aXFCNzREeWpnT0I5cmtNTGZUc2tmT0hvakh6SUc1TzBsNnRv?= =?utf-8?B?Vm5KQU1zdmNNTUs3MUErWTdsN3RTd0dWQkNsamNOVEZ1Zms3c3V0Z1MzMDFY?= =?utf-8?B?QlUzeUNiMTJ2eEdLUUNXTEJsZkhPRFAyMzFla3ozRzFkcXNrYlI0TGJxNzM2?= =?utf-8?B?eFJXb2RZdmdTazNYNGwrSkdBRklhMGs1bnh2QXFleVhlcEUyQVVHdk5IU2pM?= =?utf-8?B?K1Vicm91Z2ZEcE1wWVgyQTNXV1B4TjRxbUFqWlVOMytGWGpuRnk3ZHcyYmhp?= =?utf-8?B?NmZuTEwwZnBGVzhTUjdaUEhhb1JoTVVlUHpmWStub1M1WFcyTkdwd3psakhm?= =?utf-8?B?UC9MRzM2c2JvaWthVkYwV2lZYXc4bmk0WWdpa1UxOGlhanR2Rkx0eTlVbnFS?= =?utf-8?B?OUdwNDZXeVp0MHJDaFZidnIvZWtUSVlCR0R3SXVkYmVKalR2QTBJTDVtblY4?= =?utf-8?B?RHJJYWkrSmYzV0FhQ214Vzh0b0dadlErVG1ncTlFRGp3aHRIOUVhWlRldFlB?= =?utf-8?B?Si9wUVh6NmNMbFRNWHUvWkJQblNDNThqWG50eFpkMy8zMmRrR09DMk16OUlX?= =?utf-8?B?VEFxSC9JWFovRGxLZC84SUpNOENPV2ZTcEI1TnJYa0JYYW53Y3BXOTBjWG83?= =?utf-8?B?K1QwU0RuTlpKenpaM0FEeTVOTVp3WkdvQ0Z4SG1ZSjZlSlVOL20vVXl5a01s?= =?utf-8?B?ZkVUUE4rRnJIZnRLRkxPTnIzQ1M5M01aWTgrWHl1bUM4ZGZSb29GaTBTWVY4?= =?utf-8?B?djFDYkswZWVoYkViSGhzQ09ENXZXMFVMR2RPNjcrOTRIZUtsM3VmcUtzcHJB?= =?utf-8?B?OW5XRlVFMmRCNzZJdzdiVzM3VTh1QlVhNWQwRktITDI3S3BVNXdENjMrbEE5?= =?utf-8?B?WVVwWkl1RlEyanhmTDF4dGJ0a1pBVTFHTzR1eFc2STc0MytrRERLUWhMSHBr?= =?utf-8?B?RUloYm5QalFyLzVSUnlBRkJaVWttbWdYc0gxd2RTS3kyaVFkbldDcGJCbU1Q?= =?utf-8?B?Wjg1YW8rWFU1cHRtclJBdTNsQ3J6V05DTFZMZGVIMmV6SWFMOEMzUVpnenpN?= =?utf-8?B?MWJZek52QkM1YXVEQzdYNzAwREp3T0hxaWF6aUd0ZFZ4MWhDZEtEd0Q0QnhS?= =?utf-8?B?d0d0b1g4OVpjR3k0QS9RS2dpQW40N21kWjdjZXRjeGJKUTZRbnRPM1BRMkhD?= =?utf-8?B?SEpESWxuMlJlek9UdnpkZEMzQkE0dWlyNlk5MGVBMmpkZkMvZW1IUmQwcFJ4?= =?utf-8?B?N05CNWMzdHpZKzA0WUtSSC9TRVRkZVhNU0ZGUllWYUgxYktBblFXbHUxeDdr?= =?utf-8?B?NllEa1U5M29WdlVabFdHMkYwaGloSm5iTitiS2FKK1l0ckwrVHZML2o3a1Vh?= =?utf-8?B?Q09JN2hzOXB1VTNTK0xRbXRqSkhISVRTbitnTGpvb1ZuZktRVVRyUkM3VEQv?= =?utf-8?B?T1JvRWU5MzFXbFBTTSsxVm5MUWVaK0VCK29hZU5pUmRQak84NDJYU2U5Wkxr?= =?utf-8?B?RVNJNlBDbTRsRFR0VGsxSkpxcEU3R0dQN2VnU1BBaFg5SWtIb3dBVEN2N0pL?= =?utf-8?B?WmhtMjN4R2UydXhjMFoybkhqV1h0alBNLzVkbCtPRkkrUWkxYXVPRUJCQURV?= =?utf-8?B?QkwvWVhFTTBkL0xLVUppWE8rTzJKZDREKzVMUWFiTVRrT1IyNjIyNTVocVh5?= =?utf-8?B?TWVBMzBHMUFlRVdsaitaL3VEeVlHbWdacnh4M2pDcVUrM0RUNGZwbmxQODRi?= =?utf-8?B?MlRDT3FNQVJ4L3VTT0JjeU1EbE03eFl3SHVaZzk3MGpNOUVXdXZobE0zNkla?= =?utf-8?B?RmRTbWYrUUxxdExUZ1dRRWV0cTdMQ3poaFVkYXgwd09EZnVPenA5RlRzZnRU?= =?utf-8?B?ZkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bdtoy1Mr7tCYbCwHtJ0jMWZdW5f9hvSMCoT/hAs8Lv68c8M49MrFx8azj9pNxqfeEwtNluEbAnfBKb/3aqyxFW5wfJCFWr1vM5XDBhj+d1KQc940C/rjiDZXOKXYrzBRjcgRUyAzu2HHWdWoodE6L6/tqv02sR82x93LkEMNsVyhkAweKS3wHfatNNfb5c7rXN6A7UQ58Bokif4ANqPfsCdO2qryrH/riFVwpoHILOcovLrshuiEucVQyXXeS+gcQemv0XjtmWCZ0oehLTTkio2HAzPUs5tkSiNw7N5S00qJvYEA74wlrZnrYL+rJzZKVIREJmRos3XF2waGBanO2QdU0a8CElpiewWXjul59Kwp7VvbfTUcZwTwCOOacDu7gnhrAKgHrEXuton76GrexZzQc+G8VQ7cybWHU0jnFFS7vkORg/QGNM3RIBUSBANjtEPKUTgCGgG04zWQ7J/MgVSSNXPs8fctn4gA4I+6lSKdk8+gYcJwFYGj8FWtIhacRwMIYvX+06mVaOaTqmQvVovknJ1uLUY4jS0De6aYbFyF5zHIcbhVDOlONT1Cqd2P4lIQk03h0GttTrHyXSTlSLJRl0lWoaeOPbrVb8Oct5o5kcUihZAGeUm7Vf54L9Y04u1Tqh3zPOsOVsJn4nk+1r2bn3rUR4+rVutUVstRXSNcSgwB/YQZ1KPa+89UYBfPDAzNmzrymVoTyY5C8DA8dJ3R5ea3f6GwNibYWhEZ7JOl0y8hAxiAQuSAV34siER47rx9T2+uwYL+DMsVowmazK95/4aghjekZuzPsJyE4e4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35cf062e-5206-4eeb-adc7-08db0543ca3c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 17:34:51.9478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4khmc5ku9au014Nd/lNcIHqx7lllbcgTY++4hAyXGqjjA7MiiZha0x+hoo1+t36U48ZbOzp8w7IC6E40OWZnoZIK62dVcB2pPxX0MJJQh9k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7061 On 02/02/2023 5:18 pm, Andrew Cooper wrote: > On 02/02/2023 5:13 pm, Bernhard Kaindl wrote: >> Fixes for Py3: >> * class Delayed(): file not defined; also an error for pylint -E >> * Inconsistent use of tabs and spaces for indentation (in one block) >> >> Signed-off-by: Bernhard Kaindl > Acked-by: Andrew Cooper > > I'll add this to my pending queue while staging is blocked. Actually, on second thoughts.  Class DomainInfo and Delayed need to inherit from object for Py2 reasons.  Inheriting from file did this previously. I can fix up on commit, if you're happy. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 02 18:02:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 18:02:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488895.757186 (Exim 4.92) (envelope-from ) id 1pNdue-0002ub-24; Thu, 02 Feb 2023 18:02:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488895.757186; Thu, 02 Feb 2023 18:02:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdud-0002uU-V3; Thu, 02 Feb 2023 18:02:19 +0000 Received: by outflank-mailman (input) for mailman id 488895; Thu, 02 Feb 2023 17:56:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNdpJ-0001od-RG for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 17:56:49 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f70843aa-a322-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 18:56:48 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id u21so2869944edv.3 for ; Thu, 02 Feb 2023 09:56:48 -0800 (PST) Received: from ?IPV6:2a02:1748:dd5e:b8b0:bc6e:d792:9ad3:1d92? ([2a02:1748:dd5e:b8b0:bc6e:d792:9ad3:1d92]) by smtp.gmail.com with ESMTPSA id w16-20020a05640234d000b0046267f8150csm23081edc.19.2023.02.02.09.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 09:56:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f70843aa-a322-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tibco.com; s=googleworkspace; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Z4GgxUxw9KMCr0wz/MFIVAHr9FdS7DQ9h69clpzs9jI=; b=ZdysDnzdji44j6CWIqd2NjTZpjgOCKNuGArUFc8TGjZppxK7Xa79hGaXS0n48AbPGR xniDlrX/pwTXNRaA4J5bzQAE8Zt4rguwHfjscshljX8qjjgDUSC2O2e/Aepx29+R7aag pgGz46psRrC8Sts9qZLl/sltcgp5EkWgdugqrmbjTKDTsM0g1En0SbYFHdvKdF0MY7BJ tZ2M5IhJvY1NAq0/+E05S34ToOYVgBGgOde31lV4nMWuB6cSxOJg5rqlwKrJlsffSTMp twl34HqLBbk5ni1xKDzPKsJCtZl6of5/K1aWA05jt5npXIaZ0L1K3fYyduT0arkywlXD fzgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z4GgxUxw9KMCr0wz/MFIVAHr9FdS7DQ9h69clpzs9jI=; b=nrbIoVFDHFh0rxMH/ngISky2rkdKMxnPBCC1yv+JEn4JECKp7Fr24by4vagFGxSYRj FOGu7WTAjBuU/OUcJAFy0hPyIXTyXYGrmoZllpcBC6FcVygbI4EwbIVu6aa9afW5fi2t aIQkrzBnd4m9FfQXcdvvY2W6ZHbvmT2wqV2O2+8Q3yOz9W1MYgpLhBhG16WilCW05Mad 6ko+6M7EfuR9ChUdMU/xf7tb6jGvz+4krPWnglltJW4+sMX1rafX1orbOzgc425Otf8B gwHgoTRpvY4rbRKaoiwh3JV2SRdwbTDqHphwhg9LdulmR0il7GnPK12pFwKs+yTHAVWx StSg== X-Gm-Message-State: AO0yUKUnYl1rzZfNIfQcwWiTtyXLpq6WOR0IlE2qR1uZ8uDZYR5BXDmY kGEgiwjwc9nBIbBI+JIy4eImDg== X-Google-Smtp-Source: AK7set8iLm6kNp3xelQIOqEJzN3TOCOe/6K0mo8vGsfI8W9Kz68jh62SxcSe7AqAjDRSecIUlcjuTw== X-Received: by 2002:a05:6402:a56:b0:49e:baf:f6e9 with SMTP id bt22-20020a0564020a5600b0049e0baff6e9mr6671726edb.9.1675360608399; Thu, 02 Feb 2023 09:56:48 -0800 (PST) Message-ID: <07f4fc06-be3f-b286-d964-9f6bb3b7cc1b@tibco.com> Date: Thu, 2 Feb 2023 18:56:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH] tools/xenmon: Fix xenmon.py for with python3.x To: Andrew Cooper , Bernhard Kaindl , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230202171319.285548-1-bernhard.kaindl@citrix.com> <3412a0d5-899b-4db8-b6bd-9c532e9f84eb@citrix.com> From: Bernhard Kaindl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 02/02/2023 6:34 pm, Andrew Cooper wrote: > On 02/02/2023 5:18 pm, Andrew Cooper wrote: >> On 02/02/2023 5:13 pm, Bernhard Kaindl wrote: >>> Fixes for Py3: >>> * class Delayed(): file not defined; also an error for pylint -E >>> * Inconsistent use of tabs and spaces for indentation (in one block) >>> >>> Signed-off-by: Bernhard Kaindl >> Acked-by: Andrew Cooper >> >> I'll add this to my pending queue while staging is blocked. > Actually, on second thoughts.  Class DomainInfo and Delayed need to > inherit from object for Py2 reasons.  Inheriting from file did this > previously. > > I can fix up on commit, if you're happy. Yes, thanks! -- cu, Bernhard From xen-devel-bounces@lists.xenproject.org Thu Feb 02 18:43:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 18:43:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488903.757197 (Exim 4.92) (envelope-from ) id 1pNeXn-0000TJ-3A; Thu, 02 Feb 2023 18:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488903.757197; Thu, 02 Feb 2023 18:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNeXn-0000TC-0U; Thu, 02 Feb 2023 18:42:47 +0000 Received: by outflank-mailman (input) for mailman id 488903; Thu, 02 Feb 2023 18:42:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNeXl-0000T6-GP for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 18:42:45 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d9c6a3f-a329-11ed-933c-83870f6b2ba8; Thu, 02 Feb 2023 19:42:42 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8123A3200645; Thu, 2 Feb 2023 13:42:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 02 Feb 2023 13:42:36 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 13:42:33 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d9c6a3f-a329-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675363355; x= 1675449755; bh=lg2mMVgKWzumdcP+F9hZgcsYrteBCJhK/JelW6EYdVY=; b=C uTXDseVzBiQj9h2D+NuYP2jUT0tW3Lmilaa0/HVSPpcoiD3KfygKzgQY6EimkjGJ r5FPB9IdV+dObh+fV0OrZLfZju61Sb6vtG1NmYLcIF3/TDhRTlZSI3Pu/JQhgjs5 zeRqriMqf8Jbp0rN18pCjM+1Lt5t/VTltANRbn4K9r5dCYs5JqXLdqLwY0TsTT3j 31hBdBZCBzFrcgq7waSac0sKHGrR/49IS6TWidI6ddBpWjEPzPR7SFcCRg6b4FUR GRYPIRccsAsOCVdMLmydp4wk+cRTUS5Xxon9Fq4sn8BQsZP+FfM/yxM/3FqncdQ2 BPo8XZ+FTMxYV+HznS63Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675363355; x=1675449755; bh=lg2mMVgKWzumdcP+F9hZgcsYrteB CJhK/JelW6EYdVY=; b=cxgzpT9otQWxsLIA+yjsDC7ZP5F0KwVUpP3jph2vdxZ5 +mitzO+3QYTvVvmnpmL8EKvzBAOOpiKA0KefZzv7ciC8KpwXn3TYPeIYKEQpHe7O H0pbjMXOqtg5yoRYP3hsvSdXQz7CwXFX/HIQ7fJ5wURTZGtn01qKIf1v7RCIoaw9 KzXvF2sdBjzYNlhKlrJ+2dde8e9oV5rizIAthd4k6Q22qZzoKVRj6R2UMwQOFMnW BVM5W5A2aZAJVzpHPoIqj9GNAFpK/H+Rbs09rSxRASrPjVDyjJtMFuZop9KbSzaj 2PUaxc67TE8Tua6UJ1edW8stqxg4x7nrkZ/k9QJsUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 2 Feb 2023 13:41:29 -0500 From: Demi Marie Obenour To: Mike Snitzer Cc: Jens Axboe , Roger Pau =?utf-8?B?TW9ubsOp?= , Alasdair Kergon , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0LK2ZHUlLOwPgDgy" Content-Disposition: inline In-Reply-To: --0LK2ZHUlLOwPgDgy Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 2 Feb 2023 13:41:29 -0500 From: Demi Marie Obenour To: Mike Snitzer Cc: Jens Axboe , Roger Pau =?utf-8?B?TW9ubsOp?= , Alasdair Kergon , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling On Thu, Feb 02, 2023 at 11:50:37AM -0500, Mike Snitzer wrote: > On Wed, Jan 25 2023 at 10:33P -0500, > Demi Marie Obenour wrote: >=20 > > This work aims to allow userspace to create and destroy block devices > > in a race-free and leak-free way, >=20 > "race-free and leak-free way" implies there both races and leaks in > existing code. You're making claims that are likely very specific to > your Xen use-case. Please explain more carefully. Will do in v2. > > and to allow them to be exposed to > > other Xen VMs via blkback without leaks or races. It=E2=80=99s marked = as RFC > > for a few reasons: > >=20 > > - The code has been only lightly tested. It might be unstable or > > insecure. > >=20 > > - The DM_DEV_CREATE ioctl gains a new flag. Unknown flags were > > previously ignored, so this could theoretically break buggy userspace > > tools. >=20 > Not seeing a reason that type of DM change is needed. If you feel > strongly about it send a separate patch and we can discuss it. Patch 2/7 is the diskseq change. v2 will contain a revised and tested version with a greatly expanded commit message. > > - I have no idea if I got the block device reference counting and > > locking correct. >=20 > Your headers and justifcation for this line of work are really way too > terse. Please take the time to clearly make the case for your changes > in both the patch headers and code. I will expand the commit message in v2, but I am not sure what you want me to add to the code comments. Would you mind explaining? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --0LK2ZHUlLOwPgDgy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPcBBUACgkQsoi1X/+c IsEkFA/9GXzWAuv/0q2ZJqJ64sluumHTrJNuenjIiibpb2PmaUs036H9r2jQYDI4 Lsxw3M3/9AYwGFpj/mhV5uBJutDasM3xTROoY5VqdO6vTeueaXUCefc+CGNzXNzZ 3o018mxFSPwKDaOBrCsiOuNsHtVzaOnO/TGuBW3HcYafDKFTWhDoprhfzL9mkwBY 21Ly74WUVB+S3fhURF+XgGoPKlQlaI8u6uJvW+wPQYei/LZqm5Gcpj5sqIhomFgM yTA6l097aOj6ULLkScDW91sj30OJLc7qN5V+FtU27tRZWEzIcY5cl4/IL9KcAfGi bcQcQ2Z7WPcjqLLuUxB2C5dfR6id/CmDnplOBRD0TAVzbUCJCEciClYHxPxljE6q /mSqAfuBhO3ryA7z8xMYsYVz0SpdgnQqXXhxaZslSA4r0ACdEsytMu0YPPpIby7M BjV5Sx2xuLaw/McuiptVktbvKknJAqw79ZecjU03d3Ga3/sA8dZC4JBGRj90cOMT WPHUORPPmepxyX6n28rH/mdcsFDAzllbi37fReeJCKEEmrT5aCa8pyry1Rl2V6fi ub+T46oghFHgl63y0Timr6eamgqV3CHGczHiKMcA0Mclv4shWUyaId0bzAGn/RLR vpbwX0CGu7m1vnqsskbtLq1ThblONmQWtVFcFrqykfZMeqs2KtM= =aeu1 -----END PGP SIGNATURE----- --0LK2ZHUlLOwPgDgy-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 18:56:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 18:56:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488909.757208 (Exim 4.92) (envelope-from ) id 1pNekm-00022Y-7o; Thu, 02 Feb 2023 18:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488909.757208; Thu, 02 Feb 2023 18:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNekm-00022R-4b; Thu, 02 Feb 2023 18:56:12 +0000 Received: by outflank-mailman (input) for mailman id 488909; Thu, 02 Feb 2023 18:56:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNekl-00022H-K9; Thu, 02 Feb 2023 18:56:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNekl-0003g1-J3; Thu, 02 Feb 2023 18:56:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNekl-00055i-2q; Thu, 02 Feb 2023 18:56:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNekl-0005bZ-2S; Thu, 02 Feb 2023 18:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6UL+S/Z3SPpZsyTBqTWkkwaS7VUMpyBIGZSrTHVeDsI=; b=hWSUW68TajHGAshEiuSxADhjyR DJ5wIcrO4T0VJV3EC66VHX+keXZdF1QSSgg5eIgZIzxfWMxWiACCb7zw8hXu1dtNdwLv8njLt7LqM lDMLQARxyo2h34WFk/oLxewauQTxtUw4qKcPIaUGLF5eZoDX6jQGOAwczll3z0+d1xxQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176337: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=10b80ee5588e8928b266dea02a5e99d098bd227a From: osstest service owner Date: Thu, 02 Feb 2023 18:56:11 +0000 flight 176337 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176337/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen 10b80ee5588e8928b266dea02a5e99d098bd227a Last test of basis 176151 2023-01-26 14:00:29 Z 7 days Testing same since 176283 2023-01-30 21:02:20 Z 2 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 10b80ee558..78e93e6e57 78e93e6e57c218eead498a664785f414bcb12460 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 02 19:57:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 19:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488919.757219 (Exim 4.92) (envelope-from ) id 1pNfhJ-0000ty-N3; Thu, 02 Feb 2023 19:56:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488919.757219; Thu, 02 Feb 2023 19:56:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNfhJ-0000tr-KV; Thu, 02 Feb 2023 19:56:41 +0000 Received: by outflank-mailman (input) for mailman id 488919; Thu, 02 Feb 2023 19:56:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNfhI-0000tl-Si for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 19:56:40 +0000 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b363f225-a333-11ed-9254-a70e01b1f5fa; Thu, 02 Feb 2023 20:56:37 +0100 (CET) Received: by mail-qt1-f182.google.com with SMTP id cr22so3188307qtb.10 for ; Thu, 02 Feb 2023 11:56:37 -0800 (PST) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id h6-20020a05620a10a600b007246f005d8bsm293223qkk.116.2023.02.02.11.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 11:56:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b363f225-a333-11ed-9254-a70e01b1f5fa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=puPH7Nn4Vxt3kUnQKHCGR9XbgEDlt42vfosxQIpu+cs=; b=VvC/2JA+Ok/fgjCpiQ6GqyjKMcVaUDZxUpulHOe+ApP7g283G5j17BdLshKAvtdtFo BkUhyEBgcoh+RXWGMv3pRk38YrEQIPckGV2wVeinLDGNFvYYC1eT0PU0psDdiklvoxYh riyV3OO0jZB0ir6c7v1yRsLCa89y+X7eqAlKQxUnOk8cetdNj6RAEgrkOOnsdnJGt6UU MCl6Tg8zseXV876Vo+bic5NJVhPch46j+SeCIDiQYWUDm8jrZP2yuDUnJ9oIVX3SwjBc H5ag/snYAbzxD/PZaNdmswfmNPQVOLYhaqpecVybqaN/V0Aj6tGhI8u9kAOAUQNW8DQq Ij4A== X-Gm-Message-State: AO0yUKX9QOyVOgLbf4rornYao44+NtIf9ULpEIrS4yInC1VFvzJ+hNNS C5CnRVvDQoBDDRfCho7qj3K6 X-Google-Smtp-Source: AK7set92dyhIkHCdWF7e92O2MXu6mUmZ6lpekQmSoPBHbD1dR3CVvDYQ1CtAQ9IvY8M0gdRPR2pO1A== X-Received: by 2002:a05:622a:511:b0:3b8:6c68:6109 with SMTP id l17-20020a05622a051100b003b86c686109mr13439452qtx.21.1675367796153; Thu, 02 Feb 2023 11:56:36 -0800 (PST) Date: Thu, 2 Feb 2023 14:56:34 -0500 From: Mike Snitzer To: Demi Marie Obenour Cc: Jens Axboe , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Alasdair Kergon , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 02 2023 at 1:41P -0500, Demi Marie Obenour wrote: > On Thu, Feb 02, 2023 at 11:50:37AM -0500, Mike Snitzer wrote: > > On Wed, Jan 25 2023 at 10:33P -0500, > > Demi Marie Obenour wrote: > > > > > This work aims to allow userspace to create and destroy block devices > > > in a race-free and leak-free way, > > > > "race-free and leak-free way" implies there both races and leaks in > > existing code. You're making claims that are likely very specific to > > your Xen use-case. Please explain more carefully. > > Will do in v2. > > > > and to allow them to be exposed to > > > other Xen VMs via blkback without leaks or races. It’s marked as RFC > > > for a few reasons: > > > > > > - The code has been only lightly tested. It might be unstable or > > > insecure. > > > > > > - The DM_DEV_CREATE ioctl gains a new flag. Unknown flags were > > > previously ignored, so this could theoretically break buggy userspace > > > tools. > > > > Not seeing a reason that type of DM change is needed. If you feel > > strongly about it send a separate patch and we can discuss it. > > Patch 2/7 is the diskseq change. v2 will contain a revised and tested > version with a greatly expanded commit message. I'm aware that 2/7 is where you make the DM change to disallow unknown flags, what I'm saying is I don't see a reason for that change. Certainly doesn't look to be a requirement for everything else in that patch. So send a separate patch, but I'm inclined to _not_ accept it because it does potentially break some userspace. > > > - I have no idea if I got the block device reference counting and > > > locking correct. > > > > Your headers and justifcation for this line of work are really way too > > terse. Please take the time to clearly make the case for your changes > > in both the patch headers and code. > > I will expand the commit message in v2, but I am not sure what you want > me to add to the code comments. Would you mind explaining? Nothing specific about code, was just a general reminder (based on how terse the 2/7 header was). Mike From xen-devel-bounces@lists.xenproject.org Thu Feb 02 20:08:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 20:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488928.757230 (Exim 4.92) (envelope-from ) id 1pNft3-0002hz-QK; Thu, 02 Feb 2023 20:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488928.757230; Thu, 02 Feb 2023 20:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNft3-0002hs-N7; Thu, 02 Feb 2023 20:08:49 +0000 Received: by outflank-mailman (input) for mailman id 488928; Thu, 02 Feb 2023 20:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNft2-0002hi-Kr; Thu, 02 Feb 2023 20:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNft2-0005Xy-Bl; Thu, 02 Feb 2023 20:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNft1-00079U-UR; Thu, 02 Feb 2023 20:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNft1-0006KQ-Th; Thu, 02 Feb 2023 20:08:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8b97VrWrIuJuYJn0QfokvE/tH68c51RnuplzIFcq7HE=; b=NiVsy6bP4lRw8SZf8opdED9VOx 7DeQwVZqtE29p5h32puWiQ63vq0QlpAdYlqWlwLQQDtA0ZoqrfTJ7ountHrCjwt+rvkjtt/unDH1G 5SRw0oURJ/j+LaouBMZGattSa446xwfAndFsf0lAQko5IGoTO/dmiN5Un0F4i55g5XaY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176321: trouble: blocked/broken/fail/pass X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64::broken:regression xen-4.17-testing:test-amd64-amd64-xl-shadow::broken:regression xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-i386-libvirt::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-4.17-testing:test-amd64-amd64-xl-rtds::broken:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm::broken:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64::broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-rtds:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-libvirt:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-shadow:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.17-testing:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Thu, 02 Feb 2023 20:08:47 +0000 flight 176321 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176321/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-i386-xl-qemut-ws16-amd64 broken test-amd64-amd64-xl-shadow broken build-armhf broken test-amd64-i386-libvirt broken build-armhf 4 host-install(4) broken REGR. vs. 175447 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken in 176295 test-amd64-amd64-xl-rtds broken in 176295 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken in 176295 test-amd64-amd64-qemuu-freebsd11-amd64 broken in 176317 build-armhf 3 syslog-server running Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 5 host-install(5) broken in 176295 pass in 176321 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken in 176295 pass in 176321 test-amd64-amd64-xl-rtds 5 host-install(5) broken in 176295 pass in 176321 test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken in 176317 pass in 176321 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken pass in 176295 test-amd64-i386-libvirt 5 host-install(5) broken pass in 176317 test-amd64-amd64-xl-shadow 5 host-install(5) broken pass in 176317 test-amd64-i386-xl-qemut-ws16-amd64 5 host-install(5) broken pass in 176317 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 176317 pass in 176321 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 176317 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176317 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail in 176295 like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail in 176317 like 175447 test-amd64-i386-libvirt 15 migrate-support-check fail in 176317 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176295 n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved in 176317 n/a build-arm64-pvops 2 hosts-allocate starved in 176317 n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 42 days Testing same since 176224 2023-01-26 22:14:43 Z 6 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 broken test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt broken test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow broken test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-amd64-xl-shadow broken broken-job build-armhf broken broken-job test-amd64-i386-libvirt broken broken-step build-armhf host-install(4) broken-step build-armhf capture-logs broken-step test-amd64-i386-libvirt host-install(5) broken-step test-amd64-amd64-xl-shadow host-install(5) broken-step test-amd64-i386-xl-qemut-ws16-amd64 host-install(5) broken-step test-amd64-i386-xl-qemut-win7-amd64 host-install(5) broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-amd64-xl-rtds broken broken-job test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 20:48:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 20:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488937.757241 (Exim 4.92) (envelope-from ) id 1pNgUm-0007dZ-T9; Thu, 02 Feb 2023 20:47:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488937.757241; Thu, 02 Feb 2023 20:47:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgUm-0007dS-QM; Thu, 02 Feb 2023 20:47:48 +0000 Received: by outflank-mailman (input) for mailman id 488937; Thu, 02 Feb 2023 20:47:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgUk-0007dI-W6; Thu, 02 Feb 2023 20:47:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgUk-0006ce-Tc; Thu, 02 Feb 2023 20:47:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgUk-00085P-BT; Thu, 02 Feb 2023 20:47:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNgUk-0003I7-Ar; Thu, 02 Feb 2023 20:47:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=es8Ji7ICGCK8Dh28NPkA80fFqn0j9PqLxTTJuHapHI4=; b=Gl4Z4NQpqbWfk3ATE7Vtm9kF+q uBXen4E/3afE5Ch4G7udvgbIsNMKBiG7qdO6jsI2raoyrl9K7tAVGUTYs2st66ONuzQEECcP+6QeY iAtOdi+KptFP6B5c3FernWX8RbXqymLunSrHjt51oIQD+vCiWuFWoVsr7xAKdU1Pkr1Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176326: trouble: blocked/broken/fail/pass/starved X-Osstest-Failures: xen-unstable:build-armhf::broken:regression xen-unstable:build-armhf:host-install(4):broken:regression xen-unstable:build-armhf:syslog-server:running:regression xen-unstable:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:build-armhf:capture-logs:broken:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=10b80ee5588e8928b266dea02a5e99d098bd227a X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Thu, 02 Feb 2023 20:47:46 +0000 flight 176326 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176326/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 175994 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 175994 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a version targeted for testing: xen 10b80ee5588e8928b266dea02a5e99d098bd227a baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 13 days Failing since 176003 2023-01-20 17:40:27 Z 13 days 25 attempts Testing same since 176222 2023-01-26 22:13:29 Z 6 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 1225 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 20:58:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 20:58:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488946.757252 (Exim 4.92) (envelope-from ) id 1pNges-0000rr-T8; Thu, 02 Feb 2023 20:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488946.757252; Thu, 02 Feb 2023 20:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNges-0000rk-QD; Thu, 02 Feb 2023 20:58:14 +0000 Received: by outflank-mailman (input) for mailman id 488946; Thu, 02 Feb 2023 20:58:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgeq-0000re-Lo for xen-devel@lists.xenproject.org; Thu, 02 Feb 2023 20:58:13 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a5748d4-a33c-11ed-9254-a70e01b1f5fa; Thu, 02 Feb 2023 21:58:08 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DA6AD320092B; Thu, 2 Feb 2023 15:58:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 02 Feb 2023 15:58:04 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 15:58:02 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a5748d4-a33c-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675371483; x= 1675457883; bh=dzgq76cYFXWqr386VYF7ubjMYy/4D3tzRP84ABBYvhg=; b=s yCLlVbTqQbtyOeBRMnG9EpqbCx6GzKG4Hg76/luZQ/eT+Nq9KviKBIiPk+EkLyHN wY8o1LK4fkCBtVnIJpyFq/3uMePbmk18mOBTu1FtZlnea8hsTT+V0ADGIDWRhH0Y HmaXYjlOubsbx0jyYW+w6UkKGWiAPzRLX01mPJLTxzP3CbDw+xuj6CZsMzdaJHwy zz7n0TZRUFqXaB+xy6f9WcjAeq2n1OrDxGcXKRnyc5jxfA50PCEqMf1Dv4h+Ilys +0pQMVtNOlgCmknLyqvAUXce5gpbqq8qhAlozlmsIsTboWSZ0IaKavHetQepNQ+N Vf4qnei6SmJnjdUl3+Y8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675371483; x=1675457883; bh=dzgq76cYFXWqr386VYF7ubjMYy/4 D3tzRP84ABBYvhg=; b=d478ZEMjTvlRbXKOPtpHsd8vraJQZ8JvpW/VI0IyDbKa ub8yalBozVWUnGc6bPbOpDNSOTg8Lm0AVtkKHHYIBiEZB4EQsN/G6zRvWYh/SO77 oqaoIBNpljYZmw0CZVXXQPbpSe7AT/+1VmKYR2NkuJyf5+DLFBJG7RDslYanVOWi xDu6yLmqiurqTapj3VST8SSDjPqEIvq3uDPEHgeQB1moyddyusGd+OZGX/EaVbmr qJd5lvChm0484XwC1n1MJ0Pb6H2CISyZtIB2oCMiRoBfs7hjL3BCjlrH/zHRCN/O swy3q63rmHwpD4B13y5JUcNG3YJJTV7ZSCiIo5S80g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 2 Feb 2023 15:57:55 -0500 From: Demi Marie Obenour To: Mike Snitzer Cc: Jens Axboe , Roger Pau =?utf-8?B?TW9ubsOp?= , Alasdair Kergon , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling Message-ID: References: <20230126033358.1880-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cgmN2P5oJuiMWNP7" Content-Disposition: inline In-Reply-To: --cgmN2P5oJuiMWNP7 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 2 Feb 2023 15:57:55 -0500 From: Demi Marie Obenour To: Mike Snitzer Cc: Jens Axboe , Roger Pau =?utf-8?B?TW9ubsOp?= , Alasdair Kergon , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Juergen Gross , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, dm-devel@redhat.com Subject: Re: [RFC PATCH 0/7] Allow race-free block device handling On Thu, Feb 02, 2023 at 02:56:34PM -0500, Mike Snitzer wrote: > On Thu, Feb 02 2023 at 1:41P -0500, > Demi Marie Obenour wrote: >=20 > > On Thu, Feb 02, 2023 at 11:50:37AM -0500, Mike Snitzer wrote: > > > On Wed, Jan 25 2023 at 10:33P -0500, > > > Demi Marie Obenour wrote: > > >=20 > > > > This work aims to allow userspace to create and destroy block devic= es > > > > in a race-free and leak-free way, > > >=20 > > > "race-free and leak-free way" implies there both races and leaks in > > > existing code. You're making claims that are likely very specific to > > > your Xen use-case. Please explain more carefully. > >=20 > > Will do in v2. > >=20 > > > > and to allow them to be exposed to > > > > other Xen VMs via blkback without leaks or races. It=E2=80=99s mar= ked as RFC > > > > for a few reasons: > > > >=20 > > > > - The code has been only lightly tested. It might be unstable or > > > > insecure. > > > >=20 > > > > - The DM_DEV_CREATE ioctl gains a new flag. Unknown flags were > > > > previously ignored, so this could theoretically break buggy users= pace > > > > tools. > > >=20 > > > Not seeing a reason that type of DM change is needed. If you feel > > > strongly about it send a separate patch and we can discuss it. > >=20 > > Patch 2/7 is the diskseq change. v2 will contain a revised and tested > > version with a greatly expanded commit message. >=20 > I'm aware that 2/7 is where you make the DM change to disallow unknown > flags, what I'm saying is I don't see a reason for that change. Thanks for the clarification. > Certainly doesn't look to be a requirement for everything else in that > patch. Indeed it is not. I will make it a separate patch. > So send a separate patch, but I'm inclined to _not_ accept it because > it does potentially break some userspace. Is it okay to add DM_FILE_DESCRIPTOR_FLAG (with the same meaning as in 2/7) _without_ rejecting unknown flags? The same patch would bump the minor version number, so userspace would still be able to tell if the kernel supported DM_FILE_DESCRIPTOR_FLAG. If you wanted, I could ignore DM_FILE_DESCRIPTOR_FLAG unless the minor number passed by userspace is sufficiently recent. Another option would be to make userspace opt-in to strict parameter checking by passing 5 as the major version instead of 4. Userspace programs that passed 4 would get the old behavior, while userspace programs that passed 5 would get strict parameter checking and be able to use new features such as DM_FILE_DESCRIPTOR_FLAG. > > > > - I have no idea if I got the block device reference counting and > > > > locking correct. > > >=20 > > > Your headers and justifcation for this line of work are really way too > > > terse. Please take the time to clearly make the case for your changes > > > in both the patch headers and code. > >=20 > > I will expand the commit message in v2, but I am not sure what you want > > me to add to the code comments. Would you mind explaining? >=20 > Nothing specific about code, was just a general reminder (based on how > terse the 2/7 header was). >=20 > Mike Thanks for the feedback! --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --cgmN2P5oJuiMWNP7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPcI9YACgkQsoi1X/+c IsF28hAAhImjjtlWhG/0QL5ADEU4goFI++sArqOlA2RYmyVjye52flwl4Fzd+px3 qEsA6mLllD0x2SxfycOirT3D5d0Gsa8BVPs+WiaWed5Rc+LececX+YGQ6HgEUZBM Ig69iNxrCcA5CARoNWd/RsHZSuxSE9ltgzo00ghW+LNRKVyYAn0nuAWddWLqYrvr wVdonaDhI5IC15GPQ4CK4T21JTO16NsUjld1A03pgr0ubzV+UpwWGNycwjSpz2KB WzHAq5NTLvda6dLUmt1o/z7dJR04gPA8ICyF/zKXzkjuOgeTvQOTY25iv5O3xQYv 1WHAJJqxb8twWMw+bU92sjoUJy4jdqr5DQ7n+ga5eEG0YAPBkRwcPuKdJdotbUFF 8VP90nUdWDGlmc+w20GlNzziVOyxLFbVgxFO1evJ0Kq023gzvcgs69RqV1mLfP44 hD18hdcC2ytp8TwhNrERzmBxWjEtD1MphgGXAiJQ0qQEyYlKAYNUyolM8lTnTQR9 Xccwj6ow7pMDIV+DkNuD4Ebiu7dx4WhjyTc4jx9NHSUUDeuff0v4PzFCiXr/x/dN 0Sml2ojt43HPUfLXaepFNwLCqL54zGNNa2gsH0gyl0iwAFMAgNbMcUAx10lCOmDj d7i37cInvPYgsSr2WUgz7mbiLlQN3Eh8tf5ut+q+OOOq+cRPKCs= =P5Xt -----END PGP SIGNATURE----- --cgmN2P5oJuiMWNP7-- From xen-devel-bounces@lists.xenproject.org Thu Feb 02 20:59:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 20:59:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488953.757263 (Exim 4.92) (envelope-from ) id 1pNgg7-0001RQ-6J; Thu, 02 Feb 2023 20:59:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488953.757263; Thu, 02 Feb 2023 20:59:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgg7-0001RJ-33; Thu, 02 Feb 2023 20:59:31 +0000 Received: by outflank-mailman (input) for mailman id 488953; Thu, 02 Feb 2023 20:59:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgg5-0001R3-2Q; Thu, 02 Feb 2023 20:59:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgg5-0006pP-0e; Thu, 02 Feb 2023 20:59:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNgg4-0008NO-F4; Thu, 02 Feb 2023 20:59:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNgg4-0001k8-Ea; Thu, 02 Feb 2023 20:59:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1pUExilHSzf18s5tOG4hzVa5PMpVd6WN8lWwZuWLnNA=; b=xQp4lf79H97yn4Wbz2hZpyHrox WBd9Rjx4zvqR2R1SSz7qEdIl5nDUgL6zzro1ugDFCknFS1W6WbyBgnF1wR/7KSG5qDKK4AY/mhmA6 1rLxEaPZqedgnHLXbRKgnVuhqijVmov+geU9uJCwYvuB6D1rs6RKKMwwSY0Vzk6Bs9I8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176325: trouble: blocked/broken/pass X-Osstest-Failures: libvirt:build-armhf::broken:regression libvirt:build-armhf:host-install(4):broken:regression libvirt:build-armhf:syslog-server:running:regression libvirt:build-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:build-armhf:capture-logs:broken:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=4ad60f9b29b9548e1c65cd63a699e5f00eaaf6b1 X-Osstest-Versions-That: libvirt=95a278a84591b6a4cfa170eba31c8ec60e82f940 From: osstest service owner Date: Thu, 02 Feb 2023 20:59:28 +0000 flight 176325 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176325/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 176139 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 176139 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass version targeted for testing: libvirt 4ad60f9b29b9548e1c65cd63a699e5f00eaaf6b1 baseline version: libvirt 95a278a84591b6a4cfa170eba31c8ec60e82f940 Last test of basis 176139 2023-01-26 04:18:49 Z 7 days Failing since 176233 2023-01-27 04:18:53 Z 6 days 7 attempts Testing same since 176325 2023-02-02 04:20:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Ján Tomko Martin Kletzander Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 670 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 21:53:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 21:53:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488964.757274 (Exim 4.92) (envelope-from ) id 1pNhWe-00006p-Cz; Thu, 02 Feb 2023 21:53:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488964.757274; Thu, 02 Feb 2023 21:53:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNhWe-00006i-9t; Thu, 02 Feb 2023 21:53:48 +0000 Received: by outflank-mailman (input) for mailman id 488964; Thu, 02 Feb 2023 21:53:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNhWc-00006X-On; Thu, 02 Feb 2023 21:53:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNhWc-0008AB-Mz; Thu, 02 Feb 2023 21:53:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNhWc-0002yD-DP; Thu, 02 Feb 2023 21:53:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNhWc-00069G-Cn; Thu, 02 Feb 2023 21:53:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HVZVX+nwO/PK+1DyAzNRYpmKKqwD/rgUQKep70TQmmQ=; b=NZj1vM50ppId9CMdxCUEvJ9iCH 0Kf8tJn98y2BKDPMIkzSko7tFmC1o8MStSRGfMQrNWDrDUhuanHGYVG6cFi3RDgF44dhXLYLC084M bLMYgZuPshB2Kw+q917QRRuF3PFAYY0bYI2cglakbAx7LufPKfULis8tIAelTDfIuvvs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176333: regressions - trouble: blocked/broken/fail/pass X-Osstest-Failures: linux-linus:build-armhf::broken:regression linux-linus:build-armhf:host-install(4):broken:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:build-armhf:syslog-server:running:regression linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:build-armhf-libvirt:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:build-armhf:capture-logs:broken:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9f266ccaa2f5228bfe67ad58a94ca4e0109b954a X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Thu, 02 Feb 2023 21:53:46 +0000 flight 176333 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176333/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 4 host-install(4) broken REGR. vs. 173462 build-arm64-pvops 6 kernel-build fail REGR. vs. 173462 build-armhf 3 syslog-server running Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a build-armhf 5 capture-logs broken blocked in 173462 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass version targeted for testing: linux 9f266ccaa2f5228bfe67ad58a94ca4e0109b954a baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 118 days Failing since 173470 2022-10-08 06:21:34 Z 117 days 241 attempts Testing same since 176333 2023-02-02 10:51:02 Z 0 days 1 attempts ------------------------------------------------------------ 3471 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine blocked test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf capture-logs broken-step build-armhf host-install(4) Not pushing. (No revision log; it would be 534811 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 02 23:38:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Feb 2023 23:38:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488972.757284 (Exim 4.92) (envelope-from ) id 1pNj95-0003gg-RV; Thu, 02 Feb 2023 23:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488972.757284; Thu, 02 Feb 2023 23:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNj95-0003gZ-Og; Thu, 02 Feb 2023 23:37:35 +0000 Received: by outflank-mailman (input) for mailman id 488972; Thu, 02 Feb 2023 23:37:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNj94-0003gP-BT; Thu, 02 Feb 2023 23:37:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNj94-0001y3-8k; Thu, 02 Feb 2023 23:37:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNj93-0007UO-NX; Thu, 02 Feb 2023 23:37:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNj93-0003vy-Ms; Thu, 02 Feb 2023 23:37:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zLdk6oHZfe6D7pAoov9wEgNS/ZV/F4CgnWprraevufM=; b=26Um3NE5vpzNXOmtiujA/rHtew xVDoGGA70nH0p/s5Nj9W4r1ubBkoG+hQMJD40UNZMqb0vODfUoIAF4UpblZ89HjdxUomrGhkG2cBu YgT9k/D4IE1Id+UhoIHUW7zetJIGmwDeVfzhh57X0vKmKpwze5FERUAUs0bjKFm1FqNA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176339: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e X-Osstest-Versions-That: xen=78e93e6e57c218eead498a664785f414bcb12460 From: osstest service owner Date: Thu, 02 Feb 2023 23:37:33 +0000 flight 176339 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176339/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e baseline version: xen 78e93e6e57c218eead498a664785f414bcb12460 Last test of basis 176337 2023-02-02 17:03:37 Z 0 days Testing same since 176339 2023-02-02 21:02:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Luca Fancellu Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 78e93e6e57..a21c9e6ddf a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 03 01:28:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 01:28:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488980.757296 (Exim 4.92) (envelope-from ) id 1pNks9-0006iS-5u; Fri, 03 Feb 2023 01:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488980.757296; Fri, 03 Feb 2023 01:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNks9-0006iL-1U; Fri, 03 Feb 2023 01:28:13 +0000 Received: by outflank-mailman (input) for mailman id 488980; Fri, 03 Feb 2023 01:28:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNks6-0006iF-VT for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 01:28:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 036d70ba-a362-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 02:28:09 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6B0E661D41; Fri, 3 Feb 2023 01:28:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9FACC433EF; Fri, 3 Feb 2023 01:28:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 036d70ba-a362-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675387686; bh=YDq9DRcIdKEp/Kugr9aBiusQ8u+FDDTKTPm1TZDr/f4=; h=Date:From:To:Cc:Subject:From; b=gvqoqpOSSNib2tlfvK8CGHUCDMHtfqmB61mU6rLB0+nAxmGZ8BWrhDDfM0G/8/mT8 cZ3rqvfGxy6jIdw2sV1vLbFUWMYm6y0SleW7smBAxgJdOWDs1yWrpfOECUkpRQnOAH yLzOkQNAa27uTG95itmWYHH5KldEqiBj12toXdWvkYjGRPJEZpcKkUwT304JFofCLT ayZ3USV8QVWPt7fMVmOfHtwotw1VEhzVEz4yoN4NXm1RSBKYQ/4/V5w3507ctN/SdZ h1JaPYp69xj72VZ274xfpShjvcYtcjjUo8ILQ5FAl78Ld9M1ARS7arvgEa47b2j16W FILdpib+E6imQ== Date: Thu, 2 Feb 2023 19:28:23 -0600 From: "Gustavo A. R. Silva" To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] xen: Replace one-element array with flexible-array member Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct xen_page_directory. This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1]. This results in no differences in binary output. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/255 Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] Signed-off-by: Gustavo A. R. Silva --- drivers/xen/xen-front-pgdir-shbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-front-pgdir-shbuf.c b/drivers/xen/xen-front-pgdir-shbuf.c index 5c0b5cb5b419..b52e0fa595a9 100644 --- a/drivers/xen/xen-front-pgdir-shbuf.c +++ b/drivers/xen/xen-front-pgdir-shbuf.c @@ -30,7 +30,7 @@ struct xen_page_directory { grant_ref_t gref_dir_next_page; #define XEN_GREF_LIST_END 0 - grant_ref_t gref[1]; /* Variable length */ + grant_ref_t gref[]; /* Variable length */ }; /** -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 03:26:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 03:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.488987.757307 (Exim 4.92) (envelope-from ) id 1pNmiW-00041L-H2; Fri, 03 Feb 2023 03:26:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 488987.757307; Fri, 03 Feb 2023 03:26:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNmiW-00041E-Dt; Fri, 03 Feb 2023 03:26:24 +0000 Received: by outflank-mailman (input) for mailman id 488987; Fri, 03 Feb 2023 03:26:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNmiV-000414-P8; Fri, 03 Feb 2023 03:26:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNmiV-0006e9-Ma; Fri, 03 Feb 2023 03:26:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNmiV-0006GR-7G; Fri, 03 Feb 2023 03:26:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNmiV-0008Db-6A; Fri, 03 Feb 2023 03:26:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4741BrB5A5h1iOv77YX5o0P3rS2Ydpfxes+8F0MS3w0=; b=FzuPiEC5W2bXDLVH4ruB5iwpnG wcX6/YwWMwAm4g4AfQm7QEEcW4JQ7FxHQgbvOFSDQt55Fd3I0ef4zfqcbMqMCIp6m7cht4ptUXRwd 1ZEhGIITbZObaG76bsM16g9EPewtd2EifsYJQa8uDN7QUFAJhtf9Pi43s7w8PfeTkv6g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176336: trouble: blocked/broken/fail/pass X-Osstest-Failures: qemu-mainline:build-armhf::broken:regression qemu-mainline:build-armhf:hosts-allocate:broken:regression qemu-mainline:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:nonblocking qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=deabea6e88f7c4c3c12a36ee30051c6209561165 X-Osstest-Versions-That: qemuu=13356edb87506c148b163b8c7eb0695647d00c2a From: osstest service owner Date: Fri, 03 Feb 2023 03:26:23 +0000 flight 176336 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/176336/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf 2 hosts-allocate broken REGR. vs. 176096 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail like 176096 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 176096 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176096 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176096 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu deabea6e88f7c4c3c12a36ee30051c6209561165 baseline version: qemuu 13356edb87506c148b163b8c7eb0695647d00c2a Last test of basis 176096 2023-01-24 12:38:02 Z 9 days Failing since 176332 2023-02-02 10:37:16 Z 0 days 2 attempts Testing same since 176336 2023-02-02 15:38:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Bernhard Beschow Daniel P. Berrangé David Daney Dongdong Zhang Dr. David Alan Gilbert <dgilbert@redhat.com>
Dr. David Alan Gilbert Eric Biggers Greg Kurz Igor Mammedov Jason A. Donenfeld John Snow Maksim Davydov Marc-André Lureau Marcel Apfelbaum Mathias Krause Maxime Coquelin Michael S. Tsirkin Minghao Yuan Peter Delevoryas Peter Maydell Peter Xu Philippe Mathieu-Daudé Stefan Hajnoczi Thomas Huth Vladimir Sementsov-Ogievskiy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf broken build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-step build-armhf hosts-allocate Not pushing. (No revision log; it would be 1562 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Feb 03 06:50:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 06:50:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489012.757317 (Exim 4.92) (envelope-from ) id 1pNpt1-0003De-1K; Fri, 03 Feb 2023 06:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489012.757317; Fri, 03 Feb 2023 06:49:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNpt0-0003DX-Uo; Fri, 03 Feb 2023 06:49:26 +0000 Received: by outflank-mailman (input) for mailman id 489012; Fri, 03 Feb 2023 06:49:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNpsz-0003DN-TB; Fri, 03 Feb 2023 06:49:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNpsz-0003Z2-QK; Fri, 03 Feb 2023 06:49:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNpsz-0000RB-AQ; Fri, 03 Feb 2023 06:49:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNpsz-000143-7a; Fri, 03 Feb 2023 06:49:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0qO+yc/N6kRE9hwExFOkUOqD4mOYi/1LsEugmoMzRj0=; b=QbZ+ieNN76aKYQDef3wuNqQZL9 Ldvi7RH9df5q24Ga1nLLF1Er3tGzm1721IMzy/q4le7GXsFDTw2SgolmVCZrlIgnahMAZXw79zNhR 5Qr/Ar7XSdYvcZCTwz3QCPjdT7GXMwGtT9Ak2ZYqlkz5sYq3dV7oZb8czM+CjSBJfhTA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176341: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=e7368fd30165ced757d64da48e2091c83815ce5c X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Fri, 03 Feb 2023 06:49:25 +0000 flight 176341 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176341/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 173462 build-arm64-pvops 6 kernel-build fail REGR. vs. 173462 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux e7368fd30165ced757d64da48e2091c83815ce5c baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 118 days Failing since 173470 2022-10-08 06:21:34 Z 118 days 242 attempts Testing same since 176341 2023-02-02 22:14:15 Z 0 days 1 attempts ------------------------------------------------------------ 3474 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 535461 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Feb 03 07:05:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 07:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489019.757329 (Exim 4.92) (envelope-from ) id 1pNq8H-0006AH-Ck; Fri, 03 Feb 2023 07:05:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489019.757329; Fri, 03 Feb 2023 07:05:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNq8H-0006AA-9O; Fri, 03 Feb 2023 07:05:13 +0000 Received: by outflank-mailman (input) for mailman id 489019; Fri, 03 Feb 2023 07:05:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNq8F-0005zi-Jr for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 07:05:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062e.outbound.protection.outlook.com [2a01:111:f400:fe0c::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18a6133f-a391-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 08:05:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7133.eurprd04.prod.outlook.com (2603:10a6:800:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Fri, 3 Feb 2023 07:05:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.024; Fri, 3 Feb 2023 07:05:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18a6133f-a391-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1BtWLNf2VrjpPfM57pv2ot1bfuZPXhOspOEB2jjNUUtVWY9y/z8CdgfLe4De43E1659ArpDHYDtKcF2jHaBpbDvlA0m84+ski1r2eiPXFLkTL4yt2GtA0FXDfqM27GXnygbhxbVcu6cHIv8sjGElhPE9WInhfgm6v/ACmhqcbV22b7dIR8Yv1gMeAzgY0+b3kRI1gOycrss8lcoY6mtqFhCIn3Tt6t5vN8Gf0pCo2r9mS/q4b/LFGYZUThlUL6+USil43CdHaVEA76P7Zv/+sz8sLK/s8TAN1WZIWt19SHU2VwTAUeyKNn/w2aFI34hccQ/3yxoyGcnDzcevBpMjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnOUj5TLMf2PZxo7PDKEU2yiIsuRDwt/vGTXTVee/B0=; b=R+jImaa103jDIh3D0PyAenI/aGvkk80ZQqvjWofcuiIG2dtw0Ze9wzbR7TCLTjM8TSC8/YNIaJPKQLCeDS+akGi/kgKIzKQlVglN69GI+tJcCuYpzKUjWH41Ia1WwiY5AxPXcXLt6TihVp+7oSJtpvoqq80kY/z8DVXI65zN4VGm8QtSnuuym/fzOFBlK1IJDeIfuMNyJG6GTzf+DT104ZqtyfE+6FAWNyQcbkeZ2JFB1rM5hg2PHzHu5cLePC3ddNqP2sPmyDN+Wakt6+ukuTMaKPptkCHp59N0yWqAiEVa/BA95MF2A56QGsGqgDB5JaRV1/+pOK7cUKHJvzS6eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnOUj5TLMf2PZxo7PDKEU2yiIsuRDwt/vGTXTVee/B0=; b=h2xNANVDvaruHO2hDp5vCG5Oxwfxsmt6kKeJPLzrx5YMHE5LM+lK+ZKVSIAra7VCHBVy2UUZ6t3Dj3rZ3waltPXaSblzc/KQKen9sId3xJvNHptpZoj/wXlFuChW1zEYeKglyGq7AWeOiwzAeylYinlv/vnU8MlLOVJ3gscfT709YJGqns1JGn3wDYbEXMQHy4q2Ct/kzaRZVFybEdBszGboCsL2o3HNSGGTBpE/3bensDMXtxyvZY03iiHhMbDm8nuuD33YNVXN0Vq27uPzV1rh1/yyBx9aMhZ/cfIaQfs+A1NyHI5vC5sPEWQ0X09rswTYb54yng6pdcqUiEr2vA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <513e2851-9098-b510-588e-1e68d44d23fc@suse.com> Date: Fri, 3 Feb 2023 08:05:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 Content-Language: en-US To: Josef Johansson Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-acpi@vger.kernel.org, Roger Pau Monne , linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> <952fdc14-a8e5-a59a-9c7d-af1adf361d77@oderland.se> From: Jan Beulich In-Reply-To: <952fdc14-a8e5-a59a-9c7d-af1adf361d77@oderland.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7133:EE_ X-MS-Office365-Filtering-Correlation-Id: ace03b3d-b680-43c5-a094-08db05b4fad4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0hV/69WOu7eCLyTjgxftEWTKauPnF0kOJM1a5QkoXU3cHUU8yffCeacgVYZxq0TMqelfMdTqY2wGrVsxslypbeNP7ELXFiP0zZsFUt0eO+w00icoxLmxdK7ym66D+0cbtCJ78FRT+m8ExWyLpHK8ZKP6y7yanU04KjK1xrFzV8E3jTnVg2UW9U51nYi47rbz4S/e4IUjLlT+HFgTn2oJC/OaBPKchTQSWO8sexdSHCnQve9R6FXwn7e37LQENhFvcQeMA8vd3AbiNlbSVxoljloXzbDXXGGSGXKKh9LF1gOCTJf3yq3gzYmG0qTp+GFhiV37FM/+gaz8cMa5jXmyRjPEac6EK8HaRgjqwGfWkwHPHivFCmZipRs9AOQHmMytU5/YbHR7L222aOQLEbkvSC+uhd5rdeL6aB0QFlbl8KwxulgB5dv2CsTzmHXT9oVB4M+Q7vbJA77nTsH8x0lwdk3fjuRqbiclU0YT9uyc3JqPZgMLQiwHTEEMsCcnDxCuro88Xflw2hIZrNWd9pZiB20/jtZzbwi7l8ZUZXIX8ED8TNVtpKh6iIWozbvVydREdcWc0pd22fjdGe3yPlhnC1jxLxGvFo1WoBhlvHBNMQ433cEn+/YbGOSGPk7CMItStBZiY6CkSg1X7VUzlsC36ZDyOdPAxJm93n7gq4YK8jpKQL/ewuPLyaJgOyWi5KiE3pfiswjMed2T3NXVfevUm03IO5RPdifd4QindPmzL2s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199018)(4326008)(66946007)(66556008)(6916009)(8676002)(83380400001)(26005)(8936002)(41300700001)(6506007)(5660300002)(6512007)(66476007)(186003)(31686004)(2906002)(316002)(38100700002)(53546011)(6486002)(6666004)(2616005)(478600001)(31696002)(36756003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWgxYnJDV2FXcUVmcjAydTd0eDR0NlhBc3NNLy9DdmptcTBvUG0yZHZqY2o0?= =?utf-8?B?Wjd5V29ZUnY3bExuMkNkYkIrc3NHVURYMVM1eHA1U1d0WU1Tem5vWWpuaHRQ?= =?utf-8?B?T08xd3U1Z3pKbVA1NDQwT1FWakdsSDlXcWNVUGtYTmpOUFhZc3I4aDhrVzQv?= =?utf-8?B?RFdxS0k4VGM3Yk40cjcvL1NkSTYzQkUzeStoRXRXa08rNjZzbm0yU2c4Y1dm?= =?utf-8?B?LzA1Y05nSUh1ZitkMkg0MzdWUWJjbjc2akpKa25SWk5rWUNiMFZkMFRxeVFC?= =?utf-8?B?UjF3eC9jWE1BLzdrTzJmbGpCOWdjckdUZ2ZMcDVOZHVnVG42cDIreUxYWkUx?= =?utf-8?B?Nml0cWZScXpXTXlPN3c1OVFyUVBQNEpDMkhJaXhuOERaY1c5OXZZeXQ2cGxI?= =?utf-8?B?UUhRUlR5OXFNQm9OQ29XZFBrM2ZmZ3dQaTRwaGJ1Y3FzNUh3WGFuNnBqQURk?= =?utf-8?B?NlozemNnYW5DZFFCYTBsNDdjYTlta1NEK3FTL3hHenZQcDhiWjBUempJMmY5?= =?utf-8?B?Y3JXNDZRb1Y2K2Rzemh4ZXpUS3JtMWRteUpVQnVzT2NKYnlaSkZqUkhnaml5?= =?utf-8?B?T1hCRmwxcHYxL3BHOTZBSmtnY0QvNlB0R3oyQVNVWnRtV2xUSnppS0FxSTl4?= =?utf-8?B?U0xlYWY2NjVLekZJZXpDUERwV2xKb0pORmRyQVREbGdqQmxiaHNIaktCTVBZ?= =?utf-8?B?UE53ZWZMS2lhNXBGamdTcTQzV3N4TXFhSlE1RGlGb1pjSkE1Q1dENjhsd0Fo?= =?utf-8?B?Mnk5OHNtcFdBajBnL0dIem5LUkwwbjBEZW9pZUlmaHQ5SW85QzV3MElsWXRw?= =?utf-8?B?NGhLSnAyeUF0TEViVnVpOEdrVGQ0cVorcEpPeE1SS0hYYUVxSFlBWFNVemNG?= =?utf-8?B?ckd2VnM2ZE9xbVg4NytpQm5jUXVBa0xwb3c3RmtmTitJWjlxVU5ldFNPS0l2?= =?utf-8?B?SXdDcWw1dkJYSCtHS2NLTEZVbXRjQ3N5Z2E5R0NXOFBNdFAwc0w5LzkzeHh0?= =?utf-8?B?SkY2OERhbHR4UmdsSGxCMkNNVXZlYy85dW1TcVBDUFF3NnRkZEtwQWQxN2pt?= =?utf-8?B?QmFPQWdrSmhGekRxZTE3c0hyRG4zNmdIbEpyaklhdVdOOUt3eUMwNEdrNjh5?= =?utf-8?B?NytaYStDcTdvWW44YWZvUk9sMGEzS204ek80NVBGTWFEWjBzQ084WTFYSFNT?= =?utf-8?B?VnpGQzJVUkw2akd6V29QL1FxcjlHQkZCNTNZV2dvZVk3eS9qWjJYQUxxUXRM?= =?utf-8?B?bDhtTUZnR1Jxa3doWmZ3d2FvQWJ4RVNiZGZURXMwSmxyS3ZOMjI1d1g4b1JG?= =?utf-8?B?NlV5d3MzR2FHalFJaUl4MlYvMW9jZDM1YlE5T0F5UmVLVGR3ZTlwL0dtTGNq?= =?utf-8?B?cExVN2g2djQwT3VHWFh5aUlESi9pQ3BYdjl3Y3grcTlGN09VZ0dkV0xXc3Nt?= =?utf-8?B?MEdEK29DbnY2WHdseXNaZ0hKaGJRK3NQQ0pwQTZjRnRXaldGcXlhMUVaWjhi?= =?utf-8?B?cVZBK0pxS3dYV2F5RGlJcmFpdkZnS3llclBQcHE3QUlub0ZJTCttUWVUdHhw?= =?utf-8?B?LzdIb1hEczVqWUIxY2NBMUEwaXBPUlRKc2cvOEI5THZPbGY4b0dCZ0owRk4w?= =?utf-8?B?dHYxR3M3amhyUVA2eXJUTVhjcmJPbTBoWUQ0d1gybGxqMUZRNnhoUHplN1Y0?= =?utf-8?B?VFNjdEZYdHdrYlJYOEVzNitKcFR5TENvTmYzMFdTeTV4QW5lbGRtRVhEQThK?= =?utf-8?B?TVRBQnQ4WkRQYVZ5cEN2VWZaek1GeFJUMis2dzlkeU00UzkvZkgrLzdzTFZV?= =?utf-8?B?T2o5UGxCOWZVY0EwNlZsVlhNUE9sdFJOcFc3bDVxOFFQMVVVSzNneFduSXZ0?= =?utf-8?B?My9KbFc3b2pWaTQ1TTdnM1lhaGJYYW5JSXhtU1NGOHMwSi9LMk1jUVJWQkZj?= =?utf-8?B?RXJnL3ZHMmt6OG1MSDVsWlRMcVhwM3NxVlU5ckxucjJKR1R0MFJiMEtpT254?= =?utf-8?B?cTZSZnRjL0xxMVFhS2NRVmV3WmsvZ3RNVTBGUzRIOCtkZm9CbXZicUhXdnBS?= =?utf-8?B?MVg5ektlSGVLaE85NUw0dVpoT0Fmb1RSQlp1dngwN3VFOEh5U0ppWUhyVlND?= =?utf-8?Q?n6rTn3eevYyvWpeBBa48TlE9q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ace03b3d-b680-43c5-a094-08db05b4fad4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 07:05:06.6985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4WhyymPM/XO21ZNovBoGrzM2UGoqoqGVu3+N4UZLOhoZ2vp4vRzhLppJDJY++whLd7oYVsHFFmXyN3iPOmJNBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7133 On 30.01.2023 10:21, Josef Johansson wrote: > On 11/21/22 11:21, Roger Pau Monne wrote: >> --- a/arch/x86/xen/enlighten.c >> +++ b/arch/x86/xen/enlighten.c >> @@ -346,3 +346,30 @@ void xen_arch_unregister_cpu(int num) >> } >> EXPORT_SYMBOL(xen_arch_unregister_cpu); >> #endif >> + >> +#ifdef CONFIG_XEN_DOM0 >> +bool __init xen_processor_present(uint32_t acpi_id) >> +{ >> + unsigned int i, maxid; >> + struct xen_platform_op op = { >> + .cmd = XENPF_get_cpuinfo, >> + .interface_version = XENPF_INTERFACE_VERSION, >> + }; >> + int ret = HYPERVISOR_platform_op(&op); >> + >> + if (ret) >> + return false; >> + >> + maxid = op.u.pcpu_info.max_present; >> + for (i = 0; i <= maxid; i++) { >> + op.u.pcpu_info.xen_cpuid = i; >> + ret = HYPERVISOR_platform_op(&op); >> + if (ret) >> + continue; >> + if (op.u.pcpu_info.acpi_id == acpi_id) >> + return op.u.pcpu_info.flags & XEN_PCPU_FLAGS_ONLINE; >> + } >> + >> + return false; >> +} > My compiler (Default GCC on Fedora 32, compiling for Qubes) complain > loudly that the below was missing. > > +} > +EXPORT_SYMBOL(xen_processor_present); > > `ERROR: MODPOST xen_processor_present > [drivers/xen/xen-acpi-processor.ko] undefined!` > > Same thing with xen_sanitize_pdc in the next patch. > > +} > +EXPORT_SYMBOL(xen_sanitize_pdc); > > Everything compiled fine after those changes. Except that you may not export __init symbols. The section mismatch checker should actually complain about that. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 03 08:05:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 08:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489032.757340 (Exim 4.92) (envelope-from ) id 1pNr4K-00063A-6x; Fri, 03 Feb 2023 08:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489032.757340; Fri, 03 Feb 2023 08:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNr4K-000633-3G; Fri, 03 Feb 2023 08:05:12 +0000 Received: by outflank-mailman (input) for mailman id 489032; Fri, 03 Feb 2023 08:05:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNr4J-00061T-Iy; Fri, 03 Feb 2023 08:05:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNr4J-0005fG-Fg; Fri, 03 Feb 2023 08:05:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNr4J-0004fw-0C; Fri, 03 Feb 2023 08:05:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNr4I-0000RS-Vp; Fri, 03 Feb 2023 08:05:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D5cSRKzK9DvgHni1eFSnQQyq3//hqN+XlzILrdXz/wg=; b=e6XPJs90flkOuA6iPl/rGow5As 4rDlq7v+UUBH1qFwXbZfudlubGA7WYxGEmMW5KK+peFJYaOIspUnhwRAc/VkRZdsUj2AMoiaVVFNl VBMc/44TG25exsBORxfPUZUKPhlII/vILuU2cPTU7sRekk8jubBMx0zd2tdTtnDxn11I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176338: trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:test-amd64-amd64-xl-shadow::broken:regression xen-4.17-testing:test-amd64-i386-libvirt::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64::broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-libvirt:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-amd64-xl-shadow:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-libvirt:leak-check/check:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Fri, 03 Feb 2023 08:05:10 +0000 flight 176338 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176338/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 176317 test-amd64-amd64-qemuu-freebsd11-amd64 broken in 176317 test-amd64-i386-xl-qemut-win7-amd64 broken in 176317 build-armhf 4 host-install(4) broken in 176317 REGR. vs. 175447 test-amd64-amd64-xl-shadow broken in 176321 test-amd64-i386-libvirt broken in 176321 test-amd64-i386-xl-qemut-ws16-amd64 broken in 176321 build-armhf 3 syslog-server running in 176317 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken in 176317 pass in 176338 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken in 176317 pass in 176338 test-amd64-i386-libvirt 5 host-install(5) broken in 176321 pass in 176338 test-amd64-amd64-xl-shadow 5 host-install(5) broken in 176321 pass in 176338 test-amd64-i386-xl-qemut-ws16-amd64 5 host-install(5) broken in 176321 pass in 176338 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 176317 pass in 176338 test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 176317 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176317 test-amd64-i386-libvirt 23 leak-check/check fail pass in 176317 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 176321 test-amd64-i386-pair 10 xen-install/src_host fail pass in 176321 test-amd64-i386-pair 11 xen-install/dst_host fail pass in 176321 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 176317 n/a build-armhf 5 capture-logs broken in 176317 blocked in 175447 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved in 176317 n/a build-arm64-pvops 2 hosts-allocate starved in 176317 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 43 days Testing same since 176224 2023-01-26 22:14:43 Z 7 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken broken-job build-armhf broken broken-job test-amd64-amd64-xl-shadow broken broken-job test-amd64-i386-libvirt broken broken-job test-amd64-i386-xl-qemut-ws16-amd64 broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489054.757355 (Exim 4.92) (envelope-from ) id 1pNsD6-0006sn-N5; Fri, 03 Feb 2023 09:18:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489054.757355; Fri, 03 Feb 2023 09:18:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD6-0006se-Ir; Fri, 03 Feb 2023 09:18:20 +0000 Received: by outflank-mailman (input) for mailman id 489054; Fri, 03 Feb 2023 09:18:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD4-0006pI-Mi for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aed2bf58-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C6923447B; Fri, 3 Feb 2023 09:18:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FCA31346D; Fri, 3 Feb 2023 09:18:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rJZoBlTR3GMEEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aed2bf58-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lKKJC6YtNCf8aiN934Ne7s/FwvZH2vXGkqQ7iJjfCoc=; b=bIVE2i7Ah9bPQR9b5WIX7DOvSsZvUP1ODjO58clZnz/27q437oW9hjZ9ZWYFmN0UqP58RJ YwyH7w+yPxuTV9r1IqFb27JpdKbHiADMvpq/gI8JGSLxu25kfdODHf/+naoUFbL8V5H+5+ XNcQdKU2va5dmK8e3lMTkPoSfGW+m0E= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 0/7] Mini-OS: ad minimal 9pfs support Date: Fri, 3 Feb 2023 10:18:02 +0100 Message-Id: <20230203091809.14478-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and the verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1201 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 128 +++- xenbus.c | 39 +- 11 files changed, 1378 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489056.757370 (Exim 4.92) (envelope-from ) id 1pNsD7-00079R-VV; Fri, 03 Feb 2023 09:18:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489056.757370; Fri, 03 Feb 2023 09:18:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD7-000793-S6; Fri, 03 Feb 2023 09:18:21 +0000 Received: by outflank-mailman (input) for mailman id 489056; Fri, 03 Feb 2023 09:18:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsD7-0006sG-8I for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1f94e37-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D4C3C20FB1; Fri, 3 Feb 2023 09:18:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AB8B01346D; Fri, 3 Feb 2023 09:18:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oqyuKFnR3GMREwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1f94e37-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z81Lk0F6Fek1HMkTBl7IwshhUmTJkCu1CQ5yFDMGHEk=; b=qPrMTeO36fOo9LpfULKQZr0DuSFU+In+5S3JH3QghH/n9PK7erMaAdu72JKpbbe8/P5tpp arucenRLw4PDxTzX+LHI8sYVY/XY21Ydwt/mmJzhmuQFZgcd/rb8iACWWNas2uVEi0uswy cFcQYoZxRsj2afrV/yqX99DzOtCIlGs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Fri, 3 Feb 2023 10:18:03 +0100 Message-Id: <20230203091809.14478-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common dirctory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross --- include/xenbus.h | 6 ++++++ xenbus.c | 39 ++++++++++++++++++++++++++++++++++++--- 2 files changed, 42 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..811cde25 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,34 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + sscanf(str, "%u", value); + free(str); + + return NULL; +} + /* * Local variables: * mode: C -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489059.757396 (Exim 4.92) (envelope-from ) id 1pNsDH-0007oO-Gn; Fri, 03 Feb 2023 09:18:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489059.757396; Fri, 03 Feb 2023 09:18:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDH-0007oF-D1; Fri, 03 Feb 2023 09:18:31 +0000 Received: by outflank-mailman (input) for mailman id 489059; Fri, 03 Feb 2023 09:18:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDF-0006sG-OB for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:29 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8a0311c-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 079943447D; Fri, 3 Feb 2023 09:18:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2CB01346D; Fri, 3 Feb 2023 09:18:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Jm4sMmTR3GMkEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8a0311c-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415909; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GtWQKRAyY57feFJk8BbUzmL2nez/i6gSp+ydtlu7X9A=; b=W2spmIMlIzYekMsW/Nktfe/U0VVGVGHAsO/wqtUDQBwSfMriG+gLhv4eU8qX16ZeD2kqxU ZwKQEMJBklXMCsymSYU8e5wjFP83bBCQJHQuI898uqC2ZZh+HcL+lDyUoAEP0pp2V4jebs xzCkqi97iujyPKCo0BapNivCn+zUZbs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 3/7] Mini-OS: add support for runtime mounts Date: Fri, 3 Feb 2023 10:18:05 +0100 Message-Id: <20230203091809.14478-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross --- include/lib.h | 5 +++++ lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 1475c621..4171bfd6 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +#ifdef CONFIG_CONSFRONT +#define STATIC_MNTS 4 +#else +#define STATIC_MNTS 2 +#endif +#define DYNAMIC_MNTS 8 + +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489057.757380 (Exim 4.92) (envelope-from ) id 1pNsDE-0007Tx-6g; Fri, 03 Feb 2023 09:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489057.757380; Fri, 03 Feb 2023 09:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDE-0007Tq-3j; Fri, 03 Feb 2023 09:18:28 +0000 Received: by outflank-mailman (input) for mailman id 489057; Fri, 03 Feb 2023 09:18:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDC-0006pI-Ek for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b54821c0-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6FA9D3447B; Fri, 3 Feb 2023 09:18:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 48E911346D; Fri, 3 Feb 2023 09:18:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KfqgEF/R3GMcEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54821c0-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415903; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u/eAoULjmKQ205Pb/0fKq3T8ckSspq3tkjdl4gh7sRs=; b=CWGwhVzTH3faw0JgioySSsL+u67Fu9JB16kROsA1CGyMu8YXLsaqi6t2DmoNR9S94xK3ll Llk00mmYQ9l6l4YZ9nh5mpuGobtmGGRh6AtpEwt5tXQcyUJ2suymbcTAJM9cApjGGe0Ef/ cMbNHex5rMnd25/Ra9QuSHXWbN6emWs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 2/7] Mini-OS: add concept of mount points Date: Fri, 3 Feb 2023 10:18:04 +0100 Message-Id: <20230203091809.14478-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..1475c621 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s) -> %d\n", pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s) -> %d\n", pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489066.757411 (Exim 4.92) (envelope-from ) id 1pNsDP-0008Mc-UT; Fri, 03 Feb 2023 09:18:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489066.757411; Fri, 03 Feb 2023 09:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDP-0008MR-Qf; Fri, 03 Feb 2023 09:18:39 +0000 Received: by outflank-mailman (input) for mailman id 489066; Fri, 03 Feb 2023 09:18:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDO-0006pI-2u for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc0146c9-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:34 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96F2020FB2; Fri, 3 Feb 2023 09:18:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 678211346D; Fri, 3 Feb 2023 09:18:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cND9F2rR3GMzEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc0146c9-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iYbZqvNtZ/TCv37DDm/n8MEFIvNUWO9D/z+764HvEc=; b=PvSNSH+NewoOoU0ugPNEvH9zAz1FTuOTWeZRPgVfEAh2zOCt3CuVjrHsE/PVoffjxKN0EU JcvwnbAM8zx6M0mTZvzKCKjkZwm0qKCCIXNoNsUkPEH29Vb9hOPSYxgplT9PLN5adHiTON oTi/haqrs6ss8lsydRGnu13UQJRB4Q0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 4/7] Mini-OS: add 9pfs frontend Date: Fri, 3 Feb 2023 10:18:06 +0100 Message-Id: <20230203091809.14478-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross --- 9pfront.c | 280 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 292 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..cf4b5cb3 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,280 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 ) + { + v = NULL; + break; + } + } + free(version); + if ( v ) + { + reason = "version 1 not supported"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489072.757431 (Exim 4.92) (envelope-from ) id 1pNsDT-0000eH-QV; Fri, 03 Feb 2023 09:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489072.757431; Fri, 03 Feb 2023 09:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDT-0000e6-Jh; Fri, 03 Feb 2023 09:18:43 +0000 Received: by outflank-mailman (input) for mailman id 489072; Fri, 03 Feb 2023 09:18:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDS-0006sG-E6 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf4baddc-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:40 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3189320FB2; Fri, 3 Feb 2023 09:18:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03E6F1346D; Fri, 3 Feb 2023 09:18:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id FRRGO2/R3GNDEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf4baddc-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YKIS+Tj09UAtPDRHqh2MXWRos25VF1afTytdwvl7/5k=; b=KUuyPjwItpYs63kRYfGt/5oRDVOKuvoVf8vbVqFDCIx95OBQl8iVgUgkJHS5CRDVv/m8g7 EaGuJFoNQ313RSHZpRbvLvAPkx39b+PQFviBZwgjoZZp2JJa8EOTpZATR0RFk5XJ/LDiSF iAuxKUZNA28rNLGDbAMyUv39EQdaw00= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 5/7] Mini-OS: add 9pfs transport layer Date: Fri, 3 Feb 2023 10:18:07 +0100 Message-Id: <20230203091809.14478-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross --- 9pfront.c | 451 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 451 insertions(+) diff --git a/9pfront.c b/9pfront.c index cf4b5cb3..f6fac50a 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,443 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + len = *len1; + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[13]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +522,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -199,6 +644,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:18:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:18:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489077.757441 (Exim 4.92) (envelope-from ) id 1pNsDZ-00019E-2e; Fri, 03 Feb 2023 09:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489077.757441; Fri, 03 Feb 2023 09:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDY-000191-Uc; Fri, 03 Feb 2023 09:18:48 +0000 Received: by outflank-mailman (input) for mailman id 489077; Fri, 03 Feb 2023 09:18:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDW-0006sG-Qr for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2af7a08-a3a3-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 10:18:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DCDDF20FB3; Fri, 3 Feb 2023 09:18:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B12891346D; Fri, 3 Feb 2023 09:18:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qiq+KXXR3GNOEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2af7a08-a3a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTiD9k1sCY7qPC5hUeI+17ax3Vq23ag+y7zk3UOd7aM=; b=SLfU45Jhn6S379Qf7olIldMyNbApKjP//8ON7kw9NH2TA2HhAExqlDviup7UwFR8krpqGm cl7Yqor4zT6gA1x/RrG419ScopckPtWmEuzvQGnGzygUL25bfNvZUaou/IWHJzZpn2HhB+ 6DWrguxS5RC/61hvj9l6XxIBLOk/3ws= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Fri, 3 Feb 2023 10:18:08 +0100 Message-Id: <20230203091809.14478-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. The opened file needs to be queried via stat in order to obtain the data needed for proper access (access rights, size, type of file). Signed-off-by: Juergen Gross --- 9pfront.c | 285 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 283 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index f6fac50a..ebe48601 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ struct p9_header { uint32_t size; @@ -67,10 +87,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= 1ULL << (fid - 1); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -138,6 +175,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -151,7 +191,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -165,6 +207,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -194,6 +244,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -263,6 +321,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -320,6 +379,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -459,6 +522,134 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[13]; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + else + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "uQ", &nqid, qid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[13]; + uint32_t iounit; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[13]; + uint32_t iounit; + + if ( !req ) + return ENOENT; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -477,10 +668,98 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname + strlen(mnt->path), &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -525,6 +804,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -720,6 +1000,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:25:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489109.757456 (Exim 4.92) (envelope-from ) id 1pNsKB-0003xt-5j; Fri, 03 Feb 2023 09:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489109.757456; Fri, 03 Feb 2023 09:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsKB-0003xm-2f; Fri, 03 Feb 2023 09:25:39 +0000 Received: by outflank-mailman (input) for mailman id 489109; Fri, 03 Feb 2023 09:25:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsDf-0006pI-R8 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:18:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5face31-a3a3-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:18:51 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7053320FB3; Fri, 3 Feb 2023 09:18:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4555A1346D; Fri, 3 Feb 2023 09:18:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9tKnD3vR3GNUEwAAMHmgww (envelope-from ); Fri, 03 Feb 2023 09:18:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5face31-a3a3-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675415931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Idrvyq/CByJ2DQQaGlOqPT2h9f5xudP46VSUBxT02f4=; b=WCQLk/QNq/M3jtl676+Yekybd2+OHWkHTOJVlXFQBkfIH5X6FBwVSiLfrd0f7L5TsqsUT8 mKYp2zgWqZzwgyCUmMlt+tCS08ZXNNHI9ikDDCfpqNTYAy0mtI3yBzClQ6AnoFCa2p266N HOMi8OXMPyPbsE38ZSWpET58cGWFibY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Date: Fri, 3 Feb 2023 10:18:09 +0100 Message-Id: <20230203091809.14478-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230203091809.14478-1-jgross@suse.com> References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- 9pfront.c | 189 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 189 insertions(+) diff --git a/9pfront.c b/9pfront.c index ebe48601..45f2f9a9 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -86,11 +89,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[13]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -179,9 +210,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -190,10 +224,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -219,11 +255,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -256,12 +302,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -323,6 +379,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -387,6 +445,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -394,6 +456,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); @@ -608,6 +676,88 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return ENOENT; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret; + uint32_t count; + + if ( !req ) + { + errno = EIO; + return -1; + } + + req->cmd = P9_CMD_READ; + send_9p(dev, req, "ULU", fid, offset, len); + rcv_9p(dev, req, "D", &count, data); + + if ( req->result ) + { + ret = -1; + errno = EIO; + } + else + ret = count; + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret; + uint32_t count; + + if ( !req ) + { + errno = EIO; + return -1; + } + + req->cmd = P9_CMD_WRITE; + send_9p(dev, req, "ULD", fid, offset, len, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + } + else + ret = count; + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -668,6 +818,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1000,6 +1187,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 09:30:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 09:30:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489123.757471 (Exim 4.92) (envelope-from ) id 1pNsP3-0005UP-PN; Fri, 03 Feb 2023 09:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489123.757471; Fri, 03 Feb 2023 09:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsP3-0005UI-Ma; Fri, 03 Feb 2023 09:30:41 +0000 Received: by outflank-mailman (input) for mailman id 489123; Fri, 03 Feb 2023 09:30:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNsP2-0005UA-1z for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 09:30:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1b::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69ea88e3-a3a5-11ed-9254-a70e01b1f5fa; Fri, 03 Feb 2023 10:30:36 +0100 (CET) Received: from DUZPR01CA0143.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bd::8) by DB9PR08MB9609.eurprd08.prod.outlook.com (2603:10a6:10:456::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Fri, 3 Feb 2023 09:30:33 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bd:cafe::25) by DUZPR01CA0143.outlook.office365.com (2603:10a6:10:4bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29 via Frontend Transport; Fri, 3 Feb 2023 09:30:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28 via Frontend Transport; Fri, 3 Feb 2023 09:30:33 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Fri, 03 Feb 2023 09:30:33 +0000 Received: from 2d13f1f8dc08.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59AA9E84-DD9B-4384-BFB6-EDF221C0024D.1; Fri, 03 Feb 2023 09:30:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2d13f1f8dc08.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 03 Feb 2023 09:30:25 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB9534.eurprd08.prod.outlook.com (2603:10a6:10:44e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28; Fri, 3 Feb 2023 09:30:23 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.027; Fri, 3 Feb 2023 09:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69ea88e3-a3a5-11ed-9254-a70e01b1f5fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q3UXGkM8sEuphNbb6hidIEP8SyILN4ARAxcRLlt4LEo=; b=e897JJAsyIQNgdUSCqMCw03DafvCtSLwF2wmROJWCB8ltzr4qzfgySi6IjtmEjxnTXAvGK0TgfQ3n3JlhE0PgnrRBnwH7B3T2QGhIX6hiQU1S54iW9g+NiwbKjLOCkPd7i1soSEH4AXvNC0NbdY/wR6acC60g9nBc00M1RIC0sA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a8e37d4e84fe9187 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8apfnEPmlIpAwqqoSI4MQIb/wfP3oosxM+exw2EwfG9CvVzOiemGlrmaD8aody19yxWxtfZakfCziAtoDxrCea6TvGRwt8/EGbRz5Xhz+KO+001IlKHqhsbgJhQrDDwGSrwFK02mVVNebisPHWbvtHs46ZSrx56gQFoSSJKT8+J3c7zVaKjLHAHPW1qlN4skwWGUvzJIgZ3TNYSSXtX69Qj4R7ReJ1FUCpTh+qXsuHC2UeSqOchtuvZyjrLzsbKz1qQ7eQ/c01/VzzuD/Mgt5jWOPdWYF7vXlWK578xZv4YIKavlAxiD9btBiTLkk0w+VnixAcUyL3NApM0NrN/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q3UXGkM8sEuphNbb6hidIEP8SyILN4ARAxcRLlt4LEo=; b=OYWVsCG8vUgE2jksEchCnQajOh5HDakAaM5f451w9SaDqiJYT0KTapi/vmOWqFjfrgcFOeVOygUPBnaakLI5J8tg728AOb+qC8cleMXHyeDm3OQu5KTrIdKm3ARw3Kvk1KWipuNsPTF66p557G3lixL4b9gSUtOGw09ZpPX23Xoo8+9UG9sgT/fBWsT9m52Q5jKaSpRd62kQpyuikrePNf+pIZG0EGl2Zt2bdwBUr0RUK3+pXuZ06eC3FvJSFHL5JrYaYo9DMQkZv98rm752CqAkDIhoMrtrXd4AtuLDgDVW8bB9lcYLuwFE7DN308GYCpSZRu17tZ3FqycvvL+ySA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q3UXGkM8sEuphNbb6hidIEP8SyILN4ARAxcRLlt4LEo=; b=e897JJAsyIQNgdUSCqMCw03DafvCtSLwF2wmROJWCB8ltzr4qzfgySi6IjtmEjxnTXAvGK0TgfQ3n3JlhE0PgnrRBnwH7B3T2QGhIX6hiQU1S54iW9g+NiwbKjLOCkPd7i1soSEH4AXvNC0NbdY/wR6acC60g9nBc00M1RIC0sA= From: Luca Fancellu To: Xen-devel CC: Stefano Stabellini , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall Subject: Proposal: List files in Xen originated from external sources Thread-Topic: Proposal: List files in Xen originated from external sources Thread-Index: AQHZN7IjdE2jT11hbUWRAoU6FDszqA== Date: Fri, 3 Feb 2023 09:30:22 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.300.101.1.3) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB9534:EE_|DBAEUR03FT035:EE_|DB9PR08MB9609:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c6e7b72-a12b-42f7-19ba-08db05c94c9b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C9zD85RqgZKNMbFz/fkbaoJnppy8kLwuzRMykWPhMZjYxRCtauVLvtuj58Ty69EuOZhzYFAY1DDgE4sQ0JOL77doq/8GhXjbn0pqtleQDly8mAIdv3OYydGfLy7UWlOdtrzSGEzh+7qAu1vIzSb8V80eyzk3/v9C9vXglbLgLrkX1qJZ0jm94NJqEPLWndiUBZ0MXzhpjcrJCmGaDFOJTbyHBUl0v0jK3bo0T9Ia/uAWAs1M3W+lCbSq+53uecDiIBaKrVBiFaN39HGPHQH6v3kDczTw6f0ip5LMlT7dfPYUj2LLQfha0tq/eMX53Xp+IB2vD4TlCv0mDCXCpN/T2uytgWV864L9kuAoAOJUNb5iqOTq3NJ5iFBcUJglB6PPq+/uTPPg8VXHNKxIJuSsNnbSr1aJlfcz0wqmLL7W2atTD9IWd1LGJ3aHPjACUapvCh4k68r+FKzjQM3yhDtezmpFevyL7ACUf7+QXb+NsPat9nGdOifPXjy9OQ61ysaX3TcN/4XaMrbfwpdUPyWSPUzdBX1MjiMguAVEio1y0ZRVtjTc9kMo8gn819wEs53shA+zd83TlQ7XdNmCAtlglUs+Y8pm3V1tCCyMC5ESzublKpkOaVqi4I5/qos0NWzVF6oxAzPud5LbukWx5BqABorQ00bCbYl26YgNizSCacFAyQuX4j/vCAoKSQtP+otXw+JFurGML+0wcPvKCzzq59hiLAJSHdtf4yZWA4fxLQPvPs8pQRciVijThgP9ypK4UYJg8ZtWgFFmU13RMvGjew== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199018)(26005)(186003)(6512007)(122000001)(5660300002)(8936002)(38100700002)(71200400001)(2906002)(6506007)(33656002)(41300700001)(38070700005)(36756003)(64756008)(2616005)(966005)(86362001)(6486002)(6916009)(4326008)(8676002)(66446008)(66946007)(76116006)(54906003)(66556008)(66476007)(478600001)(316002)(83380400001)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9534 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a22df167-4223-49a3-a1f8-08db05c94659 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4Nsw+PUk6Must/p2LWfwEjahtWm7asMrs4N7//rFNh0AuPkGsWpbXSP/ixu0lxV9Wz0a9HU+zg0m4n+xDuy9RXJC8ucBky2vsOaKWs4S1FhaK+TUzXmtQcewn3Jpg4YMnfmQklpyWMx+vL3H2nbw9ae8Qm4dVcO963qrPDOc61qOBJ1g5GooP06XnNB/jAxlUEYei92NgZLVQJMbk2+it7JDj9I47iC8T4rvQUa53b5KeVfvpRiVtamq1Q4UoZ5oIdD9j/o7mU4xbDc9DqX020E9gVBRydFPNbB1JubzcHzAycmXRpiz0P6ojYBufHlAT/b2TmN7Bg5wGxLXSZ68fgG+R9tUF49ZBWRPzsBqSNRc06Ut4Z0TgS/J4luaThdsciHi4i02AAl/R+V8PJFJw2imZOjV1Ee7Zq9JLHmJr2d1tip1UtVcut/SDDIA0a2OQa5jaaj3JSy2hmeA2Z66fWlgHB03tvFfAHZva9ma5pvKCB91JoWgZAiPgxMtlq2IF2YkXRITAcuQ04icfx2jEvOJJHcJu463LnT8b+GyImWnR2oZF2UY0GdPQFfobLsbfRVbyhJ6kdjGFPgy+abPSaxmzBgufjqjrzu3ZsR6C9Rcx2K8VLT+REAtbdZ0ZgjJuEc1MJCPhJ3KHmZ0wY/Ib5zmAir4CQ9OtkP2Il1eHpLQURfhewVh/ph2DFKwMNgbHqyDuMxj8h4Ohpdx23+cgFIyPwLEQTe/9GiLLFyU7c= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199018)(36840700001)(40470700004)(46966006)(186003)(6512007)(4326008)(26005)(2616005)(6506007)(8676002)(6916009)(70206006)(70586007)(82310400005)(54906003)(5660300002)(47076005)(336012)(83380400001)(478600001)(2906002)(36756003)(86362001)(40480700001)(36860700001)(82740400003)(33656002)(40460700003)(8936002)(316002)(966005)(356005)(41300700001)(6486002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 09:30:33.4699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c6e7b72-a12b-42f7-19ba-08db05c94c9b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9609 SGkgYWxsLA0KDQpJ4oCZbSBzdGFydGluZyBhIHByb3Bvc2FsIGZvciB0aGUgZXh0ZXJuYWwgZmls ZXMgdGhhdCBuZWVkcyB0byBiZSByZW1vdmVkIGZyb20gdGhlIE1JU1JBIHNjYW4sDQp0aGUgd29y ayB3YXMgb3JpZ2luYWxseSBzdGFydGVkIGJ5IE1pY2hhbCBoZXJlOg0KaHR0cHM6Ly9wYXRjaHdv cmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9wYXRjaC8yMDIyMTExNjA5MjAzMi40NDIz LTEtbWljaGFsLm9yemVsQGFtZC5jb20vDQpzbyBJIHN0YXJ0ZWQgYnkgdGhhdCB0aHJlYWQsIHRo ZSBhaW0gb2YgdGhpcyB3b3JrIGlzIHRvIGhhdmUgYW4gaW5pdGlhbCBmb3JtYXQgdG8gc3RhcnQg YXMgc29vbiBhcyBwb3NzaWJsZSB0bw0KZXhjbHVkZSB0aGUgZXh0ZXJuYWwgZmlsZXMgZnJvbSB0 aGUgTUlTUkEgc2NhbiAoYXQgbGVhc3QgaW5pdGlhbGx5IGZyb20gY3BwY2hlY2spLg0KDQpJIHRo aW5rIHdlIGNhbiB1c2UgdGhlIEpTT04gZm9ybWF0IGJlY2F1c2UgaXTigJlzIGVhc3kgdG8gaW50 ZWdyYXRlIGl0IHdpdGggcHl0aG9uIGFuZCBpdOKAmXMgZWFzeSB0byBhZGQvcmVtb3ZlDQpmaWVs ZHMgZnJvbSB0aGUgc3RydWN0dXJlIHdpdGhvdXQgaW50ZXJmZXJpbmcgd2l0aCB0aGUgb3RoZXIg ZWxlbWVudHMgZHVyaW5nIHRpbWUsIHNvIHdlIGNhbiBkZWZpbmUgYSBzdHJ1Y3R1cmUNCm5vdyBi dXQgaWYgaW4gdGhlIGZ1dHVyZSB3ZSBzZWUgdGhlIG5lZWRzIGZvciBhZGRpdGlvbmFsIGZpZWxk LCB3ZSBjYW4ganVzdCBhZGQgdGhlbSB3aXRob3V0IGNoYW5nZXMgdG8gdGhlDQphbmFseXNpcyBz Y3JpcHQuDQoNCkluIG15IG9waW5pb24gbWFueSBvZiB0aGVzZSBmaWVsZHMgY2FuIGJlIGxlZnQg ZW1wdHkgaW4gYSBmaXJzdCBwdXNoLCB0byBsZXQgdGhlIHNjcmlwdCBleGNsdWRlIHRoZSBmaWxl cyBhbmQgZHVyaW5nDQp0aW1lIHdpdGggdGhlIGNvbnRyaWJ1dGlvbnMgb2YgdGhlIGNvbW11bml0 eSB3ZSBjYW4gYWRkIHRoZSBtaXNzaW5nIGluZm9ybWF0aW9ucy4NCkkgdGhpbmsgaXTigJlzIGVh c2llciBmb3IgdGhlIGNvbW11bml0eSB0byBwaWNrIGFuIGVudHJ5LCBkbyBzb21lIHJlc2VhcmNo IHRvIGZpbGwgdGhlIGdhcHMgYW5kIHB1c2gsIGluc3RlYWQgdG8gd2FpdA0KdW50aWwgaGF2aW5n IGFsbCB0aGUgaW5mb3JtYXRpb25zIGJlZm9yZSBhZGRpbmcgdGhlIGVudHJ5Lg0KDQoNClRoaXMg aXMgbXkgZmlyc3QgdGhvdWdoIGZvciB0aGUgZmllbGRzLCBsZXQgbWUga25vdyB5b3VyczoNCg0K ZG9jcy9taXNyYS9leHRlcm5hbC1maWxlcy5qc29uOg0Kew0KICJ2ZXJzaW9uIjogIjEuMOKAnSwN CiAiY29udGVudCI6IFsNCiAgIHsNCiAgICAgInBhdGgiOiAicmVsYXRpdmUvcGF0aC9mcm9tL3hl bi/igJwsDQogICAgICJiYWNrcG9ydCI6IFRydWUvRmFsc2UsDQogICAgICJvcmlnaW5fcHJvamVj dCI6ICJVUkwgdG8gb3JpZ2luIHByb2plY3QiLA0KICAgICAib3JpZ2luX3BhdGgiOiAicmVsYXRp dmUgcGF0aCBpbiB0aGUgb3JpZ2luYWwgcHJvamVjdCIsDQogICAgICJvcmlnaW5fcmV2aXNpb24i OiAicmV2aXNpb24gaW4gb3JpZ2luYWwgcHJvamVjdOKAnQ0KICAgfQ0KIF0NCn0NCg0KDQpNYXli ZSwgZG9jdW1lbnRhdGlvbiBmb3IgdGhpcyBmaWxlIGFuZCB0aGUgZmllbGRzIGNhbiByZXNpZGUg aW4gZG9jcy9taXNyYS9leHRlcm5hbC1maWxlcy5yc3QuDQoNCkhlcmUgZm9sbG93cyB0aGUgZXhw bGFuYXRpb24gZm9yIHRoZSBmaWVsZHM6DQoNCnBhdGg6IGlzIGEgcmVsYXRpdmUgcGF0aCBmcm9t IHRoZSB4ZW4gYmFzZSBmb2xkZXIsIGl0IGNhbiByZWZlciB0byBhIGZpbGUgb3IgaXQgY2FuIGJl IGEgcGF0aCB0byBhbiBlbnRpcmUgZm9sZGVyDQogICAgICAgICAoVGFraW5nIGFzIGV4YW1wbGUg bGliZmR0KQ0KDQpiYWNrcG9ydDogaXTigJlzIGEgYm9vbGVhbiBmbGFnIHRoYXQgc2F5cyBpZiB0 aGUgZmlsZSBpcyBzdWJqZWN0IHRvIGJhY2twb3J0LCBzbyBldmVyeSBmaWxlIHdoZXJlIHRoaXMg ZmllbGQgaXMgdHJ1ZQ0KICAgICAgICAgICAgICAgIHdvbuKAmXQgYmUgaW5jbHVkZWQgaW4gdGhl IGFuYWx5c2lzLiBBIGZpbGUgaXMgc3ViamVjdCB0byBiYWNrcG9ydCB3aGVuIGl04oCZcyBleHRl cm5hbCBhbmQgaXQgZG9lc27igJl0DQogICAgICAgICAgICAgICAgYWNjZXB0IGRpcmVjdCBjaGFu Z2VzIChjaGFuZ2VzIG5lZWRzIHRvIGJlIG1hZGUgaW4gdGhlIG9yaWdpbmFsIHByb2plY3QgYW5k IHRoZW4gYmFja3BvcnRlZA0KICAgICAgICAgICAgICAgIHRvIFhlbikNCg0Kb3JpZ2luX3Byb2pl Y3Q6IHVybCBvZiB0aGUgcmVwb3NpdG9yeSB3aGVyZSB0aGlzIGZpbGUgd2FzIG9yaWdpbmF0ZWQN Cg0Kb3JpZ2luX3BhdGg6IHJlbGF0aXZlIHBhdGggaW4gdGhlIG9yaWdpbmFsIHByb2plY3QsIG1v c3RseSBsaW5rZWQgdG8gdGhlIG9yaWdpbmFsX3JldmlzaW9uIGZpZWxkDQoNCm9yaWdpbl9yZXZp c2lvbjogcmV2aXNpb24gb2YgdGhlIGNoYW5nZXMgaW4gdGhlIHJlcG9zaXRvcnkgd2hlbiB0aGlz IGZpbGUgd2FzIHRha2VuLg0KDQoNCk5vdywgSeKAmW0gbm90IGVudGlyZWx5IHN1cmUgYWJvdXQg dGhlIGZpZWxkIOKAnGJhY2twb3J04oCdLCBiZWNhdXNlIGlmIGEgZmlsZSBpcyBub3Qgc3ViamVj dCB0byBiYWNrcG9ydCwgdGhlbiB3aHkNCndlIHNob3VsZCBub3QgbWFrZSBkaXJlY3QgY2hhbmdl cz8gU2hhbGwgd2UgbWF5YmUgY2hhbmdlIGl0cyBjb2Rlc3R5bGUgYW5kIGNvbnZlcnQgaXQgdG8g WGVuIGNvZGVzdHlsZT8NCkFuZCB0aGVuLCBpZiB0aGUgZmlsZSBpcyBub3Qgc3ViamVjdCB0byBi YWNrcG9ydCBhbmQgbm93IHdlIOKAnG93buKAnSB0aGUgZmlsZSwgdGhlcmUgaXMgbm8gbW9yZSB0 aGUgbmVlZCB0byBsaXN0IGl0DQppbiB0aGUgZXh0ZXJuYWwgZmlsZSwgYSBjb21taXQgc2VhcmNo IGNhbiByZXZlYWwgd2hlbiBpdCB3YXMgY29udmVydGVkIHRvIFhlbiBjb2Rlc3R5bGUgYW5kIHJl bW92ZWQgZnJvbQ0KdGhlIGV4dGVybmFsIGZpbGUgbGlzdCBzbyB3ZSBkb27igJl0IGxvc2UgdGhl IGhpc3RvcnkuDQpTbyB3ZSB3b3VsZCBlbmQgdXAgZXhjbHVkaW5nIGp1c3QgYWxsIHRoZSBmaWxl IGxpc3RlZCBpbiBleHRlcm5hbC1maWxlLmpzb24gYnkgdGhlIGFuYWx5c2lzLg0KDQpXaGF0IGFy ZSB5b3VyIHRob3VnaHRzIGFib3V0IHRoYXQ/IFRoYW5rIHlvdQ0KDQoNCkNoZWVycywNCkx1Y2E= From xen-devel-bounces@lists.xenproject.org Fri Feb 03 12:51:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 12:51:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489166.757481 (Exim 4.92) (envelope-from ) id 1pNvWl-0002e8-Tz; Fri, 03 Feb 2023 12:50:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489166.757481; Fri, 03 Feb 2023 12:50:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvWl-0002e1-R1; Fri, 03 Feb 2023 12:50:51 +0000 Received: by outflank-mailman (input) for mailman id 489166; Fri, 03 Feb 2023 12:50:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvWl-0002dv-BF for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 12:50:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61ca4dbc-a3c1-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 13:50:49 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 85686346CF; Fri, 3 Feb 2023 12:50:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 645991358A; Fri, 3 Feb 2023 12:50:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tUvmFigD3WPAcQAAMHmgww (envelope-from ); Fri, 03 Feb 2023 12:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61ca4dbc-a3c1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675428648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQz6KReeIBnxU3F9c9Bu3VhouAL47OPI7ut9qgu2Ddo=; b=DBFd9FzepLsReMCht9jqEuhhcnjKAzKnOKIbrGxXeHiSr0sfF7ofQTwocGsoYSvABo5JHk 2eL0tVgGVT2cPTx0AmIUTy/uVx+y2t+L++216P+Sf518+kjN7Yo5X2Ic4ovTHZNCZFoao9 shFLf5AXklQN65zdkDYZzP4pcNUvoJY= Message-ID: Date: Fri, 3 Feb 2023 13:50:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> From: Juergen Gross In-Reply-To: <20230203091809.14478-7-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kCVE4JPEmlHYhI2VUIUK1icS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kCVE4JPEmlHYhI2VUIUK1icS Content-Type: multipart/mixed; boundary="------------a8J3SxOE2EmF53jgtBnHlxHu"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> In-Reply-To: <20230203091809.14478-7-jgross@suse.com> --------------a8J3SxOE2EmF53jgtBnHlxHu Content-Type: multipart/mixed; boundary="------------ReT8a7108Yc03RHhExnd7ha3" --------------ReT8a7108Yc03RHhExnd7ha3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMTA6MTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEFkZCB0aGUgb3Bl bigpIGFuZCBjbG9zZSgpIHN1cHBvcnQgdG8gdGhlIDlwZnMgZnJvbnRlbmQuIFRoaXMgcmVx dWlyZXMNCj4gdG8gc3BsaXQgdGhlIHBhdGggbmFtZSBhbmQgdG8gd2FsayB0byB0aGUgZGVz aXJlZCBkaXJlY3RvcnkgbGV2ZWwuDQo+IA0KPiBUaGUgb3BlbmVkIGZpbGUgbmVlZHMgdG8g YmUgcXVlcmllZCB2aWEgc3RhdCBpbiBvcmRlciB0byBvYnRhaW4gdGhlDQo+IGRhdGEgbmVl ZGVkIGZvciBwcm9wZXIgYWNjZXNzIChhY2Nlc3MgcmlnaHRzLCBzaXplLCB0eXBlIG9mIGZp bGUpLg0KDQpPaCwgc29ycnksIHRoaXMgcGFyYWdyYXBoIHNob3VsZCBiZSBkcm9wcGVkLg0K DQoNCkp1ZXJnZW4NCg== --------------ReT8a7108Yc03RHhExnd7ha3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ReT8a7108Yc03RHhExnd7ha3-- --------------a8J3SxOE2EmF53jgtBnHlxHu-- --------------kCVE4JPEmlHYhI2VUIUK1icS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPdAycFAwAAAAAACgkQsN6d1ii/Ey+P bwf+LfAWnaVYLyqy6zLJKxcMUi3OMdtmgoToAi00iP7ynTAn1uqwjweI+ySzfYtB32eMLZwffUTk QvPy4rGHg/mj7tSdYz+ksqFNo4WrM4JWZjYz0Me40zoj1tk+GjpYY+YYWdKS9jEKKrxeLOVGvv7d L1XGcgnDA8c3ZzDPPHixTAPSgKmhyR8NPM1J0jGN6TrclXLwMwXi1ayCcBP4yWanQJCF0GT3HulB V3TeYV1g1bMEHhtg3Ha4crGq2cheShocveGaaPBBvDhvgp7QmR6zqtfTe7/2TlKvlZu35mNq3g5x GiLW+zGg9er1WpMYo147OrRs6FwlRiFBWUiLQA1/Kw== =8gRQ -----END PGP SIGNATURE----- --------------kCVE4JPEmlHYhI2VUIUK1icS-- From xen-devel-bounces@lists.xenproject.org Fri Feb 03 12:52:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 12:52:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489174.757497 (Exim 4.92) (envelope-from ) id 1pNvYG-0003EL-8t; Fri, 03 Feb 2023 12:52:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489174.757497; Fri, 03 Feb 2023 12:52:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvYG-0003EC-6D; Fri, 03 Feb 2023 12:52:24 +0000 Received: by outflank-mailman (input) for mailman id 489174; Fri, 03 Feb 2023 12:52:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvYF-0003E4-Hy for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 12:52:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9989a0b3-a3c1-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 13:52:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5F3E6346D8; Fri, 3 Feb 2023 12:52:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 38D891358A; Fri, 3 Feb 2023 12:52:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rONyDIYD3WOpcgAAMHmgww (envelope-from ); Fri, 03 Feb 2023 12:52:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9989a0b3-a3c1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675428742; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvt2+Gv/dBnKSemdRNIgG5off+fk9kijKWONvjmudx8=; b=QNAvTrzeqiXR+KjOVuD4E6UQsDNupUCR9HsYLS8DKnAnnCdN6Z5MgGTfz5olpazSaPPZdG cYKtdm+dsT1dSGRf1bvPmipM3NvH1obcgxwtzeGhXnvd9vBe/AcO69t83b1bfmYAl3CuMv 7/HcOpqrfomuwp01zNztjvZgxdgBoMY= Message-ID: Date: Fri, 3 Feb 2023 13:52:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> From: Juergen Gross In-Reply-To: <20230203091809.14478-8-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YI0KurEEFOlVNx7w638kODkU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YI0KurEEFOlVNx7w638kODkU Content-Type: multipart/mixed; boundary="------------6e7YkB0oaWewm8HvMsuQzKDP"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> In-Reply-To: <20230203091809.14478-8-jgross@suse.com> --------------6e7YkB0oaWewm8HvMsuQzKDP Content-Type: multipart/mixed; boundary="------------t98G7AeIYauxvE7mHeLkHJv3" --------------t98G7AeIYauxvE7mHeLkHJv3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMTA6MTgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEFkZCBzdXBwb3J0 IHRvIHJlYWQgZnJvbSBhbmQgd3JpdGUgdG8gYSBmaWxlIGhhbmRsZWQgYnkgOXBmc2Zyb250 Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pg0KDQpUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24gb2YgcmVhZC93cml0 ZSBtZXNzYWdlcyB0byBzdGF5DQpiZWxvdyB0aGUgbWF4LiBzdXBwb3J0ZWQgbWVzc2FnZSBz aXplLg0KDQoNCkp1ZXJnZW4NCg0K --------------t98G7AeIYauxvE7mHeLkHJv3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------t98G7AeIYauxvE7mHeLkHJv3-- --------------6e7YkB0oaWewm8HvMsuQzKDP-- --------------YI0KurEEFOlVNx7w638kODkU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPdA4UFAwAAAAAACgkQsN6d1ii/Ey+3 Kwf/UvRzwAqEoNFMUpCXRjeXxJwiUBdKCMyXxZ17/p9ZkBotb1CTuegUauvU3j1QF84yS3J234Gv 1ufy25E38IV06eVrUDYGUlTeHNB5l2rpw1DkA2MkGasIVsoIHdkoMglur2bviFUmiJ7d6xzVkrb5 S8z/QjrBRpm65+NDtsFYm7k3x5n7eh1eTRsb+cfmL4Yw2IvHWKNsO1/jqlaKUwC4dA4j6UP9Vmd+ muwsPUyorgS3U0a4C+F0vwXyCCobvOrUg99Rcya9vJ9dpSnc/bjdQ/yO9LVkKlGQ5NQA8ZRrpLCL ngCwI4jbu5EHAScRYVqy/gSz4TBW6x8L1GpBekYIcA== =CEZL -----END PGP SIGNATURE----- --------------YI0KurEEFOlVNx7w638kODkU-- From xen-devel-bounces@lists.xenproject.org Fri Feb 03 13:15:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 13:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489181.757512 (Exim 4.92) (envelope-from ) id 1pNvul-0006I3-6d; Fri, 03 Feb 2023 13:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489181.757512; Fri, 03 Feb 2023 13:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvul-0006Hw-3N; Fri, 03 Feb 2023 13:15:39 +0000 Received: by outflank-mailman (input) for mailman id 489181; Fri, 03 Feb 2023 13:15:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNvuj-0006Hq-Tm for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 13:15:38 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8743e93-a3c4-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 14:15:36 +0100 (CET) Received: by mail-wm1-x336.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so3832425wms.1 for ; Fri, 03 Feb 2023 05:15:36 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id o21-20020a05600c379500b003dc4a47605fsm7557638wmr.8.2023.02.03.05.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 05:15:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8743e93-a3c4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=gc9xPJKMeBqKpVpfxZjVO7Smz0up4O7VA7w/zprJPmc=; b=HIZk5D9j6oJ3EoT/Ay+XlZxQPtC0iqkj7Ggf8tUtPKJa9q6wUUIQm1ZmwzQHG1dU66 AK/KMc+j1u62W+Soc5M977fK5s2hpQ3TnJWVv4v2Omy6Ae/U+9p0PUD4GSG9a+j8bUHK 9cOFMRXeLSXwM3E+Ew3ltCxRDjgduGgg9OF6e53EpikT3FNKSby3Pw+r7tNh5QQYmWxC hGyjFTH73Y5urFWZEBUA6lsgSLj3KBwUzQeDFoQyh1D2e+AAV0mM7BhdUOTfwrZFdKJJ iNqnBjwl0Ceicl8J065wVArcfvhjVEgMfQUAHYzovEcp5MPFx2msSU0S3zKijXU0u645 l4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gc9xPJKMeBqKpVpfxZjVO7Smz0up4O7VA7w/zprJPmc=; b=lpiNle3SCWGUHmzlZQyKs8plD9Gt8aC2az3RRdO2Ztnwkt+QWSXIo0Frj4Gtsp41X4 8R14bZj8RC2mi2CnPD9bRRaVHfAG+HHNmdmHerWbk9zLq7w+1sXHX9qOIUqYTYa8M+Dd U6CYSTHa6ku+ox3mM8NZyJYpGdvq1iwn5J5LkAZ5YYRa3or+lN6C0xoxJnp6jymrac+O gUOiqO1FIfmr25TO7eN8iPZgdwngLodL2X71aPNvsv8sBo5xdd5f89Xouo5MaQFpZI7k wAe43LeivxpJfD+McboY/tGf1RYwJrx+YP7Y72jGcMMd+le5q96wqgmqtu7jh0wtNHW7 g+tA== X-Gm-Message-State: AO0yUKV7LeLYlJRVyflJpX0lzhxUrDyBESxbkaFslHCZ52ghM0qI5Q45 C65MuXY80ta5htd6zkKUH2k= X-Google-Smtp-Source: AK7set/+v/np3vY1DXoLTVCmtIaW/0Q3gKXGeH5KNaqJhk1O+We+O8ebx60/bXjpwAvNGEsg3jbm/g== X-Received: by 2002:a05:600c:154e:b0:3df:eb5d:c583 with SMTP id f14-20020a05600c154e00b003dfeb5dc583mr1479971wmg.17.1675430135458; Fri, 03 Feb 2023 05:15:35 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Fri, 03 Feb 2023 15:15:33 +0200 In-Reply-To: References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGkgSnVsaWVuLAoKT24gV2VkLCAyMDIzLTAyLTAxIGF0IDIyOjExICswMDAwLCBKdWxpZW4gR3Jh bGwgd3JvdGU6Cj4gCj4gCj4gT24gMDEvMDIvMjAyMyAxNzo0MCwgT2xla3NpaSB3cm90ZToKPiA+ IEhpIEp1bGllbiwKPiAKPiBIaSBPbGVrc2lpLAo+IAo+ID4gT24gTW9uLCAyMDIzLTAxLTMwIGF0 IDIyOjI4ICswMDAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4gPiA+IEhpIE9sZWtzaWksCj4gPiA+ IAo+ID4gPiBPbiAzMC8wMS8yMDIzIDExOjM1LCBPbGVrc2lpIHdyb3RlOgo+ID4gPiA+IEhpIEp1 bGllbiwKPiA+ID4gPiBPbiBGcmksIDIwMjMtMDEtMjcgYXQgMTY6MDIgKzAwMDAsIEp1bGllbiBH cmFsbCB3cm90ZToKPiA+ID4gPiA+IEhpIE9sZWtzaWksCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE9u IDI3LzAxLzIwMjMgMTM6NTksIE9sZWtzaWkgS3Vyb2Noa28gd3JvdGU6Cj4gPiA+ID4gPiA+IFRo ZSBwYXRjaCBpbnRyb2R1Y2VzIG1hY3JvczogQlVHKCksIFdBUk4oKSwKPiA+ID4gPiA+ID4gcnVu X2luX2V4Y2VwdGlvbigpLAo+ID4gPiA+ID4gPiBhc3NlcnRfZmFpbGVkLgo+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gVGhlIGltcGxlbWVudGF0aW9uIHVzZXMgImVicmVhayIgaW5zdHJ1Y3Rpb24g aW4gY29tYmluYXRpb24KPiA+ID4gPiA+ID4gd2l0aAo+ID4gPiA+ID4gPiBkaWZmcmVudCBidWcg ZnJhbWUgdGFibGVzIChmb3IgZWFjaCB0eXBlKSB3aGljaCBjb250YWlucwo+ID4gPiA+ID4gPiB1 c2VmdWwKPiA+ID4gPiA+ID4gaW5mb3JtYXRpb24uCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBPbGVrc2lpIEt1cm9jaGtvCj4gPiA+ID4gPiA+IDxvbGVrc2lpLmt1cm9j aGtvQGdtYWlsLmNvbT4KPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+IENoYW5nZXM6Cj4gPiA+ ID4gPiA+IMKgwqDCoMKgIC0gUmVtb3ZlIF9fIGluIGRlZmluZSBuYW1pbmdzCj4gPiA+ID4gPiA+ IMKgwqDCoMKgIC0gVXBkYXRlIHJ1bl9pbl9leGNlcHRpb25faGFuZGxlcigpIHdpdGgKPiA+ID4g PiA+ID4gwqDCoMKgwqDCoMKgIHJlZ2lzdGVyIHZvaWQgKmZuXyBhc20oX19zdHJpbmdpZnkoQlVH X0ZOX1JFRykpID0KPiA+ID4gPiA+ID4gKGZuKTsKPiA+ID4gPiA+ID4gwqDCoMKgwqAgLSBSZW1v dmUgYnVnX2luc3RyX3QgdHlwZSBhbmQgY2hhbmdlIGl0J3MgdXNhZ2UgdG8KPiA+ID4gPiA+ID4g dWludDMyX3QKPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+IMKgwqDCoCB4ZW4vYXJjaC9yaXNj di9pbmNsdWRlL2FzbS9idWcuaCB8IDExOAo+ID4gPiA+ID4gPiArKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPiA+ID4gPiA+IMKgwqDCoCB4ZW4vYXJjaC9yaXNjdi90cmFwcy5jwqDCoMKg wqDCoMKgwqDCoMKgwqAgfCAxMjgKPiA+ID4gPiA+ID4gKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+ID4gPiA+ID4gPiDCoMKgwqAgeGVuL2FyY2gvcmlzY3YveGVuLmxkcy5TwqDCoMKg wqDCoMKgwqDCoCB8wqAgMTAgKysrCj4gPiA+ID4gPiA+IMKgwqDCoCAzIGZpbGVzIGNoYW5nZWQs IDI1NiBpbnNlcnRpb25zKCspCj4gPiA+ID4gPiA+IMKgwqDCoCBjcmVhdGUgbW9kZSAxMDA2NDQg eGVuL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20vYnVnLmgKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+ID4g PiBiL3hlbi9hcmNoL3Jpc2N2L2luY2x1ZGUvYXNtL2J1Zy5oCj4gPiA+ID4gPiA+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4gPiA+ID4gPiA+IGluZGV4IDAwMDAwMDAwMDAuLjRiMTVkOGViYTYKPiA+ ID4gPiA+ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiA+ID4gPiArKysgYi94ZW4vYXJjaC9yaXNjdi9p bmNsdWRlL2FzbS9idWcuaAo+ID4gPiA+ID4gPiBAQCAtMCwwICsxLDExOCBAQAo+ID4gPiA+ID4g PiArLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAgKi8KPiA+ID4gPiA+ID4gKy8q Cj4gPiA+ID4gPiA+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTIgUmVnZW50cyBvZiB0aGUgVW5pdmVy c2l0eSBvZgo+ID4gPiA+ID4gPiBDYWxpZm9ybmlhCj4gPiA+ID4gPiA+ICsgKiBDb3B5cmlnaHQg KEMpIDIwMjEtMjAyMyBWYXRlcwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJIGhhdmUgdG8gcXVlc3Rp b24gdGhlIHR3byBjb3B5cmlnaHRzIGhlcmUgZ2l2ZW4gdGhhdCB0aGUKPiA+ID4gPiA+IG1ham9y aXR5IG9mCj4gPiA+ID4gPiB0aGUgY29kZSBzZWVtcyB0byBiZSB0YWtlbiBmcm9tIHRoZSBhcm0g aW1wbGVtZW50YXRpb24gKHNlZQo+ID4gPiA+ID4gYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVnLmgp Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBXaXRoIHRoYXQgc2FpZCwgd2Ugc2hvdWxkIGNvbnNvbGlk YXRlIHRoZSBjb2RlIHJhdGhlciB0aGFuCj4gPiA+ID4gPiBkdXBsaWNhdGluZwo+ID4gPiA+ID4g aXQgb24gZXZlcnkgYXJjaGl0ZWN0dXJlLgo+ID4gPiA+ID4gCj4gPiA+ID4gQ29weXJpZ2h0cyBz aG91bGQgYmUgcmVtb3ZlZC4gVGhleSB3ZXJlIHRha2VuIGZyb20gdGhlIHByZXZpb3VzCj4gPiA+ ID4gaW1wbGVtZW50YXRpb24gb2YgYnVnLmggZm9yIFJJU0MtViBzbyBJIGp1c3QgZm9yZ290IHRv IHJlbW92ZQo+ID4gPiA+IHRoZW0uCj4gPiA+ID4gCj4gPiA+ID4gSXQgbG9va3MgbGlrZSB3ZSBz aG91bGQgaGF2ZSBjb21tb24gYnVnLmggZm9yIEFSTSBhbmQgUklTQ1YgYnV0Cj4gPiA+ID4gSQo+ ID4gPiA+IGFtCj4gPiA+ID4gbm90IHN1cmUgdGhhdCBJIGtub3cgaG93IHRvIGRvIHRoYXQgYmV0 dGVyLgo+ID4gPiA+IFByb2JhYmx5IHRoZSBjb2RlIHdhbnRzIHRvIGJlIG1vdmVkIHRvIHhlbi9p bmNsdWRlL2J1Zy5oIGFuZAo+ID4gPiA+IHVzaW5nCj4gPiA+ID4gaWZkZWYgQVJNICYmIFJJU0NW IC4uLgo+ID4gPiAKPiA+ID4gT3IgeW91IGNvdWxkIGludHJvZHVjZSBDT05GSUdfQlVHX0dFTkVS SUMgb3IgZWxzZSwgc28gaXQgaXMKPiA+ID4gZWFzaWx5Cj4gPiA+IHNlbGVjdGFibGUgYnkgb3Ro ZXIgYXJjaGl0ZWN0dXJlLgo+ID4gPiAKPiA+ID4gPiBCdXQgc3RpbGwgSSBhbSBub3Qgc3VyZSB0 aGF0IHRoaXMgaXMgdGhlIGJlc3Qgb25lIG9wdGlvbiBhcyBhdAo+ID4gPiA+IGxlYXN0IHdlCj4g PiA+ID4gaGF2ZSBkaWZmZXJlbnQgaW1wbGVtZW50YXRpb24gZm9yIHg4Nl82NC4KPiA+ID4gCj4g PiA+IE15IG1haW4gY29uY2VybiBpcyB0aGUgbWFpbnRhaW5hbmNlIGVmZm9ydC4gRm9yIGV2ZXJ5 IGJ1Zywgd2UKPiA+ID4gd291bGQKPiA+ID4gbmVlZAo+ID4gPiB0byBmaXggaXQgaW4gdHdvIHBs YWNlcy4gVGhlIHJpc2sgaXMgd2UgbWF5IGZvcmdldCB0byBmaXggb25lCj4gPiA+IGFyY2hpdGVj dHVyZS4KPiA+ID4gVGhpcyBpcyBub3QgYSB2ZXJ5IGlkZWFsIHNpdHVhdGlvbi4KPiA+ID4gCj4g PiA+IFNvIEkgdGhpbmsgc2hhcmluZyB0aGUgaGVhZGVyIGJldHdlZW4gUklTQy1WIGFuZCBBcm0g KG9yIHg4Niwgc2VlCj4gPiA+IGJlbG93KQo+ID4gPiBpcyBhdCBsZWFzdCBhIG11c3QuIFdlIGNh biBkbyB0aGUgM3JkIGFyY2hpdGVjdHVyZSBhdCBhIGxlaXN1cmUKPiA+ID4gcGFjZS4KPiA+ID4g Cj4gPiA+IE9uZSBvcHRpb24gd291bGQgYmUgdG8gaW50cm9kdWNlIGFzbS1nZW5lcmljIGxpa2Ug TGludXggKElJUkMKPiA+ID4gdGhpcwo+ID4gPiB3YXMgYQo+ID4gPiBzdWdnZXN0aW9uIGZyb20g QW5kcmV3KS4gVGhpcyB3b3VsZCBhbHNvIHRvIHNoYXJlIGNvZGUgYmV0d2Vlbgo+ID4gPiB0d28g b2YKPiA+ID4gdGhlIGFyY2hzLgo+ID4gPiAKPiA+ID4gQWxzbywgZnJvbSBhIGJyaWVmIGxvb2ss IHRoZSBkaWZmZXJlbmNlIGluIGltcGxlbWVudGF0aW9uIGlzCj4gPiA+IG1haW5seQo+ID4gPiBi ZWNhdXNlIG9uIEFybSB3ZSBjYW4ndCB1c2UgJWMgKHNvbWUgdmVyc2lvbiBvZiBHQ0MgZGlkbid0 Cj4gPiA+IHN1cHBvcnQKPiA+ID4gaXQpLgo+ID4gPiBJcyB0aGlzIGFsc28gdGhlIGNhc2Ugb24g UklTQy1WPyBJZiBub3QsIHlvdSBtYXkgd2FudCB0byBjb25zaWRlcgo+ID4gPiB0bwo+ID4gPiB1 c2UKPiA+ID4gdGhlIHg4NiB2ZXJzaW9uLgo+ID4gPiAKPiA+IEkgZGlkIHNldmVyYWwgZXhwZXJp bWVudHMgcmVsYXRlZCB0byAnJWMnIGluIGlubGluZSBhc3NlbWJseSBmb3IKPiA+IFJJU0MtVgo+ ID4gYW5kIGl0IHNlZW1zIHRoYXQgJyVjJyBkb2Vzbid0IHN1cHBvcnQgYWxsIGZvcm1zIG9mIHRo ZSB1c2Ugb2YKPiA+ICclYycuCj4gCj4gVGhhbmtzIGZvciBjaGVja2luZyEKPiAKPiA+IEkgd3Jv dGUgdGhlIGZvbGxvd2luZyBtYWNyb3MgYW5kIHRoZXkgaGF2ZSBiZWVuIGNvbXBpbGVkIHdpdGhv dXQKPiA+IGFueQo+ID4gZXJyb3JzOgo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIC4uLi4uCj4gPiAjZGVmaW5lIF9BU01fQlVHRlJBTUVfVEVYVChz ZWNvbmRfZnJhbWUpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg XAo+ID4gwqDCoCDCoCAiLkxidWclPTogZWJyZWFrXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXAo+ID4gwqDC oCDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVzLiVjW2JmX3R5cGVdLCBcImFcIiwgQHByb2di aXRzXG4iIFwKPiA+IMKgwqAgwqAgIi5wMmFsaWduIDJcbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXAo+ID4gwqDCoCDC oCAiLkxmcm0lPTpcbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgXAo+ID4gwqDCoCDCoCAiLmxvbmcgKC5MZnJtJT0p XG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgXAo+ID4gwqDCoCDCoCAiLmxvbmcgKDB4NTU1NTU1NTUpXG4iIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFwKPiA+IMKgwqAgwqAgIi5s b25nICguTGJ1ZyU9KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoFwKPiA+IMKgwqAgwqAgIi5sb25nICgweDU1NTU1NTU1KVxuIiDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcCj4g PiDCoMKgIMKgICIubG9uZyAlY1tiZl9saW5lX2hpXVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcCj4gPiDCoMKgIMKgICIubG9uZyAoMHg1NTU1 NTU1NSlcbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgXAo+ID4gwqDCoCDCoCAiLmxvbmcgJVtiZl9saW5lX2hpXVxuIiDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKPiA+IMKgwqAgwqAgIi5s b25nICgweDU1NTU1NTU1KVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCBcCj4gPiDCoMKgIMKgICIubG9uZyAlW2JmX2xpbmVfbG9dXG4iIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgXAo+ID4g wqDCoCDCoCAiLmxvbmcgKDB4NTU1NTU1NTUpXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFwKPiA+IMKgwqAgwqAgIi5sb25nICVbYmZfcHRy XVxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoFwKPiA+IMKgwqAgwqAgIi5sb25nICgweDU1NTU1NTU1KVxuIiDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcCj4gPiDCoMKgIMKgICIu bG9uZyAoLkxidWclPSAtIC5MZnJtJT0pICsgJWNbYmZfbGluZV9oaV1cbiIgwqAgwqAgwqAgwqAg wqAgwqAgXAo+ID4gwqDCoCDCoCAiLnBvcHNlY3Rpb25cbiIgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBcCj4gPiAKPiA+ICNk ZWZpbmUgX0FTTV9CVUdGUkFNRV9JTkZPKHR5cGUsIGxpbmUsIHB0ciwgbXNnKSDCoCDCoCDCoCDC oCDCoCDCoCDCoCBcCj4gPiDCoMKgIMKgIFtiZl90eXBlXSDCoCDCoCJpIiAodHlwZSksIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFwKPiA+IMKgwqAg wqAgW2JmX3B0cl0gwqAgwqAgImkiIChwdHIpLCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKPiA+IMKgwqAgwqAgW2JmX21zZ10gwqAgwqAgImki IChtc2cpLCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoFwKPiA+IMKgwqAgwqAgW2JmX2xpbmVfbG9dICJpIiAoKGxpbmUgJiAoKDEgPDwgQlVHX0xJ TkVfTE9fV0lEVEgpIC0gMSkpIMKgXAo+ID4gwqDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCA8PCBCVUdfRElTUF9XSURUSCksIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg XAo+ID4gwqDCoCDCoCBbYmZfbGluZV9oaV0gImkiICgoKGxpbmUpID4+IEJVR19MSU5FX0xPX1dJ RFRIKSA8PAo+ID4gQlVHX0RJU1BfV0lEVEgpCj4gPiAKPiA+ICNkZWZpbmUgQlVHX0ZSQU1FKHR5 cGUsIGxpbmUsIHB0ciwgc2Vjb25kX2ZyYW1lLCBtc2cpIGRvIHvCoMKgwqDCoCBcCj4gPiDCoMKg IMKgIF9fYXNtX18gX192b2xhdGlsZV9fICggX0FTTV9CVUdGUkFNRV9URVhUKHNlY29uZF9mcmFt ZSkgwqAgwqBcCj4gPiDCoMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgOjogX0FTTV9CVUdG UkFNRV9JTkZPKHR5cGUsIGxpbmUsIHB0ciwgbXNnKSApOwo+ID4gXAo+ID4gfSB3aGlsZSAoMCkK PiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Li4uLgo+ID4gCj4gPiAKPiA+IEJ1dCBpZiBhZGQgIi5sb25nICVjW2JmX3B0cl1cbiIgdGhlbiB0 aGUgZm9sbG93aW5nIGNvbXBpbGF0aW9uCj4gPiBlcnJvcgo+ID4gd2lsbCBvY2N1cjogWyBlcnJv cjogaW52YWxpZCAnYXNtJzogaW52YWxpZCB1c2Ugb2YgJyVjJy4gXQo+ID4gCj4gPiBJZiB5b3Ug bG9vayBhdCB0aGUgZGlzc2VtYmxlciBvZiBfYnVnX2ZyYW1lc18uLi4KPiA+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC4uLi4u Lgo+ID4gwqDCoCDCoCA4MDIwMTAxMDogwqAgMTAxMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoGFkZGkgwqAgwqBhMixzcCwzMsKgwqAgIwo+ID4gLkxmcm0lPQo+ID4gwqDCoCDCoCA4MDIw MTAxMjogwqAgODAyMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoC4yYnl0ZSDCoDB4ODAy MAo+ID4gwqDCoCDCoCA4MDIwMTAxNDogwqAgNTU1NSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoGxpIMKgIMKgIMKgYTAsLTExCj4gPiDCoMKgIMKgIDgwMjAxMDE2OiDCoCA1NTU1IMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGkgwqAgwqAgwqBhMCwtMTEKPiA+IMKgwqAgwqAgODAy MDEwMTg6IMKgIDMwMjIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAuMmJ5dGUgwqAweDMw MjLCoCAjIC5MYnVnJT0KPiA+IMKgwqAgwqAgODAyMDEwMWE6IMKgIDgwMjAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAuMmJ5dGUgwqAweDgwMjAKPiA+IMKgwqAgwqAgODAyMDEwMWM6IMKg IDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBsaSDCoCDCoCDCoGEwLC0xMQo+ID4g wqDCoCDCoCA4MDIwMTAxZTogwqAgNTU1NSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGxp IMKgIMKgIMKgYTAsLTExCj4gPiDCoMKgIMKgIDgwMjAxMDIwOiDCoCAwMDAwIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgdW5pbXDCoMKgwqDCoMKgwqDCoMKgwqDCoCMKPiA+ICVjW2JmX2xp bmVfaGldCj4gPiDCoMKgIMKgIDgwMjAxMDIyOiDCoCAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgdW5pbXAKPiA+IMKgwqAgwqAgODAyMDEwMjQ6IMKgIDU1NTUgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqBsaSDCoCDCoCDCoGEwLC0xMQo+ID4gwqDCoCDCoCA4MDIwMTAyNjog wqAgNTU1NSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGxpIMKgIMKgIMKgYTAsLTExCj4g PiDCoMKgIMKgIDgwMjAxMDI4OiDCoCAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg dW5pbXDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjCj4gPiAlW2JmX2xpbmVfaGldCj4gPiDCoMKgIMKg IDgwMjAxMDJhOiDCoCAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdW5pbXAKPiA+ IMKgwqAgwqAgODAyMDEwMmM6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBs aSDCoCDCoCDCoGEwLC0xMQo+ID4gwqDCoCDCoCA4MDIwMTAyZTogwqAgNTU1NSDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoGxpIMKgIMKgIMKgYTAsLTExCj4gPiDCoMKgIMKgIDgwMjAxMDMw OiDCoCAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdW5pbXDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIwo+ID4gJVtiZl9saW5lX2xvXQo+ID4gwqDCoCDCoCA4MDIwMTAzMjogwqAgMTYw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGFkZGkgwqAgwqBzMCxzcCw4MDAKPiA+IMKg wqAgwqAgODAyMDEwMzQ6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBsaSDC oCDCoCDCoGEwLC0xMQo+ID4gwqDCoCDCoCA4MDIwMTAzNjogwqAgNTU1NSDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoGxpIMKgIMKgIMKgYTAsLTExCj4gPiDCoMKgIMKgIDgwMjAxMDM4OiDC oCAxMGI4IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgYWRkaSDCoCDCoGE0LHNwLDEwNMKg wqAgIwo+ID4gJVtiZl9wdHJdCj4gPiDCoMKgIMKgIDgwMjAxMDNhOiDCoCA4MDIwIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgLjJieXRlIMKgMHg4MDIwCj4gPiDCoMKgIMKgIDgwMjAxMDNj OiDCoCA1NTU1IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGkgwqAgwqAgwqBhMCwtMTEK PiA+IMKgwqAgwqAgODAyMDEwM2U6IMKgIDU1NTUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBsaSDCoCDCoCDCoGEwLC0xMQo+ID4gwqDCoCDCoCA4MDIwMTA0MDogwqAgMjAxMiDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoC4yYnl0ZSDCoDB4MjAxMsKgwqAgIwo+ID4gKC5MYnVnJT0g LQo+ID4gLkxmcm0lPSkgKyAlY1tiZl9saW5lX2hpXQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLi4uLi4KPiA+IC4uLiBp dCBsb29rcyBsaWtlIHRoZSBlcnJvciB3aWxsIGJlIGdlbmVyYXRlZCBpZiB0aGUgbmFtZSBpbgo+ ID4gJWNbbmFtZV0KPiA+IGlzbid0IGVxdWFsIHRvIDAuCj4gPiAKPiA+IEFub3RoZXIgdGhpbmcg SSBub3RpY2VkIGlzIHRoYXQgJVtuYW1lXSBjYW4gYmUgdXNlZCBpbnN0ZWFkIG9mCj4gPiAlY1tu YW1lXQo+ID4gZm9yIFJJU0MtViAoIGkgZGlkIGEgcXVpY2sgY2hlY2sgYW5kIGl0IHdvcmtzKSBz byBpdCBpcyBzdGlsbAo+ID4gcG9zc2libGUKPiA+IHRvIGZvbGxvdyBJbnRlbCBpbXBsZW1lbnRh dGlvbiBidXQgcmVxdWlyZWQgYSByZWRlZmluaXRpb24gb2YKPiA+IF9BU01fQlVHRlJBTUVfVEVY VCB3aGVyZSAlY1suLi5dIHdvbid0IGJlIHVzZWQuIEFsbCB0aGUgcmVzdCB3aWxsCj4gPiBiZQo+ ID4gdGhlIHNhbWUgYXMgaW4geDg2IGltcGxlbWVudGF0aW9uOgo+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuLi4uLgo+ ID4gI2RlZmluZSBfQVNNX0JVR0ZSQU1FX1RFWFQoc2Vjb25kX2ZyYW1lKcKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgwqDCoMKgwqDCoMKgIFwKPiA+IMKgwqAgwqAgIi5MYnVnJT06IGVicmVha1xuIsKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIFwKPiA+IMKgwqAgwqAgIi5wdXNoc2VjdGlvbiAuYnVnX2ZyYW1lcy4lW2JmX3R5cGVd LCBcImFcIiwgQHByb2diaXRzXG4iIFwKPiA+IMKgwqAgwqAgIi5wMmFsaWduIDJcbiIgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBcCj4gPiDCoMKgIMKgICIuTGZybSU9OlxuIiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoFwKPiA+IMKgwqAgwqAgIi5s b25nICguTGJ1ZyU9IC0gLkxmcm0lPSkgKyAlW2JmX2xpbmVfaGldXG4iIMKgIMKgIMKgIMKgIMKg IMKgIFwKPiA+IMKgwqAgwqAgIi5sb25nICglW2JmX3B0cl0gLSAuTGZybSU9KSArICVbYmZfbGlu ZV9sb11cbiIgwqAgwqAgwqAgwqAgwqAgXAo+ID4gwqDCoCDCoCAiLmlmICIgI3NlY29uZF9mcmFt ZSAiXG4iIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFwK PiA+IMKgwqAgwqAgIi5sb25nIDAsICVbYmZfbXNnXSAtIC5MZnJtJT1cbiIgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBcCj4gPiDCoMKgIMKgICIuZW5kaWZcbiIgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqBcCj4gPiDCoMKgIMKgICIucG9wc2VjdGlvblxuIiDCoCDCoCDCoCDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAuLi4uLgo+ID4gCj4gPiBPbmUgdGhpbmcgSSB3b3VsZCBsaWtl IHRvIGFzayB5b3UgaXMgd2h5IGl0J3MgYmV0dGVyIHRvIGZvbGxvdy91c2UKPiA+IHg4Ngo+ID4g aW1wbGVtZW50YXRpb24gaW5zdGVhZCBvZiBBUk0/Cj4gCj4gSU1ITywgdGhlIHg4NiB2ZXJzaW9u IGlzIGNsZWFuZXIuIEJ1dC4uLgo+IAo+ID4gSXQgc2VlbXMgdGhhdCAiJWNbLi4uXSIgaGFzIHRo ZSBiZXN0IHN1cHBvcnQgb25seSBmb3IgSW50ZWwgR0NDIGFuZAo+ID4gdGhlcmVieSBBUk0gaW1w bGVtZW50YXRpb24gbG9va3MgbW9yZSB1bml2ZXJzYWwsIGRvZXNuJ3QgaXQ/Cj4gCj4gLi4uIHlv dSBhcmUgcmlnaHQsIHRoZSBBcm0gdmVyc2lvbiBpcyBtb3JlIHBvcnRhYmxlLiBBbHRob3VnaCwg SSBkbyAKPiB3b25kZXIgaG93IEdDQyBtYW5hZ2VkIHRvIGhhdmUgYSBkaWZmZXJlbnQgYmVoYXZp b3IgYmV0d2Vlbgo+IGFyY2hpdGVjdHVyZSAKPiBhcyBJIHdvdWxkIGhhdmUgZXhwZWN0ZWQgJWMg dG8gYmUgYSBnZW5lcmljIGltcGxlbWVudGF0aW9uLgo+IAo+IEFueXdheSwgaWYgeW91IGFyZSBi YXNpbmcgb24gdGhlIEFybSBvbmUsIHRoZW4geW91IHNob3VsZCBiZSBhYmxlIHRvCj4gwqAgMSkg bW92ZSBhcmNoL2FybS9pbmNsdWRlL2FzbS9idWcuaCBpbiBhc20tZ2VuZXJpYy9idWcuaCAob3IK PiBzaW1pbGFyKQo+IMKgIDIpIFJlbmFtZSB0aGUgZ3VhcmQgYW5kIHJlbW92ZSBhcm0gc3BlY2lm aWMgY29kZS4oSSBhbSBub3Qgc3VyZQo+IGZyb20gCj4gd2hlcmUgdG8gaW5jbHVkZSBhcm17MzIs IDY0fS9idWcuaCkKPiDCoCAzKSBEZWZpbmUgQlVHX0lOU1RSIHRvIGVicmVhayBvbiBSSVNDLVYu Cj4gwqAgNCkgRmluZCBhIHBsYWNlIGZvciBhbGwgdGhlIFJJU0MtViBzcGVjaWZpYyBoZWFkZXIK PiDCoCA1KSBNb3ZlIGRvX2J1Z19mcmFtZSgpIGluIGNvbW1vbi9idWcuYwo+IAo+IEkgYW0gaGFw cHkgdG8gaGVscCB0ZXN0aW5nIHRoZSBBcm0gdmVyc2lvbiBhbmQvb3IgaGVscCBtb3ZpbmcgdGhl Cj4gY29kZSAKPiB0byBjb21tb24uCj4gClRoYW5rcyBhIGxvdCBmb3IgdGhlIGhlbHAgb2ZmZXJl ZC4KCkkndmUgc3RhcnRlZCB0byByZXdvcmsgYnVnLmggc3R1ZmYgYnV0IGZhY2VkIGFuIGlzc3Vl LgoKSSBhbSB0cnlpbmcgdG8gaW50cm9kdWNlIEdFTkVSSUNfQlVHX0ZSQU1FIGNvbmZpZyAoIG9u bHkgZm9yIEFSTSBub3cgYXMKc29tZSBzdHVmZiBpc24ndCBhdmFpbGFibGUgbm93IGZvciBSSVND LVYgc3VjaCBhcyBmaW5kX3RleHRfcmVnaW9uKCksCnByaW50aygpIGFuZCBzbyBvbi4uLiBUaGVy ZWJ5IEkgd2lsbCBzd2l0Y2ggdG8gZG9fYnVnX2ZyYW1lKCkgdG8KZ2VuZXJpYyBvbmUgYSBsaXR0 bGUgYml0IGxhdGVyIGZvciBSSVNDViApIHNvIEkgYWRkZWQgdGhlIGZvbGxvd2luZyB0bwpLY29u ZmlnOgoKICAgIGNvbmZpZyBHRU5FUklDX0RPX0JVR19GUkFNRQogICAgCWJvb2wgIkdlbmVyaWMg aW1wbGVtZW50YXRpb24gb2YgZG9fYnVnX2ZyYW1lKCkiCglkZWZhdWx0IHkgaWYgQVJNCglkZWZh dWx0IG4KCWhlbHAKCSAgLi4uCgpCdXQgd2hlbiBJIHB1c2hlZCB0aGUgY29tbWl0IHRvIEdpdExh YiBhbGwgQVJNIHJhbmRjb25maWcgam9icyBmYWlsZWQKYmVjYXVzZSB0aGV5IGRlY2lkZWQgbm90 IHRvIHNldCBHRU5FUklDX0JVR19GUkFNRT15LgpDb3VsZCB5b3UgcGxlYXNlIGdpdmUgbWUgYSBz dWdnZXN0aW9uIGhvdyBJIGNhbiB3b3JrIGFyb3VuZCB0aGlzCnByb2JsZW0/ICggSSB0aG91Z2h0 IHRoYXQgaXQgd291bGQgYmUgZW5vdWdoIHRvIHVzZSBkZWZhdWx0IHkgYnV0CnJhbmRjb25maWcg Y2FuIG92ZXJyaWRlIGl0ICkuCk9yIGlzIGl0IG5lZWRlZCB0byBwcm92aWRlIGFuIGVtcHR5IGlt cGxlbWVudGF0aW9uIGZvciBkb19idWdfZnJhbWUoKQpHRU5FUklDX0JVR19GUkFNRT1uPwpBbHNv IEkgdGhvdWdodCBhYm91dCB3ZWFrIGZ1bmN0aW9uIGFzIGFuIG9wdGlvbi4uLgoKSGVyZSBpcyBw aXBlbGluZSBmb3IgZ2VuZXJpYyBidWcgZnJhbWUgZmVhdHVyZSBhbmQgdGhlIHBhdGNoICggb2YK Y291cnNlIG5vdCByZWFkeSBmb3IgdXBzdHJlYW0gYnV0IGF0IGxlYXN0IGl0IHNob3dzIGFuIGlk ZWEgKToKICoKaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9vbGt1ci94ZW4v LS9waXBlbGluZXMvNzY2NTgxMTc0CiAqCmh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9w ZW9wbGUvb2xrdXIveGVuLy0vY29tbWl0LzZmYzY0ODEyMDI4NTJlMGFhMmMyY2IzODc3ZjJkNzFh YzAyMTM1MTEKIApQLlMuOiBQcm9iYWJseSB5b3UgaGF2ZSBzb21lIGNvbW1lbnRzICggc29tZXRo aW5nIHRoYXQgaXMgdW5hY2NlcHRhYmxlCmV2ZW4gbm93ICkgYWJvdXQgdGhlIHBhdGNoLiBJIHdp bGwgaGFwcHkgdG8gaGVhciB0aGVtIHRvby4KClRoYW5rcyBpbiBhZHZhbmNlLgoKPiBDaGVlcnMs Cj4gCn4gT2xla3NpaQo= From xen-devel-bounces@lists.xenproject.org Fri Feb 03 13:23:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 13:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489188.757523 (Exim 4.92) (envelope-from ) id 1pNw1z-0007nM-2k; Fri, 03 Feb 2023 13:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489188.757523; Fri, 03 Feb 2023 13:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNw1y-0007nF-W0; Fri, 03 Feb 2023 13:23:06 +0000 Received: by outflank-mailman (input) for mailman id 489188; Fri, 03 Feb 2023 13:23:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNw1x-0007n9-BM for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 13:23:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNw1w-0005eR-EM; Fri, 03 Feb 2023 13:23:04 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.5.182]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pNw1w-0004Yc-7P; Fri, 03 Feb 2023 13:23:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ksjkzHDtYZ+KrzuTWzg7JKOV1chDVcwz7fstNVZBzBM=; b=Cc9bC8MkdGup4XhXqtN7U2efSo 2EFzt1PKqfQTBMhMS0eTtzAVdOP+6/77Dm8fpHJapU7Xr3WARzOHGAtc+GhVqOKeQkvcDN2N7JdIw 33vnOlp1DWBA072zNWQnjJ4aIZIkJjm990XFQk9DcvZkv66Ugkx4PAm7l6le+rzWS0lA=; Message-ID: Date: Fri, 3 Feb 2023 13:23:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/02/2023 13:15, Oleksii wrote: > Hi Julien, Hi Oleksii, > On Wed, 2023-02-01 at 22:11 +0000, Julien Grall wrote: > I am trying to introduce GENERIC_BUG_FRAME config ( only for ARM now as > some stuff isn't available now for RISC-V such as find_text_region(), > printk() and so on... Thereby I will switch to do_bug_frame() to > generic one a little bit later for RISCV ) so I added the following to > Kconfig: > > config GENERIC_DO_BUG_FRAME > bool "Generic implementation of do_bug_frame()" > default y if ARM > default n > help > ... > > But when I pushed the commit to GitLab all ARM randconfig jobs failed > because they decided not to set GENERIC_BUG_FRAME=y. > Could you please give me a suggestion how I can work around this > problem? ( I thought that it would be enough to use default y but > randconfig can override it ). You don't want to allow the user to deselect GENERIC_DO_BUG_FRAME. So you want config ARM to select it: (arch/arm/Kconfig) config ARM ... select GENERIC_DO_BUG_FRAME (common/Kconfig) config GENERIC_DO_BUG_FRAME bool > Or is it needed to provide an empty implementation for do_bug_frame() > GENERIC_BUG_FRAME=n? > Also I thought about weak function as an option... > > Here is pipeline for generic bug frame feature and the patch ( of > course not ready for upstream but at least it shows an idea ): > * > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/766581174 > * > https://gitlab.com/xen-project/people/olkur/xen/-/commit/6fc6481202852e0aa2c2cb3877f2d71ac0213511 > > P.S.: Probably you have some comments ( something that is unacceptable > even now ) about the patch. I will happy to hear them too. I will try to have a look next week. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 03 13:58:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 13:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489198.757534 (Exim 4.92) (envelope-from ) id 1pNwZt-0003Jh-QD; Fri, 03 Feb 2023 13:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489198.757534; Fri, 03 Feb 2023 13:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwZt-0003Ja-NI; Fri, 03 Feb 2023 13:58:09 +0000 Received: by outflank-mailman (input) for mailman id 489198; Fri, 03 Feb 2023 13:58:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwZs-0003JU-Pl for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 13:58:09 +0000 Received: from vsp01-out.oderland.com (vsp01-out.oderland.com [2a02:28f0::25:1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6145c9d-a3ca-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 14:58:04 +0100 (CET) Received: from office.oderland.com (office.oderland.com [91.201.60.5]) by vsp-out.oderland.com (Halon) with ESMTPSA id c5c667fc-a3ca-11ed-988b-13c61387685f; Fri, 03 Feb 2023 14:58:01 +0100 (CET) Received: from 160.193-180-18.r.oderland.com ([193.180.18.160]:42860 helo=[10.137.0.14]) by office.oderland.com with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1pNwZq-0040K8-9P; Fri, 03 Feb 2023 14:58:01 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6145c9d-a3ca-11ed-93b5-47a8fe42b414 X-Scanned-Cookie: 0162612eaad5b0a05cb4a8d9b4dce14a4c5e9ffb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=oderland.se ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0vnqyLQjLM8vIxF5gJPRlxfMok/MJsZ2QdrgPNLap6A=; b=aAPvWYDchoFfYjna1mfsZ6jyzK cI6Dyni4w4oCB0PaIj9A2cpbKDveCoTAg5bDP0iU3yusuhhT2Oi0luM1iVAb30AeJmPC+v4ja5uJ3 1OBQg6L4q9G6cMsBVX17Ng1wAOvLVRJRz2Ffb9DA5Ez/Jt8uL6+SvmbJ6HXVlm5vFNYcdeNa4kqZu X7CuhssKOrDKqUH0v4NVGr42ENlJ7wwgZ1upz3ydYa3/8wld/2Z9a03IX6CTPmsgjuiWE8A8DCq8h hWPD5uEUWEeolZ5xzaaR+/eQanWZ+jlMV9quhwKtAK6SROlPEnye7Try6AyyqOboYARa9UJFkUX4g l34Ro1XA==; Message-ID: <06e6cefb-c773-d959-d569-84dd63e240e1@oderland.se> Date: Fri, 3 Feb 2023 14:58:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Subject: Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0 To: Jan Beulich Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-acpi@vger.kernel.org, Roger Pau Monne , linux-kernel@vger.kernel.org References: <20221121102113.41893-1-roger.pau@citrix.com> <20221121102113.41893-2-roger.pau@citrix.com> <952fdc14-a8e5-a59a-9c7d-af1adf361d77@oderland.se> <513e2851-9098-b510-588e-1e68d44d23fc@suse.com> Content-Language: en-US From: Josef Johansson In-Reply-To: <513e2851-9098-b510-588e-1e68d44d23fc@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit x-oderland-domain-valid: yes On 2/3/23 08:05, Jan Beulich wrote: > On 30.01.2023 10:21, Josef Johansson wrote: >> On 11/21/22 11:21, Roger Pau Monne wrote: >>> --- a/arch/x86/xen/enlighten.c >>> +++ b/arch/x86/xen/enlighten.c >>> @@ -346,3 +346,30 @@ void xen_arch_unregister_cpu(int num) >>> } >>> EXPORT_SYMBOL(xen_arch_unregister_cpu); >>> #endif >>> + >>> +#ifdef CONFIG_XEN_DOM0 >>> +bool __init xen_processor_present(uint32_t acpi_id) >>> +{ >>> + unsigned int i, maxid; >>> + struct xen_platform_op op = { >>> + .cmd = XENPF_get_cpuinfo, >>> + .interface_version = XENPF_INTERFACE_VERSION, >>> + }; >>> + int ret = HYPERVISOR_platform_op(&op); >>> + >>> + if (ret) >>> + return false; >>> + >>> + maxid = op.u.pcpu_info.max_present; >>> + for (i = 0; i <= maxid; i++) { >>> + op.u.pcpu_info.xen_cpuid = i; >>> + ret = HYPERVISOR_platform_op(&op); >>> + if (ret) >>> + continue; >>> + if (op.u.pcpu_info.acpi_id == acpi_id) >>> + return op.u.pcpu_info.flags & XEN_PCPU_FLAGS_ONLINE; >>> + } >>> + >>> + return false; >>> +} >> My compiler (Default GCC on Fedora 32, compiling for Qubes) complain >> loudly that the below was missing. >> >> +} >> +EXPORT_SYMBOL(xen_processor_present); >> >> `ERROR: MODPOST xen_processor_present >> [drivers/xen/xen-acpi-processor.ko] undefined!` >> >> Same thing with xen_sanitize_pdc in the next patch. >> >> +} >> +EXPORT_SYMBOL(xen_sanitize_pdc); >> >> Everything compiled fine after those changes. > Except that you may not export __init symbols. The section mismatch checker > should actually complain about that. > > Jan That makes sense. Patch 3 does change it from an __init though. diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 394dd6675113..a7b41103d3e5 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -348,7 +348,7 @@ EXPORT_SYMBOL(xen_arch_unregister_cpu);  #endif  #ifdef CONFIG_XEN_DOM0 -bool __init xen_processor_present(uint32_t acpi_id) +bool xen_processor_present(uint32_t acpi_id)  { So the change should be in Patch 3 I guess. Regards - Josef From xen-devel-bounces@lists.xenproject.org Fri Feb 03 14:07:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 14:07:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489213.757545 (Exim 4.92) (envelope-from ) id 1pNwiy-00052M-Lj; Fri, 03 Feb 2023 14:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489213.757545; Fri, 03 Feb 2023 14:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwiy-00052F-J4; Fri, 03 Feb 2023 14:07:32 +0000 Received: by outflank-mailman (input) for mailman id 489213; Fri, 03 Feb 2023 14:07:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwix-000525-QX; Fri, 03 Feb 2023 14:07:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwix-0006hv-NU; Fri, 03 Feb 2023 14:07:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwix-0004bI-65; Fri, 03 Feb 2023 14:07:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNwix-0001er-5V; Fri, 03 Feb 2023 14:07:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C+VDcNHPHApfZskE1+QZs+MVpsMsFE2XxI3bb8pwk6o=; b=T4D2LGLXS2kNjrvW03RyprdxEU IGxpOQ+mrPxWL0GxAfYq/Lw7z6a7Byv/THQvmM32Pwb7MwnvJlK7dStQuXoBEgjVUmhV6rfT/hZvz rimEboHf6kSi5BQMI4h+BsgiU9DxerZKZnXfP08IYer2LH/agCZ69dTZjCxTqozc7EfU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176346: all pass - PUSHED X-Osstest-Versions-This: ovmf=11f0014c0e3046e3762eac420b760091d0cdc063 X-Osstest-Versions-That: ovmf=ae6e470252d9312dce20d0b21e7f622c4ca9ad0a From: osstest service owner Date: Fri, 03 Feb 2023 14:07:31 +0000 flight 176346 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176346/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 11f0014c0e3046e3762eac420b760091d0cdc063 baseline version: ovmf ae6e470252d9312dce20d0b21e7f622c4ca9ad0a Last test of basis 176328 2023-02-02 06:12:22 Z 1 days Testing same since 176346 2023-02-03 08:11:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ae6e470252..11f0014c0e 11f0014c0e3046e3762eac420b760091d0cdc063 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 03 14:22:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 14:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489221.757556 (Exim 4.92) (envelope-from ) id 1pNwxU-0007XY-VQ; Fri, 03 Feb 2023 14:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489221.757556; Fri, 03 Feb 2023 14:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwxU-0007XR-SQ; Fri, 03 Feb 2023 14:22:32 +0000 Received: by outflank-mailman (input) for mailman id 489221; Fri, 03 Feb 2023 14:22:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwxU-0007XH-7R; Fri, 03 Feb 2023 14:22:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwxU-00076k-3q; Fri, 03 Feb 2023 14:22:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNwxT-0004z4-Ll; Fri, 03 Feb 2023 14:22:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNwxT-0001tx-LK; Fri, 03 Feb 2023 14:22:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3s0ZysFo/NnIo0nHv4ZvAcB1FOpciqcRNseG4WoPljM=; b=V5bAf23ou0HmFeNz1KcCXadzWv ebFWax4GDvw7uGTg61q7nDEx+HeZM/xwAW5dwfyW0vuCMrqUJKNaV9Gq88pacbezXoyMw5YIkY0Cd 2H63UflueCa23EJq0af2WKMMg/tXimLT4rv7Gg13cpK3FeY5Un5vyFtJZlVmL62gOzg8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176340: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=78e93e6e57c218eead498a664785f414bcb12460 X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Fri, 03 Feb 2023 14:22:31 +0000 flight 176340 xen-unstable real [real] flight 176347 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176340/ http://logs.test-lab.xenproject.org/osstest/logs/176347/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 175994 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail pass in 176347-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 176347-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 176347 never pass test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 78e93e6e57c218eead498a664785f414bcb12460 baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 14 days Failing since 176003 2023-01-20 17:40:27 Z 13 days 26 attempts Testing same since 176340 2023-02-02 21:07:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1267 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Feb 03 15:56:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 15:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489236.757573 (Exim 4.92) (envelope-from ) id 1pNyPh-0001CA-49; Fri, 03 Feb 2023 15:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489236.757573; Fri, 03 Feb 2023 15:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyPg-0001C3-Vu; Fri, 03 Feb 2023 15:55:44 +0000 Received: by outflank-mailman (input) for mailman id 489236; Fri, 03 Feb 2023 15:55:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyPe-0001Bw-RJ for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 15:55:43 +0000 Received: from mail179-30.suw41.mandrillapp.com (mail179-30.suw41.mandrillapp.com [198.2.179.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 339c94c4-a3db-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 16:55:40 +0100 (CET) Received: from pmta12.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail179-30.suw41.mandrillapp.com (Mailchimp) with ESMTP id 4P7gGx1NfgzP0Jn5r for ; Fri, 3 Feb 2023 15:55:37 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id e84c7a86e51d49dc9320c6e1922d0e98; Fri, 03 Feb 2023 15:55:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 339c94c4-a3db-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1675439737; x=1675497337; i=marc.ungeschikts@vates.fr; bh=ka+O9q3nUXmmAOu8SIVzGFtpQmRrIh1K8fg6c+c/wuQ=; h=From:Subject:To:In-Reply-To:References:Message-Id:Feedback-ID: Date:MIME-Version:Content-Type:CC:Date:Subject:From; b=OjbwNU2g+rAS86U5UVNa8iG+5hNjGb9MNaIaClzaYt5RQS6w0G/XfeWmtOFbnYW89 gvyRvLttnmUbm16upOE0t6sJeei81Q5wtzf/s4uAoPxUssaaBG66i5b6DJEgdiLlLW b6OeVZHeoFWuco3uEpbfOfy7x+nuM894MQyHFla0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1675439736; h=From : Subject : To : In-Reply-To : References : Message-Id : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=ka+O9q3nUXmmAOu8SIVzGFtpQmRrIh1K8fg6c+c/wuQ=; b=hPMCADya+XB7kSuA0gJ8BaN6l+fqU2dEjBwTJ2JLaBnFJTQXD0xJeH6cYJkCmGNL4l0Lgz bTfAH98eho9GUAP9RLhmEHrNXXv7h0cVczGZCE+/w1nZbeog+oV2hErlpQha0xSs/kgqlc4S lE+MY8WFqh1V9e1VG8fKzM4gTHveQ= From: Marc Ungeschikts Subject: =?utf-8?Q?RE=C2=A0:=20Weekly=20meeting=20-=20Xen=20Gitlab=20Issues=20Review?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 48e5b86a-aec2-49cd-9e7e-fb489512856c X-Bm-Transport-Timestamp: 1675439735748 To: xen-devel@lists.xenproject.org In-Reply-To: References: Message-Id: <20230203155535.AB26D12B68D@mail2.vates.fr> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.e84c7a86e51d49dc9320c6e1922d0e98 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230203:md Date: Fri, 03 Feb 2023 15:55:36 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-0P1nAWDENAOY8SsEmzRHsw" --_av-0P1nAWDENAOY8SsEmzRHsw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =F0=9F=93=9D Report minutes of today's Xen Gitlab Issues review me= eting: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/ For next week: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*lundi 30 janvier 2023 10:56 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*Weekly meeting - Xen Gitlab Issues Review Hi everydody, last Friday, during the Backlog Review meeting, we decided to schedule a weekly meeting *every Friday-14:00(UTC)* to talk about Xen Gitlab issues (discussion, grooming, triage,...) *Jitsi Room*: https://meet.jit.si/XenIssuesReview You are all welcome, specially developers and maintainers. * Marc Ungeschikts | Vates Project Manager* *Mobile: 0613302401* *XCP-ng & Xen Orchestra - *Vates solutions *w:* vates.fr | xcp-ng.org | xen-orchestra.com --_av-0P1nAWDENAOY8SsEmzRHsw Content-Type: multipart/related; boundary="_av-1IhsN3LhtPcJEtrSpj23Jw" --_av-1IhsN3LhtPcJEtrSpj23Jw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

=F0=9F=93= =9D Report minutes of today's Xen Gitlab Issues review me= eting: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/

 

For next week: https:/= /cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/

 

 

Marc Ungeschikts (Vates)

 

De : <= /b>Marc Ungeschikts
= Envoy=C3=A9 le :lundi 30 janvier 2023 10:56
=C3=80 : xen-devel@lists.xenproj= ect.org
Objet :Weekly meeting - Xen Gitlab Issues Review=

 

Hi everydody, = last Friday, during the Backlog Review meeting, we decided to schedule a we= ekly meeting every Friday-14:00(UTC) to talk about <= a href=3D"https://gitlab.com/groups/xen-project/-/issues" target=3D"_blank"= style=3D"box-sizing:border-box;background-color:rgba(63, 67, 80, 0.04);col= or:rgb(56, 111, 229);cursor:pointer;word-break:break-word;font-family:"= ;Open Sans", sans-serif;font-size:13.5px;white-space:pre-wrap">Xen Gitlab = issues(discussion, groomi= ng, triage,...)
 Jitsi Room:= https://meet.= jit.si/XenIssuesReview


You are all we= lcome, specially developers and maintainers.
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solution= s
w: vates.fr | xcp-ng.org | xen-or= chestra.com
3D""
3D"" --_av-1IhsN3LhtPcJEtrSpj23Jw Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline iVBORw0KGgoAAAANSUhEUgAAAK4AAACfCAYAAABgKuLmAAAm4XpUWHRSYXcg cHJvZmlsZSB0eXBlIGV4aWYAAHjatZxpkmSpcoX/swotgXlYDuBgph1o+foO kVmva2jZa8lU1VWZFRlxL+DuZ3C47c5//ed1/8GvEYZ3ubReR62eX3nkESff dP/5Nd/fwef39+el8/Wz8PPrbtyvH0ReSnxNn3/2+vX+79fDjwt8vky+K3+5 UN9fP1g//2Dkr+v3Xy70daOkEUW+se8RfV0oxc8PwtcF5mdavo7e/jqF9TW1 r89/loE/Tn/dHYdeK+vzs1//nRurZ4X7pBhPCsnzd0pfA0j6E12afFP5O6YU 30vvlc7fIcWvkbAgf1qnH7+4rbsaav7jm36Kyo/vfonWGV9r9Gu0cvx6S/pl keuPr3983YXy56i8pf/LnXP/+i7+/ProMX5G9Mvqv8W/1u+bM7OYubLU9WtS 31N83/E+wpF16+4YWvWNP4VLtPd78LuT1ZtUML/94vcOI0TCdUMOFma44byv O2yGmONxsfFNjDum92JPLY64iVtIWb/DjS2NZMQxpv3CnlP8MZbwbjv8du9u nTtb4K0xcLHwkuAf/nb/9AP3qhRC0FoS+vCJb4xabIahyOlv3kZEwv1a1PIW +Pv3r78U10QEi1ZZJTJY2PW5xCrhX0iQXqATbyx8/dRgaPZ1AZaIWxcGExIR IGohlVCDbzG2EFjIToAmQ48px0UEQinRGGTMKVVi06NuzUdaeG+NJfKy43XA jEgUKq4Rm5Emwcq5kD8td3JollRyKaWWVnoZZdZUcy211lYFirOlll0rrbbW ehtt9tRzL7321nsffY44EqBZRh1t9DHGnNxzcuXJpydvmHPFlVZexa262upr rLlJn5132XW33ffY06IlAz+sWrNuw+YJh1Q6+ZRTTzv9jDMvqXaTu/mWW2+7 /Y47f0TtK6y//f4HUQtfUYsvUnpj+xE1Xm3t+xJBcFIUMwIWXQ5EvCkEJHRU zHwPOUdFTjHzA8RLJTLIophZUMSIYD4hlhu+Y+fiJ6KK3P8pbq7ln+IW/7eR cwrdP4zc73H7U9RMNLRfxD5VqEX1ierj56fP2KfI7revTjNvjRUI8HbqXrdv xdvlv139mjVY7qcXSmjvnE4bo8XF2Po+56wzNhTXorNcILFSOrVFGe7A9LnF NK3KmL3OuveqQXFodY9uQGIfkzocZ0Cv8/S0/XDHjzVuYJly3SeNUl+5pphZ wnA2ydC5/Gms3vWbhUrjhH59OqOcMI3qtTTNBUi/7wWM2upzkzUk28nDkwib peRNfVeuOYkcWVEWoyHtrJzdejkdFUJybDcy60sGdOZf9xzr7tVPLgZWA7un pRuJQj8ELu92/SHFjDBxrTEZXWplj7tcjiRQ4D5UgmkAhMlaKocx7HLjJAQl 9VJOmYvI1pLi7gW+inX1OEsjy85pbl7+BXiFxSL5wj8LObqCTULGAjEO1rnn wFVOKo0ViBEtRMFsS6GXmk+2c1ybjIVsz7WWXfhA8jt3VrhNhlQHFGQzHX4e ZjUS/aSpW55k96xiSA/L0ABTG6msQIjyQvgR07amtR6O1VNaM4TSYvixPq0R Q0zGHM3yu8WsA54kRg4as3LTaiSL7RbO1PULaxupwhzbYriRYgtjo35KhXsz eTLrqYUs3Zv5Uj9uz7vJCkpxmU+FYDZbKIZUQN6Qx76gQSdpxs0I0VlJRj9O 7kq+ESja3fKmRM4l+FVE0ts+FR0WSvOdwJ05zt61BMqn8P6sb3KROvzDV/d3 P+ArI2aAo+Vl5PoF2pjz7GUZf3ZpixEAFndYSd5ZbHu3g7q4hXRf5cRrYeUM qhAAgn8LRDbvzMHbmoHwGtULYwdAYuUWNffgiHnbCcCpfiRIgpvCkk0IC5MC djESpKS45mPpSOM23fU0tA24Vcoq2cCj0ljOvraFsVoKBygJaezT7LbGZftN dsqezHCWvfxRvjLwPQjcpNiJ0J7AyDk1jNJCzGVITzWSgMQPdw6GulgkQwyR PLycbZGTzOSmaicBIevmmMO8w92FvlpzFWp5VIubWS9KCtSKB4IrI5L2fs9F nXrrZyYwoTAR4MoD3iFQ9WE4BCJzWaQh6bqbNaqMer0l2WAGm8iV2QLVEU05 xLhPBy9yIFFLPZpF4JaOpSX5gfmRbh8xqzJnaCWBCZV/8zFKB73YMCswBIgc y5lb8Y+xGtzVUlzH7eZBm7JT2tQxeQBjWa2HdbwR7iqwwRi5Ax/oGWNGK+qe 4ChoR2neDKzG5YI/lfWf5Sq+eofFAEN11Bs1ukG6OOPRrM5B5RbgASIjWTpk OS4/7cPyJPyeRG7xxA0MrlJmznPtjQFsZfrT4csNvEYSgjFwXVYXSjA+yNio PXHFudRaXBQjl5IZYI2qRqLAHq7YrYLgc3cIm5QmkKx0hUJUfavDYmQVP9zm JnFBSPcKas+sFIaCFuIkGFkcdqvkk5HNKz9p3jdTj3B6k468jPV4gAOoLQR6 Znj9dooOfjjiNIqBP/bFpQav+Pm+93/z1f32A+gH4Ukq1JOgssPStw3Jwfyn whyQiGpvyfDNS6Ch2WTRLdsKR4+3mp04YMjSSbs4Ka8hCaw4g4Z8CJHEihCJ Qt1INC0iFkMfTMhRY/MuJnzJbjyHl3Bi8XoX1gP6jZrwECpaqwrtKA1WhUEb vL+mJAjyaTsqdiC1oqgFLO+oPZUQtE3ZiZt46xqinw2tJt6VVRKFNIROU7G2 8cD+uLoo2YFCGIb4AfP6nO1Ax8BvTJXc6wYHpKbvblGt7ZA6tcB4pKuQGMze 3DWMV52icGOw7aiwmrLukCtzCh9JP8ogGQxb6pOFYPm9naWRAVeSXqf0K8U3 iCsY6nKfVW/KAhNgp4IRtc7LgA/xKtQF9YegPNVSrHyu8SKpXtwDcEgEyqIe 9uNXBIJW1b9kgs9IZ2iHeW3kQkbropKAJ+IY4KZMAiC0CBdsM1rjSowX7fnU BzIuAohIyQbYIQ1hi0l2AyJA4eKGAAGhYLnCEaQ4FEJBb4vNIWgYRPKKu8om wWngQLKnFA6ITpUjdsXB6Yqtqb0pcRML3M8FVwuQBrIIgASuO/V19R+RQoyg 0akfOB+/la7ZZml5F682FBXw5jsy10Hz2QgSq9tJbCKU14K20MOpUR2dSuk7 XH1EQ5/Q/RVmiwFQ28dmb5J+YNlAId7Hrghw6NI/lkZ6/DtfixlubSy3rQAE udThFyrPp3Q8UoSlHcd4A3oe1YyER6rHhQIuZGEn6nBDUQZy45VGdSREAR6J BapWqnTiWU7D45jaIEgVrdtl+CdU2ADjeUVeyw4fWDs+n1SSO6jHLc24Qfk6 FqxNjlNVLXnk32DJK1oYyQuKAHukDjA8MAPoGeCXOidbNwRJmkGfUAicRf3o dnJESUKZ+k8d82Faki0rSGitzzVwC/sywE61wVitOxZ4oyqhn0SUIAwQDnc0 QAHAjgxgTRa5jtZjhan0+qXUScl+SRR0xOGaLgEhr6GAEQifCt8jI0P0flJk ngQQHWWxJFtH6zLe4tX3qipkxL8oxkFSTAqWQ9kcALxJBMaSVfckL1kzfTGP ifK3UPbob0IC65JJwCjv405ze8cIPD4EYAC9kK8suFJW/pRy0GXhfOCIT7CC Yy6KuU4KH7GLx9hG9clqOIwliQmeLtQw+W31bhCJoXX4dEaWmTVgqEVYB/YA Z6AnSh0J6GMhqTBUq1IiCMBja9cDTUEHU7MghUBUqTmsgkHYT1QDi4hHJAGQ vTEkvuYkj5V2yehsNAkLFAwEmRNjsQX4oSL3A54OjbcQa7gh3tQRAbFQ3qTG 9lsgenApESnmgB+jGKAkcAbtjZ6BLzHCAN6BmpBCcwSiTQIrTZFOqaNWD+gH DuaKo+x2p7N7UVpeFKGhBRyTbkj+XgkzxsK/GDp/GCJmA1RA5EdWTi2wSg4R NKY27t4SaKgqUtTjkRYpl0UAOxEk4Phc3M5ZCV1MwTI1ZMNDNDIuiJTAsoCI IGNmarfyXvlRrB0431hcFPcqCETCeNOtuGUuBm2thX5BmB0YGECmGOSy/85+ v68Lw4p5Yf2O76iggwZOMD1qRTl1JbDD83WIURg6S5PB1QaMI94lfMBYCX44 2cslSY61K/6naDCuBY6TkDywKdIAJKZo0eFEGQ6R7BURjryANggvspKA9UEy IyhYXMQ1ohBEgRzJu1wzMgq9TzGSkMOEQWTERMPAsbAQlA7q9+UX6IFF24ls BluJt+QVLoscQKHhQQnG1IQdeOszYoOy2RDpwNvqDhQWVjo3y0gguMEQToho ZJtxV+JUKOw4kCDUKF44uowWRMDkhiGW9qDExF19nxmBm2tCIPVgUBcCt8uS zLlQWih3ro3iAHgzVhQM52OsCT/Ez6IN+WHHQCw0PDWIcztNmrPydkqJIhJ7 YgrxMxdyRwaPUzHHeeM8wIvbgqwimabmNZ4b6s7PsJJD8ckXiEshRXQPVp2A dRYiV3WXnDy/YTNPqjgASLmAs9gx8jExJEAUEGhwA4DP2mK8WN9B3cIyov/G RRaGyQW0RCXeaPCLiwloClz+JSlQORQvNQqg14TyQFpPBA0IBuGRKig0hY2c mym7NVJsSKfI20gBTNWD4y9oHZVgQEa4INaBYbTMbTqItzCcBulQJLiNlNwH fEFJ7Gc4H6kUYUIYAlEzkFn5brIfTbdAIuXRAIqPyK2Qm9hww8dRIgnp2ja4 UyWu0IHrUDuIFwgLJ4Ptq6fLE+A9D9mHlInPZmCU0KRSLI14uziWBdAQn0PS 5IjlQUMhVHfWssaGbS/6GzLinixuxloP6PYCc4/Gr3yQw7zjGLH2IBGrsaXK KOYOJEGRh0msAS+q0plegcRZNwQNkSBdq4WI2kNmOO02NRINR0tCJzCIZV9k PwUInB2P7CUCFKotNQeh4N0lTTe1g7a+CRoAtR3FRI01WIc0Gr2jeFkhxBWu EQoCwLpnkkudJNQ6OI7p4q8h9Sr7nkhlVsNRkGgttKIZ3MuNMGUJ6WuMOIA9 3bxQOG4AFoAC+NXOeZ5g7CfOUPOM1pHxH/3V/w4m40SAqB1rPe8plGBuaAem i+CeRNTIK0cJTYUlHwQhSQ50Y/AoRji5W2bs0MVFOIBGhHKA+SsI7QZVFlHD i3RqsTksFmOlPvAdkXStYcJ82BByMQYSrNaGYasIGQo43ZZVyVXMBWMEQKKX 68sh/AE1UlId8ELfDK1FDCPrFpkJH5sUASwEBsBTSPuQZeD2JrS2YahANTFV 11dQq1rtWFhWbYUnUkORrggIYnQoVplspLCxL/29CFKkco8ujBrAXxyHNAas mIZym8TPZig66mdGqQA0a2pVPr0QZ8gy+MDMcH0kKAqg4DqYUVtgdvKoctBT zVNwgJzSTJFt2Fo8LbxV1RGs6k8EFU6mHGHfirzLwBI4hKpy6jUuxhGylGC9 KH302FNwWtygpUC78FG01lI3ed7LMnbKcUrhCR+gBzfxH5qSqbHNZxF6XVm2 qGx1eOS7jFXrSZtF8v94P0TTaZTQZVA9YGMlIvAp8J7QSXR4tdU7q2oSJAOX h5jSh8kyMqJUgfRIpC2xEGojxyEN5IubFZ84iXeEp9XO1FrbyqqrCDyk68FX YEwdAZAtlWcRDnx8yGN0cJKV9w7MuaoyqRRxlzQPQILqgehKUNMG9G5kE5AP SVR5YGMF8VsgyJYPiLfgRRAH2I09qV34HSETRaymlkhDYvFFu5hhJUA5xtrk 1DtUAHKR1vV5TbV9UOVzHaCWyr3Q7dj26YUaVNn/fcPlfnohyLfhFagX5Bwq 69ELyR4gl9s2KvBOuSVMh3wCmv+1JvZMz/dDBd4aa/xAnSJE4oC461G3evlj 1jjJf6z6IH+xikLGim9eQ9uEbZhrYBgCg7RJmHojSXANmK0Ku3p7TgJjLd6H 1Ej4HUuPBAxUJR0hogL7UmYsNl4ablQXrcqO1NI2iYeO56LIeaRUVa8nT5BB 9hFpjNEbZCQKSY3xJlvsbIbYnjNCi6NDQFJCPZVNGWinvJN6CKR9R0/h1kS0 Er8YaDW2N8KQFPausAo4yIDNmCQ3ghZUIK9kvckR9D2wF1Di0COvRxRxU2NQ zc+k3l4lwcq6rsULUWGWo5SfkR/oMNxAr0n7PkQnq1OKwmVlgW+GAhYgpyBu xMDBc0nBZMclcBlUGWasCH1UJ0gSbp7UlED8seLYCcww9R+Upw+PYBKApG2U YvLpOioc2JLBWTcAH1tdcQQ/YWuRIp0kNuDdwUG5r7f5xDxx6gk9S1HUFRrY 6IKOUeCUcScJfoMpKFuo72ovK4YQqUSkCQlPfjGbpL2HQaYhliCMpZ2GQ5Y6 lhjYR6p5eAiUQnyrpQDqkFP3IFNRM/ACYY/DTGZmdDzF7p4yQlCpFQ4jY2pw ayjb+LZSKytzyAybS1s4B505IcY91KuBEwFIct7uoZBQN4CTIaMPueuGZ/mo 5whtUNdloSNImaBtUAwLfN1RXyhkBDWwzFi7NBtRB5kRW9pNBRDMaRPvU+65 pf5P2it/LfbVULWvCYrI1/bDSqQ92CajeVrVvugFGZFHmbXqFQ5Gj7PMRBaQ RmcsVD946d3OR0UMQrxtR5wbpAS0gqirk7QocPDtykVi4utOkCE2Mowzj0dx TmQBybS40BWBQfpgJ1pD+yiwONhHul3BpxQWV8JaET/lpNcqErTI2jV5/w4Q uartko6/yIFvhDmUSlj19WJR0WrIs9Rkt1o0VLB62JAg2B8W2hOdbDBMcHVB MoxUO942t4eb4OKpVl2QImC2FZZWYyyomcEPXjc7elQhxgeZEMHE7ZL21du1 myVqsHOYFxg0IoQQP9R4er0W8iOJ0OJuW0PC9sWtPlqhNFnW46gjZrcZT8eo Qj1F2nDlcnBh2jBgGIFJYg+RX1fdeXmdzkxmNJjEUOZlNtcRktSwr9ryPt2Q EqDIwKYgw+L0alDBT0kVTWaC+7vfpcxGiwUyb6nHv7bLGw+HMtM2b/u0WFGj QAFy+YBfSELlBqZ9HFOLjvIoSwiGTzyIi6RdsX2dUBobL8k3UQ6oNSCLqio7 yVdgqNDUiMaKlg/YaOC3GrBP0EdCg1UqDlaCjpp6HIhwFE/QnimevXtJPRAc FYdnI/B4CGzb8VQ9ohGoqjDSYiqVG2hbfrhYtTnpXzhNHrYQUpQiA99cs8L7 UTsGUoJTWyjaxIckVsBP5nfYqWMx8P1UCDAGtKyFoJi1AkMF5whVJg3F1OzH +XkIlNWO+Af4lAVFpvQ7lyQYes/BweCcNijuXmDn7b5AIMSHrK3AQcfzR6/0 yyzr1g5qRGTierT3BU5CX0Cdo+jxORtSUwMfQgNjKobiG1uq/x93VX98df7f fOP/z4XQrKyQQe24MASGuL9bQst6ZDlvWoAz5SIRTf2zMAAzYFIR92qkqpWF VcLeC6BY66kyjHh93532mfldIDxpvxi4FgrAi/77EwLqgQF0acSOBLAV8a6F N5BSaD+kYdJxBKkRtPqtHbjHaSbuRjUBABkfGwgtMgLO9/XsMUgo8VLxfQ2x LsiXIl4M7+PUw4xxC6j35rMYn/vzvXQraoK5XB2JIR1JUvRSBdxwtQlzTKI6 rx2XEnFDCCYk1YaE0WPYT4EkN3y5LF4Hc3NX7xHEu1jv65EuU3vTOsvjSn0H TeTqAfqo4zddR4d8ax4PAUYh7aDfO+4AsaI2DMoEC2vdhnAh4wZwW1xSK5DR MYpf1lAnaj4z67+PmjBCL0YxHCijtusiwhmKxxvKgejzBHVzOXwnqgFwWSh7 BgXnqJrRWVvdfaH2jbkkUMUvHKRwSy6SKUXs5lIcYGSS5vdJ/Wm0o32G5ub3 2H4fmv91cJtcAuFFnB7c53MFAQ1krG5O27m1fgXi9AKxkYdSZ9BqeTs12LjX isZNI68Qs0AIvJyLyoSgwm9tYI7JhC3KEhgHtbPByXwYDByIsJfbswVc6+wW CYOivdQS9ApjlSu1GFbxUv4IuJs17iniVpS4vQ2QT4QGCU6ENfxsgDkMTrlU MQb0aSwdGaNWA1YUAvubvVxkHJUGqOOAQt7kDk5c7RJAq01UA7qfq09yMLhG NDN1NZP29PuldqeteWPVdjJWMlydNJQ0FpVh/UhezJjISBvjOjekNj/h10kP yWOsH6uHGMaisgQNAeELYQ77Y3XebjIAoqNA2BsEEIFicXXcB99vmOVV1TNI F3ZBUuaKsjlSAVtNY+0s4pyRgQSyjXEE32iaDglFirYbFHbx/RdLAkuetpg0 fiYGdCRrq+0rhdNQce0oXnBwgG5ginN5h5zmJhIduV+TEyZqI6ohEQ5Wh2Ed dcQKLk0t3ZKQ3QDOEjX1Vv3FgUBZpjNRI1MJB60dUP6wok6ZHJgT+Yvqw4lR +ls722h9fF7QDmel0iNqg4zUDFjsxji6OggHl41fUwdVR0ZC6aQGJIp+EiID c0ZVNrVEESpk/2Itr3aRieVQMxoTUkSXMm/uuY/8zAlFofPhgixEltqB1xBS hJJ6azqigp5JF62PHmf28qP5deR4xYHyx9SOydJsQy2UygLwxhGokbMl83LD 6peFYfSGBYBRMKM2Vq7aeqEcC4Ids3TV6H6ZTuBwFPgJmJlvQHxisuCC8bbb 9/DaVB0Zrtbukc5ewQJqjjowt7HWE2hEENi9KKqqTRrZ0hVxZUJF7Pc6W0Lr 6Him2nZZh1/iOwGjVXSBkWBGn6QkSwGZpO4/yhY00XYNCffGCiSkDMChgs8A +yqGHRxSg9/OTk7aBi80BIdGXiL+qHDmiuNbG76ksMhOLR+ufhMaGVQsKsoO uESzsZpm4+33+23etBPGL92UpcDCBWU3mNzVtUcbbb1AWeaedbwGB77RqEO9 bjjYRaEXF21SVQxmzBKoc9uwDWt4DiIO2QCJgAng/y6gLZndN+UYcBJN5zDI I+BK4hL3bzgOcsKrWYnuy20NbCXYRrCKtoPgLTweinn7VXVDzBO5qfM8YzgS GsOoYyZFB6LgBKCIdDdDbWBzQPLwPDf8XNQZTSA3L/SJzZj8UA3esZf7CLOD bdPB3D8roqr9Udm3pZ0M+MNQj8MbzN4wFxcnvJyaq0wy6+Rjxv9g8KunsifW FA/BmIz4Q4TzpIOgzV1nNxEtpWG3prQzAyzDeeqEPMLzok1b40YHiY+kx6NX Qsi15Wcg6aWhg5yI4FGOfCx1wlC1SiM64lyLjpBpgzm8bT7tg8TedCIRmFrv VCDABIri+JZ6+OqdtBhuQrlrR+dYd4h7yLcEHSTd6GhVPUU6dIIdc32W6JB5 KhBQChiVcNkrUXTW0ntoIBD46+5YF/jBqlPOSAbgAT4qmExybiIQKSivwwUZ /wSzUCtXA4euhU4VUCaWKTjA4mR1sK8xsL2eqhusynk9owPwogPTQWZ1vGPQ CcDdIU7eFhg6NYOmKur5o7goq463YDhXx1gM/MIaa8fXIxp0/C9REs9HRX6r NwThJWEAljiJ7xw0Cp00xG1TPwfFAHLpKQl/dI6YcL8tacPiwHEnJ4zPq8/4 OrxendSGhXHEEMEAmHudF8bQaopKMfgPfTl0Bkgf2TqdnpG+Jplzs863JTFj WAcI6w6ppJ0SxHyGjHVqGL4qwiF4DZgD2YAGzF0lsOgwon/1oAjIfjC2nRxX Uzg40jKMoX8sIicHpP5Xwt+9k3VeUT1oAcHgVoePMRSNFGZ6W1GA3/S47L11 GnRfaYqExmG5UtKR8gdlVGsj/4GloazLDAj6YbaxemTdODqkuxMG0M0MFqu2 SIwTtWfqBRAJrwUyzopVrl6HjRpRIEKv8wE2wKWrHgTJAPsEtfNo0/hFAC3A Dd6esVEb2lssgzlSYHCgR4Uj+6oIXk6vMo5oBiji8XGQxLWqr6oqyaYjZxVR ON5OiLW+0HpDMafgxI2FSIOSeppGbSkdgQw6NlGhbAxreMeaO9WMpNGZ0QAJ AcctHnUVECpqEIfLaMT8XQeug69wUQvomoa9cGkfpRy0HgSo2gdeRY3apOkO omIKNkoI4Djqj4mLQH6IMenmOg+FRHRfm1YXkiTN/nZHC1WDBtisLtLLr0Ta a/9rCWYBA234LrUukVZd54x76L7qyaG+Gf+R1D0oCqAJB6LKRyVoPxysQanO gXyJ0seGzZIgSO9MDzGjng0loxNuL46eGh1oOu1yIowBpV58IwA2H4ztuhje ojhcifs2ryOIhqeaLOEcOquBqx3ECqbhR+BMzWhHKf6zVmaE2rHWUUuSCWDG HWXtCZMDSU0BHX+N8EBWGwpNzdB6DFldWk2qFykdMgs80UEFPV4RElS6VnAL o1d03EQa0MAc9YmpRcJraHxyBeGIEGZygQVbr5BAjl+XwWkd3mkcTd7rMFrL VZ6yaN80KuSAdWuJggb+NCOdVLMpYmJASKikkqZEdDbD5DtAiKhUnV+7EcA1 LItsaBfd7N/h9AZxdHinvTsl9RPPtNvMReU+agY/jhQbRB8h7SW1PseQgYC/ QcYI4arJJ6+UcZADR5CRdlHaDv9AxWR1RcVi0XMPUl590KTm45MAY/WlE8Y1 Te0Jo5W0CbVsoF7xjy0Z1oWrl/IFaTDeB9ISiPRGQ3VM1vo+VMQ6Bgz3BelR cU5OJQ17khIVgoZBXQ1j/vgp4jJMx60PAg0FopFXHSSHvX/BUfcTkJazovrr ADeVeXwt1BdXguOTpChFKoG+u55+MnRgkmMrrIK5ObAAynVZaBKRUbfzJrKO L0qRv8znzWYPqQ+qAk5d2u7FVq2rJ1h0ejXorNzU0SOdxUchfNr2k4T34zW3 oZyQ/3U379/9dDdEiNSIHnlBA189VVR1RgM8itPrgRLteQ30DTaEbNE5Edwe 0TAdTAe+HrqC76yfd6QsBMfoyHc+CBSqs7LUISAD9pT3bu1PuLAAhKLTVwlU Oq69XUDyyriYWlIr6qDYVOcB8CezqqaFatDO7tQzEg2hijCLIyxLrFXW6VY1 NKtcjI7HnWY68IPa1uPDUYVXtUcjh4cy0qnTI+Ir/etRC1Dp+0Cn037hMZ3H BWh6fudXoQ2DjZAgEABGtqFetSGQZPt1bkb9IeEaK7tX0IFFlL8ekEG/qpmv apOOkAJfcELSqalS9QSOdm6pTuqaCUfspajcK+6EHVGfdR7yneE22SB8xL8y qGJeH5PgpNsnhYoO0vDm9jmAMtunb4Oiso8XyThe7S/r5HlSH2ZVrPJRSwQx KfV+f7qX7pTePljXoYwE1zqv1rYe22lBp+fOmDGKei7CVU/qaIOx+dfVwG1o r1znqV+3cSMATMdaqEamtq72unb13evgWJL1U/97+Pf4VxVibz0uhmYkJUER zAq6O8hg6/kHaGLrFKueWwHM/e46fagng8DrY6anGfaV4FDL8zA+dC6qwN+q xpT8MchedXwKh39c0JNoF87ziMrxtcJ/WV/yoSFu4LQGsthmHjAy6by1PYfW 06FrH7MjrlsgtbxBuLpQ1YXa94Xi8xAe5sWLBsKuh7tC8Tr7dpCNkJ2O/Ban 58Z+D3R+GdF+itJVH4zqgEYoJ27WdTRCJ4sA5ekgXC9/iO3QU9wqzS6JjKFH FCDRCxoFhAgvcXw0dZd0EpbYlxqwhjrjMrHrkyqbpdg7mzY1h+/xa1PqGNZF zxOyKKbVxfLrUbKLdiHZHy7BVEkPntSHuwnB8g0QQ8ckGqrkarfyqeyLtAJN sMNaXD2F0CAK7VagxKEj70LQI5RepwcwzGLtGrInq/bRc80jk/aoBPQs5I7O CP6CmTfFrtPwwDmSTeN0fx7oH8fZPuP8HA75daSSfnok1mIEzScJl7yIcckV Yt/6x6v9SIsf+RXV+s/Wi/inJu+yTvvoZKwOMGRI8Wh3HJcHStX/cYFr1Olt nVsPlLjTg+AYvPQNEXt9rfBn1GGzolx+NsGDrqPNdj1yMdfrISRIXgF3wi0d dQnv2EGbOYK0oANiE7/3+R8ElKwjOkYt6fzJ1rFFCAiunF0n8UH105x6u/2d s6CueC8aZWLowSdqyy/R6aDGk/oeOvgdYNzp/5L48QOFTl2ydzud290hYIn1 UDbqdH5qoiblpU72j6ND5qHgS1Fs1D1LGEkhYgOLpLXD3GCQThoWSBHmRymq laltPcjToi549PRbVAcpyhz0jiGfgUigglie5CKUixIbb1cQw6fI7qXnPYcU NCUStU/lwxZSEr4aV44WMWnLrg5FA8iIdxfWMp20g5HnV3+PNfru7wVpGSbX 1HUrUpZVR9JT1qF9eHRR2k197eFsjIYi9NrllvhHNlxtwUG5V8dZcfWsfHzN voSEfE8x1iZnhvOyZ9DWTlf7/QxnUjMIh4iIZL5JZ1dJEGgCOga3buO1Tm1V PYnbSSevTTu15hIXJufV0QLS9ThxgVWv/tcEEF97nRLtRkxZS/8auuTMfhpC F23Ub1ZTOWtnlDjqqOd7qIvKQ4aOT6niuD+F8Kb5Cpzw4z4/Wxlo3vg6pNpy YbV0cMnFsHgbUqYundrX8TcdhD9BnZC3Al/X/1z9c23/dfWmq+M8qCLtZcNw aBltgOgJwaRBH1YTL+vzeyQiqxdWt9ScpZOzMr8h8VLX/75BveU+HHX1lqEh CFG4lpCG2p0ZMLE0vp7mJXVhx04IR2N9vY6XHD07YnpuRKSxigNXq8zX2xH+ vmrQFnkXk34vw4hSNDuCpkl2IOg5Gj1lgfE8A3PiekNB6Fk+VgJHTnVsMbSa Fd+XlXq1PpYdibF1SalsH/qa5VOy+SLYS9HxFfWlNtUBs+p8BUyCDvRBZk9t MSipvP8XRg7azQhJj1kyzLNg213PdTCeTlJTE72mlMZ77GzrkRXBjXb71ipd 55a2Glx6diuj9H1epWHCxJuqvUr4jzr1yKKES1xYftMeI4HzehSydmEette/ p41SVtWwGClRy9pe1lnzBMAyIrTJ0mGLIypX6Lok8ce4EDxdtr3LAgXaTBp6 4Kd1oq4d/2PKkFrRR11PAp7wykec4aGTqFVO611svYfQ9NTppzxIO6FMHDJk /bwD8Se497gOfF3L0YYBWBBkipUwOuZetBuvDa5P1akzrII4uF21OLWptgZO 6TidysQmyAlcM+0X6lQQmhEIkGBtepZ963jC1tEZkinO9lkJPTvyulkarvtY AkYshwUpH4nHV0B6qF3PFyQ9w9yE0jonpHOJeuzWH6G8nod4hd0cNbY//SPU ivS52PKsqh/DhTZQhbdKLSMr9RzK0D4j2ZIMnNl6eNSTqdXpiT+CgEfpLHuT avpEuuAFlKY6Y+kTSLBAfjSf9uY/R7DexlQNldie5ChkcdeM7+i72nY23H8D uWZ05wi91FUAAAGEaUNDUElDQyBwcm9maWxlAAB4nH2RPUjDQBzFX1O1IhUH C4o4ZKhOFqSKOGoVilAh1AqtOphc+iE0aUhSXBwF14KDH4tVBxdnXR1cBUHw A8TRyUnRRUr8X1JoEePBcT/e3XvcvQOEeplpVsc4oOm2mU4mxGxuRQy9ogsD iCCEuMwsY1aSUvAdX/cI8PUuxrP8z/05etW8xYCASDzDDNMmXiee2rQNzvvE EVaSVeJz4jGTLkj8yHXF4zfORZcFnhkxM+k54gixWGxjpY1ZydSIJ4mjqqZT vpD1WOW8xVkrV1nznvyF4by+vMR1msNIYgGLkCBCQRUbKMNGjFadFAtp2k/4 +Idcv0QuhVwbYOSYRwUaZNcP/ge/u7UKE3EvKZwAOl8c52MECO0CjZrjfB87 TuMECD4DV3rLX6kD05+k11pa9Ajo2wYurluasgdc7gCDT4Zsyq4UpCkUCsD7 GX1TDui/BXpWvd6a+zh9ADLUVeoGODgERouUvebz7u723v490+zvB3gHcqkl oKXxAAAN/WlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPD94cGFja2V0IGJl Z2luPSLvu78iIGlkPSJXNU0wTXBDZWhpSHpyZVN6TlRjemtjOWQiPz4KPHg6 eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1Q IENvcmUgNC40LjAtRXhpdjIiPgogPHJkZjpSREYgeG1sbnM6cmRmPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4KICA8 cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgeG1sbnM6eG1wTU09 Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iCiAgICB4bWxuczpz dEV2dD0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL3NUeXBlL1Jlc291 cmNlRXZlbnQjIgogICAgeG1sbnM6ZGM9Imh0dHA6Ly9wdXJsLm9yZy9kYy9l bGVtZW50cy8xLjEvIgogICAgeG1sbnM6R0lNUD0iaHR0cDovL3d3dy5naW1w Lm9yZy94bXAvIgogICAgeG1sbnM6dGlmZj0iaHR0cDovL25zLmFkb2JlLmNv bS90aWZmLzEuMC8iCiAgICB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5j b20veGFwLzEuMC8iCiAgIHhtcE1NOkRvY3VtZW50SUQ9ImdpbXA6ZG9jaWQ6 Z2ltcDo5NmE3ZjI0MS1lMjNjLTRiMWEtOTdjZS1kNmU2NjliOTk4ZTIiCiAg IHhtcE1NOkluc3RhbmNlSUQ9InhtcC5paWQ6MGNlZmJjNjYtNjFiMy00ZDZk LWExYzgtMTg5M2QwNWFjOTg5IgogICB4bXBNTTpPcmlnaW5hbERvY3VtZW50 SUQ9InhtcC5kaWQ6NDIyZDdlNTItOGE2Ny00NmExLWI5MjYtNTJiOGEzMGIx OGIwIgogICBkYzpGb3JtYXQ9ImltYWdlL3BuZyIKICAgR0lNUDpBUEk9IjIu MCIKICAgR0lNUDpQbGF0Zm9ybT0iTGludXgiCiAgIEdJTVA6VGltZVN0YW1w PSIxNjU2MDE0ODk0NDU0Mjg5IgogICBHSU1QOlZlcnNpb249IjIuMTAuMzAi CiAgIHRpZmY6T3JpZW50YXRpb249IjEiCiAgIHhtcDpDcmVhdG9yVG9vbD0i R0lNUCAyLjEwIj4KICAgPHhtcE1NOkhpc3Rvcnk+CiAgICA8cmRmOlNlcT4K ICAgICA8cmRmOmxpCiAgICAgIHN0RXZ0OmFjdGlvbj0ic2F2ZWQiCiAgICAg IHN0RXZ0OmNoYW5nZWQ9Ii8iCiAgICAgIHN0RXZ0Omluc3RhbmNlSUQ9Inht cC5paWQ6YTY0MGI4MmMtMDg0My00MjYwLTk3NmMtYTg1ZjA3MDc5ZjcwIgog ICAgICBzdEV2dDpzb2Z0d2FyZUFnZW50PSJHaW1wIDIuMTAgKExpbnV4KSIK ICAgICAgc3RFdnQ6d2hlbj0iMjAyMi0wNC0yOVQxMzoyMzo1NCswMjowMCIv PgogICAgIDxyZGY6bGkKICAgICAgc3RFdnQ6YWN0aW9uPSJzYXZlZCIKICAg ICAgc3RFdnQ6Y2hhbmdlZD0iLyIKICAgICAgc3RFdnQ6aW5zdGFuY2VJRD0i eG1wLmlpZDozYTUyMDNkNS04NGRiLTQzNDMtOWZhYy03NjFmZDZmZmFhYjgi CiAgICAgIHN0RXZ0OnNvZnR3YXJlQWdlbnQ9IkdpbXAgMi4xMCAoTGludXgp IgogICAgICBzdEV2dDp3aGVuPSIyMDIyLTA2LTIzVDIyOjA4OjE0KzAyOjAw Ii8+CiAgICA8L3JkZjpTZXE+CiAgIDwveG1wTU06SGlzdG9yeT4KICA8L3Jk ZjpEZXNjcmlwdGlvbj4KIDwvcmRmOlJERj4KPC94OnhtcG1ldGE+CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAg ICAgICAgICAgICAgICAgICAKPD94cGFja2V0IGVuZD0idyI/PlmiVpAAAAAG YktHRADwAKIAftw2PhcAAAAJcEhZcwAALiMAAC4jAXilP3YAAAAHdElNRQfm BhcUCA56CWQaAAAgAElEQVR42ux9Z5gkV3X2e+6tqk4Td3d2epN2tUlhJRSQ QEKABpFE/ggm2SAMxmBbtjA2/uwPJ2wwGNs8BBuDbTAyOdnYGIEtECMhhISQ YIXianOc2Z3diR2r7j3fj3sqdO/M7Ehik9TneXq3p7u6uvrWe8894T3nEjry mOWnT79UFdaUledrUoFPBADWAgzYRoio3rTR2CQfuW/UPuPgdu6M2GMX6gzB I5MvAuqiN7+8N9/f1Uta94C5xzbCZQCWE/MSUqoLzAFZVrAccWRqNoomOTIj 1vIBT6uDNjTTptqYmtkxOnHR5ntqnVHtAPe4yAcA9aprX3O231N6ktJ6E0Ab CLyWmc8gYFApBTADlsHWAswgZsAwYC3YMmAsODKwYVSHtXs4srvYmK22GT1g a817p3cdvOein9871hntDnAfs4x95DeWB+XBl0S18MW1feMbibEUhD4AgAXA DGYGCVhhOXkNNn7YBMDuISCOH5FpIjKH2JgDpt78cWOy+vWoEd1y/o/ujDp3 oAPcBcn0z79O/uKlJZ6aXG12bX0bwuYvAeiv7DgYmJkagWXAmMEWABxQs6CN wcqMFKjt/xsHYjY2AbH73xgY2zC18CFTb36Cm9G3olrz0Dk/vqvZuTsd4M4q tT3f61G54tNA9FoeP/wqs3NLCcagfmgS9f3jIM4CFSBmB073T6phGQDbDHjb tW1sPlhQon3NUSBGZGEb4RbbjK63jehbY7f85L7LEHa0cAe4Tr4P0OUjt7xA 5XK/CqWv4kp1UfTQPUCjhqjWRGXHKLhpkNW2DsDynMkBVQCdALXNdKDY/s2Y DWwtyLADa6yBI3kexQA2sI3oAW5G/9mcqn7irLt+uqsD2ycwcOt7vqOY9BqV L/wx+cGLoPQAIkPhQ/eCx8cAZtT2HUHzyLSAVAZMNC/Hmje2d5E1F6zYuQCx PE+ctVbTIQYtotgeNmDDgDUpkCMLhKZpm9HOqFr/a2v4c9GRmfDcrQ89YUNr +gkJ2t3f7qEg9xKVy3+afP/ZINUFIjIj+2EO7AGshak00Dg04bReLC3gjac9 y1NuUwecqoW246ntfOCMCiH3lI5WK5qIFmtPX03Aucr3HvytpUsP//3IKHeA +0QA7Y5vbaRC/t0IgveS5y0FiKAItlJFtO0hoFEDW0ZjbApmun70CZgyiJsN gTHwSMwKyiA9A0aOj6UW0B6FYzpqUfSUUptI0ZUKmH7TpHrgk80p0zEVHqdS ve/LSnV1PY3y+Q/C858KpRVIAUoDDITbt8Ls3ApSCrYRorL9oFu6E13q7AVi yuCWW7VwxmEjMR1iBy0xGVqiD3GEIXXYkHHYkvdixy1yNm9sPnAzGjfN8PP1 w5U/O3fLA0c6wD3JwibSbK0GW5+NLbCNjA2bDQ6bhqPQchRZNpEtrjlrQctk 9YEv+6pQeBHlCx8nzyuz0gTScMBVsJUaGrffArIWpBTqByfRHJvODBCJkkyX f7KZEUwiDXL9MTiRcdjaw2aZBEUK3NjObQ2XJeCNDDhiUGQcsCMLNE1omtE3 o0b4e8pXu9bdcfcTwnTwTrULMmFjEVuzni0vh4lK1kTEJiKOIsCaBlszzdZM sAkPTz949xSHYQXM1Z4nXTbrclm99/NFlcu9SeVzH4BW3dmVGaI8w507wI0m oBWstQgnKslSziCQ876S5Z8TwLZaDUycrPMxnlODFanZEL+usrpDOa1MBCiV 2gwxyBWBtQLYgKHSL2b4CniF76mSZf59APd2NO4Jlqg6vQTAZTCmLwYsoojY RMaayMJEPhujOQVzncNwkk1z3IbRITbRyOJnvHAyNQ8+X9CFwrWUy70bnt8L JaYBacTPbb2J6i03A40aSGuYWhO1fUdafKv5BooZIMqALLZtmVvBl9W0nIn5 xq+bWTSvbYvtGuPeiyMNJmM6GAbl9O3N6fp163545487wD1B0jh4gMjXl7C1 Z7GJFKLIMts9BGxja2esiRgmUjYMCxw2+zkKl9owLLOJijARWRMZNlEdUTRm w+jhXF80mh/w30aF4l+S9rqgtQNt/CD3f3PvftTvuhPEBqQ1wqkqmmMzqe16 1GAd7Zy1BA1sm/0bZ9CQPncWRzZpkUkNcxa8DDbGxXqtgDR+L5S/TQpgHXgM ojubk9W3nXnrnT/rmAonxK5tehzaIluj2Rpma7eTUncWVp8Vth06PrX5tgNs 7QMwkeJmY4BNuMZG0UpEUcma6EzYaD1pfR4F/luIkBPPqQ1qTqWaI0fAjRBQ nNqnQkkEEZjIEWbiMxBnIJzGcuNvOEr7QlQy24y1EM+KTMRBUaqBKY6JMUgp MDsnEZ4CIoBgwR5l7Q2AGTay5HcFTwl68h/ceeVT3r7m5h9v7wD3OItt1tlG IWCMYhM12PK+nk2XhLMd23PB0xJdBuAAgAOj//VZn61ZbqNwdXFQvTS3uPBG Isq1hKJa9KN7bmZmwGEIaAcAHXiIFDkPPrED2j5Oqf3bEpeNTYckOpaJAVNG UyukSQvKfI2iVr3ODsCkyH0LE6Al2MYK7AGAkRMy2DAsA7rgP5eZ37v1souu XX/7T490gHscpbj6rGjq53dU2BogipS19hF5x4MvfUMIYFf17n9eqoq5FytP dR29zvNRhhKDYKMISkLa5Cn4/UUXVbAupcs0Wyx3lvPNYnsxZ4E9WzzXARNW JgQh0bgOsCxuoYA30bAWBAX24vnrZoM1FirnQxf81+RQOnQj8M7nOnQ/rkSd UhGFWvWgqVUiU6/6tl7pfcSx2js/PkC++jPy6KzUPIhVIKcevizDYED39jiz MjJgE4EjA5UPECzpBnn66Ngrs3ATRCPDgpH+zVnGWBwBludHWcYUTx52c4FE 9SqAldPApMhpYqXccy1/a3ccKeVWC3m4cxEo5yld8N941vOe9pbHo8Y9pYDL YWO/rVWnTK0amGqlPPrNzwcL/ez4v/+5B/BvkadelLC42jJaRyk+ZgTLlwF+ DhxGCXhhDXQxQH55H4LFJaiCB/KUA1qW6WWt8HIFfAkrjJNH1gim9vgZ0tBZ elnueCKn6V14jEQLKwE2pWBVAGnKAFdWCN+DCrw+rxhct+s5l118/8aN1AHu cZJFV1wd2Ub9XlurwNSqK2zYGFjoZ/0l3c9Xvn6HI7s4NDHzLIt5JjEAhtff i/yTNsGGkQNvaMCRAUcRQIygv4TCikXIr+hHfkU/gmX9CAZ64C8qwesrQHcF 8IoBdM6HCjyQryWRHpNonOfPcTQgq30zThqJicCKkjgxqRSryGpgUqlJodwB DrwO1GzZTTRfQ+W8c3Uh+N2uM5eUOjbu8XTSarVdNmruYWPWsok27f3sRw6u fMN14Xyfmfzvv1iuct4fgdADy26pzWhVZLQftdu7xCiesxGILGp33gmERixG 9zkLgDwNnfOAonJLM1HCMcjGGBJeQRLGlZBW5GxPjgw4NOBGCNuMYKoNl/iw 6bUloeBsAE4ULospQYpdEoKNHJwlO5D7Lq3Er2RoBK82kfnOtisv+cK6m3/C HeAeBym//E3R3s999CdsomUcmY0cRTsBbJnr+MOffZf2unJvIOJLnBtunbPC FiS2KLNuATC1k2ICH8WLNsFbsgi1n26GnZ4Em2YmicCwrKEYYM/ZlaQAaOXA SgJaUuJXCdJiGyFW8vH5LCdEdI4MTK0JU2nAzFQRzdQltSuJB2KXvYudNY41 NLtMGqwYxNYBWJGjRSoCPC+2PAK/K/eeqBF+F8BoB7jHS+vWa4c5MvewNU+x xlyx7UPvPrLune+btZDQX1TaCMIbAeQSMncc0FcshYtWNJQAxrLEbV1CF2CQ VsiduQrByuUIRw8hGhmFnZ4G12tAWAfCJtiGQDNyqWGtQUwg0oCWeC9ZsCzj 1OIJphExzsRsiQHyPZCn4ZXywJIesImBXIep1GBrTZhq08WaORMyY7lyFcfW 4siDcpPVMpSvwYEnsQhenesr/h6AP3g8APeUNdh3fPQ9RRs1n8/GnAFjdrAx 393w7g9VW0yEb/yxTznv3bpU+DOVCwDfB3nuAc8HPA+kPEDLQ2lAe+CWtK9y z4lApNyQKPc/hyG4EYKbTQhXQlKwkctagUHW2cQEYX+5WDQoioCoCYQNcLPu PgvKmDApo6w98ZFlidlmCFMPHZCnazCTVXBkMsWYklXLknUiC10K4PcUHYss ioBmBNsItzanar+0+pu3/qwD3OMoD3/gXQNszP+BMUU25ic2Mnec875/TOqu xr/yByu9ntLdqpgfoMAD+YGA1nP/ax+kNaB9uJSvgFd5gFIOwEqlXpBSmWVe ZZIPqjUR0ZIZQyvN0XJS/ZDSFg240QDqVXB1GlyZBlcmgXpVQmwSTrOcOHDc UuLj+Ak2isDNCNFkBeGRGdh6U0p9suAFYCzIU8gN9gChTZxNbhhj6s0PTNy7 /z2bfn5/2AHucZSH/vTajWzM89gazZG5ka19YNPf/SsDwOTX//B9urv4R5Tz iQK/ReOS5wlgZ9G6ygMrBVKO2ug0MBBTHSlejikT8CeAWbUl0lqdojTjlbFr M5oxKWM3wjlo1MEzU+DpCfDMBNCog8M6OGwCRiaAkfhwzMmNARoahNM1B+Bq A7YRyXnTmrf8qkXuPKERu9nA1sKfR9Xmq1Z99aYtHRv3eCYlKpWtUKqPjbkC xj7LGtMEsPXwP//mMqXptWBLR3NdnZYisgBZMImjJsTw2CYErLMZrQWRcl67 smCbAShJViqpfKC20FqWdBOHstLXKE4oAGAoB17tJgrl84CfA/UtdsCqVYDq DOzMJLgyBcxMgK2rTI/TvkkGzdPwe4vwSjmYSgPRVBXRZBW21kiiDCyZwGxZ kcrx+RSZK3a87BnbzvzPH5y2GbVTvnTnH370M/7NS590iKOwyCZayZFZ/mtn rR9dvGnJy1TOfwV52leeLPOkkqWf4r/lQXFgNKMhCRLgByVJqzRcRq00B8qE uxJiubx+lPZFi2kRg7m9Lo3bExGeD8oXobp6QaV+UM8iUL4AGGcvE7ddV3zN noZXyMEr5qACDxxGYGuhSzmoQCe8oCTRYblP+frLH7pnW9gB7nGUj9+x2fzG xecesM1oKYxZpjXO6FrV/Xqd99c7G1biq0olYak4ch+HqwAl2ah2AGa8/hha TKm2nM26mqWSkaid7hh/dyuYqf08NJsmJ5DWYD8AFbug+5aAuvqE+hhJ6CtT jZEkLBR0zoPXlQdpBXgaKtCZ0qPkWlc2p6r/+eH7dx7oAPc4yz/+5L7oN87f uIejqKzz6ik67w353UFR5XxQFrixxo0B2wJeJGGjJKqfZNFUGxYpA+A58EuU wSQfrXUFnDQLIz3W+URHfwFTWyElKVCQg+pdBOruA5QHshZswgT0JMmU2KzQ +QC6qwjl+RLL5qzWJQDVD/1s6/90gHsC5BObH2q+/bz1I7m+4GkEfpYJDfnd OajAl4ySSp0rSvP7FCcDkvwpzfL/LG5rsiRTK7E8k5WjozTzLDbwUeDN2MDy eUosZEoATekMSTW254FK3VClXqhc0dn1Yf1oCgQBKshBFQsg7WK5HEWp4if0 vW5L/dP/1JiMOsA9AfIXb7lC5RcVXmItPzmsNhHVQ/jdeSjfazUXlErDWImN mzUP6JEHVtiRZx3uCG053xatfrSKbbOFidqOEB1MbYVqbXZ3ch6tnT1c6gEK 3UDYAKIo07OBQYEPFQRuRfI8kOc57oS1IEU6WNXzgw/fs/207IzjnXYXnNNd 5HuXeqUcZkam0RyvYGr7QfSsL8Pv1s4OJAkjkcRBYR14LYNhj4Zqu8mb7dih tDtPrAI5Trva1AyJqxYSnZkloGcKexTJNcQvKYl6xH4jAVaBlAWzAhQjtYA5 5T+wc7gckTwPpT1QsRt2/BB4bASoVR2NR2vAc+X35DOU2M5mega2Wiv6/T1P N8w/auzewsrzTX7FWu4A9zgJG7uYPD7Xy2t0repFZf8UGocmMcWM7vXL4fd7 SdM5F+aKg/tGaCyUhMISZRnnYpXYiUoSCETp/6QkR6tS+1ecvZTdZVu1aYsT lzEbIARxJba1UCIpS9Zjm8SQKWPJZvluBBbwimmwuAyUemCOHALGD4GUA2pM u4yvxOvuhvG8HFTXUOWhzbfrXK5mrZ2sHdg1rTx/mrQ3HSxaajrA/QXJyJ++ kmy1cb7KeQEsw8/76DqjHzN7J9A4NAUbWXSftRK5xb2upFy0LZEFWwLYIOvX J0kCBZCSrBepjEWhWioSQKJR4wSFOhrAiPmwMZOrxXrgpM6MbOoTAgAsuetw vLS2OHEavyXWLcVChEjAy04L5wvQS5eDu3qByjQQ1Y6uygBDI09EXtkcPniW GlxWBxETUZ1J1UipSnPy8GGl/f1Q6pBX7LId4D6WZMRMhWDNxV5vIUmRenkf 3WuWYGr7ITSPTGPyvl3oPXcNckt6QUYIKCZmTikwmTT5QNwKYEmUOWXHDszK 1X7F3j8RA5bSpEQM7qTVAWcAzWn4jdEaKFZZ8Aq0bEpddCnoWfxFHWvgNJjr XvdSzjoDVCwBQQnUqMPOjIG4hpTX7swOCuu56P6fPOQtecFegAYYWAqgZIEu ApYyaKNSQcU0ajtIeztJ6xqRsh3gPkKhyBDXG5tsvQnKec4UsAwv56F34zJM bT2IxuFpTPxsG3rOX4vC4CLJiMXsKSN+i3GVtko7jaycxkvWZPk74RwoSstq SIl2zfQHI5VoXmTrx5iOtpvjyshY8yYJihjAbrJRsrirWYMdaVxCZ173Ms9Z EjAeSPvgyjioNikmkgb5AFvbT4e2e91nXbQFwJbK9vsVrOmDCcsglC3QA3Av cXARSJ1FpLYx824AE0TEHeAuUKofvRHF33nuRlttQHcX0nZFiqE9B97pXR6q e49g4qdbYM45E12ry0k4LE6Zoi3k77DHwlXgFFxKA2SkYLLdUROerEo5sQzl eoslwITUoVHatSaxh9MHIcMFV7H1qqSDjqSiMwBuddg4S6dw3GMwCB7IKHFG A6BrMeDlgMo4UJ8Rh832kfUWxectrT3XAjgC4Eh9ZPeDMKafQWUAZwC82ILP I/JXEaktzLydiE5aKE2d6mCtj+wmU68pZu454/ChjWxoma00HLWPWUpiXIBd eRo9Z5ZRWj0A2wgxde82TG7ZA9NoCgHFpMebTG9aeR3WZB629WEMEEUJQSb5 XKY0B2zSjjNx07qWjuUp26u9lCcFc1pjxkpJuY6W+jJKqJiucFI75yumZyr5 W7KJ8IQdJ6Ew5EugnqWgYj/geyBf++Tp/u/NEhPMl8+wuaUrDoP5frb2BxyF P+dmI+Sw2cvWXAjgHGb2Ohq3TQ7f8i3f6+3LcxQus1FztQqC/nD8cDcA31Zq sPUmKPBBSgBnlHOstEbP2mWA1qjsHMX0vdthGyF6zl4Dr5AXe9ZzlQJJVEol /RJIcRKidT27MrRHZIokk9dj8nhWEzvSOif9QFKOr1DGEo3M1JYuTmzgWJGn kQ1SGnEfBafHZdlvSWcwCNqNhfFSsyK2bQFQrH2nx4BGtGj1W1/o4Z9vmJW3 ECwpM4CZcGLsHhuFoQI/Ccw+PP9cUmoMrq9FB7h7PvN3XbqrZ9A2aitto7Ay mpnMgygkoolo/15CFDEzw0xWoUt5p1mMY3WRNQ4QWqPnzGXQ+RymH96HmQd2 IqrU0XveOgS9Pc7WZRcPTcrPFYOUdpW6BJAWABpOQ2TZzBuzA6tSmWVfpd1p SDmQsZgolh0IkwqJ1AZmUm3ZOk4dPpuaGe7w2AZWAkorZkWbzeuyFK02MWXj wl0AaSiV6+49R2kA8xJu/L4l3Dw8+qC19gyydoli9qG9VTZsjio/sE9Y4G75 y+uKKpc/N6rW1kB7i0l7PkAVADtJe7t1d+/YzA1fOIejkEEa5vAU7KJuKK0d aA07+qJQGYkIpWWLofM5TN63A7U9I4iqdfRdsBGFgcWAjp0rKdmKPW4BYtJu KY7f8izghQLX6+BmE5TLg/J5cdxUxplL7WsYAbXKkH2Yjo7/zpZhE83rSnWk T69SaTwXypUlJXRKlZCGkigC0kY87u8CYFA0hYVlUIPFg7Y+sntGWX/AMoM8 308Zd08g4N71yueRLuY93du1KZqaebIu2S4QMYFnCPgZaW+LLhQrpjIdBj2L edfbn+trYwmKwI0Q0dgk/HzgMk1khP1lQWQcMJRCYVEP9JPPxpHNWxEensDh 2+5B30Vno7RyEPDS+C10ppkHuYJKluLHuEmH075WogiM6MgRmIlxhwat4JWX Q/f1Sz1bHCZTqQdGkoY2nPYlUxkvjV34LO3B0BZPSIIMEus1ovFZzAatUnOA /JaohQO1zoBYIO55HuuFZf4rW+/N22ZjKVtLyu3vNkpK8xMKuHe8aEhxZFay MU+31foqMAwIh0F0P4Cfr/nNP6ke9aHIGBibcGjDg5PQfV1Aj4YiI0ATEDMl jeGCUh5LLjkbE/fvQn3/IRz50WZE561H9/rV0PmcgNJhkiV+y1IUxsSiGeNq WwJHDYSjo7DTk5msmkK0fx9UoQgKgrRwkjNxWbKpJo4N3JYoBGUa6FFbq9NM nzIid26F1N5uy7ARuwhJkiaG16px43N52ir/2DCY3HxbzkbhJYrQBWay4P1k ov358hlPHODePnSZ5mrjEpP3LwNRD1ueAeFuAPec+8FPjc8Zx52oTHOOmIzk 90Mg3D+OIJ+DVQpkLEAuO8baOltWu2Xa830sOm8tprqLmHloN6bueRjhZBW9 m9Yh6OlKa9BYpYWMkgJ2HRstQBqm0UQ4sh92ZsaxupQSLe+0oJ2cgF4y4Mrg W2K/3NqNJsmypbxdjsNlSrWnupJgbxrG4zQC0RYqAynAatczV6d8iTRtnIJc 53I1v6s0r406fsf3ejiKLmRqrLVsFTGPKvDdhdVnVZ8wUYVbNp1P0Uz9WSrn XUqEAMxjIHybiHZf8Kl/nzcuSFqFkF4DiBzXwEzMIDo0Bb/cLzHPuDRHHDUY uUOA0ho9Zy6HXypgYvPDqO3ch2hyGr0XnIVieUmijuLtnYhbkw62XkNz3z7Y atWV0iglpB6VEHpsZQZ60aKjQJlUWyT9wVRiw7JQL51il++nTOOR2Gywadw5 3RSFUs5DvKsPeTKRbBpliM0FnfkbDPJ0FRqzAvfQ/35Vkx9ssGFzkwL3Wdfg abtS6q7i+vOnnlgJCLYXcZMutYhyxDwBa79JRHsu+Y/vHnPJMX1do/rIhE28 64jBHCHcNwZVykP36gSsTrM4jetuvnFaUGkUBxfBu/xJGN/8MMIjUzh822aE 561H95krHbdXmoiwZUdUIYat1dDYsxdcr2dirKKNlYDRWlfNa0wCPBaqolva M8mNtgyaOy4u1HTZvcQkQIZUzi29+49uGKk0iL2M2REbHpyGzrImSRhNHL73 wURh7PviPyjy/EAFuaUcRReBaEDmzIxi3AOih7ufdPlJL/k5ocAdPnNjF4f2 AlguANrA8j0M7HnK8B0LspOoUpuC5SqMKba0V66FaO4YQbB+JXR3UZwXkwEs UuaxmAFBdwGLLz4bkw/vQW33CCbufgDhVBW9Z62B310UXDGYCaYyjXDvPtha VSqD40SAaOM4ARD3YoiipFVTmiLmNns21pay1EtLUbKZqg1QUrnAnNbJtdQx cFsimAiSz209JGMmIILQHS0oFxze8Kf/YHZ/6oMead3PJhokpddzFC2XfOA4 gD0A7ut/+gsmTpUo1InVuIZ7mE0vrCIwmhzZQ0+/e/OCjXuaqVkGdhBjietF ALDnNv2wk1U0tx9AsHY5dHdJbpLcPM7cPEq3dPLyAfrOWYOgtwuT9+9A5aHt CCen0XvOWhTKSwBiRGMTiA4cADcbzg6OTYOEtG7FPnbFmSzZtaTal9itDnEo DUga1aUZCE4IO6wy5TxCoYwrLDiJCLTt5scZaJKX2LwsHc2zh1A8gyOANU+b ah07Pvae820YrlTAEhD1WgqhgEMgPMxEexpTM2OrXvvrpxRX94QClw1HZGHY 9ZLNwdCiR3YCZgAPwfClSHxsm9h4dmIGzW37E/DGFbGsKWmRy4pb9iRTWqFr 1VJ43UVM/HwrmiNjODI1g9KG1SiUcrCHD8vSLyaBirNaUspOSl6XaIcx7hED VykJswmIFSXhsKOcNQGw40BQ6nMlnF+VDAOhrchSCA+kc+67rDOLkkN00sAM 1kaIqlWEU9Nh9cDoJjZRFwiaQREYuwG6j5U+gCiqD77iLaccpfHEa1zGEWbe SeABZtLQ6sKb1569B0Q7rtz2wLFnNBNg7T2OdB0bacq11xQNbMen0XxoN4K1 K6D6ul2TEKSUAdKZ1rmWJdevke/rweJLzsXkfdtR33sQ48N3odKVQ/eKRfAK OZehk33QXBIh5g64PgxxNIAj2Vw6abEYmwQqWfIpm2WLaZCU6ZZDShJznKmf UxmHk9JO57GpwORqy5SW3mgaMBGsNa59aqOOaHoG0cw0bK3mtHdopqNqbYKN GQeww4IeVkqNn3HN756SYD1pwH3W/q3R95etu5UtdRPzuYBdykq9jBTfdvP6 s++/cuuD0/N93uYDpnrzTmoaZw9qm4Z5JIwFTbDTNTTu3wlvxQD0kj5nOgSU tP+MebbQygFJAyALbS26l/SARw+hVm+iPlWDma6juGoRCv1daYdyss4WTXqP 2dSMEIJO0kshBmQmRew0asbGNZlSdZJMWmJFxHTJjA17VK2RVPAqH6bRhKnX YWo12FoFplqFqVRgmw0Qu4mqcwWofA4Atk/v3Ptl02ju3vjuD51WRZMnpQXT 95et6wFwKRRdTory0NQkrQ5Aq/tJ0z3PfOC+OQG8+wUXroGxPwZhAFq5BsaZ Dt0JoUU7WqIq5qC6S9CLeqB6SlCFAijnWjOBXeWrrTZgp2Zgq1Vwo+k27as2 MbN/EmG1AeVr5Ad60LW8HzoXuMWBFjYAACAASURBVEgFpWwtQuqs6cUDCDZu yPR3oJYGzNmWpMjasi2vZ96LqZMJ+SYO+QE2jGCqNZhKFabWAIcM2wydgxiG ieZXngevuwdeVze8gtSoKQrZmo/lNz3393AayknrHfb9Zes0QMtBeCYpWgOP fNKKyVMNeGoHaXU/ebSbfN0gX0Xkeeby4dt599UXLoYxnwXzCxzVT2VayTuw ZvdNgFauylUKB0kraYCXlrFztl2SjhvguQbJ0yNTaIxX3X4RpQA9Zw4g6CpA aS39aSk5DykFPbAUwYb1rYBUWQBniDbZluM0W6k8JfYxRxGiag1RtYpopoJo esZ1kYwpFX4Oygsc1VFp6FIXgr5+B9hiwX2XS9O6lcHYKRs235rf9OyvdID7 aEG8Yv0qUnQ+NK0irfrJUyV4isjXNeWrA+TrfeTrEQq8qXxem77m9LXUDN/l Uv8OmKwFQPHeCEQOpKJ9Y1AmGlll3lMZjSjAJa0S6mF1oobqwWmYegTyFEor +lEc6IHO+SkoBZB66VLkNm5odb5UpkGJoqTJM0tTvJSfa2EjA9towDQaMLWG 06bVKrjZTDQ3KQXyPei8W/J1Vw+83n54XT3wu7rhlbqgfD9pPcpxv2B2HGTX TMTuCyvTl5cuuHpPB7iPNc57xsZuaCqTokHy1HJ4qky+WqwCrSnQlgK/pgJv qqjt2XkTvlUp5EiRUGMpaTCXhJPYiK8Ta2OVaGPKAjUBcgbEif1KIAWEDYPq oRnUj1QArRD0FVEq9yHfV0z6OTAAtXgJ/HVrXWdEk5LWbRRJO/1I3pPWn6GB DSPYZhMcNh1BPjMRSBFUEEB3d8Pr6oIuFaG7itCFAnQuD10swF+0FCqXd90k kwaASJoAMrfv0G4BE30rWPf0F+M0lVOKjzu0e8s0gOmb1529FZbzsJyD5SJH djmDliuOBi3z4kbOa2hShxRhpdIeyHcNL5QfPzTI90Gedg9p0USedtmpRLPS 0VNYgArpnRtHHXylUFgH1KbrmNz8AJpHKogqDVSKubRNLgOq+zD03jHJvkma ldM0MmSXSHdeSlYAUgoUBPAX9cLr6YLuKsHv6oJXKkDl8/I7PChPqhxiTV7s AgW5tEslZ6riJWyX7V/ivo/YRvgiTmM5JSsgrtz2IAOoyWPiBxddcICY7wYz gaGbTP19pjlAxv4ye55m4wG+LLWc8lFVzJpSGgh8IPBBfgDlyw45nvTLFQ2X dHSMCxez8VN57i8l5JcuwfjmB1DfvR/N8UrGPiZopUHVmpgqGqw1yNdQMglU PgddLMArFqCLBac5i3nnNOVybS2ksi2lkFybc7oAeD5UroCE6xXveJlllVG6 fatLO1uwwQFrzXc6wD3O8oyfbs5uEGYAjO55yaWf5cPVl4LRFwOPfQ34ngOp 74F9B1Yb+KDAAwUBOPBhfR8UOACTp8WRa3XYjuqpgLR5niagf8MqTHOI6t5R mHrkqt89heKKJShu2gAVBK4tlO9DBb5bCYKg1d4las2mxRuryH4kJCQZNrFp Y1OWmKegC6WY/wG0tFHN0BaTymVytq17+4sqCKY7wD0Zxvmqvlt4qnYP18Nn xuVg1Ixca/lGmEQZWMjcnN2hUWvA11JsmLFvdVqU2AoupFqZKFl2CznAW9mP 6lgFjYkabNOgcWQahcggN9CVmANJijjuRB6H0qAc9VGlapLjY1m1lANxhpRD WkEVSm67AGtTk4dtS+untFNPTNIgEHicib9hGrXTupW+Pl0v/EN3bjfvuGDN jD1SfSURWnrcU0t3xex+uEiNUes2HoGxbiMS49rNI4qAMBInKkpTuFLpy9ak LfEBaE3Ideeh8x6iaghTa6IxOY2w3oDfU3ImQmLfZri0nCmOjCmU8ZoS794e X2uyH7B7UeWL0F09LaZAAk7O7AecCarFf7O1/83G/Gth3TNrHeCeJHn7isFd 0Ux4lTnSWJX2MUhvcKJogKSbdwKGJGXMKcvMWnBoYBoGptqEqYsGR6YSlzOf SzrDEPy8j6A37wiESiGcmELtwBgoF0DnA+d8MbcCMbPrTgIym6F5Z/cEjr8r l4fX15+QZ+bKrbc4nXG9mbVTUa3x4fyZV9yB01y803rWDXTVTGQ+HI03nhzt reeooKALChQoaF+BAg0VKChfupbDAFaWabaJA2aMgY0sTCOCqUWw9QgxQZs0 Qffk4C8qwe/JZ4g2Cqw4Q75R8JRCz7I+2CVLUBufRmP0CCZ+ch9qK5aia80K FJb0O7ILK+ETuMoJZDgJ2XKflO/gbCFVKMLr6XPfHfdjiHuXcXsTXm7Rxszg +sTUgfv++pPTNwLBc4Hm6XzvT/uNibe87PKBaNvYv/C+6kuTpVM8fPIJ5JEL l+WU2w9BkhEMcrFUw8nOOGzRatNm9tBVnkawrAtBXzHT+Ty2mymJCZPvIzhn A6irhOrBI5h+eA9sowlVLKCwfAA968+AVypKdYRqidei5bVMJk0pqHwe3pIB UC7naJIUGwFtfX+pNfOWtEY1trnzhps/t+dX37+bBnr/F8AdVx3abk9bpXW6 A/djD+2t/s75a+pcbV6Fui0l4GW4ComIXQ6/bmBqBqZqYGoRTCWCrRlw0+0p xnHD5vYVl1MurK00oUsBlG6rxM1uJmIMqKcHXm83gp4u5JcuggkNzEwVzcMT qI2MAbLZCGXolmCb9iKLTZt4c5QggL94idulJ7aTk7BfVg1lgy+ZPdgIgDGf ffBPPvYJnmluBGEdgJHrq+NjHeCeRHn3bz9vW2PHofU83rgw6cGZ2RAa3L64 tFYSUNZxi6P1LQ2eKXHa2Vj4pVwG3PHewKlzRYEP1dvlSDe+j+LSRdClAjgy CCdnUN93EM3pGSjPh8r5LusnoE3sYDm3yufhDQxA5fMttiu1zJg0htvSjze2 +a3dwlH0tt0f++oWNCIPwBkAzrym1L/7+ur41Ol4zwmPE3n4FU87I9py6Aa7 p7qplSKY+aUxOVujdfsnTUmrT7e5dDYEhpYlmHyNwooeeKWglTij0nAZFYsI LjgHqpDLxIYVTDNC/fAEZrbvQzRThcoFyJWXoLR6OfJL+jMpZve/7umGv3QA FOTld7SxxmKnsn0Xobjw0iF3mg1fx6H5bG71M6KbBtaWALwcwFkAtgH4j6sO bZ/sAPdk2rtXX/qc6KGxb/CRZgnZJnLZkFGchdJJ+vMo8EK4Dy3HxzFUBfiL Cigs6ZIYcab+LGObBudthF68SEg86W5AIIIJI8zsOYjKrv1gY6ByAfLlJeje sBp+VxHwPHh9vfCXLgX5Hlo2giDV+nd7x5tMlx0iGLb286bZvDa/5llJwuGm gbWLAPwqgH4AwwBuvurQ9tMqrqsfT8C97qK1+8HW2Knm0xGxbp2eWV5C2y46 oKT0uyX+Ge+G094aiQFd8DO75WTf42QjaW9xb2a5To9TWiG/qAe5gX5YY2Gq dTTHxlHbdxBMQLBsKfIryiBf4WhDti3cNVcozPVZ2myb0bX5Nc8ayR5xfXW8 dk2p/wiAcwGsArD7+ur4eAe4J0k+ev/u6LqL1z1oTbQaU81zwS196Y/aLK/1 ZWpxspKAvXQXz8b02TB0zoP2VGrnirOWJD9qDVBvN1QuSE8qAI7juDoXoDDQ B18akphGA83KNMJaDdZa6MCHzgetAVmeJU47K355Dxvz9tzqoZ/O9vY1pf4p AAUAawEMXFPqf+D66vhpo3UfV6ZCYu++9LLV4cNjX7L7ak+N98BLQlvZJTW2 eQkZjkImjKTJTW2NdGMRiYL5fXnk+gqOxK4yfcJUthqiD/65awHPS7ZsJZWp cohplL4Pb3ARjCJMPrQDtV17HaGnvw/FNavQs2Et/O5uHL0vG6V2b8tmajTO lt8WVutfL539gjlDXjcNrC0DeDWAATEXvtsB7skG7yuv2Bj+fOTf7Wj93KxS TR2uzHNFGcpfZlhiuzUGL6UtRVWgUBjscjRDIbS3OmsK5GvotavgLR9ICeoZ GiM8Dd3bhdwZg1DFHECupq16cByTP38IzUOHwcZCFQvo2rgePRvWwSvmQdpD a1tzuVb39xQYf2Ii+4n82uccM8lw08Da5wO4AsAEgM9ddWj7wY6pcBLlnetX HuFA/QhhdBnXTRktMfl5NtDLOnNx909u3x2SwJahfZWYC9QWz4VUHXC1Dirm HTNMlnnSCrqrAH/5YgTLF4kD5sJqpBSCniK6Vq+Av6gfzAwzNY3qjl2o7NoD YwzI86DjDQkJ2VDcNJj/xkT8kfy65y4oM3ZNqb8GYBOAbgAz15T6d11fHe8A 92TJR7bsxR+/4YrR5tjM3WDzZK5Gy1oC8nR0PDcFL9DCfYj9nbb9OthaeHk/ w1nIOGixNCOgUgOKeahCDrqvBL/ch2BpP3RXrpX3kLGFSRGC3m4Uly9FbnAA qlBAc+wwarv2oLp3P5pTFfn+HKTb4gyAP42a9iOF9c9fcDr3mlL/DIDzAPTJ VN12fXW82QHuSZS/veUBvPuFF+83im9GM7qYq9EKJC0PqSVJQUeBN8OyijNo 3KZ1DaA95TJpQGtbUM7MkjACGjUEq5YgWD0IHVdN2CzZBhnyDSeZOVIEv6uI wuASlM5cBVXIIzx0BI3Rg6jvO4DKnv2I6o2KtfjjmYMTn7rjkl+qf+4RjNH1 1XFcU+o/B8ASAD6AB6+vjp/yXF3CE0S2XX3JoBmb+ajZPfNS27D5JGLQFv6C JCCo3ZlL+hu4piIuSUHw8hqF/rw4ZM7WJU+KMD0FlfNAOSH55H34mzYgWLcK qpRPS3B0WiKUlOTEpUUtSQkNgBDVm5jeuReVnXvRGB07MLNz7Lbp23Y9wJVw Oxib4Xp9VUCoXXVwOx/DxtUA3iphMQbw6asObd/eAe4pJHtfdXlfuG/qOnOg cq0day6xyoGXhRye7BopiYW4gXhL+liliQhogDyFfF8OftFH3OeBPAUEGsrP RBmIQNrtA6xXLIW/cTW88mKokpSOJ7vmqKQaI67MyBJ6EgArbcJ68zu7v3Hz p/b98TeZBoI1cBvsEYBJALsB7AVwEG4LqMmrDm1vtIG2COBiAFcByImp8Omr Dm3f0QHuKSb7fv25+fDBg8/kidp77c7KpWziPRkgtEJhESaZMAdQViTWQxxW EAWpCbrLR7Ck4BIGnk7Da0l1sTDHVCZ0FnjwBpdAryrDX1WG6iqkIE22hFIt FcdJtQbpcfaCD8HPfyq35oUHbiqv82F4EYAyXCp3A4CSTLWq2L9VABV5biSG uxjAoIAWcDvofOmqQ9vHOsA9FTXvm5+jzP6JMlea77K7Jt/Ik1E/DChJ+WbS xUnzOdVmF6us2aDgDxagu4LEXEhitNn4bty4JC4N0uSqkQs5eKtXwD9zOVRP t9sGy0tAmikvUg1o/x7ki+8C0W25DS9vSRjctHQtgeEDyANYDeAc+b+AlKWR vffx/bcC6Buh6KdXjW7jDnBPYal84To19oUfPdfunXwnjzeeyhNRLyxad30k auUraMwKXspp+INFqECnnIWYeKPRymeINXEyMTK1ZINL4K9eDjXQD10qgAp5 kO8beP6DCILPcan/44UNL1kwo+umgbU+gGUAlosp0ScaNo5mNwGMArjnqkPb 93YSEKeRHPi/r+xr3rXzRXam+Toeqz6PRxp+mmnLgFcBRzHPVFopoUoa/qI8 KNAtO0Qm5kJG06avq8z5UzYb5XPQ5QF4a1c9EKw740tU6vpa/uI33v+L+L03 DazNifZlEDWuOrjttCOUd4ArMva3b6bqj7cuhu892R6uvs3uPPICHqkFrj3M HODNpoYVQB5BFTX8/pyzd7OtneL2ULEJojMApqwNTAxPR7Sof6saGPgEafVt b9PZu3pfdF2zc5c6wJ1TRt/7RgoPVQLS+qxo3+E3m4dHrsZEY4Aj20PVyGtJ YChKCTnCayCPoHIKXl8OKqdaTQTp8sjZFLMmKZVX0+QHk7S49261fPCz3hkr v2PGJ2uLf+NvTOeudID7iOXI1/6yv/K9u59p9h6+gierm9A0a2HsGXy4UsRk oxW8RIBPIA8gX8HrDaAK4lwRUq2qFVDMMbTeC0/vpEJ+K/UWf6RXL7958Tv+ fktn1DvA/YXKwY++Y3Hjvp0reaK6DL5eg2a4kWcaa2CilVxtLEY+txTVRhGa FGmX+lWeangF7zAF3gQU7UHg7abA3wZjtqCQO6CXLdnvv/iZ+3oveUtHs3aA e/xl/N//Sjfu2RZEe8Z8rtV8O1HRKOQ1pisq0azWAgD7pcBQITDkqwg9pVAt H2gO/MEnw84odqQjHelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQj HelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQjHelIRzry2OW4FksO D5bVPN9hh0ZH+GScc3iwTMf47bzQaxseLB+PHsM82zXIdavHeu6h0RG7wN8W f58H1xyvC67P2BSIDsqGwo/qPj5W8Y4jaPMAPgy3l1a7GACfA3DDIzpneVkJ zB+D60Q4283+RwA3L+BUlwG4fB7w7gLwtQX8xhyATx+HcawA+CiAn7W9fg2A 5+GxNeSeGh4sv3dodGTXMe7dagBXA3gJgIvgGuel21YyjwO4C8B/DQ+WbwRw YGh0pHnaA1ekBLery2ySf6TABfOzAfwKXOfsdpkG8EcL1Nh/LgCYS3YND5Zv Gxod2X+M02n5fb/ocZyUidMO3Ivl+x4LcMcA/INMztnGZy3c5n1vgWuWN5cU 4BrpvQTAdgCfGB4sf2ZodOTQiQCuOo7nbgL4+jzvnz88WF7/CM/5ynlu2o1w /V2PJRfB7XkwnywG8MIFXtPxaBiX3U16Ia//Is6N4cHyebJqvfsYoG2XtQDe B+CTw4Pllac1cMWOuh/AfXMcshTA0x+B6bEcwCXzXPNXZbIcS64WYB5rpXjO 8GC58ERxdoYHy4MA/hLAcx6l7+MDeCmAjw4PlntOZ40LAPsA/HCO93oAXC52 4kLkcnEQZpOHAfzsWE6H3JxnIO3APZ/TejFcY+STMYbH02k+yjEV8+n5AP7P PL/HOWXO/p7PdHougF+Rc56eNu7Q6EhleLD8QwCvFaC2y5MBrITbxXs+wHkA njaHowcAt8kkOZZslO9ciKwDcMnwYHnz0OjIXH29DID/Fm3DswBkBYAL5/js NgAPzOOcPdKN8u6Ea9B8LNBOiA3dri3fNs/nDosTeq9M+mcCeAWA4izHdsHt zv4fCzTdTknnDKJx980B3PMBrB8eLG8/Rkhl2TxmwgyAW4dGR6aPAf4AwBDc tkgLXY1eCuArcrPnsuPfNs/nXwng7+ewM28A8Bdz/CaeBVzHko8B+J8F2uQT s9j0F88zOT8K4P1DoyOhjOXXANQAvHkOn+MyUUinL3CHRke2DQ+Wfwa3qUb7 TQoAPBtu6/nGPKc5U5yqucyR2xZwKT0CpNmkMYf58Gy5ARNz/DaeSzPKUjk1 j4NUHRod+UVuEjI5NDryaLczXTZHpCYG+v/EoJXfPT48WP4C3G49g3Pgas3w YPmuhcaMT0WNGztOL5cQWLu8BMD75wLu8GDZFyeue45BvW9odGQhLeYvBHDB HO99GsCvzXLz8gBeI0vk41n0McyLFbO8fheA/zfHSqrEKT9uiYkTBdzvybJx 5izvnSWAGp7js3kAL5tnqf76Aq/hrXO8flCW8wvFAWyX1w0Plj94LFPkNJfR Y4D6ncOD5fuHRkcezGjdaTGjToqcKOBOi7H+zjlm9GvmAe66eeyvIwC+tYBQ z5kAnjXH2/8DYD+Ab8wB3BUSQvvqaRDSOmY0Yg5f4hBcEmHDHPfnMgBfGx4s fxzAF+V+mpOR6j1R4bDsYH0ZQDTHIVcPD5a753jvl+aZYN+Yx47MyivnWNIs gG/LOX4AYLZtwwPMnf07leQ88fbne1wyR2y6KYCcT+tuEgfwHgDvhQtlLjtO XI1TA7giWwH8eI73Fosj1K5BcuLZz+U0fOlYs354sNwF4AUCwHZ5CMDPxYHY KSGl2cboQskqncryPlm15nt8Hi5N265YIgD/BuDuBeBlJYD/C+C7cr53DQ+W L5WQ5eMSuDNwMc/ZpCjgapfL4TZHnk3uxtxx0KxcKnb0bMvoT2WJBIARmViz xWxXArjycWDLRvO8t0MAudANqAtifr0PwJfg0r1nPe6AK8yh2+cIH2kAF8yS 534hZg9yQ2zbY8VuPYlILJ9jIt0yNDpSzZgzt4i9N5uD+MzhwfKix6t3JqvO TeJv3A639y8vEENr4ZhrNw4Pll9+IswHdYLH54F5QkvrsuEqAcllmD2+OA6X dGgc4/uWwsUaZ9O2YwC+3/ba7QD2zHGuZ8BR/U5noWOBd2h05CdwfIXflWjQ yALPrWV1/EcALzne4FUneFaPALgDwGw7ziwR5yG2RS+QmTyb3ANH4DmWh71e wN8uDMdt2NJ2fdNys2ZbUpcBuPJE23KPUCn88BiPuwDUF3CfKkOjI/8kjvE1 4ozdfgxTI5ZBONromsdDOCwr/wsX7B+Y5b0r4XidYxICm22JDwH8eAFcWQ9z Jz2MRDlmky8DuG6OsXk9gH9e4A080fJBGdtj2biHH4GimQDwv8OD5WHRpBsB /LIAumceDX6BaN2/F8fvcQHcH8pyPBtwLxOwRrI0zzYwk1hYTr57njDWYQDf meO9ewFsnkNTPxku9XzrKQjcIwuYzI/FP9k/PFg+IPfvQ3DZzhdi7lTxCwF8 8nhN8hMO3KHRkVBIGhfOYqoU4IL9/425ubq7sTBuwksAlOd47z/FOcMc2vgL cwBXwVUGnIrAfdQyXF7mg7k8h6JgAKNDoyNNcWBDAA8MD5bfKtGEZ83xuXPx 2Co1TinnLJavzGNrvVpMhtnI3hbAfw2NjtTmvRFnrCYAb5xnKfvqHGGvOLrw XczNCLvqRLH8T6B0i4n01VkeX5ptEkuJzn/Po1GXHE98nSzg7p3Fo4/lfMye GgZchucLxzx7o3GpzPjZgLsZwEPHSFyMYO4U9GIAL35cwZa5LhGTp8zyuAyO Tz3Xij2XcpjE44BkM5uD9RUAL5ojrHLmXMpUTIVjyQsxN+n8pgU4KFMSXXjZ LDemCOD5w4Pl64+l+U+wLJLypmOJBXA4S1MUrTkszudsyu2Vw4Pl7wO4YWh0 pCJRmzXi/M5lDjw416p22gJ3aHTEDg+W7xAQnvEIPvplzB5Ky4bB5ivPmQJw W5x0mOf6zPBg+W65vvbYLcmqcB5mTxGfLLlOPP5jyQSAP0Rr1UkIx1V4FWZP jS+FY9B9e3iwvANpFcSl82jcb2FhNYCnlcaNl+ObAbxhgcfvAXDHAojJ52Fu 3u02uDTvQuRe0RqzJR3WAnjq8GD57nnKek60XLjA48bQxm0eGh3h4cHybXCk pbkiMUvhYrp2ASbmVgDfPl6hsJNp42JodGQSjpFVX+BHbsYxSkGElPPMORw7 A2Dz0OjItgVe39Q810dijvSdjhbtbLbn0OjIEQAfAPCTY9imx8LMtGjn+4/n j1AneRDvWKDNWodL8U4c47heuErV2aSGBXB32+QGzB02u/IRmjmnvAyNjvwU wNvh4uThozjFGFyM95+O90p0soF7HxbG8NorID+WXArgSfMM6o2P8Po2z6M5 igB+6VGWYc/X/2w+ITz20vV5zzE0OnIXXCebd8CliBcSGYgE7G8B8Fcnwmn1 TvIMN8OD5X+CY4z58xz6EIjuPYaZQBJJuH6Owb5DzJNH6kR+SGxjmsP8mG9J 3gbHc7WzvPeTR7lCFfHYAvvTcJUj8/3uEbkvXxVF8Hy4FPxaAIuQlrnvgOMw fBuOPzJxoqoiCCdZFtA5EVhg98RjnIsfZXfIR33OX/T1LHCs8IsYy3m+lzKT 71GPa0c60pGOdKQjHelIRzrSkY50pCMd6UhHOtKRjnTk8S3UGYKOPBaRquc+ KHV46MD+E5aI8DIXkIOr4rwIjrd6B4CDx5MsIe2RngzH2pqY57gyXIn0UwA8 9bHmwuW3FuF6ytpf0G/Jwe0dMX66ZJKGB8sb4Squ/+bR7JYjGbWXAfhtWPt2 OBroY72mM+B2T/rAfFtaeXJwNxy5+GVwvIECHBHkT4cHy9+V5xpaN2BML4Aw ZsJnvrBXNPjk0OgIDy9bTrC2AKI6mLsBqKHRkfamcmcA+ASAa4YHy3cB8KFU E9b2A2gMjY7MDJeXebJN1DMBvAdAODxYjs/bBaAuBZgFue4JSGv7odGRppBg egFEQ6Mj0zLYr5XBed7wYHmfHG/h0pjxcxvv2yU9ehWImkMjB1i0TC+AytDo SEx7fBVcO6JLhwfLR+AI2SZzjpyMTwNAfP25+Jjh8jIN5l4AtfaJKb8hB6Xq sLZXXp4UHm3LuGcA1QsgglIVWFuQ87K81wdH8u6D69n2D5nP9QAJ7XQ2YHUL biaFyxEXru6T/dFivm6XTGIjr3fL39FweRmBuQDH+ssDyEHriaH9+1i+/2oA H2/DFgBMxb+R5I3Xy418J4i+LwP4DqQbtJ0LR7LwATwVjqjxKTi+agGOef9s Od+tAK4HUQjm98NtLHIFHGv+63CN6iL53nPh9vN6k1zYs+U7LhEAfgRuP4TP wxGZbwXw+wB+A66n68UA/lpu0lvlmB/IwO6EK+a7RlYRgiNKPwxHvXsaXB+C 98BVqhblRj4omvPw0OjIl6Ujy9Uyyf4VrlvLtXCdd8bk2rbJOZ8j3/ERuLKk zUOjI/8hv/UaOJ7w9aIk7pLf+8+iLH4HjsQyKWP07cyNWya/eULGEnDNqON9 5DwAnwXwXzLOvwxHjKnLeGwA8Fcyad4k3zsNx3x7hUy6MRmrIRmrHwC4Pgvg 4cHyi+V4wJFqPgXXTuD1cO32r5HvXwbXjOVOGY83y98/gev4GME1DblLvq8f wI/gejecAeCbcM0Ot8Ix1a6S7/whgE8OjY5UlcyyV8P1Zht5LAAABqlJREFU 0bpxaORANDQ6clgGOA9XLLcObu+rQG7QDBxZuCxf8DoZyE+K1n4NmEtwNLcN cDtM3i6TYy7a4SoAvwdHFv9rGYA/guPR/hBuQ7mvyOu/Jtf8kMzkv8pcWwjg twSsa+B6YX1NburvC8h/CNfG6Xq4yoohAU6fAP4ypK37SSbuFQKUj8P1zP0b uL6674fr3nKbgOEzMjmubvutl8r3lOA4w++S756Qm9kHtyfEjwH89fBgOdsT uEdAcbaM5VbRklfLZx+AI4EPyHe8C65m7tNwZf7Xyji9EK7E5wa4nT0vFpBp uPqxV8tnPgHXmvV1cSul4cHyYri2TLfJuL1IxqQsz7sEYL8s3/0ZuU8fkM98 Uu7F6wRXr5fnXxWF9lbBS0LegavUfp0A+pMyad40PFimmEvah6PLsadkxg7I zbsHjiB8C4C/E4A8Ha7i9Udw3NotctFPF018BK6c/HY4el8Vs7dljwFyH4Bv Do2O/FDAtlau4QHRSrfAUQlnBKx/I8vSMnl+swx8XJ7TkKXrQgHJtXC7NW6T a7ldNIoF8CMQXSugtjiaGhmfZwOADw6Njtws2vpv4cqQtsu1/ihjr7efI/7b yCT7SwHl+QKGg0ib+V02y/34N1l1viTn+qRcx+dl6V8Pt13TdwF8BkTfk1Vi XFayF8n5PyOrzafkmj1RQHfClSxtg+MuXyaAhBx3CK6DpoLr7HgnWisqrIzp fwoYbxXz4IsyWW6QyReIQvq3odGRG+Dq3T4DVysYV5X0yiT8X7me+2VSPx9I ieQPAtjQtufYWjlJvMFeDek+DVUBblE04JNktr5G1H7cZypE2lExks/PF8mY RFpg15zlhnPmuCPiOMa/oS72Tw1puc0eAH8mN+YPAfwBWjfbsJn/DwyNHDDy nNBaNBjvHRzvZ+uKLbVuCmCnM9eXPWeWY5xv+z3xTkOBPK6W8XuVKIltbZO6 nvmNkTwqmbEyojkDub7m0MgBztwryL2qZZp7VDP3tARXr/dquBZL8X0MM8B9 L1x711+RlWbTLBNzKvP7K3I/4r9n5BqVHFsRezqSz/lIucZK/r5Iruc18trt EIeJZeadB+DPhwfLTx0eLL9ILvLHSLsrXgLg9cOD5U1idyyVyMOtcsJvy2NV 22Adr5BbfN4xGZy3SPPl18qyDLG/3gjXxv/34DbcO0eAVoIreJytQ/ceAE8b HizHG55cLQP9M1mZfn14sHw2jHmr2LPL5abk4NqRFgV4Vw4Pls8ZHiw/DbN3 xoGM734B0OfEJDobR3dJXMg4hnLPXgjXu+si+f0DAvRb5fUXDw+Wnyz3sU9A f5N8xw2Z+9jMALsgy/k4gN8W5XEFHhmpPfsbCgDeMDxYfsrwYPnZYgrdn1n5 p2QCB2Lz3ij271hW4/5UbJ+nidr+sCz7fyQgJFkWLhFj+w2yzG2VZWqLLA1f kxt4Y0bbRpnZWEFr55N42TdyfCWjVUN5j2UAq5llaSZznu1iR70IwL/LcnOP DPiorCZfkCXyftEYPxAQflhmdDXW0hIe+7RMhv+QSMEd8v6E2M9PlvNdB+Bf BHxxR8S/kwjI+5FutP0O+b5qRvMY+b4pAL8JV8N2qzgtX0brVrLZcUL7OTLv N+Umf09Mp8/IdT8k4/lV0VgfFafwiEywUCbNw/Kbvy7A+Z84HDo0OjIjy/Z1 goUV8tsa8t2xhs0Wl9ba/q7LayzPd8q1/Ivcxw9ncBOKP7EbrmXW12X8/2to dIRbt8ZctlzB2mUApmVAIcb5r4nH/OsxqOSHZMMk/fIDk5DXcHmZD6IoDkwP l5d5AOzQyAELAMPLVxCs9UjriI0hENTQgQMu4rBsmQJDATAgIjCroZEDLpQC aBCZbMB7uLwsB+ZeaH0I1moALEt/HC8uktaHrnQhFyTnAQwICgzEx8tnAgCL oNRhABbMyJzPB9AHosmhkQPNzDXE57RDIwfscHlZAOZ+AEegFIMZ0NrAGA9K RRL+yQby+0E0PTRyoKWyWM7rAYiGRg64UCNz+reMI7SKhvbt45tXriIOw0UA 6iCqtnx2+QqCMYtBVBHQKQBmaORA/Lk+AdbkbPFoCU8uhivTaQyvWKlgjIJS BtZqEHjogIzTsuWejJvc0+VOOzuM3Sq4+qFo3/Gh0REeXrGSsuMjwYMuAB6U mojv+TGXHwHuW8Xof8sCKm070pFjYWqlOPS/OjQ68t3HlDmbR1iWLfP/x0DD k0lGwYgCX6AjJE8o7eAQU+oy0vJkklEwokpcRuiIwR9yp9wBBiwyY5u0u3MA AAAASUVORK5CYII= --_av-1IhsN3LhtPcJEtrSpj23Jw-- --_av-0P1nAWDENAOY8SsEmzRHsw-- From xen-devel-bounces@lists.xenproject.org Fri Feb 03 16:04:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 16:04:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489245.757584 (Exim 4.92) (envelope-from ) id 1pNyXg-0003GH-0f; Fri, 03 Feb 2023 16:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489245.757584; Fri, 03 Feb 2023 16:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyXf-0003G9-Ts; Fri, 03 Feb 2023 16:03:59 +0000 Received: by outflank-mailman (input) for mailman id 489245; Fri, 03 Feb 2023 16:03:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyXf-0003G0-KF; Fri, 03 Feb 2023 16:03:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyXf-0001PE-Hb; Fri, 03 Feb 2023 16:03:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyXf-00028F-7b; Fri, 03 Feb 2023 16:03:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNyXf-0000Fz-74; Fri, 03 Feb 2023 16:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NvSp6ej0TtjtxEiW9p0iFlIgjrXSJCMVKJdl6drUnlA=; b=JrNW+3FYCU3v6uRLZBag1Dv2D1 gYk1kQ7oUshmhd0LTWcjh7pjGIbOUwwCiNkUozwIjIfnx6EEBvAGpAbUApH59nSV0xTdAEGivkHjm 9jRB2Ev7BNsQb8xkSVz/wjHpmo9m90xIbNY4RpWlMQ07CBwPPkjXvLvOlejSmgD8n3d8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176348: all pass - PUSHED X-Osstest-Versions-This: ovmf=13b97736c876919b9786055829caaa4fa46984b7 X-Osstest-Versions-That: ovmf=11f0014c0e3046e3762eac420b760091d0cdc063 From: osstest service owner Date: Fri, 03 Feb 2023 16:03:59 +0000 flight 176348 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176348/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 13b97736c876919b9786055829caaa4fa46984b7 baseline version: ovmf 11f0014c0e3046e3762eac420b760091d0cdc063 Last test of basis 176346 2023-02-03 08:11:24 Z 0 days Testing same since 176348 2023-02-03 14:13:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Eric Dong Gerd Hoffmann Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 11f0014c0e..13b97736c8 13b97736c876919b9786055829caaa4fa46984b7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 03 16:25:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 16:25:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489253.757594 (Exim 4.92) (envelope-from ) id 1pNysf-00067P-QP; Fri, 03 Feb 2023 16:25:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489253.757594; Fri, 03 Feb 2023 16:25:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNysf-00067I-Nb; Fri, 03 Feb 2023 16:25:41 +0000 Received: by outflank-mailman (input) for mailman id 489253; Fri, 03 Feb 2023 16:25:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNyse-00066t-I4 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 16:25:40 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64ca80e7-a3df-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 17:25:38 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id q5so5180693wrv.0 for ; Fri, 03 Feb 2023 08:25:38 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id t6-20020adfa2c6000000b002be063f6820sm2434117wra.81.2023.02.03.08.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 08:25:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64ca80e7-a3df-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BrZkd8Gb1stEJ2yXCGv4hyM19hEmdyJWbEeYNYITO5U=; b=Uc4UDdIAVtU0GnrCHb6EZFjF3S+WBAtUCEziykw72hKMygS/hKu/D0+A5VN123b/tM Sjw6XAYy8gcLAJJrIV0BgKrJx5o3hrAJBcntaIXpcRAx0DmmFMLE6fdgy4Dw3Amjtwyk WqkVwgl2yBt79+dFc4s4UfdNkCBMpZ9TqQoKJ3kkqh11QCuQN1bFxdTVBmkx4wKtzk/d RzALZEZbyryey2hgWk/Akn9wKZmExChcvHIUDmCV8h/3Upgd7ItD4jeSzTG258eGdqgP FZz2CiyD0XuQ8Rn2S5yMs8jm3B4ZTRSMcjAPAiL7qs9lnrzMDXNYOdDoPgiePLPQGNjR iQFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BrZkd8Gb1stEJ2yXCGv4hyM19hEmdyJWbEeYNYITO5U=; b=vHHXPk/+bw7AuNZvlM59o3HQj9sOgVSZgQeWpnPhT1/RalHKfq4rDo6VvRxH+GKO2s Qx9geLTwkx2N2ZWMnI4sUJ0UsPhGkEHI2YFBaJnBV0qIy8Ge2vTrQispM3Whr7B8n/zU jgXKgDnQDtZv9xXAGvLBDTjFRgt1VeaBDeCw3PPtNDmwYew7Tvl/kB6WpkT03C4yheTF pw5R0uFTeVD2kuEgOxyo03r2e40Nxzby0MCbcMfeeTlJ/0UkjiAQ7E8JB7AmHUIot1MF 2X94USdUnz5Fk4Sg2A05ERFjQQgdCwwfVDqfrw4F6AHDPT2iOO+80W1cwmm/NOwz3z5l mcTA== X-Gm-Message-State: AO0yUKU3VEBhKmct9ntBOiuRzZhdUVoBov5QomJmsYt3W8JddNjVzefa JkvNqlkC7/s4QZ310EhgkCU= X-Google-Smtp-Source: AK7set8cSH/bVDGRatdPhgkQW1wN++2K3oYsczmSVhz1J8cLjBH9ksLVg/Wh0M1Bthlo0d92TPbsRA== X-Received: by 2002:adf:d231:0:b0:2c3:d3be:a607 with SMTP id k17-20020adfd231000000b002c3d3bea607mr2247909wrh.35.1675441537846; Fri, 03 Feb 2023 08:25:37 -0800 (PST) Message-ID: <73d9a10bbb0451aec55b486aa5452bc3e196201f.camel@gmail.com> Subject: Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Fri, 03 Feb 2023 18:25:35 +0200 In-Reply-To: References: <06c06dde5ee635c6d1ebf66a8cff9e7e1f4fbf5c.1674818705.git.oleksii.kurochko@gmail.com> <73553bcf-9688-c187-a9cb-c12806484893@xen.org> <2c4d490bde4f04f956e481257ddc7129c312abb6.camel@gmail.com> <873d4754-0314-0022-96a9-e54ed78ac6ef@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-03 at 13:23 +0000, Julien Grall wrote: >=20 >=20 > On 03/02/2023 13:15, Oleksii wrote: > > Hi Julien, >=20 > Hi Oleksii, >=20 > > On Wed, 2023-02-01 at 22:11 +0000, Julien Grall wrote: > > I am trying to introduce GENERIC_BUG_FRAME config ( only for ARM > > now as > > some stuff isn't available now for RISC-V such as > > find_text_region(), > > printk() and so on... Thereby I will switch to do_bug_frame() to > > generic one a little bit later for RISCV ) so I added the following > > to > > Kconfig: > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0 config GENERIC_DO_BUG_FRAME > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool "Generic implement= ation of do_bug_frame()" > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default y if ARM > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default n > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... > >=20 > > But when I pushed the commit to GitLab all ARM randconfig jobs > > failed > > because they decided not to set GENERIC_BUG_FRAME=3Dy. > > Could you please give me a suggestion how I can work around this > > problem? ( I thought that it would be enough to use default y but > > randconfig can override it ). >=20 > You don't want to allow the user to deselect GENERIC_DO_BUG_FRAME. So > you want config ARM to select it: >=20 > (arch/arm/Kconfig) > config ARM > =C2=A0=C2=A0=C2=A0 ... > =C2=A0=C2=A0=C2=A0 select GENERIC_DO_BUG_FRAME >=20 >=20 > (common/Kconfig) > config GENERIC_DO_BUG_FRAME > =C2=A0=C2=A0=C2=A0 bool >=20 > > Or is it needed to provide an empty implementation for > > do_bug_frame() > > GENERIC_BUG_FRAME=3Dn? > > Also I thought about weak function as an option... > >=20 > > Here is pipeline for generic bug frame feature and the patch ( of > > course not ready for upstream but at least it shows an idea ): > > =C2=A0 * > > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/766581174 > > =C2=A0 * > > https://gitlab.com/xen-project/people/olkur/xen/-/commit/6fc6481202852e= 0aa2c2cb3877f2d71ac0213511 > > =C2=A0=20 > > P.S.: Probably you have some comments ( something that is > > unacceptable > > even now ) about the patch. I will happy to hear them too. >=20 > I will try to have a look next week. >=20 Thanks a lot. I think that I'll send separate patch series with generic bug.h stuff today. > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:06:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:06:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489261.757610 (Exim 4.92) (envelope-from ) id 1pNzVf-0002cs-5R; Fri, 03 Feb 2023 17:05:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489261.757610; Fri, 03 Feb 2023 17:05:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVf-0002be-1U; Fri, 03 Feb 2023 17:05:59 +0000 Received: by outflank-mailman (input) for mailman id 489261; Fri, 03 Feb 2023 17:05:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVd-0002ZN-Q5 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:05:57 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0663cefd-a3e5-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 18:05:57 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id m14so5202688wrg.13 for ; Fri, 03 Feb 2023 09:05:57 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002bfe266d710sm2452191wrt.90.2023.02.03.09.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:05:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0663cefd-a3e5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4+ff1E7mX9WhYpbpoBrQzNoWKjRBFV88fd7wUihi2Qc=; b=fyMBwyuNo6g5Xnun+n9KPuzqpdI1HAlf+fhuLWm3WTQydKG+afSiJrUXVMDZHwdYIr S7Acw7HKIRvBgnbOwJLI/CO5PLIynKjHJGCiE98g6M2yIcvzfZXDxjJIT1A970G2WepJ QIpfwg6O3kEpPv4WOZk3A34Pt2CL24cTe4XlgYDJVLVKGifEmdctHXNFYjXHlvvKyw8E BdcdVpFO1b2n/gUXA2Lcicd9fU6ff1DLuso4qC2fUk1dKaRhzH/CESeUBbuD6AmprLEs 2L2mcQmQ+1pkp2poTTuMgcuhF3TEjVffWV3YVvQQlqZrWTFwbsYj3lDcHfOyUk7XsSn1 uP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4+ff1E7mX9WhYpbpoBrQzNoWKjRBFV88fd7wUihi2Qc=; b=BE8k9W2C3h9zFbjXabjbr+kyO85vfEdrR2cW6GGY58F/dUQKkXOR2c5eu1cL4j6UvD /d+OoTIkmmSrFXnOvt2qW2Zg7G14uCTW7hEw/0tf1Z1I21qcHzQTRfNytYHOs70jSCOR aIwxJY2SFtYGhR+NGpIpqC1iO7xob1+bEgQ95Lkjnoe23x/I97PYFtxPWXMlo7xCWTxh zZHzNj424jMpqyRVwADHiQGROuPETd2wdzP0+ZbcnQcPsu9XH1UcIai4ZyfmynnkeA33 ssQYuPV/NGr/VZteXAJGgPpV1B0jKQYj04DQI2fsaZMW5tGRRq9Ac0AvH4NdRUFCRrsL B//g== X-Gm-Message-State: AO0yUKXHpgJEopsDa4UEw2J8r9jrs5XHrDHMPmH3e3oaR3tYGeVjVFvS PLQLOzTlmfp7RDj+N3Msp4WDBaagtgo= X-Google-Smtp-Source: AK7set9hy80yhziTOn3wgFU9CUlgc0skleSvABzW0WPwWlOlvBXOlcTunEo+b4Kwx8atuTza5zwJzg== X-Received: by 2002:a5d:4d47:0:b0:2bf:de97:f3f8 with SMTP id a7-20020a5d4d47000000b002bfde97f3f8mr9230469wru.28.1675443956225; Fri, 03 Feb 2023 09:05:56 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Date: Fri, 3 Feb 2023 19:05:47 +0200 Message-Id: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures, so it was decided to create a new config CONFIG_GENERIC_BUG_FRAME. The version of from ARM was taken as the base version, as it looks the most portable. The patch introduces the following stuff: * common bug.h header * generic implementation of do_bug_frame() * new config CONFIG_GENERIC_BUG_FRAME Signed-off-by: Oleksii Kurochko --- xen/common/Kconfig | 6 ++ xen/common/Makefile | 1 + xen/common/bug.c | 88 +++++++++++++++++++++++++++++ xen/include/xen/bug.h | 127 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 222 insertions(+) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8..811b4eaf3b 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -92,6 +92,12 @@ config STATIC_MEMORY If unsure, say N. +config GENERIC_DO_BUG_FRAME + bool + help + Generic do_bug_frame() function is needed to handle the type of bug + frame and print an information about it. + menu "Speculative hardening" config INDIRECT_THUNK diff --git a/xen/common/Makefile b/xen/common/Makefile index bbd75b4be6..7d04c8d3b2 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_ARGO) += argo.o obj-y += bitmap.o +obj-$(CONFIG_GENERIC_DO_BUG_FRAME) += bug.o obj-$(CONFIG_HYPFS_CONFIG) += config_data.o obj-$(CONFIG_CORE_PARKING) += core_parking.o obj-y += cpu.o diff --git a/xen/common/bug.c b/xen/common/bug.c new file mode 100644 index 0000000000..393e58d571 --- /dev/null +++ b/xen/common/bug.c @@ -0,0 +1,88 @@ +#include +#include +#include +#include +#include +#include + +#include + +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) +{ + const struct bug_frame *bug = NULL; + const char *prefix = "", *filename, *predicate; + unsigned long fixup; + int id = -1, lineno; + const struct virtual_region *region; + + region = find_text_region(pc); + if ( region ) + { + for ( id = 0; id < BUGFRAME_NR; id++ ) + { + const struct bug_frame *b; + unsigned int i; + + for ( i = 0, b = region->frame[id].bugs; + i < region->frame[id].n_bugs; b++, i++ ) + { + if ( ((vaddr_t)bug_loc(b)) == pc ) + { + bug = b; + goto found; + } + } + } + } + found: + if ( !bug ) + return -ENOENT; + + if ( id == BUGFRAME_run_fn ) + { + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; + + fn(regs); + return 0; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_file(bug); + if ( !is_kernel(filename) ) + return -EINVAL; + fixup = strlen(filename); + if ( fixup > 50 ) + { + filename += fixup - 47; + prefix = "..."; + } + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); + show_execution_state(regs); + return 0; + + case BUGFRAME_bug: + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + show_execution_state(regs); + panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + if ( !is_kernel(predicate) ) + predicate = ""; + + printk("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + show_execution_state(regs); + panic("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + } + + return -EINVAL; +} + diff --git a/xen/include/xen/bug.h b/xen/include/xen/bug.h new file mode 100644 index 0000000000..b46dae035e --- /dev/null +++ b/xen/include/xen/bug.h @@ -0,0 +1,127 @@ +#ifndef __XEN_BUG_H__ +#define __XEN_BUG_H__ + +#define BUG_DISP_WIDTH 24 +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) + +#define BUGFRAME_run_fn 0 +#define BUGFRAME_warn 1 +#define BUGFRAME_bug 2 +#define BUGFRAME_assert 3 + +#define BUGFRAME_NR 4 + +#ifndef __ASSEMBLY__ + +#include +#include +#include +#include + +#include + +#ifndef BUG_FRAME_STUFF +struct bug_frame { + signed int loc_disp; /* Relative address to the bug address */ + signed int file_disp; /* Relative address to the filename */ + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ + uint16_t line; /* Line number */ + uint32_t pad0:16; /* Padding for 8-bytes align */ +}; + +#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) +#define bug_file(b) ((const void *)(b) + (b)->file_disp); +#define bug_line(b) ((b)->line) +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) +#endif /* BUG_FRAME_STUFF */ + +#ifndef BUG_FRAME +/* Many versions of GCC doesn't support the asm %c parameter which would + * be preferable to this unpleasantness. We use mergeable string + * sections to avoid multiple copies of the string appearing in the + * Xen image. BUGFRAME_run_fn needs to be handled separately. + */ +#define BUG_FRAME(type, line, file, has_msg, msg) do { \ + BUILD_BUG_ON((line) >> 16); \ + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ + asm ("1:"BUG_INSTR"\n" \ + ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ + "2:\t.asciz " __stringify(file) "\n" \ + "3:\n" \ + ".if " #has_msg "\n" \ + "\t.asciz " #msg "\n" \ + ".endif\n" \ + ".popsection\n" \ + ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ + "4:\n" \ + ".p2align 2\n" \ + ".long (1b - 4b)\n" \ + ".long (2b - 4b)\n" \ + ".long (3b - 4b)\n" \ + ".hword " __stringify(line) ", 0\n" \ + ".popsection"); \ +} while (0) +#endif /* BUG_FRAME */ + +#ifndef run_in_exception_handler +/* + * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the + * flag but instead rely on the default value from the compiler). So the + * easiest way to implement run_in_exception_handler() is to pass the to + * be called function in a fixed register. + */ +#define run_in_exception_handler(fn) do { \ + register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); \ + asm ("1:"BUG_INSTR"\n" \ + ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," \ + " \"a\", %%progbits\n" \ + "2:\n" \ + ".p2align 2\n" \ + ".long (1b - 2b)\n" \ + ".long 0, 0, 0\n" \ + ".popsection" :: "r" (fn_)); \ +} while (0) +#endif /* run_in_exception_handler */ + +#ifndef WARN +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") +#endif /* WARN */ + +#ifndef BUG +#define BUG() do { \ + BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ + unreachable(); \ +} while (0) +#endif + +#ifndef assert_failed +#define assert_failed(msg) do { \ + BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ + unreachable(); \ +} while (0) +#endif + +extern const struct bug_frame __start_bug_frames[], + __stop_bug_frames_0[], + __stop_bug_frames_1[], + __stop_bug_frames_2[], + __stop_bug_frames_3[]; + +#else /* !__ASSEMBLY__ */ + +#ifdef CONFIG_X86 +#include +#endif + +#endif /* __ASSEMBLY__ */ + +#endif /* __XEN_BUG_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:06:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489264.757643 (Exim 4.92) (envelope-from ) id 1pNzVk-0003OK-57; Fri, 03 Feb 2023 17:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489264.757643; Fri, 03 Feb 2023 17:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVk-0003NK-19; Fri, 03 Feb 2023 17:06:04 +0000 Received: by outflank-mailman (input) for mailman id 489264; Fri, 03 Feb 2023 17:06:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVj-00033s-3b for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:06:03 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08d59ef9-a3e5-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 18:06:01 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id r27so1421583wrr.1 for ; Fri, 03 Feb 2023 09:06:01 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002bfe266d710sm2452191wrt.90.2023.02.03.09.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:06:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08d59ef9-a3e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zHXZzCaP4EL/Cp/TI2J6cwghMvNFDSnZkyTmGo7qoH0=; b=S+9fHGTuMOFzFjMfTsb2kTRx6sobp8yOt0pRw4mymhSu71QMs8DOVI8p0nTCctml2Y DJFZJF18GIrWI0BQaZGI5WHR4YvMWvXJUP7GOhMDFQfpov0XRGvz3Ldq1G1vt3jIW596 TD3EUtyJPWPaQaBtOv/89WZVCScohpgL7DQ6vY96ZnkM0urOKkrpWqHvhf34qBPnsPBG /h52f2mIdif5myuP4pCXlOGrufTR5dHmyiYK7IXGz0iKxlLx+K6IttedZUdA4nm1881c xOyAgyR5Uyoqq/6sl+PCUUHEt564shjXNF09yJfYvPQ3XjB/4AZw+wNAyQaK7QkRvlpw xcYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zHXZzCaP4EL/Cp/TI2J6cwghMvNFDSnZkyTmGo7qoH0=; b=JANsS+NKLxVmurJ0UvnkE08hYfxOL2U3J9PKoWvSKhaN4SUi9dEoc4VuQcqtL4OBDA c+46McKouX0F7fhDWRKXQl9Z3PaF07uT9rH4S78nDqv6+8/Zyv/O023i5aDseHOoWX5I 1GmvDOTWcI6uACKC1hXgsjel+MtgPkDI/b2vybUDKd0OfwMzASTn9bwtQE7rZ3a0xLqw yNeUK3fnmyBWZTCZUC+cItwxTtZDop60P3Ew53UHgQtgKWr8aeIPxsufNCLVUYu+w98W fop+6spUk82QeLL87i+vZuG8cyY5Mph+RZCHKRga44OzHPNp8LWI8qssqiMntPv20la7 LQ9w== X-Gm-Message-State: AO0yUKVH39+Hl6uJKTlA+akYne+ttk2iIau87jiZuBR3ElpipmUD34+0 ZM0OhLWlUSYOSpTVxNOa+Z4rPBwjYBw= X-Google-Smtp-Source: AK7set9OpICIjgWDA7IdAqXmFcZBD6zYoq//moBwyhuYa0DOPIeuf6b9f1wVD6gxwcI0z3wLeyr20A== X-Received: by 2002:adf:d0cc:0:b0:2bf:da4d:524 with SMTP id z12-20020adfd0cc000000b002bfda4d0524mr10467422wrh.35.1675443960437; Fri, 03 Feb 2023 09:06:00 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v1 4/4] xen: change to Date: Fri, 3 Feb 2023 19:05:50 +0200 Message-Id: <5a427934949e3b0cf6026c8ad6c62e37e5250ca7.1675441720.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the generic version of bug.h stuff was introduced it is necessary to rename all uses of to Signed-off-by: Oleksii Kurochko --- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/lib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index a94520ee57..f290821a0e 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -39,7 +39,7 @@ #include #include #include -#include +#include #include #include diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 05ee1e18af..e914ccade0 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -24,12 +24,12 @@ #ifndef __ASSEMBLY__ +#include #include #include #include #include #include -#include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) #define WARN_ON(p) ({ \ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:06:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489260.757606 (Exim 4.92) (envelope-from ) id 1pNzVe-0002Zf-UR; Fri, 03 Feb 2023 17:05:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489260.757606; Fri, 03 Feb 2023 17:05:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVe-0002ZY-Qy; Fri, 03 Feb 2023 17:05:58 +0000 Received: by outflank-mailman (input) for mailman id 489260; Fri, 03 Feb 2023 17:05:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVd-0002ZN-D3 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:05:57 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0573246b-a3e5-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 18:05:56 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id bg26so4392996wmb.0 for ; Fri, 03 Feb 2023 09:05:55 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002bfe266d710sm2452191wrt.90.2023.02.03.09.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:05:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0573246b-a3e5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IimoZA31WZ5/fT3KaPsuM531N6A6S9mjjpULZGwMFtI=; b=EnHEcRl/SiMTNJ3XOSSq4Va5Rg/3mB9yM3pnSvOgaNOwb75RWc3tDObC+yfjq9xBU7 fqtAFRqezRNfy1ZgcCFK58nT4wG5kQcWH4n47tvGfEzky7pKM8UhCT98aLJR7GDnre4f NPXgGtZ9voY2dpBEG9uUargEqkKGzNWhSo3Uypl29xEVTS/VtOcCKV2u7H3u9eF+DUqL zGZPfGm6GPsfTleEKXR5PeGNFyWvSv7/7JaS4194i+zuxVSt+B+0IC74F2JZUU56y8j7 +yFa4/RGDO/rhY94zZw4NKAT1XtW7pdW5tUrWYtDF65jTyrZQwfh+Xy1juRw9Mv0rEyM T6bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IimoZA31WZ5/fT3KaPsuM531N6A6S9mjjpULZGwMFtI=; b=EKXSmgFx5SvOXqDUFbMEuNNhcXstxC3Ck1tmCo7pzZCJzeQ80xA92EJua0hHufxw72 /YLZAch6I/Yx9DVD+GfJ2KL8FVf38G57LDzdltiEwKRjoBVls1K3tq+Z4Q2lEhHFfJAU VtARCscID4cHglkf2Np0iigP8DR9HLyCbWKlHnhLIqjDfx5WgWTUDmBlagFmYd5gVlcd 8udqOXLKkcMxhGD1XhBB9iRSmicLCtC31KxN2RBeEB8fv46La/zht2toFErZEOzb5d1k 7oL4SFlz+WzFyukmJLcEdfMF7T6lK4uFAcvfXMrHJS1L17aai4hWgm7CbckmzW21AcR+ TWHQ== X-Gm-Message-State: AO0yUKVD5m4eLsxOhKSFb/do8DaQl4An0KAQlcL+a5bu6BcfukON6g7e vbD36CVxXzZWIwifgCWV0Ie3KwXB0qo= X-Google-Smtp-Source: AK7set/lZb0ZRrRuv9Avx1XZdUrh55fCyr3AYQmBrcCsMryCkQkQ+xZHERIuVvqh1ExFR+5ll0hEzQ== X-Received: by 2002:a05:600c:4588:b0:3dd:f286:5ae9 with SMTP id r8-20020a05600c458800b003ddf2865ae9mr10490877wmo.9.1675443954637; Fri, 03 Feb 2023 09:05:54 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 0/4] introduce generic implementation of macros from bug.h Date: Fri, 3 Feb 2023 19:05:46 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures (especially ARM and RISCV have the same implementation), so it was created a new config CONFIG_GENERIC_BUG_FRAME which are used to introduce generic implementation of do_bug_frame() and move ARM's to with the following changes: * add inclusion of arch-specific header * rename the guard and remove ARM specific changes * wrap macros BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed into #ifndef "BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed" thereby each architecture can override generic implementation of macros. * add #ifdef __ASSEMBLY__ ... #endif * Update run_in_exception_handler() with: register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); to avoid: asm ("mv " __stringify(BUG_FN_REG) ", %0\n" For x86 only common parts was removed from . RISC-V will be switched to use and in the future, it will use common the version of do_bug_frame() when xen/common will work for RISC-V. Oleksii Kurochko (4): xen: introduce CONFIG_GENERIC_BUG_FRAME xen/arm: switch ARM to use generic implementation of bug.h xen/x86: switch x86 to use generic implemetation of bug.h xen: change to xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/bug.h | 86 ------------------ xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/traps.c | 79 ----------------- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/bug.h | 32 +------ xen/common/Kconfig | 6 ++ xen/common/Makefile | 1 + xen/common/bug.c | 88 +++++++++++++++++++ xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/bug.h | 127 +++++++++++++++++++++++++++ xen/include/xen/lib.h | 2 +- 15 files changed, 232 insertions(+), 202 deletions(-) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:06:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489263.757639 (Exim 4.92) (envelope-from ) id 1pNzVj-0003Kw-SA; Fri, 03 Feb 2023 17:06:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489263.757639; Fri, 03 Feb 2023 17:06:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVj-0003Kp-ON; Fri, 03 Feb 2023 17:06:03 +0000 Received: by outflank-mailman (input) for mailman id 489263; Fri, 03 Feb 2023 17:06:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVi-00033s-MK for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:06:02 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 073095ad-a3e5-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 18:05:58 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id l37-20020a05600c1d2500b003dfe46a9801so2889349wms.0 for ; Fri, 03 Feb 2023 09:05:58 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002bfe266d710sm2452191wrt.90.2023.02.03.09.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:05:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 073095ad-a3e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yl1BVOCE2L2DuqGqY3o9frkeRbpNVy3JkjL/X/RKkSs=; b=Piz4Bo7P+4/3Xxe/fkI3O9MSoLBXHIF3aZpuXtMbi2ocnSrfxyQxuQ6K0TRkreS5eJ G4C5+7U2d4zK9SAC0LlyrjDhFdMBjiXz3mDn0wwaKDrJ0YpLIQQNHI6yb/0cfYOaADZ6 BHSR7s0rzNYdjkeMRjx/dubNEVRy+G7hEXxM42C4U4oRNwoFWBm7wIPjsai5UE0aPGae sTx1spuHjOmDUe1hFOlpF3p1wEXnBKtOecnNTEbslrdokyKF7N5CnX1D710B+h8QSU7O oeyQH1fv++UMGFgbdlOnTEOYBnENYP0oD0kzBeibCCVwSt0JC4QJVovgHstJqjE0ZlwR 2n9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yl1BVOCE2L2DuqGqY3o9frkeRbpNVy3JkjL/X/RKkSs=; b=7RkhqMf8B55OqjSFB+032jWvG7Z+pjLqcPArmse7uHNIxozVhVN7kHcfedXZD/jLR6 YiyZl7QCc6x8nfOhVaRpTztKnfzG19k4Bbf5To9uoYFlVH21Hesh7Z/YQ3K8BKjsbAyg 5Hfks/tSGODIQP16E/tNrBB2Pk6pR23DhcQdmAkZkf2V8Ep5FIHRO9+f4DUq0R/jbLfm sIqP6YgM1eQCTN/KQkxYPETChw/RBW2Jagp4ec5qQnh3741VJxnt7ME7yexMC4+F1QFw Fz6zzZd10+ufM5T92VxW6/aoL9bUV/7UDsBK29cCd4tuc+Fm8sTGwdh8yz1lx7m28Ibw kxtg== X-Gm-Message-State: AO0yUKVrMB3OfQkR5LrqZCWGc4ZCAjtEYEE1Y84WHeJMjegpJw5LPgzf p7ZxkXOaH+MCbRBHSYD5ozxojgv0vdQ= X-Google-Smtp-Source: AK7set8AcggySQAjlpRHEsrJ/C/bn0asYbjDxrZ9oNavZBTc+sBrfi7pove9NVnnr9v+kK3IjWvYEw== X-Received: by 2002:a05:600c:4687:b0:3db:eb0:6f6 with SMTP id p7-20020a05600c468700b003db0eb006f6mr10656252wmo.13.1675443957628; Fri, 03 Feb 2023 09:05:57 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v1 2/4] xen/arm: switch ARM to use generic implementation of bug.h Date: Fri, 3 Feb 2023 19:05:48 +0200 Message-Id: <6c8b46f2f3326b833c73dbb86674ac5eb6ea45c8.1675441720.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/bug.h | 86 -------------------------------- xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/traps.c | 79 ----------------------------- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- 6 files changed, 4 insertions(+), 168 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..ca622fc87d 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -18,6 +18,7 @@ config ARM select HAS_PDX select HAS_PMAP select IOMMU_FORCE_PT_SHARE + select GENERIC_DO_BUG_FRAME config ARCH_DEFCONFIG string diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h index f4088d0913..841667411b 100644 --- a/xen/arch/arm/include/asm/bug.h +++ b/xen/arch/arm/include/asm/bug.h @@ -9,92 +9,6 @@ # error "unknown ARM variant" #endif -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) - -struct bug_frame { - signed int loc_disp; /* Relative address to the bug address */ - signed int file_disp; /* Relative address to the filename */ - signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ - uint16_t line; /* Line number */ - uint32_t pad0:16; /* Padding for 8-bytes align */ -}; - -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) -#define bug_file(b) ((const void *)(b) + (b)->file_disp); -#define bug_line(b) ((b)->line) -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) - -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - -/* Many versions of GCC doesn't support the asm %c parameter which would - * be preferable to this unpleasantness. We use mergeable string - * sections to avoid multiple copies of the string appearing in the - * Xen image. BUGFRAME_run_fn needs to be handled separately. - */ -#define BUG_FRAME(type, line, file, has_msg, msg) do { \ - BUILD_BUG_ON((line) >> 16); \ - BUILD_BUG_ON((type) >= BUGFRAME_NR); \ - asm ("1:"BUG_INSTR"\n" \ - ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ - "2:\t.asciz " __stringify(file) "\n" \ - "3:\n" \ - ".if " #has_msg "\n" \ - "\t.asciz " #msg "\n" \ - ".endif\n" \ - ".popsection\n" \ - ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ - "4:\n" \ - ".p2align 2\n" \ - ".long (1b - 4b)\n" \ - ".long (2b - 4b)\n" \ - ".long (3b - 4b)\n" \ - ".hword " __stringify(line) ", 0\n" \ - ".popsection"); \ -} while (0) - -/* - * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the - * flag but instead rely on the default value from the compiler). So the - * easiest way to implement run_in_exception_handler() is to pass the to - * be called function in a fixed register. - */ -#define run_in_exception_handler(fn) do { \ - asm ("mov " __stringify(BUG_FN_REG) ", %0\n" \ - "1:"BUG_INSTR"\n" \ - ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," \ - " \"a\", %%progbits\n" \ - "2:\n" \ - ".p2align 2\n" \ - ".long (1b - 2b)\n" \ - ".long 0, 0, 0\n" \ - ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); \ -} while (0) - -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") - -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ - unreachable(); \ -} while (0) - -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; - #endif /* __ARM_BUG_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/div64.h b/xen/arch/arm/include/asm/div64.h index 1cd58bc51a..fc667a80f9 100644 --- a/xen/arch/arm/include/asm/div64.h +++ b/xen/arch/arm/include/asm/div64.h @@ -74,7 +74,7 @@ #elif __GNUC__ >= 4 -#include +#include /* * If the divisor happens to be constant, we determine the appropriate diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd..751c3277aa 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1197,85 +1197,6 @@ void do_unexpected_trap(const char *msg, const struct cpu_user_regs *regs) panic("CPU%d: Unexpected Trap: %s\n", smp_processor_id(), msg); } -int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) -{ - const struct bug_frame *bug = NULL; - const char *prefix = "", *filename, *predicate; - unsigned long fixup; - int id = -1, lineno; - const struct virtual_region *region; - - region = find_text_region(pc); - if ( region ) - { - for ( id = 0; id < BUGFRAME_NR; id++ ) - { - const struct bug_frame *b; - unsigned int i; - - for ( i = 0, b = region->frame[id].bugs; - i < region->frame[id].n_bugs; b++, i++ ) - { - if ( ((vaddr_t)bug_loc(b)) == pc ) - { - bug = b; - goto found; - } - } - } - } - found: - if ( !bug ) - return -ENOENT; - - if ( id == BUGFRAME_run_fn ) - { - void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; - - fn(regs); - return 0; - } - - /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ - filename = bug_file(bug); - if ( !is_kernel(filename) ) - return -EINVAL; - fixup = strlen(filename); - if ( fixup > 50 ) - { - filename += fixup - 47; - prefix = "..."; - } - lineno = bug_line(bug); - - switch ( id ) - { - case BUGFRAME_warn: - printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - return 0; - - case BUGFRAME_bug: - printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - case BUGFRAME_assert: - /* ASSERT: decode the predicate string pointer. */ - predicate = bug_msg(bug); - if ( !is_kernel(predicate) ) - predicate = ""; - - printk("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - show_execution_state(regs); - panic("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - } - - return -EINVAL; -} - #ifdef CONFIG_ARM_64 static void do_trap_brk(struct cpu_user_regs *regs, const union hsr hsr) { diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c index 1a99d3a8b4..c90e88fddb 100644 --- a/xen/arch/arm/vgic/vgic-v2.c +++ b/xen/arch/arm/vgic/vgic-v2.c @@ -16,8 +16,8 @@ */ #include -#include #include +#include #include #include diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index f0f2ea5021..b9463a5f27 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -15,9 +15,9 @@ * along with this program. If not, see . */ +#include #include #include -#include #include #include -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:06:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489262.757628 (Exim 4.92) (envelope-from ) id 1pNzVh-000349-Jv; Fri, 03 Feb 2023 17:06:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489262.757628; Fri, 03 Feb 2023 17:06:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVh-000342-Gh; Fri, 03 Feb 2023 17:06:01 +0000 Received: by outflank-mailman (input) for mailman id 489262; Fri, 03 Feb 2023 17:06:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzVg-0002ZN-A2 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:06:00 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0800783c-a3e5-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 18:05:59 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id r2so5229174wrv.7 for ; Fri, 03 Feb 2023 09:05:59 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f17-20020a5d50d1000000b002bfe266d710sm2452191wrt.90.2023.02.03.09.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:05:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0800783c-a3e5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GhdHtq9aMzFDWYNNkoxwJc2rej7B4EmE4MDh7V6MGV8=; b=PrsImFx6GNwYGrDks8LK0i6j0eUxCe9uSTX/pH59vscdE4b4pQIKcQKwk5h9gEAs8d Zcu539lmdUrWAhQsfPF6A6FnZZIKe2m58J5KmXqX+om83BNeZq1jBg3ueeU0J4Kyhqv3 LDX+SAkA6hHzZpBuOLqYYOVdzOeqSmNKtNovt3NXcSXLiK4pfPFQEOTxQumY4rPbkM27 xUHj1a9K6U6ujGGWqIIOwMYXFG9DElZH74wkPcFD2hB3lel/xiMDdHwrxZS7NYFMD01M VOJJ8Dm4+/2ypPrtaCwRD8ek5LqOTluvEaUYa4LeKTs0C9vzzSidQR22u1hPY2SzQPBl ZR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GhdHtq9aMzFDWYNNkoxwJc2rej7B4EmE4MDh7V6MGV8=; b=FUeUx7oWzi4e7RA2vgrhkj8eyNIQFg/HJQiiQ1zn7tT+24i12kath352c7aPJew8XU gz/Nxdyz23p26w5V4GjZ+r82TBhmh03+rXVElf7t7f/GrPbKu1YeGRgQ5tQSOYZO8cV2 joSN024Tq3ABkBdVj8oIYlZhja+z5hAFC8YnRFD4rMwIvnjq9WnlgQcILsIENs23Y4M+ eqyzk6VjuwPeBNWZGbuT2tcMhn+PBU4yp/kOebJR0r3SDRj7qJUKuOVZkFwdUlIsnRhY FQCyioVxPTeYRdseq5KIHF60rGDNXraoX3VZ11DE8urDQy9CfuVHfAHtGbmPHCsq1X9k FRmw== X-Gm-Message-State: AO0yUKURYSb6HG7pf//Caxbb+sJIZwYfBoJ+F2z2GNOZxENHRoeJy2VZ wXWr/SIAR/WizwLwRlcfVe6k7+MLgyM= X-Google-Smtp-Source: AK7set/DvDfuwgbw5Ws3sN7u/z0yuAmf14cwE4Zew3Zh9a4qOin0v9FihyMezT6NyK9hlQVeCQjT6w== X-Received: by 2002:a5d:6309:0:b0:2c3:dc42:525d with SMTP id i9-20020a5d6309000000b002c3dc42525dmr152118wru.36.1675443958976; Fri, 03 Feb 2023 09:05:58 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v1 3/4] xen/x86: switch x86 to use generic implemetation of bug.h Date: Fri, 3 Feb 2023 19:05:49 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/bug.h | 32 ++-------------------------- 3 files changed, 4 insertions(+), 32 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index c27cbb2304..18ff2a443b 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -27,6 +27,7 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include #include #include #include @@ -35,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/include/asm/asm_defns.h b/xen/arch/x86/include/asm/asm_defns.h index d9431180cf..a8526cf36c 100644 --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -6,7 +6,7 @@ /* NB. Auto-generated from arch/.../asm-offsets.c */ #include #endif -#include +#include #include #include #include diff --git a/xen/arch/x86/include/asm/bug.h b/xen/arch/x86/include/asm/bug.h index b7265bdfbe..6ead21d9fe 100644 --- a/xen/arch/x86/include/asm/bug.h +++ b/xen/arch/x86/include/asm/bug.h @@ -1,19 +1,10 @@ #ifndef __X86_BUG_H__ #define __X86_BUG_H__ -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) - -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - #ifndef __ASSEMBLY__ +#define BUG_FRAME_STUFF + struct bug_frame { signed int loc_disp:BUG_DISP_WIDTH; unsigned int line_hi:BUG_LINE_HI_WIDTH; @@ -58,13 +49,6 @@ struct bug_frame { :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ } while (0) - -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ - unreachable(); \ -} while (0) - /* * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, * and use a real static inline here to get proper type checking of fn(). @@ -75,19 +59,7 @@ struct bug_frame { BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ } while ( 0 ) -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; - #else /* !__ASSEMBLY__ */ - /* * Construct a bugframe, suitable for using in assembly code. Should always * match the C version above. One complication is having to stash the strings -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:31:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:31:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489294.757661 (Exim 4.92) (envelope-from ) id 1pNzue-0008W4-8K; Fri, 03 Feb 2023 17:31:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489294.757661; Fri, 03 Feb 2023 17:31:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzue-0008Vx-5f; Fri, 03 Feb 2023 17:31:48 +0000 Received: by outflank-mailman (input) for mailman id 489294; Fri, 03 Feb 2023 17:31:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzuc-0008Vn-9E; Fri, 03 Feb 2023 17:31:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzuc-0003L8-0V; Fri, 03 Feb 2023 17:31:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pNzub-0006Ol-Lv; Fri, 03 Feb 2023 17:31:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pNzub-0000m7-LB; Fri, 03 Feb 2023 17:31:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8IZXBvpvAXIA1uCErDTGh2ir6VdLlJaVstj6/EesgII=; b=nPwfUJMVHLi6es9UR7ruxwC8B7 YyobHGWiZSrE/+FAe1s3s2VQSd20d7AxEDUhzk+SWpmuvQgeZlIDKTHBNt89avzcNcFySXMvSVAkt e2Dxv2xb0OIF1Vi40CkftwVS7eukpdKxexWJ9jUnAvpaS8zCMVZermAMB7SBgVCBEBZI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176342: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:windows-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 X-Osstest-Versions-That: qemuu=13356edb87506c148b163b8c7eb0695647d00c2a From: osstest service owner Date: Fri, 03 Feb 2023 17:31:45 +0000 flight 176342 qemu-mainline real [real] flight 176351 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176342/ http://logs.test-lab.xenproject.org/osstest/logs/176351/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-ws16-amd64 12 windows-install fail pass in 176351-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail in 176351 like 176096 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail like 176096 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176096 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176096 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176096 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 baseline version: qemuu 13356edb87506c148b163b8c7eb0695647d00c2a Last test of basis 176096 2023-01-24 12:38:02 Z 10 days Failing since 176332 2023-02-02 10:37:16 Z 1 days 3 attempts Testing same since 176342 2023-02-03 03:30:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Bernhard Beschow Daniel P. Berrangé David Daney Dongdong Zhang Dr. David Alan Gilbert <dgilbert@redhat.com>
Dr. David Alan Gilbert Eric Biggers Fabiano Rosas Greg Kurz Igor Mammedov Jason A. Donenfeld John Snow Laurent Vivier Maksim Davydov Marc-André Lureau Marcel Apfelbaum Mathias Krause Maxime Coquelin Michael S. Tsirkin Minghao Yuan Peter Delevoryas Peter Maydell Peter Xu Philippe Mathieu-Daudé Philippe Mathieu-Daudé Sebastian Mitterle Stefan Hajnoczi Thomas Huth Vladimir Sementsov-Ogievskiy Wenchao Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 13356edb87..387b2b5255 387b2b52558bbb44ad74634415e1ab488d3c62a7 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Feb 03 17:54:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 17:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489307.757672 (Exim 4.92) (envelope-from ) id 1pO0GR-0002xk-2A; Fri, 03 Feb 2023 17:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489307.757672; Fri, 03 Feb 2023 17:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO0GQ-0002xd-UD; Fri, 03 Feb 2023 17:54:18 +0000 Received: by outflank-mailman (input) for mailman id 489307; Fri, 03 Feb 2023 17:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO0GP-0002xX-Rg for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 17:54:18 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5c98f40-a3eb-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 18:54:16 +0100 (CET) Received: by mail-pj1-x102b.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso9515233pjj.1 for ; Fri, 03 Feb 2023 09:54:15 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id e12-20020a170902784c00b00192b23b8451sm1889641pln.108.2023.02.03.09.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:54:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5c98f40-a3eb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=FglzRedEledpe7U/HZFQU5fjwrxpiFTlIoZfizmZKxo=; b=jbL6W/faZm4W+GkDNARtVIQSEx2ADO2QYfIC86h2ZMHc5o/ZEBFOY5YrRkhNg2iOpB /63HbsfHa9WGzx3zbFmY1UfIUIuxKXcouG1MM1zxPt90HwxBo5dELOThuq4wIWGKm/i2 DiYYIrK7jDHD/1It501CO+Y9SysMFq67N+Mtg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FglzRedEledpe7U/HZFQU5fjwrxpiFTlIoZfizmZKxo=; b=yTAOgjIap+UGOnls2lelohJy1FYh2XZocLZD3bczMf0SkL5TBRdr1Vho82aFx/og+6 1YTEQuNdKuGyGyJfN2zBDfKxx+PD8Q63SvftVkqnWlUxlFr1rP0TcfPYRylTmz/ncZfD hm4meTPa9ZMagPLn9/jj5UVI+Bq113R6iTXq0H6/lYm4Bz6oilsZkbbOSG+BeuVMIvFF 3mQIvbK9si0BsUDzrluCBDwTY1I97HLqstRtr/Jm4PgQdeFBcyZM8kTU6CStiv6njwrr eHKaRr98lf7w6C90XY7mmzxgnV1rtxRNkiMyfDfxE3hq54UD/IcdOP9JCX3j85atpDuj NVLA== X-Gm-Message-State: AO0yUKWuL4x+VjBHM1ZltptZ9ypBfTixydim+oG3mCpdKxP0mOJOkywE i19w4bc2Hz2nyRc0Z9ipAOJq4Q== X-Google-Smtp-Source: AK7set/Z7WE5Ld13ny7sgCsxLEEjOYX9qnYiq/CIu1TV+5vNxcdynZYDJopTLqfhZ/z5xziON6sH4Q== X-Received: by 2002:a17:902:c611:b0:194:5fc9:f55a with SMTP id r17-20020a170902c61100b001945fc9f55amr8907518plr.35.1675446854374; Fri, 03 Feb 2023 09:54:14 -0800 (PST) Message-ID: <63dd4a45.170a0220.e6dee.365d@mx.google.com> X-Google-Original-Message-ID: <202302031754.@keescook> Date: Fri, 3 Feb 2023 17:54:13 +0000 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] xen: Replace one-element array with flexible-array member References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 02, 2023 at 07:28:23PM -0600, Gustavo A. R. Silva wrote: > One-element arrays are deprecated, and we are replacing them with flexible > array members instead. So, replace one-element array with flexible-array > member in struct xen_page_directory. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [1]. > > This results in no differences in binary output. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/255 > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook From xen-devel-bounces@lists.xenproject.org Fri Feb 03 18:01:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 18:01:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489313.757682 (Exim 4.92) (envelope-from ) id 1pO0No-0004f0-OM; Fri, 03 Feb 2023 18:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489313.757682; Fri, 03 Feb 2023 18:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO0No-0004et-Lf; Fri, 03 Feb 2023 18:01:56 +0000 Received: by outflank-mailman (input) for mailman id 489313; Fri, 03 Feb 2023 18:01:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO0Nn-0004en-Ap for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 18:01:55 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d619a340-a3ec-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 19:01:53 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 313I1SAE033265 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 3 Feb 2023 13:01:34 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 313I1SdK033264; Fri, 3 Feb 2023 10:01:28 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d619a340-a3ec-11ed-933c-83870f6b2ba8 Message-Id: <202302031801.313I1SdK033264@m5p.com> From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini Cc: Julien Grall Cc: Bertrand Marquis Cc: Volodymyr Babchuk Date: Wed, 22 Jul 2020 10:43:57 -0700 Subject: [PATCH] xen/arm64: Default ACPI support enabled X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Unlike other unsupportted options, ACPI support is required to *boot* for a number of platforms. Users on these platforms are unable to use distribution builds and must rebuild from source to use Xen. Signed-off-by: Elliott Mitchell --- Stripping this down to near-minimum. Previous similar commits had included a message in dmesg, but the community call indicated doing near the absolute minimum. There was also a mention of potentially marking Xen as tainted in this case. That seems reasonable to me. Just ACPI support needs to default enabled now. --- xen/arch/arm/Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..778bee5792 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -29,13 +29,18 @@ menu "Architecture Features" source "arch/Kconfig" config ACPI - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" depends on ARM_64 + default y ---help--- Advanced Configuration and Power Interface (ACPI) support for Xen is an alternative to device tree on ARM64. + Note this is presently UNSUPPORTED. If a given device has both + device-tree and ACPI support, it is presently (February 2023) + recommended to boot using the device-tree. + config ARM_EFI bool -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 19:09:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 19:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489349.757699 (Exim 4.92) (envelope-from ) id 1pO1RA-0003hW-SF; Fri, 03 Feb 2023 19:09:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489349.757699; Fri, 03 Feb 2023 19:09:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RA-0003gi-O0; Fri, 03 Feb 2023 19:09:28 +0000 Received: by outflank-mailman (input) for mailman id 489349; Fri, 03 Feb 2023 19:09:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RA-0003dr-3l for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 19:09:28 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 448449f8-a3f6-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 20:09:23 +0100 (CET) Received: by mail-ej1-x62f.google.com with SMTP id lu11so18062983ejb.3 for ; Fri, 03 Feb 2023 11:09:22 -0800 (PST) Received: from uni.router.wind (adsl-160.109.242.226.tellas.gr. [109.242.226.160]) by smtp.googlemail.com with ESMTPSA id q24-20020aa7cc18000000b0049e19136c22sm1517393edt.95.2023.02.03.11.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 11:09:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 448449f8-a3f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+fzZMQ+2jafPS2MFlWMRAqix0hGiyv5wDJVeUhTAdTU=; b=Ek65BpXFqK+r5CErMfowedSYBY5DMmSf5M0MFI/WA5X3iLoaNnexl4AbZ7mVgQ/TnE aXeC8/SL/pbVsemJfvIPtX9WXxo0ii0fgK/5P2EACgYg6c/LRWfpv+gGknFzrqX9YbEy 8UiV8CAan5q7s0LO7FmzNpG4EbRdQ1dBIiARyl1W6aermiPHPUWOTIQfL0ZSAyWK5sD5 CnLRYHq23ZF5OLK+o+7ym21nnC/gOB4GWRBF+mRL5/UIiCJS4rgbEm9lgmZzW+xKD9Tt fHoT5XARSTnlXc5yUqqa3ieCwVFqcMMUCgDBkhqGvvyGKOJxreQC2GkCevHZCgXhRJUC M/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+fzZMQ+2jafPS2MFlWMRAqix0hGiyv5wDJVeUhTAdTU=; b=M40vJjSe0snJpnfnxypG/xElVjeX5ELMqa3pcYNgUvbBk34N2DuCdozQ/f8ijPforM Gt582eQMmfryKlO7qa8mOoGJllKLFHcJrSP+qqpzJDRygT7eOtgpBv1qEjbxuQr9vYLc /8DuGjg1YNLstu5kaetAu5CEehMiOxMKGzjcpZzbUPeeCKO1sG5biJLFS5YESosrMSId FVyew8WrSAyqL/Jt2Nk3qeE38ki7ye0ODQ6lFve9jiKhuu47b59myOCEWdHgU/Iv4eL5 tRdU506YdROnJ1AOzyrXTx+1ON2RIdcS7Zclnk4F2ijD7FFzmRuMl8Ylb+GPzrnYk2+q rqBQ== X-Gm-Message-State: AO0yUKXU5IPkCIr1/SNei3WdiynrDnAggpOXgZYcKUjAtGYQJRP/5w5r zlT+RJpZv6d7NSieg1/Hl1iDyH8Bz98= X-Google-Smtp-Source: AK7set+5cH7dT8nZl9h6ONnVwJRAC6JedrPJmzWnuAjvzdEKmKTbCfem8DT0SmRxULPLVntCIbvnhQ== X-Received: by 2002:a17:906:a28b:b0:886:ec6e:4c1 with SMTP id i11-20020a170906a28b00b00886ec6e04c1mr10823073ejz.59.1675451361950; Fri, 03 Feb 2023 11:09:21 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall Subject: [PATCH v3 0/2] Resolve issues related to macros in device_tree.h Date: Fri, 3 Feb 2023 21:09:06 +0200 Message-Id: <20230203190908.211541-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Xenia Ragiadakou (2): xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros xen/include/xen/device_tree.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 19:09:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 19:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489348.757693 (Exim 4.92) (envelope-from ) id 1pO1RA-0003eE-JJ; Fri, 03 Feb 2023 19:09:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489348.757693; Fri, 03 Feb 2023 19:09:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RA-0003e7-GW; Fri, 03 Feb 2023 19:09:28 +0000 Received: by outflank-mailman (input) for mailman id 489348; Fri, 03 Feb 2023 19:09:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RA-0003ds-4g for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 19:09:28 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46dff81e-a3f6-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 20:09:27 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id x7so6185780edr.0 for ; Fri, 03 Feb 2023 11:09:26 -0800 (PST) Received: from uni.router.wind (adsl-160.109.242.226.tellas.gr. [109.242.226.160]) by smtp.googlemail.com with ESMTPSA id q24-20020aa7cc18000000b0049e19136c22sm1517393edt.95.2023.02.03.11.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 11:09:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46dff81e-a3f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u/53xjCm4StWok4GzCMBvVj8eVR215tSpVZLrSRkfJ0=; b=FQLirTlVFUjB+AQPp0y0vNUjzoF5Od//jXZK0/QFsa2lKmSla9/e/4CkSzlDziqz3D LzTNkPGiiVErGIrbvXPG6PTnuX2tb4ugi5KFg4I+KnFwQrSTKxUoi0a3mFJf32FfBHJn 3ANlqIEsmS+A4DmnTad3QB3LO4A47O7Fgplfct4BG1qCOJpR39aw4+UeFhRhEwnJhVcV ZeRngIVXF+P0qBzFaXkNU5M0CyfJwpmRBhHCRe+w4+E6wS8A7F1mtkCPq291pulfLYYK Q2V+puqeZotcLZb8YfaYONFcFBXsNKUKE7uZfGzbkWC7Gl9xlGOc5cWIFEaElqimefgY X2/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u/53xjCm4StWok4GzCMBvVj8eVR215tSpVZLrSRkfJ0=; b=qjJNp+u1xV9r/8xtHy04JPYUWyAjJucJ7YQO0yHVmF4Xez0L+mkEClO5RZaY+OeKTO 7WUHlnE+XipnEX9ajj0anTfxWwn1JBHlO7CpQhHmfF7N9eciMg5uvuiiGDP9yDCwsMcF XylijeXxkD4rOeXhjsmVaGbe3cnoilesFpruG5/DVAtHA/U0Tb9PgfPYkG6YuKBPFJHe v0UCtgumd2TGBdLGz2Uyic637u0xgFq+WOBG8jB3rVdC6NR7ZH8GjlY0GJ5rEZsYfnLi ibYlBNy5H4pQb3y+khQ0iR2DpISLZ1hTgQ6C7qKquAnfhG0vPPy/KX3pHjftSSEoZAfS OHPg== X-Gm-Message-State: AO0yUKWW4fsIHMkVFbZjv+0Io+bHVx5c9BdZF2hugAG8yev15828H9Zt hD/oTNAWIvcsNo8NIqautLAnym5pR9E= X-Google-Smtp-Source: AK7set9T2ERnS3b9g9ktqqYsjwHPVy/YdYunkxTUXH1aeyDSovnj456AsSqHC0+2XWBqsC+ZD357wg== X-Received: by 2002:aa7:c24f:0:b0:497:b6bc:b811 with SMTP id y15-20020aa7c24f000000b00497b6bcb811mr11466606edo.33.1675451365991; Fri, 03 Feb 2023 11:09:25 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall Subject: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Date: Fri, 3 Feb 2023 21:09:08 +0200 Message-Id: <20230203190908.211541-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230203190908.211541-1-burzalodowa@gmail.com> References: <20230203190908.211541-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Macro dt_irq() is broken because the macro parameter has the same name with the struct dt_irq member "irq". Macro dt_irq_flags() is broken as well because struct dt_irq has no member named "flags". Since no one seems to have ever tried to use them and eventually stumble upon the issues above, remove them instead of fixing them. Fixes: 886f34045bf0 ("xen/arm: Add helpers to retrieve an interrupt description from the device tree") Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/include/xen/device_tree.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 7839a199e311..19a74909cece 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -159,9 +159,6 @@ struct dt_raw_irq { u32 specifier[DT_MAX_IRQ_SPEC]; }; -#define dt_irq(irq) ((irq)->irq) -#define dt_irq_flags(irq) ((irq)->flags) - typedef int (*device_tree_node_func)(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 19:09:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 19:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489350.757716 (Exim 4.92) (envelope-from ) id 1pO1RC-000488-2c; Fri, 03 Feb 2023 19:09:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489350.757716; Fri, 03 Feb 2023 19:09:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RB-00047h-VD; Fri, 03 Feb 2023 19:09:29 +0000 Received: by outflank-mailman (input) for mailman id 489350; Fri, 03 Feb 2023 19:09:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO1RA-0003dr-E0 for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 19:09:28 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45a10fd6-a3f6-11ed-93b5-47a8fe42b414; Fri, 03 Feb 2023 20:09:24 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id fi26so6132805edb.7 for ; Fri, 03 Feb 2023 11:09:24 -0800 (PST) Received: from uni.router.wind (adsl-160.109.242.226.tellas.gr. [109.242.226.160]) by smtp.googlemail.com with ESMTPSA id q24-20020aa7cc18000000b0049e19136c22sm1517393edt.95.2023.02.03.11.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 11:09:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45a10fd6-a3f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nf5jDFa5dOtO540IqofRXSKEY5a9ibf50gjNmqYzwIY=; b=QbS8zg5lOalxJw1+0MhIyWOGsMVXvNY6/YzdygKPF1a7uZsFzpYYrwSEQPd+y3uGxf bu7paLwDkoMCv6Leq0WGdl0GHu6qq0lnyncDrwRE9dWgSVioIle0JCvCSdfMbOJRwxUm X8UGuF2NcaGqD5svJHGibr3z26ciQJ94hdrLwtCiKCf0fPxb55AJMo6crTN4oDwsWCth 0uzJUoJCU15ILyYqXnnFK+e33/bIu4janN34aTpZdD0IIf6h81LMLQMYIXuUQuqmCp/3 gqE84p5sJUo44k3AgXBoIm14O4vsXqLXr83EDceLeR2kH4T0t3c+3RkgHDan3UFo9EE1 H1eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nf5jDFa5dOtO540IqofRXSKEY5a9ibf50gjNmqYzwIY=; b=qGYmcbxZkccNLoCQn7fTSoVqvvraNkBhL3dfJTzY5PUusX6VtawVdkF8dzogK6dki9 xxnlGCEvvznbfasKBwjyNhZKe+WKUa1+MwyKyf4pxNhHlnov4jz5xEaCUjyZCVsueDVT JN5E2Qt5iGCu+jh9UKlqmj0xNiWlU59nJut0x1HpqjG4A3f6ccv9TtZrCCKJbtXZbXOj L8TagfGeWT0+n2AKdVUqCIV5p0DvxRsU7XFfsPZsH82YtEgLWgmaf/daPdkp9ttLXTJa afwgDRxCg6qVYZEUcOqxw6i56vNDYprNkRc6RJOjVXWvU6OOKQ4fnaL37ttZi7C+UuDJ +fgA== X-Gm-Message-State: AO0yUKXHT6oalDV8e9XvVCcEWIeS6UpvD5MDCyWNL4odEfbtH13ZQkAO Z2sfeTurM5oUV7b8zWC+5QHo2ZnEe10= X-Google-Smtp-Source: AK7set8vZpdvQrfLeDqthMRygbp3lHm+1RJvh2Ij9g1JHs/lBRUhGNC4WAH5UNtiHjteRytANu9K1A== X-Received: by 2002:a05:6402:520e:b0:4a0:8ea1:cce with SMTP id s14-20020a056402520e00b004a08ea10ccemr14476060edd.25.1675451364002; Fri, 03 Feb 2023 11:09:24 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall Subject: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Date: Fri, 3 Feb 2023 21:09:07 +0200 Message-Id: <20230203190908.211541-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230203190908.211541-1-burzalodowa@gmail.com> References: <20230203190908.211541-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Xenia Ragiadakou --- Changes in v3: - the fixes are based solely to Eclair findings (the tool has been adjusted to report only those violations that can result to a bug) - reflect this in the commit title xen/include/xen/device_tree.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index a28937d12ae8..7839a199e311 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -37,11 +37,11 @@ struct dt_device_match { const void *data; }; -#define __DT_MATCH_PATH(p) .path = p -#define __DT_MATCH_TYPE(typ) .type = typ -#define __DT_MATCH_COMPATIBLE(compat) .compatible = compat +#define __DT_MATCH_PATH(p) .path = (p) +#define __DT_MATCH_TYPE(typ) .type = (typ) +#define __DT_MATCH_COMPATIBLE(compat) .compatible = (compat) #define __DT_MATCH_NOT_AVAILABLE() .not_available = 1 -#define __DT_MATCH_PROP(p) .prop = p +#define __DT_MATCH_PROP(p) .prop = (p) #define DT_MATCH_PATH(p) { __DT_MATCH_PATH(p) } #define DT_MATCH_TYPE(typ) { __DT_MATCH_TYPE(typ) } @@ -226,13 +226,13 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); #define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 #define dt_for_each_property_node(dn, pp) \ - for ( pp = dn->properties; pp != NULL; pp = pp->next ) + for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) #define dt_for_each_device_node(dt, dn) \ - for ( dn = dt; dn != NULL; dn = dn->allnext ) + for ( dn = dt; (dn) != NULL; dn = (dn)->allnext ) #define dt_for_each_child_node(dt, dn) \ - for ( dn = dt->child; dn != NULL; dn = dn->sibling ) + for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) /* Helper to read a big number; size is in cells (not bytes) */ static inline u64 dt_read_number(const __be32 *cell, int size) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 03 19:55:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 19:55:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489368.757727 (Exim 4.92) (envelope-from ) id 1pO29p-0002Jh-8x; Fri, 03 Feb 2023 19:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489368.757727; Fri, 03 Feb 2023 19:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO29p-0002Ja-6G; Fri, 03 Feb 2023 19:55:37 +0000 Received: by outflank-mailman (input) for mailman id 489368; Fri, 03 Feb 2023 19:55:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO29o-0002JU-Ag for xen-devel@lists.xenproject.org; Fri, 03 Feb 2023 19:55:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7aab1fd-a3fc-11ed-933c-83870f6b2ba8; Fri, 03 Feb 2023 20:55:34 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 548F461F54; Fri, 3 Feb 2023 19:55:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABEC5C433D2; Fri, 3 Feb 2023 19:55:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7aab1fd-a3fc-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675454131; bh=lLRrHJlFYjFEfeAb9WbJomtpWEWCRRS7nGpExue/71c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dRf0W9tLRAZUXD8XVHEU2GATrBroa3rpO3JU+/Ibb3Fawb6eV5S8l7OTC9IV00loZ naGPZF4JPZOrzHoP7Z2MBrZ7cFvIY4BrE5dDgPkHV6rUYyyPJcLLSDyy1x8lQTNpVI ZWm520+nJH9+400ubEBk5wdn46fqfrCtuPo2F8Yc1xg8/tLQ8+wxHXsJMN9qaiN858 j9I7WSD5J3zSCGjnAdQsBSugdH5H+teyHYU4HZ9w3WcR2iYkupw4mo7mGrvi0j0ME2 tn65cS/dxCK8v5H8SVtTsFQ+ntonPyevidtJXvXu04NB4gsUUNIbGNgaAHaCt7NQ6J YhLngzxRJkVOA== Date: Fri, 3 Feb 2023 11:55:29 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Xen-devel , Stefano Stabellini , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall Subject: Re: Proposal: List files in Xen originated from external sources In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1397571923-1675453621=:132504" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1397571923-1675453621=:132504 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 3 Feb 2023, Luca Fancellu wrote: > Hi all, > > I’m starting a proposal for the external files that needs to be removed from the MISRA scan, > the work was originally started by Michal here: > https://patchwork.kernel.org/project/xen-devel/patch/20221116092032.4423-1-michal.orzel@amd.com/ > so I started by that thread, the aim of this work is to have an initial format to start as soon as possible to > exclude the external files from the MISRA scan (at least initially from cppcheck). > > I think we can use the JSON format because it’s easy to integrate it with python and it’s easy to add/remove > fields from the structure without interfering with the other elements during time, so we can define a structure > now but if in the future we see the needs for additional field, we can just add them without changes to the > analysis script. > > In my opinion many of these fields can be left empty in a first push, to let the script exclude the files and during > time with the contributions of the community we can add the missing informations. > I think it’s easier for the community to pick an entry, do some research to fill the gaps and push, instead to wait > until having all the informations before adding the entry. > > > This is my first though for the fields, let me know yours: > > docs/misra/external-files.json: > { > "version": "1.0”, > "content": [ > { > "path": "relative/path/from/xen/“, > "backport": True/False, > "origin_project": "URL to origin project", > "origin_path": "relative path in the original project", > "origin_revision": "revision in original project” > } > ] > } > > > Maybe, documentation for this file and the fields can reside in docs/misra/external-files.rst. > > Here follows the explanation for the fields: > > path: is a relative path from the xen base folder, it can refer to a file or it can be a path to an entire folder > (Taking as example libfdt) I think "path" should be the only mandatory field. path alone should be sufficient for a MISRA C scanner to know if a file or directory should be excluded. > backport: it’s a boolean flag that says if the file is subject to backport, so every file where this field is true > won’t be included in the analysis. A file is subject to backport when it’s external and it doesn’t > accept direct changes (changes needs to be made in the original project and then backported > to Xen) > > origin_project: url of the repository where this file was originated > > origin_path: relative path in the original project, mostly linked to the original_revision field > > origin_revision: revision of the changes in the repository when this file was taken. These other fields (backport, origin_project, origin_path, origin_revision) are nice to have but not required. They don't provide information necessary to exclude something from MISRA C scans, however they provide information that are useful to the Xen maintainers. This is to say that we should introduce these fields only if they are useful to us human maintainers, not automated tools. That said, I think they are all useful and I would keep them as you did. > Now, I’m not entirely sure about the field “backport”, because if a file is not subject to backport, then why > we should not make direct changes? "backport" is meant to say that *only* backports are allowed, no direct changes to the source file. E.g. only backports from Linux commits, so first you need to get your patch in Linux, then we'll take it from there. > Shall we maybe change its codestyle and convert it to Xen codestyle? Typically if you only accept backports to a file, it doesn't make any sense to convert it to Xen codestyle. But it is not a hard rule and I don't think we should say anything in that regard here. > And then, if the file is not subject to backport and now we “own” the file, there is no more the need to list it > in the external file, a commit search can reveal when it was converted to Xen codestyle and removed from > the external file list so we don’t lose the history. Yes, I agree. If a file is coverted to Xen coding style and follows MISRA rules, then there is no need to list the file in docs/misra/external-files.json. > So we would end up excluding just all the file listed in external-file.json by the analysis. Right, I think so too --8323329-1397571923-1675453621=:132504-- From xen-devel-bounces@lists.xenproject.org Fri Feb 03 21:05:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Feb 2023 21:05:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489375.757737 (Exim 4.92) (envelope-from ) id 1pO3F5-00022l-DZ; Fri, 03 Feb 2023 21:05:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489375.757737; Fri, 03 Feb 2023 21:05:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO3F5-00022e-Aq; Fri, 03 Feb 2023 21:05:07 +0000 Received: by outflank-mailman (input) for mailman id 489375; Fri, 03 Feb 2023 21:05:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO3F4-00022U-7O; Fri, 03 Feb 2023 21:05:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO3F4-0008Hg-3m; Fri, 03 Feb 2023 21:05:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO3F3-00085O-Q8; Fri, 03 Feb 2023 21:05:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pO3F3-0007cE-Pb; Fri, 03 Feb 2023 21:05:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DLVcFpDlfiCnnoy3s8IUq9haqBgg77AvhKqPzJEQVBo=; b=3Nmz+pasJjCigkbR4p2sy32ADJ ELHmmNuwKnRh/nBN2D4swucNkrQ5gVZaBzur+MW85segQuk4EiAxRXYYA6yTqZOheYMgFRabsdGdq ToMls6+/yUntRy3FBKh42x6vXCnnRVjvlGzWcSyM9WqxWjMNuSTR8jTjVqEe6CS47NN4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176343: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=f2d379e7cb802f922409c35e4831ee52a2162486 X-Osstest-Versions-That: libvirt=95a278a84591b6a4cfa170eba31c8ec60e82f940 From: osstest service owner Date: Fri, 03 Feb 2023 21:05:05 +0000 flight 176343 libvirt real [real] flight 176353 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176343/ http://logs.test-lab.xenproject.org/osstest/logs/176353/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 176353-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt f2d379e7cb802f922409c35e4831ee52a2162486 baseline version: libvirt 95a278a84591b6a4cfa170eba31c8ec60e82f940 Last test of basis 176139 2023-01-26 04:18:49 Z 8 days Failing since 176233 2023-01-27 04:18:53 Z 7 days 8 attempts Testing same since 176343 2023-02-03 04:20:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiri Denemark Ján Tomko Martin Kletzander Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair fail test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 95a278a845..f2d379e7cb f2d379e7cb802f922409c35e4831ee52a2162486 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 04 00:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 00:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489397.757749 (Exim 4.92) (envelope-from ) id 1pO637-0005mK-6X; Sat, 04 Feb 2023 00:04:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489397.757749; Sat, 04 Feb 2023 00:04:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO637-0005mD-3y; Sat, 04 Feb 2023 00:04:57 +0000 Received: by outflank-mailman (input) for mailman id 489397; Sat, 04 Feb 2023 00:04:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO635-0005m3-7D; Sat, 04 Feb 2023 00:04:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO634-0004iT-TT; Sat, 04 Feb 2023 00:04:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO634-0005Z2-Eh; Sat, 04 Feb 2023 00:04:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pO634-0001Oy-EA; Sat, 04 Feb 2023 00:04:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IiFj/e+Lt5ZdwNo5D0NWNjmg6aFq2QAWVKiuM0pGAvM=; b=dg00wQWoU2W0I7wfTfhEoLdmJW shf8kDAqAP8/3XMHP0DzVJjai7q3gNjv0qYnDjIX/job52TtWMTwFQoyEKV+wnqjCWctK2B5fvVpq fM4QLL/kD4eW24/EkodSh9cVC1/a2Vhpbu4eeVyuARZVoakm2C+iYQqOqyhR4sG2fw80=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176344: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=66a87fff1a87c260452f5a57123891ca5258c449 X-Osstest-Versions-That: linux=9d84bb40bcb30a7fa16f33baa967aeb9953dda78 From: osstest service owner Date: Sat, 04 Feb 2023 00:04:54 +0000 flight 176344 linux-linus real [real] flight 176354 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176344/ http://logs.test-lab.xenproject.org/osstest/logs/176354/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 176354-retest test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176354-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 173462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 173462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 173462 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 173462 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 66a87fff1a87c260452f5a57123891ca5258c449 baseline version: linux 9d84bb40bcb30a7fa16f33baa967aeb9953dda78 Last test of basis 173462 2022-10-07 18:41:45 Z 119 days Failing since 173470 2022-10-08 06:21:34 Z 118 days 243 attempts Testing same since 176344 2023-02-03 06:54:13 Z 0 days 1 attempts ------------------------------------------------------------ 3485 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 9d84bb40bcb3..66a87fff1a87 66a87fff1a87c260452f5a57123891ca5258c449 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Feb 04 02:13:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 02:13:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489411.757760 (Exim 4.92) (envelope-from ) id 1pO83J-0001oH-CY; Sat, 04 Feb 2023 02:13:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489411.757760; Sat, 04 Feb 2023 02:13:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO83J-0001oA-8Y; Sat, 04 Feb 2023 02:13:17 +0000 Received: by outflank-mailman (input) for mailman id 489411; Sat, 04 Feb 2023 02:13:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO83I-0001o0-EH; Sat, 04 Feb 2023 02:13:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO83I-0006Ph-6h; Sat, 04 Feb 2023 02:13:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO83H-0002oT-PN; Sat, 04 Feb 2023 02:13:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pO83H-0000GB-Of; Sat, 04 Feb 2023 02:13:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dlh0q19pvs0zo1TdN3R2bZMhs59FY+QeOQlvM3LTokA=; b=dEtGU0/QiToZ1jzW1wilvyQtDL momzTkUYHDI+9ZuQ5DSeVDBenTJgpkbM50DfUVe0WhpxsAlzIlZXi91PJDFMh9KOuQzFOe7i79IOV 6OCV18bzHcrihvBb3d6ksMTAamdrwW3aVlivqBxti+k+SCqnmdwmSe4EfUB2eGX0s1ZQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176345: trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64::broken:regression xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-libvirt:leak-check/check:fail:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Sat, 04 Feb 2023 02:13:15 +0000 flight 176345 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176345/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 broken in 176317 build-armhf broken in 176317 test-amd64-i386-xl-qemut-win7-amd64 broken in 176317 build-armhf 4 host-install(4) broken in 176317 REGR. vs. 175447 build-armhf 3 syslog-server running in 176317 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken in 176317 pass in 176345 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken in 176317 pass in 176345 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 176317 pass in 176345 test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 176338 pass in 176345 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 176338 pass in 176345 test-amd64-i386-pair 10 xen-install/src_host fail in 176338 pass in 176345 test-amd64-i386-pair 11 xen-install/dst_host fail in 176338 pass in 176345 test-amd64-i386-libvirt 23 leak-check/check fail in 176338 pass in 176345 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176317 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 176338 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 176317 n/a build-armhf 5 capture-logs broken in 176317 blocked in 175447 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 176338 never pass test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved in 176317 n/a build-arm64-pvops 2 hosts-allocate starved in 176317 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 44 days Testing same since 176224 2023-01-26 22:14:43 Z 8 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken broken-job build-armhf broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Feb 04 04:15:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 04:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489425.757771 (Exim 4.92) (envelope-from ) id 1pO9wd-0006x0-8w; Sat, 04 Feb 2023 04:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489425.757771; Sat, 04 Feb 2023 04:14:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO9wd-0006wt-5I; Sat, 04 Feb 2023 04:14:31 +0000 Received: by outflank-mailman (input) for mailman id 489425; Sat, 04 Feb 2023 04:14:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO9wb-0006wh-DJ; Sat, 04 Feb 2023 04:14:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO9wb-0000kj-Bd; Sat, 04 Feb 2023 04:14:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pO9wa-0006pJ-QB; Sat, 04 Feb 2023 04:14:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pO9wa-0004V5-Pl; Sat, 04 Feb 2023 04:14:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oHLo30xeGK6s5LgE58EI6gtskWaaYXgAai7etaFqKT4=; b=e/H8dm9RC+EsDPKXWvxZGOsWj0 PZp9cH+OV6tbB3STQ7UuGltnnRI73iL9YhBzkobgVWmuqzGxYWBhHifRdjFOnXmoIBeRO96pe3QzO 0TlQkaEn2gJsQzcOaOZuT/B/sQD2qmXbnlbJQy3fQFnx2rmru/V/ewzqIn09snNCOr4E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176356: all pass - PUSHED X-Osstest-Versions-This: ovmf=7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f X-Osstest-Versions-That: ovmf=13b97736c876919b9786055829caaa4fa46984b7 From: osstest service owner Date: Sat, 04 Feb 2023 04:14:28 +0000 flight 176356 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176356/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f baseline version: ovmf 13b97736c876919b9786055829caaa4fa46984b7 Last test of basis 176348 2023-02-03 14:13:42 Z 0 days Testing same since 176356 2023-02-04 01:55:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yuan Yu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 13b97736c8..7623b4bf6a 7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 04 05:39:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 05:39:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489438.757782 (Exim 4.92) (envelope-from ) id 1pOBGi-0008OJ-A0; Sat, 04 Feb 2023 05:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489438.757782; Sat, 04 Feb 2023 05:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOBGi-0008OC-6X; Sat, 04 Feb 2023 05:39:20 +0000 Received: by outflank-mailman (input) for mailman id 489438; Sat, 04 Feb 2023 05:39:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOBGg-0008O6-S5 for xen-devel@lists.xen.org; Sat, 04 Feb 2023 05:39:18 +0000 Received: from wind.enjellic.com (wind.enjellic.com [76.10.64.91]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 418ac521-a44e-11ed-93b5-47a8fe42b414; Sat, 04 Feb 2023 06:39:15 +0100 (CET) Received: from wind.enjellic.com (localhost [127.0.0.1]) by wind.enjellic.com (8.15.2/8.15.2) with ESMTP id 3145cmjc010476; Fri, 3 Feb 2023 23:38:48 -0600 Received: (from greg@localhost) by wind.enjellic.com (8.15.2/8.15.2/Submit) id 3145clRD010475; Fri, 3 Feb 2023 23:38:47 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 418ac521-a44e-11ed-93b5-47a8fe42b414 Date: Fri, 3 Feb 2023 23:38:46 -0600 From: "Dr. Greg" To: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, xen-devel@lists.xen.org, linux-sgx@vger.kernel.org, tboot-devel@lists.sourceforge.net Cc: paul@paul-moore.com, casey@schaufler-ca.com, corbet@lwn.net Subject: Quixote/TSEM: A new security architecture and eco-system for Linux. Message-ID: <20230204053846.GA10404@wind.enjellic.com> Reply-To: "Dr. Greg" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.3 (wind.enjellic.com [127.0.0.1]); Fri, 03 Feb 2023 23:38:49 -0600 (CST) Good evening, I hope the week has gone well for everyone. On behalf of the Quixote team: Izzy the Golden Retriever, Maria, John and myself; I am pleased to announce the initial release of the Quixote/TSEM Trust Orchestration System. We believe it uniquely positions Linux to demonstrate a new approach to security and security co-processor architectures. Quixote/TSEM is based on the notion, that like all other physical phenomenon, the security state of a platform or workload can be mathematically modeled. The objective is to provide for Linux security what Docker did for Linux namespace technology. There are two major components to this architecture. TSEM is the Trusted Security Event Modeling system. It is a new Linux Security Module implementation, that at a conceptual level, is a blending of integrity measurement and mandatory access controls. It treats the LSM hooks as the basis set for a functional description of the security state of a system. Quixote is the userspace software stack that makes the TSEM LSM useful. It implements the concept of a Trust Orchestration System (TOS). A trust orchestration environment is designed to keep a platform or workload in a known trust state. It thus implements the notion of prospective trust rather than the retrospective trust model available with TPM based architectures. A patch series implementing the TSEM LSM has been submitted to the linux-security-module list for review and inclusion in the upstream kernel. The source code for the Quixote TOS and pre-compiled binaries for the userspace tooling can be found at the following URL: ftp://ftp.enjellic.com/pub/Quixote The source release includes a selection of TMA's that include Xen, SGX and micro-controller implementations. The kernel patches include a documentation file, that we believe, thoroughly discusses the rationale and implementation of the new architecture. To avoid further indemnifying my reputation for loquaciousness in e-mail, I will defer interested parties to that document for further discussion. The document is also included in the Quixote source code release for those who choose to download that. In addition to initiating a discussion on a different approach to security, we hope that this release keeps Casey Schaufler from turning more blue than he already is. Given that I had mentioned to him two months ago that a new LSM would become available, "in a couple of weeks", that may influence conversations on changes to the Linux LSM architecture that are being discussed. Such is the state of software development.... :-) I would be more than happy to field any additional questions that may be forthcoming. Best wishes for a pleasant weekend. As always, Dr. Greg The Quixote Project - Flailing at the Travails of Cybersecurity From xen-devel-bounces@lists.xenproject.org Sat Feb 04 09:55:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 09:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489463.757793 (Exim 4.92) (envelope-from ) id 1pOFFx-0003JY-N2; Sat, 04 Feb 2023 09:54:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489463.757793; Sat, 04 Feb 2023 09:54:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFFx-0003JR-JJ; Sat, 04 Feb 2023 09:54:49 +0000 Received: by outflank-mailman (input) for mailman id 489463; Sat, 04 Feb 2023 09:54:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFFw-0003JH-Ct; Sat, 04 Feb 2023 09:54:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFFw-0001Ce-7y; Sat, 04 Feb 2023 09:54:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFFv-0003vO-LN; Sat, 04 Feb 2023 09:54:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOFFv-00049o-Ks; Sat, 04 Feb 2023 09:54:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1yeGFVM9YXi6XK4MpopmIpyitgnx0JpTaq3EaWZ0FF0=; b=5LoEeorQesnMhw/Ufe8XsWnhL7 K5gSWh004zPcO+4rha9H7nQjdeIkg4hbu+4BllNrq9THxKGWDE+NLI3LaAtZzwtf4eggog+pgz2QY ATv8yZwqr05zwU0FxgPeTZQCDO/LXQhx6XEGkQxu49fxdlfwZr/Gn/IuOCGcAymZtvgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176357: trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:build-armhf::broken:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64::broken:regression xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64::broken:regression xen-4.17-testing:build-armhf:host-install(4):broken:regression xen-4.17-testing:build-armhf:syslog-server:running:regression xen-4.17-testing:test-amd64-amd64-qemuu-freebsd11-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:host-install(5):broken:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.17-testing:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-4.17-testing:build-armhf:capture-logs:broken:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Sat, 04 Feb 2023 09:54:47 +0000 flight 176357 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176357/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken in 176317 test-amd64-amd64-qemuu-freebsd11-amd64 broken in 176317 test-amd64-i386-xl-qemut-win7-amd64 broken in 176317 build-armhf 4 host-install(4) broken in 176317 REGR. vs. 175447 build-armhf 3 syslog-server running in 176317 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 5 host-install(5) broken in 176317 pass in 176357 test-amd64-i386-xl-qemut-win7-amd64 5 host-install(5) broken in 176317 pass in 176357 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 176317 pass in 176357 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176317 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-arndale 1 build-check(1) blocked in 176317 n/a build-armhf 5 capture-logs broken in 176317 blocked in 175447 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved in 176317 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved in 176317 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved in 176317 n/a build-arm64-pvops 2 hosts-allocate starved in 176317 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 44 days Testing same since 176224 2023-01-26 22:14:43 Z 8 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job build-armhf broken broken-job test-amd64-amd64-qemuu-freebsd11-amd64 broken broken-job test-amd64-i386-xl-qemut-win7-amd64 broken Not pushing. ------------------------------------------------------------ commit 2f8851c37f88e4eb4858e16626fcb2379db71a4f Author: Jason Andryuk Date: Thu Jan 26 11:00:24 2023 +0100 Revert "tools/xenstore: simplify loop handling connection I/O" I'm observing guest kexec trigger xenstored to abort on a double free. gdb output: Program received signal SIGABRT, Aborted. __pthread_kill_implementation (no_tid=0, signo=6, threadid=140645614258112) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt at ./nptl/pthread_kill.c:44 at ./nptl/pthread_kill.c:78 at ./nptl/pthread_kill.c:89 at ../sysdeps/posix/raise.c:26 at talloc.c:119 ptr=ptr@entry=0x559fae724290) at talloc.c:232 at xenstored_core.c:2945 (gdb) frame 5 at talloc.c:119 119 TALLOC_ABORT("Bad talloc magic value - double free"); (gdb) frame 7 at xenstored_core.c:2945 2945 talloc_increase_ref_count(conn); (gdb) p conn $1 = (struct connection *) 0x559fae724290 Looking at a xenstore trace, we have: IN 0x559fae71f250 20230120 17:40:53 READ (/local/domain/3/image/device-model-dom id ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 0 0 msec 10000 credit 1000000 reserve 0 disc ard wrl: dom 3 0 msec 10000 credit 1000000 reserve 0 disc ard OUT 0x559fae71f250 20230120 17:40:53 ERROR (ENOENT ) wrl: dom 0 1 msec 10000 credit 1000000 reserve 100 disc ard wrl: dom 3 1 msec 10000 credit 1000000 reserve 100 disc ard IN 0x559fae71f250 20230120 17:40:53 RELEASE (3 ) DESTROY watch 0x559fae73f630 DESTROY watch 0x559fae75ddf0 DESTROY watch 0x559fae75ec30 DESTROY watch 0x559fae75ea60 DESTROY watch 0x559fae732c00 DESTROY watch 0x559fae72cea0 DESTROY watch 0x559fae728fc0 DESTROY watch 0x559fae729570 DESTROY connection 0x559fae724290 orphaned node /local/domain/3/device/suspend/event-channel deleted orphaned node /local/domain/3/device/vbd/51712 deleted orphaned node /local/domain/3/device/vkbd/0 deleted orphaned node /local/domain/3/device/vif/0 deleted orphaned node /local/domain/3/control/shutdown deleted orphaned node /local/domain/3/control/feature-poweroff deleted orphaned node /local/domain/3/control/feature-reboot deleted orphaned node /local/domain/3/control/feature-suspend deleted orphaned node /local/domain/3/control/feature-s3 deleted orphaned node /local/domain/3/control/feature-s4 deleted orphaned node /local/domain/3/control/sysrq deleted orphaned node /local/domain/3/data deleted orphaned node /local/domain/3/drivers deleted orphaned node /local/domain/3/feature deleted orphaned node /local/domain/3/attr deleted orphaned node /local/domain/3/error deleted orphaned node /local/domain/3/console/backend-id deleted and no further output. The trace shows that DESTROY was called for connection 0x559fae724290, but that is the same pointer (conn) main() was looping through from connections. So it wasn't actually removed from the connections list? Reverting commit e8e6e42279a5 "tools/xenstore: simplify loop handling connection I/O" fixes the abort/double free. I think the use of list_for_each_entry_safe is incorrect. list_for_each_entry_safe makes traversal safe for deleting the current iterator, but RELEASE/do_release will delete some other entry in the connections list. I think the observed abort is because list_for_each_entry has next pointing to the deleted connection, and it is used in the subsequent iteration. Add a comment explaining the unsuitability of list_for_each_entry_safe. Also notice that the old code takes a reference on next which would prevents a use-after-free. This reverts commit e8e6e42279a5723239c5c40ba4c7f579a979465d. This is XSA-425/CVE-2022-42330. Fixes: e8e6e42279a5 ("tools/xenstore: simplify loop handling connection I/O") Signed-off-by: Jason Andryuk Reviewed-by: Juergen Gross Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Feb 04 10:25:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 10:25:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489475.757804 (Exim 4.92) (envelope-from ) id 1pOFji-0007Km-7m; Sat, 04 Feb 2023 10:25:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489475.757804; Sat, 04 Feb 2023 10:25:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFji-0007Kf-4q; Sat, 04 Feb 2023 10:25:34 +0000 Received: by outflank-mailman (input) for mailman id 489475; Sat, 04 Feb 2023 10:25:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFjh-0007KV-12; Sat, 04 Feb 2023 10:25:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFjg-0001xR-VW; Sat, 04 Feb 2023 10:25:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOFjg-0004hY-Ev; Sat, 04 Feb 2023 10:25:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOFjg-0005Se-EU; Sat, 04 Feb 2023 10:25:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T+mupwooxKkUQ8L9IqjcLKH4RiZehVVdJbMrV9SBAEM=; b=058SsWO5j+BvymblKmHSlRkUll Dkr2PJa2SdEltx430X5wEBm4UiKeW3swrdkONBWwc4VWdi++d1KyvgEc3izLDA/xCMrPuZI/rc2KE D7g1p1dc/Ha0gBxGa9G6KVBBniJuBU4O9wOJAHluxUcDsWeYDQlrq0mabksP6WKXscK0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176359: all pass - PUSHED X-Osstest-Versions-This: ovmf=4d37059d8e1eeda124270a158416795605327cbd X-Osstest-Versions-That: ovmf=7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f From: osstest service owner Date: Sat, 04 Feb 2023 10:25:32 +0000 flight 176359 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176359/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4d37059d8e1eeda124270a158416795605327cbd baseline version: ovmf 7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f Last test of basis 176356 2023-02-04 01:55:46 Z 0 days Testing same since 176359 2023-02-04 04:40:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7623b4bf6a..4d37059d8e 4d37059d8e1eeda124270a158416795605327cbd -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 04 11:12:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 11:12:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489485.757815 (Exim 4.92) (envelope-from ) id 1pOGSo-0004cH-OI; Sat, 04 Feb 2023 11:12:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489485.757815; Sat, 04 Feb 2023 11:12:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOGSo-0004cA-LQ; Sat, 04 Feb 2023 11:12:10 +0000 Received: by outflank-mailman (input) for mailman id 489485; Sat, 04 Feb 2023 11:12:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOGSo-0004c0-0v; Sat, 04 Feb 2023 11:12:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOGSn-0002tt-Tx; Sat, 04 Feb 2023 11:12:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOGSn-0005nE-Fb; Sat, 04 Feb 2023 11:12:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOGSn-0005xO-Ea; Sat, 04 Feb 2023 11:12:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sm0hv3PT7lsatkXNY8ktALYUhGJbNiVt9Zi3PDC0r6I=; b=E6C4hUh916jVTTVOdII1YckQXS MZnMoxmAV3FG/gc4QXJVwbh81wNnD+bDymBkzUdA/rMWcZvpvbP1PKyG0um8SpgN2lHOjtrJuIaq/ 5fEqoRoVgJ+lQmb4FTke63emwEf3b/g2T6Z4m2nnGgux52Dh+idKs+63UsY0oOO/s6aQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176349: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:regression xen-unstable:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Sat, 04 Feb 2023 11:12:09 +0000 flight 176349 xen-unstable real [real] flight 176360 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176349/ http://logs.test-lab.xenproject.org/osstest/logs/176360/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-raw 7 xen-install fail REGR. vs. 175994 Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 176360-retest test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176360-retest Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 175987 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 15 days Failing since 176003 2023-01-20 17:40:27 Z 14 days 27 attempts Testing same since 176349 2023-02-03 14:25:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1322 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 04 12:00:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 12:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489502.757829 (Exim 4.92) (envelope-from ) id 1pOHD8-0001Ot-Ig; Sat, 04 Feb 2023 12:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489502.757829; Sat, 04 Feb 2023 12:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOHD8-0001Om-F0; Sat, 04 Feb 2023 12:00:02 +0000 Received: by outflank-mailman (input) for mailman id 489502; Sat, 04 Feb 2023 12:00:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOHD7-0001CV-GL for xen-devel@lists.xenproject.org; Sat, 04 Feb 2023 12:00:01 +0000 Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [2607:f8b0:4864:20::930]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 720a1cfe-a483-11ed-93b5-47a8fe42b414; Sat, 04 Feb 2023 12:59:59 +0100 (CET) Received: by mail-ua1-x930.google.com with SMTP id g12so1409603uae.6 for ; Sat, 04 Feb 2023 03:59:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 720a1cfe-a483-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=npKOVDePKj/bCzuGpr6GKG9ommD7W1J+s+nLzWagcRI=; b=AJVmGIv7l+fhRALO+zba2OIMeIlEfsiKhmQUg4OQawLeWkW7q4RgOXuCly6AVh+i8z 4X8l5v8RzLjafOlnNIfE/gGTaqoadnO5IpcgCYoHEyoOOWXg/TKI39so6zOWbF5ddXrs vNRhXcOGDqS2aGDvWUByvkqpkDpiGbe2o079ShjL3KaSoN5LRVpRnqGfb2gmGtl0BJPz 61hEgm/HTKfk+kK25fkjMogvE1Se8FF44q6Cw21rmgTXS98T9b09up9aJT/Lqgo7JJ1w 7yN+iYZSgGsZSGRyPomBbCP4wNom1/qbcHDqVTD3F1XPTXj8Gi3TdIvdVyz67ZrSN/E3 7slQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=npKOVDePKj/bCzuGpr6GKG9ommD7W1J+s+nLzWagcRI=; b=0s2xFGyBMFT6MxFGd2uqLeGFj6Mo6XD/9A4Qp5UYYDDiAWuTXZ6OUH5wlbCdgWNJAI M1YlgjtLPIded7uwRFqzzxysAPO2ahEnVVV+a3ZErpHGOa5ITRyM5qlKHTM2qG040Msd 7cwuMn9vGrxeVGIU/ry3xdTu4L4aqgaPoarQOrrsui/J9T5WIVvlMy+WMC485J/0xLO/ VBdh4bbWQWbDDKDyp0B5x14Sr7c4yByZkMtj9PHe4R0oBLM9+IHe5/j353E+kr49WrRH 2bVhvs+Vf1fBASveWn/+IVQXZ/PHW0Pdqfx3AxSfR0mJXMRMhsBjsBrYOKmsfjkaDBoU pbTg== X-Gm-Message-State: AO0yUKXUsTQxKIC3x+OyI2aO/R/RZeHw4LkUCifAcV+ihsJ/bQZUGe51 mepnixN5zq4+6kOLfJHYgiYmhtBSTKp6/tw4QoI= X-Google-Smtp-Source: AK7set+fCuSjSSg2MUWcdViET9csRzRDeif8bwooqKV9K8ZyhHKXMLEBhzZFUAZeA6sXYr9H6aFfEQSE5AasO+0UOSA= X-Received: by 2002:a9f:3f0c:0:b0:658:2091:77a4 with SMTP id h12-20020a9f3f0c000000b00658209177a4mr1886424uaj.74.1675511997462; Sat, 04 Feb 2023 03:59:57 -0800 (PST) MIME-Version: 1.0 References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> In-Reply-To: From: Alistair Francis Date: Sat, 4 Feb 2023 21:59:31 +1000 Message-ID: Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff To: Bobby Eshleman Cc: Julien Grall , Andrew Cooper , Oleksii , xen-devel@lists.xenproject.org, Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman Content-Type: text/plain; charset="UTF-8" On Thu, Feb 2, 2023 at 3:34 AM Bobby Eshleman wrote: > > On Wed, Feb 01, 2023 at 09:06:21AM +0000, Julien Grall wrote: > > Hi Andrew, > > > > On 01/02/2023 00:21, Andrew Cooper wrote: > > > On 31/01/2023 11:17 pm, Alistair Francis wrote: > > > > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: > > > > > On 31/01/2023 11:44, Alistair Francis wrote: > > > > > > On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > > > > > > > > > > > From my understanding, on RISC-V, the use of PC-relative address is > > > > > only guaranteed with medany. So if you were going to change the cmodel > > > > > (Andrew suggested you would), then early_*() may end up to be broken. > > > > > > > > > > This check serve as a documentation of the assumption and also help the > > > > > developer any change in the model and take the appropriate action to > > > > > remediate it. > > > > > > > > > > > I think this is safe to remove. > > > > > Based on what I wrote above, do you still think this is safe? > > > > With that in mind it's probably worth leaving in then. Maybe the > > > > comment should be updated to make it explicit why we want this check > > > > (I find the current comment not very helpful). > > > > > > The presence of this check pre-supposes that Xen will always relocate > > > itself, and this simply not true. XIP for example typically does not > > > > > > Furthermore it's not checking the property wanted. The way C is > > > compiled has no bearing on what relocation head.S uses to call it. > > > > I think we are still cross-talking each other because this is not my point. > > I am not sure how to explain differently... > > > > This check is not about how head.S call early_*() but making sure the C > > function can be executed with the MMU off. In which case, you will likely > > have VA != PA. > > > > In theory head.S could apply some relocations before hand, but it may be too > > complicated to do it before calling early_*(). > > > > > > > > It is a given that we compile the hypervisor with a consistent code > > > model, meaning that the properly actually making the check do what is > > > wanted is also the property that means it is not needed in the first place. > > > > See above. > > > > > > > > This check is literally not worth the bytes it's taking up on disk, and > > > not worth the added compiler time, nor the wasted time of whoever comes > > > to support something like XIP in the future finds it to be in the way. > > > Xen as a whole will really genuinely function as intended in models > > > other than medany, and it demonstrates a misunderstanding of the topic > > > to put in such a check to begin with. > > > > Then enlight me :). So far it looks more like you are not understanding my > > point: I am talking about C function call with MMU off (e.g. VA != PA) and > > you are talking about Xen as a whole. > > > > I guess the only way to really know is to implement a different model. At > > which point there are three possible outcome: > > 1) We had the compiler check, it fired and the developper will take action > > to fix it (if needed). > > 2) We have no compiler check, the developper knew what to do it and fixed > > it. > > 3) We have no compiler check, the developper where not aware of the > > problem and we will waste time. > > > > I tend to favor the check because outcome #1 is so desirable, and I do > think that checking for medany is sufficient for the bulk of future > work. But that said, I do see Andrew's point now. > > If Xen were to a) not relocate itself, b) be executed under the 2GB > range, c) be compiled under medlow, and d) the MMU is off or on but Xen > is identity mapped, then C functions should still be safe to call in > early boot. Checking medany does protect developers from accidental bad > configuration now, but it is a somewhat imperfect proxy. Yeah, I agree. It probably is worth leaving the check in for now, even if it's imperfect. We can always remove it in the future if required. Alistair > > One alternative that may be more long term is for the self relocation > code to be Kconfig-able and to require/force medany. Anyone wanting to > develop something like XIP could deselect relocation, which would allow > them to use medlow if they wanted/needed. The early C functions would > still be callable under both in this case. The help strings could offer > explanation too. > > Thanks, > Bobby > > > Even if you disagree with the check, then I think 1 is still the best > > because it would explain our assumption. Yes it may waste a few minutes to > > the developer switching the model. But that probably nothing compare to the > > time you could waste if you don't notice it. > > > > Anyway, Alistair has now all the information to take an informative > > decision. > > > > Cheers, > > > > -- > > Julien Grall > > From xen-devel-bounces@lists.xenproject.org Sat Feb 04 13:00:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 13:00:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489519.757842 (Exim 4.92) (envelope-from ) id 1pOI9Z-0000Uv-UW; Sat, 04 Feb 2023 13:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489519.757842; Sat, 04 Feb 2023 13:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOI9Z-0000Uo-Rm; Sat, 04 Feb 2023 13:00:25 +0000 Received: by outflank-mailman (input) for mailman id 489519; Sat, 04 Feb 2023 13:00:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOI9Y-0000Ue-9G; Sat, 04 Feb 2023 13:00:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOI9Y-0005UE-6v; Sat, 04 Feb 2023 13:00:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOI9X-0002dE-Rk; Sat, 04 Feb 2023 13:00:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOI9X-00088X-RK; Sat, 04 Feb 2023 13:00:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8f/t8OdHGox0xuuxl6qaYLB7YpDL2WcOldwrm+wGXys=; b=YwSu2x7tJtAQ+dFGkbcdMC5yip PueF/hvehhhmHrVU3PzcSlv5WPG1o/QtI7TOfr0EcX/eI1MZrpOibRy/u0V0+QYa7JQZ1u37FSWAX /DCX3sa3DozoutdNwKFpBZBqNPs2V8ZEdwVSc3YipmOOdOBvyS2jVe/XCdvBa+1iicF4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176352: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=5736527050cfcc5b92521d79fe87b4883059d864 X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Sat, 04 Feb 2023 13:00:23 +0000 flight 176352 qemu-mainline real [real] flight 176366 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176352/ http://logs.test-lab.xenproject.org/osstest/logs/176366/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 5736527050cfcc5b92521d79fe87b4883059d864 baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 1 days Testing same since 176352 2023-02-03 17:40:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Emanuele Giuseppe Esposito Emilio Cota Evgeny Iakovlev Gerd Hoffmann Hanna Reitz Idan Horowitz Keith Packard Kevin Wolf Marc-André Lureau Mark Cave-Ayland Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1937 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 04 14:02:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 14:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489531.757861 (Exim 4.92) (envelope-from ) id 1pOJ77-0007Nx-J0; Sat, 04 Feb 2023 14:01:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489531.757861; Sat, 04 Feb 2023 14:01:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOJ77-0007Nq-Fc; Sat, 04 Feb 2023 14:01:57 +0000 Received: by outflank-mailman (input) for mailman id 489531; Sat, 04 Feb 2023 14:01:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOJ75-0007Lb-Q9 for xen-devel@lists.xenproject.org; Sat, 04 Feb 2023 14:01:55 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78c5f178-a494-11ed-93b5-47a8fe42b414; Sat, 04 Feb 2023 15:01:52 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 7875120150; Sat, 4 Feb 2023 15:01:50 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qxk5DFMxO5AT; Sat, 4 Feb 2023 15:01:49 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2BB2620135; Sat, 4 Feb 2023 15:01:49 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOJ6y-0003Pd-2J; Sat, 04 Feb 2023 15:01:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78c5f178-a494-11ed-93b5-47a8fe42b414 Date: Sat, 4 Feb 2023 15:01:48 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Message-ID: <20230204140148.pmhv2vnsb7ejobji@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-2-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Hello, Juergen Gross, le ven. 03 févr. 2023 10:18:03 +0100, a ecrit: > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value) > +{ > + char path[BUFFER_SIZE]; > + char *msg; > + char *str; > + > + xenbus_build_path(dir, node, path); > + msg = xenbus_read(xbt, path, &str); > + if ( msg ) > + return msg; > + > + sscanf(str, "%u", value); I'd say better check that sscanf returned 1 and otherwise return an error. Otherwise *value may end up uninitialized. > + free(str); > + > + return NULL; > +} From xen-devel-bounces@lists.xenproject.org Sat Feb 04 15:07:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 15:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489546.757878 (Exim 4.92) (envelope-from ) id 1pOK83-0006Bc-JN; Sat, 04 Feb 2023 15:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489546.757878; Sat, 04 Feb 2023 15:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOK83-0006BV-FI; Sat, 04 Feb 2023 15:06:59 +0000 Received: by outflank-mailman (input) for mailman id 489546; Sat, 04 Feb 2023 15:06:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOK82-0006BJ-I6; Sat, 04 Feb 2023 15:06:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOK82-0008LV-Fc; Sat, 04 Feb 2023 15:06:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOK81-0000L9-VX; Sat, 04 Feb 2023 15:06:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOK81-0004dj-Uv; Sat, 04 Feb 2023 15:06:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BAJLxPy72boX9/NIshrdLBu8m9AJJUluNxsIBvcOz5k=; b=oxtNxkjbeBHai+joe7KZeIMliL EAeqfLioQrD25ZXy9y00gyh1PhLOiGOU4M4aTN78KnMxbyYGG7uK0tqWNdfNStT9bMF4gNpiXubaR SnFOXsYDlMktqU99mI0MqCleTZeliQR1CdYS9RU3lNS0aZiD6ZjQRogXgLPSTPfgTYcw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176363: all pass - PUSHED X-Osstest-Versions-This: ovmf=7c138e400862a3a742489ca6f21d31afa9a3dd8a X-Osstest-Versions-That: ovmf=4d37059d8e1eeda124270a158416795605327cbd From: osstest service owner Date: Sat, 04 Feb 2023 15:06:57 +0000 flight 176363 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176363/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c138e400862a3a742489ca6f21d31afa9a3dd8a baseline version: ovmf 4d37059d8e1eeda124270a158416795605327cbd Last test of basis 176359 2023-02-04 04:40:49 Z 0 days Testing same since 176363 2023-02-04 11:26:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4d37059d8e..7c138e4008 7c138e400862a3a742489ca6f21d31afa9a3dd8a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 04 17:11:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 17:11:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489566.757895 (Exim 4.92) (envelope-from ) id 1pOM4U-0003rW-AC; Sat, 04 Feb 2023 17:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489566.757895; Sat, 04 Feb 2023 17:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOM4U-0003rP-6d; Sat, 04 Feb 2023 17:11:26 +0000 Received: by outflank-mailman (input) for mailman id 489566; Sat, 04 Feb 2023 17:11:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOM4S-0003rF-IX; Sat, 04 Feb 2023 17:11:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOM4S-0003AE-GC; Sat, 04 Feb 2023 17:11:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOM4S-0007uQ-27; Sat, 04 Feb 2023 17:11:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOM4S-0006Je-1d; Sat, 04 Feb 2023 17:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Cd/qBVe5GkzzaWK5JJph+yqFf7Z2y/jfcxcxzHc9dZo=; b=EX6iO87xvMI9WVT7Ub1y6Pr8fE tPFNFfntE9gjauuP8DrnaLC/+fKQ9dvuNuft563NNEsiRX2NeLzODeUC1XTNTY+vFPAgXdpoYWwAN yZeInOzIN/qMJA/iBhQr5c6sRS+1ALVb23f3RReMPrcNp7rZEf8SX3agGxJQej6+VWWg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176355: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=0136d86b78522bbd5755f8194c97a987f0586ba5 X-Osstest-Versions-That: linux=66a87fff1a87c260452f5a57123891ca5258c449 From: osstest service owner Date: Sat, 04 Feb 2023 17:11:24 +0000 flight 176355 linux-linus real [real] flight 176371 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176355/ http://logs.test-lab.xenproject.org/osstest/logs/176371/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 176371-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176344 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176344 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176344 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176344 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176344 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 0136d86b78522bbd5755f8194c97a987f0586ba5 baseline version: linux 66a87fff1a87c260452f5a57123891ca5258c449 Last test of basis 176344 2023-02-03 06:54:13 Z 1 days Testing same since 176355 2023-02-04 00:13:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alex Hung Alexey Khoroshilov Amit Engel Andreas Schwab Andrew Morton Anton Gusev Ard Biesheuvel Arnd Bergmann Bart Van Assche Ben Skeggs Borislav Petkov (AMD) Catalin Marinas Chaitanya Kumar Borah Christoph Hellwig Daniel Miess Daniel Wagner Daniel Wheeler Danilo Krummrich Dave Airlie David Hildenbrand Diogo Ivo Douglas Anderson Eugen Hristev Evan Quan Fabian Vogt Fedor Pchelkin George Shen Graham Sider Guo Ren Guo Ren Hans Verkuil Holger Hoffsttte Ilya Dryomov Isaac J. Manjarres James Morse Jani Nikula Jann Horn Javier Martinez Canillas Jens Axboe John Harrison John Paul Adrian Glaubitz Kefeng Wang Kirill A. Shutemov Liam Howlett Liam R. Howlett Linus Torvalds Liu Xiaodong Longlong Xia Lyude Paul Mario Limonciello Matthew Wilcox (Oracle) Maurizio Lombardi Maxime Ripard Michal Hocko Mike Kravetz Mike Rapoport (IBM) Miko Larsson Ming Lei msizanoen Nhat Pham Nicholas Kazlauskas Nicolas Chauvet Palmer Dabbelt Pengfei Xu Peter Xu Phillip Lougher Randy Dunlap Rob Clark Rodrigo Vivi Rutvij Gajjar Samuel Holland Satyanarayana ReddyTVN Shin'ichiro Kawasaki Stephen Boyd Thomas Zimmermann Tim Huang Tom Saeger Tvrtko Ursulin Vlastimil Babka Wei Yang Xiubo Li ye xingchen Yiqing Yao Yu Kuai Yu Zhao Zach O'Keefe Zhaoyang Huang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 66a87fff1a87..0136d86b7852 0136d86b78522bbd5755f8194c97a987f0586ba5 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Feb 04 19:23:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 19:23:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489581.757911 (Exim 4.92) (envelope-from ) id 1pOO85-0001BB-P3; Sat, 04 Feb 2023 19:23:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489581.757911; Sat, 04 Feb 2023 19:23:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOO85-0001B4-Lx; Sat, 04 Feb 2023 19:23:17 +0000 Received: by outflank-mailman (input) for mailman id 489581; Sat, 04 Feb 2023 19:23:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOO84-0001Au-H6; Sat, 04 Feb 2023 19:23:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOO84-0006EB-F7; Sat, 04 Feb 2023 19:23:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOO83-000791-OS; Sat, 04 Feb 2023 19:23:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOO83-0007dK-O1; Sat, 04 Feb 2023 19:23:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n6U9qPlMyjIfbqIMtxcPwW58B9/hzC0cV16wf6xl0P8=; b=CBHviWKME5mtHWWeNmdo7/KObF VZkCEo4sD+/LOsIXUSdwIhvV0MzQk/C22QWSJYW+k1xWs0C6qTVXDohJumWJyQkYiTt1eR3X36yqV NGzUJ89Cl5oFMSVTGX/5TDBbcqk+sM1IWRGNqhDt4Zl3m25I9O0WLS6hvjsJuRS/NgBM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176358: regressions - trouble: fail/pass/starved X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=0f350a4d070e952b0ecc7631708478ddfd43ba3f X-Osstest-Versions-That: libvirt=f2d379e7cb802f922409c35e4831ee52a2162486 From: osstest service owner Date: Sat, 04 Feb 2023 19:23:15 +0000 flight 176358 libvirt real [real] flight 176373 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176358/ http://logs.test-lab.xenproject.org/osstest/logs/176373/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 176343 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 0f350a4d070e952b0ecc7631708478ddfd43ba3f baseline version: libvirt f2d379e7cb802f922409c35e4831ee52a2162486 Last test of basis 176343 2023-02-03 04:20:20 Z 1 days Testing same since 176358 2023-02-04 04:21:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jim Fehlig jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0f350a4d070e952b0ecc7631708478ddfd43ba3f Author: Jim Fehlig Date: Thu Feb 2 11:04:20 2023 -0700 tools: Fix detection of remote libvirt access in virt-qemu-sev-validate The VM's firmware path is not extracted from the XML when invoking virt-qemu-sev-validate in insecure mode and connecting to the local libvirt virt-qemu-sev-validate --insecure --tk tek-tik.bin --domain test-sev-es ERROR: Cannot access firmware path remotely The test for remote access compares the return value from socket.gethostname() to the return value from conn.getHostname(). The former doesn't always return the fqdn, whereas the latter does. Use socket.getfqdn() instead. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé commit 8eb54255ec9fb933902322c4e0ed4b21cb8a5bf4 Author: Jim Fehlig Date: Thu Feb 2 11:00:18 2023 -0700 docs: Fix examples in virt-qemu-sev-validate man page Some of the examples refer to virt-dom-sev-validate. Replace them with the proper name. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé From xen-devel-bounces@lists.xenproject.org Sat Feb 04 21:16:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 21:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489601.757938 (Exim 4.92) (envelope-from ) id 1pOPsj-00059b-0y; Sat, 04 Feb 2023 21:15:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489601.757938; Sat, 04 Feb 2023 21:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOPsi-00059U-UM; Sat, 04 Feb 2023 21:15:32 +0000 Received: by outflank-mailman (input) for mailman id 489601; Sat, 04 Feb 2023 21:15:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOPsh-00059K-Sy; Sat, 04 Feb 2023 21:15:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOPsh-0000JO-Rq; Sat, 04 Feb 2023 21:15:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOPsh-0003P8-Fz; Sat, 04 Feb 2023 21:15:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOPsh-0002vk-Fa; Sat, 04 Feb 2023 21:15:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p38ZEoxgfDA5ZXNy4UoU4n4PZozke2dQ2uRV6D+fjis=; b=iB1IyNkfQneWWbKcbsLyrvDHlr wcLYRAzZLVHOJmebo/pq5J+de+8SZCtfyhsPxcpghETtg/mfgLhYq/WvFvRQanlfj+c1742gxYwUs tRSlSZtLv0tn4aJ4cw9vVxa/lq6ACE9LED4/tKW/rIkex3d/6UcmFfJ3z8Vl9fIY6l94=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176370: all pass - PUSHED X-Osstest-Versions-This: ovmf=9d669016d968b0f3e17ce7df16ae51d85b0adfcf X-Osstest-Versions-That: ovmf=7c138e400862a3a742489ca6f21d31afa9a3dd8a From: osstest service owner Date: Sat, 04 Feb 2023 21:15:31 +0000 flight 176370 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176370/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9d669016d968b0f3e17ce7df16ae51d85b0adfcf baseline version: ovmf 7c138e400862a3a742489ca6f21d31afa9a3dd8a Last test of basis 176363 2023-02-04 11:26:05 Z 0 days Testing same since 176370 2023-02-04 15:12:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Jan Bobek Jiewen Yao Min M Xu Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7c138e4008..9d669016d9 9d669016d968b0f3e17ce7df16ae51d85b0adfcf -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 04 22:47:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Feb 2023 22:47:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489622.757958 (Exim 4.92) (envelope-from ) id 1pORJN-0006n8-Ok; Sat, 04 Feb 2023 22:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489622.757958; Sat, 04 Feb 2023 22:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pORJN-0006n1-Lz; Sat, 04 Feb 2023 22:47:09 +0000 Received: by outflank-mailman (input) for mailman id 489622; Sat, 04 Feb 2023 22:47:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pORJM-0006mr-7q; Sat, 04 Feb 2023 22:47:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pORJM-0002Sy-5z; Sat, 04 Feb 2023 22:47:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pORJL-00084G-Rm; Sat, 04 Feb 2023 22:47:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pORJL-0003oJ-RK; Sat, 04 Feb 2023 22:47:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rtmKI+LV+BcX+QGYoYwxER8bWcCgS00ZfJon3CIRH+A=; b=OiG7zcj5nqOi/f0kJSojV46DIz Rvb8JF68Vb8m/hpbgWhVBGBTAtwSRAFwG2aWqeOzye8NMflbu/0H43RomFgYjIxfsbOVSJHl11VHE bCyyPdrcfcLX6IOsiMiNhvvUhKf4+PP9zTnL0kE8ktetowbsvZBw3vwoiZyac1RWn6Pk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176361: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f X-Osstest-Versions-That: xen=c4972a4272690384b15d5706f2a833aed636895e From: osstest service owner Date: Sat, 04 Feb 2023 22:47:07 +0000 flight 176361 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176361/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176357 pass in 176361 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176357 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175447 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175447 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176357 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176357 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f baseline version: xen c4972a4272690384b15d5706f2a833aed636895e Last test of basis 175447 2022-12-22 00:40:06 Z 44 days Testing same since 176224 2023-01-26 22:14:43 Z 9 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c4972a4272..2f8851c37f 2f8851c37f88e4eb4858e16626fcb2379db71a4f -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Sun Feb 05 04:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 04:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489669.758003 (Exim 4.92) (envelope-from ) id 1pOWKz-0006EJ-9B; Sun, 05 Feb 2023 04:09:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489669.758003; Sun, 05 Feb 2023 04:09:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWKz-0006Dv-2w; Sun, 05 Feb 2023 04:09:09 +0000 Received: by outflank-mailman (input) for mailman id 489669; Sun, 05 Feb 2023 04:09:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWKx-0006Dp-K2 for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 04:09:08 +0000 Received: from esa6.hc2706-39.iphmx.com (esa6.hc2706-39.iphmx.com [216.71.137.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d19caf28-a50a-11ed-933c-83870f6b2ba8; Sun, 05 Feb 2023 05:09:03 +0100 (CET) Received: from mail-oa1-f71.google.com ([209.85.160.71]) by ob1.hc2706-39.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Feb 2023 23:08:59 -0500 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-163aaf19aecso4941292fac.15 for ; Sat, 04 Feb 2023 20:08:59 -0800 (PST) Received: from mozz.bu.edu (mozz.bu.edu. [128.197.127.33]) by smtp.gmail.com with ESMTPSA id x11-20020a05620a448b00b0072c01a3b6aasm5031450qkp.100.2023.02.04.20.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Feb 2023 20:08:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d19caf28-a50a-11ed-933c-83870f6b2ba8 X-IronPort-RemoteIP: 209.85.160.71 X-IronPort-MID: 260002417 X-IronPort-Reputation: None X-IronPort-Listener: OutgoingMail X-IronPort-SenderGroup: RELAY_GSUITE X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:o7ipUawOjs9y91eAYMJ6t+dzxyrEfRIJ4+MujC+fZmUNrF6WrkVWx mpMXDjSM/aMYDf1LYhwat7lp0hT7MfUn9BkTQo+qC00HyNBpPSeOdnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9j8kkPnSHdIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYz18B56r8ks156yo4G9A5TTSWNgQ1LPgvyhNZH4gDfzpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZGBiuFIPM0SRqkEqShgJ70oOHKF0hXG7Ktm+t4sZJ N1l7fRcQOqyV0HGsL11vxJwSkmSMUDakVNuzLfWXcG7liX7n3XQL/pGBXwIO9cj4cBLMD9B5 6xEDTlTS0qlrrfjqF67YrEEasULKcDqOMYYsyglw26AS/khRp/HTuPB4towMDUY3JgfW6aDI ZNHMXwwNXwsYDUWUrsTIJs6jOGknFH1bntVpE/9Sa8fuTaLlFQrjOGyWDbTUtqxHstLpB/Gm jP95WSoMAxZJvmhlDXQpxpAgceKx0sXQrk6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL FYbkhfCtoA3/U2vC970Bli2/yfCsRkbVN5dVeY97Wlh15bp3upQPUBcJhYpVTDsnJ5eqeACv rNRo+7UOA== IronPort-HdrOrdr: A9a23:/Y4xZqtC1AzKSxfejIPXBUAm7skDoNV00zEX/kB9WHVpmwKj5q STdZMgpGPJYVMqMk3I9urwXpVoLUmsl6KdpLNhRotKPzOWxVdAUrsSlLcKqgeIc0aOldK1l5 0QCZSWYOeRMbEQt7ec3ODXKadE/PC3tIqFv6Px9UtMcC1dQ51czm5Ce3mm+45NKDWux6BVKH NR3KR6TkKbCAwqhw2AaRg4Y9Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bu.edu; s=s1gsbu; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IOvqN3WejMEJLJDUyDO4/PFLr/b6LzRjKv9Yr9nPTE8=; b=aN6T2mk2T6GtehZIfi/g96OZW+dXClvobi5ThTY61Ag1KE2jshi2nyCYulicTs1iDT vPfV3Ty2lKYS0a1P8VJR99ACPU6Kzpl1Yi2SJOrEv0WVN+UgRPBtioNaBN1de5PYM7h3 zzSuYRm/5OSX1PdIRm33dp5QzGsFyhdDq6sEHweuKg0CVEYHl1CslAR62OqLWsQj/yxq ahEo2iEiWHLO4exDq6MWdHTqYfb1Xac9nOdTG59KMh42ud2HKQE6uxtZwc2WKDsJCWp7 dqUxgpkx0Sy/t9YhA3KX+ftYjWTtHDA0+OiMibGrKFS1chTiZkLmfdlChsJgD3QSsPXT UTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IOvqN3WejMEJLJDUyDO4/PFLr/b6LzRjKv9Yr9nPTE8=; b=KWLzY/0eYY4AyjAmokF62gmipl6A+nZgcZYiYakcdMijSOGirku1uNzf9iMDEhypKd 0ioeezBRE7CVKowiNhZMHkdfejJmFCHA1VfiQI+CrbWM6p0PnoqYXT5LsXW01e/jwQPV 7peUuyz7uWbptBb71z7ji92jbgXWmcQK/AMQN7ybMsUH2GTMvryL0EEdEgotE9sYiCq0 2NninnHf1rKk1lgSjB4C/ITXFiULZ/o5PsPiLMlMb3FP97g3WTRe3VKq3quizX1JM2JM 2tUi8hAFGg5hgAQvdMPJoLtp1YBd10JHvV0SMz7w39WIgFDYf9PNG88V1S/qnTN5jdrw sk9g== X-Gm-Message-State: AO0yUKXt1iiytUwgul4sOEzXAdRMiJdra1dZVVGZRScG/rhwg+HfrppN NMf546NdfPsmBSptf83pis3p1hVZM7UZhj+Homj47bmTYm+jaVxerCjql6LG9urg0XZG2mD9xwK 15TVulG3ePDfEXTw8nm/P7YCRjvNsiKdjCN58+6KVzg== X-Received: by 2002:ac8:7770:0:b0:3b9:bc8c:c20c with SMTP id h16-20020ac87770000000b003b9bc8cc20cmr11909895qtu.23.1675570127799; Sat, 04 Feb 2023 20:08:47 -0800 (PST) X-Google-Smtp-Source: AK7set/xx0BTLv3UNnqT9/Q54Sxp1Rx3BtxUlZ/n9BQOGfQx1yKHQ1RB/enyaIyXA11Ar0ZAtj7Kcw== X-Received: by 2002:ac8:7770:0:b0:3b9:bc8c:c20c with SMTP id h16-20020ac87770000000b003b9bc8cc20cmr11909853qtu.23.1675570127403; Sat, 04 Feb 2023 20:08:47 -0800 (PST) From: Alexander Bulekov To: qemu-devel@nongnu.org Cc: Alexander Bulekov , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mauro Matteo Cascella , Peter Xu , Jason Wang , David Hildenbrand , Gerd Hoffmann , Thomas Huth , Laurent Vivier , Bandan Das , "Edgar E . Iglesias" , Darren Kenny , Bin Meng , Paolo Bonzini , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Eduardo Habkost , Jon Maloy , Siqi Chen , Stefano Stabellini , Anthony Perard , Paul Durrant , Kevin Wolf , Hanna Reitz , Amit Shah , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , John Snow , Peter Maydell , Mark Cave-Ayland , Keith Busch , Klaus Jensen , Fam Zheng , Dmitry Fleytman , "Gonglei (Arei)" , xen-devel@lists.xenproject.org (open list:X86 Xen CPUs), qemu-block@nongnu.org (open list:virtio-blk), qemu-arm@nongnu.org (open list:i.MX31 (kzm)), qemu-ppc@nongnu.org (open list:Old World (g3beige)) Subject: [PATCH v6 4/4] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded Date: Sat, 4 Feb 2023 23:07:37 -0500 Message-Id: <20230205040737.3567731-5-alxndr@bu.edu> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230205040737.3567731-1-alxndr@bu.edu> References: <20230205040737.3567731-1-alxndr@bu.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CES-GSUITE_AUTH: bf3aNvsZpxl8 This protects devices from bh->mmio reentrancy issues. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Signed-off-by: Alexander Bulekov --- hw/9pfs/xen-9p-backend.c | 4 +++- hw/block/dataplane/virtio-blk.c | 3 ++- hw/block/dataplane/xen-block.c | 5 +++-- hw/char/virtio-serial-bus.c | 3 ++- hw/display/qxl.c | 9 ++++++--- hw/display/virtio-gpu.c | 6 ++++-- hw/ide/ahci.c | 3 ++- hw/ide/core.c | 3 ++- hw/misc/imx_rngc.c | 6 ++++-- hw/misc/macio/mac_dbdma.c | 2 +- hw/net/virtio-net.c | 3 ++- hw/nvme/ctrl.c | 6 ++++-- hw/scsi/mptsas.c | 3 ++- hw/scsi/scsi-bus.c | 3 ++- hw/scsi/vmw_pvscsi.c | 3 ++- hw/usb/dev-uas.c | 3 ++- hw/usb/hcd-dwc2.c | 3 ++- hw/usb/hcd-ehci.c | 3 ++- hw/usb/hcd-uhci.c | 2 +- hw/usb/host-libusb.c | 6 ++++-- hw/usb/redirect.c | 6 ++++-- hw/usb/xen-usb.c | 3 ++- hw/virtio/virtio-balloon.c | 5 +++-- hw/virtio/virtio-crypto.c | 3 ++- 24 files changed, 63 insertions(+), 33 deletions(-) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 65c4979c3c..f077c1b255 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -441,7 +441,9 @@ static int xen_9pfs_connect(struct XenLegacyDevice *xendev) xen_9pdev->rings[i].ring.out = xen_9pdev->rings[i].data + XEN_FLEX_RING_SIZE(ring_order); - xen_9pdev->rings[i].bh = qemu_bh_new(xen_9pfs_bh, &xen_9pdev->rings[i]); + xen_9pdev->rings[i].bh = qemu_bh_new_guarded(xen_9pfs_bh, + &xen_9pdev->rings[i], + &DEVICE(xen_9pdev)->mem_reentrancy_guard); xen_9pdev->rings[i].out_cons = 0; xen_9pdev->rings[i].out_size = 0; xen_9pdev->rings[i].inprogress = false; diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index b28d81737e..a6202997ee 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -127,7 +127,8 @@ bool virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf, } else { s->ctx = qemu_get_aio_context(); } - s->bh = aio_bh_new(s->ctx, notify_guest_bh, s); + s->bh = aio_bh_new_guarded(s->ctx, notify_guest_bh, s, + &DEVICE(vdev)->mem_reentrancy_guard); s->batch_notify_vqs = bitmap_new(conf->num_queues); *dataplane = s; diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c index 2785b9e849..e31806b317 100644 --- a/hw/block/dataplane/xen-block.c +++ b/hw/block/dataplane/xen-block.c @@ -632,8 +632,9 @@ XenBlockDataPlane *xen_block_dataplane_create(XenDevice *xendev, } else { dataplane->ctx = qemu_get_aio_context(); } - dataplane->bh = aio_bh_new(dataplane->ctx, xen_block_dataplane_bh, - dataplane); + dataplane->bh = aio_bh_new_guarded(dataplane->ctx, xen_block_dataplane_bh, + dataplane, + &DEVICE(xendev)->mem_reentrancy_guard); return dataplane; } diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 7d4601cb5d..dd619f0731 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -985,7 +985,8 @@ static void virtser_port_device_realize(DeviceState *dev, Error **errp) return; } - port->bh = qemu_bh_new(flush_queued_data_bh, port); + port->bh = qemu_bh_new_guarded(flush_queued_data_bh, port, + &dev->mem_reentrancy_guard); port->elem = NULL; } diff --git a/hw/display/qxl.c b/hw/display/qxl.c index ec712d3ca2..c0460c4ef1 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -2201,11 +2201,14 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error **errp) qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl); - qxl->update_irq = qemu_bh_new(qxl_update_irq_bh, qxl); + qxl->update_irq = qemu_bh_new_guarded(qxl_update_irq_bh, qxl, + &DEVICE(qxl)->mem_reentrancy_guard); qxl_reset_state(qxl); - qxl->update_area_bh = qemu_bh_new(qxl_render_update_area_bh, qxl); - qxl->ssd.cursor_bh = qemu_bh_new(qemu_spice_cursor_refresh_bh, &qxl->ssd); + qxl->update_area_bh = qemu_bh_new_guarded(qxl_render_update_area_bh, qxl, + &DEVICE(qxl)->mem_reentrancy_guard); + qxl->ssd.cursor_bh = qemu_bh_new_guarded(qemu_spice_cursor_refresh_bh, &qxl->ssd, + &DEVICE(qxl)->mem_reentrancy_guard); } static void qxl_realize_primary(PCIDevice *dev, Error **errp) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 5e15c79b94..66ac9b6cc5 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1339,8 +1339,10 @@ void virtio_gpu_device_realize(DeviceState *qdev, Error **errp) g->ctrl_vq = virtio_get_queue(vdev, 0); g->cursor_vq = virtio_get_queue(vdev, 1); - g->ctrl_bh = qemu_bh_new(virtio_gpu_ctrl_bh, g); - g->cursor_bh = qemu_bh_new(virtio_gpu_cursor_bh, g); + g->ctrl_bh = qemu_bh_new_guarded(virtio_gpu_ctrl_bh, g, + &qdev->mem_reentrancy_guard); + g->cursor_bh = qemu_bh_new_guarded(virtio_gpu_cursor_bh, g, + &qdev->mem_reentrancy_guard); QTAILQ_INIT(&g->reslist); QTAILQ_INIT(&g->cmdq); QTAILQ_INIT(&g->fenceq); diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 7ce001cacd..37091150cb 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1508,7 +1508,8 @@ static void ahci_cmd_done(const IDEDMA *dma) ahci_write_fis_d2h(ad); if (ad->port_regs.cmd_issue && !ad->check_bh) { - ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad); + ad->check_bh = qemu_bh_new_guarded(ahci_check_cmd_bh, ad, + &DEVICE(ad)->mem_reentrancy_guard); qemu_bh_schedule(ad->check_bh); } } diff --git a/hw/ide/core.c b/hw/ide/core.c index 5d1039378f..8c8d1a8ec2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -519,7 +519,8 @@ BlockAIOCB *ide_issue_trim( iocb = blk_aio_get(&trim_aiocb_info, s->blk, cb, cb_opaque); iocb->s = s; - iocb->bh = qemu_bh_new(ide_trim_bh_cb, iocb); + iocb->bh = qemu_bh_new_guarded(ide_trim_bh_cb, iocb, + &DEVICE(s)->mem_reentrancy_guard); iocb->ret = 0; iocb->qiov = qiov; iocb->i = -1; diff --git a/hw/misc/imx_rngc.c b/hw/misc/imx_rngc.c index 632c03779c..082c6980ad 100644 --- a/hw/misc/imx_rngc.c +++ b/hw/misc/imx_rngc.c @@ -228,8 +228,10 @@ static void imx_rngc_realize(DeviceState *dev, Error **errp) sysbus_init_mmio(sbd, &s->iomem); sysbus_init_irq(sbd, &s->irq); - s->self_test_bh = qemu_bh_new(imx_rngc_self_test, s); - s->seed_bh = qemu_bh_new(imx_rngc_seed, s); + s->self_test_bh = qemu_bh_new_guarded(imx_rngc_self_test, s, + &dev->mem_reentrancy_guard); + s->seed_bh = qemu_bh_new_guarded(imx_rngc_seed, s, + &dev->mem_reentrancy_guard); } static void imx_rngc_reset(DeviceState *dev) diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c index 43bb1f56ba..80a789f32b 100644 --- a/hw/misc/macio/mac_dbdma.c +++ b/hw/misc/macio/mac_dbdma.c @@ -914,7 +914,7 @@ static void mac_dbdma_realize(DeviceState *dev, Error **errp) { DBDMAState *s = MAC_DBDMA(dev); - s->bh = qemu_bh_new(DBDMA_run_bh, s); + s->bh = qemu_bh_new_guarded(DBDMA_run_bh, s, &dev->mem_reentrancy_guard); } static void mac_dbdma_class_init(ObjectClass *oc, void *data) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3ae909041a..a170c724de 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2885,7 +2885,8 @@ static void virtio_net_add_queue(VirtIONet *n, int index) n->vqs[index].tx_vq = virtio_add_queue(vdev, n->net_conf.tx_queue_size, virtio_net_handle_tx_bh); - n->vqs[index].tx_bh = qemu_bh_new(virtio_net_tx_bh, &n->vqs[index]); + n->vqs[index].tx_bh = qemu_bh_new_guarded(virtio_net_tx_bh, &n->vqs[index], + &DEVICE(vdev)->mem_reentrancy_guard); } n->vqs[index].tx_waiting = 0; diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index f25cc2c235..dcb250e772 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -4318,7 +4318,8 @@ static void nvme_init_sq(NvmeSQueue *sq, NvmeCtrl *n, uint64_t dma_addr, QTAILQ_INSERT_TAIL(&(sq->req_list), &sq->io_req[i], entry); } - sq->bh = qemu_bh_new(nvme_process_sq, sq); + sq->bh = qemu_bh_new_guarded(nvme_process_sq, sq, + &DEVICE(sq->ctrl)->mem_reentrancy_guard); if (n->dbbuf_enabled) { sq->db_addr = n->dbbuf_dbs + (sqid << 3); @@ -4708,7 +4709,8 @@ static void nvme_init_cq(NvmeCQueue *cq, NvmeCtrl *n, uint64_t dma_addr, } } n->cq[cqid] = cq; - cq->bh = qemu_bh_new(nvme_post_cqes, cq); + cq->bh = qemu_bh_new_guarded(nvme_post_cqes, cq, + &DEVICE(cq->ctrl)->mem_reentrancy_guard); } static uint16_t nvme_create_cq(NvmeCtrl *n, NvmeRequest *req) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index c485da792c..3de288b454 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -1322,7 +1322,8 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error **errp) } s->max_devices = MPTSAS_NUM_PORTS; - s->request_bh = qemu_bh_new(mptsas_fetch_requests, s); + s->request_bh = qemu_bh_new_guarded(mptsas_fetch_requests, s, + &DEVICE(dev)->mem_reentrancy_guard); scsi_bus_init(&s->bus, sizeof(s->bus), &dev->qdev, &mptsas_scsi_info); } diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index ceceafb2cd..e5c9f7a53d 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -193,7 +193,8 @@ static void scsi_dma_restart_cb(void *opaque, bool running, RunState state) AioContext *ctx = blk_get_aio_context(s->conf.blk); /* The reference is dropped in scsi_dma_restart_bh.*/ object_ref(OBJECT(s)); - s->bh = aio_bh_new(ctx, scsi_dma_restart_bh, s); + s->bh = aio_bh_new_guarded(ctx, scsi_dma_restart_bh, s, + &DEVICE(s)->mem_reentrancy_guard); qemu_bh_schedule(s->bh); } } diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index fa76696855..4de34536e9 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1184,7 +1184,8 @@ pvscsi_realizefn(PCIDevice *pci_dev, Error **errp) pcie_endpoint_cap_init(pci_dev, PVSCSI_EXP_EP_OFFSET); } - s->completion_worker = qemu_bh_new(pvscsi_process_completion_queue, s); + s->completion_worker = qemu_bh_new_guarded(pvscsi_process_completion_queue, s, + &DEVICE(pci_dev)->mem_reentrancy_guard); scsi_bus_init(&s->bus, sizeof(s->bus), DEVICE(pci_dev), &pvscsi_scsi_info); /* override default SCSI bus hotplug-handler, with pvscsi's one */ diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 88f99c05d5..f013ded91e 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -937,7 +937,8 @@ static void usb_uas_realize(USBDevice *dev, Error **errp) QTAILQ_INIT(&uas->results); QTAILQ_INIT(&uas->requests); - uas->status_bh = qemu_bh_new(usb_uas_send_status_bh, uas); + uas->status_bh = qemu_bh_new_guarded(usb_uas_send_status_bh, uas, + &d->mem_reentrancy_guard); dev->flags |= (1 << USB_DEV_FLAG_IS_SCSI_STORAGE); scsi_bus_init(&uas->bus, sizeof(uas->bus), DEVICE(dev), &usb_uas_scsi_info); diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c index 8755e9cbb0..a0c4e782b2 100644 --- a/hw/usb/hcd-dwc2.c +++ b/hw/usb/hcd-dwc2.c @@ -1364,7 +1364,8 @@ static void dwc2_realize(DeviceState *dev, Error **errp) s->fi = USB_FRMINTVL - 1; s->eof_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, dwc2_frame_boundary, s); s->frame_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, dwc2_work_timer, s); - s->async_bh = qemu_bh_new(dwc2_work_bh, s); + s->async_bh = qemu_bh_new_guarded(dwc2_work_bh, s, + &dev->mem_reentrancy_guard); sysbus_init_irq(sbd, &s->irq); } diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index d4da8dcb8d..c930c60921 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2533,7 +2533,8 @@ void usb_ehci_realize(EHCIState *s, DeviceState *dev, Error **errp) } s->frame_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, ehci_work_timer, s); - s->async_bh = qemu_bh_new(ehci_work_bh, s); + s->async_bh = qemu_bh_new_guarded(ehci_work_bh, s, + &dev->mem_reentrancy_guard); s->device = dev; s->vmstate = qemu_add_vm_change_state_handler(usb_ehci_vm_state_change, s); diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 30ae0104bb..bdc891f57a 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -1193,7 +1193,7 @@ void usb_uhci_common_realize(PCIDevice *dev, Error **errp) USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); } } - s->bh = qemu_bh_new(uhci_bh, s); + s->bh = qemu_bh_new_guarded(uhci_bh, s, &DEVICE(dev)->mem_reentrancy_guard); s->frame_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, uhci_frame_timer, s); s->num_ports_vmstate = NB_PORTS; QTAILQ_INIT(&s->queues); diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 176868d345..f500db85ab 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1141,7 +1141,8 @@ static void usb_host_nodev_bh(void *opaque) static void usb_host_nodev(USBHostDevice *s) { if (!s->bh_nodev) { - s->bh_nodev = qemu_bh_new(usb_host_nodev_bh, s); + s->bh_nodev = qemu_bh_new_guarded(usb_host_nodev_bh, s, + &DEVICE(s)->mem_reentrancy_guard); } qemu_bh_schedule(s->bh_nodev); } @@ -1739,7 +1740,8 @@ static int usb_host_post_load(void *opaque, int version_id) USBHostDevice *dev = opaque; if (!dev->bh_postld) { - dev->bh_postld = qemu_bh_new(usb_host_post_load_bh, dev); + dev->bh_postld = qemu_bh_new_guarded(usb_host_post_load_bh, dev, + &DEVICE(dev)->mem_reentrancy_guard); } qemu_bh_schedule(dev->bh_postld); dev->bh_postld_pending = true; diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index fd7df599bc..39fbaaab16 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1441,8 +1441,10 @@ static void usbredir_realize(USBDevice *udev, Error **errp) } } - dev->chardev_close_bh = qemu_bh_new(usbredir_chardev_close_bh, dev); - dev->device_reject_bh = qemu_bh_new(usbredir_device_reject_bh, dev); + dev->chardev_close_bh = qemu_bh_new_guarded(usbredir_chardev_close_bh, dev, + &DEVICE(dev)->mem_reentrancy_guard); + dev->device_reject_bh = qemu_bh_new_guarded(usbredir_device_reject_bh, dev, + &DEVICE(dev)->mem_reentrancy_guard); dev->attach_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL, usbredir_do_attach, dev); packet_id_queue_init(&dev->cancelled, dev, "cancelled"); diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c index 0f7369e7ed..dec91294ad 100644 --- a/hw/usb/xen-usb.c +++ b/hw/usb/xen-usb.c @@ -1021,7 +1021,8 @@ static void usbback_alloc(struct XenLegacyDevice *xendev) QTAILQ_INIT(&usbif->req_free_q); QSIMPLEQ_INIT(&usbif->hotplug_q); - usbif->bh = qemu_bh_new(usbback_bh, usbif); + usbif->bh = qemu_bh_new_guarded(usbback_bh, usbif, + &DEVICE(xendev)->mem_reentrancy_guard); } static int usbback_free(struct XenLegacyDevice *xendev) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 746f07c4d2..309cebacc6 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -908,8 +908,9 @@ static void virtio_balloon_device_realize(DeviceState *dev, Error **errp) precopy_add_notifier(&s->free_page_hint_notify); object_ref(OBJECT(s->iothread)); - s->free_page_bh = aio_bh_new(iothread_get_aio_context(s->iothread), - virtio_ballloon_get_free_page_hints, s); + s->free_page_bh = aio_bh_new_guarded(iothread_get_aio_context(s->iothread), + virtio_ballloon_get_free_page_hints, s, + &DEVICE(s)->mem_reentrancy_guard); } if (virtio_has_feature(s->host_features, VIRTIO_BALLOON_F_REPORTING)) { diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 516425e26a..4c95f1096e 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -1050,7 +1050,8 @@ static void virtio_crypto_device_realize(DeviceState *dev, Error **errp) vcrypto->vqs[i].dataq = virtio_add_queue(vdev, 1024, virtio_crypto_handle_dataq_bh); vcrypto->vqs[i].dataq_bh = - qemu_bh_new(virtio_crypto_dataq_bh, &vcrypto->vqs[i]); + qemu_bh_new_guarded(virtio_crypto_dataq_bh, &vcrypto->vqs[i], + &dev->mem_reentrancy_guard); vcrypto->vqs[i].vcrypto = vcrypto; } -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Sun Feb 05 04:14:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 04:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489695.758086 (Exim 4.92) (envelope-from ) id 1pOWPl-0000D7-OG; Sun, 05 Feb 2023 04:14:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489695.758086; Sun, 05 Feb 2023 04:14:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWPl-0000D0-Kn; Sun, 05 Feb 2023 04:14:05 +0000 Received: by outflank-mailman (input) for mailman id 489695; Sun, 05 Feb 2023 04:14:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWPk-0000CG-2c; Sun, 05 Feb 2023 04:14:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWPk-0000vP-0L; Sun, 05 Feb 2023 04:14:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOWPj-00086h-GN; Sun, 05 Feb 2023 04:14:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOWPj-0001mH-Ft; Sun, 05 Feb 2023 04:14:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=idQY+tCC54glQgflnj4QGhge+AqklcI4vcZPn9e9Bag=; b=CSjQ93WMhSfRtNLab1b/OJxwCD ssQYpYz3AQdevQ6Jm4J3KRykrCidvo0sMsHua98xRFcFu4gzH0aoPV13SFNANZUIeuC5LnLm6NURb FYE5tL14x92mG1JKV0hIaqdm3rnmW/6YODIwWOZ3jQbNVte492FPea4RCBPZPXxsNp4Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176365: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e X-Osstest-Versions-That: xen=f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 From: osstest service owner Date: Sun, 05 Feb 2023 04:14:03 +0000 flight 176365 xen-unstable real [real] flight 176385 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176365/ http://logs.test-lab.xenproject.org/osstest/logs/176385/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176385-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175987 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175994 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175994 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175994 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e baseline version: xen f588e7b7cb70800533aaa8a2a9d7a4b32d10b363 Last test of basis 175994 2023-01-20 08:38:32 Z 15 days Failing since 176003 2023-01-20 17:40:27 Z 15 days 28 attempts Testing same since 176349 2023-02-03 14:25:48 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Daniel P. Smith George Dunlap Henry Wang Jan Beulich Jason Andryuk Juergen Gross Julien Grall Luca Fancellu Michal Orzel Oleksii Kurochko Stefano Stabellini Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f588e7b7cb..a21c9e6ddf a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e -> master From xen-devel-bounces@lists.xenproject.org Sun Feb 05 09:20:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 09:20:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489781.758307 (Exim 4.92) (envelope-from ) id 1pObBl-0001Qd-5V; Sun, 05 Feb 2023 09:19:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489781.758307; Sun, 05 Feb 2023 09:19:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pObBl-0001QW-2R; Sun, 05 Feb 2023 09:19:57 +0000 Received: by outflank-mailman (input) for mailman id 489781; Sun, 05 Feb 2023 09:19:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pObBj-0001QM-Gf; Sun, 05 Feb 2023 09:19:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pObBj-0000TK-CY; Sun, 05 Feb 2023 09:19:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pObBi-0004En-W9; Sun, 05 Feb 2023 09:19:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pObBi-0001Mx-Tp; Sun, 05 Feb 2023 09:19:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gbqYuZlO9sjtDOpjs4WaJYt0wOPSB9lX3ocjSrzr3UQ=; b=x+k2TUCdCgGoR1FjNkf8Jwlj0d 4DGp898qg4zyptVNPuYwSH5AFacDmCX30CMThAMgbmyXO7ZK++Kp2keYqI7Gqrlq/u7U4s34BNXYJ bnmsvckkXeD0LTbkhZId4eDSum/H/E3k6VvC5AyYvxw++9fCkhFmS1za5SVLBptpezZc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176367: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-pygrub:guest-saverestore.2:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=0730eab4d38f74589da4a7d55814773260491f89 X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Sun, 05 Feb 2023 09:19:54 +0000 flight 176367 qemu-mainline real [real] flight 176390 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176367/ http://logs.test-lab.xenproject.org/osstest/logs/176390/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which are failing intermittently (not blocking): test-amd64-amd64-pygrub 18 guest-saverestore.2 fail pass in 176390-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 0730eab4d38f74589da4a7d55814773260491f89 baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 2 days Failing since 176352 2023-02-03 17:40:20 Z 1 days 2 attempts Testing same since 176367 2023-02-04 13:02:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Alexander Graf Emanuele Giuseppe Esposito Emilio Cota Evgeny Iakovlev Fuad Tabba Gerd Hoffmann Hanna Reitz Idan Horowitz Keith Packard Kevin Wolf Marc-André Lureau Marcin Juszkiewicz Mark Cave-Ayland Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2736 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 05 12:41:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 12:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489806.758323 (Exim 4.92) (envelope-from ) id 1pOeKL-0006Ph-QS; Sun, 05 Feb 2023 12:41:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489806.758323; Sun, 05 Feb 2023 12:41:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeKL-0006Pa-Nh; Sun, 05 Feb 2023 12:41:01 +0000 Received: by outflank-mailman (input) for mailman id 489806; Sun, 05 Feb 2023 12:41:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeKK-0006PP-9n for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:41:00 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 551358c5-a552-11ed-933c-83870f6b2ba8; Sun, 05 Feb 2023 13:40:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id C683120100; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cnv66YH8ewre; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7956E200F9; Sun, 5 Feb 2023 13:40:54 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeKE-002nEy-0M; Sun, 05 Feb 2023 13:40:54 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 551358c5-a552-11ed-933c-83870f6b2ba8 Date: Sun, 5 Feb 2023 13:40:54 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Message-ID: <20230205124054.dwxobowog2aayi5r@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:04 +0100, a ecrit: > Add the concept of mount points to Mini-OS. A mount point is a path > associated with a device pointer and an open() callback. A mount point > can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). > > This allows to replace the special casing in the generic open() > handling with a generic mount point handling. > > Prepare the open() callbacks to support creating new files by adding a > mode parameter. > > Additionally add a close() prototype to include/lib.h, as it is missing > today. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > include/lib.h | 9 ++++++ > lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 70 insertions(+), 19 deletions(-) > > diff --git a/include/lib.h b/include/lib.h > index bec99646..36d94ec4 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -187,6 +187,13 @@ struct file_ops { > bool (*select_wr)(struct file *file); > }; > > +struct mount_point { > + const char *path; > + int (*open)(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode); > + void *dev; > +}; > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); > void close_all_files(void); > extern struct thread *main_thread; > void sparse(unsigned long data, size_t size); > + > +int close(int fd); > #endif > > #endif /* _LIB_H_ */ > diff --git a/lib/sys.c b/lib/sys.c > index 8f8a3de2..1475c621 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) > return buf; > } > > -#define LOG_PATH "/var/log/" > -#define SAVE_PATH "/var/lib/xen" > -#define SAVE_CONSOLE 1 > -#define RESTORE_CONSOLE 2 > - > int mkdir(const char *pathname, mode_t mode) > { > errno = EIO; > @@ -286,18 +281,30 @@ int posix_openpt(int flags) > return fd; > } > > +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return posix_openpt(flags); > +} > + > int open_savefile(const char *path, int save) > { > int fd; > char nodename[64]; > > - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); > + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); > > fd = open_consfront(nodename); > printk("fd(%d) = open_savefile\n", fd); > > return fd; > } > + > +static int open_save(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return open_savefile(pathname, flags & O_WRONLY); > +} > #else > int posix_openpt(int flags) > { > @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) > } > #endif > > -int open(const char *pathname, int flags, ...) > +static int open_log(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > { > int fd; > + > /* Ugly, but fine. */ > - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { > - fd = alloc_fd(FTYPE_CONSOLE); > - printk("open(%s) -> %d\n", pathname, fd); > - return fd; > + fd = alloc_fd(FTYPE_CONSOLE); > + printk("open(%s) -> %d\n", pathname, fd); > + return fd; > +} > + > +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + int fd; > + > + fd = alloc_fd(FTYPE_MEM); > + printk("open(%s) -> %d\n", pathname, fd); > + return fd; > +} > + > +static struct mount_point mount_points[] = { > + { .path = "/var/log", .open = open_log, .dev = NULL }, > + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > +#ifdef CONFIG_CONSFRONT > + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, > + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, > +#endif > +}; > + > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname, flags, mode); > } > - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) > - return posix_openpt(flags); > - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) > - return open_savefile(pathname, flags & O_WRONLY); > + > errno = EIO; > return -1; > } > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Sun Feb 05 12:42:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 12:42:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489817.758339 (Exim 4.92) (envelope-from ) id 1pOeLe-00071I-6V; Sun, 05 Feb 2023 12:42:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489817.758339; Sun, 05 Feb 2023 12:42:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeLe-00071B-2o; Sun, 05 Feb 2023 12:42:22 +0000 Received: by outflank-mailman (input) for mailman id 489817; Sun, 05 Feb 2023 12:42:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeLc-0006l7-B8 for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:42:20 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8567f3ca-a552-11ed-93b5-47a8fe42b414; Sun, 05 Feb 2023 13:42:16 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id A94D72013E; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6j9RGqsjjpM4; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 84AE520134; Sun, 5 Feb 2023 13:42:16 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeLY-002nFE-0U; Sun, 05 Feb 2023 13:42:16 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8567f3ca-a552-11ed-93b5-47a8fe42b414 Date: Sun, 5 Feb 2023 13:42:16 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 3/7] Mini-OS: add support for runtime mounts Message-ID: <20230205124216.psjld3kc4qtijtrw@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-4-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:05 +0100, a ecrit: > Add the support to mount a device at runtime. The number of dynamic > mounts is limited by a #define. > > For devices supporting multiple files struct file is modified to hold > a pointer to file specific data in contrast to device specific data. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > include/lib.h | 5 +++++ > lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 54 insertions(+), 1 deletion(-) > > diff --git a/include/lib.h b/include/lib.h > index 36d94ec4..fd8c36de 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -172,6 +172,7 @@ struct file { > union { > int fd; /* Any fd from an upper layer. */ > void *dev; > + void *filedata; > }; > }; > > @@ -194,6 +195,10 @@ struct mount_point { > void *dev; > }; > > +int mount(const char *path, void *dev, > + int (*open)(struct mount_point *, const char *, int, mode_t)); > +void umount(const char *path); > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > diff --git a/lib/sys.c b/lib/sys.c > index 1475c621..4171bfd6 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > return fd; > } > > -static struct mount_point mount_points[] = { > +#ifdef CONFIG_CONSFRONT > +#define STATIC_MNTS 4 > +#else > +#define STATIC_MNTS 2 > +#endif > +#define DYNAMIC_MNTS 8 > + > +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { > { .path = "/var/log", .open = open_log, .dev = NULL }, > { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > #ifdef CONFIG_CONSFRONT > @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) > for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > { > mnt = mount_points + m; > + if ( !mnt->path ) > + continue; > mlen = strlen(mnt->path); > if ( !strncmp(pathname, mnt->path, mlen) && > (pathname[mlen] == '/' || pathname[mlen] == 0) ) > @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) > return -1; > } > > +int mount(const char *path, void *dev, > + int (*open)(struct mount_point *, const char *, int, mode_t)) > +{ > + unsigned int m; > + struct mount_point *mnt; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + if ( !mnt->path ) > + { > + mnt->path = strdup(path); > + mnt->open = open; > + mnt->dev = dev; > + return 0; > + } > + } > + > + errno = ENOSPC; > + return -1; > +} > + > +void umount(const char *path) > +{ > + unsigned int m; > + struct mount_point *mnt; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + if ( mnt->path && !strcmp(mnt->path, path) ) > + { > + free((char *)mnt->path); > + mnt->path = NULL; > + return; > + } > + } > +} > + > int isatty(int fd) > { > return files[fd].type == FTYPE_CONSOLE; > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Sun Feb 05 12:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 12:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489828.758361 (Exim 4.92) (envelope-from ) id 1pOeOQ-0007mG-PT; Sun, 05 Feb 2023 12:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489828.758361; Sun, 05 Feb 2023 12:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeOQ-0007m9-LF; Sun, 05 Feb 2023 12:45:14 +0000 Received: by outflank-mailman (input) for mailman id 489828; Sun, 05 Feb 2023 12:45:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeOP-0007hb-9T for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 12:45:13 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed53ab4a-a552-11ed-933c-83870f6b2ba8; Sun, 05 Feb 2023 13:45:10 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 678422013E; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OpK39USoWs7c; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from begin (unknown [164.15.244.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 376BE20134; Sun, 5 Feb 2023 13:45:10 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOeOL-002nFx-2b; Sun, 05 Feb 2023 13:45:09 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed53ab4a-a552-11ed-933c-83870f6b2ba8 Date: Sun, 5 Feb 2023 13:45:09 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Message-ID: <20230205124509.pr5xswn4ygqsqoba@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:04 +0100, a ecrit: > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname, flags, mode); Thinking about it more: don't we want to pass pathname+mlen? So that the open function doesn't have to care where it's mounted. Samuel From xen-devel-bounces@lists.xenproject.org Sun Feb 05 12:51:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 12:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489837.758372 (Exim 4.92) (envelope-from ) id 1pOeUe-0000tZ-H7; Sun, 05 Feb 2023 12:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489837.758372; Sun, 05 Feb 2023 12:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeUe-0000tS-DJ; Sun, 05 Feb 2023 12:51:40 +0000 Received: by outflank-mailman (input) for mailman id 489837; Sun, 05 Feb 2023 12:51:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeUd-0000tI-WC; Sun, 05 Feb 2023 12:51:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeUd-0005LX-Tv; Sun, 05 Feb 2023 12:51:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOeUd-0006J0-FL; Sun, 05 Feb 2023 12:51:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOeUd-0000nZ-Et; Sun, 05 Feb 2023 12:51:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Tq/G05Ilps3hOkkvd0GOr2TXFCBv5jrwwBlSBXIr88=; b=Zel5KBkfF3vkbLhMSVtI3AjJzQ ic2r1XUpwexBCj5/fhkmZ792io0zOlRxc5qcrTv3q7Atl2p23MGOql+YhIbZb/aID6OgJLzXiSKty LOCn3HN/vTvgArrDNl6Cf50Mc4u1tTY1ICEwaDEAUGNCUW4tIuYlESk+XtEqOpftLXWE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176376: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 X-Osstest-Versions-That: linux=0136d86b78522bbd5755f8194c97a987f0586ba5 From: osstest service owner Date: Sun, 05 Feb 2023 12:51:39 +0000 flight 176376 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176355 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176355 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176355 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176355 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176355 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 baseline version: linux 0136d86b78522bbd5755f8194c97a987f0586ba5 Last test of basis 176355 2023-02-04 00:13:01 Z 1 days Testing same since 176376 2023-02-04 20:10:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gavin Shan Helge Deller Jan Luebbe Linus Torvalds Marc Zyngier Masahiro Yamada Paolo Bonzini Ricardo Koller Stafford Horne Xu Panda Yang Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0136d86b7852..db27c22251e7 db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Feb 05 16:51:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 16:51:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489860.758404 (Exim 4.92) (envelope-from ) id 1pOiEO-000150-Q3; Sun, 05 Feb 2023 16:51:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489860.758404; Sun, 05 Feb 2023 16:51:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOiEO-00014t-Mw; Sun, 05 Feb 2023 16:51:08 +0000 Received: by outflank-mailman (input) for mailman id 489860; Sun, 05 Feb 2023 16:51:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOiEN-00014j-M5; Sun, 05 Feb 2023 16:51:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOiEN-00038F-Jj; Sun, 05 Feb 2023 16:51:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOiEN-0007By-2Y; Sun, 05 Feb 2023 16:51:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOiEN-0000Uw-21; Sun, 05 Feb 2023 16:51:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BrtpIaSAtIG7RVod0n22z6b7LjNtAb6mPenoRjOsWHA=; b=nFQ/IHfHJUYOJVuEsLzGqj1EPn oSjcwjseSsZ6mDrmVc4py0Y3rJJ5vPtj8NXbTZ7qFK2FNZWzZsqIMfIjZmR2XzSk78Elxbu2FVJeS BpVf7921s1dbNn8KgC9DTaNa+p7Ogjijz7uoQehz5mbkcgRsgmYTp4i2z6vnIAL2Ejs4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176386: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e X-Osstest-Versions-That: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e From: osstest service owner Date: Sun, 05 Feb 2023 16:51:07 +0000 flight 176386 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176386/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 176365 Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176365 like 176349 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176365 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176365 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176365 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176365 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176365 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176365 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176365 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176365 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176365 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e baseline version: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e Last test of basis 176386 2023-02-05 04:19:52 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Feb 05 18:10:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 18:10:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489877.758421 (Exim 4.92) (envelope-from ) id 1pOjTI-0001VE-Np; Sun, 05 Feb 2023 18:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489877.758421; Sun, 05 Feb 2023 18:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOjTI-0001V7-L5; Sun, 05 Feb 2023 18:10:36 +0000 Received: by outflank-mailman (input) for mailman id 489877; Sun, 05 Feb 2023 18:10:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOjTH-0001Ux-Jv; Sun, 05 Feb 2023 18:10:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOjTH-00050l-IB; Sun, 05 Feb 2023 18:10:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOjTH-0000jS-5l; Sun, 05 Feb 2023 18:10:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOjTH-0007iY-5O; Sun, 05 Feb 2023 18:10:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HacMFPpPXxw/tnJbfHqvpmjwsD2yaA3169Z088NUg0s=; b=NdnVSw7r2jzjxEyv+832R2dUlA FGxnXF0OC6eFhZmSW8pOhB5oA0jnz0detqa/cR8XtdgkWaGOpTCUSoERNO+4ZXFwxz1J89NKgt+ll YK68Eoh3TZH7jYAK/0zsy1lYvKWXe+g7mo5IdEoVJ9Q+lrNbBdHql54LRB7YNhuUzdfA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176388: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=0f350a4d070e952b0ecc7631708478ddfd43ba3f X-Osstest-Versions-That: libvirt=f2d379e7cb802f922409c35e4831ee52a2162486 From: osstest service owner Date: Sun, 05 Feb 2023 18:10:35 +0000 flight 176388 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176388/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 0f350a4d070e952b0ecc7631708478ddfd43ba3f baseline version: libvirt f2d379e7cb802f922409c35e4831ee52a2162486 Last test of basis 176343 2023-02-03 04:20:20 Z 2 days Testing same since 176358 2023-02-04 04:21:56 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Jim Fehlig jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git f2d379e7cb..0f350a4d07 0f350a4d070e952b0ecc7631708478ddfd43ba3f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Feb 05 20:15:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 20:15:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489895.758444 (Exim 4.92) (envelope-from ) id 1pOlPd-0005wV-PJ; Sun, 05 Feb 2023 20:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489895.758444; Sun, 05 Feb 2023 20:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOlPd-0005wO-Ls; Sun, 05 Feb 2023 20:14:57 +0000 Received: by outflank-mailman (input) for mailman id 489895; Sun, 05 Feb 2023 20:14:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOlPc-0005wE-7H; Sun, 05 Feb 2023 20:14:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOlPc-0008I7-3X; Sun, 05 Feb 2023 20:14:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOlPb-0003Qm-MB; Sun, 05 Feb 2023 20:14:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOlPb-0005gA-Lm; Sun, 05 Feb 2023 20:14:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7gPekNCvGLoB0AU+W3xnCccO5YWv6uW6KWdmSV71omM=; b=wluKBdVaqBoR/jG/brQcYiSODg LXZm1yHE+Io1k9UOLOJj+EfWWBZNBhubyZEGhymCq/NfM8JwnxrOsgMx+MVS4hDM9Le8I8i/+RA8B 25+7/bLGjAfR4rbVSypCLweONu3piEceT3z5sKQW4UORmlWKUkBqBT85EIFkCQuo+ICA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176395: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=837c07cf68fec9cad455d5fc86aab5350cc06c53 X-Osstest-Versions-That: linux=db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 From: osstest service owner Date: Sun, 05 Feb 2023 20:14:55 +0000 flight 176395 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 176376 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176376 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176376 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176376 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176376 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176376 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 837c07cf68fec9cad455d5fc86aab5350cc06c53 baseline version: linux db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 Last test of basis 176376 2023-02-04 20:10:33 Z 1 days Testing same since 176395 2023-02-05 12:54:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Belloni Arnd Bergmann Johan Hovold Kajol Jain Linus Torvalds Michael Ellerman Nicholas Piggin Rob Herring Sachin Sant Sathvika Vasireddy Shanker Donthineni Sourabh Jain jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 479 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:13:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:13:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489908.758460 (Exim 4.92) (envelope-from ) id 1pOmKO-0004Ho-9d; Sun, 05 Feb 2023 21:13:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489908.758460; Sun, 05 Feb 2023 21:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmKO-0004Hh-71; Sun, 05 Feb 2023 21:13:36 +0000 Received: by outflank-mailman (input) for mailman id 489908; Sun, 05 Feb 2023 21:13:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmKN-0004Hb-8C for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:13:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmKM-0001Il-SX; Sun, 05 Feb 2023 21:13:34 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmKM-0006xp-Nl; Sun, 05 Feb 2023 21:13:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=Nzm6hIq1RVb/TSeMEB2Lutm0jbt8Bo9/VctKhfQBWFU=; b=SndVR/Lsxju105+ICxHvx1Xu2g 4zjo5G6bDMZ8G7GnWAnKuFvrhw1/ludfpeQ3ReOi6pAby2WS0vS3gI+fc6WHjDfd+j7n4UomKQ26a sp1AvabF8GLZzAnU+xac2kD50cBBQ4C576Jnz+wEy3IP2hSQXbCthTgwFchEcpWT8uHU=; Message-ID: Date: Sun, 5 Feb 2023 21:13:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-15-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 14/40] xen/arm64: head: Jump to the runtime mapping in enable_mm() In-Reply-To: <20230113052914.3845596-15-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:28, Penny Zheng wrote: > At the moment, on MMU system, enable_mm() will return to an address in > the 1:1 mapping, then each path is responsible to switch to virtual runtime > mapping. Then remove_identity_mapping() is called to remove all 1:1 mapping. > > Since remove_identity_mapping() is not necessary on MPU system, and we also > avoid creating empty function for MPU system, trying to keep only one codeflow > in arm64/head.S, we move path switch and remove_identity_mapping() in > enable_mm() on MMU system. AFAICT, remove_identity_mapping() is still using ENTRY(). But you could avoid to introduce ENTRY() if you re-order your series so this patch happens before the MMU specific code is moved in a separate helper. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/arm64/head.S | 28 +++++++++++++--------------- > xen/arch/arm/arm64/head_mmu.S | 33 ++++++++++++++++++++++++++++++--- > 2 files changed, 43 insertions(+), 18 deletions(-) This will need to be rebased on top of [1] (which will be merged pretty soon). There are two main differences: 1) enable_mmu has an extra parameter to take the root page-tables 2) the remove_identity_mapping should only be called for the boot CPU. So I think we want to introduce two functions: 1) enable_boot_mmu 2) enable_runtime_mmu You might need the same for the MPU as I would expect it would be per-CPU. Cheers, [1] 20230127195508.2786-1-julien@xen.org -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:30:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489915.758471 (Exim 4.92) (envelope-from ) id 1pOmaf-0006qL-Ml; Sun, 05 Feb 2023 21:30:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489915.758471; Sun, 05 Feb 2023 21:30:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmaf-0006qE-JV; Sun, 05 Feb 2023 21:30:25 +0000 Received: by outflank-mailman (input) for mailman id 489915; Sun, 05 Feb 2023 21:30:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmae-0006q8-90 for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:30:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmad-0001l0-UT; Sun, 05 Feb 2023 21:30:23 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmad-0007iV-HD; Sun, 05 Feb 2023 21:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=OQQCBAX4CNVuT93EwvNa6OSzuFLX8u7+QyWOVpT1pf4=; b=2R+55lTecbZ9dFLYue+BV06IJ4 KVf1+Ys/ovApHzBOg0XoSaj7e5Ijns1XF2P8QCqVzvs7s4CaZvkXhHrVau5ZJQlEG/IEw41dmliZO vGO+9PD4QaCe8vcRUl/Nhy+Jgiij0y7yg5LW6m0y50kg61oUIKb63jeaenz9gUtFAAUQ=; Message-ID: <6aebebad-2b01-4bd6-8a2f-7be3591382d8@xen.org> Date: Sun, 5 Feb 2023 21:30:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-16-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 15/40] xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h In-Reply-To: <20230113052914.3845596-16-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > From: Wei Chen > > To make the code readable and maintainable, we move MMU-specific > memory management code from mm.c to mm_mmu.c and move MMU-specific > definitions from mm.h to mm_mmu.h. > Later we will create mm_mpu.h and mm_mpu.c for MPU-specific memory > management code. This sentence implies there is no mm_mpu.{c, h} yet and this is not touched within this patch. However... > This will avoid lots of #ifdef in memory management code and header files. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > --- > xen/arch/arm/Makefile | 5 + > xen/arch/arm/include/asm/mm.h | 19 +- > xen/arch/arm/include/asm/mm_mmu.h | 35 + > xen/arch/arm/mm.c | 1352 +--------------------------- > xen/arch/arm/mm_mmu.c | 1376 +++++++++++++++++++++++++++++ > xen/arch/arm/mm_mpu.c | 67 ++ ... It looks like they already exists and you are modifying them. That said, it would be better if this patch only contains code movement (IOW no MPU changes). > 6 files changed, 1488 insertions(+), 1366 deletions(-) > create mode 100644 xen/arch/arm/include/asm/mm_mmu.h > create mode 100644 xen/arch/arm/mm_mmu.c I don't particular like the naming. I think it would make more sense to introduce two directories: "mmu" and "mpu" which includes code specific to each flavor of Xen. > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 4d076b278b..21188b207f 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -37,6 +37,11 @@ obj-y += kernel.init.o > obj-$(CONFIG_LIVEPATCH) += livepatch.o > obj-y += mem_access.o > obj-y += mm.o > +ifneq ($(CONFIG_HAS_MPU), y) > +obj-y += mm_mmu.o > +else > +obj-y += mm_mpu.o > +endif Shouldn't mm_mpu.o have been incldued where it was first introduced? > obj-y += monitor.o > obj-y += p2m.o > obj-y += percpu.o > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 68adcac9fa..1b9fdb6ff5 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -154,13 +154,6 @@ struct page_info > #define _PGC_need_scrub _PGC_allocated > #define PGC_need_scrub PGC_allocated > > -extern mfn_t directmap_mfn_start, directmap_mfn_end; > -extern vaddr_t directmap_virt_end; > -#ifdef CONFIG_ARM_64 > -extern vaddr_t directmap_virt_start; > -extern unsigned long directmap_base_pdx; > -#endif > - > #ifdef CONFIG_ARM_32 > #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) > #define is_xen_heap_mfn(mfn) ({ \ > @@ -192,8 +185,6 @@ extern unsigned long total_pages; > > #define PDX_GROUP_SHIFT SECOND_SHIFT > > -/* Boot-time pagetable setup */ > -extern void setup_pagetables(unsigned long boot_phys_offset); > /* Map FDT in boot pagetable */ > extern void *early_fdt_map(paddr_t fdt_paddr); > /* Remove early mappings */ > @@ -203,12 +194,6 @@ extern void remove_early_mappings(void); > extern int init_secondary_pagetables(int cpu); > /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ > extern void mmu_init_secondary_cpu(void); > -/* > - * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, > - * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. > - * For Arm64, map the region in the directmap area. > - */ > -extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); > /* Map a frame table to cover physical addresses ps through pe */ > extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); > /* map a physical range in virtual memory */ > @@ -256,6 +241,10 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) > #define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) > #define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) > > +#ifndef CONFIG_HAS_MPU > +#include > +#endif > + > /* Page-align address and convert to frame number format */ > #define paddr_to_pfn_aligned(paddr) paddr_to_pfn(PAGE_ALIGN(paddr)) > > diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h > new file mode 100644 > index 0000000000..a5e63d8af8 > --- /dev/null > +++ b/xen/arch/arm/include/asm/mm_mmu.h > @@ -0,0 +1,35 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef __ARCH_ARM_MM_MMU__ > +#define __ARCH_ARM_MM_MMU__ > + > +extern mfn_t directmap_mfn_start, directmap_mfn_end; > +extern vaddr_t directmap_virt_end; > +#ifdef CONFIG_ARM_64 > +extern vaddr_t directmap_virt_start; > +extern unsigned long directmap_base_pdx; > +#endif > + > +/* Boot-time pagetable setup */ > +extern void setup_pagetables(unsigned long boot_phys_offset); > +#define setup_mm_mappings(boot_phys_offset) setup_pagetables(boot_phys_offset) > + > +/* Non-boot CPUs use this to find the correct pagetables. */ > +extern uint64_t init_ttbr; Newline here please. > +/* > + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, > + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. > + * For Arm64, map the region in the directmap area. > + */ > +extern void setup_directmap_mappings(unsigned long base_mfn, > + unsigned long nr_mfns); > + > +#endif /* __ARCH_ARM_MM_MMU__ */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 8f15814c5e..e1ce2a62dc 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -2,371 +2,24 @@ > /* > * xen/arch/arm/mm.c > * > - * MMU code for an ARMv7-A with virt extensions. > + * Memory management common code for MMU and MPU system. > * > * Tim Deegan > * Copyright (c) 2011 Citrix Systems. > */ > > #include > -#include > #include > -#include > -#include > -#include > -#include > -#include > -#include > #include > -#include > #include > -#include > > #include > > -#include > -#include > - > -#include > - > -/* Override macros from asm/page.h to make them work with mfn_t */ > -#undef virt_to_mfn > -#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) > -#undef mfn_to_virt > -#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) > - > -#ifdef NDEBUG > -static inline void > -__attribute__ ((__format__ (__printf__, 1, 2))) > -mm_printk(const char *fmt, ...) {} > -#else > -#define mm_printk(fmt, args...) \ > - do \ > - { \ > - dprintk(XENLOG_ERR, fmt, ## args); \ > - WARN(); \ > - } while (0) > -#endif > - > -/* Static start-of-day pagetables that we use before the allocators > - * are up. These are used by all CPUs during bringup before switching > - * to the CPUs own pagetables. > - * > - * These pagetables have a very simple structure. They include: > - * - 2MB worth of 4K mappings of xen at XEN_VIRT_START, boot_first and > - * boot_second are used to populate the tables down to boot_third > - * which contains the actual mapping. > - * - a 1:1 mapping of xen at its current physical address. This uses a > - * section mapping at whichever of boot_{pgtable,first,second} > - * covers that physical address. > - * > - * For the boot CPU these mappings point to the address where Xen was > - * loaded by the bootloader. For secondary CPUs they point to the > - * relocated copy of Xen for the benefit of secondary CPUs. > - * > - * In addition to the above for the boot CPU the device-tree is > - * initially mapped in the boot misc slot. This mapping is not present > - * for secondary CPUs. > - * > - * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped > - * by the CPU once it has moved off the 1:1 mapping. > - */ > -DEFINE_BOOT_PAGE_TABLE(boot_pgtable); > -#ifdef CONFIG_ARM_64 > -DEFINE_BOOT_PAGE_TABLE(boot_first); > -DEFINE_BOOT_PAGE_TABLE(boot_first_id); > -#endif > -DEFINE_BOOT_PAGE_TABLE(boot_second_id); > -DEFINE_BOOT_PAGE_TABLE(boot_third_id); > -DEFINE_BOOT_PAGE_TABLE(boot_second); > -DEFINE_BOOT_PAGE_TABLE(boot_third); > - > -/* Main runtime page tables */ > - > -/* > - * For arm32 xen_pgtable are per-PCPU and are allocated before > - * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. > - * > - * xen_second, xen_fixmap and xen_xenmap are always shared between all > - * PCPUs. > - */ > - > -#ifdef CONFIG_ARM_64 > -#define HYP_PT_ROOT_LEVEL 0 > -static DEFINE_PAGE_TABLE(xen_pgtable); > -static DEFINE_PAGE_TABLE(xen_first); > -#define THIS_CPU_PGTABLE xen_pgtable > -#else > -#define HYP_PT_ROOT_LEVEL 1 > -/* Per-CPU pagetable pages */ > -/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ > -DEFINE_PER_CPU(lpae_t *, xen_pgtable); > -#define THIS_CPU_PGTABLE this_cpu(xen_pgtable) > -/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ > -static DEFINE_PAGE_TABLE(cpu0_pgtable); > -#endif > - > -/* Common pagetable leaves */ > -/* Second level page table used to cover Xen virtual address space */ > -static DEFINE_PAGE_TABLE(xen_second); > -/* Third level page table used for fixmap */ > -DEFINE_BOOT_PAGE_TABLE(xen_fixmap); > -/* > - * Third level page table used to map Xen itself with the XN bit set > - * as appropriate. > - */ > -static DEFINE_PAGE_TABLE(xen_xenmap); > - > -/* Non-boot CPUs use this to find the correct pagetables. */ > -uint64_t init_ttbr; > - > -static paddr_t phys_offset; > - > -/* Limits of the Xen heap */ > -mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; > -mfn_t directmap_mfn_end __read_mostly; > -vaddr_t directmap_virt_end __read_mostly; > -#ifdef CONFIG_ARM_64 > -vaddr_t directmap_virt_start __read_mostly; > -unsigned long directmap_base_pdx __read_mostly; > -#endif > - > unsigned long frametable_base_pdx __read_mostly; > -unsigned long frametable_virt_end __read_mostly; > > unsigned long max_page; > unsigned long total_pages; > > -extern char __init_begin[], __init_end[]; > - > -/* Checking VA memory layout alignment. */ > -static void __init __maybe_unused build_assertions(void) > -{ > - /* 2MB aligned regions */ > - BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); > - BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); > - /* 1GB aligned regions */ > -#ifdef CONFIG_ARM_32 > - BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); > -#else > - BUILD_BUG_ON(DIRECTMAP_VIRT_START & ~FIRST_MASK); > -#endif > - /* Page table structure constraints */ > -#ifdef CONFIG_ARM_64 > - BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); > -#endif > - BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); > -#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE > - BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); > -#endif > - /* > - * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), > - * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st > - * slot in the page tables. > - */ > -#define CHECK_SAME_SLOT(level, virt1, virt2) \ > - BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2)) > - > -#ifdef CONFIG_ARM_64 > - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0)); > - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START); > -#endif > - CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0)); > - CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START); > - > -#undef CHECK_SAME_SLOT > -} > - > -static lpae_t *xen_map_table(mfn_t mfn) > -{ > - /* > - * During early boot, map_domain_page() may be unusable. Use the > - * PMAP to map temporarily a page-table. > - */ > - if ( system_state == SYS_STATE_early_boot ) > - return pmap_map(mfn); > - > - return map_domain_page(mfn); > -} > - > -static void xen_unmap_table(const lpae_t *table) > -{ > - /* > - * During early boot, xen_map_table() will not use map_domain_page() > - * but the PMAP. > - */ > - if ( system_state == SYS_STATE_early_boot ) > - pmap_unmap(table); > - else > - unmap_domain_page(table); > -} > - > -void dump_pt_walk(paddr_t ttbr, paddr_t addr, > - unsigned int root_level, > - unsigned int nr_root_tables) > -{ > - static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; > - const mfn_t root_mfn = maddr_to_mfn(ttbr); > - const unsigned int offsets[4] = { > - zeroeth_table_offset(addr), > - first_table_offset(addr), > - second_table_offset(addr), > - third_table_offset(addr) > - }; > - lpae_t pte, *mapping; > - unsigned int level, root_table; > - > -#ifdef CONFIG_ARM_32 > - BUG_ON(root_level < 1); > -#endif > - BUG_ON(root_level > 3); > - > - if ( nr_root_tables > 1 ) > - { > - /* > - * Concatenated root-level tables. The table number will be > - * the offset at the previous level. It is not possible to > - * concatenate a level-0 root. > - */ > - BUG_ON(root_level == 0); > - root_table = offsets[root_level - 1]; > - printk("Using concatenated root table %u\n", root_table); > - if ( root_table >= nr_root_tables ) > - { > - printk("Invalid root table offset\n"); > - return; > - } > - } > - else > - root_table = 0; > - > - mapping = xen_map_table(mfn_add(root_mfn, root_table)); > - > - for ( level = root_level; ; level++ ) > - { > - if ( offsets[level] > XEN_PT_LPAE_ENTRIES ) > - break; > - > - pte = mapping[offsets[level]]; > - > - printk("%s[0x%03x] = 0x%"PRIpaddr"\n", > - level_strs[level], offsets[level], pte.bits); > - > - if ( level == 3 || !pte.walk.valid || !pte.walk.table ) > - break; > - > - /* For next iteration */ > - xen_unmap_table(mapping); > - mapping = xen_map_table(lpae_get_mfn(pte)); > - } > - > - xen_unmap_table(mapping); > -} > - > -void dump_hyp_walk(vaddr_t addr) > -{ > - uint64_t ttbr = READ_SYSREG64(TTBR0_EL2); > - > - printk("Walking Hypervisor VA 0x%"PRIvaddr" " > - "on CPU%d via TTBR 0x%016"PRIx64"\n", > - addr, smp_processor_id(), ttbr); > - > - dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); > -} > - > -lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) > -{ > - lpae_t e = (lpae_t) { > - .pt = { > - .valid = 1, /* Mappings are present */ > - .table = 0, /* Set to 1 for links and 4k maps */ > - .ai = attr, > - .ns = 1, /* Hyp mode is in the non-secure world */ > - .up = 1, /* See below */ > - .ro = 0, /* Assume read-write */ > - .af = 1, /* No need for access tracking */ > - .ng = 1, /* Makes TLB flushes easier */ > - .contig = 0, /* Assume non-contiguous */ > - .xn = 1, /* No need to execute outside .text */ > - .avail = 0, /* Reference count for domheap mapping */ > - }}; > - /* > - * For EL2 stage-1 page table, up (aka AP[1]) is RES1 as the translation > - * regime applies to only one exception level (see D4.4.4 and G4.6.1 > - * in ARM DDI 0487B.a). If this changes, remember to update the > - * hard-coded values in head.S too. > - */ > - > - switch ( attr ) > - { > - case MT_NORMAL_NC: > - /* > - * ARM ARM: Overlaying the shareability attribute (DDI > - * 0406C.b B3-1376 to 1377) > - * > - * A memory region with a resultant memory type attribute of Normal, > - * and a resultant cacheability attribute of Inner Non-cacheable, > - * Outer Non-cacheable, must have a resultant shareability attribute > - * of Outer Shareable, otherwise shareability is UNPREDICTABLE. > - * > - * On ARMv8 sharability is ignored and explicitly treated as Outer > - * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. > - */ > - e.pt.sh = LPAE_SH_OUTER; > - break; > - case MT_DEVICE_nGnRnE: > - case MT_DEVICE_nGnRE: > - /* > - * Shareability is ignored for non-Normal memory, Outer is as > - * good as anything. > - * > - * On ARMv8 sharability is ignored and explicitly treated as Outer > - * Shareable for any device memory type. > - */ > - e.pt.sh = LPAE_SH_OUTER; > - break; > - default: > - e.pt.sh = LPAE_SH_INNER; /* Xen mappings are SMP coherent */ > - break; > - } > - > - ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); > - > - lpae_set_mfn(e, mfn); > - > - return e; > -} > - > -/* Map a 4k page in a fixmap entry */ > -void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags) > -{ > - int res; > - > - res = map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags); > - BUG_ON(res != 0); > -} > - > -/* Remove a mapping from a fixmap entry */ > -void clear_fixmap(unsigned int map) > -{ > - int res; > - > - res = destroy_xen_mappings(FIXMAP_ADDR(map), FIXMAP_ADDR(map) + PAGE_SIZE); > - BUG_ON(res != 0); > -} > - > -void *map_page_to_xen_misc(mfn_t mfn, unsigned int attributes) > -{ > - set_fixmap(FIXMAP_MISC, mfn, attributes); > - > - return fix_to_virt(FIXMAP_MISC); > -} > - > -void unmap_page_from_xen_misc(void) > -{ > - clear_fixmap(FIXMAP_MISC); > -} > - > void flush_page_to_ram(unsigned long mfn, bool sync_icache) > { > void *v = map_domain_page(_mfn(mfn)); > @@ -386,878 +39,6 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache) > invalidate_icache(); > } > > -static inline lpae_t pte_of_xenaddr(vaddr_t va) > -{ > - paddr_t ma = va + phys_offset; > - > - return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); > -} > - > -void * __init early_fdt_map(paddr_t fdt_paddr) > -{ > - /* We are using 2MB superpage for mapping the FDT */ > - paddr_t base_paddr = fdt_paddr & SECOND_MASK; > - paddr_t offset; > - void *fdt_virt; > - uint32_t size; > - int rc; > - > - /* > - * Check whether the physical FDT address is set and meets the minimum > - * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at > - * least 8 bytes so that we always access the magic and size fields > - * of the FDT header after mapping the first chunk, double check if > - * that is indeed the case. > - */ > - BUILD_BUG_ON(MIN_FDT_ALIGN < 8); > - if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) > - return NULL; > - > - /* The FDT is mapped using 2MB superpage */ > - BUILD_BUG_ON(BOOT_FDT_VIRT_START % SZ_2M); > - > - rc = map_pages_to_xen(BOOT_FDT_VIRT_START, maddr_to_mfn(base_paddr), > - SZ_2M >> PAGE_SHIFT, > - PAGE_HYPERVISOR_RO | _PAGE_BLOCK); > - if ( rc ) > - panic("Unable to map the device-tree.\n"); > - > - > - offset = fdt_paddr % SECOND_SIZE; > - fdt_virt = (void *)BOOT_FDT_VIRT_START + offset; > - > - if ( fdt_magic(fdt_virt) != FDT_MAGIC ) > - return NULL; > - > - size = fdt_totalsize(fdt_virt); > - if ( size > MAX_FDT_SIZE ) > - return NULL; > - > - if ( (offset + size) > SZ_2M ) > - { > - rc = map_pages_to_xen(BOOT_FDT_VIRT_START + SZ_2M, > - maddr_to_mfn(base_paddr + SZ_2M), > - SZ_2M >> PAGE_SHIFT, > - PAGE_HYPERVISOR_RO | _PAGE_BLOCK); > - if ( rc ) > - panic("Unable to map the device-tree\n"); > - } > - > - return fdt_virt; > -} > - > -void __init remove_early_mappings(void) > -{ > - int rc; > - > - /* destroy the _PAGE_BLOCK mapping */ > - rc = modify_xen_mappings(BOOT_FDT_VIRT_START, > - BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, > - _PAGE_BLOCK); > - BUG_ON(rc); > -} > - > -/* > - * After boot, Xen page-tables should not contain mapping that are both > - * Writable and eXecutables. > - * > - * This should be called on each CPU to enforce the policy. > - */ > -static void xen_pt_enforce_wnx(void) > -{ > - WRITE_SYSREG(READ_SYSREG(SCTLR_EL2) | SCTLR_Axx_ELx_WXN, SCTLR_EL2); > - /* > - * The TLBs may cache SCTLR_EL2.WXN. So ensure it is synchronized > - * before flushing the TLBs. > - */ > - isb(); > - flush_xen_tlb_local(); > -} > - > -extern void switch_ttbr(uint64_t ttbr); > - > -/* Clear a translation table and clean & invalidate the cache */ > -static void clear_table(void *table) > -{ > - clear_page(table); > - clean_and_invalidate_dcache_va_range(table, PAGE_SIZE); > -} > - > -/* Boot-time pagetable setup. > - * Changes here may need matching changes in head.S */ > -void __init setup_pagetables(unsigned long boot_phys_offset) > -{ > - uint64_t ttbr; > - lpae_t pte, *p; > - int i; > - > - phys_offset = boot_phys_offset; > - > -#ifdef CONFIG_ARM_64 > - p = (void *) xen_pgtable; > - p[0] = pte_of_xenaddr((uintptr_t)xen_first); > - p[0].pt.table = 1; > - p[0].pt.xn = 0; > - p = (void *) xen_first; > -#else > - p = (void *) cpu0_pgtable; > -#endif > - > - /* Map xen second level page-table */ > - p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); > - p[0].pt.table = 1; > - p[0].pt.xn = 0; > - > - /* Break up the Xen mapping into 4k pages and protect them separately. */ > - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) > - { > - vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT); > - > - if ( !is_kernel(va) ) > - break; > - pte = pte_of_xenaddr(va); > - pte.pt.table = 1; /* 4k mappings always have this bit set */ > - if ( is_kernel_text(va) || is_kernel_inittext(va) ) > - { > - pte.pt.xn = 0; > - pte.pt.ro = 1; > - } > - if ( is_kernel_rodata(va) ) > - pte.pt.ro = 1; > - xen_xenmap[i] = pte; > - } > - > - /* Initialise xen second level entries ... */ > - /* ... Xen's text etc */ > - > - pte = pte_of_xenaddr((vaddr_t)xen_xenmap); > - pte.pt.table = 1; > - xen_second[second_table_offset(XEN_VIRT_START)] = pte; > - > - /* ... Fixmap */ > - pte = pte_of_xenaddr((vaddr_t)xen_fixmap); > - pte.pt.table = 1; > - xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte; > - > -#ifdef CONFIG_ARM_64 > - ttbr = (uintptr_t) xen_pgtable + phys_offset; > -#else > - ttbr = (uintptr_t) cpu0_pgtable + phys_offset; > -#endif > - > - switch_ttbr(ttbr); > - > - xen_pt_enforce_wnx(); > - > -#ifdef CONFIG_ARM_32 > - per_cpu(xen_pgtable, 0) = cpu0_pgtable; > -#endif > -} > - > -static void clear_boot_pagetables(void) > -{ > - /* > - * Clear the copy of the boot pagetables. Each secondary CPU > - * rebuilds these itself (see head.S). > - */ > - clear_table(boot_pgtable); > -#ifdef CONFIG_ARM_64 > - clear_table(boot_first); > - clear_table(boot_first_id); > -#endif > - clear_table(boot_second); > - clear_table(boot_third); > -} > - > -#ifdef CONFIG_ARM_64 > -int init_secondary_pagetables(int cpu) > -{ > - clear_boot_pagetables(); > - > - /* Set init_ttbr for this CPU coming up. All CPus share a single setof > - * pagetables, but rewrite it each time for consistency with 32 bit. */ > - init_ttbr = (uintptr_t) xen_pgtable + phys_offset; > - clean_dcache(init_ttbr); > - return 0; > -} > -#else > -int init_secondary_pagetables(int cpu) > -{ > - lpae_t *first; > - > - first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ > - > - if ( !first ) > - { > - printk("CPU%u: Unable to allocate the first page-table\n", cpu); > - return -ENOMEM; > - } > - > - /* Initialise root pagetable from root of boot tables */ > - memcpy(first, cpu0_pgtable, PAGE_SIZE); > - per_cpu(xen_pgtable, cpu) = first; > - > - if ( !init_domheap_mappings(cpu) ) > - { > - printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); > - per_cpu(xen_pgtable, cpu) = NULL; > - free_xenheap_page(first); > - return -ENOMEM; > - } > - > - clear_boot_pagetables(); > - > - /* Set init_ttbr for this CPU coming up */ > - init_ttbr = __pa(first); > - clean_dcache(init_ttbr); > - > - return 0; > -} > -#endif > - > -/* MMU setup for secondary CPUS (which already have paging enabled) */ > -void mmu_init_secondary_cpu(void) > -{ > - xen_pt_enforce_wnx(); > -} > - > -#ifdef CONFIG_ARM_32 > -/* > - * Set up the direct-mapped xenheap: > - * up to 1GB of contiguous, always-mapped memory. > - */ > -void __init setup_directmap_mappings(unsigned long base_mfn, > - unsigned long nr_mfns) > -{ > - int rc; > - > - rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, > - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); > - if ( rc ) > - panic("Unable to setup the directmap mappings.\n"); > - > - /* Record where the directmap is, for translation routines. */ > - directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; > -} > -#else /* CONFIG_ARM_64 */ > -/* Map the region in the directmap area. */ > -void __init setup_directmap_mappings(unsigned long base_mfn, > - unsigned long nr_mfns) > -{ > - int rc; > - > - /* First call sets the directmap physical and virtual offset. */ > - if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) > - { > - unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); > - > - directmap_mfn_start = _mfn(base_mfn); > - directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); > - /* > - * The base address may not be aligned to the first level > - * size (e.g. 1GB when using 4KB pages). This would prevent > - * superpage mappings for all the regions because the virtual > - * address and machine address should both be suitably aligned. > - * > - * Prevent that by offsetting the start of the directmap virtual > - * address. > - */ > - directmap_virt_start = DIRECTMAP_VIRT_START + > - (base_mfn - mfn_gb) * PAGE_SIZE; > - } > - > - if ( base_mfn < mfn_x(directmap_mfn_start) ) > - panic("cannot add directmap mapping at %lx below heap start %lx\n", > - base_mfn, mfn_x(directmap_mfn_start)); > - > - rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), > - _mfn(base_mfn), nr_mfns, > - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); > - if ( rc ) > - panic("Unable to setup the directmap mappings.\n"); > -} > -#endif > - > -/* Map a frame table to cover physical addresses ps through pe */ > -void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) > -{ > - unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - > - mfn_to_pdx(maddr_to_mfn(ps)) + 1; > - unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); > - mfn_t base_mfn; > - const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); > - int rc; > - > - frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); > - /* Round up to 2M or 32M boundary, as appropriate. */ > - frametable_size = ROUNDUP(frametable_size, mapping_size); > - base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); > - > - rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, > - frametable_size >> PAGE_SHIFT, > - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); > - if ( rc ) > - panic("Unable to setup the frametable mappings.\n"); > - > - memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); > - memset(&frame_table[nr_pdxs], -1, > - frametable_size - (nr_pdxs * sizeof(struct page_info))); > - > - frametable_virt_end = FRAMETABLE_VIRT_START + (nr_pdxs * sizeof(struct page_info)); > -} > - > -void *__init arch_vmap_virt_end(void) > -{ > - return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); > -} > - > -/* > - * This function should only be used to remap device address ranges > - * TODO: add a check to verify this assumption > - */ > -void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) > -{ > - mfn_t mfn = _mfn(PFN_DOWN(pa)); > - unsigned int offs = pa & (PAGE_SIZE - 1); > - unsigned int nr = PFN_UP(offs + len); > - void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); > - > - if ( ptr == NULL ) > - return NULL; > - > - return ptr + offs; > -} > - > -void *ioremap(paddr_t pa, size_t len) > -{ > - return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); > -} > - > -static int create_xen_table(lpae_t *entry) > -{ > - mfn_t mfn; > - void *p; > - lpae_t pte; > - > - if ( system_state != SYS_STATE_early_boot ) > - { > - struct page_info *pg = alloc_domheap_page(NULL, 0); > - > - if ( pg == NULL ) > - return -ENOMEM; > - > - mfn = page_to_mfn(pg); > - } > - else > - mfn = alloc_boot_pages(1, 1); > - > - p = xen_map_table(mfn); > - clear_page(p); > - xen_unmap_table(p); > - > - pte = mfn_to_xen_entry(mfn, MT_NORMAL); > - pte.pt.table = 1; > - write_pte(entry, pte); > - > - return 0; > -} > - > -#define XEN_TABLE_MAP_FAILED 0 > -#define XEN_TABLE_SUPER_PAGE 1 > -#define XEN_TABLE_NORMAL_PAGE 2 > - > -/* > - * Take the currently mapped table, find the corresponding entry, > - * and map the next table, if available. > - * > - * The read_only parameters indicates whether intermediate tables should > - * be allocated when not present. > - * > - * Return values: > - * XEN_TABLE_MAP_FAILED: Either read_only was set and the entry > - * was empty, or allocating a new page failed. > - * XEN_TABLE_NORMAL_PAGE: next level mapped normally > - * XEN_TABLE_SUPER_PAGE: The next entry points to a superpage. > - */ > -static int xen_pt_next_level(bool read_only, unsigned int level, > - lpae_t **table, unsigned int offset) > -{ > - lpae_t *entry; > - int ret; > - mfn_t mfn; > - > - entry = *table + offset; > - > - if ( !lpae_is_valid(*entry) ) > - { > - if ( read_only ) > - return XEN_TABLE_MAP_FAILED; > - > - ret = create_xen_table(entry); > - if ( ret ) > - return XEN_TABLE_MAP_FAILED; > - } > - > - /* The function xen_pt_next_level is never called at the 3rd level */ > - if ( lpae_is_mapping(*entry, level) ) > - return XEN_TABLE_SUPER_PAGE; > - > - mfn = lpae_get_mfn(*entry); > - > - xen_unmap_table(*table); > - *table = xen_map_table(mfn); > - > - return XEN_TABLE_NORMAL_PAGE; > -} > - > -/* Sanity check of the entry */ > -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, > - unsigned int flags) > -{ > - /* Sanity check when modifying an entry. */ > - if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) > - { > - /* We don't allow modifying an invalid entry. */ > - if ( !lpae_is_valid(entry) ) > - { > - mm_printk("Modifying invalid entry is not allowed.\n"); > - return false; > - } > - > - /* We don't allow modifying a table entry */ > - if ( !lpae_is_mapping(entry, level) ) > - { > - mm_printk("Modifying a table entry is not allowed.\n"); > - return false; > - } > - > - /* We don't allow changing memory attributes. */ > - if ( entry.pt.ai != PAGE_AI_MASK(flags) ) > - { > - mm_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", > - entry.pt.ai, PAGE_AI_MASK(flags)); > - return false; > - } > - > - /* We don't allow modifying entry with contiguous bit set. */ > - if ( entry.pt.contig ) > - { > - mm_printk("Modifying entry with contiguous bit set is not allowed.\n"); > - return false; > - } > - } > - /* Sanity check when inserting a mapping */ > - else if ( flags & _PAGE_PRESENT ) > - { > - /* We should be here with a valid MFN. */ > - ASSERT(!mfn_eq(mfn, INVALID_MFN)); > - > - /* > - * We don't allow replacing any valid entry. > - * > - * Note that the function xen_pt_update() relies on this > - * assumption and will skip the TLB flush. The function will need > - * to be updated if the check is relaxed. > - */ > - if ( lpae_is_valid(entry) ) > - { > - if ( lpae_is_mapping(entry, level) ) > - mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", > - mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); > - else > - mm_printk("Trying to replace a table with a mapping.\n"); > - return false; > - } > - } > - /* Sanity check when removing a mapping. */ > - else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) > - { > - /* We should be here with an invalid MFN. */ > - ASSERT(mfn_eq(mfn, INVALID_MFN)); > - > - /* We don't allow removing a table */ > - if ( lpae_is_table(entry, level) ) > - { > - mm_printk("Removing a table is not allowed.\n"); > - return false; > - } > - > - /* We don't allow removing a mapping with contiguous bit set. */ > - if ( entry.pt.contig ) > - { > - mm_printk("Removing entry with contiguous bit set is not allowed.\n"); > - return false; > - } > - } > - /* Sanity check when populating the page-table. No check so far. */ > - else > - { > - ASSERT(flags & _PAGE_POPULATE); > - /* We should be here with an invalid MFN */ > - ASSERT(mfn_eq(mfn, INVALID_MFN)); > - } > - > - return true; > -} > - > -/* Update an entry at the level @target. */ > -static int xen_pt_update_entry(mfn_t root, unsigned long virt, > - mfn_t mfn, unsigned int target, > - unsigned int flags) > -{ > - int rc; > - unsigned int level; > - lpae_t *table; > - /* > - * The intermediate page tables are read-only when the MFN is not valid > - * and we are not populating page table. > - * This means we either modify permissions or remove an entry. > - */ > - bool read_only = mfn_eq(mfn, INVALID_MFN) && !(flags & _PAGE_POPULATE); > - lpae_t pte, *entry; > - > - /* convenience aliases */ > - DECLARE_OFFSETS(offsets, (paddr_t)virt); > - > - /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together. */ > - ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) != (_PAGE_POPULATE|_PAGE_PRESENT)); > - > - table = xen_map_table(root); > - for ( level = HYP_PT_ROOT_LEVEL; level < target; level++ ) > - { > - rc = xen_pt_next_level(read_only, level, &table, offsets[level]); > - if ( rc == XEN_TABLE_MAP_FAILED ) > - { > - /* > - * We are here because xen_pt_next_level has failed to map > - * the intermediate page table (e.g the table does not exist > - * and the pt is read-only). It is a valid case when > - * removing a mapping as it may not exist in the page table. > - * In this case, just ignore it. > - */ > - if ( flags & (_PAGE_PRESENT|_PAGE_POPULATE) ) > - { > - mm_printk("%s: Unable to map level %u\n", __func__, level); > - rc = -ENOENT; > - goto out; > - } > - else > - { > - rc = 0; > - goto out; > - } > - } > - else if ( rc != XEN_TABLE_NORMAL_PAGE ) > - break; > - } > - > - if ( level != target ) > - { > - mm_printk("%s: Shattering superpage is not supported\n", __func__); > - rc = -EOPNOTSUPP; > - goto out; > - } > - > - entry = table + offsets[level]; > - > - rc = -EINVAL; > - if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) > - goto out; > - > - /* If we are only populating page-table, then we are done. */ > - rc = 0; > - if ( flags & _PAGE_POPULATE ) > - goto out; > - > - /* We are removing the page */ > - if ( !(flags & _PAGE_PRESENT) ) > - memset(&pte, 0x00, sizeof(pte)); > - else > - { > - /* We are inserting a mapping => Create new pte. */ > - if ( !mfn_eq(mfn, INVALID_MFN) ) > - { > - pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); > - > - /* > - * First and second level pages set pte.pt.table = 0, but > - * third level entries set pte.pt.table = 1. > - */ > - pte.pt.table = (level == 3); > - } > - else /* We are updating the permission => Copy the current pte. */ > - pte = *entry; > - > - /* Set permission */ > - pte.pt.ro = PAGE_RO_MASK(flags); > - pte.pt.xn = PAGE_XN_MASK(flags); > - /* Set contiguous bit */ > - pte.pt.contig = !!(flags & _PAGE_CONTIG); > - } > - > - write_pte(entry, pte); > - > - rc = 0; > - > -out: > - xen_unmap_table(table); > - > - return rc; > -} > - > -/* Return the level where mapping should be done */ > -static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, > - unsigned int flags) > -{ > - unsigned int level; > - unsigned long mask; > - > - /* > - * Don't take into account the MFN when removing mapping (i.e > - * MFN_INVALID) to calculate the correct target order. > - * > - * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. > - * They are or-ed together and then checked against the size of > - * each level. > - * > - * `left` is not included and checked separately to allow > - * superpage mapping even if it is not properly aligned (the > - * user may have asked to map 2MB + 4k). > - */ > - mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; > - mask |= vfn; > - > - /* > - * Always use level 3 mapping unless the caller request block > - * mapping. > - */ > - if ( likely(!(flags & _PAGE_BLOCK)) ) > - level = 3; > - else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && > - (nr >= BIT(FIRST_ORDER, UL)) ) > - level = 1; > - else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && > - (nr >= BIT(SECOND_ORDER, UL)) ) > - level = 2; > - else > - level = 3; > - > - return level; > -} > - > -#define XEN_PT_4K_NR_CONTIG 16 > - > -/* > - * Check whether the contiguous bit can be set. Return the number of > - * contiguous entry allowed. If not allowed, return 1. > - */ > -static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, > - unsigned int level, unsigned long left, > - unsigned int flags) > -{ > - unsigned long nr_contig; > - > - /* > - * Allow the contiguous bit to set when the caller requests block > - * mapping. > - */ > - if ( !(flags & _PAGE_BLOCK) ) > - return 1; > - > - /* > - * We don't allow to remove mapping with the contiguous bit set. > - * So shortcut the logic and directly return 1. > - */ > - if ( mfn_eq(mfn, INVALID_MFN) ) > - return 1; > - > - /* > - * The number of contiguous entries varies depending on the page > - * granularity used. The logic below assumes 4KB. > - */ > - BUILD_BUG_ON(PAGE_SIZE != SZ_4K); > - > - /* > - * In order to enable the contiguous bit, we should have enough entries > - * to map left and both the virtual and physical address should be > - * aligned to the size of 16 translation tables entries. > - */ > - nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; > - > - if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) > - return 1; > - > - return XEN_PT_4K_NR_CONTIG; > -} > - > -static DEFINE_SPINLOCK(xen_pt_lock); > - > -static int xen_pt_update(unsigned long virt, > - mfn_t mfn, > - /* const on purpose as it is used for TLB flush */ > - const unsigned long nr_mfns, > - unsigned int flags) > -{ > - int rc = 0; > - unsigned long vfn = virt >> PAGE_SHIFT; > - unsigned long left = nr_mfns; > - > - /* > - * For arm32, page-tables are different on each CPUs. Yet, they share > - * some common mappings. It is assumed that only common mappings > - * will be modified with this function. > - * > - * XXX: Add a check. > - */ > - const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); > - > - /* > - * The hardware was configured to forbid mapping both writeable and > - * executable. > - * When modifying/creating mapping (i.e _PAGE_PRESENT is set), > - * prevent any update if this happen. > - */ > - if ( (flags & _PAGE_PRESENT) && !PAGE_RO_MASK(flags) && > - !PAGE_XN_MASK(flags) ) > - { > - mm_printk("Mappings should not be both Writeable and Executable.\n"); > - return -EINVAL; > - } > - > - if ( flags & _PAGE_CONTIG ) > - { > - mm_printk("_PAGE_CONTIG is an internal only flag.\n"); > - return -EINVAL; > - } > - > - if ( !IS_ALIGNED(virt, PAGE_SIZE) ) > - { > - mm_printk("The virtual address is not aligned to the page-size.\n"); > - return -EINVAL; > - } > - > - spin_lock(&xen_pt_lock); > - > - while ( left ) > - { > - unsigned int order, level, nr_contig, new_flags; > - > - level = xen_pt_mapping_level(vfn, mfn, left, flags); > - order = XEN_PT_LEVEL_ORDER(level); > - > - ASSERT(left >= BIT(order, UL)); > - > - /* > - * Check if we can set the contiguous mapping and update the > - * flags accordingly. > - */ > - nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); > - new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); > - > - for ( ; nr_contig > 0; nr_contig-- ) > - { > - rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, > - new_flags); > - if ( rc ) > - break; > - > - vfn += 1U << order; > - if ( !mfn_eq(mfn, INVALID_MFN) ) > - mfn = mfn_add(mfn, 1U << order); > - > - left -= (1U << order); > - } > - > - if ( rc ) > - break; > - } > - > - /* > - * The TLBs flush can be safely skipped when a mapping is inserted > - * as we don't allow mapping replacement (see xen_pt_check_entry()). > - * > - * For all the other cases, the TLBs will be flushed unconditionally > - * even if the mapping has failed. This is because we may have > - * partially modified the PT. This will prevent any unexpected > - * behavior afterwards. > - */ > - if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) > - flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); > - > - spin_unlock(&xen_pt_lock); > - > - return rc; > -} > - > -int map_pages_to_xen(unsigned long virt, > - mfn_t mfn, > - unsigned long nr_mfns, > - unsigned int flags) > -{ > - return xen_pt_update(virt, mfn, nr_mfns, flags); > -} > - > -int populate_pt_range(unsigned long virt, unsigned long nr_mfns) > -{ > - return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); > -} > - > -int destroy_xen_mappings(unsigned long s, unsigned long e) > -{ > - ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > - ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > - ASSERT(s <= e); > - return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); > -} > - > -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) > -{ > - ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > - ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > - ASSERT(s <= e); > - return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); > -} > - > -/* Release all __init and __initdata ranges to be reused */ > -void free_init_memory(void) This function doesn't look specific to the MMU. > -{ > - paddr_t pa = virt_to_maddr(__init_begin); > - unsigned long len = __init_end - __init_begin; > - uint32_t insn; > - unsigned int i, nr = len / sizeof(insn); > - uint32_t *p; > - int rc; > - > - rc = modify_xen_mappings((unsigned long)__init_begin, > - (unsigned long)__init_end, PAGE_HYPERVISOR_RW); > - if ( rc ) > - panic("Unable to map RW the init section (rc = %d)\n", rc); > - > - /* > - * From now on, init will not be used for execution anymore, > - * so nuke the instruction cache to remove entries related to init. > - */ > - invalidate_icache_local(); > - > -#ifdef CONFIG_ARM_32 > - /* udf instruction i.e (see A8.8.247 in ARM DDI 0406C.c) */ > - insn = 0xe7f000f0; > -#else > - insn = AARCH64_BREAK_FAULT; > -#endif > - p = (uint32_t *)__init_begin; > - for ( i = 0; i < nr; i++ ) > - *(p + i) = insn; > - > - rc = destroy_xen_mappings((unsigned long)__init_begin, > - (unsigned long)__init_end); > - if ( rc ) > - panic("Unable to remove the init section (rc = %d)\n", rc); > - > - init_domheap_pages(pa, pa + len); > - printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10); > -} > - [...] > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 43e9a1be4d..87a12042cc 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -20,8 +20,10 @@ > */ > > #include > +#include > #include > #include > +#include Regardless of what I wrote above, none of the code you add seems to require > > /* Xen MPU memory region mapping table. */ > pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") > @@ -38,6 +40,71 @@ uint64_t __ro_after_init next_transient_region_idx; > /* Maximum number of supported MPU memory regions by the EL2 MPU. */ > uint64_t __ro_after_init max_xen_mpumap; > > +/* TODO: Implementation on the first usage */ It is not clear what you mean given there are some callers. > +void dump_hyp_walk(vaddr_t addr) > +{ Please add ASSERT_UNREACHABLE() for any dummy helper you have introduced any plan to implement later. This will be helpful to track down any function you haven't implemented. > +} > + > +void * __init early_fdt_map(paddr_t fdt_paddr) > +{ > + return NULL; > +} > + > +void __init remove_early_mappings(void) > +{ Ditto > +} > + > +int init_secondary_pagetables(int cpu) > +{ > + return -ENOSYS; > +} > + > +void mmu_init_secondary_cpu(void) > +{ Ditto. The name of the function is also a bit odd given this is an MPU specific file. This likely want to be renamed to mm_init_secondary_cpu(). > +} > + > +void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes) > +{ > + return NULL; > +} > + > +void *ioremap(paddr_t pa, size_t len) > +{ > + return NULL; > +} > + > +int map_pages_to_xen(unsigned long virt, > + mfn_t mfn, > + unsigned long nr_mfns, > + unsigned int flags) > +{ > + return -ENOSYS; > +} > + > +int destroy_xen_mappings(unsigned long s, unsigned long e) > +{ > + return -ENOSYS; > +} > + > +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) > +{ > + return -ENOSYS; > +} > + > +void free_init_memory(void) > +{ Ditto. > +} > + > +int xenmem_add_to_physmap_one( > + struct domain *d, > + unsigned int space, > + union add_to_physmap_extra extra, > + unsigned long idx, > + gfn_t gfn) > +{ > + return -ENOSYS; > +} > + > /* > * Local variables: > * mode: C -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:32:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:32:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489923.758483 (Exim 4.92) (envelope-from ) id 1pOmcL-0007Rc-A5; Sun, 05 Feb 2023 21:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489923.758483; Sun, 05 Feb 2023 21:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmcL-0007RV-70; Sun, 05 Feb 2023 21:32:09 +0000 Received: by outflank-mailman (input) for mailman id 489923; Sun, 05 Feb 2023 21:32:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmcK-0007RP-5Q for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:32:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmcJ-0001me-TK; Sun, 05 Feb 2023 21:32:07 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmcJ-0007lM-Oe; Sun, 05 Feb 2023 21:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rgQPzDvNwaKEKzxLcArcFBSuFajaFYaULD9DIlRdUEY=; b=drtTmNOUOAb5jH8kUsYwgJOO9V jbpITAJGEbCH3TjTn52VR6O47TyYGYSRk/jhjcdViYx13KcKxem3QaoHRlZpcnMdvrQPwzXLAsGDl R7qc8VOLjyYqRlR/o6Bgu9wnZbE9Emgy2zH2sIabKv+m2qRR9+23fWR80VNXPSGyFts8=; Message-ID: <906699b8-14ae-d038-3693-63338d7a52cf@xen.org> Date: Sun, 5 Feb 2023 21:32:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 16/40] xen/arm: introduce setup_mm_mappings To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-17-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-17-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > Function setup_pagetables is responsible for boot-time pagetable setup > in MMU system. > But in MPU system, we have already built up start-of-day Xen MPU memory region > mapping at the very beginning in assembly. > > So in order to keep only one codeflow in arm/setup.c, setup_mm_mappings > , with a more generic name, is introduced and act as an empty stub in > MPU system. is the empty stub temporarily? > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/mm.h | 2 ++ > xen/arch/arm/include/asm/mm_mpu.h | 16 ++++++++++++++++ > xen/arch/arm/setup.c | 2 +- > 3 files changed, 19 insertions(+), 1 deletion(-) > create mode 100644 xen/arch/arm/include/asm/mm_mpu.h > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 1b9fdb6ff5..9b4c07d965 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -243,6 +243,8 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) > > #ifndef CONFIG_HAS_MPU > #include > +#else > +#include > #endif > > /* Page-align address and convert to frame number format */ > diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h > new file mode 100644 > index 0000000000..1f3cff7743 > --- /dev/null > +++ b/xen/arch/arm/include/asm/mm_mpu.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef __ARCH_ARM_MM_MPU__ > +#define __ARCH_ARM_MM_MPU__ > + > +#define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) > + > +#endif /* __ARCH_ARM_MM_MPU__ */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 1f26f67b90..d7d200179c 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1003,7 +1003,7 @@ void __init start_xen(unsigned long boot_phys_offset, > /* Initialize traps early allow us to get backtrace when an error occurred */ > init_traps(); > > - setup_pagetables(boot_phys_offset); > + setup_mm_mappings(boot_phys_offset); You are renaming the caller but not the function. Why? > > smp_clear_cpu_maps(); > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:36:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:36:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489930.758496 (Exim 4.92) (envelope-from ) id 1pOmgq-0008BX-U1; Sun, 05 Feb 2023 21:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489930.758496; Sun, 05 Feb 2023 21:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmgq-0008BQ-RF; Sun, 05 Feb 2023 21:36:48 +0000 Received: by outflank-mailman (input) for mailman id 489930; Sun, 05 Feb 2023 21:36:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmgq-0008BK-34 for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:36:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmgp-0001sO-Lb; Sun, 05 Feb 2023 21:36:47 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmgp-0008Fz-H7; Sun, 05 Feb 2023 21:36:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZqrmuQ9dLxa5H22TvQN1+OSjR901nErJ+uR839KHeOE=; b=viQBJN2FRVfCVBiUj15cTot6Qa HEryOxJXgrjxPJh810dyoT4s7zV80H7z1WI9N8vtkU5vFiogZ/dWq8+AfHX1dy3uQXTw79y1EbqT0 dmFzs2lBk0/B6zUCX8jDwu95MnvmJMkPOsrQ3TUxCUgqNnJaza6Tj5jAKuFevPq1WCUE=; Message-ID: <185b3850-e11e-01a0-be90-f21a631310a9@xen.org> Date: Sun, 5 Feb 2023 21:36:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 17/40] xen/mpu: plump virt/maddr/mfn convertion in MPU system To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-18-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-18-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, title: typo: s/convertion/conversion/ On 13/01/2023 05:28, Penny Zheng wrote: > virt_to_maddr and maddr_to_virt are used widely in Xen code. So > even there is no VMSA in MPU system, we keep the interface name to > stay the same code flow. > > We move the existing virt/maddr convertion from mm.h to mm_mmu.h. > And the MPU version of virt/maddr convertion is simple, returning ditto. > the input address as the output. > > We should overide virt_to_mfn/mfn_to_virt in source file mm_mpu.c the ditto: s/overide/override/ > same way in mm_mmu.c. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/mm.h | 26 -------------------------- > xen/arch/arm/include/asm/mm_mmu.h | 26 ++++++++++++++++++++++++++ > xen/arch/arm/include/asm/mm_mpu.h | 13 +++++++++++++ > xen/arch/arm/mm_mpu.c | 6 ++++++ > 4 files changed, 45 insertions(+), 26 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 9b4c07d965..e29158028a 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -250,32 +250,6 @@ static inline void __iomem *ioremap_wc(paddr_t start, size_t len) > /* Page-align address and convert to frame number format */ > #define paddr_to_pfn_aligned(paddr) paddr_to_pfn(PAGE_ALIGN(paddr)) > > -static inline paddr_t __virt_to_maddr(vaddr_t va) > -{ > - uint64_t par = va_to_par(va); > - return (par & PADDR_MASK & PAGE_MASK) | (va & ~PAGE_MASK); > -} > -#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) > - > -#ifdef CONFIG_ARM_32 > -static inline void *maddr_to_virt(paddr_t ma) > -{ > - ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); > - ma -= mfn_to_maddr(directmap_mfn_start); > - return (void *)(unsigned long) ma + XENHEAP_VIRT_START; > -} > -#else > -static inline void *maddr_to_virt(paddr_t ma) > -{ > - ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < > - (DIRECTMAP_SIZE >> PAGE_SHIFT)); > - return (void *)(XENHEAP_VIRT_START - > - (directmap_base_pdx << PAGE_SHIFT) + > - ((ma & ma_va_bottom_mask) | > - ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); > -} > -#endif > - > /* > * Translate a guest virtual address to a machine address. > * Return the fault information if the translation has failed else 0. > diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h > index a5e63d8af8..6d7e5ddde7 100644 > --- a/xen/arch/arm/include/asm/mm_mmu.h > +++ b/xen/arch/arm/include/asm/mm_mmu.h > @@ -23,6 +23,32 @@ extern uint64_t init_ttbr; > extern void setup_directmap_mappings(unsigned long base_mfn, > unsigned long nr_mfns); > > +static inline paddr_t __virt_to_maddr(vaddr_t va) > +{ > + uint64_t par = va_to_par(va); > + return (par & PADDR_MASK & PAGE_MASK) | (va & ~PAGE_MASK); > +} > +#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) > + > +#ifdef CONFIG_ARM_32 > +static inline void *maddr_to_virt(paddr_t ma) > +{ > + ASSERT(is_xen_heap_mfn(maddr_to_mfn(ma))); > + ma -= mfn_to_maddr(directmap_mfn_start); > + return (void *)(unsigned long) ma + XENHEAP_VIRT_START; > +} > +#else > +static inline void *maddr_to_virt(paddr_t ma) > +{ > + ASSERT((mfn_to_pdx(maddr_to_mfn(ma)) - directmap_base_pdx) < > + (DIRECTMAP_SIZE >> PAGE_SHIFT)); > + return (void *)(XENHEAP_VIRT_START - > + (directmap_base_pdx << PAGE_SHIFT) + > + ((ma & ma_va_bottom_mask) | > + ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); > +} > +#endif > + > #endif /* __ARCH_ARM_MM_MMU__ */ > > /* > diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h > index 1f3cff7743..3a4b07f187 100644 > --- a/xen/arch/arm/include/asm/mm_mpu.h > +++ b/xen/arch/arm/include/asm/mm_mpu.h > @@ -4,6 +4,19 @@ > > #define setup_mm_mappings(boot_phys_offset) ((void)(boot_phys_offset)) > > +static inline paddr_t __virt_to_maddr(vaddr_t va) > +{ > + /* In MPU system, VA == PA. */ > + return (paddr_t)va; > +} > +#define virt_to_maddr(va) __virt_to_maddr((vaddr_t)(va)) This define is exactly the same as the MMU version. Can it be implemented in mm.h? > + > +static inline void *maddr_to_virt(paddr_t ma) > +{ > + /* In MPU system, VA == PA. */ > + return (void *)ma; > +} > + > #endif /* __ARCH_ARM_MM_MPU__ */ > > /* > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 87a12042cc..c9e17ab6da 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -29,6 +29,12 @@ > pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") > xen_mpumap[ARM_MAX_MPU_MEMORY_REGIONS]; > > +/* Override macros from asm/page.h to make them work with mfn_t */ > +#undef virt_to_mfn > +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) > +#undef mfn_to_virt > +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) They should be implemented when you need them. > + > /* Index into MPU memory region map for fixed regions, ascending from zero. */ > uint64_t __ro_after_init next_fixed_region_idx; > /* Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:45:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:45:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489938.758510 (Exim 4.92) (envelope-from ) id 1pOmpT-0001Ke-Rw; Sun, 05 Feb 2023 21:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489938.758510; Sun, 05 Feb 2023 21:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmpT-0001KX-PA; Sun, 05 Feb 2023 21:45:43 +0000 Received: by outflank-mailman (input) for mailman id 489938; Sun, 05 Feb 2023 21:45:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmpS-0001KR-Tu for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:45:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmpS-00023N-Jm; Sun, 05 Feb 2023 21:45:42 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmpS-0000QK-BX; Sun, 05 Feb 2023 21:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=stmcVTX7D38ez8lDEdWS3566SIyC+saTOBhoUPWmnM8=; b=DuzOwG9xYfASXm6i5RRVgKP/ye 3TlbaGaUj1Cp1R8aj4SvE3yAtbL1WGvJN63tprA6DOtNmF0c57mrcCuZC6T2jLnnWLVM30zd7hWFX KhstFz+3I9ybtDpqoeZ9TpmwPrUgw6H1Op19ancObl4STMp1BQkCPzSZAtMLm8JCISLE=; Message-ID: Date: Sun, 5 Feb 2023 21:45:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-20-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 19/40] xen/mpu: populate a new region in Xen MPU mapping table In-Reply-To: <20230113052914.3845596-20-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > The new helper xen_mpumap_update() is responsible for updating an entry > in Xen MPU memory mapping table, including creating a new entry, updating > or destroying an existing one. > > This commit only talks about populating a new entry in Xen MPU mapping table( > xen_mpumap). Others will be introduced in the following commits. > > In xen_mpumap_update_entry(), firstly, we shall check if requested address > range [base, limit) is not mapped. Then we use pr_of_xenaddr() to build up the > structure of MPU memory region(pr_t). > In the last, we set memory attribute and permission based on variable @flags. > > To summarize all region attributes in one variable @flags, layout of the > flags is elaborated as follows: > [0:2] Memory attribute Index > [3:4] Execute Never > [5:6] Access Permission > [7] Region Present > Also, we provide a set of definitions(REGION_HYPERVISOR_RW, etc) that combine > the memory attribute and permission for common combinations. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 72 +++++++ > xen/arch/arm/mm_mpu.c | 276 ++++++++++++++++++++++++++- > 2 files changed, 340 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index c945dd53db..fcde6ad0db 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -16,6 +16,61 @@ > */ > #define ARM_MAX_MPU_MEMORY_REGIONS 255 > > +/* Access permission attributes. */ > +/* Read/Write at EL2, No Access at EL1/EL0. */ > +#define AP_RW_EL2 0x0 > +/* Read/Write at EL2/EL1/EL0 all levels. */ > +#define AP_RW_ALL 0x1 > +/* Read-only at EL2, No Access at EL1/EL0. */ > +#define AP_RO_EL2 0x2 > +/* Read-only at EL2/EL1/EL0 all levels. */ > +#define AP_RO_ALL 0x3 > + > +/* > + * Excute never. > + * Stage 1 EL2 translation regime. > + * XN[1] determines whether execution of the instruction fetched from the MPU > + * memory region is permitted. > + * Stage 2 EL1/EL0 translation regime. > + * XN[0] determines whether execution of the instruction fetched from the MPU > + * memory region is permitted. > + */ > +#define XN_DISABLED 0x0 > +#define XN_P2M_ENABLED 0x1 > +#define XN_ENABLED 0x2 > + > +/* > + * Layout of the flags used for updating Xen MPU region attributes > + * [0:2] Memory attribute Index > + * [3:4] Execute Never > + * [5:6] Access Permission > + * [7] Region Present > + */ > +#define _REGION_AI_BIT 0 > +#define _REGION_XN_BIT 3 > +#define _REGION_AP_BIT 5 > +#define _REGION_PRESENT_BIT 7 > +#define _REGION_XN (2U << _REGION_XN_BIT) > +#define _REGION_RO (2U << _REGION_AP_BIT) > +#define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) > +#define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) > +#define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) > +#define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) > +#define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) > + > +/* > + * _REGION_NORMAL is convenience define. It is not meant to be used > + * outside of this header. > + */ > +#define _REGION_NORMAL (MT_NORMAL|_REGION_PRESENT) > + > +#define REGION_HYPERVISOR_RW (_REGION_NORMAL|_REGION_XN) > +#define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) > + > +#define REGION_HYPERVISOR REGION_HYPERVISOR_RW > + > +#define INVALID_REGION (~0UL) > + > #ifndef __ASSEMBLY__ > > /* Protection Region Base Address Register */ > @@ -49,6 +104,23 @@ typedef struct { > prlar_t prlar; > } pr_t; > > +/* Access to set base address of MPU protection region(pr_t). */ > +#define pr_set_base(pr, paddr) ({ \ > + pr_t *_pr = pr; \ > + _pr->prbar.reg.base = (paddr >> MPU_REGION_SHIFT); \ > +}) > + > +/* Access to set limit address of MPU protection region(pr_t). */ > +#define pr_set_limit(pr, paddr) ({ \ > + pr_t *_pr = pr; \ > + _pr->prlar.reg.limit = (paddr >> MPU_REGION_SHIFT); \ > +}) > + > +#define region_is_valid(pr) ({ \ > + pr_t *_pr = pr; \ > + _pr->prlar.reg.en; \ > +}) Can they all be implemented using static inline? > + > #endif /* __ASSEMBLY__ */ > > #endif /* __ARM64_MPU_H__ */ > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index f2b494449c..08720a7c19 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -22,9 +22,23 @@ > #include > #include > #include > +#include > #include > #include > > +#ifdef NDEBUG > +static inline void > +__attribute__ ((__format__ (__printf__, 1, 2))) > +region_printk(const char *fmt, ...) {} > +#else > +#define region_printk(fmt, args...) \ > + do \ > + { \ > + dprintk(XENLOG_ERR, fmt, ## args); \ > + WARN(); \ > + } while (0) > +#endif > + > /* Xen MPU memory region mapping table. */ > pr_t __aligned(PAGE_SIZE) __section(".data.page_aligned") > xen_mpumap[ARM_MAX_MPU_MEMORY_REGIONS]; > @@ -46,6 +60,8 @@ uint64_t __ro_after_init next_transient_region_idx; > /* Maximum number of supported MPU memory regions by the EL2 MPU. */ > uint64_t __ro_after_init max_xen_mpumap; > > +static DEFINE_SPINLOCK(xen_mpumap_lock); > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -73,6 +89,28 @@ uint64_t __ro_after_init max_xen_mpumap; > _pr; \ > }) > > +/* > + * In boot-time, fixed MPU regions(e.g. Xen text section) are added > + * at the front, indexed by next_fixed_region_idx, the others like > + * boot-only regions(e.g. early FDT) should be added at the rear, > + * indexed by next_transient_region_idx. > + * With more and more MPU regions added-in, when the two indexes > + * meet and pass with each other, we would run out of the whole > + * EL2 MPU memory regions. > + */ > +static bool __init xen_boot_mpu_regions_is_full(void) > +{ > + return next_transient_region_idx < next_fixed_region_idx; > +} > + > +static void __init update_boot_xen_mpumap_idx(uint64_t idx) > +{ > + if ( idx == next_transient_region_idx ) > + next_transient_region_idx--; > + else > + next_fixed_region_idx++; > +} > + > /* > * Access MPU protection region, including both read/write operations. > * Armv8-R AArch64 at most supports 255 MPU protection regions. > @@ -197,6 +235,236 @@ static void access_protection_region(bool read, pr_t *pr_read, > } > } > > +/* > + * Standard entry for building up the structure of MPU memory region(pr_t). > + * It is equivalent to mfn_to_xen_entry in MMU system. > + * base and limit both refer to inclusive address. > + */ > +static inline pr_t pr_of_xenaddr(paddr_t base, paddr_t limit, unsigned attr) > +{ > + prbar_t prbar; > + prlar_t prlar; > + pr_t region; > + > + /* Build up value for PRBAR_EL2. */ > + prbar = (prbar_t) { > + .reg = { > + .ap = AP_RW_EL2, /* Read/Write at EL2, no access at EL1/EL0. */ > + .xn = XN_ENABLED, /* No need to execute outside .text */ > + }}; > + > + switch ( attr ) > + { > + case MT_NORMAL_NC: > + /* > + * ARM ARM: Overlaying the shareability attribute (DDI > + * 0406C.b B3-1376 to 1377) > + * > + * A memory region with a resultant memory type attribute of normal, > + * and a resultant cacheability attribute of Inner non-cacheable, > + * outer non-cacheable, must have a resultant shareability attribute > + * of outer shareable, otherwise shareability is UNPREDICTABLE. > + * > + * On ARMv8 sharability is ignored and explicitly treated as outer > + * shareable for normal inner non-cacheable, outer non-cacheable. > + */ > + prbar.reg.sh = LPAE_SH_OUTER; > + break; > + case MT_DEVICE_nGnRnE: > + case MT_DEVICE_nGnRE: > + /* > + * Shareability is ignored for non-normal memory, Outer is as > + * good as anything. > + * > + * On ARMv8 sharability is ignored and explicitly treated as outer > + * shareable for any device memory type. > + */ > + prbar.reg.sh = LPAE_SH_OUTER; > + break; > + default: > + /* Xen mappings are SMP coherent */ > + prbar.reg.sh = LPAE_SH_INNER; > + break; > + } > + > + /* Build up value for PRLAR_EL2. */ > + prlar = (prlar_t) { > + .reg = { > + .ns = 0, /* Hyp mode is in secure world */ > + .ai = attr, > + .en = 1, /* Region enabled */ > + }}; > + > + /* Build up MPU memory region. */ > + region = (pr_t) { > + .prbar = prbar, > + .prlar = prlar, > + }; > + > + /* Set base address and limit address. */ > + pr_set_base(®ion, base); > + pr_set_limit(®ion, limit); > + > + return region; > +} > + > +#define MPUMAP_REGION_FAILED 0 > +#define MPUMAP_REGION_FOUND 1 > +#define MPUMAP_REGION_INCLUSIVE 2 > +#define MPUMAP_REGION_OVERLAP 3 > + > +/* > + * Check whether memory range [base, limit] is mapped in MPU memory > + * region table \mpu. Only address range is considered, memory attributes > + * and permission are not considered here. > + * If we find the match, the associated index will be filled up. > + * If the entry is not present, INVALID_REGION will be set in \index > + * > + * Make sure that parameter \base and \limit are both referring > + * inclusive addresss > + * > + * Return values: > + * MPUMAP_REGION_FAILED: no mapping and no overmapping > + * MPUMAP_REGION_FOUND: find an exact match in address > + * MPUMAP_REGION_INCLUSIVE: find an inclusive match in address > + * MPUMAP_REGION_OVERLAP: overlap with the existing mapping > + */ > +static int mpumap_contain_region(pr_t *mpu, uint64_t nr_regions, > + paddr_t base, paddr_t limit, uint64_t *index) Is it really possible to support 2^64 - 1 region? If so, is that the case on arm32 as well? > +{ > + uint64_t i = 0; > + uint64_t _index = INVALID_REGION; > + > + /* Allow index to be NULL */ > + index = index ?: &_index; > + > + for ( ; i < nr_regions; i++ ) > + { > + paddr_t iter_base = pr_get_base(&mpu[i]); > + paddr_t iter_limit = pr_get_limit(&mpu[i]); > + > + /* Found an exact valid match */ > + if ( (iter_base == base) && (iter_limit == limit) && > + region_is_valid(&mpu[i]) ) > + { > + *index = i; > + return MPUMAP_REGION_FOUND; > + } > + > + /* No overlapping */ > + if ( (iter_limit < base) || (iter_base > limit) ) > + continue; > + /* Inclusive and valid */ > + else if ( (base >= iter_base) && (limit <= iter_limit) && > + region_is_valid(&mpu[i]) ) > + { > + *index = i; > + return MPUMAP_REGION_INCLUSIVE; > + } > + else > + { > + region_printk("Range 0x%"PRIpaddr" - 0x%"PRIpaddr" overlaps with the existing region 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", > + base, limit, iter_base, iter_limit); > + return MPUMAP_REGION_OVERLAP; > + } > + } > + > + return MPUMAP_REGION_FAILED; > +} > + > +/* > + * Update an entry at the index @idx. > + * @base: base address > + * @limit: limit address(exclusive) > + * @flags: region attributes, should be the combination of REGION_HYPERVISOR_xx > + */ > +static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > + unsigned int flags) > +{ > + uint64_t idx; > + int rc; > + > + rc = mpumap_contain_region(xen_mpumap, max_xen_mpumap, base, limit - 1, > + &idx); > + if ( rc == MPUMAP_REGION_OVERLAP ) > + return -EINVAL; > + > + /* We are inserting a mapping => Create new region. */ > + if ( flags & _REGION_PRESENT ) > + { > + if ( rc != MPUMAP_REGION_FAILED ) > + return -EINVAL; > + > + if ( xen_boot_mpu_regions_is_full() ) > + { > + region_printk("There is no room left in EL2 MPU memory region mapping\n"); > + return -ENOMEM; > + } > + > + /* During boot time, the default index is next_fixed_region_idx. */ > + if ( system_state <= SYS_STATE_active ) > + idx = next_fixed_region_idx; > + > + xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, REGION_AI_MASK(flags)); > + /* Set permission */ > + xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); > + xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); > + > + /* Update and enable the region */ > + access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), > + idx); > + > + if ( system_state <= SYS_STATE_active ) > + update_boot_xen_mpumap_idx(idx); > + } > + > + return 0; > +} > + > +static int xen_mpumap_update(paddr_t base, paddr_t limit, unsigned int flags) > +{ > + int rc; > + > + /* > + * The hardware was configured to forbid mapping both writeable and > + * executable. > + * When modifying/creating mapping (i.e _REGION_PRESENT is set), > + * prevent any update if this happen. > + */ > + if ( (flags & _REGION_PRESENT) && !REGION_RO_MASK(flags) && > + !REGION_XN_MASK(flags) ) > + { > + region_printk("Mappings should not be both Writeable and Executable.\n"); > + return -EINVAL; > + } > + > + if ( !IS_ALIGNED(base, PAGE_SIZE) || !IS_ALIGNED(limit, PAGE_SIZE) ) > + { > + region_printk("base address 0x%"PRIpaddr", or limit address 0x%"PRIpaddr" is not page aligned.\n", > + base, limit); > + return -EINVAL; > + } > + > + spin_lock(&xen_mpumap_lock); > + > + rc = xen_mpumap_update_entry(base, limit, flags); > + > + spin_unlock(&xen_mpumap_lock); > + > + return rc; > +} > + > +int map_pages_to_xen(unsigned long virt, > + mfn_t mfn, > + unsigned long nr_mfns, > + unsigned int flags) > +{ > + ASSERT(virt == mfn_to_maddr(mfn)); > + > + return xen_mpumap_update(mfn_to_maddr(mfn), > + mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); > +} > + > /* TODO: Implementation on the first usage */ > void dump_hyp_walk(vaddr_t addr) > { > @@ -230,14 +498,6 @@ void *ioremap(paddr_t pa, size_t len) > return NULL; > } > > -int map_pages_to_xen(unsigned long virt, > - mfn_t mfn, > - unsigned long nr_mfns, > - unsigned int flags) > -{ > - return -ENOSYS; > -} > - Why do you implement map_pages_to_xen() at a different place? > int destroy_xen_mappings(unsigned long s, unsigned long e) > { > return -ENOSYS; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 21:52:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 21:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489946.758522 (Exim 4.92) (envelope-from ) id 1pOmvi-0002q3-Om; Sun, 05 Feb 2023 21:52:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489946.758522; Sun, 05 Feb 2023 21:52:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmvi-0002pw-Lr; Sun, 05 Feb 2023 21:52:10 +0000 Received: by outflank-mailman (input) for mailman id 489946; Sun, 05 Feb 2023 21:52:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmvh-0002pq-3n for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 21:52:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOmvg-0002K2-R7; Sun, 05 Feb 2023 21:52:08 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOmvg-0000fO-L4; Sun, 05 Feb 2023 21:52:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=xnqDBk6xPdw309UqTwMdtSsOvwiXsPkD09RmWniMJIE=; b=ByEAfBxfgDnpgIcNZ2oGtuBBDU 5mzY/esZIbCcg8ji1nljqUKsx+allLcgSQlNBTxVVLtzk8pp8PNB0gLz3oNMZQ1pYredhJfJccJ15 B5X0ZpRaT8SuPVYi5QAYivfGUOR1UM62bbr+BwiKPyT/NB2bEuWOQhGnTKBbtZhiJel0=; Message-ID: Date: Sun, 5 Feb 2023 21:52:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-21-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems In-Reply-To: <20230113052914.3845596-21-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > In MPU system, device tree binary can be packed with Xen > image through CONFIG_DTB_FILE, or provided by bootloader through x0. > > In MPU system, each section in xen.lds.S is PAGE_SIZE aligned. > So in order to not overlap with the previous BSS section, dtb section > should be made page-aligned too. > We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make it happen. > > In this commit, we map early FDT with a transient MPU memory region at > rear with REGION_HYPERVISOR_BOOT. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 5 +++ > xen/arch/arm/mm_mpu.c | 63 +++++++++++++++++++++++++--- > xen/arch/arm/xen.lds.S | 5 ++- > 3 files changed, 67 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index fcde6ad0db..b85e420a90 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -45,18 +45,22 @@ > * [3:4] Execute Never > * [5:6] Access Permission > * [7] Region Present > + * [8] Boot-only Region > */ > #define _REGION_AI_BIT 0 > #define _REGION_XN_BIT 3 > #define _REGION_AP_BIT 5 > #define _REGION_PRESENT_BIT 7 > +#define _REGION_BOOTONLY_BIT 8 In a follow-up patch, you are replacing BOOTONLY with TRANSIENT. Please avoid renaming new functions and instead introduce them with the correct name from the start. > #define _REGION_XN (2U << _REGION_XN_BIT) > #define _REGION_RO (2U << _REGION_AP_BIT) > #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) > +#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) > #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) > #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) > #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) > #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) > +#define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) & 0x1U) > > /* > * _REGION_NORMAL is convenience define. It is not meant to be used > @@ -68,6 +72,7 @@ > #define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) > > #define REGION_HYPERVISOR REGION_HYPERVISOR_RW > +#define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) > > #define INVALID_REGION (~0UL) > > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 08720a7c19..b34dbf4515 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -20,11 +20,16 @@ > */ > > #include > +#include > #include > #include > +#include > +#include > #include > #include > +#include > #include > +#include > > #ifdef NDEBUG > static inline void > @@ -62,6 +67,8 @@ uint64_t __ro_after_init max_xen_mpumap; > > static DEFINE_SPINLOCK(xen_mpumap_lock); > > +static paddr_t dtb_paddr; > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -403,7 +410,16 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > > /* During boot time, the default index is next_fixed_region_idx. */ > if ( system_state <= SYS_STATE_active ) > - idx = next_fixed_region_idx; > + { > + /* > + * If it is a boot-only region (i.e. region for early FDT), > + * it shall be added from the tail for late init re-organizing > + */ > + if ( REGION_BOOTONLY_MASK(flags) ) > + idx = next_transient_region_idx; > + else > + idx = next_fixed_region_idx; > + } > > xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, REGION_AI_MASK(flags)); > /* Set permission */ > @@ -465,14 +481,51 @@ int map_pages_to_xen(unsigned long virt, > mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); > } > > -/* TODO: Implementation on the first usage */ > -void dump_hyp_walk(vaddr_t addr) > +void * __init early_fdt_map(paddr_t fdt_paddr) A fair amount of this code is the same as the MMU version. Can we share some code? > { > + void *fdt_virt; > + uint32_t size; > + > + /* > + * Check whether the physical FDT address is set and meets the minimum > + * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at > + * least 8 bytes so that we always access the magic and size fields > + * of the FDT header after mapping the first chunk, double check if > + * that is indeed the case. > + */ > + BUILD_BUG_ON(MIN_FDT_ALIGN < 8); > + if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) > + return NULL; > + > + dtb_paddr = fdt_paddr; > + /* > + * In MPU system, device tree binary can be packed with Xen image > + * through CONFIG_DTB_FILE, or provided by bootloader through x0. > + * Map FDT with a transient MPU memory region of MAX_FDT_SIZE. > + * After that, we can do some magic check. > + */ > + if ( map_pages_to_xen(round_pgdown(fdt_paddr), > + maddr_to_mfn(round_pgdown(fdt_paddr)), > + round_pgup(MAX_FDT_SIZE) >> PAGE_SHIFT, > + REGION_HYPERVISOR_BOOT) ) > + panic("Unable to map the device-tree.\n"); > + > + /* VA == PA */ > + fdt_virt = maddr_to_virt(fdt_paddr); > + > + if ( fdt_magic(fdt_virt) != FDT_MAGIC ) > + return NULL; > + > + size = fdt_totalsize(fdt_virt); > + if ( size > MAX_FDT_SIZE ) > + return NULL; > + > + return fdt_virt; > } > > -void * __init early_fdt_map(paddr_t fdt_paddr) Same as the previous patch, why do you implmenet early_fdt_map() at a different place in the file? > +/* TODO: Implementation on the first usage */ > +void dump_hyp_walk(vaddr_t addr) > { > - return NULL; > } > > void __init remove_early_mappings(void) > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 79965a3c17..0565e22a1f 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -218,7 +218,10 @@ SECTIONS > _end = . ; > > /* Section for the device tree blob (if any). */ > - .dtb : { *(.dtb) } :text > + .dtb : { > + . = ALIGN(PAGE_SIZE); > + *(.dtb) > + } :text > > DWARF2_DEBUG_SECTIONS > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 22:07:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 22:07:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489952.758533 (Exim 4.92) (envelope-from ) id 1pOnAj-0004Zw-56; Sun, 05 Feb 2023 22:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489952.758533; Sun, 05 Feb 2023 22:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnAj-0004Zp-1C; Sun, 05 Feb 2023 22:07:41 +0000 Received: by outflank-mailman (input) for mailman id 489952; Sun, 05 Feb 2023 22:07:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnAh-0004Zj-I0 for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 22:07:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnAh-0002cy-9m; Sun, 05 Feb 2023 22:07:39 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOnAh-0001gP-3a; Sun, 05 Feb 2023 22:07:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6AdZCZI6fb0VGIeKRACPAcGvZAbt3Nl8xzVZj9BRxMk=; b=nYTtoyv8vLgYMEMm363LU+Gx0n MS6pgAKJG8fT4PYS2X3fYpDxQZTV7DQh95Y1sD8BIKHyY12NagkW+WtP3yPqThfkLE+AsJFML5N71 uINGnwEufrL5ipO5QwBUjYOZquabJVUnhni22TVajcps3fdI7rIuMEuDipOU7tX9VXQE=; Message-ID: <2382e2c1-ab5a-ad7d-1426-b323d5f02ba6@xen.org> Date: Sun, 5 Feb 2023 22:07:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-24-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 23/40] xen/mpu: initialize frametable in MPU system In-Reply-To: <20230113052914.3845596-24-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > Xen is using page as the smallest granularity for memory managment. > And we want to follow the same concept in MPU system. > That is, structure page_info and the frametable which is used for storing > and managing page_info is also required in MPU system. > > In MPU system, since there is no virtual address translation (VA == PA), > we can not use a fixed VA address(FRAMETABLE_VIRT_START) to map frametable > like MMU system does. > Instead, we define a variable "struct page_info *frame_table" as frametable > pointer, and ask boot allocator to allocate memory for frametable. > > As frametable is successfully initialized, the convertion between machine frame > number/machine address/"virtual address" and page-info structure is > ready too, like mfn_to_page/maddr_to_page/virt_to_page, etc > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/mm.h | 15 --------------- > xen/arch/arm/include/asm/mm_mmu.h | 16 ++++++++++++++++ You are already moving some bits related to the frametable in an earlier patch. So I am a bit surprised to see some changes in mm_mmu.h here. I would also rather prefer if the code changes are separated from the addition of the MPU code. They could them be moved at the beginning of the series and hopefully be merged before the rest (reducing the size this series). > xen/arch/arm/include/asm/mm_mpu.h | 17 +++++++++++++++++ > xen/arch/arm/mm_mpu.c | 25 +++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 15 deletions(-) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index e29158028a..7969ec9f98 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -176,7 +176,6 @@ struct page_info > > #define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) > > -#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) > /* PDX of the first page in the frame table. */ > extern unsigned long frametable_base_pdx; > > @@ -280,20 +279,6 @@ static inline uint64_t gvirt_to_maddr(vaddr_t va, paddr_t *pa, > #define virt_to_mfn(va) __virt_to_mfn(va) > #define mfn_to_virt(mfn) __mfn_to_virt(mfn) > > -/* Convert between Xen-heap virtual addresses and page-info structures. */ > -static inline struct page_info *virt_to_page(const void *v) > -{ > - unsigned long va = (unsigned long)v; > - unsigned long pdx; > - > - ASSERT(va >= XENHEAP_VIRT_START); > - ASSERT(va < directmap_virt_end); > - > - pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; > - pdx += mfn_to_pdx(directmap_mfn_start); > - return frame_table + pdx - frametable_base_pdx; > -} > - > static inline void *page_to_virt(const struct page_info *pg) > { > return mfn_to_virt(mfn_x(page_to_mfn(pg))); > diff --git a/xen/arch/arm/include/asm/mm_mmu.h b/xen/arch/arm/include/asm/mm_mmu.h > index 6d7e5ddde7..bc1b04c4c7 100644 > --- a/xen/arch/arm/include/asm/mm_mmu.h > +++ b/xen/arch/arm/include/asm/mm_mmu.h > @@ -23,6 +23,8 @@ extern uint64_t init_ttbr; > extern void setup_directmap_mappings(unsigned long base_mfn, > unsigned long nr_mfns); > > +#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) > + > static inline paddr_t __virt_to_maddr(vaddr_t va) > { > uint64_t par = va_to_par(va); > @@ -49,6 +51,20 @@ static inline void *maddr_to_virt(paddr_t ma) > } > #endif > > +/* Convert between Xen-heap virtual addresses and page-info structures. */ > +static inline struct page_info *virt_to_page(const void *v) > +{ > + unsigned long va = (unsigned long)v; > + unsigned long pdx; > + > + ASSERT(va >= XENHEAP_VIRT_START); > + ASSERT(va < directmap_virt_end); > + > + pdx = (va - XENHEAP_VIRT_START) >> PAGE_SHIFT; > + pdx += mfn_to_pdx(directmap_mfn_start); > + return frame_table + pdx - frametable_base_pdx; > +} > + > #endif /* __ARCH_ARM_MM_MMU__ */ > > /* > diff --git a/xen/arch/arm/include/asm/mm_mpu.h b/xen/arch/arm/include/asm/mm_mpu.h > index fe6a828a50..eebd5b5d35 100644 > --- a/xen/arch/arm/include/asm/mm_mpu.h > +++ b/xen/arch/arm/include/asm/mm_mpu.h > @@ -9,6 +9,8 @@ > */ > extern void setup_static_mappings(void); > > +extern struct page_info *frame_table; > + > static inline paddr_t __virt_to_maddr(vaddr_t va) > { > /* In MPU system, VA == PA. */ > @@ -22,6 +24,21 @@ static inline void *maddr_to_virt(paddr_t ma) > return (void *)ma; > } > > +/* Convert between virtual address to page-info structure. */ > +static inline struct page_info *virt_to_page(const void *v) > +{ > + unsigned long va = (unsigned long)v; > + unsigned long pdx; > + > + /* > + * In MPU system, VA == PA, virt_to_maddr() outputs the > + * exact input address. > + */ You are describing an implementation details of virt_to_maddr() which doesn't matter here. > + pdx = mfn_to_pdx(maddr_to_mfn(virt_to_maddr(va))); Why not using virt_to_mfn()? Also, I would consider to add ASSERT(mfn_is_valid(...)) to confirm the MFN you pass is covered by the frametable. (This would be a sort of equalivent check to the MMU one). > + > + return frame_table + pdx - frametable_base_pdx; > +} > + > #endif /* __ARCH_ARM_MM_MPU__ */ > > /* > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index f057ee26df..7b282be4fb 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -69,6 +69,8 @@ static DEFINE_SPINLOCK(xen_mpumap_lock); > > static paddr_t dtb_paddr; > > +struct page_info *frame_table; > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -564,6 +566,29 @@ void __init setup_static_mappings(void) > /* TODO: guest memory section, device memory section, boot-module section, etc */ > } > > +/* Map a frame table to cover physical addresses ps through pe */ > +void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) I have to admit, I am a bit puzzled why you added some stub in earlier patches for some functions but not for others. How did you make the decision on which one to stub? > +{ > + mfn_t base_mfn; > + unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - > + mfn_to_pdx(maddr_to_mfn(ps)) + 1; > + unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); > + > + frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); > + frametable_size = ROUNDUP(frametable_size, PAGE_SIZE); Maybe assert()/panic() the function is not called twice? > + /* > + * Since VA == PA in MPU and we've already setup Xenheap mapping > + * in setup_staticheap_mappings(), we could easily deduce the > + * "virtual address" of frame table. > + */ > + base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 1); > + frame_table = (struct page_info*)mfn_to_virt(base_mfn); Coding style: "struct page_info *". > + > + memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); > + memset(&frame_table[nr_pdxs], -1, > + frametable_size - (nr_pdxs * sizeof(struct page_info))); > +} > + > /* TODO: Implementation on the first usage */ > void dump_hyp_walk(vaddr_t addr) > { Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 05 22:27:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Feb 2023 22:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489959.758543 (Exim 4.92) (envelope-from ) id 1pOnTE-000786-Lg; Sun, 05 Feb 2023 22:26:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489959.758543; Sun, 05 Feb 2023 22:26:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnTE-00077z-IU; Sun, 05 Feb 2023 22:26:48 +0000 Received: by outflank-mailman (input) for mailman id 489959; Sun, 05 Feb 2023 22:26:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnTD-00077t-Nt for xen-devel@lists.xenproject.org; Sun, 05 Feb 2023 22:26:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOnTD-000396-Dm; Sun, 05 Feb 2023 22:26:47 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOnTD-0002Wr-8M; Sun, 05 Feb 2023 22:26:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=mIv17BOurYzN7jXQvzWRTILfXOUEiR2mUpxq65r72Hs=; b=WOls4ws1yNsfmO6GTewF/BBSNN c49sanPU6jFROX91N+PuR7SS8uk3Jez+yzqaT0e7jTDKl9Apvl7KV/NN6G1lcoZVHkXrzBISplDb0 EfqOaihXAwJCJJad1PbFE+hLqsVO3mUvVDbGSIaco54odqwdlkA/qfwOQK4aF8jlkl1E=; Message-ID: <32e86166-ea9c-ef58-3651-aca635435cb8@xen.org> Date: Sun, 5 Feb 2023 22:26:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-37-Penny.Zheng@arm.com> From: Julien Grall Subject: Re: [PATCH v2 36/40] xen/mpu: Use secure hypervisor timer for AArch64v8R In-Reply-To: <20230113052914.3845596-37-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:29, Penny Zheng wrote: > As AArch64v8R only has one secure state, we have to use secure EL2 hypervisor > timer for Xen in secure EL2. > > In this patch, we introduce a Kconfig option ARM_SECURE_STATE. > With this new Kconfig option, we can re-define the timer's > system register name in different secure state, but keep the > timer code flow unchanged. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/Kconfig | 7 +++++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 21 ++++++++++++++++++++- > xen/arch/arm/include/asm/cpregs.h | 4 ++-- > xen/arch/arm/time.c | 14 +++++++------- > 4 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 91491341c4..ee942a33bc 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -47,6 +47,13 @@ config ARM_EFI > be booted as an EFI application. This is only useful for > Xen that may run on systems that have UEFI firmware. > > +config ARM_SECURE_STATE > + bool "Xen will run in Arm Secure State" > + depends on ARM_V8R > + help > + In this state, a Processing Element (PE) can access the secure > + physical address space, and the secure copy of banked registers. Above, you suggest that the Armv8r will always use the secure EL2 timer. But here you allow the integrator to disable it. Why? > + > config GICV3 > bool "GICv3 driver" > depends on !NEW_VGIC > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index c46daf6f69..9546e8e3d0 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -458,7 +458,6 @@ > #define ZCR_ELx_LEN_SIZE 9 > #define ZCR_ELx_LEN_MASK 0x1ff > > -/* System registers for Armv8-R AArch64 */ Why is this removed? > #ifdef CONFIG_HAS_MPU > > /* EL2 MPU Protection Region Base Address Register encode */ > @@ -510,6 +509,26 @@ > > #endif > > +#ifdef CONFIG_ARM_SECURE_STATE > +/* > + * The Armv8-R AArch64 architecture always executes code in Secure > + * state with EL2 as the highest Exception. > + * > + * Hypervisor timer registers for Secure EL2. > + */ > +#define CNTHPS_TVAL_EL2 S3_4_C14_C5_0 > +#define CNTHPS_CTL_EL2 S3_4_C14_C5_1 > +#define CNTHPS_CVAL_EL2 S3_4_C14_C5_2 > +#define CNTHPx_TVAL_EL2 CNTHPS_TVAL_EL2 > +#define CNTHPx_CTL_EL2 CNTHPS_CTL_EL2 > +#define CNTHPx_CVAL_EL2 CNTHPS_CVAL_EL2 > +#else > +/* Hypervisor timer registers for Non-Secure EL2. */ > +#define CNTHPx_TVAL_EL2 CNTHP_TVAL_EL2 > +#define CNTHPx_CTL_EL2 CNTHP_CTL_EL2 > +#define CNTHPx_CVAL_EL2 CNTHP_CVAL_EL2 > +#endif /* CONFIG_ARM_SECURE_STATE */ Given there is only one state, I would actually prefer if we alias CNTHP_*_EL2 to CNTHPS_*_EL2. So there is no renaming. > + > /* Access to system registers */ > > #define WRITE_SYSREG64(v, name) do { \ > diff --git a/xen/arch/arm/include/asm/cpregs.h b/xen/arch/arm/include/asm/cpregs.h > index 6b083de204..a704677fbc 100644 > --- a/xen/arch/arm/include/asm/cpregs.h > +++ b/xen/arch/arm/include/asm/cpregs.h > @@ -374,8 +374,8 @@ > #define CLIDR_EL1 CLIDR > #define CNTFRQ_EL0 CNTFRQ > #define CNTHCTL_EL2 CNTHCTL > -#define CNTHP_CTL_EL2 CNTHP_CTL > -#define CNTHP_CVAL_EL2 CNTHP_CVAL > +#define CNTHPx_CTL_EL2 CNTHP_CTL > +#define CNTHPx_CVAL_EL2 CNTHP_CVAL > #define CNTKCTL_EL1 CNTKCTL > #define CNTPCT_EL0 CNTPCT > #define CNTP_CTL_EL0 CNTP_CTL > diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c > index 433d7be909..3bba733b83 100644 > --- a/xen/arch/arm/time.c > +++ b/xen/arch/arm/time.c > @@ -196,13 +196,13 @@ int reprogram_timer(s_time_t timeout) > > if ( timeout == 0 ) > { > - WRITE_SYSREG(0, CNTHP_CTL_EL2); > + WRITE_SYSREG(0, CNTHPx_CTL_EL2); > return 1; > } > > deadline = ns_to_ticks(timeout) + boot_count; > - WRITE_SYSREG64(deadline, CNTHP_CVAL_EL2); > - WRITE_SYSREG(CNTx_CTL_ENABLE, CNTHP_CTL_EL2); > + WRITE_SYSREG64(deadline, CNTHPx_CVAL_EL2); > + WRITE_SYSREG(CNTx_CTL_ENABLE, CNTHPx_CTL_EL2); > isb(); > > /* No need to check for timers in the past; the Generic Timer fires > @@ -213,7 +213,7 @@ int reprogram_timer(s_time_t timeout) > /* Handle the firing timer */ > static void htimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) > { > - if ( unlikely(!(READ_SYSREG(CNTHP_CTL_EL2) & CNTx_CTL_PENDING)) ) > + if ( unlikely(!(READ_SYSREG(CNTHPx_CTL_EL2) & CNTx_CTL_PENDING)) ) > return; > > perfc_incr(hyp_timer_irqs); > @@ -222,7 +222,7 @@ static void htimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) > raise_softirq(TIMER_SOFTIRQ); > > /* Disable the timer to avoid more interrupts */ > - WRITE_SYSREG(0, CNTHP_CTL_EL2); > + WRITE_SYSREG(0, CNTHPx_CTL_EL2); > } > > static void vtimer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) > @@ -281,7 +281,7 @@ void init_timer_interrupt(void) > /* Do not let the VMs program the physical timer, only read the physical counter */ > WRITE_SYSREG(CNTHCTL_EL2_EL1PCTEN, CNTHCTL_EL2); > WRITE_SYSREG(0, CNTP_CTL_EL0); /* Physical timer disabled */ > - WRITE_SYSREG(0, CNTHP_CTL_EL2); /* Hypervisor's timer disabled */ > + WRITE_SYSREG(0, CNTHPx_CTL_EL2); /* Hypervisor's timer disabled */ > isb(); > > request_irq(timer_irq[TIMER_HYP_PPI], 0, htimer_interrupt, > @@ -301,7 +301,7 @@ void init_timer_interrupt(void) > static void deinit_timer_interrupt(void) > { > WRITE_SYSREG(0, CNTP_CTL_EL0); /* Disable physical timer */ > - WRITE_SYSREG(0, CNTHP_CTL_EL2); /* Disable hypervisor's timer */ > + WRITE_SYSREG(0, CNTHPx_CTL_EL2); /* Disable hypervisor's timer */ > isb(); > > release_irq(timer_irq[TIMER_HYP_PPI], NULL); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 06 01:04:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 01:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489970.758561 (Exim 4.92) (envelope-from ) id 1pOpv5-0005bK-J1; Mon, 06 Feb 2023 01:03:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489970.758561; Mon, 06 Feb 2023 01:03:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOpv5-0005bD-GG; Mon, 06 Feb 2023 01:03:43 +0000 Received: by outflank-mailman (input) for mailman id 489970; Mon, 06 Feb 2023 01:03:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOpv3-0005b3-Pe; Mon, 06 Feb 2023 01:03:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOpv3-0005lm-Io; Mon, 06 Feb 2023 01:03:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOpv2-00053o-Vq; Mon, 06 Feb 2023 01:03:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOpv2-0005I1-VM; Mon, 06 Feb 2023 01:03:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rp2ZjGtofgM6be8u9MbRAdL11wwCNm2q7ec18RG3Yjs=; b=p7rco1IuWlqAG+CK2uIBuRq+J0 HtoVQxx2+UmW+g5zPJ+sMw0skHYaUCMd32T09rMn1QEE2/9DQhKQA8GomRg6JK6aJvhA86P16R60V njPFMIJyC8690Cg4VLruxGO1YB2NAFxs9V+qV/PF1ZXtAcawlhDL7N8gkNOiFUr/MTtQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176392: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=ceabf6e500570ecfb311d8896c4ba9da8cf21f2a X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Mon, 06 Feb 2023 01:03:40 +0000 flight 176392 qemu-mainline real [real] flight 176405 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176392/ http://logs.test-lab.xenproject.org/osstest/logs/176405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu ceabf6e500570ecfb311d8896c4ba9da8cf21f2a baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 2 days Failing since 176352 2023-02-03 17:40:20 Z 2 days 3 attempts Testing same since 176392 2023-02-05 09:22:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Alexander Graf Daniel P. Berrangé Drew DeVault Emanuele Giuseppe Esposito Emilio Cota Evgeny Iakovlev Fuad Tabba Gerd Hoffmann Hanna Reitz Helge Deller Idan Horowitz Ilya Leoshkevich Keith Packard Kevin Wolf Laurent Vivier Letu Ren Marc-André Lureau Marcin Juszkiewicz Mark Cave-Ayland Markus Armbruster Mike Frysinger Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 3750 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Feb 06 05:27:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 05:27:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.489991.758584 (Exim 4.92) (envelope-from ) id 1pOu1q-0008IJ-MJ; Mon, 06 Feb 2023 05:26:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 489991.758584; Mon, 06 Feb 2023 05:26:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOu1q-0008IB-HL; Mon, 06 Feb 2023 05:26:58 +0000 Received: by outflank-mailman (input) for mailman id 489991; Mon, 06 Feb 2023 05:26:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOu1o-0008I1-SA; Mon, 06 Feb 2023 05:26:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOu1o-0004mp-PZ; Mon, 06 Feb 2023 05:26:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOu1o-00015B-6d; Mon, 06 Feb 2023 05:26:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOu1o-0000pR-6D; Mon, 06 Feb 2023 05:26:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jsJdwob9aVgBJuLG7PQhEv1EomDgy0VhA8sqbboRx1s=; b=PTl0FJcUG+hqFBJBBYVRP7lmbR HzW07gjGoIha5U6nyvoX+2H5C95T5BVt5Xd7bk7fRxddZKKbiiKnEUfZ6R3fJ4HbpMGE6/S8c2pCR JcMRHbwvsLakVV0X62Vv+J55iGUns9EXGfJlxnI7/fgNtZxls3I0ldLFs5kY1Ao7PH54=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176403: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=c608f6b58f306ce0e4f459af69a196f5ed6ccf45 X-Osstest-Versions-That: linux=db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 From: osstest service owner Date: Mon, 06 Feb 2023 05:26:56 +0000 flight 176403 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176403/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176376 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176376 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176376 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176376 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176376 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux c608f6b58f306ce0e4f459af69a196f5ed6ccf45 baseline version: linux db27c22251e7c8f3a9d5bfb55c9c8c701a70bbb3 Last test of basis 176376 2023-02-04 20:10:33 Z 1 days Failing since 176395 2023-02-05 12:54:58 Z 0 days 2 attempts Testing same since 176403 2023-02-05 20:41:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaro Koskinen Alan Stern Alexandre Belloni Andreas Kemnade Arnd Bergmann Borislav Petkov (AMD) Carlos Song Christophe JAILLET Daniel Scally Dmitry Perchanov Frank Li George Kennedy Gilles BULOZ Greg Kroah-Hartman Heikki Krogerus Heiko Stuebner Helge Deller Ilpo Järvinen James Clark Jiasheng Jiang Joerg Roedel Johan Hovold Jonathan Cameron Kai-Heng Feng Kajol Jain Linus Torvalds Marco Pagani Marek Vasut Michael Ellerman Michael Walle Michal Simek Miko Larsson Neil Armstrong Nicholas Piggin Olivier Moysan Peter Zijlstra (Intel) Prashanth K Pratham Pratap Randy Dunlap Rob Herring Russell King (Oracle) Sachin Sant Sam Ravnborg Samuel Holland Samuel Thibault Sathvika Vasireddy Shanker Donthineni Sourabh Jain Srinivas Kandagatla Stephen Kitt Udipto Goswami Valentin Caron # V3 Vladimir Oltean Wahaj Xiongfeng Wang Xu Yilun Zheng Yongjun jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git db27c22251e7..c608f6b58f30 c608f6b58f306ce0e4f459af69a196f5ed6ccf45 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Feb 06 07:29:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 07:29:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490004.758601 (Exim 4.92) (envelope-from ) id 1pOvwU-0004EB-F0; Mon, 06 Feb 2023 07:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490004.758601; Mon, 06 Feb 2023 07:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOvwU-0004E4-CG; Mon, 06 Feb 2023 07:29:34 +0000 Received: by outflank-mailman (input) for mailman id 490004; Mon, 06 Feb 2023 07:29:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOvwS-0004Dy-Nf for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 07:29:33 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7d00::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fda60af3-a5ef-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 08:29:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9242.eurprd04.prod.outlook.com (2603:10a6:20b:4ca::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Mon, 6 Feb 2023 07:29:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 07:29:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fda60af3-a5ef-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FE488rrudBpEmiKEczLbQVLNOfWqcVfjZkKVOKdxmllnsHfA0EPV1eRGP5X1xfc3lmpiT7p+lV31tI2le2GbO7tCyxvr1nsQyNEpO0V5KV/RPuuHZGDR2rz9VxsDXqt4K8BphWtTplVD/I3/31LZFEMVL38A9MwR4MQF9ohQeQoZGU/0ASsLRI3u9s9lE+6RWWCLFpILNNHl2mGiJCDMWbWUlcMT0TjnMMXXD3ER1bduDaV99dB0k85928uXDfwjSXGqpQfoFHtEKCTuu+oQb/v79fqYp4x6Uc3dVlxIGSKW9a6iq8us2w9ZFlQriepigxTfbRum7rq9AR2rZg2DtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FpewjFYViQTS3TbTGBCzOzSdWZJ26X2KGd9CmtR29+E=; b=AF8xCEbW7IMIqQgsb0IYBcJ/69ir+/0l/2wd+TYivknNMQn+2gQw8khx8oOuAQKSn6zvEX9JUXN0RbVKlFvzrk8J3979TKT7NpQpGwNqu4A3OdWG5OcKAsks0Ts2zqc0IFU41O0QTlL4g7CAzDW3NgmdBJShEuvHXKDTqBl31jzRm2SM/8AVm92B+/L1ux1La1b+/MRWEcFGslsQ/0GBlUXsG9aO9kRf8CL9kH31obh1cjGhHRF2lTPYBh0eQC2KPOcw6zJvJvQET9w3Dd7Mw2M3WvnSEQ139iOErxWndZutuJBGUZ/ogl2BBfeCl6IdFbZpO4lIyWCuPt4ZJY4LkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FpewjFYViQTS3TbTGBCzOzSdWZJ26X2KGd9CmtR29+E=; b=Cds9JfGLvrwuUnm9/IA+Iy3LnzGIp2kme81vvjHWq8Ef8z39BkviWhdy/Po+KeSLZoDfAvb6e/v+N9GcTCAxOIu163D22Jmej217DagrJYRRyZwtgaXbQcpK4jMhArxtKqw1PZwVrevDpuvR1VcHpvZsUp1kVBHHepBoNAviRQfpMpJ7UimsvpvrMGRo+GW7kiAtTuyoxu8GzhJb9+1cdDD74DhV7H1OGMXQYAntOUCzsYXggqCnUY4AI0mQrzM4ymHvIV3nmd7ap/7MGJGDz7Zi2M/aot+0MYGo8N7mYRm0IP989EvTtn0+uwjVOUFplAg4NBxzUo9m5/qOt0L7Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Feb 2023 08:29:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled To: Elliott Mitchell Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <202302031801.313I1SdK033264@m5p.com> Content-Language: en-US From: Jan Beulich In-Reply-To: <202302031801.313I1SdK033264@m5p.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9242:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c9c6c67-7975-4164-c3f1-08db0813e088 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IntCnNMhxj+79HM7GnnYNEJmQey+sdp9MbAfwmNyXA9n7bM7KNPxaYI825yfqsFIZtHoh1hxvRyXnEOZr5w5XYz91xDq8NnA/sJ6oV5FgmBebiOq+ltHaS0goFRA6IR6d0a6GWTLZbA4CFfSISFFNXSwF5jZoHJawrGnrpl8i+1vr3Qha29xslq9tGJNzIchV4dlNAVI9LWb4fqPSvMTLlbRyrnhRaRQJt/rMmJW8QtF6U5p0DLj+WytEcidYLgbSuVnTr2OAgPuuipP8/re47NshU4bMZDi02e0t0ms7Ts2KVC0Jta7JWciIy4yeJohj8GeHPqzpQwM+7dlYYi/E4B9jvR/4Hpqq5vDQD8ScfjdmxiNc3Atn5y1lvFR88p1c3PNNtPV1kTZXdJFSw6XgC+9XV5sHfJzsospR/o+Js0sorWVx6flIIRmRy0mMmDB2vUXWx4auHZgHjsDu8oLd9SwhWxUma0WStFHLse7xUoTLp/JspGgN3sgjHyxfAMV9G3OnxvQXUp+tWVeSemXVLY0h9tPl6JhzcM4O30wSYz+sYTUpt8VRdfeDrvndK6DF3rDLA+mE0kS1xn7XTczl1X+MaU6XAenqD48nr10FEh3K49vd8f+sOsuhUdHJErnLUVKV/C/tjA63kp4sRd2n8eu5AExhS4w+k2iny5yspiRPsuo7XR3Q3WamUmMACQgQUCy2ClFk/+KVufkBK8WvINXaMEZ7vAaSTsI7px6pRQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199018)(31686004)(38100700002)(86362001)(2616005)(316002)(54906003)(31696002)(36756003)(5660300002)(26005)(6512007)(478600001)(66476007)(4326008)(186003)(66946007)(6486002)(66556008)(6506007)(8936002)(8676002)(53546011)(2906002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWg2MGdtVU44ZVlzaXpDTHFGS1U3aXEwem1VRHNnYy8wT1JrOVlXekJhUlZs?= =?utf-8?B?WnlEdDk1ZGY0M3JHNlY1bXQ3ZGc4cVA1V3Z0ZkVkWGUvQnhUWWpWVUhMSjhz?= =?utf-8?B?TkZGemltbFlwUmJVWU1kUXRYSHJPRFRpSmowaHE2a2lwSHF0NTYrN254SGdY?= =?utf-8?B?TVl3azN2VTRjdFdOdDQ3S3I1eTFKYTZzVDBxMkIxbnphRk1iV2I5dnVPWCtB?= =?utf-8?B?eXNOcFFONUxQekttVS9ZVXNEMGM0a1kzeVZGU0Z5a2ZBcVRDZU5tdWVyU3hU?= =?utf-8?B?RkV3SlZrWlVFU1NCZlU1Uk9tempJMWEwdFQ3Um9rTFF3RTRZMU1JUSs5Ylkz?= =?utf-8?B?MGVSdTEwZEFWenQwRUphM3hKYUlRZVRQOVRJbnNBWXFtbTI5SFRpN3R3Qm5o?= =?utf-8?B?N1BNQXFoQTROVTV0eDFYNm5qVDZVa2Z0YnRaTG5FMm04VTU3THlDTjRhV3VY?= =?utf-8?B?MGFadDNJRzdsOERvSXFoSklNVUdWL2RGLzZxQ2lzM1p5dGNSbHpoMEZqamhz?= =?utf-8?B?NHF5dHF5eEcxWXkwenlMVVRrRXNYWU5Mc01vaHpuQlZyTkFsemVPTklZLzZI?= =?utf-8?B?QUI3b0tMNGNKMkVzem5HL2hqR093QTRYcHcyMlEyaWN0bHdpZ0d1cHliZTZQ?= =?utf-8?B?Tk12YnZDSWhuZGpiNm5MV29jYjJCR3NjcXJ6T1U2Q3M1ZEdCYys2cmlneXA3?= =?utf-8?B?N0dySTBnTktQbU9aNWo0TzZXTGhqNFFyeit0ZzNwZGVhNlFiWnBBN3RFY09E?= =?utf-8?B?dGliQlVOS1dnRzNDVW4ya01ua0JkMzZ5QWR2SldwelBLUHpTSWFENkJzTDVC?= =?utf-8?B?Y01NYVAyZEg0UXZoN0JLVGZBNWJwbllzSExHRnpkMXpET2JMa2FJOW1xakVR?= =?utf-8?B?eVg0UE80SWhNZTRENzZXSFREOXUrRHYzV0FEa2U1K0xleU9zRlpwR2ljL1BH?= =?utf-8?B?Tk9qaXhlMTYrbitpZnM2cWQxNGtrazdubFZvQ09scWRRdElydDdTWFNDbzA3?= =?utf-8?B?dkEwWjJNUU5NMG9xR2hwOUVzdDhCVkphc1JaTW1mV054Tytldm82a1MwU1hr?= =?utf-8?B?NmljMUs1RnlFL1R3eXBXbWJSM3pSdnE4NVRVL2oxVWJUZmZXbkt0SURYdzNZ?= =?utf-8?B?MzB5NHA5V2QzWlZzRmgrSHNLZ2RXVk9lekZUQUVrb2g3cEJuSi9GOFhkckxK?= =?utf-8?B?TjFzREc1Qnh4WXlxYW9VOENHbnc1SUlQZUlDdkkvbE80Q2ZHelZ2RVVua0tu?= =?utf-8?B?d2c3M2pPeXVJSk0rN0lrWDlrbFZ4WGlHakwzMmdwSFQ2RzBac1pkVVhJNjdl?= =?utf-8?B?YWRLTjU2cHdqMHZRdzAvT3FkOTZrYlFham5JYm1DSnhYYWluR09YUDNZSkh1?= =?utf-8?B?NUUvbEJ0WHpjbVlDZm02eXdRR3pDdVZDTVJYUzZERS9xaVBHUlUvTUJ1WEV5?= =?utf-8?B?Z1ZZMnp6NkF4cHFEOVJrbjc3U25JN0RaQndlT3pnWjNjTDBKMVJEQ3o1ZzNF?= =?utf-8?B?NW1wZDhlVTVuTU0vTzU5a2VuVlV5SHVUY3UvTXdoYytuSHoxUWhnTGF2N0JN?= =?utf-8?B?Qjg5bVRJTTBrWWZQaXRrRzVPemN3WjhsQ2d1RTRrQ2RNYmpKdkdwU2NFYlF6?= =?utf-8?B?U2pzOXB3bDhRaElnRXIzMUVqOGRJdlQxSDBKT3RYaEtobHJaQTFDVFJTeVJY?= =?utf-8?B?Zm8xaER6b0Z1TXdxbENZTzNGVEoweExTVldSOVZuMDNWQ3pRZnJrMXRtbU5n?= =?utf-8?B?aXNwVC9MQ1VrYXB1Q0pFOUxBZ2NTNjhqSDhpWVJyREhuaEpxTXZud0gyOVhn?= =?utf-8?B?QUFHOHZtSStGTmd3Vjc3S1FjT0FEVXY0K3hWcE13Z3R1SzJNYWdjZEMxem1O?= =?utf-8?B?UVRsTFB5N21KclBRVVVjdllhL1Q0VEJvU3NkaGxBaFRMNGtDVXFPN21iRnE0?= =?utf-8?B?SGxIL09teWdlWWR5MUl6MUt1dlV0OXIxSjVQYzc0NldDWXFZYkJYVVcyVjlo?= =?utf-8?B?UkJxSWtrYnRlSDFvT3ZzNDBhV2QrdjJSdlFjWUQ3SVVXZG1zM0QxN2N5SWY1?= =?utf-8?B?RjFwWEE3VVc5elZNcGpvU3NXdDk3ZTdlN0kxbU8rVysvNkxTczhPL2craGc4?= =?utf-8?Q?HqWjAkSnTP7b6rrl7tMYe99wv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c9c6c67-7975-4164-c3f1-08db0813e088 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 07:29:26.9548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 51X2LpuoOVz3Z34AdCgTZptnUSw9OE1YJT8B6b9lIttTUorNHdT2VmVPnsWUolw73r9HlMezUUyF8Gb8kGpwsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9242 On 22.07.2020 19:43, Elliott Mitchell wrote: > Unlike other unsupportted options, ACPI support is required to *boot* > for a number of platforms. Users on these platforms are unable to use > distribution builds and must rebuild from source to use Xen. > > Signed-off-by: Elliott Mitchell A general question first: How come this mail dates back to July 2020? I had almost missed it as "new". > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -29,13 +29,18 @@ menu "Architecture Features" > source "arch/Kconfig" > > config ACPI > - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED > + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" Personally I think the (UNSUPPORTED) in the prompt should then go away as well. Which in turn points out that we will want to reconsider whether we actually have UNSUPPORTED as a Kconfig control, as its purpose looks to be specifically cases like the one here. The question goes to Stefano in particular, who I think had introduced it back at the time. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 07:40:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 07:40:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490011.758612 (Exim 4.92) (envelope-from ) id 1pOw71-0006bk-Ei; Mon, 06 Feb 2023 07:40:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490011.758612; Mon, 06 Feb 2023 07:40:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOw71-0006bd-Bx; Mon, 06 Feb 2023 07:40:27 +0000 Received: by outflank-mailman (input) for mailman id 490011; Mon, 06 Feb 2023 07:40:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOw6z-0006bX-KV for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 07:40:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7e1a::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83a45109-a5f1-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 08:40:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8412.eurprd04.prod.outlook.com (2603:10a6:10:24d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 07:40:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 07:40:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83a45109-a5f1-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=euuEMO48AbsKKH5Dr0YKaIDMiPiYX4s36tT7suugr95coCWkqkA7oPdivwUkc1XKlqrSwwksPuUKHUdwe7vOi5wnLgJFEgg6JuhLtB+SK7p+E7bVKYnzkDTbhk6LigNZ+XXZnOI/sPlHiWlNPgGd9ZXEDfhW28k6NiQho03VCJlJZmkuBow4xD1wz0RKyMlWGanCpOa+SrwnIv64xi1SirRSR7RjXSiiwITv3beM6umC7fYfxEkfdfsPe1S43dh5Mw9BJREF+x7dCT72jhAys1pL3xuLpzmWEpTPuFvuMnTdOdkJBjeuu6q8Zq1blyZ5heFHXWtES6AmTWa+Dbxzgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LeptbsoB+9MhVxyyvgp9Jnu2s7hKqr9T6YbVcTedwk8=; b=iUvse3FgonoIiMg/KEOlKyAiA9A9hll0Gs5LORuOqBLbrsY0ewUQe70z8rDsrHY2TRh3mAc9LmgACaxUZYFrwvaBfHzW4jxRn0AsCxGMXFth9zy3OCfqb/f/AQoTcWFdAR/goDYkTqeqo/EdU0outeC4mSOjAzKazxCGYzC5uIvm49ZElB+Uew38WzQTevHYEy5Tf4FqHelmvL/pY8aOGT9vZ/jjCxYV0s5ilEEBcVbEg5SfIkIM7LciN2fH68hBr2QFOXfaVCkRZKCuaCtFQ1AcTwSwhtAg2aA3yGO/34xAxarYhW5Qfp/RTfwQk+Pnt3VCE70aqU2H2oHrPyVc7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LeptbsoB+9MhVxyyvgp9Jnu2s7hKqr9T6YbVcTedwk8=; b=PQ9MFCYmPox11ncc3RO5lVMqEXhdRAG9hQ5YD+JFkjSFBOYOQ6TiDLZXC+OIUgV3ELgJNvzT4hEqScwPCdx29YBtyvHeatCW+nV0dK3oHrGDTs7Kl9hD4xRyAe1hMGrd6APtyn20LMju/TwhFfxyR/Uir134pgyZdyIm4oS0VT2Q1IEdor64fgptY4gHiCBmpW91QruM98bCY6f9hniFBMw99LwKGujjhCU/abvasOxEI2GwIeA6G7kRSwE+bLd+TYlVMzfi79X5whKzP8k9S6COngw2eVRg9zTM3fTbMoYde3Ca+4lr96S2V79oIA6lI9jK0ZaY7D1ZcDkVgDe5Cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <509f24de-a34e-7702-4579-b27bcb86ce70@suse.com> Date: Mon, 6 Feb 2023 08:40:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Ping: [PATCH] tools/symbols: drop asm/types.h inclusion Content-Language: en-US From: Jan Beulich To: Bobby Eshleman , Alistair Francis Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Connor Davis , "xen-devel@lists.xenproject.org" References: <1eaa4cce-2ef2-ca38-56d2-5d551c9c1ae9@suse.com> In-Reply-To: <1eaa4cce-2ef2-ca38-56d2-5d551c9c1ae9@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8412:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e9746f5-e209-4ac8-cb83-08db081566c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U9J3xTkaaGeufhGUCHbHln5Aew7luYi4qvo3syTxqN0qOWFYEGjLznUaAFU9Y/Uuq6BCF6CNRR40TBQ4LawJBV4Y60IQtTqvgx7EV7lXFiFSVFWQIuLphAfQTHBcy5nr2DDUJLrpxC+h2aPS6FtZHJfWDvIMsNBfcTYVn4mQ00JUfueFxEMlnXAAfjONMAei4RVfL0wj06rQ0UXnVgQPs/tBeIurkoM9x2KsMotXZY0yZuHdnOKUo+EsJPivxNZJXm85jF8hvJItMbKjh9P+fJpJHllZiIwIyGz/FSVT+NBi4/ZT67wwOXFnBZtXEZeYQsSRO6XsE+gGX/6/B1gQaFINCYbKDypZ3lJujEJVbNrovIpmUXBO6Db5DlTZggA6GWBH5D/8LlNIn9a2p2MCTMl8NLKUoWKhc+j26NtYDVm2KOavHIvUHRAwekwq8aJuRLwY2pZykkcBttfOhhBQwvLZzv3I2ZTGY5cO66N9gL0OHX0kz/xQ1TlffI9opGCvpVyb+WR+9RUfYhewLfNZTJ/QvoDvZ2N4otSmo3G9qoC6nhgmL4SnVjMt2lISLvPgvXTV8JqnVg60YIj3YAIzE4PeSatQBeqwe6a1Sk4aKc0MBLZKvwg0OpIO41/memPFDMbbobfxYEmIUpHn4CesTwZRzXehWbV/AogTKcOymDX4Tm1Stu6WfhiXzmr/r9DFp0Uf+znvYK8hNmVDrxVtCXnyYuwPu3gopGKgDPo6aAs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199018)(316002)(110136005)(54906003)(26005)(31696002)(6512007)(186003)(86362001)(36756003)(31686004)(2906002)(66946007)(66556008)(66476007)(4326008)(7416002)(8936002)(8676002)(41300700001)(5660300002)(478600001)(2616005)(53546011)(6506007)(6486002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFRraUIrZHQ5QWhnR2NsNUoyNGxyZHd2TEhCSjI1Y3NFSWR3elc1a20rYUNH?= =?utf-8?B?YkpObFNGbGdZZFVMb09EWHlRYVVZRUlTTVUwVWJqem9wMUp5a0J6N3UyOW5r?= =?utf-8?B?aDQ5aDVOQXorVGVySEZKUHhNUlRlRHE3cGxaVFMyajBhZ2F4ckQyWkFxdjl2?= =?utf-8?B?VEtlN0R2VHpSbkdXWFVxdE43a3JLLzlxeDRlakVaa0IwaTg4bUxwYktLTktQ?= =?utf-8?B?S2RYZ2pqMWJoVG03NmVKS3kvbXZBVElxem1iK016NVlDN0gzMkNRU0g4YVZL?= =?utf-8?B?QUp1ZFA5UW51UzZYOHM0eUUySkh1WU9nRHVBUEtaZDlUVk9hMGp6alhVMmxi?= =?utf-8?B?VFhrYmwwQjNQODFxaFBpd0o0aCtrUWhOQUdIOTNOeU5WN2xUWXhTMmVEbjdt?= =?utf-8?B?ZXJ4N3Jrb1gwUUFkWUJibElYWUlpeTZFV3Z0T2UyeTlqQVRWdXo3ZHJSa1NM?= =?utf-8?B?bjlSMGUrNlExZ0JiQkJ1QjJGbnVtald0b1JMRU50ampUMGc4Z1EvamNBbFRy?= =?utf-8?B?Q0ZtZ01sK1pVRUp5dGlCUmpraGJtc3M4WUE4SlV2ZGFKY1oxbkFBeThIOTMr?= =?utf-8?B?RzRWWnZ3bVpNU3g3TnA2ZHYvdjhKYzJjVStQRkg4RGVyaVcyekFjeGl6clhh?= =?utf-8?B?VFVkUlBISGZoTUVkamwzZldPbys5QnhucTFjWkdqMDhYK0RkblEyYnVvSTRo?= =?utf-8?B?UXBZbGJiSzdNcVJzd3JFS2RtZ3dTRTJ0ZExxWTg0eUNOZVI1WEEvbTl2V3lM?= =?utf-8?B?Zk5nVHdjcW1hQWJaRGdOYWFQZFU3Ulk1R1pXTTk0akx0czBFbE1BUlhlY3Fl?= =?utf-8?B?U25iVmszVHBrSkEvNmV0UUVxNWZScEFpSlVnVmVieTFuS3pjWW54a1grS1lH?= =?utf-8?B?em9za1pmZElSQTkxb2R4U1hRZ09IWVVuY1FtN1htYWVUdWtvVUVzT1I0ZzVa?= =?utf-8?B?YUxwbVAyZXRwbUphempIZzUyREtWVXpaQWZ4N2tqTVBVZG5GTC9oM2RyZ0Vx?= =?utf-8?B?TUJSZG16SmdremRoQlNSU0g5azVhTWZhNXdZR21aUmtXblVEMjNydE9wK1NC?= =?utf-8?B?a0J0anJJWlVKMWtCdjNFWmhHZjAzaHNCd0dWNW0wL1lOWlVUamJwS3RLZlZ0?= =?utf-8?B?bmswMmQrVEFtYlA1NHNXTlRNV0JJZVkxb1BMOWg5UUlRUkMvMnNNR0tTUTVj?= =?utf-8?B?Ym5IZEtjNUNoT2ZyOEFKVC9TRXBrWFl2ZmMvRGc0R1pkbGl1RjBBSC9hZlZD?= =?utf-8?B?OVdSazZUOXFLYVpuUkFpMlpva1o1OXhtRkhNdlJLY0FLK2VWaFI2Rlk4OFFB?= =?utf-8?B?YlVQMXNiVkNnT2FLK3pVdERJdXBTYXNSQWJNV2UrbitJMHU4OHJqVU55VTd3?= =?utf-8?B?SGliS09Kd2hsTlc1dE5XeHppUzZMWGlXYVNyR1lpRmVCWkhTMWVhY0lMNUwx?= =?utf-8?B?UW9TNExHcG9kQjl1elEvRDBPMkQrZGZET0Vsb3FQNitqS2tzVFRkQkllYi96?= =?utf-8?B?VWhRRWdkWVNJK3ArTVRjdWtiSWxmRjdCdEpoZEo0Z0RzRkpqYTJ6VjMzaGRx?= =?utf-8?B?M1gvazVjU1BlcXprN2x0OWNwVXpVUkMxK1kvSDNOdlNBMmllbUpNeTVjZ0Yv?= =?utf-8?B?cE9JK25YaUJSM3ZqM2RKa3UyaVdIbXNTVE9YV255cDF6Qk1qVGpFNVdMczdE?= =?utf-8?B?TDMrckNDVHdXYXRtNXhQbGNzemRyclNaaGNQT0g3UnN5NFVLb2JQd3pCclNi?= =?utf-8?B?Q1puVE1TblhlaTJaQ00rN0FOTWhYNmVxNXJ3cXVsVW13RmNRWS9QQU9JL1hq?= =?utf-8?B?VXNJQmdYcEpnSnpHUDBCUkwySUdiT01KTTY4NHdaKy9KaVArQW5WNnhjRjJi?= =?utf-8?B?cE5EdjFwZXdUMmFjTHpGOHltdm40ZlZKZmlkMndvU1FNZXc4WGhuYjBNUFdG?= =?utf-8?B?Y2wyNTdJTzJsRi9saU1ZcE9UUTlodU9mQVJLTWs4M1hPSDM4bnYyTzNuWEhv?= =?utf-8?B?UDlZOGltdmFVam5IUzNIVHR2SWNmcTc0MWdVcjBFWDd6U2VMRlJjNmNRV2N1?= =?utf-8?B?enFCdmhqY0d2bnREQVJ6by9YYmZtbFBMbm5kUmtua3MxSGY3dTFxUlJGNjRh?= =?utf-8?Q?H9tjhFVnyNZUDR1EriBN06xzp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9746f5-e209-4ac8-cb83-08db081566c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 07:40:21.7105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lMDk1QyD4ijcdUb9P6Vu9WAphnt7AZtt1p5BvbU+3SCYMb5Q5ITXd67rb1PwBqdMvH0S42/IwpDpDzCRdflWWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8412 On 20.01.2023 09:40, Jan Beulich wrote: > While this has been there forever, it's not clear to me what it was > (thought to be) needed for. In fact, all three instances of the header > already exclude their entire bodies when __ASSEMBLY__ was defined. > Hence, with no other assembly files including this header, we can at the > same time get rid of those conditionals. > > Signed-off-by: Jan Beulich May I please ask for a RISC-V side ack (or otherwise) here? Thanks, Jan > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -1,9 +1,6 @@ > #ifndef __ARM_TYPES_H__ > #define __ARM_TYPES_H__ > > -#ifndef __ASSEMBLY__ > - > - > typedef __signed__ char __s8; > typedef unsigned char __u8; > > @@ -54,8 +51,6 @@ typedef u64 register_t; > #define PRIregister "016lx" > #endif > > -#endif /* __ASSEMBLY__ */ > - > #endif /* __ARM_TYPES_H__ */ > /* > * Local variables: > --- a/xen/arch/riscv/include/asm/types.h > +++ b/xen/arch/riscv/include/asm/types.h > @@ -1,8 +1,6 @@ > #ifndef __RISCV_TYPES_H__ > #define __RISCV_TYPES_H__ > > -#ifndef __ASSEMBLY__ > - > typedef __signed__ char __s8; > typedef unsigned char __u8; > > @@ -57,8 +55,6 @@ typedef u64 register_t; > > #endif > > -#endif /* __ASSEMBLY__ */ > - > #endif /* __RISCV_TYPES_H__ */ > /* > * Local variables: > --- a/xen/arch/x86/include/asm/types.h > +++ b/xen/arch/x86/include/asm/types.h > @@ -1,8 +1,6 @@ > #ifndef __X86_TYPES_H__ > #define __X86_TYPES_H__ > > -#ifndef __ASSEMBLY__ > - > typedef __signed__ char __s8; > typedef unsigned char __u8; > > @@ -32,6 +30,4 @@ typedef unsigned long paddr_t; > #define INVALID_PADDR (~0UL) > #define PRIpaddr "016lx" > > -#endif /* __ASSEMBLY__ */ > - > #endif /* __X86_TYPES_H__ */ > --- a/xen/tools/symbols.c > +++ b/xen/tools/symbols.c > @@ -302,7 +302,6 @@ static void write_src(void) > return; > } > printf("#include \n"); > - printf("#include \n"); > printf("#if BITS_PER_LONG == 64 && !defined(SYMBOLS_ORIGIN)\n"); > printf("#define PTR .quad\n"); > printf("#define ALGN .align 8\n"); > From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:02:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490088.758667 (Exim 4.92) (envelope-from ) id 1pOxNn-0001CI-OJ; Mon, 06 Feb 2023 09:01:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490088.758667; Mon, 06 Feb 2023 09:01:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxNn-0001CB-Kb; Mon, 06 Feb 2023 09:01:51 +0000 Received: by outflank-mailman (input) for mailman id 490088; Mon, 06 Feb 2023 09:01:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxNl-0001AF-E5 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:01:49 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0d5c33d-a5fc-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:01:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id E85752011C; Mon, 6 Feb 2023 10:01:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HoOi5yXqfWlB; Mon, 6 Feb 2023 10:01:43 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EA0862010B; Mon, 6 Feb 2023 10:01:42 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOxNb-008wtA-0r; Mon, 06 Feb 2023 10:01:39 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0d5c33d-a5fc-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 10:01:39 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230206090139.ehvf2czoocn6j7nc@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-5-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit: > +void *init_9pfront(unsigned int id, const char *mnt) > +{ [...] > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); Better check for errors, otherwise the rest will hang without useful feedback. > + for ( v = version; *v; v++ ) > + { > + if ( strtoul(v, &v, 10) == 1 ) > + { > + v = NULL; > + break; This looks fragile? if version is "2.1" it will accept it apparently? I guess better check whether strtoul did read a number, and in that case break the loop anyway, successfully if the number is 1 and with failure otherwise. > + } > + } > + free(version); > + if ( v ) > + { > + reason = "version 1 not supported"; > + goto err; > + } This looks odd: when number 1 is detected this breaks out successfully, while the error message otherwise says that it's version 1 which is not supported? Is the message supposed to be "version greater than 1 not supported"? > + err: > + if ( bepath[0] ) > + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); > + if ( msg ) > + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", > + id, msg); > + else > + printk("9pfsfront add %u failed, %s\n", id, reason); > + free_9pfront(dev); In case of early errors, this will try to free uninitialized evtchn, ring_ref, etc. > + free(msg); > + return NULL; > +} Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:22:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:22:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490128.758699 (Exim 4.92) (envelope-from ) id 1pOxhZ-0004s6-RZ; Mon, 06 Feb 2023 09:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490128.758699; Mon, 06 Feb 2023 09:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxhZ-0004rz-O2; Mon, 06 Feb 2023 09:22:17 +0000 Received: by outflank-mailman (input) for mailman id 490128; Mon, 06 Feb 2023 09:22:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxhY-0004pu-F8 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:22:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc1dfe44-a5ff-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:22:11 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F4463F282; Mon, 6 Feb 2023 09:22:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A22713677; Mon, 6 Feb 2023 09:22:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dsioFMPG4GNcNgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:22:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc1dfe44-a5ff-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xq9DAQJA5bLa0f2FnBAlUYRsTbrf3r86W3+9Gv9KH+Y=; b=GcgRheuijXKt5LJvz9UKO3aK4JuaTMyMnOm+r95o1mJCBaBPDEojs3tEOBYDACu7S9zYIl ecWSc9KhF1fWCzncQPI5Zp4a0aw9kcTZ17tO+hMPprVa+a2TEDXJB59TjW06y9+Qp82FKD OLXD1a/jNlRbYOos8uzmT4dl4NvmpUs= Message-ID: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Date: Mon, 6 Feb 2023 10:22:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> From: Juergen Gross Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend In-Reply-To: <20230206090139.ehvf2czoocn6j7nc@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------vx4qmPovfF4xTZ3bqa6wrOE5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------vx4qmPovfF4xTZ3bqa6wrOE5 Content-Type: multipart/mixed; boundary="------------ufXSVO0GXigeBQDpw4HOHnfQ"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> In-Reply-To: <20230206090139.ehvf2czoocn6j7nc@begin> --------------ufXSVO0GXigeBQDpw4HOHnfQ Content-Type: multipart/mixed; boundary="------------mvNQMwStrrqXLQfuQ1suzeyP" --------------mvNQMwStrrqXLQfuQ1suzeyP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTA6MDEsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNiArMDEwMCwgYSBlY3JpdDoN Cj4+ICt2b2lkICppbml0XzlwZnJvbnQodW5zaWduZWQgaW50IGlkLCBjb25zdCBjaGFyICpt bnQpDQo+PiArew0KPiBbLi4uXQ0KPj4gKyAgICBmcmVlKHhlbmJ1c193YXRjaF9wYXRoX3Rv a2VuKFhCVF9OSUwsIGJlcGF0aCwgYmVwYXRoLCAmZGV2LT5ldmVudHMpKTsNCj4gDQo+IEJl dHRlciBjaGVjayBmb3IgZXJyb3JzLCBvdGhlcndpc2UgdGhlIHJlc3Qgd2lsbCBoYW5nIHdp dGhvdXQgdXNlZnVsDQo+IGZlZWRiYWNrLg0KDQpUaGlzIGlzIGEgY29tbW9uIHBhdHRlcm4g aW4gTWluaS1PUyBmcm9udGVuZHMuDQoNCkkgY2FuIGFkZCBhbiBlcnJvciBjaGVjaywgb2Yg Y291cnNlLg0KDQo+IA0KPj4gKyAgICBmb3IgKCB2ID0gdmVyc2lvbjsgKnY7IHYrKyApDQo+ PiArICAgIHsNCj4+ICsgICAgICAgIGlmICggc3RydG91bCh2LCAmdiwgMTApID09IDEgKQ0K Pj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHYgPSBOVUxMOw0KPj4gKyAgICAgICAg ICAgIGJyZWFrOw0KPiANCj4gVGhpcyBsb29rcyBmcmFnaWxlPyBpZiB2ZXJzaW9uIGlzICIy LjEiIGl0IHdpbGwgYWNjZXB0IGl0IGFwcGFyZW50bHk/IEkNCj4gZ3Vlc3MgYmV0dGVyIGNo ZWNrIHdoZXRoZXIgc3RydG91bCBkaWQgcmVhZCBhIG51bWJlciwgYW5kIGluIHRoYXQgY2Fz ZQ0KPiBicmVhayB0aGUgbG9vcCBhbnl3YXksIHN1Y2Nlc3NmdWxseSBpZiB0aGUgbnVtYmVy IGlzIDEgYW5kIHdpdGggZmFpbHVyZQ0KPiBvdGhlcndpc2UuDQoNClZlcnNpb25zIGFyZSBk ZWZpbmVkIHRvIGJlIGludGVnZXJzLg0KDQpJIGNhbiBhZGQgY2hlY2tzIGZvciBzYW5pdGl6 aW5nIGJhY2tlbmQgd3JpdHRlbiBkYXRhLCBidXQgSSdtIG5vdCBzdXJlIHdlDQpuZWVkIHRo YXQuIEluIGNhc2UgdGhlIGJhY2tlbmQgd2FudHMgdG8gZm9vbCB1cywgaXQgY2FuIGVhc2ls eSB0ZWxsIHVzIHRvDQpzdXBwb3J0IHZlcnNpb24gMSBldmVuIGlmIGl0IGRvZXNuJ3QuDQoN Cj4gDQo+PiArICAgICAgICB9DQo+PiArICAgIH0NCj4+ICsgICAgZnJlZSh2ZXJzaW9uKTsN Cj4+ICsgICAgaWYgKCB2ICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgcmVhc29uID0gInZl cnNpb24gMSBub3Qgc3VwcG9ydGVkIjsNCj4+ICsgICAgICAgIGdvdG8gZXJyOw0KPj4gKyAg ICB9DQo+IA0KPiBUaGlzIGxvb2tzIG9kZDogd2hlbiBudW1iZXIgMSBpcyBkZXRlY3RlZCB0 aGlzIGJyZWFrcyBvdXQgc3VjY2Vzc2Z1bGx5LA0KPiB3aGlsZSB0aGUgZXJyb3IgbWVzc2Fn ZSBvdGhlcndpc2Ugc2F5cyB0aGF0IGl0J3MgdmVyc2lvbiAxIHdoaWNoIGlzIG5vdA0KPiBz dXBwb3J0ZWQ/IElzIHRoZSBtZXNzYWdlIHN1cHBvc2VkIHRvIGJlICJ2ZXJzaW9uIGdyZWF0 ZXIgdGhhbiAxIG5vdA0KPiBzdXBwb3J0ZWQiPw0KDQpJIGNhbiBjaGFuZ2UgdGhlIG1lc3Nh Z2UgdG8gIkJhY2tlbmQgZG9lc24ndCBzdXBwb3J0IHZlcnNpb24gMSIuDQoNCj4gDQo+PiAr IGVycjoNCj4+ICsgICAgaWYgKCBiZXBhdGhbMF0gKQ0KPj4gKyAgICAgICAgZnJlZSh4ZW5i dXNfdW53YXRjaF9wYXRoX3Rva2VuKFhCVF9OSUwsIGJlcGF0aCwgYmVwYXRoKSk7DQo+PiAr ICAgIGlmICggbXNnICkNCj4+ICsgICAgICAgIHByaW50aygiOXBmc2Zyb250IGFkZCAldSBm YWlsZWQsIGVycm9yICVzIGFjY2Vzc2luZyBYZW5zdG9yZVxuIiwNCj4+ICsgICAgICAgICAg ICAgICBpZCwgbXNnKTsNCj4+ICsgICAgZWxzZQ0KPj4gKyAgICAgICAgcHJpbnRrKCI5cGZz ZnJvbnQgYWRkICV1IGZhaWxlZCwgJXNcbiIsIGlkLCByZWFzb24pOw0KPj4gKyAgICBmcmVl XzlwZnJvbnQoZGV2KTsNCj4gDQo+IEluIGNhc2Ugb2YgZWFybHkgZXJyb3JzLCB0aGlzIHdp bGwgdHJ5IHRvIGZyZWUgdW5pbml0aWFsaXplZCBldnRjaG4sDQo+IHJpbmdfcmVmLCBldGMu DQoNCk9oIHJpZ2h0LCBJIG5lZWQgdG8gY2hlY2sgdGhvc2UgZm9yIGJlaW5nIG5vdCAwLg0K DQoNCkp1ZXJnZW4NCg== --------------mvNQMwStrrqXLQfuQ1suzeyP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------mvNQMwStrrqXLQfuQ1suzeyP-- --------------ufXSVO0GXigeBQDpw4HOHnfQ-- --------------vx4qmPovfF4xTZ3bqa6wrOE5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgxsIFAwAAAAAACgkQsN6d1ii/Ey9o NggAnkHMVcRn8nmL2Sn6reRQ+Y/QBblOgM7AMasT+FM1uKkklT6aV4fr0MI1lqj4q4i0uERyhASW 0FZXJ2WLSy/Jg2kSO88Ofb3+NkL+oasI2PBVjwqZJfBgOP9yXu44IiVezCe9WsxGeRd4B6t/IL2W GH+De1P21wgaeUy33rwhHLr6nv0wbYBexn/7GviDly5wyFPvH9iPqKQ4GcrWMZGOHF5OL/jN2U8o C0xPyKa2lD07SiloC+ECo7HHdm5qE0xdAUBSmwQxIr2JAB7gXspGOejIZptlCAi5EnzIousZmZXt L3bWsCGq/Y116NBHCE+Kdhx3IPTPNQ9HY5f+PMYhow== =5Wcp -----END PGP SIGNATURE----- --------------vx4qmPovfF4xTZ3bqa6wrOE5-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:24:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490137.758713 (Exim 4.92) (envelope-from ) id 1pOxjG-0005Wb-8T; Mon, 06 Feb 2023 09:24:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490137.758713; Mon, 06 Feb 2023 09:24:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxjG-0005WU-5Q; Mon, 06 Feb 2023 09:24:02 +0000 Received: by outflank-mailman (input) for mailman id 490137; Mon, 06 Feb 2023 09:24:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxjE-0005UA-G2 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:24:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fab14662-a5ff-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:23:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A4FDC3F290; Mon, 6 Feb 2023 09:23:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D14713677; Mon, 6 Feb 2023 09:23:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q9stHSzH4GNwOAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:23:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fab14662-a5ff-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LQXVc2EqJoXYjYOUh6r9cWLuCgbAbKl+BcBrC9LF9hA=; b=Hrbvogd19KA3WLtkkVFmxCZ/W7OlssyvXrsEDIFUPoI/WSjjltK2jzbEuLmwlrmKxKDMO4 I6oyODWogV3r86p/6yP5RREanL57fMY/pdQZlrYhrt/5FbGT4OjBjv4pYdbIf71UZgoBBN DvscIA2peR7PSmnEi5WhDseEyz2Yjf4= Message-ID: <75603739-a013-1da8-a30a-e0e549c5fcd6@suse.com> Date: Mon, 6 Feb 2023 10:23:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> <20230204140148.pmhv2vnsb7ejobji@begin> From: Juergen Gross In-Reply-To: <20230204140148.pmhv2vnsb7ejobji@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WzMtLIAV9yaN7ruULp3feNIM" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WzMtLIAV9yaN7ruULp3feNIM Content-Type: multipart/mixed; boundary="------------0y4kSmhFGC6gfg7MtiRe0Iwo"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <75603739-a013-1da8-a30a-e0e549c5fcd6@suse.com> Subject: Re: [PATCH 1/7] Mini-OS: xenbus: add support for reading node from directory References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-2-jgross@suse.com> <20230204140148.pmhv2vnsb7ejobji@begin> In-Reply-To: <20230204140148.pmhv2vnsb7ejobji@begin> --------------0y4kSmhFGC6gfg7MtiRe0Iwo Content-Type: multipart/mixed; boundary="------------GPQvSeXqb39WSySrtk6ebLJ7" --------------GPQvSeXqb39WSySrtk6ebLJ7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDIuMjMgMTU6MDEsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSGVsbG8sDQo+ IA0KPiBKdWVyZ2VuIEdyb3NzLCBsZSB2ZW4uIDAzIGbDqXZyLiAyMDIzIDEwOjE4OjAzICsw MTAwLCBhIGVjcml0Og0KPj4gK2NoYXIgKnhlbmJ1c19yZWFkX3Vuc2lnbmVkKHhlbmJ1c190 cmFuc2FjdGlvbl90IHhidCwgY29uc3QgY2hhciAqZGlyLA0KPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IGNoYXIgKm5vZGUsIHVuc2lnbmVkIGludCAqdmFsdWUpDQo+ PiArew0KPj4gKyAgICBjaGFyIHBhdGhbQlVGRkVSX1NJWkVdOw0KPj4gKyAgICBjaGFyICpt c2c7DQo+PiArICAgIGNoYXIgKnN0cjsNCj4+ICsNCj4+ICsgICAgeGVuYnVzX2J1aWxkX3Bh dGgoZGlyLCBub2RlLCBwYXRoKTsNCj4+ICsgICAgbXNnID0geGVuYnVzX3JlYWQoeGJ0LCBw YXRoLCAmc3RyKTsNCj4+ICsgICAgaWYgKCBtc2cgKQ0KPj4gKyAgICAgICAgcmV0dXJuIG1z ZzsNCj4+ICsNCj4+ICsgICAgc3NjYW5mKHN0ciwgIiV1IiwgdmFsdWUpOw0KPiANCj4gSSdk IHNheSBiZXR0ZXIgY2hlY2sgdGhhdCBzc2NhbmYgcmV0dXJuZWQgMSBhbmQgb3RoZXJ3aXNl IHJldHVybiBhbg0KPiBlcnJvci4gT3RoZXJ3aXNlICp2YWx1ZSBtYXkgZW5kIHVwIHVuaW5p dGlhbGl6ZWQuDQoNCk9rYXkuDQoNCg0KSnVlcmdlbg0KDQo= --------------GPQvSeXqb39WSySrtk6ebLJ7 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------GPQvSeXqb39WSySrtk6ebLJ7-- --------------0y4kSmhFGC6gfg7MtiRe0Iwo-- --------------WzMtLIAV9yaN7ruULp3feNIM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgxywFAwAAAAAACgkQsN6d1ii/Ey+g Twf/dDI8C+ha68MR6vyp6KvSH1hUT6k8f7xCYZgxPnPO36WzD28rB0Aa/SWWZKLsqWrIUoWweiT8 PudisnbyALNuqhbMF7cY0Z1QIcjYvu40od6bk+AX/bHb+EU4KSmZfpYOxtjuKbUYU5GWQK4jCQEj GQ2dbcAf9RN9azYZuYwhxXALMj7+WMRTjRK5yjjFW26q3B9yXTGbKJuj0aTrXPp4ZzhyvtKh0mAh Xh6qx1IykBXugFVs6m2TCnB3P8Z/9LibNvn5NCM0GZv8BiajuGecY9NNpHKy0dYXM4CZXLpDWJX5 Cf9nP3kItzRtzxJ7DlhX3Dx6zEDTkM/bqLfbJ/ijCA== =yYpx -----END PGP SIGNATURE----- --------------WzMtLIAV9yaN7ruULp3feNIM-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:25:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:25:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490145.758729 (Exim 4.92) (envelope-from ) id 1pOxkl-0006Dz-Kv; Mon, 06 Feb 2023 09:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490145.758729; Mon, 06 Feb 2023 09:25:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxkl-0006Dq-Hy; Mon, 06 Feb 2023 09:25:35 +0000 Received: by outflank-mailman (input) for mailman id 490145; Mon, 06 Feb 2023 09:25:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxkj-000682-TT for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:25:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32594bdd-a600-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 10:25:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0ECDD3F291; Mon, 6 Feb 2023 09:25:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD83813677; Mon, 6 Feb 2023 09:25:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /xLKNInH4GMROgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 09:25:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32594bdd-a600-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675675530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xaUPPW+RojxjSgBFSPhxWmG2HPgYboyEyG3uqWZ5qVQ=; b=UBgZUsxfife+Rzq8PKoaFYN/gWWf1qh9/MYmEeEIQv0pXJm4UA1uEP+rYNbLFTZ6ymDWuV gG98p4a8tko5jOF6GwBwvFU+toboxBFeN1s/VKojBueZpuuISxWxZtFOHCSgV7k3dqLehb xSEGVMFJosYsDITFnCFrL81vB61ATAo= Message-ID: <16b989f6-333b-10a8-c985-bfc132342f49@suse.com> Date: Mon, 6 Feb 2023 10:25:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> <20230205124509.pr5xswn4ygqsqoba@begin> From: Juergen Gross In-Reply-To: <20230205124509.pr5xswn4ygqsqoba@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------03mOFBryRpUb8qINwbY1kud5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------03mOFBryRpUb8qINwbY1kud5 Content-Type: multipart/mixed; boundary="------------0o2qI4Dwe9qyRtfYEJ0oaCnP"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <16b989f6-333b-10a8-c985-bfc132342f49@suse.com> Subject: Re: [PATCH 2/7] Mini-OS: add concept of mount points References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-3-jgross@suse.com> <20230205124509.pr5xswn4ygqsqoba@begin> In-Reply-To: <20230205124509.pr5xswn4ygqsqoba@begin> --------------0o2qI4Dwe9qyRtfYEJ0oaCnP Content-Type: multipart/mixed; boundary="------------T2Tp6q2lXqPcEcjlt5KXoU94" --------------T2Tp6q2lXqPcEcjlt5KXoU94 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDIuMjMgMTM6NDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNCArMDEwMCwgYSBlY3JpdDoN Cj4+ICtpbnQgb3Blbihjb25zdCBjaGFyICpwYXRobmFtZSwgaW50IGZsYWdzLCAuLi4pDQo+ PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgbSwgbWxlbjsNCj4+ICsgICAgc3RydWN0IG1v dW50X3BvaW50ICptbnQ7DQo+PiArICAgIG1vZGVfdCBtb2RlID0gMDsNCj4+ICsgICAgdmFf bGlzdCBhcDsNCj4+ICsNCj4+ICsgICAgaWYgKCBmbGFncyAmIE9fQ1JFQVQgKQ0KPj4gKyAg ICB7DQo+PiArICAgICAgICB2YV9zdGFydChhcCwgZmxhZ3MpOw0KPj4gKyAgICAgICAgbW9k ZSA9IHZhX2FyZyhhcCwgbW9kZV90KTsNCj4+ICsgICAgICAgIHZhX2VuZChhcCk7DQo+PiAg ICAgICB9DQo+PiAtICAgIGlmICghc3RybmNtcChwYXRobmFtZSwgIi9kZXYvbWVtIiwgc3Ry bGVuKCIvZGV2L21lbSIpKSkgew0KPj4gLSAgICAgICAgZmQgPSBhbGxvY19mZChGVFlQRV9N RU0pOw0KPj4gLSAgICAgICAgcHJpbnRrKCJvcGVuKC9kZXYvbWVtKSAtPiAlZFxuIiwgZmQp Ow0KPj4gLSAgICAgICAgcmV0dXJuIGZkOw0KPj4gKw0KPj4gKyAgICBmb3IgKCBtID0gMDsg bSA8IEFSUkFZX1NJWkUobW91bnRfcG9pbnRzKTsgbSsrICkNCj4+ICsgICAgew0KPj4gKyAg ICAgICAgbW50ID0gbW91bnRfcG9pbnRzICsgbTsNCj4+ICsgICAgICAgIG1sZW4gPSBzdHJs ZW4obW50LT5wYXRoKTsNCj4+ICsgICAgICAgIGlmICggIXN0cm5jbXAocGF0aG5hbWUsIG1u dC0+cGF0aCwgbWxlbikgJiYNCj4+ICsgICAgICAgICAgICAgKHBhdGhuYW1lW21sZW5dID09 ICcvJyB8fCBwYXRobmFtZVttbGVuXSA9PSAwKSApDQo+PiArICAgICAgICAgICAgcmV0dXJu IG1udC0+b3BlbihtbnQsIHBhdGhuYW1lLCBmbGFncywgbW9kZSk7DQo+IA0KPiBUaGlua2lu ZyBhYm91dCBpdCBtb3JlOiBkb24ndCB3ZSB3YW50IHRvIHBhc3MgcGF0aG5hbWUrbWxlbj8N Cj4gDQo+IFNvIHRoYXQgdGhlIG9wZW4gZnVuY3Rpb24gZG9lc24ndCBoYXZlIHRvIGNhcmUg d2hlcmUgaXQncyBtb3VudGVkLg0KDQpJIHRoaW5rIGJvdGggdmFyaWFudHMgaGF2ZSB0aGVp ciBwcm9zIGFuZCBjb25zLg0KDQpBcyB0aGUgb3BlbiBmdW5jdGlvbnMgaGF2ZSB0aGUgbW91 bnQgcG9pbnQgYXZhaWxhYmxlIHZpYSB0aGUgbW50IHBhcmFtZXRlcg0KSSBjYW4gY2hhbmdl IGl0Lg0KDQoNCkp1ZXJnZW4NCg0K --------------T2Tp6q2lXqPcEcjlt5KXoU94 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------T2Tp6q2lXqPcEcjlt5KXoU94-- --------------0o2qI4Dwe9qyRtfYEJ0oaCnP-- --------------03mOFBryRpUb8qINwbY1kud5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPgx4kFAwAAAAAACgkQsN6d1ii/Ey+z SAf/WXa7lfvar4BViWtPFOQyN7ue9FGd6zGjc/YEkZ0bx2nI1A2xpU3ZGrkLdY6Plj7q+bqig5FF md2EOQ8vF7xC5DXH4Md/Y6ABs/4nrlOyshfLmKUT9hv4x+8JHLIF13Ux3tkD6xG/xyb2JwjOOW61 aG5RDZF3yBf/1sOJfkBsWyk6QTADgv8huFotRs2MVpzNGINqjlc7hPfEvAVrk4MUFyErvxbiSye7 X/3Meh9a4MW23+EiBjquJ60Xk90Xldvq3sC4iPjukskO11TQ9u9rfzq9oOB0+eVNVtszobsrY4Lw sArR4ArFNsf3leHBlSC05SjsZ33o9CfIMdSL0d/LCA== =Z174 -----END PGP SIGNATURE----- --------------03mOFBryRpUb8qINwbY1kud5-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:40:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:40:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490154.758739 (Exim 4.92) (envelope-from ) id 1pOxzO-0000Mj-1Z; Mon, 06 Feb 2023 09:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490154.758739; Mon, 06 Feb 2023 09:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxzN-0000Mc-V7; Mon, 06 Feb 2023 09:40:41 +0000 Received: by outflank-mailman (input) for mailman id 490154; Mon, 06 Feb 2023 09:40:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOxzM-0000MP-MO for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:40:40 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4de7cc13-a602-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 10:40:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 546FE20127; Mon, 6 Feb 2023 10:40:34 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y1HQiThQCbPM; Mon, 6 Feb 2023 10:40:34 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EDDB62010A; Mon, 6 Feb 2023 10:40:33 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOxzE-0091TM-3B; Mon, 06 Feb 2023 10:40:32 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4de7cc13-a602-11ed-933c-83870f6b2ba8 Date: Mon, 6 Feb 2023 10:40:32 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer Message-ID: <20230206094032.se33a5z3kzfauywg@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-6-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:07 +0100, a ecrit: > +/* > + * Using an opportunistic approach for receiving data: in case multiple > + * requests are outstanding (which is very unlikely), we nevertheless need > + * to consume all data available until we reach the desired request. > + * For requests other than the one we are waiting for, we link the complete > + * data to the request via an intermediate buffer. For our own request we can > + * omit that buffer and directly fill the caller provided variables. > + */ This documents the "why" which is very welcome, but does not document what the function does exactly (AIUI, copy from buf1+buf2 into target up to len bytes, and update buf/len accordingly). > +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, > + unsigned int *len1, unsigned int *len2, > + void *target, unsigned int len) > +{ > + if ( len <= *len1 ) > + { > + memcpy(target, *buf1, len); > + *buf1 += len; > + *len1 -= len; > + } > + else > + { > + memcpy(target, *buf1, *len1); > + target = (char *)target + *len1; > + len -= *len1; > + *buf1 = *buf2; > + *len1 = *len2; > + *buf2 = NULL; > + *len2 = 0; > + if ( len > *len1 ) > + len = *len1; But then this is a short copy, don't we need to error out, or at least log something? Normally the other end is not supposed to push data incrementaly, but better at least catch such misprogramming. > + memcpy(target, *buf1, *len1); > + } > +} > + > +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > + struct p9_header *hdr, const char *fmt, va_list ap) Please document what this helper function does (at the very least which way the copy happens). The hdr != NULL vs == NULL notably needs to be explained. > + case 'Q': > + qval = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, qval, 13); I'd say make this 13 a macro. > +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + > + down(&dev->ring_in_sem); > + > + while ( !rcv_9p_one(dev, req, fmt, ap) ); > + > + rmb(); /* Read all data before updating ring index. */ > + dev->intf->in_cons = dev->cons_pvt_in; Shouldn't there be an event notification after updating the consumption index? > + up(&dev->ring_in_sem); > + > + va_end(ap); > +} Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:48:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490163.758755 (Exim 4.92) (envelope-from ) id 1pOy6w-0001Bd-Pc; Mon, 06 Feb 2023 09:48:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490163.758755; Mon, 06 Feb 2023 09:48:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy6w-0001BW-Mz; Mon, 06 Feb 2023 09:48:30 +0000 Received: by outflank-mailman (input) for mailman id 490163; Mon, 06 Feb 2023 09:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy6v-0001BL-R7 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:48:29 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 686e1ae3-a603-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 10:48:28 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3112220137; Mon, 6 Feb 2023 10:48:28 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 37gCvjbV6Dqt; Mon, 6 Feb 2023 10:48:28 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 03F7D20135; Mon, 6 Feb 2023 10:48:27 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOy6t-0092S6-0v; Mon, 06 Feb 2023 10:48:27 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 686e1ae3-a603-11ed-933c-83870f6b2ba8 Date: Mon, 6 Feb 2023 10:48:27 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230206094827.rayr5tqstjnco3nf@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-5-jgross@suse.com> <20230206090139.ehvf2czoocn6j7nc@begin> <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <383cbd1b-6518-bc1d-a3ae-5562e3dec5c1@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 06 févr. 2023 10:22:10 +0100, a ecrit: > On 06.02.23 10:01, Samuel Thibault wrote: > > Juergen Gross, le ven. 03 févr. 2023 10:18:06 +0100, a ecrit: > > > +void *init_9pfront(unsigned int id, const char *mnt) > > > +{ > > [...] > > > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); > > > > Better check for errors, otherwise the rest will hang without useful > > feedback. > > This is a common pattern in Mini-OS frontends. Ah, indeed. Ok, then. > > > + for ( v = version; *v; v++ ) > > > + { > > > + if ( strtoul(v, &v, 10) == 1 ) > > > + { > > > + v = NULL; > > > + break; > > > > This looks fragile? if version is "2.1" it will accept it apparently? I > > guess better check whether strtoul did read a number, and in that case > > break the loop anyway, successfully if the number is 1 and with failure > > otherwise. > > Versions are defined to be integers. Ah, it's a list of versions? (I don't know the protocol at all). > I can add checks for sanitizing backend written data, but I'm not sure we > need that. In case the backend wants to fool us, it can easily tell us to > support version 1 even if it doesn't. Not necessarily fooling, but misprogramming :) > > > + } > > > + } > > > + free(version); > > > + if ( v ) > > > + { > > > + reason = "version 1 not supported"; > > > + goto err; > > > + } > > > > This looks odd: when number 1 is detected this breaks out successfully, > > while the error message otherwise says that it's version 1 which is not > > supported? Is the message supposed to be "version greater than 1 not > > supported"? > > I can change the message to "Backend doesn't support version 1". Aah, yes indeed, that was the part I missed for understanding it all :) Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:48:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490169.758770 (Exim 4.92) (envelope-from ) id 1pOy7M-0001ik-3o; Mon, 06 Feb 2023 09:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490169.758770; Mon, 06 Feb 2023 09:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy7M-0001id-1B; Mon, 06 Feb 2023 09:48:56 +0000 Received: by outflank-mailman (input) for mailman id 490169; Mon, 06 Feb 2023 09:48:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy7K-0001iC-Bb; Mon, 06 Feb 2023 09:48:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy7K-0003OM-90; Mon, 06 Feb 2023 09:48:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy7J-0006xm-Qc; Mon, 06 Feb 2023 09:48:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pOy7J-00076D-Q8; Mon, 06 Feb 2023 09:48:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=op1tJHQux/9uIDNPxTiROvfNnaTHxjWDo32IODHN2H8=; b=48uOV3gP4nlLDtUUubBkvVs5Pz HQB8o+XCDr3Np8QMT/MBDAHImc1yNaDQ4L/gy9D0AbZPEHqgEubHUJh+P6RN8Lxmja55WlnrNYWLG s12xcR/7Ya/JJ5eo0Tcl3w4SvAJmQRZ2MNFadIwxY3uVDeg9LXL0klwaTWKMwoabYcW4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176414: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=39ee93d21290293712ffb7f7c265df7dcb45b12f X-Osstest-Versions-That: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e From: osstest service owner Date: Mon, 06 Feb 2023 09:48:53 +0000 flight 176414 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176414/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 39ee93d21290293712ffb7f7c265df7dcb45b12f baseline version: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e Last test of basis 176339 2023-02-02 21:02:06 Z 3 days Testing same since 176414 2023-02-06 08:00:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Juergen Gross Krister Johansen Marek Marczykowski-Górecki Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a21c9e6ddf..39ee93d212 39ee93d21290293712ffb7f7c265df7dcb45b12f -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 06 09:49:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 09:49:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490180.758781 (Exim 4.92) (envelope-from ) id 1pOy8B-0002Id-Fo; Mon, 06 Feb 2023 09:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490180.758781; Mon, 06 Feb 2023 09:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy8B-0002IW-BR; Mon, 06 Feb 2023 09:49:47 +0000 Received: by outflank-mailman (input) for mailman id 490180; Mon, 06 Feb 2023 09:49:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOy89-0002IO-QX for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 09:49:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7d00::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 957c02ef-a603-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 10:49:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6779.eurprd04.prod.outlook.com (2603:10a6:10:11b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 09:49:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 09:49:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 957c02ef-a603-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dLpyYVvj/quzuka2ciQCTFFL893Gk13yFvJj7Jbdx2jXJN0SOU7FJ8KeONT3Lpk00FMf5XgdmVf1WalSyjPGG29w1jwtHI3JZPMbYNts38aZqInrr06xeoCtzaAECn+UAXxNc1bHPeyENvxPk/4xczKZIBscz4Fnsv1x2i0HKOKvUo9DexYxKZvvmS2diN93vgQsD8+CNYZRxXCSpZni0N/ZO3n2dHvO7iwdu+YCULdhS0hw9wElXDL7aq80r5CrgJXMrb3U21dhhJCni5mdXYJmo0LGdhsLqH9dy0q8RtOjtzKYX3OyC8Dd1soEJ/jaZ5kEk83S0w29umqDxldBAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dnTAYdCtkA3aodozt11bLjhjyRpTm3dTL7CwpGAeDU=; b=YAOCkIYmpXJPqxXGJU/U0NiaDRNrlcBH717/Ywvyh0kJc0axO1eXw/lbGsH7H/3QDuSi9NMyRjGIsm3Du+M4ADLG92cYZ52cSSpy4AmW72/DVXbnA/4HQflSYlwEKUHLfy+zWAWJxQKSIRyfgg7d1rnK2NkjI0/i2Q1rPSan3wiTto3t/hMgs4fZDpsApXOlYHlgGW6FE772HRvY9TgL6mxKdJvccfWRfUDSLLMyqk/aDaeh/uQ+Xx8dBw4AhcAxWu0dPmM9LhHNjYq+lxK/G9w4RE6hqe1oQdE3I86bsJtSOsVPhCotx3dyu9TTgHaxS1DMSM9JkJXA/srtPwjVow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4dnTAYdCtkA3aodozt11bLjhjyRpTm3dTL7CwpGAeDU=; b=g2DebtgSUYjliXyZeASZIgXfBV9h80FzxtwO66HaPnsq28mm74MMEHqrLLrOFHkAtVpawhEWF362u1l+Be2C8TtGglkvxK435oJaOguBdDq86DblLWMeRe50Ueu7VKGJb7t0+3mZf/1oARcxwl0ZaJhGjNXTx41W5qXCFslSWo5ArHYTCJe5ukPxhRuVfFDSLJL5f0wOfYZ6LA5si+hvKvqotUUWmV7nj+J7HayxGY/JzGGwWUxwSEMOBmQuND2pAUf4s1eht/ksDGnh9EGpPwHD8S/oB9Gq9jnNcKJG7Ma/0VKaqiFIWX/80tIlPItygty6CwbRBXVIGnsoYoy4og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <53371bbc-ea78-4c2b-a84e-e888ae090d3a@suse.com> Date: Mon, 6 Feb 2023 10:49:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal: List files in Xen originated from external sources Content-Language: en-US To: Stefano Stabellini , Luca Fancellu Cc: Xen-devel , Andrew Cooper , George Dunlap , Julien Grall References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6779:EE_ X-MS-Office365-Filtering-Correlation-Id: 6303daf7-b24c-43f1-3806-08db0827784d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dmy8OwV516fCjvX2d4wjg4ZIiN+MfrcK28vU9djd6ecoVI92MMNOyBvRixTyWgPiFV8YeelOdV5iWGuRNksw0FqjJRf3suxtmZ+aGkIwZSE415unVu56/D2BVab/pi4L1YCuCLViS7eB2M4JqEfvZ6zRPAQrMy7r72gKon3Kb7R6TAcoVC/LgnH8U4/IFV/+qTLTj8Nj+apX+4l2dC5dONwfEiW3Koxg5a8GGLtI6xruIIav0ig/1S1Pagj25nR4EpjGvBKFwCeGhirNanpYJJewOjFa5/r8D8mb8hknvmh+rYvWOC2YjsFJtOH0LhN6l29FqG9VgnutU//43YtKflgFIqWVmpRt6P64QFKiFDAmifvDV7h9lzYtBGGmsBqp6yr5cvuqir0h2t1RVTQvfHN8gn+nvnrOy4gcE6E4hsrpU1QSJtpKxz4ZxayB5sFD6DFh2LBvSZ9Ejavsp4IL+irw/zjeYz2qS1lSK0bxQ4ndFRfj3+LnU7Jj9gs1Vu5+mQKsCPErTc+2TUx15NopnexcSSJaUGlzJYjDmfXngdhtvzvCwTG09bXDPsBh/ngaI6dOidg41KA6IGEwY1CIzyGbOkxG459gJ3mKMmTsvugrG9pG+oWB0OFn9GM0VSowtPNwmq72IAH6Rgvj0FogwLsGgml/Y0Jg69OzfDipisbF9ym8UP4Iut87WdTQeWoVLHXcJ+cQtUrubHJCbwwkdcscJRMDHN3UMv95sSNhS3o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199018)(316002)(66476007)(54906003)(110136005)(66556008)(2906002)(38100700002)(36756003)(5660300002)(4744005)(31696002)(86362001)(8676002)(4326008)(41300700001)(8936002)(6486002)(2616005)(6512007)(478600001)(66946007)(26005)(186003)(6666004)(6506007)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTdwVjZBeTJJZC8yRENSTTRkTncybVp4ZmJSS2xvMFBKOXhINWNOVTRsOVBZ?= =?utf-8?B?NTBFVDg4eTd4dk11ZEdETVBHa1lFWDgzaDZ3TXRsOVROcE9ka0h2S2g2NjA1?= =?utf-8?B?SnIxRVpxK3BHb09nNEFkd2Fhd1kzbllnRzV1VTd5c3paZGFSdnlEaFJXcnAy?= =?utf-8?B?YjBvMldqMllVc3NqNWVldG5hT3BrekkyRGs4cndrS0t3WEpVdmp5UVBuUlhw?= =?utf-8?B?dHhlWU5IMHVKcFkyK2x2QjdJVDZUWnBSeCtwZzRyRjFPZUxRUUVCMXluSEN6?= =?utf-8?B?TnBBZ1RkKy82Z2VxZE5Qc1BwQjMramRiUENTZlYzN0dWaDlXZ2lNS1ZxRktz?= =?utf-8?B?KzJrOHhOWDFRbWdPUFN0S2lqNlBlVmUxajAybHRHMDYyck9xWVI3VDdXL0Na?= =?utf-8?B?U2R6L2VsdnZjMFpLdmtXRXFpVXdqeDQ4ZjI4NlhmVGZRYy83a3JxZlFYZ295?= =?utf-8?B?M3BuS0dnVVhVU2JqRHdQT3JqOEpsa05sWjVSMW5aQ2FZbmF4YVpwbmFwb0ho?= =?utf-8?B?NWppaUJ1TVhJZ0hBUjJNYVFxcyt6NHBGcHVjODY3NHNHWVIvZDFVZU45eEc5?= =?utf-8?B?QkpKSkhCSzM5N2dnQjQ2Um5IMTZ1Sk11QmVyVk1vQkxzZkxQRnVkOFRCN1Jn?= =?utf-8?B?NU84Q3VpdmptMUZmOVkxK00xb2hPOW9FeGdySHh2MHNZSzZKblBaWVFGUms5?= =?utf-8?B?Z0tLR09YYWl3UlJzUWFyMVlEL0N6Y0NTMTJIU2oyU2l0ckIycjVCRUh2VlB4?= =?utf-8?B?RitrNlVBUWVLOUMyWm1TbnIyZDVxTmhkN3BXVG1WWVppd0xPRHQ2bCtrU0J1?= =?utf-8?B?ZUhnZllLR0VleGh5UVNoQ083MnhwNXduWXZNdW4waWxDNGJjZE5PUjA4Z3k3?= =?utf-8?B?ZjhVWUdKakhFdXZKZ0xRNFI0Y3JlQkJ6dGpnT1FNbGpLdU1OMXJBNjI2RDRM?= =?utf-8?B?dzN2QzFPOVZTMGtndjRSenpET2xBeGlpRHhVVDhhb09vUU5OekIyTlB4UGNs?= =?utf-8?B?bnhsMDNHTHFYeGJDOE9kdWlXc0d4alYxSGZ1MHA5QUw3K1QvOW5jTGpxVXBo?= =?utf-8?B?WnZyOThId0N1NUk5U3dkRnRLdUVUanZIVkpFZTd5cEJ1cDRIM2ZWMDZHNHFN?= =?utf-8?B?M0JkWFJGN3N6NExqVUZQOU9FZnEwTWtqMnk1RW4rc0c4M2hNbHR0MlVnYzJI?= =?utf-8?B?ZVQ4N05pYkVtVzVRY0VrdmFYemYzOTZrZnFSRFhEeG1GMC80Z05odEtEbmtE?= =?utf-8?B?WlhIL2I3dVFJa2pUSFpGME04eHhTQkJreHVHK1M3d1pHS3B6d3pINitkakZ6?= =?utf-8?B?Y01tbW9UVWxELzRWbGg4S1hMRExNb2JscjU1TG15WjhhbWdJWm9uT2dTTjEw?= =?utf-8?B?WkFhQmZ5VnBtNlZOOW9icjBTTFB2VWxoMzdid3JPUnZrbFMzOUhsd1Z6bVhS?= =?utf-8?B?aXhFQlFWVktlRFJGZnR0MVZnSUY0THdxUGR5U3VuZGRxZ1RwcUx4UDUxZ2lR?= =?utf-8?B?WjBaL0x3Q2x3OXdqc2R0aEt1dEYvd3pCM09GOXEvWVE0cGdGSXdwMXNaNklG?= =?utf-8?B?c3Z4T0dManpuMzArZUluaEROVmRqejFBaGFvOGN6VVQ0OGVFVHZaVEc5OFVa?= =?utf-8?B?cmhwaG9pREZLc3g1VDVZOU5yWWNSb3loRTVNc0R2RDFXN0NUZTBzd0xGam1L?= =?utf-8?B?djJwS2xMV2lHUlFtZ1hYTGsvek1wM0hZSDFwd2hDNWhRZGhFeVMyQnB1bzF1?= =?utf-8?B?RmRoUzV0WTVtWkVkYzNWSWsvMXdXSjA5TjZYWk90RXphNFZEUTJaMGd0OVdv?= =?utf-8?B?S0IwcEhDRmp3Q0syNDAwRlpMNjl3eEdnTnlLMkJBT1R0UFgwK0ZzeHZDSEhZ?= =?utf-8?B?WUxmaEc3OFRtTWc2cXpZaUIraGFNMGlkRS91aGFKSmZ5MGdNZTN1eWFiMzJM?= =?utf-8?B?eThnTlRQRG9ZTkl2NHFSWU1qcjlLVDVUdXAzejNQd3NGTjh2SFUyMDJWd09r?= =?utf-8?B?aGtQRG0xUEorMnFUNlVSTDRUUjd6RHVZZzB3SU1iL3FWUDI5VHVhUWZuRkFx?= =?utf-8?B?SXF6Y2R1cExDQWxzbW8zeXBJL2wzeU5Wd1dvZTRVVEVYTnpEWmFqQmh2bi8x?= =?utf-8?Q?dniTZkZUJakxdk0NXXyRXQFKz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6303daf7-b24c-43f1-3806-08db0827784d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 09:49:41.9849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7RIfm/Y/+r0K8amiaC/a4CN2/gfi8sDn8/SuhYEU3ncJdFD3c0ytMfSnM0jffK4T8/YeQXSPDXdZmntrP/mUgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6779 On 03.02.2023 20:55, Stefano Stabellini wrote: > On Fri, 3 Feb 2023, Luca Fancellu wrote: >> And then, if the file is not subject to backport and now we “own” the file, there is no more the need to list it >> in the external file, a commit search can reveal when it was converted to Xen codestyle and removed from >> the external file list so we don’t lose the history. > > Yes, I agree. If a file is coverted to Xen coding style and follows > MISRA rules, then there is no need to list the file in > docs/misra/external-files.json. > > >> So we would end up excluding just all the file listed in external-file.json by the analysis. > > Right, I think so too Personally I think this is too focused on Misra. There are other uses of such data, like automatically identifying changes to the origin file(s) which we ought to be pulling in (recall that we've been doing a pretty bad job in this regard). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:02:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490188.758792 (Exim 4.92) (envelope-from ) id 1pOyK9-0004pL-IK; Mon, 06 Feb 2023 10:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490188.758792; Mon, 06 Feb 2023 10:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyK9-0004pE-ES; Mon, 06 Feb 2023 10:02:09 +0000 Received: by outflank-mailman (input) for mailman id 490188; Mon, 06 Feb 2023 10:02:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyK8-0004p8-87 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:02:08 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20619.outbound.protection.outlook.com [2a01:111:f400:fe13::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f526a44-a605-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:02:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9123.eurprd04.prod.outlook.com (2603:10a6:102:22e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29; Mon, 6 Feb 2023 10:02:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 10:02:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f526a44-a605-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWXydX5qC8IiUYQgpInE6B9RdwltrROh3QocR2N6H1PNO13QCQzOxDORQOPkdE5MqN8+bwuhLAfRewo9o37rzfiUeg6y7v7QjbW4wgePnMFwpE1RzV203Mx2KT8NMzk1M1hYP3Uigt2uED+mnF3SwyBdWAd8xtQ1MC/Gjn9513RoH6T0GGCj7tN8yjLxBqKtsaaijzh2n+eHAr34mKFuNvYyWg2H0LoLWRmEQyjt48UUeewDq39Rw7GjwVxPD8GCufeEMkSKaFud/NJwC/na9sRBR27SE6kuTdHdX2Kr9ofU6xFkKB+f8zvCshcNMecwKmpttDDemKkBchXGLnoj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KLnhGpjDMzRxpoB7RHvVZNt0fte+ucOpHhwACIQ1O1s=; b=knMyQXwMX3bBOBF4C1maa+sEXJUic3XixIZzo/R2tBKU5tBFsgvJz16WzTnuaPOf+QiJqAEaDyR/djFVLEkCWnuMkoTbCbg3FX1wWOV6FsMKsNeNvZs0r9SoCT5dWZ/ts7xHiFxQu8ABNkgYk2QpKzY63MdwMgUqp8Y7w2RGH2pgqwNw2ZjFbdUKHpJe2k28q4/Q0d8H/GkRsh8FB3rgO9+a1sgYw1lcOZMk6e2oH4s0Qu11PpwJaDTT6vT5seZg7gvHRyE4hRR58VGIopeFbhWUsjQAr/3Mkqjqbm1Id8TZznrv5gqNZ4rFH9lcdqpvWxlRIWLkxDGgsK2tZBpBcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KLnhGpjDMzRxpoB7RHvVZNt0fte+ucOpHhwACIQ1O1s=; b=xZSaetmVsPFF4vUQX+v/lxtV5/mxswACzeH78VGWmCvmHYTegiVJpE46EU0ewqO6q5s7Vr/5yiq1FjDbw1usQeZZouiF+lGGI/iQ4rW2KcDh7NXgV6xG1IcaDFD6gPZo6FdsngorNE8zVnjKrgpVhoNnbBfzrg1EEL89IvmVlAgSFDPWc/jVywVEl783enT006G0HfoIv3Tub0shUDJhs1eLA+mXIwTl45jc9+ZoXaKT3HnpaO71NcAKTZ3dX6r2Qbu0dr4BNWFVsrr5p+LKI8OfGoNL/aboGTOhgait57Juhkx2bD4J2z1ea7FOTEiFCIEUN05Bk2erRHZBE0kgTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <005b7fa3-0f64-b15d-38d5-8135b0da06d2@suse.com> Date: Mon, 6 Feb 2023 11:01:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal: List files in Xen originated from external sources Content-Language: en-US To: Luca Fancellu Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Julien Grall , Xen-devel References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9123:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d606a22-d7ad-4040-b3d7-08db08293084 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: efRxEgD7s7k2/2fs24p03iJ4/Y+/kPnirwGJKp5qqxOdQ0C9eUrS4bF9/Kb7+FRG0xNhlU1tmrN4iLhIRPtpEZwi5rFh6a3o1fSjEyU9CgQwOTfmR019PROOJ8P6mS5En16m2m0hmtmG7KFxDq4jMy5kE4bJow0mwKoqNXxHIdRsjDK02e3PLVufy80jWXacOuEje6h3vyPCg8BE3TmPnRGEDVK6H/LSVnDd0etcIXxPa5jdfPM/BrOhMeWMGCXe0ieb2sgSOUV416oaseu2oQ0JTqkoSvJMOmRHCkHlIOGQYTG7+oAU1ym5ZaBKzeo7UpBJHIfj35Tlkl6z95A+zMA+4AiubhQQEdyhKVOERbqShz8DOIYAPSQ4ciWnh+izj9gADbhwbiB6QrWQlw7BlC7G58uOAvQ/fXM6iHiNG4m+jqkSp4tcpuhJh4gqAlYNPoaFLwk5NU8Wlb5gDbG6naOVp5Lzz+QgOVctFsNb4d2Gu/ZFXJ9awJaud8SGRg+na53NujoQfGM2Ecw+fHb40E/OC2wTZcZePehlrAbjJHGjpii4uJXCzvVBg/CyTx5BSbceMd+eWHPe1dGbGR8NNZGhUqUrf9Ir3BnBiZhnlCh4IvmjGe+MocBlUk6sRvP/dBkTUGaOGKEsn9LHBvxA6nI+eb2HQDwPvQn20pTZrz8wWmKmlUKPpTRxbglBj7noOUwOLKzNQ7aF/NebBpMhWpxLtGukCW4FZ73RuaLC+hzlFpM0iDJ2dl58YU34p1UqW7V1uyOk+ACOXkGymzkz2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(136003)(346002)(396003)(366004)(451199018)(31686004)(38100700002)(36756003)(478600001)(86362001)(31696002)(966005)(6506007)(186003)(6512007)(26005)(83380400001)(2616005)(53546011)(54906003)(66946007)(2906002)(316002)(66556008)(66476007)(6486002)(4326008)(5660300002)(8936002)(41300700001)(6916009)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekVvYUJ3ZU9xRW5XdnMyeHVKQndWTWxzYk9RMTl1aTNoU2QwbkJ0Wlo3bWdx?= =?utf-8?B?S1FQQ3l5NllZbUhCVW5jNjdWMmtyODVwWUMrdkNUMERnVUVpZmRHMkIrVTlr?= =?utf-8?B?NlZjcTVYSzBlbDdRU2hkNFErN3VUZ2k3dSthRS9OeWpEWXduWEJFbTBWcjR6?= =?utf-8?B?MDBURmI5aHVETGdBV2tVVDV1eitsVzdCWkxyL29QL3RMY2pRWnA3WEwvUU9i?= =?utf-8?B?WTE1VFBOS3krODRJbmpZYUhxVitzTnF5aVdWYWxoUWhwc0tVVlMxNWdSR0hM?= =?utf-8?B?U05GdnViYWNCWlp6cTNaUklJcCtyeElZVmwxQU1PcUdmMVpMTHNnSUlYakkv?= =?utf-8?B?Z3lXZkhzUWw4SmVoQnpZSXBabkNnSkRQSlBYMWV2d25TeG81elc3OVpPbXZh?= =?utf-8?B?ZDltOXdFRWE2UThIOWJqOVBBUGFET2ptMzBYKzVsWjhwYXN5L1pnQStWNFNQ?= =?utf-8?B?bFdIanVuYlhrTHhnREw0bS9OWTVEVDZnZnZUVWYvYjgrM1d1ZGRHMUVIY0dr?= =?utf-8?B?QzhEaHoxaWlvSlNJTlVxWkgyWGRYeW5ybS8wRDZDQUtxemg0dnFyRTV4cXNH?= =?utf-8?B?T3B3dE9SaEdTVk1lWE90aVF5eTJHa3dsNlBQU2E4ZVVxNDRLWnhvajJldWx1?= =?utf-8?B?SGt5TklzUE9pc29Da3M4UkJhSmFzQ2cybXZWNDhYR00yaEdGQSttYm95ZjVN?= =?utf-8?B?V3NxRmhpTHJpeXc4Y3ZaWkk0U1B5THYwOWNLbjNVZ2xaZDJ1UCs4ZEVXV0J3?= =?utf-8?B?UWdNeDh2dEZLcmppdldWRC9yUHZTblJIL2poZklOSldlVmVOQ2NTQ0ZwdGRi?= =?utf-8?B?SS9rUVJMRmVicW1uS1ppYVd4cDdnTmJtVmtYaFhtN1BRWjcyd2Qvd3ViY1pJ?= =?utf-8?B?YzVjYzFzdE41ZTYxWFo4Y0VsQmQzdzZIRERxVTM0V3hBdTVhRFZMckdheXVw?= =?utf-8?B?dEtWTWZZamlvRjU0dmp6eVJ5ZTkwbUNmcjYxWTJnVDluRmlhNWVPN3lkNkt4?= =?utf-8?B?WC9Nbk5UM1NYbVJsWjA4UjhqTDhwRFlFb0I4d2k3STVib1hERHBPV2t6Nk10?= =?utf-8?B?ZU94SkpxK0NjTFhxakV0UDc4QWgvVHJOR2ZtRW1mdlBnTkZGajE0UVJGK053?= =?utf-8?B?dEVkNGdHa3hrZUFaZCtZWEN1UWFYTzU4eEpoWGUwa1dhazFiUWdXYzlkK1N0?= =?utf-8?B?N2svQVFUczU2VmlJL1o0aW9MUTlXaW94TnllVVVzTklkUDlqR0tqSk1BQjNo?= =?utf-8?B?YmlhdXJwTUpFdGEzcTFGeEhvN0k3VnIxMHdhSGdONDhpUzI0N3NOUnJjeTVB?= =?utf-8?B?NDd2VkQ3djUwUXZKa2dSaVBpM3hILzFybkdJTUxRQkhrcE9VZ0p3MTBCOE0z?= =?utf-8?B?cHdQNFp6OW4wMkswdWRyU0hBU3hnZVBmRlVCaWpMeVFpdXhyQjNySlhNekta?= =?utf-8?B?Nno4a0VTU2lmYkJBTHJMQ2hpRHBGejFjZ2I4WWQrejhFSi9Db3BtdWUxaWN3?= =?utf-8?B?eTlLbitvZXd0YUdhOC93aE1iZE1MQ3A5dGdaM1MyV1B6TW9kSlVtQmw0ZXJi?= =?utf-8?B?ZzlaTzc3ZEdBUWFFWXJ5ZWpkUTZRbk5hQm5XZi9kcGs3djAwRzJvVW12eGt0?= =?utf-8?B?cTBoMjk3dDNrUkR1TnZmYWtCcUdDaHFrc1JxWlRTZjROZHg3Wm9aMnErVnpW?= =?utf-8?B?Um9icnY5eTY3aTU5VVdiQlM1NE8vTmhyNHFaeVArcXFQM1BqSHFzTFNpekk1?= =?utf-8?B?YitoWm5zbUhUNHVValBzSkFtWVRsVDJwSld6ZXcybFFoUyttcDUrNDlxeCtt?= =?utf-8?B?RjRHbUpORy85Y0YyL3VqOXdueWpBVWNrVUViUVp1bERGMHNpQWZIdG43U1Yx?= =?utf-8?B?bExPVDlWcWhMRlFtNzlMQy9MdHpJWWZ6TSsveWFOekp6UVVxSUtKckNISXhz?= =?utf-8?B?cXJKK0tycGlNK2xNdlJVdVVBL2lrQW5xczJOWXhaSE0zMHhkKzZIdXFIWlNO?= =?utf-8?B?UmRFQnNmbThJenRzTE93RTRnZEVOd3V5V0VQUVpnNUx4bEZ5dE53cVJ2d2NO?= =?utf-8?B?eXBDSVAvNTdKZG12Qnd0d09abzU1YzdrUExWWllMRnptRkRkRW90VERsNXpu?= =?utf-8?Q?jyNjMTZOSo2/hUOpGf7nrCj7G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d606a22-d7ad-4040-b3d7-08db08293084 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:02:00.5304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B81Hw0SwxIPJzhgd8zPaz1G6Mcj30f5YKvxQTXzG8ZoHeV3ncjrWVf0Yy04ZoLhtYIrdM04mkl9hO4+RRvtktg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9123 On 03.02.2023 10:30, Luca Fancellu wrote: > I’m starting a proposal for the external files that needs to be removed from the MISRA scan, > the work was originally started by Michal here: > https://patchwork.kernel.org/project/xen-devel/patch/20221116092032.4423-1-michal.orzel@amd.com/ > so I started by that thread, the aim of this work is to have an initial format to start as soon as possible to > exclude the external files from the MISRA scan (at least initially from cppcheck). > > I think we can use the JSON format because it’s easy to integrate it with python and it’s easy to add/remove > fields from the structure without interfering with the other elements during time, so we can define a structure > now but if in the future we see the needs for additional field, we can just add them without changes to the > analysis script. > > In my opinion many of these fields can be left empty in a first push, to let the script exclude the files and during > time with the contributions of the community we can add the missing informations. I'm having trouble making a connection between a file having an entry here and the need/desire to include it in scanning. Can you clarify please why you see an implication from one to the other here? > I think it’s easier for the community to pick an entry, do some research to fill the gaps and push, instead to wait > until having all the informations before adding the entry. Maybe it's easier, but it's then also less useful. For example I view it as quite relevant what the origin of a file is. That may, for example, have an implication on whether "backport" is sensible to set to "true" (origin projects could, after all, be largely unmaintained, and hence it may be difficult to get any changes into there). > This is my first though for the fields, let me know yours: > > docs/misra/external-files.json: > { > "version": "1.0”, > "content": [ > { > "path": "relative/path/from/xen/“, > "backport": True/False, > "origin_project": "URL to origin project", > "origin_path": "relative path in the original project", > "origin_revision": "revision in original project” > } > ] > } > > > Maybe, documentation for this file and the fields can reside in docs/misra/external-files.rst. Couldn't documentation of the fields live at the top of the file itself? > Here follows the explanation for the fields: > > path: is a relative path from the xen base folder, it can refer to a file or it can be a path to an entire folder > (Taking as example libfdt) > > backport: it’s a boolean flag that says if the file is subject to backport, so every file where this field is true > won’t be included in the analysis. A file is subject to backport when it’s external and it doesn’t > accept direct changes (changes needs to be made in the original project and then backported > to Xen) > > origin_project: url of the repository where this file was originated Personally I'd drop "url of" - the specification of the origin needs to be precise, but I'm not convinced it absolutely needs to come in the form of a URL. What would imo be more important to mandate is that the reference be to the "canonical" copy of the project, not e.g. some github clone. > origin_path: relative path in the original project, mostly linked to the original_revision field > > origin_revision: revision of the changes in the repository when this file was taken. I guess this needs clarifying: What revision is meant here? The one originally imported, the one last updated from, or yet something else? Keep in mind that we may also be selectively importing changes, in which case any particular "revision" can easily end up misleading. The format likely also wants specifying, e.g. (like we do for Fixes: tags) the first 12 digits of a commit hash. For said selective updating this might then allow for something like ++... Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:05:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:05:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490198.758807 (Exim 4.92) (envelope-from ) id 1pOyNk-0005bb-72; Mon, 06 Feb 2023 10:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490198.758807; Mon, 06 Feb 2023 10:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyNk-0005bU-3x; Mon, 06 Feb 2023 10:05:52 +0000 Received: by outflank-mailman (input) for mailman id 490198; Mon, 06 Feb 2023 10:05:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyNi-0005ZR-SV for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:05:50 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d32acfb1-a605-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:05:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 65B9220127; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SwxpFAkPtfR4; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 334B42010E; Mon, 6 Feb 2023 11:05:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyNd-0094RX-0W; Mon, 06 Feb 2023 11:05:45 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d32acfb1-a605-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:05:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230206100545.xice46pygaoh53bf@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:08 +0100, a ecrit: > +static unsigned int get_fid(struct dev_9pfs *dev) > +{ > + unsigned int fid; > + > + fid = ffs(dev->fid_mask); > + if ( fid ) > + dev->fid_mask &= 1ULL << (fid - 1); Isn't that missing a ~ ? > @@ -459,6 +522,134 @@ static int p9_attach(struct dev_9pfs *dev) > return ret; > } > > +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return ENOENT; Rather EAGAIN? (and similar in other functions) (actually p9_version and p9_attach could be updated too, even if in their case it's not supposed to happen. > + req->cmd = P9_CMD_CLUNK; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, ""); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > +static unsigned int split_path(const char *pathname, char **split_ptr) > +{ > + unsigned int parts = 1; > + char *p; > + > + *split_ptr = strdup(pathname); > + > + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) > + { > + *p = 0; > + parts++; > + } > + > + return parts; > +} Do we need to care about an empty part if we're passed "/foo//bar"? > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > mode_t mode) > { > - errno = ENOSYS; > + int fd; > + char *path = NULL; > + char *p; > + struct file *file; > + struct file_9pfs *f9pfs; > + uint16_t nwalk; > + uint8_t omode; > + int ret; > + > + f9pfs = calloc(1, sizeof(*f9pfs)); > + f9pfs->dev = mnt->dev; > + f9pfs->fid = P9_ROOT_FID; > + > + fd = alloc_fd(ftype_9pfs); > + file = get_file_from_fd(fd); > + file->filedata = f9pfs; > + > + switch ( flags & O_ACCMODE ) > + { > + case O_RDONLY: > + omode = P9_OREAD; > + break; > + case O_WRONLY: > + omode = P9_OWRITE; > + break; > + case O_RDWR: > + omode = P9_ORDWR; > + break; > + default: > + ret = EINVAL; > + goto err; > + } [...] > + err: > + free(path); > + close(fd); > + errno = ret; This seems missing free(f9pfs)? Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:11:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490208.758818 (Exim 4.92) (envelope-from ) id 1pOyT3-00074m-S1; Mon, 06 Feb 2023 10:11:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490208.758818; Mon, 06 Feb 2023 10:11:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyT3-00074f-O7; Mon, 06 Feb 2023 10:11:21 +0000 Received: by outflank-mailman (input) for mailman id 490208; Mon, 06 Feb 2023 10:11:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyT2-00074Z-UW for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:11:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyT2-0003vO-It; Mon, 06 Feb 2023 10:11:20 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.13.231]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOyT2-0002MT-Ba; Mon, 06 Feb 2023 10:11:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XcdtCHvblRqW+q27NKI+2nh+NrT0ybHr4fxs+otMHxY=; b=H9eKpCKS8g2xrNPmcxg4YctJbA ob/7VOC29oEhvThOROINUjhYA+GnQwIPlIesVlkOV8q9LAOov2HX6YTOHmIUGNIwdG8vXIXIcy7QM Oi+vlIIRf2T+QjDRKif7O59aSRb5VN5OWFaFu1b1LdyekpjWbtpmPTTkvxroXN/88CDo=; Message-ID: <78a79c41-e026-b8aa-cfbf-0482f7f5c171@xen.org> Date: Mon, 6 Feb 2023 10:11:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-21-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-21-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, A few more remarks. On 13/01/2023 05:28, Penny Zheng wrote: > In MPU system, device tree binary can be packed with Xen > image through CONFIG_DTB_FILE, or provided by bootloader through x0. > > In MPU system, each section in xen.lds.S is PAGE_SIZE aligned. > So in order to not overlap with the previous BSS section, dtb section > should be made page-aligned too. > We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make it happen. > > In this commit, we map early FDT with a transient MPU memory region at > rear with REGION_HYPERVISOR_BOOT. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 5 +++ > xen/arch/arm/mm_mpu.c | 63 +++++++++++++++++++++++++--- > xen/arch/arm/xen.lds.S | 5 ++- > 3 files changed, 67 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index fcde6ad0db..b85e420a90 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -45,18 +45,22 @@ > * [3:4] Execute Never > * [5:6] Access Permission > * [7] Region Present > + * [8] Boot-only Region > */ > #define _REGION_AI_BIT 0 > #define _REGION_XN_BIT 3 > #define _REGION_AP_BIT 5 > #define _REGION_PRESENT_BIT 7 > +#define _REGION_BOOTONLY_BIT 8 > #define _REGION_XN (2U << _REGION_XN_BIT) > #define _REGION_RO (2U << _REGION_AP_BIT) > #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) > +#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) > #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) > #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) > #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) > #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) > +#define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) & 0x1U) > > /* > * _REGION_NORMAL is convenience define. It is not meant to be used > @@ -68,6 +72,7 @@ > #define REGION_HYPERVISOR_RO (_REGION_NORMAL|_REGION_XN|_REGION_RO) > > #define REGION_HYPERVISOR REGION_HYPERVISOR_RW > +#define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) > > #define INVALID_REGION (~0UL) > > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 08720a7c19..b34dbf4515 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -20,11 +20,16 @@ > */ > > #include > +#include > #include > #include > +#include > +#include > #include > #include > +#include > #include > +#include > > #ifdef NDEBUG > static inline void > @@ -62,6 +67,8 @@ uint64_t __ro_after_init max_xen_mpumap; > > static DEFINE_SPINLOCK(xen_mpumap_lock); > > +static paddr_t dtb_paddr; > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -403,7 +410,16 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > > /* During boot time, the default index is next_fixed_region_idx. */ > if ( system_state <= SYS_STATE_active ) > - idx = next_fixed_region_idx; > + { > + /* > + * If it is a boot-only region (i.e. region for early FDT), > + * it shall be added from the tail for late init re-organizing > + */ > + if ( REGION_BOOTONLY_MASK(flags) ) > + idx = next_transient_region_idx; > + else > + idx = next_fixed_region_idx; > + } > > xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, REGION_AI_MASK(flags)); > /* Set permission */ > @@ -465,14 +481,51 @@ int map_pages_to_xen(unsigned long virt, > mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); > } > > -/* TODO: Implementation on the first usage */ > -void dump_hyp_walk(vaddr_t addr) > +void * __init early_fdt_map(paddr_t fdt_paddr) > { > + void *fdt_virt; > + uint32_t size; > + > + /* > + * Check whether the physical FDT address is set and meets the minimum > + * alignment requirement. Since we are relying on MIN_FDT_ALIGN to be at > + * least 8 bytes so that we always access the magic and size fields > + * of the FDT header after mapping the first chunk, double check if > + * that is indeed the case. > + */ > + BUILD_BUG_ON(MIN_FDT_ALIGN < 8); > + if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) > + return NULL; > + > + dtb_paddr = fdt_paddr; > + /* > + * In MPU system, device tree binary can be packed with Xen image > + * through CONFIG_DTB_FILE, or provided by bootloader through x0. The behavior you describe is not specific to the MPU system. I also don't quite understand how describing the method to pass the DT actually matters here. > + * Map FDT with a transient MPU memory region of MAX_FDT_SIZE. > + * After that, we can do some magic check. > + */ > + if ( map_pages_to_xen(round_pgdown(fdt_paddr), I haven't looked at the rest of the series. But from here, it seems a bit strange to use map_pages_to_xen() because the virt and the phys should be the same. Do you plan to share some code where map_pages_to_xen() will be used? > + maddr_to_mfn(round_pgdown(fdt_paddr)), > + round_pgup(MAX_FDT_SIZE) >> PAGE_SHIFT, This will not work properly is the Device-Tree is MAX_FDT_SIZE (could already be page-aligned) but the start address is not page-aligned. But I think trying to map the maximum size from the start could potentially result to some issue. Below the excerpt from the Image documentation: "The device tree blob (dtb) must be placed on an 8-byte boundary and must not exceed 2 megabytes in size. Since the dtb will be mapped cacheable using blocks of up to 2 megabytes in size, it must not be placed within any 2M region which must be mapped with any specific attributes." So it would be better to map the first 2MB. Check the size and then re-map with an extra 2MB if needed. > + REGION_HYPERVISOR_BOOT) ) > + panic("Unable to map the device-tree.\n"); > + > + /* VA == PA */ I have seen in a few places where you add a similar comment. But I am not sure to understand how this help to describe the implementation of maddr_to_virt(). > + fdt_virt = maddr_to_virt(fdt_paddr); > + > + if ( fdt_magic(fdt_virt) != FDT_MAGIC ) > + return NULL; > + > + size = fdt_totalsize(fdt_virt); > + if ( size > MAX_FDT_SIZE ) > + return NULL; > + > + return fdt_virt; > } > > -void * __init early_fdt_map(paddr_t fdt_paddr) > +/* TODO: Implementation on the first usage */ > +void dump_hyp_walk(vaddr_t addr) > { > - return NULL; > } > > void __init remove_early_mappings(void) > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index 79965a3c17..0565e22a1f 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -218,7 +218,10 @@ SECTIONS > _end = . ; > > /* Section for the device tree blob (if any). */ > - .dtb : { *(.dtb) } :text > + .dtb : { > + . = ALIGN(PAGE_SIZE); > + *(.dtb) > + } :text > > DWARF2_DEBUG_SECTIONS > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:14:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490214.758829 (Exim 4.92) (envelope-from ) id 1pOyVR-0007eX-7f; Mon, 06 Feb 2023 10:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490214.758829; Mon, 06 Feb 2023 10:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVR-0007eQ-4s; Mon, 06 Feb 2023 10:13:49 +0000 Received: by outflank-mailman (input) for mailman id 490214; Mon, 06 Feb 2023 10:13:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVP-0007eF-Ew for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:13:47 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efd3c771-a606-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:13:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 2567720127; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lz8KYkgw86im; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 0B8452010E; Mon, 6 Feb 2023 11:13:43 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyVJ-0095QC-0K; Mon, 06 Feb 2023 11:13:41 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efd3c771-a606-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:13:41 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230206101341.5l7cxb2vvregskrx@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit: > This patch is missing the limitation of read/write messages to stay > below the max. supported message size. It should at least be asserted. > +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint32_t count; > + > + if ( !req ) > + { > + errno = EIO; Here as well (and in p9_write) we'd want EAGAIN rather than EIO which can be mistaken with the error case below. > + return -1; > + } > + > + req->cmd = P9_CMD_READ; > + send_9p(dev, req, "ULU", fid, offset, len); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + } > + else > + ret = count; > + > + put_free_req(dev, req); > + > + return ret; > +} Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:14:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490220.758847 (Exim 4.92) (envelope-from ) id 1pOyVm-0008Ab-Je; Mon, 06 Feb 2023 10:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490220.758847; Mon, 06 Feb 2023 10:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVm-0008AU-Gf; Mon, 06 Feb 2023 10:14:10 +0000 Received: by outflank-mailman (input) for mailman id 490220; Mon, 06 Feb 2023 10:14:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyVk-0007eF-Sd for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:14:08 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc4aa96e-a606-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:14:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 0094120127; Mon, 6 Feb 2023 11:14:05 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cdpVfKjQhtbw; Mon, 6 Feb 2023 11:14:04 +0100 (CET) Received: from begin (unknown [89.207.171.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id CCF2D2010E; Mon, 6 Feb 2023 11:14:04 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pOyVc-0095Qn-25; Mon, 06 Feb 2023 11:14:00 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc4aa96e-a606-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 11:14:00 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 0/7] Mini-OS: ad minimal 9pfs support Message-ID: <20230206101400.arrer4sdzvxlnsuv@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230203091809.14478-1-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Hello, Juergen Gross, le ven. 03 févr. 2023 10:18:02 +0100, a ecrit: > This series is adding minimal support to use 9pfs in Mini-OS. It is > adding a PV 9pfs frontend and the ability to open, close, read and > write files. Nice, thanks! :) Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:15:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490234.758859 (Exim 4.92) (envelope-from ) id 1pOyWk-0000Qm-0S; Mon, 06 Feb 2023 10:15:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490234.758859; Mon, 06 Feb 2023 10:15:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyWj-0000Qf-S4; Mon, 06 Feb 2023 10:15:09 +0000 Received: by outflank-mailman (input) for mailman id 490234; Mon, 06 Feb 2023 10:15:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyWi-0007eF-FH for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:15:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ffd585c-a607-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:15:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C4B3760593; Mon, 6 Feb 2023 10:15:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9FE57138E8; Mon, 6 Feb 2023 10:15:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6RqtJSjT4GPhBwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:15:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ffd585c-a607-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675678504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=24gc4b4kCjRbILk7EM18yr6i0qc8TwuEJDtNvQq1DTI=; b=WqLogXlgn7rBLXX+UWzkByzhDaH848BkHiyK0JaBs0ynVmisYXzik2VE1SZ7n6UW8lRM1g LyGshCRc6mxg9RIyCqxWsfEwfXfSl3c9MoG0N+6HEcxdojxhdrNqpQwV76CRRJ4o0031mK AaJMKo/n0LKSjaoymOJSUAiMMwnzrCA= Message-ID: <466e1389-4691-f444-4792-4f5a4a3c7847@suse.com> Date: Mon, 6 Feb 2023 11:15:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> <20230206100545.xice46pygaoh53bf@begin> From: Juergen Gross Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend In-Reply-To: <20230206100545.xice46pygaoh53bf@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8ZbwYTaDRyDJ8fqLn06001jE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8ZbwYTaDRyDJ8fqLn06001jE Content-Type: multipart/mixed; boundary="------------n06Dc1QYBkwAe02blN1wVy2I"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <466e1389-4691-f444-4792-4f5a4a3c7847@suse.com> Subject: Re: [PATCH 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-7-jgross@suse.com> <20230206100545.xice46pygaoh53bf@begin> In-Reply-To: <20230206100545.xice46pygaoh53bf@begin> --------------n06Dc1QYBkwAe02blN1wVy2I Content-Type: multipart/mixed; boundary="------------S3fzr0NNhVvsK6Ixi4OndRVK" --------------S3fzr0NNhVvsK6Ixi4OndRVK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTE6MDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowOCArMDEwMCwgYSBlY3JpdDoN Cj4+ICtzdGF0aWMgdW5zaWduZWQgaW50IGdldF9maWQoc3RydWN0IGRldl85cGZzICpkZXYp DQo+PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgZmlkOw0KPj4gKw0KPj4gKyAgICBmaWQg PSBmZnMoZGV2LT5maWRfbWFzayk7DQo+PiArICAgIGlmICggZmlkICkNCj4+ICsgICAgICAg IGRldi0+ZmlkX21hc2sgJj0gMVVMTCA8PCAoZmlkIC0gMSk7DQo+IA0KPiBJc24ndCB0aGF0 IG1pc3NpbmcgYSB+ID8NCg0KT2gsIGluZGVlZC4NCg0KPiANCj4+IEBAIC00NTksNiArNTIy LDEzNCBAQCBzdGF0aWMgaW50IHA5X2F0dGFjaChzdHJ1Y3QgZGV2XzlwZnMgKmRldikNCj4+ ICAgICAgIHJldHVybiByZXQ7DQo+PiAgIH0NCj4+ICAgDQo+PiArc3RhdGljIGludCBwOV9j bHVuayhzdHJ1Y3QgZGV2XzlwZnMgKmRldiwgdWludDMyX3QgZmlkKQ0KPj4gK3sNCj4+ICsg ICAgc3RydWN0IHJlcSAqcmVxID0gZ2V0X2ZyZWVfcmVxKGRldik7DQo+PiArICAgIGludCBy ZXQ7DQo+PiArDQo+PiArICAgIGlmICggIXJlcSApDQo+PiArICAgICAgICByZXR1cm4gRU5P RU5UOw0KPiANCj4gUmF0aGVyIEVBR0FJTj8gKGFuZCBzaW1pbGFyIGluIG90aGVyIGZ1bmN0 aW9ucykNCj4gKGFjdHVhbGx5IHA5X3ZlcnNpb24gYW5kIHA5X2F0dGFjaCBjb3VsZCBiZSB1 cGRhdGVkIHRvbywgZXZlbiBpZiBpbg0KPiB0aGVpciBjYXNlIGl0J3Mgbm90IHN1cHBvc2Vk IHRvIGhhcHBlbi4NCg0KWWVzLCBtaWdodCBiZSBiZXR0ZXIuDQoNCj4gDQo+PiArICAgIHJl cS0+Y21kID0gUDlfQ01EX0NMVU5LOw0KPj4gKyAgICBzZW5kXzlwKGRldiwgcmVxLCAiVSIs IGZpZCk7DQo+PiArICAgIHJjdl85cChkZXYsIHJlcSwgIiIpOw0KPj4gKyAgICByZXQgPSBy ZXEtPnJlc3VsdDsNCj4+ICsNCj4+ICsgICAgcHV0X2ZyZWVfcmVxKGRldiwgcmVxKTsNCj4+ ICsNCj4+ICsgICAgcmV0dXJuIHJldDsNCj4+ICt9DQo+IA0KPiANCj4+ICtzdGF0aWMgdW5z aWduZWQgaW50IHNwbGl0X3BhdGgoY29uc3QgY2hhciAqcGF0aG5hbWUsIGNoYXIgKipzcGxp dF9wdHIpDQo+PiArew0KPj4gKyAgICB1bnNpZ25lZCBpbnQgcGFydHMgPSAxOw0KPj4gKyAg ICBjaGFyICpwOw0KPj4gKw0KPj4gKyAgICAqc3BsaXRfcHRyID0gc3RyZHVwKHBhdGhuYW1l KTsNCj4+ICsNCj4+ICsgICAgZm9yICggcCA9IHN0cmNocigqc3BsaXRfcHRyLCAnLycpOyBw OyBwID0gc3RyY2hyKHAgKyAxLCAnLycpICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgKnAg PSAwOw0KPj4gKyAgICAgICAgcGFydHMrKzsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICBy ZXR1cm4gcGFydHM7DQo+PiArfQ0KPiANCj4gRG8gd2UgbmVlZCB0byBjYXJlIGFib3V0IGFu IGVtcHR5IHBhcnQgaWYgd2UncmUgcGFzc2VkICIvZm9vLy9iYXIiPw0KDQpJJ2QgcmF0aGVy IGFkZCBhIGNoZWNrIGZvciB0aGUgZmlsZSBuYW1lIHRvIGJlIHByb3Blcmx5IGNhbm9uaWNh bGl6ZWQNCmZ1cnRoZXIgdXAgaW4gdGhlIGhpZXJhcmNoeSAoZWl0aGVyIGluIG9wZW4oKSBk aXJlY3RseSwgb3IgaW4gb3Blbl85cGZzKCkpLg0KDQo+IA0KPj4gICBzdGF0aWMgaW50IG9w ZW5fOXBmcyhzdHJ1Y3QgbW91bnRfcG9pbnQgKm1udCwgY29uc3QgY2hhciAqcGF0aG5hbWUs IGludCBmbGFncywNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgbW9kZV90IG1vZGUpDQo+ PiAgIHsNCj4+IC0gICAgZXJybm8gPSBFTk9TWVM7DQo+PiArICAgIGludCBmZDsNCj4+ICsg ICAgY2hhciAqcGF0aCA9IE5VTEw7DQo+PiArICAgIGNoYXIgKnA7DQo+PiArICAgIHN0cnVj dCBmaWxlICpmaWxlOw0KPj4gKyAgICBzdHJ1Y3QgZmlsZV85cGZzICpmOXBmczsNCj4+ICsg ICAgdWludDE2X3QgbndhbGs7DQo+PiArICAgIHVpbnQ4X3Qgb21vZGU7DQo+PiArICAgIGlu dCByZXQ7DQo+PiArDQo+PiArICAgIGY5cGZzID0gY2FsbG9jKDEsIHNpemVvZigqZjlwZnMp KTsNCj4+ICsgICAgZjlwZnMtPmRldiA9IG1udC0+ZGV2Ow0KPj4gKyAgICBmOXBmcy0+Zmlk ID0gUDlfUk9PVF9GSUQ7DQo+PiArDQo+PiArICAgIGZkID0gYWxsb2NfZmQoZnR5cGVfOXBm cyk7DQo+PiArICAgIGZpbGUgPSBnZXRfZmlsZV9mcm9tX2ZkKGZkKTsNCj4+ICsgICAgZmls ZS0+ZmlsZWRhdGEgPSBmOXBmczsNCj4+ICsNCj4+ICsgICAgc3dpdGNoICggZmxhZ3MgJiBP X0FDQ01PREUgKQ0KPj4gKyAgICB7DQo+PiArICAgIGNhc2UgT19SRE9OTFk6DQo+PiArICAg ICAgICBvbW9kZSA9IFA5X09SRUFEOw0KPj4gKyAgICAgICAgYnJlYWs7DQo+PiArICAgIGNh c2UgT19XUk9OTFk6DQo+PiArICAgICAgICBvbW9kZSA9IFA5X09XUklURTsNCj4+ICsgICAg ICAgIGJyZWFrOw0KPj4gKyAgICBjYXNlIE9fUkRXUjoNCj4+ICsgICAgICAgIG9tb2RlID0g UDlfT1JEV1I7DQo+PiArICAgICAgICBicmVhazsNCj4+ICsgICAgZGVmYXVsdDoNCj4+ICsg ICAgICAgIHJldCA9IEVJTlZBTDsNCj4+ICsgICAgICAgIGdvdG8gZXJyOw0KPj4gKyAgICB9 DQo+IFsuLi5dDQo+PiArIGVycjoNCj4+ICsgICAgZnJlZShwYXRoKTsNCj4+ICsgICAgY2xv c2UoZmQpOw0KPj4gKyAgICBlcnJubyA9IHJldDsNCj4gDQo+IFRoaXMgc2VlbXMgbWlzc2lu ZyBmcmVlKGY5cGZzKT8NCg0KY2xvc2UoKSBkb2VzIHRoYXQgdmlhIGNsb3NlXzlwZnMoKS4N Cg0KDQpKdWVyZ2VuDQoNCg== --------------S3fzr0NNhVvsK6Ixi4OndRVK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------S3fzr0NNhVvsK6Ixi4OndRVK-- --------------n06Dc1QYBkwAe02blN1wVy2I-- --------------8ZbwYTaDRyDJ8fqLn06001jE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg0ygFAwAAAAAACgkQsN6d1ii/Ey8Y fQf/fL7x9heXbEJBL48tSCXTW6OYw7jEzQOiizt5WRR0+/lm93CySveo90odsVzZXKI+s5gi78ft NyKLQvw+N594qURTcW1a+6f6O8cVRXC9x3CVC1OiwjgFMES3zJQ3D9FoxL2gMGNLSoyPY+fl8ekN IOwEfoGB7weTgKf3upcttULmIA6dX3lSmZbQQb8tNCrDLJ75WL5f0cdzkzvOscIcNkz4bdNE3jZw Zsc8DPKoJWXg9lMaER/W9ks/GhgW5NVf9wGEEwnQuJLfCQeECn1rxa1G5qficMjz0hPMuG/FlyWT UfNABn4wOItpOuRTYfB16NK4OkCBQz1e4qBIoxwdqQ== =aPHh -----END PGP SIGNATURE----- --------------8ZbwYTaDRyDJ8fqLn06001jE-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:17:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:17:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490243.758878 (Exim 4.92) (envelope-from ) id 1pOyZ4-0001Bp-NO; Mon, 06 Feb 2023 10:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490243.758878; Mon, 06 Feb 2023 10:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyZ4-0001BO-ID; Mon, 06 Feb 2023 10:17:34 +0000 Received: by outflank-mailman (input) for mailman id 490243; Mon, 06 Feb 2023 10:17:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyZ3-0001Aw-Ip for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:17:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7590dc98-a607-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:17:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6432D60508; Mon, 6 Feb 2023 10:17:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E58F138E8; Mon, 6 Feb 2023 10:17:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id f5vnDbjT4GPUCQAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:17:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7590dc98-a607-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675678648; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=evmouaSQrGwFasoc4XbxgEKPXVKqbWqSn5F4PbsDFnA=; b=VUVaSMael8ihCS3giFabVmYD+FZ2TvxlR99RRV/eh1ngmGEaV4UiIDa8aZ30kFy9Kon7er ZKbAsAV3ajUJZ8YfE4P23XHn7LSaq+LB2z8fp90LFbRttKEHKUWTfUa3CkP4I9fhr2GjOS c3f2jaBjEr3A6G70UZJ63xVauBr3d28= Message-ID: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Date: Mon, 6 Feb 2023 11:17:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> From: Juergen Gross In-Reply-To: <20230206101341.5l7cxb2vvregskrx@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------yclteTcnPxnWv8Sct0dAK7cP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------yclteTcnPxnWv8Sct0dAK7cP Content-Type: multipart/mixed; boundary="------------ZNp3eWVZTHb7uEwrN7eu7GJn"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> In-Reply-To: <20230206101341.5l7cxb2vvregskrx@begin> --------------ZNp3eWVZTHb7uEwrN7eu7GJn Content-Type: multipart/mixed; boundary="------------DMoWO1LRQM0vB4sWYiinpiYJ" --------------DMoWO1LRQM0vB4sWYiinpiYJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTE6MTMsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gDQo+IEp1ZXJn ZW4gR3Jvc3MsIGxlIHZlbi4gMDMgZsOpdnIuIDIwMjMgMTA6MTg6MDkgKzAxMDAsIGEgZWNy aXQ6DQo+PiBUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24gb2YgcmVhZC93 cml0ZSBtZXNzYWdlcyB0byBzdGF5DQo+PiBiZWxvdyB0aGUgbWF4LiBzdXBwb3J0ZWQgbWVz c2FnZSBzaXplLg0KPiANCj4gSXQgc2hvdWxkIGF0IGxlYXN0IGJlIGFzc2VydGVkLg0KDQpJ dCBjYW4gZWFzaWx5IGJlIGxpbWl0ZWQgYnkgcmV0dXJuaW5nIHRoZSByZXN1bHRpbmcgbGlt aXQgYXMgdGhlDQpudW1iZXIgb2YgcHJvY2Vzc2VkIGJ5dGVzLg0KDQo+IA0KPj4gK3N0YXRp YyBpbnQgcDlfcmVhZChzdHJ1Y3QgZGV2XzlwZnMgKmRldiwgdWludDMyX3QgZmlkLCB1aW50 NjRfdCBvZmZzZXQsDQo+PiArICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgKmRhdGEsIHVp bnQzMl90IGxlbikNCj4+ICt7DQo+PiArICAgIHN0cnVjdCByZXEgKnJlcSA9IGdldF9mcmVl X3JlcShkZXYpOw0KPj4gKyAgICBpbnQgcmV0Ow0KPj4gKyAgICB1aW50MzJfdCBjb3VudDsN Cj4+ICsNCj4+ICsgICAgaWYgKCAhcmVxICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgZXJy bm8gPSBFSU87DQo+IA0KPiBIZXJlIGFzIHdlbGwgKGFuZCBpbiBwOV93cml0ZSkgd2UnZCB3 YW50IEVBR0FJTiByYXRoZXIgdGhhbiBFSU8gd2hpY2gNCj4gY2FuIGJlIG1pc3Rha2VuIHdp dGggdGhlIGVycm9yIGNhc2UgYmVsb3cuDQoNCkZpbmUgd2l0aCBtZS4NCg0KDQpKdWVyZ2Vu DQoNCg== --------------DMoWO1LRQM0vB4sWYiinpiYJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------DMoWO1LRQM0vB4sWYiinpiYJ-- --------------ZNp3eWVZTHb7uEwrN7eu7GJn-- --------------yclteTcnPxnWv8Sct0dAK7cP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg07cFAwAAAAAACgkQsN6d1ii/Ey/Y ewf/Vs2qlPU52r/B/GeotisiJJzEbN7c93ENdaydlUth3ICAPO7+W2kKy8W1ZShmDHZKM7Xa6NGW 7Bk9kde9LMp7LDsNzckJ/+5IjLvATdoZM+TmDmq3fIkcWnXv7c3dnagoFqWXJfV5JXExgAJRaEtE xatHxhq9Uh0Qv4PooJBZ+vSP7h2CaQfzGu4cwlwW9o6pTfEAY5nhjt7KXRZ3bRpJiwhvpeIIT0pm oeYEx25eIwJNNZQkBwnOwm6rS4GB/BLWiFfb7zPDoeZSdoVoiIUOrm9NkD3PlWWZV0/uchsP1HqS TXIWArImFew8eSB3o4PKwjm67DAoAKyxpR0WT/KCIw== =Wzru -----END PGP SIGNATURE----- --------------yclteTcnPxnWv8Sct0dAK7cP-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:23:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:23:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490253.758896 (Exim 4.92) (envelope-from ) id 1pOyey-0002rj-DQ; Mon, 06 Feb 2023 10:23:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490253.758896; Mon, 06 Feb 2023 10:23:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyey-0002rc-AR; Mon, 06 Feb 2023 10:23:40 +0000 Received: by outflank-mailman (input) for mailman id 490253; Mon, 06 Feb 2023 10:23:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOyew-0002pV-9f for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:23:38 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f1806d8-a608-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 11:23:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3941860594; Mon, 6 Feb 2023 10:23:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 130BE138E8; Mon, 6 Feb 2023 10:23:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y/RVAybV4GMJDwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 10:23:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f1806d8-a608-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675679014; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eGuanfrf0A3kzUhMN7lYsuKZW6Zk7dcW6JQI09EEc7E=; b=NvBgQUREx2mV11XQLWf0Gb8PzOBQ9OqzGwl8Qb7vUu+Z31/hXKBMFgXd7heDTEFWwji4pX j/sCo7cSve/4FXqQlP3RElJd3WirHlBy5AI2+K62FYBczkslE/RT1SCDRYf6EfORPwpWbs gafktPBan309XRMi70mwZMBfNgeeAYY= Message-ID: <3ba95dd4-36f7-334e-0b03-56fa2bc0cbb3@suse.com> Date: Mon, 6 Feb 2023 11:23:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> <20230206094032.se33a5z3kzfauywg@begin> From: Juergen Gross Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer In-Reply-To: <20230206094032.se33a5z3kzfauywg@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Bc4x9tYfP8tMKt8xWp0H1ECW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Bc4x9tYfP8tMKt8xWp0H1ECW Content-Type: multipart/mixed; boundary="------------xP67I5Wz0d9SdgXgy6oP56QB"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <3ba95dd4-36f7-334e-0b03-56fa2bc0cbb3@suse.com> Subject: Re: [PATCH 5/7] Mini-OS: add 9pfs transport layer References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-6-jgross@suse.com> <20230206094032.se33a5z3kzfauywg@begin> In-Reply-To: <20230206094032.se33a5z3kzfauywg@begin> --------------xP67I5Wz0d9SdgXgy6oP56QB Content-Type: multipart/mixed; boundary="------------ex1d1W3yAyV40Lsc7SfLXea8" --------------ex1d1W3yAyV40Lsc7SfLXea8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTA6NDAsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAwMyBmw6l2ci4gMjAyMyAxMDoxODowNyArMDEwMCwgYSBlY3JpdDoN Cj4+ICsvKg0KPj4gKyAqIFVzaW5nIGFuIG9wcG9ydHVuaXN0aWMgYXBwcm9hY2ggZm9yIHJl Y2VpdmluZyBkYXRhOiBpbiBjYXNlIG11bHRpcGxlDQo+PiArICogcmVxdWVzdHMgYXJlIG91 dHN0YW5kaW5nICh3aGljaCBpcyB2ZXJ5IHVubGlrZWx5KSwgd2UgbmV2ZXJ0aGVsZXNzIG5l ZWQNCj4+ICsgKiB0byBjb25zdW1lIGFsbCBkYXRhIGF2YWlsYWJsZSB1bnRpbCB3ZSByZWFj aCB0aGUgZGVzaXJlZCByZXF1ZXN0Lg0KPj4gKyAqIEZvciByZXF1ZXN0cyBvdGhlciB0aGFu IHRoZSBvbmUgd2UgYXJlIHdhaXRpbmcgZm9yLCB3ZSBsaW5rIHRoZSBjb21wbGV0ZQ0KPj4g KyAqIGRhdGEgdG8gdGhlIHJlcXVlc3QgdmlhIGFuIGludGVybWVkaWF0ZSBidWZmZXIuIEZv ciBvdXIgb3duIHJlcXVlc3Qgd2UgY2FuDQo+PiArICogb21pdCB0aGF0IGJ1ZmZlciBhbmQg ZGlyZWN0bHkgZmlsbCB0aGUgY2FsbGVyIHByb3ZpZGVkIHZhcmlhYmxlcy4NCj4+ICsgKi8N Cj4gDQo+IFRoaXMgZG9jdW1lbnRzIHRoZSAid2h5IiB3aGljaCBpcyB2ZXJ5IHdlbGNvbWUs IGJ1dCBkb2VzIG5vdCBkb2N1bWVudA0KPiB3aGF0IHRoZSBmdW5jdGlvbiBkb2VzIGV4YWN0 bHkgKEFJVUksIGNvcHkgZnJvbSBidWYxK2J1ZjIgaW50byB0YXJnZXQgdXANCj4gdG8gbGVu IGJ5dGVzLCBhbmQgdXBkYXRlIGJ1Zi9sZW4gYWNjb3JkaW5nbHkpLg0KDQpPa2F5LCB3aWxs IGFkZCBzb21lIG1vcmUgY29tbWVudHMuDQoNCj4gDQo+PiArc3RhdGljIHZvaWQgY29weV9i dWZzKHVuc2lnbmVkIGNoYXIgKipidWYxLCB1bnNpZ25lZCBjaGFyICoqYnVmMiwNCj4+ICsg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpsZW4xLCB1bnNpZ25lZCBpbnQg KmxlbjIsDQo+PiArICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKnRhcmdldCwgdW5zaWdu ZWQgaW50IGxlbikNCj4+ICt7DQo+PiArICAgIGlmICggbGVuIDw9ICpsZW4xICkNCj4+ICsg ICAgew0KPj4gKyAgICAgICAgbWVtY3B5KHRhcmdldCwgKmJ1ZjEsIGxlbik7DQo+PiArICAg ICAgICAqYnVmMSArPSBsZW47DQo+PiArICAgICAgICAqbGVuMSAtPSBsZW47DQo+PiArICAg IH0NCj4+ICsgICAgZWxzZQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBtZW1jcHkodGFyZ2V0 LCAqYnVmMSwgKmxlbjEpOw0KPj4gKyAgICAgICAgdGFyZ2V0ID0gKGNoYXIgKil0YXJnZXQg KyAqbGVuMTsNCj4+ICsgICAgICAgIGxlbiAtPSAqbGVuMTsNCj4+ICsgICAgICAgICpidWYx ID0gKmJ1ZjI7DQo+PiArICAgICAgICAqbGVuMSA9ICpsZW4yOw0KPj4gKyAgICAgICAgKmJ1 ZjIgPSBOVUxMOw0KPj4gKyAgICAgICAgKmxlbjIgPSAwOw0KPj4gKyAgICAgICAgaWYgKCBs ZW4gPiAqbGVuMSApDQo+PiArICAgICAgICAgICAgbGVuID0gKmxlbjE7DQo+IA0KPiBCdXQg dGhlbiB0aGlzIGlzIGEgc2hvcnQgY29weSwgZG9uJ3Qgd2UgbmVlZCB0byBlcnJvciBvdXQs IG9yIGF0IGxlYXN0DQo+IGxvZyBzb21ldGhpbmc/IE5vcm1hbGx5IHRoZSBvdGhlciBlbmQg aXMgbm90IHN1cHBvc2VkIHRvIHB1c2ggZGF0YQ0KPiBpbmNyZW1lbnRhbHksIGJ1dCBiZXR0 ZXIgYXQgbGVhc3QgY2F0Y2ggc3VjaCBtaXNwcm9ncmFtbWluZy4NCg0KSSBjYW4gYWRkIGEg bG9nIG1lc3NhZ2UuDQoNCj4gDQo+PiArICAgICAgICBtZW1jcHkodGFyZ2V0LCAqYnVmMSwg KmxlbjEpOw0KPj4gKyAgICB9DQo+PiArfQ0KPj4gKw0KPj4gK3N0YXRpYyB2b2lkIHJjdl85 cF9jb3B5KHN0cnVjdCBkZXZfOXBmcyAqZGV2LCBzdHJ1Y3QgcmVxICpyZXEsDQo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHA5X2hlYWRlciAqaGRyLCBjb25zdCBjaGFy ICpmbXQsIHZhX2xpc3QgYXApDQo+IA0KPiBQbGVhc2UgZG9jdW1lbnQgd2hhdCB0aGlzIGhl bHBlciBmdW5jdGlvbiBkb2VzIChhdCB0aGUgdmVyeSBsZWFzdCB3aGljaA0KPiB3YXkgdGhl IGNvcHkgaGFwcGVucykuIFRoZSBoZHIgIT0gTlVMTCB2cyA9PSBOVUxMIG5vdGFibHkgbmVl ZHMgdG8gYmUNCj4gZXhwbGFpbmVkLg0KDQpPa2F5Lg0KDQo+IA0KPj4gKyAgICAgICAgY2Fz ZSAnUSc6DQo+PiArICAgICAgICAgICAgcXZhbCA9IHZhX2FyZyhhcCwgdWludDhfdCAqKTsN Cj4+ICsgICAgICAgICAgICBjb3B5X2J1ZnMoJmJ1ZjEsICZidWYyLCAmbGVuMSwgJmxlbjIs IHF2YWwsIDEzKTsNCj4gDQo+IEknZCBzYXkgbWFrZSB0aGlzIDEzIGEgbWFjcm8uDQoNCk9r YXkuDQoNCj4gDQo+IA0KPj4gK3N0YXRpYyB2b2lkIHJjdl85cChzdHJ1Y3QgZGV2XzlwZnMg KmRldiwgc3RydWN0IHJlcSAqcmVxLCBjb25zdCBjaGFyICpmbXQsIC4uLikNCj4+ICt7DQo+ PiArICAgIHZhX2xpc3QgYXA7DQo+PiArDQo+PiArICAgIHZhX3N0YXJ0KGFwLCBmbXQpOw0K Pj4gKw0KPj4gKyAgICBkb3duKCZkZXYtPnJpbmdfaW5fc2VtKTsNCj4+ICsNCj4+ICsgICAg d2hpbGUgKCAhcmN2XzlwX29uZShkZXYsIHJlcSwgZm10LCBhcCkgKTsNCj4+ICsNCj4+ICsg ICAgcm1iKCk7IC8qIFJlYWQgYWxsIGRhdGEgYmVmb3JlIHVwZGF0aW5nIHJpbmcgaW5kZXgu ICovDQo+PiArICAgIGRldi0+aW50Zi0+aW5fY29ucyA9IGRldi0+Y29uc19wdnRfaW47DQo+ IA0KPiBTaG91bGRuJ3QgdGhlcmUgYmUgYW4gZXZlbnQgbm90aWZpY2F0aW9uIGFmdGVyIHVw ZGF0aW5nIHRoZSBjb25zdW1wdGlvbg0KPiBpbmRleD8NCg0KSG1tLCB5ZXMuDQoNCg0KSnVl cmdlbg0K --------------ex1d1W3yAyV40Lsc7SfLXea8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ex1d1W3yAyV40Lsc7SfLXea8-- --------------xP67I5Wz0d9SdgXgy6oP56QB-- --------------Bc4x9tYfP8tMKt8xWp0H1ECW Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPg1SUFAwAAAAAACgkQsN6d1ii/Ey92 qgf7BfSpL1a3P5Fg0ErbMeHBESKFsN0h+VmbP/vkfxIKhDG9aEiA3nDMrJCWexGqFosGUnyj0MVe EEgM8Smv+KzWG4GtERoOx28RyVpnfe3DOIj2iMx2//H1mJtEq/HsLnFS2goHjyv12H8A0Eok5j1q fWQJpIq/SKTHjEhZDT6BnxUJSfLWILIZb6s493jXHdB2kkBDN5JLdVXcCPxx/t23XziKqX37ofJe PRZZjJNyVv0FrZ+o9uGn/pn/yOAzhie27HzS4dOOHG/FicU5737HuVgah+dRngc/cs3oMO5k+urm umZO3I7T5mMu0kHwk4dgTRV8dJGGDGSKekc7f6RKmQ== =hbgf -----END PGP SIGNATURE----- --------------Bc4x9tYfP8tMKt8xWp0H1ECW-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 10:38:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 10:38:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490265.758909 (Exim 4.92) (envelope-from ) id 1pOytU-0004cw-Na; Mon, 06 Feb 2023 10:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490265.758909; Mon, 06 Feb 2023 10:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOytU-0004cp-Kw; Mon, 06 Feb 2023 10:38:40 +0000 Received: by outflank-mailman (input) for mailman id 490265; Mon, 06 Feb 2023 10:38:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOytU-0004cj-7n for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 10:38:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pOytP-0004ZH-1b; Mon, 06 Feb 2023 10:38:35 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.13.231]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pOytO-0003RC-Re; Mon, 06 Feb 2023 10:38:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=x56EfA9OWN1eC+U2EnXtfTTLCv7iltDe9D/V/Fvb+jk=; b=6Sxv18QYcl9/6on5qFbxrHn1KN d0Wss9kAkdCcKJDIfxayqiTFikOjRRFqlTyFNNeHUsW7pF5o8iUPr4tfCYQluHVVY0GoSfXGDpBxP XN3lIpm1utmBZJd+gsbVHKzJu58PLOnKEUPZL+G4p3SsdddnRGpAV3Z3GK6C/2kZrmIA=; Message-ID: <15b88500-89b0-507a-601c-84a8102bb550@xen.org> Date: Mon, 6 Feb 2023 10:38:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Content-Language: en-US To: Elliott Mitchell Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich References: <202302031801.313I1SdK033264@m5p.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/02/2023 07:29, Jan Beulich wrote: > On 22.07.2020 19:43, Elliott Mitchell wrote: >> Unlike other unsupportted options, ACPI support is required to *boot* >> for a number of platforms. Users on these platforms are unable to use >> distribution builds and must rebuild from source to use Xen. >> >> Signed-off-by: Elliott Mitchell > > A general question first: How come this mail dates back to July 2020? I > had almost missed it as "new". I can't even find the Elliott's email in my inbox so reply here. But this sounds like a rehash of [1]. >> Unlike other unsupportted options, ACPI support is required to *boot* >> for a number of platforms. Users on these platforms are unable to use >> distribution builds and must rebuild from source to use Xen. What platforms are you testing on? I know that this is working-ish on RPI4 and QEMU. But this will likely blow up on one of the server we support in OSSTest because we don't have proper support to hide SMMUs in dom0. > >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -29,13 +29,18 @@ menu "Architecture Features" >> source "arch/Kconfig" >> >> config ACPI >> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED >> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" The concerns I raised in [1] still stand. Most of the ACPI platform will also have support for IOMMUs. If we have support for IORT in Xen, then I would be a lot more amenable to remove the "UNSUPPORTED". And without that support we are going to do more harm and than good. > > Personally I think the (UNSUPPORTED) in the prompt should then go away as > well. Which in turn points out that we will want to reconsider whether we > actually have UNSUPPORTED as a Kconfig control, as its purpose looks to > be specifically cases like the one here. The question goes to Stefano in > particular, who I think had introduced it back at the time. Cheers, [1] 20201022014310.GA70872@mattapan.m5p.com -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:06:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490304.758926 (Exim 4.92) (envelope-from ) id 1pP0FY-00061s-Bi; Mon, 06 Feb 2023 12:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490304.758926; Mon, 06 Feb 2023 12:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0FY-00061l-90; Mon, 06 Feb 2023 12:05:32 +0000 Received: by outflank-mailman (input) for mailman id 490304; Mon, 06 Feb 2023 12:05:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0FW-00061a-RI for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:05:30 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b20074c-a616-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 13:05:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id DF5EB2012F; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zYnBPJhNB15A; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from begin (nat-inria-interne-52-gw-01-bso.bordeaux.inria.fr [194.199.1.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 93CEE20127; Mon, 6 Feb 2023 13:05:26 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pP0FS-009A6r-0i; Mon, 06 Feb 2023 13:05:26 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b20074c-a616-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 13:05:26 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230206120526.242njyptovkpz3jl@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 06 févr. 2023 11:17:27 +0100, a ecrit: > On 06.02.23 11:13, Samuel Thibault wrote: > > > > Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit: > > > This patch is missing the limitation of read/write messages to stay > > > below the max. supported message size. > > > > It should at least be asserted. > > It can easily be limited by returning the resulting limit as the > number of processed bytes. Strictly speaking, posix allows to return short reads, but that's usually only handled by applications when they know that they may get signals. I'd thus rather have read/write loop over the size. Samuel From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:13:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:13:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490315.758942 (Exim 4.92) (envelope-from ) id 1pP0Mp-0007XP-4Y; Mon, 06 Feb 2023 12:13:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490315.758942; Mon, 06 Feb 2023 12:13:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0Mp-0007XI-1M; Mon, 06 Feb 2023 12:13:03 +0000 Received: by outflank-mailman (input) for mailman id 490315; Mon, 06 Feb 2023 12:13:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0Mn-0007XC-8q for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:13:01 +0000 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [2607:f8b0:4864:20::e30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98df9227-a617-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:13:00 +0100 (CET) Received: by mail-vs1-xe30.google.com with SMTP id s24so12384998vsi.12 for ; Mon, 06 Feb 2023 04:13:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98df9227-a617-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hnrQtIEEU+7ze7l7ZQEZnhcc5uc+DBDXvxux78MGYMA=; b=TqN5QPcGMttgNtiBd6sV/hj+HGRVUX3x7+d1wnhunVyNUshNLX+sQvZ/5fpfD20HiR GOoI85X5a7oImnfwvaPUVxK8tr6QbNcH3pLSd/1jXZRruHhxwOvtjNJ5UlU7sRGBOtET aTSFjg21EtkzNCzTGWA7Se6Ptt/B2tvX5vMi/QWEF815ydsJiLu6071NGRvGfgs99NCz 70YJNG3+4jQ2iuxgbTvPkV5C1v55Rbm1K8hO6yPCeTG/UArcCBQJWyipwJgBQoEbFPX1 Xr8PURzBbsXfII2bTZ/L2wdGGbnr78PywHzlvHvGyA44g5ajD4WSLfevRUAmOuM07S+3 lLrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hnrQtIEEU+7ze7l7ZQEZnhcc5uc+DBDXvxux78MGYMA=; b=IUfhd9WIDAJ5/TuWeSK5d+Y95amw13LAXI7o8hwp/dbwdyX38+kkAhiqmCAotuUSP4 VnMvHpgZZ2h7nsjMmzLNyUeOyck+3smf0uG+Wj+KeSJYzlHFyyxZo+l1p1xZejZk14h7 DamsKf8+cEzLjFWAFPljEfpKNw9CFvvaJSnZyPByqNuFQc0PerdiGYNqSDrQ7gAm/TMU RVPYK4s5VlBnQTkBnZqWiIdLr1EDSnsfq8D+WmpK84XUhk6OdfxzWdm47qKvztmMxIY8 EcNHOoDuL8mhTYpNZ6DvmzVDEEselBJoVPx0rdUQzPCMJaLi4kYjSWu82YkMSsmSLfpl uZnA== X-Gm-Message-State: AO0yUKXxpABu/pvz3SjzDBI9KU6kCvGTkLWUfQFtzpPhT2Gv69G+Q+Qv Q91ihmdcmbK52aBBkdpS7Mw5gz/7LyhCwLDyrIs= X-Google-Smtp-Source: AK7set9TzkSvoulAkqG/X+6ql1sxHWFIXaE72ejGNV8n9SqrZXXDCRO67SGleU02+jRa/cjb8zDVXJh7ybOSSOUmVGg= X-Received: by 2002:a05:6102:1276:b0:3ee:4ef8:45d3 with SMTP id q22-20020a056102127600b003ee4ef845d3mr2498543vsg.64.1675685579305; Mon, 06 Feb 2023 04:12:59 -0800 (PST) MIME-Version: 1.0 References: <1eaa4cce-2ef2-ca38-56d2-5d551c9c1ae9@suse.com> <509f24de-a34e-7702-4579-b27bcb86ce70@suse.com> In-Reply-To: <509f24de-a34e-7702-4579-b27bcb86ce70@suse.com> From: Alistair Francis Date: Mon, 6 Feb 2023 22:12:33 +1000 Message-ID: Subject: Re: Ping: [PATCH] tools/symbols: drop asm/types.h inclusion To: Jan Beulich Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Connor Davis , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="UTF-8" On Mon, Feb 6, 2023 at 5:40 PM Jan Beulich wrote: > > On 20.01.2023 09:40, Jan Beulich wrote: > > While this has been there forever, it's not clear to me what it was > > (thought to be) needed for. In fact, all three instances of the header > > already exclude their entire bodies when __ASSEMBLY__ was defined. > > Hence, with no other assembly files including this header, we can at the > > same time get rid of those conditionals. > > > > Signed-off-by: Jan Beulich Reviewed-by: Alistair Francis Alistair > > May I please ask for a RISC-V side ack (or otherwise) here? > > Thanks, Jan > > > --- a/xen/arch/arm/include/asm/types.h > > +++ b/xen/arch/arm/include/asm/types.h > > @@ -1,9 +1,6 @@ > > #ifndef __ARM_TYPES_H__ > > #define __ARM_TYPES_H__ > > > > -#ifndef __ASSEMBLY__ > > - > > - > > typedef __signed__ char __s8; > > typedef unsigned char __u8; > > > > @@ -54,8 +51,6 @@ typedef u64 register_t; > > #define PRIregister "016lx" > > #endif > > > > -#endif /* __ASSEMBLY__ */ > > - > > #endif /* __ARM_TYPES_H__ */ > > /* > > * Local variables: > > --- a/xen/arch/riscv/include/asm/types.h > > +++ b/xen/arch/riscv/include/asm/types.h > > @@ -1,8 +1,6 @@ > > #ifndef __RISCV_TYPES_H__ > > #define __RISCV_TYPES_H__ > > > > -#ifndef __ASSEMBLY__ > > - > > typedef __signed__ char __s8; > > typedef unsigned char __u8; > > > > @@ -57,8 +55,6 @@ typedef u64 register_t; > > > > #endif > > > > -#endif /* __ASSEMBLY__ */ > > - > > #endif /* __RISCV_TYPES_H__ */ > > /* > > * Local variables: > > --- a/xen/arch/x86/include/asm/types.h > > +++ b/xen/arch/x86/include/asm/types.h > > @@ -1,8 +1,6 @@ > > #ifndef __X86_TYPES_H__ > > #define __X86_TYPES_H__ > > > > -#ifndef __ASSEMBLY__ > > - > > typedef __signed__ char __s8; > > typedef unsigned char __u8; > > > > @@ -32,6 +30,4 @@ typedef unsigned long paddr_t; > > #define INVALID_PADDR (~0UL) > > #define PRIpaddr "016lx" > > > > -#endif /* __ASSEMBLY__ */ > > - > > #endif /* __X86_TYPES_H__ */ > > --- a/xen/tools/symbols.c > > +++ b/xen/tools/symbols.c > > @@ -302,7 +302,6 @@ static void write_src(void) > > return; > > } > > printf("#include \n"); > > - printf("#include \n"); > > printf("#if BITS_PER_LONG == 64 && !defined(SYMBOLS_ORIGIN)\n"); > > printf("#define PTR .quad\n"); > > printf("#define ALGN .align 8\n"); > > > > From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:22:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:22:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490323.758953 (Exim 4.92) (envelope-from ) id 1pP0WA-0000fR-1T; Mon, 06 Feb 2023 12:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490323.758953; Mon, 06 Feb 2023 12:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0W9-0000fK-Us; Mon, 06 Feb 2023 12:22:41 +0000 Received: by outflank-mailman (input) for mailman id 490323; Mon, 06 Feb 2023 12:22:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0W9-0000fE-17 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:22:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f25255de-a618-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:22:39 +0100 (CET) Received: from DB8PR09CA0014.eurprd09.prod.outlook.com (2603:10a6:10:a0::27) by AM0PR08MB5410.eurprd08.prod.outlook.com (2603:10a6:208:182::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:21:58 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::43) by DB8PR09CA0014.outlook.office365.com (2603:10a6:10:a0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 12:21:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31 via Frontend Transport; Mon, 6 Feb 2023 12:21:58 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Mon, 06 Feb 2023 12:21:57 +0000 Received: from f91aebf85563.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 732E804C-A809-4A86-B1BF-2C70AB1296FA.1; Mon, 06 Feb 2023 12:21:51 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f91aebf85563.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 12:21:51 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB8449.eurprd08.prod.outlook.com (2603:10a6:150:81::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:21:48 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 12:21:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f25255de-a618-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nk01eoEzdydpuKXtKkiVQl/biFAmUsr/YQFF4kLQvgQ=; b=42ITL4SbcL3/iHWIALjhTKCzgby9KW3qOj9HOpTJH1Et9Z/3ywAC9CKl6oldWzpQ5esXAn1B2FebbN8qbtGDdH35yEVJKUqLzo+Ivy16Y8vnyop9yohk+YAPeg5Xd3dVby4fonbj0hUxgmo3f5XwcQcsr89VJwq/Xvi7GPIZy00= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0f1541c4d77ffdee X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RP+TP4aIw+RfsgA7is46xI8CyUhqZkbicGWA6SOUfk5mbVIuOaPdA3gb09FNUKqbmkwLGXHAsNjyo0dIi2FtsbmV8DFV8UQ7lE6ji+hHySHFQOYPq6YbNDMlVn8vdrpsVp6w1qxBh8/ow8ULcZKxLrvBPVTScSOWke+zYjq18wGwLqUHh5+1+sSXeMPY+Q1E6+1ClynYLR+GLdT4zM5GodFefYTQL0/WIw80FIZSqVTSnWUa4bbJYVO+tRlrk5gob3BBO/DLu/KhTd2n0mV+6xvPGI3rjlfEEaJMLFIVLch6emac9KeZzEeYxJriVToJcOcPfA1M2u12Q/8RrQJJEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nk01eoEzdydpuKXtKkiVQl/biFAmUsr/YQFF4kLQvgQ=; b=NlZB0wtqfLv3gl4e3h+RC8YMzE2GQpLJYFUIhNWvi7tXGNMocvJM2fj/RYPxWYlPjkIq42M2ARnyauRRNOHdFkf3/d/+mlQykcrPpwDQ+SOxfDbAMuVdSWT/QqrtDsbY8Uv/Pb+jTdcjVl67ktql0Y2W38DD41GpZiXtnFoFx1w1WKpDK6y17kJjfp3Art8jJBIoDMHkaVbt3PF9i7hOCQBM+Ztqam/AB/7YOrwUClLOraf+izOQb7/VwBbJEmZXBEI1TXJVoHRGK9piSVP5f0yDd9lu15/hpu+eLQh3ovmpGtrGMm3kdvTwKwBEC1QGCY2bZycaZbObbjiYBMQn9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nk01eoEzdydpuKXtKkiVQl/biFAmUsr/YQFF4kLQvgQ=; b=42ITL4SbcL3/iHWIALjhTKCzgby9KW3qOj9HOpTJH1Et9Z/3ywAC9CKl6oldWzpQ5esXAn1B2FebbN8qbtGDdH35yEVJKUqLzo+Ivy16Y8vnyop9yohk+YAPeg5Xd3dVby4fonbj0hUxgmo3f5XwcQcsr89VJwq/Xvi7GPIZy00= From: Luca Fancellu To: Jan Beulich CC: Stefano Stabellini , Andrew Cooper , George Dunlap , Julien Grall , Xen-devel Subject: Re: Proposal: List files in Xen originated from external sources Thread-Topic: Proposal: List files in Xen originated from external sources Thread-Index: AQHZN7IkxuQrtwTv+0WBDKkxqc3Ztq7BtLQAgAAnBYA= Date: Mon, 6 Feb 2023 12:21:48 +0000 Message-ID: <9EDE6823-A6EB-4ECF-BFFA-2FE896C076AD@arm.com> References: <005b7fa3-0f64-b15d-38d5-8135b0da06d2@suse.com> In-Reply-To: <005b7fa3-0f64-b15d-38d5-8135b0da06d2@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB8449:EE_|DBAEUR03FT062:EE_|AM0PR08MB5410:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ad75653-89d7-4179-e5f6-08db083cbde7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZmdE0PBg9LqemmOCZu3hxh1zA44yn/0u12aekb8xQoD9obGNlax35aagx6diQ80bnkRMJTlQeT4vQBM05UFV7xc/KIcoXD8I811/XBwm0smWFxoJWxCaj/kGdIaGwc82amDZZasehZwZmkMV4p2v7idWrGaUvRwMEfmDhOAnBPo3t859fHeVkjA6+mK0qkh32T/TwCP8t2GCj6QgEdW2yDbgfu8Rt/WFHcKNq1kVdivzev13fDAB6u4tKZpSJoeXmBW7SpWjx0GYlN+2FEP9dahEWj7XZ0EK0chrerwG+zUFgXhVvAXJRsLClfX5Q/922V0yj4FuQzGrIS0H5zlTBvhnzfs/MNR1i/VCxZAFjZg3ZWtAAmVMc0kA0psbfw/AAm+h4zHvkKXkfdSflCrhKewgTWB4EY4Q3d9ye443W1UGzt0fydZOQJc1c/xA82CVScHfQGzDPUnKQhtLutZ8iXexokBH+e+tLBY3XHvRotRCvCBRA2u0hrwkvIbMfQ+iqlvYGhYP+tcaB85GLHkE8b43NWDqTlljARH5+63V2Ow2UsJQUa5dUzKarALD5bSl7yPJffMDdG0L8yD2H0dUgJLViIQTYlvJOF9DJ9yH36nTgcclfmB6uUuwnKpqyWPRvvVofa8wC3droltiyLI8Egv9jHwbT5J7s7jGZp7ydVtzYkbmI14UAUFIGpXH3im700E1PSVgaBwU5ajkwpaYHJca50x3rEYuYdhZFYw/Vr5ssAdplIm3ApYpHf+v1s5KGObV/7aShjnSDM8NHigLHA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199018)(36756003)(33656002)(6486002)(71200400001)(66946007)(316002)(54906003)(8676002)(6506007)(53546011)(966005)(478600001)(64756008)(66446008)(5660300002)(2906002)(66476007)(66556008)(8936002)(6916009)(91956017)(76116006)(4326008)(26005)(83380400001)(38070700005)(41300700001)(6512007)(38100700002)(86362001)(122000001)(186003)(2616005)(66899018)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <09510CB97C079D419C5905E39958F19A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8449 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2c97ef6e-7d74-4796-d34d-08db083cb808 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OI2DVQG4FcgfW+GyG528cdwbiK1YF+FJfa0y23L5qe7e0IZ0j1nr2+VtorLt9VrwEmfPGTbZFvVBGOZCEOYRuPFrwL+dgWkGIlkILHbnfSfm8heRkfDF6Y6UQqOzTberQ6Ky4Kp7kJt1Vj5fghHQx7Euj4yuI4H2j3C1ZRvjdGddYWBrNgSP+QEpW1wqZZ5Hdoz2ml6Kl5ZyaOUBbUi+FyJqDG4pK4PjHU7HcQwNlbBE3UgeGq1vlWC+rRpeR1c7cks7P98aMxOqybvhbNWTaHXlccGeROIHTO8nGcPnemdT1ts2TihXzOf1KS3p3H6aPQ4tOTnLawvOsy51iJEDdtXIzX4NUeLhGnJKCRFySYgMHEcigMBtiNfuJ2ZGjviW1F2TaBw1EaamoM8sahlIhkx2xBuEMUQhNecr16v4OGEj8VnxetAhHr3LOMgzT2bz8OMwRl7szEb7zj0MHFf5tJQDeWcjL8K/Cc8GANfILvN/KpbPzRQPQdZ9G7uD4s6c6mDgInyH5sC7Jd0x2qwZ08WXZIjqKTi0l5kZX1JFzo3aBDP+Hx8MpLqOluAmiveF2UfwA00O1X5UZefjz4x7tTVOrk2ItqEz2l/CwHSdYyb2gXaDu6ELQYipLIRkuwh/2S+7LhfCsuErgmR767wa1O1mV8i9pZ06JUAPU7b0iwZ1pLzb2nLrITqXWvJCjD4zPMbvOMTUCVFUiywYPYLkmrom2t3EPLAL9Vpzda2So0I= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199018)(36840700001)(40470700004)(46966006)(81166007)(356005)(33656002)(86362001)(36756003)(82740400003)(40460700003)(70586007)(41300700001)(36860700001)(8676002)(8936002)(6862004)(54906003)(4326008)(70206006)(316002)(5660300002)(2616005)(47076005)(40480700001)(336012)(83380400001)(6486002)(82310400005)(2906002)(478600001)(6512007)(186003)(26005)(6506007)(966005)(53546011)(66899018);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:21:58.0052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ad75653-89d7-4179-e5f6-08db083cbde7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5410 SGkgSmFuLA0KDQpUaGFuayB5b3UgZm9yIGxlYXZpbmcgeW91ciBmZWVkYmFja3MsIHJlYWxseSBh cHByZWNpYXRlZC4NCg0KPiBPbiA2IEZlYiAyMDIzLCBhdCAxMDowMSwgSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDAzLjAyLjIwMjMgMTA6MzAsIEx1Y2Eg RmFuY2VsbHUgd3JvdGU6DQo+PiBJ4oCZbSBzdGFydGluZyBhIHByb3Bvc2FsIGZvciB0aGUgZXh0 ZXJuYWwgZmlsZXMgdGhhdCBuZWVkcyB0byBiZSByZW1vdmVkIGZyb20gdGhlIE1JU1JBIHNjYW4s DQo+PiB0aGUgd29yayB3YXMgb3JpZ2luYWxseSBzdGFydGVkIGJ5IE1pY2hhbCBoZXJlOg0KPj4g aHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZlbC9wYXRjaC8yMDIy MTExNjA5MjAzMi40NDIzLTEtbWljaGFsLm9yemVsQGFtZC5jb20vDQo+PiBzbyBJIHN0YXJ0ZWQg YnkgdGhhdCB0aHJlYWQsIHRoZSBhaW0gb2YgdGhpcyB3b3JrIGlzIHRvIGhhdmUgYW4gaW5pdGlh bCBmb3JtYXQgdG8gc3RhcnQgYXMgc29vbiBhcyBwb3NzaWJsZSB0bw0KPj4gZXhjbHVkZSB0aGUg ZXh0ZXJuYWwgZmlsZXMgZnJvbSB0aGUgTUlTUkEgc2NhbiAoYXQgbGVhc3QgaW5pdGlhbGx5IGZy b20gY3BwY2hlY2spLg0KPj4gDQo+PiBJIHRoaW5rIHdlIGNhbiB1c2UgdGhlIEpTT04gZm9ybWF0 IGJlY2F1c2UgaXTigJlzIGVhc3kgdG8gaW50ZWdyYXRlIGl0IHdpdGggcHl0aG9uIGFuZCBpdOKA mXMgZWFzeSB0byBhZGQvcmVtb3ZlDQo+PiBmaWVsZHMgZnJvbSB0aGUgc3RydWN0dXJlIHdpdGhv dXQgaW50ZXJmZXJpbmcgd2l0aCB0aGUgb3RoZXIgZWxlbWVudHMgZHVyaW5nIHRpbWUsIHNvIHdl IGNhbiBkZWZpbmUgYSBzdHJ1Y3R1cmUNCj4+IG5vdyBidXQgaWYgaW4gdGhlIGZ1dHVyZSB3ZSBz ZWUgdGhlIG5lZWRzIGZvciBhZGRpdGlvbmFsIGZpZWxkLCB3ZSBjYW4ganVzdCBhZGQgdGhlbSB3 aXRob3V0IGNoYW5nZXMgdG8gdGhlDQo+PiBhbmFseXNpcyBzY3JpcHQuDQo+PiANCj4+IEluIG15 IG9waW5pb24gbWFueSBvZiB0aGVzZSBmaWVsZHMgY2FuIGJlIGxlZnQgZW1wdHkgaW4gYSBmaXJz dCBwdXNoLCB0byBsZXQgdGhlIHNjcmlwdCBleGNsdWRlIHRoZSBmaWxlcyBhbmQgZHVyaW5nDQo+ PiB0aW1lIHdpdGggdGhlIGNvbnRyaWJ1dGlvbnMgb2YgdGhlIGNvbW11bml0eSB3ZSBjYW4gYWRk IHRoZSBtaXNzaW5nIGluZm9ybWF0aW9ucy4NCj4gDQo+IEknbSBoYXZpbmcgdHJvdWJsZSBtYWtp bmcgYSBjb25uZWN0aW9uIGJldHdlZW4gYSBmaWxlIGhhdmluZyBhbiBlbnRyeSBoZXJlDQo+IGFu ZCB0aGUgbmVlZC9kZXNpcmUgdG8gaW5jbHVkZSBpdCBpbiBzY2FubmluZy4gQ2FuIHlvdSBjbGFy aWZ5IHBsZWFzZSB3aHkNCj4geW91IHNlZSBhbiBpbXBsaWNhdGlvbiBmcm9tIG9uZSB0byB0aGUg b3RoZXIgaGVyZT8NCg0KTXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0IGFuIGV4dGVybmFsIGZpbGUg c2hvdWxkIG5vdCBiZSBpbmNsdWRlZCBpbiB0aGUgcmVwb3J0LCBiZWNhdXNlIHdlIGNhbuKAmXQg ZG8gZGlyZWN0IGNoYW5nZXMNCnNvIHRoZXJlIG1pZ2h0IGJlIHNpdHVhdGlvbnMgd2hlcmUgdGhl IGZpeCBjYW7igJl0IGJlIGluY2x1ZGVkIGluIHRoZSBvcmlnaW5hbCBwcm9qZWN0IGFuZCBiYWNr IHBvcnRlZCBhZnRlcndhcmRzIGJlY2F1c2UNCnRoZSBvcmlnaW5hbCBwcm9qZWN0IGRvZXNu4oCZ dCBhcHBseSB0aGUgc2FtZSBjb2Rpbmcgc3RhbmRhcmQsIG9yIGNvZGUgdGhhdCBuZWVkcyB0byBi ZSBqdXN0aWZpZWQgc2ltcGx5IGNhbuKAmXQgYmUganVzdGlmaWVkDQpiZWNhdXNlIHRoZSB0YWcg d2UgdXNlIGRvZXNu4oCZdCBtYWtlIHNlbnNlIGluIHRoZSBvcmlnaW5hbCBwcm9qZWN0Lg0KU28g d2UgZGVjaWRlZCAoPykgdG8gbGVhdmUgdGhpcyBidXJkZW4gdG8gdGhlIGZpbmFsIHVzZXIgdGhh dCBtaWdodCBqdXN0IGNvbnN1bHQgdGhlIGxpc3Qgb2YgZXh0ZXJuYWwgZmlsZXMgdG8gZml4L2p1 c3RpZnkgd2hhdA0KaXMgbm90IGNvbXBsaWFudCB3aXRoIHRoZSBjb2Rpbmcgc3RhbmRhcmQgdGhh dCBuZWVkcyB0byBiZSBmb2xsb3dlZC4NCg0KPiANCj4+IEkgdGhpbmsgaXTigJlzIGVhc2llciBm b3IgdGhlIGNvbW11bml0eSB0byBwaWNrIGFuIGVudHJ5LCBkbyBzb21lIHJlc2VhcmNoIHRvIGZp bGwgdGhlIGdhcHMgYW5kIHB1c2gsIGluc3RlYWQgdG8gd2FpdA0KPj4gdW50aWwgaGF2aW5nIGFs bCB0aGUgaW5mb3JtYXRpb25zIGJlZm9yZSBhZGRpbmcgdGhlIGVudHJ5Lg0KPiANCj4gTWF5YmUg aXQncyBlYXNpZXIsIGJ1dCBpdCdzIHRoZW4gYWxzbyBsZXNzIHVzZWZ1bC4gRm9yIGV4YW1wbGUg SSB2aWV3DQo+IGl0IGFzIHF1aXRlIHJlbGV2YW50IHdoYXQgdGhlIG9yaWdpbiBvZiBhIGZpbGUg aXMuIFRoYXQgbWF5LCBmb3INCj4gZXhhbXBsZSwgaGF2ZSBhbiBpbXBsaWNhdGlvbiBvbiB3aGV0 aGVyICJiYWNrcG9ydCIgaXMgc2Vuc2libGUgdG8gc2V0DQo+IHRvICJ0cnVlIiAob3JpZ2luIHBy b2plY3RzIGNvdWxkLCBhZnRlciBhbGwsIGJlIGxhcmdlbHkgdW5tYWludGFpbmVkLA0KPiBhbmQg aGVuY2UgaXQgbWF5IGJlIGRpZmZpY3VsdCB0byBnZXQgYW55IGNoYW5nZXMgaW50byB0aGVyZSku DQoNCkl04oCZcyBhIGZpcnN0IHN0ZXAgdG8gdW5ibG9jayB0aGUgY29kZSBzY2FubmVyIHRvIGRv IHByb3Blcmx5IGl0cyBqb2IsIHRoYXQgaXMgcHJvZHVjZSBhIHJlcG9ydCBvZiBmaW5kaW5ncyB3 ZSBuZWVkIHRvIGZpeC9qdXN0aWZ5DQp3aXRob3V0IHRoZSBwcm9ibGVtIG9mIGhhdmluZyBleHRl cm5hbCBmaWxlcyBpbiB0aGUgcmVwb3J0ICh0aGF0IGNhbuKAmXQgYmUgdG91Y2hlZCkuDQoNClNv IEkgZ2V0IHlvdXIgcG9pbnQgdGhhdCBhIGxpc3Qgb2YgZmlsZXMgd2l0aG91dCBvdGhlciBkYXRh IGlzIG5vdCByZWFsbHkgdXNlZnVsLCBidXQgaXQgZW5hYmxlcyB0aGUgY29tbXVuaXR5IG1lbWJl ciB0byBzaGFyZQ0KdGhlIGJ1cmRlbiBvZiBmaW5kaW5nIHRoZSBoaXN0b3J5IG9mIGl0LCBjdXJy ZW50bHkgd2Uga25vdyB3aGljaCBmaWxlcyBhcmUgZXh0ZXJuYWwgKG1vc3Qgb2YgdGhlIHRpbWVz IGJ5IGV4cGVyaWVuY2Ugb3IganVzdCBieSBsb29raW5nDQppbnRvIGl0cyBjb2Rlc3R5bGUpLCB3 ZSBsaXN0IHRoZW0gYW5kIGZyb20gdGltZSB0byB0aW1lIGNvbW11bml0eSBtZW1iZXJzIGNhbiBw aWNrIG9uZSBlbnRyeSBhbmQgZG8gc29tZSBhcmNoZW9sb2d5IG9uIGl0DQp0byByZWNvbnN0cnVj dCBpdHMgb3JpZ2luLg0KV2UgbWlnaHQgZW5kIHVwIGV2ZW50dWFsbHkgdG8gcmVjb2duaXNlIHRo YXQgZm9yIGEgcGFydGljdWxhciBmaWxlIHdlIGNvdWxkIGp1c3QgbWFrZSBkaXJlY3QgbW9kaWZp Y2F0aW9ucw0KYmVjYXVzZSBpdCBjYW7igJl0IGJlIGFueW1vcmUgc3ViamVjdCB0byBiYWNrIHBv cnRzIChvcmlnaW4gZGl2ZXJnZWQgdG9vIG11Y2ggbWF5YmUsIGJ1dCBJ4oCZbSBvcGVuIHRvIHN1 Z2dlc3Rpb25zIGFib3V0IHRoaXMgY2FzZSkuDQoNCk15IHBlcnNvbmFsIG9waW5pb24gaXMgdGhh dCB3ZSBjYW7igJl0IGdpdmUgdGhlIGJ1cmRlbiBvZiBkb2luZyB0aGF0IGZyb20gQSB0byBaIGZv ciBldmVyeSBlbnRyeSB0byB0aGUgY29udHJpYnV0b3JzLCBpdCB3aWxsIHJlc3VsdHMgb24NCm5v dCBoYXZpbmcgYW55dGhpbmcgYXQgYWxsLCB0aGUgY29tbXVuaXR5IHNob3VsZCBzcHJlYWQgdGhl IGJ1cmRlbiBpbiB0aGVzZSBzaXR1YXRpb25zLCBpdOKAmXMgbm90IGxpa2UgYSBmZWF0dXJlIHRo YXQgaW50cm9kdWNlcyBpc3N1ZXMNCmluIFhlbiBhbmQgdGhlIHBlcnNvbiBzaG91bGQgbWFrZSBp dCBjb21wbGV0ZSBmcm9tIHRoZSBiZWdpbm5pbmcsIGl04oCZcyBkb2N1bWVudGF0aW9uIHRoYXQg Y2FuIGJlIHByb2R1Y2VkIGR1cmluZyB0aW1lIGFuZCBjb250cmlidXRpb25zDQphcmUgd2VsY29t ZS4NCg0KPiANCj4+IFRoaXMgaXMgbXkgZmlyc3QgdGhvdWdoIGZvciB0aGUgZmllbGRzLCBsZXQg bWUga25vdyB5b3VyczoNCj4+IA0KPj4gZG9jcy9taXNyYS9leHRlcm5hbC1maWxlcy5qc29uOg0K Pj4gew0KPj4gInZlcnNpb24iOiAiMS4w4oCdLA0KPj4gImNvbnRlbnQiOiBbDQo+PiAgIHsNCj4+ ICAgICAicGF0aCI6ICJyZWxhdGl2ZS9wYXRoL2Zyb20veGVuL+KAnCwNCj4+ICAgICAiYmFja3Bv cnQiOiBUcnVlL0ZhbHNlLA0KPj4gICAgICJvcmlnaW5fcHJvamVjdCI6ICJVUkwgdG8gb3JpZ2lu IHByb2plY3QiLA0KPj4gICAgICJvcmlnaW5fcGF0aCI6ICJyZWxhdGl2ZSBwYXRoIGluIHRoZSBv cmlnaW5hbCBwcm9qZWN0IiwNCj4+ICAgICAib3JpZ2luX3JldmlzaW9uIjogInJldmlzaW9uIGlu IG9yaWdpbmFsIHByb2plY3TigJ0NCj4+ICAgfQ0KPj4gXQ0KPj4gfQ0KPj4gDQo+PiANCj4+IE1h eWJlLCBkb2N1bWVudGF0aW9uIGZvciB0aGlzIGZpbGUgYW5kIHRoZSBmaWVsZHMgY2FuIHJlc2lk ZSBpbiBkb2NzL21pc3JhL2V4dGVybmFsLWZpbGVzLnJzdC4NCj4gDQo+IENvdWxkbid0IGRvY3Vt ZW50YXRpb24gb2YgdGhlIGZpZWxkcyBsaXZlIGF0IHRoZSB0b3Agb2YgdGhlIGZpbGUgaXRzZWxm Pw0KDQpVbmZvcnR1bmF0ZWx5IG5vdCwgSlNPTiBpcyBhIGJpdCBzdHJpY3QgYWJvdXQgdGhhdC4N Cg0KPiANCj4+IEhlcmUgZm9sbG93cyB0aGUgZXhwbGFuYXRpb24gZm9yIHRoZSBmaWVsZHM6DQo+ PiANCj4+IHBhdGg6IGlzIGEgcmVsYXRpdmUgcGF0aCBmcm9tIHRoZSB4ZW4gYmFzZSBmb2xkZXIs IGl0IGNhbiByZWZlciB0byBhIGZpbGUgb3IgaXQgY2FuIGJlIGEgcGF0aCB0byBhbiBlbnRpcmUg Zm9sZGVyDQo+PiAgICAgICAgIChUYWtpbmcgYXMgZXhhbXBsZSBsaWJmZHQpDQo+PiANCj4+IGJh Y2twb3J0OiBpdOKAmXMgYSBib29sZWFuIGZsYWcgdGhhdCBzYXlzIGlmIHRoZSBmaWxlIGlzIHN1 YmplY3QgdG8gYmFja3BvcnQsIHNvIGV2ZXJ5IGZpbGUgd2hlcmUgdGhpcyBmaWVsZCBpcyB0cnVl DQo+PiAgICAgICAgICAgICAgICB3b27igJl0IGJlIGluY2x1ZGVkIGluIHRoZSBhbmFseXNpcy4g QSBmaWxlIGlzIHN1YmplY3QgdG8gYmFja3BvcnQgd2hlbiBpdOKAmXMgZXh0ZXJuYWwgYW5kIGl0 IGRvZXNu4oCZdA0KPj4gICAgICAgICAgICAgICAgYWNjZXB0IGRpcmVjdCBjaGFuZ2VzIChjaGFu Z2VzIG5lZWRzIHRvIGJlIG1hZGUgaW4gdGhlIG9yaWdpbmFsIHByb2plY3QgYW5kIHRoZW4gYmFj a3BvcnRlZA0KPj4gICAgICAgICAgICAgICAgdG8gWGVuKQ0KPj4gDQo+PiBvcmlnaW5fcHJvamVj dDogdXJsIG9mIHRoZSByZXBvc2l0b3J5IHdoZXJlIHRoaXMgZmlsZSB3YXMgb3JpZ2luYXRlZA0K PiANCj4gUGVyc29uYWxseSBJJ2QgZHJvcCAidXJsIG9mIiAtIHRoZSBzcGVjaWZpY2F0aW9uIG9m IHRoZSBvcmlnaW4gbmVlZHMgdG8gYmUNCj4gcHJlY2lzZSwgYnV0IEknbSBub3QgY29udmluY2Vk IGl0IGFic29sdXRlbHkgbmVlZHMgdG8gY29tZSBpbiB0aGUgZm9ybSBvZg0KPiBhIFVSTC4gV2hh dCB3b3VsZCBpbW8gYmUgbW9yZSBpbXBvcnRhbnQgdG8gbWFuZGF0ZSBpcyB0aGF0IHRoZSByZWZl cmVuY2UNCj4gYmUgdG8gdGhlICJjYW5vbmljYWwiIGNvcHkgb2YgdGhlIHByb2plY3QsIG5vdCBl LmcuIHNvbWUgZ2l0aHViIGNsb25lLg0KDQpTdXJlLCBjb3VsZCB5b3UgZXhwbGFpbiBpdCBhIGJp dCBtb3JlLCBtYXliZSB3aXRoIGFuIGV4YW1wbGU/DQoNCj4gDQo+PiBvcmlnaW5fcGF0aDogcmVs YXRpdmUgcGF0aCBpbiB0aGUgb3JpZ2luYWwgcHJvamVjdCwgbW9zdGx5IGxpbmtlZCB0byB0aGUg b3JpZ2luYWxfcmV2aXNpb24gZmllbGQNCj4+IA0KPj4gb3JpZ2luX3JldmlzaW9uOiByZXZpc2lv biBvZiB0aGUgY2hhbmdlcyBpbiB0aGUgcmVwb3NpdG9yeSB3aGVuIHRoaXMgZmlsZSB3YXMgdGFr ZW4uDQo+IA0KPiBJIGd1ZXNzIHRoaXMgbmVlZHMgY2xhcmlmeWluZzogV2hhdCByZXZpc2lvbiBp cyBtZWFudCBoZXJlPyBUaGUgb25lIG9yaWdpbmFsbHkNCj4gaW1wb3J0ZWQsIHRoZSBvbmUgbGFz dCB1cGRhdGVkIGZyb20sIG9yIHlldCBzb21ldGhpbmcgZWxzZT8gS2VlcCBpbiBtaW5kIHRoYXQN Cj4gd2UgbWF5IGFsc28gYmUgc2VsZWN0aXZlbHkgaW1wb3J0aW5nIGNoYW5nZXMsIGluIHdoaWNo IGNhc2UgYW55IHBhcnRpY3VsYXINCj4gInJldmlzaW9uIiBjYW4gZWFzaWx5IGVuZCB1cCBtaXNs ZWFkaW5nLiBUaGUgZm9ybWF0IGxpa2VseSBhbHNvIHdhbnRzDQo+IHNwZWNpZnlpbmcsIGUuZy4g KGxpa2Ugd2UgZG8gZm9yIEZpeGVzOiB0YWdzKSB0aGUgZmlyc3QgMTIgZGlnaXRzIG9mIGEgY29t bWl0DQo+IGhhc2guIEZvciBzYWlkIHNlbGVjdGl2ZSB1cGRhdGluZyB0aGlzIG1pZ2h0IHRoZW4g YWxsb3cgZm9yIHNvbWV0aGluZyBsaWtlDQo+IDxiYXNlLWhhc2g+KzxjaGVycnktcGljaz4rLi4u DQoNClRoaXMgaXMgYSBnb29kIHBvaW50LCB3aGF0IHdvdWxkIGl0IGJlIHRoZSBiZXN0IGZvcm1h dCBpbiB5b3VyIG9waW5pb24/DQpNYXliZSB3ZSBzaG91bGQgaGF2ZSB0aGUgZmllbGQgYXMgYW4g YXJyYXkgb2YgcmV2aXNpb25zPw0KDQoib3JpZ2luX3JldmlzaW9uIjogWw0KICAgIlJldmlzaW9u IG9mIGxhdGVzdCBiYWNrcG9ydOKAnSwNCiAgIFsuLi5dDQogICAib3JpZ2luYWxseSBpbXBvcnRl ZCByZXZpc2lvbuKAnSwNCl0NCg0KV2hhdCBzaG91bGQgYmUgdGhlIGJlc3QgdG8gY2FwdHVyZSB0 aGUgaGlzdG9yeSBvZiB0aGUgZmlsZT8NCg0KDQo+IA0KPiBKYW4NCg0KPiBPbiA2IEZlYiAyMDIz LCBhdCAwOTo0OSwgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+ IE9uIDAzLjAyLjIwMjMgMjA6NTUsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+IE9uIEZy aSwgMyBGZWIgMjAyMywgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+PiBBbmQgdGhlbiwgaWYgdGhl IGZpbGUgaXMgbm90IHN1YmplY3QgdG8gYmFja3BvcnQgYW5kIG5vdyB3ZSDigJxvd27igJ0gdGhl IGZpbGUsIHRoZXJlIGlzIG5vIG1vcmUgdGhlIG5lZWQgdG8gbGlzdCBpdA0KPj4+IGluIHRoZSBl eHRlcm5hbCBmaWxlLCBhIGNvbW1pdCBzZWFyY2ggY2FuIHJldmVhbCB3aGVuIGl0IHdhcyBjb252 ZXJ0ZWQgdG8gWGVuIGNvZGVzdHlsZSBhbmQgcmVtb3ZlZCBmcm9tDQo+Pj4gdGhlIGV4dGVybmFs IGZpbGUgbGlzdCBzbyB3ZSBkb27igJl0IGxvc2UgdGhlIGhpc3RvcnkuDQo+PiANCj4+IFllcywg SSBhZ3JlZS4gSWYgYSBmaWxlIGlzIGNvdmVydGVkIHRvIFhlbiBjb2Rpbmcgc3R5bGUgYW5kIGZv bGxvd3MNCj4+IE1JU1JBIHJ1bGVzLCB0aGVuIHRoZXJlIGlzIG5vIG5lZWQgdG8gbGlzdCB0aGUg ZmlsZSBpbg0KPj4gZG9jcy9taXNyYS9leHRlcm5hbC1maWxlcy5qc29uLg0KPj4gDQo+PiANCj4+ PiBTbyB3ZSB3b3VsZCBlbmQgdXAgZXhjbHVkaW5nIGp1c3QgYWxsIHRoZSBmaWxlIGxpc3RlZCBp biBleHRlcm5hbC1maWxlLmpzb24gYnkgdGhlIGFuYWx5c2lzLg0KPj4gDQo+PiBSaWdodCwgSSB0 aGluayBzbyB0b28NCj4gDQo+IFBlcnNvbmFsbHkgSSB0aGluayB0aGlzIGlzIHRvbyBmb2N1c2Vk IG9uIE1pc3JhLiBUaGVyZSBhcmUgb3RoZXIgdXNlcyBvZg0KPiBzdWNoIGRhdGEsIGxpa2UgYXV0 b21hdGljYWxseSBpZGVudGlmeWluZyBjaGFuZ2VzIHRvIHRoZSBvcmlnaW4gZmlsZShzKQ0KPiB3 aGljaCB3ZSBvdWdodCB0byBiZSBwdWxsaW5nIGluIChyZWNhbGwgdGhhdCB3ZSd2ZSBiZWVuIGRv aW5nIGEgcHJldHR5DQo+IGJhZCBqb2IgaW4gdGhpcyByZWdhcmQpLg0KDQpZZXMsIHdlIGNvdWxk IGZpbmQgYSBwbGFjZSBvdXRzaWRlIHRoZSAvbWlzcmEvIGZvbGRlcg0KDQo+IA0KPiBKYW4NCg0K DQoNCg0K From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:31:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:31:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490332.758963 (Exim 4.92) (envelope-from ) id 1pP0eh-0002Hr-1b; Mon, 06 Feb 2023 12:31:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490332.758963; Mon, 06 Feb 2023 12:31:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0eg-0002Hk-Uz; Mon, 06 Feb 2023 12:31:30 +0000 Received: by outflank-mailman (input) for mailman id 490332; Mon, 06 Feb 2023 12:31:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0ef-0002He-Gr for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:31:29 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0621.outbound.protection.outlook.com [2a01:111:f400:fe1f::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c5ff440-a61a-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 13:31:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8553.eurprd04.prod.outlook.com (2603:10a6:20b:434::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:31:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 12:31:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c5ff440-a61a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V8NayQFp5KFcDVU8DDhsazdfj1truTFvURGmoO1s7XzVuTZUrGS3Edq4Qf0Hq0+ztPtOBet8U7k187fH8drp1cSyivs7UIszpdIt0BtiDEiHav2GDka3wKFEptJnp3HY2WVQuV4pmqMmB+V0+r0avsHyS/WXIlcoSOcFS4GOISSlzD969xZas5oR0pLtlSMAsR20VNcM0xyim1tr69ScOQ8k+7OrQ51vij/Z24VPfbYsKXzRDfj7oske0+wcO2M0q87LDK7B4dxqET98VM6PDQTgwR4RBrbS+8x1k7LpKMDIgp5Bju6INYY2/Mi62p+vqrj4qHJa2Yd+hImk5usIOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ut/YifaKxztSMJt+03Xs/uH6xYHPVthbAnNTIuGGt2Q=; b=mFr1sWS55kwe6+Bvokn4xGsSlPDoTHRkrtEEWDp5ZkhdPyy72qWr5/OeCWbcTDd7yvhvIO4W+jDRuXtH0Ohlc2vs1+aHRura9wV9AwsYd/OOndeET2Olxgw+PL+Be3QoRQRMCVbyVUcGQy3/gY+vUuSpS190hfXxmwEth8PEISOSWhjphB/MYdWIG+U7gWw1OdjRfsL3DFoUiq38sT+lyHGP1NwXFRrgzMISx0vdqefZoDYB59gFPqaYZ4nSCBowApQbGZKQTozg0jW8r+n1yeRhzzzO6+eIBTAwbOF5Sh/w/8LjNDiPI0271VfV6ylXkWuYOyIMLuwKTa9co0uuVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ut/YifaKxztSMJt+03Xs/uH6xYHPVthbAnNTIuGGt2Q=; b=Q49gu4dpEHKdLlfW41K27GD3ipUSVXXJADDEjBX6VhsA+EIifgLn0TWRLIE7bFnkmsXBpCLLUIV0b9TBWTYMMlRjz5p7Tmd5nZS8wPgVpoRGkbCogm9KwyK+NnSSmxEM8SABHBZiaJ29sK7skDgm74rud0MNsp+VuuEGc7FsSQlLMrRQD3mqKPo0garhCZQ5FG2NyKRtTjJkgX3mYqaLpwtO9KrJ6RE+DK9H6wbaIQcldeFz2r5+Ui7r2fvDjHZG9oB7e2wj6Q/Nev89Z+SbC/EbdlahP+5Z15LXh41uoEgMcztYTWW8ctD/h8TX9q/5HEE00wUWucvxdEJJ+ZuI5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <74fb4738-b5bd-ddbe-e376-eeabc84a28be@suse.com> Date: Mon, 6 Feb 2023 13:31:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/time: use public interface TSC mode definitions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8553:EE_ X-MS-Office365-Filtering-Correlation-Id: 4135fffc-5556-49a3-4515-08db083e0f8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tqa3YyYJBo8GhLKfrDI6uQMJvOPVNT2IGsSOsotFzIklO4hLBSxv91Z8THMAVFXPq3LJY4iHC1DvrsWPmxp+/uU2W4dmVuNXo9+qUGA8ibAvxZGLYItH7R/CSb/jFrO9MRjraTT/glXcW8JdSH+UV/S52rnUD0JCfIrQWZ2E8fDWFG0X/+lODGRa0AFFXqi0ylNO3o0t0TVwkB1wmLvNXDp9g8KVk+UZlTkbt1+GI7pCyn/0XmajZFXFk63erJG43SZs3vPDRosHu4Yd1aPAxv3wIMENoa+0AjvU00X4QXg6AyO487IN2/4OFyPQw7CvwnP5+N1x9FoxDnVr07B7UTPkaWmjWyaehflJER81nKFIB+eMqI1pEXl58ZEgNGK97/DNEI67vtH/H2NWAeisro4V5xVKquZ6v1kftUpfDnFLC6okrQvj5ry9wcOB/46SzE8AIJRnV+pGpNBexIQScNYemlEcQd72u1VKxioHS9sGZ1qM20wuAe6tuSw+ubwMaIVYp7lk6A8ZKfi9QmAjY0mox/xgWRfxFxvoHcQNGW9CvczS3jlu5T/QFNxrGQMqkMTJaYhSyPniOpAL0JX/S8dRpQ89h2lnBObmbunWCPDpmaOT2jVd9rIfahJdHlZSo9Jm1hD5OzzS5tbQYqcfXAFKlnX9Fk3hravDl4CWPqE4JcFc4GPnOIPMnsPgGHmrLVfsRleCiMQ15T1ylrZnwlpIJFJVHRJcvDhPw72b+vg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199018)(31686004)(83380400001)(36756003)(31696002)(86362001)(66476007)(66556008)(6916009)(38100700002)(66946007)(4326008)(8676002)(2616005)(6512007)(6486002)(6506007)(478600001)(186003)(26005)(54906003)(8936002)(316002)(5660300002)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHBmamNrV3ZVdWlFNXlKVmIrcnVtZ01CQlFoOXM3ck1Sd0dFWWhteDhvN3lR?= =?utf-8?B?b0Rra2Zrei9yWHFwaUNiUEpGVHc4TzNoam03aS8zam44ZzlWeVBmemg2WXdM?= =?utf-8?B?MTJuVFd6MWE3eEJkNmVhVDBqNlozYzJlTGkrdFFTeTg1WkRCaFZpdE9NZ0hr?= =?utf-8?B?bm9rOWZwdXFtQU9xTFE0eHdqMkVMSnpsVlk5RnNqSVVKaDgzaTJmczlGSnRQ?= =?utf-8?B?Q0IxZVh4S0tUNGZSdXJXdmFibWRKemE3N1gwNU9Bck9EUjk5a0plWG5xVi92?= =?utf-8?B?SHFKUm9PSDROaG4wUVlDbTZySmRsdUpaNTlMa1EyUTFoNW13K2VPL3RHalhZ?= =?utf-8?B?ZnJ5NS81VklEWDN3STF3am9ObEpYM2p4VVVGUTJZSzdzVGxXbmc0eVFtd3VL?= =?utf-8?B?WGJzSXQzdVZiTlhZcHVtbGdRVGROamhONDNQd05qS3ZYSWJVbnA1QzJPbGEz?= =?utf-8?B?aUxZMkptMGhsamRjVTU5SmI3TXNxRW0rS1dsbkZENStVbnU1dUx4RTUzZUVB?= =?utf-8?B?NUg4T2tmYjRIM1ByemI4R3VUSnFHZ3NzUjJwdnFBcVJQclRzdTNqQmV5TmFv?= =?utf-8?B?Z1pFMEREdVZtanpmeGdHMDRIdzlsbktVSkhFQnZIY1hzV0lDd3R4SHRSbVRp?= =?utf-8?B?cEhBdlQxNzFVZURJanorNVRJd2JTYlBUZFFNRlRQd1VJZnBpdEl0bXJ0VCt5?= =?utf-8?B?ckhlYVE2RkRqODNPL0hrRURtVFcwTWxMdnc4c0VMeFFrbEljc2R5VWIwcHJz?= =?utf-8?B?amRLNVpyR2ZSdGVMaEw2M00xNS9XZlVTLzY0RnpvR25oMGJnMHNZdmNYMmlR?= =?utf-8?B?Zzl0QlJGazZhZ0ZueVFPNlBIMHBtamVXSFI5MCt6S2ZaQlZnV1AvMHc5U0lr?= =?utf-8?B?RURGTVVIdkUxWWtIdG1JeUdqdXZyU2Y5UXVCWTg5d0RYV0hrUEFoOTB1ODVk?= =?utf-8?B?ak9Yek40RFJGMUhMRkRDd0N6dWNtU3VEQ0xVbFU2eXlwSWlnN0ZEamF1ZVR4?= =?utf-8?B?MlZTcjU2T0RhQ1dtUk5qcHdzZ1NJS0RhS0ZLNHorZXNVanE3dElaRzdENFps?= =?utf-8?B?VGdYSGZEelM4MS82UWhiRkFYOXdGcmx6Yk1qbGhSSDRCTmVROXdOQkcxWElq?= =?utf-8?B?d3Y5T09hNTMwejRqeFN0U01uYVJRRmp2U2RGaThuRHdncEM3VFRZTHJnd0o4?= =?utf-8?B?UkZGVytpQ3dRdzQzb1ZGN3hpa1MzaWZaWGk0TEg2OTVlUnlCbzVSeFFVR1ZB?= =?utf-8?B?ZkRkMG96VXA5LzgrOGlmKzNXN3BvTWpGRlRzQzF3V3RibWZxeG52K3hOTUIy?= =?utf-8?B?TDR3Q3A1aHNPL2lZUG8rNXdmcGxhbjVxTHZIMmE1emhTTnBWTUN4TWxDQnVU?= =?utf-8?B?ZXlzN3Y2aURtK2t1T0lmSW9zb3cwbHloOUhIZHV2K3BIZVJsUWIvVFJJKy9I?= =?utf-8?B?MFNaam9TdVBpQ2p2SUhCUmQxeWV2b3RuZVVHNElPL2V1dW9KSHVxeVh0ekkx?= =?utf-8?B?OHZtSzV6citkRVd1L2huWDRVMnhQWUl1VTJ1ZlE0ZGY3MEpTU25jOE9VcHhw?= =?utf-8?B?aUNMZGczRW5Ed1lLY0xEekYzWGtUSGpxZFR3NnAydHlCcHhDSmcxZzBxZFly?= =?utf-8?B?dWxnYzkycnhmYXA4a2dudmJpQ3RKYmt4MjJHY2dZcmw0ZTBxS2FQT3J6Sjg3?= =?utf-8?B?WG91SzVMcFliZ2hqWUswek1XQkVrWjRralYyN21TcnpzeDJOa2lxNTJNSTZm?= =?utf-8?B?VkM5bCt2M3ZpVUg2bW5tYlM2QjJFN0kxdUdIWnBXRFlJUUF1QS9zUE5rYTNR?= =?utf-8?B?bU5aWmZQQ1JhVGFJUHRLMDlmRzVxVnhWaUtnU2FBUW9oNlgyNUwyWXBVRk5S?= =?utf-8?B?RDhqZDFQNUhyY0xOUmt2QXEvbHR2cDRhanZYTVNjcFQ5aWJFbEVVMWI3UGlM?= =?utf-8?B?WWlKTE5qbXorL21JNFNudUMvODZMN3hXT1FyME5ka2wzdU9SdG9weXdMKzgw?= =?utf-8?B?dXc0VnZybFU4dTZBL0pJOUsvbWJJSU1QTmt1SFZ4NDdMNHFYc0x5eFhoMDFH?= =?utf-8?B?dUtjZ0oyVCsyVHVvM2NCM0Z0dlV3MDUxL0g2bk5RRGpURjdpK1BReFozdkd4?= =?utf-8?Q?est0n1pFpMDLMK8sDfJdLw07T?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4135fffc-5556-49a3-4515-08db083e0f8d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:31:24.6374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xCfIfeZMVgLXdbP3QwiHziisTcrbogwaMiApEvh2LdDgIEbDbw8kYLNUWz75eWJHox4WWEr8vKuIcR5110/bcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8553 Now that they're properly represented in the public interface, let's do away with our private #define-s. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -36,6 +36,7 @@ #include #include #include +#include #include #include #include @@ -844,7 +845,7 @@ int arch_domain_create(struct domain *d, else ASSERT_UNREACHABLE(); /* Not HVM and not PV? */ - if ( (rc = tsc_set_info(d, TSC_MODE_DEFAULT, 0, 0, 0)) != 0 ) + if ( (rc = tsc_set_info(d, XEN_CPUID_TSC_MODE_DEFAULT, 0, 0, 0)) != 0 ) { ASSERT_UNREACHABLE(); goto fail; --- a/xen/arch/x86/include/asm/time.h +++ b/xen/arch/x86/include/asm/time.h @@ -4,20 +4,6 @@ #include -/* - * PV TSC emulation modes: - * 0 = guest rdtsc/p executed natively when monotonicity can be guaranteed - * and emulated otherwise (with frequency scaled if necessary) - * 1 = guest rdtsc/p always emulated at 1GHz (kernel and user) - * 2 = guest rdtsc always executed natively (no monotonicity/frequency - * guarantees); guest rdtscp emulated at native frequency if - * unsupported by h/w, else executed natively - * 3 = Removed, was PVRDTSCP. - */ -#define TSC_MODE_DEFAULT 0 -#define TSC_MODE_ALWAYS_EMULATE 1 -#define TSC_MODE_NEVER_EMULATE 2 - typedef u64 cycles_t; extern bool disable_tsc_sync; --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -2545,13 +2545,13 @@ void tsc_get_info(struct domain *d, uint { uint64_t tsc; - case TSC_MODE_NEVER_EMULATE: + case XEN_CPUID_TSC_MODE_NEVER_EMULATE: *elapsed_nsec = *gtsc_khz = 0; break; - case TSC_MODE_DEFAULT: + case XEN_CPUID_TSC_MODE_DEFAULT: if ( d->arch.vtsc ) { - case TSC_MODE_ALWAYS_EMULATE: + case XEN_CPUID_TSC_MODE_ALWAYS_EMULATE: *elapsed_nsec = get_s_time() - d->arch.vtsc_offset; *gtsc_khz = d->arch.tsc_khz; break; @@ -2588,8 +2588,8 @@ int tsc_set_info(struct domain *d, switch ( tsc_mode ) { - case TSC_MODE_DEFAULT: - case TSC_MODE_ALWAYS_EMULATE: + case XEN_CPUID_TSC_MODE_DEFAULT: + case XEN_CPUID_TSC_MODE_ALWAYS_EMULATE: d->arch.vtsc_offset = get_s_time() - elapsed_nsec; d->arch.tsc_khz = gtsc_khz ?: cpu_khz; set_time_scale(&d->arch.vtsc_to_ns, d->arch.tsc_khz * 1000UL); @@ -2601,12 +2601,12 @@ int tsc_set_info(struct domain *d, * When a guest is created, gtsc_khz is passed in as zero, making * d->arch.tsc_khz == cpu_khz. Thus no need to check incarnation. */ - if ( tsc_mode == TSC_MODE_DEFAULT && host_tsc_is_safe() && + if ( tsc_mode == XEN_CPUID_TSC_MODE_DEFAULT && host_tsc_is_safe() && (d->arch.tsc_khz == cpu_khz || (is_hvm_domain(d) && hvm_get_tsc_scaling_ratio(d->arch.tsc_khz))) ) { - case TSC_MODE_NEVER_EMULATE: + case XEN_CPUID_TSC_MODE_NEVER_EMULATE: d->arch.vtsc = 0; break; } @@ -2674,7 +2674,8 @@ static void cf_check dump_softtsc(unsign for_each_domain ( d ) { - if ( is_hardware_domain(d) && d->arch.tsc_mode == TSC_MODE_DEFAULT ) + if ( is_hardware_domain(d) && + d->arch.tsc_mode == XEN_CPUID_TSC_MODE_DEFAULT ) continue; printk("dom%u%s: mode=%d",d->domain_id, is_hvm_domain(d) ? "(hvm)" : "", d->arch.tsc_mode); From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:33:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:33:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490338.758975 (Exim 4.92) (envelope-from ) id 1pP0gI-0002pX-Dd; Mon, 06 Feb 2023 12:33:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490338.758975; Mon, 06 Feb 2023 12:33:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0gI-0002pQ-9w; Mon, 06 Feb 2023 12:33:10 +0000 Received: by outflank-mailman (input) for mailman id 490338; Mon, 06 Feb 2023 12:33:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0gH-0002pJ-71 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:33:09 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe1f::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68e486ca-a61a-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:33:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8553.eurprd04.prod.outlook.com (2603:10a6:20b:434::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:33:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 12:33:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68e486ca-a61a-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kcQMDsDnmrSfdgfyUTSuIsHtEwCA67lrFIdXdlY6kig1mJs6MiJiic32n73xthee0i5y+o9ZQQx70Nc3hNAs09kSyTEbcJb586tIWp0hP3aO+GbXd9QudkhmvTSfQ3qi+L5XQLtKvj9TuEALfgparPy748bc/JGvFfVAIYor7dy92k5ud1ohLmqZDRzM8+lkk06wTdVTZiuj978RSo+rpjnxECFbn4BlZrwnTwhVeX2/XVV1XxoSaIMDsfTuzBsdAI1AOEtdBBPESFJFgqbDliYk1+Bd2ewivOj6J8GiBZIuQQzeJEZgAm32j05HaK0VPip7oivQoVsb0LKFeXJ7RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcab7qzlesiQNGAJRREkouTYMLM7Xss9ex40gU9Vk7U=; b=P7V3U5Gee6gC9VHwiCE8guq4yi4yADiuX22qZJr4FIxnWj7o6zVz5KmVwL5WabtHB8kli1e4l51UsyLafIA3mDhYgDfkh1ERj11UwgzO3XR8XSsBQMJXsbGQv7qMhzMclYVM8M1Hshh2J2nSs02nIdhU6aTniwHteNYhH4mHOPEPieyQkeAs3r665GP4HI7oaTeqHxzL0lJm3RHsHmw5uQK63qCw+H+xhXr/4CVbZ3ENjliYO53sNwisDdTyC2paOT7qMiF+oBzfZFe2oiK92aDKhSEGFq34E9seDMVE6uxawRTy34NvYGRjEUqHJq+wEbxs0dtsXgkVI73kcvqXyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcab7qzlesiQNGAJRREkouTYMLM7Xss9ex40gU9Vk7U=; b=T2+IsHx7Y2JbPwbT7xa3eJj69yNhure1jIJvzOHTT6o/wpwkWn6+XPTZ5tsqqmeyNlzwApeo20OWFZFq4WYJkojf0UIThD6kK06kehIb/57ahF4zZWsDDroQiRDbr9D7HROunrWxmbDtyQc293YQHMxM9iQFQRncV0727ydB6tstelD/Bsm76JyT8uC856cye2LTamBxatK78XSR9xU6tR8/cMMiwr/kcTV1FP3JY7SR9iDbEMjIHm0D/HEFerhgO4+4FgndO9WBmTyuJoOeTNnU7119jP6HUewsNDvLczi60WT8DyMf29RAmc/ZYqvL5GQ/3mwSnuQ+dTc47mThrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> Date: Mon, 6 Feb 2023 13:33:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross From: Jan Beulich Subject: [PATCH] libxl/x86: use public interface TSC mode definitions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8553:EE_ X-MS-Office365-Filtering-Correlation-Id: fd6bbd47-16c9-47a3-d8c1-08db083e4bf8 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bj2mD4F+Gna0HBWsz9ipiSpYSfd4hXEqPzJ8aXSQGMxLW5vWMY8h1KF06HUFbAjWl7GoSgpT2Wex8nYHHM3iDJQVOn4gxd6ot5QHQGbmntcciiQewSAO1U4VXWjZ3qkkmm07MFmm5YKCzlabf/BO+dcJCnh5UzxrMwEo8QUfMP76E4NK3FJunmHEhQpFxhERYD8XhJIQX/weZy1ZIn46mIY2VTfd13OUS05y3S78Cyomwf0AUawF/sWENGjA2EYIDfhF30/exKGSA3pZE5xDViC//fHtJSGFWMQQRZ196ifBrZK1WyyPBGJakR9S4HA9TaVT8a+0TOg2Awdxdf28r+uuJcEgy1k3AB9P2hKaI9HWVviLwKZGEiCUE9BPz8Hs7ROyoSbtveyOXUDHsfr0asxw9Kle4WDDCw+KG4WuRMJlja1CNMVJ5zxaXKXRP2qpKzj2iHhNNJ/S1qy/eHTUw9SkX184AtelAUSRVIEYTenRus9HT7IrfYWL0hP4c+EicCgLDPRa2alyv/m8HXueeN86oMcg+AkNvpjpB4ykrd83PM4SYycLiuGqeVOgHZnoVa1rqBsDN92fmIxW0QeO312bnQxsPlY1oqI0zCf76nTA9L6aBiGYRhfQ9lnhH4SRk8CXinT/WKAWkiYruXNe9k+bp8IsabJrUotgq8+AqxKqL9+sGx+6fGVUqNY/0EbxOGKv1fu2287TkhwUa+2UQQ1KiiyGgvGk4/r/Oz2eKDw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199018)(31686004)(36756003)(31696002)(86362001)(66476007)(66556008)(6916009)(38100700002)(66946007)(4326008)(8676002)(2616005)(6512007)(6486002)(6506007)(478600001)(107886003)(6666004)(186003)(26005)(54906003)(8936002)(316002)(5660300002)(41300700001)(4744005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkxSQ05SbE9xdHZoQ2FvMlJjUTN0M3h0WXIwRnFKYVBoUytYOERQV0hTdHh0?= =?utf-8?B?M2dQU1lLUXFudmxubTYvSUlHdzVsdXRVNGxlTEppQmljYlVDVWhrR016RG9X?= =?utf-8?B?SEZiUWxCR1ZsTm9jQ3F6eDdveTdiclBId2tuaVc3VFdKNTRjU05EeFM2NUly?= =?utf-8?B?OXRhZTRvMTBQd3MweEZ0bTFXNUN5KzBWSWNZQldWQkw0ZGpBSFVqdURJcFcz?= =?utf-8?B?cXRwT0RQcXBkM1ZHUjN0UXVQL2dIOTVNRmtTNlR0eUllZzFpdEdUNktnTWVF?= =?utf-8?B?d25nRkFGOTBvamg4K1I3Y0dJbUdVZm5VTU9aWkJuL3JhVDlQM0lGdkpNZkRi?= =?utf-8?B?YU1Yc0lJTDE1Y3I0cFRCdjVJWWFDSkRaT1NITjJYVG9NSVNkbWlLcEdWK3cr?= =?utf-8?B?aFB6aGFJL1NHWWxYMnA4bzNVa3hFRU8ybmlLVXNaUmpnNURKbkdBZERwZUd1?= =?utf-8?B?NUxpTk5FTXVFeHlFOGZiMGxOdTFmVnN6bnZsYnJFaXBmaFRkL3NMWU9QOVdm?= =?utf-8?B?TGlPQVRVcHppcHpreVRWSHRjcXBtMjZhYnZxM3hONkQxVkd3bEZOb0xXT1VK?= =?utf-8?B?YWE4Zk81dDVSMjNTQnpCN1JKUVh5RHdzR3ovOHNxb0pBMTVJRGlCMmJ1eGRM?= =?utf-8?B?U1lwMWNMQlFoazhVeTZxTFdTZmpDMHdJSzJOdmxXR3NtS3ZEOUtlSWNIVGla?= =?utf-8?B?VHJFNGZ2VkJEOUpDaWhQK3AvbVlJM2FTYlZBcC9TcGt1a21JQW1QOG52VnYz?= =?utf-8?B?UHl1QkRXUzlBSGgxQmhmVE9XQVRYNkdrVDI0Y0ZiLzc0aklrSlpRVXNUODJ5?= =?utf-8?B?eXh2TytFc0xiV1BJZVFhWW1jbS9KTW9ybXZXRThyUnBQaCtVVUVKQ1JPMThO?= =?utf-8?B?Sk1aUms5aDE1Tmkwa3RKOUF5UWVUQStJUk9LYW1zaWFITE1tN1YyVDdUUG5Y?= =?utf-8?B?T1UyNk1MSEJ4cG1tOUc4dWxPWGsrQ291R3VFSTFuSUQzbzhtYTFUdTh1UzJa?= =?utf-8?B?Q3JvanB1ZnpDVVQ5N052YnlYL09BOTlYc1lNVWNQSGI0L2lGQzB4NGFTZXBq?= =?utf-8?B?MWNPZ2ExZnR5ZXNvd245MzhaaGpCVERLdllEMGszN0pXOFFhWEUrZGtCZ2Uz?= =?utf-8?B?Y1ZyMTcxeUZ5bzI1bEhCdEE4QlNJMEtnaVZhMU9GaUdKVS9IbnJ5bjVJV1Jj?= =?utf-8?B?SGxZYWY5UXh4d1JjVlQrby92d1gyV003bHY0eUhQLytQZmtMSktBZVEybVlR?= =?utf-8?B?Ymo4TS8ycTdYWEdsVityUWRLVHltL1ErWm1oN2hCRitUYkQ0WUJlR2d2Sm5t?= =?utf-8?B?VVZGUG52R0hzc0ZsTU5oRHliWE83V3d5bUZhZ1BiQ1N1ejNGWnNaUmdOeC9r?= =?utf-8?B?N1pYZTRRa2VRWFA5c285cCtMQVBwYXpDRjZMTi9NQXFHaGNPNFVMb1N6Smhq?= =?utf-8?B?T1pRU1IrT1lzTElVRmxvcEh0WXJ4ZTR2OG44OU1NRUpRKzB6QVJoN093ZXMz?= =?utf-8?B?cC9QS1FSU3g2ZTA2aW11QTBvSkxXcVVNY1AybHpTdDcyMzlaYkhIVGlpOG9T?= =?utf-8?B?ZXlXTkw4SXBDTnBSbUhWU2cyd1RnWnBtRGc5alpoSElIVU5USmFLYTlQTUlJ?= =?utf-8?B?Z0ZoekJ4NksvV3E5NkgzOEdmTnAwU1pDOHFWendYR2dRaWswZHZxSEpZVEhB?= =?utf-8?B?RGxRdjRHQXVOV3dxUlllYWtSTTljOHpzK3IyeGlkMU52eDBTT29TTjFpdXJr?= =?utf-8?B?U2FBZmhCNDVlSWJ4dWVoa1JqVXRiMHI1Q2NBc3FDeVBNRkdIUzY0aWtVNXdT?= =?utf-8?B?NmsyRVFEcTR2enYzVXh6eXRGR09qT2JuaHVxSGNDQVZSWFdncjVlMktONUI3?= =?utf-8?B?ZFh4blNyZFlORkg0QlhNTlc1TjZaUkpIQ3JoOFZ3eVk2bDJrTXVYL1doeGZE?= =?utf-8?B?dFdhSUM1WUlYWTBMR0M1bzhVYjVEeHFYK1ByTjlxL0F3WFlYQnFwdlhSclda?= =?utf-8?B?OGxSRUNmd1BrUUdQT3VpQXlMNTMrTmQ1R2J5RkMyOXdnOThpeEtiK243a2lt?= =?utf-8?B?WXBJdU95amdjc0J1aXloMFRlSWNaNVFmV29mTUlwd3B6ZmlYeUhPc3BrUGdp?= =?utf-8?Q?nq2TcyeM5P8dwQVRi91jfgZ8i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd6bbd47-16c9-47a3-d8c1-08db083e4bf8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:33:06.0526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aGa9y7+H5RG4/RW1xXasMOx7IQGEh1lxFDzvLSaI/WjZ1mc2d9l5luG6ENJ65NZ2yhvQDCBBuotGbHj8OzlWpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8553 Now that they're properly represented in the public interface, stop using literal numbers. No functional change intended. Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -1,5 +1,6 @@ #include "libxl_internal.h" #include "libxl_arch.h" +#include int libxl__arch_domain_prepare_config(libxl__gc *gc, libxl_domain_config *d_config, @@ -486,13 +487,13 @@ int libxl__arch_domain_create(libxl__gc switch (d_config->b_info.tsc_mode) { case LIBXL_TSC_MODE_DEFAULT: - tsc_mode = 0; + tsc_mode = XEN_CPUID_TSC_MODE_DEFAULT; break; case LIBXL_TSC_MODE_ALWAYS_EMULATE: - tsc_mode = 1; + tsc_mode = XEN_CPUID_TSC_MODE_ALWAYS_EMULATE; break; case LIBXL_TSC_MODE_NATIVE: - tsc_mode = 2; + tsc_mode = XEN_CPUID_TSC_MODE_NEVER_EMULATE; break; case LIBXL_TSC_MODE_NATIVE_PARAVIRT: LOGD(ERROR, domid, "TSC Mode native_paravirt (a.k.a PVRDTSCP) has been removed"); From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:39:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:39:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490345.758985 (Exim 4.92) (envelope-from ) id 1pP0ll-0003ZX-1u; Mon, 06 Feb 2023 12:38:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490345.758985; Mon, 06 Feb 2023 12:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0lk-0003ZQ-VJ; Mon, 06 Feb 2023 12:38:48 +0000 Received: by outflank-mailman (input) for mailman id 490345; Mon, 06 Feb 2023 12:38:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0lj-0003ZK-Nf for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:38:47 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2047.outbound.protection.outlook.com [40.107.7.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32cb20b3-a61b-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:38:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6776.eurprd04.prod.outlook.com (2603:10a6:20b:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:38:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 12:38:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32cb20b3-a61b-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nktsbzNQVZjYE5F5xYLhc7sdcN/OEgu0xBJaXb+Fh2A7W06FpI9NNpaphYuBJS6p43yv9sfvZcWG+vMkRFQRQWD5Cf4QgTKUT3Pgoe6+geH+Qhb8K9TTUO0KYCSenOZLczio3/yFSZjvRNVdw/SSRUbjw1gTHvEPCGe8fJQsJ5BJsIRaQcwlV7v24y2l24DfqteLftfoPxaZWtrjJwtWNnwZimJXzcIyozAG5IjJctvXILFYU5eiCjTrBWasUc7XGbsgGYfpUlWSkNbd7JWkUL3chTg6v+uMKROZrNqjX5vhm8dY7s/oIbQMLZojWOdCEoISmVVjnits1M8SdJ+rjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mkLg5SyEloLcxVZcSbvXyHj2WH8eTxhgyYru7I+bpq0=; b=H89p50GxG40O3hpmfsnSjaQaLqlLCfl5TUMahqD6EwQlIlS+C5AlVNs1C2efAbyTakgzXc6y/BCSZj9oUFjdzHxcXmI7O6pIe7tpprQj6053aE+4jG06YvCVdNoe5oLSRg/t3FU8tWilTwx7dTKE1WuNkGUyEVf78UfaHiVL9UC3ejW42u8Cz4F1Xz6Xm0crmyMDXSWVqSFHKan24BPhi0DWt9KQ51wU3vi8ykqWjweG8KLfVD1g+otO7m/6cubPwBud1cAc9hXqTSX0mrqfMKHD4q97IwNmZ7AYoaK/nCYEIh4KUY+WdGJoiOatNgNBnnNLLdGYRxnceqaM5i8JYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mkLg5SyEloLcxVZcSbvXyHj2WH8eTxhgyYru7I+bpq0=; b=vfoGr4TA49Tkb82FbKTyKn9IHnktLa/mUolP7LZrVsL6KD4R7vcfCFA+7urjZQFw3sA1OwWb4sIWMdf9ZLYPy3oHw+F/9F9kHVyuuUMeAOuylUg+I/zNikLx4z5Uj17r++KlEg5lRabossUw0hAGSnWvVbBIGwHp1FjWYHSWFBy1iOpcfCvp7tKftRWVL5CPVg4En1xlGl1YKH5/haLSk7lpwc7TzmXm/9Kw3jvuLfY/YYObQqNpUpceUblzLVDHf0aXkcXp+wmiscppuSgsS9WMgZ+pQwXviQGC791D+y3D5dW/37LPq2LkjqDhXnWjjv2ZmO6va/ld6scsJCXiXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Feb 2023 13:38:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal: List files in Xen originated from external sources Content-Language: en-US To: Luca Fancellu Cc: Stefano Stabellini , Andrew Cooper , George Dunlap , Julien Grall , Xen-devel References: <005b7fa3-0f64-b15d-38d5-8135b0da06d2@suse.com> <9EDE6823-A6EB-4ECF-BFFA-2FE896C076AD@arm.com> From: Jan Beulich In-Reply-To: <9EDE6823-A6EB-4ECF-BFFA-2FE896C076AD@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6776:EE_ X-MS-Office365-Filtering-Correlation-Id: b8d57964-3055-4d0d-fe80-08db083f0530 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w7rFzK91nwwKhfb/XUnXHIrph9l2AGxLut8CBbLEsD0m1ERS1mBG5VxvYKvhtpGeJ804IznO57+c+mZ7wRCVHd5wTmZvt3pOtzDDQI+7GMqYbxEtHTXLORz4fnZVHudQAZtoGwRWWjV/Fy9BJ+F7Jem3rddmezuli+wj99m8CTmhW/0Rxk6pbM1km65YRNb/pnLzVfoHX3Z0gtCc7F17JrIQWnyQ7eIoowgXoSbPIXWeVcUwNJlGkpp69Zc7kmbm7PySOTkNuGpp6EDy7+VyQbyqT2mpSmsA81DQO05DZhpE0uxM71vYg79oN1bwqG0sqHG/ErzQzuHJwvrbnetwVdxOyYCXYRICZxGvdtKI1iHMcmDh5n54P3empP9+Eb65wOOy7TZ1cj/IpJNzlGeMXZ5WbfTFLBDXhBGlaiR6k1c2vRV+SLf/2f5N02sBqNRVeccTjMOs3GkiuTk1keu7VB/pK9k7+8gnpAJb86wDbX349lJmreuIfnqmaGnChZpkaEKEI195YMPY8CNyCUrasCwtkLq70dXn44yYeEWnCGK7QV7M3w2gBjbJcpC/tlNRl7Au/HiOD09rLy3gwt8jD1f9MlTIGhW3H+OHOQYOZLYU7sch1VQAZtjw64R8GUF6pzAIdLqwpy9cIw0b5dZMP24Fibz+3F4TvVw08YMlDbppKQfulvju+1QchlWdg8y9mc83O1df0J3zDVGKlask3DdkIpahAtJDstbXJIwWqWk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39850400004)(136003)(346002)(376002)(451199018)(6486002)(2616005)(8936002)(478600001)(66556008)(26005)(186003)(31686004)(53546011)(6506007)(6512007)(54906003)(8676002)(316002)(6916009)(4326008)(38100700002)(66476007)(66946007)(41300700001)(83380400001)(2906002)(36756003)(31696002)(86362001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXBKTm5nbWtvcmlyOVdublBGSG5NbEZ0bkxUaTBRWTNDbnJmc0tIL0dBdFE0?= =?utf-8?B?UVR3UDdIWTlpN1ZxMm1ndFBhMFdOQnBteFFSdGFwR2ZsZDBxdjRwa01pc0hL?= =?utf-8?B?K1E5Z3N5bmRvS29kc1VobUlEcHpVUjlUL2FnOTdvTFhvTk9aTERndEhmNGl2?= =?utf-8?B?UGdoaFVpSTVDSVYzZ3JHOVZ3NnNsWFV3MUhjNC9BaE8xVUg5TEJvWXQ5RUJq?= =?utf-8?B?VGhJSEgwaWt0cWZJaTB6K2R5UEltVzFpSHdWQVhIRWNvNmIvSldWZXd4Yy9n?= =?utf-8?B?TTJSN0ZCZmlZTHdGZ2RrMUpwVVh6S2NTenU5aWU1dkh4UFZjNnlYUlNPQTVH?= =?utf-8?B?aG1QM1M2YlZEN3NIcitCcjF5NldYZnpFOVNzTy9zalBKN3I3YXJaOWRxQWR5?= =?utf-8?B?d2Q4NjBiRzloOTcwbUNRWnVRWWwyNlRxYmViZ3B6S2JleFEvTmhuZmZwRzNK?= =?utf-8?B?a2dRU1EyWHhRRFVEakl3cVpLOGVHWTRVbjdHUHYvbGk0ZFhXT1lJck1kYUJl?= =?utf-8?B?anpPZUNKS2hwb3N5K1ZGQ0NFdW9ZczBOZm5QWjFPOXFRYWpXS1ROUzFSeklx?= =?utf-8?B?akUzT3c1R2tCWXJzQ2pHU3R3dHhiQkQwSlVhdnpia1lSTGtaNlF2YmpXTXJ3?= =?utf-8?B?T0NubDFOWVF6UldmWklDWDRzeHdGTG51VFN5Y1JmREY4K1RtRnU5cm9nWXNs?= =?utf-8?B?WEhMT3l0Sk9zR1dDVWpLRUZib2VzOE0zL3IxMTJ0R1RqbmpScnBuaWI0RHhT?= =?utf-8?B?djQrbWI3WXlwNTlkbzdGeWpMY2EyL0swdzgzY0ZPV3N3T2xSVXByNFZLRGNR?= =?utf-8?B?aEgwdjRxNkExbzg1ME00dUZTQWY0V3Rzc2NEckUvY2o0VGlTdFh5VnllRjdn?= =?utf-8?B?cFNQdmVZdEpoam5mNWk5OWNMZjhsRGZOeTl4dXhpbW8yZGw3anpkVUxmMFZa?= =?utf-8?B?aGNIYVZjaW1pbFlwY3U0SGFqbzErd1F0cFdlbnVFT0ZRYlZlT2Z5TmRteGJE?= =?utf-8?B?WC90Z1hBOUdaalhka01yakJGOSsxd09aMUg2am5id0VLdnFBSVoxWEdpdFkz?= =?utf-8?B?Smd2QzYxalprUWtYcnNuL21INVpqUjgxYmdJNjhoOWs2L053TFFTMko4cEhD?= =?utf-8?B?R01qdmM1eDNhcHZaa0p2WVpLcjVNV1ovTUFLbldvQlVIUmZkZUxtNFNoNnB4?= =?utf-8?B?N1c2UUx2ZVc0VWNOVmx6ZVlTRHZVTnhuS1BFdVBYc2JpSzRmU2dQYjJFUk1C?= =?utf-8?B?ODBQWmZFSytrR0VubDV0TE1pVWU4UU4vc1B0bUZFQjh0d1RDcGE3Z1RXS0pN?= =?utf-8?B?VTNUa0JQYmFJU1NxUjR4cnlVdTNUUWJVVk12TFVlR1R4enhiczJGdUZNY1U0?= =?utf-8?B?bThVWUNTZHZFRitDQ0xNTlYrb1NHSS84Y1I2RVJNTXVFdCtCdTZodzRVMFRI?= =?utf-8?B?a2NKMkZmS0xIUjBURHFSKzd2dXpGTW5ROFRPNzZkc0txa202UjFtQWpJSWNB?= =?utf-8?B?bWhpZWx3R25YZXppSzVFUVp5NzFmVFNWUlFnWkJIU2Joc016aVd0TVRVTWlw?= =?utf-8?B?cWVibHNPRXNPUG9xQVJyZnBUOEY2eVBxWWJJcS81Tm1LZ0JJK0lHMlVFQjdJ?= =?utf-8?B?aFJjcnNWU3l0T0JkQ2l1SVQ3dVFKQUVHZDlSNUxKa2hjZHE4YjkrTm5yNEZC?= =?utf-8?B?OG5Ta0xPV0duMXhVQzdRcG1YTGNzZHdkVzdzSkFRZU54NFdzcGtkU1lJS0hX?= =?utf-8?B?alExd2lMNy84M3FDZVVnd0VNbW5jL2dnenJqenZPdkhVb2dXWWVSeVgwblNl?= =?utf-8?B?aEZSS0dDTGtVcnkyTjIxcSt0OEsvQ0RqTk5xVmVoNzNNUjN0bmNqL3VOZ0pE?= =?utf-8?B?enJUZEFwanhpQkhYeUJaZlBYOXZUQTV1OWsxc3pLVnFxd0oyb29IOHZtcWpI?= =?utf-8?B?YlcwOStTWFV0ZnRWOTJlZExaNXFHSyt4YlR2S3FGUWFhektZdmdDeTV0NHRx?= =?utf-8?B?OXVUM2FJR3dIZkcxblBxY0VyTTZPTjNRNW90VXpySk9xSlZkRG41QnhzRGQv?= =?utf-8?B?TjBpbnZ4bm1ZalhBTWh3bTFOc05KTTIrVmhJVDJSK2ViQkhtdWtITnhuYldM?= =?utf-8?Q?wEulyVDlgaJQAIK1WiMNoKNSy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8d57964-3055-4d0d-fe80-08db083f0530 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:38:16.7365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kORcFm/m/ebnJLoY5yuAyb6iyWg7FcHPJHjo5pEfKJ4T6SP4zdNXuKMxKS52lKESldsFpigs3RJgsD3O5kJpEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6776 On 06.02.2023 13:21, Luca Fancellu wrote: >> On 6 Feb 2023, at 10:01, Jan Beulich wrote: >> On 03.02.2023 10:30, Luca Fancellu wrote: >>> origin_path: relative path in the original project, mostly linked to the original_revision field >>> >>> origin_revision: revision of the changes in the repository when this file was taken. >> >> I guess this needs clarifying: What revision is meant here? The one originally >> imported, the one last updated from, or yet something else? Keep in mind that >> we may also be selectively importing changes, in which case any particular >> "revision" can easily end up misleading. The format likely also wants >> specifying, e.g. (like we do for Fixes: tags) the first 12 digits of a commit >> hash. For said selective updating this might then allow for something like >> ++... > > This is a good point, what would it be the best format in your opinion? > Maybe we should have the field as an array of revisions? > > "origin_revision": [ > "Revision of latest backport”, > [...] > "originally imported revision”, > ] > > What should be the best to capture the history of the file? That would be taking the 2nd step before the 1st one. For now we need to determine _what_ information we want to record. Then we can determine how to best represent it. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:43:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490354.759008 (Exim 4.92) (envelope-from ) id 1pP0pv-0005H2-0X; Mon, 06 Feb 2023 12:43:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490354.759008; Mon, 06 Feb 2023 12:43:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pu-0005Gu-TS; Mon, 06 Feb 2023 12:43:06 +0000 Received: by outflank-mailman (input) for mailman id 490354; Mon, 06 Feb 2023 12:43:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pt-0005GF-Vi for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:43:06 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbcc1dab-a61b-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 13:43:03 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id g6so2251659wrv.1 for ; Mon, 06 Feb 2023 04:43:03 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.googlemail.com with ESMTPSA id o15-20020adfa10f000000b002bddaea7a0bsm8881450wro.57.2023.02.06.04.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 04:43:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbcc1dab-a61b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MNDsqUhVp4CrpdRW5c2DDqCamntpV86ahP5h/2pH/yM=; b=mWamJfY77NtlQrOeItwBjf30DLN/kcIGuFvTr3GQF13Fway6y1IxFTPwI0KYkVJvzh /0v/ACirRrkby+/TzP6Fzmu+bPggVRQlQ5xUOIA6iwNzgv56+43usbqyb9U7y5oI32mz GTTIvaCFGO+69SfqwsQwy75c2Kef/LSCBycRoykolTjbFFVfHAcdQz9LepSXQiAABu7b d86uFfVl/mpGigMfRU47wf/6FDkkyc2pCDPUifeWdcEGaLadRyo5fYvVY5KX8h8aomvH 7jUP3z6lkrdMlXiLUpSatgO5P+mtE84BWqvjM2TJAcHIyg9TseE7TzWjolnf/nti9f/V fi4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MNDsqUhVp4CrpdRW5c2DDqCamntpV86ahP5h/2pH/yM=; b=CFZC2674nOKnUX9h1AHS8RAHCXANp0aJ9rRWbR8gC0K+d76hN4e8XICL/25uYBsuk8 D6KO1WUjay6BJwkfYBYshqIMMMAPuYuX/EYWwzXx5bjNfICvrFGeEuiZm/DxywMitwAA CRnzzuB+TdjmXuo0vPqPHtXYtZAG80XaGJpxDnuJwgCRvo6VJgjcRA4JcrUxhhVWU59D b/Pt9wIQ38BQyLvZnofXssbgGQo2tu7ZzcpmiRamFQFsWABl2PnJJmudD4EO8MmrFX9E tCgBl7FOdoDmBkftnf5gB7XHm5PbnMiPgPn/4LOE9XhBr3tvFbftZdWUEM0m2kB683U7 H9dg== X-Gm-Message-State: AO0yUKWI7E4Tlex5HSSt0u38LR+x/W0JCQdC4bz45zTfb9rUUKgUn8G/ tYf0791RIT4kD7GT6Ls3UEoLIs33kPo= X-Google-Smtp-Source: AK7set+pn2ZACVv7Cs0+tdmWIDEb8U7yE5/zmsQ8ZHjja9zaPLHSq206t6JgGqT7vLZFrTtRYQwvzw== X-Received: by 2002:a5d:5284:0:b0:2c3:d296:7a84 with SMTP id c4-20020a5d5284000000b002c3d2967a84mr9232097wrv.17.1675687382566; Mon, 06 Feb 2023 04:43:02 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap Subject: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used Date: Mon, 6 Feb 2023 14:42:50 +0200 Message-Id: <20230206124251.911744-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230206124251.911744-1-burzalodowa@gmail.com> References: <20230206124251.911744-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When none of the declarations and macro definitions in asm/hvm/support.h is referred in the file, do not include the header. To fix subsequent build errors, which were not triggered before due to the indirect inclusion of the missing headers by asm/hvm/support.h, include any missing headers. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/amd.c | 2 +- xen/arch/x86/cpu/intel.c | 2 +- xen/arch/x86/cpu/vpmu.c | 1 - xen/arch/x86/cpu/vpmu_intel.c | 1 - xen/arch/x86/crash.c | 1 - xen/arch/x86/domain.c | 1 - xen/arch/x86/domctl.c | 1 - xen/arch/x86/emul-i8254.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/io.c | 1 - xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 3 ++- xen/arch/x86/hvm/rtc.c | 3 ++- xen/arch/x86/hvm/save.c | 2 -- xen/arch/x86/hvm/stdvga.c | 1 - xen/arch/x86/hvm/svm/emulate.c | 1 - xen/arch/x86/hvm/svm/intr.c | 1 - xen/arch/x86/hvm/svm/vmcb.c | 1 - xen/arch/x86/hvm/viridian/synic.c | 1 - xen/arch/x86/hvm/viridian/time.c | 1 - xen/arch/x86/hvm/viridian/viridian.c | 1 - xen/arch/x86/hvm/vmx/intr.c | 1 - xen/arch/x86/hvm/vmx/vmcs.c | 1 - xen/arch/x86/hvm/vmx/vvmx.c | 1 + xen/arch/x86/hvm/vpic.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/i387.c | 1 - xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/mm/altp2m.c | 1 - xen/arch/x86/mm/hap/nested_ept.c | 1 - xen/arch/x86/mm/hap/nested_hap.c | 1 - xen/arch/x86/oprofile/op_model_athlon.c | 2 +- xen/arch/x86/oprofile/xenoprof.c | 1 - xen/arch/x86/smp.c | 1 - xen/arch/x86/sysctl.c | 1 - xen/arch/x86/x86_64/traps.c | 1 - xen/arch/x86/xstate.c | 1 - xen/drivers/passthrough/x86/hvm.c | 1 - 38 files changed, 14 insertions(+), 38 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 1ddb55cbe5..caafe44740 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -4,12 +4,12 @@ #include #include #include +#include #include #include #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c index dc6a0c7807..71fc1a1e18 100644 --- a/xen/arch/x86/cpu/intel.c +++ b/xen/arch/x86/cpu/intel.c @@ -1,5 +1,6 @@ #include #include +#include #include #include #include @@ -10,7 +11,6 @@ #include #include #include -#include #include "cpu.h" diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index 33e2fca8cd..b6b7342fb4 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -30,7 +30,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index b91d818be0..a8df52579d 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c index 99089f77a7..7850f0af24 100644 --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -24,7 +24,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index d7a8237f01..abd2b4ad68 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index e9bfbc57a7..2118fcad5d 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -25,7 +25,6 @@ #include #include #include -#include #include #include /* for hvm_acpi_power_button */ #include /* for arch_do_domctl */ diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index 18894b6348..1688b7e458 100644 --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -34,7 +34,7 @@ #include #include #include -#include +#include #include #include diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index 45c7b9b406..c65e1b27d0 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -18,7 +18,7 @@ #include #include -#include +#include #include #include #include diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 0309d05cfd..5ae209d3b6 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index d93ffe4546..4fe87a71c1 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -24,7 +24,7 @@ #include #include #include -#include +#include #include #include diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index 2a89bbdfa5..b89d0fd53b 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -17,9 +17,10 @@ * this program; If not, see . */ +#include #include #include -#include +#include #include /* for hvm_acpi_power_button prototype */ #include diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index d21925db08..44f2fb668d 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -22,10 +22,11 @@ * IN THE SOFTWARE. */ +#include #include #include #include -#include +#include #include #include #include diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index 86c82cbd74..c1675e3d9f 100644 --- a/xen/arch/x86/hvm/save.c +++ b/xen/arch/x86/hvm/save.c @@ -24,8 +24,6 @@ #include #include -#include - #include void arch_hvm_save(struct domain *d, struct hvm_save_header *hdr) diff --git a/xen/arch/x86/hvm/stdvga.c b/xen/arch/x86/hvm/stdvga.c index be8200c8d0..798a9a0549 100644 --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -31,7 +31,6 @@ #include #include #include -#include #include #include diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 635b3705f7..16fc134883 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 7f815d2307..9525f35593 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 0fc57dfd71..305d4767e3 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c index 856bb898b8..83d7addfc3 100644 --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -13,7 +13,6 @@ #include #include -#include #include #include "private.h" diff --git a/xen/arch/x86/hvm/viridian/time.c b/xen/arch/x86/hvm/viridian/time.c index b56fd67662..a3ea3fa067 100644 --- a/xen/arch/x86/hvm/viridian/time.c +++ b/xen/arch/x86/hvm/viridian/time.c @@ -15,7 +15,6 @@ #include #include #include -#include #include "private.h" diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c index 2937ddd3a8..7405c117bc 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 13bbe8430d..6a8316de0e 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -29,7 +29,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 7d8bfeb539..09edbd23b3 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -33,7 +33,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index f8fe8d0c14..674cdabb07 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/x86/hvm/vpic.c b/xen/arch/x86/hvm/vpic.c index b3cafaab8f..17e15720f0 100644 --- a/xen/arch/x86/hvm/vpic.c +++ b/xen/arch/x86/hvm/vpic.c @@ -32,7 +32,7 @@ #include #include #include -#include +#include #define vpic_domain(v) (container_of((v), struct domain, \ arch.hvm.vpic[!vpic->is_master])) diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index cb1d81bf9e..621f5bb88b 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -16,8 +16,8 @@ * this program; If not, see . */ +#include #include -#include #include #include #include diff --git a/xen/arch/x86/i387.c b/xen/arch/x86/i387.c index 677f571792..d824f2bb52 100644 --- a/xen/arch/x86/i387.c +++ b/xen/arch/x86/i387.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 96a9f07ca5..234da4a7f4 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -23,8 +23,8 @@ #include #include #include +#include #include -#include #include #include diff --git a/xen/arch/x86/mm/altp2m.c b/xen/arch/x86/mm/altp2m.c index 8be6eaf242..07393befee 100644 --- a/xen/arch/x86/mm/altp2m.c +++ b/xen/arch/x86/mm/altp2m.c @@ -15,7 +15,6 @@ * this program; If not, see . */ -#include #include #include #include diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c index 23fb3889b7..605e47c16c 100644 --- a/xen/arch/x86/mm/hap/nested_ept.c +++ b/xen/arch/x86/mm/hap/nested_ept.c @@ -25,7 +25,6 @@ #include #include #include -#include #include diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c index b19f657c27..098e8e5d4c 100644 --- a/xen/arch/x86/mm/hap/nested_hap.c +++ b/xen/arch/x86/mm/hap/nested_hap.c @@ -27,7 +27,6 @@ #include #include #include -#include #include diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c index 7bc5853a6c..69fd3fcc86 100644 --- a/xen/arch/x86/oprofile/op_model_athlon.c +++ b/xen/arch/x86/oprofile/op_model_athlon.c @@ -10,6 +10,7 @@ * @author Graydon Hoare */ +#include #include #include #include @@ -18,7 +19,6 @@ #include #include #include -#include #include #include diff --git a/xen/arch/x86/oprofile/xenoprof.c b/xen/arch/x86/oprofile/xenoprof.c index b20f26bbe5..247a0deca8 100644 --- a/xen/arch/x86/oprofile/xenoprof.c +++ b/xen/arch/x86/oprofile/xenoprof.c @@ -12,7 +12,6 @@ #include #include #include -#include #include "op_counter.h" diff --git a/xen/arch/x86/smp.c b/xen/arch/x86/smp.c index b42603c351..3a331cbdbc 100644 --- a/xen/arch/x86/smp.c +++ b/xen/arch/x86/smp.c @@ -21,7 +21,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index f82abc2488..f42a3b843b 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c index f8cb8d9a94..f4d17b4830 100644 --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -23,7 +23,6 @@ #include #include #include -#include static void print_xen_info(void) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 3b32bdc51c..d481e1db3e 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index 6bbd04bf3d..8175ba629a 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -23,7 +23,6 @@ #include #include #include -#include #include /* -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:43:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:43:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490355.759020 (Exim 4.92) (envelope-from ) id 1pP0pw-0005Xj-As; Mon, 06 Feb 2023 12:43:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490355.759020; Mon, 06 Feb 2023 12:43:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pw-0005Xc-5k; Mon, 06 Feb 2023 12:43:08 +0000 Received: by outflank-mailman (input) for mailman id 490355; Mon, 06 Feb 2023 12:43:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pu-00050Q-KG for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:43:06 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd764ac0-a61b-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:43:06 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id a2so9959259wrd.6 for ; Mon, 06 Feb 2023 04:43:06 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.googlemail.com with ESMTPSA id o15-20020adfa10f000000b002bddaea7a0bsm8881450wro.57.2023.02.06.04.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 04:43:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd764ac0-a61b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wrIrR+cRozFMoRbiOf5/5kA1QxMReA6Uc+urY7xUoHo=; b=nbCRk/S3OblML1f9qnfnbPK8PxslL3umgvEwqZ4c+EkvZwrhX2I8n0EjzppaK3OznD 2R4ZhflfUMoniYT5yY/OGQ4KtBDxlYoLCak7og1MDZZKSUw3FfcfU/ZIhGpHePivhBHU ohhfnIZ7aRCXUi7i0HuFxV55n7jcq6VyM+Iulw+BiKwov5NcjEW/b+OBNqjOwaV60v2k dkUKxXQfF1kC7iWty0o/gUVXM6hKHTDVAUptCT8y6rQbEfWvWFVRTWcTyfx8HQ8/eq18 pFsYKOTSXz/tHts6x8vpFX1HXfAo//lkz+sLACeePYZ89BNgCnAa6Ide85FwJ8C7M1Jd LtbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wrIrR+cRozFMoRbiOf5/5kA1QxMReA6Uc+urY7xUoHo=; b=Yz1Cfjo2wICxGelGvP1BmoYHS7PHOXH6d2eEvIufFZOSsB7d2qGbUEH6oFCkKgNQvK O93rziz2jjGJTyzuSsNzobpPgIRBr1i/UKNb8ivZpje0d1r2A3XAdFxtfpp1aWk02ppX /t987aDdCuvLNTZyfe+ZqnsqkIy/I6gWmQI8kQXgwJiMdQEPa0vbkr5ZnGK2CZAI27Lu 6J7h3QTlzuNpj4PqLDrU3ib9wKgjRukf7+qQXIOHu8qbNiu5zcENdBidi+8SNcpackgn AV8UZYUZrEs5AxUA9NfVijFV0rayhUo27lu8XAFU/E+QCpC7TUt/oiaUXkpDWdIdV4qt 0Qdg== X-Gm-Message-State: AO0yUKV85lwF93oypGrrVC8Kwge+65xnwGF4YYVg3xfC1X3Pp6PKCIcB xoflmScvxJHAyJMEEZIGsjEqlq2ASXc= X-Google-Smtp-Source: AK7set/31WKlETDcKV82pJ34osnTaPKCcY8NweAKZgLrDkMU8Nfln78DRg7Y/+V+YGwxAqctTYsZnQ== X-Received: by 2002:a05:6000:2ab:b0:2bf:e4b2:64a8 with SMTP id l11-20020a05600002ab00b002bfe4b264a8mr22402627wry.42.1675687385530; Mon, 06 Feb 2023 04:43:05 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/2] x86/hygon: do not include asm/hvm/support.h when not used Date: Mon, 6 Feb 2023 14:42:51 +0200 Message-Id: <20230206124251.911744-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230206124251.911744-1-burzalodowa@gmail.com> References: <20230206124251.911744-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since none of the declarations and macro definitions in asm/hvm/support.h is referred in x86/cpu/hygon.c, remove the unnecessary include. To resolve the subsequent build error for implicit declaration of wrmsrl() and rdmsrl() triggered in asm/spec_ctrl.h, replace asm/msr-index.h with asm/msr.h in asm/spec_ctrl.h's included headers. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/hygon.c | 1 - xen/arch/x86/include/asm/spec_ctrl.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c index 361eb6fd41..42029f2145 100644 --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -1,6 +1,5 @@ #include #include -#include #include #include "cpu.h" diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index 6a77c39378..e928596450 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -60,7 +60,7 @@ #include #include -#include +#include void init_speculation_mitigations(void); void spec_ctrl_init_domain(struct domain *d); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:43:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:43:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490353.758997 (Exim 4.92) (envelope-from ) id 1pP0pq-00050f-OH; Mon, 06 Feb 2023 12:43:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490353.758997; Mon, 06 Feb 2023 12:43:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pq-00050W-LU; Mon, 06 Feb 2023 12:43:02 +0000 Received: by outflank-mailman (input) for mailman id 490353; Mon, 06 Feb 2023 12:43:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0pp-00050Q-C8 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:43:01 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca23eac8-a61b-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:43:00 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id i5so3061291wrc.0 for ; Mon, 06 Feb 2023 04:43:00 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.googlemail.com with ESMTPSA id o15-20020adfa10f000000b002bddaea7a0bsm8881450wro.57.2023.02.06.04.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 04:42:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca23eac8-a61b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6tvKKYzN5vkUJPlotDa1j7iDKIgMMFscivD/ORBfUNU=; b=iWiwSmeeMdUchn07UMWlbItKk22mVRcbg/IvxgfCRW0hb7PCFdBaXGbsr7PlAmKolE 0MI7VkY54QvpfF6reZ/SFX5pBjt0JmvclT2SQxnExtNpzWdHNaX08g+befxUSFlzyXPK Jo8tMou32EyGqNn6TEOMkHLsT+sOztmtbrJS3ekhq6/uRIjcoywbH7dCSyeFzyVH6Q9U nFWruv/fPCYD3Qq8HX6/ElfLPAaf8lNlKZJa2Jmp3lYuaAS8rA+kYGRcqkd+5P8Ob1YT XVS8Wza3BNDT0BWVs/CKKMbQZqQK/vrcu6kxYRTLDY81xMnT9o5wZ2oEnDTM7HQxU5s8 Y9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6tvKKYzN5vkUJPlotDa1j7iDKIgMMFscivD/ORBfUNU=; b=k+Z4o7j0Dl0ynah8Wwoh+ItSVfxFjizxiIgct11Oi918k+24ldY47WX5m3OQselDHQ AmwZkmYwSyk1pjJomULYzI9mMp115wMRQiCs9TC1UH7PNx5zdAztYzfxLt92uodmk+2e Z+iyJyJkJdk62TGA/CcxjJzlgaJDCaZll0OUqxUYCD2E8apGJen0FlOXbx/zgTfCC41T gsCODqYh3Q/lTlq6OKsXKKUSMlRogTacFB+B3ITqG4B0zKoqwglzU2otG7o1oSLXuiW0 dIVV74CVI5kaBcPvRxJCHV+aSjl061r+LXs4Cmrc2BFAyQfsQDNRUp+X1Rmv6NViShq7 ndQA== X-Gm-Message-State: AO0yUKXc5F+IYkV1RgnfI+wkswR9SvVPsKgvkkbq3qvgQwzt9NdYXgTw J43N1hkWcjeud9ARv5D/lN0rPXo/GrA= X-Google-Smtp-Source: AK7set/nxjPD9Heau7t3tFnzG7bMoV8c5K6wwhV8FZWM87nBZXQ+z70F9eK2qFTyo2eY3UtWHzue5g== X-Received: by 2002:a5d:5582:0:b0:2c3:ea52:7d0e with SMTP id i2-20020a5d5582000000b002c3ea527d0emr2861327wrv.69.1675687379997; Mon, 06 Feb 2023 04:42:59 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap Subject: [PATCH 0/2] Remove unnecessary asm/hvm/support.h includes Date: Mon, 6 Feb 2023 14:42:49 +0200 Message-Id: <20230206124251.911744-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While working on the separation between AMD and Intel code, I noticed that the header asm/hvm/support.h is included in many files even if none of its declarations and macro definitions is referred in those files. This patch series aims to remove any redundant includes of asm/hvm/support.h. The changes are sent as 2 patches to aid review (especially the change in asm/spec_ctrl.h). Xenia Ragiadakou (2): x86: do not include asm/hvm/support.h when not used x86/hygon: do not include asm/hvm/support.h when not used xen/arch/x86/cpu/amd.c | 2 +- xen/arch/x86/cpu/hygon.c | 1 - xen/arch/x86/cpu/intel.c | 2 +- xen/arch/x86/cpu/vpmu.c | 1 - xen/arch/x86/cpu/vpmu_intel.c | 1 - xen/arch/x86/crash.c | 1 - xen/arch/x86/domain.c | 1 - xen/arch/x86/domctl.c | 1 - xen/arch/x86/emul-i8254.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/io.c | 1 - xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 3 ++- xen/arch/x86/hvm/rtc.c | 3 ++- xen/arch/x86/hvm/save.c | 2 -- xen/arch/x86/hvm/stdvga.c | 1 - xen/arch/x86/hvm/svm/emulate.c | 1 - xen/arch/x86/hvm/svm/intr.c | 1 - xen/arch/x86/hvm/svm/vmcb.c | 1 - xen/arch/x86/hvm/viridian/synic.c | 1 - xen/arch/x86/hvm/viridian/time.c | 1 - xen/arch/x86/hvm/viridian/viridian.c | 1 - xen/arch/x86/hvm/vmx/intr.c | 1 - xen/arch/x86/hvm/vmx/vmcs.c | 1 - xen/arch/x86/hvm/vmx/vvmx.c | 1 + xen/arch/x86/hvm/vpic.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/i387.c | 1 - xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/include/asm/spec_ctrl.h | 2 +- xen/arch/x86/mm/altp2m.c | 1 - xen/arch/x86/mm/hap/nested_ept.c | 1 - xen/arch/x86/mm/hap/nested_hap.c | 1 - xen/arch/x86/oprofile/op_model_athlon.c | 2 +- xen/arch/x86/oprofile/xenoprof.c | 1 - xen/arch/x86/smp.c | 1 - xen/arch/x86/sysctl.c | 1 - xen/arch/x86/x86_64/traps.c | 1 - xen/arch/x86/xstate.c | 1 - xen/drivers/passthrough/x86/hvm.c | 1 - 40 files changed, 15 insertions(+), 40 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:48:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490376.759029 (Exim 4.92) (envelope-from ) id 1pP0vK-0006vJ-7V; Mon, 06 Feb 2023 12:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490376.759029; Mon, 06 Feb 2023 12:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0vK-0006vC-4h; Mon, 06 Feb 2023 12:48:42 +0000 Received: by outflank-mailman (input) for mailman id 490376; Mon, 06 Feb 2023 12:48:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0vJ-0006v6-J3 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:48:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0e::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93bf3234-a61c-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 13:48:39 +0100 (CET) Received: from AM6PR05CA0012.eurprd05.prod.outlook.com (2603:10a6:20b:2e::25) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:48:33 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::28) by AM6PR05CA0012.outlook.office365.com (2603:10a6:20b:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 12:48:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 12:48:33 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Mon, 06 Feb 2023 12:48:32 +0000 Received: from e22ce6136302.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1DA50412-637A-47F9-B844-0182AB5AD441.1; Mon, 06 Feb 2023 12:48:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e22ce6136302.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 12:48:26 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB8064.eurprd08.prod.outlook.com (2603:10a6:20b:54d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 12:48:17 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 12:48:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93bf3234-a61c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uq5ePRHFEkRDZNX3ott0OvteXRN/5GjcPlXRQpT5hAE=; b=RPWGlQ/3Hdgwj0oePiMaEw/OXVbleXmKzQFLF4BbY2y2faL4A3aImcD1kzjGjzFnyDcXrcEjNwHvrlz659yzPYChlBRU33sIPJwZ31OY3gEq6nT4kg5lmUNRINwuwW4IPnrFshqu+crEjipW+gCcOJID051FyGlJU3CLYRu23NY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b44765ba3a844d4d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eC1pAYoe1DW/4DEsyXyJla87fP7GkwcuejV1Iqxy2c5/ZJJ0gKTvSBgZ/d9OgD0oi6T6rRWL4MqDmxm6SdcE+MTnjtvdDAKc0/k0Lc0QEZlrhUDsnYF/8n1nlPlONxsMWJz7klGrptyFiaViTId2zfLQ0QMtvx4Wu38FFyvbx8z0jV1cylCJKGyCK5RaxMXZfH94K2oJ4OGZ5/HA5fQiHFP/1FxwOwlr17mjVT8Mhq8tG5NI/Gv/Nff6vqoi9wU3T3UdJxdQp8di+TXM7vOpUV9mhhaQTNO1STUE56XQg3AvoHWGcd9F66ctlTZ1cpCBgn4nghNah7QFLHhqINi4mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uq5ePRHFEkRDZNX3ott0OvteXRN/5GjcPlXRQpT5hAE=; b=n50dUs4cdo5KPR5QB46F1CgFLisASSvB1ogmJeI5LphEgG+hn2VktB+cJdfs7di4UzNMKgYenHI8Dw/423uiSQJi8BUP/WSS5mBrieqYpU0gUmpi2xZhizPVMRnFjaNRvyol/bclJTW0ENYCkmN1pRaIKrq/IvSfYCk26vDFl1+VjX7U4QTHcoC49Cwvz3UbNcUrR3i7ZJHlCMrkoOUMmeSHT7uUWSMUS19kFPe3/qFE3s8DWoRnXt+Ag8BS5b9A4ocWsISQhD9G8dF7/cdVRQy7qJpAJyO/5CFq4/dENZJf9G9pHyUtVeISKxzvCxEJb9q+sXPqimg1uIaUXFNaTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uq5ePRHFEkRDZNX3ott0OvteXRN/5GjcPlXRQpT5hAE=; b=RPWGlQ/3Hdgwj0oePiMaEw/OXVbleXmKzQFLF4BbY2y2faL4A3aImcD1kzjGjzFnyDcXrcEjNwHvrlz659yzPYChlBRU33sIPJwZ31OY3gEq6nT4kg5lmUNRINwuwW4IPnrFshqu+crEjipW+gCcOJID051FyGlJU3CLYRu23NY= From: Luca Fancellu To: Jan Beulich CC: Stefano Stabellini , Andrew Cooper , George Dunlap , Julien Grall , Xen-devel , Bertrand Marquis Subject: Re: Proposal: List files in Xen originated from external sources Thread-Topic: Proposal: List files in Xen originated from external sources Thread-Index: AQHZN7IkxuQrtwTv+0WBDKkxqc3Ztq7BtLQAgAAnBYCAAASlAIAAAsKA Date: Mon, 6 Feb 2023 12:48:17 +0000 Message-ID: <5AF7E2CA-216E-4E16-8542-2E7DF7ADB77E@arm.com> References: <005b7fa3-0f64-b15d-38d5-8135b0da06d2@suse.com> <9EDE6823-A6EB-4ECF-BFFA-2FE896C076AD@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB8064:EE_|AM7EUR03FT040:EE_|AM7PR08MB5366:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b1f7a19-e600-4ef4-fff1-08db084074a3 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8n1mHQnJ+6TYOJbHfI11axqp+Dfrsf8F+0lohUvJba4LZaU8s9HAGyKjjIcgGe/H2YUAy68AxufBicTBzVfyTwB85KZGX8gOQj5gcSeoyroZ0VbX5jWc+6ps5LtpES48MlE76P2Un34R2OHGq4nAnPFrZMUO39C0Xi/aAjD/yjJCsrgNmjWtJoeQgg/Rl/FCf/xluyr9eNChc2IJcfCHY3xHIckVUNolFbPcdqXBm5vgZDKtNTu2TUCG88hMLukoN/OQMEd3BM9cqe6Cf9WZIXhQADk+scz8y9TiEQ4PHkwNmWCFs1D+xcoVtNOKcaFkEH7Ur2ez6Bis28iJMhTwQikcc42b7DGsr4QIcrS4tsQHSbuj0H8yKE4GFPbgTrNfLg12/MVdr68kEmU2aBVINVq5lcB2s0TdstDNCRMHfszXiEVHu+qkRj8q9ILDx+ORgkY5iByWolgTW8aa8kw4zPH9S7waX6k3yeXHjLotXPRz3vkhuN8d1P4IH9Q6BdseryCgpvc0fbUrWbgm0XEoLArT/MtuPXbfmiRMXummjGUQaIzhQVE6OArPZ4bWYIy6CNBNGWIWeS274BmvDX7vTZ1UF0B9gtom2ZCvB2JtqQ8e7sB6zg7a76fGwIGCWZrgpRTRsZ3LgJ/MJB+l4VyPyYQZZtrLC5Xcic2J5bBtDfAOQ6vnEFH9QHOKdjR0sZJo2uNGUHNGZtzwFXrooJRdDr/VT6+xuDEmrOMRcaywJj0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(2906002)(41300700001)(8936002)(5660300002)(6486002)(36756003)(478600001)(6506007)(53546011)(91956017)(26005)(186003)(6512007)(2616005)(83380400001)(86362001)(33656002)(38070700005)(122000001)(38100700002)(66556008)(66476007)(6916009)(8676002)(64756008)(4326008)(66946007)(66446008)(71200400001)(76116006)(316002)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8064 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e323b118-8f7f-4c8b-7405-08db08406b79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s4xlQ/47+NUXHpQyVX9z6MIITxAlwZCdajWO8YcLvWZ5dEM0nIaSLp+S1FPBLD6MKK1zLDFtHmmakvDH2yAPiJwQH5uAJjyXOYrBLXfKWBxIJRlFrVn2Cuk+Dg51B/1tCXYX05taLygCxE36TDNfCkZBwqLxQyQPVNe6fSNbFxlYtjRqXfkvtdRHi8R1pXguOy0sdw1h7ILB6xGg/fANzFKl9aYtK7djGEQD9LC8Y702mQBrrNUEiyWFilZ0RDkO++PlTj7LDucGj9CViUMe4fDNOnFckAFmTfGuILA1gmKfV8Io42d4bbjQWIBnijb0t4i+3d01Cfk2axETiRHqHFxAUznDaGqHM6fFonIV8YZmliecJUHWGxDrnyVjGJhqmyhHXaopUCeD9fZKdQEtJjDVhiW+P9hQc2AYHZNF7LH6k51MlzlNE7VmAzGla0U/3zRsq5XvEYccb9kXo2Isy1i4lEJzFFnsubNz5igmeDrzCpk2rCgnP/DjAK93PdFUqAnIKDs5HMZnkGIGu73W2wAVPgxUU2U5Q3yyII5BSbZKkc0octCUbkA+0mIoXxQaSUZgPViMjX5S34t806c1EB+3afmZsqgiQtSMbEGYmnlH4QKBbkUcqE3FTaXqlr56n+sSI+AdguFI4UU26UkU5AcRAR+1p4dd6KMVxGeYudA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(396003)(39860400002)(451199018)(46966006)(36840700001)(33656002)(82740400003)(86362001)(36860700001)(81166007)(36756003)(356005)(316002)(4326008)(41300700001)(70206006)(8676002)(70586007)(8936002)(6862004)(54906003)(40480700001)(82310400005)(5660300002)(2906002)(47076005)(336012)(83380400001)(478600001)(6486002)(6512007)(53546011)(186003)(26005)(6506007)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 12:48:33.0422 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1f7a19-e600-4ef4-fff1-08db084074a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 KyBhZGRpbmcgQmVydHJhbmQgaW4gdGhlIENDLCBhcG9sb2dpZXMgZm9yIGZvcmdldHRpbmcgeW91 IGluIHRoZSBmaXJzdCBtYWlsDQoNCj4gT24gNiBGZWIgMjAyMywgYXQgMTI6MzgsIEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwNi4wMi4yMDIzIDEzOjIx LCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+IE9uIDYgRmViIDIwMjMsIGF0IDEwOjAxLCBKYW4g QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+IHdyb3RlOg0KPj4+IE9uIDAzLjAyLjIwMjMgMTA6 MzAsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+IG9yaWdpbl9wYXRoOiByZWxhdGl2ZSBwYXRo IGluIHRoZSBvcmlnaW5hbCBwcm9qZWN0LCBtb3N0bHkgbGlua2VkIHRvIHRoZSBvcmlnaW5hbF9y ZXZpc2lvbiBmaWVsZA0KPj4+PiANCj4+Pj4gb3JpZ2luX3JldmlzaW9uOiByZXZpc2lvbiBvZiB0 aGUgY2hhbmdlcyBpbiB0aGUgcmVwb3NpdG9yeSB3aGVuIHRoaXMgZmlsZSB3YXMgdGFrZW4uDQo+ Pj4gDQo+Pj4gSSBndWVzcyB0aGlzIG5lZWRzIGNsYXJpZnlpbmc6IFdoYXQgcmV2aXNpb24gaXMg bWVhbnQgaGVyZT8gVGhlIG9uZSBvcmlnaW5hbGx5DQo+Pj4gaW1wb3J0ZWQsIHRoZSBvbmUgbGFz dCB1cGRhdGVkIGZyb20sIG9yIHlldCBzb21ldGhpbmcgZWxzZT8gS2VlcCBpbiBtaW5kIHRoYXQN Cj4+PiB3ZSBtYXkgYWxzbyBiZSBzZWxlY3RpdmVseSBpbXBvcnRpbmcgY2hhbmdlcywgaW4gd2hp Y2ggY2FzZSBhbnkgcGFydGljdWxhcg0KPj4+ICJyZXZpc2lvbiIgY2FuIGVhc2lseSBlbmQgdXAg bWlzbGVhZGluZy4gVGhlIGZvcm1hdCBsaWtlbHkgYWxzbyB3YW50cw0KPj4+IHNwZWNpZnlpbmcs IGUuZy4gKGxpa2Ugd2UgZG8gZm9yIEZpeGVzOiB0YWdzKSB0aGUgZmlyc3QgMTIgZGlnaXRzIG9m IGEgY29tbWl0DQo+Pj4gaGFzaC4gRm9yIHNhaWQgc2VsZWN0aXZlIHVwZGF0aW5nIHRoaXMgbWln aHQgdGhlbiBhbGxvdyBmb3Igc29tZXRoaW5nIGxpa2UNCj4+PiA8YmFzZS1oYXNoPis8Y2hlcnJ5 LXBpY2s+Ky4uLg0KPj4gDQo+PiBUaGlzIGlzIGEgZ29vZCBwb2ludCwgd2hhdCB3b3VsZCBpdCBi ZSB0aGUgYmVzdCBmb3JtYXQgaW4geW91ciBvcGluaW9uPw0KPj4gTWF5YmUgd2Ugc2hvdWxkIGhh dmUgdGhlIGZpZWxkIGFzIGFuIGFycmF5IG9mIHJldmlzaW9ucz8NCj4+IA0KPj4gIm9yaWdpbl9y ZXZpc2lvbiI6IFsNCj4+ICAgIlJldmlzaW9uIG9mIGxhdGVzdCBiYWNrcG9ydOKAnSwNCj4+ICAg Wy4uLl0NCj4+ICAgIm9yaWdpbmFsbHkgaW1wb3J0ZWQgcmV2aXNpb27igJ0sDQo+PiBdDQo+PiAN Cj4+IFdoYXQgc2hvdWxkIGJlIHRoZSBiZXN0IHRvIGNhcHR1cmUgdGhlIGhpc3Rvcnkgb2YgdGhl IGZpbGU/DQo+IA0KPiBUaGF0IHdvdWxkIGJlIHRha2luZyB0aGUgMm5kIHN0ZXAgYmVmb3JlIHRo ZSAxc3Qgb25lLiBGb3Igbm93IHdlIG5lZWQgdG8NCj4gZGV0ZXJtaW5lIF93aGF0XyBpbmZvcm1h dGlvbiB3ZSB3YW50IHRvIHJlY29yZC4gVGhlbiB3ZSBjYW4gZGV0ZXJtaW5lIGhvdw0KPiB0byBi ZXN0IHJlcHJlc2VudCBpdC4NCg0KWWVzIHlvdSBhcmUgcmlnaHQsIHdoYXQgaW5mb3JtYXRpb25z IG1ha2VzIHNlbnNlIHRvIHRyYWNrIGZvciBhIGZpbGUsIG15IGZpcnN0IHRob3VnaHQNCmlzIGNs ZWFybHkgdGhlIHJldmlzaW9uIHdoZXJlIHRoZSBmaWxlIHdhcyB0YWtlbiwgYXQgZmlyc3QgSSB0 aG91Z2h0IHRoYXQgdXBkYXRpbmcgdGhlIHJldmlzaW9uDQp0byB0aGUgbGF0ZXN0IG9uZSBiYWNr IHBvcnRlZCB3b3VsZCBoYXZlIGJlZW4gZW5vdWdoLCBidXQgZnJvbSB5b3VyIGNvbW1lbnQgSSBz ZWUgdGhhdA0KaXQncyBub3Qgc28gc2ltcGxlLg0KDQoNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:53:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:53:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490382.759042 (Exim 4.92) (envelope-from ) id 1pP0zn-0008Jv-RP; Mon, 06 Feb 2023 12:53:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490382.759042; Mon, 06 Feb 2023 12:53:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0zn-0008Jo-MO; Mon, 06 Feb 2023 12:53:19 +0000 Received: by outflank-mailman (input) for mailman id 490382; Mon, 06 Feb 2023 12:53:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0zm-0008It-Js; Mon, 06 Feb 2023 12:53:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0zm-0007cj-HZ; Mon, 06 Feb 2023 12:53:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP0zm-0000FO-3N; Mon, 06 Feb 2023 12:53:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP0zm-00083T-2i; Mon, 06 Feb 2023 12:53:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vI4+YXYsDOsRL36eqbZRecbUUpJsE8igYRrmbzGXR/I=; b=hg2lI+Ig9Dbn5bK6DLhRG4MslB BCcZn6jQeBEhgaD1mXoQTKTiwVKhrn8GlgF7HCiOOqxg9C8wuY3DusNrm7b6Wn0NYyx7/b+mzOjXf lg9I4iy1ZNidi1XOSjDncGHWMgBYo8Pq3IINnhgusVqrwogT0Pwsrh8D0PSWNJlEeQBw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176417: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3a59443c1d5ae0677a792c660ccd3796ce036732 X-Osstest-Versions-That: xen=39ee93d21290293712ffb7f7c265df7dcb45b12f From: osstest service owner Date: Mon, 06 Feb 2023 12:53:18 +0000 flight 176417 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176417/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 3a59443c1d5ae0677a792c660ccd3796ce036732 baseline version: xen 39ee93d21290293712ffb7f7c265df7dcb45b12f Last test of basis 176414 2023-02-06 08:00:30 Z 0 days Testing same since 176417 2023-02-06 11:01:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Bernhard Kaindl Christian Lindig Edwin Török Edwin Török Henry Wang jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 39ee93d212..3a59443c1d 3a59443c1d5ae0677a792c660ccd3796ce036732 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 06 12:58:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 12:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490392.759055 (Exim 4.92) (envelope-from ) id 1pP14e-0000cI-GI; Mon, 06 Feb 2023 12:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490392.759055; Mon, 06 Feb 2023 12:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP14e-0000cB-BC; Mon, 06 Feb 2023 12:58:20 +0000 Received: by outflank-mailman (input) for mailman id 490392; Mon, 06 Feb 2023 12:58:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP14c-0000ai-Nr for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 12:58:18 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ece3a134-a61d-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 13:58:17 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id m8so11529257edd.10 for ; Mon, 06 Feb 2023 04:58:17 -0800 (PST) Received: from uni.router.wind (adsl-41.109.242.226.tellas.gr. [109.242.226.41]) by smtp.googlemail.com with ESMTPSA id f28-20020a50a6dc000000b004aaa6a948fcsm2366863edc.37.2023.02.06.04.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 04:58:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ece3a134-a61d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1T2CcOk2cumlPijgcYdo5ZGfLn2kJ62SCoGf7/BdPyY=; b=fM2As6W25qg7X4CAszC6SnCcNzwX9qUo7GO7rX9H5tz+jwZZj2MIxkApmLB9cO/pSq JfoC/7qxCoFJMWpCsA8RvSU0vsbVLdjZrPhAyK0rCwzz/xqBr+OlCvaahakZQzXBhn5R 17ZYWefKlAUvmeS7tgW4BqvkCtmxob9tVwsYxsJbdfBeJC/QPbtUOLxFmFb00N05798+ YcrJsA/o652wClmtATTockxhGPnoEtkFaxL/iB09TAQ+JDvPo7UGZDwWhUNl5i60FPlL ZracdJ/lI5N5Bh/nMMng4MO5WTstULtJthTqwo6GHLjQcdnpbKb/lsdmn4BFOho4WwDs irSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1T2CcOk2cumlPijgcYdo5ZGfLn2kJ62SCoGf7/BdPyY=; b=4RJX9RZ5lJ7epCYCbuUxXbDSN2e1nPpeUbLlMA+G5xRwRizEOVJpAsQDxVlthYVekf c7JUDJh08KJEs2OHZqLReEk0gfJFbpjUBgOuJI0ma8ps2nYlXCUUqw25tv7jMR1LESZi QBHRp9vm0VJJmOHhNJg16Of25VKrArV7GuUKxIuJ1E54e/t50Y1zlIVLyOhEqWZVHdu6 jzuVy4h/6G8I7Bd25D6Xa2qyyG7JRJoXgKeA28jFd0HdQT/X6S4zcNwyQ/Es1vuK304i QdU76yjFE9AeCs/mr+OXKEBfhMAnJV9rf7zyovgYmeY6uaXsTW535GLAjOWgWWoOOzzC UPvQ== X-Gm-Message-State: AO0yUKXIfaB4zi6D5cT3dp7X8XN+XOZ8MdDh4WXt4VHjHp+v+sH0JfRs 4zMHRnC4n9SuOneT8EEd/kniseNsKqA= X-Google-Smtp-Source: AK7set+hHizhlj6+S6dtoqoA1xCwlZZLznwm+66G//pcIbPGN2P3bhN6a0ucbrsYJ8s4IBqPX/jvcQ== X-Received: by 2002:a05:6402:1643:b0:492:8c77:7dad with SMTP id s3-20020a056402164300b004928c777dadmr19361094edx.8.1675688297196; Mon, 06 Feb 2023 04:58:17 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Date: Mon, 6 Feb 2023 14:58:04 +0200 Message-Id: <20230206125804.950528-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APIC virtualization support is currently implemented only for Intel VT-x. To aid future work on separating AMD-V from Intel VT-x code, instead of calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub to the hvm_function_table, named set_virtual_apic_mode (to match the name of the corresponding function in Linux for cross reference). Then, create a wrapper function, called hvm_set_virtual_apic_mode(), to be used by common hvm code. For Intel VT-x, initialize the stub only when either virtual xAPIC mode or virtual x2APIC mode is supported. After the change above, do not include header asm/hvm/vmx/vmx.h as it is not required anymore and resolve subsequent build errors for implicit declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including missing asm/hvm/trace.h header. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/vlapic.c | 6 +++--- xen/arch/x86/hvm/vmx/vmx.c | 4 ++++ xen/arch/x86/include/asm/hvm/hvm.h | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d..34a7eea3a1 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -37,8 +37,8 @@ #include #include #include -#include #include +#include #include #include #include @@ -1165,7 +1165,7 @@ int guest_wrmsr_apic_base(struct vcpu *v, uint64_t value) if ( vlapic_x2apic_mode(vlapic) ) set_x2apic_id(vlapic); - vmx_vlapic_msr_changed(vlapic_vcpu(vlapic)); + hvm_set_virtual_apic_mode(vlapic_vcpu(vlapic)); HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "apic base msr is 0x%016"PRIx64, vlapic->hw.apic_base_msr); @@ -1561,7 +1561,7 @@ static int cf_check lapic_load_hidden(struct domain *d, hvm_domain_context_t *h) unlikely(vlapic_x2apic_mode(s)) ) return -EINVAL; - vmx_vlapic_msr_changed(v); + hvm_set_virtual_apic_mode(v); return 0; } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 270bc98195..6138dc0885 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3011,6 +3011,10 @@ const struct hvm_function_table * __init start_vmx(void) setup_ept_dump(); } + if ( cpu_has_vmx_virtualize_apic_accesses || + cpu_has_vmx_virtualize_x2apic_mode ) + vmx_function_table.set_virtual_apic_mode = vmx_vlapic_msr_changed; + if ( cpu_has_vmx_virtual_intr_delivery ) { vmx_function_table.update_eoi_exit_bitmap = vmx_update_eoi_exit_bitmap; diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 80e4565bd2..b690e2924c 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -217,6 +217,7 @@ struct hvm_function_table { void (*handle_eoi)(uint8_t vector, int isr); int (*pi_update_irte)(const struct vcpu *v, const struct pirq *pirq, uint8_t gvec); + void (*set_virtual_apic_mode)(struct vcpu *v); /*Walk nested p2m */ int (*nhvm_hap_walk_L1_p2m)(struct vcpu *v, paddr_t L2_gpa, @@ -786,6 +787,11 @@ static inline int hvm_pi_update_irte(const struct vcpu *v, return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); } +static inline void hvm_set_virtual_apic_mode(struct vcpu *v) +{ + alternative_vcall(hvm_funcs.set_virtual_apic_mode, v); +} + #else /* CONFIG_HVM */ #define hvm_enabled false -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:02:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490400.759069 (Exim 4.92) (envelope-from ) id 1pP18c-00024i-0F; Mon, 06 Feb 2023 13:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490400.759069; Mon, 06 Feb 2023 13:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP18b-00024b-Tf; Mon, 06 Feb 2023 13:02:25 +0000 Received: by outflank-mailman (input) for mailman id 490400; Mon, 06 Feb 2023 13:02:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP18a-00024O-IJ for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:02:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0620.outbound.protection.outlook.com [2a01:111:f400:fe0c::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e5a0338-a61e-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 14:02:22 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9323.eurprd04.prod.outlook.com (2603:10a6:10:356::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28; Mon, 6 Feb 2023 13:02:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:02:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e5a0338-a61e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qu6ZSQsBEKp+EiIjdo9Mnl/MhAbKJjGeYu7MLb6Rx7hUmY+9aC0bhoHPByczr4CWio4Ek7pOG7qjdM2mDjmHtTolP+2e9uZSaeLJCS7+0KmkL5m77uOZPWyI9/QKxIk2SpLEht3B2GCgGq+8vQUnaGgcgP86GAsSTsW/oOGYigmfaIw1KQp87NMkDM9kMgmiEL8fyUc3QV6JhbtvCQ5Y6mK1ifAJbt4Lk4VECGu7UqPZlffYj6KJwHdn2y7VuRtflpxk5TCVTf0XSMUKULkgojIW4WDg7klRPyTwGqrSTCv3DgcRE9tgZOcupXW0I2K+Fy/ew8l1MxgArk7UDznc9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P2rO2sJBZZ6PuZXWDQhs/j0995OZMo+nliHBXPSk+Ks=; b=BTzmVA0dlXA89YrEH40amRc8ta6buWNWY6M/vZps147z1hJANIxGN6U8A2OcM9LwbeAYsyzVtb3sORE/RgLanKFxHdPnFaAMHx3BR5d3arRvBtt71R2tCKNdh0GusM5YzkCfSVHidd3mLXY3+YNbCdNR556tb7Q7bStPhPZMx1QiflW/Jm8AppxYt8vk4OsVwEfCafAaiEpXovdrTrxxXGWWuB00e183gtA6+GXpIzMKnn4Rl0Vx7N2cnxL3ODu6d+ihlWSyZ//WpvZXO5SfGWtWqo2xDG0RSA8me24RLegd5AEyA16hrygpDIurEUjYZmJYYiTTMQINjWT6T786/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P2rO2sJBZZ6PuZXWDQhs/j0995OZMo+nliHBXPSk+Ks=; b=UuA+YshOF3ywpMEO/wPy2Chjzdvajewc2AaXeg8jgQELemgbobIi+5wOKJtoKBkE4FDPSM6+M7KoV/oWmKflEaCMdBdI5+hXKFhG3DpoGRxJv4XN6fEsPFefN54FCAI8ZzyfBCmVM7tJ2t45UIWorYArjf+X6UStzSMr3FWimq1Gmdyvhwi8dhWYWjHyyIH6IlyFBUTKvJNy+QX9/vUwvCxTKHmJumXa0QUrOrXpyEyq19dHBbub4WeZqaeraFifJRRZVUR5iquHl2AfSsqBXXAYHUChpYr2A7wnyjW44wA8YK3O2hK2LqYK1b9i/EiVeMuPq7Ir006Zjso01yRgCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <610daf0b-8325-ca2b-3c3c-d89338945710@suse.com> Date: Mon, 6 Feb 2023 14:02:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] x86/hygon: do not include asm/hvm/support.h when not used Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230206124251.911744-1-burzalodowa@gmail.com> <20230206124251.911744-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230206124251.911744-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9323:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f53b7e6-28ac-44ae-02c4-08db0842611a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vCoQi3x9aTycYUtBUou3o6Myv6smHRDTc7116Wg8dDPjNxb6ZMXhkDTAUWdgEXZ9fhxazN10TFkK6yPe35+UMONDVCCdtg0xbTy2c3b0z2v1SRWfUoiJ2awIBDJSsXJiGEKBGs/NVMtNHoblSpaKgQjAQaz463pw8uFZEwt98mbnuEUWAAfn+QztIXk8Qoc3xLxy88npR/+qfaUj5J7VOnLbjKIH5C7JRssSEpJKmLIpJEVSh7YF459kXJkZsaiWSz9yazh4qEOm9TDZAp2HnYBRNlj7Qk+RRKvWyXGsCEl2UJmKD1aPwiDRf/jt/4hHw4j371IOGrRmf9tmo+LJbElsxCcCBCxzjZJzesTZ/K2PAOzWrCX7yGiESnb0ZH6hBYQBOuQTq1Tsybywk1gPFeJIOnIXI2z9dBwC8dV6/tA8bnHIsdoBZDGmp2Xy02Xe6UICqFfPlZq+ZKee7SzBc3ZrcWI8QZ2afR6lux/4H+MJSFSDQOu9nCPQM86+XyxbfMoIorsPMdN8ZSKyvgudS3htxvMYffZHNPXXy3A6QuOtTvX0TZC2z/6qB0GzJJ6aBEtcqUWUy3ol44fQXQ456nUyczaN5cPlfbOq11HTOzyYj06vd5E2TIyBWmzjhcOfkVL0uKUtn/XHF0t20qjgNYiSC1TQF1uyaB0qQH03xoWYpNel+QULIeGJVkMFMbZYCBzxn3lqHl5foDzFVJQ+gJehND2AekQjzHt4pXAXTV0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(366004)(346002)(39860400002)(376002)(451199018)(6512007)(186003)(26005)(31686004)(4744005)(6506007)(38100700002)(5660300002)(36756003)(53546011)(8936002)(54906003)(2906002)(2616005)(66556008)(6486002)(316002)(66476007)(478600001)(41300700001)(31696002)(86362001)(83380400001)(66946007)(4326008)(6916009)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDFlZHd0RGhNTzhNRDNUTUxKQVk5Mk1UelFWRUNyalAzZ0dIejRlMms2djFq?= =?utf-8?B?M2NmaVZKejZOeXhmMmNUT1VZbDl5UXBwNjRoTCt3NmNTNnVObUlqMm8xUE9S?= =?utf-8?B?QWJHRFEyUm9UVXZ3Qm4zV0RwNXRvWWJNOE4vcVVLbGZBL0R1Z1BPZmdxN3RZ?= =?utf-8?B?VllwMktqbWFpQUlsS2tCMkEwNEhoYUJkWWh6TC90OXZSWjJiaDZrWEpiWDY4?= =?utf-8?B?SzVUSncyTVdJZG5KUXRQcVoxeTdFL0wwbXFsK0RWYUpoT2RreGw2cXJYYm16?= =?utf-8?B?VDBZWFJHREYwVGNqWHZLRHJKM2J5Tkl0bjFsV0Q0b1BUL1AydndJS1RpcDdx?= =?utf-8?B?aGpHYlFRSEFUY3F6c29LZGRjVUFGTVRsR2R1S0NJYm9Ib0N0L0cxWnJvdi9K?= =?utf-8?B?Nkc0UTVlRnVQdHppWWNGR0NZNFN3c0Jrdm1nSFZQWElHZjVNYXFiVFdPOFpp?= =?utf-8?B?bk9LL2VrYlZnL3F3SUpvb0tUcTRlcXN2d1FsSmpsWWlUM2dhWjkwUTZiUUFs?= =?utf-8?B?NlpUbDByQ0JNamhVRXVjeUwwSUJhUVc5SmFkbVB5cXJMMjdUWkdUNldHMnZp?= =?utf-8?B?c0lzS2lHdk85QTFvTUdQRXRnTWpDYU9vMWd5T1ZLVHdzek1ERUora2JQZEdv?= =?utf-8?B?T1U2YnBmeGhuQ3h2dXpPb1ZVMlJLc1VGNk8vemdoNWEyUS90c2k5UDc0MkVj?= =?utf-8?B?enV1N3ZQcWlxaEZ1NWxQOUxoR1FzMmladmdFWmRFS2F1Ri90UmJiaVppd1pH?= =?utf-8?B?czQvQXBwOWdBUGFVa1FFZDJyaTZWZVBZcnJrbmtIN1hmbnBuMGp3dWdpK1V6?= =?utf-8?B?RnQrSzRTRHFEM2E1Si9nU3hMZ3p3RE1kSXFKVCtvanVaNzVvb1dnaDd1Q3Ey?= =?utf-8?B?Y1piRHd3RTlUckxpZG9GVzgwaXlxaTJETG9JVjNxaTdUeGJJRUlYcjhiQmJC?= =?utf-8?B?M1JtTXN6aVVzTTdodVJzb3lFV256cVExQVd6Zk4xQXVxWmEzMGxjeThkeTBz?= =?utf-8?B?azFlNGtXRDY1MzR2T05oM1NrNVd3T1RFdTQ0bkNYNE92UHhsbWxoRUZjR1ph?= =?utf-8?B?VmpuVS9USHd5amNFNDYrTnV4QnUxdGNzenBvZWIwLzR3WjIzMFhuRjBQRXhm?= =?utf-8?B?aFc0VTNndUpXU2diaWVEaHFEVUVwa1RVUDAybDRha3F5VG5TRVNmbkRlWFdu?= =?utf-8?B?VFZzTFJjYjVnUTMrZHN3d2tJRUpGVEc5Mmwxa0pnNHNXalM2K2c2a1dmT1RZ?= =?utf-8?B?WWh2MWpKa2I0YWNuQlpVQ2orWTJxaC9ZeHJFOHdBaFVhc0lTVlFoOVNHMkFN?= =?utf-8?B?ejl5OEt3T1NJYkZNOXRNamdOQk45eHcrQm96ZjBEamdRNFk4Q1Z4eEVxQmFa?= =?utf-8?B?MXoveWQ1VFd2azgvSUhZL2NsRHlTd3JkbFZQcDc4eTlraTlPMEpubEFiRkdP?= =?utf-8?B?ZmtkZ00xSisxSjlsNWdGeFVLK20wcTc4VzBucXRHUnd3U0JWTU51T1AxbktO?= =?utf-8?B?OUVabVJVVjBCdEg3alVzUTMyU2hNZlR6bGRTSGhtYXdzQ3ZTdEpHbmtDNm1T?= =?utf-8?B?YzRZcFVLOXhCcElwYkx2aExLWS9ERzFqbTRLbDVKUCt2ZEhYcW0zaHh2YzZE?= =?utf-8?B?ZTNuMUpJOVhOMkREN1l6Sk5rcG9YaEZER2lZVk9NOTV5b2FDM2hiWHVEaVJT?= =?utf-8?B?VlhDanNCUTNza2lQVys5Yll5OHRMWDJYenZ4ejcyazVJYTFFZWZaOWJDaHl1?= =?utf-8?B?OWVyZTVTVlFVVk9lalpJVWl0TVdRZFU3SmNzL01pUXBtYnEyc2hqZGwvVVY4?= =?utf-8?B?RUV1Tll5Y2d4ZCtNMTBZb0gvTmlWMkQxdm9uaE1CYVdBc201dERMMy96VlJj?= =?utf-8?B?K1hZK0kzazR2Y2pXdWtnb1FHdko2cUtQOVlZZEhLeXoxZE9FbXgxR3RnMFpH?= =?utf-8?B?WUorQjduZkRjWm9CR1hacm1lUTZ3Rk1HSGhWc2tmdzZDYWFyOFgzVkx1cVJ0?= =?utf-8?B?Rm9VdVdBbmE3NWdoTmNkWmx3S0lIaFVqU3k4ajJiYm54Rit5N291RjhKeVpF?= =?utf-8?B?VklEMCtGT0Y5b1BvTHBSMVM0QWJJNlptTFQzZ3VtV1VIekpSdVBEQ2hoUXB4?= =?utf-8?Q?ykXNsKt0UAVsW9VEgqrk35dzw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f53b7e6-28ac-44ae-02c4-08db0842611a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:02:19.5359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ER6b5iVzOeJO8q3bTebBpBUdeXdE6qNYEluvlWBdAIhK4OzsgUtolPM3bH5MtY3gXZ4ZcgltRuNIMwuOHTU7Gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9323 On 06.02.2023 13:42, Xenia Ragiadakou wrote: > Since none of the declarations and macro definitions in asm/hvm/support.h is > referred in x86/cpu/hygon.c, remove the unnecessary include. > > To resolve the subsequent build error for implicit declaration of wrmsrl() > and rdmsrl() triggered in asm/spec_ctrl.h, replace asm/msr-index.h with > asm/msr.h in asm/spec_ctrl.h's included headers. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:02:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490401.759074 (Exim 4.92) (envelope-from ) id 1pP18c-00028A-8V; Mon, 06 Feb 2023 13:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490401.759074; Mon, 06 Feb 2023 13:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP18c-00027N-53; Mon, 06 Feb 2023 13:02:26 +0000 Received: by outflank-mailman (input) for mailman id 490401; Mon, 06 Feb 2023 13:02:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP18a-00024N-RD for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:02:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7da5d16a-a61e-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 14:02:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7106.eurprd04.prod.outlook.com (2603:10a6:208:191::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 13:01:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:01:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7da5d16a-a61e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2UFhnChCzkM7VNIYHqL1YvmxQYTnGvC8ii4SHQ2+91DLwoBNt69nB6QhXWuwM/FHzRDhMSKt369zFbB046b4nVG6u7l65pOBOCvDDSQEp66Tg3rpORVvJAy/T5DUPPVl0M0xc9ZDD/o0KQbb/V0z1/nxXn/zcIeNkdXPzGuJgp3yYo2PEqXwjqFwE3TIKAI9cq/NVarx4RN8b8WId6VxQyKgytURVrdyJEWexHjjgIxnnQrBRuhacvQmPzv05x7Wggg/S38n6/2aMU4RTX8XSXJCySUj60sP8T0yIjkao73ASQtNpUsKmNwkNRUOJLeXzdTb5EBu8iUCVNy3Pb5hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RUYBT5u2O+lSXz0eh+VZUuWrUKtpKdr8gNbF+5CKt6k=; b=Tk+453IokEbiDeMO1qZ8UQG/WMFTy8yloCMgMhHgDLRdWRJYSGPmz2C1b1ef/fdH8yMIKT0QlfCPXeVn97nCZ+WqUrfN8czXZU3tzeB0eVcJRlRXb4E/lq76OVN1Use7EOdEBjR7o//y7aEUWUl7Z4FphaxImGaOuwTE7z6LyGCWDug+sQ3Jx4Gz8+V0XYxbZta41yE//uJzSqinPJTWMHgEzQNOwfJPpUHb/dJE1AOaab3QRvYQ4+oKZNaRTUstIC24YaKXsI2J9RpLDKI3F1+BWOPJXR98k9Mw4kHJFPGZvnIZqW6FzAa2c8UarkGGAV2nlyKLnJzG7lHeJFy3+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RUYBT5u2O+lSXz0eh+VZUuWrUKtpKdr8gNbF+5CKt6k=; b=I3i6z/gWwfteYZGtz5vilO51hvtpi/GkH5e+tmHGt26p0K4ni5XEZlc1JCNva/ARVPv1GsV4JWKDVJyzlwu9CPPVe4cjRKgExJAQGkivHKF4F+9lupTW2kqQL7riT3lrD23CH1xjJ4oJkT32f+1QRRDDGRU3NHKROHe/aaN8ApX0qgwNJ3nFrwnKDfRCsurmPqgY5i9Zqf9Ri1X2f1gh7j/Kk/Lm7c9QtZm+TPcy+jB+nnZQBa4KgTJXLQCZ2+vvgFmng+AOM3fPpiiLIVURKLMUtMyN1YArSMrE/2ExlT8XaqGj82PdnzW6ilwW2uOEkvhtoIdlB6qp2pjc7k9sYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <90bef569-a49c-fd29-a855-5ef0b93b1056@suse.com> Date: Mon, 6 Feb 2023 14:01:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , xen-devel@lists.xenproject.org References: <20230206124251.911744-1-burzalodowa@gmail.com> <20230206124251.911744-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230206124251.911744-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7106:EE_ X-MS-Office365-Filtering-Correlation-Id: 67cce29d-84e6-4059-87f1-08db0842503c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qSVxVWmfnrQSlISpF/7PUFtk3auDZS0B5zc0o7Krxtxm4P7/2A9qt607fu0ODNmTOHIJfJ0n7iDqPjzLGZdYVFI6uASQMHQLtou8TyUjf2ePuwLzwO6+VQHwB8YKpz6rqq90xi1ofm2Vzlsvk184x02cDpBz4i/fXiFSHChqKBcdVPppprEZvHsGbcgHQt8rd/0gSVcfR6ZiHoDs4FzppZ+3Q2kPYs7xaYOV3SU3zMLWV0vLc1I4zM0gfOISFl17am7/uiv52yHoQELdrjgBtF9KL0HxznvXVU+OZxvV5UzE0RzCspTXDRfjU5ZS82Vxo+zD0eQuJc8ieWvF9yT9M2qsNKdA0tWkTDJoQyFWXfRz+WGbDx4vejP/eW17O7EpAJHj4m8QLRLRzRjmAXHFeshJddg/tT6WO7BG5Z2R9tXsM7TiXaJ0V2ZsQe4fbQUb5WTmPxZjwrHLggCji3+5+EyVDU4Vx7pzMBFsPGqVztt0/YzddetGWd4aXbpJVEoweObAWx12oPuKr7IC6MJ9yD+ckRwkh8P5Ah0oXx1b4Lm7k0Xoa89u2Ob1bz/fUl5uaM4NYNwnRaqPondPrcTdvAxz99Hw5BXJNAdxbSyeIZf6x98Ct3ZTB+msbgSR88SKJNjXgAXBU2dleGX79h9qM2kW6GZKAeD0sigPDZ7oUhV4070gGWcSdGTvrPbVmndrDG2MCO1ek+lDxtdiBxD4Rxfp+7hh2dGKb1peZuvwRmQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199018)(36756003)(6486002)(66946007)(6666004)(316002)(54906003)(8676002)(6506007)(53546011)(4744005)(478600001)(5660300002)(2906002)(66476007)(66556008)(8936002)(6916009)(4326008)(26005)(31696002)(41300700001)(6512007)(38100700002)(86362001)(186003)(2616005)(31686004)(66899018)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzU1bFdNbGwvS1FSWmh1b3lMQmVMNDJ2cXFUS210TFZJTlk5V3Foa25WU2li?= =?utf-8?B?L3V3QytvY3BpWXNRUktIZDExOVp3K0p2K00xSE9IS2c5UkJvY2VWRWtuaG00?= =?utf-8?B?N2E5WkNJaVlKUzlYVjFTL04rR0N2R0R0ZzBUdGJzYnFSNXpzOEhYRlQvQjJX?= =?utf-8?B?NmRaTVMveXhzek41UGRVcGZZZmI3VUszK0F1cUNaWlRDaHNkOUJrbkZqRFNT?= =?utf-8?B?cU4vb0UwdUNJcHk2VjFUeWI3YTZUdjNLOWZtVnRGN3lGTGwxOWN4MDJMZm5E?= =?utf-8?B?aUxlOVRvWVpWZEU1U3JCaE41SUl3ZHJaZE55dFoxNEpFWWtyU0lHbjZhOFFu?= =?utf-8?B?eEh2WjlxbW5sT2R4ME9Dbzh1alZiM29iSkphU20rRzc5MUdCYkdORVJjSmJv?= =?utf-8?B?VXI4VXljNkd5emNhaEx2ay90V1pmamppaXpMQXNBK1dhQ2pYTTNyYkhmOUQ2?= =?utf-8?B?ZUJIcWxNc0trTXR1OUxQU1luZEdLdTE5NEgzcEh2TVN3SlM4Sng2TDRGUFFq?= =?utf-8?B?SXNOaEpQMWhIS2Uwcjc5U09rWEtSRXZnbkhhQ1h5dUVFNnNuRFpCZmk2OFlh?= =?utf-8?B?OXdqelg5YWZHaGJQM2VGNzBOdzduU0dlSmhyYzlGMDNzdFlsUVVRWEVCVnJV?= =?utf-8?B?RG00dUlwdm9uZmlSY20wTGE5VVJBb3NrZHN0VnV1dDBrZHdmM3p3TzFITUNT?= =?utf-8?B?am5meXI3bnBrR2k5YkM5WjBaY1g2MW45eDZkcVRKZHkwRUZuekpTY0FWYXBp?= =?utf-8?B?NjhTUkhlUG9pb2lIK2FZb2JHTlhwaGpHc1FWOTRXSTkzTFZkUk0xMHhVRkJq?= =?utf-8?B?cTlDWEdVYVpaZ25jdnhXZDM2aVFPS1hDWjlMZzEzcUcvV1k3QW9DMDJsY0FE?= =?utf-8?B?bjd5eXBpL0xkOTNnQi9VVENQT2RKVkRyMlZBa0c3MGdrdE5Db0FYbDZSc2sr?= =?utf-8?B?L2ZMRlVENktwT3NDZE5WOHhxc1ZQdi80WnlMQ2F3OHpQTUpLK3grY0pmVUJn?= =?utf-8?B?K1RFL3pxcjNNdkZ6K1A4UzJ3KzRzOVJBZVBlQ0N4TG8vOWlGMkZyMFdpQ3E1?= =?utf-8?B?L1IzaXpRd3JNWlFTUEdabDdmYlg4cWJsaktJd25mcWd2ZGFiOCt1b3pGOEpT?= =?utf-8?B?dmswSE1UYXkycy9hd3RyREtOVDdvT0lYT3JGcnZhd0VNMW9UU2lRRUFmalNY?= =?utf-8?B?L2lkVGUwRHpiZ2tCOExCdmdxdXlnNkF2cjU0Zzg3RHhRdXB6L3F5VlRtY2pK?= =?utf-8?B?cHBVaEVWSTVYWE54QVJyZUpGTXBpSFNIRXpoUkRXWkdlZ01DQ2tjRkppVkds?= =?utf-8?B?ZGRGVjY0eW1ScEd6dWxiS3VkQ1hBb0ZQS0lsYzdRUTBOY3hVQW5NZjhKamQz?= =?utf-8?B?M2RkRFl1K0NOaytMNGFVTkdmMEpjR0pEWkZ3eTMzTHhNQlcwRDBpSGJXeXpn?= =?utf-8?B?NS9KUkQ1bXc2eU9xWnI1RGp1bHpuK3NWc0FhNzFMWHpwWlpKak9jU1g2WHpK?= =?utf-8?B?bGVZVDlGd0xZWCs3S1BKMENBcmhONExxVTZXOUZRRHpsaTF2UjFOWk84VmZW?= =?utf-8?B?ZmhJeDJRWU5WejkzeG02anNIZmJQN2tLcDNrQ0ZndG4zdURLMjNxeFpHVDdW?= =?utf-8?B?dStEZUJaY2cvQVBrbjh2dWlJclpRMThndy9UMDdQakVLYUwwN1BUdWxBelAx?= =?utf-8?B?ZnMzY3hMMHFrbmRhMk5TQmpJMjU2TjBlZG1Xc3dwdWZqakx6RDNiSGcwQ0k0?= =?utf-8?B?SEVPa3V3bGp1WGdJQ0NOZEJ4eGdmTXZydWdPTnZHemRJMlBDTXNMNVVNUFI3?= =?utf-8?B?eUJYcWgxNFBKL0I5dW0wT1pKZlZlbnljSVZHdjRpK1Fnd2p2YkxzUjhITzA1?= =?utf-8?B?cHIrV0trSkx6YnBKWFJTc2dFclhLeEE3RUNPekFuVlRPYjhGWjhvMVgzRFA3?= =?utf-8?B?elNHU043NmFTSVZWWjBCWTlXTVQ4U3ZOb1kwQkJWWWtIQmUyUUVDQUZ2bTJs?= =?utf-8?B?eVhSU254L0JMZ0l2TGdiaUVyZWJBVHU1Ui9nM3czMERBaXhBZmtBeWVhR0NC?= =?utf-8?B?TGVKcFMvQ2dpczJNNTNRcTJYZ0tPa2s1bHVtbHZrWmVwWmpPWWlPamxDKzI3?= =?utf-8?Q?t+VSbc6D1XXykkcis08jNN5ca?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67cce29d-84e6-4059-87f1-08db0842503c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:01:51.1471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VPAbvDZz6JwHilWbUxbK9jPkvMXD/E9j9hBteY59tNv2/kcjYkxXB7CtXkZYmefFVBhGqeLzi143y1jO3N4UeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7106 On 06.02.2023 13:42, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/emul-i8254.c > +++ b/xen/arch/x86/emul-i8254.c > @@ -34,7 +34,7 @@ > #include > #include > #include > -#include > +#include > #include > #include To be honest I'd prefer if only the HVM-specific part of this file had this new #include (and ideally the other hvm/ ones would move there as well, but I can see this being beyond the scope of what you're wanting to do). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:05:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:05:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490416.759091 (Exim 4.92) (envelope-from ) id 1pP1Bl-0003NO-Q3; Mon, 06 Feb 2023 13:05:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490416.759091; Mon, 06 Feb 2023 13:05:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1Bl-0003NH-NR; Mon, 06 Feb 2023 13:05:41 +0000 Received: by outflank-mailman (input) for mailman id 490416; Mon, 06 Feb 2023 13:05:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1Bk-0003N9-Cr for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:05:40 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060f.outbound.protection.outlook.com [2a01:111:f400:7eab::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f31833cd-a61e-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 14:05:39 +0100 (CET) Received: from BN8PR15CA0052.namprd15.prod.outlook.com (2603:10b6:408:80::29) by DS7PR12MB8323.namprd12.prod.outlook.com (2603:10b6:8:ec::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Mon, 6 Feb 2023 13:05:35 +0000 Received: from BN8NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:408:80:cafe::9) by BN8PR15CA0052.outlook.office365.com (2603:10b6:408:80::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Mon, 6 Feb 2023 13:05:35 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT055.mail.protection.outlook.com (10.13.177.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 13:05:35 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 07:05:32 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 05:05:30 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 6 Feb 2023 07:05:29 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f31833cd-a61e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRVf8Bonfm0clHVZ7uDfJGSEaPs9judjQOlECFFj7gF5CLqV6uIOQxmEEzidhF77Qevaup3WCkLXuVkQ67VcxMR9gV5XorJXF3wM4zQ3bYBVMG9T1ZBacpyCvFcsiZzIkP3sOydPlPKARPVp57jEaHavrNf0ncg9MBK1Iw2vuKZ4wNBbxP3+1Tta2uZwSsA8wkQ4qFG0b8YW9yPzhVoGQ4GgiAq0Sp/RqoZDvnSMGXRqM14T+MWyE8k+OvOWym591WQhP6yeN09ukalPGXXAbLSMyOdmY0Sn3ndCIMk6JXufqZ1HgWHZ0AoWgnXF9pLC0g/1Psi7h3RY1wnvXmmDXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fUmcsFJe6MF83JwgO6YoYfEPn008C6+sQIYoOesLnJY=; b=DhYgs2ZLkac416MgWA2EfpQlg4yLI8dMrgw1ZSR7AyvU9RDAK4wvFEIhAOCIkFxHmS7AysLPC6ElfIumoIepAfsVQgLisv1jxQJSQnICZ0Mj94rb4/EX7WXZNiNLgDXt8gAWL/oH/iwRYY7xTNo5OY0to8D81G2gzdb6dCkCT71yrd+Dgxht/3rpEuLv3nklSXZMsIhu5l6bYSkFehTl/tYnktV79D8450lA7nrBm77oOxtSaadRF3TtepBb5ZKB/7bwVfF7I+hoPO0HGxhTdKC2TMq0BTrfw/KnuzI2bH8A9m60WvyVLQEAm+6TVW3FS5ege27cGHODk+GtwR+pQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fUmcsFJe6MF83JwgO6YoYfEPn008C6+sQIYoOesLnJY=; b=keNqaKx5ibD0evTcJ4qMdneoidgR3ZPcGOxRAy9dg38iJkpeUkUF62MnWhKxOQhQz6b6lFnVoyIfDh7dLblodda1dKAt05vKnzTW5luqMo8EIU83wiXOa1BxK2CpaZHvTqg7M9nqLGE7XIUa8CjdeF7eZSNI6qRyGUNiUS5eaTA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic Date: Mon, 6 Feb 2023 14:05:28 +0100 Message-ID: <20230206130528.22401-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT055:EE_|DS7PR12MB8323:EE_ X-MS-Office365-Filtering-Correlation-Id: fc7ff0bc-e7f9-4a3a-957c-08db0842d5ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /R3nVme2bDifSazrMMVFz7mu6gCZCbSCcfYqZFgZySO3HdN4GJ7CIEXM6JY+0dN9uIBJsEGf2usRinjkEhvOTlo/W/Ee5D95CjXziapDsOVFutRM+ebk82Pe80220QPcgVYFnH3lQUH0aKI6MaH7B1FpBMha3nmwFxpl/tQqaQ+4dzHWVWz3J5gB9fSAhNSX2bCJIy3fXQHSt+CjBpnKWzTBlR8QEehXzp9rl/rTY+icuP5D/V2yVH1++yqviPyBNZ1anLB1S7MiLOEBDXzXNUPUpU54+uRx1ch3YJn1OGdhoMFMHxmrApZGjORM9Fw8D4MvNygfKsybVg99QyvxAUd4TN2Vrz8n1nQ5SSupIWShhjMMifkARl7Y1UkRrzcMxOh//gH2pJac/j+9LpMyG1h+TP5TyWwdaL3rc3vMyQ07JdUmynuiroLN6LdE+huOMdb2U6CWTTK9Ziz11SfDq6eQfD4oCvnj5a7PHSznueA4WH/kNlFLkCak27DZ4hALtOwTMtuQPsJoqU87XFk4MNcuhiONqrHKXiY09vxJVkOAOqhcVZFw61P8iyK7WmGfCPtj3We0AhX7pSa7s1nouazsE52vJsqnDZgNYZgEnbwJYIWmJYxqzdsluTKUA+3ZFB2xmD0aVvSNQPn2blC8kP0kucgJ2Y32h5OlF/VJu4TOmSrxJL3FmFNRWuRjXvBFe4QY4Z6mHXKBuOnMaSn1st+gTVhZxALyZjvTYw1Na8Y= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199018)(46966006)(36840700001)(40470700004)(83380400001)(82310400005)(186003)(426003)(40460700003)(36756003)(356005)(40480700001)(86362001)(82740400003)(36860700001)(26005)(336012)(47076005)(81166007)(2616005)(41300700001)(478600001)(70206006)(316002)(54906003)(6916009)(44832011)(4326008)(1076003)(70586007)(8676002)(5660300002)(8936002)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:05:35.2372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc7ff0bc-e7f9-4a3a-957c-08db0842d5ea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8323 This might be helpful in providing additional debugging information (in most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the code to include printing return code in panic message. In create_dom0, move the call to alloc_dom0_vcpu0() to a separate condition and call a meaningful panic message. Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c2b97fa21e20..edca23b986d2 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3874,6 +3874,7 @@ void __init create_domUs(void) }; unsigned int flags = 0U; uint32_t val; + int rc; if ( !dt_device_is_compatible(node, "xen,domain") ) continue; @@ -3966,13 +3967,16 @@ void __init create_domUs(void) */ d = domain_create(++max_init_domid, &d_cfg, flags); if ( IS_ERR(d) ) - panic("Error creating domain %s\n", dt_node_name(node)); + panic("Error creating domain %s (rc = %ld)\n", + dt_node_name(node), PTR_ERR(d)); d->is_console = true; dt_device_set_used_by(node, d->domain_id); - if ( construct_domU(d, node) != 0 ) - panic("Could not set up domain %s\n", dt_node_name(node)); + rc = construct_domU(d, node); + if ( rc ) + panic("Could not set up domain %s (rc = %d)\n", + dt_node_name(node), rc); } } @@ -4060,6 +4064,7 @@ void __init create_dom0(void) .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), }; + int rc; /* The vGIC for DOM0 is exactly emulating the hardware GIC */ dom0_cfg.arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE; @@ -4077,11 +4082,15 @@ void __init create_dom0(void) dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap); - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) ) - panic("Error creating domain 0\n"); + if ( IS_ERR(dom0) ) + panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); + + if ( alloc_dom0_vcpu0(dom0) == NULL ) + panic("Error creating domain 0 vcpu0\n"); - if ( construct_dom0(dom0) != 0) - panic("Could not set up DOM0 guest OS\n"); + rc = construct_dom0(dom0); + if ( rc ) + panic("Could not set up DOM0 guest OS (rc = %d)\n", rc); } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:11:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:11:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490422.759101 (Exim 4.92) (envelope-from ) id 1pP1H0-0004ow-DS; Mon, 06 Feb 2023 13:11:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490422.759101; Mon, 06 Feb 2023 13:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1H0-0004op-AC; Mon, 06 Feb 2023 13:11:06 +0000 Received: by outflank-mailman (input) for mailman id 490422; Mon, 06 Feb 2023 13:11:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1Gz-0004oj-L0 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:11:05 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6104796-a61f-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 14:11:04 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id gr7so34003358ejb.5 for ; Mon, 06 Feb 2023 05:11:04 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id bn18-20020a170906c0d200b0087f68a2681bsm5497250ejb.96.2023.02.06.05.11.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 05:11:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6104796-a61f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6zNTbd2Z2XxmcopTyvxRAuoZZXbDNV1HPXuOoDsllLw=; b=Sgw+wt1y8XkOdY8IiFuukjL7Dt8V092rtqOwV5sfvVXqWWjKSPkRkKQs6Z278n8bJR 2DBLrvQElGaQSdXbU03R25pSe7Crh/EOgMo4pbn7z8SNd+M3M2+CLUDYAj9szAQWLPeM ZuPwyO93NGUW7WEhoBf1SDYAr6u0FpESWkHgRi9sqmd/1Bgm8KBk9S+SU667YG9bHdlF Pxtw9RwG30CRrRd50XwbfWNmgE4SeG41304DRIHMSvhG7/BYmNHXFqqWMCraC8WKGQW/ dzQSyjdoxecPGX6OmRpQWV76OAyYxZ+Bzxemt66/dE4Qt7Jg/5Zy0KXSwvq1elX2Sj7g PhOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6zNTbd2Z2XxmcopTyvxRAuoZZXbDNV1HPXuOoDsllLw=; b=HLuD7w4WLEyAMhfGQeUnfwKPSirHZlrWpbDpk5Wt89u60plaVP4oSRvX83n/tYjbn9 gA/5YYCP6he0GxqiUdaUuRgshiIOZFG39XYJmpvt+dCDnIgeqmC4JA31d09Etnli72e0 AqkV/VEEf7kFIZURRC77Tn+gdHzWRYePtgNA49mQAnYsE4eX0eLHtM/tqIeBQ1GWylQm ZtJClm4K0WjwqNjDhReAG0cZxuuOVxdkjk2ZuYc/8AAYdtCJsFZhJGDNsDptxt7Q3MvF C5jIE0dwDcuoLDKWgFWo4c9IODUIa91aALnLyMCx8WqjzF8x9PZVOKT6XIDyj03w2tlm 8p8w== X-Gm-Message-State: AO0yUKWWJbR+wQf6yZYkxxCVQTV6CKAgD43RnT35TEX5NgnWaMd2wELb Tpy1EkG3439Q3IGWH8dW6Vk= X-Google-Smtp-Source: AK7set9lJM4uZIKi3h9uRVAlK+uEnMCNY/GiyVy1Nd8gLExPwdPBImhOM4lqQayL8rDaFdnO3HvWrg== X-Received: by 2002:a17:906:ee8d:b0:8a4:e0a2:e77f with SMTP id wt13-20020a170906ee8d00b008a4e0a2e77fmr3677810ejb.34.1675689064507; Mon, 06 Feb 2023 05:11:04 -0800 (PST) Message-ID: <5c112f02-37ab-8637-3e61-e5e19f42115d@gmail.com> Date: Mon, 6 Feb 2023 15:11:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , xen-devel@lists.xenproject.org References: <20230206124251.911744-1-burzalodowa@gmail.com> <20230206124251.911744-2-burzalodowa@gmail.com> <90bef569-a49c-fd29-a855-5ef0b93b1056@suse.com> From: Xenia Ragiadakou In-Reply-To: <90bef569-a49c-fd29-a855-5ef0b93b1056@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/6/23 15:01, Jan Beulich wrote: > On 06.02.2023 13:42, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/emul-i8254.c >> +++ b/xen/arch/x86/emul-i8254.c >> @@ -34,7 +34,7 @@ >> #include >> #include >> #include >> -#include >> +#include >> #include >> #include > > To be honest I'd prefer if only the HVM-specific part of this file had > this new #include (and ideally the other hvm/ ones would move there as > well, but I can see this being beyond the scope of what you're wanting > to do). Ah I see. That's ok. I ll move it in v2. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:15:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490429.759113 (Exim 4.92) (envelope-from ) id 1pP1L2-0005Wa-Ub; Mon, 06 Feb 2023 13:15:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490429.759113; Mon, 06 Feb 2023 13:15:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1L2-0005WT-RS; Mon, 06 Feb 2023 13:15:16 +0000 Received: by outflank-mailman (input) for mailman id 490429; Mon, 06 Feb 2023 13:15:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1L2-0005WN-0B for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:15:16 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4972d7b0-a620-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 14:15:14 +0100 (CET) Received: from mail-bn8nam04lp2044.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Feb 2023 08:15:04 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6149.namprd03.prod.outlook.com (2603:10b6:208:30b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 13:14:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:14:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4972d7b0-a620-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675689314; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=9vH0XCdRKZ0INIhUvxn6tuEtgAIYHPSpPQap+Ktx/gc=; b=OLDSr+60hu11fVDQXNbAsYPBDmWe4GLBpdowllxmRuiLlXzV1G3GHGuN ew7zFqG0qSeSBM0KiHlr53egAfaHUsq1+gk/btWm1TL1c7X4mTs2cE1DW +k4wH2sYnnPErCnFI95tqpl0OgDl2v5ooji5RNZhulIA53GObwfJOSMgI M=; X-IronPort-RemoteIP: 104.47.74.44 X-IronPort-MID: 95835787 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nOW/hKlCXBnSwLWVI2CVS8zo5gyjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdCG6DaK6PZTD1KoxyOYy+/E9U7JWDyd9gHlM9rCpjHyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5AGGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 ccKcQldYw6ZvsWnnJW5ae402sUHKfC+aevzulk4pd3YJdAPZMifBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1A3jOSF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNPROblqa416LGV7mY+B00dChy9nfuGukucHPxEL VUz5iV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zpptE1hxeXEtJ7Svbp0pvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzsaoowFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:tAXS/KnHvgijUiHRtKkfbQarhvDpDfNpimdD5ihNYBxZY6Wkfq GV7YEmPHrP41gssR4b+exoR5PwPU80maQV3WBzB8bQYOCZghrLEGgK1+KLqQEIcBeOldK1u5 0QFpSXA7XLfCdHZa6R2mWF+71L+ra6GG/Dv4rj5kYodCUvT5xJqz5+DAPzKDwFeOGFb6BJaq Z1IqB81kqdkbF8VLXLOpB/ZZmmm/T70Kj+ZAIABVoO8RDmt0LQ1JfKVyKA2wsYUXdl3bcm/A H+4nHEz5Tmiei/1hjfk0ja65g+oqqH9vJzQPaUj9QTKHHLlAGlf+1aKtu/lQFwmvir9FEp1O Ptjn4bTrxOwkKURHixvRzunzPtyykj8FjrzVPwuwqZneXJAAgiDtZHh8ZnfgDC60wm1esMqp 524w== X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="95835787" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZk/V49lrdWZGommYyn9ElIcH5bDgpspOOpuXsxlaR8Qq9DHDCn3W3ApEDov3/tGqC27VWqAYYaE2j5H9I/8MyrU/MvvBoZvKUqMM+zOCA9UY54Ky3Fsnv622uhTdnw3mleAuNBWV8qCgqLUiSF+2WmI79uDjXR6aImzynKY08ur0LbXj2733U5muuKv6faQ2SMjMGUsFRLDNRd1n8wnx6uhg1SDGfChdOnGW880b5QqkIKc3AjGSFvoiA/HFv49dtO06qA1vS7U8hAa09CLa2m+F1gK8eXJxVbIFVOoCAfLtsoI8eWTtcRfYlVy/jyIv+iiXhy6OKZvUG3O2KCTjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9vH0XCdRKZ0INIhUvxn6tuEtgAIYHPSpPQap+Ktx/gc=; b=BDelcwAOCeT+PiSx0PP3Sq6vRQe4klAlC3sJyhOu8FwWpQ7sC2ze32w0JCf1muglWvzgXqCekEkAlBjfWuPZYQDc7m9xqITtQC/GwwfOe/aCQv8mSLOJV92RbUHH4VQo1OeczD+dbvNswZ0xcANtUmFb2DtRuIxkA64ecXb7YKVef4KB46CJD8FFBPXdRCIc66YJ4ZDLIr7svUl0KqIogh0z2Dk+j98D6L77tR4byMSemoVoNLUHJu7WmoS3wDWv0sUfGFxluqKbhFjtnECBbFCl2faYp7/b1GYW3dLEUun1K5xc3DU6l4LQhTvSHpy/8nLR/ueX6VXe1DSl74vcLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9vH0XCdRKZ0INIhUvxn6tuEtgAIYHPSpPQap+Ktx/gc=; b=rVjRSbe7hf3gSpQAJN3BITCL17Osa7ACWPqJ7id0LtgUKupCpoUAjiwebN8zrxBIGOdrzoYaBvboRYBeIpcS5ugR8pgz1h+pOw//NlCU3sYqGx5ErvXJ0yBBauFiClQlqT7ITTlORWurYrstm7e0RHnleUXxNe0JJVakdcgFHyM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 6 Feb 2023 13:14:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] x86/time: use public interface TSC mode definitions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <74fb4738-b5bd-ddbe-e376-eeabc84a28be@suse.com> From: Andrew Cooper In-Reply-To: <74fb4738-b5bd-ddbe-e376-eeabc84a28be@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0247.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6149:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f3e9aff-fb57-4a6e-a7a5-08db0844245d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5XRXT8SsF/mNKSqTXUkYlQuOtBq24faCSmTwzk8PdfGUUjscxAb2sU8KwTj+cTp2dsq1KGG21Rvz8ftv+4DbnfBFydUDbK9DCyyiAzZyB7UkIcBgzg6Hse6WxnreubBw//Z7lSYQOintWNVRbbJerRKBb6JbXLGd3FxmArWE0ZY2ScR07pazU7OJzHinrtdiH+5M1XXbBkWNNo25PkUrsYnoAac9q8U2KdU4hQIpf3lk8lwUV4buxnC+ygPfrYc6+CzB1pF4icq2bHzuNzo9buGZtApJ/wya62s/WiHYVo6JjNYH5IaI/6F+lSk2BDCI1rjkqLpNVvsSOPQgAvbdVjOz2j/FsBropx5PnDyCJXx8FvS2Q07oH+s54mlqQirvRDOP634E4oFOBY/dIndRsaR5L8HQ+xYzKSp+YNtAg4cafu+r2XzfDFKhUlt41yambYGC2W9mAAiV3nHZK3aERrC0Z+wB8BM8mfV9ke3BC6lhTmWtXXSddrbmyThwakgNO06JC3GWJMfHVwABejrvPBHAD5IawNMAKeHq2f0f0aukNr8fLRi8m00kH7vlPmIhbdDFSZ5/m6fsHgkhSLCHxO6X17DyHpH5MkncnrUXs8twdtY2v5H8W0PauAbxzSjA0fz6s53CYLsgFVL/BAbGW5vUM1Hgy1xr+bAXYhq2A9QnxYtp+LG9iMRsxzP6AUeR4JXGqK0qYsOy4B1/cguQvlDSdddxBf+6ZY/PYM0kL1k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199018)(66946007)(82960400001)(38100700002)(8936002)(66556008)(41300700001)(66476007)(4326008)(8676002)(2906002)(6506007)(53546011)(186003)(6512007)(26005)(6666004)(2616005)(107886003)(316002)(110136005)(54906003)(478600001)(6486002)(558084003)(36756003)(86362001)(5660300002)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUR5ek9iaUp2WEx0RnNrNFBGbi9sUlZoTCtXcFpMMjgvcDRKQ0RGUGNQeEhW?= =?utf-8?B?cGlPNkp2Qjl1YVB5VXIyMDA3eldGUzE5cCtjM2dPWkd2MGRjSHBzcUEwTTdG?= =?utf-8?B?TFBYNmNxbnBmbWhwVHc0NnJvcUlPMGo2ZE50R2hRVGRmcmlqRE1Bam00Rk9u?= =?utf-8?B?M21GNGtUTC80S0lpR2luN2l6SHdzTXo4MWp1ZHJVVHlJekk3TThzenhnMmtw?= =?utf-8?B?OS9oRTZXbHFxWUQwMTFKbkkydFRoaVl2eGhZaExid0lrdS9DcEd5QVdRc3FQ?= =?utf-8?B?YnZqbmpOMGFCQXdNaXB6dkZhUnJieG5DOXIzbnVwUkNWUFZpdnBxb3k5alhW?= =?utf-8?B?RFpLcWhwaUlYL0lzaHRuZEM4eWNFZUJJb1ZsVFJkd3VINjlaV3NSWi9ZTm56?= =?utf-8?B?WnNkSC85Z3ltN3Z6T3Vkb2VyU2ZMalhHcW9CUy9qYm0ydGl4aldOc04yWFV0?= =?utf-8?B?b1ZJOW14YmxGNHZZOVRaVzhvOEJjQmx0QzZTMjlDWWM0aDBjUEhGKzNhQUJS?= =?utf-8?B?VlFHTVNRQXp3TW9ZVmhvdCtaaGwzazg5Y2ViVVhQQ1B4VWxlSUs2T050OXJm?= =?utf-8?B?enpaNkdUYmlLV3kwbGtlWVE0M1ZDMkM0dWhnRGM5U25BOU9KaEIyazBKQVBN?= =?utf-8?B?bHVMSWo0UkNhTGlBbDc0ZmpJZzhjUWhFT1dNVm0xRUM1Q1FSeTNqZC9WRWt2?= =?utf-8?B?Qks0bTdOOXhHRk9GSW1VU1djamJRd3BZUUxTZjFxNVNzcXJYemYyZ0lCRnVu?= =?utf-8?B?Y05hWFNzRVB2V3I1K3BOQitQcUdXNjFCMDlrV0hWNlE0ZXZMMXlKZzVia0dW?= =?utf-8?B?ZlVLVVMrT0p2dWxYd1NJVTRsY2t0dUFOTzFPOHQzL1pnckFUV29WRk5aQlpU?= =?utf-8?B?b0dwT216RFNZd2s2aS9Gb1ZEUi9hTXF0UGlRZTRIMnpYYWNxWm9KckptOHpS?= =?utf-8?B?SkJSelRHeHVmQU5FT3Z1M2VvR2gxaW1pY0ZMRDlNbW5wS0pLMHFlZjJQMTV5?= =?utf-8?B?SEwxL2wwcnNDbGlrV1ptOXZGaDBsK09FUURsc0RadURhUlIyMkNhaFNnMDBj?= =?utf-8?B?UjhmR3J1UlBlVCt3cERYSlZBazdZS0xrYlV5N2lmNEpveHNwZGl2bmJjSlk3?= =?utf-8?B?azc2L1BrRzg2ZElGWkZPOE0rK2h6VkNFeEtxQTdjYlpLUzZXSUMyalE2cUhq?= =?utf-8?B?cFRBKzZ6bW5vMnJqaVp1T0sveWdMeVRTcTRuRjFxUXR0bURCeFY4cThpbVNZ?= =?utf-8?B?SWRwM3dSbU9MV1JEUFdnR0oxNldMY21QSUJUSXl4TjNFOWdGVHU3WTFCNlNr?= =?utf-8?B?bnhNSk1SeHhLaTBRMTRiVXNrRkl3Y2ZzN0cvR3VZbDl5dVBzVDNjVDNiOHVL?= =?utf-8?B?QnZqTkJocHlUUzJYTVIrNkwxVXNIMC9lbmZubmRiRVFHeXgvaGNRM0hBb0wz?= =?utf-8?B?SWZFZkpqOUREck5yMFBqZzBwYWVDNEJ1VVBwTDlaaVV5aWs1QkpKRzAzNmZY?= =?utf-8?B?TWNyQ1hFRkJOVC9jcUZFQ3hSUnRrNjB4cjNVd0c3bUJIWjBGd3NnL3dGQ1U1?= =?utf-8?B?Qk1OMmxlRVJtRC8vMlgzbEtJYjRPVmxSSkRmVGVDaitJZjRWMDVTcDJvNFpV?= =?utf-8?B?SVF0TVNkN25GdUkxSnQ2c25pTEd2ZVZCN0ZXSm8yTjVCbGxSbVBCVnlleURh?= =?utf-8?B?dDZQQ1FIenlJK211VHN5bVNQTlF3YzlYYzVuVlhTMUtHR2dEZXlPc2hxb2xN?= =?utf-8?B?ekpKU3oyMUpmVkI3WkdOOEh5UEV3MU5xamt1QTZrMVVFL2hMUkFlM21pQUdy?= =?utf-8?B?dEtkNlorTm4wOGpFQmU1bzF3NjRvTmh0KzFoN1FVQUkrOGd4U0hNTmhLZjA0?= =?utf-8?B?Tmo5RnZXN0pjNjlrWHJPbDl0K0J0S2FCa1BQaG9uUGlWT0NUL1phRGlpMnNQ?= =?utf-8?B?VVBPa3NNNk5KbWZpc0xYQlBVcUR0MVl4NjlHTjJDODNoK3ZONWtpUzljR1oy?= =?utf-8?B?YzlybFdSK0t0ZDFKUy9OZkwyVENCaUJkTTNXVEVhWmY5WkJrVVFsaHJMSHMx?= =?utf-8?B?cGIrdmhGYk8xMzQzZGQxUVQxZzRSV2ZPWTJrMEI0ZkpON3E5SFJ3TnV1WmFK?= =?utf-8?B?WFlHUCtGSnFGRTV3UWl0aW1NaWRkdmVDOWszbUExRGpHMDA1dlJVVGhGWVNt?= =?utf-8?B?N2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xnszanliiVFX6Q00qBGEfx0SI/RWPuUs4+Bk3Rsy9Vjfu1HVJhm7efp0BR0scs/GWbQgGZtTJCAKpxG99V63bFUlnMz+WIye36p6UcarDEt3/JnHOYwzuODNtfpTxCBPuyTglo2OjMPbgNOixFu18TxOWDRDf3sgyVZgEjzC4mCAbSJwq6ttkrd8f4wJE/MUnlXaWvxEgx8uU10/+Lk9onsfXF5mXCl0ppN+xB8tthIF/21oEX5Y4IMQul0ADx+oioEmKl7s8wo92R+xVp4tp2qmGICIv5YssL5kxRwEyne2VB5E33x6zkva949wQuOS8yidU7flkS+V95u7xkpq6vjwAyYZOIG5L2EvYt70raQM5TdSUQ0UYdhvA7Gms3w7BfEJsX/90PcF7WSeuTn+1NzHfz0QiVV8D6KX3TqHSozN+3glAdePmPlk9JO5Hd31Xe4YQu3ep35WjwzXYhj2pME3M1Slaqx+Iqdlgw3K4eNQhaYqT9oDc+b0Lo0zTeNsNA9UxnOZJI/pWiVr9UirMBaRZ+kc7EUbcGhcN4i/GuydsYsN0kcweIGHd2HWU7lHVNv6CtSVhEnxJDMmfF940iLmB/1ni5Q2kMfhS5wG8R7tyw4Wl9uLGknYMgsaaKyLpsztwj0Dh4PNPA2CrTHsTVal7AXVXsqLS3g+IRVlSq6jlUYdB+QrA5o3gThEhwVqd3J2tQCOnwbGvVhqZ00RYtjZEdXDn//Ovy3MjgPzmDAa8wRp6p2GuyM2t0cXfE3m21N/l7yJkW5jK7Z7cSCs+c3+4hPcCVAn18Aju5cVDMk170vfEbdmS8b6J5MIWfAU X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f3e9aff-fb57-4a6e-a7a5-08db0844245d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:14:56.7097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 83988VLjIwEOf822CW4rh743tQhWg2t31nF/r9HPMcuKAvKIeMB0Zm/mm8dDhAdaxV8zz3bmwpz4szxgBbJpc8T4gjI6tSnfLwoIrpax1V0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6149 On 06/02/2023 12:31 pm, Jan Beulich wrote: > Now that they're properly represented in the public interface, let's do > away with our private #define-s. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:31:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:31:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490437.759124 (Exim 4.92) (envelope-from ) id 1pP1aw-00083A-EJ; Mon, 06 Feb 2023 13:31:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490437.759124; Mon, 06 Feb 2023 13:31:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1aw-000833-As; Mon, 06 Feb 2023 13:31:42 +0000 Received: by outflank-mailman (input) for mailman id 490437; Mon, 06 Feb 2023 13:31:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1au-00082x-Ub for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:31:41 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060e.outbound.protection.outlook.com [2a01:111:f400:fe1f::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94ac34d8-a622-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 14:31:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9354.eurprd04.prod.outlook.com (2603:10a6:10:36c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 13:31:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:31:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94ac34d8-a622-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/K5a/+dRl+ocyhI78rPqhOJEZ5+Ruz4ZWEoY0t9JctM0MSIBZiHkC2bA+xhjlFOMNUGWnOPJAby5IpMj5iSCMucdg0QOMLO2zIikIGMH7J8SbuQHjhKDi7SQhX6u9kJbOFloUcJodNqpQIaEfX8usmx7K5BSPusm/XW6hgGFN7DwDst/rti/kgWFoNZMZz6FB6IJBZYMZaNFHcThhWJPEQoNJo9ccrSOy/JPYk4yJIE46WMeS/WCb3tOGPWbPgUOX8+SYs00B96KtKWJC4YaaX/uJuN/p95m9IEOy9egnQlOXHy3Cu+8KJ0tg5qRU4c/bZRBgy5KcET8oKVSL2Y3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sygd243Vo/GwduwCHmg7HSqON/WDDmGlIEApJrSrGEo=; b=iEi1RspWB+Q8fo7sT+N++1t8JO01/nmYaVlnPdqn4hgdQkubdu/HH+tp9rVvuRagM1HJ/ABhjtm5jElovqjkVFPH65F3H9k0xvQJ31O2VGi1I7PQZcI31VDo78rtucpqOkSwHX0xjVkqssIYzV612mXmHsrVtwzLexPwPxQWequZif4ZMCMaSZ8JyTX53G9uCDb3yXWVAGTGl1LSW18rOBElUg3XCh6fOVt24bbM42gBar6BY24MabUDoDA0v5wp5FABFYErCGg2Xilc0duhB1i0Xw872KbS5Uz96jJ08sE5hLJ/jUcb9Fh5BOHWZ03j7nWLv78+YpnAmOAOmks59Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sygd243Vo/GwduwCHmg7HSqON/WDDmGlIEApJrSrGEo=; b=0RymhEQNWQBX4iVENFzCXH65PLPupkeC3O3ylB9NAVD4D95rlo0mUYC9/n+rrT7Z/1NDQE5Tdv9fb9h3pzyLGFIJ4Pbs/s2VKWKvcr9epJSLfc/0m62mL5gk17dbQib6GPf05IkjBg+NlAlIDTYs5gQRJHDcq8hK1tgBXOWJ3C6ybLNp0abmmfC9XdDI8FbJ9Fy+JgEI+le0SzjYlHwNJ0sDtN0LDPui618lnbnvbO2d5WtN+lv7NoeoOxClO1n8NroAIGRcONqUvVgHmsssXO53YIuHuzwx2z3RXmPdcxldLGmf61iDNf5VNnDGCzhG2KnKDgu7ucA8WheD3B8r3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Feb 2023 14:31:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH v2] Create a Kconfig option to set preferred reboot method Content-Language: en-US To: Per Bilse Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230125182706.1480160-1-per.bilse@citrix.com> From: Jan Beulich In-Reply-To: <20230125182706.1480160-1-per.bilse@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9354:EE_ X-MS-Office365-Filtering-Correlation-Id: 186098b4-e7c5-4a46-2835-08db084677d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cxEsBBuJteSt0WDyiUvU485yS7wE7iycBa5JmtdEBOk52cTPf/mHWVX+ZCr+jGV/FBM/5Or2RVzifAc+H0FfYq6Mode+oPn3VrsJ2M9u/Zpj4oD4NMePZPyHhIFbTAQ9306m9GkwOnkjJUpe5qi+rKq3nxiIDpSR8kVAHU/EptG6KWNGUo5ZaP2kHMJKJAAsSCbW4XCZBu4+5NxUYfSVVrBxdLr/x+3Y5N1MxPsrWe01aGeSw7KoDw7SekQlJ9GxYYBWtRa7ENXkocOsSUml1H+tJ+Psw9QAPVb1zKN+U+a53oOZtdKgosoVzFov1U/G8obaRd8BGgCM6qXdEddWHSiANqqr8W8+UcKF7ZTFI1v6582VESEYANbVuAyOB4Z1bxwwzgkcX4ChuDHhu9p6eV1Mh4e3VDPMHrwdX1i84P2rMkESDwHQmjAfp86PScQmQ32aUqErY02qYiJ9r4w9J4HDlNCzZZo0idu1I7lChS+RDgIwKiBTeqT8J13GyYxO5G7VezJ0vCGv4a8TkA5lXPjmYRovfvHG/4xfIRzbC+3UOep2OgNlPv58fOJ5267tsxCTohvJUUsoyQfKBXAULjQ8HxsWJlPj+f1rRKZQ9H1FBq2Uhz9C8itr2zQ57mKKHlUzhmH6VvphOUJ5WxiumAVXN9Acs1tEsRlAVuqLKBVy8hesSMapPtEAgna/Pwxbc4hIra/2x3/JqjAS20P9JSvLOAAzAl808f591rOZW9E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(136003)(366004)(396003)(39860400002)(451199018)(31686004)(54906003)(4326008)(66476007)(316002)(66556008)(66946007)(6916009)(36756003)(38100700002)(31696002)(86362001)(2616005)(6512007)(186003)(26005)(8676002)(478600001)(5660300002)(2906002)(41300700001)(8936002)(6506007)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTUzUHU2ZXV1cjJZRDFLUmNLY3lQcHF2NnVxY1M5dkRIelNVZHdUbDQ0STZj?= =?utf-8?B?UW43Q2NvWmkwR1ZGMnA3c0h2YjZwZnU2YmdSVVpETzVKUXU5Vlo0d3M3VnJH?= =?utf-8?B?RjZsblgzVDBKVktVYm9lK2lqM3NFQWdVZVVQeGYyOExQcFozYVpkd1VkY3Jz?= =?utf-8?B?eWxUeG0rVXUzaHdDTEtrZVBSdldWZC9zUjZ0bHgvRk42b1JJeUlQbWxGYXp1?= =?utf-8?B?eTZYU0FpSjRsaTNJL2hpTlU0Q0x4OU1TLzRQUkgrVWNBQWVzZXhIazVwYXBK?= =?utf-8?B?eWgwQThoZUxtS05EbHY2MTNwVFh2QUxFdlpwS3QrRXZ6WFVBMGJ5Qk1rMDZD?= =?utf-8?B?VUdPREFhL0ZiMVhpT1VzZkxEQStheFVJUnQ5eURTbTlCMFV5WGtwa293cHZG?= =?utf-8?B?V1hyanZUeHNTZXR0MkVUME9ZMkxCazNtNTlqVXdrMURJN1A5KzZuWkd3MDJq?= =?utf-8?B?Vy9COTIyWUtVRGV6Rm1IeEdXWm9JUjgzL3R1WWVoQm1xMER5S0hsbjkybzZL?= =?utf-8?B?Q1JLaHlQWG1JS01iR3NNckxEVUp3MjZMWE1wcmpQOGpGMDNLK0Z0cjhXNnVI?= =?utf-8?B?VGNoeDFNQ3JZeFpHZml1WGE3VU4xbGttSVJZejVmRzNtV1EwWllCVTBPV29G?= =?utf-8?B?QVJKTi9RYWVITHhWTVNTMUpRTVBQMFlJZnFkSHFteWozdUh4N2RrQ05xazQ0?= =?utf-8?B?bmhlaFFaM1lzTERid0JtQ2p0TkV4dGpVN1Z4ci8vaEJuUTF4dW11U01oYTJH?= =?utf-8?B?T2JIcVZpVmJOcVU1a1cwaE1PUTNYRWR6amk0enFFTjhYa2F4Wld2a2pJcUZR?= =?utf-8?B?bVlIdDlmczU2WUVYZHBpWWYrNTdMWVZSZWlxcDJtTk9xM2J4ejhoUkxDeDQ5?= =?utf-8?B?NVFGWEFzaHRoT09ob2tIZ3RiNFhlMDVQbHovODlHMmpWdGorR0xiOGIvOHlu?= =?utf-8?B?K1Y3NkpUS2Nkc1hlSW1TT2dKVUxiRE1sa2IyVjVXZ3d2cUxrbVFVUVVRdTlZ?= =?utf-8?B?Zm9oU2QrajgzV05hQlczUlBDdzVDM0pQeVpZcWxnUmdDN3hKWEhGYjZCRWtX?= =?utf-8?B?Ymh6Z3VjSnhzWExWOFJUSjQ2Vm5jU3d0SjJ2Uk1mSUpWVGFaZTBJZSswdkVl?= =?utf-8?B?KyswTWtkMUdHS1JINWVDcWNvU0JwQlRnaVQzVGZJTnVVWHRRejRkTjdwN1ho?= =?utf-8?B?dmRQWjdhUzFqTUNDK2w2RW9Zakw4YUpqWGhNa3JrTkR1Nkt1SXl5cGFTK1lz?= =?utf-8?B?ekJLYmlKbGQ5UGh3YzNkakxWLzZwakhYeG5WajdwNGZCWGMwU1NnazVpYm0z?= =?utf-8?B?cW4rWkJNRFRPQm5KMStQYjBqWUtkVDVMTE90RjZodXJncDE3VWtDY0hQanov?= =?utf-8?B?Q0RxYmZrdGcvakNxaDlmVUlEQUFSTTFYbXEyWW10NjNqRE9CYnFlTW1vM2tz?= =?utf-8?B?VG92dFgrT0NLQ1JGNlM4RWJqOUFWR2ZHNCtWRERPNWo3cnM0U2x1ZEwyV2FZ?= =?utf-8?B?SVhlajRNSXRqZ1JZU1cwUlhkT1Q0VTVaUnJaWjdwZjRBTE1MaFZFcFVWL1Q3?= =?utf-8?B?cUliVVUrZThmbkZMV0hBdkRxb0E1S3R6NGhqSVpjRWdDT2hnT2REZTJDYWtM?= =?utf-8?B?dkpMZ2szSzBZZkJLTElJRjVGYVo3T1cvdnMreklqNWlVaUYwRVh4dGM1bnlI?= =?utf-8?B?UTRzRUI3M01hazFzQmFnMkhTREJvc2tlRVl3STY5azFNWmVsallJLzV6UUVQ?= =?utf-8?B?YXNPS3RrbDJyWGN1czJPR0JNR251SVcrVFVaMUc0R0hHS1hRRys0WEVMcUZ2?= =?utf-8?B?cDF5YS8wU2QraW1tVjVpKzNtMzhqaE0yK3NFdHh4V2ZOdTVoZlNxWCtKTGtu?= =?utf-8?B?cmNvQzRRdFE4bDFEUnBjeWc4Qk5NM2JmaTZsVTVBVTBac1BnTktTNmdiWGxY?= =?utf-8?B?cGcwd3RkcEt1bm1Mc3EzZlJhZ1FGWi91S2o1TkFsSmYxMklHWFhGR01EU2Zl?= =?utf-8?B?MS9QMW14eStTdys3NVVZcXBLUUJRR09yUzRNMU1UUG9Ramt5djVJUCtkcEN5?= =?utf-8?B?WjNrYU1rbTZtOXVGeXFGV29pZ2c4Q3BVT005Vk5iMm1TN1pJd2VJTlJHbENo?= =?utf-8?Q?MS1JF33TUZ963smS4FbiryU8c?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 186098b4-e7c5-4a46-2835-08db084677d5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:31:35.5341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vo2ASNC9aevNYii/bJJEPhjwRjfabQej0Cx1tB+C0No/XDUKQJu+3uPW9w5WPwF+8nPcLdhZwPbs8E6bVZC0Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9354 On 25.01.2023 19:27, Per Bilse wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -306,6 +306,90 @@ config MEM_SHARING > bool "Xen memory sharing support (UNSUPPORTED)" if UNSUPPORTED > depends on HVM > > +config REBOOT_SYSTEM_DEFAULT > + bool "Xen-defined reboot method" > + default y > + help > + Xen will choose the most appropriate reboot method, > + which will be a Xen SCHEDOP hypercall if running as > + a Xen guest, otherwise EFI, ACPI, or by way of the > + keyboard controller, depending on system features. > + Disabling this will allow you to specify how the > + system will be rebooted. > + > +choice > + bool "Reboot method" > + depends on !REBOOT_SYSTEM_DEFAULT > + default REBOOT_METHOD_ACPI > + help > + This is a compiled-in alternative to specifying the > + reboot method on the Xen command line. Specifying a > + method on the command line will override both this > + configuration and the warm boot option below. The way it's constructed right now, I don't think this is true. E.g. "reboot=warm" on the command line isn't going to override "PCI" selected here. It wouldn't even override REBOOT_WARM=n if I'm not mistaken, as the new call to set_reboot_type() would replace what was parsed from the command line. > + none Suppress automatic reboot after panics or crashes > + triple Force a triple fault (init) > + kbd Use the keyboard controller > + acpi Use the RESET_REG in the FADT > + pci Use the so-called "PCI reset register", CF9 > + power Like 'pci' but for a full power-cyle reset > + efi Use the EFI reboot (if running under EFI) > + xen Use Xen SCHEDOP hypercall (if running under Xen as a guest) > + > + config REBOOT_METHOD_NONE > + bool "none" To be honest I don't consider this a reboot "method". The parsing really should be treating this as a boolean (i.e. also permit "0", "false", or "off"). See also "noreboot" as a further (redundant) way of expressing that intention. What is important here is that this control doesn't affect the normal reboot process; it merely suppresses rebooting in case of a crash. While I wouldn't outright nack it, I think this aspect of behavior shouldn't be Kconfig-controlled. The more that it can only be overridden by "no-noreboot" (or similarly off equivalents like "noreboot=off") on the command line, which I guess you agree would be an awkward option to use. (Personally I think we should phase out "noreboot", as "reboot=no" has been around for long enough.) > + config REBOOT_METHOD_TRIPLE > + bool "triple" > + > + config REBOOT_METHOD_KBD > + bool "kbd" > + > + config REBOOT_METHOD_ACPI > + bool "acpi" > + > + config REBOOT_METHOD_PCI > + bool "pci" > + > + config REBOOT_METHOD_POWER > + bool "power" > + > + config REBOOT_METHOD_EFI > + bool "efi" For these prompts: They want to be meaningful to people seeing them. Imo acronyms want to be upper-case (when they're in common use) or be avoided (e.g. "kbd" -> "keyboard controller" or some such). My eye was particularly caught by "power", where I was wondering: What does that mean? > + config REBOOT_METHOD_XEN > + bool "xen" > + depends on !XEN_GUEST Why the "!" here? > +endchoice > + > +config REBOOT_METHOD > + string > + default "none" if REBOOT_METHOD_NONE > + default "triple" if REBOOT_METHOD_TRIPLE > + default "kbd" if REBOOT_METHOD_KBD > + default "acpi" if REBOOT_METHOD_ACPI > + default "pci" if REBOOT_METHOD_PCI > + default "Power" if REBOOT_METHOD_POWER > + default "efi" if REBOOT_METHOD_EFI > + default "xen" if REBOOT_METHOD_XEN > + > +config REBOOT_WARM > + bool "Warm reboot" > + default n > + help > + By default the system will perform a cold reboot. > + Enable this to carry out a warm reboot. This > + configuration will have no effect if a "reboot=" > + string is supplied on the Xen command line; in this > + case the reboot string must include "warm" if a warm > + reboot is desired. > + > +config REBOOT_TEMPERATURE > + string > + default "warm" if REBOOT_WARM > + default "cold" if !REBOOT_WARM && !REBOOT_SYSTEM_DEFAULT Instead of the dependency here, I think REBOOT_WARM should have a "depends on !REBOOT_SYSTEM_DEFAULT". But I view this second control as unnecessary anyway. All you need to do is ... > --- a/xen/arch/x86/shutdown.c > +++ b/xen/arch/x86/shutdown.c > @@ -28,6 +28,19 @@ > #include > #include > > +/* > + * We don't define a compiled-in reboot string if both method and > + * temperature are defaults, in which case we can compile better code. > + */ > +#ifdef CONFIG_REBOOT_METHOD > +#define REBOOT_STR CONFIG_REBOOT_METHOD "," CONFIG_REBOOT_TEMPERATURE > +#else > +#ifdef CONFIG_REBOOT_TEMPERATURE > +#define REBOOT_STR CONFIG_REBOOT_TEMPERATURE > +#endif > +#endif ... construct this accordingly based on REBOOT_WARM. > @@ -42,10 +55,13 @@ enum reboot_type { > static int reboot_mode; > > /* > - * reboot=t[riple] | k[bd] | a[cpi] | p[ci] | n[o] | [e]fi [, [w]arm | [c]old] > + * These constants are duplicated in full in arch/x86/Kconfig, keep in synch. > + * > + * reboot=t[riple] | k[bd] | a[cpi] | p[ci] | P[ower] | n[one] | [e]fi > + * [, [w]arm | [c]old] > * warm Don't set the cold reboot flag > * cold Set the cold reboot flag > - * no Suppress automatic reboot after panics or crashes > + * none Suppress automatic reboot after panics or crashes Why the change from "no" to "none"? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:32:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:32:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490439.759135 (Exim 4.92) (envelope-from ) id 1pP1bV-0008Tl-Ns; Mon, 06 Feb 2023 13:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490439.759135; Mon, 06 Feb 2023 13:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1bV-0008Tc-Kq; Mon, 06 Feb 2023 13:32:17 +0000 Received: by outflank-mailman (input) for mailman id 490439; Mon, 06 Feb 2023 13:32:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1bU-0008L5-Le for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:32:16 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9db4d6d-a622-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 14:32:15 +0100 (CET) Received: from mail-mw2nam10lp2103.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Feb 2023 08:32:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5304.namprd03.prod.outlook.com (2603:10b6:610:9a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 13:32:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9db4d6d-a622-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675690334; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=InO9gJ7kMuXjTwPa9Y6tCCmbMQnhfZbGhGYBO6/nUY8=; b=bbOS/k/3OuWetqA0zHaZFYSK58Zu8EXHRvpdf1HKL+ghUkWgpObXdFSC cOdoX1bUM9ovOOHWZc3MpIWOXfvGYQNMZ7KZ31oOpUdhAXc9NZlwG/5Ps Keg/RkvjAZytAiBz1l986zOcpd38DbVtAWo3oFItkb47TfU+fEsVSj01c o=; X-IronPort-RemoteIP: 104.47.55.103 X-IronPort-MID: 95759350 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aZZNyK3/AQY5oXS5ffbD5Ttwkn2cJEfYwER7XKvMYLTBsI5bpzEGn 2UXXG/UPvuIZjame9wiaY3g9ktSvJ6Bxt5rSFQ4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZmO6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfE3F16 NwGFgk3NzOvxNCQn+24Q6p1v5F2RCXrFNt3VnBI6xj8VK5jZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6KlFcZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKmB99DT+DgnhJsqAWI2zUtLRwYbH+2mNqC03DvY9kCD HVBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/H8pKkjgxSJScxseIa3k9uzHzjzy jKLqSEWhrMPgMpN3KK+lXjEjiytoN7VTwczzgTRQm+hqAh+YeaYi5eA7FHa6bNFM9yfR1zY5 HwcwZHGt6YJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74FI5CEN7VJdyUZJKXg== IronPort-HdrOrdr: A9a23:fBjhpatl1+gwSG6VBUe5uXGQ7skDmtV00zEX/kB9WHVpm5Sj5r iTdPRy73/JYUUqKQodcLG7Sda9qBznhPpICOUqU4tKGTOWwVdAT7sSk7cKoQeQfBEWn9Q1vc wLHsQQNDSzNykdsS+Q2njaLz9U+qjjzEnev5a9854Cd2BXgupbnn1E406gYzBLrMMvP+tJKH JejvA31wZJAx4sH7aG7iJuZZm3mzWO/6iWFyLvwnYcmXqzZffB0s+PL/Beti1uJA+n741SjV T4rw== X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="95759350" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NphLbh23SgsuopA7jSlpMoLEXR/WUTbuWDp5HRUY2yt9QtR2jyM0VDuggLKLnIXVMsABQX+W2Qgi7lOGzI84S39f1fhhcjV8UhENQQZY6SEOk+ZLmQ+HRrFRqYWnwclGMPVl4/clK3Z8Ha/iAcL6h8y7U9da3H+LarYI7ZtkcmM1QzlkwPMxRHPwZkcRPNZr7jFtodvit4xNV67fie0mS1RmX3CMSa7qSwILJTWMfpQh5kND5rizn+Qad2bY2LRZ+tqXO4/DZOasa7gVR+EqW0Wbvnp1+IdFTxICKh5WZFuMzWYqP9DuQvTx9xcXbGJjXZ+d2NwIP87uYreTSfAxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KU26XvtYAlnfDPio15VHdhXYtxe6k0F9zAXGw1cjtX0=; b=gc5XrFjZzmwXzuk6zKA+cZX21QUVUNRCdKR4pJr9KYHkTZoBfS58SlfmoWHvYFivQXstwaOQstKCihVsMJJ9F9kgEC7ipAAuy+Ers3GHD7N6V5sREmILgcLGlFwe+mjrkNXGIdK4jUdr8zN2L9l1LrAZ4vsoGNR4P4tkMq2Wuht0PGcRl2waxpzH44+Zf/45yLEAkrNB5NkZmlYvcAU6G/tngKIZ2JxnpwEpywIzK/CTq451FWvLu7juQNKlbw2B4T8h6nw//lnVRe9Hneanc0pkla2v4lZLjkXjG8Lpdjqpu94BN8GerhRjh+lGqqcf3bzmWxkoRec5a+udVFHNVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KU26XvtYAlnfDPio15VHdhXYtxe6k0F9zAXGw1cjtX0=; b=xR70zH3EsHquIL+++eHnQ8VSetzc19PRP1t1vljtaV7XKYhjNo3XSa1oHmZ/YOjfPpoki5lMok+k68ZvBST7m7zOll8D7BgGxCjAK8hkO+Y0Cx3c0uga9U5H1qDmSqtlO2VJccXghGFBSK2uoieutsBLpNQ+UcInmISA0pYEyC4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <59a9d75b-80fa-a5e7-f085-d9813a10eddf@citrix.com> Date: Mon, 6 Feb 2023 13:32:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230206125804.950528-1-burzalodowa@gmail.com> From: Andrew Cooper In-Reply-To: <20230206125804.950528-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0209.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5304:EE_ X-MS-Office365-Filtering-Correlation-Id: 572a4be0-5735-4c6c-0343-08db08468a79 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 99Ry9GnednHTk77ccVJnmkABQ0lkGFKJ11SyNjjrLFqIMvekWcKkdXLUrEw4CkHR53mjR/WaKlh3vAuBHbczBFICNQeb6uv5H8OLddeH5LpHlyGZNo+RTkSD9Q9jL7TvIItgvZQsZHlpM6L/7puRxUqbyJRdRmvItM0UPsN4K+yWyD8UVV3h0/RCjsSMyMXZ+SCCJfgy/ccjhPwyOZDecF/9Y29i8AR57jAih7xsQ6jd35QP5KyWcMfkQTe0Gsxvy7tdGQ9fGVXMOEcU7hV7WkzDq2QpzY7OvyVBOaflf936xTo9YUvFcQzEnVnlVMaMgAJ7xfnPR3RmmM9gbmNt9Jru+opw0S2aZeMr0L0Ngw2y10S0ldweZKmXHkGblrTxyXhUgFZYlbXEy90Ty/ivNy8scJuITBYh930LVczKeUdJTeKkO1UT/vT0SMXxSIhL8tekpT+sQNQCr6aBzuiN/zctSV2H9hkTMZmAQnnhstveu/PpdKNDJOQ/FYxmrpMbSlz4Gk87TJC8WIjo9jj42ylnJhwK3PGVdrMb9Fgn0r+F7aGqLGNCjNhHpkQsJbc0A/CR/TMl2RU7bdbVcsSjRmeJFFdvGhHWoDTdzb/Ffg8kT5UkoeiuId2zSE2BgaVLetlTudj2VNFrmQqP/qUIjVSK6xZKtiFDBvpW0320HMADsN6p9ciVFcYNrr0Fp5Le7H+ZVC+pYmTzo8rQT59DnHGinNWoPgOg+n3pNpOhpCI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199018)(31686004)(2616005)(38100700002)(316002)(54906003)(5660300002)(83380400001)(31696002)(82960400001)(36756003)(86362001)(8936002)(2906002)(6486002)(66946007)(66476007)(6512007)(26005)(186003)(478600001)(8676002)(4326008)(53546011)(66556008)(6666004)(6506007)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGdCTXRYblJFbE5CS0RRRlc5cklPRWpoRUFHL214cjBTTTgydmNKR0tMOXBL?= =?utf-8?B?S1QvTnkydWtCTFZMQnRKU09FSmhyTGF3RUQ2Mi82c1JGajJSTWdENE4vUENK?= =?utf-8?B?MW51a1NpK2xOTWJiWUtBL1djbDdvKzFGeXdGa2cxTFJXV3NETHZ0UTAxeVQw?= =?utf-8?B?ZEE3WHk3bklOVlVLVXgzYzIyRkRIU3ZIdFI5UHBrM2dOd0hPbkFKQjA0UjN4?= =?utf-8?B?WWVTbmVZN1RSQUdXSjlVREl5WC85QXp3K2svZDFDSHJQU0Z5OUZtUjJYenJ4?= =?utf-8?B?NGx0dXdZNE5SdGdwZW5FaDRRSjV0YldPOHEwWFhPTk5qNWFiMUtyVnJpU29Z?= =?utf-8?B?YSswUVY4T2htK3psSG1DM21jM1pWVllyaTJJY05wNHlaN20wRUdsaFNvNWFP?= =?utf-8?B?N0xUKzJJenRUeURXaDRNdEpmU0xxS2VWU3R4OTAvS1R1clNyb3FHcmlURGxT?= =?utf-8?B?ZE1NRnpXOVkxMzVTSkVGcDE0ZTQ3UXBvM1N4WFQ0dnB6aEFJeVJBdWJrZ2tp?= =?utf-8?B?cWlzOHFQTXpLaE9vek9ZMjhaSUcvYlo3NjlLTkMycGxHL0RBSWp0OHczRWh4?= =?utf-8?B?WDJMc3A4ZWRNTGY1bkFFeTdkQnluZG5IYjR2YlRWWjZWRmp3VEtxSFBuUjFY?= =?utf-8?B?UUxycmpmQ1llVmxpQTlXZWZsQjdQdFcrbWRDRWxXcHJPdHQ5SjBpUE04WTht?= =?utf-8?B?Z0dXMktlUHBvWndEejNNbGtCb3hpeDRaM0xCNzZibTd3VEpvMGtNSXk1cDEr?= =?utf-8?B?YW5HQ1BYVjc5eTBOK0kzSEtXQTVSVnJWVmJDeVFvTklUUDNZV1l2VGF0ZTJj?= =?utf-8?B?aTJKR09oVHRGa3A3T05DRUd2NnFWZC84eTBoNXYvZlVCcVFVcTRKNHpiT21Q?= =?utf-8?B?THQ0c2RnYnhHMElZV0JsLzZRd2hIV2tPQXM2R0dvcVM4dXROODdwZnVaVFV5?= =?utf-8?B?NmdZemJHNUc1N0l4VlJSQUdwZUQ0bEEzOFNCZ0JLZG83bHJQbHBidERRNFBM?= =?utf-8?B?YXhQejFQUWdlVXhGRXY1UCtkU0tWdUtrWlE4dDc2MWozNWNIK245YlNlVmhX?= =?utf-8?B?Z0hhdXpsb3BUMEd2czJzc3FWVlJVYXdZS0dEbUZTemJ4SE1hcDZnRHhsYllV?= =?utf-8?B?eFZzTENhcGR3aUhuVFg1c0IybnlUZ085SUd3SVB4L3Uydk5LNFRXczYrUHlw?= =?utf-8?B?WWw4M1l1eFVZSXJvMENOWUtJbm5GMzY1WkZlMmthVEJUdFMvV2xnWVdZaHJN?= =?utf-8?B?NWNEOGxOeVM5YjExV0NWS1AxQzd1MWJxd09NTTI3Z1JvakR4ME9EeFJuRUQw?= =?utf-8?B?c2JmK2pUcllyY0kvTVhmMDNGYTVQT2xBUmRyVG5IUStxcWpwNkRydy82cnJ0?= =?utf-8?B?a1AwNWc1Q21mWUVoeTB5RUNNTEVQWnY5SFdIVWh4Smh6ZlZoak1lN1dXQ1l1?= =?utf-8?B?dHVSNitxNVFWZzdlUTkxdGh4VzF6TnRhaGFGUnY5WngzOHJYUzZEZ3puOFFt?= =?utf-8?B?ejJha1grcnd2TnlpYU0vVjBoRkpoQit2VWVkb3VkTGFZeU14NmwwajU3MVYx?= =?utf-8?B?N1hnVmhsK0pTRmhkMVB6amZwaExKN0NJM3ViaHlVNkEvTDVGN0I4WWw1UTh1?= =?utf-8?B?Z2VaWTZnWWJvWHA4RWdoZDlmSTlvZTg4ZXZvQXhldXROaFNtUTRYMy9HUnND?= =?utf-8?B?UFRGaWNpbld2YXg4YzFlcTdBNStPWERETHRvRlBzVG83bDRrcGNvVW9UaGJI?= =?utf-8?B?UUhQcDBnZ3BTenE4alRWS09GZnlSM3ZSeEhmRTA1TmdGbFhGTmZMeEVqaXFM?= =?utf-8?B?eEpIUkxzNUIvNWpaSjNsZkcxZzlLQjdjRWlWbFA3ZE4rVVcxTjlWRktxaEhV?= =?utf-8?B?QkVLdXBjMm9oeTU4TGVhK3pMVHhyUzZCMWI3RDV3UnVzZ1Q5NlhZTForSmVE?= =?utf-8?B?anU5a3NiUm9qbWpqbHVhcTF3d2VyaHJqMzdkNENXd1N2Z1pNaUNFcmJEME9U?= =?utf-8?B?dlNrZEt4VjZ2NE9NZllEUDZVbjZQaVZwbTZvdEI5WGp3aFhtaERBMy9hZVp6?= =?utf-8?B?MlByV1J2WHl1dE5FaXpveUgzaXhxanBOTXBKeE9rYjBQekYwKzRPZHJBMEVM?= =?utf-8?B?R3VQT1N4QTZCVnVJcitGV2JoVEpCM1JpSzB5QjcxUllBZ0pMT3l1UWo0SStu?= =?utf-8?B?OEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: alFPSYCtObVmtQb7CFI0j4YES4iGIEoyervTS2NpVriZ/mV+JisAbO8HtsLTnGvkK409jmY6I0/SKbJ48p5naO40h0lz8VX1IgXQlC9sq3lwy959NVjhGU8vxfurTuPVTjsbxkJ5BJy5aNoI7vLSE8upQ0hlTR0TVi8ZBWGwlJoFrK6hEKVCdQ7TDeWi4RWtYRPTUgXRwjcq//qsu5bNQCh/mdanDw6RgXGw+LTlRdsx29iDTWb/MvAH/kiwr2YlfkWBIeSkV9QafkPUeEGNEu8qK44N3r0ST4wf8Gk6S4YV0mTwSBb4EVZUccL70DczNDxV5PJTXh1gi4Dwy0P08OjtkzyjIS0IHloPngMA0iAd910RR0ndaYlJYW+pMpt+mm6OWLHFLOQYvIM94T6SiOS4qiEUyOW/Dq1iVLNCTx0oQddY46Y7LkqSh3u9qFLxnMmeSZr00FfhoT0cfwoLF/upXkw3qXwjZOXgSc+cmlWsUpljGBfY9SBKuQWmOsLOiD9UyRTaVP7tYh1NKkUCr57E003reAXSSmiznW9T7xuHouTgHsqXSv1IALnE+GRSsvN/wIWXKv7kTrsAZiA4wfr+6FVcvR8TD7bI7Qt+wvFawHjkAZiy93HRW+6+W+0/YOoyNtQ9cdCSFW9e+Jsv1xs/Rg2eBwFSa2YloIy7WZz1fCQOPQ90JxwVpPDqA37gSv3Z4Xygjz1XZhXOxnU89R6Y3w/EBiuLVmnGsXgbQm+y9YQDAnJGI/cqURhfPT4tdFxUmiPCTpqyAfhABgvWjdbixCWz8uVpyv1yJPm+WFttCgonsXJwwlA8qdztZq/MmOeM6OFYYSu8OratJMTo31odIjyYgUp5zA64kTYEYWJ375dWVfnWodBS4PII/FNn X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 572a4be0-5735-4c6c-0343-08db08468a79 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:32:06.9476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+Mevp8Vlgb6PUAPuPItpcX6Ihs/AVgEhi4fLgum4WNu/iJTOJ+exoA/xFQxBloHPZ/yWIl4SeFpkRjV836AcrpYO10kKV2EJobdIPPzZhc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5304 On 06/02/2023 12:58 pm, Xenia Ragiadakou wrote: > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index 270bc98195..6138dc0885 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -3011,6 +3011,10 @@ const struct hvm_function_table * __init start_vmx(void) > setup_ept_dump(); > } > > + if ( cpu_has_vmx_virtualize_apic_accesses || > + cpu_has_vmx_virtualize_x2apic_mode ) x2apic_mode is definitely wrong here, but I think apic_accesses is too.  The top of vmx_vlapic_msr_changed() is buggy too. Right now, the hook is called unconditionally.  Given no adjustment in vmx_vlapic_msr_changed(), the new form (using an alternative) needs calling unconditionally too. Naming wise, Linux is fairly bogus too.  This should be hvm_update_vlapic_mode(), but I suspect the hook will disappear in due course. > diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h > index 80e4565bd2..b690e2924c 100644 > --- a/xen/arch/x86/include/asm/hvm/hvm.h > +++ b/xen/arch/x86/include/asm/hvm/hvm.h > @@ -786,6 +787,11 @@ static inline int hvm_pi_update_irte(const struct vcpu *v, > return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); > } > > +static inline void hvm_set_virtual_apic_mode(struct vcpu *v) > +{ > + alternative_vcall(hvm_funcs.set_virtual_apic_mode, v); This has to be something like: if ( hvm_funcs.set_virtual_apic_mode )     alternative_vcall(...) Otherwise, Xen will BUG() every time an SVM guest modifies MSR_APIC_BASE. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:39:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:39:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490450.759146 (Exim 4.92) (envelope-from ) id 1pP1iG-0000xL-Hk; Mon, 06 Feb 2023 13:39:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490450.759146; Mon, 06 Feb 2023 13:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1iG-0000xE-Eg; Mon, 06 Feb 2023 13:39:16 +0000 Received: by outflank-mailman (input) for mailman id 490450; Mon, 06 Feb 2023 13:34:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1dH-0000ke-LP for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:34:07 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecb13344-a622-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 14:34:05 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id y1so10389277wru.2 for ; Mon, 06 Feb 2023 05:34:05 -0800 (PST) Received: from [10.80.2.8] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id p4-20020a5d68c4000000b002c3e4f2ffdbsm3886192wrw.58.2023.02.06.05.34.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 05:34:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecb13344-a622-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tibco.com; s=googleworkspace; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Lz1YQM/V65A11ioBaYbc6K4s50kvUjKP/4O031kUCbw=; b=rVINT2/of2qKlac1Q6VBZ6ux20RzF7iqcPOMFd8HIo8WM9jnXYSKKY4+q/LFZ9up10 Oxp2TmxFiJ+606bsVThrIb3YEQoj7kSyoJrID94qdJ1cZhEoXGEXPu7vLTBB1HOC2WoB bZfbshKtTW5Zs0NkROMkJHtS0n2WP6cYJn/2oZvmuTdeyitODy2mDju816vEpqcYr3Rg wGnmrzck5i1OCLXjmNvMsk2No6jPyqEXadhfIgT4khySahK9mE/7CSKFUmtb0v80RFmV gD9+er+djiL63oedwRInGX7yO3wcIgsPMRppmia4VYiZNAYF/+nDi1LuNwRNHk88A3Bs +eYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lz1YQM/V65A11ioBaYbc6K4s50kvUjKP/4O031kUCbw=; b=KCEygar5v/vhXJpBdIJOqgNm47axySKj1Il5TH2/R4GdHQMe0Vda/GlOoOL5+RRzeD INcf+WVV/nOvdMVe2fY9jq3DzG7i7rFGCgJJGdX+St8p1jiqT6uN35WzNYzmcnD+wPyP V+aOLUIpvkDvHRiqvZ5yAHCMX/5jJ7BiYt9W3+38Ccc4q65gfdJp/EAVWj/rmSvphid4 nsCrZfolEEoL6kUD89X7miuKK/jS6T6I/q0ODgmTvxJfniKgRClpcTeOgAFEZpk+bpf2 lO6gaQrrnmADiDVwhTsZHh+oS9CTIxNht3WMmPAXSOqNbInl/Tv+2Ity5BMEObUwUnFo X0rA== X-Gm-Message-State: AO0yUKX/aoD1zf4qXKX2qG1zFE3xojoBFRww0nFRlJm91hlm0OLXJQAH SFiBYA/IQUudvDqnVtvRqT2ciw== X-Google-Smtp-Source: AK7set/RzzUveeDHSzOdWCnLEArFHeAnUZmW+E6ylhq9Q/cM1Wv00/bWU0RDMOdKXQo8gIHphSs7PA== X-Received: by 2002:a5d:6c63:0:b0:2c3:19f1:77aa with SMTP id r3-20020a5d6c63000000b002c319f177aamr23461271wrz.37.1675690445239; Mon, 06 Feb 2023 05:34:05 -0800 (PST) Message-ID: <39520206-0375-ea2a-709a-992900014705@tibco.com> Date: Mon, 6 Feb 2023 13:34:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] libxl/x86: use public interface TSC mode definitions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> From: Andrew Cooper In-Reply-To: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/02/2023 12:33 pm, Jan Beulich wrote: > Now that they're properly represented in the public interface, stop > using literal numbers. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:45:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490460.759157 (Exim 4.92) (envelope-from ) id 1pP1oV-0002Yf-9p; Mon, 06 Feb 2023 13:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490460.759157; Mon, 06 Feb 2023 13:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1oV-0002YY-79; Mon, 06 Feb 2023 13:45:43 +0000 Received: by outflank-mailman (input) for mailman id 490460; Mon, 06 Feb 2023 13:45:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP1oU-0002YS-Dn for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:45:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a45534d-a624-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 14:45:40 +0100 (CET) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Feb 2023 08:45:33 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5335.namprd03.prod.outlook.com (2603:10b6:610:91::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 13:45:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:45:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a45534d-a624-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675691140; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ZAHp/lI4t8TkQiHunAeTFynX07AwyNhhAq0BWBQF6kU=; b=B94jycVGWJld/PCGcD6sxd0IqTB6Xdj9PxgIpnKoMMeRp9K2sXW/kasQ B72R+NeraVTszF/QiCmIvGF/bT/QNgRsWZ80ZxEy9zT74cPztG/FL7rT7 +juzpBMNs6G6jRjoHG2afUzTgFGeFWHN4Traq3254w40FeTr3kr1B4+o6 M=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 94688837 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IVmMr6spvvqZRj0obCZa7L6lAefnVGtfMUV32f8akzHdYApBsoF/q tZmKWyOafqLY2WkLooiboiyo0IF65SHxoNkGgdpriwwFC0b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWGySFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwFjEONw7Evc6M8pWAcvFVnuABfOTaI9ZK0p1g5Wmx4fcOZ7nmGv2PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60aIC9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzkqK460AbMroAVIARNRVLmh92VsB+7BY59F lEE3S0F9ZFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsTwQf5ML4iJoulR+JRdFmeJNZlfXwEDD0h jyP8i43guxLidZRjv3hu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nX/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:MppvW6C0xssw6X/lHela55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZImPHrP4gr5N0tOpTntAse9qDbnhPxICOoqTNCftWvdyQiVxehZhOOP/9SjIVyaygc078 xdmsNFebnN5DZB7PoT4GODYqkdKNvsytHXuQ8JpU0dPD2DaMtbnndE4h7wKDwOeOHfb6BJaa Z14KB81kKdUEVSVOuXLF8fUdPOotXa/aiWHSLvV3YcmXKzZSrD0s+BLySl X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="94688837" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXJdhhKT3uqjC3ZFkzA/uBz3ovm72btmaU3TN65zds7Qznwi0yGcAwjnQadqhaj+16N3qUp8CzsNFMhQsXgNblhlIpTCerHFsbzx774VOvBO1rB9hcncbanKzYYISHs8dTKA54duLjTR0tLL2HAkCR3wu3+JKjijFQf8fop9jUYGeqrtUD/MGb7fCKjSWFWHE19VGb5Mld8AtMdoUl4VLJccpDhEAInPr/VRBwC7EAwiRA/pYCF/dVibp5/jPgwxJnpngzZ4OFhQ90Al3c1nFMy4792ynlEcJtHKxw+P42qjIvfy7CuNccMCISrvUToaDwZOE/5uR38zvIGO2mYqCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZAHp/lI4t8TkQiHunAeTFynX07AwyNhhAq0BWBQF6kU=; b=e1BniGKbIZyl/z910PUZXmpu46nuQQlf/leuxVGDYM+CcrUljA4hT2+WNs6zwG0Kjsgjyu72poypmeT4IM3uwAxoZtEyFPnRd66OxaN5EMKUY1fLEC7SiV1JUqPfMUDS0RQBai8bTo6RSwVDnOCDCr/08mE1ZrLyt43QKO5VTdMtkXZ0LImxVwktZORvjcA7RtWL3MfC0mectx1/L35rlarLL1sUXQEDSUGIsmOsitDj6jyno08giUwwDxxwe7FQCS8SkJtZIoAlkJKzUiF6WZPtWi26A9jkGbkpqVxv+YWGsLYMzJltf9bctLjLFKZ1P6qbo3SFhE7p3UKKtP+TOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAHp/lI4t8TkQiHunAeTFynX07AwyNhhAq0BWBQF6kU=; b=Rhhe+iTekP4vHnHZ+3a1cN5nuVxLf0xgWWcYMR2I/m3aNXjF+czFqHtpMhBBbBi7xN3achDkpuWm2lLIqBW0PhuQ1AqMaPvZeBgSMrrNWE1HQ5tJyTaAgzzTCWBzlFtHYfhxXzDcnwh5HZZUyeQsAINbOndtAosO1uOTHff0Okc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <8f19c3eb-bb1e-b3b8-926e-caa6b2f2eee5@citrix.com> Date: Mon, 6 Feb 2023 13:45:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] libxl/x86: use public interface TSC mode definitions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , Juergen Gross References: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> From: Andrew Cooper In-Reply-To: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0083.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5335:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aba4131-97bd-481e-bf57-08db084869d3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xM4R3Tmopsc3tDAdMWHOD+JvCKziDHEAAzluKcgDmkZ/MHKmmLazlZWgsGr36NvFen3SFu+YB/F7nLWlQX7wIEbYgMhsMIWYoU/1g3IJM2+HO95txhJ0K0FDongXxgS+wRhlSEqnG70XpWmb/zrsZT1Y67PgNp6+ggdKXvoJtJSpC9FI+A2NDT1IyDw+lzxzIRqMjVpR6fMhXoWEXIF4Z9UEnWp0apg1xEGRruXBXMhG1VYmjpn8dCDGloyPzFHDuQ39Inz+N8Jv6A2lCvCFyLg6RhS9Tpd7GNtsMq+KDKWfWGOfHZQxk+e1+beYTkUkMbIlTCfz9hcDZEFdLF4tNG0rP8GIrnViHUvsBk70orMXefQL9royfDKwHLe3AWeasJfN+ZgGh1dcxPfHuavmwf4CXf1sPab3ELMSlVYk9MV9NL9kTcRxf9MX8e0jcNtPoRiR62LC07zjVoHaoIO2YhDTUS9eM8Y8wJlfTRjX0dl0euYYq+57Kt/peJE1ur0DAG+3QyOJ0J0iOj3S075diWxDgDOt/yaG3Aq/fh0lVbCRus/zpUGNzUAzVz/Go33GtPU6uujUcTc3oHACAAtnUQo0I3p6pXPQyDWTEmSKCBCdy/SC75kEfLwa+n8QknabZFRLLXBtT4296LPbunjc4Ij66ak1N5UU4J0Wsp9RZjh1GtWSkHKpdu3KiODjuluq16NOFduzW6nLvIB/jELD8BU4vMdvboUzJZSWD17XU1Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(451199018)(478600001)(110136005)(316002)(54906003)(6506007)(4744005)(53546011)(6666004)(2616005)(6512007)(26005)(186003)(31686004)(31696002)(36756003)(6486002)(5660300002)(86362001)(82960400001)(38100700002)(66946007)(4326008)(8676002)(2906002)(8936002)(66556008)(41300700001)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1MrL1ZwcE5sdFFRdlppRFNEU0ZHVFFPUmZQSzFTRUE0Z0JpQml3Sk05elFv?= =?utf-8?B?VEtzWXpPR3hRd0Iwc21TcGZtelVwMjhBR1ltZmxYbjQ5cTRmQTZPcmt4aHdU?= =?utf-8?B?VjIwckJBMHhKcUZ2TmRSUGU1MlhXdlVXM2o2UE1XY3ZPaEd4WlhkRmdzL0ww?= =?utf-8?B?clBQeGc1SThIVGRlSlMvL1hIb2srY3RGdElvSUpIK3VTemJXNThJRFljNVFq?= =?utf-8?B?K1RqOTdpUGRLdlhuNENJVVJlbFA1TjUyM29ITTR4Rm1zend2VEJZNWpYMTcz?= =?utf-8?B?L25sRmh0WGxseXdmU2VXcndKZ3FYbExGcG9YUnZ4MzFMLzl4R2xnUVo3eWo5?= =?utf-8?B?WVk4ckhFdTBicDVBMWI0eTlVck9GdWZZY2xkTk5EeVcxRVlBaHdVelh4TXVS?= =?utf-8?B?TXNtSmVRREhzc3crejBqYTRWTlJCdlRJNFpQUlY2amR3eDk4YW9mNDRpaFps?= =?utf-8?B?MU1wc1pJYTdKbitqTUZUekhkQUhndGxWQTI0SG5yU3dMdi9abk02QjdXRno3?= =?utf-8?B?WWRNU25QZ3FsMUZOZ3pobHlBUXMzNjdLRnh1YVdNZmUxYkZkNkJkTG84a0Fr?= =?utf-8?B?SVUvSEpOdzluUHNCZnpodTdiWk1JcXhyQ24zKy9WRjRXOWtVSFBCN0tNVWtU?= =?utf-8?B?cE1NTW03Qmx1QlRBL1RGclhua2FYVkMxRlQ0aVB5QjF6LzhBZW9SRjFMeUJQ?= =?utf-8?B?djVmK2F6OEg0ZWMwZGVGb2NhaktoOE9WMjVlb01kT3JaUjB2Znd0RFN0SitD?= =?utf-8?B?NmtIWHVmWTM5Zll6ZFJHQktyR0lHS0srZFgwSlJtT1pjSXVzWk9Nb3NtV3cy?= =?utf-8?B?cWJUNFZkY2ljT2FWOXU1NHBUMk1hVnZkQ3owM09KenY3TzNOT0xCbXdLT0Ri?= =?utf-8?B?WUtoQVFLV3RlTjc3R2xsOE5BV0h6dEpGK0FTMkcySU1yZXZRME02QUpaSmdI?= =?utf-8?B?Smc2anhTOEVlbTdYVWlINjN0RHRyMzNtU1BYbnFVQjVRSlp5Y21lMCtLQjli?= =?utf-8?B?Q2M4RjFmbU5paXY2a3luNmhhMVVxbWUyMXI3SGkyNko4TnB5T3hlWjBhQjh0?= =?utf-8?B?OHRhSWZqZzJWZzBnd3kwSEdsNDZYZ01tSk1GdDlEcjVMaUZjeUJXVyt0M2ww?= =?utf-8?B?d3MvWmNsMG4xOCtXa0R5UlBkM3dlM1NqUEkyVVpKNm9jbUN6NnlBTWloRm5v?= =?utf-8?B?dzBlQVgxeDd0M2h4czE0QkdGWUQ5N29uMk1EbWl4NzFGWWQ4bDF1bFFEU1Ny?= =?utf-8?B?bEV3MnIxTHQ0MlVzeVo5dWNFTDNjK3NaMlEwNXRMT0VlWmxEQzRWOVlPWGJM?= =?utf-8?B?WXdsQ1FxdWlQTHA1TUxGd0NaMTR0SjNxZ2EvSDFyWnB2OElKN3ZIYU5aRHpq?= =?utf-8?B?bGoxaS9WQUhNdCtaVjlYMkJnRzVWekhSZVRjRUJOdzFLS0d6cU5heWVEeW94?= =?utf-8?B?UzdTekxuN2RUYVhSZjdRd3pncUxIbndWL3dmWTRTK0xHeG9sYTFYMTlkMFM2?= =?utf-8?B?NkhwelcrU1BEbVlKVmJ4QTdXWVoxTVR1UWovL0Mwb1UzMjFjZ1dOUnFhSDBG?= =?utf-8?B?R0hsQzc2UW10empnSHoyVTRwKy9tNGR6cVNWbUdnRkwvOWUyVWRhUi9ESzQr?= =?utf-8?B?S0FLN1ZTWnNqZTgvZFh6V1Z4Y25FcVpEMElpMDBpMy85YWxxbm1XRFBDWE5E?= =?utf-8?B?c0xIMkRZa3RQZkVRd0ROVm92eDdBZzhtNEpWdDlodzJIelRVem82c3Z1SXkv?= =?utf-8?B?Q3k1SENYeVJFamVCaFZabGhWWUFML1FZN1dYZm53L201SURsWlF4Yk8zUkVh?= =?utf-8?B?S05jZk5INi9kNGpxTGF2RHB5TWZ4Tnc1UlF3clhobkxNOUovN01rV25WOVBH?= =?utf-8?B?KzNrVFRCS1ArMVRnbXVSYXdnVHlZNUJCRFpPZXdqb3BZSEI5Nnp1UlRjL256?= =?utf-8?B?MEdjOGNOcG54ZEpVYXg4Mm5EbnNEQjJ3NDBvSkhLaDdGZ3c1WmZmT3pYWUF0?= =?utf-8?B?T2llN2daN015VlM3SWwzVmNjR0grUTd5MGFUZFJkM2k5aUI2L3NQNzU1cXRE?= =?utf-8?B?dlhyZ3ltcjk5ZHJGandLa3d3V0czS0hTcG5MUHNRSDJYZ3Baa3VVbmxYOWhq?= =?utf-8?B?RFc2S2VCYXAwOUlkekdyY3NuZENtNEJvVGIxUVp3anAyZXNWdlMvR0V3Z2Qr?= =?utf-8?B?Umc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oB++t5Li9pndLfD+jxKkvHmbRJF5PHnNCvz2bhFdHIy1FFtXLnPozMDGKeK+rcb5OM/N3C5HrM3QyF6BqDl2QMmizZtuboqXMbvpWgJfXyDLpNluuo/PLfsOoJQIUDjBIyXX3T9mXNUttFL4UYkruW3j8NYiaVvGS4nHRi1x5tfKLcC9lS67BAId3OdlVO7EVjQLUUK7TSLjUMaMNDsGtDGf/8tvoRK3ECkumU8fruUvmutfQstes41hnNgInKbmL0+GjANvWMO8zoQDTVTkLMhX8oj//thmYGssTsSFgN+LpkKZSe4SJm6xwsyYdAvsKOj7mQJ5wnRMIOxDp0rnj1twPJByQjqGr2ze6rmgVjapdQsrWnYmriUUx3NEB/zwWG3daI7aT/PDjwm9xBPxa6uAVRG1PsyOFULsNv7+y8+8b/zuvkJzmAr/UETe7zfc1xZlvQeecLqtMUQEm3xRQfXscgmsN8l6jNt9oVW9+b6ly/u9f1bT5s/6m6va8hTsxHiokZz+HIZHfzAu+2xst/0e5naJfuZbuN5EOV0urglNMWoohOfgrZr1G/1uRPUcEXIyQleor8idYAfkZcNOlk8OCbMG2iEmxf8OpPseDJNF+AkSL0inER898u3Am8JoXddrhAq7BwKEILNqCAhkqmWzBVshtWwam2bcBIvLlTF9HNdyIXmJKLInY/j5azjL+tEQT4QvIwe6Zf9BEezAWdowT5pkuE09/3fLZkxxjgI1HUrRio+qtjmr456dvflDNA/jwILAC5EyYbRFRiOlemiOcSRH6hk2O/KuLGHnsSeubDsM7GNvgmn57qzPbQty X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aba4131-97bd-481e-bf57-08db084869d3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:45:31.2334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eoq0/YmsvbEaezOINXjx5j1Scf7Mcp5QOpQL9PbvVWJkT9/8Mx+Qo5s5OoOgietIDSf0Ty4slOgLD7ZJ/AxbBhgnwEBIJyWp6FuiXJ84bbE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5335 On 06/02/2023 12:33 pm, Jan Beulich wrote: > Now that they're properly represented in the public interface, stop > using literal numbers. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (Take 2, trying to sort out my email aliases properly.) From xen-devel-bounces@lists.xenproject.org Mon Feb 06 13:58:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 13:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490465.759167 (Exim 4.92) (envelope-from ) id 1pP20j-0004Av-ER; Mon, 06 Feb 2023 13:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490465.759167; Mon, 06 Feb 2023 13:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP20j-0004Ao-B4; Mon, 06 Feb 2023 13:58:21 +0000 Received: by outflank-mailman (input) for mailman id 490465; Mon, 06 Feb 2023 13:58:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP20h-00049B-EW for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 13:58:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7d00::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e080ebb-a626-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 14:58:17 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8637.eurprd04.prod.outlook.com (2603:10a6:102:21c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 13:58:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 13:58:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e080ebb-a626-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJrYRecOtZJvyTJivxTgmhGSDLbZcp58THSjLaashuLadpwWBD+Df7cBHp2b/Zfk4vsdcnUesBVsq06eGYId5lZLvj6EPof9y5KP15sfinhRCP0KltY4rZ0knejX5KbikkefbtIkhlLcKkEgtToCV8/1XJQ0oTnn2EvoCgwoFeENe1MG0pWTiS2DXB9K+5grBEhHEwQZNGz5ERQPJS9uMCTyLjV3uA63+J/Sf3c/s8pxV99Y/Q+no8pP0XQLnL0bSiTkoiUgPZr1gzKfQO2d7LbdXYdirNEwZ+wIP0iTm/TINS8oVGoJV5YrihsMzEdd2ypF5q0KfzEuBK+V0Alc0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GzqF5368DTaBhVCL2nvfUNDbe9atO/rOWGiNiaI0vb0=; b=gzTscLW3kly2BHwwjyrRlNv3g6pVirKiPPOrajkeOj1BgHZXPGu6APs1zuvgpkSZHhPVKNDLd17mY3UB5HziqcF+hKh5HhEL5llWiQBxc0y/fntlzY8LiHaUMe9+JNMQKlpNX2/pFIkOy9QrFpwrApNSIQIXlN3NqUCNQiyUvhgcLyii1fBNOcqIB8Io4LSeayVmTHN4EoaibZSfw6mtVyP8eIBMnRZnnbSeCYFAhg09uS0AKJKrwcEadGXbn8nDF44vMyF13zGw4m+N2voFZfPn9qAKyHzf1lo921NImep1md0est6K3tKyTYjP8DAtSIfVGfbRrWMyiuqZzvdOmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzqF5368DTaBhVCL2nvfUNDbe9atO/rOWGiNiaI0vb0=; b=juECzp8pRzgHBBaGhhBGNEAbA1FAFDYO+80rJtKpxVOuyVlUx4INpbYShYiTLXbUfFESO37mfhhDGUUa4ZwcvoS0EcZ3BVJQ0rJJU/xy+wkSsJm8z+5IfbafiMg52fVwnf53Jttl3u2tOAB/8eGjq8eH4xWbTPIjpFYHLqDoBBiYmNLxdpYW+4K0IJqNKAkeONXrMx1QtCldOxI9fD34Wpe3fJ4qIsR+mSRIaULEPdRJso4X4P1mA2Fyf8j0qgUthV8KoBvv0IP+RTbp6xxY284408pzA80t8hWgiMnLzvBayowS5oXEdXGubzAk6ftt+6pAqyGMOcn8K/r1I33jkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <38621f02-83a3-d1dc-560f-905dd0d963b0@suse.com> Date: Mon, 6 Feb 2023 14:58:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/4] x86/spec-ctrl: add logic to issue IBPB on exit to guest Content-Language: en-US To: Andrew Cooper Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima , "xen-devel@lists.xenproject.org" References: <930254a6-d0c8-4910-982a-bfd227187240@suse.com> <8ee98cc0-21d3-100a-ffcc-37cd466e7761@suse.com> <718f6fd0-cb96-6f72-87ff-7382582d89f9@srcf.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8637:EE_ X-MS-Office365-Filtering-Correlation-Id: c850fbc3-9ee6-4df2-473d-08db084a30cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y9Q8jRmq05yNYV9DnsWMa9ePViobilfTF+I03/e0H2MwcTcgWeRkcz5KkCt2gUyzJm849Sby2QnzYfBFmSRpJ07AYWtuPnGC/tcXg8Qv8Tuc5kH571a1nxUMoRYicn1UCNBTNntLBPBhC6zEsZxKSP+BnlT54qU5/1WCFNxmcFA91LJrTB2c6oJ9oHfdO7kQ6IHALgoHlZiToktkPCLfs/G6ziYcAa8QVxO2vaXyIoIDraq58Ccr2gZNR3aECpwqZ2eAXho0tzX0n6Nby5sNNJkrweNVXtaMa97I8AK/XVaVTXMhfQzglbj1sxySHO6+EG9mc5v+Ml2JBWVzWttNgNHeRFc+GzXENmWbP51Pfnj1+HbHaZjqNQUkkmz45hI0AgU9U0OXgNbiyNR7Hq66OIrIPoZde6VzGmxdnsrwx3NHHBTaLX04EGX1/d/gcoaDyOONdUrXKq94aOMlWeuvhyYbfXD/9VYMhMtzcyS+pJ2suovsW2pr7pm2XlAbHJ/b95Io5KRgLtwRW8fH3fqk/3dVK4TGFxT8Ui5S22xOZube0lL/MkqjbymVZH9iRortWKDKvT/cusncHS84lsflfDI0qzdiN7SeybgfACiE0NVefnuoRTzhD08oaEVZh71Y96rrJR3+d1LI92UZ4m4OZESYGGXJbQR0AatQXjTN54CZjpPnlQ+iehgMU1Pe3K094tJ0VY5lMpeV3maGuYL53laNBb00Ll/vh6og2ZRI/TQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199018)(66946007)(83380400001)(38100700002)(66556008)(66476007)(41300700001)(8936002)(6916009)(4326008)(8676002)(2906002)(30864003)(6506007)(53546011)(6512007)(26005)(186003)(6666004)(2616005)(54906003)(478600001)(316002)(6486002)(36756003)(86362001)(5660300002)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkpNclJYby94TUtWSkUvM3BKY0ZGSGRDZG8rV2M0ZmQ3ejBqcnc5M3g4Wlhj?= =?utf-8?B?SmpidjBNWGVzS2N6SC9WenM1VzAvZDUzMXNWSTg4a01uTFdLVDdqTHVaRVFB?= =?utf-8?B?MUMzRU82WlJqdHFhQkpPQmxFOENUWS9aUytZdVJ5UTNRQ2tRSHBTTUVySG1T?= =?utf-8?B?aDZKWm1wUFd0RWUwNS92ams2bEx5TXhzWXpSbm40Y0l5NHdyVjBUUHQvY0Q0?= =?utf-8?B?VEhxMTdGc29NVlJuMW1Ua3BNYnE0Zy9nMVRmMFBPS1hvMTNJNFlkNm5Wd0M1?= =?utf-8?B?WVlQV0kxa09XNTdLeTNuVmdpaGlSVHA3WkFPdU91U0VickVMMHU3WEllWEtt?= =?utf-8?B?NDNVaHdCL09hSXNPUXl6WkNVN2tRbXJRNnJEbzVnc3pLWWFUZWljSXQzNUR5?= =?utf-8?B?THdsUW02ek1ONWNFN3NXRkl0Wjk0VmZzemlEa0FmczJFQzRoY1NRQy82TGF5?= =?utf-8?B?bzhHRkZlSEt4dFBBK3JVZXdpaTZaS0U0cGJwZEdac0U0d3orZlJKWVhrcW1p?= =?utf-8?B?MHJzYmNJQjUvNEhYOVRLZWtPcFZxRVU2Z3hBWjRzVTF0WWdMQTNqMnNzb2Nv?= =?utf-8?B?ZXN1UGQ1QWl1QTdOUGlrczAvNHdBWVYwazBWcWFDNlJ3Y2d4S0J1VEM3cm96?= =?utf-8?B?dy9GaWhSQVhLeVlWYThXRjRIQkxoUlhqSUsyVWQ4Tmc0YnNBVkJhY0pZUi9B?= =?utf-8?B?dlZ2ODdyTlRlbUd0ZjNiZjdPTW13Nk9kS2x6b001N0QrdkJjdFhnNTJiV1V2?= =?utf-8?B?QmNhS3ZrYXhqWnhsVXowQ3FHeXJwbVBKdTZqRzBIbkRQY2xkVGtyb2dwc1Vj?= =?utf-8?B?dkpDd1laSGVGZHhRNUpVMmx2M2h2c3JhS3NBa3BJRE04b0F4czBWNDNwZlFp?= =?utf-8?B?bVVSVEpnU0FjRkRkWXdoOU1pMGdDRmVhN1c4UjhKekJxcElqbnFLZUh4Y01u?= =?utf-8?B?T2RwU2VEcjNOenZHUUwvajhaaC9CenBlQm1SN2JxelU2REZ1aDdtQXRMczFN?= =?utf-8?B?Z2FtRUc2YzlDN1VWd1dHRVZxMFNGSmxiZU1qNmZ4L3ZoMzR3a2xIV3ZzdGUx?= =?utf-8?B?Z3ZiQWYyMWhYNFFqM2hHTjFMdjk1YWNLUERzYjkza0RqM2JKZkI1d2VhTFhi?= =?utf-8?B?V214cno2c2k0bnlVcUJzUDJqNUhIeXRYSTFMWEkzSXp3OTdKQ08rbG9DeGtE?= =?utf-8?B?TzJaN3RJV285TS9rYmVhTHpBQ3ZNOEZWL0dvSGJRRVZQZ0lsc2MwOFdPdys0?= =?utf-8?B?RUFraGRhdnVGRitNV29CT1h2Z3JkM1g2UVl0ay9jODhEYUNzSEdnZEdKdldj?= =?utf-8?B?N3FNOVgzaSs5dklTNlI4cGdVOUNRNldzUzdDYjlYc0lNOTlaWStMK2V6bzEv?= =?utf-8?B?TmVZMG5RU0hVNkFicnNrK2s1WkY1VVRuWkdXVUdPVDFpcU96emtHUGIzMVky?= =?utf-8?B?cFgvSzZLTDJ4bGVFWlJIRlkwUlBqNUFjSkh4STBWQlgrZEVJaVJtRHVpdW50?= =?utf-8?B?SnFFejdDN0pDamhuL1ZCVlNDMXI0MWtqWGRoaVRoS1N0c0Q4SjNLRVNFc3Aw?= =?utf-8?B?Yll3L2VWV3dwUEhOVUZvZXZicWEzM2VJUEovZnZQQ2Flb3FDbm0vQTN1K0U3?= =?utf-8?B?TVQ5elptdTcwelpTamFIZ1p0OXg1RWNBbENuSHpkZkhEeDdwNExLZTZneFRO?= =?utf-8?B?RGs2dGRFa0xmQkRkQzJqRWVQc1dBOWUweThTVFQzbmhaTEFyd2d1S2IzY0l4?= =?utf-8?B?UHlSa01CSlBWRWxsbFhCeGZIbEFGYVlSd3gyTExaUkpaTWpKMWpMeDM3TXg1?= =?utf-8?B?S2lGVEwrblJISzdBQllsRWJvRWlRYWN0SFQyWWExQWZqL1NRcVpKdSs2aW1s?= =?utf-8?B?OGwyNzlWN3h1aXQzbi9uQi9odkVCV09zR3M3eDRKMEdvd2tpQlczd1VENEU1?= =?utf-8?B?a1RybGFCUElXYzhxY05UbENwWEM0NXF4OEFITGM0TjFPamlPQ0RLNTJUUllr?= =?utf-8?B?anVvTzIwcEo5OFovc0YydWZKNEZWWTEzand2NEhwRHFENThwQTdwTjBaTVdp?= =?utf-8?B?aVRjL2lvM1JWUER4U21YNU92aUZoQ2U5a2Z6eWI2alR2T0tGRzRMN2hEVVgw?= =?utf-8?Q?vql+aeSc4EItmzNqlvkv6Z5tI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c850fbc3-9ee6-4df2-473d-08db084a30cb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:58:14.4318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: scZ1d2F6CCQQy5aM1vZ4HvgWjeLt+LfIsDKqOFfd+Q3Mksgki/thkoZor4EnlrXA7F67VSfutQebX7jUq6kzIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8637 On 26.01.2023 21:27, Andrew Cooper wrote: > On 26/01/2023 8:02 am, Jan Beulich wrote: >> On 25.01.2023 22:10, Andrew Cooper wrote: >>> On 25/01/2023 3:25 pm, Jan Beulich wrote: >>>> In order to be able to defer the context switch IBPB to the last >>>> possible point, add logic to the exit-to-guest paths to issue the >>>> barrier there, including the "IBPB doesn't flush the RSB/RAS" >>>> workaround. Since alternatives, for now at least, can't nest, emit JMP >>>> to skip past both constructs where both are needed. This may be more >>>> efficient anyway, as the sequence of NOPs is pretty long. >>> It is very uarch specific as to when a jump is less overhead than a line >>> of nops. >>> >>> In all CPUs liable to be running Xen, even unconditional jumps take up >>> branch prediction resource, because all branch prediction is pre-decode >>> these days, so branch locations/types/destinations all need deriving >>> from %rip and "history" alone. >>> >>> So whether a branch or a line of nops is better is a tradeoff between >>> how much competition there is for branch prediction resource, and how >>> efficiently the CPU can brute-force its way through a long line of nops. >>> >>> But a very interesting datapoint.  It turns out that AMD Zen4 CPUs >>> macrofuse adjacent nops, including longnops, because it reduces the >>> amount of execute/retire resources required.  And a lot of >>> kernel/hypervisor fastpaths have a lot of nops these days. >>> >>> >>> For us, the "can't nest" is singularly more important than any worry >>> about uarch behaviour.  We've frankly got much lower hanging fruit than >>> worring about one branch vs a few nops. >>> >>>> LFENCEs are omitted - for HVM a VM entry is immanent, which already >>>> elsewhere we deem sufficiently serializing an event. For 32-bit PV >>>> we're going through IRET, which ought to be good enough as well. While >>>> 64-bit PV may use SYSRET, there are several more conditional branches >>>> there which are all unprotected. >>> Privilege changes are serialsing-ish, and this behaviour has been >>> guaranteed moving forwards, although not documented coherently. >>> >>> CPL (well - privilege, which includes SMM, root/non-root, etc) is not >>> written speculatively.  So any logic which needs to modify privilege has >>> to block until it is known to be an architectural execution path. >>> >>> This gets us "lfence-like" or "dispatch serialising" behaviour, which is >>> also the reason why INT3 is our go-to speculation halting instruction.  >>> Microcode has to be entirely certain we are going to deliver an >>> interrupt/exception/etc before it can start reading the IDT/etc. >>> >>> Either way, we've been promised that all instructions like IRET, >>> SYS{CALL,RET,ENTER,EXIT}, VM{RUN,LAUNCH,RESUME} (and ERET{U,S} in the >>> future FRED world) do, and shall continue to not execute speculatively. >>> >>> Which in practice means we don't need to worry about Spectre-v1 attack >>> against codepaths which hit an exit-from-xen path, in terms of skipping >>> protections. >>> >>> We do need to be careful about memory accesses and potential double >>> dereferences, but all the data is on the top of the stack for XPTI >>> reasons.  About the only concern is v->arch.msrs->* in the HVM path, and >>> we're fine with the current layout (AFAICT). >>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> I have to admit that I'm not really certain about the placement of the >>>> IBPB wrt the MSR_SPEC_CTRL writes. For now I've simply used "opposite of >>>> entry". >>> It really doesn't matter.  They're independent operations that both need >>> doing, and are fully serialising so can't parallelise. >>> >>> But on this note, WRMSRNS and WRMSRLIST are on the horizon.  The CPUs >>> which implement these instructions are the ones which also ought not to >>> need any adjustments in the exit paths.  So I think it is specifically >>> not worth trying to make any effort to turn *these* WRMSR's into more >>> optimised forms. >>> >>> But WRMSRLIST was designed specifically for this kind of usecase >>> (actually, more for the main context switch path) where you can prepare >>> the list of MSRs in memory, including the ability to conditionally skip >>> certain entries by adjusting the index field. >>> >>> >>> It occurs to me, having written this out, is that what we actually want >>> to do is have slightly custom not-quite-alternative blocks.  We have a >>> sequence of independent code blocks, and a small block at the end that >>> happens to contain an IRET. >>> >>> We could remove the nops at boot time if we treated it as one large >>> region, with the IRET at the end also able to have a variable position, >>> and assembles the "active" blocks tightly from the start.  Complications >>> would include adjusting the IRET extable entry, but this isn't >>> insurmountable.  Entrypoints are a bit more tricky but could be done by >>> packing from the back forward, and adjusting the entry position. >>> >>> Either way, something to ponder.  (It's also possible that it doesn't >>> make a measurable difference until we get to FRED, at which point we >>> have a set of fresh entry-points to write anyway, and a slight glimmer >>> of hope of not needing to pollute them with speculation workarounds...) >>> >>>> Since we're going to run out of SCF_* bits soon and since the new flag >>>> is meaningful only in struct cpu_info's spec_ctrl_flags, we could choose >>>> to widen that field to 16 bits right away and then use bit 8 (or higher) >>>> for the purpose here. >>> I really don't think it matters.  We've got plenty of room, and the >>> flexibility to shuffle, in both structures.  It's absolutely not worth >>> trying to introduce asymmetries to save 1 bit. >> Thanks for all the comments up to here. Just to clarify - I've not spotted >> anything there that would result in me being expected to take any action. > > I'm tempted to suggest dropping the sentence about "might be more > efficient".  It's not necessary at all IMO, and it's probably not > correct if you were to compare an atom microserver vs a big Xeon. Hmm - "might" still isn't "will". ISTR us actually discussing to limit how long a sequence of NOPs we'd tolerate before switching to JMP. >>>> --- a/xen/arch/x86/include/asm/spec_ctrl.h >>>> +++ b/xen/arch/x86/include/asm/spec_ctrl.h >>>> @@ -36,6 +36,8 @@ >>>> #define SCF_verw (1 << 3) >>>> #define SCF_ist_ibpb (1 << 4) >>>> #define SCF_entry_ibpb (1 << 5) >>>> +#define SCF_exit_ibpb_bit 6 >>>> +#define SCF_exit_ibpb (1 << SCF_exit_ibpb_bit) >>> One option to avoid the second define is to use ILOG2() with btrl. >> Specifically not. The assembler doesn't know the conditional operator, >> and the pre-processor won't collapse the expression resulting from >> expanding ilog2(). > > Oh that's dull. > > I suspect we could construct equivalent logic with an .if/.else chain, > but I have no idea if the order of evaluation would be conducive to > doing so as part of evaluating an immediate operand.  We would > specifically not want something that ended looking like `ilog2 const > "btrl $" ",%eax"`, even though I could see how to make that work. > > It would be nice if we could make something suitable here, but if not we > can live with the second _bit constant. How would .if/.else be able to go inside an expression? You can't even put this in a .macro, as that can't be invoked as part of an expression either. >>>> @@ -272,6 +293,14 @@ >>>> #define SPEC_CTRL_EXIT_TO_PV \ >>>> ALTERNATIVE "", \ >>>> DO_SPEC_CTRL_EXIT_TO_GUEST, X86_FEATURE_SC_MSR_PV; \ >>>> + ALTERNATIVE __stringify(jmp PASTE(.Lscexitpv_done, __LINE__)), \ >>>> + __stringify(DO_SPEC_CTRL_EXIT_IBPB \ >>>> + disp=(PASTE(.Lscexitpv_done, __LINE__) - \ >>>> + PASTE(.Lscexitpv_rsb, __LINE__))), \ >>>> + X86_FEATURE_IBPB_EXIT_PV; \ >>>> +PASTE(.Lscexitpv_rsb, __LINE__): \ >>>> + ALTERNATIVE "", DO_OVERWRITE_RSB, X86_BUG_IBPB_NO_RET; \ >>>> +PASTE(.Lscexitpv_done, __LINE__): \ >>>> DO_SPEC_CTRL_COND_VERW >>> What's wrong with the normal %= trick? >> We're in a C macro here which is then used in assembly code. %= only >> works in asm(), though. If we were in an assembler macro, I'd have >> used \@. Yet wrapping the whole thing in an assembler macro would, for >> my taste, hide too much information from the use sites (in particular >> the X86_{FEATURE,BUG}_* which are imo relevant to be visible there). >> >>>   The use of __LINE__ makes this >>> hard to subsequently livepatch, so I'd prefer to avoid it if possible. >> Yes, I was certainly aware this would be a concern. I couldn't think of >> a (forward looking) clean solution, though: Right now we have only one >> use per source file (the native and compat PV entry.S), so we could use >> a context-independent label name. But as you say above, for FRED we're >> likely to get new entry points, and they're likely better placed in the >> same files. > > I was going to suggest using __COUNTER__ but I've just realised why that > wont work. > > But on further consideration, this might be ok for livepatching, so long > as __LINE__ is only ever used with a local label name.  By the time it > has been compiled to a binary, the label name wont survive; only the > resulting displacement will. > > I think we probably want to merge this with TEMP_NAME() (perhaps as > UNIQ_NAME(), as it will have to move elsewhere to become common with > this) to avoid proliferating our livepatching reasoning. Even if I had recalled that we have TEMP_NAME() somewhere, I'd be very hesitant to make anything like that into more generally accessible infrastructure. I consider TEMP_NAME() itself already a too widely exposed. The problem with it is that you can easily end up with two uses as the result of expanding something that's all contained on a single source line. Hence I very specifically want to have uses of __LINE__ only in places where either it is the top level source line, or where - as is the case here - it is clear that no two instance of the same or a similar macro will ever sensibly be put on one line. (Even then there's still the risk of using the C macro inside an assembler macro, where two instances would cause problems. But if such appeared, making the assembler macro suitably use \@ instead shouldn't be overly difficult.) Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:19:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:19:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490477.759184 (Exim 4.92) (envelope-from ) id 1pP2Ko-0006w8-AZ; Mon, 06 Feb 2023 14:19:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490477.759184; Mon, 06 Feb 2023 14:19:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2Ko-0006w1-7v; Mon, 06 Feb 2023 14:19:06 +0000 Received: by outflank-mailman (input) for mailman id 490477; Mon, 06 Feb 2023 14:19:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2Kn-0006vv-7L for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:19:05 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34ea4873-a629-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 15:19:03 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so10866430wmb.4 for ; Mon, 06 Feb 2023 06:19:03 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id m2-20020a056000008200b002bfb7c2430bsm8910528wrx.19.2023.02.06.06.19.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 06:19:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34ea4873-a629-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X8iHri+YNuscdNIt1Fd45F0jYB6Ei8GSOqfqw55T6yw=; b=W3rCxP4jwjYs6Gt/4tRGj/g9AMk11qvxWqNuHivkLnkvLgSyD8wMVoC7SjKea5Zaqs Z2ENMT3ifwP+Tl4DiU8eb7MMS9yO3jpmZjoS0btLbfcslZPGjvrXwLcJAe47qJtOOXuQ ZmFOJ71kS4Od8Jl/YZpuiAxQ8VI4G5KEll0lLRpQwsEduy/t+w2Au8GzB7u3RB9CFAVV +WyGpJd1qwYrmn540SsxxNtf/aEdlgf4z/FS/CZA/caKXh9IoqpFmovSEjAqfw9Oaaxy IVfG+zj8cVfD1EQBqUzNpNncb34N5mkx81I3YXo6av7adCHiwxaecniLuZijBOM1xm+5 OI3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X8iHri+YNuscdNIt1Fd45F0jYB6Ei8GSOqfqw55T6yw=; b=VmiLO4mIUXgbgk5r090xwIxqzzrRYGZxwYuuVUJkm+faEmfODwEYKp9k7ys5SWudX9 GwhQRqvGxKwCBiF+PmoaKLPNbLPalG/eTQ0b+S5U4nI/TBcSTqppLN+Zbp9uWEKfrbPz BqcF1bGmIkfT2my/OwroI3V7Pv0btiLvDWFIpvWFA14Mf0TlFED9HZcbPt6FYS4Of3MF NUXxRRGROxfa1gcA5AD5v7DJ8VSWDkzSW+fhtMVKvQk4ep/x0lJr7lp6bPd/h62ypXed 7cPVPNRFnu0zbGaxZwR9XoJsJNXKQjTMMxo73GSADkegJkv9WtN6T8EQKiKvlPVKXd32 nDww== X-Gm-Message-State: AO0yUKXfGod1XePJZa/yQj39hGHNFg+aftG92VfC/gthznQ7Tv//2N9W 3ZF8p8gME1la3PCybIW3lsE= X-Google-Smtp-Source: AK7set+vsTH4X6KNB+voWBBlc7R4yDV/0EDuEcoCFBc0kM7k65hXWcxjFgBUCSlAzrBI4a1yRnpOkQ== X-Received: by 2002:a05:600c:2141:b0:3de:d52:2cd2 with SMTP id v1-20020a05600c214100b003de0d522cd2mr19191611wml.4.1675693142506; Mon, 06 Feb 2023 06:19:02 -0800 (PST) Message-ID: <382c2db1-d18a-388f-3f52-6eef9b33212a@gmail.com> Date: Mon, 6 Feb 2023 16:18:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230206125804.950528-1-burzalodowa@gmail.com> <59a9d75b-80fa-a5e7-f085-d9813a10eddf@citrix.com> From: Xenia Ragiadakou In-Reply-To: <59a9d75b-80fa-a5e7-f085-d9813a10eddf@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/6/23 15:32, Andrew Cooper wrote: > On 06/02/2023 12:58 pm, Xenia Ragiadakou wrote: >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c >> index 270bc98195..6138dc0885 100644 >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -3011,6 +3011,10 @@ const struct hvm_function_table * __init start_vmx(void) >> setup_ept_dump(); >> } >> >> + if ( cpu_has_vmx_virtualize_apic_accesses || >> + cpu_has_vmx_virtualize_x2apic_mode ) > > x2apic_mode is definitely wrong here, but I think apic_accesses is too. Why? > The top of vmx_vlapic_msr_changed() is buggy too. > > Right now, the hook is called unconditionally.  Given no adjustment in > vmx_vlapic_msr_changed(), the new form (using an alternative) needs > calling unconditionally too. Ok, I will initialize it unconditionally when the vmx_function_table is defined. > > Naming wise, Linux is fairly bogus too.  This should be > hvm_update_vlapic_mode(), but I suspect the hook will disappear in due > course. I can change the name. I gave the same name for cross reference purposes. > >> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h >> index 80e4565bd2..b690e2924c 100644 >> --- a/xen/arch/x86/include/asm/hvm/hvm.h >> +++ b/xen/arch/x86/include/asm/hvm/hvm.h >> @@ -786,6 +787,11 @@ static inline int hvm_pi_update_irte(const struct vcpu *v, >> return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); >> } >> >> +static inline void hvm_set_virtual_apic_mode(struct vcpu *v) >> +{ >> + alternative_vcall(hvm_funcs.set_virtual_apic_mode, v); > > This has to be something like: > > if ( hvm_funcs.set_virtual_apic_mode ) >     alternative_vcall(...) > > Otherwise, Xen will BUG() every time an SVM guest modifies MSR_APIC_BASE. Yes, that's true. I will fix it. > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:25:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490483.759195 (Exim 4.92) (envelope-from ) id 1pP2Qa-0008NY-V1; Mon, 06 Feb 2023 14:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490483.759195; Mon, 06 Feb 2023 14:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2Qa-0008NR-S6; Mon, 06 Feb 2023 14:25:04 +0000 Received: by outflank-mailman (input) for mailman id 490483; Mon, 06 Feb 2023 14:25:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2QZ-0008NL-Vk for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:25:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1a::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a89030c-a62a-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:25:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8815.eurprd04.prod.outlook.com (2603:10a6:102:20e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:24:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:24:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a89030c-a62a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZaOuV/+SiSQlhomcSrrllEIUdpPm5G1RsL9G2yd6jQI1YKvbQfWSz1kl7pNU4JzQQssxT5jqSLYLPPuqb2DhNOVYM1mXe1h8tSDwfA9ojHyPb6KESfwhZxUBwdOZ6yrhHqLp2loOBNM+gv4XFSxOIpMfgcL1DC1Y0ZamQpVrsq8nRcfSORqVfA1IsJgoaqESckhFRaCB/pHTBBmjqV12c21uNSuzp43ww1LHJyT1zEGd8beYYWDikm4A3urwTs98RMfeQEStYa3gJtA9xVO1YfhokZWcN/KXW+fmMAHTEkTUv3KtHzdaAUeFUHckeQ2IApS+Dtmft8iCh1p/UKsavw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kwojmc3mZz6Ur7EYL7dib+qQAccTGS5ed5qfQSWcpw4=; b=HQzRA4dSelBeReAYWMw++khUBtTtmQ0ttFF1pvfX0aCxH2GmL3r0KO9UudGzJO2w1ZVNl3fDKyjVYuyWFJjEbflltp74TY8qY2MoBVGFnnFSHcdoZM3sjnK5rC+yfMTgb43xfkOeYhv7AKVpGsAZoezNj621aamrgDixR/DDdSJPRCDlEDSF3LwEOpAljEM56jBhOVBccd1qOQSzg6bP9KwTdVgU7siyJ32V29Qw0jhi8trOAN9luVjB0axr6I5eWA6GTHd+X9Yl9YsQH9sdb5LhGe8SQ0tk2aQIwCAlHiHktbeTIB87A5Pe+mEKq7wgBYvwd4Xlz8RKOrDOc4w8YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kwojmc3mZz6Ur7EYL7dib+qQAccTGS5ed5qfQSWcpw4=; b=kjPT08LEF4CMOcMfitULRGwGlcUeOdsQeP4GotnE1Ra8aGnlWQ9Bvg7DWIJTltY+inDtwVgyNLspeF7PLbIX+oHb70QQGiGpLjOe+FqopfsWMmDyEISynb2tlK1KbJGCwzo91iEhPTJm/8MbMSeQL1EvHJvGjJeDwsCFxuWknF+yNtdryk8unu4C06HdQ6yrhJ6XqX0hxPdEgsuMC+K2E1lG3iDcw3ci9GMKJ7m/jBVnG0JPohDwcv4pxH2xqiaNh5nZN6ZzSugX/lmHZExwFg3Krr4tpRZdjXEYMmx2CWoaD/dfXWpNsyEQdhKIWXX59aTyjVihV+ycm/vzqWMqqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15cdfa52-03fb-0052-4389-0781422b37f2@suse.com> Date: Mon, 6 Feb 2023 15:24:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 2/4] x86/spec-ctrl: defer context-switch IBPB until guest entry Content-Language: en-US To: Andrew Cooper Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <930254a6-d0c8-4910-982a-bfd227187240@suse.com> <23ea08db-3b64-5d1a-6743-19abb7bd6529@suse.com> <8b4c6aa8-cdc5-50a3-2170-f4af80fe1a26@srcf.net> From: Jan Beulich In-Reply-To: <8b4c6aa8-cdc5-50a3-2170-f4af80fe1a26@srcf.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8815:EE_ X-MS-Office365-Filtering-Correlation-Id: 23c64ec7-7cd4-4720-29b7-08db084ded2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iildtqJhvAdp6MG6BEqthxkkF/WUZC4Sh4LPGYVySpzJ64DJT3UXJk9gWp/JE652eHfMoM7Xs/TsLUUW1AoV/6Eaa6Ff3qHW8Kq1dxvAZwkqr7pZHWE7LF5lFPComFaIsksT3QVFFxHZXsaCKZ6jc45lzfRZJxcFxGqMnwu2Cp3vqShVCVRRJjsc/syOPpTU31sZE1ATrgBovLyS7dtLXqA3XerMprDm1ihRC2MrbgQcM8H+KoJtke6Bek8m9KLT6lkeSL0DAqErIUiiALQEVict4J3foj2cO6hUHkaJpAq6A40vS18i1+11pxuVWITE8qtg/JQQBtw5kDRumynmgxck1cqIHiqzbnPZ93VJ4eAcDr4ytYRn4JpqgilZsh9c3iQCtWBz6yOREgxJCiwOm8Orkm0WqK5sWSsQ9sjxPO0FR/OCx7uCZM1ECbLzoVrgcvDzSOorcq5R0p9Yy2b/lgC17i0r+SX7p8eN+NVd5YZEb4z5lk/6L76vH/sOmlJY3WeAecem+74AFlJZQSD1b6QK2vPRHHfA/gvlC9A2XU6nStjsCTTwSYSbGruiGs+2JmkQaL6mv1jtQnOrWVi2vJUq1piCtwr9sGFtsb4o5uav1CV0DiQJltwSnfXkhmbf+YlzW1JxXvQjM5NKZKa+i/0L2D9O8LgX+Klc541YpLmlcS/EA+trkQQGdwS6bWPNcJrTFU28kp3a9EOFRBUlO6/s1FEQuW5r2AHVsaxcoT0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199018)(186003)(66946007)(38100700002)(83380400001)(5660300002)(6916009)(41300700001)(6506007)(2906002)(66476007)(66556008)(4326008)(8936002)(8676002)(6666004)(6486002)(478600001)(53546011)(2616005)(26005)(31696002)(6512007)(86362001)(316002)(54906003)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk15Y0xnaDJ4QXY2T055OVZyeVpyS3B5ZWR4eXZQQ2NjNS9TS1pxT045SG4w?= =?utf-8?B?MUxVMGl0ZXgwUmlCYmJpV1ZKdVVVWFVlT1RFY0VGUW8vYVNlTEppODFOR1Zl?= =?utf-8?B?U1dVdWhiaWFMYWtlQUh0V2FaWFpUc1lDbHQ2c3BKMURQRGRkN0NQcXdkTjNI?= =?utf-8?B?ZjNzK1k2TE11QzBDOW1XKys1WDREYms5YVllOWZxZHJCamFEbVFuWGw1dC9q?= =?utf-8?B?RWIzbTZCbjUwR3BpLzEwemg5VWxrb2RWWnhYRGJZUVRva1IxMEdmamlsaXVT?= =?utf-8?B?TjNYTlU5ZHA4eFUrN0loS04veFN0OFh5YXNBYXpMd3c1aEZFbWgvTlVVVXRU?= =?utf-8?B?Q1BvUlVJWmRFdXNybDBjM0dMejRrVjJjNWNtQmUwTjdlMVh2aWoxNm9LMGxx?= =?utf-8?B?bTZNYk05TWNhRmlPTEhzZEtSeDhQSWZvcnlmNDNTb3MyWU03WVBORk9xbFQ5?= =?utf-8?B?WFVMYnNrR2tnWHNMRFZUc3Uxa0Jjcm1tY2hrTk5CbFczbysyT0pXMGZaRWwx?= =?utf-8?B?c3hNU0xZQS80bVRLWjRodHh2aEZIUDRqRlIyRUtyK3hKaTlLU3JyOUYyWWFj?= =?utf-8?B?YXdoOXpvRDBlMUdmMHV2ZjRwbXNCbXpURDdHVGYwMm44Q2dYYnloZDJ4YmN1?= =?utf-8?B?WTV1YnhDcDZVQXpKWWpybkszc04zQTRBVlpzOUJ3c2VUam1FY0pNRFdhSkQr?= =?utf-8?B?b3pSZFRobm1yNktqRnZ0ZUdlMWN4aHJaR2VOUElvMG9DTWVIMjB3UDVFQXB5?= =?utf-8?B?V0owNjdUeGNJTHNnZ2RCeEVNeGJaZ2ZaT1oxZ3JoQkk4WnJUdi92dHdDV1R2?= =?utf-8?B?S0thYy8wVEEvWkw0Y3RXR0k5UXlnV0JmTU40MWpPc2NWMjRER2pVbmhYQXhK?= =?utf-8?B?Yll4M0xTL2lZTlBoNVBpSG11KzdUYU9uSm9ULzJsQVhBaHpKWmUxOEZZWFM0?= =?utf-8?B?N2xBTEUyWTBPM3BWTytCV3hGejU5RTFpTkk1Rk5BTTlJeXluSk1nU1I1dXN2?= =?utf-8?B?MGJDalNmYlNrdWttakp3V2xMNklZSThxamM2azFCKzRBdDN0NmkvNlhrVnJr?= =?utf-8?B?R3EyMDVEeWJRY2wvQXM1M1U5R0JaSWZOM3ZLcnA0RW42YUFtV2NWeXBic0tF?= =?utf-8?B?eE9ZV1VsM3FPUUY0bTg3TndLOFRHZU5ZQ3ErSkpXcHB3VFovcXpTcW83SzJS?= =?utf-8?B?M1AzZmNjQjhQTjlXREU4WDBFUjkwZDQ2UGFkSVY5dE9ORDc5MlR2OVppaU9j?= =?utf-8?B?cUx3S0FVWk5NZzZRK29ueitWYVpWSHZYamFFNExGdzcxdm9DU2lZRGdWT1VR?= =?utf-8?B?RGhhZkRYTVdCWjBSYm9SM2NMMFF5UytCZnNQVm1QYTY5Ui83T0o2Qkl1cm5N?= =?utf-8?B?NWh2cS81clFqWnNLWkpZdUdJL3Y0ZmJDUUxTc3VySUcyL25SSUFVTmFNa2V4?= =?utf-8?B?bCs3aUZoaXh1cVFJZzQ5K1pNWkg1L29OcEZCVHlnbHBaU2I5N3pnOHhPUXlv?= =?utf-8?B?WnI4UzhXeHNZQU5QTkJ0YkRFdW85Q2ZFMXJwamtVS09kVWU3L09HQk9abkFY?= =?utf-8?B?eVFBOXIreDdJNTFSd1Jid0twSkRaY2RTR21sTmtDaTdVL0hXMkFqUkxYdjBa?= =?utf-8?B?SWd3QTZNTHY5TzF6ZjdjYzU4NCtqQjNyeTVSdmRWSmZQdVVNN1pVZ2NCVDZW?= =?utf-8?B?ZnJ2S2tPQ21lY1BoVGlxeEY5V2M2SEZJN3g0ZzBXTll6dHkxMFNsdnJLTStk?= =?utf-8?B?aUF5ZmdTVnZDUmxWTEk5b1F5cjc1RG1JcjI3cDd6UWhaSXpZSXZjUzRJTGRy?= =?utf-8?B?WFFuNnAxWFdZSGdFMXprVWVpMXZJaHFhTUprM0xIaS9Qb3F6Z29yZ3hISGd2?= =?utf-8?B?a2JHOVZmS1cwMUhiZWlEL2w0dGQ5QXR3SGFrell6N0JNc0pMM3ZNQlMraWpX?= =?utf-8?B?M2J6S0xaOWJlOHFybWtwMTI0cHdTU3I2RUVJbEQvWXVodmlqUmh2TGFEbmh1?= =?utf-8?B?VTZ4cXdWdHRrdXZHWXAyOTJYRkQ0TXJrUzZJbFpNamNzbURSNWxnTGYrSUZO?= =?utf-8?B?QlVnOEsySCtnckZXY0xiNTlyU296OWN6NlZLS09UUVpQRW4rYitkci9JeTRJ?= =?utf-8?Q?U1fFoPHFw2UDRrgYpXyuHVr5r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23c64ec7-7cd4-4720-29b7-08db084ded2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:24:58.8930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nw/1r7aIBe28vp1rDZHwlR8lStUoxr3Yy7CPRwJGxzT39NzGJqiYXEsZCFOV4zqODl+5V0dx47Y8Gxmq8LnzWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8815 On 26.01.2023 21:43, Andrew Cooper wrote: > On 25/01/2023 3:26 pm, Jan Beulich wrote: >> In order to avoid clobbering Xen's own predictions, defer the barrier as >> much as possible. > > I can't actually think of a case where this matters.  We've done a > reasonable amount of work to get rid of indirect branches, and rets were > already immaterial because of the reset_stack_and_jump(). > > What I'm trying to figure out is whether this ends up hurting us.  If > there was an indirect call we used reliably pre and post context switch, > that changed target based on the guest type, then we'd now retain and > use the bad prediction. Hmm, so far I was understanding that the context switch operation is solely for guests' purposes; this looks to be supported by the comments there. If we were worried about Xen itself here (which of course is a valid concern), then I think that together with the issue you've spotted in patch 3 all I can do is drop the two middle patches (and the HVM part of patch 1). At which point ... >> Merely mark the CPU as needing a barrier issued the >> next time we're exiting to guest context. >> >> Suggested-by: Andrew Cooper >> Signed-off-by: Jan Beulich >> --- >> I couldn't find any sensible (central/unique) place where to move the >> comment which is being deleted alongside spec_ctrl_new_guest_context(). > > Given this, I'm wondering whether in patch 1, it might be better to name > the new bit SCF_new_guest_context.  Or new_pred_context context (which > on consideration, I think is better than the current name)? > > This would have a knock-on effect on the feature names, which I think is > important because I think you've got a subtle bug in patch 3. ... this renaming, which I've done already, may have been in vein. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:26:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:26:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490489.759207 (Exim 4.92) (envelope-from ) id 1pP2Rw-0000ar-9g; Mon, 06 Feb 2023 14:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490489.759207; Mon, 06 Feb 2023 14:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2Rw-0000ak-61; Mon, 06 Feb 2023 14:26:28 +0000 Received: by outflank-mailman (input) for mailman id 490489; Mon, 06 Feb 2023 14:26:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2Rv-0000aK-9T for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:26:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1b::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c3b400f-a62a-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:26:25 +0100 (CET) Received: from DU2PR04CA0247.eurprd04.prod.outlook.com (2603:10a6:10:28e::12) by AS2PR08MB9319.eurprd08.prod.outlook.com (2603:10a6:20b:599::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:26:18 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::94) by DU2PR04CA0247.outlook.office365.com (2603:10a6:10:28e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:26:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:26:18 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Mon, 06 Feb 2023 14:26:17 +0000 Received: from f3dc730642bd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6AB8BD7-1BD1-42AB-B0E6-D790B2390E0E.1; Mon, 06 Feb 2023 14:26:07 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3dc730642bd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 14:26:07 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB6425.eurprd08.prod.outlook.com (2603:10a6:10:261::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:26:05 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c3b400f-a62a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=53/wvQ0s8QaVe90HQ1X8qbCO97kGb2IAOzWaQMThuW8=; b=tDnJPb+W+ZiNN4eHFIfgIm/tTHvnTuDMtRnny+ZQBd3O8/HImfnwLTG1sdbDKXL0vJH0aN0sVs/RXple2hA4bdKzWuXLqQkOfufpS9qjJRH8PQH6HVtmLBtil13SQI66MaQn8EjZGDbGiXbgmA7TUcbJzeuOpyBOtwRVKVc1O0U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 49ed8747c6c46321 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIo3Uf6ZmgFtmSQSMrORWouiQqD6KMHWPYPfL+VsxArC6sVkM8c0BGtqjKFEcmYUOeFp3IE/MTkifIBYiyHm8cLC9qAdfcchNEQQDgEQnVFA+R1JS/cNCwOcHbo73vWTQv8ULl9MsVLwrqG/dNiE+v1UhtTZ7vMUngQjJkSHSw0myPiiLRFul5NM6SJhYzBr+quWpTJr6bph33yKTSeQxK+MF3BBl57d8ONJl7O363P/vmJuHQyu7uV1s72Rwak+MZnJZh2Z8K4Cyz10LJ3helJjt2Iqy4MmoWk5MVbjk2S79oQ3V+vCmgP+zgJVRAjMi3F/cngdOsrrRrauW3JzFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53/wvQ0s8QaVe90HQ1X8qbCO97kGb2IAOzWaQMThuW8=; b=esXnx3NjCKgUOe3KY+PrGU9E7h9gxQYTn0i0v7hi2SUnMShgfYMIoW21cGI5DjDDL7TBceD1VnzNQAPynyOYS6OBkqEFONGKnVvZjUmJSFyNooSx56EJikkeEutsUL8Zko0yk9kGhni1Boo33gBZlcsydqdpoWbbVDhwXnF2HvJJR3Txo/rqgenkWEgQ0WK26Gz2VN0Y4TZtXFNCc2BlBsHOKngyTVRNhL1ojQL3Bhj/vJBl+hIT1EBOFANAb9TvBI5A1RC6mB3AHgBOHagACTU2grZCuGS00XhCrfmGG8r3G41SF5YpsbG47wN5Fd3oKO2HCEjfqCV3Uf1MhB4H9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=53/wvQ0s8QaVe90HQ1X8qbCO97kGb2IAOzWaQMThuW8=; b=tDnJPb+W+ZiNN4eHFIfgIm/tTHvnTuDMtRnny+ZQBd3O8/HImfnwLTG1sdbDKXL0vJH0aN0sVs/RXple2hA4bdKzWuXLqQkOfufpS9qjJRH8PQH6HVtmLBtil13SQI66MaQn8EjZGDbGiXbgmA7TUcbJzeuOpyBOtwRVKVc1O0U= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic Thread-Topic: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic Thread-Index: AQHZOivabZ9Ut2J3Nka3T18Z2Kyz4q7B+X8A Date: Mon, 6 Feb 2023 14:26:05 +0000 Message-ID: References: <20230206130528.22401-1-michal.orzel@amd.com> In-Reply-To: <20230206130528.22401-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB6425:EE_|DBAEUR03FT013:EE_|AS2PR08MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b4e0907-2dfb-46df-2639-08db084e1c73 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g036i+S5Tv9IMkHXVpc9Gs/wsHVbMFu7d18MlMTn9pUBzHGxa/8dQ7JPUeNG9wMaxQvFwFN0NPINOWFj7Mstv4dnEA7AUe0qIHILPnWM8E9FFA/z0mU3/tlQGdtNpkVy9tI+Zqrqrn/TrGR35Kvm8iIr7AsU7iBmq7R84weLrZh8el7xu+TL2uYl2k/qsA8LI/uS6IuMkFK0u1f7UjXyck5FG8BZKuGwQ1FyIyhCyEL0nvCpTInGivk6TVupe/PI1O6DC/04HSNaYKjS5xvQ5xCenB6KKqccWExQTnM8g4aij2pOiNJfWuwU7oiUIJCVMNqpgvfEzSiQRK7P86rQsB8IN4056zyk2hS+nYpqb1zdW7W674DNyDT5h9hHwrxm2BqpJMHp7/hapiSZfzmc9Aj2kI4iYj5wb0tchrTL1e6abC1QibVJzgPn5LXiP8fWPyJsQNyUeYGUNVUDafuQAGFmd0WTrAelWvLJr5YghiyJ1oUkRN1f6/M4EJY6BERZX/lgidjfUFPClitQ3stp/4i6u96UUykmvc9QdB/qzgAJ3OW0Ok/6dKIZccUGWLj1MEuzuEfkdUlPeqrJ9evBnaSSAb/xsFGTsCNLNe904af60tenWQv1KjIA28Wo/bonHA+cOPyCNKtV1xX0cG8rUsm/KMEcQwWOwy7TpQX+txC/4/azdR/4BIEnVWWzGVAiDUFw/A69lzt/8Jp5s93KoKwg2sNulMwpYRPQDL+Gs20= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(39860400002)(376002)(396003)(451199018)(64756008)(66446008)(6916009)(53546011)(6506007)(478600001)(6486002)(2616005)(8676002)(6512007)(186003)(26005)(91956017)(4326008)(66946007)(66556008)(316002)(66476007)(76116006)(71200400001)(54906003)(38070700005)(33656002)(36756003)(38100700002)(122000001)(86362001)(83380400001)(5660300002)(4744005)(41300700001)(8936002)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <28966DE46E485E4A82154302AB367E2C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6425 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d25f8cfd-87a8-4e50-b590-08db084e14dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qzGukflAk1FABKkc/hDEAqzaK1KVrNV0ATdpiwZm3pMdI1qlmj8e/MFq+6tU/k1GLUbMNBXCkT7NDuFDwWffxogJvn37joRXxRO0tJuausBsfZJp8RW2tC4ZECjFe1l3ka4+c32v/fLK0QF/AHd07AaZfKNtZf0jobKh7y1Pj4Sd8tuWerMC5u0qGKYttbSkStCv5WF6M73EcqlUJQEOLNCWylomDiAmMJpwdncLi7QFF5z7YsK3rMlbsS4/1Vuv2PJ9s55teZl3rcOoZTD6qVSsAVN5k10UTZOS9jJUPcLTDoyGKveBu/UUVbKrcWmySsJFyFPI1hnEi37sJ4bBP5679kqO35NaawAeSgPuHFXbNumvzvREdfoxx9N0UWNmcAZDPVXkZD9CZZ0SpiP3Rn/kNOQXP/uYv4Rqqh0NdFaP/0FE9HOPEmus5QOw+vgXYkrQEzR1VMQ9H4X3MPyegW64MjOL/6U/+HcfS0De3MCBTCIqFo9IVKF/byFsiQwrHC4bTibrfnvEOoK+9pk7KliGZquCPATuM5G0+hO1Mef1a65N417buVIjk5mZcMc7X1ase4u5bKRMjau00hJRn/1x71eiqYerbfiWRgZvZiDaSfXfNqW+/tCoEDS5uwQHVjxRVaq700p/ONRHal3H5vV05HdHZZPNXeJP99CipmCaOsGyxQT8gEIwN8hOvCebWi7j86+uTElbpeMZHPKwQA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199018)(46966006)(36840700001)(40470700004)(70206006)(54906003)(316002)(4326008)(8676002)(70586007)(8936002)(41300700001)(6862004)(40460700003)(81166007)(36756003)(33656002)(86362001)(356005)(82740400003)(107886003)(53546011)(6512007)(26005)(186003)(6506007)(6486002)(2906002)(47076005)(36860700001)(40480700001)(4744005)(82310400005)(478600001)(83380400001)(5660300002)(336012)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:26:18.0836 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b4e0907-2dfb-46df-2639-08db084e1c73 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9319 > On 6 Feb 2023, at 13:05, Michal Orzel wrote: >=20 > This might be helpful in providing additional debugging information (in > most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the > code to include printing return code in panic message. In create_dom0, > move the call to alloc_dom0_vcpu0() to a separate condition and call a > meaningful panic message. >=20 > Signed-off-by: Michal Orzel > --- Hi Michal, The code looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:32:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490495.759217 (Exim 4.92) (envelope-from ) id 1pP2XR-00023n-U3; Mon, 06 Feb 2023 14:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490495.759217; Mon, 06 Feb 2023 14:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2XR-00023g-RU; Mon, 06 Feb 2023 14:32:09 +0000 Received: by outflank-mailman (input) for mailman id 490495; Mon, 06 Feb 2023 14:32:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2XQ-00023Y-7k for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:32:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060d.outbound.protection.outlook.com [2a01:111:f400:fe0e::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07824958-a62b-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 15:32:06 +0100 (CET) Received: from AS9PR06CA0400.eurprd06.prod.outlook.com (2603:10a6:20b:461::29) by AS8PR08MB10290.eurprd08.prod.outlook.com (2603:10a6:20b:63c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Mon, 6 Feb 2023 14:32:04 +0000 Received: from AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::60) by AS9PR06CA0400.outlook.office365.com (2603:10a6:20b:461::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:32:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT018.mail.protection.outlook.com (100.127.140.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:32:03 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Mon, 06 Feb 2023 14:32:03 +0000 Received: from 38f8b18c9510.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34053E15-F53A-4C00-9E7C-EEF7AD2D1E40.1; Mon, 06 Feb 2023 14:31:56 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38f8b18c9510.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 14:31:56 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB7873.eurprd08.prod.outlook.com (2603:10a6:150:5c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28; Mon, 6 Feb 2023 14:31:54 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:31:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07824958-a62b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/em00BzmsS3BsNMGKBOF/yt97Yr3Tg2BWkGaSQ0a6nQ=; b=v2vdT+z7o1+b6phot42u8vo3rg7tfL4/oRtUBNCiUCIFG/+a359dHMViaUt/LPVGPJhBxHajMb0VZ2GL/ONETyfOE5p3cfvidX4i26jLiaf1h9bOCqzkzG02oki6PrrvMI9A00Cr2tmzahT5MPl/aC2PvyAZ/33xhEsGJXPv6VY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dbd6ceffe8b8383d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gV76ICcu+2SU1yuTLiWA2zcSwTcRYbmFCTO3KGANtI82wj9T/Lup0vGQeSOfs3QVNJkObV/SbaWTVXZAhFV8powPormLjqyikGWYoDLWjosrorjPjhmxDjihaA+mHJ4GX/pSLmoftqZlERFB3llS48qci/+jbv+/qpShdpZBaNvTa5WLyNkSKnsfaofbonERXWm4PeGaFmMuWU0xERtXEHnST/AFiBmhUai19LdDGTXTAU0SvcmLSP0UU5k/k972c1aGA2HlHpx0kDy300R5/J0QvFehsCaFm+YOSLoOPyT4w47LZn2Uq40GJaEmeoGQaIEwddyBcOvc+ETk955yDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/em00BzmsS3BsNMGKBOF/yt97Yr3Tg2BWkGaSQ0a6nQ=; b=dk/ZQrNk69P+z4eWJ26SkiAtzXAL3TOzIqQ2QrNwt1ExpupoSCcZa9kAYp3Imt5YiWG0stDQlt33pFHwQDm/Q3G3ZoiCDVkTGyvCXlVj5MinCwVstqkuDjGhM/7IKoUHAlkT1YxFu9odIUSKmc8AUBTl3RxNMWLuswmSKKdbZGDAAezJH5FbC/vB0jXiusNZPxlugfaoPv7TAVTqnVesVXYJKpNgHfv5H/jXbF01iTCknhXtrlIWilMIIJnbktIPoodO5xykeuHgA4wBL574RAPXaAmih3lAmjdlxfsCTK+e3dhPOMCWLoTojvF3jwWjkc4N3xslg1Iv7L54kX2mng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/em00BzmsS3BsNMGKBOF/yt97Yr3Tg2BWkGaSQ0a6nQ=; b=v2vdT+z7o1+b6phot42u8vo3rg7tfL4/oRtUBNCiUCIFG/+a359dHMViaUt/LPVGPJhBxHajMb0VZ2GL/ONETyfOE5p3cfvidX4i26jLiaf1h9bOCqzkzG02oki6PrrvMI9A00Cr2tmzahT5MPl/aC2PvyAZ/33xhEsGJXPv6VY= From: Luca Fancellu To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Topic: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Index: AQHZOAMhFrHFBGWgpEqoPT1xaNlgs67B/28A Date: Mon, 6 Feb 2023 14:31:52 +0000 Message-ID: <4388B281-EAEB-456D-8759-6DE055755735@arm.com> References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> In-Reply-To: <20230203190908.211541-2-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB7873:EE_|AM7EUR03FT018:EE_|AS8PR08MB10290:EE_ X-MS-Office365-Filtering-Correlation-Id: 49b98c8e-acc3-48b7-e3cf-08db084eea63 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uFyY+2LbBEkDr1xHDQz64aCyBCqsHg2F9VvTg8fkSKZwFNl1oIJ3EHvDQTTXeiYzgOSJJ/e9t5eJmBYRf7jYswQge7kya4hHeYXuqOLMovipGx+n4q93Aq2beHanBw9qt2pmoD+fu7HEYQWhDCrIBkJAHwK5YorZiVF/HLcykblCHfHG7yew7TS3+kw2WJ2YOL93sHHySqucNnu19ll3hTLtAsS0POE6mh8rwEdneNczbX/194cYx/e/wMsxAk0YwlNswRmrzwwIlg80bJbx9ydOjkS4eDhrjEeeiThRg4+wwfXOxBG4KmpyQCrfWBhfZy+FSy0Rnv8eLDdrIbTl24I/8hzTq2sSMnpNDPR4L7moFVgcJWLnjkpNIloyHv9kxQF5xfvA+ZWMEClPOjBdiWR3yFOk5NmR8zyqcuZyx2ctJ/CTuCkSk5rjpdShtd+BP44DC0s0TA8sPKu/5fo0pQBbUTZeR9t9Ay8+EdTYg7wa8nlJKTUyZoKzsyAagRiQmQkxRvUlHOHKm2V1WGkUaVwV+mdKGOWW8wxZ1SNCj1UGK9OwPdh/Y0itA9I4bQxhk1CB7lgJ8XHfsviHT1h0iWIXmPyV8ILSGSCYwryfddABldDgR/Z2KGv8NkSO27vSJq1PZ+ethMvnC8wk5G5eOWxoqvjoPV3pV0tvSAsTEe6PHOUkEekiHDKzKGUnCqtBSe50LylldeHzRq8no5f50j2qbhgKl5FLNzAWX+1hGZ7HHr8ppFal1mSkDlou+73L X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199018)(41300700001)(38070700005)(33656002)(6916009)(316002)(6486002)(478600001)(966005)(4326008)(83380400001)(66556008)(66476007)(91956017)(54906003)(66946007)(86362001)(8676002)(76116006)(64756008)(66446008)(2616005)(36756003)(5660300002)(122000001)(186003)(6512007)(26005)(71200400001)(2906002)(38100700002)(6506007)(8936002)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <568DCE6E47EFA2428A8F6DFDBDE4C06D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7873 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8cb0bcc6-6b72-4e3d-126f-08db084ee3e7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w9dEB+ZUHHp3TeGBgvBP0mrnzSopGU5k46SDquFb5OTTRmybPeM73b/COZynx27SkXgzeuUr1fq3nh1NFBFfEqmX2myHlNo9I8m/anCgR3QM8D/jxCW4rNXMBFYnXaOhjvOJwp1CcuMAc7Jfh1OMFDD47i7xIOhCiX5wpLiZ4h8mJZAYES051foH57Pob04RenwXBa0uPNSHYuYxTRP+58hsgK3oXdR6ph/ROR5lSzZUqgGd1q3ux3qYuESLlhiHxSXcTJxhCQ38ZLnmI99r9ka64efLdxvILwvZiPgeO1GoD1pn5TPeuPnT+r17cRRHPKBhiCvilURScK69wWfhNEqH0/GuQKGzj5Mzfsjr3Xy3zdWIPoeuXdGRhoL80ekQ+2SF/TXk/K3wKQWt913BLWGku29avphxuaWVLo3rzc9ma2IaxqikCdIyJs7F5ZAF5PlzPpJWzLLruIkPajhrqOTQEvusqZsANN0LirTGd0q29p31TnMAoXmcUwpTyGatsvE+GOSK7va3DMEuh4R7hKl0ByXQFSixYPZKRLeQ6SP0C+55AlnPlwnGkNSL0NID5HxJiFHRAeHDWUwJvP4OQTdhlp5EG3/vtjkXuemBcOpQme2UbqV9OX1o3DPuHAd77/kQsVw8lrA9YAuy9U+ZbbfH5ZNwUaUeX8LZABFm8/pDT0lk36T8CnDQxBqFtvLCMX/nJ1x7Ff8Y/LiDj6QvsU27unTqOhIyzuYXpid3E+E= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199018)(46966006)(36840700001)(40470700004)(54906003)(316002)(70206006)(70586007)(4326008)(36860700001)(41300700001)(8936002)(5660300002)(6862004)(8676002)(2906002)(2616005)(47076005)(81166007)(478600001)(82740400003)(6486002)(86362001)(356005)(966005)(33656002)(336012)(40460700003)(6512007)(83380400001)(186003)(26005)(82310400005)(53546011)(36756003)(6506007)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:32:03.5005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49b98c8e-acc3-48b7-e3cf-08db084eea63 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10290 SGkgWGVuaWEsDQoNCj4gT24gMyBGZWIgMjAyMywgYXQgMTk6MDksIFhlbmlhIFJhZ2lhZGFrb3Ug PGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBYZW5p YSBSYWdpYWRha291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+DQo+IC0tLQ0KPiANCj4gQ2hhbmdl cyBpbiB2MzoNCj4gIC0gdGhlIGZpeGVzIGFyZSBiYXNlZCBzb2xlbHkgdG8gRWNsYWlyIGZpbmRp bmdzICh0aGUgdG9vbCBoYXMgYmVlbg0KPiAgICBhZGp1c3RlZCB0byByZXBvcnQgb25seSB0aG9z ZSB2aW9sYXRpb25zIHRoYXQgY2FuIHJlc3VsdCB0byBhIGJ1ZykNCj4gIC0gcmVmbGVjdCB0aGlz IGluIHRoZSBjb21taXQgdGl0bGUNCj4gDQo+IHhlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5o IHwgMTQgKysrKysrKy0tLS0tLS0NCj4gMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwg NyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vZGV2aWNl X3RyZWUuaCBiL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+IGluZGV4IGEyODkzN2Qx MmFlOC4uNzgzOWExOTllMzExIDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vZGV2aWNl X3RyZWUuaA0KPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vZGV2aWNlX3RyZWUuaA0KPiBAQCAtMzcs MTEgKzM3LDExIEBAIHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggew0KPiAgICAgY29uc3Qgdm9pZCAq ZGF0YTsNCj4gfTsNCj4gDQo+IC0jZGVmaW5lIF9fRFRfTUFUQ0hfUEFUSChwKSAgICAgICAgICAg ICAgLnBhdGggPSBwDQo+IC0jZGVmaW5lIF9fRFRfTUFUQ0hfVFlQRSh0eXApICAgICAgICAgICAg LnR5cGUgPSB0eXANCj4gLSNkZWZpbmUgX19EVF9NQVRDSF9DT01QQVRJQkxFKGNvbXBhdCkgICAu Y29tcGF0aWJsZSA9IGNvbXBhdA0KPiArI2RlZmluZSBfX0RUX01BVENIX1BBVEgocCkgICAgICAg ICAgICAgIC5wYXRoID0gKHApDQo+ICsjZGVmaW5lIF9fRFRfTUFUQ0hfVFlQRSh0eXApICAgICAg ICAgICAgLnR5cGUgPSAodHlwKQ0KPiArI2RlZmluZSBfX0RUX01BVENIX0NPTVBBVElCTEUoY29t cGF0KSAgIC5jb21wYXRpYmxlID0gKGNvbXBhdCkNCj4gI2RlZmluZSBfX0RUX01BVENIX05PVF9B VkFJTEFCTEUoKSAgICAgIC5ub3RfYXZhaWxhYmxlID0gMQ0KPiAtI2RlZmluZSBfX0RUX01BVENI X1BST1AocCkgICAgICAgICAgICAgIC5wcm9wID0gcA0KPiArI2RlZmluZSBfX0RUX01BVENIX1BS T1AocCkgICAgICAgICAgICAgIC5wcm9wID0gKHApDQo+IA0KPiAjZGVmaW5lIERUX01BVENIX1BB VEgocCkgICAgICAgICAgICAgICAgeyBfX0RUX01BVENIX1BBVEgocCkgfQ0KPiAjZGVmaW5lIERU X01BVENIX1RZUEUodHlwKSAgICAgICAgICAgICAgeyBfX0RUX01BVENIX1RZUEUodHlwKSB9DQo+ IEBAIC0yMjYsMTMgKzIyNiwxMyBAQCBkdF9maW5kX2ludGVycnVwdF9jb250cm9sbGVyKGNvbnN0 IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggKm1hdGNoZXMpOw0KPiAjZGVmaW5lIERUX1JPT1RfTk9E RV9TSVpFX0NFTExTX0RFRkFVTFQgMQ0KPiANCj4gI2RlZmluZSBkdF9mb3JfZWFjaF9wcm9wZXJ0 eV9ub2RlKGRuLCBwcCkgICAgICAgICAgICAgICAgICAgXA0KPiAtICAgIGZvciAoIHBwID0gZG4t PnByb3BlcnRpZXM7IHBwICE9IE5VTEw7IHBwID0gcHAtPm5leHQgKQ0KPiArICAgIGZvciAoIHBw ID0gKGRuKS0+cHJvcGVydGllczsgKHBwKSAhPSBOVUxMOyBwcCA9IChwcCktPm5leHQgKQ0KPiAN Cj4gI2RlZmluZSBkdF9mb3JfZWFjaF9kZXZpY2Vfbm9kZShkdCwgZG4pICAgICAgICAgICAgICAg ICAgICAgXA0KPiAtICAgIGZvciAoIGRuID0gZHQ7IGRuICE9IE5VTEw7IGRuID0gZG4tPmFsbG5l eHQgKQ0KPiArICAgIGZvciAoIGRuID0gZHQ7IChkbikgIT0gTlVMTDsgZG4gPSAoZG4pLT5hbGxu ZXh0ICkNCj4gDQo+ICNkZWZpbmUgZHRfZm9yX2VhY2hfY2hpbGRfbm9kZShkdCwgZG4pICAgICAg ICAgICAgICAgICAgICAgIFwNCj4gLSAgICBmb3IgKCBkbiA9IGR0LT5jaGlsZDsgZG4gIT0gTlVM TDsgZG4gPSBkbi0+c2libGluZyApDQo+ICsgICAgZm9yICggZG4gPSAoZHQpLT5jaGlsZDsgKGRu KSAhPSBOVUxMOyBkbiA9IChkbiktPnNpYmxpbmcgKQ0KPiANCj4gLyogSGVscGVyIHRvIHJlYWQg YSBiaWcgbnVtYmVyOyBzaXplIGlzIGluIGNlbGxzIChub3QgYnl0ZXMpICovDQo+IHN0YXRpYyBp bmxpbmUgdTY0IGR0X3JlYWRfbnVtYmVyKGNvbnN0IF9fYmUzMiAqY2VsbCwgaW50IHNpemUpDQo+ IC0tIA0KPiAyLjM3LjINCj4gDQo+IA0KDQpXaGlsZSB0aGUgY2hhbmdlcyBsb29rcyBzZW5zaWJs ZSB0byBtZSwgSeKAmXZlIGhhZCBhIGxvb2sgaW4gZWNsYWlyIGJ1dCBJIHdhcyB1bmFibGUgdG8g ZmluZCB0aGUgZmluZGluZ3MsDQpoZXJlIHdoYXQgZmluZGluZ3MgSSBoYXZlIGluIHRoZSBsYXRl c3QgcmVwb3J0OiANCmh0dHBzOi8vZWNsYWlyaXQuY29tOjg0NDMvam9iL1hFTi9UYXJnZXQ9QVJN NjQsYWdlbnQ9ZG9ja2VyMS9sYXN0QnVpbGQvZWNsYWlyL3BhY2thZ2VOYW1lLjgzMjIwNDYyMC9m aWxlTmFtZS4xODExNjc1ODA2Lw== From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:37:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490505.759229 (Exim 4.92) (envelope-from ) id 1pP2cg-0002qE-Ks; Mon, 06 Feb 2023 14:37:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490505.759229; Mon, 06 Feb 2023 14:37:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2cg-0002q7-HQ; Mon, 06 Feb 2023 14:37:34 +0000 Received: by outflank-mailman (input) for mailman id 490505; Mon, 06 Feb 2023 14:37:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2cf-0002pz-73 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:37:33 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2060c.outbound.protection.outlook.com [2a01:111:f400:fe5b::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c8f23835-a62b-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 15:37:31 +0100 (CET) Received: from MW4PR03CA0311.namprd03.prod.outlook.com (2603:10b6:303:dd::16) by MN0PR12MB5929.namprd12.prod.outlook.com (2603:10b6:208:37c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:37:28 +0000 Received: from CO1NAM11FT070.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::15) by MW4PR03CA0311.outlook.office365.com (2603:10b6:303:dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Mon, 6 Feb 2023 14:37:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT070.mail.protection.outlook.com (10.13.175.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 14:37:27 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 08:37:24 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 6 Feb 2023 08:37:23 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8f23835-a62b-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK3YgWcDRz03FuuMMbCY5rtuj6ibMgcqFWIW2lULHNjRf7g2yhOaqbIqk0N7ylEgcHeWDouA+oilUbMr4xLr9ldubEVrRj4ygMwX47Xy7bWdln86eih9fhg2isNEZ/+bjyPYbCfgVkgBHwjToQiUM4HZFk73R6jLL12/J/0rzwR+R/1ODFDS6SdTTcjlW//DPCqMKc40WKowYyeVuRYDptlu9RZYdQenAXbTL2e2qMIY/3RB+HrGPLl1/14KPuFxLGqa1fvf+dMHt6ZB+WmIWCIR2bEFZCwfAgdw2hz3h2W1TTZrsBgfj0n7kTzlyAzWh4ywHIeNiyQJanHs7esPYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GwsG7IefSP2GkK6J1PpfDL/s9Svfm7wg2M+oTHlM9UA=; b=fLfB7Y5b+lCBUCMi8KGAAvVSu3Mn4fboxrBzV9RzoAkmBtUxj1R8EhSnFn+qYnCPJIcUfw2w/G+xlFMfosojQ5fh4brr4YL4W1wEN1+BqLY3FzcFIgPunfeV3lCf4MwpxSjeY3X6HCWuUy8MZ9TKC9Rr+rjQgsAtJx0TNrZd70028yjCz5VM4NgVgc6kwiKgLLffl3rE7WZ+g//bE1LTJ7YQ0keOvTvabbc4ePl9BNn70xT5qDY28l8cqkL/mGZ98L4Ht4na+BedaFubiQ6HO1oGDNUuo6Xqy3qyhLZM5tBXz3ZPXT8LixF40XeDLGQOoGNNPy0AudFok0BeNMe4Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GwsG7IefSP2GkK6J1PpfDL/s9Svfm7wg2M+oTHlM9UA=; b=is8gJdF70ThE7WuLXtYo1Bj5HJubY8L1VeaYWVHuw3Kv+8EFKW2pLuV1gfhn3w7WgCNhwoz1eyEAvXSBPZ+DlsgU0EzzkPSbMmvgIgMadQ9Ww/wak4dRyOs8HTYQ8DjWM/N7TodrwVZ8K/J2o9UPg+d/6rtP8WMlJwIUjhk45L8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Mon, 6 Feb 2023 15:37:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Luca Fancellu , Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <4388B281-EAEB-456D-8759-6DE055755735@arm.com> From: Michal Orzel In-Reply-To: <4388B281-EAEB-456D-8759-6DE055755735@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT070:EE_|MN0PR12MB5929:EE_ X-MS-Office365-Filtering-Correlation-Id: eaa1a50f-ed32-4b71-1c09-08db084fab68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ydPCYzL9phztLP2EVsua4i3vI0O06+sUmFbHxgf6BmpXiEl29SPT45yHjnOtuIBQ3eLoy2BDRT0Cslm87GhZcszOc+DjmJ2+yJura/KzIng3hMizMp3sug6ahKSXIn+leJGe/sFPirHn9Pe6fLNClnNTnCMxbc5a6Tj0ALXkE5EI8MN1zDKgIsvGX2NJUw9NA3i4+Dbhw93DGbeWr2Z3CYC/f79hAGgd/Wfwb24RgedcyVY432+y6zuu8Dr3MURAeiWvIt5C9mFWGqcwayi8IsM0DhRPAcZwuagUMICml+5Ijiay/wqGAyEz9nD1Bs+HEVZXalZdqhTlwNfGjyJmqBaOKpI+E/guWlZLaRzRSLl+R1ZgSI+bZK8+1Bdh8ymDOGPIbmtpuooTMln/CioOTpnYwHon8rPU0sUV7Ej1wRGMBic/8Jt/ZInyDxqXmkLX5Wcf4AM7OddaRufTImgLYMcaw6zv6TfPDJiTR+wFZ7AsIxDET4aCr3sXREu9p6hhwcP6JTwMOkZAMjUbS8OzTBsFm8c7qaORQNT75cvbzQj23AmzwU4YcXXPIqYpCwCr8IA8Dwyr/xw6gpSUjDb1d2bkd6K+S87gky94y6kCrr1wxOkzPBQ/cIp1TM6T5vMIcYqMWYSo0CyKpudnX0N03PKtG36e/iCGGkfi2hSTB/qcYks9tMPk0jG8z11EJCGAeU79LPpngMfUNj0kFvN4eiUTAudqxET86oKmmUqb5aGpfDbfAcvSHh2w7o39+38Gj5PbC/0mutg+jxQmoG89mdx/R7xUuaB6Ndbi1BZMqRI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199018)(40470700004)(36840700001)(46966006)(36756003)(40460700003)(478600001)(966005)(2616005)(53546011)(186003)(26005)(8676002)(8936002)(41300700001)(4326008)(70586007)(70206006)(44832011)(2906002)(16576012)(316002)(110136005)(5660300002)(54906003)(81166007)(82740400003)(36860700001)(31696002)(86362001)(356005)(82310400005)(47076005)(40480700001)(426003)(336012)(83380400001)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:37:27.2503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eaa1a50f-ed32-4b71-1c09-08db084fab68 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT070.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5929 Hi Luca, On 06/02/2023 15:31, Luca Fancellu wrote: > > > Hi Xenia, > >> On 3 Feb 2023, at 19:09, Xenia Ragiadakou wrote: >> >> Signed-off-by: Xenia Ragiadakou >> --- >> >> Changes in v3: >> - the fixes are based solely to Eclair findings (the tool has been >> adjusted to report only those violations that can result to a bug) >> - reflect this in the commit title >> >> xen/include/xen/device_tree.h | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >> index a28937d12ae8..7839a199e311 100644 >> --- a/xen/include/xen/device_tree.h >> +++ b/xen/include/xen/device_tree.h >> @@ -37,11 +37,11 @@ struct dt_device_match { >> const void *data; >> }; >> >> -#define __DT_MATCH_PATH(p) .path = p >> -#define __DT_MATCH_TYPE(typ) .type = typ >> -#define __DT_MATCH_COMPATIBLE(compat) .compatible = compat >> +#define __DT_MATCH_PATH(p) .path = (p) >> +#define __DT_MATCH_TYPE(typ) .type = (typ) >> +#define __DT_MATCH_COMPATIBLE(compat) .compatible = (compat) >> #define __DT_MATCH_NOT_AVAILABLE() .not_available = 1 >> -#define __DT_MATCH_PROP(p) .prop = p >> +#define __DT_MATCH_PROP(p) .prop = (p) >> >> #define DT_MATCH_PATH(p) { __DT_MATCH_PATH(p) } >> #define DT_MATCH_TYPE(typ) { __DT_MATCH_TYPE(typ) } >> @@ -226,13 +226,13 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); >> #define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 >> >> #define dt_for_each_property_node(dn, pp) \ >> - for ( pp = dn->properties; pp != NULL; pp = pp->next ) >> + for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) >> >> #define dt_for_each_device_node(dt, dn) \ >> - for ( dn = dt; dn != NULL; dn = dn->allnext ) >> + for ( dn = dt; (dn) != NULL; dn = (dn)->allnext ) >> >> #define dt_for_each_child_node(dt, dn) \ >> - for ( dn = dt->child; dn != NULL; dn = dn->sibling ) >> + for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) >> >> /* Helper to read a big number; size is in cells (not bytes) */ >> static inline u64 dt_read_number(const __be32 *cell, int size) >> -- >> 2.37.2 >> >> > > While the changes looks sensible to me, I’ve had a look in eclair but I was unable to find the findings, > here what findings I have in the latest report: > https://eclairit.com:8443/job/XEN/Target=ARM64,agent=docker1/lastBuild/eclair/packageName.832204620/fileName.1811675806/ Eclair does not report violations at the definition but rather at the use. Check domain_build.c for example to see the reports for 20.7 related to these macros. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:43:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:43:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490511.759240 (Exim 4.92) (envelope-from ) id 1pP2iE-0004H6-97; Mon, 06 Feb 2023 14:43:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490511.759240; Mon, 06 Feb 2023 14:43:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2iE-0004Gz-6E; Mon, 06 Feb 2023 14:43:18 +0000 Received: by outflank-mailman (input) for mailman id 490511; Mon, 06 Feb 2023 14:43:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2iD-0004Gt-Hp for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:43:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061f.outbound.protection.outlook.com [2a01:111:f400:fe0c::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9644f2dd-a62c-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:43:15 +0100 (CET) Received: from AS9PR05CA0074.eurprd05.prod.outlook.com (2603:10a6:20b:499::28) by GV1PR08MB7873.eurprd08.prod.outlook.com (2603:10a6:150:5c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28; Mon, 6 Feb 2023 14:43:03 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:499:cafe::31) by AS9PR05CA0074.outlook.office365.com (2603:10a6:20b:499::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:43:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 14:43:02 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Mon, 06 Feb 2023 14:43:02 +0000 Received: from 94d604d77588.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5C15BF40-307F-46BE-A817-52CC592F00A5.1; Mon, 06 Feb 2023 14:42:55 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 94d604d77588.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 14:42:55 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB6373.eurprd08.prod.outlook.com (2603:10a6:20b:33a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:42:53 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:42:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9644f2dd-a62c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slih/Dexk80MELkkF/r4v8l/LA9gWjYcjwUklT2awqU=; b=YCCd6omlmvbioAlECt0eIaOFPJs5V67ZFjaZzJvVdjwwGTAMG8UnTolAqePFIqfgVUOEUk+ncz9S2zjRxpJv9PfbKSpUDMuG+eIHzKLZNNn9hJg51SbuKgf+IlaxdBGUrCUUUzMWSbAqxQ2pHKQtqZaCz5MW5L3ZVZUxpDTnPdo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 66e4f3a2101329fd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5/lJLJkRmtoyrtRL5GDd6fZ7ubtAYriZ4uxeLLOXgpXsFPnqYZj0M3s07YMcemeGT1FJso3cI0+r+dEzU43nDy1Deke3xKvJmEOLHDaiVvb38Ld5ux8tz+gYpp9g0lPElCzH8vp/qsW8TJIctvVZW6mMi6khrnUxqFp8r8INokn9MeFg1ZJCHO1ByJc7PuK6dp9uk/RkWqE3T8d4tijhenEP0oqyg0AE8Lq2hjvA7uAq+n6RN+7WK3Dj1MCFS+TMf8Vz1uRQiLWO/wnavsE3WFMQEC1U+JgNVmh3lSXB41iU2rC7rH2HoiK0C+XQAfTsewypqLH/aqBWD8yALfXGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slih/Dexk80MELkkF/r4v8l/LA9gWjYcjwUklT2awqU=; b=QzdzyfRFbgDalF0kZhzbfk2jHZO6cuJ9qZCeYcr2BFi9oTF94cg5eppATIqjpvlqwX3g+KWmN1Jir4RUKOkFC4ivdjnc40KSq46EVLWICHn9qLUpstWdWpaF8HRIROsaGvjdo77DRKqPMMD23BdKl9rbYMPGCFk8gyBtr61DQjb5dZDdT0nyvM41jpJ7WomyFvFlVsnMGZ+g9/J6I4J/o1jSO+NJb5Zxi9eDNgmpV7QMHIMkGx3CjI3krTJLrdOBSa9w3HkIjI0m6xSYYMPdLFOViD7tf/l3TnBdok/n9zZtS1PTEVGdKFzwUof7broAIYKZ+WX2A4nD/e8QGNKiEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slih/Dexk80MELkkF/r4v8l/LA9gWjYcjwUklT2awqU=; b=YCCd6omlmvbioAlECt0eIaOFPJs5V67ZFjaZzJvVdjwwGTAMG8UnTolAqePFIqfgVUOEUk+ncz9S2zjRxpJv9PfbKSpUDMuG+eIHzKLZNNn9hJg51SbuKgf+IlaxdBGUrCUUUzMWSbAqxQ2pHKQtqZaCz5MW5L3ZVZUxpDTnPdo= From: Luca Fancellu To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Thread-Topic: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Thread-Index: AQHZOAMXy1ML+LQFIECFNoctrCf/pa7CAoAA Date: Mon, 6 Feb 2023 14:42:50 +0000 Message-ID: References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-3-burzalodowa@gmail.com> In-Reply-To: <20230203190908.211541-3-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB6373:EE_|AM7EUR03FT040:EE_|GV1PR08MB7873:EE_ X-MS-Office365-Filtering-Correlation-Id: 82f3c0f1-98b7-477a-9fe9-08db08507337 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IEOmcTsfTyGjQETk+ttWvy7kevVsWzZTyAVPRqEU6sDKd4Dbob+93LsNR7mbXYxGAGraTlY7VeJoSTKCaxWtejNuP1kkvkOuEf5jspAGlnDiiaKlf48477z7lKTbnZZMBjKpj1c5e4TJ9sC6ziaCo7Blit61kFGnWzFyOBgb7Qlmjo/vmQS7cDnKW6lb9dkCgWqgR/IDwZBf5/D9uIddDAelHmwQrCgbzJS0IAioEfdjkJEY1aJArAw4CRnOhy45Sw8gjxSWkFwZiQrKSsXORNuUYOyfAz6EAUduuAKerH1o45hUYCGQrm483Sx5sf5xWCK2jF8ALVpNdGMrLI4yEhyltNgL9PCrvotP/JwPZ6mya7VqySxjvHDELQ3tTW7rVPPHRU75uHpzO+4wEvQp8Ss3rWJf58SH68aCsVScSBp25jA/qvPbiQMaLK0SAcTPCPXhd7vT8l6l1cgcWuDZRnpZ0Ko8OZr+PMXZypgUNHN/MmY8xvFG7XwlKLclFT7O1feNVCrzVTdyxUVGfhBUt3VS3nxMGnkZem1EeVfkekeaRxiO+s5nSOplIABxq1hZazcyyWbYUHkMjsJH7n0OHzQ7mDxpQsxSkZuopybvRvXBEZLpLkBz8TArnDEJYca6eUzGyWjf4mzP+xWs/Od+PemTjB4kxmX5Lm58n91vHFI4MuMxDO2sri2ttpCP9zsyp/uLsZeIGZvtHDroyCo8TAuS9xbLTCewshV3mYIHmtY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199018)(478600001)(38100700002)(122000001)(38070700005)(36756003)(53546011)(6506007)(33656002)(186003)(6512007)(26005)(6486002)(86362001)(4326008)(76116006)(83380400001)(66946007)(91956017)(66556008)(2616005)(8676002)(6916009)(66476007)(64756008)(54906003)(316002)(66446008)(71200400001)(2906002)(41300700001)(5660300002)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6373 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d1b8189-7b53-4f4f-5db2-08db08506c2a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8xBIwY/YL1JQcnYzGe4FH4AnR1MeNKJnKKwEA/++lUb5d7M3a8Qbswdo8GAM2ppLIQSCeMaGuAXqx8fl4ivcK4hl2QF/PuUmxTBbVyhQMhfxMb7Y3XNLb+/QkK2BT6xhkPIzDiRd2Z+HzCqi8UJrzn8o4t5sZNWD3/noGQcXizBhycSnF6fcHQezBa1L2MS8Ne7sLXGtDafAkGhqfWA4/6gdPhWypoc/xrCa5+9N08VtPljvUc7y9ScCh2/dG67lvzJknWTbMC0DB1IrWX3nM4cv/7LfnbS8HSWqILxD3rSZ4UDqTyDnwrL/s7kpFnxvALNc+4JEwO/bolHoNur14qQNOeTVz+2pJVGX8fTDDydL86nEgeJCBRX+qjCa1IYq0xPYBWc83aRWd7ITr9aPH4Lov/8DluVY91u0Yr4OK02bnlCvEboMTwlBL8SNPXnGAgy5A39B3BSeLeips4fH7UaZb+A371OWhoNHz7QpPiYZsb/KUpgfs1NpU1fdN0/R4UOQ605mIH9vuxqKruUlIOH019fi0Jp0Hk1+yNmXDIXD+W2tBYFam4SUhsBQZyXB4zVUx06luryPDQoXyjtfpo+5ovbPQZoK555cqGFl1WgGCgERazZCzpJONZ0o7QqWhAr3twfj+k+zA0yAxhltHXQXmdZFc5FEG6J3F1edKuCRZez60VN3JVPMz5hRtPxSN0lqfnCiHNBeLJ73b3QXqw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(26005)(82740400003)(186003)(6512007)(36860700001)(5660300002)(81166007)(53546011)(336012)(8936002)(2906002)(6862004)(6506007)(33656002)(356005)(41300700001)(82310400005)(36756003)(2616005)(4326008)(316002)(6486002)(478600001)(70206006)(70586007)(8676002)(40460700003)(86362001)(54906003)(47076005)(83380400001)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:43:02.5863 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82f3c0f1-98b7-477a-9fe9-08db08507337 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7873 DQoNCj4gT24gMyBGZWIgMjAyMywgYXQgMTk6MDksIFhlbmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9k b3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBNYWNybyBkdF9pcnEoKSBpcyBicm9rZW4gYmVj YXVzZSB0aGUgbWFjcm8gcGFyYW1ldGVyIGhhcyB0aGUgc2FtZSBuYW1lIHdpdGgNCj4gdGhlIHN0 cnVjdCBkdF9pcnEgbWVtYmVyICJpcnEiLg0KDQpJ4oCZbSBub3Qgc3VyZSBhYm91dCB0aGUgd29y ZGluZyDigJxicm9rZW7igJ0sIGl0IHNob3VsZCB3b3JrIGFueXdheSBvciBhbSBJIHdyb25nPw0K DQo+IE1hY3JvIGR0X2lycV9mbGFncygpIGlzIGJyb2tlbiBhcyB3ZWxsIGJlY2F1c2Ugc3RydWN0 IGR0X2lycSBoYXMgbm8gbWVtYmVyDQo+IG5hbWVkICJmbGFncyIuDQoNClllcyB0aGlzIGRlcGVu ZHMgaWYgdGhlIG1hY3JvIHdhcyBtZWFudCB0byBhY2Nlc3MgdGhlIHN0cnVjdHVyZSBkdF9pcnEs IEnigJl2ZSBoYWQgYSBsb29rDQpvbiB0aGUgY29tbWl0IGludHJvZHVjaW5nIGl0IGJ1dCBJIGNv dWxkIG5vdCBmaWd1cmUgb3V0IHRoZSB1c2FnZS4NCg0KPiANCj4gU2luY2Ugbm8gb25lIHNlZW1z IHRvIGhhdmUgZXZlciB0cmllZCB0byB1c2UgdGhlbSBhbmQgZXZlbnR1YWxseSBzdHVtYmxlIHVw b24NCj4gdGhlIGlzc3VlcyBhYm92ZSwgcmVtb3ZlIHRoZW0gaW5zdGVhZCBvZiBmaXhpbmcgdGhl bS4NCj4gDQo+IEZpeGVzOiA4ODZmMzQwNDViZjAgKCJ4ZW4vYXJtOiBBZGQgaGVscGVycyB0byBy ZXRyaWV2ZSBhbiBpbnRlcnJ1cHQgZGVzY3JpcHRpb24gZnJvbSB0aGUgZGV2aWNlIHRyZWUiKQ0K PiBTaWduZWQtb2ZmLWJ5OiBYZW5pYSBSYWdpYWRha291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+ DQo+IC0tLQ0KPiANCj4gQ2hhbmdlcyBpbiB2MzoNCj4gIC0gbmV3IHBhdGNoDQo+IA0KPiB4ZW4v aW5jbHVkZS94ZW4vZGV2aWNlX3RyZWUuaCB8IDMgLS0tDQo+IDEgZmlsZSBjaGFuZ2VkLCAzIGRl bGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJl ZS5oIGIveGVuL2luY2x1ZGUveGVuL2RldmljZV90cmVlLmgNCj4gaW5kZXggNzgzOWExOTllMzEx Li4xOWE3NDkwOWNlY2UgMTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJl ZS5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+IEBAIC0xNTksOSAr MTU5LDYgQEAgc3RydWN0IGR0X3Jhd19pcnEgew0KPiAgICAgdTMyIHNwZWNpZmllcltEVF9NQVhf SVJRX1NQRUNdOw0KPiB9Ow0KPiANCj4gLSNkZWZpbmUgZHRfaXJxKGlycSkgKChpcnEpLT5pcnEp DQo+IC0jZGVmaW5lIGR0X2lycV9mbGFncyhpcnEpICgoaXJxKS0+ZmxhZ3MpDQo+IC0NCj4gdHlw ZWRlZiBpbnQgKCpkZXZpY2VfdHJlZV9ub2RlX2Z1bmMpKGNvbnN0IHZvaWQgKmZkdCwNCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBub2RlLCBjb25zdCBjaGFyICpu YW1lLCBpbnQgZGVwdGgsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 MzIgYWRkcmVzc19jZWxscywgdTMyIHNpemVfY2VsbHMsDQo+IC0tIA0KPiAyLjM3LjINCj4gDQo+ IA0KDQpUaGV5IHNlZW1zIGluZGVlZCB1bnVzZWQsIHNvIGZvciBtZSB0aGUgY29kZSBsb29rcyBn b29kOg0KDQpSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29t Pg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:51:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:51:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490518.759252 (Exim 4.92) (envelope-from ) id 1pP2q8-0005qu-5M; Mon, 06 Feb 2023 14:51:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490518.759252; Mon, 06 Feb 2023 14:51:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2q8-0005qn-0c; Mon, 06 Feb 2023 14:51:28 +0000 Received: by outflank-mailman (input) for mailman id 490518; Mon, 06 Feb 2023 14:51:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2q6-0005qR-T6 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:51:26 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9d22566-a62d-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:51:24 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id hx15so34806305ejc.11 for ; Mon, 06 Feb 2023 06:51:24 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id s19-20020a1709067b9300b008878909859bsm5541253ejo.152.2023.02.06.06.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 06:51:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9d22566-a62d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gRKpTx++j8ZkLjUBv0s8sCh8Yr8bchGn9mv145p6DLU=; b=JmvLVVTdWg7Hx7Y2U5kSRNipJJJEGv7BxXIj0Nbrq91QidyYdlOkmRtcuYGTsH3rSd mr41lFFz4EHn4l/XR6+tH/TfV61G6bvBDv3nHnY5zXTyIeJMgNC0lIzaSKAF7+mGPfGe OBfYOzytEhIqZKVGSJmI7RT8kwDVoNvkVS9anHnvMECdt8vTIXsUvXw7TNM1eMWJBLW5 jc6Qb8bns1iWLrwjcBJWySRcBkZ5KfJ8qcZOtyllgVtkZHWaHGs7USjPfoNksLDz29zw ruwVN4UZxmoLJByPcXiHfMTdKQwkYDhr+UzWh9EoBPk2ZS6uiUc9IV0UURR4ovM0LSJq 1GnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gRKpTx++j8ZkLjUBv0s8sCh8Yr8bchGn9mv145p6DLU=; b=JhuZr2ZYcEPm8VOk7ipQYgAwI13iMpgT81Izg6iYtSKokvp7Z6JYkX4TUIUsg2eBuY YXJpRGKApEQku+odA/Svc9V+/Kf76IC0x4H70zjq7QGGiXBRKL5VMxfSW8t8kW+E5H3R 94eLjYwpjhMxvQ5P3tc23ZAzv5RNGTTzigO6se2EZa4j5yn30mrin1ACYavb2PuiF1oK QmbLcBieKr1PHh4y+Pi2XrLkiUleGqQbPESk3AGYEPEdGAQmK7tzk9gzxC55W6y20/3h bSDS3Kgkwyf9Lw3bHy53xdicZvwKFmRUF6tY253O2oB2XO++eZ5+19aQaNDizhOo+pgT YqeQ== X-Gm-Message-State: AO0yUKXS8MXJzfdNkglzYxD2AlUXTWR0AvIs7vtvudOjFmJ3ctK+YIAA 0hpA/0suVungOf7rVLerPSsrXIN3chw= X-Google-Smtp-Source: AK7set8zk2jEqy5mosGtBhh+jLWOo73g65w7p1Pi3q780KgZ8BOrbF/RUbbEQqE8PwKrm4PiPDx3nQ== X-Received: by 2002:a17:906:5945:b0:86e:f478:f598 with SMTP id g5-20020a170906594500b0086ef478f598mr18620878ejr.44.1675695083654; Mon, 06 Feb 2023 06:51:23 -0800 (PST) Message-ID: <1217f21a-5734-26eb-4c32-cc92a7b25f69@gmail.com> Date: Mon, 6 Feb 2023 16:51:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Julien Grall References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca On 2/6/23 16:42, Luca Fancellu wrote: > > >> On 3 Feb 2023, at 19:09, Xenia Ragiadakou wrote: >> >> Macro dt_irq() is broken because the macro parameter has the same name with >> the struct dt_irq member "irq". > > I’m not sure about the wording “broken”, it should work anyway or am I wrong? No, it won't work because the structure member will be substituted as well by the macro argument (for instance dt_irq(blah) will be replaced by (blah)->blah). > >> Macro dt_irq_flags() is broken as well because struct dt_irq has no member >> named "flags". > > Yes this depends if the macro was meant to access the structure dt_irq, I’ve had a look > on the commit introducing it but I could not figure out the usage. Given the macro name, I assumed that it was meant to be used for accessing a dt_irq field. > >> >> Since no one seems to have ever tried to use them and eventually stumble upon >> the issues above, remove them instead of fixing them. >> >> Fixes: 886f34045bf0 ("xen/arm: Add helpers to retrieve an interrupt description from the device tree") >> Signed-off-by: Xenia Ragiadakou >> --- >> >> Changes in v3: >> - new patch >> >> xen/include/xen/device_tree.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >> index 7839a199e311..19a74909cece 100644 >> --- a/xen/include/xen/device_tree.h >> +++ b/xen/include/xen/device_tree.h >> @@ -159,9 +159,6 @@ struct dt_raw_irq { >> u32 specifier[DT_MAX_IRQ_SPEC]; >> }; >> >> -#define dt_irq(irq) ((irq)->irq) >> -#define dt_irq_flags(irq) ((irq)->flags) >> - >> typedef int (*device_tree_node_func)(const void *fdt, >> int node, const char *name, int depth, >> u32 address_cells, u32 size_cells, >> -- >> 2.37.2 >> >> > > They seems indeed unused, so for me the code looks good: > > Reviewed-by: Luca Fancellu > > -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:56:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:56:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490525.759262 (Exim 4.92) (envelope-from ) id 1pP2uf-0006aG-PS; Mon, 06 Feb 2023 14:56:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490525.759262; Mon, 06 Feb 2023 14:56:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2uf-0006a9-MM; Mon, 06 Feb 2023 14:56:09 +0000 Received: by outflank-mailman (input) for mailman id 490525; Mon, 06 Feb 2023 14:56:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2ue-0006a3-9t for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:56:08 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20627.outbound.protection.outlook.com [2a01:111:f400:7eaf::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5fad1d1b-a62e-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 15:56:02 +0100 (CET) Received: from DB7PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:10:52::30) by DBBPR08MB6298.eurprd08.prod.outlook.com (2603:10a6:10:1f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:55:57 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::61) by DB7PR02CA0017.outlook.office365.com (2603:10a6:10:52::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:55:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32 via Frontend Transport; Mon, 6 Feb 2023 14:55:56 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Mon, 06 Feb 2023 14:55:56 +0000 Received: from 3e93cb7afcfd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 337D8818-0729-4996-89E0-AC142F1B8222.1; Mon, 06 Feb 2023 14:55:49 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3e93cb7afcfd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 14:55:49 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB10112.eurprd08.prod.outlook.com (2603:10a6:20b:64e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:55:48 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:55:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fad1d1b-a62e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkCoKdqI9O51GEANP5YqtjyZlKvcMxG7gGMEGuJdtak=; b=qgTJ9cErhS6RdEK91Dwy8gqwB+kBdGtmyBgWK0sIr1zo7EYHp6zo37NgwnZtk2fUH3eHkzcDAU2fGVn2iWoomVHuWIRElUd+WKXnbS17bQnooWs7d6uIU3h2NMu6yfskA6FpeHDyaV7HIaWrR6ryucT9fPAM6KnbbKOC6XDKNwA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: abd9b1982ef7bdcc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVCTsS0YP6IAu1j/8gJFiMabtdFrJ59ETJ2ecCoWrcTTex93z/KiCsJIf/Ls6BuBUkgsfeDqYMFb/Sc1Y3BANc/IsuqCOFCtcZN9q3wOzPAqCOaYTfZD8pjsmKBqyDDbpCAtHvTzXnDHM0GqS2V14FA5KVWjVpb3Q+I1jduX7PN3T0Cig/+Ahb+MF4nahj8sAKzUH0QvQ2UTfT3GSJGVlZc+U/IfOXdiRf5wldRyr6OEbjgjtfgnV9EGJXP0lJRYlXSdVJJXpcky3jKdW9YPqwVdJCo+TC2WGwXRelP2YUbVXy6SLCAXunmWASmS2FcZAgEaqyoboEouIjrkV6P2Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkCoKdqI9O51GEANP5YqtjyZlKvcMxG7gGMEGuJdtak=; b=WzyAVN68liEeUvG6eRNIR5Ev5gu0whNINCCds0GZkQFkdp7OcPsdEFpJpKjEIdjDFxKq1SZxzsB4Harm6IJNfTm52RZlcOFLlhtC5exnxUHtikKisAIEUw0cH2qVeDYmgIzXSC6TdsWIdwk2GjwpyOTE54M28d+3ZT4uGuVJiP9o5cC5MPyTpEEcld+zhvYjySKRlk1lS7z1Co0ZaqQWnRarSAqauQoBtlGXHnTYlNSRsbwRngeKXs2iBnS982z0FtGtJOdWzwrKi+f7utdWjfmaBabUZhaIzCKJ4mfGKYDgtkvmD3blAKwhPIgiBgqf/sWbWfVyDDs1rk0goY209g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkCoKdqI9O51GEANP5YqtjyZlKvcMxG7gGMEGuJdtak=; b=qgTJ9cErhS6RdEK91Dwy8gqwB+kBdGtmyBgWK0sIr1zo7EYHp6zo37NgwnZtk2fUH3eHkzcDAU2fGVn2iWoomVHuWIRElUd+WKXnbS17bQnooWs7d6uIU3h2NMu6yfskA6FpeHDyaV7HIaWrR6ryucT9fPAM6KnbbKOC6XDKNwA= From: Luca Fancellu To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Thread-Topic: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Thread-Index: AQHZOAMXy1ML+LQFIECFNoctrCf/pa7CAoAAgAACbgCAAAEwgA== Date: Mon, 6 Feb 2023 14:55:47 +0000 Message-ID: References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-3-burzalodowa@gmail.com> <1217f21a-5734-26eb-4c32-cc92a7b25f69@gmail.com> In-Reply-To: <1217f21a-5734-26eb-4c32-cc92a7b25f69@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB10112:EE_|DBAEUR03FT008:EE_|DBBPR08MB6298:EE_ X-MS-Office365-Filtering-Correlation-Id: ed221aaf-f7eb-4c72-4b0e-08db085240a0 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2G1BJ6kZeh7ya/71GVWEuig9jdAT32CpAyV9A9TIuTFpIKTZ+cQbnVD8qq/jwZL5Aap4smnuZXxkdm/Tz4FGJILT8rHZ6TB0noKPPtIYdb2ADFup+x3vwfwOu5yKO35qzShYJ5zNs3+A0cbf1ltlyQfWLp22IJ/uViHN8lBsJHx95SXOkOwuH404YnutA0aqBjkiL2wWDFnHtXw+46tfIwvODhsZ0gOgvlZP/7yvjLtd57LrOlA+Znu5+8dwxfxYtp6Iy2Y0pSFV76yh5fN0haNdkM4GyjCg0Qpy+4Y3CU1uI5IP47FG2XcJuCKS5qwJIiXsNnTg/K7YRAY+gqg4sqmPECFsNxU29WPTyqrFQQvsxSyhmQpIPfpgV9p4ROw69pebE0yMdurhhF9d9Nq3JwRVODKpauTkblrXHULBlzi/hpCC+Rd8QKRhowBTpIIt5nPJA7/4eGYGgXdjnruaOS6qNI9omx++efoTDt+r0P7atWJpLnTrAY7hQb92mv0T9TRxvbf7bt1+iJBfTR9C5og1ReNzla6f2eVlqXMom68Gw60IELIX8UYqIauLcF3B6V8Ug1a3Pi/bybIZFt6BC1sIleAotqABXHROsOFlfkfD+MyFLztxivA4Pufq2qWpWkL8xdLOMQWE6OzIC5mTCVVXRkZYOgFIG/58xpaTyOi1QV/G5I59lQT7CRlqYeXp189mY2dE40AjdpwS1IQbNwHGTLeatFz4s0c7ek7yA0o= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(346002)(376002)(366004)(396003)(451199018)(4326008)(6916009)(8676002)(41300700001)(91956017)(76116006)(66556008)(66946007)(64756008)(66446008)(66476007)(316002)(8936002)(83380400001)(36756003)(186003)(6512007)(122000001)(4744005)(2616005)(26005)(71200400001)(2906002)(33656002)(5660300002)(54906003)(6506007)(6486002)(53546011)(86362001)(38070700005)(478600001)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1A2F039F8FB4E1418D3165F15ECF9D0C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10112 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 75e1b702-fb75-408c-a2bd-08db08523b49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lFhRmItmdtshshZf5O5OuCQAjZYNtT0VMs07Hi3wnPelOeow4zXxLKukS5vIKHAm2X3cgQsz6BE/3Yw1mGUqhO9nh3s7ZaHZi+Cir5wXU/Zx45I5tPp+H0ZFF2i/VH7U/dc5nAeTo1zatzVgZIocMaZG3hVHOhVitxCGidqnjMBNEkBuuy3qn1T7+FeWlh3FSQ1yldecsQlXSDu/lAWWq7lT6486n/1+wNbSoUCgtnXkryLma5P2APyfAbe08V9QY/pCvY8+h05A407eWNwiEmr/Usqh449/UnBkc+j2fm7jDofHOQqhgK3P4cwC+1kBQQ+pmMbCXOZGOmIRr83BkNnq5ZQvCeVvHh6Ea/WM6Rey55yfGEOanl0m4Ho8tMufp9L5wyYpmYeFFLyQ0va6sFkAkCI8Nus5u1cpSPGonXOwWFAjJXg4CXimk8YPhRnaIldyQj+YDv3ADvXJh7HLfoAsWc1ErV6Mg9Tf7jQ9aPaNbJcYlnsizsz09D982RlcpuBRqqV1HkgvsQdi7q70Pjefp74ELFOrszfgxXFoUySIOESj+eJaaN+BQGXjXLnHJ5WvtwyxMuRULrrlRSIIySPWQF6VAowL1CvZ+5n9DjP7zVqTrpShyKy2gzeea2DM3LtjXwSNlcTQWuqJ4yAqqfU2zp9Q2k7UgXK8kWjPGVzvMQh04xs6DR7SKBLU4d7z3K+aSyAJsk8k4z44wqig7w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199018)(36840700001)(46966006)(40470700004)(26005)(6486002)(478600001)(6512007)(186003)(8936002)(53546011)(2616005)(40480700001)(5660300002)(41300700001)(6862004)(336012)(6506007)(54906003)(316002)(356005)(70206006)(70586007)(8676002)(33656002)(83380400001)(40460700003)(36860700001)(81166007)(4326008)(47076005)(82740400003)(86362001)(82310400005)(2906002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:55:56.7488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed221aaf-f7eb-4c72-4b0e-08db085240a0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6298 DQoNCj4gT24gNiBGZWIgMjAyMywgYXQgMTQ6NTEsIFhlbmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9k b3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBMdWNhDQo+IA0KPiBPbiAyLzYvMjMgMTY6 NDIsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4gT24gMyBGZWIgMjAyMywgYXQgMTk6MDksIFhl bmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g TWFjcm8gZHRfaXJxKCkgaXMgYnJva2VuIGJlY2F1c2UgdGhlIG1hY3JvIHBhcmFtZXRlciBoYXMg dGhlIHNhbWUgbmFtZSB3aXRoDQo+Pj4gdGhlIHN0cnVjdCBkdF9pcnEgbWVtYmVyICJpcnEiLg0K Pj4gSeKAmW0gbm90IHN1cmUgYWJvdXQgdGhlIHdvcmRpbmcg4oCcYnJva2Vu4oCdLCBpdCBzaG91 bGQgd29yayBhbnl3YXkgb3IgYW0gSSB3cm9uZz8NCj4gDQo+IE5vLCBpdCB3b24ndCB3b3JrIGJl Y2F1c2UgdGhlIHN0cnVjdHVyZSBtZW1iZXIgd2lsbCBiZSBzdWJzdGl0dXRlZCBhcyB3ZWxsIGJ5 IHRoZSBtYWNybyBhcmd1bWVudCAoZm9yIGluc3RhbmNlIGR0X2lycShibGFoKSB3aWxsIGJlIHJl cGxhY2VkIGJ5IChibGFoKS0+YmxhaCkuDQoNClllcyB5b3UgYXJlIHJpZ2h0LCBJIHdhcyByZWFk aW5nIGl0IGluIHRoZSB3cm9uZyB3YXkhIA0KDQo+IA0KPj4+IE1hY3JvIGR0X2lycV9mbGFncygp IGlzIGJyb2tlbiBhcyB3ZWxsIGJlY2F1c2Ugc3RydWN0IGR0X2lycSBoYXMgbm8gbWVtYmVyDQo+ Pj4gbmFtZWQgImZsYWdzIi4NCj4+IFllcyB0aGlzIGRlcGVuZHMgaWYgdGhlIG1hY3JvIHdhcyBt ZWFudCB0byBhY2Nlc3MgdGhlIHN0cnVjdHVyZSBkdF9pcnEsIEnigJl2ZSBoYWQgYSBsb29rDQo+ PiBvbiB0aGUgY29tbWl0IGludHJvZHVjaW5nIGl0IGJ1dCBJIGNvdWxkIG5vdCBmaWd1cmUgb3V0 IHRoZSB1c2FnZS4NCj4gDQo+IEdpdmVuIHRoZSBtYWNybyBuYW1lLCBJIGFzc3VtZWQgdGhhdCBp dCB3YXMgbWVhbnQgdG8gYmUgdXNlZCBmb3IgYWNjZXNzaW5nIGEgZHRfaXJxIGZpZWxkLg0KDQpZ ZXMgSSB3b3VsZCBjb21lIHRvIHRoZSBzYW1lIGNvbmNsdXNpb24NCg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:58:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490532.759273 (Exim 4.92) (envelope-from ) id 1pP2wf-0007Am-5K; Mon, 06 Feb 2023 14:58:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490532.759273; Mon, 06 Feb 2023 14:58:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2wf-0007Af-2Q; Mon, 06 Feb 2023 14:58:13 +0000 Received: by outflank-mailman (input) for mailman id 490532; Mon, 06 Feb 2023 14:58:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2wd-0007AJ-2H for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:58:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab4a0a26-a62e-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:58:09 +0100 (CET) Received: from AS9PR05CA0136.eurprd05.prod.outlook.com (2603:10a6:20b:497::6) by PAWPR08MB9447.eurprd08.prod.outlook.com (2603:10a6:102:2e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Mon, 6 Feb 2023 14:58:06 +0000 Received: from AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:497:cafe::4d) by AS9PR05CA0136.outlook.office365.com (2603:10a6:20b:497::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Mon, 6 Feb 2023 14:58:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT062.mail.protection.outlook.com (100.127.140.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend Transport; Mon, 6 Feb 2023 14:58:06 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Mon, 06 Feb 2023 14:58:06 +0000 Received: from fa32cfcbdc9f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4AD85048-35F4-4B11-868E-F5F9E8A30301.1; Mon, 06 Feb 2023 14:58:00 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa32cfcbdc9f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Feb 2023 14:58:00 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB5PR08MB10063.eurprd08.prod.outlook.com (2603:10a6:10:48a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 14:57:57 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:57:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab4a0a26-a62e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=na2eRzEXYv0U2eIJkYzdDK5WRObRa3XeWd8bVJTDIMA=; b=R02fcEr95Pu/UVZfAtka4DMpthvKAeFCmwpjcNIoDGzO1rhUNRcruovdASi1cgNsThYV9Un3nWA2SapeGzZPo8dR8K4WbLqz4dQv21GA3bmkYI45MQOOkqNjGYWqwMj7vaW14Z8TJ4KreBjfCvREUk0onfTfi0pJ3QTA7TXUDDk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cdbf87687f7417bc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mjpSyn6CawGOgbUgKU3QPmZ/hL/A4qOStRrrW9LeRIGWKB4M7hJ5SCkQelBiJSfdWPNJudHAC9FnmCXbEDY024mExvILEYiD76JAU+wiPEPgNrF5ShEwXrLRUz4HuNb/xaqyBUp0NU6SrScM4hd9nFFQCaT7tKEF2GobNkFBDpob4Z7d58i1cof7U3L9C4Zg64uRMqIzWa0EexxIgAyLgdvQoB5MW5iRzp9B1gGA89DD8KvS510CiSE+zwUiieAjDverzuspF3cShFccuu8zG97eHgTsaAflx/RgF3uT3XHuaTU9c5rnr8+X4QKVRcA32/QJtH0iZlY7tUYZUmS+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=na2eRzEXYv0U2eIJkYzdDK5WRObRa3XeWd8bVJTDIMA=; b=OyZw2znp62mlbaUEfrn+w7ELINxOzJUT8tM+olc7yKV3MyElDSpSLUbfBhDQSuzB0c1c5VF3bOkkFgGCQ5Dg74FFBjY1riNaXjZLWBNy0AH7jt7CE3DH6q+qicYbik0VStWdYo0ZyWy3lwlvSKV8lOhkXvwSNQV5Y79/mX+/GGd2Is8BbgiuOgj9yy1dApfk2WU9XTMdG+jOtWz3YEZDpQsUJf4Oujv2kqX3RD7+xBXt+k9oKy651yg88Z2N85ogB6M5m0g5vPWGPCanAno7MFCh2DWxPeDbslVRsX5qPiHh01GvlOgZxaU3MczNDR9XpFLPKn1KKreFAviJnP2koA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=na2eRzEXYv0U2eIJkYzdDK5WRObRa3XeWd8bVJTDIMA=; b=R02fcEr95Pu/UVZfAtka4DMpthvKAeFCmwpjcNIoDGzO1rhUNRcruovdASi1cgNsThYV9Un3nWA2SapeGzZPo8dR8K4WbLqz4dQv21GA3bmkYI45MQOOkqNjGYWqwMj7vaW14Z8TJ4KreBjfCvREUk0onfTfi0pJ3QTA7TXUDDk= From: Luca Fancellu To: Michal Orzel CC: Xenia Ragiadakou , Xen-devel , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Topic: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Index: AQHZOAMhFrHFBGWgpEqoPT1xaNlgs67B/28AgAABlgCAAAWwAA== Date: Mon, 6 Feb 2023 14:57:55 +0000 Message-ID: <1E5F9B6E-9745-4536-A420-FCECB3A9FEDA@arm.com> References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <4388B281-EAEB-456D-8759-6DE055755735@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB5PR08MB10063:EE_|AM7EUR03FT062:EE_|PAWPR08MB9447:EE_ X-MS-Office365-Filtering-Correlation-Id: 900834fd-458a-45c1-154d-08db08528e19 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xqrwNYLvHzlXKKkk4yf620/RqXHhyintStcxs/PFyrKo9k91/03GtIMfFXrNp1svm90YI5QxsQAWJY/BYhoitWEnfyQ7FVWQJVlBXBcJs1K9OfYRS18AaUXnXlSLrLvYbbcvZlOfIsg3D1CewPkz/Qzh4+lqq2ZX4uyhG1yhf7BpIYAzpFXoI1ICvt460BqeAiVmwJtt02/PfuQUiSb9IhGGQRIML8VwJikSK6Iv43s2DUBuEXhq3kyR/kHT1Qar7g9GRssEawj3KjGvqo5lbGRR0TDT5+dPCJl5s0kq1KiMwlnl3WtGEykZjiZcHbS/Wp5QUS+5sjVB3TgRYONI+6SGd2Vxx4gMn6YGxsjPm+pH7Dxjo1XAhiRFQUaniildVUzvtGEn02nS8jutMQIOYNfSXeOd1lLA711krOTv2gV609fApDgnXYYN71bfs7vN8ohFFZeSCYQU9n1JoK76I56XsBkoduwYR/oRY/vQlAO/z5JVsibpV0AOMRkFP0dPwUsf+XB9ej7hFdKgUqEj5FwlRj2k5p9aTUVsmCP4ArzBTChW5fnPdNC5/+IKHnhVG7vaXXjLRoePiMxTg7g6zMGLzZP0weKopV+6eONhcGxLsb/h8bHWZ/gUtYEJQ3Ur/abZYw2JawxlpkmVOTvef6T6Du/ZkQm5V9ZQ78TDCbKT70jxbbC2NzGeXQk96oRRIRJLGg3TXx9+rlf7vDd5AI01/vWBnOmy5ULDCdAc1TXrLjqNo81iH5kDK5cSn/A6jcM9vWgJu/6h2REEFC0Q+A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(39860400002)(366004)(346002)(451199018)(86362001)(2906002)(122000001)(33656002)(5660300002)(38070700005)(38100700002)(41300700001)(316002)(54906003)(8936002)(66476007)(8676002)(66556008)(4326008)(76116006)(66946007)(64756008)(6916009)(66446008)(6486002)(83380400001)(966005)(478600001)(91956017)(53546011)(6512007)(6506007)(186003)(71200400001)(26005)(36756003)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9E19DC1D30EB3747AEDE3353BD5B7924@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10063 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 589e3cd8-24bc-4d79-3e0b-08db0852875a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mPXtnga5WXbtncEEG1A72w7vAoxvPtaXl3rzrHR44c96ZF0ILGTkow1uAexsGhQVHmSgyKKs3lERWsV2ElRMqt3aDTON9XmqYfc6Bvj17zY6ghFOGPeFIJpMBLLzlaoX+3GqoAD4M6i3gFItIvWkORAdIR3pI8CvdO8hFDkCN/4gEGu4zVmPt99v5ylZ6MngWO6v4qbEledXpen4YjrScqN8Mss0Rr+nrITQ+02Z338I4LorX8GvyTnn0fSI5A48vqNY3rAfNGGZT1ep3yhKshZfj3czOElvWNPUL8NJtvt+vFEoiID50tJIYRHh4Ndqe/ZN6jIXDzgFwQkAuKwjCuHtYXv7UwAnI42D6MBvm3MdhLTsSVvJbaU/6jdEUkndnm9BPfLSPG1QaxujYf4gX0BLU25m3TpVOcyLUWGdVK2rRsSCpTiJllDwvmHx6N2FFSCVpwEW6tBXuGq85mqtP7HaK8Dg7hII1cKrGuAX9KD18IYy2Q6qEoT623mfoHt+TH/jZk8aKkJOeTtMao3qJlTwZWPra2mlFbKsBk0Fo1O+QbcIxPubr4saHe/+3k2PriqypLAmVHip1X3UuqanEke7EyDhn9M1SI2nHxHLz38VLV+Kw/pSLpc7MygW09owF/8eGVwB4LFvvtdZI6vV+pgEvWEVX4jJL/uAIzMjbiy0lh9vxbhZ/+bEYKTuBQywSF9ouNt1Ch0dBhh7pfUmH69LTLqbpIedWAt4aW2/QLM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199018)(40470700004)(46966006)(36840700001)(54906003)(966005)(478600001)(26005)(6486002)(6512007)(186003)(2616005)(336012)(53546011)(6506007)(70206006)(36756003)(316002)(2906002)(4326008)(8676002)(6862004)(40460700003)(83380400001)(41300700001)(356005)(8936002)(33656002)(82740400003)(82310400005)(40480700001)(81166007)(47076005)(70586007)(36860700001)(5660300002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:58:06.6624 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 900834fd-458a-45c1-154d-08db08528e19 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9447 DQoNCj4gT24gNiBGZWIgMjAyMywgYXQgMTQ6MzcsIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs QGFtZC5jb20+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIDA2LzAyLzIwMjMgMTU6 MzEsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiANCj4+IA0KPj4gSGkgWGVuaWEsDQo+PiANCj4+ PiBPbiAzIEZlYiAyMDIzLCBhdCAxOTowOSwgWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FA Z21haWwuY29tPiB3cm90ZToNCj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5OiBYZW5pYSBSYWdpYWRh a291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+DQo+Pj4gLS0tDQo+Pj4gDQo+Pj4gQ2hhbmdlcyBp biB2MzoNCj4+PiAtIHRoZSBmaXhlcyBhcmUgYmFzZWQgc29sZWx5IHRvIEVjbGFpciBmaW5kaW5n cyAodGhlIHRvb2wgaGFzIGJlZW4NCj4+PiAgIGFkanVzdGVkIHRvIHJlcG9ydCBvbmx5IHRob3Nl IHZpb2xhdGlvbnMgdGhhdCBjYW4gcmVzdWx0IHRvIGEgYnVnKQ0KPj4+IC0gcmVmbGVjdCB0aGlz IGluIHRoZSBjb21taXQgdGl0bGUNCj4+PiANCj4+PiB4ZW4vaW5jbHVkZS94ZW4vZGV2aWNlX3Ry ZWUuaCB8IDE0ICsrKysrKystLS0tLS0tDQo+Pj4gMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkNCj4+PiANCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUv eGVuL2RldmljZV90cmVlLmggYi94ZW4vaW5jbHVkZS94ZW4vZGV2aWNlX3RyZWUuaA0KPj4+IGlu ZGV4IGEyODkzN2QxMmFlOC4uNzgzOWExOTllMzExIDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9pbmNs dWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+Pj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2RldmljZV90 cmVlLmgNCj4+PiBAQCAtMzcsMTEgKzM3LDExIEBAIHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggew0K Pj4+ICAgIGNvbnN0IHZvaWQgKmRhdGE7DQo+Pj4gfTsNCj4+PiANCj4+PiAtI2RlZmluZSBfX0RU X01BVENIX1BBVEgocCkgICAgICAgICAgICAgIC5wYXRoID0gcA0KPj4+IC0jZGVmaW5lIF9fRFRf TUFUQ0hfVFlQRSh0eXApICAgICAgICAgICAgLnR5cGUgPSB0eXANCj4+PiAtI2RlZmluZSBfX0RU X01BVENIX0NPTVBBVElCTEUoY29tcGF0KSAgIC5jb21wYXRpYmxlID0gY29tcGF0DQo+Pj4gKyNk ZWZpbmUgX19EVF9NQVRDSF9QQVRIKHApICAgICAgICAgICAgICAucGF0aCA9IChwKQ0KPj4+ICsj ZGVmaW5lIF9fRFRfTUFUQ0hfVFlQRSh0eXApICAgICAgICAgICAgLnR5cGUgPSAodHlwKQ0KPj4+ ICsjZGVmaW5lIF9fRFRfTUFUQ0hfQ09NUEFUSUJMRShjb21wYXQpICAgLmNvbXBhdGlibGUgPSAo Y29tcGF0KQ0KPj4+ICNkZWZpbmUgX19EVF9NQVRDSF9OT1RfQVZBSUxBQkxFKCkgICAgICAubm90 X2F2YWlsYWJsZSA9IDENCj4+PiAtI2RlZmluZSBfX0RUX01BVENIX1BST1AocCkgICAgICAgICAg ICAgIC5wcm9wID0gcA0KPj4+ICsjZGVmaW5lIF9fRFRfTUFUQ0hfUFJPUChwKSAgICAgICAgICAg ICAgLnByb3AgPSAocCkNCj4+PiANCj4+PiAjZGVmaW5lIERUX01BVENIX1BBVEgocCkgICAgICAg ICAgICAgICAgeyBfX0RUX01BVENIX1BBVEgocCkgfQ0KPj4+ICNkZWZpbmUgRFRfTUFUQ0hfVFlQ RSh0eXApICAgICAgICAgICAgICB7IF9fRFRfTUFUQ0hfVFlQRSh0eXApIH0NCj4+PiBAQCAtMjI2 LDEzICsyMjYsMTMgQEAgZHRfZmluZF9pbnRlcnJ1cHRfY29udHJvbGxlcihjb25zdCBzdHJ1Y3Qg ZHRfZGV2aWNlX21hdGNoICptYXRjaGVzKTsNCj4+PiAjZGVmaW5lIERUX1JPT1RfTk9ERV9TSVpF X0NFTExTX0RFRkFVTFQgMQ0KPj4+IA0KPj4+ICNkZWZpbmUgZHRfZm9yX2VhY2hfcHJvcGVydHlf bm9kZShkbiwgcHApICAgICAgICAgICAgICAgICAgIFwNCj4+PiAtICAgIGZvciAoIHBwID0gZG4t PnByb3BlcnRpZXM7IHBwICE9IE5VTEw7IHBwID0gcHAtPm5leHQgKQ0KPj4+ICsgICAgZm9yICgg cHAgPSAoZG4pLT5wcm9wZXJ0aWVzOyAocHApICE9IE5VTEw7IHBwID0gKHBwKS0+bmV4dCApDQo+ Pj4gDQo+Pj4gI2RlZmluZSBkdF9mb3JfZWFjaF9kZXZpY2Vfbm9kZShkdCwgZG4pICAgICAgICAg ICAgICAgICAgICAgXA0KPj4+IC0gICAgZm9yICggZG4gPSBkdDsgZG4gIT0gTlVMTDsgZG4gPSBk bi0+YWxsbmV4dCApDQo+Pj4gKyAgICBmb3IgKCBkbiA9IGR0OyAoZG4pICE9IE5VTEw7IGRuID0g KGRuKS0+YWxsbmV4dCApDQo+Pj4gDQo+Pj4gI2RlZmluZSBkdF9mb3JfZWFjaF9jaGlsZF9ub2Rl KGR0LCBkbikgICAgICAgICAgICAgICAgICAgICAgXA0KPj4+IC0gICAgZm9yICggZG4gPSBkdC0+ Y2hpbGQ7IGRuICE9IE5VTEw7IGRuID0gZG4tPnNpYmxpbmcgKQ0KPj4+ICsgICAgZm9yICggZG4g PSAoZHQpLT5jaGlsZDsgKGRuKSAhPSBOVUxMOyBkbiA9IChkbiktPnNpYmxpbmcgKQ0KPj4+IA0K Pj4+IC8qIEhlbHBlciB0byByZWFkIGEgYmlnIG51bWJlcjsgc2l6ZSBpcyBpbiBjZWxscyAobm90 IGJ5dGVzKSAqLw0KPj4+IHN0YXRpYyBpbmxpbmUgdTY0IGR0X3JlYWRfbnVtYmVyKGNvbnN0IF9f YmUzMiAqY2VsbCwgaW50IHNpemUpDQo+Pj4gLS0NCj4+PiAyLjM3LjINCj4+PiANCj4+PiANCj4+ IA0KPj4gV2hpbGUgdGhlIGNoYW5nZXMgbG9va3Mgc2Vuc2libGUgdG8gbWUsIEnigJl2ZSBoYWQg YSBsb29rIGluIGVjbGFpciBidXQgSSB3YXMgdW5hYmxlIHRvIGZpbmQgdGhlIGZpbmRpbmdzLA0K Pj4gaGVyZSB3aGF0IGZpbmRpbmdzIEkgaGF2ZSBpbiB0aGUgbGF0ZXN0IHJlcG9ydDoNCj4+IGh0 dHBzOi8vZWNsYWlyaXQuY29tOjg0NDMvam9iL1hFTi9UYXJnZXQ9QVJNNjQsYWdlbnQ9ZG9ja2Vy MS9sYXN0QnVpbGQvZWNsYWlyL3BhY2thZ2VOYW1lLjgzMjIwNDYyMC9maWxlTmFtZS4xODExNjc1 ODA2Lw0KPiANCj4gRWNsYWlyIGRvZXMgbm90IHJlcG9ydCB2aW9sYXRpb25zIGF0IHRoZSBkZWZp bml0aW9uIGJ1dCByYXRoZXIgYXQgdGhlIHVzZS4NCj4gQ2hlY2sgZG9tYWluX2J1aWxkLmMgZm9y IGV4YW1wbGUgdG8gc2VlIHRoZSByZXBvcnRzIGZvciAyMC43IHJlbGF0ZWQgdG8gdGhlc2UgbWFj cm9zLg0KDQpXb3cgeWVzIHRoYXTigJlzIHJpZ2h0LCBhIGJpdCBhbm5veWluZyB0byBsaW5rIHRo ZSBpc3N1ZXMhIFdobyBrbm93cyBpZiB0aGVyZSBpcyBhIG1vZGUgdG8gbWFrZSBpdCBwb2ludCBv dXQgdGhlIHZpb2xhdGlvbiBhdCB0aGUgZGVmaW5pdGlvbg0KbGlrZSBjcHBjaGVjay4NCg0KSeKA mWxsIHJldmlldyB0aGlzIHBhdGNoIGxhdGVyIHRoaXMgd2VlayBpZiBJIG1hbmFnZSB0byBmaW5k IHRoZSB0aW1lDQoNCj4gDQo+IH5NaWNoYWwNCg0K From xen-devel-bounces@lists.xenproject.org Mon Feb 06 14:58:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 14:58:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490535.759284 (Exim 4.92) (envelope-from ) id 1pP2wu-0007YM-Eh; Mon, 06 Feb 2023 14:58:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490535.759284; Mon, 06 Feb 2023 14:58:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2wu-0007YF-By; Mon, 06 Feb 2023 14:58:28 +0000 Received: by outflank-mailman (input) for mailman id 490535; Mon, 06 Feb 2023 14:58:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP2wt-0007AJ-IK for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 14:58:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1b::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4fa34ee-a62e-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 15:58:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9191.eurprd04.prod.outlook.com (2603:10a6:20b:44e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.28; Mon, 6 Feb 2023 14:58:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 14:58:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4fa34ee-a62e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aJkPzIc6wIH6C/6f2KgzgIrpD2sOHMcsrDwUmI2Q8CTQpcT182vkUZCWbpyvFPx/C8t3NvOys0WwDqAsYxY7vG7wRqmsUJbdu/3AvsED9xqy1LTXSzh0vQc5CxpujVFJjys3psNFUfIuiXMvh0oXifJeFV43UemcZEd+Hww1BMpsEQm8Gqi+f3SDIZybP78NjqmEBr8uG1f5Oq3PfkPd3RSZ2UDaYbJUz8I9yRaEtU0B+UtxqWByodLSoC8M482NWGjluga5z4B9mpvsdYLNvLfH89bQMlqqw/UF4mpJjqOFN8iPiTVWGKNALkQhwDJL/TC8zilqn2XRoh8YkorCgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qzu6Mi2Qn6keAXqnf3Zaw1uvfZrsjJe08f7O55lzQdI=; b=cUXJ/YiUTQ1oRnXEzadBCdGbQlnndY62Wz8UCn0piAaoUTuq9VgtmuXi35LTAxGbVSdjHksCTGuZQcQ8xj28ji+ntBU9q0yu1H1zCWJ0e1fVMS1D+7lucJK7QOKaYF7XQHg2S0ejCQfogclUuARJ6IUOnoWQE1Jh+sTEd9T3shP5rj1h23J8yxKmorZzkERkVBJjilkr7M7ghdZRV5OaqD7nepO2dYs5a+w4YAvBALefUdkrwL90n77/5Hj6dY5B7MxGeAME4Jr736qpoZXECMqgkJudibkr7DVTzVQKGbuA1Y1IlQ7x/9GOyBWhR9fIdIh6dZQnUVONDr+NUdZEgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qzu6Mi2Qn6keAXqnf3Zaw1uvfZrsjJe08f7O55lzQdI=; b=202WebaB6x/Xn/ZSd5+1+EFn561LlEDoTYCU+26s91ACeny6JNes2S+V1uJtdomL5QaOoQr6W8eRNQKvtJAOUDmHx53IU3b2eXBnCxPl7saVUFM7HRPTYxdfC8OQbQIk9jDp1hWwoINsgjuLEo3Zd1adbNKKoWxfeyRWhoQhrMeIBztmk5QiFB3AVNrd7/AYgOihAhcMeiYX8xIM9lASNsGEM8J+w0aYV2JU7KjaKr60gwdAoWFad7Z1FEi2gwADSFL3gssy2cNNoiLwnfxph6OeAS4fRN/AeYXj93CDZ0/jV8rxcb2bV2KD7L5TpcSba/Wz5FuECo4kIROYkhvL+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Feb 2023 15:58:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 3/4] x86: limit issuing of IBPB during context switch Content-Language: en-US To: Andrew Cooper Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <930254a6-d0c8-4910-982a-bfd227187240@suse.com> <0acfa717-8711-599f-4d29-d92a1466a1db@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9191:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dbbd568-9f83-43cd-209d-08db085297be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tnVuyJjsR//9KmlS9SHtFIt7wzI8q2NbACX0Svqc46QhN3jAQVDmoj+KAzgzFKbkwZ5+yXUOJX3cLt+jURGUijuSdOHA/1c8zSqyTCb5AMOsYs7ZVb4k8DwxFK5nkTL45MO23RQzM607LuIUbk323HgDfbJ7330B8vOAdVtdGsmMjGFHSivCviLks0gxt3ujGGVNKsGnLiCnk8o4ak+/Y2q84Qmy/foAt7eq0AGAOvaITIHi4RMeOUEbL+Ro03srbv4oNLX2pHkNYkhdyrrMim42QjRveZbr44zILBkRVXD1pwwLbdCh3NgVBFvLpDbndXN6uq8aYfouJPvOgQ73t4JxpPbNkIwV1c5CY0+yISSQDqxZb7IkWR+DJngwJBJFrsD6uL8TAzb9PHyU2TgoWhRfXLnIa4Fcoc4WibKayhswUiMlSfhWWt/bMVn2hcXSH/Cu4nHziHdSRxAV8EP3BwDCySTu7jJ7uKLUSEpRvQ2dY85BhUloadsqgMoMIzAmoDb0Z7hbxr1Doh7CA0q9WdeXRNaKzCF/IEqBqfaIZ6vQP+laEBYmNN2TcmUr2nhb2wNETxyKkY/H6NEKr1Q4+eQ6QgbOoJBbK1iuQ33DYAEzurmPmguDlCQZED1tTlhAr+AxtXXgdPlnJuxltgV089T41VPcwHTOw9MsSFn5C6oL9f/+1fBfpmMCyq2RLaqaBWpaeoRteJO1KucvJUbXqid/QMLril3gtXLsLCKhZH4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(396003)(376002)(366004)(136003)(451199018)(6512007)(2616005)(6666004)(36756003)(53546011)(83380400001)(26005)(186003)(54906003)(6506007)(478600001)(86362001)(2906002)(6486002)(8936002)(41300700001)(5660300002)(316002)(31686004)(66946007)(66476007)(8676002)(66556008)(6916009)(4326008)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTNobVcxREx0dlB4U1NmUjRoNXJWMVIvOHVDMCtqSnVtWFhWcGtxVXhKdVNJ?= =?utf-8?B?U1VuNko3cVgvWU8wVG9nZ0VHcmZHcUZrSTQzZFM0ZkJkMHBiRk5sQ21VWHU1?= =?utf-8?B?REg5eDF4N1JGd0x3ZVRPUVhpQi9jbjVWK3JLTnAyRit1SzNtUjlBanlsa3N1?= =?utf-8?B?Qy9sUk9uaHpWR0dqSWdmUnJ6cGZyaC9WR3BGeFY3bWJ5ZGFsREYyelpoRkg0?= =?utf-8?B?MEw0UzlpdnVkNkpKb3lxQldZaW5ZR1FFSDIvblVmTEhFcDZIcTF2TDZBRGxE?= =?utf-8?B?RGczMXo0R0syWDhBbjZTQUZmaXl0M0tlUkVJckVpTG5UN0ltdmQyek53Yks3?= =?utf-8?B?ckxwSjBxUmxCMDlKOWJIRXluWHE0RFg4VWhhYVY0WDcwTGNSSEVaZTRsM3dy?= =?utf-8?B?NW01UlpoMEVReGlybEkwbW1maWN0VjIyejYyQnNmUGFJdU1KRTg4WThSbGhE?= =?utf-8?B?d1Iwa0VKU3ZZaXhFT01QUDM2SThQaU9iQnQ0OW4weXdDbmRyTEVtTmdBNVFT?= =?utf-8?B?NXBYNnZSd20vTGkrbjFUbzFWWUJ2Q3hBaWZmZEVXZWJOOStkMUVmdExaNDhQ?= =?utf-8?B?OXUyaTRRWjRjWWNJMHBINTdQd2RBOG9udXo5bzRxRldoQ1dMcDdXNlI5WFEv?= =?utf-8?B?TWlBWThQMTVwSitFS0ZHdkczTmRLU2dLVnJqVTlvNC9udzZLMWVWVlNoQ0l3?= =?utf-8?B?bDlsNDdTTGFXdDZCRHRzRVVBTm9VeE1CQTZFeE5MRUdpRGFwZmNLSmhHaElV?= =?utf-8?B?NC9PMWNacjNwZXc1aHVtbkYvOSsxcWZQaUlUV2JMb3hGbUkzQWFlU2hCVGRS?= =?utf-8?B?Qnk0cmFXMSszeVd5MnJWblBsL0RmaUJHOFBVa2pldW5ZdENKZjJzbkU4QXVj?= =?utf-8?B?eVpPYkJ3aUZwOE16TkkwZ2NMQldKcHRjRkV0U0t5c1NzMFdXMnVjM3kwT2NU?= =?utf-8?B?a3Z2RllZa1dQMXp3dDYvVTZGVFN0RVUyRzVMbnNjY3lEMXRzYStGWWtOQ2Q1?= =?utf-8?B?aktXTUh5aEtuVXdQU1hpNmF2ZVRFRnRUMGY5amx4bFVqZ2k2RW0ya1NwQi92?= =?utf-8?B?anI5QWt2MzlRa2paYWlaNFhaaWlHMVp2bStWSkg0ZUViOXVaT1NtWVlSZy96?= =?utf-8?B?OUZtd3YxaXhkTno5dDNzNGpjL0dNWVMrNXBRcWt5akV3b29STjlNZXlXUEI5?= =?utf-8?B?NWM0TVJtNlJnTkRVaE41K2N4SHRSanhDelUrZ3JMMHZPVUlVcUJsMEFpaGJq?= =?utf-8?B?QnAwYWU3enlkQjZsV0Nuc1ZWaCszbVhCZ2xKaVhwZkFnSWhnWWVWZS9NZjFQ?= =?utf-8?B?aXYrVEQ2cmtEcUpEZWwzaWFzclA1a0NPUE84T0sxblJvWkJudHpTSENnR1V3?= =?utf-8?B?Nm5jTmV2YjM4N2lLQThwM09FR3BIbG9BT0VVc0xpSmVlckVjS3UvSGg1RWJk?= =?utf-8?B?aHBLR1NGWjZVZzlNM04zRU1vMW5zbVpLejg4a1l1aVk3MU5EeVE5SFc3RXRY?= =?utf-8?B?K0hnT0k3cUZDT1BUb1VxYTQ1dWlkb3RSM3dGV1pvcjJIckF6S21nc2hzemxh?= =?utf-8?B?NEJnYVFiYjZUTUVJNU1hTXVYYlNDQWdkVEdOYlY4SGhBSGFvcTF4cndRazlp?= =?utf-8?B?WUgrVzhLTTFCVzRJaWdtVVliNGZzQXIvRmlZRW85aHZlY3UxZEVVeWd5VkQ3?= =?utf-8?B?dkllblJsWHBDNmlwVkRIdDJ3S0hsWG5qSEd5N3ZKZmRtWGZGbnN4eDNhSStC?= =?utf-8?B?UmJDUG9CWjVHQmVNQWR5R1lpejgrN0QxTGM1U3RtSm1IR2hHazZxci9RejdK?= =?utf-8?B?cVVpTTd1NmtUS2NuZ25hcklsRVdJNE1ZYmN3UUFWWi9PVTFWQVAyVnhJYU9K?= =?utf-8?B?Z2VpaEhpOTBWakhzTmxjZFI3eElPYm03ODU0V3ZWU2VSRmd0R1hoNTQvSUVy?= =?utf-8?B?ZFlBeW9VSEVBL01mL3UzUDVDekw1bGRDeEErN2lsdDc2RjRRQ0tpRDlGc2JQ?= =?utf-8?B?enZyWlhqN1dad1EvZkpiTTllVVI4K3gvd2xlNitkSnJjSHVCSXR0c1ROVFlK?= =?utf-8?B?MThacDhWSk1GV3lRN2xSSWRhKy9paTlqa0t2Q09NeGs5NnRqb2JlQ3dxMzZx?= =?utf-8?Q?NczwxEnMgXLJLGqEQLinr7Itk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dbbd568-9f83-43cd-209d-08db085297be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 14:58:23.1404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FVKog18ANDY4LBRO0CWYhgfBhaLOx/b0Nk8FEUnmJOd8fDWs+ZXCpFHQYwh5PVfhv9uk1hLhevZZoh5BmmpkAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9191 On 27.01.2023 18:47, Andrew Cooper wrote: > On 27/01/2023 7:51 am, Jan Beulich wrote: >> On 26.01.2023 21:49, Andrew Cooper wrote: >>> On 25/01/2023 3:26 pm, Jan Beulich wrote: >>>> --- a/xen/arch/x86/domain.c >>>> +++ b/xen/arch/x86/domain.c >>>> @@ -2015,7 +2015,8 @@ void context_switch(struct vcpu *prev, s >>>> >>>> ctxt_switch_levelling(next); >>>> >>>> - if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) ) >>>> + if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) && >>>> + !(prevd->arch.spec_ctrl_flags & SCF_entry_ibpb) ) >>>> { >>>> static DEFINE_PER_CPU(unsigned int, last); >>>> unsigned int *last_id = &this_cpu(last); >>>> >>>> >>> The aforementioned naming change makes the (marginal) security hole here >>> more obvious. >>> >>> When we use entry-IBPB to protect Xen, we only care about the branch >>> types in the BTB.  We don't flush the RSB when using the SMEP optimisation. >>> >>> Therefore, entry-IBPB is not something which lets us safely skip >>> exit-new-pred-context. >> Yet what's to be my takeaway? You may be suggesting to drop the patch, >> or you may be suggesting to tighten the condition. (My guess would be >> the former.) > > Well - the patch can't be committed in this form. > > I haven't figured out if there is a nice way to solve this, so I'm > afraid I don't have a helpful answer to your question.  I think it is > reasonable to wait a bit and see if a solution comes to mind. > > I'm not aversed in principle to having this optimisation (well - a > working version of it), but honestly, its marginal right now and it has > to be weighed against whatever extra complexity is required to not open > the security hole. Well, the condition can be extended accordingly (see patch fragment at the end), but the question is going to be whether the more complex logic is going to be worth the savings (especially in case it needs further extending, i.e. if I still have overlooked something). > And FYI, this (general issue) was precisely why ended up not trying to > do this rearranging in XSA-407/422.  I almost missed this security hole > and acked the patch. I appreciate you having forced us to be cautious at that time. Jan --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2067,17 +2067,26 @@ void context_switch(struct vcpu *prev, s } else { + unsigned int feat_sc_rsb = X86_FEATURE_SC_RSB_HVM; + __context_switch(); /* Re-enable interrupts before restoring state which may fault. */ local_irq_enable(); if ( is_pv_domain(nextd) ) + { load_segments(next); + feat_sc_rsb = X86_FEATURE_SC_RSB_PV; + } + ctxt_switch_levelling(next); - if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) ) + if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) && + (!(prevd->arch.spec_ctrl_flags & SCF_entry_ibpb) || + /* is_idle_domain(prevd) || */ + !boot_cpu_has(feat_sc_rsb)) ) { static DEFINE_PER_CPU(unsigned int, last); unsigned int *last_id = &this_cpu(last); From xen-devel-bounces@lists.xenproject.org Mon Feb 06 15:11:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 15:11:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490547.759295 (Exim 4.92) (envelope-from ) id 1pP39B-0001qo-QS; Mon, 06 Feb 2023 15:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490547.759295; Mon, 06 Feb 2023 15:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP39B-0001qh-NB; Mon, 06 Feb 2023 15:11:09 +0000 Received: by outflank-mailman (input) for mailman id 490547; Mon, 06 Feb 2023 15:11:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP39A-0001qb-B7 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 15:11:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b20f20f-a630-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 16:11:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E7E68605FA; Mon, 6 Feb 2023 15:11:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C4D45138E8; Mon, 6 Feb 2023 15:11:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bdNGLooY4WOPYgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 15:11:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b20f20f-a630-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675696266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KpHr+Y9+a3hDRQQMa5H1VKv3NddZ2It3j9aj7SG5DVQ=; b=leaPvyVAo7haeFuN986NihuqBa+tPkVMF93vPk3+gwASkCpyaJpDhNcsv7tnb9X+Hk70ew zfJlz/200M+QyWdRUgOIktvmX4NeK7D+zsKepB7lVsSmsh6+f84e5h7EQhwBoqLv9X/Sf6 iuccXrDobDQEuBWxgB8JRHkG8YjXg+o= Message-ID: Date: Mon, 6 Feb 2023 16:11:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] libxl/x86: use public interface TSC mode definitions Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> From: Juergen Gross In-Reply-To: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------iRv7JkIQkBWK8waNy44CFsKb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------iRv7JkIQkBWK8waNy44CFsKb Content-Type: multipart/mixed; boundary="------------fbaDGnriZE1dHNRdv7s9ph60"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu Message-ID: Subject: Re: [PATCH] libxl/x86: use public interface TSC mode definitions References: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> In-Reply-To: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> --------------fbaDGnriZE1dHNRdv7s9ph60 Content-Type: multipart/mixed; boundary="------------J5PSBULEoZ6qjjrMLDANDEET" --------------J5PSBULEoZ6qjjrMLDANDEET Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTM6MzMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBOb3cgdGhhdCB0aGV5 J3JlIHByb3Blcmx5IHJlcHJlc2VudGVkIGluIHRoZSBwdWJsaWMgaW50ZXJmYWNlLCBzdG9w DQo+IHVzaW5nIGxpdGVyYWwgbnVtYmVycy4NCj4gDQo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdl IGludGVuZGVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------J5PSBULEoZ6qjjrMLDANDEET Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------J5PSBULEoZ6qjjrMLDANDEET-- --------------fbaDGnriZE1dHNRdv7s9ph60-- --------------iRv7JkIQkBWK8waNy44CFsKb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPhGIoFAwAAAAAACgkQsN6d1ii/Ey+q VQf/YcPu9/jpqkVdmdAtU8KtB8Bth5Bhiq7hN59XRtrmdXaGrRKrPtkntKO4SaauZ/SWXfhbQRYG m9GJK0k30A6ETII34zvR/3+XMYshySpKH914kMtEKfJb379fuWA+Z8QfBFno3rE83V1fNljfwn3O wAUOa+6K+0pNfkWG9qkSIMc4ukRMRlshxA75Ljsxqf8/M/CqP98EQA7GL05CrxpRDJst4bP81mB5 5cwuHyS3UKObWhTBT4aLEKT1pUkgPcmKLFVbFI9NZuYMyZgRDhct+7QGaILQRCMEJTJsxI2Sb5QC BZyt9esudmrujtcjesL1QJYdInqInOOiDPZLEAkQhg== =YBqe -----END PGP SIGNATURE----- --------------iRv7JkIQkBWK8waNy44CFsKb-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 15:32:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 15:32:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490554.759306 (Exim 4.92) (envelope-from ) id 1pP3TY-0004S9-Fb; Mon, 06 Feb 2023 15:32:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490554.759306; Mon, 06 Feb 2023 15:32:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3TY-0004S2-Cs; Mon, 06 Feb 2023 15:32:12 +0000 Received: by outflank-mailman (input) for mailman id 490554; Mon, 06 Feb 2023 15:32:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3TX-0004Rs-Ar; Mon, 06 Feb 2023 15:32:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3TX-0003Aq-8T; Mon, 06 Feb 2023 15:32:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3TW-0004DH-UU; Mon, 06 Feb 2023 15:32:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP3TW-00046z-Ty; Mon, 06 Feb 2023 15:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xL+W0xrDBHWcDDvn0ozWxyrmCx/uG5GGXGExGfPW0+U=; b=xeh+H9Z3GQgnJLEUM+Ic2YYGRZ hTyNAQu4EMBN/Ckk4rEBmM8lk/mUcGehYSvPgqPsWRUKBPvb5SGJKWqlcehVDV+Rco9LPGcRGhGbR P/AjX8+nT8ScPw7PMnsY0nLp4ogfAWyrF2iwxOwQMST8J1Tt6IUduBRmCzKp7wr+AP4k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176407: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=b52388129bf0097954515c097e83e6112de1b579 X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Mon, 06 Feb 2023 15:32:10 +0000 flight 176407 qemu-mainline real [real] flight 176421 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176407/ http://logs.test-lab.xenproject.org/osstest/logs/176421/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176421-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu b52388129bf0097954515c097e83e6112de1b579 baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 3 days Failing since 176352 2023-02-03 17:40:20 Z 2 days 4 attempts Testing same since 176407 2023-02-06 01:08:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Alexander Graf Daniel P. Berrangé David Hildenbrand Drew DeVault Emanuele Giuseppe Esposito Emilio Cota Eric Auger Evgeny Iakovlev Fuad Tabba Gerd Hoffmann Hanna Reitz Helge Deller Idan Horowitz Ilya Leoshkevich Keith Packard Kevin Wolf Laurent Vivier Letu Ren Marc-André Lureau Marcin Juszkiewicz Mark Cave-Ayland Markus Armbruster Mike Frysinger Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4330 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Feb 06 15:35:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 15:35:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490564.759321 (Exim 4.92) (envelope-from ) id 1pP3WT-0005A4-0J; Mon, 06 Feb 2023 15:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490564.759321; Mon, 06 Feb 2023 15:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3WS-00059x-Tf; Mon, 06 Feb 2023 15:35:12 +0000 Received: by outflank-mailman (input) for mailman id 490564; Mon, 06 Feb 2023 15:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3WR-00052w-HN for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 15:35:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d59f522e-a633-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 16:35:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BA766061F; Mon, 6 Feb 2023 15:35:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 268BC138E8; Mon, 6 Feb 2023 15:35:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5Hj2Byse4WM8bwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 15:35:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d59f522e-a633-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675697707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dGfLuu/ZorhBxx/TbawrsNpt8CBswzePx7SV5hJpPYk=; b=LpQaXqH6HGS2wE18v9f6oDK3Q08Rifxy1U4VpHy4gP0CQRErkmMpUPkzOf2EG+0OtKYOyQ Ov3fzfofnQGiPMgt5ggaUTJ0PnBz8NGAHafl7MEmhArE0dUvhKqr6GJf5PSw/LVRmDn9HW O/iI6+G8FDyyY57xu3AvYHwvtqb9UEU= Message-ID: <2fcd7ba4-a388-ad28-64aa-a599882b4f9f@suse.com> Date: Mon, 6 Feb 2023 16:35:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> <20230206120526.242njyptovkpz3jl@begin> From: Juergen Gross In-Reply-To: <20230206120526.242njyptovkpz3jl@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------E0OOKWO0NiPn66yq2q0cE1v0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------E0OOKWO0NiPn66yq2q0cE1v0 Content-Type: multipart/mixed; boundary="------------ofXfWL0jC02OPXYzfjya7tIT"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <2fcd7ba4-a388-ad28-64aa-a599882b4f9f@suse.com> Subject: Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230203091809.14478-1-jgross@suse.com> <20230203091809.14478-8-jgross@suse.com> <20230206101341.5l7cxb2vvregskrx@begin> <77d6d486-5ad5-1f13-e223-79295707d090@suse.com> <20230206120526.242njyptovkpz3jl@begin> In-Reply-To: <20230206120526.242njyptovkpz3jl@begin> --------------ofXfWL0jC02OPXYzfjya7tIT Content-Type: multipart/mixed; boundary="------------CX9llXcnU2Kt063y0y38DmiH" --------------CX9llXcnU2Kt063y0y38DmiH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDIuMjMgMTM6MDUsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgbHVuLiAwNiBmw6l2ci4gMjAyMyAxMToxNzoyNyArMDEwMCwgYSBlY3JpdDoN Cj4+IE9uIDA2LjAyLjIzIDExOjEzLCBTYW11ZWwgVGhpYmF1bHQgd3JvdGU6DQo+Pj4NCj4+ PiBKdWVyZ2VuIEdyb3NzLCBsZSB2ZW4uIDAzIGbDqXZyLiAyMDIzIDEwOjE4OjA5ICswMTAw LCBhIGVjcml0Og0KPj4+PiBUaGlzIHBhdGNoIGlzIG1pc3NpbmcgdGhlIGxpbWl0YXRpb24g b2YgcmVhZC93cml0ZSBtZXNzYWdlcyB0byBzdGF5DQo+Pj4+IGJlbG93IHRoZSBtYXguIHN1 cHBvcnRlZCBtZXNzYWdlIHNpemUuDQo+Pj4NCj4+PiBJdCBzaG91bGQgYXQgbGVhc3QgYmUg YXNzZXJ0ZWQuDQo+Pg0KPj4gSXQgY2FuIGVhc2lseSBiZSBsaW1pdGVkIGJ5IHJldHVybmlu ZyB0aGUgcmVzdWx0aW5nIGxpbWl0IGFzIHRoZQ0KPj4gbnVtYmVyIG9mIHByb2Nlc3NlZCBi eXRlcy4NCj4gDQo+IFN0cmljdGx5IHNwZWFraW5nLCBwb3NpeCBhbGxvd3MgdG8gcmV0dXJu IHNob3J0IHJlYWRzLCBidXQgdGhhdCdzDQo+IHVzdWFsbHkgb25seSBoYW5kbGVkIGJ5IGFw cGxpY2F0aW9ucyB3aGVuIHRoZXkga25vdyB0aGF0IHRoZXkgbWF5IGdldA0KPiBzaWduYWxz LiBJJ2QgdGh1cyByYXRoZXIgaGF2ZSByZWFkL3dyaXRlIGxvb3Agb3ZlciB0aGUgc2l6ZS4N Cg0KT2theS4NCg0KDQpKdWVyZ2VuDQoNCg== --------------CX9llXcnU2Kt063y0y38DmiH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CX9llXcnU2Kt063y0y38DmiH-- --------------ofXfWL0jC02OPXYzfjya7tIT-- --------------E0OOKWO0NiPn66yq2q0cE1v0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPhHioFAwAAAAAACgkQsN6d1ii/Ey+7 owf/d8FYHsMx6HjK3fQ8JrLkXyYI9TyLRZIblaiBFpLVZEo0mpRJmwiNcNMSAjRR+ODYOwHe1zCy 4S1lwOoFOwkiIAC5Ss8YaeYRCuMmGlcINb3mUeidrarWGAHdX98d7Q2cK87rH3Kmy9y8twcTAtV5 HY7C1YYCGRsCs+aXTqqZNDYpLtonTGQsAHda0nejAahQRGAE1szmObVqKXejgEYKmAZofabRthtK E6qaPgE/F5amqiUxLTpDiwQBODLWGubtiN/XbSZiPNyLDQ4UBkcMUztZA1KLnKo3pxTnlu2jDbvp Fw3Twpvwvsxj4jpCgXAQIX6O0tvd055B+FBOa7kDPA== =T4vE -----END PGP SIGNATURE----- --------------E0OOKWO0NiPn66yq2q0cE1v0-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 15:52:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 15:52:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490573.759332 (Exim 4.92) (envelope-from ) id 1pP3nI-0007pg-FA; Mon, 06 Feb 2023 15:52:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490573.759332; Mon, 06 Feb 2023 15:52:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3nI-0007pZ-CS; Mon, 06 Feb 2023 15:52:36 +0000 Received: by outflank-mailman (input) for mailman id 490573; Mon, 06 Feb 2023 15:52:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP3nH-0007pT-7y for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 15:52:35 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42f7adf6-a636-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 16:52:32 +0100 (CET) Received: from mail-dm6nam04lp2041.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Feb 2023 10:52:28 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6052.namprd03.prod.outlook.com (2603:10b6:610:bf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 15:52:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 15:52:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42f7adf6-a636-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675698752; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=TO/EOIlXqhwx7p11Bl7KDym+tfvER+7l0E2fOFjUnMs=; b=dFWcgbBx297Io08r8h1CUQmoLV0LPBvLpqLwLoFtBrCedglerhBdhYCI jMjMPu7UjiyweJYT0cp6lzwr8HvdqXojynfMHWkL2rlAsPVi+lpADS9Ms 40pB8kwU1M9IDauGa4beo6IsdYXrTFTMR01DoeZBDq366La37PfYWgpJs c=; X-IronPort-RemoteIP: 104.47.73.41 X-IronPort-MID: 96263152 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FPWSsKPzHOv4mYXvrR1/lsFynXyQoLVcMsEvi/4bfWQNrUp30GQFn GtNWmGGbP7YazPyeNgiOYm08xxTu5DcnNZmQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5gJmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uxZE2wR2 NsVEx82fy+CqP2GzZmjddA506zPLOGzVG8ekldJ6GmFSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxvzG7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6Rx32gAd9IfFG+3vBbiRqoxkUONDofSkL4u9e21E2+eesKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHsqCRSH+b3qeZq3W1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWr7ccl8kQzI2g4EvKxTmro/D0ohUd4wzWWiep611/bYv9O4iwswCHtLBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4u1mS+G8B3h44RALU IronPort-HdrOrdr: A9a23:YXPWfq56u5219POxigPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="96263152" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iqkmok6GURx0BD6q7jnztJRwPF5/DkSmN72E36K5qKT6PGOAlO5DJrt4sJAWulh1HcNWSBYdUcjhtGJ6XEmu8jxk2yGyhFyEClf5x7E5BIYzvThndq9gX9aOklRfalRfOHhmhUw28zFipWAd0Mf52isZhsZvpJBM0ndP1nCKLx/Uct0ywim6YmVX1ReoQa97dYMmKbOggb1fn+9+c0xWTcXuf2HBvqYHFdxLQRzzPc8JaKQC0P4FqSTXXgKMvNIveTOrzJ2cPthiPG5vDj1/XxN8Z6bTYmoQBSURW/hBICxjj4IEmrn3+NC8ywKmHdTQG3yC1SRH9dZXUHVm5cKK+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TO/EOIlXqhwx7p11Bl7KDym+tfvER+7l0E2fOFjUnMs=; b=JMNdBSVdK8IWiqYMVnWvv2ay0JT9BKRA43XHJOImQlJCbKagHMH/x8AACNYVQwhapO67ZslBblw0IBze6URz3P+3Gqlz9VOg92kkkKquGXEFPrFlon7udNt8+dWfMgPQcQih/WlT4edpcGIwgi2VbxWOc5994FRwcFj+Bvr2MRMdVSShd2aBxDOg66U6k1Kzba4n2IVucpCL/0xTbribEh3R+AmEpizTnl9MZAiOSGssaIECEVoZBIrJ5j9nFDCRz/V86xOxoJUC2mA2N6bW3lnfyhMNL5Oc4TkX3Y6TItIR1vEgkkvmvEYWu4XjMutwAUYC32QsjrY2g3UF6pQ7Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TO/EOIlXqhwx7p11Bl7KDym+tfvER+7l0E2fOFjUnMs=; b=ciWVMSMq7UVWKjyOdGvA6uXJz0kfaxECeKAOMlZUC0L1o82qD5lZ5ga2pamj18JggIsRf3q49UVe+fAuRpPNmIikW5UOmrLRyqNpYwId1zDVztOdF488dTXqpkND8z+82VwcJV9kKrh5ZRJbXlqHcieFIL5H55/cnG6erFfuHFQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <2b41d9f5-b839-4fab-96cc-7548538cd758@citrix.com> Date: Mon, 6 Feb 2023 15:52:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH for-4.17 v6 1/5] libs: Fix auto-generation of version-script for unstable libs Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-2-anthony.perard@citrix.com> In-Reply-To: <20230120194431.55922-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0383.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6052:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d896ecf-0f6f-4e3d-6af8-08db085a24fc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4tZc0G02HB423EofiyoHx5AzmFVUoPKFeQbuQm5psY7Qur2fLBEpRI+39ColUvVumz0B0RuwgND3Xlz19CL7lddbN2NUmZopj1FGdy3dmlVv+y0gXRGi6GHAstRPkTsdXOCjfye1+6z+FG5ZCBElEIn4QcQ0XT4En6Ysww0Z4aYjWGiPlWYbG+zZfNVNAmwjBMdlFpxzf3bxe4s+BDz128bkr/hrMHOqK7HE0OTYn7tgQ3qPLfUwa8pz9TvVhCUkmM2dDKa/w8BMolsQfi7Y0iw3Fdw7jo/mKwxjT20QtPTsmzwX7YCiuOeN4ej8vOf4Bez7fSEI9YfChJNj627EeNhO9BX/HLpAaGIMmJp3SMgQyDxiPaU3JB50iPrMYSfQRT6TPsvNmYtF63hEDrkrmTsTiPwKSDo7DvCHUoQNv5pdZ7jVcr0gvjebqj+0dEimtsjKJ+xeGEkx9NpoYV0ioBWWwOEA5eG310yGemPWQMTyUyjboLnMjIk7IdQxpq5+jPANreP7mEQumgFhxM7ya16MrekwD+PmwVUzKZ+yJAg6xdCw7IVNMg3y3+8Zh1GqkrMiTEwGPq+DBrgA1/lOGhvXDVdyEqHSVefGIEzy85VSwy28CSZd9sOszQLCxePk0Z8/Xk8sPIbZ0CiARWgAx+Jmn8/1nBURLwZ0ywDaqQCw11lcktRoh7zQo7tjdgEzp+SAIPhGSFemYILFQ0iDCfGaTYtcqCjnjZ2/ylxxAqc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199018)(5660300002)(8936002)(41300700001)(83380400001)(31686004)(2906002)(66556008)(316002)(66476007)(66946007)(26005)(8676002)(6512007)(186003)(4326008)(31696002)(82960400001)(36756003)(86362001)(38100700002)(54906003)(478600001)(6486002)(2616005)(53546011)(6506007)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjBGZzRXVktadDg0NzZqY1N3Ry96VU4vaVNBZVYydEtZTUd5ak83MjBaaFpj?= =?utf-8?B?aklISmF4azAvVk1ISVpyVFZnVDFGK3dKNHNhWFNPOG41NVhjTUo2TVh4WTRP?= =?utf-8?B?bWJzbDR5aFNQMTZmYlVMU2wzL3RvTklRQy9SdmR5NG9FVXphOWd0cjRTQ01B?= =?utf-8?B?VGlVaGI1OG1ibWJRTFU0bklkTGFWR0JVRTVmMlBwSk1JTWRGRVR2RDdKaFdY?= =?utf-8?B?RENyVXF2am1tdEdWQk5TcENlb3ZLaGUvVWl4cTBhNG1vMXlvWERJVFFOS0Q4?= =?utf-8?B?MVFZRHJwOWprdVBJOGRuamVoYmo4MkR1NERXRnN2YWtpN2IwRFgrdUx1d213?= =?utf-8?B?bGpqL0FVRVdXNytzeEpsMHZIS3dZTk8wWlphajVZM2hOZEU2RHRmSTlLVjJ1?= =?utf-8?B?R25BZEhhUzVYVnRVUUg3VWhFYmNVUm10NExwb2dTVWtCS0szNzg0MFR1R2V5?= =?utf-8?B?S3RxOThrbkVGWW9WcWViV3FhWjgxdGM5SnJNdnBuVkRUUnBuQWRndm9PQnQw?= =?utf-8?B?OC9YRk1qbFdzd1FrMmh5UjQxSG9VUEVMbDJFdmdrSFRsZm4xNW1wc2NxKy9P?= =?utf-8?B?UktTVmZ0WThaS01vaHRoWkZ6QmgwZndNbW5HVmZFWjBtZkQ3UlRqRlZXbXJq?= =?utf-8?B?SnA4cGQzZmdjWmJQOTVOa21zWlcxNCtrWDVCZGZjVVJ3Ni9XUjBrVlJrZ0Fi?= =?utf-8?B?SEdWRjREaWhzVnZSVXhXcG1PRkVMMm9uN25kMzhtTFVyKzlQMEwvbk9PV0dU?= =?utf-8?B?bmgwR1laN3lSNk5Vc1dYcVF5QTdYU0hWTVRSb0R6dm9IaDcvM1BtMnpUSE4v?= =?utf-8?B?NUxxTkl0bW05RjhhemF0TFN2VFRiS0ZSUEx5a2dHaG5SZ1hVVlN5YzcxZEl3?= =?utf-8?B?cWhudUE4TWowa28yWE9oeGQydXF5VHM1TVFieGJuVFhqYnk3Z010Zk1VaGM3?= =?utf-8?B?aTB2c04wejBrcUhXTVpVVDVFcmNMRVZJYjZrRnBnbGczU1NBczJvMUgrMDYy?= =?utf-8?B?N1FiMFV1cmRWZ0pOU1A4T1NCSnAwcnVBMlJramg3MFhydEVkMEpZU1gzbWhm?= =?utf-8?B?RDJrZXoyVTNuNWpOOU9hTTg5MTFWc2RuVFVyNEphbnkwS3JvZmRtTEs0dUFJ?= =?utf-8?B?VHYrSW01Y2FOY1pLUWhCMzJ0UWtpZHpZRFhnK0E5U0loRTcxWGszRWpwWWd5?= =?utf-8?B?R0xIdDdjS1RlNjQ5WGh1QUV3SkdXTDZtM1BrM2NMNFdBU3F4KzVrckFteTkw?= =?utf-8?B?TVZiTGcxdkJ1cm50QW82NW1kRUk5eUVvTDVDTHdYTkR1L0FFNWFyWjQ5R3dw?= =?utf-8?B?ZU91d05EY0NXdG14MFE1SGlwdDRHSkc4RkZCYVFUR1hlNDloa3dIaW9xTVpW?= =?utf-8?B?Q0tpRDFQdnh0UWdyQkRoTVFyeGloVXAzc2hMRlgwdngwTTA5dUhnUnA3dTZM?= =?utf-8?B?cTlyU0syWXNVMERWaXBBdEtzamJNUUQrR1hGTk84TCtRbkhJV2srL01GdEpr?= =?utf-8?B?M05VNGZqakY1MHZJT3g0N3ZHZWxZd2FtSmJ5b0hFYStBeGV0NkVZUy9HeFVB?= =?utf-8?B?SXJicU5HZ2tFMjd3UW5pc3g5WnVzaWJWMVdvc0ZtSFN0bm42YzBPMWoxYUti?= =?utf-8?B?cG4zam1YNUJsaFd3SElKbTdYYjBMaG81M3lkODh6SkdPbXVMb0IrNEt5Nm52?= =?utf-8?B?WmZwc092a2dJV014NVFObDB6aUViMUdPVFRtK0twOFRscktqUkcwRW9GZFlJ?= =?utf-8?B?TWhHOUx0OFd6K2NxRlBZclptdFNnZEQ3WHlkRk8wVjBvTHZPMWxMRnVDTUlk?= =?utf-8?B?TzhkS1laMjZXWmpVZFhPaTNvYkMwTW1MQ2dUY2N1MjJKQ25iTytEd2tzY0xy?= =?utf-8?B?TU50T3daNnVtV3oySDRxaU5Xb3o2dHV1N2o3ekNsaExaRlpBMXFyby9QbXBB?= =?utf-8?B?R3FiSWcrYVZ6dXd1cm1kc3l3ZjNtUmVkWitPUlZyMzF0SWV4aUQ1RkQvaEtH?= =?utf-8?B?bUZQWTZyU0M3UFRPc3RFZnRyZlBjNlNMSXNFTDBTNlJWdk1hREhRdGZqSGFn?= =?utf-8?B?ZmR0dGpEVGZsc3BHbzdzWW5URE0rdWNlNjlwcWN4Q3oweUtmNHp4R2ZGaEdw?= =?utf-8?B?YjFCb3M4MDkrd1Y0Qit2THpCK1daL2w0SmZOcVp1eFZBZEJCWCtTYjIrVm8z?= =?utf-8?B?WFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KXmky5aOitV1k0WK3S4NKy7kvah7y7adferSPkwkVZQE9W8zR4Y/fqlDd4jrXIZgvX2Unn4RMvKDVvHMCNu6i0I2X98jSvs5hzoQQ1fWI7aWWuP1E73XsUFxwfZfcauFleRfq26/BFDWpxZoFW8B+2Rh1PbzEzTKZSNxIQg5gYTvLe4h5YEDR9vFbxLb9H85+GRfU2TeLfqKwLWtjDa9hZFHaEBHMJZcfdbWT4qtePr8sCusY1iuLwqs8GyokonSLjRcUevBUNrovx2aXJB5HSNx2J7mrBGZwJ4JMKtUuOyjULgR2sM0y9/WRuhq8B5OwT9aPFkuO5CQfiwb72EIJf6w8dhydlmvaeU0XdviKWL/7uEexe1JIX4lhQ/FW6KKAdi4CfhHmhXdQ7SLPavXDhvKs11SGL/mv2+R3Lh50G8o0gSc4qqZSNyhLhAmqZAuHKIjnFwRagMsfpH4LcVvRPrYMsONv7ITYmvzoc9EIgdZ1L3GDyZyKYi1y00S5kKWzyLWrxOv94InNgtStr3GzOmXNxJszt0zZbOL0vKcEnep52n3rPLdhD6cOINj1Vmh8tBmR5S4cufY+Y2i0fHi+z36TsWq/mxWcCQ27dk20WeIjd6ddhz+1eVGAVEMCtQgkasxjdDRuJHaxj8Auc84tGGqZudw958H9XFyxTJgQNxjzpIeOuMc7aCyf0or1YY8jPGx2MhQvBqp24otwCGSUhga6ij7Fvg7w8+dMTUHlPK/rYitNKtkMnjpGWVPBJa13yDpZN/2/n8aTqWvOcqWmgoV6hdxnU4UC0OS5sxa9MBhX6lA++95NceILyRpf9i8UIwyJ+tRoxXK4A9IFtd+vL45aDKa6LOxRcqUym2BdWs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d896ecf-0f6f-4e3d-6af8-08db085a24fc X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:52:26.7251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f4U1faapnya4El1NfCLWX/qEfncqzrDsZYohPfkvPILqR5tlwbkAZ6UMr29uaoRkwER1u3Eq6Vi3+Khh7k2uSx5WPr8UFWJu3k+JA5IRZKo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6052 On 20/01/2023 7:44 pm, Anthony PERARD wrote: > When there isn't a version-script for a shared library (like for > unstable libs), we create one based on the current Xen version. But > that version-script became out-of-date as soon as Xen's version > changes and make as no way to regenerate the version-script on > rebuild. > > For unstable libs, we only needs the symver to be different from a > previous release of Xen. There's an option "--default-symver" which > allow to use the soname as symver and as the soname have the Xen > release version, it will be different for every release. With > --default-symver we don't need to generate a version-script. > > But we also need to know if there's already an existing version script > , for that we introduce $(version-script) to be used to point to the > path of the existing script. (Guessing if a version script exist for a > stable library with for example $(wildcard) won't work as a file will > exist when building the library without this patch.) > > We don't need the version-script unless we are making the shared > library so it is removed from the "all" target. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:09:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490581.759346 (Exim 4.92) (envelope-from ) id 1pP43W-0001oJ-VY; Mon, 06 Feb 2023 16:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490581.759346; Mon, 06 Feb 2023 16:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP43W-0001oC-SN; Mon, 06 Feb 2023 16:09:22 +0000 Received: by outflank-mailman (input) for mailman id 490581; Mon, 06 Feb 2023 16:09:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP43V-0001o6-Nf for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:09:21 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c974987-a638-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 17:09:19 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id h16so10845219wrz.12 for ; Mon, 06 Feb 2023 08:09:19 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id o7-20020a05600002c700b002be5bdbe40csm9826652wry.27.2023.02.06.08.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 08:09:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c974987-a638-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xFsZzbiGJaBKLs/rFiMkljY9r+p3AVj/m6uaTSmp/nA=; b=k7C4ba208ZbOa2+Cdojg4SlTdP2Twwvb3aCSd5f+0v8tgAafYTaagvX9atSIYIFBsW Ndqt9GqxIL8wE0erV3bwCwW7gV6kIM5lQEQ6H//WNHDQqHDuGaU1OcInGeelH++v4z2H OOhRoE/9Uuv032yS63ay4GrEUPO2k75WleuBbkrXxNytimoq9bryVwUqEXH8A1IqigjR 2Q79tzEaEcQTdTVkTTnx0+YyPPOVfPyMLVaPIbqb5k3jKWFCJQanxMgkTKoGgGqw5tiS tW8VvmpqPKRtCjw4paNUsECsz186nLrJL0hlK2vSp475dKMoRRvMMqootgrcYRyCndqM nHFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xFsZzbiGJaBKLs/rFiMkljY9r+p3AVj/m6uaTSmp/nA=; b=RlpckSt8zBdU1oYIaD2UAUcdbMiOTJzpwHuJtEVg7zPn4znyek0Nb5C8IELVQPCNBL 1QEir+f8s2Vt7h1LOSB3wf0Hc1omWQmceIrmKiSXSt+hxuSRr/denh/ZmO8lLB1exuX6 +SK3C9LANWNBrK2UGH+Fnxg+V9+jwBsgdC7x2kDrYE709qi0RyltYV/O2vL7Oi8MfP9D 41uTa/iwsT/P3EF/MxIWAJVJ+3gHpee7yqdbmjDlsd4zUk6rqJaSTbN6WyjOcXA+NLLE j/EGBEnPY94+rSIWlZEHtjRMW7OUnWXCVjy6Ggf0VCbrbDETAS+ZiQVWxLEYrMUBXzvE G88w== X-Gm-Message-State: AO0yUKU9hORDy8epk7SCrDjnH4u/eReOjAxYmgQYJWYheEtW7J7MEk4B cBwLDc+jaOEEhANdIjuur6A= X-Google-Smtp-Source: AK7set/YK1kfkBko1SP0df3Zb9yhuvDHn1wSrJOt9mjjmRn8Kv55bYenT3715SNxdosUUW4Qjm2EeQ== X-Received: by 2002:adf:e4c1:0:b0:2c3:f06f:850c with SMTP id v1-20020adfe4c1000000b002c3f06f850cmr946866wrm.31.1675699759036; Mon, 06 Feb 2023 08:09:19 -0800 (PST) Message-ID: <7b22356adb84e32601b82985cd526e9bc050dacd.camel@gmail.com> Subject: Re: [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS From: Oleksii To: Jan Beulich , Alistair Francis Cc: xen-devel@lists.xenproject.org, Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 06 Feb 2023 18:09:16 +0200 In-Reply-To: <1d63dd9a-77df-4fca-e35b-886ba19fb35d@suse.com> References: <971c400abf7f88a6be322db72481c075d3ceb233.1674818705.git.oleksii.kurochko@gmail.com> <1d63dd9a-77df-4fca-e35b-886ba19fb35d@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi Jan,=20 On Tue, 2023-01-31 at 10:14 +0100, Jan Beulich wrote: > On 31.01.2023 01:21, Alistair Francis wrote: > > On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko > > wrote: > > >=20 > > > Work with some registers requires csr command which is part of > > > Zicsr. > > >=20 > > > Signed-off-by: Oleksii Kurochko > >=20 > > Reviewed-by: Alistair Francis >=20 > There is an open aspect Andrew has pointed out on an earlier version. > I think it would be quite helpful if that could be settled one way or > another before this patch gets committed (which formally may now be > possible, depending on whether that open aspect is considered an > "open" objection, as per ./MAINTAINERS). >=20 I will change it to 'G' as Alistair doesn't see any sense to restrict ourselves: https://lore.kernel.org/xen-devel/CAKmqyKOecoz91e-4-KZUdgT5HNhuwuN83tpFR+Hm= wkUPb2r3ew@mail.gmail.com/ > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:09:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:09:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490582.759357 (Exim 4.92) (envelope-from ) id 1pP43j-00026S-6x; Mon, 06 Feb 2023 16:09:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490582.759357; Mon, 06 Feb 2023 16:09:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP43j-00026L-3S; Mon, 06 Feb 2023 16:09:35 +0000 Received: by outflank-mailman (input) for mailman id 490582; Mon, 06 Feb 2023 16:09:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP43i-00025u-57 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:09:34 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2c95315-a638-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 17:09:32 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 316G95Bs048521 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Feb 2023 11:09:10 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 316G94d5048520; Mon, 6 Feb 2023 08:09:04 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2c95315-a638-11ed-933c-83870f6b2ba8 Date: Mon, 6 Feb 2023 08:09:04 -0800 From: Elliott Mitchell To: Julien Grall Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Message-ID: References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15b88500-89b0-507a-601c-84a8102bb550@xen.org> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: > > On 06/02/2023 07:29, Jan Beulich wrote: > > On 22.07.2020 19:43, Elliott Mitchell wrote: > >> Unlike other unsupportted options, ACPI support is required to *boot* > >> for a number of platforms. Users on these platforms are unable to use > >> distribution builds and must rebuild from source to use Xen. > >> > >> Signed-off-by: Elliott Mitchell > > > > A general question first: How come this mail dates back to July 2020? I > > had almost missed it as "new". > > I can't even find the Elliott's email in my inbox so reply here. But > this sounds like a rehash of [1]. The date on Git patches is meant as an indicator for author date. Since this is a cherry-pick of a patch which was written >2 years ago `git format-patch` indicates when it was written. This IS how these systems work. > >> Unlike other unsupportted options, ACPI support is required to *boot* > >> for a number of platforms. Users on these platforms are unable to use > >> distribution builds and must rebuild from source to use Xen. > > What platforms are you testing on? I know that this is working-ish on > RPI4 and QEMU. But this will likely blow up on one of the server we > support in OSSTest because we don't have proper support to hide SMMUs in > dom0. I've been doing RPI4 w/EDK2. Which works for my purpose, the remaining trouble spot for my purpose is needing a final resolution of the EFIFB situation. > >> --- a/xen/arch/arm/Kconfig > >> +++ b/xen/arch/arm/Kconfig > >> @@ -29,13 +29,18 @@ menu "Architecture Features" > >> source "arch/Kconfig" > >> > >> config ACPI > >> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED > >> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" > > The concerns I raised in [1] still stand. Most of the ACPI platform will > also have support for IOMMUs. If we have support for IORT in Xen, then I > would be a lot more amenable to remove the "UNSUPPORTED". And without > that support we are going to do more harm and than good. Okay, this has been a known issue for *years* and yet remains unresolved despite being a major issue. Might be an abomination, but would it work to find the string "IORT" and change it to "iort", "RTIO" or "IOXN" to prevent Dom0 from finding it? This ends up turning into a question of what are the cases and which are more common? Case1: DT-only: Unchanged Case2: Switchable between DT and ACPI, w/o SMMU: Starts working with ACPI Case3: Switchable between DT and ACPI, w/SMMU: Unchanged, ACPI mode still doesn't work, but the failure is different. Case4: Concurrent DT and ACPI support, w/o SMMU: Unchanged Case5: Concurrent DT and ACPI support, w/SMMU: Breaks if Dom0 tries to use ACPI Case6: ACPI-only, w/o SMMU: Starts working out-of-box Case7: ACPI-only, w/SMMU: Unchanged (still broken) Any other distinct cases of note? So case 5 is a problem, but cases 2 and 6 are positive. Does the classic workaround of "acpi=off" work for Linux as Dom0? If that is "yes", then publicizing that workaround (should be detectable by Xen) seems a likely short-term solution. My impression is ACPI is getting increasing support in on ARM. The number of mentions suggests if they keep going it looks likely to win. The EDK2 project has been providing an image for RPI4 and the functionality is impressive. Ultimately this is more a decision for Xen Project management, than the technical side. Are things in shape where they can be rolled out? Is ACPI support important enough to need rolling out now? I'm unsure about the former, but the latter seems a distinct "yes" since ACPI appears to be the future. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:11:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490595.759371 (Exim 4.92) (envelope-from ) id 1pP45s-0003ip-KC; Mon, 06 Feb 2023 16:11:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490595.759371; Mon, 06 Feb 2023 16:11:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP45s-0003ii-H5; Mon, 06 Feb 2023 16:11:48 +0000 Received: by outflank-mailman (input) for mailman id 490595; Mon, 06 Feb 2023 16:11:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP45q-0003iW-Kf for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:11:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f19e89e4-a638-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 17:11:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f19e89e4-a638-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675699903; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3+4sUGuF9CppcWeyGFZngKG/6LArzgH+qRUpuX7/cNk=; b=e0MZ9II+rzctqinTzRdhG8ze/EIEEiSAFzD7Pu6xmbYzSaPC+vGEmtAN hjU1P3wJnKb8B4YpO+aYr1IPbC5s+OyvtZDUnuOQ5wyLYPrursl/Jlxs2 Et3qWp+ebAHu+jsusIyxO2Am2QnLqRw4484EHjN4gy/Ku8zO32TIvqO7X s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98289369 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:VoS456osVIYabB6OnaFjbxJbE81eBmIpZRIvgKrLsJaIsI4StFCzt garIBmOParcajbxKoxyatzk9BgGuJPVydcxSlc//ig9Fy0a95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzydNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACAdUSCjl8np/K62UuVMmZ0NfOXBGZxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jOWpTSoWU9LXDCZ4Wqb/3SLhPXBoWD2AZ84G+a6sf1Yu2TGkwT/DzVJDADm8JFVkHWWWdhSN kgV8SoGtrUp+QqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOq8seVTEsk FiTkLvBBzN1t6aOYWmA7brSpjS3UQAcNWIYbDUIZRcE6dLk5oo0i3ryos1LSfDvyIevQHepn m7M9XJl71kOsSIV/7WrwmDnkxnzmoTEVgIV+Vz5Dk6PyxwsMeZJeLeUwVTc6P9BKqOQQV+Ao GUIlqCi0QweMX2evHfTGbtQRdlF897AaWSB2gA3Q/HN4hz3oxaekZZsDCaSzauDGuINYnfXb UDaomu9D7cDbSLxPcebj29cYvnGLJQM9/y/DZg4jfIUOPCdkTNrGwkwDXN8J0i3zCARfVgXY P93i/qEA3cAErhAxzGrXeob2rJD7nlgmj6NH8mqkE36j+v2iJuppVAtaQvmUwzExPnc/FW9H yh3Z6NmNCmzoMWhO3KKoOb/3HgBLGQhBICeliCkXrfrH+aSI0l4U6W56ep4K+RYc1F9yr+gE oeVBhUJlzISRBTvdW23V5yUQO62AMsm9CpkVcHuVH7xs0UejU+UxP93X/MKkXMPpISPEdYco yE5Rvi9 IronPort-HdrOrdr: A9a23:oM2aoKOWsZ7yzcBcT4z255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE+gr5nUtQ7uxpOMG7MA/hHP9OkPAs1NKZMDUO11HYXL2KgbGSuQEIeBeOudK1t5 0QAJSWYeeYZTcV/KWKgnjBYq0dLcG8kJxA7d2ujkuFJjsaFJ2Imj0JezpzZXcGOjWua6BJaa Z00vA35waISDA6f86/DnkAU/PjocfXmJ/dYRAADwM68wWVyRel8qTzHRSgxREVXylUzbpKyx mhryXJoomzufSyyhvRzE/W9o9Xn8bIwMZCAsvksLlyFhzcziq4boFoW7mPpxAwufqu70sOmM TBpB0xVv4DjE/5TyWYsBHp0wnl3C0W8Hny2XqRnHflq9yRfkNfNyMNv/MeTvMXg3BQ8O1U4e Zu5Sa0ppBXBRTPkGDU4MXJbQhjkg6OrX8rgYco/jdiud91Ut5shL1a2HkQPIYLHSr85oxiOv JpFtvg6PFfdk7fR2zFv0F0qebcAUgbL1OjeAwvq8aV2z9ZkDRS1E0D3vESmX8G6dYUV4RE3e LZKa5l/Ys+EvP+VZgNWtvpfPHHUFAlACi8a156GG6XTJ3v7ki99qIe490OlamXkdIzvdVCya goljtjxC0PkgnVeLizNaZwg1nwqL/UZ0Wp9ihv3ek6hlS1fsueDcSiciFrryLymYRZPiUsM8 zDda6/9JfYXCHT8MByrlTDsrFpWA8jbPE= X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="98289369" Date: Mon, 6 Feb 2023 16:11:19 +0000 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu , Juergen Gross Subject: Re: [PATCH] libxl/x86: use public interface TSC mode definitions Message-ID: References: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0d80ade5-dcf2-b0b3-ba4c-010962a6febc@suse.com> On Mon, Feb 06, 2023 at 01:33:03PM +0100, Jan Beulich wrote: > Now that they're properly represented in the public interface, stop > using literal numbers. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:14:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:14:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490604.759381 (Exim 4.92) (envelope-from ) id 1pP48E-0004Q2-5k; Mon, 06 Feb 2023 16:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490604.759381; Mon, 06 Feb 2023 16:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP48E-0004Pv-2v; Mon, 06 Feb 2023 16:14:14 +0000 Received: by outflank-mailman (input) for mailman id 490604; Mon, 06 Feb 2023 16:14:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP48C-0004Pj-PV; Mon, 06 Feb 2023 16:14:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP48C-0004a4-Od; Mon, 06 Feb 2023 16:14:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP48C-0005GO-Ih; Mon, 06 Feb 2023 16:14:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP48C-0007aB-I9; Mon, 06 Feb 2023 16:14:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qzuJ9PLNitvo4DnTrOsEjNoP4oSCuqZ7BJqH7hfarfI=; b=xjqc+p2l2+vuz7ZCrqteVyLNRh ei9RYQc8DE1HBF2LBBzJ6PG5b+CkzfdeMyMRF19ZC9uwRpiNxTw1pabgCllyjeGpBfoIvnoSllnAi JZ4uhorvQaNFcCl8fO0bgm1+9DMZ48z8P3ZJ9Udr0JvudV8wb4tz0mZaKqxhpJfkSsn0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176422: all pass - PUSHED X-Osstest-Versions-This: ovmf=b98e2113b53fa9c7474a820bcd94fffb352acdf6 X-Osstest-Versions-That: ovmf=9d669016d968b0f3e17ce7df16ae51d85b0adfcf From: osstest service owner Date: Mon, 06 Feb 2023 16:14:12 +0000 flight 176422 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176422/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b98e2113b53fa9c7474a820bcd94fffb352acdf6 baseline version: ovmf 9d669016d968b0f3e17ce7df16ae51d85b0adfcf Last test of basis 176370 2023-02-04 15:12:29 Z 2 days Testing same since 176422 2023-02-06 14:13:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pierre Gondois Sami Mujawar Sudeep Holla jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 9d669016d9..b98e2113b5 b98e2113b53fa9c7474a820bcd94fffb352acdf6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:23:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490613.759393 (Exim 4.92) (envelope-from ) id 1pP4Gm-0005zp-3m; Mon, 06 Feb 2023 16:23:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490613.759393; Mon, 06 Feb 2023 16:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Gm-0005zi-0V; Mon, 06 Feb 2023 16:23:04 +0000 Received: by outflank-mailman (input) for mailman id 490613; Mon, 06 Feb 2023 16:23:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Gl-0005zc-H6 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:23:03 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85a13fee-a63a-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 17:23:00 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso11195049wms.0 for ; Mon, 06 Feb 2023 08:23:00 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h3-20020a056000000300b002c3e5652744sm3560203wrx.46.2023.02.06.08.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 08:22:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85a13fee-a63a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8rfQVn4uRlB7fZSqyxTk1LcsrKMyU63zgYLlBESl7j8=; b=TFtAjVZqXhXpBDHQ3qO6ZM1fe/hzgZd2Z35yUJ+c4q5ac2srn/sQHy5EEUUk2l0g6y 5l16EycSUZN24AnATN4x0dHFPsZtWTbAATnjOlg4J3w4Hj1Jmu1hGBjRcmyrEQAyCSxJ xDAcMR8K0ZjuTOGxs00n7YWmGre/XvdlOgq1Sv4rqY+5sUgKsoJy+VgUyxfv/Bsvq2pS 6NRNR6sbf4e9hAy9xnvkqYU/G6Cv0u9gQ7HWmZCzfXVkch9X/iZ0c3aDKeH1rTO9VpMa lOOGaocGUdA76aSldIr8DRanyH0e8Qy7wWQ0//W8OqsAxnGjDDD/r+hfXYD3bbI2lPeg cSjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8rfQVn4uRlB7fZSqyxTk1LcsrKMyU63zgYLlBESl7j8=; b=FSYDr/FdK+8avZ6V9aUqTicBLZrhjV0mdm8awLHumDTTGe02aEl+3tu6taiHYHEar0 08vXnWrC9J/ZvclLgpl5FC+qpHbctKsU/3s+wOfaHLmJu2H6vCQveRoFZ2RbfcegIlvE bOnuYY5UHHYoQpvpwpI5nXBkcyrtZ+ye27QmpAQ0hZRBOosdoTgjYcr+MFVpUNhpuaKW bROR3anKrRFmUDz0ATnYU2vTcj0QzDGfq3ehZjy05fWyteWIRqcX0rCqIlHTXD/bzR2W 0tg9u40ZxcMJUjB1Egl+6fwcBaBaAnBCUwXF3A6Y32vz3lUKwyKSO6/NY2S2KvsaYlUG 26Zg== X-Gm-Message-State: AO0yUKWlLo6Y9CZWrI8Ma4mtHID5y3/uxU4+nPwUBFq9Q+FPgmMQqUID JsDjmIp5zeDYiTrI4k0Au0E= X-Google-Smtp-Source: AK7set+YHK++9tVXbUl/UKRKDcrko5zY/aUPDwtSR6JzkBYmFs/AKS8Jwm2vdJn5cpL26z5FBj4bOg== X-Received: by 2002:a05:600c:170a:b0:3d0:6a57:66a5 with SMTP id c10-20020a05600c170a00b003d06a5766a5mr343904wmn.0.1675700579524; Mon, 06 Feb 2023 08:22:59 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 02/14] xen/riscv: add header From: Oleksii To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 06 Feb 2023 18:22:57 +0200 In-Reply-To: <9a098db8e3fef97df987b2a7330333b51a21cb8c.1674818705.git.oleksii.kurochko@gmail.com> References: <9a098db8e3fef97df987b2a7330333b51a21cb8c.1674818705.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi Andrew, In the previous version of the patch series you mentioned that it is possible to re-use some parts from the existing code base. Could you please provide me with an example? I assume that __ASM_STR should be present somewhere but other parts of the header looks like it is arch-specific. ~ Oleksii On Fri, 2023-01-27 at 15:59 +0200, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > =C2=A0 - Nothing changed > --- > =C2=A0xen/arch/riscv/include/asm/asm.h | 54 > ++++++++++++++++++++++++++++++++ > =C2=A01 file changed, 54 insertions(+) > =C2=A0create mode 100644 xen/arch/riscv/include/asm/asm.h >=20 > diff --git a/xen/arch/riscv/include/asm/asm.h > b/xen/arch/riscv/include/asm/asm.h > new file mode 100644 > index 0000000000..6d426ecea7 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/asm.h > @@ -0,0 +1,54 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only) */ > +/* > + * Copyright (C) 2015 Regents of the University of California > + */ > + > +#ifndef _ASM_RISCV_ASM_H > +#define _ASM_RISCV_ASM_H > + > +#ifdef __ASSEMBLY__ > +#define __ASM_STR(x)=C2=A0=C2=A0=C2=A0x > +#else > +#define __ASM_STR(x)=C2=A0=C2=A0=C2=A0#x > +#endif > + > +#if __riscv_xlen =3D=3D 64 > +#define __REG_SEL(a, b)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_= _ASM_STR(a) > +#elif __riscv_xlen =3D=3D 32 > +#define __REG_SEL(a, b)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_= _ASM_STR(b) > +#else > +#error "Unexpected __riscv_xlen" > +#endif > + > +#define REG_L=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0__REG_SEL(ld, lw) > +#define REG_S=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0__REG_SEL(sd, sw) > + > +#if __SIZEOF_POINTER__ =3D=3D 8 > +#ifdef __ASSEMBLY__ > +#define RISCV_PTR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.dword > +#else > +#define RISCV_PTR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0".dword" > +#endif > +#elif __SIZEOF_POINTER__ =3D=3D 4 > +#ifdef __ASSEMBLY__ > +#define RISCV_PTR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0.word > +#else > +#define RISCV_PTR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0".word" > +#endif > +#else > +#error "Unexpected __SIZEOF_POINTER__" > +#endif > + > +#if (__SIZEOF_INT__ =3D=3D 4) > +#define RISCV_INT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0__ASM_STR(.word) > +#else > +#error "Unexpected __SIZEOF_INT__" > +#endif > + > +#if (__SIZEOF_SHORT__ =3D=3D 2) > +#define RISCV_SHORT=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0__ASM_STR(.half) > +#else > +#error "Unexpected __SIZEOF_SHORT__" > +#endif > + > +#endif /* _ASM_RISCV_ASM_H */ From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:31:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490621.759404 (Exim 4.92) (envelope-from ) id 1pP4OP-0007YA-Su; Mon, 06 Feb 2023 16:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490621.759404; Mon, 06 Feb 2023 16:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4OP-0007Y3-Pt; Mon, 06 Feb 2023 16:30:57 +0000 Received: by outflank-mailman (input) for mailman id 490621; Mon, 06 Feb 2023 16:30:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4OO-0007Xx-D0 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:30:56 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a072f243-a63b-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 17:30:54 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id az4-20020a05600c600400b003dff767a1f1so4011961wmb.2 for ; Mon, 06 Feb 2023 08:30:54 -0800 (PST) Received: from [192.168.1.93] ([188.73.236.41]) by smtp.gmail.com with ESMTPSA id l8-20020a05600c4f0800b003dec22de1b1sm12288382wmq.10.2023.02.06.08.30.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 08:30:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a072f243-a63b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uN6Yn35LFEIaC9C7Z2m6Dq4ezkXfgzSR56vHUQFmHCs=; b=lhsk4hFGRib+oyICAU3Ja8n2wYlnsI4rUfiuAAxm8dB9d4uQSLJ/ZczDj2uVV7nf7x jamNL5RsPOT1zmPMx5QOCT4SDQRbdqVAPqXGll5ulRWRa9cRYTAoNMGt5K+6FH8PN4jA TwjeSiZebfva86eK2eup6woVDwHnBPrf4q83xRK8QUhdIF8yNDTZTFczf3dilW0dA87K DHOjbMmMsWpfsTX+jWtWM5D1OSF0iqJa2QC1qvEGgTDOqsgENYW5JRFvFV/3G9dp80K7 LpleHAfJCuq30O1+B9mjX9ja4dq5Fjw4VOVj8OHNZrQUuLdTieeu7h/VD5VDlvzN708D CsSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uN6Yn35LFEIaC9C7Z2m6Dq4ezkXfgzSR56vHUQFmHCs=; b=vlvytwIYE8uaey5QbRKeR5GO/Pn2+bEf0K575HqdJZ262Jmvubx2kTKr4Isaduay2u JDptTVNSCHi3M7rI9AS0KucMam63WZDu3Kk3tPWaLMtkeeqB7Xn64qBZDQOyWIOpXwNX pNJlRXCeMu24hTCOb8cMsHH1RoCMi9EU6LuEtg47RzRgbrgWEYpDCjtrfVyhdZGtGRlJ PtsaMXn9LVT+ZYsPIVRCRI5KJ/2BfRhwAGIKKRVp6QYkwTuHXegxd/zJxqKwT+8vcvzH ngEVYZ4FV3lpxFCNojRcN95YmAt/HWeWA/4NsStn3W/8X3KjgJWMZpwyX3QeI5q304EF d/Jw== X-Gm-Message-State: AO0yUKWDmr07OvxY0VXR1Atb3SI1/9K03MDCcY4VmlJanVxOLSX37RV9 r5iPz3Zghjh3INx199Qzi5k= X-Google-Smtp-Source: AK7set8BfI+xpYgxoMkmEFNbyBqbCshOmbf4JSJ6Fih72wp9SVg1pUS0wHBcWWSj4LqX3WNgVCSZcA== X-Received: by 2002:a05:600c:30ca:b0:3df:c284:7e78 with SMTP id h10-20020a05600c30ca00b003dfc2847e78mr264803wmn.38.1675701053975; Mon, 06 Feb 2023 08:30:53 -0800 (PST) Message-ID: <8a1658e0-0778-688a-e2a3-bd8e4de0d542@gmail.com> Date: Mon, 6 Feb 2023 18:30:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used Content-Language: en-US From: Xenia Ragiadakou To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , xen-devel@lists.xenproject.org References: <20230206124251.911744-1-burzalodowa@gmail.com> <20230206124251.911744-2-burzalodowa@gmail.com> <90bef569-a49c-fd29-a855-5ef0b93b1056@suse.com> <5c112f02-37ab-8637-3e61-e5e19f42115d@gmail.com> In-Reply-To: <5c112f02-37ab-8637-3e61-e5e19f42115d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/6/23 15:11, Xenia Ragiadakou wrote: > > On 2/6/23 15:01, Jan Beulich wrote: >> On 06.02.2023 13:42, Xenia Ragiadakou wrote: >>> --- a/xen/arch/x86/emul-i8254.c >>> +++ b/xen/arch/x86/emul-i8254.c >>> @@ -34,7 +34,7 @@ >>>   #include >>>   #include >>>   #include >>> -#include >>> +#include >>>   #include >>>   #include >> >> To be honest I'd prefer if only the HVM-specific part of this file had >> this new #include (and ideally the other hvm/ ones would move there as >> well, but I can see this being beyond the scope of what you're wanting >> to do). > > Ah I see. That's ok. I ll move it in v2. After having a closer look at the code, I think it would be better to leave it as is in this patch because the struct hvm_hw_pit_channel (declared in puplic/hvm/save.h) and the function hvm_get_guest_time() (declared in asm/hvm/hvm.h) are used by the common part of this file. And I can send another patch to cleanup the headers in this file. Unless you insist. > >> >> Jan > -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:43:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:43:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490629.759414 (Exim 4.92) (envelope-from ) id 1pP4Zz-0000mS-VC; Mon, 06 Feb 2023 16:42:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490629.759414; Mon, 06 Feb 2023 16:42:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Zz-0000mL-SY; Mon, 06 Feb 2023 16:42:55 +0000 Received: by outflank-mailman (input) for mailman id 490629; Mon, 06 Feb 2023 16:42:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Zy-0000mB-Rz; Mon, 06 Feb 2023 16:42:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Zy-0005JA-Q7; Mon, 06 Feb 2023 16:42:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4Zy-0005ui-CM; Mon, 06 Feb 2023 16:42:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP4Zy-0003SY-Bt; Mon, 06 Feb 2023 16:42:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zHnSmCrUubav6FqP80zf9+38cL6P7LRsDMr/Zsj++yk=; b=xZ2fHypAaS6/I8+sO8T88sXC7o F0JYhQ0mlgicJoGXGpdi8u13cvqjmbTqY68o6TLY6z3Bx3i+q1+w0Fns5AShQFB/HA493w2QZ79ta MFi1pXbAfGBTP2khn5T0adtClN2SbDoIGcprN1IcB5dyxNIoOut+ux9F///2lJqsHeWA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176409: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e X-Osstest-Versions-That: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e From: osstest service owner Date: Mon, 06 Feb 2023 16:42:54 +0000 flight 176409 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176409/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176386 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176386 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176386 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176386 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176386 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176386 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 176386 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176386 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176386 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176386 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e baseline version: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e Last test of basis 176409 2023-02-06 01:53:25 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:53:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:53:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490641.759428 (Exim 4.92) (envelope-from ) id 1pP4kS-0002S9-3w; Mon, 06 Feb 2023 16:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490641.759428; Mon, 06 Feb 2023 16:53:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4kS-0002S2-1J; Mon, 06 Feb 2023 16:53:44 +0000 Received: by outflank-mailman (input) for mailman id 490641; Mon, 06 Feb 2023 16:53:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4kQ-0002Rw-9g for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:53:42 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20618.outbound.protection.outlook.com [2a01:111:f400:7eaf::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cec2b8bf-a63e-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 17:53:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7410.eurprd04.prod.outlook.com (2603:10a6:20b:1d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29; Mon, 6 Feb 2023 16:53:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 16:53:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cec2b8bf-a63e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+8xERCtl8nVH50N8rKZRFdyeJDfXgSQ6s1MNwqMKBGzefZFSShiRsJM8CXeR53sfC//JO5+4Ns0nv46xccQUjj2GNyTT2eIp8OcQUFbTUc5UIXMfNwsehEA7supdcMgNfqlDl4N8x+vRuPdJKcNywQiajoQF50OKnMTKrzUy+SD5IR5HuJjw53iA+CoYq/YYRnCJ8dkiTpAvff8pmWY1QppI82qphbhwg5BeFm4bPqOUyNEgyJagVSV58TG/1gIS7SiqZ4G2I5FSvyOHVLgetqa6qa4EKlntQqy+SxejQlH/vfeUSPsm+Qf2Ax9C2GbzboMpn4nMzZhHIQNtFCZSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BA3hVnymw75XyzT28ezWDicOIUf4EVaML1zrA+X2Bsw=; b=bSjsUcFw3dQRJH/AGnG5wkvdLjwnLN6tIYtyTCAarw1Lj7ElCaX+tq3BhDGhCJO9Uzwr8I/XlLbT3Qr/9WeFtwE/gkwjePYbP0xe0OvQiB3zsn+kj45z38KGAxONgG5oM4slQDm18u1HZQpS7H3bU23W5NW9s/qxVK/miwM8KK055ZeED2YI//x/8B21yM3ZLYQQ5HYrIptRoRto+mDENAXt84NCZK+LXHXN0iLSEj+pVuk3YlOzJZkpJcnf9Kojh4GvlaPMuJRO8U5JgtPKJ4GzOQCkVOzS1dffTbeRIbnVH0+/TR0T0NfU/zCR6xRs1Wj2P81/Q1trM28/SXFjpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BA3hVnymw75XyzT28ezWDicOIUf4EVaML1zrA+X2Bsw=; b=qLt4ljyOLlq/u/9ijV4XrAWAZwbw/FS8WndKJDBbFgcAq+yMlDj8Pm6gUgjD2MHRPUDK+meg6rb2LeWK3ix+PhDb62RiRtNmyittQ6NuWvqzIsv+BhBs0fOspbpU5+JJgl4Z1KrEnQNFwMkCKAFtRW9DsNWTBzzyByQNp/EPhOxolTJvAZgKxXejWszglvbxC+bqBct0jN6zWDjvFCrksx9eUET0zzgIqYMO/9OFcNa93s92EUlox/VGuaJyqCITkofN5Jfhpz+aGui8n3XzaO2PyCmiyqfIK1Lo0ZBnaZ/QihaOJYpOJbDqB7VUlaO3x2bs8ssT8W50CUgLaKrQMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Feb 2023 17:53:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , xen-devel@lists.xenproject.org References: <20230206124251.911744-1-burzalodowa@gmail.com> <20230206124251.911744-2-burzalodowa@gmail.com> <90bef569-a49c-fd29-a855-5ef0b93b1056@suse.com> <5c112f02-37ab-8637-3e61-e5e19f42115d@gmail.com> <8a1658e0-0778-688a-e2a3-bd8e4de0d542@gmail.com> From: Jan Beulich In-Reply-To: <8a1658e0-0778-688a-e2a3-bd8e4de0d542@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7410:EE_ X-MS-Office365-Filtering-Correlation-Id: 33dd2149-e5e6-4a51-09ad-08db0862b209 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zq9zaq574UCBMonQJBkMzLcRHKTIWV4RBoRrsXC09gA/tZexds+dhYJ4+ZMRZ2PH/5sGypkNSSn8BjYjc6coVQkvRbXCWWhOb9rTypqrAPReerpGdSJyfsph6O4qMcBUWRcJAMvp1/X7AE6YmKgYZwu4VY7VJonMpnxFEVlOWhJ+qfsOyjsDW8xn/zCbGWkEBbXofS8XaYpySykP4/hoXc1lmVRDtuo7K7fTrXEbJHPDA8PRpytdg8orR9O/go0Je87dqj4TxQgbgw+AVuzqBWVdBc8Xg+bAADfSRiGUHyFqFwaj6ffdrQlMNPb/QiBEWA73E7sS2HQ56P6DeIU4D//ha41mGSQ4FDA0jbihEkGOvtY2JUZ2JcopNnjkuqW0mYfP92UDjdkW/rJFupwEQrUv42UwmBQhxiM/Fuf2/1Hdrkhr4MeOTfVnkK2LEGit2lUslGp3c/cQNFXf/kJc3enyI2OUDbgaM+9CXMf7b+o1XOh7VJKpaHixtuXMAuWG1l983Y0H1Tmh4V9BgTHS12EOTN9X7/ZapNeFxOfvtI7HKFi3KFCjz8hWaczxcjBG6GlusYhLXjniksrsPZq5j7QFvX80NX3cvStOmkD3k7kN7p13yA7kYAWg0BNVBVFdtthY+VctxtM8ljkju78yNDS/4QgZrXNdy95ss2cu8oAfEqjx72Oyrp9cEGfXTbMJ4CX8sNHbjZSStuDCsG5UB0hAHN/vIBAzJFdTyu9fRG4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199018)(31686004)(66899018)(186003)(316002)(54906003)(83380400001)(31696002)(2616005)(86362001)(36756003)(5660300002)(26005)(6512007)(478600001)(2906002)(38100700002)(6486002)(66946007)(66556008)(6506007)(8936002)(6666004)(41300700001)(6916009)(53546011)(66476007)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnFUT2lQUTY2bXFaejVvcW90NzYrM1p4MS9hWlpnSjd6dHR4cDJRSHdheldh?= =?utf-8?B?czFVRXpQTXVDQmgrS0ZRc2FlcnV6WUgxejM2NnFESmN4Snp1UmVJYmRCMCtN?= =?utf-8?B?WkVxejlNMUc4VXd3dFArU3c3RWVUODFjWGl3VkhXbktrQng1YjJRbTJtU3lP?= =?utf-8?B?dVBVZnhEM0xyUjdvZlhQWUcrbEZhd0N2RlJGQ2NZVU9KSFh4dHlJRkFzN0tH?= =?utf-8?B?NEFsbmwwcWlkSWFWMEtGZUVsMk92aTR1VXlKYlRtbFl3M3RuZlJXL25NeHNT?= =?utf-8?B?TzVtdjBpbEVaY0dhTC80a0xQZnZkNU5TQUZkZ0RON3RpRlRRdjVIL3l4QU5D?= =?utf-8?B?Sy9uQ3dzdms5S2pEbCtZSXJKd05Eckc4bkRVN25md2dmeW9lYk9iUVBwNjJB?= =?utf-8?B?YVRQQ1JFKy80bGxzQkNCQjM2eTc1dWFzWUhiM2NSOGV3VUQzeDNuYnBBZGZJ?= =?utf-8?B?Y1JzZU1KaExFVndYb1drUHpKMGtiVXRXb2xxZWp2LzIrRmtMR1FrQlBycDZ6?= =?utf-8?B?NTVsUUp4WlNhMGhJbytqT093bVFPeHBtNWZiVk1WdlAvdnQ1QXJES0w0YnpW?= =?utf-8?B?Wm5iNFM5Wjd6aUpzS3ZFODAyL1FBVEQxUkFobEtsY3dIdkMwMExXbjV5QkF2?= =?utf-8?B?Ym9uSGQ5K2xtYllIZG9lTGZBdFdlWGc0d0tZeFBabXRIdzZEb2VBWE95NnE0?= =?utf-8?B?S3JQajNTci9pRTVOVHZHZDVJRmNVT1NIL0U1eXJwRUlPU3VTMHp2M2dnMGE5?= =?utf-8?B?Z3hsYTBDRkJPSDhyLytzSzlYNjlQZkViNVVKLzNLQnpTaVlsUFZuWmFVMity?= =?utf-8?B?K2FWSnp6TzZKcytuTXdPYjJqNTJ3TVRlU1BlRi9mcEdKaVgzaUVCN2RWYU1q?= =?utf-8?B?aXdWMzBOdXBIbDcwZmt6eFpLS1VyQ2lMZVBvN0NQTStXMkJoNmVESTgvT3pl?= =?utf-8?B?UXZ2UCtpRTdxZi9KQkxqYm9LdXRQZ3FaTE9kM3lKTjVMSVpxUFg4VVNHQXh2?= =?utf-8?B?V1VXUFVtbkc5QmhDaG9GRmUxSkRucHFVSC96YThNRGY2M2Vwa2dtQ2hNMU1R?= =?utf-8?B?eEhvbEVZS1BUZTkwbUlEYlozQjFDcjB3aVpWVWhPTTdiaHRaMkl5bkRaN01J?= =?utf-8?B?Q2RzN09aQ3ZKcUo3Rk1zbHRrUE1pWjlIUzJKcGlwc0JUM04rb1d0S1RyZk1n?= =?utf-8?B?cHEvaUFzL011RnBPQ3dKU3pQQVBqS1ZJcE0yaTQxN21pdmE0eUNtd3lxTDhl?= =?utf-8?B?UkRiaWRLdENjbDcxbGR1MWRVS3NSNG8vZTNyZlRkdWo5QjJVeWYvdlR4a2RF?= =?utf-8?B?M2lLRmowU3JtY1J6VG1rVUJoWkd0QmlRb2ZlemVod1FxbXFMTHQrbHNWR0JK?= =?utf-8?B?RlZ0MHZ2SERzNDRIa0wwMDFOQklmcS9aVFlpeEZzbHF4TnEvdmhQY2hsa0NF?= =?utf-8?B?NGc5LzFoR1FTRlpVbENXS1ZtNlNnYmJpL1Q4TFZZZXhucjJyelprNkczdWlk?= =?utf-8?B?RzlXalZSektBVGt6dzJwdUt3cTJTanY3aHFxWUEzcDJFSWE0UXRuSEpXVmk5?= =?utf-8?B?cEJSaXI5UmdRNFQ0cHFwOHpqNDg4eHgxWVpmNytZUUdGS2x1emlQQmFIUnZT?= =?utf-8?B?ZVd1YWhYcXVXblEvY2hWeXFma2JiY3IzMXJzZ1VTczJ1eEwrWnVWVWtndVJv?= =?utf-8?B?VS9mTExycUVEYXJ2b2NNczV2Q2drb3ZhV0lGTzZlc1QxeXpSQ1liWWY0Y3RS?= =?utf-8?B?MEhibXk3RGtKdzIrNktsQnhQN1ZDTDRCV0JtL2NYTHpBajBtUVE5bGNObHhW?= =?utf-8?B?SjFlMFRXVGc3eUdnWHpHV3l0YmMwV2tWdHQydWZMdm53aTJrck80NU56Qy8z?= =?utf-8?B?bWswbTQzZTRJeFRFWExiRnpIaGh6TTg4eHlVUkl6b1QvLzBHTFBlRVFBRE9J?= =?utf-8?B?ZW04ZVZCVm1BaHVQUFVxcTVVZmg0Zi9YMjFqRlVkRXplc25pclhqUnZ4V0Y2?= =?utf-8?B?L0x3RGZoUTY2U01zUGZ5dnZYMm56NmcrdURGVEowNHN0dHRGS1ZrS3VFQXFU?= =?utf-8?B?a0daNW9NTkFBRzZyZ2xKSC9TMnEwMzNEaGVoUnk2OEN4TVR5enFJbGV2aytt?= =?utf-8?Q?1dcLMQWZt+wncgQDw5y/ysTBA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33dd2149-e5e6-4a51-09ad-08db0862b209 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 16:53:39.2935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HcprZlrkUIGhw2fG6aAWJmTbrUp0rILLEFlfDfX2fVlUIxGYpZDjDFEKXoUzVsQbykeQSCRyxFUVrgvRWXh9uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7410 On 06.02.2023 17:30, Xenia Ragiadakou wrote: > On 2/6/23 15:11, Xenia Ragiadakou wrote: >> On 2/6/23 15:01, Jan Beulich wrote: >>> On 06.02.2023 13:42, Xenia Ragiadakou wrote: >>>> --- a/xen/arch/x86/emul-i8254.c >>>> +++ b/xen/arch/x86/emul-i8254.c >>>> @@ -34,7 +34,7 @@ >>>>   #include >>>>   #include >>>>   #include >>>> -#include >>>> +#include >>>>   #include >>>>   #include >>> >>> To be honest I'd prefer if only the HVM-specific part of this file had >>> this new #include (and ideally the other hvm/ ones would move there as >>> well, but I can see this being beyond the scope of what you're wanting >>> to do). >> >> Ah I see. That's ok. I ll move it in v2. > > After having a closer look at the code, I think it would be better to > leave it as is in this patch because the struct hvm_hw_pit_channel > (declared in puplic/hvm/save.h) and the function hvm_get_guest_time() > (declared in asm/hvm/hvm.h) are used by the common part of this file. > And I can send another patch to cleanup the headers in this file. > Unless you insist. Oh, I didn't recall it's this ugly. We're indeed using a HVM-only struct for PV here as well. Your change is okay then as is: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 16:59:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 16:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490648.759440 (Exim 4.92) (envelope-from ) id 1pP4qJ-0003AL-Oq; Mon, 06 Feb 2023 16:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490648.759440; Mon, 06 Feb 2023 16:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4qJ-0003AE-Lt; Mon, 06 Feb 2023 16:59:47 +0000 Received: by outflank-mailman (input) for mailman id 490648; Mon, 06 Feb 2023 16:59:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4qH-0003A8-SI for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 16:59:45 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061e.outbound.protection.outlook.com [2a01:111:f400:fe02::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6c323ea-a63f-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 17:59:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7931.eurprd04.prod.outlook.com (2603:10a6:10:1eb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 16:59:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%6]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 16:59:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6c323ea-a63f-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PhNBzs+DKNIxHmgvPwYrT4EbXLU9Agno1nMTqWzBB+HOEOUtPYXY5Mq14E4PPLKp3NKIpTsTLfCPq/4/0ynEct27dAMbEvkObwYAVGWbn/E0WF92G9T+km8TxyJOeAFG/CHQbAtEG3/h5IpNyxlsqIL7V7fhWK+HDXJX/6y2HcB3aM+ZzoOfus2ix1uiwGoQ6npIrObuH9tIg9fZPMdToM18dS7pdTQufS6YLYgmpzbUFkrJUy0iBicem7DM9gFHneaOvoXBbIf33NAvCmYXCRAHK3z3Mj3Hm6qDI+S8EtqsmiOQvl8ttQHs9fTUXBaWOcwd7cKn69rX79cMrKEPww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WDrFca8dvmtdJGbiU1pfFdCev8B0O2YOfnJyhi4Mq3s=; b=ern0zW2Epzpa2MjnJEKk7mTdOeJqFQ6e04mz6mxhH1wystwnzGNe2IEV14ahwSXw4LuqamSq0d8Q5UpeFJi9Quz78WANJIx4VPcJQwP7WEylReX8c0TLI+7qg8nHy4tgOfbvACrWnBHoJ/+2fZ2+gu7J6GPJehQU36ZI4WuohVXCPHQJtXS0nwGQUO7lErBcaQhWxGdhr4BCFnEXYY5XIzYeQqne7xyTgUcs9ZfZkn+zy+AthYH4IUl07QaGPTGrinThvq6DqiTSyg3GkCN7oFRP8UQcPv2tikKJhqEDz4B2esLMXSAogwkLRyh/6qKToXkhfQIdWdtZdqsOPrQj8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WDrFca8dvmtdJGbiU1pfFdCev8B0O2YOfnJyhi4Mq3s=; b=OoiEuSkjPrn5UflEqq8/OBxfNraDj2PewNGuB1J1AZq2HVSqL+qYEnv4jrAj40ChfE3qt2rMEdJUVZSHFTmUU7qviGgpOsRjOLuShwVLQtZZuMJOCvFuaC8m+don848iUZLug6NmwZPZAz1BRsVTmpsgCOHGuPhEywMF2Kch1OvevJVvvzK8Du00tp5rw5lVCSdVBv3ziAf20RVP/ObIi5We3V48uj9o5zE4POwAR8KByuMXsHN4CL72HL8D0aufQe8YIef322MVhnathpVwOd4Id9WixCz9KpLbSc0/Yevt3eQ6VtjeRSitdqkma/wTj7ZyKbGFFB4f08EraTSE8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <00c311d9-cdcd-45a4-7ae6-5a5fd5450ba2@suse.com> Date: Mon, 6 Feb 2023 17:59:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Content-Language: en-US To: Elliott Mitchell Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Julien Grall References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0210.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7931:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f166506-ba23-4445-39d3-08db08638a19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xCgfk8jegvFKM70/zRbH3INlHoKfvLJBgU/VGbGM8fv16djlpbsW2CMePFjlejrBLg2P6wjsFyZ4I4RsQmME9/ccq4OuLAxLWWHted5SypMyo5dIi5layZcpwe2T8ppHU2w/icx1itKO6e01dhpuVefc1TyIPF4mAvsAqeO5fQBJg94/7yj6EAdpyTH5HH3m5DY8vt8zRXvH/6/eZqva0h1pRXxPkLiGFrdGe6YR16gtvDXWFCt8jpZmjV5OAdg+sxMddtUvI2wUnG2mThd0xGb4xvE62kHaRJzyA61G3q1iAp2cesGumf6lSNpN23csXbUPofpY4ZTvtaPv0lAq9dtCUETdQsoCzI1hoqD1jXvqDrXv+TY/Caj/hxW26BNadNycCtn6dU84xNyOcq502zduHKda81lXqQw2XegfxVGuAnrktAd2TPK1N/pLcobkpr/ZvJI7OtJofHiaENESoDuQoeBDb/JX/lE3swddRUeIS5UwuR9sQmkZRm+roA8PtTJY/Fx5AthkVBb8iiWpzK5KN0J2Q2hDLkGsUo6VE0mYch6LKiHpt4OrmnM+GjI39sxVAal3ry/kqKarnUbrsXzx+GdJwmNilOy5opXSNHt+bMBDpfGK+MZGzAMV8aXthcjv1Aoba6ACtkvTdhtpgTnDvGFGjJN/yhSRewl0DZofJlUew+e8+vHKeF91i8Rtjvt5GAULzL+7Bu7d1vPTp5kzWZuPxmU0NOkMdZPss+g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199018)(36756003)(316002)(54906003)(6512007)(31696002)(86362001)(26005)(31686004)(186003)(6506007)(2906002)(66476007)(4326008)(8936002)(8676002)(66556008)(5660300002)(41300700001)(2616005)(6486002)(53546011)(478600001)(66946007)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGpVVjI0eitZZGEzUFN5eU9CanFlMkJrYlhPNzFjaTNlTlBHa0IwdVdHR2Qv?= =?utf-8?B?clpSNmVCc1I3RlhRT1VsMmdxNnl5TmUxUTB0SUExS1lLdmlvQXc5Z21YQUtC?= =?utf-8?B?S1VuUkVNbmlwNFlnRWNBVk00UlZiaGRQem1qN05NazcrVTYrWTVOb1JIVEF5?= =?utf-8?B?VUpzWVFUdndmZzJkWitVYyttUmQ4NHdtdDZJb3pUdFZlL2VuT21mTTZLZkEv?= =?utf-8?B?bjZybGVyVk5wTDRRR1lQUCtlcUkxSWhQTFZXU2l2N0dpZVZaUUNkY1ljWU5l?= =?utf-8?B?T0ZseWtCU3E4WHB2bGFzaENVZGFjQjNnMjUwM0VMMzlGb21Ra3duS0lVNzRi?= =?utf-8?B?UFVyNEE4MUozUXp3V2hwNUlMTk04VWYwT0UwYzEzSHlKT1RSUkhQRmlzMVdi?= =?utf-8?B?bWJwMWhRYk9BMDZ1TG1mVFhQRmlqTXQyZUpaTjZwQzh0Wm0xTGhRNEEwOFRW?= =?utf-8?B?SENPRkd4MmQzb0h6VWoxVXV4b25IbGJXRG9jUzQyZStBU0hmVy9rTXU3ZUJ0?= =?utf-8?B?SnF2T2ZsVnljWHc1dlZ4YnRYd3lFMStuWk1pVTBPZG1sbFpid2lqd0Zndnp0?= =?utf-8?B?T01UTDRyeU84Um4wWWdzOWxRd1hXNFNhSWN1aDMzaTZIL0orYU56YzRjbHlM?= =?utf-8?B?VmtsdTJGYUlwQVJ6ejAzVmVSYm82UkM1QnE0bDJJdmRLVDgrY0FTVkEwWHpv?= =?utf-8?B?YUNxalpnOEwxbVBYekcyb2NjL3FwNFBOT3E3SUpSTUY2ZEN5emJHazRHVFhs?= =?utf-8?B?YkEySTI3bWdWbFZRNW82b04xMzFEakhrYk5Wa3Q0TnRCSW5FU0dLSE0rMmNQ?= =?utf-8?B?Mjl5UDM4a1N3WG1makVZNnJvWG5MaHl5T05IVXBDZXdLblBCU0RPdmpPUStC?= =?utf-8?B?dzBrQWlibzlpWlNwcjVOWVlUczFMa1NYWUhPcFdzSkRYSXplNnBwUVhRcDJL?= =?utf-8?B?eEM3RGV2ZmhvbWVTdmRwcWtaaUhKeGtXY3hsUEZVU21sMXU5WjJYa3dWV0tX?= =?utf-8?B?UVJJUnd5NW41WXEzd3R4ZjNkTVhVdFhRcXlDVG9VRGYxRWdyWTBvTFA4QjhO?= =?utf-8?B?NGFWQ2lzbStFSEw2aHZSaWI4Z1JNVURhbyttbkpZRGdCbFZLQUZMUlk4SWRz?= =?utf-8?B?amdWWm9rR0QyZVVDa3pvVmN1a01CN1FaWUZ5K240MjMvdnRkY3lCUkpYblps?= =?utf-8?B?YzAwZnVNK01VcWNwbnI0S0FpM3lOT0RTQXFKVlR2RlpXS2E2TXQ0R2Y3b3Yy?= =?utf-8?B?ZGlTZitpQ3BWVEwvVEh6dmN4NXRkVXlWTGxPcU8wWE1ycHQyRFZDMkxRUWp2?= =?utf-8?B?c0tOY1B4Ti9XdWptWXUwMUtmYXA1NmQyQlAxblhHc0tuUlJoTk9kRVJlZGtB?= =?utf-8?B?U3E3L0hscDhiUHBJYXNuTk5IeGN3M2Zscyt4Qy95TW13eTBickVJanhma1VT?= =?utf-8?B?U2NCak9vYlk4c1NnVEl5eXpWc2l0OVhHNUdDcHF3LzEyQ3I4ei81RDRzMVZP?= =?utf-8?B?UlBsK1psaEZ0aktuODh4MGpQeFhXZkhyVTRrbGF5UHcwR2FRV1pmOGlUeVlx?= =?utf-8?B?aURScW56SnJqcFgvUkZ5SmdKRWNJRDFBUDhrZjFHOXFSbHVEU1ZXaVNUTGtU?= =?utf-8?B?TXRySG9BRzd0TG02MVdYS2JjdWg0N2FubUJzQVhSN00wVGRjcjBPZDZ4czBP?= =?utf-8?B?YU42aFRnZzg2OVFZMVlNVVlFcVdTejJyandDUXFvVE8zMVFtQmcybmtZNS9t?= =?utf-8?B?S202ZVNJZ01vTzF1ZDFUM0Y4TWtzbVNaR2IreHNkcXNvaU8zVlNMQTVyYlhP?= =?utf-8?B?YUJkMnRPOVYxT1lsWE5rclIzeGpMWEEzMFpJZlIydzZCY0FXWVhQbHUyS1oz?= =?utf-8?B?VU9KTnpkM0JvVUZrd1RTcWdVcFpxU0FoQTlYSW03bk5LUFFYYjhodk1iMFZh?= =?utf-8?B?WlhWaUdBT20vT2pkK2N6aXhreGFpNHpyZWVJWjBwaXlsV1RlWG1SaGh6MzZ3?= =?utf-8?B?UG50RzNVVG4zTEhvUDBNNy9ZUmM2d21GdjZJbWMvZWluR3AzZVFRQWtRN0pu?= =?utf-8?B?WmtZODRsOHViY21EcmRza0Q3eVJ2UHJ2MWVXeFk1dTJQU3lVY2FxT2l2RCti?= =?utf-8?Q?XDaIHOUdHnPF+2wZpZY5ZeHsu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f166506-ba23-4445-39d3-08db08638a19 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 16:59:41.6469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N6zc+eFbwGAfg8qmcAFibnhR1ZBKmju55uhpUP/2qZ6JftsM41e3BShSzGjd/VHk8EbjIVCexe2aEKzytg+fkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7931 On 06.02.2023 17:09, Elliott Mitchell wrote: > On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: >> >> On 06/02/2023 07:29, Jan Beulich wrote: >>> On 22.07.2020 19:43, Elliott Mitchell wrote: >>>> Unlike other unsupportted options, ACPI support is required to *boot* >>>> for a number of platforms. Users on these platforms are unable to use >>>> distribution builds and must rebuild from source to use Xen. >>>> >>>> Signed-off-by: Elliott Mitchell >>> >>> A general question first: How come this mail dates back to July 2020? I >>> had almost missed it as "new". >> >> I can't even find the Elliott's email in my inbox so reply here. But >> this sounds like a rehash of [1]. > > The date on Git patches is meant as an indicator for author date. Since > this is a cherry-pick of a patch which was written >2 years ago > `git format-patch` indicates when it was written. This IS how these > systems work. Yet I don't think I've seen anyone else send such apparently out-of-date patches. And I don't think they all go and massage the author date prior to sending stuff out ... Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 06 17:08:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 17:08:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490655.759453 (Exim 4.92) (envelope-from ) id 1pP4yH-0004ij-Hx; Mon, 06 Feb 2023 17:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490655.759453; Mon, 06 Feb 2023 17:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4yH-0004ic-FF; Mon, 06 Feb 2023 17:08:01 +0000 Received: by outflank-mailman (input) for mailman id 490655; Mon, 06 Feb 2023 17:07:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4yF-0004iW-B9 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 17:07:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP4y8-000620-UD; Mon, 06 Feb 2023 17:07:52 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.13.231]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pP4y8-0000sV-N8; Mon, 06 Feb 2023 17:07:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=O+IH0CODgK6C59yuZASs+SvNoF6Rdvd/FoLJo7Wq58I=; b=1Vi4O/0dH8sYfZfhiJC6hACKov 2qC4YbC+SmI1Csh5tGGh/4d7OQ/5JWTge3TVPbOpBatbb3iGp08+t804TLw8Fbv70NQSvyBXysZ2m Cnip6SHaOEzI51b4GB23gGozhP89yxIAP1hmh/3sCpofrUOfjv1FhZ17M/Byu77YWtYw=; Message-ID: <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> Date: Mon, 6 Feb 2023 17:07:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Content-Language: en-US To: Elliott Mitchell Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Elliott, On 06/02/2023 16:09, Elliott Mitchell wrote: > On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: >> >> On 06/02/2023 07:29, Jan Beulich wrote: >>> On 22.07.2020 19:43, Elliott Mitchell wrote: >>>> Unlike other unsupportted options, ACPI support is required to *boot* >>>> for a number of platforms. Users on these platforms are unable to use >>>> distribution builds and must rebuild from source to use Xen. >>>> >>>> Signed-off-by: Elliott Mitchell >>> >>> A general question first: How come this mail dates back to July 2020? I >>> had almost missed it as "new". >> >> I can't even find the Elliott's email in my inbox so reply here. But >> this sounds like a rehash of [1]. > > The date on Git patches is meant as an indicator for author date. Since > this is a cherry-pick of a patch which was written >2 years ago > `git format-patch` indicates when it was written. This IS how these > systems work. Hmmm... I am a bit surprised to what you say. I have sent several patches in the past with an old author date and they always showed as the date sent in my inbox. > >> >> Unlike other unsupportted options, ACPI support is required to *boot* >> >> for a number of platforms. Users on these platforms are unable to use >> >> distribution builds and must rebuild from source to use Xen. >> >> What platforms are you testing on? I know that this is working-ish on >> RPI4 and QEMU. But this will likely blow up on one of the server we >> support in OSSTest because we don't have proper support to hide SMMUs in >> dom0. > > I've been doing RPI4 w/EDK2. Which works for my purpose, the remaining > trouble spot for my purpose is needing a final resolution of the EFIFB > situation. I have had no feedback from the relevant person on EFIFB patch and I am not planning to purse the work in the near future. > >>>> --- a/xen/arch/arm/Kconfig >>>> +++ b/xen/arch/arm/Kconfig >>>> @@ -29,13 +29,18 @@ menu "Architecture Features" >>>> source "arch/Kconfig" >>>> >>>> config ACPI >>>> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED >>>> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" >> >> The concerns I raised in [1] still stand. Most of the ACPI platform will >> also have support for IOMMUs. If we have support for IORT in Xen, then I >> would be a lot more amenable to remove the "UNSUPPORTED". And without >> that support we are going to do more harm and than good. > > Okay, this has been a known issue for *years* and yet remains unresolved > despite being a major issue. Right, the situation hasn't changed much since you last sent your patch to drop EXPERT/UNSUPPORTED. Unless you fancy working on ACPI, I don't really see the situation changing soon. > Might be an abomination, but would it work > to find the string "IORT" and change it to "iort", "RTIO" or "IOXN" to > prevent Dom0 from finding it? Unfortunately no because there IORT is used to describing mapping for the GICv3 ITS which is currently working when ACPI is enabled in Xen. > > This ends up turning into a question of what are the cases and which are > more common? > > Case1: DT-only: Unchanged > > Case2: Switchable between DT and ACPI, w/o SMMU: Starts working with ACPI > > Case3: Switchable between DT and ACPI, w/SMMU: Unchanged, ACPI mode still > doesn't work, but the failure is different. > > Case4: Concurrent DT and ACPI support, w/o SMMU: Unchanged So Xen would start using ACPI rather than DT.I think we should default DT it until we have the ACPI support completed. > > Case5: Concurrent DT and ACPI support, w/SMMU: Breaks if Dom0 tries to > use ACPI > > Case6: ACPI-only, w/o SMMU: Starts working out-of-box > > Case7: ACPI-only, w/SMMU: Unchanged (still broken) To clarify, this will boot but then start to break in very subtle way. > > Any other distinct cases of note? Nothing AFAICT. > So case 5 is a problem, but cases 2 and 6 are positive. Does the classic > workaround of "acpi=off" work for Linux as Dom0? If that is "yes", then > publicizing that workaround (should be detectable by Xen) seems a likely > short-term solution. > > My impression is ACPI is getting increasing support in on ARM. The > number of mentions suggests if they keep going it looks likely to win. > The EDK2 project has been providing an image for RPI4 and the > functionality is impressive. AFAIK, the push is drove by Arm Server and Windows on Arm. Does EDK2 on RPI4 still provide both DT and ACPI? > > Ultimately this is more a decision for Xen Project management, than the > technical side. Are things in shape where they can be rolled out? No. But as I wrote before, I don't believe the gap is very big. > Is > ACPI support important enough to need rolling out now? > > I'm unsure about the former, but the latter seems a distinct "yes" since > ACPI appears to be the future. ACPI is indeed picking up the pace on Arm Server and platform where Windows on Arm is supported. But that should not only be the reason to remove UNSUPPORTED. You are right that enabling ACPI by default will draw more users. But I also expect those users to be less familiar with Xen and therefore not very interested to fix bugs. So removing EXPERT/UNSUPPORTED is probably going to still make them unhappy as I don't think the help (including writing patch) for ACPI on Arm will change very much in the near future (from the community call I was under the impression you could not commit time for it). So I am not convinced this is really making Xen in a better position right now. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 06 17:13:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 17:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490663.759464 (Exim 4.92) (envelope-from ) id 1pP53P-0006Ch-At; Mon, 06 Feb 2023 17:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490663.759464; Mon, 06 Feb 2023 17:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP53P-0006Ca-7q; Mon, 06 Feb 2023 17:13:19 +0000 Received: by outflank-mailman (input) for mailman id 490663; Mon, 06 Feb 2023 17:13:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP53O-0006CU-EA for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 17:13:18 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b88d504-a641-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 18:13:17 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id l37-20020a05600c1d2500b003dfe46a9801so7905785wms.0 for ; Mon, 06 Feb 2023 09:13:16 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p9-20020a05600c468900b003dc53217e07sm12482471wmo.16.2023.02.06.09.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 09:13:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b88d504-a641-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8kJeWBeBEEkZinRTqUdpXBM4KBY2GKR9YUxlAybjLNA=; b=DCKQXUbgOF0XysgbQpYCGzMDUy3A9NCJzbo2yGZ5p83xhpEK/p78lWjgnmsFjTLebi XOXaE8wgntZca8pasdB/5tQe7EsSNo6kGNbNfmqQeHppwrTwuyqG6ZA0Hk+knIT0bTgw 357/3JnzjHbvs4ChnV9wUPr3p6mfRXEOu0x1dHhivW774oEWp/aT3CcGQjK2Mldo/WNx Tkf2xFYN9w4IwsEZCb5sV/vnedHvQ3qXQZu1s7kG3VkGp5kAeR+2Bc78786hpDKUVIth bmgC8HhOe2yJzGL5gASruhOkizSud+uo/t2A+xgxSFwMbRwJKa4t60IsTxRNvC+DUy0u eRNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8kJeWBeBEEkZinRTqUdpXBM4KBY2GKR9YUxlAybjLNA=; b=ArZozIa5bhHkxXmee0XHVmmGL9vFVPeTDf/1ClOLiioTYXctZazjFirqJs4AZoCYJQ JfXq3DueCqUEYsq30R1dbmnulOI76z6Ly3Gn357Fk2ryZeypm22+eOQNvPQLMY3EoMel 9DAqzIW5TeVgnjBWje3VRzj/T9Glu61fk7lrM8VJ1jdg42s+LhMrZgoUAnwtYm49fzeh vw8MxtSoq492CWD9jTK10dDVwZc2XOZDddWJY6vRbK48gHkWkv9LVRzIs43oxbOBzlsh EH92p61Y+3ZTl+g5Ubqp/QndN+bK6es56baetra2znGK/kfllQAVGC4Zo53icc9IH1fS DmIQ== X-Gm-Message-State: AO0yUKUC1/sxxoP0WrSUV5gfoEHipdKFsW/I6DnK+HCXbm0AkEO0FboI YMjgAF3fu9/bYuM/K1PlCPCJQ9Hy2TU= X-Google-Smtp-Source: AK7set+OrE4llkvGByt9rua/P84tDUWUxYHxTfZJepBHfWufbFF/B/A9giEHcpoirsR4Ay1/CtRuaQ== X-Received: by 2002:a05:600c:704:b0:3df:d8c5:ec18 with SMTP id i4-20020a05600c070400b003dfd8c5ec18mr437977wmn.13.1675703595862; Mon, 06 Feb 2023 09:13:15 -0800 (PST) Message-ID: <21617e45dd4efea7b1779650cd063d054ed0e309.camel@gmail.com> Subject: Re: [PATCH v2 07/14] xen/riscv: introduce exception context From: Oleksii To: Stefano Stabellini , Jan Beulich Cc: Julien Grall , Andrew Cooper , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman , xen-devel@lists.xenproject.org Date: Mon, 06 Feb 2023 19:13:13 +0200 In-Reply-To: References: <652289358975cf869e4bc0a6a70e3aba7bd2fbf6.1674818705.git.oleksii.kurochko@gmail.com> <75328420-0fbd-92ae-40c7-9fee1c31c907@suse.com> <792bc4533d3604acd4321b4b15965adec22431a4.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-01-31 at 17:30 -0800, Stefano Stabellini wrote: > On Mon, 30 Jan 2023, Jan Beulich wrote: > > On 30.01.2023 12:54, Oleksii wrote: > > > Hi Jan, > > >=20 > > > On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: > > > > On 27.01.2023 14:59, Oleksii Kurochko wrote: > > > > > --- /dev/null > > > > > +++ b/xen/arch/riscv/include/asm/processor.h > > > > > @@ -0,0 +1,82 @@ > > > > > +/* SPDX-License-Identifier: MIT */ > > > > > +/*********************************************************** > > > > > ****** > > > > > ************* > > > > > + * > > > > > + * Copyright 2019 (C) Alistair Francis > > > > > > > > > > + * Copyright 2021 (C) Bobby Eshleman > > > > > > > > > > + * Copyright 2023 (C) Vates > > > > > + * > > > > > + */ > > > > > + > > > > > +#ifndef _ASM_RISCV_PROCESSOR_H > > > > > +#define _ASM_RISCV_PROCESSOR_H > > > > > + > > > > > +#ifndef __ASSEMBLY__ > > > > > + > > > > > +/* On stack VCPU state */ > > > > > +struct cpu_user_regs > > > > > +{ > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long zero; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long ra; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long sp; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long gp; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long tp; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t0; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t1; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t2; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s0; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s1; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a0; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a1; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a2; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a3; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a4; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a5; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a6; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long a7; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s2; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s3; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s4; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s5; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s6; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s7; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s8; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s9; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s10; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long s11; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t3; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t4; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t5; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long t6; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long sepc; > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long sstatus; > > > > > +=C2=A0=C2=A0=C2=A0 /* pointer to previous stack_cpu_regs */ > > > > > +=C2=A0=C2=A0=C2=A0 unsigned long pregs; > > > > > +}; > > > >=20 > > > > Just to restate what I said on the earlier version: We have a > > > > struct > > > > of > > > > this name in the public interface for x86. Besides to confusion > > > > about > > > > re-using the name for something private, I'd still like to > > > > understand > > > > what the public interface plans are. This is specifically > > > > because I > > > > think it would be better to re-use suitable public interface > > > > structs > > > > internally where possible. But that of course requires spelling > > > > out > > > > such parts of the public interface first. > > > >=20 > > > I am not sure that I get you here. > > > I greped a little bit and found out that each architecture > > > declares > > > this structure inside arch-specific folder. > > >=20 > > > Mostly the usage of the cpu_user_regs is to save/restore current > > > state > > > of CPU during traps ( exceptions/interrupts ) and > > > context_switch(). > >=20 > > Arm effectively duplicates the public interface struct > > vcpu_guest_core_regs > > and the internal struct cpu_user_regs (and this goes as far as also > > duplicating the __DECL_REG() helper). Personally I find such > > duplication > > odd at the first glance at least; maybe there is a specific reason > > for this > > in Arm. But whether the public interface struct can be re-used can > > likely > > only be known once it was spelled out. >=20 > struct vcpu_guest_core_regs is used as part of struct > vcpu_guest_context, which is used for VCPUOP_initialise, which is not > used on ARM and RISC-V (we use a standard firmware interface > instead), > and for save/restore, which also is not going to work any time soon > on > ARM and RISC-V. >=20 > This is to say that we are probably not going to need the public > interface for the next year or two, so it is difficult to tell at > this > stage if it aligns well with struct cpu_user_regs. I think we'll have > to > cross that bridge when we come to it. >=20 Agree that it will be better to return to the public interface later. So I'll this part of the patch series as is now. >=20 > > > Also some registers are modified during construction of a domain. > > > Thereby I prefer here to see the arch-specific register names > > > instead > > > of common. > >=20 > > Not sure what meaning of "common" you imply here. Surely register > > names > > want to be arch-specific, and hence can't be "common" with other > > arch-es. >=20 > I think Oleksii misunderstood your request and believed you were > asking > him to make struct cpu_user_regs common across arches. Yeah, that's what I thought at first... ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 06 17:30:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 17:30:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490671.759477 (Exim 4.92) (envelope-from ) id 1pP5Jm-0000JD-QL; Mon, 06 Feb 2023 17:30:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490671.759477; Mon, 06 Feb 2023 17:30:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP5Jm-0000J6-LS; Mon, 06 Feb 2023 17:30:14 +0000 Received: by outflank-mailman (input) for mailman id 490671; Mon, 06 Feb 2023 17:30:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP5Jl-0000J0-9Y for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 17:30:13 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8e9520d-a643-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 18:30:12 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id a2so10834466wrd.6 for ; Mon, 06 Feb 2023 09:30:12 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id d2-20020a056000186200b002bddd75a83fsm9979966wri.8.2023.02.06.09.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 09:30:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e9520d-a643-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=sKmFv+Y+fHTwV8G4a9TkOiAdfk5N2aZo0z6M5KjFABU=; b=RKC3jEtyZnPlL92R77zlXgBYgN+4WGuzpFmlrE48Mat7077sJy5pReBQgBTn6k7kA5 8486zgYIEJerDiMo1CeGxTZjIwVz36gTsStvNdR/uP2LC29un18aVmYWdgptukauHDaw 5jiSils3kmjCwnrfykXrU9n4gIVqCbOOyt3SybVb8J7dH9e4Jr9ox/lnJ0WITE5/0/xs cF0i0RUBt7jOSGuJXcZjFWfk5LrPcJWsgoPmV2uTdlVj/qdJ/q7c+cOmSE+wS6jsHkMj 5/6B4Ts1Tg4EA9fBZf1HBhAvJpjq2WgB/zP4OSR32GbKkEvnpqC2/LeopgUuTXkLLdG0 AvDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sKmFv+Y+fHTwV8G4a9TkOiAdfk5N2aZo0z6M5KjFABU=; b=jZ68GjyXJMrLYAZANX7WoHdwZ0bSGitIT44yOAOOAKQ4XpdITRal2tsKgrZqhNKBeP +sa/ro/YT90zQHkWW+GzQVqdz/ZEBr+SKZ3lzAM6G1CnwD2wBw4Lakj0m7j5dbelycZt siqlP21NhoDHDksxqoif5DGumVoDwF4nqO5mpvfYiIgAKkaiYImqkZyC5FgRZncxkTzY 419S/rPECelYqpzSfmV8w815DSweQEX0aTmsNwo0h9uUMY5SSSAttGHCLu8Ujt+Srsja TIU0tJs/6uwLRV5PM8QKGxoJpnwi1aYqW3T5IndJixhJvaYBfWEtDU+1A+VVvAdR7Fov ZkCQ== X-Gm-Message-State: AO0yUKVa94cO1uJUt8ysrK+QWJBqp6s/7NdmwHFFfL1AUI27eJNxNfwF KBY2D2DZBKb7oUXW0nha1dk= X-Google-Smtp-Source: AK7set+/uR4EPeIMP9HefYZxm4x0hB0Aikwa4fU5buMRhgscylD7e7ZxX+RNTcgFO/AyqLXIoPb/0A== X-Received: by 2002:adf:fb4b:0:b0:2bf:c4be:e987 with SMTP id c11-20020adffb4b000000b002bfc4bee987mr15873692wrs.26.1675704611505; Mon, 06 Feb 2023 09:30:11 -0800 (PST) Message-ID: <6573131ec6cde4eecce9959637965d10ef55ec71.camel@gmail.com> Subject: Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff From: Oleksii To: Julien Grall , Andrew Cooper , Alistair Francis Cc: xen-devel@lists.xenproject.org, Bob Eshleman , Alistair Francis , Andrew Cooper , Jan Beulich , Stefano Stabellini , Gianluca Guida , Connor Davis , Bobby Eshleman Date: Mon, 06 Feb 2023 19:30:09 +0200 In-Reply-To: <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> References: <06c2c36bd68b2534c757dc4087476e855253680a.1674819203.git.oleksii.kurochko@gmail.com> <2f6a3b17-4e41-fe9a-1713-4942b3bd3585@xen.org> <9d5841b2-5d0b-390f-6e95-cf492e99e5a2@srcf.net> <1a1e9b46-e665-f33a-b122-31a5af5b22da@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi all, On Wed, 2023-02-01 at 09:06 +0000, Julien Grall wrote: > Hi Andrew, >=20 > On 01/02/2023 00:21, Andrew Cooper wrote: > > On 31/01/2023 11:17 pm, Alistair Francis wrote: > > > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall > > > wrote: > > > > On 31/01/2023 11:44, Alistair Francis wrote: > > > > > On Sat, Jan 28, 2023 at 12:15 AM Oleksii > > > > > wrote: > > > > >=20 > > > > =C2=A0 From my understanding, on RISC-V, the use of PC-relative > > > > address is > > > > only guaranteed with medany. So if you were going to change the > > > > cmodel > > > > (Andrew suggested you would), then early_*() may end up to be > > > > broken. > > > >=20 > > > > This check serve as a documentation of the assumption and also > > > > help the > > > > developer any change in the model and take the appropriate > > > > action to > > > > remediate it. > > > >=20 > > > > > I think this is safe to remove. > > > > Based on what I wrote above, do you still think this is safe? > > > With that in mind it's probably worth leaving in then. Maybe the > > > comment should be updated to make it explicit why we want this > > > check > > > (I find the current comment not very helpful). > >=20 > > The presence of this check pre-supposes that Xen will always > > relocate > > itself, and this simply not true.=C2=A0 XIP for example typically does > > not > >=20 > > Furthermore it's not checking the property wanted.=C2=A0 The way C is > > compiled has no bearing on what relocation head.S uses to call it. >=20 > I think we are still cross-talking each other because this is not my=20 > point. I am not sure how to explain differently... >=20 > This check is not about how head.S call early_*() but making sure the > C=20 > function can be executed with the MMU off. In which case, you will=20 > likely have VA !=3D PA. >=20 > In theory head.S could apply some relocations before hand, but it may > be=20 > too complicated to do it before calling early_*(). >=20 > >=20 > > It is a given that we compile the hypervisor with a consistent code > > model, meaning that the properly actually making the check do what > > is > > wanted is also the property that means it is not needed in the > > first place. >=20 > See above. >=20 > >=20 > > This check is literally not worth the bytes it's taking up on disk, > > and > > not worth the added compiler time, nor the wasted time of whoever > > comes > > to support something like XIP in the future finds it to be in the > > way. > > Xen as a whole will really genuinely function as intended in models > > other than medany, and it demonstrates a misunderstanding of the > > topic > > to put in such a check to begin with. >=20 > Then enlight me :). So far it looks more like you are not > understanding=20 > my point: I am talking about C function call with MMU off (e.g. VA !=3D > PA) and you are talking about Xen as a whole. >=20 > I guess the only way to really know is to implement a different > model.=20 > At which point there are three possible outcome: > =C2=A0=C2=A0 1) We had the compiler check, it fired and the developper wi= ll > take=20 > action to fix it (if needed). > =C2=A0=C2=A0 2) We have no compiler check, the developper knew what to do= it > and=20 > fixed it. > =C2=A0=C2=A0 3) We have no compiler check, the developper where not aware= of > the=20 > problem and we will waste time. >=20 > Even if you disagree with the check, then I think 1 is still the best > because it would explain our assumption. Yes it may waste a few > minutes=20 > to the developer switching the model. But that probably nothing > compare=20 > to the time you could waste if you don't notice it. >=20 > Anyway, Alistair has now all the information to take an informative=20 > decision. >=20 I'll bring back the check and send the new version of the patch tomorrow as Bobby&Alistair lean toward it. Andrew, do you have other thoughts? > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 06 18:03:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 18:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490679.759487 (Exim 4.92) (envelope-from ) id 1pP5pe-0003zE-AK; Mon, 06 Feb 2023 18:03:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490679.759487; Mon, 06 Feb 2023 18:03:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP5pe-0003z7-6b; Mon, 06 Feb 2023 18:03:10 +0000 Received: by outflank-mailman (input) for mailman id 490679; Mon, 06 Feb 2023 18:03:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP5pc-0003z1-JL for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 18:03:08 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8048cc66-a648-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 19:03:06 +0100 (CET) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Feb 2023 13:03:02 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6478.namprd03.prod.outlook.com (2603:10b6:510:b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Mon, 6 Feb 2023 18:02:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6064.034; Mon, 6 Feb 2023 18:02:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8048cc66-a648-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675706586; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YJzG4NLn5eg6+L2HkO8F9YzYlDOI3tCiics21dQOJsY=; b=J6r6gVxn/L2Kuvpiw03cLH84zD2Mch05Nj3EmyGgV4J+B4xYHcEbu5GV FtmQJbnqLe/x02cHkrKcX3R9bjd5UoxX3vfZ0rf9vabtsoH4K+el1Y0+Q wXBuW9/Dx614d15+VKQJVNZMPiUhA41Nbv7N9YeFcyKKUGimdkTNnqrGc 4=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 95807338 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qoRGcqkuRpkSS02JVL6YtE7o5gyhJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJMXm/SPKyIZmD2fNx1PIrlpE8Pv5GHxtFrTVNupCs2FyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5AGGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cVHeB0GcBGvvPyn5+yEE9Z3luc8Ica+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDSe3gqaUx0DV/wEQ6T0QqXgOQmsK7j0XmAvVtN 3AY2jMh+P1aGEuDC4OVsweDiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceWjgCx lKP2dTzClRHsrKPTmmG3qyJtj70Mi8QRVLufgcBRAoBptXm/oc6i0uWSs45SfDkyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CHhRqcBO51lmW8g UU= IronPort-HdrOrdr: A9a23:yHYhZqo3gHdCC71iu9C61TAaV5oAeYIsimQD101hICG9E/bo8v xG+c5wuCMc5wx8ZJhNo7+90dC7MArhHP1OkOss1NWZPDUO0VHARL2Ki7GN/9SKIVycygcy78 Zdmp9FebnN5AhB5voSODPIaOrIGuP3lpxAWN2uqEuFkTsaE52IMT0JcDqmLg== X-IronPort-AV: E=Sophos;i="5.97,276,1669093200"; d="scan'208";a="95807338" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gxm6Gi46Zk+PKO26PvqdAqfkrfnr4JtaZrE87ClFOrOStDjCIv81QnX1JfLS02P41ISYqSSbQ/wz6ukTGuRC46hcDV4xtw3LbwAKnAESY+sbsTb5nR7yBKky5iXw4EAy1hyRNIuVifM1CKhHE6fB6PYBuGDThEQU9Uf3kUH52wZyOyi0KvRqIpIusWyI1zpZ8UGwOaldtacaQ4AYXJNr47s/CjwhQzv7e1DksTLAXi9/yAtDqJpR6y7jy7gwj3EHUKfEoOTFf2MUrCzNIuwfQIn6J8i1HF2K5KSs8M/ua4dfPzetomyeyz61dkF1m3BJkw1z1M5xfuAxqlN3PnFUuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8rHXcx2/qL3mNCXpB8gDZ0ooVc6uJLo6FWH+iGcAtI0=; b=FUC4YNzNaX9IYPB53TkS4o9SyXDnynvwtjz4ubaZ2qbIrVNbRfecReuxAmy19oAJi5BQfWRvZzqRWf3W8Jx3JniqZSduIP9AfsREYpWb1hWI4i0agme/hwla8Y1Hfn6BFOllDREVVh4pSO28nrjs20pUKra827+tcSCzz64fX585LdhnZV2C6ElSvmPFXz6UaPSl4eouyBX3/cBCzic8PxswEvGU8DxRoYzv1YCsO0K1ldp7ZuYKfHqEP7qi8z8u3c6T8+NMwlKy1ZRZr/gLVigDXfHKErCXjV4enXsD0Z7dG0PZBcba/5DamOejbMEitY4idnzndfUVZZbx/jhXhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8rHXcx2/qL3mNCXpB8gDZ0ooVc6uJLo6FWH+iGcAtI0=; b=fJpVZOFvwBPd9pUs7RUTVCikeOdWLbfRIqjUnBYNSq+gM3R8X8melcdZ5mT6z+U9biwTo/toAMWibLOgOQmfuYFk99yMXgjcxVUuXsep0BCTZiYKKmUT66fy+V/vQR8yy8CNLfKYjiG0C0JJor4dPoU0XnUklRVI2UlTbNG1bDg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 6 Feb 2023 18:02:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH for-4.17 v6 2/5] libs/light: Rework targets prerequisites Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Juergen Gross References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-3-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230120194431.55922-3-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0014.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6478:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fb6e008-abb0-462d-9b1f-08db086c6181 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZtZ+/Rx1o0ov4jIo9WK4irNzf174xsmx3lsagp1r9zCtQyuFHw7O6z7hjesWO46FLPmUksUz0647ItSc1UEKcaNiaY1uUthTh/ddTYZ0oRyUK7LBRl0nZvuAjN/8M+wcYHeEOtggnEh5zDEW6z0KtRTz+c4MlwWOpY4xaMeEm8B4PT1UA9vtMxEDXWWdH0PnnUInkuACMKlADs9Fpn7nZuN8Zr+HL/ZmAHQKrPtEitxnhKLphLd1LSs5YWOm1jIDXKPkvAVbjRe6n0qxgf1lC0oRVMBDUiGqWfvWEy5zOhUp1nPXZ94vE/IKmfMc6JFjez8U+/D7PXeCKHSvmKzhafL+JjSC/+yy9FWSr7S27ex04MzDnW8MkWYAlDFF2jJ1Rn8i6FUP8yOtNw5WQSoC1Umg5RlO5fyz/VZfCLbYNwbrWPeZ6tRS1lDPWucjPrvJjVk07Tsv7tND5//PD+6pGv2avFS9VAZ6i4eDswbzO44P5CynP6M2FdlFpJCs9a/TJAz1Nv6eFUCmmKDI1HS2qwkm0o3MoseG8GG9E25RqlgrG2gQNwp8p8EmurS+bBcYQtG8y5+6ASmwfa0BB9SVFKLhLyoN3XGpoWyqcw3Iufu1RU5qeKIxO4D6c9SSw6110HsNaqvO7JZBj0daWV5sTssBN+SJ2PY2CguKrdsJGQkwFNlc/LNe8IbMX1y0isA6MYKk0DqUKsJ+hoOz4hAvtDrg7k1uq0YUrfxCHLqHzTg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(451199018)(86362001)(2906002)(66556008)(31696002)(36756003)(82960400001)(83380400001)(53546011)(478600001)(6666004)(186003)(26005)(6512007)(6506007)(2616005)(8936002)(5660300002)(6486002)(41300700001)(38100700002)(54906003)(8676002)(66946007)(4326008)(66476007)(316002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHREeU9QYm1ja3JoRStUSTFUQitmSi9DU2x5Zks4d0VIMWdKcU1YK1F3aHEr?= =?utf-8?B?UHRPRzB1ZEI1QnRjVGhaNGpsT2FGLzBkc2owK0RVOGFJMW5mZGJEQ3BZUm1i?= =?utf-8?B?YlJKQzhqUGdieUhsR1FLY3krQjBGOGpPNEFyOGxrRHFBNUJJTU02RXFyRkZ5?= =?utf-8?B?SkhNWXFoK0MxNVBRQ0JRaUNIMFJKKzU0VEhJbjBtR2Z0eStscDdZd0xPV0Yw?= =?utf-8?B?L041RDBuc0docGxNc0tjWWlDdFhqQTlMNGJhQ0FMYWo1blFaTGNvOUhYclR3?= =?utf-8?B?bkR3dGtTSmYwbVpJSTBPTldOazJhbytEVXlVYnZWS3g3OVRHMUEvTlhsdUth?= =?utf-8?B?c3RkV3FEakFkK0RBWGhXQmIzajdvN0hIU3VQSEhNRmJjWHkySWRSblRrcmRJ?= =?utf-8?B?TzZUaU4vVzBzOTNHcEFTN2d5SXV2ckNjYlB5eGFjTlhUQkFmSzVjK3BKUTF3?= =?utf-8?B?ZDUySlF2bEZSTDdoV0JMaW9QVngxakNVSE1VSGQ4R25GNmhNakMxd0pmVk03?= =?utf-8?B?OXE4RExIa0Y0Z1lYTG81bDdtdzI0Q05pMlhaRklvejVOazZlNzBrVWxTSWVq?= =?utf-8?B?cjB0VytaaFRtbkFGaFREM0F3b1owWlV5Q0pDRkVFaGxPUm9XaXRJRGx3b2RV?= =?utf-8?B?TXU4SzdMelpTRStLcFYzT0Nqcm1sMjFpZXp1OHBiaFJ1ZUF5b0UwMGJSME54?= =?utf-8?B?T3NMZkZjS3JZUkpnZG40Q2pmd284MlZyK3NUdnVlWnJOeEdZb1RxSEk1TTQ5?= =?utf-8?B?OEpFVlM0RWNVLzlMcWNLYmk4dGFVS201V1NuSWllcENSTmdQU0dxcWFCTksz?= =?utf-8?B?WC81U0VFQnpaZG9MVDRyQlVVTkVGa0YzYlc4K1BuTG1UR0dmU0RkU2dKZkpX?= =?utf-8?B?YU8rOFI1eGxXVmxNYWx2Z1FUYjFFb3RTUWFYeFhpalVIelcyYlJxbUNFdFRD?= =?utf-8?B?end1RDdnUjhjdUF3K2JLaVd1Qk43eGVmdEdKdlBobjUvOFlJVHRTTFBPYUM5?= =?utf-8?B?a0VDak4yQXhaMmJxTy91SWlvVHZiZ2c1cVFIeFQ5N0pwNGF4UWgzbzc0QXEr?= =?utf-8?B?M3JpVFpTYXVlMkY2NTRlTTV2a2M5Uk96NjRGUlFNSGVSa3lubkkyc3B1MlhI?= =?utf-8?B?SllXWDlnUmxPVm5yM1FaUDFvOUdMUWdBMFdaelRWZ256RjdJcWYydktyeHRu?= =?utf-8?B?TzZkYkVRTEtrRmtSNFc2SVJuM2RoTHZjcVM5eHBGS3ZHYTVoR1FXRjdhZlhH?= =?utf-8?B?MzBjSGZwUjNhZVN1c0E3eC9Wc0wreDR0OWtLQ3VaZXNMQldLbnFZZWVFY0d6?= =?utf-8?B?R3RFaVNGdzl6cFF6Rk5KWVhxSTRZQUtRRG1hb0tXSTRnUzR5UzNIa1pjbG9H?= =?utf-8?B?VkhmK3dFazdRQ1ZSMzdraktPa0pwQ1NGQWJtUzZKVElaOFNzK2ZsWklKcWNV?= =?utf-8?B?ZWtnaFNNLzhRUS9WdGRIL1J1bEhSUnVzVkZHTnZxelRaZTJkdWpNblFHUmlB?= =?utf-8?B?VFBNN1NKZG9BeVZhZjBBYmpnSUZBTFE4OUdRMk9pc3NlWHpEUkJYNkZ4T09I?= =?utf-8?B?Wk1EdWRmc3RHVmg0bDdZMTBYUzJyTGJBYzRzUXNGZUExbkpPcm96dFFjdTBJ?= =?utf-8?B?ZVVZY2tJaWFHc2YyQzh4VjBsWWp2RGtvN1U0RytsUUxVNkNqMWcwOEwxMWF2?= =?utf-8?B?Umw5bDM0ekVWMFNlQ3pQM0pKZit5YVZzRDQ2ZE5iQ1BRWUhmMmdYSm41YkRM?= =?utf-8?B?dlBBcWxVZENGUEtGMkpWTjRlclkxMFlFTkx3bkNVdnJCc05xSkplZEdldEpy?= =?utf-8?B?alZ5WVppYk9QN3M2ZjRlZWg2Sm1sN0VsY1BaRUtJU2tXM2RQbXphdU9SaXR0?= =?utf-8?B?SWRXUy83MW41Q01obU1nUmFhSjcwMWMydVZLT09kZVNDNUtaR045Q2xSR0Zq?= =?utf-8?B?TzB5K2NzcWl6VWt3UFlpWnU3U2RDZU9vK3pnMkw1Sithc3JIa1RWV2NLbm9F?= =?utf-8?B?aDlCS3NnSVQ1NVhGd1BnUTRVQ25Pb1luUzFRUk1XRG9kd3Y4UWpMRnJzZFVv?= =?utf-8?B?SnJFVjBnR0VsbUNva1Z6TWlIYzNhQUZOcC8yZWVtakp5OXBrQWp1dFpkRk1Q?= =?utf-8?B?VGhLbHdNZmxxYTZ6NE5JTzJwRFRpTGZudUZNSjE2S2tHdUhZcFhrcVZPcElz?= =?utf-8?B?eXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YDGOvDNGlKHstIaRuxhKt9UKOO/S7AdQlgQPN9X9WtsQgHe4kzQDD9oueHjQ1jotFlrXmGrJt1Y3NXberq/mbxbViV6uzezlReWXsyy5p1Vh5H1+Ko0svHO4Cq9Zb7LKRsEv8tAJI4QmRzDoOIvAkD+D7xeoNeMsISWX/5bjQGdxGkPwznXkOk+4p4JFveeGNTF8SxqNLtHzjdpcnSG+mhLKNpgvEJmx7FvlCsy1bPpqU/2T39uLeFyf4S8V/Uj/kPcllbJQ7tklpaJiLvZtZn0ZqfVR9BSTrFs3vl3kjdj8oGVUJjQPM1h6yVpplTwa/ebMfLCPdoQHz+O/ageTh+ZoWHY/xTqn2ye2VckbWjG2V2BF8iwqUS2c/Q/x6/vJvXS3/WgPR7vjTTwZZCe5dktic2D9/m6FbSEF7+HMOERKjsbGB35NAjh9EMHyd8ImhfIWB2bEy4rTOLqtr54Ck4rN4R7JIjrHyKZfHxBhXkrBYQifDv2DFeK+N8HLnANGNEXQSsiWtI4j0R0t/CYvVRUzDl7wFz1vTOyckiB+nWNPY7BhU8cYr21ABd4uHBbzp1aHk40ST5D5HExMW0s7Ngb6aEgh5jfZPd2cWtMPTos4+uIQx1AYbhD6qQ5I4XSmQOtYHjfcetTn6mjRUgj184OTqfbNf2ar5NmD5gYpG54P5ta2tTPlYJQBRf5T1OvdAuHUCorxo27MMvFhBEgWwNb3CyAp+mvmenihPa7VuUR2u9SL/QS8ejePQ7nQZ3qpvVyRxjVKIE6zp/gx9Sa7Wp3UB3g5T1JAQQM9tvCZNqonebbCI4JKAcVDnS/ArC3j X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fb6e008-abb0-462d-9b1f-08db086c6181 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 18:02:59.0618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F02A5nS/WbPBhXW4saZ18ko8zfFhbG4nsUHhykMlq7mF7dqCb/pfcuRFYMleFZarYKT0rpc4dvKj35HbYbCI0HwkfMFOL0OvDxJAWZ5Jusk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6478 On 20/01/2023 7:44 pm, Anthony PERARD wrote: > No need for $(AUTOSRCS), GNU make can generate them as needed when > trying to build them as needed when trying to build the object. Also, > those two AUTOSRCS don't need to be a prerequisite of "all". As for > the "clean" target, those two files are already removed via "_*.c". > > We don't need $(AUTOINCS) either: > - As for both _libxl_save_msgs*.h headers, we are adding more > selective dependencies so the headers will still be generated as > needed. > - "clean" rule already delete the _*.h files, so AUTOINCS aren't needed > there. > > "libxl_internal_json.h" doesn't seems to have ever existed, so the > dependency is removed. > > Rework objects prerequisites, to have them dependents on either > "libxl.h" or "libxl_internal.h". "libxl.h" is not normally included > directly in the source code as "libxl_internal.h" is used instead, but > we have "libxl.h" as prerequisite of "libxl_internal.h", so generated > headers will still be generated as needed. > > Make doesn't need "libxl.h" to generate "testidl.c", "libxl.h" is only > needed later when building "testidl.o". This avoid the need to > regenerate "testidl.c" when only "libxl.h" changed. Also use automatic > variables $< and $@. > > Signed-off-by: Anthony PERARD > --- > > Notes: > v6: > - rebased, part of the patch commited as 4ff0811 > - reword commit message > > v4: > - new patch > > tools/libs/light/Makefile | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile > index cd3fa855e1..b28447a2ae 100644 > --- a/tools/libs/light/Makefile > +++ b/tools/libs/light/Makefile > @@ -148,9 +148,6 @@ LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.opic) > TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o > TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t) > > -AUTOINCS = _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h > -AUTOSRCS = _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c > - > CLIENTS = testidl libxl-save-helper > > SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o > @@ -178,13 +175,13 @@ libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -I$(XEN_ROOT)/tools > $(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest) > > testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight) > -testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS) > - $(PYTHON) gentest.py libxl_types.idl testidl.c.new > - mv testidl.c.new testidl.c > +testidl.c: libxl_types.idl gentest.py > + $(PYTHON) gentest.py $< $@.new > + mv -f $@.new $@ Doesn't this want to be a mov-if-changed? We don't need to force a rebuild if testidl.c hasn't changed, I don't think. > > -all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS) > +all: $(CLIENTS) $(TEST_PROGS) > > -$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok > +$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): libxl.api-ok > > $(DSDT_FILES-y): acpi > > @@ -196,7 +193,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check > $(PERL) $^ > touch $@ > > -_libxl.api-for-check: $(XEN_INCLUDE)/libxl.h $(AUTOINCS) > +_libxl.api-for-check: $(XEN_INCLUDE)/libxl.h > $(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \ > -DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \ > >$@.new > @@ -208,14 +205,22 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \ > $(PERL) -w $< $@ >$@.new > $(call move-if-changed,$@.new,$@) > > +# > +# headers dependencies on generated headers > +# > $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h > $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h > libxl_internal.h: $(XEN_INCLUDE)/libxl.h $(XEN_INCLUDE)/libxl_json.h > libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h > -libxl_internal_json.h: _libxl_types_internal_json.h > +libxl_internal.h: _libxl_save_msgs_callout.h > > -$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h > +# > +# objects dependencies on headers that depends on generated headers > +# > +$(TEST_PROG_OBJS): $(XEN_INCLUDE)/libxl.h > $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h > +$(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h _libxl_save_msgs_helper.h > +testidl.o: $(XEN_INCLUDE)/libxl.h I know you're just rearranging existing the existing logic, but why doesn't `#include ` not generate suitable dependences ? ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 06 18:46:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 18:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490689.759498 (Exim 4.92) (envelope-from ) id 1pP6VZ-0000PO-Ox; Mon, 06 Feb 2023 18:46:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490689.759498; Mon, 06 Feb 2023 18:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP6VZ-0000PH-Lp; Mon, 06 Feb 2023 18:46:29 +0000 Received: by outflank-mailman (input) for mailman id 490689; Mon, 06 Feb 2023 18:46:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP6VZ-0000P7-7X; Mon, 06 Feb 2023 18:46:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP6VZ-00007R-5E; Mon, 06 Feb 2023 18:46:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP6VY-0003t2-Ou; Mon, 06 Feb 2023 18:46:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP6VY-00086a-OV; Mon, 06 Feb 2023 18:46:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RpI4LDbHt5mLGxb8keXJEfVfNS7hAgFjTmoUl0eTD1o=; b=lfZ7j8cOB9bLnFaiGDCrb43q6I 6XUdePLWqabZd41M1U5NuWOWof/dBDZ9A+VPZx0i8vQrrTELeXYA7n8mfhirZgAB+8eyGgGjPbqAr 2eFBgLLOMYIxnAY4M1QPgpD9O7PUq+ufGDSJoHjfq/VdBIgP/f0lfIbE9WOUWbCtclWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176424: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=6c707d4573f5df2b60503dfeedc10b33cebd60d1 X-Osstest-Versions-That: xen=3a59443c1d5ae0677a792c660ccd3796ce036732 From: osstest service owner Date: Mon, 06 Feb 2023 18:46:28 +0000 flight 176424 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176424/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 6c707d4573f5df2b60503dfeedc10b33cebd60d1 baseline version: xen 3a59443c1d5ae0677a792c660ccd3796ce036732 Last test of basis 176417 2023-02-06 11:01:59 Z 0 days Testing same since 176424 2023-02-06 16:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3a59443c1d..6c707d4573 6c707d4573f5df2b60503dfeedc10b33cebd60d1 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 06 19:22:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 19:22:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490698.759509 (Exim 4.92) (envelope-from ) id 1pP73e-0004th-Hq; Mon, 06 Feb 2023 19:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490698.759509; Mon, 06 Feb 2023 19:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP73e-0004ta-DC; Mon, 06 Feb 2023 19:21:42 +0000 Received: by outflank-mailman (input) for mailman id 490698; Mon, 06 Feb 2023 19:21:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP73d-0004tU-E8 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 19:21:41 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20605.outbound.protection.outlook.com [2a01:111:f400:fe5b::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79d7c36c-a653-11ed-933c-83870f6b2ba8; Mon, 06 Feb 2023 20:21:39 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by IA1PR12MB6210.namprd12.prod.outlook.com (2603:10b6:208:3e6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Mon, 6 Feb 2023 19:21:34 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6064.032; Mon, 6 Feb 2023 19:21:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79d7c36c-a653-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkQgJ0wLdntU9VH1Al87kQfnjmqhG3TqFQJs+9xfnizKT9ETnHuXK8oiPjfDeh9pC8nZDL1i8h2eEBAD4/bq8iR9PjNJCsYUzdshk0hqFUlocSDZYMWmkEn57clcl4WdGyYgbnuKvSlL4XSxWWU4cqHs+SiEG93cGHGyCoBE5vUp8F/gtqyF5nzuthBXB3BFeNuPVAqS7SBs6nGxlCLEmaqw/eO28TcrAdgOQD4s60TrgIKWePta82gaB2MRml8dBDTx/fYxizGjRH1y3RRTrP7cGzmigFePOpLSnJTiBhKPKXXO0/2w3pRlVFg8J8v4xW1IIw3W9jri6MAhi9x9Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RFMIzuROk4KVY1ZC3vF6DMro9amPOV07A1IIMt8JDpI=; b=LACoX2TUMktdVQef8seLjxlTUGgM1yXJ+utwYfVyo9Mblc8PlhinLrFtEE7WtvgB7rTuR+fD9lqyeVIvDpNgadyfbmHmDT261HAx4zTNeWT/TYqc3lIpp5Evtx+9BbuzoyiB4i3OQv6OlRWWlA/xWxqhsngkihU4arXOGuNOBPtWvSWjSgbRFIYV0G1543PXNTor2H2Q897l3EzO6I6bdl5UqL/RaRTHQvV/z+X0+HEKGnn4VFD1HHsaENsuZTNsm2Kg0n2e67ZkKNLV8u/TSjToC7Y9N0Yo1vgsJqnwBOVUertKvK/VyXGOXVLWaMUqFr6i+/8QPaZjo0o30nRRUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RFMIzuROk4KVY1ZC3vF6DMro9amPOV07A1IIMt8JDpI=; b=t1sj3d5Ba2MAv25XkXpXF0JlWfFakQ2i9r2A9q4pTNpmJBGYTFB1lUlL9n5hnOnvuBNPr/bskRRlF3B8l1DrBvl/wHF0Oitu795NJmGZClbeTgVENQkPGIRYRRYUQGqWMch76jpPRdBQG9t/cPF3YCPnKNaNkqBKW/BYeVfWYJc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <8144403d-0899-5b25-f1b0-f798d4b371a6@amd.com> Date: Mon, 6 Feb 2023 19:21:28 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size To: Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-6-ayan.kumar.halder@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|IA1PR12MB6210:EE_ X-MS-Office365-Filtering-Correlation-Id: 50ccd8dd-54b2-4c68-48b1-08db08775c2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cN/Ctfw6/q92zU5cuvlZYKpJ58/FZpm32HCxctpU1cr3OOxFJxgxAyF6BzYswqRh+WDF/D0Nxv8wMLcb5xLna3kPEweCRizv7W0Q7OBXQzcyRipA872D8PAbAE4mf41R68FPAUIlo1Evf93dNFUollO5C0wnIf08YkOA3atYsXlMCSL6InAUAgPIaAX7CPQEdx2hYnAheCU086V3cs+13YjSZpaKkxUY2WUBqLu2kbqvrAbeQrt2MJQOcDvsL3UAMMd0kuOjBltLuH6rvtbvTjiVUJS3/a6zxsfrgEPtNaszhHHU2vA4w2oFkCMbBU+Dv/q2xQBmCQFVk0Su7grXSeDdntJnlrO6Q6Oi+lgARlplgVp6xvLhGfr5SpCZ9CRJlc8N1u435G8igU/WkhTOY7+GZBpGdixnOZs3XN8z0i6uiBT+PjIR+2Ena757AIcwyDQsOHgGdlgq7lzS0yTjtGF0jCpDuddqQTajUuCgWA4f8vqUIqxPwNOe4X5XkNx3OU43nr6omRxyzIfiMgmBx8Bi/DTLA9nJjJP3GMI/SqWMDOaUaROXHVX0p+ZGAlgU7rHrwVp5c+StPltnzY6+OffCStu1hYXxMW/YVpCKNWmJDU7Fd5fhyn62vBV+49fg/ua6FALORI4OLh8lnWx0mzs7YhPxoE45rImeVG5RImgsRBIE2LCXwlfTZJmKT4DJds1jVFGBQQgsws9tfpPQ7vvGCiMH2uXnV0ZNfv2M0fY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199018)(66476007)(66556008)(8676002)(66946007)(8936002)(41300700001)(4326008)(31686004)(316002)(110136005)(83380400001)(6636002)(5660300002)(2906002)(36756003)(6666004)(6486002)(31696002)(478600001)(26005)(2616005)(53546011)(6506007)(6512007)(186003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEQyTC9FVmJaZ1Y4cC9jcVpkSWROSnVjaFdsZGpOVnpQN0RZYkRMU0tHanJv?= =?utf-8?B?cThlQnhNV2RvdnpxaG9Nc0dJOFJ0RVZnVnFZTTVFRU9sc3lHeHhQa0k2MVQ3?= =?utf-8?B?aUdteEo4d1BEc2lnbkVQeGsxVGFCNUhVWkQ4YitERVJRVmRMdXo2Tzl4Rngy?= =?utf-8?B?RGwyTmI5c1NNYmI0bkFZNW01dEs1cGhoRmJuUTd3Y3ZKRXJLalJUczczTThE?= =?utf-8?B?SUFubHUvM2FWVlpQcEswU1VGanRXNEVUaU01SDZ2bDRDVyt6NXhLdU9ybmVN?= =?utf-8?B?Y09KMG5oS3BRV285dlQxaElVWU1rSzhHYXRLVDhmK3AycUZqSlI5Si8rV2d5?= =?utf-8?B?OHdRcnQ4d1FZRzhlcG81SWp6OWwxYUlnTGoydnhxN2M1czdGejBzMXdPczhm?= =?utf-8?B?NTh6RzlUeHA3M21FS0xrdFRXM2dlK1ljRFJhWEo4b2lRUW1lQnEzVGpBSG5j?= =?utf-8?B?M042Z01rcGZsTXF6aE5XQ2NDQ2dubWcxbFl0V3JQSFBPRlFkdGZUK1NMTU9a?= =?utf-8?B?djZIM1l2cDV4VzBnNTVVK21lL0NMZDM5QS8wY3F2RTlNTWdVVEJteXBSaHdw?= =?utf-8?B?TTg4VzM2d3l3WHJIV3BMVXQ2SzlwQUF0L2RzYkdBcm01bUNEQnB0OHRkbnVv?= =?utf-8?B?Nk1rZU42Z29OTzdHUDE5S0FPNUl0WVpxZTViZUg3b2VRZTdEWkV4eGpYZXUy?= =?utf-8?B?TUtqbnJXTE91TndKUU5EcnB2REZxMnVncWtFOENCTkRQTHBKVk5DQ0JzRmpn?= =?utf-8?B?TnNaZ2RONzFhNkZKd2VkYVF5U3VXRzRROXF4TVJXZkRHbjc1cVhLc2dKWlVs?= =?utf-8?B?c3ZIdmI0MGdvZUhYc211Z0Q0N3h4SGFWa2cyT3hXeHd5aVc4NHNEYmZFTDVx?= =?utf-8?B?NHlxTzVkTUMrUkp3a0paR05HcXppZS9WbHRXU3RUekVoWnp0cHhzcTlibng1?= =?utf-8?B?OEhlUnJxTTVkWHNvWThGODZmaDdldUtwSityNVZIMmRYdlVCMWRTWkVXS294?= =?utf-8?B?a3ZZYXQvZnRxbEVka3JldFMxWWhyMHJuazAwYnRjUDNESFpMWlhLQS9WeUxy?= =?utf-8?B?MVB5M2VSYXdDWWk2ODJQeEY5UlV1cVRhR3EvV2tnL2lLUlZsY2hIWmphNEYv?= =?utf-8?B?Z1ZncE5tdG1oK3ozS0Q2a0JRcGlPK2oyQVhtWFNoSXI3Ym9vN3NJRXhURDJ5?= =?utf-8?B?dTlMdzdKOHl3ZjlMeDhrdGl1Ni9LMmJLS3YyakMxWDBKNDhDQklJcmN6cUYr?= =?utf-8?B?ZFFGcVhxUXBNWU5GVEd0K3dQeFFaQ3JZNmN3ZDNGMUVMbmw4U3o4M2ZPRFlQ?= =?utf-8?B?aWowd2VuRWpPSldRaGV3OU5qaVVPeFZacXFPdXRaazVxdENEYzFURnFUQ0Yx?= =?utf-8?B?WkV3b0cxS3pWZlpWa08vVE5aaFlTN2JWcnhPTlJjUVlwYWZNYTJ6UnJydTdR?= =?utf-8?B?YWwzZ1lVaHBqdkUzN1dBWmtZS2taRXZCb1BORjZLRlVzVkhjMFRaV1ovb1BX?= =?utf-8?B?bXUvTm5DcEFVRmszKzc3ZXYxSlRoTmpFQUQ0emFBN2ZsSEgvV1JDcFY5d0RC?= =?utf-8?B?cC9YdHdZYUwvV0h2ZHJzN1kzUzNmd1FDbm5xc0J6SWlPR2NIREM0eVVSL01L?= =?utf-8?B?U1cxR0RkQUtJREN5UmMvK2ZaYURZcW9MOHFHMFZ6T1F1MW53WHRaRTlaMUZh?= =?utf-8?B?UUx4OUczZFNOUEs1Qm9uc0VDc2lVT3FoenM4NjlyRjVXaHAxd2RjMEUwQmoz?= =?utf-8?B?SC8yL3BVaGtMNGlpOXBrZXZvYnFRdnVZejY1YmRtY014K3FYQXUrRExoTVJR?= =?utf-8?B?SFdmdVh4OFBjMStXbEdIU3J0b3d4NG1JT2RtemwrMlFudklNRnMyMDVrVlhu?= =?utf-8?B?VTV5N2RqMGIyMWcyY2FReFN3ZjVCY0tIU0c2MlZHNG42UENsWGxmek9OY3NC?= =?utf-8?B?ZkNodk90S0djRTNXMktadG1DU1pOLzhmRG1IaG9UTkxLNVdSUiswWjlWYUMz?= =?utf-8?B?Qk04ODBFYldUYkxVOHZRbEg2OFZwaWtTc1NKaktlRGhkQnowUXFuazJKY2Fp?= =?utf-8?B?T0tLTndib1QrNU9SbGdTTmZlMTUrR3g2NW51STFWcUIxT0MwUGlrekZzdTl6?= =?utf-8?Q?t7gO8p2DQeSTAEWBCp6Cju1Kw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50ccd8dd-54b2-4c68-48b1-08db08775c2c X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 19:21:34.5624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VXkD7di2VU7VtV1lCMSszvajmVtqOgr1MBQ0uJAwKSodYritOJwL6NX6FAIWrSxssUtEIfiXNAhRzOo9oJWSKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6210 Hi Stefano, On 19/01/2023 23:24, Stefano Stabellini wrote: > On Tue, 17 Jan 2023, Ayan Kumar Halder wrote: >> One should now be able to use 'paddr_t' to represent address and size. >> Consequently, one should use 'PRIpaddr' as a format specifier for paddr_t. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from - >> >> v1 - 1. Rebased the patch. >> >> xen/arch/arm/domain_build.c | 9 +++++---- >> xen/arch/arm/gic-v3.c | 2 +- >> xen/arch/arm/platforms/exynos5.c | 26 +++++++++++++------------- >> xen/drivers/char/exynos4210-uart.c | 2 +- >> xen/drivers/char/ns16550.c | 8 ++++---- >> xen/drivers/char/omap-uart.c | 2 +- >> xen/drivers/char/pl011.c | 4 ++-- >> xen/drivers/char/scif-uart.c | 2 +- >> xen/drivers/passthrough/arm/smmu.c | 6 +++--- >> 9 files changed, 31 insertions(+), 30 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 72b9afbb4c..cf8ae37a14 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -1666,7 +1666,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, >> dt_for_each_device_node( dt_host, np ) >> { >> unsigned int naddr; >> - u64 addr, size; >> + paddr_t addr, size; >> >> naddr = dt_number_of_address(np); >> >> @@ -2445,7 +2445,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, >> unsigned int naddr; >> unsigned int i; >> int res; >> - u64 addr, size; >> + paddr_t addr, size; >> bool own_device = !dt_device_for_passthrough(dev); >> /* >> * We want to avoid mapping the MMIO in dom0 for the following cases: >> @@ -2941,9 +2941,10 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, >> if ( res ) >> { >> printk(XENLOG_ERR "Unable to permit to dom%d access to" >> - " 0x%"PRIx64" - 0x%"PRIx64"\n", >> + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", >> kinfo->d->domain_id, >> - mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); >> + (paddr_t) (mstart & PAGE_MASK), >> + (paddr_t) (PAGE_ALIGN(mstart + size) - 1)); > Why do you need the casts here? mstart is already defined as paddr_t Actually, this is because the PAGE_MASK is defined as 'long'. See xen/include/xen/page-size.h :- #define PAGE_SIZE           (_AC(1,L) << PAGE_SHIFT) #define PAGE_MASK           (~(PAGE_SIZE-1)) So, the resultant type inferred is 'long unsigned int'. Thus, we need to add an explicit cast. - Ayan > > >> return res; >> } >> >> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c >> index bb59ea94cd..391dfa53d7 100644 >> --- a/xen/arch/arm/gic-v3.c >> +++ b/xen/arch/arm/gic-v3.c >> @@ -1393,7 +1393,7 @@ static void __init gicv3_dt_init(void) >> >> for ( i = 0; i < gicv3.rdist_count; i++ ) >> { >> - uint64_t rdist_base, rdist_size; >> + paddr_t rdist_base, rdist_size; >> >> res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size); >> if ( res ) >> diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c >> index 6560507092..f79fad9957 100644 >> --- a/xen/arch/arm/platforms/exynos5.c >> +++ b/xen/arch/arm/platforms/exynos5.c >> @@ -42,8 +42,8 @@ static int exynos5_init_time(void) >> void __iomem *mct; >> int rc; >> struct dt_device_node *node; >> - u64 mct_base_addr; >> - u64 size; >> + paddr_t mct_base_addr; >> + paddr_t size; >> >> node = dt_find_compatible_node(NULL, NULL, "samsung,exynos4210-mct"); >> if ( !node ) >> @@ -59,7 +59,7 @@ static int exynos5_init_time(void) >> return -ENXIO; >> } >> >> - dprintk(XENLOG_INFO, "mct_base_addr: %016llx size: %016llx\n", >> + dprintk(XENLOG_INFO, "mct_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", >> mct_base_addr, size); >> >> mct = ioremap_nocache(mct_base_addr, size); >> @@ -97,9 +97,9 @@ static int __init exynos5_smp_init(void) >> struct dt_device_node *node; >> void __iomem *sysram; >> char *compatible; >> - u64 sysram_addr; >> - u64 size; >> - u64 sysram_offset; >> + paddr_t sysram_addr; >> + paddr_t size; >> + paddr_t sysram_offset; >> int rc; >> >> node = dt_find_compatible_node(NULL, NULL, "samsung,secure-firmware"); >> @@ -131,7 +131,7 @@ static int __init exynos5_smp_init(void) >> dprintk(XENLOG_ERR, "Error in %s\n", compatible); >> return -ENXIO; >> } >> - dprintk(XENLOG_INFO, "sysram_addr: %016llx size: %016llx offset: %016llx\n", >> + dprintk(XENLOG_INFO,"sysram_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"offset: 0x%"PRIpaddr"\n", >> sysram_addr, size, sysram_offset); >> >> sysram = ioremap_nocache(sysram_addr, size); >> @@ -189,7 +189,7 @@ static int exynos5_cpu_power_up(void __iomem *power, int cpu) >> return 0; >> } >> >> -static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) >> +static int exynos5_get_pmu_baseandsize(paddr_t *power_base_addr, paddr_t *size) >> { >> struct dt_device_node *node; >> int rc; >> @@ -215,7 +215,7 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) >> return -ENXIO; >> } >> >> - dprintk(XENLOG_DEBUG, "power_base_addr: %016llx size: %016llx\n", >> + dprintk(XENLOG_DEBUG, "power_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", >> *power_base_addr, *size); >> >> return 0; >> @@ -223,8 +223,8 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) >> >> static int exynos5_cpu_up(int cpu) >> { >> - u64 power_base_addr; >> - u64 size; >> + paddr_t power_base_addr; >> + paddr_t size; >> void __iomem *power; >> int rc; >> >> @@ -256,8 +256,8 @@ static int exynos5_cpu_up(int cpu) >> >> static void exynos5_reset(void) >> { >> - u64 power_base_addr; >> - u64 size; >> + paddr_t power_base_addr; >> + paddr_t size; >> void __iomem *pmu; >> int rc; >> >> diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c >> index 43aaf02e18..32cc8c78b5 100644 >> --- a/xen/drivers/char/exynos4210-uart.c >> +++ b/xen/drivers/char/exynos4210-uart.c >> @@ -303,7 +303,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, >> const char *config = data; >> struct exynos4210_uart *uart; >> int res; >> - u64 addr, size; >> + paddr_t addr, size; >> >> if ( strcmp(config, "") ) >> printk("WARNING: UART configuration is not supported\n"); >> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c >> index 58d0ccd889..8ef895a2bb 100644 >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -42,8 +42,8 @@ >> >> static struct ns16550 { >> int baud, clock_hz, data_bits, parity, stop_bits, fifo_size, irq; >> - u64 io_base; /* I/O port or memory-mapped I/O address. */ >> - u64 io_size; >> + paddr_t io_base; /* I/O port or memory-mapped I/O address. */ >> + paddr_t io_size; >> int reg_shift; /* Bits to shift register offset by */ >> int reg_width; /* Size of access to use, the registers >> * themselves are still bytes */ >> @@ -1166,7 +1166,7 @@ static const struct ns16550_config __initconst uart_config[] = >> static int __init >> pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >> { >> - u64 orig_base = uart->io_base; >> + paddr_t orig_base = uart->io_base; >> unsigned int b, d, f, nextf, i; >> >> /* NB. Start at bus 1 to avoid AMT: a plug-in card cannot be on bus 0. */ >> @@ -1259,7 +1259,7 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >> else >> size = len & PCI_BASE_ADDRESS_MEM_MASK; >> >> - uart->io_base = ((u64)bar_64 << 32) | >> + uart->io_base = (paddr_t) ((u64)bar_64 << 32) | >> (bar & PCI_BASE_ADDRESS_MEM_MASK); >> } >> /* IO based */ >> diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c >> index d6a5d59aa2..3b53e1909a 100644 >> --- a/xen/drivers/char/omap-uart.c >> +++ b/xen/drivers/char/omap-uart.c >> @@ -324,7 +324,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, >> struct omap_uart *uart; >> u32 clkspec; >> int res; >> - u64 addr, size; >> + paddr_t addr, size; >> >> if ( strcmp(config, "") ) >> printk("WARNING: UART configuration is not supported\n"); >> diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c >> index be67242bc0..256ec11e3f 100644 >> --- a/xen/drivers/char/pl011.c >> +++ b/xen/drivers/char/pl011.c >> @@ -222,7 +222,7 @@ static struct uart_driver __read_mostly pl011_driver = { >> .vuart_info = pl011_vuart, >> }; >> >> -static int __init pl011_uart_init(int irq, u64 addr, u64 size, bool sbsa) >> +static int __init pl011_uart_init(int irq, paddr_t addr, paddr_t size, bool sbsa) >> { >> struct pl011 *uart; >> >> @@ -258,7 +258,7 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev, >> { >> const char *config = data; >> int res; >> - u64 addr, size; >> + paddr_t addr, size; >> >> if ( strcmp(config, "") ) >> { >> diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c >> index 2fccafe340..b425881d06 100644 >> --- a/xen/drivers/char/scif-uart.c >> +++ b/xen/drivers/char/scif-uart.c >> @@ -311,7 +311,7 @@ static int __init scif_uart_init(struct dt_device_node *dev, >> const char *config = data; >> struct scif_uart *uart; >> int res; >> - u64 addr, size; >> + paddr_t addr, size; >> >> if ( strcmp(config, "") ) >> printk("WARNING: UART configuration is not supported\n"); >> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c >> index 0a514821b3..490d253d44 100644 >> --- a/xen/drivers/passthrough/arm/smmu.c >> +++ b/xen/drivers/passthrough/arm/smmu.c >> @@ -73,8 +73,8 @@ >> /* Xen: Helpers to get device MMIO and IRQs */ >> struct resource >> { >> - u64 addr; >> - u64 size; >> + paddr_t addr; >> + paddr_t size; >> unsigned int type; >> }; >> >> @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, >> ptr = ioremap_nocache(res->addr, res->size); >> if (!ptr) { >> dev_err(dev, >> - "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", >> + "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", >> res->addr, res->size); >> return ERR_PTR(-ENOMEM); >> } >> -- >> 2.17.1 >> From xen-devel-bounces@lists.xenproject.org Mon Feb 06 19:31:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 19:31:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490705.759520 (Exim 4.92) (envelope-from ) id 1pP7D8-0006SY-Er; Mon, 06 Feb 2023 19:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490705.759520; Mon, 06 Feb 2023 19:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP7D8-0006SR-Av; Mon, 06 Feb 2023 19:31:30 +0000 Received: by outflank-mailman (input) for mailman id 490705; Mon, 06 Feb 2023 19:31:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP7D7-0006SF-5V; Mon, 06 Feb 2023 19:31:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP7D7-000164-4Q; Mon, 06 Feb 2023 19:31:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP7D6-0005k6-OQ; Mon, 06 Feb 2023 19:31:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pP7D6-00032x-Nw; Mon, 06 Feb 2023 19:31:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=86YFyfO80loxadlAThIGGC8L/I491RTDl7UqMzHvm8s=; b=kxZUXouEI4VQCV6GCIUhMMRyWN /s0QQuac6TPXP4Dg1X+WwpxpSJLVcNlDjvr3QZcVt9Ue3Y06EQBX+mnNu+VxtAKWMviFHVT/rMXJQ m5hXpRQGlIpjUk6lYuhQY9Hfk7/GSIUZ3lvgUghFFeKEWlm0CYyydva4GmT53R0UtC2g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176426: all pass - PUSHED X-Osstest-Versions-This: ovmf=aea8a9c954a79029ded443eadf7c92716c1753cc X-Osstest-Versions-That: ovmf=b98e2113b53fa9c7474a820bcd94fffb352acdf6 From: osstest service owner Date: Mon, 06 Feb 2023 19:31:28 +0000 flight 176426 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176426/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aea8a9c954a79029ded443eadf7c92716c1753cc baseline version: ovmf b98e2113b53fa9c7474a820bcd94fffb352acdf6 Last test of basis 176422 2023-02-06 14:13:24 Z 0 days Testing same since 176426 2023-02-06 16:44:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Nickle Wang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b98e2113b5..aea8a9c954 aea8a9c954a79029ded443eadf7c92716c1753cc -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Feb 06 20:30:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 20:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490719.759537 (Exim 4.92) (envelope-from ) id 1pP88M-0004r9-0v; Mon, 06 Feb 2023 20:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490719.759537; Mon, 06 Feb 2023 20:30:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP88L-0004r2-U5; Mon, 06 Feb 2023 20:30:37 +0000 Received: by outflank-mailman (input) for mailman id 490719; Mon, 06 Feb 2023 20:30:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP88K-0004qw-K5 for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 20:30:36 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19a5403b-a65d-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 21:30:32 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 316KUAaZ049716 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Feb 2023 15:30:16 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 316KU9o2049715; Mon, 6 Feb 2023 12:30:09 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19a5403b-a65d-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 12:30:09 -0800 From: Elliott Mitchell To: Julien Grall Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Message-ID: References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Mon, Feb 06, 2023 at 05:07:50PM +0000, Julien Grall wrote: > > On 06/02/2023 16:09, Elliott Mitchell wrote: > > On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: > >> > >> On 06/02/2023 07:29, Jan Beulich wrote: > >>> On 22.07.2020 19:43, Elliott Mitchell wrote: > >>>> Unlike other unsupportted options, ACPI support is required to *boot* > >>>> for a number of platforms. Users on these platforms are unable to use > >>>> distribution builds and must rebuild from source to use Xen. > >>>> > >>>> Signed-off-by: Elliott Mitchell > >>> > >>> A general question first: How come this mail dates back to July 2020? I > >>> had almost missed it as "new". > >> > >> I can't even find the Elliott's email in my inbox so reply here. But > >> this sounds like a rehash of [1]. > > > > The date on Git patches is meant as an indicator for author date. Since > > this is a cherry-pick of a patch which was written >2 years ago > > `git format-patch` indicates when it was written. This IS how these > > systems work. > > Hmmm... I am a bit surprised to what you say. I have sent several > patches in the past with an old author date and they always showed as > the date sent in my inbox. Dunno, but it was straight out of `git format-patch`. I'm not using `git send-email` though (that requires a setup distinct from what I'm aiming for). > >> >> Unlike other unsupportted options, ACPI support is required to *boot* > >> >> for a number of platforms. Users on these platforms are unable to use > >> >> distribution builds and must rebuild from source to use Xen. > >> > >> What platforms are you testing on? I know that this is working-ish on > >> RPI4 and QEMU. But this will likely blow up on one of the server we > >> support in OSSTest because we don't have proper support to hide SMMUs in > >> dom0. > > > > I've been doing RPI4 w/EDK2. Which works for my purpose, the remaining > > trouble spot for my purpose is needing a final resolution of the EFIFB > > situation. > > I have had no feedback from the relevant person on EFIFB patch and I am > not planning to purse the work in the near future. Okay, thanks for the news. Hopefully efifb on Xen support gets into kernels closer to the Linux HEAD. > >>>> --- a/xen/arch/arm/Kconfig > >>>> +++ b/xen/arch/arm/Kconfig > >>>> @@ -29,13 +29,18 @@ menu "Architecture Features" > >>>> source "arch/Kconfig" > >>>> > >>>> config ACPI > >>>> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED > >>>> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" > >> > >> The concerns I raised in [1] still stand. Most of the ACPI platform will > >> also have support for IOMMUs. If we have support for IORT in Xen, then I > >> would be a lot more amenable to remove the "UNSUPPORTED". And without > >> that support we are going to do more harm and than good. > > > > Okay, this has been a known issue for *years* and yet remains unresolved > > despite being a major issue. > > Right, the situation hasn't changed much since you last sent your patch > to drop EXPERT/UNSUPPORTED. > > Unless you fancy working on ACPI, I don't really see the situation > changing soon. The situation is changing in large entities are pushing ACPI for ARM. If they succeed (likely) then it will be a case of Xen/ARM MUST support ACPI, or else the project will die. There is always a chance I might end up going after this, but that doesn't seem too likely in the near future. > > Might be an abomination, but would it work > > to find the string "IORT" and change it to "iort", "RTIO" or "IOXN" to > > prevent Dom0 from finding it? > > Unfortunately no because there IORT is used to describing mapping for > the GICv3 ITS which is currently working when ACPI is enabled in Xen. The original advantage of Xen was paravirtualization. Might this be a case where it is better to have Domain 0 compensate and know the SMMU is unusable with current versions of Xen? > > This ends up turning into a question of what are the cases and which are > > more common? > > > > Case1: DT-only: Unchanged > > > > Case2: Switchable between DT and ACPI, w/o SMMU: Starts working with ACPI > > > > Case3: Switchable between DT and ACPI, w/SMMU: Unchanged, ACPI mode still > > doesn't work, but the failure is different. > > > > Case4: Concurrent DT and ACPI support, w/o SMMU: Unchanged > > So Xen would start using ACPI rather than DT.I think we should default > DT it until we have the ACPI support completed. Isn't this precisely what the proposed change does? Are you suggesting, if both DT and ACPI are present, prevent Dom0 from seeing ACPI? If you're suggesting doing futher masking, perhaps only if SMMU is present? > > Case5: Concurrent DT and ACPI support, w/SMMU: Breaks if Dom0 tries to > > use ACPI > > > > Case6: ACPI-only, w/o SMMU: Starts working out-of-box > > > > Case7: ACPI-only, w/SMMU: Unchanged (still broken) > > To clarify, this will boot but then start to break in very subtle way. Which suggests a need to provide warnings the situation is known to be broken. > > So case 5 is a problem, but cases 2 and 6 are positive. Does the classic > > workaround of "acpi=off" work for Linux as Dom0? If that is "yes", then > > publicizing that workaround (should be detectable by Xen) seems a likely > > short-term solution. > > > > My impression is ACPI is getting increasing support in on ARM. The > > number of mentions suggests if they keep going it looks likely to win. > > The EDK2 project has been providing an image for RPI4 and the > > functionality is impressive. > > AFAIK, the push is drove by Arm Server and Windows on Arm. Does EDK2 on > RPI4 still provide both DT and ACPI? Some time back I had tried enabling that, but it appeared rather broken. Might well be I was using a kernel which didn't match their DT and thus it was quite broken (which is the major advantage of ACPI). > > Ultimately this is more a decision for Xen Project management, than the > > technical side. Are things in shape where they can be rolled out? > > No. But as I wrote before, I don't believe the gap is very big. > > > Is > > ACPI support important enough to need rolling out now? > > > > I'm unsure about the former, but the latter seems a distinct "yes" since > > ACPI appears to be the future. > > ACPI is indeed picking up the pace on Arm Server and platform where > Windows on Arm is supported. But that should not only be the reason to > remove UNSUPPORTED. Well good news is I'm not proposing removing the unsupported marking. I'm proposing to enable ACPI by default. I think it is reasonable to add more warnings at runtime of the setup not being supported. > You are right that enabling ACPI by default will draw more users. But I > also expect those users to be less familiar with Xen and therefore not > very interested to fix bugs. So removing EXPERT/UNSUPPORTED is probably > going to still make them unhappy as I don't think the help (including > writing patch) for ACPI on Arm will change very much in the near future > (from the community call I was under the impression you could not commit > time for it). The average level of technical competence may be lower, but the larger pool of people should yield enough to get additional problems fixed. > So I am not convinced this is really making Xen in a better position > right now. Right now the present situation is *actively* pushing people who want to use Xen on ACPI-only ARM boards away. If virtualization is important for them, they are likely to instead opt for KVM, VMWare, Hyper-V, or Bhyve. Suppressing mindshare will destroy the future of Xen on ARM. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Feb 06 21:23:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 21:23:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490730.759548 (Exim 4.92) (envelope-from ) id 1pP8xX-0002B7-UI; Mon, 06 Feb 2023 21:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490730.759548; Mon, 06 Feb 2023 21:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP8xX-0002B0-Qy; Mon, 06 Feb 2023 21:23:31 +0000 Received: by outflank-mailman (input) for mailman id 490730; Mon, 06 Feb 2023 21:23:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pP8xX-0002Ae-9q for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 21:23:31 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d7a0642-a664-11ed-93b5-47a8fe42b414; Mon, 06 Feb 2023 22:23:27 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C2A0FB81625; Mon, 6 Feb 2023 21:23:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88617C433EF; Mon, 6 Feb 2023 21:23:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d7a0642-a664-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675718603; bh=/L6vScwanHXQkqlWWq3WvENVOhp9UJBsxYcGY9TovNA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kJy22NLlEYDFYl5LC9EYy1W8ZkkJr0WmEg2ATI7r2Z/Jf0EItt01iJtJFb7MW1hY/ Mt0snoE83/ahw55qGIfBmaxbtlIJ+P4NjNSnNxUshowVEwaq0Q9IT9SAFGpA6KtPBn mpg61oCAxOHyL5TslO414HY7jZtdVwy7cKtL59vlC0LXX9jKGiSIOEMhC4p9lZjnC0 SdKngky7TtWlBYCUe1jKB5BHbdjAQEcCeU4SNnv7SIvwgpPa2kWY+pL825RIeU5D2O SraFqFHDognpL9WDNSy4N0LNhnJ808sPPVnaHuLIT3T0HrJ8vikF8FMkNoXP0DpigQ a6drYlCQ6PcKg== Date: Mon, 6 Feb 2023 13:23:21 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , Luca Fancellu , Xen-devel , Andrew Cooper , George Dunlap , Julien Grall Subject: Re: Proposal: List files in Xen originated from external sources In-Reply-To: <53371bbc-ea78-4c2b-a84e-e888ae090d3a@suse.com> Message-ID: References: <53371bbc-ea78-4c2b-a84e-e888ae090d3a@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-268053785-1675718239=:132504" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-268053785-1675718239=:132504 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Mon, 6 Feb 2023, Jan Beulich wrote: > On 03.02.2023 20:55, Stefano Stabellini wrote: > > On Fri, 3 Feb 2023, Luca Fancellu wrote: > >> And then, if the file is not subject to backport and now we “own” the file, there is no more the need to list it > >> in the external file, a commit search can reveal when it was converted to Xen codestyle and removed from > >> the external file list so we don’t lose the history. > > > > Yes, I agree. If a file is coverted to Xen coding style and follows > > MISRA rules, then there is no need to list the file in > > docs/misra/external-files.json. > > > > > >> So we would end up excluding just all the file listed in external-file.json by the analysis. > > > > Right, I think so too > > Personally I think this is too focused on Misra. We are trying to do two things at once: 1) list of external files with their management info (backports, origin, etc.) 2) list of files and paths to exclude from MISRA checking >From this discussion it became clear that 1) and 2) are very different, have different requirements, and different info attached. In fact, the two lists of files and paths don't even match: not all external files exclude MISRA checking and some non-external files also exclude MISRA checking. I suggest we go forward with a MISRA-only exclude list with files and paths to exclude from automatic checking, and without any implication about external files. The list could be a json file called "misra-exclude.json" to avoid any doubts. --8323329-268053785-1675718239=:132504-- From xen-devel-bounces@lists.xenproject.org Mon Feb 06 22:32:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 22:32:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490740.759565 (Exim 4.92) (envelope-from ) id 1pPA2K-0001LI-2w; Mon, 06 Feb 2023 22:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490740.759565; Mon, 06 Feb 2023 22:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPA2J-0001LB-Um; Mon, 06 Feb 2023 22:32:31 +0000 Received: by outflank-mailman (input) for mailman id 490740; Mon, 06 Feb 2023 22:32:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPA2I-0001L5-DQ for xen-devel@lists.xenproject.org; Mon, 06 Feb 2023 22:32:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPA2C-0005Ty-HV; Mon, 06 Feb 2023 22:32:24 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPA2C-0006Qy-Af; Mon, 06 Feb 2023 22:32:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=g2znekQW63nAZ8k2hF8K09p6l4jUYK6Zf2PQwsS7lfc=; b=Jd8wCoUHRyk8dfHuaHAf4NFKN4 gY5fd1cx8IkemMkEsRNhuvKcyvaOGJpjnVXmtjDVIfvaDgroyEQx+auQSiPrG51RDL6rnvf1W0i1Z Nv2k2dQIoda8HRMe5VMA/lDyBsne14OiFgqSy4zbSNv96+t/B/j26hyKNRS4Y2be5vug=; Message-ID: <3b2f49cd-195c-f69b-b5d4-681a7cad58d5@xen.org> Date: Mon, 6 Feb 2023 22:32:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Elliott Mitchell Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> From: Julien Grall Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 06/02/2023 20:30, Elliott Mitchell wrote: > On Mon, Feb 06, 2023 at 05:07:50PM +0000, Julien Grall wrote: >> >> On 06/02/2023 16:09, Elliott Mitchell wrote: >>> On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: >>>> >>>> On 06/02/2023 07:29, Jan Beulich wrote: >>>>> On 22.07.2020 19:43, Elliott Mitchell wrote: >>>>>> Unlike other unsupportted options, ACPI support is required to *boot* >>>>>> for a number of platforms. Users on these platforms are unable to use >>>>>> distribution builds and must rebuild from source to use Xen. >>>>>> >>>>>> Signed-off-by: Elliott Mitchell >>>>> >>>>> A general question first: How come this mail dates back to July 2020? I >>>>> had almost missed it as "new". >>>> >>>> I can't even find the Elliott's email in my inbox so reply here. But >>>> this sounds like a rehash of [1]. >>> >>> The date on Git patches is meant as an indicator for author date. Since >>> this is a cherry-pick of a patch which was written >2 years ago >>> `git format-patch` indicates when it was written. This IS how these >>> systems work. >> >> Hmmm... I am a bit surprised to what you say. I have sent several >> patches in the past with an old author date and they always showed as >> the date sent in my inbox. > > Dunno, but it was straight out of `git format-patch`. I'm not using > `git send-email` though (that requires a setup distinct from what I'm > aiming for). That's probably why. >>>> >> Unlike other unsupportted options, ACPI support is required to *boot* >>>> >> for a number of platforms. Users on these platforms are unable to use >>>> >> distribution builds and must rebuild from source to use Xen. >>>> >>>> What platforms are you testing on? I know that this is working-ish on >>>> RPI4 and QEMU. But this will likely blow up on one of the server we >>>> support in OSSTest because we don't have proper support to hide SMMUs in >>>> dom0. >>> >>> I've been doing RPI4 w/EDK2. Which works for my purpose, the remaining >>> trouble spot for my purpose is needing a final resolution of the EFIFB >>> situation. >> >> I have had no feedback from the relevant person on EFIFB patch and I am >> not planning to purse the work in the near future. > > Okay, thanks for the news. Hopefully efifb on Xen support gets into > kernels closer to the Linux HEAD. > > >>>>>> --- a/xen/arch/arm/Kconfig >>>>>> +++ b/xen/arch/arm/Kconfig >>>>>> @@ -29,13 +29,18 @@ menu "Architecture Features" >>>>>> source "arch/Kconfig" >>>>>> >>>>>> config ACPI >>>>>> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED >>>>>> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" >>>> >>>> The concerns I raised in [1] still stand. Most of the ACPI platform will >>>> also have support for IOMMUs. If we have support for IORT in Xen, then I >>>> would be a lot more amenable to remove the "UNSUPPORTED". And without >>>> that support we are going to do more harm and than good. >>> >>> Okay, this has been a known issue for *years* and yet remains unresolved >>> despite being a major issue. >> >> Right, the situation hasn't changed much since you last sent your patch >> to drop EXPERT/UNSUPPORTED. >> >> Unless you fancy working on ACPI, I don't really see the situation >> changing soon. > > The situation is changing in large entities are pushing ACPI for ARM. If > they succeed (likely) then it will be a case of Xen/ARM MUST support > ACPI, or else the project will die. This is quite a bold statement... I can see this ACPI to overtake in server world where ACPI is sort of the de-facto default firmware table. However, in embedded this is probably going to be more mixed because Device-Tree is a lot simpler to use (think of safety certified environment). >>> Might be an abomination, but would it work >>> to find the string "IORT" and change it to "iort", "RTIO" or "IOXN" to >>> prevent Dom0 from finding it? >> >> Unfortunately no because there IORT is used to describing mapping for >> the GICv3 ITS which is currently working when ACPI is enabled in Xen. > > The original advantage of Xen was paravirtualization. Might this > be a case where it is better to have Domain 0 compensate and know the > SMMU is unusable with current versions of Xen? I believe it would make more difficult to add support for Stage-1 SMMU in dom0. So this would be a short-sighted decision. > >>> This ends up turning into a question of what are the cases and which are >>> more common? >>> >>> Case1: DT-only: Unchanged >>> >>> Case2: Switchable between DT and ACPI, w/o SMMU: Starts working with ACPI >>> >>> Case3: Switchable between DT and ACPI, w/SMMU: Unchanged, ACPI mode still >>> doesn't work, but the failure is different. >>> >>> Case4: Concurrent DT and ACPI support, w/o SMMU: Unchanged >> >> So Xen would start using ACPI rather than DT.I think we should default >> DT it until we have the ACPI support completed. > > Isn't this precisely what the proposed change does? Are you suggesting, > if both DT and ACPI are present, prevent Dom0 from seeing ACPI? In the current model Xen and dom0 have to be using the same kind of firmware table. IOW if Xen is using the Device-Tree then dom0 has to. We never investigated whether it would be feasible for Dom0 to use ACPI but not Xen. > If > you're suggesting doing futher masking, perhaps only if SMMU is present? Even if we remove the dependencies on UNSUPPORTED, ACPI will still be in a unsupported state by Xen Project (at least until the missing feature are present). This means, if both Device-Tree and ACPI are present then we should boot using Device-Tree so the user is using a supported configuration. If they wish to use ACPI, then they will need to pass "acpi=on" on the Xen command line. > >>> Case5: Concurrent DT and ACPI support, w/SMMU: Breaks if Dom0 tries to >>> use ACPI >>> >>> Case6: ACPI-only, w/o SMMU: Starts working out-of-box >>> >>> Case7: ACPI-only, w/SMMU: Unchanged (still broken) >> >> To clarify, this will boot but then start to break in very subtle way. > > Which suggests a need to provide warnings the situation is known to be > broken. Right. If that's the decision, then this would need to be part of this patch (or a new one patch). >>> Ultimately this is more a decision for Xen Project management, than the >>> technical side. Are things in shape where they can be rolled out? >> >> No. But as I wrote before, I don't believe the gap is very big. >> >>> Is >>> ACPI support important enough to need rolling out now? >>> >>> I'm unsure about the former, but the latter seems a distinct "yes" since >>> ACPI appears to be the future. >> >> ACPI is indeed picking up the pace on Arm Server and platform where >> Windows on Arm is supported. But that should not only be the reason to >> remove UNSUPPORTED. > > Well good news is I'm not proposing removing the unsupported marking. > I'm proposing to enable ACPI by default. I think it is reasonable to > add more warnings at runtime of the setup not being supported. From my experience warnings tend to be ignore/forgotten. So this could lead to poorer experience when issues are subbtle (think memory corruption). > >> You are right that enabling ACPI by default will draw more users. But I >> also expect those users to be less familiar with Xen and therefore not >> very interested to fix bugs. So removing EXPERT/UNSUPPORTED is probably >> going to still make them unhappy as I don't think the help (including >> writing patch) for ACPI on Arm will change very much in the near future >> (from the community call I was under the impression you could not commit >> time for it). > > The average level of technical competence may be lower, but the larger > pool of people should yield enough to get additional problems fixed. > >> So I am not convinced this is really making Xen in a better position >> right now. > > Right now the present situation is *actively* pushing people who want to > use Xen on ACPI-only ARM boards away. That's interesting because I haven't encountered that many ACPI-only platform outside of the server world. But, honestly, I think you are blaming a bit too much EXPERT/UNSUPPORTED. Such issue would be really a problem with single contributor. For companies they usually care less and will pick whatever suit them (even it is behind a Kconfig). > If virtualization is important for > them, they are likely to instead opt for KVM, VMWare, Hyper-V, or Bhyve. > Suppressing mindshare will destroy the future of Xen on ARM. Another bold statement? Anyway, I will wait for input from Bertand and Stefano. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 06 23:39:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Feb 2023 23:39:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490748.759582 (Exim 4.92) (envelope-from ) id 1pPB4v-0008Is-Vl; Mon, 06 Feb 2023 23:39:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490748.759582; Mon, 06 Feb 2023 23:39:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPB4v-0008Il-Sp; Mon, 06 Feb 2023 23:39:17 +0000 Received: by outflank-mailman (input) for mailman id 490748; Mon, 06 Feb 2023 23:39:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPB4u-0008Ib-4V; Mon, 06 Feb 2023 23:39:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPB4u-0006ys-1z; Mon, 06 Feb 2023 23:39:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPB4t-0001C6-Lf; Mon, 06 Feb 2023 23:39:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPB4t-0006uP-LC; Mon, 06 Feb 2023 23:39:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KRhyvJ2CHRf5MmL5xi201mVrgXjyMEGqm/YT3eGtntE=; b=qcPJ+zeFzvI8mbIFYRTFShRuk1 4n+At8zSPTx246KRXL/mfao4Nj9RuTD2mZac0DDdBEeE3jKYE/cg8tlixKhyDNEyytGS26M3WgiPJ KEblSG7tGfFPgn52bQJJLUCmvDgXvrTMVyQ+3q0vOd7ZouCd4EkSjLV/Sxo6kI8l0a7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176411: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=d2d11f342b179f1894a901f143ec7c008caba43e X-Osstest-Versions-That: linux=c608f6b58f306ce0e4f459af69a196f5ed6ccf45 From: osstest service owner Date: Mon, 06 Feb 2023 23:39:15 +0000 flight 176411 linux-linus real [real] flight 176430 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176411/ http://logs.test-lab.xenproject.org/osstest/logs/176430/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176430-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176403 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176403 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176403 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176403 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176403 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux d2d11f342b179f1894a901f143ec7c008caba43e baseline version: linux c608f6b58f306ce0e4f459af69a196f5ed6ccf45 Last test of basis 176403 2023-02-05 20:41:31 Z 1 days Testing same since 176411 2023-02-06 05:30:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Geert Uytterhoeven Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c608f6b58f30..d2d11f342b17 d2d11f342b179f1894a901f143ec7c008caba43e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Feb 07 00:10:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 00:10:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490761.759596 (Exim 4.92) (envelope-from ) id 1pPBYj-0004nq-4D; Tue, 07 Feb 2023 00:10:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490761.759596; Tue, 07 Feb 2023 00:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPBYj-0004nD-0l; Tue, 07 Feb 2023 00:10:05 +0000 Received: by outflank-mailman (input) for mailman id 490761; Tue, 07 Feb 2023 00:10:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPBYi-0004Yx-69 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 00:10:04 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c24db898-a67b-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 01:10:01 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3AEE4CE0ACC; Tue, 7 Feb 2023 00:09:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D255C433EF; Tue, 7 Feb 2023 00:09:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c24db898-a67b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675728594; bh=ePu9a/G+QBwUyf7aBR4H9QVI54kwod4y9QZMvCVKXes=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CKTUSbxxaWZOxAmww08e9b9LaC0MUOJ4wXVAPtBA5CzLhQNwaYXGbb3/kBJK3nj/l CQ1MvNhp5dhPxOZCiWjWKVklcDmkhwAfIGDRp+262GjbQx88nxWm3WcfkcOQz+Ln1l WjEbVuqVXaYvpvOqjeZC47Zu3bdoKdlIRUdAmYrm4gkYylAnsimPhaThMbO2UK0WyI +T1hO0pE4zdzurm9k/w4pmsJqUr0m6VM97MIazd8e4s/UUtX4g7yuBhCTi7lR7xSNp w5Y9vQWm99lp44YUOzbbZyYo7BuBm5Ek2erGfr9oTfj4lpdZ5kmaqAU5rUEt5GQv8J M7kJIgZ/5IIfw== Date: Mon, 6 Feb 2023 16:09:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: ehem+xen@m5p.com, george.dunlap@cloud.com cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich , julien@xen.org Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled In-Reply-To: <3b2f49cd-195c-f69b-b5d4-681a7cad58d5@xen.org> Message-ID: References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> <3b2f49cd-195c-f69b-b5d4-681a7cad58d5@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII +George On Mon, 6 Feb 2023, Julien Grall wrote: > On 06/02/2023 20:30, Elliott Mitchell wrote: > > The situation is changing in large entities are pushing ACPI for ARM. If > > they succeed (likely) then it will be a case of Xen/ARM MUST support > > ACPI, or else the project will die. We need to be careful when making wide-reaching marketing statements because: - it is always extremely hard to make accurate prediction of the future - even seasoned experts often make major guessing mistakes Bill Gates predicted that OS/2 would take over the world in '87. Many people on xen-devel might not even know what OS/2 is. I am not aware of any plans by Xilinx (now AMD) to replace Device Tree with ACPI. In fact we are investing in Device Tree with System Device Tree and other related activites (Lopper, etc.) I suggest to keep the discussion technical and practical. As a community, we don't enable experimental/unsupported features by default for obvious reasons. In this case, the feature (ACPI) might give a chance to Xen to boot on a given platform. Do we want to make an exception for ACPI to be enabled by default even if experimental/unsupported? If so, we can look into the details of how to do that. But first, we need a policy decision. Who should be the people making this decision? I'll let George as Community Manager decide if the decision stands with the ARM maintainers or with the committers. From xen-devel-bounces@lists.xenproject.org Tue Feb 07 01:39:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 01:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490770.759610 (Exim 4.92) (envelope-from ) id 1pPCwx-0003sH-JR; Tue, 07 Feb 2023 01:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490770.759610; Tue, 07 Feb 2023 01:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPCwx-0003sA-EF; Tue, 07 Feb 2023 01:39:11 +0000 Received: by outflank-mailman (input) for mailman id 490770; Tue, 07 Feb 2023 01:39:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPCwv-0003s4-Q5 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 01:39:10 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34df7b83-a688-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 02:39:06 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C118C5C0176; Mon, 6 Feb 2023 20:39:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 06 Feb 2023 20:39:04 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 20:39:03 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34df7b83-a688-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1675733944; x= 1675820344; bh=E77I4hzJ5OTSfxMPHbdAio8DoXPAgvCkC3DV+Z4FNik=; b=J yusuLB9XWJz/Qxu6kslR1fuSua7vWyQ54j9P3Rs7PS+T//fXoFg2QxbJ6wwVh40C 1uL50HMkyZaCBf0TxEzcX9Lu/3SvaaWxgYkYctL/MbDIxeJTvGzQZgsrjckiJ/y0 ud3FpVhmnotDLzTsgcBdpHyupVZkaZ0fG98kAGqwjEvZADqR/t2JEWuqo6CI8+oD A/xMPgkl896EmEHc98jCqceAh4v5fvZXjIeaWAg/uvSR2Lxi7LpXqxJ5LFqqJ5zo Pkr8oxlL+1aAhfqv5tlbuY9gSn0aq9gL1XsKU8waxK4GcAOz+kd+2aWYAlztBkWi tICXOBn2XhnTch9l+moSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675733944; x=1675820344; bh=E77I4hzJ5OTSfxMPHbdAio8DoXPAgvCkC3D V+Z4FNik=; b=RPb59f+bXTM7Z6jyL/zagY5/QrAnovigvVvk9mk0IRKWrp09bBt yMWhJW07bQH7IdQrbtvZow4fI2OfEP3gAzthojHEdmwgVEecisfiWxPdECr6Oj89 Lh7OWEA1Dd7S8QEsys5tm2fkugVYFhDYOXwfFGQ+15Vt/hu7A4uT8wy1PYGnNNHK 5XnwEwpYRoMAydK0uf70SJo+tdTt64rQ4s+OxnOyTsORyhNDppVNyK4730a3nqzv 3EKlEd6t7z/9Y5K8V27WZKOW+TFec/rpbYZK05Xo4gIns6W8m4jdVuiK5VCn5ZRA OhAcotsxj4njp1NGwjktiUnavSe7OTbHnnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen: speed up grant-table reclaim Date: Mon, 6 Feb 2023 20:38:56 -0500 Message-Id: <20230207013856.1508-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a grant entry is still in use by the remote domain, Linux must put it on a deferred list. Normally, this list is very short, because the PV network and block protocols expect the backend to unmap the grant first. However, Qubes OS's GUI protocol is subject to the constraints of the X Window System, and as such winds up with the frontend unmapping the window first. As a result, the list can grow very large, resulting in a massive memory leak and eventual VM freeze. Fix this problem by bumping the number of entries that the VM will attempt to free at each iteration to 10000. This is an ugly hack that may well make a denial of service easier, but for Qubes OS that is less bad than the problem Qubes OS users are facing today. There really needs to be a way for a frontend to be notified when the backend has unmapped the grants. Additionally, a module parameter is provided to allow tuning the reclaim speed. The code previously used printk(KERN_DEBUG) whenever it had to defer reclaiming a page because the grant was still mapped. This resulted in a large volume of log messages that bothered users. Use pr_debug instead, which suppresses the messages by default. Developers can enable them using the dynamic debug mechanism. Fixes QubesOS/qubes-issues#7410 (memory leak) Fixes QubesOS/qubes-issues#7359 (excessive logging) --- Anyone have suggestions for improving the grant mechanism? Argo isn't a good option, as in the GUI protocol there are substantial performance wins to be had by using true shared memory. drivers/xen/grant-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 5c83d41..2c2faa7 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -355,14 +355,20 @@ static void gnttab_handle_deferred(struct timer_list *); static DEFINE_TIMER(deferred_timer, gnttab_handle_deferred); +static atomic64_t deferred_count; +static atomic64_t leaked_count; +static unsigned int free_per_iteration = 10000; + static void gnttab_handle_deferred(struct timer_list *unused) { - unsigned int nr = 10; + unsigned int nr = READ_ONCE(free_per_iteration); + const bool ignore_limit = nr == 0; struct deferred_entry *first = NULL; unsigned long flags; + size_t freed = 0; spin_lock_irqsave(&gnttab_list_lock, flags); - while (nr--) { + while ((ignore_limit || nr--) && !list_empty(&deferred_list)) { struct deferred_entry *entry = list_first_entry(&deferred_list, struct deferred_entry, list); @@ -372,10 +378,13 @@ list_del(&entry->list); spin_unlock_irqrestore(&gnttab_list_lock, flags); if (_gnttab_end_foreign_access_ref(entry->ref)) { + uint64_t ret = atomic64_sub_return(1, &deferred_count); put_free_entry(entry->ref); - pr_debug("freeing g.e. %#x (pfn %#lx)\n", - entry->ref, page_to_pfn(entry->page)); + pr_debug("freeing g.e. %#x (pfn %#lx), %llu remaining\n", + entry->ref, page_to_pfn(entry->page), + (unsigned long long)ret); put_page(entry->page); + freed++; kfree(entry); entry = NULL; } else { @@ -387,14 +396,15 @@ spin_lock_irqsave(&gnttab_list_lock, flags); if (entry) list_add_tail(&entry->list, &deferred_list); - else if (list_empty(&deferred_list)) - break; } - if (!list_empty(&deferred_list) && !timer_pending(&deferred_timer)) { + if (list_empty(&deferred_list)) + WARN_ON(atomic64_read(&deferred_count)); + else if (!timer_pending(&deferred_timer)) { deferred_timer.expires = jiffies + HZ; add_timer(&deferred_timer); } spin_unlock_irqrestore(&gnttab_list_lock, flags); + pr_debug("Freed %zu references", freed); } static void gnttab_add_deferred(grant_ref_t ref, struct page *page) @@ -402,7 +412,7 @@ { struct deferred_entry *entry; gfp_t gfp = (in_atomic() || irqs_disabled()) ? GFP_ATOMIC : GFP_KERNEL; - const char *what = KERN_WARNING "leaking"; + uint64_t leaked, deferred; entry = kmalloc(sizeof(*entry), gfp); if (!page) { @@ -426,12 +436,20 @@ add_timer(&deferred_timer); } spin_unlock_irqrestore(&gnttab_list_lock, flags); - what = KERN_DEBUG "deferring"; + deferred = atomic64_add_return(1, &deferred_count); + leaked = atomic64_read(&leaked_count); + pr_debug("deferring g.e. %#x (pfn %#lx) (total deferred %llu, total leaked %llu)\n", + ref, page ? page_to_pfn(page) : -1, deferred, leaked); + } else { + deferred = atomic64_read(&deferred_count); + leaked = atomic64_add_return(1, &leaked_count); + pr_warn("leaking g.e. %#x (pfn %#lx) (total deferred %llu, total leaked %llu)\n", + ref, page ? page_to_pfn(page) : -1, deferred, leaked); } - printk("%s g.e. %#x (pfn %#lx)\n", - what, ref, page ? page_to_pfn(page) : -1); } +module_param(free_per_iteration, uint, 0600); + int gnttab_try_end_foreign_access(grant_ref_t ref) { int ret = _gnttab_end_foreign_access_ref(ref); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Feb 07 01:55:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 01:55:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490777.759620 (Exim 4.92) (envelope-from ) id 1pPDCc-0006S2-Ta; Tue, 07 Feb 2023 01:55:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490777.759620; Tue, 07 Feb 2023 01:55:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPDCc-0006Rv-Q9; Tue, 07 Feb 2023 01:55:22 +0000 Received: by outflank-mailman (input) for mailman id 490777; Tue, 07 Feb 2023 01:55:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPDCb-0006Ro-70 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 01:55:21 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78304262-a68a-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 02:55:18 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 3171stcX050816 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Feb 2023 20:55:01 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 3171stKk050815; Mon, 6 Feb 2023 17:54:55 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78304262-a68a-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 17:54:55 -0800 From: Elliott Mitchell To: Julien Grall Cc: george.dunlap@cloud.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Jan Beulich Subject: Re: [PATCH] xen/arm64: Default ACPI support enabled Message-ID: References: <202302031801.313I1SdK033264@m5p.com> <15b88500-89b0-507a-601c-84a8102bb550@xen.org> <1d685b34-940b-b8ca-e689-b5a42eaccea1@xen.org> <3b2f49cd-195c-f69b-b5d4-681a7cad58d5@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b2f49cd-195c-f69b-b5d4-681a7cad58d5@xen.org> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Mon, Feb 06, 2023 at 10:32:22PM +0000, Julien Grall wrote: > Hi, > > On 06/02/2023 20:30, Elliott Mitchell wrote: > > On Mon, Feb 06, 2023 at 05:07:50PM +0000, Julien Grall wrote: > >> > >> On 06/02/2023 16:09, Elliott Mitchell wrote: > >>> On Mon, Feb 06, 2023 at 10:38:32AM +0000, Julien Grall wrote: > >>>> > >>>> On 06/02/2023 07:29, Jan Beulich wrote: > >>>>> On 22.07.2020 19:43, Elliott Mitchell wrote: > > >>>>>> --- a/xen/arch/arm/Kconfig > >>>>>> +++ b/xen/arch/arm/Kconfig > >>>>>> @@ -29,13 +29,18 @@ menu "Architecture Features" > >>>>>> source "arch/Kconfig" > >>>>>> > >>>>>> config ACPI > >>>>>> - bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED > >>>>>> + bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" > >>>> > >>>> The concerns I raised in [1] still stand. Most of the ACPI platform will > >>>> also have support for IOMMUs. If we have support for IORT in Xen, then I > >>>> would be a lot more amenable to remove the "UNSUPPORTED". And without > >>>> that support we are going to do more harm and than good. > >>> > >>> Okay, this has been a known issue for *years* and yet remains unresolved > >>> despite being a major issue. > >> > >> Right, the situation hasn't changed much since you last sent your patch > >> to drop EXPERT/UNSUPPORTED. > >> > >> Unless you fancy working on ACPI, I don't really see the situation > >> changing soon. > > > > The situation is changing in large entities are pushing ACPI for ARM. If > > they succeed (likely) then it will be a case of Xen/ARM MUST support > > ACPI, or else the project will die. > > This is quite a bold statement... I can see this ACPI to overtake in > server world where ACPI is sort of the de-facto default firmware table. > However, in embedded this is probably going to be more mixed because > Device-Tree is a lot simpler to use (think of safety certified environment). Quite true. Many technologies though tend to slowly flow down from the high-end server market into lower-end desktop and then embedded markets (some do go the opposite direction). Notice the first computers filled rooms, yet now many doorknobs have computers. Hypervisors started on high-end servers, yet now most phones have 95% of the technology. I don't expect to see ACPI inside cars in the next decade, but I suspect it may be common on cellphones and routers soon. > >>> Might be an abomination, but would it work > >>> to find the string "IORT" and change it to "iort", "RTIO" or "IOXN" to > >>> prevent Dom0 from finding it? > >> > >> Unfortunately no because there IORT is used to describing mapping for > >> the GICv3 ITS which is currently working when ACPI is enabled in Xen. > > > > The original advantage of Xen was paravirtualization. Might this > > be a case where it is better to have Domain 0 compensate and know the > > SMMU is unusable with current versions of Xen? > > I believe it would make more difficult to add support for Stage-1 SMMU > in dom0. So this would be a short-sighted decision. Okay. Use a feature bit? Perhaps have something passing "iommu=off" to the Dom0 kernel? > >>> This ends up turning into a question of what are the cases and which are > >>> more common? > >>> > >>> Case1: DT-only: Unchanged > >>> > >>> Case2: Switchable between DT and ACPI, w/o SMMU: Starts working with ACPI > >>> > >>> Case3: Switchable between DT and ACPI, w/SMMU: Unchanged, ACPI mode still > >>> doesn't work, but the failure is different. > >>> > >>> Case4: Concurrent DT and ACPI support, w/o SMMU: Unchanged > >> > >> So Xen would start using ACPI rather than DT.I think we should default > >> DT it until we have the ACPI support completed. > > > > Isn't this precisely what the proposed change does? Are you suggesting, > > if both DT and ACPI are present, prevent Dom0 from seeing ACPI? > > In the current model Xen and dom0 have to be using the same kind of > firmware table. IOW if Xen is using the Device-Tree then dom0 has to. > > We never investigated whether it would be feasible for Dom0 to use ACPI > but not Xen. > > > If > > you're suggesting doing futher masking, perhaps only if SMMU is present? > > Even if we remove the dependencies on UNSUPPORTED, ACPI will still be in > a unsupported state by Xen Project (at least until the missing feature > are present). > > This means, if both Device-Tree and ACPI are present then we should boot > using Device-Tree so the user is using a supported configuration. If > they wish to use ACPI, then they will need to pass "acpi=on" on the Xen > command line. This seems reasonable. > >>> Case5: Concurrent DT and ACPI support, w/SMMU: Breaks if Dom0 tries to > >>> use ACPI > >>> > >>> Case6: ACPI-only, w/o SMMU: Starts working out-of-box > >>> > >>> Case7: ACPI-only, w/SMMU: Unchanged (still broken) > >> > >> To clarify, this will boot but then start to break in very subtle way. > > > > Which suggests a need to provide warnings the situation is known to be > > broken. > > Right. If that's the decision, then this would need to be part of this > patch (or a new one patch). A warning message was part of a previous version. Yet that was rejected and the recent suggestion was to send the bare default enable ACPI by itself. > >>> Ultimately this is more a decision for Xen Project management, than the > >>> technical side. Are things in shape where they can be rolled out? > >> > >> No. But as I wrote before, I don't believe the gap is very big. > >> > >>> Is > >>> ACPI support important enough to need rolling out now? > >>> > >>> I'm unsure about the former, but the latter seems a distinct "yes" since > >>> ACPI appears to be the future. > >> > >> ACPI is indeed picking up the pace on Arm Server and platform where > >> Windows on Arm is supported. But that should not only be the reason to > >> remove UNSUPPORTED. > > > > Well good news is I'm not proposing removing the unsupported marking. > > I'm proposing to enable ACPI by default. I think it is reasonable to > > add more warnings at runtime of the setup not being supported. > From my experience warnings tend to be ignore/forgotten. So this could > lead to poorer experience when issues are subbtle (think memory corruption). True enough. :-( > >> You are right that enabling ACPI by default will draw more users. But I > >> also expect those users to be less familiar with Xen and therefore not > >> very interested to fix bugs. So removing EXPERT/UNSUPPORTED is probably > >> going to still make them unhappy as I don't think the help (including > >> writing patch) for ACPI on Arm will change very much in the near future > >> (from the community call I was under the impression you could not commit > >> time for it). > > > > The average level of technical competence may be lower, but the larger > > pool of people should yield enough to get additional problems fixed. > > >> So I am not convinced this is really making Xen in a better position > >> right now. > > > > Right now the present situation is *actively* pushing people who want to > > use Xen on ACPI-only ARM boards away. > That's interesting because I haven't encountered that many ACPI-only > platform outside of the server world. Perhaps most have been looking up information, finding Xen didn't support ACPI on ARM and quietly disappearing. > But, honestly, I think you are blaming a bit too much > EXPERT/UNSUPPORTED. Such issue would be really a problem with single > contributor. For companies they usually care less and will pick whatever > suit them (even it is behind a Kconfig). Though individuals are valuable since they represent mindshare and mindshare has a distinct influence on the future. On Mon, Feb 06, 2023 at 04:09:51PM -0800, Stefano Stabellini wrote: > +George > > On Mon, 6 Feb 2023, Julien Grall wrote: > > On 06/02/2023 20:30, Elliott Mitchell wrote: > > > The situation is changing in large entities are pushing ACPI for ARM. If > > > they succeed (likely) then it will be a case of Xen/ARM MUST support > > > ACPI, or else the project will die. > > We need to be careful when making wide-reaching marketing statements because: > - it is always extremely hard to make accurate prediction of the future > - even seasoned experts often make major guessing mistakes > > Bill Gates predicted that OS/2 would take over the world in '87. Many > people on xen-devel might not even know what OS/2 is. > > I am not aware of any plans by Xilinx (now AMD) to replace Device Tree > with ACPI. In fact we are investing in Device Tree with System Device > Tree and other related activites (Lopper, etc.) True enough. Though see above about many bits of technology tending to slowly flow from the server room into smaller systems. > I suggest to keep the discussion technical and practical. As a > community, we don't enable experimental/unsupported features by default > for obvious reasons. In this case, the feature (ACPI) might give a > chance to Xen to boot on a given platform. As noted, nested-HVM support is present in default builds of 4.14/x86. > Do we want to make an exception for ACPI to be enabled by default even > if experimental/unsupported? If so, we can look into the details of how > to do that. As noted, this allows Xen to boot on more devices (whereas without it Xen won't boot). So this is what places ACPI support into a different category. Classic approach is a warning message with a delay. Marking as tainted has been suggested. I don't have any additional ideas. > But first, we need a policy decision. Who should be the people making > this decision? I'll let George as Community Manager decide if the > decision stands with the ARM maintainers or with the committers. I think this has gotten into a none of the above category; this is more of a management/community question. Does enabling it provide a better experience by making things simpler for more people? Does enabling it provide a worse experience by something not supported escaping? Management has to make a guess as which is more likely beneficial to the Xen Project's future. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 02:11:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 02:11:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490786.759632 (Exim 4.92) (envelope-from ) id 1pPDRX-0000sS-6J; Tue, 07 Feb 2023 02:10:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490786.759632; Tue, 07 Feb 2023 02:10:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPDRX-0000sL-3L; Tue, 07 Feb 2023 02:10:47 +0000 Received: by outflank-mailman (input) for mailman id 490786; Tue, 07 Feb 2023 02:10:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPDRV-0000sF-5Q for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 02:10:45 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f37da52-a68c-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 03:10:42 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2898B5C0172; Mon, 6 Feb 2023 21:10:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 06 Feb 2023 21:10:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 21:10:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f37da52-a68c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1675735841; x= 1675822241; bh=0/QcbN0ctdlX8hZfS9z2Phx50pOCQWlpB7rg/xsi3T8=; b=g KIMsGmT/w5H9y1dmBcwk3+EuiJVcncOMk+yfPyNXHgrIcp4CDmqk2RFQQy4RJwhB FVtgklsUkVPcUHpc063Zw7r4pKQCr0mDeKglx3SMNE19OXcbccjitm09hHq5aFYe QA0LPGu1N8xInLYh2QLzBj0CVo4eioeTLPVHXbnEElLcrJ1IFMH8Czc/IPmnZkrH cEoSnslw4s4aII+uGqT+wIuHnUhTO8rpJWqnac1eaydxzI67KGQ7sEmWryf0UznS cnCZgyikSbrkOOt71NO0EGTNZnniIs673RSLus88v8A6XnD1fS4ixVJgeRRybNdQ wMQiRa4k8DBuU4cEJN8Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675735841; x=1675822241; bh=0/QcbN0ctdlX8hZfS9z2Phx50pOCQWlpB7r g/xsi3T8=; b=hb2PbVPN3WfbPNLBQ9T4tGr5IrsBE7dbEnpTs8tq9aMNH8NkGVP JY+CW8PDPHWa76W7eElX52MQRkTtijle4Q7tOsCeHQLZgDdZQXu8R2ZHnkBh9pH5 GtkhocApSdYzy2ig8uylwpG41Kj+zTP/Ym7Hb2nvtzxvvyzOmIF/t1I3wesrCvSp GP4McVSIEJJaM44SuiOUdMKfZSmUjlr0WZ/8f98fO1JjmXHBbFdLTrKbuKXtBcKx cTaA/Ck7UoX6QmVeNlSjLycSJq2eYLJdgObIur+bzJCSGPU/dOdgsr7DjfJi1iFM 6mq2T+vgHNxmpAEzaNHXUl9Kq0lERwJN0fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] xen: speed up grant-table reclaim Date: Mon, 6 Feb 2023 21:10:33 -0500 Message-Id: <20230207021033.1797-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a grant entry is still in use by the remote domain, Linux must put it on a deferred list. Normally, this list is very short, because the PV network and block protocols expect the backend to unmap the grant first. However, Qubes OS's GUI protocol is subject to the constraints of the X Window System, and as such winds up with the frontend unmapping the window first. As a result, the list can grow very large, resulting in a massive memory leak and eventual VM freeze. Fix this problem by bumping the number of entries that the VM will attempt to free at each iteration to 10000. This is an ugly hack that may well make a denial of service easier, but for Qubes OS that is less bad than the problem Qubes OS users are facing today. There really needs to be a way for a frontend to be notified when the backend has unmapped the grants. Additionally, a module parameter is provided to allow tuning the reclaim speed. The code previously used printk(KERN_DEBUG) whenever it had to defer reclaiming a page because the grant was still mapped. This resulted in a large volume of log messages that bothered users. Use pr_debug instead, which suppresses the messages by default. Developers can enable them using the dynamic debug mechanism. Fixes: QubesOS/qubes-issues#7410 (memory leak) Fixes: QubesOS/qubes-issues#7359 (excessive logging) Fixes: 569ca5b3f94c ("xen/gnttab: add deferred freeing logic") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour --- Anyone have suggestions for improving the grant mechanism? Argo isn't a good option, as in the GUI protocol there are substantial performance wins to be had by using true shared memory. Resending as I forgot the Signed-off-by on the first submission. Sorry about that. drivers/xen/grant-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c index 5c83d41..2c2faa7 100644 --- a/drivers/xen/grant-table.c +++ b/drivers/xen/grant-table.c @@ -355,14 +355,20 @@ static void gnttab_handle_deferred(struct timer_list *); static DEFINE_TIMER(deferred_timer, gnttab_handle_deferred); +static atomic64_t deferred_count; +static atomic64_t leaked_count; +static unsigned int free_per_iteration = 10000; + static void gnttab_handle_deferred(struct timer_list *unused) { - unsigned int nr = 10; + unsigned int nr = READ_ONCE(free_per_iteration); + const bool ignore_limit = nr == 0; struct deferred_entry *first = NULL; unsigned long flags; + size_t freed = 0; spin_lock_irqsave(&gnttab_list_lock, flags); - while (nr--) { + while ((ignore_limit || nr--) && !list_empty(&deferred_list)) { struct deferred_entry *entry = list_first_entry(&deferred_list, struct deferred_entry, list); @@ -372,10 +378,13 @@ list_del(&entry->list); spin_unlock_irqrestore(&gnttab_list_lock, flags); if (_gnttab_end_foreign_access_ref(entry->ref)) { + uint64_t ret = atomic64_sub_return(1, &deferred_count); put_free_entry(entry->ref); - pr_debug("freeing g.e. %#x (pfn %#lx)\n", - entry->ref, page_to_pfn(entry->page)); + pr_debug("freeing g.e. %#x (pfn %#lx), %llu remaining\n", + entry->ref, page_to_pfn(entry->page), + (unsigned long long)ret); put_page(entry->page); + freed++; kfree(entry); entry = NULL; } else { @@ -387,14 +396,15 @@ spin_lock_irqsave(&gnttab_list_lock, flags); if (entry) list_add_tail(&entry->list, &deferred_list); - else if (list_empty(&deferred_list)) - break; } - if (!list_empty(&deferred_list) && !timer_pending(&deferred_timer)) { + if (list_empty(&deferred_list)) + WARN_ON(atomic64_read(&deferred_count)); + else if (!timer_pending(&deferred_timer)) { deferred_timer.expires = jiffies + HZ; add_timer(&deferred_timer); } spin_unlock_irqrestore(&gnttab_list_lock, flags); + pr_debug("Freed %zu references", freed); } static void gnttab_add_deferred(grant_ref_t ref, struct page *page) @@ -402,7 +412,7 @@ { struct deferred_entry *entry; gfp_t gfp = (in_atomic() || irqs_disabled()) ? GFP_ATOMIC : GFP_KERNEL; - const char *what = KERN_WARNING "leaking"; + uint64_t leaked, deferred; entry = kmalloc(sizeof(*entry), gfp); if (!page) { @@ -426,12 +436,20 @@ add_timer(&deferred_timer); } spin_unlock_irqrestore(&gnttab_list_lock, flags); - what = KERN_DEBUG "deferring"; + deferred = atomic64_add_return(1, &deferred_count); + leaked = atomic64_read(&leaked_count); + pr_debug("deferring g.e. %#x (pfn %#lx) (total deferred %llu, total leaked %llu)\n", + ref, page ? page_to_pfn(page) : -1, deferred, leaked); + } else { + deferred = atomic64_read(&deferred_count); + leaked = atomic64_add_return(1, &leaked_count); + pr_warn("leaking g.e. %#x (pfn %#lx) (total deferred %llu, total leaked %llu)\n", + ref, page ? page_to_pfn(page) : -1, deferred, leaked); } - printk("%s g.e. %#x (pfn %#lx)\n", - what, ref, page ? page_to_pfn(page) : -1); } +module_param(free_per_iteration, uint, 0600); + int gnttab_try_end_foreign_access(grant_ref_t ref) { int ret = _gnttab_end_foreign_access_ref(ref); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Feb 07 03:11:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 03:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490798.759648 (Exim 4.92) (envelope-from ) id 1pPEOC-0007b7-N5; Tue, 07 Feb 2023 03:11:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490798.759648; Tue, 07 Feb 2023 03:11:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEOC-0007b0-KC; Tue, 07 Feb 2023 03:11:24 +0000 Received: by outflank-mailman (input) for mailman id 490798; Tue, 07 Feb 2023 03:11:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEOA-0007au-UY for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 03:11:23 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 156e8f3e-a695-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 04:11:17 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 798D95C00E3; Mon, 6 Feb 2023 22:11:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 06 Feb 2023 22:11:15 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 22:11:13 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 156e8f3e-a695-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1675739475; x= 1675825875; bh=YzwotlKDm6EYuoAYh/dxRDIrWRC+9rhY3acqxK9reeI=; b=S zGz+GZRdZ7y1/isF5Za2SgRv88gm70n7InL65f29WjxMPMqPyKb89m6BQlFm3gRe hFjI6oMvnidsryzJwt+XaicxbL7y7A0OJKRIkRKHzgzA/p4HEOm+6rjCqpoJD195 NAaVlvIeo/7w6rLYk+neKQHNTJPRp0WwkeaImyNccEfG66RhRpb6bv3FFPAhu6KH wJ4OYDXoD5YPBcsUSFEnfz7ujFKglm2FXVSaUEaFwUu/R61CiuJzqFjAYmpqt6J8 sD+LVL/O1GfINN1lQ7Vf18CKcxj4jFX5USV6dme6cOLK4NqceLEf6QdkUaMaUNfA WlCBRbDEpkMI34c0415Lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675739475; x=1675825875; bh=YzwotlKDm6EYuoAYh/dxRDIrWRC+9rhY3ac qxK9reeI=; b=jWNWW+WOK7QaiNf2vY4VgCS9OsUmjWHc+IxGeHyQnvvC1cwd1P0 M9AJr8QwC+HFBAFWLXrobshVKhcbdefBRStx2EW7OX26upX/jO3u7JsnBo8J6jA3 IAvdKcN0U1lJHNrlghupnB46oFKMrAzFI2KOtYhlz4sOByUd6Z8SbHbmt0BQo77a /Tw+zdLfe8SVQzEFL3CLDAhlbaGne2pE/0WU07jPtZw+6LyAA9wB/D0OyalwJTZl +EPihuWWz/i+PUwHBInXYGulglS3sh5tJaGTwhTkXbTWMOFsL6CrdWLUmO/y122O TXnraPDCXSiq618ajKh17aHx0qU27dWJ0eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepleejtedukeekvddtudeitdfftedvuddt vedtgfetjeeiteffkefhkeevvdfhtefgnecuffhomhgrihhnpeigvghnrdhorhhgpdhphi hthhhonhdrohhrghdpihhnthgvlhdrtghomhdptggvnhhtohhsrdhorhhgpdhllhhvmhdr ohhrghdpuggvsghirghnrdhorhhgpdgrlhhpihhnvghlihhnuhigrdhorhhgpdhslhhofi hglhgrshhsrdgtohhmpdhsphhhihhngidqughotgdrohhrghdpiihlihgsrdhnvghtpdhk vghrnhgvlhdrohhrghdprhgvughhrghtrdgtohhmpdhgnhhurdhorhhgpdhinhhrihgrrd hfrhdpghhmphhlihgsrdhorhhgpdhpohhlrghrshhslhdrohhrghdpsggvrhhlihhoshdr uggvpdhiphigvgdrohhrghdpvghthhgvrhgsohhothdrohhrghdpphgtihhsihhgrdgtoh hmpdhmihgtrhhoshhofhhtrdgtohhmpdgumhhtfhdrohhrghenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvg hthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH] Replace git:// and http:// with https:// Date: Mon, 6 Feb 2023 22:10:33 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch was created by doing a tree-wide search and replace with sed, then reverting changes that were pointless or wrong. Signed-off-by: Demi Marie Obenour --- Config.mk | 20 ++++++-------------- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/README.remus | 2 +- docs/conf.py | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++++--------- stubdom/configure.ac | 18 +++++++++--------- stubdom/grub.patches/10graphics.diff | 2 +- tools/examples/xeninfo.pl | 2 +- tools/firmware/etherboot/Makefile | 4 ++-- tools/firmware/etherboot/README | 2 +- tools/firmware/hvmloader/pci_regs.h | 2 +- tools/firmware/hvmloader/pir.c | 2 +- tools/firmware/hvmloader/pir_types.h | 2 +- tools/firmware/hvmloader/smbios_types.h | 2 +- 19 files changed, 47 insertions(+), 55 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..fd0719e38be1c679946c4d677c0f0dbdb2a85411 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo index 4da27faeb5fa863fd4e140cbeaad308b9a543b86..8e37da1a03f839c486eb9bd0af46716cfb9086e0 100644 --- a/automation/build/centos/CentOS-7.2.repo +++ b/automation/build/centos/CentOS-7.2.repo @@ -6,28 +6,28 @@ [base] name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #released updates [updates] name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/updates/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that may be useful [extras] name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/extras/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that extend functionality of existing packages [centosplus] name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/centosplus/$basearch/ gpgcheck=1 gpgcheck=1 enabled=0 diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list index dc119fa0b4df1bd6e742c42776710abcd6deaa86..1db1598997429d7a14d3fcd8f0f8152aa6d40b8a 100644 --- a/automation/build/debian/unstable-llvm-8.list +++ b/automation/build/debian/unstable-llvm-8.list @@ -1,3 +1,3 @@ # Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb https://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb-src https://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..22ec2f2474ed3d1f1f614085f9bd832be4d42496 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz diff --git a/docs/README.remus b/docs/README.remus index e41e045a109466213b39bf5099ee16652b229ccc..5e411addb1a63f1b2c01ff165fc6f74d6d81c8ea 100644 --- a/docs/README.remus +++ b/docs/README.remus @@ -7,7 +7,7 @@ Using Remus with libxl on Xen 4.5 and higher: To enable network buffering, you need libnl 3.2.8 or higher along with the development headers and command line utilities. If your distro does not have the appropriate libnl3 version, you can find - the latest source tarball of libnl3 at http://www.carisma.slowglass.com/~tgr/libnl/ + the latest source tarball of libnl3 at https://www.carisma.slowglass.com/~tgr/libnl/ Disk replication: VMs protected by Remus need to use DRBD based disk backends. Specifically, you diff --git a/docs/conf.py b/docs/conf.py index 50e41501db8f95bd186818c49a8e6538d733012b..7f4adce29e57e4ab8be9a09fc105bb133c51dbb0 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -5,7 +5,7 @@ # # This file does only contain a selection of the most common options. For a # full list see the documentation: -# http://www.sphinx-doc.org/en/master/config +# https://www.sphinx-doc.org/en/master/config # -- Path setup -------------------------------------------------------------- diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..9f32e0e0c0ec5c491209d6e73232b5a388b0a588 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/xen.git\n"); $printed_novcs = 1; } return 0; diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..92d0e7f74f5f9d28460d33ea012daffaaf8d6759 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : ZLIB_URL=\$\(XEN_EXTFILES_URL\) else - ZLIB_URL="http://www.zlib.net" + ZLIB_URL="https://www.zlib.net" fi fi @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://www.kernel.org/pub/software/utils/pciutils" fi fi @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sources.redhat.com/pub/newlib" fi fi @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3607,7 +3607,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://ftp.gmplib.org/pub/gmp-4.3.2" fi fi @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" = "x"; then : if test "x$extfiles" = "xy"; then : POLARSSL_URL=\$\(XEN_EXTFILES_URL\) else - POLARSSL_URL="http://polarssl.org/code/releases" + POLARSSL_URL="https://polarssl.org/code/releases" fi fi @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" = "x"; then : if test "x$extfiles" = "xy"; then : TPMEMU_URL=\$\(XEN_EXTFILES_URL\) else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" + TPMEMU_URL="https://download.berlios.de/tpm-emulator" fi fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..846d1dbe66df86c5f19924670f0a296bfacdddb4 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,15 +55,15 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://www.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sources.redhat.com/pub/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://ftp.gmplib.org/pub/gmp-4.3.2]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/code/releases]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://download.berlios.de/tpm-emulator]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) diff --git a/stubdom/grub.patches/10graphics.diff b/stubdom/grub.patches/10graphics.diff index 5ee2852fd7d7595c7fe17acbb6096ae96f04aaf4..e80aab75bd31ac677ab2884718673094d97b3df2 100644 --- a/stubdom/grub.patches/10graphics.diff +++ b/stubdom/grub.patches/10graphics.diff @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c grub-0.97/stage2/graphics.c + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program; If not, see ++ * along with this program; If not, see + */ + +#ifdef SUPPORT_GRAPHICS diff --git a/tools/examples/xeninfo.pl b/tools/examples/xeninfo.pl index 95a15d9595c0f4bf09c9429099bd3b27e98ebf3e..1815d1d9f219799a83fbc0329a4a1a010264893e 100644 --- a/tools/examples/xeninfo.pl +++ b/tools/examples/xeninfo.pl @@ -36,7 +36,7 @@ sub apiconnect { foreach my $xenhost (keys %xenhosts) { - my $xen = RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}"); + my $xen = RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}"); my $session = $xen->simple_request("session.login_with_password", "user",""); if (! $session) { diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..b6d420786c3d0895e2118ce789ebdff585268f96 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -5,9 +5,9 @@ include $(XEN_ROOT)/tools/Rules.mk include Config ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git endif # put an updated tar.gz on xenbits after changes to this variable diff --git a/tools/firmware/etherboot/README b/tools/firmware/etherboot/README index 5e3c1daf588fb33bc82238b818ba6aef5c8062e5..4ea8891478ef7973af97538c9733d4ce1506005f 100644 --- a/tools/firmware/etherboot/README +++ b/tools/firmware/etherboot/README @@ -13,7 +13,7 @@ Since gPXE upstream do not appear to distribute tarballs, we generated one ourselves with the following runes (to extract the tree as on 25th September 2008): - git clone git://git.etherboot.org/scm/gpxe.git + git clone https://git.etherboot.org/scm/gpxe.git cd gpxe git archive --format=tar --prefix=gpxe/ c24bc349ead939d90b5784dbff3cd9fdb9d83ba8 | gzip -n >../gpxe-git-snapshot.tar.gz diff --git a/tools/firmware/hvmloader/pci_regs.h b/tools/firmware/hvmloader/pci_regs.h index 7bf2d873ab644c5d342a7e4112a94814e62ce71c..4b093308f6af346afed7cf55c764fd46560bc700 100644 --- a/tools/firmware/hvmloader/pci_regs.h +++ b/tools/firmware/hvmloader/pci_regs.h @@ -6,7 +6,7 @@ * Copyright 1997--1999 Martin Mares * * For more information, please consult the following manuals (look at - * http://www.pcisig.com/ for how to get them): + * https://www.pcisig.com/ for how to get them): * * PCI BIOS Specification * PCI Local Bus Specification diff --git a/tools/firmware/hvmloader/pir.c b/tools/firmware/hvmloader/pir.c index cc420ddff48d0c4f748552fbddc106930796b903..369b4f9b903f961bf79ee2015384187084e40d1e 100644 --- a/tools/firmware/hvmloader/pir.c +++ b/tools/firmware/hvmloader/pir.c @@ -19,7 +19,7 @@ /* * The structure of these tables is described in - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ unsigned long create_pir_tables(void) { diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h index 9f9259c2e144420d4cb1db190a7af447283624ad..5129b0c7fd9a087810a299ee8930f755814a263b 100644 --- a/tools/firmware/hvmloader/pir_types.h +++ b/tools/firmware/hvmloader/pir_types.h @@ -17,7 +17,7 @@ * Copyright (C) Citrix Systems, 2011 * * See the PCI Interrupt Routing spec for more detail: - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ #ifndef PIR_TYPES_H diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h index 7c648ece71698af003f1600a150b1b77fe880254..3f1c120da60b6aa95cb2b6b1f03cc31d912832a4 100644 --- a/tools/firmware/hvmloader/smbios_types.h +++ b/tools/firmware/hvmloader/smbios_types.h @@ -19,7 +19,7 @@ * Authors: Andrew D. Ball * * See the SMBIOS 2.4 spec for more detail: - * http://www.dmtf.org/standards/smbios/ + * https://www.dmtf.org/standards/smbios/ */ #ifndef SMBIOS_TYPES_H -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Tue Feb 07 03:27:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 03:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490806.759660 (Exim 4.92) (envelope-from ) id 1pPEdz-0000xh-30; Tue, 07 Feb 2023 03:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490806.759660; Tue, 07 Feb 2023 03:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEdz-0000xa-06; Tue, 07 Feb 2023 03:27:43 +0000 Received: by outflank-mailman (input) for mailman id 490806; Tue, 07 Feb 2023 03:27:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEdx-0000xS-N4 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 03:27:41 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f28911c-a697-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 04:27:39 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 3173R6tH051115 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Feb 2023 22:27:11 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 3173R5pB051114; Mon, 6 Feb 2023 19:27:05 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f28911c-a697-11ed-93b5-47a8fe42b414 Date: Mon, 6 Feb 2023 19:27:05 -0800 From: Elliott Mitchell To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= Subject: Re: [PATCH] Replace git:// and http:// with https:// Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Mon, Feb 06, 2023 at 10:10:33PM -0500, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. I completely agree with the premise, but I would suggest the better approach to removing use of git:// is to instead require signing of commits. I'm also under the impression git can use TLS, though I'm unsure whether gits:// works (and what revision of git is required). -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 03:29:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 03:29:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490814.759671 (Exim 4.92) (envelope-from ) id 1pPEgA-0001YT-FS; Tue, 07 Feb 2023 03:29:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490814.759671; Tue, 07 Feb 2023 03:29:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEgA-0001YM-Cd; Tue, 07 Feb 2023 03:29:58 +0000 Received: by outflank-mailman (input) for mailman id 490814; Tue, 07 Feb 2023 03:29:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEg8-0001Y7-DF; Tue, 07 Feb 2023 03:29:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEg8-00039c-9J; Tue, 07 Feb 2023 03:29:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEg7-0000iM-WD; Tue, 07 Feb 2023 03:29:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPEg7-0007yE-Vk; Tue, 07 Feb 2023 03:29:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AeGrZZdO+0+i2rEZU0xwRLvvYB6Foz/27AmQ6L2Obl4=; b=HJ4glET00AhrU8bsltQCef5y6Z AnSBhOXwGeWY7Mkf4QkO3byO8DCAeZgIrbt0Ih4nmjQqDocgRAKUNOn1k5BPIi1gPSroBVxw+f8ws +jFN7/dwXY/wienJGc36SI6/6mJxrTo6Ep8rPHS3qjMKaQcbWyADEHm5INDEAzT4lArU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176413: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Tue, 07 Feb 2023 03:29:55 +0000 flight 176413 linux-5.4 real [real] flight 176435 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176413/ http://logs.test-lab.xenproject.org/osstest/logs/176435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 176106 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 176106 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 176090 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 13 days Testing same since 176413 2023-02-06 07:13:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4165 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 07 03:35:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 03:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490825.759681 (Exim 4.92) (envelope-from ) id 1pPElA-00034Y-5s; Tue, 07 Feb 2023 03:35:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490825.759681; Tue, 07 Feb 2023 03:35:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPElA-00034Q-3F; Tue, 07 Feb 2023 03:35:08 +0000 Received: by outflank-mailman (input) for mailman id 490825; Tue, 07 Feb 2023 03:35:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPEl8-00034I-BP for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 03:35:06 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67e94709-a698-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 04:35:04 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 652CA5C013A; Mon, 6 Feb 2023 22:35:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 06 Feb 2023 22:35:02 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 22:35:00 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67e94709-a698-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675740902; x= 1675827302; bh=YARagWVFzU6m/TyGyOyBiivedx2s/TAdmuAhqEgAIeE=; b=L IBFjdIkUOUicwAweFVQm6V7quANljBk/Ftwc1QgtnrIizT4fK1UeULF6/AXv8gGe kGce0I/eK8YUsozG9XBDiKW3mWQ9upE6/TltSZjRzTya8giVWIy0Ng7etstAifWl Iizkj/Gn+tnCh8Y0qzA6OLjOoZtaUW1Bne0NwWLRNl75DnmzW17pS8U+gWw+Icmf 5Rnb97NHJbg4ryZoLBxiSwCvqisNEmg95SvChb69CiQovDz8J/6kBHYoRLJD4RM/ hsZ9lRFFwE8kriEBJUmT8vaqMiSrtQzAoz/CRs5oeRofnqcdkNuOjXNU0UT4nb2A T7btvODBn4aIbdefY5b+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675740902; x=1675827302; bh=YARagWVFzU6m/TyGyOyBiivedx2s /TAdmuAhqEgAIeE=; b=ligvz5dhd/XKuRx3waDQJfDQOwepPJwK9bcr7hAxNJ15 XIv2Zex5+PfQXM/91rMKFYz2dQcz/qxGNI5uYqBUTINQPIljdBpYK0J+WFNmEez+ Oht5hm9jQGAlEP0sY+FKeuDJwwlQa66T0Um63FLNIm9vrvKCxXkiXGqa8QcRQHMo 6T29n9d6v6MOfdmyKLGzgFq4TVs4rW1F2qbB8Yb6Ad8rl3eQfQSYgsRyWh+4VI7N hE+ywqCyjbyV/wWZvjOx0eOorzARLCGjA0AGBX1vzRL148ThDhm6Ge6cwsrRsLB/ bKTAiqckqSN35XFoVRRUitLH1Bn7usv7U6qoNa0DOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 6 Feb 2023 22:34:55 -0500 From: Demi Marie Obenour To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH] Replace git:// and http:// with https:// Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w8Nifwht2W675Aj3" Content-Disposition: inline In-Reply-To: --w8Nifwht2W675Aj3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 6 Feb 2023 22:34:55 -0500 From: Demi Marie Obenour To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Subject: Re: [PATCH] Replace git:// and http:// with https:// On Mon, Feb 06, 2023 at 07:27:05PM -0800, Elliott Mitchell wrote: > On Mon, Feb 06, 2023 at 10:10:33PM -0500, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. >=20 > I completely agree with the premise, but I would suggest the better > approach to removing use of git:// is to instead require signing of > commits. I fully support requiring commit signing, but I don=E2=80=99t consider comm= it signing to be a replacement for transport encryption. I also strongly recommend using SSH, not GPG, for commit signing: it is vastly easier to use and the attack surface is much, much smaller. > I'm also under the impression git can use TLS, though I'm > unsure whether gits:// works (and what revision of git is required). git uses TLS via HTTPS. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --w8Nifwht2W675Aj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPhxuIACgkQsoi1X/+c IsHdTxAA3ymYrjj9pvU67Gqp6swv/MgRdqI0D3lMfc+HLORwqS84H2CRxBSZaZ84 poNfq7fHgcdukt0KS6UHEPFUweNleHu2EeGP66djaacZrZBYalmkni8ixYRgC/o4 tyCo/qv4PtQ50Acwkp09plwjmf3rq768BjpYhlx3TO40YnMCObJ19qNMtOrHRc6Z qcDxh01g9ON6Cgd3Qmpy2Hcr0gR4v9Rc3jFdlqdrPoNT7gfyVS4KZJS/i+3t3m5K /CC/ZkWmR/CNwNxKskDTLXwvDZn/DHiyapL0dNxEFA2J0FeDzRpP4O+pLM/cfKA5 o9EPbunxWr/6nPKsRvaFtB5chjHqvQ4XY+lJav83a5neF+nnfEY3IV6Xb8kr3+V9 JwEdG0cyDBrTrJ5PAbHE1lPHcZlmBDoXdyzzma2TZ7shfa+Azioa6S3TfZvdTKz+ bUYFiZUEuYoiOQI0IIjyJnnZzdvci/+AtLNb8u25f2pLcS8W1DfqgW2fGB65QTHx aXH96dpMv0XoN6ZZkigReOAttYxhBDVUScAbaj1uTqyGjcpqicPGRSFKI/do9RH8 Vz4fTrQtQvht/wj1XezJzObrKCGw+6kc6iKRbJJ3aRkxn6PJ/2gmpESNAtfEYuuk 4OhVI/OBosHUwwwYQlP8xuREPJMuXDm6qLK31jFRAIXIeLtjckQ= =PlQa -----END PGP SIGNATURE----- --w8Nifwht2W675Aj3-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 04:00:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 04:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490834.759696 (Exim 4.92) (envelope-from ) id 1pPF9L-0006nA-6z; Tue, 07 Feb 2023 04:00:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490834.759696; Tue, 07 Feb 2023 04:00:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPF9L-0006n3-3k; Tue, 07 Feb 2023 04:00:07 +0000 Received: by outflank-mailman (input) for mailman id 490834; Tue, 07 Feb 2023 04:00:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPF9J-0006dp-IF for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 04:00:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7d00::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3d8418a-a69b-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 05:00:00 +0100 (CET) Received: from AM5PR0301CA0036.eurprd03.prod.outlook.com (2603:10a6:206:14::49) by VE1PR08MB5568.eurprd08.prod.outlook.com (2603:10a6:800:1a8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 03:59:50 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::16) by AM5PR0301CA0036.outlook.office365.com (2603:10a6:206:14::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 03:59:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 03:59:49 +0000 Received: ("Tessian outbound 0d7b2ab0f13d:v132"); Tue, 07 Feb 2023 03:59:49 +0000 Received: from 9943d359d7af.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7CBB64AE-74FE-4F7E-A432-07FAB8CCB7A2.1; Tue, 07 Feb 2023 03:59:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9943d359d7af.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Feb 2023 03:59:39 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by DBBPR08MB6235.eurprd08.prod.outlook.com (2603:10a6:10:201::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 03:59:35 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Tue, 7 Feb 2023 03:59:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3d8418a-a69b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vzc5y7p+/o0K9CTVJPDl+kbHvQnHxemFHQRdWA+ht1U=; b=qjGjk1wb4sQvsxJerN6ozREzxvMBUPBccsX1PUb9Co1GZlGybORHRPLmolKgc9bWD06/VsIplQ1Msu+uxquty9U/V+/7LVJOKALVrByLpcOR0/6cPP72C/YfiFAKBKB+weieQS8CkdxhkZd9lDfqbuAT+s38KCWINFaIvJBC7qQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z3Ao80oD+nwDJBgL/uxtRfnIwVUTrC7MqeDxNcgq3kqp6nHorJapG8SIcp62v8m/PabRuKJ69UMbpsvimN9h4Mn0zR90xrDTrvW5fOFV8msyzWuMt7Z6tZhb7ZBR+g2iy1geoFYAlKg0pHrnGf064Ule19ChvBqo98tPyTl5fB9IusbTt1hBmg4CjTO8Kdgrp3Icg4s3OoFAodT10+7MgEn2ebqTVPOwDXPyp8ge+vSL3Jy8/EDPIQ8LBYPkcjLOXkySuQ7fCGkEvveNpUlqMvaCSaOfNuP65BrOH+IzSMNgPYu0c2zredc7krL9rVzdLci2Ztf2C3vRMKpKK164Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vzc5y7p+/o0K9CTVJPDl+kbHvQnHxemFHQRdWA+ht1U=; b=njyvZrD8KE7QXs9NuEZc2XPZx6NgOXS12XduI9rv+iKf8AMdCLZfhVIAYurDVR9btGAq2x6IYjktymPzjjqcuMtNPLpn2sIn5UyOVOzKD/q/9iZnF9PqPDpTOsCe1qQ4iMCwMedVkHrYuh8qfLjUgtGCQYE4C/5A653QbT1F3GcyvmNzRpl6vHVii17s+PNe/oeny2EU9tjfc4B0/iXLZwFFowIEAluQgg0SRyDlYINyYcWs4uJjyK543pIBEWsKi4Iryv9xecKnTDjjT+M1Dw7DEraJR0c2UNA2mTYxF9L8adJvt59kXAsIkmEox6mPjmEBlDYtgGHcxLVSqMZ2IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vzc5y7p+/o0K9CTVJPDl+kbHvQnHxemFHQRdWA+ht1U=; b=qjGjk1wb4sQvsxJerN6ozREzxvMBUPBccsX1PUb9Co1GZlGybORHRPLmolKgc9bWD06/VsIplQ1Msu+uxquty9U/V+/7LVJOKALVrByLpcOR0/6cPP72C/YfiFAKBKB+weieQS8CkdxhkZd9lDfqbuAT+s38KCWINFaIvJBC7qQ= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 15/40] xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h Thread-Topic: [PATCH v2 15/40] xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h Thread-Index: AQHZJxApcmRevH68lE+WQ8biO49P9K7BA/mAgAH2IVA= Date: Tue, 7 Feb 2023 03:59:34 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-16-Penny.Zheng@arm.com> <6aebebad-2b01-4bd6-8a2f-7be3591382d8@xen.org> In-Reply-To: <6aebebad-2b01-4bd6-8a2f-7be3591382d8@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A54E8E911FDAAC4EA5E0FC13BDB08445.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|DBBPR08MB6235:EE_|AM7EUR03FT046:EE_|VE1PR08MB5568:EE_ X-MS-Office365-Filtering-Correlation-Id: 1401b7e0-b84a-486d-4df9-08db08bfc276 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lMW+hd28QzeYmMWEXLANKaDmjsINXO28SrVplQ80thaBL2JupEjI45puTveIjZHK4A2TJokjStwYBfn66PgRpLtkQtKk2HGU7HCptDSRzKp4IPCuFco+1aRXM7s8T+bMQu9NEe6VD3zR6FZhk0jHWotiLdg+2RSjs4/EkIdEwQL2uH1oaOG4vFDUEvpbAIGeqwyaz8mzGWjBDnKId6f0lAgloHXZCYwK6bPyqgYuV3Dmpht3xSGQXKvxRMiT6tV19TWqJcuMSxDXSnNyJc7zXY6aDlT+oUi/O0Ktk7NEERCjuSwXwthPtkPT4costAPuPEqb9ICFE1sKp88BTTxg9ttFQ85W93HFHXOMW7jgWrB7xZk2FIb2Wv0znRjtHQnhKAYtEtGHLUlDO+d1HtYnOF6fkMw6OiHs372PC3UF4hQMSt4vqxI8In7G8C2j1D9X0gA3CrGd/wp6jUFqz04yviH3sFkN0KzVlenumKQRN7+tj1VcJacI7kSekZ0M5qKsSSyVNBDtJ9heBjZ6XXLwRDzDybPSTGmGt8/MqKX8DojJTyfyAz+P8SEdJ8IZt7eXmfcHU8VkLpBVQp9Q1rC53cXR2riy/BNerbBAO7KW/MWu2z40Gwba17NARdBNrIwaY7MLht8AstCAVr8F8PkAJI+B4WwmE9nw9HBK7IQGYQ3jp2mamclWs4LHrw9Dd68ALsNe35IRE3CfmgMtHnhG4/Og1/LpyU9Yw1M28LL8WzBbjiuPIW6DLyVAydE9sqd17IPR1W8ilUZwMklLhnBTBA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199018)(76116006)(316002)(110136005)(83380400001)(54906003)(52536014)(66476007)(5660300002)(8936002)(66946007)(8676002)(64756008)(66446008)(66556008)(41300700001)(4326008)(478600001)(6506007)(9686003)(53546011)(26005)(186003)(7696005)(966005)(71200400001)(38070700005)(55016003)(33656002)(2906002)(38100700002)(122000001)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6235 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57417aaa-c42c-4bc3-c4f5-08db08bfb92a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bZsCUKNr1Wnp6FWGiSihHJGhXOHodT2AzMz98zLsXhr0paQM8SWeDTx7Mj833Q2jjCYZFbJ0xN18nL6sDhjP8n0T5XjLyyw77sL8AlQWcdfoVn5i0jhpDCr5FLho8n71lR9sAzcxL0A8Zn9YW+xwl4F0x9FNX26ilQOwc77PNk6nTZ6xAp9EVIgYyp9wpnfsjV174mzojjf0Ev/MpGjRMYb2W583SlztTI90uM3CXcnaejwOBdas8wApkXxQ9q3ZRNfVLAM7DB+5ss2XJv96H1uepVTTPS4Vk/5Tx41BjjBK7E4pGpcDaSthXKk0SCZlngRxXno6nmZsrGfuWr81OaJYSNkn2df5aFAAl/W/sKkFGPnZ8F978a4lixitIp7zk5K7eFevaQ3WFYYy/Ilc/lbBDBEWqrLUrO/s/DhmJxHgfegcwevAr0pehru+fnvp+1h9U0a3A3+lPAlYfKzcq6Y4Shu++Orbg3HXf2WIlAdEXHcpWme3bZl8xyRi/6pnXa7v/qtcFn2MWv184F7Boc59kgHK2rAnJ/d2DsfVMeZonS+5Mk0kib8dJF9o7hWqWj+ybqHiMbb/pQCtGaPkROQDge/Chfg8MGxlHxpFt2qzG2djJRMycu/uklfunYObmhmPMrjCemnhkLL65xdqRRColrocmWFdr9U/TmEwdfjPqPicaX2wGb4df4mE0MazJlO0q5nhb8VZe3dDifFWQ8/B+M3Qi+T4JR/Td8fJiOqP+TKUWrWmaWmkdlVK76+aHCB8QFt3jwzHM0Q5n3IqcQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199018)(40470700004)(36840700001)(46966006)(70206006)(110136005)(4326008)(8676002)(316002)(8936002)(70586007)(6506007)(41300700001)(5660300002)(52536014)(356005)(81166007)(33656002)(36860700001)(86362001)(82740400003)(54906003)(53546011)(186003)(7696005)(26005)(107886003)(9686003)(2906002)(336012)(47076005)(82310400005)(55016003)(40480700001)(40460700003)(966005)(478600001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 03:59:49.6584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1401b7e0-b84a-486d-4df9-08db08bfc276 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5568 SGksDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVuIEdyYWxs IDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBGZWJydWFyeSA2LCAyMDIzIDU6MzAg QU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT47IFN0 ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kIE1h cnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxW b2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxNS80 MF0geGVuL2FybTogbW92ZSBNTVUtc3BlY2lmaWMgbWVtb3J5DQo+IG1hbmFnZW1lbnQgY29kZSB0 byBtbV9tbXUuYy9tbV9tbXUuaA0KPiANCj4gSGksDQo+IA0KPiBPbiAxMy8wMS8yMDIzIDA1OjI4 LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBGcm9tOiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNv bT4NCj4gPg0KPiA+IFRvIG1ha2UgdGhlIGNvZGUgcmVhZGFibGUgYW5kIG1haW50YWluYWJsZSwg d2UgbW92ZSBNTVUtc3BlY2lmaWMNCj4gPiBtZW1vcnkgbWFuYWdlbWVudCBjb2RlIGZyb20gbW0u YyB0byBtbV9tbXUuYyBhbmQgbW92ZSBNTVUtDQo+IHNwZWNpZmljDQo+ID4gZGVmaW5pdGlvbnMg ZnJvbSBtbS5oIHRvIG1tX21tdS5oLg0KPiA+IExhdGVyIHdlIHdpbGwgY3JlYXRlIG1tX21wdS5o IGFuZCBtbV9tcHUuYyBmb3IgTVBVLXNwZWNpZmljIG1lbW9yeQ0KPiA+IG1hbmFnZW1lbnQgY29k ZS4NCj4gDQo+IFRoaXMgc2VudGVuY2UgaW1wbGllcyB0aGVyZSBpcyBubyBtbV9tcHUue2MsIGh9 IHlldCBhbmQgdGhpcyBpcyBub3QgdG91Y2hlZA0KPiB3aXRoaW4gdGhpcyBwYXRjaC4gSG93ZXZl ci4uLg0KPiANCj4gDQo+ID4gVGhpcyB3aWxsIGF2b2lkIGxvdHMgb2YgI2lmZGVmIGluIG1lbW9y eSBtYW5hZ2VtZW50IGNvZGUgYW5kIGhlYWRlciBmaWxlcy4NCj4gPg0KPiA+IFNpZ25lZC1vZmYt Ynk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55 IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJt L01ha2VmaWxlICAgICAgICAgICAgIHwgICAgNSArDQo+ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVk ZS9hc20vbW0uaCAgICAgfCAgIDE5ICstDQo+ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v bW1fbW11LmggfCAgIDM1ICsNCj4gPiAgIHhlbi9hcmNoL2FybS9tbS5jICAgICAgICAgICAgICAg ICB8IDEzNTIgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJt L21tX21tdS5jICAgICAgICAgICAgIHwgMTM3Ng0KPiArKysrKysrKysrKysrKysrKysrKysrKysr KysrKw0KPiA+ICAgeGVuL2FyY2gvYXJtL21tX21wdS5jICAgICAgICAgICAgIHwgICA2NyArKw0K PiANCj4gLi4uIEl0IGxvb2tzIGxpa2UgdGhleSBhbHJlYWR5IGV4aXN0cyBhbmQgeW91IGFyZSBt b2RpZnlpbmcgdGhlbS4gVGhhdA0KPiBzYWlkLCBpdCB3b3VsZCBiZSBiZXR0ZXIgaWYgdGhpcyBw YXRjaCBvbmx5IGNvbnRhaW5zIGNvZGUgbW92ZW1lbnQgKElPVw0KPiBubyBNUFUgY2hhbmdlcyku DQo+IA0KPiA+ICAgNiBmaWxlcyBjaGFuZ2VkLCAxNDg4IGluc2VydGlvbnMoKyksIDEzNjYgZGVs ZXRpb25zKC0pDQo+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL21tX21tdS5oDQo+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gvYXJtL21tX21t dS5jDQo+IA0KPiBJIGRvbid0IHBhcnRpY3VsYXIgbGlrZSB0aGUgbmFtaW5nLiBJIHRoaW5rIGl0 IHdvdWxkIG1ha2UgbW9yZSBzZW5zZSB0bw0KPiBpbnRyb2R1Y2UgdHdvIGRpcmVjdG9yaWVzOiAi bW11IiBhbmQgIm1wdSIgd2hpY2ggaW5jbHVkZXMgY29kZSBzcGVjaWZpYw0KPiB0byBlYWNoIGZs YXZvciBvZiBYZW4uDQo+IA0KWy4uLl0NCj4gPg0KPiA+IC0NCj4gPiAtLyogUmVsZWFzZSBhbGwg X19pbml0IGFuZCBfX2luaXRkYXRhIHJhbmdlcyB0byBiZSByZXVzZWQgKi8NCj4gPiAtdm9pZCBm cmVlX2luaXRfbWVtb3J5KHZvaWQpDQo+IA0KPiBUaGlzIGZ1bmN0aW9uIGRvZXNuJ3QgbG9vayBz cGVjaWZpYyB0byB0aGUgTU1VLg0KPiANCg0KRnVuY3Rpb25zIGxpa2UsIGVhcmx5X2ZkdF9tYXBb MV0gLyBzZXR1cF9mcmFtZXRhYmxlX21hcHBpbmdzWzJdIC8gZnJlZV9pbml0X21lbW9yeSBbM10g Li4uDQp0aGV5IGJvdGggc2hhcmUgcXVpdGUgdGhlIHNhbWUgbG9naWMgYXMgTU1VIGRvZXMgaW4g TVBVIHN5c3RlbSwgdGhlIGRpZmZlcmVuY2UgY291bGQgb25seQ0KYmUgYWRkcmVzcyB0cmFuc2xh dGlvbiByZWdpbWUuIFN0aWxsLCBpbiBvcmRlciB0byBhdm9pZCBwdXR0aW5nIHRvbyBtdWNoICNp ZmRlZiBoZXJlIGFuZCB0aGVyZSwNCkkgaW1wbGVtZW50IGRpZmZlcmVudCBNTVUgYW5kIE1QVSB2 ZXJzaW9uIG9mIHRoZW0uDQogDQpPciBJIGtlZXAgdGhlbSBpbiBnZW5lcmljIGZpbGUgaGVyZSwg dGhlbiBpbiBmdXR1cmUgY29tbWl0cyB3aGVuIHdlIGltcGxlbWVudCBNUFUgdmVyc2lvbg0Kb2Yg dGhlbShJIGxpc3QgcmVsYXRlZCBjb21taXRzIGJlbG93KSwgSSB0cmFuc2ZlciB0aGVtIHRvIE1N VSBmaWxlIHRoZXJlLg0KDQpXZHl0Pw0KDQpbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDIzLTAxL21zZzAwNzc0Lmh0bWwgDQpbMl0gaHR0 cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDIzLTAx L21zZzAwNzg3Lmh0bWwgCQ0KWzNdIGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJjaGl2 ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMy0wMS9tc2cwMDc4Ni5odG1sIA0KDQo+ID4gLXsNCj4gPiAt ICAgIHBhZGRyX3QgcGEgPSB2aXJ0X3RvX21hZGRyKF9faW5pdF9iZWdpbik7DQo+ID4gLSAgICB1 bnNpZ25lZCBsb25nIGxlbiA9IF9faW5pdF9lbmQgLSBfX2luaXRfYmVnaW47DQo+ID4gLSAgICB1 aW50MzJfdCBpbnNuOw0KPiA+IC0gICAgdW5zaWduZWQgaW50IGksIG5yID0gbGVuIC8gc2l6ZW9m KGluc24pOw0KPiA+IC0gICAgdWludDMyX3QgKnA7DQo+ID4gLSAgICBpbnQgcmM7DQo+ID4gLQ0K PiA+IC0gICAgcmMgPSBtb2RpZnlfeGVuX21hcHBpbmdzKCh1bnNpZ25lZCBsb25nKV9faW5pdF9i ZWdpbiwNCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9uZylf X2luaXRfZW5kLCBQQUdFX0hZUEVSVklTT1JfUlcpOw0KPiA+IC0gICAgaWYgKCByYyApDQo+ID4g LSAgICAgICAgcGFuaWMoIlVuYWJsZSB0byBtYXAgUlcgdGhlIGluaXQgc2VjdGlvbiAocmMgPSAl ZClcbiIsIHJjKTsNCj4gPiAtDQo+ID4gLSAgICAvKg0KPiA+IC0gICAgICogRnJvbSBub3cgb24s IGluaXQgd2lsbCBub3QgYmUgdXNlZCBmb3IgZXhlY3V0aW9uIGFueW1vcmUsDQo+ID4gLSAgICAg KiBzbyBudWtlIHRoZSBpbnN0cnVjdGlvbiBjYWNoZSB0byByZW1vdmUgZW50cmllcyByZWxhdGVk IHRvIGluaXQuDQo+ID4gLSAgICAgKi8NCj4gPiAtICAgIGludmFsaWRhdGVfaWNhY2hlX2xvY2Fs KCk7DQo+ID4gLQ0KPiA+IC0jaWZkZWYgQ09ORklHX0FSTV8zMg0KPiA+IC0gICAgLyogdWRmIGlu c3RydWN0aW9uIGkuZSAoc2VlIEE4LjguMjQ3IGluIEFSTSBEREkgMDQwNkMuYykgKi8NCj4gPiAt ICAgIGluc24gPSAweGU3ZjAwMGYwOw0KPiA+IC0jZWxzZQ0KPiA+IC0gICAgaW5zbiA9IEFBUkNI NjRfQlJFQUtfRkFVTFQ7DQo+ID4gLSNlbmRpZg0KPiA+IC0gICAgcCA9ICh1aW50MzJfdCAqKV9f aW5pdF9iZWdpbjsNCj4gPiAtICAgIGZvciAoIGkgPSAwOyBpIDwgbnI7IGkrKyApDQo+ID4gLSAg ICAgICAgKihwICsgaSkgPSBpbnNuOw0KPiA+IC0NCj4gPiAtICAgIHJjID0gZGVzdHJveV94ZW5f bWFwcGluZ3MoKHVuc2lnbmVkIGxvbmcpX19pbml0X2JlZ2luLA0KPiA+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9uZylfX2luaXRfZW5kKTsNCj4gPiAtICAgIGlm ICggcmMgKQ0KPiA+IC0gICAgICAgIHBhbmljKCJVbmFibGUgdG8gcmVtb3ZlIHRoZSBpbml0IHNl Y3Rpb24gKHJjID0gJWQpXG4iLCByYyk7DQo+ID4gLQ0KPiA+IC0gICAgaW5pdF9kb21oZWFwX3Bh Z2VzKHBhLCBwYSArIGxlbik7DQo+ID4gLSAgICBwcmludGsoIkZyZWVkICVsZGtCIGluaXQgbWVt b3J5LlxuIiwgKGxvbmcpKF9faW5pdF9lbmQtDQo+IF9faW5pdF9iZWdpbik+PjEwKTsNCj4gPiAt fQ0KPiA+IC0NCj4gDQo+IA0KPiBbLi4uXQ0KPiANCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv YXJtL21tX21wdS5jIGIveGVuL2FyY2gvYXJtL21tX21wdS5jDQo+ID4gaW5kZXggNDNlOWExYmU0 ZC4uODdhMTIwNDJjYyAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vbW1fbXB1LmMNCj4g PiArKysgYi94ZW4vYXJjaC9hcm0vbW1fbXB1LmMNCj4gPiBAQCAtMjAsOCArMjAsMTAgQEANCj4g PiAgICAqLw0KPiA+DQo+ID4gICAjaW5jbHVkZSA8eGVuL2luaXQuaD4NCj4gPiArI2luY2x1ZGUg PHhlbi9tbS5oPg0KPiA+ICAgI2luY2x1ZGUgPHhlbi9wYWdlLXNpemUuaD4NCj4gPiAgICNpbmNs dWRlIDxhc20vYXJtNjQvbXB1Lmg+DQo+ID4gKyNpbmNsdWRlIDxhc20vcGFnZS5oPg0KPiANCj4g UmVnYXJkbGVzcyBvZiB3aGF0IEkgd3JvdGUgYWJvdmUsIG5vbmUgb2YgdGhlIGNvZGUgeW91IGFk ZCBzZWVtcyB0bw0KPiByZXF1aXJlIDxhc20vcGFnZS5oPg0KPiANCj4gPg0KPiA+ICAgLyogWGVu IE1QVSBtZW1vcnkgcmVnaW9uIG1hcHBpbmcgdGFibGUuICovDQo+ID4gICBwcl90IF9fYWxpZ25l ZChQQUdFX1NJWkUpIF9fc2VjdGlvbigiLmRhdGEucGFnZV9hbGlnbmVkIikNCj4gPiBAQCAtMzgs NiArNDAsNzEgQEAgdWludDY0X3QgX19yb19hZnRlcl9pbml0IG5leHRfdHJhbnNpZW50X3JlZ2lv bl9pZHg7DQo+ID4gICAvKiBNYXhpbXVtIG51bWJlciBvZiBzdXBwb3J0ZWQgTVBVIG1lbW9yeSBy ZWdpb25zIGJ5IHRoZSBFTDIgTVBVLg0KPiAqLw0KPiA+ICAgdWludDY0X3QgX19yb19hZnRlcl9p bml0IG1heF94ZW5fbXB1bWFwOw0KPiA+DQo+ID4gKy8qIFRPRE86IEltcGxlbWVudGF0aW9uIG9u IHRoZSBmaXJzdCB1c2FnZSAqLw0KPiANCj4gSXQgaXMgbm90IGNsZWFyIHdoYXQgeW91IG1lYW4g Z2l2ZW4gdGhlcmUgYXJlIHNvbWUgY2FsbGVycy4NCj4gDQo+ID4gK3ZvaWQgZHVtcF9oeXBfd2Fs ayh2YWRkcl90IGFkZHIpDQo+ID4gK3sNCj4gDQo+IFBsZWFzZSBhZGQgQVNTRVJUX1VOUkVBQ0hB QkxFKCkgZm9yIGFueSBkdW1teSBoZWxwZXIgeW91IGhhdmUNCj4gaW50cm9kdWNlZA0KPiBhbnkg cGxhbiB0byBpbXBsZW1lbnQgbGF0ZXIuIFRoaXMgd2lsbCBiZSBoZWxwZnVsIHRvIHRyYWNrIGRv d24gYW55DQo+IGZ1bmN0aW9uIHlvdSBoYXZlbid0IGltcGxlbWVudGVkLg0KPiANCj4gDQo+ID4g K30NCj4gPiArDQo+ID4gK3ZvaWQgKiBfX2luaXQgZWFybHlfZmR0X21hcChwYWRkcl90IGZkdF9w YWRkcikNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIE5VTEw7DQo+ID4gK30NCj4gPiArDQo+ID4g K3ZvaWQgX19pbml0IHJlbW92ZV9lYXJseV9tYXBwaW5ncyh2b2lkKQ0KPiA+ICt7DQo+IA0KPiBE aXR0bw0KPiANCj4gPiArfQ0KPiA+ICsNCj4gPiAraW50IGluaXRfc2Vjb25kYXJ5X3BhZ2V0YWJs ZXMoaW50IGNwdSkNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIC1FTk9TWVM7DQo+ID4gK30NCj4g PiArDQo+ID4gK3ZvaWQgbW11X2luaXRfc2Vjb25kYXJ5X2NwdSh2b2lkKQ0KPiA+ICt7DQo+IA0K PiBEaXR0by4gVGhlIG5hbWUgb2YgdGhlIGZ1bmN0aW9uIGlzIGFsc28gYSBiaXQgb2RkIGdpdmVu IHRoaXMgaXMgYW4gTVBVDQo+IHNwZWNpZmljIGZpbGUuIFRoaXMgbGlrZWx5IHdhbnQgdG8gYmUg cmVuYW1lZCB0byBtbV9pbml0X3NlY29uZGFyeV9jcHUoKS4NCj4gDQo+ID4gK30NCj4gPiArDQo+ ID4gK3ZvaWQgKmlvcmVtYXBfYXR0cihwYWRkcl90IHBhLCBzaXplX3QgbGVuLCB1bnNpZ25lZCBp bnQgYXR0cmlidXRlcykNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIE5VTEw7DQo+ID4gK30NCj4g PiArDQo+ID4gK3ZvaWQgKmlvcmVtYXAocGFkZHJfdCBwYSwgc2l6ZV90IGxlbikNCj4gPiArew0K PiA+ICsgICAgcmV0dXJuIE5VTEw7DQo+ID4gK30NCj4gPiArDQo+ID4gK2ludCBtYXBfcGFnZXNf dG9feGVuKHVuc2lnbmVkIGxvbmcgdmlydCwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgbWZu X3QgbWZuLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG5yX21mbnMs DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFncykNCj4gPiArew0K PiA+ICsgICAgcmV0dXJuIC1FTk9TWVM7DQo+ID4gK30NCj4gPiArDQo+ID4gK2ludCBkZXN0cm95 X3hlbl9tYXBwaW5ncyh1bnNpZ25lZCBsb25nIHMsIHVuc2lnbmVkIGxvbmcgZSkNCj4gPiArew0K PiA+ICsgICAgcmV0dXJuIC1FTk9TWVM7DQo+ID4gK30NCj4gPiArDQo+ID4gK2ludCBtb2RpZnlf eGVuX21hcHBpbmdzKHVuc2lnbmVkIGxvbmcgcywgdW5zaWduZWQgbG9uZyBlLCB1bnNpZ25lZCBp bnQNCj4gZmxhZ3MpDQo+ID4gK3sNCj4gPiArICAgIHJldHVybiAtRU5PU1lTOw0KPiA+ICt9DQo+ ID4gKw0KPiA+ICt2b2lkIGZyZWVfaW5pdF9tZW1vcnkodm9pZCkNCj4gPiArew0KPiANCj4gRGl0 dG8uDQo+IA0KPiA+ICt9DQo+ID4gKw0KPiA+ICtpbnQgeGVubWVtX2FkZF90b19waHlzbWFwX29u ZSgNCj4gPiArICAgIHN0cnVjdCBkb21haW4gKmQsDQo+ID4gKyAgICB1bnNpZ25lZCBpbnQgc3Bh Y2UsDQo+ID4gKyAgICB1bmlvbiBhZGRfdG9fcGh5c21hcF9leHRyYSBleHRyYSwNCj4gPiArICAg IHVuc2lnbmVkIGxvbmcgaWR4LA0KPiA+ICsgICAgZ2ZuX3QgZ2ZuKQ0KPiA+ICt7DQo+ID4gKyAg ICByZXR1cm4gLUVOT1NZUzsNCj4gPiArfQ0KPiA+ICsNCj4gPiAgIC8qDQo+ID4gICAgKiBMb2Nh bCB2YXJpYWJsZXM6DQo+ID4gICAgKiBtb2RlOiBDDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwN Cg== From xen-devel-bounces@lists.xenproject.org Tue Feb 07 04:16:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 04:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490841.759710 (Exim 4.92) (envelope-from ) id 1pPFPE-0000Jo-KV; Tue, 07 Feb 2023 04:16:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490841.759710; Tue, 07 Feb 2023 04:16:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPFPE-0000Jh-HL; Tue, 07 Feb 2023 04:16:32 +0000 Received: by outflank-mailman (input) for mailman id 490841; Tue, 07 Feb 2023 04:16:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPFPC-0000Jb-HN for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 04:16:30 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 308c75ea-a69e-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 05:16:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D3DCD5C010A; Mon, 6 Feb 2023 23:16:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 06 Feb 2023 23:16:26 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 23:16:24 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 308c75ea-a69e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675743386; x= 1675829786; bh=T+RzIRfVPAOp7N6E1JMBNPuSrGmeuNu+auzyrAc2/IA=; b=P nojtqfPpGoPZuB6vRDuVkzi0xyRWhq5wQe3g/zcsj2FouURpc87QMncoRfooaFRR nNn+i7NpxGVdZ436ORlBLWLgtSMlmJCLGcZ+pZraeJSiz6rvZmzgAzU/T7P7ubXH OizkL0KG/jekelXhKhS5z3HQDy13OsuvyBg5m6/s0k/jEu34vXiO6FL0l8mspVr0 mUwcZsWjAziINVxq/FkSo6fDLM2SrmeBW2+LWSZq5CNBF2oOJeWd/XqsIZhyozlc YxXV1T5Voj3ZWzoRmMTVukRW9T+9tc2I+PKuj5CfRh6Hpw3RLC5uXmHcvURmwMsq uRAIxu3x4xslOlmsCKuGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675743386; x=1675829786; bh=T+RzIRfVPAOp7N6E1JMBNPuSrGme uNu+auzyrAc2/IA=; b=pAXzU/XGjIGC0oSEROVSVHUuhPHlqVdhVY37ZepShQuH n14z7bXgUq91dfo12lmvW2+yMa7zzx/EEPnwPgqeq+ESBzgmmeo5XBSc4pBp7+J5 Zx5zIAg1DdmyuCeoQrB1zJ5b3QCCaCiGs2BWRPUxuRtsl/LuSCP91274UZrEqq6L gpuTLyOg4adiwT7HtVgAQloHkEwU0o9rwqj7XEvL8xk2uGAR+4Y981cTTKLD06sr HZ4OlCcoHg8LtIpCDrEkAu2ORepVAg4d318lGu+B1l9DdYt9h7jIOs90DT8OSNm7 ky87fhL0zJJojB2salJdKUHcirityn+L46G5qigAdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek ieettddvvdefvddtgedtgfehkeetteeiteegledtvdelfffgiefhkefhffeknecuffhomh grihhnpeigvghnrdhorhhgpdhllhhvmhdrohhrghdpghhithhlrggsrdgtohhmnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvg hksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 7 Feb 2023 05:16:21 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH] Replace git:// and http:// with https:// Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RnBPpALuuVEdkz4K" Content-Disposition: inline In-Reply-To: --RnBPpALuuVEdkz4K Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 7 Feb 2023 05:16:21 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH] Replace git:// and http:// with https:// On Mon, Feb 06, 2023 at 10:10:33PM -0500, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. >=20 > This patch was created by doing a tree-wide search and replace with sed, > then reverting changes that were pointless or wrong. >=20 > Signed-off-by: Demi Marie Obenour > --- > Config.mk | 20 ++++++-------------- > README | 4 ++-- > automation/build/centos/CentOS-7.2.repo | 8 ++++---- > automation/build/debian/stretch-llvm-8.list | 4 ++-- > automation/build/debian/unstable-llvm-8.list | 4 ++-- > automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- > docs/README.remus | 2 +- > docs/conf.py | 2 +- > scripts/get_maintainer.pl | 2 +- > stubdom/configure | 18 +++++++++--------- > stubdom/configure.ac | 18 +++++++++--------- > stubdom/grub.patches/10graphics.diff | 2 +- > tools/examples/xeninfo.pl | 2 +- > tools/firmware/etherboot/Makefile | 4 ++-- > tools/firmware/etherboot/README | 2 +- > tools/firmware/hvmloader/pci_regs.h | 2 +- > tools/firmware/hvmloader/pir.c | 2 +- > tools/firmware/hvmloader/pir_types.h | 2 +- > tools/firmware/hvmloader/smbios_types.h | 2 +- > 19 files changed, 47 insertions(+), 55 deletions(-) >=20 > diff --git a/Config.mk b/Config.mk > index 10eb443b17d85381b2d1e2282f8965c3e99767e0..fd0719e38be1c679946c4d677= c0f0dbdb2a85411 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=3D $(foreach i, $(APPEND_INCLUDES), -= I$(i)) > EMBEDDED_EXTRA_CFLAGS :=3D -fno-pie -fno-stack-protector -fno-stack-prot= ector-all > EMBEDDED_EXTRA_CFLAGS +=3D -fno-exceptions -fno-asynchronous-unwind-tabl= es > =20 > -XEN_EXTFILES_URL ?=3D http://xenbits.xen.org/xen-extfiles > +XEN_EXTFILES_URL ?=3D https://xenbits.xen.org/xen-extfiles > # All the files at that location were downloaded from elsewhere on > # the internet. The original download URL is preserved as a comment > # near the place in the Xen Makefiles where the file is used. > @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) > QEMU_TRADITIONAL_REVISION ?=3D $(QEMU_TAG) > endif > =20 > -ifeq ($(GIT_HTTP),y) > -OVMF_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/ovmf.git > -QEMU_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/qemu-xen.git > -QEMU_TRADITIONAL_URL ?=3D http://xenbits.xen.org/git-http/qemu-xen-tradi= tional.git > -SEABIOS_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/seabios.git > -MINIOS_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/mini-os.git > -else > -OVMF_UPSTREAM_URL ?=3D git://xenbits.xen.org/ovmf.git > -QEMU_UPSTREAM_URL ?=3D git://xenbits.xen.org/qemu-xen.git > -QEMU_TRADITIONAL_URL ?=3D git://xenbits.xen.org/qemu-xen-traditional.git > -SEABIOS_UPSTREAM_URL ?=3D git://xenbits.xen.org/seabios.git > -MINIOS_UPSTREAM_URL ?=3D git://xenbits.xen.org/mini-os.git > -endif > +OVMF_UPSTREAM_URL ?=3D https://xenbits.xen.org/ovmf.git > +QEMU_UPSTREAM_URL ?=3D https://xenbits.xen.org/qemu-xen.git > +QEMU_TRADITIONAL_URL ?=3D https://xenbits.xen.org/qemu-xen-traditional.g= it > +SEABIOS_UPSTREAM_URL ?=3D https://xenbits.xen.org/seabios.git > +MINIOS_UPSTREAM_URL ?=3D https://xenbits.xen.org/mini-os.git xenbits http server has git under /git-http/, so you need to adjust URLs when changing the protocol. Verify if all other URLs in this patch actually work too. (...) > diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/bui= ld/debian/stretch-llvm-8.list > index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185= 423adf4b0c51a21 100644 > --- a/automation/build/debian/stretch-llvm-8.list > +++ b/automation/build/debian/stretch-llvm-8.list > @@ -1,3 +1,3 @@ > # Strech LLVM 8 repos > -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main APT used to require extra package (apt-transport-https) to support HTTPS (I'm pretty sure it applies to stretch, but probably not to unstable). And also, it needs ca-certificates installed. So, this may require some more work before switching the protocol. You can observe https://gitlab.com/xen-project/patchew/xen/-/pipelines if/when gitlab picks it up, to see if everything still works. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --RnBPpALuuVEdkz4K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPh0JYACgkQ24/THMrX 1ywTxgf+N8Z0WN/SpCBci1N6Tf8WXZbkHoHtAVIPWbst/uCf/2v7TQUj8UcQF1Pd VMDWe2OUca2Te/hslDjssntG00AMVOFUcBfbq0jMFE2s5VgVZLbbPvAS6PCSua5V ySsgh8jc+yHkql58OpG08cM/bJlX10RuYf4DLrYDKwmd8LLHMIxjdepHc/yXZWk1 2qxkQNlT12GqScm3bXX7HoDhH5G2WMOoXEfswPbVz2VJ+ullR42BfbzOWJodTTPO A4iGbmP/6o1i28onuGFrTM7b4j+X9rLPyfuMpDZcV7x5QEsEoe8F7LBnc7e50yoC lj5FBatfn7VDnuiPgyQP6b4QoyJRRg== =mMs7 -----END PGP SIGNATURE----- --RnBPpALuuVEdkz4K-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 04:41:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 04:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490851.759724 (Exim 4.92) (envelope-from ) id 1pPFnC-0003tG-Qw; Tue, 07 Feb 2023 04:41:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490851.759724; Tue, 07 Feb 2023 04:41:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPFnC-0003t9-O1; Tue, 07 Feb 2023 04:41:18 +0000 Received: by outflank-mailman (input) for mailman id 490851; Tue, 07 Feb 2023 04:41:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPFnB-0003t3-Bm for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 04:41:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061a.outbound.protection.outlook.com [2a01:111:f400:7d00::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7e1d153-a6a1-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 05:41:15 +0100 (CET) Received: from DUZPR01CA0130.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bc::25) by DB9PR08MB8458.eurprd08.prod.outlook.com (2603:10a6:10:3d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 04:41:11 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bc:cafe::54) by DUZPR01CA0130.outlook.office365.com (2603:10a6:10:4bc::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 04:41:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 04:41:11 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Tue, 07 Feb 2023 04:41:11 +0000 Received: from f44109f421b3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 58CB2DA3-BFAA-4A65-953C-F8C3EDAD0D7C.1; Tue, 07 Feb 2023 04:41:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f44109f421b3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Feb 2023 04:41:05 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by GVXPR08MB7869.eurprd08.prod.outlook.com (2603:10a6:150:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Tue, 7 Feb 2023 04:41:02 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Tue, 7 Feb 2023 04:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7e1d153-a6a1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7n6XQxCZb9v9WEalNy2ILrO3/Yijeb+Kvcd1gHK7j0=; b=yFY56P6y08ZexJAnfve4TtWI3Ti7653Xm9i0yd2MnyMmWyEVVKefJgl5xt74nkh4wvPu4TesW+gnGcvpdwFG0Z3JwXdJpCZf2xDeVvM6+vgBQFBY0Y1C2buZJfR3JLe7CSFc/wH87MpF+DGWq0q5k+zEq5aBsNz9evVWTwF0Wbs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQPKOnIYyPfwYxIWLVQrnVd64rDofufS8yZ7n0m1KVvSoUW65x+/vqHhTlgbVtowNEWAWOqXX48Xs0Qm9e/wqVRlVABqr7Bcntr4FWaEAM9RLX6XQFzsrfIzfDT8/0oIcToyjv+q0NjnOUNcTsUUPMgzbD+qQBtfGQanyb+TMxgRsPhnupFOtvqJD8IryWgwfG3eMPXwWh0TqPovMcb/grIHS2rgTjpQHINg/bCINKSEebAdSTQFiYIyCnkh6SEwAA9XVbXa2rhWSYIAVRs2n+fIGBpt3W6W0qsHgnZu9arKSLXuoQyQvbEhZDg1F/R+W3xqSR3qyP04t05odgnZLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7n6XQxCZb9v9WEalNy2ILrO3/Yijeb+Kvcd1gHK7j0=; b=biRGH51ymNMcE2zmxnil8KKyUk3CrPWXIB8fdLIaiXv7ne/WLJ9hfsqvOYZzlL8Hiihxa8JGCInkJ/ejzRj8jlAJvCbQ9saDGahi8nvvw3ob67U9HKFQhZswuuVK00KcVtW32DHgOGNuT+p3QsxVLuJKfewa04/wrivoTts+OYmUn1ILcuh5OXGxVtTBtyeNmEZf3iFjF9HyBku/yi00jxyXqBgrA2zp+JfRCbX8ThPGLnbuKlApYx60IgtnQibuf+R5hsnEOOofow78dIYiK+vHLcWuD3hFXiE2MSEUtwbX+pkDyGdkBnS0pU8r0Cxn/2NUcgtd9Hq0HAW98qhjoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7n6XQxCZb9v9WEalNy2ILrO3/Yijeb+Kvcd1gHK7j0=; b=yFY56P6y08ZexJAnfve4TtWI3Ti7653Xm9i0yd2MnyMmWyEVVKefJgl5xt74nkh4wvPu4TesW+gnGcvpdwFG0Z3JwXdJpCZf2xDeVvM6+vgBQFBY0Y1C2buZJfR3JLe7CSFc/wH87MpF+DGWq0q5k+zEq5aBsNz9evVWTwF0Wbs= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 16/40] xen/arm: introduce setup_mm_mappings Thread-Topic: [PATCH v2 16/40] xen/arm: introduce setup_mm_mappings Thread-Index: AQHZJxApt1qKOFucDkmJWOJS5upXDK7BBHYAgAIIgnA= Date: Tue, 7 Feb 2023 04:40:59 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-17-Penny.Zheng@arm.com> <906699b8-14ae-d038-3693-63338d7a52cf@xen.org> In-Reply-To: <906699b8-14ae-d038-3693-63338d7a52cf@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 551B48383A2D1E44BF938ED4B8864A8C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|GVXPR08MB7869:EE_|DBAEUR03FT042:EE_|DB9PR08MB8458:EE_ X-MS-Office365-Filtering-Correlation-Id: e8f32b40-775a-4845-879e-08db08c5898f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pri7AWUz/y2ahCC8PlOoNlhrbfsDt/cuVGEiSQazyOn5Fy65tu7pMeS9Zdr4fb2aj63m2HchcjLE3vcYrqinSRd3PdNixPOV808M3bk7Wey1cjS6fl1d73ZsQ58P+yxxPamnNeLrAunniX6LMUVrmMONZu+4sOCl9ZMt25tfw7ScwHFZw9X4oMRyruRshmZc07hQfBMAr08OMweWl8Te17/PeP6HFo+tg2MZAfYxMMQckpyNsAfFIyyHSfOLyuZhcnUPwKI6exPMbxIy6cs19XRR2i42ox1FwCgnmx487Yl4OlXx/8Bo+1Ca0d9dV/0dGN5xbEdiTai5oltRbciI+KD2M4BJBk2Tp3BNtaXMQXMGUQb7T9WbQn3d2Mge6VrpUF3NJqC3UaRcNH4XfMzyPrpJ/VPMSRmBwg6ZpfJ+qozubuvYxTCGULS/U/UC0tHMYvVToS6JKwlxVaH1UVP6dLKm4EtFOGzHtWj95rWFYtaFIahCOVcdBv7eKEfkvEW0hOT9qJGpYiz0KHDg838EpIR5tnH8QyWFwExmq/mUcb9Xt1IlGLuFc8iU+ZgP687F9V7fxPArGkhGugxAm+1Kxw+REmKQzEfceoKKf1PizVUx8y28ctb751EsNB3aZkD8fwcmjEMpHMrjbbQBAr/nTWUTcRQZFqjM1Wfn56RjJsBkYGUhHSv6/ShPM2g9i6PyhXaiwjo7emb/ZAhCtFShY9+BWLu+ZlVlrgJp+lka9/I= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199018)(33656002)(316002)(86362001)(478600001)(54906003)(110136005)(71200400001)(5660300002)(55016003)(8936002)(66476007)(52536014)(2906002)(4326008)(76116006)(8676002)(66946007)(64756008)(66556008)(66446008)(41300700001)(38070700005)(122000001)(186003)(83380400001)(9686003)(38100700002)(7696005)(6506007)(53546011)(26005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7869 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7ccd800d-86e0-479a-6c92-08db08c58272 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yedI1mNtoai3hn3y1tbfi3OBCMScgFoUfMk78gmnVOV5JspEGMflDY0Jw4xc4GqxnNTw8q9NS8Cp0I/2+31dWaGw1cwI31lxCdDkD6wQRebzSP9KQlO3CbjIG8Bzi6KBHGmnzq0H2fYJ1OdxDn02B5TONdQdhPMEHdghNGaq/eUcUHezUcCUx+hvJ9j9fkMVFR/VTOr6NXDpalxgBzWTZABQQrdDckAboJl/Urk/+ldGMgxuH2w+0SWumX50CTrddnbbZID36Pp59JSe9kby5UV94VeZLjeq9n+7f1sQ/Ddz1tVoXvMNwmAw4znwKiPsrQR+i+jlfvXwf3pe5hhQ3/Jrh+6UKHK432Dk3S/MrogGQMd8hV5sJOj0RmZOQpB0G0tBn6YSvvx5HxS6QjMC2LZGQCEOlN8RLkD1tWLqesBkeKalaK2z2aNUXYCJquWjk8Ondp0XWCzaflZRKxKMRvaqzDeLL8tOoch89w5toF8W+KnhSgjJmWtVVZbe8dR33r74EdsZkhrIqFW32Eq44o+gUqyKuRbWlpaNeulFQX7Oa8plzb9yT3+uL2JiA+I50eAVKD8Z9/QVSmcFKb0cFbbKs815TdRSlaXcrBI+h/qVywT7usiuSywZVYBGxdRa0Ly6vtiEmeESt/yBtyou/4AmRL6xckmhE2ZAj6kMHmw/l5Vuv7YRllKLpBOV6CAKo6yMMeBlg0DSV/emxLDKbh2OxUFECvNDyksq5Lbh3lw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199018)(40470700004)(46966006)(36840700001)(478600001)(26005)(186003)(9686003)(7696005)(53546011)(8936002)(5660300002)(52536014)(40480700001)(41300700001)(55016003)(336012)(6506007)(107886003)(316002)(54906003)(110136005)(70586007)(70206006)(356005)(4326008)(83380400001)(8676002)(40460700003)(33656002)(36860700001)(47076005)(81166007)(82740400003)(2906002)(82310400005)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 04:41:11.2365 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e8f32b40-775a-4845-879e-08db08c5898f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8458 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBGZWJydWFyeSA2LCAyMDIz IDU6MzIgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJj aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2 MiAxNi80MF0geGVuL2FybTogaW50cm9kdWNlIHNldHVwX21tX21hcHBpbmdzDQo+IA0KPiBIaSwN Cj4gDQo+IE9uIDEzLzAxLzIwMjMgMDU6MjgsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEZ1bmN0 aW9uIHNldHVwX3BhZ2V0YWJsZXMgaXMgcmVzcG9uc2libGUgZm9yIGJvb3QtdGltZSBwYWdldGFi bGUgc2V0dXANCj4gPiBpbiBNTVUgc3lzdGVtLg0KPiA+IEJ1dCBpbiBNUFUgc3lzdGVtLCB3ZSBo YXZlIGFscmVhZHkgYnVpbHQgdXAgc3RhcnQtb2YtZGF5IFhlbiBNUFUNCj4gPiBtZW1vcnkgcmVn aW9uIG1hcHBpbmcgYXQgdGhlIHZlcnkgYmVnaW5uaW5nIGluIGFzc2VtYmx5Lg0KPiA+DQo+ID4g U28gaW4gb3JkZXIgdG8ga2VlcCBvbmx5IG9uZSBjb2RlZmxvdyBpbiBhcm0vc2V0dXAuYywNCj4g PiBzZXR1cF9tbV9tYXBwaW5ncyAsIHdpdGggYSBtb3JlIGdlbmVyaWMgbmFtZSwgaXMgaW50cm9k dWNlZCBhbmQgYWN0IGFzDQo+ID4gYW4gZW1wdHkgc3R1YiBpbiBNUFUgc3lzdGVtLg0KPiANCj4g aXMgdGhlIGVtcHR5IHN0dWIgdGVtcG9yYXJpbHk/DQo+IA0KPiA+DQo+ID4gU2lnbmVkLW9mZi1i eTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTog V2VpIENoZW4gPHdlaS5jaGVuQGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vbW0uaCAgICAgfCAgMiArKw0KPiA+ICAgeGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL21tX21wdS5oIHwgMTYgKysrKysrKysrKysrKysrKw0KPiA+ICAgeGVuL2FyY2gvYXJtL3Nl dHVwLmMgICAgICAgICAgICAgIHwgIDIgKy0NCj4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgMTkgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9tbV9tcHUuaA0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9tbS5oDQo+ID4gYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v bW0uaCBpbmRleCAxYjlmZGI2ZmY1Li45YjRjMDdkOTY1IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9tbS5oDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL21tLmgNCj4gPiBAQCAtMjQzLDYgKzI0Myw4IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfX2lv bWVtICppb3JlbWFwX3djKHBhZGRyX3QNCj4gPiBzdGFydCwgc2l6ZV90IGxlbikNCj4gPg0KPiA+ ICAgI2lmbmRlZiBDT05GSUdfSEFTX01QVQ0KPiA+ICAgI2luY2x1ZGUgPGFzbS9tbV9tbXUuaD4N Cj4gPiArI2Vsc2UNCj4gPiArI2luY2x1ZGUgPGFzbS9tbV9tcHUuaD4NCj4gPiAgICNlbmRpZg0K PiA+DQo+ID4gICAvKiBQYWdlLWFsaWduIGFkZHJlc3MgYW5kIGNvbnZlcnQgdG8gZnJhbWUgbnVt YmVyIGZvcm1hdCAqLyBkaWZmDQo+ID4gLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v bW1fbXB1LmgNCj4gPiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9tbV9tcHUuaA0KPiA+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gaW5kZXggMDAwMDAwMDAwMC4uMWYzY2ZmNzc0Mw0KPiA+ IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vbW1fbXB1 LmgNCj4gPiBAQCAtMCwwICsxLDE2IEBADQo+ID4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVy OiBHUEwtMi4wLW9yLWxhdGVyICovICNpZm5kZWYNCj4gPiArX19BUkNIX0FSTV9NTV9NUFVfXyAj ZGVmaW5lIF9fQVJDSF9BUk1fTU1fTVBVX18NCj4gPiArDQo+ID4gKyNkZWZpbmUgc2V0dXBfbW1f bWFwcGluZ3MoYm9vdF9waHlzX29mZnNldCkNCj4gPiArKCh2b2lkKShib290X3BoeXNfb2Zmc2V0 KSkNCj4gPiArDQo+ID4gKyNlbmRpZiAvKiBfX0FSQ0hfQVJNX01NX01QVV9fICovDQo+ID4gKw0K PiA+ICsvKg0KPiA+ICsgKiBMb2NhbCB2YXJpYWJsZXM6DQo+ID4gKyAqIG1vZGU6IEMNCj4gPiAr ICogYy1maWxlLXN0eWxlOiAiQlNEIg0KPiA+ICsgKiBjLWJhc2ljLW9mZnNldDogNA0KPiA+ICsg KiBpbmRlbnQtdGFicy1tb2RlOiBuaWwNCj4gPiArICogRW5kOg0KPiA+ICsgKi8NCj4gPiBkaWZm IC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYyBpbmRl eA0KPiA+IDFmMjZmNjdiOTAuLmQ3ZDIwMDE3OWMgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gv YXJtL3NldHVwLmMNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiA+IEBAIC0xMDAz LDcgKzEwMDMsNyBAQCB2b2lkIF9faW5pdCBzdGFydF94ZW4odW5zaWduZWQgbG9uZw0KPiBib290 X3BoeXNfb2Zmc2V0LA0KPiA+ICAgICAgIC8qIEluaXRpYWxpemUgdHJhcHMgZWFybHkgYWxsb3cg dXMgdG8gZ2V0IGJhY2t0cmFjZSB3aGVuIGFuIGVycm9yIG9jY3VycmVkDQo+ICovDQo+ID4gICAg ICAgaW5pdF90cmFwcygpOw0KPiA+DQo+ID4gLSAgICBzZXR1cF9wYWdldGFibGVzKGJvb3RfcGh5 c19vZmZzZXQpOw0KPiA+ICsgICAgc2V0dXBfbW1fbWFwcGluZ3MoYm9vdF9waHlzX29mZnNldCk7 DQo+IA0KPiBZb3UgYXJlIHJlbmFtaW5nIHRoZSBjYWxsZXIgYnV0IG5vdCB0aGUgZnVuY3Rpb24u IFdoeT8NCj4gDQoNCkl0IGlzIGEgcmVvcmcgbWlzdGFrZS4gIE1NVS1yZWxhdGVkIGltcGxlbWVu dGF0aW9uIGhhcyBiZWVuIG1pc3Rha2VubHkNCnB1dCBpbiBwcmV2aW91cyBjb21taXQgIltQQVRD SCB2MiAxNS80MF0geGVuL2FybTogbW92ZSBNTVUtc3BlY2lmaWMNCm1lbW9yeSBtYW5hZ2VtZW50 IGNvZGUgdG8gbW1fbW11LmMvbW1fbW11LmgiKGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcv YXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAyMy0wMS9tc2cwMDc3Ni5odG1sICkNClNvcnJ5IGZv ciB0aGF0Lg0KSSdsbCBleHRyYWN0IHRoZSByZWxhdGl2ZSBjb2RlcyBmcm9tIHRoZSBwcmV2aW91 cyBjb21taXQ6DQonJycNCisvKiBCb290LXRpbWUgcGFnZXRhYmxlIHNldHVwICovDQorI2RlZmlu ZSBzZXR1cF9tbV9tYXBwaW5ncyhib290X3BoeXNfb2Zmc2V0KSBzZXR1cF9wYWdldGFibGVzKGJv b3RfcGh5c19vZmZzZXQpDQonJycNCg0KPiA+DQo+ID4gICAgICAgc21wX2NsZWFyX2NwdV9tYXBz KCk7DQo+ID4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue Feb 07 05:08:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 05:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490860.759740 (Exim 4.92) (envelope-from ) id 1pPGDj-000721-0Q; Tue, 07 Feb 2023 05:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490860.759740; Tue, 07 Feb 2023 05:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPGDi-00071u-Ty; Tue, 07 Feb 2023 05:08:42 +0000 Received: by outflank-mailman (input) for mailman id 490860; Tue, 07 Feb 2023 05:08:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPGDi-00071o-3b for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 05:08:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ad3d900-a6a5-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 06:08:38 +0100 (CET) Received: from DB6PR07CA0170.eurprd07.prod.outlook.com (2603:10a6:6:43::24) by DB4PR08MB9333.eurprd08.prod.outlook.com (2603:10a6:10:3f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Tue, 7 Feb 2023 05:08:07 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::ac) by DB6PR07CA0170.outlook.office365.com (2603:10a6:6:43::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 05:08:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Tue, 7 Feb 2023 05:08:07 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Tue, 07 Feb 2023 05:08:07 +0000 Received: from 804c477540a4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A8ECE839-2908-4121-ACCC-A34975724923.1; Tue, 07 Feb 2023 05:07:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 804c477540a4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Feb 2023 05:07:57 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by AS4PR08MB7603.eurprd08.prod.outlook.com (2603:10a6:20b:4cd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Tue, 7 Feb 2023 05:07:54 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Tue, 7 Feb 2023 05:07:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ad3d900-a6a5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=El5gqzAjs0tLTnk4nu8rNjqFlBTKVoahck+qKfhqyUY=; b=deL8sRkO8BR4o8M8jPkzvL/WJKQy8uo3x5xM1EOjeqTavztKZa0w0UB/yDFbOfNqgAeB+4Tjm0kr8MSQ0e60Y6/2AuLh/AGvDvI8FTxonVL7EPXPfxOUdOsd5dmUrh6G0Jz3yL98GNodqxLgw1ZlJOxNtCNfPxyEZPwNAdzYZ3k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gNHyt9X1JtK43DMUZ/ZDJzKozPNlPR+hKeCM3cyrqJml7w+RmeiAmZNsNV1ME8YsnW8vqaB34JigSuzCmc4p9P/f72eof7YwrVhBiPWy+9zj2fbmmW/sWXYEF1+W0zVV09Tauws7qPoHcJFc0ZTBagW/eFQSF+WTjzn4497FGWDmhtfruYO67FyKWa4LxLy6PKs7Er2Q6dX13Lt3B5PQoXTooCbUFu5ZF0bnhQCR6CmqoGHKJwX3LhEU/fd0r2E56d7nWeRcCEAZoH3U/QNih32K6WDlqgMCccICNWMBr138QZVrzS0RInFiuOlqecwQVDsEuqas0ib3zrzevaCjXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=El5gqzAjs0tLTnk4nu8rNjqFlBTKVoahck+qKfhqyUY=; b=ZLChP5Jfa91BCWxhbaIazhyAG8oH9VCsDikN2Z/7gSuWPWpJAAuehE1eHnwlng5OCsBOnsUJwPu6YbKDhr/Uua5qHpCWUbFDiuqqx34qjwZjtGyGTNaU+s7Ebte5XcQ9RAuIaRfBe+a2+Jz2jenk7BV4BdcXKClj7N2xGCOkpHpvUigu1gMnM1YNDK1x1ymfPzqPez+aLyP27WD5pKdwnW7PyO7jW//AB7aq1tvan/NTvZJ/T/Tt9Hgk5cz/ZdmVcxp6ka054TLTaZ7MVQI5qOlZZEPwtQLfJMy8nRsT8xRuTKmnYtHtXNz7fr5Pyk5eh3KvCSB8V0bNyKlfMa94ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=El5gqzAjs0tLTnk4nu8rNjqFlBTKVoahck+qKfhqyUY=; b=deL8sRkO8BR4o8M8jPkzvL/WJKQy8uo3x5xM1EOjeqTavztKZa0w0UB/yDFbOfNqgAeB+4Tjm0kr8MSQ0e60Y6/2AuLh/AGvDvI8FTxonVL7EPXPfxOUdOsd5dmUrh6G0Jz3yL98GNodqxLgw1ZlJOxNtCNfPxyEZPwNAdzYZ3k= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 19/40] xen/mpu: populate a new region in Xen MPU mapping table Thread-Topic: [PATCH v2 19/40] xen/mpu: populate a new region in Xen MPU mapping table Thread-Index: AQHZJxAyhm/BFklSvUiEwXIvodABZq7BCEGAgAIHbzA= Date: Tue, 7 Feb 2023 05:07:46 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-20-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9019E052A7CA394DA6C71419DE71E7A9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|AS4PR08MB7603:EE_|DBAEUR03FT060:EE_|DB4PR08MB9333:EE_ X-MS-Office365-Filtering-Correlation-Id: bace2081-5419-4e6b-d60f-08db08c94cdb x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zB7FM2uqv87m3EJKD4tL5RW98Gn5W5y70ls0Gc9mOHFcH3g/w54qaILG4ibt4x0doB14xLvZaNzcZn+kI2Z/bHDysXNTNZaU09D9ILp9kPAA4pcmiTgnGkMMV1jI2H0mMw6DyTOU19IlMY3z5ZjwK+2scWZNM+XhXCkCxnkdr5SXi3/UJhXtdxHAJG1b/eeLDcwGg8s0FX+0vqiaRB/TwW7XyapHHIYIzYPLXeEpqwUb+o/t7xP8VoN2LSj+wzZqx+ZeMryBiCV1v89lUphIIfv4qYAnpFZV7LEEIMz1Gm6vrOe9Gm+PACHNct8mWZU12Aq9ujdmo9O40XC6oahbCdxgs3BnU1T50564qViDpMtfeAf8yBwzzD32kBNIZMf1BGJ+4ZJP5lpSjAugb4mDGFJQQwziExOYmGio7YcrsZdyDILndRcm7uBZ7ZEBucGQ3kicgHVv7SIz5T59PaqZQ+lgoc0g3fdEUzlJfv9DbpiugtvYn5CX7obxI4hCrHpvVIGCXLMoNieJseSYI7G9xttBYki+ILZfwZfZGkdWvLeUd00F9bZsOr29vTRYCENlxmpWHuxEZQblm0Tev3eBbAqtLr6gw2wUX9ntr46OXY7juTx9KXlJjywXNCYouNmtAdHYpU5ydONTRPJyawpcmUi0geNsM64cqcLzi1MnX9XXPHFlN+ehuOTQ05tJEAUdr0kd4FGt7Kk74rkAMEUORg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(451199018)(186003)(6506007)(26005)(9686003)(7696005)(53546011)(86362001)(38070700005)(33656002)(83380400001)(71200400001)(478600001)(2906002)(110136005)(8676002)(316002)(54906003)(4326008)(76116006)(122000001)(38100700002)(66446008)(66476007)(64756008)(66556008)(41300700001)(8936002)(5660300002)(52536014)(66946007)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7603 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0b1392be-6370-49f7-2c38-08db08c94038 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3RWU5uZb1jcDbqgiBCAFGbSZORZjbnnXncIUdiPoimfWYjfo18Y6ztcCkVYEH+zun7iBsfVzSF49reNdozvIkkoJ1SMWyZuty1QmnCD9ZBCsxD9RgJp2k8yzeeKZTuxxdkFu0QNJIzp2Y3Yasnqe/0lD6K1T1LBsKtkQAnlxbkmzIWjbx3lyzvEAA/noDkaNe6x4gFIl/JAMDkKmGfyJhE1EJ1VocPqr5AdkeqCLhNl9SHQ2QesOX4GXjRocZPIVaVl7rgpvZNULpgu7BQQeVr36bKZh8JaVsqLT63oXXe4LKb9zf//lPgZ+dZNroztd0TekN1k6a+n09pDLNYVSr2qtjgYu5Auukrnv8+i0faK3/UNKapoDRRAas3ZJj59l2GtZgy7KGz0swfzK4Lh7Fy5UEq31uqRR4SshWbytwjIIz86jRZnGdAxD5IazCGYgILWpU47n8cUVLFGzolgwTvIk0RLfRdLy20YFFdFgfu2asv+KJ0X+Kf4lppTIklo6vC6v3dJv+MaDxgdYmfLFpU4uVGppqVOWrKQogafTnyYksHmoD2+At29BS3+kIb290AnoQF2bE/ZxDTtX54QhjZAGMZyTvXWDbikTvSwbG8DpsOKe4RWj1fbOrVeT8AxtXmF7Scukj6r4w0L93EWtsqBbC2YZnRZ0UDskaaLiR4BvQj7gbsRkv2kZlEquUqLpqgdQbE9RMcqsAk8A5M1zyg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199018)(36840700001)(40470700004)(46966006)(110136005)(36860700001)(33656002)(7696005)(356005)(40480700001)(55016003)(82310400005)(81166007)(82740400003)(86362001)(2906002)(70586007)(316002)(4326008)(70206006)(8676002)(40460700003)(8936002)(52536014)(5660300002)(47076005)(336012)(54906003)(83380400001)(26005)(9686003)(6506007)(41300700001)(186003)(53546011)(478600001)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 05:08:07.3981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bace2081-5419-4e6b-d60f-08db08c94cdb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9333 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBGZWJydWFyeSA2LCAyMDIz IDU6NDYgQU0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJj aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2 MiAxOS80MF0geGVuL21wdTogcG9wdWxhdGUgYSBuZXcgcmVnaW9uIGluIFhlbiBNUFUNCj4gbWFw cGluZyB0YWJsZQ0KPiANCj4gSGksDQo+IA0KPiBPbiAxMy8wMS8yMDIzIDA1OjI4LCBQZW5ueSBa aGVuZyB3cm90ZToNCj4gPiBUaGUgbmV3IGhlbHBlciB4ZW5fbXB1bWFwX3VwZGF0ZSgpIGlzIHJl c3BvbnNpYmxlIGZvciB1cGRhdGluZyBhbg0KPiA+IGVudHJ5IGluIFhlbiBNUFUgbWVtb3J5IG1h cHBpbmcgdGFibGUsIGluY2x1ZGluZyBjcmVhdGluZyBhIG5ldyBlbnRyeSwNCj4gPiB1cGRhdGlu ZyBvciBkZXN0cm95aW5nIGFuIGV4aXN0aW5nIG9uZS4NCj4gPg0KPiA+IFRoaXMgY29tbWl0IG9u bHkgdGFsa3MgYWJvdXQgcG9wdWxhdGluZyBhIG5ldyBlbnRyeSBpbiBYZW4gTVBVIG1hcHBpbmcN Cj4gPiB0YWJsZSggeGVuX21wdW1hcCkuIE90aGVycyB3aWxsIGJlIGludHJvZHVjZWQgaW4gdGhl IGZvbGxvd2luZyBjb21taXRzLg0KPiA+DQo+ID4gSW4geGVuX21wdW1hcF91cGRhdGVfZW50cnko KSwgZmlyc3RseSwgd2Ugc2hhbGwgY2hlY2sgaWYgcmVxdWVzdGVkDQo+ID4gYWRkcmVzcyByYW5n ZSBbYmFzZSwgbGltaXQpIGlzIG5vdCBtYXBwZWQuIFRoZW4gd2UgdXNlIHByX29mX3hlbmFkZHIo KQ0KPiA+IHRvIGJ1aWxkIHVwIHRoZSBzdHJ1Y3R1cmUgb2YgTVBVIG1lbW9yeSByZWdpb24ocHJf dCkuDQo+ID4gSW4gdGhlIGxhc3QsIHdlIHNldCBtZW1vcnkgYXR0cmlidXRlIGFuZCBwZXJtaXNz aW9uIGJhc2VkIG9uIHZhcmlhYmxlDQo+IEBmbGFncy4NCj4gPg0KPiA+IFRvIHN1bW1hcml6ZSBh bGwgcmVnaW9uIGF0dHJpYnV0ZXMgaW4gb25lIHZhcmlhYmxlIEBmbGFncywgbGF5b3V0IG9mDQo+ ID4gdGhlIGZsYWdzIGlzIGVsYWJvcmF0ZWQgYXMgZm9sbG93czoNCj4gPiBbMDoyXSBNZW1vcnkg YXR0cmlidXRlIEluZGV4DQo+ID4gWzM6NF0gRXhlY3V0ZSBOZXZlcg0KPiA+IFs1OjZdIEFjY2Vz cyBQZXJtaXNzaW9uDQo+ID4gWzddICAgUmVnaW9uIFByZXNlbnQNCj4gPiBBbHNvLCB3ZSBwcm92 aWRlIGEgc2V0IG9mIGRlZmluaXRpb25zKFJFR0lPTl9IWVBFUlZJU09SX1JXLCBldGMpIHRoYXQN Cj4gPiBjb21iaW5lIHRoZSBtZW1vcnkgYXR0cmlidXRlIGFuZCBwZXJtaXNzaW9uIGZvciBjb21t b24gY29tYmluYXRpb25zLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBl bm55LnpoZW5nQGFybS5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVu QGFybS5jb20+DQo+ID4gLS0tDQo+ID4gICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQv bXB1LmggfCAgNzIgKysrKysrKw0KPiA+ICAgeGVuL2FyY2gvYXJtL21tX21wdS5jICAgICAgICAg ICAgICAgIHwgMjc2ICsrKysrKysrKysrKysrKysrKysrKysrKysrLQ0KPiA+ICAgMiBmaWxlcyBj aGFuZ2VkLCAzNDAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkNCj4gPg0KWy4uLl0NCj4g PiArDQo+ID4gKyNkZWZpbmUgTVBVTUFQX1JFR0lPTl9GQUlMRUQgICAgMA0KPiA+ICsjZGVmaW5l IE1QVU1BUF9SRUdJT05fRk9VTkQgICAgIDENCj4gPiArI2RlZmluZSBNUFVNQVBfUkVHSU9OX0lO Q0xVU0lWRSAyDQo+ID4gKyNkZWZpbmUgTVBVTUFQX1JFR0lPTl9PVkVSTEFQICAgMw0KPiA+ICsN Cj4gPiArLyoNCj4gPiArICogQ2hlY2sgd2hldGhlciBtZW1vcnkgcmFuZ2UgW2Jhc2UsIGxpbWl0 XSBpcyBtYXBwZWQgaW4gTVBVIG1lbW9yeQ0KPiA+ICsgKiByZWdpb24gdGFibGUgXG1wdS4gT25s eSBhZGRyZXNzIHJhbmdlIGlzIGNvbnNpZGVyZWQsIG1lbW9yeQ0KPiA+ICthdHRyaWJ1dGVzDQo+ ID4gKyAqIGFuZCBwZXJtaXNzaW9uIGFyZSBub3QgY29uc2lkZXJlZCBoZXJlLg0KPiA+ICsgKiBJ ZiB3ZSBmaW5kIHRoZSBtYXRjaCwgdGhlIGFzc29jaWF0ZWQgaW5kZXggd2lsbCBiZSBmaWxsZWQg dXAuDQo+ID4gKyAqIElmIHRoZSBlbnRyeSBpcyBub3QgcHJlc2VudCwgSU5WQUxJRF9SRUdJT04g d2lsbCBiZSBzZXQgaW4gXGluZGV4DQo+ID4gKyAqDQo+ID4gKyAqIE1ha2Ugc3VyZSB0aGF0IHBh cmFtZXRlciBcYmFzZSBhbmQgXGxpbWl0IGFyZSBib3RoIHJlZmVycmluZw0KPiA+ICsgKiBpbmNs dXNpdmUgYWRkcmVzc3MNCj4gPiArICoNCj4gPiArICogUmV0dXJuIHZhbHVlczoNCj4gPiArICog IE1QVU1BUF9SRUdJT05fRkFJTEVEOiBubyBtYXBwaW5nIGFuZCBubyBvdmVybWFwcGluZw0KPiA+ ICsgKiAgTVBVTUFQX1JFR0lPTl9GT1VORDogZmluZCBhbiBleGFjdCBtYXRjaCBpbiBhZGRyZXNz DQo+ID4gKyAqICBNUFVNQVBfUkVHSU9OX0lOQ0xVU0lWRTogZmluZCBhbiBpbmNsdXNpdmUgbWF0 Y2ggaW4gYWRkcmVzcw0KPiA+ICsgKiAgTVBVTUFQX1JFR0lPTl9PVkVSTEFQOiBvdmVybGFwIHdp dGggdGhlIGV4aXN0aW5nIG1hcHBpbmcgICovDQo+ID4gK3N0YXRpYyBpbnQgbXB1bWFwX2NvbnRh aW5fcmVnaW9uKHByX3QgKm1wdSwgdWludDY0X3QgbnJfcmVnaW9ucywNCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LA0KPiA+ ICt1aW50NjRfdCAqaW5kZXgpDQo+IA0KPiBJcyBpdCByZWFsbHkgcG9zc2libGUgdG8gc3VwcG9y dCAyXjY0IC0gMSByZWdpb24/IElmIHNvLCBpcyB0aGF0IHRoZSBjYXNlIG9uIGFybTMyDQo+IGFz IHdlbGw/DQo+IA0KDQpObywgdGhlIGFsbG93YWJsZSBiaXR3aWR0aCBpcyA4IGJpdC4gSSdsbCBj aGFuZ2UgaXQgdWludDhfdCBpbnN0ZWFkDQoNCj4gPiArew0KPiA+ICsgICAgdWludDY0X3QgaSA9 IDA7DQo+ID4gKyAgICB1aW50NjRfdCBfaW5kZXggPSBJTlZBTElEX1JFR0lPTjsNCj4gPiArDQo+ ID4gKyAgICAvKiBBbGxvdyBpbmRleCB0byBiZSBOVUxMICovDQo+ID4gKyAgICBpbmRleCA9IGlu ZGV4ID86ICZfaW5kZXg7DQo+ID4gKw0KPiA+ICsgICAgZm9yICggOyBpIDwgbnJfcmVnaW9uczsg aSsrICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwYWRkcl90IGl0ZXJfYmFzZSA9IHByX2dl dF9iYXNlKCZtcHVbaV0pOw0KPiA+ICsgICAgICAgIHBhZGRyX3QgaXRlcl9saW1pdCA9IHByX2dl dF9saW1pdCgmbXB1W2ldKTsNCj4gPiArDQo+ID4gKyAgICAgICAgLyogRm91bmQgYW4gZXhhY3Qg dmFsaWQgbWF0Y2ggKi8NCj4gPiArICAgICAgICBpZiAoIChpdGVyX2Jhc2UgPT0gYmFzZSkgJiYg KGl0ZXJfbGltaXQgPT0gbGltaXQpICYmDQo+ID4gKyAgICAgICAgICAgICByZWdpb25faXNfdmFs aWQoJm1wdVtpXSkgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgKmluZGV4ID0g aTsNCj4gPiArICAgICAgICAgICAgcmV0dXJuIE1QVU1BUF9SRUdJT05fRk9VTkQ7DQo+ID4gKyAg ICAgICAgfQ0KPiA+ICsNCj4gPiArICAgICAgICAvKiBObyBvdmVybGFwcGluZyAqLw0KPiA+ICsg ICAgICAgIGlmICggKGl0ZXJfbGltaXQgPCBiYXNlKSB8fCAoaXRlcl9iYXNlID4gbGltaXQpICkN Cj4gPiArICAgICAgICAgICAgY29udGludWU7DQo+ID4gKyAgICAgICAgLyogSW5jbHVzaXZlIGFu ZCB2YWxpZCAqLw0KPiA+ICsgICAgICAgIGVsc2UgaWYgKCAoYmFzZSA+PSBpdGVyX2Jhc2UpICYm IChsaW1pdCA8PSBpdGVyX2xpbWl0KSAmJg0KPiA+ICsgICAgICAgICAgICAgICAgICByZWdpb25f aXNfdmFsaWQoJm1wdVtpXSkgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgKmlu ZGV4ID0gaTsNCj4gPiArICAgICAgICAgICAgcmV0dXJuIE1QVU1BUF9SRUdJT05fSU5DTFVTSVZF Ow0KPiA+ICsgICAgICAgIH0NCj4gPiArICAgICAgICBlbHNlDQo+ID4gKyAgICAgICAgew0KPiA+ ICsgICAgICAgICAgICByZWdpb25fcHJpbnRrKCJSYW5nZSAweCUiUFJJcGFkZHIiIC0gMHglIlBS SXBhZGRyIiBvdmVybGFwcw0KPiB3aXRoIHRoZSBleGlzdGluZyByZWdpb24gMHglIlBSSXBhZGRy IiAtIDB4JSJQUklwYWRkciJcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgYmFz ZSwgbGltaXQsIGl0ZXJfYmFzZSwgaXRlcl9saW1pdCk7DQo+ID4gKyAgICAgICAgICAgIHJldHVy biBNUFVNQVBfUkVHSU9OX09WRVJMQVA7DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsgICAgfQ0KPiA+ ICsNCj4gPiArICAgIHJldHVybiBNUFVNQVBfUkVHSU9OX0ZBSUxFRDsNCj4gPiArfQ0KPiA+ICsN Cj4gPiArLyoNCj4gPiArICogVXBkYXRlIGFuIGVudHJ5IGF0IHRoZSBpbmRleCBAaWR4Lg0KPiA+ ICsgKiBAYmFzZTogIGJhc2UgYWRkcmVzcw0KPiA+ICsgKiBAbGltaXQ6IGxpbWl0IGFkZHJlc3Mo ZXhjbHVzaXZlKQ0KPiA+ICsgKiBAZmxhZ3M6IHJlZ2lvbiBhdHRyaWJ1dGVzLCBzaG91bGQgYmUg dGhlIGNvbWJpbmF0aW9uIG9mDQo+ID4gK1JFR0lPTl9IWVBFUlZJU09SX3h4ICAqLyBzdGF0aWMg aW50DQo+IHhlbl9tcHVtYXBfdXBkYXRlX2VudHJ5KHBhZGRyX3QNCj4gPiArYmFzZSwgcGFkZHJf dCBsaW1pdCwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25l ZCBpbnQgZmxhZ3MpIHsNCj4gPiArICAgIHVpbnQ2NF90IGlkeDsNCj4gPiArICAgIGludCByYzsN Cj4gPiArDQo+ID4gKyAgICByYyA9IG1wdW1hcF9jb250YWluX3JlZ2lvbih4ZW5fbXB1bWFwLCBt YXhfeGVuX21wdW1hcCwgYmFzZSwNCj4gbGltaXQgLSAxLA0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJmlkeCk7DQo+ID4gKyAgICBpZiAoIHJjID09IE1QVU1BUF9SRUdJT05f T1ZFUkxBUCApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsgICAg LyogV2UgYXJlIGluc2VydGluZyBhIG1hcHBpbmcgPT4gQ3JlYXRlIG5ldyByZWdpb24uICovDQo+ ID4gKyAgICBpZiAoIGZsYWdzICYgX1JFR0lPTl9QUkVTRU5UICkNCj4gPiArICAgIHsNCj4gPiAr ICAgICAgICBpZiAoIHJjICE9IE1QVU1BUF9SRUdJT05fRkFJTEVEICkNCj4gPiArICAgICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsgICAgICAgIGlmICggeGVuX2Jvb3RfbXB1 X3JlZ2lvbnNfaXNfZnVsbCgpICkNCj4gPiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIHJl Z2lvbl9wcmludGsoIlRoZXJlIGlzIG5vIHJvb20gbGVmdCBpbiBFTDIgTVBVIG1lbW9yeSByZWdp b24NCj4gbWFwcGluZ1xuIik7DQo+ID4gKyAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiA+ ICsgICAgICAgIH0NCj4gPiArDQo+ID4gKyAgICAgICAgLyogRHVyaW5nIGJvb3QgdGltZSwgdGhl IGRlZmF1bHQgaW5kZXggaXMgbmV4dF9maXhlZF9yZWdpb25faWR4LiAqLw0KPiA+ICsgICAgICAg IGlmICggc3lzdGVtX3N0YXRlIDw9IFNZU19TVEFURV9hY3RpdmUgKQ0KPiA+ICsgICAgICAgICAg ICBpZHggPSBuZXh0X2ZpeGVkX3JlZ2lvbl9pZHg7DQo+ID4gKw0KPiA+ICsgICAgICAgIHhlbl9t cHVtYXBbaWR4XSA9IHByX29mX3hlbmFkZHIoYmFzZSwgbGltaXQgLSAxLA0KPiBSRUdJT05fQUlf TUFTSyhmbGFncykpOw0KPiA+ICsgICAgICAgIC8qIFNldCBwZXJtaXNzaW9uICovDQo+ID4gKyAg ICAgICAgeGVuX21wdW1hcFtpZHhdLnByYmFyLnJlZy5hcCA9IFJFR0lPTl9BUF9NQVNLKGZsYWdz KTsNCj4gPiArICAgICAgICB4ZW5fbXB1bWFwW2lkeF0ucHJiYXIucmVnLnhuID0gUkVHSU9OX1hO X01BU0soZmxhZ3MpOw0KPiA+ICsNCj4gPiArICAgICAgICAvKiBVcGRhdGUgYW5kIGVuYWJsZSB0 aGUgcmVnaW9uICovDQo+ID4gKyAgICAgICAgYWNjZXNzX3Byb3RlY3Rpb25fcmVnaW9uKGZhbHNl LCBOVUxMLCAoY29uc3QNCj4gcHJfdCopKCZ4ZW5fbXB1bWFwW2lkeF0pLA0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpZHgpOw0KPiA+ICsNCj4gPiArICAgICAgICBpZiAo IHN5c3RlbV9zdGF0ZSA8PSBTWVNfU1RBVEVfYWN0aXZlICkNCj4gPiArICAgICAgICAgICAgdXBk YXRlX2Jvb3RfeGVuX21wdW1hcF9pZHgoaWR4KTsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAg ICByZXR1cm4gMDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCB4ZW5fbXB1bWFwX3Vw ZGF0ZShwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIHVuc2lnbmVkDQo+ID4gK2ludCBmbGFn cykgew0KPiA+ICsgICAgaW50IHJjOw0KPiA+ICsNCj4gPiArICAgIC8qDQo+ID4gKyAgICAgKiBU aGUgaGFyZHdhcmUgd2FzIGNvbmZpZ3VyZWQgdG8gZm9yYmlkIG1hcHBpbmcgYm90aCB3cml0ZWFi bGUgYW5kDQo+ID4gKyAgICAgKiBleGVjdXRhYmxlLg0KPiA+ICsgICAgICogV2hlbiBtb2RpZnlp bmcvY3JlYXRpbmcgbWFwcGluZyAoaS5lIF9SRUdJT05fUFJFU0VOVCBpcyBzZXQpLA0KPiA+ICsg ICAgICogcHJldmVudCBhbnkgdXBkYXRlIGlmIHRoaXMgaGFwcGVuLg0KPiA+ICsgICAgICovDQo+ ID4gKyAgICBpZiAoIChmbGFncyAmIF9SRUdJT05fUFJFU0VOVCkgJiYgIVJFR0lPTl9ST19NQVNL KGZsYWdzKSAmJg0KPiA+ICsgICAgICAgICAhUkVHSU9OX1hOX01BU0soZmxhZ3MpICkNCj4gPiAr ICAgIHsNCj4gPiArICAgICAgICByZWdpb25fcHJpbnRrKCJNYXBwaW5ncyBzaG91bGQgbm90IGJl IGJvdGggV3JpdGVhYmxlIGFuZA0KPiBFeGVjdXRhYmxlLlxuIik7DQo+ID4gKyAgICAgICAgcmV0 dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhSVNfQUxJR05F RChiYXNlLCBQQUdFX1NJWkUpIHx8ICFJU19BTElHTkVEKGxpbWl0LCBQQUdFX1NJWkUpICkNCj4g PiArICAgIHsNCj4gPiArICAgICAgICByZWdpb25fcHJpbnRrKCJiYXNlIGFkZHJlc3MgMHglIlBS SXBhZGRyIiwgb3IgbGltaXQgYWRkcmVzcw0KPiAweCUiUFJJcGFkZHIiIGlzIG5vdCBwYWdlIGFs aWduZWQuXG4iLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgYmFzZSwgbGltaXQpOw0KPiA+ ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIHNw aW5fbG9jaygmeGVuX21wdW1hcF9sb2NrKTsNCj4gPiArDQo+ID4gKyAgICByYyA9IHhlbl9tcHVt YXBfdXBkYXRlX2VudHJ5KGJhc2UsIGxpbWl0LCBmbGFncyk7DQo+ID4gKw0KPiA+ICsgICAgc3Bp bl91bmxvY2soJnhlbl9tcHVtYXBfbG9jayk7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIHJjOw0K PiA+ICt9DQo+ID4gKw0KPiA+ICtpbnQgbWFwX3BhZ2VzX3RvX3hlbih1bnNpZ25lZCBsb25nIHZp cnQsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwNCj4gPiArICAgICAgICAg ICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBucl9tZm5zLA0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MpIHsNCj4gPiArICAgIEFTU0VSVCh2aXJ0ID09IG1mbl90 b19tYWRkcihtZm4pKTsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4geGVuX21wdW1hcF91cGRhdGUo bWZuX3RvX21hZGRyKG1mbiksDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZu X3RvX21hZGRyKG1mbl9hZGQobWZuLCBucl9tZm5zKSksDQo+ID4gK2ZsYWdzKTsgfQ0KPiA+ICsN Cj4gPiAgIC8qIFRPRE86IEltcGxlbWVudGF0aW9uIG9uIHRoZSBmaXJzdCB1c2FnZSAqLw0KPiA+ ICAgdm9pZCBkdW1wX2h5cF93YWxrKHZhZGRyX3QgYWRkcikNCj4gPiAgIHsNCj4gPiBAQCAtMjMw LDE0ICs0OTgsNiBAQCB2b2lkICppb3JlbWFwKHBhZGRyX3QgcGEsIHNpemVfdCBsZW4pDQo+ID4g ICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gICB9DQo+ID4NCj4gPiAtaW50IG1hcF9wYWdlc190b194 ZW4odW5zaWduZWQgbG9uZyB2aXJ0LA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICBtZm5fdCBt Zm4sDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbnJfbWZucywNCj4g PiAtICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWdzKQ0KPiA+IC17DQo+ID4g LSAgICByZXR1cm4gLUVOT1NZUzsNCj4gPiAtfQ0KPiA+IC0NCj4gDQo+IFdoeSBkbyB5b3UgaW1w bGVtZW50IG1hcF9wYWdlc190b194ZW4oKSBhdCBhIGRpZmZlcmVudCBwbGFjZT8NCj4gDQo+IA0K PiA+ICAgaW50IGRlc3Ryb3lfeGVuX21hcHBpbmdzKHVuc2lnbmVkIGxvbmcgcywgdW5zaWduZWQg bG9uZyBlKQ0KPiA+ICAgew0KPiA+ICAgICAgIHJldHVybiAtRU5PU1lTOw0KPiANCj4gQ2hlZXJz LA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Feb 07 06:16:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 06:16:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490870.759752 (Exim 4.92) (envelope-from ) id 1pPHGK-0006ev-0Z; Tue, 07 Feb 2023 06:15:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490870.759752; Tue, 07 Feb 2023 06:15:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPHGJ-0006eo-U4; Tue, 07 Feb 2023 06:15:27 +0000 Received: by outflank-mailman (input) for mailman id 490870; Tue, 07 Feb 2023 06:15:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPHGI-0006ei-NS for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 06:15:27 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce17a60e-a6ae-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 07:15:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6F645C0143; Tue, 7 Feb 2023 01:15:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 07 Feb 2023 01:15:22 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 01:15:20 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce17a60e-a6ae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675750522; x= 1675836922; bh=3lcBQME6MxRrUUK7wACIPcbp0M8UXo7emK3UQbich5k=; b=W iMbmAWFclTpShDffpBOLo6MdlVXzsBNuvAq3SmV+9BXCowJzwgWHu5o0S5vnQRV0 FULWE0oseBOYjoJAzukO2g/9zuywwxuEwijvOyUBWTSNeIyfygNjFyD5TGmhufol Yl0ld/RzcxvZTOmmY7Q3GMciRi5SHjyba5vFDLTI01ZZ185mWUTJWZ1wMZXWVKS9 GBtdgdtZsiep+E6npEzY9L16Y0IzABCwo4nbkrLX6c+yckVPqRLyIZCw0t1KxCqr iA90f5PoyFeKLJFqoTL7lT3++YeMvkuHyjDOvMgNB/oj59bFVQ2gc847xGr5JI7K CrEK10k0VDgQQj49lAF2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675750522; x=1675836922; bh=3lcBQME6MxRrUUK7wACIPcbp0M8U Xo7emK3UQbich5k=; b=kjomZON+S4yDUOMakksa8Gft04CJl6wLq1ln1yFWDgdg bA4Sj/PCDpJP/rYI70p34qTOUxDJMepuVZWEpN9l4S3UglVtcm7FHgQTYuIlUivS thAct9z2jfz8ekA8krcfIxX3Ax0hlFldRDSCurPWDvO7icBJ21P14ftPYbqEo0zQ yhjlDxjcBYmjtTbvLuCYcrxNO38xL5rTLaygyi3VufvF0Bm5u4annmS/fPXl7H+Y KcbrY2IWZWiMzjXAlVrELQ9/sOPJ7sbrxzDnkXNwOb6ISzcpOErjB2NsXRhiQpDY bFhMUn9GD4UowJ4cOQDXMnocudJANs/+qmo8b98/Uw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegjedgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleeuueeihfehteeifffggeehtdeg ueelffetgeeggeekteffuefhfefhkeefvdehnecuffhomhgrihhnpeigvghnrdhorhhgpd hllhhvmhdrohhrghdpghhithhlrggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 7 Feb 2023 01:15:14 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH] Replace git:// and http:// with https:// Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h0L6L6myaQYfPp28" Content-Disposition: inline In-Reply-To: --h0L6L6myaQYfPp28 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 7 Feb 2023 01:15:14 -0500 From: Demi Marie Obenour To: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Samuel Thibault , Anthony PERARD , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH] Replace git:// and http:// with https:// On Tue, Feb 07, 2023 at 05:16:21AM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Mon, Feb 06, 2023 at 10:10:33PM -0500, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > >=20 > > This patch was created by doing a tree-wide search and replace with sed, > > then reverting changes that were pointless or wrong. > >=20 > > Signed-off-by: Demi Marie Obenour > > --- > > Config.mk | 20 ++++++-------------- > > README | 4 ++-- > > automation/build/centos/CentOS-7.2.repo | 8 ++++---- > > automation/build/debian/stretch-llvm-8.list | 4 ++-- > > automation/build/debian/unstable-llvm-8.list | 4 ++-- > > automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- > > docs/README.remus | 2 +- > > docs/conf.py | 2 +- > > scripts/get_maintainer.pl | 2 +- > > stubdom/configure | 18 +++++++++--------- > > stubdom/configure.ac | 18 +++++++++--------- > > stubdom/grub.patches/10graphics.diff | 2 +- > > tools/examples/xeninfo.pl | 2 +- > > tools/firmware/etherboot/Makefile | 4 ++-- > > tools/firmware/etherboot/README | 2 +- > > tools/firmware/hvmloader/pci_regs.h | 2 +- > > tools/firmware/hvmloader/pir.c | 2 +- > > tools/firmware/hvmloader/pir_types.h | 2 +- > > tools/firmware/hvmloader/smbios_types.h | 2 +- > > 19 files changed, 47 insertions(+), 55 deletions(-) > >=20 > > diff --git a/Config.mk b/Config.mk > > index 10eb443b17d85381b2d1e2282f8965c3e99767e0..fd0719e38be1c679946c4d6= 77c0f0dbdb2a85411 100644 > > --- a/Config.mk > > +++ b/Config.mk > > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=3D $(foreach i, $(APPEND_INCLUDES),= -I$(i)) > > EMBEDDED_EXTRA_CFLAGS :=3D -fno-pie -fno-stack-protector -fno-stack-pr= otector-all > > EMBEDDED_EXTRA_CFLAGS +=3D -fno-exceptions -fno-asynchronous-unwind-ta= bles > > =20 > > -XEN_EXTFILES_URL ?=3D http://xenbits.xen.org/xen-extfiles > > +XEN_EXTFILES_URL ?=3D https://xenbits.xen.org/xen-extfiles > > # All the files at that location were downloaded from elsewhere on > > # the internet. The original download URL is preserved as a comment > > # near the place in the Xen Makefiles where the file is used. > > @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) > > QEMU_TRADITIONAL_REVISION ?=3D $(QEMU_TAG) > > endif > > =20 > > -ifeq ($(GIT_HTTP),y) > > -OVMF_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/ovmf.git > > -QEMU_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/qemu-xen.git > > -QEMU_TRADITIONAL_URL ?=3D http://xenbits.xen.org/git-http/qemu-xen-tra= ditional.git > > -SEABIOS_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/seabios.git > > -MINIOS_UPSTREAM_URL ?=3D http://xenbits.xen.org/git-http/mini-os.git > > -else > > -OVMF_UPSTREAM_URL ?=3D git://xenbits.xen.org/ovmf.git > > -QEMU_UPSTREAM_URL ?=3D git://xenbits.xen.org/qemu-xen.git > > -QEMU_TRADITIONAL_URL ?=3D git://xenbits.xen.org/qemu-xen-traditional.g= it > > -SEABIOS_UPSTREAM_URL ?=3D git://xenbits.xen.org/seabios.git > > -MINIOS_UPSTREAM_URL ?=3D git://xenbits.xen.org/mini-os.git > > -endif > > +OVMF_UPSTREAM_URL ?=3D https://xenbits.xen.org/ovmf.git > > +QEMU_UPSTREAM_URL ?=3D https://xenbits.xen.org/qemu-xen.git > > +QEMU_TRADITIONAL_URL ?=3D https://xenbits.xen.org/qemu-xen-traditional= =2Egit > > +SEABIOS_UPSTREAM_URL ?=3D https://xenbits.xen.org/seabios.git > > +MINIOS_UPSTREAM_URL ?=3D https://xenbits.xen.org/mini-os.git >=20 > xenbits http server has git under /git-http/, so you need to adjust URLs > when changing the protocol. Verify if all other URLs in this patch > actually work too. New version coming with what I believe to be fixed URLs for everything except the TPM emulator. The TPM emulator was originally hosted on BerliOS, which I believe no longer exists, so it only makes sense to download it from Xen=E2=80=99s own servers. I=E2=80=99ll fail the build if= an attempt is made to download it from the original (now defunct) website. > > diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/b= uild/debian/stretch-llvm-8.list > > index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba91= 85423adf4b0c51a21 100644 > > --- a/automation/build/debian/stretch-llvm-8.list > > +++ b/automation/build/debian/stretch-llvm-8.list > > @@ -1,3 +1,3 @@ > > # Strech LLVM 8 repos > > -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > > -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > > +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main > > +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main >=20 > APT used to require extra package (apt-transport-https) to support > HTTPS (I'm pretty sure it applies to stretch, but probably not to > unstable). And also, it needs ca-certificates installed. So, this may > require some more work before switching the protocol. You can observe > https://gitlab.com/xen-project/patchew/xen/-/pipelines if/when gitlab > picks it up, to see if everything still works. Will do. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --h0L6L6myaQYfPp28 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPh7HcACgkQsoi1X/+c IsHgsRAAuOdK+iEggOqRlVD4kNqUOQHTF0xTF4gaMjoXLFp5u2IjxFxkM8fPfeg3 bC9T1BdIvPtkPa9rWrsov83gloiKVfcgiFihxqMfUQJDHaFlSn44qcXqt2DEPTgH EeWt8CU4ZXEKkBcC16qUHUWBNaxNAgjtbWTiXWRwAQ7r9AHugYjrWcMHH9U153fm 82QPge6keXn02y8sXG93Ai93g6bIqbuRoffDFM3XPZsGxZbnu+XfGTv+eImMuQA1 qOSdsdiK+vRmnuj0YY1PcWdtkbbABVhCFKVmpb9TP40zRHYX7mrnZI4cPH6K+BHm /2I/6+cYEvwkTM263vXnQBwwD8xPjdvHBvh/USuXb7IpVZIyAyUcqnVLn/yi8Rgd 6iJaukw9renxVpA25sGEuBYhMgAvOTnPdmKFZ7b1b0BOJmYbGxqp3ll5RSVzs6qq HKFa+lH9F08tXTtZYlr3eT+hkNI9yuuFByeSipNQtaYpvXDhtKMQ9q/tGo4Z/4QM 5us0LzOTeCFO5otJ9IRPj1lWHfvoCXB8uyrHdqUvu4GUSl0Ohpw8Ad8Db/W7T2At 8wSGs6sEHJ0zhkz2VlAAbwG91O/DTwG9SKdek9iad8zZMwqbfEl1er+jMK99ezzv vwaSjzOIvbIoUQUrUQadTY3aP127oWSiwmQSDHwRBAQvzI/EkiQ= =6vm5 -----END PGP SIGNATURE----- --h0L6L6myaQYfPp28-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 06:31:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 06:31:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490880.759770 (Exim 4.92) (envelope-from ) id 1pPHVa-0000iy-Iz; Tue, 07 Feb 2023 06:31:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490880.759770; Tue, 07 Feb 2023 06:31:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPHVa-0000ir-D1; Tue, 07 Feb 2023 06:31:14 +0000 Received: by outflank-mailman (input) for mailman id 490880; Tue, 07 Feb 2023 06:31:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPHVZ-0000if-1P for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 06:31:13 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20616.outbound.protection.outlook.com [2a01:111:f400:fe13::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02bb9373-a6b1-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 07:31:11 +0100 (CET) Received: from DUZPR01CA0229.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::26) by DB5PR08MB10162.eurprd08.prod.outlook.com (2603:10a6:10:4a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Tue, 7 Feb 2023 06:30:56 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b4:cafe::17) by DUZPR01CA0229.outlook.office365.com (2603:10a6:10:4b4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 06:30:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Tue, 7 Feb 2023 06:30:55 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Tue, 07 Feb 2023 06:30:55 +0000 Received: from c2b6cc3dd1a8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DEF4EABC-8220-438D-A633-CBA2DB40BB13.1; Tue, 07 Feb 2023 06:30:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c2b6cc3dd1a8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Feb 2023 06:30:49 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by PA4PR08MB6142.eurprd08.prod.outlook.com (2603:10a6:102:ee::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 06:30:37 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6064.025; Tue, 7 Feb 2023 06:30:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02bb9373-a6b1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBX6WIPprRbeDcEysvckpxtaMitb4BjzUgmDZzHmKms=; b=pHJ+4RcrWD4e0KX0AZ0/Dtt+Qz2aPdHx1r9NAq3vvC3Fefhq7Zqdq7/DSFrzmJgx9mDmT3ksTkF3a3O2BZ4uesnXQx823q1Y7ZiXWPGAKAd7IgTY0Vea2uBD/KJbc3MSs4n8AVRTslamzItR6qQoMsinT9IFNsYnPOrITwpZlX8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chbp3bnEsa1nc4liqIFoS6bMxIuXDQS6/H43HjyC131R7ZDntzmAPWEW4/U/HoU48E950LgXSIp5OfJU1WJDMi8iD06w75FQseTlpptSnSZP8w1qEqvIjE0MuUwg5kJiEP0xWhRbjQwsgMtss7XPiCQijb7qIDwoiVxI+Ts+UmT56phEHnAYHOnvL/tYhvHDA/hLOTtURiwSzVN5LuWbszeuFgdOHGCLfrjG/lG6N97F7dBEoBAkqfBKOUglnIg0lBFiXL2XQfK4vMIxIFr70nQtN5jgoYgWgPP9+dbCzTOa088zm9mCfOWqNdl0gVTGaXBQvOoy3EPjynBNifGslw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CBX6WIPprRbeDcEysvckpxtaMitb4BjzUgmDZzHmKms=; b=SRUeZkMUSQ0JEBmLzSPSv+YGCigMQbtzrpE9xpHMaZv44CKsuDzmQXpObc9+8xGAJNzAK+gn+dj+lq/YQ/mhsQAXP78uFocDF+/qpZ70CC4Pq/2hX/vsNhYvyKu6uWmbjNEEoZn+24r92gO9MSV8rtqD9anT1W5Dqsw+IZAF4U/LZbM/6qR3CzdLi4WFgXixrshwvAtj4/N2+cGsi+bztMAY6r/IuyollGiZDg2/7tPeAEqqlqim3z2Q2Ricoj0PEHfqe/SmVwpb3v2XX5BL8styB1CfzGaI1iTi1mcu40/H3XqlvpF528869vJgwdkfym98aep5JMJnb2kZWv5kNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBX6WIPprRbeDcEysvckpxtaMitb4BjzUgmDZzHmKms=; b=pHJ+4RcrWD4e0KX0AZ0/Dtt+Qz2aPdHx1r9NAq3vvC3Fefhq7Zqdq7/DSFrzmJgx9mDmT3ksTkF3a3O2BZ4uesnXQx823q1Y7ZiXWPGAKAd7IgTY0Vea2uBD/KJbc3MSs4n8AVRTslamzItR6qQoMsinT9IFNsYnPOrITwpZlX8= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems Thread-Topic: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems Thread-Index: AQHZJxA1N6B15lsZP0qYNGyz15VK/q7B2JQAgAE/6UA= Date: Tue, 7 Feb 2023 06:30:35 +0000 Message-ID: References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-21-Penny.Zheng@arm.com> <78a79c41-e026-b8aa-cfbf-0482f7f5c171@xen.org> In-Reply-To: <78a79c41-e026-b8aa-cfbf-0482f7f5c171@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 588F24A8B4475E42B21F694CDC46D64E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|PA4PR08MB6142:EE_|DBAEUR03FT028:EE_|DB5PR08MB10162:EE_ X-MS-Office365-Filtering-Correlation-Id: e574522a-567f-455b-7fd2-08db08d4de01 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x5ZNY8DYpBCWS1dA3tcGfqq79rlywqTovrCdjWQ5zqjYJcY3IhEkhPFRdEEkBL9xG4m26d7azj1L47szHZwE60JIiQxXLXK9V4FTDZvtp1qZ0OLQRBhXyKvMoY4EN193MkYs2BZX7Mr4LD9ZSnbJ1JyQYhFLkUiIQoTU5xBpGAN1PtrBdmKbI/85+pTSFjskewVoQAEqibaLwRtdJhjw6SxuBXOcTq5QZqCgEzSpzl6fZhvEW4cIbQihItdFUPtV5707b6O531Q24KeSCigUUz2ZlT/LZdaeaprFhak8FOqbOy8OV32zefVoxMNu/fv+BINcDjh9yE/Im/l/8Od9xamCiC9Jgoo9qrXGrgYAjuyqjVklmfNc9BILLr9482YpZIo41YHxPfb2rJ3qiQOe5TT9Hhv2s0PclNpYjgfI2QVHYUhRYCkzZWpdTFqMS3U365TEFF1HvAzwomvTOeAKiqPRyHBa5NR2T/rpsy/sqF1F63G7udeCcZDxEkbTCS4O2hLtICimIQP2AY5IMuLflce20F1R8YPczBkA0XO9YA5LfYjyDZm0v3C/juVPuNVFkvMT+xBXwEPvnYnDW1ToB5nL7HbnvyrEOmt1/czbyWB0ruZw1vjMMmEk9NgMo/zMi3XkbmFF648X8TkaJ+I+Svr63/LDK+gEvkSCt0xFPNPNRT0EakvtJM0A6fFr/OM0jKt9CpcfGafhs5FxowfMBw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199018)(8676002)(66946007)(38100700002)(122000001)(38070700005)(316002)(83380400001)(52536014)(8936002)(66556008)(66476007)(66446008)(64756008)(4326008)(41300700001)(76116006)(2906002)(5660300002)(6506007)(53546011)(478600001)(26005)(186003)(9686003)(86362001)(110136005)(33656002)(54906003)(71200400001)(7696005)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6142 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b2bd740b-6ad3-4683-e577-08db08d4d254 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DRyJ5cNSltdAQRBGuPwgMgk5eAPgA21sChdy2+vomGt5wmQOZf6tFKfBF3vPREGtIsMNDN6qJhVZ94KoJmBqey9L8MyoWS5WlHQdHqh8OKp3wg8z8MiorFquoHqtIEICiPQuThri2Msn+rVxpZFS2emJLDQkbnyggZi+y1AZVPN+RCac3D1SWjJ7TKuI0wpweWldpz2pPf+qdc4E28F6zIaP4o81orDDmBXsZmcO/B99zGGiT0DfEbfsKIDUG0KPyY1PkYZuIwlMGsQtk9lSKiSO8udgpXCx+V7u7cw2An3+iVIyoNcViFmUdGlO31uUuIVacrsb3PCckMGAE2kMHQdXX+hI4AzJixX5j2ipuLsvAqoLWuy94hjN6/LsMqG7q6WjtkPL16EZHWJnTxnQ+dUVj1y7hcK80eX90uzWZtOqkRYvymmSDVMN/lKSihSo3Udmlp1iQ+0xGTsOaJdSxo2CApFjytjHMWGG8a5I3SPphcP8F3PJIUo2u7vCo9Ml+FOd947IWlyd/9V6Z/WTylJtfQu1J3ordGDnq1Kkmskl2z8LCJy9foHsW2/7MdPZ7K9eGG7+s00y0hIm0ZSUW5FOxw24twgiG1lHkMZIiUFJfl0M9BrQ5WooQdtqoFuyhrv2HtsnN1K1nt+LOBp2YahLIYz23jytwzIE5csIUTn96ni65FCuRsrV6w0KaUeUzQ9oT6SJNi2AI+hWkFAK7w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(376002)(346002)(451199018)(40470700004)(46966006)(36840700001)(82310400005)(47076005)(83380400001)(186003)(9686003)(54906003)(336012)(110136005)(33656002)(2906002)(36860700001)(356005)(70206006)(8676002)(7696005)(70586007)(478600001)(55016003)(4326008)(53546011)(6506007)(26005)(40460700003)(107886003)(8936002)(40480700001)(41300700001)(52536014)(81166007)(82740400003)(86362001)(316002)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 06:30:55.3630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e574522a-567f-455b-7fd2-08db08d4de01 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10162 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogTW9uZGF5LCBGZWJydWFyeSA2LCAyMDIz IDY6MTEgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLWRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNv bT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRy YW5kIE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47DQo+IFZvbG9keW15ciBCYWJj aHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2 MiAyMC80MF0geGVuL21wdTogcGx1bXAgZWFybHlfZmR0X21hcCBpbiBNUFUNCj4gc3lzdGVtcw0K PiANCj4gSGksDQo+IA0KPiBBIGZldyBtb3JlIHJlbWFya3MuDQo+IA0KPiBPbiAxMy8wMS8yMDIz IDA1OjI4LCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBJbiBNUFUgc3lzdGVtLCBkZXZpY2UgdHJl ZSBiaW5hcnkgY2FuIGJlIHBhY2tlZCB3aXRoIFhlbiBpbWFnZSB0aHJvdWdoDQo+ID4gQ09ORklH X0RUQl9GSUxFLCBvciBwcm92aWRlZCBieSBib290bG9hZGVyIHRocm91Z2ggeDAuDQo+ID4NCj4g PiBJbiBNUFUgc3lzdGVtLCBlYWNoIHNlY3Rpb24gaW4geGVuLmxkcy5TIGlzIFBBR0VfU0laRSBh bGlnbmVkLg0KPiA+IFNvIGluIG9yZGVyIHRvIG5vdCBvdmVybGFwIHdpdGggdGhlIHByZXZpb3Vz IEJTUyBzZWN0aW9uLCBkdGIgc2VjdGlvbg0KPiA+IHNob3VsZCBiZSBtYWRlIHBhZ2UtYWxpZ25l ZCB0b28uDQo+ID4gV2UgYWRkIC4gPSBBTElHTihQQUdFX1NJWkUpOyBpbiB0aGUgaGVhZCBvZiBk dGIgc2VjdGlvbiB0byBtYWtlIGl0IGhhcHBlbi4NCj4gPg0KPiA+IEluIHRoaXMgY29tbWl0LCB3 ZSBtYXAgZWFybHkgRkRUIHdpdGggYSB0cmFuc2llbnQgTVBVIG1lbW9yeSByZWdpb24gYXQNCj4g PiByZWFyIHdpdGggUkVHSU9OX0hZUEVSVklTT1JfQk9PVC4NCj4gPg0KPiA+IFNpZ25lZC1vZmYt Ynk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6 IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJt L2luY2x1ZGUvYXNtL2FybTY0L21wdS5oIHwgIDUgKysrDQo+ID4gICB4ZW4vYXJjaC9hcm0vbW1f bXB1LmMgICAgICAgICAgICAgICAgfCA2MyArKysrKysrKysrKysrKysrKysrKysrKysrLS0tDQo+ ID4gICB4ZW4vYXJjaC9hcm0veGVuLmxkcy5TICAgICAgICAgICAgICAgfCAgNSArKy0NCj4gPiAg IDMgZmlsZXMgY2hhbmdlZCwgNjcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gPg0K PiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvbXB1LmgNCj4g PiBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9tcHUuaA0KPiA+IGluZGV4IGZjZGU2 YWQwZGIuLmI4NWU0MjBhOTAgMTAwNjQ0DQo+ID4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUv YXNtL2FybTY0L21wdS5oDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTY0 L21wdS5oDQo+ID4gQEAgLTQ1LDE4ICs0NSwyMiBAQA0KPiA+ICAgICogWzM6NF0gRXhlY3V0ZSBO ZXZlcg0KPiA+ICAgICogWzU6Nl0gQWNjZXNzIFBlcm1pc3Npb24NCj4gPiAgICAqIFs3XSAgIFJl Z2lvbiBQcmVzZW50DQo+ID4gKyAqIFs4XSAgIEJvb3Qtb25seSBSZWdpb24NCj4gPiAgICAqLw0K PiA+ICAgI2RlZmluZSBfUkVHSU9OX0FJX0JJVCAgICAgICAgICAgIDANCj4gPiAgICNkZWZpbmUg X1JFR0lPTl9YTl9CSVQgICAgICAgICAgICAzDQo+ID4gICAjZGVmaW5lIF9SRUdJT05fQVBfQklU ICAgICAgICAgICAgNQ0KPiA+ICAgI2RlZmluZSBfUkVHSU9OX1BSRVNFTlRfQklUICAgICAgIDcN Cj4gPiArI2RlZmluZSBfUkVHSU9OX0JPT1RPTkxZX0JJVCAgICAgIDgNCj4gPiAgICNkZWZpbmUg X1JFR0lPTl9YTiAgICAgICAgICAgICAgICAoMlUgPDwgX1JFR0lPTl9YTl9CSVQpDQo+ID4gICAj ZGVmaW5lIF9SRUdJT05fUk8gICAgICAgICAgICAgICAgKDJVIDw8IF9SRUdJT05fQVBfQklUKQ0K PiA+ICAgI2RlZmluZSBfUkVHSU9OX1BSRVNFTlQgICAgICAgICAgICgxVSA8PCBfUkVHSU9OX1BS RVNFTlRfQklUKQ0KPiA+ICsjZGVmaW5lIF9SRUdJT05fQk9PVE9OTFkgICAgICAgICAgKDFVIDw8 IF9SRUdJT05fQk9PVE9OTFlfQklUKQ0KPiA+ICAgI2RlZmluZSBSRUdJT05fQUlfTUFTSyh4KSAg ICAgICAgICgoKHgpID4+IF9SRUdJT05fQUlfQklUKSAmIDB4N1UpDQo+ID4gICAjZGVmaW5lIFJF R0lPTl9YTl9NQVNLKHgpICAgICAgICAgKCgoeCkgPj4gX1JFR0lPTl9YTl9CSVQpICYgMHgzVSkN Cj4gPiAgICNkZWZpbmUgUkVHSU9OX0FQX01BU0soeCkgICAgICAgICAoKCh4KSA+PiBfUkVHSU9O X0FQX0JJVCkgJiAweDNVKQ0KPiA+ICAgI2RlZmluZSBSRUdJT05fUk9fTUFTSyh4KSAgICAgICAg ICgoKHgpID4+IF9SRUdJT05fQVBfQklUKSAmIDB4MlUpDQo+ID4gKyNkZWZpbmUgUkVHSU9OX0JP T1RPTkxZX01BU0soeCkgICAoKCh4KSA+PiBfUkVHSU9OX0JPT1RPTkxZX0JJVCkNCj4gJiAweDFV KQ0KPiA+DQo+ID4gICAvKg0KPiA+ICAgICogX1JFR0lPTl9OT1JNQUwgaXMgY29udmVuaWVuY2Ug ZGVmaW5lLiBJdCBpcyBub3QgbWVhbnQgdG8gYmUgdXNlZA0KPiA+IEBAIC02OCw2ICs3Miw3IEBA DQo+ID4gICAjZGVmaW5lIFJFR0lPTl9IWVBFUlZJU09SX1JPDQo+IChfUkVHSU9OX05PUk1BTHxf UkVHSU9OX1hOfF9SRUdJT05fUk8pDQo+ID4NCj4gPiAgICNkZWZpbmUgUkVHSU9OX0hZUEVSVklT T1IgICAgICAgICBSRUdJT05fSFlQRVJWSVNPUl9SVw0KPiA+ICsjZGVmaW5lIFJFR0lPTl9IWVBF UlZJU09SX0JPT1QNCj4gKFJFR0lPTl9IWVBFUlZJU09SX1JXfF9SRUdJT05fQk9PVE9OTFkpDQo+ ID4NCj4gPiAgICNkZWZpbmUgSU5WQUxJRF9SRUdJT04gICAgICAgICAgICAofjBVTCkNCj4gPg0K PiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbW1fbXB1LmMgYi94ZW4vYXJjaC9hcm0vbW1f bXB1LmMgaW5kZXgNCj4gPiAwODcyMGE3YzE5Li5iMzRkYmY0NTE1IDEwMDY0NA0KPiA+IC0tLSBh L3hlbi9hcmNoL2FybS9tbV9tcHUuYw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9tbV9tcHUuYw0K PiA+IEBAIC0yMCwxMSArMjAsMTYgQEANCj4gPiAgICAqLw0KPiA+DQo+ID4gICAjaW5jbHVkZSA8 eGVuL2luaXQuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9saWJmZHQvbGliZmR0Lmg+DQo+ID4gICAj aW5jbHVkZSA8eGVuL21tLmg+DQo+ID4gICAjaW5jbHVkZSA8eGVuL3BhZ2Utc2l6ZS5oPg0KPiA+ ICsjaW5jbHVkZSA8eGVuL3Bmbi5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3NpemVzLmg+DQo+ID4g ICAjaW5jbHVkZSA8eGVuL3NwaW5sb2NrLmg+DQo+ID4gICAjaW5jbHVkZSA8YXNtL2FybTY0L21w dS5oPg0KPiA+ICsjaW5jbHVkZSA8YXNtL2Vhcmx5X3ByaW50ay5oPg0KPiA+ICAgI2luY2x1ZGUg PGFzbS9wYWdlLmg+DQo+ID4gKyNpbmNsdWRlIDxhc20vc2V0dXAuaD4NCj4gPg0KPiA+ICAgI2lm ZGVmIE5ERUJVRw0KPiA+ICAgc3RhdGljIGlubGluZSB2b2lkDQo+ID4gQEAgLTYyLDYgKzY3LDgg QEAgdWludDY0X3QgX19yb19hZnRlcl9pbml0IG1heF94ZW5fbXB1bWFwOw0KPiA+DQo+ID4gICBz dGF0aWMgREVGSU5FX1NQSU5MT0NLKHhlbl9tcHVtYXBfbG9jayk7DQo+ID4NCj4gPiArc3RhdGlj IHBhZGRyX3QgZHRiX3BhZGRyOw0KPiA+ICsNCj4gPiAgIC8qIFdyaXRlIGEgTVBVIHByb3RlY3Rp b24gcmVnaW9uICovDQo+ID4gICAjZGVmaW5lIFdSSVRFX1BST1RFQ1RJT05fUkVHSU9OKHNlbCwg cHIsIHByYmFyX2VsMiwgcHJsYXJfZWwyKSAoeyAgICAgICBcDQo+ID4gICAgICAgdWludDY0X3Qg X3NlbCA9IHNlbDsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBcDQo+ID4gQEAgLTQwMyw3ICs0MTAsMTYgQEAgc3RhdGljIGludCB4ZW5fbXB1bWFwX3VwZGF0 ZV9lbnRyeShwYWRkcl90DQo+IGJhc2UsDQo+ID4gcGFkZHJfdCBsaW1pdCwNCj4gPg0KPiA+ICAg ICAgICAgICAvKiBEdXJpbmcgYm9vdCB0aW1lLCB0aGUgZGVmYXVsdCBpbmRleCBpcyBuZXh0X2Zp eGVkX3JlZ2lvbl9pZHguICovDQo+ID4gICAgICAgICAgIGlmICggc3lzdGVtX3N0YXRlIDw9IFNZ U19TVEFURV9hY3RpdmUgKQ0KPiA+IC0gICAgICAgICAgICBpZHggPSBuZXh0X2ZpeGVkX3JlZ2lv bl9pZHg7DQo+ID4gKyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAvKg0KPiA+ICsgICAgICAg ICAgICAgKiBJZiBpdCBpcyBhIGJvb3Qtb25seSByZWdpb24gKGkuZS4gcmVnaW9uIGZvciBlYXJs eSBGRFQpLA0KPiA+ICsgICAgICAgICAgICAgKiBpdCBzaGFsbCBiZSBhZGRlZCBmcm9tIHRoZSB0 YWlsIGZvciBsYXRlIGluaXQgcmUtb3JnYW5pemluZw0KPiA+ICsgICAgICAgICAgICAgKi8NCj4g PiArICAgICAgICAgICAgaWYgKCBSRUdJT05fQk9PVE9OTFlfTUFTSyhmbGFncykgKQ0KPiA+ICsg ICAgICAgICAgICAgICAgaWR4ID0gbmV4dF90cmFuc2llbnRfcmVnaW9uX2lkeDsNCj4gPiArICAg ICAgICAgICAgZWxzZQ0KPiA+ICsgICAgICAgICAgICAgICAgaWR4ID0gbmV4dF9maXhlZF9yZWdp b25faWR4Ow0KPiA+ICsgICAgICAgIH0NCj4gPg0KPiA+ICAgICAgICAgICB4ZW5fbXB1bWFwW2lk eF0gPSBwcl9vZl94ZW5hZGRyKGJhc2UsIGxpbWl0IC0gMSwNCj4gUkVHSU9OX0FJX01BU0soZmxh Z3MpKTsNCj4gPiAgICAgICAgICAgLyogU2V0IHBlcm1pc3Npb24gKi8NCj4gPiBAQCAtNDY1LDE0 ICs0ODEsNTEgQEAgaW50IG1hcF9wYWdlc190b194ZW4odW5zaWduZWQgbG9uZyB2aXJ0LA0KPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5fdG9fbWFkZHIobWZuX2FkZChtZm4s IG5yX21mbnMpKSwgZmxhZ3MpOw0KPiA+ICAgfQ0KPiA+DQo+ID4gLS8qIFRPRE86IEltcGxlbWVu dGF0aW9uIG9uIHRoZSBmaXJzdCB1c2FnZSAqLyAtdm9pZA0KPiA+IGR1bXBfaHlwX3dhbGsodmFk ZHJfdCBhZGRyKQ0KPiA+ICt2b2lkICogX19pbml0IGVhcmx5X2ZkdF9tYXAocGFkZHJfdCBmZHRf cGFkZHIpDQo+ID4gICB7DQo+ID4gKyAgICB2b2lkICpmZHRfdmlydDsNCj4gPiArICAgIHVpbnQz Ml90IHNpemU7DQo+ID4gKw0KPiA+ICsgICAgLyoNCj4gPiArICAgICAqIENoZWNrIHdoZXRoZXIg dGhlIHBoeXNpY2FsIEZEVCBhZGRyZXNzIGlzIHNldCBhbmQgbWVldHMgdGhlDQo+IG1pbmltdW0N Cj4gPiArICAgICAqIGFsaWdubWVudCByZXF1aXJlbWVudC4gU2luY2Ugd2UgYXJlIHJlbHlpbmcg b24gTUlOX0ZEVF9BTElHTiB0bw0KPiBiZSBhdA0KPiA+ICsgICAgICogbGVhc3QgOCBieXRlcyBz byB0aGF0IHdlIGFsd2F5cyBhY2Nlc3MgdGhlIG1hZ2ljIGFuZCBzaXplIGZpZWxkcw0KPiA+ICsg ICAgICogb2YgdGhlIEZEVCBoZWFkZXIgYWZ0ZXIgbWFwcGluZyB0aGUgZmlyc3QgY2h1bmssIGRv dWJsZSBjaGVjayBpZg0KPiA+ICsgICAgICogdGhhdCBpcyBpbmRlZWQgdGhlIGNhc2UuDQo+ID4g KyAgICAgKi8NCj4gPiArICAgICBCVUlMRF9CVUdfT04oTUlOX0ZEVF9BTElHTiA8IDgpOw0KPiA+ ICsgICAgIGlmICggIWZkdF9wYWRkciB8fCBmZHRfcGFkZHIgJSBNSU5fRkRUX0FMSUdOICkNCj4g PiArICAgICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gKw0KPiA+ICsgICAgZHRiX3BhZGRyID0gZmR0 X3BhZGRyOw0KPiA+ICsgICAgLyoNCj4gPiArICAgICAqIEluIE1QVSBzeXN0ZW0sIGRldmljZSB0 cmVlIGJpbmFyeSBjYW4gYmUgcGFja2VkIHdpdGggWGVuIGltYWdlDQo+ID4gKyAgICAgKiB0aHJv dWdoIENPTkZJR19EVEJfRklMRSwgb3IgcHJvdmlkZWQgYnkgYm9vdGxvYWRlciB0aHJvdWdoIHgw Lg0KPiANCj4gVGhlIGJlaGF2aW9yIHlvdSBkZXNjcmliZSBpcyBub3Qgc3BlY2lmaWMgdG8gdGhl IE1QVSBzeXN0ZW0uIEkgYWxzbyBkb24ndA0KPiBxdWl0ZSB1bmRlcnN0YW5kIGhvdyBkZXNjcmli aW5nIHRoZSBtZXRob2QgdG8gcGFzcyB0aGUgRFQgYWN0dWFsbHkgbWF0dGVycw0KPiBoZXJlLg0K PiANCj4gPiArICAgICAqIE1hcCBGRFQgd2l0aCBhIHRyYW5zaWVudCBNUFUgbWVtb3J5IHJlZ2lv biBvZiBNQVhfRkRUX1NJWkUuDQo+ID4gKyAgICAgKiBBZnRlciB0aGF0LCB3ZSBjYW4gZG8gc29t ZSBtYWdpYyBjaGVjay4NCj4gPiArICAgICAqLw0KPiA+ICsgICAgaWYgKCBtYXBfcGFnZXNfdG9f eGVuKHJvdW5kX3BnZG93bihmZHRfcGFkZHIpLA0KPiANCj4gSSBoYXZlbid0IGxvb2tlZCBhdCB0 aGUgcmVzdCBvZiB0aGUgc2VyaWVzLiBCdXQgZnJvbSBoZXJlLCBpdCBzZWVtcyBhIGJpdCBzdHJh bmdlDQo+IHRvIHVzZSBtYXBfcGFnZXNfdG9feGVuKCkgYmVjYXVzZSB0aGUgdmlydCBhbmQgdGhl IHBoeXMgc2hvdWxkIGJlIHRoZQ0KPiBzYW1lLg0KPiANCg0KSG1tLCB0IHRob3VnaHQgbWFwX3Bh Z2VzX3RvX3hlbiwgaXMgdG8gc2V0IHVwIG1lbW9yeSBtYXBwaW5nIGZvciBhY2Nlc3MuDQpJbiBN UFUsIHdlIGFsc28gbmVlZCB0byBzZXQgdXAgYSBNUFUgbWVtb3J5IHJlZ2lvbiBmb3IgdGhlIEZE VCwgZXZlbiB3aXRob3V0DQp2aXJ0LXRvLXBoeXMgY29udmVyc2lvbiANCg0KPiBEbyB5b3UgcGxh biB0byBzaGFyZSBzb21lIGNvZGUgd2hlcmUgbWFwX3BhZ2VzX3RvX3hlbigpIHdpbGwgYmUgdXNl ZD8NCj4gDQoNCkVhY2ggdGltZSwgaW4gQyBib290LXRpbWUsIHdlIGJ1aWxkIHVwIGEgbmV3IE1Q VSBtZW1vcnkgcmVnaW9uIGZvciBzdGFnZSAxDQpFTDIgbWVtb3J5IG1hcHBpbmcsIHdlIHVzZSB0 aGlzIG1hcF9wYWdlc190b194ZW4gdG8gY29tcGxldGUuDQpJIHRoaW5rIGl0IGhhcyB0aGUgc2Ft ZSBlZmZlY3QgYXMgaXQgaGFzIGluIE1NVSwgb3RoZXIgdGhhbiBNTVUgc2V0cyB1cA0KdmlydC10 by1waHlzIG1lbW9yeSBtYXBwaW5nIGFuZCBNUFUgYWx3YXlzIHNldHMgdXAgaWRlbnRpdHkgbWVt b3J5IG1hcHBpbmcuDQoNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICBtYWRkcl90b19t Zm4ocm91bmRfcGdkb3duKGZkdF9wYWRkcikpLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgIHJvdW5kX3BndXAoTUFYX0ZEVF9TSVpFKSA+PiBQQUdFX1NISUZULA0KPiANCj4gVGhpcyB3 aWxsIG5vdCB3b3JrIHByb3Blcmx5IGlzIHRoZSBEZXZpY2UtVHJlZSBpcyBNQVhfRkRUX1NJWkUg KGNvdWxkDQo+IGFscmVhZHkgYmUgcGFnZS1hbGlnbmVkKSBidXQgdGhlIHN0YXJ0IGFkZHJlc3Mg aXMgbm90IHBhZ2UtYWxpZ25lZC4NCj4gDQo+IEJ1dCBJIHRoaW5rIHRyeWluZyB0byBtYXAgdGhl IG1heGltdW0gc2l6ZSBmcm9tIHRoZSBzdGFydCBjb3VsZCBwb3RlbnRpYWxseQ0KPiByZXN1bHQg dG8gc29tZSBpc3N1ZS4gQmVsb3cgdGhlIGV4Y2VycHQgZnJvbSB0aGUgSW1hZ2UNCj4gZG9jdW1l bnRhdGlvbjoNCj4gDQo+ICJUaGUgZGV2aWNlIHRyZWUgYmxvYiAoZHRiKSBtdXN0IGJlIHBsYWNl ZCBvbiBhbiA4LWJ5dGUgYm91bmRhcnkgYW5kIG11c3QNCj4gbm90IGV4Y2VlZCAyIG1lZ2FieXRl cyBpbiBzaXplLiBTaW5jZSB0aGUgZHRiIHdpbGwgYmUgbWFwcGVkIGNhY2hlYWJsZSB1c2luZw0K PiBibG9ja3Mgb2YgdXAgdG8gMiBtZWdhYnl0ZXMgaW4gc2l6ZSwgaXQgbXVzdCBub3QgYmUgcGxh Y2VkIHdpdGhpbiBhbnkgMk0NCj4gcmVnaW9uIHdoaWNoIG11c3QgYmUgbWFwcGVkIHdpdGggYW55 IHNwZWNpZmljIGF0dHJpYnV0ZXMuIg0KPiANCj4gU28gaXQgd291bGQgYmUgYmV0dGVyIHRvIG1h cCB0aGUgZmlyc3QgMk1CLiBDaGVjayB0aGUgc2l6ZSBhbmQgdGhlbiByZS1tYXANCj4gd2l0aCBh biBleHRyYSAyTUIgaWYgbmVlZGVkLg0KPiANCg0KT2gsIHVuZGVyIHNwZWNpYWwgY2lyY3Vtc3Rh bmNlcywgdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gd2lsbCBtYXAgZXhjZWVkaW5nIDJNQi4N ClRoYW5rcyBmb3IgZXhwbGFuYXRpb24hDQpJIHdpbGwgbWFwIGFzIHlvdSBzdWdnZXN0ZWQuDQoN Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICBSRUdJT05fSFlQRVJWSVNPUl9CT09UKSAp ID4gKyAgICAgICAgcGFuaWMoIlVuYWJsZSB0bw0KPiBtYXAgdGhlIGRldmljZS10cmVlLlxuIik7 DQo+ID4gKw0KPiA+ICsgICAgLyogVkEgPT0gUEEgKi8NCj4gDQo+IEkgaGF2ZSBzZWVuIGluIGEg ZmV3IHBsYWNlcyB3aGVyZSB5b3UgYWRkIGEgc2ltaWxhciBjb21tZW50LiBCdXQgSSBhbSBub3QN Cj4gc3VyZSB0byB1bmRlcnN0YW5kIGhvdyB0aGlzIGhlbHAgdG8gZGVzY3JpYmUgdGhlIGltcGxl bWVudGF0aW9uIG9mDQo+IG1hZGRyX3RvX3ZpcnQoKS4NCj4gDQo+ID4gKyAgICBmZHRfdmlydCA9 IG1hZGRyX3RvX3ZpcnQoZmR0X3BhZGRyKTsNCj4gPiArDQo+ID4gKyAgICBpZiAoIGZkdF9tYWdp YyhmZHRfdmlydCkgIT0gRkRUX01BR0lDICkNCj4gPiArICAgICAgICByZXR1cm4gTlVMTDsNCj4g PiArDQo+ID4gKyAgICBzaXplID0gZmR0X3RvdGFsc2l6ZShmZHRfdmlydCk7DQo+ID4gKyAgICBp ZiAoIHNpemUgPiBNQVhfRkRUX1NJWkUgKQ0KPiA+ICsgICAgICAgIHJldHVybiBOVUxMOw0KPiA+ ICsNCj4gPiArICAgIHJldHVybiBmZHRfdmlydDsNCj4gPiAgIH0NCj4gPg0KPiA+IC12b2lkICog X19pbml0IGVhcmx5X2ZkdF9tYXAocGFkZHJfdCBmZHRfcGFkZHIpDQo+ID4gKy8qIFRPRE86IElt cGxlbWVudGF0aW9uIG9uIHRoZSBmaXJzdCB1c2FnZSAqLyB2b2lkDQo+ID4gK2R1bXBfaHlwX3dh bGsodmFkZHJfdCBhZGRyKQ0KPiA+ICAgew0KPiA+IC0gICAgcmV0dXJuIE5VTEw7DQo+ID4gICB9 DQo+ID4NCj4gPiAgIHZvaWQgX19pbml0IHJlbW92ZV9lYXJseV9tYXBwaW5ncyh2b2lkKSBkaWZm IC0tZ2l0DQo+ID4gYS94ZW4vYXJjaC9hcm0veGVuLmxkcy5TIGIveGVuL2FyY2gvYXJtL3hlbi5s ZHMuUyBpbmRleA0KPiA+IDc5OTY1YTNjMTcuLjA1NjVlMjJhMWYgMTAwNjQ0DQo+ID4gLS0tIGEv eGVuL2FyY2gvYXJtL3hlbi5sZHMuUw0KPiA+ICsrKyBiL3hlbi9hcmNoL2FybS94ZW4ubGRzLlMN Cj4gPiBAQCAtMjE4LDcgKzIxOCwxMCBAQCBTRUNUSU9OUw0KPiA+ICAgICBfZW5kID0gLiA7DQo+ ID4NCj4gPiAgICAgLyogU2VjdGlvbiBmb3IgdGhlIGRldmljZSB0cmVlIGJsb2IgKGlmIGFueSku ICovDQo+ID4gLSAgLmR0YiA6IHsgKiguZHRiKSB9IDp0ZXh0DQo+ID4gKyAgLmR0YiA6IHsNCj4g PiArICAgICAgLiA9IEFMSUdOKFBBR0VfU0laRSk7DQo+ID4gKyAgICAgICooLmR0YikNCj4gPiAr ICB9IDp0ZXh0DQo+ID4NCj4gPiAgICAgRFdBUkYyX0RFQlVHX1NFQ1RJT05TDQo+ID4NCj4gDQo+ IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue Feb 07 07:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 07:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490892.759786 (Exim 4.92) (envelope-from ) id 1pPIox-0001On-UR; Tue, 07 Feb 2023 07:55:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490892.759786; Tue, 07 Feb 2023 07:55:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPIox-0001Oe-RC; Tue, 07 Feb 2023 07:55:19 +0000 Received: by outflank-mailman (input) for mailman id 490892; Tue, 07 Feb 2023 07:55:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPIow-0001OW-DH for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 07:55:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7d00::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0c39f63-a6bc-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 08:55:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7562.eurprd04.prod.outlook.com (2603:10a6:10:1f6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 07:55:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 07:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0c39f63-a6bc-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVXtlrp5wo1v0g70x+vb+DJQFE1beUiFWmGOYqhT96N/2tWgOBWZzoVRahlgaoXUOSbfrbJ0cn6wcSYZVBcEzYDaWgvn15t1TfJXlPuhDtKkWHoCHAhPV5RTwDmtUUPnmlovQuu6uecFnEKaaTjmbAjw1oqubCFKJXG5PRwLqMUnaINxOVBeTxHM87QVtr8EjFL2zYsABFd3DfyOogHliXzT2Vfj8sLyF/r0RCO2QsyzV3TKDFsgfzVOBviYRFE2ES+UQ8pe1ppUau8va07PkkgKLkBIeNlPwCuZI7PIkChYHzg4NKHuCW88UAGLmE8hi2EWRb1N0uVLAbq5OnAeTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qyMlDGlnbTjTWKsUr9Dg2CKy9ZY+rH0jptAkKFFu0Vs=; b=bJAZqnKIgUugV2Oi+lXWQ7AEi1FFY5rWoVqfU8pa+tLUwDhhcTWcYwG2BqJCHjEj9cxbGGigp685NvQFq5K+t7tjM+taYdn8myD9db3LdYyXxSh3Ncw+Hl7uJj0EsIaZnFCAinQ80FP2aKC1QYElneQ+tOMx0DphAzRPAmO4Wx/4Fcd4xlYGEj4+FRpVmgNH9gCPhob87kPBLbI/Lhrx6bcIiBPJK9+eumAMu0CD+tmQfXZsK58sile1HYlOIpAHYMlQ59dGXx4EtxPDXv3mQYIWp/6eMggaTtSi9w9efEt+PUf/ffz4HYk3xJzUWuUuTPsod90kzTF45v7VbSivaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qyMlDGlnbTjTWKsUr9Dg2CKy9ZY+rH0jptAkKFFu0Vs=; b=5idHm8X90BuhvM+81jqSMEWFWUNXgl0+/ZXaFxV/rW8nQvBqauQEmwdkPtZaRfXnoDlDwGk/mqHznHDUyycqZpOM3AoIHVVkerwAgur/ZBOE/EZ78B02YoCejIlTTmAYy6MDij85k/C93yUlARCGAaFghpQKrY+U+M+xHbIq+bZfbqJBZ/UCqxaX/o0vCTVu3T+KB6eJ4ADTgv54GdwnaozqmGWf6fU2nqI63gnFfkGvHMUn3K5wpGP7v5QgWKll6SuSR6Uyz3H0JG39XT0zQ9rTiBEZv67ltizbw1ZFmpUfmUt/s6iEev+XVft8GHyWft72YSdhNkSNpwbebFUhlw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <53e151e1-9b35-bccf-1589-fc503729cee4@suse.com> Date: Tue, 7 Feb 2023 08:55:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal: List files in Xen originated from external sources Content-Language: en-US To: Stefano Stabellini Cc: Luca Fancellu , Xen-devel , Andrew Cooper , George Dunlap , Julien Grall References: <53371bbc-ea78-4c2b-a84e-e888ae090d3a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7562:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b416610-9fa6-45ca-9195-08db08e0a34b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6i2fhQ4c0/h4tVFPdllj4v0ulH/PGEMP+GGq87b/5ClzGqOWsM2G5gxNUoys+LbVXqWNm4vxWmZUg5pubapmgsouk05p7p3YrpbYGh1gUw1SHOMmX5MVkvDmaByeWEcLsdlo1MnP/3E8d8lJv9LCpm8/tqBfWs13nlH6mt/nmrshKnjzSGvG+UB3GFRq+BAbV6sP0O194nCcImus6avb1oQBPtFBfzh3BCxjPC8DFhDS6+PL3IiiYfCmNWRlVVHmSOJgXJk4+mU+Haw7fuubJyR+xkL2HCuawREcZcD2pxGx05rqyeBccj6TlMcUC/FU8LwSFkUNo4JD6FVA7+qmD71dUVzSIbRnEhQ2YHZ4YJxu7GKiaS21Tv7LS+Ec5c7u8J0GryiGZMw1KrNbausMG05DmFLMObbcFWn2o1jQkpUzbe9KYDaJV8esBC5jXL0dBbKm1c4RIzjzfjEwfaZVka73ALw6kHVZ1TR0p3bGpggi+FIr3rTFYIvvSEN+kImBVSSE8bdx/w0fem1t1761ag/d96XLMYmGavuUDd08jvQjrOvjTk23idDqTYz1nMOVI6JK+UNSlSCyV9FtEj+3Me2lN8SJm4tyu7b3EBJjOhDNIfsUXqWmlERj6qjxbJlyRp6X5vwcUuQQxDyVKKavgsdtUTBwQI7aw0/MtxYOqRgh0bEdEm5b4qU0GY5+Qy/IG294IqoKUmR5CWryQAcKVfRSvtKgPHYe+PadoMTKoec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(376002)(39860400002)(346002)(136003)(451199018)(31686004)(66476007)(66556008)(54906003)(316002)(66946007)(86362001)(31696002)(36756003)(2906002)(41300700001)(53546011)(6506007)(478600001)(186003)(26005)(6916009)(8676002)(6512007)(2616005)(4326008)(38100700002)(5660300002)(8936002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2FteEsxa1ZyV0JMR3VqQWYyRS9NL1FXOGlvTS8vVGwrc29qSUlkdDBvOXlR?= =?utf-8?B?K0ZBVTBwVkZSRE9wK0o4UGgxbEx1Yzhzd0RtM0N6c3FZcXlFdnJiL2JzT3VT?= =?utf-8?B?UTQyL1hpSklLMVRlNnF0SkIyTGlEWUhRaWc3Ynh3MTlJZnNiWGNBYWVWdWRC?= =?utf-8?B?OFZwQitHZWJUMHQ5WDNRTE40ajFCME5zb2dFdXJmSE84RkZRUWJDSTN4NFV4?= =?utf-8?B?Um0wazZqWldwdGVNRSthNUxRRittZGNVRk9iT1F6SThsTEVZMFh2RmYvaGRl?= =?utf-8?B?bmNvZGd5N2x6NzlnRzVyYzlJSWdUSzIycDJPOElwWGhvOVA3Z0NNV2lmemRW?= =?utf-8?B?TWg0NGZBcHBjVERveGpadjQ3WUpnMjN4ZTV2Y2J2cjlsekR5MkNIL3JpZ1VZ?= =?utf-8?B?VGQxbFRnUTZkc05MUWVXNTB3cEJmVEtyRTlWM241UGUrWmRWWHQwT0lEaW9K?= =?utf-8?B?dXpxcGtUT0o4MnBjSXQ1Z0FWZS9wYWRLZ3EyRlBwQ2J4c1VOTnZhQm51cWUx?= =?utf-8?B?WmR2RXFTQ1A4MnZkLzBwYy92VkpBNGxBM3dmRXEvWFJWMGpQMkhrMzRNM3lW?= =?utf-8?B?elF0bnFJR2c0bWlIY2xFdlVZUzZCbFRIQWNqanVPbFJHeFFlcG13c2FkZFpC?= =?utf-8?B?NjZLaGgyWXdzMnFoMUwxNUhvbVdPL2ZoMlowTmFjb0ZOcWRFUzRKU0p6c0wz?= =?utf-8?B?bjBuQ3YxditSUVJmWlAwTjgvUis3Y1hzb2RMd0pCb1F1ZGI3M0tya0lyNnJl?= =?utf-8?B?QWZXVlMrZVBJeHpLQ282V1NIRVBSekxTYXdUdDdoaHNaOEpCaXEyNFpRRit5?= =?utf-8?B?YkFjWE10N0RkMTI0VXhUZ3pzUXcrNWJvemx3L0lpdHB2RWJ0cmhBVWc2OUJn?= =?utf-8?B?VGJpTUZtMFZ0c1R5UC9nekljMksyYkdjOVpLRkQrVURUQWkwQXM5Y1VMNHNL?= =?utf-8?B?ZGs5RlU5QWNCekdJanZwY2x5UWE3U2FyYVprNHc2TGl0WEJ6dklmRFB6Nzc3?= =?utf-8?B?UVY3T0ZDbm9RRUZDdWFXbjJuZmFnRzFQT3d5Y25Memx2YVpORFBlRnIwaklW?= =?utf-8?B?azFpQVRxNXEwSE9Gb3h2S0dtbktONDkxNlRTd3lJc3FQUlRmZk10b0tQY2pQ?= =?utf-8?B?UjlGQThHMVJBaFNzYUM2bVlKb1F0Q2h6cXptaUwzY1VXdmluT3g3Zk4yVHNL?= =?utf-8?B?UldqTXBIdHFkRE5TaHp6bnNqT0tVWHY5Ykd1MmgzR1JSWUNnb1NIQkpSdnAy?= =?utf-8?B?R0kyN2lGVlNmUDFobEwyTjFhSU10T0E1aVIzRGFWbnd4a3VVa1BlblFkQXph?= =?utf-8?B?MkQwN1ZONlE0RmZ0NnVya0xWakdEdEZ6VFlmT2hzU2tHbXZZMndtMmlWVlVR?= =?utf-8?B?N0NubEFWOWVXNmIzUFIrdUFPTjJFbTVnaVRNa21kNjRqaXZLbmhHTXJ1QTU4?= =?utf-8?B?Y0xCa2UyVE9HczdJT01WSHBuemkxZFhKN0k2SnZxUU4ycjloTDRiUTNjZThE?= =?utf-8?B?a1RLVFRmM3AwaTk0UGJTZWlZVzB0end5d21zU1MzTXA0aWVuVGMrNU51ZjFL?= =?utf-8?B?N0hGRVFhbmRRTEFiUDZvSkxRTGVCc0d1QjI1OU1pMkFjdDh2L2p3Tng3MjZD?= =?utf-8?B?Zldmd09HTUpWdXhnRktvVkdxM3VUaW12S1ArSGtRT25Jc2NMQVBVRmt0ZVIr?= =?utf-8?B?WFIzUHRzQkVPekZ4b3hnWE5ZeER0a3BtS1pNUGdIWFdodjcvS2xXb0pDaHA1?= =?utf-8?B?bkowaytCc1FVQ0t3a0h5RnorM2xhZWk2MUdsb0M4SUJPK2I5a0tiV1kremZx?= =?utf-8?B?aE5YV1dsZlg0YThLSzQ2WExDMGw4Y3V2UW9zcERqRkdlS3NsdUgrY29kQWpy?= =?utf-8?B?b2J3MEo3RU5yUGpsRXlySEIzY2Z5UEdOdkVIZFlsUkdtNUcvWHEvbExISU9j?= =?utf-8?B?NW1GT2RpYVhhOTJtc3BSYndIaFhRdmhJeTRnUGY5KzV6dTllczd2SllxZEJu?= =?utf-8?B?bXlpNGN3UjNCeTFLSUw2SFlWbURGcmVMNS9LUlVZTVBNY3BtbkIzR3dQV3J6?= =?utf-8?B?NEUzaC92UXg1UFo4VHBvTDVUbDU3ZjBMN2J0L3MwRDZyWnRLWXVYOUZKaVFx?= =?utf-8?Q?IqidcruMEj8Ii0O6rYRXVnCzY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b416610-9fa6-45ca-9195-08db08e0a34b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 07:55:11.0423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BdPo8KPJHBJ7LSyuJ851dVl/caQVzcUh3KFO7sS54nOfr4bZOPYn0PHc00qecJ342dEEDhYvaBRMePD1Ewl5dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7562 On 06.02.2023 22:23, Stefano Stabellini wrote: > On Mon, 6 Feb 2023, Jan Beulich wrote: >> On 03.02.2023 20:55, Stefano Stabellini wrote: >>> On Fri, 3 Feb 2023, Luca Fancellu wrote: >>>> And then, if the file is not subject to backport and now we “own” the file, there is no more the need to list it >>>> in the external file, a commit search can reveal when it was converted to Xen codestyle and removed from >>>> the external file list so we don’t lose the history. >>> >>> Yes, I agree. If a file is coverted to Xen coding style and follows >>> MISRA rules, then there is no need to list the file in >>> docs/misra/external-files.json. >>> >>> >>>> So we would end up excluding just all the file listed in external-file.json by the analysis. >>> >>> Right, I think so too >> >> Personally I think this is too focused on Misra. > > We are trying to do two things at once: > 1) list of external files with their management info (backports, origin, etc.) > 2) list of files and paths to exclude from MISRA checking > > From this discussion it became clear that 1) and 2) are very different, > have different requirements, and different info attached. In fact, the > two lists of files and paths don't even match: not all external files > exclude MISRA checking and some non-external files also exclude MISRA > checking. > > I suggest we go forward with a MISRA-only exclude list with files and > paths to exclude from automatic checking, and without any implication > about external files. The list could be a json file called > "misra-exclude.json" to avoid any doubts. That would be fine with me. Such a file could then include a justification for each exclusion right away. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 07 07:59:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 07:59:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490898.759797 (Exim 4.92) (envelope-from ) id 1pPIse-00025U-Da; Tue, 07 Feb 2023 07:59:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490898.759797; Tue, 07 Feb 2023 07:59:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPIse-00025N-Ak; Tue, 07 Feb 2023 07:59:08 +0000 Received: by outflank-mailman (input) for mailman id 490898; Tue, 07 Feb 2023 07:59:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPIsc-00025H-S1 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 07:59:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a61e4af-a6bd-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 08:59:04 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4186C340B7; Tue, 7 Feb 2023 07:59:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C8DD613467; Tue, 7 Feb 2023 07:59:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id k7yxL8cE4mOhXgAAMHmgww (envelope-from ); Tue, 07 Feb 2023 07:59:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a61e4af-a6bd-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675756744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5gbyCaKdJ8Mi2SS92SeXVfp2L0hg2wIdbGtZaSSemJk=; b=cSLouw+eDRwsEhh4tCdzm/mXIkiN3VaizXDinxf3AxfRlZvMB13J7nYgvv8ambeU0sM7ey DfSm73Mxx8bw6U4fEBZZv1JatzASdbZIRMW3lo65fJ3jM7DsZCHiJEcXBD8HwsYeoYT9mU PVM2qzsER8TVJkPgRfU9baF5PVtydIw= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky , xen-devel@lists.xenproject.org Subject: [PATCH v2] x86/paravirt: merge activate_mm and dup_mmap callbacks Date: Tue, 7 Feb 2023 08:59:02 +0100 Message-Id: <20230207075902.7539-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are sharing the same implementations in all cases: for Xen PV guests they are pinning the PGD of the new mm_struct, and for all other cases they are a NOP. In the end both callbacks are meant to register an address space with the underlying hypervisor, so there needs to be only a single callback for that purpose. So merge them to a common callback .mmu.enter_mmap (in contrast to the corresponding already existing .mmu.exit_mmap). As the first parameter of the old callbacks isn't used, drop it from the replacement one. Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky --- V2: - expand commit message (Srivatsa S. Bhat) --- arch/x86/include/asm/mmu_context.h | 4 ++-- arch/x86/include/asm/paravirt.h | 14 +++----------- arch/x86/include/asm/paravirt_types.h | 7 ++----- arch/x86/kernel/paravirt.c | 3 +-- arch/x86/mm/init.c | 2 +- arch/x86/xen/mmu_pv.c | 12 ++---------- 6 files changed, 11 insertions(+), 31 deletions(-) diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h index b8d40ddeab00..6a14b6c2165c 100644 --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @@ -134,7 +134,7 @@ extern void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, #define activate_mm(prev, next) \ do { \ - paravirt_activate_mm((prev), (next)); \ + paravirt_enter_mmap(next); \ switch_mm((prev), (next), NULL); \ } while (0); @@ -167,7 +167,7 @@ static inline void arch_dup_pkeys(struct mm_struct *oldmm, static inline int arch_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) { arch_dup_pkeys(oldmm, mm); - paravirt_arch_dup_mmap(oldmm, mm); + paravirt_enter_mmap(mm); return ldt_dup_context(oldmm, mm); } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index 73e9522db7c1..07bbdceaf35a 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -332,16 +332,9 @@ static inline void tss_update_io_bitmap(void) } #endif -static inline void paravirt_activate_mm(struct mm_struct *prev, - struct mm_struct *next) +static inline void paravirt_enter_mmap(struct mm_struct *next) { - PVOP_VCALL2(mmu.activate_mm, prev, next); -} - -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) -{ - PVOP_VCALL2(mmu.dup_mmap, oldmm, mm); + PVOP_VCALL1(mmu.enter_mmap, next); } static inline int paravirt_pgd_alloc(struct mm_struct *mm) @@ -787,8 +780,7 @@ extern void default_banner(void); #ifndef __ASSEMBLY__ #ifndef CONFIG_PARAVIRT_XXL -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, - struct mm_struct *mm) +static inline void paravirt_enter_mmap(struct mm_struct *mm) { } #endif diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 8c1da419260f..71bf64b963df 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -164,11 +164,8 @@ struct pv_mmu_ops { unsigned long (*read_cr3)(void); void (*write_cr3)(unsigned long); - /* Hooks for intercepting the creation/use of an mm_struct. */ - void (*activate_mm)(struct mm_struct *prev, - struct mm_struct *next); - void (*dup_mmap)(struct mm_struct *oldmm, - struct mm_struct *mm); + /* Hook for intercepting the creation/use of an mm_struct. */ + void (*enter_mmap)(struct mm_struct *mm); /* Hooks for allocating and freeing a pagetable top-level */ int (*pgd_alloc)(struct mm_struct *mm); diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 327757afb027..ff1109b9c6cd 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -352,8 +352,7 @@ struct paravirt_patch_template pv_ops = { .mmu.make_pte = PTE_IDENT, .mmu.make_pgd = PTE_IDENT, - .mmu.dup_mmap = paravirt_nop, - .mmu.activate_mm = paravirt_nop, + .mmu.enter_mmap = paravirt_nop, .mmu.lazy_mode = { .enter = paravirt_nop, diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index cb258f58fdc8..cbc53da4c1b4 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -806,7 +806,7 @@ void __init poking_init(void) BUG_ON(!poking_mm); /* Xen PV guests need the PGD to be pinned. */ - paravirt_arch_dup_mmap(NULL, poking_mm); + paravirt_enter_mmap(poking_mm); /* * Randomize the poking address, but make sure that the following page diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index ee29fb558f2e..b3b8d289b9ab 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -885,14 +885,7 @@ void xen_mm_unpin_all(void) spin_unlock(&pgd_lock); } -static void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next) -{ - spin_lock(&next->page_table_lock); - xen_pgd_pin(next); - spin_unlock(&next->page_table_lock); -} - -static void xen_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) +static void xen_enter_mmap(struct mm_struct *mm) { spin_lock(&mm->page_table_lock); xen_pgd_pin(mm); @@ -2153,8 +2146,7 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { .make_p4d = PV_CALLEE_SAVE(xen_make_p4d), #endif - .activate_mm = xen_activate_mm, - .dup_mmap = xen_dup_mmap, + .enter_mmap = xen_enter_mmap, .exit_mmap = xen_exit_mmap, .lazy_mode = { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 08:36:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 08:36:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490917.759818 (Exim 4.92) (envelope-from ) id 1pPJS6-0007Ra-G5; Tue, 07 Feb 2023 08:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490917.759818; Tue, 07 Feb 2023 08:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJS6-0007RT-DC; Tue, 07 Feb 2023 08:35:46 +0000 Received: by outflank-mailman (input) for mailman id 490917; Tue, 07 Feb 2023 08:35:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJS5-0007RJ-5Z; Tue, 07 Feb 2023 08:35:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJS5-0003Mt-3e; Tue, 07 Feb 2023 08:35:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJS4-0006oI-OY; Tue, 07 Feb 2023 08:35:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPJS4-0002B0-Nx; Tue, 07 Feb 2023 08:35:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u7vDry9E5JN+t62tL7GS63MDSn9SIMDuTMMDDtMgNbQ=; b=RP0Y47m5XVZ8Py5sWj/Tl2k50e Ep5FkY6ZST3nsZ7VfAMwsy/Dv/v8oPJAP6hPGpqbpQUP2HcnwCzhqWLsZQnXu4ITMha8VYypKYeby uqHOPXTODvEsT8ivZLrBGopIMTV0oRheEOZK0GKgKqg71PKxdwWFvvMlvpENKLcvL9sk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176439: all pass - PUSHED X-Osstest-Versions-This: ovmf=aef0061ac22fb14d631aa0398d2cb496b2f7b8c8 X-Osstest-Versions-That: ovmf=aea8a9c954a79029ded443eadf7c92716c1753cc From: osstest service owner Date: Tue, 07 Feb 2023 08:35:44 +0000 flight 176439 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176439/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf aef0061ac22fb14d631aa0398d2cb496b2f7b8c8 baseline version: ovmf aea8a9c954a79029ded443eadf7c92716c1753cc Last test of basis 176426 2023-02-06 16:44:33 Z 0 days Testing same since 176439 2023-02-07 03:43:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Thierry LARONDE jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git aea8a9c954..aef0061ac2 aef0061ac22fb14d631aa0398d2cb496b2f7b8c8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 07 08:41:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 08:41:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490925.759829 (Exim 4.92) (envelope-from ) id 1pPJXZ-0000Qt-59; Tue, 07 Feb 2023 08:41:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490925.759829; Tue, 07 Feb 2023 08:41:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJXZ-0000Qm-1m; Tue, 07 Feb 2023 08:41:25 +0000 Received: by outflank-mailman (input) for mailman id 490925; Tue, 07 Feb 2023 08:41:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJXX-0000Qg-Ix for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 08:41:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJXX-0003TC-6z; Tue, 07 Feb 2023 08:41:23 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPJXX-0007W4-1E; Tue, 07 Feb 2023 08:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NMGu9IlDm6SJdAa7XdU6aw2VhY12g264AbakLErmg7w=; b=odiPZuUCsu/vktmJMcyOFn1SJO pJUqSscJtDTUTIvXAhopzNjNNUxQRmkXFyi4OwBzQl2wYlr1kSjEsTi2ieNwxF6LhLA9NrQSUc3zg eQHnIUVeqo+R7Dj57qmPkBPGQsHZqjE7chgYH1v/eoo3G9X3vSJckq0kJW2yUzXJ6LIY=; Message-ID: <3c4b0308-1042-b21c-e558-5bbf7bd34757@xen.org> Date: Tue, 7 Feb 2023 08:41:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 15/40] xen/arm: move MMU-specific memory management code to mm_mmu.c/mm_mmu.h Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-16-Penny.Zheng@arm.com> <6aebebad-2b01-4bd6-8a2f-7be3591382d8@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/02/2023 03:59, Penny Zheng wrote: >> -----Original Message----- >> From: Julien Grall >> Sent: Monday, February 6, 2023 5:30 AM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v2 15/40] xen/arm: move MMU-specific memory >> management code to mm_mmu.c/mm_mmu.h >> >> Hi, >> >> On 13/01/2023 05:28, Penny Zheng wrote: >>> From: Wei Chen >>> >>> To make the code readable and maintainable, we move MMU-specific >>> memory management code from mm.c to mm_mmu.c and move MMU- >> specific >>> definitions from mm.h to mm_mmu.h. >>> Later we will create mm_mpu.h and mm_mpu.c for MPU-specific memory >>> management code. >> >> This sentence implies there is no mm_mpu.{c, h} yet and this is not touched >> within this patch. However... >> >> >>> This will avoid lots of #ifdef in memory management code and header files. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Penny Zheng >>> --- >>> xen/arch/arm/Makefile | 5 + >>> xen/arch/arm/include/asm/mm.h | 19 +- >>> xen/arch/arm/include/asm/mm_mmu.h | 35 + >>> xen/arch/arm/mm.c | 1352 +--------------------------- >>> xen/arch/arm/mm_mmu.c | 1376 >> +++++++++++++++++++++++++++++ >>> xen/arch/arm/mm_mpu.c | 67 ++ >> >> ... It looks like they already exists and you are modifying them. That >> said, it would be better if this patch only contains code movement (IOW >> no MPU changes). >> >>> 6 files changed, 1488 insertions(+), 1366 deletions(-) >>> create mode 100644 xen/arch/arm/include/asm/mm_mmu.h >>> create mode 100644 xen/arch/arm/mm_mmu.c >> >> I don't particular like the naming. I think it would make more sense to >> introduce two directories: "mmu" and "mpu" which includes code specific >> to each flavor of Xen. >> > [...] >>> >>> - >>> -/* Release all __init and __initdata ranges to be reused */ >>> -void free_init_memory(void) >> >> This function doesn't look specific to the MMU. >> > > Functions like, early_fdt_map[1] / setup_frametable_mappings[2] / free_init_memory [3] ... I looked at setup_frametable_mappings() and didn't think it was possible to share much code. But I agree for early_fdt_map and free_init_memory(). > they both share quite the same logic as MMU does in MPU system, the difference could only > be address translation regime. Still, in order to avoid putting too much #ifdef here and there, > I implement different MMU and MPU version of them. I am not sure why you would need to put #ifdef in the code. Looking at it, there is usually only a chunk that is different for the mapping. So you could provide an helper that will be implemented in the MMU/MPU code. > > Or I keep them in generic file here, then in future commits when we implement MPU version > of them(I list related commits below), I transfer them to MMU file there. I am not entirely sure. In one way it help to figure out the commonality but on the other way we are mixing code movement and new code. In this case, the code movement would probably small, so that might be better for the review. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 08:47:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 08:47:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490934.759840 (Exim 4.92) (envelope-from ) id 1pPJdV-0001Eg-0M; Tue, 07 Feb 2023 08:47:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490934.759840; Tue, 07 Feb 2023 08:47:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJdU-0001EZ-Ta; Tue, 07 Feb 2023 08:47:32 +0000 Received: by outflank-mailman (input) for mailman id 490934; Tue, 07 Feb 2023 08:47:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJdU-0001ET-BZ for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 08:47:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJdT-0003k9-WA; Tue, 07 Feb 2023 08:47:31 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPJdT-0007jg-R4; Tue, 07 Feb 2023 08:47:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MO/N76B90w7ChXb/0G4rt7MHAvghcd+auTqIpGkNNxU=; b=isKtbCa0z2+kcB40DkO51uZntx cCmOTtR9tOct9lHBMkNMFIjn/D44BtB1yQztr5IDbsX7e+8yZTlVtZh686izN0MeLeIvevYsdVK15 pXqht7sh6EitlPBPzIPNByJxJTNXlXTtGMvdAOdc//dKvOy+JKPfnPL9Wz/oago68lWM=; Message-ID: <265b1d97-8a0b-8388-5edb-3d476ceb77ac@xen.org> Date: Tue, 7 Feb 2023 08:47:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU systems Content-Language: en-US To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-21-Penny.Zheng@arm.com> <78a79c41-e026-b8aa-cfbf-0482f7f5c171@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/02/2023 06:30, Penny Zheng wrote: > Hi Julien Hi Penny, >> -----Original Message----- >> From: Julien Grall >> Sent: Monday, February 6, 2023 6:11 PM >> To: Penny Zheng ; xen-devel@lists.xenproject.org >> Cc: Wei Chen ; Stefano Stabellini >> ; Bertrand Marquis ; >> Volodymyr Babchuk >> Subject: Re: [PATCH v2 20/40] xen/mpu: plump early_fdt_map in MPU >> systems >> >> Hi, >> >> A few more remarks. >> >> On 13/01/2023 05:28, Penny Zheng wrote: >>> In MPU system, device tree binary can be packed with Xen image through >>> CONFIG_DTB_FILE, or provided by bootloader through x0. >>> >>> In MPU system, each section in xen.lds.S is PAGE_SIZE aligned. >>> So in order to not overlap with the previous BSS section, dtb section >>> should be made page-aligned too. >>> We add . = ALIGN(PAGE_SIZE); in the head of dtb section to make it happen. >>> >>> In this commit, we map early FDT with a transient MPU memory region at >>> rear with REGION_HYPERVISOR_BOOT. >>> >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Wei Chen >>> --- >>> xen/arch/arm/include/asm/arm64/mpu.h | 5 +++ >>> xen/arch/arm/mm_mpu.c | 63 +++++++++++++++++++++++++--- >>> xen/arch/arm/xen.lds.S | 5 ++- >>> 3 files changed, 67 insertions(+), 6 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h >>> b/xen/arch/arm/include/asm/arm64/mpu.h >>> index fcde6ad0db..b85e420a90 100644 >>> --- a/xen/arch/arm/include/asm/arm64/mpu.h >>> +++ b/xen/arch/arm/include/asm/arm64/mpu.h >>> @@ -45,18 +45,22 @@ >>> * [3:4] Execute Never >>> * [5:6] Access Permission >>> * [7] Region Present >>> + * [8] Boot-only Region >>> */ >>> #define _REGION_AI_BIT 0 >>> #define _REGION_XN_BIT 3 >>> #define _REGION_AP_BIT 5 >>> #define _REGION_PRESENT_BIT 7 >>> +#define _REGION_BOOTONLY_BIT 8 >>> #define _REGION_XN (2U << _REGION_XN_BIT) >>> #define _REGION_RO (2U << _REGION_AP_BIT) >>> #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) >>> +#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) >>> #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) >>> #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) >>> #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) >>> #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) >>> +#define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) >> & 0x1U) >>> >>> /* >>> * _REGION_NORMAL is convenience define. It is not meant to be used >>> @@ -68,6 +72,7 @@ >>> #define REGION_HYPERVISOR_RO >> (_REGION_NORMAL|_REGION_XN|_REGION_RO) >>> >>> #define REGION_HYPERVISOR REGION_HYPERVISOR_RW >>> +#define REGION_HYPERVISOR_BOOT >> (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) >>> >>> #define INVALID_REGION (~0UL) >>> >>> diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c index >>> 08720a7c19..b34dbf4515 100644 >>> --- a/xen/arch/arm/mm_mpu.c >>> +++ b/xen/arch/arm/mm_mpu.c >>> @@ -20,11 +20,16 @@ >>> */ >>> >>> #include >>> +#include >>> #include >>> #include >>> +#include >>> +#include >>> #include >>> #include >>> +#include >>> #include >>> +#include >>> >>> #ifdef NDEBUG >>> static inline void >>> @@ -62,6 +67,8 @@ uint64_t __ro_after_init max_xen_mpumap; >>> >>> static DEFINE_SPINLOCK(xen_mpumap_lock); >>> >>> +static paddr_t dtb_paddr; >>> + >>> /* Write a MPU protection region */ >>> #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ >>> uint64_t _sel = sel; \ >>> @@ -403,7 +410,16 @@ static int xen_mpumap_update_entry(paddr_t >> base, >>> paddr_t limit, >>> >>> /* During boot time, the default index is next_fixed_region_idx. */ >>> if ( system_state <= SYS_STATE_active ) >>> - idx = next_fixed_region_idx; >>> + { >>> + /* >>> + * If it is a boot-only region (i.e. region for early FDT), >>> + * it shall be added from the tail for late init re-organizing >>> + */ >>> + if ( REGION_BOOTONLY_MASK(flags) ) >>> + idx = next_transient_region_idx; >>> + else >>> + idx = next_fixed_region_idx; >>> + } >>> >>> xen_mpumap[idx] = pr_of_xenaddr(base, limit - 1, >> REGION_AI_MASK(flags)); >>> /* Set permission */ >>> @@ -465,14 +481,51 @@ int map_pages_to_xen(unsigned long virt, >>> mfn_to_maddr(mfn_add(mfn, nr_mfns)), flags); >>> } >>> >>> -/* TODO: Implementation on the first usage */ -void >>> dump_hyp_walk(vaddr_t addr) >>> +void * __init early_fdt_map(paddr_t fdt_paddr) >>> { >>> + void *fdt_virt; >>> + uint32_t size; >>> + >>> + /* >>> + * Check whether the physical FDT address is set and meets the >> minimum >>> + * alignment requirement. Since we are relying on MIN_FDT_ALIGN to >> be at >>> + * least 8 bytes so that we always access the magic and size fields >>> + * of the FDT header after mapping the first chunk, double check if >>> + * that is indeed the case. >>> + */ >>> + BUILD_BUG_ON(MIN_FDT_ALIGN < 8); >>> + if ( !fdt_paddr || fdt_paddr % MIN_FDT_ALIGN ) >>> + return NULL; >>> + >>> + dtb_paddr = fdt_paddr; >>> + /* >>> + * In MPU system, device tree binary can be packed with Xen image >>> + * through CONFIG_DTB_FILE, or provided by bootloader through x0. >> >> The behavior you describe is not specific to the MPU system. I also don't >> quite understand how describing the method to pass the DT actually matters >> here. >> >>> + * Map FDT with a transient MPU memory region of MAX_FDT_SIZE. >>> + * After that, we can do some magic check. >>> + */ >>> + if ( map_pages_to_xen(round_pgdown(fdt_paddr), >> >> I haven't looked at the rest of the series. But from here, it seems a bit strange >> to use map_pages_to_xen() because the virt and the phys should be the >> same. >> > > Hmm, t thought map_pages_to_xen, is to set up memory mapping for access. > In MPU, we also need to set up a MPU memory region for the FDT, even without > virt-to-phys conversion I think my point was misunderstood. I agree that we need a function to update the MPU. Instead I was asking whether using map_pages_to_xen() rather than creating a new helper with an MPU specific would not be better so we don't have to pass a pointless parameter (virt). That's why... > >> Do you plan to share some code where map_pages_to_xen() will be used? ... I was asking if you were going to share code with the MMU that may end up to use this function. If yes, then I agree in common code, it would be best to use map_pages_to_xen(). For MPU specific code, I would consider to provide an helper that doesn't need the virt to reduce the amount of unnecessary code. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 09:03:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 09:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490940.759850 (Exim 4.92) (envelope-from ) id 1pPJst-0003nY-Aa; Tue, 07 Feb 2023 09:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490940.759850; Tue, 07 Feb 2023 09:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJst-0003nR-7s; Tue, 07 Feb 2023 09:03:27 +0000 Received: by outflank-mailman (input) for mailman id 490940; Tue, 07 Feb 2023 09:03:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJsr-0003nJ-Sd for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 09:03:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPJsr-00044I-GZ; Tue, 07 Feb 2023 09:03:25 +0000 Received: from [54.239.6.184] (helo=[192.168.19.254]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPJsr-0008N3-8x; Tue, 07 Feb 2023 09:03:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3+OKKIlDVqxj00raOPnDeDddYAcXyXZNdnlMzpY+erY=; b=3s82OlcTXmmALXS8UWAuFeQxQy Jy+9yqf61lni2VyC/gHyvHC5azza8vHAMkAJ9U8YdPGyXxqwHQq7P4ivx1/wi3iUkAUNEGKFAkGvP z+MPXshA4Be44YbVQfmm2kTsy5oVxYgli2mNs7/rz2zENcWjSNvi5n3IKhLZWvcVyk4g=; Message-ID: <4f98390c-1cf3-99f3-5131-a42a7ed4387a@xen.org> Date: Tue, 7 Feb 2023 09:03:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size Content-Language: en-US To: Ayan Kumar Halder , Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-6-ayan.kumar.halder@amd.com> <8144403d-0899-5b25-f1b0-f798d4b371a6@amd.com> From: Julien Grall In-Reply-To: <8144403d-0899-5b25-f1b0-f798d4b371a6@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/02/2023 19:21, Ayan Kumar Halder wrote: > Hi Stefano, > > On 19/01/2023 23:24, Stefano Stabellini wrote: >> On Tue, 17 Jan 2023, Ayan Kumar Halder wrote: >>> One should now be able to use 'paddr_t' to represent address and size. >>> Consequently, one should use 'PRIpaddr' as a format specifier for >>> paddr_t. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from - >>> >>> v1 - 1. Rebased the patch. >>> >>>   xen/arch/arm/domain_build.c        |  9 +++++---- >>>   xen/arch/arm/gic-v3.c              |  2 +- >>>   xen/arch/arm/platforms/exynos5.c   | 26 +++++++++++++------------- >>>   xen/drivers/char/exynos4210-uart.c |  2 +- >>>   xen/drivers/char/ns16550.c         |  8 ++++---- >>>   xen/drivers/char/omap-uart.c       |  2 +- >>>   xen/drivers/char/pl011.c           |  4 ++-- >>>   xen/drivers/char/scif-uart.c       |  2 +- >>>   xen/drivers/passthrough/arm/smmu.c |  6 +++--- >>>   9 files changed, 31 insertions(+), 30 deletions(-) >>> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index 72b9afbb4c..cf8ae37a14 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -1666,7 +1666,7 @@ static int __init find_memory_holes(const >>> struct kernel_info *kinfo, >>>       dt_for_each_device_node( dt_host, np ) >>>       { >>>           unsigned int naddr; >>> -        u64 addr, size; >>> +        paddr_t addr, size; >>>           naddr = dt_number_of_address(np); >>> @@ -2445,7 +2445,7 @@ static int __init handle_device(struct domain >>> *d, struct dt_device_node *dev, >>>       unsigned int naddr; >>>       unsigned int i; >>>       int res; >>> -    u64 addr, size; >>> +    paddr_t addr, size; >>>       bool own_device = !dt_device_for_passthrough(dev); >>>       /* >>>        * We want to avoid mapping the MMIO in dom0 for the following >>> cases: >>> @@ -2941,9 +2941,10 @@ static int __init >>> handle_passthrough_prop(struct kernel_info *kinfo, >>>           if ( res ) >>>           { >>>               printk(XENLOG_ERR "Unable to permit to dom%d access to" >>> -                   " 0x%"PRIx64" - 0x%"PRIx64"\n", >>> +                   " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", >>>                      kinfo->d->domain_id, >>> -                   mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); >>> +                   (paddr_t) (mstart & PAGE_MASK), >>> +                   (paddr_t) (PAGE_ALIGN(mstart + size) - 1)); >> Why do you need the casts here? mstart is already defined as paddr_t > > Actually, this is because the PAGE_MASK is defined as 'long'. See > xen/include/xen/page-size.h :- > > #define PAGE_SIZE           (_AC(1,L) << PAGE_SHIFT) > #define PAGE_MASK           (~(PAGE_SIZE-1)) > > So, the resultant type inferred is 'long unsigned int'. Thus, we need to > add an explicit cast. Hmmm... I am a bit confused with this statement. If the resultant type inferred is actually 'long unsigned int', then why was the current specifier worked before ('long unsigned int' is 32-bit on Arm32)? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 09:35:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 09:35:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490958.759867 (Exim 4.92) (envelope-from ) id 1pPKO4-0007Xk-Q8; Tue, 07 Feb 2023 09:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490958.759867; Tue, 07 Feb 2023 09:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKO4-0007Xd-NN; Tue, 07 Feb 2023 09:35:40 +0000 Received: by outflank-mailman (input) for mailman id 490958; Tue, 07 Feb 2023 09:35:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKO3-0007XH-9m for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 09:35:39 +0000 Received: from de-smtp-delivery-114.mimecast.com (de-smtp-delivery-114.mimecast.com [194.104.111.114]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c63d1f77-a6ca-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 10:35:36 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-44-35q8XptyPieKh3wbJbcPRw-1; Tue, 07 Feb 2023 10:35:31 +0100 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com (2603:10a6:203:9e::22) by AS8PR08MB9316.eurprd08.prod.outlook.com (2603:10a6:20b:5a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 09:35:28 +0000 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::2fae:319e:cfcf:3caf]) by AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::2fae:319e:cfcf:3caf%11]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 09:35:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63d1f77-a6ca-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zf.com; s=mczfcom20220728; t=1675762535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RBnNRH/Do97IW0AnYEaEY567CFFYoYzLoEiSGhAWhLo=; b=YH5cILtC4OWHt8l1EYfjfUHR5UGDs/kcdc+VmP5+EAjAZxc1bAiyEehNgx6Y9gP7HoypO7 aEolI0qA+Y6vbFhQckL+wtCnSsUONWkEafsUxJHCl31n3RC/4eco2KhsACLMl+lHC0P99Y cI7tsah4ZiURrsffkDSDNY3weqm31tk= X-MC-Unique: 35q8XptyPieKh3wbJbcPRw-1 From: El Mesdadi Youssef ESK UILD7 To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini Subject: AW: AW: Xenstore failed to start / Xenalyze on ARM ( NXP S32G3 with Cortex-A53) Thread-Topic: AW: Xenstore failed to start / Xenalyze on ARM ( NXP S32G3 with Cortex-A53) Thread-Index: AQHZOteDcvsBZrsC1U2+NXCuNzWqRA== Date: Tue, 7 Feb 2023 09:35:28 +0000 Message-ID: References: <3e7059c2-0d23-03f2-9a93-f88de09171f4@xen.org> <619a00f0-0f9f-5f5f-13a7-ea86f9c24eec@xen.org> In-Reply-To: <619a00f0-0f9f-5f5f-13a7-ea86f9c24eec@xen.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Enabled=true; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SetDate=2023-02-07T09:35:26Z; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Method=Privileged; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Name=Internal sub2 (no marking); MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SiteId=eb70b763-b6d7-4486-8555-8831709a784e; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ActionId=1dd26ef2-7370-48f7-8942-e53a52ceae44; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ContentBits=0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM5PR0802MB2578:EE_|AS8PR08MB9316:EE_ x-ms-office365-filtering-correlation-id: f9ee14ed-1869-4552-037f-08db08eea600 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: jbhZz8acsGN86jcQrLBpGldfrBNygmZHdwPZjhCYu3jygzqhuk4MIQC05rfcZbOP9BRl+iQAKSf8boOzfzGHQOegS7yDo25NRipqMv8YgAebFCshHJ4/nBUSLUyNtVc+LtdTZTLboiTs8hAWSvm8qvh7AhvGDcIY8MZ0HTUa8Z9FWU6MEeq0jxH1Wxgb51Z5t5u9lmlrg1UMaKb/TXUNj8k++30QUNmM536uUy4fUfhuxAxkYeL52z/K5zjk6V/CjP3/mgiUi56IhscW8ZZmvgwPPwAvepVchn2a9rSUCvrSBNjCaGcSw7Nf2mVAwCG/fobJr4qMRzDbQ1INtvLUzQaft3lS7X82Wajd58nQLYtBt/mWJrD0Wkx5IUSHw0sFVa83g+CTZIQgo9aMr2t1Yd63y4K2MMuUwqw50z4ycOD6Rrziu4QeukhnCoLoumXM+OKylk4YV/BM9f0ccvRhRKvpSOIr5wxex5ihK7tR5rRNC43EH21/q1FB1f2enIb98Q1Up013LY/4fMQhLNxZSqT6Gsp6bYHpb9sG0BpZNbgdvEG7w+w05A+Hia5TilPX23KhnoHWUAG4dM290c11tyWgSoFpa3yzl5YqoHvFvmYdqe+ukyyTFVCfK0ObgIHLE23cMNqCJawTuQUv8eZ4bZeXrLoaFHTgeN5bMICVNpxSpNXexh7+7At8+UYpwPFbHKtyTKdvrFyFLytP3j5sLjyg2DJi0epyCRRsVJnzDRw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0802MB2578.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(451199018)(4326008)(4001150100001)(38100700002)(82960400001)(122000001)(38070700005)(316002)(52536014)(8936002)(8676002)(64756008)(66476007)(66446008)(41300700001)(66556008)(76116006)(2906002)(5660300002)(30864003)(66946007)(53546011)(6506007)(478600001)(26005)(9686003)(186003)(33656002)(86362001)(83380400001)(110136005)(66574015)(7696005)(71200400001)(55016003)(559001)(579004)(357404004);DIR:OUT;SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZEIvMDd4UkQwdUNCayt6cms3SDlKR0cwWDJ4UnM1cXZRdXR5TGR0aUVuTTk3?= =?utf-8?B?Q1lTODJzdGNyV3dXbVN6RjB1d1V5aW8wZ3NNbnN3RzBsSTR1dFRhTmJuMm5u?= =?utf-8?B?YTROK2FkQmxoKy91aWhMdzlmbGZ4aDhmWlMxU1lUWTRVTkhrc0NsSjVwUWVM?= =?utf-8?B?RDcyb09JUE9CYmMzK0JPVFB4OUNWcUpxQ1FYVTVCd1NLS21Wd2pVL2tWRElY?= =?utf-8?B?MDdZUzBCamtYYkwvSG5uQTNXaWxZS0RLeDE2YlNVZHBKR3VxWmRid3R4RGNj?= =?utf-8?B?OTBqMzU5QlJsVEJORGh3WGZJYUNCSG5xQWhORlVTV0laaDM5RXdudm9VRU5s?= =?utf-8?B?ZUMvd0tGbHJrWEN1M3FEcWswRVliRklTZ2Y0QjgrSnhMc09DdDFwK205b1hO?= =?utf-8?B?UEd1RnhZaUl2S1ZqemQzMi8vbnc3S1JXdE4wVVR0dmR1NC9IN2xQSkdoK0d6?= =?utf-8?B?anU5K0FCWEM3UXFobUltTDA5b0wvOGliNHc1dU1wcFd0SExabWMvbTFTOWtx?= =?utf-8?B?N0ZvMlVoNjFqOTNwMmxJZTRjUmd6SE80c3BURzR1WDdacnQwdG9ISmc0aTQy?= =?utf-8?B?eERpT2E1U1grZENBbU04c1ByZXJUL2lPSjJ5V2wzSWJvL3dCUklwTVNvcUxQ?= =?utf-8?B?Mk8ySnVTNmlWVFpRQ3JBY3FGRWhuZ1hZTEFHaFp0d0xoLzV2UDlvY2lCMnli?= =?utf-8?B?eGJSSDdxWEJtZGVEVGdIWjZBOFF2c20wd3YyU2dVSmtWYXlQOGx0bitHQVg0?= =?utf-8?B?NkJFdDI2U0dDUDV2dEFJVmU1ZytjcEFtM1pSYU9QWjFmaUMrMWVhMVpPcEZ5?= =?utf-8?B?T0hRaHJkM3llS3BpakFkaW9OeVJYUFRlV1FzaDF3bytuclYxK054eTc2ZXNY?= =?utf-8?B?T3lzNlgyaWpDRWZRdmg2NGIvT09wY2RmdU1TU3h5R2FOUlJrQ2ZrL0x4SytL?= =?utf-8?B?QVA3TzBLeldjbWVMZ1RqbzRTUGhzZ2NYVG1VY1Izam5PUXFYY3k1M3hFUUpy?= =?utf-8?B?dUdWWU9IWituTFNZNFpheWR2TkYwWm1ZbjBoWElxSXNWQmx0Z2FqaExhR1lT?= =?utf-8?B?Z1luS0RmSERycEo1Y25taEVIdXB4NUlmZ2ttNVZxdXZDdHJLQWI3SWN0cy9W?= =?utf-8?B?by83eVlzcVZiL0w0WWQrdythcmt3RDFxMDBvREtmeGlRVFVNTUd4T1d0QXVV?= =?utf-8?B?VWFnRmx4Q0IyWnd5Y3ZQSS9tLy9TWjFpbGJ2TVVYbWU3WU93YUlSK2xYY2xU?= =?utf-8?B?b3pOaE1JWXViWEF6QjVJVE1ScDg3amRvQjRaZENuZUlFY000Wk5UODY5SFhD?= =?utf-8?B?cHdtYi8ySHU0TlkwdVZsdGIralVDUGFScThla2dLUFdQbzUxUmpKNzJHNE41?= =?utf-8?B?N3ZoZzY4a2JrZXRPaFNGcDZieHNvL0xNa2pXQkQ1VEFvb0c5VTBtMk56czZW?= =?utf-8?B?Z0JnV2Z6ckNTaEJsTXVqaFpFRTkwOCt3WVNjVlZFblJuT3huUUg4R0hxYk9w?= =?utf-8?B?WWRkSHZZZGhOcXhqZ1VHdlZSYXRTcUxJV29zYm02ZGNPSFRqbzFWZWNlSk9Z?= =?utf-8?B?NDRvT3JkNklWUkY4ZmduTTJ4YkxSb1c0WEh2VkJhM0k1Tm9EOHU3bFZVR0xN?= =?utf-8?B?L1c4TnYzNzZDenRYQVppelhjaVBmT3p6QmVLOUdjdUZnR0hTeDJHRVl0WGVj?= =?utf-8?B?NDRPdUwrN0c0MnB3SFRFc2czYnFDUy9mczJHOEdOcGRsdlN6VEY4S0xGOGlp?= =?utf-8?B?NXJDTG53Y3NQMlZoalhLcUpJeTJmbUJidVA3cEFrYXB6QWRhTlJXeHp6aGVT?= =?utf-8?B?NUtaV0ZvbWMzVUwzdXRUcExMYWNTTTBEb0NsYmJ3cjV4YVFkMG1EdmxIM2hz?= =?utf-8?B?eXh1VGMvNmxONFNLQXlHcmp5RlpFMnhBalcwbkVwYS9Qcm9JT045bHhCMkE3?= =?utf-8?B?L1ZaNHZ3SFU0TlpQcFpndnZWeVBPQ29zVCsycm1LWFZGNkVBNG9rRVc4b21N?= =?utf-8?B?M2dBVTl5OUgrdGxWZ0FpcDhpQkV1QS9PaWxxaGNWYU5kOGEzTGRldGhkcDBq?= =?utf-8?B?TWNJaTMzWWRiZGNCL3Z4L1g1eURQdVUrY21EMlp4dldMdUdzRjRaRkZEekwx?= =?utf-8?Q?PrCDzbVgiwhxsIc6c7owhdpZa?= MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8EMN6IlyjfpSwvKVrlKtJmea0FWYiNQa4UF2EcFKqJWHOVf8olPuVExZGTvWxhsZitwssUM+LqijyrwYB/Pq+KkansyCZf9Q07+owVujv/bSalJ2UQ9H3rFakDPTHs8RW/QZe+AqrFCNllDWeyr029O1OobjgHRs6SSxDp69i5s25kfW2jkYx1Av8xtUFkhOVesloSfVHtu7tGXMa/84B0JPxmtm+XbUU7kNT8j7K4Hedkq2C2/eDTOI33DYdFtyQJ592bl3BRvjQGem4giJS7kFcypBtg5M+hNDaW/t/Oe/NkgUuqMwX2P57yLzEo4roO8rnDV0GHZB2MU+ypJnTU8XzVdKiUWpTx5Mtl8OwqTkEA3j5EBwV83PVk9I6F3ap/QeQOzQmnvkgvWwuLi2g0mHScdKoRFBQNw32BGDNpBY6YN/uYKo5chf1TOpHlNmZn29xoVb+juwjW1iFZW+xEU6n6sKhBkOBictUNH1WVElEQ3V6wp4qJWkQ5DwkCv5bVUmbiHKRQpHxeAP8sGx9FvnLgrapdmDhYkfDfTJgZhf5rZN6mSKcPX5NGTqU+L9yrWFyZDU6aBXrCrHxTzo1YYNmv7Bh/RGhHWyJpT4zO1www4rbMs7Zp5+iuLwYCX7aVANh8Jj2C82A4ENJrrJVF/UrsMcRWGMXcg9YRgMqRn06QdQiQ2kX1Qle8HVnt7mYugD0+Mb+mLAYACp1UHDu/j4lPCxFZVlB44sb2emFMxKBURmGPpc9UyXSYuTyuYrL9SuGPlXB+3QeGY25bda1Uc2vvyz2uNGQzp7H2eJbOVJO60VBq6LpXRp68Qye6m3irD4ERXSLCvaz4UzsJPpqw== X-OriginatorOrg: zf.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0802MB2578.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9ee14ed-1869-4552-037f-08db08eea600 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 09:35:28.3002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: eb70b763-b6d7-4486-8555-8831709a784e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tMC7+wkbvt4dWcEocCcKkDu5ua7Z1ym6hGkTwaxgy9A1Cws/VSfVNcS3A1kLDgxxQjK2Vd+vlNyGCBZN/D+sHBHcB+02zgurO5wL+CCZzo4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9316 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: zf.com Content-Language: de-DE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 PiBoZWxsbyBKdWxpZW4sDQoNCj5maXJzdCBvZiBhbGwgdGhhbmsgeW91IHNvIG11Y2ggZm9yIHRo ZSBzdXBwb3J0LCAgYWZ0ZXIgZmxhc2hpbmcgWGVuIG9uIHRoZSBTMzJHMyBJIG5vdGljZWQgdGhh dCBJIGNhbm5vdCBjcmVhdGUgRG9tVXMuDQo+d2hlbiBJIGFsc28gZ2l2ZSB0aGUgeGwgbGlzdCwg aXQgZG9lcyBub3QgZXZlbiBzaG93IERvbTAgYW5kIHN0YXlzIGJsb2NrZWQuDQoNCnJvb3RAczMy ZzM5OWFldmIzOn4jIHhsIGxpc3QNCk5hbWUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgSUQgICBNZW0gVkNQVXMgICAgICBTdGF0ZSAgIFRpbWUocykNCg0Kcm9vdEBzMzJn Mzk5YWV2YjM6fiMgDQoNCg0KPkkgYXNzdW1lIHRoaXMgaXMgYmVjYXVzZSB4ZW5zdG9yZSBmYWls ZWQgdG8gc3RhcnQsIHRoZSBlcnJvciBpcyBzaG93biBpbiB0aGUgbWVzc2FnZXMgZHVyaW5nIHRo ZSBib290IHRpbWUuDQoNCltGQUlMRURdIEZhaWxlZCB0byBzdGFydCBUaGUgWGVuIHhlbnN0b3Jl Lg0KU2VlICdzeXN0ZW1jdGwgc3RhdHVzIHhlbnN0b3JlZC5zZXJ2aWNlJyBmb3IgZGV0YWlscy4N Cg0KW0ZBSUxFRF0gRmFpbGVkIHRvIG1vdW50IE5GU0QgY29uZmlndXJhdGlvbiBmaWxlc3lzdGVt Lg0KU2VlICdzeXN0ZW1jdGwgc3RhdHVzIHByb2MtZnMtbmZzZC5tb3VudCcgZm9yIGRldGFpbHMu DQoNCj5IZXJlIGlzIHhsLmNvbmYgaW4gY2FzZSB5b3UgbmVlZCBpbmZvcm1hdGlvbiBhYm91dCB0 aGlzIGZpbGU6DQoNCnJvb3RAczMyZzM5OWFldmIzOi9ldGMveGVuIyBjYXQgeGwuY29uZg0KIyMg R2xvYmFsIFhMIGNvbmZpZyBmaWxlICMjDQoNCiMgU2V0IGRvbWFpbi1pZCBwb2xpY3kuICJ4ZW4i IG1lYW5zIHRoYXQgdGhlIGh5cGVydmlzb3Igd2lsbCBjaG9vc2UgdGhlDQojIGlkIG9mIGEgbmV3 IGRvbWFpbi4gInJhbmRvbSIgbWVhbnMgdGhhdCBhIHJhbmRvbSB2YWx1ZSB3aWxsIGJlIGNob3Nl bi4NCiNkb21pZF9wb2xpY3k9InhlbiINCg0KIyBDb250cm9sIHdoZXRoZXIgZG9tMCBpcyBiYWxs b29uZWQgZG93biB3aGVuIHhlbiBkb2Vzbid0IGhhdmUgZW5vdWdoDQojIGZyZWUgbWVtb3J5IHRv IGNyZWF0ZSBhIGRvbWFpbi4gICJhdXRvIiBtZWFucyBvbmx5IGJhbGxvb24gaWYgZG9tMA0KIyBz dGFydHMgd2l0aCBhbGwgdGhlIGhvc3QncyBtZW1vcnkuDQojYXV0b2JhbGxvb249ImF1dG8iDQoN CiMgZnVsbCBwYXRoIG9mIHRoZSBsb2NrZmlsZSB1c2VkIGJ5IHhsIGR1cmluZyBkb21haW4gY3Jl YXRpb24NCiNsb2NrZmlsZT0iL3Zhci9sb2NrL3hsIg0KDQojIGRlZmF1bHQgb3V0cHV0IGZvcm1h dCB1c2VkIGJ5ICJ4bCBsaXN0IC1sIg0KI291dHB1dF9mb3JtYXQ9Impzb24iDQoNCiMgZmlyc3Qg YmxvY2sgZGV2aWNlIHRvIGJlIHVzZWQgZm9yIHRlbXBvcmFyeSBWTSBkaXNrIG1vdW50cw0KI2Js a2Rldl9zdGFydD0ieHZkYSINCg0KIyBkZWZhdWx0IG9wdGlvbiB0byBydW4gaG90cGx1ZyBzY3Jp cHRzIGZyb20geGwNCiMgaWYgZGlzYWJsZWQgdGhlIG9sZCBiZWhhdmlvdXIgd2lsbCBiZSB1c2Vk LCBhbmQgaG90cGx1ZyBzY3JpcHRzIHdpbGwgYmUNCiMgbGF1bmNoZWQgYnkgdWRldi4NCiNydW5f aG90cGx1Z19zY3JpcHRzPTENCg0KIyBkZWZhdWx0IGJhY2tlbmQgZG9tYWluIHRvIGNvbm5lY3Qg Z3Vlc3QgdmlmcyB0by4gIFRoaXMgY2FuIGJlIGFueQ0KIyB2YWxpZCBkb21haW4gaWRlbnRpZmll ci4NCiN2aWYuZGVmYXVsdC5iYWNrZW5kPSIwIg0KDQojIGRlZmF1bHQgZ2F0ZXdheSBkZXZpY2Ug dG8gdXNlIHdpdGggdmlmLXJvdXRlIGhvdHBsdWcgc2NyaXB0DQojdmlmLmRlZmF1bHQuZ2F0ZXdh eWRldj0iZXRoMCINCg0KIyBkZWZhdWx0IHZpZiBzY3JpcHQgdG8gdXNlIGlmIG5vbmUgaXMgc3Bl Y2lmaWVkIGluIHRoZSBndWVzdCBjb25maWcNCiN2aWYuZGVmYXVsdC5zY3JpcHQ9InZpZi1icmlk Z2UiDQoNCiMgZGVmYXVsdCBicmlkZ2UgZGV2aWNlIHRvIHVzZSB3aXRoIHZpZi1icmlkZ2UgaG90 cGx1ZyBzY3JpcHRzDQojdmlmLmRlZmF1bHQuYnJpZGdlPSJ4ZW5icjAiDQoNCiMgUmVzZXJ2ZSBh IGNsYWltIG9mIG1lbW9yeSB3aGVuIGxhdW5jaGluZyBhIGd1ZXN0LiBUaGlzIGd1YXJhbnRlZXMg aW1tZWRpYXRlDQojIGZlZWRiYWNrIHdoZXRoZXIgdGhlIGd1ZXN0IGNhbiBiZSBsYXVuY2hlZCBk dWUgdG8gbWVtb3J5IGV4aGF1c3Rpb24NCiMgKHdoaWNoIGNhbiB0YWtlIGEgbG9uZyB0aW1lIHRv IGZpbmQgb3V0IGlmIGxhdW5jaGluZyBodWdlIGd1ZXN0cykuDQojIHNlZSB4bC5jb25mKDUpIGZv ciBkZXRhaWxzLg0KI2NsYWltX21vZGU9MQ0KDQojIFNwZWNpZnkgZ2xvYmFsIHZjcHUgaGFyZCBh ZmZpbml0eSBtYXNrcy4gU2VlIHhsLmNvbmYoNSkgZm9yIGRldGFpbHMuDQojdm0uY3B1bWFzaz0i MC03Ig0KI3ZtLnB2LmNwdW1hc2s9IjAtMyINCiN2bS5odm0uY3B1bWFzaz0iMy03Ig0KDQoNCj5u ZXh0IGFyZSB0aGUgbWVzc2FnZXMgZHVyaW5nIHRoZSBib290IHRpbWU6DQoNCk5PVElDRTogIFJl c2V0IHN0YXR1czogUG93ZXItT24gUmVzZXQNCk5PVElDRTogIEJMMjogdjIuNShyZWxlYXNlKTpi c3AzMy4wLTIuNS1kaXJ0eQ0KTk9USUNFOiAgQkwyOiBCdWlsdCA6IDE0OjAxOjA5LCBKdW4gMTUg MjAyMg0KTk9USUNFOiAgQkwyOiBCb290aW5nIEJMMzENCg0KDQpVLUJvb3QgMjAyMC4wNCtnOWNk ZmNhNjg2ZSAoSnVuIDEwIDIwMjIgLSAxMTo0Njo0MSArMDAwMCkNCg0KQ1BVOiAgIE5YUCBTMzJH Mzk5QSByZXYuIDEuMA0KTW9kZWw6IE5YUCBTMzJHM1hYWC1FVkINCkRSQU06ICAzLjUgR2lCDQpN TUM6ICAgRlNMX1NESEM6IDANCkxvYWRpbmcgRW52aXJvbm1lbnQgZnJvbSBNTUMuLi4gT0sNClVz aW5nIGludGVybmFsIGNsb2NrIGZvciBQQ0llMCwgQ1JOUw0KQ29uZmlndXJpbmcgUENJZTAgYXMg Um9vdENvbXBsZXgoeDIpDQpVc2luZyBpbnRlcm5hbCBjbG9jayBmb3IgUENJZTEsIENSTlMNCkZy ZXF1ZW5jeSAxMDBNaHogY29uZmlndXJlZCBmb3IgUENJZTENCkNvbmZpZ3VyaW5nIFBDSWUxIGFz IFNHTUlJIFtYUENTMCAxRywgWFBDUzEgT0ZGKFBDSWV4MSldDQpTZXR0aW5nIFBDSSBEZXZpY2Ug YW5kIFZlbmRvciBJRHMgdG8gMHg0MzAwOjB4MTk1Nw0KUENJZTA6IEZhaWxlZCB0byBnZXQgbGlu ayB1cA0KUGNpZTA6IExJTktfREJHXzE6IDB4MDAwMDAwMDAsIExJTktfREJHXzI6IDB4MDAwMDA4 MDAgKGV4cGVjdGVkIDB4MDAwMDAwZDEpDQpERUJVR19SMDogMHgwMGVkNDAwMSwgREVCVUdfUjE6 IDB4MDg2MDAwMDANClBDSTogRmFpbGVkIGF1dG9jb25maWcgYmFyIDFjDQpQQ0llMTogTm90IGNv bmZpZ3VyaW5nIFBDSWUsIFBIWSBub3QgY29uZmlndXJlZA0KSW46ICAgIHNlcmlhbEA0MDFjODAw MA0KT3V0OiAgIHNlcmlhbEA0MDFjODAwMA0KRXJyOiAgIHNlcmlhbEA0MDFjODAwMA0KTG9hZGlu ZyBTSkExMTA1IGZpcm13YXJlIG92ZXIgU1BJIDU6MA0KTm8gbWF0Y2hpbmcgZGV2aWNlIElEIGZv dW5kIGZvciBkZXZpZCBGRkZGRkZGRiwgY3MgMC4NCkVycm9yIFNKQTExMDUgY29uZmlndXJhdGlv biBub3QgY29tcGxldGVkDQpOZXQ6ICAgRVFPUyBwaHk6IHJnbWlpIEAgNA0KDQpXYXJuaW5nOiBl dGhfZXFvcyAoZXRoMCkgdXNpbmcgcmFuZG9tIE1BQyBhZGRyZXNzIC0gZjY6NjU6ODY6YTI6MGU6 ZjgNCmV0aDA6IGV0aF9lcW9zIFBGRTogZW1hYzA6IHNnbWlpIGVtYWMxOiBub25lIGVtYWMyOiBu b25lDQoNCldhcm5pbmc6IGV0aF9wZmVuZyB1c2luZyBNQUMgYWRkcmVzcyBmcm9tIFJPTQ0KLCBl dGgxOiBldGhfcGZlbmcNCkhpdCBhbnkga2V5IHRvIHN0b3AgYXV0b2Jvb3Q6ICAwDQogUEZFOiBl bWFjMDogc2dtaWkgZW1hYzE6IG5vbmUgZW1hYzI6IG5vbmUNCiBQRkU6IGVtYWMwOiBzZ21paSBl bWFjMTogbm9uZSBlbWFjMjogbm9uZQ0KMTAzOSBieXRlcyByZWFkIGluIDkgbXMgKDExMi4zIEtp Qi9zKQ0KIyMgRXhlY3V0aW5nIHNjcmlwdCBhdCA4MDIwMDAwMA0KMTA0ODY4OCBieXRlcyByZWFk IGluIDM2IG1zICgyNy44IE1pQi9zKQ0KMTQwMzQ5NTIgYnl0ZXMgcmVhZCBpbiAyMDEgbXMgKDY2 LjYgTWlCL3MpDQozODQ2MSBieXRlcyByZWFkIGluIDkgbXMgKDQuMSBNaUIvcykNCiMjIEZsYXR0 ZW5lZCBEZXZpY2UgVHJlZSBibG9iIGF0IDg2NjAwMDAwDQogICBCb290aW5nIHVzaW5nIHRoZSBm ZHQgYmxvYiBhdCAweDg2NjAwMDAwDQogICBVc2luZyBEZXZpY2UgVHJlZSBpbiBwbGFjZSBhdCAw MDAwMDAwMDg2NjAwMDAwLCBlbmQgMDAwMDAwMDA4NjYwZGZmZg0KRFQ6IEVuYWJsaW5nIFBGRQ0K RFQ6IEVuYWJsaW5nIFBGRV9FTUFDXzANCkRUOiBwZmUwIHNldCB0byAwMDowMTpiZTpiZTplZjox MQ0KRFQ6IERpc2FibGluZyBQRkVfRU1BQ18xDQpEVDogRGlzYWJsaW5nIFBGRV9FTUFDXzINCg0K U3RhcnRpbmcga2VybmVsIC4uLg0KDQotIFVBUlQgZW5hYmxlZCAtDQotIEJvb3QgQ1BVIGJvb3Rp bmcgLQ0KLSBDdXJyZW50IEVMIDAwMDAwMDA4IC0NCi0gSW5pdGlhbGl6ZSBDUFUgLQ0KLSBUdXJu aW5nIG9uIHBhZ2luZyAtDQotIFplcm8gQlNTIC0NCi0gUmVhZHkgLQ0KKFhFTikgQ2hlY2tpbmcg Zm9yIGluaXRyZCBpbiAvY2hvc2VuDQooWEVOKSBSQU06IDAwMDAwMDAwODAwMDAwMDAgLSAwMDAw MDAwMGZmZmZmZmZmDQooWEVOKSBSQU06IDAwMDAwMDA4ODAwMDAwMDAgLSAwMDAwMDAwOGRmZmZm ZmZmDQooWEVOKQ0KKFhFTikgTU9EVUxFWzBdOiAwMDAwMDAwMDg1NjAwMDAwIC0gMDAwMDAwMDA4 NTc0MzBjOCBYZW4NCihYRU4pIE1PRFVMRVsxXTogMDAwMDAwMDA4NjYwMDAwMCAtIDAwMDAwMDAw ODY2MGEwMDAgRGV2aWNlIFRyZWUNCihYRU4pIE1PRFVMRVsyXTogMDAwMDAwMDA4NTgwMDAwMCAt IDAwMDAwMDAwODY1NjI4MDggS2VybmVsDQooWEVOKSAgUkVTVkRbMF06IDAwMDAwMDAwZmY4MDAw MDAgLSAwMDAwMDAwMGZmOWZmZmZmDQooWEVOKSAgUkVTVkRbMV06IDAwMDAwMDAwYzAwMDAwMDAg LSAwMDAwMDAwMGMwM2ZmZmZmDQooWEVOKSAgUkVTVkRbMl06IDAwMDAwMDAwYzA0MDAwMDAgLSAw MDAwMDAwMGMwN2ZmZmZmDQooWEVOKSAgUkVTVkRbM106IDAwMDAwMDAwZDAwMDAwMDAgLSAwMDAw MDAwMGQwM2ZmZmZmDQooWEVOKSAgUkVTVkRbNF06IDAwMDAwMDAwODQwMDAwMDAgLSAwMDAwMDAw MDg0MDdmZmZmDQooWEVOKSAgUkVTVkRbNV06IDAwMDAwMDAwMzQwMDAwMDAgLSAwMDAwMDAwMDM0 MDdmZmZmDQooWEVOKSAgUkVTVkRbNl06IDAwMDAwMDAwMzQwODAwMDAgLSAwMDAwMDAwMDM0MDlm ZmZmDQooWEVOKSAgUkVTVkRbN106IDAwMDAwMDAwODMyMDAwMDAgLSAwMDAwMDAwMDgzNWRmZmZm DQooWEVOKSAgUkVTVkRbOF06IDAwMDAwMDAwODM1ZTAwMDAgLSAwMDAwMDAwMDgzNWZmZmZmDQoo WEVOKQ0KKFhFTikNCihYRU4pIENvbW1hbmQgbGluZTogZG9tMF9tZW09NTEyTSBkb20wX21heF92 Y3B1cz0xIGJvb3RzY3J1Yj0wDQooWEVOKSBQRk4gY29tcHJlc3Npb24gb24gYml0cyAyMC4uLjIy DQooWEVOKSBEb21haW4gaGVhcCBpbml0aWFsaXNlZA0KKFhFTikgQm9vdGluZyB1c2luZyBEZXZp Y2UgVHJlZQ0KKFhFTikgUGxhdGZvcm06IE5YUCBTMzItR2VuMQ0KKFhFTikgTm8gZHR1YXJ0IHBh dGggY29uZmlndXJlZA0KKFhFTikgQmFkIGNvbnNvbGU9IG9wdGlvbiAnZHR1YXJ0Jw0KIFhlbiA0 LjE0LjANCihYRU4pIFhlbiB2ZXJzaW9uIDQuMTQuMCAoeGVuLTQuMTQtcjBAZnNsLWF1dG8pIChh YXJjaDY0LWZzbC1saW51eC1nY2MgKEdDQykgMTAuICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDIuMCkgZGVidWc9eSAg MjAyMi0wNS0xOA0KKFhFTikgTGF0ZXN0IENoYW5nZVNldDogV2VkIE1heSAxOCAxNTo0NzoyNiAy MDIyICswMzAwIGdpdDpiZWNkZDE4ZTUwLWRpcnR5DQooWEVOKSBidWlsZC1pZDogYzkzYmU4MjBi ZmU4N2I1YWJjY2Q5NWVhODZlOTgxMjFlMTIzMTI0OQ0KKFhFTikgUHJvY2Vzc29yOiA0MTBmZDAz NDogIkFSTSBMaW1pdGVkIiwgdmFyaWFudDogMHgwLCBwYXJ0IDB4ZDAzLCByZXYgMHg0DQooWEVO KSA2NC1iaXQgRXhlY3V0aW9uOg0KKFhFTikgICBQcm9jZXNzb3IgRmVhdHVyZXM6IDAwMDAwMDAw MDEwMDIyMjIgMDAwMDAwMDAwMDAwMDAwMA0KKFhFTikgICAgIEV4Y2VwdGlvbiBMZXZlbHM6IEVM Mzo2NCszMiBFTDI6NjQrMzIgRUwxOjY0KzMyIEVMMDo2NCszMg0KKFhFTikgICAgIEV4dGVuc2lv bnM6IEZsb2F0aW5nUG9pbnQgQWR2YW5jZWRTSU1EIEdJQ3YzLVN5c1JlZw0KKFhFTikgICBEZWJ1 ZyBGZWF0dXJlczogMDAwMDAwMDAxMDMwNTEwNiAwMDAwMDAwMDAwMDAwMDAwDQooWEVOKSAgIEF1 eGlsaWFyeSBGZWF0dXJlczogMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwDQooWEVO KSAgIE1lbW9yeSBNb2RlbCBGZWF0dXJlczogMDAwMDAwMDAwMDAwMTEyMiAwMDAwMDAwMDAwMDAw MDAwDQooWEVOKSAgIElTQSBGZWF0dXJlczogIDAwMDAwMDAwMDAwMTExMjAgMDAwMDAwMDAwMDAw MDAwMA0KKFhFTikgMzItYml0IEV4ZWN1dGlvbjoNCihYRU4pICAgUHJvY2Vzc29yIEZlYXR1cmVz OiAwMDAwMDEzMToxMDAxMTAxMQ0KKFhFTikgICAgIEluc3RydWN0aW9uIFNldHM6IEFBcmNoMzIg QTMyIFRodW1iIFRodW1iLTIgSmF6ZWxsZQ0KKFhFTikgICAgIEV4dGVuc2lvbnM6IEdlbmVyaWNU aW1lciBTZWN1cml0eQ0KKFhFTikgICBEZWJ1ZyBGZWF0dXJlczogMDMwMTAwNjYNCihYRU4pICAg QXV4aWxpYXJ5IEZlYXR1cmVzOiAwMDAwMDAwMA0KKFhFTikgICBNZW1vcnkgTW9kZWwgRmVhdHVy ZXM6IDEwMjAxMTA1IDQwMDAwMDAwIDAxMjYwMDAwIDAyMTAyMjExDQooWEVOKSAgSVNBIEZlYXR1 cmVzOiAwMjEwMTExMCAxMzExMjExMSAyMTIzMjA0MiAwMTExMjEzMSAwMDAxMTE0MiAwMDAxMTEy MQ0KKFhFTikgVXNpbmcgU01DIENhbGxpbmcgQ29udmVudGlvbiB2MS4yDQooWEVOKSBVc2luZyBQ U0NJIHYxLjENCihYRU4pIFNNUDogQWxsb3dpbmcgOCBDUFVzDQooWEVOKSBlbmFibGVkIHdvcmth cm91bmQgZm9yOiBBUk0gZXJyYXR1bSAxNTMwOTI0DQooWEVOKSBHZW5lcmljIFRpbWVyIElSUTog cGh5cz0zMCBoeXA9MjYgdmlydD0yNyBGcmVxOiA1MDAwIEtIeg0KKFhFTikgR0lDdjMgaW5pdGlh bGl6YXRpb246DQooWEVOKSAgICAgICBnaWNfZGlzdF9hZGRyPTB4MDAwMDAwNTA4MDAwMDANCihY RU4pICAgICAgIGdpY19tYWludGVuYW5jZV9pcnE9MjUNCihYRU4pICAgICAgIGdpY19yZGlzdF9z dHJpZGU9MA0KKFhFTikgICAgICAgZ2ljX3JkaXN0X3JlZ2lvbnM9MQ0KKFhFTikgICAgICAgcmVk aXN0cmlidXRvciByZWdpb25zOg0KKFhFTikgICAgICAgICAtIHJlZ2lvbiAwOiAweDAwMDAwMDUw OTAwMDAwIC0gMHgwMDAwMDA1MGIwMDAwMA0KKFhFTikgR0lDdjMgY29tcGF0aWJsZSB3aXRoIEdJ Q3YyIGNiYXNlIDB4MDAwMDAwNTA0MDAwMDAgdmJhc2UgMHgwMDAwMDA1MDQyMDAwMA0KKFhFTikg R0lDdjM6IDU3NiBsaW5lcywgKElJRCAwMDAxMTQzYikuDQooWEVOKSBHSUN2MzogQ1BVMDogRm91 bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDAxYTAwMA0KKFhFTikgWFNN IEZyYW1ld29yayB2MS4wLjAgaW5pdGlhbGl6ZWQNCihYRU4pIEluaXRpYWxpc2luZyBYU00gU0lM TyBtb2RlDQooWEVOKSBVc2luZyBzY2hlZHVsZXI6IFNNUCBDcmVkaXQgU2NoZWR1bGVyIHJldjIg KGNyZWRpdDIpDQooWEVOKSBJbml0aWFsaXppbmcgQ3JlZGl0MiBzY2hlZHVsZXINCihYRU4pICBs b2FkX3ByZWNpc2lvbl9zaGlmdDogMTgNCihYRU4pICBsb2FkX3dpbmRvd19zaGlmdDogMzANCihY RU4pICB1bmRlcmxvYWRfYmFsYW5jZV90b2xlcmFuY2U6IDANCihYRU4pICBvdmVybG9hZF9iYWxh bmNlX3RvbGVyYW5jZTogLTMNCihYRU4pICBydW5xdWV1ZXMgYXJyYW5nZW1lbnQ6IHNvY2tldA0K KFhFTikgIGNhcCBlbmZvcmNlbWVudCBncmFudWxhcml0eTogMTBtcw0KKFhFTikgbG9hZCB0cmFj a2luZyB3aW5kb3cgbGVuZ3RoIDEwNzM3NDE4MjQgbnMNCihYRU4pIEFsbG9jYXRlZCBjb25zb2xl IHJpbmcgb2YgNjQgS2lCLg0KKFhFTikgQ1BVMDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxMyB0 aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBCcmluZ2luZyB1cCBDUFUxDQot IENQVSAwMDAwMDAwMSBib290aW5nIC0NCi0gQ3VycmVudCBFTCAwMDAwMDAwOCAtDQotIEluaXRp YWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBwYWdpbmcgLQ0KLSBSZWFkeSAtDQooWEVOKSBHSUN2 MzogQ1BVMTogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDAzYTAw MA0KKFhFTikgQ1BVMTogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxNSB0aW1lcyBiZWZvcmUgcGF1 c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMSBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBD UFUyDQotIENQVSAwMDAwMDEwMCBib290aW5nIC0NCi0gQ3VycmVudCBFTCAwMDAwMDAwOCAtDQot IEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBwYWdpbmcgLQ0KLSBSZWFkeSAtDQooWEVO KSBHSUN2MzogQ1BVMjogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0 MDA5YTAwMA0KKFhFTikgQ1BVMjogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxNSB0aW1lcyBiZWZv cmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMiBib290ZWQuDQooWEVOKSBCcmluZ2lu ZyB1cCBDUFUzDQotIENQVSAwMDAwMDEwMSBib290aW5nIC0NCi0gQ3VycmVudCBFTCAwMDAwMDAw OCAtDQotIEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBwYWdpbmcgLQ0KLSBSZWFkeSAt DQooWEVOKSBHSUN2MzogQ1BVMzogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24gMCBAMDAw MDAwMDA0MDBiYTAwMA0KKFhFTikgQ1BVMzogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAxNSB0aW1l cyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgMyBib290ZWQuDQooWEVOKSBC cmluZ2luZyB1cCBDUFU0DQotIENQVSAwMDAwMDAwMiBib290aW5nIC0NCi0gQ3VycmVudCBFTCAw MDAwMDAwOCAtDQotIEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBwYWdpbmcgLQ0KLSBS ZWFkeSAtDQooWEVOKSBHSUN2MzogQ1BVNDogRm91bmQgcmVkaXN0cmlidXRvciBpbiByZWdpb24g MCBAMDAwMDAwMDA0MDA1YTAwMA0KKFhFTikgQ1BVNDogR3Vlc3QgYXRvbWljcyB3aWxsIHRyeSAx NCB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgNCBib290ZWQuDQoo WEVOKSBCcmluZ2luZyB1cCBDUFU1DQotIENQVSAwMDAwMDAwMyBib290aW5nIC0NCi0gQ3VycmVu dCBFTCAwMDAwMDAwOCAtDQotIEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBwYWdpbmcg LQ0KLSBSZWFkeSAtDQooWEVOKSBHSUN2MzogQ1BVNTogRm91bmQgcmVkaXN0cmlidXRvciBpbiBy ZWdpb24gMCBAMDAwMDAwMDA0MDA3YTAwMA0KKFhFTikgQ1BVNTogR3Vlc3QgYXRvbWljcyB3aWxs IHRyeSAxNSB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUgNSBib290 ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFU2DQotIENQVSAwMDAwMDEwMiBib290aW5nIC0NCi0g Q3VycmVudCBFTCAwMDAwMDAwOCAtDQotIEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmluZyBvbiBw YWdpbmcgLQ0KLSBSZWFkeSAtDQooWEVOKSBHSUN2MzogQ1BVNjogRm91bmQgcmVkaXN0cmlidXRv ciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDBkYTAwMA0KKFhFTikgQ1BVNjogR3Vlc3QgYXRvbWlj cyB3aWxsIHRyeSAxNiB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVOKSBDUFUg NiBib290ZWQuDQooWEVOKSBCcmluZ2luZyB1cCBDUFU3DQotIENQVSAwMDAwMDEwMyBib290aW5n IC0NCi0gQ3VycmVudCBFTCAwMDAwMDAwOCAtDQotIEluaXRpYWxpemUgQ1BVIC0NCi0gVHVybmlu ZyBvbiBwYWdpbmcgLQ0KLSBSZWFkeSAtDQooWEVOKSBHSUN2MzogQ1BVNzogRm91bmQgcmVkaXN0 cmlidXRvciBpbiByZWdpb24gMCBAMDAwMDAwMDA0MDBmYTAwMA0KKFhFTikgQ1BVNzogR3Vlc3Qg YXRvbWljcyB3aWxsIHRyeSAxNSB0aW1lcyBiZWZvcmUgcGF1c2luZyB0aGUgZG9tYWluDQooWEVO KSBDUFUgNyBib290ZWQuDQooWEVOKSBCcm91Z2h0IHVwIDggQ1BVcw0KKFhFTikgSS9PIHZpcnR1 YWxpc2F0aW9uIGRpc2FibGVkDQooWEVOKSBQMk06IDQwLWJpdCBJUEEgd2l0aCA0MC1iaXQgUEEg YW5kIDgtYml0IFZNSUQNCihYRU4pIFAyTTogMyBsZXZlbHMgd2l0aCBvcmRlci0xIHJvb3QsIFZU Q1IgMHg4MDAyMzU1OA0KKFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0eTogY3B1LCAxIENQVSBw ZXIgc2NoZWQtcmVzb3VyY2UNCihYRU4pIEFkZGluZyBjcHUgMCB0byBydW5xdWV1ZSAwDQooWEVO KSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nDQooWEVOKSBBZGRpbmcgY3B1IDEg dG8gcnVucXVldWUgMA0KKFhFTikgQWRkaW5nIGNwdSAyIHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFk ZGluZyBjcHUgMyB0byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDQgdG8gcnVucXVldWUg MA0KKFhFTikgQWRkaW5nIGNwdSA1IHRvIHJ1bnF1ZXVlIDANCihYRU4pIEFkZGluZyBjcHUgNiB0 byBydW5xdWV1ZSAwDQooWEVOKSBBZGRpbmcgY3B1IDcgdG8gcnVucXVldWUgMA0KKFhFTikgYWx0 ZXJuYXRpdmVzOiBQYXRjaGluZyB3aXRoIGFsdCB0YWJsZSAwMDAwMDAwMDAwMmQ0MzA4IC0+IDAw MDAwMDAwMDAyZDRiM2MNCihYRU4pICoqKiBMT0FESU5HIERPTUFJTiAwICoqKg0KKFhFTikgTG9h ZGluZyBkMCBrZXJuZWwgZnJvbSBib290IG1vZHVsZSBAIDAwMDAwMDAwODU4MDAwMDANCihYRU4p IEFsbG9jYXRpbmcgMToxIG1hcHBpbmdzIHRvdGFsbGluZyA1MTJNQiBmb3IgZG9tMDoNCihYRU4p IEJBTktbMF0gMHgwMDAwMDBhMDAwMDAwMC0weDAwMDAwMGMwMDAwMDAwICg1MTJNQikNCihYRU4p IEdyYW50IHRhYmxlIHJhbmdlOiAweDAwMDAwMDg1NjAwMDAwLTB4MDAwMDAwODU2NDAwMDANCihY RU4pIEFsbG9jYXRpbmcgUFBJIDE2IGZvciBldmVudCBjaGFubmVsIGludGVycnVwdA0KKFhFTikg TG9hZGluZyB6SW1hZ2UgZnJvbSAwMDAwMDAwMDg1ODAwMDAwIHRvIDAwMDAwMDAwYTAwMDAwMDAt MDAwMDAwMDBhMGQ2MjgwOA0KKFhFTikgTG9hZGluZyBkMCBEVEIgdG8gMHgwMDAwMDAwMGE4MDAw MDAwLTB4MDAwMDAwMDBhODAwOTQ3YQ0KKFhFTikgSW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEgdGhy ZXNob2xkIHNldCBhdCAweDQwMDAgcGFnZXMuDQooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwNCihY RU4pIEd1ZXN0IExvZ2xldmVsOiBBbGwNCihYRU4pICoqKiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAo dHlwZSAnQ1RSTC1hJyB0aHJlZSB0aW1lcyB0byBzd2l0Y2ggaW5wdXQpDQooWEVOKSBGcmVlZCAz NTJrQiBpbml0IG1lbW9yeS4NCihYRU4pIGQwdjA6IHZHSUNEOiBSQVogb24gcmVzZXJ2ZWQgcmVn aXN0ZXIgb2Zmc2V0IDB4MDAwMDBjDQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQg d3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0DQooWEVOKSBkMHYwOiB2R0lDRDog dW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI4DQooWEVO KSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJ Q0FDVElWRVIxMg0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAw MDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSMTYNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQg d29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjIwDQooWEVOKSBkMHYwOiB2 R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIy NA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZm ZmYgdG8gSUNBQ1RJVkVSMjgNCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0 ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjMyDQooWEVOKSBkMHYwOiB2R0lDRDogdW5o YW5kbGVkIHdvcmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVIzNg0KKFhFTikg ZDB2MDogdkdJQ0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNB Q1RJVkVSNDANCihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAw MGZmZmZmZmZmIHRvIElDQUNUSVZFUjQ0DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdv cmQgd3JpdGUgMHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI0OA0KKFhFTikgZDB2MDogdkdJ Q0Q6IHVuaGFuZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNTIN CihYRU4pIGQwdjA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZm IHRvIElDQUNUSVZFUjU2DQooWEVOKSBkMHYwOiB2R0lDRDogdW5oYW5kbGVkIHdvcmQgd3JpdGUg MHgwMDAwMDBmZmZmZmZmZiB0byBJQ0FDVElWRVI2MA0KKFhFTikgZDB2MDogdkdJQ0Q6IHVuaGFu ZGxlZCB3b3JkIHdyaXRlIDB4MDAwMDAwZmZmZmZmZmYgdG8gSUNBQ1RJVkVSNjQNCihYRU4pIGQw djA6IHZHSUNEOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAwMDAwMGZmZmZmZmZmIHRvIElDQUNU SVZFUjY4DQooWEVOKSBkMHYwOiB2R0lDUjogU0dJOiB1bmhhbmRsZWQgd29yZCB3cml0ZSAweDAw MDAwMGZmZmZmZmZmIHRvIElDQUNUSVZFUjANClsgICAgMC4wMDAwMDBdIEJvb3RpbmcgTGludXgg b24gcGh5c2ljYWwgQ1BVIDB4MDAwMDAwMDAwMCBbMHg0MTBmZDAzNF0NClsgICAgMC4wMDAwMDBd IExpbnV4IHZlcnNpb24gNS4xMC4xMDktcnQ2NStnMGJhY2U3ZmRlNWY1IChvZS11c2VyQG9lLWhv c3QpIChhYXJjICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGg2NC1mc2wtbGludXgtZ2NjIChHQ0MpIDEwLjIuMCwgR05V IGxkIChHTlUgQmludXRpbHMpIDIuMzUuMSkgIzEgU01QIFBSRUVNUFQgRnJpICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBKdW4gMjQgMTU6MDE6MDggVVRDIDIwMjINClsgICAgMC4wMDAwMDBdIE1hY2hpbmUgbW9kZWw6 IE5YUCBTMzJHM1hYWC1FVkIzDQpbICAgIDAuMDAwMDAwXSBYZW4gNC4xNCBzdXBwb3J0IGZvdW5k DQpbICAgIDAuMDAwMDAwXSBSZXNlcnZlZCBtZW1vcnk6IGNyZWF0ZWQgRE1BIG1lbW9yeSBwb29s IGF0IDB4MDAwMDAwMDA4MzIwMDAwMCwgcyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpemUgMyBNaUINClsgICAgMC4w MDAwMDBdIE9GOiByZXNlcnZlZCBtZW06IGluaXRpYWxpemVkIG5vZGUgcGZlYnVmc0A4MzIwMDAw MCwgY29tcGF0aWJsZSBpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGQgc2hhcmVkLWRtYS1wb29sDQpbICAgIDAuMDAw MDAwXSBab25lIHJhbmdlczoNClsgICAgMC4wMDAwMDBdICAgRE1BICAgICAgW21lbSAweDAwMDAw MDAwMzQwMDAwMDAtMHgwMDAwMDAwMGZmOWZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBETUEzMiAg ICBlbXB0eQ0KWyAgICAwLjAwMDAwMF0gICBOb3JtYWwgICBlbXB0eQ0KWyAgICAwLjAwMDAwMF0g TW92YWJsZSB6b25lIHN0YXJ0IGZvciBlYWNoIG5vZGUNClsgICAgMC4wMDAwMDBdIEVhcmx5IG1l bW9yeSBub2RlIHJhbmdlcw0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAw MDAwMzQwMDAwMDAtMHgwMDAwMDAwMDM0MDlmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAg MDogW21lbSAweDAwMDAwMDAwODMyMDAwMDAtMHgwMDAwMDAwMDgzNWRmZmZmXQ0KWyAgICAwLjAw MDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwODM1ZTAwMDAtMHgwMDAwMDAwMDgzNWZm ZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwODQwMDAwMDAt MHgwMDAwMDAwMDg0MDdmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAw MDAwMDAwYTAwMDAwMDAtMHgwMDAwMDAwMGJmZmZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2Rl ICAgMDogW21lbSAweDAwMDAwMDAwYzAwMDAwMDAtMHgwMDAwMDAwMGMwN2ZmZmZmXQ0KWyAgICAw LjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZDAwMDAwMDAtMHgwMDAwMDAwMGQw M2ZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAwZmY4MDAw MDAtMHgwMDAwMDAwMGZmOWZmZmZmXQ0KWyAgICAwLjAwMDAwMF0gSW5pdG1lbSBzZXR1cCBub2Rl IDAgW21lbSAweDAwMDAwMDAwMzQwMDAwMDAtMHgwMDAwMDAwMGZmOWZmZmZmXQ0KWyAgICAwLjAw MDAwMF0gY21hOiBSZXNlcnZlZCAyNTYgTWlCIGF0IDB4MDAwMDAwMDBhZDAwMDAwMA0KWyAgICAw LjAwMDAwMF0gcHNjaTogcHJvYmluZyBmb3IgY29uZHVpdCBtZXRob2QgZnJvbSBEVC4NClsgICAg MC4wMDAwMDBdIHBzY2k6IFBTQ0l2MS4xIGRldGVjdGVkIGluIGZpcm13YXJlLg0KWyAgICAwLjAw MDAwMF0gcHNjaTogVXNpbmcgc3RhbmRhcmQgUFNDSSB2MC4yIGZ1bmN0aW9uIElEcw0KWyAgICAw LjAwMDAwMF0gcHNjaTogVHJ1c3RlZCBPUyBtaWdyYXRpb24gbm90IHJlcXVpcmVkDQpbICAgIDAu MDAwMDAwXSBwc2NpOiBTTUMgQ2FsbGluZyBDb252ZW50aW9uIHYxLjENClsgICAgMC4wMDAwMDBd IHBlcmNwdTogRW1iZWRkZWQgMTcgcGFnZXMvY3B1IHMzMjAyNCByODE5MiBkMjk0MTYgdTY5NjMy DQpbICAgIDAuMDAwMDAwXSBEZXRlY3RlZCBWSVBUIEktY2FjaGUgb24gQ1BVMA0KWyAgICAwLjAw MDAwMF0gQ1BVIGZlYXR1cmVzOiBkZXRlY3RlZDogQVJNIGVycmF0dW0gODQ1NzE5DQpbICAgIDAu MDAwMDAwXSBDUFUgZmVhdHVyZXM6IGRldGVjdGVkOiBHSUMgc3lzdGVtIHJlZ2lzdGVyIENQVSBp bnRlcmZhY2UNClsgICAgMC4wMDAwMDBdIENQVSBmZWF0dXJlczogZGV0ZWN0ZWQ6IEFSTSBlcnJh dGEgMTE2NTUyMiwgMTMxOTM2NywgMTUzMDkyMywgb3IgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDE1MzA5MjQNClsg ICAgMC4wMDAwMDBdIEJ1aWx0IDEgem9uZWxpc3RzLCBtb2JpbGl0eSBncm91cGluZyBvbi4gIFRv dGFsIHBhZ2VzOiAxMzQxMDkNClsgICAgMC4wMDAwMDBdIEtlcm5lbCBjb21tYW5kIGxpbmU6IGNv bnNvbGU9dHR5TEYwLDExNTIwMCBlYXJseWNvbj14ZW4gZWFybHlwcmluICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRr PXhlbiByb290PS9kZXYvbW1jYmxrMHAyIHJ3IGNsa19pZ25vcmVfdW51c2VkDQpbICAgIDAuMDAw MDAwXSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAx MDQ4NTc2IGJ5dGVzLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbGluZWFyKQ0KWyAgICAwLjAwMDAwMF0gSW5vZGUt Y2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUzNiAob3JkZXI6IDcsIDUyNDI4OCBieXRlcywg bGkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbmVhcikNClsgICAgMC4wMDAwMDBdIG1lbSBhdXRvLWluaXQ6IHN0YWNr Om9mZiwgaGVhcCBhbGxvYzpvZmYsIGhlYXAgZnJlZTpvZmYNClsgICAgMC4wMDAwMDBdIE1lbW9y eTogMjAyMjUySy81NDM4NzJLIGF2YWlsYWJsZSAoODc2Nksga2VybmVsIGNvZGUsIDY1MEsgcndk YXRhICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICwgMjg4MEsgcm9kYXRhLCAxMzQ0SyBpbml0LCAyNDVLIGJzcywgNzk0 NzZLIHJlc2VydmVkLCAyNjIxNDRLIGNtYS1yZXNlcnZlZCkNClsgICAgMC4wMDAwMDBdIHJjdTog UHJlZW1wdGlibGUgaGllcmFyY2hpY2FsIFJDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMC4wMDAw MDBdIHJjdTogICAgIFJDVSBldmVudCB0cmFjaW5nIGlzIGVuYWJsZWQuDQpbICAgIDAuMDAwMDAw XSByY3U6ICAgICBSQ1UgcmVzdHJpY3RpbmcgQ1BVcyBmcm9tIE5SX0NQVVM9OCB0byBucl9jcHVf aWRzPTEuDQpbICAgIDAuMDAwMDAwXSAgVHJhbXBvbGluZSB2YXJpYW50IG9mIFRhc2tzIFJDVSBl bmFibGVkLg0KWyAgICAwLjAwMDAwMF0gIFRyYWNpbmcgdmFyaWFudCBvZiBUYXNrcyBSQ1UgZW5h YmxlZC4NClsgICAgMC4wMDAwMDBdIHJjdTogUkNVIGNhbGN1bGF0ZWQgdmFsdWUgb2Ygc2NoZWR1 bGVyLWVubGlzdG1lbnQgZGVsYXkgaXMgMjUgamlmICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpZXMuDQpbICAgIDAu MDAwMDAwXSByY3U6IEFkanVzdGluZyBnZW9tZXRyeSBmb3IgcmN1X2Zhbm91dF9sZWFmPTE2LCBu cl9jcHVfaWRzPTENClsgICAgMC4wMDAwMDBdIE5SX0lSUVM6IDY0LCBucl9pcnFzOiA2NCwgcHJl YWxsb2NhdGVkIGlycXM6IDANClsgICAgMC4wMDAwMDBdIEdJQ3YzOiA1NDQgU1BJcyBpbXBsZW1l bnRlZA0KWyAgICAwLjAwMDAwMF0gR0lDdjM6IDAgRXh0ZW5kZWQgU1BJcyBpbXBsZW1lbnRlZA0K WyAgICAwLjAwMDAwMF0gR0lDdjM6IERpc3RyaWJ1dG9yIGhhcyBubyBSYW5nZSBTZWxlY3RvciBz dXBwb3J0DQpbICAgIDAuMDAwMDAwXSBHSUN2MzogMTYgUFBJcyBpbXBsZW1lbnRlZA0KWyAgICAw LjAwMDAwMF0gR0lDdjM6IENQVTA6IGZvdW5kIHJlZGlzdHJpYnV0b3IgMCByZWdpb24gMDoweDAw MDAwMDAwNTA5MDAwMDANClsgICAgMC4wMDAwMDBdIHJhbmRvbTogZ2V0X3JhbmRvbV9ieXRlcyBj YWxsZWQgZnJvbSBzdGFydF9rZXJuZWwrMHgzMWMvMHg0ZWMgd2l0ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGggY3Ju Z19pbml0PTANClsgICAgMC4wMDAwMDBdIGFyY2hfdGltZXI6IGNwMTUgdGltZXIocykgcnVubmlu ZyBhdCA1LjAwTUh6ICh2aXJ0KS4NClsgICAgMC4wMDAwMDBdIGNsb2Nrc291cmNlOiBhcmNoX3N5 c19jb3VudGVyOiBtYXNrOiAweGZmZmZmZmZmZmZmZmZmIG1heF9jeWNsZXM6ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAweDEyNzM1MGI4OCwgbWF4X2lkbGVfbnM6IDQ0MDc5NTIwMjEyMCBucw0KWyAgICAwLjAwMDAw MV0gc2NoZWRfY2xvY2s6IDU2IGJpdHMgYXQgNU1IeiwgcmVzb2x1dGlvbiAyMDBucywgd3JhcHMg ZXZlcnkgNDM5ODAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgNDY1MTExMDBucw0KWyAgICAwLjAwMDM1N10gQ29uc29s ZTogY29sb3VyIGR1bW15IGRldmljZSA4MHgyNQ0KWyAgICAwLjAwMDM4NV0gQ2FsaWJyYXRpbmcg ZGVsYXkgbG9vcCAoc2tpcHBlZCksIHZhbHVlIGNhbGN1bGF0ZWQgdXNpbmcgdGltZXIgZnIgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZXF1ZW5jeS4uIDEwLjAwIEJvZ29NSVBTIChscGo9MjAwMDApDQpbICAgIDAuMDAw Mzk1XSBwaWRfbWF4OiBkZWZhdWx0OiAzMjc2OCBtaW5pbXVtOiAzMDENClsgICAgMC4wMDA0ODld IE1vdW50LWNhY2hlIGhhc2ggdGFibGUgZW50cmllczogMjA0OCAob3JkZXI6IDIsIDE2Mzg0IGJ5 dGVzLCBsaW5lICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGFyKQ0KWyAgICAwLjAwMDUwMF0gTW91bnRwb2ludC1jYWNo ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDIwNDggKG9yZGVyOiAyLCAxNjM4NCBieXRlcywgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGxpbmVhcikNClsgICAgMC4wMDE5NDNdIHhlbjpncmFudF90YWJsZTogR3JhbnQgdGFi bGVzIHVzaW5nIHZlcnNpb24gMSBsYXlvdXQNClsgICAgMC4wMDE5NjRdIEdyYW50IHRhYmxlIGlu aXRpYWxpemVkDQpbICAgIDAuMDAxOTk0XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZPLWJhc2VkIEFC SQ0KWyAgICAwLjAwMjAyM10gWGVuOiBpbml0aWFsaXppbmcgY3B1MA0KWyAgICAwLjAwMjEyN10g cmN1OiBIaWVyYXJjaGljYWwgU1JDVSBpbXBsZW1lbnRhdGlvbi4NClsgICAgMC4wMDI0MTJdIHNt cDogQnJpbmdpbmcgdXAgc2Vjb25kYXJ5IENQVXMgLi4uDQpbICAgIDAuMDAyNDE1XSBzbXA6IEJy b3VnaHQgdXAgMSBub2RlLCAxIENQVQ0KWyAgICAwLjAwMjQxOV0gU01QOiBUb3RhbCBvZiAxIHBy b2Nlc3NvcnMgYWN0aXZhdGVkLg0KWyAgICAwLjAwMjQyN10gQ1BVIGZlYXR1cmVzOiBkZXRlY3Rl ZDogMzItYml0IEVMMCBTdXBwb3J0DQpbICAgIDAuMDAyNDMzXSBDUFUgZmVhdHVyZXM6IGRldGVj dGVkOiBDUkMzMiBpbnN0cnVjdGlvbnMNClsgICAgMC4wMDk3MThdIENQVTogQWxsIENQVShzKSBz dGFydGVkIGF0IEVMMQ0KWyAgICAwLjAwOTczMV0gYWx0ZXJuYXRpdmVzOiBwYXRjaGluZyBrZXJu ZWwgY29kZQ0KWyAgICAwLjAxMDE4M10gZGV2dG1wZnM6IGluaXRpYWxpemVkDQpbICAgIDAuMDE0 NDE1XSBjbG9ja3NvdXJjZTogamlmZmllczogbWFzazogMHhmZmZmZmZmZiBtYXhfY3ljbGVzOiAw eGZmZmZmZmZmLCBtYSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB4X2lkbGVfbnM6IDc2NDUwNDE3ODUxMDAwMDAgbnMN ClsgICAgMC4wMTQ0MjldIGZ1dGV4IGhhc2ggdGFibGUgZW50cmllczogMjU2IChvcmRlcjogMiwg MTYzODQgYnl0ZXMsIGxpbmVhcikNClsgICAgMC4wMjA0MjZdIHBpbmN0cmwgY29yZTogaW5pdGlh bGl6ZWQgcGluY3RybCBzdWJzeXN0ZW0NClsgICAgMC4wMjA5ODNdIE5FVDogUmVnaXN0ZXJlZCBw cm90b2NvbCBmYW1pbHkgMTYNClsgICAgMC4wMjIxNDFdIERNQTogcHJlYWxsb2NhdGVkIDEyOCBL aUIgR0ZQX0tFUk5FTCBwb29sIGZvciBhdG9taWMgYWxsb2NhdGlvbnMNClsgICAgMC4wMjIyMThd IERNQTogcHJlYWxsb2NhdGVkIDEyOCBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BIHBvb2wgZm9yIGF0 b21pYyBhbGxvICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNhdGlvbnMNClsgICAgMC4wMjIzMDldIERNQTogcHJlYWxs b2NhdGVkIDEyOCBLaUIgR0ZQX0tFUk5FTHxHRlBfRE1BMzIgcG9vbCBmb3IgYXRvbWljIGFsICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxvY2F0aW9ucw0KWyAgICAwLjAyMjg1MV0gdGhlcm1hbF9zeXM6IFJlZ2lzdGVy ZWQgdGhlcm1hbCBnb3Zlcm5vciAnc3RlcF93aXNlJw0KWyAgICAwLjAyMzExMF0gaHctYnJlYWtw b2ludDogZm91bmQgNiBicmVha3BvaW50IGFuZCA0IHdhdGNocG9pbnQgcmVnaXN0ZXJzLg0KWyAg ICAwLjAyMzE1M10gQVNJRCBhbGxvY2F0b3IgaW5pdGlhbGlzZWQgd2l0aCA2NTUzNiBlbnRyaWVz DQpbICAgIDAuMDIzMjE4XSB4ZW46c3dpb3RsYl94ZW46IFdhcm5pbmc6IG9ubHkgYWJsZSB0byBh bGxvY2F0ZSA0IE1CIGZvciBzb2Z0d2FyZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU8gVExCDQpbICAgIDAuMDIz OTMzXSBzb2Z0d2FyZSBJTyBUTEI6IG1hcHBlZCBbbWVtIDB4MDAwMDAwMDBhMTgwMDAwMC0weDAw MDAwMDAwYTFjMDAwMCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAwXSAoNE1CKQ0KWyAgICAwLjAyMzk5OF0gU2VyaWFs OiBBTUJBIFBMMDExIFVBUlQgZHJpdmVyDQpbICAgIDAuMDI0NTcxXSBhcm0tc2NtaSBmaXJtd2Fy ZTpzY21pOiBTQ01JIE5vdGlmaWNhdGlvbnMgLSBDb3JlIEVuYWJsZWQuDQpbICAgIDAuMDI0NjQ5 XSBhcm0tc2NtaSBmaXJtd2FyZTpzY21pOiBOby4gb2YgUHJvdG9jb2wgPiBNQVhfUFJPVE9DT0xT X0lNUA0KWyAgICAwLjAyNDY1NF0gYXJtLXNjbWkgZmlybXdhcmU6c2NtaTogU0NNSSBQcm90b2Nv bCB2Mi4wICdOWFA6UzMyRzM5OUEnIEZpcm13YXIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZSB2ZXJzaW9uIDB4MA0K WyAgICAwLjAzOTg1MF0gSHVnZVRMQiByZWdpc3RlcmVkIDEuMDAgR2lCIHBhZ2Ugc2l6ZSwgcHJl LWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDAuMDM5ODU4XSBIdWdlVExCIHJlZ2lzdGVyZWQgMzIu MCBNaUIgcGFnZSBzaXplLCBwcmUtYWxsb2NhdGVkIDAgcGFnZXMNClsgICAgMC4wMzk4NjJdIEh1 Z2VUTEIgcmVnaXN0ZXJlZCAyLjAwIE1pQiBwYWdlIHNpemUsIHByZS1hbGxvY2F0ZWQgMCBwYWdl cw0KWyAgICAwLjAzOTg2Nl0gSHVnZVRMQiByZWdpc3RlcmVkIDY0LjAgS2lCIHBhZ2Ugc2l6ZSwg cHJlLWFsbG9jYXRlZCAwIHBhZ2VzDQpbICAgIDAuMDQzNDEyXSBzY21pLWNsb2NrcyBzY21pX2Rl di4xOiBmYWlsZWQgdG8gcmVnaXN0ZXIgY2xvY2sgODcNClsgICAgMC4wNDM0MjFdIHNjbWktY2xv Y2tzIHNjbWlfZGV2LjE6IGZhaWxlZCB0byByZWdpc3RlciBjbG9jayA4OA0KWyAgICAwLjA0MzQy OF0gc2NtaS1jbG9ja3Mgc2NtaV9kZXYuMTogZmFpbGVkIHRvIHJlZ2lzdGVyIGNsb2NrIDg5DQpb ICAgIDAuMDQzNDM0XSBzY21pLWNsb2NrcyBzY21pX2Rldi4xOiBmYWlsZWQgdG8gcmVnaXN0ZXIg Y2xvY2sgOTANClsgICAgMC4wNDM1MDddIHNjbWktY2xvY2tzIHNjbWlfZGV2LjE6IGZhaWxlZCB0 byByZWdpc3RlciBjbG9jayA5NQ0KWyAgICAwLjA0MzUxNF0gc2NtaS1jbG9ja3Mgc2NtaV9kZXYu MTogZmFpbGVkIHRvIHJlZ2lzdGVyIGNsb2NrIDk2DQpbICAgIDAuMDQzNTIwXSBzY21pLWNsb2Nr cyBzY21pX2Rldi4xOiBmYWlsZWQgdG8gcmVnaXN0ZXIgY2xvY2sgOTcNClsgICAgMC4wNDM1MjZd IHNjbWktY2xvY2tzIHNjbWlfZGV2LjE6IGZhaWxlZCB0byByZWdpc3RlciBjbG9jayA5OA0KWyAg ICAwLjA0Njg3MV0geGVuOmJhbGxvb246IEluaXRpYWxpc2luZyBiYWxsb29uIGRyaXZlcg0KWyAg ICAwLjA0NzIzMF0gdmdhYXJiOiBsb2FkZWQNClsgICAgMC4wNDczNjddIFNDU0kgc3Vic3lzdGVt IGluaXRpYWxpemVkDQpbICAgIDAuMDQ3NDk0XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRl cmZhY2UgZHJpdmVyIHVzYmZzDQpbICAgIDAuMDQ3NTIxXSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5l dyBpbnRlcmZhY2UgZHJpdmVyIGh1Yg0KWyAgICAwLjA0NzU0MV0gdXNiY29yZTogcmVnaXN0ZXJl ZCBuZXcgZGV2aWNlIGRyaXZlciB1c2INClsgICAgMC4wNDc4MThdIHBwc19jb3JlOiBMaW51eFBQ UyBBUEkgdmVyLiAxIHJlZ2lzdGVyZWQNClsgICAgMC4wNDc4MjFdIHBwc19jb3JlOiBTb2Z0d2Fy ZSB2ZXIuIDUuMy42IC0gQ29weXJpZ2h0IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21lICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHR0aSA8Z2lvbWV0dGlAbGludXguaXQ+DQpbICAgIDAuMDQ3ODMxXSBQVFAgY2xvY2sgc3Vw cG9ydCByZWdpc3RlcmVkDQpbICAgIDAuMDQ4NjY0XSBjbG9ja3NvdXJjZTogU3dpdGNoZWQgdG8g Y2xvY2tzb3VyY2UgYXJjaF9zeXNfY291bnRlcg0KWyAgICAwLjA1MzA4M10gTkVUOiBSZWdpc3Rl cmVkIHByb3RvY29sIGZhbWlseSAyDQpbICAgIDAuMDUzMTczXSBJUCBpZGVudHMgaGFzaCB0YWJs ZSBlbnRyaWVzOiAxNjM4NCAob3JkZXI6IDUsIDEzMTA3MiBieXRlcywgbGluZSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhcikNClsgICAgMC4wNTM3NjJdIHRjcF9saXN0ZW5fcG9ydGFkZHJfaGFzaCBoYXNoIHRhYmxl IGVudHJpZXM6IDUxMiAob3JkZXI6IDEsIDgxOTIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ5dGVzLCBsaW5lYXIp DQpbICAgIDAuMDUzNzg3XSBUQ1AgZXN0YWJsaXNoZWQgaGFzaCB0YWJsZSBlbnRyaWVzOiA4MTky IChvcmRlcjogNCwgNjU1MzYgYnl0ZXMsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsaW5lYXIpDQpbICAgIDAuMDUz ODQ3XSBUQ1AgYmluZCBoYXNoIHRhYmxlIGVudHJpZXM6IDgxOTIgKG9yZGVyOiA1LCAxMzEwNzIg Ynl0ZXMsIGxpbmVhciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICApDQpbICAgIDAuMDUzOTcwXSBUQ1A6IEhhc2ggdGFi bGVzIGNvbmZpZ3VyZWQgKGVzdGFibGlzaGVkIDgxOTIgYmluZCA4MTkyKQ0KWyAgICAwLjA1NDAy OF0gVURQIGhhc2ggdGFibGUgZW50cmllczogNTEyIChvcmRlcjogMiwgMTYzODQgYnl0ZXMsIGxp bmVhcikNClsgICAgMC4wNTQwNTJdIFVEUC1MaXRlIGhhc2ggdGFibGUgZW50cmllczogNTEyIChv cmRlcjogMiwgMTYzODQgYnl0ZXMsIGxpbmVhcikNClsgICAgMC4wNTQxNDddIE5FVDogUmVnaXN0 ZXJlZCBwcm90b2NvbCBmYW1pbHkgMQ0KWyAgICAwLjA1NDQzNV0gUlBDOiBSZWdpc3RlcmVkIG5h bWVkIFVOSVggc29ja2V0IHRyYW5zcG9ydCBtb2R1bGUuDQpbICAgIDAuMDU0NDM5XSBSUEM6IFJl Z2lzdGVyZWQgdWRwIHRyYW5zcG9ydCBtb2R1bGUuDQpbICAgIDAuMDU0NDQxXSBSUEM6IFJlZ2lz dGVyZWQgdGNwIHRyYW5zcG9ydCBtb2R1bGUuDQpbICAgIDAuMDU0NDQzXSBSUEM6IFJlZ2lzdGVy ZWQgdGNwIE5GU3Y0LjEgYmFja2NoYW5uZWwgdHJhbnNwb3J0IG1vZHVsZS4NClsgICAgMC4wNTQ0 NTFdIFBDSTogQ0xTIDAgYnl0ZXMsIGRlZmF1bHQgNjQNClsgICAgMC4wNTUzNzVdIHdvcmtpbmdz ZXQ6IHRpbWVzdGFtcF9iaXRzPTYyIG1heF9vcmRlcj0xNyBidWNrZXRfb3JkZXI9MA0KWyAgICAw LjA1NTg1OF0gZnVzZTogaW5pdCAoQVBJIHZlcnNpb24gNy4zMikNClsgICAgMC4wNTU5NjVdIE5F VDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMzgNClsgICAgMC4wNTU5ODhdIEJsb2NrIGxh eWVyIFNDU0kgZ2VuZXJpYyAoYnNnKSBkcml2ZXIgdmVyc2lvbiAwLjQgbG9hZGVkIChtYWpvciAy ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDQ4KQ0KWyAgICAwLjA1NTk5M10gaW8gc2NoZWR1bGVyIG1xLWRlYWRsaW5l IHJlZ2lzdGVyZWQNClsgICAgMC4wNTU5OTddIGlvIHNjaGVkdWxlciBreWJlciByZWdpc3RlcmVk DQpbICAgIDAuMDU3MDI1XSBzMzJnLXNpdWwyLXBpbmN0cmwgNDAwOWMyNDAuc2l1bDItcGluY3Ry bDogaW5pdGlhbGl6ZWQgczMyIHBpbmN0ciAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsIGRyaXZlcg0KWyAgICAwLjA1 Nzk2NV0gZ3Bpby0zMzkgKGxsY2VjYW4wLWVuKTogaG9nZ2VkIGFzIG91dHB1dC9oaWdoDQpbICAg IDAuMDU3OTgzXSBncGlvLTM0MCAobGxjZWNhbjAtc3RieSk6IGhvZ2dlZCBhcyBvdXRwdXQvaGln aA0KWyAgICAwLjA1Nzk5OF0gZ3Bpby0zNDIgKGxsY2VjYW40LWVuKTogaG9nZ2VkIGFzIG91dHB1 dC9oaWdoDQpbICAgIDAuMDU4MDE0XSBncGlvLTM0MyAobGxjZWNhbjQtc3RieSk6IGhvZ2dlZCBh cyBvdXRwdXQvaGlnaA0KWyAgICAwLjA1ODAyOV0gZ3Bpby0zNDUgKGxsY2VjYW41LWVuKTogaG9n Z2VkIGFzIG91dHB1dC9oaWdoDQpbICAgIDAuMDU4MDQ0XSBncGlvLTM0NiAobGxjZWNhbjUtc3Ri eSk6IGhvZ2dlZCBhcyBvdXRwdXQvaGlnaA0KWyAgICAwLjA1ODA1OF0gZ3Bpby0zNTEgKGxsY2Vj YW42LWVuKTogaG9nZ2VkIGFzIG91dHB1dC9oaWdoDQpbICAgIDAuMDU4MDcyXSBncGlvLTM1MiAo bGxjZWNhbjYtc3RieSk6IGhvZ2dlZCBhcyBvdXRwdXQvaGlnaA0KWyAgICAwLjA1ODA4OV0gZ3Bp by0zNTMgKGxsY2VjYW4xMi1zdGJ5KTogaG9nZ2VkIGFzIG91dHB1dC9oaWdoDQpbICAgIDAuMDU4 MTAzXSBncGlvLTM1OCAobGxjZWNhbjEyLWVuKTogaG9nZ2VkIGFzIG91dHB1dC9oaWdoDQpbICAg IDAuMDU4MTIwXSBncGlvLTM2MCAobGxjZWNhbjEzLWVuKTogaG9nZ2VkIGFzIG91dHB1dC9oaWdo DQpbICAgIDAuMDU4MTM1XSBncGlvLTM2MSAobGxjZWNhbjEzLXN0YnkpOiBob2dnZWQgYXMgb3V0 cHV0L2hpZ2gNClsgICAgMC4wNTgxNTFdIGdwaW8tMzgyIChsbGNlY2FuMTUtZW4pOiBob2dnZWQg YXMgb3V0cHV0L2hpZ2gNClsgICAgMC4wNTgxNjVdIGdwaW8tMzgzIChsbGNlY2FuMTUtc3RieSk6 IGhvZ2dlZCBhcyBvdXRwdXQvaGlnaA0KWyAgICAwLjA1OTM1OF0geGVuOnhlbl9ldnRjaG46IEV2 ZW50LWNoYW5uZWwgZGV2aWNlIGluc3RhbGxlZA0KWyAgICAwLjA2MDQ2N10gc2VyaWFsOiBGcmVl c2NhbGUgbGluZmxleCBkcml2ZXINClsgICAgMC4wNjA2ODZdIDQwMWM4MDAwLnNlcmlhbDogdHR5 TEYwIGF0IE1NSU8gMHg0MDFjODAwMCAoaXJxID0gMjUsIGJhc2VfYmF1ZCA9ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA3ODEyNTAwKSBpcyBhIEZTTF9MSU5GTEVYDQpbICAgIDAuMDYwNzM1XSBwcmludGs6IGNvbnNv bGUgW3R0eUxGMF0gZW5hYmxlZA0KWyAgICAwLjA2MTA3Ml0gNDAxY2MwMDAuc2VyaWFsOiB0dHlM RjEgYXQgTU1JTyAweDQwMWNjMDAwIChpcnEgPSAyNiwgYmFzZV9iYXVkID0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDc4MTI1MDApIGlzIGEgRlNMX0xJTkZMRVgNClsgICAgMC4wNjEzODVdIDQwMmJjMDAwLnNlcmlh bDogdHR5TEYyIGF0IE1NSU8gMHg0MDJiYzAwMCAoaXJxID0gNDQsIGJhc2VfYmF1ZCA9ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICA3ODEyNTAwKSBpcyBhIEZTTF9MSU5GTEVYDQpbICAgIDAuMDYxODMyXSBjYWNoZWlu Zm86IFVuYWJsZSB0byBkZXRlY3QgY2FjaGUgaGllcmFyY2h5IGZvciBDUFUgMA0KWyAgICAwLjA2 MTg0Nl0gSW52YWxpZCBtYXhfcXVldWVzICg0KSwgd2lsbCB1c2UgZGVmYXVsdCBtYXg6IDEuDQpb ICAgIDAuMDYyMTkzXSBmc2xfZmNjdSA0MDMwYzAwMC5mY2N1OiBGQ0NVIHN0YXR1cyBpcyAwIChu b3JtYWwpDQpbICAgIDAuMDYzODEzXSBzcGktbm9yIHNwaTAuMDogbXQzNXh1MDJnICgyNjIxNDQg S2J5dGVzKQ0KWyAgICAwLjA2NTM2NV0gdmNhbjogVmlydHVhbCBDQU4gaW50ZXJmYWNlIGRyaXZl cg0KWyAgICAwLjA2NTM3MF0gc2xjYW46IHNlcmlhbCBsaW5lIENBTiBpbnRlcmZhY2UgZHJpdmVy DQpbICAgIDAuMDY1MzcyXSBzbGNhbjogMTAgZHluYW1pYyBpbnRlcmZhY2UgY2hhbm5lbHMuDQpb ICAgIDAuMDY1Mzc3XSBDQU4gZGV2aWNlIGRyaXZlciBpbnRlcmZhY2UNClsgICAgMC4wNjU1NTVd IGUxMDA6IEludGVsKFIpIFBSTy8xMDAgTmV0d29yayBEcml2ZXINClsgICAgMC4wNjU1NThdIGUx MDA6IENvcHlyaWdodChjKSAxOTk5LTIwMDYgSW50ZWwgQ29ycG9yYXRpb24NClsgICAgMC4wNjU1 ODVdIGUxMDAwOiBJbnRlbChSKSBQUk8vMTAwMCBOZXR3b3JrIERyaXZlcg0KWyAgICAwLjA2NTU4 OF0gZTEwMDA6IENvcHlyaWdodCAoYykgMTk5OS0yMDA2IEludGVsIENvcnBvcmF0aW9uLg0KWyAg ICAwLjA2NTYxNV0gZTEwMDBlOiBJbnRlbChSKSBQUk8vMTAwMCBOZXR3b3JrIERyaXZlcg0KWyAg ICAwLjA2NTYxNl0gZTEwMDBlOiBDb3B5cmlnaHQoYykgMTk5OSAtIDIwMTUgSW50ZWwgQ29ycG9y YXRpb24uDQpbICAgIDAuMDY1NjQyXSBpZ2I6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0 d29yayBEcml2ZXINClsgICAgMC4wNjU2NDVdIGlnYjogQ29weXJpZ2h0IChjKSAyMDA3LTIwMTQg SW50ZWwgQ29ycG9yYXRpb24uDQpbICAgIDAuMDY1OTIwXSB4ZW5fbmV0ZnJvbnQ6IEluaXRpYWxp c2luZyBYZW4gdmlydHVhbCBldGhlcm5ldCBkcml2ZXINClsgICAgMC4wNjYwMTZdIGhzZS11aW8g NDAyMTEwMDAubXUxYjogZmlybXdhcmUgbm90IGZvdW5kDQpbICAgIDAuMDY2MjA4XSBlaGNpX2hj ZDogVVNCIDIuMCAnRW5oYW5jZWQnIEhvc3QgQ29udHJvbGxlciAoRUhDSSkgRHJpdmVyDQpbICAg IDAuMDY2MjEzXSBlaGNpLXBjaTogRUhDSSBQQ0kgcGxhdGZvcm0gZHJpdmVyDQpbICAgIDAuMDY2 MzE4XSB1c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVhcw0KWyAgICAw LjA2NjM0Nl0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciB1c2Itc3Rv cmFnZQ0KWyAgICAwLjA2NzUwM10gczMyZ2VuMS1ydGMgNDAwNjAwMDAucnRjOiByZWdpc3RlcmVk IGFzIHJ0YzANClsgICAgMC4wNjc1MzNdIHMzMmdlbjEtcnRjIDQwMDYwMDAwLnJ0Yzogc2V0dGlu ZyBzeXN0ZW0gY2xvY2sgdG8gMTk3MC0wMS0wMVQwMDowICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDA6MDAgVVRDICgw KQ0KWyAgICAwLjA2NzY2NV0gaTJjIC9kZXYgZW50cmllcyBkcml2ZXINClsgICAgMC4wNjgwMjZd IHNhYzU4ci13ZHQgNDAxMGMwMDAuc3d0OiBTQUM1OFIvUzMyR0VOMSBXYXRjaGRvZyBUaW1lciBS ZWdpc3RlcmVkICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIC4gdGltZW91dD0zMHMgKG5vd2F5b3V0PTApDQpbICAgIDAu MDY4MjA0XSBzYWM1OHItd2R0IDQwMjAwMDAwLnN3dDogU0FDNThSL1MzMkdFTjEgV2F0Y2hkb2cg VGltZXIgUmVnaXN0ZXJlZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuIHRpbWVvdXQ9MzBzIChub3dheW91dD0wKQ0K WyAgICAwLjA2ODM3MV0gc2FjNThyLXdkdCA0MDIwNDAwMC5zd3Q6IFNBQzU4Ui9TMzJHRU4xIFdh dGNoZG9nIFRpbWVyIFJlZ2lzdGVyZWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLiB0aW1lb3V0PTMwcyAobm93YXlv dXQ9MCkNClsgICAgMC4wNjg1MzhdIHNhYzU4ci13ZHQgNDAyMDgwMDAuc3d0OiBTQUM1OFIvUzMy R0VOMSBXYXRjaGRvZyBUaW1lciBSZWdpc3RlcmVkICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC4gdGltZW91dD0zMHMg KG5vd2F5b3V0PTApDQpbICAgIDAuMDY4Nzc2XSBzYWM1OHItd2R0IDQwNTAwMDAwLnN3dDogU0FD NThSL1MzMkdFTjEgV2F0Y2hkb2cgVGltZXIgUmVnaXN0ZXJlZCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAuIHRpbWVv dXQ9MzBzIChub3dheW91dD0wKQ0KWyAgICAwLjA2ODk1MF0gc2FjNThyLXdkdCA0MDUwNDAwMC5z d3Q6IFNBQzU4Ui9TMzJHRU4xIFdhdGNoZG9nIFRpbWVyIFJlZ2lzdGVyZWQgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LiB0aW1lb3V0PTMwcyAobm93YXlvdXQ9MCkNClsgICAgMC4wNjkxMTJdIHNhYzU4ci13ZHQgNDA1 MDgwMDAuc3d0OiBTQUM1OFIvUzMyR0VOMSBXYXRjaGRvZyBUaW1lciBSZWdpc3RlcmVkICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIC4gdGltZW91dD0zMHMgKG5vd2F5b3V0PTApDQpbICAgIDAuMDY5Mjc5XSBzYWM1OHIt d2R0IDQwNTBjMDAwLnN3dDogU0FDNThSL1MzMkdFTjEgV2F0Y2hkb2cgVGltZXIgUmVnaXN0ZXJl ZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAuIHRpbWVvdXQ9MzBzIChub3dheW91dD0wKQ0KWyAgICAwLjA2OTQ5Ml0g c2RoY2k6IFNlY3VyZSBEaWdpdGFsIEhvc3QgQ29udHJvbGxlciBJbnRlcmZhY2UgZHJpdmVyDQpb ICAgIDAuMDY5NDk1XSBzZGhjaTogQ29weXJpZ2h0KGMpIFBpZXJyZSBPc3NtYW4NClsgICAgMC4w Njk0OTddIHNkaGNpLXBsdGZtOiBTREhDSSBwbGF0Zm9ybSBhbmQgT0YgZHJpdmVyIGhlbHBlcg0K WyAgICAwLjA2OTgzN10gbW1jMDogQ1FIQ0kgdmVyc2lvbiA1LjEwDQpbICAgIDAuMDcwNDUyXSBo c2UgNDAyMTAwMDAubXUwYjogZmlybXdhcmUgbm90IGZvdW5kDQpbICAgIDAuMDcwNjU4XSB1c2Jj b3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmhpZA0KWyAgICAwLjA3MDY2 Ml0gdXNiaGlkOiBVU0IgSElEIGNvcmUgZHJpdmVyDQpbICAgIDAuMDgyOTkzXSBzMzItYWRjIDQw MWY4MDAwLmFkYzogRGV2aWNlIGluaXRpYWxpemVkIHN1Y2Nlc3NmdWxseS4NClsgICAgMC4wOTQ5 NDddIHMzMi1hZGMgNDAyZTgwMDAuYWRjOiBEZXZpY2UgaW5pdGlhbGl6ZWQgc3VjY2Vzc2Z1bGx5 Lg0KWyAgICAwLjA5NTEwOV0gbnhwX3MzMl9kZHJfcGVyZiA0MDNlMDAwMC5kZHItcGVyZjogcHJv YmluZyBkZXZpY2UNClsgICAgMC4wOTUzNTNdIG54cF9zMzJfZGRyX3BlcmYgNDAzZTAwMDAuZGRy LXBlcmY6IGRldmljZSBpbml0aWFsaXplZCBzdWNjZXNzZnVsICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGx5DQpbICAg IDAuMDk1NDMwXSBzMzItc2l1bDItbnZtZW0gNDAwOWMwMDAubnZyYW06IGluaXRpYWxpemUgczMy IHNpdWwyIG52bWVtIGRyaXZlcg0KWyAgICAwLjA5NTU1MF0gczMyLXNpdWwyLW52bWVtIDQ0MDEw MDAwLm52cmFtOiBpbml0aWFsaXplIHMzMiBzaXVsMiBudm1lbSBkcml2ZXINClsgICAgMC4wOTU5 NDldIE5FVDogUmVnaXN0ZXJlZCBwcm90b2NvbCBmYW1pbHkgMTANClsgICAgMC4wOTY0MzZdIFNl Z21lbnQgUm91dGluZyB3aXRoIElQdjYNClsgICAgMC4wOTY0NzZdIHNpdDogSVB2NiwgSVB2NCBh bmQgTVBMUyBvdmVyIElQdjQgdHVubmVsaW5nIGRyaXZlcg0KWyAgICAwLjA5Njg1Ml0gTkVUOiBS ZWdpc3RlcmVkIHByb3RvY29sIGZhbWlseSAxNw0KWyAgICAwLjA5Njk0N10gY2FuOiBjb250cm9s bGVyIGFyZWEgbmV0d29yayBjb3JlDQpbICAgIDAuMDk2OTgwXSBORVQ6IFJlZ2lzdGVyZWQgcHJv dG9jb2wgZmFtaWx5IDI5DQpbICAgIDAuMDk2OTg0XSBjYW46IHJhdyBwcm90b2NvbA0KWyAgICAw LjA5Njk4OV0gY2FuOiBicm9hZGNhc3QgbWFuYWdlciBwcm90b2NvbA0KWyAgICAwLjA5Njk5Nl0g Y2FuOiBuZXRsaW5rIGdhdGV3YXkgLSBtYXhfaG9wcz0xDQpbICAgIDAuMDk3MDE0XSA4MDIxcTog ODAyLjFRIFZMQU4gU3VwcG9ydCB2MS44DQpbICAgIDAuMDk3MTQ5XSBwcmludGs6IGNvbnNvbGUg W3R0eUxGMF06IHByaW50aW5nIHRocmVhZCBzdGFydGVkDQpbICAgIDAuMTAwNzAzXSBtbWMwOiBT REhDSSBjb250cm9sbGVyIG9uIDQwMmYwMDAwLnVzZGhjIFs0MDJmMDAwMC51c2RoY10gdXNpbmcg QSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBETUENClsgICAgMC4xMDg2NzRdIHBoeS1zMzJnZW4xLXNlcmRlcyA0MDQ4 MDAwMC5zZXJkZXM6IFVzaW5nIG1vZGUgMCBmb3IgU2VyRGVzIHN1YnN5ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 ZW0NClsgICAgMC4xMDkwMjBdIHBoeS1zMzJnZW4xLXNlcmRlcyA0NDE4MDAwMC5zZXJkZXM6IFVz aW5nIG1vZGUgMyBmb3IgU2VyRGVzIHN1YnN5ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZW0NClsgICAgMC4xMTUx MzFdIHBoeS1zMzJnZW4xLXNlcmRlcyA0NDE4MDAwMC5zZXJkZXM6IFVuc3RhYmxlIFJYIGRldGVj dGVkIG9uIFhQQ1MxDQpbICAgIDAuMTE1MTU4XSBwaHktczMyZ2VuMS1zZXJkZXMgNDQxODAwMDAu c2VyZGVzOiBVbnN0YWJsZSBSWCBkZXRlY3RlZCBvbiBYUENTMA0KWyAgICAwLjExNTMzN10gczMy Z2VuMS1wY2llIDQwNDAwMDAwLnBjaWU6IENvbmZpZ3VyZWQgYXMgUm9vdENvbXBsZXgNClsgICAg MC4xMTU2MjddIHMzMmdlbjEtcGNpZSA0MDQwMDAwMC5wY2llOiBTZXR0aW5nIFBDSSBEZXZpY2Ug YW5kIFZlbmRvciBJRHMgdG8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDB4NDMwMDoweDE5NTcNClsgICAgMC4xMTY2 MTRdIHMzMmdlbjEtcGNpZSA0MDQwMDAwMC5wY2llOiBBbGxvY2F0ZWQgbGluZSAwIGZvciBpbnRl cnJ1cHQgNTIgKG1zICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGkpDQpbICAgIDAuMzgzMzE2XSBtbWMwOiBDb21tYW5k IFF1ZXVlIEVuZ2luZSBlbmFibGVkDQpbICAgIDAuMzgzMzI2XSBtbWMwOiBuZXcgRERSIE1NQyBj YXJkIGF0IGFkZHJlc3MgMDAwMQ0KWyAgICAwLjM5MTQwOV0gbW1jYmxrMDogbW1jMDowMDAxIEcx TTE1TSA1OS4zIEdpQg0KWyAgICAwLjM5MTUzOV0gbW1jYmxrMGJvb3QwOiBtbWMwOjAwMDEgRzFN MTVNIHBhcnRpdGlvbiAxIDMxLjUgTWlCDQpbICAgIDAuMzkxNjYxXSBtbWNibGswYm9vdDE6IG1t YzA6MDAwMSBHMU0xNU0gcGFydGl0aW9uIDIgMzEuNSBNaUINClsgICAgMC4zOTE4MDRdIG1tY2Js azBycG1iOiBtbWMwOjAwMDEgRzFNMTVNIHBhcnRpdGlvbiAzIDQuMDAgTWlCLCBjaGFyZGV2ICgy NDM6ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDApDQpbICAgIDAuMzk5MjA4XSAgbW1jYmxrMDogcDEgcDIgcDMNClsg ICAgMS4xMzYxMTZdIHMzMmdlbjEtcGNpZSA0MDQwMDAwMC5wY2llOiBGYWlsZWQgdG8gc3RhYmls aXplIFBIWSBsaW5rDQpbICAgIDEuMTM2MTIzXSBzMzJnZW4xLXBjaWUgNDA0MDAwMDAucGNpZTog Q29uZmlndXJpbmcgYXMgUm9vdENvbXBsZXgNClsgICAgMS4xMzYxMzZdIHMzMmdlbjEtcGNpZSA0 MDQwMDAwMC5wY2llOiBob3N0IGJyaWRnZSAvc29jL3BjaWVANDA0MDAwMDAgcmFuZ2VzICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDoNClsgICAgMS4xMzYxNzddIHMzMmdlbjEtcGNpZSA0MDQwMDAwMC5wY2llOiAgICAg ICBJTyAweDVmZmZmZTAwMDAuLjB4NWZmZmZlZmZmZiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgID4gMHgwMDAwMDAw MDAwDQpbICAgIDEuMTM2MTk1XSBzMzJnZW4xLXBjaWUgNDA0MDAwMDAucGNpZTogICAgICBNRU0g MHg1ODAwMDAwMDAwLi4weDVmZmZmZGZmZmYgLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA+IDB4MDAwMDAwMDAwMA0K KFhFTikgcGh5c2Rldi5jOjE2OmQwdjAgUEhZU0RFVk9QIGNtZD0yNTogbm90IGltcGxlbWVudGVk DQpbICAgIDIuMTQyMDQxXSBzMzJnZW4xLXBjaWUgNDA0MDAwMDAucGNpZTogUGh5IGxpbmsgbmV2 ZXIgY2FtZSB1cA0KKFhFTikgcGh5c2Rldi5jOjE2OmQwdjAgUEhZU0RFVk9QIGNtZD0xNTogbm90 IGltcGxlbWVudGVkDQpbICAgIDIuMTQyMTMzXSBzMzJnZW4xLXBjaWUgNDA0MDAwMDAucGNpZTog UENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDAwOjAwDQpbICAgIDIuMTQyMTM5XSBwY2lfYnVzIDAw MDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgMDAtZmZdDQpbICAgIDIuMTQyMTQ3XSBwY2lf YnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNlIFtpbyAgMHgwMDAwLTB4ZmZmZl0NClsgICAg Mi4xNDIxNTNdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDU4MDAw MDAwMDAtMHg1ZmZmZmRmZmZmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF0gKGJ1cyBhZGRyZXNzIFsweDAwMDAwMDAw LTB4N2ZmZmRmZmZmXSkNClsgICAgMi4xNDIyMDFdIHBjaSAwMDAwOjAwOjAwLjA6IFsxNmMzOjQz MDBdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDANClsgICAgMi4xNDIyMjRdIHBjaSAwMDAwOjAwOjAw LjA6IHJlZyAweDEwOiBbbWVtIDB4NTgwMDAwMDAwMC0weDU4MDAwZmZmZmZdDQpbICAgIDIuMTQy MjQyXSBwY2kgMDAwMDowMDowMC4wOiByZWcgMHgzODogW21lbSAweDU4MDAwMDAwMDAtMHg1ODAw MDBmZmZmIHByZWZdDQpbICAgIDIuMTQyMzM5XSBwY2kgMDAwMDowMDowMC4wOiBzdXBwb3J0cyBE MQ0KWyAgICAyLjE0MjM0NF0gcGNpIDAwMDA6MDA6MDAuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE MCBEMSBEM2hvdCBEM2NvbGQNClsgICAgMi4xNjU1MjZdIHBjaSAwMDAwOjAwOjAwLjA6IEZhaWxl ZCB0byBhZGQgLSBwYXNzdGhyb3VnaCBvciBNU0kvTVNJLVggbWlnaHQgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZh aWwhDQpbICAgIDIuMTY4NTIxXSBwY2kgMDAwMDowMDowMC4wOiBCQVIgMDogYXNzaWduZWQgW21l bSAweDU4MDAwMDAwMDAtMHg1ODAwMGZmZmZmXQ0KWyAgICAyLjE2ODUzMl0gcGNpIDAwMDA6MDA6 MDAuMDogQkFSIDY6IGFzc2lnbmVkIFttZW0gMHg1ODAwMTAwMDAwLTB4NTgwMDEwZmZmZiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcHJlZl0NClsgICAgMi4xNjg1NDFdIHBjaSAwMDAwOjAwOjAwLjA6IFBDSSBicmlk Z2UgdG8gW2J1cyAwMS1mZl0NClsgICAgMi4xNjg4MzldIHBjaWVwb3J0IDAwMDA6MDA6MDAuMDog UE1FOiBTaWduYWxpbmcgd2l0aCBJUlEgNjcNClsgICAgMi4xNzUxNThdIGNsazogTm90IGRpc2Fi bGluZyB1bnVzZWQgY2xvY2tzDQpbICAgIDIuMjcwNDU3XSByYW5kb206IGZhc3QgaW5pdCBkb25l DQpbICAgIDIuMjgyNDIyXSBFWFQ0LWZzIChtbWNibGswcDIpOiByZWNvdmVyeSBjb21wbGV0ZQ0K WyAgICAyLjI4MzE3MV0gRVhUNC1mcyAobW1jYmxrMHAyKTogbW91bnRlZCBmaWxlc3lzdGVtIHdp dGggb3JkZXJlZCBkYXRhIG1vZGUuIE8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHRzOiAobnVsbCkNClsgICAgMi4y ODMyMjldIFZGUzogTW91bnRlZCByb290IChleHQ0IGZpbGVzeXN0ZW0pIG9uIGRldmljZSAxNzk6 Mi4NClsgICAgMi4yODM1NzFdIGRldnRtcGZzOiBtb3VudGVkDQpbICAgIDIuMjg0MTc5XSBGcmVl aW5nIHVudXNlZCBrZXJuZWwgbWVtb3J5OiAxMzQ0Sw0KWyAgICAyLjI4NDMxMl0gUnVuIC9zYmlu L2luaXQgYXMgaW5pdCBwcm9jZXNzDQpbICAgIDIuNDEzNDg4XSBzeXN0ZW1kWzFdOiBTeXN0ZW0g dGltZSBiZWZvcmUgYnVpbGQgdGltZSwgYWR2YW5jaW5nIGNsb2NrLg0KWyAgICAyLjQ0MTI5OF0g c3lzdGVtZFsxXTogc3lzdGVtZCAyNDYgcnVubmluZyBpbiBzeXN0ZW0gbW9kZS4gKCtQQU0gLUFV RElUIC1TRUwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSU5VWCArSU1BIC1BUFBBUk1PUiAtU01BQ0sgK1NZU1ZJTklU ICtVVE1QIC1MSUJDUllQVFNFVFVQIC1HQ1JZUFQgLUdOVVRMUyArQUNMICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg WFogLUxaNCAtWlNURCAtU0VDQ09NUCArQkxLSUQgLUVMRlVUSUxTICtLTU9EIC1JRE4yIC1JRE4g LVBDUkUyIGRlZmF1bHQtaGllcmFyY2ggICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeT1oeWJyaWQpDQoNCldbICAgIDIu NDQyMzA3XSBzeXN0ZW1kWzFdOiBEZXRlY3RlZCBhcmNoaXRlY3R1cmUgYXJtNjQuDQplbGNvbWUg dG8gQXV0byBMaW51eCBCU1AgMzMuMCAoZ2F0ZXNnYXJ0aCkhDQoNClsgICAgMi40ODQ5NzVdIHN5 c3RlbWRbMV06IFNldCBob3N0bmFtZSB0byA8czMyZzM5OWFldmIzPi4NClsgICAgMi41Nzc2ODNd IHN5c3RlbWQtc3lzdi1nZW5lcmF0b3JbNzZdOiBTeXNWIHNlcnZpY2UgJy9ldGMvaW5pdC5kL25l dHBlcmYnIGxhICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGNrcyBhIG5hdGl2ZSBzeXN0ZW1kIHVuaXQgZmlsZS4gQXV0 b21hdGljYWxseSBnZW5lcmF0aW5nIGEgdW5pdCBmaWxlIGZvciBjb21wYXRpICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJpbGl0eS4gUGxlYXNlIHVwZGF0ZSBwYWNrYWdlIHRvIGluY2x1ZGUgYSBuYXRpdmUgc3lzdGVt ZCB1bml0IGZpbGUsIGluIG9yZGVyIHRvICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYWtlIGl0IG1vcmUgc2FmZSBh bmQgcm9idXN0Lg0KWyAgICAyLjc2Njc0NF0gc3lzdGVtZFsxXTogL2xpYi9zeXN0ZW1kL3N5c3Rl bS94ZW4tcWVtdS1kb20wLWRpc2stYmFja2VuZC5zZXJ2aWMgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZToxMTogUElE RmlsZT0gcmVmZXJlbmNlcyBhIHBhdGggYmVsb3cgbGVnYWN5IGRpcmVjdG9yeSAvdmFyL3J1bi8s IHVwZGF0aW5nIC92YXIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgL3J1bi94ZW4vcWVtdS1kb20wLnBpZCDihpIgL3J1 bi94ZW4vcWVtdS1kb20wLnBpZDsgcGxlYXNlIHVwZGF0ZSB0aGUgdW5pdCBmaWxlIGFjYyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBvcmRpbmdseS4NClsgIE9LICBbICAgIDIuODQ5NjAzXSBzeXN0ZW1kWzFdOiBRdWV1 ZWQgc3RhcnQgam9iIGZvciBkZWZhdWx0IHRhcmdldCBNdWx0aS1Vc2VyICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBT eXN0ZW0uDQogcmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gcmVhZCAoMTYg Ynl0ZXMgcmVhZCkNCltbICAgIDIuODUxNjE1XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIHN5 c3RlbS1nZXR0eS5zbGljZS4NCjBtXSBDcmVhdGVkIHNsaWNlIHN5c3RlbS1nZXR0eS5zbGljZS4N ClsgIE9LICBdIENyZWF0ZWQgc2xpY2Ugc3lbICAgIDIuODg0NzQzXSByYW5kb206IHN5c3RlbWQ6 IHVuaW5pdGlhbGl6ZWQgdXJhbmRvbSByICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVhZCAoMTYgYnl0ZXMgcmVhZCkN CnNbICAgIDIuODg1MDY0XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIHN5c3RlbS1tb2Rwcm9i ZS5zbGljZS4NCnRlbS1tb2Rwcm9iZS5zbGljZS4NClsgIE9LICBdIENyZWF0ZWQgc2xpY2Ugc3lz WyAgICAyLjkxMjcwNV0gcmFuZG9tOiBzeXN0ZW1kOiB1bmluaXRpYWxpemVkIHVyYW5kb20gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlYWQgKDE2IGJ5dGVzIHJlYWQpDQp0WyAgICAyLjkxMzAwMl0gc3lzdGVtZFsx XTogQ3JlYXRlZCBzbGljZSBzeXN0ZW0tc2VyaWFsXHgyZGdldHR5LnNsaWNlLg0KZW0tc2VyaWFs XHgyZGdldHR5LnNsaWNlLg0KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBVc2VbICAgIDIuOTQwOTYy XSBzeXN0ZW1kWzFdOiBDcmVhdGVkIHNsaWNlIFVzZXIgYW5kIFNlc3MgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW9u IFNsaWNlLg0KciBhbmQgU2Vzc2lvbiBTbGljZS4NClsgIE9LICBdIFN0YXJ0ZWQgRGlzcGF0Y2gg UFsgICAgMi45NjA4NzZdIHN5c3RlbWRbMV06IFN0YXJ0ZWQgRGlzcGF0Y2ggUGFzc3dvcmQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFJlcXVlc3RzIHRvIENvbnNvbGUgRGlyZWN0b3J5IFdhdGNoLg0KYXNzd29yZCDi gKZ0cyB0byBDb25zb2xlIERpcmVjdG9yeSBXYXRjaC4NClsgIE9LICBdIFN0YXJ0ZWQgRm9yd2Fy ZCBQYXNbICAgIDIuOTg4ODI0XSBzeXN0ZW1kWzFdOiBTdGFydGVkIEZvcndhcmQgUGFzc3dvcmQg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFJlcXVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdhdGNoLg0Kc3dvcmQgUuKA pnVlc3RzIHRvIFdhbGwgRGlyZWN0b3J5IFdhdGNoLg0KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQg UGF0aFsgICAgMy4wMTI4NzddIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFBhdGhzLg0Kcy4N ClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJlbW90WyAgICAzLjAzMjc1NF0gc3lzdGVtZFsxXTog UmVhY2hlZCB0YXJnZXQgUmVtb3RlIEZpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlIFN5c3RlbXMuDQplIEZpbGUg U3lzdGVtcy4NClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFNsaWNlWyAgICAzLjA1Mjc0NF0gc3lz dGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgU2xpY2VzLg0Kcy4NClsgIE9LICBdIFJlYWNoZWQgdGFy Z2V0IFN3YXAgc3lzdGVtZFsxXTogUmVhY2hlZCB0YXJnZXQgU3dhcC4NClswbS4NClsgIE9LICAg c3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVyIEFjdGl2YXRpb24gU29ja2V0 Lg0KWzBtXSBMaXN0ZW5pbmcgb24gUlBDYmluZCBTZXJ2ZXIgQWN0aXZhdGlvbiBTb2NrZXQuDQpb ICBPSyAgXSBSZWFjaGVkIHRhcmdldCBSUEMgWyAgICAzLjEyNDg0NF0gc3lzdGVtZFsxXTogUmVh Y2hlZCB0YXJnZXQgUlBDIFBvcnQgTSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhcHBlci4NClBvcnQgTWFwcGVyLg0K WyAgT0sgIF0gTGlzdGVuaW5nIG9uIFN5WyAgICAzLjE0NTE1M10gc3lzdGVtZFsxXTogTGlzdGVu aW5nIG9uIFN5c2xvZyBTb2NrZXQuDQpzbG9nIFNvY2tldC4NClsgIE9LICBdIExpc3RlbmluZyBv biBpbml0Y1sgICAgMy4xNjQ4ODZdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBpbml0Y3RsIENv bXBhICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRpYmlsaXR5IE5hbWVkIFBpcGUuDQp0bCBDb21wYXRpYmlsaXR5IE5h bWVkIFBpcGUuDQpbICBPSyAgICAgIDMuMTkxMDM1XSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hl Y2sgcmVzdWx0ZWQgaW4gSm91cm5hbCBBdWRpdCBTb2NrZSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0IGJlaW5nIHNr aXBwZWQuDQptWyAgICAzLjE5MTQ5Nl0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIEpvdXJuYWwg U29ja2V0ICgvZGV2L2xvZykuDQpdIExpc3RlbmluZyBvbiBKb3VybmFsIFNvY2tldCAoL2Rldi9s b2cpLg0KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEpvdVsgICAgMy4yMjExMDZdIHN5c3RlbWRbMV06 IExpc3RlbmluZyBvbiBKb3VybmFsIFNvY2tldC4NCnJuYWwgU29ja2V0Lg0KWyAgT0sgIF0gTGlz dGVuaW5nIG9uIE5lWyAgICAzLjI0MTE5MF0gc3lzdGVtZFsxXTogTGlzdGVuaW5nIG9uIE5ldHdv cmsgU2VydmljZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgTmV0bGluayBTb2NrZXQuDQp0d29yayBTZXJ2aWNlIE5l dGxpbmsgU29ja2V0Lg0KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHVkZVsgICAgMy4yNjUwNTFdIHN5 c3RlbWRbMV06IExpc3RlbmluZyBvbiB1ZGV2IENvbnRyb2wgU28gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2tldC4N CnYgQ29udHJvbCBTb2NrZXQuDQpbICBPSyAgXSBMaXN0ZW5pbmcgb24gdWRldiBbICAgIDMuMjg0 OTE5XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gdWRldiBLZXJuZWwgUyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBv Y2tldC4NCktlcm5lbCBTb2NrZXQuDQpbICBPSyAgXSBMaXN0ZW5pbmcgb24gVXNlciBbICAgIDMu MzA0OTM2XSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gVXNlciBEYXRhYmFzZSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTWFuYWdlciBTb2NrZXQuDQpEYXRhYmFzZSBNYW5hZ2VyIFNvY2tldC4NCiAgICAgICAgIE1v dW50aW5nIEhbICAgIDMuMzMwNTkxXSBzeXN0ZW1kWzFdOiBNb3VudGluZyBIdWdlIFBhZ2VzIEZp bGUgU3lzdGVtLi4uDQp1Z2UgUGFnZXMgRmlsZSBTeXN0ZW0uLi4NCiAgICAgICAgIE1vdW50aW5n ICAgICAzLjM1MzE1Nl0gc3lzdGVtZFsxXTogQ29uZGl0aW9uIGNoZWNrIHJlc3VsdGVkIGluIFBP U0lYIE1lICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtIGJlaW5nIHNraXBwZWQu DQo7MzltTW91bnQgL3Byb2MveGVuIGZpbGVzLi4uDQogICAgICBbICAgIDMuMzU0OTU0XSBzeXN0 ZW1kWzFdOiBNb3VudGluZyBNb3VudCAvcHJvYy94ZW4gZmlsZXMuLi4NCiBbICAgIDMuMzcwOTMz XSBzeXN0ZW1kWzFdOiBNb3VudGluZyBLZXJuZWwgRGVidWcgRmlsZSBTeXN0ZW0uLi4NCiAgTW91 bnRpbmcgS2VybmVsIERlYnVnIEZpbGUgU3lzdGVtLi4uDQogICAgICAgICBTdGFydGlbICAgIDMu NDAxMTkxXSBzeXN0ZW1kWzFdOiBDb25kaXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gS2VybmVsIFRy YSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjZSBGaWxlIFN5c3RlbSBiZWluZyBza2lwcGVkLg0KbmcgTG9hZCBLZXJu ZWwgTW9kdWxlIGNvblsgICAgMy40MDE2NzldIHN5c3RlbWRbMV06IENvbmRpdGlvbiBjaGVjayBy ZXN1bHRlZCBpbiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgQ3JlYXRlIGxpc3Qgb2Ygc3RhdGljIGRldmljZSBub2Rl cyBmb3IgdGhlIGN1cnJlbnQga2VybmVsIGJlaW5nIHNraXBwZWQuDQpmaVsgICAgMy40MDM2NDJd IHN5c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZSBjb25maWdmcy4uLg0KZ2Zz Li4uDQogICAgICAgICBTdGFydGluZyAgICAgMy40NDY3NzFdIHN5c3RlbWRbMV06IFN0YXJ0aW5n IExvYWQgS2VybmVsIE1vZHVsZSBkcm0uLi4NCjltTG9hZCBLZXJuZWwgTW9kdWxlIGRybS4uLg0K ICAgICAgICAgU3RhcnRpbmcgICAgIDMuNDcwNzcxXSBzeXN0ZW1kWzFdOiBTdGFydGluZyBMb2Fk IEtlcm5lbCBNb2R1bGUgZnVzZS4uLg0KOW1Mb2FkIEtlcm5lbCBNb2R1bGUgZnVzZS4uLg0KICAg ICAgICAgU3RhcnRpbmcgICAgIDMuNDk0Nzg4XSBzeXN0ZW1kWzFdOiBTdGFydGluZyBSUEMgQmlu ZC4uLg0KOW1SUEMgQmluZC4uLg0KICAgICBbICAgIDMuNTEzMDAwXSBzeXN0ZW1kWzFdOiBDb25k aXRpb24gY2hlY2sgcmVzdWx0ZWQgaW4gRmlsZSBTeXN0ZW0gQ2hlY2sgb24gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFJvb3QgRGV2aWNlIGJlaW5nIHNraXBwZWQuDQogICAgU3RhcnRpbmcgSm91clsgICAgMy41MTY0 NTVdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIEpvdXJuYWwgU2VydmljZS4uLg0KbmFsIFNlcnZpY2Uu Li4NCiAgICAgICAgIFsgICAgMy41NDgxMDFdIHN5c3RlbWRbMV06IFN0YXJ0aW5nIExvYWQgS2Vy bmVsIE1vZHVsZXMuLi4NClN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZXMuLi4NCiAgICAgICAg IFN0YXJ0aW5nICAgICAzLjU3MDgxOV0gc3lzdGVtZFsxXTogU3RhcnRpbmcgUmVtb3VudCBSb290 IGFuZCBLZXJuZWwgRmlsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGUgU3lzdGVtcy4uLg0KOW1SZW1vdW50IFJvb3Qg YW5kIEtlcm5lbCBGaWxlIFN5c3RlbXMuLi4NCiAgICAgWyAgICAzLjU5NTAxOF0gc3lzdGVtZFsx XTogU3RhcnRpbmcgQ29sZHBsdWcgQWxsIHVkZXYgRGV2aWNlcy4uLg0KICAgIFN0YXJ0aW5nIENv bGRwbHVnIEFsbCB1ZGV2IERldmljZXMuLi4NClsgICAgMy42MzI0NTddIGxsY2VfY29yZSA0M2Zm ODAwMC5sbGNlOiBTdWNjZXNzZnVsbHkgbG9hZGVkIExMQ0UgZmlybXdhcmUNClsgICAgMy42Mzk2 NDFdIHN5c3RlbWRbMV06IFN0YXJ0ZWQgUlBDIEJpbmQuDQozMm0gIE9LICBdIFN0YXJ0ZWQgUlBD IEJpbmQuDQpbICAgIDMuNjUxMjMzXSBFWFQ0LWZzIChtbWNibGswcDIpOiByZS1tb3VudGVkLiBP cHRzOiAobnVsbCkNClsgICAgMy43MDY1NDRdIHN5c3RlbWRbMV06IE1vdW50ZWQgSHVnZSBQYWdl cyBGaWxlIFN5c3RlbS4NCjMybSAgT0sgIF0gTW91bnRlZCBIdWdlIFBhZ2VzIEZpbGUgU3lzdGVt Lg0KWyAgICAzLjcyOTE4NF0gc3lzdGVtZFsxXTogTW91bnRlZCBNb3VudCAvcHJvYy94ZW4gZmls ZXMuDQozMm0gIE9LICBdIE1vdW50ZWQgTW91bnQgL3Byb2MveGVuIGZpbGVzLg0KWyAgT0sgIF0g U3RhcnRlZCBKb3VybmFbICAgIDMuNzQ5MTU4XSBzeXN0ZW1kWzFdOiBTdGFydGVkIEpvdXJuYWwg U2VydmljZS4NCmwgU2VydmljZS4NClsgIE9LICBdIE1vdW50ZWQgS2VybmVsIERlYnVnIEZpbGUg U3lzdGVtLg0KWyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwgTW9kdWxlIGNvbmZpZ2ZzLg0K WyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwgTW9kdWxlIGRybS4NClsgICAgMy44MDQ2OTRd IGxsY2VfbWIgNDNhMDAwMDAubGxjZV9tYjogTExDRSBmaXJtd2FyZSB2ZXJzaW9uOiBHR0VFXzNB DQpbICAgIDMuODA0NzExXSBsbGNlX21iIDQzYTAwMDAwLmxsY2VfbWI6IExMQ0UgZmlybXdhcmU6 IGxvZ2dpbmcgc3VwcG9ydCBkaXNhYmxlZA0KWyAgT0sgIF0gRmluaXNoZWQgTG9hZCBLZXJuZWwg TW9kdWxlIGZ1c2UuDQpbICBPSyAgXSBGaW5pc2hlZCBSZW1vdW50IFJvb3QgYW5kIEtlcm5lbCBG aWxlIFN5c3RlbXMuDQogICAgICAgICBNb3VudGluZyBGVVNFIENvbnRyb2wgRmlsZSBTeXN0ZW0u Li4NCiAgICAgICAgIE1vdW50aW5nIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLi4u DQpbICAgIDMuOTE2MzYzXSBsbGNlX2NhbjogdW5rbm93biBwYXJhbWV0ZXIgJ2xvZ2dpbmcnIGln bm9yZWQNCiAgICAgICAgIFN0YXJ0aW5nIEZsdXNoIEpvdXJuYWwgdG8gUGVyc2lzdGVudCBTdG9y YWdlLi4uDQogICAgICAgICBTdGFydGluZyBDcmVhdGUgU3RhdGljIERldmljZSBOb2RlcyBpbiAv ZGV2Li4uDQpbICBPSyAgXSBNb3VudGVkIEZVU0UgQ29udHJvbCBGaWxlIFN5c3RlbS4NClsgIE9L ICBdIEZpbmlzaGVkIExvYWQgS2VybmVsIE1vZHVsZXMuDQpbICBPSyAgXSBNb3VudGVkIEtlcm5l bCBDb25maWd1cmF0aW9uIEZpbGUgU3lzdGVtLg0KWyAgT0sgIF0gRmluaXNoZWQgRmx1c2ggSm91 cm5hbCB0byBQZXJzaXN0ZW50IFN0b3JhZ2UuDQpbICBPSyAgXSBGaW5pc2hlZCBDcmVhdGUgU3Rh dGljIERldmljZSBOb2RlcyBpbiAvZGV2Lg0KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTG9jYWwg RmlsZSBTeXN0ZW1zIChQcmUpLg0KICAgICAgICAgTW91bnRpbmcgTkZTRCBjb25maWd1cmF0aW9u IGZpbGVzeXN0ZW0uLi4NCiAgICAgICAgIE1vdW50aW5nIC90bXAuLi4NCiAgICAgICAgIE1vdW50 aW5nIG1vdW50IHhlbnN0b3JlIGZpbGUgc3lzdGVtLi4uDQogICAgICAgICBNb3VudGluZyAvdmFy L3ZvbGF0aWxlLi4uDQogICAgICAgICBTdGFydGluZyBBcHBseSBLZXJuZWwgVmFyaWFibGVzLi4u DQogICAgICAgICBTdGFydGluZyBSdWxlLWJhc2VkIE1hbmFnZeKApmZvciBEZXZpY2UgRXZlbnRz IGFuZCBGaWxlcy4uLg0KWyAgT0sgIF0gRmluaXNoZWQgQ29sZHBsdWcgQWxsIHVkZXYgRGV2aWNl cy4NCltGQUlMRURdIEZhaWxlZCB0byBtb3VudCBORlNEIGNvbmZpZ3VyYXRpb24gZmlsZXN5c3Rl bS4NClNlZSAnc3lzdGVtY3RsIHN0YXR1cyBwcm9jLWZzLW5mc2QubW91bnQnIGZvciBkZXRhaWxz Lg0KW0RFUEVORF0gRGVwZW5kZW5jeSBmYWlsZWQgZm9yIE5GUyBzZXJ2ZXIgYW5kIHNlcnZpY2Vz Lg0KW0RFUEVORF0gRGVwZW5kZW5jeSBmYWlsZWQgZm9yIE5GUyBNb3VudCBEYWVtb24uDQpbICBP SyAgXSBTdGFydGVkIFJ1bGUtYmFzZWQgTWFuYWdlciBmb3IgRGV2aWNlIEV2ZW50cyBhbmQgRmls ZXMuDQpbICBPSyAgXSBNb3VudGVkIC90bXAuDQpbICBPSyAgXSBNb3VudGVkIG1vdW50IHhlbnN0 b3JlIGZpbGUgc3lzdGVtLg0KWyAgT0sgIF0gTW91bnRlZCAvdmFyL3ZvbGF0aWxlLg0KWyAgT0sg IF0gRmluaXNoZWQgQXBwbHkgS2VybmVsIFZhcmlhYmxlcy4NCiAgICAgICAgIE1vdW50aW5nIC92 YXIvdm9sYXRpbGUvdG1wLi4uDQogICAgICAgICBTdGFydGluZyBMb2FkL1NhdmUgUmFuZG9tIFNl ZWQuLi4NClsgIE9LICBdIE1vdW50ZWQgL3Zhci92b2xhdGlsZS90bXAuDQpbICBPSyAgXSBSZWFj aGVkIHRhcmdldCBMb2NhbCBGaWxlIFN5c3RlbXMuDQogICAgICAgICBTdGFydGluZyBDcmVhdGUg Vm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVzLi4uDQpbICBPSyAgXSBGaW5pc2hlZCBDcmVh dGUgVm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVzLg0KWyAgICA1LjA2MDA5MV0gcGZlbmc6 IGxvYWRpbmcgb3V0LW9mLXRyZWUgbW9kdWxlIHRhaW50cyBrZXJuZWwuDQpbICAgIDUuMDg3NzMy XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFBGRW5nIGV0aGVybmV0IGRyaXZlciBsb2FkaW5nIC4uLg0K WyAgICA1LjA4Nzc0OV0gcGZlbmcgNDYwMDAwMDAucGZlOiBWZXJzaW9uOiBSVE0gMS4wLjANClsg ICAgNS4wODc3NTNdIHBmZW5nIDQ2MDAwMDAwLnBmZTogTXVsdGkgaW5zdGFuY2Ugc3VwcG9ydDog ZGlzYWJsZWQgKHN0YW5kYWxvbmUpDQpbICAgIDUuMDg3NzU2XSBwZmVuZyA0NjAwMDAwMC5wZmU6 IENvbXBpbGVkIGJ5OiAxMC4yLjANClsgICAgNS4wODc3ODNdIHBmZW5nIDQ2MDAwMDAwLnBmZTog Q2J1cyBhZGRyIDB4NDYwMDAwMDAgc2l6ZSAweDEwMDAwMDANClsgICAgNS4wODc3OTFdIHBmZW5n IDQ2MDAwMDAwLnBmZTogbnhwLGZ3LWNsYXNzLW5hbWU6IHMzMmdfcGZlX2NsYXNzLmZ3DQpbICAg IDUuMDg3Nzk2XSBwZmVuZyA0NjAwMDAwMC5wZmU6IG54cCxmdy11dGlsLW5hbWU6IHMzMmdfcGZl X3V0aWwuZncNClsgICAgNS4wODc4NDhdIHBmZW5nIDQ2MDAwMDAwLnBmZTogaXJxICdoaWYwJyA6 IDU4DQpbICAgIDUuMDg3ODYyXSBwZmVuZyA0NjAwMDAwMC5wZmU6IGlycSAnaGlmMScgOiA1OQ0K WyAgICA1LjA4Nzg3NF0gcGZlbmcgNDYwMDAwMDAucGZlOiBpcnEgJ2hpZjInIDogNjANClsgICAg NS4wODc4NzldIHBmZW5nIDQ2MDAwMDAwLnBmZTogSElGIGNoYW5uZWxzIG1hc2s6IDB4MDAwNw0K WyAgICA1LjA4Nzg5MF0gcGZlbmcgNDYwMDAwMDAucGZlOiBuZXRpZiBuYW1lOiBwZmUwDQpbICAg IDUuMDg3ODk2XSBwZmVuZyA0NjAwMDAwMC5wZmU6IERUIG1hYyBhZGRyOiAwMDowMTpiZTpiZTpl ZjoxMQ0KWyAgICA1LjA4NzkwM10gcGZlbmcgNDYwMDAwMDAucGZlOiBuZXRpZihwZmUwKSBtb2Rl OiBzdGQNClsgICAgNS4wODc5MDhdIHBmZW5nIDQ2MDAwMDAwLnBmZTogbmV0aWYocGZlMCkgRU1B QzogMA0KWyAgICA1LjA4NzkxNF0gcGZlbmcgNDYwMDAwMDAucGZlOiBuZXRpZihwZmUwKSBISUZz OiBjb3VudCAxIG1hcCAwMQ0KWyAgICA1LjA4NzkyM10gcGZlbmcgNDYwMDAwMDAucGZlOiBFTUFD MCBpbnRlcmZhY2UgbW9kZTogNA0KWyAgICA1LjA4ODA2MF0gcGZlbmcgNDYwMDAwMDAucGZlOiBQ RkUgcG9ydCBjb2hlcmVuY3kgZW5hYmxlZCwgbWFzayAweDFlDQpbICAgIDUuMDg4MjQ5XSBwZmVu ZyA0NjAwMDAwMC5wZmU6IENsb2Nrczogc3lzPTMwME1IeiBwZT02MDBNSHoNClsgICAgNS4wODgy NjNdIHBmZW5nIDQ2MDAwMDAwLnBmZTogSW50ZXJmYWNlIHNlbGVjdGVkOiBFTUFDMDogMHg0IEVN QUMxOiAweGZmZmZmICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGZmZiBFTUFDMjogMHhmZmZmZmZmZg0KWyAgICA1LjEy MDA1N10gcGZlbmcgNDYwMDAwMDAucGZlOiBQRkUgY29udHJvbGxlciByZXNldCBkb25lDQpbICAg IDUuMTIwMTY5XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFRYIGNsb2NrIG9uIEVNQUMwIGZvciBpbnRl cmZhY2Ugc2dtaWkgaW5zdGFsbCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZA0KWyAgICA1LjEyMDIxOV0gcGZlbmcg NDYwMDAwMDAucGZlOiBSWCBjbG9jayBvbiBFTUFDMCBmb3IgaW50ZXJmYWNlIHNnbWlpIGluc3Rh bGwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZWQNClsgICAgNS4xMjA1NTZdIHBmZW5nIDQ2MDAwMDAwLnBmZTogYXNz aWduZWQgcmVzZXJ2ZWQgbWVtb3J5IG5vZGUgcGZlYnVmc0AzNDAwMDAwICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAN CiAgICAgWyAgICA1LjEyOTIyMV0gcGZlbmcgNDYwMDAwMDAucGZlOiBhc3NpZ25lZCByZXNlcnZl ZCBtZW1vcnkgbm9kZSBwZmVidWZzQDM0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDA4MDAwMA0KICAgIFN0YXJ0aW5n IE5ldHdvcmsgVGltZSBTeW5jaHJvbml6YXRpb24uLi4NClsgICAgNS4xMjkzMjBdIHBmZW5nIDQ2 MDAwMDAwLnBmZTogYXNzaWduZWQgcmVzZXJ2ZWQgbWVtb3J5IG5vZGUgcGZlYnVmc0A4MzIwMDAw ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIDANCiAgICAgWyAgICA1LjEyOTM1M10gcGZlbmcgNDYwMDAwMDAucGZlOiBh c3NpZ25lZCByZXNlcnZlZCBtZW1vcnkgbm9kZSBwZmVidWZzQDgzICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDVlMDAw MA0KICAgIFN0YXJ0aW5nIFVwZGF0ZSBVVE1QIGFib3V0IFN5c3RlbSBCb290L1NodXRkb3duLi4u DQpbICAgIDUuMTM3NzMxXSBwZmVuZyA0NjAwMDAwMC5wZmU6IEZpcm13YXJlOiBDTEFTUyBzMzJn X3BmZV9jbGFzcy5mdyBbMzk4NjAgYnl0ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzXQ0KWyAgICA1LjEzNzc0Nl0g cGZlbmcgNDYwMDAwMDAucGZlOiBGaXJtd2FyZTogVVRJTCBzMzJnX3BmZV91dGlsLmZ3IFsxOTk0 MCBieXRlc10NCjMybSAgT0sgIF0gRmluaXNoZWQgVXBkYXRlIFVUTVAgYWJvdXQgU3lzdGVtIEJv b3QvU2h1dGRvd24uDQpbICAgIDUuMTM3NzY1XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFBGRSBDQlVT IHAweDQ2MDAwMDAwIG1hcHBlZCBAIHYweGZmZmZmZmMwMTMwMCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwMDAwDQpb ICAgIDUuMTM3NzgxXSBwZmVuZyA0NjAwMDAwMC5wZmU6IEhXIHZlcnNpb24gMHgxMDENClsgICAg NS4xMzc3ODhdIHBmZW5nIDQ2MDAwMDAwLnBmZTogU2lsaWNvbiBTMzJHMw0KWyAgICA1LjEzNzc5 NV0gcGZlbmcgNDYwMDAwMDAucGZlOiBGYWlsLVN0b3AgbW9kZSBkaXNhYmxlZA0KWyAgICA1LjEz OTIxOV0gcGZlbmcgNDYwMDAwMDAucGZlOiBCTVUxIGJ1ZmZlciBiYXNlOiBwMHhjMDAwMDAwMA0K WyAgICA1LjEzOTMxOF0gcGZlbmcgNDYwMDAwMDAucGZlOiBCTVUyIGJ1ZmZlciBiYXNlOiBwMHgz NDAwMDAwMCAoMHg4MDAwMCBieXRlcykNClsgICAgNS4xNDA2MzFdIHBmZW5nIDQ2MDAwMDAwLnBm ZTogcmVnaXN0ZXIgSVJRIDYyIGJ5IG5hbWUgJ1BGRSBCTVUgSVJRJw0KWyAgICA1LjE3Mzc5N10g cGZlbmcgNDYwMDAwMDAucGZlOiBCTVVfRU1QVFlfSU5UIChCTVUgQCBwMHgoX19fX3B0cnZhbF9f X18pKS4gUG8gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgb2wgcmVhZHkuDQpbICAgIDUuMTczODE5XSBwZmVuZyA0NjAw MDAwMC5wZmU6IEJNVV9FTVBUWV9JTlQgKEJNVSBAIHAweChfX19fcHRydmFsX19fXykpLiBQbyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBvbCByZWFkeS4NClsgICAgNS4xNzM4NTddIHBmZW5nIDQ2MDAwMDAwLnBmZTog RmlybXdhcmUgLmVsZiBkZXRlY3RlZA0KMzJtICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgVGltZSBT eW5jaHJvbml6YXRpb24gICAgNS4xNzM4NjRdIHBmZW5nIDQ2MDAwMDAwLnBmZTogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFVwbG9hZGluZyBDTEFTUyBmaXJtd2FyZQ0KMG0uDQpbICAgIDUuMTczODcxXSBwZmVuZyA0 NjAwMDAwMC5wZmU6IFNlbGVjdGVkIEZXIGxvYWRpbmcgT1BzIHRvIGxvYWQgOCBQRXMgaW4gcGFy YSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsbGVsDQpbICAgIDUuMzQxMzQ2XSBwZmVuZyA0NjAwMDAwMC5wZmU6IHBm ZV9jdC5oIGZpbGUgdmVyc2lvbiJlMWNiMzc2YjY3ZmE0ZDFkZTgwMGIxMyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAy YjMyOGI0MmMiDQpbICAgIDUuMzgzNjk1XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFtGVyBWRVJTSU9O XSAxLjMuMCwgQnVpbGQ6IE1heSAzMSAyMDIyLCAwODoyMiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6MjIgKCksIElE OiAweDMxNDU0NjUwDQpbICAgIDUuMzg0MDE1XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFNBRkVUWSBp bnN0YW5jZSBjcmVhdGVkDQozMm0gIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN5c3RlbSBJbml0aWFs aXphdGlvbiAgICA1LjM4NDAyNV0gcGZlbmcgNDYwMDAwMDAucGZlOiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2F0 Y2hkb2cgaW5zdGFuY2UgY3JlYXRlZA0KMG0uDQpbICAgIDUuMzg0MDM4XSBwZmVuZyA0NjAwMDAw MC5wZmU6IFVwbG9hZGluZyBVVElMIGZpcm13YXJlDQpbICAgIDUuMzg0MDQzXSBwZmVuZyA0NjAw MDAwMC5wZmU6IFNlbGVjdGVkIEZXIGxvYWRpbmcgT1BzIHRvIGxvYWQgMSBQRXMgaW4gcGFyYSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBsbGVsDQozMm0gIE9LICBdIFN0YXJ0ZWQgRGFpbHkgQ2xlYW51cCBvZiBUZW1w b3JhcnkgRGlyZWN0b3JpZXMuDQpbICAgIDUuMzk2ODM0XSBwZmVuZyA0NjAwMDAwMC5wZmU6IHBm ZV9jdC5oIGZpbGUgdmVyc2lvbiJlMWNiMzc2YjY3ZmE0ZDFkZTgwMGIxMyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAy YjMyOGI0MmMiDQpbICAgIDUuNDEwNDQ2XSBwZmVuZyA0NjAwMDAwMC5wZmU6IFZMQU4gSUQgaW5j b3JyZWN0IG9yIG5vdCBzZXQuIFVzaW5nIGRlZmF1bHQgViAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBMQU4gSUQgPSAw eDAxLg0KMzJtICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTeXN0ZW0gVGltZSBTZXQuDQpbICAgIDUu NDEwNDUyXSBwZmVuZyA0NjAwMDAwMC5wZmU6IFZMQU4gc3RhdHMgc2l6ZSBpbmNvcnJlY3Qgb3Ig bm90IHNldC4gVXNpbmcgZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZmF1bHQgVkxBTiBzdGF0cyBzaXplID0gMjAu DQpbICAgIDUuNDEwNTQ0XSBwZmVuZyA0NjAwMDAwMC5wZmU6IEZhbGwtYmFjayBicmlkZ2UgZG9t YWluIEAgMHgyMDAwMGEzNCAoY2xhc3MpDQpbICAgIDUuNDEwNTUxXSBwZmVuZyA0NjAwMDAwMC5w ZmU6IERlZmF1bHQgYnJpZGdlIGRvbWFpbiBAIDB4MjAwMDBhMmMgKGNsYXNzKQ0KWyAgICA1LjQx NjY4MF0gcGZlbmcgNDYwMDAwMDAucGZlOiBSb3V0aW5nIHRhYmxlIGNyZWF0ZWQsIEhhc2ggVGFi bGUgQCBwMHgzNDA4MDAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgMDAsIFBvb2wgQCBwMHgzNDA4ODAwMCAoNjU1MzYg Ynl0ZXMpDQpbICAgIDUuNDE2OTg5XSBwZmVuZyA0NjAwMDAwMC5wZmU6IEZlYXR1cmUgZXJyMDUx MjExX3dvcmthcm91bmQ6IERJU0FCTEVEDQozMm0gIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN5c3Rl bSBUaW1lIFN5bmNocm9uaXplZC4NClsgICAgNS40MTgzNjRdIHBmZW5nIDQ2MDAwMDAwLnBmZTog TURJTyBidXMgMCBkaXNhYmxlZDogTm90IGZvdW5kIGluIERUDQpbICAgIDUuNDE4MzcwXSBwZmVu ZyA0NjAwMDAwMC5wZmU6IE1ESU8gYnVzIDEgZGlzYWJsZWQ6IE5vIEVNQUMNClsgICAgNS40MTgz NzRdIHBmZW5nIDQ2MDAwMDAwLnBmZTogTURJTyBidXMgMiBkaXNhYmxlZDogTm8gRU1BQw0KMzJt ICBPSyAgXSBTdGFydGVkIERhaWx5IHJvdGF0aW9uIG9mIGxvZyBmaWxlcy4NClsgICAgNS40MTg3 MDVdIHBmZW5nIDQ2MDAwMDAwLnBmZTogSElGMCBlbmFibGVkDQpbICAgIDUuNDE4OTY3XSBwZmVu ZyA0NjAwMDAwMC5wZmU6IEhJRjEgZW5hYmxlZA0KWyAgICA1LjQxOTIyOV0gcGZlbmcgNDYwMDAw MDAucGZlOiBISUYyIGVuYWJsZWQNClsgICAgNS40MTkyMzVdIHBmZW5nIDQ2MDAwMDAwLnBmZTog SElGMyBub3QgY29uZmlndXJlZCwgc2tpcHBlZA0KMzJtICBPSyAgXSBSZWFjaGVkIHRhcmdldCBU aW1lcnMuDQpbICAgIDUuNDI0NDcxXSBwZmVuZyA0NjAwMDAwMC5wZmUgcGZlMDogcmVnaXN0ZXJl ZA0KWyAgICA1LjQyNDQ5Nl0gcGZlbmcgNDYwMDAwMDAucGZlIHBmZTA6IFN1YnNjcmliZSB0byBI SUYwDQozMm0gIE9LICBdIExpc3RlbmluZyBvbiBELUJ1cyBTeXN0ZW0gTWVzc2FnZSBCdXNbICAg IDUuNDI1MDQ0XSBwZmVuZyA0NjAwMDAwMC5wZiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlIHBmZTA6IEVuYWJsZSBI SUYwDQogU29ja2V0Lg0KWyAgICA1LjQyNTIwN10gcGZlbmcgNDYwMDAwMDAucGZlIHBmZTA6IHNl dHRpbmcgTUFDIGFkZHI6IDAwOjAxOmJlOmJlOmVmOjExDQogICAgIFsgICAgNS40MjUyMzRdIHBm ZW5nIDQ2MDAwMDAwLnBmZSBwZmUwOiBQVFAgSFcgYWRkZW5kIDB4ODAwMDAwMDAsIG1heF9hZGog YyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBvbmZpZ3VyZWQgdG8gNDY1NjYxMjggcHBiDQogICAgU3RhcnRpbmcgc3No ZC5zb2NrZXQuDQpbICAgIDUuNDI1MjQzXSBwZmVuZyA0NjAwMDAwMC5wZmU6IElFRUUxNTg4OiBJ bnB1dCBDbG9jazogMjAwMDAwMDAwSHosIE91dHB1dDogMSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwMDAwMDAwMEh6 LCBBY2N1cmFjeTogMTAuMG5zDQpbICAgIDUuNDMxMTE1XSBwZmVuZyA0NjAwMDAwMC5wZmUgcGZl MDogUmVnaXN0ZXJlZCBQVFAgSFcgY2xvY2sgc3VjY2Vzc2Z1bGx5IG9uICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBF TUFDMA0KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIHNzaGQuc29ja2V0Lg0KWyAgT0sgIF0gUmVhY2hl ZCB0YXJnZXQgU29ja2V0cy4NClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEJhc2ljIFN5c3RlbS4N ClsgIE9LICBdIFN0YXJ0ZWQgSm9iIHNwb29saW5nIHRvb2xzLg0KWyAgT0sgIF0gU3RhcnRlZCBQ ZXJpb2RpYyBDb21tYW5kIFNjaGVkdWxlci4NClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVt IE1lc3NhZ2UgQnVzLg0KWyAgT0sgIF0gU3RhcnRlZCBBIG1pbmltYWxpc3RpYyBuZXTigKZQdjQs IHJkaXNjIGFuZCBESENQdjYgc3VwcG9ydC4NCiAgICAgICAgIFN0YXJ0aW5nIElQdjYgUGFja2V0 IEZpbHRlcmluZyBGcmFtZXdvcmsuLi4NCiAgICAgICAgIFN0YXJ0aW5nIElQdjQgUGFja2V0IEZp bHRlcmluZyBGcmFtZXdvcmsuLi4NClsgIE9LICBdIFN0YXJ0ZWQgaXJxYmFsYW5jZSBkYWVtb24u DQpbICBPSyAgXSBTdGFydGVkIEhhcmR3YXJlIFJORyBFbnRyb3B5IEdhdGhlcmVyIERhZW1vbi4N ClsgIE9LICBdIFN0YXJ0ZWQgc3Ryb25nU3dhbiBJUHNlYyBJ4oCmSUtFdjIgZGFlbW9uIHVzaW5n IGlwc2VjLmNvbmYuDQpbICAgIDYuNjI1MDg2XSByYW5kb206IGNybmcgaW5pdCBkb25lDQpbICAg IDYuNjI1MTAxXSByYW5kb206IDcgdXJhbmRvbSB3YXJuaW5nKHMpIG1pc3NlZCBkdWUgdG8gcmF0 ZWxpbWl0aW5nDQpbICBPSyAgXSBTdGFydGVkIFN5c3RlbSBMb2dnaW5nIFNlcnZpY2UuDQogICAg ICAgICBTdGFydGluZyBVc2VyIExvZ2luIE1hbmFnZW1lbnQuLi4NCiAgICAgICAgIFN0YXJ0aW5n IFRoZSBYZW4geGVuc3RvcmUuLi4NCiAgICAgICAgIFN0YXJ0aW5nIE9wZW5TU0ggS2V5IEdlbmVy YXRpb24uLi4NClsgIE9LICBdIEZpbmlzaGVkIExvYWQvU2F2ZSBSYW5kb20gU2VlZC4NClsgIE9L ICBdIEZpbmlzaGVkIElQdjYgUGFja2V0IEZpbHRlcmluZyBGcmFtZXdvcmsuDQpbICBPSyAgXSBG aW5pc2hlZCBJUHY0IFBhY2tldCBGaWx0ZXJpbmcgRnJhbWV3b3JrLg0KWyAgT0sgIF0gUmVhY2hl ZCB0YXJnZXQgTmV0d29yayAoUHJlKS4NCiAgICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgU2Vydmlj ZS4uLg0KW0ZBSUxFRF0gRmFpbGVkIHRvIHN0YXJ0IFRoZSBYZW4geGVuc3RvcmUuDQpTZWUgJ3N5 c3RlbWN0bCBzdGF0dXMgeGVuc3RvcmVkLnNlcnZpY2UnIGZvciBkZXRhaWxzLg0KW0RFUEVORF0g RGVwZW5kZW5jeSBmYWlsZWQgZm9yIHhlbi3igKZkZXMsIEpTT04gY29uZmlndXJhdGlvbiBzdHVi KS4NCltERVBFTkRdIERlcGVuZGVuY3kgZmFpbGVkIGZvciBYZW5j4oCmZ3Vlc3QgY29uc29sZXMg YW5kIGh5cGVydmlzb3IuDQpbREVQRU5EXSBEZXBlbmRlbmN5IGZhaWxlZCBmb3IgWGVuZOKApnAg Z3Vlc3RzIG9uIGJvb3QgYW5kIHNodXRkb3duLg0KW0RFUEVORF0gRGVwZW5kZW5jeSBmYWlsZWQg Zm9yIHFlbXUgZm9yIHhlbiBkb20wIGRpc2sgYmFja2VuZC4NClsgIE9LICBdIFN0YXJ0ZWQgTmV0 d29yayBTZXJ2aWNlLg0KWyAgT0sgIF0gRmluaXNoZWQgT3BlblNTSCBLZXkgR2VuZXJhdGlvbi4N ClsgIE9LICBdIFN0YXJ0ZWQgVXNlciBMb2dpbiBNYW5hZ2VtZW50Lg0KICAgICAgICAgU3RhcnRp bmcgTmV0d29yayBOYW1lIFJlc29sdXRpb24uLi4NCiAgICAgICAgIFN0YXJ0aW5nIFhlbi13YXRj aGRvZyAtIHJ1biB4ZW4gd2F0Y2hkb2cgZGFlbW9uLi4uDQpbICBPSyAgXSBTdGFydGVkIFhlbi13 YXRjaGRvZyAtIHJ1biB4ZW4gd2F0Y2hkb2cgZGFlbW9uLg0KWyAgT0sgIF0gU3RhcnRlZCBOZXR3 b3JrIE5hbWUgUmVzb2x1dGlvbi4NClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IE5ldHdvcmsuDQpb ICBPSyAgXSBSZWFjaGVkIHRhcmdldCBIb3N0IGFuZCBOZXR3b3JrIE5hbWUgTG9va3Vwcy4NClsg IE9LICBdIFN0YXJ0ZWQgTkZTIHN0YXR1cyBtb25pdG9yIGZvciBORlN2Mi8zIGxvY2tpbmcuLg0K WyAgT0sgIF0gU3RhcnRlZCBSZXNwb25kIHRvIElQdjYgTm9kZSBJbmZvcm1hdGlvbiBRdWVyaWVz Lg0KWyAgT0sgIF0gU3RhcnRlZCBOZXR3b3JrIFJvdXRlciBEaXNjb3ZlcnkgRGFlbW9uLg0KICAg ICAgICAgU3RhcnRpbmcgUGVybWl0IFVzZXIgU2Vzc2lvbnMuLi4NClsgIE9LICBdIFN0YXJ0ZWQg WGluZXRkIEEgUG93ZXJmdWwgUmVwbGFjZW1lbnQgRm9yIEluZXRkLg0KWyAgT0sgIF0gRmluaXNo ZWQgUGVybWl0IFVzZXIgU2Vzc2lvbnMuDQpbICBPSyAgXSBTdGFydGVkIEdldHR5IG9uIHR0eTEu DQpbICBPSyAgXSBTdGFydGVkIFNlcmlhbCBHZXR0eSBvbiBodmMwLg0KWyAgT0sgIF0gU3RhcnRl ZCBTZXJpYWwgR2V0dHkgb24gdHR5TEYwLg0KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTG9naW4g UHJvbXB0cy4NClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IE11bHRpLVVzZXIgU3lzdGVtLg0KICAg ICAgICAgU3RhcnRpbmcgVXBkYXRlIFVUTVAgYWJvdXQgU3lzdGVtIFJ1bmxldmVsIENoYW5nZXMu Li4NClsgIE9LICBdIEZpbmlzaGVkIFVwZGF0ZSBVVE1QIGFib3V0IFN5c3RlbSBSdW5sZXZlbCBD aGFuZ2VzLg0KDQozMy5BdXRvIExpbnV4IHZiMyAzdC5MRnMzMmczOTlhZXZiMyBodmMwDQoNCg0K PlNvbWUgZXh0cmEgaW5mb3JtYXRpb24gYWJvdXQgeGVuc3RvcmU6DQoNCnJvb3RAczMyZzM5OWFl dmIzOn4jIHN5c3RlbWN0bCBzdGF0dXMgeGVuc3RvcmVkLnNlcnZpY2UNCiogeGVuc3RvcmVkLnNl cnZpY2UgLSBUaGUgWGVuIHhlbnN0b3JlDQogICAgIExvYWRlZDogbG9hZGVkICgvbGliL3N5c3Rl bWQvc3lzdGVtL3hlbnN0b3JlZC5zZXJ2aWNlOyBlbmFibGVkOyB2ZW5kb3IgcHJlPg0KICAgICBB Y3RpdmU6IGZhaWxlZCAoUmVzdWx0OiBwcm90b2NvbCkgc2luY2UgV2VkIDIwMjAtMTItMTYgMTc6 MjU6MjAgVVRDOyA2bWluID4NCiAgICBQcm9jZXNzOiAxODIgRXhlY1N0YXJ0UHJlPS9iaW4vZ3Jl cCAtcSBjb250cm9sX2QgL3Byb2MveGVuL2NhcGFiaWxpdGllcyAoY28+DQogICAgUHJvY2Vzczog MTg2IEV4ZWNTdGFydD0vZXRjL3hlbi9zY3JpcHRzL2xhdW5jaC14ZW5zdG9yZSAoY29kZT1leGl0 ZWQsIHN0YXR1Pg0KICAgTWFpbiBQSUQ6IDE4NiAoY29kZT1leGl0ZWQsIHN0YXR1cz0wL1NVQ0NF U1MpDQoNCkRlYyAxNiAxNzoyNToyMCBzMzJnMzk5YWV2YjMgc3lzdGVtZFsxXTogU3RhcnRpbmcg VGhlIFhlbiB4ZW5zdG9yZS4uLg0KRGVjIDE2IDE3OjI1OjIwIHMzMmczOTlhZXZiMyBsYXVuY2gt eGVuc3RvcmVbMTg2XTogU3RhcnRpbmcgL3Vzci9zYmluL3hlbnN0b3JlZD4NCkRlYyAxNiAxNzoy NToyMCBzMzJnMzk5YWV2YjMgbGF1bmNoLXhlbnN0b3JlWzE5M106IEZBVEFMOiBGYWlsZWQgdG8g b3BlbiBjb25uZWM+DQpEZWMgMTYgMTc6MjU6MjAgczMyZzM5OWFldmIzIHN5c3RlbWRbMV06IHhl bnN0b3JlZC5zZXJ2aWNlOiBGYWlsZWQgd2l0aCByZXN1bHQgPg0KRGVjIDE2IDE3OjI1OjIwIHMz MmczOTlhZXZiMyBzeXN0ZW1kWzFdOiBGYWlsZWQgdG8gc3RhcnQgVGhlIFhlbiB4ZW5zdG9yZS4N Cg0KDQo+QW55IGlkZWEgb2YgaG93IGNhbiBJIGZpeCB0aGF0PyBUaGFuayB5b3Ugc28gbXVjaCBm b3IgdGhlIHN1cHBvcnQNCg0KQmVzdCByZWdhcmRzDQpZb3Vzc2VmIEVsIE1lc2RhZGkNCg0KDQoN Ci0tLS0tVXJzcHLDvG5nbGljaGUgTmFjaHJpY2h0LS0tLS0NClZvbjogSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gDQpHZXNlbmRldDogRGllbnN0YWcsIDE3LiBKYW51YXIgMjAyMyAxNToz OA0KQW46IEVsIE1lc2RhZGkgWW91c3NlZiBFU0sgVUlMRDcgPHlvdXNzZWYuZWxtZXNkYWRpQHpm LmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KQ2M6IFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCkJldHJlZmY6IFJlOiBBVzogWGVuYWx5emUg b24gQVJNICggTlhQIFMzMkczIHdpdGggQ29ydGV4LUE1MykNCg0KDQoNCk9uIDEzLzAxLzIwMjMg MTI6NTYsIEVsIE1lc2RhZGkgWW91c3NlZiBFU0sgVUlMRDcgd3JvdGU6DQo+IEhlbGxvIEp1bGll biwNCg0KSGksDQoNCj4+Pj4geGVudHJhY2Ugc2hvdWxkIHdvcmsgb24gdXBzdHJlYW0gWGVuLiBX aGF0IGRpZCB5b3UgdmVyc2lvbiBkaWQgeW91IHRyeT8NCj4gDQo+IFdoaWxlIGJ1aWxkaW5nIG15 IGltYWdlIHVzaW5nIHRoZSBCU1AtbGludXggb2YgTlhQLCB0aGUgdmVyc2lvbiB0aGF0IHdhcyBk b3dubG9hZGVkIGlzIFhlbiA0LjE0Lg0KDQpEbyB5b3Uga25vdyB3aGVyZSB0aGUgc291cmNlIGFy ZSBkb3dubG9hZGVkIGZyb20/DQoNCj4gDQo+IA0KPj4+PiBDYW4geW91IGFsc28gY2xhcmlmeSB0 aGUgZXJyb3IgeW91IGFyZSBzZWVuPw0KPiANCj4gVGhlIGVycm9yIEkgcmVjZWl2ZSB3aGlsZSB0 aXBwaW5nIHhlbnRyYWNlIGlzOiBDb21tYW5kIG5vdCBmb3VuZC4NCg0KDQoiQ29tbWFuZCBub3Qg Zm91bmQiIG1lYW5zIHRoZSBwcm9ncmFtIGhhc24ndCBiZWVuIGluc3RhbGxlZC4NCg0KPiBJIGFz c3VtZSBpbiB0aGlzIFhlbiB2ZXJzaW9uLCBYZW50cmFjZSBpcyBub3QgY29tcGF0aWJsZSB3aXRo IEFSTSANCj4gYXJjaGl0ZWN0dXJlDQpUaGUgc3VwcG9ydCBmb3IgeGVudHJhY2Ugb24gQXJtIGhh cyBiZWVuIGFkZGVkIGFyb3VuZCBYZW4gNC4xMi4gU28gaXQgc2hvdWxkIHdvcmsgZm9yIFhlbiA0 LjE0IChldmVuIHRob3VnaCBJIGRvbid0IHJlY29tbWVuZCB1c2luZyBvbGRlciByZWxlYXNlKS4N Cg0KSSB3b3VsZCBzdWdnZXN0IHRvIGNoZWNrIGhvdyB5b3UgYXJlIGJ1aWxkaW5nIHRoZSB0b29s cyBhbmQgd2hpY2ggcGFja2FnZSB3aWxsIGJlIGluc3RhbGxlZC4NCg0KPiANCj4gTXkgcXVlc3Rp b24gaXMsIGlzIHRoZXJlIGFueSBuZXcgdmVyc2lvbiBvZiBYZW4gdGhhdCBzdXBwb3J0cyBYZW50 cmFjZSBvbiBBUk0/IElmIHllcyBob3cgY291bGQgSSBpbnN0YWxsIGl0PyBCZWNhdXNlIFhlbi40 LjE0IHdhcyBpbnN0YWxsZWQgYXV0b21hdGljYWxseSBieSB0eXBpbmcgdGhpcyAoIERJU1RST19G RUFUVVJFU19hcHBlbmQgKz0gInhlbiIpIGluIHRoZSBsb2NhbC5jb25mIGZpbGUgd2hpbGUgY3Jl YXRpbmcgbXkgaW1hZ2UuDQoNCkkgYW0gbm90IGZhbWlsaWFyIHdpdGggdGhlIEJTUC1saW51eCBv ZiBOWFAgYXMgdGhpcyBpcyBub3QgYSBwcm9qZWN0IG1haW50YWluZWQgYnkgWGVuIFByb2plY3Qu DQoNCklmIHlvdSBuZWVkIHN1cHBvcnQgZm9yIGl0LCB0aGVuIEkgd291bGQgc3VnZ2VzdCB0byBk aXNjdXNzIHdpdGggTlhQIGRpcmVjdGx5Lg0KDQo+IA0KPiBPciBpcyB0aGVyZSBhbnkgc291cmNl IG9uIFhlbnRyYWNlIHRoYXQgaXMgY29tcGF0aWJsZSB3aXRoIEFSTSBvbiBHaXRIdWIsIHRoYXQg SSBjb3VsZCBkb3dubG9hZCBhbmQgY29tcGlsZSBteXNlbGY/DQpFdmVuIGlmIHRoZSBoeXBlcnZp c29yIGlzIFhlbiwgeW91IHNlZW0gdG8gdXNlIGNvZGUgcHJvdmlkZWQgYnkgYW4gZXh0ZXJuYWwg ZW50aXR5LiBJIGNhbid0IGFkdmlzZSBvbiB0aGUgbmV4dCBzdGVwcyB3aXRob3V0IGtub3dpbmcg dGhlIG1vZGlmaWNhdGlvbiB0aGF0IE5YUCBtYWRlIGluIHRoZSBoeXBlcnZpc29yLg0KDQo+IA0K Pj4+PiBZZXMgaWYgeW91IGFzc2lnbiAob3IgcHJvdmlkZSBwYXJhLXZpcnR1YWxpemVkIGRyaXZl cikgdGhlIEdQSU8vTEVEL0Nhbi1JbnRlcmZhY2UgdG8gdGhlIGd1ZXN0Lg0KPiANCj4gSXMgdGhl cmUgYW55IHR1dG9yaWFsIHRoYXQgY291bGQgaGVscCBtZSBjcmVhdGUgdGhvc2UgZHJpdmVycz8g QW5kIGhvdyBjb21wbGljYXRlZCBpcyB0aGF0LCB0byBjcmVhdGUgdGhlbT8NCg0KSSBhbSBub3Qg YXdhcmUgb2YgYW55IHR1dG9yaWFsLiBSZWdhcmRpbmcgdGhlIGNvbXBsZXhpdHksIGl0IGFsbCBk ZXBlbmRzIG9uIHdoYXQgZXhhY3RseSB5b3Ugd2FudCB0byBkby4NCg0KPiBPciBjYW4gdGhleSBi ZSBhc3NpZ25lZCBqdXN0IHdpdGggUENJLVBhc3N0aHJvdWdoPw0KDQpQQ0kgcGFzc3Rocm91Z2gg aXMgbm90IHlldCBzdXBwb3J0ZWQgb24gQXJtLiBUaGF0IHNhaWQsIEkgd2FzIG5vdCBleHBlY3Rp bmcgdGhlIEdQSU8vTEVEL0Nhbi1pbnRlcmZhY2UgdG8gYmUgUENJIGRldmljZXMuDQoNCklmIHRo ZXkgYXJlIHBsYXRmb3JtIGRldmljZXMgKGkuZSBub24tUENJIGRldmljZXMpLCB0aGVuIHlvdSBj b3VsZCBwb3RlbnRpYWxseSBkaXJlY3RseSBhc3NpZ24gdGhlbSB0byAqb25lKiBndWVzdCAodGhp cyB3b3VsZCBub3Qgd29yayBpZiB5b3UgbmVlZCB0byBzaGFyZSB0aGVtKS4NCg0KSSB3cm90ZSBw b3RlbnRpYWxseSBiZWNhdXNlIGlmIHRoZSBkZXZpY2UgaXMgRE1BLWNhcGFiYWJsZSwgdGhlbiB0 aGUgZGV2aWNlIG11c3QgYmUgYmVoaW5kIGFuIElPTU1VLg0KDQpDaGVlcnMsDQoNCi0tDQpKdWxp ZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Tue Feb 07 09:44:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 09:44:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490966.759879 (Exim 4.92) (envelope-from ) id 1pPKWC-0000iT-Qw; Tue, 07 Feb 2023 09:44:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490966.759879; Tue, 07 Feb 2023 09:44:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKWC-0000iM-N5; Tue, 07 Feb 2023 09:44:04 +0000 Received: by outflank-mailman (input) for mailman id 490966; Tue, 07 Feb 2023 09:44:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKWA-0000iE-N0 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 09:44:02 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f26e712e-a6cb-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 10:43:59 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id eq11so14636088edb.6 for ; Tue, 07 Feb 2023 01:43:59 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.226.tellas.gr. [109.242.226.89]) by smtp.googlemail.com with ESMTPSA id es26-20020a056402381a00b00488117821ffsm6193880edb.31.2023.02.07.01.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 01:43:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f26e712e-a6cb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3oDDsC41sLF+atuCMTLto1TqTReol5tcMlO6ePzFZbY=; b=iqtCiOzMXZD3dsv3XJYGyp1ngC/kiRrsR2sHW//eEEL7wCJElqngwxI4Xa18/1Y1Yt NLnQ9RHMvAXzd2okecxJWIfvAxUOFSH3ddHWpGJ/YAO2vbUH2yGLSvzY3xM1NJgTdvqQ ZCpjvKvypQtzD+pc7s0lJxVNDqB0s/cxLEDDvkugnCBxKEMM+SQ/ioBpqNox1D/CzgQO feiz3J1tLu2kIcarA9HpwC3ZRpUqYeNcd/5OPJCyo94XjCcP3MP4nbqBC4Bt2kSEz+ul 7CET6WMEEuMdMvR2/FNimotTdpg/hgOOKANDLo8RglPzG1TLxZi/H2nz4mGbu2E4qt4g YfYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3oDDsC41sLF+atuCMTLto1TqTReol5tcMlO6ePzFZbY=; b=chSvpbMlSbdzfnjhnM2xLDg2XDf/MYUC6gjJhB+8fpni7eEr5A/a8mF1aBJ8c3/yG+ m/OC0FQ6vt8DDNHKFNlNZKGE94AnBl0l0/3tu9vLKl0twnGKN89nnE8B0CJvefLQ7yw4 llk38tFnTOXX/TwfW8qQDQnk24Nh8CjSjHky/xjg2kjCAfj3cTu2C3iBSJZskteJCXkm aYxttMD9J8Ve8anx5IcKDYlQOD1GETbrLdmCE5HjkTLCJ+Nqnny//bsQcbl5sawix8AT adQDcn8fhv1sWK0Sb7/JlPczyFTqK2z/lGqCSBumOrq7TLaT/fcV7NFFydbrX5x33bJI KoTw== X-Gm-Message-State: AO0yUKUWVacPVuVQl3AB5Hjywc9M0YxL0mYV3yno0fjxXSj1AYNFrH/u 1Du3rBzwjkXrjUtT4iovHP6w1qgwoOc= X-Google-Smtp-Source: AK7set+99kLyLrbIod12hxN1P7gPbKejSBK/XshU+Jnqw2rWu/Hz0edkV49zsX/b8aqKJh/PCbNFqA== X-Received: by 2002:a50:a415:0:b0:4aa:a53f:a041 with SMTP id u21-20020a50a415000000b004aaa53fa041mr2749916edb.34.1675763038399; Tue, 07 Feb 2023 01:43:58 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Date: Tue, 7 Feb 2023 11:43:47 +0200 Message-Id: <20230207094347.1059376-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APIC virtualization support is currently implemented only for Intel VT-x. To aid future work on separating AMD-V from Intel VT-x code, instead of calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub to the hvm_function_table, named update_vlapic_mode, and create a wrapper function, called hvm_update_vlapic_mode(), to be used by common hvm code. After the change above, do not include header asm/hvm/vmx/vmx.h as it is not required anymore and resolve subsequent build errors for implicit declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including missing asm/hvm/trace.h header. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - rename set_virtual_apic_mode to update_vlapic_mode, suggested by Andrew - in hvm_update_vlapic_mode(), call the stub only if available, otherwise a BUG() will be triggered every time an svm guest writes the APIC_BASE MSR, bug reported by Andrew - initialize the stub for vmx unconditionally to maintain current behavior since no functional change is intended, bug reported by Andrew (here, I decided to place the initialization in start_vmx to be closer to the initializations of the other stubs that are relevant to apic virtualization) xen/arch/x86/hvm/vlapic.c | 6 +++--- xen/arch/x86/hvm/vmx/vmx.c | 2 ++ xen/arch/x86/include/asm/hvm/hvm.h | 7 +++++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d..dc93b5e930 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -37,8 +37,8 @@ #include #include #include -#include #include +#include #include #include #include @@ -1165,7 +1165,7 @@ int guest_wrmsr_apic_base(struct vcpu *v, uint64_t value) if ( vlapic_x2apic_mode(vlapic) ) set_x2apic_id(vlapic); - vmx_vlapic_msr_changed(vlapic_vcpu(vlapic)); + hvm_update_vlapic_mode(vlapic_vcpu(vlapic)); HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "apic base msr is 0x%016"PRIx64, vlapic->hw.apic_base_msr); @@ -1561,7 +1561,7 @@ static int cf_check lapic_load_hidden(struct domain *d, hvm_domain_context_t *h) unlikely(vlapic_x2apic_mode(s)) ) return -EINVAL; - vmx_vlapic_msr_changed(v); + hvm_update_vlapic_mode(v); return 0; } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 270bc98195..dd57aa7623 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3011,6 +3011,8 @@ const struct hvm_function_table * __init start_vmx(void) setup_ept_dump(); } + vmx_function_table.update_vlapic_mode = vmx_vlapic_msr_changed; + if ( cpu_has_vmx_virtual_intr_delivery ) { vmx_function_table.update_eoi_exit_bitmap = vmx_update_eoi_exit_bitmap; diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 80e4565bd2..43d3fc2498 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -217,6 +217,7 @@ struct hvm_function_table { void (*handle_eoi)(uint8_t vector, int isr); int (*pi_update_irte)(const struct vcpu *v, const struct pirq *pirq, uint8_t gvec); + void (*update_vlapic_mode)(struct vcpu *v); /*Walk nested p2m */ int (*nhvm_hap_walk_L1_p2m)(struct vcpu *v, paddr_t L2_gpa, @@ -786,6 +787,12 @@ static inline int hvm_pi_update_irte(const struct vcpu *v, return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); } +static inline void hvm_update_vlapic_mode(struct vcpu *v) +{ + if ( hvm_funcs.update_vlapic_mode ) + alternative_vcall(hvm_funcs.update_vlapic_mode, v); +} + #else /* CONFIG_HVM */ #define hvm_enabled false -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:13:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:13:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490974.759889 (Exim 4.92) (envelope-from ) id 1pPKyr-0004Pm-5E; Tue, 07 Feb 2023 10:13:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490974.759889; Tue, 07 Feb 2023 10:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKyr-0004Pf-2a; Tue, 07 Feb 2023 10:13:41 +0000 Received: by outflank-mailman (input) for mailman id 490974; Tue, 07 Feb 2023 10:13:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPKyp-0004PJ-6x for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 10:13:39 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 14e8b3ed-a6d0-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 11:13:36 +0100 (CET) Received: from [2001:8b0:10b:5::bb3] (helo=u3832b3a9db3152.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKyf-0003XM-8j; Tue, 07 Feb 2023 10:13:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14e8b3ed-a6d0-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eG3f7Wrpn6kr4QybJUcA38LkC2ORxSzToIuDbPU0wTE=; b=RRIAiIlP1VWkuaCHd5DtE+gSln p5WFxrUMwUvaVkOvQ+MqpoeA6DDFxSHozKTBlFE47AShOR8tt/9MDff5h1oIwWmZBuzXEkVSAdZPV Bg9QLo1IyywosSbV9jZNyBbPu9n7uq8wsuVHqD1ZZpVXAClxoJohIZgUXo3hEdljVNrIGwcSPru1w QvpeCBUHihpJYuHOOZvzt+wPU7lCFxfrLXIvEgmbngv/pd5opxAg7HK9zNYUSZEbH2KK3KUvfc4yG M6eLONGJgQ2fRuXh657kn+Oi4GusHYsJjK1Q4IfD0hf+RPZzGbgIFduDMi4Linpt+Qkoq+JO7AZJR L94v6jCA==; Message-ID: <84ded117ebc6e8c72f4120df00d357a275da9eaf.camel@infradead.org> Subject: Re: [QEMU][PATCH v5 00/10] Introduce xenpvh machine for arm architecture From: David Woodhouse To: Vikram Garhwal , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, alex.bennee@linaro.org Date: Tue, 07 Feb 2023 10:13:28 +0000 In-Reply-To: <20230131225149.14764-1-vikram.garhwal@amd.com> References: <20230131225149.14764-1-vikram.garhwal@amd.com> Content-Type: multipart/signed; micalg="sha-256"; protocol="application/pkcs7-signature"; boundary="=-qo71SzSGkn58Swa6P6Dk" User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html --=-qo71SzSGkn58Swa6P6Dk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2023-01-31 at 14:51 -0800, Vikram Garhwal wrote: >=20 > Hi, > This series add xenpvh machine for aarch64. Motivation behind creating xe= npvh > machine with IOREQ and TPM was to enable each guest on Xen aarch64 to hav= e it's > own unique and emulated TPM. >=20 > This series does following: > =C2=A0=C2=A0=C2=A0 1. Moved common xen functionalities from hw/i386/xen t= o hw/xen/ so those can > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 be used for aarch64. > =C2=A0=C2=A0=C2=A0 2. We added a minimal xenpvh arm machine which creates= an IOREQ server and > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 support TPM. >=20 > Also, checkpatch.pl fails for 03/12 and 06/12. These fails are due to > moving old code to new place which was not QEMU code style compatible. > No new add code was added. Is there a git tree for this, please? I'd like to check for conflicts with the Xen-on-KVM emulation support which I'm also hoping to get in for 8.0. --=-qo71SzSGkn58Swa6P6Dk Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCEkQw ggYQMIID+KADAgECAhBNlCwQ1DvglAnFgS06KwZPMA0GCSqGSIb3DQEBDAUAMIGIMQswCQYDVQQG EwJVUzETMBEGA1UECBMKTmV3IEplcnNleTEUMBIGA1UEBxMLSmVyc2V5IENpdHkxHjAcBgNVBAoT FVRoZSBVU0VSVFJVU1QgTmV0d29yazEuMCwGA1UEAxMlVVNFUlRydXN0IFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xODExMDIwMDAwMDBaFw0zMDEyMzEyMzU5NTlaMIGWMQswCQYDVQQG EwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYD VQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50 aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEAyjztlApB/975Rrno1jvm2pK/KxBOqhq8gr2+JhwpKirSzZxQgT9tlC7zl6hn1fXjSo5MqXUf ItMltrMaXqcESJuK8dtK56NCSrq4iDKaKq9NxOXFmqXX2zN8HHGjQ2b2Xv0v1L5Nk1MQPKA19xeW QcpGEGFUUd0kN+oHox+L9aV1rjfNiCj3bJk6kJaOPabPi2503nn/ITX5e8WfPnGw4VuZ79Khj1YB rf24k5Ee1sLTHsLtpiK9OjG4iQRBdq6Z/TlVx/hGAez5h36bBJMxqdHLpdwIUkTqT8se3ed0PewD ch/8kHPo5fZl5u1B0ecpq/sDN/5sCG52Ds+QU5O5EwIDAQABo4IBZDCCAWAwHwYDVR0jBBgwFoAU U3m/WqorSs9UgOHYm8Cd8rIDZsswHQYDVR0OBBYEFAnA8vwL2pTbX/4r36iZQs/J4K0AMA4GA1Ud DwEB/wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEF BQcDBDARBgNVHSAECjAIMAYGBFUdIAAwUAYDVR0fBEkwRzBFoEOgQYY/aHR0cDovL2NybC51c2Vy dHJ1c3QuY29tL1VTRVJUcnVzdFJTQUNlcnRpZmljYXRpb25BdXRob3JpdHkuY3JsMHYGCCsGAQUF BwEBBGowaDA/BggrBgEFBQcwAoYzaHR0cDovL2NydC51c2VydHJ1c3QuY29tL1VTRVJUcnVzdFJT QUFkZFRydXN0Q0EuY3J0MCUGCCsGAQUFBzABhhlodHRwOi8vb2NzcC51c2VydHJ1c3QuY29tMA0G CSqGSIb3DQEBDAUAA4ICAQBBRHUAqznCFfXejpVtMnFojADdF9d6HBA4kMjjsb0XMZHztuOCtKF+ xswhh2GqkW5JQrM8zVlU+A2VP72Ky2nlRA1GwmIPgou74TZ/XTarHG8zdMSgaDrkVYzz1g3nIVO9 IHk96VwsacIvBF8JfqIs+8aWH2PfSUrNxP6Ys7U0sZYx4rXD6+cqFq/ZW5BUfClN/rhk2ddQXyn7 kkmka2RQb9d90nmNHdgKrwfQ49mQ2hWQNDkJJIXwKjYA6VUR/fZUFeCUisdDe/0ABLTI+jheXUV1 eoYV7lNwNBKpeHdNuO6Aacb533JlfeUHxvBz9OfYWUiXu09sMAviM11Q0DuMZ5760CdO2VnpsXP4 KxaYIhvqPqUMWqRdWyn7crItNkZeroXaecG03i3mM7dkiPaCkgocBg0EBYsbZDZ8bsG3a08LwEsL 1Ygz3SBsyECa0waq4hOf/Z85F2w2ZpXfP+w8q4ifwO90SGZZV+HR/Jh6rEaVPDRF/CEGVqR1hiuQ OZ1YL5ezMTX0ZSLwrymUE0pwi/KDaiYB15uswgeIAcA6JzPFf9pLkAFFWs1QNyN++niFhsM47qod x/PL+5jR87myx5uYdBEQkkDc+lKB1Wct6ucXqm2EmsaQ0M95QjTmy+rDWjkDYdw3Ms6mSWE3Bn7i 5ZgtwCLXgAIe5W8mybM2JzCCBhQwggT8oAMCAQICEQDGvhmWZ0DEAx0oURL6O6l+MA0GCSqGSIb3 DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVyMRAwDgYD VQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNlY3RpZ28g UlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBMB4XDTIyMDEwNzAw MDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJARYTZHdtdzJAaW5mcmFkZWFkLm9y ZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3GpC2bomUqk+91wLYBzDMcCj5C9m6 oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZHh7htyAkWYVoFsFPrwHounto8xTsy SSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT9YgcBqKCo65pTFmOnR/VVbjJk4K2 xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNjP+qDrh0db7PAjO1D4d5ftfrsf+kd RR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy2U+eITZ5LLE5s45mX2oPFknWqxBo bQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3BgBEmfsYWlBXO8rVXfvPgLs32VdV NZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/7auNVRmPB3v5SWEsH8xi4Bez2V9U KxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmdlFYhAflWKQ03Ufiu8t3iBE3VJbc2 5oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9aelIl6vtbhMA+l0nfrsORMa4kobqQ5 C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMBAAGjggHMMIIByDAfBgNVHSMEGDAW gBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeDMcimo0oz8o1R1Nver3ZVpSkwDgYD VR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMC MEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGln by5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9jcmwuc2VjdGlnby5jb20vU2VjdGln b1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEB BH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50 QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j c3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5mcmFkZWFkLm9yZzANBgkqhkiG9w0B AQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQvQ/fzPXmtR9t54rpmI2TfyvcKgOXp qa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvIlSPrzIB4Z2wyIGQpaPLlYflrrVFK v9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9ChWFfgSXvrWDZspnU3Gjw/rMHrGnql Htlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0whpBtXdyDjzBtQTaZJ7zTT/vlehc/ tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9IzCCBhQwggT8oAMCAQICEQDGvhmW Z0DEAx0oURL6O6l+MA0GCSqGSIb3DQEBCwUAMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3Jl YXRlciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0 ZWQxPjA8BgNVBAMTNVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJl IEVtYWlsIENBMB4XDTIyMDEwNzAwMDAwMFoXDTI1MDEwNjIzNTk1OVowJDEiMCAGCSqGSIb3DQEJ ARYTZHdtdzJAaW5mcmFkZWFkLm9yZzCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBALQ3 GpC2bomUqk+91wLYBzDMcCj5C9m6oZaHwvmIdXftOgTbCJXADo6G9T7BBAebw2JV38EINgKpy/ZH h7htyAkWYVoFsFPrwHounto8xTsySSePMiPlmIdQ10BcVSXMUJ3Juu16GlWOnAMJY2oYfEzmE7uT 9YgcBqKCo65pTFmOnR/VVbjJk4K2xE34GC2nAdUQkPFuyaFisicc6HRMOYXPuF0DuwITEKnjxgNj P+qDrh0db7PAjO1D4d5ftfrsf+kdRR4gKVGSk8Tz2WwvtLAroJM4nXjNPIBJNT4w/FWWc/5qPHJy 2U+eITZ5LLE5s45mX2oPFknWqxBobQZ8a9dsZ3dSPZBvE9ZrmtFLrVrN4eo1jsXgAp1+p7bkfqd3 BgBEmfsYWlBXO8rVXfvPgLs32VdVNZxb/CDWPqBsiYv0Hv3HPsz07j5b+/cVoWqyHDKzkaVbxfq/ 7auNVRmPB3v5SWEsH8xi4Bez2V9UKxfYCnqsjp8RaC2/khxKt0A552Eaxnz/4ly/2C7wkwTQnBmd lFYhAflWKQ03Ufiu8t3iBE3VJbc25oMrglj7TRZrmKq3CkbFnX0fyulB+kHimrt6PIWn7kgyl9ae lIl6vtbhMA+l0nfrsORMa4kobqQ5C5rveVgmcIad67EDa+UqEKy/GltUwlSh6xy+TrK1tzDvAgMB AAGjggHMMIIByDAfBgNVHSMEGDAWgBQJwPL8C9qU21/+K9+omULPyeCtADAdBgNVHQ4EFgQUzMeD Mcimo0oz8o1R1Nver3ZVpSkwDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwHQYDVR0lBBYw FAYIKwYBBQUHAwQGCCsGAQUFBwMCMEAGA1UdIAQ5MDcwNQYMKwYBBAGyMQECAQEBMCUwIwYIKwYB BQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20vQ1BTMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJlRW1h aWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJaHR0cDovL2NydC5zZWN0aWdv LmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAj BggrBgEFBQcwAYYXaHR0cDovL29jc3Auc2VjdGlnby5jb20wHgYDVR0RBBcwFYETZHdtdzJAaW5m cmFkZWFkLm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAyW6MUir5dm495teKqAQjDJwuFCi35h4xgnQv Q/fzPXmtR9t54rpmI2TfyvcKgOXpqa7BGXNFfh1JsqexVkIqZP9uWB2J+uVMD+XZEs/KYNNX2PvI lSPrzIB4Z2wyIGQpaPLlYflrrVFKv9CjT2zdqvy2maK7HKOQRt3BiJbVG5lRiwbbygldcALEV9Ch WFfgSXvrWDZspnU3Gjw/rMHrGnqlHtlyebp3pf3fSS9kzQ1FVtVIDrL6eqhTwJxe+pXSMMqFiN0w hpBtXdyDjzBtQTaZJ7zTT/vlehc/tDuqZwGHm/YJy883Ll+GP3NvOkgaRGWEuYWJJ6hFCkXYjyR9 IzGCBMcwggTDAgEBMIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVz dGVyMRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMT NVNlY3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEA xr4ZlmdAxAMdKFES+jupfjANBglghkgBZQMEAgEFAKCCAeswGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMjMwMjA3MTAxMzI5WjAvBgkqhkiG9w0BCQQxIgQg4v1a1gZu SxTofsQeLh9qix3XxAt1wO1LVGUkaQIYXj0wgb0GCSsGAQQBgjcQBDGBrzCBrDCBljELMAkGA1UE BhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEYMBYG A1UEChMPU2VjdGlnbyBMaW1pdGVkMT4wPAYDVQQDEzVTZWN0aWdvIFJTQSBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAMa+GZZnQMQDHShREvo7qX4wgb8GCyqGSIb3 DQEJEAILMYGvoIGsMIGWMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRgwFgYDVQQKEw9TZWN0aWdvIExpbWl0ZWQxPjA8BgNVBAMTNVNl Y3RpZ28gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAxr4Z lmdAxAMdKFES+jupfjANBgkqhkiG9w0BAQEFAASCAgBvGUKEHDuHhEYhvPKVV1KqZ+6Osg2RJLCg DexbakxI7+7dBY1bcAS+4Mj2AWHJVOmKYUBBQ+LVyG3nXjoWjz3jHQOaNLuhiZ0JWNZFqCbIc3pG DPAR2kFngrJbnr7UHA3i902heupfbBPbl6X2y8P2G6Es8TS+GUrqutpA/vFYbzGnYhokwl9eMRlk jC1+E7LGDHAmcCa5zekhb41o5B5jAGUjBEDMFv8b/U0VvNuqKtWNAB38a3LHrg3J577B9HoTpEN5 cdtwDxKcdbyvtcFoYOKJ3KsoP8wQ/hxXiFSzxGJIOHpDIwapwM8TBytkkHPsan1xj4H+1FQBzHx/ D1GM/5Nar4uxWYtIoLDRTGsxd3dadxZZMiwA6MZeor/NPjc65qAGDnMigl2xkaHxbiM4pYZbNg3+ xvruQjN9arlYWmmRluj3ABAtfrhGQAepVRv6BJN43zkoMXFZ9/86uWcEM2nPt6fQzvOj66h3MiUq NBpXGPXnwitK350xEqfGB03lAKS0UYJnygcj2AcMT35rOC0F9n6qpfpTjDud3UV1CAeHaC+DJ5hN 1icBiVSRrsyDBjte0behPDlgglt0nNn2twJ15ueLJXdWHGsGU6lmEFOdESZ7jNfhrDsZMPwYiZJB RDAmXwfr/gOcARxlJZH33L50A4c2smT1ZpSulkqsuQAAAAAAAA== --=-qo71SzSGkn58Swa6P6Dk-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:24:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490981.759900 (Exim 4.92) (envelope-from ) id 1pPL96-0005z5-5m; Tue, 07 Feb 2023 10:24:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490981.759900; Tue, 07 Feb 2023 10:24:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPL96-0005yy-2R; Tue, 07 Feb 2023 10:24:16 +0000 Received: by outflank-mailman (input) for mailman id 490981; Tue, 07 Feb 2023 10:24:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPL94-0005ys-Kv for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 10:24:14 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061e.outbound.protection.outlook.com [2a01:111:f400:fe1f::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8decf71a-a6d1-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 11:24:08 +0100 (CET) Received: from DB7PR05CA0021.eurprd05.prod.outlook.com (2603:10a6:10:36::34) by AS8PR08MB8246.eurprd08.prod.outlook.com (2603:10a6:20b:522::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Tue, 7 Feb 2023 10:24:03 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::9b) by DB7PR05CA0021.outlook.office365.com (2603:10a6:10:36::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35 via Frontend Transport; Tue, 7 Feb 2023 10:24:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34 via Frontend Transport; Tue, 7 Feb 2023 10:24:02 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Tue, 07 Feb 2023 10:24:02 +0000 Received: from 1ec843b26cfa.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CD080F3A-05C8-4F5F-A3CD-87A9B0ACFC32.1; Tue, 07 Feb 2023 10:23:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1ec843b26cfa.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Feb 2023 10:23:55 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS4PR08MB7507.eurprd08.prod.outlook.com (2603:10a6:20b:4f9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 10:23:54 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::b14f:1c13:afa:4eda%3]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 10:23:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8decf71a-a6d1-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqnGrUXDpS3abghYSnDeat7XyrNKciq/92CcdHcngTU=; b=0Tk3DBpFXlhnkpGZXIx9PW6j231HN5ueRGSCFx1bzHnIFSKgTmGK7PhDD1GwLQ12ueCj7/AmMD33xImKfpdjosXPzsnDSHZw6gR2NTigjvgkaud1/mWzz2FPWJhwu5pmPsg3lnn0MiWCi7eFHF3QczeSCAYgW/jElFVUKWq2PY0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0d094df87cc121cd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f+9KV4UTRMg4tVcSz8O3WUAHUKiYVkbg9C5HrIt2kD4j2BLM5eRoBJLf8lp2EC4V1nWFIBQxXo1fuy83ePBxUDZzmWp7TMo7SptVo2dzdRTFQAxpPYZNYG/zG43gzJ3ul8JCtggMWpc2n2aaH+VxUHDTMy1fHvHXeC6kd5Y4ODREq2HmEOraP9Er+I4/Xs/XdDeei95rr6Pd5b4d55/Ev/TsIwKm0x/dOKZrM+G+84Ird60b4CLv3RCbz+ohmOhJ6ipH2QT521dln70tnRihcDMANr/yjc0uySZnx4UWO2rDGcEGreOstolFi1je5rhLrC8mzLeqflpUsKs8t8+zpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FqnGrUXDpS3abghYSnDeat7XyrNKciq/92CcdHcngTU=; b=EyCR/v9H6Xm2q2LM21n60XdSIBu2KH710rn/PhzL1HJ+nla8bfh47dFRPugyp+OTdFOAQdO3B8gqUD4irjfi3yANc0vt5gOjbEKkpdAK+pbMmExq4BwptfqdCv9kg8e1/ivLM7XUN8KvwdXL0GilD72W1lRI1z7+ab/oxcCXV/zEtdW0Ex9rP04Z6B4JL1sPU6vcdVZGG21cAl3tQAv/Z7dxpFQxBvl9c7Sak0Zjtpg+2dpt01BTwzaeM3eeulBiongdJnFserFO2McLyN8JVvMBda/hJwU5BbTb0XlZD5bF5Wgz0X2zwYwllalv6GatM0sA+XR6fo0mWd43UUSrcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FqnGrUXDpS3abghYSnDeat7XyrNKciq/92CcdHcngTU=; b=0Tk3DBpFXlhnkpGZXIx9PW6j231HN5ueRGSCFx1bzHnIFSKgTmGK7PhDD1GwLQ12ueCj7/AmMD33xImKfpdjosXPzsnDSHZw6gR2NTigjvgkaud1/mWzz2FPWJhwu5pmPsg3lnn0MiWCi7eFHF3QczeSCAYgW/jElFVUKWq2PY0= From: Luca Fancellu To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Topic: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Thread-Index: AQHZOAMhFrHFBGWgpEqoPT1xaNlgs67DTHuA Date: Tue, 7 Feb 2023 10:23:54 +0000 Message-ID: References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> In-Reply-To: <20230203190908.211541-2-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS4PR08MB7507:EE_|DBAEUR03FT017:EE_|AS8PR08MB8246:EE_ X-MS-Office365-Filtering-Correlation-Id: 80a33c4b-f0d2-4106-3d37-08db08f56ef9 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: apiCLDPGZWOsQJrUisBcOAYZkQtD1/KK7dMcBCoBULEYWJOht16BetvA+I3pbhvrJRLUFbM1gKA3m+j+iezCz98Vgb0x4Y9TkW91vI1mhtQ4VS5v2xd24Rt1ZNq7byo2YNFsNBzFBw6edkAO4uHtfj/XnHyjvKQz54cBFKC/Ow9H4R46KFZRhRWBgU41aFVzu3oBPiviJBPS7NK7vBgZDGCBg10Nm74ae8BQjQ3in5yOXxaOXDLZaVmzt92Kzy0NA0rU/6i7M5t94plL17qaaaA15PYGSOejXxqVWTOjFi7mmgK1O+zxuZ6FdCWSCiUQcOQbMOq4H3lYpTc8SkjXg9+h8tgpKESKeIvhvGVwQAdOHGXxIk5dNwYP8laK8cPac5ibpwaGLioWGFVY3THcS2G1Z3TH/pK20iGh4u24Iz4gb2Bvzg2ceYqB8ZzYnH56/IJpKl55W9cSZvEiOm6zifnVQg3D7hTHqhsXb5yD3xmpXvMpSSJRZEBGEj1YuGqsAsWU3Y2EZiNOhVRJDXV/oDkR7LYiu8sv0RCyMXeJgRimszBM/a+OC3C57ALQ8lGzSsz8V0X8S63q5kwrtvDF6Cga/T6XU4tYOYqg4mP0gkv2dkqp7Xw+LduSjNfQaEb0r2We3R9HDICPuBEKa4Yg1F80JmvQvBdjyfWSqxsHqdy4J5/7ARmW7iShPIvb5nWQYD5CR3SSnPWK2E6hQtfM30+kcDFWAQ+wk9aDyg40Hok= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199018)(36756003)(33656002)(38100700002)(86362001)(38070700005)(6916009)(66446008)(66556008)(54906003)(8936002)(66946007)(4326008)(41300700001)(8676002)(91956017)(5660300002)(316002)(66476007)(122000001)(76116006)(64756008)(2906002)(2616005)(83380400001)(478600001)(6512007)(26005)(186003)(53546011)(6506007)(6486002)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7507 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 68eaa278-778b-4071-6a0a-08db08f56a02 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8CJbgmrUEVTU2KCbwGnec04p27lc1TCORsT2NObHcuLLDJhcELk0WwWGy6J0Tc780+7z2uRUgqGxjUWm+5G+bq5qnvYNvofipI4xTuhyeoq+9H5Sr/wpvh970ynGsg84vYLuIvlDpLhIBw0xtWDkNV6QppIjSnsFHAAOI6MtUeag9OCoWkEv/QIQiNVQ7/Ij4qAkHbt6NYahfbAN6dmlt8zvw4A0Ht2DkchVxgD2O2X4l3/eiIWcoBTDBv/8R2HSSkloc9ct/4+X0ZkFBoDvBpBbcb/h9eZuoSKrVmvGwGYU3aj9IzGGN07KeW9h5Kg7YlSZAaC5u/2QyANrTC99lNUCKXhBbLTO/c78mz8YzhBxHtJcXzjSfWesh+IUwVeBX+txcplO5T14CCrX/wtIor685FLsKTwnJMuWYTChsR33H4+EitFpS//DbNKfgZLylAxjBti9z01PTg2rsLE0drjrrj3+dyIUDTmwh0K9NklsecamDos1pHTh/1CPYCYdr+PPLyPY+UAQKYh56xepNM+03Q31k5F9gFxlBD0e1Mm3kaNFt6P6OmuEw8ANj1toSOFZtNug8gEi0OJhul2C+F89pAqzoZZbGIMYkG9XDw0Z3+jFcUP+lHLjiM0gGmGrjNsmvliO9+Ukl2MwbksWtI6+zFA+wX5iPSSRLv8hslL6Uq+u2i5FWH3c1OeqBfbIEVBUx15tf9iYbPA702XhAA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(36860700001)(86362001)(33656002)(36756003)(81166007)(82740400003)(70586007)(5660300002)(356005)(6862004)(4326008)(8936002)(316002)(8676002)(70206006)(41300700001)(82310400005)(54906003)(40480700001)(2906002)(6486002)(47076005)(40460700003)(478600001)(83380400001)(336012)(2616005)(26005)(6512007)(53546011)(186003)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 10:24:02.4894 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80a33c4b-f0d2-4106-3d37-08db08f56ef9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8246 DQoNCj4gT24gMyBGZWIgMjAyMywgYXQgMTk6MDksIFhlbmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9k b3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KDQpJ4oCZbSBub3QgcmVhbGx5IGEgc3VwcG9ydGVy IG9mIGVtcHR5IGNvbW1pdCBtZXNzYWdlLCBidXQgaXTigJlzIHVwIHRvIHRoZSBtYWludGFpbmVy IDopDQoNCkZvciBtZSB0aGUgY2hhbmdlcyBsb29rcyBnb29kDQoNClJldmlld2VkLWJ5OiBMdWNh IEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0KPiBTaWduZWQtb2ZmLWJ5OiBY ZW5pYSBSYWdpYWRha291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+DQo+IC0tLQ0KPiANCj4gQ2hh bmdlcyBpbiB2MzoNCj4gIC0gdGhlIGZpeGVzIGFyZSBiYXNlZCBzb2xlbHkgdG8gRWNsYWlyIGZp bmRpbmdzICh0aGUgdG9vbCBoYXMgYmVlbg0KPiAgICBhZGp1c3RlZCB0byByZXBvcnQgb25seSB0 aG9zZSB2aW9sYXRpb25zIHRoYXQgY2FuIHJlc3VsdCB0byBhIGJ1ZykNCj4gIC0gcmVmbGVjdCB0 aGlzIGluIHRoZSBjb21taXQgdGl0bGUNCj4gDQo+IHhlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJl ZS5oIHwgMTQgKysrKysrKy0tLS0tLS0NCj4gMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vZGV2 aWNlX3RyZWUuaCBiL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+IGluZGV4IGEyODkz N2QxMmFlOC4uNzgzOWExOTllMzExIDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vZGV2 aWNlX3RyZWUuaA0KPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vZGV2aWNlX3RyZWUuaA0KPiBAQCAt MzcsMTEgKzM3LDExIEBAIHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggew0KPiAgICAgY29uc3Qgdm9p ZCAqZGF0YTsNCj4gfTsNCj4gDQo+IC0jZGVmaW5lIF9fRFRfTUFUQ0hfUEFUSChwKSAgICAgICAg ICAgICAgLnBhdGggPSBwDQo+IC0jZGVmaW5lIF9fRFRfTUFUQ0hfVFlQRSh0eXApICAgICAgICAg ICAgLnR5cGUgPSB0eXANCj4gLSNkZWZpbmUgX19EVF9NQVRDSF9DT01QQVRJQkxFKGNvbXBhdCkg ICAuY29tcGF0aWJsZSA9IGNvbXBhdA0KPiArI2RlZmluZSBfX0RUX01BVENIX1BBVEgocCkgICAg ICAgICAgICAgIC5wYXRoID0gKHApDQo+ICsjZGVmaW5lIF9fRFRfTUFUQ0hfVFlQRSh0eXApICAg ICAgICAgICAgLnR5cGUgPSAodHlwKQ0KPiArI2RlZmluZSBfX0RUX01BVENIX0NPTVBBVElCTEUo Y29tcGF0KSAgIC5jb21wYXRpYmxlID0gKGNvbXBhdCkNCj4gI2RlZmluZSBfX0RUX01BVENIX05P VF9BVkFJTEFCTEUoKSAgICAgIC5ub3RfYXZhaWxhYmxlID0gMQ0KPiAtI2RlZmluZSBfX0RUX01B VENIX1BST1AocCkgICAgICAgICAgICAgIC5wcm9wID0gcA0KPiArI2RlZmluZSBfX0RUX01BVENI X1BST1AocCkgICAgICAgICAgICAgIC5wcm9wID0gKHApDQo+IA0KPiAjZGVmaW5lIERUX01BVENI X1BBVEgocCkgICAgICAgICAgICAgICAgeyBfX0RUX01BVENIX1BBVEgocCkgfQ0KPiAjZGVmaW5l IERUX01BVENIX1RZUEUodHlwKSAgICAgICAgICAgICAgeyBfX0RUX01BVENIX1RZUEUodHlwKSB9 DQo+IEBAIC0yMjYsMTMgKzIyNiwxMyBAQCBkdF9maW5kX2ludGVycnVwdF9jb250cm9sbGVyKGNv bnN0IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggKm1hdGNoZXMpOw0KPiAjZGVmaW5lIERUX1JPT1Rf Tk9ERV9TSVpFX0NFTExTX0RFRkFVTFQgMQ0KPiANCj4gI2RlZmluZSBkdF9mb3JfZWFjaF9wcm9w ZXJ0eV9ub2RlKGRuLCBwcCkgICAgICAgICAgICAgICAgICAgXA0KPiAtICAgIGZvciAoIHBwID0g ZG4tPnByb3BlcnRpZXM7IHBwICE9IE5VTEw7IHBwID0gcHAtPm5leHQgKQ0KPiArICAgIGZvciAo IHBwID0gKGRuKS0+cHJvcGVydGllczsgKHBwKSAhPSBOVUxMOyBwcCA9IChwcCktPm5leHQgKQ0K PiANCj4gI2RlZmluZSBkdF9mb3JfZWFjaF9kZXZpY2Vfbm9kZShkdCwgZG4pICAgICAgICAgICAg ICAgICAgICAgXA0KPiAtICAgIGZvciAoIGRuID0gZHQ7IGRuICE9IE5VTEw7IGRuID0gZG4tPmFs bG5leHQgKQ0KPiArICAgIGZvciAoIGRuID0gZHQ7IChkbikgIT0gTlVMTDsgZG4gPSAoZG4pLT5h bGxuZXh0ICkNCj4gDQo+ICNkZWZpbmUgZHRfZm9yX2VhY2hfY2hpbGRfbm9kZShkdCwgZG4pICAg ICAgICAgICAgICAgICAgICAgIFwNCj4gLSAgICBmb3IgKCBkbiA9IGR0LT5jaGlsZDsgZG4gIT0g TlVMTDsgZG4gPSBkbi0+c2libGluZyApDQo+ICsgICAgZm9yICggZG4gPSAoZHQpLT5jaGlsZDsg KGRuKSAhPSBOVUxMOyBkbiA9IChkbiktPnNpYmxpbmcgKQ0KPiANCj4gLyogSGVscGVyIHRvIHJl YWQgYSBiaWcgbnVtYmVyOyBzaXplIGlzIGluIGNlbGxzIChub3QgYnl0ZXMpICovDQo+IHN0YXRp YyBpbmxpbmUgdTY0IGR0X3JlYWRfbnVtYmVyKGNvbnN0IF9fYmUzMiAqY2VsbCwgaW50IHNpemUp DQo+IC0tIA0KPiAyLjM3LjINCj4gDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:27:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490990.759912 (Exim 4.92) (envelope-from ) id 1pPLBv-0006hV-OJ; Tue, 07 Feb 2023 10:27:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490990.759912; Tue, 07 Feb 2023 10:27:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLBv-0006hO-KF; Tue, 07 Feb 2023 10:27:11 +0000 Received: by outflank-mailman (input) for mailman id 490990; Tue, 07 Feb 2023 10:27:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLBt-0006hE-TQ; Tue, 07 Feb 2023 10:27:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLBt-0006GL-Lz; Tue, 07 Feb 2023 10:27:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLBt-0001de-FG; Tue, 07 Feb 2023 10:27:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPLBt-0002gL-Em; Tue, 07 Feb 2023 10:27:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OpR30lI46HTXCVl0iDeNnLOu9SaQN0E1PWBxIEjoMSI=; b=2/V/7t1wsLPWHXQz1HYqNSYb1H 1xGbqiBNOXIVPkUWHa/RxwTn+EG/ZRvf4QOISw2iAlXxrakI1pyWUl/n1gFbcADHuS/ZHOGLMmIPF JmpS3k9twOha6c74jszkEHisXu19AwlzMa2mfm8FVD8SLRE2qgs3I2QDFuI7Y08G+5HQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176423: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:heisenbug qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Tue, 07 Feb 2023 10:27:09 +0000 flight 176423 qemu-mainline real [real] flight 176445 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176423/ http://logs.test-lab.xenproject.org/osstest/logs/176445/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail pass in 176445-retest test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176445-retest test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 176445-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 4 days Failing since 176352 2023-02-03 17:40:20 Z 3 days 5 attempts Testing same since 176423 2023-02-06 15:35:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Alexander Graf BALATON Zoltan Bernhard Beschow Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Drew DeVault Emanuele Giuseppe Esposito Emilio Cota Eric Auger Evgeny Iakovlev Frederic Barrat Fuad Tabba Gerd Hoffmann Hanna Reitz Helge Deller Idan Horowitz Ilya Leoshkevich Keith Packard Kevin Wolf Laurent Vivier Letu Ren Marc-André Lureau Marcin Juszkiewicz Mark Cave-Ayland Markus Armbruster Mike Frysinger Murilo Opsfelder Araujo Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4630 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:39:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.490999.759923 (Exim 4.92) (envelope-from ) id 1pPLNV-0008KC-Qy; Tue, 07 Feb 2023 10:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 490999.759923; Tue, 07 Feb 2023 10:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLNV-0008K5-Nz; Tue, 07 Feb 2023 10:39:09 +0000 Received: by outflank-mailman (input) for mailman id 490999; Tue, 07 Feb 2023 10:39:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLNU-0008Jz-Jo for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 10:39:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLNT-0006Xr-Me; Tue, 07 Feb 2023 10:39:07 +0000 Received: from [54.239.6.184] (helo=[192.168.19.254]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPLNT-0003vO-FE; Tue, 07 Feb 2023 10:39:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=C9qTSZ0gbvsbfgxi2p57QAD1Nv90OK9YA/xsqiI6y0c=; b=xyGXm3QKUBWlQDMW8xEYTK8UOg AA1m2OcCTUfmd6fiKhN1Sg6sCDe0C/8I00O7D0R/pcS2z5VGTSgpVdQycqt8DaqSvpzbMzzIO7VeX rGFTHp5Rnuc27Ays5it3mmdvx183uqh2/Qy9eAe4QLehKf6OrZLcpAaQu7KAXwBqhS5w=; Message-ID: <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> Date: Tue, 7 Feb 2023 10:39:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Luca Fancellu , Xenia Ragiadakou Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 07/02/2023 10:23, Luca Fancellu wrote: > > >> On 3 Feb 2023, at 19:09, Xenia Ragiadakou wrote: >> > > I’m not really a supporter of empty commit message, but it’s up to the maintainer :) +1. In this case a brief summary of the rule would be handy for those that are not well-versed with MISRA. This can be dealt on commit if you propose a new commit message. > > For me the changes looks good > > Reviewed-by: Luca Fancellu Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:47:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:47:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491007.759934 (Exim 4.92) (envelope-from ) id 1pPLUp-0001QH-Jy; Tue, 07 Feb 2023 10:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491007.759934; Tue, 07 Feb 2023 10:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLUp-0001QA-H6; Tue, 07 Feb 2023 10:46:43 +0000 Received: by outflank-mailman (input) for mailman id 491007; Tue, 07 Feb 2023 10:46:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLUn-0001Q4-O5 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 10:46:41 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b402a13c-a6d4-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 11:46:40 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id x9so6843511eds.12 for ; Tue, 07 Feb 2023 02:46:40 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id c5-20020a50d645000000b004aaa656887esm3594711edj.96.2023.02.07.02.46.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 02:46:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b402a13c-a6d4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gVA0XKgYBCLmgUb385TaY1m2lRq/DLaicO0rFFkDgcY=; b=PO791oPowLN0A7cmhxIWvDhH1FXkF83uaX9GUfcyRtylzezFpYIJir0vJESwcTG+pI LFpSmAeuEFA/ptM7kn46EDfMCE4ISq9koqqQ6+jDfwsKRd/MkLsEdiMXEJCdTU56Zumj Nrj+nyiQHYhd48Y10EG6qyvYgXdYUgdRd5NexpQ/nvEtuUc6hZ/NTu9vHDOVwtyEz8Iw p13Xtxcme+Xxbf/zWc62B4hRXASFxJ41xyaXVmcNb9vqft+TvyHZR/BtyYEfE86qQj/R y05LHWusjerEF5cpqBCPQDI/byxvtYHZMvLvntNvdrH7vVLckRHiyDOZhMh78ctAjok9 R1OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gVA0XKgYBCLmgUb385TaY1m2lRq/DLaicO0rFFkDgcY=; b=vzTftTnttdbXVYqB7dkkBdMBzPOgwNDQYcjr9MV0AwJHKesKQCBtP1sXXJQsCkvfNb De88NNOprQOvDpB7b3D8AcDIHDJhjusucmx4u6N3bMxN0Q+5iXYzkMNTcPSMst+ekcZa B+PuNs6zdfsmgxNDuW7jCHKyaERvVd+vhB6P6XPtnPQ28HwEX+JbifD6Ibm2iH90CxnA 11budRwLjquyUm49c0RHmqr6lshO4p6TNHCSOB/yMitIQZfsRrb+pup6J4XT9bTOuGH9 3PzBPxNO8oOxJFMhhxDBirBQORjdlyzujD63n+EbZjZx+4Ef9Icj7g745uyGCvlOo/+X pehQ== X-Gm-Message-State: AO0yUKUTa4nZA57+O0saJOGBeqUbBwQaCT+uZUuwMUQUcQhMfbGzIvX3 8ZKwkquKFiletHbwaRrabac= X-Google-Smtp-Source: AK7set/5snqA4X/+xkVyjFbtf27QGN0GoQzw6QZ4Uqa9h6Q0+g6v+F5b3ReFDzQtWUdkepVP6pG0dQ== X-Received: by 2002:a50:d51d:0:b0:499:1ed2:6456 with SMTP id u29-20020a50d51d000000b004991ed26456mr2975513edi.22.1675766799797; Tue, 07 Feb 2023 02:46:39 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 12:46:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Julien Grall , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> From: Xenia Ragiadakou In-Reply-To: <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/7/23 12:39, Julien Grall wrote: > Hi, > > On 07/02/2023 10:23, Luca Fancellu wrote: >> >> >>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou wrote: >>> >> >> I’m not really a supporter of empty commit message, but it’s up to the >> maintainer :) > > +1. In this case a brief summary of the rule would be handy for those > that are not well-versed with MISRA. > > This can be dealt on commit if you propose a new commit message. I 'm refrained from stating the rule as is because it is strict and it is not applied as is. "Add parentheses around macro parameters when the precedence and associativity of the performed operators can lead to unintended order of evaluation." Is this ok? > >> >> For me the changes looks good >> >> Reviewed-by: Luca Fancellu > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:59:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:59:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491014.759956 (Exim 4.92) (envelope-from ) id 1pPLh8-0003KD-4t; Tue, 07 Feb 2023 10:59:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491014.759956; Tue, 07 Feb 2023 10:59:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh8-0003K6-1g; Tue, 07 Feb 2023 10:59:26 +0000 Received: by outflank-mailman (input) for mailman id 491014; Tue, 07 Feb 2023 10:59:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh7-0003ES-6L; Tue, 07 Feb 2023 10:59:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh7-00078y-4d; Tue, 07 Feb 2023 10:59:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh6-0002St-P3; Tue, 07 Feb 2023 10:59:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPLh6-0004BK-Oa; Tue, 07 Feb 2023 10:59:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7rxobh9s/r6BXbVXX9gxKzTz5Gil93VElXB1bvULUTo=; b=E+atcIKamukkI9fKy5cFSrk+IO t5a7+Kj8G4PvuY9yBs+ZygXJUfwfBg+DEvGYNzdTMDQkvoxv2oE/rLEMKW9rrQ67VpEs1aNhwEvad SrOqKKjM6v7yzFgowfaMXXNHBs5ZRpjK/7+7QgXBNT9KatP+JHkZAndGQaZvO8bwLXGY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176447: all pass - PUSHED X-Osstest-Versions-This: ovmf=5db84c85c3544b92fa236c4d169440d523712ae0 X-Osstest-Versions-That: ovmf=aef0061ac22fb14d631aa0398d2cb496b2f7b8c8 From: osstest service owner Date: Tue, 07 Feb 2023 10:59:24 +0000 flight 176447 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176447/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5db84c85c3544b92fa236c4d169440d523712ae0 baseline version: ovmf aef0061ac22fb14d631aa0398d2cb496b2f7b8c8 Last test of basis 176439 2023-02-07 03:43:53 Z 0 days Testing same since 176447 2023-02-07 08:42:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Min M Xu Min Xu Swatisri Kantamsetti Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git aef0061ac2..5db84c85c3 5db84c85c3544b92fa236c4d169440d523712ae0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 07 10:59:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 10:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491013.759945 (Exim 4.92) (envelope-from ) id 1pPLh6-00034v-Nu; Tue, 07 Feb 2023 10:59:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491013.759945; Tue, 07 Feb 2023 10:59:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh6-00034o-KW; Tue, 07 Feb 2023 10:59:24 +0000 Received: by outflank-mailman (input) for mailman id 491013; Tue, 07 Feb 2023 10:59:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPLh5-00034i-7c for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 10:59:23 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061f.outbound.protection.outlook.com [2a01:111:f400:7eab::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79132d81-a6d6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 11:59:21 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS7PR12MB6118.namprd12.prod.outlook.com (2603:10b6:8:9a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 10:59:18 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6064.032; Tue, 7 Feb 2023 10:59:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79132d81-a6d6-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QgVOz6Iry52/6xOV86Xhb5PEoR/2eEj02/qPFkJnR7i6k047DVMB3szSKVHs8oEUWgYHAIZmI/ycKVetSugnDB8MR7Ey9vOF5bo/0e6B5YBmW7YGKcvbVXti/goaEFGQYzyNooDKraHEpIhpQbq0QjWfj4PXGnTUT5j0g8wsqQ45bN92zIX978Oc9Hx4fj2jQdYNRf1y61IqYhvIlRtuxPhLrryO3qJy7s/5guv1DdSeeh6pi2tt5f4EGJ4q/gHqvHyaX2+zgYI+YkWrPapyJAGsM/5yiZBZJ7Mr2AwzquUSrlU1dPuN9y8AA/bck92ZOohE/z4TKnpJLVcRTn8BOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCAtXlg2sBMSsdC3I4UNEaw5IkdMVpwGhBPHqAs9fGs=; b=LP0WmEawFm6V3CWUYCWvMaP0Ch5Na92MFRD1kMG0roh5mKkxcK7gnlJUAzcew0MsveonJ3AhNg3XchgnA40GRBHlcMER5XvdDegDtoOXt48688BS1BnXA7jCAd3dFeSh/vp0Cm+J9gnrXv3ozvEGvYnPbf7/MwqqmfCIlyaAhDfOcGihjHeIQGzNfUqVVBPkOat12UcXz1yQwjewlWulJ2IK0nvdKITiMbrIlbEeSIORJ899BkVF4xENXgvffrVe1cxubpx98EC/qrvwmWtNse2jHi3jn3ol+L7auuRE1em1rDAAe097JtfcW0uUj554wSaLduDz2agz2LQCck6PHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCAtXlg2sBMSsdC3I4UNEaw5IkdMVpwGhBPHqAs9fGs=; b=U6VoxvnT3+TOdmC2lcXF9LyiF662tmWzwmwbxJzLSAB49Ub3T2f8KESI5gTDSkl4MrX/UQJCD7cmvoOkvzhXzD+amELkqmhaXcja83/DY8ai/5SAaPxfz/qooW1BydBnqjxdlkQq/mkVl40pwydysOcd4EtH7JCi/z8gR9PX3/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 7 Feb 2023 10:59:11 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size To: Julien Grall , Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-6-ayan.kumar.halder@amd.com> <8144403d-0899-5b25-f1b0-f798d4b371a6@amd.com> <4f98390c-1cf3-99f3-5131-a42a7ed4387a@xen.org> From: Ayan Kumar Halder In-Reply-To: <4f98390c-1cf3-99f3-5131-a42a7ed4387a@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::19) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS7PR12MB6118:EE_ X-MS-Office365-Filtering-Correlation-Id: a4b052a1-77c3-4a93-daa4-08db08fa5b63 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4hQlAL1SEK8xDvtsLXq28ROMlUXS2U2dt0BPMkaXdVb3tEHshILKRUp+O/LrjRsNzboiY4xx+wPepAEyij4HKAKKn7uephcC3Pty9tF5WzQXDQCVNapDI/+WmdeABvxHpw88cXMYo7AiPrPiin/GyE/1r+czcRq2bAYiEt6xgi+ct4gBALi7PfUCDvyouCVNSyZkEZQTaRupOhbWsmCa0439Y9OTVEawyYNwF/f08ltuQlmaew69/vy/pNtQPl1v1NQJ5vwyRHw5UXXj/aU7v3MykGI7odJ2IFVIS7MBQzIo73C3xsdPUnuFt9SijFxP/NlODJNwKOJa+ZOD7xjoC/B1QOFZ+7Cqxdo8387eCwHWIZGYzEmyDMqg9/OJpoT2FOOmvYLQHGbxbj2A7s4WHS5xr8EUr/SNxW4vymP3TeFbw7W+uatKo9xtUk0ZTa86flENjpjxzqIk6HrBCZ8S7qnLcHpEQWP0wn6iNUm7DHhmeGWya0BTKNnRICK5PNxA0kOrV29JbU1Z1nF1HXp+rEroVZrYUe3TWP1bL/kkwO9A1qDtoDb9s6FbG8r3uGTI6q4/2II4GBNsYquF84dlyEKR274dOjEDNijk/jFknS939EZ5tNvEZDF5CNy3U+rX1YpjBB8QemFG/Os4d+/2nDLaDuT+ISUowbESLB3ZPpz/dkg9lDEUtq8691ZcACouhd5VWcTvuHnftYbw3rUlazANiyNHtZ0j8vUI6l7IJ6ep/1ZmmA+zp1lTOC9xRNIXJaKFGNh5qaoebVD++M9ijg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(451199018)(31686004)(41300700001)(36756003)(6512007)(83380400001)(31696002)(26005)(2616005)(186003)(8676002)(6506007)(6666004)(478600001)(110136005)(6636002)(6486002)(316002)(66946007)(8936002)(66556008)(38100700002)(4326008)(53546011)(5660300002)(66476007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXl4QW1ycUYvWXhsaDlZaitKTzJjRHFNNndnOWdrajV6ZTZHc3BjN0NPMUUw?= =?utf-8?B?R2tHK01wQU51WnE3RXNPeVoyWm1KYWVTOHQxTjVYUGJUQmtIN0djRDZKTWxZ?= =?utf-8?B?SlErT2VqMUhrK0dBSzZKREJXZ2QxUmxXcDBoeXg2a1BLNWJ1RlNPVlNmZjc5?= =?utf-8?B?ZkthZnpFWHlFOFdESUVnTmtSSkY4ZS9aZVRHN0pSbkZyclpuM2wzZkExandK?= =?utf-8?B?MXkvemNRNSt4ekplWUdnL0U5VFNhSWViR09yVHVzRjZ2ZGV4aVplcTAra0Z1?= =?utf-8?B?REdtZVo0aHI3OERscGplQVJBZ2RUeHFrUkNiZHRaV1JtUnR5VVM3aTFuNVh4?= =?utf-8?B?U1plUEx4MnRjaStQVDZoMUFvVmVJVGVrc01rVTFzM0grakdETkQ1ZTNiQURw?= =?utf-8?B?TnZGZ2kwdWw0MUcwSyttY20ydklRSllqWmJzNWM0VUdOMGtZVmJmam9uUUQ3?= =?utf-8?B?N1F2bURLZC9SdE9LK3hDdllGWWp0aU9qalJvdUJ0NTJ3eFhrNzVwKzBUNlVB?= =?utf-8?B?M0ZPQ3BoSUZROHlPamI1cHl1YlhDaXNCYWphMHVMNUNCS3I2ZGN0ZHdGQWl0?= =?utf-8?B?RFZscEpybitHa3dFbTdZcmpVa2dCbGh3aHRqUmJYM0dzaVBvUk4xdWFNbkhx?= =?utf-8?B?dW82N29VSGxBa2Y0NGVOVW5EYXB3K2pTVGhOd1NUYzdZdDJlNmVhOUFSWERV?= =?utf-8?B?NnBtQmZpWTRiVElVd25vck5hSjVUSEhNNkN3VjZsOFYrTGYzZDlWdkJMVFJz?= =?utf-8?B?UVZrVUFmYjhZZlQ1UTU2cEZ5M2J0NHdEQ0FzR2dBMnV6SXdRYWM5Y1Zqc0lY?= =?utf-8?B?QjF3cmE0emN5b1BUbTMrS1FLL3J1MUtITDI4bERMM09lMEJ5YXhmVU9BRW93?= =?utf-8?B?S3VlTjlzRFJmeml4aXEyTDk0akREek55cTdWTEJreVNITXJHNUNyZmVQSkRB?= =?utf-8?B?WW9qeC9NSUVEQk1qOXp0TUJCaDY5S1ZDZHhjQ3IxZitBcXgrZ0VuQ2tCVkpP?= =?utf-8?B?SFNhenFacElPeGp3VVBMenh2SkZZNjBEUExIaCtFRTVoR25LbElJc1YrcTcw?= =?utf-8?B?cEJ2ZS9oM0JGVHh5dk5BNngzMzJLaVdEalMzaUtjMFQ5UnFtSTIzRlQ0NkF0?= =?utf-8?B?bi9VVjc4MVpmbFk5ZUd1ZzhDcjIyM0h4R2VhSzBpUjZsT2ZSWHY0NWJPcFNM?= =?utf-8?B?cWRuL1ROYmMxV1cvZUx3YkJSYzdibUtDRk4yYkJSWi82U2xWSjQvTjA3UDZY?= =?utf-8?B?azNoK1QwTkdBaE5pd1RXVTMva25sdmQ2ZnJlT3RaQUVGdFpyZXdSTEVsZjBL?= =?utf-8?B?MW9RTVlaSEVzRmQ1ODNLbTdMTVFPQTgyNGZ6bmhBWUxGakRrTkhOckV0Ry9a?= =?utf-8?B?T21ZSVF2OU9zL0U1RHJkTk9MTlJINzRKY253MFM5SzQ3K0JETnBpNjZOMVRW?= =?utf-8?B?Q0Fnb1Z0K0hGMDVVdjZsSU55UlFPa2hVMVVqbnM4ZUhGQTBBMVgyWnh2aFR5?= =?utf-8?B?c3gwSGR5OHkxQjlxUG1HM1l2a1dzRlhjZFU4bjR1d2FRc2pBZExyQjZZczFX?= =?utf-8?B?WEc5ZFdyZzJaZ3FYQzBON08zVWEreWNDNjBaQkxYS2E1NHliNWFTREtTcGJJ?= =?utf-8?B?VW1IQ2NTaDFFNC9Rc3FUOEZqRzVRcEllcE5pTmVCNW03ZUg0cFdXcGdHK2Jo?= =?utf-8?B?cmJJeVRSTCtSNERQaC9wNjRCZ0dCaStxNnQzL0FEZ1lPSloyUjl2eE1ZbnhK?= =?utf-8?B?dmhBVy9vcm5maUFRWUJGYW9HSzBrbTFPTUdLbTJCRWZMWVFaako2Z0lEcnJr?= =?utf-8?B?TzFOZHZHeGFFZVRWUXVwY3AzSTlyY2hGMmFCb1R0RWdzK1pSTEI5am9OS0E4?= =?utf-8?B?RkdoMHA0NmsyZEdHemNkWmtjRkFkVW5Eek12aERFYTFOYzN3cEQyMlIwc05W?= =?utf-8?B?RzZTaXQ1NUNTTTRZVk4wMGxldWp5REJ2cndrTEc0WkVxYmtiNlE1Wjg2Q0I0?= =?utf-8?B?Lzl0bGpOaXRNQnFnOU9kTFdkbm9BNFhNT1VyVGd4V1Q5Ti9MR3RUY21Udkdw?= =?utf-8?B?aGJhZ0VUZ0N6MnBzVHlBd1RLQWJNUWJjeml1Q3F5RWQ0eUcyYzlmSVlIandE?= =?utf-8?Q?6AbatUHsoU8n3Pm6GtiiGSUX1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4b052a1-77c3-4a93-daa4-08db08fa5b63 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 10:59:17.3517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QIfDX0c6GUeebht15l1ucXjS8apWTu7PJoN7DY55cQTG9U2dMrgk8CGw8OXaSDJllWhdk3x8xCXwVZMgRS+c1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6118 Hi Julien, On 07/02/2023 09:03, Julien Grall wrote: > > > On 06/02/2023 19:21, Ayan Kumar Halder wrote: >> Hi Stefano, >> >> On 19/01/2023 23:24, Stefano Stabellini wrote: >>> On Tue, 17 Jan 2023, Ayan Kumar Halder wrote: >>>> One should now be able to use 'paddr_t' to represent address and size. >>>> Consequently, one should use 'PRIpaddr' as a format specifier for >>>> paddr_t. >>>> >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> >>>> Changes from - >>>> >>>> v1 - 1. Rebased the patch. >>>> >>>>   xen/arch/arm/domain_build.c        |  9 +++++---- >>>>   xen/arch/arm/gic-v3.c              |  2 +- >>>>   xen/arch/arm/platforms/exynos5.c   | 26 +++++++++++++------------- >>>>   xen/drivers/char/exynos4210-uart.c |  2 +- >>>>   xen/drivers/char/ns16550.c         |  8 ++++---- >>>>   xen/drivers/char/omap-uart.c       |  2 +- >>>>   xen/drivers/char/pl011.c           |  4 ++-- >>>>   xen/drivers/char/scif-uart.c       |  2 +- >>>>   xen/drivers/passthrough/arm/smmu.c |  6 +++--- >>>>   9 files changed, 31 insertions(+), 30 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>>> index 72b9afbb4c..cf8ae37a14 100644 >>>> --- a/xen/arch/arm/domain_build.c >>>> +++ b/xen/arch/arm/domain_build.c >>>> @@ -1666,7 +1666,7 @@ static int __init find_memory_holes(const >>>> struct kernel_info *kinfo, >>>>       dt_for_each_device_node( dt_host, np ) >>>>       { >>>>           unsigned int naddr; >>>> -        u64 addr, size; >>>> +        paddr_t addr, size; >>>>           naddr = dt_number_of_address(np); >>>> @@ -2445,7 +2445,7 @@ static int __init handle_device(struct domain >>>> *d, struct dt_device_node *dev, >>>>       unsigned int naddr; >>>>       unsigned int i; >>>>       int res; >>>> -    u64 addr, size; >>>> +    paddr_t addr, size; >>>>       bool own_device = !dt_device_for_passthrough(dev); >>>>       /* >>>>        * We want to avoid mapping the MMIO in dom0 for the >>>> following cases: >>>> @@ -2941,9 +2941,10 @@ static int __init >>>> handle_passthrough_prop(struct kernel_info *kinfo, >>>>           if ( res ) >>>>           { >>>>               printk(XENLOG_ERR "Unable to permit to dom%d access to" >>>> -                   " 0x%"PRIx64" - 0x%"PRIx64"\n", >>>> +                   " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", >>>>                      kinfo->d->domain_id, >>>> -                   mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - >>>> 1); >>>> +                   (paddr_t) (mstart & PAGE_MASK), >>>> +                   (paddr_t) (PAGE_ALIGN(mstart + size) - 1)); >>> Why do you need the casts here? mstart is already defined as paddr_t >> >> Actually, this is because the PAGE_MASK is defined as 'long'. See >> xen/include/xen/page-size.h :- >> >> #define PAGE_SIZE           (_AC(1,L) << PAGE_SHIFT) >> #define PAGE_MASK           (~(PAGE_SIZE-1)) >> >> So, the resultant type inferred is 'long unsigned int'. Thus, we need >> to add an explicit cast. > > Hmmm... I am a bit confused with this statement. If the resultant type > inferred is actually 'long unsigned int', then why was the current > specifier worked before ('long unsigned int' is 32-bit on Arm32)? Before this change, mstart was of type paddr_t (ie u64 ie unsigned long long on Arm_32). When 'unsigned long long' was operated with 'long' (ie PAGE_SIZE), then the resultant type is 'unsigned long long'. The rule from 'C Standard 2011' (https://web.cs.dal.ca/~vlado/pl/C_Standard_2011-n1570.pdf) , page 53 (Section 6.3.1.8 Usual arithmetic conversions) is :- "Otherwise, if the operand that has unsigned integer type has rank greater or equal to the rank of the type of the other operand, then the operand with signed integer type is converted to the type of the operand with unsigned integer type." And from 6.3.1.1 "The rank of long long int shall be greater than the rank of long int, which shall be greater than the rank of int, which shall be greater than the rank of short int, which shall be greater than the rank of signed char. The rank of any unsigned integer type shall equal the rank of the corresponding signed integer type, if any." And using 'PRIx64' to print 'unsigned long long' will not require any cast. Now with the change, mstart is of paddr_t (ie 'unsigned int'). 'unsigned int' operated with 'long', then  the result is 'unsigned long int'. As the rank of 'unsigned long int' > 'int', thus it cannot be printed using PRIx32 (integer format specifier) without an explicit cast. Please let me know if this makes sense. -Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Feb 07 11:29:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 11:29:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491035.759976 (Exim 4.92) (envelope-from ) id 1pPM9m-0007OE-Ii; Tue, 07 Feb 2023 11:29:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491035.759976; Tue, 07 Feb 2023 11:29:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPM9m-0007O7-Fm; Tue, 07 Feb 2023 11:29:02 +0000 Received: by outflank-mailman (input) for mailman id 491035; Tue, 07 Feb 2023 11:29:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPM9k-0007O0-WA for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 11:29:01 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d2d3ba2-a6da-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 12:28:59 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id bk16so13206754wrb.11 for ; Tue, 07 Feb 2023 03:28:58 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id l11-20020a05600002ab00b002bfb5ebf8cfsm11619769wry.21.2023.02.07.03.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 03:28:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d2d3ba2-a6da-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=AGI/5WcD6IGK2sLIXNvkcsRTPFw6n+eD/7aDYli9eNw=; b=BSkithBNedEW1mzDXaqlodB8jO8lEtTg7665sfhV80ahPjZapCg0ZNiENOikQuB8zf xZr45kbt2RyypID+7LCV4vP9WmLeuqFa8QSMANfPP5QkqxynCXp7znZvyRgJlZcxVT/8 pnwRJgqutT3asendQuoc3d5XQEzNf+r+Veb8n42Y8cPTmG8P8oPXW+PNeredbFWRh/YU StrR3p28aVqfIMG9FRJCpTVR7uB4cblh45Ob4uwnvlm4Q+1gC9JW/LpPxo5gh0kVNyti WIl33onjmJ58KQWJWxHEk1sHgOZ39sOjOAs415Y8APNqxtCJ8C0otyqEinEn0v76csG3 L0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AGI/5WcD6IGK2sLIXNvkcsRTPFw6n+eD/7aDYli9eNw=; b=0+2w2jCzL/f+cHh3PkPU2TAz8wgek/ojHKlTj/jlbrGPTH/wc1wI04UACt/Z47xZYo s34CDXmgY/FmKjPXBozna5uYGxlpGIUx7WZvpxzXOjvAZbNzDupzAdhZbPvupvWaHzT2 H+vmz1LcSa6sPIGtwRAfCmv8tuNtb4Q7d4Mlmj4VvKcVbhozg5tKJobrh6UAWy9sq6/F ULsuuarHLjuX64XO+TPRPa+sNDc1HqYvUAMyNjO7jx+GdPCOJnFub5jBc/nWE5crnT+q /0WwY72BctkALlyoZWpNKEu3kpN9+O1ZNvrKiHODLu9IWUk9JVnJI6Cs9wmh4BMhW8pm rhUQ== X-Gm-Message-State: AO0yUKVr/ynq12T7Y9d7Sj9AKPovUs39GRNFCO6t514sGlZnQwIk3O2N SfsqSSQ55nme0gIjefLIjuE= X-Google-Smtp-Source: AK7set+QfGpmkZbcbph5BoT+fIdKLK+48MuShp0M4NBsAUFYGVRfXkqpbVNeGL/Are2Cv/Mrtg//gA== X-Received: by 2002:a05:6000:124d:b0:2bf:d8ee:22d4 with SMTP id j13-20020a056000124d00b002bfd8ee22d4mr2156306wrx.8.1675769338368; Tue, 07 Feb 2023 03:28:58 -0800 (PST) Message-ID: Subject: Re: [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Date: Tue, 07 Feb 2023 13:28:56 +0200 In-Reply-To: <5c6e413b606ae268f0a6a24d347d6dd994598d37.camel@gmail.com> References: <06c2c36bd68b2534c757dc4087476e855253680a.1675163330.git.oleksii.kurochko@gmail.com> <12f4a315-19dc-2462-7bbf-f02408b09081@xen.org> <5c6e413b606ae268f0a6a24d347d6dd994598d37.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-01-31 at 14:37 +0200, Oleksii wrote: > Hi Julien, >=20 > On Tue, 2023-01-31 at 11:42 +0000, Julien Grall wrote: > > Hi Oleksii, > >=20 > > On 31/01/2023 11:17, Oleksii Kurochko wrote: > > > Because printk() relies on a serial driver (like the ns16550 > > > driver) > > > and drivers require working virtual memory (ioremap()) there is > > > not > > > print functionality early in Xen boot. > > >=20 > > > The patch introduces the basic stuff of early_printk > > > functionality > > > which will be enough to print 'hello from C environment". > > >=20 > > > Originally early_printk.{c,h} was introduced by Bobby Eshleman > > > ( > > > https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d > > > 1aab71384) > > > but some functionality was changed: > > > early_printk() function was changed in comparison with the > > > original > > > as > > > common isn't being built now so there is no vscnprintf. > > >=20 > > > This commit adds early printk implementation built on the putc > > > SBI > > > call. > > >=20 > > > As sbi_console_putchar() is already being planned for deprecation > > > it is used temporarily now and will be removed or reworked after > > > real uart will be ready. > > >=20 > > > Signed-off-by: Bobby Eshleman > > > Signed-off-by: Oleksii Kurochko > > > Reviewed-by: Bobby Eshleman > > > --- > > > Changes in V8: > > > =C2=A0=C2=A0=C2=A0=C2=A0 - Nothing was changed > > > --- > > > Changes in V7: > > > =C2=A0=C2=A0=C2=A0=C2=A0 - Nothing was changed > > > --- > > > Changes in V6: > > > =C2=A0=C2=A0=C2=A0=C2=A0 - Remove __riscv_cmodel_medany check from ea= rly_printk.c > >=20 > > This discussion is still not resolved. I will echo Jan's point [1] > > and=20 > > expand it. There is limited point to keep sending a new version for > > small changes if there main open points are not addressed. > >=20 > > Can you please look at settling done on the issues first and then > > send a=20 > > new version? > Sure, I won't provide new patch series until the issue will be > resolved. >=20 Since Alistair and Bobby agreed that the check is needed I'll send a new version of the patch series. > This patch series has been sent to resolve an issue with CI&CD which > I > missed after the renaming of task for RISC-V in build.yaml. >=20 > ~ Oleksii > >=20 > > Cheers, > >=20 > > [1] 1d63dd9a-77df-4fca-e35b-886ba19fb35d@suse.com > >=20 >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 07 11:37:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 11:37:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491041.759987 (Exim 4.92) (envelope-from ) id 1pPMHw-0000UX-Dg; Tue, 07 Feb 2023 11:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491041.759987; Tue, 07 Feb 2023 11:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPMHw-0000UQ-9k; Tue, 07 Feb 2023 11:37:28 +0000 Received: by outflank-mailman (input) for mailman id 491041; Tue, 07 Feb 2023 11:37:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPMHu-0000UK-Pr for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 11:37:26 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c88f70ef-a6db-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 12:37:23 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c88f70ef-a6db-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675769844; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2RdYT+BhoSAbPtnOB239Ez6A+I/nIOHIo1uOpKSaS7Y=; b=KAbPJAjNAgXvoJZ61WCVzRxgpnxJskEBoSh+zVNTVCmb3GDfIti64CaR mzl/G0WCAHI5Zlvd69V33Q0fTDayb/5pm2c1JSDqcYTBeZyigg+p0Ro3m 34BStQ6tSUyjXAj6LcLODYGUmPT4coXNLKbRBx63ANftVtTsub7b+D4X5 g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96408112 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:TbkC0apdLqPdEOCITZ222Hkxqv9eBmI+ZRIvgKrLsJaIsI4StFCzt garIBnQM6zcYGamKN4jbIu3pk9Vv5WEyYBkG1c9qyhhE3sQ8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyZNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGEHPhPT2c2s+4+2UbQ32PoSc9vSLqpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jOYozypW0hAXDCZ4Wbcylf8pOrMpircXZoySq+e6KBA2ELGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ul7Cmdx6yS5ByWbkAGQSRGc8cOr9ItSHoh0 Vrht9rxCCZmqrG9VXOX/bDSpjS3URX5NkdbO3VCF1FcpYC+/sdq1Emnostf/LCd39elGmGu7 CqxkSUl2u5Ns/9UxZyp1AWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9jAEATY1 JQQs43Htb1VU8nR/MCYaL9VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX aMyhe+zzMULVJdJRfUtC25UNyjN5faIKDgdfqqIBueim7AoHON9wAlgZFSLw0fmm1U2nKc0N P+zKJjzUClCWfg/k2bsHY/xNIPHIQhnlAvuqW3TlUz7gdJymlbFIVv6DLd+Rr9gt/7VyOkk2 91eK9GL231ivB7WO0HqHXooBQlSdxATXMmmw/G7g8bfemKK7kl9Ua6OqV7gEqQ595loehDgo ijnBR8AmAKh3hUq62yiMxheVV8mZr4nxVpTAMDmFQ/AN6QLCWp30JoiSg== IronPort-HdrOrdr: A9a23:WD7fC65FdlX33dJLQQPXwYOCI+orL9Y04lQ7vn2ZFiY6TiXIra +TdaoguSMc6QxhP03I/OrrBEDuewK5yXcY2/hoAV7BZnibhILYFvAe0WKK+VSJcECelp856U p5SdkdNDSaNykAsS+V2njDLz8V+qj5zEnkv5ao815dCSVRL41w5QZwDQiWVmVwWQl9HJI8UL aM+8ZdoDKkWHIPKuC2HGMMUeTvr8DC0MuOW29OOzcXrC21yR+44r/zFBaVmj8YTjN02L8ntU TVjgDj4a2nkvejjjvRzXXa4Zh6kMbojvFDGMuPoM4ILSiEsHffWK1RH5m5+BwlquCm71gn1P HKvhcbJsx2r0jce2mkyCGdqTUJhFwVmhzf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKprzPKN MeTf002cwmPG9yLkqp9FWH+ebcFUjbyy32DnTruaSuoktrdT5CvgslLfck7wc9HaIGOud5Dt v/Q9VVfZF1P7orhPFGdZM8qI2MeyTwaCOJCXmVJ1v/EqEBJjbil77biY9Fpt2CSdgw1501l4 3GUFRE8UgIW2yrJ/Gv8fRwg1PwqEPUZ0Wo9iib3ek9hpTMAIDGC2mobncAs+WdmN0jIuv9H8 yeBfttcpneBGHzA5tO2wHke7Q6EwhmbPEo X-IronPort-AV: E=Sophos;i="5.97,278,1669093200"; d="scan'208";a="96408112" Date: Tue, 7 Feb 2023 11:37:12 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH for-4.17 v6 2/5] libs/light: Rework targets prerequisites Message-ID: References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-3-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Feb 06, 2023 at 06:02:51PM +0000, Andrew Cooper wrote: > On 20/01/2023 7:44 pm, Anthony PERARD wrote: > > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile > > index cd3fa855e1..b28447a2ae 100644 > > --- a/tools/libs/light/Makefile > > +++ b/tools/libs/light/Makefile > > @@ -178,13 +175,13 @@ libxl_x86_acpi.o libxl_x86_acpi.opic: CFLAGS += -I$(XEN_ROOT)/tools > > $(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest) > > > > testidl.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight) > > -testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS) > > - $(PYTHON) gentest.py libxl_types.idl testidl.c.new > > - mv testidl.c.new testidl.c > > +testidl.c: libxl_types.idl gentest.py > > + $(PYTHON) gentest.py $< $@.new > > + mv -f $@.new $@ > > Doesn't this want to be a mov-if-changed? > > We don't need to force a rebuild if testidl.c hasn't changed, I don't think. I don't like move-if-changed, as when the prerequisites happens to be newer than the target, the rules keeps been executed on incremental builds. Also in this case, only two targets depends on this one, "testidl.o" and "testidl", so move-if-changed would not be very useful. > > @@ -208,14 +205,22 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \ > > $(PERL) -w $< $@ >$@.new > > $(call move-if-changed,$@.new,$@) > > > > +# > > +# headers dependencies on generated headers > > +# > > $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h > > $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h > > libxl_internal.h: $(XEN_INCLUDE)/libxl.h $(XEN_INCLUDE)/libxl_json.h > > libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h > > -libxl_internal_json.h: _libxl_types_internal_json.h > > +libxl_internal.h: _libxl_save_msgs_callout.h > > > > -$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h > > +# > > +# objects dependencies on headers that depends on generated headers > > +# > > +$(TEST_PROG_OBJS): $(XEN_INCLUDE)/libxl.h > > $(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h > > +$(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h _libxl_save_msgs_helper.h > > +testidl.o: $(XEN_INCLUDE)/libxl.h > > I know you're just rearranging existing the existing logic, but why > doesn't `#include ` not generate suitable dependences ? Make doesn't know how to read *.c files ;-). But more importantly, we don't have any logic to generate dependencies ahead of building the object, so make doesn't know about it. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:18:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:18:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491054.759998 (Exim 4.92) (envelope-from ) id 1pPMvl-0005Gv-Nh; Tue, 07 Feb 2023 12:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491054.759998; Tue, 07 Feb 2023 12:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPMvl-0005Go-L2; Tue, 07 Feb 2023 12:18:37 +0000 Received: by outflank-mailman (input) for mailman id 491054; Tue, 07 Feb 2023 12:18:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPMvk-0005Gi-PV for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:18:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPMvk-0000Xg-DT; Tue, 07 Feb 2023 12:18:36 +0000 Received: from [54.239.6.184] (helo=[192.168.19.254]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPMvk-0007kx-6C; Tue, 07 Feb 2023 12:18:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rg2h/+YWNrBolKrfXz3DTEOR7mU2DhPRWAjUp61Kjmo=; b=06MlHl9gvfYq9URfQkb9qVJAns uIqB4KmPdncAGPcUC+6mTdDadKBdU+P8d5Mz1bUPZLEAc+MLV12OX1CN4ugriwlhFbur1hWFAiTSz BeUKacRwuP/mRv+C9EZcB4FzDS4rNdSRyiBPblxGf14gWUBLOQiJ5gYPUkvoQm4uHms8=; Message-ID: Date: Tue, 7 Feb 2023 12:18:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size Content-Language: en-US To: Ayan Kumar Halder , Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-6-ayan.kumar.halder@amd.com> <8144403d-0899-5b25-f1b0-f798d4b371a6@amd.com> <4f98390c-1cf3-99f3-5131-a42a7ed4387a@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ayan, On 07/02/2023 10:59, Ayan Kumar Halder wrote: > On 07/02/2023 09:03, Julien Grall wrote: >> >> >> On 06/02/2023 19:21, Ayan Kumar Halder wrote: >>> Hi Stefano, >>> >>> On 19/01/2023 23:24, Stefano Stabellini wrote: >>>> On Tue, 17 Jan 2023, Ayan Kumar Halder wrote: >>>>> One should now be able to use 'paddr_t' to represent address and size. >>>>> Consequently, one should use 'PRIpaddr' as a format specifier for >>>>> paddr_t. >>>>> >>>>> Signed-off-by: Ayan Kumar Halder >>>>> --- >>>>> >>>>> Changes from - >>>>> >>>>> v1 - 1. Rebased the patch. >>>>> >>>>>   xen/arch/arm/domain_build.c        |  9 +++++---- >>>>>   xen/arch/arm/gic-v3.c              |  2 +- >>>>>   xen/arch/arm/platforms/exynos5.c   | 26 +++++++++++++------------- >>>>>   xen/drivers/char/exynos4210-uart.c |  2 +- >>>>>   xen/drivers/char/ns16550.c         |  8 ++++---- >>>>>   xen/drivers/char/omap-uart.c       |  2 +- >>>>>   xen/drivers/char/pl011.c           |  4 ++-- >>>>>   xen/drivers/char/scif-uart.c       |  2 +- >>>>>   xen/drivers/passthrough/arm/smmu.c |  6 +++--- >>>>>   9 files changed, 31 insertions(+), 30 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>>>> index 72b9afbb4c..cf8ae37a14 100644 >>>>> --- a/xen/arch/arm/domain_build.c >>>>> +++ b/xen/arch/arm/domain_build.c >>>>> @@ -1666,7 +1666,7 @@ static int __init find_memory_holes(const >>>>> struct kernel_info *kinfo, >>>>>       dt_for_each_device_node( dt_host, np ) >>>>>       { >>>>>           unsigned int naddr; >>>>> -        u64 addr, size; >>>>> +        paddr_t addr, size; >>>>>           naddr = dt_number_of_address(np); >>>>> @@ -2445,7 +2445,7 @@ static int __init handle_device(struct domain >>>>> *d, struct dt_device_node *dev, >>>>>       unsigned int naddr; >>>>>       unsigned int i; >>>>>       int res; >>>>> -    u64 addr, size; >>>>> +    paddr_t addr, size; >>>>>       bool own_device = !dt_device_for_passthrough(dev); >>>>>       /* >>>>>        * We want to avoid mapping the MMIO in dom0 for the >>>>> following cases: >>>>> @@ -2941,9 +2941,10 @@ static int __init >>>>> handle_passthrough_prop(struct kernel_info *kinfo, >>>>>           if ( res ) >>>>>           { >>>>>               printk(XENLOG_ERR "Unable to permit to dom%d access to" >>>>> -                   " 0x%"PRIx64" - 0x%"PRIx64"\n", >>>>> +                   " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", >>>>>                      kinfo->d->domain_id, >>>>> -                   mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - >>>>> 1); >>>>> +                   (paddr_t) (mstart & PAGE_MASK), >>>>> +                   (paddr_t) (PAGE_ALIGN(mstart + size) - 1)); >>>> Why do you need the casts here? mstart is already defined as paddr_t >>> >>> Actually, this is because the PAGE_MASK is defined as 'long'. See >>> xen/include/xen/page-size.h :- >>> >>> #define PAGE_SIZE           (_AC(1,L) << PAGE_SHIFT) >>> #define PAGE_MASK           (~(PAGE_SIZE-1)) >>> >>> So, the resultant type inferred is 'long unsigned int'. Thus, we need >>> to add an explicit cast. >> >> Hmmm... I am a bit confused with this statement. If the resultant type >> inferred is actually 'long unsigned int', then why was the current >> specifier worked before ('long unsigned int' is 32-bit on Arm32)? > > Before this change, mstart was of type paddr_t (ie u64 ie unsigned long > long on Arm_32). When 'unsigned long long' was operated with 'long' (ie > PAGE_SIZE), then the resultant type is 'unsigned long long'. The rule > from 'C Standard 2011' > (https://web.cs.dal.ca/~vlado/pl/C_Standard_2011-n1570.pdf) , page 53 > (Section 6.3.1.8 Usual arithmetic conversions) is :- > > "Otherwise, if the operand that has unsigned integer type has rank > greater or equal to the rank of the type of the other operand, then the > operand with signed integer type is converted to the type of the operand > with unsigned integer type." > > And from 6.3.1.1 > > "The rank of long long int shall be greater than the rank of long int, > which shall be greater than the rank of int, which shall be greater than > the rank of short int, which shall be greater than the rank of signed char. > > The rank of any unsigned integer type shall equal the rank of the > corresponding signed integer type, if any." > > And using 'PRIx64' to print 'unsigned long long' will not require any cast. > > Now with the change, > mstart is of paddr_t (ie 'unsigned int'). 'unsigned int' operated with > 'long', then  the result is 'unsigned long int'. As the rank of > 'unsigned long int' > 'int', thus it cannot be printed using PRIx32 > (integer format specifier) without an explicit cast. > > Please let me know if this makes sense. Thanks for the explanation. I would expect that there will be several places in Xen where we would need such cast. So it sounds like we want to define paddr_t as ``unsigned long`` and update PRIpaddr accordingly. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:25:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:25:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491062.760009 (Exim 4.92) (envelope-from ) id 1pPN2F-0006jA-Fh; Tue, 07 Feb 2023 12:25:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491062.760009; Tue, 07 Feb 2023 12:25:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPN2F-0006j3-B4; Tue, 07 Feb 2023 12:25:19 +0000 Received: by outflank-mailman (input) for mailman id 491062; Tue, 07 Feb 2023 12:25:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPN2D-0006ix-W2 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:25:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPN2D-0000fV-7O; Tue, 07 Feb 2023 12:25:17 +0000 Received: from [54.239.6.184] (helo=[192.168.19.254]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPN2D-000827-0f; Tue, 07 Feb 2023 12:25:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=oRKxtklRriJfGpyyw3SWVXtexrI5aDfH8hx9UnXSOQo=; b=YEZic+YqEAcpH08jzHNLItnIFl VhMXxRMjsqq7ZOszl0mzQY32/i1/zpQ8BcTLajCYLmuPViXvHexFiUyyFKI1TQx7yqilMZ5G9+QrI xOZR15k1chfJUKQVrVNptBOuJaVf2YF20iS1xOzsnijidaj72f3apXLjA3H6trkQ0uH4=; Message-ID: <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> Date: Tue, 7 Feb 2023 12:25:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Xenia Ragiadakou , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/02/2023 10:46, Xenia Ragiadakou wrote: > > On 2/7/23 12:39, Julien Grall wrote: >> Hi, >> >> On 07/02/2023 10:23, Luca Fancellu wrote: >>> >>> >>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>> wrote: >>>> >>> >>> I’m not really a supporter of empty commit message, but it’s up to >>> the maintainer :) >> >> +1. In this case a brief summary of the rule would be handy for those >> that are not well-versed with MISRA. >> >> This can be dealt on commit if you propose a new commit message. > > I 'm refrained from stating the rule as is because it is strict and it > is not applied as is. I am a bit confused with this statement. From misra/..., we are supporting rule 20.7. So why aren't applying it strictly? And if it is not applied as-is, shouldn't we document the violation (if any)? > > "Add parentheses around macro parameters when the precedence and > associativity of the performed operators can lead to unintended order of > evaluation." > > Is this ok? I am OK with this. Is there any ID from Eclair that could be used to track each error (and so we can confirm they have disappeared)? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:42:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491070.760031 (Exim 4.92) (envelope-from ) id 1pPNIZ-000146-4f; Tue, 07 Feb 2023 12:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491070.760031; Tue, 07 Feb 2023 12:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIZ-00013z-1x; Tue, 07 Feb 2023 12:42:11 +0000 Received: by outflank-mailman (input) for mailman id 491070; Tue, 07 Feb 2023 12:42:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIX-0000om-Ci for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:42:09 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d245e328-a6e4-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:42:03 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id ba1so9357274wrb.5 for ; Tue, 07 Feb 2023 04:42:03 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id d3-20020a056000114300b002c3f9404c45sm19632wrx.7.2023.02.07.04.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:42:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d245e328-a6e4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9BypUrC3yR5z7zzlODmq7D0VqGCfJ2/AlymTxYrt8pY=; b=R3Tvr+99ZU06QKypC3id2r5wsF06P+PsX6PKY3hRwv/drAQtzhmJbuc6RYIQWkWupZ sWq0Cq5HJKTWpAWW801TFELTCcXMl+SivU2KWGD+VbZKL5ftL8s/HW9peTzgGUCZyxXN 4C+Dnw6tdpiGbSJLpkrKC7B0Lx0xFPhog9jM+MAZ66ZhCopDfFgMusF1xCbk+h0JOito R7PLbwtjRGOxJ7bYP5ox/p3W5Rs4+5Uh+0a1hN+GPR8uKvUiTIJ+AiRn62LFTiRRZkFm JpXOnpkgvp/m/93FEXwl9utF2hU9ArMyMygNi4RGOmkMBZDdTox4L3E0wn4xJry1xi4x 8pKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9BypUrC3yR5z7zzlODmq7D0VqGCfJ2/AlymTxYrt8pY=; b=tn6bAuanDccV6dSjRMrqq/aa1hI3NIfYF5VEk3L9B07Wsa7VfZKEhywClrlsi98WbL 7J3w2dlxHOyITgjnVu74LyYVDtFNN1sXiSZrIiKRzNOQSuJWqudOxyqwBPbwr+hhNLg4 qlyHSW6Lqviru0ueUm6uILZUzFXBLtls+V8cNkA+GgO6xIuzLCLxkvyBUXuJkl5fsAW6 AR96D2Jir0jHc951sC4rxJj4yXn0c3ZrZUFKdYwt19YhgfZszx3pCNegPust+LiDU8Tp boPYqrZiznytsETJbA2j5MIsrfAVLY2fqdN6RWpndppH85VtNliMjMNQJ/SZjcA5joNq NVgA== X-Gm-Message-State: AO0yUKVnq9/VsINJBvQV5m42NL+4y9mAL8E0Er2zegjj8ekwBWKU/UzV VGq2cSb0SdgrGLCZ/sestWTROhVCCC4= X-Google-Smtp-Source: AK7set/u06FmZEfg0nblYrdSBPAbZVNB2dQAoq6pdwEDdPceH4WxNlLqqJ++GEcTI58D3OAlurynVQ== X-Received: by 2002:a5d:58ec:0:b0:2ab:78e2:864e with SMTP id f12-20020a5d58ec000000b002ab78e2864emr2639532wrd.19.1675773722211; Tue, 07 Feb 2023 04:42:02 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v9 0/2] Basic early_printk and smoke test implementation Date: Tue, 7 Feb 2023 14:41:51 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke test which checks if "Hello from C env" message is present in serial.tmp The patch series is rebased on top of the patch "include/types: move stddef.h-kind types to common header" [1] [1] https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ --- Changes in V9: - Bring "cmodel=medany" check back to be sure that C function is safe to be called in early boot when MMU is off as --- Changes in V8: - Set "needs: archlinux-current-gcc-riscv64-debug" in test.yaml for RISCV job as CONFIG_EARLY_PRINTK is available only when CONFIG_DEBUG is available. --- Changes in V7: - Fix dependecy for qemu-smoke-riscv64-gcc job --- Changes in V6: - Rename container name in test.yaml for .qemu-riscv64. --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed - All mentioned comments by Stefano in Xen mailing list will be fixed as a separate patch out of this patch series. --- Oleksii Kurochko (2): xen/riscv: introduce early_printk basic stuff automation: add RISC-V smoke test automation/gitlab-ci/test.yaml | 20 ++++++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++ xen/arch/riscv/Kconfig.debug | 5 ++++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ xen/arch/riscv/setup.c | 4 +++ 7 files changed, 95 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:42:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491071.760037 (Exim 4.92) (envelope-from ) id 1pPNIZ-00017W-Hh; Tue, 07 Feb 2023 12:42:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491071.760037; Tue, 07 Feb 2023 12:42:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIZ-00016y-Ax; Tue, 07 Feb 2023 12:42:11 +0000 Received: by outflank-mailman (input) for mailman id 491071; Tue, 07 Feb 2023 12:42:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIY-0000om-Co for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:42:10 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3288455-a6e4-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:42:04 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so13083590wmb.2 for ; Tue, 07 Feb 2023 04:42:04 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id d3-20020a056000114300b002c3f9404c45sm19632wrx.7.2023.02.07.04.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:42:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3288455-a6e4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rviyH505nsbYK2ozmVytpLFJQlUNOXPwSYuCd3kmF7A=; b=ZbZcaBRqoKsBUHy+yBzw6A7IpcZoHc11piFNhJxND8DTmVn8up8S5sS7e9Oz958NJ5 C0Mdm6Ah//0tNwSH7l4B7u3s6qzhTU3CwtT2ZEdxGyldffM0irGPQ0PQwZXa+bzHg7Rl sdCMeVrV4pzXX2v7jJ7592Ve6TGr5HgHUqX3WrofTgr9PzJd/myOD/5SpcqWU9Jw1xS4 wtE7o8xWYT8XmKnK3YWF/R554SYMgPxk4FCOjuzitIwob4mL1aRzt/G2zgVo0Nk434mn OJS64KwMLHwuasw3/C4bx8pILsmP57blSrtFG8BdNdo73AF9doeTqCsWEDvfhzsKr6UN WQ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rviyH505nsbYK2ozmVytpLFJQlUNOXPwSYuCd3kmF7A=; b=DNW76a1V1b4eEa/mWbD6fQSGPiohYYy+pgTZlo3ufPUaXxcJxpNhGtbkRzN0BarCV2 EKNOjzM31lzK7KG5Is9ai4jhcZzW4uPUiCBHOQ7Alf7PA2rlOumORnLXbJzst302wPGr RAo5T540m0ApU23nG02OVVYqzpN/X5TkbL/lkDGxdev36Iz5NvYPRnfWNCH7KGyHgtDj U8cmtYvjqFpKTWPKAisemqwLgKqkvSW8hAIuH63yNqrMBfRB1tCybi3AJLPePOMbxhAu qNfVS9Aw3lNPMqNPmQekrJy6FvlYnUliiSe5Ztyir7YaoH0S+n6BM0QM0iJ8uGZvfiqE DEmQ== X-Gm-Message-State: AO0yUKVaUVeNfNSHhN+O2naE5BAzoLmv7bqh8cYc4yD2czxgUAxiHV15 ulIh9Rhi6oZv/yAeC0xIRlhp/NCnjy8= X-Google-Smtp-Source: AK7set8zdSCBTXeP8zqZSORJdmDP/4UE3Fy1x6QxZBzmptqONrAoC2Dlln7oY75Qh8V1nEU8NWO8/w== X-Received: by 2002:a05:600c:3596:b0:3df:d431:cf64 with SMTP id p22-20020a05600c359600b003dfd431cf64mr2909266wmq.39.1675773723875; Tue, 07 Feb 2023 04:42:03 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Subject: [PATCH v9 1/2] xen/riscv: introduce early_printk basic stuff Date: Tue, 7 Feb 2023 14:41:52 +0200 Message-Id: <06c2c36bd68b2534c757dc4087476e855253680a.1675772422.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. The patch introduces the basic stuff of early_printk functionality which will be enough to print 'hello from C environment". Originally early_printk.{c,h} was introduced by Bobby Eshleman (https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d1aab71384) but some functionality was changed: early_printk() function was changed in comparison with the original as common isn't being built now so there is no vscnprintf. This commit adds early printk implementation built on the putc SBI call. As sbi_console_putchar() is already being planned for deprecation it is used temporarily now and will be removed or reworked after real uart will be ready. Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko Reviewed-by: Bobby Eshleman --- Changes in V9: - Bring "cmodel=medany" check back to be sure that C function is safe to be called in early boot when MMU is off ( e.g. VA != PA ) --- Changes in V8: - Nothing was changed --- Changes in V7: - Nothing was changed --- Changes in V6: - Remove __riscv_cmodel_medany check from early_printk.c --- Changes in V5: - Code style fixes - Change an error message of #error in case of __riscv_cmodel_medany isn't defined --- Changes in V4: - Remove "depends on RISCV*" from Kconfig.debug as it is located in arch specific folder so by default RISCV configs should be ebabled. - Add "ifdef __riscv_cmodel_medany" to be sure that PC-relative addressing is used as early_*() functions can be called from head.S with MMU-off and before relocation (if it would be needed at all for RISC-V) - fix code style --- Changes in V3: - reorder headers in alphabetical order - merge changes related to start_xen() function from "[PATCH v2 7/8] xen/riscv: print hello message from C env" to this patch - remove unneeded parentheses in definition of STACK_SIZE --- Changes in V2: - introduce STACK_SIZE define. - use consistent padding between instruction mnemonic and operand(s) --- --- xen/arch/riscv/Kconfig.debug | 5 ++++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 33 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ xen/arch/riscv/setup.c | 4 +++ 5 files changed, 55 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug index e69de29bb2..608c9ff832 100644 --- a/xen/arch/riscv/Kconfig.debug +++ b/xen/arch/riscv/Kconfig.debug @@ -0,0 +1,5 @@ +config EARLY_PRINTK + bool "Enable early printk" + default DEBUG + help + Enables early printk debug messages diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index fd916e1004..1a4f1a6015 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..b66a11f1bc --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include + +/* + * TODO: + * sbi_console_putchar is already planned for deprecation + * so it should be reworked to use UART directly. +*/ +void early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if ( *s == '\n' ) + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +void early_printk(const char *str) +{ + while ( *str ) + { + early_puts(str, 1); + str++; + } +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..05106e160d --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,12 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#ifdef CONFIG_EARLY_PRINTK +void early_printk(const char *str); +#else +static inline void early_printk(const char *s) {}; +#endif + +#endif /* __EARLY_PRINTK_H__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 13e24e2fe1..d09ffe1454 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,12 +1,16 @@ #include #include +#include + /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); void __init noreturn start_xen(void) { + early_printk("Hello from C env\n"); + for ( ;; ) asm volatile ("wfi"); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:42:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:42:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491069.760020 (Exim 4.92) (envelope-from ) id 1pPNIX-0000p4-U8; Tue, 07 Feb 2023 12:42:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491069.760020; Tue, 07 Feb 2023 12:42:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIX-0000ox-Q9; Tue, 07 Feb 2023 12:42:09 +0000 Received: by outflank-mailman (input) for mailman id 491069; Tue, 07 Feb 2023 12:42:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNIW-0000om-OQ for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:42:08 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d4073d75-a6e4-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:42:06 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id h16so13391659wrz.12 for ; Tue, 07 Feb 2023 04:42:06 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id d3-20020a056000114300b002c3f9404c45sm19632wrx.7.2023.02.07.04.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:42:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4073d75-a6e4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j+hH6wb1ILPFhWUIsB/OxGXEs5Kwqur8kDwatlBPrCk=; b=bPheiZnEhiQ1peBLgDKE1aPxYbZYirgBqnhur2Zkb0RnWjshA5wNwe0OumdN50yKOo PDR5r7JOGCQiKG7m/yrkKDRm+z2X6raWrneJHiljUEqu3bRpUNvx9kEtbaLYHdCECEvi pEG+mri63PtEVeIde7uXjsgJhRzL8ZA15g03kzFQ1WsvWAVLY/9bBO5xgS+tRpvz3r89 zK9a0tF7oQUtFXfKKskjm9BBqxQTccOr8sxzWPuacdx9fOziLLxKAvsd3y8nOpEOZvzp x03hYtnME61Fy1QmPoD9ImVCzTx6+G00I9Zc08uHAy/kLcRnLQX/CNTPHGhDCQ2BizLF irHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j+hH6wb1ILPFhWUIsB/OxGXEs5Kwqur8kDwatlBPrCk=; b=vCqwcZCl1zX66yunuYvTdJgoIu1EdFNr69wHxE21KKcgxHTOIn0uLA3wgH4KrdmK1Q e+5U3OrIYbRk7l3gKlJiisFsxl+UsTen3FKlq3Xu/EHda3exYvTRyL6a+SxkAxFIgMef 5vViUBAOjvD5brKwpJoE4MYScYPScMeZyNbx8wTGPIAVEM1c9SgjVAzj3l1IQ7klGr1U DuyLig0HdRW9zjS1nzwDA+4w4TnMFi/fnC8vsYFgrXJa4XohDCEgwb+r+7W3SYSqSEw6 9ACvWrlwTTWfnbaQjiUg9JoupjW2PfccI39nkGU/K5dBJVvoigJ7Bmhoa+V3suKo7BYI WYFQ== X-Gm-Message-State: AO0yUKXNWwZD4xXJ/pWrFROg01HQTK+bQ1OWrLG4L1KDPu4R43gN47Rd PeThl6KoMbrw5BntoSCKkCGmvzgDUic= X-Google-Smtp-Source: AK7set/akf552p7QtPIKA+1v4oAevc72tE5v1TZ3UtKYfvcXZJwMZnyWufHvjepVkFncB3w6Jn6RTg== X-Received: by 2002:adf:ef84:0:b0:2bf:bac7:30d4 with SMTP id d4-20020adfef84000000b002bfbac730d4mr2717681wro.53.1675773725317; Tue, 07 Feb 2023 04:42:05 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein , Alistair Francis Subject: [PATCH v9 2/2] automation: add RISC-V smoke test Date: Tue, 7 Feb 2023 14:41:53 +0200 Message-Id: <2ff69540fffe67880bb13a468295c593d0db8604.1675772422.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Signed-off-by: Oleksii Kurochko Acked-by: Stefano Stabellini Reviewed-by: Alistair Francis --- Changes in V9: - Nothing changed --- Changes in V8: - Set "needs: archlinux-current-gcc-riscv64-debug" in test.yaml for RISCV job as CONFIG_EARLY_PRINTK is available only when CONFIG_DEBUG is available. --- Changes in V7: - Fix dependecy for qemu-smoke-riscv64-gcc job --- Changes in V6: - Rename container name in test.yaml for .qemu-riscv64. --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed - All mentioned comments by Stefano in Xen mailing list will be fixed as a separate patch out of this patch series. --- automation/gitlab-ci/test.yaml | 20 ++++++++++++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index afd80adfe1..ce543ef5c0 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,19 @@ tags: - x86_64 +.qemu-riscv64: + extends: .test-jobs-common + variables: + CONTAINER: archlinux:current-riscv64 + LOGFILE: qemu-smoke-riscv64.log + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - x86_64 + .yocto-test: extends: .test-jobs-common script: @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: needs: - debian-unstable-clang-debug +qemu-smoke-riscv64-gcc: + extends: .qemu-riscv64 + script: + - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} + needs: + - archlinux-current-gcc-riscv64-debug + # Yocto test jobs yocto-qemuarm64: extends: .yocto-test-arm64 diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh new file mode 100755 index 0000000000..e0f06360bc --- /dev/null +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -0,0 +1,20 @@ +#!/bin/bash + +set -ex + +# Run the test +rm -f smoke.serial +set +e + +timeout -k 1 2 \ +qemu-system-riscv64 \ + -M virt \ + -smp 1 \ + -nographic \ + -m 2g \ + -kernel binaries/xen \ + |& tee smoke.serial + +set -e +(grep -q "Hello from C env" smoke.serial) || exit 1 +exit 0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:46:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491094.760053 (Exim 4.92) (envelope-from ) id 1pPNN6-0002iX-4X; Tue, 07 Feb 2023 12:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491094.760053; Tue, 07 Feb 2023 12:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNN6-0002iQ-1p; Tue, 07 Feb 2023 12:46:52 +0000 Received: by outflank-mailman (input) for mailman id 491094; Tue, 07 Feb 2023 12:46:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNN4-0002iK-TH for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:46:50 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a2f9646-a6e5-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:46:44 +0100 (CET) Received: by mail-ej1-x629.google.com with SMTP id gr7so42821288ejb.5 for ; Tue, 07 Feb 2023 04:46:44 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id o13-20020a17090611cd00b007b4bc423b41sm6760202eja.190.2023.02.07.04.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 04:46:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a2f9646-a6e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A4k+rnXQ6TJREKovfpvAXDa5QBS1bqrIcrrDJ7G1YV8=; b=JqSHkXFCft5o6Q+5EwpCDSEnhnLfsAztRh8okX88L0XMY3Jvvaps8sbN+QhPXr+qia KbOR8TQTmQLRR4HRpEsbsgO8qBaHFujZ8neOROWvb1aScstfY8MzJ/dqlC5M4r1a1P3m LhqvlA84lYVSpOKyJz9ygiCsiepnL/K+eXcZ7qEee3Go9ANwZnJJow5Mbnvc++ulx6wa hK6g9T2JOK84cxUF8CcHg1RXK5qjozmpmi9UDxZc4zhGbl8HZK0bUW4bPKodr2HHO7eq eY6otoAhSD5NGG98t5U+O4ZEHZZIX3yrHneSkAAihKENYaRMh64vJuVvNS5xybzWY7jn Z/BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A4k+rnXQ6TJREKovfpvAXDa5QBS1bqrIcrrDJ7G1YV8=; b=1DPfcgKdzXOYfqcpapkd9F5CF8leoJqRX3Zd7fTuRwqGb5WO8BecP7bEgE0UrK9URs 2UTPRpVoQ4mB6AKQYiH6ChlsxnQLFG4z5Em6KoNBtJEPKLR/MjOtkOaAQJJU4s+eUVp5 mFpVc8EIXN7oYUxJTt9MW/wBe0h8paYNRhm4JK4x+ErcS9OuEfPiWuacTmz8Gk7d8FBk QBvQJMhpCeZU0U4WFEwmoXehx3/cfvgxkVYFiYVsCl7Gkhi96Ax9jDba1NBfYLJleJ5Y 1Od58qrw50NmHseP7YeJvahqoxj5htnQ18IZie/5fFzaEda1PWwq8VlCvNBwk4hRnld7 XDWg== X-Gm-Message-State: AO0yUKVIIL40V+73bSX13/oM8QHNizCGE8uOgKMPv0PsDah5wGy037Vl 5owbgd4P7Ygf9gv9dOM2FZAAWKNQwfQ= X-Google-Smtp-Source: AK7set8G5Ij8qlCGsH4766eGYLaI975xzSHW+vtGVsnFvgT2USX7UY7D0CdCd2rdvqRUc3CfNygVvw== X-Received: by 2002:a17:907:8e8b:b0:8aa:1f89:122e with SMTP id tx11-20020a1709078e8b00b008aa1f89122emr1828009ejc.39.1675774004270; Tue, 07 Feb 2023 04:46:44 -0800 (PST) Message-ID: <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> Date: Tue, 7 Feb 2023 14:46:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Julien Grall , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> From: Xenia Ragiadakou In-Reply-To: <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/7/23 14:25, Julien Grall wrote: > > > On 07/02/2023 10:46, Xenia Ragiadakou wrote: >> >> On 2/7/23 12:39, Julien Grall wrote: >>> Hi, >>> >>> On 07/02/2023 10:23, Luca Fancellu wrote: >>>> >>>> >>>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>>> wrote: >>>>> >>>> >>>> I’m not really a supporter of empty commit message, but it’s up to >>>> the maintainer :) >>> >>> +1. In this case a brief summary of the rule would be handy for those >>> that are not well-versed with MISRA. >>> >>> This can be dealt on commit if you propose a new commit message. >> >> I 'm refrained from stating the rule as is because it is strict and it >> is not applied as is. > > I am a bit confused with this statement. From misra/..., we are > supporting rule 20.7. So why aren't applying it strictly? > > And if it is not applied as-is, shouldn't we document the violation (if > any)? I applied it strictly on v2, but there was no review. Then Eclair was adjusted to have a less strict approach. Still there is a finding asking to add parentheses around dt in dt_for_each_device_node(dt, dn), i.e dn = (dt);, to which AFAIK you object. > >> >> "Add parentheses around macro parameters when the precedence and >> associativity of the performed operators can lead to unintended order >> of evaluation." >> >> Is this ok? > > I am OK with this. Is there any ID from Eclair that could be used to > track each error (and so we can confirm they have disappeared)? I am not aware of any. The patch can be decoupled from misra and Eclair (I mean have a generic commit title) and just mention in the commit message that it fixes some Eclair findings for MISRA C rule 20.7. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:49:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:49:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491102.760074 (Exim 4.92) (envelope-from ) id 1pPNPP-0003a5-Q1; Tue, 07 Feb 2023 12:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491102.760074; Tue, 07 Feb 2023 12:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPP-0003Zy-Ms; Tue, 07 Feb 2023 12:49:15 +0000 Received: by outflank-mailman (input) for mailman id 491102; Tue, 07 Feb 2023 12:49:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPN-0003Jc-OW for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:49:13 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d298f1ab-a6e5-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 13:49:13 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id y1so13453593wru.2 for ; Tue, 07 Feb 2023 04:49:13 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p10-20020a5d59aa000000b002be5401ef5fsm11468388wrr.39.2023.02.07.04.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:49:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d298f1ab-a6e5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dQfYQAH/vtqOvI/GxwDEsygPxurjtVig+mWnpoag/DE=; b=m8Yb+st4y9Hj54obFB6mNuAk/JsAkM+nJsdBB4aRDGQn6L0yxEMANmx56PoAE1064u vk3WzXYrk0rqYO4sHnAxET5/NcjyqZKRpfXO2YCFkwOjXWkVi+qjxD5m9O7rDmxOAKXV RD7Kc+eomFQFQ9tyFBs/wk4nZd4XL0kCUqenvRSo2D4FB0sqI5SaXvN+kWMM/CValrOA +9pegrO+cv5UVa3eOIcAMXIm+B1QehzDu/koMbDpNhlFz02I7L70I2WDSuyMAar/rjjD kAbw0oLBZzQuGs49adnuo8/CPsNUa4tBJzRp1gHCqFsDrO6zEcQgTnquIhvedGoBHbeG srwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dQfYQAH/vtqOvI/GxwDEsygPxurjtVig+mWnpoag/DE=; b=shL+/q0bO7xd2iGMs8mjGPJszBYub+YyoKRdb5ij9WbrfgvchRNaphZ7dE0Iwn6eeK h8ABxg7Iz1lBpFONFZyftwq/L50wMW+iAoinjbnZfOE8D0rZmlk//wTZw2hxGlpIbn0W THPnFoLypScVO7enK8PMQKMHmOS0uTuBmRREi68m+4i+oAWuu980ekPoy6/s+plzCFSZ TFBCEepkJZreqGIePnW7pPv9091chXFI9JotHeRDxqzZkUs+r6EuYtVf3DMbY+t+51Je iSQnNsNcePDfLN78qnPVCNPuha/nSIiW+aQZHYY94M/fth8Vt4/fNq1v4L7tiF9DkpE4 eSww== X-Gm-Message-State: AO0yUKWXDbk2Jhpwqxqib+bwE0y3vMsnyBhKxqO+jOt13H795nfiuUQL d0K4dWliNqJheYtyaKr/N93LGScbdms= X-Google-Smtp-Source: AK7set9AZVnmhxwKoONs8lAr2Wqo/5905kHTVilAQJnoJrvaQgnDPcG1vZerf5YHa44yrjbuo3ZmCQ== X-Received: by 2002:adf:df84:0:b0:2bf:b7e3:6d62 with SMTP id z4-20020adfdf84000000b002bfb7e36d62mr2945922wrl.5.1675774152401; Tue, 07 Feb 2023 04:49:12 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Subject: [PATCH v10 1/2] xen/riscv: introduce early_printk basic stuff Date: Tue, 7 Feb 2023 14:49:05 +0200 Message-Id: <15e29bb67e9dc0a24811c02c8ef6965523dac27e.1675773832.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. The patch introduces the basic stuff of early_printk functionality which will be enough to print 'hello from C environment". Originally early_printk.{c,h} was introduced by Bobby Eshleman (https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d1aab71384) but some functionality was changed: early_printk() function was changed in comparison with the original as common isn't being built now so there is no vscnprintf. This commit adds early printk implementation built on the putc SBI call. As sbi_console_putchar() is already being planned for deprecation it is used temporarily now and will be removed or reworked after real uart will be ready. Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko Reviewed-by: Bobby Eshleman --- Changes in V10: - Miss to add the check in V9 so add it in V10 --- Changes in V9: - Bring "cmodel=medany" check back to be sure that C function is safe to be called in early boot when MMU is off ( e.g. VA != PA ) --- Changes in V8: - Nothing was changed --- Changes in V7: - Nothing was changed --- Changes in V6: - Remove __riscv_cmodel_medany check from early_printk.c --- Changes in V5: - Code style fixes - Change an error message of #error in case of __riscv_cmodel_medany isn't defined --- Changes in V4: - Remove "depends on RISCV*" from Kconfig.debug as it is located in arch specific folder so by default RISCV configs should be ebabled. - Add "ifdef __riscv_cmodel_medany" to be sure that PC-relative addressing is used as early_*() functions can be called from head.S with MMU-off and before relocation (if it would be needed at all for RISC-V) - fix code style --- Changes in V3: - reorder headers in alphabetical order - merge changes related to start_xen() function from "[PATCH v2 7/8] xen/riscv: print hello message from C env" to this patch - remove unneeded parentheses in definition of STACK_SIZE --- Changes in V2: - introduce STACK_SIZE define. - use consistent padding between instruction mnemonic and operand(s) --- xen/arch/riscv/Kconfig.debug | 5 +++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 44 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++ xen/arch/riscv/setup.c | 4 +++ 5 files changed, 66 insertions(+) create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug index e69de29bb2..608c9ff832 100644 --- a/xen/arch/riscv/Kconfig.debug +++ b/xen/arch/riscv/Kconfig.debug @@ -0,0 +1,5 @@ +config EARLY_PRINTK + bool "Enable early printk" + default DEBUG + help + Enables early printk debug messages diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index fd916e1004..1a4f1a6015 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,3 +1,4 @@ +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c new file mode 100644 index 0000000000..dfe4ad77e2 --- /dev/null +++ b/xen/arch/riscv/early_printk.c @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * RISC-V early printk using SBI + * + * Copyright (C) 2021 Bobby Eshleman + */ +#include +#include + +/* + * When the MMU is off during early boot, any C function called has to + * use PC-relative rather than absolute address because the physical address + * may not match the virtual address. + * + * To guarantee PC-relative address cmodel=medany should be used + */ +#ifndef __riscv_cmodel_medany +#error "early_*() can be called from head.S with MMU-off" +#endif + +/* + * TODO: + * sbi_console_putchar is already planned for deprecation + * so it should be reworked to use UART directly. +*/ +void early_puts(const char *s, size_t nr) +{ + while ( nr-- > 0 ) + { + if ( *s == '\n' ) + sbi_console_putchar('\r'); + sbi_console_putchar(*s); + s++; + } +} + +void early_printk(const char *str) +{ + while ( *str ) + { + early_puts(str, 1); + str++; + } +} diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h new file mode 100644 index 0000000000..05106e160d --- /dev/null +++ b/xen/arch/riscv/include/asm/early_printk.h @@ -0,0 +1,12 @@ +#ifndef __EARLY_PRINTK_H__ +#define __EARLY_PRINTK_H__ + +#include + +#ifdef CONFIG_EARLY_PRINTK +void early_printk(const char *str); +#else +static inline void early_printk(const char *s) {}; +#endif + +#endif /* __EARLY_PRINTK_H__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 13e24e2fe1..d09ffe1454 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,12 +1,16 @@ #include #include +#include + /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); void __init noreturn start_xen(void) { + early_printk("Hello from C env\n"); + for ( ;; ) asm volatile ("wfi"); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:49:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:49:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491101.760064 (Exim 4.92) (envelope-from ) id 1pPNPN-0003Jp-I0; Tue, 07 Feb 2023 12:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491101.760064; Tue, 07 Feb 2023 12:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPN-0003Ji-F4; Tue, 07 Feb 2023 12:49:13 +0000 Received: by outflank-mailman (input) for mailman id 491101; Tue, 07 Feb 2023 12:49:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPM-0003Jc-7k for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:49:12 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d19d08bc-a6e5-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 13:49:11 +0100 (CET) Received: by mail-wr1-x42c.google.com with SMTP id a2so13164080wrd.6 for ; Tue, 07 Feb 2023 04:49:11 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p10-20020a5d59aa000000b002be5401ef5fsm11468388wrr.39.2023.02.07.04.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:49:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d19d08bc-a6e5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4zkAUWp9Lxhlr3VSmKMwlZzj2U9syX3G3ZQDSxEtKDs=; b=alUaR2YHRN8AOm95OB86CMZSplcxFy0gBvAnfbanCDdbZVaLjwB0DrLosNyVpid2FC i7uQYNH6QlfUEsWoas0kyVQEYHFjaaAoI/T768CXRqE+wwB8bnpDfvWzwNFwejHNBZs8 jXWyoua0eKBCDkQgyjAAY4rXVu25ILDV1ZqXMERkpiuaEQZ2EKT0JAk7hYmGR5gxFm9U m5HCLUrOn+etxArpRFbUAG4vDFm9MtrWjaQxt27qBkugPH70fw2cNbaaITW7Y045seWh M/cGPI2JJThDDXC2xWNXpcw62Z4noBEhEwP55wL+LFuZO9YeFec62t45hVS2n/VJSK0z DXmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4zkAUWp9Lxhlr3VSmKMwlZzj2U9syX3G3ZQDSxEtKDs=; b=JFIqsjr5554w1rSMPa1/7Rnv2rt3NgOAsi0Gi8zgl6r4W69nSu7GUnW+RvgUJ9S3nX QYnIazH/YdrluStctnIWmPfjv9IaXUngFLZTBjaQgQuGgtbuAv+jZ7CN8jYrky9TyseZ tmbYXN0W99chXqRK0yemei/SAeJj0afMRCIR7Hd/BqgeZ2w37ckcDSZGv+PZ/LlU35mn zt2BL4zt+kIbUg634EngSTg+MJnUZ0I9mxdJlQC2Lu0AL1HXfyP8lqci5vPD2DudPjZZ BuCJc3a6fkXe5M8ntpiqhqhslLmg9r/5Dk5rL8W6A+c7IMXXmhrnMbEuMfsLYEozNdqA WuZA== X-Gm-Message-State: AO0yUKVfJybDSPKfTxX728EvL4kkajodJBae2qjrylhGw3AlsbpmpqZo KqOnTBwri/AOoKLbGYTSfVb+32+Edcs= X-Google-Smtp-Source: AK7set8nbfSycTUaWY/Sf0u5R8Nl3Mpvjk2TKArDTh55EsigXiThcS1XEpNpIF3oQb1e7oiZcVswmQ== X-Received: by 2002:a5d:524b:0:b0:2c3:ea65:cc7d with SMTP id k11-20020a5d524b000000b002c3ea65cc7dmr2910272wrc.55.1675774150757; Tue, 07 Feb 2023 04:49:10 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v10 0/2] Basic early_printk and smoke test implementation Date: Tue, 7 Feb 2023 14:49:04 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke test which checks if "Hello from C env" message is present in serial.tmp The patch series is rebased on top of the patch "include/types: move stddef.h-kind types to common header" [1] [1] https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@suse.com/ --- Changes in V10: - Add changes mentioned in V9 (forget to do in previous version) --- Changes in V9: - Bring "cmodel=medany" check back to be sure that C function is safe to be called in early boot when MMU is off ( e.g. VA != PA ) --- Changes in V8: - Set "needs: archlinux-current-gcc-riscv64-debug" in test.yaml for RISCV job as CONFIG_EARLY_PRINTK is available only when CONFIG_DEBUG is available. --- Changes in V7: - Fix dependecy for qemu-smoke-riscv64-gcc job --- Changes in V6: - Rename container name in test.yaml for .qemu-riscv64. --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed - All mentioned comments by Stefano in Xen mailing list will be fixed as a separate patch out of this patch series. --- Oleksii Kurochko (2): xen/riscv: introduce early_printk basic stuff automation: add RISC-V smoke test automation/gitlab-ci/test.yaml | 20 +++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 +++++++++++ xen/arch/riscv/Kconfig.debug | 5 +++ xen/arch/riscv/Makefile | 1 + xen/arch/riscv/early_printk.c | 44 +++++++++++++++++++++++ xen/arch/riscv/include/asm/early_printk.h | 12 +++++++ xen/arch/riscv/setup.c | 4 +++ 7 files changed, 106 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh create mode 100644 xen/arch/riscv/early_printk.c create mode 100644 xen/arch/riscv/include/asm/early_printk.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:49:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:49:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491104.760085 (Exim 4.92) (envelope-from ) id 1pPNPj-00048Q-23; Tue, 07 Feb 2023 12:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491104.760085; Tue, 07 Feb 2023 12:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPi-00048J-Uy; Tue, 07 Feb 2023 12:49:34 +0000 Received: by outflank-mailman (input) for mailman id 491104; Tue, 07 Feb 2023 12:49:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNPh-00046W-Ip for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:49:33 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3771746-a6e5-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:49:14 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id m14so13402669wrg.13 for ; Tue, 07 Feb 2023 04:49:14 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p10-20020a5d59aa000000b002be5401ef5fsm11468388wrr.39.2023.02.07.04.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:49:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3771746-a6e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MP+WeNW2jc2Ok92hlipZzRTFVcDRlzwQA/TTq4v+O/I=; b=ijge2m1L8mXGIjmudIc0kU36fafmyR/aA+gnU75YYhci+1GJAh2iHTGPrsfB9PCgQR qA0oY29GZS/BkzZrhDfh1iPudMganyHhPN56pW1cm9SFN4g+ThZEcdLKf9R3rnQ66lCp 8/dFSjHslmPOB6k1i+RdkVDcNjgg7ds4dKSA1eWyespJtmO4mRSCeDlI2uB9zb16WR9F yyAcbiqWih2kTKVSJTAevIzRC1xTyQi2gmwqnPV4mUeW5dKkBr4KoVLyyOlMP96F3ZRj sdShClQl/CPXEGeLfFxD1leWexz6Du2OWR9NA8ZiwKOvMOyenAYjeZh9TUzysaoWkiq5 7Q+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MP+WeNW2jc2Ok92hlipZzRTFVcDRlzwQA/TTq4v+O/I=; b=lBq47cpoHFZSEW1JZxxZ8jbLLdxyMJRtf2fd+blOIQq2uum3SeSVgmxF4twd934tzi ZrhW8uu8L3+94O338FFg8GYXEZgayw/nz+rwZQ2cKyNEEpClznw9IVYu/ISXnxUoR1Mj oryHHzm8Hyr48AvqHSSvPDL/CtOta1TJYf/8tcW/hkQpNf5BhiwDQT8jYeWGRubbj1c5 c2+qtpDaH1RiqF01nAT3ootz+3hXR2uGDjAPSx1H0vk07g7uha7Z3Hoj5gY5q03RM2zE /fSlBDYxGr4RccPwU915wFCQ5NpDHi/ocXBrmrcmEMn979HCgXd+CGqtSCxOHOpSmQb/ gIrA== X-Gm-Message-State: AO0yUKWWlLk0QddQnE37/txi00zkdPszbnZIRB6RTsYMn3WSJEFWYJ1t 2N9Fo/1cnxM30Cd8fNU0kgzPGE1LzZo= X-Google-Smtp-Source: AK7set+kc0WyAA33aAL78wgvE70Jl4mTk0DiCw/XKoqzJFSDdDbHgAgdleQvK2l+g3dGOc4T6IKK6w== X-Received: by 2002:adf:f5cd:0:b0:2c3:eff9:292e with SMTP id k13-20020adff5cd000000b002c3eff9292emr2757817wrp.22.1675774153845; Tue, 07 Feb 2023 04:49:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein , Alistair Francis Subject: [PATCH v10 2/2] automation: add RISC-V smoke test Date: Tue, 7 Feb 2023 14:49:06 +0200 Message-Id: <50fb97738c628108c2304856cc9755a83860fde9.1675773832.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Signed-off-by: Oleksii Kurochko Acked-by: Stefano Stabellini Reviewed-by: Alistair Francis --- Changes in V10: - Nothing changed --- Changes in V9: - Nothing changed --- Changes in V8: - Set "needs: archlinux-current-gcc-riscv64-debug" in test.yaml for RISCV job as CONFIG_EARLY_PRINTK is available only when CONFIG_DEBUG is available. --- Changes in V7: - Fix dependecy for qemu-smoke-riscv64-gcc job --- Changes in V6: - Rename container name in test.yaml for .qemu-riscv64. --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed - All mentioned comments by Stefano in Xen mailing list will be fixed as a separate patch out of this patch series. --- automation/gitlab-ci/test.yaml | 20 ++++++++++++++++++++ automation/scripts/qemu-smoke-riscv64.sh | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100755 automation/scripts/qemu-smoke-riscv64.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index afd80adfe1..ce543ef5c0 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -54,6 +54,19 @@ tags: - x86_64 +.qemu-riscv64: + extends: .test-jobs-common + variables: + CONTAINER: archlinux:current-riscv64 + LOGFILE: qemu-smoke-riscv64.log + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - x86_64 + .yocto-test: extends: .test-jobs-common script: @@ -234,6 +247,13 @@ qemu-smoke-x86-64-clang-pvh: needs: - debian-unstable-clang-debug +qemu-smoke-riscv64-gcc: + extends: .qemu-riscv64 + script: + - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} + needs: + - archlinux-current-gcc-riscv64-debug + # Yocto test jobs yocto-qemuarm64: extends: .yocto-test-arm64 diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh new file mode 100755 index 0000000000..e0f06360bc --- /dev/null +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -0,0 +1,20 @@ +#!/bin/bash + +set -ex + +# Run the test +rm -f smoke.serial +set +e + +timeout -k 1 2 \ +qemu-system-riscv64 \ + -M virt \ + -smp 1 \ + -nographic \ + -m 2g \ + -kernel binaries/xen \ + |& tee smoke.serial + +set -e +(grep -q "Hello from C env" smoke.serial) || exit 1 +exit 0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:50:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:50:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491116.760097 (Exim 4.92) (envelope-from ) id 1pPNQD-0005Sd-9o; Tue, 07 Feb 2023 12:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491116.760097; Tue, 07 Feb 2023 12:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNQD-0005S7-70; Tue, 07 Feb 2023 12:50:05 +0000 Received: by outflank-mailman (input) for mailman id 491116; Tue, 07 Feb 2023 12:50:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNQC-00046W-1P for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 12:50:04 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef389819-a6e5-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 13:50:01 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso13110085wms.0 for ; Tue, 07 Feb 2023 04:50:01 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id y10-20020a05600c364a00b003daf7721bb3sm18367359wmq.12.2023.02.07.04.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 04:50:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef389819-a6e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wwDH5rKguNe4LYAQep0fZVMYwtjqvHKEEtn5XlpSSj8=; b=DsSvCocG7COvE2P5JTV0ctSHEdAEyITF7TtKXGAApaxJOofKSCP+5AIuoGdRYorffZ dwNW3LwFqqPA62MYQCcY6Dm/Fg1d+arO4IHDGo6i3uPXUydD82yBxuz9ngr+7+ht3K1N 1c9rxf3QViisvEFg+3aeSIBztam8iextzvNmOcjhhDmD+YOMnDV25eq9JvQj4hLpAMsQ EKA7MCTpk1zxXU9spFCfBQ2TbNeSBXaPKqc6MmvCQfvo0s7NRLz012YqR51nf+U9Gzix lN6dGYfqYVQ+XRW6bc44tvtBqHvLqs/2J7fgbKZI/lwrq6gIIiz20XeMGtWpLpvfc43H cZ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wwDH5rKguNe4LYAQep0fZVMYwtjqvHKEEtn5XlpSSj8=; b=bU5CYmDSBzostB1Z4lL1GL1FYa2Gt2YNaYDVnhaHV9k8VZ/LKUxWoCxsUq0ezWEXlT 47OkCsYKrJLZRD3I2W4GBtGZptHVCZdKkjanDEwURFgahHN8Wo1SqVsry3SIGpZ/tsu6 D3RNqtOsl6jAO4Mq9Q85dnBhlZ5Q1bZA+Sto5KJ9TvIB16IeU0dzHwKL7nOiW1Et0gIa qBgQ6JO/XoYBdoyDnmKLAjwVDww4EwcmIeJIzkoIBbAwhcIq5THZ+TXEsSkAbed8o7fe izl64Gyov6UNdM1BEwC4E8QaNtfaKASmhB4QS437FFCzl4lUkOtOpq6O7Ry9dUpH9FIV MT7A== X-Gm-Message-State: AO0yUKVvnkxe3hmz86PYVhIfCMEnNMWkmE35vlGcB1/+yL93Tt4YTstP hBRkRZr65HvpNPy29X6Ksr/k7UGtVLY= X-Google-Smtp-Source: AK7set9lQAY/uJBLEp+GIMMCFGSzZrR0ZzVWFQdBn0add57cTVetW8WuazsnasSuICR2LFfYaKxB+Q== X-Received: by 2002:a05:600c:2e83:b0:3dc:5e16:37ea with SMTP id p3-20020a05600c2e8300b003dc5e1637eamr2911501wmn.30.1675774200494; Tue, 07 Feb 2023 04:50:00 -0800 (PST) Message-ID: <4a76a3910cbb53d271536a223c71d7a4ca3e73f8.camel@gmail.com> Subject: Re: [PATCH v9 0/2] Basic early_printk and smoke test implementation From: Oleksii To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Date: Tue, 07 Feb 2023 14:49:58 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi all, Please look at V10 and skip V9 as I missed to add the check with medany. Sorry. ~ Oleksii On Tue, 2023-02-07 at 14:41 +0200, Oleksii Kurochko wrote: > The patch series introduces the following: > - the minimal set of headers and changes inside them. > - SBI (RISC-V Supervisor Binary Interface) things necessary for basic > =C2=A0 early_printk implementation. > - things needed to set up the stack. > - early_printk() function to print only strings. > - RISC-V smoke test which checks if=C2=A0 "Hello from C env" message is > =C2=A0 present in serial.tmp >=20 > The patch series is rebased on top of the patch "include/types: move > stddef.h-kind types to common header" [1] >=20 > [1] > https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe4178d7@su= se.com/ >=20 > --- > Changes in V9: > =C2=A0- Bring "cmodel=3Dmedany" check back to be sure that C function is > safe to be called > =C2=A0=C2=A0 in early boot when MMU is off as=20 > --- > Changes in V8: > =C2=A0- Set "needs: archlinux-current-gcc-riscv64-debug" in test.yaml > =C2=A0=C2=A0 for RISCV job as CONFIG_EARLY_PRINTK is available only when > =C2=A0=C2=A0 CONFIG_DEBUG is available. > --- > Changes in V7: > =C2=A0- Fix dependecy for qemu-smoke-riscv64-gcc job > --- > Changes in V6: > =C2=A0- Rename container name in test.yaml for .qemu-riscv64. > --- > Changes in V5: > =C2=A0 - Nothing changed > --- > Changes in V4: > =C2=A0 - Nothing changed > --- > Changes in V3: > =C2=A0 - Nothing changed > =C2=A0 - All mentioned comments by Stefano in Xen mailing list will be > =C2=A0=C2=A0=C2=A0 fixed as a separate patch out of this patch series. > --- >=20 > Oleksii Kurochko (2): > =C2=A0 xen/riscv: introduce early_printk basic stuff > =C2=A0 automation: add RISC-V smoke test >=20 > =C2=A0automation/gitlab-ci/test.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 20 ++++++++++++++ > =C2=A0automation/scripts/qemu-smoke-riscv64.sh=C2=A0 | 20 ++++++++++++++ > =C2=A0xen/arch/riscv/Kconfig.debug=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 ++++ > =C2=A0xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 = 1 + > =C2=A0xen/arch/riscv/early_printk.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 33 > +++++++++++++++++++++++ > =C2=A0xen/arch/riscv/include/asm/early_printk.h | 12 +++++++++ > =C2=A0xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2= =A0 4 +++ > =C2=A07 files changed, 95 insertions(+) > =C2=A0create mode 100755 automation/scripts/qemu-smoke-riscv64.sh > =C2=A0create mode 100644 xen/arch/riscv/early_printk.c > =C2=A0create mode 100644 xen/arch/riscv/include/asm/early_printk.h >=20 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 12:54:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 12:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491126.760108 (Exim 4.92) (envelope-from ) id 1pPNUg-0006Tt-35; Tue, 07 Feb 2023 12:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491126.760108; Tue, 07 Feb 2023 12:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNUg-0006Tm-0C; Tue, 07 Feb 2023 12:54:42 +0000 Received: by outflank-mailman (input) for mailman id 491126; Tue, 07 Feb 2023 12:54:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNUe-0006TJ-OT; Tue, 07 Feb 2023 12:54:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNUe-0001Ix-LU; Tue, 07 Feb 2023 12:54:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNUe-0007GR-5A; Tue, 07 Feb 2023 12:54:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPNUe-0002yA-4X; Tue, 07 Feb 2023 12:54:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MyeBkJ7Ho1+RZb66HBoOU8tgRGXFAgnBR1zXdcYlq5s=; b=6henCkaabuUQYw1Ljzj0JQdaEa OUtdKiZU36nY6Z0ur54Ly1Cbx8f45e7JDPOVhllNvbNrhet4GZvACT1DsZ0TWGnSfkKpxkrxIhgzy R8Df+OM7EkNIdmwQl3miScKLHADd0u5PvNFMvFQQfOpT+BNjPQVNwGoHKNOxD4XCoHhc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176428: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3a59443c1d5ae0677a792c660ccd3796ce036732 X-Osstest-Versions-That: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e From: osstest service owner Date: Tue, 07 Feb 2023 12:54:40 +0000 flight 176428 xen-unstable real [real] flight 176451 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176428/ http://logs.test-lab.xenproject.org/osstest/logs/176451/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 176409 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 176451-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176409 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176409 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176409 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176409 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176409 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 3a59443c1d5ae0677a792c660ccd3796ce036732 baseline version: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e Last test of basis 176409 2023-02-06 01:53:25 Z 1 days Testing same since 176428 2023-02-06 17:07:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Bernhard Kaindl Christian Lindig Edwin Török Edwin Török Henry Wang Jan Beulich Juergen Gross Krister Johansen Marek Marczykowski-Górecki Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 407 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 07 13:01:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 13:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491143.760122 (Exim 4.92) (envelope-from ) id 1pPNax-00084b-Qn; Tue, 07 Feb 2023 13:01:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491143.760122; Tue, 07 Feb 2023 13:01:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNax-00084U-Ns; Tue, 07 Feb 2023 13:01:11 +0000 Received: by outflank-mailman (input) for mailman id 491143; Tue, 07 Feb 2023 13:01:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNaw-00084O-18 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 13:01:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPNav-0001Ss-AH; Tue, 07 Feb 2023 13:01:09 +0000 Received: from [54.239.6.184] (helo=[192.168.19.254]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPNav-0001sb-3F; Tue, 07 Feb 2023 13:01:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CGl5AJpT8mlXhiKot7RSXU8efAe90/C+/eAtEeF7bOA=; b=ODC0Yb06vqrEMpfTsdSjk1jF3M R55oY5h4zgnhLPVfrTVHMCe88AWrtMQ814uR+BZOjTJQVQ9uCzq24HFdit7R2IDglt13ENXba7WtN ++ndm5rjvsX+7mtPYVrpzJR9Ov6Qonj+F1JLRLANYW4/snBmOhSdSuiwUgBb8YRhcEuM=; Message-ID: <7255affa-a0f5-4388-2889-cb523a0246b0@xen.org> Date: Tue, 7 Feb 2023 13:01:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Xenia Ragiadakou , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> From: Julien Grall In-Reply-To: <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 07/02/2023 12:46, Xenia Ragiadakou wrote: > On 2/7/23 14:25, Julien Grall wrote: >> >> >> On 07/02/2023 10:46, Xenia Ragiadakou wrote: >>> >>> On 2/7/23 12:39, Julien Grall wrote: >>>> Hi, >>>> >>>> On 07/02/2023 10:23, Luca Fancellu wrote: >>>>> >>>>> >>>>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>>>> wrote: >>>>>> >>>>> >>>>> I’m not really a supporter of empty commit message, but it’s up to >>>>> the maintainer :) >>>> >>>> +1. In this case a brief summary of the rule would be handy for >>>> those that are not well-versed with MISRA. >>>> >>>> This can be dealt on commit if you propose a new commit message. >>> >>> I 'm refrained from stating the rule as is because it is strict and >>> it is not applied as is. >> >> I am a bit confused with this statement. From misra/..., we are >> supporting rule 20.7. So why aren't applying it strictly? >> >> And if it is not applied as-is, shouldn't we document the violation >> (if any)? > > I applied it strictly on v2, but there was no review. Ah! In general it is best to ping if there are no answers. > Then Eclair was adjusted to have a less strict approach. Still there is > a finding asking to add parentheses around dt in > dt_for_each_device_node(dt, dn), i.e dn = (dt);, to which AFAIK you object. Are you referring to the discussion in [1]? If so, I wasn't totally opposed to the suggestion so long we are consistent. > >> >>> >>> "Add parentheses around macro parameters when the precedence and >>> associativity of the performed operators can lead to unintended order >>> of evaluation." >>> >>> Is this ok? >> >> I am OK with this. Is there any ID from Eclair that could be used to >> track each error (and so we can confirm they have disappeared)? > > I am not aware of any. Hmmm ok. It might be a nice feature to suggest in Eclair because anyone can check whether an issue was resolved. Here, I don't exactly know what to check in Eclair. So I have to rely on you. Anyway, nothing that can be fixed for this commit. > > The patch can be decoupled from misra and Eclair (I mean have a generic > commit title) and just mention in the commit message that it fixes some > Eclair findings for MISRA C rule 20.7. I have a slight preference for a more generic title. But the current one also work for me. I will commit later on. Cheers, [1] b2f2d1e7-0c18-206f-5e9d-d0115e398840@xen.org > >> >> Cheers, >> > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 07 13:38:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 13:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491154.760132 (Exim 4.92) (envelope-from ) id 1pPOBD-0003T5-LB; Tue, 07 Feb 2023 13:38:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491154.760132; Tue, 07 Feb 2023 13:38:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOBD-0003Sy-IQ; Tue, 07 Feb 2023 13:38:39 +0000 Received: by outflank-mailman (input) for mailman id 491154; Tue, 07 Feb 2023 13:38:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOBC-0003Sn-4h for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 13:38:38 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9994c7e4-a6ec-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 14:38:14 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id bg5-20020a05600c3c8500b003e00c739ce4so2830976wmb.5 for ; Tue, 07 Feb 2023 05:38:14 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id o7-20020a05600002c700b002be5bdbe40csm12128975wry.27.2023.02.07.05.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 05:37:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9994c7e4-a6ec-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cm28rj9Az0U5hMacFDsUKTaBeJjioQqU2J6dR3p92Tg=; b=ILJQRtgZd7lX16j/WA8Lj/dGEeLZFfn+iFir7u0IH2rDTltxSs1I8igEN+PwwhbPO2 7oPURxm3NDk2RY3SNISQvtkRUUM3c5bE6h0zB2NCiojvedfiaS8DW5sG9d1Hcp1Q8tiv XOIeKIR8X0TsNR76X5xukwz7wjo5zEi2BG8BzOP+uN7HZPiGzvKTESqXoALG1gL1PhCF 4Y5UczT+FChIudEsGThZjXUVcVxusV1u1x+N7shOtTig1S7d0i1mZxdNjg33uMScZWe6 EdBRncMKieo77OitLf+bN8Tz0GahtSg5H7JnR1o+Thr8GwD/J9VUdlLmPmaWgcrbOU1s TzFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Cm28rj9Az0U5hMacFDsUKTaBeJjioQqU2J6dR3p92Tg=; b=Z6kkZys7l3hPLOLl1mUtbBRnnrkMk+dp9rSiji/PNrVXjWqEph6DTHeYarIzXmOedT G46h7cnImkzCQo6+oIx+4wxTvXESeAg3SnwQ6T+dwPWnzWVkoh9qQHtktZhzvAzAym/J HC+EQIaWvJvYDEijMwaLKAzIFmkATc9T4JcVEvAy88z7sfSg5DqKm+cM29/jx9Xgr6Ss d+und3F+oEnl0TALG74OxxXkPqXUjGkS8zqXXLO7NsPMv/WLULALxzB8Yjiul5hZHW+U QENMPCFDEvKP/XNsqP03WItw4DvfH2xYhEk5Gd0R+GV5q9OQeV90nrMDumu7WZClnJUj kc0g== X-Gm-Message-State: AO0yUKVANAox7luFcrP8eClhImzqkaz+S6E51CWQFZtzbfFjiYv4K5SG bgHiGyfkOSufnIPwgQ96qQMCUW6e7shu4haw X-Google-Smtp-Source: AK7set8RzcALzpamYdyKC4uDj9lXzPUP6SPGeGKJIRGB15faLUk1G6npuUQipZ/Ae90poRqUiAITHA== X-Received: by 2002:a05:600c:a291:b0:3dc:55e6:fffd with SMTP id hu17-20020a05600ca29100b003dc55e6fffdmr3188847wmb.15.1675777062052; Tue, 07 Feb 2023 05:37:42 -0800 (PST) Date: Tue, 7 Feb 2023 16:37:38 +0300 From: Dan Carpenter To: xen-devel@lists.xenproject.org Cc: Julia Lawall , Luis Chamberlain , Linus Torvalds , Hongchen Zhang , Alexander Viro , Andrew Morton , "Christian Brauner (Microsoft)" , David Howells , Mauro Carvalho Chehab , Eric Dumazet , "Fabio M. De Francesco" , Christophe JAILLET , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, maobibo , Matthew Wilcox , Sedat Dilek Subject: xen: sleeping in atomic warnings Message-ID: References: <20230129060452.7380-1-zhanghongchen@loongson.cn> <4ffbb0c8-c5d0-73b3-7a4e-2da9a7b03669@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: These are static checker warnings from Smatch. The line numbers are based on next-20230207. To reproduce these warnings then you need to have the latest Smatch from git and you need to rebuild the cross function probably four times. I have reviewed most of these and they all seem valid to me. I remember I reported some a while back but never heard back. https://lore.kernel.org/all/20210802144037.GA29540@kili/ regards, dan carpenter arch/x86/xen/p2m.c:189 alloc_p2m_page() warn: sleeping in atomic context xen_create_contiguous_region() <- disables preempt xen_destroy_contiguous_region() <- disables preempt -> xen_remap_exchanged_ptes() -> set_phys_to_machine() -> xen_alloc_p2m_entry() -> alloc_p2m_pmd() xen_alloc_p2m_entry() -> alloc_p2m_page() drivers/xen/events/events_base.c:1213 bind_evtchn_to_irq_chip() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> bind_evtchn_to_irqhandler() -> bind_evtchn_to_irqhandler_chip() -> bind_evtchn_to_irq_chip() drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c:303 netxen_pcie_sem_lock() warn: sleeping in atomic context netxen_nic_hw_write_wx_2M() <- disables preempt netxen_nic_hw_read_wx_2M() <- disables preempt -> netxen_pcie_sem_lock() drivers/xen/xen-pciback/pci_stub.c:110 pcistub_device_release() warn: sleeping in atomic context pcistub_get_pci_dev_by_slot() <- disables preempt pcistub_get_pci_dev() <- disables preempt -> pcistub_device_get_pci_dev() -> pcistub_device_put() -> pcistub_device_release() drivers/xen/xen-scsiback.c:1016 __scsiback_del_translation_entry() warn: sleeping in atomic context scsiback_del_translation_entry() <- disables preempt scsiback_release_translation_entry() <- disables preempt -> __scsiback_del_translation_entry() drivers/xen/xen-scsiback.c:276 scsiback_free_translation_entry() warn: sleeping in atomic context scsiback_del_translation_entry() <- disables preempt scsiback_release_translation_entry() <- disables preempt -> __scsiback_del_translation_entry() -> scsiback_free_translation_entry() drivers/xen/events/events_base.c:1427 unbind_from_irq() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> bind_evtchn_to_irqhandler() -> bind_evtchn_to_irqhandler_chip() -> unbind_from_irq() drivers/xen/xenbus/xenbus_client.c:473 xenbus_alloc_evtchn() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> xenbus_alloc_evtchn() drivers/xen/xenbus/xenbus_client.c:321 xenbus_dev_error() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> xenbus_free_evtchn() -> xenbus_dev_error() drivers/xen/xenbus/xenbus_client.c:342 xenbus_dev_fatal() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> xenbus_alloc_evtchn() -> xenbus_dev_fatal() drivers/xen/xenbus/xenbus_client.c:494 xenbus_free_evtchn() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> xenbus_free_evtchn() drivers/xen/xenbus/xenbus_client.c:290 xenbus_va_dev_error() warn: sleeping in atomic context pvcalls_front_connect() <- disables preempt pvcalls_front_accept() <- disables preempt -> create_active() -> xenbus_free_evtchn() -> xenbus_dev_error() create_active() -> xenbus_alloc_evtchn() -> xenbus_dev_fatal() -> xenbus_va_dev_error() From xen-devel-bounces@lists.xenproject.org Tue Feb 07 13:59:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 13:59:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491164.760146 (Exim 4.92) (envelope-from ) id 1pPOVL-0006DF-GL; Tue, 07 Feb 2023 13:59:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491164.760146; Tue, 07 Feb 2023 13:59:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOVL-0006D8-Di; Tue, 07 Feb 2023 13:59:27 +0000 Received: by outflank-mailman (input) for mailman id 491164; Tue, 07 Feb 2023 13:59:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOVK-0006D2-Rd for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 13:59:27 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a10e1cb5-a6ef-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 14:59:24 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id lu11so43379424ejb.3 for ; Tue, 07 Feb 2023 05:59:24 -0800 (PST) Received: from [192.168.1.93] ([188.73.237.113]) by smtp.gmail.com with ESMTPSA id x10-20020a1709060a4a00b00869f2ca6a87sm6880137ejf.135.2023.02.07.05.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 05:59:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a10e1cb5-a6ef-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eW5/IB9F0YU5jMiK2TgayIROIXd/2nQI7kaEe7D7zEM=; b=aFChJlXrWtiMqjRs+K+ZDRJ+HjaLVbXc7uST7+1Tz2invoFsg1DkmkPhKs+U5CLtFS 6c8FQP3NWjdqn8jv81nnt1/5d32i3s7a92PZ9ssAQ1PvaV2E2V3ZH4CbRBJJV4OEjfqR KC59MmYj7ykgSrDftn9FhQNo9XyUAQtKVE/8b+fpkyWIOS9XGPI3sB4QYGLDia5M4phD JbStSstHFtfJYqiNmj4eNJaTJdCJ4a5A4pVBmLm4KkXLqT2kXYQ+OeFgANrTvKo5uya4 X6x9dJvXF/e/Wbq3b3CG+QOE9BrtHMY3MQpoAuRhQwnoKW76PUcwp0AV99UYw5VBKo1+ +gYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eW5/IB9F0YU5jMiK2TgayIROIXd/2nQI7kaEe7D7zEM=; b=zYoO+t6vi8lqaUY6SWdGS7vc1CEy/4TbkUR7txJvb2H1hmkqbHIR4jPxt+9NYrFyta TeWnRsqsEc/p0a8JYLM+ZMlirDU/hfQreApnaOloHhrOKIe6tAS9Y4d4MRnSmkh5IQs+ V0713q5+n3hkqhTa+VQRUEDBmVV07XuG2I3doQlZRPROCsOIQM6B4wTnEZG01K8QqYJo 7vqhAobpPJ0eKERQNUXyjzyZsg8S0nXsLOmFpdsVji/uaQ4xqjTzXnwOAGkTzTCftpyh G4vsIi3t62sKX0JpOrcCosHhsnp+AzyST6ek6h92AMxrTUuGv5CTEZI864M8Rtk3D/Rg oeYw== X-Gm-Message-State: AO0yUKUrCeIbb9gfCh7a/UIORGmEOwntHSrtLJ7z3p/Eadp+5aaMK+LT V2/LMEu4yNP8gCM05P/1gScZnV0TzEU= X-Google-Smtp-Source: AK7set/1ooOfoEzS/KINe2zxtNf7BZmWL8TyXRDbF5bGxEE0tq5DsUcThgzg8zaoH9bBpmpqfvpEhg== X-Received: by 2002:a17:906:fa18:b0:878:54e3:e3e1 with SMTP id lo24-20020a170906fa1800b0087854e3e3e1mr3559535ejb.73.1675778364563; Tue, 07 Feb 2023 05:59:24 -0800 (PST) Message-ID: <916d173e-16c2-8cde-5815-e8c0396eda04@gmail.com> Date: Tue, 7 Feb 2023 15:59:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Julien Grall , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> <7255affa-a0f5-4388-2889-cb523a0246b0@xen.org> From: Xenia Ragiadakou In-Reply-To: <7255affa-a0f5-4388-2889-cb523a0246b0@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 2/7/23 15:01, Julien Grall wrote: > Hi, > > On 07/02/2023 12:46, Xenia Ragiadakou wrote: >> On 2/7/23 14:25, Julien Grall wrote: >>> >>> >>> On 07/02/2023 10:46, Xenia Ragiadakou wrote: >>>> >>>> On 2/7/23 12:39, Julien Grall wrote: >>>>> Hi, >>>>> >>>>> On 07/02/2023 10:23, Luca Fancellu wrote: >>>>>> >>>>>> >>>>>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>>>>> wrote: >>>>>>> >>>>>> >>>>>> I’m not really a supporter of empty commit message, but it’s up to >>>>>> the maintainer :) >>>>> >>>>> +1. In this case a brief summary of the rule would be handy for >>>>> those that are not well-versed with MISRA. >>>>> >>>>> This can be dealt on commit if you propose a new commit message. >>>> >>>> I 'm refrained from stating the rule as is because it is strict and >>>> it is not applied as is. >>> >>> I am a bit confused with this statement. From misra/..., we are >>> supporting rule 20.7. So why aren't applying it strictly? >>> >>> And if it is not applied as-is, shouldn't we document the violation >>> (if any)? >> >> I applied it strictly on v2, but there was no review. > > Ah! In general it is best to ping if there are no answers. Me too I ve forgotten about it. A ticket in gitlab reminded me that it was pending. > >> Then Eclair was adjusted to have a less strict approach. Still there >> is a finding asking to add parentheses around dt in >> dt_for_each_device_node(dt, dn), i.e dn = (dt);, to which AFAIK you >> object. > > Are you referring to the discussion in [1]? If so, I wasn't totally > opposed to the suggestion so long we are consistent. I am not able to find [1]. I 'm referring to the discussion in 20221220085100.22848-6-luca.fancellu@arm.com and 20220728134943.1185621-1-burzalodowa@gmail.com > >> >>> >>>> >>>> "Add parentheses around macro parameters when the precedence and >>>> associativity of the performed operators can lead to unintended >>>> order of evaluation." >>>> >>>> Is this ok? >>> >>> I am OK with this. Is there any ID from Eclair that could be used to >>> track each error (and so we can confirm they have disappeared)? >> >> I am not aware of any. > Hmmm ok. It might be a nice feature to suggest in Eclair because anyone > can check whether an issue was resolved. Currently, the violations in Eclair are reported per macro call (I guess because it is acceptable to have parentheses around the macro args) so it is difficult to track all of them. > > Here, I don't exactly know what to check in Eclair. So I have to rely on > you. Anyway, nothing that can be fixed for this commit. > >> >> The patch can be decoupled from misra and Eclair (I mean have a >> generic commit title) and just mention in the commit message that it >> fixes some Eclair findings for MISRA C rule 20.7. > > I have a slight preference for a more generic title. But the current one > also work for me. It can be changed into "xen/device_tree: add parentheses around macro parameters" > > I will commit later on. Do you want me to send a v4? > > Cheers, > > [1] b2f2d1e7-0c18-206f-5e9d-d0115e398840@xen.org >> >>> >>> Cheers, >>> >> > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:03:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491172.760161 (Exim 4.92) (envelope-from ) id 1pPOZJ-0007hd-3E; Tue, 07 Feb 2023 14:03:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491172.760161; Tue, 07 Feb 2023 14:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOZI-0007hW-W0; Tue, 07 Feb 2023 14:03:32 +0000 Received: by outflank-mailman (input) for mailman id 491172; Tue, 07 Feb 2023 14:03:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPOZH-0007hQ-Rf for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:03:31 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d3a8384-a6f0-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:03:20 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9774938B13; Tue, 7 Feb 2023 14:03:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 15351139ED; Tue, 7 Feb 2023 14:03:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E93JAyda4mNlAwAAMHmgww (envelope-from ); Tue, 07 Feb 2023 14:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d3a8384-a6f0-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675778599; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aqWjYHqVE8IvaN3952TdpK0BSSvIahWB7+QeuDQju0E=; b=Z+sNqKMBUcr9PbS8JeE5I2eNwQCHKlA7YsRnX1vfF9u9qVANR71qfA6hfqriiyCLd+A2Er 7w/L+SecSxDsWrc9hzFu3BvqbVocAAFx2nOjyaMPiYKyFPRgoFrUSKvuu2VGQyq6qSezaO 59vLyZ33Nzgx+F2rcVJL5N1Xtxok7JM= Message-ID: Date: Tue, 7 Feb 2023 15:03:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Dan Carpenter , xen-devel@lists.xenproject.org Cc: Julia Lawall , Luis Chamberlain , Linus Torvalds , Hongchen Zhang , Alexander Viro , Andrew Morton , "Christian Brauner (Microsoft)" , David Howells , Mauro Carvalho Chehab , Eric Dumazet , "Fabio M. De Francesco" , Christophe JAILLET , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, maobibo , Matthew Wilcox , Sedat Dilek References: <20230129060452.7380-1-zhanghongchen@loongson.cn> <4ffbb0c8-c5d0-73b3-7a4e-2da9a7b03669@inria.fr> From: Juergen Gross Subject: Re: xen: sleeping in atomic warnings In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8Cy4GAJEf0mO30TJKVjHugHL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8Cy4GAJEf0mO30TJKVjHugHL Content-Type: multipart/mixed; boundary="------------ISvi0mubQ4jvNED1SOA4tE7c"; protected-headers="v1" From: Juergen Gross To: Dan Carpenter , xen-devel@lists.xenproject.org Cc: Julia Lawall , Luis Chamberlain , Linus Torvalds , Hongchen Zhang , Alexander Viro , Andrew Morton , "Christian Brauner (Microsoft)" , David Howells , Mauro Carvalho Chehab , Eric Dumazet , "Fabio M. De Francesco" , Christophe JAILLET , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, maobibo , Matthew Wilcox , Sedat Dilek Message-ID: Subject: Re: xen: sleeping in atomic warnings References: <20230129060452.7380-1-zhanghongchen@loongson.cn> <4ffbb0c8-c5d0-73b3-7a4e-2da9a7b03669@inria.fr> In-Reply-To: --------------ISvi0mubQ4jvNED1SOA4tE7c Content-Type: multipart/mixed; boundary="------------iyE4cjBPZ5UxfPZspDcYBu0a" --------------iyE4cjBPZ5UxfPZspDcYBu0a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDIuMjMgMTQ6MzcsIERhbiBDYXJwZW50ZXIgd3JvdGU6DQo+IFRoZXNlIGFyZSBz dGF0aWMgY2hlY2tlciB3YXJuaW5ncyBmcm9tIFNtYXRjaC4gIFRoZSBsaW5lIG51bWJlcnMg YXJlDQo+IGJhc2VkIG9uIG5leHQtMjAyMzAyMDcuICBUbyByZXByb2R1Y2UgdGhlc2Ugd2Fy bmluZ3MgdGhlbiB5b3UgbmVlZCB0bw0KPiBoYXZlIHRoZSBsYXRlc3QgU21hdGNoIGZyb20g Z2l0IGFuZCB5b3UgbmVlZCB0byByZWJ1aWxkIHRoZSBjcm9zcw0KPiBmdW5jdGlvbiBwcm9i YWJseSBmb3VyIHRpbWVzLiAgSSBoYXZlIHJldmlld2VkIG1vc3Qgb2YgdGhlc2UgYW5kIHRo ZXkNCj4gYWxsIHNlZW0gdmFsaWQgdG8gbWUuICBJIHJlbWVtYmVyIEkgcmVwb3J0ZWQgc29t ZSBhIHdoaWxlIGJhY2sgYnV0IG5ldmVyDQo+IGhlYXJkIGJhY2suICBodHRwczovL2xvcmUu a2VybmVsLm9yZy9hbGwvMjAyMTA4MDIxNDQwMzcuR0EyOTU0MEBraWxpLw0KPiANCj4gcmVn YXJkcywNCj4gZGFuIGNhcnBlbnRlcg0KPiANCj4gYXJjaC94ODYveGVuL3AybS5jOjE4OSBh bGxvY19wMm1fcGFnZSgpIHdhcm46IHNsZWVwaW5nIGluIGF0b21pYyBjb250ZXh0DQo+IHhl bl9jcmVhdGVfY29udGlndW91c19yZWdpb24oKSA8LSBkaXNhYmxlcyBwcmVlbXB0DQo+IHhl bl9kZXN0cm95X2NvbnRpZ3VvdXNfcmVnaW9uKCkgPC0gZGlzYWJsZXMgcHJlZW1wdA0KPiAt PiB4ZW5fcmVtYXBfZXhjaGFuZ2VkX3B0ZXMoKQ0KPiAgICAgLT4gc2V0X3BoeXNfdG9fbWFj aGluZSgpDQo+ICAgICAgICAtPiB4ZW5fYWxsb2NfcDJtX2VudHJ5KCkNCj4gICAgICAgICAg IC0+IGFsbG9jX3AybV9wbWQoKQ0KPiB4ZW5fYWxsb2NfcDJtX2VudHJ5KCkgPGR1cGxpY2F0 ZT4NCj4gICAgICAgICAgICAgIC0+IGFsbG9jX3AybV9wYWdlKCkNCg0KVGhvc2UgYWxsb2Nh dGlvbnMgY2FuJ3QgYmUgcmVhY2hlZCBhZnRlciBlYXJseSBib290Lg0KDQo+IGRyaXZlcnMv eGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jOjEyMTMgYmluZF9ldnRjaG5fdG9faXJxX2NoaXAo KSB3YXJuOiBzbGVlcGluZyBpbiBhdG9taWMgY29udGV4dA0KPiBwdmNhbGxzX2Zyb250X2Nv bm5lY3QoKSA8LSBkaXNhYmxlcyBwcmVlbXB0DQo+IHB2Y2FsbHNfZnJvbnRfYWNjZXB0KCkg PC0gZGlzYWJsZXMgcHJlZW1wdA0KPiAtPiBjcmVhdGVfYWN0aXZlKCkNCj4gICAgIC0+IGJp bmRfZXZ0Y2huX3RvX2lycWhhbmRsZXIoKQ0KPiAgICAgICAgLT4gYmluZF9ldnRjaG5fdG9f aXJxaGFuZGxlcl9jaGlwKCkNCj4gICAgICAgICAgIC0+IGJpbmRfZXZ0Y2huX3RvX2lycV9j aGlwKCkNCg0KWWVzLCB0aGF0IG9uZSBsb29rcyB2ZXJ5IHN1c3BpY2lvdXMuIEJhc2ljYWxs eSB0aGUgc2FtZSBwcm9ibGVtIGFzIGFsbA0KdGhlIG90aGVyIHB2Y2FsbHMgaXNzdWVzIGJl bG93Lg0KDQo+IGRyaXZlcnMvbmV0L2V0aGVybmV0L3Fsb2dpYy9uZXR4ZW4vbmV0eGVuX25p Y19ody5jOjMwMyBuZXR4ZW5fcGNpZV9zZW1fbG9jaygpIHdhcm46IHNsZWVwaW5nIGluIGF0 b21pYyBjb250ZXh0DQo+IG5ldHhlbl9uaWNfaHdfd3JpdGVfd3hfMk0oKSA8LSBkaXNhYmxl cyBwcmVlbXB0DQo+IG5ldHhlbl9uaWNfaHdfcmVhZF93eF8yTSgpIDwtIGRpc2FibGVzIHBy ZWVtcHQNCj4gLT4gbmV0eGVuX3BjaWVfc2VtX2xvY2soKQ0KDQpUaGlzIGlzIG5vdCBYZW4g cmVsYXRlZC4NCg0KPiBkcml2ZXJzL3hlbi94ZW4tcGNpYmFjay9wY2lfc3R1Yi5jOjExMCBw Y2lzdHViX2RldmljZV9yZWxlYXNlKCkgd2Fybjogc2xlZXBpbmcgaW4gYXRvbWljIGNvbnRl eHQNCj4gcGNpc3R1Yl9nZXRfcGNpX2Rldl9ieV9zbG90KCkgPC0gZGlzYWJsZXMgcHJlZW1w dA0KPiBwY2lzdHViX2dldF9wY2lfZGV2KCkgPC0gZGlzYWJsZXMgcHJlZW1wdA0KPiAtPiBw Y2lzdHViX2RldmljZV9nZXRfcGNpX2RldigpDQo+ICAgICAtPiBwY2lzdHViX2RldmljZV9w dXQoKQ0KPiAgICAgICAgLT4gcGNpc3R1Yl9kZXZpY2VfcmVsZWFzZSgpDQoNClNlZW1zIHRv cCBiZSBwcm9ibGVtYXRpYywgdG9vLg0KDQo+IGRyaXZlcnMveGVuL3hlbi1zY3NpYmFjay5j OjEwMTYgX19zY3NpYmFja19kZWxfdHJhbnNsYXRpb25fZW50cnkoKSB3YXJuOiBzbGVlcGlu ZyBpbiBhdG9taWMgY29udGV4dA0KPiBzY3NpYmFja19kZWxfdHJhbnNsYXRpb25fZW50cnko KSA8LSBkaXNhYmxlcyBwcmVlbXB0DQo+IHNjc2liYWNrX3JlbGVhc2VfdHJhbnNsYXRpb25f ZW50cnkoKSA8LSBkaXNhYmxlcyBwcmVlbXB0DQo+IC0+IF9fc2NzaWJhY2tfZGVsX3RyYW5z bGF0aW9uX2VudHJ5KCkNCg0KTmVlZHMgZml4aW5nIChzYW1lIGZpeCBhcyB0aGUgb3RoZXIg c2NzaWJhY2sgaXNzdWUpLg0KDQpUaGFua3MgZm9yIHRoZSByZXBvcnRzLA0KDQoNCkp1ZXJn ZW4NCg== --------------iyE4cjBPZ5UxfPZspDcYBu0a Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------iyE4cjBPZ5UxfPZspDcYBu0a-- --------------ISvi0mubQ4jvNED1SOA4tE7c-- --------------8Cy4GAJEf0mO30TJKVjHugHL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPiWiYFAwAAAAAACgkQsN6d1ii/Ey/x Hgf+P2Hd8pWhpiMwq3X+xYM/xtj+fvlGoOrT0aNfmaplCixttNBdSZw/MuMAIkqodiNp6uHap9tk 2/Jfcf9JwTgNRcdr23SNSMPGh86R3JKF/qaCMfM8wifYktD/meNw0Vs1ZW5xw8QZOCwqe9jqv3Hz CQKBeHTEeH9uDb4wql8A6gao/2tnusvveVESAF98OoP1cPv7vuB4ylG+4kyjOp5WqvfT37xrmP6R mhfe9AdX3MLEAFefFXDmxMHbxaRk5ZMCt5Y3HKiUpIJEPWPzXmJyVMY2DhHMKwm6WYVH5fFnGs8T y/UMp78Wic3f7u3tNzjylhrnaKthkCrhwKVmmxTGkg== =qKRH -----END PGP SIGNATURE----- --------------8Cy4GAJEf0mO30TJKVjHugHL-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491191.760238 (Exim 4.92) (envelope-from ) id 1pPPFT-0005gH-I1; Tue, 07 Feb 2023 14:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491191.760238; Tue, 07 Feb 2023 14:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFT-0005fy-D1; Tue, 07 Feb 2023 14:47:07 +0000 Received: by outflank-mailman (input) for mailman id 491191; Tue, 07 Feb 2023 14:47:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFS-0004Hz-2b for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:06 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 494ab1a0-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:47:04 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id k13so6389521wrh.8 for ; Tue, 07 Feb 2023 06:47:04 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 494ab1a0-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1IWBP/c/EbKTMCf14sIBroBxkMgK54lnL7TJ/513lNY=; b=CtviIgm8AaS4DYuEaApnP1r3gcW3M7UdSzlg9Q8u22X7wARj1QHliZmPoWwPQBWUO9 vPkMQEGLIexFkjROpkIW3suirI7ZM+I5MLqSJhbDcNC01ycS3C8hGcRPyl3U/7WJO7wm UNj8U2r1FqMQ4GYkEWBXE7EvhkqlTQi6RlUxyAQMATafxQ8l4ssVag5UyjRHaw61bUwz LaYP66gtOP5OgdadX9savLvQRuh2U01jU3H65rDS33CB1mDR7fuqtGZyjcxuI8hCb8rj FvssQZg0fJdrxK9cPLJFXY2zH4yYX89JYjKfiVNieLE25TDtPPuOQitgT3YVRCz+sJi2 aZxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1IWBP/c/EbKTMCf14sIBroBxkMgK54lnL7TJ/513lNY=; b=rWnKtPSJTghKtCqutKdR53ErSu4S0KMLvysYQS4is8Ltjp0Ylwp/YdaLCI5n8f35sh mUD/NA7mJ24FGybW7e1Cd0o1Vzzxdu2gqjZhVQ8n472hPwT4znxp90RYtjSjZbp0E0+m xnXNyoIQqz1NYaPqGhBMoDaE736MatXmIhIuocHDcyR4hV0Tu3XM92VocZgJA5IfC1NI 2cJCpszIWy4MEcvuU54VirxR8smDnvgC/nkMUOSRpHKQuioqmSRkGU+fzSAW3oi8l7L/ C/v6KA91kB9HdoauPi+4w8+cJPGrXHo5050nfaXOwIweDiRFH/u55U8MEGuZguu0h8Rl e88w== X-Gm-Message-State: AO0yUKWb4bip0RD6TktYZbGsIwjGztPS6a3FybDqf2+I6rjRUwocXCyz 3TgwW7v97NMIDj9NI7xhPaymbzCdlo4= X-Google-Smtp-Source: AK7set9YiHlqT9aQFOz4wGaj3dmu1SfoPfk/N58GChYLcYQNCgxnYBdDubbZaXWJsg1DXIv6Cv7oSg== X-Received: by 2002:adf:f212:0:b0:2c3:f021:da5c with SMTP id p18-20020adff212000000b002c3f021da5cmr2976082wro.29.1675781223513; Tue, 07 Feb 2023 06:47:03 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 06/14] xen/riscv: introduce empty Date: Tue, 7 Feb 2023 16:46:41 +0200 Message-Id: <426a20fc179d642f5fb300e528de6f3835f6975a.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To include is required Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V3: - Add Acked-by: Alistair Francis --- Changes in V2: - is a new empty header which is required to include --- xen/arch/riscv/include/asm/cache.h | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 xen/arch/riscv/include/asm/cache.h diff --git a/xen/arch/riscv/include/asm/cache.h b/xen/arch/riscv/include/asm/cache.h new file mode 100644 index 0000000000..69573eb051 --- /dev/null +++ b/xen/arch/riscv/include/asm/cache.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _ASM_RISCV_CACHE_H +#define _ASM_RISCV_CACHE_H + +#endif /* _ASM_RISCV_CACHE_H */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491194.760265 (Exim 4.92) (envelope-from ) id 1pPPFX-0006Ls-OR; Tue, 07 Feb 2023 14:47:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491194.760265; Tue, 07 Feb 2023 14:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFX-0006LK-F9; Tue, 07 Feb 2023 14:47:11 +0000 Received: by outflank-mailman (input) for mailman id 491194; Tue, 07 Feb 2023 14:47:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFV-00043Z-VI for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:09 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c5cba88-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:09 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id bk16so13778586wrb.11 for ; Tue, 07 Feb 2023 06:47:09 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c5cba88-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=04wjIppSfpPVzws51Ad11YsV3qJmgS4kPG4tQJfLNf4=; b=XMoJV8dR5z5URnSW1pHXG2651WmE6/cAqmSUSIR74AEw1drpof1nTXEMFr+X0CVnQC ruyHe1M2Hjp0xQXl5lTu3BdqAKgn8u7w+YFTAQipFc9Mf1fjGn8aU3TLFEc2DTYHWOTh /x0YDoKGi0e9bUNbkEPsUnXG3OZ305OEaRMssmoJSpYnqTjrjfZ5hGu8UJkr+MUR/bKH ZrulfUzrqOHr+1yG+dLWGeDrm8U5AFXl8kM7dD3VDA/GHNrJjorsD183IR+m/iPqPQWE IB6BL56WOY0ATYXIJF/NODYlUdL2M8ljUeWWNMEtsiriC5u2zm0901GoAJufvqsm1B0M 39lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=04wjIppSfpPVzws51Ad11YsV3qJmgS4kPG4tQJfLNf4=; b=VfkJt/uc6YfZvvCtOH5714g8KSy/kFTkGD+FvkUT5Q8Ymlpw8eaMY8uNhNvCBCorMe C/Xnv9jNfGEzBD3FbJRm+JECzkRSSowgoC67ZtXUx6Y4e4ffKbx4A81J3E5/kPYOK5M3 kyUMN5PUsgJk3gIE6/BL/kPBBpE0OgwaFUcz8iLUdUOUlXM9yYTzpIEQ0G1MKjJ/Mtt9 fMhtw9ue7K8tsGkehjJH5lx/nqikY/NTeBj85C3rQhgowUw/ecAkTIXGT60sKh/VHGO5 WLH2k/qiI8hOgUwkslqZpYwcngPgDDksljo0FygQ+z2kfD3cVQE0spu+oje8/sJp+Fl4 oi2w== X-Gm-Message-State: AO0yUKXHYBnYYpvmIKqnfch662noJEulKbes7A2TvyivQijRkPSOptmn LuBCkLlvFrtVaspxaUAXG8tZ0poan1s= X-Google-Smtp-Source: AK7set/prRVjtdCwcu9cls5uhEUisXXJMLQcxLikFdoRBcez7hQhMakYkkCy/B2mJ/m3CNweMzJqQA== X-Received: by 2002:adf:db88:0:b0:2bf:ec8b:3a5 with SMTP id u8-20020adfdb88000000b002bfec8b03a5mr3517884wri.46.1675781228864; Tue, 07 Feb 2023 06:47:08 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 10/14] xen/riscv: mask all interrupts Date: Tue, 7 Feb 2023 16:46:45 +0200 Message-Id: <9fb09c8b7fd5c0caf1e577788e173ee6ecceac79.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes in V2: - Add Reviewed-by to the commit message --- xen/arch/riscv/riscv64/head.S | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index d444dd8aad..ffd95f9f89 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -1,6 +1,11 @@ +#include + .section .text.header, "ax", %progbits ENTRY(start) + /* Mask all interrupts */ + csrw CSR_SIE, zero + la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491193.760260 (Exim 4.92) (envelope-from ) id 1pPPFX-0006J4-7F; Tue, 07 Feb 2023 14:47:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491193.760260; Tue, 07 Feb 2023 14:47:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFX-0006Id-3N; Tue, 07 Feb 2023 14:47:11 +0000 Received: by outflank-mailman (input) for mailman id 491193; Tue, 07 Feb 2023 14:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFV-0004Hz-4j for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:09 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b1400ea-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:47:07 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id m14so13759855wrg.13 for ; Tue, 07 Feb 2023 06:47:07 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b1400ea-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oi5DCBZSkuvSDM/z9ivzbbaEYK1y6oIa/0SJ8j9gemI=; b=eIswdB6VeglcjRbBDpI8+zM5jevHk6HrUHXIx6qx6KIzdOl3zd3g8Td+eDCkZ3XrD+ dhKMpHY+8/jS1P0rgaVBu6wYW6jmLZ4iaA8h8/fT1xRaHmQrimtsXJ4EJpm6rSVnnaKC 7CAaO4Q71Nvks0OWtE/kVOX5dAvyGS+u662BopXaQx/tj8+fJ4t00r3NU9QS4Tx8AlPS 9jETBCBPGiaeObyJx1QwDCSbTI6xJUbUfQD1tckhXK+RE34lyQI2di2w8wBf0Q/OC9jT fIxPrup2kIyqwLH9VOobgUObxoOFN3Yx49wSNYtGfk9z9fdcN25qjHUid8J6FpdMvoWL ZWSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oi5DCBZSkuvSDM/z9ivzbbaEYK1y6oIa/0SJ8j9gemI=; b=MDS5s1ru03EyqwbmZSh//az6L6AuP+Mm1z6QWg0XsmqCDqlEc0yEd9Pcvo4L13YkSp nSOz3D5Ya0OQSpIH7tEDhTItRnUosk7j6yMEASHC+rlq1C1wL5gXAFLRS+JrEIGvrQeD Zm5IQjL3i4D8el+uLzUmKDDv6g0wfS+JajqPr6XeQpkR7cCAYlQiI67ZOT19Ce+xnsOe OlPLJwj/DIuj4v1+sjO6/6MdhSEaez2CWit3Wvb70jAU0dAp9NkF0rM4gkBmBBJRaleO 2z/jtX/4qcN8vZGP130hvNS6mTSI2IHImBfSlMyDQ/EwNQ6N7aN0pUzp1+aFFLfXAQNg bWKQ== X-Gm-Message-State: AO0yUKVLpXVJnXwE5g2Z5Alr54E+AX6BXoGFlX1GCNwHJQbGoI0uodBl a3clRDpMEPbDd0uVdVDgv+Z4Apa+TpA= X-Google-Smtp-Source: AK7set9GC8uo+fLEbxV24Az69fz4r4X2+GU8mXoIYCHS44ACCVdzGaKQjn+K3rwZV+BSuuuqf7r9nA== X-Received: by 2002:a05:6000:18ca:b0:2c3:db9e:4b06 with SMTP id w10-20020a05600018ca00b002c3db9e4b06mr3018255wrq.45.1675781226491; Tue, 07 Feb 2023 06:47:06 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation Date: Tue, 7 Feb 2023 16:46:43 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces an implementation of basic exception handlers: - to save/restore context - to handle an exception itself. The handler calls wait_for_interrupt now, nothing more. Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Refactor entry.S to start using of defines introduced in asm_offsets.C - Rename {__,}handle_exception to handle_trap() and do_trap() to be more consistent with RISC-V spec. - Wrap handle_trap() to ENTRY(). --- xen/arch/riscv/Makefile | 2 + xen/arch/riscv/entry.S | 94 ++++++++++++++++++++++++++++++ xen/arch/riscv/include/asm/traps.h | 13 +++++ xen/arch/riscv/traps.c | 13 +++++ 4 files changed, 122 insertions(+) create mode 100644 xen/arch/riscv/entry.S create mode 100644 xen/arch/riscv/include/asm/traps.h create mode 100644 xen/arch/riscv/traps.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 1a4f1a6015..443f6bf15f 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,7 +1,9 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o +obj-y += entry.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o +obj-y += traps.o $(TARGET): $(TARGET)-syms $(OBJCOPY) -O binary -S $< $@ diff --git a/xen/arch/riscv/entry.S b/xen/arch/riscv/entry.S new file mode 100644 index 0000000000..0be543f8e0 --- /dev/null +++ b/xen/arch/riscv/entry.S @@ -0,0 +1,94 @@ +#include +#include +#include +#include +#include + +/* WIP: only works while interrupting Xen context */ +ENTRY(handle_trap) + + /* Exceptions from xen */ +save_to_stack: + /* Save context to stack */ + REG_S sp, (CPU_USER_REGS_SP - CPU_USER_REGS_SIZE) (sp) + addi sp, sp, -CPU_USER_REGS_SIZE + REG_S t0, CPU_USER_REGS_T0(sp) + + /* Save registers */ + REG_S ra, CPU_USER_REGS_RA(sp) + REG_S gp, CPU_USER_REGS_GP(sp) + REG_S t1, CPU_USER_REGS_T1(sp) + REG_S t2, CPU_USER_REGS_T2(sp) + REG_S s0, CPU_USER_REGS_S0(sp) + REG_S s1, CPU_USER_REGS_S1(sp) + REG_S a0, CPU_USER_REGS_A0(sp) + REG_S a1, CPU_USER_REGS_A1(sp) + REG_S a2, CPU_USER_REGS_A2(sp) + REG_S a3, CPU_USER_REGS_A3(sp) + REG_S a4, CPU_USER_REGS_A4(sp) + REG_S a5, CPU_USER_REGS_A5(sp) + REG_S a6, CPU_USER_REGS_A6(sp) + REG_S a7, CPU_USER_REGS_A7(sp) + REG_S s2, CPU_USER_REGS_S2(sp) + REG_S s3, CPU_USER_REGS_S3(sp) + REG_S s4, CPU_USER_REGS_S4(sp) + REG_S s5, CPU_USER_REGS_S5(sp) + REG_S s6, CPU_USER_REGS_S6(sp) + REG_S s7, CPU_USER_REGS_S7(sp) + REG_S s8, CPU_USER_REGS_S8(sp) + REG_S s9, CPU_USER_REGS_S9(sp) + REG_S s10,CPU_USER_REGS_S10(sp) + REG_S s11,CPU_USER_REGS_S11(sp) + REG_S t3, CPU_USER_REGS_T3(sp) + REG_S t4, CPU_USER_REGS_T4(sp) + REG_S t5, CPU_USER_REGS_T5(sp) + REG_S t6, CPU_USER_REGS_T6(sp) + csrr t0, CSR_SEPC + REG_S t0, CPU_USER_REGS_SEPC(sp) + csrr t0, CSR_SSTATUS + REG_S t0, CPU_USER_REGS_SSTATUS(sp) + + mv a0, sp + jal do_trap + +restore_registers: + /* Restore stack_cpu_regs */ + REG_L t0, CPU_USER_REGS_SEPC(sp) + csrw CSR_SEPC, t0 + REG_L t0, CPU_USER_REGS_SSTATUS(sp) + csrw CSR_SSTATUS, t0 + + REG_L ra, CPU_USER_REGS_RA(sp) + REG_L gp, CPU_USER_REGS_GP(sp) + REG_L t0, CPU_USER_REGS_T0(sp) + REG_L t1, CPU_USER_REGS_T1(sp) + REG_L t2, CPU_USER_REGS_T2(sp) + REG_L s0, CPU_USER_REGS_S0(sp) + REG_L s1, CPU_USER_REGS_S1(sp) + REG_L a0, CPU_USER_REGS_A0(sp) + REG_L a1, CPU_USER_REGS_A1(sp) + REG_L a2, CPU_USER_REGS_A2(sp) + REG_L a3, CPU_USER_REGS_A3(sp) + REG_L a4, CPU_USER_REGS_A4(sp) + REG_L a5, CPU_USER_REGS_A5(sp) + REG_L a6, CPU_USER_REGS_A6(sp) + REG_L a7, CPU_USER_REGS_A7(sp) + REG_L s2, CPU_USER_REGS_S2(sp) + REG_L s3, CPU_USER_REGS_S3(sp) + REG_L s4, CPU_USER_REGS_S4(sp) + REG_L s5, CPU_USER_REGS_S5(sp) + REG_L s6, CPU_USER_REGS_S6(sp) + REG_L s7, CPU_USER_REGS_S7(sp) + REG_L s8, CPU_USER_REGS_S8(sp) + REG_L s9, CPU_USER_REGS_S9(sp) + REG_L s10, CPU_USER_REGS_S10(sp) + REG_L s11, CPU_USER_REGS_S11(sp) + REG_L t3, CPU_USER_REGS_T3(sp) + REG_L t4, CPU_USER_REGS_T4(sp) + REG_L t5, CPU_USER_REGS_T5(sp) + REG_L t6, CPU_USER_REGS_T6(sp) + + /* Restore sp */ + REG_L sp, CPU_USER_REGS_SP(sp) + + sret diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h new file mode 100644 index 0000000000..f3fb6b25d1 --- /dev/null +++ b/xen/arch/riscv/include/asm/traps.h @@ -0,0 +1,13 @@ +#ifndef __ASM_TRAPS_H__ +#define __ASM_TRAPS_H__ + +#include + +#ifndef __ASSEMBLY__ + +void do_trap(struct cpu_user_regs *cpu_regs); +void handle_trap(void); + +#endif /* __ASSEMBLY__ */ + +#endif /* __ASM_TRAPS_H__ */ diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c new file mode 100644 index 0000000000..ccd3593f5a --- /dev/null +++ b/xen/arch/riscv/traps.c @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2023 Vates + * + * RISC-V Trap handlers + */ +#include +#include + +void do_trap(struct cpu_user_regs *cpu_regs) +{ + die(); +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491197.760302 (Exim 4.92) (envelope-from ) id 1pPPFb-0007PP-J5; Tue, 07 Feb 2023 14:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491197.760302; Tue, 07 Feb 2023 14:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFb-0007ML-B9; Tue, 07 Feb 2023 14:47:15 +0000 Received: by outflank-mailman (input) for mailman id 491197; Tue, 07 Feb 2023 14:47:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFZ-00043Z-Gc for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:13 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e93df62-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:12 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id d14so13781503wrr.9 for ; Tue, 07 Feb 2023 06:47:13 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e93df62-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V6IhfQAV5IjeeWZlpGmkr/m4ORJCf6aJbJ24k0Y0RyM=; b=A+aRebtaV3WpRPtal0p4naUZFEf2dOOimXcWyxt6+InsIlNAr5FeF8zJ+9Fs8ODYp5 EGBwta7Dhk/9VyucGPp5PiIKdfj+2+MyTmiT/hNbtuRWODJ9i5yqZDpfQK5DsXFnXXOe 32OxFHZmbF9l8nH4PU2XO2moIZRwxi91MoykGd7gQfO3wPLam0O2FQyCH79qT9YaJof8 1ioJWoNHB+LWpf3bUTJFxYZwUQ1NAjAKxhuG2CykOGG/ke3t50EQC6Cl8zC+MivMryuq G17Dr4SUdV8WpLbQ5AjWRSq6Tk2qhh81I/1UzUbLM/LnhpP7ezV72RwApGzo6fBnL61N 19Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6IhfQAV5IjeeWZlpGmkr/m4ORJCf6aJbJ24k0Y0RyM=; b=BdqLgykfiEYQSdyka9o3omXcvgRyjcMaOGk3OuT8+lTGc2abRhmF4JL71MmR6XS451 9+E0tkS6FrIcClJBf4dyqyTDbOAZjha7beBf3O8zHOJLbETwMjdh27uNE5KjgD2UT3bl tunUpP6LVahKaO2+MT2Z5+TrdCTllXzlHKi7NJ7ZjcuT8iGawQRt5ygGedbgZmYk5clP G+X6SunsD5rtWiN8mjbzyIQO2wZNIjdUyJ1H8CkLk2KMpS9cp+goYu68+lptPP+NOx6S EY9lHRhy81WK9gRIPPmT1x0vGkjaatOQqkdPhqaEsCfW0N/dUPSr/kPOWzRaeGzdEkkO VFvw== X-Gm-Message-State: AO0yUKUv7qjpkccIsVdAqmr368QKK7DKv4Xi+qUpSbpZoSn6/I/En53u 67QkgnnKTUpTZZIEuL8ieBQSdycsIec= X-Google-Smtp-Source: AK7set8UcK6JVA5vbQ/17muxBznyE8QIL4jNt9zqnWLiZK7CvcqB0ffFaWrCjTPchxB4Fi1Bf1JdeQ== X-Received: by 2002:adf:d0c5:0:b0:2c3:e958:6dfc with SMTP id z5-20020adfd0c5000000b002c3e9586dfcmr2985084wrh.13.1675781232669; Tue, 07 Feb 2023 06:47:12 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 13/14] xen/riscv: test basic handling stuff Date: Tue, 7 Feb 2023 16:46:48 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Nothing changed --- xen/arch/riscv/setup.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index d502cf06b0..8d070244fd 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -9,12 +9,28 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); +static void test_run_in_exception(struct cpu_user_regs *regs) +{ + early_printk("If you see this message, "); + early_printk("run_in_exception_handler is most likely working\n"); +} + +static void test_macros_from_bug_h(void) +{ + run_in_exception_handler(test_run_in_exception); + WARN(); + early_printk("If you see this message, "); + early_printk("WARN is most likely working\n"); +} + void __init noreturn start_xen(void) { early_printk("Hello from C env\n"); trap_init(); + test_macros_from_bug_h(); + for ( ;; ) asm volatile ("wfi"); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491198.760308 (Exim 4.92) (envelope-from ) id 1pPPFc-0007ZD-El; Tue, 07 Feb 2023 14:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491198.760308; Tue, 07 Feb 2023 14:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFc-0007VE-12; Tue, 07 Feb 2023 14:47:16 +0000 Received: by outflank-mailman (input) for mailman id 491198; Tue, 07 Feb 2023 14:47:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFZ-0004Hz-Vb for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:14 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dfee10e-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:47:11 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id j25so10260842wrc.4 for ; Tue, 07 Feb 2023 06:47:11 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dfee10e-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fkyl+saYSnP1Fs1dLENb15D9r/RcpVgIDgVDjctpg1w=; b=p6TOa8sY181gq4ZCt9O/1Zt83m3NO5z58c1hiI/dWdQ+n5UOqFGuuO5/k5/IGpMtJX n8OhrzE9rPjxo5SCgpdJdW4b4I2FrvahmLOG4/fHpABxHsuznGagsKCFW/nOgdUlkV4/ cnrxouGLpHxC1T4IXMUQNd7+YrYs+67cTs6i7A7lGxM6kSeviTJljn0pweMmdcZZ8jr4 JIMZUipc4sdFdS0oLHeOXqRc6QH/gZxAN+gadhcfr4IHsCrEzX2GFZg4pXZ+lhj/reth 7uA+efaLm9UUNmjf412UOuHZMbgCt/mxyfY3cyINg2keTAHr4uYzy8ouD0d1ANZswlIg BJBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fkyl+saYSnP1Fs1dLENb15D9r/RcpVgIDgVDjctpg1w=; b=Rb3o1mcQJr9FEl4MiyUM8EnL+xsTHv+VYwxH92i3fK0oPDQt7//YlHRdbuWluKZp7B Py/JuuEnBV/0FmRUE1R829R+NMWprJAYPnXWmoSUtJnAjKsrJISCT4NYpTAST7wYc6eo Wd6BxlcS26AjiAXDgovO5KgY4diQf2xYeTxebf14FqAkFjQOKh7/utN9mtWugGabqbNz 3XkeBoP0ozBD1eZhd+lJWLVclQKV+Ec0W04ijG6Jxz05xqgPFy/WxZi3UEskRjuHEym9 Scp1xvdtvrKakCtuUyLtjWFqQu0rIcTL61mkLECW0fd3sWr41twTEKYcL3FCkKBhYljT 4oCQ== X-Gm-Message-State: AO0yUKUrf2EdTi9CEqePCqxeA5EvJwWvaGPq9t7xxmeATuWf88280kHP PFXqfF+slcsHylyWQvc3hAEVHBEVOC0= X-Google-Smtp-Source: AK7set8bLiYUTRqSD33+6+fXhmMECShlxeDoyOJeIjl7B4/tNSj27Y0wzfWcCCQ6kKD3RCPZ6FkqBA== X-Received: by 2002:a5d:6885:0:b0:2bf:ebd0:2e46 with SMTP id h5-20020a5d6885000000b002bfebd02e46mr2842486wru.65.1675781231314; Tue, 07 Feb 2023 06:47:11 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from Date: Tue, 7 Feb 2023 16:46:47 +0200 Message-Id: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. Signed-off-by: Oleksii Kurochko --- Changes in V3: - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] --- Changes in V2: - Remove __ in define namings - Update run_in_exception_handler() with register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); - Remove bug_instr_t type and change it's usage to uint32_t --- xen/arch/riscv/include/asm/bug.h | 38 +++++++++ xen/arch/riscv/setup.c | 2 +- xen/arch/riscv/traps.c | 130 +++++++++++++++++++++++++++++++ xen/arch/riscv/xen.lds.S | 10 +++ 4 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/include/asm/bug.h diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h new file mode 100644 index 0000000000..07190e9cfa --- /dev/null +++ b/xen/arch/riscv/include/asm/bug.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2021-2023 Vates + * + */ +#ifndef _ASM_RISCV_BUG_H +#define _ASM_RISCV_BUG_H + +#include + +#ifndef __ASSEMBLY__ + +#define BUG_FN_REG t0 + +#define BUG_INSTR "ebreak" + +#define INSN_LENGTH_MASK _UL(0x3) +#define INSN_LENGTH_32 _UL(0x3) + +#define BUG_INSN_32 _UL(0x00100073) /* ebreak */ +#define BUG_INSN_16 _UL(0x9002) /* c.ebreak */ +#define COMPRESSED_INSN_MASK _UL(0xffff) + +#define GET_INSN_LENGTH(insn) \ +({ \ + unsigned long len; \ + len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ? \ + 4UL : 2UL; \ + len; \ +}) + +/* These are defined by the architecture */ +int is_valid_bugaddr(uint32_t addr); + +#endif /* !__ASSEMBLY__ */ + +#endif /* _ASM_RISCV_BUG_H */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index c8513ca4f8..d502cf06b0 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,6 +1,6 @@ +#include #include #include - #include #include #include diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index 31ed63e3c1..624847f840 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -97,7 +98,136 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) die(); } +void show_execution_state(const struct cpu_user_regs *regs) +{ + early_printk("implement show_execution_state(regs)\n"); +} + +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) +{ + struct bug_frame *start, *end; + struct bug_frame *bug = NULL; + unsigned int id = 0; + const char *filename, *predicate; + int lineno; + + unsigned long bug_frames[] = { + (unsigned long)&__start_bug_frames[0], + (unsigned long)&__stop_bug_frames_0[0], + (unsigned long)&__stop_bug_frames_1[0], + (unsigned long)&__stop_bug_frames_2[0], + (unsigned long)&__stop_bug_frames_3[0], + }; + + for ( id = 0; id < BUGFRAME_NR; id++ ) + { + start = (struct bug_frame *)bug_frames[id]; + end = (struct bug_frame *)bug_frames[id + 1]; + + while ( start != end ) + { + if ( (vaddr_t)bug_loc(start) == pc ) + { + bug = start; + goto found; + } + + start++; + } + } + + found: + if ( bug == NULL ) + return -ENOENT; + + if ( id == BUGFRAME_run_fn ) + { + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; + + fn(regs); + + goto end; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_file(bug); + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + /* + * TODO: change early_printk's function to early_printk with format + * when s(n)printf() will be added. + */ + early_printk("Xen WARN at "); + early_printk(filename); + early_printk(":"); + // early_printk_hnum(lineno); + + show_execution_state(regs); + + goto end; + + case BUGFRAME_bug: + /* + * TODO: change early_printk's function to early_printk with format + * when s(n)printf() will be added. + */ + early_printk("Xen BUG at "); + early_printk(filename); + early_printk(":"); + // early_printk_hnum(lineno); + + show_execution_state(regs); + early_printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + + /* + * TODO: change early_printk's function to early_printk with format + * when s(n)printf() will be added. + */ + early_printk("Assertion \'"); + early_printk(predicate); + early_printk("\' failed at "); + early_printk(filename); + early_printk(":"); + // early_printk_hnum(lineno); + + show_execution_state(regs); + early_printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + } + + return -EINVAL; + + end: + return 0; +} + +int is_valid_bugaddr(uint32_t insn) +{ + if ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) + return (insn == BUG_INSN_32); + else + return ((insn & COMPRESSED_INSN_MASK) == BUG_INSN_16); +} + void do_trap(struct cpu_user_regs *cpu_regs) { + register_t pc = cpu_regs->sepc; + uint32_t instr = *(uint32_t *)pc; + + if (is_valid_bugaddr(instr)) { + if (!do_bug_frame(cpu_regs, cpu_regs->sepc)) { + cpu_regs->sepc += GET_INSN_LENGTH(*(uint32_t *)pc); + return; + } + } + do_unexpected_trap(cpu_regs); } diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index ca57cce75c..139e2d04cb 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -39,6 +39,16 @@ SECTIONS . = ALIGN(PAGE_SIZE); .rodata : { _srodata = .; /* Read-only data */ + /* Bug frames table */ + __start_bug_frames = .; + *(.bug_frames.0) + __stop_bug_frames_0 = .; + *(.bug_frames.1) + __stop_bug_frames_1 = .; + *(.bug_frames.2) + __stop_bug_frames_2 = .; + *(.bug_frames.3) + __stop_bug_frames_3 = .; *(.rodata) *(.rodata.*) *(.data.rel.ro) -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491188.760205 (Exim 4.92) (envelope-from ) id 1pPPFO-0004pM-EE; Tue, 07 Feb 2023 14:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491188.760205; Tue, 07 Feb 2023 14:47:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFO-0004pD-Am; Tue, 07 Feb 2023 14:47:02 +0000 Received: by outflank-mailman (input) for mailman id 491188; Tue, 07 Feb 2023 14:47:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFN-00043Z-3f for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:01 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47213d3c-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:00 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id o18so13802865wrj.3 for ; Tue, 07 Feb 2023 06:47:00 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:46:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47213d3c-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OxYCQq01h12RUP/eyWz/O7MFFuhOlyFFr7TX4jQoI/U=; b=H4JNQlCrpWpbRS9D75dBSvGVXJUZ5y0BPr76bV3vEIfBT9Tpc+WXmEhGn+2YcYRnA3 o+I3zBVlSORkux1fxax5KmYKHVlVtPpSYjNZwTnVJngztGGpH53d+dEk5P6llwN1mT2u PLzbR+5ofut80mDQpqcgXGPeWTyFejPaNwidwdKPLizYbxa+Er3CXjWEwML5D5T/ozdJ prBfMgfKKINZUjHIY2H0bEXYFQXfUHObTsPnoRp8uZb/ml9S3xh0AOgyz6vq5qr9ftPM 23S0/JC639XRoqyzTbnu/r6XEIzQufGpXu9RxVjokco1RSlXR9xtiX+Ujrq7KHk3Igl+ xjNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OxYCQq01h12RUP/eyWz/O7MFFuhOlyFFr7TX4jQoI/U=; b=OfFGNc3Je5cPOGolYO+nURiI95WDoxXsMFX4beedeuxPz6hbadHVUs6fukjXKkdLqm W9ygPCRhuRD+7P4ghYgGu+j7/1yKCKTpX9t1A+F2q6WB82fk9USh2ew2WiBKHduRgvcA dySIouGhr2cMRNUyzpKY9xoCbt2M7SuJqXNyNfj91AFxE1sks9uVLT4+DtNVY6EJUTxs 0GIhW5/OGFaTY7OYL/pwRWDBoHU1H+YRGGy1NO4plQxSuROs50kPpXkzXlDLct/Ji7gh riM75CLY23be31rCH7s3hRVNc+YoLGsQdGBU0fH9cUokS+EZ+eJdY7raAi3b/8ouaQrS da8Q== X-Gm-Message-State: AO0yUKUiPU1BIgk2HcYZnmsQBg8FhD1wgSdZXa+PTgL6LX6J6C6W7jFf 9NyIN+tN/AWO+/+aX9UWavSONB+KmTc= X-Google-Smtp-Source: AK7set9PU/vNtc9ac4qkctk68Byc909U61wI9XuJyABb2tsMHaccyEkm/KHnWAMYDx0G7KNsb50tkQ== X-Received: by 2002:a5d:5505:0:b0:2bb:e868:6a45 with SMTP id b5-20020a5d5505000000b002bbe8686a45mr2841966wrv.56.1675781220173; Tue, 07 Feb 2023 06:47:00 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 04/14] xen/riscv: add header Date: Tue, 7 Feb 2023 16:46:39 +0200 Message-Id: <94a46f35bc9387c699d9d24b1c792b54ec290255.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following changes were made in comparison with from Linux: * remove all defines as they are defined in riscv_encoding.h * leave only csr_* macros Origin: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ d2d11f342b17 Signed-off-by: Oleksii Kurochko --- Changes in V3: - Update origin to https://git.kernel.org/... --- Changes in V2: - Minor refactoring mentioned in the commit message, switch tabs to spaces and refactor things around __asm__ __volatile__. - Update the commit message and add "Origin:" tag. --- xen/arch/riscv/include/asm/csr.h | 84 ++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 xen/arch/riscv/include/asm/csr.h diff --git a/xen/arch/riscv/include/asm/csr.h b/xen/arch/riscv/include/asm/csr.h new file mode 100644 index 0000000000..4275cf6515 --- /dev/null +++ b/xen/arch/riscv/include/asm/csr.h @@ -0,0 +1,84 @@ +/* + * SPDX-License-Identifier: GPL-2.0-only + * + * Copyright (C) 2015 Regents of the University of California + */ + +#ifndef _ASM_RISCV_CSR_H +#define _ASM_RISCV_CSR_H + +#include +#include +#include + +#ifndef __ASSEMBLY__ + +#define csr_read(csr) \ +({ \ + register unsigned long __v; \ + __asm__ __volatile__ ( "csrr %0, " __ASM_STR(csr) \ + : "=r" (__v) \ + : : "memory" ); \ + __v; \ +}) + +#define csr_write(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrw " __ASM_STR(csr) ", %0" \ + : /* no outputs */ \ + : "rK" (__v) \ + : "memory" ); \ +}) + +#define csr_swap(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrrw %0, " __ASM_STR(csr) ", %1" \ + : "=r" (__v) \ + : "rK" (__v) \ + : "memory" ); \ + __v; \ +}) + +#define csr_read_set(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrrs %0, " __ASM_STR(csr) ", %1" \ + : "=r" (__v) \ + : "rK" (__v) \ + : "memory" ); \ + __v; \ +}) + +#define csr_set(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrs " __ASM_STR(csr) ", %0" \ + : /* no outputs */ \ + : "rK" (__v) \ + : "memory" ); \ +}) + +#define csr_read_clear(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrrc %0, " __ASM_STR(csr) ", %1" \ + : "=r" (__v) \ + : "rK" (__v) \ + : "memory" ); \ + __v; \ +}) + +#define csr_clear(csr, val) \ +({ \ + unsigned long __v = (unsigned long)(val); \ + __asm__ __volatile__ ( "csrc " __ASM_STR(csr) ", %0" \ + : /*no outputs */ \ + : "rK" (__v) \ + : "memory" ); \ +}) + +#endif /* __ASSEMBLY__ */ + +#endif /* _ASM_RISCV_CSR_H */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491190.760228 (Exim 4.92) (envelope-from ) id 1pPPFS-0005ND-1d; Tue, 07 Feb 2023 14:47:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491190.760228; Tue, 07 Feb 2023 14:47:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFR-0005ME-RO; Tue, 07 Feb 2023 14:47:05 +0000 Received: by outflank-mailman (input) for mailman id 491190; Tue, 07 Feb 2023 14:47:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFQ-0004Hz-8o for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:04 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4684efea-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:46:59 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id r2so13790566wrv.7 for ; Tue, 07 Feb 2023 06:46:59 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:46:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4684efea-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6lgGmAAnRDZ6o8+3iK6BQRdTjYlkjMWL3Qt3jZKXptA=; b=cS4VEimK8mrmEf7GWH65cTaZLbjdwgCAEXd7FvmE+2mcuaPWu3NXx/gQZ2pPZS4TlL 89RokDxrtmyHEoAsYOLfQBUKGtSvkHGx12EqTJEs83kcGBwcMh6J/Zm2G9Q9Zf9qs84z WnADgn/hBAUlcodlq3MAnFU9R2VrmnH34MKY6Nn6U11hqoxbBanYmvChW0RUbZnr1iQw 186YL8ZMvprccDESU9gqAlLD6MEGEl+dpEXwnjxi0vF21FzMBiTc0aEQO5BjzhyTrCkr 3xmLdcUgz6My4kZ53VvxNJAHg+BEN8z0psKA3p6XStGj31VozZy1FIca3DLsHYMmg066 ZWcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6lgGmAAnRDZ6o8+3iK6BQRdTjYlkjMWL3Qt3jZKXptA=; b=LfFoIbAyW/CLFLXkf41N3XyLfNQk5AGeyRM3tyf3hptDfGiq36JIcerVPSOd66IlBl eJsccerCPJt6EwvItbLgf3uQTMdwRlbUYIdd6whhmKq1e1h88Z+Ol5WIgUCZh9vvyKmO yWObLE1+N2OSKuqZ9RMYQxJP8mCk4kTHFBnD5VR6RRA3u7z9aK1bAbI46+kUE9pk4sWi n1fyoE9XWNMZvVqNh1EdugUHDJ4eY0hOJ5rkfSStQ/1o9V+MgPBeOVgN0wH9fDdCMm/M 495eAr8ME6YorBpIQKUru5hE+EzQHBUAAbz2oeeOQLvwU9Jbzh/yHEuPlW5jo6JLYbJx 7v+g== X-Gm-Message-State: AO0yUKUiuyvg1kYcGdre1+QZahN0ZeffMv2WZX/iZ1fD0YTYj/L1/b8M +biOtgWmdBPsh6bVZbtQJyMK/HxED3Y= X-Google-Smtp-Source: AK7set+ZiDeW8XzmyVR730iwORXHrtru6OzzabnDZds5LItFcL+KDzBVJG3kEvzxoxoIohipoucXqQ== X-Received: by 2002:adf:cd10:0:b0:2be:338f:bc55 with SMTP id w16-20020adfcd10000000b002be338fbc55mr2994545wrm.66.1675781218587; Tue, 07 Feb 2023 06:46:58 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 03/14] xen/riscv: add X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following changes were done in Xen code base in comparison with OpenSBI: * Remove "#include " as most of the stuff inside it is present in Xen code base. * Add macros _UL and _ULL as they were in before * Add SATP32_MODE_SHIFT/SATP64_MODE_SHIFT/SATP_MODE_SHIFT as they will be used in riscv/mm.c * Add CAUSE_IRQ_FLAG which is going to be used insised exception handler * Change ulong to unsigned long in macros REG_PTR(...) * Change s32 to int32_t Originally authored by Anup Patel Origin: https://github.com/riscv-software-src/opensbi.git c45992cc2b12 Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V3: - Add Acked-by: Alistair Francis --- Changes in V2: - Take the latest version of riscv_encoding.h from OpenSBI. - Update riscv_encoding.h with Xen related changes mentioned in the commit message. - Update commit message and add "Origin:" tag --- xen/arch/riscv/include/asm/riscv_encoding.h | 927 ++++++++++++++++++++ 1 file changed, 927 insertions(+) create mode 100644 xen/arch/riscv/include/asm/riscv_encoding.h diff --git a/xen/arch/riscv/include/asm/riscv_encoding.h b/xen/arch/riscv/include/asm/riscv_encoding.h new file mode 100644 index 0000000000..43dd4f6981 --- /dev/null +++ b/xen/arch/riscv/include/asm/riscv_encoding.h @@ -0,0 +1,927 @@ +/* + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2019 Western Digital Corporation or its affiliates. + * + * Authors: + * Anup Patel + */ + +#ifndef __RISCV_ENCODING_H__ +#define __RISCV_ENCODING_H__ + +#define _UL(X) _AC(X, UL) +#define _ULL(X) _AC(X, ULL) + +/* clang-format off */ +#define MSTATUS_SIE _UL(0x00000002) +#define MSTATUS_MIE _UL(0x00000008) +#define MSTATUS_SPIE_SHIFT 5 +#define MSTATUS_SPIE (_UL(1) << MSTATUS_SPIE_SHIFT) +#define MSTATUS_UBE _UL(0x00000040) +#define MSTATUS_MPIE _UL(0x00000080) +#define MSTATUS_SPP_SHIFT 8 +#define MSTATUS_SPP (_UL(1) << MSTATUS_SPP_SHIFT) +#define MSTATUS_MPP_SHIFT 11 +#define MSTATUS_MPP (_UL(3) << MSTATUS_MPP_SHIFT) +#define MSTATUS_FS _UL(0x00006000) +#define MSTATUS_XS _UL(0x00018000) +#define MSTATUS_VS _UL(0x00000600) +#define MSTATUS_MPRV _UL(0x00020000) +#define MSTATUS_SUM _UL(0x00040000) +#define MSTATUS_MXR _UL(0x00080000) +#define MSTATUS_TVM _UL(0x00100000) +#define MSTATUS_TW _UL(0x00200000) +#define MSTATUS_TSR _UL(0x00400000) +#define MSTATUS32_SD _UL(0x80000000) +#if __riscv_xlen == 64 +#define MSTATUS_UXL _ULL(0x0000000300000000) +#define MSTATUS_SXL _ULL(0x0000000C00000000) +#define MSTATUS_SBE _ULL(0x0000001000000000) +#define MSTATUS_MBE _ULL(0x0000002000000000) +#define MSTATUS_GVA _ULL(0x0000004000000000) +#define MSTATUS_GVA_SHIFT 38 +#define MSTATUS_MPV _ULL(0x0000008000000000) +#else +#define MSTATUSH_SBE _UL(0x00000010) +#define MSTATUSH_MBE _UL(0x00000020) +#define MSTATUSH_GVA _UL(0x00000040) +#define MSTATUSH_GVA_SHIFT 6 +#define MSTATUSH_MPV _UL(0x00000080) +#endif +#define MSTATUS32_SD _UL(0x80000000) +#define MSTATUS64_SD _ULL(0x8000000000000000) + +#define SSTATUS_SIE MSTATUS_SIE +#define SSTATUS_SPIE_SHIFT MSTATUS_SPIE_SHIFT +#define SSTATUS_SPIE MSTATUS_SPIE +#define SSTATUS_SPP_SHIFT MSTATUS_SPP_SHIFT +#define SSTATUS_SPP MSTATUS_SPP +#define SSTATUS_FS MSTATUS_FS +#define SSTATUS_XS MSTATUS_XS +#define SSTATUS_VS MSTATUS_VS +#define SSTATUS_SUM MSTATUS_SUM +#define SSTATUS_MXR MSTATUS_MXR +#define SSTATUS32_SD MSTATUS32_SD +#define SSTATUS64_UXL MSTATUS_UXL +#define SSTATUS64_SD MSTATUS64_SD + +#if __riscv_xlen == 64 +#define HSTATUS_VSXL _UL(0x300000000) +#define HSTATUS_VSXL_SHIFT 32 +#endif +#define HSTATUS_VTSR _UL(0x00400000) +#define HSTATUS_VTW _UL(0x00200000) +#define HSTATUS_VTVM _UL(0x00100000) +#define HSTATUS_VGEIN _UL(0x0003f000) +#define HSTATUS_VGEIN_SHIFT 12 +#define HSTATUS_HU _UL(0x00000200) +#define HSTATUS_SPVP _UL(0x00000100) +#define HSTATUS_SPV _UL(0x00000080) +#define HSTATUS_GVA _UL(0x00000040) +#define HSTATUS_VSBE _UL(0x00000020) + +#define IRQ_S_SOFT 1 +#define IRQ_VS_SOFT 2 +#define IRQ_M_SOFT 3 +#define IRQ_S_TIMER 5 +#define IRQ_VS_TIMER 6 +#define IRQ_M_TIMER 7 +#define IRQ_S_EXT 9 +#define IRQ_VS_EXT 10 +#define IRQ_M_EXT 11 +#define IRQ_S_GEXT 12 +#define IRQ_PMU_OVF 13 + +#define MIP_SSIP (_UL(1) << IRQ_S_SOFT) +#define MIP_VSSIP (_UL(1) << IRQ_VS_SOFT) +#define MIP_MSIP (_UL(1) << IRQ_M_SOFT) +#define MIP_STIP (_UL(1) << IRQ_S_TIMER) +#define MIP_VSTIP (_UL(1) << IRQ_VS_TIMER) +#define MIP_MTIP (_UL(1) << IRQ_M_TIMER) +#define MIP_SEIP (_UL(1) << IRQ_S_EXT) +#define MIP_VSEIP (_UL(1) << IRQ_VS_EXT) +#define MIP_MEIP (_UL(1) << IRQ_M_EXT) +#define MIP_SGEIP (_UL(1) << IRQ_S_GEXT) +#define MIP_LCOFIP (_UL(1) << IRQ_PMU_OVF) + +#define SIP_SSIP MIP_SSIP +#define SIP_STIP MIP_STIP + +#define PRV_U _UL(0) +#define PRV_S _UL(1) +#define PRV_M _UL(3) + +#define SATP32_MODE _UL(0x80000000) +#define SATP32_MODE_SHIFT 31 +#define SATP32_ASID _UL(0x7FC00000) +#define SATP32_PPN _UL(0x003FFFFF) +#define SATP64_MODE _ULL(0xF000000000000000) +#define SATP64_MODE_SHIFT 60 +#define SATP64_ASID _ULL(0x0FFFF00000000000) +#define SATP64_PPN _ULL(0x00000FFFFFFFFFFF) + +#define SATP_MODE_OFF _UL(0) +#define SATP_MODE_SV32 _UL(1) +#define SATP_MODE_SV39 _UL(8) +#define SATP_MODE_SV48 _UL(9) +#define SATP_MODE_SV57 _UL(10) +#define SATP_MODE_SV64 _UL(11) + +#define HGATP_MODE_OFF _UL(0) +#define HGATP_MODE_SV32X4 _UL(1) +#define HGATP_MODE_SV39X4 _UL(8) +#define HGATP_MODE_SV48X4 _UL(9) + +#define HGATP32_MODE_SHIFT 31 +#define HGATP32_VMID_SHIFT 22 +#define HGATP32_VMID_MASK _UL(0x1FC00000) +#define HGATP32_PPN _UL(0x003FFFFF) + +#define HGATP64_MODE_SHIFT 60 +#define HGATP64_VMID_SHIFT 44 +#define HGATP64_VMID_MASK _ULL(0x03FFF00000000000) +#define HGATP64_PPN _ULL(0x00000FFFFFFFFFFF) + +#define PMP_R _UL(0x01) +#define PMP_W _UL(0x02) +#define PMP_X _UL(0x04) +#define PMP_A _UL(0x18) +#define PMP_A_TOR _UL(0x08) +#define PMP_A_NA4 _UL(0x10) +#define PMP_A_NAPOT _UL(0x18) +#define PMP_L _UL(0x80) + +#define PMP_SHIFT 2 +#define PMP_COUNT 64 +#if __riscv_xlen == 64 +#define PMP_ADDR_MASK ((_ULL(0x1) << 54) - 1) +#else +#define PMP_ADDR_MASK _UL(0xFFFFFFFF) +#endif + +#if __riscv_xlen == 64 +#define MSTATUS_SD MSTATUS64_SD +#define SSTATUS_SD SSTATUS64_SD +#define SATP_MODE SATP64_MODE +#define SATP_MODE_SHIFT SATP64_MODE_SHIFT + +#define HGATP_PPN HGATP64_PPN +#define HGATP_VMID_SHIFT HGATP64_VMID_SHIFT +#define HGATP_VMID_MASK HGATP64_VMID_MASK +#define HGATP_MODE_SHIFT HGATP64_MODE_SHIFT +#else +#define MSTATUS_SD MSTATUS32_SD +#define SSTATUS_SD SSTATUS32_SD +#define SATP_MODE SATP32_MODE +#define SATP_MODE_SHIFT SATP32_MODE_SHIFT + +#define HGATP_PPN HGATP32_PPN +#define HGATP_VMID_SHIFT HGATP32_VMID_SHIFT +#define HGATP_VMID_MASK HGATP32_VMID_MASK +#define HGATP_MODE_SHIFT HGATP32_MODE_SHIFT +#endif + +#define TOPI_IID_SHIFT 16 +#define TOPI_IID_MASK 0xfff +#define TOPI_IPRIO_MASK 0xff + +#if __riscv_xlen == 64 +#define MHPMEVENT_OF (_UL(1) << 63) +#define MHPMEVENT_MINH (_UL(1) << 62) +#define MHPMEVENT_SINH (_UL(1) << 61) +#define MHPMEVENT_UINH (_UL(1) << 60) +#define MHPMEVENT_VSINH (_UL(1) << 59) +#define MHPMEVENT_VUINH (_UL(1) << 58) +#else +#define MHPMEVENTH_OF (_ULL(1) << 31) +#define MHPMEVENTH_MINH (_ULL(1) << 30) +#define MHPMEVENTH_SINH (_ULL(1) << 29) +#define MHPMEVENTH_UINH (_ULL(1) << 28) +#define MHPMEVENTH_VSINH (_ULL(1) << 27) +#define MHPMEVENTH_VUINH (_ULL(1) << 26) + +#define MHPMEVENT_OF (MHPMEVENTH_OF << 32) +#define MHPMEVENT_MINH (MHPMEVENTH_MINH << 32) +#define MHPMEVENT_SINH (MHPMEVENTH_SINH << 32) +#define MHPMEVENT_UINH (MHPMEVENTH_UINH << 32) +#define MHPMEVENT_VSINH (MHPMEVENTH_VSINH << 32) +#define MHPMEVENT_VUINH (MHPMEVENTH_VUINH << 32) + +#endif + +#define MHPMEVENT_SSCOF_MASK _ULL(0xFFFF000000000000) + +#if __riscv_xlen > 32 +#define ENVCFG_STCE (_ULL(1) << 63) +#define ENVCFG_PBMTE (_ULL(1) << 62) +#else +#define ENVCFGH_STCE (_UL(1) << 31) +#define ENVCFGH_PBMTE (_UL(1) << 30) +#endif +#define ENVCFG_CBZE (_UL(1) << 7) +#define ENVCFG_CBCFE (_UL(1) << 6) +#define ENVCFG_CBIE_SHIFT 4 +#define ENVCFG_CBIE (_UL(0x3) << ENVCFG_CBIE_SHIFT) +#define ENVCFG_CBIE_ILL _UL(0x0) +#define ENVCFG_CBIE_FLUSH _UL(0x1) +#define ENVCFG_CBIE_INV _UL(0x3) +#define ENVCFG_FIOM _UL(0x1) + +/* ===== User-level CSRs ===== */ + +/* User Trap Setup (N-extension) */ +#define CSR_USTATUS 0x000 +#define CSR_UIE 0x004 +#define CSR_UTVEC 0x005 + +/* User Trap Handling (N-extension) */ +#define CSR_USCRATCH 0x040 +#define CSR_UEPC 0x041 +#define CSR_UCAUSE 0x042 +#define CSR_UTVAL 0x043 +#define CSR_UIP 0x044 + +/* User Floating-point CSRs */ +#define CSR_FFLAGS 0x001 +#define CSR_FRM 0x002 +#define CSR_FCSR 0x003 + +/* User Counters/Timers */ +#define CSR_CYCLE 0xc00 +#define CSR_TIME 0xc01 +#define CSR_INSTRET 0xc02 +#define CSR_HPMCOUNTER3 0xc03 +#define CSR_HPMCOUNTER4 0xc04 +#define CSR_HPMCOUNTER5 0xc05 +#define CSR_HPMCOUNTER6 0xc06 +#define CSR_HPMCOUNTER7 0xc07 +#define CSR_HPMCOUNTER8 0xc08 +#define CSR_HPMCOUNTER9 0xc09 +#define CSR_HPMCOUNTER10 0xc0a +#define CSR_HPMCOUNTER11 0xc0b +#define CSR_HPMCOUNTER12 0xc0c +#define CSR_HPMCOUNTER13 0xc0d +#define CSR_HPMCOUNTER14 0xc0e +#define CSR_HPMCOUNTER15 0xc0f +#define CSR_HPMCOUNTER16 0xc10 +#define CSR_HPMCOUNTER17 0xc11 +#define CSR_HPMCOUNTER18 0xc12 +#define CSR_HPMCOUNTER19 0xc13 +#define CSR_HPMCOUNTER20 0xc14 +#define CSR_HPMCOUNTER21 0xc15 +#define CSR_HPMCOUNTER22 0xc16 +#define CSR_HPMCOUNTER23 0xc17 +#define CSR_HPMCOUNTER24 0xc18 +#define CSR_HPMCOUNTER25 0xc19 +#define CSR_HPMCOUNTER26 0xc1a +#define CSR_HPMCOUNTER27 0xc1b +#define CSR_HPMCOUNTER28 0xc1c +#define CSR_HPMCOUNTER29 0xc1d +#define CSR_HPMCOUNTER30 0xc1e +#define CSR_HPMCOUNTER31 0xc1f +#define CSR_CYCLEH 0xc80 +#define CSR_TIMEH 0xc81 +#define CSR_INSTRETH 0xc82 +#define CSR_HPMCOUNTER3H 0xc83 +#define CSR_HPMCOUNTER4H 0xc84 +#define CSR_HPMCOUNTER5H 0xc85 +#define CSR_HPMCOUNTER6H 0xc86 +#define CSR_HPMCOUNTER7H 0xc87 +#define CSR_HPMCOUNTER8H 0xc88 +#define CSR_HPMCOUNTER9H 0xc89 +#define CSR_HPMCOUNTER10H 0xc8a +#define CSR_HPMCOUNTER11H 0xc8b +#define CSR_HPMCOUNTER12H 0xc8c +#define CSR_HPMCOUNTER13H 0xc8d +#define CSR_HPMCOUNTER14H 0xc8e +#define CSR_HPMCOUNTER15H 0xc8f +#define CSR_HPMCOUNTER16H 0xc90 +#define CSR_HPMCOUNTER17H 0xc91 +#define CSR_HPMCOUNTER18H 0xc92 +#define CSR_HPMCOUNTER19H 0xc93 +#define CSR_HPMCOUNTER20H 0xc94 +#define CSR_HPMCOUNTER21H 0xc95 +#define CSR_HPMCOUNTER22H 0xc96 +#define CSR_HPMCOUNTER23H 0xc97 +#define CSR_HPMCOUNTER24H 0xc98 +#define CSR_HPMCOUNTER25H 0xc99 +#define CSR_HPMCOUNTER26H 0xc9a +#define CSR_HPMCOUNTER27H 0xc9b +#define CSR_HPMCOUNTER28H 0xc9c +#define CSR_HPMCOUNTER29H 0xc9d +#define CSR_HPMCOUNTER30H 0xc9e +#define CSR_HPMCOUNTER31H 0xc9f + +/* ===== Supervisor-level CSRs ===== */ + +/* Supervisor Trap Setup */ +#define CSR_SSTATUS 0x100 +#define CSR_SIE 0x104 +#define CSR_STVEC 0x105 +#define CSR_SCOUNTEREN 0x106 + +/* Supervisor Configuration */ +#define CSR_SENVCFG 0x10a + +/* Supervisor Trap Handling */ +#define CSR_SSCRATCH 0x140 +#define CSR_SEPC 0x141 +#define CSR_SCAUSE 0x142 +#define CSR_STVAL 0x143 +#define CSR_SIP 0x144 + +/* Sstc extension */ +#define CSR_STIMECMP 0x14D +#define CSR_STIMECMPH 0x15D + +/* Supervisor Protection and Translation */ +#define CSR_SATP 0x180 + +/* Supervisor-Level Window to Indirectly Accessed Registers (AIA) */ +#define CSR_SISELECT 0x150 +#define CSR_SIREG 0x151 + +/* Supervisor-Level Interrupts (AIA) */ +#define CSR_STOPEI 0x15c +#define CSR_STOPI 0xdb0 + +/* Supervisor-Level High-Half CSRs (AIA) */ +#define CSR_SIEH 0x114 +#define CSR_SIPH 0x154 + +/* Supervisor stateen CSRs */ +#define CSR_SSTATEEN0 0x10C +#define CSR_SSTATEEN1 0x10D +#define CSR_SSTATEEN2 0x10E +#define CSR_SSTATEEN3 0x10F + +/* ===== Hypervisor-level CSRs ===== */ + +/* Hypervisor Trap Setup (H-extension) */ +#define CSR_HSTATUS 0x600 +#define CSR_HEDELEG 0x602 +#define CSR_HIDELEG 0x603 +#define CSR_HIE 0x604 +#define CSR_HCOUNTEREN 0x606 +#define CSR_HGEIE 0x607 + +/* Hypervisor Configuration */ +#define CSR_HENVCFG 0x60a +#define CSR_HENVCFGH 0x61a + +/* Hypervisor Trap Handling (H-extension) */ +#define CSR_HTVAL 0x643 +#define CSR_HIP 0x644 +#define CSR_HVIP 0x645 +#define CSR_HTINST 0x64a +#define CSR_HGEIP 0xe12 + +/* Hypervisor Protection and Translation (H-extension) */ +#define CSR_HGATP 0x680 + +/* Hypervisor Counter/Timer Virtualization Registers (H-extension) */ +#define CSR_HTIMEDELTA 0x605 +#define CSR_HTIMEDELTAH 0x615 + +/* Virtual Supervisor Registers (H-extension) */ +#define CSR_VSSTATUS 0x200 +#define CSR_VSIE 0x204 +#define CSR_VSTVEC 0x205 +#define CSR_VSSCRATCH 0x240 +#define CSR_VSEPC 0x241 +#define CSR_VSCAUSE 0x242 +#define CSR_VSTVAL 0x243 +#define CSR_VSIP 0x244 +#define CSR_VSATP 0x280 + +/* Virtual Interrupts and Interrupt Priorities (H-extension with AIA) */ +#define CSR_HVIEN 0x608 +#define CSR_HVICTL 0x609 +#define CSR_HVIPRIO1 0x646 +#define CSR_HVIPRIO2 0x647 + +/* VS-Level Window to Indirectly Accessed Registers (H-extension with AIA) */ +#define CSR_VSISELECT 0x250 +#define CSR_VSIREG 0x251 + +/* VS-Level Interrupts (H-extension with AIA) */ +#define CSR_VSTOPEI 0x25c +#define CSR_VSTOPI 0xeb0 + +/* Hypervisor and VS-Level High-Half CSRs (H-extension with AIA) */ +#define CSR_HIDELEGH 0x613 +#define CSR_HVIENH 0x618 +#define CSR_HVIPH 0x655 +#define CSR_HVIPRIO1H 0x656 +#define CSR_HVIPRIO2H 0x657 +#define CSR_VSIEH 0x214 +#define CSR_VSIPH 0x254 + +/* Hypervisor stateen CSRs */ +#define CSR_HSTATEEN0 0x60C +#define CSR_HSTATEEN0H 0x61C +#define CSR_HSTATEEN1 0x60D +#define CSR_HSTATEEN1H 0x61D +#define CSR_HSTATEEN2 0x60E +#define CSR_HSTATEEN2H 0x61E +#define CSR_HSTATEEN3 0x60F +#define CSR_HSTATEEN3H 0x61F + +/* ===== Machine-level CSRs ===== */ + +/* Machine Information Registers */ +#define CSR_MVENDORID 0xf11 +#define CSR_MARCHID 0xf12 +#define CSR_MIMPID 0xf13 +#define CSR_MHARTID 0xf14 + +/* Machine Trap Setup */ +#define CSR_MSTATUS 0x300 +#define CSR_MISA 0x301 +#define CSR_MEDELEG 0x302 +#define CSR_MIDELEG 0x303 +#define CSR_MIE 0x304 +#define CSR_MTVEC 0x305 +#define CSR_MCOUNTEREN 0x306 +#define CSR_MSTATUSH 0x310 + +/* Machine Configuration */ +#define CSR_MENVCFG 0x30a +#define CSR_MENVCFGH 0x31a + +/* Machine Trap Handling */ +#define CSR_MSCRATCH 0x340 +#define CSR_MEPC 0x341 +#define CSR_MCAUSE 0x342 +#define CSR_MTVAL 0x343 +#define CSR_MIP 0x344 +#define CSR_MTINST 0x34a +#define CSR_MTVAL2 0x34b + +/* Machine Memory Protection */ +#define CSR_PMPCFG0 0x3a0 +#define CSR_PMPCFG1 0x3a1 +#define CSR_PMPCFG2 0x3a2 +#define CSR_PMPCFG3 0x3a3 +#define CSR_PMPCFG4 0x3a4 +#define CSR_PMPCFG5 0x3a5 +#define CSR_PMPCFG6 0x3a6 +#define CSR_PMPCFG7 0x3a7 +#define CSR_PMPCFG8 0x3a8 +#define CSR_PMPCFG9 0x3a9 +#define CSR_PMPCFG10 0x3aa +#define CSR_PMPCFG11 0x3ab +#define CSR_PMPCFG12 0x3ac +#define CSR_PMPCFG13 0x3ad +#define CSR_PMPCFG14 0x3ae +#define CSR_PMPCFG15 0x3af +#define CSR_PMPADDR0 0x3b0 +#define CSR_PMPADDR1 0x3b1 +#define CSR_PMPADDR2 0x3b2 +#define CSR_PMPADDR3 0x3b3 +#define CSR_PMPADDR4 0x3b4 +#define CSR_PMPADDR5 0x3b5 +#define CSR_PMPADDR6 0x3b6 +#define CSR_PMPADDR7 0x3b7 +#define CSR_PMPADDR8 0x3b8 +#define CSR_PMPADDR9 0x3b9 +#define CSR_PMPADDR10 0x3ba +#define CSR_PMPADDR11 0x3bb +#define CSR_PMPADDR12 0x3bc +#define CSR_PMPADDR13 0x3bd +#define CSR_PMPADDR14 0x3be +#define CSR_PMPADDR15 0x3bf +#define CSR_PMPADDR16 0x3c0 +#define CSR_PMPADDR17 0x3c1 +#define CSR_PMPADDR18 0x3c2 +#define CSR_PMPADDR19 0x3c3 +#define CSR_PMPADDR20 0x3c4 +#define CSR_PMPADDR21 0x3c5 +#define CSR_PMPADDR22 0x3c6 +#define CSR_PMPADDR23 0x3c7 +#define CSR_PMPADDR24 0x3c8 +#define CSR_PMPADDR25 0x3c9 +#define CSR_PMPADDR26 0x3ca +#define CSR_PMPADDR27 0x3cb +#define CSR_PMPADDR28 0x3cc +#define CSR_PMPADDR29 0x3cd +#define CSR_PMPADDR30 0x3ce +#define CSR_PMPADDR31 0x3cf +#define CSR_PMPADDR32 0x3d0 +#define CSR_PMPADDR33 0x3d1 +#define CSR_PMPADDR34 0x3d2 +#define CSR_PMPADDR35 0x3d3 +#define CSR_PMPADDR36 0x3d4 +#define CSR_PMPADDR37 0x3d5 +#define CSR_PMPADDR38 0x3d6 +#define CSR_PMPADDR39 0x3d7 +#define CSR_PMPADDR40 0x3d8 +#define CSR_PMPADDR41 0x3d9 +#define CSR_PMPADDR42 0x3da +#define CSR_PMPADDR43 0x3db +#define CSR_PMPADDR44 0x3dc +#define CSR_PMPADDR45 0x3dd +#define CSR_PMPADDR46 0x3de +#define CSR_PMPADDR47 0x3df +#define CSR_PMPADDR48 0x3e0 +#define CSR_PMPADDR49 0x3e1 +#define CSR_PMPADDR50 0x3e2 +#define CSR_PMPADDR51 0x3e3 +#define CSR_PMPADDR52 0x3e4 +#define CSR_PMPADDR53 0x3e5 +#define CSR_PMPADDR54 0x3e6 +#define CSR_PMPADDR55 0x3e7 +#define CSR_PMPADDR56 0x3e8 +#define CSR_PMPADDR57 0x3e9 +#define CSR_PMPADDR58 0x3ea +#define CSR_PMPADDR59 0x3eb +#define CSR_PMPADDR60 0x3ec +#define CSR_PMPADDR61 0x3ed +#define CSR_PMPADDR62 0x3ee +#define CSR_PMPADDR63 0x3ef + +/* Machine Counters/Timers */ +#define CSR_MCYCLE 0xb00 +#define CSR_MINSTRET 0xb02 +#define CSR_MHPMCOUNTER3 0xb03 +#define CSR_MHPMCOUNTER4 0xb04 +#define CSR_MHPMCOUNTER5 0xb05 +#define CSR_MHPMCOUNTER6 0xb06 +#define CSR_MHPMCOUNTER7 0xb07 +#define CSR_MHPMCOUNTER8 0xb08 +#define CSR_MHPMCOUNTER9 0xb09 +#define CSR_MHPMCOUNTER10 0xb0a +#define CSR_MHPMCOUNTER11 0xb0b +#define CSR_MHPMCOUNTER12 0xb0c +#define CSR_MHPMCOUNTER13 0xb0d +#define CSR_MHPMCOUNTER14 0xb0e +#define CSR_MHPMCOUNTER15 0xb0f +#define CSR_MHPMCOUNTER16 0xb10 +#define CSR_MHPMCOUNTER17 0xb11 +#define CSR_MHPMCOUNTER18 0xb12 +#define CSR_MHPMCOUNTER19 0xb13 +#define CSR_MHPMCOUNTER20 0xb14 +#define CSR_MHPMCOUNTER21 0xb15 +#define CSR_MHPMCOUNTER22 0xb16 +#define CSR_MHPMCOUNTER23 0xb17 +#define CSR_MHPMCOUNTER24 0xb18 +#define CSR_MHPMCOUNTER25 0xb19 +#define CSR_MHPMCOUNTER26 0xb1a +#define CSR_MHPMCOUNTER27 0xb1b +#define CSR_MHPMCOUNTER28 0xb1c +#define CSR_MHPMCOUNTER29 0xb1d +#define CSR_MHPMCOUNTER30 0xb1e +#define CSR_MHPMCOUNTER31 0xb1f +#define CSR_MCYCLEH 0xb80 +#define CSR_MINSTRETH 0xb82 +#define CSR_MHPMCOUNTER3H 0xb83 +#define CSR_MHPMCOUNTER4H 0xb84 +#define CSR_MHPMCOUNTER5H 0xb85 +#define CSR_MHPMCOUNTER6H 0xb86 +#define CSR_MHPMCOUNTER7H 0xb87 +#define CSR_MHPMCOUNTER8H 0xb88 +#define CSR_MHPMCOUNTER9H 0xb89 +#define CSR_MHPMCOUNTER10H 0xb8a +#define CSR_MHPMCOUNTER11H 0xb8b +#define CSR_MHPMCOUNTER12H 0xb8c +#define CSR_MHPMCOUNTER13H 0xb8d +#define CSR_MHPMCOUNTER14H 0xb8e +#define CSR_MHPMCOUNTER15H 0xb8f +#define CSR_MHPMCOUNTER16H 0xb90 +#define CSR_MHPMCOUNTER17H 0xb91 +#define CSR_MHPMCOUNTER18H 0xb92 +#define CSR_MHPMCOUNTER19H 0xb93 +#define CSR_MHPMCOUNTER20H 0xb94 +#define CSR_MHPMCOUNTER21H 0xb95 +#define CSR_MHPMCOUNTER22H 0xb96 +#define CSR_MHPMCOUNTER23H 0xb97 +#define CSR_MHPMCOUNTER24H 0xb98 +#define CSR_MHPMCOUNTER25H 0xb99 +#define CSR_MHPMCOUNTER26H 0xb9a +#define CSR_MHPMCOUNTER27H 0xb9b +#define CSR_MHPMCOUNTER28H 0xb9c +#define CSR_MHPMCOUNTER29H 0xb9d +#define CSR_MHPMCOUNTER30H 0xb9e +#define CSR_MHPMCOUNTER31H 0xb9f + +/* Machine Counter Setup */ +#define CSR_MCOUNTINHIBIT 0x320 +#define CSR_MHPMEVENT3 0x323 +#define CSR_MHPMEVENT4 0x324 +#define CSR_MHPMEVENT5 0x325 +#define CSR_MHPMEVENT6 0x326 +#define CSR_MHPMEVENT7 0x327 +#define CSR_MHPMEVENT8 0x328 +#define CSR_MHPMEVENT9 0x329 +#define CSR_MHPMEVENT10 0x32a +#define CSR_MHPMEVENT11 0x32b +#define CSR_MHPMEVENT12 0x32c +#define CSR_MHPMEVENT13 0x32d +#define CSR_MHPMEVENT14 0x32e +#define CSR_MHPMEVENT15 0x32f +#define CSR_MHPMEVENT16 0x330 +#define CSR_MHPMEVENT17 0x331 +#define CSR_MHPMEVENT18 0x332 +#define CSR_MHPMEVENT19 0x333 +#define CSR_MHPMEVENT20 0x334 +#define CSR_MHPMEVENT21 0x335 +#define CSR_MHPMEVENT22 0x336 +#define CSR_MHPMEVENT23 0x337 +#define CSR_MHPMEVENT24 0x338 +#define CSR_MHPMEVENT25 0x339 +#define CSR_MHPMEVENT26 0x33a +#define CSR_MHPMEVENT27 0x33b +#define CSR_MHPMEVENT28 0x33c +#define CSR_MHPMEVENT29 0x33d +#define CSR_MHPMEVENT30 0x33e +#define CSR_MHPMEVENT31 0x33f + +/* For RV32 */ +#define CSR_MHPMEVENT3H 0x723 +#define CSR_MHPMEVENT4H 0x724 +#define CSR_MHPMEVENT5H 0x725 +#define CSR_MHPMEVENT6H 0x726 +#define CSR_MHPMEVENT7H 0x727 +#define CSR_MHPMEVENT8H 0x728 +#define CSR_MHPMEVENT9H 0x729 +#define CSR_MHPMEVENT10H 0x72a +#define CSR_MHPMEVENT11H 0x72b +#define CSR_MHPMEVENT12H 0x72c +#define CSR_MHPMEVENT13H 0x72d +#define CSR_MHPMEVENT14H 0x72e +#define CSR_MHPMEVENT15H 0x72f +#define CSR_MHPMEVENT16H 0x730 +#define CSR_MHPMEVENT17H 0x731 +#define CSR_MHPMEVENT18H 0x732 +#define CSR_MHPMEVENT19H 0x733 +#define CSR_MHPMEVENT20H 0x734 +#define CSR_MHPMEVENT21H 0x735 +#define CSR_MHPMEVENT22H 0x736 +#define CSR_MHPMEVENT23H 0x737 +#define CSR_MHPMEVENT24H 0x738 +#define CSR_MHPMEVENT25H 0x739 +#define CSR_MHPMEVENT26H 0x73a +#define CSR_MHPMEVENT27H 0x73b +#define CSR_MHPMEVENT28H 0x73c +#define CSR_MHPMEVENT29H 0x73d +#define CSR_MHPMEVENT30H 0x73e +#define CSR_MHPMEVENT31H 0x73f + +/* Counter Overflow CSR */ +#define CSR_SCOUNTOVF 0xda0 + +/* Debug/Trace Registers */ +#define CSR_TSELECT 0x7a0 +#define CSR_TDATA1 0x7a1 +#define CSR_TDATA2 0x7a2 +#define CSR_TDATA3 0x7a3 + +/* Debug Mode Registers */ +#define CSR_DCSR 0x7b0 +#define CSR_DPC 0x7b1 +#define CSR_DSCRATCH0 0x7b2 +#define CSR_DSCRATCH1 0x7b3 + +/* Machine-Level Window to Indirectly Accessed Registers (AIA) */ +#define CSR_MISELECT 0x350 +#define CSR_MIREG 0x351 + +/* Machine-Level Interrupts (AIA) */ +#define CSR_MTOPEI 0x35c +#define CSR_MTOPI 0xfb0 + +/* Virtual Interrupts for Supervisor Level (AIA) */ +#define CSR_MVIEN 0x308 +#define CSR_MVIP 0x309 + +/* Smstateen extension registers */ +/* Machine stateen CSRs */ +#define CSR_MSTATEEN0 0x30C +#define CSR_MSTATEEN0H 0x31C +#define CSR_MSTATEEN1 0x30D +#define CSR_MSTATEEN1H 0x31D +#define CSR_MSTATEEN2 0x30E +#define CSR_MSTATEEN2H 0x31E +#define CSR_MSTATEEN3 0x30F +#define CSR_MSTATEEN3H 0x31F + +/* Machine-Level High-Half CSRs (AIA) */ +#define CSR_MIDELEGH 0x313 +#define CSR_MIEH 0x314 +#define CSR_MVIENH 0x318 +#define CSR_MVIPH 0x319 +#define CSR_MIPH 0x354 + +/* ===== Trap/Exception Causes ===== */ + +/* Exception cause high bit - is an interrupt if set */ +#define CAUSE_IRQ_FLAG (_UL(1) << (__riscv_xlen - 1)) + +#define CAUSE_MISALIGNED_FETCH 0x0 +#define CAUSE_FETCH_ACCESS 0x1 +#define CAUSE_ILLEGAL_INSTRUCTION 0x2 +#define CAUSE_BREAKPOINT 0x3 +#define CAUSE_MISALIGNED_LOAD 0x4 +#define CAUSE_LOAD_ACCESS 0x5 +#define CAUSE_MISALIGNED_STORE 0x6 +#define CAUSE_STORE_ACCESS 0x7 +#define CAUSE_USER_ECALL 0x8 +#define CAUSE_SUPERVISOR_ECALL 0x9 +#define CAUSE_VIRTUAL_SUPERVISOR_ECALL 0xa +#define CAUSE_MACHINE_ECALL 0xb +#define CAUSE_FETCH_PAGE_FAULT 0xc +#define CAUSE_LOAD_PAGE_FAULT 0xd +#define CAUSE_STORE_PAGE_FAULT 0xf +#define CAUSE_FETCH_GUEST_PAGE_FAULT 0x14 +#define CAUSE_LOAD_GUEST_PAGE_FAULT 0x15 +#define CAUSE_VIRTUAL_INST_FAULT 0x16 +#define CAUSE_STORE_GUEST_PAGE_FAULT 0x17 + +/* Common defines for all smstateen */ +#define SMSTATEEN_MAX_COUNT 4 +#define SMSTATEEN0_CS_SHIFT 0 +#define SMSTATEEN0_CS (_ULL(1) << SMSTATEEN0_CS_SHIFT) +#define SMSTATEEN0_FCSR_SHIFT 1 +#define SMSTATEEN0_FCSR (_ULL(1) << SMSTATEEN0_FCSR_SHIFT) +#define SMSTATEEN0_IMSIC_SHIFT 58 +#define SMSTATEEN0_IMSIC (_ULL(1) << SMSTATEEN0_IMSIC_SHIFT) +#define SMSTATEEN0_AIA_SHIFT 59 +#define SMSTATEEN0_AIA (_ULL(1) << SMSTATEEN0_AIA_SHIFT) +#define SMSTATEEN0_SVSLCT_SHIFT 60 +#define SMSTATEEN0_SVSLCT (_ULL(1) << SMSTATEEN0_SVSLCT_SHIFT) +#define SMSTATEEN0_HSENVCFG_SHIFT 62 +#define SMSTATEEN0_HSENVCFG (_ULL(1) << SMSTATEEN0_HSENVCFG_SHIFT) +#define SMSTATEEN_STATEN_SHIFT 63 +#define SMSTATEEN_STATEN (_ULL(1) << SMSTATEEN_STATEN_SHIFT) + +/* ===== Instruction Encodings ===== */ + +#define INSN_MATCH_LB 0x3 +#define INSN_MASK_LB 0x707f +#define INSN_MATCH_LH 0x1003 +#define INSN_MASK_LH 0x707f +#define INSN_MATCH_LW 0x2003 +#define INSN_MASK_LW 0x707f +#define INSN_MATCH_LD 0x3003 +#define INSN_MASK_LD 0x707f +#define INSN_MATCH_LBU 0x4003 +#define INSN_MASK_LBU 0x707f +#define INSN_MATCH_LHU 0x5003 +#define INSN_MASK_LHU 0x707f +#define INSN_MATCH_LWU 0x6003 +#define INSN_MASK_LWU 0x707f +#define INSN_MATCH_SB 0x23 +#define INSN_MASK_SB 0x707f +#define INSN_MATCH_SH 0x1023 +#define INSN_MASK_SH 0x707f +#define INSN_MATCH_SW 0x2023 +#define INSN_MASK_SW 0x707f +#define INSN_MATCH_SD 0x3023 +#define INSN_MASK_SD 0x707f + +#define INSN_MATCH_FLW 0x2007 +#define INSN_MASK_FLW 0x707f +#define INSN_MATCH_FLD 0x3007 +#define INSN_MASK_FLD 0x707f +#define INSN_MATCH_FLQ 0x4007 +#define INSN_MASK_FLQ 0x707f +#define INSN_MATCH_FSW 0x2027 +#define INSN_MASK_FSW 0x707f +#define INSN_MATCH_FSD 0x3027 +#define INSN_MASK_FSD 0x707f +#define INSN_MATCH_FSQ 0x4027 +#define INSN_MASK_FSQ 0x707f + +#define INSN_MATCH_C_LD 0x6000 +#define INSN_MASK_C_LD 0xe003 +#define INSN_MATCH_C_SD 0xe000 +#define INSN_MASK_C_SD 0xe003 +#define INSN_MATCH_C_LW 0x4000 +#define INSN_MASK_C_LW 0xe003 +#define INSN_MATCH_C_SW 0xc000 +#define INSN_MASK_C_SW 0xe003 +#define INSN_MATCH_C_LDSP 0x6002 +#define INSN_MASK_C_LDSP 0xe003 +#define INSN_MATCH_C_SDSP 0xe002 +#define INSN_MASK_C_SDSP 0xe003 +#define INSN_MATCH_C_LWSP 0x4002 +#define INSN_MASK_C_LWSP 0xe003 +#define INSN_MATCH_C_SWSP 0xc002 +#define INSN_MASK_C_SWSP 0xe003 + +#define INSN_MATCH_C_FLD 0x2000 +#define INSN_MASK_C_FLD 0xe003 +#define INSN_MATCH_C_FLW 0x6000 +#define INSN_MASK_C_FLW 0xe003 +#define INSN_MATCH_C_FSD 0xa000 +#define INSN_MASK_C_FSD 0xe003 +#define INSN_MATCH_C_FSW 0xe000 +#define INSN_MASK_C_FSW 0xe003 +#define INSN_MATCH_C_FLDSP 0x2002 +#define INSN_MASK_C_FLDSP 0xe003 +#define INSN_MATCH_C_FSDSP 0xa002 +#define INSN_MASK_C_FSDSP 0xe003 +#define INSN_MATCH_C_FLWSP 0x6002 +#define INSN_MASK_C_FLWSP 0xe003 +#define INSN_MATCH_C_FSWSP 0xe002 +#define INSN_MASK_C_FSWSP 0xe003 + +#define INSN_MASK_WFI 0xffffff00 +#define INSN_MATCH_WFI 0x10500000 + +#define INSN_MASK_FENCE_TSO 0xffffffff +#define INSN_MATCH_FENCE_TSO 0x8330000f + +#if __riscv_xlen == 64 + +/* 64-bit read for VS-stage address translation (RV64) */ +#define INSN_PSEUDO_VS_LOAD 0x00003000 + +/* 64-bit write for VS-stage address translation (RV64) */ +#define INSN_PSEUDO_VS_STORE 0x00003020 + +#elif __riscv_xlen == 32 + +/* 32-bit read for VS-stage address translation (RV32) */ +#define INSN_PSEUDO_VS_LOAD 0x00002000 + +/* 32-bit write for VS-stage address translation (RV32) */ +#define INSN_PSEUDO_VS_STORE 0x00002020 + +#else +#error "Unexpected __riscv_xlen" +#endif + +#define INSN_16BIT_MASK 0x3 +#define INSN_32BIT_MASK 0x1c + +#define INSN_IS_16BIT(insn) \ + (((insn) & INSN_16BIT_MASK) != INSN_16BIT_MASK) +#define INSN_IS_32BIT(insn) \ + (((insn) & INSN_16BIT_MASK) == INSN_16BIT_MASK && \ + ((insn) & INSN_32BIT_MASK) != INSN_32BIT_MASK) + +#define INSN_LEN(insn) (INSN_IS_16BIT(insn) ? 2 : 4) + +#if __riscv_xlen == 64 +#define LOG_REGBYTES 3 +#else +#define LOG_REGBYTES 2 +#endif +#define REGBYTES (1 << LOG_REGBYTES) + +#define SH_RD 7 +#define SH_RS1 15 +#define SH_RS2 20 +#define SH_RS2C 2 + +#define RV_X(x, s, n) (((x) >> (s)) & ((1 << (n)) - 1)) +#define RVC_LW_IMM(x) ((RV_X(x, 6, 1) << 2) | \ + (RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 5, 1) << 6)) +#define RVC_LD_IMM(x) ((RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 5, 2) << 6)) +#define RVC_LWSP_IMM(x) ((RV_X(x, 4, 3) << 2) | \ + (RV_X(x, 12, 1) << 5) | \ + (RV_X(x, 2, 2) << 6)) +#define RVC_LDSP_IMM(x) ((RV_X(x, 5, 2) << 3) | \ + (RV_X(x, 12, 1) << 5) | \ + (RV_X(x, 2, 3) << 6)) +#define RVC_SWSP_IMM(x) ((RV_X(x, 9, 4) << 2) | \ + (RV_X(x, 7, 2) << 6)) +#define RVC_SDSP_IMM(x) ((RV_X(x, 10, 3) << 3) | \ + (RV_X(x, 7, 3) << 6)) +#define RVC_RS1S(insn) (8 + RV_X(insn, SH_RD, 3)) +#define RVC_RS2S(insn) (8 + RV_X(insn, SH_RS2C, 3)) +#define RVC_RS2(insn) RV_X(insn, SH_RS2C, 5) + +#define SHIFT_RIGHT(x, y) \ + ((y) < 0 ? ((x) << -(y)) : ((x) >> (y))) + +#define REG_MASK \ + ((1 << (5 + LOG_REGBYTES)) - (1 << LOG_REGBYTES)) + +#define REG_OFFSET(insn, pos) \ + (SHIFT_RIGHT((insn), (pos) - LOG_REGBYTES) & REG_MASK) + +#define REG_PTR(insn, pos, regs) \ + (unsigned long *)((unsigned long)(regs) + REG_OFFSET(insn, pos)) + +#define GET_RM(insn) (((insn) >> 12) & 7) + +#define GET_RS1(insn, regs) (*REG_PTR(insn, SH_RS1, regs)) +#define GET_RS2(insn, regs) (*REG_PTR(insn, SH_RS2, regs)) +#define GET_RS1S(insn, regs) (*REG_PTR(RVC_RS1S(insn), 0, regs)) +#define GET_RS2S(insn, regs) (*REG_PTR(RVC_RS2S(insn), 0, regs)) +#define GET_RS2C(insn, regs) (*REG_PTR(insn, SH_RS2C, regs)) +#define GET_SP(regs) (*REG_PTR(2, 0, regs)) +#define SET_RD(insn, regs, val) (*REG_PTR(insn, SH_RD, regs) = (val)) +#define IMM_I(insn) ((int32_t)(insn) >> 20) +#define IMM_S(insn) (((int32_t)(insn) >> 25 << 5) | \ + (int32_t)(((insn) >> 7) & 0x1f)) +#define MASK_FUNCT3 0x7000 + +/* clang-format on */ + +#endif -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491185.760172 (Exim 4.92) (envelope-from ) id 1pPPFJ-00043m-DZ; Tue, 07 Feb 2023 14:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491185.760172; Tue, 07 Feb 2023 14:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFJ-00043f-AN; Tue, 07 Feb 2023 14:46:57 +0000 Received: by outflank-mailman (input) for mailman id 491185; Tue, 07 Feb 2023 14:46:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFH-00043Z-Mg for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:46:55 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 435db7ae-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:46:54 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id o18so13802520wrj.3 for ; Tue, 07 Feb 2023 06:46:54 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:46:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 435db7ae-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AMHmfkHHTHE0v8pkna6MESdKkLlHbxr+3nLxEqnuiC4=; b=JJI6HdRHIWyCG0Qcly/fFIST+Tcw6IpEg44w2jU+neU9OLHt6feqdUdJUAC+jR9jMZ 27ARJoCYBkXc0FL0UjJWCPiJEWaASW6ffCQKesJjBg6FvS2WixNHIzBgX38hvF2CAVPU FFJwy7qKs/C+nw8uk0h45KmcB3qZHZGAOvRGEUTTGeOmC1g9oOdfpxHqVNsMl8Kl86wM swKJxCoqZ6zDJPG45WlE59CIdFEeOWAASU0adaTHk40Ey3jyDKp4aruCMpKqGJy2Bp6B aiCHdeIxntwjD6/wnyK2Usu48SNyrjXlylq28uJeyCtaYCgSbHIZPPwFMQlFJtyth0cz wTIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AMHmfkHHTHE0v8pkna6MESdKkLlHbxr+3nLxEqnuiC4=; b=RTLw/nuySScArWW/Ybk/auOP3rVOhZtEtvbZPXsxTYbJ7D+Kf+Sozd+G6Z1rVYm5R0 mNWRhb8WZBzKhjgUbV05XH+ZlcLbLdaJ8VR4RI+RbVGiso1wcToA5YQD9IUeklWWee4K IQMY22gqGiapw23H2fViNqeqAjaOHTiaefVqx3kRvF3W8MOkDW+FUOwFeCc1UAjcjpMF jtup7StB2LT4EW1PkpmfsjS3B8txJb8m3mCQBpVbA2NaN0nOMVcNP8tKFvXGgDK5enNk pxExPzd/aC+xYa1ISXAv6Spr26HCiuRAu6+j3srdP5IAze2q6J6eyhnIOjyJ6/J66pLh 2Gxw== X-Gm-Message-State: AO0yUKVLLlr+hRd0axTBoCo6GVVEzCfb9UvOHb/nGLYz8I36w36LT+FT x3R5SWN2QQhYuY07YxdoRWGrVC+AlJM= X-Google-Smtp-Source: AK7set98BUQF2JfES/VGC6uCGFzYm12btefrioeDJfWkGepohAAunlIN0GLPqqAWrAY6y6FHTg6uwQ== X-Received: by 2002:adf:e786:0:b0:2c3:def9:7e1a with SMTP id n6-20020adfe786000000b002c3def97e1amr3055414wrm.44.1675781213722; Tue, 07 Feb 2023 06:46:53 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v3 00/14] RISCV basic exception handling implementation Date: Tue, 7 Feb 2023 16:46:35 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The patch series is based on another one [Basic early_printk and smoke test implementation] and [introduce generic implementation of macros from bug.h] which haven't been commited yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instruction if an exception can not be handled. To verify that exception handling works well it was implemented macros from such as BUG/WARN/run_in_exception/assert_failed. The implementation of macros is used "ebreak" instruction and set up bug frame tables for each type of macros. Also it was implemented register save/restore to return and continue work after WARN/run_in_exception. Not all functionality of the macros was implemented as some of them require hard-panic the system which is not available now. Instead of hard-panic 'wfi' instruction is used but it should be definitely changed in the neareset future. It wasn't implemented show_execution_state() and stack trace discovering as it's not necessary now. --- Changes in V3: - Change the name of config RISCV_ISA_RV64IMA to RISCV_ISA_RV64G as instructions from Zicsr and Zifencei extensions aren't part of I extension any more. - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] - Update commit messages --- Changes in V2: - take the latest riscv_encoding.h from OpenSBI, update it with Xen related changes, and update the commit message with "Origin:" tag and the commit message itself. - add "Origin:" tag to the commit messag of the patch [xen/riscv: add header]. - Remove the patch [xen/riscv: add early_printk_hnum() function] as the functionality provided by the patch isn't used now. - Refactor prcoess.h: move structure offset defines to asm-offsets.c, change register_t to unsigned long. - Refactor entry.S to use offsets defined in asm-offsets.C - Rename {__,}handle_exception to handle_trap() and do_trap() to be more consistent with RISC-V spec. - Merge the pathc which introduces do_unexpected_trap() with the patch [xen/riscv: introduce exception handlers implementation]. - Rename setup_trap_handler() to trap_init() and update correspondingly the patches in the patch series. - Refactor bug.h, remove bug_instr_t type from it. - Refactor decode_trap_cause() function to be more optimization-friendly. - Add two new empty headers: and as they are needed to include which provides ARRAY_SIZE and other macros. - Code style fixes. --- Oleksii Kurochko (14): xen/riscv: change ISA to r64G xen/riscv: add header xen/riscv: add header xen/riscv: introduce empty xen/riscv: introduce empty xen/riscv: introduce exception context xen/riscv: introduce exception handlers implementation xen/riscv: introduce decode_cause() stuff xen/riscv: mask all interrupts xen/riscv: introduce trap_init() xen/riscv: introduce an implementation of macros from xen/riscv: test basic handling stuff automation: modify RISC-V smoke test automation/scripts/qemu-smoke-riscv64.sh | 2 +- xen/arch/riscv/Kconfig | 14 +- xen/arch/riscv/Makefile | 2 + xen/arch/riscv/arch.mk | 2 +- xen/arch/riscv/entry.S | 94 ++ xen/arch/riscv/include/asm/asm.h | 54 ++ xen/arch/riscv/include/asm/bug.h | 38 + xen/arch/riscv/include/asm/cache.h | 6 + xen/arch/riscv/include/asm/csr.h | 84 ++ xen/arch/riscv/include/asm/processor.h | 82 ++ xen/arch/riscv/include/asm/riscv_encoding.h | 927 ++++++++++++++++++++ xen/arch/riscv/include/asm/string.h | 6 + xen/arch/riscv/include/asm/traps.h | 14 + xen/arch/riscv/riscv64/asm-offsets.c | 53 ++ xen/arch/riscv/riscv64/head.S | 5 + xen/arch/riscv/setup.c | 22 +- xen/arch/riscv/traps.c | 233 +++++ xen/arch/riscv/xen.lds.S | 10 + 18 files changed, 1640 insertions(+), 8 deletions(-) create mode 100644 xen/arch/riscv/entry.S create mode 100644 xen/arch/riscv/include/asm/asm.h create mode 100644 xen/arch/riscv/include/asm/bug.h create mode 100644 xen/arch/riscv/include/asm/cache.h create mode 100644 xen/arch/riscv/include/asm/csr.h create mode 100644 xen/arch/riscv/include/asm/processor.h create mode 100644 xen/arch/riscv/include/asm/riscv_encoding.h create mode 100644 xen/arch/riscv/include/asm/string.h create mode 100644 xen/arch/riscv/include/asm/traps.h create mode 100644 xen/arch/riscv/traps.c -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491187.760190 (Exim 4.92) (envelope-from ) id 1pPPFM-0004Pt-4u; Tue, 07 Feb 2023 14:47:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491187.760190; Tue, 07 Feb 2023 14:47:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFM-0004OG-0P; Tue, 07 Feb 2023 14:47:00 +0000 Received: by outflank-mailman (input) for mailman id 491187; Tue, 07 Feb 2023 14:46:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFL-0004Hz-At for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:46:59 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4469773f-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:46:56 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id i5so6624533wrc.0 for ; Tue, 07 Feb 2023 06:46:56 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:46:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4469773f-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BeKlKQYE7Ni0q7sa33oNWy1hbogFwzoa9jmFgKxuPpg=; b=YpY2gkWaM3zV8ZLTipnSRbsaciGgxykBKswjqXD9rs2M08Yb1xKF6N1rIUKI+Sntjh 6aVlI3f+2gm0ojcPul6HrkhnAT7tWT27pOvcCVYNaDSss2iCzKZB5DGP/051Y2HEfJtj DJqT6LGFHO0thy6tJ8+stYjgNiyIYiYiIFA7AGR7XjLboitoQ7P2EVPMzVJBKNfburEU 2jszF0t51cHIwGp2+hPLJPElczd8ErI+Ku/ZqwLVQmqJAAcE1abNtruM87VMjSOQ80M7 eXF2ItubuoPHMjeSYT/1eLGFBoqRX1HQUe9cv8f1aOXPnUehZDYvH0S3GAyQTuwp5zh+ J8BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BeKlKQYE7Ni0q7sa33oNWy1hbogFwzoa9jmFgKxuPpg=; b=tGnd0o1x0B86yZXaX15ycYFaUQYp2B4lN1XeDWoCOqgZHvCkbVTCFUhrorHnVDCvTb jrYXkXXcfnptRfuQ0iXpr/n32J9aIQBGFpx6tgIOFRWIqlHfcFyfUNyl7FkVT7e+dmki e4D9FK2Z2nE92F6GRFnyVGqK18Rl4sRcXJWdjr86TeSJQciYk+7Fim3JfTTKyk+qsxiQ 3WJN5TKIkS0AlcodGq13W6LmH+rzD7aG9zVJLjVMSUBuNruCoXZyn8aEgKghlW0RLXx5 byZPproVVI27alvyGp+vCGPSJju2+JaFB1MXtg76JsHU96tPt0AMGV9UXE9qWn6DeA/+ 7W3g== X-Gm-Message-State: AO0yUKX+i+ePB3eGe044AXsocn+FBSIxLrj801G1DijZk4ifUqul71Ml ChjbxXaiSHzbdoVXvW7LasSZQjqyFZA= X-Google-Smtp-Source: AK7set9Gs824FluQ0oqE09fWcuFr5+gOFbrFPP88qJeejCuF+aPWckC5o5p1oW14I1IaA5jbIhq5Sw== X-Received: by 2002:a5d:488b:0:b0:2bf:e533:315a with SMTP id g11-20020a5d488b000000b002bfe533315amr2837644wrq.62.1675781215205; Tue, 07 Feb 2023 06:46:55 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 01/14] xen/riscv: change ISA to r64G Date: Tue, 7 Feb 2023 16:46:36 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Work with some registers requires csr command which is part of Zicsr. Also ISA was changed from r64ima to r64g where G is represented the “IMAFDZicsr Zifencei” base and extensions so basically it is the same as it was before plus additional extensions we will need in the nearest future. Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V3: - Change the name of config RISCV_ISA_RV64IMA to RISCV_ISA_RV64G as instructions from Zicsr and Zifencei extensions aren't part of I extension any more. --- Changes in V2: - Nothing changed --- xen/arch/riscv/Kconfig | 14 +++++++++----- xen/arch/riscv/arch.mk | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig index 468e250c86..f382b36f6c 100644 --- a/xen/arch/riscv/Kconfig +++ b/xen/arch/riscv/Kconfig @@ -19,15 +19,19 @@ menu "ISA Selection" choice prompt "Base ISA" - default RISCV_ISA_RV64IMA if RISCV_64 + default RISCV_ISA_RV64G if RISCV_64 help This selects the base ISA extensions that Xen will target. -config RISCV_ISA_RV64IMA - bool "RV64IMA" +config RISCV_ISA_RV64G + bool "RV64G" help - Use the RV64I base ISA, plus the "M" and "A" extensions - for integer multiply/divide and atomic instructions, respectively. + Use the RV64I base ISA, plus + "M" for multiply/divide, + "A" for atomic instructions, + “F”/"D" for {single/double}-precision floating-point instructions, + "Zicsr" for control and status register access, + "Zifencei" for instruction-fetch fence. endchoice diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk index 012dc677c3..45fe858ee0 100644 --- a/xen/arch/riscv/arch.mk +++ b/xen/arch/riscv/arch.mk @@ -3,7 +3,7 @@ CFLAGS-$(CONFIG_RISCV_64) += -mabi=lp64 -riscv-march-$(CONFIG_RISCV_ISA_RV64IMA) := rv64ima +riscv-march-$(CONFIG_RISCV_ISA_RV64G) := rv64g riscv-march-$(CONFIG_RISCV_ISA_C) := $(riscv-march-y)c # Note that -mcmodel=medany is used so that Xen can be mapped -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491186.760182 (Exim 4.92) (envelope-from ) id 1pPPFL-0004Iw-MA; Tue, 07 Feb 2023 14:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491186.760182; Tue, 07 Feb 2023 14:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFL-0004Io-JM; Tue, 07 Feb 2023 14:46:59 +0000 Received: by outflank-mailman (input) for mailman id 491186; Tue, 07 Feb 2023 14:46:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFJ-00043Z-QZ for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:46:57 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4515cb25-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:46:57 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id i5so6624587wrc.0 for ; Tue, 07 Feb 2023 06:46:57 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:46:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4515cb25-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3tgYfAfD7y5+s+fFwercTLYRC593TWNu/7OHh5VrJ1Y=; b=mtUiH24LSxdP83e3/HoZXgc0OSVrOXMZMcwetkPgnyCh7NTtvPvHdSqhUmfgoOXfjG 3Vy3kMX6XdDkBUxrJRZiL802ZUViLF/QSv8ug/V7uWD32qsl9Gxi/kmfHz2NEyfLZ4He woSGDLNeeutwfm3i3ZY86XtvDhzsNqVIcdkBHVD6FX2m1TsriDf9AeJsVWPkTLBwndYB nJT8PrAIIVMvMmm8N8cQO/eQEum5PioQprmtXeT01A0fmCv7EgpXgVhzQuTyfVWzJgyw WzfWMeh67YspgiKw6C5DE2xLTKEd/5HZQwqrpN/ugVtTJ+0A3sGYknkruujams3oE0mJ cy1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3tgYfAfD7y5+s+fFwercTLYRC593TWNu/7OHh5VrJ1Y=; b=sq3Ehho7Hv/y/9Pp7Z3A8n7y1jG3+wRncBzjfoO+khrNp9AiAV6KAAVmZ++d4m9u+G YcaYNG8F5Rj3ei5ANKg7OPcQHi7Dt1UoCJKIY7IvbAT06JJdUAckn7bJCDr7qD3JiH4C qLJ5p0Q6OTA29dagEz8jWaFSeXLrO4rx9C8hGjFsBcXQZZHi9KMa6fK+3tGEyDJpbdzD 8iNP5frkJJLYBZs7gCEHiaIuHLLiDjsJQTAFDgLpu4/K5lJwAHfVUxp+iMRMA/9+4C7N jPpKkGFV26qhtiEJH7ZKAtMr67uOFmWa6CVh2Fz9BxbTZKCRoc7+astC3q7PbgQ+vBBG M5rA== X-Gm-Message-State: AO0yUKVYtYWUCCc1ukBDAeM6AUKkhP36wVUahWjSaycdUscWcbtSOKz1 kyohqejqg+gQI9w3QWEIsJOcY2ECF34= X-Google-Smtp-Source: AK7set/Ro8PcNKY56BKu1kk8MYAYlHQ4VC0V0zDkbBq20MZDeqvG877jB1ZF4xqM4qub7WdYBiNxFg== X-Received: by 2002:a05:6000:110e:b0:2bf:95fb:e5b3 with SMTP id z14-20020a056000110e00b002bf95fbe5b3mr2886114wrw.33.1675781216795; Tue, 07 Feb 2023 06:46:56 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 02/14] xen/riscv: add header Date: Tue, 7 Feb 2023 16:46:37 +0200 Message-Id: <0c7192216497663865fa220c95301c357a846568.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Nothing changed --- xen/arch/riscv/include/asm/asm.h | 54 ++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 xen/arch/riscv/include/asm/asm.h diff --git a/xen/arch/riscv/include/asm/asm.h b/xen/arch/riscv/include/asm/asm.h new file mode 100644 index 0000000000..6d426ecea7 --- /dev/null +++ b/xen/arch/riscv/include/asm/asm.h @@ -0,0 +1,54 @@ +/* SPDX-License-Identifier: (GPL-2.0-only) */ +/* + * Copyright (C) 2015 Regents of the University of California + */ + +#ifndef _ASM_RISCV_ASM_H +#define _ASM_RISCV_ASM_H + +#ifdef __ASSEMBLY__ +#define __ASM_STR(x) x +#else +#define __ASM_STR(x) #x +#endif + +#if __riscv_xlen == 64 +#define __REG_SEL(a, b) __ASM_STR(a) +#elif __riscv_xlen == 32 +#define __REG_SEL(a, b) __ASM_STR(b) +#else +#error "Unexpected __riscv_xlen" +#endif + +#define REG_L __REG_SEL(ld, lw) +#define REG_S __REG_SEL(sd, sw) + +#if __SIZEOF_POINTER__ == 8 +#ifdef __ASSEMBLY__ +#define RISCV_PTR .dword +#else +#define RISCV_PTR ".dword" +#endif +#elif __SIZEOF_POINTER__ == 4 +#ifdef __ASSEMBLY__ +#define RISCV_PTR .word +#else +#define RISCV_PTR ".word" +#endif +#else +#error "Unexpected __SIZEOF_POINTER__" +#endif + +#if (__SIZEOF_INT__ == 4) +#define RISCV_INT __ASM_STR(.word) +#else +#error "Unexpected __SIZEOF_INT__" +#endif + +#if (__SIZEOF_SHORT__ == 2) +#define RISCV_SHORT __ASM_STR(.half) +#else +#error "Unexpected __SIZEOF_SHORT__" +#endif + +#endif /* _ASM_RISCV_ASM_H */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491195.760273 (Exim 4.92) (envelope-from ) id 1pPPFY-0006cn-PA; Tue, 07 Feb 2023 14:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491195.760273; Tue, 07 Feb 2023 14:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFY-0006Z1-BZ; Tue, 07 Feb 2023 14:47:12 +0000 Received: by outflank-mailman (input) for mailman id 491195; Tue, 07 Feb 2023 14:47:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFW-0004Hz-6j for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:10 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bc4786e-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:47:08 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id j25so10260650wrc.4 for ; Tue, 07 Feb 2023 06:47:08 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bc4786e-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWyN2AklZ+5udnDul9odmXqegN4DHlE2VSRiWyrifCk=; b=ocaxVvlYtFP008qmuBCn/r0eoVYyRMrmmcenV4lyrF8OElaW4XdvlMrx+yszOoiZdf Ql2uCW6a/XmmfBCYhNXzP4UP3tjLFdO2lZOeRM+AQCIA597VSiK1XQkuntVi54QsLcpg zoYTYZQIJb22Eo90typrTbaFXAyS0KHX+vsYOHh9t2VuxrywjleIt3N9vqoZKXrOQSBg AkqAUuoEZiPiA4BCVJftf3phbGObVDP6qsUZHdM+zUm1r6jRGGCp/Lk45cl8miibo5Wy 2qNxGKPj2m6i8xa4/rywq0NndmT19XjHhKJyX3h2nd6rcdLe9LKm5U4ICdVIjpnm6K3i 9ynw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UWyN2AklZ+5udnDul9odmXqegN4DHlE2VSRiWyrifCk=; b=eqKGyu80pn0qVaM4gz4q2CIu685AqH2cF3+IATCUpem5s+PSEaHPOdE7iL2uOG1DJE Y6fSewm3w2RYfsTojjVaykZkh5kXMh5hdlhBZVhLuFhfc4BVbrnFagS/G3tUgqREnoTF J6TO60ryhZzsZghCRpDsu8BlUNKELg/GJ/nHlSMm5/Pm7T+BKL62SB7y33aLhADHLnjv YgXT49Ok2FWYpjq4Oc5Hk2TlqXZKAjs/Re7Fjtl1FhosZ0eR9gSaW9DI66NuMCJXXmJv hSx6YxtkmU6bKyQyz+6G1hX2EWbJUTWS4Kmdyq7XWn74J8R+RZzwnq8ysnZakay/Zmy0 fANA== X-Gm-Message-State: AO0yUKUrMHiq6765HHFfdWbWJPlL2FxRSPX/o7ZJyePn6rN/NMQzIqCj czQN6F+Os/q+I2pizqLDT0bQnJwpenk= X-Google-Smtp-Source: AK7set8dhxnbXJj/Yc55LnNr+mWVMKyhsLBz++8X5Ub8Iyp/LGs9KzAIIqY4J88YsD5O3q6qurIfHQ== X-Received: by 2002:adf:f485:0:b0:2c3:e297:8e4d with SMTP id l5-20020adff485000000b002c3e2978e4dmr2480852wro.6.1675781227718; Tue, 07 Feb 2023 06:47:07 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 09/14] xen/riscv: introduce decode_cause() stuff Date: Tue, 7 Feb 2023 16:46:44 +0200 Message-Id: <0198e2a5b572b9031eafe7cd1c85c6f9537b704c.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko --- Changes in V3: - Nothing changed --- Changes in V2: - Make decode_trap_cause() more optimization friendly. - Merge the pathc which introduces do_unexpected_trap() to the current one. --- xen/arch/riscv/traps.c | 85 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 84 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index ccd3593f5a..f2a1e1ffcf 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -4,10 +4,93 @@ * * RISC-V Trap handlers */ +#include +#include #include #include +#include +#include -void do_trap(struct cpu_user_regs *cpu_regs) +static const char *decode_trap_cause(unsigned long cause) +{ + static const char *const trap_causes[] = { + [CAUSE_MISALIGNED_FETCH] = "Instruction Address Misaligned", + [CAUSE_FETCH_ACCESS] = "Instruction Access Fault", + [CAUSE_ILLEGAL_INSTRUCTION] = "Illegal Instruction", + [CAUSE_BREAKPOINT] = "Breakpoint", + [CAUSE_MISALIGNED_LOAD] = "Load Address Misaligned", + [CAUSE_LOAD_ACCESS] = "Load Access Fault", + [CAUSE_MISALIGNED_STORE] = "Store/AMO Address Misaligned", + [CAUSE_STORE_ACCESS] = "Store/AMO Access Fault", + [CAUSE_USER_ECALL] = "Environment Call from U-Mode", + [CAUSE_SUPERVISOR_ECALL] = "Environment Call from S-Mode", + [CAUSE_MACHINE_ECALL] = "Environment Call from M-Mode", + [CAUSE_FETCH_PAGE_FAULT] = "Instruction Page Fault", + [CAUSE_LOAD_PAGE_FAULT] = "Load Page Fault", + [CAUSE_STORE_PAGE_FAULT] = "Store/AMO Page Fault", + [CAUSE_FETCH_GUEST_PAGE_FAULT] = "Instruction Guest Page Fault", + [CAUSE_LOAD_GUEST_PAGE_FAULT] = "Load Guest Page Fault", + [CAUSE_VIRTUAL_INST_FAULT] = "Virtualized Instruction Fault", + [CAUSE_STORE_GUEST_PAGE_FAULT] = "Guest Store/AMO Page Fault", + }; + + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) + return trap_causes[cause]; + return "UNKNOWN"; +} + +const char *decode_reserved_interrupt_cause(unsigned long irq_cause) +{ + switch ( irq_cause ) + { + case IRQ_M_SOFT: + return "M-mode Software Interrupt"; + case IRQ_M_TIMER: + return "M-mode TIMER Interrupt"; + case IRQ_M_EXT: + return "M-mode TIMER Interrupt"; + default: + return "UNKNOWN IRQ type"; + } +} + +const char *decode_interrupt_cause(unsigned long cause) +{ + unsigned long irq_cause = cause & ~CAUSE_IRQ_FLAG; + + switch ( irq_cause ) + { + case IRQ_S_SOFT: + return "Supervisor Software Interrupt"; + case IRQ_S_TIMER: + return "Supervisor Timer Interrupt"; + case IRQ_S_EXT: + return "Supervisor External Interrupt"; + default: + return decode_reserved_interrupt_cause(irq_cause); + } +} + +const char *decode_cause(unsigned long cause) +{ + if ( cause & CAUSE_IRQ_FLAG ) + return decode_interrupt_cause(cause); + + return decode_trap_cause(cause); +} + +static void do_unexpected_trap(const struct cpu_user_regs *regs) { + unsigned long cause = csr_read(CSR_SCAUSE); + + early_printk("Unhandled exception: "); + early_printk(decode_cause(cause)); + early_printk("\n"); + die(); } + +void do_trap(struct cpu_user_regs *cpu_regs) +{ + do_unexpected_trap(cpu_regs); +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491192.760244 (Exim 4.92) (envelope-from ) id 1pPPFT-0005kA-Ub; Tue, 07 Feb 2023 14:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491192.760244; Tue, 07 Feb 2023 14:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFT-0005jp-Oe; Tue, 07 Feb 2023 14:47:07 +0000 Received: by outflank-mailman (input) for mailman id 491192; Tue, 07 Feb 2023 14:47:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFS-00043Z-LI for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:06 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a3b7ca3-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:05 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id h3so5955059wrp.10 for ; Tue, 07 Feb 2023 06:47:06 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a3b7ca3-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CM5HAZAjC5AS1XK7mKrfXtpw4DHmLtXflVKppyEPcdo=; b=QBriLcpZb17+mIDzi2hjXl/GfUukjGfTQRZexvrZ+QPKD1zSlUt5+GASQzCrg8Gy8A P8bgxeSlxuW/ydZTZI7mRfFUHCaz6RqcaXmKkXk1k8dcN+zDwUwH+qnZsXfwsKaL7rfV XwXL/dSjYDxq6N72X/6Y+WDdYlpSDwyMKdzE2IUazeOWiGSeRtlTkm9w16LCEOMckSMi 1Y42XMiG9rCudzursKW6xmFLU7Z5hCNqBMQDk2hbwN4r/GbYnxzLYifj1jSaQQzhdYSE tXSyi192ftfYr1P0P9NI1zfcEmpQAvlb9zMpnAWYhtenPgJKEgJh09snizFHNY7rFFUF 4hDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CM5HAZAjC5AS1XK7mKrfXtpw4DHmLtXflVKppyEPcdo=; b=D/aeDHjw27MwWf1yvN6pTXLUVNpIxbtTfLVDCqsLHoIWIWydKCd8N2r3McrRoYXVR+ g1hd8VpKTOxbZ0IWRATbsCOnaCLraCqCYOeHhhr8sirH2FIdgNfCWz1RGBYQ6NO1zrRl 5PoJLtEListljkHTLsrsSBkS/dCdjd9QxrTLt71TlWYhgQPchwKWXOvhq8ce3Ofitw9e 5/W2iKEFwxFrY1ucFDA1nrZZ/nTJU2FyaN+J+GXLiBpotpKyCB79IuAMvRfDB4+tSuuS BTqDk9uXj6z0Zh/8U2+MngCv437MoXkr/uxtZPzKVd8ajXHOu7rgogW1YR/qo/TZMsyg o8vA== X-Gm-Message-State: AO0yUKU9zeAAD74Zy+UoY3MS3TXOr0eZqWzqIQSjPRbmpWVGlXU6DigA xp1J+t5ilVbgzSBK4MGlKP9EZQRI6yI= X-Google-Smtp-Source: AK7set9ECa3KSNKJ9bKD3YYek4ecROKFNbQm3F0y6p2soM6Yv1NRvKI0Jzh3WUrYcgqWkTpTMDqIkQ== X-Received: by 2002:adf:f80c:0:b0:2c3:cdcd:f0b3 with SMTP id s12-20020adff80c000000b002c3cdcdf0b3mr2739661wrp.9.1675781225280; Tue, 07 Feb 2023 06:47:05 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Subject: [PATCH v3 07/14] xen/riscv: introduce exception context Date: Tue, 7 Feb 2023 16:46:42 +0200 Message-Id: <5aa05592497ba9c4d207185d81981442d43ba676.1675780434.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces a set of registers which should be saved to and restored from a stack after an exception occurs and a set of defines which will be used during exception context saving/restoring. Originally header was introduced in the patch series from Bobby so partially it was re-used and the following changes were done: - Move all RISCV_CPU_USER_REGS_* to asm/asm-offsets.c - Remove RISCV_CPU_USER_REGS_OFFSET & RISCV_CPU_USER_REGS_SIZE as there is no sense in them after RISCV_CPU_USER_REGS_* were moved to asm/asm-offsets.c - Remove RISCV_PCPUINFO_* as they aren't needed for current status of the RISC-V port - register_t renamed to unsigned long - rename wait_for_interrupt to wfi Signed-off-by: Bobby Eshleman Signed-off-by: Oleksii Kurochko --- Changes in V3: - update code style for die() function --- Changes in V2: - All the changes were added to the commit message. - temporarily was added function die() to stop exectution it will be removed after panic() will be available. --- xen/arch/riscv/include/asm/processor.h | 83 ++++++++++++++++++++++++++ xen/arch/riscv/riscv64/asm-offsets.c | 53 ++++++++++++++++ 2 files changed, 136 insertions(+) create mode 100644 xen/arch/riscv/include/asm/processor.h diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h new file mode 100644 index 0000000000..a71448e02e --- /dev/null +++ b/xen/arch/riscv/include/asm/processor.h @@ -0,0 +1,83 @@ +/* SPDX-License-Identifier: MIT */ +/****************************************************************************** + * + * Copyright 2019 (C) Alistair Francis + * Copyright 2021 (C) Bobby Eshleman + * Copyright 2023 (C) Vates + * + */ + +#ifndef _ASM_RISCV_PROCESSOR_H +#define _ASM_RISCV_PROCESSOR_H + +#ifndef __ASSEMBLY__ + +/* On stack VCPU state */ +struct cpu_user_regs +{ + unsigned long zero; + unsigned long ra; + unsigned long sp; + unsigned long gp; + unsigned long tp; + unsigned long t0; + unsigned long t1; + unsigned long t2; + unsigned long s0; + unsigned long s1; + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; + unsigned long a4; + unsigned long a5; + unsigned long a6; + unsigned long a7; + unsigned long s2; + unsigned long s3; + unsigned long s4; + unsigned long s5; + unsigned long s6; + unsigned long s7; + unsigned long s8; + unsigned long s9; + unsigned long s10; + unsigned long s11; + unsigned long t3; + unsigned long t4; + unsigned long t5; + unsigned long t6; + unsigned long sepc; + unsigned long sstatus; + /* pointer to previous stack_cpu_regs */ + unsigned long pregs; +}; + +static inline void wfi(void) +{ + __asm__ __volatile__ ("wfi"); +} + +/* + * panic() isn't available at the moment so an infinite loop will be + * used temporarily. + * TODO: change it to panic() + */ +static inline void die(void) +{ + for ( ;; ) + wfi(); +} + +#endif /* __ASSEMBLY__ */ + +#endif /* _ASM_RISCV_PROCESSOR_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/riscv/riscv64/asm-offsets.c b/xen/arch/riscv/riscv64/asm-offsets.c index e69de29bb2..d632b75c2a 100644 --- a/xen/arch/riscv/riscv64/asm-offsets.c +++ b/xen/arch/riscv/riscv64/asm-offsets.c @@ -0,0 +1,53 @@ +#define COMPILE_OFFSETS + +#include +#include + +#define DEFINE(_sym, _val) \ + asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ + : : "i" (_val) ) +#define BLANK() \ + asm volatile ( "\n.ascii\"==><==\"" : : ) +#define OFFSET(_sym, _str, _mem) \ + DEFINE(_sym, offsetof(_str, _mem)); + +void asm_offsets(void) +{ + BLANK(); + DEFINE(CPU_USER_REGS_SIZE, sizeof(struct cpu_user_regs)); + OFFSET(CPU_USER_REGS_ZERO, struct cpu_user_regs, zero); + OFFSET(CPU_USER_REGS_RA, struct cpu_user_regs, ra); + OFFSET(CPU_USER_REGS_SP, struct cpu_user_regs, sp); + OFFSET(CPU_USER_REGS_GP, struct cpu_user_regs, gp); + OFFSET(CPU_USER_REGS_TP, struct cpu_user_regs, tp); + OFFSET(CPU_USER_REGS_T0, struct cpu_user_regs, t0); + OFFSET(CPU_USER_REGS_T1, struct cpu_user_regs, t1); + OFFSET(CPU_USER_REGS_T2, struct cpu_user_regs, t2); + OFFSET(CPU_USER_REGS_S0, struct cpu_user_regs, s0); + OFFSET(CPU_USER_REGS_S1, struct cpu_user_regs, s1); + OFFSET(CPU_USER_REGS_A0, struct cpu_user_regs, a0); + OFFSET(CPU_USER_REGS_A1, struct cpu_user_regs, a1); + OFFSET(CPU_USER_REGS_A2, struct cpu_user_regs, a2); + OFFSET(CPU_USER_REGS_A3, struct cpu_user_regs, a3); + OFFSET(CPU_USER_REGS_A4, struct cpu_user_regs, a4); + OFFSET(CPU_USER_REGS_A5, struct cpu_user_regs, a5); + OFFSET(CPU_USER_REGS_A6, struct cpu_user_regs, a6); + OFFSET(CPU_USER_REGS_A7, struct cpu_user_regs, a7); + OFFSET(CPU_USER_REGS_S2, struct cpu_user_regs, s2); + OFFSET(CPU_USER_REGS_S3, struct cpu_user_regs, s3); + OFFSET(CPU_USER_REGS_S4, struct cpu_user_regs, s4); + OFFSET(CPU_USER_REGS_S5, struct cpu_user_regs, s5); + OFFSET(CPU_USER_REGS_S6, struct cpu_user_regs, s6); + OFFSET(CPU_USER_REGS_S7, struct cpu_user_regs, s7); + OFFSET(CPU_USER_REGS_S8, struct cpu_user_regs, s8); + OFFSET(CPU_USER_REGS_S9, struct cpu_user_regs, s9); + OFFSET(CPU_USER_REGS_S10, struct cpu_user_regs, s10); + OFFSET(CPU_USER_REGS_S11, struct cpu_user_regs, s11); + OFFSET(CPU_USER_REGS_T3, struct cpu_user_regs, t3); + OFFSET(CPU_USER_REGS_T4, struct cpu_user_regs, t4); + OFFSET(CPU_USER_REGS_T5, struct cpu_user_regs, t5); + OFFSET(CPU_USER_REGS_T6, struct cpu_user_regs, t6); + OFFSET(CPU_USER_REGS_SEPC, struct cpu_user_regs, sepc); + OFFSET(CPU_USER_REGS_SSTATUS, struct cpu_user_regs, sstatus); + OFFSET(CPU_USER_REGS_PREGS, struct cpu_user_regs, pregs); +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491196.760281 (Exim 4.92) (envelope-from ) id 1pPPFZ-0006gz-8f; Tue, 07 Feb 2023 14:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491196.760281; Tue, 07 Feb 2023 14:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFY-0006fP-SZ; Tue, 07 Feb 2023 14:47:12 +0000 Received: by outflank-mailman (input) for mailman id 491196; Tue, 07 Feb 2023 14:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFX-00043Z-6A for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:11 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d0ce107-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:10 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id d14so13781368wrr.9 for ; Tue, 07 Feb 2023 06:47:10 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d0ce107-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uc1iqmG0eDG1vQ8U+sIbLSUPJBA6OCCUXdQBV344qb4=; b=olvo1aH5RBZGUjokZv9RAKbsOsTDD+/kjMI6EjTxAZF/9s6xmssMG5Yp1p19tqmDSq J1ZEL34cKCWDSvONG1t6ZUMPJUHjlRsqFNaidownvwbiK0IVyzswUmBBTYSeD1F+hYKY z+xzh2RWPonGo7U6ZCZvYflS4I1ELFfsOhIO9riFSWazIOEEVI3DeVonkBEWCQUk2zf7 EOiNvZxTOIlL58sD81K8pLzcrVEvvxbe6Ln8eG+UPtrpPqPyHhYUvP3QEeROM1TtDviA EQl6U/PrnpUn7ooJV7ng8oLPhhs7ocfPbPwZbxflFHPL/mBXBkTu8+0K5yopXUptwDy3 Jb4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uc1iqmG0eDG1vQ8U+sIbLSUPJBA6OCCUXdQBV344qb4=; b=cKisLwzTdZXoVClOoJO1snmDhnBAhfCYeW7QIbWtcGrGXMUjGmEz2AG/JY4WGRFHO+ GS1YUzJw1PjSkK5+a/MktiJ/c1hqvL+LyOXZzpGXdHPR7LW7knLrhTLPnaJh07kGyB3h vxIrrnT0eToWlc2MPv4azLnfcQILvW6HTWXZUHVeCtKOSfZ6IxYoTVF0/EOi8ZZPb55o 3wZwVbOZTzVfH30ov+kkk0R+4pIs7ujDATIgx3Gx0WdgCe5Vaj4phfNuA6cxK9bND8NS GzBgx1NWfNNLyngRPWlrQA6jHCqMoPl2LaMgDSxWOz7aiMQthZpEQwTSNOtv/4NUTuaP KiCg== X-Gm-Message-State: AO0yUKVziIZeZegXfLUYJ7/OOVQ1Voa7+4ccn7yhLAAP2KwCF0+8G0AL 7NgQHxsu5Eave7i4m67x1xbbdOR8bpc= X-Google-Smtp-Source: AK7set+Eb+udgm23p1UXUtnSVXWgYWQE4l6PsivZ10ubuA6EA4/o8N3XEZ7hphV9varJkmI3sswzRQ== X-Received: by 2002:adf:ec82:0:b0:2c3:e793:dc57 with SMTP id z2-20020adfec82000000b002c3e793dc57mr3284318wrn.10.1675781230114; Tue, 07 Feb 2023 06:47:10 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 11/14] xen/riscv: introduce trap_init() Date: Tue, 7 Feb 2023 16:46:46 +0200 Message-Id: <38c210192e8a4f32bb45765c4038cfc8f737aa78.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes in V2: - Rename setup_trap_handler() to trap_init(). - Add Reviewed-by to the commit message. --- xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 4 ++++ xen/arch/riscv/traps.c | 7 +++++++ 3 files changed, 12 insertions(+) diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h index f3fb6b25d1..f1879294ef 100644 --- a/xen/arch/riscv/include/asm/traps.h +++ b/xen/arch/riscv/include/asm/traps.h @@ -7,6 +7,7 @@ void do_trap(struct cpu_user_regs *cpu_regs); void handle_trap(void); +void trap_init(void); #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index d09ffe1454..c8513ca4f8 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,7 +1,9 @@ #include #include +#include #include +#include /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] @@ -11,6 +13,8 @@ void __init noreturn start_xen(void) { early_printk("Hello from C env\n"); + trap_init(); + for ( ;; ) asm volatile ("wfi"); diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index f2a1e1ffcf..31ed63e3c1 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -11,6 +11,13 @@ #include #include +void trap_init(void) +{ + unsigned long addr = (unsigned long)&handle_trap; + + csr_write(CSR_STVEC, addr); +} + static const char *decode_trap_cause(unsigned long cause) { static const char *const trap_causes[] = { -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491189.760216 (Exim 4.92) (envelope-from ) id 1pPPFQ-000574-Lx; Tue, 07 Feb 2023 14:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491189.760216; Tue, 07 Feb 2023 14:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFQ-00056n-IY; Tue, 07 Feb 2023 14:47:04 +0000 Received: by outflank-mailman (input) for mailman id 491189; Tue, 07 Feb 2023 14:47:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFP-00043Z-1c for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:03 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 482f607f-a6f6-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 15:47:02 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id g6so5812540wrv.1 for ; Tue, 07 Feb 2023 06:47:02 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 482f607f-a6f6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nZbJvpQHfICiARUPdSaE3T2PkEjqSCE47Uwko84j3uw=; b=GVtSuZg1axNOgd53uaa0Kr+pnNaG5LGEC0bMA4qUijmsPrE5UxNqPA8h5nELV7ZCdz AoThuRXw3lWb+3mAYdw+iQdVf41u8s1RTDkoeqDXU86rQyu/Cm/BJkh3rFHw9VrH9UVZ RdHcxfYUXwiYi1OZHOL9mydJnq4C5gm95b0QxJCBdtnDJRwH9oH48aoIa8O4m+XiYLJ3 RnLrjFjQPotwK0fkAqUs88XUkJHzMoF8pg9s2P/Z5p2ZjrlqKGHAYz7QFkHV9T6K0HTL CMGFRuwLeOIWQu4oqoCPuf0l5SacqftDs5gyo+jO/QjRFzzcu6AAAOImMre3LHzIwmKA /J4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZbJvpQHfICiARUPdSaE3T2PkEjqSCE47Uwko84j3uw=; b=fYU9poOyLmmu94FcFA5b+RTMaJtRmsGKfTXMPsyXXkoF61qiO3pyfSl3wDTGS38LDu USKcqp5TGqy/Q6AnDoRTDwkNoIIf9s+U+UqdGk62J4Ys+RseBaj6Z3MO7dMBdEFrNqgS zi70o1bnWgq7LGiMkz4npXGLNwb4mWwJl2mX1WkH3SS27lLsxZpXRat3dNgwO6VfCsJA sWZQONmU+AuyHqCW5H4IzPg9esOngfSvxH1SJrYXTjwYUQ9nDtYeIzNqTrYLCb+VKXf+ ao4Uz3qjjfww+m3gdoi2zdzf2dGc95elJK9CIebHnUXdyxoeCwSuUuOzyaLZ6+QZe+Dv bOEA== X-Gm-Message-State: AO0yUKVvSQSjknedmYOfhpzLCEWYU0ECOPfLAyesm8RXNw9S2NGRK9yd kCV3lbyL4Xa+RJxzL+ZOvUqWFp3wzXY= X-Google-Smtp-Source: AK7set/83iLuQppbz9zdeLU6RBjnX0wck/UfT2HChKiNCZZppvs+dYzLgd/1LctfNATlSL03MOswTg== X-Received: by 2002:a5d:6707:0:b0:2bf:da34:2b37 with SMTP id o7-20020a5d6707000000b002bfda342b37mr3091845wru.3.1675781221864; Tue, 07 Feb 2023 06:47:01 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v3 05/14] xen/riscv: introduce empty Date: Tue, 7 Feb 2023 16:46:40 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To include is required Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V3: - Add Acked-by: Alistair Francis --- Changes in V2: - is a new empty header which is required to include --- xen/arch/riscv/include/asm/string.h | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 xen/arch/riscv/include/asm/string.h diff --git a/xen/arch/riscv/include/asm/string.h b/xen/arch/riscv/include/asm/string.h new file mode 100644 index 0000000000..a26ba8f5c6 --- /dev/null +++ b/xen/arch/riscv/include/asm/string.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef _ASM_RISCV_STRING_H +#define _ASM_RISCV_STRING_H + +#endif /* _ASM_RISCV_STRING_H */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:47:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491199.760323 (Exim 4.92) (envelope-from ) id 1pPPFf-00085k-6W; Tue, 07 Feb 2023 14:47:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491199.760323; Tue, 07 Feb 2023 14:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFe-00083t-4g; Tue, 07 Feb 2023 14:47:18 +0000 Received: by outflank-mailman (input) for mailman id 491199; Tue, 07 Feb 2023 14:47:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPFb-0004Hz-Qs for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:47:15 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f636d1c-a6f6-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:47:14 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id m14so13760224wrg.13 for ; Tue, 07 Feb 2023 06:47:14 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b002c3e94cb757sm5269743wrw.117.2023.02.07.06.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:47:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f636d1c-a6f6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0X89Og2seSZDPBXzfRkfuOgunrgwSAjGT9JkLDw56FE=; b=MKkUIjqfar/5miiez4RxBwX2Sis0GVA/H92rR+af5yPU7SwTiSTe3g7KUck0pok9j5 kYXxk8s+E7PHUPPYLdEjGWEFRgGSen2B3KZ1hWOW6vyUfnLHKzh35OP9Z3+KtoNYWgZ0 5WpYe/z4puRVkObG63IRQZUhgiFGIjjoAxwKo29gG9gBi/vn2i7Y0QUdtrRYLZk3BpUy oebHOxZ/1EWDSJz1q7dDWOtnHNrGqgNUWhriXJsjEcoqqSYm7b0KPLMP/12C644ICXqr MyycV0fzvwdaFaf+NzXtt0QYADR2XilazaVqgPmAzD//lx0xVb3kjuhv5Z3+MIjq8q05 dWgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0X89Og2seSZDPBXzfRkfuOgunrgwSAjGT9JkLDw56FE=; b=Xx6Ng+0h7bSEcp0x1cAUlN6f6LJx7bce4sXAX4O+HXSdqlrh1qwZfN6y+VDv7FiG9R xHOBh1H0a8G/aJEmHNodBQu5oAyFL/jgF+PeUAgQTTeujdqpiAEHaUu2zC8b0OdWRP7L HAIYlwuo+yQYu7tiP+taSuSyrzSE0UBq8/kKxiXIAtNcwyeZtvROzOU2uUHkj67M/sAn 9FzC8oNh1cqerbtVFRiJrS2S6GGTqpBAVrF50ga2izZM7hWiuOIcDMLQ7AqiQCJuCenI hy3F6sRin9qr4qNxTcZNxdLbrjOEhmazuFd9gALvizG88EXn7h5eepW8KDxUyGxQXLCM qwCw== X-Gm-Message-State: AO0yUKX10g0xWVnda8s/gOJylUY09BIO2lI4C6oqqViYE820LOynmaew c8sPQL2aUtVHJc2eV6Wbrdob9D/4UNo= X-Google-Smtp-Source: AK7set/2dBDoiNyI90TorRCwsIqunxRJzQ9AUXnux2yDQnZ0kkLTQxpeVrzNe5fa52Gznyki+n93aQ== X-Received: by 2002:adf:ef8d:0:b0:2c3:d296:7a84 with SMTP id d13-20020adfef8d000000b002c3d2967a84mr3254637wro.17.1675781233790; Tue, 07 Feb 2023 06:47:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH v3 14/14] automation: modify RISC-V smoke test Date: Tue, 7 Feb 2023 16:46:49 +0200 Message-Id: <95527748699e6ab643dc2fdee634fe934ae12f60.1675779308.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch modifies the grep pattern to reflect the usage of WARN. Signed-off-by: Oleksii Kurochko --- Changes in V3: - Update commit message --- Changes in V2: - Leave only the latest "grep ..." --- automation/scripts/qemu-smoke-riscv64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh index e0f06360bc..02fc66be03 100755 --- a/automation/scripts/qemu-smoke-riscv64.sh +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -16,5 +16,5 @@ qemu-system-riscv64 \ |& tee smoke.serial set -e -(grep -q "Hello from C env" smoke.serial) || exit 1 +(grep -q "WARN is most likely working" smoke.serial) || exit 1 exit 0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:48:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:48:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491221.760337 (Exim 4.92) (envelope-from ) id 1pPPGO-0003U4-NR; Tue, 07 Feb 2023 14:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491221.760337; Tue, 07 Feb 2023 14:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPGO-0003Tv-JH; Tue, 07 Feb 2023 14:48:04 +0000 Received: by outflank-mailman (input) for mailman id 491221; Tue, 07 Feb 2023 14:48:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPGN-0003Qw-5c; Tue, 07 Feb 2023 14:48:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPGN-0003yb-2X; Tue, 07 Feb 2023 14:48:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPGM-0004aA-Kc; Tue, 07 Feb 2023 14:48:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPPGM-0007kB-KC; Tue, 07 Feb 2023 14:48:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MVe3EqfZ/WIPkyJGZbPOEIrlJo+PzkS7IEGfqxFis0c=; b=qdm58y0bHCysgxMx6zaqMZwEIh ZhaS1oCrYzkPom+Gwm9WHLX+8AfOSM/++/a7OJ+aieiICVazdxayCY+RkyO/4AkLywHfcbBM7GXbD lrrb+rG4xTlBglMAbqiXPbYbp2uDfT0saDmOgwe5YDV9rHcab8ticFQojj6TU4gWldMo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176434: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a X-Osstest-Versions-That: linux=d2d11f342b179f1894a901f143ec7c008caba43e From: osstest service owner Date: Tue, 07 Feb 2023 14:48:02 +0000 flight 176434 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176434/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176411 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176411 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176411 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176411 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 176411 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176411 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a baseline version: linux d2d11f342b179f1894a901f143ec7c008caba43e Last test of basis 176411 2023-02-06 05:30:02 Z 1 days Testing same since 176434 2023-02-07 00:16:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Potapenko David Sterba Josef Bacik Linus Torvalds Qu Wenruo Tanmay Bhushan <007047221b@gmail.com> Tejun Heo Waiman Long Will Deacon jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git d2d11f342b17..05ecb680708a 05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Feb 07 14:55:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 14:55:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491294.760348 (Exim 4.92) (envelope-from ) id 1pPPNc-0005ri-HU; Tue, 07 Feb 2023 14:55:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491294.760348; Tue, 07 Feb 2023 14:55:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPNc-0005rb-DX; Tue, 07 Feb 2023 14:55:32 +0000 Received: by outflank-mailman (input) for mailman id 491294; Tue, 07 Feb 2023 14:55:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPNb-0005rV-1L for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 14:55:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062d.outbound.protection.outlook.com [2a01:111:f400:fe1a::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7608232c-a6f7-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 15:55:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7455.eurprd04.prod.outlook.com (2603:10a6:800:1a1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 14:55:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 14:55:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7608232c-a6f7-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5PyTZJ5u6sWzQm7LQzz4RLt3JWzEh9n1sj8ftYVNeyjt/Wahuyth6ifVqzIMUGzHlEcdb8lWhnCA0N41m1GiNO7RgCjuIQE3GdoAAR1Hp6TV7pIaVs7NxkVSgp8i+jsvSNRuf+MACbIq4OnMf+EE7c/8MycyPav3D6u8HQQ5hy7wsi+g3QSJICi/bFHneZ9czH4/E4kRgiSrsBvZjUW+ImTkxBMHy7XTyS+cYMNj//WuXHn4k8/JI9miQzKmPdBYITCmgpQwMH9BOZJvOZ0g9a0HoAywL64VPJEI3JEtijMHrKCQ4svu6XYZRaaVe2TuzihDXoI8QJebrZEAJ2bCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aLwNBKHAemjJEccoETxEMrCE1WQwSTUOFcIQGZqFZVw=; b=L0o+56rt8sLR4DzmELXaw8DvVNanzwa5K3CIpdO/6Zn9RBvo76XLGp94/+cU/i4tSJtcTkoOmppAKVVcBF3VBpvLHyoZjT9f3K22KMXhCeVCJsV/s6O4LlTgC7eWICz1ED1dsSGntX6utWnUe6AtOu4mxYYEIWqg9FvERo1zLgAz0lKsqG2/2BQ301lkhaUadnaBnwp2PxVIrVaE1PRhTWi/EC1XIJDsp+i4QLwIratPVUagGbNKsH76srKVZwIIcH7hyMQMGf3H0IafyFTTtE1NC+ntPU3QHxOHZh+bilWxr1tK2cIhTlmlfBo1LdiR3La4TDqleDjMR0cyEtoiuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aLwNBKHAemjJEccoETxEMrCE1WQwSTUOFcIQGZqFZVw=; b=BGATALQCWAdNWoTAHKBGDwEYfjOa6ohw5PTh8zxuTphNDmfygC8Zd8Cpyrocg109ZuyTUzwOSCXkE1ezCgxZ6UIhBQ7sPPJTHI7Rt9lA6D7RdH8pl0CNfCUHfLDbwuMUHxFCK2epWgaRuV05br0rX2GTNZBVcJM98z0tdzctfpQRXh8Joe6qJLFp4nkws1rLSWDwCdGi9sUBaEKGv+sfQg6a5lKdXtK0/Bc0+0kVPWR4zGhXFWLlyhF1r8Wc5BAiWTemezr5/aV7eOcDkkPSEAoGVM0Cjq1evHtTrkHJ8l4o/cJ7VBNDBu8iEmxir89deZzgowoPXcHN+I0OOYjLFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7aff9222-213a-121a-6c62-d838d9406d36@suse.com> Date: Tue, 7 Feb 2023 15:55:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 04/14] xen/riscv: add header Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <94a46f35bc9387c699d9d24b1c792b54ec290255.1675779308.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <94a46f35bc9387c699d9d24b1c792b54ec290255.1675779308.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7455:EE_ X-MS-Office365-Filtering-Correlation-Id: 980b3bb4-bda4-4d99-f8d6-08db091b5988 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CLUo312bwxQx3bVjyLiYkjmagZivKrj6KPrNnjSpuPDKK+OlH/AlQtIUjrMjLhslz49XhuG1NTli8lziguyoWOOfEfmkYmYVWS4rP2X0aOZ7SiRX8rJl0J+zllh+ppnYnslJJ4CF4zwJkDimnr4dFfjlXLe4G7/5msXejqcfJ/1IBXrJNJhGgH5kTjORiwzvDHRAOBqK81YaDrwMBsEvsDh18+NysBNZzlXBQTtT57comDmoOtPcbyT/EjY3xScJBhGYk4iw8cnGZkePLTPglnVGEllM0dQeC3eSvmRHLRMGAGmuHLVMMKESfoI24NNhdvdA/75WCem7Ri94AC9NrJjjFAjCxt1WxvVp3Pmgbt+ptCWLbQXHw8H3aiLfzGitPDgmq+Ji4hU70g44xqrNIocwYtSmti++DE6zn/+/tguL9rjWXGOtkEsAyJmJ9yngZSSSbwWiA3TkzWX1wNHOPof/g4TDbm7FIKRp70bcZspEfMZQext1nl8n4GuiZzQ/S/XVQwRqW5TsYr763jTbzjXDyqziJ2zJeYigZSFJj6rBRXxe9Zob95+8DB1ahD+pFgLK9Dt0jzOXpHPDVK0IZTVDTxr8IOm8oyNzPkkTHbbPP3aCrJzX1nqhF5LH/hLkEIKpo9NIuYTqTjuofbSbtvTaGxQlZZRvVRgMV8urasNa4SBS7+gc0/BNAAp95M24AkIs+lrWzls0fLxWjMtikJzDiEC9NFHffFi8n/JxQgA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(376002)(396003)(346002)(39850400004)(451199018)(2616005)(6486002)(478600001)(31696002)(86362001)(38100700002)(186003)(53546011)(26005)(6512007)(6506007)(36756003)(4326008)(316002)(54906003)(8936002)(66946007)(66556008)(6916009)(66476007)(5660300002)(8676002)(41300700001)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmc4d0k1cFdGejI0RHhKaks2bEQvN0x3RmNGUG4xNUtJMXZ0SUtpcnFHTEQw?= =?utf-8?B?RXk3ZWdKNzBlYnFma1h0aXVUQWY3NlNnbVM5ZjA5L1pqN3NXeWtOS0VqaG1H?= =?utf-8?B?WEpHTWFZYVd4Vm5tU0VKZ1QxTklvQ01reDc3RXFDZGwzL2dneVFnMkIwV1hh?= =?utf-8?B?S21Cbmd3aDV6K0x2RWc2U0E0WElGd3I5ZXhib2FxQ0ZmTmJ0bVZDc2ZSNTNB?= =?utf-8?B?UWNkT3Z6djFNdGUzWkNmSlZuSmx1SEVWQWVHcTZJeXVZdytYaXIyTTFPd0J4?= =?utf-8?B?cDZWMkF3M1RRUDRZSFpwZ3V6dWQrNUMwSFB3R21EL2FkY3YvTzYwaWhYZFNR?= =?utf-8?B?RjZ2MTN5c0M1T2kzSTE1cnJITm1kUlFvWkxCd3duL2lSUHBlZitJalFjWTRk?= =?utf-8?B?WWlJZVllV1BKY2k1dzlOVHBXWUQvbkFhOGlWWmpXTzJmQTd0S3VpN1B4VURu?= =?utf-8?B?MzZTWEVWVTBMY1BlTmszN0g0K0Vpck1kWkNjTG9laHlrUng1MlZQYmRqNm9Y?= =?utf-8?B?NHQ1YUFoajJ3bnQ1QlBXdjhHNFpUQ0gxbnVRR2hTTkpwN0xqUk9zRmJaKzZy?= =?utf-8?B?d09rdGRDbHNXUDZ1emNsTVpPV05zZitpSTZyc3hzNzFQSTRFV0RraVltMnNp?= =?utf-8?B?WCtES1k4VVJEMTFiYkdoRXBTRG85dXU4L2J3V0I1SHZGZXRodjF5WmZjaUpF?= =?utf-8?B?SkZRSHVielBjMnloK2xQeXlETzhDMnNGSzZWb1l2Z1lkQW8xVXoxS3NudWlS?= =?utf-8?B?NmhxOCt3MHZRVEhGKzhkMXhEc0dUQUZtd1A5TXcrTituL3Z0azdHcUsyVXhw?= =?utf-8?B?eEhPUVl2NGNhSjZzSlJ6a1JZbEkwSHZWVEhyaEg0UTZQL1J3TE1La1IyOEpa?= =?utf-8?B?RFp0VXViNVBWY2hBbk0xa0tScDVYYmcxSDMvSEtudVFvRUpJQ0JLQk82ditI?= =?utf-8?B?LzduUllFM2ZWeU5aWldQOVIrOXdQOGpsSG0yOGFOaFJrNkZvUzRkWUpNQ1ht?= =?utf-8?B?REZCbVpoZUtMc05VdC93ZFNCbkpsNWJ3NzNlM1VHaldNQjNIMFA5MVNIMEhW?= =?utf-8?B?KzVNNTFYOGw3bk54ZHc4MXB1d0lrUFdWaGFPYlkrYUs2T0Y5QnRyNUJ3ejhK?= =?utf-8?B?aHcza2xXMXpjd3AzRHJTL3dXWDI0cWxWc1RqT0trSnNlejlwNXExM2dwaUdU?= =?utf-8?B?dUhvRDNlTDkrZWNCaFB2R1FQd0F2RWFvMXNuYTBSditCajBJUUZmUTNXekJi?= =?utf-8?B?U0RVZ3hFVUJPcFF2c0wxQVl2OFM3K1lXWFZhVk1nYUNkZUZsVTZaek50TzVl?= =?utf-8?B?TmpPNDNWSm9VSXFRc0dLeFZ4dFFMSGN3UHJKblVEV0FHZGtaZGFUcDhqVkFB?= =?utf-8?B?U0ZRMmEzM01QcEd4eGkyRCtoZ0l5VEtoYWR2dmhKZkpzREs4eUV4aEhMRDVx?= =?utf-8?B?UllpbFRHZHpHWGxCbENiUVZ4bDhLR3B5Z0EwMWN3T3FIbVYxUTQrTURYcW4x?= =?utf-8?B?UEFDVjRKelZlcXJjQzhubExSM0NybzZNbnVLaXc1allqQjBxKzlSRzVkaDIz?= =?utf-8?B?cEtiSEsvdHB1c2lJVGpTa2J4SjNKbERlcVZENURuOVl1K2hObDVLMnVpM3VH?= =?utf-8?B?a1lCMEFQR2JVZ0ZKQVFjQk9FMnRocWp5LzdydEFjb1h6SU9jSGFiWUx2R3pM?= =?utf-8?B?eXc1RWFKVFFHV2JtRndXcGh6cHBod0ZadThVUXBNN2o2VkRINnNoUElXWnJE?= =?utf-8?B?UHVMSE9hMEw0aktrZVR5RldNVlVDMS9MbmwxMU9hS0NMcmJyUno5SFRsOVBV?= =?utf-8?B?TlcwVTIwQjZvV1hJZE9NWGs5T2lCWnRpdnNORy95RFJrc01BTW55bGFFL3Zq?= =?utf-8?B?MFU0eVZ0LzdKUC8rL3lFRHZibmcydG51eitRdVRWR2NpVFFXNk84eC9aY2Jo?= =?utf-8?B?bmNhNTF4SHJQZHhubEErYmd5WjZqYnV3TWVVV2RFbmlzNzBzcWlWaHBET3dK?= =?utf-8?B?c1ZCYml5Uk9GY29abVZHNzlkT0tqUmVMMXd6Q0Q1aUdaZXc2ejcwS2R1ZkMr?= =?utf-8?B?MkNKU2VLSlBaQlFIbVU2eEZrd3A4NzlpbFFZMTRVVkltb2NVcmpkTm8yQzBG?= =?utf-8?Q?yV5JRpYOf79usz1xMK/7TEDtR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980b3bb4-bda4-4d99-f8d6-08db091b5988 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 14:55:27.5847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aljBmd8lCkKR++vZAhrO5LkTPrUMiVLbjJDoDwocviAI/CDgtDqwJ8XnWT1eKtMFIXv9Pw5h2xCzjbrAOeCutQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7455 On 07.02.2023 15:46, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/csr.h > @@ -0,0 +1,84 @@ > +/* > + * SPDX-License-Identifier: GPL-2.0-only > + * > + * Copyright (C) 2015 Regents of the University of California > + */ > + > +#ifndef _ASM_RISCV_CSR_H > +#define _ASM_RISCV_CSR_H > + > +#include > +#include > +#include > + > +#ifndef __ASSEMBLY__ > + > +#define csr_read(csr) \ > +({ \ > + register unsigned long __v; \ > + __asm__ __volatile__ ( "csrr %0, " __ASM_STR(csr) \ Nit: There's now one too many space (here and elsewhere below) between the opening parenthesis and the opening double quote. > +#define csr_clear(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrc " __ASM_STR(csr) ", %0" \ > + : /*no outputs */ \ Nit: Missing blank inside comment. I think these adjustments could be done while committing, assuming no other changes are necessary and an ack appears. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 07 15:08:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 15:08:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491303.760362 (Exim 4.92) (envelope-from ) id 1pPPZT-0007W4-SQ; Tue, 07 Feb 2023 15:07:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491303.760362; Tue, 07 Feb 2023 15:07:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPZT-0007Vx-Oo; Tue, 07 Feb 2023 15:07:47 +0000 Received: by outflank-mailman (input) for mailman id 491303; Tue, 07 Feb 2023 15:07:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPZS-0007Vp-Cr for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 15:07:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7d00::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ca5a753-a6f9-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 16:07:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8314.eurprd04.prod.outlook.com (2603:10a6:10:249::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 15:07:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 15:07:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ca5a753-a6f9-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3VcYEcRSeKEjdJ/Y7RvZM95G4hpQXCQHZw24t3km4zVGV1IPYN11Zq//z4Xvd7y5bOkGSlu1+I6cO9B0JXwmdPmubCO96pYiuze7ZduMKyVC5WOgb6PiyyxKFZXexferTO9FtDgl5Yhe2kInqy67pi/3rIN21vvNyM+6dB2rj54hPLSLAPtDjEfF6kigoBx5bcsG8+hOVDF8w6qVGMBKZ5sWhsKRUQhgwlMi7vP3NzndwUf4z68O/1/urJdnKX4hmQeBlZMJATlcMIa96lPJbUdQNk3slI9qMRBllFxmCWs0eOkB7mixiIK22e6Q9KLpPOROyv4c8IsaaSFU6eodg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lRjNyhJB24lX2oEDBofRKsPL/nQHU2HOAqMzsG9bTZs=; b=JCPbxi86sWq008e27T8HV9N0CWog9dN0MHkv0Bq6GA4+lgw+tMNpE8Wt3u4AJ+CjbjvYtdZUmg25bMBWoO+eVx93xbdI9V4o03WCwH4C+O2E9q8razct7erDGHp1ta3mxKm4Qeqm3J/11Lg3jZ105ZteVs4GEtYA87+CeBz5Ipdhn7OFCe8p7aKFmPtNcrsGyrOsL8k50C2Ez7E800E0iEYofY82MhysQ4mmbpI4YpMPCkKhO9ML2RT0WUNv6d5PbUMP9MAsZogB1XuRxzQGjue5N46xRmTOp3HmbRYwZt8FD1ocFUXjKt7iWjF4j5cs7+wHXp0dRdYaxJyLfyDTqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lRjNyhJB24lX2oEDBofRKsPL/nQHU2HOAqMzsG9bTZs=; b=Jvb+1/min/rRrNt+RKNRIuj9OjxcJ8bHVbD0ezKzCcTsAhGcUjG2CYMaMHRyWtSRDAFGMDYr8zfe8Zl69vrLbuUSewf9QLQDzSVeSdjJEp3XxVVevjj+cZc0O5gRg1pBlMLV88pVtaZcxzPakLaA69gpf/Z9UM257JlP5U+OWGbn/05A6t6mGS09EpNsDR2uQnbRXTjXNwnghyxBXy/bYW4hk3LD199VkHKnLBPaOiZDKBq48AIpbRMY4IEkAZEm2iCpZHT97Y3dJ+pANAqzts/Xjv8T8Fy3cZWWRebfwuKSPf0kA9qtt7E73rMvvu7SF6/t0RYE11im1t1Yi805zA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 7 Feb 2023 16:07:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8314:EE_ X-MS-Office365-Filtering-Correlation-Id: 153492c4-f394-48c4-9ed5-08db091d0f52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hFBGseIWP5yPy9x+4m2tiDVPPsHwiMHN0RRl+8poBZO6Drv3odMTBBDtQC6ZmuAqmeSdCjMme/iK2nuMbeVkcpCs8h9cuAuOgTcsiKeJ/+Vqb8Utff4fu09cRn7Z7n/mzL+O81O0fJALBMD5cFo9b8Vl6SyOO9JFF14n9mvS7HiL+Nw50gStSsmGK4fGkzvAwye5+2a8d06npBSVBt4OzBf5ehlaQA+r3f/B2fCY8iEHwJxzlzL1GQb4j04w0GEB5EbHxy4ICFRXpZzldN5S1e+5ij/iaImFm7PIEfkdA/DS19dwH8VWgZcbO9jnddwOOEx2VkgoDtz9q+sHhCxYA2K2Wydrnc5N35LPux9gEn2gsm2nvur8zbm14nKTxP881F+AQALgKZfCIjeAMtkGXfrBG3hCztFxFotKzJ8Y5hd6YyG92UjlPXPhHDeykh4hB8Pcxmkd2+9yAKwG4W5OYwzbkC3rbTi02DYiPhCFQCRBQqzfsTr0R548OGXBs+TiI517ir//SD+owIwtyYO3Ir2l4zY27BiiaaTgwcodWEUVsMpUHrTtUQWFyDUja2d5slRHA6N60rfo/ygWH++u0/EndUJXX3UQ2ErmEBssfrrcGFgVA+bUmfbCjyAs445RrXn1QMKyNmmqycj2YobpHCnoyvZk4OOE+fXxGtMA267A6Dx2T/TDbbV0J2iMsmI/B9+ygrmEILAhTiAMx8HgDCSouBhhHUto3bNDGu/Rksc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199018)(6506007)(6512007)(186003)(26005)(6666004)(53546011)(36756003)(38100700002)(8676002)(54906003)(316002)(5660300002)(41300700001)(2616005)(8936002)(2906002)(83380400001)(66476007)(66946007)(31696002)(4326008)(6486002)(86362001)(478600001)(6916009)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU1qaFBKN1hXRUtoZ3V6ZzY1NXVFcjdGdHRwTU9UaXNPTXl0WVp2dDNuQ3dO?= =?utf-8?B?ZmtyRkxldHFKdnZVZWp4NGR3RDVOSUNhYjJmd2gxM0pQNlo3YUpxdDl5eity?= =?utf-8?B?VEo4dW1JdUIvUjIwVDJzMUdRUDNnZEQwdWQrMGw0L0RTMXQ1cUduQUhRWDI5?= =?utf-8?B?c25xVzcrUEpvUWpmUVgzUElsMTM1WWV0WXd5aThRVGNnaTRWMGQrVE9TNHVt?= =?utf-8?B?YWtyL1lRZGlyQ2pGTXhzRXFFQkNySjVrRkVLbjRaTTRiWk0yZ0hsK3FMSnFX?= =?utf-8?B?WXRPSE9yTjA5TE9veStqTGNOYnhJYjhwQWlTbGp6ZWR1NXdlVjJQLzVPWENu?= =?utf-8?B?ZVQvWWIvRVdPa1UyTnVyUGZKbHZyQzVWcDdPNmVXWGp4czFxcEY4bkZDc3hX?= =?utf-8?B?elM4SlBtYmpGdFgrdml6MVoxeFRJOTlpMDJWYmlvcXpzUVVabURFek5IVWFE?= =?utf-8?B?N0RyNUkrWjUrU2dYNy8wallsRnRFdmRSbUo2SHIzTXRiRUFpNWVqcDR5Umwx?= =?utf-8?B?aDFIYms2WnY1ekppdmNsUTRDa2pyaWYvanVHRWxESUNjK0dITlJKejlxbzE3?= =?utf-8?B?b2JBZ0t6WGxFS09tbVYvWnNCYVAzTUhHRFQwb1dRRTBQcVd4WDNhWS9XLzd0?= =?utf-8?B?c0dpc2hvN0lPUitFak55UlZQdWtCd1B4MzgzVW5KQlBzZWd4ODFaaDlJaE1Z?= =?utf-8?B?THZOUnQ5UnZ3TkZSR3dqM2hkKzVvUmJDd1U1eW0yTWNXOE9TaU9zeVAvanlN?= =?utf-8?B?c0xpK21HanZLeW1NWC9NMnhGdFJHUkk4RzZBb01zZjZ0TnR3c2NUeVdYS3FO?= =?utf-8?B?R3lXME4rN2F5U24vaXlSRCtMNEFLKytTQU9XZS9rbVN1NGdEaHlzK1F0Lyti?= =?utf-8?B?QXg1TVdRK2R4OVE2elFzbHh4MWV2U0VsblZHVEZCZkphRk5aOTMyN0phaGtC?= =?utf-8?B?ZmxJWWppZC8xQ0R0aU5yTWlxeUxnd09PT3NjcWVDRElCdm5YUVBCYjBDL094?= =?utf-8?B?WWl5SXhINWt6aXkyYkIzVFJiVVdSbWdHakhWQ3Q5dUorRlVRVW9WUGVSNzhI?= =?utf-8?B?dWlOLy9SL3MvUGJJK1RmR2xGeVc0Y3o2cUlzNWJ5TkQ1dGdKZG5sVnE5dWcx?= =?utf-8?B?WlE3SzM0M0Qrc0puR1haU1RsMmZwcnI4ODlIL3pYQXQxcFczOWkrL3M4cWs5?= =?utf-8?B?ajllVzdHWk5YRFhqcStvVFZFTlpRMUpQYUJ3eGFrc0tCVkJUdXlDaDR2RHNi?= =?utf-8?B?dzR6bU5ybWZqVUFnZWJJZU9lbjNhWGlIQ2NuekdIajlQMTVpZkJDWTVQbHBM?= =?utf-8?B?Qlc1V3NLUmtaeHU3bEJVVkRWV0YzQnlST0NkbjA4dmRZKzVaUmlCU1NTSDdU?= =?utf-8?B?eHozczFma0wraWdOU0ZnbE5SalYxa3ZUQittQ0ZZeVg4MWVjYVZOZ2lvaDhl?= =?utf-8?B?S0FMZU9ocG5RMlNVSG9zTFNlZnVzZ1NxemxWaFd2VzhCVEwxeVREMVc0ZGJv?= =?utf-8?B?b0lVSml3QjJ3TURtK2wyK2hteWIrY3ViQVp5N2xPQWQ2NlAzdEFwNkpmdEZu?= =?utf-8?B?Szc4VmkwZWlFanhjOS9wSnpvdXBtS3ZpTUh5WXhBaVQ1S3dNb0wwMlVPVjUv?= =?utf-8?B?UFZqRi9zVC9PbUJTWjgyelpXNHhZSm5mdit4S2Z3U3BlTDZlbU94MWx0T0ow?= =?utf-8?B?OHZOdGZJNTFuaVpzbmxIa3pwVXVLNXQ5YVlycDhFd2Q1WThIS2RDYlh3eTdK?= =?utf-8?B?OENTSlEzU3ViQXE2VXhUSmw3aUFrY1crU2RWcFlMdEpxTGF2Y0xWbXhBcmo1?= =?utf-8?B?cDZ5OVJhTmFEVWJVa1B0bnhMNlRjMU9kUVY2WWFVakpQeG1NajRDME5HcmJz?= =?utf-8?B?dkhoRFR4b2NJOHB2ejZtWG9vVndHSlB4aGpBWVJMaEF3WExWbWlHalVxZTlD?= =?utf-8?B?WmtOVEZHZ1dIb1RxQzJkV0VJRDg0Ukk4VVozZ1hGYlRvMmM5b2tzdnNwOGFk?= =?utf-8?B?aE5LMUxhVnRWSTY1RUtkbHNiUnJpc2JQSHRWb0tYaEp3OTV0QldBdGJ5Wkhy?= =?utf-8?B?alpDMFM3djBZNHRTc1RGMEtyZCtHeUo0eHlSMGpzR3VHNzVVWmJSOXRJS3N6?= =?utf-8?Q?c5B5rExbRpmQvbJX21pE8WC48?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 153492c4-f394-48c4-9ed5-08db091d0f52 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 15:07:42.0393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rAm7gxsqfOeA2E6Yh7d+aot+pCxABU3QZquLIOxcjnO90Jn5zWfKmWsmfEgsu5p3CwVH2q9bV3V+AHG9hSqrVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8314 On 07.02.2023 15:46, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bug.h > @@ -0,0 +1,38 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2012 Regents of the University of California > + * Copyright (C) 2021-2023 Vates > + * > + */ > +#ifndef _ASM_RISCV_BUG_H > +#define _ASM_RISCV_BUG_H > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#define BUG_FN_REG t0 > + > +#define BUG_INSTR "ebreak" > + > +#define INSN_LENGTH_MASK _UL(0x3) > +#define INSN_LENGTH_32 _UL(0x3) I assume these are deliberately over-simplified (not accounting for wider than 32-bit insns in any way)? > +#define BUG_INSN_32 _UL(0x00100073) /* ebreak */ > +#define BUG_INSN_16 _UL(0x9002) /* c.ebreak */ > +#define COMPRESSED_INSN_MASK _UL(0xffff) > + > +#define GET_INSN_LENGTH(insn) \ > +({ \ > + unsigned long len; \ > + len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ? \ > + 4UL : 2UL; \ > + len; \ Any reason for the use of "unsigned long" (not "unsigned int") here? > +}) > + > +/* These are defined by the architecture */ > +int is_valid_bugaddr(uint32_t addr); A function by this name very likely wants to return bool. Also - uint32_t (not "unsigned long") for an address? > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,6 +1,6 @@ > +#include > #include > #include > - > #include > #include > #include I think it is good practice to have a blank line between xen/ and asm/ includes. > --- a/xen/arch/riscv/traps.c > +++ b/xen/arch/riscv/traps.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include Perhaps wants adjusting earlier in the series: Preferably all xen/ ahead of all asm/. > @@ -97,7 +98,136 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) > die(); > } > > +void show_execution_state(const struct cpu_user_regs *regs) > +{ > + early_printk("implement show_execution_state(regs)\n"); > +} > + > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > +{ > + struct bug_frame *start, *end; > + struct bug_frame *bug = NULL; const? > + unsigned int id = 0; > + const char *filename, *predicate; > + int lineno; > + > + unsigned long bug_frames[] = { > + (unsigned long)&__start_bug_frames[0], > + (unsigned long)&__stop_bug_frames_0[0], > + (unsigned long)&__stop_bug_frames_1[0], > + (unsigned long)&__stop_bug_frames_2[0], > + (unsigned long)&__stop_bug_frames_3[0], > + }; > + > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + start = (struct bug_frame *)bug_frames[id]; > + end = (struct bug_frame *)bug_frames[id + 1]; Nit: Stray double blanks. But I'd like to suggest that you get away without casts here in the first place. Such casts are always a certain risk going forward. > + while ( start != end ) > + { > + if ( (vaddr_t)bug_loc(start) == pc ) > + { > + bug = start; > + goto found; > + } > + > + start++; > + } > + } > + > + found: > + if ( bug == NULL ) > + return -ENOENT; > + > + if ( id == BUGFRAME_run_fn ) > + { > + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; > + > + fn(regs); > + > + goto end; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_file(bug); > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + /* > + * TODO: change early_printk's function to early_printk with format > + * when s(n)printf() will be added. > + */ > + early_printk("Xen WARN at "); > + early_printk(filename); > + early_printk(":"); > + // early_printk_hnum(lineno); What's this? At the very least the comment is malformed. > + show_execution_state(regs); > + > + goto end; > + > + case BUGFRAME_bug: > + /* > + * TODO: change early_printk's function to early_printk with format > + * when s(n)printf() will be added. > + */ > + early_printk("Xen BUG at "); > + early_printk(filename); > + early_printk(":"); > + // early_printk_hnum(lineno); > + > + show_execution_state(regs); > + early_printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + > + case BUGFRAME_assert: > + /* ASSERT: decode the predicate string pointer. */ > + predicate = bug_msg(bug); > + > + /* > + * TODO: change early_printk's function to early_printk with format > + * when s(n)printf() will be added. > + */ > + early_printk("Assertion \'"); > + early_printk(predicate); > + early_printk("\' failed at "); > + early_printk(filename); > + early_printk(":"); > + // early_printk_hnum(lineno); > + > + show_execution_state(regs); > + early_printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + } > + > + return -EINVAL; > + > + end: > + return 0; > +} > + > +int is_valid_bugaddr(uint32_t insn) > +{ > + if ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) Nit: Style. > + return (insn == BUG_INSN_32); > + else > + return ((insn & COMPRESSED_INSN_MASK) == BUG_INSN_16); > +} > + > void do_trap(struct cpu_user_regs *cpu_regs) > { > + register_t pc = cpu_regs->sepc; > + uint32_t instr = *(uint32_t *)pc; You still read a 32-bit value when only 16 bits may be accessible. > + if (is_valid_bugaddr(instr)) { > + if (!do_bug_frame(cpu_regs, cpu_regs->sepc)) { I'm pretty sure I did point out the style issues here. > + cpu_regs->sepc += GET_INSN_LENGTH(*(uint32_t *)pc); Why would you re-read the insn here, when you have it in a local variable already? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 07 15:35:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 15:35:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491309.760376 (Exim 4.92) (envelope-from ) id 1pPQ01-0002qR-WB; Tue, 07 Feb 2023 15:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491309.760376; Tue, 07 Feb 2023 15:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQ01-0002qK-S6; Tue, 07 Feb 2023 15:35:13 +0000 Received: by outflank-mailman (input) for mailman id 491309; Tue, 07 Feb 2023 15:35:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPPzz-0002jd-U0 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 15:35:12 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20625.outbound.protection.outlook.com [2a01:111:f400:fe59::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff86cec0-a6fc-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 16:35:08 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BL3PR12MB6644.namprd12.prod.outlook.com (2603:10b6:208:3b1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 15:35:03 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6064.032; Tue, 7 Feb 2023 15:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff86cec0-a6fc-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RxRKCk+SoFxfQ4kO3zXvTjt5yhG0+CL4CJhbsC4RnEa+ZB8/+yPeJWPNSUnJvu1F/HHzpMUTYcHR+4NovWzfOi+QJXLcOO3B44ihVTTb/ArCjeoq2pvQS6SM0J/nobZuJAW6CwvGuB/61/u5Sj/7R/lPeAHLjqgmmlCyLQ71AcoMD4Mi4MDKbuZVJDd3MlBrxFDbgG7tORacEXVxKIwFk4Rd3RiSxMF59oTL4EHKcLT8/l+yWprpWQduH8b5xWpUr1R3XxH4WveIf8aDQJ3ff+v7xtqtInx92E1zuGI34nFUZWsONMon6GtrEeSuoFyAyUhbQzwfhAXt7gdqZVie6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZfXDTBW7e3Ody7K6nafRVS7FjVu2tDf+oF5XqRnlu4=; b=EofM/gJpxg4q1V+IBQSr4CK0tHru/VyNBcz9tkqm31/+KINjur91HqKC4fcBceaJF8+xpxJfxMavejXmRVGabqASq3ahs1xBq1/VgYPgZI9AzWEFd7aiwv6iYDQZiaMzYGk5q+4j4kyr9S7JgIawONtqcN4YM4UHdKwX4PDJ4P8m0mSzRhx9wsZOnnoOkL2YZjnp+4XeXmJzi4rz3J7zGAzpjapuyE37Gi+asvrpxomUA4tSw1m/ceVUdBM0/UKMVLszun7nKypki3fd25gsXQ2LRteLtZ05Hntvlt4kmLWIUlvUfdkfjD//6y3jcJ6ZR/1gVZOj5OK2Gg6viYVg1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZfXDTBW7e3Ody7K6nafRVS7FjVu2tDf+oF5XqRnlu4=; b=CmeDGs/Ylto0Z/oH2vbBVhQuaZxl9cnbXylskuUhVGj9lQeOkGiF8SeHMfiDwae3Z7fFgJ16Mq2dV21/TNn4tBfXxlMgPE6tNazlBfdidRgHV1zm0KY5fGenwT9ZolH9nomrOL4GpYUIt9xa25Lepi4hP5psOXFkjAawKkeh4yo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 7 Feb 2023 15:34:56 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0254.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::18) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BL3PR12MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 8901b209-51ce-47a3-0886-08db0920e165 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q89N5UkIGR9+SS8P3IvVCMXh49Z3IxZQscrpYHGm896r6ls+7qMMJYgk8dBXNBix0l4cYHDxpbILwgwSqkWcJI+kKaNMFuuNuc+roC+BujbZHSz9V/brpWkVnTXs6a2t/AhcHavZEx/VaHDpAC9n2ijMtQnk+IWZpOxROirm8BHIqMlhwYNqfe+QdvpAH2AOWTgA9YukwGj/zQqTAvYxkBkP9OpJu78ipqeUsjb1fCqsZJrcBBlw7RGe8d2LCNfm9DPuUXB/+1E9kgfCzhaPi9jR1BPlGd4sLq+c1Mh+oydQHo5h3hf0+TzIzDa7GIS7J37+QTSOp0onM3vdfGXhRxNnv0hf9dYKAmZxwJ20j6glbgQxnq19xo1JEoBnYpe29Zds/IZIg5om5cqzCt3U2KQPnJXeABSW11aF+wxbjIyFmheLqq+Kk1odbQ1RtOgofAjoOjzu/wCDs+moPrGznNh0dG8uipDwThF/Aec+2zDoKXfEpPMjDPytq/WCBgV6IYeTQzugppuHgTGaUUVMlbjUAbK9lM2F+vTfgdHvRGZWqSqrI63cgxjiGH6fSV4XWEdY+B5wds8YN9nfRuHJFtywFyyIiy5dOJr6Dz8iJZlEbekarZl88TX6Z87DC87ufZzTDzULsQ4h6VRqpeIRkd/ZgGriG26gw3JLp0UPzIwfA0xVctbLoCdAmrlIIuPTZgS7TI6zbyLAjk2LqAHhodxe7cB0oghKbCYLXui0DMc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199018)(5660300002)(31696002)(31686004)(2906002)(36756003)(41300700001)(8936002)(186003)(26005)(110136005)(38100700002)(66556008)(6512007)(66476007)(66946007)(8676002)(478600001)(4326008)(2616005)(6486002)(6666004)(316002)(83380400001)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjdPdTFrVHAyTDBYUlFISm03L2lzemt2cTVIcDhaM3daUnAwK3lGYmgvVk9K?= =?utf-8?B?VDYzRnJCZjNHRjNDU3dvbDlDdzZRcndmOEtZdmlCSkdFcml2Z29nV2FaMXRC?= =?utf-8?B?WEtDOEFGYjlaNDNPaUtDZjQvNUpEK1owcnVoWW9WL2JGRU9EQ3BLVzhucncz?= =?utf-8?B?UHNkNE1UdGlUWFJ2YWJiYmxjbE12TWozbWVKV3Q0RWRTUHQ5dTRCUWkrbDFD?= =?utf-8?B?bHRrbkZFcE4zaFRkaUpZZWJoQVJyQlpDdE0wazJLZlNhVUVET2t0aS9DK1Ns?= =?utf-8?B?OGxKVDUwYnRETGswVVU2aDZEcWZ3TlZUYkxZNzNSVi9wSEVEckIzWGxzQnJa?= =?utf-8?B?aHRkRFZDdEUrU2dlODZ6R0I1T2tkVmhLVzN2NjhiZ1ZGQkVJbXlrdzBWU1pw?= =?utf-8?B?T2hFd0dpY3R2MnptUTR3QlpVSmlwTVFqVkVLNG9FVnc3MXEvdTNZdWw4SHJt?= =?utf-8?B?ZGx2YmQ1bkhxT3haSGRRM0hHY0kxcW1uZXNwOHJERWNMT28yaGdCU1hhWnpi?= =?utf-8?B?bCtPQlNJUm03THRuMTBhc3Y3ZzdJak1CQ2lxTW5GYXI5cDlnR3JjRjZzVFVu?= =?utf-8?B?Vjc2dU1UOEJwYW93NSs5eEU2S0JBNnpDMzJjT1dCZnR1ajFuNkIwY0YrdVA1?= =?utf-8?B?L1pPMWxmUk1EdElMczdMN1RZTEhpRmpBbUJpaC85ait2ZFB3UnV4L3puM3Uy?= =?utf-8?B?NDNtT2NUS1N5a3l4NXZ0bXZWVjI4QU50QmszWS9CWWNRSU4xcHpkSUZvZVd6?= =?utf-8?B?d2V4VStBTUl1ZU1HUzJGdGI5NEdRbWQ2MDhxZnd5eXpBaDd2ZTR1QnI0N3NR?= =?utf-8?B?TWZiSVd6NDhHdlpTWTIxa1poVmtvRzBGOElsS0I4bEhZejlwcTNQUUU2N0Q5?= =?utf-8?B?RElLaUZPQjZrbkNXbUNzcnlrZVpHNkt0eEljem9jNVc0akl5S1BIY2grUlRT?= =?utf-8?B?ZjY0THg1aTUyZkNXMlg4NWFJemUzR0Y1V28yQm5PcVhUa2FXczlMNHJxc3BZ?= =?utf-8?B?ZmhQem1UZU1Gd3AzekQ0cWRHaldrbVhCYmZ1YlhucERFb3RVMEZHSTRXWmhM?= =?utf-8?B?bUo3YUZDN2kzMVU5OERnT1BFcW00QmJkOTV6d0JhNmFITzBmenY2Nnp1MHBr?= =?utf-8?B?b1NXNVltU0UvZks5MHl6UVQyS2JUMTBDZmJlaUVrdEdnRTFvSGcvK0gwNzR1?= =?utf-8?B?T05HQ3lkT2xzUHgxUmgzNXllWEtsWXJoWlA0U2Z5STZ1QnVXR2VKeEhpejRJ?= =?utf-8?B?c1YrRmRUNEJTWWwrZDNSNk1MUGpRdkduWmNlYXpXUkE0UG5Vb2RhZEFLVGdC?= =?utf-8?B?QWJFMEF6UGJpNXJIZzFLTlpMVzNHbU1YVGFxbVVhRGtlM3p6UWk3TGVWM1Zj?= =?utf-8?B?M1RBT3RjMnE0TTY5ODFYQ290V2hxTG0xanN3VDJQbEluWmRFT2tyV1BUR2dQ?= =?utf-8?B?Y2gyNUdmRGdpMTl1UklmSlVXS2xMRVdYRllqZlFHTnVMOVozTWgwYVJHbFky?= =?utf-8?B?Y290RElYMG12SmU0QytwOVhVK0NPdmFXbkEyTmQzUDkyVHlKbkt0Qkx0OGFR?= =?utf-8?B?YjdxYjMrZk5ZbVV6OWtHS2dMQTBxMDVRaWRMQmdZb1UweERXNlFOZTl2aDFX?= =?utf-8?B?bGIramFHTUg1TU5SRk5DdFJpblVsR1hkVXF0YlU5UG1PTFlkdzFWWWZTM0Fu?= =?utf-8?B?MGxxUTFGRFNCVWV3V3NCNDUvWGR3ZHJndG8wYmwwRzRaVXc4N0RRQlgvd2Vi?= =?utf-8?B?VCtvZWloNkhpN1NNc0ZCOEthQXpZVUI4WDU4L2Ntd1N4SE42WW1KT1dralZ4?= =?utf-8?B?bkdsR1BWRlloK1FwZXg5TGdNK0FQVXF5Y05aSFJKQlJEVG9qa0Y0MlFIdU1y?= =?utf-8?B?ZXlCS294UE96WXdUOHdhV1p4YVVod3MvU3ZuZHJtTEpweDV1S2pabmUvWExM?= =?utf-8?B?Qk9mWlA3R092eEx0SGlxTnVXNUhuZ1FZMWR3REdhWEcrdVdWbFgyVGdTaFVm?= =?utf-8?B?a3ZGQ0taV0I0dUlKamx3RVR4N2ZyWDZ5Y3dYa2Q1M2pFLzA2VlhNZXo2eEVT?= =?utf-8?B?MHpYaFgvdVVMQUNYS1pBQlphTXR6aHZJbmpxQXJXUlh3WHlqaWU4bk5JOFZF?= =?utf-8?Q?xAQzuB+UeI5w+2VnxRyITQP7Y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8901b209-51ce-47a3-0886-08db0920e165 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 15:35:03.0499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Re+uDZNgPAhArNkBN9IPZFZ/KEVre5+lOxQZmLoqdDLeADA0VTo8VQljW627jFKVou751zJuKz2Dje94YwI+3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6644 On 20/01/2023 11:06, Julien Grall wrote: > Hi Ayan, Hi Julien, > > On 17/01/2023 17:43, Ayan Kumar Halder wrote: >> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >> "Virtualization Translation Control Register" for the bit descriptions. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> Changes from - >> >> v1 - New patch. >> >>   xen/arch/arm/p2m.c | 10 +++++++--- >>   1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index 948f199d84..cfdea55e71 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>       register_t val = >> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>     #ifdef CONFIG_ARM_32 >> -    if ( p2m_ipa_bits < 40 ) >> +    if ( p2m_ipa_bits < PADDR_BITS ) >>           panic("P2M: Not able to support %u-bit IPA at the moment\n", >>                 p2m_ipa_bits); >>   -    printk("P2M: 40-bit IPA\n"); >> -    p2m_ipa_bits = 40; >> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >> +    p2m_ipa_bits = PADDR_BITS; >> +#ifdef CONFIG_ARM_PA_32 >> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >> +#else >>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >> +#endif > > I am wondering whether this is right time to switch to an array like > the arm64 code? This would allow to use 32-bit IPA also when Xen > support 64-bit physical address. In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the physical address range supported at runtime. This is then used as an index into pa_range_info[] to determine t0sz, root_order, etc. However, for AArch32 I do not see an equivalent register (similar to ID_AA64MMFR0_EL1) or any register to determine the physical address range. Thus, I will prefer to keep the code as it is unless you suggest any alternative. - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Feb 07 15:37:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 15:37:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491316.760387 (Exim 4.92) (envelope-from ) id 1pPQ2G-0003P0-By; Tue, 07 Feb 2023 15:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491316.760387; Tue, 07 Feb 2023 15:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQ2G-0003Ot-8R; Tue, 07 Feb 2023 15:37:32 +0000 Received: by outflank-mailman (input) for mailman id 491316; Tue, 07 Feb 2023 15:37:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQ2F-0003On-P2 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 15:37:31 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5369dfb1-a6fd-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 16:37:29 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5369dfb1-a6fd-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675784249; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MzFiCAJWokp+6zcRaC5Zzpqym3xpJR7o9NQ472GezWo=; b=MdQ/+wa/Xuyh4FUYC/RYAPPp4VKh3xRnjMY2F+d7ArwJInbLjwK5hQz8 QL6IlSdOWqfqPwNwZgVgnl3eSr9XkCzXLX8ixxvzvGf4bIU8PbhJ6EdB0 /EeBtXoLPTpa10CsDCQa+MBbV9QPx2W6K4jbBrSgbOyCs6K7t5qIDPbe6 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95443851 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:R5baOaigqg+IGDdT/Qdn4katX1612RAKZh0ujC45NGQN5FlHY01je htvXG7Sb/iJa2D3KdwjboS3p0wAucLTzodhQAZqpC9mQn8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5geBzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ8dW4rQyuGtd6H4+KSE/JRi8k6EMDCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27J+ z6apDSkW3n2MvSjxx6F0yypg9bIxzzlecUYE7KR0/R11Qj7Kms7V0RNCArTTeOCokKzXtN3K koK+zEvp6w/6EyqSNbmWxSy5nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neLld70AT1ksJWOVGmQsLyTqFuaOzURLGIETT8JS00C+daLiJookhvFQ9JnEai0pt74Azf9x 3aNtidWr6oXpd4G0eO851+vqzmlvJTOQyY+7x/bWW/j5QR8DKa+bom15Fyd8fZBJo+ESkWps X4f3syP6+ZICouC/ASISf8IFauk5N6ENiPdml9lG5Q99zWr9GWndIoW6zZ7TG9gKssecCXlS FPSswhWopRUOROXgbRfOtzrTZ5wlO65SIqjD6qPBjZTXnRvXCvaogdDXkui41HOwGF1ipwyN I6neO/5WB72Fp9b5DaxQu4c15oiySY/2X7fSPjH8vi37VaNTCXLEOlYaTNiesh8tfrZ+1uNr 76zIuPQk31ivPvCjj47GGL5BXQDNjAFCJ//sKS7ncbTc1M9SAnN5xI8qI7NmrCJfYwPzo8kH VnnACe0LWYTYlWZQThmklg5NNvSsW9X9BrXxxAEM1eywGQEao2y9qoZfJZfVeB5q7E8la4oF 6ZZIZ/o7hFzptPvomV1UHUAhNY6KETDafymb0JJnwTTj7Y/HleUq7cIjyPk9TUUDzrfiCfNi +TI6+8verJaH14KJJ+POJqSI6aZ4SB1dBRaAxGZfbG+uSzErOBXFsAGpqVofpxSd06enGvyO sT/KU5wmNQharQdqLHh7Z1oZa/weweiNiK2x1Xm0Is= IronPort-HdrOrdr: A9a23:bEhxSqpZtUOpz4JYFMCpTQoaV5stL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssScb6KG90dq7MAvhHP9OkO8s1NKZMDUO11HYS72KgbGSpgEIXheOjNK1tp 0QEZSWaueAdmSS5PySiGbXYrUdLcG8kJxAx92uskuFJTsaG52IhD0JdDpzZ3cGOzWucqBJaK Z0iPA3wwZITU5nHfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1yi0hIXQ1p0sMEfGT yuqW3Ez5Tml8v+5g7X1mfV4ZgTssDm0MF/CMuFjdVQAinwiy6zDb4RG4GqjXQQmqWC+VwqmN 7Dr1MLJMJo8U7ceWmzvF/ExxTg6jAz8HXvoGXowEcLmfaJBw7SNvAxyr6xMyGpp3bIhesMnZ 6jCljp+aa+RHn77V3AD9uhbWAcqqP7mwthrQcptQ0qbWIvUs4ikWUhxjIhLH4hJlOy1Gl1Kp gnMCib3ocdTW+n X-IronPort-AV: E=Sophos;i="5.97,278,1669093200"; d="scan'208";a="95443851" Date: Tue, 7 Feb 2023 15:37:14 +0000 From: Anthony PERARD To: Demi Marie Obenour CC: , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Doug Goldstein , Samuel Thibault , "Roger Pau =?iso-8859-1?Q?Monn=E9?=" , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= Subject: Re: [PATCH] Replace git:// and http:// with https:// Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Mon, Feb 06, 2023 at 10:10:33PM -0500, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > This patch was created by doing a tree-wide search and replace with sed, > then reverting changes that were pointless or wrong. > > Signed-off-by: Demi Marie Obenour Hi, Thanks for the patch. Could you split this patch into several patches? I think that would make it easier to review. Not all URL are equal, or have the same purpose. They need to be check one by one to make sure that the right change to do. I propose at least 3 patches: > --- "automation / CI" changes: > automation/build/centos/CentOS-7.2.repo | 8 ++++---- > automation/build/debian/stretch-llvm-8.list | 4 ++-- > automation/build/debian/unstable-llvm-8.list | 4 ++-- > automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- "build system" changes: > Config.mk | 20 ++++++-------------- > stubdom/configure | 18 +++++++++--------- > stubdom/configure.ac | 18 +++++++++--------- > tools/firmware/etherboot/Makefile | 4 ++-- "miscellaneous and documentation": > README | 4 ++-- > docs/README.remus | 2 +- > docs/conf.py | 2 +- > scripts/get_maintainer.pl | 2 +- > stubdom/grub.patches/10graphics.diff | 2 +- > tools/examples/xeninfo.pl | 2 +- > tools/firmware/etherboot/README | 2 +- > tools/firmware/hvmloader/pci_regs.h | 2 +- > tools/firmware/hvmloader/pir.c | 2 +- > tools/firmware/hvmloader/pir_types.h | 2 +- > tools/firmware/hvmloader/smbios_types.h | 2 +- > 19 files changed, 47 insertions(+), 55 deletions(-) In or after the "build system" patch, you could propose to remove GIT_HTTP variable, and only use https:// urls. A separate change could be better as we could easily revert it if that an issue. We could start with a patch to default to GIT_HTTP=y, even if all urls would bu https. > diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh > index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..22ec2f2474ed3d1f1f614085f9bd832be4d42496 100755 > --- a/automation/scripts/qemu-smoke-dom0-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh > @@ -4,7 +4,7 @@ set -ex > > cd binaries > # Use the kernel from Debian > -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz > +curl --fail --silent --show-error --location --output vmlinuz https://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz This url change is wrong, the certificate provided aren't for debian.org. > # Use a tiny initrd based on busybox from Alpine Linux > curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz > > diff --git a/docs/README.remus b/docs/README.remus > index e41e045a109466213b39bf5099ee16652b229ccc..5e411addb1a63f1b2c01ff165fc6f74d6d81c8ea 100644 > --- a/docs/README.remus > +++ b/docs/README.remus > @@ -7,7 +7,7 @@ Using Remus with libxl on Xen 4.5 and higher: > To enable network buffering, you need libnl 3.2.8 > or higher along with the development headers and command line utilities. > If your distro does not have the appropriate libnl3 version, you can find > - the latest source tarball of libnl3 at http://www.carisma.slowglass.com/~tgr/libnl/ > + the latest source tarball of libnl3 at https://www.carisma.slowglass.com/~tgr/libnl/ This url doesn't exist anymore, so better not change it, or fix the comment. > > Disk replication: > VMs protected by Remus need to use DRBD based disk backends. Specifically, you > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 48e07370e8d462ced70a1de13ec8134b4eed65ba..9f32e0e0c0ec5c491209d6e73232b5a388b0a588 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -1457,7 +1457,7 @@ sub vcs_exists { > warn("$P: No supported VCS found. Add --nogit to options?\n"); > warn("Using a git repository produces better results.\n"); > warn("Try latest git repository using:\n"); > - warn("git clone git://xenbits.xen.org/xen.git\n"); > + warn("git clone https://xenbits.xen.org/xen.git\n"); This url is wrong, xenbits provides git trees on http via a different path, see in Config.mk. > $printed_novcs = 1; > } > return 0; > diff --git a/tools/examples/xeninfo.pl b/tools/examples/xeninfo.pl > index 95a15d9595c0f4bf09c9429099bd3b27e98ebf3e..1815d1d9f219799a83fbc0329a4a1a010264893e 100644 > --- a/tools/examples/xeninfo.pl > +++ b/tools/examples/xeninfo.pl > @@ -36,7 +36,7 @@ sub apiconnect > { > foreach my $xenhost (keys %xenhosts) > { > - my $xen = RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}"); > + my $xen = RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}"); I'm pretty sure that the wrong change to do here. > my $session = $xen->simple_request("session.login_with_password", "user",""); > if (! $session) > { I haven't check every urls, there's probably other that want to be change to something else rather that just s/http/https/. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 07 16:11:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 16:11:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491326.760398 (Exim 4.92) (envelope-from ) id 1pPQYU-00005u-4J; Tue, 07 Feb 2023 16:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491326.760398; Tue, 07 Feb 2023 16:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQYU-00005n-0N; Tue, 07 Feb 2023 16:10:50 +0000 Received: by outflank-mailman (input) for mailman id 491326; Tue, 07 Feb 2023 16:10:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQYR-00005d-7h for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 16:10:48 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc866d85-a701-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 17:10:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc866d85-a701-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675786209; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=B7PmvqwHTmYEXj8KCOsl8OPJeetpt8oR6BHQJvweCgU=; b=SfYraN6gpqDtJNWvT9/K5IkFmsfzPhMFJg7vSlCTWZ4q4KbQiN8E0t3W aX4G480iTCzXo8XHfYE92qr8W9MDu0LSqFREec5B9rOOt0jtx355+MFWM JMBZbj3JLLDIlhrgpxfU7xtaMLEzKO3u3SkpNXkMHDrpw78tHU4zNmcXX Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96052655 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:rAZX2qJ6Ww3H8zcCFE+RxJUlxSXFcZb7ZxGr2PjKsXjdYENS0GABm jBNCmCBMveCNGamKdAlYYTj8hgCuJbXnNVqT1ZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5ARhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5IKF922 MUfDgwASQKGq9mf4+6lEdNz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbG50IxBjF+ woq+UzhOjQnMZ+h9ADdsVG8jbHdvBLdW5wrQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 04b4C01toAp6VemCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3PLaXhRzi AXPxYmwQ2Uy7vvMEyn1GqqoQS2aBgErFUI7Ygk4QCwX5vXYiaJvkEn1UYM2eEKqteHdFTb1y jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD3271k5JAVdoKiN2bGKuOGphsRNMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QRP8cpJFPfo300PyZ8OlwBd2B1wMkC1 WqzK57wXR7294w3pNZJewvt+eBynX1vrY8ibZv60w6mwdKjiI29EN843K+1Rrlhtsus+VyFm +uzwuPWk32zpsWiOHiImWPSRHhWRUUG6Wfe8ZMKK7DdeVc8SAnMyZb5mNscRmCspIwN/s+gw 513chUwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:Q28U569pXTnGaBmAfgJuk+DxI+orL9Y04lQ7vn2ZKCYlEPBw8v rFoB1173LJYVoqNE3I4OrwXpVoIkmslqKdg7NxAV7KZmCPhILPFu5fBODZowEIdReRygdr79 YET0EvMrbN5IBB/L7HCdODYrEdKQS8gcSVbDvlvg5QpN9RGtpd0zs= X-IronPort-AV: E=Sophos;i="5.97,278,1669093200"; d="scan'208";a="96052655" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu , "Juergen Gross" Subject: [XEN PATCH] tools: Have flex and bison mandatory Date: Tue, 7 Feb 2023 16:09:48 +0000 Message-ID: <20230207160948.3169-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Both are already mandatory to build the hypervisor. This will help avoid cases where the *.y or *.l files are been updated but flex and bison aren't available. This also remove the way the missing binaries are been handled, with double-column-rules, which might be an issue sometime. Adding ".SECONDARY:" to avoid "libxlu_cfg_y.c" been deleted by make when building the library, and regenerating the file on the first incremental build. Signed-off-by: Anthony PERARD --- tools/configure | 142 +- tools/configure.ac | 8 +- tools/libs/util/.gitignore | 1 + tools/libs/util/Makefile | 21 +- tools/libs/util/libxlu_cfg_l.c | 2375 ------------------------ tools/libs/util/libxlu_cfg_l.h | 734 -------- tools/libs/util/libxlu_cfg_y.c | 1705 ------------------ tools/libs/util/libxlu_cfg_y.h | 96 - tools/libs/util/libxlu_disk_l.c | 2975 ------------------------------- tools/libs/util/libxlu_disk_l.h | 701 -------- 10 files changed, 60 insertions(+), 8698 deletions(-) create mode 100644 tools/libs/util/.gitignore delete mode 100644 tools/libs/util/libxlu_cfg_l.c delete mode 100644 tools/libs/util/libxlu_cfg_l.h delete mode 100644 tools/libs/util/libxlu_cfg_y.c delete mode 100644 tools/libs/util/libxlu_cfg_y.h delete mode 100644 tools/libs/util/libxlu_disk_l.c delete mode 100644 tools/libs/util/libxlu_disk_l.h diff --git a/tools/configure b/tools/configure index dae377c982..75ae8caa5b 100755 --- a/tools/configure +++ b/tools/configure @@ -5448,6 +5448,51 @@ test -z "$INSTALL_SCRIPT" && INSTALL_SCRIPT='${INSTALL}' test -z "$INSTALL_DATA" && INSTALL_DATA='${INSTALL} -m 644' +# Extract the first word of "bison", so it can be a program name with args. +set dummy bison; ac_word=$2 +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 +$as_echo_n "checking for $ac_word... " >&6; } +if ${ac_cv_path_BISON+:} false; then : + $as_echo_n "(cached) " >&6 +else + case $BISON in + [\\/]* | ?:[\\/]*) + ac_cv_path_BISON="$BISON" # Let the user override the test with a path. + ;; + *) + as_save_IFS=$IFS; IFS=$PATH_SEPARATOR +for as_dir in $PATH +do + IFS=$as_save_IFS + test -z "$as_dir" && as_dir=. + for ac_exec_ext in '' $ac_executable_extensions; do + if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then + ac_cv_path_BISON="$as_dir/$ac_word$ac_exec_ext" + $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 + break 2 + fi +done + done +IFS=$as_save_IFS + + test -z "$ac_cv_path_BISON" && ac_cv_path_BISON="no" + ;; +esac +fi +BISON=$ac_cv_path_BISON +if test -n "$BISON"; then + { $as_echo "$as_me:${as_lineno-$LINENO}: result: $BISON" >&5 +$as_echo "$BISON" >&6; } +else + { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 +$as_echo "no" >&6; } +fi + + +if test x"${BISON}" = x"no" +then + as_fn_error $? "Unable to find bison, please install bison" "$LINENO" 5 +fi # Extract the first word of "flex", so it can be a program name with args. set dummy flex; ac_word=$2 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 @@ -5475,6 +5520,7 @@ done done IFS=$as_save_IFS + test -z "$ac_cv_path_FLEX" && ac_cv_path_FLEX="no" ;; esac fi @@ -5488,6 +5534,10 @@ $as_echo "no" >&6; } fi +if test x"${FLEX}" = x"no" +then + as_fn_error $? "Unable to find flex, please install flex" "$LINENO" 5 +fi # Extract the first word of "abi-dumper", so it can be a program name with args. set dummy abi-dumper; ac_word=$2 { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 @@ -10117,98 +10167,6 @@ else fi -if test "x$pvshim" = "xy"; then : - - # Extract the first word of "bison", so it can be a program name with args. -set dummy bison; ac_word=$2 -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 -$as_echo_n "checking for $ac_word... " >&6; } -if ${ac_cv_path_BISON+:} false; then : - $as_echo_n "(cached) " >&6 -else - case $BISON in - [\\/]* | ?:[\\/]*) - ac_cv_path_BISON="$BISON" # Let the user override the test with a path. - ;; - *) - as_save_IFS=$IFS; IFS=$PATH_SEPARATOR -for as_dir in $PATH -do - IFS=$as_save_IFS - test -z "$as_dir" && as_dir=. - for ac_exec_ext in '' $ac_executable_extensions; do - if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then - ac_cv_path_BISON="$as_dir/$ac_word$ac_exec_ext" - $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 - break 2 - fi -done - done -IFS=$as_save_IFS - - test -z "$ac_cv_path_BISON" && ac_cv_path_BISON="no" - ;; -esac -fi -BISON=$ac_cv_path_BISON -if test -n "$BISON"; then - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $BISON" >&5 -$as_echo "$BISON" >&6; } -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } -fi - - -if test x"${BISON}" = x"no" -then - as_fn_error $? "Unable to find bison, please install bison" "$LINENO" 5 -fi - -else - - # Extract the first word of "bison", so it can be a program name with args. -set dummy bison; ac_word=$2 -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 -$as_echo_n "checking for $ac_word... " >&6; } -if ${ac_cv_path_BISON+:} false; then : - $as_echo_n "(cached) " >&6 -else - case $BISON in - [\\/]* | ?:[\\/]*) - ac_cv_path_BISON="$BISON" # Let the user override the test with a path. - ;; - *) - as_save_IFS=$IFS; IFS=$PATH_SEPARATOR -for as_dir in $PATH -do - IFS=$as_save_IFS - test -z "$as_dir" && as_dir=. - for ac_exec_ext in '' $ac_executable_extensions; do - if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then - ac_cv_path_BISON="$as_dir/$ac_word$ac_exec_ext" - $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 - break 2 - fi -done - done -IFS=$as_save_IFS - - ;; -esac -fi -BISON=$ac_cv_path_BISON -if test -n "$BISON"; then - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $BISON" >&5 -$as_echo "$BISON" >&6; } -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 -$as_echo "no" >&6; } -fi - - - -fi ax_found=0 diff --git a/tools/configure.ac b/tools/configure.ac index 3a2f6a2da9..1a714d9ff7 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -298,7 +298,8 @@ AC_ARG_VAR([AWK], [Path to awk tool]) AC_PROG_CC AC_PROG_MAKE_SET AC_PROG_INSTALL -AC_PATH_PROG([FLEX], [flex]) +AX_PATH_PROG_OR_FAIL([BISON], [bison]) +AX_PATH_PROG_OR_FAIL([FLEX], [flex]) AC_PATH_PROG([ABI_DUMPER], [abi-dumper]) AX_PATH_PROG_OR_FAIL([PERL], [perl]) AX_PATH_PROG_OR_FAIL([AWK], [awk]) @@ -512,11 +513,6 @@ AC_ARG_ENABLE([pvshim], esac ]) AC_SUBST(pvshim) -AS_IF([test "x$pvshim" = "xy"], [ - AX_PATH_PROG_OR_FAIL([BISON], [bison]) -], [ - AC_PATH_PROG([BISON], [bison]) -]) AX_FIND_HEADER([INCLUDE_ENDIAN_H], [endian.h sys/endian.h]) diff --git a/tools/libs/util/.gitignore b/tools/libs/util/.gitignore new file mode 100644 index 0000000000..63e62ad066 --- /dev/null +++ b/tools/libs/util/.gitignore @@ -0,0 +1 @@ +/libxlu_*_[ly].[ch] diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile index e016baf888..93ebf930a4 100644 --- a/tools/libs/util/Makefile +++ b/tools/libs/util/Makefile @@ -16,18 +16,6 @@ CFLAGS += $(CFLAGS_libxenctrl) CFLAGS += $(PTHREAD_CFLAGS) LDFLAGS += $(PTHREAD_LDFLAGS) -ifeq ($(FLEX),) -%.c %.h:: %.l - $(warning Flex is needed to rebuild some libxl parsers and \ - scanners, please install it and rerun configure) -endif - -ifeq ($(BISON),) -%.c %.h:: %.y - $(warning Bison is needed to rebuild some libxl parsers and \ - scanners, please install it and rerun configure) -endif - AUTOINCS = libxlu_cfg_y.h libxlu_cfg_l.h libxlu_disk_l.h LIBHEADER := libxlutil.h @@ -40,10 +28,15 @@ include $(XEN_ROOT)/tools/libs/libs.mk $(OBJS-y) $(PIC_OBJS): $(AUTOINCS) -%.c %.h:: %.y +%.c %.h: %.y @rm -f $*.[ch] $(BISON) --output=$*.c $< -%.c %.h:: %.l +%.c %.h: %.l @rm -f $*.[ch] $(FLEX) --header-file=$*.h --outfile=$*.c $< + +clean:: + $(RM) libxlu_*_[ly].[ch] + +.SECONDARY: diff --git a/tools/libs/util/libxlu_cfg_l.c b/tools/libs/util/libxlu_cfg_l.c deleted file mode 100644 index 406b50a037..0000000000 --- a/tools/libs/util/libxlu_cfg_l.c +++ /dev/null @@ -1,2375 +0,0 @@ -#line 2 "libxlu_cfg_l.c" - -#line 4 "libxlu_cfg_l.c" - -#define YY_INT_ALIGNED short int - -/* A lexical scanner generated by flex */ - -#define FLEX_SCANNER -#define YY_FLEX_MAJOR_VERSION 2 -#define YY_FLEX_MINOR_VERSION 6 -#define YY_FLEX_SUBMINOR_VERSION 4 -#if YY_FLEX_SUBMINOR_VERSION > 0 -#define FLEX_BETA -#endif - -#ifdef yy_create_buffer -#define xlu__cfg_yy_create_buffer_ALREADY_DEFINED -#else -#define yy_create_buffer xlu__cfg_yy_create_buffer -#endif - -#ifdef yy_delete_buffer -#define xlu__cfg_yy_delete_buffer_ALREADY_DEFINED -#else -#define yy_delete_buffer xlu__cfg_yy_delete_buffer -#endif - -#ifdef yy_scan_buffer -#define xlu__cfg_yy_scan_buffer_ALREADY_DEFINED -#else -#define yy_scan_buffer xlu__cfg_yy_scan_buffer -#endif - -#ifdef yy_scan_string -#define xlu__cfg_yy_scan_string_ALREADY_DEFINED -#else -#define yy_scan_string xlu__cfg_yy_scan_string -#endif - -#ifdef yy_scan_bytes -#define xlu__cfg_yy_scan_bytes_ALREADY_DEFINED -#else -#define yy_scan_bytes xlu__cfg_yy_scan_bytes -#endif - -#ifdef yy_init_buffer -#define xlu__cfg_yy_init_buffer_ALREADY_DEFINED -#else -#define yy_init_buffer xlu__cfg_yy_init_buffer -#endif - -#ifdef yy_flush_buffer -#define xlu__cfg_yy_flush_buffer_ALREADY_DEFINED -#else -#define yy_flush_buffer xlu__cfg_yy_flush_buffer -#endif - -#ifdef yy_load_buffer_state -#define xlu__cfg_yy_load_buffer_state_ALREADY_DEFINED -#else -#define yy_load_buffer_state xlu__cfg_yy_load_buffer_state -#endif - -#ifdef yy_switch_to_buffer -#define xlu__cfg_yy_switch_to_buffer_ALREADY_DEFINED -#else -#define yy_switch_to_buffer xlu__cfg_yy_switch_to_buffer -#endif - -#ifdef yypush_buffer_state -#define xlu__cfg_yypush_buffer_state_ALREADY_DEFINED -#else -#define yypush_buffer_state xlu__cfg_yypush_buffer_state -#endif - -#ifdef yypop_buffer_state -#define xlu__cfg_yypop_buffer_state_ALREADY_DEFINED -#else -#define yypop_buffer_state xlu__cfg_yypop_buffer_state -#endif - -#ifdef yyensure_buffer_stack -#define xlu__cfg_yyensure_buffer_stack_ALREADY_DEFINED -#else -#define yyensure_buffer_stack xlu__cfg_yyensure_buffer_stack -#endif - -#ifdef yylex -#define xlu__cfg_yylex_ALREADY_DEFINED -#else -#define yylex xlu__cfg_yylex -#endif - -#ifdef yyrestart -#define xlu__cfg_yyrestart_ALREADY_DEFINED -#else -#define yyrestart xlu__cfg_yyrestart -#endif - -#ifdef yylex_init -#define xlu__cfg_yylex_init_ALREADY_DEFINED -#else -#define yylex_init xlu__cfg_yylex_init -#endif - -#ifdef yylex_init_extra -#define xlu__cfg_yylex_init_extra_ALREADY_DEFINED -#else -#define yylex_init_extra xlu__cfg_yylex_init_extra -#endif - -#ifdef yylex_destroy -#define xlu__cfg_yylex_destroy_ALREADY_DEFINED -#else -#define yylex_destroy xlu__cfg_yylex_destroy -#endif - -#ifdef yyget_debug -#define xlu__cfg_yyget_debug_ALREADY_DEFINED -#else -#define yyget_debug xlu__cfg_yyget_debug -#endif - -#ifdef yyset_debug -#define xlu__cfg_yyset_debug_ALREADY_DEFINED -#else -#define yyset_debug xlu__cfg_yyset_debug -#endif - -#ifdef yyget_extra -#define xlu__cfg_yyget_extra_ALREADY_DEFINED -#else -#define yyget_extra xlu__cfg_yyget_extra -#endif - -#ifdef yyset_extra -#define xlu__cfg_yyset_extra_ALREADY_DEFINED -#else -#define yyset_extra xlu__cfg_yyset_extra -#endif - -#ifdef yyget_in -#define xlu__cfg_yyget_in_ALREADY_DEFINED -#else -#define yyget_in xlu__cfg_yyget_in -#endif - -#ifdef yyset_in -#define xlu__cfg_yyset_in_ALREADY_DEFINED -#else -#define yyset_in xlu__cfg_yyset_in -#endif - -#ifdef yyget_out -#define xlu__cfg_yyget_out_ALREADY_DEFINED -#else -#define yyget_out xlu__cfg_yyget_out -#endif - -#ifdef yyset_out -#define xlu__cfg_yyset_out_ALREADY_DEFINED -#else -#define yyset_out xlu__cfg_yyset_out -#endif - -#ifdef yyget_leng -#define xlu__cfg_yyget_leng_ALREADY_DEFINED -#else -#define yyget_leng xlu__cfg_yyget_leng -#endif - -#ifdef yyget_text -#define xlu__cfg_yyget_text_ALREADY_DEFINED -#else -#define yyget_text xlu__cfg_yyget_text -#endif - -#ifdef yyget_lineno -#define xlu__cfg_yyget_lineno_ALREADY_DEFINED -#else -#define yyget_lineno xlu__cfg_yyget_lineno -#endif - -#ifdef yyset_lineno -#define xlu__cfg_yyset_lineno_ALREADY_DEFINED -#else -#define yyset_lineno xlu__cfg_yyset_lineno -#endif - -#ifdef yyget_column -#define xlu__cfg_yyget_column_ALREADY_DEFINED -#else -#define yyget_column xlu__cfg_yyget_column -#endif - -#ifdef yyset_column -#define xlu__cfg_yyset_column_ALREADY_DEFINED -#else -#define yyset_column xlu__cfg_yyset_column -#endif - -#ifdef yywrap -#define xlu__cfg_yywrap_ALREADY_DEFINED -#else -#define yywrap xlu__cfg_yywrap -#endif - -#ifdef yyget_lval -#define xlu__cfg_yyget_lval_ALREADY_DEFINED -#else -#define yyget_lval xlu__cfg_yyget_lval -#endif - -#ifdef yyset_lval -#define xlu__cfg_yyset_lval_ALREADY_DEFINED -#else -#define yyset_lval xlu__cfg_yyset_lval -#endif - -#ifdef yyget_lloc -#define xlu__cfg_yyget_lloc_ALREADY_DEFINED -#else -#define yyget_lloc xlu__cfg_yyget_lloc -#endif - -#ifdef yyset_lloc -#define xlu__cfg_yyset_lloc_ALREADY_DEFINED -#else -#define yyset_lloc xlu__cfg_yyset_lloc -#endif - -#ifdef yyalloc -#define xlu__cfg_yyalloc_ALREADY_DEFINED -#else -#define yyalloc xlu__cfg_yyalloc -#endif - -#ifdef yyrealloc -#define xlu__cfg_yyrealloc_ALREADY_DEFINED -#else -#define yyrealloc xlu__cfg_yyrealloc -#endif - -#ifdef yyfree -#define xlu__cfg_yyfree_ALREADY_DEFINED -#else -#define yyfree xlu__cfg_yyfree -#endif - -/* First, we deal with platform-specific or compiler-specific issues. */ - -/* begin standard C headers. */ -#include -#include -#include -#include - -/* end standard C headers. */ - -/* flex integer type definitions */ - -#ifndef FLEXINT_H -#define FLEXINT_H - -/* C99 systems have . Non-C99 systems may or may not. */ - -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L - -/* C99 says to define __STDC_LIMIT_MACROS before including stdint.h, - * if you want the limit (max/min) macros for int types. - */ -#ifndef __STDC_LIMIT_MACROS -#define __STDC_LIMIT_MACROS 1 -#endif - -#include -typedef int8_t flex_int8_t; -typedef uint8_t flex_uint8_t; -typedef int16_t flex_int16_t; -typedef uint16_t flex_uint16_t; -typedef int32_t flex_int32_t; -typedef uint32_t flex_uint32_t; -#else -typedef signed char flex_int8_t; -typedef short int flex_int16_t; -typedef int flex_int32_t; -typedef unsigned char flex_uint8_t; -typedef unsigned short int flex_uint16_t; -typedef unsigned int flex_uint32_t; - -/* Limits of integral types. */ -#ifndef INT8_MIN -#define INT8_MIN (-128) -#endif -#ifndef INT16_MIN -#define INT16_MIN (-32767-1) -#endif -#ifndef INT32_MIN -#define INT32_MIN (-2147483647-1) -#endif -#ifndef INT8_MAX -#define INT8_MAX (127) -#endif -#ifndef INT16_MAX -#define INT16_MAX (32767) -#endif -#ifndef INT32_MAX -#define INT32_MAX (2147483647) -#endif -#ifndef UINT8_MAX -#define UINT8_MAX (255U) -#endif -#ifndef UINT16_MAX -#define UINT16_MAX (65535U) -#endif -#ifndef UINT32_MAX -#define UINT32_MAX (4294967295U) -#endif - -#ifndef SIZE_MAX -#define SIZE_MAX (~(size_t)0) -#endif - -#endif /* ! C99 */ - -#endif /* ! FLEXINT_H */ - -/* begin standard C++ headers. */ - -/* TODO: this is always defined, so inline it */ -#define yyconst const - -#if defined(__GNUC__) && __GNUC__ >= 3 -#define yynoreturn __attribute__((__noreturn__)) -#else -#define yynoreturn -#endif - -/* Returned upon end-of-file. */ -#define YY_NULL 0 - -/* Promotes a possibly negative, possibly signed char to an - * integer in range [0..255] for use as an array index. - */ -#define YY_SC_TO_UI(c) ((YY_CHAR) (c)) - -/* An opaque pointer. */ -#ifndef YY_TYPEDEF_YY_SCANNER_T -#define YY_TYPEDEF_YY_SCANNER_T -typedef void* yyscan_t; -#endif - -/* For convenience, these vars (plus the bison vars far below) - are macros in the reentrant scanner. */ -#define yyin yyg->yyin_r -#define yyout yyg->yyout_r -#define yyextra yyg->yyextra_r -#define yyleng yyg->yyleng_r -#define yytext yyg->yytext_r -#define yylineno (YY_CURRENT_BUFFER_LVALUE->yy_bs_lineno) -#define yycolumn (YY_CURRENT_BUFFER_LVALUE->yy_bs_column) -#define yy_flex_debug yyg->yy_flex_debug_r - -/* Enter a start condition. This macro really ought to take a parameter, - * but we do it the disgusting crufty way forced on us by the ()-less - * definition of BEGIN. - */ -#define BEGIN yyg->yy_start = 1 + 2 * -/* Translate the current start state into a value that can be later handed - * to BEGIN to return to the state. The YYSTATE alias is for lex - * compatibility. - */ -#define YY_START ((yyg->yy_start - 1) / 2) -#define YYSTATE YY_START -/* Action number for EOF rule of a given start state. */ -#define YY_STATE_EOF(state) (YY_END_OF_BUFFER + state + 1) -/* Special action meaning "start processing a new file". */ -#define YY_NEW_FILE yyrestart( yyin , yyscanner ) -#define YY_END_OF_BUFFER_CHAR 0 - -/* Size of default input buffer. */ -#ifndef YY_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k. - * Moreover, YY_BUF_SIZE is 2*YY_READ_BUF_SIZE in the general case. - * Ditto for the __ia64__ case accordingly. - */ -#define YY_BUF_SIZE 32768 -#else -#define YY_BUF_SIZE 16384 -#endif /* __ia64__ */ -#endif - -/* The state buf must be large enough to hold one state per character in the main buffer. - */ -#define YY_STATE_BUF_SIZE ((YY_BUF_SIZE + 2) * sizeof(yy_state_type)) - -#ifndef YY_TYPEDEF_YY_BUFFER_STATE -#define YY_TYPEDEF_YY_BUFFER_STATE -typedef struct yy_buffer_state *YY_BUFFER_STATE; -#endif - -#ifndef YY_TYPEDEF_YY_SIZE_T -#define YY_TYPEDEF_YY_SIZE_T -typedef size_t yy_size_t; -#endif - -#define EOB_ACT_CONTINUE_SCAN 0 -#define EOB_ACT_END_OF_FILE 1 -#define EOB_ACT_LAST_MATCH 2 - - /* Note: We specifically omit the test for yy_rule_can_match_eol because it requires - * access to the local variable yy_act. Since yyless() is a macro, it would break - * existing scanners that call yyless() from OUTSIDE yylex. - * One obvious solution it to make yy_act a global. I tried that, and saw - * a 5% performance hit in a non-yylineno scanner, because yy_act is - * normally declared as a register variable-- so it is not worth it. - */ - #define YY_LESS_LINENO(n) \ - do { \ - int yyl;\ - for ( yyl = n; yyl < yyleng; ++yyl )\ - if ( yytext[yyl] == '\n' )\ - --yylineno;\ - }while(0) - #define YY_LINENO_REWIND_TO(dst) \ - do {\ - const char *p;\ - for ( p = yy_cp-1; p >= (dst); --p)\ - if ( *p == '\n' )\ - --yylineno;\ - }while(0) - -/* Return all but the first "n" matched characters back to the input stream. */ -#define yyless(n) \ - do \ - { \ - /* Undo effects of setting up yytext. */ \ - int yyless_macro_arg = (n); \ - YY_LESS_LINENO(yyless_macro_arg);\ - *yy_cp = yyg->yy_hold_char; \ - YY_RESTORE_YY_MORE_OFFSET \ - yyg->yy_c_buf_p = yy_cp = yy_bp + yyless_macro_arg - YY_MORE_ADJ; \ - YY_DO_BEFORE_ACTION; /* set up yytext again */ \ - } \ - while ( 0 ) -#define unput(c) yyunput( c, yyg->yytext_ptr , yyscanner ) - -#ifndef YY_STRUCT_YY_BUFFER_STATE -#define YY_STRUCT_YY_BUFFER_STATE -struct yy_buffer_state - { - FILE *yy_input_file; - - char *yy_ch_buf; /* input buffer */ - char *yy_buf_pos; /* current position in input buffer */ - - /* Size of input buffer in bytes, not including room for EOB - * characters. - */ - int yy_buf_size; - - /* Number of characters read into yy_ch_buf, not including EOB - * characters. - */ - int yy_n_chars; - - /* Whether we "own" the buffer - i.e., we know we created it, - * and can realloc() it to grow it, and should free() it to - * delete it. - */ - int yy_is_our_buffer; - - /* Whether this is an "interactive" input source; if so, and - * if we're using stdio for input, then we want to use getc() - * instead of fread(), to make sure we stop fetching input after - * each newline. - */ - int yy_is_interactive; - - /* Whether we're considered to be at the beginning of a line. - * If so, '^' rules will be active on the next match, otherwise - * not. - */ - int yy_at_bol; - - int yy_bs_lineno; /**< The line count. */ - int yy_bs_column; /**< The column count. */ - - /* Whether to try to fill the input buffer when we reach the - * end of it. - */ - int yy_fill_buffer; - - int yy_buffer_status; - -#define YY_BUFFER_NEW 0 -#define YY_BUFFER_NORMAL 1 - /* When an EOF's been seen but there's still some text to process - * then we mark the buffer as YY_EOF_PENDING, to indicate that we - * shouldn't try reading from the input source any more. We might - * still have a bunch of tokens to match, though, because of - * possible backing-up. - * - * When we actually see the EOF, we change the status to "new" - * (via yyrestart()), so that the user can continue scanning by - * just pointing yyin at a new input file. - */ -#define YY_BUFFER_EOF_PENDING 2 - - }; -#endif /* !YY_STRUCT_YY_BUFFER_STATE */ - -/* We provide macros for accessing buffer states in case in the - * future we want to put the buffer states in a more general - * "scanner state". - * - * Returns the top of the stack, or NULL. - */ -#define YY_CURRENT_BUFFER ( yyg->yy_buffer_stack \ - ? yyg->yy_buffer_stack[yyg->yy_buffer_stack_top] \ - : NULL) -/* Same as previous macro, but useful when we know that the buffer stack is not - * NULL or when we need an lvalue. For internal use only. - */ -#define YY_CURRENT_BUFFER_LVALUE yyg->yy_buffer_stack[yyg->yy_buffer_stack_top] - -void yyrestart ( FILE *input_file , yyscan_t yyscanner ); -void yy_switch_to_buffer ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_create_buffer ( FILE *file, int size , yyscan_t yyscanner ); -void yy_delete_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yy_flush_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yypush_buffer_state ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -void yypop_buffer_state ( yyscan_t yyscanner ); - -static void yyensure_buffer_stack ( yyscan_t yyscanner ); -static void yy_load_buffer_state ( yyscan_t yyscanner ); -static void yy_init_buffer ( YY_BUFFER_STATE b, FILE *file , yyscan_t yyscanner ); -#define YY_FLUSH_BUFFER yy_flush_buffer( YY_CURRENT_BUFFER , yyscanner) - -YY_BUFFER_STATE yy_scan_buffer ( char *base, yy_size_t size , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_string ( const char *yy_str , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_bytes ( const char *bytes, int len , yyscan_t yyscanner ); - -void *yyalloc ( yy_size_t , yyscan_t yyscanner ); -void *yyrealloc ( void *, yy_size_t , yyscan_t yyscanner ); -void yyfree ( void * , yyscan_t yyscanner ); - -#define yy_new_buffer yy_create_buffer -#define yy_set_interactive(is_interactive) \ - { \ - if ( ! YY_CURRENT_BUFFER ){ \ - yyensure_buffer_stack (yyscanner); \ - YY_CURRENT_BUFFER_LVALUE = \ - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); \ - } \ - YY_CURRENT_BUFFER_LVALUE->yy_is_interactive = is_interactive; \ - } -#define yy_set_bol(at_bol) \ - { \ - if ( ! YY_CURRENT_BUFFER ){\ - yyensure_buffer_stack (yyscanner); \ - YY_CURRENT_BUFFER_LVALUE = \ - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); \ - } \ - YY_CURRENT_BUFFER_LVALUE->yy_at_bol = at_bol; \ - } -#define YY_AT_BOL() (YY_CURRENT_BUFFER_LVALUE->yy_at_bol) - -#define xlu__cfg_yywrap(yyscanner) (/*CONSTCOND*/1) -#define YY_SKIP_YYWRAP -typedef flex_uint8_t YY_CHAR; - -typedef int yy_state_type; - -#define yytext_ptr yytext_r - -static yy_state_type yy_get_previous_state ( yyscan_t yyscanner ); -static yy_state_type yy_try_NUL_trans ( yy_state_type current_state , yyscan_t yyscanner); -static int yy_get_next_buffer ( yyscan_t yyscanner ); -static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner ); - -/* Done after the current pattern has been matched and before the - * corresponding action - sets up yytext. - */ -#define YY_DO_BEFORE_ACTION \ - yyg->yytext_ptr = yy_bp; \ - yyg->yytext_ptr -= yyg->yy_more_len; \ - yyleng = (int) (yy_cp - yyg->yytext_ptr); \ - yyg->yy_hold_char = *yy_cp; \ - *yy_cp = '\0'; \ - yyg->yy_c_buf_p = yy_cp; -#define YY_NUM_RULES 17 -#define YY_END_OF_BUFFER 18 -/* This struct is not used in this scanner, - but its presence is necessary. */ -struct yy_trans_info - { - flex_int32_t yy_verify; - flex_int32_t yy_nxt; - }; -static const flex_int16_t yy_accept[37] = - { 0, - 0, 0, 15, 15, 18, 14, 3, 10, 14, 14, - 14, 13, 13, 4, 2, 9, 8, 5, 6, 1, - 15, 15, 16, 0, 12, 0, 0, 10, 0, 11, - 0, 7, 2, 1, 15, 0 - } ; - -static const YY_CHAR yy_ec[256] = - { 0, - 1, 1, 1, 1, 1, 1, 1, 1, 2, 3, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 2, 1, 4, 5, 1, 1, 1, 6, 7, - 7, 1, 8, 9, 7, 10, 1, 11, 11, 11, - 11, 11, 11, 11, 11, 11, 11, 7, 12, 1, - 13, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 14, 15, 16, 1, 17, 1, 18, 18, 18, 18, - - 18, 18, 19, 19, 19, 19, 19, 19, 19, 19, - 19, 19, 19, 19, 19, 19, 19, 19, 19, 18, - 19, 19, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1 - } ; - -static const YY_CHAR yy_meta[20] = - { 0, - 1, 2, 3, 1, 1, 1, 1, 1, 1, 4, - 4, 1, 1, 1, 1, 1, 4, 4, 4 - } ; - -static const flex_int16_t yy_base[43] = - { 0, - 0, 0, 18, 20, 53, 59, 59, 59, 20, 42, - 19, 59, 19, 59, 15, 59, 59, 59, 59, 0, - 0, 59, 59, 23, 59, 0, 28, 59, 22, 59, - 0, 59, 18, 0, 0, 59, 38, 42, 46, 50, - 26, 54 - } ; - -static const flex_int16_t yy_def[43] = - { 0, - 36, 1, 37, 37, 36, 36, 36, 36, 38, 39, - 40, 36, 36, 36, 36, 36, 36, 36, 36, 41, - 42, 36, 36, 38, 36, 38, 39, 36, 40, 36, - 40, 36, 36, 41, 42, 0, 36, 36, 36, 36, - 36, 36 - } ; - -static const flex_int16_t yy_nxt[79] = - { 0, - 6, 7, 8, 9, 10, 11, 12, 13, 14, 12, - 15, 16, 17, 18, 6, 19, 6, 20, 20, 22, - 23, 22, 23, 25, 30, 33, 25, 30, 33, 34, - 28, 32, 33, 31, 26, 33, 31, 26, 21, 21, - 21, 21, 24, 24, 28, 24, 27, 27, 27, 27, - 29, 29, 36, 29, 35, 36, 36, 35, 5, 36, - 36, 36, 36, 36, 36, 36, 36, 36, 36, 36, - 36, 36, 36, 36, 36, 36, 36, 36 - } ; - -static const flex_int16_t yy_chk[79] = - { 0, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 3, - 3, 4, 4, 9, 11, 15, 24, 29, 33, 41, - 27, 13, 15, 11, 9, 33, 29, 24, 37, 37, - 37, 37, 38, 38, 10, 38, 39, 39, 39, 39, - 40, 40, 5, 40, 42, 0, 0, 42, 36, 36, - 36, 36, 36, 36, 36, 36, 36, 36, 36, 36, - 36, 36, 36, 36, 36, 36, 36, 36 - } ; - -/* Table of booleans, true if rule could match eol. */ -static const flex_int32_t yy_rule_can_match_eol[18] = - { 0, -0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, }; - -/* The intent behind this definition is that it'll catch - * any uses of REJECT which flex missed. - */ -#define REJECT reject_used_but_not_detected -#define yymore() (yyg->yy_more_flag = 1) -#define YY_MORE_ADJ yyg->yy_more_len -#define YY_RESTORE_YY_MORE_OFFSET -#line 1 "libxlu_cfg_l.l" -/* -*- fundamental -*- */ -/* - * libxlu_cfg_l.l - xl configuration file parsing: lexer - * - * Copyright (C) 2010 Citrix Ltd. - * Author Ian Jackson - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - */ -#line 20 "libxlu_cfg_l.l" -#include "libxlu_cfg_i.h" - -#define ctx ((CfgParseContext*)yyextra) -#define YY_NO_INPUT - -#define GOT(x) do{ \ - yylloc->first_line= yylineno; \ - return (x); \ - }while(0) - -/* Some versions of flex have a bug (Fedora bugzilla 612465) which causes - * it to fail to declare these functions, which it defines. So declare - * them ourselves. Hopefully we won't have to simultaneously support - * a flex version which declares these differently somehow. */ -int xlu__cfg_yyget_column(yyscan_t yyscanner); -void xlu__cfg_yyset_column(int column_no, yyscan_t yyscanner); - -#line 740 "libxlu_cfg_l.c" - -#line 742 "libxlu_cfg_l.c" - -#define INITIAL 0 -#define lexerr 1 - -#ifndef YY_NO_UNISTD_H -/* Special case for "unistd.h", since it is non-ANSI. We include it way - * down here because we want the user's section 1 to have been scanned first. - * The user has a chance to override it with an option. - */ -#include -#endif - -#ifndef YY_EXTRA_TYPE -#define YY_EXTRA_TYPE void * -#endif - -/* Holds the entire state of the reentrant scanner. */ -struct yyguts_t - { - - /* User-defined. Not touched by flex. */ - YY_EXTRA_TYPE yyextra_r; - - /* The rest are the same as the globals declared in the non-reentrant scanner. */ - FILE *yyin_r, *yyout_r; - size_t yy_buffer_stack_top; /**< index of top of stack. */ - size_t yy_buffer_stack_max; /**< capacity of stack. */ - YY_BUFFER_STATE * yy_buffer_stack; /**< Stack as an array. */ - char yy_hold_char; - int yy_n_chars; - int yyleng_r; - char *yy_c_buf_p; - int yy_init; - int yy_start; - int yy_did_buffer_switch_on_eof; - int yy_start_stack_ptr; - int yy_start_stack_depth; - int *yy_start_stack; - yy_state_type yy_last_accepting_state; - char* yy_last_accepting_cpos; - - int yylineno_r; - int yy_flex_debug_r; - - char *yytext_r; - int yy_more_flag; - int yy_more_len; - - YYSTYPE * yylval_r; - - YYLTYPE * yylloc_r; - - }; /* end struct yyguts_t */ - -static int yy_init_globals ( yyscan_t yyscanner ); - - /* This must go here because YYSTYPE and YYLTYPE are included - * from bison output in section 1.*/ - # define yylval yyg->yylval_r - - # define yylloc yyg->yylloc_r - -int yylex_init (yyscan_t* scanner); - -int yylex_init_extra ( YY_EXTRA_TYPE user_defined, yyscan_t* scanner); - -/* Accessor methods to globals. - These are made visible to non-reentrant scanners for convenience. */ - -int yylex_destroy ( yyscan_t yyscanner ); - -int yyget_debug ( yyscan_t yyscanner ); - -void yyset_debug ( int debug_flag , yyscan_t yyscanner ); - -YY_EXTRA_TYPE yyget_extra ( yyscan_t yyscanner ); - -void yyset_extra ( YY_EXTRA_TYPE user_defined , yyscan_t yyscanner ); - -FILE *yyget_in ( yyscan_t yyscanner ); - -void yyset_in ( FILE * _in_str , yyscan_t yyscanner ); - -FILE *yyget_out ( yyscan_t yyscanner ); - -void yyset_out ( FILE * _out_str , yyscan_t yyscanner ); - - int yyget_leng ( yyscan_t yyscanner ); - -char *yyget_text ( yyscan_t yyscanner ); - -int yyget_lineno ( yyscan_t yyscanner ); - -void yyset_lineno ( int _line_number , yyscan_t yyscanner ); - -int yyget_column ( yyscan_t yyscanner ); - -void yyset_column ( int _column_no , yyscan_t yyscanner ); - -YYSTYPE * yyget_lval ( yyscan_t yyscanner ); - -void yyset_lval ( YYSTYPE * yylval_param , yyscan_t yyscanner ); - - YYLTYPE *yyget_lloc ( yyscan_t yyscanner ); - - void yyset_lloc ( YYLTYPE * yylloc_param , yyscan_t yyscanner ); - -/* Macros after this point can all be overridden by user definitions in - * section 1. - */ - -#ifndef YY_SKIP_YYWRAP -#ifdef __cplusplus -extern "C" int yywrap ( yyscan_t yyscanner ); -#else -extern int yywrap ( yyscan_t yyscanner ); -#endif -#endif - -#ifndef YY_NO_UNPUT - -#endif - -#ifndef yytext_ptr -static void yy_flex_strncpy ( char *, const char *, int , yyscan_t yyscanner); -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen ( const char * , yyscan_t yyscanner); -#endif - -#ifndef YY_NO_INPUT -#ifdef __cplusplus -static int yyinput ( yyscan_t yyscanner ); -#else -static int input ( yyscan_t yyscanner ); -#endif - -#endif - -/* Amount of stuff to slurp up with each read. */ -#ifndef YY_READ_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k */ -#define YY_READ_BUF_SIZE 16384 -#else -#define YY_READ_BUF_SIZE 8192 -#endif /* __ia64__ */ -#endif - -/* Copy whatever the last rule matched to the standard output. */ -#ifndef ECHO -/* This used to be an fputs(), but since the string might contain NUL's, - * we now use fwrite(). - */ -#define ECHO do { if (fwrite( yytext, (size_t) yyleng, 1, yyout )) {} } while (0) -#endif - -/* Gets input and stuffs it into "buf". number of characters read, or YY_NULL, - * is returned in "result". - */ -#ifndef YY_INPUT -#define YY_INPUT(buf,result,max_size) \ - if ( YY_CURRENT_BUFFER_LVALUE->yy_is_interactive ) \ - { \ - int c = '*'; \ - int n; \ - for ( n = 0; n < max_size && \ - (c = getc( yyin )) != EOF && c != '\n'; ++n ) \ - buf[n] = (char) c; \ - if ( c == '\n' ) \ - buf[n++] = (char) c; \ - if ( c == EOF && ferror( yyin ) ) \ - YY_FATAL_ERROR( "input in flex scanner failed" ); \ - result = n; \ - } \ - else \ - { \ - errno=0; \ - while ( (result = (int) fread(buf, 1, (yy_size_t) max_size, yyin)) == 0 && ferror(yyin)) \ - { \ - if( errno != EINTR) \ - { \ - YY_FATAL_ERROR( "input in flex scanner failed" ); \ - break; \ - } \ - errno=0; \ - clearerr(yyin); \ - } \ - }\ -\ - -#endif - -/* No semi-colon after return; correct usage is to write "yyterminate();" - - * we don't want an extra ';' after the "return" because that will cause - * some compilers to complain about unreachable statements. - */ -#ifndef yyterminate -#define yyterminate() return YY_NULL -#endif - -/* Number of entries by which start-condition stack grows. */ -#ifndef YY_START_STACK_INCR -#define YY_START_STACK_INCR 25 -#endif - -/* Report a fatal error. */ -#ifndef YY_FATAL_ERROR -#define YY_FATAL_ERROR(msg) yy_fatal_error( msg , yyscanner) -#endif - -/* end tables serialization structures and prototypes */ - -/* Default declaration of generated scanner - a define so the user can - * easily add parameters. - */ -#ifndef YY_DECL -#define YY_DECL_IS_OURS 1 - -extern int yylex \ - (YYSTYPE * yylval_param, YYLTYPE * yylloc_param , yyscan_t yyscanner); - -#define YY_DECL int yylex \ - (YYSTYPE * yylval_param, YYLTYPE * yylloc_param , yyscan_t yyscanner) -#endif /* !YY_DECL */ - -/* Code executed at the beginning of each rule, after yytext and yyleng - * have been set up. - */ -#ifndef YY_USER_ACTION -#define YY_USER_ACTION -#endif - -/* Code executed at the end of each rule. */ -#ifndef YY_BREAK -#define YY_BREAK /*LINTED*/break; -#endif - -#define YY_RULE_SETUP \ - YY_USER_ACTION - -/** The main scanner function which does all the work. - */ -YY_DECL -{ - yy_state_type yy_current_state; - char *yy_cp, *yy_bp; - int yy_act; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - yylval = yylval_param; - - yylloc = yylloc_param; - - if ( !yyg->yy_init ) - { - yyg->yy_init = 1; - -#ifdef YY_USER_INIT - YY_USER_INIT; -#endif - - if ( ! yyg->yy_start ) - yyg->yy_start = 1; /* first start state */ - - if ( ! yyin ) - yyin = stdin; - - if ( ! yyout ) - yyout = stdout; - - if ( ! YY_CURRENT_BUFFER ) { - yyensure_buffer_stack (yyscanner); - YY_CURRENT_BUFFER_LVALUE = - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); - } - - yy_load_buffer_state( yyscanner ); - } - - { -#line 53 "libxlu_cfg_l.l" - - -#line 1028 "libxlu_cfg_l.c" - - while ( /*CONSTCOND*/1 ) /* loops until end-of-file is reached */ - { - yyg->yy_more_len = 0; - if ( yyg->yy_more_flag ) - { - yyg->yy_more_len = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr); - yyg->yy_more_flag = 0; - } - yy_cp = yyg->yy_c_buf_p; - - /* Support of yytext. */ - *yy_cp = yyg->yy_hold_char; - - /* yy_bp points to the position in yy_ch_buf of the start of - * the current run. - */ - yy_bp = yy_cp; - - yy_current_state = yyg->yy_start; -yy_match: - do - { - YY_CHAR yy_c = yy_ec[YY_SC_TO_UI(*yy_cp)] ; - if ( yy_accept[yy_current_state] ) - { - yyg->yy_last_accepting_state = yy_current_state; - yyg->yy_last_accepting_cpos = yy_cp; - } - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 37 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - ++yy_cp; - } - while ( yy_current_state != 36 ); - yy_cp = yyg->yy_last_accepting_cpos; - yy_current_state = yyg->yy_last_accepting_state; - -yy_find_action: - yy_act = yy_accept[yy_current_state]; - - YY_DO_BEFORE_ACTION; - - if ( yy_act != YY_END_OF_BUFFER && yy_rule_can_match_eol[yy_act] ) - { - int yyl; - for ( yyl = yyg->yy_more_len; yyl < yyleng; ++yyl ) - if ( yytext[yyl] == '\n' ) - - do{ yylineno++; - yycolumn=0; - }while(0) -; - } - -do_action: /* This label is used only to access EOF actions. */ - - switch ( yy_act ) - { /* beginning of action switch */ - case 0: /* must back up */ - /* undo the effects of YY_DO_BEFORE_ACTION */ - *yy_cp = yyg->yy_hold_char; - yy_cp = yyg->yy_last_accepting_cpos; - yy_current_state = yyg->yy_last_accepting_state; - goto yy_find_action; - -case 1: -YY_RULE_SETUP -#line 55 "libxlu_cfg_l.l" -{ - yylval->string= xlu__cfgl_strdup(ctx,yytext); - GOT(IDENT); - } - YY_BREAK -case 2: -YY_RULE_SETUP -#line 59 "libxlu_cfg_l.l" -{ - yylval->string= xlu__cfgl_strdup(ctx,yytext); - GOT(NUMBER); - } - YY_BREAK -case 3: -YY_RULE_SETUP -#line 64 "libxlu_cfg_l.l" - - YY_BREAK -case 4: -YY_RULE_SETUP -#line 66 "libxlu_cfg_l.l" -{ GOT(','); } - YY_BREAK -case 5: -YY_RULE_SETUP -#line 67 "libxlu_cfg_l.l" -{ GOT('['); } - YY_BREAK -case 6: -YY_RULE_SETUP -#line 68 "libxlu_cfg_l.l" -{ GOT(']'); } - YY_BREAK -case 7: -YY_RULE_SETUP -#line 69 "libxlu_cfg_l.l" -{ GOT(OP_ADD); } - YY_BREAK -case 8: -YY_RULE_SETUP -#line 70 "libxlu_cfg_l.l" -{ GOT('='); } - YY_BREAK -case 9: -YY_RULE_SETUP -#line 71 "libxlu_cfg_l.l" -{ GOT(';'); } - YY_BREAK -case 10: -/* rule 10 can match eol */ -YY_RULE_SETUP -#line 73 "libxlu_cfg_l.l" -{ yylloc->first_line= yylineno-1; return NEWLINE; } - YY_BREAK -case 11: -YY_RULE_SETUP -#line 75 "libxlu_cfg_l.l" -{ - yylval->string= xlu__cfgl_dequote(ctx,yytext); - GOT(STRING); - } - YY_BREAK -case 12: -YY_RULE_SETUP -#line 79 "libxlu_cfg_l.l" -{ - yylval->string= xlu__cfgl_dequote(ctx,yytext); - GOT(STRING); - } - YY_BREAK -case 13: -YY_RULE_SETUP -#line 84 "libxlu_cfg_l.l" -{ - ctx->likely_python= 1; - BEGIN(lexerr); - yymore(); - } - YY_BREAK -case 14: -YY_RULE_SETUP -#line 90 "libxlu_cfg_l.l" -{ - BEGIN(lexerr); - yymore(); - } - YY_BREAK -case 15: -YY_RULE_SETUP -#line 95 "libxlu_cfg_l.l" -{ - xlu__cfgl_lexicalerror(ctx,"lexical error"); - BEGIN(0); - } - YY_BREAK -case 16: -/* rule 16 can match eol */ -YY_RULE_SETUP -#line 100 "libxlu_cfg_l.l" -{ - xlu__cfgl_lexicalerror(ctx,"lexical error"); - BEGIN(0); - GOT(NEWLINE); - } - YY_BREAK -case 17: -YY_RULE_SETUP -#line 105 "libxlu_cfg_l.l" -YY_FATAL_ERROR( "flex scanner jammed" ); - YY_BREAK -#line 1212 "libxlu_cfg_l.c" -case YY_STATE_EOF(INITIAL): -case YY_STATE_EOF(lexerr): - yyterminate(); - - case YY_END_OF_BUFFER: - { - /* Amount of text matched not including the EOB char. */ - int yy_amount_of_matched_text = (int) (yy_cp - yyg->yytext_ptr) - 1; - - /* Undo the effects of YY_DO_BEFORE_ACTION. */ - *yy_cp = yyg->yy_hold_char; - YY_RESTORE_YY_MORE_OFFSET - - if ( YY_CURRENT_BUFFER_LVALUE->yy_buffer_status == YY_BUFFER_NEW ) - { - /* We're scanning a new file or input source. It's - * possible that this happened because the user - * just pointed yyin at a new source and called - * yylex(). If so, then we have to assure - * consistency between YY_CURRENT_BUFFER and our - * globals. Here is the right place to do so, because - * this is the first action (other than possibly a - * back-up) that will match for the new input source. - */ - yyg->yy_n_chars = YY_CURRENT_BUFFER_LVALUE->yy_n_chars; - YY_CURRENT_BUFFER_LVALUE->yy_input_file = yyin; - YY_CURRENT_BUFFER_LVALUE->yy_buffer_status = YY_BUFFER_NORMAL; - } - - /* Note that here we test for yy_c_buf_p "<=" to the position - * of the first EOB in the buffer, since yy_c_buf_p will - * already have been incremented past the NUL character - * (since all states make transitions on EOB to the - * end-of-buffer state). Contrast this with the test - * in input(). - */ - if ( yyg->yy_c_buf_p <= &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] ) - { /* This was really a NUL. */ - yy_state_type yy_next_state; - - yyg->yy_c_buf_p = yyg->yytext_ptr + yy_amount_of_matched_text; - - yy_current_state = yy_get_previous_state( yyscanner ); - - /* Okay, we're now positioned to make the NUL - * transition. We couldn't have - * yy_get_previous_state() go ahead and do it - * for us because it doesn't know how to deal - * with the possibility of jamming (and we don't - * want to build jamming into it because then it - * will run more slowly). - */ - - yy_next_state = yy_try_NUL_trans( yy_current_state , yyscanner); - - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - - if ( yy_next_state ) - { - /* Consume the NUL. */ - yy_cp = ++yyg->yy_c_buf_p; - yy_current_state = yy_next_state; - goto yy_match; - } - - else - { - yy_cp = yyg->yy_last_accepting_cpos; - yy_current_state = yyg->yy_last_accepting_state; - goto yy_find_action; - } - } - - else switch ( yy_get_next_buffer( yyscanner ) ) - { - case EOB_ACT_END_OF_FILE: - { - yyg->yy_did_buffer_switch_on_eof = 0; - - if ( yywrap( yyscanner ) ) - { - /* Note: because we've taken care in - * yy_get_next_buffer() to have set up - * yytext, we can now set up - * yy_c_buf_p so that if some total - * hoser (like flex itself) wants to - * call the scanner after we return the - * YY_NULL, it'll still work - another - * YY_NULL will get returned. - */ - yyg->yy_c_buf_p = yyg->yytext_ptr + YY_MORE_ADJ; - - yy_act = YY_STATE_EOF(YY_START); - goto do_action; - } - - else - { - if ( ! yyg->yy_did_buffer_switch_on_eof ) - YY_NEW_FILE; - } - break; - } - - case EOB_ACT_CONTINUE_SCAN: - yyg->yy_c_buf_p = - yyg->yytext_ptr + yy_amount_of_matched_text; - - yy_current_state = yy_get_previous_state( yyscanner ); - - yy_cp = yyg->yy_c_buf_p; - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - goto yy_match; - - case EOB_ACT_LAST_MATCH: - yyg->yy_c_buf_p = - &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars]; - - yy_current_state = yy_get_previous_state( yyscanner ); - - yy_cp = yyg->yy_c_buf_p; - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - goto yy_find_action; - } - break; - } - - default: - YY_FATAL_ERROR( - "fatal flex scanner internal error--no action found" ); - } /* end of action switch */ - } /* end of scanning one token */ - } /* end of user's declarations */ -} /* end of yylex */ - -/* yy_get_next_buffer - try to read in a new buffer - * - * Returns a code representing an action: - * EOB_ACT_LAST_MATCH - - * EOB_ACT_CONTINUE_SCAN - continue scanning from current position - * EOB_ACT_END_OF_FILE - end of file - */ -static int yy_get_next_buffer (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - char *dest = YY_CURRENT_BUFFER_LVALUE->yy_ch_buf; - char *source = yyg->yytext_ptr; - int number_to_move, i; - int ret_val; - - if ( yyg->yy_c_buf_p > &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars + 1] ) - YY_FATAL_ERROR( - "fatal flex scanner internal error--end of buffer missed" ); - - if ( YY_CURRENT_BUFFER_LVALUE->yy_fill_buffer == 0 ) - { /* Don't try to fill the buffer, so this is an EOF. */ - if ( yyg->yy_c_buf_p - yyg->yytext_ptr - YY_MORE_ADJ == 1 ) - { - /* We matched a single character, the EOB, so - * treat this as a final EOF. - */ - return EOB_ACT_END_OF_FILE; - } - - else - { - /* We matched some text prior to the EOB, first - * process it. - */ - return EOB_ACT_LAST_MATCH; - } - } - - /* Try to read more data. */ - - /* First move last chars to start of buffer. */ - number_to_move = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr - 1); - - for ( i = 0; i < number_to_move; ++i ) - *(dest++) = *(source++); - - if ( YY_CURRENT_BUFFER_LVALUE->yy_buffer_status == YY_BUFFER_EOF_PENDING ) - /* don't do the read, it's not guaranteed to return an EOF, - * just force an EOF - */ - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars = 0; - - else - { - int num_to_read = - YY_CURRENT_BUFFER_LVALUE->yy_buf_size - number_to_move - 1; - - while ( num_to_read <= 0 ) - { /* Not enough room in the buffer - grow it. */ - - /* just a shorter name for the current buffer */ - YY_BUFFER_STATE b = YY_CURRENT_BUFFER_LVALUE; - - int yy_c_buf_p_offset = - (int) (yyg->yy_c_buf_p - b->yy_ch_buf); - - if ( b->yy_is_our_buffer ) - { - int new_size = b->yy_buf_size * 2; - - if ( new_size <= 0 ) - b->yy_buf_size += b->yy_buf_size / 8; - else - b->yy_buf_size *= 2; - - b->yy_ch_buf = (char *) - /* Include room in for 2 EOB chars. */ - yyrealloc( (void *) b->yy_ch_buf, - (yy_size_t) (b->yy_buf_size + 2) , yyscanner ); - } - else - /* Can't grow it, we don't own it. */ - b->yy_ch_buf = NULL; - - if ( ! b->yy_ch_buf ) - YY_FATAL_ERROR( - "fatal error - scanner input buffer overflow" ); - - yyg->yy_c_buf_p = &b->yy_ch_buf[yy_c_buf_p_offset]; - - num_to_read = YY_CURRENT_BUFFER_LVALUE->yy_buf_size - - number_to_move - 1; - - } - - if ( num_to_read > YY_READ_BUF_SIZE ) - num_to_read = YY_READ_BUF_SIZE; - - /* Read in more data. */ - YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), - yyg->yy_n_chars, num_to_read ); - - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - if ( yyg->yy_n_chars == 0 ) - { - if ( number_to_move == YY_MORE_ADJ ) - { - ret_val = EOB_ACT_END_OF_FILE; - yyrestart( yyin , yyscanner); - } - - else - { - ret_val = EOB_ACT_LAST_MATCH; - YY_CURRENT_BUFFER_LVALUE->yy_buffer_status = - YY_BUFFER_EOF_PENDING; - } - } - - else - ret_val = EOB_ACT_CONTINUE_SCAN; - - if ((yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) { - /* Extend the array by 50%, plus the number we really need. */ - int new_size = yyg->yy_n_chars + number_to_move + (yyg->yy_n_chars >> 1); - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf = (char *) yyrealloc( - (void *) YY_CURRENT_BUFFER_LVALUE->yy_ch_buf, (yy_size_t) new_size , yyscanner ); - if ( ! YY_CURRENT_BUFFER_LVALUE->yy_ch_buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_get_next_buffer()" ); - /* "- 2" to take care of EOB's */ - YY_CURRENT_BUFFER_LVALUE->yy_buf_size = (int) (new_size - 2); - } - - yyg->yy_n_chars += number_to_move; - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] = YY_END_OF_BUFFER_CHAR; - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars + 1] = YY_END_OF_BUFFER_CHAR; - - yyg->yytext_ptr = &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[0]; - - return ret_val; -} - -/* yy_get_previous_state - get the state just before the EOB char was reached */ - - static yy_state_type yy_get_previous_state (yyscan_t yyscanner) -{ - yy_state_type yy_current_state; - char *yy_cp; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - yy_current_state = yyg->yy_start; - - for ( yy_cp = yyg->yytext_ptr + YY_MORE_ADJ; yy_cp < yyg->yy_c_buf_p; ++yy_cp ) - { - YY_CHAR yy_c = (*yy_cp ? yy_ec[YY_SC_TO_UI(*yy_cp)] : 1); - if ( yy_accept[yy_current_state] ) - { - yyg->yy_last_accepting_state = yy_current_state; - yyg->yy_last_accepting_cpos = yy_cp; - } - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 37 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - } - - return yy_current_state; -} - -/* yy_try_NUL_trans - try to make a transition on the NUL character - * - * synopsis - * next_state = yy_try_NUL_trans( current_state ); - */ - static yy_state_type yy_try_NUL_trans (yy_state_type yy_current_state , yyscan_t yyscanner) -{ - int yy_is_jam; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; /* This var may be unused depending upon options. */ - char *yy_cp = yyg->yy_c_buf_p; - - YY_CHAR yy_c = 1; - if ( yy_accept[yy_current_state] ) - { - yyg->yy_last_accepting_state = yy_current_state; - yyg->yy_last_accepting_cpos = yy_cp; - } - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 37 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - yy_is_jam = (yy_current_state == 36); - - (void)yyg; - return yy_is_jam ? 0 : yy_current_state; -} - -#ifndef YY_NO_UNPUT - -#endif - -#ifndef YY_NO_INPUT -#ifdef __cplusplus - static int yyinput (yyscan_t yyscanner) -#else - static int input (yyscan_t yyscanner) -#endif - -{ - int c; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - *yyg->yy_c_buf_p = yyg->yy_hold_char; - - if ( *yyg->yy_c_buf_p == YY_END_OF_BUFFER_CHAR ) - { - /* yy_c_buf_p now points to the character we want to return. - * If this occurs *before* the EOB characters, then it's a - * valid NUL; if not, then we've hit the end of the buffer. - */ - if ( yyg->yy_c_buf_p < &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] ) - /* This was really a NUL. */ - *yyg->yy_c_buf_p = '\0'; - - else - { /* need more input */ - int offset = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr); - ++yyg->yy_c_buf_p; - - switch ( yy_get_next_buffer( yyscanner ) ) - { - case EOB_ACT_LAST_MATCH: - /* This happens because yy_g_n_b() - * sees that we've accumulated a - * token and flags that we need to - * try matching the token before - * proceeding. But for input(), - * there's no matching to consider. - * So convert the EOB_ACT_LAST_MATCH - * to EOB_ACT_END_OF_FILE. - */ - - /* Reset buffer status. */ - yyrestart( yyin , yyscanner); - - /*FALLTHROUGH*/ - - case EOB_ACT_END_OF_FILE: - { - if ( yywrap( yyscanner ) ) - return 0; - - if ( ! yyg->yy_did_buffer_switch_on_eof ) - YY_NEW_FILE; -#ifdef __cplusplus - return yyinput(yyscanner); -#else - return input(yyscanner); -#endif - } - - case EOB_ACT_CONTINUE_SCAN: - yyg->yy_c_buf_p = yyg->yytext_ptr + offset; - break; - } - } - } - - c = *(unsigned char *) yyg->yy_c_buf_p; /* cast for 8-bit char's */ - *yyg->yy_c_buf_p = '\0'; /* preserve yytext */ - yyg->yy_hold_char = *++yyg->yy_c_buf_p; - - if ( c == '\n' ) - - do{ yylineno++; - yycolumn=0; - }while(0) -; - - return c; -} -#endif /* ifndef YY_NO_INPUT */ - -/** Immediately switch to a different input stream. - * @param input_file A readable stream. - * @param yyscanner The scanner object. - * @note This function does not reset the start condition to @c INITIAL . - */ - void yyrestart (FILE * input_file , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if ( ! YY_CURRENT_BUFFER ){ - yyensure_buffer_stack (yyscanner); - YY_CURRENT_BUFFER_LVALUE = - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); - } - - yy_init_buffer( YY_CURRENT_BUFFER, input_file , yyscanner); - yy_load_buffer_state( yyscanner ); -} - -/** Switch to a different input buffer. - * @param new_buffer The new input buffer. - * @param yyscanner The scanner object. - */ - void yy_switch_to_buffer (YY_BUFFER_STATE new_buffer , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* TODO. We should be able to replace this entire function body - * with - * yypop_buffer_state(); - * yypush_buffer_state(new_buffer); - */ - yyensure_buffer_stack (yyscanner); - if ( YY_CURRENT_BUFFER == new_buffer ) - return; - - if ( YY_CURRENT_BUFFER ) - { - /* Flush out information for old buffer. */ - *yyg->yy_c_buf_p = yyg->yy_hold_char; - YY_CURRENT_BUFFER_LVALUE->yy_buf_pos = yyg->yy_c_buf_p; - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - YY_CURRENT_BUFFER_LVALUE = new_buffer; - yy_load_buffer_state( yyscanner ); - - /* We don't actually know whether we did this switch during - * EOF (yywrap()) processing, but the only time this flag - * is looked at is after yywrap() is called, so it's safe - * to go ahead and always set it. - */ - yyg->yy_did_buffer_switch_on_eof = 1; -} - -static void yy_load_buffer_state (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyg->yy_n_chars = YY_CURRENT_BUFFER_LVALUE->yy_n_chars; - yyg->yytext_ptr = yyg->yy_c_buf_p = YY_CURRENT_BUFFER_LVALUE->yy_buf_pos; - yyin = YY_CURRENT_BUFFER_LVALUE->yy_input_file; - yyg->yy_hold_char = *yyg->yy_c_buf_p; -} - -/** Allocate and initialize an input buffer state. - * @param file A readable stream. - * @param size The character buffer size in bytes. When in doubt, use @c YY_BUF_SIZE. - * @param yyscanner The scanner object. - * @return the allocated buffer state. - */ - YY_BUFFER_STATE yy_create_buffer (FILE * file, int size , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - - b = (YY_BUFFER_STATE) yyalloc( sizeof( struct yy_buffer_state ) , yyscanner ); - if ( ! b ) - YY_FATAL_ERROR( "out of dynamic memory in yy_create_buffer()" ); - - b->yy_buf_size = size; - - /* yy_ch_buf has to be 2 characters longer than the size given because - * we need to put in 2 end-of-buffer characters. - */ - b->yy_ch_buf = (char *) yyalloc( (yy_size_t) (b->yy_buf_size + 2) , yyscanner ); - if ( ! b->yy_ch_buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_create_buffer()" ); - - b->yy_is_our_buffer = 1; - - yy_init_buffer( b, file , yyscanner); - - return b; -} - -/** Destroy the buffer. - * @param b a buffer created with yy_create_buffer() - * @param yyscanner The scanner object. - */ - void yy_delete_buffer (YY_BUFFER_STATE b , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if ( ! b ) - return; - - if ( b == YY_CURRENT_BUFFER ) /* Not sure if we should pop here. */ - YY_CURRENT_BUFFER_LVALUE = (YY_BUFFER_STATE) 0; - - if ( b->yy_is_our_buffer ) - yyfree( (void *) b->yy_ch_buf , yyscanner ); - - yyfree( (void *) b , yyscanner ); -} - -/* Initializes or reinitializes a buffer. - * This function is sometimes called more than once on the same buffer, - * such as during a yyrestart() or at EOF. - */ - static void yy_init_buffer (YY_BUFFER_STATE b, FILE * file , yyscan_t yyscanner) - -{ - int oerrno = errno; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - yy_flush_buffer( b , yyscanner); - - b->yy_input_file = file; - b->yy_fill_buffer = 1; - - /* If b is the current buffer, then yy_init_buffer was _probably_ - * called from yyrestart() or through yy_get_next_buffer. - * In that case, we don't want to reset the lineno or column. - */ - if (b != YY_CURRENT_BUFFER){ - b->yy_bs_lineno = 1; - b->yy_bs_column = 0; - } - - b->yy_is_interactive = file ? (isatty( fileno(file) ) > 0) : 0; - - errno = oerrno; -} - -/** Discard all buffered characters. On the next scan, YY_INPUT will be called. - * @param b the buffer state to be flushed, usually @c YY_CURRENT_BUFFER. - * @param yyscanner The scanner object. - */ - void yy_flush_buffer (YY_BUFFER_STATE b , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if ( ! b ) - return; - - b->yy_n_chars = 0; - - /* We always need two end-of-buffer characters. The first causes - * a transition to the end-of-buffer state. The second causes - * a jam in that state. - */ - b->yy_ch_buf[0] = YY_END_OF_BUFFER_CHAR; - b->yy_ch_buf[1] = YY_END_OF_BUFFER_CHAR; - - b->yy_buf_pos = &b->yy_ch_buf[0]; - - b->yy_at_bol = 1; - b->yy_buffer_status = YY_BUFFER_NEW; - - if ( b == YY_CURRENT_BUFFER ) - yy_load_buffer_state( yyscanner ); -} - -/** Pushes the new state onto the stack. The new state becomes - * the current state. This function will allocate the stack - * if necessary. - * @param new_buffer The new state. - * @param yyscanner The scanner object. - */ -void yypush_buffer_state (YY_BUFFER_STATE new_buffer , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if (new_buffer == NULL) - return; - - yyensure_buffer_stack(yyscanner); - - /* This block is copied from yy_switch_to_buffer. */ - if ( YY_CURRENT_BUFFER ) - { - /* Flush out information for old buffer. */ - *yyg->yy_c_buf_p = yyg->yy_hold_char; - YY_CURRENT_BUFFER_LVALUE->yy_buf_pos = yyg->yy_c_buf_p; - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - /* Only push if top exists. Otherwise, replace top. */ - if (YY_CURRENT_BUFFER) - yyg->yy_buffer_stack_top++; - YY_CURRENT_BUFFER_LVALUE = new_buffer; - - /* copied from yy_switch_to_buffer. */ - yy_load_buffer_state( yyscanner ); - yyg->yy_did_buffer_switch_on_eof = 1; -} - -/** Removes and deletes the top of the stack, if present. - * The next element becomes the new top. - * @param yyscanner The scanner object. - */ -void yypop_buffer_state (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if (!YY_CURRENT_BUFFER) - return; - - yy_delete_buffer(YY_CURRENT_BUFFER , yyscanner); - YY_CURRENT_BUFFER_LVALUE = NULL; - if (yyg->yy_buffer_stack_top > 0) - --yyg->yy_buffer_stack_top; - - if (YY_CURRENT_BUFFER) { - yy_load_buffer_state( yyscanner ); - yyg->yy_did_buffer_switch_on_eof = 1; - } -} - -/* Allocates the stack if it does not exist. - * Guarantees space for at least one push. - */ -static void yyensure_buffer_stack (yyscan_t yyscanner) -{ - yy_size_t num_to_alloc; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (!yyg->yy_buffer_stack) { - - /* First allocation is just for 2 elements, since we don't know if this - * scanner will even need a stack. We use 2 instead of 1 to avoid an - * immediate realloc on the next call. - */ - num_to_alloc = 1; /* After all that talk, this was set to 1 anyways... */ - yyg->yy_buffer_stack = (struct yy_buffer_state**)yyalloc - (num_to_alloc * sizeof(struct yy_buffer_state*) - , yyscanner); - if ( ! yyg->yy_buffer_stack ) - YY_FATAL_ERROR( "out of dynamic memory in yyensure_buffer_stack()" ); - - memset(yyg->yy_buffer_stack, 0, num_to_alloc * sizeof(struct yy_buffer_state*)); - - yyg->yy_buffer_stack_max = num_to_alloc; - yyg->yy_buffer_stack_top = 0; - return; - } - - if (yyg->yy_buffer_stack_top >= (yyg->yy_buffer_stack_max) - 1){ - - /* Increase the buffer to prepare for a possible push. */ - yy_size_t grow_size = 8 /* arbitrary grow size */; - - num_to_alloc = yyg->yy_buffer_stack_max + grow_size; - yyg->yy_buffer_stack = (struct yy_buffer_state**)yyrealloc - (yyg->yy_buffer_stack, - num_to_alloc * sizeof(struct yy_buffer_state*) - , yyscanner); - if ( ! yyg->yy_buffer_stack ) - YY_FATAL_ERROR( "out of dynamic memory in yyensure_buffer_stack()" ); - - /* zero only the new slots.*/ - memset(yyg->yy_buffer_stack + yyg->yy_buffer_stack_max, 0, grow_size * sizeof(struct yy_buffer_state*)); - yyg->yy_buffer_stack_max = num_to_alloc; - } -} - -/** Setup the input buffer state to scan directly from a user-specified character buffer. - * @param base the character buffer - * @param size the size in bytes of the character buffer - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - */ -YY_BUFFER_STATE yy_scan_buffer (char * base, yy_size_t size , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - - if ( size < 2 || - base[size-2] != YY_END_OF_BUFFER_CHAR || - base[size-1] != YY_END_OF_BUFFER_CHAR ) - /* They forgot to leave room for the EOB's. */ - return NULL; - - b = (YY_BUFFER_STATE) yyalloc( sizeof( struct yy_buffer_state ) , yyscanner ); - if ( ! b ) - YY_FATAL_ERROR( "out of dynamic memory in yy_scan_buffer()" ); - - b->yy_buf_size = (int) (size - 2); /* "- 2" to take care of EOB's */ - b->yy_buf_pos = b->yy_ch_buf = base; - b->yy_is_our_buffer = 0; - b->yy_input_file = NULL; - b->yy_n_chars = b->yy_buf_size; - b->yy_is_interactive = 0; - b->yy_at_bol = 1; - b->yy_fill_buffer = 0; - b->yy_buffer_status = YY_BUFFER_NEW; - - yy_switch_to_buffer( b , yyscanner ); - - return b; -} - -/** Setup the input buffer state to scan a string. The next call to yylex() will - * scan from a @e copy of @a str. - * @param yystr a NUL-terminated string to scan - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - * @note If you want to scan bytes that may contain NUL values, then use - * yy_scan_bytes() instead. - */ -YY_BUFFER_STATE yy_scan_string (const char * yystr , yyscan_t yyscanner) -{ - - return yy_scan_bytes( yystr, (int) strlen(yystr) , yyscanner); -} - -/** Setup the input buffer state to scan the given bytes. The next call to yylex() will - * scan from a @e copy of @a bytes. - * @param yybytes the byte buffer to scan - * @param _yybytes_len the number of bytes in the buffer pointed to by @a bytes. - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - */ -YY_BUFFER_STATE yy_scan_bytes (const char * yybytes, int _yybytes_len , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - char *buf; - yy_size_t n; - int i; - - /* Get memory for full buffer, including space for trailing EOB's. */ - n = (yy_size_t) (_yybytes_len + 2); - buf = (char *) yyalloc( n , yyscanner ); - if ( ! buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_scan_bytes()" ); - - for ( i = 0; i < _yybytes_len; ++i ) - buf[i] = yybytes[i]; - - buf[_yybytes_len] = buf[_yybytes_len+1] = YY_END_OF_BUFFER_CHAR; - - b = yy_scan_buffer( buf, n , yyscanner); - if ( ! b ) - YY_FATAL_ERROR( "bad buffer in yy_scan_bytes()" ); - - /* It's okay to grow etc. this buffer, and we should throw it - * away when we're done. - */ - b->yy_is_our_buffer = 1; - - return b; -} - -#ifndef YY_EXIT_FAILURE -#define YY_EXIT_FAILURE 2 -#endif - -static void yynoreturn yy_fatal_error (const char* msg , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - fprintf( stderr, "%s\n", msg ); - exit( YY_EXIT_FAILURE ); -} - -/* Redefine yyless() so it works in section 3 code. */ - -#undef yyless -#define yyless(n) \ - do \ - { \ - /* Undo effects of setting up yytext. */ \ - int yyless_macro_arg = (n); \ - YY_LESS_LINENO(yyless_macro_arg);\ - yytext[yyleng] = yyg->yy_hold_char; \ - yyg->yy_c_buf_p = yytext + yyless_macro_arg; \ - yyg->yy_hold_char = *yyg->yy_c_buf_p; \ - *yyg->yy_c_buf_p = '\0'; \ - yyleng = yyless_macro_arg; \ - } \ - while ( 0 ) - -/* Accessor methods (get/set functions) to struct members. */ - -/** Get the user-defined data for this scanner. - * @param yyscanner The scanner object. - */ -YY_EXTRA_TYPE yyget_extra (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyextra; -} - -/** Get the current line number. - * @param yyscanner The scanner object. - */ -int yyget_lineno (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (! YY_CURRENT_BUFFER) - return 0; - - return yylineno; -} - -/** Get the current column number. - * @param yyscanner The scanner object. - */ -int yyget_column (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (! YY_CURRENT_BUFFER) - return 0; - - return yycolumn; -} - -/** Get the input stream. - * @param yyscanner The scanner object. - */ -FILE *yyget_in (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyin; -} - -/** Get the output stream. - * @param yyscanner The scanner object. - */ -FILE *yyget_out (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyout; -} - -/** Get the length of the current token. - * @param yyscanner The scanner object. - */ -int yyget_leng (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyleng; -} - -/** Get the current token. - * @param yyscanner The scanner object. - */ - -char *yyget_text (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yytext; -} - -/** Set the user-defined data. This data is never touched by the scanner. - * @param user_defined The data to be associated with this scanner. - * @param yyscanner The scanner object. - */ -void yyset_extra (YY_EXTRA_TYPE user_defined , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyextra = user_defined ; -} - -/** Set the current line number. - * @param _line_number line number - * @param yyscanner The scanner object. - */ -void yyset_lineno (int _line_number , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* lineno is only valid if an input buffer exists. */ - if (! YY_CURRENT_BUFFER ) - YY_FATAL_ERROR( "yyset_lineno called with no buffer" ); - - yylineno = _line_number; -} - -/** Set the current column. - * @param _column_no column number - * @param yyscanner The scanner object. - */ -void yyset_column (int _column_no , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* column is only valid if an input buffer exists. */ - if (! YY_CURRENT_BUFFER ) - YY_FATAL_ERROR( "yyset_column called with no buffer" ); - - yycolumn = _column_no; -} - -/** Set the input stream. This does not discard the current - * input buffer. - * @param _in_str A readable stream. - * @param yyscanner The scanner object. - * @see yy_switch_to_buffer - */ -void yyset_in (FILE * _in_str , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyin = _in_str ; -} - -void yyset_out (FILE * _out_str , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyout = _out_str ; -} - -int yyget_debug (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yy_flex_debug; -} - -void yyset_debug (int _bdebug , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yy_flex_debug = _bdebug ; -} - -/* Accessor methods for yylval and yylloc */ - -YYSTYPE * yyget_lval (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yylval; -} - -void yyset_lval (YYSTYPE * yylval_param , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yylval = yylval_param; -} - -YYLTYPE *yyget_lloc (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yylloc; -} - -void yyset_lloc (YYLTYPE * yylloc_param , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yylloc = yylloc_param; -} - -/* User-visible API */ - -/* yylex_init is special because it creates the scanner itself, so it is - * the ONLY reentrant function that doesn't take the scanner as the last argument. - * That's why we explicitly handle the declaration, instead of using our macros. - */ -int yylex_init(yyscan_t* ptr_yy_globals) -{ - if (ptr_yy_globals == NULL){ - errno = EINVAL; - return 1; - } - - *ptr_yy_globals = (yyscan_t) yyalloc ( sizeof( struct yyguts_t ), NULL ); - - if (*ptr_yy_globals == NULL){ - errno = ENOMEM; - return 1; - } - - /* By setting to 0xAA, we expose bugs in yy_init_globals. Leave at 0x00 for releases. */ - memset(*ptr_yy_globals,0x00,sizeof(struct yyguts_t)); - - return yy_init_globals ( *ptr_yy_globals ); -} - -/* yylex_init_extra has the same functionality as yylex_init, but follows the - * convention of taking the scanner as the last argument. Note however, that - * this is a *pointer* to a scanner, as it will be allocated by this call (and - * is the reason, too, why this function also must handle its own declaration). - * The user defined value in the first argument will be available to yyalloc in - * the yyextra field. - */ -int yylex_init_extra( YY_EXTRA_TYPE yy_user_defined, yyscan_t* ptr_yy_globals ) -{ - struct yyguts_t dummy_yyguts; - - yyset_extra (yy_user_defined, &dummy_yyguts); - - if (ptr_yy_globals == NULL){ - errno = EINVAL; - return 1; - } - - *ptr_yy_globals = (yyscan_t) yyalloc ( sizeof( struct yyguts_t ), &dummy_yyguts ); - - if (*ptr_yy_globals == NULL){ - errno = ENOMEM; - return 1; - } - - /* By setting to 0xAA, we expose bugs in - yy_init_globals. Leave at 0x00 for releases. */ - memset(*ptr_yy_globals,0x00,sizeof(struct yyguts_t)); - - yyset_extra (yy_user_defined, *ptr_yy_globals); - - return yy_init_globals ( *ptr_yy_globals ); -} - -static int yy_init_globals (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - /* Initialization is the same as for the non-reentrant scanner. - * This function is called from yylex_destroy(), so don't allocate here. - */ - - yyg->yy_buffer_stack = NULL; - yyg->yy_buffer_stack_top = 0; - yyg->yy_buffer_stack_max = 0; - yyg->yy_c_buf_p = NULL; - yyg->yy_init = 0; - yyg->yy_start = 0; - - yyg->yy_start_stack_ptr = 0; - yyg->yy_start_stack_depth = 0; - yyg->yy_start_stack = NULL; - -/* Defined in main.c */ -#ifdef YY_STDINIT - yyin = stdin; - yyout = stdout; -#else - yyin = NULL; - yyout = NULL; -#endif - - /* For future reference: Set errno on error, since we are called by - * yylex_init() - */ - return 0; -} - -/* yylex_destroy is for both reentrant and non-reentrant scanners. */ -int yylex_destroy (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* Pop the buffer stack, destroying each element. */ - while(YY_CURRENT_BUFFER){ - yy_delete_buffer( YY_CURRENT_BUFFER , yyscanner ); - YY_CURRENT_BUFFER_LVALUE = NULL; - yypop_buffer_state(yyscanner); - } - - /* Destroy the stack itself. */ - yyfree(yyg->yy_buffer_stack , yyscanner); - yyg->yy_buffer_stack = NULL; - - /* Destroy the start condition stack. */ - yyfree( yyg->yy_start_stack , yyscanner ); - yyg->yy_start_stack = NULL; - - /* Reset the globals. This is important in a non-reentrant scanner so the next time - * yylex() is called, initialization will occur. */ - yy_init_globals( yyscanner); - - /* Destroy the main struct (reentrant only). */ - yyfree ( yyscanner , yyscanner ); - yyscanner = NULL; - return 0; -} - -/* - * Internal utility routines. - */ - -#ifndef yytext_ptr -static void yy_flex_strncpy (char* s1, const char * s2, int n , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - - int i; - for ( i = 0; i < n; ++i ) - s1[i] = s2[i]; -} -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen (const char * s , yyscan_t yyscanner) -{ - int n; - for ( n = 0; s[n]; ++n ) - ; - - return n; -} -#endif - -void *yyalloc (yy_size_t size , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - return malloc(size); -} - -void *yyrealloc (void * ptr, yy_size_t size , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - - /* The cast to (char *) in the following accommodates both - * implementations that use char* generic pointers, and those - * that use void* generic pointers. It works with the latter - * because both ANSI C and C++ allow castless assignment from - * any pointer type to void*, and deal with argument conversions - * as though doing an assignment. - */ - return realloc(ptr, size); -} - -void yyfree (void * ptr , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - free( (char *) ptr ); /* see yyrealloc() for (char *) cast */ -} - -#define YYTABLES_NAME "yytables" - -#line 105 "libxlu_cfg_l.l" diff --git a/tools/libs/util/libxlu_cfg_l.h b/tools/libs/util/libxlu_cfg_l.h deleted file mode 100644 index 213ba18b86..0000000000 --- a/tools/libs/util/libxlu_cfg_l.h +++ /dev/null @@ -1,734 +0,0 @@ -#ifndef xlu__cfg_yyHEADER_H -#define xlu__cfg_yyHEADER_H 1 -#define xlu__cfg_yyIN_HEADER 1 - -#line 6 "libxlu_cfg_l.h" - -#line 8 "libxlu_cfg_l.h" - -#define YY_INT_ALIGNED short int - -/* A lexical scanner generated by flex */ - -#define FLEX_SCANNER -#define YY_FLEX_MAJOR_VERSION 2 -#define YY_FLEX_MINOR_VERSION 6 -#define YY_FLEX_SUBMINOR_VERSION 4 -#if YY_FLEX_SUBMINOR_VERSION > 0 -#define FLEX_BETA -#endif - -#ifdef yy_create_buffer -#define xlu__cfg_yy_create_buffer_ALREADY_DEFINED -#else -#define yy_create_buffer xlu__cfg_yy_create_buffer -#endif - -#ifdef yy_delete_buffer -#define xlu__cfg_yy_delete_buffer_ALREADY_DEFINED -#else -#define yy_delete_buffer xlu__cfg_yy_delete_buffer -#endif - -#ifdef yy_scan_buffer -#define xlu__cfg_yy_scan_buffer_ALREADY_DEFINED -#else -#define yy_scan_buffer xlu__cfg_yy_scan_buffer -#endif - -#ifdef yy_scan_string -#define xlu__cfg_yy_scan_string_ALREADY_DEFINED -#else -#define yy_scan_string xlu__cfg_yy_scan_string -#endif - -#ifdef yy_scan_bytes -#define xlu__cfg_yy_scan_bytes_ALREADY_DEFINED -#else -#define yy_scan_bytes xlu__cfg_yy_scan_bytes -#endif - -#ifdef yy_init_buffer -#define xlu__cfg_yy_init_buffer_ALREADY_DEFINED -#else -#define yy_init_buffer xlu__cfg_yy_init_buffer -#endif - -#ifdef yy_flush_buffer -#define xlu__cfg_yy_flush_buffer_ALREADY_DEFINED -#else -#define yy_flush_buffer xlu__cfg_yy_flush_buffer -#endif - -#ifdef yy_load_buffer_state -#define xlu__cfg_yy_load_buffer_state_ALREADY_DEFINED -#else -#define yy_load_buffer_state xlu__cfg_yy_load_buffer_state -#endif - -#ifdef yy_switch_to_buffer -#define xlu__cfg_yy_switch_to_buffer_ALREADY_DEFINED -#else -#define yy_switch_to_buffer xlu__cfg_yy_switch_to_buffer -#endif - -#ifdef yypush_buffer_state -#define xlu__cfg_yypush_buffer_state_ALREADY_DEFINED -#else -#define yypush_buffer_state xlu__cfg_yypush_buffer_state -#endif - -#ifdef yypop_buffer_state -#define xlu__cfg_yypop_buffer_state_ALREADY_DEFINED -#else -#define yypop_buffer_state xlu__cfg_yypop_buffer_state -#endif - -#ifdef yyensure_buffer_stack -#define xlu__cfg_yyensure_buffer_stack_ALREADY_DEFINED -#else -#define yyensure_buffer_stack xlu__cfg_yyensure_buffer_stack -#endif - -#ifdef yylex -#define xlu__cfg_yylex_ALREADY_DEFINED -#else -#define yylex xlu__cfg_yylex -#endif - -#ifdef yyrestart -#define xlu__cfg_yyrestart_ALREADY_DEFINED -#else -#define yyrestart xlu__cfg_yyrestart -#endif - -#ifdef yylex_init -#define xlu__cfg_yylex_init_ALREADY_DEFINED -#else -#define yylex_init xlu__cfg_yylex_init -#endif - -#ifdef yylex_init_extra -#define xlu__cfg_yylex_init_extra_ALREADY_DEFINED -#else -#define yylex_init_extra xlu__cfg_yylex_init_extra -#endif - -#ifdef yylex_destroy -#define xlu__cfg_yylex_destroy_ALREADY_DEFINED -#else -#define yylex_destroy xlu__cfg_yylex_destroy -#endif - -#ifdef yyget_debug -#define xlu__cfg_yyget_debug_ALREADY_DEFINED -#else -#define yyget_debug xlu__cfg_yyget_debug -#endif - -#ifdef yyset_debug -#define xlu__cfg_yyset_debug_ALREADY_DEFINED -#else -#define yyset_debug xlu__cfg_yyset_debug -#endif - -#ifdef yyget_extra -#define xlu__cfg_yyget_extra_ALREADY_DEFINED -#else -#define yyget_extra xlu__cfg_yyget_extra -#endif - -#ifdef yyset_extra -#define xlu__cfg_yyset_extra_ALREADY_DEFINED -#else -#define yyset_extra xlu__cfg_yyset_extra -#endif - -#ifdef yyget_in -#define xlu__cfg_yyget_in_ALREADY_DEFINED -#else -#define yyget_in xlu__cfg_yyget_in -#endif - -#ifdef yyset_in -#define xlu__cfg_yyset_in_ALREADY_DEFINED -#else -#define yyset_in xlu__cfg_yyset_in -#endif - -#ifdef yyget_out -#define xlu__cfg_yyget_out_ALREADY_DEFINED -#else -#define yyget_out xlu__cfg_yyget_out -#endif - -#ifdef yyset_out -#define xlu__cfg_yyset_out_ALREADY_DEFINED -#else -#define yyset_out xlu__cfg_yyset_out -#endif - -#ifdef yyget_leng -#define xlu__cfg_yyget_leng_ALREADY_DEFINED -#else -#define yyget_leng xlu__cfg_yyget_leng -#endif - -#ifdef yyget_text -#define xlu__cfg_yyget_text_ALREADY_DEFINED -#else -#define yyget_text xlu__cfg_yyget_text -#endif - -#ifdef yyget_lineno -#define xlu__cfg_yyget_lineno_ALREADY_DEFINED -#else -#define yyget_lineno xlu__cfg_yyget_lineno -#endif - -#ifdef yyset_lineno -#define xlu__cfg_yyset_lineno_ALREADY_DEFINED -#else -#define yyset_lineno xlu__cfg_yyset_lineno -#endif - -#ifdef yyget_column -#define xlu__cfg_yyget_column_ALREADY_DEFINED -#else -#define yyget_column xlu__cfg_yyget_column -#endif - -#ifdef yyset_column -#define xlu__cfg_yyset_column_ALREADY_DEFINED -#else -#define yyset_column xlu__cfg_yyset_column -#endif - -#ifdef yywrap -#define xlu__cfg_yywrap_ALREADY_DEFINED -#else -#define yywrap xlu__cfg_yywrap -#endif - -#ifdef yyget_lval -#define xlu__cfg_yyget_lval_ALREADY_DEFINED -#else -#define yyget_lval xlu__cfg_yyget_lval -#endif - -#ifdef yyset_lval -#define xlu__cfg_yyset_lval_ALREADY_DEFINED -#else -#define yyset_lval xlu__cfg_yyset_lval -#endif - -#ifdef yyget_lloc -#define xlu__cfg_yyget_lloc_ALREADY_DEFINED -#else -#define yyget_lloc xlu__cfg_yyget_lloc -#endif - -#ifdef yyset_lloc -#define xlu__cfg_yyset_lloc_ALREADY_DEFINED -#else -#define yyset_lloc xlu__cfg_yyset_lloc -#endif - -#ifdef yyalloc -#define xlu__cfg_yyalloc_ALREADY_DEFINED -#else -#define yyalloc xlu__cfg_yyalloc -#endif - -#ifdef yyrealloc -#define xlu__cfg_yyrealloc_ALREADY_DEFINED -#else -#define yyrealloc xlu__cfg_yyrealloc -#endif - -#ifdef yyfree -#define xlu__cfg_yyfree_ALREADY_DEFINED -#else -#define yyfree xlu__cfg_yyfree -#endif - -/* First, we deal with platform-specific or compiler-specific issues. */ - -/* begin standard C headers. */ -#include -#include -#include -#include - -/* end standard C headers. */ - -/* flex integer type definitions */ - -#ifndef FLEXINT_H -#define FLEXINT_H - -/* C99 systems have . Non-C99 systems may or may not. */ - -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L - -/* C99 says to define __STDC_LIMIT_MACROS before including stdint.h, - * if you want the limit (max/min) macros for int types. - */ -#ifndef __STDC_LIMIT_MACROS -#define __STDC_LIMIT_MACROS 1 -#endif - -#include -typedef int8_t flex_int8_t; -typedef uint8_t flex_uint8_t; -typedef int16_t flex_int16_t; -typedef uint16_t flex_uint16_t; -typedef int32_t flex_int32_t; -typedef uint32_t flex_uint32_t; -#else -typedef signed char flex_int8_t; -typedef short int flex_int16_t; -typedef int flex_int32_t; -typedef unsigned char flex_uint8_t; -typedef unsigned short int flex_uint16_t; -typedef unsigned int flex_uint32_t; - -/* Limits of integral types. */ -#ifndef INT8_MIN -#define INT8_MIN (-128) -#endif -#ifndef INT16_MIN -#define INT16_MIN (-32767-1) -#endif -#ifndef INT32_MIN -#define INT32_MIN (-2147483647-1) -#endif -#ifndef INT8_MAX -#define INT8_MAX (127) -#endif -#ifndef INT16_MAX -#define INT16_MAX (32767) -#endif -#ifndef INT32_MAX -#define INT32_MAX (2147483647) -#endif -#ifndef UINT8_MAX -#define UINT8_MAX (255U) -#endif -#ifndef UINT16_MAX -#define UINT16_MAX (65535U) -#endif -#ifndef UINT32_MAX -#define UINT32_MAX (4294967295U) -#endif - -#ifndef SIZE_MAX -#define SIZE_MAX (~(size_t)0) -#endif - -#endif /* ! C99 */ - -#endif /* ! FLEXINT_H */ - -/* begin standard C++ headers. */ - -/* TODO: this is always defined, so inline it */ -#define yyconst const - -#if defined(__GNUC__) && __GNUC__ >= 3 -#define yynoreturn __attribute__((__noreturn__)) -#else -#define yynoreturn -#endif - -/* An opaque pointer. */ -#ifndef YY_TYPEDEF_YY_SCANNER_T -#define YY_TYPEDEF_YY_SCANNER_T -typedef void* yyscan_t; -#endif - -/* For convenience, these vars (plus the bison vars far below) - are macros in the reentrant scanner. */ -#define yyin yyg->yyin_r -#define yyout yyg->yyout_r -#define yyextra yyg->yyextra_r -#define yyleng yyg->yyleng_r -#define yytext yyg->yytext_r -#define yylineno (YY_CURRENT_BUFFER_LVALUE->yy_bs_lineno) -#define yycolumn (YY_CURRENT_BUFFER_LVALUE->yy_bs_column) -#define yy_flex_debug yyg->yy_flex_debug_r - -/* Size of default input buffer. */ -#ifndef YY_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k. - * Moreover, YY_BUF_SIZE is 2*YY_READ_BUF_SIZE in the general case. - * Ditto for the __ia64__ case accordingly. - */ -#define YY_BUF_SIZE 32768 -#else -#define YY_BUF_SIZE 16384 -#endif /* __ia64__ */ -#endif - -#ifndef YY_TYPEDEF_YY_BUFFER_STATE -#define YY_TYPEDEF_YY_BUFFER_STATE -typedef struct yy_buffer_state *YY_BUFFER_STATE; -#endif - -#ifndef YY_TYPEDEF_YY_SIZE_T -#define YY_TYPEDEF_YY_SIZE_T -typedef size_t yy_size_t; -#endif - -#ifndef YY_STRUCT_YY_BUFFER_STATE -#define YY_STRUCT_YY_BUFFER_STATE -struct yy_buffer_state - { - FILE *yy_input_file; - - char *yy_ch_buf; /* input buffer */ - char *yy_buf_pos; /* current position in input buffer */ - - /* Size of input buffer in bytes, not including room for EOB - * characters. - */ - int yy_buf_size; - - /* Number of characters read into yy_ch_buf, not including EOB - * characters. - */ - int yy_n_chars; - - /* Whether we "own" the buffer - i.e., we know we created it, - * and can realloc() it to grow it, and should free() it to - * delete it. - */ - int yy_is_our_buffer; - - /* Whether this is an "interactive" input source; if so, and - * if we're using stdio for input, then we want to use getc() - * instead of fread(), to make sure we stop fetching input after - * each newline. - */ - int yy_is_interactive; - - /* Whether we're considered to be at the beginning of a line. - * If so, '^' rules will be active on the next match, otherwise - * not. - */ - int yy_at_bol; - - int yy_bs_lineno; /**< The line count. */ - int yy_bs_column; /**< The column count. */ - - /* Whether to try to fill the input buffer when we reach the - * end of it. - */ - int yy_fill_buffer; - - int yy_buffer_status; - - }; -#endif /* !YY_STRUCT_YY_BUFFER_STATE */ - -void yyrestart ( FILE *input_file , yyscan_t yyscanner ); -void yy_switch_to_buffer ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_create_buffer ( FILE *file, int size , yyscan_t yyscanner ); -void yy_delete_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yy_flush_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yypush_buffer_state ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -void yypop_buffer_state ( yyscan_t yyscanner ); - -YY_BUFFER_STATE yy_scan_buffer ( char *base, yy_size_t size , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_string ( const char *yy_str , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_bytes ( const char *bytes, int len , yyscan_t yyscanner ); - -void *yyalloc ( yy_size_t , yyscan_t yyscanner ); -void *yyrealloc ( void *, yy_size_t , yyscan_t yyscanner ); -void yyfree ( void * , yyscan_t yyscanner ); - -#define xlu__cfg_yywrap(yyscanner) (/*CONSTCOND*/1) -#define YY_SKIP_YYWRAP - -#define yytext_ptr yytext_r - -#ifdef YY_HEADER_EXPORT_START_CONDITIONS -#define INITIAL 0 -#define lexerr 1 - -#endif - -#ifndef YY_NO_UNISTD_H -/* Special case for "unistd.h", since it is non-ANSI. We include it way - * down here because we want the user's section 1 to have been scanned first. - * The user has a chance to override it with an option. - */ -#include -#endif - -#ifndef YY_EXTRA_TYPE -#define YY_EXTRA_TYPE void * -#endif - -int yylex_init (yyscan_t* scanner); - -int yylex_init_extra ( YY_EXTRA_TYPE user_defined, yyscan_t* scanner); - -/* Accessor methods to globals. - These are made visible to non-reentrant scanners for convenience. */ - -int yylex_destroy ( yyscan_t yyscanner ); - -int yyget_debug ( yyscan_t yyscanner ); - -void yyset_debug ( int debug_flag , yyscan_t yyscanner ); - -YY_EXTRA_TYPE yyget_extra ( yyscan_t yyscanner ); - -void yyset_extra ( YY_EXTRA_TYPE user_defined , yyscan_t yyscanner ); - -FILE *yyget_in ( yyscan_t yyscanner ); - -void yyset_in ( FILE * _in_str , yyscan_t yyscanner ); - -FILE *yyget_out ( yyscan_t yyscanner ); - -void yyset_out ( FILE * _out_str , yyscan_t yyscanner ); - - int yyget_leng ( yyscan_t yyscanner ); - -char *yyget_text ( yyscan_t yyscanner ); - -int yyget_lineno ( yyscan_t yyscanner ); - -void yyset_lineno ( int _line_number , yyscan_t yyscanner ); - -int yyget_column ( yyscan_t yyscanner ); - -void yyset_column ( int _column_no , yyscan_t yyscanner ); - -YYSTYPE * yyget_lval ( yyscan_t yyscanner ); - -void yyset_lval ( YYSTYPE * yylval_param , yyscan_t yyscanner ); - - YYLTYPE *yyget_lloc ( yyscan_t yyscanner ); - - void yyset_lloc ( YYLTYPE * yylloc_param , yyscan_t yyscanner ); - -/* Macros after this point can all be overridden by user definitions in - * section 1. - */ - -#ifndef YY_SKIP_YYWRAP -#ifdef __cplusplus -extern "C" int yywrap ( yyscan_t yyscanner ); -#else -extern int yywrap ( yyscan_t yyscanner ); -#endif -#endif - -#ifndef yytext_ptr -static void yy_flex_strncpy ( char *, const char *, int , yyscan_t yyscanner); -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen ( const char * , yyscan_t yyscanner); -#endif - -#ifndef YY_NO_INPUT - -#endif - -/* Amount of stuff to slurp up with each read. */ -#ifndef YY_READ_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k */ -#define YY_READ_BUF_SIZE 16384 -#else -#define YY_READ_BUF_SIZE 8192 -#endif /* __ia64__ */ -#endif - -/* Number of entries by which start-condition stack grows. */ -#ifndef YY_START_STACK_INCR -#define YY_START_STACK_INCR 25 -#endif - -/* Default declaration of generated scanner - a define so the user can - * easily add parameters. - */ -#ifndef YY_DECL -#define YY_DECL_IS_OURS 1 - -extern int yylex \ - (YYSTYPE * yylval_param, YYLTYPE * yylloc_param , yyscan_t yyscanner); - -#define YY_DECL int yylex \ - (YYSTYPE * yylval_param, YYLTYPE * yylloc_param , yyscan_t yyscanner) -#endif /* !YY_DECL */ - -/* yy_get_previous_state - get the state just before the EOB char was reached */ - -#undef YY_NEW_FILE -#undef YY_FLUSH_BUFFER -#undef yy_set_bol -#undef yy_new_buffer -#undef yy_set_interactive -#undef YY_DO_BEFORE_ACTION - -#ifdef YY_DECL_IS_OURS -#undef YY_DECL_IS_OURS -#undef YY_DECL -#endif - -#ifndef xlu__cfg_yy_create_buffer_ALREADY_DEFINED -#undef yy_create_buffer -#endif -#ifndef xlu__cfg_yy_delete_buffer_ALREADY_DEFINED -#undef yy_delete_buffer -#endif -#ifndef xlu__cfg_yy_scan_buffer_ALREADY_DEFINED -#undef yy_scan_buffer -#endif -#ifndef xlu__cfg_yy_scan_string_ALREADY_DEFINED -#undef yy_scan_string -#endif -#ifndef xlu__cfg_yy_scan_bytes_ALREADY_DEFINED -#undef yy_scan_bytes -#endif -#ifndef xlu__cfg_yy_init_buffer_ALREADY_DEFINED -#undef yy_init_buffer -#endif -#ifndef xlu__cfg_yy_flush_buffer_ALREADY_DEFINED -#undef yy_flush_buffer -#endif -#ifndef xlu__cfg_yy_load_buffer_state_ALREADY_DEFINED -#undef yy_load_buffer_state -#endif -#ifndef xlu__cfg_yy_switch_to_buffer_ALREADY_DEFINED -#undef yy_switch_to_buffer -#endif -#ifndef xlu__cfg_yypush_buffer_state_ALREADY_DEFINED -#undef yypush_buffer_state -#endif -#ifndef xlu__cfg_yypop_buffer_state_ALREADY_DEFINED -#undef yypop_buffer_state -#endif -#ifndef xlu__cfg_yyensure_buffer_stack_ALREADY_DEFINED -#undef yyensure_buffer_stack -#endif -#ifndef xlu__cfg_yylex_ALREADY_DEFINED -#undef yylex -#endif -#ifndef xlu__cfg_yyrestart_ALREADY_DEFINED -#undef yyrestart -#endif -#ifndef xlu__cfg_yylex_init_ALREADY_DEFINED -#undef yylex_init -#endif -#ifndef xlu__cfg_yylex_init_extra_ALREADY_DEFINED -#undef yylex_init_extra -#endif -#ifndef xlu__cfg_yylex_destroy_ALREADY_DEFINED -#undef yylex_destroy -#endif -#ifndef xlu__cfg_yyget_debug_ALREADY_DEFINED -#undef yyget_debug -#endif -#ifndef xlu__cfg_yyset_debug_ALREADY_DEFINED -#undef yyset_debug -#endif -#ifndef xlu__cfg_yyget_extra_ALREADY_DEFINED -#undef yyget_extra -#endif -#ifndef xlu__cfg_yyset_extra_ALREADY_DEFINED -#undef yyset_extra -#endif -#ifndef xlu__cfg_yyget_in_ALREADY_DEFINED -#undef yyget_in -#endif -#ifndef xlu__cfg_yyset_in_ALREADY_DEFINED -#undef yyset_in -#endif -#ifndef xlu__cfg_yyget_out_ALREADY_DEFINED -#undef yyget_out -#endif -#ifndef xlu__cfg_yyset_out_ALREADY_DEFINED -#undef yyset_out -#endif -#ifndef xlu__cfg_yyget_leng_ALREADY_DEFINED -#undef yyget_leng -#endif -#ifndef xlu__cfg_yyget_text_ALREADY_DEFINED -#undef yyget_text -#endif -#ifndef xlu__cfg_yyget_lineno_ALREADY_DEFINED -#undef yyget_lineno -#endif -#ifndef xlu__cfg_yyset_lineno_ALREADY_DEFINED -#undef yyset_lineno -#endif -#ifndef xlu__cfg_yyget_column_ALREADY_DEFINED -#undef yyget_column -#endif -#ifndef xlu__cfg_yyset_column_ALREADY_DEFINED -#undef yyset_column -#endif -#ifndef xlu__cfg_yywrap_ALREADY_DEFINED -#undef yywrap -#endif -#ifndef xlu__cfg_yyget_lval_ALREADY_DEFINED -#undef yyget_lval -#endif -#ifndef xlu__cfg_yyset_lval_ALREADY_DEFINED -#undef yyset_lval -#endif -#ifndef xlu__cfg_yyget_lloc_ALREADY_DEFINED -#undef yyget_lloc -#endif -#ifndef xlu__cfg_yyset_lloc_ALREADY_DEFINED -#undef yyset_lloc -#endif -#ifndef xlu__cfg_yyalloc_ALREADY_DEFINED -#undef yyalloc -#endif -#ifndef xlu__cfg_yyrealloc_ALREADY_DEFINED -#undef yyrealloc -#endif -#ifndef xlu__cfg_yyfree_ALREADY_DEFINED -#undef yyfree -#endif -#ifndef xlu__cfg_yytext_ALREADY_DEFINED -#undef yytext -#endif -#ifndef xlu__cfg_yyleng_ALREADY_DEFINED -#undef yyleng -#endif -#ifndef xlu__cfg_yyin_ALREADY_DEFINED -#undef yyin -#endif -#ifndef xlu__cfg_yyout_ALREADY_DEFINED -#undef yyout -#endif -#ifndef xlu__cfg_yy_flex_debug_ALREADY_DEFINED -#undef yy_flex_debug -#endif -#ifndef xlu__cfg_yylineno_ALREADY_DEFINED -#undef yylineno -#endif -#ifndef xlu__cfg_yytables_fload_ALREADY_DEFINED -#undef yytables_fload -#endif -#ifndef xlu__cfg_yytables_destroy_ALREADY_DEFINED -#undef yytables_destroy -#endif -#ifndef xlu__cfg_yyTABLES_NAME_ALREADY_DEFINED -#undef yyTABLES_NAME -#endif - -#line 105 "libxlu_cfg_l.l" - -#line 733 "libxlu_cfg_l.h" -#undef xlu__cfg_yyIN_HEADER -#endif /* xlu__cfg_yyHEADER_H */ diff --git a/tools/libs/util/libxlu_cfg_y.c b/tools/libs/util/libxlu_cfg_y.c deleted file mode 100644 index 6d4638afc9..0000000000 --- a/tools/libs/util/libxlu_cfg_y.c +++ /dev/null @@ -1,1705 +0,0 @@ -/* A Bison parser, made by GNU Bison 3.3.2. */ - -/* Bison implementation for Yacc-like parsers in C - - Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2019 Free Software Foundation, - Inc. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see . */ - -/* As a special exception, you may create a larger work that contains - part or all of the Bison parser skeleton and distribute that work - under terms of your choice, so long as that work isn't itself a - parser generator using the skeleton or a modified version thereof - as a parser skeleton. Alternatively, if you modify or redistribute - the parser skeleton itself, you may (at your option) remove this - special exception, which will cause the skeleton and the resulting - Bison output files to be licensed under the GNU General Public - License without this special exception. - - This special exception was added by the Free Software Foundation in - version 2.2 of Bison. */ - -/* C LALR(1) parser skeleton written by Richard Stallman, by - simplifying the original so-called "semantic" parser. */ - -/* All symbols defined below should begin with yy or YY, to avoid - infringing on user name space. This should be done even for local - variables, as they might otherwise be expanded by user macros. - There are some unavoidable exceptions within include files to - define necessary library symbols; they are noted "INFRINGES ON - USER NAME SPACE" below. */ - -/* Undocumented macros, especially those whose name start with YY_, - are private implementation details. Do not rely on them. */ - -/* Identify Bison output. */ -#define YYBISON 1 - -/* Bison version. */ -#define YYBISON_VERSION "3.3.2" - -/* Skeleton name. */ -#define YYSKELETON_NAME "yacc.c" - -/* Pure parsers. */ -#define YYPURE 1 - -/* Push parsers. */ -#define YYPUSH 0 - -/* Pull parsers. */ -#define YYPULL 1 - - -/* Substitute the variable and function names. */ -#define yyparse xlu__cfg_yyparse -#define yylex xlu__cfg_yylex -#define yyerror xlu__cfg_yyerror -#define yydebug xlu__cfg_yydebug -#define yynerrs xlu__cfg_yynerrs - - -/* First part of user prologue. */ -#line 19 "libxlu_cfg_y.y" /* yacc.c:337 */ - -#define ctx_scanner ctx->scanner -#include "libxlu_cfg_i.h" -#include "libxlu_cfg_l.h" - -#line 82 "libxlu_cfg_y.c" /* yacc.c:337 */ -# ifndef YY_NULLPTR -# if defined __cplusplus -# if 201103L <= __cplusplus -# define YY_NULLPTR nullptr -# else -# define YY_NULLPTR 0 -# endif -# else -# define YY_NULLPTR ((void*)0) -# endif -# endif - -/* Enabling verbose error messages. */ -#ifdef YYERROR_VERBOSE -# undef YYERROR_VERBOSE -# define YYERROR_VERBOSE 1 -#else -# define YYERROR_VERBOSE 1 -#endif - -/* In a future release of Bison, this section will be replaced - by #include "libxlu_cfg_y.h". */ -#ifndef YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED -# define YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED -/* Debug traces. */ -#ifndef YYDEBUG -# define YYDEBUG 0 -#endif -#if YYDEBUG -extern int xlu__cfg_yydebug; -#endif - -/* Token type. */ -#ifndef YYTOKENTYPE -# define YYTOKENTYPE - enum yytokentype - { - IDENT = 258, - STRING = 259, - NUMBER = 260, - NEWLINE = 261, - OP_ADD = 262 - }; -#endif - -/* Value type. */ -#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED - -union YYSTYPE -{ -#line 25 "libxlu_cfg_y.y" /* yacc.c:352 */ - - char *string; - XLU_ConfigValue *value; - -#line 138 "libxlu_cfg_y.c" /* yacc.c:352 */ -}; - -typedef union YYSTYPE YYSTYPE; -# define YYSTYPE_IS_TRIVIAL 1 -# define YYSTYPE_IS_DECLARED 1 -#endif - -/* Location type. */ -#if ! defined YYLTYPE && ! defined YYLTYPE_IS_DECLARED -typedef struct YYLTYPE YYLTYPE; -struct YYLTYPE -{ - int first_line; - int first_column; - int last_line; - int last_column; -}; -# define YYLTYPE_IS_DECLARED 1 -# define YYLTYPE_IS_TRIVIAL 1 -#endif - - - -int xlu__cfg_yyparse (CfgParseContext *ctx); - -#endif /* !YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED */ - - - -#ifdef short -# undef short -#endif - -#ifdef YYTYPE_UINT8 -typedef YYTYPE_UINT8 yytype_uint8; -#else -typedef unsigned char yytype_uint8; -#endif - -#ifdef YYTYPE_INT8 -typedef YYTYPE_INT8 yytype_int8; -#else -typedef signed char yytype_int8; -#endif - -#ifdef YYTYPE_UINT16 -typedef YYTYPE_UINT16 yytype_uint16; -#else -typedef unsigned short yytype_uint16; -#endif - -#ifdef YYTYPE_INT16 -typedef YYTYPE_INT16 yytype_int16; -#else -typedef short yytype_int16; -#endif - -#ifndef YYSIZE_T -# ifdef __SIZE_TYPE__ -# define YYSIZE_T __SIZE_TYPE__ -# elif defined size_t -# define YYSIZE_T size_t -# elif ! defined YYSIZE_T -# include /* INFRINGES ON USER NAME SPACE */ -# define YYSIZE_T size_t -# else -# define YYSIZE_T unsigned -# endif -#endif - -#define YYSIZE_MAXIMUM ((YYSIZE_T) -1) - -#ifndef YY_ -# if defined YYENABLE_NLS && YYENABLE_NLS -# if ENABLE_NLS -# include /* INFRINGES ON USER NAME SPACE */ -# define YY_(Msgid) dgettext ("bison-runtime", Msgid) -# endif -# endif -# ifndef YY_ -# define YY_(Msgid) Msgid -# endif -#endif - -#ifndef YY_ATTRIBUTE -# if (defined __GNUC__ \ - && (2 < __GNUC__ || (__GNUC__ == 2 && 96 <= __GNUC_MINOR__))) \ - || defined __SUNPRO_C && 0x5110 <= __SUNPRO_C -# define YY_ATTRIBUTE(Spec) __attribute__(Spec) -# else -# define YY_ATTRIBUTE(Spec) /* empty */ -# endif -#endif - -#ifndef YY_ATTRIBUTE_PURE -# define YY_ATTRIBUTE_PURE YY_ATTRIBUTE ((__pure__)) -#endif - -#ifndef YY_ATTRIBUTE_UNUSED -# define YY_ATTRIBUTE_UNUSED YY_ATTRIBUTE ((__unused__)) -#endif - -/* Suppress unused-variable warnings by "using" E. */ -#if ! defined lint || defined __GNUC__ -# define YYUSE(E) ((void) (E)) -#else -# define YYUSE(E) /* empty */ -#endif - -#if defined __GNUC__ && ! defined __ICC && 407 <= __GNUC__ * 100 + __GNUC_MINOR__ -/* Suppress an incorrect diagnostic about yylval being uninitialized. */ -# define YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN \ - _Pragma ("GCC diagnostic push") \ - _Pragma ("GCC diagnostic ignored \"-Wuninitialized\"")\ - _Pragma ("GCC diagnostic ignored \"-Wmaybe-uninitialized\"") -# define YY_IGNORE_MAYBE_UNINITIALIZED_END \ - _Pragma ("GCC diagnostic pop") -#else -# define YY_INITIAL_VALUE(Value) Value -#endif -#ifndef YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN -# define YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN -# define YY_IGNORE_MAYBE_UNINITIALIZED_END -#endif -#ifndef YY_INITIAL_VALUE -# define YY_INITIAL_VALUE(Value) /* Nothing. */ -#endif - - -#if ! defined yyoverflow || YYERROR_VERBOSE - -/* The parser invokes alloca or malloc; define the necessary symbols. */ - -# ifdef YYSTACK_USE_ALLOCA -# if YYSTACK_USE_ALLOCA -# ifdef __GNUC__ -# define YYSTACK_ALLOC __builtin_alloca -# elif defined __BUILTIN_VA_ARG_INCR -# include /* INFRINGES ON USER NAME SPACE */ -# elif defined _AIX -# define YYSTACK_ALLOC __alloca -# elif defined _MSC_VER -# include /* INFRINGES ON USER NAME SPACE */ -# define alloca _alloca -# else -# define YYSTACK_ALLOC alloca -# if ! defined _ALLOCA_H && ! defined EXIT_SUCCESS -# include /* INFRINGES ON USER NAME SPACE */ - /* Use EXIT_SUCCESS as a witness for stdlib.h. */ -# ifndef EXIT_SUCCESS -# define EXIT_SUCCESS 0 -# endif -# endif -# endif -# endif -# endif - -# ifdef YYSTACK_ALLOC - /* Pacify GCC's 'empty if-body' warning. */ -# define YYSTACK_FREE(Ptr) do { /* empty */; } while (0) -# ifndef YYSTACK_ALLOC_MAXIMUM - /* The OS might guarantee only one guard page at the bottom of the stack, - and a page size can be as small as 4096 bytes. So we cannot safely - invoke alloca (N) if N exceeds 4096. Use a slightly smaller number - to allow for a few compiler-allocated temporary stack slots. */ -# define YYSTACK_ALLOC_MAXIMUM 4032 /* reasonable circa 2006 */ -# endif -# else -# define YYSTACK_ALLOC YYMALLOC -# define YYSTACK_FREE YYFREE -# ifndef YYSTACK_ALLOC_MAXIMUM -# define YYSTACK_ALLOC_MAXIMUM YYSIZE_MAXIMUM -# endif -# if (defined __cplusplus && ! defined EXIT_SUCCESS \ - && ! ((defined YYMALLOC || defined malloc) \ - && (defined YYFREE || defined free))) -# include /* INFRINGES ON USER NAME SPACE */ -# ifndef EXIT_SUCCESS -# define EXIT_SUCCESS 0 -# endif -# endif -# ifndef YYMALLOC -# define YYMALLOC malloc -# if ! defined malloc && ! defined EXIT_SUCCESS -void *malloc (YYSIZE_T); /* INFRINGES ON USER NAME SPACE */ -# endif -# endif -# ifndef YYFREE -# define YYFREE free -# if ! defined free && ! defined EXIT_SUCCESS -void free (void *); /* INFRINGES ON USER NAME SPACE */ -# endif -# endif -# endif -#endif /* ! defined yyoverflow || YYERROR_VERBOSE */ - - -#if (! defined yyoverflow \ - && (! defined __cplusplus \ - || (defined YYLTYPE_IS_TRIVIAL && YYLTYPE_IS_TRIVIAL \ - && defined YYSTYPE_IS_TRIVIAL && YYSTYPE_IS_TRIVIAL))) - -/* A type that is properly aligned for any stack member. */ -union yyalloc -{ - yytype_int16 yyss_alloc; - YYSTYPE yyvs_alloc; - YYLTYPE yyls_alloc; -}; - -/* The size of the maximum gap between one aligned stack and the next. */ -# define YYSTACK_GAP_MAXIMUM (sizeof (union yyalloc) - 1) - -/* The size of an array large to enough to hold all stacks, each with - N elements. */ -# define YYSTACK_BYTES(N) \ - ((N) * (sizeof (yytype_int16) + sizeof (YYSTYPE) + sizeof (YYLTYPE)) \ - + 2 * YYSTACK_GAP_MAXIMUM) - -# define YYCOPY_NEEDED 1 - -/* Relocate STACK from its old location to the new one. The - local variables YYSIZE and YYSTACKSIZE give the old and new number of - elements in the stack, and YYPTR gives the new location of the - stack. Advance YYPTR to a properly aligned location for the next - stack. */ -# define YYSTACK_RELOCATE(Stack_alloc, Stack) \ - do \ - { \ - YYSIZE_T yynewbytes; \ - YYCOPY (&yyptr->Stack_alloc, Stack, yysize); \ - Stack = &yyptr->Stack_alloc; \ - yynewbytes = yystacksize * sizeof (*Stack) + YYSTACK_GAP_MAXIMUM; \ - yyptr += yynewbytes / sizeof (*yyptr); \ - } \ - while (0) - -#endif - -#if defined YYCOPY_NEEDED && YYCOPY_NEEDED -/* Copy COUNT objects from SRC to DST. The source and destination do - not overlap. */ -# ifndef YYCOPY -# if defined __GNUC__ && 1 < __GNUC__ -# define YYCOPY(Dst, Src, Count) \ - __builtin_memcpy (Dst, Src, (Count) * sizeof (*(Src))) -# else -# define YYCOPY(Dst, Src, Count) \ - do \ - { \ - YYSIZE_T yyi; \ - for (yyi = 0; yyi < (Count); yyi++) \ - (Dst)[yyi] = (Src)[yyi]; \ - } \ - while (0) -# endif -# endif -#endif /* !YYCOPY_NEEDED */ - -/* YYFINAL -- State number of the termination state. */ -#define YYFINAL 3 -/* YYLAST -- Last index in YYTABLE. */ -#define YYLAST 27 - -/* YYNTOKENS -- Number of terminals. */ -#define YYNTOKENS 13 -/* YYNNTS -- Number of nonterminals. */ -#define YYNNTS 11 -/* YYNRULES -- Number of rules. */ -#define YYNRULES 23 -/* YYNSTATES -- Number of states. */ -#define YYNSTATES 32 - -#define YYUNDEFTOK 2 -#define YYMAXUTOK 262 - -/* YYTRANSLATE(TOKEN-NUM) -- Symbol number corresponding to TOKEN-NUM - as returned by yylex, with out-of-bounds checking. */ -#define YYTRANSLATE(YYX) \ - ((unsigned) (YYX) <= YYMAXUTOK ? yytranslate[YYX] : YYUNDEFTOK) - -/* YYTRANSLATE[TOKEN-NUM] -- Symbol number corresponding to TOKEN-NUM - as returned by yylex. */ -static const yytype_uint8 yytranslate[] = -{ - 0, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 12, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 9, - 2, 8, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 10, 2, 11, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, - 2, 2, 2, 2, 2, 2, 1, 2, 3, 4, - 5, 6, 7 -}; - -#if YYDEBUG - /* YYRLINE[YYN] -- Source line where rule number YYN was defined. */ -static const yytype_uint8 yyrline[] = -{ - 0, 48, 48, 49, 51, 52, 54, 55, 56, 58, - 59, 61, 62, 64, 65, 67, 68, 70, 71, 72, - 74, 75, 77, 79 -}; -#endif - -#if YYDEBUG || YYERROR_VERBOSE || 1 -/* YYTNAME[SYMBOL-NUM] -- String name of the symbol SYMBOL-NUM. - First, the terminals, then, starting at YYNTOKENS, nonterminals. */ -static const char *const yytname[] = -{ - "$end", "error", "$undefined", "IDENT", "STRING", "NUMBER", "NEWLINE", - "\"+=\"", "'='", "';'", "'['", "']'", "','", "$accept", "file", "stmts", - "stmt", "assignment", "endstmt", "value", "atom", "valuelist", "values", - "nlok", YY_NULLPTR -}; -#endif - -# ifdef YYPRINT -/* YYTOKNUM[NUM] -- (External) token number corresponding to the - (internal) symbol number NUM (which must be that of a token). */ -static const yytype_uint16 yytoknum[] = -{ - 0, 256, 257, 258, 259, 260, 261, 262, 61, 59, - 91, 93, 44 -}; -# endif - -#define YYPACT_NINF -18 - -#define yypact_value_is_default(Yystate) \ - (!!((Yystate) == (-18))) - -#define YYTABLE_NINF -3 - -#define yytable_value_is_error(Yytable_value) \ - 0 - - /* YYPACT[STATE-NUM] -- Index in YYTABLE of the portion describing - STATE-NUM. */ -static const yytype_int8 yypact[] = -{ - -18, 5, 1, -18, -3, 14, -18, -18, -18, 3, - -18, -18, 10, 10, -18, -18, -18, -18, -18, -18, - -18, 13, -18, -18, 15, 12, 19, -18, -18, 13, - -18, 19 -}; - - /* YYDEFACT[STATE-NUM] -- Default reduction number in state STATE-NUM. - Performed when YYTABLE does not specify something else to do. Zero - means the default is an error. */ -static const yytype_uint8 yydefact[] = -{ - 4, 0, 0, 1, 0, 0, 11, 12, 5, 3, - 7, 8, 0, 0, 6, 15, 16, 22, 10, 13, - 9, 17, 23, 22, 0, 18, 20, 14, 22, 19, - 22, 21 -}; - - /* YYPGOTO[NTERM-NUM]. */ -static const yytype_int8 yypgoto[] = -{ - -18, -18, -18, -18, -18, 18, -13, -18, -18, -18, - -17 -}; - - /* YYDEFGOTO[NTERM-NUM]. */ -static const yytype_int8 yydefgoto[] = -{ - -1, 1, 2, 8, 9, 10, 18, 19, 24, 25, - 21 -}; - - /* YYTABLE[YYPACT[STATE-NUM]] -- What to do in state STATE-NUM. If - positive, shift that token. If negative, reduce the rule whose - number is the opposite. If YYTABLE_NINF, syntax error. */ -static const yytype_int8 yytable[] = -{ - 20, -2, 4, 11, 5, 3, 26, 6, 23, 6, - 7, 29, 7, 31, 15, 16, 30, 15, 16, 22, - 17, 12, 13, 17, 28, 22, 27, 14 -}; - -static const yytype_uint8 yycheck[] = -{ - 13, 0, 1, 6, 3, 0, 23, 6, 21, 6, - 9, 28, 9, 30, 4, 5, 29, 4, 5, 6, - 10, 7, 8, 10, 12, 6, 11, 9 -}; - - /* YYSTOS[STATE-NUM] -- The (internal number of the) accessing - symbol of state STATE-NUM. */ -static const yytype_uint8 yystos[] = -{ - 0, 14, 15, 0, 1, 3, 6, 9, 16, 17, - 18, 6, 7, 8, 18, 4, 5, 10, 19, 20, - 19, 23, 6, 19, 21, 22, 23, 11, 12, 23, - 19, 23 -}; - - /* YYR1[YYN] -- Symbol number of symbol that rule YYN derives. */ -static const yytype_uint8 yyr1[] = -{ - 0, 13, 14, 14, 15, 15, 16, 16, 16, 17, - 17, 18, 18, 19, 19, 20, 20, 21, 21, 21, - 22, 22, 23, 23 -}; - - /* YYR2[YYN] -- Number of symbols on the right hand side of rule YYN. */ -static const yytype_uint8 yyr2[] = -{ - 0, 2, 1, 2, 0, 2, 2, 1, 2, 3, - 3, 1, 1, 1, 4, 1, 1, 0, 1, 3, - 2, 5, 0, 2 -}; - - -#define yyerrok (yyerrstatus = 0) -#define yyclearin (yychar = YYEMPTY) -#define YYEMPTY (-2) -#define YYEOF 0 - -#define YYACCEPT goto yyacceptlab -#define YYABORT goto yyabortlab -#define YYERROR goto yyerrorlab - - -#define YYRECOVERING() (!!yyerrstatus) - -#define YYBACKUP(Token, Value) \ - do \ - if (yychar == YYEMPTY) \ - { \ - yychar = (Token); \ - yylval = (Value); \ - YYPOPSTACK (yylen); \ - yystate = *yyssp; \ - goto yybackup; \ - } \ - else \ - { \ - yyerror (&yylloc, ctx, YY_("syntax error: cannot back up")); \ - YYERROR; \ - } \ - while (0) - -/* Error token number */ -#define YYTERROR 1 -#define YYERRCODE 256 - - -/* YYLLOC_DEFAULT -- Set CURRENT to span from RHS[1] to RHS[N]. - If N is 0, then set CURRENT to the empty location which ends - the previous symbol: RHS[0] (always defined). */ - -#ifndef YYLLOC_DEFAULT -# define YYLLOC_DEFAULT(Current, Rhs, N) \ - do \ - if (N) \ - { \ - (Current).first_line = YYRHSLOC (Rhs, 1).first_line; \ - (Current).first_column = YYRHSLOC (Rhs, 1).first_column; \ - (Current).last_line = YYRHSLOC (Rhs, N).last_line; \ - (Current).last_column = YYRHSLOC (Rhs, N).last_column; \ - } \ - else \ - { \ - (Current).first_line = (Current).last_line = \ - YYRHSLOC (Rhs, 0).last_line; \ - (Current).first_column = (Current).last_column = \ - YYRHSLOC (Rhs, 0).last_column; \ - } \ - while (0) -#endif - -#define YYRHSLOC(Rhs, K) ((Rhs)[K]) - - -/* Enable debugging if requested. */ -#if YYDEBUG - -# ifndef YYFPRINTF -# include /* INFRINGES ON USER NAME SPACE */ -# define YYFPRINTF fprintf -# endif - -# define YYDPRINTF(Args) \ -do { \ - if (yydebug) \ - YYFPRINTF Args; \ -} while (0) - - -/* YY_LOCATION_PRINT -- Print the location on the stream. - This macro was not mandated originally: define only if we know - we won't break user code: when these are the locations we know. */ - -#ifndef YY_LOCATION_PRINT -# if defined YYLTYPE_IS_TRIVIAL && YYLTYPE_IS_TRIVIAL - -/* Print *YYLOCP on YYO. Private, do not rely on its existence. */ - -YY_ATTRIBUTE_UNUSED -static int -yy_location_print_ (FILE *yyo, YYLTYPE const * const yylocp) -{ - int res = 0; - int end_col = 0 != yylocp->last_column ? yylocp->last_column - 1 : 0; - if (0 <= yylocp->first_line) - { - res += YYFPRINTF (yyo, "%d", yylocp->first_line); - if (0 <= yylocp->first_column) - res += YYFPRINTF (yyo, ".%d", yylocp->first_column); - } - if (0 <= yylocp->last_line) - { - if (yylocp->first_line < yylocp->last_line) - { - res += YYFPRINTF (yyo, "-%d", yylocp->last_line); - if (0 <= end_col) - res += YYFPRINTF (yyo, ".%d", end_col); - } - else if (0 <= end_col && yylocp->first_column < end_col) - res += YYFPRINTF (yyo, "-%d", end_col); - } - return res; - } - -# define YY_LOCATION_PRINT(File, Loc) \ - yy_location_print_ (File, &(Loc)) - -# else -# define YY_LOCATION_PRINT(File, Loc) ((void) 0) -# endif -#endif - - -# define YY_SYMBOL_PRINT(Title, Type, Value, Location) \ -do { \ - if (yydebug) \ - { \ - YYFPRINTF (stderr, "%s ", Title); \ - yy_symbol_print (stderr, \ - Type, Value, Location, ctx); \ - YYFPRINTF (stderr, "\n"); \ - } \ -} while (0) - - -/*-----------------------------------. -| Print this symbol's value on YYO. | -`-----------------------------------*/ - -static void -yy_symbol_value_print (FILE *yyo, int yytype, YYSTYPE const * const yyvaluep, YYLTYPE const * const yylocationp, CfgParseContext *ctx) -{ - FILE *yyoutput = yyo; - YYUSE (yyoutput); - YYUSE (yylocationp); - YYUSE (ctx); - if (!yyvaluep) - return; -# ifdef YYPRINT - if (yytype < YYNTOKENS) - YYPRINT (yyo, yytoknum[yytype], *yyvaluep); -# endif - YYUSE (yytype); -} - - -/*---------------------------. -| Print this symbol on YYO. | -`---------------------------*/ - -static void -yy_symbol_print (FILE *yyo, int yytype, YYSTYPE const * const yyvaluep, YYLTYPE const * const yylocationp, CfgParseContext *ctx) -{ - YYFPRINTF (yyo, "%s %s (", - yytype < YYNTOKENS ? "token" : "nterm", yytname[yytype]); - - YY_LOCATION_PRINT (yyo, *yylocationp); - YYFPRINTF (yyo, ": "); - yy_symbol_value_print (yyo, yytype, yyvaluep, yylocationp, ctx); - YYFPRINTF (yyo, ")"); -} - -/*------------------------------------------------------------------. -| yy_stack_print -- Print the state stack from its BOTTOM up to its | -| TOP (included). | -`------------------------------------------------------------------*/ - -static void -yy_stack_print (yytype_int16 *yybottom, yytype_int16 *yytop) -{ - YYFPRINTF (stderr, "Stack now"); - for (; yybottom <= yytop; yybottom++) - { - int yybot = *yybottom; - YYFPRINTF (stderr, " %d", yybot); - } - YYFPRINTF (stderr, "\n"); -} - -# define YY_STACK_PRINT(Bottom, Top) \ -do { \ - if (yydebug) \ - yy_stack_print ((Bottom), (Top)); \ -} while (0) - - -/*------------------------------------------------. -| Report that the YYRULE is going to be reduced. | -`------------------------------------------------*/ - -static void -yy_reduce_print (yytype_int16 *yyssp, YYSTYPE *yyvsp, YYLTYPE *yylsp, int yyrule, CfgParseContext *ctx) -{ - unsigned long yylno = yyrline[yyrule]; - int yynrhs = yyr2[yyrule]; - int yyi; - YYFPRINTF (stderr, "Reducing stack by rule %d (line %lu):\n", - yyrule - 1, yylno); - /* The symbols being reduced. */ - for (yyi = 0; yyi < yynrhs; yyi++) - { - YYFPRINTF (stderr, " $%d = ", yyi + 1); - yy_symbol_print (stderr, - yystos[yyssp[yyi + 1 - yynrhs]], - &yyvsp[(yyi + 1) - (yynrhs)] - , &(yylsp[(yyi + 1) - (yynrhs)]) , ctx); - YYFPRINTF (stderr, "\n"); - } -} - -# define YY_REDUCE_PRINT(Rule) \ -do { \ - if (yydebug) \ - yy_reduce_print (yyssp, yyvsp, yylsp, Rule, ctx); \ -} while (0) - -/* Nonzero means print parse trace. It is left uninitialized so that - multiple parsers can coexist. */ -int yydebug; -#else /* !YYDEBUG */ -# define YYDPRINTF(Args) -# define YY_SYMBOL_PRINT(Title, Type, Value, Location) -# define YY_STACK_PRINT(Bottom, Top) -# define YY_REDUCE_PRINT(Rule) -#endif /* !YYDEBUG */ - - -/* YYINITDEPTH -- initial size of the parser's stacks. */ -#ifndef YYINITDEPTH -# define YYINITDEPTH 200 -#endif - -/* YYMAXDEPTH -- maximum size the stacks can grow to (effective only - if the built-in stack extension method is used). - - Do not make this value too large; the results are undefined if - YYSTACK_ALLOC_MAXIMUM < YYSTACK_BYTES (YYMAXDEPTH) - evaluated with infinite-precision integer arithmetic. */ - -#ifndef YYMAXDEPTH -# define YYMAXDEPTH 10000 -#endif - - -#if YYERROR_VERBOSE - -# ifndef yystrlen -# if defined __GLIBC__ && defined _STRING_H -# define yystrlen strlen -# else -/* Return the length of YYSTR. */ -static YYSIZE_T -yystrlen (const char *yystr) -{ - YYSIZE_T yylen; - for (yylen = 0; yystr[yylen]; yylen++) - continue; - return yylen; -} -# endif -# endif - -# ifndef yystpcpy -# if defined __GLIBC__ && defined _STRING_H && defined _GNU_SOURCE -# define yystpcpy stpcpy -# else -/* Copy YYSRC to YYDEST, returning the address of the terminating '\0' in - YYDEST. */ -static char * -yystpcpy (char *yydest, const char *yysrc) -{ - char *yyd = yydest; - const char *yys = yysrc; - - while ((*yyd++ = *yys++) != '\0') - continue; - - return yyd - 1; -} -# endif -# endif - -# ifndef yytnamerr -/* Copy to YYRES the contents of YYSTR after stripping away unnecessary - quotes and backslashes, so that it's suitable for yyerror. The - heuristic is that double-quoting is unnecessary unless the string - contains an apostrophe, a comma, or backslash (other than - backslash-backslash). YYSTR is taken from yytname. If YYRES is - null, do not copy; instead, return the length of what the result - would have been. */ -static YYSIZE_T -yytnamerr (char *yyres, const char *yystr) -{ - if (*yystr == '"') - { - YYSIZE_T yyn = 0; - char const *yyp = yystr; - - for (;;) - switch (*++yyp) - { - case '\'': - case ',': - goto do_not_strip_quotes; - - case '\\': - if (*++yyp != '\\') - goto do_not_strip_quotes; - else - goto append; - - append: - default: - if (yyres) - yyres[yyn] = *yyp; - yyn++; - break; - - case '"': - if (yyres) - yyres[yyn] = '\0'; - return yyn; - } - do_not_strip_quotes: ; - } - - if (! yyres) - return yystrlen (yystr); - - return (YYSIZE_T) (yystpcpy (yyres, yystr) - yyres); -} -# endif - -/* Copy into *YYMSG, which is of size *YYMSG_ALLOC, an error message - about the unexpected token YYTOKEN for the state stack whose top is - YYSSP. - - Return 0 if *YYMSG was successfully written. Return 1 if *YYMSG is - not large enough to hold the message. In that case, also set - *YYMSG_ALLOC to the required number of bytes. Return 2 if the - required number of bytes is too large to store. */ -static int -yysyntax_error (YYSIZE_T *yymsg_alloc, char **yymsg, - yytype_int16 *yyssp, int yytoken) -{ - YYSIZE_T yysize0 = yytnamerr (YY_NULLPTR, yytname[yytoken]); - YYSIZE_T yysize = yysize0; - enum { YYERROR_VERBOSE_ARGS_MAXIMUM = 5 }; - /* Internationalized format string. */ - const char *yyformat = YY_NULLPTR; - /* Arguments of yyformat. */ - char const *yyarg[YYERROR_VERBOSE_ARGS_MAXIMUM]; - /* Number of reported tokens (one for the "unexpected", one per - "expected"). */ - int yycount = 0; - - /* There are many possibilities here to consider: - - If this state is a consistent state with a default action, then - the only way this function was invoked is if the default action - is an error action. In that case, don't check for expected - tokens because there are none. - - The only way there can be no lookahead present (in yychar) is if - this state is a consistent state with a default action. Thus, - detecting the absence of a lookahead is sufficient to determine - that there is no unexpected or expected token to report. In that - case, just report a simple "syntax error". - - Don't assume there isn't a lookahead just because this state is a - consistent state with a default action. There might have been a - previous inconsistent state, consistent state with a non-default - action, or user semantic action that manipulated yychar. - - Of course, the expected token list depends on states to have - correct lookahead information, and it depends on the parser not - to perform extra reductions after fetching a lookahead from the - scanner and before detecting a syntax error. Thus, state merging - (from LALR or IELR) and default reductions corrupt the expected - token list. However, the list is correct for canonical LR with - one exception: it will still contain any token that will not be - accepted due to an error action in a later state. - */ - if (yytoken != YYEMPTY) - { - int yyn = yypact[*yyssp]; - yyarg[yycount++] = yytname[yytoken]; - if (!yypact_value_is_default (yyn)) - { - /* Start YYX at -YYN if negative to avoid negative indexes in - YYCHECK. In other words, skip the first -YYN actions for - this state because they are default actions. */ - int yyxbegin = yyn < 0 ? -yyn : 0; - /* Stay within bounds of both yycheck and yytname. */ - int yychecklim = YYLAST - yyn + 1; - int yyxend = yychecklim < YYNTOKENS ? yychecklim : YYNTOKENS; - int yyx; - - for (yyx = yyxbegin; yyx < yyxend; ++yyx) - if (yycheck[yyx + yyn] == yyx && yyx != YYTERROR - && !yytable_value_is_error (yytable[yyx + yyn])) - { - if (yycount == YYERROR_VERBOSE_ARGS_MAXIMUM) - { - yycount = 1; - yysize = yysize0; - break; - } - yyarg[yycount++] = yytname[yyx]; - { - YYSIZE_T yysize1 = yysize + yytnamerr (YY_NULLPTR, yytname[yyx]); - if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) - yysize = yysize1; - else - return 2; - } - } - } - } - - switch (yycount) - { -# define YYCASE_(N, S) \ - case N: \ - yyformat = S; \ - break - default: /* Avoid compiler warnings. */ - YYCASE_(0, YY_("syntax error")); - YYCASE_(1, YY_("syntax error, unexpected %s")); - YYCASE_(2, YY_("syntax error, unexpected %s, expecting %s")); - YYCASE_(3, YY_("syntax error, unexpected %s, expecting %s or %s")); - YYCASE_(4, YY_("syntax error, unexpected %s, expecting %s or %s or %s")); - YYCASE_(5, YY_("syntax error, unexpected %s, expecting %s or %s or %s or %s")); -# undef YYCASE_ - } - - { - YYSIZE_T yysize1 = yysize + yystrlen (yyformat); - if (yysize <= yysize1 && yysize1 <= YYSTACK_ALLOC_MAXIMUM) - yysize = yysize1; - else - return 2; - } - - if (*yymsg_alloc < yysize) - { - *yymsg_alloc = 2 * yysize; - if (! (yysize <= *yymsg_alloc - && *yymsg_alloc <= YYSTACK_ALLOC_MAXIMUM)) - *yymsg_alloc = YYSTACK_ALLOC_MAXIMUM; - return 1; - } - - /* Avoid sprintf, as that infringes on the user's name space. - Don't have undefined behavior even if the translation - produced a string with the wrong number of "%s"s. */ - { - char *yyp = *yymsg; - int yyi = 0; - while ((*yyp = *yyformat) != '\0') - if (*yyp == '%' && yyformat[1] == 's' && yyi < yycount) - { - yyp += yytnamerr (yyp, yyarg[yyi++]); - yyformat += 2; - } - else - { - yyp++; - yyformat++; - } - } - return 0; -} -#endif /* YYERROR_VERBOSE */ - -/*-----------------------------------------------. -| Release the memory associated to this symbol. | -`-----------------------------------------------*/ - -static void -yydestruct (const char *yymsg, int yytype, YYSTYPE *yyvaluep, YYLTYPE *yylocationp, CfgParseContext *ctx) -{ - YYUSE (yyvaluep); - YYUSE (yylocationp); - YYUSE (ctx); - if (!yymsg) - yymsg = "Deleting"; - YY_SYMBOL_PRINT (yymsg, yytype, yyvaluep, yylocationp); - - YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN - switch (yytype) - { - case 3: /* IDENT */ -#line 40 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { free(((*yyvaluep).string)); } -#line 1072 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 4: /* STRING */ -#line 40 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { free(((*yyvaluep).string)); } -#line 1078 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 5: /* NUMBER */ -#line 40 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { free(((*yyvaluep).string)); } -#line 1084 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 19: /* value */ -#line 44 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { xlu__cfg_value_free(((*yyvaluep).value)); } -#line 1090 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 20: /* atom */ -#line 40 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { free(((*yyvaluep).string)); } -#line 1096 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 21: /* valuelist */ -#line 44 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { xlu__cfg_value_free(((*yyvaluep).value)); } -#line 1102 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - case 22: /* values */ -#line 44 "libxlu_cfg_y.y" /* yacc.c:1257 */ - { xlu__cfg_value_free(((*yyvaluep).value)); } -#line 1108 "libxlu_cfg_y.c" /* yacc.c:1257 */ - break; - - default: - break; - } - YY_IGNORE_MAYBE_UNINITIALIZED_END -} - - - - -/*----------. -| yyparse. | -`----------*/ - -int -yyparse (CfgParseContext *ctx) -{ -/* The lookahead symbol. */ -int yychar; - - -/* The semantic value of the lookahead symbol. */ -/* Default value used for initialization, for pacifying older GCCs - or non-GCC compilers. */ -YY_INITIAL_VALUE (static YYSTYPE yyval_default;) -YYSTYPE yylval YY_INITIAL_VALUE (= yyval_default); - -/* Location data for the lookahead symbol. */ -static YYLTYPE yyloc_default -# if defined YYLTYPE_IS_TRIVIAL && YYLTYPE_IS_TRIVIAL - = { 1, 1, 1, 1 } -# endif -; -YYLTYPE yylloc = yyloc_default; - - /* Number of syntax errors so far. */ - int yynerrs; - - int yystate; - /* Number of tokens to shift before error messages enabled. */ - int yyerrstatus; - - /* The stacks and their tools: - 'yyss': related to states. - 'yyvs': related to semantic values. - 'yyls': related to locations. - - Refer to the stacks through separate pointers, to allow yyoverflow - to reallocate them elsewhere. */ - - /* The state stack. */ - yytype_int16 yyssa[YYINITDEPTH]; - yytype_int16 *yyss; - yytype_int16 *yyssp; - - /* The semantic value stack. */ - YYSTYPE yyvsa[YYINITDEPTH]; - YYSTYPE *yyvs; - YYSTYPE *yyvsp; - - /* The location stack. */ - YYLTYPE yylsa[YYINITDEPTH]; - YYLTYPE *yyls; - YYLTYPE *yylsp; - - /* The locations where the error started and ended. */ - YYLTYPE yyerror_range[3]; - - YYSIZE_T yystacksize; - - int yyn; - int yyresult; - /* Lookahead token as an internal (translated) token number. */ - int yytoken = 0; - /* The variables used to return semantic value and location from the - action routines. */ - YYSTYPE yyval; - YYLTYPE yyloc; - -#if YYERROR_VERBOSE - /* Buffer for error messages, and its allocated size. */ - char yymsgbuf[128]; - char *yymsg = yymsgbuf; - YYSIZE_T yymsg_alloc = sizeof yymsgbuf; -#endif - -#define YYPOPSTACK(N) (yyvsp -= (N), yyssp -= (N), yylsp -= (N)) - - /* The number of symbols on the RHS of the reduced rule. - Keep to zero when no symbol should be popped. */ - int yylen = 0; - - yyssp = yyss = yyssa; - yyvsp = yyvs = yyvsa; - yylsp = yyls = yylsa; - yystacksize = YYINITDEPTH; - - YYDPRINTF ((stderr, "Starting parse\n")); - - yystate = 0; - yyerrstatus = 0; - yynerrs = 0; - yychar = YYEMPTY; /* Cause a token to be read. */ - yylsp[0] = yylloc; - goto yysetstate; - - -/*------------------------------------------------------------. -| yynewstate -- push a new state, which is found in yystate. | -`------------------------------------------------------------*/ -yynewstate: - /* In all cases, when you get here, the value and location stacks - have just been pushed. So pushing a state here evens the stacks. */ - yyssp++; - - -/*--------------------------------------------------------------------. -| yynewstate -- set current state (the top of the stack) to yystate. | -`--------------------------------------------------------------------*/ -yysetstate: - *yyssp = (yytype_int16) yystate; - - if (yyss + yystacksize - 1 <= yyssp) -#if !defined yyoverflow && !defined YYSTACK_RELOCATE - goto yyexhaustedlab; -#else - { - /* Get the current used size of the three stacks, in elements. */ - YYSIZE_T yysize = (YYSIZE_T) (yyssp - yyss + 1); - -# if defined yyoverflow - { - /* Give user a chance to reallocate the stack. Use copies of - these so that the &'s don't force the real ones into - memory. */ - YYSTYPE *yyvs1 = yyvs; - yytype_int16 *yyss1 = yyss; - YYLTYPE *yyls1 = yyls; - - /* Each stack pointer address is followed by the size of the - data in use in that stack, in bytes. This used to be a - conditional around just the two extra args, but that might - be undefined if yyoverflow is a macro. */ - yyoverflow (YY_("memory exhausted"), - &yyss1, yysize * sizeof (*yyssp), - &yyvs1, yysize * sizeof (*yyvsp), - &yyls1, yysize * sizeof (*yylsp), - &yystacksize); - yyss = yyss1; - yyvs = yyvs1; - yyls = yyls1; - } -# else /* defined YYSTACK_RELOCATE */ - /* Extend the stack our own way. */ - if (YYMAXDEPTH <= yystacksize) - goto yyexhaustedlab; - yystacksize *= 2; - if (YYMAXDEPTH < yystacksize) - yystacksize = YYMAXDEPTH; - - { - yytype_int16 *yyss1 = yyss; - union yyalloc *yyptr = - (union yyalloc *) YYSTACK_ALLOC (YYSTACK_BYTES (yystacksize)); - if (! yyptr) - goto yyexhaustedlab; - YYSTACK_RELOCATE (yyss_alloc, yyss); - YYSTACK_RELOCATE (yyvs_alloc, yyvs); - YYSTACK_RELOCATE (yyls_alloc, yyls); -# undef YYSTACK_RELOCATE - if (yyss1 != yyssa) - YYSTACK_FREE (yyss1); - } -# endif - - yyssp = yyss + yysize - 1; - yyvsp = yyvs + yysize - 1; - yylsp = yyls + yysize - 1; - - YYDPRINTF ((stderr, "Stack size increased to %lu\n", - (unsigned long) yystacksize)); - - if (yyss + yystacksize - 1 <= yyssp) - YYABORT; - } -#endif /* !defined yyoverflow && !defined YYSTACK_RELOCATE */ - - YYDPRINTF ((stderr, "Entering state %d\n", yystate)); - - if (yystate == YYFINAL) - YYACCEPT; - - goto yybackup; - - -/*-----------. -| yybackup. | -`-----------*/ -yybackup: - /* Do appropriate processing given the current state. Read a - lookahead token if we need one and don't already have one. */ - - /* First try to decide what to do without reference to lookahead token. */ - yyn = yypact[yystate]; - if (yypact_value_is_default (yyn)) - goto yydefault; - - /* Not known => get a lookahead token if don't already have one. */ - - /* YYCHAR is either YYEMPTY or YYEOF or a valid lookahead symbol. */ - if (yychar == YYEMPTY) - { - YYDPRINTF ((stderr, "Reading a token: ")); - yychar = yylex (&yylval, &yylloc, ctx_scanner); - } - - if (yychar <= YYEOF) - { - yychar = yytoken = YYEOF; - YYDPRINTF ((stderr, "Now at end of input.\n")); - } - else - { - yytoken = YYTRANSLATE (yychar); - YY_SYMBOL_PRINT ("Next token is", yytoken, &yylval, &yylloc); - } - - /* If the proper action on seeing token YYTOKEN is to reduce or to - detect an error, take that action. */ - yyn += yytoken; - if (yyn < 0 || YYLAST < yyn || yycheck[yyn] != yytoken) - goto yydefault; - yyn = yytable[yyn]; - if (yyn <= 0) - { - if (yytable_value_is_error (yyn)) - goto yyerrlab; - yyn = -yyn; - goto yyreduce; - } - - /* Count tokens shifted since error; after three, turn off error - status. */ - if (yyerrstatus) - yyerrstatus--; - - /* Shift the lookahead token. */ - YY_SYMBOL_PRINT ("Shifting", yytoken, &yylval, &yylloc); - - /* Discard the shifted token. */ - yychar = YYEMPTY; - - yystate = yyn; - YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN - *++yyvsp = yylval; - YY_IGNORE_MAYBE_UNINITIALIZED_END - *++yylsp = yylloc; - goto yynewstate; - - -/*-----------------------------------------------------------. -| yydefault -- do the default action for the current state. | -`-----------------------------------------------------------*/ -yydefault: - yyn = yydefact[yystate]; - if (yyn == 0) - goto yyerrlab; - goto yyreduce; - - -/*-----------------------------. -| yyreduce -- do a reduction. | -`-----------------------------*/ -yyreduce: - /* yyn is the number of a rule to reduce with. */ - yylen = yyr2[yyn]; - - /* If YYLEN is nonzero, implement the default value of the action: - '$$ = $1'. - - Otherwise, the following line sets YYVAL to garbage. - This behavior is undocumented and Bison - users should not rely upon it. Assigning to YYVAL - unconditionally makes the parser a bit smaller, and it avoids a - GCC warning that YYVAL may be used uninitialized. */ - yyval = yyvsp[1-yylen]; - - /* Default location. */ - YYLLOC_DEFAULT (yyloc, (yylsp - yylen), yylen); - yyerror_range[1] = yyloc; - YY_REDUCE_PRINT (yyn); - switch (yyn) - { - case 9: -#line 58 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { xlu__cfg_set_store(ctx,(yyvsp[-2].string),XLU_OP_ASSIGNMENT,(yyvsp[0].value),(yylsp[0]).first_line); } -#line 1406 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 10: -#line 59 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { xlu__cfg_set_store(ctx,(yyvsp[-2].string),XLU_OP_ADDITION,(yyvsp[0].value),(yylsp[0]).first_line); } -#line 1412 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 13: -#line 64 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= xlu__cfg_string_mk(ctx,(yyvsp[0].string),&(yylsp[0])); } -#line 1418 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 14: -#line 65 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= (yyvsp[-1].value); } -#line 1424 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 15: -#line 67 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.string)= (yyvsp[0].string); } -#line 1430 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 16: -#line 68 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.string)= (yyvsp[0].string); } -#line 1436 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 17: -#line 70 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= xlu__cfg_list_mk(ctx,NULL,&yylloc); } -#line 1442 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 18: -#line 71 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= (yyvsp[0].value); } -#line 1448 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 19: -#line 72 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= (yyvsp[-2].value); } -#line 1454 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 20: -#line 74 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { (yyval.value)= xlu__cfg_list_mk(ctx,(yyvsp[-1].value),&(yylsp[-1])); } -#line 1460 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - case 21: -#line 75 "libxlu_cfg_y.y" /* yacc.c:1652 */ - { xlu__cfg_list_append(ctx,(yyvsp[-4].value),(yyvsp[-1].value)); (yyval.value)= (yyvsp[-4].value); } -#line 1466 "libxlu_cfg_y.c" /* yacc.c:1652 */ - break; - - -#line 1470 "libxlu_cfg_y.c" /* yacc.c:1652 */ - default: break; - } - /* User semantic actions sometimes alter yychar, and that requires - that yytoken be updated with the new translation. We take the - approach of translating immediately before every use of yytoken. - One alternative is translating here after every semantic action, - but that translation would be missed if the semantic action invokes - YYABORT, YYACCEPT, or YYERROR immediately after altering yychar or - if it invokes YYBACKUP. In the case of YYABORT or YYACCEPT, an - incorrect destructor might then be invoked immediately. In the - case of YYERROR or YYBACKUP, subsequent parser actions might lead - to an incorrect destructor call or verbose syntax error message - before the lookahead is translated. */ - YY_SYMBOL_PRINT ("-> $$ =", yyr1[yyn], &yyval, &yyloc); - - YYPOPSTACK (yylen); - yylen = 0; - YY_STACK_PRINT (yyss, yyssp); - - *++yyvsp = yyval; - *++yylsp = yyloc; - - /* Now 'shift' the result of the reduction. Determine what state - that goes to, based on the state we popped back to and the rule - number reduced by. */ - { - const int yylhs = yyr1[yyn] - YYNTOKENS; - const int yyi = yypgoto[yylhs] + *yyssp; - yystate = (0 <= yyi && yyi <= YYLAST && yycheck[yyi] == *yyssp - ? yytable[yyi] - : yydefgoto[yylhs]); - } - - goto yynewstate; - - -/*--------------------------------------. -| yyerrlab -- here on detecting error. | -`--------------------------------------*/ -yyerrlab: - /* Make sure we have latest lookahead translation. See comments at - user semantic actions for why this is necessary. */ - yytoken = yychar == YYEMPTY ? YYEMPTY : YYTRANSLATE (yychar); - - /* If not already recovering from an error, report this error. */ - if (!yyerrstatus) - { - ++yynerrs; -#if ! YYERROR_VERBOSE - yyerror (&yylloc, ctx, YY_("syntax error")); -#else -# define YYSYNTAX_ERROR yysyntax_error (&yymsg_alloc, &yymsg, \ - yyssp, yytoken) - { - char const *yymsgp = YY_("syntax error"); - int yysyntax_error_status; - yysyntax_error_status = YYSYNTAX_ERROR; - if (yysyntax_error_status == 0) - yymsgp = yymsg; - else if (yysyntax_error_status == 1) - { - if (yymsg != yymsgbuf) - YYSTACK_FREE (yymsg); - yymsg = (char *) YYSTACK_ALLOC (yymsg_alloc); - if (!yymsg) - { - yymsg = yymsgbuf; - yymsg_alloc = sizeof yymsgbuf; - yysyntax_error_status = 2; - } - else - { - yysyntax_error_status = YYSYNTAX_ERROR; - yymsgp = yymsg; - } - } - yyerror (&yylloc, ctx, yymsgp); - if (yysyntax_error_status == 2) - goto yyexhaustedlab; - } -# undef YYSYNTAX_ERROR -#endif - } - - yyerror_range[1] = yylloc; - - if (yyerrstatus == 3) - { - /* If just tried and failed to reuse lookahead token after an - error, discard it. */ - - if (yychar <= YYEOF) - { - /* Return failure if at end of input. */ - if (yychar == YYEOF) - YYABORT; - } - else - { - yydestruct ("Error: discarding", - yytoken, &yylval, &yylloc, ctx); - yychar = YYEMPTY; - } - } - - /* Else will try to reuse lookahead token after shifting the error - token. */ - goto yyerrlab1; - - -/*---------------------------------------------------. -| yyerrorlab -- error raised explicitly by YYERROR. | -`---------------------------------------------------*/ -yyerrorlab: - /* Pacify compilers when the user code never invokes YYERROR and the - label yyerrorlab therefore never appears in user code. */ - if (0) - YYERROR; - - /* Do not reclaim the symbols of the rule whose action triggered - this YYERROR. */ - YYPOPSTACK (yylen); - yylen = 0; - YY_STACK_PRINT (yyss, yyssp); - yystate = *yyssp; - goto yyerrlab1; - - -/*-------------------------------------------------------------. -| yyerrlab1 -- common code for both syntax error and YYERROR. | -`-------------------------------------------------------------*/ -yyerrlab1: - yyerrstatus = 3; /* Each real token shifted decrements this. */ - - for (;;) - { - yyn = yypact[yystate]; - if (!yypact_value_is_default (yyn)) - { - yyn += YYTERROR; - if (0 <= yyn && yyn <= YYLAST && yycheck[yyn] == YYTERROR) - { - yyn = yytable[yyn]; - if (0 < yyn) - break; - } - } - - /* Pop the current state because it cannot handle the error token. */ - if (yyssp == yyss) - YYABORT; - - yyerror_range[1] = *yylsp; - yydestruct ("Error: popping", - yystos[yystate], yyvsp, yylsp, ctx); - YYPOPSTACK (1); - yystate = *yyssp; - YY_STACK_PRINT (yyss, yyssp); - } - - YY_IGNORE_MAYBE_UNINITIALIZED_BEGIN - *++yyvsp = yylval; - YY_IGNORE_MAYBE_UNINITIALIZED_END - - yyerror_range[2] = yylloc; - /* Using YYLLOC is tempting, but would change the location of - the lookahead. YYLOC is available though. */ - YYLLOC_DEFAULT (yyloc, yyerror_range, 2); - *++yylsp = yyloc; - - /* Shift the error token. */ - YY_SYMBOL_PRINT ("Shifting", yystos[yyn], yyvsp, yylsp); - - yystate = yyn; - goto yynewstate; - - -/*-------------------------------------. -| yyacceptlab -- YYACCEPT comes here. | -`-------------------------------------*/ -yyacceptlab: - yyresult = 0; - goto yyreturn; - - -/*-----------------------------------. -| yyabortlab -- YYABORT comes here. | -`-----------------------------------*/ -yyabortlab: - yyresult = 1; - goto yyreturn; - - -#if !defined yyoverflow || YYERROR_VERBOSE -/*-------------------------------------------------. -| yyexhaustedlab -- memory exhaustion comes here. | -`-------------------------------------------------*/ -yyexhaustedlab: - yyerror (&yylloc, ctx, YY_("memory exhausted")); - yyresult = 2; - /* Fall through. */ -#endif - - -/*-----------------------------------------------------. -| yyreturn -- parsing is finished, return the result. | -`-----------------------------------------------------*/ -yyreturn: - if (yychar != YYEMPTY) - { - /* Make sure we have latest lookahead translation. See comments at - user semantic actions for why this is necessary. */ - yytoken = YYTRANSLATE (yychar); - yydestruct ("Cleanup: discarding lookahead", - yytoken, &yylval, &yylloc, ctx); - } - /* Do not reclaim the symbols of the rule whose action triggered - this YYABORT or YYACCEPT. */ - YYPOPSTACK (yylen); - YY_STACK_PRINT (yyss, yyssp); - while (yyssp != yyss) - { - yydestruct ("Cleanup: popping", - yystos[*yyssp], yyvsp, yylsp, ctx); - YYPOPSTACK (1); - } -#ifndef yyoverflow - if (yyss != yyssa) - YYSTACK_FREE (yyss); -#endif -#if YYERROR_VERBOSE - if (yymsg != yymsgbuf) - YYSTACK_FREE (yymsg); -#endif - return yyresult; -} diff --git a/tools/libs/util/libxlu_cfg_y.h b/tools/libs/util/libxlu_cfg_y.h deleted file mode 100644 index 1233cb94fc..0000000000 --- a/tools/libs/util/libxlu_cfg_y.h +++ /dev/null @@ -1,96 +0,0 @@ -/* A Bison parser, made by GNU Bison 3.3.2. */ - -/* Bison interface for Yacc-like parsers in C - - Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2019 Free Software Foundation, - Inc. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see . */ - -/* As a special exception, you may create a larger work that contains - part or all of the Bison parser skeleton and distribute that work - under terms of your choice, so long as that work isn't itself a - parser generator using the skeleton or a modified version thereof - as a parser skeleton. Alternatively, if you modify or redistribute - the parser skeleton itself, you may (at your option) remove this - special exception, which will cause the skeleton and the resulting - Bison output files to be licensed under the GNU General Public - License without this special exception. - - This special exception was added by the Free Software Foundation in - version 2.2 of Bison. */ - -/* Undocumented macros, especially those whose name start with YY_, - are private implementation details. Do not rely on them. */ - -#ifndef YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED -# define YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED -/* Debug traces. */ -#ifndef YYDEBUG -# define YYDEBUG 0 -#endif -#if YYDEBUG -extern int xlu__cfg_yydebug; -#endif - -/* Token type. */ -#ifndef YYTOKENTYPE -# define YYTOKENTYPE - enum yytokentype - { - IDENT = 258, - STRING = 259, - NUMBER = 260, - NEWLINE = 261, - OP_ADD = 262 - }; -#endif - -/* Value type. */ -#if ! defined YYSTYPE && ! defined YYSTYPE_IS_DECLARED - -union YYSTYPE -{ -#line 25 "libxlu_cfg_y.y" /* yacc.c:1921 */ - - char *string; - XLU_ConfigValue *value; - -#line 71 "libxlu_cfg_y.h" /* yacc.c:1921 */ -}; - -typedef union YYSTYPE YYSTYPE; -# define YYSTYPE_IS_TRIVIAL 1 -# define YYSTYPE_IS_DECLARED 1 -#endif - -/* Location type. */ -#if ! defined YYLTYPE && ! defined YYLTYPE_IS_DECLARED -typedef struct YYLTYPE YYLTYPE; -struct YYLTYPE -{ - int first_line; - int first_column; - int last_line; - int last_column; -}; -# define YYLTYPE_IS_DECLARED 1 -# define YYLTYPE_IS_TRIVIAL 1 -#endif - - - -int xlu__cfg_yyparse (CfgParseContext *ctx); - -#endif /* !YY_XLU_CFG_YY_LIBXLU_CFG_Y_H_INCLUDED */ diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c deleted file mode 100644 index 0b59723b71..0000000000 --- a/tools/libs/util/libxlu_disk_l.c +++ /dev/null @@ -1,2975 +0,0 @@ -#line 1 "libxlu_disk_l.c" -#define _GNU_SOURCE - -#line 4 "libxlu_disk_l.c" - -#define YY_INT_ALIGNED short int - -/* A lexical scanner generated by flex */ - -#define FLEX_SCANNER -#define YY_FLEX_MAJOR_VERSION 2 -#define YY_FLEX_MINOR_VERSION 6 -#define YY_FLEX_SUBMINOR_VERSION 4 -#if YY_FLEX_SUBMINOR_VERSION > 0 -#define FLEX_BETA -#endif - -#ifdef yy_create_buffer -#define xlu__disk_yy_create_buffer_ALREADY_DEFINED -#else -#define yy_create_buffer xlu__disk_yy_create_buffer -#endif - -#ifdef yy_delete_buffer -#define xlu__disk_yy_delete_buffer_ALREADY_DEFINED -#else -#define yy_delete_buffer xlu__disk_yy_delete_buffer -#endif - -#ifdef yy_scan_buffer -#define xlu__disk_yy_scan_buffer_ALREADY_DEFINED -#else -#define yy_scan_buffer xlu__disk_yy_scan_buffer -#endif - -#ifdef yy_scan_string -#define xlu__disk_yy_scan_string_ALREADY_DEFINED -#else -#define yy_scan_string xlu__disk_yy_scan_string -#endif - -#ifdef yy_scan_bytes -#define xlu__disk_yy_scan_bytes_ALREADY_DEFINED -#else -#define yy_scan_bytes xlu__disk_yy_scan_bytes -#endif - -#ifdef yy_init_buffer -#define xlu__disk_yy_init_buffer_ALREADY_DEFINED -#else -#define yy_init_buffer xlu__disk_yy_init_buffer -#endif - -#ifdef yy_flush_buffer -#define xlu__disk_yy_flush_buffer_ALREADY_DEFINED -#else -#define yy_flush_buffer xlu__disk_yy_flush_buffer -#endif - -#ifdef yy_load_buffer_state -#define xlu__disk_yy_load_buffer_state_ALREADY_DEFINED -#else -#define yy_load_buffer_state xlu__disk_yy_load_buffer_state -#endif - -#ifdef yy_switch_to_buffer -#define xlu__disk_yy_switch_to_buffer_ALREADY_DEFINED -#else -#define yy_switch_to_buffer xlu__disk_yy_switch_to_buffer -#endif - -#ifdef yypush_buffer_state -#define xlu__disk_yypush_buffer_state_ALREADY_DEFINED -#else -#define yypush_buffer_state xlu__disk_yypush_buffer_state -#endif - -#ifdef yypop_buffer_state -#define xlu__disk_yypop_buffer_state_ALREADY_DEFINED -#else -#define yypop_buffer_state xlu__disk_yypop_buffer_state -#endif - -#ifdef yyensure_buffer_stack -#define xlu__disk_yyensure_buffer_stack_ALREADY_DEFINED -#else -#define yyensure_buffer_stack xlu__disk_yyensure_buffer_stack -#endif - -#ifdef yylex -#define xlu__disk_yylex_ALREADY_DEFINED -#else -#define yylex xlu__disk_yylex -#endif - -#ifdef yyrestart -#define xlu__disk_yyrestart_ALREADY_DEFINED -#else -#define yyrestart xlu__disk_yyrestart -#endif - -#ifdef yylex_init -#define xlu__disk_yylex_init_ALREADY_DEFINED -#else -#define yylex_init xlu__disk_yylex_init -#endif - -#ifdef yylex_init_extra -#define xlu__disk_yylex_init_extra_ALREADY_DEFINED -#else -#define yylex_init_extra xlu__disk_yylex_init_extra -#endif - -#ifdef yylex_destroy -#define xlu__disk_yylex_destroy_ALREADY_DEFINED -#else -#define yylex_destroy xlu__disk_yylex_destroy -#endif - -#ifdef yyget_debug -#define xlu__disk_yyget_debug_ALREADY_DEFINED -#else -#define yyget_debug xlu__disk_yyget_debug -#endif - -#ifdef yyset_debug -#define xlu__disk_yyset_debug_ALREADY_DEFINED -#else -#define yyset_debug xlu__disk_yyset_debug -#endif - -#ifdef yyget_extra -#define xlu__disk_yyget_extra_ALREADY_DEFINED -#else -#define yyget_extra xlu__disk_yyget_extra -#endif - -#ifdef yyset_extra -#define xlu__disk_yyset_extra_ALREADY_DEFINED -#else -#define yyset_extra xlu__disk_yyset_extra -#endif - -#ifdef yyget_in -#define xlu__disk_yyget_in_ALREADY_DEFINED -#else -#define yyget_in xlu__disk_yyget_in -#endif - -#ifdef yyset_in -#define xlu__disk_yyset_in_ALREADY_DEFINED -#else -#define yyset_in xlu__disk_yyset_in -#endif - -#ifdef yyget_out -#define xlu__disk_yyget_out_ALREADY_DEFINED -#else -#define yyget_out xlu__disk_yyget_out -#endif - -#ifdef yyset_out -#define xlu__disk_yyset_out_ALREADY_DEFINED -#else -#define yyset_out xlu__disk_yyset_out -#endif - -#ifdef yyget_leng -#define xlu__disk_yyget_leng_ALREADY_DEFINED -#else -#define yyget_leng xlu__disk_yyget_leng -#endif - -#ifdef yyget_text -#define xlu__disk_yyget_text_ALREADY_DEFINED -#else -#define yyget_text xlu__disk_yyget_text -#endif - -#ifdef yyget_lineno -#define xlu__disk_yyget_lineno_ALREADY_DEFINED -#else -#define yyget_lineno xlu__disk_yyget_lineno -#endif - -#ifdef yyset_lineno -#define xlu__disk_yyset_lineno_ALREADY_DEFINED -#else -#define yyset_lineno xlu__disk_yyset_lineno -#endif - -#ifdef yyget_column -#define xlu__disk_yyget_column_ALREADY_DEFINED -#else -#define yyget_column xlu__disk_yyget_column -#endif - -#ifdef yyset_column -#define xlu__disk_yyset_column_ALREADY_DEFINED -#else -#define yyset_column xlu__disk_yyset_column -#endif - -#ifdef yywrap -#define xlu__disk_yywrap_ALREADY_DEFINED -#else -#define yywrap xlu__disk_yywrap -#endif - -#ifdef yyalloc -#define xlu__disk_yyalloc_ALREADY_DEFINED -#else -#define yyalloc xlu__disk_yyalloc -#endif - -#ifdef yyrealloc -#define xlu__disk_yyrealloc_ALREADY_DEFINED -#else -#define yyrealloc xlu__disk_yyrealloc -#endif - -#ifdef yyfree -#define xlu__disk_yyfree_ALREADY_DEFINED -#else -#define yyfree xlu__disk_yyfree -#endif - -/* First, we deal with platform-specific or compiler-specific issues. */ - -/* begin standard C headers. */ -#include -#include -#include -#include - -/* end standard C headers. */ - -/* flex integer type definitions */ - -#ifndef FLEXINT_H -#define FLEXINT_H - -/* C99 systems have . Non-C99 systems may or may not. */ - -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L - -/* C99 says to define __STDC_LIMIT_MACROS before including stdint.h, - * if you want the limit (max/min) macros for int types. - */ -#ifndef __STDC_LIMIT_MACROS -#define __STDC_LIMIT_MACROS 1 -#endif - -#include -typedef int8_t flex_int8_t; -typedef uint8_t flex_uint8_t; -typedef int16_t flex_int16_t; -typedef uint16_t flex_uint16_t; -typedef int32_t flex_int32_t; -typedef uint32_t flex_uint32_t; -#else -typedef signed char flex_int8_t; -typedef short int flex_int16_t; -typedef int flex_int32_t; -typedef unsigned char flex_uint8_t; -typedef unsigned short int flex_uint16_t; -typedef unsigned int flex_uint32_t; - -/* Limits of integral types. */ -#ifndef INT8_MIN -#define INT8_MIN (-128) -#endif -#ifndef INT16_MIN -#define INT16_MIN (-32767-1) -#endif -#ifndef INT32_MIN -#define INT32_MIN (-2147483647-1) -#endif -#ifndef INT8_MAX -#define INT8_MAX (127) -#endif -#ifndef INT16_MAX -#define INT16_MAX (32767) -#endif -#ifndef INT32_MAX -#define INT32_MAX (2147483647) -#endif -#ifndef UINT8_MAX -#define UINT8_MAX (255U) -#endif -#ifndef UINT16_MAX -#define UINT16_MAX (65535U) -#endif -#ifndef UINT32_MAX -#define UINT32_MAX (4294967295U) -#endif - -#ifndef SIZE_MAX -#define SIZE_MAX (~(size_t)0) -#endif - -#endif /* ! C99 */ - -#endif /* ! FLEXINT_H */ - -/* begin standard C++ headers. */ - -/* TODO: this is always defined, so inline it */ -#define yyconst const - -#if defined(__GNUC__) && __GNUC__ >= 3 -#define yynoreturn __attribute__((__noreturn__)) -#else -#define yynoreturn -#endif - -/* Returned upon end-of-file. */ -#define YY_NULL 0 - -/* Promotes a possibly negative, possibly signed char to an - * integer in range [0..255] for use as an array index. - */ -#define YY_SC_TO_UI(c) ((YY_CHAR) (c)) - -/* An opaque pointer. */ -#ifndef YY_TYPEDEF_YY_SCANNER_T -#define YY_TYPEDEF_YY_SCANNER_T -typedef void* yyscan_t; -#endif - -/* For convenience, these vars (plus the bison vars far below) - are macros in the reentrant scanner. */ -#define yyin yyg->yyin_r -#define yyout yyg->yyout_r -#define yyextra yyg->yyextra_r -#define yyleng yyg->yyleng_r -#define yytext yyg->yytext_r -#define yylineno (YY_CURRENT_BUFFER_LVALUE->yy_bs_lineno) -#define yycolumn (YY_CURRENT_BUFFER_LVALUE->yy_bs_column) -#define yy_flex_debug yyg->yy_flex_debug_r - -/* Enter a start condition. This macro really ought to take a parameter, - * but we do it the disgusting crufty way forced on us by the ()-less - * definition of BEGIN. - */ -#define BEGIN yyg->yy_start = 1 + 2 * -/* Translate the current start state into a value that can be later handed - * to BEGIN to return to the state. The YYSTATE alias is for lex - * compatibility. - */ -#define YY_START ((yyg->yy_start - 1) / 2) -#define YYSTATE YY_START -/* Action number for EOF rule of a given start state. */ -#define YY_STATE_EOF(state) (YY_END_OF_BUFFER + state + 1) -/* Special action meaning "start processing a new file". */ -#define YY_NEW_FILE yyrestart( yyin , yyscanner ) -#define YY_END_OF_BUFFER_CHAR 0 - -/* Size of default input buffer. */ -#ifndef YY_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k. - * Moreover, YY_BUF_SIZE is 2*YY_READ_BUF_SIZE in the general case. - * Ditto for the __ia64__ case accordingly. - */ -#define YY_BUF_SIZE 32768 -#else -#define YY_BUF_SIZE 16384 -#endif /* __ia64__ */ -#endif - -/* The state buf must be large enough to hold one state per character in the main buffer. - */ -#define YY_STATE_BUF_SIZE ((YY_BUF_SIZE + 2) * sizeof(yy_state_type)) - -#ifndef YY_TYPEDEF_YY_BUFFER_STATE -#define YY_TYPEDEF_YY_BUFFER_STATE -typedef struct yy_buffer_state *YY_BUFFER_STATE; -#endif - -#ifndef YY_TYPEDEF_YY_SIZE_T -#define YY_TYPEDEF_YY_SIZE_T -typedef size_t yy_size_t; -#endif - -#define EOB_ACT_CONTINUE_SCAN 0 -#define EOB_ACT_END_OF_FILE 1 -#define EOB_ACT_LAST_MATCH 2 - - #define YY_LESS_LINENO(n) - #define YY_LINENO_REWIND_TO(ptr) - -/* Return all but the first "n" matched characters back to the input stream. */ -#define yyless(n) \ - do \ - { \ - /* Undo effects of setting up yytext. */ \ - int yyless_macro_arg = (n); \ - YY_LESS_LINENO(yyless_macro_arg);\ - *yy_cp = yyg->yy_hold_char; \ - YY_RESTORE_YY_MORE_OFFSET \ - yyg->yy_c_buf_p = yy_cp = yy_bp + yyless_macro_arg - YY_MORE_ADJ; \ - YY_DO_BEFORE_ACTION; /* set up yytext again */ \ - } \ - while ( 0 ) -#define unput(c) yyunput( c, yyg->yytext_ptr , yyscanner ) - -#ifndef YY_STRUCT_YY_BUFFER_STATE -#define YY_STRUCT_YY_BUFFER_STATE -struct yy_buffer_state - { - FILE *yy_input_file; - - char *yy_ch_buf; /* input buffer */ - char *yy_buf_pos; /* current position in input buffer */ - - /* Size of input buffer in bytes, not including room for EOB - * characters. - */ - int yy_buf_size; - - /* Number of characters read into yy_ch_buf, not including EOB - * characters. - */ - int yy_n_chars; - - /* Whether we "own" the buffer - i.e., we know we created it, - * and can realloc() it to grow it, and should free() it to - * delete it. - */ - int yy_is_our_buffer; - - /* Whether this is an "interactive" input source; if so, and - * if we're using stdio for input, then we want to use getc() - * instead of fread(), to make sure we stop fetching input after - * each newline. - */ - int yy_is_interactive; - - /* Whether we're considered to be at the beginning of a line. - * If so, '^' rules will be active on the next match, otherwise - * not. - */ - int yy_at_bol; - - int yy_bs_lineno; /**< The line count. */ - int yy_bs_column; /**< The column count. */ - - /* Whether to try to fill the input buffer when we reach the - * end of it. - */ - int yy_fill_buffer; - - int yy_buffer_status; - -#define YY_BUFFER_NEW 0 -#define YY_BUFFER_NORMAL 1 - /* When an EOF's been seen but there's still some text to process - * then we mark the buffer as YY_EOF_PENDING, to indicate that we - * shouldn't try reading from the input source any more. We might - * still have a bunch of tokens to match, though, because of - * possible backing-up. - * - * When we actually see the EOF, we change the status to "new" - * (via yyrestart()), so that the user can continue scanning by - * just pointing yyin at a new input file. - */ -#define YY_BUFFER_EOF_PENDING 2 - - }; -#endif /* !YY_STRUCT_YY_BUFFER_STATE */ - -/* We provide macros for accessing buffer states in case in the - * future we want to put the buffer states in a more general - * "scanner state". - * - * Returns the top of the stack, or NULL. - */ -#define YY_CURRENT_BUFFER ( yyg->yy_buffer_stack \ - ? yyg->yy_buffer_stack[yyg->yy_buffer_stack_top] \ - : NULL) -/* Same as previous macro, but useful when we know that the buffer stack is not - * NULL or when we need an lvalue. For internal use only. - */ -#define YY_CURRENT_BUFFER_LVALUE yyg->yy_buffer_stack[yyg->yy_buffer_stack_top] - -void yyrestart ( FILE *input_file , yyscan_t yyscanner ); -void yy_switch_to_buffer ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_create_buffer ( FILE *file, int size , yyscan_t yyscanner ); -void yy_delete_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yy_flush_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yypush_buffer_state ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -void yypop_buffer_state ( yyscan_t yyscanner ); - -static void yyensure_buffer_stack ( yyscan_t yyscanner ); -static void yy_load_buffer_state ( yyscan_t yyscanner ); -static void yy_init_buffer ( YY_BUFFER_STATE b, FILE *file , yyscan_t yyscanner ); -#define YY_FLUSH_BUFFER yy_flush_buffer( YY_CURRENT_BUFFER , yyscanner) - -YY_BUFFER_STATE yy_scan_buffer ( char *base, yy_size_t size , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_string ( const char *yy_str , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_bytes ( const char *bytes, int len , yyscan_t yyscanner ); - -void *yyalloc ( yy_size_t , yyscan_t yyscanner ); -void *yyrealloc ( void *, yy_size_t , yyscan_t yyscanner ); -void yyfree ( void * , yyscan_t yyscanner ); - -#define yy_new_buffer yy_create_buffer -#define yy_set_interactive(is_interactive) \ - { \ - if ( ! YY_CURRENT_BUFFER ){ \ - yyensure_buffer_stack (yyscanner); \ - YY_CURRENT_BUFFER_LVALUE = \ - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); \ - } \ - YY_CURRENT_BUFFER_LVALUE->yy_is_interactive = is_interactive; \ - } -#define yy_set_bol(at_bol) \ - { \ - if ( ! YY_CURRENT_BUFFER ){\ - yyensure_buffer_stack (yyscanner); \ - YY_CURRENT_BUFFER_LVALUE = \ - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); \ - } \ - YY_CURRENT_BUFFER_LVALUE->yy_at_bol = at_bol; \ - } -#define YY_AT_BOL() (YY_CURRENT_BUFFER_LVALUE->yy_at_bol) - -#define xlu__disk_yywrap(yyscanner) (/*CONSTCOND*/1) -#define YY_SKIP_YYWRAP -typedef flex_uint8_t YY_CHAR; - -typedef int yy_state_type; - -#define yytext_ptr yytext_r - -static yy_state_type yy_get_previous_state ( yyscan_t yyscanner ); -static yy_state_type yy_try_NUL_trans ( yy_state_type current_state , yyscan_t yyscanner); -static int yy_get_next_buffer ( yyscan_t yyscanner ); -static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner ); - -/* Done after the current pattern has been matched and before the - * corresponding action - sets up yytext. - */ -#define YY_DO_BEFORE_ACTION \ - yyg->yytext_ptr = yy_bp; \ - yyg->yytext_ptr -= yyg->yy_more_len; \ - yyleng = (int) (yy_cp - yyg->yytext_ptr); \ - yyg->yy_hold_char = *yy_cp; \ - *yy_cp = '\0'; \ - yyg->yy_c_buf_p = yy_cp; -#define YY_NUM_RULES 37 -#define YY_END_OF_BUFFER 38 -/* This struct is not used in this scanner, - but its presence is necessary. */ -struct yy_trans_info - { - flex_int32_t yy_verify; - flex_int32_t yy_nxt; - }; -static const flex_int16_t yy_acclist[594] = - { 0, - 36, 36, 38, 34, 35, 37, 8193, 34, 35, 37, - 16385, 8193, 34, 37,16385, 34, 35, 37, 35, 37, - 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, - 35, 37, 34, 35, 37, 34, 35, 37, 34, 35, - 37, 34, 35, 37, 34, 35, 37, 34, 35, 37, - 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, - 35, 37, 34, 35, 37, 34, 35, 37, 36, 37, - 37, 34, 34, 8193, 34, 8193, 34,16385, 8193, 34, - 8193, 34, 34, 8225, 34,16417, 34, 34, 34, 34, - 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, - - 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, - 36, 8193, 34, 8193, 34, 8193, 8225, 34, 8225, 34, - 8225, 24, 34, 34, 34, 34, 34, 34, 34, 34, - 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, - 34, 34, 34, 34, 34, 34, 34, 8225, 34, 8225, - 34, 8225, 24, 34, 34, 29, 8225, 34,16417, 34, - 34, 16, 34, 34, 34, 34, 34, 34, 34, 34, - 34, 8218, 8225, 34,16410,16417, 34, 34, 32, 8225, - 34,16417, 34, 8217, 8225, 34,16409,16417, 34, 34, - 34, 8220, 8225, 34,16412,16417, 34, 34, 34, 34, - - 34, 29, 8225, 34, 29, 8225, 34, 29, 34, 29, - 8225, 34, 3, 34, 16, 34, 34, 34, 34, 34, - 31, 8225, 34,16417, 34, 34, 34, 8218, 8225, 34, - 8218, 8225, 34, 8218, 34, 8218, 8225, 34, 34, 32, - 8225, 34, 32, 8225, 34, 32, 34, 32, 8225, 8217, - 8225, 34, 8217, 8225, 34, 8217, 34, 8217, 8225, 34, - 34, 8220, 8225, 34, 8220, 8225, 34, 8220, 34, 8220, - 8225, 34, 34, 11, 34, 34, 29, 8225, 34, 29, - 8225, 34, 29, 8225, 29, 34, 29, 34, 3, 34, - 34, 34, 34, 34, 34, 34, 31, 8225, 34, 31, - - 8225, 34, 31, 34, 31, 8225, 34, 34, 30, 8225, - 34,16417, 8218, 8225, 34, 8218, 8225, 34, 8218, 8225, - 8218, 34, 8218, 34, 34, 32, 8225, 34, 32, 8225, - 34, 32, 8225, 32, 34, 32, 8217, 8225, 34, 8217, - 8225, 34, 8217, 8225, 8217, 34, 8217, 34, 34, 8220, - 8225, 34, 8220, 8225, 34, 8220, 8225, 8220, 34, 8220, - 34, 34, 11, 24, 11, 7, 34, 34, 34, 34, - 34, 34, 34, 14, 34, 31, 8225, 34, 31, 8225, - 34, 31, 8225, 31, 34, 31, 2, 34, 30, 8225, - 34, 30, 8225, 34, 30, 34, 30, 8225, 17, 34, - - 34, 12, 34, 34, 23, 11, 11, 24, 7, 24, - 7, 34, 8, 34, 34, 34, 34, 6, 34, 14, - 34, 2, 24, 2, 34, 30, 8225, 34, 30, 8225, - 34, 30, 8225, 30, 34, 30, 17, 34, 34, 12, - 24, 12, 34, 27, 8225, 34,16417, 23, 24, 23, - 7, 7, 24, 34, 8, 24, 8, 34, 34, 34, - 34, 6, 24, 6, 6, 24, 6, 24, 34, 2, - 2, 24, 34, 34, 12, 12, 24, 34, 27, 8225, - 34, 27, 8225, 34, 27, 34, 27, 8225, 23, 24, - 34, 8, 8, 24, 34, 34, 18, 19, 6, 6, - - 24, 6, 6, 34, 34, 15, 34, 34, 27, 8225, - 34, 27, 8225, 34, 27, 8225, 27, 34, 27, 34, - 34, 34, 18, 24, 18, 19, 24, 19, 6, 6, - 34, 34, 15, 34, 34, 21, 9, 20, 18, 18, - 24, 19, 19, 24, 6, 5, 6, 34, 22, 34, - 21, 24, 21, 9, 24, 9, 20, 24, 20, 4, - 6, 5, 6, 34, 22, 24, 22, 34, 21, 21, - 24, 9, 9, 24, 20, 20, 24, 4, 6, 13, - 34, 22, 22, 24, 10, 13, 34, 10, 24, 10, - 10, 10, 24 - - } ; - -static const flex_int16_t yy_accept[373] = - { 0, - 1, 1, 1, 2, 3, 4, 7, 12, 16, 19, - 21, 24, 27, 30, 33, 36, 39, 42, 45, 48, - 51, 54, 57, 60, 63, 66, 69, 71, 72, 73, - 74, 76, 79, 81, 82, 83, 84, 87, 87, 88, - 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, - 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, - 109, 110, 111, 112, 114, 116, 117, 119, 121, 122, - 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, - 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, - 143, 144, 145, 146, 147, 148, 150, 152, 153, 154, - - 155, 156, 160, 161, 162, 164, 165, 166, 167, 168, - 169, 170, 171, 172, 177, 178, 179, 183, 184, 189, - 190, 191, 192, 197, 198, 199, 200, 201, 202, 205, - 208, 210, 212, 213, 215, 217, 218, 219, 220, 221, - 225, 226, 227, 228, 231, 234, 236, 238, 239, 240, - 243, 246, 248, 250, 253, 256, 258, 260, 261, 262, - 265, 268, 270, 272, 273, 274, 275, 276, 277, 280, - 283, 285, 287, 288, 289, 291, 292, 293, 294, 295, - 296, 297, 300, 303, 305, 307, 308, 309, 313, 316, - 319, 321, 323, 324, 325, 326, 329, 332, 334, 336, - - 337, 340, 343, 345, 347, 348, 349, 350, 353, 356, - 358, 360, 361, 362, 363, 365, 366, 367, 368, 369, - 370, 371, 372, 373, 374, 376, 379, 382, 384, 386, - 387, 388, 389, 392, 395, 397, 399, 401, 402, 403, - 404, 405, 406, 407, 409, 411, 412, 413, 414, 415, - 416, 417, 418, 419, 420, 422, 424, 425, 426, 429, - 432, 434, 436, 437, 439, 440, 442, 443, 444, 448, - 450, 451, 452, 454, 455, 457, 458, 459, 460, 461, - 462, 464, 465, 467, 469, 470, 471, 473, 474, 475, - 476, 478, 479, 482, 485, 487, 489, 491, 492, 493, - - 495, 496, 497, 498, 499, 500, 502, 503, 504, 505, - 506, 508, 509, 512, 515, 517, 519, 520, 521, 522, - 523, 525, 526, 528, 529, 530, 531, 532, 533, 535, - 536, 537, 538, 539, 540, 542, 543, 545, 546, 548, - 549, 550, 551, 553, 554, 556, 557, 559, 560, 562, - 564, 565, 567, 568, 569, 570, 572, 573, 575, 576, - 578, 580, 582, 583, 585, 586, 588, 590, 591, 592, - 594, 594 - } ; - -static const YY_CHAR yy_ec[256] = - { 0, - 1, 1, 1, 1, 1, 1, 1, 1, 2, 3, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 2, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 4, 5, 1, 1, 6, 6, 7, - 6, 6, 6, 6, 6, 6, 6, 8, 1, 1, - 9, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 10, 11, 12, 13, - - 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, - 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, - 34, 19, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1 - } ; - -static const YY_CHAR yy_meta[35] = - { 0, - 1, 1, 2, 3, 1, 1, 1, 1, 4, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1 - } ; - -static const flex_int16_t yy_base[443] = - { 0, - 0, 0, 936, 935, 937, 932, 33, 36, 940, 940, - 45, 63, 31, 42, 51, 52, 925, 33, 65, 67, - 69, 70, 924, 71, 923, 75, 0, 940, 928, 940, - 91, 95, 0, 0, 104, 921, 113, 0, 91, 99, - 114, 92, 115, 80, 100, 48, 119, 121, 122, 74, - 123, 128, 131, 129, 125, 133, 135, 136, 137, 143, - 138, 145, 0, 157, 0, 0, 168, 0, 0, 926, - 140, 146, 165, 159, 152, 164, 155, 168, 171, 176, - 177, 170, 180, 175, 184, 188, 212, 191, 185, 192, - 193, 194, 219, 212, 199, 230, 0, 0, 940, 195, - - 200, 239, 235, 197, 246, 225, 226, 919, 244, 918, - 243, 236, 245, 266, 248, 264, 282, 271, 291, 248, - 270, 254, 300, 279, 296, 302, 288, 303, 311, 0, - 315, 0, 311, 318, 940, 313, 319, 208, 313, 344, - 321, 331, 325, 333, 0, 352, 0, 345, 347, 359, - 0, 361, 0, 368, 0, 370, 0, 322, 366, 379, - 0, 381, 0, 359, 357, 923, 382, 384, 392, 0, - 0, 0, 0, 387, 940, 386, 390, 392, 329, 401, - 397, 409, 0, 417, 0, 399, 412, 426, 429, 0, - 0, 0, 0, 412, 427, 438, 0, 0, 0, 0, - - 440, 0, 0, 0, 0, 436, 405, 447, 0, 0, - 0, 0, 438, 443, 922, 940, 921, 442, 450, 449, - 452, 454, 459, 458, 453, 469, 0, 0, 0, 0, - 920, 470, 481, 0, 483, 0, 484, 481, 919, 368, - 467, 495, 918, 940, 917, 940, 488, 916, 479, 490, - 492, 495, 505, 498, 940, 915, 940, 507, 523, 0, - 0, 0, 0, 940, 503, 864, 940, 846, 532, 836, - 0, 824, 940, 516, 796, 940, 513, 530, 536, 538, - 784, 940, 542, 535, 547, 772, 940, 549, 551, 768, - 940, 502, 562, 0, 564, 0, 0, 562, 764, 940, - - 544, 557, 760, 752, 744, 940, 552, 568, 571, 568, - 581, 577, 588, 0, 0, 0, 0, 589, 580, 591, - 736, 940, 728, 940, 601, 602, 597, 599, 940, 603, - 720, 712, 700, 672, 940, 665, 940, 610, 656, 603, - 648, 607, 629, 940, 627, 940, 625, 940, 624, 940, - 607, 574, 940, 614, 572, 940, 491, 940, 433, 940, - 940, 622, 389, 940, 303, 940, 261, 940, 204, 940, - 940, 635, 639, 642, 646, 650, 654, 658, 662, 666, - 670, 674, 678, 682, 686, 690, 694, 698, 702, 706, - 710, 714, 718, 722, 726, 730, 734, 738, 742, 746, - - 750, 754, 758, 762, 766, 770, 774, 778, 782, 786, - 790, 794, 798, 802, 806, 810, 814, 818, 822, 826, - 830, 834, 838, 842, 846, 850, 854, 858, 862, 866, - 870, 874, 878, 882, 886, 890, 894, 898, 902, 906, - 910, 914 - } ; - -static const flex_int16_t yy_def[443] = - { 0, - 371, 1, 372, 372, 371, 373, 374, 374, 371, 371, - 375, 375, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 376, 371, 373, 371, - 377, 374, 378, 378, 379, 12, 373, 380, 12, 12, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 376, 377, 378, 378, 381, 382, 382, 371, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 379, 12, 12, 12, - 12, 12, 12, 12, 12, 381, 382, 382, 371, 12, - - 12, 383, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 384, 87, 87, 385, 12, 386, 12, - 12, 12, 387, 12, 12, 12, 12, 12, 388, 389, - 383, 389, 12, 12, 371, 87, 12, 12, 12, 390, - 12, 12, 12, 391, 392, 384, 392, 87, 87, 393, - 394, 385, 394, 395, 396, 386, 396, 12, 12, 397, - 398, 387, 398, 12, 12, 399, 12, 12, 388, 389, - 389, 400, 400, 12, 371, 87, 87, 87, 12, 12, - 12, 401, 402, 390, 402, 12, 12, 403, 391, 392, - 392, 404, 404, 87, 87, 393, 394, 394, 405, 405, - - 395, 396, 396, 406, 406, 12, 12, 397, 398, 398, - 407, 407, 12, 12, 408, 371, 409, 87, 12, 87, - 87, 87, 12, 87, 12, 401, 402, 402, 410, 410, - 411, 87, 412, 413, 403, 413, 87, 87, 414, 12, - 12, 415, 408, 371, 416, 371, 87, 417, 12, 87, - 87, 87, 418, 87, 371, 419, 371, 87, 412, 413, - 413, 420, 420, 371, 87, 421, 371, 12, 422, 423, - 423, 416, 371, 87, 424, 371, 12, 87, 87, 87, - 425, 371, 425, 425, 87, 419, 371, 87, 87, 421, - 371, 12, 426, 427, 422, 427, 423, 87, 424, 371, - - 12, 87, 428, 429, 425, 371, 425, 425, 87, 87, - 87, 12, 426, 427, 427, 430, 430, 87, 12, 87, - 431, 371, 432, 371, 425, 425, 87, 87, 371, 12, - 433, 434, 435, 431, 371, 432, 371, 425, 425, 87, - 436, 12, 437, 371, 438, 371, 439, 371, 425, 371, - 87, 440, 371, 12, 437, 371, 438, 371, 439, 371, - 371, 87, 440, 371, 441, 371, 442, 371, 442, 371, - 0, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371 - } ; - -static const flex_int16_t yy_nxt[975] = - { 0, - 6, 7, 8, 9, 6, 6, 6, 6, 10, 11, - 12, 13, 14, 15, 16, 17, 18, 19, 17, 17, - 17, 17, 20, 17, 21, 22, 23, 24, 25, 17, - 26, 17, 17, 17, 32, 32, 33, 32, 32, 33, - 36, 34, 36, 42, 34, 29, 29, 29, 30, 35, - 50, 36, 37, 38, 43, 44, 39, 36, 80, 45, - 36, 36, 40, 29, 29, 29, 30, 35, 46, 48, - 37, 38, 41, 47, 36, 49, 36, 53, 36, 36, - 36, 56, 58, 36, 36, 55, 83, 61, 51, 36, - 54, 62, 52, 29, 65, 59, 32, 32, 33, 66, - - 36, 36, 71, 34, 29, 29, 29, 30, 36, 36, - 77, 29, 38, 67, 67, 67, 68, 67, 75, 72, - 67, 69, 73, 36, 36, 74, 78, 79, 36, 53, - 36, 36, 36, 87, 36, 76, 84, 36, 36, 85, - 36, 81, 36, 86, 36, 36, 36, 36, 82, 36, - 92, 95, 36, 100, 36, 36, 89, 90, 88, 29, - 65, 36, 91, 101, 36, 66, 90, 93, 36, 94, - 29, 97, 102, 36, 36, 104, 98, 36, 103, 36, - 36, 107, 108, 106, 36, 36, 36, 105, 86, 36, - 109, 110, 111, 36, 36, 114, 112, 36, 117, 119, - - 36, 36, 36, 36, 36, 121, 36, 368, 36, 36, - 120, 113, 29, 29, 29, 30, 118, 36, 134, 29, - 38, 36, 127, 115, 116, 122, 123, 125, 36, 126, - 128, 124, 29, 97, 36, 36, 180, 138, 98, 129, - 129, 67, 130, 129, 36, 36, 129, 132, 133, 135, - 136, 140, 36, 36, 36, 36, 142, 36, 137, 35, - 35, 123, 86, 36, 370, 143, 144, 144, 67, 145, - 144, 148, 158, 144, 147, 35, 35, 90, 119, 36, - 36, 149, 150, 150, 67, 151, 150, 159, 36, 150, - 153, 154, 154, 67, 155, 154, 164, 36, 154, 157, - - 160, 160, 67, 161, 160, 36, 368, 160, 163, 165, - 166, 36, 36, 29, 170, 167, 168, 29, 172, 171, - 36, 175, 36, 173, 35, 35, 176, 36, 36, 177, - 36, 36, 188, 174, 36, 29, 190, 178, 36, 181, - 36, 191, 223, 179, 182, 182, 67, 183, 182, 186, - 206, 182, 185, 187, 29, 192, 35, 35, 35, 35, - 193, 29, 197, 29, 199, 194, 36, 198, 36, 200, - 29, 202, 29, 204, 195, 36, 203, 36, 205, 268, - 207, 29, 209, 29, 211, 214, 213, 210, 218, 212, - 217, 36, 353, 36, 29, 170, 36, 35, 35, 219, - - 171, 35, 35, 35, 35, 224, 36, 231, 36, 225, - 36, 29, 227, 221, 36, 222, 232, 228, 220, 29, - 229, 36, 240, 35, 35, 230, 233, 233, 67, 234, - 233, 29, 190, 233, 236, 237, 348, 191, 238, 35, - 29, 197, 29, 202, 239, 36, 198, 36, 203, 29, - 209, 242, 36, 35, 247, 210, 255, 241, 248, 36, - 35, 35, 36, 35, 35, 35, 35, 253, 36, 35, - 35, 29, 227, 250, 269, 254, 36, 228, 249, 251, - 252, 35, 258, 29, 260, 29, 262, 264, 36, 261, - 265, 263, 35, 35, 346, 35, 35, 70, 271, 35, - - 35, 35, 35, 35, 35, 274, 35, 35, 282, 35, - 35, 36, 277, 278, 35, 35, 283, 284, 35, 35, - 279, 285, 36, 280, 288, 29, 260, 35, 35, 289, - 312, 261, 293, 293, 67, 294, 293, 301, 306, 293, - 296, 35, 35, 298, 303, 306, 304, 35, 35, 35, - 35, 309, 308, 36, 307, 282, 302, 319, 35, 35, - 35, 35, 35, 311, 29, 314, 29, 316, 35, 35, - 315, 282, 317, 35, 35, 344, 310, 364, 325, 35, - 35, 318, 35, 35, 329, 320, 36, 328, 332, 36, - 29, 314, 35, 35, 330, 326, 315, 331, 327, 333, - - 35, 35, 35, 35, 282, 282, 340, 341, 35, 35, - 35, 35, 36, 282, 35, 35, 36, 351, 35, 35, - 362, 339, 365, 36, 338, 366, 342, 361, 360, 354, - 358, 349, 356, 35, 35, 27, 27, 27, 27, 29, - 29, 29, 31, 31, 31, 31, 36, 36, 36, 36, - 63, 353, 63, 63, 64, 64, 64, 64, 66, 350, - 66, 66, 35, 35, 35, 35, 70, 70, 324, 70, - 96, 96, 96, 96, 98, 322, 98, 98, 131, 131, - 131, 131, 146, 146, 146, 146, 152, 152, 152, 152, - 156, 156, 156, 156, 162, 162, 162, 162, 169, 169, - - 169, 169, 171, 348, 171, 171, 184, 184, 184, 184, - 189, 189, 189, 189, 191, 346, 191, 191, 196, 196, - 196, 196, 198, 344, 198, 198, 201, 201, 201, 201, - 203, 337, 203, 203, 208, 208, 208, 208, 210, 335, - 210, 210, 215, 215, 215, 215, 173, 282, 173, 173, - 226, 226, 226, 226, 228, 324, 228, 228, 235, 235, - 235, 235, 193, 322, 193, 193, 200, 276, 200, 200, - 205, 267, 205, 205, 212, 257, 212, 212, 243, 243, - 243, 243, 245, 245, 245, 245, 230, 306, 230, 230, - 256, 256, 256, 256, 259, 259, 259, 259, 261, 300, - - 261, 261, 266, 266, 266, 266, 270, 270, 270, 270, - 272, 272, 272, 272, 275, 275, 275, 275, 281, 281, - 281, 281, 286, 286, 286, 286, 263, 246, 263, 263, - 290, 290, 290, 290, 295, 295, 295, 295, 271, 297, - 271, 271, 299, 299, 299, 299, 305, 305, 305, 305, - 313, 313, 313, 313, 315, 292, 315, 315, 321, 321, - 321, 321, 323, 323, 323, 323, 317, 291, 317, 317, - 334, 334, 334, 334, 336, 336, 336, 336, 343, 343, - 343, 343, 345, 345, 345, 345, 347, 347, 347, 347, - 352, 352, 352, 352, 355, 355, 355, 355, 357, 357, - - 357, 357, 359, 359, 359, 359, 363, 363, 363, 363, - 367, 367, 367, 367, 369, 369, 369, 369, 287, 276, - 273, 216, 267, 257, 246, 244, 216, 141, 139, 99, - 36, 30, 60, 57, 36, 30, 371, 28, 28, 5, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371 - } ; - -static const flex_int16_t yy_chk[975] = - { 0, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, - 1, 1, 1, 1, 7, 7, 7, 8, 8, 8, - 13, 7, 18, 13, 8, 11, 11, 11, 11, 11, - 18, 14, 11, 11, 13, 14, 11, 46, 46, 14, - 15, 16, 11, 12, 12, 12, 12, 12, 14, 16, - 12, 12, 12, 15, 19, 16, 20, 20, 21, 22, - 24, 22, 24, 50, 26, 21, 50, 26, 19, 44, - 20, 26, 19, 31, 31, 24, 32, 32, 32, 31, - - 39, 42, 39, 32, 35, 35, 35, 35, 40, 45, - 44, 35, 35, 37, 37, 37, 37, 37, 42, 39, - 37, 37, 40, 41, 43, 41, 45, 45, 47, 47, - 48, 49, 51, 54, 55, 43, 51, 52, 54, 52, - 53, 48, 56, 53, 57, 58, 59, 61, 49, 71, - 59, 61, 60, 71, 62, 72, 56, 62, 55, 64, - 64, 75, 58, 72, 77, 64, 57, 60, 74, 60, - 67, 67, 73, 76, 73, 75, 67, 78, 74, 82, - 79, 78, 79, 77, 84, 80, 81, 76, 80, 83, - 81, 82, 83, 85, 89, 86, 84, 86, 88, 90, - - 88, 90, 91, 92, 100, 92, 104, 369, 95, 101, - 91, 85, 87, 87, 87, 87, 89, 138, 104, 87, - 87, 94, 100, 87, 87, 93, 93, 94, 93, 95, - 101, 93, 96, 96, 106, 107, 138, 107, 96, 102, - 102, 102, 102, 102, 103, 112, 102, 102, 103, 105, - 105, 109, 111, 109, 113, 105, 111, 120, 106, 115, - 115, 122, 113, 122, 367, 112, 114, 114, 114, 114, - 114, 115, 120, 114, 114, 116, 116, 118, 118, 121, - 118, 116, 117, 117, 117, 117, 117, 121, 124, 117, - 117, 119, 119, 119, 119, 119, 124, 127, 119, 119, - - 123, 123, 123, 123, 123, 125, 365, 123, 123, 125, - 126, 126, 128, 129, 129, 127, 128, 131, 131, 129, - 133, 134, 139, 131, 136, 136, 136, 134, 137, 136, - 141, 158, 143, 133, 143, 144, 144, 136, 179, 139, - 142, 144, 179, 137, 140, 140, 140, 140, 140, 141, - 158, 140, 140, 142, 146, 146, 148, 148, 149, 149, - 146, 150, 150, 152, 152, 148, 165, 150, 164, 152, - 154, 154, 156, 156, 149, 159, 154, 240, 156, 240, - 159, 160, 160, 162, 162, 165, 164, 160, 168, 162, - 167, 167, 363, 168, 169, 169, 174, 176, 176, 174, - - 169, 177, 177, 178, 178, 180, 181, 186, 186, 181, - 180, 182, 182, 177, 207, 178, 187, 182, 176, 184, - 184, 187, 207, 194, 194, 184, 188, 188, 188, 188, - 188, 189, 189, 188, 188, 194, 359, 189, 195, 195, - 196, 196, 201, 201, 206, 206, 196, 213, 201, 208, - 208, 214, 214, 218, 218, 208, 225, 213, 219, 219, - 220, 220, 225, 221, 221, 222, 222, 223, 223, 224, - 224, 226, 226, 220, 241, 224, 241, 226, 219, 221, - 222, 232, 232, 233, 233, 235, 235, 237, 249, 233, - 238, 235, 238, 238, 357, 237, 237, 242, 242, 247, - - 247, 250, 250, 251, 251, 247, 252, 252, 253, 254, - 254, 292, 249, 250, 265, 265, 253, 253, 258, 258, - 251, 254, 277, 252, 258, 259, 259, 274, 274, 265, - 292, 259, 269, 269, 269, 269, 269, 277, 284, 269, - 269, 278, 278, 274, 279, 283, 280, 279, 279, 280, - 280, 285, 284, 301, 283, 307, 278, 301, 285, 285, - 288, 288, 289, 289, 293, 293, 295, 295, 302, 302, - 293, 308, 295, 298, 298, 355, 288, 352, 307, 310, - 310, 298, 309, 309, 311, 302, 312, 310, 319, 319, - 313, 313, 311, 311, 312, 308, 313, 318, 309, 320, - - 318, 318, 320, 320, 325, 326, 327, 328, 327, 327, - 328, 328, 330, 338, 340, 340, 342, 340, 351, 351, - 351, 326, 354, 354, 325, 362, 330, 349, 347, 342, - 345, 338, 343, 362, 362, 372, 372, 372, 372, 373, - 373, 373, 374, 374, 374, 374, 375, 375, 375, 375, - 376, 341, 376, 376, 377, 377, 377, 377, 378, 339, - 378, 378, 379, 379, 379, 379, 380, 380, 336, 380, - 381, 381, 381, 381, 382, 334, 382, 382, 383, 383, - 383, 383, 384, 384, 384, 384, 385, 385, 385, 385, - 386, 386, 386, 386, 387, 387, 387, 387, 388, 388, - - 388, 388, 389, 333, 389, 389, 390, 390, 390, 390, - 391, 391, 391, 391, 392, 332, 392, 392, 393, 393, - 393, 393, 394, 331, 394, 394, 395, 395, 395, 395, - 396, 323, 396, 396, 397, 397, 397, 397, 398, 321, - 398, 398, 399, 399, 399, 399, 400, 305, 400, 400, - 401, 401, 401, 401, 402, 304, 402, 402, 403, 403, - 403, 403, 404, 303, 404, 404, 405, 299, 405, 405, - 406, 290, 406, 406, 407, 286, 407, 407, 408, 408, - 408, 408, 409, 409, 409, 409, 410, 281, 410, 410, - 411, 411, 411, 411, 412, 412, 412, 412, 413, 275, - - 413, 413, 414, 414, 414, 414, 415, 415, 415, 415, - 416, 416, 416, 416, 417, 417, 417, 417, 418, 418, - 418, 418, 419, 419, 419, 419, 420, 272, 420, 420, - 421, 421, 421, 421, 422, 422, 422, 422, 423, 270, - 423, 423, 424, 424, 424, 424, 425, 425, 425, 425, - 426, 426, 426, 426, 427, 268, 427, 427, 428, 428, - 428, 428, 429, 429, 429, 429, 430, 266, 430, 430, - 431, 431, 431, 431, 432, 432, 432, 432, 433, 433, - 433, 433, 434, 434, 434, 434, 435, 435, 435, 435, - 436, 436, 436, 436, 437, 437, 437, 437, 438, 438, - - 438, 438, 439, 439, 439, 439, 440, 440, 440, 440, - 441, 441, 441, 441, 442, 442, 442, 442, 256, 248, - 245, 243, 239, 231, 217, 215, 166, 110, 108, 70, - 36, 29, 25, 23, 17, 6, 5, 4, 3, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, - 371, 371, 371, 371 - } ; - -#define YY_TRAILING_MASK 0x2000 -#define YY_TRAILING_HEAD_MASK 0x4000 -#define REJECT \ -{ \ -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ \ -yy_cp = yyg->yy_full_match; /* restore poss. backed-over text */ \ -yyg->yy_lp = yyg->yy_full_lp; /* restore orig. accepting pos. */ \ -yyg->yy_state_ptr = yyg->yy_full_state; /* restore orig. state */ \ -yy_current_state = *yyg->yy_state_ptr; /* restore curr. state */ \ -++yyg->yy_lp; \ -goto find_rule; \ -} - -#define yymore() (yyg->yy_more_flag = 1) -#define YY_MORE_ADJ yyg->yy_more_len -#define YY_RESTORE_YY_MORE_OFFSET -#line 1 "libxlu_disk_l.l" -/* -*- fundamental -*- */ -/* - * libxlu_disk_l.l - parser for disk specification strings - * - * Copyright (C) 2011 Citrix Ltd. - * Author Ian Jackson - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - */ -/* - * Parsing the old xm/xend/xl-4.1 disk specs is a tricky problem, - * because the target string might in theory contain "," which is the - * delimiter we use for stripping off things on the RHS, and ":", - * which is the delimiter we use for stripping off things on the LHS. - * - * In this parser we do not support such target strings in the old - * syntax; if the target string has to contain "," or ":" the new - * syntax's "target=" should be used. - */ - -#line 35 "libxlu_disk_l.l" -#include "libxlu_disk_i.h" - -#define YY_NO_INPUT - -/* The code generated by flex is missing braces in single line expressions and - * is not properly indented, which triggers the clang misleading-indentation - * check that has been made part of -Wall since clang 10. In order to safely - * disable it on clang versions that don't have the diagnostic implemented - * also disable the unknown option and pragma warning. */ -#ifdef __clang__ -# pragma clang diagnostic ignored "-Wunknown-pragmas" -# pragma clang diagnostic ignored "-Wunknown-warning-option" -# pragma clang diagnostic ignored "-Wmisleading-indentation" -#endif - -/* Some versions of flex have a bug (Fedora bugzilla 612465) which causes - * it to fail to declare these functions, which it defines. So declare - * them ourselves. Hopefully we won't have to simultaneously support - * a flex version which declares these differently somehow. */ -int xlu__disk_yyget_column(yyscan_t yyscanner); -void xlu__disk_yyset_column(int column_no, yyscan_t yyscanner); - - -/*----- useful macros and functions used in actions ----- - * we use macros in the actual rules to keep the actions short - * and particularly to avoid repeating boilerplate values such as - * DPC->disk, yytext, etc. */ - -/* Sets an enum, checking it hasn't already been set to a different value */ -#define DSET(dpc,member,enumname,str,valname) do{ \ - if (dpc->disk->member != LIBXL_DISK_##enumname##_UNKNOWN && \ - dpc->disk->member != LIBXL_DISK_##enumname##_##valname) { \ - xlu__disk_err(dpc, str, TOSTRING(member) " respecified"); \ - } else { \ - dpc->disk->member = LIBXL_DISK_##enumname##_##valname; \ - } \ - }while(0) - -/* For actions whose patterns contain '=', finds the start of the value */ -#define FROMEQUALS (strchr(yytext,'=')+1) - -/* Chops the delimiter off, modifying yytext and yyleng. */ -#define STRIP(delim) do{ \ - if (yyleng>0 && yytext[yyleng-1]==(delim)) \ - yytext[--yyleng] = 0; \ - }while(0) - -/* Sets a string value, checking it hasn't been set already. */ -#define SAVESTRING(what,loc,val) do{ \ - savestring(DPC, what " respecified", &DPC->disk->loc, (val)); \ - }while(0) -static void savestring(DiskParseContext *dpc, const char *what_respecified, - char **update, const char *value) { - if (*update) { - if (**update) { xlu__disk_err(dpc,value,what_respecified); return; } - free(*update); /* do not complain about overwriting empty strings */ - } - *update = strdup(value); -} - -#define DPC dpc /* our convention in lexer helper functions */ - -/* Sets ->readwrite from the string. This ought to be an enum, perhaps. */ -static void setaccess(DiskParseContext *dpc, const char *str) { - if (!strcmp(str, "r") || !strcmp(str, "ro")) { - dpc->disk->readwrite = 0; - } else if (!strcmp(str, "rw") || !strcmp(str, "w") || !strcmp(str,"")) { - dpc->disk->readwrite = 1; - } else { - xlu__disk_err(dpc,str,"unknown value for access"); - } -} - -/* Sets ->format from the string. IDL should provide something for this. */ -static void setformat(DiskParseContext *dpc, const char *str) { - if (!strcmp(str,"")) DSET(dpc,format,FORMAT,str,RAW); - else if (!strcmp(str,"raw")) DSET(dpc,format,FORMAT,str,RAW); - else if (!strcmp(str,"qcow")) DSET(dpc,format,FORMAT,str,QCOW); - else if (!strcmp(str,"qcow2")) DSET(dpc,format,FORMAT,str,QCOW2); - else if (!strcmp(str,"vhd")) DSET(dpc,format,FORMAT,str,VHD); - else if (!strcmp(str,"empty")) DSET(dpc,format,FORMAT,str,EMPTY); - else if (!strcmp(str,"qed")) DSET(dpc,format,FORMAT,str,QED); - else xlu__disk_err(dpc,str,"unknown value for format"); -} - -/* Sets ->backend from the string. IDL should provide something for this. */ -static void setbackendtype(DiskParseContext *dpc, const char *str) { - if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); - else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); - else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); - else if (!strcmp(str,"standalone")) DSET(dpc,backend,BACKEND,str,STANDALONE); - else xlu__disk_err(dpc,str,"unknown value for backendtype"); -} - -/* Sets ->specification from the string. IDL should provide something for this. */ -static void setspecification(DiskParseContext *dpc, const char *str) { - if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); - else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); - else xlu__disk_err(dpc,str,"unknown value for specification"); -} - -/* Sets ->colo-port from the string. COLO need this. */ -static void setcoloport(DiskParseContext *dpc, const char *str) { - int port = atoi(str); - if (port) { - dpc->disk->colo_port = port; - } else { - xlu__disk_err(dpc,str,"unknown value for colo_port"); - } -} - -#define DEPRECATE(usewhatinstead) /* not currently reported */ - -/* Handles a vdev positional parameter which includes a devtype. */ -static int vdev_and_devtype(DiskParseContext *dpc, char *str) { - /* returns 1 if it was :, 0 (doing nothing) otherwise */ - char *colon = strrchr(str, ':'); - if (!colon) - return 0; - - DEPRECATE("use `devtype=...'"); - *colon++ = 0; - SAVESTRING("vdev", vdev, str); - - if (!strcmp(colon,"cdrom")) { - DPC->disk->is_cdrom = 1; - } else if (!strcmp(colon,"disk")) { - DPC->disk->is_cdrom = 0; - } else { - xlu__disk_err(DPC,colon,"unknown deprecated type"); - } - return 1; -} - -#undef DPC /* needs to be defined differently the actual lexer */ -#define DPC ((DiskParseContext*)yyextra) - -#line 1227 "libxlu_disk_l.c" - -#line 1229 "libxlu_disk_l.c" - -#define INITIAL 0 -#define LEXERR 1 - -#ifndef YY_NO_UNISTD_H -/* Special case for "unistd.h", since it is non-ANSI. We include it way - * down here because we want the user's section 1 to have been scanned first. - * The user has a chance to override it with an option. - */ -#include -#endif - -#ifndef YY_EXTRA_TYPE -#define YY_EXTRA_TYPE void * -#endif - -/* Holds the entire state of the reentrant scanner. */ -struct yyguts_t - { - - /* User-defined. Not touched by flex. */ - YY_EXTRA_TYPE yyextra_r; - - /* The rest are the same as the globals declared in the non-reentrant scanner. */ - FILE *yyin_r, *yyout_r; - size_t yy_buffer_stack_top; /**< index of top of stack. */ - size_t yy_buffer_stack_max; /**< capacity of stack. */ - YY_BUFFER_STATE * yy_buffer_stack; /**< Stack as an array. */ - char yy_hold_char; - int yy_n_chars; - int yyleng_r; - char *yy_c_buf_p; - int yy_init; - int yy_start; - int yy_did_buffer_switch_on_eof; - int yy_start_stack_ptr; - int yy_start_stack_depth; - int *yy_start_stack; - yy_state_type yy_last_accepting_state; - char* yy_last_accepting_cpos; - - int yylineno_r; - int yy_flex_debug_r; - - yy_state_type *yy_state_buf; - yy_state_type *yy_state_ptr; - char *yy_full_match; - int yy_lp; - - /* These are only needed for trailing context rules, - * but there's no conditional variable for that yet. */ - int yy_looking_for_trail_begin; - int yy_full_lp; - int *yy_full_state; - - char *yytext_r; - int yy_more_flag; - int yy_more_len; - - }; /* end struct yyguts_t */ - -static int yy_init_globals ( yyscan_t yyscanner ); - -int yylex_init (yyscan_t* scanner); - -int yylex_init_extra ( YY_EXTRA_TYPE user_defined, yyscan_t* scanner); - -/* Accessor methods to globals. - These are made visible to non-reentrant scanners for convenience. */ - -int yylex_destroy ( yyscan_t yyscanner ); - -int yyget_debug ( yyscan_t yyscanner ); - -void yyset_debug ( int debug_flag , yyscan_t yyscanner ); - -YY_EXTRA_TYPE yyget_extra ( yyscan_t yyscanner ); - -void yyset_extra ( YY_EXTRA_TYPE user_defined , yyscan_t yyscanner ); - -FILE *yyget_in ( yyscan_t yyscanner ); - -void yyset_in ( FILE * _in_str , yyscan_t yyscanner ); - -FILE *yyget_out ( yyscan_t yyscanner ); - -void yyset_out ( FILE * _out_str , yyscan_t yyscanner ); - - int yyget_leng ( yyscan_t yyscanner ); - -char *yyget_text ( yyscan_t yyscanner ); - -int yyget_lineno ( yyscan_t yyscanner ); - -void yyset_lineno ( int _line_number , yyscan_t yyscanner ); - -int yyget_column ( yyscan_t yyscanner ); - -void yyset_column ( int _column_no , yyscan_t yyscanner ); - -/* Macros after this point can all be overridden by user definitions in - * section 1. - */ - -#ifndef YY_SKIP_YYWRAP -#ifdef __cplusplus -extern "C" int yywrap ( yyscan_t yyscanner ); -#else -extern int yywrap ( yyscan_t yyscanner ); -#endif -#endif - -#ifndef YY_NO_UNPUT - -#endif - -#ifndef yytext_ptr -static void yy_flex_strncpy ( char *, const char *, int , yyscan_t yyscanner); -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen ( const char * , yyscan_t yyscanner); -#endif - -#ifndef YY_NO_INPUT -#ifdef __cplusplus -static int yyinput ( yyscan_t yyscanner ); -#else -static int input ( yyscan_t yyscanner ); -#endif - -#endif - -/* Amount of stuff to slurp up with each read. */ -#ifndef YY_READ_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k */ -#define YY_READ_BUF_SIZE 16384 -#else -#define YY_READ_BUF_SIZE 8192 -#endif /* __ia64__ */ -#endif - -/* Copy whatever the last rule matched to the standard output. */ -#ifndef ECHO -/* This used to be an fputs(), but since the string might contain NUL's, - * we now use fwrite(). - */ -#define ECHO do { if (fwrite( yytext, (size_t) yyleng, 1, yyout )) {} } while (0) -#endif - -/* Gets input and stuffs it into "buf". number of characters read, or YY_NULL, - * is returned in "result". - */ -#ifndef YY_INPUT -#define YY_INPUT(buf,result,max_size) \ - if ( YY_CURRENT_BUFFER_LVALUE->yy_is_interactive ) \ - { \ - int c = '*'; \ - int n; \ - for ( n = 0; n < max_size && \ - (c = getc( yyin )) != EOF && c != '\n'; ++n ) \ - buf[n] = (char) c; \ - if ( c == '\n' ) \ - buf[n++] = (char) c; \ - if ( c == EOF && ferror( yyin ) ) \ - YY_FATAL_ERROR( "input in flex scanner failed" ); \ - result = n; \ - } \ - else \ - { \ - errno=0; \ - while ( (result = (int) fread(buf, 1, (yy_size_t) max_size, yyin)) == 0 && ferror(yyin)) \ - { \ - if( errno != EINTR) \ - { \ - YY_FATAL_ERROR( "input in flex scanner failed" ); \ - break; \ - } \ - errno=0; \ - clearerr(yyin); \ - } \ - }\ -\ - -#endif - -/* No semi-colon after return; correct usage is to write "yyterminate();" - - * we don't want an extra ';' after the "return" because that will cause - * some compilers to complain about unreachable statements. - */ -#ifndef yyterminate -#define yyterminate() return YY_NULL -#endif - -/* Number of entries by which start-condition stack grows. */ -#ifndef YY_START_STACK_INCR -#define YY_START_STACK_INCR 25 -#endif - -/* Report a fatal error. */ -#ifndef YY_FATAL_ERROR -#define YY_FATAL_ERROR(msg) yy_fatal_error( msg , yyscanner) -#endif - -/* end tables serialization structures and prototypes */ - -/* Default declaration of generated scanner - a define so the user can - * easily add parameters. - */ -#ifndef YY_DECL -#define YY_DECL_IS_OURS 1 - -extern int yylex (yyscan_t yyscanner); - -#define YY_DECL int yylex (yyscan_t yyscanner) -#endif /* !YY_DECL */ - -/* Code executed at the beginning of each rule, after yytext and yyleng - * have been set up. - */ -#ifndef YY_USER_ACTION -#define YY_USER_ACTION -#endif - -/* Code executed at the end of each rule. */ -#ifndef YY_BREAK -#define YY_BREAK /*LINTED*/break; -#endif - -#define YY_RULE_SETUP \ - YY_USER_ACTION - -/** The main scanner function which does all the work. - */ -YY_DECL -{ - yy_state_type yy_current_state; - char *yy_cp, *yy_bp; - int yy_act; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if ( !yyg->yy_init ) - { - yyg->yy_init = 1; - -#ifdef YY_USER_INIT - YY_USER_INIT; -#endif - - /* Create the reject buffer large enough to save one state per allowed character. */ - if ( ! yyg->yy_state_buf ) - yyg->yy_state_buf = (yy_state_type *)yyalloc(YY_STATE_BUF_SIZE , yyscanner); - if ( ! yyg->yy_state_buf ) - YY_FATAL_ERROR( "out of dynamic memory in yylex()" ); - - if ( ! yyg->yy_start ) - yyg->yy_start = 1; /* first start state */ - - if ( ! yyin ) - yyin = stdin; - - if ( ! yyout ) - yyout = stdout; - - if ( ! YY_CURRENT_BUFFER ) { - yyensure_buffer_stack (yyscanner); - YY_CURRENT_BUFFER_LVALUE = - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); - } - - yy_load_buffer_state( yyscanner ); - } - - { -#line 185 "libxlu_disk_l.l" - - -#line 188 "libxlu_disk_l.l" - /*----- the scanner rules which do the parsing -----*/ - -#line 1511 "libxlu_disk_l.c" - - while ( /*CONSTCOND*/1 ) /* loops until end-of-file is reached */ - { - yyg->yy_more_len = 0; - if ( yyg->yy_more_flag ) - { - yyg->yy_more_len = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr); - yyg->yy_more_flag = 0; - } - yy_cp = yyg->yy_c_buf_p; - - /* Support of yytext. */ - *yy_cp = yyg->yy_hold_char; - - /* yy_bp points to the position in yy_ch_buf of the start of - * the current run. - */ - yy_bp = yy_cp; - - yy_current_state = yyg->yy_start; - - yyg->yy_state_ptr = yyg->yy_state_buf; - *yyg->yy_state_ptr++ = yy_current_state; - -yy_match: - do - { - YY_CHAR yy_c = yy_ec[YY_SC_TO_UI(*yy_cp)] ; - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 372 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - *yyg->yy_state_ptr++ = yy_current_state; - ++yy_cp; - } - while ( yy_current_state != 371 ); - -yy_find_action: - yy_current_state = *--yyg->yy_state_ptr; - yyg->yy_lp = yy_accept[yy_current_state]; -find_rule: /* we branch to this label when backing up */ - for ( ; ; ) /* until we find what rule we matched */ - { - if ( yyg->yy_lp && yyg->yy_lp < yy_accept[yy_current_state + 1] ) - { - yy_act = yy_acclist[yyg->yy_lp]; - if ( yy_act & YY_TRAILING_HEAD_MASK || - yyg->yy_looking_for_trail_begin ) - { - if ( yy_act == yyg->yy_looking_for_trail_begin ) - { - yyg->yy_looking_for_trail_begin = 0; - yy_act &= ~YY_TRAILING_HEAD_MASK; - break; - } - } - else if ( yy_act & YY_TRAILING_MASK ) - { - yyg->yy_looking_for_trail_begin = yy_act & ~YY_TRAILING_MASK; - yyg->yy_looking_for_trail_begin |= YY_TRAILING_HEAD_MASK; - } - else - { - yyg->yy_full_match = yy_cp; - yyg->yy_full_state = yyg->yy_state_ptr; - yyg->yy_full_lp = yyg->yy_lp; - break; - } - ++yyg->yy_lp; - goto find_rule; - } - --yy_cp; - yy_current_state = *--yyg->yy_state_ptr; - yyg->yy_lp = yy_accept[yy_current_state]; - } - - YY_DO_BEFORE_ACTION; - -do_action: /* This label is used only to access EOF actions. */ - - switch ( yy_act ) - { /* beginning of action switch */ -case 1: -/* rule 1 can match eol */ -YY_RULE_SETUP -#line 190 "libxlu_disk_l.l" -{ /* ignore whitespace before parameters */ } - YY_BREAK -/* ordinary parameters setting enums or strings */ -case 2: -/* rule 2 can match eol */ -YY_RULE_SETUP -#line 194 "libxlu_disk_l.l" -{ STRIP(','); setformat(DPC, FROMEQUALS); } - YY_BREAK -case 3: -YY_RULE_SETUP -#line 196 "libxlu_disk_l.l" -{ DPC->disk->is_cdrom = 1; } - YY_BREAK -case 4: -YY_RULE_SETUP -#line 197 "libxlu_disk_l.l" -{ DPC->disk->is_cdrom = 1; } - YY_BREAK -case 5: -YY_RULE_SETUP -#line 198 "libxlu_disk_l.l" -{ DPC->disk->is_cdrom = 0; } - YY_BREAK -case 6: -/* rule 6 can match eol */ -YY_RULE_SETUP -#line 199 "libxlu_disk_l.l" -{ xlu__disk_err(DPC,yytext,"unknown value for type"); } - YY_BREAK -case 7: -/* rule 7 can match eol */ -YY_RULE_SETUP -#line 201 "libxlu_disk_l.l" -{ STRIP(','); setaccess(DPC, FROMEQUALS); } - YY_BREAK -case 8: -/* rule 8 can match eol */ -YY_RULE_SETUP -#line 202 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } - YY_BREAK -case 9: -/* rule 9 can match eol */ -YY_RULE_SETUP -#line 203 "libxlu_disk_l.l" -{ STRIP(','); setbackendtype(DPC,FROMEQUALS); } - YY_BREAK -case 10: -/* rule 10 can match eol */ -YY_RULE_SETUP -#line 204 "libxlu_disk_l.l" -{ STRIP(','); setspecification(DPC,FROMEQUALS); } - YY_BREAK -case 11: -/* rule 11 can match eol */ -YY_RULE_SETUP -#line 206 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } - YY_BREAK -case 12: -/* rule 12 can match eol */ -YY_RULE_SETUP -#line 207 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } - YY_BREAK -case 13: -YY_RULE_SETUP -#line 208 "libxlu_disk_l.l" -{ DPC->disk->direct_io_safe = 1; } - YY_BREAK -case 14: -YY_RULE_SETUP -#line 209 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, true); } - YY_BREAK -case 15: -YY_RULE_SETUP -#line 210 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, false); } - YY_BREAK -/* Note that the COLO configuration settings should be considered unstable. - * They may change incompatibly in future versions of Xen. */ -case 16: -YY_RULE_SETUP -#line 213 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, true); } - YY_BREAK -case 17: -YY_RULE_SETUP -#line 214 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, false); } - YY_BREAK -case 18: -/* rule 18 can match eol */ -YY_RULE_SETUP -#line 215 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } - YY_BREAK -case 19: -/* rule 19 can match eol */ -YY_RULE_SETUP -#line 216 "libxlu_disk_l.l" -{ STRIP(','); setcoloport(DPC, FROMEQUALS); } - YY_BREAK -case 20: -/* rule 20 can match eol */ -YY_RULE_SETUP -#line 217 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } - YY_BREAK -case 21: -/* rule 21 can match eol */ -YY_RULE_SETUP -#line 218 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } - YY_BREAK -case 22: -/* rule 22 can match eol */ -YY_RULE_SETUP -#line 219 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); } - YY_BREAK -/* the target magic parameter, eats the rest of the string */ -case 23: -YY_RULE_SETUP -#line 223 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); } - YY_BREAK -/* unknown parameters */ -case 24: -/* rule 24 can match eol */ -YY_RULE_SETUP -#line 227 "libxlu_disk_l.l" -{ xlu__disk_err(DPC,yytext,"unknown parameter"); } - YY_BREAK -/* deprecated prefixes */ -/* the "/.*" in these patterns ensures that they count as if they - * matched the whole string, so these patterns take precedence */ -case 25: -YY_RULE_SETUP -#line 234 "libxlu_disk_l.l" -{ - STRIP(':'); - DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'"); - setformat(DPC, yytext); - } - YY_BREAK -case 26: -YY_RULE_SETUP -#line 240 "libxlu_disk_l.l" -{ - char *newscript; - STRIP(':'); - DPC->had_depr_prefix=1; DEPRECATE("use `script=...'"); - if (asprintf(&newscript, "block-%s", yytext) < 0) { - xlu__disk_err(DPC,yytext,"unable to format script"); - return 0; - } - savestring(DPC, "script respecified", - &DPC->disk->script, newscript); - free(newscript); - } - YY_BREAK -case 27: -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ -yyg->yy_c_buf_p = yy_cp = yy_bp + 8; -YY_DO_BEFORE_ACTION; /* set up yytext again */ -YY_RULE_SETUP -#line 253 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 28: -YY_RULE_SETUP -#line 254 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 29: -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ -yyg->yy_c_buf_p = yy_cp = yy_bp + 4; -YY_DO_BEFORE_ACTION; /* set up yytext again */ -YY_RULE_SETUP -#line 255 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 30: -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ -yyg->yy_c_buf_p = yy_cp = yy_bp + 6; -YY_DO_BEFORE_ACTION; /* set up yytext again */ -YY_RULE_SETUP -#line 256 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 31: -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ -yyg->yy_c_buf_p = yy_cp = yy_bp + 5; -YY_DO_BEFORE_ACTION; /* set up yytext again */ -YY_RULE_SETUP -#line 257 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 32: -*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ -yyg->yy_c_buf_p = yy_cp = yy_bp + 4; -YY_DO_BEFORE_ACTION; /* set up yytext again */ -YY_RULE_SETUP -#line 258 "libxlu_disk_l.l" -{ DPC->had_depr_prefix=1; DEPRECATE(0); } - YY_BREAK -case 33: -/* rule 33 can match eol */ -YY_RULE_SETUP -#line 260 "libxlu_disk_l.l" -{ - xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix"); - return 0; - } - YY_BREAK -/* positional parameters */ -case 34: -/* rule 34 can match eol */ -YY_RULE_SETUP -#line 267 "libxlu_disk_l.l" -{ - STRIP(','); - - if (DPC->err) { - /* previous errors may just lead to subsequent ones */ - } else if (!DPC->disk->pdev_path) { - SAVESTRING("target", pdev_path, yytext); - } else if (!DPC->had_depr_prefix && - DPC->disk->format == LIBXL_DISK_FORMAT_UNKNOWN) { - if (!*DPC->disk->pdev_path && vdev_and_devtype(DPC,yytext)) { - DPC->disk->format = LIBXL_DISK_FORMAT_EMPTY; - } else { - setformat(DPC,yytext); - } - } else if (!DPC->disk->vdev) { - if (!vdev_and_devtype(DPC,yytext)) - SAVESTRING("vdev", vdev, yytext); - } else if (!DPC->access_set) { - DPC->access_set = 1; - setaccess(DPC,yytext); - } else { - xlu__disk_err(DPC,yytext,"too many positional parameters"); - return 0; /* don't print any more errors */ - } -} - YY_BREAK -case 35: -YY_RULE_SETUP -#line 293 "libxlu_disk_l.l" -{ - BEGIN(LEXERR); - yymore(); -} - YY_BREAK -case 36: -YY_RULE_SETUP -#line 297 "libxlu_disk_l.l" -{ - xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0; -} - YY_BREAK -case 37: -YY_RULE_SETUP -#line 300 "libxlu_disk_l.l" -YY_FATAL_ERROR( "flex scanner jammed" ); - YY_BREAK -#line 1870 "libxlu_disk_l.c" - case YY_STATE_EOF(INITIAL): - case YY_STATE_EOF(LEXERR): - yyterminate(); - - case YY_END_OF_BUFFER: - { - /* Amount of text matched not including the EOB char. */ - int yy_amount_of_matched_text = (int) (yy_cp - yyg->yytext_ptr) - 1; - - /* Undo the effects of YY_DO_BEFORE_ACTION. */ - *yy_cp = yyg->yy_hold_char; - YY_RESTORE_YY_MORE_OFFSET - - if ( YY_CURRENT_BUFFER_LVALUE->yy_buffer_status == YY_BUFFER_NEW ) - { - /* We're scanning a new file or input source. It's - * possible that this happened because the user - * just pointed yyin at a new source and called - * yylex(). If so, then we have to assure - * consistency between YY_CURRENT_BUFFER and our - * globals. Here is the right place to do so, because - * this is the first action (other than possibly a - * back-up) that will match for the new input source. - */ - yyg->yy_n_chars = YY_CURRENT_BUFFER_LVALUE->yy_n_chars; - YY_CURRENT_BUFFER_LVALUE->yy_input_file = yyin; - YY_CURRENT_BUFFER_LVALUE->yy_buffer_status = YY_BUFFER_NORMAL; - } - - /* Note that here we test for yy_c_buf_p "<=" to the position - * of the first EOB in the buffer, since yy_c_buf_p will - * already have been incremented past the NUL character - * (since all states make transitions on EOB to the - * end-of-buffer state). Contrast this with the test - * in input(). - */ - if ( yyg->yy_c_buf_p <= &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] ) - { /* This was really a NUL. */ - yy_state_type yy_next_state; - - yyg->yy_c_buf_p = yyg->yytext_ptr + yy_amount_of_matched_text; - - yy_current_state = yy_get_previous_state( yyscanner ); - - /* Okay, we're now positioned to make the NUL - * transition. We couldn't have - * yy_get_previous_state() go ahead and do it - * for us because it doesn't know how to deal - * with the possibility of jamming (and we don't - * want to build jamming into it because then it - * will run more slowly). - */ - - yy_next_state = yy_try_NUL_trans( yy_current_state , yyscanner); - - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - - if ( yy_next_state ) - { - /* Consume the NUL. */ - yy_cp = ++yyg->yy_c_buf_p; - yy_current_state = yy_next_state; - goto yy_match; - } - - else - { - yy_cp = yyg->yy_c_buf_p; - goto yy_find_action; - } - } - - else switch ( yy_get_next_buffer( yyscanner ) ) - { - case EOB_ACT_END_OF_FILE: - { - yyg->yy_did_buffer_switch_on_eof = 0; - - if ( yywrap( yyscanner ) ) - { - /* Note: because we've taken care in - * yy_get_next_buffer() to have set up - * yytext, we can now set up - * yy_c_buf_p so that if some total - * hoser (like flex itself) wants to - * call the scanner after we return the - * YY_NULL, it'll still work - another - * YY_NULL will get returned. - */ - yyg->yy_c_buf_p = yyg->yytext_ptr + YY_MORE_ADJ; - - yy_act = YY_STATE_EOF(YY_START); - goto do_action; - } - - else - { - if ( ! yyg->yy_did_buffer_switch_on_eof ) - YY_NEW_FILE; - } - break; - } - - case EOB_ACT_CONTINUE_SCAN: - yyg->yy_c_buf_p = - yyg->yytext_ptr + yy_amount_of_matched_text; - - yy_current_state = yy_get_previous_state( yyscanner ); - - yy_cp = yyg->yy_c_buf_p; - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - goto yy_match; - - case EOB_ACT_LAST_MATCH: - yyg->yy_c_buf_p = - &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars]; - - yy_current_state = yy_get_previous_state( yyscanner ); - - yy_cp = yyg->yy_c_buf_p; - yy_bp = yyg->yytext_ptr + YY_MORE_ADJ; - goto yy_find_action; - } - break; - } - - default: - YY_FATAL_ERROR( - "fatal flex scanner internal error--no action found" ); - } /* end of action switch */ - } /* end of scanning one token */ - } /* end of user's declarations */ -} /* end of yylex */ - -/* yy_get_next_buffer - try to read in a new buffer - * - * Returns a code representing an action: - * EOB_ACT_LAST_MATCH - - * EOB_ACT_CONTINUE_SCAN - continue scanning from current position - * EOB_ACT_END_OF_FILE - end of file - */ -static int yy_get_next_buffer (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - char *dest = YY_CURRENT_BUFFER_LVALUE->yy_ch_buf; - char *source = yyg->yytext_ptr; - int number_to_move, i; - int ret_val; - - if ( yyg->yy_c_buf_p > &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars + 1] ) - YY_FATAL_ERROR( - "fatal flex scanner internal error--end of buffer missed" ); - - if ( YY_CURRENT_BUFFER_LVALUE->yy_fill_buffer == 0 ) - { /* Don't try to fill the buffer, so this is an EOF. */ - if ( yyg->yy_c_buf_p - yyg->yytext_ptr - YY_MORE_ADJ == 1 ) - { - /* We matched a single character, the EOB, so - * treat this as a final EOF. - */ - return EOB_ACT_END_OF_FILE; - } - - else - { - /* We matched some text prior to the EOB, first - * process it. - */ - return EOB_ACT_LAST_MATCH; - } - } - - /* Try to read more data. */ - - /* First move last chars to start of buffer. */ - number_to_move = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr - 1); - - for ( i = 0; i < number_to_move; ++i ) - *(dest++) = *(source++); - - if ( YY_CURRENT_BUFFER_LVALUE->yy_buffer_status == YY_BUFFER_EOF_PENDING ) - /* don't do the read, it's not guaranteed to return an EOF, - * just force an EOF - */ - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars = 0; - - else - { - int num_to_read = - YY_CURRENT_BUFFER_LVALUE->yy_buf_size - number_to_move - 1; - - while ( num_to_read <= 0 ) - { /* Not enough room in the buffer - grow it. */ - - YY_FATAL_ERROR( -"input buffer overflow, can't enlarge buffer because scanner uses REJECT" ); - - } - - if ( num_to_read > YY_READ_BUF_SIZE ) - num_to_read = YY_READ_BUF_SIZE; - - /* Read in more data. */ - YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), - yyg->yy_n_chars, num_to_read ); - - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - if ( yyg->yy_n_chars == 0 ) - { - if ( number_to_move == YY_MORE_ADJ ) - { - ret_val = EOB_ACT_END_OF_FILE; - yyrestart( yyin , yyscanner); - } - - else - { - ret_val = EOB_ACT_LAST_MATCH; - YY_CURRENT_BUFFER_LVALUE->yy_buffer_status = - YY_BUFFER_EOF_PENDING; - } - } - - else - ret_val = EOB_ACT_CONTINUE_SCAN; - - if ((yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) { - /* Extend the array by 50%, plus the number we really need. */ - int new_size = yyg->yy_n_chars + number_to_move + (yyg->yy_n_chars >> 1); - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf = (char *) yyrealloc( - (void *) YY_CURRENT_BUFFER_LVALUE->yy_ch_buf, (yy_size_t) new_size , yyscanner ); - if ( ! YY_CURRENT_BUFFER_LVALUE->yy_ch_buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_get_next_buffer()" ); - /* "- 2" to take care of EOB's */ - YY_CURRENT_BUFFER_LVALUE->yy_buf_size = (int) (new_size - 2); - } - - yyg->yy_n_chars += number_to_move; - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] = YY_END_OF_BUFFER_CHAR; - YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars + 1] = YY_END_OF_BUFFER_CHAR; - - yyg->yytext_ptr = &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[0]; - - return ret_val; -} - -/* yy_get_previous_state - get the state just before the EOB char was reached */ - - static yy_state_type yy_get_previous_state (yyscan_t yyscanner) -{ - yy_state_type yy_current_state; - char *yy_cp; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - yy_current_state = yyg->yy_start; - - yyg->yy_state_ptr = yyg->yy_state_buf; - *yyg->yy_state_ptr++ = yy_current_state; - - for ( yy_cp = yyg->yytext_ptr + YY_MORE_ADJ; yy_cp < yyg->yy_c_buf_p; ++yy_cp ) - { - YY_CHAR yy_c = (*yy_cp ? yy_ec[YY_SC_TO_UI(*yy_cp)] : 1); - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 372 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - *yyg->yy_state_ptr++ = yy_current_state; - } - - return yy_current_state; -} - -/* yy_try_NUL_trans - try to make a transition on the NUL character - * - * synopsis - * next_state = yy_try_NUL_trans( current_state ); - */ - static yy_state_type yy_try_NUL_trans (yy_state_type yy_current_state , yyscan_t yyscanner) -{ - int yy_is_jam; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; /* This var may be unused depending upon options. */ - - YY_CHAR yy_c = 1; - while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) - { - yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 372 ) - yy_c = yy_meta[yy_c]; - } - yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - yy_is_jam = (yy_current_state == 371); - if ( ! yy_is_jam ) - *yyg->yy_state_ptr++ = yy_current_state; - - (void)yyg; - return yy_is_jam ? 0 : yy_current_state; -} - -#ifndef YY_NO_UNPUT - -#endif - -#ifndef YY_NO_INPUT -#ifdef __cplusplus - static int yyinput (yyscan_t yyscanner) -#else - static int input (yyscan_t yyscanner) -#endif - -{ - int c; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - *yyg->yy_c_buf_p = yyg->yy_hold_char; - - if ( *yyg->yy_c_buf_p == YY_END_OF_BUFFER_CHAR ) - { - /* yy_c_buf_p now points to the character we want to return. - * If this occurs *before* the EOB characters, then it's a - * valid NUL; if not, then we've hit the end of the buffer. - */ - if ( yyg->yy_c_buf_p < &YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[yyg->yy_n_chars] ) - /* This was really a NUL. */ - *yyg->yy_c_buf_p = '\0'; - - else - { /* need more input */ - int offset = (int) (yyg->yy_c_buf_p - yyg->yytext_ptr); - ++yyg->yy_c_buf_p; - - switch ( yy_get_next_buffer( yyscanner ) ) - { - case EOB_ACT_LAST_MATCH: - /* This happens because yy_g_n_b() - * sees that we've accumulated a - * token and flags that we need to - * try matching the token before - * proceeding. But for input(), - * there's no matching to consider. - * So convert the EOB_ACT_LAST_MATCH - * to EOB_ACT_END_OF_FILE. - */ - - /* Reset buffer status. */ - yyrestart( yyin , yyscanner); - - /*FALLTHROUGH*/ - - case EOB_ACT_END_OF_FILE: - { - if ( yywrap( yyscanner ) ) - return 0; - - if ( ! yyg->yy_did_buffer_switch_on_eof ) - YY_NEW_FILE; -#ifdef __cplusplus - return yyinput(yyscanner); -#else - return input(yyscanner); -#endif - } - - case EOB_ACT_CONTINUE_SCAN: - yyg->yy_c_buf_p = yyg->yytext_ptr + offset; - break; - } - } - } - - c = *(unsigned char *) yyg->yy_c_buf_p; /* cast for 8-bit char's */ - *yyg->yy_c_buf_p = '\0'; /* preserve yytext */ - yyg->yy_hold_char = *++yyg->yy_c_buf_p; - - return c; -} -#endif /* ifndef YY_NO_INPUT */ - -/** Immediately switch to a different input stream. - * @param input_file A readable stream. - * @param yyscanner The scanner object. - * @note This function does not reset the start condition to @c INITIAL . - */ - void yyrestart (FILE * input_file , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if ( ! YY_CURRENT_BUFFER ){ - yyensure_buffer_stack (yyscanner); - YY_CURRENT_BUFFER_LVALUE = - yy_create_buffer( yyin, YY_BUF_SIZE , yyscanner); - } - - yy_init_buffer( YY_CURRENT_BUFFER, input_file , yyscanner); - yy_load_buffer_state( yyscanner ); -} - -/** Switch to a different input buffer. - * @param new_buffer The new input buffer. - * @param yyscanner The scanner object. - */ - void yy_switch_to_buffer (YY_BUFFER_STATE new_buffer , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* TODO. We should be able to replace this entire function body - * with - * yypop_buffer_state(); - * yypush_buffer_state(new_buffer); - */ - yyensure_buffer_stack (yyscanner); - if ( YY_CURRENT_BUFFER == new_buffer ) - return; - - if ( YY_CURRENT_BUFFER ) - { - /* Flush out information for old buffer. */ - *yyg->yy_c_buf_p = yyg->yy_hold_char; - YY_CURRENT_BUFFER_LVALUE->yy_buf_pos = yyg->yy_c_buf_p; - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - YY_CURRENT_BUFFER_LVALUE = new_buffer; - yy_load_buffer_state( yyscanner ); - - /* We don't actually know whether we did this switch during - * EOF (yywrap()) processing, but the only time this flag - * is looked at is after yywrap() is called, so it's safe - * to go ahead and always set it. - */ - yyg->yy_did_buffer_switch_on_eof = 1; -} - -static void yy_load_buffer_state (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyg->yy_n_chars = YY_CURRENT_BUFFER_LVALUE->yy_n_chars; - yyg->yytext_ptr = yyg->yy_c_buf_p = YY_CURRENT_BUFFER_LVALUE->yy_buf_pos; - yyin = YY_CURRENT_BUFFER_LVALUE->yy_input_file; - yyg->yy_hold_char = *yyg->yy_c_buf_p; -} - -/** Allocate and initialize an input buffer state. - * @param file A readable stream. - * @param size The character buffer size in bytes. When in doubt, use @c YY_BUF_SIZE. - * @param yyscanner The scanner object. - * @return the allocated buffer state. - */ - YY_BUFFER_STATE yy_create_buffer (FILE * file, int size , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - - b = (YY_BUFFER_STATE) yyalloc( sizeof( struct yy_buffer_state ) , yyscanner ); - if ( ! b ) - YY_FATAL_ERROR( "out of dynamic memory in yy_create_buffer()" ); - - b->yy_buf_size = size; - - /* yy_ch_buf has to be 2 characters longer than the size given because - * we need to put in 2 end-of-buffer characters. - */ - b->yy_ch_buf = (char *) yyalloc( (yy_size_t) (b->yy_buf_size + 2) , yyscanner ); - if ( ! b->yy_ch_buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_create_buffer()" ); - - b->yy_is_our_buffer = 1; - - yy_init_buffer( b, file , yyscanner); - - return b; -} - -/** Destroy the buffer. - * @param b a buffer created with yy_create_buffer() - * @param yyscanner The scanner object. - */ - void yy_delete_buffer (YY_BUFFER_STATE b , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if ( ! b ) - return; - - if ( b == YY_CURRENT_BUFFER ) /* Not sure if we should pop here. */ - YY_CURRENT_BUFFER_LVALUE = (YY_BUFFER_STATE) 0; - - if ( b->yy_is_our_buffer ) - yyfree( (void *) b->yy_ch_buf , yyscanner ); - - yyfree( (void *) b , yyscanner ); -} - -/* Initializes or reinitializes a buffer. - * This function is sometimes called more than once on the same buffer, - * such as during a yyrestart() or at EOF. - */ - static void yy_init_buffer (YY_BUFFER_STATE b, FILE * file , yyscan_t yyscanner) - -{ - int oerrno = errno; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - yy_flush_buffer( b , yyscanner); - - b->yy_input_file = file; - b->yy_fill_buffer = 1; - - /* If b is the current buffer, then yy_init_buffer was _probably_ - * called from yyrestart() or through yy_get_next_buffer. - * In that case, we don't want to reset the lineno or column. - */ - if (b != YY_CURRENT_BUFFER){ - b->yy_bs_lineno = 1; - b->yy_bs_column = 0; - } - - b->yy_is_interactive = file ? (isatty( fileno(file) ) > 0) : 0; - - errno = oerrno; -} - -/** Discard all buffered characters. On the next scan, YY_INPUT will be called. - * @param b the buffer state to be flushed, usually @c YY_CURRENT_BUFFER. - * @param yyscanner The scanner object. - */ - void yy_flush_buffer (YY_BUFFER_STATE b , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if ( ! b ) - return; - - b->yy_n_chars = 0; - - /* We always need two end-of-buffer characters. The first causes - * a transition to the end-of-buffer state. The second causes - * a jam in that state. - */ - b->yy_ch_buf[0] = YY_END_OF_BUFFER_CHAR; - b->yy_ch_buf[1] = YY_END_OF_BUFFER_CHAR; - - b->yy_buf_pos = &b->yy_ch_buf[0]; - - b->yy_at_bol = 1; - b->yy_buffer_status = YY_BUFFER_NEW; - - if ( b == YY_CURRENT_BUFFER ) - yy_load_buffer_state( yyscanner ); -} - -/** Pushes the new state onto the stack. The new state becomes - * the current state. This function will allocate the stack - * if necessary. - * @param new_buffer The new state. - * @param yyscanner The scanner object. - */ -void yypush_buffer_state (YY_BUFFER_STATE new_buffer , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if (new_buffer == NULL) - return; - - yyensure_buffer_stack(yyscanner); - - /* This block is copied from yy_switch_to_buffer. */ - if ( YY_CURRENT_BUFFER ) - { - /* Flush out information for old buffer. */ - *yyg->yy_c_buf_p = yyg->yy_hold_char; - YY_CURRENT_BUFFER_LVALUE->yy_buf_pos = yyg->yy_c_buf_p; - YY_CURRENT_BUFFER_LVALUE->yy_n_chars = yyg->yy_n_chars; - } - - /* Only push if top exists. Otherwise, replace top. */ - if (YY_CURRENT_BUFFER) - yyg->yy_buffer_stack_top++; - YY_CURRENT_BUFFER_LVALUE = new_buffer; - - /* copied from yy_switch_to_buffer. */ - yy_load_buffer_state( yyscanner ); - yyg->yy_did_buffer_switch_on_eof = 1; -} - -/** Removes and deletes the top of the stack, if present. - * The next element becomes the new top. - * @param yyscanner The scanner object. - */ -void yypop_buffer_state (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - if (!YY_CURRENT_BUFFER) - return; - - yy_delete_buffer(YY_CURRENT_BUFFER , yyscanner); - YY_CURRENT_BUFFER_LVALUE = NULL; - if (yyg->yy_buffer_stack_top > 0) - --yyg->yy_buffer_stack_top; - - if (YY_CURRENT_BUFFER) { - yy_load_buffer_state( yyscanner ); - yyg->yy_did_buffer_switch_on_eof = 1; - } -} - -/* Allocates the stack if it does not exist. - * Guarantees space for at least one push. - */ -static void yyensure_buffer_stack (yyscan_t yyscanner) -{ - yy_size_t num_to_alloc; - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (!yyg->yy_buffer_stack) { - - /* First allocation is just for 2 elements, since we don't know if this - * scanner will even need a stack. We use 2 instead of 1 to avoid an - * immediate realloc on the next call. - */ - num_to_alloc = 1; /* After all that talk, this was set to 1 anyways... */ - yyg->yy_buffer_stack = (struct yy_buffer_state**)yyalloc - (num_to_alloc * sizeof(struct yy_buffer_state*) - , yyscanner); - if ( ! yyg->yy_buffer_stack ) - YY_FATAL_ERROR( "out of dynamic memory in yyensure_buffer_stack()" ); - - memset(yyg->yy_buffer_stack, 0, num_to_alloc * sizeof(struct yy_buffer_state*)); - - yyg->yy_buffer_stack_max = num_to_alloc; - yyg->yy_buffer_stack_top = 0; - return; - } - - if (yyg->yy_buffer_stack_top >= (yyg->yy_buffer_stack_max) - 1){ - - /* Increase the buffer to prepare for a possible push. */ - yy_size_t grow_size = 8 /* arbitrary grow size */; - - num_to_alloc = yyg->yy_buffer_stack_max + grow_size; - yyg->yy_buffer_stack = (struct yy_buffer_state**)yyrealloc - (yyg->yy_buffer_stack, - num_to_alloc * sizeof(struct yy_buffer_state*) - , yyscanner); - if ( ! yyg->yy_buffer_stack ) - YY_FATAL_ERROR( "out of dynamic memory in yyensure_buffer_stack()" ); - - /* zero only the new slots.*/ - memset(yyg->yy_buffer_stack + yyg->yy_buffer_stack_max, 0, grow_size * sizeof(struct yy_buffer_state*)); - yyg->yy_buffer_stack_max = num_to_alloc; - } -} - -/** Setup the input buffer state to scan directly from a user-specified character buffer. - * @param base the character buffer - * @param size the size in bytes of the character buffer - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - */ -YY_BUFFER_STATE yy_scan_buffer (char * base, yy_size_t size , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - - if ( size < 2 || - base[size-2] != YY_END_OF_BUFFER_CHAR || - base[size-1] != YY_END_OF_BUFFER_CHAR ) - /* They forgot to leave room for the EOB's. */ - return NULL; - - b = (YY_BUFFER_STATE) yyalloc( sizeof( struct yy_buffer_state ) , yyscanner ); - if ( ! b ) - YY_FATAL_ERROR( "out of dynamic memory in yy_scan_buffer()" ); - - b->yy_buf_size = (int) (size - 2); /* "- 2" to take care of EOB's */ - b->yy_buf_pos = b->yy_ch_buf = base; - b->yy_is_our_buffer = 0; - b->yy_input_file = NULL; - b->yy_n_chars = b->yy_buf_size; - b->yy_is_interactive = 0; - b->yy_at_bol = 1; - b->yy_fill_buffer = 0; - b->yy_buffer_status = YY_BUFFER_NEW; - - yy_switch_to_buffer( b , yyscanner ); - - return b; -} - -/** Setup the input buffer state to scan a string. The next call to yylex() will - * scan from a @e copy of @a str. - * @param yystr a NUL-terminated string to scan - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - * @note If you want to scan bytes that may contain NUL values, then use - * yy_scan_bytes() instead. - */ -YY_BUFFER_STATE yy_scan_string (const char * yystr , yyscan_t yyscanner) -{ - - return yy_scan_bytes( yystr, (int) strlen(yystr) , yyscanner); -} - -/** Setup the input buffer state to scan the given bytes. The next call to yylex() will - * scan from a @e copy of @a bytes. - * @param yybytes the byte buffer to scan - * @param _yybytes_len the number of bytes in the buffer pointed to by @a bytes. - * @param yyscanner The scanner object. - * @return the newly allocated buffer state object. - */ -YY_BUFFER_STATE yy_scan_bytes (const char * yybytes, int _yybytes_len , yyscan_t yyscanner) -{ - YY_BUFFER_STATE b; - char *buf; - yy_size_t n; - int i; - - /* Get memory for full buffer, including space for trailing EOB's. */ - n = (yy_size_t) (_yybytes_len + 2); - buf = (char *) yyalloc( n , yyscanner ); - if ( ! buf ) - YY_FATAL_ERROR( "out of dynamic memory in yy_scan_bytes()" ); - - for ( i = 0; i < _yybytes_len; ++i ) - buf[i] = yybytes[i]; - - buf[_yybytes_len] = buf[_yybytes_len+1] = YY_END_OF_BUFFER_CHAR; - - b = yy_scan_buffer( buf, n , yyscanner); - if ( ! b ) - YY_FATAL_ERROR( "bad buffer in yy_scan_bytes()" ); - - /* It's okay to grow etc. this buffer, and we should throw it - * away when we're done. - */ - b->yy_is_our_buffer = 1; - - return b; -} - -#ifndef YY_EXIT_FAILURE -#define YY_EXIT_FAILURE 2 -#endif - -static void yynoreturn yy_fatal_error (const char* msg , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - fprintf( stderr, "%s\n", msg ); - exit( YY_EXIT_FAILURE ); -} - -/* Redefine yyless() so it works in section 3 code. */ - -#undef yyless -#define yyless(n) \ - do \ - { \ - /* Undo effects of setting up yytext. */ \ - int yyless_macro_arg = (n); \ - YY_LESS_LINENO(yyless_macro_arg);\ - yytext[yyleng] = yyg->yy_hold_char; \ - yyg->yy_c_buf_p = yytext + yyless_macro_arg; \ - yyg->yy_hold_char = *yyg->yy_c_buf_p; \ - *yyg->yy_c_buf_p = '\0'; \ - yyleng = yyless_macro_arg; \ - } \ - while ( 0 ) - -/* Accessor methods (get/set functions) to struct members. */ - -/** Get the user-defined data for this scanner. - * @param yyscanner The scanner object. - */ -YY_EXTRA_TYPE yyget_extra (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyextra; -} - -/** Get the current line number. - * @param yyscanner The scanner object. - */ -int yyget_lineno (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (! YY_CURRENT_BUFFER) - return 0; - - return yylineno; -} - -/** Get the current column number. - * @param yyscanner The scanner object. - */ -int yyget_column (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - if (! YY_CURRENT_BUFFER) - return 0; - - return yycolumn; -} - -/** Get the input stream. - * @param yyscanner The scanner object. - */ -FILE *yyget_in (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyin; -} - -/** Get the output stream. - * @param yyscanner The scanner object. - */ -FILE *yyget_out (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyout; -} - -/** Get the length of the current token. - * @param yyscanner The scanner object. - */ -int yyget_leng (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yyleng; -} - -/** Get the current token. - * @param yyscanner The scanner object. - */ - -char *yyget_text (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yytext; -} - -/** Set the user-defined data. This data is never touched by the scanner. - * @param user_defined The data to be associated with this scanner. - * @param yyscanner The scanner object. - */ -void yyset_extra (YY_EXTRA_TYPE user_defined , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyextra = user_defined ; -} - -/** Set the current line number. - * @param _line_number line number - * @param yyscanner The scanner object. - */ -void yyset_lineno (int _line_number , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* lineno is only valid if an input buffer exists. */ - if (! YY_CURRENT_BUFFER ) - YY_FATAL_ERROR( "yyset_lineno called with no buffer" ); - - yylineno = _line_number; -} - -/** Set the current column. - * @param _column_no column number - * @param yyscanner The scanner object. - */ -void yyset_column (int _column_no , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* column is only valid if an input buffer exists. */ - if (! YY_CURRENT_BUFFER ) - YY_FATAL_ERROR( "yyset_column called with no buffer" ); - - yycolumn = _column_no; -} - -/** Set the input stream. This does not discard the current - * input buffer. - * @param _in_str A readable stream. - * @param yyscanner The scanner object. - * @see yy_switch_to_buffer - */ -void yyset_in (FILE * _in_str , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyin = _in_str ; -} - -void yyset_out (FILE * _out_str , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yyout = _out_str ; -} - -int yyget_debug (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - return yy_flex_debug; -} - -void yyset_debug (int _bdebug , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - yy_flex_debug = _bdebug ; -} - -/* Accessor methods for yylval and yylloc */ - -/* User-visible API */ - -/* yylex_init is special because it creates the scanner itself, so it is - * the ONLY reentrant function that doesn't take the scanner as the last argument. - * That's why we explicitly handle the declaration, instead of using our macros. - */ -int yylex_init(yyscan_t* ptr_yy_globals) -{ - if (ptr_yy_globals == NULL){ - errno = EINVAL; - return 1; - } - - *ptr_yy_globals = (yyscan_t) yyalloc ( sizeof( struct yyguts_t ), NULL ); - - if (*ptr_yy_globals == NULL){ - errno = ENOMEM; - return 1; - } - - /* By setting to 0xAA, we expose bugs in yy_init_globals. Leave at 0x00 for releases. */ - memset(*ptr_yy_globals,0x00,sizeof(struct yyguts_t)); - - return yy_init_globals ( *ptr_yy_globals ); -} - -/* yylex_init_extra has the same functionality as yylex_init, but follows the - * convention of taking the scanner as the last argument. Note however, that - * this is a *pointer* to a scanner, as it will be allocated by this call (and - * is the reason, too, why this function also must handle its own declaration). - * The user defined value in the first argument will be available to yyalloc in - * the yyextra field. - */ -int yylex_init_extra( YY_EXTRA_TYPE yy_user_defined, yyscan_t* ptr_yy_globals ) -{ - struct yyguts_t dummy_yyguts; - - yyset_extra (yy_user_defined, &dummy_yyguts); - - if (ptr_yy_globals == NULL){ - errno = EINVAL; - return 1; - } - - *ptr_yy_globals = (yyscan_t) yyalloc ( sizeof( struct yyguts_t ), &dummy_yyguts ); - - if (*ptr_yy_globals == NULL){ - errno = ENOMEM; - return 1; - } - - /* By setting to 0xAA, we expose bugs in - yy_init_globals. Leave at 0x00 for releases. */ - memset(*ptr_yy_globals,0x00,sizeof(struct yyguts_t)); - - yyset_extra (yy_user_defined, *ptr_yy_globals); - - return yy_init_globals ( *ptr_yy_globals ); -} - -static int yy_init_globals (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - /* Initialization is the same as for the non-reentrant scanner. - * This function is called from yylex_destroy(), so don't allocate here. - */ - - yyg->yy_buffer_stack = NULL; - yyg->yy_buffer_stack_top = 0; - yyg->yy_buffer_stack_max = 0; - yyg->yy_c_buf_p = NULL; - yyg->yy_init = 0; - yyg->yy_start = 0; - - yyg->yy_start_stack_ptr = 0; - yyg->yy_start_stack_depth = 0; - yyg->yy_start_stack = NULL; - - yyg->yy_state_buf = 0; - yyg->yy_state_ptr = 0; - yyg->yy_full_match = 0; - yyg->yy_lp = 0; - -/* Defined in main.c */ -#ifdef YY_STDINIT - yyin = stdin; - yyout = stdout; -#else - yyin = NULL; - yyout = NULL; -#endif - - /* For future reference: Set errno on error, since we are called by - * yylex_init() - */ - return 0; -} - -/* yylex_destroy is for both reentrant and non-reentrant scanners. */ -int yylex_destroy (yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - - /* Pop the buffer stack, destroying each element. */ - while(YY_CURRENT_BUFFER){ - yy_delete_buffer( YY_CURRENT_BUFFER , yyscanner ); - YY_CURRENT_BUFFER_LVALUE = NULL; - yypop_buffer_state(yyscanner); - } - - /* Destroy the stack itself. */ - yyfree(yyg->yy_buffer_stack , yyscanner); - yyg->yy_buffer_stack = NULL; - - /* Destroy the start condition stack. */ - yyfree( yyg->yy_start_stack , yyscanner ); - yyg->yy_start_stack = NULL; - - yyfree ( yyg->yy_state_buf , yyscanner); - yyg->yy_state_buf = NULL; - - /* Reset the globals. This is important in a non-reentrant scanner so the next time - * yylex() is called, initialization will occur. */ - yy_init_globals( yyscanner); - - /* Destroy the main struct (reentrant only). */ - yyfree ( yyscanner , yyscanner ); - yyscanner = NULL; - return 0; -} - -/* - * Internal utility routines. - */ - -#ifndef yytext_ptr -static void yy_flex_strncpy (char* s1, const char * s2, int n , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - - int i; - for ( i = 0; i < n; ++i ) - s1[i] = s2[i]; -} -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen (const char * s , yyscan_t yyscanner) -{ - int n; - for ( n = 0; s[n]; ++n ) - ; - - return n; -} -#endif - -void *yyalloc (yy_size_t size , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - return malloc(size); -} - -void *yyrealloc (void * ptr, yy_size_t size , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - - /* The cast to (char *) in the following accommodates both - * implementations that use char* generic pointers, and those - * that use void* generic pointers. It works with the latter - * because both ANSI C and C++ allow castless assignment from - * any pointer type to void*, and deal with argument conversions - * as though doing an assignment. - */ - return realloc(ptr, size); -} - -void yyfree (void * ptr , yyscan_t yyscanner) -{ - struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; - (void)yyg; - free( (char *) ptr ); /* see yyrealloc() for (char *) cast */ -} - -#define YYTABLES_NAME "yytables" - -#line 300 "libxlu_disk_l.l" diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h deleted file mode 100644 index 509aad67dc..0000000000 --- a/tools/libs/util/libxlu_disk_l.h +++ /dev/null @@ -1,701 +0,0 @@ -#ifndef xlu__disk_yyHEADER_H -#define xlu__disk_yyHEADER_H 1 -#define xlu__disk_yyIN_HEADER 1 - -#line 5 "libxlu_disk_l.h" -#define _GNU_SOURCE - -#line 8 "libxlu_disk_l.h" - -#define YY_INT_ALIGNED short int - -/* A lexical scanner generated by flex */ - -#define FLEX_SCANNER -#define YY_FLEX_MAJOR_VERSION 2 -#define YY_FLEX_MINOR_VERSION 6 -#define YY_FLEX_SUBMINOR_VERSION 4 -#if YY_FLEX_SUBMINOR_VERSION > 0 -#define FLEX_BETA -#endif - -#ifdef yy_create_buffer -#define xlu__disk_yy_create_buffer_ALREADY_DEFINED -#else -#define yy_create_buffer xlu__disk_yy_create_buffer -#endif - -#ifdef yy_delete_buffer -#define xlu__disk_yy_delete_buffer_ALREADY_DEFINED -#else -#define yy_delete_buffer xlu__disk_yy_delete_buffer -#endif - -#ifdef yy_scan_buffer -#define xlu__disk_yy_scan_buffer_ALREADY_DEFINED -#else -#define yy_scan_buffer xlu__disk_yy_scan_buffer -#endif - -#ifdef yy_scan_string -#define xlu__disk_yy_scan_string_ALREADY_DEFINED -#else -#define yy_scan_string xlu__disk_yy_scan_string -#endif - -#ifdef yy_scan_bytes -#define xlu__disk_yy_scan_bytes_ALREADY_DEFINED -#else -#define yy_scan_bytes xlu__disk_yy_scan_bytes -#endif - -#ifdef yy_init_buffer -#define xlu__disk_yy_init_buffer_ALREADY_DEFINED -#else -#define yy_init_buffer xlu__disk_yy_init_buffer -#endif - -#ifdef yy_flush_buffer -#define xlu__disk_yy_flush_buffer_ALREADY_DEFINED -#else -#define yy_flush_buffer xlu__disk_yy_flush_buffer -#endif - -#ifdef yy_load_buffer_state -#define xlu__disk_yy_load_buffer_state_ALREADY_DEFINED -#else -#define yy_load_buffer_state xlu__disk_yy_load_buffer_state -#endif - -#ifdef yy_switch_to_buffer -#define xlu__disk_yy_switch_to_buffer_ALREADY_DEFINED -#else -#define yy_switch_to_buffer xlu__disk_yy_switch_to_buffer -#endif - -#ifdef yypush_buffer_state -#define xlu__disk_yypush_buffer_state_ALREADY_DEFINED -#else -#define yypush_buffer_state xlu__disk_yypush_buffer_state -#endif - -#ifdef yypop_buffer_state -#define xlu__disk_yypop_buffer_state_ALREADY_DEFINED -#else -#define yypop_buffer_state xlu__disk_yypop_buffer_state -#endif - -#ifdef yyensure_buffer_stack -#define xlu__disk_yyensure_buffer_stack_ALREADY_DEFINED -#else -#define yyensure_buffer_stack xlu__disk_yyensure_buffer_stack -#endif - -#ifdef yylex -#define xlu__disk_yylex_ALREADY_DEFINED -#else -#define yylex xlu__disk_yylex -#endif - -#ifdef yyrestart -#define xlu__disk_yyrestart_ALREADY_DEFINED -#else -#define yyrestart xlu__disk_yyrestart -#endif - -#ifdef yylex_init -#define xlu__disk_yylex_init_ALREADY_DEFINED -#else -#define yylex_init xlu__disk_yylex_init -#endif - -#ifdef yylex_init_extra -#define xlu__disk_yylex_init_extra_ALREADY_DEFINED -#else -#define yylex_init_extra xlu__disk_yylex_init_extra -#endif - -#ifdef yylex_destroy -#define xlu__disk_yylex_destroy_ALREADY_DEFINED -#else -#define yylex_destroy xlu__disk_yylex_destroy -#endif - -#ifdef yyget_debug -#define xlu__disk_yyget_debug_ALREADY_DEFINED -#else -#define yyget_debug xlu__disk_yyget_debug -#endif - -#ifdef yyset_debug -#define xlu__disk_yyset_debug_ALREADY_DEFINED -#else -#define yyset_debug xlu__disk_yyset_debug -#endif - -#ifdef yyget_extra -#define xlu__disk_yyget_extra_ALREADY_DEFINED -#else -#define yyget_extra xlu__disk_yyget_extra -#endif - -#ifdef yyset_extra -#define xlu__disk_yyset_extra_ALREADY_DEFINED -#else -#define yyset_extra xlu__disk_yyset_extra -#endif - -#ifdef yyget_in -#define xlu__disk_yyget_in_ALREADY_DEFINED -#else -#define yyget_in xlu__disk_yyget_in -#endif - -#ifdef yyset_in -#define xlu__disk_yyset_in_ALREADY_DEFINED -#else -#define yyset_in xlu__disk_yyset_in -#endif - -#ifdef yyget_out -#define xlu__disk_yyget_out_ALREADY_DEFINED -#else -#define yyget_out xlu__disk_yyget_out -#endif - -#ifdef yyset_out -#define xlu__disk_yyset_out_ALREADY_DEFINED -#else -#define yyset_out xlu__disk_yyset_out -#endif - -#ifdef yyget_leng -#define xlu__disk_yyget_leng_ALREADY_DEFINED -#else -#define yyget_leng xlu__disk_yyget_leng -#endif - -#ifdef yyget_text -#define xlu__disk_yyget_text_ALREADY_DEFINED -#else -#define yyget_text xlu__disk_yyget_text -#endif - -#ifdef yyget_lineno -#define xlu__disk_yyget_lineno_ALREADY_DEFINED -#else -#define yyget_lineno xlu__disk_yyget_lineno -#endif - -#ifdef yyset_lineno -#define xlu__disk_yyset_lineno_ALREADY_DEFINED -#else -#define yyset_lineno xlu__disk_yyset_lineno -#endif - -#ifdef yyget_column -#define xlu__disk_yyget_column_ALREADY_DEFINED -#else -#define yyget_column xlu__disk_yyget_column -#endif - -#ifdef yyset_column -#define xlu__disk_yyset_column_ALREADY_DEFINED -#else -#define yyset_column xlu__disk_yyset_column -#endif - -#ifdef yywrap -#define xlu__disk_yywrap_ALREADY_DEFINED -#else -#define yywrap xlu__disk_yywrap -#endif - -#ifdef yyalloc -#define xlu__disk_yyalloc_ALREADY_DEFINED -#else -#define yyalloc xlu__disk_yyalloc -#endif - -#ifdef yyrealloc -#define xlu__disk_yyrealloc_ALREADY_DEFINED -#else -#define yyrealloc xlu__disk_yyrealloc -#endif - -#ifdef yyfree -#define xlu__disk_yyfree_ALREADY_DEFINED -#else -#define yyfree xlu__disk_yyfree -#endif - -/* First, we deal with platform-specific or compiler-specific issues. */ - -/* begin standard C headers. */ -#include -#include -#include -#include - -/* end standard C headers. */ - -/* flex integer type definitions */ - -#ifndef FLEXINT_H -#define FLEXINT_H - -/* C99 systems have . Non-C99 systems may or may not. */ - -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L - -/* C99 says to define __STDC_LIMIT_MACROS before including stdint.h, - * if you want the limit (max/min) macros for int types. - */ -#ifndef __STDC_LIMIT_MACROS -#define __STDC_LIMIT_MACROS 1 -#endif - -#include -typedef int8_t flex_int8_t; -typedef uint8_t flex_uint8_t; -typedef int16_t flex_int16_t; -typedef uint16_t flex_uint16_t; -typedef int32_t flex_int32_t; -typedef uint32_t flex_uint32_t; -#else -typedef signed char flex_int8_t; -typedef short int flex_int16_t; -typedef int flex_int32_t; -typedef unsigned char flex_uint8_t; -typedef unsigned short int flex_uint16_t; -typedef unsigned int flex_uint32_t; - -/* Limits of integral types. */ -#ifndef INT8_MIN -#define INT8_MIN (-128) -#endif -#ifndef INT16_MIN -#define INT16_MIN (-32767-1) -#endif -#ifndef INT32_MIN -#define INT32_MIN (-2147483647-1) -#endif -#ifndef INT8_MAX -#define INT8_MAX (127) -#endif -#ifndef INT16_MAX -#define INT16_MAX (32767) -#endif -#ifndef INT32_MAX -#define INT32_MAX (2147483647) -#endif -#ifndef UINT8_MAX -#define UINT8_MAX (255U) -#endif -#ifndef UINT16_MAX -#define UINT16_MAX (65535U) -#endif -#ifndef UINT32_MAX -#define UINT32_MAX (4294967295U) -#endif - -#ifndef SIZE_MAX -#define SIZE_MAX (~(size_t)0) -#endif - -#endif /* ! C99 */ - -#endif /* ! FLEXINT_H */ - -/* begin standard C++ headers. */ - -/* TODO: this is always defined, so inline it */ -#define yyconst const - -#if defined(__GNUC__) && __GNUC__ >= 3 -#define yynoreturn __attribute__((__noreturn__)) -#else -#define yynoreturn -#endif - -/* An opaque pointer. */ -#ifndef YY_TYPEDEF_YY_SCANNER_T -#define YY_TYPEDEF_YY_SCANNER_T -typedef void* yyscan_t; -#endif - -/* For convenience, these vars (plus the bison vars far below) - are macros in the reentrant scanner. */ -#define yyin yyg->yyin_r -#define yyout yyg->yyout_r -#define yyextra yyg->yyextra_r -#define yyleng yyg->yyleng_r -#define yytext yyg->yytext_r -#define yylineno (YY_CURRENT_BUFFER_LVALUE->yy_bs_lineno) -#define yycolumn (YY_CURRENT_BUFFER_LVALUE->yy_bs_column) -#define yy_flex_debug yyg->yy_flex_debug_r - -/* Size of default input buffer. */ -#ifndef YY_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k. - * Moreover, YY_BUF_SIZE is 2*YY_READ_BUF_SIZE in the general case. - * Ditto for the __ia64__ case accordingly. - */ -#define YY_BUF_SIZE 32768 -#else -#define YY_BUF_SIZE 16384 -#endif /* __ia64__ */ -#endif - -#ifndef YY_TYPEDEF_YY_BUFFER_STATE -#define YY_TYPEDEF_YY_BUFFER_STATE -typedef struct yy_buffer_state *YY_BUFFER_STATE; -#endif - -#ifndef YY_TYPEDEF_YY_SIZE_T -#define YY_TYPEDEF_YY_SIZE_T -typedef size_t yy_size_t; -#endif - -#ifndef YY_STRUCT_YY_BUFFER_STATE -#define YY_STRUCT_YY_BUFFER_STATE -struct yy_buffer_state - { - FILE *yy_input_file; - - char *yy_ch_buf; /* input buffer */ - char *yy_buf_pos; /* current position in input buffer */ - - /* Size of input buffer in bytes, not including room for EOB - * characters. - */ - int yy_buf_size; - - /* Number of characters read into yy_ch_buf, not including EOB - * characters. - */ - int yy_n_chars; - - /* Whether we "own" the buffer - i.e., we know we created it, - * and can realloc() it to grow it, and should free() it to - * delete it. - */ - int yy_is_our_buffer; - - /* Whether this is an "interactive" input source; if so, and - * if we're using stdio for input, then we want to use getc() - * instead of fread(), to make sure we stop fetching input after - * each newline. - */ - int yy_is_interactive; - - /* Whether we're considered to be at the beginning of a line. - * If so, '^' rules will be active on the next match, otherwise - * not. - */ - int yy_at_bol; - - int yy_bs_lineno; /**< The line count. */ - int yy_bs_column; /**< The column count. */ - - /* Whether to try to fill the input buffer when we reach the - * end of it. - */ - int yy_fill_buffer; - - int yy_buffer_status; - - }; -#endif /* !YY_STRUCT_YY_BUFFER_STATE */ - -void yyrestart ( FILE *input_file , yyscan_t yyscanner ); -void yy_switch_to_buffer ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_create_buffer ( FILE *file, int size , yyscan_t yyscanner ); -void yy_delete_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yy_flush_buffer ( YY_BUFFER_STATE b , yyscan_t yyscanner ); -void yypush_buffer_state ( YY_BUFFER_STATE new_buffer , yyscan_t yyscanner ); -void yypop_buffer_state ( yyscan_t yyscanner ); - -YY_BUFFER_STATE yy_scan_buffer ( char *base, yy_size_t size , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_string ( const char *yy_str , yyscan_t yyscanner ); -YY_BUFFER_STATE yy_scan_bytes ( const char *bytes, int len , yyscan_t yyscanner ); - -void *yyalloc ( yy_size_t , yyscan_t yyscanner ); -void *yyrealloc ( void *, yy_size_t , yyscan_t yyscanner ); -void yyfree ( void * , yyscan_t yyscanner ); - -#define xlu__disk_yywrap(yyscanner) (/*CONSTCOND*/1) -#define YY_SKIP_YYWRAP - -#define yytext_ptr yytext_r - -#ifdef YY_HEADER_EXPORT_START_CONDITIONS -#define INITIAL 0 -#define LEXERR 1 - -#endif - -#ifndef YY_NO_UNISTD_H -/* Special case for "unistd.h", since it is non-ANSI. We include it way - * down here because we want the user's section 1 to have been scanned first. - * The user has a chance to override it with an option. - */ -#include -#endif - -#ifndef YY_EXTRA_TYPE -#define YY_EXTRA_TYPE void * -#endif - -int yylex_init (yyscan_t* scanner); - -int yylex_init_extra ( YY_EXTRA_TYPE user_defined, yyscan_t* scanner); - -/* Accessor methods to globals. - These are made visible to non-reentrant scanners for convenience. */ - -int yylex_destroy ( yyscan_t yyscanner ); - -int yyget_debug ( yyscan_t yyscanner ); - -void yyset_debug ( int debug_flag , yyscan_t yyscanner ); - -YY_EXTRA_TYPE yyget_extra ( yyscan_t yyscanner ); - -void yyset_extra ( YY_EXTRA_TYPE user_defined , yyscan_t yyscanner ); - -FILE *yyget_in ( yyscan_t yyscanner ); - -void yyset_in ( FILE * _in_str , yyscan_t yyscanner ); - -FILE *yyget_out ( yyscan_t yyscanner ); - -void yyset_out ( FILE * _out_str , yyscan_t yyscanner ); - - int yyget_leng ( yyscan_t yyscanner ); - -char *yyget_text ( yyscan_t yyscanner ); - -int yyget_lineno ( yyscan_t yyscanner ); - -void yyset_lineno ( int _line_number , yyscan_t yyscanner ); - -int yyget_column ( yyscan_t yyscanner ); - -void yyset_column ( int _column_no , yyscan_t yyscanner ); - -/* Macros after this point can all be overridden by user definitions in - * section 1. - */ - -#ifndef YY_SKIP_YYWRAP -#ifdef __cplusplus -extern "C" int yywrap ( yyscan_t yyscanner ); -#else -extern int yywrap ( yyscan_t yyscanner ); -#endif -#endif - -#ifndef yytext_ptr -static void yy_flex_strncpy ( char *, const char *, int , yyscan_t yyscanner); -#endif - -#ifdef YY_NEED_STRLEN -static int yy_flex_strlen ( const char * , yyscan_t yyscanner); -#endif - -#ifndef YY_NO_INPUT - -#endif - -/* Amount of stuff to slurp up with each read. */ -#ifndef YY_READ_BUF_SIZE -#ifdef __ia64__ -/* On IA-64, the buffer size is 16k, not 8k */ -#define YY_READ_BUF_SIZE 16384 -#else -#define YY_READ_BUF_SIZE 8192 -#endif /* __ia64__ */ -#endif - -/* Number of entries by which start-condition stack grows. */ -#ifndef YY_START_STACK_INCR -#define YY_START_STACK_INCR 25 -#endif - -/* Default declaration of generated scanner - a define so the user can - * easily add parameters. - */ -#ifndef YY_DECL -#define YY_DECL_IS_OURS 1 - -extern int yylex (yyscan_t yyscanner); - -#define YY_DECL int yylex (yyscan_t yyscanner) -#endif /* !YY_DECL */ - -/* yy_get_previous_state - get the state just before the EOB char was reached */ - -#undef YY_NEW_FILE -#undef YY_FLUSH_BUFFER -#undef yy_set_bol -#undef yy_new_buffer -#undef yy_set_interactive -#undef YY_DO_BEFORE_ACTION - -#ifdef YY_DECL_IS_OURS -#undef YY_DECL_IS_OURS -#undef YY_DECL -#endif - -#ifndef xlu__disk_yy_create_buffer_ALREADY_DEFINED -#undef yy_create_buffer -#endif -#ifndef xlu__disk_yy_delete_buffer_ALREADY_DEFINED -#undef yy_delete_buffer -#endif -#ifndef xlu__disk_yy_scan_buffer_ALREADY_DEFINED -#undef yy_scan_buffer -#endif -#ifndef xlu__disk_yy_scan_string_ALREADY_DEFINED -#undef yy_scan_string -#endif -#ifndef xlu__disk_yy_scan_bytes_ALREADY_DEFINED -#undef yy_scan_bytes -#endif -#ifndef xlu__disk_yy_init_buffer_ALREADY_DEFINED -#undef yy_init_buffer -#endif -#ifndef xlu__disk_yy_flush_buffer_ALREADY_DEFINED -#undef yy_flush_buffer -#endif -#ifndef xlu__disk_yy_load_buffer_state_ALREADY_DEFINED -#undef yy_load_buffer_state -#endif -#ifndef xlu__disk_yy_switch_to_buffer_ALREADY_DEFINED -#undef yy_switch_to_buffer -#endif -#ifndef xlu__disk_yypush_buffer_state_ALREADY_DEFINED -#undef yypush_buffer_state -#endif -#ifndef xlu__disk_yypop_buffer_state_ALREADY_DEFINED -#undef yypop_buffer_state -#endif -#ifndef xlu__disk_yyensure_buffer_stack_ALREADY_DEFINED -#undef yyensure_buffer_stack -#endif -#ifndef xlu__disk_yylex_ALREADY_DEFINED -#undef yylex -#endif -#ifndef xlu__disk_yyrestart_ALREADY_DEFINED -#undef yyrestart -#endif -#ifndef xlu__disk_yylex_init_ALREADY_DEFINED -#undef yylex_init -#endif -#ifndef xlu__disk_yylex_init_extra_ALREADY_DEFINED -#undef yylex_init_extra -#endif -#ifndef xlu__disk_yylex_destroy_ALREADY_DEFINED -#undef yylex_destroy -#endif -#ifndef xlu__disk_yyget_debug_ALREADY_DEFINED -#undef yyget_debug -#endif -#ifndef xlu__disk_yyset_debug_ALREADY_DEFINED -#undef yyset_debug -#endif -#ifndef xlu__disk_yyget_extra_ALREADY_DEFINED -#undef yyget_extra -#endif -#ifndef xlu__disk_yyset_extra_ALREADY_DEFINED -#undef yyset_extra -#endif -#ifndef xlu__disk_yyget_in_ALREADY_DEFINED -#undef yyget_in -#endif -#ifndef xlu__disk_yyset_in_ALREADY_DEFINED -#undef yyset_in -#endif -#ifndef xlu__disk_yyget_out_ALREADY_DEFINED -#undef yyget_out -#endif -#ifndef xlu__disk_yyset_out_ALREADY_DEFINED -#undef yyset_out -#endif -#ifndef xlu__disk_yyget_leng_ALREADY_DEFINED -#undef yyget_leng -#endif -#ifndef xlu__disk_yyget_text_ALREADY_DEFINED -#undef yyget_text -#endif -#ifndef xlu__disk_yyget_lineno_ALREADY_DEFINED -#undef yyget_lineno -#endif -#ifndef xlu__disk_yyset_lineno_ALREADY_DEFINED -#undef yyset_lineno -#endif -#ifndef xlu__disk_yyget_column_ALREADY_DEFINED -#undef yyget_column -#endif -#ifndef xlu__disk_yyset_column_ALREADY_DEFINED -#undef yyset_column -#endif -#ifndef xlu__disk_yywrap_ALREADY_DEFINED -#undef yywrap -#endif -#ifndef xlu__disk_yyget_lval_ALREADY_DEFINED -#undef yyget_lval -#endif -#ifndef xlu__disk_yyset_lval_ALREADY_DEFINED -#undef yyset_lval -#endif -#ifndef xlu__disk_yyget_lloc_ALREADY_DEFINED -#undef yyget_lloc -#endif -#ifndef xlu__disk_yyset_lloc_ALREADY_DEFINED -#undef yyset_lloc -#endif -#ifndef xlu__disk_yyalloc_ALREADY_DEFINED -#undef yyalloc -#endif -#ifndef xlu__disk_yyrealloc_ALREADY_DEFINED -#undef yyrealloc -#endif -#ifndef xlu__disk_yyfree_ALREADY_DEFINED -#undef yyfree -#endif -#ifndef xlu__disk_yytext_ALREADY_DEFINED -#undef yytext -#endif -#ifndef xlu__disk_yyleng_ALREADY_DEFINED -#undef yyleng -#endif -#ifndef xlu__disk_yyin_ALREADY_DEFINED -#undef yyin -#endif -#ifndef xlu__disk_yyout_ALREADY_DEFINED -#undef yyout -#endif -#ifndef xlu__disk_yy_flex_debug_ALREADY_DEFINED -#undef yy_flex_debug -#endif -#ifndef xlu__disk_yylineno_ALREADY_DEFINED -#undef yylineno -#endif -#ifndef xlu__disk_yytables_fload_ALREADY_DEFINED -#undef yytables_fload -#endif -#ifndef xlu__disk_yytables_destroy_ALREADY_DEFINED -#undef yytables_destroy -#endif -#ifndef xlu__disk_yyTABLES_NAME_ALREADY_DEFINED -#undef yyTABLES_NAME -#endif - -#line 300 "libxlu_disk_l.l" - -#line 699 "libxlu_disk_l.h" -#undef xlu__disk_yyIN_HEADER -#endif /* xlu__disk_yyHEADER_H */ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 07 16:15:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 16:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491334.760409 (Exim 4.92) (envelope-from ) id 1pPQct-0000sc-0u; Tue, 07 Feb 2023 16:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491334.760409; Tue, 07 Feb 2023 16:15:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQcs-0000sV-UO; Tue, 07 Feb 2023 16:15:22 +0000 Received: by outflank-mailman (input) for mailman id 491334; Tue, 07 Feb 2023 16:15:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQcs-0000sJ-Fl; Tue, 07 Feb 2023 16:15:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQcs-0006MJ-C2; Tue, 07 Feb 2023 16:15:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPQcr-00012B-Qs; Tue, 07 Feb 2023 16:15:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPQcr-0007ea-QQ; Tue, 07 Feb 2023 16:15:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oWdVmHrOG6ShYwn+9oMSUGV86fsYSRM88ab4XMMYAyg=; b=l5/WGD6dAPgLE1AMM/lLYu1+2y uQZriutBvKcoWOcE+wV5zHJ/HISJgbKpwIzq615a1Byw2Q1MMow5qVtbqrtdU4RJr+LAIqPXuz95Y OAFqWTX0QkP2JFZh3bfLpFqcg+bH+og304ATTuBNJkhb+8jWCWS8Ov3OE3KiQjze74MM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176438: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Tue, 07 Feb 2023 16:15:21 +0000 flight 176438 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/176438/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 176106 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 176413 pass in 176438 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176413 pass in 176438 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 176413 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 176413 like 176090 test-arm64-arm64-xl 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 176413 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 176413 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 176413 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 176413 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 176413 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 176413 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 176413 never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 176413 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 176413 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 176413 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 176413 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 176413 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 13 days Testing same since 176413 2023-02-06 07:13:34 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4165 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 07 17:01:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 17:01:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491347.760423 (Exim 4.92) (envelope-from ) id 1pPRLi-0006RI-K7; Tue, 07 Feb 2023 17:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491347.760423; Tue, 07 Feb 2023 17:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRLi-0006RB-HB; Tue, 07 Feb 2023 17:01:42 +0000 Received: by outflank-mailman (input) for mailman id 491347; Tue, 07 Feb 2023 17:01:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRLh-0006R1-GX; Tue, 07 Feb 2023 17:01:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRLh-0007bm-Cu; Tue, 07 Feb 2023 17:01:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRLh-0002sF-2I; Tue, 07 Feb 2023 17:01:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPRLh-0008Qe-1p; Tue, 07 Feb 2023 17:01:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2nHprLgsRg5KwJNDxm5xVWejR8Z7pFdkg8+1KTWLDm8=; b=EWq5Q42eewb7L4+kHJSYdVXYxp s9K/fvKNs8eqRTwfIu/1qsXVc16yNPf2/DeJNFR+4aw9RZOJW8Xa7y5h6cXpMMTAELAs36fVcyxKX ZAdKSE3UDoatD7lPc6ySdjQ5UqZe7rdU5xQ4E7BQYEUiRQWLcm9/MMpEncvsrghKWMeU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176455: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c0e202194bfcb413d7cf662b333550ed444c469b X-Osstest-Versions-That: xen=6c707d4573f5df2b60503dfeedc10b33cebd60d1 From: osstest service owner Date: Tue, 07 Feb 2023 17:01:41 +0000 flight 176455 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176455/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c0e202194bfcb413d7cf662b333550ed444c469b baseline version: xen 6c707d4573f5df2b60503dfeedc10b33cebd60d1 Last test of basis 176424 2023-02-06 16:00:27 Z 1 days Testing same since 176455 2023-02-07 15:02:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6c707d4573..c0e202194b c0e202194bfcb413d7cf662b333550ed444c469b -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 07 17:03:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 17:03:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491355.760433 (Exim 4.92) (envelope-from ) id 1pPRNQ-00074F-2Q; Tue, 07 Feb 2023 17:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491355.760433; Tue, 07 Feb 2023 17:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRNP-000748-Vt; Tue, 07 Feb 2023 17:03:27 +0000 Received: by outflank-mailman (input) for mailman id 491355; Tue, 07 Feb 2023 17:03:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPRNP-000740-7M for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 17:03:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7d00::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55f92e64-a709-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 18:03:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB8050.eurprd04.prod.outlook.com (2603:10a6:20b:246::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 17:03:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Tue, 7 Feb 2023 17:03:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55f92e64-a709-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KhEiHP+d7cu30HwJ76/FVeECl5dIxSKq/OA8OuutYzpN95hMRXj+6wl8uwpQdtMz/2LpSMTJlapxmWVz13Lvqz+qHMB2wCiSPCXIg2y0sDQ3SOfyS/gpgpc8GnHEUVlhhbwSqMuDC7uOvqclv24wM41e+9mspQuylqHl89X0oSic4scfEYG7SwaCdu72KJc5wcG9W9zyLajsNE1XU6KQqDlgav3o12bU89cqdzs7/cuGORsjFrYyPAm/njetZUmxBXSv0RO5Iy0heLmUQmb6pH1suVKpCozP/Ke7JAqifIsK5auQxNQyM4k/0XZMnpj05MLFEdNGETyz+24U80CKLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VZQne71/nFBvKBvkD5NCdgH85tSHAsKxkKvctiFAPqY=; b=gsQKb+WtVlaVupIAqCVSgd6Qw52BUia/W8hE2CSm3hAa8e5+cXW/XQgi635vO0sX3Tm0J7xqQWs2gmb+VIHnLRGH3/km4qruamhck8Lh0D75UtSpHvxBY0AiwW6FmxOLfB+skAg5i8P04XFcgFqKhQVApo3jVRS3f8hz1D/b6MxZq9/ee2c387ihJ9LvzxxyVP6lUZipAuVrU5SwT+S3XIa0+qyPqGHo1VZeO7rqmxZqE4KyUhGBxzUYYmL/CmtcXt4Z9rV6Ry8U/z3J5+FMA6lrKFds2vd1pbk/mzmx2gEsZn+hqKRnVabw2RGYE8IXprOmYzi2591ii5T6p0LNpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VZQne71/nFBvKBvkD5NCdgH85tSHAsKxkKvctiFAPqY=; b=fblDdqQeb2180id3aO//hwb/83EIHXuQ7/rASXjDNXwjhlP3KgXw4n4Skux4BGckx/EzIVbUOIXPsK4QiZ6FJnFCbGJToyHJX0OYJfECDPgl8vxDr3RK1z7eMevLKlzNpX2lDCvPp1cPKfgl9o1s5CMUl+qE3r3frJgqxl2UBILxpxM+oxAyrnZe4SQuV2ABvflAyD5gviquY3tqb1EMeFqOWtHxdM9RuRpTUQ+FmLG0H0YbClbP+4i8s7R9oNfLvqFwwR3aUj9dV6LdCvy4YIsCVSot5nFNw+3gF1oPoNeZkU3oW9YV22imGsNXzWPd7uaqL7sR+b1dovpK4jw7lA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 7 Feb 2023 18:03:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20230207160948.3169-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20230207160948.3169-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB8050:EE_ X-MS-Office365-Filtering-Correlation-Id: 0054f43b-97e4-4b4f-a76c-08db092d33a5 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NMutmlJ2nAbfxWYOFtp3fHZ60ZaXyV2SLj4jby7nqsZhNoJbFwRJDjC7Kv1mUXxSHz7KvAiBa5qBQfXowsfFH54km3ZI83XPfyZvmPtBqqwSQRKXcJ6fdgrli4000jf/ZjKR75syyQkYW07K1K1+dKfStt97mF+34PCl3od4ONpEZn/svkQzVR5zCxsoVR1edyOCWuSEsJDdccpWIH0nIuCp5quM8ZqGcyu9b3KCKKe4yguQIKHVgNBZLhqkAHK/VvekAgLUASwXw5xh7+WLLTMzU/FLW9BTebmDF9upU73NypcaBPv6Z9Z4Z/gHKG7bUvaJ1Uxlqj7IShDMBNFqgK4vWu1qpOibEAyx3R93fY1SIzU7a50Htm4TxJt8Kj0PtxEdYwj2Kzm+MplL1QPgC8UpXzzvUhR3is/QkUILvv3qY1XdXlWWFfvPotj/d/sz19K2oOVlFq2BmMRjlr1aeQytPWhOHl2G+N5MbPf0WANBsull+FvQ4MG9t8sE2SrseflJsfYIbXx9Cf0lhOHrdRMu4ncVNkKveYGSK1hb1QzDQ3WWhbGmIHT2XY4Ic3sVulXinp1j8Z+ONBlkV1F5u62Pm+0Nb4KFhtRvGOiN9Sj7UJFBZrlhaiD2WAj1jJBGDwgoj+/NrLn8BL6hUMSzOhAk1HMcR2NGmcd+kmWSZ2OxC4O9KtqBgJvtMi/1cXCaUF23Z5i77OsQ8WrhKQdxCbFxi/Yra7Z0aMJ6xIl471Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(396003)(366004)(136003)(39860400002)(451199018)(5660300002)(478600001)(31686004)(2906002)(54906003)(316002)(66946007)(6916009)(4326008)(8676002)(66476007)(66556008)(6486002)(6666004)(6506007)(6512007)(26005)(2616005)(186003)(53546011)(8936002)(41300700001)(86362001)(38100700002)(31696002)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXhvMVhyTEE0M3JDeWxWdlFTemZmS2NOdzVlOFdIMlZ6K081WTNGZThva3dX?= =?utf-8?B?UDdBaEZLSS8xZjJpUUFaZW95LzFEdWYxM1BJNk9Fc0ZLUHU3cE5uclRlUU9z?= =?utf-8?B?cktrWTBrZWJKZzYyemx3eUtxbTNHL2hlSEpaWldTZm9LN0czOHpSbWdZZUJJ?= =?utf-8?B?THQvWXhhQmw4NDFOM3dMY0NsdFJTaktFRGRjMXYwZGYvUW5XRGcrMkd5dzQr?= =?utf-8?B?c2dYMHNIZlUrWGxxTmcvTFUwYS9IWTQvYTNXcEUxU0VZTWlvVTl1WE8wV29N?= =?utf-8?B?enYwT2l6Q0FVenVMZWJ0K0F6QVhBZDAwcXpMRDRJamNYUFRLcGtMSjU5TWVu?= =?utf-8?B?RHFqdzBycElqMG5MSFRwWGN5MktTK2RsRXpURmp5RzRZMDMwOHZ3UmtGV1Rr?= =?utf-8?B?VnJ3MmdrbE1YTzNDRC9uRVVpZFh6dHUzT2tSNEtWWWgzNGlEMkdsb2RiZUpq?= =?utf-8?B?R2svMGlkb2lWRVZlanRIbkE5dGxqR2dSQVhwNWVHdXFrNldvT3Axay9SaWNC?= =?utf-8?B?RDdJZVJLeVhxSmpYRDFKaFNpcGZqcjd1MCt6YTNZVG1DMUtaMnEvQVNxSDl5?= =?utf-8?B?c3YwUGJWUTBIY3VscWhrS2tLclhPeGdkNWloSXJlZEJEMXlOOGhtNFlFQXZL?= =?utf-8?B?RG4vaEtTVUxmdFJVREQ0VkNZK21uTStxNHNEeGxKL1JlRFY3cXZNeFc5YnNp?= =?utf-8?B?cEdLT2FUQzVGR0xYSDdhOTNQNU5MbEZYRHh4Sm12dUFZUDVBNXdzWXloaUxV?= =?utf-8?B?ZkZKR0w4aDJUdXp2cUUxSnAyK3dLM3BOb1RwUHAvWXh6TXkveCtPNDcwQWNk?= =?utf-8?B?Vm9udy9idEJZL1NPSTdhVUVmUlVFb2hjeW95b2RwZTF6bE9iWUY5WVVCaGda?= =?utf-8?B?UWpLYmo5bjdnRUtJb25iWUtRL2VkWS9VUGZYWmpaSlQ2QmdhdzFTWnpvMzla?= =?utf-8?B?N3RncEJxS3JvODJtOTVjdloxeWNXZFpFSmh2SDI3eUVIVkxXZy9hVituTGhU?= =?utf-8?B?WHN2cGlacmN2ckVEeTlvOER6UlR0VEtvWm4rZFNlUzJkTnNpelpjSVAxN0pP?= =?utf-8?B?VTBzSW15eFBjN0szdW1NdE0vcmdzS2xINGRRdGdSWStFcUV0UjFLQlZETzd2?= =?utf-8?B?aVg0Y1NlVnBjcGpnb1FpSTdvKzFrN2x1VC9jWjVHMHJ0ZmRKdzRvQ2EvU1B6?= =?utf-8?B?Nm1oWnZXUVZPUXJ4YXVFY2J0QVlvR0tuamdKOTFqS3BqUGl3UDc2cjJrUit1?= =?utf-8?B?UFdVVzFBQldMSWhubng3YkJFMFBpdlpnckQ1cnZ1OEZXNFZITHNla3dZdjNR?= =?utf-8?B?TVVnMHJFeUxpQllwVmgvc04ySWNNWTZaSktwemNNdm9oOW5jckRYeXJVeHNu?= =?utf-8?B?ZlJUSzZHUU9nQTFJNTdkTjB2U2lnTWhxbEZhU2htWkxTOHNSNXdqNjQvMWlm?= =?utf-8?B?dXV6aXF1d29zelkxOWRkeXFMejNsT1EvWXJQU3ViVmlqSnZiQStvOWcrQ0VT?= =?utf-8?B?NHVtaWszUlYvTkRjMW5zOTdXRkhXbFN4YnNmVjF0NkFBLytTSG5nZWk3ejlw?= =?utf-8?B?SlpFUTF2dXpHdW96L3dseEpSckIwZGlXZnMvL0dsMGxUOUJvSlZIa3UrWHdE?= =?utf-8?B?N05lWStKVjNhWmVobFJPRGVNOEYzbXhzeVdYaHFTWVBFSjQvUzZCOW5ZdjBS?= =?utf-8?B?NjJYeDUrYm54TGNudnlxQTJHLzhMdG12VjB3QlpwNE1VWmpJSWd0aktjdWll?= =?utf-8?B?dTVlb043ZVlyQWxLSkxJa055MHFFcThHK2RmbVJqU2dkdWc2Z3psazlzOHRO?= =?utf-8?B?Z1YvRFdBVFFpVWJBcjZkeHMyRllydXRkTkRDaEVCYXJ6K3pZK3NJcnQrZm9L?= =?utf-8?B?STVaQXZoV05IeUtFc09MN1czazB5eko5WExVaGViajd3ZkFJWHIzTHJlelUv?= =?utf-8?B?K0RydDZxaTBKRUJxdExmSVBYaTlPOEliWnZBSEsxNXhPZWxJWnB3UnkzYWFm?= =?utf-8?B?L2h0SURoV0NhVk5nNzlCM3VKNmI0bzYydDdzb3lDZHRQaStQYytDdG1pTFZG?= =?utf-8?B?MGRZTkZ1emEvVDN5ZGQrS3JaSWtYRi95Qjh3M0JzNHIvQTBPcVg0bWRQQzkw?= =?utf-8?Q?y1TrzTjZGLZ6OmJYPUpL7Xuov?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0054f43b-97e4-4b4f-a76c-08db092d33a5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 17:03:14.9448 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5OJ3NCsroYMEFp6DuDx8lgfeZwzyyNjcQyZR2pj5DSwGKZ6yu7ULffNYuwvw5ruPqYMPqOpCDTGhAbOndL73rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8050 On 07.02.2023 17:09, Anthony PERARD wrote: > Both are already mandatory to build the hypervisor. I'm not sure this is sufficient as a justification. From all we can tell even pretty old tool versions are okay for kconfig's purposes. However, pretty recently I've learned that some linker script language construct used for GNU ld runs into a bug in certain (old) versions of flex. Use of that construct will then cause an (almost?) infinite loop in ld. Therefore the question is whether libxlu's uses are immune to such issues (along the lines of kconfig apparently being). That said - I'm happy about the change in principle; if so desired we could simply see if anyone ever runs into an issue, and revert if need be. Nevertheless I'm not convinced it'll address the problem Andrew had noticed in CI (and where the consideration to remove the generated files originated). It is likely to mask the issue in CI (simply because, aiui, there are no incremental builds done there), but that won't prevent people running into it on other occasions. > This will help avoid cases where the *.y or *.l files are been updated > but flex and bison aren't available. This is odd: How will this "help"? Right now the build ought to fail (it doesn't, there's merely a warning, which might be easily missed). With your change configure will fail when the tools aren't there. > This also remove the way the missing binaries are been handled, with > double-column-rules, which might be an issue sometime. These double-colon rules should never have been introduced. Double colons have a different meaning ("terminal rule") for pattern rules. In fact they were my initial suspects when looking into that odd build failure in CI. > Adding ".SECONDARY:" to avoid "libxlu_cfg_y.c" been deleted by make > when building the library, and regenerating the file on the first > incremental build. While probably okay here, I'd still like to ask: Are you sure you don't want to specify the files we care about, rather than applying it to everything (by leaving blank the right side of the colon)? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 07 18:05:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 18:05:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491376.760445 (Exim 4.92) (envelope-from ) id 1pPSKf-0005T9-Mk; Tue, 07 Feb 2023 18:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491376.760445; Tue, 07 Feb 2023 18:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPSKf-0005T2-K4; Tue, 07 Feb 2023 18:04:41 +0000 Received: by outflank-mailman (input) for mailman id 491376; Tue, 07 Feb 2023 18:04:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPSKe-0005Sw-IA for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 18:04:40 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd269882-a711-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 19:04:18 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd269882-a711-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675793058; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UyUpBNePlzlW5g9E0XocfkD0UG+yFrziX5U4b0VfFHk=; b=et/9zT80Tond+PG+FhbZMwyprjpIWXS6dabmD0alX6oejYc8Q8XwUMKK Ika+z/IlJCaxwv06GoJPA3t9F4FXpZjtDJRv9JAYo97UoIAUt7ywLrNBw 993HjXDvjcRphs7T6OhjEvJYeEUBRyctBk2WR0kcZDZP8TpC6EMIMFOlq M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 94917444 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:BfHsj6IeTj948OSpFE+R7JUlxSXFcZb7ZxGr2PjKsXjdYENSgzYDy GIaC2nXPvmJYGvyfNwgbYvlpE4AscDVzt9hQANlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5ARhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5GQnsVr PEICQwLSSGgm8SGwfGfFsNz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbGZQMwRrE+ goq+UzSWCsdK/qFxwGm737vqP3Gkjr5e6MrQejQGvlC3wTImz175ActfVmxrOS9i0W+c8lCM EFS8S0rxYAt8GS7Q9+7WAe3yFaGsQQbQMF4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq1/6+ZtzqoNQAJLGUJYmkPSg5t3jX4iNht1FSVFI8lSfPryISvQlkc3 gxmsgAPxK9I1MMb9pm92mHknxScp9vtEiQqs1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZxCIUvIT46NuhXogj1mPPBMmPevpn0GWKJp9zmFfLIQua8+I 4yHVs2nEGwXD69qpBLvGbhAjud7mnhhmTmJLXwe8/hA+ePPDEN5tJ9faAfeBgzHxPPsTPrpH yZ3aJLRlkQ3vBzWaSjL648DRW3m3lBiba0aX/d/L7bZSiI/QTFJNhMk6e95E2CTt/gPx7igE 7DUchMw9WcTclWddljXNC44Nem/NXu9xFpiVRER0Z+T8yBLSe6SAG03LsNtFVX73ISPFcJJc sQ= IronPort-HdrOrdr: A9a23:FjDRfa/yDN0LIMd4Maxuk+AiI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHvJYVMqMk3I9uruBEDtex3hHP1OkOws1NWZLWrbUQKTRekP0WKL+Vbd8kbFh4xgPM lbEpSXCLfLfCVHZcSR2njFLz73quP3j5xBho3lvglQpRkBUdAG0+/gYDzraXGfQmN9dPwEPa vZ3OVrjRy6d08aa8yqb0N1JdQq97Xw5evbiQdtPW9e1DWz X-IronPort-AV: E=Sophos;i="5.97,278,1669093200"; d="scan'208";a="94917444" Date: Tue, 7 Feb 2023 18:02:45 +0000 From: Anthony PERARD To: Jan Beulich CC: Wei Liu , Juergen Gross , Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Message-ID: References: <20230207160948.3169-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Feb 07, 2023 at 06:03:12PM +0100, Jan Beulich wrote: > On 07.02.2023 17:09, Anthony PERARD wrote: > > Both are already mandatory to build the hypervisor. > > I'm not sure this is sufficient as a justification. From all we can > tell even pretty old tool versions are okay for kconfig's purposes. > However, pretty recently I've learned that some linker script language > construct used for GNU ld runs into a bug in certain (old) versions of > flex. Use of that construct will then cause an (almost?) infinite loop > in ld. Therefore the question is whether libxlu's uses are immune to > such issues (along the lines of kconfig apparently being). > > That said - I'm happy about the change in principle; if so desired we > could simply see if anyone ever runs into an issue, and revert if need > be. Nevertheless I'm not convinced it'll address the problem Andrew > had noticed in CI (and where the consideration to remove the generated Indeed, it won't fix the issue. > files originated). It is likely to mask the issue in CI (simply > because, aiui, there are no incremental builds done there), but that > won't prevent people running into it on other occasions. > > This will help avoid cases where the *.y or *.l files are been updated > > but flex and bison aren't available. > > This is odd: How will this "help"? Right now the build ought to fail > (it doesn't, there's merely a warning, which might be easily missed). > With your change configure will fail when the tools aren't there. The scenario I was thinking about is when someone edit the *.l source file, and try to rebuild without flex been installed. It might take sometime to find-out that the reason change aren't taken into account is because flex is missing. At least there's a warning, but it is buried within the rest of the build log. > > This also remove the way the missing binaries are been handled, with > > double-column-rules, which might be an issue sometime. > > These double-colon rules should never have been introduced. Double > colons have a different meaning ("terminal rule") for pattern rules. > In fact they were my initial suspects when looking into that odd build > failure in CI. After some more investigation, I don't think anymore the double-colon rules here is an issue. I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" failing to build while "libxlu_cfg_l.[ch]" are been regenerated is probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of targets. If for some reason we have: libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c Then make seems to take two parallel decision: When building libxlu_cfg_y.o: libxlu_cfg_l.h is newer than libxlu_cfg_l.l -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o When building libxlu_cfg_l.o: libxlu_cfg_l.c is older than libxlu_cfg_l.l -> we need to generate libxlu_cfg_l.c first Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been updated do to the parallel build of libxlu_cfg_l.o. I can easily reproduce the issue with: touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; touch libxlu_cfg_l.h; sleep .1; make -j And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. I don't know how to properly fix this yet. Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is supposed to be grouped targets. But that's is maybe fixed in 4.4. > > Adding ".SECONDARY:" to avoid "libxlu_cfg_y.c" been deleted by make > > when building the library, and regenerating the file on the first > > incremental build. > > While probably okay here, I'd still like to ask: Are you sure you > don't want to specify the files we care about, rather than applying it > to everything (by leaving blank the right side of the colon)? I guess it would be better to specify each targets. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 07 18:49:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 18:49:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491385.760456 (Exim 4.92) (envelope-from ) id 1pPT1z-0001qe-1o; Tue, 07 Feb 2023 18:49:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491385.760456; Tue, 07 Feb 2023 18:49:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPT1y-0001qX-Uq; Tue, 07 Feb 2023 18:49:26 +0000 Received: by outflank-mailman (input) for mailman id 491385; Tue, 07 Feb 2023 18:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPT1x-0001qR-EY for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 18:49:25 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 214b89cf-a718-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 19:49:21 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 317ImuEP054912 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 7 Feb 2023 13:49:02 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 317Imu1q054911; Tue, 7 Feb 2023 10:48:56 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 214b89cf-a718-11ed-93b5-47a8fe42b414 Date: Tue, 7 Feb 2023 10:48:56 -0800 From: Elliott Mitchell To: Anthony PERARD Cc: Jan Beulich , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Message-ID: References: <20230207160948.3169-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Tue, Feb 07, 2023 at 06:02:45PM +0000, Anthony PERARD wrote: > On Tue, Feb 07, 2023 at 06:03:12PM +0100, Jan Beulich wrote: > > On 07.02.2023 17:09, Anthony PERARD wrote: > > > This also remove the way the missing binaries are been handled, with > > > double-column-rules, which might be an issue sometime. > > > > These double-colon rules should never have been introduced. Double > > colons have a different meaning ("terminal rule") for pattern rules. > > In fact they were my initial suspects when looking into that odd build > > failure in CI. > > After some more investigation, I don't think anymore the double-colon > rules here is an issue. > > I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" > failing to build while "libxlu_cfg_l.[ch]" are been regenerated is > probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of > targets. > > If for some reason we have: > libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c > > Then make seems to take two parallel decision: > When building libxlu_cfg_y.o: > libxlu_cfg_l.h is newer than libxlu_cfg_l.l > -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o > When building libxlu_cfg_l.o: > libxlu_cfg_l.c is older than libxlu_cfg_l.l > -> we need to generate libxlu_cfg_l.c first > Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been > updated do to the parallel build of libxlu_cfg_l.o. > > I can easily reproduce the issue with: > touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; > touch libxlu_cfg_l.h; sleep .1; make -j > And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. > > I don't know how to properly fix this yet. > Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is > supposed to be grouped targets. But that's is maybe fixed in 4.4. Might this be solved with: %.c: %.l | %.h I'm unsure whether order-only dependencies are GNU-make only (there is a good chance). There is also the option of using .PRECIOUS -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 19:07:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 19:07:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491392.760467 (Exim 4.92) (envelope-from ) id 1pPTIg-0004S2-Cx; Tue, 07 Feb 2023 19:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491392.760467; Tue, 07 Feb 2023 19:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTIg-0004Rv-AC; Tue, 07 Feb 2023 19:06:42 +0000 Received: by outflank-mailman (input) for mailman id 491392; Tue, 07 Feb 2023 19:06:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTIe-0004Rp-Oz for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 19:06:41 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060b.outbound.protection.outlook.com [2a01:111:f400:fe59::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8bdafef9-a71a-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 20:06:38 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by SN7PR12MB6765.namprd12.prod.outlook.com (2603:10b6:806:26b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 19:06:35 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%9]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 19:06:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bdafef9-a71a-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/GDRoiF31LZeVsfRfi0jN86KhfadOD9trfnFiP3zNhnM0kobDv3sIG1EWD4I48atlEBVwkVkHQtxFa6K+FYcu1T1/6dgjK041A/cfHM2o6AsX071Tsor9GtkH++ZiFNHPcgfFkIrwmP32hJWOaqtO8ZTNMFhmKOgDl+MpdhaYS4S2OTkqLDN5WbosViGcyGCi1kH+HfeSJu9k3PWxovGQnFyszcQgmXpEmTYRyRIojcWNaJw0oaJhHOsybvwdkJ4ASxbrfQLlurvqYnuFagXXyc4EIjxqTFPR7XSG99Nh5+3qTVkiy+8GrvVoEaa6eXP4T5AzPju956GotFDefZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IF/FKHSdGzAdLdfjLANUSzV2h8+sZCXFUOFGffZJzSU=; b=XzqJPCiPi0LKdpDhssx07p88UZi6NS0TzwXOXUFtN3X23i3iHR6eNIjd06KyLH4ODWtS8iS17DxY9bKO+rt3c3swOK5B34J7XKlRP4/m7FH0jWP0iSXoIQXhzqp+Hcz+SBHC+w8mVsUlEd2NymVMmGbNc8c3JAe5XQYHqZjoY1zw2uRDpWjImL/wRJ+VRYOklGacznd/GzB8Dp8e3WfS11AQEzOH5ZvFrn+RyXdzhCPo5C4kLYt4C70Ej+vwQHmjtSUWZamgR/eW5kc/83nNpbH2BXVCjIbmSj1bNJp6ovFKeJSFXaIeeTd7mh4S3oKZtT+QdIxQaYA4fROQ14BqwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IF/FKHSdGzAdLdfjLANUSzV2h8+sZCXFUOFGffZJzSU=; b=xjcdX3LzMaW+7dWBGGGBzp+xkE3rYs8bLYsDmRId6i8jgnZoqxMH9qOF3vqufA2BOUXeJNLVnqxtYTHtC5JWSMVNF2L2SamWrnf55EKxzpPVTURo33ZK9k/KO4vEhuDYptWbYLlE5KCIM6hF8KQL5vD5cxwyayx+Pd3HsD0dBtE= From: "Garhwal, Vikram" To: David Woodhouse , "qemu-devel@nongnu.org" CC: "xen-devel@lists.xenproject.org" , "Stabellini, Stefano" , "alex.bennee@linaro.org" Subject: Re: [QEMU][PATCH v5 00/10] Introduce xenpvh machine for arm architecture Thread-Topic: [QEMU][PATCH v5 00/10] Introduce xenpvh machine for arm architecture Thread-Index: AQHZNcakEWW/7lvDjUSyrZ2SnjklJq7DThcAgACUN/M= Date: Tue, 7 Feb 2023 19:06:33 +0000 Message-ID: References: <20230131225149.14764-1-vikram.garhwal@amd.com> <84ded117ebc6e8c72f4120df00d357a275da9eaf.camel@infradead.org> In-Reply-To: <84ded117ebc6e8c72f4120df00d357a275da9eaf.camel@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR12MB4409:EE_|SN7PR12MB6765:EE_ x-ms-office365-filtering-correlation-id: bf54ded0-b047-4cff-6fd6-08db093e6d79 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S1ghSw58pf4+n7MHuMMv8U/1mvcZu+8aY0dAgTsELfOXv+FNm9jBZfIOU5MqV3JFuFIZlbqlrV+nq2D7ttXoecy8Lg9SzK62rWplcKq9bbB05hxjqSFt1p0iVGQC8tfjrAcYqPR3VevSH12gQGv28J5LATI/QIQfBIyzhfbyiDY+RiygipGsDaVhEvjKaodhbbJHQGpBP+zknvdxN3riE58GmmR8lUrOtwb3UH7I7+3FR88Rfx6mHjp+FipBQRcYCuGDNOMtWKqQK1Csvi2zCxW3LY1Th2zGm2N8+SL6ZHTb28KLrGiPxuZ5yxOMi3yUp+nlTWUiaoX47S9/TG/ZhFa6gxXMmaqmeh+JsCNACwdogNOQnIpKcdxWFFHfBKCQ5QsDzJOZV5uksTsLGxniWK+FqBdsw3JjFMjGbrrsjwXrsZA8oW/sSL3jQ3PtEab7ocyeIxR7Sd0mGMtK/jc9JD0TfE7fVxQvzqgm8HXkJTvkiak9lXfEWWBUPu8LyocPbn2WgNzD2w8uWHvkMzAB8nOi4Y1oPDmR6SwtywIqc+ayaY+/lALpyGdvxDWGEhgSPbDMFTnGTwyvog3bTtFz5FFvmopTPPHWFo7i84LAH1RVsLcLrgCLaaX3FJdpFKYnF9uZtZ18ZgK0WEDqjsSMeiLEVNyDJ+v0lHIpIk19YrJ8JKBo6VWdxne3EV8JDeVDfYYMJ+4/Mo9JP8o8aNrsGAiza1AUo/duDmsPLpzooyk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199018)(186003)(966005)(6506007)(53546011)(26005)(38070700005)(478600001)(9686003)(33656002)(122000001)(38100700002)(166002)(316002)(9326002)(52536014)(41300700001)(71200400001)(55016003)(8936002)(5660300002)(110136005)(7696005)(66446008)(2906002)(54906003)(64756008)(66556008)(83380400001)(66476007)(66946007)(91956017)(86362001)(8676002)(4326008)(76116006);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J8eP6TiP5I7/4+ntETLs3/mOGnbC1DjFxiFT9iCSfjWzAqLzXszLiWU7JDXo?= =?us-ascii?Q?Ho9dxszGu0F1KHdxvPoMypXWOt/jKEpRcS3Ogvq/hltHvgrLwcmDETsKhEjq?= =?us-ascii?Q?bfk6eYpkFq9vuQyvB1wOm6wkKiJiU26C3XPzmSDSUqFOdvWKB2Th/3JtNeKR?= =?us-ascii?Q?5/0w2DgyQjUGyuqTFVFnM3pr3YXkHjWRngkguCq2xb3LyL2hsYzT0nz428Jj?= =?us-ascii?Q?s5Kyk1uPEZma7XXQE4WZaGnUzwbc558FmtEqbTLxvmCHqBzALlaGJ3PlobdA?= =?us-ascii?Q?C2EenSls1AE2fA2ZsAu7AWtGoe12J3/+DUKM4pyoRVwKKLPj89WnviN2S7QM?= =?us-ascii?Q?Y8K+hz4RTbX0agp3S1beObjQZjEb2V8krw8j1M0LpX4Q5pw1KbKXtdVUNv7j?= =?us-ascii?Q?0n9muQJTGRsvJnvxtTnHKEa7ByKl+OjfkEpr1F+vuPFKSb7n4vr4xdOEqTac?= =?us-ascii?Q?xd8G05R+M+/pLSwTeIyL53TbZjJ2iAzB13flOFZ/Z5BZ3b7nD2e75mai7ze4?= =?us-ascii?Q?I3deKE7Dhyjym7ep/vVsFFw1ERj41FlpC403lDADrn/uHJDyfT0jTdgjO4fo?= =?us-ascii?Q?p51UFDkdpY0JbTc89vix2SS300T3bunOdeX6Wy9xPOSGfVm6SR7nDjsrZlxC?= =?us-ascii?Q?Lt3hQzN+oGXRgRny+cg9oI8c8EMk3RokQa6V9L2b4PmeNtLrtLnA5ICmCc/k?= =?us-ascii?Q?1avJpJHInVFWT/RsHSxMLQgqGumX4PXWsoENFA3RXPUEfajhCWfjiSdn1/WY?= =?us-ascii?Q?S4DdtFqGjY302+WN20FMVuPJ5lhSQwwoSE3ibks18jcfM5bv3pKXaE5fKZT2?= =?us-ascii?Q?+ivPC22Zt860n9is8Y+y6AvqvSFJeKdrx+O2bEDbXPSJhSIi8mFFDHyAvnPf?= =?us-ascii?Q?XM47/oM8d/FwJh1sp6rLIT6vM9Rv1DKIuiisBHiKxJbNIhcJivlAxQ/VCQAF?= =?us-ascii?Q?TZEN5Rt5197YPepfj/fjR5e84JRxnW4kX8IrI1hPcb9RD3wCzYk/tKDArMl/?= =?us-ascii?Q?l96jOtnmLodvD7UFLk2+iy4CewtGsHQop97RCCuaUR+8Oa4v80Q4hhPRX8OY?= =?us-ascii?Q?MOcLR046o/abKMUwI4PzJbcAt/Bb2im1fekR4lCG3TMk24iJa2YGF/66einR?= =?us-ascii?Q?OTtKvNfu3SWMyaqL99xKX5UQU1vGGjgeMwjtGGYto7A0/WzIig81TNaQ++Hu?= =?us-ascii?Q?m+Qs56zE7P01EAUIo1mmDAYY7zMGDQnVfvyytUcC8o2gujAGwV3xg2Z2fXRT?= =?us-ascii?Q?Lw5esno1o++Dj2jiHhBgtSvzJy7Nu10jo2DOPVACeELjdvrzNBZdZIpCtiuN?= =?us-ascii?Q?iLo2OFMGc93jlloVZsC9ewaMo8vyED+oNAb75FxUaibwSLgBQT8E0OaNB8nY?= =?us-ascii?Q?kIMuae2rPdD0gGIOAl5IpTskFw+dPVVkx6fML+EZlZIOmPmsC1uWwIwTyuBA?= =?us-ascii?Q?jQn1ldsd4iSPSdUtO+4Q9OHvTj0B1RM7Xty/LWL+32f8IANSndZk5StRtZXO?= =?us-ascii?Q?fs40tstw5zk7q+NM0YuamjxI1UmWX//CQJRCEaNGt0gdyOMPN/mi6ZBOAvaj?= =?us-ascii?Q?kWiYkyygtgG0xAjUsB64GHqoB8dsE/7QkV3bwzZ3PI02p53qkcCOzeoPvM4i?= =?us-ascii?Q?fA=3D=3D?= Content-Type: multipart/alternative; boundary="_000_MW3PR12MB4409AF045F05F924718D884D9FDB9MW3PR12MB4409namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf54ded0-b047-4cff-6fd6-08db093e6d79 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 19:06:33.1885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vgpOi1hzlmeAx/woEgskTAdZCJUxbdti1loBI07ZX0fVs5T66ltMxztkS2pedXRFLenx6kkFQqRnGhYCnHeHCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6765 --_000_MW3PR12MB4409AF045F05F924718D884D9FDB9MW3PR12MB4409namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi David, I forked the QEMU latest master branch and added these 10 patches. Branch Link: https://github.com/gvikram31/qemu Please let me know if I misunderstood your request. Regards, vikram On 2/7/23, 2:13 AM, "David Woodhouse" wrote: On Tue, 2023-01-31 at 14:51 -0800, Vikram Garhwal wrote: > > Hi, > This series add xenpvh machine for aarch64. Motivation behind creating xe= npvh > machine with IOREQ and TPM was to enable each guest on Xen aarch64 to hav= e it's > own unique and emulated TPM. > > This series does following: > 1. Moved common xen functionalities from hw/i386/xen to hw/xen/ so th= ose can > be used for aarch64. > 2. We added a minimal xenpvh arm machine which creates an IOREQ serve= r and > support TPM. > > Also, checkpatch.pl fails for 03/12 and 06/12. These fails are due to > moving old code to new place which was not QEMU code style compatible. > No new add code was added. Is there a git tree for this, please? I'd like to check for conflicts with the Xen-on-KVM emulation support which I'm also hoping to get in for 8.0. --_000_MW3PR12MB4409AF045F05F924718D884D9FDB9MW3PR12MB4409namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi David,

I forked the QEMU latest master branch and added the= se 10 patches.

 

Branch Link: https://github.com/gvikram31/qemu

 

Please let me know if I misunderstood your request.<= o:p>

 

Regards,

vikram

 

On 2/7/23, 2:13 AM, "David Woodhouse" <dwmw2@infradead.org>= wrote:

On Tue, 2023-01-31 at 14:= 51 -0800, Vikram Garhwal wrote:

>

> Hi,

> This series add xenp= vh machine for aarch64. Motivation behind creating xenpvh

> machine with IOREQ a= nd TPM was to enable each guest on Xen aarch64 to have it's

> own unique and emula= ted TPM.

>

> This series does fol= lowing:

>     1= . Moved common xen functionalities from hw/i386/xen to hw/xen/ so those can=

>    &n= bsp;   be used for aarch64.

>     2= . We added a minimal xenpvh arm machine which creates an IOREQ server and

>    &n= bsp;   support TPM.

>

> Also, checkpatch.pl = fails for 03/12 and 06/12. These fails are due to

> moving old code to n= ew place which was not QEMU code style compatible.

> No new add code was = added.

 

Is there a git tree for t= his, please? I'd like to check for conflicts

with the Xen-on-KVM emula= tion support which I'm also hoping to get in

for 8.0.

 

 

 

--_000_MW3PR12MB4409AF045F05F924718D884D9FDB9MW3PR12MB4409namp_-- From xen-devel-bounces@lists.xenproject.org Tue Feb 07 19:12:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 19:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491400.760478 (Exim 4.92) (envelope-from ) id 1pPTOX-0005w7-5u; Tue, 07 Feb 2023 19:12:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491400.760478; Tue, 07 Feb 2023 19:12:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTOX-0005w0-2o; Tue, 07 Feb 2023 19:12:45 +0000 Received: by outflank-mailman (input) for mailman id 491400; Tue, 07 Feb 2023 19:12:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTOW-0005vu-G7 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 19:12:44 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64b02c5e-a71b-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 20:12:42 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 317JCUdF055038 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 7 Feb 2023 14:12:35 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 317JCUs8055037; Tue, 7 Feb 2023 11:12:30 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64b02c5e-a71b-11ed-93b5-47a8fe42b414 Date: Tue, 7 Feb 2023 11:12:30 -0800 From: Elliott Mitchell To: Anthony PERARD Cc: Jan Beulich , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Message-ID: References: <20230207160948.3169-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Tue, Feb 07, 2023 at 10:48:56AM -0800, Elliott Mitchell wrote: > On Tue, Feb 07, 2023 at 06:02:45PM +0000, Anthony PERARD wrote: > > On Tue, Feb 07, 2023 at 06:03:12PM +0100, Jan Beulich wrote: > > > On 07.02.2023 17:09, Anthony PERARD wrote: > > > > This also remove the way the missing binaries are been handled, with > > > > double-column-rules, which might be an issue sometime. > > > > > > These double-colon rules should never have been introduced. Double > > > colons have a different meaning ("terminal rule") for pattern rules. > > > In fact they were my initial suspects when looking into that odd build > > > failure in CI. > > > > After some more investigation, I don't think anymore the double-colon > > rules here is an issue. > > > > I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" > > failing to build while "libxlu_cfg_l.[ch]" are been regenerated is > > probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of > > targets. > > > > If for some reason we have: > > libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c > > > > Then make seems to take two parallel decision: > > When building libxlu_cfg_y.o: > > libxlu_cfg_l.h is newer than libxlu_cfg_l.l > > -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o > > When building libxlu_cfg_l.o: > > libxlu_cfg_l.c is older than libxlu_cfg_l.l > > -> we need to generate libxlu_cfg_l.c first > > Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been > > updated do to the parallel build of libxlu_cfg_l.o. > > > > I can easily reproduce the issue with: > > touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; > > touch libxlu_cfg_l.h; sleep .1; make -j > > And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. > > > > I don't know how to properly fix this yet. > > Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is > > supposed to be grouped targets. But that's is maybe fixed in 4.4. > > Might this be solved with: > > %.c: %.l | %.h > > I'm unsure whether order-only dependencies are GNU-make only (there is a > good chance). There is also the option of using .PRECIOUS Then upon more reading wouldn't: %_y.c: | %_l.c Accomplish the job? (assuming GNU-make or everyone has copied that feature) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Feb 07 19:49:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 19:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491410.760489 (Exim 4.92) (envelope-from ) id 1pPTxR-0001M9-Tr; Tue, 07 Feb 2023 19:48:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491410.760489; Tue, 07 Feb 2023 19:48:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTxR-0001M2-Qo; Tue, 07 Feb 2023 19:48:49 +0000 Received: by outflank-mailman (input) for mailman id 491410; Tue, 07 Feb 2023 19:48:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTxR-0001Ls-4V; Tue, 07 Feb 2023 19:48:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTxR-000327-1j; Tue, 07 Feb 2023 19:48:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPTxQ-0003y4-Nf; Tue, 07 Feb 2023 19:48:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPTxQ-0007SW-L5; Tue, 07 Feb 2023 19:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZLjOJszRiP2iWWyRBvI8wYRlxS5FTw5JTtyOkxmg72E=; b=dmtis2AoIq0rVIJmWSJsKy7oIX 8ysqA1i4j0dBu/qyPHGCb+xpsvnmRB0CcOTHUMcoLJMlzV9BpiIbHveJDV5UMEsZCe00af5ecfC+P Zn/qJfSxd7pBEonYXt7l0cLwYcyWKFE0RXwv3iMLGYdsk3hUi2s3duqwwUG5Kf4/9P+g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176441: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=5c4007ddc6c29632b5cc96ab4ef81ebb7797d1bb X-Osstest-Versions-That: libvirt=0f350a4d070e952b0ecc7631708478ddfd43ba3f From: osstest service owner Date: Tue, 07 Feb 2023 19:48:48 +0000 flight 176441 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176441/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 5c4007ddc6c29632b5cc96ab4ef81ebb7797d1bb baseline version: libvirt 0f350a4d070e952b0ecc7631708478ddfd43ba3f Last test of basis 176388 2023-02-05 04:35:40 Z 2 days Testing same since 176441 2023-02-07 04:20:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik Oleg Vasilev Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 0f350a4d07..5c4007ddc6 5c4007ddc6c29632b5cc96ab4ef81ebb7797d1bb -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 07 20:55:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 20:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491423.760499 (Exim 4.92) (envelope-from ) id 1pPUzs-0000iV-PP; Tue, 07 Feb 2023 20:55:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491423.760499; Tue, 07 Feb 2023 20:55:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPUzs-0000iO-Ma; Tue, 07 Feb 2023 20:55:24 +0000 Received: by outflank-mailman (input) for mailman id 491423; Tue, 07 Feb 2023 20:55:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPUzr-0000iH-43 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 20:55:23 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20603.outbound.protection.outlook.com [2a01:111:f400:fe5b::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b8067ca4-a729-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 21:55:15 +0100 (CET) Received: from DS7PR05CA0042.namprd05.prod.outlook.com (2603:10b6:8:2f::29) by SJ0PR12MB7007.namprd12.prod.outlook.com (2603:10b6:a03:486::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 20:55:12 +0000 Received: from DM6NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::3d) by DS7PR05CA0042.outlook.office365.com (2603:10b6:8:2f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.12 via Frontend Transport; Tue, 7 Feb 2023 20:55:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT004.mail.protection.outlook.com (10.13.172.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Tue, 7 Feb 2023 20:55:11 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 14:55:11 -0600 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 7 Feb 2023 14:55:09 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8067ca4-a729-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cYWQmr5YD3BqK6/FHIQS06uTeprD8eCYlujPdMb4xsNFCEwV1xkzV+Z1+p1oSDny+HtLNBAKvTGPYdP2qiQi1yuWYDLss0+KabsP6XAUcFq/8c6DM36Jxs4hWS5hcADsUKzYWeDzuu+Qx2AhXSjHi/JUVgNQEOKsooemGIfYBrcrqFxs4zqJYt9nrcDJPSniVlQACnHjwVNo8/DnfXkb0C/uCx/Vdiqw5JxMVFuCV5Y9V2MWt5+1QGOnEAwGSj4pnYWd2L1UC8OTH3JxurAF5LsxN31KsJo94DTNhdrbcGDkvFROM7oiCgn8XJSTQS5PL0ZjRx0Mr4H4/ezAQcfLPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tL4oMzGUrykxtEnlElUpdq9qUAZ5V2x4TGyfNNm7mFU=; b=NtVBkM4gYz+rFvX58X3KZ57sqLuTHaEQBm1Sl43+xA5lOBM3Nson4Ig9DA7fVn51PS7XRgkq7dJrnn16DoAO3NkfhaBEN0y2w7HBAUwLXMWciqdCmoQfLpKq81Cs3tzJnI6mMQ0eZgJBWAPqLhnPwN8r/6oH8LWzxyoPh4C71L3WDqiwcVbXJnRiczfRGgSwUSL4Vr/7bWdGyZKws/YkkNUGaI0y32kU+26L/8pEqmOEd+j56yCU7GiV2ilawpL4kJEd3vPUC+HhwzpPwubcjXtgwG6RdCEYaTbGeuyAwRxndHQcN8I4gf2WHx5Q4geZqBAKhPA057pvJ7hqqp9MzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tL4oMzGUrykxtEnlElUpdq9qUAZ5V2x4TGyfNNm7mFU=; b=LFNIjvSUvfSk2W9oHkPakY+oodnHYuae3CXlwjAL2LxDhvuquGXfAbRwfE9qMVn305gFKMiJ+Fa5AVFLxWfX1SToCj/9vRzyqkTutZHFNq1g+2k+wyqGUGoQgy7NgvmheOFN0TJNhsdX7PBU+277pDiUwsMGhThB8UYXa9KGKbg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Tue, 7 Feb 2023 15:55:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Content-Language: en-US To: Penny Zheng , CC: , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-2-Penny.Zheng@arm.com> From: Stewart Hildebrand In-Reply-To: <20221115025235.1378931-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT004:EE_|SJ0PR12MB7007:EE_ X-MS-Office365-Filtering-Correlation-Id: 05254b98-5615-48cc-88b7-08db094d9af3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vXj9p2B0Ui+1OxchRjPii5eI48jWUUQwwQZLcBvgWttGCTb8PskF0Vs9oAJuoDZAWH8X3avzAYgrhQt2k0ft3DaL6/Arl0WQ/8hLaKGkGffvOILnP4qerezTqnizS0OhgRscW9HyoKhKd0P15jcnXlUgROaEmUdsVgHoiXJITKlfe5yg8cm83+rwNKDiJS9iH+CPFAiY9PSaITHs3mzXZO9+pRApXl0Di3FytxTHpTgKWUnp1bXFtp3ZDxPu4JZfgMUgGPyEG12JqZIPEYJ6B+dhsE5vfXB89ZeNGTAnn9bb8B9504USmPk7vcEd6bCtLquWkHa8BEHQn60hQloQ/G7L49fEJ+3J3qASwEdDF5noBqYXtpVrtNVXop75q5/rm96WTm39BEfahLUIyheWJfJbdslbxffg8+nrXVGO8bJR/Sn1eX7V9ezLmCuYsBXRJGroDTARG+HYV+ZgFANSQDN9H23xNDsjBQQEhpJFFr3l9EJjwltO//+Sfjwt6rfDM2t9+zct3HyWodcSW+RwVHIcyJ90V2+JaRlVHSaktmIYZdmukB5fmeCm3jGkv0vwKXLY7ye5j7Rcp1Rd8Ta7QNriMipk7BoB1iBx0RuuwzbZck0jAEy5og26xTVZ3IWozpc3bR3w7m59fdDlXquGYOmxnR2LZpv1zPDkp+QFlIJoN2GjHHRi7Ep2bbY1xNSM9XKp9MK6GN0e/5TbHmP6em4hPeOOIPRGEQUyBuhd5amU0aGdDTUm5p0K7f99RdJYf2pwW65bHbZwTgQkUvsO7g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(66899018)(86362001)(110136005)(54906003)(82310400005)(31696002)(47076005)(336012)(426003)(40480700001)(36756003)(31686004)(2906002)(40460700003)(44832011)(70206006)(5660300002)(36860700001)(83380400001)(4326008)(8676002)(8936002)(41300700001)(70586007)(186003)(26005)(478600001)(2616005)(53546011)(82740400003)(316002)(356005)(81166007)(16576012)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 20:55:11.9059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05254b98-5615-48cc-88b7-08db094d9af3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7007 Hi Penny, On 11/14/22 21:52, Penny Zheng wrote: > ... > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index fdbf68aadc..2d4ae0f00a 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -50,10 +50,6 @@ struct membank { > paddr_t start; > paddr_t size; > enum membank_type type; > -#ifdef CONFIG_STATIC_SHM > - char shm_id[MAX_SHM_ID_LENGTH]; > - unsigned int nr_shm_borrowers; > -#endif > }; > > struct meminfo { > @@ -61,6 +57,17 @@ struct meminfo { > struct membank bank[NR_MEM_BANKS]; > }; > > +struct shm_membank { > + char shm_id[MAX_SHM_ID_LENGTH]; > + unsigned int nr_shm_borrowers; > + struct membank *membank; > +}; > + > +struct shm_meminfo { > + unsigned int nr_banks; > + struct shm_membank bank[NR_MEM_BANKS]; > +}; > + > /* > * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. > * The purpose of the domU flag is to avoid getting confused in > @@ -105,6 +112,7 @@ struct bootinfo { > struct meminfo acpi; > #endif > bool static_heap; > + struct shm_meminfo shm_mem; > }; > > struct map_range_data The reduction in the sizeof struct membank is a welcome improvement, in my opinion, because it is multiplied by NR_MEM_BANKS, and IIRC we only have 32k of boot stack to play with. Before this patch: sizeof(struct kernel_info): 20648 sizeof(struct meminfo): 10248 sizeof(struct shm_meminfo): 10248 When building with EXTRA_CFLAGS_XEN_CORE="Wstack-usage=4096 -Wno-error=stack-usage=": arch/arm/domain_build.c: In function ‘construct_domU’: arch/arm/domain_build.c:3747:19: warning: stack usage is 20720 bytes [-Wstack-usage=] 3747 | static int __init construct_domU(struct domain *d, | ^~~~~~~~~~~~~~ arch/arm/domain_build.c: In function ‘construct_dom0’: arch/arm/domain_build.c:3979:19: warning: stack usage is 20688 bytes [-Wstack-usage=] 3979 | static int __init construct_dom0(struct domain *d) | ^~~~~~~~~~~~~~ After this patch: sizeof(struct kernel_info): 14504 sizeof(struct meminfo): 6152 sizeof(struct shm_meminfo): 8200 arch/arm/domain_build.c: In function ‘construct_domU’: arch/arm/domain_build.c:3754:19: warning: stack usage is 14576 bytes [-Wstack-usage=] 3754 | static int __init construct_domU(struct domain *d, | ^~~~~~~~~~~~~~ arch/arm/domain_build.c: In function ‘construct_dom0’: arch/arm/domain_build.c:3986:19: warning: stack usage is 14544 bytes [-Wstack-usage=] 3986 | static int __init construct_dom0(struct domain *d) | ^~~~~~~~~~~~~~ A later patch in this series will increase it again slightly. Note that I'm not expecting this series to address these particular warnings, I'm merely pointing out the (positive) impact of the change. From xen-devel-bounces@lists.xenproject.org Tue Feb 07 20:57:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 20:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491430.760511 (Exim 4.92) (envelope-from ) id 1pPV1L-0001FI-5f; Tue, 07 Feb 2023 20:56:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491430.760511; Tue, 07 Feb 2023 20:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV1L-0001FB-1T; Tue, 07 Feb 2023 20:56:55 +0000 Received: by outflank-mailman (input) for mailman id 491430; Tue, 07 Feb 2023 20:56:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV1J-0001F5-Kd for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 20:56:53 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2061a.outbound.protection.outlook.com [2a01:111:f400:7eb2::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f14421e1-a729-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 21:56:51 +0100 (CET) Received: from MW2PR2101CA0026.namprd21.prod.outlook.com (2603:10b6:302:1::39) by SA1PR12MB5638.namprd12.prod.outlook.com (2603:10b6:806:229::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Tue, 7 Feb 2023 20:56:48 +0000 Received: from CO1NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::c2) by MW2PR2101CA0026.outlook.office365.com (2603:10b6:302:1::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.4 via Frontend Transport; Tue, 7 Feb 2023 20:56:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT079.mail.protection.outlook.com (10.13.175.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.32 via Frontend Transport; Tue, 7 Feb 2023 20:56:47 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 14:56:46 -0600 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 7 Feb 2023 14:56:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f14421e1-a729-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzQv5BvbKcz7n7sSt7PoA7TY0ntC2eRXDhKRaiB2ZgH0pCENeTtDZiDZDR5zTY6EhCrSFGyPKT3OL96tGPZ7cTsnOmROo2YdaEVE/6iypLyPD6ZSQ7RFH+6n+MyN/1QgkUbfzExLmMKjq+R9pwVk5K3k/CG5htwp5ZwVskDXwPX4p8/Iq2pXOlyzPquywgyL2sNpEkwG8PvjCn6t6iSPzEzJx9Ljhw3vtxZGBvDbS7K3zNvg4sXMd9yn+NY2z5qPbqHxWEfoNAXHOYXULFtWq3ogHLWd3hIrg4iBY809zfGEEc8zoaB+BF9h8/rAxBjpHnM5AXMN5Px14pgJHZVveQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqGXqn6aTEqAgnWHoNZpiEyEkTFc3xIH9PWXXXBy0qE=; b=QlK38YSQAf0pivr9oExILxzyUUa6UiW0IKgyxmvlj6VFNsxp7yBnS30WxGrTFI9EP7EGa/tHcBPe3koJt0K5L8pZLMRmjIXWPMbTBcQAppx7w1WsvWICueVkO0ZYI08iN1KdFMPFIXS2+6YidqaYK+C4bAitb31VNiiPX0t44pgfXEaSREMlQm9sc/yc5pgZfF+1iJG3TStC1o+vKXnqEIKZI0Kv2q7/fS9L+T1rJOhRoAZGA+ZwoXjC7oeNMxmofdhWd6T0/y3Wzn1zKWfoFbI+tjxkSiclnUbimdNtlqLh2gODRZ9djihfVCJzbFs2Lr3TSFiyb9oFpX9/5HawKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqGXqn6aTEqAgnWHoNZpiEyEkTFc3xIH9PWXXXBy0qE=; b=WFve+6sTEo3UIOiJ1xzsojSye+lneCe6ojHVsteJ7y/ZrMQxUJGeDehBEaqnB7poonAMZUkiRTsOxMQrI8jLngOyf3BT95A6QfwgQ0ZeBmUc55x2aMErNvVx6FcY9Xiqfs+QAAW+CiIlnnyQmjoE75W2+k9WB9Y0wy69t9rNPJ8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <522e5499-76eb-6aed-cce4-7c70c1bf0d1f@amd.com> Date: Tue, 7 Feb 2023 15:56:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 03/13] xen/arm: introduce allocate_domheap_memory and guest_physmap_memory Content-Language: en-US To: Penny Zheng , CC: , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-4-Penny.Zheng@arm.com> From: Stewart Hildebrand In-Reply-To: <20221115025235.1378931-4-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT079:EE_|SA1PR12MB5638:EE_ X-MS-Office365-Filtering-Correlation-Id: 9983e3cf-d6ea-46de-16e7-08db094dd3d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hUeCdG90KIl6bVrrG+xDoSrme1q9Fvf3Ybv2KfV5e6kDWTHDUXossk0yNc29Rh5Uv2DH2id+XR4dmXd11qn2ixEhA05VKVuW7GxVXL5VnsNAN3QiH4R+O60iuNZu7GuS4APY61ClwYwMogPttNfy1PmlcW8NwI5lDrw0jv5IWO3KPMagIjDbECvL7O6jlu7Bu+PcLxQsbkkut+9BSaeeWFkLjr6E4ZO+ka83Tcaz7HtZFBQulVqd3YevfoxtMZ51OaaJ41gIgSjLzOlEoOHJHVRFeRd20JkAG/K6/j2ZQ5u08OYXbZjvl+GnYx3usrZiumXpldNbePMHBT6YGQhuZXdA1FoXk5wLLLQTrSDpaFCTdWUujfj52rRIBdlWmnLsjHax2H7OW1RXHYCzUudiANQ0R34QRM8DTC6PCEMBFt52Rnr5v3WXpcdFaD1omazRdmAV0TaDkKuDKexHLyJC5HapIRTQS5QeCh3rRGTiTCPuHQjMUm9Q0wZ426/94/b562ul+dyKsfiJfEh/UmQq9HdHPH0n6QuYBpT7vy9n57HuAGMWL0M2Bu0gRTohyCnXO22fwPtw56ltJauLxnKBAkK642E4FxFWS3vjaO2xUjCCwdQ3Oce81uPsCnkF0vsBvB2yJUlhE9qZi3/wLpz4N4EMcKGSKOF4I/cFzSDx8na5TOb6kH955NVoEBfywIN/VcAR4RqZ2FnfP9tYD4w4FCF0JlXjvZGUjt36Is2u85a3w4qPuZHCA0eRnMP+RK+xdItiKt/aR7YTYG8dTbAbAQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(36860700001)(82740400003)(31686004)(336012)(40480700001)(83380400001)(26005)(86362001)(2616005)(31696002)(81166007)(186003)(47076005)(36756003)(356005)(426003)(70586007)(40460700003)(70206006)(53546011)(316002)(110136005)(44832011)(41300700001)(2906002)(16576012)(478600001)(54906003)(4326008)(5660300002)(8676002)(8936002)(82310400005)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 20:56:47.2846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9983e3cf-d6ea-46de-16e7-08db094dd3d9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5638 Hi Penny, On 11/14/22 21:52, Penny Zheng wrote: > We split the codes of allocate_bank_memory into two parts, > allocate_domheap_memory and guest_physmap_memory. > > One is about allocating guest RAM from heap, which could be re-used later for > allocating static shared memory from heap when host address is not provided. > > The other is building up guest P2M mapping. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 93 +++++++++++++++++++++++++++---------- > 1 file changed, 68 insertions(+), 25 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index d2b9e60b5c..92763e96fc 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -390,34 +390,18 @@ static void __init allocate_memory_11(struct domain *d, > } > } > > -static bool __init allocate_bank_memory(struct domain *d, > - struct kernel_info *kinfo, > - gfn_t sgfn, > - paddr_t tot_size) > +static bool __init allocate_domheap_memory(struct domain *d, > + paddr_t tot_size, > + struct meminfo *mem) > { > - int res; > struct page_info *pg; > - struct membank *bank; > unsigned int max_order = ~0; > > - /* > - * allocate_bank_memory can be called with a tot_size of zero for > - * the second memory bank. It is not an error and we can safely > - * avoid creating a zero-size memory bank. > - */ > - if ( tot_size == 0 ) > - return true; > - > - bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; > - bank->start = gfn_to_gaddr(sgfn); > - bank->size = tot_size; > - > while ( tot_size > 0 ) > { > unsigned int order = get_allocation_size(tot_size); > > order = min(max_order, order); > - > pg = alloc_domheap_pages(d, order, 0); > if ( !pg ) > { > @@ -437,15 +421,74 @@ static bool __init allocate_bank_memory(struct domain *d, > continue; > } > > - res = guest_physmap_add_page(d, sgfn, page_to_mfn(pg), order); > - if ( res ) > - { > - dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); > + if ( mem->nr_banks == NR_MEM_BANKS ) > return false; > - } > + > + mem->bank[mem->nr_banks].start = mfn_to_maddr(page_to_mfn(pg)); > + mem->bank[mem->nr_banks].size = 1UL << (PAGE_SHIFT + order); > + mem->nr_banks++; > + tot_size -= (1UL << (PAGE_SHIFT + order)); Why the change from 1ULL to 1UL? > + } > + > + return true; > +} > + > +static int __init guest_physmap_memory(struct domain *d, > + const struct meminfo *mem, gfn_t sgfn) > +{ > + unsigned int i; > + int res; > + > + for ( i = 0; i < mem->nr_banks; i++ ) > + { > + paddr_t size = mem->bank[i].size; > + unsigned int order = get_order_from_bytes(size); > + > + /* Size must be power of two */ > + BUG_ON(!size || (size & (size - 1))); > + res = guest_physmap_add_page(d, sgfn, maddr_to_mfn(mem->bank[i].start), > + order); > + if ( res ) > + return res; > > sgfn = gfn_add(sgfn, 1UL << order); > - tot_size -= (1ULL << (PAGE_SHIFT + order)); > + } > + > + return 0; > +} > + > +static bool __init allocate_bank_memory(struct domain *d, > + struct kernel_info *kinfo, > + gfn_t sgfn, > + paddr_t total_size) > +{ > + struct membank *bank; > + struct meminfo host = {0}; This function uses 6k of stack, largely due to the sizeof struct meminfo. arch/arm/domain_build.c: In function ‘allocate_bank_memory’: arch/arm/domain_build.c:461:20: warning: stack usage is 6224 bytes [-Wstack-usage=] 461 | static bool __init allocate_bank_memory(struct domain *d, | ^~~~~~~~~~~~~~~~~~~~ It may be fine for now, but I wanted to at least check if anyone else had an opinion on allocating "struct meminfo host" by some other means, such as xzalloc/free or by making it static: static struct meminfo __initdata host; memset(&host, 0, sizeof(struct meminfo)); Particularly if we ever plan on increasing NR_MEM_BANKS again in the future. > + > + /* > + * allocate_bank_memory can be called with a total_size of zero for > + * the second memory bank. It is not an error and we can safely > + * avoid creating a zero-size memory bank. > + */ > + if ( total_size == 0 ) > + return true; > + > + bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; > + bank->start = gfn_to_gaddr(sgfn); > + bank->size = total_size; > + > + if ( !allocate_domheap_memory(d, total_size, &host) ) > + { > + printk(XENLOG_ERR "Failed to allocate (%"PRIpaddr"MB) pages to %pd\n", > + total_size >> 20, d); > + return false; > + } > + > + if ( guest_physmap_memory(d, &host, sgfn) ) > + { > + printk(XENLOG_ERR "Failed to map (%"PRIpaddr"MB) pages to %pd\n", > + total_size >> 20, d); > + return false; > } > > kinfo->mem.nr_banks++; > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Feb 07 20:57:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 20:57:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491439.760521 (Exim 4.92) (envelope-from ) id 1pPV26-0001q8-Ly; Tue, 07 Feb 2023 20:57:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491439.760521; Tue, 07 Feb 2023 20:57:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV26-0001q0-JL; Tue, 07 Feb 2023 20:57:42 +0000 Received: by outflank-mailman (input) for mailman id 491439; Tue, 07 Feb 2023 20:57:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV24-0001F5-Oe for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 20:57:40 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20627.outbound.protection.outlook.com [2a01:111:f400:fe5b::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d5cbae3-a72a-11ed-93b5-47a8fe42b414; Tue, 07 Feb 2023 21:57:38 +0100 (CET) Received: from MW4PR04CA0336.namprd04.prod.outlook.com (2603:10b6:303:8a::11) by PH7PR12MB6881.namprd12.prod.outlook.com (2603:10b6:510:1b7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 20:57:34 +0000 Received: from CO1NAM11FT070.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::9b) by MW4PR04CA0336.outlook.office365.com (2603:10b6:303:8a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 20:57:34 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT070.mail.protection.outlook.com (10.13.175.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 20:57:34 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 14:57:33 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 14:57:33 -0600 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 7 Feb 2023 14:57:31 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d5cbae3-a72a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFi2acilOQyyZ5F0R+S4QIOISzOghcyURqkW2K/UqqaLVLeaKxkMog3GRE1jj3eZyrxJlGi9kGVvUPVEG3wblpCUU8HwewDA0zhbUNioqsducnFGqg1nLN360SG4yKi6nU1O2fFo5YOz0yKZLTHv7XarXysOuCxhOhFb9pS1Q1Bn4wL+QGrJavT+R4PiRQ4fF98KZpQWaeZrXaNAoNndXhZDCKN+oLLoJsC43FtD0jDe2C1lxgMpnWP1HBga9BoR9kh4g6Nd+2lDG7IEdEPwAeg83yNjv1RsRoBu4DW2vas6DCUyiVuMpPhYvrLaELdYa/fu2fs6uPVo2laqGO/fRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+jYxCp6nCsjb+AHMJH4nWQu9hbmn/AD2c7tuvYBI2Fo=; b=k5OXh7WVluVUNLjwIzYiHbCnK8boIQIQnZf7xjmZDNWXXzEDCKeM/SCoZLFu6dkIlL4p0CiHJdITqjhZJv7l0Awx9Er4b8OC2xnOYbNB2h+p5fYNoxddHFOgOUutxNlhXd1wILiOQTJCjOX3Wgd+rYHd8mzwb02tqpLn6BW73HbAD8U8yDEY8FKFAtG5dqnkrRtl4ROscYM71VdHU8sQ0kmRE6DBJfIseljm311WYM3s2FAzmWZhYSvf6mAcVfYJnrt8Y2iAX4cFSrQMDAqo1wEfX6cAW/1vcnfjx0dhCVctVp7UShqys3SSe6cXsIgr7szX/rPvjN87k9PjsXhtfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+jYxCp6nCsjb+AHMJH4nWQu9hbmn/AD2c7tuvYBI2Fo=; b=o2p5MiDYTJfX5FyrWeXbl2bM11uKcS+7tQdSO3ed+ZtD4eGudhkq5uwAwFhZHSM001mlHapq/mVhnWc8XYvKJklF1qRlN4JTBXBEFiCYCLaxUMqB6tTIOySdSKaRVeTGzqlmoHGNh9jHR+Q2cVRX7YuH+Wb95J0iUBjSvhL05Sg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <093e99aa-608e-728c-6710-9fd100c16027@amd.com> Date: Tue, 7 Feb 2023 15:57:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Stewart Hildebrand Subject: Re: [PATCH v1 05/13] xen/arm: allocate shared memory from heap when host address not provided To: Penny Zheng , CC: , Stefano Stabellini , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-6-Penny.Zheng@arm.com> Content-Language: en-US In-Reply-To: <20221115025235.1378931-6-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT070:EE_|PH7PR12MB6881:EE_ X-MS-Office365-Filtering-Correlation-Id: 866c5ee9-2a7c-436c-b7a6-08db094defdf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RoulFy/4zKzeBgdgte/pCfjToMXi8aPplvls4mUn9uAzHzAvC2mRYr0dP4AhMLKc6+S6rIoyEPPhke2NCvMtnOYHm2zdjkZ9QJ2937s4ethkNqOiYWcFVp+V0ZkM5ZusLLpMXyhdEBHfX+6g+CqrylyxsjPIQixRUD05AKd58VkJRpYaYAXxOEMGQuKrEVAf+BtMWOjfdqlvEsrsDnlGAKk/uN5xV/MYu5ni3G7mxQLcwNVbkSMQy7l8U6rWyzGF6wDcr5SOhz0Yv5464K0e0kKE73/uR0mvtVxa2OKvffowPYN2eu0XjqEcGM9yfg2rSe3r65sYGRwEL3qj2UHwKFhLQ8dHVReQc9F/gLYoLVL78+Y7tk7h8wAKLDm81pYP64bGrtUV6fNXSmiCElMZusLOgQZxUquV1NXg61Vq4XUG3mejU4zRw2lWRkmMpKgYe+W1yj0/F0YT78Rvbrg40DVLeudoFMoHjJrBapOa5iOskcBNzg64phojAzNrinXXzy0IcLXi70gIGpYHyPeND43L3ngDsQbUSMjhKzRTuCvf8BLidhjOB6jBytO8PC9IrV3QrUe0Ux5kQBkH84OHy0/uZZyYt3hyFDXLt2VEGAsDKby9FZFbbNEY6l02tkJMABGVu9NcWQEVkrzVM46BCrNR9V5AyVncOBrSUKzjFrgcQ/kLeVQyEc1WD3ONksLoFwkSq+HRSWsQnFxzM1I44VnasBxoPDX8du3peVhnNJ9Nsr3smdJz742TEBRrQ2iLJMVac1gDhU9xh3uadKAzRg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199018)(46966006)(40470700004)(36840700001)(8936002)(86362001)(44832011)(41300700001)(5660300002)(4326008)(70586007)(8676002)(316002)(16576012)(110136005)(54906003)(82310400005)(40480700001)(36756003)(70206006)(2906002)(40460700003)(31696002)(47076005)(2616005)(426003)(83380400001)(26005)(53546011)(186003)(336012)(6666004)(31686004)(82740400003)(356005)(81166007)(36860700001)(478600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 20:57:34.2886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 866c5ee9-2a7c-436c-b7a6-08db094defdf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT070.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6881 On 11/14/22 21:52, Penny Zheng wrote: > when host address is not provided in "xen,shared-mem", we let Xen > allocate requested shared memory from heap, and once the shared memory is > allocated, it will be marked as static(PGC_static), which means that it will be > reserved as static memory, and will not go back to heap even on freeing. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 83 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 82 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index fbb196d8a4..3de96882a5 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -835,6 +835,72 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) > return true; > } > > +static int __init mark_shared_memory_static(struct shm_membank *shm_membank) > +{ > + unsigned int bank; > + unsigned long i, nr_mfns; > + struct page_info *pg; > + struct meminfo *meminfo; > + > + BUG_ON(!shm_membank->mem.banks.meminfo); > + meminfo = shm_membank->mem.banks.meminfo; > + for ( bank = 0; bank < meminfo->nr_banks; bank++ ) > + { > + pg = mfn_to_page(maddr_to_mfn(meminfo->bank[bank].start)); > + nr_mfns = PFN_DOWN(meminfo->bank[bank].size); > + > + for ( i = 0; i < nr_mfns; i++ ) > + { > + /* The page should be already allocated from heap. */ > + if ( !pg[i].count_info & PGC_state_inuse ) > + { > + printk(XENLOG_ERR > + "pg[%lu] MFN %"PRI_mfn" c=%#lx\n", > + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info); > + goto fail; > + } > + > + pg[i].count_info |= PGC_static; > + } > + } > + > + return 0; > + > + fail: > + while ( bank >= 0 ) When building with EXTRA_CFLAGS_XEN_CORE="-Wtype-limits -Wno-error=type-limits", we get the following warning: arch/arm/domain_build.c: In function ‘mark_shared_memory_static’: arch/arm/domain_build.c:879:18: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 879 | while ( bank >= 0 ) | ^~ > + { > + while ( --i >= 0 ) Similarly here: arch/arm/domain_build.c:881:21: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 881 | while ( --i >= 0 ) | ^~ > + pg[i].count_info &= ~PGC_static; > + i = PFN_DOWN(meminfo->bank[--bank].size); > + } > + > + return -EINVAL; > +} > + > +static int __init allocate_shared_memory(struct shm_membank *shm_membank, > + paddr_t psize) > +{ > + struct meminfo *banks; > + int ret; > + > + BUG_ON(shm_membank->mem.banks.meminfo != NULL); > + > + banks = xmalloc_bytes(sizeof(struct meminfo)); > + if ( banks == NULL ) > + return -ENOMEM; > + shm_membank->mem.banks.meminfo = banks; > + memset(shm_membank->mem.banks.meminfo, 0, sizeof(struct meminfo)); > + > + if ( !allocate_domheap_memory(NULL, psize, shm_membank->mem.banks.meminfo) ) > + return -EINVAL; > + > + ret = mark_shared_memory_static(shm_membank); > + if ( ret ) > + return ret; > + > + return 0; > +} > + > static mfn_t __init acquire_shared_memory_bank(struct domain *d, > paddr_t pbase, paddr_t psize) > { > @@ -975,7 +1041,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > unsigned int i; > const char *role_str; > const char *shm_id; > - bool owner_dom_io = true; > + bool owner_dom_io = true, paddr_assigned = true; > struct shm_membank *shm_membank; > > if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) > @@ -1035,6 +1101,21 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > return -ENOENT; > } > > + /* > + * When host address is not provided in "xen,shared-mem", > + * we let Xen allocate requested memory from heap at first domain. > + */ > + if ( !paddr_assigned && !shm_membank->mem.banks.meminfo ) > + { > + ret = allocate_shared_memory(shm_membank, psize); > + if ( ret ) > + { > + printk("%pd: failed to allocate shared memory bank(%"PRIpaddr"MB) from heap: %d\n", > + d, psize >> 20, ret); > + return ret; > + } > + } > + > /* > * DOMID_IO is a fake domain and is not described in the Device-Tree. > * Therefore when the owner of the shared region is DOMID_IO, we will > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Feb 07 20:58:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 20:58:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491445.760533 (Exim 4.92) (envelope-from ) id 1pPV38-0002PV-1a; Tue, 07 Feb 2023 20:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491445.760533; Tue, 07 Feb 2023 20:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV37-0002PO-Ud; Tue, 07 Feb 2023 20:58:45 +0000 Received: by outflank-mailman (input) for mailman id 491445; Tue, 07 Feb 2023 20:58:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPV36-0001Ev-ML for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 20:58:44 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34461414-a72a-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 21:58:43 +0100 (CET) Received: from DM5PR08CA0034.namprd08.prod.outlook.com (2603:10b6:4:60::23) by CH2PR12MB4311.namprd12.prod.outlook.com (2603:10b6:610:a8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 20:58:40 +0000 Received: from DM6NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:4:60:cafe::1) by DM5PR08CA0034.outlook.office365.com (2603:10b6:4:60::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 20:58:40 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT011.mail.protection.outlook.com (10.13.172.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 20:58:40 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 14:58:39 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 12:58:39 -0800 Received: from [192.168.137.15] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 7 Feb 2023 14:58:37 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34461414-a72a-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFOEBFDy6BNMGaaOBF6SjgM+VeCINujcEKQb5cBotnLp/PD0mvP86LDGb84DLd4tE+cD8QiRATY0ZVFZl+Pi1RQ2a7V7255vUESPG3T50caP8px+P85zwnW6ZgUnR1vhEuPcw4VZO9jY4E1BJAJhZE5lF3Nju/Q++qMTe3wB0uAQgjs/ECqILI+oYIZuwQ5k/JX9YaIbimmKNZvLO2HuVLhMgRu95VXXLbNtNluB/vok/TfE6FmxamTKfy34wcsNnQcdEVNapiNdJmELgM4/9hO6Yshr6ALgEndlKtXN6Ovp9c39RUweL/GEnyUjywYosXI5t4EtMqEQcBmp0wOs8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcWWu3sdWRHgqCgYw3wtJptaHraof7I55haYkmrwPo8=; b=bebhgvePiXpqLyZ3/2fHmXGgQr694PrP7OinAi3H127QKN9bn3mal5ng1nJa0zaXQBa3PCuSHR+FItCuHbVGdx9CmraFYc5kjOINJXjZtfebCMIdVugoSR4AwzzWahnpbTF7Nb2xo7AL2Co9yCovmus61b7q7hfHMzhFT92iiANEKGr3x2x52upeGDj/QaFycRZqzguNz55B48mp2UOU56iB1Zg8mPWhjpR7hRmnw3LAe//CrIyVFnYAj0suucUh3TAV000ruAewApf/nW2tmVKfTsIXbZ0HGznz4b/mD012TsSb2vZ6K/5CDVhkHIHWz1RnAiRpTPOrmAPI43G2OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcWWu3sdWRHgqCgYw3wtJptaHraof7I55haYkmrwPo8=; b=NpsBiV8no1NKlPQAZiRAm8fi4b6apLOcbopzM11Ne/qEWgXydu6BbKz3WUZdJRvCHeAlS7b3vBi1x7Oy0MO7ZcNi65KQE9yoM2mmaQbrpQiib1uwA1QOGMtSLp0QVH9zb+vRp0W+7qNJQs7uLpt1Wi8mNTmWrlZV83T1MqfDKhc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <11cd5c7c-235b-2daf-d12f-0c3cfe7e8185@amd.com> Date: Tue, 7 Feb 2023 15:58:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Stewart Hildebrand Subject: Re: [PATCH v1 06/13] xen/arm: assign shared memory to owner when host address not provided To: Penny Zheng , CC: , Stefano Stabellini , "Julien Grall" , Bertrand Marquis , Volodymyr Babchuk References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-7-Penny.Zheng@arm.com> Content-Language: en-US In-Reply-To: <20221115025235.1378931-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT011:EE_|CH2PR12MB4311:EE_ X-MS-Office365-Filtering-Correlation-Id: 4658e963-0150-4aba-1038-08db094e171b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K77+EtG/fiqBFFNOj+RmebA4gehZihBxQ2/t6Xcf72kZ53ORMOvCXhmaZbszf3UVDg2nm9R7Wfvsn+A1m+mTyTw19LAAn3MCXeHXiF0BVIkjBfHbSwGiIoWsuzhm1jhWnQ+75yI/UolY2/v7y2ZZ7fu0yVlrSCnscBUZXBrv5AwiJj9FzV6S6NnEBH33vpCI68d1O/IzW/NEcRsEor7bMagRNzfuD2LXhiZpum0febjtU7DXL1HbwkYFc9QE8Aws+RSSVR7XAMMXY80CCKazLfdIAkyTWHpE0AztwgxDOrcsbv6rHetSfmmmtdIyCifPOm5rq/+I7tlDWB0n71233ChZgMZO95pKGCJJP8OCRLezhC1KYjAljTWsKvpquzwsk0jupgzFt4+0oASHsviFRfPj+c8EpyUhPZ1qFBOk95+XQcEynfSoEhR6qe9CLuEovYf2fBcrIiTc0fpNG112jcXLNuu0q4CNtB6yNLjBheMxzRF0m/H0m8DYaT6xtdNAjen/DywMkJdOgP0aFgcLHSVKPXJzbDUeLwMlX+U+VrxutD2FSqSyVl4M8s1CdmnnF5IwjQifFB07mBIZ3KlMpq1cwwdvCMrFrD0AmJRekzgAJS/nu4Ev3f1j0M9/mPPezw+LnKyuxVLb/0l03PqAcC/aRrwtGrw/GG+CEDnnS41VNwJrDpo2+gKiNqvtiIGX8jpkq1HrqapZZeb2vFCOaXh7tDRfP8Gl/zpPa/vgT9hKemwKDvXAMh+om3de7OYH7xNUvfB6gSorgzALmwS89A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199018)(46966006)(36840700001)(40470700004)(40460700003)(40480700001)(82310400005)(47076005)(83380400001)(426003)(336012)(36860700001)(6666004)(478600001)(53546011)(356005)(2616005)(186003)(26005)(81166007)(31696002)(86362001)(36756003)(31686004)(82740400003)(8936002)(5660300002)(70586007)(41300700001)(70206006)(2906002)(44832011)(316002)(16576012)(110136005)(54906003)(4326008)(8676002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 20:58:40.1868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4658e963-0150-4aba-1038-08db094e171b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4311 Hi Penny, On 11/14/22 21:52, Penny Zheng wrote: > With the introduction of new scenario where host address is not provided > in "xen,shared-mem", the function "assign_shared_memory" shall be adapted > to it too. > > Shared memory will already be allocated from heap, when calling > "assign_shared_memory" with unprovided host address. > So in "assign_shared_memory", we just need to assign these static shared pages > to its owner domain using function "assign_pages", and add as many > additional reference as the number of borrowers. > > Signed-off-by: Penny Zheng > --- > xen/arch/arm/domain_build.c | 160 ++++++++++++++++++++++++++++++------ > 1 file changed, 133 insertions(+), 27 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3de96882a5..faf0784bb0 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -817,8 +817,12 @@ static bool __init is_shm_allocated_to_domio(struct shm_membank *shm_membank) > { > struct page_info *page; > struct domain *d; > + paddr_t pbase; > > - page = maddr_to_page(shm_membank->mem.bank->start); > + pbase = shm_membank->mem.banks.meminfo ? > + shm_membank->mem.banks.meminfo->bank[0].start : > + shm_membank->mem.bank->start; > + page = maddr_to_page(pbase); > d = page_get_owner_and_reference(page); > if ( d == NULL ) > return false; > @@ -907,6 +911,7 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > mfn_t smfn; > unsigned long nr_pfns; > int res; > + struct page_info *page; > > /* > * Pages of statically shared memory shall be included > @@ -922,33 +927,82 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, > d->max_pages += nr_pfns; > > smfn = maddr_to_mfn(pbase); > - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); > - if ( res ) > + page = mfn_to_page(smfn); > + /* > + * If page is allocated from heap as static shared memory, then we just > + * assign it to the owner domain > + */ > + if ( page->count_info == (PGC_state_inuse | PGC_static) ) > { > - printk(XENLOG_ERR > - "%pd: failed to acquire static memory: %d.\n", d, res); > - d->max_pages -= nr_pfns; > - return INVALID_MFN; > + res = assign_pages(page, nr_pfns, d, 0); > + if ( res ) > + { > + printk(XENLOG_ERR > + "%pd: failed to assign static memory: %d.\n", d, res); > + return INVALID_MFN; > + } > + } > + else > + { > + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); > + if ( res ) > + { > + printk(XENLOG_ERR > + "%pd: failed to acquire static memory: %d.\n", d, res); > + d->max_pages -= nr_pfns; > + return INVALID_MFN; > + } > } > > return smfn; > } > > -static int __init assign_shared_memory(struct domain *d, > - struct shm_membank *shm_membank, > - paddr_t gbase) > +static void __init remove_shared_memory_ref(struct page_info *page, > + unsigned long nr_pages, > + unsigned long nr_borrowers) > { > - mfn_t smfn; > - int ret = 0; > - unsigned long nr_pages, nr_borrowers, i; > - struct page_info *page; > - paddr_t pbase, psize; > + while ( --nr_pages >= 0 ) arch/arm/domain_build.c: In function ‘remove_shared_memory_ref’: arch/arm/domain_build.c:969:24: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 969 | while ( --nr_pages >= 0 ) | ^~ > + put_page_nr(page + nr_pages, nr_borrowers); > +} > > - pbase = shm_membank->mem.bank->start; > - psize = shm_membank->mem.bank->size; > +static int __init add_shared_memory_ref(struct domain *d, struct page_info *page, > + unsigned long nr_pages, > + unsigned long nr_borrowers) > +{ > + unsigned int i; > > - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", > - d, pbase, pbase + psize); > + /* > + * Instead of letting borrower domain get a page ref, we add as many > + * additional reference as the number of borrowers when the owner > + * is allocated, since there is a chance that owner is created > + * after borrower. > + * So if the borrower is created first, it will cause adding pages > + * in the P2M without reference. > + */ > + for ( i = 0; i < nr_pages; i++ ) > + { > + if ( !get_page_nr(page + i, d, nr_borrowers) ) > + { > + printk(XENLOG_ERR > + "Failed to add %lu references to page %"PRI_mfn".\n", > + nr_borrowers, mfn_x(page_to_mfn(page)) + i); > + goto fail; > + } > + } > + return 0; > + > + fail: > + remove_shared_memory_ref(page, i, nr_borrowers); > + return -EINVAL; > +} > + > +static int __init acquire_shared_memory(struct domain *d, > + paddr_t pbase, paddr_t psize, > + paddr_t gbase) > +{ > + mfn_t smfn; > + int ret = 0; > + unsigned long nr_pages; When building with EXTRA_CFLAGS_XEN_CORE="-Wunused-but-set-variable -Wno-error=unused-but-set-variable" arch/arm/domain_build.c: In function ‘acquire_shared_memory’: arch/arm/domain_build.c:1010:19: warning: variable ‘nr_pages’ set but not used [-Wunused-but-set-variable] 1010 | unsigned long nr_pages; | ^~~~~~~~ > > smfn = acquire_shared_memory_bank(d, pbase, psize); > if ( mfn_eq(smfn, INVALID_MFN) ) > @@ -970,6 +1024,44 @@ static int __init assign_shared_memory(struct domain *d, > } > } > > + return 0; > +} > + > +static int __init assign_shared_memory(struct domain *d, > + struct shm_membank *shm_membank, > + paddr_t gbase) > +{ > + int ret = 0; > + unsigned long nr_pages, nr_borrowers; > + struct page_info *page; > + unsigned int i; > + struct meminfo *meminfo; > + > + /* Host address is not provided in "xen,shared-mem" */ > + if ( shm_membank->mem.banks.meminfo ) > + { > + meminfo = shm_membank->mem.banks.meminfo; > + for ( i = 0; i < meminfo->nr_banks; i++ ) > + { > + ret = acquire_shared_memory(d, > + meminfo->bank[i].start, > + meminfo->bank[i].size, > + gbase); > + if ( ret ) > + return ret; > + > + gbase += meminfo->bank[i].size; > + } > + } > + else > + { > + ret = acquire_shared_memory(d, > + shm_membank->mem.bank->start, > + shm_membank->mem.bank->size, gbase); > + if ( ret ) > + return ret; > + } > + > /* > * Get the right amount of references per page, which is the number of > * borrower domains. > @@ -984,23 +1076,37 @@ static int __init assign_shared_memory(struct domain *d, > * So if the borrower is created first, it will cause adding pages > * in the P2M without reference. > */ > - page = mfn_to_page(smfn); > - for ( i = 0; i < nr_pages; i++ ) > + if ( shm_membank->mem.banks.meminfo ) > { > - if ( !get_page_nr(page + i, d, nr_borrowers) ) > + meminfo = shm_membank->mem.banks.meminfo; > + for ( i = 0; i < meminfo->nr_banks; i++ ) > { > - printk(XENLOG_ERR > - "Failed to add %lu references to page %"PRI_mfn".\n", > - nr_borrowers, mfn_x(smfn) + i); > - goto fail; > + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); > + nr_pages = PFN_DOWN(meminfo->bank[i].size); > + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); > + if ( ret ) > + goto fail; > } > } > + else > + { > + page = mfn_to_page( > + maddr_to_mfn(shm_membank->mem.bank->start)); > + nr_pages = shm_membank->mem.bank->size >> PAGE_SHIFT; > + ret = add_shared_memory_ref(d, page, nr_pages, nr_borrowers); > + if ( ret ) > + return ret; > + } > > return 0; > > fail: > while ( --i >= 0 ) I'm aware that this line is unchanged, and I'm not trying to introduce scope creep, but I still wanted to point this out because (1) it is similar in nature to other occurrences introduced in this series and (2) the body of the loop is changed: arch/arm/domain_build.c: In function ‘assign_shared_memory’: arch/arm/domain_build.c:1109:17: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 1109 | while ( --i >= 0 ) | ^~ > - put_page_nr(page + i, nr_borrowers); > + { > + page = mfn_to_page(maddr_to_mfn(meminfo->bank[i].start)); > + nr_pages = PFN_DOWN(meminfo->bank[i].size); > + remove_shared_memory_ref(page, nr_pages, nr_borrowers); > + } > return ret; > } > > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Feb 07 21:09:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Feb 2023 21:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491454.760544 (Exim 4.92) (envelope-from ) id 1pPVDV-0004CK-4v; Tue, 07 Feb 2023 21:09:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491454.760544; Tue, 07 Feb 2023 21:09:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPVDV-0004CD-0B; Tue, 07 Feb 2023 21:09:29 +0000 Received: by outflank-mailman (input) for mailman id 491454; Tue, 07 Feb 2023 21:09:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPVDT-0004C7-Ng for xen-devel@lists.xenproject.org; Tue, 07 Feb 2023 21:09:27 +0000 Received: from outgoing2021.csail.mit.edu (outgoing2021.csail.mit.edu [128.30.2.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2ac5836-a72b-11ed-933c-83870f6b2ba8; Tue, 07 Feb 2023 22:09:25 +0100 (CET) Received: from vmware-inc.ear2.seattle1.level3.net ([4.30.137.154] helo=srivatsab3MD6R.vmware.com) by outgoing2021.csail.mit.edu with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1pPVDJ-005MHi-J6; Tue, 07 Feb 2023 16:09:17 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2ac5836-a72b-11ed-933c-83870f6b2ba8 Subject: Re: [PATCH v2] x86/paravirt: merge activate_mm and dup_mmap callbacks To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Alexey Makhalov , VMware PV-Drivers Reviewers , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky , xen-devel@lists.xenproject.org References: <20230207075902.7539-1-jgross@suse.com> From: "Srivatsa S. Bhat" Message-ID: Date: Tue, 7 Feb 2023 13:09:15 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230207075902.7539-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/6/23 11:59 PM, Juergen Gross wrote: > The two paravirt callbacks .mmu.activate_mm and .mmu.dup_mmap are > sharing the same implementations in all cases: for Xen PV guests they > are pinning the PGD of the new mm_struct, and for all other cases > they are a NOP. > > In the end both callbacks are meant to register an address space with > the underlying hypervisor, so there needs to be only a single callback > for that purpose. > > So merge them to a common callback .mmu.enter_mmap (in contrast to the > corresponding already existing .mmu.exit_mmap). > > As the first parameter of the old callbacks isn't used, drop it from > the replacement one. > > Signed-off-by: Juergen Gross > Reviewed-by: Boris Ostrovsky Reviewed-by: Srivatsa S. Bhat (VMware) Regards, Srivatsa VMware Photon OS > --- > V2: > - expand commit message (Srivatsa S. Bhat) > --- > arch/x86/include/asm/mmu_context.h | 4 ++-- > arch/x86/include/asm/paravirt.h | 14 +++----------- > arch/x86/include/asm/paravirt_types.h | 7 ++----- > arch/x86/kernel/paravirt.c | 3 +-- > arch/x86/mm/init.c | 2 +- > arch/x86/xen/mmu_pv.c | 12 ++---------- > 6 files changed, 11 insertions(+), 31 deletions(-) > > diff --git a/arch/x86/include/asm/mmu_context.h b/arch/x86/include/asm/mmu_context.h > index b8d40ddeab00..6a14b6c2165c 100644 > --- a/arch/x86/include/asm/mmu_context.h > +++ b/arch/x86/include/asm/mmu_context.h > @@ -134,7 +134,7 @@ extern void switch_mm_irqs_off(struct mm_struct *prev, struct mm_struct *next, > > #define activate_mm(prev, next) \ > do { \ > - paravirt_activate_mm((prev), (next)); \ > + paravirt_enter_mmap(next); \ > switch_mm((prev), (next), NULL); \ > } while (0); > > @@ -167,7 +167,7 @@ static inline void arch_dup_pkeys(struct mm_struct *oldmm, > static inline int arch_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) > { > arch_dup_pkeys(oldmm, mm); > - paravirt_arch_dup_mmap(oldmm, mm); > + paravirt_enter_mmap(mm); > return ldt_dup_context(oldmm, mm); > } > > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index 73e9522db7c1..07bbdceaf35a 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -332,16 +332,9 @@ static inline void tss_update_io_bitmap(void) > } > #endif > > -static inline void paravirt_activate_mm(struct mm_struct *prev, > - struct mm_struct *next) > +static inline void paravirt_enter_mmap(struct mm_struct *next) > { > - PVOP_VCALL2(mmu.activate_mm, prev, next); > -} > - > -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, > - struct mm_struct *mm) > -{ > - PVOP_VCALL2(mmu.dup_mmap, oldmm, mm); > + PVOP_VCALL1(mmu.enter_mmap, next); > } > > static inline int paravirt_pgd_alloc(struct mm_struct *mm) > @@ -787,8 +780,7 @@ extern void default_banner(void); > > #ifndef __ASSEMBLY__ > #ifndef CONFIG_PARAVIRT_XXL > -static inline void paravirt_arch_dup_mmap(struct mm_struct *oldmm, > - struct mm_struct *mm) > +static inline void paravirt_enter_mmap(struct mm_struct *mm) > { > } > #endif > diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h > index 8c1da419260f..71bf64b963df 100644 > --- a/arch/x86/include/asm/paravirt_types.h > +++ b/arch/x86/include/asm/paravirt_types.h > @@ -164,11 +164,8 @@ struct pv_mmu_ops { > unsigned long (*read_cr3)(void); > void (*write_cr3)(unsigned long); > > - /* Hooks for intercepting the creation/use of an mm_struct. */ > - void (*activate_mm)(struct mm_struct *prev, > - struct mm_struct *next); > - void (*dup_mmap)(struct mm_struct *oldmm, > - struct mm_struct *mm); > + /* Hook for intercepting the creation/use of an mm_struct. */ > + void (*enter_mmap)(struct mm_struct *mm); > > /* Hooks for allocating and freeing a pagetable top-level */ > int (*pgd_alloc)(struct mm_struct *mm); > diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c > index 327757afb027..ff1109b9c6cd 100644 > --- a/arch/x86/kernel/paravirt.c > +++ b/arch/x86/kernel/paravirt.c > @@ -352,8 +352,7 @@ struct paravirt_patch_template pv_ops = { > .mmu.make_pte = PTE_IDENT, > .mmu.make_pgd = PTE_IDENT, > > - .mmu.dup_mmap = paravirt_nop, > - .mmu.activate_mm = paravirt_nop, > + .mmu.enter_mmap = paravirt_nop, > > .mmu.lazy_mode = { > .enter = paravirt_nop, > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c > index cb258f58fdc8..cbc53da4c1b4 100644 > --- a/arch/x86/mm/init.c > +++ b/arch/x86/mm/init.c > @@ -806,7 +806,7 @@ void __init poking_init(void) > BUG_ON(!poking_mm); > > /* Xen PV guests need the PGD to be pinned. */ > - paravirt_arch_dup_mmap(NULL, poking_mm); > + paravirt_enter_mmap(poking_mm); > > /* > * Randomize the poking address, but make sure that the following page > diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c > index ee29fb558f2e..b3b8d289b9ab 100644 > --- a/arch/x86/xen/mmu_pv.c > +++ b/arch/x86/xen/mmu_pv.c > @@ -885,14 +885,7 @@ void xen_mm_unpin_all(void) > spin_unlock(&pgd_lock); > } > > -static void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next) > -{ > - spin_lock(&next->page_table_lock); > - xen_pgd_pin(next); > - spin_unlock(&next->page_table_lock); > -} > - > -static void xen_dup_mmap(struct mm_struct *oldmm, struct mm_struct *mm) > +static void xen_enter_mmap(struct mm_struct *mm) > { > spin_lock(&mm->page_table_lock); > xen_pgd_pin(mm); > @@ -2153,8 +2146,7 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { > .make_p4d = PV_CALLEE_SAVE(xen_make_p4d), > #endif > > - .activate_mm = xen_activate_mm, > - .dup_mmap = xen_dup_mmap, > + .enter_mmap = xen_enter_mmap, > .exit_mmap = xen_exit_mmap, > > .lazy_mode = { > From xen-devel-bounces@lists.xenproject.org Wed Feb 08 01:21:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 01:21:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491466.760555 (Exim 4.92) (envelope-from ) id 1pPZ93-0005Nt-SF; Wed, 08 Feb 2023 01:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491466.760555; Wed, 08 Feb 2023 01:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZ93-0005Nm-Nu; Wed, 08 Feb 2023 01:21:09 +0000 Received: by outflank-mailman (input) for mailman id 491466; Wed, 08 Feb 2023 01:21:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZ92-0005NZ-17; Wed, 08 Feb 2023 01:21:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZ91-00019y-UU; Wed, 08 Feb 2023 01:21:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZ91-0005zu-Fz; Wed, 08 Feb 2023 01:21:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPZ91-0007gf-Fa; Wed, 08 Feb 2023 01:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WPE7yqvhRJsPGbn5TQZjl5RsFbjWK61W6R+IgWAh3ZQ=; b=PwTzM7LRQD3OOGfB1xurvdmhw3 TvNBAe5lJwWxRM+o6zGbxE2s14jFWe1zJBGcnWNsx4NhZ0ALBrCnL7FoHAzSiilkGeDefnWud6BFM pYHDj/3D2YM6yHFf/YKbYZ+69j8gRQ0KCVByPJCBGDqhXj5vG7iMTw1qRY1DzWG0QStk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 176449: regressions - trouble: fail/pass/starved X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:debian-di-install:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking qemu-mainline:build-armhf-libvirt:build-check(1):starved:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking qemu-mainline:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b X-Osstest-Versions-That: qemuu=387b2b52558bbb44ad74634415e1ab488d3c62a7 From: osstest service owner Date: Wed, 08 Feb 2023 01:21:07 +0000 flight 176449 qemu-mainline real [real] flight 176575 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176449/ http://logs.test-lab.xenproject.org/osstest/logs/176575/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 12 debian-di-install fail REGR. vs. 176342 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 176342 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176342 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176342 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176342 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: qemuu 6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b baseline version: qemuu 387b2b52558bbb44ad74634415e1ab488d3c62a7 Last test of basis 176342 2023-02-03 03:30:18 Z 4 days Failing since 176352 2023-02-03 17:40:20 Z 4 days 6 attempts Testing same since 176423 2023-02-06 15:35:52 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Alex Bennée Alexander Graf BALATON Zoltan Bernhard Beschow Daniel Henrique Barboza Daniel P. Berrangé David Hildenbrand Drew DeVault Emanuele Giuseppe Esposito Emilio Cota Eric Auger Evgeny Iakovlev Frederic Barrat Fuad Tabba Gerd Hoffmann Hanna Reitz Helge Deller Idan Horowitz Ilya Leoshkevich Keith Packard Kevin Wolf Laurent Vivier Letu Ren Marc-André Lureau Marcin Juszkiewicz Mark Cave-Ayland Markus Armbruster Mike Frysinger Murilo Opsfelder Araujo Paolo Bonzini Peter Maydell Philippe Mathieu-Daudé Richard Henderson Rui Wang Thomas Huth Xiang Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 4630 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 08 02:03:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 02:03:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491474.760566 (Exim 4.92) (envelope-from ) id 1pPZo9-00022l-2J; Wed, 08 Feb 2023 02:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491474.760566; Wed, 08 Feb 2023 02:03:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZo8-00022e-Us; Wed, 08 Feb 2023 02:03:36 +0000 Received: by outflank-mailman (input) for mailman id 491474; Wed, 08 Feb 2023 02:03:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPZo7-00022Y-5c for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 02:03:35 +0000 Received: from sonic315-55.consmr.mail.gq1.yahoo.com (sonic315-55.consmr.mail.gq1.yahoo.com [98.137.65.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c814daab-a754-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 03:03:31 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Wed, 8 Feb 2023 02:03:28 +0000 Received: by hermes--production-ne1-746bc6c6c4-j9j2r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6c67ca8b47a829739ee46a2e499b4e4c; Wed, 08 Feb 2023 02:03:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c814daab-a754-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1675821808; bh=NXJ9PRylLClq1paqhxQPO6X19sNqGm+8vVMc3JLv+yo=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=K81FqFtOTeBnloDm8unpt8jM7HSXiSqoSjHwDxcqWTgNmGjf1tNMjn4yFltK8b6ETRdF3aYHttqINhgLyYj5WPwO14VxAVOdjrChd1Byw4yqpXq89Qnfjk++D0DXz0pACrx12qOepvsyY/jA79XPfli7K9/OyIqKPQHLDZ7t4zJXUyhJqzDWKSEh8GxyadBC8AWgTcSEzRgphOr4KnawQ5NCDsgiU+OOBSsboODTosmEaMEOVLX7Zgne2COwsTNtdSOHnDQTElT37nxv+Y6YEOTbIZ2RHzD6N3BFoO53ec644VcVi2N63a4YneXyne1kP6Nzaq25thYteDcxHdrqHQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675821808; bh=kWlPj0khdqgamcY3cVxsxxVYNpSRMoDGw3WTDoMW/XM=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RExVFcu4TsjeJMcqv6P/tTrkNKS71TbcVS4EHEp8CXq5PoTCnr88GqkJiQVAxAKTr2JTBAhlJrbt/BDZbG4hlkAxoD9pQer2SSDTBl8Zob/BxWevEZS68j1FS1KZpts2Iks/02TVo3q2ePgv63awwSNCDyPde9opyxNXSTn4YLe0+p84Q0JFFrtlmvukrP4tIcAj6Cq1ng8TXPHKqkpnoRzsZ3b4uY6X3/9AS3kycLdXNCooPpUWawqLjcKGk6hDgOP1bwCPYDSZlMXz4MNX3hzBuo9t+95bdIUF/QNBG7R8naQTijFokx2sES1zooblSr0J3uAou8Hby9K8JieFLg== X-YMail-OSG: HdhH2KYVM1mUq4HnKWmrYNjCXKkD8WAM8t491iad3X6T7_EAe0YYzySz2eUIXaD xaTI2LKPoLQEtMVSoddtnOIxIpyvFZI.fbXxClaOxb3HZOuCTKjPxghK1BZ.QaRssSkk8G.Yor_W MdyDDWd57U9_.hIqAXG2HPcR3hBmvnqyi9YGO5q7E3_DQrqSYx0NbATXrZC0EkY2_wNHEUqHyBnx Is4.NX25k0lVY6..iNT939SG7w6biAgEtQW8ckKFWraN8E20E43Lyfeh34KhymL.v08XzW.XKa2d nttcy43MzS6ewwOEKT3HMpJIFBTjIzwnm3N5tmIKPk5iuWb2lYP49tEHFcioFvQuccf238KQSe7x TsRWUrsk_gT93B_XdS9Lp47.a59lDsHbWZSIB7iYKlkT86PJjPZlqxWbSHnxQVYYGkw8dEhvwWzD UBDg.UI8OA.DcHAO8iRgtWE7WNxyNytAAMZEVDXA1TWAx7QAborNhPngTnMW2zyInlNE2m5kFtGE 28rUxlB9JxhHPV5o7NWWaErCyYA6ZQ_.OHiHq6Q6IiDwJcTWwwWJRarCGy5y8VLnav2iP4cqLAkb 7MiRkJxkri.56BPxNyleSZpucB5dsahJ7IgIr8nSPs68IIkoniPm6dSh8ZIrM.O_drsAbWjS3Qpc feKocN9vJ8.JQ7mRmvgJeSqtJK1TExeilbtDSKIlfu7d19uZ7PwfdtRTLvHqQhHljZXw98Z5rMG3 dmvGSP3FNHsYw5UckRlsxVSeZa3rKXSGKZd3ZQKKJeoa1a6KbqyuTzEeP.lNCKbUKKxXZ2ASk6C6 _pi6hMIbbEHmXKGDtZp16JxHWE_OCE4ZYnLApPevldrzPa9g4XY.5ZObcs2eR9w8jAqD_UmWyL84 H1mtNznwoslQT_Nzf7WO_VwRlVsqOCwblO2F6EzPFdmNpUo3dEio2LJ32udP7WnNn2DrZYiGXxbu 5g3fDaFBuRThhOH.ZAXR4.hKMWjHdPE1unfUCWzAuMzIlGf.ScUnzD8IKHj5eyaRy4YLYNuwgZxx tE4bfaB0PQQpN60cOFSyiQmNlv1kFjgxPTFxXqdvfyTUWhGsb_GzoDR2Xeod56R168q4Rz9XQHWE .aW0W2d1_hUwTdPeMRiGKGSBeJVSTRNrtRs7UPqr2AA.s08NtJMccSg64FAyKsnwOGbo7X7QbQFv SnHBmvwOG89etq8D5ZyX7zvYrhut9EgPUM4a_DQZqrmK83Si1PBXxImxCEWsPWKhvbUxEQci9wCN cXJgPtcCX8yXm1v3EABhJ4t5WEiUDCoz2p29zLgmZfDUBIHrzJ5YMctOJtnxR1HOcUUJ.fMgtia9 w69lYx8UGB13Gf7XPmiiyKbnVuUKTeKB47Placr9tYLbsK4FYoBJ.Y6b5UkO84RrTbBem9Cawcf8 ChQ9Fk7cd5zwTvUo08anwmcUJqcwgZBCJ7TFV6vZpc6eeTFc0AK_y3h4Z6SbEowHYS82foAGsaO_ k3Uv9_EgU2LrbzxZrwbwtET2Q85.e0JtHU8HJnKBFSJwGE6rto.JpGOrj4I4TIFm2KCUCVZi2rGX PX3OG8kckEqzvAJqREbpAyoXj5XDvXGv4c8KN.dwnzpMaqyXeJLw3LepVJJS4dBM.lKJ3Ym6O3Wn ZCi101UTfl0MRaIIETFQ_a4fFlfyMDcXwM1Wdi9h9kKPKt1j7W0EFs4vP5YamW1Cs4QJf7chKTDx iaIh17eguneIV3rUEWxP05oP_VX1zZJ8k4ku1BNTwe5yDp1B1Vq_YPilJMCDx.IlKHnjtYWWJSC_ rCYjUn4Bgs433Y_AJxFzF9r6kuOMjdUnhrlIQKzVcFQwu7aUdIKLnrdxFOyHIbT6hmNmHc.lZTm2 u5OsylnaUTidIL2_88mew0pCbV.G1TDkiJ6qFAdwfh2dsN0PGM9MXOb4H9y7RaiBZncWYEq6OF4y SGdREhllhbjr795.WE6gkjPoFzJlXikjxQs8.tgORiTCpmwfLtj5zZ9q.kcAMvvGGIQJt033.qmZ EyhwLQosavtEt_CM2ULZzJ0R_uecKXJd3FYRhQS4uSvMjnBzvpgEO.vDIW_5_s0atxIt8VuVHNzg TT.xUseeyax5yKWXEqKA110m0LxOp0qNtvKOYCdn5pkqUNx939atMDPUgCAjw2OW_XyvLkSd3He. 9SgLZPvwlOboR3app02mNQ3.IUSvVVaqXHwJVH3uQ_acHma4bN0.WvorHyeMrhfvAUxUrpCX65Ih o X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , xen-devel@lists.xenproject.org, qemu-stable@nongnu.org Subject: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator Date: Tue, 7 Feb 2023 21:03:05 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 4262 Commit 998250e97661 ("xen, gfx passthrough: register host bridge specific to passthrough") uses the igd-passthrough-i440FX pci host device with the xenfv machine type and igd-passthru=on, but using it for the pc machine type, xen accelerator, and igd-passtru=on was omitted from that commit. The igd-passthru-i440FX pci host device is also needed for guests configured with the pc machine type, the xen accelerator, and igd-passthru=on. Specifically, tests show that not using the igd-specific pci host device with the Intel igd passed through to the guest results in slower startup performance and reduced resolution of the display during startup. This patch fixes this issue. To simplify the logic that is needed to support both the --enable-xen and the --disable-xen configure options, introduce the boolean symbol pc_xen_igd_gfx_pt_enabled() whose value is set appropriately in the sysemu/xen.h header file as the test to determine whether or not to use the igd-passthrough-i440FX pci host device instead of the normal i440FX pci host device. Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to passthrough") Signed-off-by: Chuck Zmudzinski --- This patch is intended to replace or complement a recently proposed patch that modifies slot_reserved_mask for the xenfv machine with igd-passthru=on in order to fix the problem of Qemu not reserving slot 2 for the Intel IGD for the xenfv machine type. This patch provides a simple way to improve Qemu support for the Intel IGD with the xen accelerator without needing to change how slot_reserved_mask functions. For reference, the latest version of the patch to fix the xenfv machine using slot_reserved_mask is at: https://lore.kernel.org/qemu-devel/b1b4a21fe9a600b1322742dda55a40e9961daa57.1674346505.git.brchuckz@aol.com/ Reason for introducing the new boolean pc_xen_igd_gfx_pt_enabled(): It is also possible to use xen_igd_gfx_pt_enabled() directly to check if the igd-passthru-i440FX pci host device is needed in this patch, but in that case it would be necessary to implement it in accel/stubs/xen-stub.c like this: bool xen_igd_gfx_pt_enabled(void) { return false; } to cover the case when Qemu is configured with --disable-xen. I thought it was simpler to introduce the same boolean prefixed with pc_ and set it to 0 when --disable-xen is the configure option, and that explains why the proposed patch introduces pc_xen_igd_gfx_pt_enabled() instead of using xen_igd_gfx_pt_enabled() directly. Another reason to use pc_xen_igd_gfx_pt_enabled() is to distinguish it from xen_igd_gfx_pt_enabled() in hw/i386/pc_piix.c, because the use of xen_igd_gfx_pt_enabled() is guarded by CONFIG_XEN but this patch needs to place the boolean in a position that is not guarded by CONFIG_XEN. This approach will simplify any future effort to move the code in pc_piix.c that is not guarded by CONFIG_XEN to a xen-specific file. hw/i386/pc_piix.c | 2 ++ include/sysemu/xen.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index df64dd8dcc..fd5b9ae1eb 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -433,6 +433,8 @@ static void pc_xen_hvm_init(MachineState *machine) compat(machine); \ } \ pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, \ + pc_xen_igd_gfx_pt_enabled() ? \ + TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE : \ TYPE_I440FX_PCI_DEVICE); \ } \ DEFINE_PC_MACHINE(suffix, name, pc_init_##suffix, optionfn) diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index 0ca25697e4..99ae41e619 100644 --- a/include/sysemu/xen.h +++ b/include/sysemu/xen.h @@ -23,6 +23,7 @@ extern bool xen_allowed; #define xen_enabled() (xen_allowed) +#define pc_xen_igd_gfx_pt_enabled() xen_igd_gfx_pt_enabled() #ifndef CONFIG_USER_ONLY void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); @@ -33,6 +34,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, #else /* !CONFIG_XEN_IS_POSSIBLE */ #define xen_enabled() 0 +#define pc_xen_igd_gfx_pt_enabled() 0 #ifndef CONFIG_USER_ONLY static inline void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) { -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 02:46:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 02:46:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491499.760629 (Exim 4.92) (envelope-from ) id 1pPaTN-0007Yi-4r; Wed, 08 Feb 2023 02:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491499.760629; Wed, 08 Feb 2023 02:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPaTN-0007YZ-1x; Wed, 08 Feb 2023 02:46:13 +0000 Received: by outflank-mailman (input) for mailman id 491499; Wed, 08 Feb 2023 02:46:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPaTL-0007YK-Iw; Wed, 08 Feb 2023 02:46:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPaTL-0003Yr-HO; Wed, 08 Feb 2023 02:46:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPaTL-0002Uf-8B; Wed, 08 Feb 2023 02:46:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPaTL-0000YM-7l; Wed, 08 Feb 2023 02:46:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=luCv8x5INA29EkJeez54xbHlRETSqilJBNrLbpTJAAk=; b=iIw+a+z7RFo0QZ1yOK4oET9ELU 9K42DKxd+hiTsDbsjkJic3iYlck2HtKbUfXeOnb/vAx/kAif7tcfAezwFBW8CN5D8EEhacQtYXZHj 0F5k5rMm33Zh+c8shrphiAibl6f77z8P0R1R4A4AXNXolG0F2Q0QLuyvSdnYWJV6PL0Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176453: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=6c707d4573f5df2b60503dfeedc10b33cebd60d1 X-Osstest-Versions-That: xen=a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e From: osstest service owner Date: Wed, 08 Feb 2023 02:46:11 +0000 flight 176453 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176453/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176409 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176409 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176409 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176409 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176409 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176409 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 6c707d4573f5df2b60503dfeedc10b33cebd60d1 baseline version: xen a21c9e6ddfee6d21dff1f18c299cb94a47b32c9e Last test of basis 176409 2023-02-06 01:53:25 Z 2 days Failing since 176428 2023-02-06 17:07:16 Z 1 days 2 attempts Testing same since 176453 2023-02-07 12:55:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Bernhard Kaindl Christian Lindig Edwin Török Edwin Török Henry Wang Jan Beulich Juergen Gross Julien Grall Krister Johansen Marek Marczykowski-Górecki Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a21c9e6ddf..6c707d4573 6c707d4573f5df2b60503dfeedc10b33cebd60d1 -> master From xen-devel-bounces@lists.xenproject.org Wed Feb 08 04:51:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 04:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491521.760687 (Exim 4.92) (envelope-from ) id 1pPcQZ-0005N4-Ma; Wed, 08 Feb 2023 04:51:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491521.760687; Wed, 08 Feb 2023 04:51:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQZ-0005Mu-Iu; Wed, 08 Feb 2023 04:51:27 +0000 Received: by outflank-mailman (input) for mailman id 491521; Wed, 08 Feb 2023 04:51:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQY-0005Mg-Dt for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 04:51:27 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a47bc01-a76c-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 05:51:21 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1DD5D5C00E6; Tue, 7 Feb 2023 23:51:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 07 Feb 2023 23:51:19 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 23:51:16 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a47bc01-a76c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1675831879; x= 1675918279; bh=aVO6hKdg+qs1t/q894FccNAEhBlymG5Vl6MNYUKRsPU=; b=b kBBeLSwWy0cB4pTi14RcAk3PgmE16THrLkuybE3HQY99MInDYqFdRaCicLTO9mAi zEZM2Aa7+nr5sWwzvMhwjqF46KVJSyVVb/km8/5fd9OmQpN8501w4LM6wgQjCbx2 0YXDX1H9vYjpQDkgjC8X9zXQkJS91/dBu90sPtBZZQt8tXpJP5rMx2rtWukx3V4M vM8E5LDnAKg0s8ouVJQYVK41bjESIu5u+IKDXxJipmED7QnQXejn225/HWEZICa6 QR5ixtR3FaoQlH7W7o01pTmb+z9wx+6wS//6cLgq3Bh6YFX7Oz0sJh8wK7tUyHPZ ThgpdHm1ozVgjBleMR3BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675831879; x=1675918279; bh=aVO6hKdg+qs1t/q894FccNAEhBlymG5Vl6M NYUKRsPU=; b=TUYXQxxkn4r+jNqGODnl50sFUBPQh8lBgAQU4gucJ30bd+bQM5k raH4P7CSdkfDuxLFOwW7cRQRxByKnqpTvQWGAk2MA5Ras07PypCJ6mw4r9KUIcsX rymfYRYvZDfXnSkrf/vg3yllBTIX1IvLidGmhEZDVNRXCnDERf/QLo7csr8snWIg MFuJqKUnF90ApjtPkgE1gWEUzRe06IqvTWnqRyNKHPVgvVHLwTcpdW4iJdyn7DUB KmZXXvcrNTky54Y8hudONyJNsuExShu3XMiBic21fCzhM+2GdHFuuV+Vffdmhy45 sXn21NVCWJrPzAwCRsKeRYj3XkKvPoylcYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdehieduudefleejjeeuleeiuddtieet teevtdfhfedtiefhvdffleehudefgfevnecuffhomhgrihhnpehhthhtphhstghophihih hnghegqddqtghrvgguihhtshdvqdgtohhnfhhighdrmhhknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvth hhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Daniel De Graaf , Quan Xu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant , Elena Ufimtseva , Nick Rosbrook , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jun Nakajima , Kevin Tian , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh Subject: [PATCH 0/4] Stop using insecure transports Date: Tue, 7 Feb 2023 23:51:03 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Demi Marie Obenour (4): Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http:// with https:// Miscellaneous and documentation: Only use TLS-protected transports GPL License Boilerplate: Switch from HTTP to HTTPS COPYING | 4 ++-- CREDITS | 2 +- Config.mk | 20 +++++----------- README | 8 +++---- SUPPORT.md | 2 +- automation/build/centos/CentOS-7.2.repo | 8 +++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/README.remus | 2 +- docs/conf.py | 2 +- docs/features/feature-levelling.pandoc | 4 ++-- docs/features/intel_psr_cat_cdp.pandoc | 2 +- docs/features/intel_psr_mba.pandoc | 2 +- docs/features/migration.pandoc | 2 +- docs/features/sched_credit.pandoc | 4 ++-- docs/features/sched_credit2.pandoc | 6 ++--- docs/features/sched_rtds.pandoc | 4 ++-- docs/misc/amd-ucode-container.txt | 4 ++-- docs/misc/arm/booting.txt | 4 ++-- docs/misc/arm/passthrough.txt | 2 +- docs/misc/kconfig-language.rst | 14 +++++------ docs/misc/livepatch.pandoc | 2 +- docs/misc/netif-staging-grants.pandoc | 10 ++++---- docs/misc/pvcalls.pandoc | 18 +++++++------- docs/misc/status-override-table-spec.fodt | 2 +- docs/misc/vtd-pi.txt | 6 ++--- docs/misc/vtd.txt | 4 ++-- docs/misc/xen-env-table-spec.fodt | 2 +- docs/misc/xenstore-paths.pandoc | 2 +- docs/misc/xl-psr.pandoc | 2 +- docs/misc/xsm-flask.txt | 2 +- docs/process/release-technician-checklist.txt | 2 +- docs/process/sending-patches.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- m4/README.source | 4 ++-- m4/ax_compare_version.m4 | 4 ++-- m4/ocaml.m4 | 2 +- m4/pkg.m4 | 4 ++-- m4/systemd.m4 | 2 +- misc/coverity/model.c | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++------- stubdom/configure.ac | 24 ++++++++++++------- stubdom/grub.patches/10graphics.diff | 4 ++-- stubdom/grub.patches/61btrfs.diff | 4 ++-- stubdom/vtpmmgr/tpmrsa.c | 6 ++--- stubdom/vtpmmgr/tpmrsa.h | 4 ++-- tools/configure | 16 ++++++------- tools/console/client/main.c | 2 +- tools/console/daemon/io.c | 2 +- tools/console/daemon/io.h | 2 +- tools/console/daemon/main.c | 2 +- tools/console/daemon/utils.c | 2 +- tools/console/daemon/utils.h | 2 +- tools/debugger/gdbsx/README | 2 +- tools/debugger/gdbsx/gx/gx.h | 2 +- tools/debugger/gdbsx/gx/gx_comm.c | 4 ++-- tools/debugger/gdbsx/gx/gx_local.c | 2 +- tools/debugger/gdbsx/gx/gx_main.c | 2 +- tools/debugger/gdbsx/gx/gx_utils.c | 2 +- tools/debugger/gdbsx/gx/xg_dummy.c | 2 +- tools/debugger/gdbsx/xg/xg_main.c | 2 +- tools/debugger/gdbsx/xg/xg_public.h | 2 +- tools/examples/xeninfo.pl | 6 ++--- tools/firmware/Makefile | 2 +- tools/firmware/etherboot/Makefile | 4 ++-- tools/firmware/etherboot/README | 23 +----------------- tools/firmware/hvmloader/32bitbios_support.c | 2 +- tools/firmware/hvmloader/Makefile | 2 +- tools/firmware/hvmloader/cacheattr.c | 2 +- tools/firmware/hvmloader/e820.c | 2 +- tools/firmware/hvmloader/hvmloader.c | 2 +- tools/firmware/hvmloader/mp_tables.c | 2 +- tools/firmware/hvmloader/optionroms.c | 2 +- tools/firmware/hvmloader/ovmf.c | 2 +- tools/firmware/hvmloader/pci.c | 2 +- tools/firmware/hvmloader/pci_regs.h | 2 +- tools/firmware/hvmloader/pir.c | 2 +- tools/firmware/hvmloader/pir_types.h | 4 ++-- tools/firmware/hvmloader/rombios.c | 2 +- tools/firmware/hvmloader/seabios.c | 2 +- tools/firmware/hvmloader/smbios.c | 2 +- tools/firmware/hvmloader/smbios_types.h | 4 ++-- tools/firmware/hvmloader/smp.c | 2 +- tools/firmware/hvmloader/tests.c | 2 +- tools/firmware/hvmloader/util.c | 2 +- tools/firmware/rombios/32bit/32bitbios.c | 2 +- tools/firmware/rombios/32bit/mkhex | 2 +- tools/firmware/rombios/32bit/pmm.c | 4 ++-- .../firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- .../rombios/32bit/tcgbios/tpm_drivers.c | 2 +- tools/firmware/rombios/32bit/util.c | 2 +- tools/firmware/rombios/32bitgateway.c | 2 +- tools/firmware/rombios/apmbios.S | 2 +- tools/firmware/rombios/rombios.c | 10 ++++---- tools/firmware/rombios/rombios.h | 2 +- tools/firmware/rombios/tcgbios.c | 2 +- tools/firmware/vgabios/COPYING | 2 +- tools/firmware/vgabios/README | 10 ++++---- tools/firmware/vgabios/biossums.c | 2 +- tools/firmware/vgabios/clext.c | 2 +- tools/firmware/vgabios/vbe.c | 4 ++-- tools/firmware/vgabios/vbe_display_api.txt | 8 +++---- tools/firmware/vgabios/vgabios.c | 12 +++++----- tools/fuzz/README.afl | 2 +- tools/golang/xenlight/xenlight.go | 2 +- tools/hotplug/Linux/block-common.sh | 2 +- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/hotplug/Linux/external-device-migrate | 2 +- tools/hotplug/Linux/launch-xenstore.in | 2 +- tools/hotplug/Linux/locking.sh | 2 +- tools/hotplug/Linux/logging.sh | 2 +- tools/hotplug/Linux/vif-common.sh | 2 +- tools/hotplug/Linux/xen-hotplug-common.sh.in | 2 +- tools/hotplug/Linux/xen-network-common.sh | 2 +- tools/hotplug/Linux/xen-script-common.sh | 2 +- tools/hotplug/Linux/xendomains.in | 2 +- tools/hotplug/NetBSD/locking.sh | 2 +- tools/include/libxenvchan.h | 4 ++-- tools/include/libxl.h | 2 +- tools/include/xencall.h | 2 +- tools/include/xenctrl.h | 2 +- tools/include/xendevicemodel.h | 2 +- tools/include/xenevtchn.h | 2 +- tools/include/xenforeignmemory.h | 2 +- tools/include/xengnttab.h | 2 +- tools/include/xenguest.h | 2 +- tools/include/xenhypfs.h | 2 +- tools/include/xenstore.h | 2 +- tools/include/xenstore_lib.h | 2 +- tools/include/xentoolcore.h | 2 +- tools/include/xentoolcore_internal.h | 2 +- tools/include/xentoollog.h | 2 +- tools/libacpi/build.c | 2 +- tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 +- tools/libfsimage/fat/fat.h | 2 +- tools/libfsimage/fat/fsys_fat.c | 2 +- tools/libfsimage/iso9660/fsys_iso9660.c | 2 +- tools/libfsimage/iso9660/iso9660.h | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 4 ++-- tools/libfsimage/ufs/fsys_ufs.c | 2 +- tools/libfsimage/xfs/fsys_xfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 6 ++--- tools/libfsimage/zfs/Makefile | 2 +- tools/libfsimage/zfs/filesys.h | 2 +- tools/libfsimage/zfs/fsi_zfs.c | 2 +- tools/libfsimage/zfs/fsi_zfs.h | 2 +- tools/libfsimage/zfs/fsys_zfs.c | 2 +- tools/libfsimage/zfs/fsys_zfs.h | 2 +- tools/libfsimage/zfs/mb_info.h | 2 +- tools/libfsimage/zfs/shared.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu_objset.h | 2 +- tools/libfsimage/zfs/zfs-include/dnode.h | 2 +- .../libfsimage/zfs/zfs-include/dsl_dataset.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dir.h | 2 +- tools/libfsimage/zfs/zfs-include/sa_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/spa.h | 2 +- .../zfs/zfs-include/uberblock_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/vdev_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_leaf.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_acl.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_znode.h | 2 +- tools/libfsimage/zfs/zfs-include/zil.h | 2 +- tools/libfsimage/zfs/zfs-include/zio.h | 2 +- .../libfsimage/zfs/zfs-include/zio_checksum.h | 2 +- tools/libfsimage/zfs/zfs_fletcher.c | 2 +- tools/libfsimage/zfs/zfs_lzjb.c | 2 +- tools/libfsimage/zfs/zfs_sha256.c | 4 ++-- tools/libs/call/buffer.c | 2 +- tools/libs/call/core.c | 2 +- tools/libs/call/freebsd.c | 2 +- tools/libs/call/linux.c | 2 +- tools/libs/call/minios.c | 2 +- tools/libs/call/netbsd.c | 2 +- tools/libs/call/solaris.c | 2 +- tools/libs/ctrl/xc_altp2m.c | 2 +- tools/libs/ctrl/xc_cpu_hotplug.c | 2 +- tools/libs/ctrl/xc_cpupool.c | 2 +- tools/libs/ctrl/xc_csched.c | 2 +- tools/libs/ctrl/xc_csched2.c | 2 +- tools/libs/ctrl/xc_domain.c | 2 +- tools/libs/ctrl/xc_evtchn.c | 2 +- tools/libs/ctrl/xc_flask.c | 2 +- tools/libs/ctrl/xc_foreign_memory.c | 2 +- tools/libs/ctrl/xc_freebsd.c | 2 +- tools/libs/ctrl/xc_gnttab.c | 2 +- tools/libs/ctrl/xc_hcall_buf.c | 2 +- tools/libs/ctrl/xc_linux.c | 2 +- tools/libs/ctrl/xc_mem_access.c | 2 +- tools/libs/ctrl/xc_mem_paging.c | 2 +- tools/libs/ctrl/xc_memshr.c | 2 +- tools/libs/ctrl/xc_minios.c | 2 +- tools/libs/ctrl/xc_misc.c | 2 +- tools/libs/ctrl/xc_monitor.c | 2 +- tools/libs/ctrl/xc_netbsd.c | 2 +- tools/libs/ctrl/xc_pagetab.c | 2 +- tools/libs/ctrl/xc_physdev.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/ctrl/xc_rt.c | 2 +- tools/libs/ctrl/xc_solaris.c | 2 +- tools/libs/ctrl/xc_tbuf.c | 2 +- tools/libs/ctrl/xc_vm_event.c | 2 +- tools/libs/ctrl/xc_vmtrace.c | 2 +- tools/libs/devicemodel/common.c | 2 +- tools/libs/devicemodel/compat.c | 2 +- tools/libs/devicemodel/core.c | 2 +- tools/libs/evtchn/core.c | 2 +- tools/libs/evtchn/freebsd.c | 2 +- tools/libs/evtchn/linux.c | 2 +- tools/libs/evtchn/minios.c | 2 +- tools/libs/evtchn/netbsd.c | 2 +- tools/libs/evtchn/solaris.c | 2 +- tools/libs/foreignmemory/compat.c | 2 +- tools/libs/foreignmemory/core.c | 2 +- tools/libs/foreignmemory/freebsd.c | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/foreignmemory/minios.c | 2 +- tools/libs/foreignmemory/netbsd.c | 2 +- tools/libs/foreignmemory/solaris.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/gntshr_core.c | 2 +- tools/libs/gnttab/gntshr_unimp.c | 2 +- tools/libs/gnttab/gnttab_core.c | 2 +- tools/libs/gnttab/gnttab_unimp.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/gnttab/minios.c | 2 +- tools/libs/gnttab/netbsd.c | 2 +- tools/libs/guest/xg_core.c | 2 +- tools/libs/guest/xg_core.h | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_core_arm.h | 2 +- tools/libs/guest/xg_core_x86.c | 2 +- tools/libs/guest/xg_core_x86.h | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_armzimageloader.c | 2 +- tools/libs/guest/xg_dom_binloader.c | 2 +- tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_compat_linux.c | 2 +- tools/libs/guest/xg_dom_core.c | 2 +- tools/libs/guest/xg_dom_elfloader.c | 2 +- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_domain.c | 2 +- tools/libs/guest/xg_nomigrate.c | 2 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_private.c | 2 +- tools/libs/guest/xg_private.h | 2 +- tools/libs/guest/xg_resume.c | 2 +- tools/libs/guest/xg_save_restore.h | 2 +- tools/libs/guest/xg_suspend.c | 2 +- tools/libs/hypfs/core.c | 2 +- tools/libs/light/libxl_genid.c | 2 +- tools/libs/stat/COPYING | 2 +- tools/libs/stat/xenstat_qmp.c | 2 +- tools/libs/store/xs.c | 2 +- tools/libs/toolcore/handlereg.c | 2 +- tools/libs/toollog/xtl_core.c | 2 +- tools/libs/toollog/xtl_logger_stdio.c | 2 +- tools/libs/util/libxlu_cfg_y.c | 2 +- tools/libs/util/libxlu_cfg_y.h | 2 +- tools/libs/vchan/init.c | 2 +- tools/libs/vchan/io.c | 2 +- tools/libs/vchan/vchan.h | 2 +- tools/misc/mkhex | 2 +- tools/misc/mkrpm | 2 +- tools/misc/xen-mceinj.c | 2 +- tools/misc/xen-vmtrace.c | 2 +- tools/misc/xencov.c | 2 +- tools/misc/xenpm.c | 2 +- tools/misc/xenpvnetboot | 6 ++--- tools/ocaml/LICENSE | 2 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 2 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2 +- tools/pygrub/src/ExtLinuxConf.py | 2 +- tools/pygrub/src/GrubConf.py | 2 +- tools/pygrub/src/pygrub | 2 +- tools/python/xen/lowlevel/xs/xs.c | 2 +- tools/tests/depriv/depriv-fd-checker.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/vhpet/main.c | 4 ++-- tools/tests/vpci/emul.h | 2 +- tools/tests/vpci/main.c | 2 +- tools/tests/x86_emulator/blowfish.c | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/vchan/node-select.c | 2 +- tools/vchan/node.c | 2 +- tools/vchan/vchan-socket-proxy.c | 2 +- tools/xenmon/COPYING | 2 +- tools/xenmon/setmask.c | 2 +- tools/xenmon/xenbaked.c | 2 +- tools/xenmon/xenbaked.h | 2 +- tools/xenmon/xenmon.py | 2 +- tools/xenpaging/file_ops.c | 2 +- tools/xenpaging/file_ops.h | 2 +- tools/xenpaging/policy.h | 2 +- tools/xenpaging/policy_default.c | 2 +- tools/xenpaging/xenpaging.c | 2 +- tools/xenpaging/xenpaging.h | 2 +- tools/xenpmd/xenpmd.c | 2 +- tools/xenstore/COPYING | 2 +- tools/xenstore/include/xenstore_state.h | 2 +- tools/xenstore/talloc.c | 4 ++-- tools/xenstore/talloc.h | 2 +- tools/xenstore/talloc_guide.txt | 2 +- tools/xenstore/tdb.c | 2 +- tools/xenstore/tdb.h | 2 +- tools/xenstore/xenstored_control.c | 2 +- tools/xenstore/xenstored_control.h | 2 +- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 2 +- tools/xenstore/xenstored_domain.h | 2 +- tools/xenstore/xenstored_minios.c | 2 +- tools/xenstore/xenstored_posix.c | 2 +- tools/xenstore/xenstored_transaction.c | 2 +- tools/xenstore/xenstored_transaction.h | 2 +- tools/xenstore/xenstored_watch.c | 2 +- tools/xenstore/xenstored_watch.h | 2 +- tools/xenstore/xs_lib.c | 2 +- tools/xenstore/xs_lib.h | 2 +- tools/xentop/xentop.c | 2 +- tools/xentrace/xenalyze.c | 2 +- tools/xl/check-xl-disk-parse | 6 ++--- xen/COPYING | 2 +- xen/arch/arm/acpi/boot.c | 2 +- xen/arch/arm/acpi/lib.c | 2 +- xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm32/insn.c | 2 +- xen/arch/arm/arm32/lib/bitops.c | 2 +- xen/arch/arm/arm32/lib/lib1funcs.S | 2 +- xen/arch/arm/arm32/lib/lshrdi3.S | 2 +- xen/arch/arm/arm64/bpi.S | 2 +- xen/arch/arm/arm64/cache.S | 2 +- xen/arch/arm/arm64/debug-meson.inc | 2 +- xen/arch/arm/arm64/debug-mvebu.inc | 2 +- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/arm64/insn.c | 2 +- xen/arch/arm/arm64/lib/bitops.c | 2 +- xen/arch/arm/arm64/lib/clear_page.S | 2 +- xen/arch/arm/arm64/lib/memchr.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 4 ++-- xen/arch/arm/arm64/lib/memcpy.S | 4 ++-- xen/arch/arm/arm64/lib/memmove.S | 4 ++-- xen/arch/arm/arm64/lib/memset.S | 4 ++-- xen/arch/arm/arm64/lib/strchr.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 4 ++-- xen/arch/arm/arm64/lib/strlen.S | 4 ++-- xen/arch/arm/arm64/lib/strncmp.S | 4 ++-- xen/arch/arm/arm64/lib/strnlen.S | 4 ++-- xen/arch/arm/arm64/lib/strrchr.S | 2 +- xen/arch/arm/efi/efi-dom0.c | 2 +- xen/arch/arm/include/asm/acpi.h | 2 +- xen/arch/arm/include/asm/altp2m.h | 2 +- xen/arch/arm/include/asm/arm32/insn.h | 2 +- xen/arch/arm/include/asm/arm64/atomic.h | 2 +- xen/arch/arm/include/asm/arm64/insn.h | 2 +- xen/arch/arm/include/asm/arm64/io.h | 2 +- xen/arch/arm/include/asm/gic_v3_its.h | 2 +- xen/arch/arm/include/asm/iommu.h | 2 +- xen/arch/arm/include/asm/iommu_fwspec.h | 2 +- xen/arch/arm/include/asm/ioreq.h | 2 +- xen/arch/arm/include/asm/mem_access.h | 2 +- xen/arch/arm/include/asm/monitor.h | 2 +- xen/arch/arm/include/asm/new_vgic.h | 2 +- xen/arch/arm/include/asm/pci.h | 2 +- xen/arch/arm/include/asm/smccc.h | 2 +- xen/arch/arm/include/asm/tee/optee_smc.h | 2 +- xen/arch/arm/include/asm/vm_event.h | 2 +- xen/arch/arm/include/asm/vpl011.h | 2 +- xen/arch/arm/include/asm/vpsci.h | 2 +- xen/arch/arm/pci/ecam.c | 2 +- xen/arch/arm/pci/pci-access.c | 2 +- xen/arch/arm/pci/pci-host-common.c | 2 +- xen/arch/arm/pci/pci-host-generic.c | 2 +- xen/arch/arm/pci/pci-host-zynqmp.c | 2 +- xen/arch/arm/pci/pci.c | 2 +- xen/arch/arm/platforms/thunderx.c | 2 +- xen/arch/arm/vgic/vgic-init.c | 2 +- xen/arch/arm/vgic/vgic-mmio.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/arm/vgic/vgic.h | 2 +- xen/arch/x86/acpi/boot.c | 2 +- xen/arch/x86/acpi/cpu_idle.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/acpi/cpuidle_menu.c | 2 +- xen/arch/x86/acpi/lib.c | 2 +- xen/arch/x86/alternative.c | 2 +- xen/arch/x86/boot/build32.lds | 2 +- xen/arch/x86/boot/cmdline.c | 2 +- xen/arch/x86/boot/defs.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 8 +++---- xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 10 ++++---- xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- xen/arch/x86/cpu/microcode/core.c | 4 ++-- xen/arch/x86/cpu/microcode/intel.c | 4 ++-- xen/arch/x86/cpu/mtrr/main.c | 2 +- xen/arch/x86/cpu/mwait-idle.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/cpu/vpmu_amd.c | 2 +- xen/arch/x86/cpu/vpmu_intel.c | 2 +- xen/arch/x86/dmi_scan.c | 2 +- xen/arch/x86/gdbstub.c | 2 +- xen/arch/x86/gdbsx.c | 2 +- xen/arch/x86/genapic/x2apic.c | 2 +- xen/arch/x86/guest/hyperv/hyperv.c | 2 +- xen/arch/x86/guest/hyperv/private.h | 2 +- xen/arch/x86/guest/hyperv/tlb.c | 2 +- xen/arch/x86/guest/hyperv/util.c | 2 +- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/hvm/asid.c | 2 +- xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/hvm/domain.c | 2 +- xen/arch/x86/hvm/grant_table.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/hypercall.c | 2 +- xen/arch/x86/hvm/intercept.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 2 +- xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/monitor.c | 2 +- xen/arch/x86/hvm/mtrr.c | 2 +- xen/arch/x86/hvm/nestedhvm.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 2 +- xen/arch/x86/hvm/quirks.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/hvm/svm/asid.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/entry.S | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svmdebug.c | 2 +- xen/arch/x86/hvm/svm/vmcb.c | 2 +- xen/arch/x86/hvm/vioapic.c | 6 ++--- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vm_event.c | 2 +- xen/arch/x86/hvm/vmsi.c | 6 ++--- xen/arch/x86/hvm/vmx/entry.S | 2 +- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 2 +- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/hypercall.c | 2 +- xen/arch/x86/include/asm/acpi.h | 2 +- xen/arch/x86/include/asm/altp2m.h | 2 +- xen/arch/x86/include/asm/edd.h | 4 ++-- xen/arch/x86/include/asm/endbr.h | 2 +- xen/arch/x86/include/asm/guest.h | 2 +- xen/arch/x86/include/asm/guest/hyperv-hcall.h | 2 +- xen/arch/x86/include/asm/guest/hyperv.h | 2 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 2 +- xen/arch/x86/include/asm/guest/xen-hcall.h | 2 +- xen/arch/x86/include/asm/guest/xen.h | 2 +- xen/arch/x86/include/asm/guest_pt.h | 2 +- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/hpet.h | 2 +- xen/arch/x86/include/asm/hvm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/grant_table.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 2 +- xen/arch/x86/include/asm/hvm/io.h | 2 +- xen/arch/x86/include/asm/hvm/ioreq.h | 2 +- xen/arch/x86/include/asm/hvm/irq.h | 2 +- xen/arch/x86/include/asm/hvm/monitor.h | 2 +- xen/arch/x86/include/asm/hvm/nestedhvm.h | 2 +- xen/arch/x86/include/asm/hvm/save.h | 2 +- xen/arch/x86/include/asm/hvm/support.h | 2 +- xen/arch/x86/include/asm/hvm/svm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/svm/emulate.h | 2 +- xen/arch/x86/include/asm/hvm/svm/intr.h | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- xen/arch/x86/include/asm/hvm/vcpu.h | 2 +- xen/arch/x86/include/asm/hvm/vioapic.h | 6 ++--- xen/arch/x86/include/asm/hvm/vlapic.h | 2 +- xen/arch/x86/include/asm/hvm/vm_event.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 2 +- xen/arch/x86/include/asm/hvm/vpt.h | 2 +- xen/arch/x86/include/asm/iommu.h | 2 +- xen/arch/x86/include/asm/ioreq.h | 2 +- xen/arch/x86/include/asm/mem_access.h | 2 +- xen/arch/x86/include/asm/mem_paging.h | 2 +- xen/arch/x86/include/asm/mem_sharing.h | 2 +- xen/arch/x86/include/asm/monitor.h | 2 +- xen/arch/x86/include/asm/p2m.h | 2 +- xen/arch/x86/include/asm/paging.h | 2 +- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/include/asm/pv/grant_table.h | 2 +- xen/arch/x86/include/asm/pv/mm.h | 2 +- xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/include/asm/pv/traps.h | 2 +- xen/arch/x86/include/asm/shadow.h | 2 +- xen/arch/x86/include/asm/shstk.h | 2 +- xen/arch/x86/include/asm/spec_ctrl.h | 2 +- xen/arch/x86/include/asm/spec_ctrl_asm.h | 2 +- xen/arch/x86/include/asm/traps.h | 2 +- xen/arch/x86/include/asm/vm_event.h | 2 +- xen/arch/x86/include/asm/vpmu.h | 2 +- xen/arch/x86/include/asm/xenoprof.h | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/altp2m.c | 2 +- xen/arch/x86/mm/guest_walk.c | 2 +- xen/arch/x86/mm/hap/guest_walk.c | 2 +- xen/arch/x86/mm/hap/hap.c | 2 +- xen/arch/x86/mm/hap/nested_ept.c | 2 +- xen/arch/x86/mm/hap/nested_hap.c | 2 +- xen/arch/x86/mm/hap/private.h | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/mem_paging.c | 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/nested.c | 2 +- xen/arch/x86/mm/p2m-basic.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/arch/x86/mm/p2m-pod.c | 2 +- xen/arch/x86/mm/p2m-pt.c | 2 +- xen/arch/x86/mm/p2m.c | 2 +- xen/arch/x86/mm/p2m.h | 2 +- xen/arch/x86/mm/paging.c | 2 +- xen/arch/x86/mm/physmap.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/mm/shadow/multi.h | 2 +- xen/arch/x86/mm/shadow/private.h | 2 +- xen/arch/x86/mm/shadow/pv.c | 2 +- xen/arch/x86/mm/shadow/set.c | 2 +- xen/arch/x86/mm/shadow/types.h | 2 +- xen/arch/x86/monitor.c | 2 +- xen/arch/x86/msr.c | 2 +- xen/arch/x86/pv/callback.c | 2 +- xen/arch/x86/pv/descriptor-tables.c | 2 +- xen/arch/x86/pv/emul-gate-op.c | 2 +- xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/grant_table.c | 2 +- xen/arch/x86/pv/hypercall.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/misc-hypercalls.c | 2 +- xen/arch/x86/pv/mm.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/pv/shim.c | 2 +- xen/arch/x86/pv/traps.c | 2 +- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/spec_ctrl.c | 2 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/vm_event.c | 2 +- xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- xen/arch/x86/x86_64/cpu_idle.c | 2 +- xen/arch/x86/x86_64/cpufreq.c | 2 +- xen/arch/x86/x86_64/gdbstub.c | 2 +- xen/arch/x86/x86_64/mm.c | 2 +- xen/arch/x86/x86_64/mmconfig.h | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- xen/common/README.source | 6 ++--- xen/common/argo.c | 2 +- xen/common/bunzip2.c | 6 ++--- xen/common/coverage/coverage.c | 2 +- xen/common/dm.c | 2 +- xen/common/event_channel.c | 2 +- xen/common/gdbstub.c | 2 +- xen/common/grant_table.c | 2 +- xen/common/ioreq.c | 2 +- xen/common/libelf/libelf-dominfo.c | 2 +- xen/common/libelf/libelf-loader.c | 2 +- xen/common/libelf/libelf-private.h | 2 +- xen/common/libelf/libelf-tools.c | 2 +- xen/common/lz4/decompress.c | 6 ++--- xen/common/lzo.c | 8 +++---- xen/common/mem_access.c | 2 +- xen/common/monitor.c | 2 +- xen/common/page_alloc.c | 2 +- xen/common/pdx.c | 2 +- xen/common/preempt.c | 2 +- xen/common/radix-tree.c | 2 +- xen/common/rcupdate.c | 8 +++---- xen/common/sched/null.c | 2 +- xen/common/stop_machine.c | 2 +- xen/common/time.c | 2 +- xen/common/unlzma.c | 8 +++---- xen/common/unlzo.c | 4 ++-- xen/common/vm_event.c | 2 +- xen/common/wait.c | 2 +- xen/common/xmalloc_tlsf.c | 4 ++-- xen/common/xz/crc32.c | 2 +- xen/common/xz/dec_bcj.c | 2 +- xen/common/xz/dec_lzma2.c | 2 +- xen/common/xz/lzma2.h | 2 +- xen/common/xz/stream.h | 2 +- xen/common/zstd/bitstream.h | 2 +- xen/common/zstd/entropy_common.c | 2 +- xen/common/zstd/fse.h | 2 +- xen/common/zstd/fse_decompress.c | 2 +- xen/common/zstd/huf.h | 2 +- xen/common/zstd/huf_decompress.c | 2 +- xen/crypto/README.source | 4 ++-- xen/drivers/acpi/apei/apei-base.c | 2 +- xen/drivers/acpi/apei/apei-io.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/drivers/acpi/apei/hest.c | 2 +- xen/drivers/acpi/numa.c | 2 +- xen/drivers/acpi/osl.c | 2 +- xen/drivers/acpi/pmstat.c | 2 +- xen/drivers/acpi/tables.c | 2 +- xen/drivers/char/consoled.c | 2 +- xen/drivers/char/meson-uart.c | 2 +- xen/drivers/char/mvebu-uart.c | 2 +- xen/drivers/char/xen_pv_console.c | 2 +- xen/drivers/char/xhci-dbc.c | 2 +- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/drivers/passthrough/amd/iommu-defs.h | 2 +- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/drivers/passthrough/amd/iommu_cmd.c | 2 +- xen/drivers/passthrough/amd/iommu_detect.c | 2 +- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_init.c | 2 +- xen/drivers/passthrough/amd/iommu_intr.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/arm/iommu_fwspec.c | 2 +- xen/drivers/passthrough/arm/iommu_helpers.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 4 ++-- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/ats.c | 2 +- xen/drivers/passthrough/ats.h | 2 +- xen/drivers/passthrough/iommu.c | 2 +- xen/drivers/passthrough/pci.c | 6 ++--- xen/drivers/passthrough/vtd/dmar.c | 2 +- xen/drivers/passthrough/vtd/dmar.h | 2 +- xen/drivers/passthrough/vtd/extern.h | 2 +- xen/drivers/passthrough/vtd/intremap.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/drivers/passthrough/vtd/qinval.c | 2 +- xen/drivers/passthrough/vtd/quirks.c | 2 +- xen/drivers/passthrough/vtd/utils.c | 2 +- xen/drivers/passthrough/vtd/vtd.h | 2 +- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- xen/drivers/passthrough/vtd/x86/hvm.c | 2 +- xen/drivers/passthrough/vtd/x86/vtd.c | 2 +- xen/drivers/passthrough/x86/hvm.c | 2 +- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 2 +- xen/drivers/vpci/vpci.c | 2 +- xen/include/acpi/actbl3.h | 2 +- xen/include/crypto/README.source | 4 ++-- xen/include/crypto/vmac.h | 4 ++-- xen/include/efi/eficapsule.h | 2 +- xen/include/public/arch-x86/hvm/start_info.h | 2 +- xen/include/public/errno.h | 2 +- xen/include/public/grant_table.h | 2 +- xen/include/public/hvm/params.h | 2 +- xen/include/public/io/blkif.h | 4 ++-- xen/include/public/io/libxenvchan.h | 2 +- xen/include/public/io/tpmif.h | 2 +- xen/include/xen/acpi.h | 2 +- xen/include/xen/argo.h | 2 +- xen/include/xen/atomic.h | 2 +- xen/include/xen/compiler.h | 2 +- xen/include/xen/cper.h | 2 +- xen/include/xen/cpuidle.h | 2 +- xen/include/xen/dm.h | 2 +- xen/include/xen/elfstructs.h | 4 ++-- xen/include/xen/gdbstub.h | 2 +- xen/include/xen/grant_table.h | 2 +- xen/include/xen/inttypes.h | 2 +- xen/include/xen/iommu.h | 2 +- xen/include/xen/ioreq.h | 2 +- xen/include/xen/lzo.h | 2 +- xen/include/xen/mem_access.h | 2 +- xen/include/xen/monitor.h | 2 +- xen/include/xen/multiboot.h | 2 +- xen/include/xen/pci_regs.h | 4 ++-- xen/include/xen/radix-tree.h | 2 +- xen/include/xen/rbtree.h | 2 +- xen/include/xen/rcupdate.h | 8 +++---- xen/include/xen/vm_event.h | 2 +- xen/include/xen/xxhash.h | 2 +- xen/lib/list-sort.c | 2 +- xen/lib/rbtree.c | 4 ++-- xen/lib/xxhash32.c | 2 +- xen/lib/xxhash64.c | 2 +- xen/tools/kconfig/gconf.c | 2 +- xen/tools/kconfig/merge_config.sh | 4 ++-- xen/tools/kconfig/qconf.cc | 2 +- xen/xsm/silo.c | 2 +- 714 files changed, 882 insertions(+), 907 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 04:51:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 04:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491524.760721 (Exim 4.92) (envelope-from ) id 1pPcQg-00069v-IT; Wed, 08 Feb 2023 04:51:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491524.760721; Wed, 08 Feb 2023 04:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQg-00069o-FW; Wed, 08 Feb 2023 04:51:34 +0000 Received: by outflank-mailman (input) for mailman id 491524; Wed, 08 Feb 2023 04:51:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQe-0005Mi-9m for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 04:51:32 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f7162e9-a76c-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 05:51:28 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E1C1C5C0096; Tue, 7 Feb 2023 23:51:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 07 Feb 2023 23:51:27 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 23:51:25 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f7162e9-a76c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1675831887; x=1675918287; bh=Hwlx+HFJQc MjQAaxpZj9K126hSKE+cYpG2Bet+RH630=; b=U9VNf2m1IkGmrBDjVQTeCvMTRe Y6dBDZuxFSmXS6+I3sLIEV0mbIDuQxJs+SaCNm+Nk7v0+T8LVfLbipS8vaAqsXcN 6gVKmaDwUd+XF3yEuUscZJ6QutD9fvuTj8T4OvJgBNSl21boOPhEHHjQhFBzV3IJ U45vAs/mdBds+oeG63l519MjwLmvt8yWjEQRWcOv9G8HWfQ9BtoXBe1P4X8sewFZ OjMOB+IMeYg0Yo1AcOtQItA/+JnRHNj5zXJMkwXd4PMOhKWx0UTQsCoekOwqhVfS jJZ6Z15CPylXp0ANmc+WaJLGaTpPxGdDm2HtTws6MbmeATJYlB18GjgBMHMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675831887; x= 1675918287; bh=Hwlx+HFJQcMjQAaxpZj9K126hSKE+cYpG2Bet+RH630=; b=L w/wUIAFzwE4i/yJo7j+Phvk2WjHQ/2LWwc3je0egUDdNzchOWZMdcBEJjDgF4jNV JaBxOzDCG4KdvKnJFnMIO5QiUBNcaNpDl4fLgu/0pV/HmsaC3rWfioG6bngbq2Gc in8ZERCImLTm1EF7jL71vsqxjsiWrzE/a/MwNN3+y4IvbD8JykOCmomxi8YbqK5B XTbllKpABj2dKvczxzt0tVJyzIcDhu2rY4ahivx5RQ/vVCxkf9irzyvAZDPrdums HG8fYofDpv2p13Pe86KET3BNH3GgXoGE7NSdXlVTglXwziObP9Y6rir6/lw0NHk2 cPzit1wf01WL0MQ65gVXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnegfrhhlucfvnfffucdlgedmnecujfgu rhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcuof grrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhmqeenucggtffrrghtthgvrhhnpeettddukeduffffjedtfeefieetiefgvd evjeefkefhffekteeggfevueekkeffudenucffohhmrghinhepghhnuhdrohhrghdpghho ohhprdhorhhgpdhsohhurhgtvghfohhrghgvrdhnvghtpdhfrhgvvggsshgurdhorhhgpd hnvghtsghsugdrohhrghdpohhpvghnsghsugdrohhrghdpihhnthgvlhdrtghordhukhdp rghmugdrtghomhdpihhnthgvlhdrtghomhdphihouhhtuhgsvgdrtghomhdplhhinhhugi hfohhunhgurghtihhonhdrohhrghdpgigvnhhprhhojhgvtghtrdhorhhgpdigvghnrdho rhhgpdhslhhiuggvshhhrghrvgdrnhgvthdpghhoohhglhgvrdgtohhmpdgrmhguieegrd horhhgpdhkvghrnhgvlhdrohhrghdpfhhrvggvqdgvlhgvtghtrhhonhhsrdgtohhmpdgu vghngidruggvpdguvghvihgtvghtrhgvvgdrohhrghdpuhifrghtvghrlhhoohdrtggrpd hkvghrnhgvlhhnvgifsghivghsrdhorhhgpdgtohhrnhgvlhhlrdgvughupdhfrghurdgu vgdpghhithhhuhgsrdgtohhmpdhrvggrughthhgvughotghsrdhiohdpshgthhgurdifsh dpohhpvghnghhrohhuphdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant , Doug Goldstein Subject: [PATCH 3/4] Miscellaneous and documentation: Only use TLS-protected transports Date: Tue, 7 Feb 2023 23:51:06 -0500 Message-Id: <83ecebe5c6b57713b0265fe0aeea25700f2b892b.1675829867.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch changes miscellaneous links that are not used by any automated tool. Some of these links are dead anyway. Signed-off-by: Demi Marie Obenour --- This patch might well have flaws, not least due to its sheer size. COPYING | 4 ++-- CREDITS | 2 +- README | 4 ++-- SUPPORT.md | 2 +- docs/features/feature-levelling.pandoc | 4 ++-- docs/features/intel_psr_cat_cdp.pandoc | 2 +- docs/features/intel_psr_mba.pandoc | 2 +- docs/features/migration.pandoc | 2 +- docs/features/sched_credit.pandoc | 4 ++-- docs/features/sched_credit2.pandoc | 6 ++--- docs/features/sched_rtds.pandoc | 4 ++-- docs/misc/amd-ucode-container.txt | 4 ++-- docs/misc/arm/booting.txt | 4 ++-- docs/misc/arm/passthrough.txt | 2 +- docs/misc/kconfig-language.rst | 14 +++++------ docs/misc/livepatch.pandoc | 2 +- docs/misc/netif-staging-grants.pandoc | 10 ++++---- docs/misc/pvcalls.pandoc | 18 +++++++-------- docs/misc/status-override-table-spec.fodt | 2 +- docs/misc/vtd-pi.txt | 6 ++--- docs/misc/vtd.txt | 4 ++-- docs/misc/xen-env-table-spec.fodt | 2 +- docs/misc/xenstore-paths.pandoc | 2 +- docs/misc/xl-psr.pandoc | 2 +- docs/misc/xsm-flask.txt | 2 +- docs/process/release-technician-checklist.txt | 2 +- docs/process/sending-patches.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- m4/README.source | 4 ++-- m4/ax_compare_version.m4 | 4 ++-- m4/ocaml.m4 | 2 +- m4/pkg.m4 | 2 +- misc/coverity/model.c | 2 +- stubdom/vtpmmgr/tpmrsa.c | 4 +--- stubdom/vtpmmgr/tpmrsa.h | 2 +- tools/configure | 12 +++++----- tools/examples/xeninfo.pl | 4 ++-- tools/firmware/Makefile | 2 +- tools/firmware/etherboot/README | 23 +------------------ tools/firmware/hvmloader/pci_regs.h | 2 +- tools/firmware/hvmloader/pir.c | 2 +- tools/firmware/hvmloader/pir_types.h | 2 +- tools/firmware/hvmloader/smbios_types.h | 2 +- tools/firmware/rombios/32bit/pmm.c | 2 +- tools/firmware/rombios/rombios.c | 8 +++---- tools/firmware/vgabios/README | 10 ++++---- tools/firmware/vgabios/vbe.c | 2 +- tools/firmware/vgabios/vbe_display_api.txt | 8 +++---- tools/firmware/vgabios/vgabios.c | 8 +++---- tools/fuzz/README.afl | 2 +- tools/hotplug/Linux/xendomains.in | 2 +- tools/include/libxenvchan.h | 2 +- tools/include/libxl.h | 2 +- tools/libacpi/build.c | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 4 ++-- tools/libfsimage/zfs/zfs_sha256.c | 2 +- tools/libs/light/libxl_genid.c | 2 +- tools/libs/stat/xenstat_qmp.c | 2 +- tools/misc/mkrpm | 2 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 2 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2 +- tools/tests/vhpet/main.c | 2 +- tools/xenstore/talloc.c | 2 +- tools/xenstore/talloc_guide.txt | 2 +- tools/xl/check-xl-disk-parse | 6 ++--- xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 2 +- xen/arch/arm/arm64/lib/memcpy.S | 2 +- xen/arch/arm/arm64/lib/memmove.S | 2 +- xen/arch/arm/arm64/lib/memset.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 2 +- xen/arch/arm/arm64/lib/strlen.S | 2 +- xen/arch/arm/arm64/lib/strncmp.S | 2 +- xen/arch/arm/arm64/lib/strnlen.S | 2 +- xen/arch/arm/include/asm/smccc.h | 2 +- xen/arch/arm/include/asm/tee/optee_smc.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 6 ++--- xen/arch/x86/cpu/mcheck/mce_amd.c | 8 +++---- xen/arch/x86/cpu/microcode/core.c | 4 ++-- xen/arch/x86/cpu/microcode/intel.c | 4 ++-- xen/arch/x86/dmi_scan.c | 2 +- xen/arch/x86/hvm/vioapic.c | 4 ++-- xen/arch/x86/hvm/vmsi.c | 4 ++-- xen/arch/x86/include/asm/edd.h | 4 ++-- xen/arch/x86/include/asm/hpet.h | 2 +- xen/arch/x86/include/asm/hvm/vioapic.h | 4 ++-- xen/common/README.source | 6 ++--- xen/common/bunzip2.c | 4 ++-- xen/common/lz4/decompress.c | 6 ++--- xen/common/lzo.c | 8 +++---- xen/common/rcupdate.c | 6 ++--- xen/common/unlzma.c | 6 ++--- xen/common/unlzo.c | 2 +- xen/common/xmalloc_tlsf.c | 4 ++-- xen/common/xz/crc32.c | 2 +- xen/common/xz/dec_bcj.c | 2 +- xen/common/xz/dec_lzma2.c | 2 +- xen/common/xz/lzma2.h | 2 +- xen/common/xz/stream.h | 2 +- xen/common/zstd/bitstream.h | 2 +- xen/common/zstd/entropy_common.c | 2 +- xen/common/zstd/fse.h | 2 +- xen/common/zstd/fse_decompress.c | 2 +- xen/common/zstd/huf.h | 2 +- xen/common/zstd/huf_decompress.c | 2 +- xen/crypto/README.source | 4 ++-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/pci.c | 4 ++-- xen/include/acpi/actbl3.h | 2 +- xen/include/crypto/README.source | 4 ++-- xen/include/crypto/vmac.h | 4 ++-- xen/include/efi/eficapsule.h | 2 +- xen/include/public/arch-x86/hvm/start_info.h | 2 +- xen/include/public/errno.h | 2 +- xen/include/public/grant_table.h | 2 +- xen/include/public/hvm/params.h | 2 +- xen/include/public/io/blkif.h | 4 ++-- xen/include/public/io/libxenvchan.h | 2 +- xen/include/public/io/tpmif.h | 2 +- xen/include/xen/compiler.h | 2 +- xen/include/xen/elfstructs.h | 4 ++-- xen/include/xen/lzo.h | 2 +- xen/include/xen/pci_regs.h | 4 ++-- xen/include/xen/rcupdate.h | 6 ++--- xen/include/xen/xxhash.h | 2 +- xen/lib/rbtree.c | 2 +- xen/lib/xxhash32.c | 2 +- xen/lib/xxhash64.c | 2 +- xen/tools/kconfig/gconf.c | 2 +- xen/tools/kconfig/merge_config.sh | 4 ++-- xen/tools/kconfig/qconf.cc | 2 +- 133 files changed, 221 insertions(+), 244 deletions(-) diff --git a/COPYING b/COPYING index 824c3aa353b47507241831f4753590f86a162014..74ebc2a18ac2fb407a92e48f59e1b6f3828ad2ba 100644 --- a/COPYING +++ b/COPYING @@ -16,9 +16,9 @@ the *License Exceptions* section of this file. When these code sections are compiled as part of a GPLv2-licensed program, such as Xen, the result is licensed under GPLv2. See the FSF's definition of GPL compatibility: - http://www.gnu.org/licenses/gpl-faq.html#WhatDoesCompatMean + https://www.gnu.org/licenses/gpl-faq.html#WhatDoesCompatMean And how this applies to a range of open source licenses: - http://www.gnu.org/licenses/license-list.html + https://www.gnu.org/licenses/license-list.html A number of files will also specify GPL exceptions, such as - Autoconf exception diff --git a/CREDITS b/CREDITS index 3ddcdbaac64c47d95f13091e00146cfbde7cc58b..741856859c787820a83782611c6cd6ee95fe4176 100644 --- a/CREDITS +++ b/CREDITS @@ -11,6 +11,6 @@ N: Jeremy Fitzhardinge E: jeremy@goop.org -W: http://www.goop.org/~jeremy +W: https://www.goop.org/~jeremy P: 1B40B6D0 D: Linux pvops diff --git a/README b/README index f8cc426f78d690f37e013242e81d4e440556c330..aca8182c9f17e8457515fd9e2f7c66b486e93557 100644 --- a/README +++ b/README @@ -206,7 +206,7 @@ Tboot is an open source, pre- kernel/VMM module that uses Intel(R) TXT to perform a measured and verified launch of an OS kernel/VMM. The Trusted Boot module is available from -http://sourceforge.net/projects/tboot. This project hosts the code in a -mercurial repo at http://tboot.sourceforge.net/hg/tboot.hg and contains +https://sourceforge.net/projects/tboot. This project hosts the code in a +mercurial repo at https://tboot.sourceforge.net/hg/tboot.hg and contains tarballs of the source. Instructions in the tboot README describe how to modify grub.conf to use tboot to launch Xen. diff --git a/SUPPORT.md b/SUPPORT.md index 295369998e6ac07f11c1a4e0783bd5a87ee948e9..479d64802c46cb84be89802d230d6f7594d92265 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -1122,6 +1122,6 @@ External projects that provide their own security support for Xen-related featur * FreeBSD https://www.freebsd.org/security/ - * NetBSD http://www.netbsd.org/support/security/ + * NetBSD https://www.netbsd.org/support/security/ * OpenBSD https://www.openbsd.org/security.html diff --git a/docs/features/feature-levelling.pandoc b/docs/features/feature-levelling.pandoc index 171a42c358409f4ab24f0d783628187a367c15b8..0b3659ec8920771d33c6a9813535f5648ff92169 100644 --- a/docs/features/feature-levelling.pandoc +++ b/docs/features/feature-levelling.pandoc @@ -202,9 +202,9 @@ Corruption) # References -[Intel Flexmigration](http://www.intel.co.uk/content/dam/www/public/us/en/documents/application-notes/virtualization-technology-flexmigration-application-note.pdf) +[Intel Flexmigration](https://www.intel.co.uk/content/dam/www/public/us/en/documents/application-notes/virtualization-technology-flexmigration-application-note.pdf) -[AMD Extended Migration Technology](http://developer.amd.com/wordpress/media/2012/10/43781-3.00-PUB_Live-Virtual-Machine-Migration-on-AMD-processors.pdf) +[AMD Extended Migration Technology](https://developer.amd.com/wordpress/media/2012/10/43781-3.00-PUB_Live-Virtual-Machine-Migration-on-AMD-processors.pdf) # History diff --git a/docs/features/intel_psr_cat_cdp.pandoc b/docs/features/intel_psr_cat_cdp.pandoc index 1fb02ea1e6746ee2e87e12bb08c0454997ed397a..a05d6b084597c88c8ea2539cd37798f8de788d67 100644 --- a/docs/features/intel_psr_cat_cdp.pandoc +++ b/docs/features/intel_psr_cat_cdp.pandoc @@ -448,7 +448,7 @@ N/A # References -"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) +"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) # History diff --git a/docs/features/intel_psr_mba.pandoc b/docs/features/intel_psr_mba.pandoc index 86df661ba8866b2d0a099682230ffad1b97f4408..b46ab657043e5ead4afd8d0e982da5678868cf9d 100644 --- a/docs/features/intel_psr_mba.pandoc +++ b/docs/features/intel_psr_mba.pandoc @@ -242,7 +242,7 @@ N/A # References -"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) +"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) # History diff --git a/docs/features/migration.pandoc b/docs/features/migration.pandoc index 5334536d48f5250d9f755fbe43f2dd6bf7126bf8..d1c8086daf0c979390d8a214e9526ce46eb4e614 100644 --- a/docs/features/migration.pandoc +++ b/docs/features/migration.pandoc @@ -111,7 +111,7 @@ scenarios, which will involve starting with VMs from Xen 4.5 Xen Developer Summit 2015 Presentation [video](https://www.youtube.com/watch?v=RwiDeG21lrc) and -[slides](http://events.linuxfoundation.org/sites/events/files/slides/migv2.pdf) +[slides](https://events.linuxfoundation.org/sites/events/files/slides/migv2.pdf) for Migration v2 # History diff --git a/docs/features/sched_credit.pandoc b/docs/features/sched_credit.pandoc index 706513de6e449eec33f4864eed18cb327a053b42..974d47db16894ab83ad9c41280f3dd68a45fcce4 100644 --- a/docs/features/sched_credit.pandoc +++ b/docs/features/sched_credit.pandoc @@ -85,8 +85,8 @@ by also doing the following: * [potential non-ideal behavior on hyperthreaded systems](https://lists.xenproject.org/archives/html/xen-devel/2014-07/msg01848.html) [1] * [long standing BOOST vs. migration bug](https://lists.xen.org/archives/html/xen-devel/2015-10/msg02851.html) [2] * [priority handling issues](https://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01362.html) [3] -* "Scheduler development update", XenSummit Asia 2009 [whitepaper](http://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) [4] -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "Scheduler development update", XenSummit Asia 2009 [whitepaper](https://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) [4] +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) * "The Credit Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Credit_Scheduler) * "Xen Project Schedulers" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Xen_Project_Schedulers) diff --git a/docs/features/sched_credit2.pandoc b/docs/features/sched_credit2.pandoc index 436ff9f8f6ad4df0ff1410e768b2570faeb77485..95c739ee21eeb6b8034037cdabf6e6e777573fb0 100644 --- a/docs/features/sched_credit2.pandoc +++ b/docs/features/sched_credit2.pandoc @@ -91,9 +91,9 @@ following: # References -* "Scheduler development update", XenSummit Asia 2009 [whitepaper](http://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) -* "Scope and Performance of Credit-2 Scheduler" [XPDS16 Presentation](http://www.slideshare.net/xen_com_mgr/xpds16-scope-and-performance-of-credit2-scheduler-anshul-makkar-ctirix-systems-uk-ltd) +* "Scheduler development update", XenSummit Asia 2009 [whitepaper](https://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "Scope and Performance of Credit-2 Scheduler" [XPDS16 Presentation](https://www.slideshare.net/xen_com_mgr/xpds16-scope-and-performance-of-credit2-scheduler-anshul-makkar-ctirix-systems-uk-ltd) * "The Credit2 Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Credit2_Scheduler_Development) * "Xen Project Schedulers" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Xen_Project_Schedulers) diff --git a/docs/features/sched_rtds.pandoc b/docs/features/sched_rtds.pandoc index 4ccf704b53d08cd6ef618e3b521c293b87eb88ad..5c03d67f48df4c41a913e2a89a09630806388206 100644 --- a/docs/features/sched_rtds.pandoc +++ b/docs/features/sched_rtds.pandoc @@ -105,8 +105,8 @@ at a macroscopic level), the following should be done: # References -* "RT-Xen: Real-Time Virtualization" [XPDS14 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/2014_Xen_Developer_Summit_0.pdf) -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "RT-Xen: Real-Time Virtualization" [XPDS14 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/2014_Xen_Developer_Summit_0.pdf) +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) * [RT-Xen Project](https://sites.google.com/site/realtimexen/) * [RTDS-Based-Scheduler](https://wiki.xenproject.org/wiki/RTDS-Based-Scheduler) * "The RTDS Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/RTDS-Based-Scheduler) diff --git a/docs/misc/amd-ucode-container.txt b/docs/misc/amd-ucode-container.txt index 1db64662d56707e928fb39784bc31d51b25b5cfb..c5bfd08e65344b75e6e451a0cb151d5ead614b1a 100644 --- a/docs/misc/amd-ucode-container.txt +++ b/docs/misc/amd-ucode-container.txt @@ -85,6 +85,6 @@ they should obtain a "good" set by downloading them from source links Reference(s): ------------- -[1] http://www.amd64.org/microcode.html +[1] https://www.amd64.org/microcode.html [2] https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tree/amd-ucode -[3] http://lxr.free-electrons.com/source/Documentation/x86/early-microcode.txt +[3] https://lxr.free-electrons.com/source/Documentation/x86/early-microcode.txt diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt index bd7bfe7f284ad5ed56cfff009b52bf36aed8522f..dd28d1d5af6a9840b4dc66744ea8b97c87a05555 100644 --- a/docs/misc/arm/booting.txt +++ b/docs/misc/arm/booting.txt @@ -65,10 +65,10 @@ Xen relies on some settings the firmware has to configure in EL3 before starting [1] linux/Documentation/arm/booting.rst -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst +Latest version: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst [2] linux/Documentation/arm64/booting.rst -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst +Latest version: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst [3] legacy format header Latest version: https://source.denx.de/u-boot/u-boot/-/blob/master/include/image.h#L315 diff --git a/docs/misc/arm/passthrough.txt b/docs/misc/arm/passthrough.txt index 4f0a024818a2b6f1610cd7a12c26b5532dba042d..c3f6c29fca583939e7fb7ae30f02a4bcff2343ea 100644 --- a/docs/misc/arm/passthrough.txt +++ b/docs/misc/arm/passthrough.txt @@ -50,7 +50,7 @@ Note: - ranges - #address-cells - #size-cells - * See http://www.devicetree.org/Device_Tree_Usage for more + * See https://www.devicetree.org/Device_Tree_Usage for more information about device tree. * In this example, the device MMIO region is placed at a different address (0x10000000) compared to the host address (0xfff51000) diff --git a/docs/misc/kconfig-language.rst b/docs/misc/kconfig-language.rst index 74bef19f69f0a8078f2f988358ff57046b46210b..f13fdb7ddc3739af4a89f3f93f8814d3815d69b5 100644 --- a/docs/misc/kconfig-language.rst +++ b/docs/misc/kconfig-language.rst @@ -669,10 +669,10 @@ and real world requirements were not well understood. As it stands though only reverse engineering techniques have been used to deduce semantics from variability modeling languages such as Kconfig [3]_. -.. [0] http://www.eng.uwaterloo.ca/~shshe/kconfig_semantics.pdf -.. [1] http://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf -.. [2] http://gsd.uwaterloo.ca/sites/default/files/ase241-berger_0.pdf -.. [3] http://gsd.uwaterloo.ca/sites/default/files/icse2011.pdf +.. [0] https://www.eng.uwaterloo.ca/~shshe/kconfig_semantics.pdf +.. [1] https://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf +.. [2] https://gsd.uwaterloo.ca/sites/default/files/ase241-berger_0.pdf +.. [3] https://gsd.uwaterloo.ca/sites/default/files/icse2011.pdf Full SAT solver for Kconfig ~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -691,10 +691,10 @@ such efforts somehow on Kconfig. There is enough interest from mentors of existing projects to not only help advise how to integrate this work upstream but also help maintain it long term. Interested developers should visit: -http://kernelnewbies.org/KernelProjects/kconfig-sat +https://kernelnewbies.org/KernelProjects/kconfig-sat -.. [4] http://www.cs.cornell.edu/~sabhar/chapters/SATSolvers-KR-Handbook.pdf -.. [5] http://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf +.. [4] https://www.cs.cornell.edu/~sabhar/chapters/SATSolvers-KR-Handbook.pdf +.. [5] https://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf .. [6] https://cados.cs.fau.de .. [7] https://vamos.cs.fau.de .. [8] https://undertaker.cs.fau.de diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc index d38e4ce074b399946aecdaedb4cb6fe5b8043b66..a94fb57eb568e85a25c93bf6a988f123d4e48443 100644 --- a/docs/misc/livepatch.pandoc +++ b/docs/misc/livepatch.pandoc @@ -993,7 +993,7 @@ The design of that is not discussed in this design. This is implemented in a seperate tool which lives in a seperate GIT repo. -Currently it resides at git://xenbits.xen.org/livepatch-build-tools.git +Currently it resides at https://xenbits.xen.org/git-http/livepatch-build-tools.git ### Exception tables and symbol tables growth diff --git a/docs/misc/netif-staging-grants.pandoc b/docs/misc/netif-staging-grants.pandoc index cb33028adc3dadc8a9fb2a7739af6e5027690f82..1643f852d0b8a80645c90f80d9c48e6d5045abcb 100644 --- a/docs/misc/netif-staging-grants.pandoc +++ b/docs/misc/netif-staging-grants.pandoc @@ -399,7 +399,7 @@ Depending on the implementation, it would mean that we no longer would need to aggregate as much as grant ops as possible (step 1) and could transmit the packet on the transmit function (e.g. Linux ```ndo_start_xmit```) as previously proposed -here\[[0](http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html)\]. +here\[[0](https://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html)\]. This would heavily improve efficiency specifially for smaller packets. Which in return would decrease RTT, having data being acknoledged much quicker. @@ -548,7 +548,7 @@ the results. # References -[0] http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html +[0] https://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html [1] https://github.com/freebsd/freebsd/blob/master/sys/dev/netmap/netmap_mem2.c#L362 @@ -556,11 +556,11 @@ the results. [3] https://github.com/iovisor/bpf-docs/blob/master/Express_Data_Path.pdf -[4] http://prototype-kernel.readthedocs.io/en/latest/networking/XDP/design/requirements.html#write-access-to-packet-data +[4] https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/design/requirements.html#write-access-to-packet-data -[5] http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c#L2073 +[5] https://lxr.free-electrons.com/source/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c#L2073 -[6] http://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx4/en_rx.c#L52 +[6] https://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx4/en_rx.c#L52 [7] https://schd.ws/hosted_files/xendeveloperanddesignsummit2017/e6/ToGrantOrNotToGrant-XDDS2017_v3.pdf diff --git a/docs/misc/pvcalls.pandoc b/docs/misc/pvcalls.pandoc index 971cd8f4b1225d70b5cca31a3fe5121ddb8ae459..e86eef84e441cbe74f9c19a8ed509146e8a331d2 100644 --- a/docs/misc/pvcalls.pandoc +++ b/docs/misc/pvcalls.pandoc @@ -1072,13 +1072,13 @@ reading from the socket. [xenstore]: https://xenbits.xen.org/docs/unstable/misc/xenstore.txt [XenbusStateInitialising]: https://xenbits.xen.org/docs/unstable/hypercall/x86_64/include,public,io,xenbus.h.html -[address]: http://pubs.opengroup.org/onlinepubs/7908799/xns/syssocket.h.html -[in]: http://pubs.opengroup.org/onlinepubs/000095399/basedefs/netinet/in.h.html -[socket]: http://pubs.opengroup.org/onlinepubs/009695399/functions/socket.html -[connect]: http://pubs.opengroup.org/onlinepubs/7908799/xns/connect.html -[shutdown]: http://pubs.opengroup.org/onlinepubs/7908799/xns/shutdown.html -[bind]: http://pubs.opengroup.org/onlinepubs/7908799/xns/bind.html -[listen]: http://pubs.opengroup.org/onlinepubs/7908799/xns/listen.html -[accept]: http://pubs.opengroup.org/onlinepubs/7908799/xns/accept.html -[poll]: http://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.html +[address]: https://pubs.opengroup.org/onlinepubs/7908799/xns/syssocket.h.html +[in]: https://pubs.opengroup.org/onlinepubs/000095399/basedefs/netinet/in.h.html +[socket]: https://pubs.opengroup.org/onlinepubs/009695399/functions/socket.html +[connect]: https://pubs.opengroup.org/onlinepubs/7908799/xns/connect.html +[shutdown]: https://pubs.opengroup.org/onlinepubs/7908799/xns/shutdown.html +[bind]: https://pubs.opengroup.org/onlinepubs/7908799/xns/bind.html +[listen]: https://pubs.opengroup.org/onlinepubs/7908799/xns/listen.html +[accept]: https://pubs.opengroup.org/onlinepubs/7908799/xns/accept.html +[poll]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.html [ring.h]: https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/io/ring.h;hb=HEAD diff --git a/docs/misc/status-override-table-spec.fodt b/docs/misc/status-override-table-spec.fodt index a831b7323b2bed31e19a06553b0ac40f1dfc797f..73c9061d98ef027a18539b8475bb030e788a0824 100644 --- a/docs/misc/status-override-table-spec.fodt +++ b/docs/misc/status-override-table-spec.fodt @@ -485,7 +485,7 @@ Title: Define a list of ACPI namespace names that are to be ignored by the OSPM License: - This work is licensed under the Creative Commons Attribution 4.0 International License. To view a copy of this license, visit http://creativecommons.org/licenses/by/4.0/ or send a letter to Creative Commons, 444 Castro Street, Suite 900, Mountain View, California, 94041, USA. + This work is licensed under the Creative Commons Attribution 4.0 International License. To view a copy of this license, visit https://creativecommons.org/licenses/by/4.0/ or send a letter to Creative Commons, 444 Castro Street, Suite 900, Mountain View, California, 94041, USA. Problem Statement: Hypervisors control which devices are allocated to which virtual machines. If ACPI tables created by platform firmware are passed directly from a hypervisor to a new virtual machine, the virtual machine can see all of the devices available to the hypervisor. This would be an incorrect view for the new virtual machine. By the same token, embedding the ability to create ACPI tables on the fly within a hypervisor adds more complexity and increases the resources needed by the hypervisor to run. To be clear, this is not a problem for the straightforward tables – such as the FADT, MADT, SRAT, or others – but is a problem for the DSDT and SSDT that contain AML byte codes. Generating AML byte codes on the fly would require the use of an ASL compiler, the most complex part of the tools needed to create ACPI tables. diff --git a/docs/misc/vtd-pi.txt b/docs/misc/vtd-pi.txt index d14b208c2781384fd2ea5ce5bd79666f790f71b2..4624a0f5a56824f1f5451303fb5d939cc50c2929 100644 --- a/docs/misc/vtd-pi.txt +++ b/docs/misc/vtd-pi.txt @@ -101,7 +101,7 @@ recorded in a data structure called a posted-interrupt descriptor. More information about APICv and CPU-side Posted-interrupt, please refer to Chapter "APIC VIRTUALIZATION AND VIRTUAL INTERRUPTS", and Section "POSTED-INTERRUPT PROCESSING" in the Intel SDM: -http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf +https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf - Root-Complex Support Interrupt posting is the process by which an interrupt request (from IOAPIC @@ -120,7 +120,7 @@ for the virtual-vectors and contains the attributes of the notification event interrupts recorded in the posted-interrupt descriptor. More information about VT-d PI, please refer to -http://www.intel.com/content/www/us/en/intelligent-systems/intel-technology/vt-directed-io-spec.html +https://www.intel.com/content/www/us/en/intelligent-systems/intel-technology/vt-directed-io-spec.html Design Overview ============== @@ -223,7 +223,7 @@ pCPU when an interrupt is recorded in the posted-interrupt descriptor. This existing global vector is a _special_ vector to CPU, CPU handle it in a _special_ way compared to normal vectors, please refer to 29.6 in Intel SDM -http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf +https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf for more information about how CPU handles it. After having VT-d PI, VT-d engine can issue notification event when the diff --git a/docs/misc/vtd.txt b/docs/misc/vtd.txt index 89076a0776e4b23e0ec8e7600d65bc9f9a3f5980..61a042e15f69997a053e435bfac265f1ce1893bd 100644 --- a/docs/misc/vtd.txt +++ b/docs/misc/vtd.txt @@ -203,10 +203,10 @@ systems using following Intel motherboards: Feel free to add others as they become available. - Dell: Optiplex 755 -http://www.dell.com/content/products/category.aspx/optix?c=us&cs=555&l=en&s=biz +https://www.dell.com/content/products/category.aspx/optix?c=us&cs=555&l=en&s=biz - HP Compaq: DC7800 -http://h10010.www1.hp.com/wwpc/us/en/en/WF04a/12454-12454-64287-321860-3328898.html +https://h10010.www1.hp.com/wwpc/us/en/en/WF04a/12454-12454-64287-321860-3328898.html For more information, pls refer to https://wiki.xen.org/wiki/VTdHowTo. diff --git a/docs/misc/xen-env-table-spec.fodt b/docs/misc/xen-env-table-spec.fodt index ccde7a69814f01a47bb1c5db471d571c1bd31aca..174e5fd1288429d998fb6eb2df188b8ef52973a0 100644 --- a/docs/misc/xen-env-table-spec.fodt +++ b/docs/misc/xen-env-table-spec.fodt @@ -530,7 +530,7 @@ Title: Define Xen Environment table for passing Xen specific information to DOM0. License: - This work is licensed under the BSD License. To view a copy of this license, visit http://opensource.org/licenses/BSD-3-Clause. + This work is licensed under the BSD License. To view a copy of this license, visit https://opensource.org/licenses/BSD-3-Clause. Problem Statement: DOM0(Linux) requires additional information about the Xen environment for proper communication with Xen. DOM0 shares some memory pages with Xen and it need the address and size of the memory allocated to it. DOM0 also needs to configure interrupt that will be used for notification of events. The Xen Environment Table: diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 5cd5c8a3b9391b12f5c603deacbfe72271cd8c25..1a502e1a5e28db53c4b3cc3ecf488792d94eae13 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -232,7 +232,7 @@ The BIOS used by this domain. These xenstore values are used to override some of the default string values in the SMBIOS table constructed in hvmloader. See the SMBIOS -table specification at http://www.dmtf.org/standards/smbios/ +table specification at https://www.dmtf.org/standards/smbios/ #### ~/bios-strings/oem-* = STRING [HVM,INTERNAL] diff --git a/docs/misc/xl-psr.pandoc b/docs/misc/xl-psr.pandoc index 3d196ed2edccb8df2717ebbc201465a2fbe78acc..b9de9af175fb7226c739646d95c38fbaabd9addc 100644 --- a/docs/misc/xl-psr.pandoc +++ b/docs/misc/xl-psr.pandoc @@ -251,4 +251,4 @@ hexadecimal value. ## Reference [1] Intel SDM -(http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html). +(https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html). diff --git a/docs/misc/xsm-flask.txt b/docs/misc/xsm-flask.txt index 2419c5cf2916de736122be57c7ad88802a9bd0a2..281e450bcfbbe4a703d9c6bd4df21642d3c0ee88 100644 --- a/docs/misc/xsm-flask.txt +++ b/docs/misc/xsm-flask.txt @@ -93,7 +93,7 @@ rebuild. FLASK uses only one domain configuration parameter (seclabel) defining the full security label of the newly created domain. If using the example policy, "seclabel='system_u:system_r:domU_t'" is an example of a normal domain. The -labels are in the same format as SELinux labels; see http://selinuxproject.org +labels are in the same format as SELinux labels; see https://selinuxproject.org for more details on the use of the user, role, and optional MLS/MCS labels. FLASK policy overview diff --git a/docs/process/release-technician-checklist.txt b/docs/process/release-technician-checklist.txt index 4b061bf5f20bbb72e092e5930177374f9bb0c10f..7a077777ec162c580d6d2f8edb4ba0474c5172b3 100644 --- a/docs/process/release-technician-checklist.txt +++ b/docs/process/release-technician-checklist.txt @@ -23,7 +23,7 @@ t=RELEASE-$r # - check (for point releases, but not RCs) all XSAs have been applied (Lars) # * check, even for point releases -* http://logs.test-lab.xenproject.org/osstest/results/all-branch-statuses.txt +* https://logs.test-lab.xenproject.org/osstest/results/all-branch-statuses.txt # QEMU diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc index 2e74c3b57ef5a5ee88230b3ca367ea56ab10846f..654ba2360592f85f6a9cc126c27417bbe428372c 100644 --- a/docs/process/sending-patches.pandoc +++ b/docs/process/sending-patches.pandoc @@ -82,7 +82,7 @@ modified form), the `Origin:` tag specifies the source of the patch: E.g.: - Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3 + Origin: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3 The commit id should be shortened to its first 12 characters. diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index 8f80d61d2f1aa9e63da9b1e61b77a67c826efe6f..7826419dad563a3b70c3c97fc4c0fb5339bd58e9 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -271,7 +271,7 @@ Hi all, Xen X.Y rcZ is tagged. You can check that out from xen.git: -git://xenbits.xen.org/xen.git X.Y.0-rcZ +https://xenbits.xen.org/git-http/xen.git X.Y.0-rcZ For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/X.Y.0-rcZ/xen-X.Y.0-rcZ.tar.gz diff --git a/m4/README.source b/m4/README.source index 7a8719d9304cea05269e0b0cfaa32e343763c1e1..af730953ac0cb05ca45e9a03f031e5bc2b7764ec 100644 --- a/m4/README.source +++ b/m4/README.source @@ -6,9 +6,9 @@ m4 sources we have picked up or developed. ax_compare_version.m4 ===================== This file was fetched from -http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 -Also see http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +Also see https://www.gnu.org/software/autoconf-archive/ax_compare_version.html pkg.m4 ====== diff --git a/m4/ax_compare_version.m4 b/m4/ax_compare_version.m4 index 26f4dec2497e3b9667c558c72c9e3b74188f48be..8a8103e94beee8778045e720ea13ad8ea040b396 100644 --- a/m4/ax_compare_version.m4 +++ b/m4/ax_compare_version.m4 @@ -1,7 +1,7 @@ -# Fetched from http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +# Fetched from https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 # Commit ID: 27948f49ca30e4222bb7cdd55182bd7341ac50c5 # =========================================================================== -# http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +# https://www.gnu.org/software/autoconf-archive/ax_compare_version.html # =========================================================================== # # SYNOPSIS diff --git a/m4/ocaml.m4 b/m4/ocaml.m4 index b067ee942741d88522eb1955189408b157ab9ca6..90f44772a7628aa0f29d514b2f142d4660ea7e43 100644 --- a/m4/ocaml.m4 +++ b/m4/ocaml.m4 @@ -1,5 +1,5 @@ dnl autoconf macros for OCaml -dnl from http://forge.ocamlcore.org/ +dnl from https://forge.ocamlcore.org/ dnl dnl Copyright © 2009 Richard W.M. Jones dnl Copyright © 2009 Stefano Zacchiroli diff --git a/m4/pkg.m4 b/m4/pkg.m4 index ed7182d826339ebc7459ef61cb92c06128865389..bb59b15417268411e83f9ae6ba8fbe01faf2e38f 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -147,7 +147,7 @@ path to pkg-config. _PKG_TEXT -To get pkg-config, see .])[]dnl +To get pkg-config, see .])[]dnl ]) else $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS diff --git a/misc/coverity/model.c b/misc/coverity/model.c index 1ec3fe86735a542039a1bfb444cd94338e26ae09..aa48107e6e881b73adb06c71b8e25607dcecd774 100644 --- a/misc/coverity/model.c +++ b/misc/coverity/model.c @@ -21,7 +21,7 @@ * Copyright (c) 2013-2014 Citrix Systems Ltd; All Right Reserved * * Based on: - * http://hg.python.org/cpython/file/tip/Misc/coverity_model.c + * https://hg.python.org/cpython/file/tip/Misc/coverity_model.c * Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, * 2011, 2012, 2013 Python Software Foundation; All Rights Reserved * diff --git a/stubdom/vtpmmgr/tpmrsa.c b/stubdom/vtpmmgr/tpmrsa.c index b18a5a3af680a69c758da8cae531fd7999dbdbef..7731640f6899dfde21106b0a34575b70ca25699d 100644 --- a/stubdom/vtpmmgr/tpmrsa.c +++ b/stubdom/vtpmmgr/tpmrsa.c @@ -3,7 +3,7 @@ * * Copyright (C) 2006-2011, Brainspark B.V. * - * This file is part of PolarSSL (http://www.polarssl.org) + * This file is part of PolarSSL (https://www.polarssl.org) * Lead Maintainer: Paul Bakker * * All rights reserved. @@ -24,8 +24,6 @@ /* * RSA was designed by Ron Rivest, Adi Shamir and Len Adleman. * - * http://theory.lcs.mit.edu/~rivest/rsapaper.pdf - * http://www.cacr.math.uwaterloo.ca/hac/about/chap8.pdf */ #include "tcg.h" diff --git a/stubdom/vtpmmgr/tpmrsa.h b/stubdom/vtpmmgr/tpmrsa.h index 65fd32a45c58ec504a9d6ed93c40e312567fbd6d..efeb5f2a21e4ac43b3cda417c0c8cea62052087c 100644 --- a/stubdom/vtpmmgr/tpmrsa.h +++ b/stubdom/vtpmmgr/tpmrsa.h @@ -5,7 +5,7 @@ * * Copyright (C) 2006-2010, Brainspark B.V. * - * This file is part of PolarSSL (http://www.polarssl.org) + * This file is part of PolarSSL (https://www.polarssl.org) * Lead Maintainer: Paul Bakker * * All rights reserved. diff --git a/tools/configure b/tools/configure index dae377c98252b9daf491a55058d11d2bf3c3ad84..f6f13bfdc0901b0cea125c5ac13208c92e7b7a0f 100755 --- a/tools/configure +++ b/tools/configure @@ -3753,10 +3753,10 @@ esac -# Fetched from http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +# Fetched from https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 # Commit ID: 27948f49ca30e4222bb7cdd55182bd7341ac50c5 # =========================================================================== -# http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +# https://www.gnu.org/software/autoconf-archive/ax_compare_version.html # =========================================================================== # # SYNOPSIS @@ -8376,7 +8376,7 @@ Alternatively, you may set the environment variables glib_CFLAGS and glib_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else glib_CFLAGS=$pkg_cv_glib_CFLAGS @@ -8467,7 +8467,7 @@ Alternatively, you may set the environment variables pixman_CFLAGS and pixman_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else pixman_CFLAGS=$pkg_cv_pixman_CFLAGS @@ -9923,7 +9923,7 @@ Alternatively, you may set the environment variables SYSTEMD_CFLAGS and SYSTEMD_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else SYSTEMD_CFLAGS=$pkg_cv_SYSTEMD_CFLAGS @@ -10018,7 +10018,7 @@ Alternatively, you may set the environment variables SYSTEMD_CFLAGS and SYSTEMD_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else SYSTEMD_CFLAGS=$pkg_cv_SYSTEMD_CFLAGS diff --git a/tools/examples/xeninfo.pl b/tools/examples/xeninfo.pl index 1815d1d9f219799a83fbc0329a4a1a010264893e..34c9cc65ce4407e38c03aaf8a46d1a150cbabccb 100644 --- a/tools/examples/xeninfo.pl +++ b/tools/examples/xeninfo.pl @@ -6,13 +6,13 @@ # ingard [at] mevaag [dot] no # # # # This work is licensed under the Creative Commons Attribution-Noncommercial-Share Alike 3.0 License. # -# To view a copy of this license, visit http://creativecommons.org/licenses/by-nc-sa/3.0/ or send a letter # +# To view a copy of this license, visit https://creativecommons.org/licenses/by-nc-sa/3.0/ or send a letter # # to Creative Commons, 171 Second Street, Suite 300, San Francisco, California, 94105, USA. # # # ############################################################################################################# use strict; -# http://search.cpan.org/~rjray/RPC-XML-0.59/lib/RPC/XML/Client.pm +# https://search.cpan.org/~rjray/RPC-XML-0.59/lib/RPC/XML/Client.pm require RPC::XML; require RPC::XML::Client; diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile index 345037b93b7f7987f0344f8a3ae86b4ec42a6caa..22e1d9dfaf88a74338e6521275574d9b775fa7b9 100644 --- a/tools/firmware/Makefile +++ b/tools/firmware/Makefile @@ -36,7 +36,7 @@ ifeq ($(CONFIG_ROMBIOS),y) @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \ echo "==========================================================================="; \ echo "Require dev86 rpm or bin86 & bcc debs version >= 0.16.14 to build firmware!"; \ - echo "(visit http://www.debath.co.uk/dev86/ for more information)"; \ + echo "(visit https://www.debath.co.uk/dev86/ for more information)"; \ echo "==========================================================================="; \ false ; \ fi diff --git a/tools/firmware/etherboot/README b/tools/firmware/etherboot/README index 5e3c1daf588fb33bc82238b818ba6aef5c8062e5..51c1d6db5bc7540a7495d281405355d796e5141b 100644 --- a/tools/firmware/etherboot/README +++ b/tools/firmware/etherboot/README @@ -1,28 +1,7 @@ - -This directory builds gPXE option ROMs from the gPXE source +This directory builds iPXE option ROMs from the iPXE source tarball. We provide this tarball in our source so that the option ROMs can be reconstructed from source, allowing easier debugging and fulfilling the terms of the GPL. We make a few non-standard settings, most to do with timeouts and when to give up, and for stricter DHCP spec compliance. - ----------------------------------------- - -Since gPXE upstream do not appear to distribute tarballs, we -generated one ourselves with the following runes (to extract the tree -as on 25th September 2008): - - git clone git://git.etherboot.org/scm/gpxe.git - cd gpxe - git archive --format=tar --prefix=gpxe/ c24bc349ead939d90b5784dbff3cd9fdb9d83ba8 | gzip -n >../gpxe-git-snapshot.tar.gz - ----------------------------------------- - -Previously, an image from Rom-o-matic.net was provided here, fetched -from the following URL: - -http://rom-o-matic.net/5.4.3/build.php?version=5.4.3&F=ignore&nic=rtl8139%3Artl8139+--+%5B0x10ec%2C0x8139%5D&ofmt=Binary+ROM+Image%28.zrom%29&arch=i386&ASK_BOOT=-1&BOOT_FIRST=BOOT_NIC&BOOT_SECOND=BOOT_NOTHING&BOOT_THIRD=BOOT_NOTHING&BOOT_INDEX=0&STATIC_CLIENT_IP=&STATIC_SUBNET_MASK=&STATIC_SERVER_IP=&STATIC_GATEWAY_IP=&STATIC_BOOTFILE=&EXIT_ON_FILE_LOAD_ERROR=on&DHCP_CLIENT_ID=&DHCP_CLIENT_ID_LEN=&DHCP_CLIENT_ID_TYPE=&DHCP_USER_CLASS=&DHCP_USER_CLASS_LEN=&ALLOW_ONLY_ENCAPSULATED=on&DEFAULT_BOOTFILE=&CONGESTED=on&BACKOFF_LIMIT=7&TIMEOUT=180&TRY_FLOPPY_FIRST=0&EXIT_IF_NO_OFFER=on&TAGGED_IMAGE=on&ELF_IMAGE=on&PXE_IMAGE=on&DOWNLOAD_PROTO_TFTP=on&COMCONSOLE=0x3F8&CONSPEED=9600&COMPARM=0x03&PXE_EXPORT=on&CONFIG_PCI=on&CONFIG_ISA=on&BUILD_ID=&PCBIOS=on&PXE_DHCP_STRICT=on&A=Get+ROM - -The mkhex script in tools/firmware/hvmloader will make the header file -from the downloaded image. diff --git a/tools/firmware/hvmloader/pci_regs.h b/tools/firmware/hvmloader/pci_regs.h index 7bf2d873ab644c5d342a7e4112a94814e62ce71c..4b093308f6af346afed7cf55c764fd46560bc700 100644 --- a/tools/firmware/hvmloader/pci_regs.h +++ b/tools/firmware/hvmloader/pci_regs.h @@ -6,7 +6,7 @@ * Copyright 1997--1999 Martin Mares * * For more information, please consult the following manuals (look at - * http://www.pcisig.com/ for how to get them): + * https://www.pcisig.com/ for how to get them): * * PCI BIOS Specification * PCI Local Bus Specification diff --git a/tools/firmware/hvmloader/pir.c b/tools/firmware/hvmloader/pir.c index cc420ddff48d0c4f748552fbddc106930796b903..369b4f9b903f961bf79ee2015384187084e40d1e 100644 --- a/tools/firmware/hvmloader/pir.c +++ b/tools/firmware/hvmloader/pir.c @@ -19,7 +19,7 @@ /* * The structure of these tables is described in - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ unsigned long create_pir_tables(void) { diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h index 9f9259c2e144420d4cb1db190a7af447283624ad..5129b0c7fd9a087810a299ee8930f755814a263b 100644 --- a/tools/firmware/hvmloader/pir_types.h +++ b/tools/firmware/hvmloader/pir_types.h @@ -17,7 +17,7 @@ * Copyright (C) Citrix Systems, 2011 * * See the PCI Interrupt Routing spec for more detail: - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ #ifndef PIR_TYPES_H diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h index 7c648ece71698af003f1600a150b1b77fe880254..3f1c120da60b6aa95cb2b6b1f03cc31d912832a4 100644 --- a/tools/firmware/hvmloader/smbios_types.h +++ b/tools/firmware/hvmloader/smbios_types.h @@ -19,7 +19,7 @@ * Authors: Andrew D. Ball * * See the SMBIOS 2.4 spec for more detail: - * http://www.dmtf.org/standards/smbios/ + * https://www.dmtf.org/standards/smbios/ */ #ifndef SMBIOS_TYPES_H diff --git a/tools/firmware/rombios/32bit/pmm.c b/tools/firmware/rombios/32bit/pmm.c index 09fec427483f3385b621aebac505705e7f819630..e0e39fef68a7b8d1695738e5e6f3c045c6dceaa4 100644 --- a/tools/firmware/rombios/32bit/pmm.c +++ b/tools/firmware/rombios/32bit/pmm.c @@ -1,7 +1,7 @@ /* * pmm.c - POST(Power On Self Test) Memory Manager * according to the specification described in - * http://www.phoenix.com/NR/rdonlyres/873A00CF-33AC-4775-B77E-08E7B9754993/0/specspmm101.pdf + * https://www.phoenix.com/NR/rdonlyres/873A00CF-33AC-4775-B77E-08E7B9754993/0/specspmm101.pdf * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public diff --git a/tools/firmware/rombios/rombios.c b/tools/firmware/rombios/rombios.c index 5cda22785f6f62cd54956cc04dff687fd51f07b6..1818d2fa4d32b3c89299076b3968827bea749402 100644 --- a/tools/firmware/rombios/rombios.c +++ b/tools/firmware/rombios/rombios.c @@ -7,8 +7,8 @@ // MandrakeSoft S.A. // 43, rue d'Aboukir // 75002 Paris - France -// http://www.linux-mandrake.com/ -// http://www.mandrakesoft.com/ +// https://www.linux-mandrake.com/ +// https://www.mandrakesoft.com/ // // This library is free software; you can redistribute it and/or // modify it under the terms of the GNU Lesser General Public @@ -733,7 +733,7 @@ typedef struct { // for access to EBDA area // The EBDA structure should conform to - // http://www.frontiernet.net/~fys/rombios.htm document + // https://www.frontiernet.net/~fys/rombios.htm document // I made the ata and cdemu structs begin at 0x121 in the EBDA seg // EBDA must be at most 768 bytes; it lives at EBDA_SEG, and the boot // device tables are at EBDA_SEG:IPL_TABLE_OFFSET @@ -2058,7 +2058,7 @@ print_bios_banner() // We also don't support letting option ROMs register as bootable disk // drives (BCVs), only as bootable devices (BEVs). // -// http://www.phoenix.com/en/Customer+Services/White+Papers-Specs/pc+industry+specifications.htm +// https://www.phoenix.com/en/Customer+Services/White+Papers-Specs/pc+industry+specifications.htm //-------------------------------------------------------------------------- static char drivetypes[][10]={"", "Floppy","Hard Disk","CD-Rom", "Network"}; diff --git a/tools/firmware/vgabios/README b/tools/firmware/vgabios/README index a21fef1e8b809df92f59ea946155ac0d1b8cf915..ccc1379ab18089ac0ad37ae6a1a7bc2414f7437c 100644 --- a/tools/firmware/vgabios/README +++ b/tools/firmware/vgabios/README @@ -72,8 +72,8 @@ These fonts are public domain The source code is based on information taken from : - Kevin Lawton's vga card emulation for bochs/plex86 - Ralf Brown's interrupts list avalaible at - http://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html -- Finn Thogersons' VGADOC4b available at http://home.worldonline.dk/~finth/ + https://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html +- Finn Thogersons' VGADOC4b available at https://home.worldonline.dk/~finth/ - Michael Abrash's Graphics Programming Black Book - Francois Gervais' book "programmation des cartes graphiques cga-ega-vga" edited by sybex @@ -83,9 +83,9 @@ The source code is based on information taken from : Feedback -------- Please report any bugs, comments, patches for this VGA Bios to info@vruppert.de -You can find the latest release at : http://www.nongnu.org/vgabios/ -For any information on bochs, visit the website http://bochs.sourceforge.net/ -For any information on qemu, visit the website http://fabrice.bellard.free.fr/qemu/ +You can find the latest release at : https://www.nongnu.org/vgabios/ +For any information on bochs, visit the website https://bochs.sourceforge.net/ +For any information on qemu, visit the website https://fabrice.bellard.free.fr/qemu/ History diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c index c5066906d3d001f8246566ed0e207e40659ac9a6..8e6408733ae68bdc582054ee58778c03f180b220 100644 --- a/tools/firmware/vgabios/vbe.c +++ b/tools/firmware/vgabios/vbe.c @@ -48,7 +48,7 @@ extern char vbebios_product_revision; ASM_START // FIXME: 'merge' these (c) etc strings with the vgabios.c strings? _vbebios_copyright: -.ascii "Bochs/Plex86 VBE(C) 2003 http://savannah.nongnu.org/projects/vgabios/" +.ascii "Bochs/Plex86 VBE(C) 2003 https://savannah.nongnu.org/projects/vgabios/" .byte 0x00 _vbebios_vendor_name: diff --git a/tools/firmware/vgabios/vbe_display_api.txt b/tools/firmware/vgabios/vbe_display_api.txt index fddb78b4bc713d153d1d08b95a639929a37d7b01..a365d2cc94aa36ef16dc730dd5886f69bc731fee 100644 --- a/tools/firmware/vgabios/vbe_display_api.txt +++ b/tools/firmware/vgabios/vbe_display_api.txt @@ -63,16 +63,16 @@ Todo References ---------- [VBE3] VBE 3 Specification at - http://www.vesa.org/vbe3.pdf + https://www.vesa.org/vbe3.pdf [BOCHS] Bochs Open Source IA-32 Emulator at - http://bochs.sourceforge.net + https://bochs.sourceforge.net [VBEBIOS] VBE Bios for Bochs at - http://savannah.gnu.org/projects/vgabios/ + https://savannah.gnu.org/projects/vgabios/ [Screenshots] Screenshots of programs using the VBE Bios at - http://japj.org/projects/bochs_plex86/screenshots.html + https://japj.org/projects/bochs_plex86/screenshots.html Abbreviations ------------- diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c index 1c75b7de96c2b366f910ffb7ed4a7833d53a59da..3ad98ca254a4ce8e7359a8a2d1a259b098ab927b 100644 --- a/tools/firmware/vgabios/vgabios.c +++ b/tools/firmware/vgabios/vgabios.c @@ -36,7 +36,7 @@ // // This VGA Bios is based on information taken from : // - Kevin Lawton's vga card emulation for bochs/plex86 -// - Ralf Brown's interrupts list available at http://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html +// - Ralf Brown's interrupts list available at https://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html // - Finn Thogersons' VGADOC4b available at http://home.worldonline.dk/~finth/ // - Michael Abrash's Graphics Programming Black Book // - Francois Gervais' book "programmation des cartes graphiques cga-ega-vga" edited by sybex @@ -193,11 +193,11 @@ vgabios_license: vgabios_website: .ascii "Please visit :" .byte 0x0a,0x0d -;;.ascii " . http://www.plex86.org" +;;.ascii " . https://www.plex86.org" ;;.byte 0x0a,0x0d -.ascii " . http://bochs.sourceforge.net" +.ascii " . https://bochs.sourceforge.net" .byte 0x0a,0x0d -.ascii " . http://www.nongnu.org/vgabios" +.ascii " . https://www.nongnu.org/vgabios" .byte 0x0a,0x0d .byte 0x0a,0x0d .byte 0x00 diff --git a/tools/fuzz/README.afl b/tools/fuzz/README.afl index a59564985ab773d4123feaffd8224c9ae6b1cc0d..d9d7138cafb9e494e14af223710e1a02d05421c4 100644 --- a/tools/fuzz/README.afl +++ b/tools/fuzz/README.afl @@ -2,7 +2,7 @@ Some fuzzing targets have American Fuzzy Lop (AFL) support. -See also http://lcamtuf.coredump.cx/afl/ +See also https://lcamtuf.coredump.cx/afl/ # HOW IT WORKS diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xendomains.in index 70f4129ef4bf24da30b05e5b568c01e39ed384bd..e713e6521933f768add60cb085c29e1137e83d10 100644 --- a/tools/hotplug/Linux/xendomains.in +++ b/tools/hotplug/Linux/xendomains.in @@ -12,7 +12,7 @@ # # Based on the example in the "Designing High Quality Integrated Linux # Applications HOWTO" by Avi Alkalay -# +# # ### BEGIN INIT INFO # Provides: xendomains diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index 30cc73cf97e30d81732ad084eeac3838bb3841de..ad771866e44321f6c880733a3df8e9315c2b348e 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -25,7 +25,7 @@ * * @section DESCRIPTION * - * Originally borrowed from the Qubes OS Project, http://www.qubes-os.org, + * Originally borrowed from the Qubes OS Project, https://www.qubes-os.org, * this code has been substantially rewritten to use the gntdev and gntalloc * devices instead of raw MFNs and map_foreign_range. * diff --git a/tools/include/libxl.h b/tools/include/libxl.h index d652895075a056ce6ec29f7b0623a0686eb84f36..6016b7b67598f6ac330819ef3df3bc4d003a30c4 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -2518,7 +2518,7 @@ static inline void libxl_cpuid_set(libxl_ctx *ctx __attribute__((unused)), * userid Data contents * "xl" domain config file in xl format, Unix line endings * "libvirt-xml" domain config file in libvirt XML format. See - * http://libvirt.org/formatdomain.html + * https://libvirt.org/formatdomain.html * "domain-userdata-lock" lock file to protect domain userdata in libxl. * It's a per-domain lock. Applications should * not touch this file. diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index fe2db66a62e68b92bdcbc1949e0de2900cec6e6c..a58a8ebf06de6e0a265cf8b5c41cceae8cf6d0a2 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -563,7 +563,7 @@ int acpi_build_tables(struct acpi_ctxt *ctxt, struct acpi_config *config) * into a 116 bytes buffer thus causing an overflow. The solution is to * link the higher revision FADT with the XSDT only and introduce a * compatible revision 1 FADT that is linked with the RSDT. Refer to: - * http://www.acpi.info/presentations/S01USMOBS169_OS%20new.ppt + * https://www.acpi.info/presentations/S01USMOBS169_OS%20new.ppt */ fadt_10 = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_10_fadt), 16); if (!fadt_10) goto oom; diff --git a/tools/libfsimage/reiserfs/fsys_reiserfs.c b/tools/libfsimage/reiserfs/fsys_reiserfs.c index 10ca65747678716d571afe9755158c4e10c56150..299b257e999426547199753508fcf76f1d440ed7 100644 --- a/tools/libfsimage/reiserfs/fsys_reiserfs.c +++ b/tools/libfsimage/reiserfs/fsys_reiserfs.c @@ -658,7 +658,7 @@ reiserfs_mount (fsi_file_t *ffi, const char *options) /***************** TREE ACCESSING METHODS *****************************/ /* I assume you are familiar with the ReiserFS tree, if not go to - * http://www.namesys.com/content_table.html + * https://www.namesys.com/content_table.html * * My tree node cache is organized as following * 0 ROOT node diff --git a/tools/libfsimage/xfs/xfs.h b/tools/libfsimage/xfs/xfs.h index 40699281e44d6a9587ef40a61563d71424292a4a..e9f93531d82aa12264ef3b4c8bbc8f56d9c7d58f 100644 --- a/tools/libfsimage/xfs/xfs.h +++ b/tools/libfsimage/xfs/xfs.h @@ -25,11 +25,11 @@ * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, * Mountain View, CA 94043, or: * - * http://www.sgi.com + * https://www.sgi.com * * For further information regarding this notice, see: * - * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/ + * https://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/ */ typedef signed char xfs_int8_t; diff --git a/tools/libfsimage/zfs/zfs_sha256.c b/tools/libfsimage/zfs/zfs_sha256.c index 616fc0a78069dbb162c24048d77551848db196db..18a5c05008ef4a5f5b2cec57e343ed8ea1f9ccfe 100644 --- a/tools/libfsimage/zfs/zfs_sha256.c +++ b/tools/libfsimage/zfs/zfs_sha256.c @@ -26,7 +26,7 @@ /* * SHA-256 checksum, as specified in FIPS 180-2, available at: - * http://csrc.nist.gov/cryptval + * https://csrc.nist.gov/cryptval * * This is a very compact implementation of SHA-256. * It is designed to be simple and portable, not to be fast. diff --git a/tools/libs/light/libxl_genid.c b/tools/libs/light/libxl_genid.c index 7f52356c605237677d3568aa70bf42d02077bfc1..963381bd903985f7fe1d00206f4bba740e010bda 100644 --- a/tools/libs/light/libxl_genid.c +++ b/tools/libs/light/libxl_genid.c @@ -28,7 +28,7 @@ * See Microsoft's "Virtual Machine Generation ID" specification for * further details, including when a new generation ID is required. * - * http://www.microsoft.com/en-us/download/details.aspx?id=30707 + * https://www.microsoft.com/en-us/download/details.aspx?id=30707 */ int libxl_ms_vm_genid_generate(libxl_ctx *ctx, libxl_ms_vm_genid *id) { diff --git a/tools/libs/stat/xenstat_qmp.c b/tools/libs/stat/xenstat_qmp.c index 9909b9727e48cb0690a8aa25604ae9372786c420..399176ecff46eb2667b4cb5643eeb620c830f329 100644 --- a/tools/libs/stat/xenstat_qmp.c +++ b/tools/libs/stat/xenstat_qmp.c @@ -357,7 +357,7 @@ static int qmp_connect(char *path) } /* Gather the qdisk statistics by querying QMP - Resources: http://wiki.qemu.org/QMP and qmp-commands.hx from the qemu code + Resources: https://wiki.qemu.org/QMP and qmp-commands.hx from the qemu code QMP Syntax for entering command mode. This command must be issued before issuing any other command: In: {"execute": "qmp_capabilities"} diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm index 68819b2d739cea5491b53f9b944ee2bd20d92c2b..ed6cfdb3cb8fee5e20d52878f7129ff0503693b3 100644 --- a/tools/misc/mkrpm +++ b/tools/misc/mkrpm @@ -34,7 +34,7 @@ Version: $version Release: $release License: GPL Group: System/Hypervisor -URL: http://xenbits.xenproject.org/xen.git +URL: https://xenbits.xenproject.org/xen.git BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root %define _binary_payload w1.gzdio diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c index e4306a0c2f8f03407a5c195de5b3d0350e9faf44..64f46ce571ffc2af803051983b03312ace000950 100644 --- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c +++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c @@ -52,7 +52,7 @@ static char * dup_String_val(value s) #include "_xtl_levels.inc" -/* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ +/* Option type support as per https://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ #ifndef Val_none #define Val_none Val_int(0) #endif diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74ad8fbda1ef4b9f7027eba1183621f..10ca7259b0edf72ad8df85c682e9b434f264ea39 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -226,7 +226,7 @@ static value Val_string_list(libxl_string_list *c_val) CAMLreturn(list); } -/* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ +/* Option type support as per https://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ #ifndef Val_none #define Val_none Val_int(0) #endif diff --git a/tools/tests/vhpet/main.c b/tools/tests/vhpet/main.c index 6fe65ea808c663d6c4618448bb4b4cea218cd11c..4054eec6296910d3117334091b3dac190f9aea29 100644 --- a/tools/tests/vhpet/main.c +++ b/tools/tests/vhpet/main.c @@ -14,7 +14,7 @@ */ /* - * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf + * https://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf * * xen_source is a directory that has all xen source below it. * diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index 23c3a23b199f2318dd34786d1ae00b964dd1213a..9eda1bfc00c0b6b35d34ce25268fc9c070d9da55 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -26,7 +26,7 @@ */ /* - inspired by http://swapped.cc/halloc/ + inspired by https://swapped.cc/halloc/ */ #ifdef _SAMBA_BUILD_ diff --git a/tools/xenstore/talloc_guide.txt b/tools/xenstore/talloc_guide.txt index c23ac77cad72ab9265ee5af5bf5edbc1e6800380..bfcb35506b790570ab170cffbd280b674d8b6068 100644 --- a/tools/xenstore/talloc_guide.txt +++ b/tools/xenstore/talloc_guide.txt @@ -5,7 +5,7 @@ Andrew Tridgell September 2004 The most current version of this document is available at - http://samba.org/ftp/unpacked/samba4/source/lib/talloc/talloc_guide.txt + https://samba.org/ftp/unpacked/samba4/source/lib/talloc/talloc_guide.txt If you are used to talloc from Samba3 then please read this carefully, as talloc has changed a lot. diff --git a/tools/xl/check-xl-disk-parse b/tools/xl/check-xl-disk-parse index 18fb66940a5464d17a89d41fa5fa9c051c5c2606..5f843585ad51f036c5ce09598a90d7702f70ae61 100755 --- a/tools/xl/check-xl-disk-parse +++ b/tools/xl/check-xl-disk-parse @@ -133,7 +133,7 @@ disk: { EOF -# http://backdrift.org/xen-block-iscsi-script-with-multipath-support +# https://backdrift.org/xen-block-iscsi-script-with-multipath-support one 0 iscsi:iqn.2001-05.com.equallogic:0-8a0906-23fe93404-c82797962054a96d-examplehost,xvda,w one 0 vdev=xvda,access=w,script=block-iscsi,target=iqn.2001-05.com.equallogic:0-8a0906-23fe93404-c82797962054a96d-examplehost @@ -148,8 +148,8 @@ disk: { EOF -# http://lists.linbit.com/pipermail/drbd-user/2008-September/010221.html -# http://www.drbd.org/users-guide-emb/s-xen-configure-domu.html +# https://lists.linbit.com/pipermail/drbd-user/2008-September/010221.html +# https://www.drbd.org/users-guide-emb/s-xen-configure-domu.html one 0 drbd:app01,hda,w expected < diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index d7ae8919df777d90f872628ca2f0afa3c78a66dc..98c630fc86295ca38e248f9db8329e2a15794bda 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -24,7 +24,7 @@ * Issue Date: October 2013 * * URL: - * http://support.amd.com/TechDocs/24593.pdf + * https://support.amd.com/TechDocs/24593.pdf */ /* The related documentation for K8 Revisions A - E is: @@ -35,7 +35,7 @@ * Issue Date: February 2006 * * URL: - * http://support.amd.com/TechDocs/26094.PDF + * https://support.amd.com/TechDocs/26094.PDF */ /* The related documentation for K8 Revisions F - G is: @@ -46,7 +46,7 @@ * Issue Date: July 2007 * * URL: - * http://support.amd.com/TechDocs/32559.pdf + * https://support.amd.com/TechDocs/32559.pdf */ /* Family10 MCA documentation published at @@ -57,7 +57,7 @@ * Isse Date: January 11, 2013 * * URL: - * http://support.amd.com/TechDocs/31116.pdf + * https://support.amd.com/TechDocs/31116.pdf */ #include diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index d14754e222820aba46678bcbeb9efe3fb5d38903..40be586c5c69b6a43c1ddca45c6c02c40226f3d8 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -11,9 +11,9 @@ * Software Developer's Manual * Order Number 253668 or free download from: * - * http://developer.intel.com/design/pentium4/manuals/253668.htm + * https://developer.intel.com/design/pentium4/manuals/253668.htm * - * For more information, go to http://www.urbanmyth.org/microcode + * For more information, go to https://www.urbanmyth.org/microcode * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index f7fec4b4ed1066f4cb4cc4ba1a0b16b86ab66175..cb0f74c1fefe47ec20f85451c2e090322e712372 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -11,9 +11,9 @@ * Software Developer's Manual * Order Number 253668 or free download from: * - * http://developer.intel.com/design/pentium4/manuals/253668.htm + * https://developer.intel.com/design/pentium4/manuals/253668.htm * - * For more information, go to http://www.urbanmyth.org/microcode + * For more information, go to https://www.urbanmyth.org/microcode * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c index 81f80c053a7a5472584508b0042629c4f15ac82a..6a0d119f86e4d85863abeca8066352d1a62aaea1 100644 --- a/xen/arch/x86/dmi_scan.c +++ b/xen/arch/x86/dmi_scan.c @@ -617,7 +617,7 @@ static const struct dmi_blacklist __initconstrel dmi_blacklist[] = { NO_MATCH, NO_MATCH }}, { force_acpi_ht, "ABIT i440BX-W83977", { - MATCH(DMI_BOARD_VENDOR, "ABIT "), + MATCH(DMI_BOARD_VENDOR, "ABIT "), MATCH(DMI_BOARD_NAME, "i440BX-W83977 (BP6)"), NO_MATCH, NO_MATCH }}, diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 41e3c4d5e42de151a3fb49bc93e4429e37be604a..864f6a84e6173f1414cbf3eb54e3ee08fb78179b 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -4,8 +4,8 @@ * MandrakeSoft S.A. * 43, rue d'Aboukir * 75002 Paris - France - * http://www.linux-mandrake.com/ - * http://www.mandrakesoft.com/ + * https://www.linux-mandrake.com/ + * https://www.mandrakesoft.com/ * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060c85cbd7d339bcdca488cdb143b47ac..969678f94244df4c6a6671015f8e766e27aa8fbe 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -4,8 +4,8 @@ * MandrakeSoft S.A. * 43, rue d'Aboukir * 75002 Paris - France - * http://www.linux-mandrake.com/ - * http://www.mandrakesoft.com/ + * https://www.linux-mandrake.com/ + * https://www.mandrakesoft.com/ * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public diff --git a/xen/arch/x86/include/asm/edd.h b/xen/arch/x86/include/asm/edd.h index afaa23732a385c71d5b3a1fb0be128e8deb69a84..9f8b8aa2219fc21e581e8d7aa00ce5bcffb3e188 100644 --- a/xen/arch/x86/include/asm/edd.h +++ b/xen/arch/x86/include/asm/edd.h @@ -7,8 +7,8 @@ * structures and definitions for the int 13h, ax={41,48}h * BIOS Enhanced Disk Drive Services * This is based on the T13 group document D1572 Revision 0 (August 14 2002) - * available at http://www.t13.org/docs2002/d1572r0.pdf. It is - * very similar to D1484 Revision 3 http://www.t13.org/docs2002/d1484r3.pdf + * available at https://www.t13.org/docs2002/d1572r0.pdf. It is + * very similar to D1484 Revision 3 https://www.t13.org/docs2002/d1484r3.pdf * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License v2.0 as published by diff --git a/xen/arch/x86/include/asm/hpet.h b/xen/arch/x86/include/asm/hpet.h index 9919f7473071d9d4cd81f1158f4189e7c0674f9e..b6840d768722d9d35820bfbcad343c08f82b1a27 100644 --- a/xen/arch/x86/include/asm/hpet.h +++ b/xen/arch/x86/include/asm/hpet.h @@ -3,7 +3,7 @@ /* * Documentation on HPET can be found at: - * http://www.intel.com/content/dam/www/public/us/en/documents/ + * https://www.intel.com/content/dam/www/public/us/en/documents/ * technical-specifications/software-developers-hpet-spec-1-0a.pdf */ diff --git a/xen/arch/x86/include/asm/hvm/vioapic.h b/xen/arch/x86/include/asm/hvm/vioapic.h index 2944ec20dd53bf90fa9b7776df20e4a5f54af7e9..4e0166f160575554f9619911b0cc4b4b082bada3 100644 --- a/xen/arch/x86/include/asm/hvm/vioapic.h +++ b/xen/arch/x86/include/asm/hvm/vioapic.h @@ -4,8 +4,8 @@ * MandrakeSoft S.A. * 43, rue d'Aboukir * 75002 Paris - France - * http://www.linux-mandrake.com/ - * http://www.mandrakesoft.com/ + * https://www.linux-mandrake.com/ + * https://www.mandrakesoft.com/ * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public diff --git a/xen/common/README.source b/xen/common/README.source index 732b9454c88abeddf6918e24d068129fc29e8c74..62a2033b104fd365ed456acf84f596fff5872721 100644 --- a/xen/common/README.source +++ b/xen/common/README.source @@ -26,7 +26,7 @@ The file is dually licensed under GPLv2.0 and LGPLv2.1 libelf ------ This directory was opriginally imported from the libelf -project at http://www.mr511.de/software/english.html +project at https://www.mr511.de/software/english.html This directory is licensed under LGPLv2.1 (see COPYING file) libfdt @@ -39,12 +39,12 @@ and a BSD 2-clause license lz4/decompress.c ----------------- This file was originally imported from the LZ4 project -( http://www.lz4.org). The source is available from +( https://www.lz4.org). The source is available from https://github.com/Cyan4973/lz4 The file is licensed under a BSD 2-clause license xz -- This directory was imported from the XZ Utils project -and is available under http://tukaani.org/xz/ +and is available under https://tukaani.org/xz/ The imported code is in the public domain diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c index 61b80aff1ba9bad72e7ce999ebe40198a21a83c1..fb829b41f13bfc288d8a063b9390f2688c777d11 100644 --- a/xen/common/bunzip2.c +++ b/xen/common/bunzip2.c @@ -35,7 +35,7 @@ Phone (337) 232-1234 or 1-800-738-2226 Fax (337) 232-1297 - http://www.hospiceacadiana.com/ + https://www.hospiceacadiana.com/ Manuel */ @@ -470,7 +470,7 @@ got_huff_bits: and decoded them into the intermediate buffer. There are dbufCount many decoded bytes in dbuf[]. Now undo the Burrows-Wheeler transform on dbuf. See - http://dogma.net/markn/articles/bwt/bwt.htm + https://dogma.net/markn/articles/bwt/bwt.htm */ /* Turn byteCount into cumulative occurrence counts of 0 to n-1. */ j = 0; diff --git a/xen/common/lz4/decompress.c b/xen/common/lz4/decompress.c index 876906fac1a75e9f7900a2597817f82e4cb9f309..501bd4b343ffd444c4221864d1bdeec7b8a85b1d 100644 --- a/xen/common/lz4/decompress.c +++ b/xen/common/lz4/decompress.c @@ -7,7 +7,7 @@ * * LZ4 - Fast LZ compression algorithm * Copyright (C) 2011-2012, Yann Collet. - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are @@ -33,8 +33,8 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * * You can contact the author at : - * - LZ4 homepage : http://fastcompression.blogspot.com/p/lz4.html - * - LZ4 source repository : http://code.google.com/p/lz4/ + * - LZ4 homepage : https://fastcompression.blogspot.com/p/lz4.html + * - LZ4 source repository : https://code.google.com/p/lz4/ */ #include "defs.h" diff --git a/xen/common/lzo.c b/xen/common/lzo.c index a87c76ddedad72314aba334495469ac3aa2aca66..480a49dad309ec6b194d03248d1d407fba4e650a 100644 --- a/xen/common/lzo.c +++ b/xen/common/lzo.c @@ -4,7 +4,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Adapted for Xen (files combined and syntactic/header changes) by: * Dan Magenheimer @@ -17,7 +17,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta @@ -87,7 +87,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta @@ -112,7 +112,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c index 212a99acd8c8d4c2649b3bcc56bb163f87ba7b8b..70b4d21b0f1d6da758f1df0f1c5229c6afdf200e 100644 --- a/xen/common/rcupdate.c +++ b/xen/common/rcupdate.c @@ -25,11 +25,11 @@ * Based on the original work by Paul McKenney * and inputs from Rusty Russell, Andrea Arcangeli and Andi Kleen. * Papers: - * http://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf - * http://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) + * https://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf + * https://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) * * For detailed explanation of Read-Copy Update mechanism see - - * http://lse.sourceforge.net/locking/rcupdate.html + * https://lse.sourceforge.net/locking/rcupdate.html */ #include #include diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c index 6cd99023adf6a4e92244891297f5b0ed68653309..69448d7b398634b6543b1fcea7b6101724c17b36 100644 --- a/xen/common/unlzma.c +++ b/xen/common/unlzma.c @@ -8,7 +8,7 @@ * implementation for lzma. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (C) 1999-2005 Igor Pavlov * * Copyrights of the parts, see headers below. @@ -47,7 +47,7 @@ static long long __init read_int(unsigned char *ptr, int size) /* Small range coder implementation for lzma. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (c) 1999-2005 Igor Pavlov */ @@ -207,7 +207,7 @@ rc_bit_tree_decode(struct rc *rc, uint16_t *p, int num_levels, int *symbol) * Small lzma deflate implementation. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (C) 1999-2005 Igor Pavlov */ diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c index 74056778ebecc070b38a82e8040657924f9cd13f..23eff1354fe0679299951abfb3fbe2bcc2adc699 100644 --- a/xen/common/unlzo.c +++ b/xen/common/unlzo.c @@ -26,7 +26,7 @@ * * Markus F.X.J. Oberhumer * - * http://www.oberhumer.com/opensource/lzop/ + * https://www.oberhumer.com/opensource/lzop/ */ #include "decompress.h" diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index 75bdf18c4ea7d4ea96a5eb51699a0354b7db166c..a0e986d36aa0569b145e9f2ad62f67c595ff1249 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -16,9 +16,9 @@ * Version 2.1 * * This is kernel port of TLSF allocator. - * Original code can be found at: http://rtportal.upv.es/rtmalloc/ + * Original code can be found at: https://rtportal.upv.es/rtmalloc/ * Adapted for Linux by Nitin Gupta (nitingupta910@gmail.com) - * (http://code.google.com/p/compcache/source/browse/trunk/sub-projects + * (https://code.google.com/p/compcache/source/browse/trunk/sub-projects * /allocators/tlsf-kmod r229 dated Aug 27, 2008 * Adapted for Xen by Dan Magenheimer (dan.magenheimer@oracle.com) */ diff --git a/xen/common/xz/crc32.c b/xen/common/xz/crc32.c index 092a74fbaba81e5fdf2f2b1f053f138941625d14..66cf046052fe40904c2e6efc125df9b5b9036f5f 100644 --- a/xen/common/xz/crc32.c +++ b/xen/common/xz/crc32.c @@ -2,7 +2,7 @@ * CRC32 using the polynomial from IEEE-802.3 * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/dec_bcj.c b/xen/common/xz/dec_bcj.c index bfa498587ab884d7148758f070c1f0d0cfa27c50..4070f3d533aef9ba1a6ac497fb8565a3e6d31a35 100644 --- a/xen/common/xz/dec_bcj.c +++ b/xen/common/xz/dec_bcj.c @@ -2,7 +2,7 @@ * Branch/Call/Jump (BCJ) filter decoders * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/dec_lzma2.c b/xen/common/xz/dec_lzma2.c index f80d8309f4c3cbcd1688aecc98deed5fd3c44d49..2521dacfe14fe3a909e96e425d4bd3766d749404 100644 --- a/xen/common/xz/dec_lzma2.c +++ b/xen/common/xz/dec_lzma2.c @@ -2,7 +2,7 @@ * LZMA2 decoder * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/lzma2.h b/xen/common/xz/lzma2.h index e0ef42e880a005099144df78a7c19b01d49410b2..acd70ffb7e7902cd2339899d36f84c609f946d36 100644 --- a/xen/common/xz/lzma2.h +++ b/xen/common/xz/lzma2.h @@ -2,7 +2,7 @@ * LZMA2 definitions * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/stream.h b/xen/common/xz/stream.h index d36d0fec6424ef23bb7f9d0c457c859171d995cd..7f34e66381a407e3e6535f6d4badda3c981f7f3a 100644 --- a/xen/common/xz/stream.h +++ b/xen/common/xz/stream.h @@ -12,7 +12,7 @@ /* * See the .xz file format specification at - * http://tukaani.org/xz/xz-file-format.txt + * https://tukaani.org/xz/xz-file-format.txt * to understand the container format. */ diff --git a/xen/common/zstd/bitstream.h b/xen/common/zstd/bitstream.h index 2b06d4551f03fe116b8420130155b10d8a71fe0d..2192cad3569b738b065e593c65a9858ba1702df8 100644 --- a/xen/common/zstd/bitstream.h +++ b/xen/common/zstd/bitstream.h @@ -4,7 +4,7 @@ * header file (to include) * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/entropy_common.c b/xen/common/zstd/entropy_common.c index d329cccc608c3de6279b8ad84472e402b860761c..81d37b1a521555d86b945ec79e76c26daedd68e4 100644 --- a/xen/common/zstd/entropy_common.c +++ b/xen/common/zstd/entropy_common.c @@ -2,7 +2,7 @@ * Common functions of New Generation Entropy library * Copyright (C) 2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/fse.h b/xen/common/zstd/fse.h index 5761e09f17ff209704959170d81a8cdada4b5c88..8db3773b17e3105f29667a8b366f41d4224114e2 100644 --- a/xen/common/zstd/fse.h +++ b/xen/common/zstd/fse.h @@ -3,7 +3,7 @@ * Public Prototypes declaration * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/fse_decompress.c b/xen/common/zstd/fse_decompress.c index ba5f960eb35dd6d71401045d673e581e114188b8..eb5abd6680169f039a3d04be2e3e689a4abef67f 100644 --- a/xen/common/zstd/fse_decompress.c +++ b/xen/common/zstd/fse_decompress.c @@ -2,7 +2,7 @@ * FSE : Finite State Entropy decoder * Copyright (C) 2013-2015, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/huf.h b/xen/common/zstd/huf.h index 0e091dbffe3df40081df16468a285fdab579cdbb..8b07da65cff813dd2170ae895d85576aac1cd01f 100644 --- a/xen/common/zstd/huf.h +++ b/xen/common/zstd/huf.h @@ -3,7 +3,7 @@ * header file * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/huf_decompress.c b/xen/common/zstd/huf_decompress.c index 1bdfc695d0537465d4e712d4f9bf5914f35a33a3..e7bfa9007daa2c6096261f2464e41b734d0b798c 100644 --- a/xen/common/zstd/huf_decompress.c +++ b/xen/common/zstd/huf_decompress.c @@ -2,7 +2,7 @@ * Huffman decoder, part of New Generation Entropy library * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/crypto/README.source b/xen/crypto/README.source index 894045de28536dba2bc21a58c7753266ed549146..bdd85aec76ac59827e1c0209f3015d6b9def4f75 100644 --- a/xen/crypto/README.source +++ b/xen/crypto/README.source @@ -5,7 +5,7 @@ This documents the upstream sources for files in this directory. rijndael.c ========== This file comes from -http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ +https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ vmac.c ====== @@ -14,4 +14,4 @@ are in the files). See - https://en.wikipedia.org/wiki/VMAC -- http://www.fastcrypto.org/vmac/vmac.c +- https://www.fastcrypto.org/vmac/vmac.c diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 091f09b21752ab30b509ec3e2d216a5986a40d3d..682bf12aaaf5bd7b50afda56cdc9694984442c57 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -14,7 +14,7 @@ * Based on Linux's IPMMU-VMSA driver from Renesas BSP: * drivers/iommu/ipmmu-vmsa.c * you can found at: - * url: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git + * url: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git * branch: v4.14.75-ltsi/rcar-3.9.6 * commit: e206eb5b81a60e64c35fbc3a999b1a0db2b98044 * and Xen's SMMU driver: diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index b42acb8d7c091932825f60e97bdc86b1a466d026..9f8819785b49f26d7a03e30d51ac5dd0d6700719 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) * Device [8086:2fc0] * Erratum HSE43 * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset - * http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x2fc0 }, /* * Devices [8086:6f60,6fa0,6fc0] * Errata BDF2 / BDX2 * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration - * http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x6f60 }, { PCI_VENDOR_ID_INTEL, 0x6fa0 }, diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h index 0a6778421f60e5f4daa4476627a9ed54c6ff654a..6a0ede3c1924109699e7af391cf07d7fae62113a 100644 --- a/xen/include/acpi/actbl3.h +++ b/xen/include/acpi/actbl3.h @@ -95,7 +95,7 @@ * binary wire protocols." (Or ACPI tables and buffers.) "If you ask me, * this decision was a design error in C. Ritchie could have picked an order * and stuck with it." Norman Ramsey. - * See http://stackoverflow.com/a/1053662/41661 + * See https://stackoverflow.com/a/1053662/41661 */ /******************************************************************************* diff --git a/xen/include/crypto/README.source b/xen/include/crypto/README.source index 68de1cd1bb5bd2e5b0632176ae12a11f99aaf0b2..2c6325ec724dcfea0f209a9e450a86d0f7014611 100644 --- a/xen/include/crypto/README.source +++ b/xen/include/crypto/README.source @@ -5,7 +5,7 @@ This documents the upstream sources for files in this directory. rijndael.h ========== This file comes from -http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ +https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ vmac.h ====== @@ -14,4 +14,4 @@ are in the files). See - https://en.wikipedia.org/wiki/VMAC -- http://www.fastcrypto.org/vmac/vmac.h +- https://www.fastcrypto.org/vmac/vmac.h diff --git a/xen/include/crypto/vmac.h b/xen/include/crypto/vmac.h index 457f3f5dd6da05c3e9c1e152e9338077ab17fdfe..305ad40ac00bd1c4d26588bd716b8540717ad50c 100644 --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -62,9 +62,9 @@ typedef unsigned long long uint64_t; * This implementation supports two free AES implementations: OpenSSL's and * Paulo Barreto's. To use OpenSSL's, you will need to include the OpenSSL * crypto library (eg, gcc -lcrypto foo.c). For Barreto's, you will need - * to compile rijndael-alg-fst.c, last seen at http://www.iaik.tu-graz.ac.at/ + * to compile rijndael-alg-fst.c, last seen at https://www.iaik.tu-graz.ac.at/ * research/krypto/AES/old/~rijmen/rijndael/rijndael-fst-3.0.zip and - * http://homes.esat.kuleuven.be/~rijmen/rijndael/rijndael-fst-3.0.zip. + * https://homes.esat.kuleuven.be/~rijmen/rijndael/rijndael-fst-3.0.zip. * To use a different implementation, use these definitions as a model. * ----------------------------------------------------------------------- */ #if VMAC_USE_OPENSSL diff --git a/xen/include/efi/eficapsule.h b/xen/include/efi/eficapsule.h index 481af2816af55b5f0ec3a0bf17198faee3b31983..45e98aafffdf83fbd4069186aafb26477b4ff0f0 100644 --- a/xen/include/efi/eficapsule.h +++ b/xen/include/efi/eficapsule.h @@ -4,7 +4,7 @@ Copyright (c) 2004 - 2007, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at -http://opensource.org/licenses/bsd-license.php +https://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. diff --git a/xen/include/public/arch-x86/hvm/start_info.h b/xen/include/public/arch-x86/hvm/start_info.h index e33557c0b4e98c6db3d3521710daa3838586733c..caef8972b24b638356611344b7dca088f9954b90 100644 --- a/xen/include/public/arch-x86/hvm/start_info.h +++ b/xen/include/public/arch-x86/hvm/start_info.h @@ -89,7 +89,7 @@ * The values used in the type field of the memory map table entries are * defined below and match the Address Range Types as defined in the "System * Address Map Interfaces" section of the ACPI Specification. Please refer to - * section 15 in version 6.2 of the ACPI spec: http://uefi.org/specifications + * section 15 in version 6.2 of the ACPI spec: https://uefi.org/specifications */ #define XEN_HVM_MEMMAP_TYPE_RAM 1 #define XEN_HVM_MEMMAP_TYPE_RESERVED 2 diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h index 5a78a7607c0ddac82ea49a363a0a9fcfe2b885ae..5022e85194f930ef3f62765385b0fff1cfae00d0 100644 --- a/xen/include/public/errno.h +++ b/xen/include/public/errno.h @@ -54,7 +54,7 @@ enum xen_errno { * * The set of identifiers to be added here shouldn't extend beyond what * POSIX mandates (see e.g. - * http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html) + * https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html) * with the exception that we support some optional (XSR) values * specified there (but no new ones should be added). */ diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h index 1dfa17a6d02a34d55ad095ce392bbdf99e8424bb..0bfa1626f591f1566abfe5846f5d732664ec3733 100644 --- a/xen/include/public/grant_table.h +++ b/xen/include/public/grant_table.h @@ -43,7 +43,7 @@ /* Some rough guidelines on accessing and updating grant-table entries * in a concurrency-safe manner. For more information, Linux contains a * reference implementation for guest OSes (drivers/xen/grant_table.c, see - * http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD + * https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD * * NB. WMB is a no-op on current-generation x86 processors. However, a * compiler barrier will still be required. diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h index a22b4ed45d2eb2dcaf61db9bef1f83b80d426a40..8d38c495f3e30291a518ca7979ffe8580defb5cd 100644 --- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -86,7 +86,7 @@ /* * Viridian enlightenments * - * (See http://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor%20Top%20Level%20Functional%20Specification%20v4.0.docx) + * (See https://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor%20Top%20Level%20Functional%20Specification%20v4.0.docx) * * To expose viridian enlightenments to the guest set this parameter * to the desired feature mask. The base feature set must be present diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 22f1eef0c0ca371a8cfe3eeea99f54bec1e234c9..6546f4cda9186cdde7fa4e782188970423db83b2 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -571,9 +571,9 @@ * command on a native device. * * More information about trim/unmap operations can be found at: - * http://t13.org/Documents/UploadedDocuments/docs2008/ + * https://t13.org/Documents/UploadedDocuments/docs2008/ * e07154r6-Data_Set_Management_Proposal_for_ATA-ACS2.doc - * http://www.seagate.com/staticfiles/support/disc/manuals/ + * https://www.seagate.com/staticfiles/support/disc/manuals/ * Interface%20manuals/100293068c.pdf * * Optional. See "feature-discard", "discard-alignment", diff --git a/xen/include/public/io/libxenvchan.h b/xen/include/public/io/libxenvchan.h index 2eab65cb195460446b0d4de5178dfa564c258476..3776937713d75c60629e0ef21f3ac69142e68fe5 100644 --- a/xen/include/public/io/libxenvchan.h +++ b/xen/include/public/io/libxenvchan.h @@ -13,7 +13,7 @@ * * @section DESCRIPTION * - * Originally borrowed from the Qubes OS Project, http://www.qubes-os.org, + * Originally borrowed from the Qubes OS Project, https://www.qubes-os.org, * this code has been substantially rewritten to use the gntdev and gntalloc * devices instead of raw MFNs and map_foreign_range. * diff --git a/xen/include/public/io/tpmif.h b/xen/include/public/io/tpmif.h index ad02dbaf1a312e9de30fbbd618fa02db9d4e1930..747f7259d804ea566536720e8b4dc7cacb38f335 100644 --- a/xen/include/public/io/tpmif.h +++ b/xen/include/public/io/tpmif.h @@ -71,7 +71,7 @@ typedef struct tpmif_tx_interface tpmif_tx_interface_t; * TPM may cancel a command if the interface is seized by another locality. * * The TPM command format is defined by the TCG, and is available at - * http://www.trustedcomputinggroup.org/resources/tpm_main_specification + * https://www.trustedcomputinggroup.org/resources/tpm_main_specification */ enum tpmif_state { diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index a5631303348b16f7b5f737c9e94af4daf1d11527..f93c1b6ee8198cc7560808cdfab9ed72a74fc273 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -172,7 +172,7 @@ * ... * * This has already been reported upstream: - * http://bugs.llvm.org/show_bug.cgi?id=32595 + * https://bugs.llvm.org/show_bug.cgi?id=32595 */ #ifdef __clang__ # define CLANG_DISABLE_WARN_GCC_COMPAT_START \ diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h index 06e6f87c3d800df44fbc254448b1f95537224971..42afd609c22030fb2cfd77277488e0981fa44dd4 100644 --- a/xen/include/xen/elfstructs.h +++ b/xen/include/xen/elfstructs.h @@ -45,7 +45,7 @@ typedef uint64_t Elf64_Xword; /* * e_ident[] identification indexes - * See http://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html + * See https://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html */ #define EI_MAG0 0 /* file ID */ #define EI_MAG1 1 /* file ID */ @@ -374,7 +374,7 @@ typedef struct { /* * ARM32 relocation types. See - * http://infocenter.arm.com/help/topic/com.arm.doc.ihi0044f/IHI0044F_aaelf.pdf + * https://infocenter.arm.com/help/topic/com.arm.doc.ihi0044f/IHI0044F_aaelf.pdf * S - address of symbol. * A - addend for relocation (r_addend or need to extract from insn) * P - address of the dest being relocated (derieved from r_offset) diff --git a/xen/include/xen/lzo.h b/xen/include/xen/lzo.h index e920027fadaf3f272e798ef88777c886574c8809..899d61edd141cc531af902909708524345a90611 100644 --- a/xen/include/xen/lzo.h +++ b/xen/include/xen/lzo.h @@ -7,7 +7,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index a90aff1712bafc6ed87296858803d16c253e7b53..bb7b83223254adc571eaef7b9713e4b044032edf 100644 --- a/xen/include/xen/pci_regs.h +++ b/xen/include/xen/pci_regs.h @@ -6,7 +6,7 @@ * Copyright 1997--1999 Martin Mares * * For more information, please consult the following manuals (look at - * http://www.pcisig.com/ for how to get them): + * https://www.pcisig.com/ for how to get them): * * PCI BIOS Specification * PCI Local Bus Specification @@ -14,7 +14,7 @@ * PCI System Design Guide * * For hypertransport information, please consult the following manuals - * from http://www.hypertransport.org + * from https://www.hypertransport.org * * The Hypertransport I/O Link Specification */ diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index 6f2587058edb4914768a88842741d534a64524df..f123b77aafaa1cb50ba6bceea88cfb4408e9cb6d 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -21,11 +21,11 @@ * Based on the original work by Paul McKenney * and inputs from Rusty Russell, Andrea Arcangeli and Andi Kleen. * Papers: - * http://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf - * http://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) + * https://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf + * https://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) * * For detailed explanation of Read-Copy Update mechanism see - - * http://lse.sourceforge.net/locking/rcupdate.html + * https://lse.sourceforge.net/locking/rcupdate.html */ #ifndef __XEN_RCUPDATE_H diff --git a/xen/include/xen/xxhash.h b/xen/include/xen/xxhash.h index 6f2237cbcf8ef1eb0910c264f2868aa62d1ebdd6..1005654af0a01ac03f2da3747e4146ce15d16943 100644 --- a/xen/include/xen/xxhash.h +++ b/xen/include/xen/xxhash.h @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index eb418baabb12724f01f74c8dc55ec694b4d2427d..8b6c2c7572cd9793bbb77192704db27e04cb3988 100644 --- a/xen/lib/rbtree.c +++ b/xen/lib/rbtree.c @@ -24,7 +24,7 @@ #include /* - * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree + * red-black trees properties: https://en.wikipedia.org/wiki/Rbtree * * 1) A node is either red or black * 2) The root is black diff --git a/xen/lib/xxhash32.c b/xen/lib/xxhash32.c index e8d403e5ced6588f0db7ea7064898919aa24671c..3bec28c91351cc9f26ae1121cc56a28230dc2135 100644 --- a/xen/lib/xxhash32.c +++ b/xen/lib/xxhash32.c @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/lib/xxhash64.c b/xen/lib/xxhash64.c index 481e76fbcf4c880ec395b1be314126a6d8c89347..6cb9ee28ec34f792c52cd5e71f3a15af145994dc 100644 --- a/xen/lib/xxhash64.c +++ b/xen/lib/xxhash64.c @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/tools/kconfig/gconf.c b/xen/tools/kconfig/gconf.c index e36b342f1065b750b4e0f9105a015c66bb38d94f..cc9675c6e1f262639394949da5ddcd3939bc9c85 100644 --- a/xen/tools/kconfig/gconf.c +++ b/xen/tools/kconfig/gconf.c @@ -690,7 +690,7 @@ void on_license1_activate(GtkMenuItem * menuitem, gpointer user_data) const gchar *license_text = "gkc is released under the terms of the GNU GPL v2.\n" "For more information, please see the source code or\n" - "visit http://www.fsf.org/licenses/licenses.html\n"; + "visit https://www.fsf.org/licenses/licenses.html\n"; dialog = gtk_message_dialog_new(GTK_WINDOW(main_wnd), GTK_DIALOG_DESTROY_WITH_PARENT, diff --git a/xen/tools/kconfig/merge_config.sh b/xen/tools/kconfig/merge_config.sh index 63c8565206a451c4c3e800148b209b0e98d47432..b7d75e61bf74b1c8eeddd0931acfcf2799674d6f 100755 --- a/xen/tools/kconfig/merge_config.sh +++ b/xen/tools/kconfig/merge_config.sh @@ -7,8 +7,8 @@ # dependencies or config symbol removal). # # Portions reused from kconf_check and generate_cfg: -# http://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-tools/tree/tools/kconf_check -# http://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-tools/tree/tools/generate_cfg +# https://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-tools/tree/tools/kconf_check +# https://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-tools/tree/tools/generate_cfg # # Copyright (c) 2009-2010 Wind River Systems, Inc. # Copyright 2011 Linaro diff --git a/xen/tools/kconfig/qconf.cc b/xen/tools/kconfig/qconf.cc index 82773cc35d356a82d20287e3982122d61dd92fbc..02ab0e50148bd6a583c197635f8e122146341be1 100644 --- a/xen/tools/kconfig/qconf.cc +++ b/xen/tools/kconfig/qconf.cc @@ -1785,7 +1785,7 @@ void ConfigMainWindow::showAbout(void) { static const QString str = "qconf is Copyright (C) 2002 Roman Zippel .\n" "Copyright (C) 2015 Boris Barbulovski .\n\n" - "Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n"; + "Bug reports and feature request can also be entered at https://bugzilla.kernel.org/\n"; QMessageBox::information(this, "qconf", str); } -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 04:51:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 04:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491522.760700 (Exim 4.92) (envelope-from ) id 1pPcQb-0005cK-57; Wed, 08 Feb 2023 04:51:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491522.760700; Wed, 08 Feb 2023 04:51:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQa-0005cD-Vt; Wed, 08 Feb 2023 04:51:28 +0000 Received: by outflank-mailman (input) for mailman id 491522; Wed, 08 Feb 2023 04:51:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQZ-0005Mg-8U for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 04:51:27 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b91cb60-a76c-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 05:51:22 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6EC315C004F; Tue, 7 Feb 2023 23:51:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 07 Feb 2023 23:51:21 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 23:51:20 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b91cb60-a76c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675831881; x=1675918281; bh=VQRXUb8COcLQL5wKNAvsTr8YrZBI8htigcg TgwfJaPQ=; b=Sri98Dat7bcGfKXp4cs97EGmpmzOJB4BMQGOK1mu0mxjoqhW2jE UWBwWrCxJmBVObbUOsUqntVwHuh3+P5+dA7e0/oCKLlg0Qad6G3ic8QaHsNQwWtc 5EPi1RJvd8E7t7LA6zb0N8qZR4L3KvVuQ+XMHm3Osr+kGUYYbdGxC7WJePvnMO3N AOpLHBsy8RaWl61sg5o16cY+6deVsVodevwy50e9ZSxgiqXQhxr9GJsPsUfgefD4 bRlHEgSZkfQSpymzeFatw/pwL9JxVENlvr2pq9e1XkBGF43oKKVkGDHltu4Y3ZCC H5iqojVutngihaqFXVpi98kR/kesZVKlVDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675831881; x=1675918281; bh=VQRXUb8COcLQL 5wKNAvsTr8YrZBI8htigcgTgwfJaPQ=; b=YPr9xWXqsizujYcwETmyZiRXcufxQ 6VmUOh07Pe7QjyYuHaYWCi929iODGhpTYv8K//RK9PG3yWHQ4xSHVsh8e+bZZyZm kD5b6546a1+1lMYg14vecn5KedXzk8irwqw8/E3kH3SM0cILZg19dhDPcgJkQhHA 0Dwc/yOCGqUrHGWsnnZu5hCC74y/rv10tyOPmyuwu21iUefvWCMAkO9jQZWZ7KIx Or0CUbyaKVHRRFpLSu+FNPuJR/JRmVrTqkDNiFbTDIh8wmyd6du9k4KSO4blNZwZ LWMhGRh7+BuktewwiHrtDatpPRK3rETG+Qq6sMSnHpisGUZLIE7cyP4XQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepkeevtdevgffhieevgffgjeetueej veegleeihfeileehudfggfetvdevueekudeknecuffhomhgrihhnpeigvghnrdhorhhgpd hslhhofihglhgrshhsrdgtohhmpdhinhhfrhgruggvrggurdhorhhgpdhsphhhihhngidq ughotgdrohhrghdpiihlihgsrdhnvghtpdhkvghrnhgvlhdrohhrghdprhgvughhrghtrd gtohhmpdhgnhhurdhorhhgpdhinhhrihgrrdhfrhdpghhmphhlihgsrdhorhhgpdhpohhl rghrshhslhdrohhrghdpsggvrhhlihhoshdruggvpdhsohhurhgtvgifrghrvgdrohhrgh dpihhpgigvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: [PATCH 1/4] Build system: Replace git:// and http:// with https:// Date: Tue, 7 Feb 2023 23:51:04 -0500 Message-Id: <74c5389cb5adbd62154735a28f6c31ae1865b254.1675829867.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Signed-off-by: Demi Marie Obenour --- Config.mk | 20 ++++++-------------- docs/README.remus | 2 +- docs/conf.py | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++++--------- stubdom/configure.ac | 24 +++++++++++++++--------- stubdom/grub.patches/10graphics.diff | 2 +- tools/examples/xeninfo.pl | 2 +- tools/firmware/etherboot/Makefile | 4 ++-- 9 files changed, 37 insertions(+), 39 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/git-http/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/docs/README.remus b/docs/README.remus index e41e045a109466213b39bf5099ee16652b229ccc..10929e06d049755c4e8a9c900af7e10048c3effb 100644 --- a/docs/README.remus +++ b/docs/README.remus @@ -7,7 +7,7 @@ Using Remus with libxl on Xen 4.5 and higher: To enable network buffering, you need libnl 3.2.8 or higher along with the development headers and command line utilities. If your distro does not have the appropriate libnl3 version, you can find - the latest source tarball of libnl3 at http://www.carisma.slowglass.com/~tgr/libnl/ + the latest source tarball of libnl3 at https://www.infradead.org/~tgr/libnl/ Disk replication: VMs protected by Remus need to use DRBD based disk backends. Specifically, you diff --git a/docs/conf.py b/docs/conf.py index 50e41501db8f95bd186818c49a8e6538d733012b..7f4adce29e57e4ab8be9a09fc105bb133c51dbb0 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -5,7 +5,7 @@ # # This file does only contain a selection of the most common options. For a # full list see the documentation: -# http://www.sphinx-doc.org/en/master/config +# https://www.sphinx-doc.org/en/master/config # -- Path setup -------------------------------------------------------------- diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..cf629cdf3c44e4abe67214378c49a3a9d858d9b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/git-http/xen.git\n"); $printed_novcs = 1; } return 0; diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..8b409d294d6ad5e363d6942078e66de95fa0503d 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : ZLIB_URL=\$\(XEN_EXTFILES_URL\) else - ZLIB_URL="http://www.zlib.net" + ZLIB_URL="https://www.zlib.net" fi fi @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://www.kernel.org/pub/software/utils/pciutils" fi fi @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sources.redhat.com/pub/newlib" fi fi @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3607,7 +3607,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://gmplib.org/download/gmp" fi fi @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" = "x"; then : if test "x$extfiles" = "xy"; then : POLARSSL_URL=\$\(XEN_EXTFILES_URL\) else - POLARSSL_URL="http://polarssl.org/code/releases" + POLARSSL_URL="https://polarssl.org/code/releases" fi fi @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" = "x"; then : if test "x$extfiles" = "xy"; then : TPMEMU_URL=\$\(XEN_EXTFILES_URL\) else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" + TPMEMU_URL="https://download.berlios.de/tpm-emulator" fi fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..e43853d45a5f652c05fe36f9171fba4c1b5863c0 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,19 +55,25 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://www.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gmp]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/code/releases]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://download.berlios.de/tpm-emulator]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) +if test "x$vtpm" != xn || test "x$vtpmmgr" != xn; then + if test "x$extfiles" != xy; then + AC_MSG_ERROR([Sources needed for the vTPM and vTPM manager stubdomains are no longer at their original URLs]) + fi +fi + #Conditionally enable these stubdoms based on the presense of dependencies AX_STUBDOM_CONDITIONAL_FINISH([vtpm-stubdom], [vtpm]) AX_STUBDOM_CONDITIONAL_FINISH([vtpmmgr-stubdom], [vtpmmgr]) diff --git a/stubdom/grub.patches/10graphics.diff b/stubdom/grub.patches/10graphics.diff index 5ee2852fd7d7595c7fe17acbb6096ae96f04aaf4..e80aab75bd31ac677ab2884718673094d97b3df2 100644 --- a/stubdom/grub.patches/10graphics.diff +++ b/stubdom/grub.patches/10graphics.diff @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c grub-0.97/stage2/graphics.c + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program; If not, see ++ * along with this program; If not, see + */ + +#ifdef SUPPORT_GRAPHICS diff --git a/tools/examples/xeninfo.pl b/tools/examples/xeninfo.pl index 95a15d9595c0f4bf09c9429099bd3b27e98ebf3e..1815d1d9f219799a83fbc0329a4a1a010264893e 100644 --- a/tools/examples/xeninfo.pl +++ b/tools/examples/xeninfo.pl @@ -36,7 +36,7 @@ sub apiconnect { foreach my $xenhost (keys %xenhosts) { - my $xen = RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}"); + my $xen = RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}"); my $session = $xen->simple_request("session.login_with_password", "user",""); if (! $session) { diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..b6d420786c3d0895e2118ce789ebdff585268f96 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -5,9 +5,9 @@ include $(XEN_ROOT)/tools/Rules.mk include Config ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git endif # put an updated tar.gz on xenbits after changes to this variable -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 04:51:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 04:51:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491523.760703 (Exim 4.92) (envelope-from ) id 1pPcQb-0005fQ-AR; Wed, 08 Feb 2023 04:51:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491523.760703; Wed, 08 Feb 2023 04:51:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQb-0005dU-73; Wed, 08 Feb 2023 04:51:29 +0000 Received: by outflank-mailman (input) for mailman id 491523; Wed, 08 Feb 2023 04:51:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQZ-0005Mi-EL for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 04:51:27 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d28f1e8-a76c-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 05:51:26 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 180585C0096; Tue, 7 Feb 2023 23:51:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 07 Feb 2023 23:51:24 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 23:51:23 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d28f1e8-a76c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675831884; x=1675918284; bh=YjlH9X1VyXgKgkGafsk0dvpHNT7Xq4V4f4f mb7TTmQY=; b=gKUzfZSMSCQtZOKag+iELqMmfZhsasxn73CsNjmkRH/iAn1Km8p Ts+Wm430rpzCnxzHsnTbkUUNRzQIEojLTrU7QCHQbSeACTs7/CvdbwFvRpRU9NJA D8NcUZLi/NeTf3wnEBInAilwUWMwGlPWHdCJhu6yThfks2/GMHnH3R2u3Y7D8AeY CAfOj/dyqv4nV+p9Scl0foniYDo7xc4uAcbaloR/AA5r6u9ivMx9gWKVptz57237 zqMS+Ib5PX961CR0xKvaOHm0kh5NhtXazpzIv8wDNB9XREYzBFxKakac9yG73cs2 g27/lbHnF70UosycHRZcoyP88aIoZbJOcSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675831884; x=1675918284; bh=YjlH9X1VyXgKg kGafsk0dvpHNT7Xq4V4f4fmb7TTmQY=; b=NMx4qk795RswMLjEiZLoBJkeUZfXp ahQC2we/9mUlVcWQrNl09IsgrAaefnPn7CGkLscbmDr7BGUPAEWr0U/lue2bSTx9 YIOD/AkSWia8G0klz+P1E0pXguZuuLJWAYiCEDsYmck0REJYzdtgmaF1b17ODx4q nZnl0nc955b314uQT0H37vMDTlQBtSkOqdcPH+etWhqVmKu4Lb5oURE9b0oEvJcL xXUoLy18/VV7g9nbxye5xQ8J4meMYynYcjoKSu1qcQVRIAUDQ1tCFUsYV6a4vudU 8CVew9fBB350c2pnyna+enY0eu9oCA7RnI08nPvANf3AqEWolagXxKAAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteduueehgeeujeegudeiffffveel teeljeevudeileffieetgfegffeitedvkeeunecuffhomhgrihhnpehphihthhhonhdroh hrghdpihhnthgvlhdrtghomhdptggvnhhtohhsrdhorhhgpdhllhhvmhdrohhrghdpuggv sghirghnrdhorhhgpdgrlhhpihhnvghlihhnuhigrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgv thhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: [PATCH 2/4] Automation and CI: Replace git:// and http:// with https:// Date: Tue, 7 Feb 2023 23:51:05 -0500 Message-Id: <4dcc09d2621f5ae319e9a01895287bacbc4d6c86.1675829867.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. Signed-off-by: Demi Marie Obenour --- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo index 4da27faeb5fa863fd4e140cbeaad308b9a543b86..8e37da1a03f839c486eb9bd0af46716cfb9086e0 100644 --- a/automation/build/centos/CentOS-7.2.repo +++ b/automation/build/centos/CentOS-7.2.repo @@ -6,28 +6,28 @@ [base] name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #released updates [updates] name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/updates/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that may be useful [extras] name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/extras/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that extend functionality of existing packages [centosplus] name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/centosplus/$basearch/ gpgcheck=1 gpgcheck=1 enabled=0 diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list index dc119fa0b4df1bd6e742c42776710abcd6deaa86..1db1598997429d7a14d3fcd8f0f8152aa6d40b8a 100644 --- a/automation/build/debian/unstable-llvm-8.list +++ b/automation/build/debian/unstable-llvm-8.list @@ -1,3 +1,3 @@ # Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb https://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb-src https://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..6163eeeda623527d0620fb20a23b589b1168a896 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 04:51:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 04:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491525.760732 (Exim 4.92) (envelope-from ) id 1pPcQm-0006WF-6q; Wed, 08 Feb 2023 04:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491525.760732; Wed, 08 Feb 2023 04:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQm-0006W0-2i; Wed, 08 Feb 2023 04:51:40 +0000 Received: by outflank-mailman (input) for mailman id 491525; Wed, 08 Feb 2023 04:51:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPcQj-0005Mg-Tv for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 04:51:38 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42710f65-a76c-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 05:51:33 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EBE585C016C; Tue, 7 Feb 2023 23:51:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 07 Feb 2023 23:51:32 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 23:51:30 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42710f65-a76c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675831892; x=1675918292; bh=dyK2mpttNlzVjpmXjCcZV/GbQ/bzks8cjQn Q60uAr7g=; b=hfE/uk4jHwleDnLOPFF3C2Iq3Txxwi41B1e8Iw0UR63dzPkzVTp KttBft+UGbsfd8cZUf0FwWV8iOzE2EK6oeMAmVCpilSQ83InLqzj/Mmjy3BVlREp uBTXdpwzhPp12Yr+X0GmIzegME13zQtinklOgKtfzerBjfYPqmcuP1tdnSdFhiM5 6kAxWW/DAJHloUkd29hxuTtj3LSFsb2hyQNVJtAPa3N1mdTx54q0IBvxmmboz7QF ah2QlCgukkzWC9ktad34AbNAB1d14BTNN25DDoNhmrKxu6rpVb28MWj6Y/qkBvEF nLIOUXGWPFtkfIDbTLWdOP9FepWGFfHkeGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675831892; x=1675918292; bh=dyK2mpttNlzVj pmXjCcZV/GbQ/bzks8cjQnQ60uAr7g=; b=CLPh1dzHDxcvxZUVYPulJkMyuIs02 XRDQJX6qkdvIjj5SscepqvVbvUZz+F37Et58Ced05/K17iRXHLckm97DS99lEkvo ta5mXh46h6nocc2gqkq9H7xO9T1QGZCtPycSbRuK8krWvARm9X3/7l2VNSM62hzq 5ZyzoTCTaE0pLmGlRu0Xo1VvQHl9mrFGmlZEoa713JczgvUQC5+WKg4m/W/tlwui 5s9aWbN9/M/ZSNjk3rYGpQu7LtimhpzbbZ97tijV8Yi74Ca74i/rqqpY1dMIEsRg iDPwKQTJY1OvhfIKXcTt7GyWi4BCF80jPKVNI85Xxic2jYdwTRAgl5Vmg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdvvddvfeevffekveetjedtffdt veelkeffleehgedukeeuveegjeefffevgfehnecuffhomhgrihhnpehgnhhurdhorhhgpd dutddrudekvddruddvtddrjeekpdgrphhmsghiohhsrdhssgdptghmuhdrvgguuhdpfiho rhhlughonhhlihhnvgdrughkpdhsghhirdgtohhmnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhn ghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Date: Tue, 7 Feb 2023 23:51:07 -0500 Message-Id: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch changes GPL boilerplate. Signed-off-by: Demi Marie Obenour --- This patch is absolutely massive. Thankfully, it was autogenerated. m4/pkg.m4 | 2 +- m4/systemd.m4 | 2 +- stubdom/grub.patches/10graphics.diff | 2 +- stubdom/grub.patches/61btrfs.diff | 4 ++-- stubdom/vtpmmgr/tpmrsa.c | 2 +- stubdom/vtpmmgr/tpmrsa.h | 2 +- tools/configure | 4 ++-- tools/console/client/main.c | 2 +- tools/console/daemon/io.c | 2 +- tools/console/daemon/io.h | 2 +- tools/console/daemon/main.c | 2 +- tools/console/daemon/utils.c | 2 +- tools/console/daemon/utils.h | 2 +- tools/debugger/gdbsx/README | 2 +- tools/debugger/gdbsx/gx/gx.h | 2 +- tools/debugger/gdbsx/gx/gx_comm.c | 4 ++-- tools/debugger/gdbsx/gx/gx_local.c | 2 +- tools/debugger/gdbsx/gx/gx_main.c | 2 +- tools/debugger/gdbsx/gx/gx_utils.c | 2 +- tools/debugger/gdbsx/gx/xg_dummy.c | 2 +- tools/debugger/gdbsx/xg/xg_main.c | 2 +- tools/debugger/gdbsx/xg/xg_public.h | 2 +- tools/firmware/hvmloader/32bitbios_support.c | 2 +- tools/firmware/hvmloader/Makefile | 2 +- tools/firmware/hvmloader/cacheattr.c | 2 +- tools/firmware/hvmloader/e820.c | 2 +- tools/firmware/hvmloader/hvmloader.c | 2 +- tools/firmware/hvmloader/mp_tables.c | 2 +- tools/firmware/hvmloader/optionroms.c | 2 +- tools/firmware/hvmloader/ovmf.c | 2 +- tools/firmware/hvmloader/pci.c | 2 +- tools/firmware/hvmloader/pir_types.h | 2 +- tools/firmware/hvmloader/rombios.c | 2 +- tools/firmware/hvmloader/seabios.c | 2 +- tools/firmware/hvmloader/smbios.c | 2 +- tools/firmware/hvmloader/smbios_types.h | 2 +- tools/firmware/hvmloader/smp.c | 2 +- tools/firmware/hvmloader/tests.c | 2 +- tools/firmware/hvmloader/util.c | 2 +- tools/firmware/rombios/32bit/32bitbios.c | 2 +- tools/firmware/rombios/32bit/mkhex | 2 +- tools/firmware/rombios/32bit/pmm.c | 2 +- tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c | 2 +- tools/firmware/rombios/32bit/util.c | 2 +- tools/firmware/rombios/32bitgateway.c | 2 +- tools/firmware/rombios/apmbios.S | 2 +- tools/firmware/rombios/rombios.c | 2 +- tools/firmware/rombios/rombios.h | 2 +- tools/firmware/rombios/tcgbios.c | 2 +- tools/firmware/vgabios/COPYING | 2 +- tools/firmware/vgabios/biossums.c | 2 +- tools/firmware/vgabios/clext.c | 2 +- tools/firmware/vgabios/vbe.c | 2 +- tools/firmware/vgabios/vgabios.c | 4 ++-- tools/golang/xenlight/xenlight.go | 2 +- tools/hotplug/Linux/block-common.sh | 2 +- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/hotplug/Linux/external-device-migrate | 2 +- tools/hotplug/Linux/launch-xenstore.in | 2 +- tools/hotplug/Linux/locking.sh | 2 +- tools/hotplug/Linux/logging.sh | 2 +- tools/hotplug/Linux/vif-common.sh | 2 +- tools/hotplug/Linux/xen-hotplug-common.sh.in | 2 +- tools/hotplug/Linux/xen-network-common.sh | 2 +- tools/hotplug/Linux/xen-script-common.sh | 2 +- tools/hotplug/NetBSD/locking.sh | 2 +- tools/include/libxenvchan.h | 2 +- tools/include/xencall.h | 2 +- tools/include/xenctrl.h | 2 +- tools/include/xendevicemodel.h | 2 +- tools/include/xenevtchn.h | 2 +- tools/include/xenforeignmemory.h | 2 +- tools/include/xengnttab.h | 2 +- tools/include/xenguest.h | 2 +- tools/include/xenhypfs.h | 2 +- tools/include/xenstore.h | 2 +- tools/include/xenstore_lib.h | 2 +- tools/include/xentoolcore.h | 2 +- tools/include/xentoolcore_internal.h | 2 +- tools/include/xentoollog.h | 2 +- tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 +- tools/libfsimage/fat/fat.h | 2 +- tools/libfsimage/fat/fsys_fat.c | 2 +- tools/libfsimage/iso9660/fsys_iso9660.c | 2 +- tools/libfsimage/iso9660/iso9660.h | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 +- tools/libfsimage/ufs/fsys_ufs.c | 2 +- tools/libfsimage/xfs/fsys_xfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 4 ++-- tools/libfsimage/zfs/Makefile | 2 +- tools/libfsimage/zfs/filesys.h | 2 +- tools/libfsimage/zfs/fsi_zfs.c | 2 +- tools/libfsimage/zfs/fsi_zfs.h | 2 +- tools/libfsimage/zfs/fsys_zfs.c | 2 +- tools/libfsimage/zfs/fsys_zfs.h | 2 +- tools/libfsimage/zfs/mb_info.h | 2 +- tools/libfsimage/zfs/shared.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu_objset.h | 2 +- tools/libfsimage/zfs/zfs-include/dnode.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dataset.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dir.h | 2 +- tools/libfsimage/zfs/zfs-include/sa_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/spa.h | 2 +- tools/libfsimage/zfs/zfs-include/uberblock_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/vdev_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_leaf.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_acl.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_znode.h | 2 +- tools/libfsimage/zfs/zfs-include/zil.h | 2 +- tools/libfsimage/zfs/zfs-include/zio.h | 2 +- tools/libfsimage/zfs/zfs-include/zio_checksum.h | 2 +- tools/libfsimage/zfs/zfs_fletcher.c | 2 +- tools/libfsimage/zfs/zfs_lzjb.c | 2 +- tools/libfsimage/zfs/zfs_sha256.c | 2 +- tools/libs/call/buffer.c | 2 +- tools/libs/call/core.c | 2 +- tools/libs/call/freebsd.c | 2 +- tools/libs/call/linux.c | 2 +- tools/libs/call/minios.c | 2 +- tools/libs/call/netbsd.c | 2 +- tools/libs/call/solaris.c | 2 +- tools/libs/ctrl/xc_altp2m.c | 2 +- tools/libs/ctrl/xc_cpu_hotplug.c | 2 +- tools/libs/ctrl/xc_cpupool.c | 2 +- tools/libs/ctrl/xc_csched.c | 2 +- tools/libs/ctrl/xc_csched2.c | 2 +- tools/libs/ctrl/xc_domain.c | 2 +- tools/libs/ctrl/xc_evtchn.c | 2 +- tools/libs/ctrl/xc_flask.c | 2 +- tools/libs/ctrl/xc_foreign_memory.c | 2 +- tools/libs/ctrl/xc_freebsd.c | 2 +- tools/libs/ctrl/xc_gnttab.c | 2 +- tools/libs/ctrl/xc_hcall_buf.c | 2 +- tools/libs/ctrl/xc_linux.c | 2 +- tools/libs/ctrl/xc_mem_access.c | 2 +- tools/libs/ctrl/xc_mem_paging.c | 2 +- tools/libs/ctrl/xc_memshr.c | 2 +- tools/libs/ctrl/xc_minios.c | 2 +- tools/libs/ctrl/xc_misc.c | 2 +- tools/libs/ctrl/xc_monitor.c | 2 +- tools/libs/ctrl/xc_netbsd.c | 2 +- tools/libs/ctrl/xc_pagetab.c | 2 +- tools/libs/ctrl/xc_physdev.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/ctrl/xc_rt.c | 2 +- tools/libs/ctrl/xc_solaris.c | 2 +- tools/libs/ctrl/xc_tbuf.c | 2 +- tools/libs/ctrl/xc_vm_event.c | 2 +- tools/libs/ctrl/xc_vmtrace.c | 2 +- tools/libs/devicemodel/common.c | 2 +- tools/libs/devicemodel/compat.c | 2 +- tools/libs/devicemodel/core.c | 2 +- tools/libs/evtchn/core.c | 2 +- tools/libs/evtchn/freebsd.c | 2 +- tools/libs/evtchn/linux.c | 2 +- tools/libs/evtchn/minios.c | 2 +- tools/libs/evtchn/netbsd.c | 2 +- tools/libs/evtchn/solaris.c | 2 +- tools/libs/foreignmemory/compat.c | 2 +- tools/libs/foreignmemory/core.c | 2 +- tools/libs/foreignmemory/freebsd.c | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/foreignmemory/minios.c | 2 +- tools/libs/foreignmemory/netbsd.c | 2 +- tools/libs/foreignmemory/solaris.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/gntshr_core.c | 2 +- tools/libs/gnttab/gntshr_unimp.c | 2 +- tools/libs/gnttab/gnttab_core.c | 2 +- tools/libs/gnttab/gnttab_unimp.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/gnttab/minios.c | 2 +- tools/libs/gnttab/netbsd.c | 2 +- tools/libs/guest/xg_core.c | 2 +- tools/libs/guest/xg_core.h | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_core_arm.h | 2 +- tools/libs/guest/xg_core_x86.c | 2 +- tools/libs/guest/xg_core_x86.h | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_armzimageloader.c | 2 +- tools/libs/guest/xg_dom_binloader.c | 2 +- tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_compat_linux.c | 2 +- tools/libs/guest/xg_dom_core.c | 2 +- tools/libs/guest/xg_dom_elfloader.c | 2 +- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_domain.c | 2 +- tools/libs/guest/xg_nomigrate.c | 2 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_private.c | 2 +- tools/libs/guest/xg_private.h | 2 +- tools/libs/guest/xg_resume.c | 2 +- tools/libs/guest/xg_save_restore.h | 2 +- tools/libs/guest/xg_suspend.c | 2 +- tools/libs/hypfs/core.c | 2 +- tools/libs/stat/COPYING | 2 +- tools/libs/store/xs.c | 2 +- tools/libs/toolcore/handlereg.c | 2 +- tools/libs/toollog/xtl_core.c | 2 +- tools/libs/toollog/xtl_logger_stdio.c | 2 +- tools/libs/util/libxlu_cfg_y.c | 2 +- tools/libs/util/libxlu_cfg_y.h | 2 +- tools/libs/vchan/init.c | 2 +- tools/libs/vchan/io.c | 2 +- tools/libs/vchan/vchan.h | 2 +- tools/misc/mkhex | 2 +- tools/misc/xen-mceinj.c | 2 +- tools/misc/xen-vmtrace.c | 2 +- tools/misc/xencov.c | 2 +- tools/misc/xenpm.c | 2 +- tools/misc/xenpvnetboot | 6 +++--- tools/ocaml/LICENSE | 2 +- tools/pygrub/src/ExtLinuxConf.py | 2 +- tools/pygrub/src/GrubConf.py | 2 +- tools/pygrub/src/pygrub | 2 +- tools/python/xen/lowlevel/xs/xs.c | 2 +- tools/tests/depriv/depriv-fd-checker.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/vhpet/main.c | 2 +- tools/tests/vpci/emul.h | 2 +- tools/tests/vpci/main.c | 2 +- tools/tests/x86_emulator/blowfish.c | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/vchan/node-select.c | 2 +- tools/vchan/node.c | 2 +- tools/vchan/vchan-socket-proxy.c | 2 +- tools/xenmon/COPYING | 2 +- tools/xenmon/setmask.c | 2 +- tools/xenmon/xenbaked.c | 2 +- tools/xenmon/xenbaked.h | 2 +- tools/xenmon/xenmon.py | 2 +- tools/xenpaging/file_ops.c | 2 +- tools/xenpaging/file_ops.h | 2 +- tools/xenpaging/policy.h | 2 +- tools/xenpaging/policy_default.c | 2 +- tools/xenpaging/xenpaging.c | 2 +- tools/xenpaging/xenpaging.h | 2 +- tools/xenpmd/xenpmd.c | 2 +- tools/xenstore/COPYING | 2 +- tools/xenstore/include/xenstore_state.h | 2 +- tools/xenstore/talloc.c | 2 +- tools/xenstore/talloc.h | 2 +- tools/xenstore/tdb.c | 2 +- tools/xenstore/tdb.h | 2 +- tools/xenstore/xenstored_control.c | 2 +- tools/xenstore/xenstored_control.h | 2 +- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 2 +- tools/xenstore/xenstored_domain.h | 2 +- tools/xenstore/xenstored_minios.c | 2 +- tools/xenstore/xenstored_posix.c | 2 +- tools/xenstore/xenstored_transaction.c | 2 +- tools/xenstore/xenstored_transaction.h | 2 +- tools/xenstore/xenstored_watch.c | 2 +- tools/xenstore/xenstored_watch.h | 2 +- tools/xenstore/xs_lib.c | 2 +- tools/xenstore/xs_lib.h | 2 +- tools/xentop/xentop.c | 2 +- tools/xentrace/xenalyze.c | 2 +- xen/COPYING | 2 +- xen/arch/arm/acpi/boot.c | 2 +- xen/arch/arm/acpi/lib.c | 2 +- xen/arch/arm/arm32/insn.c | 2 +- xen/arch/arm/arm32/lib/bitops.c | 2 +- xen/arch/arm/arm32/lib/lib1funcs.S | 2 +- xen/arch/arm/arm32/lib/lshrdi3.S | 2 +- xen/arch/arm/arm64/bpi.S | 2 +- xen/arch/arm/arm64/cache.S | 2 +- xen/arch/arm/arm64/debug-meson.inc | 2 +- xen/arch/arm/arm64/debug-mvebu.inc | 2 +- xen/arch/arm/arm64/insn.c | 2 +- xen/arch/arm/arm64/lib/bitops.c | 2 +- xen/arch/arm/arm64/lib/clear_page.S | 2 +- xen/arch/arm/arm64/lib/memchr.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 2 +- xen/arch/arm/arm64/lib/memcpy.S | 2 +- xen/arch/arm/arm64/lib/memmove.S | 2 +- xen/arch/arm/arm64/lib/memset.S | 2 +- xen/arch/arm/arm64/lib/strchr.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 2 +- xen/arch/arm/arm64/lib/strlen.S | 2 +- xen/arch/arm/arm64/lib/strncmp.S | 2 +- xen/arch/arm/arm64/lib/strnlen.S | 2 +- xen/arch/arm/arm64/lib/strrchr.S | 2 +- xen/arch/arm/efi/efi-dom0.c | 2 +- xen/arch/arm/include/asm/acpi.h | 2 +- xen/arch/arm/include/asm/altp2m.h | 2 +- xen/arch/arm/include/asm/arm32/insn.h | 2 +- xen/arch/arm/include/asm/arm64/atomic.h | 2 +- xen/arch/arm/include/asm/arm64/insn.h | 2 +- xen/arch/arm/include/asm/arm64/io.h | 2 +- xen/arch/arm/include/asm/gic_v3_its.h | 2 +- xen/arch/arm/include/asm/iommu.h | 2 +- xen/arch/arm/include/asm/iommu_fwspec.h | 2 +- xen/arch/arm/include/asm/ioreq.h | 2 +- xen/arch/arm/include/asm/mem_access.h | 2 +- xen/arch/arm/include/asm/monitor.h | 2 +- xen/arch/arm/include/asm/new_vgic.h | 2 +- xen/arch/arm/include/asm/pci.h | 2 +- xen/arch/arm/include/asm/vm_event.h | 2 +- xen/arch/arm/include/asm/vpl011.h | 2 +- xen/arch/arm/include/asm/vpsci.h | 2 +- xen/arch/arm/pci/ecam.c | 2 +- xen/arch/arm/pci/pci-access.c | 2 +- xen/arch/arm/pci/pci-host-common.c | 2 +- xen/arch/arm/pci/pci-host-generic.c | 2 +- xen/arch/arm/pci/pci-host-zynqmp.c | 2 +- xen/arch/arm/pci/pci.c | 2 +- xen/arch/arm/platforms/thunderx.c | 2 +- xen/arch/arm/vgic/vgic-init.c | 2 +- xen/arch/arm/vgic/vgic-mmio.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/arm/vgic/vgic.h | 2 +- xen/arch/x86/acpi/boot.c | 2 +- xen/arch/x86/acpi/cpu_idle.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/acpi/cpuidle_menu.c | 2 +- xen/arch/x86/acpi/lib.c | 2 +- xen/arch/x86/alternative.c | 2 +- xen/arch/x86/boot/build32.lds | 2 +- xen/arch/x86/boot/cmdline.c | 2 +- xen/arch/x86/boot/defs.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 2 +- xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 10 +++++----- xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- xen/arch/x86/cpu/mtrr/main.c | 2 +- xen/arch/x86/cpu/mwait-idle.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/cpu/vpmu_amd.c | 2 +- xen/arch/x86/cpu/vpmu_intel.c | 2 +- xen/arch/x86/gdbstub.c | 2 +- xen/arch/x86/gdbsx.c | 2 +- xen/arch/x86/genapic/x2apic.c | 2 +- xen/arch/x86/guest/hyperv/hyperv.c | 2 +- xen/arch/x86/guest/hyperv/private.h | 2 +- xen/arch/x86/guest/hyperv/tlb.c | 2 +- xen/arch/x86/guest/hyperv/util.c | 2 +- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/hvm/asid.c | 2 +- xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/hvm/domain.c | 2 +- xen/arch/x86/hvm/grant_table.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/hypercall.c | 2 +- xen/arch/x86/hvm/intercept.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 2 +- xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/monitor.c | 2 +- xen/arch/x86/hvm/mtrr.c | 2 +- xen/arch/x86/hvm/nestedhvm.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 2 +- xen/arch/x86/hvm/quirks.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/hvm/svm/asid.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/entry.S | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svmdebug.c | 2 +- xen/arch/x86/hvm/svm/vmcb.c | 2 +- xen/arch/x86/hvm/vioapic.c | 2 +- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vm_event.c | 2 +- xen/arch/x86/hvm/vmsi.c | 2 +- xen/arch/x86/hvm/vmx/entry.S | 2 +- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 2 +- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/hypercall.c | 2 +- xen/arch/x86/include/asm/acpi.h | 2 +- xen/arch/x86/include/asm/altp2m.h | 2 +- xen/arch/x86/include/asm/endbr.h | 2 +- xen/arch/x86/include/asm/guest.h | 2 +- xen/arch/x86/include/asm/guest/hyperv-hcall.h | 2 +- xen/arch/x86/include/asm/guest/hyperv.h | 2 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 2 +- xen/arch/x86/include/asm/guest/xen-hcall.h | 2 +- xen/arch/x86/include/asm/guest/xen.h | 2 +- xen/arch/x86/include/asm/guest_pt.h | 2 +- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/hvm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/grant_table.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 2 +- xen/arch/x86/include/asm/hvm/io.h | 2 +- xen/arch/x86/include/asm/hvm/ioreq.h | 2 +- xen/arch/x86/include/asm/hvm/irq.h | 2 +- xen/arch/x86/include/asm/hvm/monitor.h | 2 +- xen/arch/x86/include/asm/hvm/nestedhvm.h | 2 +- xen/arch/x86/include/asm/hvm/save.h | 2 +- xen/arch/x86/include/asm/hvm/support.h | 2 +- xen/arch/x86/include/asm/hvm/svm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/svm/emulate.h | 2 +- xen/arch/x86/include/asm/hvm/svm/intr.h | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- xen/arch/x86/include/asm/hvm/vcpu.h | 2 +- xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- xen/arch/x86/include/asm/hvm/vlapic.h | 2 +- xen/arch/x86/include/asm/hvm/vm_event.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 2 +- xen/arch/x86/include/asm/hvm/vpt.h | 2 +- xen/arch/x86/include/asm/iommu.h | 2 +- xen/arch/x86/include/asm/ioreq.h | 2 +- xen/arch/x86/include/asm/mem_access.h | 2 +- xen/arch/x86/include/asm/mem_paging.h | 2 +- xen/arch/x86/include/asm/mem_sharing.h | 2 +- xen/arch/x86/include/asm/monitor.h | 2 +- xen/arch/x86/include/asm/p2m.h | 2 +- xen/arch/x86/include/asm/paging.h | 2 +- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/include/asm/pv/grant_table.h | 2 +- xen/arch/x86/include/asm/pv/mm.h | 2 +- xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/include/asm/pv/traps.h | 2 +- xen/arch/x86/include/asm/shadow.h | 2 +- xen/arch/x86/include/asm/shstk.h | 2 +- xen/arch/x86/include/asm/spec_ctrl.h | 2 +- xen/arch/x86/include/asm/spec_ctrl_asm.h | 2 +- xen/arch/x86/include/asm/traps.h | 2 +- xen/arch/x86/include/asm/vm_event.h | 2 +- xen/arch/x86/include/asm/vpmu.h | 2 +- xen/arch/x86/include/asm/xenoprof.h | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/altp2m.c | 2 +- xen/arch/x86/mm/guest_walk.c | 2 +- xen/arch/x86/mm/hap/guest_walk.c | 2 +- xen/arch/x86/mm/hap/hap.c | 2 +- xen/arch/x86/mm/hap/nested_ept.c | 2 +- xen/arch/x86/mm/hap/nested_hap.c | 2 +- xen/arch/x86/mm/hap/private.h | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/mem_paging.c | 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/nested.c | 2 +- xen/arch/x86/mm/p2m-basic.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/arch/x86/mm/p2m-pod.c | 2 +- xen/arch/x86/mm/p2m-pt.c | 2 +- xen/arch/x86/mm/p2m.c | 2 +- xen/arch/x86/mm/p2m.h | 2 +- xen/arch/x86/mm/paging.c | 2 +- xen/arch/x86/mm/physmap.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/mm/shadow/multi.h | 2 +- xen/arch/x86/mm/shadow/private.h | 2 +- xen/arch/x86/mm/shadow/pv.c | 2 +- xen/arch/x86/mm/shadow/set.c | 2 +- xen/arch/x86/mm/shadow/types.h | 2 +- xen/arch/x86/monitor.c | 2 +- xen/arch/x86/msr.c | 2 +- xen/arch/x86/pv/callback.c | 2 +- xen/arch/x86/pv/descriptor-tables.c | 2 +- xen/arch/x86/pv/emul-gate-op.c | 2 +- xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/grant_table.c | 2 +- xen/arch/x86/pv/hypercall.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/misc-hypercalls.c | 2 +- xen/arch/x86/pv/mm.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/pv/shim.c | 2 +- xen/arch/x86/pv/traps.c | 2 +- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/spec_ctrl.c | 2 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/vm_event.c | 2 +- xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- xen/arch/x86/x86_64/cpu_idle.c | 2 +- xen/arch/x86/x86_64/cpufreq.c | 2 +- xen/arch/x86/x86_64/gdbstub.c | 2 +- xen/arch/x86/x86_64/mm.c | 2 +- xen/arch/x86/x86_64/mmconfig.h | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- xen/common/argo.c | 2 +- xen/common/bunzip2.c | 2 +- xen/common/coverage/coverage.c | 2 +- xen/common/dm.c | 2 +- xen/common/event_channel.c | 2 +- xen/common/gdbstub.c | 2 +- xen/common/grant_table.c | 2 +- xen/common/ioreq.c | 2 +- xen/common/libelf/libelf-dominfo.c | 2 +- xen/common/libelf/libelf-loader.c | 2 +- xen/common/libelf/libelf-private.h | 2 +- xen/common/libelf/libelf-tools.c | 2 +- xen/common/mem_access.c | 2 +- xen/common/monitor.c | 2 +- xen/common/page_alloc.c | 2 +- xen/common/pdx.c | 2 +- xen/common/preempt.c | 2 +- xen/common/radix-tree.c | 2 +- xen/common/rcupdate.c | 2 +- xen/common/sched/null.c | 2 +- xen/common/stop_machine.c | 2 +- xen/common/time.c | 2 +- xen/common/unlzma.c | 2 +- xen/common/unlzo.c | 2 +- xen/common/vm_event.c | 2 +- xen/common/wait.c | 2 +- xen/drivers/acpi/apei/apei-base.c | 2 +- xen/drivers/acpi/apei/apei-io.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/drivers/acpi/apei/hest.c | 2 +- xen/drivers/acpi/numa.c | 2 +- xen/drivers/acpi/osl.c | 2 +- xen/drivers/acpi/pmstat.c | 2 +- xen/drivers/acpi/tables.c | 2 +- xen/drivers/char/consoled.c | 2 +- xen/drivers/char/meson-uart.c | 2 +- xen/drivers/char/mvebu-uart.c | 2 +- xen/drivers/char/xen_pv_console.c | 2 +- xen/drivers/char/xhci-dbc.c | 2 +- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/drivers/passthrough/amd/iommu-defs.h | 2 +- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/drivers/passthrough/amd/iommu_cmd.c | 2 +- xen/drivers/passthrough/amd/iommu_detect.c | 2 +- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_init.c | 2 +- xen/drivers/passthrough/amd/iommu_intr.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/arm/iommu_fwspec.c | 2 +- xen/drivers/passthrough/arm/iommu_helpers.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/ats.c | 2 +- xen/drivers/passthrough/ats.h | 2 +- xen/drivers/passthrough/iommu.c | 2 +- xen/drivers/passthrough/pci.c | 6 +++--- xen/drivers/passthrough/vtd/dmar.c | 2 +- xen/drivers/passthrough/vtd/dmar.h | 2 +- xen/drivers/passthrough/vtd/extern.h | 2 +- xen/drivers/passthrough/vtd/intremap.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/drivers/passthrough/vtd/qinval.c | 2 +- xen/drivers/passthrough/vtd/quirks.c | 2 +- xen/drivers/passthrough/vtd/utils.c | 2 +- xen/drivers/passthrough/vtd/vtd.h | 2 +- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- xen/drivers/passthrough/vtd/x86/hvm.c | 2 +- xen/drivers/passthrough/vtd/x86/vtd.c | 2 +- xen/drivers/passthrough/x86/hvm.c | 2 +- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 2 +- xen/drivers/vpci/vpci.c | 2 +- xen/include/xen/acpi.h | 2 +- xen/include/xen/argo.h | 2 +- xen/include/xen/atomic.h | 2 +- xen/include/xen/compiler.h | 2 +- xen/include/xen/cper.h | 2 +- xen/include/xen/cpuidle.h | 2 +- xen/include/xen/dm.h | 2 +- xen/include/xen/elfstructs.h | 2 +- xen/include/xen/gdbstub.h | 2 +- xen/include/xen/grant_table.h | 2 +- xen/include/xen/inttypes.h | 2 +- xen/include/xen/iommu.h | 2 +- xen/include/xen/ioreq.h | 2 +- xen/include/xen/mem_access.h | 2 +- xen/include/xen/monitor.h | 2 +- xen/include/xen/multiboot.h | 2 +- xen/include/xen/radix-tree.h | 2 +- xen/include/xen/rbtree.h | 2 +- xen/include/xen/rcupdate.h | 2 +- xen/include/xen/vm_event.h | 2 +- xen/lib/list-sort.c | 2 +- xen/lib/rbtree.c | 2 +- xen/xsm/silo.c | 2 +- 609 files changed, 622 insertions(+), 622 deletions(-) diff --git a/m4/pkg.m4 b/m4/pkg.m4 index bb59b15417268411e83f9ae6ba8fbe01faf2e38f..398cafe97b20c7a0ee74586b2ca247bc58e08570 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -14,7 +14,7 @@ # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # As a special exception to the GNU General Public License, if you # distribute this file as part of a program that contains a diff --git a/m4/systemd.m4 b/m4/systemd.m4 index 112dc11b5e05e11d730e33a133c08527cfb4990f..a0a1b856aaa59fc4b97a9a90c88029953b878a2b 100644 --- a/m4/systemd.m4 +++ b/m4/systemd.m4 @@ -13,7 +13,7 @@ # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . dnl Some optional path options AC_DEFUN([AX_SYSTEMD_OPTIONS], [ diff --git a/stubdom/grub.patches/10graphics.diff b/stubdom/grub.patches/10graphics.diff index e80aab75bd31ac677ab2884718673094d97b3df2..5c1067ba9c31ada35086d8f2f4da989bfdfc7046 100644 --- a/stubdom/grub.patches/10graphics.diff +++ b/stubdom/grub.patches/10graphics.diff @@ -1769,7 +1769,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.h grub-0.97/stage2/graphics.h + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program; If not, see ++ * along with this program; If not, see + */ + +#ifndef GRAPHICS_H diff --git a/stubdom/grub.patches/61btrfs.diff b/stubdom/grub.patches/61btrfs.diff index ae8f866e509ef23ac3cb607651e56de193ef6c55..a96062e685e4f6a1922132e9ba6ee30abfd3c8aa 100644 --- a/stubdom/grub.patches/61btrfs.diff +++ b/stubdom/grub.patches/61btrfs.diff @@ -70,7 +70,7 @@ diff -up /dev/null grub-upstream.wip/stage2/btrfs.h + * General Public License for more details. + * + * You should have received a copy of the GNU General Public -+ * License along with this program; If not, see ++ * License along with this program; If not, see + */ + +/* include/asm-i386/types.h */ @@ -1561,7 +1561,7 @@ diff -up /dev/null grub-upstream.wip/stage2/fsys_btrfs.c + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program. If not, see . ++ * along with this program. If not, see . + */ + +#ifdef FSYS_BTRFS diff --git a/stubdom/vtpmmgr/tpmrsa.c b/stubdom/vtpmmgr/tpmrsa.c index 7731640f6899dfde21106b0a34575b70ca25699d..5a9f6b29e5831a9fbd7f920c1c5edbc0d9ad60d5 100644 --- a/stubdom/vtpmmgr/tpmrsa.c +++ b/stubdom/vtpmmgr/tpmrsa.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ /* * RSA was designed by Ron Rivest, Adi Shamir and Len Adleman. diff --git a/stubdom/vtpmmgr/tpmrsa.h b/stubdom/vtpmmgr/tpmrsa.h index efeb5f2a21e4ac43b3cda417c0c8cea62052087c..45e1f72e4b816bb9c4c3c6b4055c522192c69ec8 100644 --- a/stubdom/vtpmmgr/tpmrsa.h +++ b/stubdom/vtpmmgr/tpmrsa.h @@ -21,7 +21,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ #ifndef TPMRSA_H #define TPMRSA_H diff --git a/tools/configure b/tools/configure index f6f13bfdc0901b0cea125c5ac13208c92e7b7a0f..50d1abfe2b5579651fb1ef43db87ec8ceb109547 100755 --- a/tools/configure +++ b/tools/configure @@ -3647,7 +3647,7 @@ esac # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # As a special exception to the GNU General Public License, if you # distribute this file as part of a program that contains a @@ -3868,7 +3868,7 @@ esac # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . diff --git a/tools/console/client/main.c b/tools/console/client/main.c index 1a6fa162f750692e4affa33abecae1fd22031d4f..f694af558544d294a82c60c50739341d94038ae7 100644 --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c index 682c1f4008e0c984987e2e712c84175c923888b9..54b28dd29c69f6887171fd1e70b2dcbde41bb252 100644 --- a/tools/console/daemon/io.c +++ b/tools/console/daemon/io.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/console/daemon/io.h b/tools/console/daemon/io.h index d016addac896c6d6930495af2e9e4f19bc09abf5..8486cfaaed19604e21e1b36ed4e8a2cb55a316ff 100644 --- a/tools/console/daemon/io.h +++ b/tools/console/daemon/io.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #ifndef CONSOLED_IO_H diff --git a/tools/console/daemon/main.c b/tools/console/daemon/main.c index aac7233a48c93e8542f8f8637445be592080fb3f..75643b8023fe6552ead2b5be15bc3c6c3ad12322 100644 --- a/tools/console/daemon/main.c +++ b/tools/console/daemon/main.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/utils.c b/tools/console/daemon/utils.c index f9dd8a60c5c497c3dc2c9c5779b38bca547dd5a9..d609fb05198d98f55312a25f11ffd84b55c3b33e 100644 --- a/tools/console/daemon/utils.c +++ b/tools/console/daemon/utils.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/utils.h b/tools/console/daemon/utils.h index a010ac44e0fa2c99be586fccdac66261c9a67992..e828fb7eef71753c4cefab220653bd463e155444 100644 --- a/tools/console/daemon/utils.h +++ b/tools/console/daemon/utils.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #ifndef CONSOLED_UTILS_H diff --git a/tools/debugger/gdbsx/README b/tools/debugger/gdbsx/README index c875c0172a84e9d649ed1502259704e422f8759c..d6b557bc0357e2fe6c9625906c6248bb3c8091ef 100644 --- a/tools/debugger/gdbsx/README +++ b/tools/debugger/gdbsx/README @@ -67,7 +67,7 @@ mukesh[dot]rathor[at]oracle[dot]com USEFUL gdb macros: -# Courtesy Zhigang W (http://10.182.120.78/tech/vt/ovm/debug/gdbinit.macros): +# Courtesy Zhigang W (https://10.182.120.78/tech/vt/ovm/debug/gdbinit.macros): define ps dont-repeat diff --git a/tools/debugger/gdbsx/gx/gx.h b/tools/debugger/gdbsx/gx/gx.h index af3957587aab02396b393dff6428eb2204c46b1f..d3f7ef913a3b422428e210c61a10bf84c373fee4 100644 --- a/tools/debugger/gdbsx/gx/gx.h +++ b/tools/debugger/gdbsx/gx/gx.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ typedef uint16_t domid_t; diff --git a/tools/debugger/gdbsx/gx/gx_comm.c b/tools/debugger/gdbsx/gx/gx_comm.c index 5a0c61df4bd4d984aff33f5cda661ed075911b22..2a4967a78273580fecb7e114fb268744e088a770 100644 --- a/tools/debugger/gdbsx/gx/gx_comm.c +++ b/tools/debugger/gdbsx/gx/gx_comm.c @@ -15,7 +15,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . */ + along with this program; If not, see . */ /* * Copyright (C) 2009, Mukesh Rathor, Oracle Corp. All rights reserved. * @@ -29,7 +29,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This module handles communication with remote gdb. courtesy diff --git a/tools/debugger/gdbsx/gx/gx_local.c b/tools/debugger/gdbsx/gx/gx_local.c index 023f5a391f43aa253411fde90e1559c23b869ac2..6af2d442fbae0382a5ec515607c95e4d46f81b74 100644 --- a/tools/debugger/gdbsx/gx/gx_local.c +++ b/tools/debugger/gdbsx/gx/gx_local.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ diff --git a/tools/debugger/gdbsx/gx/gx_main.c b/tools/debugger/gdbsx/gx/gx_main.c index 15de2c350135e76e965efe9b54c5224087c4266d..d9e556affa468f72fbe4eaebc4815db7881550a5 100644 --- a/tools/debugger/gdbsx/gx/gx_main.c +++ b/tools/debugger/gdbsx/gx/gx_main.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This module is the main module for gdbsx implementation. gdbsx is a remote diff --git a/tools/debugger/gdbsx/gx/gx_utils.c b/tools/debugger/gdbsx/gx/gx_utils.c index f3c003960c4e407834468f2760bb4279a5121a92..428e2c24ad15af9468055df3fab6ad5c65d6df5c 100644 --- a/tools/debugger/gdbsx/gx/gx_utils.c +++ b/tools/debugger/gdbsx/gx/gx_utils.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/tools/debugger/gdbsx/gx/xg_dummy.c b/tools/debugger/gdbsx/gx/xg_dummy.c index e995fad7d5d30ddf24034db70ec9ff603d50e2ae..b75bdfb724e5c4c6f9b8766f7cdc70a1912a6359 100644 --- a/tools/debugger/gdbsx/gx/xg_dummy.c +++ b/tools/debugger/gdbsx/gx/xg_dummy.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include #include diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c index 4576c762af0c29521e75db5ba3355d89250a0047..2dfaec7df065002d128c24c2df1c81b3aa5212fc 100644 --- a/tools/debugger/gdbsx/xg/xg_main.c +++ b/tools/debugger/gdbsx/xg/xg_main.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This is the main module to interface with xen. This module exports APIs that diff --git a/tools/debugger/gdbsx/xg/xg_public.h b/tools/debugger/gdbsx/xg/xg_public.h index 31513c817796897d22af915fbdb9a7d7d1587421..95fc6e11c2900c4182df658b068b250d043c8da6 100644 --- a/tools/debugger/gdbsx/xg/xg_public.h +++ b/tools/debugger/gdbsx/xg/xg_public.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define XGERR(...) \ diff --git a/tools/firmware/hvmloader/32bitbios_support.c b/tools/firmware/hvmloader/32bitbios_support.c index cee3804888c447df7e952960312ad07023a07acc..7b76fb4fdb4ed685dfaf2b614d497c227f433d62 100644 --- a/tools/firmware/hvmloader/32bitbios_support.c +++ b/tools/firmware/hvmloader/32bitbios_support.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile index 4f31c881613ca5a5b44aa6afbe860daa1b3ee7a0..3d745c30d2c2074578afb4d99d91fd2e2f19dcdc 100644 --- a/tools/firmware/hvmloader/Makefile +++ b/tools/firmware/hvmloader/Makefile @@ -14,7 +14,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # XEN_ROOT = $(CURDIR)/../../.. diff --git a/tools/firmware/hvmloader/cacheattr.c b/tools/firmware/hvmloader/cacheattr.c index b7215fba2e0200228e063e2f7e16e79b6f916a52..3abf460eacd4859174156a1a9d40c3e5d168150a 100644 --- a/tools/firmware/hvmloader/cacheattr.c +++ b/tools/firmware/hvmloader/cacheattr.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c index c490a0bc790c1e70912411f9b1cdf09e661dada2..427cde142b7f0ac74513392d5e966166ac6b0927 100644 --- a/tools/firmware/hvmloader/e820.c +++ b/tools/firmware/hvmloader/e820.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/hvmloader.c b/tools/firmware/hvmloader/hvmloader.c index c58841e5b55624c6f50b2a2756b81e914295c3ea..417dec5cad20bcd2c6bfe83a50f68757f18b3070 100644 --- a/tools/firmware/hvmloader/hvmloader.c +++ b/tools/firmware/hvmloader/hvmloader.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/mp_tables.c b/tools/firmware/hvmloader/mp_tables.c index d207ecbf00c9297c491fea8952a4a2f7215ccb9b..6acdd1be488557b0354d495833d18e95b9aa8a1f 100644 --- a/tools/firmware/hvmloader/mp_tables.c +++ b/tools/firmware/hvmloader/mp_tables.c @@ -24,7 +24,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/firmware/hvmloader/optionroms.c b/tools/firmware/hvmloader/optionroms.c index 97080583cca7aba7269cc7e68feec4e5beab8990..2d57890724ac7394d3535d10199d0f60d6a2487e 100644 --- a/tools/firmware/hvmloader/optionroms.c +++ b/tools/firmware/hvmloader/optionroms.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c index 23610a071797f143bb712e03df5e492d0e91a7a6..def5b9e41ea43c3de834117aaf361175ac476366 100644 --- a/tools/firmware/hvmloader/ovmf.c +++ b/tools/firmware/hvmloader/ovmf.c @@ -18,7 +18,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c index 257a6feb6148c4d0cd3fa608cf4cc902251ee000..944afeb3b8b0ddb7998d04517921371884a57557 100644 --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h index 5129b0c7fd9a087810a299ee8930f755814a263b..01e1bfbcf4d088269fd5dde97dbc729d5a0c7f1b 100644 --- a/tools/firmware/hvmloader/pir_types.h +++ b/tools/firmware/hvmloader/pir_types.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) Citrix Systems, 2011 * diff --git a/tools/firmware/hvmloader/rombios.c b/tools/firmware/hvmloader/rombios.c index 46f331e465966d241f2a0e970ef3ab46adf24b31..6f9f2a59b5713dc6d86376d8ff3a449a145c04aa 100644 --- a/tools/firmware/hvmloader/rombios.c +++ b/tools/firmware/hvmloader/rombios.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/seabios.c b/tools/firmware/hvmloader/seabios.c index 444d118ddb01451aac393ee1cb6fb23dcb1ba72d..33062f6f331292658444649875211318270b7607 100644 --- a/tools/firmware/hvmloader/seabios.c +++ b/tools/firmware/hvmloader/seabios.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/smbios.c b/tools/firmware/hvmloader/smbios.c index 97a054e9e3fe9918aee64c036662334679e74a71..5547edfd127b8ce4d80ca1700d02e738f3c70d66 100644 --- a/tools/firmware/hvmloader/smbios.c +++ b/tools/firmware/hvmloader/smbios.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h index 3f1c120da60b6aa95cb2b6b1f03cc31d912832a4..c75cfee7028779b709d407f2b1e44d2e4b574e64 100644 --- a/tools/firmware/hvmloader/smbios_types.h +++ b/tools/firmware/hvmloader/smbios_types.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/hvmloader/smp.c b/tools/firmware/hvmloader/smp.c index 082b17f138186c48e936f621d154955bf1dfe652..0f464517ab62ce80333a39c04e802501cc237d4c 100644 --- a/tools/firmware/hvmloader/smp.c +++ b/tools/firmware/hvmloader/smp.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/tests.c b/tools/firmware/hvmloader/tests.c index a70c72dffbbb3922faae6cc2832fc8195018c0da..948cd360d71591d96571481599d7f0b0d7d7d78e 100644 --- a/tools/firmware/hvmloader/tests.c +++ b/tools/firmware/hvmloader/tests.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 581b35e5cfb5ad1be1aa09e8536cfc3bd70c82ee..611a0603c7e3ed6278e0479eb0a9e0db90ec56f7 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/rombios/32bit/32bitbios.c b/tools/firmware/rombios/32bit/32bitbios.c index 87acf209c3fdb6185910cd5e29e4b1538c59548f..39b141a23b3ad241b38b11fde33d14c89a766674 100644 --- a/tools/firmware/rombios/32bit/32bitbios.c +++ b/tools/firmware/rombios/32bit/32bitbios.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/mkhex b/tools/firmware/rombios/32bit/mkhex index 7200d007e460021d1b25b6d3b29a34c08b82eb69..cfdd011c37d3e808a5a17b1d662b775acc22f7d4 100644 --- a/tools/firmware/rombios/32bit/mkhex +++ b/tools/firmware/rombios/32bit/mkhex @@ -16,7 +16,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # echo "unsigned $1[] = {" diff --git a/tools/firmware/rombios/32bit/pmm.c b/tools/firmware/rombios/32bit/pmm.c index e0e39fef68a7b8d1695738e5e6f3c045c6dceaa4..49e603fd0297760b6efae70444ea975bc832a66a 100644 --- a/tools/firmware/rombios/32bit/pmm.c +++ b/tools/firmware/rombios/32bit/pmm.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) 2009 FUJITSU LIMITED * diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c index fa22c4460aac6f45aa67ceb991033c93b25a84fa..8da795ed4b642eec2d1e02953023fdec1625551f 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c index 59d16bbae6b422cd77d9faf719b4faad075d4ece..8897df75b21d364da9da58a498cc61d8e58295c8 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c +++ b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/util.c b/tools/firmware/rombios/32bit/util.c index 6c1c4805144bf520abe6545f70bb0720a709102b..e5f9acbadf19bf65d073a6aee0e32560d9d5b016 100644 --- a/tools/firmware/rombios/32bit/util.c +++ b/tools/firmware/rombios/32bit/util.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include #include diff --git a/tools/firmware/rombios/32bitgateway.c b/tools/firmware/rombios/32bitgateway.c index 3d58a6b0a1cdd8b6b8a24bb7da1ea1d236597345..9f28ea3b5d27e7dc585039f0355dcc1a17469835 100644 --- a/tools/firmware/rombios/32bitgateway.c +++ b/tools/firmware/rombios/32bitgateway.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * Copyright (c) 2008, Citrix Systems, Inc. diff --git a/tools/firmware/rombios/apmbios.S b/tools/firmware/rombios/apmbios.S index 814be8fd57eba8998a177c3ebd757de557c92599..9dd6b3390eab5a679771de429f893362b20c4b75 100644 --- a/tools/firmware/rombios/apmbios.S +++ b/tools/firmware/rombios/apmbios.S @@ -15,7 +15,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . #if defined(APM_REAL) #define APMSYM(s) apmreal_ ## s diff --git a/tools/firmware/rombios/rombios.c b/tools/firmware/rombios/rombios.c index 1818d2fa4d32b3c89299076b3968827bea749402..a4c1566e75501855b5d4b9838c969c2e083877f4 100644 --- a/tools/firmware/rombios/rombios.c +++ b/tools/firmware/rombios/rombios.c @@ -21,7 +21,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // ROM BIOS for use with Bochs/Plex86/QEMU emulation environment diff --git a/tools/firmware/rombios/rombios.h b/tools/firmware/rombios/rombios.h index 8726d37737b4f980311a2695156b34c42af16fa2..a3849de73d096d570dbd160eec0a484bf30ff57f 100644 --- a/tools/firmware/rombios/rombios.h +++ b/tools/firmware/rombios/rombios.h @@ -15,7 +15,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . /* define it to include QEMU specific code */ //#define BX_QEMU diff --git a/tools/firmware/rombios/tcgbios.c b/tools/firmware/rombios/tcgbios.c index e725ef9d1bdc3b995044e2a27bbfbc399dbd8e5c..8f5ab34bce24199d6922d11a4d3a6f6484833773 100644 --- a/tools/firmware/rombios/tcgbios.c +++ b/tools/firmware/rombios/tcgbios.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/vgabios/COPYING b/tools/firmware/vgabios/COPYING index 05956269987638868d4aea655e8fd4c9d5b6ecd5..8b44515327c654405640f624ea7de292302a431c 100644 --- a/tools/firmware/vgabios/COPYING +++ b/tools/firmware/vgabios/COPYING @@ -484,7 +484,7 @@ convey the exclusion of warranty; and each file should have at least the Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/firmware/vgabios/biossums.c b/tools/firmware/vgabios/biossums.c index 85ecc04e1665c6c3902a95f4687859513cc6e358..144467ae327e403a547fa8174db0fd760ddf6b15 100644 --- a/tools/firmware/vgabios/biossums.c +++ b/tools/firmware/vgabios/biossums.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include #include diff --git a/tools/firmware/vgabios/clext.c b/tools/firmware/vgabios/clext.c index d727cd59f270d6658c1bc0dee82eff40ceff0074..c6b1fcbad1505a27fb8e1c131c1c7994e24fa7be 100644 --- a/tools/firmware/vgabios/clext.c +++ b/tools/firmware/vgabios/clext.c @@ -14,7 +14,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // //#define CIRRUS_VESA3_PMINFO diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c index 8e6408733ae68bdc582054ee58778c03f180b220..2bda60d1aefe1c4922b07efa975b3d0932dc0426 100644 --- a/tools/firmware/vgabios/vbe.c +++ b/tools/firmware/vgabios/vbe.c @@ -13,7 +13,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // // ============================================================================================ // diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c index 3ad98ca254a4ce8e7359a8a2d1a259b098ab927b..d5d21c3fce1da5acb645822cb9546c95164fd40a 100644 --- a/tools/firmware/vgabios/vgabios.c +++ b/tools/firmware/vgabios/vgabios.c @@ -17,7 +17,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // // ============================================================================================ // @@ -37,7 +37,7 @@ // This VGA Bios is based on information taken from : // - Kevin Lawton's vga card emulation for bochs/plex86 // - Ralf Brown's interrupts list available at https://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html -// - Finn Thogersons' VGADOC4b available at http://home.worldonline.dk/~finth/ +// - Finn Thogersons' VGADOC4b available at https://home.worldonline.dk/~finth/ // - Michael Abrash's Graphics Programming Black Book // - Francois Gervais' book "programmation des cartes graphiques cga-ega-vga" edited by sybex // - DOSEMU 1.0.1 source code for several tables values and formulas diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index a45c636952520823f3c13a314e476cdbf4e1629f..a456518e8339446e40edf971c0231a90ae0f5fe2 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ // Package xenlight provides bindings to Xen's libxl C library. diff --git a/tools/hotplug/Linux/block-common.sh b/tools/hotplug/Linux/block-common.sh index f86a88c4ebce21036a3e029223099ef9501fad21..de57b642546f95251d8e3ebbebd63279aa025a91 100644 --- a/tools/hotplug/Linux/block-common.sh +++ b/tools/hotplug/Linux/block-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/block-drbd-probe b/tools/hotplug/Linux/block-drbd-probe index 7b2968b6d944ea7222b79b1acda8c5f0dab8ab23..fca46fb32c5fb94bf07fe3b8363e2bdea3f6ccf8 100755 --- a/tools/hotplug/Linux/block-drbd-probe +++ b/tools/hotplug/Linux/block-drbd-probe @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # Usage: # block-drbd-probe devicename diff --git a/tools/hotplug/Linux/external-device-migrate b/tools/hotplug/Linux/external-device-migrate index f5942a6a954fc1ac9f21974f0e2a70a4d8dd3dbd..68eaac145bec13de5ce038e882d62ce14fa79fbb 100644 --- a/tools/hotplug/Linux/external-device-migrate +++ b/tools/hotplug/Linux/external-device-migrate @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # set -x diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in index e854ca1eb8957f616122a6d96b88bb891142318d..5028d1d09f4da30d458f354687488da002c94905 100644 --- a/tools/hotplug/Linux/launch-xenstore.in +++ b/tools/hotplug/Linux/launch-xenstore.in @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # XENSTORED=@XENSTORED@ diff --git a/tools/hotplug/Linux/locking.sh b/tools/hotplug/Linux/locking.sh index 2e6fb35f02785c7a2c5a164df417f47659f829bd..13fb7134c6b6a20f7de2be4394406377abdb8167 100644 --- a/tools/hotplug/Linux/locking.sh +++ b/tools/hotplug/Linux/locking.sh @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # diff --git a/tools/hotplug/Linux/logging.sh b/tools/hotplug/Linux/logging.sh index 3e94df1a9e900d1b2b368568e2400063882f74eb..b7ed7b292dd54f4ff085eb2fe9cdf346c9ec1c33 100644 --- a/tools/hotplug/Linux/logging.sh +++ b/tools/hotplug/Linux/logging.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # log() { diff --git a/tools/hotplug/Linux/vif-common.sh b/tools/hotplug/Linux/vif-common.sh index a8e65178f9074390eb6a1bdf5b1f741fffac66ad..43ea7bbf775fb4688ef9849ca5805facaaa7cd47 100644 --- a/tools/hotplug/Linux/vif-common.sh +++ b/tools/hotplug/Linux/vif-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/xen-hotplug-common.sh.in b/tools/hotplug/Linux/xen-hotplug-common.sh.in index 8c2cb9e25a1a401cf4dc366e2cdcb45eb59cf95a..9e5207fee85f39248b8cd12ec52c8dddb2a7e922 100644 --- a/tools/hotplug/Linux/xen-hotplug-common.sh.in +++ b/tools/hotplug/Linux/xen-hotplug-common.sh.in @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # dir=$(dirname "$0") diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 42fa704e8d40f683ed3a7d3562b7c9685b7f804c..89542b2b9ac0bc8b0089bf05d9e3251c3c0ba6ef 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/xen-script-common.sh b/tools/hotplug/Linux/xen-script-common.sh index 370a50a3cd9849e9348be5934b12d21d3f7b05d0..a8d36414df691e6d729b3011aea598c5fa03d110 100644 --- a/tools/hotplug/Linux/xen-script-common.sh +++ b/tools/hotplug/Linux/xen-script-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/NetBSD/locking.sh b/tools/hotplug/NetBSD/locking.sh index 2098d0e3ab6ed60c9b52acf2d36f67dde8550e0b..4a63fb2e1c77dc98bdb8cafc40dca7cd8c1f4c50 100644 --- a/tools/hotplug/NetBSD/locking.sh +++ b/tools/hotplug/NetBSD/locking.sh @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index ad771866e44321f6c880733a3df8e9315c2b348e..049e334426855661c3487d7fbfc3eec64b2655c5 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/include/xencall.h b/tools/include/xencall.h index fc95ed0fe58eea7fb7830458fe6207bce610d63a..e577b927b8e6e4091dd9e6bf35d57952ea96f410 100644 --- a/tools/include/xencall.h +++ b/tools/include/xencall.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENCALL_H #define XENCALL_H diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 23037874d3d5a01ddf55766088bf782393a9c483..fc0c72ae0265e610047b9a8fd950973e34198e2f 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENCTRL_H diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h index 797e0c6b2961926a68cd96b8ff5e1627067903ac..58dbb1bdda2fb8a9ee237ed20e0ecf1c09abe42e 100644 --- a/tools/include/xendevicemodel.h +++ b/tools/include/xendevicemodel.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENDEVICEMODEL_H #define XENDEVICEMODEL_H diff --git a/tools/include/xenevtchn.h b/tools/include/xenevtchn.h index 1255c85178d2d5049aa2406c5be1b7932bec728d..51fbc42eb0598f95015a6754636ce70e9d20aba8 100644 --- a/tools/include/xenevtchn.h +++ b/tools/include/xenevtchn.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from: * xenctrl.h diff --git a/tools/include/xenforeignmemory.h b/tools/include/xenforeignmemory.h index 0ab1dd19d3b56db4a9dccd784d54919d390b47a9..eb897603862d519dcd40ecff6c9e8be8d1810222 100644 --- a/tools/include/xenforeignmemory.h +++ b/tools/include/xenforeignmemory.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENFOREIGNMEMORY_H #define XENFOREIGNMEMORY_H diff --git a/tools/include/xengnttab.h b/tools/include/xengnttab.h index 111fc88caeb3ef1186f6a3d0051688ceed14dc5c..188c7a9fdb8bdc4f1bad6b6ed7656f1921a0142d 100644 --- a/tools/include/xengnttab.h +++ b/tools/include/xengnttab.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from: * xenctrl.h diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index e01f494b772a4800fbd8d9d7ced8b45a811e8219..f8e248c5a2e30486a78e1207dd36b96159ce211e 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENGUEST_H diff --git a/tools/include/xenhypfs.h b/tools/include/xenhypfs.h index 25432d2a1657d8a59b04ffdefca6d7ee1734cf55..7818198ee184c9c8c8fa2e5a50272cc4bb360b64 100644 --- a/tools/include/xenhypfs.h +++ b/tools/include/xenhypfs.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENHYPFS_H #define XENHYPFS_H diff --git a/tools/include/xenstore.h b/tools/include/xenstore.h index 2b3f69fb61d3434f00dbc7870739258c81882d2a..c72e66e513720ebee2b11bcf901c3f9ba7af1416 100644 --- a/tools/include/xenstore.h +++ b/tools/include/xenstore.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XENSTORE_H diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h index 2266009ec12410b07b8109b185c6c5d40b3b8771..7fd536234a937ff87d147abe34a0d67c905faa1f 100644 --- a/tools/include/xenstore_lib.h +++ b/tools/include/xenstore_lib.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XENSTORE_LIB_H diff --git a/tools/include/xentoolcore.h b/tools/include/xentoolcore.h index b3a3c934e28314a9f0d2856376916a0d5eb8c00e..3ff9dd6dbbcbdd9a3c3f5067aec1ccfd1e7921a6 100644 --- a/tools/include/xentoolcore.h +++ b/tools/include/xentoolcore.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLCORE_H diff --git a/tools/include/xentoolcore_internal.h b/tools/include/xentoolcore_internal.h index 1be014434d32f399de1ba3bcc9fcbb7f61c08749..be67c5fb7f41232cb1644751b4b9b9dc3b99039c 100644 --- a/tools/include/xentoolcore_internal.h +++ b/tools/include/xentoolcore_internal.h @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLCORE_INTERNAL_H diff --git a/tools/include/xentoollog.h b/tools/include/xentoollog.h index 76f17fe125d103af9ba587cb56fb147a23b5e615..817db123dd3136409f7a190fcdca56896b0342ec 100644 --- a/tools/include/xentoollog.h +++ b/tools/include/xentoollog.h @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLLOG_H diff --git a/tools/libfsimage/ext2fs/fsys_ext2fs.c b/tools/libfsimage/ext2fs/fsys_ext2fs.c index 5ed8fce90ef1dd663862f085865c7050a0eb9524..019bbffb475098158bb9798894e6a416b96a10a6 100644 --- a/tools/libfsimage/ext2fs/fsys_ext2fs.c +++ b/tools/libfsimage/ext2fs/fsys_ext2fs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/fat/fat.h b/tools/libfsimage/fat/fat.h index 2abb43084f47fa83e628ea01e237efd4d797bdd6..e9f535ce8827ef61851cfbfebd8e4242692d7146 100644 --- a/tools/libfsimage/fat/fat.h +++ b/tools/libfsimage/fat/fat.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/libfsimage/fat/fsys_fat.c b/tools/libfsimage/fat/fsys_fat.c index b89354a8721b280045a91a7b15151c1fe0380438..f540c6413339da4f1c23f95d4e856a4952937a46 100644 --- a/tools/libfsimage/fat/fsys_fat.c +++ b/tools/libfsimage/fat/fsys_fat.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/iso9660/fsys_iso9660.c b/tools/libfsimage/iso9660/fsys_iso9660.c index 6e767357bfdc2e35d7aa788977280218e1937aa5..15cde87307e842af4a1fa09e314dd3b38473bfa4 100644 --- a/tools/libfsimage/iso9660/fsys_iso9660.c +++ b/tools/libfsimage/iso9660/fsys_iso9660.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * References: diff --git a/tools/libfsimage/iso9660/iso9660.h b/tools/libfsimage/iso9660/iso9660.h index 4ea9b3eed36a416c0faaaceb12f345da318cd7b7..6ac443e6dcc91f86b33c5420a2d32591f7d1b58f 100644 --- a/tools/libfsimage/iso9660/iso9660.h +++ b/tools/libfsimage/iso9660/iso9660.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * References: diff --git a/tools/libfsimage/reiserfs/fsys_reiserfs.c b/tools/libfsimage/reiserfs/fsys_reiserfs.c index 299b257e999426547199753508fcf76f1d440ed7..a83b69a059e1fec3b73c171fef66690310303c56 100644 --- a/tools/libfsimage/reiserfs/fsys_reiserfs.c +++ b/tools/libfsimage/reiserfs/fsys_reiserfs.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/ufs/fsys_ufs.c b/tools/libfsimage/ufs/fsys_ufs.c index a545bc9f65e82748c931f6f30a1c8c9abf0a712d..3f6ff873078656f914e2a0ccb9398f55365fcd81 100644 --- a/tools/libfsimage/ufs/fsys_ufs.c +++ b/tools/libfsimage/ufs/fsys_ufs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2006 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/xfs/fsys_xfs.c b/tools/libfsimage/xfs/fsys_xfs.c index d735a88e55f3ac30b11ba7e5fe6a8a07b97bce0c..a8d8f249ad2cb1bbf53ab2fdb5bdbf5779ca433b 100644 --- a/tools/libfsimage/xfs/fsys_xfs.c +++ b/tools/libfsimage/xfs/fsys_xfs.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/xfs/xfs.h b/tools/libfsimage/xfs/xfs.h index e9f93531d82aa12264ef3b4c8bbc8f56d9c7d58f..00b76f31a55c3b7449618620976da70d3f1c2bb2 100644 --- a/tools/libfsimage/xfs/xfs.h +++ b/tools/libfsimage/xfs/xfs.h @@ -20,12 +20,12 @@ * other software, or any other product whatsoever. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, * Mountain View, CA 94043, or: * - * https://www.sgi.com + * https://www.sgi.com * * For further information regarding this notice, see: * diff --git a/tools/libfsimage/zfs/Makefile b/tools/libfsimage/zfs/Makefile index 434a9c3580e6ab029f0b54779decfd8107a08f10..b8cbca7f1a9da28b79cc0f855b23389f8364ad1e 100644 --- a/tools/libfsimage/zfs/Makefile +++ b/tools/libfsimage/zfs/Makefile @@ -13,7 +13,7 @@ # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # diff --git a/tools/libfsimage/zfs/filesys.h b/tools/libfsimage/zfs/filesys.h index 36cc720709f7b238e1aa746afeabf6b961cda1c0..c1f64eb282034965cb329bf6a1b6a92adfd7bd00 100644 --- a/tools/libfsimage/zfs/filesys.h +++ b/tools/libfsimage/zfs/filesys.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsi_zfs.c b/tools/libfsimage/zfs/fsi_zfs.c index 187a8bc6b2d9502cd20a6306f98d75c9e8f9a939..bd24a5e7c84afcb8f2d993a7ca4e65717c1d4a8c 100644 --- a/tools/libfsimage/zfs/fsi_zfs.c +++ b/tools/libfsimage/zfs/fsi_zfs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsi_zfs.h b/tools/libfsimage/zfs/fsi_zfs.h index 980ce8f30478f0707146cac2d2ba4b1e160d4c5d..e3b4a8116e386c16f504cd7fb87344461a549cbf 100644 --- a/tools/libfsimage/zfs/fsi_zfs.h +++ b/tools/libfsimage/zfs/fsi_zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsys_zfs.c b/tools/libfsimage/zfs/fsys_zfs.c index e881fbb09ba9311e1e3001f148244e5416d61e16..941068b1339242b6b8a6e8f5710495bce3a46b84 100644 --- a/tools/libfsimage/zfs/fsys_zfs.c +++ b/tools/libfsimage/zfs/fsys_zfs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsys_zfs.h b/tools/libfsimage/zfs/fsys_zfs.h index b4be51b50d1f3411f43f14ccc956bb80e21a920e..14595dffa998da725e39fa24e9ab0fb49e05cfbf 100644 --- a/tools/libfsimage/zfs/fsys_zfs.h +++ b/tools/libfsimage/zfs/fsys_zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/mb_info.h b/tools/libfsimage/zfs/mb_info.h index 16e9013f58b3f28b3c2cd3a211f0eb6c265d1451..2c68dbea43d9259152cf20b69fe628d8217dfabe 100644 --- a/tools/libfsimage/zfs/mb_info.h +++ b/tools/libfsimage/zfs/mb_info.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/tools/libfsimage/zfs/shared.h b/tools/libfsimage/zfs/shared.h index e4a239abe19c130ea2e48c6a8d7fb16079fd4dd7..55ffefce2020a00d2e74c859ad7bdb874904173d 100644 --- a/tools/libfsimage/zfs/shared.h +++ b/tools/libfsimage/zfs/shared.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dmu.h b/tools/libfsimage/zfs/zfs-include/dmu.h index b39a951cf7c9725b9198bbd2876fd31080f90ee3..d37b02f04eadc6316dcd2dc5fca4c7d9f92d2e0e 100644 --- a/tools/libfsimage/zfs/zfs-include/dmu.h +++ b/tools/libfsimage/zfs/zfs-include/dmu.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dmu_objset.h b/tools/libfsimage/zfs/zfs-include/dmu_objset.h index 2680fcf1bd8082e2e6f78997b35dcb4b6c35ef48..8a9c6ae3bf85f29055b1a8bddeb9ed68958d0e0f 100644 --- a/tools/libfsimage/zfs/zfs-include/dmu_objset.h +++ b/tools/libfsimage/zfs/zfs-include/dmu_objset.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dnode.h b/tools/libfsimage/zfs/zfs-include/dnode.h index dd90a8779c70074dfcce14e61ad94e069f42eb35..49bfb54fc3feae4f7e02be6e94b3dc5f2396d135 100644 --- a/tools/libfsimage/zfs/zfs-include/dnode.h +++ b/tools/libfsimage/zfs/zfs-include/dnode.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h index 470b60758840438cc8f655ece37311f1793f23bf..8ac92c60bcdbe1494568370d5d38475013899fc9 100644 --- a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h +++ b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dir.h b/tools/libfsimage/zfs/zfs-include/dsl_dir.h index 0e71b6b4808ed847560b2b62e0bbe3c865ebe521..e25bc139f3d94ed993c64992889a264eeb824a69 100644 --- a/tools/libfsimage/zfs/zfs-include/dsl_dir.h +++ b/tools/libfsimage/zfs/zfs-include/dsl_dir.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/sa_impl.h b/tools/libfsimage/zfs/zfs-include/sa_impl.h index 0679c93f2999d951adafa477be6e72975884995b..a9af9024194cda52d7a75c98faface583a5c847e 100644 --- a/tools/libfsimage/zfs/zfs-include/sa_impl.h +++ b/tools/libfsimage/zfs/zfs-include/sa_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/spa.h b/tools/libfsimage/zfs/zfs-include/spa.h index ee708ef60bdc355e9d895967e00b277c3a897bf5..ba35ab740a4a8086830335fdcf920a3c910da11b 100644 --- a/tools/libfsimage/zfs/zfs-include/spa.h +++ b/tools/libfsimage/zfs/zfs-include/spa.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h index 282d3b92827c70e4982530608b0ce0a028cf1ca2..2f879666cbd7e3c4b8fb0bf55cca91b8cea71bc0 100644 --- a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h +++ b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/vdev_impl.h b/tools/libfsimage/zfs/zfs-include/vdev_impl.h index f3823b298d134379483b8c8e196c9fe196617e93..fe69c31fb9e51d0c64b3dea25276510adc768c92 100644 --- a/tools/libfsimage/zfs/zfs-include/vdev_impl.h +++ b/tools/libfsimage/zfs/zfs-include/vdev_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zap_impl.h b/tools/libfsimage/zfs/zfs-include/zap_impl.h index 7adfc347c3a15dc89d97510827468a02fb2643da..44fedf9f665722da05c6b6adc54da251f7f989cc 100644 --- a/tools/libfsimage/zfs/zfs-include/zap_impl.h +++ b/tools/libfsimage/zfs/zfs-include/zap_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zap_leaf.h b/tools/libfsimage/zfs/zfs-include/zap_leaf.h index ecf3faacb6407856e247521012242aff0e8fb2ee..9517d055f2d5b107faf081b80642604a1bb3853c 100644 --- a/tools/libfsimage/zfs/zfs-include/zap_leaf.h +++ b/tools/libfsimage/zfs/zfs-include/zap_leaf.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs.h b/tools/libfsimage/zfs/zfs-include/zfs.h index 592d23a768d1ded2d521a1135f791888bef3ae5f..0f0e2552051ed291797febd690f6782599ae467d 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs.h +++ b/tools/libfsimage/zfs/zfs-include/zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs_acl.h b/tools/libfsimage/zfs/zfs-include/zfs_acl.h index 6a685e0536711617abe5ba770fc9b89666ea109c..e0f458b68a9d4b0ce9914b78f806956eb5831bf4 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs_acl.h +++ b/tools/libfsimage/zfs/zfs-include/zfs_acl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs_znode.h b/tools/libfsimage/zfs/zfs-include/zfs_znode.h index 902c4972caf61fab31de2d7ec08beefcc5f509ef..a46f7d765422a7f1abcb4f638601717a6255f5ed 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs_znode.h +++ b/tools/libfsimage/zfs/zfs-include/zfs_znode.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zil.h b/tools/libfsimage/zfs/zfs-include/zil.h index f34173c36b1859d20958f1a8d6913163b0dbb666..ec70d71ad3d42db0d7bf91c37a9f03b027b2f10f 100644 --- a/tools/libfsimage/zfs/zfs-include/zil.h +++ b/tools/libfsimage/zfs/zfs-include/zil.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zio.h b/tools/libfsimage/zfs/zfs-include/zio.h index 513f321f9a82584acacbde1620b60d954bcdcb5e..c9dce12271379196bcab6e64562a6db132daaba1 100644 --- a/tools/libfsimage/zfs/zfs-include/zio.h +++ b/tools/libfsimage/zfs/zfs-include/zio.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zio_checksum.h b/tools/libfsimage/zfs/zfs-include/zio_checksum.h index 5f22f29995765835586b0baadfb9410a5ffdca84..b9864ee32722e317abc774f2c2fb91ab6e54f26c 100644 --- a/tools/libfsimage/zfs/zfs-include/zio_checksum.h +++ b/tools/libfsimage/zfs/zfs-include/zio_checksum.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_fletcher.c b/tools/libfsimage/zfs/zfs_fletcher.c index cc9e8c4954d46eb47ce4321b05e1bddc7f61fc89..368beed6b06f329d631d60def1656e7503d50f21 100644 --- a/tools/libfsimage/zfs/zfs_fletcher.c +++ b/tools/libfsimage/zfs/zfs_fletcher.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_lzjb.c b/tools/libfsimage/zfs/zfs_lzjb.c index 0b11eee63af1b584feb1d7aab8365c0319a61584..f904e0b7dc4590411274b55e464adeefc94a1af7 100644 --- a/tools/libfsimage/zfs/zfs_lzjb.c +++ b/tools/libfsimage/zfs/zfs_lzjb.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_sha256.c b/tools/libfsimage/zfs/zfs_sha256.c index 18a5c05008ef4a5f5b2cec57e343ed8ea1f9ccfe..9a5b4af54e3c0f7da8c685d700a41fdc09e536a5 100644 --- a/tools/libfsimage/zfs/zfs_sha256.c +++ b/tools/libfsimage/zfs/zfs_sha256.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libs/call/buffer.c b/tools/libs/call/buffer.c index 085674d882ae5d031460f26451f48a3da790e549..34d0c90c58ce57125fda700571999122b2918269 100644 --- a/tools/libs/call/buffer.c +++ b/tools/libs/call/buffer.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/call/core.c b/tools/libs/call/core.c index 02c4f8e1aefa9a87846daf0ae811cc91e12a0c00..ae82ff9535d870ce764242d21b5325eaa663b2b8 100644 --- a/tools/libs/call/core.c +++ b/tools/libs/call/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/call/freebsd.c b/tools/libs/call/freebsd.c index 6d2e8704b3de549f8e3e6e1de158138fc0c8ef11..20ec28a564684cdec8fb49f4ec21a7fb5b7fcd63 100644 --- a/tools/libs/call/freebsd.c +++ b/tools/libs/call/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_freebsd_osdep.c */ diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c index 6d588e6bea8fab3e2dfe18966d95ae09c14899c3..65d5a764689d998f02adaa389b2be7ba4d25ac1e 100644 --- a/tools/libs/call/linux.c +++ b/tools/libs/call/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/call/minios.c b/tools/libs/call/minios.c index 3f33b8357829cc632f8775eda46e1a15699f0d5a..9b1435ca11494eb7600d52d520a537ae4d5910fe 100644 --- a/tools/libs/call/minios.c +++ b/tools/libs/call/minios.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_minios.c * diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c index 91ae68357e3ef7b973499c7621515bb4150c61bb..e27c0f32d7a40b9287593b56f3a8a78e0497c970 100644 --- a/tools/libs/call/netbsd.c +++ b/tools/libs/call/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_netbsd.c */ diff --git a/tools/libs/call/solaris.c b/tools/libs/call/solaris.c index 304262bd057b37e9724cf9e177b20e1b70e9dcde..b79102fe996e19e4f605aec0862075442ec733a4 100644 --- a/tools/libs/call/solaris.c +++ b/tools/libs/call/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_solaris.c */ diff --git a/tools/libs/ctrl/xc_altp2m.c b/tools/libs/ctrl/xc_altp2m.c index 6987c9541fd15cacb9880fb8f73763f63b023db7..cad63f74a1c922dcde6a0322387f3dc26e5a8de8 100644 --- a/tools/libs/ctrl/xc_altp2m.c +++ b/tools/libs/ctrl/xc_altp2m.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_cpu_hotplug.c b/tools/libs/ctrl/xc_cpu_hotplug.c index 2ea98257792ba0b10330de492e96c4b73860d7a8..9f3916300000a63703abee19f214c112383764f5 100644 --- a/tools/libs/ctrl/xc_cpu_hotplug.c +++ b/tools/libs/ctrl/xc_cpu_hotplug.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/ctrl/xc_cpupool.c b/tools/libs/ctrl/xc_cpupool.c index fbd8cc9d037c7761e78e5d7111e6eead027f8b3a..52dcfe4a274a5d64c534dd47ede42da9c889a5dd 100644 --- a/tools/libs/ctrl/xc_cpupool.c +++ b/tools/libs/ctrl/xc_cpupool.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2009, J Gross. */ diff --git a/tools/libs/ctrl/xc_csched.c b/tools/libs/ctrl/xc_csched.c index 8e8c67220a0bc88db1bbc1d7880a8a95dd39570a..24213fc4c3cf53939357d01f37b68b803e220675 100644 --- a/tools/libs/ctrl/xc_csched.c +++ b/tools/libs/ctrl/xc_csched.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_csched2.c b/tools/libs/ctrl/xc_csched2.c index 5eb753ad99158cfcd743fa4eb2260b17002f3793..14e4d15ad2644e1ffd5e08b4d6464cdab84e2f04 100644 --- a/tools/libs/ctrl/xc_csched2.c +++ b/tools/libs/ctrl/xc_csched2.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index e939d0715739f288bcf5c5f3c2a6f8865dddbbd1..d87105331dc3d394b16757b36cf9ebb9cf5db098 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2003, K A Fraser. */ diff --git a/tools/libs/ctrl/xc_evtchn.c b/tools/libs/ctrl/xc_evtchn.c index 614786d3f3197e93958abe4321f40a0becb11d3b..7578869367b922ef8182e9ec96b242409a276be1 100644 --- a/tools/libs/ctrl/xc_evtchn.c +++ b/tools/libs/ctrl/xc_evtchn.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2004, K A Fraser. */ diff --git a/tools/libs/ctrl/xc_flask.c b/tools/libs/ctrl/xc_flask.c index c1652ba48d7c9163080cea92ea874e729f1ad96f..e3b6e9f279d73b7abb7a0d7d12e5801d3837de59 100644 --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_foreign_memory.c b/tools/libs/ctrl/xc_foreign_memory.c index 4053d268513673d18fedaeccd739b4186d33846d..47d65bf2f6c59574d2217be6c2239701cb9b507f 100644 --- a/tools/libs/ctrl/xc_foreign_memory.c +++ b/tools/libs/ctrl/xc_foreign_memory.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #define XC_BUILDING_COMPAT_MAP_FOREIGN_API diff --git a/tools/libs/ctrl/xc_freebsd.c b/tools/libs/ctrl/xc_freebsd.c index 9dd48a3a08bb00c4bd1f75caf99b7865a977030b..661e49a9a110e2e3f8f82a75d733c4c5c49012b1 100644 --- a/tools/libs/ctrl/xc_freebsd.c +++ b/tools/libs/ctrl/xc_freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_gnttab.c b/tools/libs/ctrl/xc_gnttab.c index eb92d897d49e54d48d08db56a3b7b3dd17bde7c8..7db3f81613cb915de47350a8889baddb87689b94 100644 --- a/tools/libs/ctrl/xc_gnttab.c +++ b/tools/libs/ctrl/xc_gnttab.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_hcall_buf.c b/tools/libs/ctrl/xc_hcall_buf.c index 200671f36ff2a036743de545243e29b786337bbe..59127484841bb835e1a5fb3db64e33b3e6d9a8eb 100644 --- a/tools/libs/ctrl/xc_hcall_buf.c +++ b/tools/libs/ctrl/xc_hcall_buf.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/ctrl/xc_linux.c b/tools/libs/ctrl/xc_linux.c index c67c71c08be3f43fbe579e9ec76d8f1218fe4d28..c961f53124caa57aff6a27c4996c0a526b0265e6 100644 --- a/tools/libs/ctrl/xc_linux.c +++ b/tools/libs/ctrl/xc_linux.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_mem_access.c b/tools/libs/ctrl/xc_mem_access.c index 6d613037d04ea81369c1ccde40126c0da574277a..15c047174b253ea28484f77e604e1ba8432537d1 100644 --- a/tools/libs/ctrl/xc_mem_access.c +++ b/tools/libs/ctrl/xc_mem_access.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_mem_paging.c b/tools/libs/ctrl/xc_mem_paging.c index 999a572cefdcbadfec7d1c1a854acecd0f2c6411..a940f3b95702f991e47f02e1f22c95bd2ff5d694 100644 --- a/tools/libs/ctrl/xc_mem_paging.c +++ b/tools/libs/ctrl/xc_mem_paging.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c index 2f65b3b22e13b37a7c7055920ab52b541e83b291..9813a731a359ff6905c8c814fe72be1cd5674698 100644 --- a/tools/libs/ctrl/xc_memshr.c +++ b/tools/libs/ctrl/xc_memshr.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_minios.c b/tools/libs/ctrl/xc_minios.c index 3dea7a78a576d7425f36096837cb25099a2577ab..0a75f382615caf9d2d9a7d2c2572ae5d2863a93d 100644 --- a/tools/libs/ctrl/xc_minios.c +++ b/tools/libs/ctrl/xc_minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #undef NDEBUG diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 265f15ec2da344e948cbbe532d6d456a09accfc0..3b8b19801be53efc1bb025cd6aa713ce1f4976c3 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_bitops.h" diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c index c5fa62ff30d2bc3107e52ed70242644d182730fc..4a29f199b0b4152d4767a2539eb5e4ced6ba5b5b 100644 --- a/tools/libs/ctrl/xc_monitor.c +++ b/tools/libs/ctrl/xc_monitor.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_netbsd.c b/tools/libs/ctrl/xc_netbsd.c index 31979937621ebd37de7578878b2825bd8f9b05b0..4609ba8599d8e3d02bb8a9f7335b615d6667c100 100644 --- a/tools/libs/ctrl/xc_netbsd.c +++ b/tools/libs/ctrl/xc_netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_pagetab.c b/tools/libs/ctrl/xc_pagetab.c index db25c20247573a3c638d7725c976433221a40141..b938d8b8369c54a4ebf4245268f43d572f0a7501 100644 --- a/tools/libs/ctrl/xc_pagetab.c +++ b/tools/libs/ctrl/xc_pagetab.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_physdev.c b/tools/libs/ctrl/xc_physdev.c index 460a8e779ce857e764e414c6dc118d6918d7aa6b..2fc2ac67a174d570bfddf2d7a1ce6cdbb46c575e 100644 --- a/tools/libs/ctrl/xc_physdev.c +++ b/tools/libs/ctrl/xc_physdev.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 76d7eb7f265da4e52a69f944e13e10621d6ad2e2..5af84c2bbeff0e80e5f89b5b439e1b080f595548 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index 2f99a7d2cfb560cdf57ae6777f55d0310f943602..444e2e6ad92458dc811b16895eec365c6698d676 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index ed960c6f30e65baf1b0857961cfdb276e12fdcfe..818c7a6c750e4bc618e6e658d665958c4a9daa01 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XC_PRIVATE_H diff --git a/tools/libs/ctrl/xc_rt.c b/tools/libs/ctrl/xc_rt.c index ad257c6e52878b652e5449804de02d61aa3d05ff..03bbacffa37b484cf51025c3ebf5a8260dc3f57d 100644 --- a/tools/libs/ctrl/xc_rt.c +++ b/tools/libs/ctrl/xc_rt.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_solaris.c b/tools/libs/ctrl/xc_solaris.c index 5128f3f0f49040cbe88d762f6f42448cbb8a8f21..629b0b21faadbdc6616c0b9e38641b1d6eac5989 100644 --- a/tools/libs/ctrl/xc_solaris.c +++ b/tools/libs/ctrl/xc_solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_tbuf.c b/tools/libs/ctrl/xc_tbuf.c index 283fbd1c8fb898bbbcb978e0fb71ca018504e362..110e4323a69a2d4ee02d356a19440863c1d8d8d7 100644 --- a/tools/libs/ctrl/xc_tbuf.c +++ b/tools/libs/ctrl/xc_tbuf.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_vm_event.c b/tools/libs/ctrl/xc_vm_event.c index a97c615b18999e96a29dd1ef0bfc09c5455e062a..a371cca306496d9f4cd4a8e3085d2f2aa1431783 100644 --- a/tools/libs/ctrl/xc_vm_event.c +++ b/tools/libs/ctrl/xc_vm_event.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_vmtrace.c b/tools/libs/ctrl/xc_vmtrace.c index 602502367f2393ab38b5680a707a7f3a444fa57a..b36455f1dd3d8fd56610593382e8bdfd56f224d3 100644 --- a/tools/libs/ctrl/xc_vmtrace.c +++ b/tools/libs/ctrl/xc_vmtrace.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/devicemodel/common.c b/tools/libs/devicemodel/common.c index 0fdc7121f1eb7707f1f330577c9f4a2c948199f9..e18c2379e55d939323c91eb214d1e35900fa9bc1 100644 --- a/tools/libs/devicemodel/common.c +++ b/tools/libs/devicemodel/common.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/devicemodel/compat.c b/tools/libs/devicemodel/compat.c index 5b4fdae2980450518919d60d50bf4acbeb6b100b..3c72737b0c50e3bea926317c4bea412b4089febc 100644 --- a/tools/libs/devicemodel/compat.c +++ b/tools/libs/devicemodel/compat.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index 8e619eeb0a1fc5faf7043e90ceb91becf9999db0..a30bdaa465ed8f03ed2316b3e42b991e2293be2c 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c index de925fc9630c0ca398b75c3d02ad81cbddbe21ed..5d70e827a8a450d3624e6357319ad0ee77b2a5b8 100644 --- a/tools/libs/evtchn/core.c +++ b/tools/libs/evtchn/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c index 422836f1a1145de40dbbe771e0825b6d327ab377..0a557fce99b72cbf6205a26ae25689d7166c1f02 100644 --- a/tools/libs/evtchn/freebsd.c +++ b/tools/libs/evtchn/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from xc_freebsd_osdep.c */ diff --git a/tools/libs/evtchn/linux.c b/tools/libs/evtchn/linux.c index e61b77ca618a502448b7fcf4eedc83de4dfbca65..e9576e6ffc7fda7bb7bef7795bef35a9517ee58f 100644 --- a/tools/libs/evtchn/linux.c +++ b/tools/libs/evtchn/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c index 28743cb055753f02976c9258003203b51c40a242..6f5482edcfa716fb27f1818178a4cdc05d6317d9 100644 --- a/tools/libs/evtchn/minios.c +++ b/tools/libs/evtchn/minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from xc_minios.c */ diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c index 2de9cefc67f89b2a0ebd39c3008be0147701de1c..68047ef65c6fe77723308ec02fc77be523ee7324 100644 --- a/tools/libs/evtchn/netbsd.c +++ b/tools/libs/evtchn/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_netbsd.c */ diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c index 375a5f9b4fce280688fa0c6dcf8480cfb40fb78f..d137c7a30c044366ca36e03f766450f6ba490919 100644 --- a/tools/libs/evtchn/solaris.c +++ b/tools/libs/evtchn/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_solaris.c */ diff --git a/tools/libs/foreignmemory/compat.c b/tools/libs/foreignmemory/compat.c index 5f730ca919d670de43cd1581a131224a856a050d..2d743720a42cf575f220d80cf3cd3d1f61fdf8a4 100644 --- a/tools/libs/foreignmemory/compat.c +++ b/tools/libs/foreignmemory/compat.c @@ -11,7 +11,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_foreign_memory.c */ diff --git a/tools/libs/foreignmemory/core.c b/tools/libs/foreignmemory/core.c index 7edc6f0dbfe35859819b9d5f6a21b12c61a8b471..ab6e8820e67a232c6c9002ba4c03f8604e0b9cf6 100644 --- a/tools/libs/foreignmemory/core.c +++ b/tools/libs/foreignmemory/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/freebsd.c b/tools/libs/foreignmemory/freebsd.c index 2cf0fa1c38b1544e43116867bf48b3e3bf47f959..d18e9f9112b3bad4444ec0ccfb0cd1d24cc243ab 100644 --- a/tools/libs/foreignmemory/freebsd.c +++ b/tools/libs/foreignmemory/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c index 9062117407a998634c6115043bbe33339e53ee19..7f6a327a9b43ee2b76f58fb918ffe004afab7d85 100644 --- a/tools/libs/foreignmemory/linux.c +++ b/tools/libs/foreignmemory/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/foreignmemory/minios.c b/tools/libs/foreignmemory/minios.c index f2f4dfb2be51851431b776e8b0d0c277cb13ec7e..0f7570772e3d9389f6373e8becaa8a6e292bd98f 100644 --- a/tools/libs/foreignmemory/minios.c +++ b/tools/libs/foreignmemory/minios.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_minios.c * diff --git a/tools/libs/foreignmemory/netbsd.c b/tools/libs/foreignmemory/netbsd.c index 597db775d7ea428f865f3a53192494617e69cb49..8220452d6dd47662f76bc5d1fe2e3580ebd1eaad 100644 --- a/tools/libs/foreignmemory/netbsd.c +++ b/tools/libs/foreignmemory/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/solaris.c b/tools/libs/foreignmemory/solaris.c index 958fb01f6d24a0e166b3a1d0db3000c2e84659ac..8dceeab84053fe8ed8472e6e94e015a4254acae7 100644 --- a/tools/libs/foreignmemory/solaris.c +++ b/tools/libs/foreignmemory/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/gnttab/freebsd.c b/tools/libs/gnttab/freebsd.c index e42ac3fbf351470d43b085eed0e172a0f85b8e09..97373b3faee3fc91a006c870fa431ab0e5aa013e 100644 --- a/tools/libs/gnttab/freebsd.c +++ b/tools/libs/gnttab/freebsd.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from linux.c */ diff --git a/tools/libs/gnttab/gntshr_core.c b/tools/libs/gnttab/gntshr_core.c index 1117e29c91335eb50b0c848b7ead2449ab148df9..2483d4987618aebff4b62f3673dc53fa62f9316c 100644 --- a/tools/libs/gnttab/gntshr_core.c +++ b/tools/libs/gnttab/gntshr_core.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gntshr_unimp.c b/tools/libs/gnttab/gntshr_unimp.c index e21048435b1795ec5f057966aacbab5e09ae3892..dd08bc1265b97e86e7a69b0d03c1a4a8fe89782a 100644 --- a/tools/libs/gnttab/gntshr_unimp.c +++ b/tools/libs/gnttab/gntshr_unimp.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gnttab_core.c b/tools/libs/gnttab/gnttab_core.c index 92e7228a267123c1e5156ea3d74b081bcbd7cbf0..4b6cdf26747bca181286a405efca64815e4c179a 100644 --- a/tools/libs/gnttab/gnttab_core.c +++ b/tools/libs/gnttab/gnttab_core.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gnttab_unimp.c b/tools/libs/gnttab/gnttab_unimp.c index dee1afd2647f9f69a1d2a0dc5450b31ffd81a4da..bef13af9d85cd1aa71516dea052781f4bec824eb 100644 --- a/tools/libs/gnttab/gnttab_unimp.c +++ b/tools/libs/gnttab/gnttab_unimp.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c index 5628fd5719d1d7f95f5c5ca3f6e22cee708b32cf..e730250bcf8e2876f618321fbc45735c1f961a5c 100644 --- a/tools/libs/gnttab/linux.c +++ b/tools/libs/gnttab/linux.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linux_osdep.c */ diff --git a/tools/libs/gnttab/minios.c b/tools/libs/gnttab/minios.c index cac89f0ba6206df7e4271427269cd4e39069a459..410b545ec694605688f909d014380bf3c3febe5c 100644 --- a/tools/libs/gnttab/minios.c +++ b/tools/libs/gnttab/minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Splitfrom xc_minios.c */ diff --git a/tools/libs/gnttab/netbsd.c b/tools/libs/gnttab/netbsd.c index a4ad624b5415f050bcd23503e5e478ff6a5699f7..2c1a80f45421473f9dfb7303c7a07ade97ccbf37 100644 --- a/tools/libs/gnttab/netbsd.c +++ b/tools/libs/gnttab/netbsd.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from linux.c */ diff --git a/tools/libs/guest/xg_core.c b/tools/libs/guest/xg_core.c index c52f1161c1c8ff7e7f6effdc8a40ee449d4eaa81..6cb3d1b24a5d331e2480e83fab2a82cfe816d515 100644 --- a/tools/libs/guest/xg_core.c +++ b/tools/libs/guest/xg_core.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ /* diff --git a/tools/libs/guest/xg_core.h b/tools/libs/guest/xg_core.h index aaca9e0a8b992b5915ddfd20ef474ace8eccaeaf..a7585fa7aae06534cfd536cad6815ea0cc0a6fa6 100644 --- a/tools/libs/guest/xg_core.h +++ b/tools/libs/guest/xg_core.h @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_core_arm.c b/tools/libs/guest/xg_core_arm.c index aaabd075585e4ab69f7b690bab6a8256509a5fa6..c4a89b15e48fe6acba6f3f75a13412f1d0d98b35 100644 --- a/tools/libs/guest/xg_core_arm.c +++ b/tools/libs/guest/xg_core_arm.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011 Citrix Systems * diff --git a/tools/libs/guest/xg_core_arm.h b/tools/libs/guest/xg_core_arm.h index 162f7a7569e7067ebdb096c571439c4f6e7714b8..df0a2a2d2a7451c9a7e948aed0646f1a8d79fb7d 100644 --- a/tools/libs/guest/xg_core_arm.h +++ b/tools/libs/guest/xg_core_arm.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2012 Citrix Systems * diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 61106b98b87701330d0833e7d138a55b2f614416..dcfe6a7c59796f0114c8c5f6740f271a246df5f0 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2007 Isaku Yamahata * VA Linux Systems Japan K.K. diff --git a/tools/libs/guest/xg_core_x86.h b/tools/libs/guest/xg_core_x86.h index 867146b1d9e73bed2810f6aa60f22bcc9b12d58b..4c9f82480861b6c24f331d243e7cf9a58b83d651 100644 --- a/tools/libs/guest/xg_core_x86.h +++ b/tools/libs/guest/xg_core_x86.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2007 Isaku Yamahata * VA Linux Systems Japan K.K. diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 57f81eb0a0822b6d17cb5dfce90ef964a9178b75..72b23b5f7610e5c549f446da480ca50a91bee527 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c index 5e3b76355ec4850056a415cdbba25b52e7ca8c28..0aa693047e0a5d3779272b11276797d8a771ba74 100644 --- a/tools/libs/guest/xg_dom_arm.c +++ b/tools/libs/guest/xg_dom_arm.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011, Citrix Systems */ diff --git a/tools/libs/guest/xg_dom_armzimageloader.c b/tools/libs/guest/xg_dom_armzimageloader.c index 6d837cefc4a25b85d4974c1672b7d649d61edf32..ac822a213cb14264be946ce546493209e500124a 100644 --- a/tools/libs/guest/xg_dom_armzimageloader.c +++ b/tools/libs/guest/xg_dom_armzimageloader.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_dom_binloader.c b/tools/libs/guest/xg_dom_binloader.c index f5e3ddc5dc4d515f455ef70aaa3cf607eaad4d37..bf8bfbefb994a58761d38961e12ff65b50faca86 100644 --- a/tools/libs/guest/xg_dom_binloader.c +++ b/tools/libs/guest/xg_dom_binloader.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Some of the field descriptions were copied from "The Multiboot * Specification", Copyright 1995, 96 Bryan Ford , diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index 263a3f4c85a660790a8794b9147e338047bda18e..d20b37401269d0481658b502ffe9c694cbf884d6 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_bzimageloader.c b/tools/libs/guest/xg_dom_bzimageloader.c index 764ddbb43eb82dfe8c12eb95f38d952ed5c8c374..4e1693e625b16dfd017e4b7f38fdc5e985248e20 100644 --- a/tools/libs/guest/xg_dom_bzimageloader.c +++ b/tools/libs/guest/xg_dom_bzimageloader.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * written 2007 by Jeremy Fitzhardinge diff --git a/tools/libs/guest/xg_dom_compat_linux.c b/tools/libs/guest/xg_dom_compat_linux.c index a0d9c7a04e85946804ecf48bc4e1d3bf47e83220..1b18b51ba6df30f67724fa395a9aeab2c06e71c7 100644 --- a/tools/libs/guest/xg_dom_compat_linux.c +++ b/tools/libs/guest/xg_dom_compat_linux.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c index c4f4e7f3e27a13f4cb72eb96552c921c6b45e4c8..a228496fd4066bae8e9a862d6548b6e6f65bc78b 100644 --- a/tools/libs/guest/xg_dom_core.c +++ b/tools/libs/guest/xg_dom_core.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_elfloader.c b/tools/libs/guest/xg_dom_elfloader.c index f17930d98bf70fa3a0a7dced02177e0ce6123538..f71a49a4332c973ab3f3c58964cf4f764ca4c6c4 100644 --- a/tools/libs/guest/xg_dom_elfloader.c +++ b/tools/libs/guest/xg_dom_elfloader.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_hvmloader.c b/tools/libs/guest/xg_dom_hvmloader.c index 39e1e5f579a738b5f71c0ef28dcd821817b22a94..e78754ce26b3af00447d14fa45a219d855fc5061 100644 --- a/tools/libs/guest/xg_dom_hvmloader.c +++ b/tools/libs/guest/xg_dom_hvmloader.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c index 9328fbf804853d98db175b6a02bcc925fd8b1181..b536afbe3cf2229872be53618781d2fa41332ba3 100644 --- a/tools/libs/guest/xg_dom_x86.c +++ b/tools/libs/guest/xg_dom_x86.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index f0e7748449a1c7b13ec601d66bef4d18eb9485c0..ce4562b024defb0cad10bf1b441b244b1812e679 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2003, K A Fraser. */ diff --git a/tools/libs/guest/xg_nomigrate.c b/tools/libs/guest/xg_nomigrate.c index 6795c62ddc2803527bf0e74843cb86ef99231de0..f9b528cf25c9e20f72bd85cc33c976641987472e 100644 --- a/tools/libs/guest/xg_nomigrate.c +++ b/tools/libs/guest/xg_nomigrate.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011, Citrix Systems */ diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index c594fdba415de8cde8d08e53710b9c0437a8b5a4..406ec536e169d3b489c9dadd155160c122f4d10a 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_private.c b/tools/libs/guest/xg_private.c index 2073dba2ef2091b71e175252b5da7b14549602d2..291ed0b237eb9bb380751ae40a938953918fbe1d 100644 --- a/tools/libs/guest/xg_private.c +++ b/tools/libs/guest/xg_private.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 09e24f122760a4bfc6a8e73c922ed44b5f8da635..62d8a153210684a24103650cc1c4e283d190c50e 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XG_PRIVATE_H diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c index 77e2451a3c4daa7712a056bf9886661ff474bcdb..0b5451c8a4fdf154342bc0b38f4459297f1bc84a 100644 --- a/tools/libs/guest/xg_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xg_private.h" diff --git a/tools/libs/guest/xg_save_restore.h b/tools/libs/guest/xg_save_restore.h index 3dbbc8dcd271c59a35836ab9d2a911cdb5126843..a30c909271c596627dfa74714e98ec359ae0a5dd 100644 --- a/tools/libs/guest/xg_save_restore.h +++ b/tools/libs/guest/xg_save_restore.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/guest/xg_suspend.c b/tools/libs/guest/xg_suspend.c index 0ce63649636905851e03750a0ae8bcb63dd926f1..62d9b3d9ed65364c982065169d4d9941fa9861d5 100644 --- a/tools/libs/guest/xg_suspend.c +++ b/tools/libs/guest/xg_suspend.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c index 52b30db8d777c357fb85f3e936ce120d1431f421..522576a152251280d4e73ed0254d83782650edf4 100644 --- a/tools/libs/hypfs/core.c +++ b/tools/libs/hypfs/core.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #define __XEN_TOOLS__ 1 diff --git a/tools/libs/stat/COPYING b/tools/libs/stat/COPYING index 480e5f18765e660f5e9d00f9bb09097bdc3d3084..d49f0cf1a31a59bda21b086c12cc4e5071bcb635 100644 --- a/tools/libs/stat/COPYING +++ b/tools/libs/stat/COPYING @@ -489,7 +489,7 @@ notice is found. Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index 7a9a8b1656b05799515b75520cbc32bba72069a0..faafb3a1c5fc65a76603c47ab29cdd0ae010150f 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #define _GNU_SOURCE diff --git a/tools/libs/toolcore/handlereg.c b/tools/libs/toolcore/handlereg.c index b43cb0e8acab7a06d65a3215934bd56e1e8d93a0..4a9d87b64107ad9b0aaa112926a8cf7bf946a3ea 100644 --- a/tools/libs/toolcore/handlereg.c +++ b/tools/libs/toolcore/handlereg.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoolcore_internal.h" diff --git a/tools/libs/toollog/xtl_core.c b/tools/libs/toollog/xtl_core.c index 099d2f30951d613e189cd7d980f39f274c91a772..c526c44ab4918ce1f67cd778d95054ad0fe8eaef 100644 --- a/tools/libs/toollog/xtl_core.c +++ b/tools/libs/toollog/xtl_core.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoollog.h" diff --git a/tools/libs/toollog/xtl_logger_stdio.c b/tools/libs/toollog/xtl_logger_stdio.c index 52dfbf51e35b122462fa966f4c4171b768dd0204..4fc17aad96929eb2cf75a45d2b6027975fdb9515 100644 --- a/tools/libs/toollog/xtl_logger_stdio.c +++ b/tools/libs/toollog/xtl_logger_stdio.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoollog.h" diff --git a/tools/libs/util/libxlu_cfg_y.c b/tools/libs/util/libxlu_cfg_y.c index 6d4638afc937368065943fee2386aa523a1c12a3..055b697437d9dc7d9ce9d63fa965ded14ba10932 100644 --- a/tools/libs/util/libxlu_cfg_y.c +++ b/tools/libs/util/libxlu_cfg_y.c @@ -16,7 +16,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program. If not, see . */ + along with this program. If not, see . */ /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work diff --git a/tools/libs/util/libxlu_cfg_y.h b/tools/libs/util/libxlu_cfg_y.h index 1233cb94fccc3d7c442ebb3692af23000c550983..01f12531a641c78a2e5265361dab01e31974170a 100644 --- a/tools/libs/util/libxlu_cfg_y.h +++ b/tools/libs/util/libxlu_cfg_y.h @@ -16,7 +16,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program. If not, see . */ + along with this program. If not, see . */ /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98759897d324bf0a712f7788be1e5865..9136a118753858e3e70dbbe37247d4747b449af9 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c index 1f201ad554f2dc050f45e63b92446d301fb76d89..00281ebf36f1a3cbb93316b458e9eddc9b7f32d9 100644 --- a/tools/libs/vchan/io.c +++ b/tools/libs/vchan/io.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h index 621016ef42e5eaf57f1c0d5e333801d35b3abe35..9aec37906960f80c5bbf717717eb2e6f9cf528ba 100644 --- a/tools/libs/vchan/vchan.h +++ b/tools/libs/vchan/vchan.h @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/misc/mkhex b/tools/misc/mkhex index d0982d5787286ba894087358115824cc75eaea30..0cc49047cbf33aabde0291ce407f314210d4c42f 100755 --- a/tools/misc/mkhex +++ b/tools/misc/mkhex @@ -16,7 +16,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # echo "unsigned $1[] = {" diff --git a/tools/misc/xen-mceinj.c b/tools/misc/xen-mceinj.c index df55eefbacc585e7e62eff1c40972cfa15015b35..b385eaac57021a1bbb6b2691c9178bdd2339cf55 100644 --- a/tools/misc/xen-mceinj.c +++ b/tools/misc/xen-mceinj.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Authors: Yunhong Jiang * Haicheng Li diff --git a/tools/misc/xen-vmtrace.c b/tools/misc/xen-vmtrace.c index 5b688a54af5a1c59a4cc85acbf81c9b0e164a5e9..93af18ebbd8adfe364bb1f72c414188f685d6053 100644 --- a/tools/misc/xen-vmtrace.c +++ b/tools/misc/xen-vmtrace.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/misc/xencov.c b/tools/misc/xencov.c index e5b40dba9cf1c1f42f4efc2d851cdefcb33ad37a..28e006569a204eef5593dee8868ab32a5b80b396 100644 --- a/tools/misc/xencov.c +++ b/tools/misc/xencov.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 4f8cde690a7c77f4465fd0815c901b4232240419..162a18fe7e1485145a6255f8c653b47552f24a97 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define MAX_NR_CPU 512 diff --git a/tools/misc/xenpvnetboot b/tools/misc/xenpvnetboot index be972b9e19b7ff55e7723c37d1e2affd306fae22..7a6feee3d4474385d0738954733a691b7dfdbbf6 100755 --- a/tools/misc/xenpvnetboot +++ b/tools/misc/xenpvnetboot @@ -8,7 +8,7 @@ # useful, but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General # Public License for more details. You should have received a copy of the GNU -# General Public License along with this program; If not, see . +# General Public License along with this program; If not, see . import sys import os @@ -168,7 +168,7 @@ Get boot images from the given location and prepare for Xen to use. Supported locations: - - http://host/path + - https://host/path - https://host/path - ftp://host/path - file:///path @@ -216,7 +216,7 @@ Supported locations: else: location = '' if (location == '' - or location.startswith('http://') or location.startswith('https://') + or location.startswith('https://') or location.startswith('https://') or location.startswith('ftp://') or location.startswith('file://') or (os.path.exists(location) and os.path.isdir(location))): fetcher = Fetcher(location, opts.output_directory) diff --git a/tools/ocaml/LICENSE b/tools/ocaml/LICENSE index d4d1f176886856c1e536ca925471520ba9c7bcfe..f11101ec2d33d936815e259bd757869e456d2bfd 100644 --- a/tools/ocaml/LICENSE +++ b/tools/ocaml/LICENSE @@ -181,7 +181,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public -License along with this library; If not, see . +License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/pygrub/src/ExtLinuxConf.py b/tools/pygrub/src/ExtLinuxConf.py index 9fd635b9cf7ad56a925e955be9702922d2648121..c12fa3a1912c92ced8ecf3f1f3596af55f67773f 100644 --- a/tools/pygrub/src/ExtLinuxConf.py +++ b/tools/pygrub/src/ExtLinuxConf.py @@ -7,7 +7,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function, absolute_import diff --git a/tools/pygrub/src/GrubConf.py b/tools/pygrub/src/GrubConf.py index 73f1bbed2f543333172104683768710ed61b6bf3..958a15a44af1b284b1a5b69aa8557ae1585f4af2 100644 --- a/tools/pygrub/src/GrubConf.py +++ b/tools/pygrub/src/GrubConf.py @@ -9,7 +9,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function, absolute_import diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub index ce7ab0eb8cf3c352dfc5ac1726b88cbbf953ff28..eda2aa1f4e0de8fb70749140e0f52f365277b7de 100755 --- a/tools/pygrub/src/pygrub +++ b/tools/pygrub/src/pygrub @@ -9,7 +9,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function diff --git a/tools/python/xen/lowlevel/xs/xs.c b/tools/python/xen/lowlevel/xs/xs.c index 3ba5a8b893d9c0ce7b5aaf242242568910807d06..bb78f5b84bb6771ea6786cd14267cb8f9c4de3db 100644 --- a/tools/python/xen/lowlevel/xs/xs.c +++ b/tools/python/xen/lowlevel/xs/xs.c @@ -11,7 +11,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) 2005 Mike Wray Hewlett-Packard * Copyright (C) 2005 Christian Limpach diff --git a/tools/tests/depriv/depriv-fd-checker.c b/tools/tests/depriv/depriv-fd-checker.c index 98a27a03d5438b783c6ae4cf0c23591b48b57c93..bd0bdb2d54f2aeef910843e645e30bb6cc7b89c6 100644 --- a/tools/tests/depriv/depriv-fd-checker.c +++ b/tools/tests/depriv/depriv-fd-checker.c @@ -47,7 +47,7 @@ * * You should have received a copy of the GNU Lesser General Public * License along with this library; If not, see - * . + * . */ #include diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index b022cc0eab0373f8e1896df6d710ad94afb3c62f..bec67fcea1361cabb858fae618a3907ba14f769f 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -10,7 +10,7 @@ * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. . + * General Public License for more details. . */ #include diff --git a/tools/tests/vhpet/main.c b/tools/tests/vhpet/main.c index 4054eec6296910d3117334091b3dac190f9aea29..8452da8a60192b66f3980987a74caf19d48fff4c 100644 --- a/tools/tests/vhpet/main.c +++ b/tools/tests/vhpet/main.c @@ -10,7 +10,7 @@ * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. . + * General Public License for more details. . */ /* diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index f03e3a56d18121184f725c6003943fdb7c5e40eb..50f4c1b9d3e9067cbafdfdf25c77ddb8779cb139 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef _TEST_VPCI_ diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c index b9a0a6006bb98c4b7d28ad5d2b9a20ecaff0352a..1348722947f2cad87ed9b39d195b35413bab97a3 100644 --- a/tools/tests/vpci/main.c +++ b/tools/tests/vpci/main.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include "emul.h" diff --git a/tools/tests/x86_emulator/blowfish.c b/tools/tests/x86_emulator/blowfish.c index 8f0939c101879ad5fd2aab202b4619960f5231c0..7c02bbd3ac2219960ca6937e97956410381e417c 100644 --- a/tools/tests/x86_emulator/blowfish.c +++ b/tools/tests/x86_emulator/blowfish.c @@ -12,7 +12,7 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public -License along with this library; If not, see . +License along with this library; If not, see . */ #include diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c index d3574b3fa27025de7115b6c4dda80e8408141fe0..37bde5a67316ec853b6567f5ffd9e7fba57676d0 100644 --- a/tools/tests/xenstore/test-xenstore.c +++ b/tools/tests/xenstore/test-xenstore.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/vchan/node-select.c b/tools/vchan/node-select.c index 039464427a8b54f3a4bc8cd3d5de7bca1aaf9509..e885a05a33c4b1357b0c1ead5799cc9661ba58cd 100644 --- a/tools/vchan/node-select.c +++ b/tools/vchan/node-select.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/vchan/node.c b/tools/vchan/node.c index f1638f013d3d5fc4f00427080848f8022ae7efed..d9720154aaa7801deee7669ff74b9005e83ce627 100644 --- a/tools/vchan/node.c +++ b/tools/vchan/node.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/vchan/vchan-socket-proxy.c b/tools/vchan/vchan-socket-proxy.c index e1d959c6d15ce84e71bafcb512743d1c65f1dc07..72f16e05420b1c42b3b8cc6810932e49975cadc7 100644 --- a/tools/vchan/vchan-socket-proxy.c +++ b/tools/vchan/vchan-socket-proxy.c @@ -22,7 +22,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/xenmon/COPYING b/tools/xenmon/COPYING index ec0f60d1ffd93b956159a23858b2393c58f26d4e..a7ee562a7c71f5ae42a698d0f3fc8cbabf919646 100644 --- a/tools/xenmon/COPYING +++ b/tools/xenmon/COPYING @@ -304,7 +304,7 @@ the "copyright" line and a pointer to where the full notice is found. GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/xenmon/setmask.c b/tools/xenmon/setmask.c index 7e7b7b8f4378c4f690520a3e000b6f90ca0b9201..4452ceacf7151c6585cc28fa5e3b5527a84febea 100644 --- a/tools/xenmon/setmask.c +++ b/tools/xenmon/setmask.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c index 4dddbd20e2fb39a4216f5efe351c13dee0305836..9df18480d5e5401d23871c68efd8e237d2ed7887 100644 --- a/tools/xenmon/xenbaked.c +++ b/tools/xenmon/xenbaked.c @@ -26,7 +26,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenmon/xenbaked.h b/tools/xenmon/xenbaked.h index 9eeacbb5843a3af6efceb10bd953df3249ce8266..b2943edd8135fa132fd621c98fe8d639011b9cf8 100644 --- a/tools/xenmon/xenbaked.h +++ b/tools/xenmon/xenbaked.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __QOS_H__ diff --git a/tools/xenmon/xenmon.py b/tools/xenmon/xenmon.py index 977ada68877139b783345980e78769efd47ca3f5..f37fc29afb573d8abcf6b4b66df97ad246462b64 100644 --- a/tools/xenmon/xenmon.py +++ b/tools/xenmon/xenmon.py @@ -20,7 +20,7 @@ # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . ##################################################################### from __future__ import print_function diff --git a/tools/xenpaging/file_ops.c b/tools/xenpaging/file_ops.c index 301fb3427cc5f8ca271fcc00343772e87efde76f..f13ba9848c26137c8f3c1cd7b82eb01efed48ace 100644 --- a/tools/xenpaging/file_ops.c +++ b/tools/xenpaging/file_ops.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/file_ops.h b/tools/xenpaging/file_ops.h index ee3fd7d8b86c9d2a187daaf7aaa7c8a94a761aaa..5a9466fb587583bb727a42d6a82d8f062be1cea7 100644 --- a/tools/xenpaging/file_ops.h +++ b/tools/xenpaging/file_ops.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/policy.h b/tools/xenpaging/policy.h index b1425a90ef6d3bb5c5132354bb8abe4daf28a006..81356f9c18770988559a242bbcbfe801dd5d511b 100644 --- a/tools/xenpaging/policy.h +++ b/tools/xenpaging/policy.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/policy_default.c b/tools/xenpaging/policy_default.c index 979d251230451710de9087ee348bad47a2261d04..801dfa182d7b743fb9ec3db82e3bab7facc064cb 100644 --- a/tools/xenpaging/policy_default.c +++ b/tools/xenpaging/policy_default.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 6e5490315d0128ed9065308675dab10de3a31c44..a579394b35c2bacbb9468adacbec86c696fd50c0 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/xenpaging/xenpaging.h b/tools/xenpaging/xenpaging.h index e0fc7b31b863b2c4390e6c9f317898f41a1005d2..a1a5074b9ee3b70a13b37102213114d6439e1abc 100644 --- a/tools/xenpaging/xenpaging.h +++ b/tools/xenpaging/xenpaging.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index 15e6169c449de77517de2cb67c21a5c5c4cd4851..f5a8513bc1b6da7fe45f09c31ac98412932dc3b5 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* Xen extended power management support provides HVM guest power management diff --git a/tools/xenstore/COPYING b/tools/xenstore/COPYING index c764b2e3292196157cafb19aef908c9565146be4..00f925a24f36e388fca35ebb9ac1f188c6774ffd 100644 --- a/tools/xenstore/COPYING +++ b/tools/xenstore/COPYING @@ -494,7 +494,7 @@ notice is found. Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/xenstore/include/xenstore_state.h b/tools/xenstore/include/xenstore_state.h index ae0d053c8ffc07c1e0491da647bcc40728d127f3..d949d3aa6522c0b0cc563fc3451e3e62cedc0c82 100644 --- a/tools/xenstore/include/xenstore_state.h +++ b/tools/xenstore/include/xenstore_state.h @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENSTORE_STATE_H diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index 9eda1bfc00c0b6b35d34ce25268fc9c070d9da55..91b620c2c604307f3fd662697ab152bcae7c1836 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -22,7 +22,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ /* diff --git a/tools/xenstore/talloc.h b/tools/xenstore/talloc.h index a0f4bff25788e6964cc42ad9f9c3b5af0fe4a49a..bd027e0f8db2873d9c0231a47baa03b69f9b75ca 100644 --- a/tools/xenstore/talloc.h +++ b/tools/xenstore/talloc.h @@ -21,7 +21,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #include diff --git a/tools/xenstore/tdb.c b/tools/xenstore/tdb.c index 29593b76c308a928e109dec32aea7563dc5b2b8b..d53dfed7979aba9d9ad0f7113cb33a2bdadeb85b 100644 --- a/tools/xenstore/tdb.c +++ b/tools/xenstore/tdb.c @@ -22,7 +22,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ diff --git a/tools/xenstore/tdb.h b/tools/xenstore/tdb.h index ce3c7339f884af1fb381266d729148aefe62f8c7..4676b9058b554ee0b06d1f121e07bc1a40729678 100644 --- a/tools/xenstore/tdb.h +++ b/tools/xenstore/tdb.h @@ -25,7 +25,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifdef __cplusplus diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index cbd62556c3ae50a9d539de14d28890c8d9a9f81a..3d8be860bdf9846c10edb4bde60b4d4e091a507e 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_control.h b/tools/xenstore/xenstored_control.h index a8cb76559ba1e4e13b9c12d14f82765afa090a2b..6ea1194d3ce214dc12a3e83525d47ad3aa3f1373 100644 --- a/tools/xenstore/xenstored_control.h +++ b/tools/xenstore/xenstored_control.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ int do_control(const void *ctx, struct connection *conn, diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 4f00e0cdc0cf30f57a9ab972e9b5752f83724856..5893dfa2560eb844e476d2e56ab06692d6299414 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index c59b06551f543b3909fdb6a49ef57ff9db000d45..3d9c6c66b987e412a3f7ddbe615391db7ec2157a 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_CORE_H diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 9ef41ede03ae16a86ad8274df9d53a0209c96a31..2dae7fc4bdf017c3980a1c7d51e43a667560de98 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index dc4660861eb752142e931d3c870e4c46228016d0..f5f5e0d71e1adb3be00717675b311634755a31d7 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_DOMAIN_H diff --git a/tools/xenstore/xenstored_minios.c b/tools/xenstore/xenstored_minios.c index aa384e50c8fec8297d9870ab3f8c9275fd20babd..3f5ceef9fc9380fdeb9922bfd2391a2dc7c84f8d 100644 --- a/tools/xenstore/xenstored_minios.c +++ b/tools/xenstore/xenstored_minios.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include #include diff --git a/tools/xenstore/xenstored_posix.c b/tools/xenstore/xenstored_posix.c index b20504d1b656b004e5d0dd5cc77cef80d24d9f7f..c422ac1d44d399d2b5ecda0508b07cbdaf0e2128 100644 --- a/tools/xenstore/xenstored_posix.c +++ b/tools/xenstore/xenstored_posix.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 1aa9d3cb3dce2792256e0f373f1f6e65f8523e35..f347c4fb8e367f993aaebfe7aa92d78c44a59f64 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_transaction.h b/tools/xenstore/xenstored_transaction.h index b6f8cb7d0a3b13d9f68eed1fc2443b8ac40c33b8..4e2eb585ebd194fc114a8fa630ec6befc165cf16 100644 --- a/tools/xenstore/xenstored_transaction.h +++ b/tools/xenstore/xenstored_transaction.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_TRANSACTION_H #define _XENSTORED_TRANSACTION_H diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 8ad0229df648361a40435927f85c4341f72f3658..a2d1054bb581b4733bc5ca2a386a0d59cbe85b4e 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_watch.h b/tools/xenstore/xenstored_watch.h index 091890edca966c4e714fd77397f48f4122aecf73..51f7f64ff4ff911754380e7447cf0600ce13eb8f 100644 --- a/tools/xenstore/xenstored_watch.h +++ b/tools/xenstore/xenstored_watch.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_WATCH_H diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index b9941c567cd0559ee76431e9eee525cf0f3ea30c..e8cf37d0bb092efe24be6544743301c2cefd7aff 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #include diff --git a/tools/xenstore/xs_lib.h b/tools/xenstore/xs_lib.h index efa05997d67c30f75be28f0389980117351f396f..78a0a9549a51cf6030b9d37a5ac1464771eca1a2 100644 --- a/tools/xenstore/xs_lib.h +++ b/tools/xenstore/xs_lib.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XS_LIB_H diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c index 950e8935c4c149f9bcd15eeb8691837d0ea881a4..0037f4f1f30e786152631ab89b47d0f1f4967d80 100644 --- a/tools/xentop/xentop.c +++ b/tools/xentop/xentop.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* get curses header from configure */ diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 5de167031e01d73a7e3fdfa1b8bd67352b2b45d9..e555e0cca37a939818f95b6314b105bf87461d9a 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define _XOPEN_SOURCE 600 #include diff --git a/xen/COPYING b/xen/COPYING index ddb3494147a1312ffb8120c9486eea0d21ec4718..e76aa91592a88ed1510ef6fa8066050d89af6c14 100644 --- a/xen/COPYING +++ b/xen/COPYING @@ -331,7 +331,7 @@ the "copyright" line and a pointer to where the full notice is found. GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index db5085e15d84321b6d05aa338ffbf25e26ec8913..dda7b4e74e76490a0a77a0db020d4ac3a45a5f0e 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c index 41d521f720ac5fe4fe2a2f5f2e1f82b4add3ceba..482dac701f340373071b3233c64fc762b732ed60 100644 --- a/xen/arch/arm/acpi/lib.c +++ b/xen/arch/arm/acpi/lib.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/arm32/insn.c b/xen/arch/arm/arm32/insn.c index 49953a042aee62a56e6785ed030ece3848701169..b8ea6005419221f2333746ddbbaf8fb2d257c308 100644 --- a/xen/arch/arm/arm32/insn.c +++ b/xen/arch/arm/arm32/insn.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include #include diff --git a/xen/arch/arm/arm32/lib/bitops.c b/xen/arch/arm/arm32/lib/bitops.c index ceddd76d1b008e3c9f712fdf686fca979401eb51..6df685a0e910e29d1f2b64ca6eaa445325959fa6 100644 --- a/xen/arch/arm/arm32/lib/bitops.c +++ b/xen/arch/arm/arm32/lib/bitops.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/lib1funcs.S index f1278bd6c1399414b4fc28fd3c7d93b5db6156a4..8b766baa00437ff9bcf35490f3a1af09d2274e39 100644 --- a/xen/arch/arm/arm32/lib/lib1funcs.S +++ b/xen/arch/arm/arm32/lib/lib1funcs.S @@ -28,7 +28,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License -along with this program; see the file COPYING. If not, see . */ +along with this program; see the file COPYING. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm32/lib/lshrdi3.S b/xen/arch/arm/arm32/lib/lshrdi3.S index 88b9655282abde3598fc2396da24877c450d821b..e1470e657022dfa05e2e230f9da75cc38ca03605 100644 --- a/xen/arch/arm/arm32/lib/lshrdi3.S +++ b/xen/arch/arm/arm32/lib/lshrdi3.S @@ -21,7 +21,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License -along with this program; see the file COPYING. If not, see . */ +along with this program; see the file COPYING. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/bpi.S b/xen/arch/arm/arm64/bpi.S index 4e638252204893ce8fe38b81c45639d256f29be2..79831dc026243e1b5fd8e1af87a46b9eee4c02c7 100644 --- a/xen/arch/arm/arm64/bpi.S +++ b/xen/arch/arm/arm64/bpi.S @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/cache.S b/xen/arch/arm/arm64/cache.S index 9a88a2b49731f2196cae99112bc3b5b33548c179..01f514c169251e9d58fa0b71a23ffb1ce425d135 100644 --- a/xen/arch/arm/arm64/cache.S +++ b/xen/arch/arm/arm64/cache.S @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/debug-meson.inc b/xen/arch/arm/arm64/debug-meson.inc index e65e1ccde4823521b275de7f133c2db12fbde693..67e91fee21d61f712ed9d13efb30e2d3d124eaeb 100644 --- a/xen/arch/arm/arm64/debug-meson.inc +++ b/xen/arch/arm/arm64/debug-meson.inc @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define AML_UART_WFIFO_REG 0x00 diff --git a/xen/arch/arm/arm64/debug-mvebu.inc b/xen/arch/arm/arm64/debug-mvebu.inc index 63b12dc3d37bb429a1eda25731b75b8126d0c279..72edc5e23ce721e74d686da90a4da21246c0eb0e 100644 --- a/xen/arch/arm/arm64/debug-mvebu.inc +++ b/xen/arch/arm/arm64/debug-mvebu.inc @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define UART_STATUS_REG 0x0c diff --git a/xen/arch/arm/arm64/insn.c b/xen/arch/arm/arm64/insn.c index 22f2bdebd544f7e5f789361844bf14e73f15c604..2f55c243f3b67e19ee201d73ee0dbf4047c33745 100644 --- a/xen/arch/arm/arm64/insn.c +++ b/xen/arch/arm/arm64/insn.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include #include diff --git a/xen/arch/arm/arm64/lib/bitops.c b/xen/arch/arm/arm64/lib/bitops.c index 20e3f3d6ceafc0f66310d6dccab1c78e3afd8702..6b638b7632d1dad5f2594d5acd46bf6e1b4d7a41 100644 --- a/xen/arch/arm/arm64/lib/bitops.c +++ b/xen/arch/arm/arm64/lib/bitops.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/clear_page.S b/xen/arch/arm/arm64/lib/clear_page.S index a767e63686d872210ca4f7c0aa3400868ec6f67d..2185c0987e1c630d5eed09344b2e88d8df0833a1 100644 --- a/xen/arch/arm/arm64/lib/clear_page.S +++ b/xen/arch/arm/arm64/lib/clear_page.S @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memchr.S b/xen/arch/arm/arm64/lib/memchr.S index 81f113bb1cabbc240d3b04fa427f37bb4dc86531..0becb12666288bd9cab299ec4590b5f70873752e 100644 --- a/xen/arch/arm/arm64/lib/memchr.S +++ b/xen/arch/arm/arm64/lib/memchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/memcmp.S b/xen/arch/arm/arm64/lib/memcmp.S index d9cd1d786f34a0a2b79483d7f7672f44b244f3e7..85c02580ceccdd12db0bed9aca604146a61e9a31 100644 --- a/xen/arch/arm/arm64/lib/memcmp.S +++ b/xen/arch/arm/arm64/lib/memcmp.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/memcpy.S b/xen/arch/arm/arm64/lib/memcpy.S index e7a667c2be280d9a5a4b8d991cbbf645ace5374e..b6bd157ca4da645f4df5b0b3fc0d55fdeebf1681 100644 --- a/xen/arch/arm/arm64/lib/memcpy.S +++ b/xen/arch/arm/arm64/lib/memcpy.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memmove.S b/xen/arch/arm/arm64/lib/memmove.S index 35d9b62fa0bb2430f65def7b0c0fc8e6cb04dec3..00e790e5c03d5f985bd7272c717a5ceac5a3fb08 100644 --- a/xen/arch/arm/arm64/lib/memmove.S +++ b/xen/arch/arm/arm64/lib/memmove.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memset.S b/xen/arch/arm/arm64/lib/memset.S index 5ce1db2e76e4a06bb51e8b5acc9f3ae0cb9313c4..d4c906ec409fb039c68129c7fab3b04c45f87961 100644 --- a/xen/arch/arm/arm64/lib/memset.S +++ b/xen/arch/arm/arm64/lib/memset.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/strchr.S b/xen/arch/arm/arm64/lib/strchr.S index 0506b0ff7f3aef45d2ef9932d071a7100253b5f4..e3fd8a263cec7d9ea1de5227891bffa4f070e759 100644 --- a/xen/arch/arm/arm64/lib/strchr.S +++ b/xen/arch/arm/arm64/lib/strchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strcmp.S b/xen/arch/arm/arm64/lib/strcmp.S index 5492a8482fa59e0463042f2deb4ef3ca515f24d5..793da9658b64b343b962b9ea47ecc51b317d4eae 100644 --- a/xen/arch/arm/arm64/lib/strcmp.S +++ b/xen/arch/arm/arm64/lib/strcmp.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/strlen.S b/xen/arch/arm/arm64/lib/strlen.S index d8d513d18f87d5ff36539dfd6f85dece8ba9ec66..439d4c0c9f5caf2fde899c8c1844b2b82bb84b7a 100644 --- a/xen/arch/arm/arm64/lib/strlen.S +++ b/xen/arch/arm/arm64/lib/strlen.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/strncmp.S b/xen/arch/arm/arm64/lib/strncmp.S index 90d3eb67055577f3d4514221d48ab69edcda202d..71c6a6404b1480c912b136bf072033c01a617851 100644 --- a/xen/arch/arm/arm64/lib/strncmp.S +++ b/xen/arch/arm/arm64/lib/strncmp.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strnlen.S b/xen/arch/arm/arm64/lib/strnlen.S index 9e2683790b1f33d3d12ec03f758c2c8a62f0baf1..4ad5c9a954e9bd969a9b3c328ff588d59b274702 100644 --- a/xen/arch/arm/arm64/lib/strnlen.S +++ b/xen/arch/arm/arm64/lib/strnlen.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strrchr.S b/xen/arch/arm/arm64/lib/strrchr.S index 07059983f828cdbe0b29cd615987172c8336fa8d..19118c6b9844a6e4613b1e5a6724a944c95a55dc 100644 --- a/xen/arch/arm/arm64/lib/strrchr.S +++ b/xen/arch/arm/arm64/lib/strrchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ /* diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c index aae0f979112ae8cd81d0dfd9785f14fa814aa411..fb75d7db75cf5c619087377961036a0a61112e8e 100644 --- a/xen/arch/arm/efi/efi-dom0.c +++ b/xen/arch/arm/efi/efi-dom0.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/include/asm/acpi.h b/xen/arch/arm/include/asm/acpi.h index e53973e0542b6aa7d8a32c325c47f343e2c4438b..3b61a82c31c297c08d0bb2f5221e8dba32fee3e0 100644 --- a/xen/arch/arm/include/asm/acpi.h +++ b/xen/arch/arm/include/asm/acpi.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/include/asm/altp2m.h b/xen/arch/arm/include/asm/altp2m.h index df50cb2f0988f344a5e1bf065157a0a98ece4db6..ed325988130686a7808b242edf162b3afbfaa517 100644 --- a/xen/arch/arm/include/asm/altp2m.h +++ b/xen/arch/arm/include/asm/altp2m.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_ALTP2M_H diff --git a/xen/arch/arm/include/asm/arm32/insn.h b/xen/arch/arm/include/asm/arm32/insn.h index c800cbfff544f5240a80e2635caf6ca742562784..48ee26fa02c8d7428b53e6ed66c5952431760afe 100644 --- a/xen/arch/arm/include/asm/arm32/insn.h +++ b/xen/arch/arm/include/asm/arm32/insn.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM32_INSN #define __ARCH_ARM_ARM32_INSN diff --git a/xen/arch/arm/include/asm/arm64/atomic.h b/xen/arch/arm/include/asm/arm64/atomic.h index 2d425678660b90f2417317bc66c16691b5679c12..fbc4bff39d15d3428b6d5c35e3484231aeeed7e9 100644 --- a/xen/arch/arm/include/asm/arm64/atomic.h +++ b/xen/arch/arm/include/asm/arm64/atomic.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM64_ATOMIC #define __ARCH_ARM_ARM64_ATOMIC diff --git a/xen/arch/arm/include/asm/arm64/insn.h b/xen/arch/arm/include/asm/arm64/insn.h index 4e0d364d412869615bb02a42a841db2eb717989b..44eb394b07b36ccbdbeaa6a0f031b0c73d262612 100644 --- a/xen/arch/arm/include/asm/arm64/insn.h +++ b/xen/arch/arm/include/asm/arm64/insn.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM64_INSN #define __ARCH_ARM_ARM64_INSN diff --git a/xen/arch/arm/include/asm/arm64/io.h b/xen/arch/arm/include/asm/arm64/io.h index 2e2ab24f7838b56c9fb9968f0a98f1e7a1c8e6b4..4f98dbbdfe4929f40c6c4409311f4a6d76d92ea7 100644 --- a/xen/arch/arm/include/asm/arm64/io.h +++ b/xen/arch/arm/include/asm/arm64/io.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef _ARM_ARM64_IO_H #define _ARM_ARM64_IO_H diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h index fae3f6ecefe99fe7841d1d1fef5b9cd6571f8634..7f2d125288167cfb923b24124ad13ff647623179 100644 --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_ARM_ITS_H__ diff --git a/xen/arch/arm/include/asm/iommu.h b/xen/arch/arm/include/asm/iommu.h index d57bd8a38ccd4b042e6a72d54bf326ebed411af9..c12a45e5c6a177b5e2da4006ab49836f000921e8 100644 --- a/xen/arch/arm/include/asm/iommu.h +++ b/xen/arch/arm/include/asm/iommu.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ARCH_ARM_IOMMU_H__ #define __ARCH_ARM_IOMMU_H__ diff --git a/xen/arch/arm/include/asm/iommu_fwspec.h b/xen/arch/arm/include/asm/iommu_fwspec.h index 5cdb53f8e84bd09b22bc03be9e4481717a5e715a..0cabb191c4da18e91ef8c3bdcfc6f981a201ac8c 100644 --- a/xen/arch/arm/include/asm/iommu_fwspec.h +++ b/xen/arch/arm/include/asm/iommu_fwspec.h @@ -21,7 +21,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ARCH_ARM_IOMMU_FWSPEC_H__ diff --git a/xen/arch/arm/include/asm/ioreq.h b/xen/arch/arm/include/asm/ioreq.h index 50185978d51621ec9978aef89f92226891433a88..fd1e775d10d9aa8e0bf16a3dd918dd36aaf38c04 100644 --- a/xen/arch/arm/include/asm/ioreq.h +++ b/xen/arch/arm/include/asm/ioreq.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_IOREQ_H__ diff --git a/xen/arch/arm/include/asm/mem_access.h b/xen/arch/arm/include/asm/mem_access.h index 35ed0ad15471c3a4e2eddc5810668c3ef152619b..7920f856822415149ed0cabc0aa919fed3ba81e7 100644 --- a/xen/arch/arm/include/asm/mem_access.h +++ b/xen/arch/arm/include/asm/mem_access.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _ASM_ARM_MEM_ACCESS_H diff --git a/xen/arch/arm/include/asm/monitor.h b/xen/arch/arm/include/asm/monitor.h index 7567be66bdc5b314943caaba73d9f891bafab43c..01619b6eefebc3a08f555ff37fe58417a87be379 100644 --- a/xen/arch/arm/include/asm/monitor.h +++ b/xen/arch/arm/include/asm/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ASM_ARM_MONITOR_H__ diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm/new_vgic.h index b7fa9ab11a0bb991cd475c6dadff650a73a4af4b..bac6f778dcdfae836cde88c39ef065cd8fd19fcd 100644 --- a/xen/arch/arm/include/asm/new_vgic.h +++ b/xen/arch/arm/include/asm/new_vgic.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ASM_ARM_NEW_VGIC_H #define __ASM_ARM_NEW_VGIC_H diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 8cb46f6b718597a8b620bb02e2097579d7e00f35..7c1f75970c474a3cb2724c3b66d03ce2d9e44c3a 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARM_PCI_H__ diff --git a/xen/arch/arm/include/asm/vm_event.h b/xen/arch/arm/include/asm/vm_event.h index abe7db1970cab6e102ae670f6ea15d7ddd7023e1..1cfcc46f1410a44ce13411a59a937d4d985e7dd8 100644 --- a/xen/arch/arm/include/asm/vm_event.h +++ b/xen/arch/arm/include/asm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_VM_EVENT_H__ diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/vpl011.h index c09abcd7a9b3356d0809743517934adae00087f5..61d66ed2f62827f47228ef57ed4fb886f662d7d7 100644 --- a/xen/arch/arm/include/asm/vpl011.h +++ b/xen/arch/arm/include/asm/vpl011.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _VPL011_H_ diff --git a/xen/arch/arm/include/asm/vpsci.h b/xen/arch/arm/include/asm/vpsci.h index 0cca5e6830b8c72963aa5607a38c0a09ae224aad..1b3546739242f738939b83482cbbd0386cceb997 100644 --- a/xen/arch/arm/include/asm/vpsci.h +++ b/xen/arch/arm/include/asm/vpsci.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_VPSCI_H__ diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c index 3987f96b01783e0d96b5c2b729bbea72bae0c57e..da1d19a9d8d2807f723af352c5adace68f25795a 100644 --- a/xen/arch/arm/pci/ecam.c +++ b/xen/arch/arm/pci/ecam.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index 9f9aac43d7e9b30e01b1afe1ecf37101981582bc..8a3a476eae2172d61cf13a5d56bf229bfac85761 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a8ece94303ca8070e8a6c2d5bc326ed4ae11d22a..e603dcf3d03f1d575078099ff4a80069cfaaf6ec 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c index 46de6e43cc722adda4a20aa9e1cead2a528ddca3..ab262f0f7678c73cc03a181d3904e9074732da67 100644 --- a/xen/arch/arm/pci/pci-host-generic.c +++ b/xen/arch/arm/pci/pci-host-generic.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c index 101edb8593c1e9b3647b00aaccf1b44c56ebb2f1..1d63769bace8520bcd995ac37fb094628f505c9f 100644 --- a/xen/arch/arm/pci/pci-host-zynqmp.c +++ b/xen/arch/arm/pci/pci-host-zynqmp.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c index 78b97beaef12e85771602af4b296e075596affb7..1cc61272e02a32bc3f541aa80dacf5d42922a6b0 100644 --- a/xen/arch/arm/pci/pci.c +++ b/xen/arch/arm/pci/pci.c @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/platforms/thunderx.c b/xen/arch/arm/platforms/thunderx.c index 9b32a29c6b05eff94847189c1de7b69609720a9f..f46f3344294123091bb7d857a480dd385e2f38d5 100644 --- a/xen/arch/arm/platforms/thunderx.c +++ b/xen/arch/arm/platforms/thunderx.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic-init.c b/xen/arch/arm/vgic/vgic-init.c index 62ae5536997be5d0be7eae2cbc9e89be63d81185..dfbe1b03f1c1cd1bfd8aeeff3d0a602a1843d6da 100644 --- a/xen/arch/arm/vgic/vgic-init.c +++ b/xen/arch/arm/vgic/vgic-init.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic-mmio.h b/xen/arch/arm/vgic/vgic-mmio.h index 3566cf237cee2c15bde3fb32e9a3b12c98cb1e1d..2203f87dd835271b6671cb2503100853267621cc 100644 --- a/xen/arch/arm/vgic/vgic-mmio.h +++ b/xen/arch/arm/vgic/vgic-mmio.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __XEN_ARM_VGIC_VGIC_MMIO_H__ #define __XEN_ARM_VGIC_VGIC_MMIO_H__ diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c index 1a99d3a8b48446cbd031e325c941580e8a9ec7a8..11efab7b3e074b375177dbfc63e4c051d1bf2681 100644 --- a/xen/arch/arm/vgic/vgic-v2.c +++ b/xen/arch/arm/vgic/vgic-v2.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index f0f2ea502195901d6c9654f00ae9e330eff95215..b4a177106dc497642d780b91ca99f82b2cc51481 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic.h b/xen/arch/arm/vgic/vgic.h index 534b24bcd3f431a389cb866747535929e5622a8b..c2a1bef3dd9d0ac997205270401e978917133c71 100644 --- a/xen/arch/arm/vgic/vgic.h +++ b/xen/arch/arm/vgic/vgic.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __XEN_ARM_VGIC_VGIC_H__ #define __XEN_ARM_VGIC_VGIC_H__ diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 54b72d716beda91bfee09b62e6e7e8ba12ece5c8..4e04bf4d6177c455959cc89f535cb0e054f0685b 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c index 427c8c89c5c438d610de3470f0daf1840c7cb0ee..ec879af0c10452a5159a0a9379dd816c650f1cd6 100644 --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -25,7 +25,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index c27cbb2304f27dbb0dbde0b74322a006d860dccc..c21794715cebef404ba9da17692bf6bffabbc49b 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -22,7 +22,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c index d4c7dcd5d99d239462ba6c523a94ee8e970ba141..3fb3e1a5faf6fa937086606957042728083d5364 100644 --- a/xen/arch/x86/acpi/cpufreq/powernow.c +++ b/xen/arch/x86/acpi/cpufreq/powernow.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpuidle_menu.c b/xen/arch/x86/acpi/cpuidle_menu.c index a275436d799c9440f3895d00cbf9bec48ce15b9d..66d95fc1450a0e2d11d70ceb76bb594db5738e9b 100644 --- a/xen/arch/x86/acpi/cpuidle_menu.c +++ b/xen/arch/x86/acpi/cpuidle_menu.c @@ -18,7 +18,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c index 43831b92d1322ba4cc3c65ceebc7e88bcfefe484..895b52c3ab1f9e325b594199c49d7e45e6e38382 100644 --- a/xen/arch/x86/acpi/lib.c +++ b/xen/arch/x86/acpi/lib.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 0c6fc7b4fb0cb3d961f020dade3e3d42fede5c40..f715bcf1575c2d1ec7860481cdabd57257787de7 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/boot/build32.lds b/xen/arch/x86/boot/build32.lds index 56edaa727be77424d09f0e525be76f7c7b0403c2..a00183a28b8c63d9a523e5d5f79a0f58303072cd 100644 --- a/xen/arch/x86/boot/build32.lds +++ b/xen/arch/x86/boot/build32.lds @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . */ ENTRY(_start) diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c index fc11c6d3c5c45fc8cdcd51ddd12923bfee3c0447..ffd5d060686e2b01ea74ea0418ac7f01e86feae2 100644 --- a/xen/arch/x86/boot/cmdline.c +++ b/xen/arch/x86/boot/cmdline.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . * * strlen(), strncmp(), strchr(), strspn() and strcspn() were copied from * Linux kernel source (linux/lib/string.c). diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec69636525e3a028058328d1dca2f324..95cfb053b7a827308680884331315c927a7b67b4 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . * * max() was copied from xen/xen/include/xen/kernel.h. */ diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c index be44d7f611b1c06ce00dd5ff73c696b3d616ccd1..c9d124ec9901f5eff26e4c68cb5abb4b8fa6203a 100644 --- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c +++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/arch/x86/cpu/mcheck/mce-apei.c b/xen/arch/x86/cpu/mcheck/mce-apei.c index 53b6735896bf105e22f38400f8a02e1ed422a5a2..1e21265fd510b647be80dc56090ddf1711c6d2fc 100644 --- a/xen/arch/x86/cpu/mcheck/mce-apei.c +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c @@ -25,7 +25,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index 98c630fc86295ca38e248f9db8329e2a15794bda..67ea5db8c0c8754bd1c19cb03585f74539d13db5 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* K8 common MCA documentation published at @@ -24,7 +24,7 @@ * Issue Date: October 2013 * * URL: - * https://support.amd.com/TechDocs/24593.pdf + * https://support.amd.com/TechDocs/24593.pdf */ /* The related documentation for K8 Revisions A - E is: @@ -35,7 +35,7 @@ * Issue Date: February 2006 * * URL: - * https://support.amd.com/TechDocs/26094.PDF + * https://support.amd.com/TechDocs/26094.PDF */ /* The related documentation for K8 Revisions F - G is: @@ -46,7 +46,7 @@ * Issue Date: July 2007 * * URL: - * https://support.amd.com/TechDocs/32559.pdf + * https://support.amd.com/TechDocs/32559.pdf */ /* Family10 MCA documentation published at @@ -57,7 +57,7 @@ * Isse Date: January 11, 2013 * * URL: - * https://support.amd.com/TechDocs/31116.pdf + * https://support.amd.com/TechDocs/31116.pdf */ #include diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c index af30811afd445fe38d629f5fa220a868861cf6a6..a8d3aa68ae7beef9fb6ced8c1729883f69f07cad 100644 --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/cpu/mcheck/x86_mca.h b/xen/arch/x86/cpu/mcheck/x86_mca.h index 8f7fced0fee057326ef7d87699b1b5ab9d5fb170..420dabf288f3a6bef73b5473a822f50f46cd7b62 100644 --- a/xen/arch/x86/cpu/mcheck/x86_mca.h +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef X86_MCA_H diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c index 2946003b84938f3b83c98b62dfaa3ace90822983..88ee0f8444227287b57ba8018e4343720a555346 100644 --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -14,7 +14,7 @@ Library General Public License for more details. You should have received a copy of the GNU Library General Public - License along with this library; If not, see . + License along with this library; If not, see . Richard Gooch may be reached by email at rgooch@atnf.csiro.au The postal address is: diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c index 9e981e7e26dceff1a75c76b073a59a3fc0dcc800..78d2e7bb65911b78f0792c9bbc0b0b02f26199ed 100644 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ /* diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index b6b7342fb466e4ad2240516c0c3afc21472566e7..9b85e443ebf83bd73f31f41aaa32c8248aa577cc 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 58794a16f06cd4041935922a51eb813a364a5d14..112409cbcc898f04dc83017616bcbbab0feae1ec 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index a8df52579db8e455b24f2f4a89367cbfe81d77ab..f3f855e7c3e90e40f7ba77a90aaf309b80c85487 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c index 961cae0be74f5514eb2f05536727786a74f9e250..6a7ad0f5578d11af14dda92d07d7a82ad0313c2c 100644 --- a/xen/arch/x86/gdbstub.c +++ b/xen/arch/x86/gdbstub.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include #include diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c index 6ef46e8ea77d8de3178ff50340bdf4fa2d0b9d95..e7b20a7202a1133ea14be39aab0538465e2748e3 100644 --- a/xen/arch/x86/gdbsx.c +++ b/xen/arch/x86/gdbsx.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c index f73390cdb017caae149d2e1057723958a66ee7ae..36a30ec43e86b59c2135d1c4bdb2938038f51370 100644 --- a/xen/arch/x86/genapic/x2apic.c +++ b/xen/arch/x86/genapic/x2apic.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c index b101ba3080b44a95cadd893c521454eb321572e6..f28df2cb45f8f67f3a16157345edd9051f9e79b0 100644 --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/private.h b/xen/arch/x86/guest/hyperv/private.h index fea3e291e944ef8d22de7c8da7dd4f488167c428..a33e2501ff53ed9042a64a23a33431ea1125cbeb 100644 --- a/xen/arch/x86/guest/hyperv/private.h +++ b/xen/arch/x86/guest/hyperv/private.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/tlb.c b/xen/arch/x86/guest/hyperv/tlb.c index f249b259253daaa747dee5989d9f7d85a3be3846..986b8083cfae508cf27a4c886138a693892036b2 100644 --- a/xen/arch/x86/guest/hyperv/tlb.c +++ b/xen/arch/x86/guest/hyperv/tlb.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/util.c b/xen/arch/x86/guest/hyperv/util.c index 2c5f421b7bd9a5039ba59653a09b1e06700b2a3d..2db9b68136b31d5b3aef2467450c44cab5929217 100644 --- a/xen/arch/x86/guest/hyperv/util.c +++ b/xen/arch/x86/guest/hyperv/util.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c index 366af1d6500104dd97ca592c1a5a6d58bb4296f7..b4e01a25018513585fbc73bd04364bc1e85d920c 100644 --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 498625eae0a3f065c41366aa8b51c2e571c6ca63..45af2a7caa3066ad8805e1fed409f40c931e18ca 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index 9c2defaa6621864e359ea45e554ae8322c1d4610..417cd713ec29a4161c4b7d50fb473a139d6cadf5 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/hvm/asid.c b/xen/arch/x86/hvm/asid.c index 1fd2770a3ae062031687b4d9b0d38f9516f5b0d2..b4ea2d90c030b6fd6dcc33cac1518aec0d5f96fa 100644 --- a/xen/arch/x86/hvm/asid.c +++ b/xen/arch/x86/hvm/asid.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index f8e6089870b01b45fb88739658b17fae92b687ec..fd66243984cbe955eecfa7cdbd3a79d069b30294 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 3ac6b7b423b10fae313950a1d443e6e2fb42ad39..8d7cfc074f6b25496a6b99baf685c6b5e816b970 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c index 10e30175a1b6865d4924d08e5baf357794342cb7..82308a5cdb91f2a854fbd9a21e098246641e5072 100644 --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/grant_table.c b/xen/arch/x86/hvm/grant_table.c index b7a896ea5855f4ae1c99e26b204b69a610ee2338..fa23d5ad83257493783fde4c916c7b5d4be7a654 100644 --- a/xen/arch/x86/hvm/grant_table.c +++ b/xen/arch/x86/hvm/grant_table.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index c65e1b27d09ea5931fc13919697de088c1b9a8fe..60be48f6cf6347c5a8b51590b9397214a0621c90 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5c1e64189600df7d5c700ea500cf4afce12391ca..9339fc94bec0354eaff1b79b391d6139faf8a02d 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c index 405d0a95afd8ef77d298f3d4dd261ba3cd3f7920..2fef069930318ddc4aa50e7baab9332d67a1ea97 100644 --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c index ffa31b7467161054c7b8b0f156d088f51c642f6e..e028f96b6ee46d3834b8803d81718eeed2115e4e 100644 --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 5ae209d3b6b3a5453290320d83bc09a9a3c6c8cd..9f16521c4449a3240e18638fca1cb2a96528e76c 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 0bdcca1e1a5f68d213cb9a73637df4610c8d68aa..67427efe4dd9de2c2397358a6009dc0428deced8 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 4fe87a71c12b36bd88233c061130105317a1654c..2ceed080e99deff38806c416ffcc0a77064fbd49 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c index a11cd76f4d18003012ae502b0bd0fc6c408fcf9b..ddd83ba6cd8d36ef82c4d1818e21f8c0f94b50e9 100644 --- a/xen/arch/x86/hvm/monitor.c +++ b/xen/arch/x86/hvm/monitor.c @@ -19,7 +19,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 344edc2d6a96e4c9ab2aa68b2f40c51853ca2e6a..23382e936f43178dcb997b4f35c5bd680c0d0985 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c index 58370190ffc91fc9fc277e4f3532e09e4719bbbd..bfbba9df2ac4c63dc8be93296547fad6931e9fe1 100644 --- a/xen/arch/x86/hvm/nestedhvm.c +++ b/xen/arch/x86/hvm/nestedhvm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index b89d0fd53ba16422792af9940a0fa1fac577f772..b4b33747225e6c1a96137493ecb8fd1d4483cd2b 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c index 2adab1f4b84b459c443029d129b69c22f8e6d44b..ef084b1d9659bfaa8e18877b694e1e2fd0673919 100644 --- a/xen/arch/x86/hvm/quirks.c +++ b/xen/arch/x86/hvm/quirks.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index c1675e3d9fb097ec88eda0b333cc6c0f6561d326..d0918b492916bf32de5e9f552d74fd493616da60 100644 --- a/xen/arch/x86/hvm/save.c +++ b/xen/arch/x86/hvm/save.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index ab06dd3f3ae27d0c7f1e42dca429e275aa980032..d18ee50c2d0467bdc8ea018922578e40e1a3a728 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883cff49c1fc335cbfbabc321d371295d..089cd946f55b9e4d3b39f36e1ae3fa45f8650b62 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 981cd82e7c0b2bab093476c38b9e29d7e58a2d3c..6e1ed4a3f8a0740dce835c2fe6d9d09d79779d77 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ .file "svm/entry.S" diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 9525f3559392de8063bca90fd5000db82499ec06..ca4a6ccec0c0ebd954819f2c5183e0d251f24ab7 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 9f5f35f16aff2a11320a3719b0668ab57776b610..8bcfc65dc4f5304d47511c79771fe00dc5e02fc6 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index fa7325720328ba562948c8e921ee2ce8e1bde20f..1713966530d0bb3905e39268f340f05f565258c4 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index bce86f0ef706d5f1baeb21943cf3028d283cd6c5..4de3480737b18a8ee678df936290f87d1ac0e019 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e38726540a637c1a2d7f9f2c6c482e2c..88b5d745c0efde3a21ea6755905214583a9d0d4b 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 864f6a84e6173f1414cbf3eb54e3ee08fb78179b..adc1b2a2fd1f255e44e77cefb28d72541068b62b 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Yunhong Jiang * Ported to xen by using virtual IRQ line. diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d149c1a23ed8e8495d982a27cc367e6..031c04a61b7de6e09846d143a82dc1bb2b656958 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vm_event.c b/xen/arch/x86/hvm/vm_event.c index 19aac19bc35406675624c0cd7e64f78f10bf8005..867a0eb902148bf069324069e14d97c2ae5b07a1 100644 --- a/xen/arch/x86/hvm/vm_event.c +++ b/xen/arch/x86/hvm/vm_event.c @@ -17,7 +17,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 969678f94244df4c6a6671015f8e766e27aa8fbe..ff2a5fa04226a889504e3b741e80b24dae570717 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Support for virtual MSI logic * Will be merged it with virtual IOAPIC logic, since most is the same diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index 5f5de45a1309c7d667cc6755e7f3da269c3de9a9..3ee68881a0fdbae73981193a69ab1998a61bd857 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ .file "vmx/entry.S" diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e25bc894918da392675076d91ef143b..e5e88f9dbd3d32ba58a5761fe49f71e10c80f7b9 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 09edbd23b3990dd88994f716145da07778f29cd3..edc99e6106d3555c1a9d97870ca4928fb9f78863 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index ade2a25ce7c20bb0220630b7b70ab0a13b1072e8..af76300a4d76ebb7a1d4ec7cd33cc30bf3ffa629 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb073672e371e1546efc9f573087bfe435..50779030b4c55a73376c2d24017bf02d716cbc0c 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 621f5bb88b63850a4f4acbd39c5a66f7fe421568..05b1c37ca244aec58b04e39135d0bf4ad54dfbd7 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c index 6b73cff9b9ff3fb271836b97aac28f0fa9d389c9..b087621726720bc66171163144c0c62ced582100 100644 --- a/xen/arch/x86/hypercall.c +++ b/xen/arch/x86/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2015,2016 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 6ce79ce465b45b336138786a4fa8694e2c029b44..52bf6423b905e5e36714efe1b582e72463d372d4 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/include/asm/altp2m.h b/xen/arch/x86/include/asm/altp2m.h index b206e95863a63d35324778695300f668a1050327..d5914d6a96f1d060d77d8bf28d1d640225296beb 100644 --- a/xen/arch/x86/include/asm/altp2m.h +++ b/xen/arch/x86/include/asm/altp2m.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_ALTP2M_H diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h index d946fac131306049b44d8e52f2a0f9cf1bb3c5f4..46f02fd0812ca6dc85e8cda717194b2e0509c93f 100644 --- a/xen/arch/x86/include/asm/endbr.h +++ b/xen/arch/x86/include/asm/endbr.h @@ -10,7 +10,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2021-2022 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest.h b/xen/arch/x86/include/asm/guest.h index ccf1ffbb729af6aeb4dc8259ab26dd610ade69a1..9aa3edcca571ae4ae275715db44cf2dd62e9a78c 100644 --- a/xen/arch/x86/include/asm/guest.h +++ b/xen/arch/x86/include/asm/guest.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv-hcall.h b/xen/arch/x86/include/asm/guest/hyperv-hcall.h index 423ca0860b5d517a48b81a86240b898a31f913f1..fb2ab0e341f51dd1974f66d7959bc383d366a8d0 100644 --- a/xen/arch/x86/include/asm/guest/hyperv-hcall.h +++ b/xen/arch/x86/include/asm/guest/hyperv-hcall.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv.h b/xen/arch/x86/include/asm/guest/hyperv.h index 1a1b47831c8d602f568636053a69da0ab863f4ba..783baced2f5177f16c7875896b15e1d7a2f34abb 100644 --- a/xen/arch/x86/include/asm/guest/hyperv.h +++ b/xen/arch/x86/include/asm/guest/hyperv.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h index 0a6c3b47ab36cb4a1f6dffdef1e7535c96c49638..e966926a934ec31c3bfdd715ba505a058abcc35c 100644 --- a/xen/arch/x86/include/asm/guest/hypervisor.h +++ b/xen/arch/x86/include/asm/guest/hypervisor.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 48ffd1a0b1b40a8729e4cea9f045af978567173c..bedf8ba86779cd4c087549503feae4b081f8cd2d 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen-hcall.h b/xen/arch/x86/include/asm/guest/xen-hcall.h index 03d5868a9efd698353d22578abc19c503fa84038..f6f0d576d3629df8e6e7475dca3ad2d51f8505b2 100644 --- a/xen/arch/x86/include/asm/guest/xen-hcall.h +++ b/xen/arch/x86/include/asm/guest/xen-hcall.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen.h b/xen/arch/x86/include/asm/guest/xen.h index 2042a9a0c2537bcacfe781e8bad0cb42cf069dfa..ea46d83de7865825272aab1d322ad7ec49989211 100644 --- a/xen/arch/x86/include/asm/guest/xen.h +++ b/xen/arch/x86/include/asm/guest/xen.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index 6802db2a415a9c3aa0faf55f8e5ee97c83cdc4f9..15c2d9383fa542f886b32b1fc82fa0ad9a0256dd 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -22,7 +22,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_ASM_GUEST_PT_H diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 90dece29decad0dba7f7682a498493a06baa904f..9d7e2bbaf020ec76cb2b58c076f22dea9c513d82 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_HAP_H diff --git a/xen/arch/x86/include/asm/hvm/asid.h b/xen/arch/x86/include/asm/hvm/asid.h index 633ddb72e494a85e42200298db4cda585d3a374a..f1e5525c8301f215709300d43c4dea8007041b6b 100644 --- a/xen/arch/x86/include/asm/hvm/asid.h +++ b/xen/arch/x86/include/asm/hvm/asid.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444ea85b691126c3e8a31c08bbd48acb25..c5152049ed30799e1dffa4a309058cab180b2dcb 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/hvm/grant_table.h b/xen/arch/x86/include/asm/hvm/grant_table.h index a5612585b35e520a87f0566a1f49d4574a34681f..342631b170c7cfc0ae452c93d8a3b5b7f2b3928b 100644 --- a/xen/arch/x86/include/asm/hvm/grant_table.h +++ b/xen/arch/x86/include/asm/hvm/grant_table.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_HVM_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 65768c797ea7547f50962af5b1a379a8c275a47c..d92ecbdc7c805bc37ffd33c60f18292f43885596 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_HVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h index 54e0161b492c3714f13112e0ebffa91dbc9e0229..3253c68a82a787c8ad3748c42551d6f26f2c559b 100644 --- a/xen/arch/x86/include/asm/hvm/io.h +++ b/xen/arch/x86/include/asm/hvm/io.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IO_H__ diff --git a/xen/arch/x86/include/asm/hvm/ioreq.h b/xen/arch/x86/include/asm/hvm/ioreq.h index 9b2eb6fedf99bafd52c1395dca6887d4107460ae..9bd11077393cff0390130321db369adc529d52e8 100644 --- a/xen/arch/x86/include/asm/hvm/ioreq.h +++ b/xen/arch/x86/include/asm/hvm/ioreq.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/irq.h b/xen/arch/x86/include/asm/hvm/irq.h index c4369ceb7aaaf5f3e50af0913ee8b78b81501d3a..fde58a7734a3d04bc7a6de63b40f539d94ca7e2b 100644 --- a/xen/arch/x86/include/asm/hvm/irq.h +++ b/xen/arch/x86/include/asm/hvm/irq.h @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IRQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h index 639f6dfa374cf18b9f9088bd45007c1962eb452f..61358dcc055dbf9746f759db29d812eeb3f1f241 100644 --- a/xen/arch/x86/include/asm/hvm/monitor.h +++ b/xen/arch/x86/include/asm/hvm/monitor.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_MONITOR_H__ diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h index 7184928c2bb179a424554cdab534f0373305a9a9..0b179f58192e5025e2f47e1824b6a058ac1100be 100644 --- a/xen/arch/x86/include/asm/hvm/nestedhvm.h +++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _HVM_NESTEDHVM_H diff --git a/xen/arch/x86/include/asm/hvm/save.h b/xen/arch/x86/include/asm/hvm/save.h index e975011ddb7112a2286242468a3df79c6a410d7b..39debb0a764b308c60a476abfeeb8f112282c4c6 100644 --- a/xen/arch/x86/include/asm/hvm/save.h +++ b/xen/arch/x86/include/asm/hvm/save.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_HVM_SAVE_H__ diff --git a/xen/arch/x86/include/asm/hvm/support.h b/xen/arch/x86/include/asm/hvm/support.h index 6b583738ecb5667c8bf3fa3545e0b02cfbec179b..fd2a51c4f6ca25ae0392a80fb2af82e6b5d1e3a9 100644 --- a/xen/arch/x86/include/asm/hvm/support.h +++ b/xen/arch/x86/include/asm/hvm/support.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SUPPORT_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h index 0e5ec3ab788a578121b4c4eb2f88757718bc5991..70acd037b5d235c68737a974b75184e1587a44fc 100644 --- a/xen/arch/x86/include/asm/hvm/svm/asid.h +++ b/xen/arch/x86/include/asm/hvm/svm/asid.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/include/asm/hvm/svm/emulate.h index eb1a8c24af6d23ddb20ab2d346ea8e9165538de0..f1bdeff74fd5ad436766c337d7202602c863a642 100644 --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h +++ b/xen/arch/x86/include/asm/hvm/svm/emulate.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_EMULATE_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/intr.h b/xen/arch/x86/include/asm/hvm/svm/intr.h index ae52d9f948b127c7cff5c27a33f0719be159e297..817e5a713978cfd1a60f7951994f7e207e3a398d 100644 --- a/xen/arch/x86/include/asm/hvm/svm/intr.h +++ b/xen/arch/x86/include/asm/hvm/svm/intr.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 656d7d1a9a71ac5144115523a91204ed9c2729ef..3a5615dbaa205fe94bb462d1abc3df736a56602a 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_SVM_NESTEDSVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59b76bcd412ec409565193501618599b..6ce1f59ca788c8e2aae55eedf6f976f82f5851d5 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h index 330c1d91aad54a2ca47e28a67c44d58c465459ab..d4544c589de8a65141226738b6215cc04f5ea050 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h +++ b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index e87728fa81cd26fe014dd3eb47d622105063760f..ce33d4cc72d9616de774b7bf62f686d494a705ec 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_SVM_VMCB_H__ diff --git a/xen/arch/x86/include/asm/hvm/vcpu.h b/xen/arch/x86/include/asm/hvm/vcpu.h index 8adf4555c2ab491980c0de823d424be15219413c..577ca66752f10ee31f869271b045bf8247df34b9 100644 --- a/xen/arch/x86/include/asm/hvm/vcpu.h +++ b/xen/arch/x86/include/asm/hvm/vcpu.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VCPU_H__ diff --git a/xen/arch/x86/include/asm/hvm/vioapic.h b/xen/arch/x86/include/asm/hvm/vioapic.h index 4e0166f160575554f9619911b0cc4b4b082bada3..60fa3659113b1045c01ca6cdbfaf4799a76f9b49 100644 --- a/xen/arch/x86/include/asm/hvm/vioapic.h +++ b/xen/arch/x86/include/asm/hvm/vioapic.h @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef __ASM_X86_HVM_VIOAPIC_H__ diff --git a/xen/arch/x86/include/asm/hvm/vlapic.h b/xen/arch/x86/include/asm/hvm/vlapic.h index 8f908928c35c824359c0a998133a4675767b32ed..8905858a8fbfed0355974fecc83811920e444b49 100644 --- a/xen/arch/x86/include/asm/hvm/vlapic.h +++ b/xen/arch/x86/include/asm/hvm/vlapic.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VLAPIC_H__ diff --git a/xen/arch/x86/include/asm/hvm/vm_event.h b/xen/arch/x86/include/asm/hvm/vm_event.h index 28cb07ce8ff608212ccacd3140cf1b9423cadceb..714b8dd38984fd303660f4f504641a5bccdfc9eb 100644 --- a/xen/arch/x86/include/asm/hvm/vm_event.h +++ b/xen/arch/x86/include/asm/hvm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e744780543e3350694d376644c06af88b7d0..dc316cdf89b74e0616feb433ecb4e34acad4468f 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VMX_VMCS_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f4459b70d9f14d9e8267af3902e49339..9d33e6e200de018080c588c72cce3268b0ccfaed 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VMX_VMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h index 2c3adb5dd6b348475875ff2835653f8f4297b56d..7d1c415ec17a1153c8c33f5744a199969fa04e5a 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VVMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h index 74c0cedd11cce8567c12aef946ef4fad4c5a647f..193e0d01cd6c00cc1f8bc2037d7bd9a77c9f7adf 100644 --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VPT_H__ diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h index fc0afe35bf6b9160f3514797e1d8c8203fd74230..bc43c3a35993cd7771f7360c88943a10ed976529 100644 --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ARCH_X86_IOMMU_H__ #define __ARCH_X86_IOMMU_H__ diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h index d06ce9a6ea56ef4e6528872be2029a3177b8b313..5b659fb345382c4b45e794c8f1ad2a4ba90e4e8d 100644 --- a/xen/arch/x86/include/asm/ioreq.h +++ b/xen/arch/x86/include/asm/ioreq.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h index 18091610aea0439f7ad7bd60b2f205a3404aa99b..615eac2f8c3d72bd9c799e062bfd8f4f379bf84a 100644 --- a/xen/arch/x86/include/asm/mem_access.h +++ b/xen/arch/x86/include/asm/mem_access.h @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_ACCESS_H__ diff --git a/xen/arch/x86/include/asm/mem_paging.h b/xen/arch/x86/include/asm/mem_paging.h index d3635e96cffc0bb18efe2b865b3fee03bf537dad..67ebddbbe33be779a5acc965f1a0648ea228d6f3 100644 --- a/xen/arch/x86/include/asm/mem_paging.h +++ b/xen/arch/x86/include/asm/mem_paging.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_PAGING_H__ diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h index 2c00069bc91ce53b0e04b3eeb89e35c15fcf2676..5ed531af16a14a551a6cc48c1cdc5fa3787e3dde 100644 --- a/xen/arch/x86/include/asm/mem_sharing.h +++ b/xen/arch/x86/include/asm/mem_sharing.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __MEM_SHARING_H__ #define __MEM_SHARING_H__ diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h index d8d54c5f23d691fd1af049680552b11fd7b2267f..11ecd70b41831c1930256feb4a30fdf388814f13 100644 --- a/xen/arch/x86/include/asm/monitor.h +++ b/xen/arch/x86/include/asm/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ASM_X86_MONITOR_H__ diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h index bd684d02f3676fba3b39b347e27556040fc36aa8..4b71075fe91400ab754cd5038b5ed29e9d05712a 100644 --- a/xen/arch/x86/include/asm/p2m.h +++ b/xen/arch/x86/include/asm/p2m.h @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_ASM_X86_P2M_H diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h index 8c0b0ef29a10d1199ea92c3bc8084a83b18c91e9..480f4aeefef094c02311e2d93a9429511a674ba3 100644 --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_PAGING_H diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h index 924508bbb4f0c199b3cd2306d9d8f0bd0ef399f9..77800439a187b7cc43355b1d445b4f7499854f43 100644 --- a/xen/arch/x86/include/asm/pv/domain.h +++ b/xen/arch/x86/include/asm/pv/domain.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/pv/grant_table.h b/xen/arch/x86/include/asm/pv/grant_table.h index 85442b60749f6b17195eb9925887f9c98ae6a28b..72afc193abd5970b0d72fa317836722f29e630d8 100644 --- a/xen/arch/x86/include/asm/pv/grant_table.h +++ b/xen/arch/x86/include/asm/pv/grant_table.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/pv/mm.h b/xen/arch/x86/include/asm/pv/mm.h index 9983f8257c63fa492120662d10ec192366560216..912b006875aaae76f2872ccddae3c766c1da4ec1 100644 --- a/xen/arch/x86/include/asm/pv/mm.h +++ b/xen/arch/x86/include/asm/pv/mm.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_MM_H__ diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h index a43c3689b48aa85ce6a413a8b5df3d9540475966..22acad0233ccaf9213e47e248064be9bfa8e0444 100644 --- a/xen/arch/x86/include/asm/pv/shim.h +++ b/xen/arch/x86/include/asm/pv/shim.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/pv/traps.h b/xen/arch/x86/include/asm/pv/traps.h index 855203c4e288bd7f1dd12d62dbfcb5379e5b69ca..f64993b2a349a8d403c86df0bbf86835cea2ec53 100644 --- a/xen/arch/x86/include/asm/pv/traps.h +++ b/xen/arch/x86/include/asm/pv/traps.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_TRAPS_H__ diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h index 1365fe48051827acc3cac2a9640d4e1b560c5309..d83d705f3aca08a6807c234e65ac690fed506e3b 100644 --- a/xen/arch/x86/include/asm/shadow.h +++ b/xen/arch/x86/include/asm/shadow.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_H diff --git a/xen/arch/x86/include/asm/shstk.h b/xen/arch/x86/include/asm/shstk.h index fdc9cc65a3fa6d673e5a79149a1d451a019d0126..4c580a34976c343826a2c79bedb291a2efee9437 100644 --- a/xen/arch/x86/include/asm/shstk.h +++ b/xen/arch/x86/include/asm/shstk.h @@ -10,7 +10,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2022 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index e928596450f7ba65f6af9c005dbb1a1609dd6c95..b480db11ad5c3a7914020fdb49fc46d613c8af40 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532be63d849f5eb94d47d9cb30bb3b67..18245921c27c7f4618a04ac46fc1c2a0c8dd6467 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/traps.h b/xen/arch/x86/include/asm/traps.h index b0dd2d24614dbead8e51bc0924afbb8cdeabb617..d6cb16541148fe0a7cda26071f31ee376ab768c9 100644 --- a/xen/arch/x86/include/asm/traps.h +++ b/xen/arch/x86/include/asm/traps.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef ASM_TRAP_H diff --git a/xen/arch/x86/include/asm/vm_event.h b/xen/arch/x86/include/asm/vm_event.h index 0756124075231d0b7aa9e1a0367b756033750d72..8c98b177a62c5af15fac37af032f8f5f1e3cd51f 100644 --- a/xen/arch/x86/include/asm/vm_event.h +++ b/xen/arch/x86/include/asm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index 05e1fbfccfcf9f592108a8db70f7955e52129cca..ded3cff7fb314499b18461408301152a2f5a2dd9 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/include/asm/xenoprof.h b/xen/arch/x86/include/asm/xenoprof.h index cf6af8c5df525c6925df9eeaae4be52738d21fee..bd93ef6e7cccf099d8f4679764340e328d1ca229 100644 --- a/xen/arch/x86/include/asm/xenoprof.h +++ b/xen/arch/x86/include/asm/xenoprof.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_XENOPROF_H__ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0fe14faa5fa7f4c384b44324c86743e823b53917..409c8b32536666fb51a3474d0ae04e7c6e17ec96 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/mm/altp2m.c b/xen/arch/x86/mm/altp2m.c index 07393befeeed4e9b0230306e60a9167460c511f8..a48cb5567de880e44324f5fd02b8379e7eaf8465 100644 --- a/xen/arch/x86/mm/altp2m.c +++ b/xen/arch/x86/mm/altp2m.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 76b4e0425887ff9f3e932dfd54c9fab70ca4585e..989006cb1b377d8192acfea668e891c126c6eef7 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c index 1da8d3b99edcb81b1eaa46ed2055ddb343209d04..f12467001082fd3922f18338ead92ed10b46d3c4 100644 --- a/xen/arch/x86/mm/hap/guest_walk.c +++ b/xen/arch/x86/mm/hap/guest_walk.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index 84cb358df1231a4b3a93997b9b2281bb2506b3c5..bcfd6e450268b75483206a7536d9b88a008d3b6e 100644 --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c index 605e47c16cd54480fce0a2b3d5251f327e91eec7..9ffad29d346cd09ed38dbfe9dc2d486c582c9519 100644 --- a/xen/arch/x86/mm/hap/nested_ept.c +++ b/xen/arch/x86/mm/hap/nested_ept.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include #include diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c index 098e8e5d4ca9c00de9e9cc870d2573a1b659e670..95d853994037764ecd6fd39d0f2de6f61dd171cb 100644 --- a/xen/arch/x86/mm/hap/nested_hap.c +++ b/xen/arch/x86/mm/hap/nested_hap.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/private.h b/xen/arch/x86/mm/hap/private.h index 1040eaf69f437a90b183c3e8cec683a9659fa028..f60bc084b2fe2ec35200d5b845562b3829e67da8 100644 --- a/xen/arch/x86/mm/hap/private.h +++ b/xen/arch/x86/mm/hap/private.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __HAP_PRIVATE_H__ diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index f3aed9fcc966037ebd94451fdc2098cacfbd7e04..07c53bff9566583779291e5a9b5a600161663bab 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include /* copy_from_guest() */ diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c index 01281f786ee05e83d1860340bcf7486f47914d4d..79158a1266090052bbb9fd9d6aa00aa5274a2bcb 100644 --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc54440a15723eb827ba28ae4b4221e877..d3f3d2007502c4480cb5fc4f36e6bff1c618d728 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h index c1523aeccf992db0313f3eadbd050a35222cf1bd..93200149ee739badd6ab5e431036939de7830775 100644 --- a/xen/arch/x86/mm/mm-locks.h +++ b/xen/arch/x86/mm/mm-locks.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _MM_LOCKS_H diff --git a/xen/arch/x86/mm/nested.c b/xen/arch/x86/mm/nested.c index fab62b2b2dc1db8f76f0b2a3cfb16c8f74d81511..56b0017aac0d70b2eca899f2ca7e5e3bda1210d9 100644 --- a/xen/arch/x86/mm/nested.c +++ b/xen/arch/x86/mm/nested.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-basic.c b/xen/arch/x86/mm/p2m-basic.c index 47b780d6d63aeccc699567568ecfd5ebf119caac..56da2cae3db622db050c74cd2e2bab219740f071 100644 --- a/xen/arch/x86/mm/p2m-basic.c +++ b/xen/arch/x86/mm/p2m-basic.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index bb143c6c42c69db4e054b9156aad9a18ea0b2378..6cb7fcfcf0e9236443fa78ee228a44ba638f5667 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index 2edab5e5cd91feb2ade4450a56b95ca3c55ee91b..2444ea5690cbd1ef6073cdf17e46cce6db02b251 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index cd1af33b6772ab1016e8d4c3284a6bc5d282869d..9735cf19ded2e85dd8fe8288852c8a4a3382249d 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -21,7 +21,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index c5561fe22160114d0d18124bd6ff35c3171dd523..a757474fb9577a1982b35166c0e8cfdabbb2039e 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h index cc0f6766e4df2d9db78463e2c2dcf55b26266820..dcbb5d9875b42f0c2b3c05362a0836ddf5c6825e 100644 --- a/xen/arch/x86/mm/p2m.h +++ b/xen/arch/x86/mm/p2m.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ struct p2m_domain *p2m_init_one(struct domain *d); diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 1c5f54f92aefcb79b891c25d8d1e922d8c21c37f..59dabd64065b16cc87d4afa8d97e9ba40df92a65 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/physmap.c b/xen/arch/x86/mm/physmap.c index 2d267b42f73b87554f328eaa69ed5062f7f7a65a..d4cb0317dc4aae8c0fdac763ab734628b82969da 100644 --- a/xen/arch/x86/mm/physmap.c +++ b/xen/arch/x86/mm/physmap.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index a74b15e3e75b6e882709f0ce0e72001f14e8e9d0..69bd2306733eea291f46c787655a9cc967205cdc 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index 88c3c16322f2777231538e382c148af4cb6bc070..a168b6c9d7a52ef5945e8ed22df9387e8cd689d5 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 3b06cfaf9a5aefb4d7678d9a5a5fb5c361d0319c..3567b6457896803a2c61b50ebd1ddd24daea3931 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h index 5bcd6ae1a8da2a77f3640bb69c010181f0624f2e..34e8186718f793c10285681fb57b8ee7583601fa 100644 --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ extern int diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h index 79d82364fc92e650317b8cc68a73c8abe3ae8028..c0954e85d37386c34f155c7531ab0196b909ee3c 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_PRIVATE_H diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c index ed10d5479c5ef09cc1a1dc0447552d47e608c6ca..9235b24a9f0903fe0c5178f3d2e808374079d4dd 100644 --- a/xen/arch/x86/mm/shadow/pv.c +++ b/xen/arch/x86/mm/shadow/pv.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c index bd6c68b547c9b02cf31182e407ab8900de0dc254..2aea9894ed24e1630356c2a7fa5b9e6881e78ac5 100644 --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define GUEST_PAGING_LEVELS 0 diff --git a/xen/arch/x86/mm/shadow/types.h b/xen/arch/x86/mm/shadow/types.h index fac59522b008d8a7fbcd60d99e585b346dd387a0..f491d80306339f7fe46c0cce38016b65e6dc952d 100644 --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_TYPES_H diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c index 30ca71432c0b822dea660b7ee391b79ed2951f76..db2ea5bd59e30ae46cfdd3b7a8559a0900806710 100644 --- a/xen/arch/x86/monitor.c +++ b/xen/arch/x86/monitor.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 7ddf0078c3a20ac2e4acf1d09292ba8d581aeac4..f5ae1ca82b63f7a9bf111cbad7cb0e2502ad2485 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c index 067ee3b795d0c906702d05ad67e71512396e5b5d..73e99a13f2dc26d8b3e3a5fd6827d8eaf619a3e9 100644 --- a/xen/arch/x86/pv/callback.c +++ b/xen/arch/x86/pv/callback.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descriptor-tables.c index b4135b450cdfb0a5e7b49bcc71f03cb1355ad079..4ac7d6169a31fae87c1c2a49d1049ef6c9a85654 100644 --- a/xen/arch/x86/pv/descriptor-tables.c +++ b/xen/arch/x86/pv/descriptor-tables.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index 758a20ad9df424db9dfeb8ea08707bf6405b97e8..8249f7561ee4c2a2acf3495df548913a3eca5397 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c index 2c07eed9a092df5882161e1a28557e5862c4a5d1..62b7fdefa322c31e674d7bd8263e17c77f0d24c5 100644 --- a/xen/arch/x86/pv/emul-inv-op.c +++ b/xen/arch/x86/pv/emul-inv-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 5da00e24e4ff15a9ef61c10002a3e511fced799c..61994058a8171b7aceb8b0117e67cfc44b5271bd 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 0a7907ec5e846c00df5fc461cbb3948b7efece40..3ac280963c487e0663a6a0818eb764181ff0b00d 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/grant_table.c b/xen/arch/x86/pv/grant_table.c index 81c72e61ed55888308e51e437805e2b91e7bc112..4c4dadd909064bbdd6e77f766ee89a326d784ad6 100644 --- a/xen/arch/x86/pv/grant_table.c +++ b/xen/arch/x86/pv/grant_table.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c index 2eedfbfae86417a48a682b3cc201ec0d8bfc478e..799407a1808cdd8e36d7fa5977cac35e308a4c23 100644 --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c index 316a23e77eb76eb7c532601d2779586fc54a7fea..a00816e7535de63726b3cbef307dbc57ced31c77 100644 --- a/xen/arch/x86/pv/iret.c +++ b/xen/arch/x86/pv/iret.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public * License along with this program; If not, see - * . + * . */ #include diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c index aaaf70eb633063e34cc2672dfe5e316f5b023065..e7a731b310a0455048611bdc681d97fab6d5855e 100644 --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/mm.c b/xen/arch/x86/pv/mm.c index 5ed7b3ccdbf209fb94b45c8e6c72eb510aeb5f19..44b74a6ec42a09dc74f39b2ff05c0779899da305 100644 --- a/xen/arch/x86/pv/mm.c +++ b/xen/arch/x86/pv/mm.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index 5963f5ee2d512a482b76f040eca4f4f314f91390..568dae9db6aa3d96baf0d12d150be2081bcf11df 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index ae1a0e6e65af04715b27fe55a5c316d74923ddb8..5c2b0481d7896066cb1e4ffa61cc9bbcc8e73415 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 97fe54b5ee5a6a95daa6146314f0d3fa482118b8..61de39eece9c514be14777dd4ae7690a018fc3c8 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b26758c2c89faf00719d75db5000c2c12331c848..621da7c204fd25362a96603c2bfe04fee3273b4f 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index a320b81947c85b39e1cea551b68b7aa7fdc4fab7..c61a95f7165e82e408959dd8e6074893e2b63e79 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8fa7aa8f6c8f8c73b8094e05855378e..ec8e67fadf70f3b9ae28aa369c25e0c1ebfca860 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c index 7027c08a926b3a9be0f296c56f7be5d4de537058..3067cb552af3af09ae8376519f2874b85b78e0b8 100644 --- a/xen/arch/x86/vm_event.c +++ b/xen/arch/x86/vm_event.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/x86_64/acpi_mmcfg.c b/xen/arch/x86/x86_64/acpi_mmcfg.c index 2159c68189e4b4f749f8e5a65c55a8a788ec659e..02c557449f9a18f1a06869d34bd308f9c0e8202d 100644 --- a/xen/arch/x86/x86_64/acpi_mmcfg.c +++ b/xen/arch/x86/x86_64/acpi_mmcfg.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/arch/x86/x86_64/cpu_idle.c b/xen/arch/x86/x86_64/cpu_idle.c index e2195d57bec7c768f80cef57bcde1c3b8e81b05d..0a5654cc122eaf60223d1c8591063bd959fd6559 100644 --- a/xen/arch/x86/x86_64/cpu_idle.c +++ b/xen/arch/x86/x86_64/cpu_idle.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/x86_64/cpufreq.c b/xen/arch/x86/x86_64/cpufreq.c index 9e1e2050da09688f2cd1cc5343f1a70b7af51ae2..f9ffc6275e6abc41d4a199bcf2f54c1ce59c036e 100644 --- a/xen/arch/x86/x86_64/cpufreq.c +++ b/xen/arch/x86/x86_64/cpufreq.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c index 8287124dfb1d0934e8a6d29de82fca374ca00357..4191cc148b9de3887204ba8b30302b19eced0d9b 100644 --- a/xen/arch/x86/x86_64/gdbstub.c +++ b/xen/arch/x86/x86_64/gdbstub.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 60db439af3ecb5cda1f641f0a18c5dea6b531ab6..5d7bb0ca3ed249277469ebcc29b01017545050b2 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ EMIT_FILE; diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h index 433046be663a4983ca5cdfb67b53df4e587f481b..057ae6ad758430c81b0f4c3c8303d2265a7a581f 100644 --- a/xen/arch/x86/x86_64/mmconfig.h +++ b/xen/arch/x86/x86_64/mmconfig.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay - adapted from linux */ diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index e38f98b547263b505078b649efbb8b9b666f657d..2ea0408e38c6a95f3cc08ad12b899488a97308eb 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* Operand sizes: 8-bit operands or specified/overridden size. */ diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index bb7af967ffee61e13fc1d4d2e0220fed77a88707..c5dc51330499b318d71ec60207e577491b10bc21 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __X86_EMULATE_H__ diff --git a/xen/common/argo.c b/xen/common/argo.c index 9ad2ecaa1e42337567cef6ecd53d56965590d60e..dad5b4a5e97d59ad7b8e687e61740264b37fdc67 100644 --- a/xen/common/argo.c +++ b/xen/common/argo.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c index fb829b41f13bfc288d8a063b9390f2688c777d11..5909003437c3489d43a887d25ea5fd827f16afc0 100644 --- a/xen/common/bunzip2.c +++ b/xen/common/bunzip2.c @@ -7,7 +7,7 @@ Robert Sedgewick, and Jon L. Bentley. This code is licensed under the LGPLv2: - LGPL (http://www.gnu.org/copyleft/lgpl.html + LGPL (https://www.gnu.org/copyleft/lgpl.html */ /* diff --git a/xen/common/coverage/coverage.c b/xen/common/coverage/coverage.c index bd90f2866373795137912561c3897e01ab95a501..efecaceb2ebd7ae0a949c68960fc363563f1b0bd 100644 --- a/xen/common/coverage/coverage.c +++ b/xen/common/coverage/coverage.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/common/dm.c b/xen/common/dm.c index 201b652deb7eb09e9b78bdaefdf07ca3faa0a135..a335edb982f2814cd953678feb2777d22153724e 100644 --- a/xen/common/dm.c +++ b/xen/common/dm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f5e0b12d15209d3d43ba1877e9def37b31ca32b7..65b75bc43837b52b891cca493bc4eedd82e21cc5 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include "event_channel.h" diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c index df8d122bce8d8c7fe0ede2303bfc46148712f4c4..a97f75ce94f140325300d64669a65cad973965cf 100644 --- a/xen/common/gdbstub.c +++ b/xen/common/gdbstub.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index b896f9af0e48d77b5d8e4d62d4bf2c15a3d675f7..a679c269d2680fff23b110eea8e80dbd4ec1fa4c 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index ecb8f545e1c4c158272c9cd48090bb62ef88a567..763fa524806c925096443f1740cdebd5932ec696 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/libelf/libelf-dominfo.c b/xen/common/libelf/libelf-dominfo.c index 24d1371dd7a95d8d8f199ddd24f7d3fd0df398ea..22f5105412fe39361a239cf478dcb22d6e29ec92 100644 --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "libelf-private.h" diff --git a/xen/common/libelf/libelf-loader.c b/xen/common/libelf/libelf-loader.c index 629cc0d3e611f065689f239e368100c0624ee5a6..69571dfb6b3215ba381d8546b72774506c3704bc 100644 --- a/xen/common/libelf/libelf-loader.c +++ b/xen/common/libelf/libelf-loader.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifdef __XEN__ diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h index 47db679966c6d0019a883123e7323fd28a96e1a6..d2f71196e1d80e00b499a4e80b5802b1ddf0dc63 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef __LIBELF_PRIVATE_H__ #define __LIBELF_PRIVATE_H__ diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c index a9edb6a8dcb348b1de77966dd96e6c2dcc82d4ef..245ca26fbea8f9e9058d02d23155b8ca1472482f 100644 --- a/xen/common/libelf/libelf-tools.c +++ b/xen/common/libelf/libelf-tools.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "libelf-private.h" diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 010e6f8dbfe9fbbd5223c9d1322a48e4f1d324f3..4bb463b5226065deb5be3983e994a71d190174ea 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/common/monitor.c b/xen/common/monitor.c index d5c9ff1cbf8cc71dfc1f31fbefa8ad21e2cdab99..4c89d9b85e38cf43c1f12cd9404c25667cc0e774 100644 --- a/xen/common/monitor.c +++ b/xen/common/monitor.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e40473f71ead2dbc182ecb80cac980b678e69280..806fc2ff37e0a7e2d61e600b6744b909043d10d9 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/common/pdx.c b/xen/common/pdx.c index c91875fabe2b070ba42a043be2a95ec846c5f832..dae46270c15f022ae24aa9a9d71f7c03b5a47902 100644 --- a/xen/common/pdx.c +++ b/xen/common/pdx.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/preempt.c b/xen/common/preempt.c index 3b4178fd44acaef5d99e1b01c38a8ee483adea47..5d7a85c7f8623fc84940c3dfe246ef424babe9d2 100644 --- a/xen/common/preempt.c +++ b/xen/common/preempt.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c index adc3034222dc9f7177b415d6ef895ce6ad80f3f6..06fe1bd5d36da89ba0b6cc33995b9f05ab09e930 100644 --- a/xen/common/radix-tree.c +++ b/xen/common/radix-tree.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c index 70b4d21b0f1d6da758f1df0f1c5229c6afdf200e..e3caf0e322ff6fb9f9bcc421be32a752d7601f2d 100644 --- a/xen/common/rcupdate.c +++ b/xen/common/rcupdate.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2001 * diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 65a0a6c5312d25052fda69c0be1898ce41062bb9..e375f715e50ff885f5a27fec90b1144994a70b28 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c index 3adbe380de965d7e11ff0692fe707a1803c1d22a..af4b5ef728419a63d25c604f292727226ba4a0cd 100644 --- a/xen/common/stop_machine.c +++ b/xen/common/stop_machine.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/time.c b/xen/common/time.c index 92f7b72464723e6b4830c6db29d9d30ef46f47a7..8f659118dada04384682222f3e4dc98418102054 100644 --- a/xen/common/time.c +++ b/xen/common/time.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c index 69448d7b398634b6543b1fcea7b6101724c17b36..a45996744b424a2a9ee073c1bc69d2d4853b4624 100644 --- a/xen/common/unlzma.c +++ b/xen/common/unlzma.c @@ -25,7 +25,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "decompress.h" diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c index 23eff1354fe0679299951abfb3fbe2bcc2adc699..65f76c890d3b8fd18de1716942ceb694b5dd4f6a 100644 --- a/xen/common/unlzo.c +++ b/xen/common/unlzo.c @@ -22,7 +22,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; see the file COPYING. - * If not, see . + * If not, see . * * Markus F.X.J. Oberhumer * diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index ecf49c38a9889f4ddb6c7f73b3cabb386f18ba73..2a64811551081217c0b8eca185c5f879f2b62a01 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/common/wait.c b/xen/common/wait.c index 86d3b15419db27ad54ef4d9c94fc8418d0471406..8ce592ee0440f56c5804e64a0d8eb514f7ab2e34 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/apei-base.c b/xen/drivers/acpi/apei/apei-base.c index de75c1cef9922f8fd7a82b13ce1446b6231a612e..699e7f0e613ef2c24db3fff01bf4d7af5a2d2f5c 100644 --- a/xen/drivers/acpi/apei/apei-base.c +++ b/xen/drivers/acpi/apei/apei-base.c @@ -28,7 +28,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include #include diff --git a/xen/drivers/acpi/apei/apei-io.c b/xen/drivers/acpi/apei/apei-io.c index eadf7a4dab53d7be15c6d4183c1beec0491bfb14..3bc468a1d10a33dc998ae7acda2cc0707cd7242a 100644 --- a/xen/drivers/acpi/apei/apei-io.c +++ b/xen/drivers/acpi/apei/apei-io.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c index 40d8f00270d0ac5acab558661d4041f1634c6bf9..2dad97cff70ee564de66c4878eb66ce85c07e771 100644 --- a/xen/drivers/acpi/apei/erst.c +++ b/xen/drivers/acpi/apei/erst.c @@ -22,7 +22,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/hest.c b/xen/drivers/acpi/apei/hest.c index 5881275d2f3762342043c7a7323ca3e42014e0da..d83795c7c6dbf5c82cbcb6347871d0a8a8bbec75 100644 --- a/xen/drivers/acpi/apei/hest.c +++ b/xen/drivers/acpi/apei/hest.c @@ -23,7 +23,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index bc6e888234e4cb6266909130377c90bed5f5f2ba..d1e2a51eb14d098a5dc84a8f994c7c7a50498bd1 100644 --- a/xen/drivers/acpi/numa.c +++ b/xen/drivers/acpi/numa.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/acpi/osl.c b/xen/drivers/acpi/osl.c index 389505f786668dc4b6859956ee51f4f4df85f675..c080882cc71d7b42e00dccc7ed49949fa371bad2 100644 --- a/xen/drivers/acpi/osl.c +++ b/xen/drivers/acpi/osl.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 1bae6351019be9662c33ebc479d2d7470e8096fb..5d52ffdad1e1b6065888e01e5a00412f6a365f01 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -14,7 +14,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # # The full GNU General Public License is included in this distribution in the # file called LICENSE. diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c index 96ff96b84c6676ec9c6b13070382b2533de1f88c..c6c950598add102d19b9321a13fd7d76b4082bf5 100644 --- a/xen/drivers/acpi/tables.c +++ b/xen/drivers/acpi/tables.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/char/consoled.c b/xen/drivers/char/consoled.c index 222e01844271a927e693d9c242e2124374bb1b3c..c53c6645ea2f900e9944b5b6a6c7ad04251bf8eb 100644 --- a/xen/drivers/char/consoled.c +++ b/xen/drivers/char/consoled.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c index b1e25e0468a49d764f1b40c522019e75dd496f4e..0e4a56dbef3dc955299ce6f38f701aa03a54df50 100644 --- a/xen/drivers/char/meson-uart.c +++ b/xen/drivers/char/meson-uart.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c index a00618b96fbc3bbdeaf09203e297b1b972bd9443..42307c4de81a44f5418700e0353a8c8d47338fcb 100644 --- a/xen/drivers/char/mvebu-uart.c +++ b/xen/drivers/char/mvebu-uart.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/char/xen_pv_console.c b/xen/drivers/char/xen_pv_console.c index 1536bdaf524583feb910a7bcf693c865df692265..37a9539e537ac2d2d388ebfb028c4dfb1d755d65 100644 --- a/xen/drivers/char/xen_pv_console.c +++ b/xen/drivers/char/xen_pv_console.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 60b781f872027c99c75c6d7eb3be82fa8e00ffbd..5127a085e6384352230c7bf9749da7ad07da4e1a 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Assured Information Security. */ diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index a94520ee57ac914be1d51a4a498c8d66cf15f3c2..30368afc6bec2ae579286b4953f7fd8d0966bb7f 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -21,7 +21,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/drivers/passthrough/amd/iommu-defs.h b/xen/drivers/passthrough/amd/iommu-defs.h index 35de548e3a783c8e2be4aa6a2a04bfbc8f9bb7af..11726aeaa742687b72053ac51ccd3659a475bba6 100644 --- a/xen/drivers/passthrough/amd/iommu-defs.h +++ b/xen/drivers/passthrough/amd/iommu-defs.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef AMD_IOMMU_DEFS_H diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index 8bc3c35b1bb1d13d7d321145788996197821f1e5..9692c89aee9c7fc5f841faac7b2792423108ca76 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef AMD_IOMMU_H #define AMD_IOMMU_H diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b390cad35960eef212f5d4d75fd1c2a75..bb821cf29936645bf2545d467c184630eee4a37f 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_cmd.c b/xen/drivers/passthrough/amd/iommu_cmd.c index 40ddf366bb4d01b8effe21cc6bcb5adc4f55fff4..a94caada9597e2160bfb27427de2fb5d557d7c6e 100644 --- a/xen/drivers/passthrough/amd/iommu_cmd.c +++ b/xen/drivers/passthrough/amd/iommu_cmd.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include "iommu.h" diff --git a/xen/drivers/passthrough/amd/iommu_detect.c b/xen/drivers/passthrough/amd/iommu_detect.c index 2317fa6a7d8dc9967ca7320861da27009047a008..6d6d7e17a885f28088da766017fb24970b3cf0e1 100644 --- a/xen/drivers/passthrough/amd/iommu_detect.c +++ b/xen/drivers/passthrough/amd/iommu_detect.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 80a331f546ed847ffcc418e25e16e3789fe7a950..f8d1d9a4b1b72b63d4c0844d7ba2de54fc2ad919 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 9773ccfcb41fe700af5c592777ba9d3eab3f0ef7..2c5a9ac2bca1fcc8036b76cd00bc10106a9705ea 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c index f4de09f43180e4f07c1b354eab39152afe6f50f0..6af1bca33c146d4351f6833e751dde328033ec06 100644 --- a/xen/drivers/passthrough/amd/iommu_intr.c +++ b/xen/drivers/passthrough/amd/iommu_intr.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 993bac6f8878d2b64521ce5c59e8589e40be5af1..b4cb59ca2ea21a607a8e5b554848b117e320cae6 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 4ba8e764b22f4b5bfd6772071144cfecfa323816..bcd928078d532e76c3efc590698a920663875750 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/iommu_fwspec.c b/xen/drivers/passthrough/arm/iommu_fwspec.c index 8c97c7ca4807c4b01bf171a9a7dee5f0bfc4648f..bc082a7e1ff532cdfaab917213bd19c8e22914d7 100644 --- a/xen/drivers/passthrough/arm/iommu_fwspec.c +++ b/xen/drivers/passthrough/arm/iommu_fwspec.c @@ -20,7 +20,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/iommu_helpers.c b/xen/drivers/passthrough/arm/iommu_helpers.c index 5cb19874819357b5cd58638864b56c505d07b37a..4e026eca681f5653996cd72debefb7ccc0259581 100644 --- a/xen/drivers/passthrough/arm/iommu_helpers.c +++ b/xen/drivers/passthrough/arm/iommu_helpers.c @@ -20,7 +20,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 682bf12aaaf5bd7b50afda56cdc9694984442c57..425ba0330f1100d0ce7729d6a534d3172728233e 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -34,7 +34,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index d58c5cd0bf772226904038e5c05d901ba1d5e1f9..e1f59f5889cc397921eedebed43cb5d6ebaea2b2 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -67,7 +67,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . * */ diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3360b677a183b45a73c19ac191a4edc..e62b51c3d7f3db228b58f37138e77bd46fb549c9 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) 2013 ARM Limited * diff --git a/xen/drivers/passthrough/ats.c b/xen/drivers/passthrough/ats.c index 7f7b16dc490c2e287b838fa8e9a1b0c6a18c3c72..8b8a424f7a22e262862b42d17c2a2d6fb5cc3927 100644 --- a/xen/drivers/passthrough/ats.c +++ b/xen/drivers/passthrough/ats.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/ats.h b/xen/drivers/passthrough/ats.h index c202f4ecdd6753de10427bb4adfeaa00d6a4915a..2e8bf13d07dbd40ff0222f32b72684b6eed21626 100644 --- a/xen/drivers/passthrough/ats.h +++ b/xen/drivers/passthrough/ats.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _ATS_H_ diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index b4dfa95dfd8e49b2c953d09bbfe5190ef04f7109..d72ac5f94a953d165d175f05467ca02ffa9114aa 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 9f8819785b49f26d7a03e30d51ac5dd0d6700719..0ea51f14106d5378c6a013d322c9a1f87359d174 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) * Device [8086:2fc0] * Erratum HSE43 * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x2fc0 }, /* * Devices [8086:6f60,6fa0,6fc0] * Errata BDF2 / BDX2 * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x6f60 }, { PCI_VENDOR_ID_INTEL, 0x6fa0 }, diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 78c8bad1515a231b0a501308e3003a5ce124fb2b..d71ad72dc434832308c047526021481c5622fbe3 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/dmar.h b/xen/drivers/passthrough/vtd/dmar.h index a1f2353a511f4f432494cd0d318ae9531a6c9001..33b9cea7ac835e812c690d6120da93968bb7b12c 100644 --- a/xen/drivers/passthrough/vtd/dmar.h +++ b/xen/drivers/passthrough/vtd/dmar.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h index 39602d1f88f82fdc94d2d94bab07dc4d95692223..4115e48b6047091f60e929199e1f13a264446ae1 100644 --- a/xen/drivers/passthrough/vtd/extern.h +++ b/xen/drivers/passthrough/vtd/extern.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c index 1512e4866b8cce8453c4c65838425c1ae093f197..0f0d390714ee77924570af6a7d6d0b8a954f0cc7 100644 --- a/xen/drivers/passthrough/vtd/intremap.c +++ b/xen/drivers/passthrough/vtd/intremap.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 62e143125d99443e9949e51ccc65a1b92ff3b648..7f3780fadff7e48d8a5e9f98e87d9533b22194bd 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h index 78aa8a96f5a01b7a5fb01d5ebcb3a934c0a51f29..caaa3d51ea9eafe50eeae2cc22691e8ecf55f3e3 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj */ diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c index 4f9ad136b9c50ec2ea86cd698879d7beb5444133..8952b454d5b28ce110346807169d8476b0b73e11 100644 --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index fcc8f73e8b906a3a7279410b7e80b55c6e4e61bd..763dd335a8ff7a4bf23ad4f135c7fdf6d523b94b 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c index 7c4d032f4f275dca753b011ef6f337e231fd3107..0a1e2ced49db198b6b02dd0471c184803d26c7cd 100644 --- a/xen/drivers/passthrough/vtd/utils.c +++ b/xen/drivers/passthrough/vtd/utils.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/vtd.h b/xen/drivers/passthrough/vtd/vtd.h index cb2df76eeddbd1f1e3682f7acc28433efdc5c643..af6d64ce20a41ec74ebbd02dce3509b5539834d8 100644 --- a/xen/drivers/passthrough/vtd/vtd.h +++ b/xen/drivers/passthrough/vtd/vtd.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c index 04d702b1d6b1985e4e0a07eb29118133b1682c77..fba0d92d6011ae5c422b777af31c4b5efedba93a 100644 --- a/xen/drivers/passthrough/vtd/x86/ats.c +++ b/xen/drivers/passthrough/vtd/x86/ats.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/x86/hvm.c b/xen/drivers/passthrough/vtd/x86/hvm.c index bc776cf7daaa206273f1e90ef9667a0725444f69..420bc6aa4e3b4c0624535761e7882561c9552dec 100644 --- a/xen/drivers/passthrough/vtd/x86/hvm.c +++ b/xen/drivers/passthrough/vtd/x86/hvm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/x86/vtd.c b/xen/drivers/passthrough/vtd/x86/vtd.c index 76f12adc23dfc5f3d6d62056f7e85029d212e618..ccb5710683a3179b3e7a3b091612a60adc0cb786 100644 --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index dd09ec22f12d53c1f1a3f1643a7792281eeffc0b..c424a7fd01a6c62b7318ade02d66ad2c70ac28de 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index f671b0f2bb45b22059a04be8f76d92c80b6700e9..dc5924d1ef6b7a3bfab941f6724e1d8b0e0077a8 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index ec2e978a4e6b16706f1c6ad61e4648b56c15f009..ac0418cffd9a42bbd92ce02e9476127ea84cac3e 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c index 8f2b59e61aa42eca4d2bb583019a6e2df952b9f3..9649cf30c116346497017009ba32ad9df866a999 100644 --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index bea0cc7aede17847bdfc1a4735d1e0a06acf6fb0..cdad7cbcb6a96bf74250b4f61b46bb011ff03a82 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 6d48d496bb4871e28f3c25a730dcbdf88dd48151..662419892399f5c5f2daec705fcedaf83e9dfef7 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 352f27f6a72396ada2dc30c6374d766614c2094f..1e1ea51fc6b55868f7d7643100d84ec008285762 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/include/xen/argo.h b/xen/include/xen/argo.h index fd4cfdd55c0ab90cd9ed2723a1fd7e867d33f4de..6653970bc45b9c23484985b27e7aef14c4223363 100644 --- a/xen/include/xen/argo.h +++ b/xen/include/xen/argo.h @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_ARGO_H__ diff --git a/xen/include/xen/atomic.h b/xen/include/xen/atomic.h index 529213ebbb4b8cf6ab40b3f32fcf93c8be8a29e7..550087f5f29b3a1c4826b50a80ad9db7a2d0a190 100644 --- a/xen/include/xen/atomic.h +++ b/xen/include/xen/atomic.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_ATOMIC_H__ diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index f93c1b6ee8198cc7560808cdfab9ed72a74fc273..eb3fd1651f011c0430fcd058313e12f1d7cecf68 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -172,7 +172,7 @@ * ... * * This has already been reported upstream: - * https://bugs.llvm.org/show_bug.cgi?id=32595 + * https://bugs.llvm.org/show_bug.cgi?id=32595 */ #ifdef __clang__ # define CLANG_DISABLE_WARN_GCC_COMPAT_START \ diff --git a/xen/include/xen/cper.h b/xen/include/xen/cper.h index 8788ceff126d98d7edd9d963c89934a2671fbd59..5df340bae735d22deb5359ee299bacbb46cbeab5 100644 --- a/xen/include/xen/cper.h +++ b/xen/include/xen/cper.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef LINUX_CPER_H diff --git a/xen/include/xen/cpuidle.h b/xen/include/xen/cpuidle.h index 521a8deb04c23bba99178d341d0cc05288b6382d..e04d928291a32054298241f26f7f3a141b1d2c01 100644 --- a/xen/include/xen/cpuidle.h +++ b/xen/include/xen/cpuidle.h @@ -19,7 +19,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/include/xen/dm.h b/xen/include/xen/dm.h index 18417d57f1e5a20d2f97d40bb19cfebfb5e6217a..cfeef82473a276efa07c9fa6fbdc50f480021829 100644 --- a/xen/include/xen/dm.h +++ b/xen/include/xen/dm.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_DM_H__ diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h index 42afd609c22030fb2cfd77277488e0981fa44dd4..ca4c32436293279fc51d90c578e7f73da0e586f6 100644 --- a/xen/include/xen/elfstructs.h +++ b/xen/include/xen/elfstructs.h @@ -45,7 +45,7 @@ typedef uint64_t Elf64_Xword; /* * e_ident[] identification indexes - * See https://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html + * See https://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html */ #define EI_MAG0 0 /* file ID */ #define EI_MAG1 1 /* file ID */ diff --git a/xen/include/xen/gdbstub.h b/xen/include/xen/gdbstub.h index 18c960969b769d20d035855479391407587c3636..9fd079d85616df1b12356109969a36cb25459eb9 100644 --- a/xen/include/xen/gdbstub.h +++ b/xen/include/xen/gdbstub.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_GDBSTUB_H__ diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h index 85fe6b7b5eb20c078ee422d1550be755af799a86..84d61b3ce99c0a0672bbd69afdaf53b12764ca94 100644 --- a/xen/include/xen/grant_table.h +++ b/xen/include/xen/grant_table.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_GRANT_TABLE_H__ diff --git a/xen/include/xen/inttypes.h b/xen/include/xen/inttypes.h index 28c0053f1c7adab0d56615b2a217ebbeb4e516a8..4db9ab779331caf7826c6bcaf14574de8b704b64 100644 --- a/xen/include/xen/inttypes.h +++ b/xen/include/xen/inttypes.h @@ -12,7 +12,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; If not, see . */ + License along with the GNU C Library; If not, see . */ /* * ISO C99: 7.8 Format conversion of integer types diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 4f22fc1bed5523c5b1a8951579975e0712c08c28..964b690628faef1bbd9ec3edc2775fd79f3bbe0f 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay */ diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h index a26614d331e3c98f9d4b7967b6fdd9d4e6a49de6..2e2004cf6a07e8992c5db80972685a4e4c5c7fd8 100644 --- a/xen/include/xen/ioreq.h +++ b/xen/include/xen/ioreq.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_IOREQ_H__ diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h index 4e4811680dc96fc40928f1b21208c6dc3f5f49ec..1ed4fde2a8cafce4f6a549ea286837b90d3e418b 100644 --- a/xen/include/xen/mem_access.h +++ b/xen/include/xen/mem_access.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_MEM_ACCESS_H diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h index 6b17a9307195df172b62bd9acf2cbb2c964dfad4..2652b016ed8a2f855717a32a2977c7266c049749 100644 --- a/xen/include/xen/monitor.h +++ b/xen/include/xen/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __XEN_MONITOR_H__ diff --git a/xen/include/xen/multiboot.h b/xen/include/xen/multiboot.h index 80a1761d9ee7742b30d5c8a18a4d962dfed181da..d3a1998c93d9527aef2a8a224fa6778783e157b8 100644 --- a/xen/include/xen/multiboot.h +++ b/xen/include/xen/multiboot.h @@ -12,7 +12,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . */ + along with this program; If not, see . */ #ifndef __MULTIBOOT_H__ #define __MULTIBOOT_H__ diff --git a/xen/include/xen/radix-tree.h b/xen/include/xen/radix-tree.h index 58c40312e61986e311576beff7b8627cfde64c7b..3ffe32b27c60ab7bc74515550bee1f09b57e3985 100644 --- a/xen/include/xen/radix-tree.h +++ b/xen/include/xen/radix-tree.h @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_RADIX_TREE_H #define _XEN_RADIX_TREE_H diff --git a/xen/include/xen/rbtree.h b/xen/include/xen/rbtree.h index 77bf57d4abc8da2ed7cfa6adbe5f8ab78fc17a29..99473a8db0a46bdbe845c4730956e2e6c1e35e25 100644 --- a/xen/include/xen/rbtree.h +++ b/xen/include/xen/rbtree.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . linux/include/linux/rbtree.h diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index f123b77aafaa1cb50ba6bceea88cfb4408e9cb6d..cde46128944ae23dad12061225410f88b1e1f468 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2001 * diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h index 92811d9110e5509009aaa47278d63643412bd0ee..d60681bec668ebf0d27dac69b8d3ade6ae3f333d 100644 --- a/xen/include/xen/vm_event.h +++ b/xen/include/xen/vm_event.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/lib/list-sort.c b/xen/lib/list-sort.c index de1af2ef8b0c279f3fbd9b93aa68619bb34dad51..82670110e20efda833a85f99838f461f42e10fdd 100644 --- a/xen/lib/list-sort.c +++ b/xen/lib/list-sort.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index 8b6c2c7572cd9793bbb77192704db27e04cb3988..ba03bfae71aafa1c590f66f96d586a2b4169eadc 100644 --- a/xen/lib/rbtree.c +++ b/xen/lib/rbtree.c @@ -15,7 +15,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . linux/lib/rbtree.c */ diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index b89b364287840623792f853e44070ce24a2b3cc4..1570fb2b2f72b6829f7bb39d939240d7bcb6e69e 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define XSM_NO_WRAPPERS #include -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:02:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:02:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491573.760743 (Exim 4.92) (envelope-from ) id 1pPeT5-0005pJ-3Z; Wed, 08 Feb 2023 07:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491573.760743; Wed, 08 Feb 2023 07:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPeT5-0005pC-0J; Wed, 08 Feb 2023 07:02:11 +0000 Received: by outflank-mailman (input) for mailman id 491573; Wed, 08 Feb 2023 07:02:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPeT3-0005p6-Bt for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:02:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0624.outbound.protection.outlook.com [2a01:111:f400:fe0c::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f15d003-a77e-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 08:02:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7675.eurprd04.prod.outlook.com (2603:10a6:10:207::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 07:02:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 07:02:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f15d003-a77e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wsh0GeiA1qZz7MArhe6UPagRq+PB2kk0pPcTf4QrQczRhxtzygcharlyKHx57aSkY2F7WvSW1EgwqzaNge0Cao2GshqrQgs48cuUkvF6dygGsZ3Dj+y6hLVVnJk1XWOgghKfS8Fkkfs3mNPFVJx71cA7LwhllvWwCjJiznluTXPO3EZDok3BFG7HaXEju8tZ8MueoGArhAd4DOOk3pcfNKw+Z02tMNVQk/WfEa2K6n7J1h34arFwMibR5CW1titzgISDXpzD0lpk/RrOC0ZA1hf7ZeBrs2fTdjJ/6KTq3rLd7pRNZr4fNC8PP749bGwZNej3EHbZL9+zNdrXjdEIMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gY1TRlj8K9y3EEs7dSAdirCHxY/e6l6kQYi59rctxco=; b=PpfhaThunQzjjspN6iUVGyeITOKzqEbddDHwcAhAim+jlk50jBZlmdPhit/XJEfrNfp6b9VdCBm2oOb+OGT8RvO0CWpueGy+DfPI16DoFdS5lsb0RSYab44/6RrNdauOZLSRQKxg9kLuM+7ffZFM8PQwJsWRJId9JD/+bg58QZEosjYaF+PIL8VCZhyqXSxI1ewfH66UuG0xzgGWQlRCAeauXGR4ly3RclTlvyEJvzdOo1ba9m915lJ/NqfHd6EoJY2T6AkF/U7zS1N/ihr9eA9gfzQr0JxAJRYMLwmH85/7oMO5ztVALyDypecAIfArs4BSSTosNXCl+j9ECiqfJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gY1TRlj8K9y3EEs7dSAdirCHxY/e6l6kQYi59rctxco=; b=WeD76y2fL05+ksDGloeNdUbjux+kYD9yYEO13Br9Gn3bZWIPwMTQxTtWaKszwvKe1yC3wXAWRgBXY8Yt5ahPgueTstj5UQsNvS9Z5FIjw1CvbyF+Sup7Veuv0QaV1GnPmJVp2e4Grpj1wpyuxBzpl8eoj7YJPsS6wApkbU/g8hN+n6NcarTaiG2swfZgV7vgxep8qmhrPjBNfUhfUWctVfBjyOTDBc/uX4Sc8vt6VHcBn8nakSWkges4Vy346ukGRVWqb7J0ZYRMkQCN34sdKdkqihw8lY03V+LUHgaJZXgTgKMmFwftLY3vNqBykOhfpgApt7066fwXdAce3u6BYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <920136c2-2c24-d851-fbda-ba7cd2c640ed@suse.com> Date: Wed, 8 Feb 2023 08:02:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/4] Build system: Replace git:// and http:// with https:// Content-Language: en-US To: Demi Marie Obenour Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org References: <74c5389cb5adbd62154735a28f6c31ae1865b254.1675829867.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <74c5389cb5adbd62154735a28f6c31ae1865b254.1675829867.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7675:EE_ X-MS-Office365-Filtering-Correlation-Id: 191e42cc-937b-4d78-9093-08db09a26168 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7rt3XtbqjdTsAMI/Uo2ilf+qvnBLBkon8FlacEZqq0qIFFOtCnQZV7sZX6pTByGyov/LKdbCZQD4/2IIYzyb/uDk4xoGGPWxJGCS1foWCcQdFYoveqQptZe4d6d1j17rBHImXDuynDqHF22Usk7U32T9crau8MhnKR/HdcANgwhWj6r5evD38QwMW4JMFw2Y7BpvKL2B7GSPFfTmidx9+SZr6eKkG8015TsEWXcdrlNMwREfUq3XASR/Juqb30qOUb+9hr0IY8ErOe+iiTNdW0wyGcII5R0L9g00G67wXy1IDombDCMGvIFwC1H01yjzieYQ5zZRMz7WoWW8YPEIrT0LJIDzss82Dv9rs1+MqRQNx7EDW4MtiDTKYvNpox/EUjpDKPbM1S2q60eGQXGQgt8ULMmoZNfMyzQ/3AOOICjJpmJTLoRfXi99jUSFiNIUTYgSr0amApibWTuFtI7tpETXFEU8VxsaM8dJxZEDmt933b1X35S8dclbdsFRQ84aeWIuplL3fB+/3Q0Lci4Pny4YXaQLRtk66w2RqOxIPgohZAR9pYu3N1NY7Sx/hyx7i+ZJDMgJyCMccSfJAevqhpTnXhqOIOaB5Zu9yIVIS4nfj0Jgkbk656uJcqIgJus0mury3EyiOPqW97VztcZRqfU3QBZlbBh0WivygcMWi6ZHiPH48yi9DuPHhaxesIK9/JgsSIm82x1oMglLmaD9yV0B4fzCf1j5XlBeRfAUsGdRxSc9rWn+DUnkTt0u18Co2pESE+ZkBVmAJSdVfjkU0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199018)(5660300002)(86362001)(2906002)(8936002)(41300700001)(66946007)(8676002)(31696002)(4326008)(66476007)(6916009)(66556008)(36756003)(83380400001)(6666004)(6506007)(53546011)(26005)(186003)(6512007)(478600001)(6486002)(966005)(2616005)(38100700002)(316002)(54906003)(31686004)(84970400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDdCOTREKzZDY0tzTDdFakN6OUJHeXZ3Z0Z2ampVRVNBaXRNQTRvd3R4L2FH?= =?utf-8?B?dGFFQ05odDZJVjN2ZnJuMEc1ZVRuTVQxeE4xMnA4V0RGNm4wSFRScVRrQjRz?= =?utf-8?B?YWN2azd0Z2QzM0lKVVZWVGtseXEzYy9uMjFUdlJpQVhUTEh4c0REdkJGN0tk?= =?utf-8?B?N3dmLzdHVmloMm9meUhXVjNkTk8zQUZYd05CWTFybmpkcUIrNFordHl6bWhp?= =?utf-8?B?YzZDc043T1ZvU1FkMGpFdzlXdXZvVkFpc1JEVlN5Wmdlb0Y2TEZkRFM0MTBK?= =?utf-8?B?bHJkamJBZjJnYUJXT1pERjBzckt3NTVhS3NpZGNGTmRQemVSMVB3dWRuMVZn?= =?utf-8?B?TVFITXFOaWJzYUhoeThRcG9iaDErZUhXZStUdGJIOXZUOW44R2ErZ0xPeXpE?= =?utf-8?B?VHVmT0swTW81N0w1R1lvY3dDWnNkaTlMUWxSRmcwUnpydXBVSmJCeEV0SDhq?= =?utf-8?B?aEwra0c0QXlFcDRRbmZsajgzOVE3YVVZM1o3V3RzSG9PRGppa0RrbnM0N1o3?= =?utf-8?B?bHNxd2RRcmhXenVieU5UdXFaRkhoek1BdGZvbGpzeW1DUjdLcGlMYkZaTW9H?= =?utf-8?B?VFNQcCtWSWNKRGZnRTY2NGdpNUxvTEdERWVZZkFFcVpXeE9HZEVFbndBTXIx?= =?utf-8?B?REoxTUdiT0M2MXkrYng3Rks5THMrZEovSnhYWjJodzNvN25WblMyV1RBMFJC?= =?utf-8?B?NzI4bjZFb3NDZDh0cU00VkJBWGxJVnlMUFA2cjF0YW9QbjFNSzltckZjMzcr?= =?utf-8?B?UXdES1l4MDhGeS9ZbS9LL1l5eG4xY3JtdHFvYkxGTG5SakxtVCtzL0xaUUJL?= =?utf-8?B?ZHBPWnIxcG1LR2NDSjNhSTJMQnU2SThMZXFPZFV1TlRvNjRtVE9waStGT0tm?= =?utf-8?B?aGFpOFdEanVQbDF1K0lrSXlTU0xjQzBEdzczSmJUSFRIdWVPMEhJQkhMclhG?= =?utf-8?B?dnl0NTh0MXJXZmREZ2doU3hwb3VTYVU0NitnUFRXOTJtMkNOcWxZL3V3V0I5?= =?utf-8?B?a1JIeXNVMDRvN2RnUEYwdW5oS2RLQTE2c0R6ZlcxemtOWEpYeDZqVWxLdXNS?= =?utf-8?B?cjFzN21LVmJIckw4ZW41dkVoSHJFcmlYbW16Z0Y3WlI2Wi80dGh6K0hUMXZ6?= =?utf-8?B?MVFPTG5hcXV3NkdGZmhqQmQ2R2NRN0t0dmJmeU9xQy9Cam82a1RVdTBTWmZQ?= =?utf-8?B?b3B4WUhiWThxZGhlUnNOWjlrK0JtWFdlejN5eWt6YVV4UUVZT2dvYXB6aGRU?= =?utf-8?B?VytRUG5mdU5kdUtuY2kzUXl5Mm9ZV3dJeVcrRVp5TDZ4NmdHWHFPZDUzam9x?= =?utf-8?B?Ynh3a1p1Y3NMOXlGbnVCdjJkVkMvWHhBYStKOXQ2OFdXNWxvSElGSm42TnJJ?= =?utf-8?B?R2hWcklqMEhmYWxUVFdiT3ozbUFianlzSGVOZ2ZVcVJvS3BPbUZESnplUUhq?= =?utf-8?B?eU9SSzdabncvNWxJMm5BUFpLR2tHVERTcGZZTUZ6VnFIdFdBOFFCdVl2TXVh?= =?utf-8?B?cXk4cFdrUmd5Wk1HK3ZkbHFGSDNycDliS05ycHZ0dFExNDNxM0lZbG9GSVhr?= =?utf-8?B?bkpnWnBadkQvSk05Y2M2dm8xdzRIZnlQTGFzeXAyU2tsVWVsQmdKOExzRUJE?= =?utf-8?B?UC9DVnNuMTZvcXRrM0NSd0ovYUM5cGpQNFBNRFpUQkxvdURrUzJaWVVFaHZ5?= =?utf-8?B?eUw5VmJsMk9lK0pTYlBMbjN3ZUhGSUFlcTMrWFhvdWU5dk1CYVpMRGdMQmN4?= =?utf-8?B?U1BBbjM3U3QvSzhtZmVOSE45NDBTeW9ES2xCUUZERWZ0a3E4c2h3dGx3d2ha?= =?utf-8?B?U3FEMVFVZmJBWWpPK09zajJyTWNibmt4NmVtbCtwQjV1WE5mUWZ1MjlvcDJx?= =?utf-8?B?YnJHL2pJOFY5cElwcVRvNDZXTDY0ZG5Va1NxekcrZFhYUHB4ZE15UjQvcUZp?= =?utf-8?B?UllleWlCNWRjbGdRZGhoMXlKQWoxSnRPZG9FZjdLaTFEdlVkSU9tUGV6NTdV?= =?utf-8?B?T290WTU5L2JXY05KSFlEblc5ZG4xbDVKR3FSNXNoRERXYmpSZjlEMXUvNTk3?= =?utf-8?B?YkZ4YlRuWXMrbjFTVVZ2a0dsdkRrS2RXT2I0S2xMUjBsK3AwRHRJRjNXL0Q5?= =?utf-8?Q?rC4yQpCPjs4AvTAv0LEqSr7bc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 191e42cc-937b-4d78-9093-08db09a26168 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 07:02:04.3057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EeUdX7e/MjQwC4Eddj6NDnefKmKuUMzQBCCzh3w2K8sNdAZ6jWohLh05SdhAUP52xMa6RdoJHAwmm26lSVaSCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7675 On 08.02.2023 05:51, Demi Marie Obenour wrote: > --- a/stubdom/grub.patches/10graphics.diff > +++ b/stubdom/grub.patches/10graphics.diff > @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c grub-0.97/stage2/graphics.c > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > -+ * along with this program; If not, see > ++ * along with this program; If not, see > + */ While this one may be seen as simply on the edge, ... > --- a/tools/examples/xeninfo.pl > +++ b/tools/examples/xeninfo.pl > @@ -36,7 +36,7 @@ sub apiconnect > { > foreach my $xenhost (keys %xenhosts) > { > - my $xen = RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}"); > + my $xen = RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}"); > my $session = $xen->simple_request("session.login_with_password", "user",""); > if (! $session) > { ... this pretty clearly isn't part of the build system. And iirc Anthony had put under question this change anyway. > --- a/tools/firmware/etherboot/Makefile > +++ b/tools/firmware/etherboot/Makefile > @@ -5,9 +5,9 @@ include $(XEN_ROOT)/tools/Rules.mk > include Config > > ifeq ($(GIT_HTTP),y) > -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git > +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git > else > -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git > +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git > endif When both URLs are the same now, why keep the ifeq()? Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:34:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:34:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491579.760753 (Exim 4.92) (envelope-from ) id 1pPeyK-0001CA-J5; Wed, 08 Feb 2023 07:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491579.760753; Wed, 08 Feb 2023 07:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPeyK-0001C3-GA; Wed, 08 Feb 2023 07:34:28 +0000 Received: by outflank-mailman (input) for mailman id 491579; Wed, 08 Feb 2023 07:34:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPeyJ-0001Bx-Br for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:34:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7d00::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02f8d920-a783-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 08:34:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9047.eurprd04.prod.outlook.com (2603:10a6:20b:442::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 07:34:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 07:34:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02f8d920-a783-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOZV7wYF3viDkXFCUfMBWuRZ204L6fSrLeKxDfe92yOb177hPSkvrclUGdSh96L8N6mPvNeQX47B6zg8qtFxh+hff2n7WbfAI2eEbzMsa9Sf9Tl3LfeDAOGD9BHS1/3ngkBm+GNGTf4RwjFKKu0GKSr6t9Gh586W+rHnFvSifnXlZGEWEKMsq9JrAhBXYLwicTtwjnGnzv+TeXGux4a/GTr2K8RJJdDIGANXz/+jsN48nYtGbHUaJkbXqZn18RnPCM9r8QW/g8zalGZZ6ksQlYwQ5WMuYlIuGhGVuL/YGlV7Z4hrsx4NfFNvOQvvVGdsJrloiLlMx0jOp8kPObQTdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ohr2oxjexWs4hYfaEOfRQM9AJYLdjY64IyCAApzNVIk=; b=cVl0VGxt+kYsPxfRUeVk8TwyF3jsQVyVai6Z7SsxmV5NzFm1uYuzRLEeCKEy/CfxHtiOCoXOfUSBg0PveMUFAtsuV5xRMvQn6qLd2NtAfCSVBIBFcPyClnmiunpCSJW+/nCaM6WXX4lGiDqUuAPQViLrlwLH+rNGKEXESCo4r6Dx+/CttdjKwkDA15nJS/NgGdpbrSioN2+4CSFl3qDio4fSGv/bo08vWj9XiHJf2k98ITNtA/A8Zf1WxQ1AfFChLxZbJDurdUyeNRZ84NO97hNv4MvhkCPQHmxSTCNzEt1pNxG9pYiQ/sp+5VlXc3etGZ+tgWcnrjVKlvSfna+pjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ohr2oxjexWs4hYfaEOfRQM9AJYLdjY64IyCAApzNVIk=; b=f9JaA4QxnfgiRfzhwMA4yeEh10+M7ZQiMFSku4mt7aY+jQyyRw8kV/ThceedvIXikdqJl6aHGt+95cXdTSUG2vp2y6BMQf8+kRZXcj7rUW6+YTGqXdOCutke4dji0qtlDYxAsQ8X8yAhDCrv1i8gdiBIMeft4XNTj6W08ZH1mHlfkbeY0L58ucweKEN+ljmialx3TOG122cM9dQwFBzr+COAsCwkBIIvbAtOAwct9bE1di4coZesoRnyUiSs+2ynTouyp+lWYghgIiwL1iFt7FTqe69tkKLo24Ld4Ut64/RRJ3A/EPFlcONqQN2rdnhdkCMHWOT1OaddHwWoD3T0mQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <87140c89-e3ed-46cd-f7ab-8688640416b7@suse.com> Date: Wed, 8 Feb 2023 08:34:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/4] Miscellaneous and documentation: Only use TLS-protected transports Content-Language: en-US To: Demi Marie Obenour Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant , Doug Goldstein , xen-devel@lists.xenproject.org References: <83ecebe5c6b57713b0265fe0aeea25700f2b892b.1675829867.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <83ecebe5c6b57713b0265fe0aeea25700f2b892b.1675829867.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9047:EE_ X-MS-Office365-Filtering-Correlation-Id: dec252b4-4d5a-46ca-fc9f-08db09a6e569 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D2sGSj1K8k6x7awsC52c6aienh8hozWcA9eGDK95wHsk/6h8l0IG9IcIF/Y42bbPyPR49h43hTGCOWLwslBwTA3e9iHcbOe3XLGKek6LevaRLWnPVIC1Q5i8vDh0ypdFpV7lxeaLr/kj9fJUZSSOrLyTS0Sl1zdEVTq+qnNMf4Gm/PcHwHeI6pYkNoLv1mWUewdAL7xSTQr6Scpf62c5AZ1qbdf1xqWrgDAyvGcRG2ab/Zc/ZRhsUaqLn2cf2m01DsmrvuJHg9wF/TQEnTr+yVgITuLfcI6BOmUcN/JD2qnyAQM8IP+m3AWFCYFcG43PGTnKixeVpEUlND4FTWYZLN9arFU0ZUCjBekP9BFSxJ1RJ48PH02V6/BSrDHY1UHgA0Bl0KTBLwwYygCM/cFaCPe2qYL4giZyOTxJylFsAnrp42xCfTk+ULmXjxGyJRJGfwv5AmHLX+MX3v4eX+TQ9C2hNaKLotk2D1TBwz8vm8ShQWqMPc5XghlckX8m8dfV0g1OGWA0SKz1vmRaDLxYpbO8G4Jpv+wVtwSVOOITRDqA0PWXY83oB6gav5u5LbuZRZl2qNj0iA0WW88CoSEbar3SJHEUwEx/LJ4Jxg/0GgKZDcEKqQNDzlihWu/RMpnn/s2G0vD7rOOvEgVF29NMoOtVSrvaCEP/Q0XZJvgTEph1Ok/+LljZqbjWpFR2v6qy9PlCiV4OFUPQUwf72by6pVh0mVadIZNbvLLCE6c+RQuqzx09uSsn4E8h69y9jdZ+2zPmUn7/ohljmO8xhY+fOkSZMd3FfV6zO4gBJf+JK7ugp+L4bmu4bnlC+mD3mXDSH8KMHrOmsWM7X8z0Uvd3cg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199018)(2906002)(83380400001)(38100700002)(316002)(66946007)(66556008)(8936002)(6916009)(41300700001)(66476007)(4326008)(7416002)(5660300002)(6666004)(6506007)(26005)(53546011)(6486002)(2616005)(478600001)(966005)(8676002)(186003)(6512007)(19273905006)(86362001)(40140700001)(54906003)(36756003)(31696002)(31686004)(562404015)(45980500001)(43740500002)(563064011)(376185003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVJxQktmMlc2T2hzTXpZeDZ1Zkk5UXZJYitwS2lGbElPak01NWpvRVlvOUg2?= =?utf-8?B?UFVxdzBoUytXWThPZ3FmQ0sxalg4OUtDVjV0Rm5MQndIWldjaFF4YWgzekdk?= =?utf-8?B?RGlLSHJISzRkdm1DYytvRUN0WFVIQ0Rxa2pjemtTMk93U2phZVQ1eFRzazFr?= =?utf-8?B?dTFsUW5ybFlSaWtVWk9QYmFKb2N3ZFAyRm5wNThESkp1WEduSk9jTy9vT29q?= =?utf-8?B?RnNBQmxZWXZ6SzIrUmFDYTNKTDgwYWdpbHRqSUtzWkpPS1JlQTMyVVhOUGJj?= =?utf-8?B?cW5QVThrbGNkSUpCY3pVSGRXa0RlS0NsRmVHM3hFYkw2eWtzTHJBdE1JaXpI?= =?utf-8?B?OTNMNEVXcEFEeVVjZnRyaC9ib2M5QWtMdG0zSFhOYlI4VVQzQkppS1Vrd0dI?= =?utf-8?B?T2dzQ1BkWXVOVHJySHhlZjZ2a3BMUUt0WGQ0dmxWWGlCQXIxTWFKZGQwWXVa?= =?utf-8?B?cXM4YjBTdU5IQnEzL0tmQjBLWHBuRjJXNnJpaUFrTVNJOEVKQWp6d0lRNHVR?= =?utf-8?B?UTJraWpLb01SbkVldkd0Y0doZ3hDemVQQ245Uk44bE9YS2dEUC82cWFwVXRh?= =?utf-8?B?QWwzT3ZWSFlMZ3hUL0N5L0xHMUtFOGN6Ukt1cEh2ZlFoZmJYVFNaN2NSTStt?= =?utf-8?B?TldaSHZhTkxhRE9ldzVmMUJSNDlVNXpXY296djFsVlVHL1F0aEw2Y2ZxaUhL?= =?utf-8?B?M01LRE1mVzlIVlRIL2dselRBSUI0SGFkUDhKelBERzQ3azQ1eUttemU3dW1l?= =?utf-8?B?ZVEyRHBJb0FFNjJWcUFCZHVOMy9ubklDVXkzODJaMll6c3E2T2ZRWFljVDdP?= =?utf-8?B?NWRvOEZsbFZGQURJb0dOdEgrTXd6US9aalptRnZsUFlHY3JyK0NLRUswUTc4?= =?utf-8?B?TW9rNHFCbW12dG40cVJSVDhiM2dDZmJxR0J4bHVQRlhwRlQ1dWhKUWJRVnl4?= =?utf-8?B?YTJta1dxNnFkR2QwQUE3QzRwOWNmZXc3V2NLNXVVMDJHeDN3MVF3T3FFOHh4?= =?utf-8?B?aFU1N1J4OEVhU3Foa3Mvc0x6TUZuY2tweGxPMjlibDZ2VmlwZ2dFS0dReVph?= =?utf-8?B?MlJ1anFHOHA3d2Q4NXNpSjdJVlVyYkxoYzJLNS85U2FETkhPcmpuQ0hoNGVt?= =?utf-8?B?QkpXSTlJdlRFbW5PdUw1akU0cTMzRjllZmhZV0JYTHorQzBoOXpvd0VwdGVr?= =?utf-8?B?YjVrNXNwMmZVSHN6YmlTc1pFK0lzRks0RkJ3YzNoNGUxNEJBMWdVMCsydUE3?= =?utf-8?B?eStLQUZja3k2bkJxRm92NjhnT2V3WkJITTRRQ3g2NlYvNklCN3BQd21aQXlK?= =?utf-8?B?NHZMMXRTT09CVnhSQ2RFMklkM1phb3lBTTdjS2RLSFQzVkZIQkRBU3ZDc3Y0?= =?utf-8?B?amIxQ2p5MDlyMFMvMW9QV2Q2eCtsL3QvTkZlNFVadS9xQ0J4RTFZcStoV2c1?= =?utf-8?B?c2h3WjFFZ05TbjQ3dXlXaTNTWGhPdktMaTViR2VpZjdEeVRmZGM3Z2FPWVBz?= =?utf-8?B?RHhLOGhKS3RVZlMyMWNQSXFyVGRndVowMWdvdHFVZURmeE1OOG40ZjVBR25M?= =?utf-8?B?ellpWnhhVkM1VENxaXJLS0loNnJVRUxpaUhxTVZvdXAraFArcWZmNXMzZmtT?= =?utf-8?B?azhBYVhLWld3aUNPVnJJQU04UFN2Q0wxdHdLYnNGY05neXVzb1Jna1N6SmFi?= =?utf-8?B?V0E3QjQ3L3hRK2FoblpJMWRrRXNxaWJBRWt2Sy9jbndpY2xLNEpHdjQwekx1?= =?utf-8?B?Si8vUk44SkN4MVBzOXR6azY1Q0JQRzd1alNGa1lYQ1NRN0JDS2Fzamc3WmQr?= =?utf-8?B?bG4zVXp3dlljZFJPcVZPbGFGcXJ3bHZOVGs0SU1SQmFtWVBFbjhkTFc1K29J?= =?utf-8?B?YkZ1QlU0UkZLNFprTnYyYWhBbC9qZHpoODFlV2dNVTdaR2Q2SkY3dFRIdTdo?= =?utf-8?B?cjJXY1A4UWkwYXFLL2ZCejRvQ21KV3VuNmxNMWt6Qklpc0JXUW53VWpvU0Zw?= =?utf-8?B?QTgwODU3eGJObStHZGJSTTJjZUl2WlFGVkdnSDRqWFIwdzBpUmlhNFM2UXFQ?= =?utf-8?B?ZlpVVytyQi9JVzlMekFDQlBjUnp5MXlPMXpuR2VKeGtNaWhSVHZuRVNTRXEw?= =?utf-8?Q?IoXCWuSU97c0/aOqCay/Z8oX+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dec252b4-4d5a-46ca-fc9f-08db09a6e569 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 07:34:22.6206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ag9s5wS1L8rrJ9usvhCeSqZGboduDJGiRtTM8fBkyOTzTN05crwixk2lxQVImdkX7gEK5jeb6kL5sgf4Er2avg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9047 On 08.02.2023 05:51, Demi Marie Obenour wrote: > --- a/tools/misc/mkrpm > +++ b/tools/misc/mkrpm > @@ -34,7 +34,7 @@ Version: $version > Release: $release > License: GPL > Group: System/Hypervisor > -URL: http://xenbits.xenproject.org/xen.git > +URL: https://xenbits.xenproject.org/xen.git At the example of this (can't really tell whether there are others): Perhaps a good opportunity to actually provide a correct (working) URL? > --- a/xen/arch/arm/arm64/lib/memcmp.S > +++ b/xen/arch/arm/arm64/lib/memcmp.S > @@ -6,7 +6,7 @@ > * and re-licensed under GPLv2 for the Linux kernel. The original code can > * be found @ > * > - * http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/ > + * https://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/ > * files/head:/src/aarch64/ Here (and below) maybe a good opportunity to unwrap the URL(s) at the same time? > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -11,9 +11,9 @@ > * Software Developer's Manual > * Order Number 253668 or free download from: > * > - * http://developer.intel.com/design/pentium4/manuals/253668.htm > + * https://developer.intel.com/design/pentium4/manuals/253668.htm > * > - * For more information, go to http://www.urbanmyth.org/microcode > + * For more information, go to https://www.urbanmyth.org/microcode The original URL doesn't look to exist anymore, and the secure one fails to get a connection in the first place. > --- a/xen/arch/x86/dmi_scan.c > +++ b/xen/arch/x86/dmi_scan.c > @@ -617,7 +617,7 @@ static const struct dmi_blacklist __initconstrel dmi_blacklist[] = { > NO_MATCH, NO_MATCH }}, > > { force_acpi_ht, "ABIT i440BX-W83977", { > - MATCH(DMI_BOARD_VENDOR, "ABIT "), > + MATCH(DMI_BOARD_VENDOR, "ABIT "), > MATCH(DMI_BOARD_NAME, "i440BX-W83977 (BP6)"), > NO_MATCH, NO_MATCH }}, Such a change is equivalent to removing the table entry: The BIOS in question won't magically change from http:// to https://. It _may_ be reasonable to add a 2nd table entry using https:// here. > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -4,8 +4,8 @@ > * MandrakeSoft S.A. > * 43, rue d'Aboukir > * 75002 Paris - France > - * http://www.linux-mandrake.com/ > - * http://www.mandrakesoft.com/ > + * https://www.linux-mandrake.com/ > + * https://www.mandrakesoft.com/ Both sites result in "server not found". No point updating such URLs imo. Doing so only gives the false impression that they are still valid. > --- a/xen/common/README.source > +++ b/xen/common/README.source > @@ -26,7 +26,7 @@ The file is dually licensed under GPLv2.0 and LGPLv2.1 > libelf > ------ > This directory was opriginally imported from the libelf > -project at http://www.mr511.de/software/english.html > +project at https://www.mr511.de/software/english.html > This directory is licensed under LGPLv2.1 (see COPYING file) > > libfdt Firefox reports a self-signed security risk warning here. I'm unconvinced it is a good idea to refer to such a URL, but I guess it's better than nothing (and also better than the 404 coming back from the http:// one). > --- a/xen/common/bunzip2.c > +++ b/xen/common/bunzip2.c > @@ -35,7 +35,7 @@ > Phone (337) 232-1234 or 1-800-738-2226 > Fax (337) 232-1297 > > - http://www.hospiceacadiana.com/ > + https://www.hospiceacadiana.com/ > > Manuel > */ > @@ -470,7 +470,7 @@ got_huff_bits: > and decoded them into the intermediate buffer. There are > dbufCount many decoded bytes in dbuf[]. Now undo the > Burrows-Wheeler transform on dbuf. See > - http://dogma.net/markn/articles/bwt/bwt.htm > + https://dogma.net/markn/articles/bwt/bwt.htm Again the site looks to no longer exist. > --- a/xen/include/crypto/vmac.h > +++ b/xen/include/crypto/vmac.h > @@ -62,9 +62,9 @@ typedef unsigned long long uint64_t; > * This implementation supports two free AES implementations: OpenSSL's and > * Paulo Barreto's. To use OpenSSL's, you will need to include the OpenSSL > * crypto library (eg, gcc -lcrypto foo.c). For Barreto's, you will need > - * to compile rijndael-alg-fst.c, last seen at http://www.iaik.tu-graz.ac.at/ > + * to compile rijndael-alg-fst.c, last seen at https://www.iaik.tu-graz.ac.at/ > * research/krypto/AES/old/~rijmen/rijndael/rijndael-fst-3.0.zip and > - * http://homes.esat.kuleuven.be/~rijmen/rijndael/rijndael-fst-3.0.zip. > + * https://homes.esat.kuleuven.be/~rijmen/rijndael/rijndael-fst-3.0.zip. > * To use a different implementation, use these definitions as a model. > * ----------------------------------------------------------------------- */ While here the server still exists, the URL doesn't anymore. > --- a/xen/tools/kconfig/qconf.cc > +++ b/xen/tools/kconfig/qconf.cc > @@ -1785,7 +1785,7 @@ void ConfigMainWindow::showAbout(void) > { > static const QString str = "qconf is Copyright (C) 2002 Roman Zippel .\n" > "Copyright (C) 2015 Boris Barbulovski .\n\n" > - "Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n"; > + "Bug reports and feature request can also be entered at https://bugzilla.kernel.org/\n"; > > QMessageBox::information(this, "qconf", str); > } Personally I think changes to files under xen/tools/kconfig/ should come via a Linux side commit that we port over. Now that I've reached the end, just to clarify: I've not checked all URLs, just ones looking potentially "suspicious" to me. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:36:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:36:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491586.760764 (Exim 4.92) (envelope-from ) id 1pPezo-0001qK-UE; Wed, 08 Feb 2023 07:36:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491586.760764; Wed, 08 Feb 2023 07:36:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPezo-0001qD-Rc; Wed, 08 Feb 2023 07:36:00 +0000 Received: by outflank-mailman (input) for mailman id 491586; Wed, 08 Feb 2023 07:35:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPezn-0001pz-Na for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:35:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ac11e4e-a783-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 08:35:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74E5F33876; Wed, 8 Feb 2023 07:35:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D9BA13425; Wed, 8 Feb 2023 07:35:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vq4QEd5Q42P+agAAMHmgww (envelope-from ); Wed, 08 Feb 2023 07:35:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ac11e4e-a783-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675841758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wMLDm6HC72+yePinbuQ93EyNJ0Xs8Qcg0nWPi5wVOt0=; b=ZWU1AcsF5oJPNVDf7z/lHoMW6/8RaCc/Pw+AIHHw4VbRvMQcTSn8r7pBpV+E+omWeA6NR7 m7TkG3dNP3d1hzVgsvmAxXSWEtGlSP+fhfCpaOemUgexgdVmwKSJJJdQC4Z79lJUFXXTUF Rkqy04af873x9aiBS1yCiM0QaLJLZxg= Message-ID: <778b4f10-5e4d-72f8-32b6-1e20c7300bad@suse.com> Date: Wed, 8 Feb 2023 08:35:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH for-4.17 v6 2/5] libs/light: Rework targets prerequisites Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-3-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: <20230120194431.55922-3-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------APpGJ5s0DotdnxR4EUT4nHxr" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------APpGJ5s0DotdnxR4EUT4nHxr Content-Type: multipart/mixed; boundary="------------SMrOlJfIzq7uZ1mT880h4VXx"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu Message-ID: <778b4f10-5e4d-72f8-32b6-1e20c7300bad@suse.com> Subject: Re: [XEN PATCH for-4.17 v6 2/5] libs/light: Rework targets prerequisites References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-3-anthony.perard@citrix.com> In-Reply-To: <20230120194431.55922-3-anthony.perard@citrix.com> --------------SMrOlJfIzq7uZ1mT880h4VXx Content-Type: multipart/mixed; boundary="------------0orpuLnNhOpClhuJj0y5cUkc" --------------0orpuLnNhOpClhuJj0y5cUkc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDEuMjMgMjA6NDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBObyBuZWVkIGZv ciAkKEFVVE9TUkNTKSwgR05VIG1ha2UgY2FuIGdlbmVyYXRlIHRoZW0gYXMgbmVlZGVkIHdo ZW4NCj4gdHJ5aW5nIHRvIGJ1aWxkIHRoZW0gYXMgbmVlZGVkIHdoZW4gdHJ5aW5nIHRvIGJ1 aWxkIHRoZSBvYmplY3QuIEFsc28sDQo+IHRob3NlIHR3byBBVVRPU1JDUyBkb24ndCBuZWVk IHRvIGJlIGEgcHJlcmVxdWlzaXRlIG9mICJhbGwiLiBBcyBmb3INCj4gdGhlICJjbGVhbiIg dGFyZ2V0LCB0aG9zZSB0d28gZmlsZXMgYXJlIGFscmVhZHkgcmVtb3ZlZCB2aWEgIl8qLmMi Lg0KPiANCj4gV2UgZG9uJ3QgbmVlZCAkKEFVVE9JTkNTKSBlaXRoZXI6DQo+IC0gQXMgZm9y IGJvdGggX2xpYnhsX3NhdmVfbXNncyouaCBoZWFkZXJzLCB3ZSBhcmUgYWRkaW5nIG1vcmUN Cj4gICAgc2VsZWN0aXZlIGRlcGVuZGVuY2llcyBzbyB0aGUgaGVhZGVycyB3aWxsIHN0aWxs IGJlIGdlbmVyYXRlZCBhcw0KPiAgICBuZWVkZWQuDQo+IC0gImNsZWFuIiBydWxlIGFscmVh ZHkgZGVsZXRlIHRoZSBfKi5oIGZpbGVzLCBzbyBBVVRPSU5DUyBhcmVuJ3QgbmVlZGVkDQo+ ICAgIHRoZXJlLg0KPiANCj4gImxpYnhsX2ludGVybmFsX2pzb24uaCIgZG9lc24ndCBzZWVt cyB0byBoYXZlIGV2ZXIgZXhpc3RlZCwgc28gdGhlDQo+IGRlcGVuZGVuY3kgaXMgcmVtb3Zl ZC4NCj4gDQo+IFJld29yayBvYmplY3RzIHByZXJlcXVpc2l0ZXMsIHRvIGhhdmUgdGhlbSBk ZXBlbmRlbnRzIG9uIGVpdGhlcg0KPiAibGlieGwuaCIgb3IgImxpYnhsX2ludGVybmFsLmgi LiAibGlieGwuaCIgaXMgbm90IG5vcm1hbGx5IGluY2x1ZGVkDQo+IGRpcmVjdGx5IGluIHRo ZSBzb3VyY2UgY29kZSBhcyAibGlieGxfaW50ZXJuYWwuaCIgaXMgdXNlZCBpbnN0ZWFkLCBi dXQNCj4gd2UgaGF2ZSAibGlieGwuaCIgYXMgcHJlcmVxdWlzaXRlIG9mICJsaWJ4bF9pbnRl cm5hbC5oIiwgc28gZ2VuZXJhdGVkDQo+IGhlYWRlcnMgd2lsbCBzdGlsbCBiZSBnZW5lcmF0 ZWQgYXMgbmVlZGVkLg0KPiANCj4gTWFrZSBkb2Vzbid0IG5lZWQgImxpYnhsLmgiIHRvIGdl bmVyYXRlICJ0ZXN0aWRsLmMiLCAibGlieGwuaCIgaXMgb25seQ0KPiBuZWVkZWQgbGF0ZXIg d2hlbiBidWlsZGluZyAidGVzdGlkbC5vIi4gVGhpcyBhdm9pZCB0aGUgbmVlZCB0bw0KPiBy ZWdlbmVyYXRlICJ0ZXN0aWRsLmMiIHdoZW4gb25seSAibGlieGwuaCIgY2hhbmdlZC4gQWxz byB1c2UgYXV0b21hdGljDQo+IHZhcmlhYmxlcyAkPCBhbmQgJEAuDQo+IA0KPiBTaWduZWQt b2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCg0K UmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVy Z2VuDQoNCg== --------------0orpuLnNhOpClhuJj0y5cUkc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0orpuLnNhOpClhuJj0y5cUkc-- --------------SMrOlJfIzq7uZ1mT880h4VXx-- --------------APpGJ5s0DotdnxR4EUT4nHxr Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPjUN0FAwAAAAAACgkQsN6d1ii/Ey/z iAf/SXId6hTOqhv8reqTqxvXAz2WpE0RbydR+TJ2wVecs8Rq/cFxmiWnRaHO2qp/k6PvQ6XGVFeM j6FIcsEpN7mMisoxxoSJKLFJcUgrsWpJ9P7YuSaqzcL2rgNZkZYQNavo/JS+h+Bm/kyjLuVZOcUj QwdHmHliVVwbRu4912XtRjLIThz0SgoP3gBoCoiHLiR65VlzESR0M4eg/eY7UFrtpfYT0M0Z1I08 hi1kpvNsOABjokC8K7wFihzWfg5EvORKK0b/CSdr3dBXGubB8ps8euXnbCTJRRjredwy1EDvuN77 cBFmK6RISzCBEOzrhOkwnYYsQEM1VJtV/PF3EF4Ubw== =8b1e -----END PGP SIGNATURE----- --------------APpGJ5s0DotdnxR4EUT4nHxr-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:41:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:41:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491595.760776 (Exim 4.92) (envelope-from ) id 1pPf4e-0003NA-Le; Wed, 08 Feb 2023 07:41:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491595.760776; Wed, 08 Feb 2023 07:41:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPf4e-0003N3-IJ; Wed, 08 Feb 2023 07:41:00 +0000 Received: by outflank-mailman (input) for mailman id 491595; Wed, 08 Feb 2023 07:40:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPf4d-0003Mx-6S for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:40:59 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20601.outbound.protection.outlook.com [2a01:111:f400:7eaf::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec9b809d-a783-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 08:40:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8715.eurprd04.prod.outlook.com (2603:10a6:20b:43e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 07:40:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 07:40:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec9b809d-a783-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbBL+otwZm0mm3IfwZp0KVwGoF5lyOSwgFrOoqvFZPqVFjLGrfERGMi/wC7GPa65w56qw48q/ZoB4EXZlduiMiDWI/EWNWzyDtYv5w/1WYqJQQNZKWMBpu71Ngj5Un8OYJBbacubgP1y0yVs+wVBXS+03i/Cb9tsVfyAAod+QuFAg597cIHMbbyiKMTSVkXsSNY83e0iDFbBen8Lb09p0IbPcmpba8ZFGoJXceodPyTQRc7ozxL8OKW3O5Qv0LBFcSerRFfbA/SorVEbg3hZqAXC5+tj9McHc2Gl2v41gArWLH0dqaft/VQAAA9yH4WYs4lHE0yqcK8IXDU7MuOuHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMHdsj1dxM24biHuwFUsHVtaHLX5hyeS4TF1uR4NEk4=; b=k70qq6L1DL2BbmeNFNzGjzNuxnUJjMidDoQ6g7b95GZQ8aqIobfhSUZx0kM0PmXvihH9qjDnE7x+coaC7ZAWdGFjfrXmZdQWLP03BXxI4yOhxifUSBCybrIFzZ1Xhs4rXuZdmqHII1v7qee89yuUCGW34VtXrwElPM2t4lx8mWVrg76tTXSLYnORRI9ExBqDVjdEYAgJ6PhtavqM1kMxJezYyTh2TJkFbMmzPujXpWzayELYV7Vrzpz/q7JRAStuUjYXsdgAe7vLd3T31jbD4jNbLIQgglwdkQIlycr41aBo+LknMRLxttt+WSH3J2POg0Pi3xRMaVpeJTcRS5/3jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vMHdsj1dxM24biHuwFUsHVtaHLX5hyeS4TF1uR4NEk4=; b=eOrN6Hy8zQ3tQLO/QWKIDVZonVzjbAAKO1WafQVpJIgEiIdrFvmOOkczXKKu0KSbif6+X5TrkCNyoOUAC8+4h9VbObmn10YKYQm3turKCm+SfytJ5pjE76iiHcFvkVD3J5CuzYI/W5/dXOy3+CLu81tzQSTN0QrlQzaq5SZKG8/0ZLicC94PinuWCXGFV9Fv/4YKFnwDIezlWqjOh2WlVB/WWvlUs1P704XXzh9dcRY8w2RBMHhjlZV8VHbclZEaxDYci+6HRgbXBeE9dN8WesoRGIvfZ5Sk8wpMs7Q8FoIr+T2lGSmJvXY8NzgrKZfyypr8NCwvTu6m+T8Dw37BTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f3c358e-02b9-94e0-0b06-8a96ff92519b@suse.com> Date: Wed, 8 Feb 2023 08:40:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Content-Language: en-US To: Demi Marie Obenour Cc: Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8715:EE_ X-MS-Office365-Filtering-Correlation-Id: 32ea974d-671a-40b9-ee53-08db09a7cf8a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 67kQRuswuycAYHUkfSTkijOswe7ub66r+lnJ8b4b/pxUNRxZIwXeAlVj2OXb+kZMfdVtv8DkzrWmCEPxTY3cjTYSU0Yrdv0WoK8Luzj9NlrLUyhhTft0eEzb9lRfwb01ISbgwoXsFlaKV4ubIR1olbgKSgHQ/riO8rk3FFDlO9CPmY03L9icrEIcuLbFrlq5APs2r07bzx0u3EbW21MS/VZf0CVH0QZPvMMwY6TAfHtczQIzVXlqbmVv3pwUz++9JB4gasYwlyBZKfG8fzlgT84HQcljqKz4Hdxw10uaF59t7RoiRcSqy+dUXfgqjCUmemsUxeAh4rYRDXQjhF6c8pj+ZeN00+T+JOuNj4teo9HDgb/R0ca0bFca6VXeVGJKcYbZ4ByXu8DqB0McTaPyLlOoVRdr+Yv0gVQk5AGGKVzTJEO04ePNQTY5xBYBRmA1fydiAvnviOSZTOpMfw8tZW3C125VK4oY53wgp45zyl3QQpQ7NtuDmx2c38wGPdRZotuQZamBSqtcwbDtLRXDoyYDkUH6Vc7JuhsN2Oj1PDOWewdrJcaOw7NbVLJ2x59Bcyw3+5/goLVSSNTIwqVQ40wPDlBECDLeMkUO5nszy8603rEfBa+0Ht1DOxj+o1LzGxzPm4V0sCG5Sg0icPIdRigbqlyK6Fc7ErzzqDuKfl/UIwZ8AxPupoCc8wB0GV8r9eYbymJXqz5WnKleMOGPDb2bBLSVxGQ4YGLhYlBF2OuCYYl5z5iasGTBJmPid88i4EhVsgoJ/qWNsuIX2soiesG86cz2fAdZTKFq+RP8YhBvVZjjQ9OLgSGKw79nePO6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(346002)(136003)(396003)(366004)(451199018)(31686004)(36756003)(26005)(186003)(86362001)(38100700002)(54906003)(31696002)(6506007)(2616005)(83380400001)(6486002)(6512007)(6666004)(966005)(478600001)(8676002)(66556008)(316002)(66946007)(53546011)(7416002)(5660300002)(4326008)(41300700001)(6916009)(66476007)(2906002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlpQeUgxM0xvRnBRVEszenJZSFNhWFlrWk85Zno5VUNMUnNZK2llbUZkRDM2?= =?utf-8?B?STNwcGFoQ0xIa2tSTVc5T3dZUVkzVUhCN3BldXlNb2l1VWNLbkRmWUdJaDlo?= =?utf-8?B?d2NoOHRPbjZwTFpCdytTd2NJSzdLYktMRUIybU1mUHQrcFBIUGx5bW10NHVV?= =?utf-8?B?blZjQ205ak0rUEFTdkpUZlFUUUVMbk50NEY3aURVNVJySlJ5cjA4amNwV3FE?= =?utf-8?B?ckZlQnZabExjTngwS0oyNitvcWQyRk9yL1lYVmFnbER2dXJjUnE4VlBvZ0U2?= =?utf-8?B?UzRlL1ZRTFJCS2J3bFQwb0FRdGJwTGhoSW94Zlp0SURUZXlvaGdobHVTazho?= =?utf-8?B?Tk5rb1RkTFliQjJCUUVsbXFWeXU5RE5Ec3RyUHN4VzZhRjNpTDBxZi85OVZJ?= =?utf-8?B?R2I0OWMvMHZrc3c2YkxsaGNDMlpDazdkbmlTQ2gzbjhWWVdiY2Z0K2d0ZTdv?= =?utf-8?B?VjdFSkhJVFdJVzFBY3ZvSzJqK0lXUUlRcHQ1RDhhSHl2UE54eStRSldmdVhG?= =?utf-8?B?dGZTWkd0YmxteWErek5EcldTTHJvOGxEM1hNT2o3Y3hnYzVWL3pLWXN3Zkcw?= =?utf-8?B?NnZWNnRSSWNTNW1XQThJT3JSTEpHdElhSW13MHRHK0ZtaU9QdEJLYVhYdSto?= =?utf-8?B?cmU0R2ZnakVtK3g3UlVGT1hHLzEySWNSaWRUTDFybllhUWwwb3hZcnNKczlY?= =?utf-8?B?MG4xRjl1Y1c5MnEvNFVHRjh0ZDA1SUlXM2RCdkczSEdPTXhLbTJsM2FlVU5K?= =?utf-8?B?a20rREx1dXlFVDJmYnY5YXJxVUNJUEZBcFVQaDZIYURNemYwbmR2blNWS3dG?= =?utf-8?B?SkpWNU1QdFoyZXhCODNQREZoaFZzdlV0bVR6dVZlZ0wzWmNmTnVOOU54OWU1?= =?utf-8?B?OSs4V3BFTHVzR2lsbWsyOHo0M0tGWEVOQXI3L3k0dlJWQnY2Mk4yc3BFaGFM?= =?utf-8?B?OFZEa0dHRnBVSkFSZXk1N0FoVm9wSVdabWNMK0JpT3lNd0pLSjBJWDRhcGZq?= =?utf-8?B?MDI1RGhHRXZ0djJtV1hMQkRYcGNHc0dRSzJJMDFqY2xNOEp6cmdQQXBoQ3pM?= =?utf-8?B?bTVma0NWQVJYaG5Ea1FHdUp1bHNiWVY0ZFp6ZmdMOWpSVnVMZlEyYzRRWEpT?= =?utf-8?B?SFFoaUl1Q3REK3QvcGxGZlhRazZ3Y3Z3K2UyeG9FTXJjRm1iR3V1QitvRHhn?= =?utf-8?B?RE9IcjlnNGQycGU1M0Nwb29ic2NkR3hKK0NNbjVMV0dScUkyZ0tyZngzeVNX?= =?utf-8?B?Z0N6NXVEUVhZbW5tLzc4dWZ6OVQ1MVF4eE1vMTFMRnRwZW1nT24vOTRzVThv?= =?utf-8?B?eTAwN3V5WGo4RVJ6ZUhYSlJ5ajhDNnZKMGd5RElBT29JUFNqOWRKOGNiZkVk?= =?utf-8?B?eFlqVjhRSi9EMzRMd2dDdXhSeS9uTVZZV1JReU44b0xKWi90eUVvWjRPME1R?= =?utf-8?B?T3F1ZFU2cW9lSVVlbmlJbGJ0RWRnRXpnaG43RUdLZ25pbm5zZlh1NUlRcEFz?= =?utf-8?B?ME1mZ0NPM1c4ZTFKMzdEZXlCcnpjMTBBNm53aWFOSGxsSzFEdFk4aCtPVHRt?= =?utf-8?B?dERzRzJkc2J2WUE2ZTFuWVdock1BL2RaQjFvampqckRZZXdrTENSd3pKNnR1?= =?utf-8?B?am5KWWN1SUJRYU4vcmlaYXlrMUVJYWlRZVhFa0UxakxNSkhQK2ZlWU1lYnp0?= =?utf-8?B?THRCN2ZpT1hmK3B6OGdmQnlaWlZVcUhjcmlNWVd6WGdtbzcxemxaOVhja29L?= =?utf-8?B?SXZ6RldmOGxqMlcxTFlrUUljNFNxaEhINWRJeHpsbWlwMEI5R0ZIUUxwTTU5?= =?utf-8?B?NUFqMFQ0cUt1cXZSZFhHdlU2c25iRk5VcURPUjZUUnhZVDUwNy9RK0xJMWIw?= =?utf-8?B?RjZ4TVo4TlZZSzZjdGpvOGZVNUl4UFlJeVh4Y2NOSEsxMGZJdC8zZUhObk8y?= =?utf-8?B?Z002NExFVkhYYzZxWjB4d21QaUwvZmZobHYvbzZSV0NWanJrK3pvQXFid21E?= =?utf-8?B?NzFqNjVnTXVtNXg2WUlsQ29mMmo4Q0pOQkhSMXlXaUZibEQrRStjNnEreThG?= =?utf-8?B?UEhlRE5PQy84bVFPRXFjWWlEV2lpU3hKOFE1S0Z3ZEhFWWNZcDlWYytHbVFR?= =?utf-8?Q?me17N+/ieOkulTDaklxoOeIbe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32ea974d-671a-40b9-ee53-08db09a7cf8a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 07:40:55.2202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y1oj6ZyGDTsnnWRzj4tCp8SndgTZfRPgxunWwAKXYifxzmoFLGRwLtUG6hVG2zmNE6lXzM7HlGPgFdtbutTfqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8715 On 08.02.2023 05:51, Demi Marie Obenour wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include At the example of this file: While the above matches $subject, ... > @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) > * Device [8086:2fc0] > * Erratum HSE43 > * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset > - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html > + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html > */ > { PCI_VENDOR_ID_INTEL, 0x2fc0 }, > /* > * Devices [8086:6f60,6fa0,6fc0] > * Errata BDF2 / BDX2 > * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration > - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html > + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html > */ > { PCI_VENDOR_ID_INTEL, 0x6f60 }, > { PCI_VENDOR_ID_INTEL, 0x6fa0 }, ... this doesn't (and would rather belong in the earlier patch). As to $subject: Wouldn't it be more logical to replace the license boiler plates by SPDX headers instead? This was done to some degree on Arm already, but I haven't gone check why it was done incompletely there. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:42:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491601.760787 (Exim 4.92) (envelope-from ) id 1pPf5c-0003ta-Ut; Wed, 08 Feb 2023 07:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491601.760787; Wed, 08 Feb 2023 07:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPf5c-0003tT-SB; Wed, 08 Feb 2023 07:42:00 +0000 Received: by outflank-mailman (input) for mailman id 491601; Wed, 08 Feb 2023 07:41:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPf5b-0003tL-Jq for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:41:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 114f2699-a784-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 08:41:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5D40B1FDD6; Wed, 8 Feb 2023 07:41:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E11813425; Wed, 8 Feb 2023 07:41:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YeyvDUZS42MybQAAMHmgww (envelope-from ); Wed, 08 Feb 2023 07:41:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 114f2699-a784-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675842118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v2Mem9p52JvWtPHOGMgTswkwbfxUxket1zvpVWYpEVM=; b=c9dW85e2EXORUmzmnlTbuH6J1n5n1YHFTRXFJSMySUdXWSF17luYLtj2AiiJA0xNZtBFhQ ZBh4H5xUTMZ3YdyUUQW66V/qNmlB/XSduaSHJrRbsyXE1B64spA5dLmlfL+vqGpkOebBe4 QdRCb52af87G0jw4aVmzQmgIcHXhjos= Message-ID: <8866d2e0-5fd4-2cdc-25e5-59d7804e9ea1@suse.com> Date: Wed, 8 Feb 2023 08:41:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH for-4.17 v6 3/5] libs/light: Makefile cleanup Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-4-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: <20230120194431.55922-4-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HNFGBM54abUzU4hrEdEp50fY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HNFGBM54abUzU4hrEdEp50fY Content-Type: multipart/mixed; boundary="------------2VtDEpAU1gxpdmVN1DeRGrHv"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu Message-ID: <8866d2e0-5fd4-2cdc-25e5-59d7804e9ea1@suse.com> Subject: Re: [XEN PATCH for-4.17 v6 3/5] libs/light: Makefile cleanup References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-4-anthony.perard@citrix.com> In-Reply-To: <20230120194431.55922-4-anthony.perard@citrix.com> --------------2VtDEpAU1gxpdmVN1DeRGrHv Content-Type: multipart/mixed; boundary="------------L0isKTxR0yOiesm0XP5a1gWH" --------------L0isKTxR0yOiesm0XP5a1gWH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDEuMjMgMjA6NDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBSZXdvcmsgImxp YmFjcGkuaCIgaW5jbHVkZSBpbiAibGlieGxfeDg2X2FjcGkuYyIgYXMgdG8gYmUgbW9yZQ0K PiBzZWxlY3RpdmUgYWJvdXQgdGhlIGluY2x1ZGUgcGF0aCBhbmQgb25seSBhZGQgInRvb2xz L2xpYmFjcGkvIi4gQWxzbw0KPiAibGlieGxfZG9tLmMiIGRvbid0IHVzZSAibGliYWNwaS5o IiBhbnltb3JlLiBVc2UgIi1pcXVvdGUiIGZvciBsaWJhY3BpDQo+IGhlYWRlcnMuDQo+IA0K PiBHZXQgcmlkIG9mIHRoZSB3ZWlyZCAiJChldmFsIHN0ZW0gPSIgaW4gdGhlIG1pZGRsZSBv ZiBhIHJlY2lwZSBhbmQgdXNlDQo+IGEgbWFrZSBhdXRvbWF0aWMgdmFyaWFibGUgIiQoKkYp IiBpbnN0ZWFkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhv bnkucGVyYXJkQGNpdHJpeC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxq Z3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo= --------------L0isKTxR0yOiesm0XP5a1gWH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------L0isKTxR0yOiesm0XP5a1gWH-- --------------2VtDEpAU1gxpdmVN1DeRGrHv-- --------------HNFGBM54abUzU4hrEdEp50fY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPjUkUFAwAAAAAACgkQsN6d1ii/Ey+o Kwf7BjOxhajY5ZWmQiyJKBxJOeJASE1Stt3zKyd8tAHsYzxa59C/dxtbiHVtySd+zEhv7GkvP6nF AOHiXzMmCvsg1DvIF2sGIRIN3FJhNVvr6VQRk3Fp6Ff4SdiW76yhlmFWOQEHSyLAoHZmCUIX9+YG 1UvcRrsB/4fzL0RMA6S2X8s6s2OYDG0pp42t1us1lfV0JXY5Kr/Cbq5PLq2oWlIGoxe00/jFxNN1 ANQxP3u91HXMBjtNChV3HJ8cHinmobgTuUDn1xURg3TFHIIPrU1lYoJJy6L+EZFT3AdxopFCouL+ PwfKblBIF/gNz9qsGWz8uKNCiNWiRgBotVEZUPq+xg== =HFKm -----END PGP SIGNATURE----- --------------HNFGBM54abUzU4hrEdEp50fY-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 07:48:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 07:48:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491608.760797 (Exim 4.92) (envelope-from ) id 1pPfC1-0004hm-LF; Wed, 08 Feb 2023 07:48:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491608.760797; Wed, 08 Feb 2023 07:48:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfC1-0004hf-Id; Wed, 08 Feb 2023 07:48:37 +0000 Received: by outflank-mailman (input) for mailman id 491608; Wed, 08 Feb 2023 07:48:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfC0-0004hZ-5j for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 07:48:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd0782f4-a784-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 08:48:34 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B67411F8AA; Wed, 8 Feb 2023 07:48:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9722813425; Wed, 8 Feb 2023 07:48:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9buBI9FT42O7bwAAMHmgww (envelope-from ); Wed, 08 Feb 2023 07:48:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd0782f4-a784-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675842513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tucXlCXEqqliuqXuPmdogZ+wrgldXIdN/2httANrX/M=; b=VTFofPOexpBmO639Mq02ozXJUdLm75I27i7raUn27plf03RQheUCQ7GlhcVk0d/I7leMzV /K8IkzJrhBsNf7/ZchVm4boou+8iN1kOM1Igw/le/Lgr2L0lrJcq49BAKAy+kQEocCUbrF bKqJbxZvUmQZ85vz0NTcv8F6+EgB4RI= Message-ID: Date: Wed, 8 Feb 2023 08:48:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-6-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: <20230120194431.55922-6-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------h9owloSCSzLYg0sdCqtZqI71" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------h9owloSCSzLYg0sdCqtZqI71 Content-Type: multipart/mixed; boundary="------------qDYDCpw0cKZds2C7BEkWMtme"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu Message-ID: Subject: Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-6-anthony.perard@citrix.com> In-Reply-To: <20230120194431.55922-6-anthony.perard@citrix.com> --------------qDYDCpw0cKZds2C7BEkWMtme Content-Type: multipart/mixed; boundary="------------9GPa8ZrkbXXvgJnFE7kjL6Zf" --------------9GPa8ZrkbXXvgJnFE7kjL6Zf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDEuMjMgMjA6NDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBMRExJQlMgaXMg dXN1YWxseSBvbmx5IHRoZSBsaWJyYXJ5IGZsYWdzICh0aGF0IGlzIHRoZSBgLWxgIGZsYWdz KSwgYXMNCj4gcHJvcG9zZWQgaW4gR05VIG1ha2UgbWFudWFsLCB3aGlsZSBMREZMQUdTIHdv dWxkIGJlIGV4dHJhIGZsYWdzIHN1Y2gNCj4gYXMgYC1MYC4NCj4gDQo+IFJld29yayB0aGUg bWFrZSBtYWNybyAkKHhlbmxpYnMtbGRsaWJzLCApIHRvIG9ubHkgcHJvdmlkZSB0aGUgbGli cmFyeQ0KPiBmbGFncy4gJCh4ZW5saWJzLWxkZmxhZ3MsICkgYWxyZWFkeSBvbmx5IHByb3Zp ZGUgdGhlIGV4dHJhIGZsYWdzIGxpa2UNCj4gdGhlIC1ycGF0aC1saW5rIGZsYWdzLg0KPiAN Cj4gQWxzbyBmaXggInRlc3RfJSIgcmVjaXBlIGluIGxpYnMvbGlnaHQgYXMgImxpYnhlbmxp Z2h0LnNvIiBpbg0KPiAkKExETElCU19saWJ4ZW5saWdodCkgaXMgYmVlbiByZXBsYWNlZCBi eSAiLWx4ZW5saWdodCIuIEluc3RlYWQgb2YNCj4ganVzdCBjaGFuZ2luZyB0aGUgZmlsdGVy LCB3ZSB3aWxsIHN0YXJ0IHVzaW5nIHRoZSAkKHhlbmxpYnMtKiwpIG1hY3JvLg0KPiBGb3Ig TERGTEFHUywgd2Ugb25seSBuZWVkcyB0aGUgb25lIGZvciBsaWJ4ZW5saWdodCwgYXMgdGhl IG9uZSBmb3INCg0Kbml0OiBzL25lZWRzL25lZWQvDQoNCj4gdG9vbGNvcmUgYW5kIHRvb2xs b2cgYXJlIGFscmVhZHkgaW4gJChMREZMQUdTKSwgdGhleSBhcmUgZGVwZW5kZW5jaWVzDQo+ IHRvIGJ1aWxkIGxpYnhlbmxpZ2h0LnNvLg0KDQpJIGRvbid0IGxpa2UgdGhpcyB2ZXJ5IG11 Y2guIHRvb2xjb3JlIGFuZCB0b29sbG9nIGFyZSB1c2VkIGRpcmVjdGx5IGJ5DQp0aGUgdGVz dF8lIHByb2dyYW1zLCBzbyBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCByZWx5IG9uIGxpYnhl bmxpZ2h0DQpkZXBlbmRpbmcgb24gdGhlbS4NCg0KDQpKdWVyZ2VuDQo= --------------9GPa8ZrkbXXvgJnFE7kjL6Zf Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------9GPa8ZrkbXXvgJnFE7kjL6Zf-- --------------qDYDCpw0cKZds2C7BEkWMtme-- --------------h9owloSCSzLYg0sdCqtZqI71 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPjU9EFAwAAAAAACgkQsN6d1ii/Ey/u Rgf/ToA05R83oh3Zxnn9QBhbo/DWFt/KwXWWDlQZTU2bb2V66C4cT7sk8C9XJD7EdNBQTX2oUyg/ qqdJTWZBHBdHwPkcA26BVd34BJOLoFGUSKlq0NvyLSsNSTRTp7lH2b2qswDbGcFSft8nq5b90pOp 7QVx7KBneQnjH3GAUgqEMsavxHeAXZgHqH2Od+OQ91Nvlqk9WT9yHWiMP7yEcNyn2O/GShEKFjsc d7+sD4P3YlRxRCFZTHSSi5vACCtB5h6LhkoLDzra5LKHAy2t95s9YNXzUDmlnivXOCx7f4OzMzcG i1mSpFlAq9qJ5Wm+R7vQMaQwjlMs6ZG+5GYpNamobA== =l8fu -----END PGP SIGNATURE----- --------------h9owloSCSzLYg0sdCqtZqI71-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 08:03:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 08:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491619.760809 (Exim 4.92) (envelope-from ) id 1pPfPf-0007lK-F0; Wed, 08 Feb 2023 08:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491619.760809; Wed, 08 Feb 2023 08:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfPf-0007lD-AX; Wed, 08 Feb 2023 08:02:43 +0000 Received: by outflank-mailman (input) for mailman id 491619; Wed, 08 Feb 2023 08:02:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfPe-0007l7-Fh for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 08:02:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1a::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4ace4a3-a786-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 09:02:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7588.eurprd04.prod.outlook.com (2603:10a6:20b:2dd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 08:02:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 08:02:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4ace4a3-a786-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l4ALZ45AqEpW4QxJhE/AoKeGjdb8KyUFKd6Qimup+Sv5xNXtNno7f9b29uYk6semC5DgWISwR9zQzy/Pb18aG15LfQhth22wDjrZEg1ZZvmnvuv7o5iYusJgaaihIcowuDBZgTxcRXnpF7bNt5sLOv2OfaUYRgMcG7hLr0Kh3Ql3iaQ3Nm2evB9+zvjmGEdGlDIO3pr1PlOUCVdmZfIb1Z098p2LL8bpohML0s0XSAB8T/BA/rZzOPAEVQLBdAsMEgvB4glWlpIeyNJSl1Dq1z1er/bx1QQ4W/1OhMM1uYBNjPJeUR9VKwqGzDQCRedYMnJ4U0Ygux/c/o7VOsyoHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dzPI/saA6KVcDXF5RleaoZ+pK0Fg6mAKbIgPAm4x9Ls=; b=TnFVLHzfaMU1O7ac5oM15UdOiedc3xZAnHRLpkX7qgo08TXSwhE70eOwTLJly8NknjTG2ZlbmoWYQBMn0qBc+hK+VoZN4cqPL58w/8ZYYDwP1kkyoT4kYroxGD4r2fO6D+E3rOyP4vDewGSXAti6qG5Z2DVjVOKVRVKQNsQ1gB3zC6ZekxmCBR7VWtROr0bD2IS/TztD+7n8CVTnV19gfjdOo/UYqIhYSZ2+87zRNkkpRUin8CrIVJKzUYwbGofVJPbL+amBP4k6WfAiR+A5BwOCwTrCrVj2p8of6FolRm2457auxSMiaoP5oh4ZT2wV4IXBvW6IpQpWva35CLaDAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dzPI/saA6KVcDXF5RleaoZ+pK0Fg6mAKbIgPAm4x9Ls=; b=uCrnlSZDjQpYITVWQzorXnlcw2jKntQd81vBO9shOr2AFIwZuIfEtROl6t6NwE1MtpF7yUveky5hIq1Sy9+rHZ5Td/sFVUruXCFxZfWHbUX30B9In0ylNukVRo8HdtOIHO2vhGftBrWSah9LdrqlRChkQiMoRKKBN62zn00RnzxIX0D0UG8rPwvlniERoP3PggAekxn2xn5ZHuR1xewXaogChtFO2nBi/iTeszzNaFoGqQ/ryreg26qINwxy4y2pn8BFu8xM4iUxXrhxACgYL1X/NUqvevJ7RkqFMHwQ61kgGzn3R4910yc+IMISP5fgwy6Pq2uCDa6n5GmHPtuzgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e01f840-1d42-f31e-4471-ee06820b4b31@suse.com> Date: Wed, 8 Feb 2023 09:02:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Content-Language: en-US To: Anthony PERARD Cc: Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20230207160948.3169-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7588:EE_ X-MS-Office365-Filtering-Correlation-Id: 65ff4528-34bb-4349-acfe-08db09aad7c2 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NTsSTlqnxk6KtvNmLx3RHkVYJwQp6cyIjf2e8gBs7XZ56yIO7lD/mizNZnvFlhWWj0D74Cl8iAZHwNwIMxzVN+kdtr+wvJhxvUj0F32B6UjRbP1S2SpCw8WLDXd6Ni6Z3ZO5j9OUs9DlreNt7xnacqX9plB9eSm62LJAnEGH0wjk/R7pnB6EqZ4k7i7cWEueeH2zRuGNiYx0tLxosvE7CBmXB26UJo/yY+N0kH3NpFKBARHQqM/mLT5NNFfbACri6lP/BT+WJgDUYfFgLXhM4BVi7hm2qjNmh5PeoKH1x4Ta8DgUXI81hQfjQUIcEFiuWlClH7CNniLJaE0pnXUwQUz3VKjzVRrCLXZ2v43q1EWc2vdgEiVghKMUeI/GxyyL8lfOCcrQ3TRRUhhpoJo5ehZ1aqK8dBlSbvejkMiQtqovE4e4p64+Tr6BvN3kVfpVOnnYi/q0zJiWojRSOyIUhM7E34O9+VdnpPHX8APhDOAxKGmtAqP04lgbZzn7CZ9iAIVpL5w6sAQDSbWiRra6t/0HF2//CXaVlLzQyvMrfjirzyVFXerVa+t1GQYXb9bcTv0B8EBv0cx2GSGpBJVOY7GNxK6q3ysEBL3536o74LBVf7DCg00DJFUQrVskoE4sLaDGF7Tv2JeWtKeHjT4BZ5nL2IeR46FuD1G5LmZGOfcWgvbIbgMES3CbSyvGTqTb0qVvhBg0WDMKyMZfR1wmU4Ojnq+o7GK+2WtBFLH1kLM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(366004)(39860400002)(396003)(136003)(451199018)(83380400001)(38100700002)(316002)(478600001)(54906003)(31696002)(6506007)(53546011)(4326008)(36756003)(2906002)(26005)(6512007)(86362001)(2616005)(186003)(8676002)(5660300002)(8936002)(66946007)(66556008)(66476007)(6916009)(6486002)(31686004)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0h1eDlkL1psL05ZcGpKOTJ3cTFhdnpDK0pkWngrRUx1aU45NzV1QnRqaXpX?= =?utf-8?B?WEo0eUlrQ3RwS2I5SDdFazBmV000R29ud0ZqTmZMRThoclBaUzI3enlVb2h3?= =?utf-8?B?V2p6L2lDeVQ1RmtMTVE5bFRDeTg3ZXIxelpndjcyNmNjWDdtN0wyNXF4SHZB?= =?utf-8?B?c0xxOXdIQjljTEZHS1ZRNHlhS1YwRFVxVCt4ZVJCc1JnaVZ5dGNnbHRYdjJ2?= =?utf-8?B?dkJiMytlR0lQNDlCc1FYRWh0SHhSSzNTcWYveXIvL3M1a3gvUGhtUi9yOEFW?= =?utf-8?B?Tnc3dzRtZ2JySm44RVVpR1V2TjFpSlUxVTlvWHlJVEZ2S1luL3VsRER6ZDc5?= =?utf-8?B?SXVxRFpKdXhUN1ZlMEFCUnF1WXlpbVVsR3NoT0EzdW5ubXpoWFN2K1JtTHM0?= =?utf-8?B?WWgzekFqMHRIMTNjYUZiWmZaNjBNZGo4UzdCTGZCTy80OGJoYnZXNDVtaDNH?= =?utf-8?B?YlF1NEpHY2RCcUYwYzZWR3RKQWpjanZVY1hxSER1b0t5QUhLRWdyYWtGZTJn?= =?utf-8?B?dGczWTE3Y1pXNG5pZ2xyTENWekd5THJCQ3RibjVKR3B0dHNMclBKWU5CbldU?= =?utf-8?B?Y25KSHYzSFQzQkNTdExwS1QzdS9nSytOOTVBNjA3QWV4NHZTNFBMbm9NQkFQ?= =?utf-8?B?TnZJZ2FmMkdaWDFMT2JMNTJsOWJWYTJGek9rVjkyTS9VbWVmMEZqWW43RHVn?= =?utf-8?B?N3BQSTJxd1VqT29NTHRIMEZlZWNvWkZsMUY5d1d4R3AwazhZVzV5UGVCMk5v?= =?utf-8?B?NE1LeWs4aktLMk1obmpWTlpOY043YWZaME42TlFrN1E4ZWdYYXZnY1NyRm1N?= =?utf-8?B?NGZtc2JFN1gwcUpranBEekc5WTVtV2ZyZk5FREZYdkpUTlJvaFp5aWFQelF4?= =?utf-8?B?MkRLSlNyRU5zZHk2YmdtVTFtL0diTmFVdGdaNEtjcmhIRnRpNy9HZ0w4WHFN?= =?utf-8?B?blV5MUNtL2x1UU9mcU13NXhVbjZDSXFvVHBXZHRXNi9La2g1TTJSZExWUmZi?= =?utf-8?B?RG44VTdSSjBoTXFKSTZDYjEwa2k4d2d5bWZ0NFlmb2lYOUdFM3lSalVndmhi?= =?utf-8?B?dVdUd3JNMkFDVkx2ZVNQaG1FSG1ZdCs2azlLQjJ2QU1tNFgxUk96NUw1aHlx?= =?utf-8?B?QVRYMEV3aVU1ZlU4QzdvR0Q2SDMyQ0JMUUhvaEtsdGdObk1DNjVpc1dVNFov?= =?utf-8?B?Q1RKeFJkSXpJZi9hSnExbUFzRmVySkhTenQvL3Nkd0JiT0tUNS83SlNxSkRn?= =?utf-8?B?bGsvUHlBTWlIQTI2b1Bzd3B0WWVwQVdvajlnejVaaEprNmlhK0ZZK0hURTdD?= =?utf-8?B?bnJkS2dzVytVNDRxSENnc3JPYjN4Rmw3VGl3Q1Z6WjRJSEx4RzBHbEt4MVk1?= =?utf-8?B?NkhxM1NmWEZVL29QcTVzYmJTdEdyL0djTTRVNUlIUlpXeTlFVXRISERFOHh1?= =?utf-8?B?cFV1MWI1REhLL0pxTWhqK0FCRGl3aHlGanB4U0JCeGM4SW9qVk5FMjY2ZGk1?= =?utf-8?B?azBEbkVwRWgxaGVja01QTE5hc29qRTJOd21mbkFud3ZiOUxoYmpFQTI4Rm1I?= =?utf-8?B?RVhLcGpjS1NrUnpuaXZlRk1EWWgyWGZZSDd3ZG81K0NxTzFMNFAxT0RybnlX?= =?utf-8?B?aWxuQVRzNmo2aFJNUVdOSFA3eHFGTnoxY3ZRMXdUYUxQK09HY3hwUUYySk01?= =?utf-8?B?MmFSM00wS2dJejFBL29NTFJJcHlMamM3dURPUkdKUkFYUE5yVGExRFdVWjJi?= =?utf-8?B?TE4zc0lLVmIzZEoybEVWdFdMZzlhQUxTellxQzY3MTZwVFdEN0d6OVNPQnJt?= =?utf-8?B?V2pubTQ4WGVTRy9pZUVzem1GQ0cwd3lUeWwvSnZNTHN4WmFNZUZ3Zjc0dVBF?= =?utf-8?B?Q2pIT1ZsL3dkNE42UXVWa0JaajgzU2ZDQmJlZldPUnJ2L21LaDNub29aNjBv?= =?utf-8?B?dHdZN29PMzBkMyt0MUNVNm5TUVNKRitVSFhPa2IvblNXS3NTNWNJcTFBRDFs?= =?utf-8?B?VlFCdnlmMkRROFlhUDg1bzZNa0djaHowMGJvd3pjdWpyU3NqQitPMndjclNa?= =?utf-8?B?cTJhVitycFV2QTBNeW5zWERmRFBMQWMzcXdLTzc4S28vUlRFYWlaZy9FZWxB?= =?utf-8?Q?MiGu/2qXL5iGjcYqyNwHzdUqW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65ff4528-34bb-4349-acfe-08db09aad7c2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 08:02:37.4038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j29YJr7Qn4qG9ltSAgX0eiD4qfepgD0KXu3NiNNrQ90GiDBD9UaWTuj/8+oycc3gYjyenYlgYkmpW93DJsa85Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7588 On 07.02.2023 19:02, Anthony PERARD wrote: > On Tue, Feb 07, 2023 at 06:03:12PM +0100, Jan Beulich wrote: >> On 07.02.2023 17:09, Anthony PERARD wrote: >>> Both are already mandatory to build the hypervisor. >> >> I'm not sure this is sufficient as a justification. From all we can >> tell even pretty old tool versions are okay for kconfig's purposes. >> However, pretty recently I've learned that some linker script language >> construct used for GNU ld runs into a bug in certain (old) versions of >> flex. Use of that construct will then cause an (almost?) infinite loop >> in ld. Therefore the question is whether libxlu's uses are immune to >> such issues (along the lines of kconfig apparently being). >> >> That said - I'm happy about the change in principle; if so desired we >> could simply see if anyone ever runs into an issue, and revert if need >> be. Nevertheless I'm not convinced it'll address the problem Andrew >> had noticed in CI (and where the consideration to remove the generated > > Indeed, it won't fix the issue. > >> files originated). It is likely to mask the issue in CI (simply >> because, aiui, there are no incremental builds done there), but that >> won't prevent people running into it on other occasions. > > >>> This will help avoid cases where the *.y or *.l files are been updated >>> but flex and bison aren't available. >> >> This is odd: How will this "help"? Right now the build ought to fail >> (it doesn't, there's merely a warning, which might be easily missed). >> With your change configure will fail when the tools aren't there. > > The scenario I was thinking about is when someone edit the *.l source > file, and try to rebuild without flex been installed. It might take > sometime to find-out that the reason change aren't taken into account is > because flex is missing. At least there's a warning, but it is buried > within the rest of the build log. Right, as said - imo this should be (have been) an error. In that sense your change of course helps because it makes the issue more apparent. >>> This also remove the way the missing binaries are been handled, with >>> double-column-rules, which might be an issue sometime. >> >> These double-colon rules should never have been introduced. Double >> colons have a different meaning ("terminal rule") for pattern rules. >> In fact they were my initial suspects when looking into that odd build >> failure in CI. > > After some more investigation, I don't think anymore the double-colon > rules here is an issue. > > I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" > failing to build while "libxlu_cfg_l.[ch]" are been regenerated is > probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of > targets. > > If for some reason we have: > libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c > > Then make seems to take two parallel decision: > When building libxlu_cfg_y.o: > libxlu_cfg_l.h is newer than libxlu_cfg_l.l > -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o > When building libxlu_cfg_l.o: > libxlu_cfg_l.c is older than libxlu_cfg_l.l > -> we need to generate libxlu_cfg_l.c first > Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been > updated do to the parallel build of libxlu_cfg_l.o. > > I can easily reproduce the issue with: > touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; > touch libxlu_cfg_l.h; sleep .1; make -j > And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. Interesting. In my somewhat similar experiments I found that an issue exists only when one of the .c files is missing. Things looked to work properly when both were there, but one was outdated. Clearly that's yet more surprising behavior than, as you appear to observe, the issue simply being tied too "needs updating". > I don't know how to properly fix this yet. > Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is > supposed to be grouped targets. But that's is maybe fixed in 4.4. Well, in my tests while 4.4 has fixed one issue with intermediate files affecting the behavior here, the issue we're possibly running into is still there. I've sent an inquiry to bug-make@gnu.org. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 08:27:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 08:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491625.760820 (Exim 4.92) (envelope-from ) id 1pPfnK-00028o-DQ; Wed, 08 Feb 2023 08:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491625.760820; Wed, 08 Feb 2023 08:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfnK-00028h-9o; Wed, 08 Feb 2023 08:27:10 +0000 Received: by outflank-mailman (input) for mailman id 491625; Wed, 08 Feb 2023 08:27:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfnJ-00028b-Bp for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 08:27:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfmt-0003vY-Lk; Wed, 08 Feb 2023 08:26:43 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.11.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPfmt-0008AQ-Ba; Wed, 08 Feb 2023 08:26:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fu3vjw3MBtxFiRXEBBDdtqVNw4Gwhku2X6kE7vLNfzc=; b=R+259Va7K4AWf70njZ5YztAEQP NY9JEu8kS5IAiX4KHlmiX9qPzb+w7nzAk6AvEWO3s193jG6+sqtg2Pw44Osu/AeH2ULHp4NNMgxpY /zdFgacUIwWlkjrrcJXCtJqOIlB/IwN01DivizEdIXnv6jrYiKZx3eZ4C8otcIP8fY8Y=; Message-ID: <1770bab7-3e25-d611-1d3f-58c02a2f7492@xen.org> Date: Wed, 8 Feb 2023 08:26:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Content-Language: en-US To: Jan Beulich , Demi Marie Obenour Cc: Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> <3f3c358e-02b9-94e0-0b06-8a96ff92519b@suse.com> From: Julien Grall In-Reply-To: <3f3c358e-02b9-94e0-0b06-8a96ff92519b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/02/2023 07:40, Jan Beulich wrote: > On 08.02.2023 05:51, Demi Marie Obenour wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -11,7 +11,7 @@ >> * more details. >> * >> * You should have received a copy of the GNU General Public License along with >> - * this program; If not, see . >> + * this program; If not, see . >> */ >> >> #include > > At the example of this file: While the above matches $subject, ... > >> @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) >> * Device [8086:2fc0] >> * Erratum HSE43 >> * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset >> - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html >> + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html >> */ >> { PCI_VENDOR_ID_INTEL, 0x2fc0 }, >> /* >> * Devices [8086:6f60,6fa0,6fc0] >> * Errata BDF2 / BDX2 >> * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration >> - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html >> + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html >> */ >> { PCI_VENDOR_ID_INTEL, 0x6f60 }, >> { PCI_VENDOR_ID_INTEL, 0x6fa0 }, > > ... this doesn't (and would rather belong in the earlier patch). > > As to $subject: Wouldn't it be more logical to replace the license boiler > plates by SPDX headers instead? This was done to some degree on Arm > already, but I haven't gone check why it was done incompletely there. Skimming through xen-devel, it sounds like it was most likely a lack of time. I think it would be a good idea here to switch to SPDX. That said, I can appreciate that Demi may not want to take on that works. So I would be happy to give a try if no-one else wants to. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 08 08:38:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 08:38:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491631.760831 (Exim 4.92) (envelope-from ) id 1pPfyQ-0003lA-Dx; Wed, 08 Feb 2023 08:38:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491631.760831; Wed, 08 Feb 2023 08:38:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfyQ-0003l3-9m; Wed, 08 Feb 2023 08:38:38 +0000 Received: by outflank-mailman (input) for mailman id 491631; Wed, 08 Feb 2023 08:38:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfyP-0003ku-9S for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 08:38:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPfyO-00047S-HE; Wed, 08 Feb 2023 08:38:36 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.11.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPfyO-0000Hr-BQ; Wed, 08 Feb 2023 08:38:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MgfdcIMpStrNlclkLdooLr2yen3mPvyrAOchQc8yY88=; b=p4unn2ZmfIt9abuQ7DyqEjNR+c iAM55HApr3LO9OYPHeLYk3KGoeVkKP3gXu44wpyzoJ/wUQnw3YxkQY44lE8VYG+LCd1h7BFh2CwEV PbKHnPbc1aVfLmq7/Gg07UMcd47JIMSfxUvgxmKycb1EMopsVtTf+szkJNA4IUMDdHDo=; Message-ID: <1be4d1fc-bfa4-0cfd-b4fb-9a3ac1089c85@xen.org> Date: Wed, 8 Feb 2023 08:38:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Xenia Ragiadakou , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> <7255affa-a0f5-4388-2889-cb523a0246b0@xen.org> <916d173e-16c2-8cde-5815-e8c0396eda04@gmail.com> From: Julien Grall In-Reply-To: <916d173e-16c2-8cde-5815-e8c0396eda04@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/02/2023 13:59, Xenia Ragiadakou wrote: > Hi Julien, Hi Xenia, > > On 2/7/23 15:01, Julien Grall wrote: >> Hi, >> >> On 07/02/2023 12:46, Xenia Ragiadakou wrote: >>> On 2/7/23 14:25, Julien Grall wrote: >>>> >>>> >>>> On 07/02/2023 10:46, Xenia Ragiadakou wrote: >>>>> >>>>> On 2/7/23 12:39, Julien Grall wrote: >>>>>> Hi, >>>>>> >>>>>> On 07/02/2023 10:23, Luca Fancellu wrote: >>>>>>> >>>>>>> >>>>>>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>>>>>> wrote: >>>>>>>> >>>>>>> >>>>>>> I’m not really a supporter of empty commit message, but it’s up >>>>>>> to the maintainer :) >>>>>> >>>>>> +1. In this case a brief summary of the rule would be handy for >>>>>> those that are not well-versed with MISRA. >>>>>> >>>>>> This can be dealt on commit if you propose a new commit message. >>>>> >>>>> I 'm refrained from stating the rule as is because it is strict and >>>>> it is not applied as is. >>>> >>>> I am a bit confused with this statement. From misra/..., we are >>>> supporting rule 20.7. So why aren't applying it strictly? >>>> >>>> And if it is not applied as-is, shouldn't we document the violation >>>> (if any)? >>> >>> I applied it strictly on v2, but there was no review. >> >> Ah! In general it is best to ping if there are no answers. > > Me too I ve forgotten about it. A ticket in gitlab reminded me that it > was pending. > >> >>> Then Eclair was adjusted to have a less strict approach. Still there >>> is a finding asking to add parentheses around dt in >>> dt_for_each_device_node(dt, dn), i.e dn = (dt);, to which AFAIK you >>> object. >> >> Are you referring to the discussion in [1]? If so, I wasn't totally >> opposed to the suggestion so long we are consistent. > > I am not able to find [1]. https://lore.kernel.org/xen-devel/b2f2d1e7-0c18-206f-5e9d-d0115e398840@xen.org/ which is... > I 'm referring to the discussion in > 20221220085100.22848-6-luca.fancellu@arm.com and > 20220728134943.1185621-1-burzalodowa@gmail.com ... a reply to this message. At the end of that reply, I said that I wasn't totally against adding the parentheses but we should be consistent in how we do it. > >> >>> >>>> >>>>> >>>>> "Add parentheses around macro parameters when the precedence and >>>>> associativity of the performed operators can lead to unintended >>>>> order of evaluation." >>>>> >>>>> Is this ok? >>>> >>>> I am OK with this. Is there any ID from Eclair that could be used to >>>> track each error (and so we can confirm they have disappeared)? >>> >>> I am not aware of any. >> Hmmm ok. It might be a nice feature to suggest in Eclair because >> anyone can check whether an issue was resolved. > > Currently, the violations in Eclair are reported per macro call (I guess > because it is acceptable to have parentheses around the macro args) so > it is difficult to track all of them. > >> >> Here, I don't exactly know what to check in Eclair. So I have to rely >> on you. Anyway, nothing that can be fixed for this commit. >> >>> >>> The patch can be decoupled from misra and Eclair (I mean have a >>> generic commit title) and just mention in the commit message that it >>> fixes some Eclair findings for MISRA C rule 20.7. >> >> I have a slight preference for a more generic title. But the current >> one also work for me. > > It can be changed into "xen/device_tree: add parentheses around macro > parameters" > >> >> I will commit later on. > > Do you want me to send a v4? No need. It is now merged with the following commit message: xen/device_tree: add parentheses around macro parameters Add parentheses around macro parameters when the precedence and associativity of the performed operators can lead to unintended order of evaluation. This is fixing some ECLAIR finding for Misra Rule 20.7. Link: https://lore.kernel.org/xen-devel/20230203190908.211541-2-burzalodowa@gmail.com/ Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu [jgrall: Reworded the commit message] Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 08 08:46:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 08:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491638.760842 (Exim 4.92) (envelope-from ) id 1pPg6B-0005JF-69; Wed, 08 Feb 2023 08:46:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491638.760842; Wed, 08 Feb 2023 08:46:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPg6B-0005J8-3J; Wed, 08 Feb 2023 08:46:39 +0000 Received: by outflank-mailman (input) for mailman id 491638; Wed, 08 Feb 2023 08:46:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPg69-0005J2-SB for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 08:46:37 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18cfbc0a-a78d-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 09:46:36 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id bg5-20020a05600c3c8500b003e00c739ce4so879990wmb.5 for ; Wed, 08 Feb 2023 00:46:36 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id j37-20020a05600c1c2500b003daf6e3bc2fsm5133846wms.1.2023.02.08.00.46.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Feb 2023 00:46:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18cfbc0a-a78d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BElElEQ/hIipacRrOOmj7l0wq5XVFry676UGj3ToD4M=; b=JzUvg+GxfFxNR3dLjqK3bEGSDX93ztKUbP+eUDVe8CF1UELKkZg7gwveN0KmSHZRQo Zgw5tbadfODeZ2wa8H1JuatquPLEtTch5yRCW2SLyI82OeIFMwN0f2BFLCl/ykMedQKm eZDdMAnmwPC/HtMjazu/1M0TOn4G5Efn9BL8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BElElEQ/hIipacRrOOmj7l0wq5XVFry676UGj3ToD4M=; b=eCaG/+WVYrGfyYzXMmYLEWKamnK77/pr3dqTme0rmClDsDUaynrrDSeH22JuMjpOnO YZWSnXbZODFpkLgVPQCEgmJi8HE5fzB/7qqDejxe7lTE2otJEIoWEk96E8mQ/ePPl9Cl AtXC8BhaL44DmD2fuFKWNXNRSJ2PshFIeTgYZ3+SgsAN7ekYfH00xTC6Z7DP00cKdcFw sLYCTCJbCdG2QApi+F8HTVX5RZtUssjpMpLBZ0xMO7+y+yFuGcs3Rt1d1W78G+VzMxEZ KxtEONwoww7MZG513XHLkFgHWQ25oeh3f06PRv46/ttzN18uM8sJ9nPM+kXE6KBOsHUB 55Wg== X-Gm-Message-State: AO0yUKV3Kd8HizZxEFWXpfXaHBAxsRAFZfEMJ/yJNpSW/hxXZgfI4K59 AoEsSH8H1OD4NGCMLlntEb9yhg== X-Google-Smtp-Source: AK7set+sf9swTZMuxhMhLBUl7teg09yqYmoBCHyrmMdyt7vUvfNUCXwgEjVNJO+I9lTa9De08ED45w== X-Received: by 2002:a05:600c:130f:b0:3cf:7197:e68a with SMTP id j15-20020a05600c130f00b003cf7197e68amr5753177wmf.18.1675845996444; Wed, 08 Feb 2023 00:46:36 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH 0/4] Stop using insecure transports From: Christian Lindig In-Reply-To: Date: Wed, 8 Feb 2023 08:46:35 +0000 Cc: Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Anthony PERARD , Volodymyr Babchuk , Ross Lagerwall , "Daniel P. Smith" , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Christian Lindig Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Demi Marie Obenour X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 8 Feb 2023, at 04:51, Demi Marie Obenour = wrote: >=20 > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. >=20 > Demi Marie Obenour (4): > Build system: Replace git:// and http:// with https:// > Automation and CI: Replace git:// and http:// with https:// > Miscellaneous and documentation: Only use TLS-protected transports > GPL License Boilerplate: Switch from HTTP to HTTPS Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Wed Feb 08 09:07:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 09:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491652.760852 (Exim 4.92) (envelope-from ) id 1pPgPV-00083c-T3; Wed, 08 Feb 2023 09:06:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491652.760852; Wed, 08 Feb 2023 09:06:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPgPV-00083V-Q2; Wed, 08 Feb 2023 09:06:37 +0000 Received: by outflank-mailman (input) for mailman id 491652; Wed, 08 Feb 2023 09:06:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPgPV-00083O-5L for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 09:06:37 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2b5024b-a78f-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 10:06:34 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id j23so822394wra.0 for ; Wed, 08 Feb 2023 01:06:34 -0800 (PST) Received: from [192.168.1.93] ([188.73.237.113]) by smtp.gmail.com with ESMTPSA id f2-20020a5d50c2000000b002c4061a687bsm106430wrt.31.2023.02.08.01.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 01:06:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2b5024b-a78f-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A733CfuQzZfwFno/lGIp75WMI0UVJz9xDqrK7ocJJh0=; b=ivBxJNLYDSpuGgnFEvV4K+U7v/7i6qTu9yhQ76jk7zxM76h+LJruSsmfZ6Gpat2MK6 SD/IVbcQcLbq9QuXw0y/heTDuzVK2DKxveRn6rf8CDNcbFmpfG6fhWXiGdhXBLFnn1jU 5joR87DX316e9fJ9IwRu8V9jLTGKVoDUfVYR/rsMQBLImmzH3jqqvD8ZQCmj6pkFUT9P tIWQnjOH9KEAsirRhPN4XPPVrtyVHVpNviMXBY0N+v2HIIXOANMGPSKqGzZu+RDkcKDt T2tt/8+KGvESSu2Sgmg1+CQdAsvUbrPSXtHeUXNlyxJP9FN2ERCGgZDxV6YZ6qsAhJdp gezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A733CfuQzZfwFno/lGIp75WMI0UVJz9xDqrK7ocJJh0=; b=T7Y3lFEiM9R5fIy140AoIpaLcXu9s+VFvJUW5502RDO5RrMZLnTEZYmi3eISo3dO3p QBmfjCW/53XdO3H/l7/pptfus77aLecNortM5ItLQlBUjI40i0T0cTopRyT8A8tL7pbT gDRsgXjIa2WZF3Yt5Re0YLC4l58b4BcuU2qFYBCJ2faqnO1doWQTFxDnG+xRmlN2NsRS Iu7quLFQ4OX4cSFLeitHawzjwkUkUSNaCPM5cnZkvebPWdpC0JD+Lcz9Dvqu/7/yDvY9 LMXGAuZAg2hav48G0c1pk1BSo8D1/lNmimEdM82doPgGviREHbc5jlaWoM5dY6soKvAt vedg== X-Gm-Message-State: AO0yUKU1Uxz65VJ0WMuICXxqShGzed6w05BbZfUp/xuAQfCjt7fjCqBn NafkXN8574wXe56/fyJgL6Y= X-Google-Smtp-Source: AK7set9Y8OJg7SjjWr7w7ClvBZ1bZf/Xoyvz4/kChpqQc4yQO3/eegkDFVeN9xq8N/8DXF5oHoK0lA== X-Received: by 2002:a05:6000:8:b0:2bf:b5e4:cd63 with SMTP id h8-20020a056000000800b002bfb5e4cd63mr5899486wrx.8.1675847194029; Wed, 08 Feb 2023 01:06:34 -0800 (PST) Message-ID: Date: Wed, 8 Feb 2023 11:06:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/2] xen/device_tree: fix Eclair findings for MISRA C 2012 Rule 20.7 Content-Language: en-US To: Julien Grall , Luca Fancellu Cc: Xen-devel , Stefano Stabellini References: <20230203190908.211541-1-burzalodowa@gmail.com> <20230203190908.211541-2-burzalodowa@gmail.com> <63d81215-fd4a-e2f2-e145-3ee115b7df14@xen.org> <43562da4-53a1-df7a-dcf3-2af62a95f42d@xen.org> <30f5c980-0d90-a293-0542-1c967dbae41b@gmail.com> <7255affa-a0f5-4388-2889-cb523a0246b0@xen.org> <916d173e-16c2-8cde-5815-e8c0396eda04@gmail.com> <1be4d1fc-bfa4-0cfd-b4fb-9a3ac1089c85@xen.org> From: Xenia Ragiadakou In-Reply-To: <1be4d1fc-bfa4-0cfd-b4fb-9a3ac1089c85@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/8/23 10:38, Julien Grall wrote: > > > On 07/02/2023 13:59, Xenia Ragiadakou wrote: >> Hi Julien, > > Hi Xenia, > >> >> On 2/7/23 15:01, Julien Grall wrote: >>> Hi, >>> >>> On 07/02/2023 12:46, Xenia Ragiadakou wrote: >>>> On 2/7/23 14:25, Julien Grall wrote: >>>>> >>>>> >>>>> On 07/02/2023 10:46, Xenia Ragiadakou wrote: >>>>>> >>>>>> On 2/7/23 12:39, Julien Grall wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 07/02/2023 10:23, Luca Fancellu wrote: >>>>>>>> >>>>>>>> >>>>>>>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou >>>>>>>>> wrote: >>>>>>>>> >>>>>>>> >>>>>>>> I’m not really a supporter of empty commit message, but it’s up >>>>>>>> to the maintainer :) >>>>>>> >>>>>>> +1. In this case a brief summary of the rule would be handy for >>>>>>> those that are not well-versed with MISRA. >>>>>>> >>>>>>> This can be dealt on commit if you propose a new commit message. >>>>>> >>>>>> I 'm refrained from stating the rule as is because it is strict >>>>>> and it is not applied as is. >>>>> >>>>> I am a bit confused with this statement. From misra/..., we are >>>>> supporting rule 20.7. So why aren't applying it strictly? >>>>> >>>>> And if it is not applied as-is, shouldn't we document the violation >>>>> (if any)? >>>> >>>> I applied it strictly on v2, but there was no review. >>> >>> Ah! In general it is best to ping if there are no answers. >> >> Me too I ve forgotten about it. A ticket in gitlab reminded me that it >> was pending. >> >>> >>>> Then Eclair was adjusted to have a less strict approach. Still there >>>> is a finding asking to add parentheses around dt in >>>> dt_for_each_device_node(dt, dn), i.e dn = (dt);, to which AFAIK you >>>> object. >>> >>> Are you referring to the discussion in [1]? If so, I wasn't totally >>> opposed to the suggestion so long we are consistent. >> >> I am not able to find [1]. > > https://lore.kernel.org/xen-devel/b2f2d1e7-0c18-206f-5e9d-d0115e398840@xen.org/ > > which is... > > >> I 'm referring to the discussion in >> 20221220085100.22848-6-luca.fancellu@arm.com and >> 20220728134943.1185621-1-burzalodowa@gmail.com > > ... a reply to this message. At the end of that reply, I said that I > wasn't totally against adding the parentheses but we should be > consistent in how we do it. Ok, I must have got it wrong. > >> >>> >>>> >>>>> >>>>>> >>>>>> "Add parentheses around macro parameters when the precedence and >>>>>> associativity of the performed operators can lead to unintended >>>>>> order of evaluation." >>>>>> >>>>>> Is this ok? >>>>> >>>>> I am OK with this. Is there any ID from Eclair that could be used >>>>> to track each error (and so we can confirm they have disappeared)? >>>> >>>> I am not aware of any. >>> Hmmm ok. It might be a nice feature to suggest in Eclair because >>> anyone can check whether an issue was resolved. >> >> Currently, the violations in Eclair are reported per macro call (I >> guess because it is acceptable to have parentheses around the macro >> args) so it is difficult to track all of them. >> >>> >>> Here, I don't exactly know what to check in Eclair. So I have to rely >>> on you. Anyway, nothing that can be fixed for this commit. >>> >>>> >>>> The patch can be decoupled from misra and Eclair (I mean have a >>>> generic commit title) and just mention in the commit message that it >>>> fixes some Eclair findings for MISRA C rule 20.7. >>> >>> I have a slight preference for a more generic title. But the current >>> one also work for me. >> >> It can be changed into "xen/device_tree: add parentheses around macro >> parameters" >> >>> >>> I will commit later on. >> >> Do you want me to send a v4? > > No need. It is now merged with the following commit message: > >     xen/device_tree: add parentheses around macro parameters > >     Add parentheses around macro parameters when the precedence and >     associativity of the performed operators can lead to unintended > order of evaluation. > >     This is fixing some ECLAIR finding for Misra Rule 20.7. > >     Link: > https://lore.kernel.org/xen-devel/20230203190908.211541-2-burzalodowa@gmail.com/ >     Signed-off-by: Xenia Ragiadakou >     Reviewed-by: Luca Fancellu >     [jgrall: Reworded the commit message] >     Acked-by: Julien Grall Thanks a lot. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Feb 08 10:38:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 10:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491665.760863 (Exim 4.92) (envelope-from ) id 1pPhpk-0001M0-CL; Wed, 08 Feb 2023 10:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491665.760863; Wed, 08 Feb 2023 10:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPhpk-0001Lt-9D; Wed, 08 Feb 2023 10:37:48 +0000 Received: by outflank-mailman (input) for mailman id 491665; Wed, 08 Feb 2023 10:37:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPhpj-0001Lj-6R; Wed, 08 Feb 2023 10:37:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPhpj-0006zH-1h; Wed, 08 Feb 2023 10:37:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPhpi-00081N-Ob; Wed, 08 Feb 2023 10:37:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPhpi-0001Lc-OA; Wed, 08 Feb 2023 10:37:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Co/NpZPXP968P+4yMR1jx4HflnFbhDZvrZ4L+yG0h8I=; b=scauqUKjofT6JZVgr1Rl2bUB+l 8fUGtx/fsw9hAp0ZJJznCwvE99g6Ou0bLNZsN9rfkRLuHIsA3P7Pw06x2pkla7juuMx9PPGlJd8Vb AffwGbuRQmID/MvtjkC9EetXulHxlUmZ3252zPf6SCsPxSh3gqIE5yEPNnSgEom4SDI8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176459: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3dae50283d9819c691a97f15b133124c00d39a2f X-Osstest-Versions-That: xen=2f8851c37f88e4eb4858e16626fcb2379db71a4f From: osstest service owner Date: Wed, 08 Feb 2023 10:37:46 +0000 flight 176459 xen-4.17-testing real [real] flight 176621 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176459/ http://logs.test-lab.xenproject.org/osstest/logs/176621/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 176621-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176361 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176361 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176361 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176361 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176361 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 176361 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176361 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176361 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176361 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176361 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a version targeted for testing: xen 3dae50283d9819c691a97f15b133124c00d39a2f baseline version: xen 2f8851c37f88e4eb4858e16626fcb2379db71a4f Last test of basis 176361 2023-02-04 10:09:47 Z 4 days Testing same since 176459 2023-02-07 16:39:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Ayan Kumar Halder Daniel P. Smith Jan Beulich Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2f8851c37f..3dae50283d 3dae50283d9819c691a97f15b133124c00d39a2f -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 11:03:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 11:03:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491682.760911 (Exim 4.92) (envelope-from ) id 1pPiEi-0005NW-Re; Wed, 08 Feb 2023 11:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491682.760911; Wed, 08 Feb 2023 11:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPiEi-0005NP-OE; Wed, 08 Feb 2023 11:03:36 +0000 Received: by outflank-mailman (input) for mailman id 491682; Wed, 08 Feb 2023 11:03:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPiEh-0005NF-Mp; Wed, 08 Feb 2023 11:03:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPiEh-0007h3-KQ; Wed, 08 Feb 2023 11:03:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPiEh-0000At-Cy; Wed, 08 Feb 2023 11:03:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPiEh-0004G7-CU; Wed, 08 Feb 2023 11:03:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=f4Pe32jIni3eKVJ2iAZ3Acfxcbo2tmuo53F67CAmGsM=; b=ESJH4NTpQ2uqopYlGatP8RkTRN +Y3RI3yf1wScUhCEBYjKfQKZihA/xb3F/MyOGJkEeUadlOQKw1mcEOAA85T0jIeNb0zPsLiemQyDq ENryagImSqmyHCCWEbJlZzhrXr7spXBgzHEdV/Fsrvi4nsmYVlyM4AzXKCvHqg58344U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176618: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=b9adcb5ab910b61e5332728bd248906e68a45900 X-Osstest-Versions-That: xen=c0e202194bfcb413d7cf662b333550ed444c469b From: osstest service owner Date: Wed, 08 Feb 2023 11:03:35 +0000 flight 176618 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176618/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen b9adcb5ab910b61e5332728bd248906e68a45900 baseline version: xen c0e202194bfcb413d7cf662b333550ed444c469b Last test of basis 176455 2023-02-07 15:02:14 Z 0 days Testing same since 176618 2023-02-08 09:01:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anthony PERARD Julien Grall Oleksii Kurochko Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c0e202194b..b9adcb5ab9 b9adcb5ab910b61e5332728bd248906e68a45900 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Feb 08 11:57:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 11:57:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491700.760950 (Exim 4.92) (envelope-from ) id 1pPj4P-0003K7-6b; Wed, 08 Feb 2023 11:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491700.760950; Wed, 08 Feb 2023 11:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj4P-0003K0-3o; Wed, 08 Feb 2023 11:57:01 +0000 Received: by outflank-mailman (input) for mailman id 491700; Wed, 08 Feb 2023 11:56:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj4N-0003Jo-2h; Wed, 08 Feb 2023 11:56:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj4N-0000iQ-1D; Wed, 08 Feb 2023 11:56:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj4M-0001QE-Fe; Wed, 08 Feb 2023 11:56:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPj4M-0001zB-F6; Wed, 08 Feb 2023 11:56:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=g726fAPK2Qq3C/TjQL2K/jPMldEWIVQ++njzKPZLggA=; b=yR8jS9aGAZdpFZR+E4yvisA4aa D3tjIRAQ9RW0bgUe65pliNcm8zu51o2W2VZCtoeasOo3ohuH+IktnQRgkfKUIXwMzjbUkcvDszshz fwzliO9HRotRZlQLvLKyTuZVciVUbLbH+lXw8ON6KdCw2U3zi+4lI+vUpr78Vp2OBmTc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 176458: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=6e081438bf8ef616d0123aab7a743476d8114ef6 X-Osstest-Versions-That: xen=65bf12135f618614bbf44626fba1c20ca8d1a127 From: osstest service owner Date: Wed, 08 Feb 2023 11:56:58 +0000 flight 176458 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176458/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 175454 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 175454 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 175454 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175454 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 175454 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 175454 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 175454 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 175454 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 175454 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 6e081438bf8ef616d0123aab7a743476d8114ef6 baseline version: xen 65bf12135f618614bbf44626fba1c20ca8d1a127 Last test of basis 175454 2022-12-22 09:46:50 Z 48 days Testing same since 176458 2023-02-07 16:39:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Ayan Kumar Halder Jan Beulich Jason Andryuk jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 65bf12135f..6e081438bf 6e081438bf8ef616d0123aab7a743476d8114ef6 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:00:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491709.760960 (Exim 4.92) (envelope-from ) id 1pPj7r-0004pT-UG; Wed, 08 Feb 2023 12:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491709.760960; Wed, 08 Feb 2023 12:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj7r-0004pM-RX; Wed, 08 Feb 2023 12:00:35 +0000 Received: by outflank-mailman (input) for mailman id 491709; Wed, 08 Feb 2023 12:00:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPj7q-0004pC-HU for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:00:34 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ffb8efd-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:00:32 +0100 (CET) Received: by mail-wr1-x434.google.com with SMTP id r2so16495775wrv.7 for ; Wed, 08 Feb 2023 04:00:32 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id k10-20020a5d6e8a000000b002bdda9856b5sm13533349wrz.50.2023.02.08.04.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 04:00:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ffb8efd-a7a8-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qQJM2z8w5SMjjjK6M6hIicfHTpkGlBAWuTOaToSD/NM=; b=UQMoe4gEBu/ZKPJwL7np79iKew9f0UlC/IkwjJRPOPCp5d+VrgqvyU8kKG7xQEkh9e rpA6kTCqYSAtFzx4zAoTzn0TbN63yyAFRg9sdyL+OzCryX0uxjMz5JZXEULr+EU86zsw nf3Mt07NHItxS1efOJRRBIPZobWHY4AWpvZsN6mVLuhg3BP7KwNvAkjuYKgXkQqEGGt2 ijq6uvT7EH3Lbo5yY7BsmeExYqLikOgBL706riujpKugVpCotT1nMY+aBpLvM43lQsFF zpOXBQaDcBTk4t3Z/bJr7OSAzHKda68Uzkn+vk9lNzc18YzSkJHGxnWkBu9KtI8uVS1x MECQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qQJM2z8w5SMjjjK6M6hIicfHTpkGlBAWuTOaToSD/NM=; b=0N77ti24TBEpApxI71sMs1bIdBcoE72NvBPwrY1Q9bKlNch94mHph42Ncil9Mglaay IsMb2Mw45lGhKZCuU2+CHL5r5aMcKa0g/ZYl6FL8rUm2RZ95dpTXcRDzHG+xoPPH2KiU qTAzumR0W1reHm5RN78/trXG1Itzgy6gvdqUp6a9ZVNQuRJhBOxuWI0xQQF74RBSWEW7 G/GptKWGOINFNOHgOCpiXY1NZf92iL8XbWg4ABx3/HMGA6DhURURtvmeEhCnBDnU2KVg VXoVF3t43VYQc9Se6hPxqUEojctUJqpPRJ5oNsyLPTHG5VXYGNRlJhNip4ClVhzttTRE Dw0A== X-Gm-Message-State: AO0yUKVAXdY07irnuBofI0sRDm7RUje538nt7YnIeEZiIrc76cPj2C4v Yls14ZNGYNnvJx/eyP9ierY= X-Google-Smtp-Source: AK7set/ZD1Dvkrs0e2MIzCeniKrb/Sv2xR9IwGMhY5BtDKN278G2Lsrf6PQLvXYCJOCYBdWdt+YRGg== X-Received: by 2002:a5d:468c:0:b0:2c3:fb4f:490f with SMTP id u12-20020a5d468c000000b002c3fb4f490fmr3037204wrq.33.1675857631531; Wed, 08 Feb 2023 04:00:31 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from From: Oleksii To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Wed, 08 Feb 2023 14:00:29 +0200 In-Reply-To: References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGVsbG8gSmFuLAoKVGhhbmtzIGZvciB0aGUgY29tbWVudHMhCgpPbiBUdWUsIDIwMjMtMDItMDcg YXQgMTY6MDcgKzAxMDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+IE9uIDA3LjAyLjIwMjMgMTU6NDYs IE9sZWtzaWkgS3Vyb2Noa28gd3JvdGU6Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi94ZW4v YXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9idWcuaAo+ID4gQEAgLTAsMCArMSwzOCBAQAo+ID4gKy8q IFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wICovCj4gPiArLyoKPiA+ICsgKiBDb3B5 cmlnaHQgKEMpIDIwMTIgUmVnZW50cyBvZiB0aGUgVW5pdmVyc2l0eSBvZiBDYWxpZm9ybmlhCj4g PiArICogQ29weXJpZ2h0IChDKSAyMDIxLTIwMjMgVmF0ZXMKPiA+ICsgKgo+ID4gKyAqLwo+ID4g KyNpZm5kZWYgX0FTTV9SSVNDVl9CVUdfSAo+ID4gKyNkZWZpbmUgX0FTTV9SSVNDVl9CVUdfSAo+ ID4gKwo+ID4gKyNpbmNsdWRlIDx4ZW4vdHlwZXMuaD4KPiA+ICsKPiA+ICsjaWZuZGVmIF9fQVNT RU1CTFlfXwo+ID4gKwo+ID4gKyNkZWZpbmUgQlVHX0ZOX1JFRyB0MAo+ID4gKwo+ID4gKyNkZWZp bmUgQlVHX0lOU1RSICJlYnJlYWsiCj4gPiArCj4gPiArI2RlZmluZSBJTlNOX0xFTkdUSF9NQVNL wqDCoMKgwqDCoMKgwqAgX1VMKDB4MykKPiA+ICsjZGVmaW5lIElOU05fTEVOR1RIXzMywqDCoMKg wqDCoMKgwqDCoMKgIF9VTCgweDMpCj4gCj4gSSBhc3N1bWUgdGhlc2UgYXJlIGRlbGliZXJhdGVs eSBvdmVyLXNpbXBsaWZpZWQgKG5vdCBhY2NvdW50aW5nIGZvcgo+IHdpZGVyIHRoYW4gMzItYml0 IGluc25zIGluIGFueSB3YXkpPwpUaGUgYmFzZSBpbnN0cnVjdGlvbiBzZXQgaGFzIGEgZml4ZWQg bGVuZ3RoIG9mIDMyLWJpdCBuYXR1cmFsbHkgYWxpZ25lZAppbnN0cnVjdGlvbnMuCgpUaGVyZSBh cmUgZXh0ZW5zaW9ucyBvZiB2YXJpYWJsZSBsZW5ndGggKCB3aGVyZSBlYWNoIGluc3RydWN0aW9u IGNhbiBiZQphbnkgbnVtYmVyIG9mIDE2LWJpdCBwYXJjZWxzIGluIGxlbmd0aCApIGJ1dCB0aGV5 IGFyZW4ndCB1c2VkIGluIFhlbgphbmQgTGludXgga2VybmVsICggd2hlcmUgdGhlc2UgZGVmaW5p dGlvbnMgd2VyZSB0YWtlbiBmcm9tICkuCgpDb21wcmVzc2VkIElTQSBpcyB1c2VkIG5vdyB3aGVy ZSB0aGUgaW5zdHJ1Y3Rpb24gbGVuZ3RoIGlzIDE2IGJpdCAgYW5kCidlYnJlYWsnIGluc3RydWN0 aW9uLCBpbiB0aGlzIGNhc2UsIGNhbiBiZSBlaXRoZXIgMTYgb3IgMzIgYml0ICgKZGVwZW5kaW5n IG9uIGlmIGNvbXByZXNzZWQgSVNBIGlzIHVzZWQgb3Igbm90ICkKPiAKPiA+ICsjZGVmaW5lIEJV R19JTlNOXzMywqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9VTCgweDAwMTAwMDczKSAvKiBlYnJl YWsgKi8KPiA+ICsjZGVmaW5lIEJVR19JTlNOXzE2wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9V TCgweDkwMDIpwqDCoMKgwqAgLyogYy5lYnJlYWsgKi8KPiA+ICsjZGVmaW5lIENPTVBSRVNTRURf SU5TTl9NQVNLwqDCoMKgIF9VTCgweGZmZmYpCj4gPiArCj4gPiArI2RlZmluZSBHRVRfSU5TTl9M RU5HVEgoaW5zbinCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgXAo+ID4gKyh7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgdW5zaWduZWQgbG9uZyBsZW47 wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBsZW4gPSAoKGluc24gJiBJTlNOX0xFTkdU SF9NQVNLKSA9PSBJTlNOX0xFTkdUSF8zMikgP8KgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgIDRV TCA6IDJVTDvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgbGVuO8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gCj4gQW55IHJlYXNv biBmb3IgdGhlIHVzZSBvZiAidW5zaWduZWQgbG9uZyIgKG5vdCAidW5zaWduZWQgaW50IikgaGVy ZT8KPiAKVGhlcmUgaXMgbm8gc3BlY2lmaWMgcmVhc29uIChhdCBsZWFzdCBJIGRvbid0IHNlZSBp dCBub3cpLiBJdCBsb29rcwpsaWtlIGl0IGNhbiBiZSB1c2VkIGhlcmUgZXZlbiBzbWFsbGVyIHR5 cGUgdGhhbiAndW5zaWduZWQgaW50JyBhcyBsZW4sCmluIGN1cnJlbnQgY2FzZSwgY2FuIGJlIGVp dGhlciA0IG9yIDIuCgo+ID4gK30pCj4gPiArCj4gPiArLyogVGhlc2UgYXJlIGRlZmluZWQgYnkg dGhlIGFyY2hpdGVjdHVyZSAqLwo+ID4gK2ludCBpc192YWxpZF9idWdhZGRyKHVpbnQzMl90IGFk ZHIpOwo+IAo+IEEgZnVuY3Rpb24gYnkgdGhpcyBuYW1lIHZlcnkgbGlrZWx5IHdhbnRzIHRvIHJl dHVybiBib29sLiBBbHNvIC0KPiB1aW50MzJfdCAobm90ICJ1bnNpZ25lZCBsb25nIikgZm9yIGFu IGFkZHJlc3M/Cj4gCkl0IHNob3VsZCBiZSB1bnNpZ25lZCBsb25nLgoKPiA+IC0tLSBhL3hlbi9h cmNoL3Jpc2N2L3NldHVwLmMKPiA+ICsrKyBiL3hlbi9hcmNoL3Jpc2N2L3NldHVwLmMKPiA+IEBA IC0xLDYgKzEsNiBAQAo+ID4gKyNpbmNsdWRlIDx4ZW4vYnVnLmg+Cj4gPiDCoCNpbmNsdWRlIDx4 ZW4vY29tcGlsZS5oPgo+ID4gwqAjaW5jbHVkZSA8eGVuL2luaXQuaD4KPiA+IC0KPiA+IMKgI2lu Y2x1ZGUgPGFzbS9jc3IuaD4KPiA+IMKgI2luY2x1ZGUgPGFzbS9lYXJseV9wcmludGsuaD4KPiA+ IMKgI2luY2x1ZGUgPGFzbS90cmFwcy5oPgo+IAo+IEkgdGhpbmsgaXQgaXMgZ29vZCBwcmFjdGlj ZSB0byBoYXZlIGEgYmxhbmsgbGluZSBiZXR3ZWVuIHhlbi8gYW5kCj4gYXNtLwo+IGluY2x1ZGVz Lgo+IApUaGFua3MuIEkgd2lsbCBicmluZyBhIGJsYW5rIGxpbmUgYmFjay4KCj4gPiAtLS0gYS94 ZW4vYXJjaC9yaXNjdi90cmFwcy5jCj4gPiArKysgYi94ZW4vYXJjaC9yaXNjdi90cmFwcy5jCj4g PiBAQCAtOCw2ICs4LDcgQEAKPiA+IMKgI2luY2x1ZGUgPGFzbS9lYXJseV9wcmludGsuaD4KPiA+ IMKgI2luY2x1ZGUgPGFzbS9wcm9jZXNzb3IuaD4KPiA+IMKgI2luY2x1ZGUgPGFzbS90cmFwcy5o Pgo+ID4gKyNpbmNsdWRlIDx4ZW4vYnVnLmg+Cj4gPiDCoCNpbmNsdWRlIDx4ZW4vZXJybm8uaD4K PiA+IMKgI2luY2x1ZGUgPHhlbi9saWIuaD4KPiAKPiBQZXJoYXBzIHdhbnRzIGFkanVzdGluZyBl YXJsaWVyIGluIHRoZSBzZXJpZXM6IFByZWZlcmFibHkgYWxsIHhlbi8KPiBhaGVhZCBvZiBhbGwg YXNtLy4KPiAKSSdsbCBmaXggaXQgaW4gdGhlIG5leHQgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggc2Vy aWVzLgoKPiA+IEBAIC05Nyw3ICs5OCwxMzYgQEAgc3RhdGljIHZvaWQgZG9fdW5leHBlY3RlZF90 cmFwKGNvbnN0IHN0cnVjdAo+ID4gY3B1X3VzZXJfcmVncyAqcmVncykKPiA+IMKgwqDCoMKgIGRp ZSgpOwo+ID4gwqB9Cj4gPiDCoAo+ID4gK3ZvaWQgc2hvd19leGVjdXRpb25fc3RhdGUoY29uc3Qg c3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MpCj4gPiArewo+ID4gK8KgwqDCoCBlYXJseV9wcmlu dGsoImltcGxlbWVudCBzaG93X2V4ZWN1dGlvbl9zdGF0ZShyZWdzKVxuIik7Cj4gPiArfQo+ID4g Kwo+ID4gK2ludCBkb19idWdfZnJhbWUoY29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Ms IHZhZGRyX3QgcGMpCj4gPiArewo+ID4gK8KgwqDCoCBzdHJ1Y3QgYnVnX2ZyYW1lICpzdGFydCwg KmVuZDsKPiA+ICvCoMKgwqAgc3RydWN0IGJ1Z19mcmFtZSAqYnVnID0gTlVMTDsKPiAKPiBjb25z dD8KcmVncyBhcmVuJ3QgY2hhbmdlZCBpbiB0aGUgZnVuY3Rpb24gc28gSSBkZWNpZGVkIHRvIHB1 dCBpdCBhcyBjb25zdC4KPiAKPiA+ICvCoMKgwqAgdW5zaWduZWQgaW50IGlkID0gMDsKPiA+ICvC oMKgwqAgY29uc3QgY2hhciAqZmlsZW5hbWUsICpwcmVkaWNhdGU7Cj4gPiArwqDCoMKgIGludCBs aW5lbm87Cj4gPiArCj4gPiArwqDCoMKgIHVuc2lnbmVkIGxvbmcgYnVnX2ZyYW1lc1tdID0gewo+ ID4gK8KgwqDCoMKgwqDCoMKgICh1bnNpZ25lZCBsb25nKSZfX3N0YXJ0X2J1Z19mcmFtZXNbMF0s Cj4gPiArwqDCoMKgwqDCoMKgwqAgKHVuc2lnbmVkIGxvbmcpJl9fc3RvcF9idWdfZnJhbWVzXzBb MF0sCj4gPiArwqDCoMKgwqDCoMKgwqAgKHVuc2lnbmVkIGxvbmcpJl9fc3RvcF9idWdfZnJhbWVz XzFbMF0sCj4gPiArwqDCoMKgwqDCoMKgwqAgKHVuc2lnbmVkIGxvbmcpJl9fc3RvcF9idWdfZnJh bWVzXzJbMF0sCj4gPiArwqDCoMKgwqDCoMKgwqAgKHVuc2lnbmVkIGxvbmcpJl9fc3RvcF9idWdf ZnJhbWVzXzNbMF0sCj4gPiArwqDCoMKgIH07Cj4gPiArCj4gPiArwqDCoMKgIGZvciAoIGlkID0g MDsgaWQgPCBCVUdGUkFNRV9OUjsgaWQrKyApCj4gPiArwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKg wqDCoCBzdGFydCA9IChzdHJ1Y3TCoCBidWdfZnJhbWUgKilidWdfZnJhbWVzW2lkXTsKPiA+ICvC oMKgwqDCoMKgwqDCoCBlbmQgPSAoc3RydWN0wqAgYnVnX2ZyYW1lICopYnVnX2ZyYW1lc1tpZCAr IDFdOwo+IAo+IE5pdDogU3RyYXkgZG91YmxlIGJsYW5rcy4gQnV0IEknZCBsaWtlIHRvIHN1Z2dl c3QgdGhhdCB5b3UgZ2V0IGF3YXkKPiB3aXRob3V0IGNhc3RzIGhlcmUgaW4gdGhlIGZpcnN0IHBs YWNlLiBTdWNoIGNhc3RzIGFyZSBhbHdheXMgYQo+IGNlcnRhaW4KPiByaXNrIGdvaW5nIGZvcndh cmQuCkRvIHlvdSBtZWFuIHRoYXQgaXQgaXMgYmV0dGVyIHRvIHJlLXdyaXRlIGJ1Z19mcmFtZVtd IHRvOgogICAgc3RydWN0IGJ1Z19mcmFuZSBidWdfZnJhbWVzW10gPSB7CiAgICAgICAgJl9fc3Rh cnRfYnVnX2ZyYW1lWzBdLAogICAgICAgIC4uLgo+IAo+ID4gK8KgwqDCoMKgwqDCoMKgIHdoaWxl ICggc3RhcnQgIT0gZW5kICkKPiA+ICvCoMKgwqDCoMKgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBpZiAoICh2YWRkcl90KWJ1Z19sb2Moc3RhcnQpID09IHBjICkKPiA+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg YnVnID0gc3RhcnQ7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZm91 bmQ7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBzdGFydCsrOwo+ID4gK8KgwqDCoMKgwqDCoMKgIH0KPiA+ICvCoMKgwqAgfQo+ ID4gKwo+ID4gKyBmb3VuZDoKPiA+ICvCoMKgwqAgaWYgKCBidWcgPT0gTlVMTCApCj4gPiArwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9FTlQ7Cj4gPiArCj4gPiArwqDCoMKgIGlmICggaWQgPT0g QlVHRlJBTUVfcnVuX2ZuICkKPiA+ICvCoMKgwqAgewo+ID4gK8KgwqDCoMKgwqDCoMKgIHZvaWQg KCpmbikoY29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKikgPSAodm9pZCAqKXJlZ3MtCj4gPiA+ QlVHX0ZOX1JFRzsKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBmbihyZWdzKTsKPiA+ICsKPiA+ ICvCoMKgwqDCoMKgwqDCoCBnb3RvIGVuZDsKPiA+ICvCoMKgwqAgfQo+ID4gKwo+ID4gK8KgwqDC oCAvKiBXQVJOLCBCVUcgb3IgQVNTRVJUOiBkZWNvZGUgdGhlIGZpbGVuYW1lIHBvaW50ZXIgYW5k IGxpbmUKPiA+IG51bWJlci4gKi8KPiA+ICvCoMKgwqAgZmlsZW5hbWUgPSBidWdfZmlsZShidWcp Owo+ID4gK8KgwqDCoCBsaW5lbm8gPSBidWdfbGluZShidWcpOwo+ID4gKwo+ID4gK8KgwqDCoCBz d2l0Y2ggKCBpZCApCj4gPiArwqDCoMKgIHsKPiA+ICvCoMKgwqAgY2FzZSBCVUdGUkFNRV93YXJu Ogo+ID4gK8KgwqDCoMKgwqDCoMKgIC8qCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAqIFRPRE86IGNo YW5nZSBlYXJseV9wcmludGsncyBmdW5jdGlvbiB0byBlYXJseV9wcmludGsKPiA+IHdpdGggZm9y bWF0Cj4gPiArwqDCoMKgwqDCoMKgwqDCoCAqwqDCoMKgwqDCoMKgIHdoZW4gcyhuKXByaW50Zigp IHdpbGwgYmUgYWRkZWQuCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAqLwo+ID4gK8KgwqDCoMKgwqDC oMKgIGVhcmx5X3ByaW50aygiWGVuIFdBUk4gYXQgIik7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZWFy bHlfcHJpbnRrKGZpbGVuYW1lKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBlYXJseV9wcmludGsoIjoi KTsKPiA+ICvCoMKgwqDCoMKgwqDCoCAvLyBlYXJseV9wcmludGtfaG51bShsaW5lbm8pOwo+IAo+ IFdoYXQncyB0aGlzPyBBdCB0aGUgdmVyeSBsZWFzdCB0aGUgY29tbWVudCBpcyBtYWxmb3JtZWQu Ckl0J3MgYW4gb2xkIGNvZGUgdGhhdCBzaG91bGQgYmUgcmVtb3ZlZC4KCj4gCj4gPiArwqDCoMKg wqDCoMKgwqAgc2hvd19leGVjdXRpb25fc3RhdGUocmVncyk7Cj4gPiArCj4gPiArwqDCoMKgwqDC oMKgwqAgZ290byBlbmQ7Cj4gPiArCj4gPiArwqDCoMKgIGNhc2UgQlVHRlJBTUVfYnVnOgo+ID4g K8KgwqDCoMKgwqDCoMKgwqAgLyoKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqAgKiBUT0RPOiBjaGFu Z2UgZWFybHlfcHJpbnRrJ3MgZnVuY3Rpb24gdG8gZWFybHlfcHJpbnRrCj4gPiB3aXRoIGZvcm1h dAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoCAqwqDCoMKgwqDCoMKgIHdoZW4gcyhuKXByaW50Zigp IHdpbGwgYmUgYWRkZWQuCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgICovCj4gPiArwqDCoMKgwqDC oMKgwqAgZWFybHlfcHJpbnRrKCJYZW4gQlVHIGF0ICIpOwo+ID4gK8KgwqDCoMKgwqDCoMKgIGVh cmx5X3ByaW50ayhmaWxlbmFtZSk7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZWFybHlfcHJpbnRrKCI6 Iik7Cj4gPiArwqDCoMKgwqDCoMKgwqAgLy8gZWFybHlfcHJpbnRrX2hudW0obGluZW5vKTsKPiA+ ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBzaG93X2V4ZWN1dGlvbl9zdGF0ZShyZWdzKTsKPiA+ICvC oMKgwqDCoMKgwqDCoCBlYXJseV9wcmludGsoImNoYW5nZSB3YWl0X2Zvcl9pbnRlcnJ1cHQgdG8g cGFuaWMoKSB3aGVuCj4gPiBjb21tb24gaXMgYXZhaWxhYmxlXG4iKTsKPiA+ICvCoMKgwqDCoMKg wqDCoCBkaWUoKTsKPiA+ICsKPiA+ICvCoMKgwqAgY2FzZSBCVUdGUkFNRV9hc3NlcnQ6Cj4gPiAr wqDCoMKgwqDCoMKgwqAgLyogQVNTRVJUOiBkZWNvZGUgdGhlIHByZWRpY2F0ZSBzdHJpbmcgcG9p bnRlci4gKi8KPiA+ICvCoMKgwqDCoMKgwqDCoCBwcmVkaWNhdGUgPSBidWdfbXNnKGJ1Zyk7Cj4g PiArCj4gPiArwqDCoMKgwqDCoMKgwqAgLyoKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICogVE9ETzog Y2hhbmdlIGVhcmx5X3ByaW50aydzIGZ1bmN0aW9uIHRvIGVhcmx5X3ByaW50awo+ID4gd2l0aCBm b3JtYXQKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICrCoMKgwqDCoMKgwqAgd2hlbiBzKG4pcHJpbnRm KCkgd2lsbCBiZSBhZGRlZC4KPiA+ICvCoMKgwqDCoMKgwqDCoMKgICovCj4gPiArwqDCoMKgwqDC oMKgwqAgZWFybHlfcHJpbnRrKCJBc3NlcnRpb24gXCciKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBl YXJseV9wcmludGsocHJlZGljYXRlKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBlYXJseV9wcmludGso IlwnIGZhaWxlZCBhdCAiKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBlYXJseV9wcmludGsoZmlsZW5h bWUpOwo+ID4gK8KgwqDCoMKgwqDCoMKgIGVhcmx5X3ByaW50aygiOiIpOwo+ID4gK8KgwqDCoMKg wqDCoMKgIC8vIGVhcmx5X3ByaW50a19obnVtKGxpbmVubyk7Cj4gPiArCj4gPiArwqDCoMKgwqDC oMKgwqAgc2hvd19leGVjdXRpb25fc3RhdGUocmVncyk7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZWFy bHlfcHJpbnRrKCJjaGFuZ2Ugd2FpdF9mb3JfaW50ZXJydXB0IHRvIHBhbmljKCkgd2hlbgo+ID4g Y29tbW9uIGlzIGF2YWlsYWJsZVxuIik7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZGllKCk7Cj4gPiAr wqDCoMKgIH0KPiA+ICsKPiA+ICvCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArCj4gPiArIGVu ZDoKPiA+ICvCoMKgwqAgcmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ID4gK2ludCBpc192YWxpZF9i dWdhZGRyKHVpbnQzMl90IGluc24pCj4gPiArewo+ID4gK8KgwqDCoCBpZiAoKGluc24gJiBJTlNO X0xFTkdUSF9NQVNLKSA9PSBJTlNOX0xFTkdUSF8zMikKPiAKPiBOaXQ6IFN0eWxlLgpUaGFua3Mu IEknbGwgZml4IGl0Lgo+IAo+ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAoaW5zbiA9PSBCVUdf SU5TTl8zMik7Cj4gPiArwqDCoMKgIGVsc2UKPiA+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gKChp bnNuICYgQ09NUFJFU1NFRF9JTlNOX01BU0spID09IEJVR19JTlNOXzE2KTsKPiA+ICt9Cj4gPiAr Cj4gPiDCoHZvaWQgZG9fdHJhcChzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqY3B1X3JlZ3MpCj4gPiDC oHsKPiA+ICvCoMKgwqAgcmVnaXN0ZXJfdCBwYyA9IGNwdV9yZWdzLT5zZXBjOwo+ID4gK8KgwqDC oCB1aW50MzJfdCBpbnN0ciA9ICoodWludDMyX3QgKilwYzsKPiAKPiBZb3Ugc3RpbGwgcmVhZCBh IDMyLWJpdCB2YWx1ZSB3aGVuIG9ubHkgMTYgYml0cyBtYXkgYmUgYWNjZXNzaWJsZS4KU2luY2Ug dGhlcmUgd2VyZSBhIGxvdCBvZiBjb21tZW50cyBvbiB0aGUgcHJldmlvdXMgdmVyc2lvbiBvZiBw YXRjaApzZXJpZXMsIHRoaXMgY29tbWVudCBzbGlwcGVkIG91dCBvZiBteSBoZWFkLgpJJ2xsIGZp eCBpbiBuZXcgdmVyc2lvbiBvZiB0aGUgcGF0Y2ggc2VyaWVzLgoKPiAKPiA+ICvCoMKgwqAgaWYg KGlzX3ZhbGlkX2J1Z2FkZHIoaW5zdHIpKSB7Cj4gPiArwqDCoMKgwqDCoMKgwqAgaWYgKCFkb19i dWdfZnJhbWUoY3B1X3JlZ3MsIGNwdV9yZWdzLT5zZXBjKSkgewo+IAo+IEknbSBwcmV0dHkgc3Vy ZSBJIGRpZCBwb2ludCBvdXQgdGhlIHN0eWxlIGlzc3VlcyBoZXJlLgo+IAo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY3B1X3JlZ3MtPnNlcGMgKz0gR0VUX0lOU05fTEVOR1RIKCoodWludDMy X3QgKilwYyk7Cj4gCj4gV2h5IHdvdWxkIHlvdSByZS1yZWFkIHRoZSBpbnNuIGhlcmUsIHdoZW4g eW91IGhhdmUgaXQgaW4gYSBsb2NhbAo+IHZhcmlhYmxlCj4gYWxyZWFkeT8KSW5hdHRlbnRpb24u IEknbGwgcmUtdXNlIGxvY2FsIHZhcmlhYmxlLgo+IAo+IEphbgoK From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:05:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491718.760971 (Exim 4.92) (envelope-from ) id 1pPjCq-0005Z7-H1; Wed, 08 Feb 2023 12:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491718.760971; Wed, 08 Feb 2023 12:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjCq-0005Z0-EF; Wed, 08 Feb 2023 12:05:44 +0000 Received: by outflank-mailman (input) for mailman id 491718; Wed, 08 Feb 2023 12:05:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjCp-0005Yt-1p for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:05:43 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20613.outbound.protection.outlook.com [2a01:111:f400:7e88::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e611272c-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:05:38 +0100 (CET) Received: from BN9P223CA0005.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::10) by DS0PR12MB8502.namprd12.prod.outlook.com (2603:10b6:8:15b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 12:05:35 +0000 Received: from BN8NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10b:cafe::dd) by BN9P223CA0005.outlook.office365.com (2603:10b6:408:10b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:05:34 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT096.mail.protection.outlook.com (10.13.177.195) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:05:34 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:05:33 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:05:33 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:05:32 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e611272c-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RovyDJI5mN7W1CJhW8UGjDhdNTpoyi7AzYWXL94q2osTfD1JnXVVJPFmUZ0G3ea3d+PmxLnVb9d4Ba65OO7fjAoq5Kh1VsSuz2bnHdKRuvCDU14FEXPfIJPGveW7D6wDOcvs22GJJQhBR+L48t04hyx78SrdbDJDVP1ef5Ncqmy0ckk+yDsynDD3/h6YoWCKy/OuF8cedaVQMdbV+HytbAPh5MIWhPKaQPf8bwQggp04kxWhvKpwbm9uHM2GtCPWPtQgqAyKNEULeboZcDi81OWMJmA4cOAfHRrML+76753NlDDE1k+sb6CFATbwJSmy0llF0v5zqBnz2f2QXZPh5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3dVG3f7t3j71oFqAAKQ6yDvr9I2Ln5TtlO/vvACjZU=; b=TxxbvsD/LqqdlxIIJMf84rx5YHl2GpwqERilFjOyg2JSk9V8GngS7MUvHCqpwaugwCffSeEthv/vThWlSxGFUlOVQrhG7PQpi1B+OetYizFxZhPMqXhtFL+2dj7w20euU9dKm4/dht0O10co//wFOZbog+ItUSp/9fwstqCgol3zOfQV7stqoaBrCaLySLZ4EVqcoASGLT80r4WIPY68sTOc6YjAIEyP1mBWIBznOHJkksP8hext+JayN0Oeh0uqJM+DdOAMU8HlYCfqg2rg4xzyPj4YAztjqniHnCG5qJA5jrYA8pR0PRqhPcRgieo+fOZre6SZtduU1Lizuv23kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3dVG3f7t3j71oFqAAKQ6yDvr9I2Ln5TtlO/vvACjZU=; b=U7ldx1QJ/qkUWNJ2K+8uMiyGyTzV2CCRG1UF1tWaagGFSqT2zuoeCOg472z2/stFigPK78DwLYs9dpwpppWYbzx0loDz4c0vfLuCSGXXWiE6NI+dzzn0pJLZJtNZMvXlwGWsSan4eCKfDfx54Qnxe8aB5ZSJujoygXStWSGKdDE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 0/9] Add support for 32 bit physical address Date: Wed, 8 Feb 2023 12:05:20 +0000 Message-ID: <20230208120529.22313-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT096:EE_|DS0PR12MB8502:EE_ X-MS-Office365-Filtering-Correlation-Id: bd7bff0f-a7bb-4c37-b1a0-08db09ccc85a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c5IBmDM45OJxXWXeS9VGe2A3gaWZyb1R1pvsYn0wALiDxDjrfVDPYAxzswJbSXrk/lB1isJGdBcMuQ8P1NLeGmxqENhPyjVLanouJhR/pwxRM/37+75JehyrU3LzC5iAHfoIqo1UsBEOnYk3HFDUia4nIIxO+ZKL2xFx+Tf9n8jyg7GzzC1zudxjQRzB5DH9nQIF6TCmzTolRUvBIbZAo5sgXl+EpzbeaQXO3NpA21yz1SC72NNOhAgvad0cceaA9KD/LlwgpOWAeRJX99sCyLN3Mvz9cv+HI4udWk5mPVm0ID1Kolrj/LN0qSNOj5iv2IXg98fbNm7pFQzO+Um9FayB0I+PC8W7Pfi1QA0CVwKSxIWwbLHvYwmiKK3uKuQFkQ3G8oRR2mIbIBkt3zahAYI2mVt3bhtHRx5GTFI7RA9dvb+jQZ249FLds17x9lbwggVyDbShb/Da87dm0LP5YjIv2awbyaQwT85yWAFNpLJiXPQhc7RQeU9sRhbyTiuvaTqnU6YwLzOrRg5PtATpVR/fdPScHb709mdrOuXSpCMzmvFaB4uAmoazwPZFtwFEEst2OUtW2B2++sYDBgiXWRXWZ5P6czU8R9NpCBGvH8M8RlOW4jBHZLdfnInjg4LkPWuwxBgk7SaMR/tXSe4x7LzPCq4Mo3G15X/RSywqdJwstyWt3k2YFar7Fi3z1nmNAP1O0Ok8GtWQiHmgPyTlXj+gPwHH4vk2pA1Gxt5QPoLT42HQSuX3Ao8e2WpZlM2OEcK1pk08pmoD0j27g+rtXhytwuojIog+Eu98RQmhPandWLNAHP+9pQW6WI1cOY/g X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(5660300002)(47076005)(36756003)(7416002)(2906002)(426003)(81166007)(83380400001)(1076003)(40480700001)(2616005)(336012)(356005)(82740400003)(8676002)(36860700001)(4326008)(70206006)(70586007)(54906003)(6916009)(316002)(8936002)(103116003)(41300700001)(6666004)(186003)(82310400005)(26005)(40460700003)(478600001)(86362001)(966005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:05:34.1953 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd7bff0f-a7bb-4c37-b1a0-08db09ccc85a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8502 Hi All, Please have a look at https://lists.xenproject.org/archives/html/xen-devel/2022-11/msg01465.html for the context. The benefits of using 32 bit physical addresses are as follows :- 1. It helps to use Xen on platforms (for eg R52) which supports 32 bit physical addresses and has no support for large physical address extension. On 32 bit MPU systems which supports flat-mapping (for eg R52), it helps to translate 32 bit VA into 32 bit PA. 2. It also helps in code optimization when the underlying platform does not use large physical address extension. The current patch serie depends on :- "[XEN v5] xen/arm: Use the correct format specifier" https://lists.xenproject.org/archives/html/xen-devel/2023-01/msg01896.html I did not send out the patch again as it has already been reviewed and acked and is waiting to be committed to staging. The following points are to be noted :- 1. Device tree always use u64 for address and size. The caller needs to translate between u64 and u32 (when 32 bit physical addressing is used). 2. Currently, we have enabled this option for Arm_32 as the MMU for Arm_64 uses 48 bit physical addressing. 3. https://lists.xenproject.org/archives/html/xen-devel/2022-12/msg00117.html has been added to this series. Changes from : v1 - 1. Reordered the patches such that the first three patches fixes issues in the existing codebase. These can be applied independent of the remaining patches in this serie, 2. Dropped translate_dt_address_size() for the address/size translation between paddr_t and u64 (as parsed from the device tree). Also, dropped the check for truncation (while converting u64 to paddr_t). Instead now we have modified device_tree_get_reg() and typecasted the return for dt_read_number(), to obtain paddr_t. Also, introduced wrappers for fdt_get_mem_rsv() and dt_device_get_address() for the same purpose. These can be found in patch 4/11 and patch 6/11. 3. Split "Other adaptations required to support 32bit paddr" into the following individual patches for each adaptation : xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_ARM_PA_32" 4. Introduced "xen/arm: p2m: Enable support for 32bit IPA". v2 - 1. Dropped patches 1/11, 2/11 and 3/11 from the v2 as it has already been committed (except 2/11 - "[XEN v5] xen/arm: Use the correct format specifier" which is waiting to be committed). 2. Introduced a new patch "xen/drivers: ns16550: Use paddr_t for io_base/io_size". Ayan Kumar Halder (9): xen/ns16550: Remove unneeded truncation check in the DT init code xen/arm: Typecast the DT values into paddr_t xen/drivers: ns16550: Use paddr_t for io_base/io_size xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 xen/arm: Introduce choice to enable 64/32 bit physical addressing xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_ARM_PA_32" xen/arm: Restrict zeroeth_table_offset for ARM_64 xen/arm: p2m: Enable support for 32bit IPA xen/arch/Kconfig | 12 +++++ xen/arch/arm/Kconfig | 31 +++++++++++++ xen/arch/arm/bootfdt.c | 38 ++++++++++++---- xen/arch/arm/domain_build.c | 12 ++--- xen/arch/arm/gic-v2.c | 10 ++--- xen/arch/arm/gic-v3-its.c | 4 +- xen/arch/arm/gic-v3.c | 10 ++--- xen/arch/arm/guest_walk.c | 2 + xen/arch/arm/include/asm/lpae.h | 4 ++ xen/arch/arm/include/asm/page-bits.h | 2 + xen/arch/arm/include/asm/setup.h | 2 +- xen/arch/arm/include/asm/types.h | 6 +++ xen/arch/arm/mm.c | 7 +-- xen/arch/arm/p2m.c | 10 +++-- xen/arch/arm/pci/pci-host-common.c | 6 +-- xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- xen/arch/arm/platforms/brcm.c | 4 +- xen/arch/arm/platforms/exynos5.c | 32 ++++++------- xen/arch/arm/platforms/sunxi.c | 2 +- xen/arch/arm/platforms/xgene-storm.c | 2 +- xen/arch/arm/setup.c | 14 +++--- xen/arch/arm/smpboot.c | 2 +- xen/common/device_tree.c | 36 ++++++++++++++- xen/drivers/char/cadence-uart.c | 4 +- xen/drivers/char/exynos4210-uart.c | 4 +- xen/drivers/char/imx-lpuart.c | 4 +- xen/drivers/char/meson-uart.c | 4 +- xen/drivers/char/mvebu-uart.c | 4 +- xen/drivers/char/ns16550.c | 31 ++++++++----- xen/drivers/char/omap-uart.c | 4 +- xen/drivers/char/pl011.c | 6 +-- xen/drivers/char/scif-uart.c | 4 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++-- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 23 +++++----- xen/include/xen/device_tree.h | 27 +++++++++-- xen/include/xen/libfdt/libfdt_xen.h | 52 ++++++++++++++++++++++ xen/include/xen/types.h | 2 + 38 files changed, 311 insertions(+), 118 deletions(-) create mode 100644 xen/include/xen/libfdt/libfdt_xen.h -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491719.760983 (Exim 4.92) (envelope-from ) id 1pPjDA-0005xa-S0; Wed, 08 Feb 2023 12:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491719.760983; Wed, 08 Feb 2023 12:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDA-0005xT-Mq; Wed, 08 Feb 2023 12:06:04 +0000 Received: by outflank-mailman (input) for mailman id 491719; Wed, 08 Feb 2023 12:06:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjD9-0005Yt-84 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:03 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20603.outbound.protection.outlook.com [2a01:111:f400:7eaa::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2f901e2-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:06:00 +0100 (CET) Received: from MW4PR03CA0238.namprd03.prod.outlook.com (2603:10b6:303:b9::33) by DM8PR12MB5448.namprd12.prod.outlook.com (2603:10b6:8:27::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 12:05:57 +0000 Received: from CO1NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::ad) by MW4PR03CA0238.outlook.office365.com (2603:10b6:303:b9::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:05:57 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT084.mail.protection.outlook.com (10.13.174.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:05:56 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:05:56 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:05:55 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:05:53 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2f901e2-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCw7PNGMOtLaHOGhrmqRQSUbkbiK94N1v0suR229ELqslmbPWlM2bwAA0+8MBDrwhitD93gZWgrFGkBOdZdHCkpfEujy0CmGgoJTsrehGIRUCrPuAUtXLXRD1Lp1Xhf+8i5djgC5U3gxRnObjaeR4Z9DrwtoMmzeYypChL6GXGJaUnUBhUsOBoT0JAiQMYIeODd3JPvO63ked2rDYrPTrtNGpJeodNyUJgwXNe5cIKp61urd445Ly/jMlJJXIkNrKHbl9tIaCDLzO5v6j86xBS5OCWDsnhvZSPNOjgL3Gy+N+i9oMfcC9iiZC80liVqIhvShoI9uV5HHIv/ZCkhmoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CAZmFKeEHcYbCwG62zO7gEcvYWFvdpCtigxTazP649I=; b=eOiZdUFJWpwGcTGYAmRKnO3lqQKxVfJ02n4e+Byl6iYzvyVLf/JedY3HA1e0WFfQHicmS4O/z6sLT29UBi+kcHKNmRoiGhs7xc44umxbM78+lqfjSXaLXolRasNE6okadiC9wYbnEt8/b+06dOjVHitZs4d0yRFBlh39VJRkaa14THrC228T4IkiJGVEs42zztjwwHt1/ya3t1jk2bVvfDoStd37EvOhEhpoJ+JdpnGNQTfdHxssID0kSvNxfn/W8bRlwMi75nsv8NTjVN5pRQ8WkP/v1p1SNTy5sYeUS00kn/ljO6g9ol9IXTsKUDtzTVNc7QCcoiq3oRGjyIi9Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CAZmFKeEHcYbCwG62zO7gEcvYWFvdpCtigxTazP649I=; b=QJFZDCfbYXDytDsTMeOWeoD+4YMy7hH2A18T/65uiKR/jG8w1oQgK2ERGPOxwcN/eePsd7SGJb7nS1y7g7hpQMO62+1wUnrjBmHbcRmrDWw8k4BckFsEO85oWU+xOHFUeKU3Kb3lmK27RZOsYpfvdwdgJuykZg6WfEoss3+ZYZ8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 1/9] xen/ns16550: Remove unneeded truncation check in the DT init code Date: Wed, 8 Feb 2023 12:05:21 +0000 Message-ID: <20230208120529.22313-2-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT084:EE_|DM8PR12MB5448:EE_ X-MS-Office365-Filtering-Correlation-Id: bae3aa70-476c-4ad6-afde-08db09ccd5e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eI9tbLPm9f+EnhW+YS1sZ+F/5hto17sTKLboransAphD69Kc6hjvwhzhoJKWseDrZgJ5bTTn/G0ubLLbWnfc/Q6C4TTTOOkTTeaejcFmgW6k4hQoVpLmwZeUiTDqLVzuImIIV1L6FI7zHyW2uLxlGCl5PamcVSXt1gE/8RrZHq0+/y7A4Mj/g9cfZaboPSCjqy6JlE420mdGfTQBjsYtUqqPDc/olTb3dGBIKyXjFmfGT27hTV8Dl4pVnK8ZHItfA6YjmD6VUiFo6ffGIiJzYlRVZK7pXeaqakxDq43x3YteZNe8Cf5eGn/Q5Qlvayk5bxIVau5oc27CwOfhYjG9bGwVU0mZpKi6uhIfaQXgO2Glqhg1RiHUblY3zN20EGN5GTW0CmYi60qj9As4XcRnKlOTpMsbzH/UZIdWzgZZQmTQVxZadK2TDjDcUMW9u5b+t+gUwq1KWbgIJmM3FCVnFeNYQBYWpaABAf4kEDH3m8mU7BJvYX03UtTPxH0yLnL1adiQJWWyxw37wnmk2sFR/uuenzQcQjtKm7MuWMEyMfQrdLHWN+QTzR2bgqjognFEd5KUrBjcAOCHhUf6xxmw+bNj/I1kgsigqosKJDxPCi3yUvPIsRlRylbzc/CK4aRln3BA9PW/8Mi4sSUPQqlugI1PxaHn3IT88WpoutSGRf4SMdkGWmU6GTKq9+2oquLqknbgFrAP13Q4JWalOuBoP5HhUB6GlnN+5+4sj4A6heY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(356005)(81166007)(40480700001)(1076003)(36756003)(86362001)(6666004)(478600001)(40460700003)(82310400005)(47076005)(36860700001)(26005)(186003)(2616005)(82740400003)(426003)(83380400001)(336012)(8936002)(41300700001)(8676002)(316002)(5660300002)(54906003)(7416002)(70206006)(70586007)(2906002)(103116003)(4326008)(6916009)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:05:56.7876 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bae3aa70-476c-4ad6-afde-08db09ccd5e2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5448 In an earlier commit (7c1de0038895), "ns16550.io_size" was u32 and "io_size" was u64. Thus, the ASSERT() was needed to check if the values are the same. However, in a later commit (c9f8e0aee507), "ns16550.io_size" was changed to u64. Thus, the ASSERT() became redundant. So, now as "io_size" and "uart->io_size" are both u64, there will be no truncation. Thus, one can remove the ASSERT() and extra assignment. Signed-off-by: Ayan Kumar Halder Reviewed-by: Jan Beulich --- Changes from : v1 - 1. Updated commit message/title. 2. Added Rb. v2 - No change. xen/drivers/char/ns16550.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 4ce74b3cd3..092f6b9c4b 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1747,7 +1747,6 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, struct ns16550 *uart; int res; u32 reg_shift, reg_width; - u64 io_size; uart = &ns16550_com[0]; @@ -1758,14 +1757,10 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, uart->parity = UART_PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &uart->io_base, &io_size); + res = dt_device_get_address(dev, 0, &uart->io_base, &uart->io_size); if ( res ) return res; - uart->io_size = io_size; - - ASSERT(uart->io_size == io_size); /* Detect truncation */ - res = dt_property_read_u32(dev, "reg-shift", ®_shift); if ( !res ) uart->reg_shift = 0; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491720.760994 (Exim 4.92) (envelope-from ) id 1pPjDD-0006Fh-9U; Wed, 08 Feb 2023 12:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491720.760994; Wed, 08 Feb 2023 12:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDD-0006Fa-6E; Wed, 08 Feb 2023 12:06:07 +0000 Received: by outflank-mailman (input) for mailman id 491720; Wed, 08 Feb 2023 12:06:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDB-0005Yt-1b for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:05 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20628.outbound.protection.outlook.com [2a01:111:f400:fe5b::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f47fd19a-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:06:02 +0100 (CET) Received: from BN8PR16CA0022.namprd16.prod.outlook.com (2603:10b6:408:4c::35) by BL3PR12MB6570.namprd12.prod.outlook.com (2603:10b6:208:38d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 12:05:59 +0000 Received: from BN8NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:408:4c:cafe::3a) by BN8PR16CA0022.outlook.office365.com (2603:10b6:408:4c::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:05:59 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT034.mail.protection.outlook.com (10.13.176.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:05:59 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:05:59 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:05:58 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:05:57 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f47fd19a-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJd1wz7dMYsgPPH1/FcBi9+9O9ULUMg0c77k+X9K9F+hfHdy1+ZhaViJyyTdfelUYhECIF+iwQKqNpk5he6+gA7qnhzE0HLFNRG9p3/7z73E5LzJLPbJJV+Ykr0bAMDxGsmImoD2FsykU6ubavO8FjvLYpBz+zSExSoaZzzXDjE1urVvdsZbpsi4FeMwqH2d+AdjkoZoWaVzj7j0S9EM7LpTAYzzLeoV4R0p2Cfn/kzhCzLF6KE1ycFGoRfTCv82SNeipR96pkCwwqbzHnrLVDrgETZIeQIp+5bhSB6fTDR/+Vl7mnCy+Htuugm7D1R/hujD51ApUEtCORHxx2YKCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9HEXd6ARAjfD8fn3nNtPFsJDRaX64he8Jp0qXxsvYyY=; b=eChyWCmIVpr+pwH3iJEVuB4TuedcENhOhCEncOQbMzV5OSqQU8AjOdD4HSP4qZ/C99Uwy/qjvfD9dQa0rDLjOZo2U77F3qi7Ltj1FIzJ2YABRlxjVurVWZm8n2bVVXf8awPcwJb2uXdb2iyRWp9AEmaiZaa9lnH13cMbcUnTeuXfQUdvA3zf4ZjBcDnB1yGWAM2Cgd/NdOqFLofFU+/N8ayvvOX58wQbA5SnNbuJfi+SNmUt4fBpqLiSJu59I92WgARIZ/6oo6A6Vzt/qvcR/uNNBS9/TWkdiI5LqOQQEb3Q85jV96W4kns/lLuwXpupi4tJz8VK/4JyvxjMT8dycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9HEXd6ARAjfD8fn3nNtPFsJDRaX64he8Jp0qXxsvYyY=; b=nFDGpSRUG2nGXfxaDZlY5R3t9bdkbWDQR4Ynxp7Qbk39RGL/gk+gwtOHDVnY5gZPLBrIUCbrg1Uh8lcmkF6uvDTLPDp2KoMusGKGXfpFuXtM4HzsJ2y8VqZwcaSHl33bASDeY1dlMC9OUeQO6ZW4+Sg9d62Sa3HCyyGKGuBOGfM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 2/9] xen/arm: Typecast the DT values into paddr_t Date: Wed, 8 Feb 2023 12:05:22 +0000 Message-ID: <20230208120529.22313-3-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT034:EE_|BL3PR12MB6570:EE_ X-MS-Office365-Filtering-Correlation-Id: f3d5b161-4b80-4449-1244-08db09ccd761 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cK1l4WaKlaywofelyy6RJ+RTF3I9JRpKsgTFq2V8usSL6xJ0+XxIurE0thc/D1Beq8MFPh60GeW89rlbozKwr5aqc994tPXG0TqOTaVP73OPMbp/j2le8hbPcBqhTdDJxV9625vUsmod4K+1g1+P1lS/0FbZxRIw/k4IvrgoMwBaahSy9sTTJmhmUm4df2SPxSEtDTs80+xe7MYZzQKOPQ9DM8s6Xq+WVDrCJd2/EQ+E3W0QWP1QNwlH+VhahcPZWkNPfB53iHPx3AVSy7hVvbta/D/AZNt+f3ETl4wUsaIuhQC9dPkPNCfVshv0/ddBbmwt00WyE9fnIXvAJWudUlscxX4ie4rU9Ozl8XkIf5D6NafbEXEahwjneGzW5xlhngaLEVVhDzmC6YBPG3JdzzAw3MzNuLhfB/ptbbrFJZwvs9EjdRzCEjbRtbag6CjhMg2hC5MgP0r27MutLaApMEkAnYiotX2T87HL2ah8lSazcJrBW1p4R1CJ61OZXKkmZmJniHyBm4suzQfkkJoIvJla8QkeQAL7hexdfuKY38ye35Ys/091wvuIKBBb0ne4EHsxpeF586VIr9+73JxzmrpdvpILaYroewpPECc1UtjAfg41bTlrUq3h2LpIGbjIcRlDYbNPZTjeRrMc5sP//asJbZ25C4a2cAgx+CUf9mGYWAVQBucANqdMGgT9SeOqnCXQmmti06mGoprMYaPAoxixSozEtde/J45Yuhp62R4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(5660300002)(47076005)(30864003)(36756003)(7416002)(2906002)(426003)(81166007)(83380400001)(1076003)(40480700001)(2616005)(336012)(356005)(82740400003)(8676002)(36860700001)(4326008)(70206006)(70586007)(54906003)(6916009)(316002)(8936002)(103116003)(41300700001)(6666004)(186003)(82310400005)(26005)(40460700003)(478600001)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:05:59.4186 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3d5b161-4b80-4449-1244-08db09ccd761 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6570 In future, we wish to support 32 bit physical address. However, the current dt and fdt functions can only read u64 values. We wish to make the DT functions read u64 as well u32 values (depending on the width of physical address). Also, we wish to detect if any truncation has occurred (ie while reading u32 physical addresses from u64 values read from DT). device_tree_get_reg() should now be able to return paddr_t. This is invoked by various callers to get DT address and size. For fdt_get_mem_rsv(), we have introduced wrapper ie fdt_get_mem_rsv_paddr() while will invoke fdt_get_mem_rsv() and translate u64 to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as it has been imported from external source. For dt_read_number(), we have also introduced a wrapper ie dt_read_paddr() to read physical addresses. We chose not to modify the original function as it been used in places where it needs to specifically u64 values from dt (For eg dt_property_read_u64()). Xen prints an error when it detects a truncation (during typecast between u64 and paddr_t). It is not possible to return an error in all scenarios. So, it is user's responsibility to check the error logs. To detect truncation, we right shift physical address by "PADDR_BITS - 1" and then if the resulting number is greater than 1, we know that truncation has occurred and an appropriate error log is printed. Signed-off-by: Ayan Kumar Halder --- Changes from v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead this approach achieves the same purpose. 2. No need to check for truncation while converting values from u64 to paddr_t. v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr 3. Logged error messages in case truncation is detected. xen/arch/arm/bootfdt.c | 38 ++++++++++++++++----- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/include/asm/setup.h | 2 +- xen/arch/arm/setup.c | 14 ++++---- xen/arch/arm/smpboot.c | 2 +- xen/include/xen/device_tree.h | 21 ++++++++++++ xen/include/xen/libfdt/libfdt_xen.h | 52 +++++++++++++++++++++++++++++ xen/include/xen/types.h | 2 ++ 8 files changed, 115 insertions(+), 18 deletions(-) create mode 100644 xen/include/xen/libfdt/libfdt_xen.h diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0085c28d74..f63da3e831 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include @@ -53,10 +53,30 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, } void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, - u32 size_cells, u64 *start, u64 *size) + u32 size_cells, paddr_t *start, paddr_t *size) { - *start = dt_next_cell(address_cells, cell); - *size = dt_next_cell(size_cells, cell); + u64 dt_start, dt_size; + + /* + * dt_next_cell will return u64 whereas paddr_t may be u64 or u32. Thus, + * there is an implicit cast from u64 to paddr_t. + */ + dt_start = dt_next_cell(address_cells, cell); + dt_size = dt_next_cell(size_cells, cell); + + if ( (dt_start >> (PADDR_SHIFT - 1)) > 1 ) + printk("Error: Physical address greater than max width supported\n"); + + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) + printk("Error: Physical size greater than max width supported\n"); + + /* + * Note: It is user's responsibility to check for the error messages. + * Xen will sliently truncate in case if the address/size is greater than + * the max supported width. + */ + *start = dt_start; + *size = dt_size; } static int __init device_tree_get_meminfo(const void *fdt, int node, @@ -326,7 +346,7 @@ static int __init process_chosen_node(const void *fdt, int node, printk("linux,initrd-start property has invalid length %d\n", len); return -EINVAL; } - start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); + start = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); prop = fdt_get_property(fdt, node, "linux,initrd-end", &len); if ( !prop ) @@ -339,7 +359,7 @@ static int __init process_chosen_node(const void *fdt, int node, printk("linux,initrd-end property has invalid length %d\n", len); return -EINVAL; } - end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); + end = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); if ( start >= end ) { @@ -594,9 +614,11 @@ static void __init early_print_info(void) for ( i = 0; i < nr_rsvd; i++ ) { paddr_t s, e; - if ( fdt_get_mem_rsv(device_tree_flattened, i, &s, &e) < 0 ) + + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &s, &e) < 0 ) continue; - /* fdt_get_mem_rsv returns length */ + + /* fdt_get_mem_rsv_paddr returns length */ e += s; printk(" RESVD[%u]: %"PRIpaddr" - %"PRIpaddr"\n", i, s, e); } diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a798e0b256..4d7e67560f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -949,7 +949,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, BUG_ON(!prop); cells = (const __be32 *)prop->value; device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_number(cells, size_cells); + psize = dt_read_paddr(cells, size_cells); if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) { printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..6105e5cae3 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -158,7 +158,7 @@ extern uint32_t hyp_traps_vector[]; void init_traps(void); void device_tree_get_reg(const __be32 **cell, u32 address_cells, - u32 size_cells, u64 *start, u64 *size); + u32 size_cells, paddr_t *start, paddr_t *size); u32 device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 1f26f67b90..5ade20e6e7 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -29,7 +29,7 @@ #include #include #include -#include +#include #include #include #include @@ -222,11 +222,11 @@ static void __init dt_unreserved_regions(paddr_t s, paddr_t e, { paddr_t r_s, r_e; - if ( fdt_get_mem_rsv(device_tree_flattened, i, &r_s, &r_e ) < 0 ) + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &r_s, &r_e ) < 0 ) /* If we can't read it, pretend it doesn't exist... */ continue; - r_e += r_s; /* fdt_get_mem_rsv returns length */ + r_e += r_s; /* fdt_get_mem_rsv_paddr returns length */ if ( s < r_e && r_s < e ) { @@ -502,13 +502,13 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, { paddr_t mod_s, mod_e; - if ( fdt_get_mem_rsv(device_tree_flattened, - i - mi->nr_mods, - &mod_s, &mod_e ) < 0 ) + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, + i - mi->nr_mods, + &mod_s, &mod_e ) < 0 ) /* If we can't read it, pretend it doesn't exist... */ continue; - /* fdt_get_mem_rsv returns length */ + /* fdt_get_mem_rsv_paddr returns length */ mod_e += mod_s; if ( s < mod_e && mod_s < e ) diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index 412ae22869..c15c177487 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -159,7 +159,7 @@ static void __init dt_smp_init_cpus(void) continue; } - addr = dt_read_number(prop, dt_n_addr_cells(cpu)); + addr = dt_read_paddr(prop, dt_n_addr_cells(cpu)); hwid = addr; if ( hwid != addr ) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index a28937d12a..b61bac2931 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -244,6 +244,27 @@ static inline u64 dt_read_number(const __be32 *cell, int size) return r; } +/* Wrapper for dt_read_number() to return paddr_t (instead of u64) */ +static inline paddr_t dt_read_paddr(const __be32 *cell, int size) +{ + u64 dt_r = 0; + paddr_t r; + + dt_r = dt_read_number(cell, size); + + if ( (dt_r >> (PADDR_SHIFT - 1)) > 1 ) + printk("Error: Physical address greater than max width supported\n"); + + /* + * Note: It is user's responsibility to check for the error messages. + * Xen will sliently truncate in case if the address/size is greater than + * the max supported width. + */ + r = dt_r; + + return r; +} + /* Helper to convert a number of cells to bytes */ static inline int dt_cells_to_size(int size) { diff --git a/xen/include/xen/libfdt/libfdt_xen.h b/xen/include/xen/libfdt/libfdt_xen.h new file mode 100644 index 0000000000..a3196dd96c --- /dev/null +++ b/xen/include/xen/libfdt/libfdt_xen.h @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * xen/include/xen/libfdt/libfdt_xen.h + * + * Wrapper functions for device tree. This helps to convert dt values + * between u64 and paddr_t. + * + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. + */ + +#ifndef LIBFDT_XEN_H +#define LIBFDT_XEN_H + +#include + +inline int fdt_get_mem_rsv_paddr(const void *fdt, int n, + paddr_t *address, + paddr_t *size) +{ + uint64_t dt_addr; + uint64_t dt_size; + int ret = 0; + + ret = fdt_get_mem_rsv(fdt, n, &dt_addr, &dt_size); + + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) + { + printk("Error: Physical address greater than max width supported\n"); + return -1; + } + + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) + { + printk("Error: Physical size greater than max width supported\n"); + return -1; + } + + *address = dt_addr; + *size = dt_size; + + return ret; +} + +#endif /* LIBFDT_XEN_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/include/xen/types.h b/xen/include/xen/types.h index 6aba80500a..b7255c7c38 100644 --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -71,4 +71,6 @@ typedef bool bool_t; #define test_and_set_bool(b) xchg(&(b), true) #define test_and_clear_bool(b) xchg(&(b), false) +#define PADDR_SHIFT PADDR_BITS + #endif /* __TYPES_H__ */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491722.761005 (Exim 4.92) (envelope-from ) id 1pPjDI-0006bu-Hy; Wed, 08 Feb 2023 12:06:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491722.761005; Wed, 08 Feb 2023 12:06:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDI-0006bl-F1; Wed, 08 Feb 2023 12:06:12 +0000 Received: by outflank-mailman (input) for mailman id 491722; Wed, 08 Feb 2023 12:06:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDH-0006aK-I6 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:11 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20618.outbound.protection.outlook.com [2a01:111:f400:fe5a::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7c66ada-a7a8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 13:06:08 +0100 (CET) Received: from BN9PR03CA0810.namprd03.prod.outlook.com (2603:10b6:408:13f::35) by BL0PR12MB4945.namprd12.prod.outlook.com (2603:10b6:208:1c4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 12:06:02 +0000 Received: from BN8NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13f:cafe::81) by BN9PR03CA0810.outlook.office365.com (2603:10b6:408:13f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT089.mail.protection.outlook.com (10.13.176.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:01 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:01 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:06:00 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:05:59 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7c66ada-a7a8-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoSiBqEi2+4Yk4MIqB0BxRKbboquC7mtftIDBFP+id3WgqxmHoSqqZyEO5sDz4ERohiJO4i2pyvIeg2VRpe8F+b2bUjmohGIYw44VCigl3WwJwy+Iytejl54EpHba2q3zQa/ISA4zu12CR7+lT2hGgyrdPDTZV/3vJrAnUBym1vqTpVQSdtFtdeR4X/6UFPZCOvJaMPU2eCnDIuGXzSGTvV1CgdC2Z3PtI5j0GRID8IcCdM3evDOiFrSUd6cyWBFIQXg+nC+ishSs4OaCJPkU3vqGN7eH+7ybLhtcMyA+SHx1Dps4TI5AFjcREPfGKjtrTUjZA3wMgV2lCuqR+phjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWDdC45h3TzmFMpzP68+i+YB/5cnNKV4V21ZBbTbtAQ=; b=QQvgoS5851Ps3UJFxrNHDbY+Y4fteovcy4xvGkgVL6de+to4wzQC6d2xzqhuBBF1cEQcx2uVAuZZegAfEZVp4x/uhV3b9VG01464mqJNwgrB8hEVU79CIk65FqX6myOigPw9W3xEpUHaN11sZcs6SjGXhnkXLhW5SRa8uluovTLaqbrgfIPYVAUJ5DKaHeaGLJUYSGFQfgt3C8Nfhs+joRJGa5RENxgtteWHoIE0MtUAsOsZhPzqEHKb7+2iJkwXP1ZfunHUmDc8zsZKK0/JnmuqMNjp6dH6No0cvnJaLlAfCPgvH0P6nmv/9GBMgTZXaWcRA/2pPpKVqZ/2nSfLHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWDdC45h3TzmFMpzP68+i+YB/5cnNKV4V21ZBbTbtAQ=; b=b99biGqvkjHe5Vlvg7uEmB2D+BHLaU0ouL8Hq6jrJ0C7muIiM0sW+VaH5qCJPz2+tBsEQDwmSNmnt1TQ4HEKoAXQwE78w9YIrdeqYapK3UXSZYWefctxKwiNkDejvv2W2oPZ0e6jADYFENRk1SN2HiDTnCkh6BJUQhyvsIpF8Hc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 3/9] xen/drivers: ns16550: Use paddr_t for io_base/io_size Date: Wed, 8 Feb 2023 12:05:23 +0000 Message-ID: <20230208120529.22313-4-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT089:EE_|BL0PR12MB4945:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e1095b2-76eb-4466-6ea2-08db09ccd8af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /79enLjL8WxVA0/UJrwt8ZvoUxa8j8rNcwzU5P4VC1Zo9ckjdjeuuc03dPPrvYe9jXzID1jFbqvvsVOwc374QY5oIEY6Ju82M+iOf+68okQMV6P/EPZLtOeCGD69Dm10+A8E+enI0WKeLBHRfLY8aS8HulEi0/3FYNpXW1h95FIErfpnG/t8/hfl8MlLFg3AYTOcEbZ2sx6nj25lE5v/5a4QQ7oOEti9X125GtwIcmIwL7rbQa/GLlOLR6qMdTjPAenRPWyUNS+3L2wRprRYZKlCFrlLlpKHBI0sUdItQHFxe5PZt5mP6KrnAZih2WlgtX9RUTIERzRrFENSlm1eEW2wcSVQPZks+DB0s1QORf2xhrEiOnVKszJ9ynJxx5YdOFelTsxhz4kp59+UkMMbCp3y9qTg83+j9XgUilyIu67yo70LeBIATpluVz5gfJ3D25qAPhqVJKIArf1bq8aXK3DHx7xmNcL1j0jggcqorD1i46gv3uHsaIZ2pHXZwuTpIGBsw0d3114xiwoIIz5IYLMcJQx6Lc2W+2z3GV5FAstx42MZ0NavkZ4gvstcq4antpo2crSoquJ6fyoMgPsAdgATaDpVw9Jk0ocKE6zpzWSmKWF+wWgr5eT5WWGBrUNWeLbdgJ3QU1x7YpRyhvPldaWL/kppjk8Wi2C118xmJzt/vqFtsn2ufuWbsdNP+tCVmJczixvRvYIrtyg83C6++nGx55FwrZmBriBVKCkulyw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199018)(40470700004)(46966006)(36840700001)(103116003)(36756003)(86362001)(356005)(2906002)(82310400005)(7416002)(41300700001)(5660300002)(8936002)(83380400001)(81166007)(82740400003)(36860700001)(478600001)(186003)(26005)(40480700001)(40460700003)(316002)(336012)(70586007)(1076003)(6666004)(8676002)(6916009)(54906003)(70206006)(426003)(4326008)(47076005)(2616005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:01.5942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1095b2-76eb-4466-6ea2-08db09ccd8af X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4945 io_base and io_size represent physical addresses. So they should use paddr_t (instead of u64). However in future, paddr_t may be defined as u32. So when typecasting values from u64 to paddr_t, one should always check for any possible truncation. If any truncation is discovered, Xen needs to raise a BUG for this (as the address is provided either by reading the PCIE registers or parsing parameters from string, so the error is unrecoverable). Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - NA v2 - 1. Extracted the patch from "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" into a separate patch of its own. xen/drivers/char/ns16550.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 092f6b9c4b..2aee5642f9 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -42,8 +42,8 @@ static struct ns16550 { int baud, clock_hz, data_bits, parity, stop_bits, fifo_size, irq; - u64 io_base; /* I/O port or memory-mapped I/O address. */ - u64 io_size; + paddr_t io_base; /* I/O port or memory-mapped I/O address. */ + paddr_t io_size; int reg_shift; /* Bits to shift register offset by */ int reg_width; /* Size of access to use, the registers * themselves are still bytes */ @@ -1166,8 +1166,9 @@ static const struct ns16550_config __initconst uart_config[] = static int __init pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) { - u64 orig_base = uart->io_base; + paddr_t orig_base = uart->io_base; unsigned int b, d, f, nextf, i; + u64 pci_uart_io_base; /* NB. Start at bus 1 to avoid AMT: a plug-in card cannot be on bus 0. */ for ( b = skip_amt ? 1 : 0; b < 0x100; b++ ) @@ -1259,8 +1260,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) else size = len & PCI_BASE_ADDRESS_MEM_MASK; - uart->io_base = ((u64)bar_64 << 32) | - (bar & PCI_BASE_ADDRESS_MEM_MASK); + pci_uart_io_base = ((u64)bar_64 << 32) | + (bar & PCI_BASE_ADDRESS_MEM_MASK); + + /* Truncation detected while converting to paddr_t */ + BUG_ON((pci_uart_io_base >> (PADDR_SHIFT - 1)) > 1); + + uart->io_base = pci_uart_io_base; } /* IO based */ else if ( !param->mmio && (bar & PCI_BASE_ADDRESS_SPACE_IO) ) @@ -1468,6 +1474,7 @@ static bool __init parse_positional(struct ns16550 *uart, char **str) int baud; const char *conf; char *name_val_pos; + u64 uart_io_base; conf = *str; name_val_pos = strchr(conf, '='); @@ -1532,7 +1539,12 @@ static bool __init parse_positional(struct ns16550 *uart, char **str) else #endif { - uart->io_base = simple_strtoull(conf, &conf, 0); + uart_io_base = simple_strtoull(conf, &conf, 0); + + /* Truncation detected while converting to paddr_t */ + BUG_ON((uart_io_base >> (PADDR_SHIFT - 1)) > 1); + + uart->io_base = uart_io_base; } } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491724.761016 (Exim 4.92) (envelope-from ) id 1pPjDK-0006tb-14; Wed, 08 Feb 2023 12:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491724.761016; Wed, 08 Feb 2023 12:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDJ-0006t0-Sk; Wed, 08 Feb 2023 12:06:13 +0000 Received: by outflank-mailman (input) for mailman id 491724; Wed, 08 Feb 2023 12:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDI-0006aK-7D for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:12 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20620.outbound.protection.outlook.com [2a01:111:f400:fe59::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f861eb80-a7a8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 13:06:09 +0100 (CET) Received: from MW4P223CA0006.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::11) by DM4PR12MB5054.namprd12.prod.outlook.com (2603:10b6:5:389::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 12:06:05 +0000 Received: from CO1NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::b1) by MW4P223CA0006.outlook.office365.com (2603:10b6:303:80::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:06:05 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT103.mail.protection.outlook.com (10.13.174.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Wed, 8 Feb 2023 12:06:04 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:03 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:06:03 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:01 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f861eb80-a7a8-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiZJa7LpqecLmIOezeCDZzej+i6EZWbKsE0YUPA3iL/dtYNBJePy9pDF1Z76JZfhF3aFYPE1dVPUZi239AdH9XvjgpfLxbEY+abUIkzLqAPASRdAWHcw9yQHPi35q4zXDvZAmOMgVrNURf890uCZc9wbNaOXSZ3CBtu+wreUj8U4KsGk/j66H/RY6rvRL1kQEqsd7sxG2ilI97HLU5mOc+a7kPDCdP8mlhDU0JbD2bSXwkO4vj/Fjv1xia8rotzIG21qPR77BTwOWPNnk5AkrroGLA6GfAR2Tgeou4vyT1aTJXOZQQQaeKMcKV8zB4pzVEEYtNyezlmhhceE8IkE1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9dBpjpHRrYQheiS0OUkDqg0rAHDdN+rFIGNjpdf/QF0=; b=MEyK+lVeqgoMbQ8dNWYD+73MfmbY2BvK/xIbSGCksHobhQDdJCg3sl2eUP5P8DlsCI03TTAKczBmiZcJoyhORKtEXatHbJi3TGpuCd4wQ+M3hgrLbNT6BiGxFgFaMJZMsjbYeEvSAOU2pyx2FdDtCBzJ+boftYapsI+eqbePVWHPMijU8QRl2/OAJZpZHzsKCCFLKSRne1RhI3XTCz6+Arl15H269X+eAUrSoDfjk2+I5n6BMMgNau9oueCdkHThgsS575d4a4C/FmFgWR1j2Cy1mGOQnlYtDXJAWOlwoI76vHQmmz6r1YORwvGFopTTZyc++qzyRQTphGDu7X3rcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dBpjpHRrYQheiS0OUkDqg0rAHDdN+rFIGNjpdf/QF0=; b=y9WZSfwb8EZqaiG18Ll8A49AUV0Ehgh+GLXOHpx8JoO/ECSF24Iur9E7zvyv3VfFJ1dK3htPsrwIMprSzqBNIm+JCqvalUFBkgNanMtMhLOhuX9/2nZ8aFiQy8FnpGzC1tqdfomx4qc0bU842ivk8129wDnRMQIrPrywlDV3FYg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t Date: Wed, 8 Feb 2023 12:05:24 +0000 Message-ID: <20230208120529.22313-5-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT103:EE_|DM4PR12MB5054:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e5b6317-4d6b-4ff8-11a8-08db09ccda88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v3ur82nZj8GjbkPI3wioY03DzfSKmdpdcIdCUxpXARofTG9Nztue5GKyKX8o5PxAlmxCEEDaUnPdoS8lBxqRdXEUirNsQX2W6hvoALS9hq8T3aLfa8exF0o6GMUSaCYiwO+VvDrDZ2pra7iV4w1NrEhkO9Mfn69R26Z6jyadPExLL9oI+Hc4rmdp5fUYHYnsnqzMsrzteCzMaNR8+BJeiXrBj9kgrMzze+Otrza8QsNbMRdzFiSSQbJ+zZK9madTAlE8uCPPCz0Oz7O4FI1tKqsw8ws3NsOgn9D64pLDodxblR3i3n7QBABA6EPUe1/lsweaoKTz7BBZPrNzvcuR49B+HirVfPAfHX9/z46GCZZpLBL+AHzlxH4tUhxYEfwbRak0Ur4PSXqW8xZvzul1Lq3f7aW3Cue50LbWEGLehqmRWCNTrz3/Omf3MPLzCIdSmCJil6djyWcCtKUq/JGYKgxNw8LEx0ZPdYxnk/Zr66yrTZdAXaYLQLvb6+GDE/0Og+IxFN0jHyPLaFyoLal28Ii6sl5YGdCChT8BOiTGFAfdeidb5Ec6XlGv/KVT78/b0OFt6mZ+oErfjn3IYWEUIo4qIzVs76kkXlaZvfVKQNUEofc/LKj3pFQTDqOvOhQvfA6VgGMk7rXCpdFcgoMrcGZfh52iqDkk5k8MYVz4Exsd5E4KeLAXrT277yU6yO21YUn/gRNkd+d3LMyfNd0zikJ+OrQd/5ES6OltYVOHDiY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(5660300002)(47076005)(30864003)(36756003)(7416002)(2906002)(426003)(81166007)(83380400001)(1076003)(40480700001)(2616005)(336012)(356005)(82740400003)(8676002)(36860700001)(4326008)(70206006)(70586007)(54906003)(6916009)(316002)(8936002)(103116003)(41300700001)(6666004)(186003)(82310400005)(26005)(40460700003)(478600001)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:04.5823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e5b6317-4d6b-4ff8-11a8-08db09ccda88 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5054 dt_device_get_address() can accept u64 only for address and size. However, the address/size denotes physical addresses. Thus, they should be represented by 'paddr_t'. Consequently, we introduce a wrapper for dt_device_get_address() ie dt_device_get_paddr() which accepts address/size as paddr_t and inturn invokes dt_device_get_address() after converting address/size to u64. The reason for introducing doing this is that in future 'paddr_t' may be defined as u32. Thus, we need an explicit wrapper to do the type conversion and return an error in case of truncation. With this, callers now invoke dt_device_get_paddr(). dt_device_get_address() is invoked by dt_device_get_paddr() only. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. New patch. v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" into this patch. 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. 3. Logged error in case of truncation. xen/arch/arm/domain_build.c | 10 +++--- xen/arch/arm/gic-v2.c | 10 +++--- xen/arch/arm/gic-v3-its.c | 4 +-- xen/arch/arm/gic-v3.c | 10 +++--- xen/arch/arm/pci/pci-host-common.c | 6 ++-- xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- xen/arch/arm/platforms/brcm.c | 4 +-- xen/arch/arm/platforms/exynos5.c | 32 +++++++++---------- xen/arch/arm/platforms/sunxi.c | 2 +- xen/arch/arm/platforms/xgene-storm.c | 2 +- xen/common/device_tree.c | 36 ++++++++++++++++++++-- xen/drivers/char/cadence-uart.c | 4 +-- xen/drivers/char/exynos4210-uart.c | 4 +-- xen/drivers/char/imx-lpuart.c | 4 +-- xen/drivers/char/meson-uart.c | 4 +-- xen/drivers/char/mvebu-uart.c | 4 +-- xen/drivers/char/ns16550.c | 2 +- xen/drivers/char/omap-uart.c | 4 +-- xen/drivers/char/pl011.c | 6 ++-- xen/drivers/char/scif-uart.c | 4 +-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 8 ++--- xen/include/xen/device_tree.h | 6 ++-- 24 files changed, 105 insertions(+), 73 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4d7e67560f..c7e88f5011 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1692,13 +1692,13 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, dt_for_each_device_node( dt_host, np ) { unsigned int naddr; - u64 addr, size; + paddr_t addr, size; naddr = dt_number_of_address(np); for ( i = 0; i < naddr; i++ ) { - res = dt_device_get_address(np, i, &addr, &size); + res = dt_device_get_paddr(np, i, &addr, &size); if ( res ) { printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", @@ -2471,7 +2471,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, unsigned int naddr; unsigned int i; int res; - u64 addr, size; + paddr_t addr, size; bool own_device = !dt_device_for_passthrough(dev); /* * We want to avoid mapping the MMIO in dom0 for the following cases: @@ -2526,7 +2526,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, /* Give permission and map MMIOs */ for ( i = 0; i < naddr; i++ ) { - res = dt_device_get_address(dev, i, &addr, &size); + res = dt_device_get_paddr(dev, i, &addr, &size); if ( res ) { printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", @@ -2957,7 +2957,7 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, if ( res ) { printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", kinfo->d->domain_id, mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); return res; diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 5d4d298b86..6476ff4230 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -993,7 +993,7 @@ static void gicv2_extension_dt_init(const struct dt_device_node *node) continue; /* Get register frame resource from DT. */ - if ( dt_device_get_address(v2m, 0, &addr, &size) ) + if ( dt_device_get_paddr(v2m, 0, &addr, &size) ) panic("GICv2: Cannot find a valid v2m frame address\n"); /* @@ -1018,19 +1018,19 @@ static void __init gicv2_dt_init(void) paddr_t vsize; const struct dt_device_node *node = gicv2_info.node; - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("GICv2: Cannot find a valid address for the distributor\n"); - res = dt_device_get_address(node, 1, &cbase, &csize); + res = dt_device_get_paddr(node, 1, &cbase, &csize); if ( res ) panic("GICv2: Cannot find a valid address for the CPU\n"); - res = dt_device_get_address(node, 2, &hbase, NULL); + res = dt_device_get_paddr(node, 2, &hbase, NULL); if ( res ) panic("GICv2: Cannot find a valid address for the hypervisor\n"); - res = dt_device_get_address(node, 3, &vbase, &vsize); + res = dt_device_get_paddr(node, 3, &vbase, &vsize); if ( res ) panic("GICv2: Cannot find a valid address for the virtual CPU\n"); diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 1ec9934191..3aa4edda10 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -1004,12 +1004,12 @@ static void gicv3_its_dt_init(const struct dt_device_node *node) */ dt_for_each_child_node(node, its) { - uint64_t addr, size; + paddr_t addr, size; if ( !dt_device_is_compatible(its, "arm,gic-v3-its") ) continue; - if ( dt_device_get_address(its, 0, &addr, &size) ) + if ( dt_device_get_paddr(its, 0, &addr, &size) ) panic("GICv3: Cannot find a valid ITS frame address\n"); add_to_host_its_list(addr, size, its); diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index bb59ea94cd..4e6c98bada 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1377,7 +1377,7 @@ static void __init gicv3_dt_init(void) int res, i; const struct dt_device_node *node = gicv3_info.node; - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("GICv3: Cannot find a valid distributor address\n"); @@ -1393,9 +1393,9 @@ static void __init gicv3_dt_init(void) for ( i = 0; i < gicv3.rdist_count; i++ ) { - uint64_t rdist_base, rdist_size; + paddr_t rdist_base, rdist_size; - res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size); + res = dt_device_get_paddr(node, 1 + i, &rdist_base, &rdist_size); if ( res ) panic("GICv3: No rdist base found for region %d\n", i); @@ -1417,10 +1417,10 @@ static void __init gicv3_dt_init(void) * For GICv3 supporting GICv2, GICC and GICV base address will be * provided. */ - res = dt_device_get_address(node, 1 + gicv3.rdist_count, + res = dt_device_get_paddr(node, 1 + gicv3.rdist_count, &cbase, &csize); if ( !res ) - dt_device_get_address(node, 1 + gicv3.rdist_count + 2, + dt_device_get_paddr(node, 1 + gicv3.rdist_count + 2, &vbase, &vsize); } diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a8ece94303..5550f9478d 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -93,7 +93,7 @@ gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops) cfg_reg_idx = 0; /* Parse our PCI ecam register address */ - err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size); + err = dt_device_get_paddr(dev, cfg_reg_idx, &addr, &size); if ( err ) goto err_exit; @@ -349,10 +349,10 @@ int __init pci_host_bridge_mappings(struct domain *d) for ( i = 0; i < dt_number_of_address(dev); i++ ) { - uint64_t addr, size; + paddr_t addr, size; int err; - err = dt_device_get_address(dev, i, &addr, &size); + err = dt_device_get_paddr(dev, i, &addr, &size); if ( err ) { printk(XENLOG_ERR diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c index 811b40b1a6..407ec07f63 100644 --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c @@ -64,7 +64,7 @@ static void __iomem *rpi4_map_watchdog(void) if ( !node ) return NULL; - ret = dt_device_get_address(node, 0, &start, &len); + ret = dt_device_get_paddr(node, 0, &start, &len); if ( ret ) { printk("Cannot read watchdog register address\n"); diff --git a/xen/arch/arm/platforms/brcm.c b/xen/arch/arm/platforms/brcm.c index d481b2c60f..4310feee73 100644 --- a/xen/arch/arm/platforms/brcm.c +++ b/xen/arch/arm/platforms/brcm.c @@ -40,7 +40,7 @@ static __init int brcm_get_dt_node(char *compat_str, u32 *reg_base) { const struct dt_device_node *node; - u64 reg_base_64; + paddr_t reg_base_64; int rc; node = dt_find_compatible_node(NULL, NULL, compat_str); @@ -50,7 +50,7 @@ static __init int brcm_get_dt_node(char *compat_str, return -ENOENT; } - rc = dt_device_get_address(node, 0, ®_base_64, NULL); + rc = dt_device_get_paddr(node, 0, ®_base_64, NULL); if ( rc ) { dprintk(XENLOG_ERR, "%s: missing \"reg\" prop\n", __func__); diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c index 6560507092..c48093cd4f 100644 --- a/xen/arch/arm/platforms/exynos5.c +++ b/xen/arch/arm/platforms/exynos5.c @@ -42,8 +42,8 @@ static int exynos5_init_time(void) void __iomem *mct; int rc; struct dt_device_node *node; - u64 mct_base_addr; - u64 size; + paddr_t mct_base_addr; + paddr_t size; node = dt_find_compatible_node(NULL, NULL, "samsung,exynos4210-mct"); if ( !node ) @@ -52,14 +52,14 @@ static int exynos5_init_time(void) return -ENXIO; } - rc = dt_device_get_address(node, 0, &mct_base_addr, &size); + rc = dt_device_get_paddr(node, 0, &mct_base_addr, &size); if ( rc ) { dprintk(XENLOG_ERR, "Error in \"samsung,exynos4210-mct\"\n"); return -ENXIO; } - dprintk(XENLOG_INFO, "mct_base_addr: %016llx size: %016llx\n", + dprintk(XENLOG_INFO, "mct_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", mct_base_addr, size); mct = ioremap_nocache(mct_base_addr, size); @@ -97,9 +97,9 @@ static int __init exynos5_smp_init(void) struct dt_device_node *node; void __iomem *sysram; char *compatible; - u64 sysram_addr; - u64 size; - u64 sysram_offset; + paddr_t sysram_addr; + paddr_t size; + paddr_t sysram_offset; int rc; node = dt_find_compatible_node(NULL, NULL, "samsung,secure-firmware"); @@ -125,13 +125,13 @@ static int __init exynos5_smp_init(void) return -ENXIO; } - rc = dt_device_get_address(node, 0, &sysram_addr, &size); + rc = dt_device_get_paddr(node, 0, &sysram_addr, &size); if ( rc ) { dprintk(XENLOG_ERR, "Error in %s\n", compatible); return -ENXIO; } - dprintk(XENLOG_INFO, "sysram_addr: %016llx size: %016llx offset: %016llx\n", + dprintk(XENLOG_INFO,"sysram_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"offset: 0x%"PRIpaddr"\n", sysram_addr, size, sysram_offset); sysram = ioremap_nocache(sysram_addr, size); @@ -189,7 +189,7 @@ static int exynos5_cpu_power_up(void __iomem *power, int cpu) return 0; } -static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) +static int exynos5_get_pmu_baseandsize(paddr_t *power_base_addr, paddr_t *size) { struct dt_device_node *node; int rc; @@ -208,14 +208,14 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) return -ENXIO; } - rc = dt_device_get_address(node, 0, power_base_addr, size); + rc = dt_device_get_paddr(node, 0, power_base_addr, size); if ( rc ) { dprintk(XENLOG_ERR, "Error in \"samsung,exynos5XXX-pmu\"\n"); return -ENXIO; } - dprintk(XENLOG_DEBUG, "power_base_addr: %016llx size: %016llx\n", + dprintk(XENLOG_DEBUG, "power_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", *power_base_addr, *size); return 0; @@ -223,8 +223,8 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) static int exynos5_cpu_up(int cpu) { - u64 power_base_addr; - u64 size; + paddr_t power_base_addr; + paddr_t size; void __iomem *power; int rc; @@ -256,8 +256,8 @@ static int exynos5_cpu_up(int cpu) static void exynos5_reset(void) { - u64 power_base_addr; - u64 size; + paddr_t power_base_addr; + paddr_t size; void __iomem *pmu; int rc; diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c index e8e4d88bef..2b2c215f20 100644 --- a/xen/arch/arm/platforms/sunxi.c +++ b/xen/arch/arm/platforms/sunxi.c @@ -50,7 +50,7 @@ static void __iomem *sunxi_map_watchdog(bool *new_wdt) return NULL; } - ret = dt_device_get_address(node, 0, &wdt_start, &wdt_len); + ret = dt_device_get_paddr(node, 0, &wdt_start, &wdt_len); if ( ret ) { dprintk(XENLOG_ERR, "Cannot read watchdog register address\n"); diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index befd0c3c2d..6fc2f9679e 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -50,7 +50,7 @@ static void __init xgene_check_pirq_eoi(void) if ( !node ) panic("%s: Can not find interrupt controller node\n", __func__); - res = dt_device_get_address(node, 0, &dbase, NULL); + res = dt_device_get_paddr(node, 0, &dbase, NULL); if ( res ) panic("%s: Cannot find a valid address for the distributor\n", __func__); diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 6c9712ab7b..d0f19d5cfc 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -934,8 +934,9 @@ bail: } /* dt_device_address - Translate device tree address and return it */ -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, - u64 *addr, u64 *size) +static int dt_device_get_address(const struct dt_device_node *dev, + unsigned int index, + u64 *addr, u64 *size) { const __be32 *addrp; unsigned int flags; @@ -955,6 +956,37 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, return 0; } +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, + paddr_t *addr, paddr_t *size) +{ + u64 dt_addr = 0, dt_size = 0; + int ret; + + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); + + if ( addr ) + { + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) + { + printk("Error: Physical address greater than max width supported\n"); + return -EINVAL; + } + + *addr = dt_addr; + } + + if ( size ) + { + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) + { + printk("Error: Physical size greater than max width supported\n"); + return -EINVAL; + } + *size = dt_size; + } + + return ret; +} int dt_for_each_range(const struct dt_device_node *dev, int (*cb)(const struct dt_device_node *, diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uart.c index 22905ba66c..c38d7ed143 100644 --- a/xen/drivers/char/cadence-uart.c +++ b/xen/drivers/char/cadence-uart.c @@ -158,14 +158,14 @@ static int __init cuart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct cuart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &cuart_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("cadence: Unable to retrieve the base" diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c index 43aaf02e18..2503392ccd 100644 --- a/xen/drivers/char/exynos4210-uart.c +++ b/xen/drivers/char/exynos4210-uart.c @@ -303,7 +303,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, const char *config = data; struct exynos4210_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -316,7 +316,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, uart->parity = PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("exynos4210: Unable to retrieve the base" diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c index 9c1f3b71a3..77f70c2719 100644 --- a/xen/drivers/char/imx-lpuart.c +++ b/xen/drivers/char/imx-lpuart.c @@ -204,7 +204,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, const char *config = data; struct imx_lpuart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -216,7 +216,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, uart->parity = 0; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("imx8-lpuart: Unable to retrieve the base" diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c index b1e25e0468..c627328122 100644 --- a/xen/drivers/char/meson-uart.c +++ b/xen/drivers/char/meson-uart.c @@ -209,14 +209,14 @@ static int __init meson_uart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct meson_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &meson_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("meson: Unable to retrieve the base address of the UART\n"); diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c index a00618b96f..cc55173513 100644 --- a/xen/drivers/char/mvebu-uart.c +++ b/xen/drivers/char/mvebu-uart.c @@ -231,14 +231,14 @@ static int __init mvebu_uart_init(struct dt_device_node *dev, const void *data) const char *config = data; struct mvebu3700_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &mvebu3700_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("mvebu3700: Unable to retrieve the base address of the UART\n"); diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 2aee5642f9..9a5e26a8d2 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1769,7 +1769,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, uart->parity = UART_PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &uart->io_base, &uart->io_size); + res = dt_device_get_paddr(dev, 0, &uart->io_base, &uart->io_size); if ( res ) return res; diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c index d6a5d59aa2..8e643cb039 100644 --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -324,7 +324,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, struct omap_uart *uart; u32 clkspec; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); @@ -344,7 +344,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, uart->parity = UART_PARITY_NONE; uart->stop_bits = 1; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("omap-uart: Unable to retrieve the base" diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index be67242bc0..052a651251 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -222,7 +222,7 @@ static struct uart_driver __read_mostly pl011_driver = { .vuart_info = pl011_vuart, }; -static int __init pl011_uart_init(int irq, u64 addr, u64 size, bool sbsa) +static int __init pl011_uart_init(int irq, paddr_t addr, paddr_t size, bool sbsa) { struct pl011 *uart; @@ -258,14 +258,14 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev, { const char *config = data; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) { printk("WARNING: UART configuration is not supported\n"); } - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("pl011: Unable to retrieve the base" diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c index 2fccafe340..1b28ba90e9 100644 --- a/xen/drivers/char/scif-uart.c +++ b/xen/drivers/char/scif-uart.c @@ -311,14 +311,14 @@ static int __init scif_uart_init(struct dt_device_node *dev, const char *config = data; struct scif_uart *uart; int res; - u64 addr, size; + paddr_t addr, size; if ( strcmp(config, "") ) printk("WARNING: UART configuration is not supported\n"); uart = &scif_com; - res = dt_device_get_address(dev, 0, &addr, &size); + res = dt_device_get_paddr(dev, 0, &addr, &size); if ( res ) { printk("scif-uart: Unable to retrieve the base" diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 091f09b217..611d9eeba5 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -794,7 +794,7 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu) static __init bool ipmmu_stage2_supported(void) { struct dt_device_node *np; - uint64_t addr, size; + paddr_t addr, size; void __iomem *base; uint32_t product, cut; bool stage2_supported = false; @@ -806,7 +806,7 @@ static __init bool ipmmu_stage2_supported(void) return false; } - if ( dt_device_get_address(np, 0, &addr, &size) ) + if ( dt_device_get_paddr(np, 0, &addr, &size) ) { printk(XENLOG_ERR "ipmmu: Failed to get PRR MMIO\n"); return false; @@ -884,7 +884,7 @@ static int ipmmu_probe(struct dt_device_node *node) { const struct dt_device_match *match; struct ipmmu_vmsa_device *mmu; - uint64_t addr, size; + paddr_t addr, size; uint32_t reg; int irq, ret; @@ -905,7 +905,7 @@ static int ipmmu_probe(struct dt_device_node *node) bitmap_zero(mmu->ctx, IPMMU_CTX_MAX); /* Map I/O memory and request IRQ. */ - ret = dt_device_get_address(node, 0, &addr, &size); + ret = dt_device_get_paddr(node, 0, &addr, &size); if ( ret ) { dev_err(&node->dev, "Failed to get MMIO\n"); diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index d58c5cd0bf..79d20eed20 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -2451,7 +2451,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) } /* Base address */ - ret = dt_device_get_address(dev_to_dt(pdev), 0, &ioaddr, &iosize); + ret = dt_device_get_paddr(dev_to_dt(pdev), 0, &ioaddr, &iosize); if (ret) goto out_free_smmu; diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3..79281075ba 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -73,8 +73,8 @@ /* Xen: Helpers to get device MMIO and IRQs */ struct resource { - u64 addr; - u64 size; + paddr_t addr; + paddr_t size; unsigned int type; }; @@ -101,7 +101,7 @@ static struct resource *platform_get_resource(struct platform_device *pdev, switch (type) { case IORESOURCE_MEM: - ret = dt_device_get_address(pdev, num, &res.addr, &res.size); + ret = dt_device_get_paddr(pdev, num, &res.addr, &res.size); return ((ret) ? NULL : &res); @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, ptr = ioremap_nocache(res->addr, res->size); if (!ptr) { dev_err(dev, - "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", + "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", res->addr, res->size); return ERR_PTR(-ENOMEM); } diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index b61bac2931..04aa43e0ee 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -583,7 +583,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); /** - * dt_device_get_address - Resolve an address for a device + * dt_device_get_paddr - Resolve an address for a device * @device: the device whose address is to be resolved * @index: index of the address to resolve * @addr: address filled by this function @@ -592,8 +592,8 @@ const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); * This function resolves an address, walking the tree, for a give * device-tree node. It returns 0 on success. */ -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, - u64 *addr, u64 *size); +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, + paddr_t *addr, paddr_t *size); /** * dt_number_of_irq - Get the number of IRQ for a device -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491725.761021 (Exim 4.92) (envelope-from ) id 1pPjDK-0006xt-IY; Wed, 08 Feb 2023 12:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491725.761021; Wed, 08 Feb 2023 12:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDK-0006x8-9E; Wed, 08 Feb 2023 12:06:14 +0000 Received: by outflank-mailman (input) for mailman id 491725; Wed, 08 Feb 2023 12:06:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDI-0005Yt-SG for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:12 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8f6829f-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:06:10 +0100 (CET) Received: from BN9PR03CA0230.namprd03.prod.outlook.com (2603:10b6:408:f8::25) by SJ1PR12MB6220.namprd12.prod.outlook.com (2603:10b6:a03:455::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 12:06:07 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f8:cafe::b6) by BN9PR03CA0230.outlook.office365.com (2603:10b6:408:f8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:06 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:06 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:05 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:06:05 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:04 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8f6829f-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hHOe6KSeFKyBKPf2J8i+A8CsgJiUa5OO0cDZP03Bxv4h25kbUG41qcYlRC6S75ykUtVMdtLHxwQ/dwzcu8fiTE9rbQ70tu51Tl4W1WyjoB07lM/IcMP7K5EGzwZmGASoQFfZFPjJhOBHhSNReVQf5bysnF7XoD1DzKXxdB4xLI5PkgYT/2s6wTCnMtEMBYSLVfxhBNhMF2l6NelrPza0gfRuWOvVHxDrWLMPRg48BR1oYQSWjuIY7RlB9wx8zlTI0cxHqciMqCYxRYks6xSjqpJQag+o/LY7FJnEvruxs5I9LF6S9wxvlGzX/+XSIfK5rIJHrSz3xvPRe6V/mLRlBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wNZiAudurUH10oR6SRddjZkqMj7xmnDFdnkT/K607Xk=; b=TGtJHMjIlj7IPGeypMlCLWhzYpE1G0WG1yR96zGaM/AOmjS0ujbumwsl6oaRy7WRphSkwB65WocXOm7jjxNifiaOnFZmrW8BXyCFnANHLFFBfxk8YNjgO+K3WmPT/IGthyHw3qGkQ9ifaVHq3z8h3l9NIo0k+PXhQMqQMwKs7Abi8x0WHBDSyv3cjlPiuHAjqVDxKE6gqbEHMTv2Up3AQItKC+x5AYICO1IFfq40mDLb0DahR7hB8DPHWWbtD02EXzoWdtA+ZnrotouTDPN9/FJ2q3GGEXc0t/ewrw5q0fdhsQ43ZEXM4BwQyGhSCJDhrKdAujth9P5fwm665k0egg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wNZiAudurUH10oR6SRddjZkqMj7xmnDFdnkT/K607Xk=; b=dI2JpUNyWf5zpLherLQpQXl7UM7flk+nGB3cAuswJJcGCdaRwPluoR9G2C6clArGRDGumfDR6UYljcXEXNq3aFpc0cKzkBMii7y4PoQNfd5N9mcQvsATCpEi0wK/2ZBJPdaAQl8+0WSj0icZYjyn2USYWLIKPFGBXunRiU8AlCg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 5/9] xen/arm: smmu: Use writeq_relaxed_non_atomic() for writing to SMMU_CBn_TTBR0 Date: Wed, 8 Feb 2023 12:05:25 +0000 Message-ID: <20230208120529.22313-6-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT068:EE_|SJ1PR12MB6220:EE_ X-MS-Office365-Filtering-Correlation-Id: eaf8e6d7-befb-4405-9b73-08db09ccdb67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zSfFdIJa0eWdbPTD+99ILui8bDnYvpqqY2IUK4OMN4UGkWqcyubtJomDr681hLGkOZ7ts+0rIThZU7XdRolW2m2JxELeyM2gY05HTPqj60m2AYTScUUXCgnDnSscvqMfCdGsYbZA9LBgvlm8TnIA7sKAwPlxNmlqsC49NSVIe7nq+QroTDuR9rG/strBHdET3cw0eMulzyznX0QQuwbSUzEeaIQqtq/2t9Cv2A6UdDs0pty18Ozel8Oo4KItd0aaEbulX/JoDqq5rMlQLdNyLMZ2TO0t/b5G2sVZF/KRd84+y1t8SDVbuR2WVxDvpgXYAyQXPD5SiqFIcrarFNFusCrpOpvKZTBKjNjjkRtBmc0GG2+rf5XObOyphY7bDdbXdJg2IFpvkVcjhWv2w5Chs5ICkyCVf5+RJ61g+RoU3Wn7a0HV/rPo6gZG8INd8ykphT/UHOyzE9RolrdHqHceStNiIFwgGz+hJhj2uoeiy3HUosPeGsMEHSN0Y5ti3rHtFfRZbAEfdKgU178j/8e9LwuGU+Eko2EbHy/AlflS34PEJN5kdKQfCySS7LjE0jvZexeNHNa4QpNlY+rbU4H7Epi1c7opqvrsXTZhuSu2mtvtg5F8Gk7kf8f59+KsrOdUt74f1iXzAIjgkVmItoToXMIezG4XNE8jdV4Lue2z8dtbotzPVqlJkewmkRSAWz3HeCdz/lzYSX6rAth40T6EH20mvaxov8iqT/9NIyHB5gQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199018)(36840700001)(46966006)(40470700004)(7416002)(36756003)(186003)(82740400003)(26005)(2616005)(81166007)(426003)(6666004)(47076005)(82310400005)(83380400001)(36860700001)(1076003)(336012)(70206006)(70586007)(103116003)(4326008)(6916009)(40460700003)(40480700001)(8936002)(5660300002)(41300700001)(8676002)(356005)(86362001)(54906003)(478600001)(316002)(2906002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:06.1567 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eaf8e6d7-befb-4405-9b73-08db09ccdb67 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6220 Refer ARM IHI 0062D.c ID070116 (SMMU 2.0 spec), 17-360, 17.3.9, SMMU_CBn_TTBR0 is a 64 bit register. Thus, one can use writeq_relaxed_non_atomic() to write to it instead of invoking writel_relaxed() twice for lower half and upper half of the register. This also helps us as p2maddr is 'paddr_t' (which may be u32 in future). Thus, one can assign p2maddr to a 64 bit register and do the bit manipulations on it, to generate the value for SMMU_CBn_TTBR0. Signed-off-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini --- Changes from - v1 - 1. Extracted the patch from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". Use writeq_relaxed_non_atomic() to write u64 register in a non-atomic fashion. v2 - 1. Added R-b. xen/drivers/passthrough/arm/smmu.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 79281075ba..c8ef2a925f 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -499,8 +499,7 @@ enum arm_smmu_s2cr_privcfg { #define ARM_SMMU_CB_SCTLR 0x0 #define ARM_SMMU_CB_RESUME 0x8 #define ARM_SMMU_CB_TTBCR2 0x10 -#define ARM_SMMU_CB_TTBR0_LO 0x20 -#define ARM_SMMU_CB_TTBR0_HI 0x24 +#define ARM_SMMU_CB_TTBR0 0x20 #define ARM_SMMU_CB_TTBCR 0x30 #define ARM_SMMU_CB_S1_MAIR0 0x38 #define ARM_SMMU_CB_FSR 0x58 @@ -1083,6 +1082,7 @@ static void arm_smmu_flush_pgtable(struct arm_smmu_device *smmu, void *addr, static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) { u32 reg; + u64 reg64; bool stage1; struct arm_smmu_cfg *cfg = &smmu_domain->cfg; struct arm_smmu_device *smmu = smmu_domain->smmu; @@ -1177,12 +1177,13 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain) dev_notice(smmu->dev, "d%u: p2maddr 0x%"PRIpaddr"\n", smmu_domain->cfg.domain->domain_id, p2maddr); - reg = (p2maddr & ((1ULL << 32) - 1)); - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO); - reg = (p2maddr >> 32); + reg64 = p2maddr; + if (stage1) - reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT; - writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI); + reg64 |= (((uint64_t) (ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT)) + << 32); + + writeq_relaxed_non_atomic(reg64, cb_base + ARM_SMMU_CB_TTBR0); /* * TTBCR -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491726.761038 (Exim 4.92) (envelope-from ) id 1pPjDQ-0007cK-1c; Wed, 08 Feb 2023 12:06:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491726.761038; Wed, 08 Feb 2023 12:06:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDP-0007c6-Sn; Wed, 08 Feb 2023 12:06:19 +0000 Received: by outflank-mailman (input) for mailman id 491726; Wed, 08 Feb 2023 12:06:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDO-0005Yt-E0 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:18 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20627.outbound.protection.outlook.com [2a01:111:f400:7e8d::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fccd4b8a-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:06:16 +0100 (CET) Received: from MW4P223CA0022.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::27) by MN0PR12MB6293.namprd12.prod.outlook.com (2603:10b6:208:3c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 12:06:13 +0000 Received: from CO1NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::1f) by MW4P223CA0022.outlook.office365.com (2603:10b6:303:80::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:06:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT103.mail.protection.outlook.com (10.13.174.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Wed, 8 Feb 2023 12:06:12 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:10 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:10 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:08 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fccd4b8a-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdLENqq37b9ZYS3K+BNukeD6w/d9RlR0+JxnIuDsvpZHVWYahTxZAzqgphCTZLOzdpFbXAp8ZwB2ZcROhhebuVSHu/i9Q8IwabjeEntX+DHHD+U8igBqUE8onbNuFdoP4iG7mUGEY719BflVBpg3VIMHhYoghlrjMLIPyDOYKqwwcFma7oUK1J8nhiiCxN23I0NCJZgDLSeN1vm+cZqU4/nsXlGnaw0RMN4bJT9Jwj5nzeGMBeoguWT7VsrY/hLh9J3SgAM4xgK7fX0siyIJutXVttIFtgYTIhaWcgRNAjGYshVuB2q9vj7CtJGKIGyOwBKA6/YRdjVar5MqkBvjiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SgrLGCe1IsqVgkkGPjJAA41OS8EEq9GuzCIZagEB9xo=; b=kya3y9szk6te3w8BCWZ/VLhZ2QdBvR4NlX1gQSWE9jbvh27QM3A3apwxO0gXWpxvs60fSGeB0mRP2mn3kebBtGoBH4S62GQ/q+b/tvNoM1mWNjWSCaP8H65fjn1A1QPMeEtCO0RWXPftYBY6DNveFXjKUBaBkvn0NRyxhvAnxP+y09JtlRn/kfqt/NnbN0JDLmWIUI3r32Kc6FvQiKiuq7yc2s8CxKpUfWwNsQu0P6tdWMF1T+3jBQQVnHSgozHU0LECByJP1SiTttF3zOF5uVIgEtICnv4cBNnZ/pSjNRKVlWzSWkGmyhKDZ1etcfUTpFaRRBufYJrKb3AvEMyqiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgrLGCe1IsqVgkkGPjJAA41OS8EEq9GuzCIZagEB9xo=; b=a8XaQJqbRgWKD8Ol06vHLGOtYU7D0zMphxDmtznMbRlo3jg07T2BBuoEg4Z0u2jTSc08mB6myZB6sdn9WuEzMWRgv8QfgqVwNo8ToY4fGpY2RqDkiEtX4Hl9XmIh3MSklbn+HSeY3upChd7G1ayu27Ie+9NcoM3q5UmB7fsg5VI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 7/9] xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_ARM_PA_32" Date: Wed, 8 Feb 2023 12:05:27 +0000 Message-ID: <20230208120529.22313-8-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT103:EE_|MN0PR12MB6293:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d4f4065-f167-4b38-1f25-08db09ccdf62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a3D7XVw8xXkZxZS1H1ZxfEfHJU4ZzptkepB6BD4RMIy/T+s7FSO7PWc03nIdzERBVeEq6LQ0gHLPZbR1329iX6yJG9eYkrRss+J2ZfCjtIB3cM3Qp3GxxOU+dhJnbuJ3CST/FNZRrMUSk6DoQapUxj4dNAFl6I7qpFVcJyPhzH+n9kKOxSnu7bwKg7gCJOQ4AS1ysj7a2t6tAGRQ4g1iA1h50RRzsULdLdeiin435tlP7c1nxPEUo3O6qJRH7waRRZAuB9cRhdXUzozVPAE/AF6WExUevdgjOGjqk43xT7k0Y+MAeUymdd7FJV69Xty3AJzenK8UICyKoe99X3LL9JEpWQhqlpQRimXr0Tg0GzjUfh6zrpIdrizo0d5jl4oJ5vE1Hgek1bTvKdnO+NCIw0au9dkvKV6mpdMYFt7wxcpUrZCDiRbjIiadjPSLbQG1iPavDLcQW/aEMsYcK1NFQAMPtToDCEsZbc27lh792oFU0w5eklu0u8bn7I0z7HVJVxQajN0h8OY3ye8vqzwccj1CPKWOJ+5SwZxEB0ySATf5y0hOoJszNGsVhmb3TjpYSXhgnSdUFALaVckfmAsHPqL5o7tSevHk/CvN7NxCedS4l2Eq0XVFdmdrbUukBJ/bKgjk6T6Ky1PKhG9u425N7mBacmkYP/epQMwMXgeT/yDikw0Fhfk79qwcnWm+3r0IAB3U+xLX10MWlwQMfSitIhBu/hhi/NnSZz/YjnSL0WI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199018)(40470700004)(36840700001)(46966006)(316002)(54906003)(83380400001)(36860700001)(103116003)(336012)(40480700001)(426003)(47076005)(81166007)(86362001)(356005)(82310400005)(82740400003)(26005)(1076003)(40460700003)(2616005)(36756003)(6666004)(7416002)(478600001)(186003)(5660300002)(41300700001)(2906002)(8936002)(6916009)(8676002)(70206006)(4326008)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:12.7379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4f4065-f167-4b38-1f25-08db09ccdf62 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6293 In the subsequent patch, we introduce "CONFIG_ARM_PA_32" to support 32 bit physical addresses. Thus, the code specific to "Large Physical Address Extension" (ie LPAE) should be enclosed within "ifndef CONFIG_ARM_PA_32". Refer xen/arch/arm/include/asm/short-desc.h, "short_desc_l1_supersec_t" unsigned int extbase1:4; /* Extended base address, PA[35:32] */ unsigned int extbase2:4; /* Extended base address, PA[39:36] */ Thus, extbase1 and extbase2 are not valid when 32 bit physical addresses are supported. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". v2 - 1. Reordered this patch so that it appears after CONFIG_ARM_PA_32 is introduced (in 6/9). xen/arch/arm/guest_walk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c index 43d3215304..0feb7b76ec 100644 --- a/xen/arch/arm/guest_walk.c +++ b/xen/arch/arm/guest_walk.c @@ -154,8 +154,10 @@ static bool guest_walk_sd(const struct vcpu *v, mask = (1ULL << L1DESC_SUPERSECTION_SHIFT) - 1; *ipa = gva & mask; *ipa |= (paddr_t)(pte.supersec.base) << L1DESC_SUPERSECTION_SHIFT; +#ifndef CONFIG_ARM_PA_32 *ipa |= (paddr_t)(pte.supersec.extbase1) << L1DESC_SUPERSECTION_EXT_BASE1_SHIFT; *ipa |= (paddr_t)(pte.supersec.extbase2) << L1DESC_SUPERSECTION_EXT_BASE2_SHIFT; +#endif /* CONFIG_ARM_PA_32 */ } /* Set permissions so that the caller can check the flags by herself. */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491727.761044 (Exim 4.92) (envelope-from ) id 1pPjDQ-0007gb-HL; Wed, 08 Feb 2023 12:06:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491727.761044; Wed, 08 Feb 2023 12:06:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDQ-0007ft-7v; Wed, 08 Feb 2023 12:06:20 +0000 Received: by outflank-mailman (input) for mailman id 491727; Wed, 08 Feb 2023 12:06:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDO-0006aK-Ui for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:19 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20626.outbound.protection.outlook.com [2a01:111:f400:7eab::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd543b58-a7a8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 13:06:18 +0100 (CET) Received: from MW4P223CA0022.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::27) by SN7PR12MB7155.namprd12.prod.outlook.com (2603:10b6:806:2a6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 12:06:11 +0000 Received: from CO1NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::a) by MW4P223CA0022.outlook.office365.com (2603:10b6:303:80::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:06:11 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT103.mail.protection.outlook.com (10.13.174.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Wed, 8 Feb 2023 12:06:11 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:08 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 04:06:07 -0800 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd543b58-a7a8-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=COcPuaPp9+IoaUReWusIqsRDXHkg/TjPwlLUFoxP/TEGdnyevhxkMyoXYwHPYLWHzPCcycBYote+SQf2sBGJo2RawLk9tzXGCAjSx3Ah0Lpb1qF4a11oiRmXi3rc7WvpfvLPPAs4EJf5qFydjZKrVmIai07izO8rmNE0LQw6+XNdBkZqQ3mwvsIkqnS3zbxwQ7Js9x3Yc2Tb2qqgB97TEhnmBW2XVg7Cs9G781XFCry6POXp4CUusNC9lCyitmvEySef7cmOBwRFWA8Mr/qJwWgQUdVxRGzshC3RMSSwmtty7u+yu+TPa6VsutFhc849hMkmBaDuy7QkN/cWZRveMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2VJmiFZsrpDpPGNogHFDiYO4zGiLQ4UiSa+V9iwHmw=; b=J9qW61yVr3zympsBHiPnNj9Vy57je2TxStAoV8/p1BkkSFzEtbMC8fbBZgr5a1ltW0twUgtucwVwonUdoGdqHXV0qAM1M/iPn+coiDYIvzNQCiaUwB0EaSIzDoar5XsaVSlzihbqq5uubYftXk17QO64N0BhxPq0NsWMSVhZ3+hBDS6qLdXffRWt2jgXd8tw6BEQTnuYAkXH+S5lQ0kc3V4Gm0j10234Ito2amqL+OQjytdwWAf6EVEHg2d6bZcxoJfoPN07fG0vO4QLNfCs/nwnXj3oqEGvwPGLKnm9cA1r8PMl6ItRo/YfTUDylQikkzrGCxTEE3HGitvPlCaj8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2VJmiFZsrpDpPGNogHFDiYO4zGiLQ4UiSa+V9iwHmw=; b=zUlzT1qF3JNeDtu5CSpfKvgAEaJkusMXWCwW4ga0vTKitWoW3uEeHICuRE5Vnv1veuIUbe41dzBOYSfTNLKFvPF6FXxIvuxs7SALMLg8lOuAEwtIhEBFjEngs2Y6YvdMu2RqT6CI8bn7wbrvcHNaTtlFR62vjvEcSKjPwYSskwQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 6/9] xen/arm: Introduce choice to enable 64/32 bit physical addressing Date: Wed, 8 Feb 2023 12:05:26 +0000 Message-ID: <20230208120529.22313-7-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT103:EE_|SN7PR12MB7155:EE_ X-MS-Office365-Filtering-Correlation-Id: e982044b-afe5-4289-dbf4-08db09ccdeb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +PGHHTJ4b9SFgIcUt5sKm9Vgn228H0EgmqZgQdjTZ6bTyfybN2/etL1CQVFkh0w3yvn5TDDB0M4ydK9eCsOziVR/iBE+LG0dCZhfN8PceRLMRUovr2BoHGEd9Df0J5M8hkk82md9+0+jQgVf5k3FA4gxyAJNYzub4jDgP3Ifo1UvWnC2TAjpvTBn1enFzkOwSipjfky4EooGyfVPueGQ692M+WcZVBuERYsItHn6UgqA8TW5VRUA4J+RgkB3E0v0Fx9yd3nhklarOP4fdbtt75uH1i6VvGMEOyHXtff+utepMiGr621a0HLdnCc2qkK/bbGQUf6IdEJEqEckWDttv8OYIOI7ysuV6i65h9lUdkjaxxpvbZaiGJMq9srpSCRgB3uzdzUVoavZvzHY5TbjTJ04g+kRznk1O4R6V9IUMizijNbjosdv9NunmD2g8iq7K56T5UoNQ6WAzwIBpAL10Nvml13aF0zYugs8TImz297mAAnQGKzjyxwycFXTPNF9PNRkjglQu3nnX9Is1wdrTo7EYwuEYEy8jmJDkEU+Wk9T7sGHs2KaQ9pcMb5n7D7p7YSknHOboFVW0M5OGAJEmwuvbE3VJuoex0oDA5MOLuc7jxwbSPEavs6v8ixgrz3aA5dunImiYHcaUXM2G20Q/e8Y3jqgreaCzdNW539+3x2BbOcKWODlkmJJum+rfuflsOPZnhWvo4nlC2asYwW6LRk+GHKMZ9BV9Z6UD3j2Lho= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(136003)(376002)(39860400002)(451199018)(36840700001)(40470700004)(46966006)(8936002)(7416002)(5660300002)(2906002)(36860700001)(336012)(426003)(47076005)(40480700001)(356005)(82740400003)(86362001)(81166007)(36756003)(54906003)(316002)(41300700001)(8676002)(70206006)(70586007)(6916009)(186003)(26005)(2616005)(1076003)(103116003)(478600001)(6666004)(40460700003)(4326008)(82310400005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:11.6130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e982044b-afe5-4289-dbf4-08db09ccdeb8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7155 Some Arm based hardware platforms which does not support LPAE (eg Cortex-R52), uses 32 bit physical addresses. Also, users may choose to use 32 bits to represent physical addresses for optimization. To support the above use cases, we have introduced arch independent configs to choose if the physical address can be represented using 32 bits (PHYS_ADDR_32) or 64 bits (PHYS_ADDR_64). For now only ARM_32 provides support to enable 32 bit physical addressing. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 only whereas ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. (Jan,Julien please let me know if I understood your suggestion about Kconfig correctly). xen/arch/Kconfig | 12 +++++++++++ xen/arch/arm/Kconfig | 31 ++++++++++++++++++++++++++++ xen/arch/arm/include/asm/page-bits.h | 2 ++ xen/arch/arm/include/asm/types.h | 6 ++++++ 4 files changed, 51 insertions(+) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index 7028f7b74f..1eff312b51 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -1,6 +1,18 @@ config 64BIT bool +config PHYS_ADDR_32 + bool + help + Select this option if the physical addresses can be represented by + 32 bits. + +config PHYS_ADDR_64 + bool + help + Select this option if the physical addresses can be represented + 64 bits. + config NR_CPUS int "Maximum number of CPUs" range 1 4095 diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..0955891e86 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -18,6 +18,37 @@ config ARM select HAS_PDX select HAS_PMAP select IOMMU_FORCE_PT_SHARE + choice + bool "Representative width for any physical address (default 64bit)" + optional + ---help--- + You may want to specify the width to represent the physical + address space. + By default, the physical addresses are represented using + 64 bits. + + However in certain platforms, the physical addresses may be + represented using 32 bits. + Also, the user may decide that the physical addresses can be + represented using 32 bits for a given SoC. In those cases, + user may want to enable 32 bit physical address for + optimization. + For now, we have enabled this choice for ARM_32 only. + + config ARM_PA_64 + select PHYS_ADDR_64 + bool "Select 64 bits to represent physical address" + ---help--- + Use 64 bits to represent physical address. + + config ARM_PA_32 + select PHYS_ADDR_32 + depends on ARM_32 + bool "Select 32 bits to represent physical address" + ---help--- + Use 32 bits to represent physical address. + + endchoice config ARCH_DEFCONFIG string diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h index 5d6477e599..8f4dcebcfd 100644 --- a/xen/arch/arm/include/asm/page-bits.h +++ b/xen/arch/arm/include/asm/page-bits.h @@ -5,6 +5,8 @@ #ifdef CONFIG_ARM_64 #define PADDR_BITS 48 +#elif CONFIG_ARM_PA_32 +#define PADDR_BITS 32 #else #define PADDR_BITS 40 #endif diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h index e218ed77bd..26144bc87e 100644 --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -34,9 +34,15 @@ typedef signed long long s64; typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 +#if defined(CONFIG_ARM_PA_32) +typedef unsigned long paddr_t; +#define INVALID_PADDR (~0UL) +#define PRIpaddr "08lx" +#else typedef u64 paddr_t; #define INVALID_PADDR (~0ULL) #define PRIpaddr "016llx" +#endif typedef u32 register_t; #define PRIregister "08x" #elif defined (CONFIG_ARM_64) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491728.761052 (Exim 4.92) (envelope-from ) id 1pPjDR-0007v6-B5; Wed, 08 Feb 2023 12:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491728.761052; Wed, 08 Feb 2023 12:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDR-0007u2-2c; Wed, 08 Feb 2023 12:06:21 +0000 Received: by outflank-mailman (input) for mailman id 491728; Wed, 08 Feb 2023 12:06:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDP-0005Yt-Dw for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:19 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20618.outbound.protection.outlook.com [2a01:111:f400:7e89::618]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdd108c8-a7a8-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 13:06:17 +0100 (CET) Received: from MW4P223CA0026.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::31) by DS7PR12MB6336.namprd12.prod.outlook.com (2603:10b6:8:93::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Wed, 8 Feb 2023 12:06:14 +0000 Received: from CO1NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::b9) by MW4P223CA0026.outlook.office365.com (2603:10b6:303:80::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Wed, 8 Feb 2023 12:06:14 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT103.mail.protection.outlook.com (10.13.174.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Wed, 8 Feb 2023 12:06:13 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:12 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:12 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:10 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdd108c8-a7a8-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcoBNrkCfME6utYB3/h5MFkU5pCEihv5tvxvsDn4P8z/EHI0SdPKHa+kUCFOXAw9I7Mm/HgPdysWRJNBYJwfO3qZMfkQ1HMjd/22vPD+kqOBYShXYhVHIaNqxAsreyWXpXX8ugSMDi8nc3/v+2qWY1W70XEN52P7mRNTkiHKDBHKyvDjASCYqmzhfaAR12cQ+XZL/0D1SLf58qtgQX+z6ukGX6hKYVHQis4RbV2ToPfPNex0l3EQHE6NcxPwmp3aH4BUyvSGSuYx5uWYRQmrQyP4zqf2cjes13PeQnr2fqsgjGpqRsyv4lGdVRQbpnaLMgV5qgCmqkTHTM08D0Eanw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c7Yzg+nNX8nU4svwG9G763956tzSeXgDroKQZsR7IaM=; b=O81tc0a4pMeLGWa3YV89ZrO6Ut1aVcexYyAHZVOBLUid2dh9idKUpX/H5zJnxpLanyswSKSp/qcNHbkPQfM0yx7BQXZm5cPkWaKIkx+7Wp6QKfmOoQRZkwe/BswEhXRQ0pofkxsclBsW+hfWD0aug52zdUyGkGrKX3U9fOxXHWvOdnUHU80ZMO9ICbViRyMVtqKtPp8P0Rhut/lLAza+KKtuzDOwCuKzb7ZC9MJenqWHvYaEMy+qBfI42/O5aHpBHvGEEfwcEetGJskakokO71YQueeGu4qUWj+DieDvv1NxzV9ZJobVfGvkxYER/C6WzMFu291IugUCYP1PkMQDRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c7Yzg+nNX8nU4svwG9G763956tzSeXgDroKQZsR7IaM=; b=shkauWBL2Ey7IlA3ds08VPngv1oOP+GgtplCC6auZfftJdqvxBpMuGzpi7lqcxWVHtCODNIe+B9UYxn8J3xjauxxhyfpGHxpwTk7wMYRE6hrwDdXdPGb06u3n3doCMTwPileAAT81RuMF5jTL9kbmhnv63utWAW45oDdtSzGNl8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 8/9] xen/arm: Restrict zeroeth_table_offset for ARM_64 Date: Wed, 8 Feb 2023 12:05:28 +0000 Message-ID: <20230208120529.22313-9-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT103:EE_|DS7PR12MB6336:EE_ X-MS-Office365-Filtering-Correlation-Id: 289f0d9c-ef7e-4d17-1278-08db09cce01c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m+wsuPBT2ynBY3SpbZ7rDQe7N/lgtsWD3lZ3NFPxnMIcQrQu0SeJ9bfkXm+0Q07AHNf8ulR+zaM8qGg9hDST+D+tfHIgknLtelv2yy3Gh9pDr8VRzm1yi0Jz/MZfxBG/ZWTmdcO2E3p4PnwyVzxsSjzR1+AZg2GQO4epUPJFeZ3L0CMccU3DkiU2893PEEvJJZO7XOGajtbAYbbi01ticxmaNd1FWjJ8glMM/YSkz1g3nLbnsc5ZW1kkKigOj05VBAOWBdyLm6nFKKg16tWpDRfO1Q4hS34RAC1JIlxH+xdALdzNXp9wNK1aXsYSdSj0oag7h9qso7Whbq23VH5Ziaolsx3z1rpDBtVNdxezNWzad9kSRr/Ro1f3ZX+mPkx6ffyDzS1CLERTKEvUt+XI1gT3wYJDaAmXR23YkQMS1LxjrEO81Fs+ALduTmnRylQLm6mTzTUxx2SfRJFljr0CS+kumWLM5yDvbFR3hu2anjpJSiaU0oNFyK6HaGFaso/bradBb4E/YtB/Toq8yF8FmoMQZjrwDT7YUXuJUBzypajpJVPnA1yYNltU2/hofp8cbn3F/I+G/dBjxSDJq7JB0Sn4o457bPWAvbG51jg+fEWUBMGOFnjrcyF1GQ4cBiyFTWIpbIjqCNHVVskQpHmCPzNeOv9GhHinTOkZXT26xgCMfL9vM1VXGMRbLFvs1fa2nVDE0MlmabbSFMJV626R5b+YGsZGARxHH/QUAzggX/M= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199018)(36840700001)(40470700004)(46966006)(40460700003)(478600001)(36860700001)(8936002)(5660300002)(7416002)(82740400003)(81166007)(356005)(2906002)(40480700001)(36756003)(336012)(47076005)(426003)(2616005)(70586007)(70206006)(8676002)(4326008)(86362001)(82310400005)(316002)(54906003)(103116003)(83380400001)(26005)(6666004)(6916009)(186003)(41300700001)(1076003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:13.9409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 289f0d9c-ef7e-4d17-1278-08db09cce01c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6336 When 32 bit physical addresses are used (ie ARM_PA_32=y), "va >> ZEROETH_SHIFT" causes an overflow. Also, there is no zeroeth level page table on Arm 32-bit. Also took the opportunity to clean up dump_pt_walk(). One could use DECLARE_OFFSETS() macro instead of declaring the declaring an array of page table offsets. Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - Removed the duplicate declaration for DECLARE_OFFSETS. v2 - 1. Reworded the commit message. 2. Use CONFIG_ARM_PA_32 to restrict zeroeth_table_offset. xen/arch/arm/include/asm/lpae.h | 4 ++++ xen/arch/arm/mm.c | 7 +------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h index 3fdd5d0de2..998edeed6e 100644 --- a/xen/arch/arm/include/asm/lpae.h +++ b/xen/arch/arm/include/asm/lpae.h @@ -259,7 +259,11 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); #define first_table_offset(va) TABLE_OFFSET(first_linear_offset(va)) #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va)) #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) +#ifdef CONFIG_ARM_PA_32 +#define zeroeth_table_offset(va) 0 +#else #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) +#endif /* * Macros to define page-tables: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index b99806af99..44942c6a4f 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -221,12 +221,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr, { static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; const mfn_t root_mfn = maddr_to_mfn(ttbr); - const unsigned int offsets[4] = { - zeroeth_table_offset(addr), - first_table_offset(addr), - second_table_offset(addr), - third_table_offset(addr) - }; + DECLARE_OFFSETS(offsets, addr); lpae_t pte, *mapping; unsigned int level, root_table; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 12:06:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 12:06:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491729.761058 (Exim 4.92) (envelope-from ) id 1pPjDR-00085L-U9; Wed, 08 Feb 2023 12:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491729.761058; Wed, 08 Feb 2023 12:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDR-00083L-KZ; Wed, 08 Feb 2023 12:06:21 +0000 Received: by outflank-mailman (input) for mailman id 491729; Wed, 08 Feb 2023 12:06:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPjDP-0006aK-Un for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 12:06:20 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061d.outbound.protection.outlook.com [2a01:111:f400:7eaa::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fdc4f3d6-a7a8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 13:06:18 +0100 (CET) Received: from BN9PR03CA0469.namprd03.prod.outlook.com (2603:10b6:408:139::24) by DM6PR12MB4186.namprd12.prod.outlook.com (2603:10b6:5:21b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 12:06:15 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::96) by BN9PR03CA0469.outlook.office365.com (2603:10b6:408:139::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:15 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.17 via Frontend Transport; Wed, 8 Feb 2023 12:06:14 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:14 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 8 Feb 2023 06:06:14 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 8 Feb 2023 06:06:12 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdc4f3d6-a7a8-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eGEv6hVeXIIaSDJ7ZI7lRscV9T7gAOwT3N6VlGYQr2TqzIMmPek2KTPGN7zwzVgYCqDV1QsVpyKWlqC4t37dFSt6hsLVZmFb8Id5ILTQCcy/WuTmw0YfuRq96Vti0XoMjtn4yzZVC6sKKiG2VO7uyW3rZblTEbmEdsRSPcaDIRbWMuY/NGm8DcTGZn9KCJh6lEgwW3GT71hnO0FDN5ynBlVnU/NAnfcU+ivlGPRJkdYJ/+o0mKo2faOd5jd8BsPSZg7cRDxEY800AbzlYh1IUkPW8asBl3d0bUFvKjZoVztmfBYwK/C4XYF5hWqDnxnEaif4RbSi0FmQRiydJ2effg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0LXD4lI8ekDQUSE6zCy/ebroVeYXJn+F4RC8ggf+pIc=; b=Lj11pQd7lgsj9ngTwgMVlWmPia7xcbBzN6WbkQ7yDOWNCUMAu0074oasZSYhEiICH1DYfpYVdEQ6y3k8X1GE3a/I6xlCIOTNdsyj0vG2Wv6sIZv+qU1BU7mclQLJc7EUYbxisWEZks0oZbGO64JhNM9hY8kWrD6eygyO8NLSnc1yzVn6KyKvNLgryEfpp/7o6gjfJ3HpgOEkde7lj6JPd8ax329q8gEMPQJ66UwYFFMZI/8WjWviSW+HIKCu9zHpli2onD+yjVfpB9TMiFe+2JpfunbX8lZJLD0fgiX2JOmf52Piwmew2Nl0qF1jYnwg2MChognj0DcMiVBnR4cfoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0LXD4lI8ekDQUSE6zCy/ebroVeYXJn+F4RC8ggf+pIc=; b=ErQ4AwfQw4+2h9qn4hteiAL0q68cc6ah+VO5+qp7oBqWstMinN+wyDsMETqjDI+wupSXAKLwhlYVZX7ol8TMkwtO3fR7yjQDcXDp/H3dT6T5C67hSlFykbs0nmbMwxwo7+mt503HAHkUbt5yG7b4UHVVeA1zl8eSzuiZjZD2uHk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , , , , , Ayan Kumar Halder Subject: [XEN v3 9/9] xen/arm: p2m: Enable support for 32bit IPA Date: Wed, 8 Feb 2023 12:05:29 +0000 Message-ID: <20230208120529.22313-10-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230208120529.22313-1-ayan.kumar.halder@amd.com> References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT025:EE_|DM6PR12MB4186:EE_ X-MS-Office365-Filtering-Correlation-Id: cb541ae0-5344-43f2-5281-08db09cce097 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jMx+nu47epA0QL6HRtvziQrm6JLf5MYr0IGtyYhZN/lG/5bEwLBQpHQtT5sbooeEE8bGQd9m/kLfPLCY4Enjxlu+JYF9GOzeFKtwgojPADBe/FLY5FYRcs99G4RIsIfjH5eswgaUo75/VHXDpeZj1yMopYWmH0fiL+dFVo/DtoGVIuCngeFbhnmcyxxvvsQSOv95vo0WasmVSRLLl8Tcj+D6s9a+TDQKSvQVOvkd+SKB7pHH6Zb/LF+VKZZ5b1cDmfNAmgH91D4qwrCqDaxdGTtZWK9tfqvpp2ba/bVkhxrFobqrrGAM84W2BbLZyQCgkgVH2nQZlwo+oANbmUkdUj6yjwg4TPlsYkrxduLV1yd9yq90d3iRQH/6pYmsD/p45L60SNGP1QKDZp2OJt8ue2XaQd7hHZ8AtEJfYZlCg7GWr8pvjbrn8gs2jNKVcw52Lix+s07nDvIPf5UXP+UyMvb7opZ3m269mE9+IYQTowwDQ9QeCxZEQeV/PQh8KcXlsAdKDRz8/GPy53vkkde2weK0oOuKiLVNVH6lVqFdQidzkG2ObKSUZFY3doch3MKDR8zZTT5ZTt7M9NZ+xRrf853tHChbWGoch63N3y+s2+/Qy//967eIcFfFWM86HFd1jiRN1xTtKFnoNWRO7zZipbqlgwabBsOTDReMT9UVcMpjGFThjFJASgO9ovF/p6bZDN+mvW76V8EW1BfE/BIzQzQ/hNKLv4sTwaImh4YcYvM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199018)(40470700004)(36840700001)(46966006)(316002)(83380400001)(54906003)(47076005)(426003)(36756003)(82740400003)(8936002)(40480700001)(2906002)(41300700001)(36860700001)(7416002)(5660300002)(103116003)(356005)(86362001)(82310400005)(81166007)(6916009)(40460700003)(70586007)(70206006)(8676002)(4326008)(26005)(478600001)(186003)(336012)(1076003)(2616005)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 12:06:14.8736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb541ae0-5344-43f2-5281-08db09cce097 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4186 VTCR.T0SZ should be set as 0x20 to support 32bit IPA. Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, "Virtualization Translation Control Register" for the bit descriptions. Signed-off-by: Ayan Kumar Halder Acked-by: Stefano Stabellini --- Changes from - v1 - New patch. v2 - 1. Added Ack. xen/arch/arm/p2m.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d84..cfdea55e71 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; #ifdef CONFIG_ARM_32 - if ( p2m_ipa_bits < 40 ) + if ( p2m_ipa_bits < PADDR_BITS ) panic("P2M: Not able to support %u-bit IPA at the moment\n", p2m_ipa_bits); - printk("P2M: 40-bit IPA\n"); - p2m_ipa_bits = 40; + printk("P2M: %u-bit IPA\n",PADDR_BITS); + p2m_ipa_bits = PADDR_BITS; +#ifdef CONFIG_ARM_PA_32 + val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ +#else val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ +#endif val |= VTCR_SL0(0x1); /* P2M starts at first level */ #else /* CONFIG_ARM_64 */ static const struct { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 13:33:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 13:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491789.761082 (Exim 4.92) (envelope-from ) id 1pPkZg-0003os-7E; Wed, 08 Feb 2023 13:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491789.761082; Wed, 08 Feb 2023 13:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPkZg-0003ol-3g; Wed, 08 Feb 2023 13:33:24 +0000 Received: by outflank-mailman (input) for mailman id 491789; Wed, 08 Feb 2023 13:33:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPkZe-0003of-Hr for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 13:33:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7d00::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 260dfba2-a7b5-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 14:33:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8108.eurprd04.prod.outlook.com (2603:10a6:10:25e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 13:33:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 13:33:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 260dfba2-a7b5-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+G1cDwOPEVzu79Ql8tu+lYrtMH2znRDF4KJRGy7tDbJrmux2UFcWIkjc6TbOrTNOHeN/KgKT5p6iXo4fuB98UgNvaWlQiDqzK08rz7sb4KM9lekxfnIiIpERd1XAqf+/Yd/Vake6kzGOOwHwIb1yI5g1J5vhbibkuRPWPpMVu00DLMgWcIzO2loTqkisajiyAfwZMPaw5wur7GX159AkfL6/lzO5Qs++Q2c45+0C7qeDKc2ucQfbr6rxUL1IB/UVDeQXxZlx4RBXiyZn+d68c2nH0uG/lOEDVBuBf001JA86qWCk7XD/AmzOCRpIaGrc01etjg/j400KbqUKObjSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J7yzqllAbb4kLy8ohe30N8uaVTRIW2+hh/616DNZETI=; b=E6vm6b1SoJf8WI5iKcrM5ckfHBHSNQj+ZRsJOoJGssvGNsa3F9a3/D4ynTdenas4RDKhtEJF0QequYQ1vhnjkmCHy+92nT6DF2mjGUI+G8uOMjauTcCpLLTw4H0hXvu9aPvs+swpVDrqjfdLsVxmfNqc1p89HBlc6NaEpZdAuX1srfe/CdQXX01Dh35uBkNhpsYDFs9vYRwMr3Ce0aZeJSTuawZ3I9DBxhozRBE4G34QYEW/B9t/7vI4ydZRNZFpapow5Ff0DmlF2a+F3QOU7W9P9m0U/OhT88wK+72jrB/lqvMkrrV1PPckcBAh2wjK9Y96324vsJeldZhpmNuI5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J7yzqllAbb4kLy8ohe30N8uaVTRIW2+hh/616DNZETI=; b=qeM7v2rjbJg4K/mVDKTmTXfQZYjaQEV795Y6DPGm5o3/Mm662yDJiPAycUJtycQn6aZJYdSapBwd8vrg8ELOt1e7CjBUSTkqT2wvUul4bP/56jGX6+0c23T0AszyNuXvhb/y9GolnxMYWUxWRZGtCzA/LV7eS8Po72UCnOF/+Y4nflOUkyMb5yqm8zzIljdw8XLrTa1eJlIWHajUEszLnnPLnpa+ag0hD3Dm7MMADakPewJOOzD6VhjyQQjLEh7UhuEqT5WojnEVQNHale0clNEhPhrBuRCmto/B8QizYsMznxzQerzsRHY9q7mkgavIhLeuBUaLNUScKY/J5TnHSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 8 Feb 2023 14:33:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v3 2/9] xen/arm: Typecast the DT values into paddr_t Content-Language: en-US To: Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-3-ayan.kumar.halder@amd.com> From: Jan Beulich In-Reply-To: <20230208120529.22313-3-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8108:EE_ X-MS-Office365-Filtering-Correlation-Id: 91ac2c45-1073-4950-a567-08db09d90833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mf7qNS/9CfnTMS2dWEYnwNuhEWyZ/JUdveQ+MXRK/mqUWUeksG3xiOpoCQ9Tw0QlHvgow45utHYQC6Ob4QgHqHaMYnQ3mFCdBzewD7LNN+9FlwHH/Pg8kBMw1rBHiJtd9rvvNQnfDTdIw+Jt7bEcKSjg6jmOW0PhICJTz8ltnRKkK4+7bor6snhdud8S16fiiRxxAfSLMDA7j7MiaHB44m5hBR0+wFleTnX4Tsxa7P5ZHDo1u60TNO9QuhFxtVGb235XO256ujenSiF587uEhrDG6+NgT0Sd0TqjcJ8qqUbp5AjtJr7mUu5fFwH4R2rVmdGfHdo3dhOHWEcvEyx67TczKUzR0KX+6eBVonwieFolb7hTBYa42W9UWLFfiBxi/WpvV01A66hclq0AJ0WkInZ/60m5bTGUtSHKd08qGbq+6ScPFbPUL0WfkdyQm8YljX6EkrHoZG2rv5aLJ3x0BH8/8lVdrNfMaRa7HqchrDgaphMKbwJnq1F50MfZBihFQq4DZL1jmwjNGlwgejwxt+AXCHijUe2hFXSXt0hhuQLW1vOB3gW6jPnmO3+pXpJffZaY8FZEO5iWgYkgUZkpiL5AuJjvuXhlMXEgsrt4IYeTDMNT6JDODaa1dnAIrc7MTjoqtUFX89H8Hk5TSGrk8rpag3VM4aabjUDth6X68DQx4EPh3zlCAWLeNjo8b5b/fl9SNzUSCrDxfX5OzoGH2FRXfhuQKd5pNcH/6pU3sdI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(376002)(366004)(39860400002)(136003)(451199018)(7416002)(6506007)(53546011)(31696002)(8676002)(6512007)(38100700002)(316002)(186003)(86362001)(6486002)(26005)(478600001)(8936002)(41300700001)(83380400001)(5660300002)(36756003)(4326008)(2616005)(66476007)(66946007)(66556008)(6916009)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDlSMFFnb2VQOGd0VjN2Q0xITXhGUERhcnVpRjR4cnpqcUpmWE8zRjhrYjdT?= =?utf-8?B?TE81cExpQUxWWExRRkFLczJGMVlFa2VLVEZMOWppdERXK1MzQ241TTNvR2Zp?= =?utf-8?B?ZWZQaC9HVk4vQVYyckxBdGtWSll5WklnaEg1eExKbUdFR1JUOVpjK1FZNURt?= =?utf-8?B?dVIrTkRERnp2Rk9vcm1TZlJCR091ZE8rVk9QSkdlUndIeGI2TmtuRkZoRmZG?= =?utf-8?B?V0grTmlWdms4UE4reGRKcFJ6NmJWUXVOMjF0VFZHSldiYVZabitTNUwzS0x6?= =?utf-8?B?RTJjbm1vdVNMbm5RMWZNdmlFaEFkbkxHeWtHV1dEcllBOTk0QURpMVBaMDFC?= =?utf-8?B?RnREeTQ2QzJsZUNXeDI0L2dHOVhrMXRwY053N1VBaVA0cVEvdC9jQ2p5blkz?= =?utf-8?B?cFUyZWQ5YzZLb1lIOE5NNjhQSTBGOVU1bDNIY2tOZjE2VE5DODJtcVN4dnZE?= =?utf-8?B?ekMySTZhZVlYNUc5Sjdwa3F1bVV5YVQ3Rlg1Z1pJTk1NM09hTkZ1N0FXek0w?= =?utf-8?B?Ukl4RUZ2Q0ZTaGxoSDd5MWFOendxakxOa1BnUHJNWGV6Wk5LMHRKQmpCNC9O?= =?utf-8?B?NTVjWm55SGN1amlqRllXWWVDQ1p6NkVNd0dURE9BZUkyTWhNWm9NMDFwK1A1?= =?utf-8?B?UkhRd016ZGl1VmRMSEw2bVM3MGE0T3Y0S2pWSk41dTVNVDFjVVNpNVBTVXFh?= =?utf-8?B?bmxjK0tHcUJReWxQUExYRlk0M1pOUlZtZjlFZVVmRlFobVMzVEdQdUF5RjVK?= =?utf-8?B?YnFhTjZMRDk3TmpKYVlxb0hXTVJIQWl4OFhZYXU2WEtldEgyK3dXMDIzcE0z?= =?utf-8?B?M29xOE4ramZRMWVFVFFvaVVub3lJQ2hDUUsybWdXRlNBWjYwWXM0QTFZRjVv?= =?utf-8?B?L00yVXB4Mmh3ZVFIZFRKUmNZM0NWais5WDRUWU0wZjcreldkcWFGRE1DekFB?= =?utf-8?B?akV3K2lpWSsxK1hsNGlKeFl5M0lmemxJK1BPUzBhc1F5SEs0UWhzVUZodTlL?= =?utf-8?B?QkNvejFmbGZuRk9FMVAyOXJJTmpidUZtV0hhVVdSNmlGc2V2Ukp2RWVUeHh1?= =?utf-8?B?eitoRlRqeWV6Nkl3eGVUcDNWci9xMi9sQ1dMWk5lNStyMVVTZDJKM1lld01i?= =?utf-8?B?NCtlV05IS21qRUYyWS9VMDcvc1o3SjhMOExPcDB0UVNUMllsWmRJb2J0U29s?= =?utf-8?B?bVJrSGdwQlRrb0lsclBkRVJGd28wdFVXbFYraVBjN3RVMytKY1poUFZxdFFm?= =?utf-8?B?ckhjQ1Fsa1ZKNm00cWI4bzI5U1FrWmNrb0FZTHExNW5wSlg5N3pYZjhONnJi?= =?utf-8?B?eFZMNVpCL2xVMjQ1ZGlyTWJiUksrVjg3RVhMeVhTeVF2QXJPNzM0QmFMcitP?= =?utf-8?B?WDhDRlhPQzhHMUhFOVBYWUZGdUdqdHpQeUF0S2xzaFIyY25Gc2dyclBFY3d5?= =?utf-8?B?aGwwRFlIaGE2aEJlTkpIS1ZZZFdGTnpLWVZOWXN6R29TSUo0OWRsd09HdEpN?= =?utf-8?B?NXBvL3dPRHA1NXQvbDRocjBvUTNMbUl0elY1ZkcxWFpvRkcyQ0FCWHJtcXl3?= =?utf-8?B?aWxPV3FBWXp5ZUNQcGo3NUdTcHE2SUlBdjZoUVI2R1AzUXNKcTRGZjRhZTJy?= =?utf-8?B?Wi9HbUdZVWtRa0lCbkU2b21HWk1sbFU2SWxIUll5NnAyczlTajcwS3JxdmV2?= =?utf-8?B?a3NPeXVoMGxmWmV4SzVvRnBRMXlHeHpkK25QTHc0aXc3OGJVZ0ROVmdaMkIy?= =?utf-8?B?WHNpNWV6ZlgzdzgwaUZhRytoN2NsYTA5U3B2OXVQTFJsVXVHQ1dzcW1qS2VE?= =?utf-8?B?RHBaK04zdTBSdUdwRW41T1YwR2ZTS0dkVGprRDFsY0lJVk1Ub2oxVXpvaHB0?= =?utf-8?B?NkJ5dUhSNWorVDZ5Y3c5ZzRuTzhCSWg1NG9PeFdYSzdzUnlVUnNKKzlES2VT?= =?utf-8?B?UW90TlVGK1VNMEpqT05Ra29KNmZGOWVlN2x2eG5IN1FROFhFQ2d6VUM1bFgy?= =?utf-8?B?aWJqdVdiQ2tVRVViNjhFbnpUN0FBQXRVemxxNnhuemxoNmZTSDJjYmdSMlI4?= =?utf-8?B?YlN3RVJQTThGRFVoK2R5RUxIRzJrbUtXT0wxZDg4bFVIZ1p1SmFJVk9sQzJh?= =?utf-8?Q?Peg/3Pp/etiY58ALOhiIBfVlT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91ac2c45-1073-4950-a567-08db09d90833 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 13:33:15.5400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x1dHdAHKRKaTb7YSH4oG7tySZA7kOF/B04faGEzRZy71RdDNU3FbQUaBsz+qIhmP3hGbNGnfRgQcMLOVgrE74Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8108 On 08.02.2023 13:05, Ayan Kumar Halder wrote: > In future, we wish to support 32 bit physical address. > However, the current dt and fdt functions can only read u64 values. > We wish to make the DT functions read u64 as well u32 values (depending > on the width of physical address). Also, we wish to detect if any > truncation has occurred (ie while reading u32 physical addresses from > u64 values read from DT). > > device_tree_get_reg() should now be able to return paddr_t. This is > invoked by various callers to get DT address and size. > > For fdt_get_mem_rsv(), we have introduced wrapper ie > fdt_get_mem_rsv_paddr() while will invoke fdt_get_mem_rsv() and translate > u64 to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as > it has been imported from external source. > > For dt_read_number(), we have also introduced a wrapper ie > dt_read_paddr() to read physical addresses. We chose not to modify the > original function as it been used in places where it needs to > specifically u64 values from dt (For eg dt_property_read_u64()). > > Xen prints an error when it detects a truncation (during typecast > between u64 and paddr_t). It is not possible to return an error in all > scenarios. So, it is user's responsibility to check the error logs. > > To detect truncation, we right shift physical address by > "PADDR_BITS - 1" and then if the resulting number is greater than 1, > we know that truncation has occurred and an appropriate error log is > printed. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from > > v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and > "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead > this approach achieves the same purpose. > > 2. No need to check for truncation while converting values from u64 to paddr_t. > > v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. > 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr > 3. Logged error messages in case truncation is detected. > > xen/arch/arm/bootfdt.c | 38 ++++++++++++++++----- > xen/arch/arm/domain_build.c | 2 +- > xen/arch/arm/include/asm/setup.h | 2 +- > xen/arch/arm/setup.c | 14 ++++---- > xen/arch/arm/smpboot.c | 2 +- > xen/include/xen/device_tree.h | 21 ++++++++++++ > xen/include/xen/libfdt/libfdt_xen.h | 52 +++++++++++++++++++++++++++++ > xen/include/xen/types.h | 2 ++ > 8 files changed, 115 insertions(+), 18 deletions(-) > create mode 100644 xen/include/xen/libfdt/libfdt_xen.h Can you please avoid underscores in the names of new files, unless they're strictly required for some reason? > @@ -53,10 +53,30 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, > } > > void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > - u32 size_cells, u64 *start, u64 *size) > + u32 size_cells, paddr_t *start, paddr_t *size) > { > - *start = dt_next_cell(address_cells, cell); > - *size = dt_next_cell(size_cells, cell); > + u64 dt_start, dt_size; No new uses of this type (and its siblings), please. We're in the process of phasing out their use. See ./CODING_STYLE. > + /* > + * dt_next_cell will return u64 whereas paddr_t may be u64 or u32. Thus, > + * there is an implicit cast from u64 to paddr_t. > + */ > + dt_start = dt_next_cell(address_cells, cell); > + dt_size = dt_next_cell(size_cells, cell); > + > + if ( (dt_start >> (PADDR_SHIFT - 1)) > 1 ) > + printk("Error: Physical address greater than max width supported\n"); > + > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) > + printk("Error: Physical size greater than max width supported\n"); While I assume you wrote the checks this way to avoid "shift count too large" compiler diagnostics, personally I think this is making it harder to recognize what is wanted. Already (val >> (PADDR_SHIFT - 1)) >> 1 would be better imo, by why not simply (paddr_t)val != val? > --- a/xen/include/xen/types.h > +++ b/xen/include/xen/types.h > @@ -71,4 +71,6 @@ typedef bool bool_t; > #define test_and_set_bool(b) xchg(&(b), true) > #define test_and_clear_bool(b) xchg(&(b), false) > > +#define PADDR_SHIFT PADDR_BITS Why do we need this alias? And if we need it, on what basis did you pick the file you've put it in? Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 13:38:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 13:38:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491797.761093 (Exim 4.92) (envelope-from ) id 1pPkeB-0004aw-SB; Wed, 08 Feb 2023 13:38:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491797.761093; Wed, 08 Feb 2023 13:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPkeB-0004ap-P5; Wed, 08 Feb 2023 13:38:03 +0000 Received: by outflank-mailman (input) for mailman id 491797; Wed, 08 Feb 2023 13:38:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPkeA-0004aj-NB for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 13:38:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPkdk-0003DK-AW; Wed, 08 Feb 2023 13:37:36 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.11.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPkdk-0004gM-2t; Wed, 08 Feb 2023 13:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=phXoCH2rrOKW//2xnsmEj1K+tWMZjXrxZBLeSAFDrAY=; b=MNFwsGvLEZF3BgB5OIOZ7qcV9w MnVZgWo3qSt97IleMT8bpNVixJSmg1cphu7yQwN8QJ6rYijq4v3z006XinAizcj+xBT1hjX6wvhra sQqsqtNotTOEL8v0nxGVKret42RDZS9IbA9ht9+yDtCCNLpU7zySYenX4Xx8lBPRdwbQ=; Message-ID: <86efcc2f-57ee-9add-89b3-31b4dee56bcd@xen.org> Date: Wed, 8 Feb 2023 13:37:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii , Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 08/02/2023 12:00, Oleksii wrote: > On Tue, 2023-02-07 at 16:07 +0100, Jan Beulich wrote: >> On 07.02.2023 15:46, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/bug.h >>> @@ -0,0 +1,38 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * Copyright (C) 2012 Regents of the University of California >>> + * Copyright (C) 2021-2023 Vates >>> + * >>> + */ >>> +#ifndef _ASM_RISCV_BUG_H >>> +#define _ASM_RISCV_BUG_H >>> + >>> +#include >>> + >>> +#ifndef __ASSEMBLY__ >>> + >>> +#define BUG_FN_REG t0 >>> + >>> +#define BUG_INSTR "ebreak" >>> + >>> +#define INSN_LENGTH_MASK        _UL(0x3) >>> +#define INSN_LENGTH_32          _UL(0x3) >> >> I assume these are deliberately over-simplified (not accounting for >> wider than 32-bit insns in any way)? > The base instruction set has a fixed length of 32-bit naturally aligned > instructions. > > There are extensions of variable length ( where each instruction can be > any number of 16-bit parcels in length ) but they aren't used in Xen > and Linux kernel ( where these definitions were taken from ). > > Compressed ISA is used now where the instruction length is 16 bit and > 'ebreak' instruction, in this case, can be either 16 or 32 bit ( > depending on if compressed ISA is used or not ) >> >>> +#define BUG_INSN_32             _UL(0x00100073) /* ebreak */ >>> +#define BUG_INSN_16             _UL(0x9002)     /* c.ebreak */ >>> +#define COMPRESSED_INSN_MASK    _UL(0xffff) >>> + >>> +#define GET_INSN_LENGTH(insn)                               \ >>> +({                                                          \ >>> +    unsigned long len;                                      \ >>> +    len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ?   \ >>> +        4UL : 2UL;                                          \ >>> +    len;                                                    \ >> >> Any reason for the use of "unsigned long" (not "unsigned int") here? >> > There is no specific reason (at least I don't see it now). It looks > like it can be used here even smaller type than 'unsigned int' as len, > in current case, can be either 4 or 2. > >>> +}) >>> + >>> +/* These are defined by the architecture */ >>> +int is_valid_bugaddr(uint32_t addr); >> >> A function by this name very likely wants to return bool. Also - >> uint32_t (not "unsigned long") for an address? >> > It should be unsigned long. In other part of the code, you are using vaddr_t/paddr_t to describe an address. It would be best to use one of those (I think vaddr_t) so it is clear what kind of address it is supposed to take. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 08 13:53:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 13:53:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491804.761104 (Exim 4.92) (envelope-from ) id 1pPksY-000765-4g; Wed, 08 Feb 2023 13:52:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491804.761104; Wed, 08 Feb 2023 13:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPksY-00075y-1Z; Wed, 08 Feb 2023 13:52:54 +0000 Received: by outflank-mailman (input) for mailman id 491804; Wed, 08 Feb 2023 13:52:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPksX-00075s-6J for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 13:52:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e111f423-a7b7-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 14:52:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7477.eurprd04.prod.outlook.com (2603:10a6:10:1a9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Wed, 8 Feb 2023 13:52:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 13:52:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e111f423-a7b7-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ho81jvmYQ2kSn4W9OKux8FDfKGMJLbDQLdSMIxnP/N9yl1K5rVoNo3nqB5FM8JeY+1VajRMdW7ixgkV/QUbXSGYA5NEpMMxkYR67hQilavZhs9HGIyCyRmRVsK1H1An6XqiR6F230h2n7PgaCGoOCk4hN7qO0rIxvJ8YHRMA5NlbVeX60JSSDLntAKUsbszw/26OluiQrdX0WfGwHDAo+/GO9xmSgKSTAYScb2OpOJZyAmtdH7k7b/IXwAI9v/5a8b23YpF4vvizYex0PNQu0tQzfcGmSsu39G3xz/iRZol0zhW2O9JVk9MFE6ufp4VJZ+bSanragJ68qvaIk5+kWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=okrVck6BRG6qGz81zprf1OrFP5YupAGMWlqt7WKoUmU=; b=Lt92cU1EYiNF2TBWZGUsLn4HlYDUxgDXnFgqDRBVpqtMBx8ulwkhbiNJH9Lmk97qF3UEzGV4E0ZCGfsQ1U8KtHKRbheDOztKNKHgEhOsi8q6LLxO5ZAK2lEhEXg5toUni9wDQZBgndpKJStVD5DUhE3KhIskFpS8awGoolUozKyT4HWhae2LM7ss2DyZSNSI2Bs1Tq0m16lNsNQ15GAwOiLeCpntwmh0iuaFIB8fgWk2/KvI3960po21m3nDiQqgVQdcrf7f5TX6b6AJvs2l39r73CZ6NXBIG071o3ZXyDzKawV7LcyqwXIIaeZjAAUiNM+bJl3qQha9RW1AryeOJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=okrVck6BRG6qGz81zprf1OrFP5YupAGMWlqt7WKoUmU=; b=dILqfusdiimURd9APnF/V0C70ZvPLNrXnLwmBY3YIjThofpsURlmDrP0RxihND9pBjajqbp3DC2dia+DiYnjxFOOKKl6SNKqTySBS50LLtmXJMW40Hs8OBe5eA0LrZOORGvdZ1IhnLYEA8TVHTjOFP55aWOew1JL9xbVHQ2tRnJdlFTKPA+GSDPfc6c+ms93ew6xa5+zmoB+rjmjFm1kRhZMsa5HVnDSjKQzC2KzywQDdqDtTQ8uw7uBS/6tLPIctBKoeuFuPMXfHRtd2Qzd43PpgEwnOaUTmB5VcGWPcGE7H94Jx7tFepCtAvZxjzOYazfPnhvBxez3ej544jgeng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <216343f3-6045-c6fe-ff4c-3a70d5061b78@suse.com> Date: Wed, 8 Feb 2023 14:52:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v3 3/9] xen/drivers: ns16550: Use paddr_t for io_base/io_size Content-Language: en-US To: Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-4-ayan.kumar.halder@amd.com> From: Jan Beulich In-Reply-To: <20230208120529.22313-4-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7477:EE_ X-MS-Office365-Filtering-Correlation-Id: 5294a81f-66fe-44dd-6571-08db09dbb360 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MiCU6aphNvIky9mdVnq2/7cifwZr6e66WqBIgT4qVbNRoMp4Y9gpQNU4PBtHzuqiwO1QVmH9panFDWmTE1mOLFpb4RQvUftasGmKgbMUfOGjwBaGqDYr914/Tkt4qIlZex5899dmB+a1FEdNhisKfqvJ4R/GzwcHhtriIz9wPWOppbAa8TdQ0mymlUridSdyPk43bTdH8OqBRpbIrY+oRuGzRaqQN4S0Oc1/Id3SlBkCwUS9PLIC6A8PV5gox6VY8ojp0fkgZavXvkzhEEahyeqnKUmOCsVxAf8T8M4fTk/XV1x7H7wtKsZPT0ablPUdcwCkjwdEdvYUhlBgRjRTd+GQj7Ud+VHYcvn3HV+a3Ak0vUXYJc53BDqGqRMi47bQxfBAXo3WQHpHVss7QuCeCxrVYFAT7xY70RcHI/swc0bihjDuVE2lvsuOb7IuZf+cow1Aze97rgULXDQCsZFPEPrgvIq96c7Nlwlk7WGKXqzaBtGMj5sA3/uhrEdY0V6Yqtbsv1N0EU9oWTcLzUo9sOXExhS3YjDe2NFrDfvGJAip0TeWBUFV7Zfnqk5MEkCAKmkwiA4TkRkDYr6wx7yuDdKEfjDNUHyZuaxGI4LMdcOlfoAh4Y81ewuIFvz7VkFEi1Y27QhGbCx3idmiyQZHpUG8gZCvuAGNaJLEKSwvPthiAyuH3bRNXcj4NOAV/1hEHtR0vWgeMZ+P7crRFGHS+ooe8uA95TBAwuhoXkVmE/s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39850400004)(346002)(136003)(376002)(396003)(366004)(451199018)(6506007)(86362001)(5660300002)(53546011)(7416002)(26005)(6512007)(31686004)(186003)(66556008)(8936002)(2906002)(66946007)(6916009)(66476007)(4326008)(8676002)(38100700002)(41300700001)(316002)(2616005)(31696002)(478600001)(6486002)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlZ3SlF4UFloSXp2TEJ3Q3BodkdzSG5RMmR2UnhDZnpZMnpIc2tROHhKZFBF?= =?utf-8?B?TTVuR2RGRGhWbTUxajk5ZXFWdFhZa25DYlpqMVNZd3RWZ0Z6QWxicE02RVJV?= =?utf-8?B?SW5JQWNZYmpFR3Vpcm9ydCt1Z2d1UTB6WU1oYWE4SkxMOS9OLzc2TlJFRGxw?= =?utf-8?B?R0xRbkFCK0lIVUIvYnB3SjN4aGgrMHFtSDVaOVFGc2l5TFd3Mlc2UEVGTkZ3?= =?utf-8?B?OXY4djFRMTRjMlJybmNZN09JVWlhb1lmcXEwblZLQStsUXJvNHMrc1JDNUdY?= =?utf-8?B?YVIrbFZlWHpZRk9RR0RGWFlSV2kzS3VuT0IxcGV4MUVXL1VOVmdQemVsV09E?= =?utf-8?B?RWtXc3BKa2ZZd0cwclVhYW5oMzUvTm9mbWY2VUZWN2ZVcXFibCtRaUMwR084?= =?utf-8?B?aFZwOHgyZGlPL21jRTdiZ3dJN1ArTnlDamlZOGkva1hmV2FweW1PUHpxbVpU?= =?utf-8?B?QlJLRTFEOVpHT3c3WG1qNlh5bWx6dG9mQjNGWGRmU2tKSUFVRjFHY1VjWUZv?= =?utf-8?B?eE5uOHhjdmZGd0JCcHJHSmZBYTNmN3daMlF1VEExelhQempoWkUzTDZEZWdM?= =?utf-8?B?Vlo2Ylk4cW9kV2R1bytMNnFJbVlmUURzMlI5T3E4djB1T1FtYnhSb3cxQzRl?= =?utf-8?B?U2pMdlBSNGt2VU9mUUdRbWxpWEpyRUR1cjlqUEduUnlScGZlZ3VQUUdXMENB?= =?utf-8?B?SGVsZkVBMWtySFZ5SXcycUFaNVpsSWdXeENOVU1WOFFKTjRUOTJGSDNjSjdQ?= =?utf-8?B?ZjdTaVp6bnVVZXA0aGh1TEt4SVZKdmlVNUY4bzE4WDBIa0RHa1FmUit0VlF2?= =?utf-8?B?QVdXTElRd1p4VDNYZ2FYWVlSSmdTN3NMWGFvMjZsVWJpVVozK2hRNHRmUCtW?= =?utf-8?B?TGR5S1FDVlVhVy9RV0dPNlFhY1R6b2R4L0QxaldINk1IRG1yZHVkanltTVdJ?= =?utf-8?B?VnZrcmtSaFBMaHBpalVjdlByeVowcEJ0M3QwbFZiMm53QUFCN1UrRGNTYXdn?= =?utf-8?B?TW55TVZnZ1BXOTRUN0tmaDArU1hoSnJKekxBcC8xc0l0dzFpZHR6eVdidEhu?= =?utf-8?B?VGtkd3A3K0tzRjNTdFlxZEgzQmF2SWdYMlJBOGRTbXAreGdIckxnOURGQ2I1?= =?utf-8?B?a1B6ZTRBSzd3aUQxR1JZNUZLRnEwSVZRZmtEcldaNmg2dkVxV1l0SC81NkZy?= =?utf-8?B?QmUzdnZ4My9nQ3pPbTYrQmxQZ2xld1I1ZUlKNUYzOWFCWGNWUTdZMy83VTBM?= =?utf-8?B?U2dVTnBiaUZWT1NvOWd4MUY1Y0Zrdmo5d1VvdFE2ME1zbkFtODNkdE9WYjd6?= =?utf-8?B?ODhSWXVMVUREWDNacDRiSlRIYWkyM1BKZWpaTGRTaWVPazlLNll6MlRWK0dU?= =?utf-8?B?UkZqdnBxQkpZVkdhK1E5WUU4d1RqVXo4YnBJM2ZvL0VvSGlLK2tiTFhMUWNE?= =?utf-8?B?cVZWdmxFOGZuaGFubU5LanNTUEEvN2tyVFl5Q1pDVXV1bGtMNWt6clE0ZThk?= =?utf-8?B?SUMvVVFEdFVoOFd4N2xEd1hFbjYrdUVDcHY0V1VBTEh1bGJncExFTG94USt1?= =?utf-8?B?NE1MN25qVEJnNm9kQ1FQcVJPUGQ1eHFEZ2dScDhGb1lyS2g5dmNVbkpaK2No?= =?utf-8?B?TjB3SWE3NnA1MmVyN3ZvbmEvbEF6Y3hpVTdITWU2b2FKNG1XZWdLOHlnbzVZ?= =?utf-8?B?VUhManBuaEFkRjVzbm8xalNIc3ZCVGw5S2kyUlg4VlQ5VW91WUtIWEhWT0Y1?= =?utf-8?B?elVhVFlBVzhNSlptaHJQSEZ1S2J5N08zVmxONnh5QVBEZWhVcXB2UUpCSDRD?= =?utf-8?B?a29iN3RIbGxBNllLYmFNaXNlUmliNmNtT2FSbi8vc25XYlJ6M3hkQW9zZnhN?= =?utf-8?B?WlQ4VDR5RWpIdTZzODAwQTBsWWhQNXZCa2t6UXVGU1NVTmlMZGZtb3d3YVdi?= =?utf-8?B?ejhtUlhtOC9mUUd4b3VpRTRCSzU4Zm01eEpHR2daZnhvTGl4VVZpMGIwbHp1?= =?utf-8?B?QmFGY1U5NURJUnVQRVVIR0NhbUxGVG5zczlMbGVUMUdKWTlMOVdwTjJFbnIy?= =?utf-8?B?dUhMWmxZMEZuc09GemxhdGtLU3MxYTMwTC9iUGs3YkFBZllOdWVqZWNReGYx?= =?utf-8?Q?Ej/+j6m4UfiDs22qyfxvykTD1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5294a81f-66fe-44dd-6571-08db09dbb360 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 13:52:21.6702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w1cg/Kqvep58LP6xWYgyoK+kFfOpkc1XxQeaDl7M3Itk16nmur9OhQRy+RgTdnKR+EjP6tjjZ/ado8sxriS/Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7477 On 08.02.2023 13:05, Ayan Kumar Halder wrote: > @@ -1166,8 +1166,9 @@ static const struct ns16550_config __initconst uart_config[] = > static int __init > pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > { > - u64 orig_base = uart->io_base; > + paddr_t orig_base = uart->io_base; > unsigned int b, d, f, nextf, i; > + u64 pci_uart_io_base; uint64_t please (also elsewhere as needed), assuming the variable actually needs to survive. And if it needs to, please move it into a more narrow scope (and perhaps shorten its name). > @@ -1259,8 +1260,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) > else > size = len & PCI_BASE_ADDRESS_MEM_MASK; > > - uart->io_base = ((u64)bar_64 << 32) | > - (bar & PCI_BASE_ADDRESS_MEM_MASK); > + pci_uart_io_base = ((u64)bar_64 << 32) | > + (bar & PCI_BASE_ADDRESS_MEM_MASK); > + > + /* Truncation detected while converting to paddr_t */ > + BUG_ON((pci_uart_io_base >> (PADDR_SHIFT - 1)) > 1); Why would we want to crash during early boot at all? And then even at a point where it'll be hard to figure out what's going on, as we're only in the process of configuring the serial console? > @@ -1532,7 +1539,12 @@ static bool __init parse_positional(struct ns16550 *uart, char **str) > else > #endif > { > - uart->io_base = simple_strtoull(conf, &conf, 0); > + uart_io_base = simple_strtoull(conf, &conf, 0); > + > + /* Truncation detected while converting to paddr_t */ > + BUG_ON((uart_io_base >> (PADDR_SHIFT - 1)) > 1); All the same here. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 13:54:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 13:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491811.761115 (Exim 4.92) (envelope-from ) id 1pPktw-0007fA-Ei; Wed, 08 Feb 2023 13:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491811.761115; Wed, 08 Feb 2023 13:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPktw-0007f3-Bu; Wed, 08 Feb 2023 13:54:20 +0000 Received: by outflank-mailman (input) for mailman id 491811; Wed, 08 Feb 2023 13:54:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPktu-0007ev-HH for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 13:54:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPktu-0003eK-3i; Wed, 08 Feb 2023 13:54:18 +0000 Received: from [15.248.2.156] (helo=[10.24.67.27]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pPktt-0005Ex-Sz; Wed, 08 Feb 2023 13:54:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=McnBrCWRoxZlRGej8CiN+mqbawvADBXTJYklGVGhDcE=; b=uJgRHh835FVcJb9JQ+wkttPB+N 8LRDFWYFXzEVSDv3uxehFdexCYSCM/lsv3szx92zj5HTPjVYPi44JEN6gL0vz3yiJwurhuaRSXo5q Sm9FbZVHfDyofTM4foFKbFZhi9mbWVxpg9svHD5A+tXRpHNBSbxKF3bXJeXWOys5AHR8=; Message-ID: <39fbec67-f2ef-bd3b-97fb-c884bea83686@xen.org> Date: Wed, 8 Feb 2023 13:54:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 2/2] xen/arm: Add support for booting gzip compressed uImages Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , ayankuma@amd.com References: <20230202084905.6950-1-michal.orzel@amd.com> <20230202084905.6950-3-michal.orzel@amd.com> <3ef695c9-9b5e-3323-a901-d6daf030e07d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2023 11:36, Michal Orzel wrote: > Hi Julien, Hi, > On 02/02/2023 12:23, Julien Grall wrote: >> >> >> On 02/02/2023 11:12, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> >>> On 02/02/2023 12:01, Julien Grall wrote: >>>> >>>> >>>> Hi Michal, >>>> >>>> On 02/02/2023 08:49, Michal Orzel wrote: >>>>> @@ -265,11 +284,14 @@ static __init int kernel_decompress(struct bootmodule *mod) >>>>> #define IH_ARCH_ARM 2 /* ARM */ >>>>> #define IH_ARCH_ARM64 22 /* ARM64 */ >>>>> >>>>> +/* uImage Compression Types */ >>>>> +#define IH_COMP_GZIP 1 >>>>> + >>>>> /* >>>>> * Check if the image is a uImage and setup kernel_info >>>>> */ >>>>> static int __init kernel_uimage_probe(struct kernel_info *info, >>>>> - paddr_t addr, paddr_t size) >>>>> + struct bootmodule *mod) >>>>> { >>>>> struct { >>>>> __be32 magic; /* Image Header Magic Number */ >>>>> @@ -287,6 +309,8 @@ static int __init kernel_uimage_probe(struct kernel_info *info, >>>>> } uimage; >>>>> >>>>> uint32_t len; >>>>> + paddr_t addr = mod->start; >>>>> + paddr_t size = mod->size; >>>>> >>>>> if ( size < sizeof(uimage) ) >>>>> return -EINVAL; >>>> >>>> Shouldn't we return -ENOENT here? >>> Frankly speaking, I do not want to fall through in such a case. >>> If a kernel size is less than 64B, something is wrong, isn't it? >> >> I agree something is likely wrong but this should not be the job of >> kernel_uimage_probe() to enforce this for everyone. >> >> To give a concrete example, let's imagine we decide to re-order the call >> so kernel_uimage_probe() happens *after* an new header A than would >> require 128 bytes (the number is made up). >> >> It would be wrong for A to return -EINVAL because the other protocol may >> require a smaller size. The same goes here even at least for consistency. >> >> So if you really want to enforce a minimum size, then such check should >> be in the caller. Then each probe could return -ENOENT if the size is >> too small. >> >>> I am not sure if Xen would handle a kernel whose size is less than a page. >> >> I don't see any reason why it would not be. >> >>> >>> I do not like the whole falling through in kernel_probe even in case of obvious violations. >>> But this is something not related to this series so I added to my TODO to properly handle >>> the return types from kernel_probe path. If you really think, we should return -ENOENT here, >>> then ok (although I do not like it). Could this be done on commit if you insist on that? >> >> See above for an alternative proposal. Depending on the version we >> settle on I can do it on commit (but this is not going to happen today >> as OSSTEst is still blocked). > Ok, lets stick to your original suggestion with s/-EINVAL/-ENOENT/ It looks like I didn't gave my reviewed-by. So: Reviewed-by: Julien Grall I will change it on commit. As we discussed on IRC, even if there is no arm32 testing in OSSTest, I expect this to only impact boot and therefore should be caught by the Gitlab CI. You already done some testing [1], so I will commit it now. > and I will come up with something for a future patch as this will require more changes > to make it generic. I also do not like at all the fact that we are not informing the user about the error code > when calling panic from construct_{dom0,domU}... I saw you posted it. I will add it in my queue of patches to review. Cheers, [1] https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/770984105 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:02:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:02:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491817.761125 (Exim 4.92) (envelope-from ) id 1pPl1b-0000wH-88; Wed, 08 Feb 2023 14:02:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491817.761125; Wed, 08 Feb 2023 14:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPl1b-0000wA-5P; Wed, 08 Feb 2023 14:02:15 +0000 Received: by outflank-mailman (input) for mailman id 491817; Wed, 08 Feb 2023 14:02:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPl1Z-0000w4-3E for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:02:13 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ed9b241-a7b9-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 15:02:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7788.eurprd04.prod.outlook.com (2603:10a6:10:1e4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 14:01:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:01:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ed9b241-a7b9-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMFKslKeH5IXe1oQ+WYUuYMt7cKhJ6DAGRjhldd+8nRhSqGA/5aX4/sO0oS03s4WvqnNNX2p4njmVW+Zlnhgav9EIPLtawY+Ey5gyPHqaXMidavVSMFbKOSLyeONkGKgzYUGVAs2BbuK6sZZiQa3bzv5Ns9zBhevr2V8InO4qpIAlX7iZSDzkQ1vlAyPKBR0GYi50Uq7MIq6G+ToG34RiVuFwBZBpIy2mDglzcVIeUz4tgffHp/IT8UNMzigztrsmniWNvv8X6fl3FAq1hHaOoyKtnof6eh6Nc7eZstTUf55jpmLJEbnmxGHn6rkeZSppODXyPyAnpr4GqW/PY4zoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pcJ6Kpoo/jEQgzlnd8Gu/OiW8lE/XFHagJmShQ7+9TI=; b=eIQsuXz7NcvRp8G/EO3jTq9Abgj7zGo+a6yjNeY8eTQNTTWUAovT8/tNxUZNa5ENLSFpQptmi2f8yv0oI7tQYxgCf9/YKxK8iVrz42PR0bSL2gKok67St9hah3k4xi4y+tJb8/tubIjvJtemLTqy2e73WfG0whuNKRYWjY128xaOMKVy0DzUpID2yZs23y3tzw29if+glM0bicLU+p+m5golq5LzuuwPY1oGLC7Npwkk053rhGAPNH7ibeVpzMSDG+q0wHxTbEUwRRJsNDYAkcJQsffPWeHy/8DnQywaM7Kr7bOU5egL3Pf5atl4oSH+1A08ELEDW9FpNsHJb4vYcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pcJ6Kpoo/jEQgzlnd8Gu/OiW8lE/XFHagJmShQ7+9TI=; b=XXnii2IC6Z8oLgQ/iXSOaixXgwB51AMsV508oelrrkD/V2oJVYrUMn6kqhru6R99DG/YxJPRZ7P6qwuLjg5nrl/YHIYU2uMJn0vb1TqCvDYwBj3nIovNP55ds9A8v1D4z9pD67YKa4GWY30Bq3GVMI/RPQLXiJZOsTj2t03ux+ekhPlMGoWLjIeyM/MEGDPhJ1xGUPVjsaGLneunTQCL6HSlyGY/RGmOEYIhoP3YP3JRX8luZ9Ie/SPJ28M2ONW9Zwr++cZLyv+gzyT8XGlVP57aN5evsVoQVHudIY9bFJWupfxFQWAJyTwwnI0TfpMheUhAQ1E0Y4SccYb0QyjZwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1331e8eb-652a-3bdd-2c98-ee695b03d12a@suse.com> Date: Wed, 8 Feb 2023 15:01:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: f3a66975-830b-45ba-57d5-08db09dd0020 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LzifTmLaC+lyj0BZP8ZSGBdhkjwdzTe43Ky/G/OJAk4NF1uL5gmc+hQtB4oEOmzf7peqdFHyL8CErKHJOFCDZt8lhyb+SvYQYa8Py2d/kQJKTFXoXUaXNT2cx1+N/xgZmvWuz9ZDUp+MjKmemp3bbmfvXMJ1UxInKPi2I/38STXZyzOrgHmEoJBflXTnNxgaRF+KGn+UNzMo92RDAeQlLo+dcgKCImthEv63eyOMTGxrqyCgWri38TW5IPO1GNGKDp/JvHvWGumeC/4dPBsvVP54bA2MLzVtRKNr3pAknHOCfObr0cWqQp7iteSgEsoePL7NlTt/A9gGOQWI/9Apy+XzAD+cLCAi/k3ORK9Z6pYb0GUuLCabGlxTIDYfMAWGCGs0CPOkSvonu2aJrw+rr2Ajj+Bnm+XhVVbXpfTkgQ986tnslys2ZMHChI3ZNN70dh8ZgCX0SYHz20reQPy31BX1iJI9x5HxDDjvVmn6jQDYESOhkPyQ3pAdoBDWaClZ/yl8DC8W/qtRAlfAZmVmm7z2sQwrTzAJmjQiLMVBRSUDKT7vPCjzkGscW27c5GGAYbrJCkQmSGK+7jtNEx3cSuARaWnDgxz49i0uwjSFMPxt/2CNvPlSyl9g7rAA6Q8TOOXmLcMprWkoB4zU9NrftpcegO0s4vVYx9MAX4n3SGZUITNHMCh7ShT9KWWf70cFJs5mI4+VPeZ8Xiv6JK8z3N2L0KYPw7Ouw0IMxFkVQEI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(136003)(366004)(376002)(346002)(451199018)(31696002)(6916009)(8676002)(66476007)(66556008)(86362001)(66946007)(4326008)(31686004)(41300700001)(8936002)(316002)(54906003)(5660300002)(38100700002)(6506007)(53546011)(186003)(6512007)(26005)(6486002)(478600001)(2906002)(2616005)(83380400001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU9pbVpMTWphcldNSjJZTndGYjJqVmhIcGxjNFYwcHdQbzE5MlNmUU41cUh6?= =?utf-8?B?RFhEN21wS1g2T3BlcnBIeEtuWURIUy96NDN4VkZGWFFmZHlUWjRzU1Uzbld2?= =?utf-8?B?ZU53c1NqblE5cWJJcm5PL043ZmdoNjAyUmJIc1lCSTMxWXIyQWVib0RnSmVE?= =?utf-8?B?VnpZUmd0MU9Ob3Q2UVlaVW12NWFJR2hnMUl3b0JTeHVvelFtd1lRZ2pjcHNo?= =?utf-8?B?VmExVG9JSHdvSG5Cb3pNSFZieGxKbzNNdzNMeFhweS85cW1HVHRhRDNUT3pP?= =?utf-8?B?TGlSQUdQeGU2Q1ByRHR3eHRqNVVKdk9peVZwS1hrc29iNGxjNkY5Z3ZObm1Z?= =?utf-8?B?ZWpGS29BSkM2WXRoVXdiR2JIS0NRdVE4aWhOZGViQlJhYUZhWjdCa1lIUVlX?= =?utf-8?B?Um9jK2t4TUlvUUN3SEpSUDVSM3M1bDdIb3kwREYvdU9Gc01WTFFmUkkvMFBy?= =?utf-8?B?REZoMTB1eHptZGUxMGNQRGpZVzA2QVdrbFZ3QTgwUDI2RHNocnZWclRERmhN?= =?utf-8?B?QmtrUjlubG5neDhpaWUzQVdoUXpnZVF3K04wZTRJZ3F0eEM2Z0I4TzhJYnpK?= =?utf-8?B?YnpNeUpTNEp5emtrZ1NmbzRmWDFObEdaNnNPRzJ2MzFtbUc3SlR6SURrZ1V2?= =?utf-8?B?Rk1Vbkp6cjZRa0V1cDlwNzNhN05TM2tqcFlqU1RBTjNCSlNhK0hXSXhPVWR0?= =?utf-8?B?SlZJY1F2MGFaTG0zV3pibVVKSUw1bzhWNlJRVzlXWkZ3S0RUaUJ0OUZZSkRl?= =?utf-8?B?RVZHMkVaMXBtOFU2Qm4vbjJhU0JxVEkwM2g1a0ZJa2RiU3FOUVNrY3FKS2JZ?= =?utf-8?B?cjRiSFlXRnFDMTRaVFJpQ3dYWnFGNXNjWkVGamZsZldKUEtCZ3FpQjhWc0tk?= =?utf-8?B?TzQ5QjVpaTFtckJVdjgvbzlCYWhNSXVDdlRCcFg5VTQxOGgwaENYLzV4QmpF?= =?utf-8?B?ek5MQ3FxU1I5Wm5jYkxiQkR2aGhjUDJXUXUzRmdlZWNDUk9Tb3JWVXBPb0VY?= =?utf-8?B?ZHU5bERKSThGdDVUK1ZYZnNZVlVVV1JPdmpxWlhJY0lNTFptVXNVdjBHTUx1?= =?utf-8?B?cGttTGhtYStFdWlaTnNYVFBhcFV2TkRCTW9UNzlVbkNaa0gzckN5dkZxeXFK?= =?utf-8?B?b3cxQ3oyWlJ4WmxVUGUxYlArM3dET3Y4aURUMWZka08xNWZ1Z2t1ZjBDbyt3?= =?utf-8?B?cjJyb2tiTTN2SnRJYlIvSVBKMk1IVTRVYlUrV1RsMDMvR00zc0lFYVVGZ0ta?= =?utf-8?B?bUUrSndiZDFrSWRYNFZDbG9aSFdOS1kvTUxSN2dXZGVSZXNDcGc4RlVTLzFl?= =?utf-8?B?Y2JQQy9qWGNTdDZIc0lVaWFTdDB5QXlHdmNXMmFYSFNlM3o4d1hEbFBoNXo0?= =?utf-8?B?cFZOaVF0K1dYL0FUUFE4bkxlNjd4QlJIdW5iYVJDQ2dwTVo5UGtZWitMdGc4?= =?utf-8?B?OHc5ckw5YkJ2aXBKT2phWVZnVmEra1VwLzUzUG5DNEs2VTN3dnZmZ2UrU3Jj?= =?utf-8?B?NnNzZ0pSWlFJUkpKWkRyek91dEw2SmtYVmY2N1RhRC9NODdrcEtuR09qWExn?= =?utf-8?B?Y2puTi9XTjd1eCtVNmJwbk9yYlVaMFJHeFBZNW1SeDVYNGlKWWNrY2RSSjV0?= =?utf-8?B?dnRJNklEMEhpQWhPTFZ0RGxyT1BUaVJhSlN5eUlMSnNPcUZmYlpwZFNJSEY5?= =?utf-8?B?aC9KWENsNGtJODMzTzhWSjR3bWR4ejR2cHhzV0JiekVQY1pLejRIcEwxY0Zs?= =?utf-8?B?cno1bW1KY1A4TmlJaEpDQWZQQVlzSCtTWHpaWHp5WXhPTlRMcHo2SjE2WVpU?= =?utf-8?B?cEU3MlgrbG1GY1VNU2YwWk81b2plNG5zTUtUbE8yWFY3NVV5dXE0V3NBVjZU?= =?utf-8?B?OXpkV3VucSsrN3lhREdkSWFDUWxIdDl4UnJFQkdsU1hIQWhQd09EdlQ5Z0FK?= =?utf-8?B?TTNSQjNwblo1d3BweGFjQ3JjV281dlVycnB2c0VzajIzbGErTnI5OWJGVVdN?= =?utf-8?B?dEw4RDhRNUxKa3RoKzMzNkVITGZUQlRzcThTV3RsWnY3R2JtUjgrT09SbUZU?= =?utf-8?B?N1AwbXRXZllaVTZnc05EN0ZPNUptK0VxTnJHM0JHODVGeW1FTjdpNnNPMlVl?= =?utf-8?Q?XOtZIIbX7FDOddWOXSkIyEm11?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3a66975-830b-45ba-57d5-08db09dd0020 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:01:39.8849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i3QElFf3XGDRzsyHuXuSttyolg8vQSNpkbZanoS8FqcdeZbdyOPjRrh1NC5HZaC67Ud10sihUylJUM/ujnGB5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7788 On 08.02.2023 13:00, Oleksii wrote: > On Tue, 2023-02-07 at 16:07 +0100, Jan Beulich wrote: >> On 07.02.2023 15:46, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/bug.h >>> @@ -0,0 +1,38 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * Copyright (C) 2012 Regents of the University of California >>> + * Copyright (C) 2021-2023 Vates >>> + * >>> + */ >>> +#ifndef _ASM_RISCV_BUG_H >>> +#define _ASM_RISCV_BUG_H >>> + >>> +#include >>> + >>> +#ifndef __ASSEMBLY__ >>> + >>> +#define BUG_FN_REG t0 >>> + >>> +#define BUG_INSTR "ebreak" >>> + >>> +#define INSN_LENGTH_MASK        _UL(0x3) >>> +#define INSN_LENGTH_32          _UL(0x3) >> >> I assume these are deliberately over-simplified (not accounting for >> wider than 32-bit insns in any way)? > The base instruction set has a fixed length of 32-bit naturally aligned > instructions. > > There are extensions of variable length ( where each instruction can be > any number of 16-bit parcels in length ) but they aren't used in Xen > and Linux kernel ( where these definitions were taken from ). Can there then please be a comment here about this (current) assumption? >>> +#define BUG_INSN_32             _UL(0x00100073) /* ebreak */ >>> +#define BUG_INSN_16             _UL(0x9002)     /* c.ebreak */ >>> +#define COMPRESSED_INSN_MASK    _UL(0xffff) >>> + >>> +#define GET_INSN_LENGTH(insn)                               \ >>> +({                                                          \ >>> +    unsigned long len;                                      \ >>> +    len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ?   \ >>> +        4UL : 2UL;                                          \ >>> +    len;                                                    \ >> >> Any reason for the use of "unsigned long" (not "unsigned int") here? >> > There is no specific reason (at least I don't see it now). It looks > like it can be used here even smaller type than 'unsigned int' as len, > in current case, can be either 4 or 2. Often working with more narrow types isn't as efficient, so using (signed/unsigned) int is generally best unless there are specific reasons to use a wider or more narrow type. >>> @@ -97,7 +98,136 @@ static void do_unexpected_trap(const struct >>> cpu_user_regs *regs) >>>      die(); >>>  } >>>   >>> +void show_execution_state(const struct cpu_user_regs *regs) >>> +{ >>> +    early_printk("implement show_execution_state(regs)\n"); >>> +} >>> + >>> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) >>> +{ >>> +    struct bug_frame *start, *end; >>> +    struct bug_frame *bug = NULL; >> >> const? > regs aren't changed in the function so I decided to put it as const. Hmm, a misunderstanding? I was asking whether there is a reason not to have the three local variables be "pointer to const". As a rule of thumb, const should be added to pointed-to types whenever possible. That way it's very obvious even when looking only in passing that the value/array pointed to isn't supposed to be modified through the variable (or function parameter). >>> +    unsigned int id = 0; >>> +    const char *filename, *predicate; >>> +    int lineno; >>> + >>> +    unsigned long bug_frames[] = { >>> +        (unsigned long)&__start_bug_frames[0], >>> +        (unsigned long)&__stop_bug_frames_0[0], >>> +        (unsigned long)&__stop_bug_frames_1[0], >>> +        (unsigned long)&__stop_bug_frames_2[0], >>> +        (unsigned long)&__stop_bug_frames_3[0], >>> +    }; >>> + >>> +    for ( id = 0; id < BUGFRAME_NR; id++ ) >>> +    { >>> +        start = (struct  bug_frame *)bug_frames[id]; >>> +        end = (struct  bug_frame *)bug_frames[id + 1]; >> >> Nit: Stray double blanks. But I'd like to suggest that you get away >> without casts here in the first place. Such casts are always a >> certain >> risk going forward. > Do you mean that it is better to re-write bug_frame[] to: > struct bug_frane bug_frames[] = { > &__start_bug_frame[0], > ... Yes - the fewer casts the better. Also as per above, as much const as possible. And I expect the array can actually also be static rather than living on the stack. >>> +        while ( start != end ) >>> +        { >>> +            if ( (vaddr_t)bug_loc(start) == pc ) >>> +            { >>> +                bug = start; >>> +                goto found; >>> +            } >>> + >>> +            start++; >>> +        } >>> +    } >>> + >>> + found: >>> +    if ( bug == NULL ) >>> +        return -ENOENT; >>> + >>> +    if ( id == BUGFRAME_run_fn ) >>> +    { >>> +        void (*fn)(const struct cpu_user_regs *) = (void *)regs- >>>> BUG_FN_REG; >>> + >>> +        fn(regs); >>> + >>> +        goto end; >>> +    } >>> + >>> +    /* WARN, BUG or ASSERT: decode the filename pointer and line >>> number. */ >>> +    filename = bug_file(bug); >>> +    lineno = bug_line(bug); >>> + >>> +    switch ( id ) >>> +    { >>> +    case BUGFRAME_warn: >>> +        /* >>> +         * TODO: change early_printk's function to early_printk >>> with format >>> +         *       when s(n)printf() will be added. >>> +         */ >>> +        early_printk("Xen WARN at "); >>> +        early_printk(filename); >>> +        early_printk(":"); >>> +        // early_printk_hnum(lineno); >> >> What's this? At the very least the comment is malformed. > It's an old code that should be removed. Removed? I.e. the line number will never be logged? Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:13:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491826.761136 (Exim 4.92) (envelope-from ) id 1pPlBn-0002d8-9m; Wed, 08 Feb 2023 14:12:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491826.761136; Wed, 08 Feb 2023 14:12:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlBn-0002d1-77; Wed, 08 Feb 2023 14:12:47 +0000 Received: by outflank-mailman (input) for mailman id 491826; Wed, 08 Feb 2023 14:12:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlBm-0002cv-11 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:12:46 +0000 Received: from de-smtp-delivery-114.mimecast.com (de-smtp-delivery-114.mimecast.com [194.104.111.114]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a70ae629-a7ba-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 15:12:44 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-8-gXXzry2_PdWF3BQo1NdXIg-1; Wed, 08 Feb 2023 15:12:17 +0100 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com (2603:10a6:203:9e::22) by AS8PR08MB6328.eurprd08.prod.outlook.com (2603:10a6:20b:33e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Wed, 8 Feb 2023 14:12:01 +0000 Received: from AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::2fae:319e:cfcf:3caf]) by AM5PR0802MB2578.eurprd08.prod.outlook.com ([fe80::2fae:319e:cfcf:3caf%11]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:12:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a70ae629-a7ba-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zf.com; s=mczfcom20220728; t=1675865562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQKq6ajN8oDT2FKzdhA8RMNRAkIGl3uF/n3oq3V9AzE=; b=jEhSqxwrWqIZKoNFL3iK21x13JeMgSzWY0LtWzalPEDOiO5vO+p0lfJ6hjqltNLw21T8jv Z3kRrxosBgV0dhJv4LnL49qtTu4i9tUpqV85l32Y1KrzX1ANYOxHU9GZiEktA/Fxejang7 cVend1olFLMnbp+ywt3/OAfaT29ILvA= X-MC-Unique: gXXzry2_PdWF3BQo1NdXIg-1 From: El Mesdadi Youssef ESK UILD7 To: "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Julien Grall Subject: Missing Libraries (.h) of xenstore, libxl and xenapi Thread-Topic: Missing Libraries (.h) of xenstore, libxl and xenapi Thread-Index: AQHZO8dPTqcqfMxKgEW/bjgkY4U5Fg== Date: Wed, 8 Feb 2023 14:12:00 +0000 Message-ID: References: <3e7059c2-0d23-03f2-9a93-f88de09171f4@xen.org> <619a00f0-0f9f-5f5f-13a7-ea86f9c24eec@xen.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Enabled=true; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SetDate=2023-02-07T09:35:26Z; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Method=Privileged; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_Name=Internal sub2 (no marking); MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_SiteId=eb70b763-b6d7-4486-8555-8831709a784e; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ActionId=1dd26ef2-7370-48f7-8942-e53a52ceae44; MSIP_Label_7294a1c8-9899-41e7-8f6e-8b1b3c79592a_ContentBits=0 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM5PR0802MB2578:EE_|AS8PR08MB6328:EE_ x-ms-office365-filtering-correlation-id: 91acbc10-1505-467f-f1d2-08db09de7262 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: zaAtHRbp3PQgiqoeN7/tRJyaZVaGfAOZG5YKTAdmJ6MRQkhA08WoTw94ihJEqfgalV22+5nYW6Dy7xfQm0NF0JEd2uAjsOl7cvCsF6WgE2YQaGndibK7i3WwaHuYec0ct0VSS4p6RQQTZqWfryDJ3ZHrlzWud8U8CXwRS2DC5blN54KUkhi1BdxQ8zjESSxKGr6KIf8Lf/8fH6r5CC2GQMUK0bvewMTWGWjNFEYfejADTJqKh181d51DjpIz6wlv1h7n9oTWjE/QjVitDbU51tQCJx/y9vhGlGV5C2XxOZSxjJKLI2PJ9wfzTqhrGsui4DYeLGW5vqTMf7nTXZ3bmDmQx4qxy0cvCXOqqye7QcGO+Z8dQz5SsBACUbe8hL2wKJ5sgFHyq4R6NZAlUTNKn1ohiFHifyl5gTAw0imz7gZkIQstHeki6ewJgfs5f4XdrjCCgqKYiHTmh6QDsSFHtu8Ue0vatnL16xCCzUJamMK5JE6LSdPpEt7gmMHUQuiv+fPd3HBWiikdWdL1e4FRgePsu1XC+dvQYK3jwA1pPtBGImTXTTKE6Sl0euP9yqvTxExDR37g3UxTMn3y0wYP+O9hGBF4ish1SUd0CBoUmT03lZV3Z3FiYcTtvCu82ge/UvOIfYocci0LMFnqTfVifEoBlDeFhnkWWv3jYs3tK6Ze7HkVZ6r45YaB/6UTgf526Sp/TQ4Y8GmEXFqKZkzRjA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0802MB2578.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(451199018)(66476007)(66556008)(76116006)(6916009)(82960400001)(66946007)(41300700001)(316002)(478600001)(33656002)(54906003)(38070700005)(38100700002)(7696005)(4743002)(4744005)(8676002)(186003)(9686003)(55016003)(2906002)(86362001)(71200400001)(26005)(122000001)(8936002)(66446008)(5660300002)(64756008)(52536014)(6506007)(4326008);DIR:OUT;SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVY2VVhrczQrVEZjZ0xrVmN4VGkxZ01SQmc5ZUNsQ3BJRlZjZ3VSd0wvVHJo?= =?utf-8?B?bWYySDFaZDl2LzMraDZXZkJzWklyYW9qR2tPUWI1YThoMHlqQk5sK2RhUGds?= =?utf-8?B?N0VDellabVNRL3l1cnhHTC9Ua1hpQ3ZIZmp0eTNyanA1M21BZVBEbmFKQVFS?= =?utf-8?B?TllwRStsZDFyQkJHS1hjVDRBN3VPSHF3dDFyUURTa0pqdzZoVExMVWw4YWN2?= =?utf-8?B?eWVsMnI4MDhkVEUzLzE2ME9uNUN3K2dnbjRZcDZqWUZrVW80SVdJMVhNRVRU?= =?utf-8?B?RjloalFJOURxU1lyajNZYjFoWGRUYlNyQ2R5VTZIVTVtUSttWXk0WGlOWVIr?= =?utf-8?B?RkRSZzdZMGFCODVlOWx1SjdZNVhEcmFaVzlWZjVBOEJsZTJtcjJCWjRDNmlW?= =?utf-8?B?Z1BnVTBGMGRtQnd2NHZ0N2RrbGNra0poU1RJdEVUQ0p3NjAxWHdNZUd0R1Fx?= =?utf-8?B?dHo4b09UU3lHUEFpZFRzL1M0Y3pYTEd5Zk5TeEhTQlVudmR2eVNBTk40UW5w?= =?utf-8?B?RE0wL3hSK1NLb1AxemxPTHRRTkY5Q0pqeXRzRXVkT1MwdnkvSlVvWFNtWE1W?= =?utf-8?B?TXFXbE5zdVV4Ukx6TElQSWFzZW5GOUpBTGtGYklUZTB2dlZNOUJjUDdzRDFq?= =?utf-8?B?ZHNPWkhhaFlxQTdvajQ3MHNuc01XRE1wZmJWVm5RL1FmSVplaUF4SHh5azZx?= =?utf-8?B?bk42anBKRHFhSVh4OFBkY0YyVlMyd2lJSDl6RkJlNml0ZE1iU0ZCZGZZWjNq?= =?utf-8?B?VmJ3THBBSXVjci94YUxCWGdmTjRpTHpsL3JDeldVTUtZeGpKY05pZUpMbEN3?= =?utf-8?B?VmZZdEhzMmtHaDhkTlA4OWtsTVhXamJ6b3R6V3hzT0VBVFRsRVpvQ3Rwck1X?= =?utf-8?B?ZzVyOGZTbXlBclhjRHRuUCtPY0lzRkMvSWpiWVkvRDJEUlBCK3V5UDRGbjdn?= =?utf-8?B?SWtsRDZUQXZXM292SHVDZDMyRXBoREh6SURIdEczaGp1WFA0SVNBVkc5b1NC?= =?utf-8?B?N0VUTGxHOE5ER0E2eHo0L1greG94SGpHaDBSMVh5Rkl2TzN0azFVTlpOazNj?= =?utf-8?B?cE1wMkYvUnNlMmwyQzhEb0FnbkhIbEFZczhMUXQ4U2xRdm5wZ1V4TUFlL2Zp?= =?utf-8?B?bzFyc1RnT1FqZ0dzSDhiSU84WTV0NnltUytFSHFLR0FBUGk4ZHpLblJGU2NP?= =?utf-8?B?Y0E0a0FQOVZGeFJaZnVuY0lTUk1zZVNiM3Urb0xMWmdueW5aYU1LQURkdWxz?= =?utf-8?B?WjJtczhJV0RrcTdUek1TT2lROGtuai9KNlZkMmVhVkp0bkpIVWZBcEcwSVdR?= =?utf-8?B?NnJ5aDFGbEY5SlE1aHU4a2w4VUZhNC9KTysrVllwTllpWlZ2OXV2akt2TUVU?= =?utf-8?B?SnFkVVFMbDhBOXFwcGZaNmtDSmNmc2haMVBQL091eG8vU2RkdEJYWmdyM01t?= =?utf-8?B?bW9NeUpzcXVOclZ5UUdtSUYxYXVTNUFuL1gvYk51bThLRTMyQ3BoSW16K0t3?= =?utf-8?B?SEFoekxUK08vdTByWFREY0s0VUZUSXhqSnBRdVlZeXkvWDlHOWpCd1F5Z2Y2?= =?utf-8?B?eE5ZZWxhM0ZDeG9JaGRWbjBxYW1rb25ZSEdSbFdydjJnOFBiVGFvazZuL1Yz?= =?utf-8?B?eVl1K1kvS1I3WkptTGJVcDVscUdsNDJXS2VETlIvU3AvU2xFZTZXZHB2QTRM?= =?utf-8?B?MFRaaExCVnpOSkduZm5NWWk4bVd6MFViRDltQnRnaW5HaGlkNktPVTlQaVRr?= =?utf-8?B?eXpsS3c2cXhZaDVRZzdvM2haY0YrQ1ZNbG14dHJodFpuWUhGNGw1ZDJIY0FO?= =?utf-8?B?RSt4VmxObm5WZ2ZqWXV0SkJEckRvbW1GQm9TMjdtWVRnNlhLUTQ0SkxYK2tG?= =?utf-8?B?YitoTVRNaFE3VzhvYit2bTNNcVFrUHdJYllKUVFYNTR1OEdZc21Rb1dOZ21v?= =?utf-8?B?V3dqZnVNVnJRUmRmdGRxNmFZZEJhY2krR00xYVdOUktpeFk4eEQyZXBtVUt3?= =?utf-8?B?ZDQ5L0lRd0FZNXlpNkVpSWYrNWJ0ZFp0aDNuUmowL0dldS82V2xIMjhxbFhi?= =?utf-8?B?amxaaytoSmEvUTMrdXE1ZEtubXZnNHpEY2VwM0lSVUJ0VmtuckQzbXlOV2lI?= =?utf-8?Q?3vNf9WmVngClN7NIdGtfv6Xfa?= MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: elMPvIiH/dMYOfdFWNeBvvHCBSUch9pdrrTdjRT+qs9gNyPlFaxWYBq+lBxnTTOi5EyQXXmwCYbQ+oaJCo3ZMO2lUBxI0YONTV/ssT20Dyl5Ztac9w0bhwat0G3GYvcvOgMvXcttmivrKc8eO5N4Zz3cS99INTd9dVdpOSSb+3XADd+KZdy3uDRgBoFaRyLCqhoCjPRo4kkCfofja0UQFKmBpxOaafCWDrJpgDLhdmEXMAvEtLCKWqieYy2XrGH7V/j6oXHvWjNGo9lk/GVnLim2OysH43gEt83S7bT8NJPsj18k6x8wNWMDJgFE50ljzD5j2+OiSp3/vGnIjfSJy4Q91bOFuRWy+Mmyz3U4GP+ARqbww7woYq34mzpnjqM0mHKN4xEwgaQKUBURlNyuotCtXp5CTWb0K5jX0AE7hupUX9/mnil7RM7JWM6pTcdaOu2UA7vmao3+FT+tWEuBEetkDOemclvws0QT8XBD+y7J2ikiQoOUETLx4vT7arpHFdfY6qk7b3UhG1q5RnMmr100RUNCXlk5UiQjyO9Jm7NQILLGaa2TgFxXZhrqxE/VybYDs0qFt8Elejhl33qEGIMKceQqm/qDZLUXBa/mQj+6tp1qbAIxXhoqnpmlSjxY+0f/nI/LsxWPyybSJy2VFwZevGIAcPFgrjHYVXa5qy0DIpTmR+ZX+qgDHEghqPx/7ZlSePPJVmGLl7Pu3nN6NdiXtqziAqPx7o2EORD73H7phRnY56wrKPA+lxQf8XM+e51bIQYlKYsZsQDxZxI/ep/sMij7HbgrPQgL3XpVQknlbDvffobLcqv3d7DO4Ehdct8yMNXxzV1T+aFWE9S0Mw== X-OriginatorOrg: zf.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM5PR0802MB2578.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91acbc10-1505-467f-f1d2-08db09de7262 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 14:12:00.9377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: eb70b763-b6d7-4486-8555-8831709a784e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i+i4vo4WHahdShnX+axzcn9T0lPt39bBQA0/oGjrdquUDdXUI4wW4wC7YCnpUj+9kRTuAJwMAsGjhK0oL1Q8O/0Z5qdZM78EVmQdRL9i48Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6328 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: zf.com Content-Language: de-DE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 PkhlbGxvIHRvZ2V0aGVyLA0KDQo+aW0gdHJ5aW5nIHRvIHdyaXRlIEMgY29kZSB0byBtb25pdG9y IHRoZSBDUFUgdXNhZ2UgaW4gYW5kIG1lbW9yeSBhbGxvY2F0aW9uIGluIGEgdmVyeSBzaG9ydCB0 aW1lIChpbiBtaWNyb3NlY29uZCAvIGlmIHBvc3NpYmxlIGFsc28gbmFubyBzZWNvbmQpLiBGb3Ig dGhpcyBJIG5lZWQgdG8gdXNlIHRoZSBmdW5jdGlvbnMgcHJvdmlkZWQgYnkgdGhlIGZvbGxvd2lu ZyBsaWJyYXJpZXMsIGxpYnhsLmggLyB4ZW5zdG9yZS5oICBvciB0aGUgbGlicmFyaWVzIHByb3Zp ZGVkIGJ5IHhlbmFwaS4gVW5mb3J0dW5hdGVseSB0aG9zZSBsaWJyYXJpZXMgKHRoZSBoZWFkZXIg ZGF0ZWkpIGFyZSBub3QgaW5zdGFsbGVkLiBTaG91bGQgSSBidWlsZCB0aGVtIHdpdGggbXkgaW1h Z2U/IE9yIGlzIHRoZXJlIGFueSBvdGhlciBzb2x1dGlvbj8NCg0KPkkgYW0gdXNpbmcgeGVuIDEu MTQgb24gdGhlIHMzMmczIGZyb20gbnhwIG1pY3JvcHJvY2Vzc29yLCBuZXdlc3QgdmVyc2lvbiAo eGVuIDEuMTcpIGlzIG5vdCBzdXBwb3J0ZWQgeWV0IG9uIHRoZSBzMzJnMy4NCg0KPklmIHlvdSBh bHNvIGhhdmUgc29tZSBkb2N1bWVudGF0aW9ucyB0aGF0IGNvdWxkIGhlbHAgbWUgdG8gdXNlIGFu ZCB1bmRlcnN0YW5kIHRoZSBmdW5jdGlvbnMgaW5zaWRlIHRob3NlICguaCkgZmlsZXMsIGl0IHdv dWxkIGJlIHNvIGhlbHBmdWwgaWYgeW91IHNoYXJlIHRob3NlIGRvY3VtZW50cyB3aXRoIG1lLiBU aGFuayB5b3Ugc28gbXVjaCBmb3IgdGhlIHN1cHBvcnQuDQoNCkJlc3QgcmVnYXJkcw0KWW91c3Nl ZiBFbCBNZXNkYWRpDQoNCg0K From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:36:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:36:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491832.761148 (Exim 4.92) (envelope-from ) id 1pPlYX-0005V9-5y; Wed, 08 Feb 2023 14:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491832.761148; Wed, 08 Feb 2023 14:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlYX-0005V2-3E; Wed, 08 Feb 2023 14:36:17 +0000 Received: by outflank-mailman (input) for mailman id 491832; Wed, 08 Feb 2023 14:36:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlYV-0005Uw-NW for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:36:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20604.outbound.protection.outlook.com [2a01:111:f400:fe1a::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee8501a0-a7bd-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 15:36:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9196.eurprd04.prod.outlook.com (2603:10a6:10:2fb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 8 Feb 2023 14:36:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:36:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee8501a0-a7bd-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdykdlAhLC09LzuP8lvvQ1zir9V4enNNlFFYbEoxlNKopCCp5TTLne/9oHCzq5DC+c933ksXQBHoayJYMmKCX1gFbqq4274l3qM+y/em9rqUkXV8SZ2WN1RJ59UZRLPBkXvSj1vMifp1c0/mNThmyuMRfNt5tJrZrZDHhBejXjiSa95ml2D7mdB8a5x6Y0UIH12+UIT6w6bftDQWTYc2c7MJnBOkW5IuW+2GqhzZ554GklwB8Wtk0pM0gKxKPB0blD2PMdeUNhdZp3JB9ghH3wY4TaE1v/iEa6ZEBf/RFxoCKmJ72SkKUok7ut84ZjQq8jrHRDfRW/X2EzNRjHDijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULamCwbkY8loNWVReuZrKYv+2dnNsKI3wYg3dw/3S20=; b=jNSQyiWYAEjK8VFuB07sdAS7WkGMMUQEe//WgFXCvV4BUdQLZWyArRd259+nwD/AJhRf9GVwWEGnHac570h4gPxq7RAH5DOblEGYvn4daXQYXK5gBmtHwhRGJB+MDGMPxwHitq9+01uEidKo2xUvRdlNlYLLxv0z/VXEVHET4hTkxif0JU18IDHx/W+P2IuOTXzVUJ7bwOWnIG3LTOJl1iQpWUGF66jPn3CiGHYiztuGM00HBTNZul0E1NNDuPjCCyIGCwvClbxZOT//F7J7S9qflKrwM2NIgrnG9r7OkfdCi9MZLTTupBEpjq4Rq0+VtA22umcX6v0P8yE22iUgIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULamCwbkY8loNWVReuZrKYv+2dnNsKI3wYg3dw/3S20=; b=aXAM4TP4DlPRCTAcNKOYXc+FVi+WeEfyNfMCFmsJPITXaIt+oXAahvjcRzqu4fEG2QFi1bTC5HC30kU1B7PbFw6okSHumU7nFADarkkATrrtrycUy2cOLp8UY487qOyISQhGutqzvz9gU3tGWDALv36fDHndUeDSEQAXvlCADdLDlBts8eSQK/Y+lV/yirG/y9u2gzE+6Jom4VxwDA5AShNmiBbEXQ2ddjexuAPvdNNqnLpCG+vI4TAR/rMu+oTdvF5wjjhcV8aldPtq0yNZlweD4u8g32K9lCsx/a24f5uNQrh0OOpEzXuok5tOFD7GuEmLix4vR7A4mLxJrAcNZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 8 Feb 2023 15:36:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Jan Beulich Subject: [PATCH v3 0/4] x86/shadow: misc tidying To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9196:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e8a29e1-7829-407a-d07d-08db09e1d1a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nn4Naz6CUnlOyS+h0DAjQ1abcn3iP8ANsVzdWHWTkj8/RJxf4H1TAynS+AW2wOMogX+V+OLWdHXla04Q8XDBRqk8hT68jmC10mI3IDfYQEjaKLPrVrpYsPL81anSy6Y41iXkfWBxD/EFQNs0YXBZRIu1U5BHuC4u8KSfEsCIFMbrq9hC87yv6EvDi3eB98tr0dbrzsW6WkbncT5HiPmf9weNMRmKhXSME9rDOZWPwo7OvOUblxz8N3CJJ94SwUnWw50J0rXVikQFak/gTGdRenpKw19dKAApKy2t8FV4qSJn1YwKVL0ByS7x0ieZalimV24VBAxy5coSR3N+0fG3Vl3SEW+cv+ju4Wuh4TL6EMeWGiUPqraXnVkR1cT3nXEllwCY7rDwzQXT1eB9u6d6c5aqbZhxyL/3AII//8prGsSPiYNy4WJXtMq6T76n1PY53BWEFtPjh8bqRzt+MHOaBJ+5u2qFkgp9ZBfi10pn2yFH6aJe4LIEsoHuAJFKCC85gLp9jrY10CMa5ffoVhiXufFjpSAAWLfxdFTZ+Zhgo30BRx/Xr4Bxls/Rzidjf+BfxjDDONrU0HS3q3QDwT6vEJbUq84Rrkx5/ckDhUHGLm9l7AsenL0hUdIWZ4Xeee6CaSvXxBR/tiJbylVPEES/KlzvUiqSYckY4euaQIxwSFutUTCv/5zTfgseErX11OValZ72QsGVakz0ElfduNUIJjbjQVaG4PNKK703PkAnnbsJZPingCz/vdjwCoViOLABjQWfCt8rb/relwtNwCGBCp9eZPcbY23zX5GXym/I8Fo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(366004)(396003)(136003)(39860400002)(451199018)(31686004)(54906003)(186003)(26005)(6512007)(31696002)(86362001)(36756003)(8676002)(4744005)(5660300002)(6666004)(66946007)(2906002)(8936002)(6916009)(66476007)(66556008)(41300700001)(4326008)(478600001)(2616005)(6506007)(6486002)(38100700002)(316002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3dNRERJblRzQVJNcWtuUUxKQTRKZEhiTGRTNkM3TjdtTFZWVG9FaG1ncHhw?= =?utf-8?B?WlFrbWtzQzcyY3Y5NkhVODUxRDZFQmNDWUp3blRyOStqR09XdGdDeHh3Mklr?= =?utf-8?B?N3BSejZKSVhNOThldHBjd0VJanRjTWJydTNid2lYaHVONmpXaTVIOVU4ZTZ6?= =?utf-8?B?a1JFeEdQdmF1cDg3RVd5VFYvWlpJQnptNE5sc0NaZk0xejNnbnNaWUNOd1NQ?= =?utf-8?B?UGNUMUhlejkweHR6d2VCUDZ6M0FjQmNCUStPamEyQ01YeEpueHJkdk5LYkVS?= =?utf-8?B?Ky9ZZnpmekdmRFo0bS8vSjRjaXRPYStGc3Qvd2tBcDdiMzN5eEtUQVE0Z2Fy?= =?utf-8?B?alpZZXlhMjl5T1pQZnNXQXB1YmtiZkpZRFI3RitiN3M2NWlGTEU3MUN0a2dL?= =?utf-8?B?Ukpnd1E1U1VORjJiVzVxeFdkY3pFUWlOODZRanA4YitTWkRTNGhLZHozaSt0?= =?utf-8?B?R3FZRjhicVJPaTZ6N2IxSHkvYVRyZVB5eTFlRkJlRHpTcUJLUEVyaGNDN3dk?= =?utf-8?B?azllNjB6bzZDQWVjVHk3N21NdjdGaHEzMGxZSG1SOEorbm5ORUpoRHlld2FY?= =?utf-8?B?OHVBeHBac2pIcXliUWFQWUhyWXE2SmVGVGN0c1FoT1d4T1BMOTlQSkZHQitm?= =?utf-8?B?NWZIazNHNW5za0k2SklidHhWc1QxNTJ0bTFHVnVrRmU3N2tmZW1OWnh3dFBl?= =?utf-8?B?LzVQSFNMZHRMaUdhajFmeStQS1RzQUJhakZKZSszdk9PNG1POGoxcG1Ta3Vm?= =?utf-8?B?SVRFeGltZldaN05XMU1kbjgwYVYzemhkcTdINnArZjhKbDhDc1NtZHBNbnB2?= =?utf-8?B?Z3ZkWGtBaktBVFhNUWg1U2JJNnFWcUpIVU9YNmhyRWVLWllmQWEwMnl1YlhJ?= =?utf-8?B?UndCWXZjV2ZRMkdIMlhXUkV0VWQ4TXlZL0x5ZDdsbGp1UVVIdUVxZHF4QnBh?= =?utf-8?B?OXlLRERDc0JSTVJnZkk0NkhpRUJGeGVaY3Q5NFY0L005QzlSR0FVb0dBOThJ?= =?utf-8?B?QkFhemRRREV3RlFZZFk4NWVqdDdwd0xlbE1HU1RBbVNQaklFSEM1YXNScDJa?= =?utf-8?B?ZFhKa1hYSzg0TzBIS3V3SUo4dU1vMHZ3M0tBSTVmeFFZaWFCdkN0djkweFZ0?= =?utf-8?B?c3ZPTjlXc3c2Z2JSQVh0emZ2ZXBmUUw2OUZTOU5qVkFXdk5MeFE5bUJQZWVP?= =?utf-8?B?YVJDTysyVHFralVRNWVYMWNFTmR6ay9qcTN2anJ5VGNaS0duSFAwQVExbGRy?= =?utf-8?B?ZjNWN1czRGZhQ2tNaUlJSU1mTVhmcDFjMnVQWDNVa1FwUk5WY2RiK1ArZjdD?= =?utf-8?B?MnNwVGxYTXZDRjRTdmREUEE4cEpFMmlPbGdjSytYK0FXRjdscFpCbkNCYkFJ?= =?utf-8?B?WlkxOERLeVNldEdCU3N2YVZLQlMxK2dMZU1jU2p0QWVod3g4WHo3U1IzQUFy?= =?utf-8?B?WWNmemlIdWlQOTZrSkJJN2ZWSTZRKzZKc1R5YVR6NHdWRDEvNk43MDlacjV2?= =?utf-8?B?UmZmWWFwaEl1aExoWlpVTW9ZSFBuZnhrWVpCcmZaYjJVT3lqWEFTcWYvNFla?= =?utf-8?B?aEd2RE4xeUlFMGJIQ3YwczBwalFUTm8xbVBydFdPRjVMdjFTUWRGa0RxNEpz?= =?utf-8?B?U04vcDBLL0puY01oSDZHQmNtR3Nja0lsRFdZTFdycE5FaDhuREtZbFVITGw1?= =?utf-8?B?K3B6OERUem1zKzJIQ2xwWitBM043SVhseGZUM3pHa1RZK3c2aVpiK0g5Uk1P?= =?utf-8?B?TldncFI2TTkrR29GUjB4ZkZvRVlEWklZZmVUNDBBREZTNHZrR3E5TnJEYmNC?= =?utf-8?B?TWRCOTkwL2M2ZHFCbUFPWGNteE53Q1IycHBsUTEyQUV6eTN5Z3JwTEVvZWcx?= =?utf-8?B?dFpYZ2tqYWh5dVVCcU1JNkZLSExhcHU2a0I1cm4zMXBQVGxsand3OW9BelNZ?= =?utf-8?B?bys5VWhmRmhacGdwc1VFS0ZRR1UwcVp3MmdaOERGWHYrakozSld6OHEzVGxD?= =?utf-8?B?Mk5tQVR2VGFhQ0lpeHUyOGNqY1VzQzk4a2d5VndwWGxNRDVQeFlGeDBWVTQz?= =?utf-8?B?eWtIMFRaSWUzWDY1bm9WUHVPTDNBTEZFOUY0NUxBZ0ZidzVCejdPNmo1OFBi?= =?utf-8?Q?RU6Px7818/c8e6s9ekBtwl1WQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e8a29e1-7829-407a-d07d-08db09e1d1a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:36:09.4725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HxkeaNzuQ1/Oxq2tcj2RarRvCUYWDcIEuD6wE4ux6YAcpdxcjc/1dJKjrvkpoUa5qC94OR0fELLL0EakwfjyjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9196 ... or so I hope. The main observation was that we still have both hash_vcpu_for_each() and hash_domain_for_each(), where the latter was introduced in 2014/15 to replace the former. Only some eight years later we can now complete this conversion. Everything else addresses other things noticed along the road. 1: replace sh_reset_l3_up_pointers() 2: drop hash_vcpu_foreach() 3: rename hash_domain_foreach() 4: re-work 4-level SHADOW_FOREACH_L2E() See individual patches for changes. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:37:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:37:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491838.761158 (Exim 4.92) (envelope-from ) id 1pPlZn-000614-GM; Wed, 08 Feb 2023 14:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491838.761158; Wed, 08 Feb 2023 14:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlZn-00060x-DJ; Wed, 08 Feb 2023 14:37:35 +0000 Received: by outflank-mailman (input) for mailman id 491838; Wed, 08 Feb 2023 14:37:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlZl-0005uV-Of for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:37:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20620.outbound.protection.outlook.com [2a01:111:f400:7e1b::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f2608dd-a7be-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 15:37:33 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9343.eurprd04.prod.outlook.com (2603:10a6:102:2a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 8 Feb 2023 14:37:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:37:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f2608dd-a7be-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DrS+vnlzccE9IWsvsXtED7UZwF7WWkjI5pRMEQXWyKxx1gHcnbsCQOtV2OHnricjn8gPJKDHqILaaPDW5QW2MoUXbHWpmBP4dbm2UGejKxxMbPDnQdBfibEaYaVcOS9uMojyb2yG/RNQMvNs+u1Oepy3yYalYi8JB1RkYS1sdlfJOLIHHm9mMlCcP/63NFwWHvzLfg8y27pab8nS0FOHMbowjJcbnGqvlhEUXQiWSBaVvQzEBImL1toXQ8MgE/UO5Btd49gjOr5ND6Y62POj8mN/Ah15fe44RNmvqJg3XEgOIoAAqtEf9ezHcff72F4feqGSPawHfuHgKWAtMl4Ygg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9OFFDeWa7q1c8WhKPz1ZFmBqxkr1kVm4Ujr2h18c0yg=; b=b1ADAVqAiEVqKArrvPwGoM0wtrdsi/LqpGViZxC0sox5A8B8vVbMb1tE3bRzCJGW+g8vY3lo4Rr5EEVS8AEtQfVduDEWMfX/nII4d6xXVnegI0AdkhpnPW9f97MOhYsLAzkv2EpokDIyab2ia24vaIkSMTk1DBYYlekGgRgWcoJ7kfCHZi6D8g8PLwYLM05ab3aTXzJCx1HYXZXMxqvCkmBi0laAKDoxA6E7qyrDFvjzxpRB+De5JjqOgMjfRu1iit9zDCxCM+Tzs6ZR+aohi26XaiUqk6+b9dhqZRc4WjGKJddbKw33oHBgQarV65fHgX3j9H6jMCgfX0BcyOFluA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9OFFDeWa7q1c8WhKPz1ZFmBqxkr1kVm4Ujr2h18c0yg=; b=iZkyHsFQYtKxTQYYWsIS7pvq2sBKeIryr9u55glMvGbT5tPPQQ2RsbxpIkF4ELTkEeGP7gQWzePkFrX/VC8/7n5BcmXhCR+OrpqwevkJqmBYn+00tUxzYJdFmXjjD2BNrZpMfS4CtxKnpgnN+CR3CspN6dJxDOF7aioCp0HJrbCjH3uCgmaj9X9Dn5qEiCxTqvnCPboIHfbW/5Jm0Fc9mMoXlviIzGeQcyceV//uy1pjksni/UNTezjq9Ov0HsWbAIdwEe6qzzhCgRs0cu/aHcjlz5HcPV12QrYnYCe6S32ird2q0AbT0WT0dyddMXWBC+ND810uRnu9Va7LgucTvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55114c08-6407-db9c-a25c-06fa7bbfd4e8@suse.com> Date: Wed, 8 Feb 2023 15:37:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH v3 1/4] x86/shadow: replace sh_reset_l3_up_pointers() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: a9050c5a-b306-4410-92c0-08db09e1f6e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: shjkBeSBCdIULCxKfU1Km7pTB2b7uFYVwdbUu3Gln0LhyDGNB1+nQpELTiiHc0YeJJnvoczil663ew1qHtHrZ59jyBloFM5LqFCzvqzCFrgOgUhZPa7ecmt75M7sVw8gjam5GTI2topyJAiLBxI/rYCBIeogtvCtOHBHdXI+iVrO/3RPSImYXoSqtueBIXXM8wx9Qc+xdiCSg3EYhaq/wvxOQgED09wHZyGkVZAXwEL5OjcQfBh1m+98X9Gg45NxoNqgplHy5x3B1oYXNEHOO3vID+uYYqtKEUYqvLhL8C5lsXDD9A+siZIi1N5tbEVS3Br5+ry2gURxDg2WJjX/HKKt+WLtybElgpCtysjnA8JrXG3MRgxei/GGf1zhGCb3E7p5khjE2hToj+kYGhL7Na9ZCi+8gxNDfAnj477ru5mlo+8LAqwRewA3OcK1ZJyVYlg6FvMhmR0nrDjb0PLCmAmcH0vRjbpKQ0vrmH4gEuKn+UkfkLr96wML4vTZr11ljHBRg1qmr/rgT/lgV5TIDvveKwffg5GiC0yc+67I28b0dFTPUtL11JxFK61ky/5n4fZuUBl4nI4ssHeFdCMjzn3rys/WMDvypB6GEcNhUZWiMdtybhyA0DgZRyUDscfT94mvwR1derPyTzQq+wPPOxbEDZikVKYDGo8rAwpRwtVs/4FEO5KOptKnkU+13Ns4pXpDdH0ktfg9iEyyOnhyAwnEBe7h6XYzNG6zFww25Ro= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199018)(31686004)(83380400001)(6486002)(36756003)(5660300002)(2906002)(26005)(186003)(31696002)(478600001)(6506007)(6512007)(6666004)(41300700001)(54906003)(86362001)(38100700002)(2616005)(316002)(66946007)(4326008)(6916009)(66556008)(8676002)(8936002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?by9MUk5yYzZFalB5U3pra2hybjFuWldIY3NURFY5MkNJOW5sRmxnQ3JyS2lZ?= =?utf-8?B?TGhySjNsZDRhNTFucjRPWXlZRmIyRDlBc05GakpvOHQ3NmVrQ2lMZng5WmlJ?= =?utf-8?B?V0I4SEk3dzhHS1FvMGpYZVBhOUtDc0JoOXVUSTVkMXZPS3NibEorTDBlQUVO?= =?utf-8?B?QU1kSzRnLy9nWkRvMTkwV09XSWNROXBHbC9HeHowSlE2VURLdC9xUHAzeUJ4?= =?utf-8?B?WHFKQzNrUFZQbnlVQ29FS3JtdWJWWHFvWmhUbjZSalhucnU1eFR2ZDVCa1lr?= =?utf-8?B?NGJ5KytVb1M3RWlaa2p6MEw2MnZqT2hTSVg2NG5NNmtvMDlhbzJXK0xZL2pm?= =?utf-8?B?endvZENzQmtPdlhTeWVBNllwRzlJOEZQWHZnUDdPaExwc3ZCemZEdmNKbWY4?= =?utf-8?B?bENpUXQ2dGJQOVdjWFYzaWFhaDZvalBkWjFWVU55OTdiRy9iVndjMmc2a0tC?= =?utf-8?B?elkvZUo4c3Z4WUFsLzQyeWhTbXM2QzlGc3htWW54K1JRcDdiK2tXOGdYVUdI?= =?utf-8?B?amRwRXFka21RWWhsVHhNeVR0L2pXVk5lWnRoRmZQNndUOU1RTXg1Y0VGd3lj?= =?utf-8?B?VGVDZ0hrdkh4b0YvemJpVE1iQ1gzOWJUMGNvTksrdmRTdVo2OW53YmhUNGtt?= =?utf-8?B?OGF1OE5kK2VRZHMyckZUU1FQMFZ4MUtsazFHR1BEQmpXcElFLzhubUxGTGJB?= =?utf-8?B?TFUzaitSQWF3REIzN2RIak9rSUhoUSsvMFd4YUZXVWN1Z3Z5TkxxUytrci9q?= =?utf-8?B?QmFPMldqck9KZWVoSnAzT1BGRkM4TkZObXpKQVFUZ2Nqc3FnTXFPVS83RW1y?= =?utf-8?B?K0NnWis0T3BXZzFRakhmdnVRYmtMUjh4c0p4alEwdUdTaXZ4L3ZUa2tnYkQ1?= =?utf-8?B?aWFpWEZKQ3Rzc1FZWDFCUXJNVTR2bFlQU2UvbHFjU2pia0tmSTFpSmpOY3RO?= =?utf-8?B?VkIrdnNwaksvblRRT2F5ZjhralgwN0VXNVBiVUxxbjZKazhGU3Z5ZXFnREMy?= =?utf-8?B?Wmttem1uNTZ2S3VXaTZKbXpRbmkvRDVFZ2krYTIxbGl3QU9Id2lNb3FHeUtK?= =?utf-8?B?eDZDVWIwajg5bUZjSHZ6Tm9DWDJ0YVg3eFlhamNJcldERWI0RHNkVW5hYnZR?= =?utf-8?B?c2pIc09hNjlOUDlBZVBqQms5SVR0YlFVRU5SL0dNeGYxSzlYM0ptNzN0Mjkv?= =?utf-8?B?LzZPaEFCc1VXekhvS1BCRnZNcHFXYjhqYU9oaHZtdi9SdFg4ZE1iaUROYU1u?= =?utf-8?B?S3VDdC9uK094QlhwZklrcExRRkNxUXI0bGFaeDBIOVU4ajFYa2NMTEw1eWgw?= =?utf-8?B?Q3Z0cE11ZVFlZmREN2JtczltNFUyT3ZFRTZGYXJsNXdza3ZBNXJMbDhQMTJ1?= =?utf-8?B?aDIva1kzdWJ0MUQvOXBtZVB4Tm9lMStqS2tRaThlZUl3V3VzMnJjVllDMU5U?= =?utf-8?B?M3hiYlZiVW92ZzVxYlFZdUtRNnk1cTVaTFNnYnlTTjdxeEs1WG11NU1JUG9W?= =?utf-8?B?bkl6dXh4K21SeG1ZZWhIam8vZHN0d1ZkNmpuQmZaTmxHWjRNMlBMNmZlNDlJ?= =?utf-8?B?UW80dDd3Y2dRZGkzY1FjSHp5Q3FueERUb0xva2NSR2NvRUNYV0Q0dENiR05L?= =?utf-8?B?OVNqRnRaVWdPSjlSSUpZT1J6Q0ZobFJmZHF3Z2tHUnF2L3kvZ00vSnltMmlT?= =?utf-8?B?bzQvTmRUaGdOZnkvY0NJa1E5Zkcwb2RHMVV6K1RXdUo0cVFORHpxT3IydndS?= =?utf-8?B?Rm5YbVhLWVY0K3Y5Z1VGVjVNdHFrTFhUN2xTZmpsNlYxUkUzRk80NDYrYi9S?= =?utf-8?B?ZDU1bGZaVVNjTWVaRDAwcXhISjgrWVJKZ3luL3NkZmNDbVh5UWRBR1hkMFhI?= =?utf-8?B?VDB0ak9HUmRiOUlZYzFqTk5CZlVDRHAxZWREMkR1d1FvUzc1dmc0aENTcEhT?= =?utf-8?B?bEpCc2pGM1lESGdTRGxVc21KVzMxaUl4bmtXVTduT0J3a2ZOVERTaUhzWnJq?= =?utf-8?B?VGJpUnFpdkYrN0tuQUc2dWs4TTFScEpwYVVMelIyekViZnlpVlV4U3RTR0hV?= =?utf-8?B?c0R2Snk5KzNoUHBZb3BnWml6Zzh5WXBoTmRkQU9hMEdXUUxJVjRMR1pCd0Jw?= =?utf-8?Q?dbA63uEnTuOhMOJdZ7Q/9Ok/+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9050c5a-b306-4410-92c0-08db09e1f6e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:37:11.8904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: izx8F0g51C9a/q4kyhVLL3i31CPqGxejAfvMefCe4XRtcgh9fQ0a7ISF9yFi6t7/CgDJ7OFk0dXxQTZ223qmng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9343 Rather than doing a separate hash walk (and then even using the vCPU variant, which is to go away), do the up-pointer-clearing right in sh_unpin(), as an alternative to the (now further limited) enlisting on a "free floating" list fragment. This utilizes the fact that such list fragments are traversed only for multi-page shadows (in shadow_free() and sh_next_page()). Furthermore sh_terminate_list() is a safe guard only anyway, which isn't in use in the common case (it actually does something only for BIGMEM configurations). Signed-off-by: Jan Beulich --- v3: Clear sp->up uniformly for all L3/64 shadows. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2371,29 +2371,6 @@ static void sh_detach_old_tables(struct /**************************************************************************/ -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -static int cf_check sh_clear_up_pointer( - struct vcpu *v, mfn_t smfn, mfn_t unused) -{ - mfn_to_page(smfn)->up = 0; - return 0; -} - -void sh_reset_l3_up_pointers(struct vcpu *v) -{ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { - [SH_type_l3_64_shadow] = sh_clear_up_pointer, - }; - - HASH_CALLBACKS_CHECK(SHF_L3_64); - hash_vcpu_foreach(v, SHF_L3_64, callbacks, INVALID_MFN); -} - - -/**************************************************************************/ - static void sh_update_paging_modes(struct vcpu *v) { struct domain *d = v->domain; --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -971,7 +971,6 @@ sh_make_shadow(struct vcpu *v, mfn_t gmf sh_unpin(d, page_to_mfn(sp)); } d->arch.paging.shadow.opt_flags &= ~SHOPT_LINUX_L3_TOPLEVEL; - sh_reset_l3_up_pointers(v); } } #endif --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -505,11 +505,6 @@ void shadow_blow_tables(struct domain *d */ int sh_remove_all_mappings(struct domain *d, mfn_t gmfn, gfn_t gfn); -/* Reset the up-pointers of every L3 shadow to 0. - * This is called when l3 shadows stop being pinnable, to clear out all - * the list-head bits so the up-pointer field is properly inititalised. */ -void sh_reset_l3_up_pointers(struct vcpu *v); - /****************************************************************************** * Flags used in the return value of the shadow_set_lXe() functions... */ @@ -729,7 +724,7 @@ static inline void sh_unpin(struct domai { struct page_list_head tmp_list, *pin_list; struct page_info *sp, *next; - unsigned int i, head_type; + unsigned int i, head_type, sz; ASSERT(mfn_valid(smfn)); sp = mfn_to_page(smfn); @@ -741,20 +736,29 @@ static inline void sh_unpin(struct domai return; sp->u.sh.pinned = 0; - /* Cut the sub-list out of the list of pinned shadows, - * stitching it back into a list fragment of its own. */ + sz = shadow_size(head_type); + + /* + * Cut the sub-list out of the list of pinned shadows, stitching + * multi-page shadows back into a list fragment of their own. + */ pin_list = &d->arch.paging.shadow.pinned_shadows; INIT_PAGE_LIST_HEAD(&tmp_list); - for ( i = 0; i < shadow_size(head_type); i++ ) + for ( i = 0; i < sz; i++ ) { ASSERT(sp->u.sh.type == head_type); ASSERT(!i || !sp->u.sh.head); next = page_list_next(sp, pin_list); page_list_del(sp, pin_list); - page_list_add_tail(sp, &tmp_list); + if ( sz > 1 ) + page_list_add_tail(sp, &tmp_list); + else if ( head_type == SH_type_l3_64_shadow ) + sp->up = 0; sp = next; } - sh_terminate_list(&tmp_list); + + if ( sz > 1 ) + sh_terminate_list(&tmp_list); sh_put_ref(d, smfn, 0); } From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:37:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:37:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491839.761169 (Exim 4.92) (envelope-from ) id 1pPlZx-0006KX-T0; Wed, 08 Feb 2023 14:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491839.761169; Wed, 08 Feb 2023 14:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlZx-0006KO-QE; Wed, 08 Feb 2023 14:37:45 +0000 Received: by outflank-mailman (input) for mailman id 491839; Wed, 08 Feb 2023 14:37:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlZw-0006Jc-6G for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:37:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7e1b::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24b06bb7-a7be-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 15:37:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9343.eurprd04.prod.outlook.com (2603:10a6:102:2a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 8 Feb 2023 14:37:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:37:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24b06bb7-a7be-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbtCQ3Fj/naIk3mxntRfiOU2vyS+Lrro7KvreNTYOjgyzhIJPzlKhvfsRHVPwL/yYZCiTtvpyecp4OV1jZE9a6/DVkcsd7Mt4g8oBbayq5wPlxBeitLuQoXkm1G20Ma5H/ktFok5k1Shcd7U8dbZNN0zCEn4K7bTlZnaEzXTmwbrvQh2JuGF/M4xgJvCmkRAiJrOHfZAQDi6H1R7YZ5x7qET9DljqUIKq2wuOn4XJej37QsKvw0JWJ8QdJFJ8yLpq8rvBRl0IMB9knZiAj5TOsXCWzaGKgkoQZVxqz3LSmNeCQ9wTeJWq7maVr8e6P3pAKfmWNC0nDrQBpSwVgcLQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0EWXtpH9i4csdupIvMLjkJkLdXonRZOQV6uj0BrMrb4=; b=Xf2PPYj8eLALD3yFgK1POvzyG91HO0VMWx/LTkMDovigZVagv+seUfcanaYYrVbshPz1EP4mAu2JsmnroMmKoBY60axMfycNtmW/tqeVZj+AeDwMSZfaL7xIepppJPfsFbtofveCLk99iRPhldccky23Z5G3bYmqGifYuLaQs1gyaTPTyq1SLchU/31XWEbYvpVBFGOWgx+DLZ3mV5fGfgw0vqfIz2m85iQUrqt2jl9gQWVII3pnSt1SmbXhQoxccYE24HXa1KZlBM8Ffe0MGGHgF7QHmwMM0awXZ5saOYWI/XiU9V0tf09XsC2f4G5YMM2JgNS8LRGCIQY7Bsfc5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0EWXtpH9i4csdupIvMLjkJkLdXonRZOQV6uj0BrMrb4=; b=Qh1qHPV6wUp7LMfiGM3gQnJkKOnv0lVT95ZPlGeB49SFKvguHIE39ZasZUFu1wb/twDrnkHPEZFpK9nX2PVVhqd0vyJ37zHUTQ8nCYJkocZmJKEFw9sXbTfCRbt/gASSuuxCqXdT2bT7g+fVEWvGietZQhygGOG9pjROYAaOye8M3bBp8x6o5QK9TGp2Alo2qzua2lSnSnWqGtHg5OQVjBrhXKSJZjidizczDkCz7RLfN/xAheBW1h/zdWmmgM1QV6CPWXAML9YkKCVXfz9mJC8JJUTC2RQ8KGkbzRmDJQj5g/y33GVvw62nWnyw8BP/jmqpJ0V6jGaj9ocqzmydcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f9d6428-9cc6-ddff-a65f-25b7ef7556b7@suse.com> Date: Wed, 8 Feb 2023 15:37:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH v3 2/4] x86/shadow: drop hash_vcpu_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: bfed1094-557c-41a1-f566-08db09e2082c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oyus828w65Ulom6Fw9Ld1C96VHblAak5+1JTsFg4zy76P9K2uwBw8VokHmE9F9A2T7Fy6GE9J9YOV1YTYEuF0OpCnsxxeLKTQMcLMQkqroPwMjSy4ahcqg663Vd2+35coR4kMQTRuFHBPEW3j6kMSYusi5RVrT6KjxXWxTQz4Q5mXRHCWHif7Kt8tSaYIPZtqL9MvQu41wDMXZ4sQJxMVj/uYfcd3OvId7gMYWYYWGXGFi/YffVFGC6RZvMrzPHSD2XmNYQfZSLcR5DcMhzm3aRL6v5PoHQDlmXLCMiVcMqGqk5+7gjKKE14SBGBLKmtTf5Y0K/u+2oBILydtxxX1BfXAU61xJnojP9KKGAyDTH+CcIyMlETTgvl25mzEchTTvPcBcZSWarXX02MhPtnUsVLIGo2F0Mw2SQsHkTL7gRVWVkTCcOYNYgO7VHEioADV+VYYryMmaCz0t/XJ4ekRbZnNd/ONhBq+n+gmFHMp5D6fBqnjMhpNgCoi/z2xVYkqd5aimuEdtzs/2EZXIiRE0uKinuzuZxB3VsUjb+9CvZcthHobUftFMvu8EwYwqztrzoIXp/jbNfqHZ3JCp1VdKOsHSwAaOKo6JW/+yiNp8ajhUbvlf9xhFP0jQ03DDEyoP+G9Nnpqxypw+K/oyKuPbxIWKRrBMpumuEy7Eg3YayopQ9mQBeLIadlIPLElaWyskSI7Kz9YOePNtkh+PSFw5zjvaQw+GXK4iOFoov3arCSM3pucBZvsqR8wQP3RNoO0NnSlocV2h1hJITjU+ndSrVbPlNyUa6o9mB9F/rM6nIz952g41ATZ6o76StHXuLL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199018)(31686004)(83380400001)(6486002)(36756003)(5660300002)(2906002)(26005)(186003)(31696002)(478600001)(6506007)(6512007)(41300700001)(54906003)(86362001)(38100700002)(2616005)(316002)(66946007)(4326008)(6916009)(66556008)(8676002)(8936002)(66476007)(43740500002)(45980500001)(414714003)(473944003)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDN0ZCtRM1JUdzZBczZmRGwvOFRrSXVpM0xTNm9oSitZbGczNDFzMDBnYmow?= =?utf-8?B?VHJxaHg5MllaRnJSY3NqMjEvZFlBMGlvQy9QdWtYelE5WE5mTjdhOFhZZ2ow?= =?utf-8?B?YTIzNVJ0MllWWnlBVytJUnhDSkt0WkRwQ3NiTm9oOGhQVjQxLzZCV1BESHU3?= =?utf-8?B?Z1lKS2dLeDJBUWtPS1gwMUdPNlROOEJycHVLaTNRenFqR2FSRlZ3ZEw0NmxT?= =?utf-8?B?ei9hcHQxcG9JdnpTdno2MGthNGZPdUVPb254Q1ArWFRKV1hOaEpzb3VvNHV1?= =?utf-8?B?NzR5T0JQZko1a1VJejc4bU55Wm4vN3M5aHN2VHEvSGJWeWsrMnBZTDNVRkU2?= =?utf-8?B?NGQ2bXV4TnRuYUVXS010RmhmNWNWclU2WnEzZ2lpcUI4VW9UNVNZRStsMDJ5?= =?utf-8?B?RytMUG9PYWdTOTZkSU9HdGtVNXFPcmJzeVBMR3MzSFh3UVNNWDRBRFAvR25i?= =?utf-8?B?dzRaVUhIT0I0ZUZScDFrV0I3cVRlc295ejlVbGxLOFpiREJRNTgzR3h2cWx5?= =?utf-8?B?UkhQY1VhTmJ5VGdJQS93dk5nUUNQN0U0QWdhR0xMbFM1Nm9DdEhMbXZjbDBM?= =?utf-8?B?c210TGxrQk5IYkt1Tm1GeDBoWVdZY1BXQ241MHk5b1Vlb0VtbW9Lblc4UUEr?= =?utf-8?B?YW9QQThWakxtYXBlYVJxQ3RiQVlrQW5sTDNDL1BpYUQvV3RqbUFzUFlkOHlM?= =?utf-8?B?ZzROOTNxOXQwWUJhYnVGdzFUa3hwR3Z0eUJrZ1kyWnJOTmgxb1VOd01OQi9Q?= =?utf-8?B?SDkrM0pObllDRFFMZGJRUXBwZWxiNEpxOE5xdWJKSzVyZkpsZzd1OXZKM1Jt?= =?utf-8?B?TjZFa00xV3FOTUowTXRTVnQzRjhsRmttODJUNlNNd1RBT0l3Znh6Y1RNeTJK?= =?utf-8?B?WEtLNEpFZDE5b3NmbmJqTy8wbVJPUFpjSVV3MURHMnZwRk44SHJYcExiQ2Mx?= =?utf-8?B?aXdoN1g2alU3QXBtK0UrZGVBVDdISENvc1dUQm9QUWp5NjFqK2ptRUVhcmR4?= =?utf-8?B?UTUzSDhiTFA3Nml0Ny9uMmx0UktXc2VvQmVWUEVYNDJxMDBoRk5ETThKQjVj?= =?utf-8?B?QW16MWJPQzlJdVJIU3EraEt5eE9JbmRhU2VhRjMzQzYxQ3VNRm4yZng1Mzhq?= =?utf-8?B?c1lRektBU245cHFDelRrRng0K01adVJtcWxOL3lhbWRicnZCdGhGc2ZaN0tp?= =?utf-8?B?Qk1WdHZJUkUzY1I1dDFGNWp4YXlXQnd5Q1dlZWlNTEEyeWVHNGhpOHV3bWc0?= =?utf-8?B?VWppNVFuN2QxQWNTTEhuMkRlVmFqLzl0NmkydVNKM0JaMHNVcngrQUwraEV6?= =?utf-8?B?R3JlNG1wZjA5L1J3cmVWN0xld2FzeThtT1U0N2pLZVFDNDl4aWpEUldPU2lI?= =?utf-8?B?d05nYTArZlJac1R6cHlES3dYMUllRkFyeFdtTmFIQTM1cDlIVlBjVGlBa3E0?= =?utf-8?B?OHhKY25NRXpXZUpuMWdNdEdrTlFtT05qT0FuZ29OTWphQ1NHaGVvVi9nWERm?= =?utf-8?B?VWxadTM2WVFsb1dUOXVJZ1hIdE50WTVib3lGbGRnaGZXZTFQb2JmYW1Uc1dh?= =?utf-8?B?RDhzN2E5Zlo3aStrWmRMVmZ3Zjc3dXRKZWM1R2dnR0djdENKWmVoTFo2WUlV?= =?utf-8?B?VWhXazk2bktTWks0Sk1rNm8wWUJDZWE1U2F2QUlOamw3aWR4NUpVdFJ2TGpN?= =?utf-8?B?d2FjRFR6RHZiVEZBR2lYRlRJbDh0ZGUxUFBqS1phWDhFNnJTKzZ6UlFLMzk0?= =?utf-8?B?QmdWMVVCcHdOTGFZb05GQ1c3ajZuQlh4a0JZaFdWS01vUCtGTGs1dGFBU3JN?= =?utf-8?B?VDkwbU15bFpxbTQyWG1PZXhMTW9MRm5MQ2Z6dm9yWm0wN3hKRlJ0OU0venlL?= =?utf-8?B?SVJMejI5bGRLb0lyWFg0RDgrM2ZEd2hHU3dKUC80eXc2dmpucE1BTDB3VE9P?= =?utf-8?B?Q0xSMkg1VDZZYmxCcEFQQldOYkk4VDEzSmluVCtodlNvTW4rYUZGZE1TUHlw?= =?utf-8?B?TUtmZnRHUDhuRzFIN0xBNXRFaUJRY3k4MEM5TlYzYzdwVFhsTFl6V0ZHb01p?= =?utf-8?B?b0dGWVYrbTJwdjh6c0F3aUlKVTBubGVSOHhLVzREMW5qTit6VXp1UzBlOXZX?= =?utf-8?Q?f7D/ovlylvtKegyOvcfqGjclr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfed1094-557c-41a1-f566-08db09e2082c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:37:40.8573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qi7RMSmI8R0LN+SMJZj8MT/lBkghHjLLSZZ64ktBxK6ip/pNc93t6utOAoOSl0wEFKB629GV7oW3zCSV8/HY3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9343 The domain based variant is easily usable by shadow_audit_tables(); all that's needed is conversion of the callback functions. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v3: Re-base. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1680,59 +1680,11 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_vcpu_callback_t)(struct vcpu *v, mfn_t smfn, mfn_t other_mfn); typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_vcpu_foreach(struct vcpu *v, unsigned int callback_mask, - const hash_vcpu_callback_t callbacks[], - mfn_t callback_mfn) -/* Walk the hash table looking at the types of the entries and - * calling the appropriate callback function for each entry. - * The mask determines which shadow types we call back for, and the array - * of callbacks tells us which function to call. - * Any callback may return non-zero to let us skip the rest of the scan. - * - * WARNING: Callbacks MUST NOT add or remove hash entries unless they - * then return non-zero to terminate the scan. */ -{ - int i, done = 0; - struct domain *d = v->domain; - struct page_info *x; - - ASSERT(paging_locked_by_me(d)); - - /* Can be called via p2m code &c after shadow teardown. */ - if ( unlikely(!d->arch.paging.shadow.hash_table) ) - return; - - /* Say we're here, to stop hash-lookups reordering the chains */ - ASSERT(d->arch.paging.shadow.hash_walking == 0); - d->arch.paging.shadow.hash_walking = 1; - - for ( i = 0; i < SHADOW_HASH_BUCKETS; i++ ) - { - /* WARNING: This is not safe against changes to the hash table. - * The callback *must* return non-zero if it has inserted or - * deleted anything from the hash (lookups are OK, though). */ - for ( x = d->arch.paging.shadow.hash_table[i]; x; x = next_shadow(x) ) - { - if ( callback_mask & (1 << x->u.sh.type) ) - { - ASSERT(x->u.sh.type <= SH_type_max_shadow); - ASSERT(callbacks[x->u.sh.type] != NULL); - done = callbacks[x->u.sh.type](v, page_to_mfn(x), - callback_mfn); - if ( done ) break; - } - } - if ( done ) break; - } - d->arch.paging.shadow.hash_walking = 0; -} - static void hash_domain_foreach(struct domain *d, unsigned int callback_mask, const hash_domain_callback_t callbacks[], @@ -3280,7 +3232,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_vcpu_callback_t callbacks[SH_type_unused] = { + static const hash_domain_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3329,7 +3281,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_vcpu_foreach(v, mask, callbacks, INVALID_MFN); + hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -333,32 +333,32 @@ static void sh_audit_gw(struct vcpu *v, if ( mfn_valid(gw->l4mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l4mfn, SH_type_l4_shadow))) ) - (void) sh_audit_l4_table(v, smfn, INVALID_MFN); + sh_audit_l4_table(d, smfn, INVALID_MFN); if ( mfn_valid(gw->l3mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l3mfn, SH_type_l3_shadow))) ) - (void) sh_audit_l3_table(v, smfn, INVALID_MFN); + sh_audit_l3_table(d, smfn, INVALID_MFN); #endif /* PAE or 64... */ if ( mfn_valid(gw->l2mfn) ) { if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #if GUEST_PAGING_LEVELS >= 4 && defined(CONFIG_PV32) if ( mfn_valid((smfn = get_shadow_status(d, gw->l2mfn, SH_type_l2h_shadow))) ) - (void) sh_audit_l2_table(v, smfn, INVALID_MFN); + sh_audit_l2_table(d, smfn, INVALID_MFN); #endif } if ( mfn_valid(gw->l1mfn) && mfn_valid((smfn = get_shadow_status(d, gw->l1mfn, SH_type_l1_shadow))) ) - (void) sh_audit_l1_table(v, smfn, INVALID_MFN); + sh_audit_l1_table(d, smfn, INVALID_MFN); else if ( (guest_l2e_get_flags(gw->l2e) & _PAGE_PRESENT) && (guest_l2e_get_flags(gw->l2e) & _PAGE_PSE) && mfn_valid( (smfn = get_fl1_shadow_status(d, guest_l2e_get_gfn(gw->l2e)))) ) - (void) sh_audit_fl1_table(v, smfn, INVALID_MFN); + sh_audit_fl1_table(d, smfn, INVALID_MFN); #endif /* SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES */ } @@ -3920,9 +3920,8 @@ static const char *sh_audit_flags(const return NULL; } -int cf_check sh_audit_l1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_l1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { - struct domain *d = v->domain; guest_l1e_t *gl1e, *gp; shadow_l1e_t *sl1e; mfn_t mfn, gmfn, gl1mfn; @@ -3989,7 +3988,7 @@ int cf_check sh_audit_l1_table(struct vc return done; } -int cf_check sh_audit_fl1_table(struct vcpu *v, mfn_t sl1mfn, mfn_t x) +int cf_check sh_audit_fl1_table(struct domain *d, mfn_t sl1mfn, mfn_t x) { guest_l1e_t *gl1e, e; shadow_l1e_t *sl1e; @@ -4015,9 +4014,8 @@ int cf_check sh_audit_fl1_table(struct v return 0; } -int cf_check sh_audit_l2_table(struct vcpu *v, mfn_t sl2mfn, mfn_t x) +int cf_check sh_audit_l2_table(struct domain *d, mfn_t sl2mfn, mfn_t x) { - struct domain *d = v->domain; guest_l2e_t *gl2e, *gp; shadow_l2e_t *sl2e; mfn_t mfn, gmfn, gl2mfn; @@ -4067,9 +4065,8 @@ int cf_check sh_audit_l2_table(struct vc } #if GUEST_PAGING_LEVELS >= 4 -int cf_check sh_audit_l3_table(struct vcpu *v, mfn_t sl3mfn, mfn_t x) +int cf_check sh_audit_l3_table(struct domain *d, mfn_t sl3mfn, mfn_t x) { - struct domain *d = v->domain; guest_l3e_t *gl3e, *gp; shadow_l3e_t *sl3e; mfn_t mfn, gmfn, gl3mfn; @@ -4117,9 +4114,8 @@ int cf_check sh_audit_l3_table(struct vc return 0; } -int cf_check sh_audit_l4_table(struct vcpu *v, mfn_t sl4mfn, mfn_t x) +int cf_check sh_audit_l4_table(struct domain *d, mfn_t sl4mfn, mfn_t x) { - struct domain *d = v->domain; guest_l4e_t *gl4e, *gp; shadow_l4e_t *sl4e; mfn_t mfn, gmfn, gl4mfn; --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -83,19 +83,19 @@ SHADOW_INTERNAL_NAME(sh_remove_l3_shadow #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES int cf_check SHADOW_INTERNAL_NAME(sh_audit_l1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_fl1_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl1mfn, mfn_t x); + (struct domain *d, mfn_t sl1mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l2_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl2mfn, mfn_t x); + (struct domain *d, mfn_t sl2mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l3_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl3mfn, mfn_t x); + (struct domain *d, mfn_t sl3mfn, mfn_t x); int cf_check SHADOW_INTERNAL_NAME(sh_audit_l4_table, GUEST_LEVELS) - (struct vcpu *v, mfn_t sl4mfn, mfn_t x); + (struct domain *d, mfn_t sl4mfn, mfn_t x); #endif extern const struct paging_mode From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:38:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:38:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491847.761181 (Exim 4.92) (envelope-from ) id 1pPlaG-0006w1-70; Wed, 08 Feb 2023 14:38:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491847.761181; Wed, 08 Feb 2023 14:38:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlaG-0006vs-3D; Wed, 08 Feb 2023 14:38:04 +0000 Received: by outflank-mailman (input) for mailman id 491847; Wed, 08 Feb 2023 14:38:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlaF-0006Jc-9R for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:38:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7e1b::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 302e92b4-a7be-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 15:38:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9343.eurprd04.prod.outlook.com (2603:10a6:102:2a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 8 Feb 2023 14:37:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:37:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 302e92b4-a7be-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxytKhLHogxVaSy3rKMjoRZ0tuZ3VcYuYGU8TL1+BcV73hlkqzuvN4VwLWOJ6w33yl7sC9AyPe6+ybCXsK56rSfH6h124wk1mtb5UJlPfa4/tqaLKboobi/HS0qrlRkFnoZXGeKJFsgDdyS82i6ueQw0fyktE7CftDs8Ut/b3X6i7ef0sWha/IfoUnCNWAEcLvjffdgQNcOlJC3RXEcwL6hnDwfL0JmJxqfgf1uBBbNNW/xpQ3BUaJHl8C0g+Q1ooWo5AfEnVzNzVPDPhIUvhOodJI+gujk0gRSFqh9kJAfgzece7jAYLsrlz3CHRGSaGqpUNQmLYg8r2fio9ppmgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z4ux/6tWNQBcW4wZFr0MDeGUcIrrS8cZY8coYVotxL8=; b=lahJGM0c92A3RJ5cL722RF5FWN9y5saT+j7OK1LG706wD0KJXHjUHpiE009k1Q0fWrUmmAQ44quGjt9WAdnY1FlJeCHorzqIIBxeCf5PkmfTpXqeCOXK3gBAaZLY6nG94kbFr4JATJ15feL7NjpqYkrlKh7M6xjEPw+UbGK1pfiv9eNGCAg7bgOOiIxKU6LTnlb/m8KPihjPWoJxWHxEygFjF0Z4mMxLqnF52L9NYetb24T3eaCPM0BjV0V+5ifw0k5NLzEVmoL6+hDMnWGVH/q6u/2b4/9zCq5665xFs/sTLFcaJd+FZXv4uyXmRLMzwVvljClA/6OnyKVaySbmtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z4ux/6tWNQBcW4wZFr0MDeGUcIrrS8cZY8coYVotxL8=; b=po9kfWLv26qWv9anAv+kougLog3B3orii9DwzrVE0G9vlMwF0EVh2LHHBLxYw7rtucxq02Qe3bYRrYqczKUozlZfFzC7WD6uXUSJF4u9kyjJJ/gaBGYrrzo6egh6wNzJH/3LJwLo4dpvsL0DvSdRMly7f/zFqkIH3k5835cT7EbdhhiyxMcObf3f2RAL9EsuJ7DSax62uVAhp+p39TIqRE4rN9HAQUkg0gjYbpwQbWmpud5J74lt3UEuO+ndVqUV86r6+R80j7Bg7ILNColX10asArZlzNeoknUzkm7shoMrSvzgbn5ztiM95mNOaUM/4o9j1TL9tbB2FH2rFX0eAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 8 Feb 2023 15:37:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH v3 3/4] x86/shadow: rename hash_domain_foreach() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: dbe2301b-5c59-42b9-cce7-08db09e21359 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WpmEtlNKVRqR0IDDeaRC3+KhsB3O89G4fgdPGJ9ShZ1RToQY7jI1qIb0avMWi7B/bAK8mYc80WO7WvzM6aaXYS9RvuQmUAXqSBfoSkBOWvDFQHgCsXwhcvPozVDJCw01sT/QFbP43iWE3sSK8SW6e8521d6mN+zRITMatLVmfgT+bHZu94MEysRgOsW59dv6J+mJ7pzE4CrCXUIHTh6/kRPadUkPD1RfSGtY2yCPVMtfcwz+iLnsadLOtlX01Hx8kf05942nxr6HIZH87jTPRUAGWaMHxl7m3YqdHTCzb8tmWJBsySipHNvWhmvKdLNyVcDL6FTmcTw85cEFQ08KnHoKUq+g44YFv9Flk1cyCWbrg6NhOoEoDGwLY4b+gCaLCA0RnbV/oxJIW5z6YIJKvlVQpl+s31b+ZybMc/HxCmZyGe/tr5d5FWyR0ICtkOJqDzwcPqhL7zzcQXp0K5fk0LRU3i8lv3o/43gzkOw4AH85Qe06ed/fD+YRUqqSW+9ERlZ4vOpadoZiWkzAVAXZ0KPAsKGARkFm1+8s9X0F2/O5bQ0yl6oQOJxOYcuVeSuKRPv9Gfe1EpKBJAMLWfVffDvgegqIY4hwG5l6zsndBmAbcME95uFb6Y5iLqbWBCsENh4nFBfYPoC1Jg9dtHWPF3CCQnpckZcrqFUzkAwmB83zVdEfqNWWjDXynqqWxKulo8hi1Vx31KB9uyKwIVlQPAZTemU4bocbuvLR1jSEqAY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199018)(31686004)(83380400001)(6486002)(36756003)(5660300002)(2906002)(26005)(186003)(31696002)(478600001)(6506007)(6512007)(41300700001)(54906003)(86362001)(38100700002)(2616005)(316002)(66946007)(4326008)(6916009)(66556008)(8676002)(8936002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?My93aksxZWpQT0htUmZCOHFuaVRHa2MwQnVTMkdPcXhZdUFpNldObXhDU29F?= =?utf-8?B?QkROTGtEYTJMZ0R6N2xDcnZHbExTRnlwNVZjVUZHeGFyaVVPbyswMUc0Wk5V?= =?utf-8?B?UDBkamZVSjJQMEgvajFoQnpsSjZxdmsrODdvRlJRWi94YUNZaFllbTB1bUMr?= =?utf-8?B?K2hkOGxvcEdoRXBlS2lkZlhTeCtNOTV3amdQQS9pMjlQVkJYekI2Z1hkc2hD?= =?utf-8?B?VGlBQVdoanUwVGdtSS9GeWlmdGJodlRtWXp3Ty9NZEh4L1QxNHo2SzNETUhW?= =?utf-8?B?b21iSkkzSncwMFdzdGJ2NUVZQ2p1Z3VuRDJrU2dITlNLUVdKZ1R0VFZVWGxp?= =?utf-8?B?RVhzbjZ2a1dzU0UxeTNIbFdiUVUxbHA3aktOeGdOSGhZZnl3REdMaWV5b3pC?= =?utf-8?B?dUZ1MEl0ZkVMK0tHQXViOE9URlhZcC9lQ3Bxdlh1aWR1T3R0WWN0RkNyMms0?= =?utf-8?B?TTQ2a2twZjlMbVhDQ3B5RU5rNGxGbjl2MFFtZUxuQWF3NFVTcTN0UHZzNE9W?= =?utf-8?B?bi92UDNqS1h3QmFRSzR1NW04ZjVXVkRWQUxXUEo2dEFuRWdKTTdEbWtRQlpu?= =?utf-8?B?aXRJZXlpT2hvdTUzU0U3K2srUVZSM2VZNU11MkFkRGl2cnlTVmx4R29IakJ4?= =?utf-8?B?Q3c3SjU0VmdBQVdxVFV3Q3hZUTlQd0JqMXRDeEVJTlJ2cUloREEzZUdGVEY4?= =?utf-8?B?M1B5ZVJpZDN2cW1yeGt3WVVpOFpBWndPUCtheFUxUVhhOEpYTVd4d2RtaFVV?= =?utf-8?B?RloyN1BXQXg2S3VzTDhoWVVkb3VOcUFGK1FndjlMM1pkSmFxdXFqem1OQ1Ny?= =?utf-8?B?L1dkZzJsVWdmYzZ0Z2lvR3FGRk85dG5WbFBtWjVTbndiNEZKcFd6T0JUSk1H?= =?utf-8?B?ZmUzWnZURGxOZ09PMW8zU3BERW9lR0I5UUN5a2RWOU9NLzMrMkp2WER5RHkz?= =?utf-8?B?SlBjVHI0UlRBcThIWUpDcHpRRVcrd0tHRmVHM3dMOE1FK1QxZm9GTUcra0VR?= =?utf-8?B?bjdzM0VINDNZYVhUK0xSRm5aamxJL0ZINWUvaXo2TGlOUEJ2SGFsMUNLc0Zw?= =?utf-8?B?dWVzNXMvcVdSOS8rQjh6NjZFOVdxZ2swRHJnMTl1NThCeXZjNlBzTEg2NWxD?= =?utf-8?B?U0RzSnBRUzBHOVRmQVBwRnpQQjVuc3R3WHpMS0VJdkpUZUpmTVg0eWRJeUFu?= =?utf-8?B?UTBYRXpueTVTTG51Ulg3cFBLVElSQ1NNWnNHWS9RUE90U1RwZytkMzI4Rk1r?= =?utf-8?B?QUsxOFoxaFVSQnNNSitwMmRVby9sZkwvVDJleWljYm9rQnVNRGdKdUhpenUy?= =?utf-8?B?ZkYzRnNzQVIyV2NMWDdrVmpUdm9zdUNNNDFSMkt1Sy9GNWM2dlRvQU0zaUNo?= =?utf-8?B?WDlrOEhpTW9xRFBsRng5cWRZSWpVWnhRV0M0NFZtNkZxMlM5VEJwcUFaRzVR?= =?utf-8?B?ZDZuWGJBY1ZqRHNTNjk0WnNvamJrQWtpYXZ1VVUyOGtWZStsTnc0ZE5DZTQ4?= =?utf-8?B?MFpoSVNkc3FSWkdzc28rWFR3TFg0YnJwVDlvaTBUSnZKUWIyZ2JXd2ovODhx?= =?utf-8?B?YUZzSytySWV2SUwwTEtMc29XQk9VNUc1a3BycmtZOU1YUmdnZlR1d0w3d0VY?= =?utf-8?B?OGFKQkhpQmxKMmhkWFpDN1p5ZytpMDFBd204aGxoQnhTaVVwV3p4ZGZ5YlRY?= =?utf-8?B?NmN2RXZUT044eS9SVHQzaVBVbWljMXNkbktnbHBqTW0wMGZXbWpsZ0ZaOEg0?= =?utf-8?B?NGVTTzhGTHp1NGpoZG04Z09NbEYrMHJsejZoUURQR1gvRUJLVm5iT0ZEbHB0?= =?utf-8?B?U3dNYmxEZjRzK2RZam5pSnNZOGFINGh6c1BRc04yUUIweFBXTHVnYk9TeW13?= =?utf-8?B?ZlZuTHNCMStRek9WTjhROHZueHE5M3RlS0o3b3VuYzhneXIxYVhkdk9ZdDBJ?= =?utf-8?B?NmRibWNzQ1VDRXdIWUdlaDVHeGVnOFhWTTlOMUNmOGNsa0ZDV1h6TWxRYkt6?= =?utf-8?B?U0ptVkYvRkFqZG1keS8reXdVSjZxQ2haQW5YTG00WWd0TDlYcTJzanRydUUx?= =?utf-8?B?NXMwTkpOQ0xNTldqdC9ZMGhkcXJRNTI3V29uNG9waElYd3MwZ3dQeHErMi9h?= =?utf-8?Q?Dj+UxdSBtFpMoayvRQGqtVQQX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbe2301b-5c59-42b9-cce7-08db09e21359 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:37:59.6061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SeEM17TOsMTIMM0ousfCsmt1LLExf16Kotwef5emK+xXBuhQ2D6X51rfWX6OxnJnNTFDHuPycXqjgNcMMpsPkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9343 The "domain" in there has become meaningless; drop it. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1680,15 +1680,15 @@ bool shadow_hash_delete(struct domain *d return true; } -typedef int (*hash_domain_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); +typedef int (*hash_callback_t)(struct domain *d, mfn_t smfn, mfn_t other_mfn); #define HASH_CALLBACKS_CHECK(mask) \ BUILD_BUG_ON((mask) > (1U << ARRAY_SIZE(callbacks)) - 1) -static void hash_domain_foreach(struct domain *d, - unsigned int callback_mask, - const hash_domain_callback_t callbacks[], - mfn_t callback_mfn) +static void hash_foreach(struct domain *d, + unsigned int callback_mask, + const hash_callback_t callbacks[], + mfn_t callback_mfn) /* Walk the hash table looking at the types of the entries and * calling the appropriate callback function for each entry. * The mask determines which shadow types we call back for, and the array @@ -1826,7 +1826,7 @@ int sh_remove_write_access(struct domain unsigned long fault_addr) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_write_access_from_l1, 2), @@ -2011,7 +2011,7 @@ int sh_remove_write_access(struct domain else perfc_incr(shadow_writeable_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, then there's some non-pagetable * mapping -- ioreq page, grant mapping, &c. */ @@ -2039,7 +2039,7 @@ int sh_remove_all_mappings(struct domain struct page_info *page = mfn_to_page(gmfn); /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_fl1_32_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 2), [SH_type_l1_pae_shadow] = SHADOW_INTERNAL_NAME(sh_rm_mappings_from_l1, 3), @@ -2063,7 +2063,7 @@ int sh_remove_all_mappings(struct domain /* Brute-force search of all the shadows, by walking the hash */ perfc_incr(shadow_mappings_bf); HASH_CALLBACKS_CHECK(SHF_L1_ANY | SHF_FL1_ANY); - hash_domain_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); + hash_foreach(d, SHF_L1_ANY | SHF_FL1_ANY, callbacks, gmfn); /* If that didn't catch the mapping, something is very wrong */ if ( !sh_check_page_has_no_refs(page) ) @@ -2172,7 +2172,7 @@ void sh_remove_shadows(struct domain *d, /* Dispatch table for getting per-type functions: each level must * be called with the function to remove a lower-level shadow. */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #ifdef CONFIG_HVM [SH_type_l2_32_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 2), [SH_type_l2_pae_shadow] = SHADOW_INTERNAL_NAME(sh_remove_l1_shadow, 3), @@ -2221,9 +2221,9 @@ void sh_remove_shadows(struct domain *d, /* * Lower-level shadows need to be excised from upper-level shadows. This - * call to hash_domain_foreach() looks dangerous but is in fact OK: each - * call will remove at most one shadow, and terminate immediately when - * it does remove it, so we never walk the hash after doing a deletion. + * call to hash_foreach() looks dangerous but is in fact OK: each call + * will remove at most one shadow, and terminate immediately when it does + * remove it, so we never walk the hash after doing a deletion. */ #define DO_UNSHADOW(_type) do { \ t = (_type); \ @@ -2247,7 +2247,7 @@ void sh_remove_shadows(struct domain *d, (pg->shadow_flags & (1 << t)) ) \ { \ HASH_CALLBACKS_CHECK(SHF_page_type_mask); \ - hash_domain_foreach(d, masks[t], callbacks, smfn); \ + hash_foreach(d, masks[t], callbacks, smfn); \ } \ } while (0) @@ -3232,7 +3232,7 @@ int shadow_domctl(struct domain *d, void shadow_audit_tables(struct vcpu *v) { /* Dispatch table for getting per-type functions */ - static const hash_domain_callback_t callbacks[SH_type_unused] = { + static const hash_callback_t callbacks[SH_type_unused] = { #if SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) # ifdef CONFIG_HVM [SH_type_l1_32_shadow] = SHADOW_INTERNAL_NAME(sh_audit_l1_table, 2), @@ -3281,7 +3281,7 @@ void shadow_audit_tables(struct vcpu *v) HASH_CALLBACKS_CHECK(SHADOW_AUDIT & (SHADOW_AUDIT_ENTRIES | SHADOW_AUDIT_ENTRIES_FULL) ? SHF_page_type_mask : 0); - hash_domain_foreach(v->domain, mask, callbacks, INVALID_MFN); + hash_foreach(v->domain, mask, callbacks, INVALID_MFN); } #ifdef CONFIG_PV From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:40:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:40:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491860.761191 (Exim 4.92) (envelope-from ) id 1pPlcq-0000GJ-RR; Wed, 08 Feb 2023 14:40:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491860.761191; Wed, 08 Feb 2023 14:40:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlcq-0000GC-Oq; Wed, 08 Feb 2023 14:40:44 +0000 Received: by outflank-mailman (input) for mailman id 491860; Wed, 08 Feb 2023 14:40:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlco-0000Fx-Vz for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:40:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20628.outbound.protection.outlook.com [2a01:111:f400:7e1b::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f373742-a7be-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 15:40:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9343.eurprd04.prod.outlook.com (2603:10a6:102:2a7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.22; Wed, 8 Feb 2023 14:40:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:40:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f373742-a7be-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rg+DYWikV92fFanUpOwhcZxGlJq/ruCM5CLDg+JFbUDihhNYIG6kZNEu0LzaTo+eCDyOo7JJqsGrfLnX1by26/GEvS6K2su4M43iiRmRSoLE8qBIA9yaVRnHnkiUOYrlEv6X6DqbTyFYWK1wdBhBuzcNinQX3ZhC1dXopCByc8refTsi6a8G0s/Xtg/D4UB0hV8VeNiuT9yKIkY+KuT/lF+zNN2fpF3ZJh5aW2v2TAoC4HyYVuakmPQAwF8fiYKnoDCboaF66BSA3FBMRSenmDPtNF589fBxsT48N4lCM189v/02KWOwcsJDwKExOi+zdXdLkbg/nBjjLofxsvw+fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7TjoransTycJI2ib6c9uLYqwWZI2WbBm/YXVnWC/riQ=; b=YrVqfj3kxbWLMnr5jBfyTa/EhciqLXcKUdRByEiYpDexHKm1ZLAuR37OXPiR1dP0KXqxsU3QRzfJk5u9WLuyGLQMGrAxMQ5cEEBqraBO0ArDsmAUlYPBS2VwWcFuQsD5aLDyE1IMdSpC2zGjjSelCX0mcdsiy2a3RbpZ0souzFa10k7mtrGfM2zhG8y0abTuQIuZkop87su7yiqVmzJmkb6ZEtE+r4nzlVpIdTldlZzqGlxO0poVYbcs31e1Spn/7Ccq4Iu2lbsBNAEoGyr8OcFBd+8LQrUQGaXi4qIo1zeqjLv2IGFweuBgfoWNJr+4h8MiIQFABnesn1IFvq41Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7TjoransTycJI2ib6c9uLYqwWZI2WbBm/YXVnWC/riQ=; b=0FpbdIv26A9IGOnz1qaRhQ/T3XvsltXaLoz4e3KjD75ORO3dNqmfzQZaCIkxQzK4LBgpk9yW0ZHZ7j/4A1NqIn9vOJKlAmO11l3c6Oiq5Sh06TXqc6dR+qmHuG3QY/UQvGvUBVkjD3nHp04C7CkQslrwXoBoZHfGuf+XJ4T5rAa+5ZbXaYVxcKbHLTqOzP5rZf31sKt+t163efuRlpNrCFHvCdLukOYiG2Cd7hjkvQ0jgP3FvcBdqxekrAs7idjRUcN5DU9N60aIPBr9a9QlmaRdtaAhhveyUaI7Z1+qSfv+tAoxu67lV0tLkgyptHXR6h5HD8KQ1TZl9tfK/Zxc6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <96b0ebc7-4cd6-9053-06a6-78dfc0666b8a@suse.com> Date: Wed, 8 Feb 2023 15:40:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap From: Jan Beulich Subject: [PATCH] x86/p2m: tighten old-MFN check in p2m_add_page() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: 329425c6-94a8-4030-a2d6-08db09e27267 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1lMLreEldrL65iOZLfh2qWemUfBqXSbSoue2HJr1BfIwkLfb6lp4YUYxflulXqcD6vpPpvHevMr2puasB8zJ7y0BS2qkJiZyewIDjgmyg/LNYUCdkcVWpXhc15f2F9EFQy0wuHpl83YcV2Btgxju1zyznBkOehHq0yAUA6lfFeQEC2C9BfkQ/QyQifUqZ/sDm7O1elT43cOMopoMbKFUwYXo+t47UxhthmhFd5H/GwAStIUT4J+0IBKgLPIfotJmtL/0Ke7e0kRuUcpZiYxLn7YddDC7ijdIgsyMCO8iS2b3Km/Z7qSWQhdo3V5vYzPmVuvJkn3ki5mdBZqMODEfm0GHVNxthsKmohm6QlNrWaxBiS6uw9JpM00hXx7Z802EAEfhLhtSadKkKPxgfVFqA6805CP0LrV1Ci+HlXhPe5EIBN122mzu6+bBcAUeKMJjtqOIsn6hk3mdGDHcmj/7kihYhBGK8kmzQxggzfvdsYSMsuAgSfwuK9Rhax95z8tfmyMRWSIJnZw99wrk/u93XtuR6k+DURHah2BONgfqzVWb0wx0sgNLe/e5EGD8FvXPgtMJy0nF4oYfPMsIQJufSlsH/SylpKn+dUbyblMEHbldVl6/Mo/8H15UuEOYCowGFPJaHTM2xjvdKldW4rRhbRZTdRiUPWZxSLo1zFiaBij4A5RbMX2NykzfkvyKrw2VI7QcVnDP1UlIKG7Dme3rWUx7qqlxhdp/NIsGBLNU1Do= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199018)(31686004)(83380400001)(6486002)(36756003)(5660300002)(2906002)(26005)(186003)(31696002)(478600001)(6506007)(6512007)(41300700001)(54906003)(86362001)(38100700002)(2616005)(316002)(66946007)(4326008)(6916009)(66556008)(8676002)(8936002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUIzRFNlLytndExlYnpPWkoycGsySTBUbGpNNTJuNmpBQkVTdGFnTTdHemNK?= =?utf-8?B?Z3ZKQllrdm9yc2VueERucjJTdFV0Nkpod3BZU2FOUEN6bk1wb2xDV3VpczZD?= =?utf-8?B?TmFZKy9jUEZhWmdyME50S1hoUFdjaVZhMHJHTnRGUDdaMm5JZzJlK0JDYlRS?= =?utf-8?B?aWtnU3R5ZTE0UmFZVFFyTHpyZzNsckc1WXhUWi9uTTU4UVN2dmg5QmJxUGF0?= =?utf-8?B?VUF2YzFaRVEzSzhDcGI5Q1U1cGtneHdwMTk3b1d1OUFaeTRObXl6cVNPcFE3?= =?utf-8?B?VFZIR2srMjM3dnFYL1cxdUYwS1F0a1FzS29FRmtwSzRhQys4Rzg0aXQ3Wnhi?= =?utf-8?B?bDdZVVMyWlRVUDcwaHAxNjZrakVhNm9SMG1uTjBVNm1RYTZjUjN3SWdTVTRq?= =?utf-8?B?T04vQWZFbWl4SjVXK0FVd0dabmpnakxXT2VWT090cVBUUk5vOHcrRytiWk45?= =?utf-8?B?NlJZOEZqRmQwczJqZUxPVjgrL1lkak0wZ3hlcFZHQ2dNclhoUU9vY3crRnRK?= =?utf-8?B?MXRrSDVZTTZaL2tTN25vdzBqSDJlWWtxSFFSLy8ydFhhVjg2aUxpOGpQU3dk?= =?utf-8?B?Mk1pSkVYRDRBKytldlpXc2hMVG1JelhTRURGbHNPVlRGYXkrT0Zyc3plMmJI?= =?utf-8?B?R1N0SnU2LzhaWFpzZVQ3WjUyR3NjRlVISTBiSzlOR1RJeUpQMTlRU29jODhO?= =?utf-8?B?blpSNmxjbG91cFNyYTNFY0E1NUFZTW9IWlQrVUgzc0J0UFNhb3hYWkZGU0t4?= =?utf-8?B?aW9WWE5iVGl6N2VUWjgyZ01qT0dGcCszUDNjc2JwelpZcTJpenlLeEViaVQr?= =?utf-8?B?TmNnbVIyVXFLeFFNR0toU0t3V2FacXdOSUpyZWJ0V3hGakJJT2FmLzNkMkRE?= =?utf-8?B?UmdpQmJCaVNOdHVnVmo5OWY5cEJlZWlIRTAzM3JLS2x6dGdIRXpTaFNoUUhr?= =?utf-8?B?Z0loelZzb0E3MGROUU5kWllITlhrLzhpeEhDMnBPOFkxVmJEQmtDTTZmVzJx?= =?utf-8?B?MnpuMDBDQzV1a2hjMVV5cXNMa2krZ2QyV01KRnNtVy9HeVk5MTdnYlVzYzI2?= =?utf-8?B?V0Z0ZHd1SWhrcjlnclBlYzdITWd2MndDaXA3cTFZSWxpSDZUWXNPVGpmbXho?= =?utf-8?B?MXlpOXNoMFhLSGgxTnRzNnpyd1grdlQ2RjJMSXdnMi9DOTVrSnc5TkF5bXF0?= =?utf-8?B?QzJ5TGRqQ29sRnJZZDNWMUpsWVpEYm9BMGkwRnE2NDBUUUlhMS9STENSRGVX?= =?utf-8?B?dE9temd5TkR1S3lIS1hBZ0h0UlVqeWpXNkh2TnByM3lCMDBtYXA1dHM4aEZ2?= =?utf-8?B?SGdLRHE4UElyNEttOWRXT3p6NGF5ZXk5eURSQUh1NDBqVXRNUGlWTWJURGx6?= =?utf-8?B?Y2FTZ0ZvcGl6ck1hSHRXQncvRG9Ud3U3N1BaK1hERUlrSThvTzlqaDdkdXRz?= =?utf-8?B?QU9HTG5WVXRjMnlCWGJWZnliNWc0bHZ2a2paMjJ6RHkzZEJGbUxsY2duTXdj?= =?utf-8?B?OHRpajRRMmg1bklZSCtndS8vWXhGaWNZd1h5ZU1QUEQ4OHhsRFlVMllVK2Vn?= =?utf-8?B?VHE2VFRxaE4wdWFvdWFkUzFzUFkrQ3JQTjRLVmc0Y0E3b1VsazJFbFNidmZu?= =?utf-8?B?L203aHJkMisybk5qRTdCQWZtUnI5cG9iWG54ZnN1dFovMjlwMlgwZW9aVVhn?= =?utf-8?B?Vi8rOHd5Q2xvOGZtRU5wN2J1STdVTjFsaTJLbWxnWnRxVlJXelVyaGljWU5Q?= =?utf-8?B?akJLeXFWa2FobGJlMXdMdHFnckExK2M0YkZubGhPNjlPVVMyNXpNcURNNkdU?= =?utf-8?B?T3lOT0txZkNBbXZpS3JKSVpDY1lld3Y5Ty9ZeFYyRHNYMzBvSHlpYXY4R1U3?= =?utf-8?B?dG1uWVFEYjlLVTZpTWlZY1JnanlDSHQ5UWlwZGUwZWd1b1paTGdvN1NwUlJS?= =?utf-8?B?T01OMHpHT0FiY2dvR1RSVURUM0o0YURBbGVZMGRrSmluK1FmL3p0VlVOZ3Az?= =?utf-8?B?V01oYmhwWndxUDVKckRzMGhzdnRoNE11YzVuY3ovODdNU3lRajZQdVorQm0x?= =?utf-8?B?MFNrSXdiSlhBZjZBcmpqcUxJTUJ6TDdkZHBmakNHZldoSXFaa2JiNkJ2Q3Bh?= =?utf-8?Q?xVuf9Wgs2R31KZfEPaM3iiMCC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 329425c6-94a8-4030-a2d6-08db09e27267 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:40:39.1272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oblWzcvq5dAlDDDnWgZtGOFvQ6iaP/5c85oKwstmwc1/2Os4faazSHFwnNNipUqXIY93wPRJXPgX9pNWuOTqyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9343 Just ahead of the logic in question we've translated the subject MFN to a valid original GFN, in order to then translate that GFN back to an MFN. Restricting the call to p2m_remove_page() to the case where these two MFNs match is too weak. Instead refuse the operation altogether when there's a mismatch (which likely indicates a bug elsewhere in Xen). Signed-off-by: Jan Beulich --- If we were certain that a mismatch indicates a bug elsewhere, we might want to consider crashing the domain instead, to limit damage as well as to make sure the issue is actually noticed. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -714,13 +714,19 @@ p2m_add_page(struct domain *d, gfn_t gfn mfn_x(mfn_add(mfn, i)), gfn_x(ogfn), gfn_x(gfn_add(gfn, i))); omfn = p2m->get_entry(p2m, ogfn, &ot, &a, 0, NULL, NULL); + if ( !mfn_eq(omfn, mfn_add(mfn, i)) ) + { + P2M_DEBUG("old gfn %#lx -> mfn %#lx != mfn %#lx\n", + gfn_x(ogfn), mfn_x(omfn), mfn_x(mfn) + i); + rc = -EXDEV; + goto out; + } if ( p2m_is_ram(ot) && !p2m_is_paged(ot) ) { ASSERT(mfn_valid(omfn)); P2M_DEBUG("old gfn=%#lx -> mfn %#lx\n", gfn_x(ogfn) , mfn_x(omfn)); - if ( mfn_eq(omfn, mfn_add(mfn, i)) && - (rc = p2m_remove_entry(p2m, ogfn, omfn, 0)) ) + if ( (rc = p2m_remove_entry(p2m, ogfn, omfn, 0)) ) goto out; } } From xen-devel-bounces@lists.xenproject.org Wed Feb 08 14:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 14:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491868.761202 (Exim 4.92) (envelope-from ) id 1pPlhC-00011Q-CL; Wed, 08 Feb 2023 14:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491868.761202; Wed, 08 Feb 2023 14:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlhC-00011J-9P; Wed, 08 Feb 2023 14:45:14 +0000 Received: by outflank-mailman (input) for mailman id 491868; Wed, 08 Feb 2023 14:45:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPlac-0005uV-Hw for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 14:38:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0631.outbound.protection.outlook.com [2a01:111:f400:fe1f::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e991945-a7be-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 15:38:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7456.eurprd04.prod.outlook.com (2603:10a6:800:1ac::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 14:38:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Wed, 8 Feb 2023 14:38:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e991945-a7be-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A2DhN7QHe7zq7Zsg7u1Bi+z6xTHyas2R9c86qcKo2D5oJFooHYLIvwzMjOO4EtT7h5uD9fvabhnm1fMOw4ZyTRG5FxzU5JbZWrwTwZ0kibQUy8gcSq62CUS9wI07ppulPjy2aqgRimUd6k1l0uu+SNTsCavRwXAVlzNN6tVJtwsjD6J3wMOeeh6uE9qpi6vqMua6d0Jq8ol+XXycZ79e/ntj1nM4amnNS14KStL8fPAfAIGgT9Rlb2euAmMtn7svDO88SQW07cC4yWRSoii+ED25UbPcTzJTRX/h0PHuzmOWdXiI5H2vROzTZXbJH0phqZCXFKM97djYFLYBTFTFew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XKJmP6oShTkiMe9LQzsbVOzIHfIJVktiMOexocp7MYs=; b=fy2S+gTW/THUSoE7KvVg/sG/JYzC2AGNiW676RhDe4x39cFzCJXXhzGefBK7A+12rWY1OzhLSr+Lw7t5mCR0PkF4TihiePUSiEKC3DfAyNgz4hi15GRDz7VPg1/vEEoaZo2xG01BPu45me3o6ymoGynWaxN3hVhA3krDkvhwIY9jpYrjeaWO/hx7l9udNE72zT9D2Qe8fjf454nyBUWUmJ84YyxTlSmOLngCddVeZ8L7nRG86wax6IDUDoOcNYQrYyj4lva8mmUelZS3suzvgM4Haj23n6n8CLrGjsFEOcep7kzzdOLR7izohloP0IMecCL0yqgOrJM6wGq4KH6Y2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XKJmP6oShTkiMe9LQzsbVOzIHfIJVktiMOexocp7MYs=; b=EWolOIufNmtQWstOjAkal5lY6bl5mOzqequ5Bmm29NL+UXHInuhMuHh4fMj8HJz+FhLptwNNTj5NLQOTS6suNDEsqrDx3TvEAgXwX4i9qPoZ+A1IyE5wwE9IMugII7Ed3w+JY0Ao/5ltA9fOyWFP0CnoVogfdSob9SxJdvlvPyV19aHz6YihtHj65FeZr+EwRsr758UoIieEjf1gMYYWIEaIfbplERWPNmQikYcutEwt53zGqWRiPniztLMHfHSup8yHCkqbqi5/GO0defzIgO1hkI8uI+jnsVhFBXmDw81KFRXNhdO9iJ5mo1XTOw2xfyaBJeHPlZ4beq9MitOrvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7d2dd28a-a821-e906-6245-ab26e5518706@suse.com> Date: Wed, 8 Feb 2023 15:38:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH v3 4/4] x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7456:EE_ X-MS-Office365-Filtering-Correlation-Id: 071df123-240e-4793-6b2a-08db09e220df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fwBNcL90U63MLLRc4y8L2x+95daJtqeuWtw/o4hnROkjouBOStc9Y96ehp6cofPc0BvKrhtBpJa9h9Htl6F4fMQvIt0xdjlQLdSOq3Dc4ODfsIu2yjyZQrfNuF66y76HtdWqaHNThuqbf6aZz5Bo8sljj4jQCV9oKwXWtH0OkuIsqKTZMY6LNztKdgrHwPbo/ezK/tJMPBwn4W8dmil4iUEWTISGfAFbErxB+AHA38rEeEWgNxFd8QCo3w/lI9llFAUV3yCDkuy9jSquXymmNGj6sOvsWH0ge/PzIIPJXQ5O3ekq/E0EhRhvD/9jUqqwfxiNXbwU4xTqUskHyXnbDkNXWAViXWB/PLVlwF1DfGMzYfXyOK1c7GS4eJh5AwneEO8dMujdEbnQZnGzKFv0Xmne85ZoTswBiBxbniF/IBXBOw5CoEJCj45gGouDx84SVCGC5ThgHN3jzOLsO4aEXWFzvZBT9s4NEWAb85lUqZxAM4l5YjX6BUx+mig1gt/zDebBUoVm0ABR/pGDcbEQgWXB/teEEwdkuXmFiXy8hIqHzJdyxwTNwL/Db2OjnM5z0vdY0qJpdDFoCFsXB739vH0Xo1rhTAv5oHxHIOc2hOshINKhmkAPRSaExnrz+MlTrAmDzx/y8We+gvEN37UUFjrJMr2iZ24y1z0+u/jm0RkGiwaWZOjtTjwczb910cLG3uykrAxAdgsPZE7FNuEk9zSDsmVZreNfvffFWocISFc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39850400004)(346002)(136003)(376002)(396003)(366004)(451199018)(6506007)(86362001)(5660300002)(26005)(6512007)(31686004)(186003)(66556008)(8936002)(6666004)(2906002)(66946007)(6916009)(66476007)(4326008)(8676002)(38100700002)(41300700001)(316002)(2616005)(31696002)(478600001)(6486002)(54906003)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFU3dkdPMUhMd3dHS1FDYjNFdDRUSThjZEdRWUk0Uk5FVDhjdG9iWWQxaDdV?= =?utf-8?B?ZEpMd1AzZTdsUXF1NHdQTkY0WkFWcVlUUnBzUVFjK0ljUHY4bG1lWUZ2dWlC?= =?utf-8?B?Nms4dnFRQmtDYWpJRmhNSDNVc2VzQkpPRFBjVjJILzdCcGZmVVJFaWlYV2ZY?= =?utf-8?B?QjN6cmNtNWNneFYrcVVmaUovdmFHYUIyT3lrVmQvUW02aDJuOVNlemV0RlJJ?= =?utf-8?B?amZCdko0V1hrSkZFaGpyam1WcVBuUjNyMEQ4bmtzM3hSQ240TWw3UmZZSVJ2?= =?utf-8?B?RW0rMllIK3AzN2c1aHNSekx5UlpzN29uN0hhN0ZwaEFVd0JzNTRDdE0zQVNZ?= =?utf-8?B?bEk5YXg4eFhpYU1Nd3pWWjBhNzVSUU93dG5jSkdqd3ZtSUtBZlpxb0FDVjFW?= =?utf-8?B?Q1V6VmpZc2t1NEUzdDlLTk54czRIcEVFY29HQ1krc3MxUzNReTg2TnhCdHNa?= =?utf-8?B?U0RWMU95a2w4U05EUWRWNUVJblVVdDNwNk1vSXFOVVhnT0ZoNE5ka0JubDN2?= =?utf-8?B?N3JRTndObUU0cXJHNUVQRkNtVTBWOXcrNDBjdWcyVlFoVDFyeTlNclN0SW0v?= =?utf-8?B?QlVHZVhvR1ROK0p6UWRMOXlmMFo1VURQT2xLcWszc1VzVkljZWJLdlJoZDZE?= =?utf-8?B?elBsS2VoTEhUamxXMFh6QUV4SE5tSjNOazhzZmhkMFVtUXZEcm8yWFk1cUVN?= =?utf-8?B?U1JmTURHZk8xRFhLWitxbnlNN0pCaWk4b1hPUGFuL1ljRnR0S21vWm95VERC?= =?utf-8?B?dGVvOUxuc1hlWSsyNnUwQ1YySVhXd1JrZ21oUFZhcTJwYlMzalZDSU5CMjVG?= =?utf-8?B?MTJ6M1g5OS9sbnllMERLdGYwTk9USVVqVHlpQ3NpejYvRjJGVHVJTzBHV3p1?= =?utf-8?B?d2lnT3ArVmNRMmtvMFpQZGcvdHhxTDZrYXI4MllxVzdwSjF5MTBtWm1iMFNO?= =?utf-8?B?elBqS1JDbFFBaXBGZnI2M0ZaM1NuSWcxMXJqVVQvUEZjd0hJQ2x6UUJRRTJj?= =?utf-8?B?Q2FLU1RIT0lKcG9MMG1mVzNNYkhDUnZTYlNJS3VXalRrUFVTZHpIZE5hYkFh?= =?utf-8?B?MDRWdVNGL1hWYUNONTBYUStkNzRMblA2NlZscnc1Q0FlS2ptTXc4TGdwSGRZ?= =?utf-8?B?MStZNE1SaDd6L3Bhek1EWDBVTFovUml0eVRTN01OSjZCVjlTcnNJUUx4Y3VL?= =?utf-8?B?NTNQWEdGQWN0K1NxWlBha3ZqVUw4dklia3VQRE9QRnc2aE00NGhQbEUzNzRW?= =?utf-8?B?VXJYN3hTRnoyMGdLV1IxNDd6QWNTRXFyVXJvRWR1UHhXNHZESm5UenZiZmZZ?= =?utf-8?B?ZkRMZkNlSElBcE5XbE5LSzh2aWgvOGRmRVBucWtWNjBmTys4dkFRMnZvZlJM?= =?utf-8?B?KzcwNXJDZkpiTGFjZktvUnh3c0tya28rekNQRkUvSjZ5bE5wNWVMRFppSC9y?= =?utf-8?B?WTVwSVYxdnJlYzIwdGIxOXE2aXdXTjNadlR4dmlmWEdoaVd2TDl6NnRobk5S?= =?utf-8?B?KytIanlTTkFlNm9aYStjdVo4MmwzVlhFT2xqT05HcWNpbnRYOXNpVnJ1YW1S?= =?utf-8?B?WFo1K09oMDdtd3VJWFpvVE1yRlp2L1BFWks3Y1gzSzd3bmZaT2tMVUVIOEMw?= =?utf-8?B?NHZ5Q2hRVWZsWEdLY1ZYMUVIYnJGa0NlYW0rRXU1M05TajJIMFF5Z1lYc2tm?= =?utf-8?B?Mi95MEtVZ3kvbXZmNEJ5cjdIN0RneWVjb0lxVmkyRGQxTDRZSWhkOGE5NFhx?= =?utf-8?B?S2dkQ2JTZ3pqRVZlZTlXa3VJT3BDQ1hqL0QxWThTQ0dWVUNjTzJUemh0QjNU?= =?utf-8?B?S1dNSFdjR2RrL0hSdnZvQ1VlZDJKdkVMVlRHUE5rQlQyS1ltbENreUFhVG5I?= =?utf-8?B?RXU0SDJBa1krTnorUkU2OE80elUwQXZydGY4QS9NblJJbml3VGYyNlNiMDlP?= =?utf-8?B?aTFVZ1BvNnpoVmRIV09pOUN5S1pPRVMvdVJidWpYazNHWW93ekZoSG9hZUdq?= =?utf-8?B?djNzTndyOGJhZnFTRm9Ydk84K3prVUhlRVNBUTJ6T1dId2NTLzViTG1mYm95?= =?utf-8?B?RWFqY2JTeStGTERCdVFkWGgrUVk5MjB1UFlUSG5YK2RISHg0YlZLSi8xMnlC?= =?utf-8?Q?TukDCTyClzRyt2rv8cCYKw62m?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 071df123-240e-4793-6b2a-08db09e220df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 14:38:22.3078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Zc58En/NsA12WA3fRrPtf+x/g2lfS7FHp8d0dCg/zUpemhuq8kzu8LKINKEu8Q33rUuTXFVGrPQwv2zrOHKNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7456 First of all move the almost loop-invariant condition out of the loop; transform it into an altered loop boundary, noting that the updating of _gl2p is relevant only at one use site, and then also only inside the _code blob it provides. Then drop the shadow_mode_external() part of the condition as being redundant with the is_pv_32bit_domain() check. Further, since the new local variable wants to be "unsigned int", convert the loop induction variable accordingly. Finally also adjust formatting as most code needs touching anyway. Signed-off-by: Jan Beulich --- v3: Drop shadow_mode_external(). Switch back from using trailing underscores. Convert style to be fully conformant. v2: New. --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -861,23 +861,22 @@ do { /* 64-bit l2: touch all entries except for PAE compat guests. */ #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code) \ do { \ - int _i; \ - int _xen = !shadow_mode_external(_dom); \ + unsigned int _i, _end = SHADOW_L2_PAGETABLE_ENTRIES; \ shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ - for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ + if ( is_pv_32bit_domain(_dom) /* implies !shadow_mode_external(_dom) */ && \ + mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ + _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ + for ( _i = 0; _i < _end; ++_i ) \ { \ - if ( (!(_xen)) \ - || !is_pv_32bit_domain(_dom) \ - || mfn_to_page(_sl2mfn)->u.sh.type == SH_type_l2_64_shadow \ - || (_i < COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom)) ) \ + (_sl2e) = _sp + _i; \ + if ( shadow_l2e_get_flags(*(_sl2e)) & _PAGE_PRESENT ) \ { \ - (_sl2e) = _sp + _i; \ - if ( shadow_l2e_get_flags(*(_sl2e)) & _PAGE_PRESENT ) \ - {_code} \ - if ( _done ) break; \ - increment_ptr_to_guest_entry(_gl2p); \ + _code; \ } \ + if ( _done ) \ + break; \ + increment_ptr_to_guest_entry(_gl2p); \ } \ unmap_domain_page(_sp); \ } while (0) From xen-devel-bounces@lists.xenproject.org Wed Feb 08 15:11:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 15:11:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491874.761213 (Exim 4.92) (envelope-from ) id 1pPm5x-0004bm-BA; Wed, 08 Feb 2023 15:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491874.761213; Wed, 08 Feb 2023 15:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPm5x-0004bf-8S; Wed, 08 Feb 2023 15:10:49 +0000 Received: by outflank-mailman (input) for mailman id 491874; Wed, 08 Feb 2023 15:10:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPm5v-0004bW-CF for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 15:10:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0a1de91-a7c2-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 16:10:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0a1de91-a7c2-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675869043; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gL91Uy1XfA0sijNXu9PWt94U4qjtLgeeQ+pIBM3hSGc=; b=SJa/IdDFAOEh4RqfGhWbWexD4qWEeB6wLZZfrVMDxqsEaFEWZk+/q//J fZZ2BeGcZ7ixavqao5L++5LK3KAKO94ku2dBXdFYXUPTzXJHi4LydZKAJ TUs+hnvzl+4H9fQ6FcX6ZxDruXG42HtRsLZ1kERh9660C61ZIFjzfqVpY w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95604727 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:h+jw7q4Dhfwp4Kqn5yx9xwxRtBXHchMFZxGqfqrLsTDasY5as4F+v mcYXTrXaK2LYGKje4hxPIy+o0lUsMfXnIVlSwporS8yHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoT7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my dI8cDkIKSy4uM2J7q7hSdlQrO0fM5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxvG/ j6ZpTuR7hcyOMSH9TCvqyOQvtDJwTP2UogyEIHn36s/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIntaUo/VanZsX8VRa/5nWDu3Y0WdVKFPYhwBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pEXFLdylYP3ZCFFZbpYC5++nfky4jUP5fPorth9iyJQrP7 A+ksHI9t4k5pPIUgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K3741s5CHx7ZiHCgUpLj2WZVawXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ 8jGLpfwUyhHU/s5pNZTewv7+eVzrszZ7TqMLa0XMjz9iebODJJrYedt3KSyghARs/rf/VS9H yd3PMqW0RRPONASkQGOmbP/2WsidCBhbbiv8pw/SwJ2ClY+cI3XI6OLkOxJlk0Mt/g9q9okC VnkCxQGlAKg2y2vxMfjQikLVY4DlK1X9RoTVRHA937zs5T/Se5DNJsiSqY= IronPort-HdrOrdr: A9a23:sxcuL6ovZLagQtWXGptiuWIaV5rdeYIsimQD101hICG9Evb0qy lhppQmPH7P+VAssRQb8+xoV5PufZqxz/BICMwqTNWftWrdyQyVxeNZnOjfKlTbckWTygce79 YET0EXMrbN5DNB/KLHCWeDcurJwLO8gd+VbeW19QYScem9AZsQnjuQCWygYz1LrBEtP+tBKH IFjPA32gZJfx4sH7yGL0hAZcfvjfvRmqnrZBYXbiRXlDVn3VuTmcXH+wHz5GZlbw9y X-IronPort-AV: E=Sophos;i="5.97,281,1669093200"; d="scan'208";a="95604727" Date: Wed, 8 Feb 2023 15:10:18 +0000 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. Message-ID: References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-6-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Feb 08, 2023 at 08:48:33AM +0100, Juergen Gross wrote: > On 20.01.23 20:44, Anthony PERARD wrote: > > LDLIBS is usually only the library flags (that is the `-l` flags), as > > proposed in GNU make manual, while LDFLAGS would be extra flags such > > as `-L`. > > > > Rework the make macro $(xenlibs-ldlibs, ) to only provide the library > > flags. $(xenlibs-ldflags, ) already only provide the extra flags like > > the -rpath-link flags. > > > > Also fix "test_%" recipe in libs/light as "libxenlight.so" in > > $(LDLIBS_libxenlight) is been replaced by "-lxenlight". Instead of > > just changing the filter, we will start using the $(xenlibs-*,) macro. > > For LDFLAGS, we only needs the one for libxenlight, as the one for > > nit: s/needs/need/ > > > toolcore and toollog are already in $(LDFLAGS), they are dependencies > > to build libxenlight.so. > > I don't like this very much. toolcore and toollog are used directly by > the test_% programs, so I don't think we should rely on libxenlight > depending on them. Ok, I can add them back, it isn't much of an issue to have duplicated flags on the command line. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 08 15:20:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 15:20:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491882.761225 (Exim 4.92) (envelope-from ) id 1pPmFO-0006Cz-88; Wed, 08 Feb 2023 15:20:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491882.761225; Wed, 08 Feb 2023 15:20:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmFO-0006Cs-58; Wed, 08 Feb 2023 15:20:34 +0000 Received: by outflank-mailman (input) for mailman id 491882; Wed, 08 Feb 2023 15:20:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmFN-0006Cm-23 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 15:20:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1fdf9b94-a7c4-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 16:20:31 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8E7DA1FE93; Wed, 8 Feb 2023 15:20:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 701B513425; Wed, 8 Feb 2023 15:20:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hO6lGb6942M4PQAAMHmgww (envelope-from ); Wed, 08 Feb 2023 15:20:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fdf9b94-a7c4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675869630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tNudGKwfWz2Qi9qUZWYX4r6w5ISOHAiaiJecluurz8Q=; b=Q7SvzmiLbf/F+8FfSiba+wJUWsDhLkRsb1/iuTDE5ApMh+1QPKoMJnnoJw3HfeeH84I+Up uqBGezGdkp/sO16kMNua9mDdzKJslfjz52FA8Pu6Y/0SDjg/MfeHGq/1az7auPGIscDnIZ mYFwxWG5NpFfcpfNcyJ8VZ4GFZv4OSM= Message-ID: <6a141dab-aef8-960d-269d-23f8000a257d@suse.com> Date: Wed, 8 Feb 2023 16:20:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-6-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3XYzH0xAdv2HzJAOc6ANiMLK" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3XYzH0xAdv2HzJAOc6ANiMLK Content-Type: multipart/mixed; boundary="------------LCfy9ydGsVF7jbzK000cXc0t"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: <6a141dab-aef8-960d-269d-23f8000a257d@suse.com> Subject: Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. References: <20230120194431.55922-1-anthony.perard@citrix.com> <20230120194431.55922-6-anthony.perard@citrix.com> In-Reply-To: --------------LCfy9ydGsVF7jbzK000cXc0t Content-Type: multipart/mixed; boundary="------------NGeQ0T0Ln0Bk0r7ebsQeeLuP" --------------NGeQ0T0Ln0Bk0r7ebsQeeLuP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDIuMjMgMTY6MTAsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBXZWQsIEZl YiAwOCwgMjAyMyBhdCAwODo0ODozM0FNICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4gT24gMjAuMDEuMjMgMjA6NDQsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4+IExETElC UyBpcyB1c3VhbGx5IG9ubHkgdGhlIGxpYnJhcnkgZmxhZ3MgKHRoYXQgaXMgdGhlIGAtbGAg ZmxhZ3MpLCBhcw0KPj4+IHByb3Bvc2VkIGluIEdOVSBtYWtlIG1hbnVhbCwgd2hpbGUgTERG TEFHUyB3b3VsZCBiZSBleHRyYSBmbGFncyBzdWNoDQo+Pj4gYXMgYC1MYC4NCj4+Pg0KPj4+ IFJld29yayB0aGUgbWFrZSBtYWNybyAkKHhlbmxpYnMtbGRsaWJzLCApIHRvIG9ubHkgcHJv dmlkZSB0aGUgbGlicmFyeQ0KPj4+IGZsYWdzLiAkKHhlbmxpYnMtbGRmbGFncywgKSBhbHJl YWR5IG9ubHkgcHJvdmlkZSB0aGUgZXh0cmEgZmxhZ3MgbGlrZQ0KPj4+IHRoZSAtcnBhdGgt bGluayBmbGFncy4NCj4+Pg0KPj4+IEFsc28gZml4ICJ0ZXN0XyUiIHJlY2lwZSBpbiBsaWJz L2xpZ2h0IGFzICJsaWJ4ZW5saWdodC5zbyIgaW4NCj4+PiAkKExETElCU19saWJ4ZW5saWdo dCkgaXMgYmVlbiByZXBsYWNlZCBieSAiLWx4ZW5saWdodCIuIEluc3RlYWQgb2YNCj4+PiBq dXN0IGNoYW5naW5nIHRoZSBmaWx0ZXIsIHdlIHdpbGwgc3RhcnQgdXNpbmcgdGhlICQoeGVu bGlicy0qLCkgbWFjcm8uDQo+Pj4gRm9yIExERkxBR1MsIHdlIG9ubHkgbmVlZHMgdGhlIG9u ZSBmb3IgbGlieGVubGlnaHQsIGFzIHRoZSBvbmUgZm9yDQo+Pg0KPj4gbml0OiBzL25lZWRz L25lZWQvDQo+Pg0KPj4+IHRvb2xjb3JlIGFuZCB0b29sbG9nIGFyZSBhbHJlYWR5IGluICQo TERGTEFHUyksIHRoZXkgYXJlIGRlcGVuZGVuY2llcw0KPj4+IHRvIGJ1aWxkIGxpYnhlbmxp Z2h0LnNvLg0KPj4NCj4+IEkgZG9uJ3QgbGlrZSB0aGlzIHZlcnkgbXVjaC4gdG9vbGNvcmUg YW5kIHRvb2xsb2cgYXJlIHVzZWQgZGlyZWN0bHkgYnkNCj4+IHRoZSB0ZXN0XyUgcHJvZ3Jh bXMsIHNvIEkgZG9uJ3QgdGhpbmsgd2Ugc2hvdWxkIHJlbHkgb24gbGlieGVubGlnaHQNCj4+ IGRlcGVuZGluZyBvbiB0aGVtLg0KPiANCj4gT2ssIEkgY2FuIGFkZCB0aGVtIGJhY2ssIGl0 IGlzbid0IG11Y2ggb2YgYW4gaXNzdWUgdG8gaGF2ZSBkdXBsaWNhdGVkDQo+IGZsYWdzIG9u IHRoZSBjb21tYW5kIGxpbmUuDQoNCkluIHRoYXQgY2FzZSB5b3UgY2FuIGFkZCBteQ0KDQpS ZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJn ZW4NCg0K --------------NGeQ0T0Ln0Bk0r7ebsQeeLuP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------NGeQ0T0Ln0Bk0r7ebsQeeLuP-- --------------LCfy9ydGsVF7jbzK000cXc0t-- --------------3XYzH0xAdv2HzJAOc6ANiMLK Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPjvb4FAwAAAAAACgkQsN6d1ii/Ey/c NggAnsThHSKs11L8Gg/65yMm/QFoXIGuJVVYtrqerdkhy+Pd8WdGrGbyUS9YMFCdMMAZPjQhZM5i zihP9uP6JX1sn83JFlP4dOAU3onPEDDc7v2A92ZbQiYf8xIFlTvaIBG+6puIw226Buev7Aim0R36 c6yyNp3vOJ4zaw22h1HuW5Tb07RcFbkFphXvUcrFkMpQ/lPw8HncRk3vTBMi1y5LeRR7+VYzfKps pcCjjEwJKNYNvMrssWibpuN5NoV2pNs+HCFiL8bCdpHRFs9GUOa7c41NXheL65jRlpaHn3AQfngO rLzXDgISvBT/tdXJUjbIWt3BBpHrUEQiJxz7PERrig== =231C -----END PGP SIGNATURE----- --------------3XYzH0xAdv2HzJAOc6ANiMLK-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 15:40:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 15:40:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491890.761235 (Exim 4.92) (envelope-from ) id 1pPmYE-00088N-2U; Wed, 08 Feb 2023 15:40:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491890.761235; Wed, 08 Feb 2023 15:40:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmYD-000887-Vm; Wed, 08 Feb 2023 15:40:01 +0000 Received: by outflank-mailman (input) for mailman id 491890; Wed, 08 Feb 2023 15:40:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmYC-00087y-KX for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 15:40:00 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d720f501-a7c6-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 16:39:57 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id l21-20020a05600c1d1500b003dfe462b7e4so2773480wms.0 for ; Wed, 08 Feb 2023 07:39:57 -0800 (PST) Received: from work-hp.. ([91.123.148.245]) by smtp.gmail.com with ESMTPSA id d8-20020adfe2c8000000b002bfe08c566fsm13958034wrj.106.2023.02.08.07.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 07:39:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d720f501-a7c6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oGWuGjSyAolvIuh2gpF30/sfRfWcmW0ukeqiTc1FZg4=; b=oJLgmWwOA/fWnsZRLlXi0D7IB41vvMVwDk7qIp/hPO/I0Cu28Q2i4d0DPXkgCMMGW7 SdzZx2e3lqC+DVRz/VlUF+Pk6ZB+kB9aSgjpLPKWsIw6CQBDEbkGyHNWz4UyfDWYca53 K34F4fo3Rdk5I9CATRq9b+kuSOPothxpM0z/dhRzc7xKpmGW2aUP7qLS5v26HcIzsXml uRi3XbYZNSXIYEpwwPGuh8OTovAuQ7No2yybmDgLJaO+R3upLfKBHWlDm2zvJPPCTQlz 8uTHL68LY/yG++GRdkvszu7ZgdscE3xE0++V0ywwduDPIPSfpmd/Xpn8oL10Dt/+8xS3 XurQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oGWuGjSyAolvIuh2gpF30/sfRfWcmW0ukeqiTc1FZg4=; b=777myMKhD4KEoB+UVlt4crIkZLK5efbJ7sNcs6K90URPJfJXakLSnf6VNcKAclHkyu DiyI3xB3wZosjglbf9OLi0hImFEswGtNk1wTPZ7iENeelOMrJK3nn3jvfbA1Wo6FCFik oxjlr2QVKzt/5h0Ejm4VgitVzZp483rc22GEK4aXZ5YFAEXG6weV3gYf5Wad6FMvr186 8JnD5MpqL90KTBMfdA4PjKnBadBRcl/8Yl6vDhGTGZCqh4lfuP4FXE6rJ7TNBq5o4Tk4 fUjV+EWktuGe2Ln1BgW5Il5NVgf7hl43fa8/AAK3h1tFXWiaDLOA6EfDApVeFxDq/z1a gPHg== X-Gm-Message-State: AO0yUKVF43vqhyF2IMkhWnYj5HR+FqPovARZ9qAfvPUKfXZPE2pgDJEE M2cD7N7nQDmMGJSGCgc911w6OVu0vLU= X-Google-Smtp-Source: AK7set/9TBqIZGKiBgGkbYehMHhv5R4xqumCMXaSzOW6dO7LsQm45M+8qsR9emWP/44RWI8GFW0KSA== X-Received: by 2002:a05:600c:1613:b0:3df:b5ae:5289 with SMTP id m19-20020a05600c161300b003dfb5ae5289mr6782149wmn.8.1675870796500; Wed, 08 Feb 2023 07:39:56 -0800 (PST) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Juergen Gross , Stefano Stabellini , Viresh Kumar Subject: [PATCH] xen/grant-dma-iommu: Implement a dummy probe_device() callback Date: Wed, 8 Feb 2023 17:36:49 +0200 Message-Id: <20230208153649.3604857-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Update stub IOMMU driver (which main purpose is to reuse generic IOMMU device-tree bindings by Xen grant DMA-mapping layer on Arm) according to the recent changes done in the following commit 57365a04c921 ("iommu: Move bus setup to IOMMU device registration"). With probe_device() callback being called during IOMMU device registration, the uninitialized callback just leads to the "kernel NULL pointer dereference" issue during boot. Fix that by adding a dummy callback. Looks like the release_device() callback is not mandatory to be implemented as IOMMU framework makes sure that callback is initialized before dereferencing. Reported-by: Viresh Kumar Signed-off-by: Oleksandr Tyshchenko --- drivers/xen/grant-dma-iommu.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c index 16b8bc0c0b33..6a9fe02c6bfc 100644 --- a/drivers/xen/grant-dma-iommu.c +++ b/drivers/xen/grant-dma-iommu.c @@ -16,8 +16,15 @@ struct grant_dma_iommu_device { struct iommu_device iommu; }; -/* Nothing is really needed here */ -static const struct iommu_ops grant_dma_iommu_ops; +static struct iommu_device *grant_dma_iommu_probe_device(struct device *dev) +{ + return ERR_PTR(-ENODEV); +} + +/* Nothing is really needed here except a dummy probe_device callback */ +static const struct iommu_ops grant_dma_iommu_ops = { + .probe_device = grant_dma_iommu_probe_device, +}; static const struct of_device_id grant_dma_iommu_of_match[] = { { .compatible = "xen,grant-dma" }, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 15:46:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 15:46:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491897.761247 (Exim 4.92) (envelope-from ) id 1pPmef-0001GF-OU; Wed, 08 Feb 2023 15:46:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491897.761247; Wed, 08 Feb 2023 15:46:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmef-0001G8-Lr; Wed, 08 Feb 2023 15:46:41 +0000 Received: by outflank-mailman (input) for mailman id 491897; Wed, 08 Feb 2023 15:46:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmee-0001Fy-4c; Wed, 08 Feb 2023 15:46:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmee-0006N2-2R; Wed, 08 Feb 2023 15:46:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmed-0006mQ-NR; Wed, 08 Feb 2023 15:46:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPmed-0003DI-N0; Wed, 08 Feb 2023 15:46:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mPCEHSGWcQ/ww66Hp6J27xgyEN1QW3n43Tnphh+8Vlo=; b=dgO1oQtnqVpL6FjKJjfVj3VLlD WwbWzvN/Sa3nTZMkK2rtpKOl8FFB63R8+BqnBmJgrsEK7Meukp4r8me1gXl1dBJ5AUOU8FQU+zVbH PS9XVU+16oeC5rCjd2Vj2kWkkHSgpHY/Y0IH0wI4cumGGou3UWIeWb+1mzlP2lB1qGRg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176640: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 X-Osstest-Versions-That: xen=b9adcb5ab910b61e5332728bd248906e68a45900 From: osstest service owner Date: Wed, 08 Feb 2023 15:46:39 +0000 flight 176640 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176640/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 baseline version: xen b9adcb5ab910b61e5332728bd248906e68a45900 Last test of basis 176618 2023-02-08 09:01:53 Z 0 days Testing same since 176640 2023-02-08 14:02:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Michal Orzel jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b9adcb5ab9..6d317b10f8 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Feb 08 15:51:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 15:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491905.761258 (Exim 4.92) (envelope-from ) id 1pPmjD-0002fv-Al; Wed, 08 Feb 2023 15:51:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491905.761258; Wed, 08 Feb 2023 15:51:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmjD-0002fo-7i; Wed, 08 Feb 2023 15:51:23 +0000 Received: by outflank-mailman (input) for mailman id 491905; Wed, 08 Feb 2023 15:51:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPmjB-0002fi-P2 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 15:51:22 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20602.outbound.protection.outlook.com [2a01:111:f400:7e8b::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cc8d5c6-a7c8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 16:51:19 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SJ1PR12MB6265.namprd12.prod.outlook.com (2603:10b6:a03:458::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 15:51:15 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6064.032; Wed, 8 Feb 2023 15:51:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cc8d5c6-a7c8-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6xHexLB+U3bx/nrchIMkcWvCYjXZIsTMslDyH14SxUKVZpYckZFg6vj9LHJL7L8hmxVIgOoPm8DANO+f5g/zCPa9NXqaLCwCiLPLTW84uEIKVk9QPG5Cg7CXSI4AvZRld1BfPsMVQxoZakkD+KzSWZbiRJUra3LKqVQI9UXghsIgI4zd4YjCwT/4q8VA4xhA6EzNfrIEjNb2Vj67ZFTGiWDL3EqamhH1MN3tm5bnEZc4DYS2wp/AqesZG/w+S5lLon9D/jpZXSx/jDVXShY8wlj124kQC24dxgDGEj9srTvbKl0DuOgRkzl+/jIdxeeLh5Oc+/h1ZfZov1xbSWHZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jfm/pEyLeRy4g+nxOzs+DogaTR+Y6/Oh3dLy89tCDHE=; b=ekQiT2wJFUo+5muWM6FnYtanXcTlodII34NneJA8B+trY8pArtf4Bp+QDl9mKlMvALNhlPy3MYuTrw/EwJWRB0Qmra/9toakVDp52DU9xobqqEv3yDH2I7w0jgkKGKSj/ZulOC2M5MLIwNIOcAXc+zSe05649/fY2BKpQrOLnoPkDUiAqnlXov/Szw9AfV52gfdeLeh46C2I2CCax6D44hKNDxszpRPcIkw/9OYyfMm/SU7D2HtkvWR0qMsQZa9DvI3/iHClTznZNi01VjcgyUqRCD8YW/yl8N1fUc/nxXlqvFuSDMjupDGEdzx4nL4U1L/nnUqErxa7Wmls+aTx8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jfm/pEyLeRy4g+nxOzs+DogaTR+Y6/Oh3dLy89tCDHE=; b=Kkgw41Gx2om5GrCbRJTmZbFfbPQWo3kdGCS5slMPJgJsHG66IPAcB/zNWelmH+GGKQovDDHB9WmE7N+SQOiF4LYEf0JqqUPvoJ0rthl1NAx5psOrutCgxEg5bPrIRmjl/fMRwRGygQLfRDmuXbh4ogNbyNuqto+98NXYP+euY64= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 8 Feb 2023 15:51:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 2/9] xen/arm: Typecast the DT values into paddr_t To: Jan Beulich , Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-3-ayan.kumar.halder@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0609.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::11) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SJ1PR12MB6265:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c9b9af1-b450-48d3-7ba4-08db09ec4f38 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s1jQpE+r1lDwS2by70frrxb6EkD5aCd23cmk/UTAqq8wUKeNMAZpvJg/swbevfwl4i5t32JAQASj4UwBBZC9Ft8JdCjWIUXwKZTIEqiyaLlq8XOjLJM87wix449HIjFdfQO41w+UEcALdb5UPCXzF2b0ZDwAurdq4xO3WPjmaadQqqTyk4hhBBlwPhyHLtQmaZ9DkIA72wl1J7eB4PT0yhZH1hJLQ+EbJlf3CCs1Eh00mwxASxk8SSkWnFDQ2vXzjO3It3Atj9UGVczfQQFP159veYtr8X+6TvtXh086uVjEUf1mplmCHCJc59m7zvBhhkdGH2nq1CGMOS94AP3trE53F8sHcLZcYXeccHZTtjFTP1JEapxBLPCBeI84BVD0/lih17eYAaITnZQaVY5t0rBX+OaBEWyE1ooanvf/t1jA3Gi2Fj/gc6eajyZWdt1SIg7lk/HTSlhwbL89UaftYE8ItxJs2os4GN8B2Ia+DmA50t9n+zYQ946nxU9ux4DZdRk44bSjDQf9jstVXHvMDLk6+wYMkjIsbe4iigMXFREng4XU3Gt8eM/ClcPmmDCKsYzbyFXDkGuYU8s6Djy01vTL1k4dVtjXZvnSHBySaSgNs9n8TGmnCMt69Jq9fgPGfqLrUI4GehbutLZOMOJvTjxLjteiglqkizT1C+TX5oepDDHTARAEopmSQNIa2jAMdtaL7fAV6WelMGKFQ5hgcSvF0yIeKKrpQuOoUMacmEI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(451199018)(5660300002)(83380400001)(7416002)(31686004)(8936002)(2906002)(41300700001)(36756003)(2616005)(4326008)(6506007)(26005)(186003)(6486002)(53546011)(6512007)(110136005)(6636002)(66946007)(316002)(66476007)(66556008)(31696002)(8676002)(6666004)(38100700002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azl2Z3dyTXhob1MvWUVxeVVRZUlxVHVVeldZd2NNS1ArS2l0M3pVUVY2cTdj?= =?utf-8?B?L3dUK3NyWmw4YnVlaFV5Z0ozSXU4d0tnQUhjdTVjODlna3VDM0k2RS94endv?= =?utf-8?B?Qm5ydTZyM1Z1eGZLcy9MQkpPcUpmV25KS2ZKU2FuYnlRWndaUzRDL2JEeWNo?= =?utf-8?B?d2VDQzJhSlk2eDFZckFYNS9lNkQxU2JFdDdEbmxlOU5ZdzI1MlpBWktMWDNk?= =?utf-8?B?WWtvSlp0enlOVjIzaGRuR1h4NXpKYURyUW9ncVQ0UDRCU2ZjZlhOU2F2bzZE?= =?utf-8?B?bmFhNGM0S0NCZDBSR2x1dldvemN3ZGhDejRIcnJldUNTMkFtRDhOcFNSdHdh?= =?utf-8?B?T1AvYUdIeTN6NFpOZ0VvajdIMTZjZ28xRFMyYnlIMitjUmwzTXJJSklnd0Jo?= =?utf-8?B?YUxnbGhQUE1pQWJ3eGFHTkpSdWhaVFZ5ci9XTkF6SXdKSjlHTFhRMWNYNnQw?= =?utf-8?B?REdwTGw3WGFmRlIxdmZKbEpvdjVVeDQ4ejUwWUxYbFNObXRTamdJZjFhV0JS?= =?utf-8?B?NmJSTWFiZnFHM205cy9SQno3SURqR2FUSm96Zm1qdFo0RjE2aytJQ2Y3K0R2?= =?utf-8?B?NHkrQnUwbUsrYnA2Kzk2WFlBTmZWU1c4RVVpaWpKMG85dDFhNEs1MkloMGNr?= =?utf-8?B?RjZ6RndwZWdld0ZaYzBpdHRCVGl2UG1QU25wS292cG5nVjFjd2hOYm11VnBS?= =?utf-8?B?SUZZZG90WWRNWVdESVpIeVR1d1QzSTZxTHhVVDhzcVpIemhrNVRWaUVNblg5?= =?utf-8?B?SWEvNUE0RmxLaVJhM0pXRTdPRTk5TmJseHJpaDZVdFNabHJzNUYwRk5RNXdP?= =?utf-8?B?RnFsdDEyZ3dpWjZJa3krSDNIUlN1NFYrNGNLQU5YOTBubytpRUlvVFo0MjFQ?= =?utf-8?B?UjlvcjZaZlFyV1lobVJsMXdkeUVRVElHak1BQUJmVTNsWE5uY1lEOXNUZG1B?= =?utf-8?B?bFNVN2M3ck9HZTJiSEFWb3R5bnNKTlBjM013NFpmU24rQzM0aVBiTHJDMm5y?= =?utf-8?B?K0VyUkRESFN5TzBwdy9EM3U3WUlnek9HcVdyNFZDSXRjVXNHVURRdSt1ZUpy?= =?utf-8?B?TmxiQTg1Mkt2akZZOTFhVG5icGJrM1lqL0pSQWJaTlpVeHhuMm9oemhub0E3?= =?utf-8?B?anNLNTZxNTlzZTB2M2UyYkF1RStIbnNuLzBjdjcrK3ByRVVCMWR1S1NTTlN0?= =?utf-8?B?M01MQklvajhuMnVoZ0xEbGpIQzNITFkvZElqSlU5ejdTWGw4WlFQcFN2SFBG?= =?utf-8?B?L0RQakF3cW93aDRrWXI2UjczNjlzaXBGQ1UwNWRXM2tia1RueCtHQ0tuakJz?= =?utf-8?B?aVNNS1RyYU9EQ2JTaXV3YlNpSE9sNXRoQlRMdXdTTldSUFBDVWZTK1JjQ25Q?= =?utf-8?B?TzNCa2c1VjlPU1ZCUytncG1DcmdUN0I0YUkvYWJzVmFocVhRelAwNFJER3Fz?= =?utf-8?B?c3liRmorNDZBcE4yYVg1YnJRdWNQYVJnS2JBUDNyRk0wUm9FMHM4bXVqdWZs?= =?utf-8?B?STk0Y2xFNVJZT0VmeTQ3Y3pHQ3FtaGRvaWVRYllnVkdmdzNacmRXMXpDeTN4?= =?utf-8?B?WThieDNRNm1sS2l5WlFEZER3TUh1azlVbENVRW9IQ2w3cU5CYzA2QUtqYVFi?= =?utf-8?B?M2tpak9hQVFKRW9ueVpyZStpS3Z4UEdmYnk2clg2RzBMVEJHTFlESkpnRWdw?= =?utf-8?B?OGtEcmlDbnQ1cEd5UnNxdEI1UWI0a2FRSUZlQ244b2QzMXErYnJMVmlkdHR0?= =?utf-8?B?SFFKTVMySWlmWUlqUlZTbEdrWjVEUHV3dG4rVmFtbVFZcGxYUHNoMDd4UkNm?= =?utf-8?B?M0gxdGk5YTUrQjdVVk14cThVdG5QbXluSUxoM3hUZ05malhPSlhiblBTbmo5?= =?utf-8?B?U213TU1mdllzcVp6bUhhZnZ1U0Ivb3RMdC9qZE0wYm5IRzRQWHMzbzNTV3o5?= =?utf-8?B?Qjg2QXlVNFF1RUk1VWhnc0xheWdSK1Q0b0JYODkxNlFaZFBncGJkMGI0d0RK?= =?utf-8?B?aFZNVGIya3cxT3BrbEJZc2NBZEVlTjBhOE9lZlVwRm5nMTZHajJvcW9MSklz?= =?utf-8?B?aTRTd2thMnpyTHU4c0NNL1hoWU42cG5pYStwZmE3a2xJNkNpdjIvYVRtbFpU?= =?utf-8?Q?klmlhONh4EYWN8a+HapQMta+e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9b9af1-b450-48d3-7ba4-08db09ec4f38 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 15:51:15.1746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hM9eR5vYJdSGZfy/tU8Lt+PsraoyN1qpjQyed6fMKIie5KU4peEkVDjgIzr39crzbIIZj4UtqDapyUtUK0P2ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6265 Hi Jan, On 08/02/2023 13:33, Jan Beulich wrote: > On 08.02.2023 13:05, Ayan Kumar Halder wrote: >> In future, we wish to support 32 bit physical address. >> However, the current dt and fdt functions can only read u64 values. >> We wish to make the DT functions read u64 as well u32 values (depending >> on the width of physical address). Also, we wish to detect if any >> truncation has occurred (ie while reading u32 physical addresses from >> u64 values read from DT). >> >> device_tree_get_reg() should now be able to return paddr_t. This is >> invoked by various callers to get DT address and size. >> >> For fdt_get_mem_rsv(), we have introduced wrapper ie >> fdt_get_mem_rsv_paddr() while will invoke fdt_get_mem_rsv() and translate >> u64 to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as >> it has been imported from external source. >> >> For dt_read_number(), we have also introduced a wrapper ie >> dt_read_paddr() to read physical addresses. We chose not to modify the >> original function as it been used in places where it needs to >> specifically u64 values from dt (For eg dt_property_read_u64()). >> >> Xen prints an error when it detects a truncation (during typecast >> between u64 and paddr_t). It is not possible to return an error in all >> scenarios. So, it is user's responsibility to check the error logs. >> >> To detect truncation, we right shift physical address by >> "PADDR_BITS - 1" and then if the resulting number is greater than 1, >> we know that truncation has occurred and an appropriate error log is >> printed. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from >> >> v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and >> "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead >> this approach achieves the same purpose. >> >> 2. No need to check for truncation while converting values from u64 to paddr_t. >> >> v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. >> 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr >> 3. Logged error messages in case truncation is detected. >> >> xen/arch/arm/bootfdt.c | 38 ++++++++++++++++----- >> xen/arch/arm/domain_build.c | 2 +- >> xen/arch/arm/include/asm/setup.h | 2 +- >> xen/arch/arm/setup.c | 14 ++++---- >> xen/arch/arm/smpboot.c | 2 +- >> xen/include/xen/device_tree.h | 21 ++++++++++++ >> xen/include/xen/libfdt/libfdt_xen.h | 52 +++++++++++++++++++++++++++++ >> xen/include/xen/types.h | 2 ++ >> 8 files changed, 115 insertions(+), 18 deletions(-) >> create mode 100644 xen/include/xen/libfdt/libfdt_xen.h > Can you please avoid underscores in the names of new files, unless they're > strictly required for some reason? Actually I introduced libfdt_xen.h as I did not wish to modify the fdt_get_mem_rsv() (present in fdt_ro.c). So I created libfdt_xen.h to implement fdt_get_mem_rsv_paddr(). The *_xen.h denotes that it is derived from * (which can be modified like any other file). Let me know what name you suggest. > >> @@ -53,10 +53,30 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, >> } >> >> void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, >> - u32 size_cells, u64 *start, u64 *size) >> + u32 size_cells, paddr_t *start, paddr_t *size) >> { >> - *start = dt_next_cell(address_cells, cell); >> - *size = dt_next_cell(size_cells, cell); >> + u64 dt_start, dt_size; > No new uses of this type (and its siblings), please. We're in the process > of phasing out their use. See ./CODING_STYLE. Ack > >> + /* >> + * dt_next_cell will return u64 whereas paddr_t may be u64 or u32. Thus, >> + * there is an implicit cast from u64 to paddr_t. >> + */ >> + dt_start = dt_next_cell(address_cells, cell); >> + dt_size = dt_next_cell(size_cells, cell); >> + >> + if ( (dt_start >> (PADDR_SHIFT - 1)) > 1 ) >> + printk("Error: Physical address greater than max width supported\n"); >> + >> + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) >> + printk("Error: Physical size greater than max width supported\n"); > While I assume you wrote the checks this way to avoid "shift count too > large" compiler diagnostics, personally I think this is making it > harder to recognize what is wanted. Already (val >> (PADDR_SHIFT - 1)) >> 1 > would be better imo, by why not simply (paddr_t)val != val? Yes, makes sense. I will use "(paddr_t)val != val" to check for truncation. > >> --- a/xen/include/xen/types.h >> +++ b/xen/include/xen/types.h >> @@ -71,4 +71,6 @@ typedef bool bool_t; >> #define test_and_set_bool(b) xchg(&(b), true) >> #define test_and_clear_bool(b) xchg(&(b), false) >> >> +#define PADDR_SHIFT PADDR_BITS > Why do we need this alias? I could have use PADDR_BITS instead, but decided to use PADDR_SHIFT for cosmetic reasons. > And if we need it, on what basis did you pick > the file you've put it in? I wanted to put in an arch independent file (where we have defined macros related to data types). - Ayan > > Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 17:00:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 17:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491912.761280 (Exim 4.92) (envelope-from ) id 1pPnnS-0002Kk-Q8; Wed, 08 Feb 2023 16:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491912.761280; Wed, 08 Feb 2023 16:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnS-0002Kd-NG; Wed, 08 Feb 2023 16:59:50 +0000 Received: by outflank-mailman (input) for mailman id 491912; Wed, 08 Feb 2023 16:59:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnR-0002KM-Lz; Wed, 08 Feb 2023 16:59:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnR-0000Ef-JO; Wed, 08 Feb 2023 16:59:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnR-0008RP-Al; Wed, 08 Feb 2023 16:59:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPnnR-0005m8-AJ; Wed, 08 Feb 2023 16:59:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=noXx5AGWypO3xPwhX2MzB4uAoHNI43EmDxjj8Uh921M=; b=cygqfts19smvaNw1uHOhCue8WJ QKt1RGuI+zXwENTSb7nUiBVQPPfYVcmPiNroZ+9t+Z5OCt9WvVdJzBQTYsn7PjodhhD3RTHxhtw3v TBpmUeYUZgf/qJHuhoFOFDXB9X6f3eTg6AOjM/rYaDVL9omK6ggy2oKVENngfPltkKsg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176460: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: linux-5.4:test-amd64-amd64-pair::broken:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-amd64-amd64-pair:host-install/src_host(6):broken:heisenbug linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-examine:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Wed, 08 Feb 2023 16:59:49 +0000 flight 176460 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/176460/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pair broken build-arm64-pvops 6 kernel-build fail in 176438 REGR. vs. 176106 Tests which are failing intermittently (not blocking): test-amd64-amd64-pair 6 host-install/src_host(6) broken pass in 176438 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 176413 pass in 176460 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 176413 test-amd64-i386-examine 6 xen-install fail pass in 176438 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 176438 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 176438 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 176438 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 176438 n/a test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 176413 like 176090 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 176413 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 14 days Testing same since 176413 2023-02-06 07:13:34 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair broken test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-pair broken broken-step test-amd64-amd64-pair host-install/src_host(6) Not pushing. (No revision log; it would be 4165 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 08 17:00:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 17:00:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491911.761269 (Exim 4.92) (envelope-from ) id 1pPnnP-00025C-Ct; Wed, 08 Feb 2023 16:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491911.761269; Wed, 08 Feb 2023 16:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnP-000255-9u; Wed, 08 Feb 2023 16:59:47 +0000 Received: by outflank-mailman (input) for mailman id 491911; Wed, 08 Feb 2023 16:59:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnnN-00024z-LZ for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 16:59:45 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa8ca477-a7d1-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 17:59:43 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa8ca477-a7d1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675875583; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lFKv9iAHm2/PnFQnmWDbdl0f5ZalkCm6aTnDOAkDN7Q=; b=dAH7VjA8pGnl9omG4na74TCeipWzZKg6E7b6qz9quoZ7DUnJEUbJxcNg R/Ve/Tweh2qKtkH5deDM7R802rvEWOo0vFURhYfQ0ZwB2bJR9ot7oxSqq hozldzqL3UcgfGiHCB15GCwbKDfkgnKCmgZqxLs/vbhNRCGm4K5Ay9x88 M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98648404 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:gn2lDaojy0wd77VzACAUqprscWheBmIIZRIvgKrLsJaIsI4StFCzt garIBnUM/zeZ2rwKNElYYqz9h5V6pKAz9ZlTFRkrCw8FnxBp5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzylNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGoMUi2pp9Dr+bf4FdBSn/UkF9OoBrpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jOWoTipXklGXDCZ4QLd31mjjbHQpjPmZbNIKrjjrtIynULGkwT/DzVJDADm8JFVkHWWWd1FL FcP0jEztqV0/0uuJvHiWzWorXjCuQQTM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDhoj/yLWUx6vvPEyvbr+rK62roYkD5MFPuewdeTDc4yfnR/bg2zU32cM9SF5WvzefMTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4umkWyKRBaJxsldrVj Kj752tsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon4zOh/MgT6wyhdy+U3aB Xt9WZz0ZZr9If04pAdaus9HieN7rszA7TO7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Mm +uzw/Cikk0FOMWnO3m/zGLmBQxSRZTNLcys+pM/my/qClYOJVzN/NeIkOh/J9Q6wfQ9eyWh1 ijVZ3K0AWHX3RXvQThmoFg5AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:YqnUbK9JQzejftPCx0Nuk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.97,281,1669093200"; d="scan'208";a="98648404" From: Anthony PERARD To: CC: Anthony PERARD , Juergen Gross , Wei Liu Subject: [XEN PATCH v6.1 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only. Date: Wed, 8 Feb 2023 16:59:13 +0000 Message-ID: <20230208165913.19694-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <6a141dab-aef8-960d-269d-23f8000a257d@suse.com> References: <6a141dab-aef8-960d-269d-23f8000a257d@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain LDLIBS is usually only the library flags (that is the `-l` flags), as proposed in GNU make manual, while LDFLAGS would be extra flags such as `-L`. Rework the make macro $(xenlibs-ldlibs, ) to only provide the library flags. $(xenlibs-ldflags, ) already only provide the extra flags like the -rpath-link flags. Also fix "test_%" recipe in libs/light as "libxenlight.so" in $(LDLIBS_libxenlight) is been replaced by "-lxenlight". Instead of just changing the filter, we will start using the $(xenlibs-*,) macro. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross --- Notes: v6.1: - For test_% recipe, add toolcore and toollog to the $(xenlibs-ldflags,) macro, to not have to reli on the flags been already present in $(LDFLAGS). v6: - new patch tools/Rules.mk | 16 +++++++--------- tools/console/client/Makefile | 1 + tools/console/daemon/Makefile | 1 + tools/helpers/Makefile | 3 +++ tools/libs/libs.mk | 1 + tools/libs/light/Makefile | 2 +- 6 files changed, 14 insertions(+), 10 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index d7c1f61cdf..007a64f2f5 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -105,12 +105,6 @@ define xenlibs-libs $(XEN_ROOT)/tools/libs/$(lib)/lib$(FILENAME_$(lib))$(libextension)) endef -# Flags for linking against all Xen libraries listed in $(1) -define xenlibs-ldlibs - $(call xenlibs-rpath,$(1)) $(call xenlibs-libs,$(1)) \ - $(foreach lib,$(1),$(xenlibs-ldlibs-$(lib))) -endef - # Provide needed flags for linking an in-tree Xen library by an external # project (or when it is necessary to link with "-lxen$(1)" instead of using # the full path to the library). @@ -119,12 +113,16 @@ define xenlibs-ldflags $(foreach lib,$(1),-L$(XEN_ROOT)/tools/libs/$(lib)) endef +# Flags for linking against all Xen libraries listed in $(1) +define xenlibs-ldlibs + $(foreach lib,$(1),-l$(FILENAME_$(lib)) $(xenlibs-ldlibs-$(lib))) +endef + # Flags for linking against all Xen libraries listed in $(1) but by making use # of -L and -l instead of providing a path to the shared library. define xenlibs-ldflags-ldlibs $(call xenlibs-ldflags,$(1)) \ - $(foreach lib,$(1), -l$(FILENAME_$(lib))) \ - $(foreach lib,$(1),$(xenlibs-ldlibs-$(lib))) + $(call xenlibs-ldlibs,$(1)) endef define LIB_defs @@ -132,7 +130,7 @@ define LIB_defs XEN_libxen$(1) = $$(XEN_ROOT)/tools/libs/$(1) CFLAGS_libxen$(1) = $$(CFLAGS_xeninclude) SHLIB_libxen$(1) = $$(call xenlibs-rpath,$(1)) -Wl,-rpath-link=$$(XEN_libxen$(1)) - LDLIBS_libxen$(1) = $$(call xenlibs-ldlibs,$(1)) + LDLIBS_libxen$(1) = $$(call xenlibs-ldflags,$(1)) $$(call xenlibs-ldlibs,$(1)) endef $(foreach lib,$(LIBS_LIBS),$(eval $(call LIB_defs,$(lib)))) diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile index 071262c9ae..ea7819c03e 100644 --- a/tools/console/client/Makefile +++ b/tools/console/client/Makefile @@ -6,6 +6,7 @@ USELIBS := ctrl store CFLAGS += $(call xenlibs-cflags,$(USELIBS)) CFLAGS += -include $(XEN_ROOT)/tools/config.h +LDFLAGS += $(call xenlibs-ldflags,$(USELIBS)) LDLIBS += $(call xenlibs-ldlibs,$(USELIBS)) LDLIBS += $(SOCKET_LIBS) diff --git a/tools/console/daemon/Makefile b/tools/console/daemon/Makefile index e53c874eee..400611fc2d 100644 --- a/tools/console/daemon/Makefile +++ b/tools/console/daemon/Makefile @@ -7,6 +7,7 @@ CFLAGS += $(call xenlibs-cflags,$(USELIBS)) CFLAGS-$(CONFIG_ARM) += -DCONFIG_ARM CFLAGS += -include $(XEN_ROOT)/tools/config.h +LDFLAGS += $(call xenlibs-ldflags,$(USELIBS)) LDLIBS += $(call xenlibs-ldlibs,$(USELIBS)) LDLIBS += $(SOCKET_LIBS) LDLIBS += $(UTIL_LIBS) diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 0d4df01365..5db88dc81b 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -18,17 +18,20 @@ endif XEN_INIT_DOM0_USELIBS := ctrl toollog store light XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o $(XEN_INIT_DOM0_OBJS): CFLAGS += $(call xenlibs-cflags,$(XEN_INIT_DOM0_USELIBS)) +xen-init-dom0: LDFLAGS += $(call xenlibs-ldflags,$(XEN_INIT_DOM0_USELIBS)) xen-init-dom0: LDLIBS += $(call xenlibs-ldlibs,$(XEN_INIT_DOM0_USELIBS)) INIT_XENSTORE_DOMAIN_USELIBS := toollog store ctrl guest light INIT_XENSTORE_DOMAIN_OBJS = init-xenstore-domain.o init-dom-json.o $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(call xenlibs-cflags,$(INIT_XENSTORE_DOMAIN_USELIBS)) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h +init-xenstore-domain: LDFLAGS += $(call xenlibs-ldflags,$(INIT_XENSTORE_DOMAIN_USELIBS)) init-xenstore-domain: LDLIBS += $(call xenlibs-ldlibs,$(INIT_XENSTORE_DOMAIN_USELIBS)) INIT_DOM0LESS_USELIBS := ctrl evtchn toollog store light guest foreignmemory INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o $(INIT_DOM0LESS_OBJS): CFLAGS += $(call xenlibs-cflags,$(INIT_DOM0LESS_USELIBS)) +init-dom0less: LDFLAGS += $(call xenlibs-ldflags,$(INIT_DOM0LESS_USELIBS)) init-dom0less: LDLIBS += $(call xenlibs-ldlibs,$(INIT_DOM0LESS_USELIBS)) .PHONY: all diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index 0e4b5e0bd0..fc6aa7ede9 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -17,6 +17,7 @@ CFLAGS += -Wmissing-prototypes CFLAGS += $(CFLAGS_xeninclude) CFLAGS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib))) +LDFLAGS += $(call xenlibs-ldflags,$(USELIBS_$(LIBNAME))) LDLIBS += $(call xenlibs-ldlibs,$(USELIBS_$(LIBNAME))) PIC_OBJS := $(OBJS-y:.o=.opic) diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 96daeabc47..04ea2a82c0 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -244,7 +244,7 @@ libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS) test_%: test_%.o test_common.o libxenlight_test.so - $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $(call xenlibs-ldflags,toollog toolcore light) -o $@ $^ $(call xenlibs-ldlibs,toollog toolcore) -lyajl $(APPEND_LDFLAGS) libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 08 17:08:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 17:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491929.761292 (Exim 4.92) (envelope-from ) id 1pPnvT-0004KP-NS; Wed, 08 Feb 2023 17:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491929.761292; Wed, 08 Feb 2023 17:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnvT-0004KI-Iw; Wed, 08 Feb 2023 17:08:07 +0000 Received: by outflank-mailman (input) for mailman id 491929; Wed, 08 Feb 2023 17:08:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPnvS-0004KC-Ou for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 17:08:06 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062b.outbound.protection.outlook.com [2a01:111:f400:fe5b::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26327d8e-a7d3-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 18:08:05 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH0PR12MB5092.namprd12.prod.outlook.com (2603:10b6:610:bf::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 17:08:01 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6064.032; Wed, 8 Feb 2023 17:08:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26327d8e-a7d3-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VeQxvr6HkLAvdis2BzIOxWv+xNsCGmhNWX+ppvVRrB4Eoi6kjLsEaxBX/SgI6z5/5OqeHsKptT7F71ED9Av2DwwyyrrYJe8qEGGsZ+2PD76TJ4sNU+12PfSJDrEDo6q+N7GX/u+H3eyV+4KtOrwSLpYydv6/Dboz91GTca4alH0MxV4DUpXiAqLGcgoo9iS8Wq4pzPZO6FbT8OQCLc+4vzv8GHK/JG3ypGWmdMcKkYklgr8/4Ta0MEwzPxOtuWbKaZFQxq2+Lmh1kaQWoxm+Z8jZssS8R+2h+cymzq8qDrnFuJGtmp4BPSSj+0kaqAN38sxPMTR8HDLwSZFFbmMrEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wF+jvPzW/t75K67ZlUkLDlWTJo3FWF0QTAZfcrA4DdE=; b=BbCZAE8v+83MHD64G1+kdQRE0yBXZOUMXb2bVWaMZPFCh4duGi3ao6bZayHde9I9cLCkJ6F1XpPSvqBIpPsQLinmvDZLKsWAeY+g1ybARsevKAn/kDHNDAfo5tGW+cRVUW++iWfTwL6Y03Q/axFFfopEu1Tb04Vl5dMN7d6gzrzAkpgqsLt6OhxgkNMEB1ykXrrN6XNmm9HFKDQHg8VHaWXSL+ryJIv6pQLQq7c6WlL18WD09/YBq0vuYKKTVv00W3OhFzmszQ2x8JcbU2AAEnPgPH+mu33/ghrqochGhPp2bpTPzD6wqu+VYuF+AC0vGZB9jpJJwvdVzjw7N3puLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wF+jvPzW/t75K67ZlUkLDlWTJo3FWF0QTAZfcrA4DdE=; b=JuZa36cUX3qzVMBgXFksDyxjc/cJk2EqjyqgV7lNIYfkBJnSkxqRSDVbcfx8JgwOXB59CfkIX9fjq4yGfO+3pYu+zZfDa/1hSBIwLVX+ZOw1DUQWkRRuTkyndiNZGn5TudRTqvffpLBc+C5CxLvM0BRGDazO3A/c6jWXngpjrrQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Wed, 8 Feb 2023 17:07:54 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 3/9] xen/drivers: ns16550: Use paddr_t for io_base/io_size To: Jan Beulich , Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-4-ayan.kumar.halder@amd.com> <216343f3-6045-c6fe-ff4c-3a70d5061b78@suse.com> From: Ayan Kumar Halder In-Reply-To: <216343f3-6045-c6fe-ff4c-3a70d5061b78@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::15) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH0PR12MB5092:EE_ X-MS-Office365-Filtering-Correlation-Id: 1037ec46-c80c-40a4-94d5-08db09f708aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yHk3gx6eaMUKKRCCgU5cKWguZ0pn5yonr77v3temw/Go4Wwz9M+Gn4SCNuo1BGFEtUIz72r0D5R0z+uMWFXoBkC3tpamkZZvc18koV5WQ5BbYPBlnQHsSn99p7vlv69Mbh+E007EH2mNuJ7wS1X239daFY4HkobumoEsovxPRGfhW2tl1v1QPoa526D0FSYzhchuHFwlX3s0T34eQzsJqEJSahZ6RkZBDCA1ua44ZhsPdCpet/WXbYMBCelarojAy+Tfq43pu4HtqzWk9bWw9UzucMG3uz9URIGvy1W5kinJQd2JQjPPxQnlHCi695wgCA/ZukqEIGp9LuPP+jkiWC5Emqm0juqMEkKS9nvlxKMXzKc4T0A2vJnfdzE87xS851Gdu3tZ/QnwdJv6q81RD887xEY49YHj8HeySaKFsNyOvSIOyZcn4NoVbdUmyeMpQm3NWfAYzFgkqIDTZxAGLoSN3bLFIxiKp27uzQVBC6pFuD10ZbbakH/cogXevT5GN9XLWca3VBga20NpYAs0BtCakZP6B6bAwtmSaFMDQ8xz1cpsJXX+oGXMSMJQLYsHa3fLyEehIEEnaY6J9cnO8MHZbS5rKJw1XZ6RFhCCwrvHgQFjAvI5oIvPLhz4BOEn0sD8bEYrEw3KZt2hjawjBtjT5tn5no4K0GIRTvN9BM/sUdFrERpfbqv3j0XdUqr2eDlus0azfDN06xUmFFpEdH/wjYx8+6RDk1HqWxg1KeI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199018)(110136005)(6636002)(31696002)(6512007)(316002)(2616005)(53546011)(186003)(6506007)(83380400001)(36756003)(26005)(478600001)(6666004)(6486002)(38100700002)(5660300002)(41300700001)(7416002)(31686004)(8936002)(2906002)(66946007)(66556008)(8676002)(66476007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlVrTjBFWWZVZnlHSndQL1ZONHo0S3FjUTVKSEI1ZjNHbWlZb1hjNTJSOXIx?= =?utf-8?B?c21hTUgwdGYxSkNhcGkrMGdFK2NGWEhGREd2ZFkvdDV2SjdDQkFPQmhDVE9n?= =?utf-8?B?VVc5c1ltazc3ZVc1UUd5UERIM2FwNmFjVXRiTVJuVExvMHNsVlNkQXVGajBO?= =?utf-8?B?Z01JQmtnQlNjNEVHZW95emVPeG82N3BHTS9VbVptVGUzeUhHeWQyNHJTdHZ5?= =?utf-8?B?bTdmOTBTdjZaalR3N1lYOXYrNlRrTnlXUTF1NWl1MkNpMGpTNkhyQ3hFRktx?= =?utf-8?B?TjRlYjJGQmRPTFQwSnV3RTBDZnZsb2Nyc1lEMG5NN09sVWJweC8zTlhaU3hM?= =?utf-8?B?dFVyUWRvbHZ5N3NEMFF2ajJ0RzYxN2RRVDJaSmdaZGhLOUtBQkZ6ZU9teUdW?= =?utf-8?B?ZUFyRW1uUFoyM2lBbE53K0hiK3ljZGpqWVZtU2VYbUFsckJZTGlDbDdNTkVs?= =?utf-8?B?RE1mUmdheHpzRVhkc214b1lDZUJmMG4xeFZCaCtELy9VREU5SzRBNTNSem5h?= =?utf-8?B?TEs5elp6dFVIa2dRZkpDeHRnT2VORTd5dmd5VFBGa3dKT3hUMVNkazlTSDNn?= =?utf-8?B?T0NKZXp0SjZiazQwdnRmaThXUVgvcnAxZzUvSDUrOFRIWDRiYXl6c2ZPalNj?= =?utf-8?B?a1Q0T2s2UHB0V083V3N3eXlneWNYT2ozQ1JEQVk0aUl2WkcyVFlra2RMeVRj?= =?utf-8?B?RXZESmxRNnVDODRUNmVJek9GNWN4anRmSkhvaldIMktGMHpFSGM4RWJUbHpx?= =?utf-8?B?ZC9WejFhTlZMR0Y1QXYzRU11bzdCVjhIZWYvYjN0YlB1aGFTdzYrV1dNSzRG?= =?utf-8?B?TXAzM2hvSUtDNjRkV2NMSTBaNnVvVVJSeHRSdGQ2OVVINFJ2dEhVaWJmcUxK?= =?utf-8?B?cDN0TWd3b0RiSlVPKzlDRm1jYlA2SWJqdm4wQ1dBZlVuSzNVUXNKcnR1dGcw?= =?utf-8?B?SG1SUUx1SDgzR3BaVVZFOSs4dzJkQXhXRGN4RTZDdWNycHpRYnhyYzdrem9z?= =?utf-8?B?RkFPRE5XTUdGVldXRmFmL0sxbVFHOUF0MENkUXk3NVFpYmVmMkk5QTFNa2lT?= =?utf-8?B?R3pyT3JCT3hodW5abktraTh4dERLTkQ3VWZVK2duRXNYUk41MnhOV3NrM0hu?= =?utf-8?B?UEM1RkFTREkrREFmMUY0OHZ4WEkrdk9Ka0RMMGVUdGlXU1g5THhQOUF0bmFz?= =?utf-8?B?VHo2cnNuem5kcGJ5TU52cHNQQW5YNmcyVXV2a0dtcXcxN3NrK2QxaTFod1Y0?= =?utf-8?B?MDdOVktUZDgzblpRUTAycGQyVUl0dEhmN21FOEVDUmJ5RVZ2VTg2K3RxamdX?= =?utf-8?B?VEk2VnNoNVhrNlgzVjQ0U05lMFVCbXByeVM1bWU3a0ZQOE14dzFOS21LUHps?= =?utf-8?B?TVIzRGo5NnVOOUo3Ym8xZlVCVkZScGcxYlQrUHcrR0szZDdvY214R0tSMEtI?= =?utf-8?B?alBHQzBIVlhjQ2pKbk5xNTl6T0tCcitaVDN6SXJxZkE3QVhNTlpYMVJaQVI1?= =?utf-8?B?ZmRHVHk0L1FvZTJRN2RFTnlwUXRObEZzamlydlNsNWdiZVdSOHJVamtnM2sz?= =?utf-8?B?T2JzQ0xyMFNhbzlUQkxUZklkMlBwb0RTNExPQnlTQ3UwSFh3TG5idkdoN0tM?= =?utf-8?B?VElxMlVzZk5ZVXE3TGlVK2ppOTFrTjVEaXBzNzJpTnpGWGNBUlNNdm5Belcy?= =?utf-8?B?Q1lEREh2Rjl3U1BZTGpkS0x2Q2tUY3RwemNyVm9Wd0o0ZkdCU2hIdnhDby9W?= =?utf-8?B?U1Evdm5YUkdVUTVMcjhCV2VPZ0xna2xhdXJTK2FiRDdnSDFySmJLUFQ4UWl1?= =?utf-8?B?VERsQ0Q2ZWlsN09DTms0T1htWFFyOTd0R0dFM2FBNU1ONzhQQmE2cDhxZkMv?= =?utf-8?B?M1VsSTNjemV5OWgyQUNDM1oxbEl6c01SbllBNUFIczlWVTR4b0RRd0pmSkxR?= =?utf-8?B?VlVkV0ZLQ0VGSXAvTGY5U3ZyYm9rZk1jdzJSbkdkTEdzeEMxT1BwV09QdFZR?= =?utf-8?B?QlJsMmVaWVJieVBwK292aE52YUZ4Z2VqMDhNcnVkQ0o4WGtGTks2Ty9PWmRN?= =?utf-8?B?VHNlbDllLzRQU0h6RXIyclJMcyswV3ZXUVo4T2hlTXh1bHk0SzBOdGc0ZUww?= =?utf-8?Q?urZtlVOAJaYImy7YO9upjW2ya?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1037ec46-c80c-40a4-94d5-08db09f708aa X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 17:08:01.2213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T2H/zpPWNycdjde5XooCFNhjHHjOEO8ZKbXUV3DyqsHuMSJzVpxapjOIR7BVzVuHPsYlxlDv2qM1dqEK2PoKUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5092 Hi Jan, On 08/02/2023 13:52, Jan Beulich wrote: > On 08.02.2023 13:05, Ayan Kumar Halder wrote: >> @@ -1166,8 +1166,9 @@ static const struct ns16550_config __initconst uart_config[] = >> static int __init >> pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >> { >> - u64 orig_base = uart->io_base; >> + paddr_t orig_base = uart->io_base; >> unsigned int b, d, f, nextf, i; >> + u64 pci_uart_io_base; > uint64_t please (also elsewhere as needed), assuming the variable > actually needs to survive. And if it needs to, please move it into > a more narrow scope (and perhaps shorten its name). Ack. > >> @@ -1259,8 +1260,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >> else >> size = len & PCI_BASE_ADDRESS_MEM_MASK; >> >> - uart->io_base = ((u64)bar_64 << 32) | >> - (bar & PCI_BASE_ADDRESS_MEM_MASK); >> + pci_uart_io_base = ((u64)bar_64 << 32) | >> + (bar & PCI_BASE_ADDRESS_MEM_MASK); >> + >> + /* Truncation detected while converting to paddr_t */ >> + BUG_ON((pci_uart_io_base >> (PADDR_SHIFT - 1)) > 1); > Why would we want to crash during early boot at all? And then even at a > point where it'll be hard to figure out what's going on, as we're only > in the process of configuring the serial console? I do not understand the best way to return an error from pci_uart_config(). Out of the 4 invocations of pci_uart_config(), the return value is checked in two invocations only like this. if ( pci_uart_config(uart, 0, uart - ns16550_com) )                 return true; pci_uart_config() returns 0 in case of success and -1 in case of error. But the caller seems to be checking the opposite. I could not use domain_crash() as I understand that pci_uart_config() is invoked before domain is created. > >> @@ -1532,7 +1539,12 @@ static bool __init parse_positional(struct ns16550 *uart, char **str) >> else >> #endif >> { >> - uart->io_base = simple_strtoull(conf, &conf, 0); >> + uart_io_base = simple_strtoull(conf, &conf, 0); >> + >> + /* Truncation detected while converting to paddr_t */ >> + BUG_ON((uart_io_base >> (PADDR_SHIFT - 1)) > 1); > All the same here. I can return false from here and let ns16550_parse_port_config() return. I think that might be the correct thing to do here. - Ayan > > Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 08 17:25:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 17:25:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491939.761301 (Exim 4.92) (envelope-from ) id 1pPoBg-0006v6-7E; Wed, 08 Feb 2023 17:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491939.761301; Wed, 08 Feb 2023 17:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPoBg-0006uz-3h; Wed, 08 Feb 2023 17:24:52 +0000 Received: by outflank-mailman (input) for mailman id 491939; Wed, 08 Feb 2023 17:24:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPoBe-0006ut-Ow for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 17:24:50 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c2c7801-a7d5-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 18:24:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c2c7801-a7d5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675877088; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AtAO9c64dKZK6SM8dqDsLsQe7o2Imlohacu+oBEsSsk=; b=DiatRwQn86wOFSTON8IizGE2lbeUXh515jPwv5q2nPYB983AVgRHV7ok bT3F4odtiqbIdouy+Ikjx7xm6/Hdy3zMrO3lnsDvoVtTMgEZq6ynxObpr 1/q/oyYOBZp2Ex+ty2wENd4/i/C6uk45u37B4dw86nZE4460aKwCJL/vz A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95073846 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:uBehLqMV2dNHXZTvrR2fl8FynXyQoLVcMsEvi/4bfWQNrUoj3zUCz jMXWjiObqveYmHzfdkgadixox4B65XXxoJjTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5gxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0t9+HCIV9 /A1FB4uTQmZv8KQ/qq7G8A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLokm/yzwH32fDBCt1uRoYI84nTJzRw327/oWDbQUo3XHZoOzhrGz o7A137rMDYRGoWu8Aiqq1iJuKzOgXyicqtHQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3K UYZ5y4vpqga71GwQ5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRyEu1 1KPt8PkA3poqrL9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLnW0opkuRFJA5Svfz14CrX2iqm FhmsRTSmZ0qhNNIjKe30GzpoBG1vKDpaDAt5lT+CzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHRcFJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5yYCl/CI+TfNDKq8gj9yjn9ZKme6ENlGPxL44owUuBFEfVsDE Zmaa92wKn0RFL5qyjG7L89Ej+B2mXFimz2OH8+lp/hC7VZ4TCTNIVviGALRBt3VEYve+FmFm zqhH5viJ+pjvB3WPXCMrN97waEiJnknH5Hmw/G7hcbaSjeK7FoJUqeLqZt4ItwNokigvruQl p1LchMCmQWXaLyuAVniV02Pn5u2DM0h8SpkY3xE0JTB8yFLXLtDJZw3L/MfFYTLPsQ5pRKoZ 5Hpo/m9P8k= IronPort-HdrOrdr: A9a23:vuwCd61aMQW7bujxvjSTFgqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td X-IronPort-AV: E=Sophos;i="5.97,281,1669093200"; d="scan'208";a="95073846" From: Ross Lagerwall To: CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Ross Lagerwall Subject: [PATCH] build: Make FILE symbol paths consistent Date: Wed, 8 Feb 2023 17:24:16 +0000 Message-ID: <20230208172416.725028-1-ross.lagerwall@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The FILE symbols in out-of-tree builds may be either a relative path to the object dir or an absolute path depending on how the build is invoked. Fix the paths for C files so that they are consistent with in-tree builds - the path is relative to the "xen" directory (e.g. common/irq.c). This fixes livepatch builds when the original Xen build was out-of-tree since livepatch-build always does in-tree builds. Signed-off-by: Ross Lagerwall --- xen/Rules.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 70b7489ea8..6b9269a70c 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -228,8 +228,9 @@ quiet_cmd_cc_o_c = CC $@ ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@ ifneq ($(CONFIG_CC_IS_CLANG)$(call clang-ifversion,-lt,600,y),yy) + rel_path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1))) cmd_objcopy_fix_sym = \ - $(OBJCOPY) --redefine-sym $( Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 18:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491945.761313 (Exim 4.92) (envelope-from ) id 1pPom4-0003JX-2z; Wed, 08 Feb 2023 18:02:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491945.761313; Wed, 08 Feb 2023 18:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPom3-0003JQ-Vm; Wed, 08 Feb 2023 18:02:27 +0000 Received: by outflank-mailman (input) for mailman id 491945; Wed, 08 Feb 2023 18:02:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPom1-0003JK-V7 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 18:02:26 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbc20ff0-a7da-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 19:02:23 +0100 (CET) Received: from mail-sn1nam02lp2046.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Feb 2023 13:02:10 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by SJ0PR03MB5727.namprd03.prod.outlook.com (2603:10b6:a03:2af::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 18:02:03 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%6]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 18:02:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbc20ff0-a7da-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675879343; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TCRMx2hlHmIpleezg0Gi3bHGWkCCytuSV9ZdPQuj/p8=; b=R/tt86JeC5dH14aqGBE1bRKNPJIV5qFWNTH/mUF3MIpDha4v0nFE1Ugc ikmClj3EuVQ6pBEUIWh5UtzpCWwkuxJAV3Guhv3D6TXKhwbEQqCI+Pxff jMmLqsPaE3mvleQ52hZypN0AA501WbPzf34icvj4hncbhs0J+4DT8q4dP Y=; X-IronPort-RemoteIP: 104.47.57.46 X-IronPort-MID: 95079045 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ok5WyKOaC3z+4jjvrR2MlsFynXyQoLVcMsEvi/4bfWQNrUp0hmcCy mRJXGCGOfmKZDehKoolad/jp0IFu5fWyYM3QAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5gxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uNMEVpB1 6QqFC4mMxK4jN3o6aibe8A506zPLOGzVG8ekldJ6GmDSM0AGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxvza7IA9ZidABNPLPfceRA8FckUuCu WvC+0zyAw0ANczZwj2Amp6prr6SxXyqAN5PfFG+3uNXvg2im2oLMzoTVgK3rKjio0rvYt0Kf iT4/QJr98De7neDS8LhRRSjvXistxsVSd1WVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWQSm+1/7KdvzS0fyMSKAc/iTQsSAIE55z4ptg1hxeXFNJ7Svbp0JvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:Ip0RDqHLB3jZ7Gj+pLqE0seALOsnbusQ8zAXPhZKOHtom6uj5q OTdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bHYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIObuEZoTJB/KTHCKjTKadE/OW6 X-IronPort-AV: E=Sophos;i="5.97,281,1669093200"; d="scan'208";a="95079045" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EViNpe86MhNEYIf+Q/bcq9112OJm373mHnGgFRvkEnvSSyMPc6ZFH7CXs4TBs/nT0jp/s3BP50meYyoXCnq6IkThgsSlxaNQJr/HQxE31egh3zWsqdgjrMbiy5hmHfJyRzX5/MBRLP0EdlA9hYPzG2c8yZCP8mPT5WHoy321oj37HndUvxnFBLl9aa3bf0A/vdZ2Ljeld4dIFOZXHTzpSbrfvm8BFTV66cC1LHCtFhnlhzVFm354zc+0OSI2exLqDRx1VazSxBUqG8FXV32aGVe4wchE3Vfp8ueoQ4J4m5Z93w2wnOZPxw7b+Uvt3zyirFXREE+bkdqUK3F3Ke7SlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TCRMx2hlHmIpleezg0Gi3bHGWkCCytuSV9ZdPQuj/p8=; b=CVaTov0cos0tYgJweVq9YnVez5S/wGDPEX1qd/IgENRTO/HBWicfNkN29jKSZsSYmfsjJBsH+CajemPcGLTxo2fd5DVRzKGRfWKwN98dWms7DYbOUFIuWdVHIAw6EhatNhNW+EBZMefoUVBky3++5A5ueckKiD+hy9X/b7MiHCPwB2O7sDP3QmhlkFU1Yq4Izu37G2BAe3EWKzf2vehNYOVy8YncoZkJZgkM6jj4qxTMbW5Hrc4iYD+bfuxXIbqJS0v4CAQYgHxzGVfY+ury0Fry9ZpoYofX4I+XM8DfeRsczlf+SC46F1xuwJz03Yqhn/caRE6QmfPyGtRmGj8IQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TCRMx2hlHmIpleezg0Gi3bHGWkCCytuSV9ZdPQuj/p8=; b=lGyvcvuo0dwM9dcToLXgeXto9BbaF+8vm8Jyx+GCV9YJtRnb2FWBwNKazW4/7UwQ71rCLORvUBTzl52q0CsE3qsemj22epa0DZ94XhRvmpXuzOyQ4zzJ/9KhzuE7kqntD8liPoFcDSbdyyV3tWTozDvNegtyO8WHawYOocj08wA= From: Ross Lagerwall To: Mihails Strasuns , "xen-devel@lists.xenproject.org" CC: Michael Kurth Subject: Re: [PATCH v1 1/4] common.h: Flush stdout before writing to stderr Thread-Topic: [PATCH v1 1/4] common.h: Flush stdout before writing to stderr Thread-Index: AQHZK+7uzgs/uPURN0KVH9/bFkDof67Fdcqe Date: Wed, 8 Feb 2023 18:02:03 +0000 Message-ID: References: <2e89973f61bbd6e6ebb423ec6fe7a025d5404235.1673623880.git.mstrasun@amazon.com> In-Reply-To: <2e89973f61bbd6e6ebb423ec6fe7a025d5404235.1673623880.git.mstrasun@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|SJ0PR03MB5727:EE_ x-ms-office365-filtering-correlation-id: ddffba5c-aad7-4ab4-8c2e-08db09fe9575 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X5DYZH+DZixcWqcCz8OQbbxGBORYiZT+n3mmGdEo6z4Tjezg/HUpO1Y2POtBkxWNYYpcRv8uPTHadRNBwtpHYO/tU9KsyFPqs4Ac5/mjibVlQcY8MJsNeah0OrzbCLU9PJfFqAl7L+R6KWh+j/53RHSg03MfMy9RkO1jtM5grUkHzTbbkGS2OPA3Yv1a/JN87L/6Wrc2YR6HwucMY6pPXcYURuraAKDS8DlKs6kNYo34BSCAFPNelG9L/+EHt2C5vTg8fkYIzZlYkwUFQ7y9SE2PkV2/TxiEyONzlCrNfzhDDHw3nkWTedzIwU1b7VPvJZ0uFe5J86PjzPcBE1dwtEfLEM4PUmcq0jo+wkhLx3jEoDiia6QM3i7OLZrqEBoTukkaUpzFpnDGRK6qJ/bELYiX+RS/+vbQ6j1iYMX4EVlh5L38grXEYJCzg6GZY+f6o+mli5m7/fqkozfH9MhUPEucj01EdXvL7sNNpqGij8DWYeeka8Z5Uxst2DOcYV0RMlPtQ3XM1l+q2Z9SjA2ko+GgyW7ZtfLE216RIVeQa+Q1T1NzdoDwp6jN/0WUtIKzY+Niyzs3giDhbNCG7dXTvTOPucDl4MbulP12aG53dIGVVNKfP5T/MB755SPoIsCu2QsRr157GFSrmH52MWxVMABJEZa1svCB5oEXkKMiGI6UUD2Un151jaQhZx1ObonY3At818ejZDFxKIcYevHpNg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199018)(53546011)(6506007)(52536014)(9686003)(26005)(186003)(316002)(8936002)(33656002)(38070700005)(2906002)(55016003)(71200400001)(83380400001)(7696005)(110136005)(5660300002)(44832011)(478600001)(86362001)(66476007)(66446008)(66556008)(64756008)(66946007)(91956017)(76116006)(41300700001)(4326008)(8676002)(82960400001)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ty55VzAT7Br65oc2Y1Qd4aj8p9bL2jxN0hkRMInxdxykTlbvNYTj3Ttfe7?= =?iso-8859-1?Q?k6Q7CZ5Ri7FS0qUVSTL8j/YaOcuQRXxBjdiuynPqv0/rRUTEg2ELNECJDB?= =?iso-8859-1?Q?SD8WQaLcWZMS5MncN963jSVxrUX6ebKRu4oApRBVYcysc2WrYiI70HOsog?= =?iso-8859-1?Q?hMd5kfjUcZM4233QEOJrqnt6xJ+mD2dPjK0VJVfC7uwoOeUG9WgtoAgsKw?= =?iso-8859-1?Q?ZOhGBtBthEIndwUYRwaGjorlO4h9w7WH3Efsol5ToAFwBY76upnZSGugug?= =?iso-8859-1?Q?P12sPeYO2fnfrRKHkGnv460/QK6ElBFPYJZkDWO4LnXsixPZupIK6lfJ51?= =?iso-8859-1?Q?J/R3vd+4IEHR7xhLv8T3pb8VwrmpVHSRqjNU5SfHN6FwoICr2J4+9xSbKd?= =?iso-8859-1?Q?bYcmvpZ1EOvDDc/uuIy2fmTAspMo5ZkM+hrv9o4iD9tKZWTjBM9zYIuHug?= =?iso-8859-1?Q?C5iAwdzP6h6GZeqKknpD+Lave5nLUiMFh8Owpk+YzIWCi7x/SAmZW/UaKk?= =?iso-8859-1?Q?uwznP0Sr5J+U84wmNtmTOlRuvPX/WmyzZNxppikss328RbUNGcc58XlHP+?= =?iso-8859-1?Q?7kbr/BxTwizqkZKR04DKXhJ1jIEyubdqx/JbgfiqOv+bzMgUGRJY7S+aV7?= =?iso-8859-1?Q?LyqI1QsvyfQxL6Hi66526uS7tCCvE/T1E8tK2gLdnnt6hAaN1KVN/bgTMZ?= =?iso-8859-1?Q?ATfNYtBsKrMrtm8GpdYf+j+TB9m4u6nZBaWtYDzVAr9bq/ik+d9YqBeg5x?= =?iso-8859-1?Q?ylK1Y4gQP6Hp5zbaaT3FxCAnhtOeGi4lDMgFeRAEnB5og8S06zaUWIs6Pb?= =?iso-8859-1?Q?U/zJjo5bN/lvmu4K5rCxWCyrxreE89OUjhrVDGcymb6oASyb947mhMEcb8?= =?iso-8859-1?Q?RvH4yzSgNOzMlP0ucyEGU5rSOXFdjs5B8mq0gwGivQbtyqQX2EtnOGAnav?= =?iso-8859-1?Q?UXx9oLtVctv8KJj17kTFwGaDPKmp4Ho3gTvqi8sgPwUYmxSRmGb3RYZFYq?= =?iso-8859-1?Q?pmc47klKPagceUXNTuVzpcnoJuMUYi8AxUZtwDzOw3ak1aCntxsKwuLJI6?= =?iso-8859-1?Q?VJJ11WWoqfGk7NqIq1Ub0fcsHCgabXGZBSSNriAazIvhyBVdq6SrIbT3cP?= =?iso-8859-1?Q?rQd/ubMRVPBYlGh5B/lotmNwdf6TYMi7CcedLPxemXapVy/TNgPTxBriHy?= =?iso-8859-1?Q?LCli1TYh/JbPu1PYrivcz0jyuT74cyPxz135lBYlXTyOAjS1EkO2i+hq+X?= =?iso-8859-1?Q?tc3QK8OG/yYvLkKwjR0As3OM6djLQdGF0L1kTHAXWzLN1pBKTLAUBpsI1A?= =?iso-8859-1?Q?4QaV8bCgMkKIHsXRAtvto3Jhz9CGd9vtKsB/WvyelJiXCz9uRNfHewhSQQ?= =?iso-8859-1?Q?Cqvnnmi0aMFjDaX8o/lDMOgEuqUig76u4oVTmduqoKnWvjSct87vz5QLKt?= =?iso-8859-1?Q?9eYg9KV9C4zf6eCtqK0ksFONdqlDuNSDD67sBCQkRqIHTP3T/DhMhCak1Y?= =?iso-8859-1?Q?navt7gnlGO95Vnay+SGyzMHAzie0IkZiVoy3XDrdWrIPmL85wvrg38/yuj?= =?iso-8859-1?Q?skoogFWgmMm0w5jTjtcWCsinDUSuNqomcv3gusnPgEEFFzHZ4DzLrCqywV?= =?iso-8859-1?Q?N/IYLog0QcBayWkiK2IEnHhUJTPmaBW1sk?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: B7M9pyHJeM95OMV9PF0rqw4aLtixBNiRAZiItlB5zbd/Af0FAuUTt6b8rmIw9SUy9U77vwwUN+mwHqm5ytN9h0cAN+Fs/64odjP9gSRPk+tATTXUs+2fMiLmmzjhJqsVATKBvtO9v1FhTkujigrcKspPFiTTC8INCf4LRAiBgZTfra/kXviUAG63D0svR44gn7hEhH5o2YSyidZOMutvmMM03buYMjAzzzFsYdT40R6hwkc6zg0gX/JMkLIXx+jKH3eG9W1cre1zueif3HJPhmit+jTwvEpPTlTGhihLedVuZrOOxyBtF1rKvMPK/Fu4Dv7euYMHFPHVztK9+Jp7EDpEMRXzxXSOUp4+oIla7cwXEFI12gmvzMqeHzuGHgfBaOg2mIN34a+rGlRyVcXHoz8akPPi5xMlXhbwXiQUlJcmo8YfqMDoRxBoy3Mx8bqafs9+2dYIfoOFWHo/gh1Vx/VjrnrhMlUzZSwwopVFP4z12cohtM7OvPicoHlvqZ0duoMcPF4xHEi6xFd7Sm4dDd7SJ/cg2AQIYwHbY/KhchWcE58id1IejU3OpZcZIyeSZgkf5c7iumendvkklvlID/ymVrcIdM4E7kq0ceWR4tzB6XDL7vFNXSQUr9FgXfuQuVZNNOCqE4OPwGHScfI7/yMzB4Zyjs2rA23iz0HoGVNUTnIKq3CPDE+6xxcsN0UCi/nxuhAlYWrJmVZBqpQgzwIj28SKAB6WfzM2n8l3/CHGjEviFEK4oY3S4TB/g/RJnurwFRw4sriAJbgfmaQAwJcwXxwqr2B3hm0U91oF2ObBihKIVPTk6SHMaS2YXgF7 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddffba5c-aad7-4ab4-8c2e-08db09fe9575 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 18:02:03.6596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QC6UNUYtfijc4MjA5UovWCoVQ5aYTtvkMHuZgbzGRFztNHXvhFXeycZ+3QMDqwPxMXYzWoUwX++DqEhjSUBbDQKfX0vvGgSS+7ismVnqM2Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5727 > From: Xen-devel on behalf of Mih= ails Strasuns =0A= > Sent: Thursday, January 19, 2023 10:13 AM=0A= > To: xen-devel@lists.xenproject.org =0A= > Cc: mstrasun@amazon.com ; Michael Kurth =0A= > Subject: [PATCH v1 1/4] common.h: Flush stdout before writing to stderr = =0A= > =A0=0A= > Flush existing debug messages before writing an error to stderr.=A0 stder= r=0A= > is usually unbuffered and stdout is usually buffered. This results in=0A= > odd looking output when an error occurs and both stderr/stdout are=0A= > printed on the same console/file. More precisely, the error message is=0A= > printed in the middle of previously emitted debug messages.=0A= > =0A= > Signed-off-by: Michael Kurth =0A= > ---=0A= > =A0common.h | 1 +=0A= > =A01 file changed, 1 insertion(+)=0A= > =0A= > diff --git a/common.h b/common.h=0A= > index 02c9b7b..9a9da79 100644=0A= > --- a/common.h=0A= > +++ b/common.h=0A= > @@ -10,6 +10,7 @@ extern char *childobj;=0A= > =A0=0A= > =A0#define DIFF_FATAL(format, ...) \=0A= > =A0({ \=0A= > +=A0=A0=A0=A0=A0=A0 fflush(stdout); \=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 fprintf(stderr, "ERROR: %s: " format "\n", child= obj, ##__VA_ARGS__); \=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 error(2, 0, "unreconcilable difference"); \=0A= > =A0})=0A= > -- =0A= > 2.38.1=0A= =0A= Reviewed-by: Ross Lagerwall = From xen-devel-bounces@lists.xenproject.org Wed Feb 08 18:05:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 18:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491953.761324 (Exim 4.92) (envelope-from ) id 1pPooy-00042C-GM; Wed, 08 Feb 2023 18:05:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491953.761324; Wed, 08 Feb 2023 18:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPooy-000425-Db; Wed, 08 Feb 2023 18:05:28 +0000 Received: by outflank-mailman (input) for mailman id 491953; Wed, 08 Feb 2023 18:05:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPoox-00041z-7F for xen-devel@lists.xen.org; Wed, 08 Feb 2023 18:05:27 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 271b7ce0-a7db-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 19:05:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 271b7ce0-a7db-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675879525; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6GFlkZ7+0oTK0eTY8I2TZ0OsKy8DTPzIbsaB6hzh+UQ=; b=Ad/bRzp88iwwHKMOY9Y6bq+E23ynEmDbfQL3y6iwquhcYQg2MPLG2suj Cg4T8zwmbT3KuzkwX0e78p1KCzx83Mk7+1ZJ9JeAZSHskdHR0SQ6TCJCH JYezVm+iuB/nBVje6L+Y6yfs6V9p5BbuBU8dMVEufaOBy4bIqs3JzGig5 4=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96638636 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:hEMwmKuox9I2ik6kSEjD9gcxXufnVFleMUV32f8akzHdYApBsoF/q tZmKT3Vb66JNzOgKo9wbI2wph8EvsTVzoBjSwNupS89ECtB+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWGxyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMweClQbAGAityM/vGaWtcv1p0KIsvOM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7Wydfs0nToaM47nLMxQh1+LPsLMDUapqBQsA9ckOw9 zyYpDSnWU9y2Nq322K18Firl+/0rQyhAqMiKpjl7NtnjwjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7GRqirxasvRkaQdNcVfI77AKlzbDd6AKUQGMDS1Z8hMcO7ZFsA2Zwj xnQwo2vXGY02FGIdZ6D3ueN8DGjOiUrF1FBRD86DltcytfhhY5m23ojUe1fOKKyi9T0HxT5z DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab/P+SVBU7nAeGsxWpzZn2Ip zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3Y1R/HNFBz3oRZPmLy8BxkgTHqFyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27Ca2LP4YQPMUrK1HvEMRSiai4hTiFfK8EyP5XB HtmWZz0USZy5VpPnFJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYe5tDbd6VchgtPnsiFyMo 75i2z6il003vBvWPnOGrub+7DkicRAGOHwBg5UGLbDfelU4SAnMyZb5mNscRmCspIwN/s+gw 513chYGoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:K15wR6nlYRGaflI5jvXKVzCIa1fpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.97,281,1669093200"; d="scan'208";a="96638636" From: Ross Lagerwall To: CC: Konrad Rzeszutek Wilk , Andrew Cooper , , Ross Lagerwall Subject: [PATCH] create-diff-object: Handle missing secsym for debug sections Date: Wed, 8 Feb 2023 18:04:57 +0000 Message-ID: <20230208180457.800671-1-ross.lagerwall@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Certain debug sections like ".debug_aranges" when built with GCC 11.2.1 are missing section symbols (presumably because they're not needed). Instead, of segfaulting, simply don't include them if they're missing. Signed-off-by: Ross Lagerwall --- create-diff-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-diff-object.c b/create-diff-object.c index a516670..780e6c8 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf) list_for_each_entry(sec, &kelf->sections, list) { if (is_debug_section(sec)) { sec->include = 1; - if (!is_rela_section(sec)) + if (!is_rela_section(sec) && sec->secsym) sec->secsym->include = 1; } } -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 18:51:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 18:51:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491960.761334 (Exim 4.92) (envelope-from ) id 1pPpXV-0001Hh-Us; Wed, 08 Feb 2023 18:51:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491960.761334; Wed, 08 Feb 2023 18:51:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPpXV-0001Ha-SH; Wed, 08 Feb 2023 18:51:29 +0000 Received: by outflank-mailman (input) for mailman id 491960; Wed, 08 Feb 2023 18:51:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPpXU-0001HU-Vf for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 18:51:28 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95999630-a7e1-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 19:51:25 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 318Ip1Px061004 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 8 Feb 2023 13:51:07 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 318Ip1ro061003; Wed, 8 Feb 2023 10:51:01 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95999630-a7e1-11ed-93b5-47a8fe42b414 Date: Wed, 8 Feb 2023 10:51:01 -0800 From: Elliott Mitchell To: Jan Beulich Cc: Anthony PERARD , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Message-ID: References: <20230207160948.3169-1-anthony.perard@citrix.com> <7e01f840-1d42-f31e-4471-ee06820b4b31@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e01f840-1d42-f31e-4471-ee06820b4b31@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Wed, Feb 08, 2023 at 09:02:35AM +0100, Jan Beulich wrote: > On 07.02.2023 19:02, Anthony PERARD wrote: > > > > I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" > > failing to build while "libxlu_cfg_l.[ch]" are been regenerated is > > probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of > > targets. > > > > If for some reason we have: > > libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c > > > > Then make seems to take two parallel decision: > > When building libxlu_cfg_y.o: > > libxlu_cfg_l.h is newer than libxlu_cfg_l.l > > -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o > > When building libxlu_cfg_l.o: > > libxlu_cfg_l.c is older than libxlu_cfg_l.l > > -> we need to generate libxlu_cfg_l.c first > > Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been > > updated do to the parallel build of libxlu_cfg_l.o. > > > > I can easily reproduce the issue with: > > touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; > > touch libxlu_cfg_l.h; sleep .1; make -j > > And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. > > Interesting. In my somewhat similar experiments I found that an issue > exists only when one of the .c files is missing. Things looked to work > properly when both were there, but one was outdated. Clearly that's > yet more surprising behavior than, as you appear to observe, the issue > simply being tied too "needs updating". The actual problem is flex and bison output both files at the same time. One process sees all of its prerequisites are up to do and therefore proceeds to the next step. A second process sees an out of date prerequisite, and starts to run flex which wipes out the prerequisite of the first process. Crucially libxlu_cfg_y.o does NOT depend on libxlu_cfg_l.c, therefore GNU Make is allowed to proceed with building libxlu_cfg_y.o even if libxlu_cfg_l.c is out of date. The problem is the rule to update libxlu_cfg_l.c ALSO updates libxlu_cfg_l.h as a side-effect. As such libxlu_cfg_y.o needs an order-only dependency (assuming GNU Make syntax is allowed) on libxlu_cfg_l.c, so the two rules DON'T run in parallel and cause havoc. > > I don't know how to properly fix this yet. > > Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is > > supposed to be grouped targets. But that's is maybe fixed in 4.4. > > Well, in my tests while 4.4 has fixed one issue with intermediate files > affecting the behavior here, the issue we're possibly running into is > still there. I've sent an inquiry to bug-make@gnu.org. I do not believe this is a bug in GNU Make. Merely double-output rules cause precisely this sort of trouble in Make when run in parallel. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Feb 08 19:41:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 19:41:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491969.761345 (Exim 4.92) (envelope-from ) id 1pPqJe-00079x-Lo; Wed, 08 Feb 2023 19:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491969.761345; Wed, 08 Feb 2023 19:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqJe-00079q-J8; Wed, 08 Feb 2023 19:41:14 +0000 Received: by outflank-mailman (input) for mailman id 491969; Wed, 08 Feb 2023 19:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqJc-00079e-IW for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 19:41:12 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84984beb-a7e8-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 20:41:04 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D89465C0056; Wed, 8 Feb 2023 14:41:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 08 Feb 2023 14:41:01 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 14:40:58 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84984beb-a7e8-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675885261; x= 1675971661; bh=tSC+d5CSw18yD+fR/I858Vj+qQlU6DNIY9nwulJK/Po=; b=t +Ah9UYYIaK3ZiIav0B2AlPaS/8zSPUQdL+O9HINaX7oV3hIPAD/cPhM/jArFwYHP BtRtvv/t7X+2TDP+PgNsppc7LpycL0R9ZiDRXx7dpxnzoNWVhFwcQXQdt6hvU4nQ HPLegS+XLzCyvfDCjxSvsgAGt5LIrnDWcy2LYiv+zVuJXK2fe/7Mv192nV1ULqPU QewruBqpSkHY+V8C9GErelUvhg7c5m+2sIXtUtvk5TMZWwlt4Hmj750WAtqOifh8 luvsjcqNECAb2DoikQubMMOAJ9waGwv/D7nlxjMIP4n6dIIuo9W7LiKSYPn8G3jb m+1jAg1RtiUzqK2s6uHfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675885261; x=1675971661; bh=tSC+d5CSw18yD+fR/I858Vj+qQlU 6DNIY9nwulJK/Po=; b=aPigWqCpUD8CMnMH655bc7WKkpHCXwZ04SZsMglyNVTD q4ppWg48QYtafTj3t7x1iVllRzEC0n3StvK6Vl+w29aNPdfqOYRxsUcFWazjS6Wt InwuiFMFWEyKHoxGYmvkRCFG/vZXlAGlAUshHs07svAXOSdVpU8cZd9Dxgc2a2y9 mTRzaJuAfEUQZ3szytKlCiiBoiUC8oz7vVOjCn+nk7SFF/rpfFNOJk+QW4XlmXsY AXnZLeCHtAdjM0b1/H1A7UwXsJYUe6mtvSQtfhkOW1eVsL5aHFIieDEvX9s0eU9B vswbju3/60QYcrrzN8N/E++UBq3IT4ol5Q1+I6weGQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdeugffgteevffevkeefveekfeet heefteffgefgvdekgfefgeelveetteffveefnecuffhomhgrihhnpehgnhhurdhorhhgpd hinhhtvghlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 8 Feb 2023 14:19:46 -0500 From: Demi Marie Obenour To: Julien Grall , Jan Beulich Cc: Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , Roger Pau =?utf-8?B?TW9ubsOp?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" , xen-devel@lists.xenproject.org Subject: Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Message-ID: References: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> <3f3c358e-02b9-94e0-0b06-8a96ff92519b@suse.com> <1770bab7-3e25-d611-1d3f-58c02a2f7492@xen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i88wNZm7oENdIBvm" Content-Disposition: inline In-Reply-To: <1770bab7-3e25-d611-1d3f-58c02a2f7492@xen.org> --i88wNZm7oENdIBvm Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 8 Feb 2023 14:19:46 -0500 From: Demi Marie Obenour To: Julien Grall , Jan Beulich Cc: Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , Roger Pau =?utf-8?B?TW9ubsOp?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" , xen-devel@lists.xenproject.org Subject: Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS On Wed, Feb 08, 2023 at 08:26:37AM +0000, Julien Grall wrote: > Hi, >=20 > On 08/02/2023 07:40, Jan Beulich wrote: > > On 08.02.2023 05:51, Demi Marie Obenour wrote: > > > --- a/xen/drivers/passthrough/pci.c > > > +++ b/xen/drivers/passthrough/pci.c > > > @@ -11,7 +11,7 @@ > > > * more details. > > > * > > > * You should have received a copy of the GNU General Public Licens= e along with > > > - * this program; If not, see . > > > + * this program; If not, see . > > > */ > > > #include > >=20 > > At the example of this file: While the above matches $subject, ... > >=20 > > > @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) > > > * Device [8086:2fc0] > > > * Erratum HSE43 > > > * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset > > > - * https://www.intel.com/content/www/us/en/processors/xeon/x= eon-e5-v3-spec-update.html > > > + * https://www.intel.com/content/www/us/en/processors/xeon/x= eon-e5-v3-spec-update.html > > > */ > > > { PCI_VENDOR_ID_INTEL, 0x2fc0 }, > > > /* > > > * Devices [8086:6f60,6fa0,6fc0] > > > * Errata BDF2 / BDX2 > > > * PCI BARs in the Home Agent Will Return Non-Zero Values D= uring Enumeration > > > - * https://www.intel.com/content/www/us/en/processors/xeon/x= eon-e5-v4-spec-update.html > > > + * https://www.intel.com/content/www/us/en/processors/xeon/x= eon-e5-v4-spec-update.html > > > */ > > > { PCI_VENDOR_ID_INTEL, 0x6f60 }, > > > { PCI_VENDOR_ID_INTEL, 0x6fa0 }, > >=20 > > ... this doesn't (and would rather belong in the earlier patch). > >=20 > > As to $subject: Wouldn't it be more logical to replace the license boil= er > > plates by SPDX headers instead? This was done to some degree on Arm > > already, but I haven't gone check why it was done incompletely there. >=20 > Skimming through xen-devel, it sounds like it was most likely a lack of > time. I think it would be a good idea here to switch to SPDX. >=20 > That said, I can appreciate that Demi may not want to take on that works.= So > I would be happy to give a try if no-one else wants to. Should I drop this patch then? I don=E2=80=99t have time for the SPDX chan= ge, sorry. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --i88wNZm7oENdIBvm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPj+sgACgkQsoi1X/+c IsHZKQ/9GRm4WqJ9yhAkeDjsG/vAOsGx71MMKrZK7IBB6rbCuuJK0PK2cOnt6ldu zcmeUDPFcFKaMMIZQOskTMiahbTDECW5k19swgyF9shX6PFmxPur4sGuneJ0NzUv 4qzrM/OzCnNygNlp8YAyOxmJlwVSAv9nm1dMArupnGiWhNRDBbO2cYY2KtLWOM6y tHQduBcDg0cmJqj3/h/P+fYggamvKzXFBRgcyldvxa2DS+6tlHWKqWxIdnaaoTnR 3Q8kOXPiWc0fEZIEfR/5j2T02Gg9M4/gNfL5AXZXFTZUdfWhtjiArjcOFZjYLxD1 X8Aym5hCE4ntmFrNO0t6rj1+ylstXRIC6TC1mOk0ZVPMijVMSVuK+9YdgsB62jyy qAuG0K9Ej0v6Vgd6Plb3PzvEyQVxxP8qGyoKHjZoq1xYaCNJ8eAbqcB0eh1fR+8E o0RHPJOtXmZ1XELOTYxXHuMTpaa1+7fpWrjB3gCRICeG9NSvyj/IB/kXgjB0w/os Gh+TQRKSbvucaISxb3Bd/XNXEE2McD3k2+uiJpKJqMPnjUyImCrN9fZI4/jstb8j LQTRiNiL+MEjwTx1nV1aFmKaSO0J5dLo4kKKzf5UUZ6YgBDqvEU9rzYNooW9gDcQ gMqkeerUC8Jlhy3XLWbzBuekVqO8RT/peCHQoApEx4XGLAMT1o0= =Y2dQ -----END PGP SIGNATURE----- --i88wNZm7oENdIBvm-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491983.761357 (Exim 4.92) (envelope-from ) id 1pPqxA-0003iH-VY; Wed, 08 Feb 2023 20:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491983.761357; Wed, 08 Feb 2023 20:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqxA-0003iA-SD; Wed, 08 Feb 2023 20:22:04 +0000 Received: by outflank-mailman (input) for mailman id 491983; Wed, 08 Feb 2023 20:22:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqx9-0003i0-J6; Wed, 08 Feb 2023 20:22:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqx9-0005DA-HA; Wed, 08 Feb 2023 20:22:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPqx9-0001kC-2e; Wed, 08 Feb 2023 20:22:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPqx9-0005SZ-26; Wed, 08 Feb 2023 20:22:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3ooPXi8FpxWOZpuTydm1Jo2a20M2ADsl2GTUWb5+1+U=; b=t9fV7Z/ErHqkuNdOUTPrCWNXnT BR+K2utUDFK6RxH2DiOkb3saGZFveJz7/LWDU3SCJo7STnc59zlNQwIZT4SO0/sKhGY9IZC6FaR1G yR4y+sjGedBvXuoJXok2HbuS0lFib4KN+7z/WXwY4UGFb2GErR1nKAogtWNn92bNViss=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176498: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=513c1a3d3f1982fb850c910937099525b0d35e24 X-Osstest-Versions-That: linux=05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a From: osstest service owner Date: Wed, 08 Feb 2023 20:22:03 +0000 flight 176498 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176498/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176434 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176434 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176434 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176434 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 176434 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176434 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 513c1a3d3f1982fb850c910937099525b0d35e24 baseline version: linux 05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a Last test of basis 176434 2023-02-07 00:16:17 Z 1 days Testing same since 176498 2023-02-07 17:26:36 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Shiju Jose Steven Rostedt (Google) jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 05ecb680708a..513c1a3d3f19 513c1a3d3f1982fb850c910937099525b0d35e24 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:58:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491993.761367 (Exim 4.92) (envelope-from ) id 1pPrWa-0007kk-Pk; Wed, 08 Feb 2023 20:58:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491993.761367; Wed, 08 Feb 2023 20:58:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWa-0007kd-Mw; Wed, 08 Feb 2023 20:58:40 +0000 Received: by outflank-mailman (input) for mailman id 491993; Wed, 08 Feb 2023 20:58:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWZ-0007kX-EV for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 20:58:40 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59cfc279-a7f3-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 21:58:35 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 196075C0120; Wed, 8 Feb 2023 15:58:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 08 Feb 2023 15:58:34 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 15:58:29 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59cfc279-a7f3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1675889914; x= 1675976314; bh=aDqIdNUEWMR7zz0ZB/+K8g9s2Ud5Eed4yTJbvPfrQnE=; b=E tPyoGoda7+iTe4VfJN6ILfYjkZanD/D0xWQ9fgLMRtFOTlLWdILlT3EOJF90Tu6E Ka91zzzDlUpUrkcK9hHLCCKJbazZjFuhOzkRtVs/RWtZe1ryxSJwa3AF7YMLrjcT ISpMGWvcXYpyjWFjxw1cUNAOv+jxMxLRoMD/kpJVrfhTuIP1ROiNTnzD+ZvmnTmc hhipjFA4SVM6tmDOCgWwtteUN8fI03zI8k0hMJ8tGM2ROlKfpE3CDjYuLT0D28zt rFTY8vPD9QmVSJObj//4UlIZHSraIh7pWScefbX/UA2xg6Yw8tNhKA8xhk3h8WMg b0YgUrbjoj3gdoS5nZIOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1675889914; x=1675976314; bh=aDqIdNUEWMR7zz0ZB/+K8g9s2Ud5Eed4yTJ bvPfrQnE=; b=srEXO2hfPXTNHECHHnZ8nZK/tP9vfJpbxpMIvIGrx27dGI4wgQQ KrXerOxsj9M9IGMThOxkqt9KidxVYCBKUoLYx42ZsXFgQNIFM57O3yLeP/9h3u3W DOZVWS0/jzX9wg+bJx6u4sr4L924JzzZ2qRJPjnNT2J9xGRzIOxj2DHJazD8LQRn E5v0IlSEcH8l+izNp9t5ybDcgXC8Ml1iJ2Ie6EYTh9tlbDtsOPfJix390to9m8yt jIJ9InV5Rb5R4k8pfOiS7k3TbeFf9HrNN6m7C6vjatnyjE9YFXZcUh1iqwU7ITRw tpG93Sah5sPpHTPHbJE89VwU96mwQWzDNxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdehieduudefleejjeeuleeiuddtieet teevtdfhfedtiefhvdffleehudefgfevnecuffhomhgrihhnpehhthhtphhstghophihih hnghegqddqtghrvgguihhtshdvqdgtohhnfhhighdrmhhknecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvth hhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Daniel De Graaf , Quan Xu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant , Elena Ufimtseva , Nick Rosbrook , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jun Nakajima , Kevin Tian , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh Subject: [PATCH v2 0/4] Stop using insecure transports Date: Wed, 8 Feb 2023 15:58:20 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Demi Marie Obenour (4): Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http:// with https:// Miscellaneous and documentation: Only use TLS-protected transports GPL License Boilerplate: Switch from HTTP to HTTPS COPYING | 4 ++-- CREDITS | 2 +- Config.mk | 20 +++++----------- README | 8 +++---- SUPPORT.md | 2 +- automation/build/centos/CentOS-7.2.repo | 8 +++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/README.remus | 2 +- docs/conf.py | 2 +- docs/features/feature-levelling.pandoc | 4 ++-- docs/features/intel_psr_cat_cdp.pandoc | 2 +- docs/features/intel_psr_mba.pandoc | 2 +- docs/features/migration.pandoc | 2 +- docs/features/sched_credit.pandoc | 4 ++-- docs/features/sched_credit2.pandoc | 6 ++--- docs/features/sched_rtds.pandoc | 4 ++-- docs/misc/amd-ucode-container.txt | 4 ++-- docs/misc/arm/booting.txt | 4 ++-- docs/misc/arm/passthrough.txt | 2 +- docs/misc/kconfig-language.rst | 14 +++++------ docs/misc/livepatch.pandoc | 2 +- docs/misc/netif-staging-grants.pandoc | 10 ++++---- docs/misc/pvcalls.pandoc | 18 +++++++------- docs/misc/status-override-table-spec.fodt | 2 +- docs/misc/vtd-pi.txt | 6 ++--- docs/misc/vtd.txt | 4 ++-- docs/misc/xen-env-table-spec.fodt | 2 +- docs/misc/xenstore-paths.pandoc | 2 +- docs/misc/xl-psr.pandoc | 2 +- docs/misc/xsm-flask.txt | 2 +- docs/process/release-technician-checklist.txt | 2 +- docs/process/sending-patches.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- m4/README.source | 4 ++-- m4/ax_compare_version.m4 | 4 ++-- m4/ocaml.m4 | 2 +- m4/pkg.m4 | 4 ++-- m4/systemd.m4 | 2 +- misc/coverity/model.c | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++------- stubdom/configure.ac | 24 ++++++++++++------- stubdom/grub.patches/10graphics.diff | 4 ++-- stubdom/grub.patches/61btrfs.diff | 4 ++-- stubdom/vtpmmgr/tpmrsa.c | 6 ++--- stubdom/vtpmmgr/tpmrsa.h | 4 ++-- tools/configure | 16 ++++++------- tools/console/client/main.c | 2 +- tools/console/daemon/io.c | 2 +- tools/console/daemon/io.h | 2 +- tools/console/daemon/main.c | 2 +- tools/console/daemon/utils.c | 2 +- tools/console/daemon/utils.h | 2 +- tools/debugger/gdbsx/gx/gx.h | 2 +- tools/debugger/gdbsx/gx/gx_comm.c | 4 ++-- tools/debugger/gdbsx/gx/gx_local.c | 2 +- tools/debugger/gdbsx/gx/gx_main.c | 2 +- tools/debugger/gdbsx/gx/gx_utils.c | 2 +- tools/debugger/gdbsx/gx/xg_dummy.c | 2 +- tools/debugger/gdbsx/xg/xg_main.c | 2 +- tools/debugger/gdbsx/xg/xg_public.h | 2 +- tools/examples/xeninfo.pl | 4 ++-- tools/firmware/Makefile | 2 +- tools/firmware/etherboot/Makefile | 6 +---- tools/firmware/etherboot/README | 23 +----------------- tools/firmware/hvmloader/32bitbios_support.c | 2 +- tools/firmware/hvmloader/Makefile | 2 +- tools/firmware/hvmloader/cacheattr.c | 2 +- tools/firmware/hvmloader/e820.c | 2 +- tools/firmware/hvmloader/hvmloader.c | 2 +- tools/firmware/hvmloader/mp_tables.c | 2 +- tools/firmware/hvmloader/optionroms.c | 2 +- tools/firmware/hvmloader/ovmf.c | 2 +- tools/firmware/hvmloader/pci.c | 2 +- tools/firmware/hvmloader/pci_regs.h | 2 +- tools/firmware/hvmloader/pir.c | 2 +- tools/firmware/hvmloader/pir_types.h | 4 ++-- tools/firmware/hvmloader/rombios.c | 2 +- tools/firmware/hvmloader/seabios.c | 2 +- tools/firmware/hvmloader/smbios.c | 2 +- tools/firmware/hvmloader/smbios_types.h | 4 ++-- tools/firmware/hvmloader/smp.c | 2 +- tools/firmware/hvmloader/tests.c | 2 +- tools/firmware/hvmloader/util.c | 2 +- tools/firmware/rombios/32bit/32bitbios.c | 2 +- tools/firmware/rombios/32bit/mkhex | 2 +- tools/firmware/rombios/32bit/pmm.c | 4 ++-- .../firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- .../rombios/32bit/tcgbios/tpm_drivers.c | 2 +- tools/firmware/rombios/32bit/util.c | 2 +- tools/firmware/rombios/32bitgateway.c | 2 +- tools/firmware/rombios/apmbios.S | 2 +- tools/firmware/rombios/rombios.c | 6 ++--- tools/firmware/rombios/rombios.h | 2 +- tools/firmware/rombios/tcgbios.c | 2 +- tools/firmware/vgabios/COPYING | 2 +- tools/firmware/vgabios/README | 10 ++++---- tools/firmware/vgabios/biossums.c | 2 +- tools/firmware/vgabios/clext.c | 2 +- tools/firmware/vgabios/vbe.c | 4 ++-- tools/firmware/vgabios/vbe_display_api.txt | 8 +++---- tools/firmware/vgabios/vgabios.c | 10 ++++---- tools/fuzz/README.afl | 2 +- tools/golang/xenlight/xenlight.go | 2 +- tools/hotplug/Linux/block-common.sh | 2 +- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/hotplug/Linux/external-device-migrate | 2 +- tools/hotplug/Linux/launch-xenstore.in | 2 +- tools/hotplug/Linux/locking.sh | 2 +- tools/hotplug/Linux/logging.sh | 2 +- tools/hotplug/Linux/vif-common.sh | 2 +- tools/hotplug/Linux/xen-hotplug-common.sh.in | 2 +- tools/hotplug/Linux/xen-network-common.sh | 2 +- tools/hotplug/Linux/xen-script-common.sh | 2 +- tools/hotplug/Linux/xendomains.in | 2 +- tools/hotplug/NetBSD/locking.sh | 2 +- tools/include/libxenvchan.h | 4 ++-- tools/include/libxl.h | 2 +- tools/include/xencall.h | 2 +- tools/include/xenctrl.h | 2 +- tools/include/xendevicemodel.h | 2 +- tools/include/xenevtchn.h | 2 +- tools/include/xenforeignmemory.h | 2 +- tools/include/xengnttab.h | 2 +- tools/include/xenguest.h | 2 +- tools/include/xenhypfs.h | 2 +- tools/include/xenstore.h | 2 +- tools/include/xenstore_lib.h | 2 +- tools/include/xentoolcore.h | 2 +- tools/include/xentoolcore_internal.h | 2 +- tools/include/xentoollog.h | 2 +- tools/libacpi/build.c | 2 +- tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 +- tools/libfsimage/fat/fat.h | 2 +- tools/libfsimage/fat/fsys_fat.c | 2 +- tools/libfsimage/iso9660/fsys_iso9660.c | 2 +- tools/libfsimage/iso9660/iso9660.h | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 4 ++-- tools/libfsimage/ufs/fsys_ufs.c | 2 +- tools/libfsimage/xfs/fsys_xfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 6 ++--- tools/libfsimage/zfs/Makefile | 2 +- tools/libfsimage/zfs/filesys.h | 2 +- tools/libfsimage/zfs/fsi_zfs.c | 2 +- tools/libfsimage/zfs/fsi_zfs.h | 2 +- tools/libfsimage/zfs/fsys_zfs.c | 2 +- tools/libfsimage/zfs/fsys_zfs.h | 2 +- tools/libfsimage/zfs/mb_info.h | 2 +- tools/libfsimage/zfs/shared.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu_objset.h | 2 +- tools/libfsimage/zfs/zfs-include/dnode.h | 2 +- .../libfsimage/zfs/zfs-include/dsl_dataset.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dir.h | 2 +- tools/libfsimage/zfs/zfs-include/sa_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/spa.h | 2 +- .../zfs/zfs-include/uberblock_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/vdev_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_leaf.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_acl.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_znode.h | 2 +- tools/libfsimage/zfs/zfs-include/zil.h | 2 +- tools/libfsimage/zfs/zfs-include/zio.h | 2 +- .../libfsimage/zfs/zfs-include/zio_checksum.h | 2 +- tools/libfsimage/zfs/zfs_fletcher.c | 2 +- tools/libfsimage/zfs/zfs_lzjb.c | 2 +- tools/libfsimage/zfs/zfs_sha256.c | 4 ++-- tools/libs/call/buffer.c | 2 +- tools/libs/call/core.c | 2 +- tools/libs/call/freebsd.c | 2 +- tools/libs/call/linux.c | 2 +- tools/libs/call/minios.c | 2 +- tools/libs/call/netbsd.c | 2 +- tools/libs/call/solaris.c | 2 +- tools/libs/ctrl/xc_altp2m.c | 2 +- tools/libs/ctrl/xc_cpu_hotplug.c | 2 +- tools/libs/ctrl/xc_cpupool.c | 2 +- tools/libs/ctrl/xc_csched.c | 2 +- tools/libs/ctrl/xc_csched2.c | 2 +- tools/libs/ctrl/xc_domain.c | 2 +- tools/libs/ctrl/xc_evtchn.c | 2 +- tools/libs/ctrl/xc_flask.c | 2 +- tools/libs/ctrl/xc_foreign_memory.c | 2 +- tools/libs/ctrl/xc_freebsd.c | 2 +- tools/libs/ctrl/xc_gnttab.c | 2 +- tools/libs/ctrl/xc_hcall_buf.c | 2 +- tools/libs/ctrl/xc_linux.c | 2 +- tools/libs/ctrl/xc_mem_access.c | 2 +- tools/libs/ctrl/xc_mem_paging.c | 2 +- tools/libs/ctrl/xc_memshr.c | 2 +- tools/libs/ctrl/xc_minios.c | 2 +- tools/libs/ctrl/xc_misc.c | 2 +- tools/libs/ctrl/xc_monitor.c | 2 +- tools/libs/ctrl/xc_netbsd.c | 2 +- tools/libs/ctrl/xc_pagetab.c | 2 +- tools/libs/ctrl/xc_physdev.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/ctrl/xc_rt.c | 2 +- tools/libs/ctrl/xc_solaris.c | 2 +- tools/libs/ctrl/xc_tbuf.c | 2 +- tools/libs/ctrl/xc_vm_event.c | 2 +- tools/libs/ctrl/xc_vmtrace.c | 2 +- tools/libs/devicemodel/common.c | 2 +- tools/libs/devicemodel/compat.c | 2 +- tools/libs/devicemodel/core.c | 2 +- tools/libs/evtchn/core.c | 2 +- tools/libs/evtchn/freebsd.c | 2 +- tools/libs/evtchn/linux.c | 2 +- tools/libs/evtchn/minios.c | 2 +- tools/libs/evtchn/netbsd.c | 2 +- tools/libs/evtchn/solaris.c | 2 +- tools/libs/foreignmemory/compat.c | 2 +- tools/libs/foreignmemory/core.c | 2 +- tools/libs/foreignmemory/freebsd.c | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/foreignmemory/minios.c | 2 +- tools/libs/foreignmemory/netbsd.c | 2 +- tools/libs/foreignmemory/solaris.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/gntshr_core.c | 2 +- tools/libs/gnttab/gntshr_unimp.c | 2 +- tools/libs/gnttab/gnttab_core.c | 2 +- tools/libs/gnttab/gnttab_unimp.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/gnttab/minios.c | 2 +- tools/libs/gnttab/netbsd.c | 2 +- tools/libs/guest/xg_core.c | 2 +- tools/libs/guest/xg_core.h | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_core_arm.h | 2 +- tools/libs/guest/xg_core_x86.c | 2 +- tools/libs/guest/xg_core_x86.h | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_armzimageloader.c | 2 +- tools/libs/guest/xg_dom_binloader.c | 2 +- tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_compat_linux.c | 2 +- tools/libs/guest/xg_dom_core.c | 2 +- tools/libs/guest/xg_dom_elfloader.c | 2 +- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_domain.c | 2 +- tools/libs/guest/xg_nomigrate.c | 2 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_private.c | 2 +- tools/libs/guest/xg_private.h | 2 +- tools/libs/guest/xg_resume.c | 2 +- tools/libs/guest/xg_save_restore.h | 2 +- tools/libs/guest/xg_suspend.c | 2 +- tools/libs/hypfs/core.c | 2 +- tools/libs/light/libxl_genid.c | 2 +- tools/libs/stat/COPYING | 2 +- tools/libs/stat/xenstat_qmp.c | 2 +- tools/libs/store/xs.c | 2 +- tools/libs/toolcore/handlereg.c | 2 +- tools/libs/toollog/xtl_core.c | 2 +- tools/libs/toollog/xtl_logger_stdio.c | 2 +- tools/libs/util/libxlu_cfg_y.c | 2 +- tools/libs/util/libxlu_cfg_y.h | 2 +- tools/libs/vchan/init.c | 2 +- tools/libs/vchan/io.c | 2 +- tools/libs/vchan/vchan.h | 2 +- tools/misc/mkhex | 2 +- tools/misc/mkrpm | 2 +- tools/misc/xen-mceinj.c | 2 +- tools/misc/xen-vmtrace.c | 2 +- tools/misc/xencov.c | 2 +- tools/misc/xenpm.c | 2 +- tools/misc/xenpvnetboot | 2 +- tools/ocaml/LICENSE | 2 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 2 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2 +- tools/pygrub/src/ExtLinuxConf.py | 2 +- tools/pygrub/src/GrubConf.py | 2 +- tools/pygrub/src/pygrub | 2 +- tools/python/xen/lowlevel/xs/xs.c | 2 +- tools/tests/depriv/depriv-fd-checker.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/vhpet/main.c | 4 ++-- tools/tests/vpci/emul.h | 2 +- tools/tests/vpci/main.c | 2 +- tools/tests/x86_emulator/blowfish.c | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/vchan/node-select.c | 2 +- tools/vchan/node.c | 2 +- tools/vchan/vchan-socket-proxy.c | 2 +- tools/xenmon/COPYING | 2 +- tools/xenmon/setmask.c | 2 +- tools/xenmon/xenbaked.c | 2 +- tools/xenmon/xenbaked.h | 2 +- tools/xenmon/xenmon.py | 2 +- tools/xenpaging/file_ops.c | 2 +- tools/xenpaging/file_ops.h | 2 +- tools/xenpaging/policy.h | 2 +- tools/xenpaging/policy_default.c | 2 +- tools/xenpaging/xenpaging.c | 2 +- tools/xenpaging/xenpaging.h | 2 +- tools/xenpmd/xenpmd.c | 2 +- tools/xenstore/COPYING | 2 +- tools/xenstore/include/xenstore_state.h | 2 +- tools/xenstore/talloc.c | 4 ++-- tools/xenstore/talloc.h | 2 +- tools/xenstore/talloc_guide.txt | 2 +- tools/xenstore/tdb.c | 2 +- tools/xenstore/tdb.h | 2 +- tools/xenstore/xenstored_control.c | 2 +- tools/xenstore/xenstored_control.h | 2 +- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 2 +- tools/xenstore/xenstored_domain.h | 2 +- tools/xenstore/xenstored_minios.c | 2 +- tools/xenstore/xenstored_posix.c | 2 +- tools/xenstore/xenstored_transaction.c | 2 +- tools/xenstore/xenstored_transaction.h | 2 +- tools/xenstore/xenstored_watch.c | 2 +- tools/xenstore/xenstored_watch.h | 2 +- tools/xenstore/xs_lib.c | 2 +- tools/xenstore/xs_lib.h | 2 +- tools/xentop/xentop.c | 2 +- tools/xentrace/xenalyze.c | 2 +- tools/xl/check-xl-disk-parse | 6 ++--- xen/COPYING | 2 +- xen/arch/arm/acpi/boot.c | 2 +- xen/arch/arm/acpi/lib.c | 2 +- xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm32/insn.c | 2 +- xen/arch/arm/arm32/lib/bitops.c | 2 +- xen/arch/arm/arm32/lib/lib1funcs.S | 2 +- xen/arch/arm/arm32/lib/lshrdi3.S | 2 +- xen/arch/arm/arm64/bpi.S | 2 +- xen/arch/arm/arm64/cache.S | 2 +- xen/arch/arm/arm64/debug-meson.inc | 2 +- xen/arch/arm/arm64/debug-mvebu.inc | 2 +- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/arm64/insn.c | 2 +- xen/arch/arm/arm64/lib/bitops.c | 2 +- xen/arch/arm/arm64/lib/clear_page.S | 2 +- xen/arch/arm/arm64/lib/memchr.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 5 ++-- xen/arch/arm/arm64/lib/memcpy.S | 4 ++-- xen/arch/arm/arm64/lib/memmove.S | 4 ++-- xen/arch/arm/arm64/lib/memset.S | 4 ++-- xen/arch/arm/arm64/lib/strchr.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 4 ++-- xen/arch/arm/arm64/lib/strlen.S | 4 ++-- xen/arch/arm/arm64/lib/strncmp.S | 4 ++-- xen/arch/arm/arm64/lib/strnlen.S | 4 ++-- xen/arch/arm/arm64/lib/strrchr.S | 2 +- xen/arch/arm/efi/efi-dom0.c | 2 +- xen/arch/arm/include/asm/acpi.h | 2 +- xen/arch/arm/include/asm/altp2m.h | 2 +- xen/arch/arm/include/asm/arm32/insn.h | 2 +- xen/arch/arm/include/asm/arm64/atomic.h | 2 +- xen/arch/arm/include/asm/arm64/insn.h | 2 +- xen/arch/arm/include/asm/arm64/io.h | 2 +- xen/arch/arm/include/asm/gic_v3_its.h | 2 +- xen/arch/arm/include/asm/iommu.h | 2 +- xen/arch/arm/include/asm/iommu_fwspec.h | 2 +- xen/arch/arm/include/asm/ioreq.h | 2 +- xen/arch/arm/include/asm/mem_access.h | 2 +- xen/arch/arm/include/asm/monitor.h | 2 +- xen/arch/arm/include/asm/new_vgic.h | 2 +- xen/arch/arm/include/asm/pci.h | 2 +- xen/arch/arm/include/asm/smccc.h | 2 +- xen/arch/arm/include/asm/tee/optee_smc.h | 2 +- xen/arch/arm/include/asm/vm_event.h | 2 +- xen/arch/arm/include/asm/vpl011.h | 2 +- xen/arch/arm/include/asm/vpsci.h | 2 +- xen/arch/arm/pci/ecam.c | 2 +- xen/arch/arm/pci/pci-access.c | 2 +- xen/arch/arm/pci/pci-host-common.c | 2 +- xen/arch/arm/pci/pci-host-generic.c | 2 +- xen/arch/arm/pci/pci-host-zynqmp.c | 2 +- xen/arch/arm/pci/pci.c | 2 +- xen/arch/arm/platforms/thunderx.c | 2 +- xen/arch/arm/vgic/vgic-init.c | 2 +- xen/arch/arm/vgic/vgic-mmio.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/arm/vgic/vgic.h | 2 +- xen/arch/x86/acpi/boot.c | 2 +- xen/arch/x86/acpi/cpu_idle.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/acpi/cpuidle_menu.c | 2 +- xen/arch/x86/acpi/lib.c | 2 +- xen/arch/x86/alternative.c | 2 +- xen/arch/x86/boot/build32.lds | 2 +- xen/arch/x86/boot/cmdline.c | 2 +- xen/arch/x86/boot/defs.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 8 +++---- xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 10 ++++---- xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- xen/arch/x86/cpu/microcode/core.c | 4 +--- xen/arch/x86/cpu/microcode/intel.c | 4 ++-- xen/arch/x86/cpu/mtrr/main.c | 2 +- xen/arch/x86/cpu/mwait-idle.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/cpu/vpmu_amd.c | 2 +- xen/arch/x86/cpu/vpmu_intel.c | 2 +- xen/arch/x86/dmi_scan.c | 5 ++++ xen/arch/x86/gdbstub.c | 2 +- xen/arch/x86/gdbsx.c | 2 +- xen/arch/x86/genapic/x2apic.c | 2 +- xen/arch/x86/guest/hyperv/hyperv.c | 2 +- xen/arch/x86/guest/hyperv/private.h | 2 +- xen/arch/x86/guest/hyperv/tlb.c | 2 +- xen/arch/x86/guest/hyperv/util.c | 2 +- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/hvm/asid.c | 2 +- xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/hvm/domain.c | 2 +- xen/arch/x86/hvm/grant_table.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/hypercall.c | 2 +- xen/arch/x86/hvm/intercept.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 2 +- xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/monitor.c | 2 +- xen/arch/x86/hvm/mtrr.c | 2 +- xen/arch/x86/hvm/nestedhvm.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 2 +- xen/arch/x86/hvm/quirks.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/hvm/svm/asid.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/entry.S | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svmdebug.c | 2 +- xen/arch/x86/hvm/svm/vmcb.c | 2 +- xen/arch/x86/hvm/vioapic.c | 2 +- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vm_event.c | 2 +- xen/arch/x86/hvm/vmsi.c | 2 +- xen/arch/x86/hvm/vmx/entry.S | 2 +- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 2 +- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/hypercall.c | 2 +- xen/arch/x86/include/asm/acpi.h | 2 +- xen/arch/x86/include/asm/altp2m.h | 2 +- xen/arch/x86/include/asm/edd.h | 4 ++-- xen/arch/x86/include/asm/endbr.h | 2 +- xen/arch/x86/include/asm/guest.h | 2 +- xen/arch/x86/include/asm/guest/hyperv-hcall.h | 2 +- xen/arch/x86/include/asm/guest/hyperv.h | 2 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 2 +- xen/arch/x86/include/asm/guest/xen-hcall.h | 2 +- xen/arch/x86/include/asm/guest/xen.h | 2 +- xen/arch/x86/include/asm/guest_pt.h | 2 +- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/hpet.h | 2 +- xen/arch/x86/include/asm/hvm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/grant_table.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 2 +- xen/arch/x86/include/asm/hvm/io.h | 2 +- xen/arch/x86/include/asm/hvm/ioreq.h | 2 +- xen/arch/x86/include/asm/hvm/irq.h | 2 +- xen/arch/x86/include/asm/hvm/monitor.h | 2 +- xen/arch/x86/include/asm/hvm/nestedhvm.h | 2 +- xen/arch/x86/include/asm/hvm/save.h | 2 +- xen/arch/x86/include/asm/hvm/support.h | 2 +- xen/arch/x86/include/asm/hvm/svm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/svm/emulate.h | 2 +- xen/arch/x86/include/asm/hvm/svm/intr.h | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- xen/arch/x86/include/asm/hvm/vcpu.h | 2 +- xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- xen/arch/x86/include/asm/hvm/vlapic.h | 2 +- xen/arch/x86/include/asm/hvm/vm_event.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 2 +- xen/arch/x86/include/asm/hvm/vpt.h | 2 +- xen/arch/x86/include/asm/iommu.h | 2 +- xen/arch/x86/include/asm/ioreq.h | 2 +- xen/arch/x86/include/asm/mem_access.h | 2 +- xen/arch/x86/include/asm/mem_paging.h | 2 +- xen/arch/x86/include/asm/mem_sharing.h | 2 +- xen/arch/x86/include/asm/monitor.h | 2 +- xen/arch/x86/include/asm/p2m.h | 2 +- xen/arch/x86/include/asm/paging.h | 2 +- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/include/asm/pv/grant_table.h | 2 +- xen/arch/x86/include/asm/pv/mm.h | 2 +- xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/include/asm/pv/traps.h | 2 +- xen/arch/x86/include/asm/shadow.h | 2 +- xen/arch/x86/include/asm/shstk.h | 2 +- xen/arch/x86/include/asm/spec_ctrl.h | 2 +- xen/arch/x86/include/asm/spec_ctrl_asm.h | 2 +- xen/arch/x86/include/asm/traps.h | 2 +- xen/arch/x86/include/asm/vm_event.h | 2 +- xen/arch/x86/include/asm/vpmu.h | 2 +- xen/arch/x86/include/asm/xenoprof.h | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/altp2m.c | 2 +- xen/arch/x86/mm/guest_walk.c | 2 +- xen/arch/x86/mm/hap/guest_walk.c | 2 +- xen/arch/x86/mm/hap/hap.c | 2 +- xen/arch/x86/mm/hap/nested_ept.c | 2 +- xen/arch/x86/mm/hap/nested_hap.c | 2 +- xen/arch/x86/mm/hap/private.h | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/mem_paging.c | 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/nested.c | 2 +- xen/arch/x86/mm/p2m-basic.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/arch/x86/mm/p2m-pod.c | 2 +- xen/arch/x86/mm/p2m-pt.c | 2 +- xen/arch/x86/mm/p2m.c | 2 +- xen/arch/x86/mm/p2m.h | 2 +- xen/arch/x86/mm/paging.c | 2 +- xen/arch/x86/mm/physmap.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/mm/shadow/multi.h | 2 +- xen/arch/x86/mm/shadow/private.h | 2 +- xen/arch/x86/mm/shadow/pv.c | 2 +- xen/arch/x86/mm/shadow/set.c | 2 +- xen/arch/x86/mm/shadow/types.h | 2 +- xen/arch/x86/monitor.c | 2 +- xen/arch/x86/msr.c | 2 +- xen/arch/x86/pv/callback.c | 2 +- xen/arch/x86/pv/descriptor-tables.c | 2 +- xen/arch/x86/pv/emul-gate-op.c | 2 +- xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/grant_table.c | 2 +- xen/arch/x86/pv/hypercall.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/misc-hypercalls.c | 2 +- xen/arch/x86/pv/mm.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/pv/shim.c | 2 +- xen/arch/x86/pv/traps.c | 2 +- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/spec_ctrl.c | 2 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/vm_event.c | 2 +- xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- xen/arch/x86/x86_64/cpu_idle.c | 2 +- xen/arch/x86/x86_64/cpufreq.c | 2 +- xen/arch/x86/x86_64/gdbstub.c | 2 +- xen/arch/x86/x86_64/mm.c | 2 +- xen/arch/x86/x86_64/mmconfig.h | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- xen/common/README.source | 6 ++--- xen/common/argo.c | 2 +- xen/common/bunzip2.c | 7 +++--- xen/common/coverage/coverage.c | 2 +- xen/common/dm.c | 2 +- xen/common/event_channel.c | 2 +- xen/common/gdbstub.c | 2 +- xen/common/grant_table.c | 2 +- xen/common/ioreq.c | 2 +- xen/common/libelf/libelf-dominfo.c | 2 +- xen/common/libelf/libelf-loader.c | 2 +- xen/common/libelf/libelf-private.h | 2 +- xen/common/libelf/libelf-tools.c | 2 +- xen/common/lz4/decompress.c | 6 ++--- xen/common/lzo.c | 8 +++---- xen/common/mem_access.c | 2 +- xen/common/monitor.c | 2 +- xen/common/page_alloc.c | 2 +- xen/common/pdx.c | 2 +- xen/common/preempt.c | 2 +- xen/common/radix-tree.c | 2 +- xen/common/rcupdate.c | 8 +++---- xen/common/sched/null.c | 2 +- xen/common/stop_machine.c | 2 +- xen/common/time.c | 2 +- xen/common/unlzma.c | 8 +++---- xen/common/unlzo.c | 4 ++-- xen/common/vm_event.c | 2 +- xen/common/wait.c | 2 +- xen/common/xmalloc_tlsf.c | 4 ++-- xen/common/xz/crc32.c | 2 +- xen/common/xz/dec_bcj.c | 2 +- xen/common/xz/dec_lzma2.c | 2 +- xen/common/xz/lzma2.h | 2 +- xen/common/xz/stream.h | 2 +- xen/common/zstd/bitstream.h | 2 +- xen/common/zstd/entropy_common.c | 2 +- xen/common/zstd/fse.h | 2 +- xen/common/zstd/fse_decompress.c | 2 +- xen/common/zstd/huf.h | 2 +- xen/common/zstd/huf_decompress.c | 2 +- xen/crypto/README.source | 4 ++-- xen/drivers/acpi/apei/apei-base.c | 2 +- xen/drivers/acpi/apei/apei-io.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/drivers/acpi/apei/hest.c | 2 +- xen/drivers/acpi/numa.c | 2 +- xen/drivers/acpi/osl.c | 2 +- xen/drivers/acpi/pmstat.c | 2 +- xen/drivers/acpi/tables.c | 2 +- xen/drivers/char/consoled.c | 2 +- xen/drivers/char/meson-uart.c | 2 +- xen/drivers/char/mvebu-uart.c | 2 +- xen/drivers/char/xen_pv_console.c | 2 +- xen/drivers/char/xhci-dbc.c | 2 +- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/drivers/passthrough/amd/iommu-defs.h | 2 +- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/drivers/passthrough/amd/iommu_cmd.c | 2 +- xen/drivers/passthrough/amd/iommu_detect.c | 2 +- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_init.c | 2 +- xen/drivers/passthrough/amd/iommu_intr.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/arm/iommu_fwspec.c | 2 +- xen/drivers/passthrough/arm/iommu_helpers.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 4 ++-- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/ats.c | 2 +- xen/drivers/passthrough/ats.h | 2 +- xen/drivers/passthrough/iommu.c | 2 +- xen/drivers/passthrough/pci.c | 6 ++--- xen/drivers/passthrough/vtd/dmar.c | 2 +- xen/drivers/passthrough/vtd/dmar.h | 2 +- xen/drivers/passthrough/vtd/extern.h | 2 +- xen/drivers/passthrough/vtd/intremap.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/drivers/passthrough/vtd/qinval.c | 2 +- xen/drivers/passthrough/vtd/quirks.c | 2 +- xen/drivers/passthrough/vtd/utils.c | 2 +- xen/drivers/passthrough/vtd/vtd.h | 2 +- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- xen/drivers/passthrough/vtd/x86/hvm.c | 2 +- xen/drivers/passthrough/vtd/x86/vtd.c | 2 +- xen/drivers/passthrough/x86/hvm.c | 2 +- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 2 +- xen/drivers/vpci/vpci.c | 2 +- xen/include/acpi/actbl3.h | 2 +- xen/include/crypto/README.source | 4 ++-- xen/include/crypto/vmac.h | 5 ++-- xen/include/efi/eficapsule.h | 2 +- xen/include/public/arch-x86/hvm/start_info.h | 2 +- xen/include/public/errno.h | 2 +- xen/include/public/grant_table.h | 2 +- xen/include/public/hvm/params.h | 2 +- xen/include/public/io/blkif.h | 4 ++-- xen/include/public/io/libxenvchan.h | 2 +- xen/include/public/io/tpmif.h | 2 +- xen/include/xen/acpi.h | 2 +- xen/include/xen/argo.h | 2 +- xen/include/xen/atomic.h | 2 +- xen/include/xen/compiler.h | 2 +- xen/include/xen/cper.h | 2 +- xen/include/xen/cpuidle.h | 2 +- xen/include/xen/dm.h | 2 +- xen/include/xen/elfstructs.h | 4 ++-- xen/include/xen/gdbstub.h | 2 +- xen/include/xen/grant_table.h | 2 +- xen/include/xen/inttypes.h | 2 +- xen/include/xen/iommu.h | 2 +- xen/include/xen/ioreq.h | 2 +- xen/include/xen/lzo.h | 2 +- xen/include/xen/mem_access.h | 2 +- xen/include/xen/monitor.h | 2 +- xen/include/xen/multiboot.h | 2 +- xen/include/xen/pci_regs.h | 4 ++-- xen/include/xen/radix-tree.h | 2 +- xen/include/xen/rbtree.h | 2 +- xen/include/xen/rcupdate.h | 8 +++---- xen/include/xen/vm_event.h | 2 +- xen/include/xen/xxhash.h | 2 +- xen/lib/list-sort.c | 2 +- xen/lib/rbtree.c | 4 ++-- xen/lib/xxhash32.c | 2 +- xen/lib/xxhash64.c | 2 +- xen/xsm/silo.c | 2 +- 710 files changed, 867 insertions(+), 896 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:58:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491995.761384 (Exim 4.92) (envelope-from ) id 1pPrWe-00083N-FI; Wed, 08 Feb 2023 20:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491995.761384; Wed, 08 Feb 2023 20:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWe-00082m-9L; Wed, 08 Feb 2023 20:58:44 +0000 Received: by outflank-mailman (input) for mailman id 491995; Wed, 08 Feb 2023 20:58:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWc-000800-Lt for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 20:58:42 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b6a5f2d-a7f3-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 21:58:39 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 360795C0114; Wed, 8 Feb 2023 15:58:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 08 Feb 2023 15:58:37 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 15:58:35 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b6a5f2d-a7f3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675889917; x=1675976317; bh=mEGhY+Vya8iAlE9GB9PbRYaZwA2j9eKz3dR M4StDQ70=; b=ozyYwcXHg1RrE3lLptE+zLipMntILP0qWcQtn4NSEyKVeD5g1vw ZHKEgoYenRyg9mAiRArU8g4uvT5QiFnuq4ZjEasabFEV5FxlwQFHqHBxFO11BjRr aDPeSiBL7HaLQQTehj4tXDhkrzSZGpIjoSXhcgGl8c1H8sLzFvhuoAbz+bzAD/Eh 1EdGU8/BsPcKPszxgRA6gDHb4iyXuuJp8RsT5EE3Prc9CkrE/iHk/qObknLDZy3c /4EqZP8wQsdav2rsqBO9qhnnsNLA+G+yvNT7mf2mnZxmXdoLTmeCpPIOWllLfipF paung8Z3C/VYlxa2lm0nwG50cjw67/DBvxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1675889917; x=1675976317; bh=mEGhY+Vya8iAl E9GB9PbRYaZwA2j9eKz3dRM4StDQ70=; b=halKxgKZ7sSdmrY4257EzJTAwrRhZ YUH9cmdxgpMLXtrVP+jROOZaRc6lYXnJ4LcOsd+ginkVEKBeKXrhEHVuou/RYsGJ Ft3LAC2yCE66oe6leEvPvxEVfLStTgeDYJOJzgYo6DiiCgX1pLs+a3Kmk+DVmDR2 IGVMvh+EO6t4wLjvepyL3tLSN6DJbqPW46bS6LXGcmjAiFiOP56h02a8dY12eP8Q IYxNw5EcmGEumCki8ehIcGxdMjWZT/xjPTSl662MIpLt90BrTssa8j4aOUPysak/ WXKpIl2LUTN9fo+EpkFIZy/AQYNLmUTJSTadvM/6q846+zqYH9oJaoYMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepkeevtdevgffhieevgffgjeetueej veegleeihfeileehudfggfetvdevueekudeknecuffhomhgrihhnpeigvghnrdhorhhgpd hslhhofihglhgrshhsrdgtohhmpdhinhhfrhgruggvrggurdhorhhgpdhsphhhihhngidq ughotgdrohhrghdpiihlihgsrdhnvghtpdhkvghrnhgvlhdrohhrghdprhgvughhrghtrd gtohhmpdhgnhhurdhorhhgpdhinhhrihgrrdhfrhdpghhmphhlihgsrdhorhhgpdhpohhl rghrshhslhdrohhrghdpsggvrhhlihhoshdruggvpdhsohhurhgtvgifrghrvgdrohhrgh dpihhpgigvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// Date: Wed, 8 Feb 2023 15:58:21 -0500 Message-Id: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Signed-off-by: Demi Marie Obenour --- Config.mk | 20 ++++++-------------- docs/README.remus | 2 +- docs/conf.py | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++++--------- stubdom/configure.ac | 24 +++++++++++++++--------- tools/firmware/etherboot/Makefile | 6 +----- 7 files changed, 34 insertions(+), 40 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/git-http/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/docs/README.remus b/docs/README.remus index e41e045a109466213b39bf5099ee16652b229ccc..10929e06d049755c4e8a9c900af7e10048c3effb 100644 --- a/docs/README.remus +++ b/docs/README.remus @@ -7,7 +7,7 @@ Using Remus with libxl on Xen 4.5 and higher: To enable network buffering, you need libnl 3.2.8 or higher along with the development headers and command line utilities. If your distro does not have the appropriate libnl3 version, you can find - the latest source tarball of libnl3 at http://www.carisma.slowglass.com/~tgr/libnl/ + the latest source tarball of libnl3 at https://www.infradead.org/~tgr/libnl/ Disk replication: VMs protected by Remus need to use DRBD based disk backends. Specifically, you diff --git a/docs/conf.py b/docs/conf.py index 50e41501db8f95bd186818c49a8e6538d733012b..7f4adce29e57e4ab8be9a09fc105bb133c51dbb0 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -5,7 +5,7 @@ # # This file does only contain a selection of the most common options. For a # full list see the documentation: -# http://www.sphinx-doc.org/en/master/config +# https://www.sphinx-doc.org/en/master/config # -- Path setup -------------------------------------------------------------- diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..cf629cdf3c44e4abe67214378c49a3a9d858d9b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/git-http/xen.git\n"); $printed_novcs = 1; } return 0; diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..8b409d294d6ad5e363d6942078e66de95fa0503d 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : ZLIB_URL=\$\(XEN_EXTFILES_URL\) else - ZLIB_URL="http://www.zlib.net" + ZLIB_URL="https://www.zlib.net" fi fi @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://www.kernel.org/pub/software/utils/pciutils" fi fi @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sources.redhat.com/pub/newlib" fi fi @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3607,7 +3607,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://gmplib.org/download/gmp" fi fi @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" = "x"; then : if test "x$extfiles" = "xy"; then : POLARSSL_URL=\$\(XEN_EXTFILES_URL\) else - POLARSSL_URL="http://polarssl.org/code/releases" + POLARSSL_URL="https://polarssl.org/code/releases" fi fi @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" = "x"; then : if test "x$extfiles" = "xy"; then : TPMEMU_URL=\$\(XEN_EXTFILES_URL\) else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" + TPMEMU_URL="https://download.berlios.de/tpm-emulator" fi fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..e43853d45a5f652c05fe36f9171fba4c1b5863c0 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,19 +55,25 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://www.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gmp]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/code/releases]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://download.berlios.de/tpm-emulator]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) +if test "x$vtpm" != xn || test "x$vtpmmgr" != xn; then + if test "x$extfiles" != xy; then + AC_MSG_ERROR([Sources needed for the vTPM and vTPM manager stubdomains are no longer at their original URLs]) + fi +fi + #Conditionally enable these stubdoms based on the presense of dependencies AX_STUBDOM_CONDITIONAL_FINISH([vtpm-stubdom], [vtpm]) AX_STUBDOM_CONDITIONAL_FINISH([vtpmmgr-stubdom], [vtpmmgr]) diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..f08b2c847b6535e5c28b6576445d02c2ac9551eb 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -4,11 +4,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk include Config -ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git -else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git -endif +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git # put an updated tar.gz on xenbits after changes to this variable IPXE_GIT_TAG := 3c040ad387099483102708bb1839110bc788cefb -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:58:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491994.761379 (Exim 4.92) (envelope-from ) id 1pPrWe-00080g-5h; Wed, 08 Feb 2023 20:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491994.761379; Wed, 08 Feb 2023 20:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWe-00080Z-2m; Wed, 08 Feb 2023 20:58:44 +0000 Received: by outflank-mailman (input) for mailman id 491994; Wed, 08 Feb 2023 20:58:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWc-0007kX-Ko for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 20:58:42 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d433fe9-a7f3-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 21:58:40 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0C1455C013E; Wed, 8 Feb 2023 15:58:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 08 Feb 2023 15:58:40 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 15:58:38 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d433fe9-a7f3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675889920; x=1675976320; bh=YjlH9X1VyXgKgkGafsk0dvpHNT7Xq4V4f4f mb7TTmQY=; b=jaEcFfmHc3jC4mYccFTIPr09qO7jo80ZccMUmV7ONnH7Y13AcC1 J0mqLLxFgjaQ7taNYM/UqrQ1pUVcB5eGD1QXvpm75yZEyliVvM99ErUNaFdhkFCT GLBQEbceYawOVVStZOfeU7ZJVvRXToWHeouzAh7mpopV169AweJxZRa2PxXk8a+r jOAHpX4+aWWmrQau5OkCA/UANUQsGoVeCFZf7+t9JTXJliuJ2E3oOCSh1hSutPhf Fz6N7NArDclx7i2KcIuh+qYRACQUnHubGyBHWoq6g59kJF1gu5dOZngWMOz0VUoq p5NekZSxz0CXEWDMEFgB5CldR83ZC6dO0Rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1675889920; x=1675976320; bh=YjlH9X1VyXgKg kGafsk0dvpHNT7Xq4V4f4fmb7TTmQY=; b=epZVL0unkdc7f5L0bOAadoCipddZY oDZp2lKBJaGzoNwWCywg+liuQqg1MZlPBLE+bWlQtPeCEFWoI3Oeba7XhrAiQXW6 hZcx6twW/Nxxs61YTlagFpQ7ACJCOdmL9Rb0GGQeT6c3Vgtws0gPh7YrO6bhorEd PxjLp5KN3fRSyjYQN8yZFgK0CMBp9XhnKf8bBGovIaFeWZsT8Y5Xtu1LKYLyMAUM N4Juxc6hTSY9ctAH+xX5tfjRebTilxhBzhRzexd/qX5rLBo+j58GbwWymSVfIARx ytuY6eQ9CtziUqaT1vK5wff7YAP0b6vgw6hAH2ofBr3bZ6FfTtworH71A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteduueehgeeujeegudeiffffveel teeljeevudeileffieetgfegffeitedvkeeunecuffhomhgrihhnpehphihthhhonhdroh hrghdpihhnthgvlhdrtghomhdptggvnhhtohhsrdhorhhgpdhllhhvmhdrohhrghdpuggv sghirghnrdhorhhgpdgrlhhpihhnvghlihhnuhigrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgv thhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: [PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https:// Date: Wed, 8 Feb 2023 15:58:22 -0500 Message-Id: <8a3d0ce9747e486e91ad5b47777c80293e0fd168.1675889602.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. Signed-off-by: Demi Marie Obenour --- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo index 4da27faeb5fa863fd4e140cbeaad308b9a543b86..8e37da1a03f839c486eb9bd0af46716cfb9086e0 100644 --- a/automation/build/centos/CentOS-7.2.repo +++ b/automation/build/centos/CentOS-7.2.repo @@ -6,28 +6,28 @@ [base] name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #released updates [updates] name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/updates/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that may be useful [extras] name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/extras/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that extend functionality of existing packages [centosplus] name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/centosplus/$basearch/ gpgcheck=1 gpgcheck=1 enabled=0 diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list index dc119fa0b4df1bd6e742c42776710abcd6deaa86..1db1598997429d7a14d3fcd8f0f8152aa6d40b8a 100644 --- a/automation/build/debian/unstable-llvm-8.list +++ b/automation/build/debian/unstable-llvm-8.list @@ -1,3 +1,3 @@ # Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb https://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb-src https://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..6163eeeda623527d0620fb20a23b589b1168a896 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:58:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491996.761401 (Exim 4.92) (envelope-from ) id 1pPrWj-00007h-K3; Wed, 08 Feb 2023 20:58:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491996.761401; Wed, 08 Feb 2023 20:58:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWj-00007V-Gq; Wed, 08 Feb 2023 20:58:49 +0000 Received: by outflank-mailman (input) for mailman id 491996; Wed, 08 Feb 2023 20:58:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWh-000800-NB for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 20:58:48 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f487064-a7f3-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 21:58:44 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id ABA5A5C0114; Wed, 8 Feb 2023 15:58:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 08 Feb 2023 15:58:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 15:58:41 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f487064-a7f3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1675889923; x=1675976323; bh=LwAVsdpt7C bTwbn8Hx1g6+yuYHPJbXxVX3PdFBOiK9g=; b=mmSs+embJitFjXhtqxZPm+gMVZ XOUR9DkCO/LEEejNfdJGNolKeopPyXpu2Gu5NNh5JtKPXlnIr+DoSodIvZpabUMb JB0dpoACq3FYCxuzEqfb9y+FMj4WZkko+hSShETt6VRYq0eR9DAPTkCQYo3SJ/xm jiedtU04MCpFjwI5fr6nG8hgToqWYR7bhqJpI9W5pSd0lMPbRzLW7rcUeF+ofL4t rzv/WPW81wx/mLG6EOoKDc2LcW/ePu29v6KLP3GIgZWu6AlhFiEMvls9UZrPeekE bDYlJf2AfTGldd9H+2Y9AM2qrR7PoM6ZUWLuSVRYlMvz83zTpuovTp7UOHZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1675889923; x= 1675976323; bh=LwAVsdpt7CbTwbn8Hx1g6+yuYHPJbXxVX3PdFBOiK9g=; b=O 0fRwDflcxflH1MS5BGkF1kF2JFy2mO4vMKbzWDQt7GH/62rvVGbZ9TcTsbcO08rk tegU8pfPdfM3yj6qLKE5HI7rArPSGxC4C17OEVQmswBWQMwesmPBSa8MxzeS1BDo tbwCUyz8OV+jzaJrX+TexVOdjYs5ETWs96fPuSt6hYRq8KsUrj1gKkf9RUhGw1Ld t//YaqHtBILIgRsmhYwm04ykY1hAmqfDwsLIk2iQiil8sr+3BTLw4LmOEeBUD/7r Smh9soYh4Gxs/+2l4M50hE8TN2EZ0iYut0qFfRFdDCjQekTTNiTg51LI2bEqxRWS OaSQMwCiJ7lZIkTOyasGQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnegfrhhlucfvnfffucdlgedmnecujfgu rhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcuof grrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhmqeenucggtffrrghtthgvrhhnpeettddukeduffffjedtfeefieetiefgvd evjeefkefhffekteeggfevueekkeffudenucffohhmrghinhepghhnuhdrohhrghdpghho ohhprdhorhhgpdhsohhurhgtvghfohhrghgvrdhnvghtpdhfrhgvvggsshgurdhorhhgpd hnvghtsghsugdrohhrghdpohhpvghnsghsugdrohhrghdpihhnthgvlhdrtghordhukhdp rghmugdrtghomhdpihhnthgvlhdrtghomhdphihouhhtuhgsvgdrtghomhdplhhinhhugi hfohhunhgurghtihhonhdrohhrghdpgigvnhhprhhojhgvtghtrdhorhhgpdigvghnrdho rhhgpdhslhhiuggvshhhrghrvgdrnhgvthdpghhoohhglhgvrdgtohhmpdgrmhguieegrd horhhgpdhkvghrnhgvlhdrohhrghdpfhhrvggvqdgvlhgvtghtrhhonhhsrdgtohhmpdgu vghngidruggvpdguvghvihgtvghtrhgvvgdrohhrghdpuhifrghtvghrlhhoohdrtggrpd hkvghrnhgvlhhnvgifsghivghsrdhorhhgpdgtohhrnhgvlhhlrdgvughupdhfrghurdgu vgdpghhithhhuhgsrdgtohhmpdhrvggrughthhgvughotghsrdhiohdpshgthhgurdifsh dpohhpvghnghhrohhuphdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant Subject: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports Date: Wed, 8 Feb 2023 15:58:23 -0500 Message-Id: <8c476ad1d36919f31c3d37edc813182e8f1489e8.1675889602.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch changes miscellaneous links that are not used by any automated tool. Some of these links are dead anyway. Signed-off-by: Demi Marie Obenour --- COPYING | 4 ++-- CREDITS | 2 +- README | 4 ++-- SUPPORT.md | 2 +- docs/features/feature-levelling.pandoc | 4 ++-- docs/features/intel_psr_cat_cdp.pandoc | 2 +- docs/features/intel_psr_mba.pandoc | 2 +- docs/features/migration.pandoc | 2 +- docs/features/sched_credit.pandoc | 4 ++-- docs/features/sched_credit2.pandoc | 6 ++--- docs/features/sched_rtds.pandoc | 4 ++-- docs/misc/amd-ucode-container.txt | 4 ++-- docs/misc/arm/booting.txt | 4 ++-- docs/misc/arm/passthrough.txt | 2 +- docs/misc/kconfig-language.rst | 14 +++++------ docs/misc/livepatch.pandoc | 2 +- docs/misc/netif-staging-grants.pandoc | 10 ++++---- docs/misc/pvcalls.pandoc | 18 +++++++-------- docs/misc/status-override-table-spec.fodt | 2 +- docs/misc/vtd-pi.txt | 6 ++--- docs/misc/vtd.txt | 4 ++-- docs/misc/xen-env-table-spec.fodt | 2 +- docs/misc/xenstore-paths.pandoc | 2 +- docs/misc/xl-psr.pandoc | 2 +- docs/misc/xsm-flask.txt | 2 +- docs/process/release-technician-checklist.txt | 2 +- docs/process/sending-patches.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- m4/README.source | 4 ++-- m4/ax_compare_version.m4 | 4 ++-- m4/ocaml.m4 | 2 +- m4/pkg.m4 | 2 +- misc/coverity/model.c | 2 +- stubdom/vtpmmgr/tpmrsa.c | 4 +--- stubdom/vtpmmgr/tpmrsa.h | 2 +- tools/configure | 12 +++++----- tools/examples/xeninfo.pl | 4 ++-- tools/firmware/Makefile | 2 +- tools/firmware/etherboot/README | 23 +------------------ tools/firmware/hvmloader/pci_regs.h | 2 +- tools/firmware/hvmloader/pir.c | 2 +- tools/firmware/hvmloader/pir_types.h | 2 +- tools/firmware/hvmloader/smbios_types.h | 2 +- tools/firmware/rombios/32bit/pmm.c | 2 +- tools/firmware/rombios/rombios.c | 4 ++-- tools/firmware/vgabios/README | 10 ++++---- tools/firmware/vgabios/vbe.c | 2 +- tools/firmware/vgabios/vbe_display_api.txt | 8 +++---- tools/firmware/vgabios/vgabios.c | 8 +++---- tools/fuzz/README.afl | 2 +- tools/hotplug/Linux/xendomains.in | 2 +- tools/include/libxenvchan.h | 2 +- tools/include/libxl.h | 2 +- tools/libacpi/build.c | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 4 ++-- tools/libfsimage/zfs/zfs_sha256.c | 2 +- tools/libs/light/libxl_genid.c | 2 +- tools/libs/stat/xenstat_qmp.c | 2 +- tools/misc/mkrpm | 2 +- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 2 +- tools/ocaml/libs/xl/xenlight_stubs.c | 2 +- tools/tests/vhpet/main.c | 2 +- tools/xenstore/talloc.c | 2 +- tools/xenstore/talloc_guide.txt | 2 +- tools/xl/check-xl-disk-parse | 6 ++--- xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/arm64/head.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 3 +-- xen/arch/arm/arm64/lib/memcpy.S | 2 +- xen/arch/arm/arm64/lib/memmove.S | 2 +- xen/arch/arm/arm64/lib/memset.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 2 +- xen/arch/arm/arm64/lib/strlen.S | 2 +- xen/arch/arm/arm64/lib/strncmp.S | 2 +- xen/arch/arm/arm64/lib/strnlen.S | 2 +- xen/arch/arm/include/asm/smccc.h | 2 +- xen/arch/arm/include/asm/tee/optee_smc.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 6 ++--- xen/arch/x86/cpu/mcheck/mce_amd.c | 8 +++---- xen/arch/x86/cpu/microcode/core.c | 4 +--- xen/arch/x86/cpu/microcode/intel.c | 4 ++-- xen/arch/x86/dmi_scan.c | 5 ++++ xen/arch/x86/include/asm/edd.h | 4 ++-- xen/arch/x86/include/asm/hpet.h | 2 +- xen/common/README.source | 6 ++--- xen/common/bunzip2.c | 5 ++-- xen/common/lz4/decompress.c | 6 ++--- xen/common/lzo.c | 8 +++---- xen/common/rcupdate.c | 6 ++--- xen/common/unlzma.c | 6 ++--- xen/common/unlzo.c | 2 +- xen/common/xmalloc_tlsf.c | 4 ++-- xen/common/xz/crc32.c | 2 +- xen/common/xz/dec_bcj.c | 2 +- xen/common/xz/dec_lzma2.c | 2 +- xen/common/xz/lzma2.h | 2 +- xen/common/xz/stream.h | 2 +- xen/common/zstd/bitstream.h | 2 +- xen/common/zstd/entropy_common.c | 2 +- xen/common/zstd/fse.h | 2 +- xen/common/zstd/fse_decompress.c | 2 +- xen/common/zstd/huf.h | 2 +- xen/common/zstd/huf_decompress.c | 2 +- xen/crypto/README.source | 4 ++-- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/pci.c | 4 ++-- xen/include/acpi/actbl3.h | 2 +- xen/include/crypto/README.source | 4 ++-- xen/include/crypto/vmac.h | 5 ++-- xen/include/efi/eficapsule.h | 2 +- xen/include/public/arch-x86/hvm/start_info.h | 2 +- xen/include/public/errno.h | 2 +- xen/include/public/grant_table.h | 2 +- xen/include/public/hvm/params.h | 2 +- xen/include/public/io/blkif.h | 4 ++-- xen/include/public/io/libxenvchan.h | 2 +- xen/include/public/io/tpmif.h | 2 +- xen/include/xen/compiler.h | 2 +- xen/include/xen/elfstructs.h | 4 ++-- xen/include/xen/lzo.h | 2 +- xen/include/xen/pci_regs.h | 4 ++-- xen/include/xen/rcupdate.h | 6 ++--- xen/include/xen/xxhash.h | 2 +- xen/lib/rbtree.c | 2 +- xen/lib/xxhash32.c | 2 +- xen/lib/xxhash64.c | 2 +- 127 files changed, 212 insertions(+), 235 deletions(-) diff --git a/COPYING b/COPYING index 824c3aa353b47507241831f4753590f86a162014..74ebc2a18ac2fb407a92e48f59e1b6f3828ad2ba 100644 --- a/COPYING +++ b/COPYING @@ -16,9 +16,9 @@ the *License Exceptions* section of this file. When these code sections are compiled as part of a GPLv2-licensed program, such as Xen, the result is licensed under GPLv2. See the FSF's definition of GPL compatibility: - http://www.gnu.org/licenses/gpl-faq.html#WhatDoesCompatMean + https://www.gnu.org/licenses/gpl-faq.html#WhatDoesCompatMean And how this applies to a range of open source licenses: - http://www.gnu.org/licenses/license-list.html + https://www.gnu.org/licenses/license-list.html A number of files will also specify GPL exceptions, such as - Autoconf exception diff --git a/CREDITS b/CREDITS index 3ddcdbaac64c47d95f13091e00146cfbde7cc58b..741856859c787820a83782611c6cd6ee95fe4176 100644 --- a/CREDITS +++ b/CREDITS @@ -11,6 +11,6 @@ N: Jeremy Fitzhardinge E: jeremy@goop.org -W: http://www.goop.org/~jeremy +W: https://www.goop.org/~jeremy P: 1B40B6D0 D: Linux pvops diff --git a/README b/README index f8cc426f78d690f37e013242e81d4e440556c330..aca8182c9f17e8457515fd9e2f7c66b486e93557 100644 --- a/README +++ b/README @@ -206,7 +206,7 @@ Tboot is an open source, pre- kernel/VMM module that uses Intel(R) TXT to perform a measured and verified launch of an OS kernel/VMM. The Trusted Boot module is available from -http://sourceforge.net/projects/tboot. This project hosts the code in a -mercurial repo at http://tboot.sourceforge.net/hg/tboot.hg and contains +https://sourceforge.net/projects/tboot. This project hosts the code in a +mercurial repo at https://tboot.sourceforge.net/hg/tboot.hg and contains tarballs of the source. Instructions in the tboot README describe how to modify grub.conf to use tboot to launch Xen. diff --git a/SUPPORT.md b/SUPPORT.md index 295369998e6ac07f11c1a4e0783bd5a87ee948e9..479d64802c46cb84be89802d230d6f7594d92265 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -1122,6 +1122,6 @@ External projects that provide their own security support for Xen-related featur * FreeBSD https://www.freebsd.org/security/ - * NetBSD http://www.netbsd.org/support/security/ + * NetBSD https://www.netbsd.org/support/security/ * OpenBSD https://www.openbsd.org/security.html diff --git a/docs/features/feature-levelling.pandoc b/docs/features/feature-levelling.pandoc index 171a42c358409f4ab24f0d783628187a367c15b8..0b3659ec8920771d33c6a9813535f5648ff92169 100644 --- a/docs/features/feature-levelling.pandoc +++ b/docs/features/feature-levelling.pandoc @@ -202,9 +202,9 @@ Corruption) # References -[Intel Flexmigration](http://www.intel.co.uk/content/dam/www/public/us/en/documents/application-notes/virtualization-technology-flexmigration-application-note.pdf) +[Intel Flexmigration](https://www.intel.co.uk/content/dam/www/public/us/en/documents/application-notes/virtualization-technology-flexmigration-application-note.pdf) -[AMD Extended Migration Technology](http://developer.amd.com/wordpress/media/2012/10/43781-3.00-PUB_Live-Virtual-Machine-Migration-on-AMD-processors.pdf) +[AMD Extended Migration Technology](https://developer.amd.com/wordpress/media/2012/10/43781-3.00-PUB_Live-Virtual-Machine-Migration-on-AMD-processors.pdf) # History diff --git a/docs/features/intel_psr_cat_cdp.pandoc b/docs/features/intel_psr_cat_cdp.pandoc index 1fb02ea1e6746ee2e87e12bb08c0454997ed397a..a05d6b084597c88c8ea2539cd37798f8de788d67 100644 --- a/docs/features/intel_psr_cat_cdp.pandoc +++ b/docs/features/intel_psr_cat_cdp.pandoc @@ -448,7 +448,7 @@ N/A # References -"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) +"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) # History diff --git a/docs/features/intel_psr_mba.pandoc b/docs/features/intel_psr_mba.pandoc index 86df661ba8866b2d0a099682230ffad1b97f4408..b46ab657043e5ead4afd8d0e982da5678868cf9d 100644 --- a/docs/features/intel_psr_mba.pandoc +++ b/docs/features/intel_psr_mba.pandoc @@ -242,7 +242,7 @@ N/A # References -"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) +"INTEL RESOURCE DIRECTOR TECHNOLOGY (INTEL RDT) ALLOCATION FEATURES" [Intel 64 and IA-32 Architectures Software Developer Manuals, vol3](https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html) # History diff --git a/docs/features/migration.pandoc b/docs/features/migration.pandoc index 5334536d48f5250d9f755fbe43f2dd6bf7126bf8..d1c8086daf0c979390d8a214e9526ce46eb4e614 100644 --- a/docs/features/migration.pandoc +++ b/docs/features/migration.pandoc @@ -111,7 +111,7 @@ scenarios, which will involve starting with VMs from Xen 4.5 Xen Developer Summit 2015 Presentation [video](https://www.youtube.com/watch?v=RwiDeG21lrc) and -[slides](http://events.linuxfoundation.org/sites/events/files/slides/migv2.pdf) +[slides](https://events.linuxfoundation.org/sites/events/files/slides/migv2.pdf) for Migration v2 # History diff --git a/docs/features/sched_credit.pandoc b/docs/features/sched_credit.pandoc index 706513de6e449eec33f4864eed18cb327a053b42..974d47db16894ab83ad9c41280f3dd68a45fcce4 100644 --- a/docs/features/sched_credit.pandoc +++ b/docs/features/sched_credit.pandoc @@ -85,8 +85,8 @@ by also doing the following: * [potential non-ideal behavior on hyperthreaded systems](https://lists.xenproject.org/archives/html/xen-devel/2014-07/msg01848.html) [1] * [long standing BOOST vs. migration bug](https://lists.xen.org/archives/html/xen-devel/2015-10/msg02851.html) [2] * [priority handling issues](https://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01362.html) [3] -* "Scheduler development update", XenSummit Asia 2009 [whitepaper](http://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) [4] -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "Scheduler development update", XenSummit Asia 2009 [whitepaper](https://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) [4] +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) * "The Credit Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Credit_Scheduler) * "Xen Project Schedulers" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Xen_Project_Schedulers) diff --git a/docs/features/sched_credit2.pandoc b/docs/features/sched_credit2.pandoc index 436ff9f8f6ad4df0ff1410e768b2570faeb77485..95c739ee21eeb6b8034037cdabf6e6e777573fb0 100644 --- a/docs/features/sched_credit2.pandoc +++ b/docs/features/sched_credit2.pandoc @@ -91,9 +91,9 @@ following: # References -* "Scheduler development update", XenSummit Asia 2009 [whitepaper](http://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) -* "Scope and Performance of Credit-2 Scheduler" [XPDS16 Presentation](http://www.slideshare.net/xen_com_mgr/xpds16-scope-and-performance-of-credit2-scheduler-anshul-makkar-ctirix-systems-uk-ltd) +* "Scheduler development update", XenSummit Asia 2009 [whitepaper](https://www-archive.xenproject.org/files/xensummit_intel09/George_Dunlap.pdf) +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "Scope and Performance of Credit-2 Scheduler" [XPDS16 Presentation](https://www.slideshare.net/xen_com_mgr/xpds16-scope-and-performance-of-credit2-scheduler-anshul-makkar-ctirix-systems-uk-ltd) * "The Credit2 Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Credit2_Scheduler_Development) * "Xen Project Schedulers" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/Xen_Project_Schedulers) diff --git a/docs/features/sched_rtds.pandoc b/docs/features/sched_rtds.pandoc index 4ccf704b53d08cd6ef618e3b521c293b87eb88ad..5c03d67f48df4c41a913e2a89a09630806388206 100644 --- a/docs/features/sched_rtds.pandoc +++ b/docs/features/sched_rtds.pandoc @@ -105,8 +105,8 @@ at a macroscopic level), the following should be done: # References -* "RT-Xen: Real-Time Virtualization" [XPDS14 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/2014_Xen_Developer_Summit_0.pdf) -* "Scheduling in Xen" [XPDS15 Presentation](http://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) +* "RT-Xen: Real-Time Virtualization" [XPDS14 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/2014_Xen_Developer_Summit_0.pdf) +* "Scheduling in Xen" [XPDS15 Presentation](https://events.linuxfoundation.org/sites/events/files/slides/Faggioli_XenSummit.pdf) * [RT-Xen Project](https://sites.google.com/site/realtimexen/) * [RTDS-Based-Scheduler](https://wiki.xenproject.org/wiki/RTDS-Based-Scheduler) * "The RTDS Scheduler" [on the Xen-Project wiki](https://wiki.xenproject.org/wiki/RTDS-Based-Scheduler) diff --git a/docs/misc/amd-ucode-container.txt b/docs/misc/amd-ucode-container.txt index 1db64662d56707e928fb39784bc31d51b25b5cfb..c5bfd08e65344b75e6e451a0cb151d5ead614b1a 100644 --- a/docs/misc/amd-ucode-container.txt +++ b/docs/misc/amd-ucode-container.txt @@ -85,6 +85,6 @@ they should obtain a "good" set by downloading them from source links Reference(s): ------------- -[1] http://www.amd64.org/microcode.html +[1] https://www.amd64.org/microcode.html [2] https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tree/amd-ucode -[3] http://lxr.free-electrons.com/source/Documentation/x86/early-microcode.txt +[3] https://lxr.free-electrons.com/source/Documentation/x86/early-microcode.txt diff --git a/docs/misc/arm/booting.txt b/docs/misc/arm/booting.txt index 02f7bb65ec6d99e0f2f72e769847406610ec4873..cfc423a4898b4d3b7135a102bedd25b18fbadb4d 100644 --- a/docs/misc/arm/booting.txt +++ b/docs/misc/arm/booting.txt @@ -62,10 +62,10 @@ Xen relies on some settings the firmware has to configure in EL3 before starting [1] linux/Documentation/arm/booting.rst -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst +Latest version: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/booting.rst [2] linux/Documentation/arm64/booting.rst -Latest version: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst +Latest version: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm64/booting.rst [3] legacy format header Latest version: https://source.denx.de/u-boot/u-boot/-/blob/master/include/image.h#L315 diff --git a/docs/misc/arm/passthrough.txt b/docs/misc/arm/passthrough.txt index 4f0a024818a2b6f1610cd7a12c26b5532dba042d..c3f6c29fca583939e7fb7ae30f02a4bcff2343ea 100644 --- a/docs/misc/arm/passthrough.txt +++ b/docs/misc/arm/passthrough.txt @@ -50,7 +50,7 @@ Note: - ranges - #address-cells - #size-cells - * See http://www.devicetree.org/Device_Tree_Usage for more + * See https://www.devicetree.org/Device_Tree_Usage for more information about device tree. * In this example, the device MMIO region is placed at a different address (0x10000000) compared to the host address (0xfff51000) diff --git a/docs/misc/kconfig-language.rst b/docs/misc/kconfig-language.rst index 74bef19f69f0a8078f2f988358ff57046b46210b..f13fdb7ddc3739af4a89f3f93f8814d3815d69b5 100644 --- a/docs/misc/kconfig-language.rst +++ b/docs/misc/kconfig-language.rst @@ -669,10 +669,10 @@ and real world requirements were not well understood. As it stands though only reverse engineering techniques have been used to deduce semantics from variability modeling languages such as Kconfig [3]_. -.. [0] http://www.eng.uwaterloo.ca/~shshe/kconfig_semantics.pdf -.. [1] http://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf -.. [2] http://gsd.uwaterloo.ca/sites/default/files/ase241-berger_0.pdf -.. [3] http://gsd.uwaterloo.ca/sites/default/files/icse2011.pdf +.. [0] https://www.eng.uwaterloo.ca/~shshe/kconfig_semantics.pdf +.. [1] https://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf +.. [2] https://gsd.uwaterloo.ca/sites/default/files/ase241-berger_0.pdf +.. [3] https://gsd.uwaterloo.ca/sites/default/files/icse2011.pdf Full SAT solver for Kconfig ~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -691,10 +691,10 @@ such efforts somehow on Kconfig. There is enough interest from mentors of existing projects to not only help advise how to integrate this work upstream but also help maintain it long term. Interested developers should visit: -http://kernelnewbies.org/KernelProjects/kconfig-sat +https://kernelnewbies.org/KernelProjects/kconfig-sat -.. [4] http://www.cs.cornell.edu/~sabhar/chapters/SATSolvers-KR-Handbook.pdf -.. [5] http://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf +.. [4] https://www.cs.cornell.edu/~sabhar/chapters/SATSolvers-KR-Handbook.pdf +.. [5] https://gsd.uwaterloo.ca/sites/default/files/vm-2013-berger.pdf .. [6] https://cados.cs.fau.de .. [7] https://vamos.cs.fau.de .. [8] https://undertaker.cs.fau.de diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc index d38e4ce074b399946aecdaedb4cb6fe5b8043b66..a94fb57eb568e85a25c93bf6a988f123d4e48443 100644 --- a/docs/misc/livepatch.pandoc +++ b/docs/misc/livepatch.pandoc @@ -993,7 +993,7 @@ The design of that is not discussed in this design. This is implemented in a seperate tool which lives in a seperate GIT repo. -Currently it resides at git://xenbits.xen.org/livepatch-build-tools.git +Currently it resides at https://xenbits.xen.org/git-http/livepatch-build-tools.git ### Exception tables and symbol tables growth diff --git a/docs/misc/netif-staging-grants.pandoc b/docs/misc/netif-staging-grants.pandoc index cb33028adc3dadc8a9fb2a7739af6e5027690f82..1643f852d0b8a80645c90f80d9c48e6d5045abcb 100644 --- a/docs/misc/netif-staging-grants.pandoc +++ b/docs/misc/netif-staging-grants.pandoc @@ -399,7 +399,7 @@ Depending on the implementation, it would mean that we no longer would need to aggregate as much as grant ops as possible (step 1) and could transmit the packet on the transmit function (e.g. Linux ```ndo_start_xmit```) as previously proposed -here\[[0](http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html)\]. +here\[[0](https://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html)\]. This would heavily improve efficiency specifially for smaller packets. Which in return would decrease RTT, having data being acknoledged much quicker. @@ -548,7 +548,7 @@ the results. # References -[0] http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html +[0] https://lists.xenproject.org/archives/html/xen-devel/2015-05/msg01504.html [1] https://github.com/freebsd/freebsd/blob/master/sys/dev/netmap/netmap_mem2.c#L362 @@ -556,11 +556,11 @@ the results. [3] https://github.com/iovisor/bpf-docs/blob/master/Express_Data_Path.pdf -[4] http://prototype-kernel.readthedocs.io/en/latest/networking/XDP/design/requirements.html#write-access-to-packet-data +[4] https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/design/requirements.html#write-access-to-packet-data -[5] http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c#L2073 +[5] https://lxr.free-electrons.com/source/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c#L2073 -[6] http://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx4/en_rx.c#L52 +[6] https://lxr.free-electrons.com/source/drivers/net/ethernet/mellanox/mlx4/en_rx.c#L52 [7] https://schd.ws/hosted_files/xendeveloperanddesignsummit2017/e6/ToGrantOrNotToGrant-XDDS2017_v3.pdf diff --git a/docs/misc/pvcalls.pandoc b/docs/misc/pvcalls.pandoc index 971cd8f4b1225d70b5cca31a3fe5121ddb8ae459..e86eef84e441cbe74f9c19a8ed509146e8a331d2 100644 --- a/docs/misc/pvcalls.pandoc +++ b/docs/misc/pvcalls.pandoc @@ -1072,13 +1072,13 @@ reading from the socket. [xenstore]: https://xenbits.xen.org/docs/unstable/misc/xenstore.txt [XenbusStateInitialising]: https://xenbits.xen.org/docs/unstable/hypercall/x86_64/include,public,io,xenbus.h.html -[address]: http://pubs.opengroup.org/onlinepubs/7908799/xns/syssocket.h.html -[in]: http://pubs.opengroup.org/onlinepubs/000095399/basedefs/netinet/in.h.html -[socket]: http://pubs.opengroup.org/onlinepubs/009695399/functions/socket.html -[connect]: http://pubs.opengroup.org/onlinepubs/7908799/xns/connect.html -[shutdown]: http://pubs.opengroup.org/onlinepubs/7908799/xns/shutdown.html -[bind]: http://pubs.opengroup.org/onlinepubs/7908799/xns/bind.html -[listen]: http://pubs.opengroup.org/onlinepubs/7908799/xns/listen.html -[accept]: http://pubs.opengroup.org/onlinepubs/7908799/xns/accept.html -[poll]: http://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.html +[address]: https://pubs.opengroup.org/onlinepubs/7908799/xns/syssocket.h.html +[in]: https://pubs.opengroup.org/onlinepubs/000095399/basedefs/netinet/in.h.html +[socket]: https://pubs.opengroup.org/onlinepubs/009695399/functions/socket.html +[connect]: https://pubs.opengroup.org/onlinepubs/7908799/xns/connect.html +[shutdown]: https://pubs.opengroup.org/onlinepubs/7908799/xns/shutdown.html +[bind]: https://pubs.opengroup.org/onlinepubs/7908799/xns/bind.html +[listen]: https://pubs.opengroup.org/onlinepubs/7908799/xns/listen.html +[accept]: https://pubs.opengroup.org/onlinepubs/7908799/xns/accept.html +[poll]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.html [ring.h]: https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/io/ring.h;hb=HEAD diff --git a/docs/misc/status-override-table-spec.fodt b/docs/misc/status-override-table-spec.fodt index a831b7323b2bed31e19a06553b0ac40f1dfc797f..73c9061d98ef027a18539b8475bb030e788a0824 100644 --- a/docs/misc/status-override-table-spec.fodt +++ b/docs/misc/status-override-table-spec.fodt @@ -485,7 +485,7 @@ Title: Define a list of ACPI namespace names that are to be ignored by the OSPM License: - This work is licensed under the Creative Commons Attribution 4.0 International License. To view a copy of this license, visit http://creativecommons.org/licenses/by/4.0/ or send a letter to Creative Commons, 444 Castro Street, Suite 900, Mountain View, California, 94041, USA. + This work is licensed under the Creative Commons Attribution 4.0 International License. To view a copy of this license, visit https://creativecommons.org/licenses/by/4.0/ or send a letter to Creative Commons, 444 Castro Street, Suite 900, Mountain View, California, 94041, USA. Problem Statement: Hypervisors control which devices are allocated to which virtual machines. If ACPI tables created by platform firmware are passed directly from a hypervisor to a new virtual machine, the virtual machine can see all of the devices available to the hypervisor. This would be an incorrect view for the new virtual machine. By the same token, embedding the ability to create ACPI tables on the fly within a hypervisor adds more complexity and increases the resources needed by the hypervisor to run. To be clear, this is not a problem for the straightforward tables – such as the FADT, MADT, SRAT, or others – but is a problem for the DSDT and SSDT that contain AML byte codes. Generating AML byte codes on the fly would require the use of an ASL compiler, the most complex part of the tools needed to create ACPI tables. diff --git a/docs/misc/vtd-pi.txt b/docs/misc/vtd-pi.txt index d14b208c2781384fd2ea5ce5bd79666f790f71b2..4624a0f5a56824f1f5451303fb5d939cc50c2929 100644 --- a/docs/misc/vtd-pi.txt +++ b/docs/misc/vtd-pi.txt @@ -101,7 +101,7 @@ recorded in a data structure called a posted-interrupt descriptor. More information about APICv and CPU-side Posted-interrupt, please refer to Chapter "APIC VIRTUALIZATION AND VIRTUAL INTERRUPTS", and Section "POSTED-INTERRUPT PROCESSING" in the Intel SDM: -http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf +https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf - Root-Complex Support Interrupt posting is the process by which an interrupt request (from IOAPIC @@ -120,7 +120,7 @@ for the virtual-vectors and contains the attributes of the notification event interrupts recorded in the posted-interrupt descriptor. More information about VT-d PI, please refer to -http://www.intel.com/content/www/us/en/intelligent-systems/intel-technology/vt-directed-io-spec.html +https://www.intel.com/content/www/us/en/intelligent-systems/intel-technology/vt-directed-io-spec.html Design Overview ============== @@ -223,7 +223,7 @@ pCPU when an interrupt is recorded in the posted-interrupt descriptor. This existing global vector is a _special_ vector to CPU, CPU handle it in a _special_ way compared to normal vectors, please refer to 29.6 in Intel SDM -http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf +https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-manual-325462.pdf for more information about how CPU handles it. After having VT-d PI, VT-d engine can issue notification event when the diff --git a/docs/misc/vtd.txt b/docs/misc/vtd.txt index 89076a0776e4b23e0ec8e7600d65bc9f9a3f5980..61a042e15f69997a053e435bfac265f1ce1893bd 100644 --- a/docs/misc/vtd.txt +++ b/docs/misc/vtd.txt @@ -203,10 +203,10 @@ systems using following Intel motherboards: Feel free to add others as they become available. - Dell: Optiplex 755 -http://www.dell.com/content/products/category.aspx/optix?c=us&cs=555&l=en&s=biz +https://www.dell.com/content/products/category.aspx/optix?c=us&cs=555&l=en&s=biz - HP Compaq: DC7800 -http://h10010.www1.hp.com/wwpc/us/en/en/WF04a/12454-12454-64287-321860-3328898.html +https://h10010.www1.hp.com/wwpc/us/en/en/WF04a/12454-12454-64287-321860-3328898.html For more information, pls refer to https://wiki.xen.org/wiki/VTdHowTo. diff --git a/docs/misc/xen-env-table-spec.fodt b/docs/misc/xen-env-table-spec.fodt index ccde7a69814f01a47bb1c5db471d571c1bd31aca..174e5fd1288429d998fb6eb2df188b8ef52973a0 100644 --- a/docs/misc/xen-env-table-spec.fodt +++ b/docs/misc/xen-env-table-spec.fodt @@ -530,7 +530,7 @@ Title: Define Xen Environment table for passing Xen specific information to DOM0. License: - This work is licensed under the BSD License. To view a copy of this license, visit http://opensource.org/licenses/BSD-3-Clause. + This work is licensed under the BSD License. To view a copy of this license, visit https://opensource.org/licenses/BSD-3-Clause. Problem Statement: DOM0(Linux) requires additional information about the Xen environment for proper communication with Xen. DOM0 shares some memory pages with Xen and it need the address and size of the memory allocated to it. DOM0 also needs to configure interrupt that will be used for notification of events. The Xen Environment Table: diff --git a/docs/misc/xenstore-paths.pandoc b/docs/misc/xenstore-paths.pandoc index 5cd5c8a3b9391b12f5c603deacbfe72271cd8c25..1a502e1a5e28db53c4b3cc3ecf488792d94eae13 100644 --- a/docs/misc/xenstore-paths.pandoc +++ b/docs/misc/xenstore-paths.pandoc @@ -232,7 +232,7 @@ The BIOS used by this domain. These xenstore values are used to override some of the default string values in the SMBIOS table constructed in hvmloader. See the SMBIOS -table specification at http://www.dmtf.org/standards/smbios/ +table specification at https://www.dmtf.org/standards/smbios/ #### ~/bios-strings/oem-* = STRING [HVM,INTERNAL] diff --git a/docs/misc/xl-psr.pandoc b/docs/misc/xl-psr.pandoc index 3d196ed2edccb8df2717ebbc201465a2fbe78acc..b9de9af175fb7226c739646d95c38fbaabd9addc 100644 --- a/docs/misc/xl-psr.pandoc +++ b/docs/misc/xl-psr.pandoc @@ -251,4 +251,4 @@ hexadecimal value. ## Reference [1] Intel SDM -(http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html). +(https://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html). diff --git a/docs/misc/xsm-flask.txt b/docs/misc/xsm-flask.txt index 2419c5cf2916de736122be57c7ad88802a9bd0a2..281e450bcfbbe4a703d9c6bd4df21642d3c0ee88 100644 --- a/docs/misc/xsm-flask.txt +++ b/docs/misc/xsm-flask.txt @@ -93,7 +93,7 @@ rebuild. FLASK uses only one domain configuration parameter (seclabel) defining the full security label of the newly created domain. If using the example policy, "seclabel='system_u:system_r:domU_t'" is an example of a normal domain. The -labels are in the same format as SELinux labels; see http://selinuxproject.org +labels are in the same format as SELinux labels; see https://selinuxproject.org for more details on the use of the user, role, and optional MLS/MCS labels. FLASK policy overview diff --git a/docs/process/release-technician-checklist.txt b/docs/process/release-technician-checklist.txt index 4b061bf5f20bbb72e092e5930177374f9bb0c10f..7a077777ec162c580d6d2f8edb4ba0474c5172b3 100644 --- a/docs/process/release-technician-checklist.txt +++ b/docs/process/release-technician-checklist.txt @@ -23,7 +23,7 @@ t=RELEASE-$r # - check (for point releases, but not RCs) all XSAs have been applied (Lars) # * check, even for point releases -* http://logs.test-lab.xenproject.org/osstest/results/all-branch-statuses.txt +* https://logs.test-lab.xenproject.org/osstest/results/all-branch-statuses.txt # QEMU diff --git a/docs/process/sending-patches.pandoc b/docs/process/sending-patches.pandoc index 2e74c3b57ef5a5ee88230b3ca367ea56ab10846f..654ba2360592f85f6a9cc126c27417bbe428372c 100644 --- a/docs/process/sending-patches.pandoc +++ b/docs/process/sending-patches.pandoc @@ -82,7 +82,7 @@ modified form), the `Origin:` tag specifies the source of the patch: E.g.: - Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3 + Origin: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f093b08c47b3 The commit id should be shortened to its first 12 characters. diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index 8f80d61d2f1aa9e63da9b1e61b77a67c826efe6f..7826419dad563a3b70c3c97fc4c0fb5339bd58e9 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -271,7 +271,7 @@ Hi all, Xen X.Y rcZ is tagged. You can check that out from xen.git: -git://xenbits.xen.org/xen.git X.Y.0-rcZ +https://xenbits.xen.org/git-http/xen.git X.Y.0-rcZ For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/X.Y.0-rcZ/xen-X.Y.0-rcZ.tar.gz diff --git a/m4/README.source b/m4/README.source index 7a8719d9304cea05269e0b0cfaa32e343763c1e1..af730953ac0cb05ca45e9a03f031e5bc2b7764ec 100644 --- a/m4/README.source +++ b/m4/README.source @@ -6,9 +6,9 @@ m4 sources we have picked up or developed. ax_compare_version.m4 ===================== This file was fetched from -http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 -Also see http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +Also see https://www.gnu.org/software/autoconf-archive/ax_compare_version.html pkg.m4 ====== diff --git a/m4/ax_compare_version.m4 b/m4/ax_compare_version.m4 index 26f4dec2497e3b9667c558c72c9e3b74188f48be..8a8103e94beee8778045e720ea13ad8ea040b396 100644 --- a/m4/ax_compare_version.m4 +++ b/m4/ax_compare_version.m4 @@ -1,7 +1,7 @@ -# Fetched from http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +# Fetched from https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 # Commit ID: 27948f49ca30e4222bb7cdd55182bd7341ac50c5 # =========================================================================== -# http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +# https://www.gnu.org/software/autoconf-archive/ax_compare_version.html # =========================================================================== # # SYNOPSIS diff --git a/m4/ocaml.m4 b/m4/ocaml.m4 index b067ee942741d88522eb1955189408b157ab9ca6..90f44772a7628aa0f29d514b2f142d4660ea7e43 100644 --- a/m4/ocaml.m4 +++ b/m4/ocaml.m4 @@ -1,5 +1,5 @@ dnl autoconf macros for OCaml -dnl from http://forge.ocamlcore.org/ +dnl from https://forge.ocamlcore.org/ dnl dnl Copyright © 2009 Richard W.M. Jones dnl Copyright © 2009 Stefano Zacchiroli diff --git a/m4/pkg.m4 b/m4/pkg.m4 index ed7182d826339ebc7459ef61cb92c06128865389..bb59b15417268411e83f9ae6ba8fbe01faf2e38f 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -147,7 +147,7 @@ path to pkg-config. _PKG_TEXT -To get pkg-config, see .])[]dnl +To get pkg-config, see .])[]dnl ]) else $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS diff --git a/misc/coverity/model.c b/misc/coverity/model.c index 1ec3fe86735a542039a1bfb444cd94338e26ae09..aa48107e6e881b73adb06c71b8e25607dcecd774 100644 --- a/misc/coverity/model.c +++ b/misc/coverity/model.c @@ -21,7 +21,7 @@ * Copyright (c) 2013-2014 Citrix Systems Ltd; All Right Reserved * * Based on: - * http://hg.python.org/cpython/file/tip/Misc/coverity_model.c + * https://hg.python.org/cpython/file/tip/Misc/coverity_model.c * Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, * 2011, 2012, 2013 Python Software Foundation; All Rights Reserved * diff --git a/stubdom/vtpmmgr/tpmrsa.c b/stubdom/vtpmmgr/tpmrsa.c index b18a5a3af680a69c758da8cae531fd7999dbdbef..7731640f6899dfde21106b0a34575b70ca25699d 100644 --- a/stubdom/vtpmmgr/tpmrsa.c +++ b/stubdom/vtpmmgr/tpmrsa.c @@ -3,7 +3,7 @@ * * Copyright (C) 2006-2011, Brainspark B.V. * - * This file is part of PolarSSL (http://www.polarssl.org) + * This file is part of PolarSSL (https://www.polarssl.org) * Lead Maintainer: Paul Bakker * * All rights reserved. @@ -24,8 +24,6 @@ /* * RSA was designed by Ron Rivest, Adi Shamir and Len Adleman. * - * http://theory.lcs.mit.edu/~rivest/rsapaper.pdf - * http://www.cacr.math.uwaterloo.ca/hac/about/chap8.pdf */ #include "tcg.h" diff --git a/stubdom/vtpmmgr/tpmrsa.h b/stubdom/vtpmmgr/tpmrsa.h index 65fd32a45c58ec504a9d6ed93c40e312567fbd6d..efeb5f2a21e4ac43b3cda417c0c8cea62052087c 100644 --- a/stubdom/vtpmmgr/tpmrsa.h +++ b/stubdom/vtpmmgr/tpmrsa.h @@ -5,7 +5,7 @@ * * Copyright (C) 2006-2010, Brainspark B.V. * - * This file is part of PolarSSL (http://www.polarssl.org) + * This file is part of PolarSSL (https://www.polarssl.org) * Lead Maintainer: Paul Bakker * * All rights reserved. diff --git a/tools/configure b/tools/configure index dae377c98252b9daf491a55058d11d2bf3c3ad84..f6f13bfdc0901b0cea125c5ac13208c92e7b7a0f 100755 --- a/tools/configure +++ b/tools/configure @@ -3753,10 +3753,10 @@ esac -# Fetched from http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 +# Fetched from https://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 # Commit ID: 27948f49ca30e4222bb7cdd55182bd7341ac50c5 # =========================================================================== -# http://www.gnu.org/software/autoconf-archive/ax_compare_version.html +# https://www.gnu.org/software/autoconf-archive/ax_compare_version.html # =========================================================================== # # SYNOPSIS @@ -8376,7 +8376,7 @@ Alternatively, you may set the environment variables glib_CFLAGS and glib_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else glib_CFLAGS=$pkg_cv_glib_CFLAGS @@ -8467,7 +8467,7 @@ Alternatively, you may set the environment variables pixman_CFLAGS and pixman_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else pixman_CFLAGS=$pkg_cv_pixman_CFLAGS @@ -9923,7 +9923,7 @@ Alternatively, you may set the environment variables SYSTEMD_CFLAGS and SYSTEMD_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else SYSTEMD_CFLAGS=$pkg_cv_SYSTEMD_CFLAGS @@ -10018,7 +10018,7 @@ Alternatively, you may set the environment variables SYSTEMD_CFLAGS and SYSTEMD_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -To get pkg-config, see . +To get pkg-config, see . See \`config.log' for more details" "$LINENO" 5; } else SYSTEMD_CFLAGS=$pkg_cv_SYSTEMD_CFLAGS diff --git a/tools/examples/xeninfo.pl b/tools/examples/xeninfo.pl index 95a15d9595c0f4bf09c9429099bd3b27e98ebf3e..0e70b15db43f68cf82856aafdddcb9e8d798ea95 100644 --- a/tools/examples/xeninfo.pl +++ b/tools/examples/xeninfo.pl @@ -6,13 +6,13 @@ # ingard [at] mevaag [dot] no # # # # This work is licensed under the Creative Commons Attribution-Noncommercial-Share Alike 3.0 License. # -# To view a copy of this license, visit http://creativecommons.org/licenses/by-nc-sa/3.0/ or send a letter # +# To view a copy of this license, visit https://creativecommons.org/licenses/by-nc-sa/3.0/ or send a letter # # to Creative Commons, 171 Second Street, Suite 300, San Francisco, California, 94105, USA. # # # ############################################################################################################# use strict; -# http://search.cpan.org/~rjray/RPC-XML-0.59/lib/RPC/XML/Client.pm +# https://search.cpan.org/~rjray/RPC-XML-0.59/lib/RPC/XML/Client.pm require RPC::XML; require RPC::XML::Client; diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile index 345037b93b7f7987f0344f8a3ae86b4ec42a6caa..22e1d9dfaf88a74338e6521275574d9b775fa7b9 100644 --- a/tools/firmware/Makefile +++ b/tools/firmware/Makefile @@ -36,7 +36,7 @@ ifeq ($(CONFIG_ROMBIOS),y) @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \ echo "==========================================================================="; \ echo "Require dev86 rpm or bin86 & bcc debs version >= 0.16.14 to build firmware!"; \ - echo "(visit http://www.debath.co.uk/dev86/ for more information)"; \ + echo "(visit https://www.debath.co.uk/dev86/ for more information)"; \ echo "==========================================================================="; \ false ; \ fi diff --git a/tools/firmware/etherboot/README b/tools/firmware/etherboot/README index 5e3c1daf588fb33bc82238b818ba6aef5c8062e5..51c1d6db5bc7540a7495d281405355d796e5141b 100644 --- a/tools/firmware/etherboot/README +++ b/tools/firmware/etherboot/README @@ -1,28 +1,7 @@ - -This directory builds gPXE option ROMs from the gPXE source +This directory builds iPXE option ROMs from the iPXE source tarball. We provide this tarball in our source so that the option ROMs can be reconstructed from source, allowing easier debugging and fulfilling the terms of the GPL. We make a few non-standard settings, most to do with timeouts and when to give up, and for stricter DHCP spec compliance. - ----------------------------------------- - -Since gPXE upstream do not appear to distribute tarballs, we -generated one ourselves with the following runes (to extract the tree -as on 25th September 2008): - - git clone git://git.etherboot.org/scm/gpxe.git - cd gpxe - git archive --format=tar --prefix=gpxe/ c24bc349ead939d90b5784dbff3cd9fdb9d83ba8 | gzip -n >../gpxe-git-snapshot.tar.gz - ----------------------------------------- - -Previously, an image from Rom-o-matic.net was provided here, fetched -from the following URL: - -http://rom-o-matic.net/5.4.3/build.php?version=5.4.3&F=ignore&nic=rtl8139%3Artl8139+--+%5B0x10ec%2C0x8139%5D&ofmt=Binary+ROM+Image%28.zrom%29&arch=i386&ASK_BOOT=-1&BOOT_FIRST=BOOT_NIC&BOOT_SECOND=BOOT_NOTHING&BOOT_THIRD=BOOT_NOTHING&BOOT_INDEX=0&STATIC_CLIENT_IP=&STATIC_SUBNET_MASK=&STATIC_SERVER_IP=&STATIC_GATEWAY_IP=&STATIC_BOOTFILE=&EXIT_ON_FILE_LOAD_ERROR=on&DHCP_CLIENT_ID=&DHCP_CLIENT_ID_LEN=&DHCP_CLIENT_ID_TYPE=&DHCP_USER_CLASS=&DHCP_USER_CLASS_LEN=&ALLOW_ONLY_ENCAPSULATED=on&DEFAULT_BOOTFILE=&CONGESTED=on&BACKOFF_LIMIT=7&TIMEOUT=180&TRY_FLOPPY_FIRST=0&EXIT_IF_NO_OFFER=on&TAGGED_IMAGE=on&ELF_IMAGE=on&PXE_IMAGE=on&DOWNLOAD_PROTO_TFTP=on&COMCONSOLE=0x3F8&CONSPEED=9600&COMPARM=0x03&PXE_EXPORT=on&CONFIG_PCI=on&CONFIG_ISA=on&BUILD_ID=&PCBIOS=on&PXE_DHCP_STRICT=on&A=Get+ROM - -The mkhex script in tools/firmware/hvmloader will make the header file -from the downloaded image. diff --git a/tools/firmware/hvmloader/pci_regs.h b/tools/firmware/hvmloader/pci_regs.h index 7bf2d873ab644c5d342a7e4112a94814e62ce71c..4b093308f6af346afed7cf55c764fd46560bc700 100644 --- a/tools/firmware/hvmloader/pci_regs.h +++ b/tools/firmware/hvmloader/pci_regs.h @@ -6,7 +6,7 @@ * Copyright 1997--1999 Martin Mares * * For more information, please consult the following manuals (look at - * http://www.pcisig.com/ for how to get them): + * https://www.pcisig.com/ for how to get them): * * PCI BIOS Specification * PCI Local Bus Specification diff --git a/tools/firmware/hvmloader/pir.c b/tools/firmware/hvmloader/pir.c index cc420ddff48d0c4f748552fbddc106930796b903..369b4f9b903f961bf79ee2015384187084e40d1e 100644 --- a/tools/firmware/hvmloader/pir.c +++ b/tools/firmware/hvmloader/pir.c @@ -19,7 +19,7 @@ /* * The structure of these tables is described in - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ unsigned long create_pir_tables(void) { diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h index 9f9259c2e144420d4cb1db190a7af447283624ad..5129b0c7fd9a087810a299ee8930f755814a263b 100644 --- a/tools/firmware/hvmloader/pir_types.h +++ b/tools/firmware/hvmloader/pir_types.h @@ -17,7 +17,7 @@ * Copyright (C) Citrix Systems, 2011 * * See the PCI Interrupt Routing spec for more detail: - * http://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx + * https://www.microsoft.com/taiwan/whdc/archive/pciirq.mspx */ #ifndef PIR_TYPES_H diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h index 7c648ece71698af003f1600a150b1b77fe880254..3f1c120da60b6aa95cb2b6b1f03cc31d912832a4 100644 --- a/tools/firmware/hvmloader/smbios_types.h +++ b/tools/firmware/hvmloader/smbios_types.h @@ -19,7 +19,7 @@ * Authors: Andrew D. Ball * * See the SMBIOS 2.4 spec for more detail: - * http://www.dmtf.org/standards/smbios/ + * https://www.dmtf.org/standards/smbios/ */ #ifndef SMBIOS_TYPES_H diff --git a/tools/firmware/rombios/32bit/pmm.c b/tools/firmware/rombios/32bit/pmm.c index 09fec427483f3385b621aebac505705e7f819630..e0e39fef68a7b8d1695738e5e6f3c045c6dceaa4 100644 --- a/tools/firmware/rombios/32bit/pmm.c +++ b/tools/firmware/rombios/32bit/pmm.c @@ -1,7 +1,7 @@ /* * pmm.c - POST(Power On Self Test) Memory Manager * according to the specification described in - * http://www.phoenix.com/NR/rdonlyres/873A00CF-33AC-4775-B77E-08E7B9754993/0/specspmm101.pdf + * https://www.phoenix.com/NR/rdonlyres/873A00CF-33AC-4775-B77E-08E7B9754993/0/specspmm101.pdf * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public diff --git a/tools/firmware/rombios/rombios.c b/tools/firmware/rombios/rombios.c index 5cda22785f6f62cd54956cc04dff687fd51f07b6..52ba4a988f262f41b6d98ce41cca791db13c21be 100644 --- a/tools/firmware/rombios/rombios.c +++ b/tools/firmware/rombios/rombios.c @@ -733,7 +733,7 @@ typedef struct { // for access to EBDA area // The EBDA structure should conform to - // http://www.frontiernet.net/~fys/rombios.htm document + // https://www.frontiernet.net/~fys/rombios.htm document // I made the ata and cdemu structs begin at 0x121 in the EBDA seg // EBDA must be at most 768 bytes; it lives at EBDA_SEG, and the boot // device tables are at EBDA_SEG:IPL_TABLE_OFFSET @@ -2058,7 +2058,7 @@ print_bios_banner() // We also don't support letting option ROMs register as bootable disk // drives (BCVs), only as bootable devices (BEVs). // -// http://www.phoenix.com/en/Customer+Services/White+Papers-Specs/pc+industry+specifications.htm +// https://www.phoenix.com/en/Customer+Services/White+Papers-Specs/pc+industry+specifications.htm //-------------------------------------------------------------------------- static char drivetypes[][10]={"", "Floppy","Hard Disk","CD-Rom", "Network"}; diff --git a/tools/firmware/vgabios/README b/tools/firmware/vgabios/README index a21fef1e8b809df92f59ea946155ac0d1b8cf915..ccc1379ab18089ac0ad37ae6a1a7bc2414f7437c 100644 --- a/tools/firmware/vgabios/README +++ b/tools/firmware/vgabios/README @@ -72,8 +72,8 @@ These fonts are public domain The source code is based on information taken from : - Kevin Lawton's vga card emulation for bochs/plex86 - Ralf Brown's interrupts list avalaible at - http://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html -- Finn Thogersons' VGADOC4b available at http://home.worldonline.dk/~finth/ + https://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html +- Finn Thogersons' VGADOC4b available at https://home.worldonline.dk/~finth/ - Michael Abrash's Graphics Programming Black Book - Francois Gervais' book "programmation des cartes graphiques cga-ega-vga" edited by sybex @@ -83,9 +83,9 @@ The source code is based on information taken from : Feedback -------- Please report any bugs, comments, patches for this VGA Bios to info@vruppert.de -You can find the latest release at : http://www.nongnu.org/vgabios/ -For any information on bochs, visit the website http://bochs.sourceforge.net/ -For any information on qemu, visit the website http://fabrice.bellard.free.fr/qemu/ +You can find the latest release at : https://www.nongnu.org/vgabios/ +For any information on bochs, visit the website https://bochs.sourceforge.net/ +For any information on qemu, visit the website https://fabrice.bellard.free.fr/qemu/ History diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c index c5066906d3d001f8246566ed0e207e40659ac9a6..8e6408733ae68bdc582054ee58778c03f180b220 100644 --- a/tools/firmware/vgabios/vbe.c +++ b/tools/firmware/vgabios/vbe.c @@ -48,7 +48,7 @@ extern char vbebios_product_revision; ASM_START // FIXME: 'merge' these (c) etc strings with the vgabios.c strings? _vbebios_copyright: -.ascii "Bochs/Plex86 VBE(C) 2003 http://savannah.nongnu.org/projects/vgabios/" +.ascii "Bochs/Plex86 VBE(C) 2003 https://savannah.nongnu.org/projects/vgabios/" .byte 0x00 _vbebios_vendor_name: diff --git a/tools/firmware/vgabios/vbe_display_api.txt b/tools/firmware/vgabios/vbe_display_api.txt index fddb78b4bc713d153d1d08b95a639929a37d7b01..a365d2cc94aa36ef16dc730dd5886f69bc731fee 100644 --- a/tools/firmware/vgabios/vbe_display_api.txt +++ b/tools/firmware/vgabios/vbe_display_api.txt @@ -63,16 +63,16 @@ Todo References ---------- [VBE3] VBE 3 Specification at - http://www.vesa.org/vbe3.pdf + https://www.vesa.org/vbe3.pdf [BOCHS] Bochs Open Source IA-32 Emulator at - http://bochs.sourceforge.net + https://bochs.sourceforge.net [VBEBIOS] VBE Bios for Bochs at - http://savannah.gnu.org/projects/vgabios/ + https://savannah.gnu.org/projects/vgabios/ [Screenshots] Screenshots of programs using the VBE Bios at - http://japj.org/projects/bochs_plex86/screenshots.html + https://japj.org/projects/bochs_plex86/screenshots.html Abbreviations ------------- diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c index 1c75b7de96c2b366f910ffb7ed4a7833d53a59da..3ad98ca254a4ce8e7359a8a2d1a259b098ab927b 100644 --- a/tools/firmware/vgabios/vgabios.c +++ b/tools/firmware/vgabios/vgabios.c @@ -36,7 +36,7 @@ // // This VGA Bios is based on information taken from : // - Kevin Lawton's vga card emulation for bochs/plex86 -// - Ralf Brown's interrupts list available at http://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html +// - Ralf Brown's interrupts list available at https://www.cs.cmu.edu/afs/cs/user/ralf/pub/WWW/files.html // - Finn Thogersons' VGADOC4b available at http://home.worldonline.dk/~finth/ // - Michael Abrash's Graphics Programming Black Book // - Francois Gervais' book "programmation des cartes graphiques cga-ega-vga" edited by sybex @@ -193,11 +193,11 @@ vgabios_license: vgabios_website: .ascii "Please visit :" .byte 0x0a,0x0d -;;.ascii " . http://www.plex86.org" +;;.ascii " . https://www.plex86.org" ;;.byte 0x0a,0x0d -.ascii " . http://bochs.sourceforge.net" +.ascii " . https://bochs.sourceforge.net" .byte 0x0a,0x0d -.ascii " . http://www.nongnu.org/vgabios" +.ascii " . https://www.nongnu.org/vgabios" .byte 0x0a,0x0d .byte 0x0a,0x0d .byte 0x00 diff --git a/tools/fuzz/README.afl b/tools/fuzz/README.afl index a59564985ab773d4123feaffd8224c9ae6b1cc0d..d9d7138cafb9e494e14af223710e1a02d05421c4 100644 --- a/tools/fuzz/README.afl +++ b/tools/fuzz/README.afl @@ -2,7 +2,7 @@ Some fuzzing targets have American Fuzzy Lop (AFL) support. -See also http://lcamtuf.coredump.cx/afl/ +See also https://lcamtuf.coredump.cx/afl/ # HOW IT WORKS diff --git a/tools/hotplug/Linux/xendomains.in b/tools/hotplug/Linux/xendomains.in index 70f4129ef4bf24da30b05e5b568c01e39ed384bd..e713e6521933f768add60cb085c29e1137e83d10 100644 --- a/tools/hotplug/Linux/xendomains.in +++ b/tools/hotplug/Linux/xendomains.in @@ -12,7 +12,7 @@ # # Based on the example in the "Designing High Quality Integrated Linux # Applications HOWTO" by Avi Alkalay -# +# # ### BEGIN INIT INFO # Provides: xendomains diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index 30cc73cf97e30d81732ad084eeac3838bb3841de..ad771866e44321f6c880733a3df8e9315c2b348e 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -25,7 +25,7 @@ * * @section DESCRIPTION * - * Originally borrowed from the Qubes OS Project, http://www.qubes-os.org, + * Originally borrowed from the Qubes OS Project, https://www.qubes-os.org, * this code has been substantially rewritten to use the gntdev and gntalloc * devices instead of raw MFNs and map_foreign_range. * diff --git a/tools/include/libxl.h b/tools/include/libxl.h index d652895075a056ce6ec29f7b0623a0686eb84f36..6016b7b67598f6ac330819ef3df3bc4d003a30c4 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -2518,7 +2518,7 @@ static inline void libxl_cpuid_set(libxl_ctx *ctx __attribute__((unused)), * userid Data contents * "xl" domain config file in xl format, Unix line endings * "libvirt-xml" domain config file in libvirt XML format. See - * http://libvirt.org/formatdomain.html + * https://libvirt.org/formatdomain.html * "domain-userdata-lock" lock file to protect domain userdata in libxl. * It's a per-domain lock. Applications should * not touch this file. diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index fe2db66a62e68b92bdcbc1949e0de2900cec6e6c..a58a8ebf06de6e0a265cf8b5c41cceae8cf6d0a2 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -563,7 +563,7 @@ int acpi_build_tables(struct acpi_ctxt *ctxt, struct acpi_config *config) * into a 116 bytes buffer thus causing an overflow. The solution is to * link the higher revision FADT with the XSDT only and introduce a * compatible revision 1 FADT that is linked with the RSDT. Refer to: - * http://www.acpi.info/presentations/S01USMOBS169_OS%20new.ppt + * https://www.acpi.info/presentations/S01USMOBS169_OS%20new.ppt */ fadt_10 = ctxt->mem_ops.alloc(ctxt, sizeof(struct acpi_10_fadt), 16); if (!fadt_10) goto oom; diff --git a/tools/libfsimage/reiserfs/fsys_reiserfs.c b/tools/libfsimage/reiserfs/fsys_reiserfs.c index 10ca65747678716d571afe9755158c4e10c56150..299b257e999426547199753508fcf76f1d440ed7 100644 --- a/tools/libfsimage/reiserfs/fsys_reiserfs.c +++ b/tools/libfsimage/reiserfs/fsys_reiserfs.c @@ -658,7 +658,7 @@ reiserfs_mount (fsi_file_t *ffi, const char *options) /***************** TREE ACCESSING METHODS *****************************/ /* I assume you are familiar with the ReiserFS tree, if not go to - * http://www.namesys.com/content_table.html + * https://www.namesys.com/content_table.html * * My tree node cache is organized as following * 0 ROOT node diff --git a/tools/libfsimage/xfs/xfs.h b/tools/libfsimage/xfs/xfs.h index 40699281e44d6a9587ef40a61563d71424292a4a..e9f93531d82aa12264ef3b4c8bbc8f56d9c7d58f 100644 --- a/tools/libfsimage/xfs/xfs.h +++ b/tools/libfsimage/xfs/xfs.h @@ -25,11 +25,11 @@ * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, * Mountain View, CA 94043, or: * - * http://www.sgi.com + * https://www.sgi.com * * For further information regarding this notice, see: * - * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/ + * https://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/ */ typedef signed char xfs_int8_t; diff --git a/tools/libfsimage/zfs/zfs_sha256.c b/tools/libfsimage/zfs/zfs_sha256.c index 616fc0a78069dbb162c24048d77551848db196db..18a5c05008ef4a5f5b2cec57e343ed8ea1f9ccfe 100644 --- a/tools/libfsimage/zfs/zfs_sha256.c +++ b/tools/libfsimage/zfs/zfs_sha256.c @@ -26,7 +26,7 @@ /* * SHA-256 checksum, as specified in FIPS 180-2, available at: - * http://csrc.nist.gov/cryptval + * https://csrc.nist.gov/cryptval * * This is a very compact implementation of SHA-256. * It is designed to be simple and portable, not to be fast. diff --git a/tools/libs/light/libxl_genid.c b/tools/libs/light/libxl_genid.c index 7f52356c605237677d3568aa70bf42d02077bfc1..963381bd903985f7fe1d00206f4bba740e010bda 100644 --- a/tools/libs/light/libxl_genid.c +++ b/tools/libs/light/libxl_genid.c @@ -28,7 +28,7 @@ * See Microsoft's "Virtual Machine Generation ID" specification for * further details, including when a new generation ID is required. * - * http://www.microsoft.com/en-us/download/details.aspx?id=30707 + * https://www.microsoft.com/en-us/download/details.aspx?id=30707 */ int libxl_ms_vm_genid_generate(libxl_ctx *ctx, libxl_ms_vm_genid *id) { diff --git a/tools/libs/stat/xenstat_qmp.c b/tools/libs/stat/xenstat_qmp.c index 9909b9727e48cb0690a8aa25604ae9372786c420..399176ecff46eb2667b4cb5643eeb620c830f329 100644 --- a/tools/libs/stat/xenstat_qmp.c +++ b/tools/libs/stat/xenstat_qmp.c @@ -357,7 +357,7 @@ static int qmp_connect(char *path) } /* Gather the qdisk statistics by querying QMP - Resources: http://wiki.qemu.org/QMP and qmp-commands.hx from the qemu code + Resources: https://wiki.qemu.org/QMP and qmp-commands.hx from the qemu code QMP Syntax for entering command mode. This command must be issued before issuing any other command: In: {"execute": "qmp_capabilities"} diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm index 68819b2d739cea5491b53f9b944ee2bd20d92c2b..997d09133e23f680f1c0333653ca3d106715366e 100644 --- a/tools/misc/mkrpm +++ b/tools/misc/mkrpm @@ -34,7 +34,7 @@ Version: $version Release: $release License: GPL Group: System/Hypervisor -URL: http://xenbits.xenproject.org/xen.git +URL: https://xenbits.xenproject.org/ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root %define _binary_payload w1.gzdio diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c index e4306a0c2f8f03407a5c195de5b3d0350e9faf44..64f46ce571ffc2af803051983b03312ace000950 100644 --- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c +++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c @@ -52,7 +52,7 @@ static char * dup_String_val(value s) #include "_xtl_levels.inc" -/* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ +/* Option type support as per https://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ #ifndef Val_none #define Val_none Val_int(0) #endif diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c index 45b8af61c74ad8fbda1ef4b9f7027eba1183621f..10ca7259b0edf72ad8df85c682e9b434f264ea39 100644 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ b/tools/ocaml/libs/xl/xenlight_stubs.c @@ -226,7 +226,7 @@ static value Val_string_list(libxl_string_list *c_val) CAMLreturn(list); } -/* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ +/* Option type support as per https://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ #ifndef Val_none #define Val_none Val_int(0) #endif diff --git a/tools/tests/vhpet/main.c b/tools/tests/vhpet/main.c index 6fe65ea808c663d6c4618448bb4b4cea218cd11c..4054eec6296910d3117334091b3dac190f9aea29 100644 --- a/tools/tests/vhpet/main.c +++ b/tools/tests/vhpet/main.c @@ -14,7 +14,7 @@ */ /* - * http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf + * https://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/software-developers-hpet-spec-1-0a.pdf * * xen_source is a directory that has all xen source below it. * diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index 23c3a23b199f2318dd34786d1ae00b964dd1213a..9eda1bfc00c0b6b35d34ce25268fc9c070d9da55 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -26,7 +26,7 @@ */ /* - inspired by http://swapped.cc/halloc/ + inspired by https://swapped.cc/halloc/ */ #ifdef _SAMBA_BUILD_ diff --git a/tools/xenstore/talloc_guide.txt b/tools/xenstore/talloc_guide.txt index c23ac77cad72ab9265ee5af5bf5edbc1e6800380..bfcb35506b790570ab170cffbd280b674d8b6068 100644 --- a/tools/xenstore/talloc_guide.txt +++ b/tools/xenstore/talloc_guide.txt @@ -5,7 +5,7 @@ Andrew Tridgell September 2004 The most current version of this document is available at - http://samba.org/ftp/unpacked/samba4/source/lib/talloc/talloc_guide.txt + https://samba.org/ftp/unpacked/samba4/source/lib/talloc/talloc_guide.txt If you are used to talloc from Samba3 then please read this carefully, as talloc has changed a lot. diff --git a/tools/xl/check-xl-disk-parse b/tools/xl/check-xl-disk-parse index 18fb66940a5464d17a89d41fa5fa9c051c5c2606..5f843585ad51f036c5ce09598a90d7702f70ae61 100755 --- a/tools/xl/check-xl-disk-parse +++ b/tools/xl/check-xl-disk-parse @@ -133,7 +133,7 @@ disk: { EOF -# http://backdrift.org/xen-block-iscsi-script-with-multipath-support +# https://backdrift.org/xen-block-iscsi-script-with-multipath-support one 0 iscsi:iqn.2001-05.com.equallogic:0-8a0906-23fe93404-c82797962054a96d-examplehost,xvda,w one 0 vdev=xvda,access=w,script=block-iscsi,target=iqn.2001-05.com.equallogic:0-8a0906-23fe93404-c82797962054a96d-examplehost @@ -148,8 +148,8 @@ disk: { EOF -# http://lists.linbit.com/pipermail/drbd-user/2008-September/010221.html -# http://www.drbd.org/users-guide-emb/s-xen-configure-domu.html +# https://lists.linbit.com/pipermail/drbd-user/2008-September/010221.html +# https://www.drbd.org/users-guide-emb/s-xen-configure-domu.html one 0 drbd:app01,hda,w expected < diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index d7ae8919df777d90f872628ca2f0afa3c78a66dc..98c630fc86295ca38e248f9db8329e2a15794bda 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -24,7 +24,7 @@ * Issue Date: October 2013 * * URL: - * http://support.amd.com/TechDocs/24593.pdf + * https://support.amd.com/TechDocs/24593.pdf */ /* The related documentation for K8 Revisions A - E is: @@ -35,7 +35,7 @@ * Issue Date: February 2006 * * URL: - * http://support.amd.com/TechDocs/26094.PDF + * https://support.amd.com/TechDocs/26094.PDF */ /* The related documentation for K8 Revisions F - G is: @@ -46,7 +46,7 @@ * Issue Date: July 2007 * * URL: - * http://support.amd.com/TechDocs/32559.pdf + * https://support.amd.com/TechDocs/32559.pdf */ /* Family10 MCA documentation published at @@ -57,7 +57,7 @@ * Isse Date: January 11, 2013 * * URL: - * http://support.amd.com/TechDocs/31116.pdf + * https://support.amd.com/TechDocs/31116.pdf */ #include diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index d14754e222820aba46678bcbeb9efe3fb5d38903..3e588d4e2193e448f710ff5c113a2b3d97805bd9 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -11,9 +11,7 @@ * Software Developer's Manual * Order Number 253668 or free download from: * - * http://developer.intel.com/design/pentium4/manuals/253668.htm - * - * For more information, go to http://www.urbanmyth.org/microcode + * https://developer.intel.com/design/pentium4/manuals/253668.htm * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index f7fec4b4ed1066f4cb4cc4ba1a0b16b86ab66175..cb0f74c1fefe47ec20f85451c2e090322e712372 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -11,9 +11,9 @@ * Software Developer's Manual * Order Number 253668 or free download from: * - * http://developer.intel.com/design/pentium4/manuals/253668.htm + * https://developer.intel.com/design/pentium4/manuals/253668.htm * - * For more information, go to http://www.urbanmyth.org/microcode + * For more information, go to https://www.urbanmyth.org/microcode * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License diff --git a/xen/arch/x86/dmi_scan.c b/xen/arch/x86/dmi_scan.c index 81f80c053a7a5472584508b0042629c4f15ac82a..499c546e8419a8dcf577ae22a2cc4a12daff3010 100644 --- a/xen/arch/x86/dmi_scan.c +++ b/xen/arch/x86/dmi_scan.c @@ -621,6 +621,11 @@ static const struct dmi_blacklist __initconstrel dmi_blacklist[] = { MATCH(DMI_BOARD_NAME, "i440BX-W83977 (BP6)"), NO_MATCH, NO_MATCH }}, + { force_acpi_ht, "ABIT i440BX-W83977", { + MATCH(DMI_BOARD_VENDOR, "ABIT "), + MATCH(DMI_BOARD_NAME, "i440BX-W83977 (BP6)"), + NO_MATCH, NO_MATCH }}, + { force_acpi_ht, "IBM Bladecenter", { MATCH(DMI_BOARD_VENDOR, "IBM"), MATCH(DMI_BOARD_NAME, "IBM eServer BladeCenter HS20"), diff --git a/xen/arch/x86/include/asm/edd.h b/xen/arch/x86/include/asm/edd.h index afaa23732a385c71d5b3a1fb0be128e8deb69a84..9f8b8aa2219fc21e581e8d7aa00ce5bcffb3e188 100644 --- a/xen/arch/x86/include/asm/edd.h +++ b/xen/arch/x86/include/asm/edd.h @@ -7,8 +7,8 @@ * structures and definitions for the int 13h, ax={41,48}h * BIOS Enhanced Disk Drive Services * This is based on the T13 group document D1572 Revision 0 (August 14 2002) - * available at http://www.t13.org/docs2002/d1572r0.pdf. It is - * very similar to D1484 Revision 3 http://www.t13.org/docs2002/d1484r3.pdf + * available at https://www.t13.org/docs2002/d1572r0.pdf. It is + * very similar to D1484 Revision 3 https://www.t13.org/docs2002/d1484r3.pdf * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License v2.0 as published by diff --git a/xen/arch/x86/include/asm/hpet.h b/xen/arch/x86/include/asm/hpet.h index 9919f7473071d9d4cd81f1158f4189e7c0674f9e..b6840d768722d9d35820bfbcad343c08f82b1a27 100644 --- a/xen/arch/x86/include/asm/hpet.h +++ b/xen/arch/x86/include/asm/hpet.h @@ -3,7 +3,7 @@ /* * Documentation on HPET can be found at: - * http://www.intel.com/content/dam/www/public/us/en/documents/ + * https://www.intel.com/content/dam/www/public/us/en/documents/ * technical-specifications/software-developers-hpet-spec-1-0a.pdf */ diff --git a/xen/common/README.source b/xen/common/README.source index 732b9454c88abeddf6918e24d068129fc29e8c74..62a2033b104fd365ed456acf84f596fff5872721 100644 --- a/xen/common/README.source +++ b/xen/common/README.source @@ -26,7 +26,7 @@ The file is dually licensed under GPLv2.0 and LGPLv2.1 libelf ------ This directory was opriginally imported from the libelf -project at http://www.mr511.de/software/english.html +project at https://www.mr511.de/software/english.html This directory is licensed under LGPLv2.1 (see COPYING file) libfdt @@ -39,12 +39,12 @@ and a BSD 2-clause license lz4/decompress.c ----------------- This file was originally imported from the LZ4 project -( http://www.lz4.org). The source is available from +( https://www.lz4.org). The source is available from https://github.com/Cyan4973/lz4 The file is licensed under a BSD 2-clause license xz -- This directory was imported from the XZ Utils project -and is available under http://tukaani.org/xz/ +and is available under https://tukaani.org/xz/ The imported code is in the public domain diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c index 61b80aff1ba9bad72e7ce999ebe40198a21a83c1..167ffb7f73967111724b900b296bd6ebbd12711a 100644 --- a/xen/common/bunzip2.c +++ b/xen/common/bunzip2.c @@ -35,7 +35,7 @@ Phone (337) 232-1234 or 1-800-738-2226 Fax (337) 232-1297 - http://www.hospiceacadiana.com/ + https://www.hospiceacadiana.com/ Manuel */ @@ -469,8 +469,7 @@ got_huff_bits: (and repeated runs) for this block from the input stream, and decoded them into the intermediate buffer. There are dbufCount many decoded bytes in dbuf[]. Now undo the - Burrows-Wheeler transform on dbuf. See - http://dogma.net/markn/articles/bwt/bwt.htm + Burrows-Wheeler transform on dbuf. */ /* Turn byteCount into cumulative occurrence counts of 0 to n-1. */ j = 0; diff --git a/xen/common/lz4/decompress.c b/xen/common/lz4/decompress.c index 876906fac1a75e9f7900a2597817f82e4cb9f309..501bd4b343ffd444c4221864d1bdeec7b8a85b1d 100644 --- a/xen/common/lz4/decompress.c +++ b/xen/common/lz4/decompress.c @@ -7,7 +7,7 @@ * * LZ4 - Fast LZ compression algorithm * Copyright (C) 2011-2012, Yann Collet. - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are @@ -33,8 +33,8 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * * You can contact the author at : - * - LZ4 homepage : http://fastcompression.blogspot.com/p/lz4.html - * - LZ4 source repository : http://code.google.com/p/lz4/ + * - LZ4 homepage : https://fastcompression.blogspot.com/p/lz4.html + * - LZ4 source repository : https://code.google.com/p/lz4/ */ #include "defs.h" diff --git a/xen/common/lzo.c b/xen/common/lzo.c index a87c76ddedad72314aba334495469ac3aa2aca66..480a49dad309ec6b194d03248d1d407fba4e650a 100644 --- a/xen/common/lzo.c +++ b/xen/common/lzo.c @@ -4,7 +4,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Adapted for Xen (files combined and syntactic/header changes) by: * Dan Magenheimer @@ -17,7 +17,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta @@ -87,7 +87,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta @@ -112,7 +112,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c index 212a99acd8c8d4c2649b3bcc56bb163f87ba7b8b..70b4d21b0f1d6da758f1df0f1c5229c6afdf200e 100644 --- a/xen/common/rcupdate.c +++ b/xen/common/rcupdate.c @@ -25,11 +25,11 @@ * Based on the original work by Paul McKenney * and inputs from Rusty Russell, Andrea Arcangeli and Andi Kleen. * Papers: - * http://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf - * http://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) + * https://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf + * https://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) * * For detailed explanation of Read-Copy Update mechanism see - - * http://lse.sourceforge.net/locking/rcupdate.html + * https://lse.sourceforge.net/locking/rcupdate.html */ #include #include diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c index 6cd99023adf6a4e92244891297f5b0ed68653309..69448d7b398634b6543b1fcea7b6101724c17b36 100644 --- a/xen/common/unlzma.c +++ b/xen/common/unlzma.c @@ -8,7 +8,7 @@ * implementation for lzma. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (C) 1999-2005 Igor Pavlov * * Copyrights of the parts, see headers below. @@ -47,7 +47,7 @@ static long long __init read_int(unsigned char *ptr, int size) /* Small range coder implementation for lzma. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (c) 1999-2005 Igor Pavlov */ @@ -207,7 +207,7 @@ rc_bit_tree_decode(struct rc *rc, uint16_t *p, int num_levels, int *symbol) * Small lzma deflate implementation. * Copyright (C) 2006 Aurelien Jacobs < aurel@gnuage.org > * - * Based on LzmaDecode.c from the LZMA SDK 4.22 (http://www.7-zip.org/) + * Based on LzmaDecode.c from the LZMA SDK 4.22 (https://www.7-zip.org/) * Copyright (C) 1999-2005 Igor Pavlov */ diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c index 74056778ebecc070b38a82e8040657924f9cd13f..23eff1354fe0679299951abfb3fbe2bcc2adc699 100644 --- a/xen/common/unlzo.c +++ b/xen/common/unlzo.c @@ -26,7 +26,7 @@ * * Markus F.X.J. Oberhumer * - * http://www.oberhumer.com/opensource/lzop/ + * https://www.oberhumer.com/opensource/lzop/ */ #include "decompress.h" diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index 75bdf18c4ea7d4ea96a5eb51699a0354b7db166c..a0e986d36aa0569b145e9f2ad62f67c595ff1249 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -16,9 +16,9 @@ * Version 2.1 * * This is kernel port of TLSF allocator. - * Original code can be found at: http://rtportal.upv.es/rtmalloc/ + * Original code can be found at: https://rtportal.upv.es/rtmalloc/ * Adapted for Linux by Nitin Gupta (nitingupta910@gmail.com) - * (http://code.google.com/p/compcache/source/browse/trunk/sub-projects + * (https://code.google.com/p/compcache/source/browse/trunk/sub-projects * /allocators/tlsf-kmod r229 dated Aug 27, 2008 * Adapted for Xen by Dan Magenheimer (dan.magenheimer@oracle.com) */ diff --git a/xen/common/xz/crc32.c b/xen/common/xz/crc32.c index 092a74fbaba81e5fdf2f2b1f053f138941625d14..66cf046052fe40904c2e6efc125df9b5b9036f5f 100644 --- a/xen/common/xz/crc32.c +++ b/xen/common/xz/crc32.c @@ -2,7 +2,7 @@ * CRC32 using the polynomial from IEEE-802.3 * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/dec_bcj.c b/xen/common/xz/dec_bcj.c index bfa498587ab884d7148758f070c1f0d0cfa27c50..4070f3d533aef9ba1a6ac497fb8565a3e6d31a35 100644 --- a/xen/common/xz/dec_bcj.c +++ b/xen/common/xz/dec_bcj.c @@ -2,7 +2,7 @@ * Branch/Call/Jump (BCJ) filter decoders * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/dec_lzma2.c b/xen/common/xz/dec_lzma2.c index f80d8309f4c3cbcd1688aecc98deed5fd3c44d49..2521dacfe14fe3a909e96e425d4bd3766d749404 100644 --- a/xen/common/xz/dec_lzma2.c +++ b/xen/common/xz/dec_lzma2.c @@ -2,7 +2,7 @@ * LZMA2 decoder * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/lzma2.h b/xen/common/xz/lzma2.h index e0ef42e880a005099144df78a7c19b01d49410b2..acd70ffb7e7902cd2339899d36f84c609f946d36 100644 --- a/xen/common/xz/lzma2.h +++ b/xen/common/xz/lzma2.h @@ -2,7 +2,7 @@ * LZMA2 definitions * * Authors: Lasse Collin - * Igor Pavlov + * Igor Pavlov * * This file has been put into the public domain. * You can do whatever you want with this file. diff --git a/xen/common/xz/stream.h b/xen/common/xz/stream.h index d36d0fec6424ef23bb7f9d0c457c859171d995cd..7f34e66381a407e3e6535f6d4badda3c981f7f3a 100644 --- a/xen/common/xz/stream.h +++ b/xen/common/xz/stream.h @@ -12,7 +12,7 @@ /* * See the .xz file format specification at - * http://tukaani.org/xz/xz-file-format.txt + * https://tukaani.org/xz/xz-file-format.txt * to understand the container format. */ diff --git a/xen/common/zstd/bitstream.h b/xen/common/zstd/bitstream.h index 2b06d4551f03fe116b8420130155b10d8a71fe0d..2192cad3569b738b065e593c65a9858ba1702df8 100644 --- a/xen/common/zstd/bitstream.h +++ b/xen/common/zstd/bitstream.h @@ -4,7 +4,7 @@ * header file (to include) * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/entropy_common.c b/xen/common/zstd/entropy_common.c index d329cccc608c3de6279b8ad84472e402b860761c..81d37b1a521555d86b945ec79e76c26daedd68e4 100644 --- a/xen/common/zstd/entropy_common.c +++ b/xen/common/zstd/entropy_common.c @@ -2,7 +2,7 @@ * Common functions of New Generation Entropy library * Copyright (C) 2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/fse.h b/xen/common/zstd/fse.h index 5761e09f17ff209704959170d81a8cdada4b5c88..8db3773b17e3105f29667a8b366f41d4224114e2 100644 --- a/xen/common/zstd/fse.h +++ b/xen/common/zstd/fse.h @@ -3,7 +3,7 @@ * Public Prototypes declaration * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/fse_decompress.c b/xen/common/zstd/fse_decompress.c index ba5f960eb35dd6d71401045d673e581e114188b8..eb5abd6680169f039a3d04be2e3e689a4abef67f 100644 --- a/xen/common/zstd/fse_decompress.c +++ b/xen/common/zstd/fse_decompress.c @@ -2,7 +2,7 @@ * FSE : Finite State Entropy decoder * Copyright (C) 2013-2015, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/huf.h b/xen/common/zstd/huf.h index 0e091dbffe3df40081df16468a285fdab579cdbb..8b07da65cff813dd2170ae895d85576aac1cd01f 100644 --- a/xen/common/zstd/huf.h +++ b/xen/common/zstd/huf.h @@ -3,7 +3,7 @@ * header file * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/common/zstd/huf_decompress.c b/xen/common/zstd/huf_decompress.c index 1bdfc695d0537465d4e712d4f9bf5914f35a33a3..e7bfa9007daa2c6096261f2464e41b734d0b798c 100644 --- a/xen/common/zstd/huf_decompress.c +++ b/xen/common/zstd/huf_decompress.c @@ -2,7 +2,7 @@ * Huffman decoder, part of New Generation Entropy library * Copyright (C) 2013-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/crypto/README.source b/xen/crypto/README.source index 894045de28536dba2bc21a58c7753266ed549146..bdd85aec76ac59827e1c0209f3015d6b9def4f75 100644 --- a/xen/crypto/README.source +++ b/xen/crypto/README.source @@ -5,7 +5,7 @@ This documents the upstream sources for files in this directory. rijndael.c ========== This file comes from -http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ +https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ vmac.c ====== @@ -14,4 +14,4 @@ are in the files). See - https://en.wikipedia.org/wiki/VMAC -- http://www.fastcrypto.org/vmac/vmac.c +- https://www.fastcrypto.org/vmac/vmac.c diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 091f09b21752ab30b509ec3e2d216a5986a40d3d..682bf12aaaf5bd7b50afda56cdc9694984442c57 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -14,7 +14,7 @@ * Based on Linux's IPMMU-VMSA driver from Renesas BSP: * drivers/iommu/ipmmu-vmsa.c * you can found at: - * url: git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git + * url: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git * branch: v4.14.75-ltsi/rcar-3.9.6 * commit: e206eb5b81a60e64c35fbc3a999b1a0db2b98044 * and Xen's SMMU driver: diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index b42acb8d7c091932825f60e97bdc86b1a466d026..9f8819785b49f26d7a03e30d51ac5dd0d6700719 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) * Device [8086:2fc0] * Erratum HSE43 * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset - * http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x2fc0 }, /* * Devices [8086:6f60,6fa0,6fc0] * Errata BDF2 / BDX2 * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration - * http://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html */ { PCI_VENDOR_ID_INTEL, 0x6f60 }, { PCI_VENDOR_ID_INTEL, 0x6fa0 }, diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h index 0a6778421f60e5f4daa4476627a9ed54c6ff654a..6a0ede3c1924109699e7af391cf07d7fae62113a 100644 --- a/xen/include/acpi/actbl3.h +++ b/xen/include/acpi/actbl3.h @@ -95,7 +95,7 @@ * binary wire protocols." (Or ACPI tables and buffers.) "If you ask me, * this decision was a design error in C. Ritchie could have picked an order * and stuck with it." Norman Ramsey. - * See http://stackoverflow.com/a/1053662/41661 + * See https://stackoverflow.com/a/1053662/41661 */ /******************************************************************************* diff --git a/xen/include/crypto/README.source b/xen/include/crypto/README.source index 68de1cd1bb5bd2e5b0632176ae12a11f99aaf0b2..2c6325ec724dcfea0f209a9e450a86d0f7014611 100644 --- a/xen/include/crypto/README.source +++ b/xen/include/crypto/README.source @@ -5,7 +5,7 @@ This documents the upstream sources for files in this directory. rijndael.h ========== This file comes from -http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ +https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/crypto/ vmac.h ====== @@ -14,4 +14,4 @@ are in the files). See - https://en.wikipedia.org/wiki/VMAC -- http://www.fastcrypto.org/vmac/vmac.h +- https://www.fastcrypto.org/vmac/vmac.h diff --git a/xen/include/crypto/vmac.h b/xen/include/crypto/vmac.h index 457f3f5dd6da05c3e9c1e152e9338077ab17fdfe..022d49f6e20b03463dd2d8fb2be4329f62a44feb 100644 --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -62,9 +62,8 @@ typedef unsigned long long uint64_t; * This implementation supports two free AES implementations: OpenSSL's and * Paulo Barreto's. To use OpenSSL's, you will need to include the OpenSSL * crypto library (eg, gcc -lcrypto foo.c). For Barreto's, you will need - * to compile rijndael-alg-fst.c, last seen at http://www.iaik.tu-graz.ac.at/ - * research/krypto/AES/old/~rijmen/rijndael/rijndael-fst-3.0.zip and - * http://homes.esat.kuleuven.be/~rijmen/rijndael/rijndael-fst-3.0.zip. + * to compile rijndael-alg-fst.c, last seen at + * https://www.iaik.tu-graz.ac.at/research/krypto/AES/old/~rijmen/rijndael/rijndael-fst-3.0.zip and * To use a different implementation, use these definitions as a model. * ----------------------------------------------------------------------- */ #if VMAC_USE_OPENSSL diff --git a/xen/include/efi/eficapsule.h b/xen/include/efi/eficapsule.h index 481af2816af55b5f0ec3a0bf17198faee3b31983..45e98aafffdf83fbd4069186aafb26477b4ff0f0 100644 --- a/xen/include/efi/eficapsule.h +++ b/xen/include/efi/eficapsule.h @@ -4,7 +4,7 @@ Copyright (c) 2004 - 2007, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at -http://opensource.org/licenses/bsd-license.php +https://opensource.org/licenses/bsd-license.php THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. diff --git a/xen/include/public/arch-x86/hvm/start_info.h b/xen/include/public/arch-x86/hvm/start_info.h index e33557c0b4e98c6db3d3521710daa3838586733c..caef8972b24b638356611344b7dca088f9954b90 100644 --- a/xen/include/public/arch-x86/hvm/start_info.h +++ b/xen/include/public/arch-x86/hvm/start_info.h @@ -89,7 +89,7 @@ * The values used in the type field of the memory map table entries are * defined below and match the Address Range Types as defined in the "System * Address Map Interfaces" section of the ACPI Specification. Please refer to - * section 15 in version 6.2 of the ACPI spec: http://uefi.org/specifications + * section 15 in version 6.2 of the ACPI spec: https://uefi.org/specifications */ #define XEN_HVM_MEMMAP_TYPE_RAM 1 #define XEN_HVM_MEMMAP_TYPE_RESERVED 2 diff --git a/xen/include/public/errno.h b/xen/include/public/errno.h index 5a78a7607c0ddac82ea49a363a0a9fcfe2b885ae..5022e85194f930ef3f62765385b0fff1cfae00d0 100644 --- a/xen/include/public/errno.h +++ b/xen/include/public/errno.h @@ -54,7 +54,7 @@ enum xen_errno { * * The set of identifiers to be added here shouldn't extend beyond what * POSIX mandates (see e.g. - * http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html) + * https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html) * with the exception that we support some optional (XSR) values * specified there (but no new ones should be added). */ diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h index 1dfa17a6d02a34d55ad095ce392bbdf99e8424bb..0bfa1626f591f1566abfe5846f5d732664ec3733 100644 --- a/xen/include/public/grant_table.h +++ b/xen/include/public/grant_table.h @@ -43,7 +43,7 @@ /* Some rough guidelines on accessing and updating grant-table entries * in a concurrency-safe manner. For more information, Linux contains a * reference implementation for guest OSes (drivers/xen/grant_table.c, see - * http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD + * https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/xen/grant-table.c;hb=HEAD * * NB. WMB is a no-op on current-generation x86 processors. However, a * compiler barrier will still be required. diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h index a22b4ed45d2eb2dcaf61db9bef1f83b80d426a40..8d38c495f3e30291a518ca7979ffe8580defb5cd 100644 --- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -86,7 +86,7 @@ /* * Viridian enlightenments * - * (See http://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor%20Top%20Level%20Functional%20Specification%20v4.0.docx) + * (See https://download.microsoft.com/download/A/B/4/AB43A34E-BDD0-4FA6-BDEF-79EEF16E880B/Hypervisor%20Top%20Level%20Functional%20Specification%20v4.0.docx) * * To expose viridian enlightenments to the guest set this parameter * to the desired feature mask. The base feature set must be present diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 22f1eef0c0ca371a8cfe3eeea99f54bec1e234c9..6546f4cda9186cdde7fa4e782188970423db83b2 100644 --- a/xen/include/public/io/blkif.h +++ b/xen/include/public/io/blkif.h @@ -571,9 +571,9 @@ * command on a native device. * * More information about trim/unmap operations can be found at: - * http://t13.org/Documents/UploadedDocuments/docs2008/ + * https://t13.org/Documents/UploadedDocuments/docs2008/ * e07154r6-Data_Set_Management_Proposal_for_ATA-ACS2.doc - * http://www.seagate.com/staticfiles/support/disc/manuals/ + * https://www.seagate.com/staticfiles/support/disc/manuals/ * Interface%20manuals/100293068c.pdf * * Optional. See "feature-discard", "discard-alignment", diff --git a/xen/include/public/io/libxenvchan.h b/xen/include/public/io/libxenvchan.h index 2eab65cb195460446b0d4de5178dfa564c258476..3776937713d75c60629e0ef21f3ac69142e68fe5 100644 --- a/xen/include/public/io/libxenvchan.h +++ b/xen/include/public/io/libxenvchan.h @@ -13,7 +13,7 @@ * * @section DESCRIPTION * - * Originally borrowed from the Qubes OS Project, http://www.qubes-os.org, + * Originally borrowed from the Qubes OS Project, https://www.qubes-os.org, * this code has been substantially rewritten to use the gntdev and gntalloc * devices instead of raw MFNs and map_foreign_range. * diff --git a/xen/include/public/io/tpmif.h b/xen/include/public/io/tpmif.h index ad02dbaf1a312e9de30fbbd618fa02db9d4e1930..747f7259d804ea566536720e8b4dc7cacb38f335 100644 --- a/xen/include/public/io/tpmif.h +++ b/xen/include/public/io/tpmif.h @@ -71,7 +71,7 @@ typedef struct tpmif_tx_interface tpmif_tx_interface_t; * TPM may cancel a command if the interface is seized by another locality. * * The TPM command format is defined by the TCG, and is available at - * http://www.trustedcomputinggroup.org/resources/tpm_main_specification + * https://www.trustedcomputinggroup.org/resources/tpm_main_specification */ enum tpmif_state { diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h index a5631303348b16f7b5f737c9e94af4daf1d11527..f93c1b6ee8198cc7560808cdfab9ed72a74fc273 100644 --- a/xen/include/xen/compiler.h +++ b/xen/include/xen/compiler.h @@ -172,7 +172,7 @@ * ... * * This has already been reported upstream: - * http://bugs.llvm.org/show_bug.cgi?id=32595 + * https://bugs.llvm.org/show_bug.cgi?id=32595 */ #ifdef __clang__ # define CLANG_DISABLE_WARN_GCC_COMPAT_START \ diff --git a/xen/include/xen/elfstructs.h b/xen/include/xen/elfstructs.h index 06e6f87c3d800df44fbc254448b1f95537224971..42afd609c22030fb2cfd77277488e0981fa44dd4 100644 --- a/xen/include/xen/elfstructs.h +++ b/xen/include/xen/elfstructs.h @@ -45,7 +45,7 @@ typedef uint64_t Elf64_Xword; /* * e_ident[] identification indexes - * See http://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html + * See https://www.caldera.com/developers/gabi/2000-07-17/ch4.eheader.html */ #define EI_MAG0 0 /* file ID */ #define EI_MAG1 1 /* file ID */ @@ -374,7 +374,7 @@ typedef struct { /* * ARM32 relocation types. See - * http://infocenter.arm.com/help/topic/com.arm.doc.ihi0044f/IHI0044F_aaelf.pdf + * https://infocenter.arm.com/help/topic/com.arm.doc.ihi0044f/IHI0044F_aaelf.pdf * S - address of symbol. * A - addend for relocation (r_addend or need to extract from insn) * P - address of the dest being relocated (derieved from r_offset) diff --git a/xen/include/xen/lzo.h b/xen/include/xen/lzo.h index e920027fadaf3f272e798ef88777c886574c8809..899d61edd141cc531af902909708524345a90611 100644 --- a/xen/include/xen/lzo.h +++ b/xen/include/xen/lzo.h @@ -7,7 +7,7 @@ * Copyright (C) 1996-2012 Markus F.X.J. Oberhumer * * The full LZO package can be found at: - * http://www.oberhumer.com/opensource/lzo/ + * https://www.oberhumer.com/opensource/lzo/ * * Changed for Linux kernel use by: * Nitin Gupta diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index a90aff1712bafc6ed87296858803d16c253e7b53..bb7b83223254adc571eaef7b9713e4b044032edf 100644 --- a/xen/include/xen/pci_regs.h +++ b/xen/include/xen/pci_regs.h @@ -6,7 +6,7 @@ * Copyright 1997--1999 Martin Mares * * For more information, please consult the following manuals (look at - * http://www.pcisig.com/ for how to get them): + * https://www.pcisig.com/ for how to get them): * * PCI BIOS Specification * PCI Local Bus Specification @@ -14,7 +14,7 @@ * PCI System Design Guide * * For hypertransport information, please consult the following manuals - * from http://www.hypertransport.org + * from https://www.hypertransport.org * * The Hypertransport I/O Link Specification */ diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index 6f2587058edb4914768a88842741d534a64524df..f123b77aafaa1cb50ba6bceea88cfb4408e9cb6d 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -21,11 +21,11 @@ * Based on the original work by Paul McKenney * and inputs from Rusty Russell, Andrea Arcangeli and Andi Kleen. * Papers: - * http://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf - * http://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) + * https://www.rdrop.com/users/paulmck/paper/rclockpdcsproof.pdf + * https://lse.sourceforge.net/locking/rclock_OLS.2001.05.01c.sc.pdf (OLS2001) * * For detailed explanation of Read-Copy Update mechanism see - - * http://lse.sourceforge.net/locking/rcupdate.html + * https://lse.sourceforge.net/locking/rcupdate.html */ #ifndef __XEN_RCUPDATE_H diff --git a/xen/include/xen/xxhash.h b/xen/include/xen/xxhash.h index 6f2237cbcf8ef1eb0910c264f2868aa62d1ebdd6..1005654af0a01ac03f2da3747e4146ce15d16943 100644 --- a/xen/include/xen/xxhash.h +++ b/xen/include/xen/xxhash.h @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index eb418baabb12724f01f74c8dc55ec694b4d2427d..8b6c2c7572cd9793bbb77192704db27e04cb3988 100644 --- a/xen/lib/rbtree.c +++ b/xen/lib/rbtree.c @@ -24,7 +24,7 @@ #include /* - * red-black trees properties: http://en.wikipedia.org/wiki/Rbtree + * red-black trees properties: https://en.wikipedia.org/wiki/Rbtree * * 1) A node is either red or black * 2) The root is black diff --git a/xen/lib/xxhash32.c b/xen/lib/xxhash32.c index e8d403e5ced6588f0db7ea7064898919aa24671c..3bec28c91351cc9f26ae1121cc56a28230dc2135 100644 --- a/xen/lib/xxhash32.c +++ b/xen/lib/xxhash32.c @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are diff --git a/xen/lib/xxhash64.c b/xen/lib/xxhash64.c index 481e76fbcf4c880ec395b1be314126a6d8c89347..6cb9ee28ec34f792c52cd5e71f3a15af145994dc 100644 --- a/xen/lib/xxhash64.c +++ b/xen/lib/xxhash64.c @@ -2,7 +2,7 @@ * xxHash - Extremely Fast Hash algorithm * Copyright (C) 2012-2016, Yann Collet. * - * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php) + * BSD 2-Clause License (https://www.opensource.org/licenses/bsd-license.php) * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 20:58:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 20:58:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.491997.761412 (Exim 4.92) (envelope-from ) id 1pPrWq-0000WL-7G; Wed, 08 Feb 2023 20:58:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 491997.761412; Wed, 08 Feb 2023 20:58:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWq-0000W4-2C; Wed, 08 Feb 2023 20:58:56 +0000 Received: by outflank-mailman (input) for mailman id 491997; Wed, 08 Feb 2023 20:58:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPrWn-0007kX-T8 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 20:58:54 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 629c7584-a7f3-11ed-93b5-47a8fe42b414; Wed, 08 Feb 2023 21:58:49 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 003705C01AF; Wed, 8 Feb 2023 15:58:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 08 Feb 2023 15:58:49 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 15:58:44 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 629c7584-a7f3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1675889928; x=1675976328; bh=X82fmQZImoD02f0eAkPeqQQyL923jAeYmmh KA9iOEU4=; b=tdhLYHLTiCHhaamwBSa4QyGPGV7jQ5jYlpk4f8bJw93ACHUhRZT TwYdK1A+K6WPRA1RIH62xLkvGSyxuMkpoUWuyH7qhg3FawAVxCWcE0P7e48p5V11 bsuLldd4T+NvriP4bFK+C6e0DV1MYdCuxuZ3PCGVVo2KDXjNekDik6drnhNerpSJ 4qgVXItXciedTzYChW+C55MBqzL4whdMYqQJ+PuT9gdwOHcsZSXe7Nx/f1pRoEl0 /OTal96e3Tu4z/Xd+HQamZcS19bPqQ3EVMX5ncvcpqW7vycYVISVxuFlo3TEfmMz thaAw1TxNDGF+Ov7RiVu7v3aBfxkiKjhSHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1675889928; x=1675976328; bh=X82fmQZImoD02 f0eAkPeqQQyL923jAeYmmhKA9iOEU4=; b=jshWnjdL8HPWxFXreowHAmLk5SqDy hU9uvhES0IboW/Ec7S4X9nKxqkb4Sf3hXGkJBN02Yg7k0uk/rxhvkfoAlObQ+47z sc4bqIVDUUHNnbMaJz8esCx0KQYeeTn3BiTpNmETzo5sqGOncoWd8Hn+G2RB7WPb ZMLBJ1+NBQ3i5gpTHxmLeHyS62zf/TyKbB4RZbaBFHgz2/ZXmv8g/yAnT6z2uDXl LmQM5W7NxxLf18Pf8GHTKBULET0pX+72ISSF+zEqLWTfQXn4LRKhwT+1uG3MTp1Q GXcPMoa9/Of0XrEZ6mQyQZYBiLWzh7dHBhw363OjEX/nZw+DboG4YWV0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuefgveffffffgfefleevgeekgfeg udeivdehveefkeefuedtgeehgeduhefhvdevnecuffhomhgrihhnpehgnhhurdhorhhgpd grphhmsghiohhsrdhssgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Date: Wed, 8 Feb 2023 15:58:24 -0500 Message-Id: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch changes GPL boilerplate. Signed-off-by: Demi Marie Obenour --- m4/pkg.m4 | 2 +- m4/systemd.m4 | 2 +- stubdom/grub.patches/10graphics.diff | 4 ++-- stubdom/grub.patches/61btrfs.diff | 4 ++-- stubdom/vtpmmgr/tpmrsa.c | 2 +- stubdom/vtpmmgr/tpmrsa.h | 2 +- tools/configure | 4 ++-- tools/console/client/main.c | 2 +- tools/console/daemon/io.c | 2 +- tools/console/daemon/io.h | 2 +- tools/console/daemon/main.c | 2 +- tools/console/daemon/utils.c | 2 +- tools/console/daemon/utils.h | 2 +- tools/debugger/gdbsx/gx/gx.h | 2 +- tools/debugger/gdbsx/gx/gx_comm.c | 4 ++-- tools/debugger/gdbsx/gx/gx_local.c | 2 +- tools/debugger/gdbsx/gx/gx_main.c | 2 +- tools/debugger/gdbsx/gx/gx_utils.c | 2 +- tools/debugger/gdbsx/gx/xg_dummy.c | 2 +- tools/debugger/gdbsx/xg/xg_main.c | 2 +- tools/debugger/gdbsx/xg/xg_public.h | 2 +- tools/firmware/hvmloader/32bitbios_support.c | 2 +- tools/firmware/hvmloader/Makefile | 2 +- tools/firmware/hvmloader/cacheattr.c | 2 +- tools/firmware/hvmloader/e820.c | 2 +- tools/firmware/hvmloader/hvmloader.c | 2 +- tools/firmware/hvmloader/mp_tables.c | 2 +- tools/firmware/hvmloader/optionroms.c | 2 +- tools/firmware/hvmloader/ovmf.c | 2 +- tools/firmware/hvmloader/pci.c | 2 +- tools/firmware/hvmloader/pir_types.h | 2 +- tools/firmware/hvmloader/rombios.c | 2 +- tools/firmware/hvmloader/seabios.c | 2 +- tools/firmware/hvmloader/smbios.c | 2 +- tools/firmware/hvmloader/smbios_types.h | 2 +- tools/firmware/hvmloader/smp.c | 2 +- tools/firmware/hvmloader/tests.c | 2 +- tools/firmware/hvmloader/util.c | 2 +- tools/firmware/rombios/32bit/32bitbios.c | 2 +- tools/firmware/rombios/32bit/mkhex | 2 +- tools/firmware/rombios/32bit/pmm.c | 2 +- tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c | 2 +- tools/firmware/rombios/32bit/util.c | 2 +- tools/firmware/rombios/32bitgateway.c | 2 +- tools/firmware/rombios/apmbios.S | 2 +- tools/firmware/rombios/rombios.c | 2 +- tools/firmware/rombios/rombios.h | 2 +- tools/firmware/rombios/tcgbios.c | 2 +- tools/firmware/vgabios/COPYING | 2 +- tools/firmware/vgabios/biossums.c | 2 +- tools/firmware/vgabios/clext.c | 2 +- tools/firmware/vgabios/vbe.c | 2 +- tools/firmware/vgabios/vgabios.c | 2 +- tools/golang/xenlight/xenlight.go | 2 +- tools/hotplug/Linux/block-common.sh | 2 +- tools/hotplug/Linux/block-drbd-probe | 2 +- tools/hotplug/Linux/external-device-migrate | 2 +- tools/hotplug/Linux/launch-xenstore.in | 2 +- tools/hotplug/Linux/locking.sh | 2 +- tools/hotplug/Linux/logging.sh | 2 +- tools/hotplug/Linux/vif-common.sh | 2 +- tools/hotplug/Linux/xen-hotplug-common.sh.in | 2 +- tools/hotplug/Linux/xen-network-common.sh | 2 +- tools/hotplug/Linux/xen-script-common.sh | 2 +- tools/hotplug/NetBSD/locking.sh | 2 +- tools/include/libxenvchan.h | 2 +- tools/include/xencall.h | 2 +- tools/include/xenctrl.h | 2 +- tools/include/xendevicemodel.h | 2 +- tools/include/xenevtchn.h | 2 +- tools/include/xenforeignmemory.h | 2 +- tools/include/xengnttab.h | 2 +- tools/include/xenguest.h | 2 +- tools/include/xenhypfs.h | 2 +- tools/include/xenstore.h | 2 +- tools/include/xenstore_lib.h | 2 +- tools/include/xentoolcore.h | 2 +- tools/include/xentoolcore_internal.h | 2 +- tools/include/xentoollog.h | 2 +- tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 +- tools/libfsimage/fat/fat.h | 2 +- tools/libfsimage/fat/fsys_fat.c | 2 +- tools/libfsimage/iso9660/fsys_iso9660.c | 2 +- tools/libfsimage/iso9660/iso9660.h | 2 +- tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 +- tools/libfsimage/ufs/fsys_ufs.c | 2 +- tools/libfsimage/xfs/fsys_xfs.c | 2 +- tools/libfsimage/xfs/xfs.h | 2 +- tools/libfsimage/zfs/Makefile | 2 +- tools/libfsimage/zfs/filesys.h | 2 +- tools/libfsimage/zfs/fsi_zfs.c | 2 +- tools/libfsimage/zfs/fsi_zfs.h | 2 +- tools/libfsimage/zfs/fsys_zfs.c | 2 +- tools/libfsimage/zfs/fsys_zfs.h | 2 +- tools/libfsimage/zfs/mb_info.h | 2 +- tools/libfsimage/zfs/shared.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu.h | 2 +- tools/libfsimage/zfs/zfs-include/dmu_objset.h | 2 +- tools/libfsimage/zfs/zfs-include/dnode.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dataset.h | 2 +- tools/libfsimage/zfs/zfs-include/dsl_dir.h | 2 +- tools/libfsimage/zfs/zfs-include/sa_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/spa.h | 2 +- tools/libfsimage/zfs/zfs-include/uberblock_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/vdev_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_impl.h | 2 +- tools/libfsimage/zfs/zfs-include/zap_leaf.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_acl.h | 2 +- tools/libfsimage/zfs/zfs-include/zfs_znode.h | 2 +- tools/libfsimage/zfs/zfs-include/zil.h | 2 +- tools/libfsimage/zfs/zfs-include/zio.h | 2 +- tools/libfsimage/zfs/zfs-include/zio_checksum.h | 2 +- tools/libfsimage/zfs/zfs_fletcher.c | 2 +- tools/libfsimage/zfs/zfs_lzjb.c | 2 +- tools/libfsimage/zfs/zfs_sha256.c | 2 +- tools/libs/call/buffer.c | 2 +- tools/libs/call/core.c | 2 +- tools/libs/call/freebsd.c | 2 +- tools/libs/call/linux.c | 2 +- tools/libs/call/minios.c | 2 +- tools/libs/call/netbsd.c | 2 +- tools/libs/call/solaris.c | 2 +- tools/libs/ctrl/xc_altp2m.c | 2 +- tools/libs/ctrl/xc_cpu_hotplug.c | 2 +- tools/libs/ctrl/xc_cpupool.c | 2 +- tools/libs/ctrl/xc_csched.c | 2 +- tools/libs/ctrl/xc_csched2.c | 2 +- tools/libs/ctrl/xc_domain.c | 2 +- tools/libs/ctrl/xc_evtchn.c | 2 +- tools/libs/ctrl/xc_flask.c | 2 +- tools/libs/ctrl/xc_foreign_memory.c | 2 +- tools/libs/ctrl/xc_freebsd.c | 2 +- tools/libs/ctrl/xc_gnttab.c | 2 +- tools/libs/ctrl/xc_hcall_buf.c | 2 +- tools/libs/ctrl/xc_linux.c | 2 +- tools/libs/ctrl/xc_mem_access.c | 2 +- tools/libs/ctrl/xc_mem_paging.c | 2 +- tools/libs/ctrl/xc_memshr.c | 2 +- tools/libs/ctrl/xc_minios.c | 2 +- tools/libs/ctrl/xc_misc.c | 2 +- tools/libs/ctrl/xc_monitor.c | 2 +- tools/libs/ctrl/xc_netbsd.c | 2 +- tools/libs/ctrl/xc_pagetab.c | 2 +- tools/libs/ctrl/xc_physdev.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/ctrl/xc_rt.c | 2 +- tools/libs/ctrl/xc_solaris.c | 2 +- tools/libs/ctrl/xc_tbuf.c | 2 +- tools/libs/ctrl/xc_vm_event.c | 2 +- tools/libs/ctrl/xc_vmtrace.c | 2 +- tools/libs/devicemodel/common.c | 2 +- tools/libs/devicemodel/compat.c | 2 +- tools/libs/devicemodel/core.c | 2 +- tools/libs/evtchn/core.c | 2 +- tools/libs/evtchn/freebsd.c | 2 +- tools/libs/evtchn/linux.c | 2 +- tools/libs/evtchn/minios.c | 2 +- tools/libs/evtchn/netbsd.c | 2 +- tools/libs/evtchn/solaris.c | 2 +- tools/libs/foreignmemory/compat.c | 2 +- tools/libs/foreignmemory/core.c | 2 +- tools/libs/foreignmemory/freebsd.c | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/foreignmemory/minios.c | 2 +- tools/libs/foreignmemory/netbsd.c | 2 +- tools/libs/foreignmemory/solaris.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/gntshr_core.c | 2 +- tools/libs/gnttab/gntshr_unimp.c | 2 +- tools/libs/gnttab/gnttab_core.c | 2 +- tools/libs/gnttab/gnttab_unimp.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/gnttab/minios.c | 2 +- tools/libs/gnttab/netbsd.c | 2 +- tools/libs/guest/xg_core.c | 2 +- tools/libs/guest/xg_core.h | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_core_arm.h | 2 +- tools/libs/guest/xg_core_x86.c | 2 +- tools/libs/guest/xg_core_x86.h | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_armzimageloader.c | 2 +- tools/libs/guest/xg_dom_binloader.c | 2 +- tools/libs/guest/xg_dom_boot.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_compat_linux.c | 2 +- tools/libs/guest/xg_dom_core.c | 2 +- tools/libs/guest/xg_dom_elfloader.c | 2 +- tools/libs/guest/xg_dom_hvmloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_domain.c | 2 +- tools/libs/guest/xg_nomigrate.c | 2 +- tools/libs/guest/xg_offline_page.c | 2 +- tools/libs/guest/xg_private.c | 2 +- tools/libs/guest/xg_private.h | 2 +- tools/libs/guest/xg_resume.c | 2 +- tools/libs/guest/xg_save_restore.h | 2 +- tools/libs/guest/xg_suspend.c | 2 +- tools/libs/hypfs/core.c | 2 +- tools/libs/stat/COPYING | 2 +- tools/libs/store/xs.c | 2 +- tools/libs/toolcore/handlereg.c | 2 +- tools/libs/toollog/xtl_core.c | 2 +- tools/libs/toollog/xtl_logger_stdio.c | 2 +- tools/libs/util/libxlu_cfg_y.c | 2 +- tools/libs/util/libxlu_cfg_y.h | 2 +- tools/libs/vchan/init.c | 2 +- tools/libs/vchan/io.c | 2 +- tools/libs/vchan/vchan.h | 2 +- tools/misc/mkhex | 2 +- tools/misc/xen-mceinj.c | 2 +- tools/misc/xen-vmtrace.c | 2 +- tools/misc/xencov.c | 2 +- tools/misc/xenpm.c | 2 +- tools/misc/xenpvnetboot | 2 +- tools/ocaml/LICENSE | 2 +- tools/pygrub/src/ExtLinuxConf.py | 2 +- tools/pygrub/src/GrubConf.py | 2 +- tools/pygrub/src/pygrub | 2 +- tools/python/xen/lowlevel/xs/xs.c | 2 +- tools/tests/depriv/depriv-fd-checker.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/vhpet/main.c | 2 +- tools/tests/vpci/emul.h | 2 +- tools/tests/vpci/main.c | 2 +- tools/tests/x86_emulator/blowfish.c | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/vchan/node-select.c | 2 +- tools/vchan/node.c | 2 +- tools/vchan/vchan-socket-proxy.c | 2 +- tools/xenmon/COPYING | 2 +- tools/xenmon/setmask.c | 2 +- tools/xenmon/xenbaked.c | 2 +- tools/xenmon/xenbaked.h | 2 +- tools/xenmon/xenmon.py | 2 +- tools/xenpaging/file_ops.c | 2 +- tools/xenpaging/file_ops.h | 2 +- tools/xenpaging/policy.h | 2 +- tools/xenpaging/policy_default.c | 2 +- tools/xenpaging/xenpaging.c | 2 +- tools/xenpaging/xenpaging.h | 2 +- tools/xenpmd/xenpmd.c | 2 +- tools/xenstore/COPYING | 2 +- tools/xenstore/include/xenstore_state.h | 2 +- tools/xenstore/talloc.c | 2 +- tools/xenstore/talloc.h | 2 +- tools/xenstore/tdb.c | 2 +- tools/xenstore/tdb.h | 2 +- tools/xenstore/xenstored_control.c | 2 +- tools/xenstore/xenstored_control.h | 2 +- tools/xenstore/xenstored_core.c | 2 +- tools/xenstore/xenstored_core.h | 2 +- tools/xenstore/xenstored_domain.c | 2 +- tools/xenstore/xenstored_domain.h | 2 +- tools/xenstore/xenstored_minios.c | 2 +- tools/xenstore/xenstored_posix.c | 2 +- tools/xenstore/xenstored_transaction.c | 2 +- tools/xenstore/xenstored_transaction.h | 2 +- tools/xenstore/xenstored_watch.c | 2 +- tools/xenstore/xenstored_watch.h | 2 +- tools/xenstore/xs_lib.c | 2 +- tools/xenstore/xs_lib.h | 2 +- tools/xentop/xentop.c | 2 +- tools/xentrace/xenalyze.c | 2 +- xen/COPYING | 2 +- xen/arch/arm/acpi/boot.c | 2 +- xen/arch/arm/acpi/lib.c | 2 +- xen/arch/arm/arm32/insn.c | 2 +- xen/arch/arm/arm32/lib/bitops.c | 2 +- xen/arch/arm/arm32/lib/lib1funcs.S | 2 +- xen/arch/arm/arm32/lib/lshrdi3.S | 2 +- xen/arch/arm/arm64/bpi.S | 2 +- xen/arch/arm/arm64/cache.S | 2 +- xen/arch/arm/arm64/debug-meson.inc | 2 +- xen/arch/arm/arm64/debug-mvebu.inc | 2 +- xen/arch/arm/arm64/insn.c | 2 +- xen/arch/arm/arm64/lib/bitops.c | 2 +- xen/arch/arm/arm64/lib/clear_page.S | 2 +- xen/arch/arm/arm64/lib/memchr.S | 2 +- xen/arch/arm/arm64/lib/memcmp.S | 2 +- xen/arch/arm/arm64/lib/memcpy.S | 2 +- xen/arch/arm/arm64/lib/memmove.S | 2 +- xen/arch/arm/arm64/lib/memset.S | 2 +- xen/arch/arm/arm64/lib/strchr.S | 2 +- xen/arch/arm/arm64/lib/strcmp.S | 2 +- xen/arch/arm/arm64/lib/strlen.S | 2 +- xen/arch/arm/arm64/lib/strncmp.S | 2 +- xen/arch/arm/arm64/lib/strnlen.S | 2 +- xen/arch/arm/arm64/lib/strrchr.S | 2 +- xen/arch/arm/efi/efi-dom0.c | 2 +- xen/arch/arm/include/asm/acpi.h | 2 +- xen/arch/arm/include/asm/altp2m.h | 2 +- xen/arch/arm/include/asm/arm32/insn.h | 2 +- xen/arch/arm/include/asm/arm64/atomic.h | 2 +- xen/arch/arm/include/asm/arm64/insn.h | 2 +- xen/arch/arm/include/asm/arm64/io.h | 2 +- xen/arch/arm/include/asm/gic_v3_its.h | 2 +- xen/arch/arm/include/asm/iommu.h | 2 +- xen/arch/arm/include/asm/iommu_fwspec.h | 2 +- xen/arch/arm/include/asm/ioreq.h | 2 +- xen/arch/arm/include/asm/mem_access.h | 2 +- xen/arch/arm/include/asm/monitor.h | 2 +- xen/arch/arm/include/asm/new_vgic.h | 2 +- xen/arch/arm/include/asm/pci.h | 2 +- xen/arch/arm/include/asm/vm_event.h | 2 +- xen/arch/arm/include/asm/vpl011.h | 2 +- xen/arch/arm/include/asm/vpsci.h | 2 +- xen/arch/arm/pci/ecam.c | 2 +- xen/arch/arm/pci/pci-access.c | 2 +- xen/arch/arm/pci/pci-host-common.c | 2 +- xen/arch/arm/pci/pci-host-generic.c | 2 +- xen/arch/arm/pci/pci-host-zynqmp.c | 2 +- xen/arch/arm/pci/pci.c | 2 +- xen/arch/arm/platforms/thunderx.c | 2 +- xen/arch/arm/vgic/vgic-init.c | 2 +- xen/arch/arm/vgic/vgic-mmio.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/arm/vgic/vgic.h | 2 +- xen/arch/x86/acpi/boot.c | 2 +- xen/arch/x86/acpi/cpu_idle.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/acpi/cpuidle_menu.c | 2 +- xen/arch/x86/acpi/lib.c | 2 +- xen/arch/x86/alternative.c | 2 +- xen/arch/x86/boot/build32.lds | 2 +- xen/arch/x86/boot/cmdline.c | 2 +- xen/arch/x86/boot/defs.h | 2 +- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 2 +- xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- xen/arch/x86/cpu/mtrr/main.c | 2 +- xen/arch/x86/cpu/mwait-idle.c | 2 +- xen/arch/x86/cpu/vpmu.c | 2 +- xen/arch/x86/cpu/vpmu_amd.c | 2 +- xen/arch/x86/cpu/vpmu_intel.c | 2 +- xen/arch/x86/gdbstub.c | 2 +- xen/arch/x86/gdbsx.c | 2 +- xen/arch/x86/genapic/x2apic.c | 2 +- xen/arch/x86/guest/hyperv/hyperv.c | 2 +- xen/arch/x86/guest/hyperv/private.h | 2 +- xen/arch/x86/guest/hyperv/tlb.c | 2 +- xen/arch/x86/guest/hyperv/util.c | 2 +- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/guest/xen/xen.c | 2 +- xen/arch/x86/hvm/asid.c | 2 +- xen/arch/x86/hvm/dm.c | 2 +- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/hvm/domain.c | 2 +- xen/arch/x86/hvm/grant_table.c | 2 +- xen/arch/x86/hvm/hpet.c | 2 +- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/hypercall.c | 2 +- xen/arch/x86/hvm/intercept.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/ioreq.c | 2 +- xen/arch/x86/hvm/irq.c | 2 +- xen/arch/x86/hvm/monitor.c | 2 +- xen/arch/x86/hvm/mtrr.c | 2 +- xen/arch/x86/hvm/nestedhvm.c | 2 +- xen/arch/x86/hvm/pmtimer.c | 2 +- xen/arch/x86/hvm/quirks.c | 2 +- xen/arch/x86/hvm/save.c | 2 +- xen/arch/x86/hvm/svm/asid.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/entry.S | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svmdebug.c | 2 +- xen/arch/x86/hvm/svm/vmcb.c | 2 +- xen/arch/x86/hvm/vioapic.c | 2 +- xen/arch/x86/hvm/vlapic.c | 2 +- xen/arch/x86/hvm/vm_event.c | 2 +- xen/arch/x86/hvm/vmsi.c | 2 +- xen/arch/x86/hvm/vmx/entry.S | 2 +- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 2 +- xen/arch/x86/hvm/vmx/vvmx.c | 2 +- xen/arch/x86/hvm/vpt.c | 2 +- xen/arch/x86/hypercall.c | 2 +- xen/arch/x86/include/asm/acpi.h | 2 +- xen/arch/x86/include/asm/altp2m.h | 2 +- xen/arch/x86/include/asm/endbr.h | 2 +- xen/arch/x86/include/asm/guest.h | 2 +- xen/arch/x86/include/asm/guest/hyperv-hcall.h | 2 +- xen/arch/x86/include/asm/guest/hyperv.h | 2 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 2 +- xen/arch/x86/include/asm/guest/xen-hcall.h | 2 +- xen/arch/x86/include/asm/guest/xen.h | 2 +- xen/arch/x86/include/asm/guest_pt.h | 2 +- xen/arch/x86/include/asm/hap.h | 2 +- xen/arch/x86/include/asm/hvm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/grant_table.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 2 +- xen/arch/x86/include/asm/hvm/io.h | 2 +- xen/arch/x86/include/asm/hvm/ioreq.h | 2 +- xen/arch/x86/include/asm/hvm/irq.h | 2 +- xen/arch/x86/include/asm/hvm/monitor.h | 2 +- xen/arch/x86/include/asm/hvm/nestedhvm.h | 2 +- xen/arch/x86/include/asm/hvm/save.h | 2 +- xen/arch/x86/include/asm/hvm/support.h | 2 +- xen/arch/x86/include/asm/hvm/svm/asid.h | 2 +- xen/arch/x86/include/asm/hvm/svm/emulate.h | 2 +- xen/arch/x86/include/asm/hvm/svm/intr.h | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- xen/arch/x86/include/asm/hvm/vcpu.h | 2 +- xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- xen/arch/x86/include/asm/hvm/vlapic.h | 2 +- xen/arch/x86/include/asm/hvm/vm_event.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 2 +- xen/arch/x86/include/asm/hvm/vpt.h | 2 +- xen/arch/x86/include/asm/iommu.h | 2 +- xen/arch/x86/include/asm/ioreq.h | 2 +- xen/arch/x86/include/asm/mem_access.h | 2 +- xen/arch/x86/include/asm/mem_paging.h | 2 +- xen/arch/x86/include/asm/mem_sharing.h | 2 +- xen/arch/x86/include/asm/monitor.h | 2 +- xen/arch/x86/include/asm/p2m.h | 2 +- xen/arch/x86/include/asm/paging.h | 2 +- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/include/asm/pv/grant_table.h | 2 +- xen/arch/x86/include/asm/pv/mm.h | 2 +- xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/include/asm/pv/traps.h | 2 +- xen/arch/x86/include/asm/shadow.h | 2 +- xen/arch/x86/include/asm/shstk.h | 2 +- xen/arch/x86/include/asm/spec_ctrl.h | 2 +- xen/arch/x86/include/asm/spec_ctrl_asm.h | 2 +- xen/arch/x86/include/asm/traps.h | 2 +- xen/arch/x86/include/asm/vm_event.h | 2 +- xen/arch/x86/include/asm/vpmu.h | 2 +- xen/arch/x86/include/asm/xenoprof.h | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/altp2m.c | 2 +- xen/arch/x86/mm/guest_walk.c | 2 +- xen/arch/x86/mm/hap/guest_walk.c | 2 +- xen/arch/x86/mm/hap/hap.c | 2 +- xen/arch/x86/mm/hap/nested_ept.c | 2 +- xen/arch/x86/mm/hap/nested_hap.c | 2 +- xen/arch/x86/mm/hap/private.h | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/mem_paging.c | 2 +- xen/arch/x86/mm/mem_sharing.c | 2 +- xen/arch/x86/mm/mm-locks.h | 2 +- xen/arch/x86/mm/nested.c | 2 +- xen/arch/x86/mm/p2m-basic.c | 2 +- xen/arch/x86/mm/p2m-ept.c | 2 +- xen/arch/x86/mm/p2m-pod.c | 2 +- xen/arch/x86/mm/p2m-pt.c | 2 +- xen/arch/x86/mm/p2m.c | 2 +- xen/arch/x86/mm/p2m.h | 2 +- xen/arch/x86/mm/paging.c | 2 +- xen/arch/x86/mm/physmap.c | 2 +- xen/arch/x86/mm/shadow/common.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 2 +- xen/arch/x86/mm/shadow/multi.h | 2 +- xen/arch/x86/mm/shadow/private.h | 2 +- xen/arch/x86/mm/shadow/pv.c | 2 +- xen/arch/x86/mm/shadow/set.c | 2 +- xen/arch/x86/mm/shadow/types.h | 2 +- xen/arch/x86/monitor.c | 2 +- xen/arch/x86/msr.c | 2 +- xen/arch/x86/pv/callback.c | 2 +- xen/arch/x86/pv/descriptor-tables.c | 2 +- xen/arch/x86/pv/emul-gate-op.c | 2 +- xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 2 +- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/grant_table.c | 2 +- xen/arch/x86/pv/hypercall.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/misc-hypercalls.c | 2 +- xen/arch/x86/pv/mm.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 2 +- xen/arch/x86/pv/shim.c | 2 +- xen/arch/x86/pv/traps.c | 2 +- xen/arch/x86/smpboot.c | 2 +- xen/arch/x86/spec_ctrl.c | 2 +- xen/arch/x86/traps.c | 2 +- xen/arch/x86/vm_event.c | 2 +- xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- xen/arch/x86/x86_64/cpu_idle.c | 2 +- xen/arch/x86/x86_64/cpufreq.c | 2 +- xen/arch/x86/x86_64/gdbstub.c | 2 +- xen/arch/x86/x86_64/mm.c | 2 +- xen/arch/x86/x86_64/mmconfig.h | 2 +- xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- xen/common/argo.c | 2 +- xen/common/bunzip2.c | 2 +- xen/common/coverage/coverage.c | 2 +- xen/common/dm.c | 2 +- xen/common/event_channel.c | 2 +- xen/common/gdbstub.c | 2 +- xen/common/grant_table.c | 2 +- xen/common/ioreq.c | 2 +- xen/common/libelf/libelf-dominfo.c | 2 +- xen/common/libelf/libelf-loader.c | 2 +- xen/common/libelf/libelf-private.h | 2 +- xen/common/libelf/libelf-tools.c | 2 +- xen/common/mem_access.c | 2 +- xen/common/monitor.c | 2 +- xen/common/page_alloc.c | 2 +- xen/common/pdx.c | 2 +- xen/common/preempt.c | 2 +- xen/common/radix-tree.c | 2 +- xen/common/rcupdate.c | 2 +- xen/common/sched/null.c | 2 +- xen/common/stop_machine.c | 2 +- xen/common/time.c | 2 +- xen/common/unlzma.c | 2 +- xen/common/unlzo.c | 2 +- xen/common/vm_event.c | 2 +- xen/common/wait.c | 2 +- xen/drivers/acpi/apei/apei-base.c | 2 +- xen/drivers/acpi/apei/apei-io.c | 2 +- xen/drivers/acpi/apei/erst.c | 2 +- xen/drivers/acpi/apei/hest.c | 2 +- xen/drivers/acpi/numa.c | 2 +- xen/drivers/acpi/osl.c | 2 +- xen/drivers/acpi/pmstat.c | 2 +- xen/drivers/acpi/tables.c | 2 +- xen/drivers/char/consoled.c | 2 +- xen/drivers/char/meson-uart.c | 2 +- xen/drivers/char/mvebu-uart.c | 2 +- xen/drivers/char/xen_pv_console.c | 2 +- xen/drivers/char/xhci-dbc.c | 2 +- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/drivers/passthrough/amd/iommu-defs.h | 2 +- xen/drivers/passthrough/amd/iommu.h | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/drivers/passthrough/amd/iommu_cmd.c | 2 +- xen/drivers/passthrough/amd/iommu_detect.c | 2 +- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_init.c | 2 +- xen/drivers/passthrough/amd/iommu_intr.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/arm/iommu_fwspec.c | 2 +- xen/drivers/passthrough/arm/iommu_helpers.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/drivers/passthrough/ats.c | 2 +- xen/drivers/passthrough/ats.h | 2 +- xen/drivers/passthrough/iommu.c | 2 +- xen/drivers/passthrough/pci.c | 2 +- xen/drivers/passthrough/vtd/dmar.c | 2 +- xen/drivers/passthrough/vtd/dmar.h | 2 +- xen/drivers/passthrough/vtd/extern.h | 2 +- xen/drivers/passthrough/vtd/intremap.c | 2 +- xen/drivers/passthrough/vtd/iommu.c | 2 +- xen/drivers/passthrough/vtd/iommu.h | 2 +- xen/drivers/passthrough/vtd/qinval.c | 2 +- xen/drivers/passthrough/vtd/quirks.c | 2 +- xen/drivers/passthrough/vtd/utils.c | 2 +- xen/drivers/passthrough/vtd/vtd.h | 2 +- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- xen/drivers/passthrough/vtd/x86/hvm.c | 2 +- xen/drivers/passthrough/vtd/x86/vtd.c | 2 +- xen/drivers/passthrough/x86/hvm.c | 2 +- xen/drivers/passthrough/x86/iommu.c | 2 +- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 2 +- xen/drivers/vpci/vpci.c | 2 +- xen/include/xen/acpi.h | 2 +- xen/include/xen/argo.h | 2 +- xen/include/xen/atomic.h | 2 +- xen/include/xen/cper.h | 2 +- xen/include/xen/cpuidle.h | 2 +- xen/include/xen/dm.h | 2 +- xen/include/xen/gdbstub.h | 2 +- xen/include/xen/grant_table.h | 2 +- xen/include/xen/inttypes.h | 2 +- xen/include/xen/iommu.h | 2 +- xen/include/xen/ioreq.h | 2 +- xen/include/xen/mem_access.h | 2 +- xen/include/xen/monitor.h | 2 +- xen/include/xen/multiboot.h | 2 +- xen/include/xen/radix-tree.h | 2 +- xen/include/xen/rbtree.h | 2 +- xen/include/xen/rcupdate.h | 2 +- xen/include/xen/vm_event.h | 2 +- xen/lib/list-sort.c | 2 +- xen/lib/rbtree.c | 2 +- xen/xsm/silo.c | 2 +- 606 files changed, 610 insertions(+), 610 deletions(-) diff --git a/m4/pkg.m4 b/m4/pkg.m4 index bb59b15417268411e83f9ae6ba8fbe01faf2e38f..398cafe97b20c7a0ee74586b2ca247bc58e08570 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -14,7 +14,7 @@ # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # As a special exception to the GNU General Public License, if you # distribute this file as part of a program that contains a diff --git a/m4/systemd.m4 b/m4/systemd.m4 index 112dc11b5e05e11d730e33a133c08527cfb4990f..a0a1b856aaa59fc4b97a9a90c88029953b878a2b 100644 --- a/m4/systemd.m4 +++ b/m4/systemd.m4 @@ -13,7 +13,7 @@ # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . dnl Some optional path options AC_DEFUN([AX_SYSTEMD_OPTIONS], [ diff --git a/stubdom/grub.patches/10graphics.diff b/stubdom/grub.patches/10graphics.diff index 5ee2852fd7d7595c7fe17acbb6096ae96f04aaf4..5c1067ba9c31ada35086d8f2f4da989bfdfc7046 100644 --- a/stubdom/grub.patches/10graphics.diff +++ b/stubdom/grub.patches/10graphics.diff @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c grub-0.97/stage2/graphics.c + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program; If not, see ++ * along with this program; If not, see + */ + +#ifdef SUPPORT_GRAPHICS @@ -1769,7 +1769,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.h grub-0.97/stage2/graphics.h + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program; If not, see ++ * along with this program; If not, see + */ + +#ifndef GRAPHICS_H diff --git a/stubdom/grub.patches/61btrfs.diff b/stubdom/grub.patches/61btrfs.diff index ae8f866e509ef23ac3cb607651e56de193ef6c55..a96062e685e4f6a1922132e9ba6ee30abfd3c8aa 100644 --- a/stubdom/grub.patches/61btrfs.diff +++ b/stubdom/grub.patches/61btrfs.diff @@ -70,7 +70,7 @@ diff -up /dev/null grub-upstream.wip/stage2/btrfs.h + * General Public License for more details. + * + * You should have received a copy of the GNU General Public -+ * License along with this program; If not, see ++ * License along with this program; If not, see + */ + +/* include/asm-i386/types.h */ @@ -1561,7 +1561,7 @@ diff -up /dev/null grub-upstream.wip/stage2/fsys_btrfs.c + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License -+ * along with this program. If not, see . ++ * along with this program. If not, see . + */ + +#ifdef FSYS_BTRFS diff --git a/stubdom/vtpmmgr/tpmrsa.c b/stubdom/vtpmmgr/tpmrsa.c index 7731640f6899dfde21106b0a34575b70ca25699d..5a9f6b29e5831a9fbd7f920c1c5edbc0d9ad60d5 100644 --- a/stubdom/vtpmmgr/tpmrsa.c +++ b/stubdom/vtpmmgr/tpmrsa.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ /* * RSA was designed by Ron Rivest, Adi Shamir and Len Adleman. diff --git a/stubdom/vtpmmgr/tpmrsa.h b/stubdom/vtpmmgr/tpmrsa.h index efeb5f2a21e4ac43b3cda417c0c8cea62052087c..45e1f72e4b816bb9c4c3c6b4055c522192c69ec8 100644 --- a/stubdom/vtpmmgr/tpmrsa.h +++ b/stubdom/vtpmmgr/tpmrsa.h @@ -21,7 +21,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ #ifndef TPMRSA_H #define TPMRSA_H diff --git a/tools/configure b/tools/configure index f6f13bfdc0901b0cea125c5ac13208c92e7b7a0f..50d1abfe2b5579651fb1ef43db87ec8ceb109547 100755 --- a/tools/configure +++ b/tools/configure @@ -3647,7 +3647,7 @@ esac # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # As a special exception to the GNU General Public License, if you # distribute this file as part of a program that contains a @@ -3868,7 +3868,7 @@ esac # General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . diff --git a/tools/console/client/main.c b/tools/console/client/main.c index 1a6fa162f750692e4affa33abecae1fd22031d4f..f694af558544d294a82c60c50739341d94038ae7 100644 --- a/tools/console/client/main.c +++ b/tools/console/client/main.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c index 682c1f4008e0c984987e2e712c84175c923888b9..54b28dd29c69f6887171fd1e70b2dcbde41bb252 100644 --- a/tools/console/daemon/io.c +++ b/tools/console/daemon/io.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/console/daemon/io.h b/tools/console/daemon/io.h index d016addac896c6d6930495af2e9e4f19bc09abf5..8486cfaaed19604e21e1b36ed4e8a2cb55a316ff 100644 --- a/tools/console/daemon/io.h +++ b/tools/console/daemon/io.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #ifndef CONSOLED_IO_H diff --git a/tools/console/daemon/main.c b/tools/console/daemon/main.c index aac7233a48c93e8542f8f8637445be592080fb3f..75643b8023fe6552ead2b5be15bc3c6c3ad12322 100644 --- a/tools/console/daemon/main.c +++ b/tools/console/daemon/main.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/utils.c b/tools/console/daemon/utils.c index f9dd8a60c5c497c3dc2c9c5779b38bca547dd5a9..d609fb05198d98f55312a25f11ffd84b55c3b33e 100644 --- a/tools/console/daemon/utils.c +++ b/tools/console/daemon/utils.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #include diff --git a/tools/console/daemon/utils.h b/tools/console/daemon/utils.h index a010ac44e0fa2c99be586fccdac66261c9a67992..e828fb7eef71753c4cefab220653bd463e155444 100644 --- a/tools/console/daemon/utils.h +++ b/tools/console/daemon/utils.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . \*/ #ifndef CONSOLED_UTILS_H diff --git a/tools/debugger/gdbsx/gx/gx.h b/tools/debugger/gdbsx/gx/gx.h index af3957587aab02396b393dff6428eb2204c46b1f..d3f7ef913a3b422428e210c61a10bf84c373fee4 100644 --- a/tools/debugger/gdbsx/gx/gx.h +++ b/tools/debugger/gdbsx/gx/gx.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ typedef uint16_t domid_t; diff --git a/tools/debugger/gdbsx/gx/gx_comm.c b/tools/debugger/gdbsx/gx/gx_comm.c index 5a0c61df4bd4d984aff33f5cda661ed075911b22..2a4967a78273580fecb7e114fb268744e088a770 100644 --- a/tools/debugger/gdbsx/gx/gx_comm.c +++ b/tools/debugger/gdbsx/gx/gx_comm.c @@ -15,7 +15,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . */ + along with this program; If not, see . */ /* * Copyright (C) 2009, Mukesh Rathor, Oracle Corp. All rights reserved. * @@ -29,7 +29,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This module handles communication with remote gdb. courtesy diff --git a/tools/debugger/gdbsx/gx/gx_local.c b/tools/debugger/gdbsx/gx/gx_local.c index 023f5a391f43aa253411fde90e1559c23b869ac2..6af2d442fbae0382a5ec515607c95e4d46f81b74 100644 --- a/tools/debugger/gdbsx/gx/gx_local.c +++ b/tools/debugger/gdbsx/gx/gx_local.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ diff --git a/tools/debugger/gdbsx/gx/gx_main.c b/tools/debugger/gdbsx/gx/gx_main.c index 15de2c350135e76e965efe9b54c5224087c4266d..d9e556affa468f72fbe4eaebc4815db7881550a5 100644 --- a/tools/debugger/gdbsx/gx/gx_main.c +++ b/tools/debugger/gdbsx/gx/gx_main.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This module is the main module for gdbsx implementation. gdbsx is a remote diff --git a/tools/debugger/gdbsx/gx/gx_utils.c b/tools/debugger/gdbsx/gx/gx_utils.c index f3c003960c4e407834468f2760bb4279a5121a92..428e2c24ad15af9468055df3fab6ad5c65d6df5c 100644 --- a/tools/debugger/gdbsx/gx/gx_utils.c +++ b/tools/debugger/gdbsx/gx/gx_utils.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/tools/debugger/gdbsx/gx/xg_dummy.c b/tools/debugger/gdbsx/gx/xg_dummy.c index e995fad7d5d30ddf24034db70ec9ff603d50e2ae..b75bdfb724e5c4c6f9b8766f7cdc70a1912a6359 100644 --- a/tools/debugger/gdbsx/gx/xg_dummy.c +++ b/tools/debugger/gdbsx/gx/xg_dummy.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include #include diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c index 4576c762af0c29521e75db5ba3355d89250a0047..2dfaec7df065002d128c24c2df1c81b3aa5212fc 100644 --- a/tools/debugger/gdbsx/xg/xg_main.c +++ b/tools/debugger/gdbsx/xg/xg_main.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* This is the main module to interface with xen. This module exports APIs that diff --git a/tools/debugger/gdbsx/xg/xg_public.h b/tools/debugger/gdbsx/xg/xg_public.h index 31513c817796897d22af915fbdb9a7d7d1587421..95fc6e11c2900c4182df658b068b250d043c8da6 100644 --- a/tools/debugger/gdbsx/xg/xg_public.h +++ b/tools/debugger/gdbsx/xg/xg_public.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define XGERR(...) \ diff --git a/tools/firmware/hvmloader/32bitbios_support.c b/tools/firmware/hvmloader/32bitbios_support.c index cee3804888c447df7e952960312ad07023a07acc..7b76fb4fdb4ed685dfaf2b614d497c227f433d62 100644 --- a/tools/firmware/hvmloader/32bitbios_support.c +++ b/tools/firmware/hvmloader/32bitbios_support.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile index 4f31c881613ca5a5b44aa6afbe860daa1b3ee7a0..3d745c30d2c2074578afb4d99d91fd2e2f19dcdc 100644 --- a/tools/firmware/hvmloader/Makefile +++ b/tools/firmware/hvmloader/Makefile @@ -14,7 +14,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # XEN_ROOT = $(CURDIR)/../../.. diff --git a/tools/firmware/hvmloader/cacheattr.c b/tools/firmware/hvmloader/cacheattr.c index b7215fba2e0200228e063e2f7e16e79b6f916a52..3abf460eacd4859174156a1a9d40c3e5d168150a 100644 --- a/tools/firmware/hvmloader/cacheattr.c +++ b/tools/firmware/hvmloader/cacheattr.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c index c490a0bc790c1e70912411f9b1cdf09e661dada2..427cde142b7f0ac74513392d5e966166ac6b0927 100644 --- a/tools/firmware/hvmloader/e820.c +++ b/tools/firmware/hvmloader/e820.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/hvmloader.c b/tools/firmware/hvmloader/hvmloader.c index c58841e5b55624c6f50b2a2756b81e914295c3ea..417dec5cad20bcd2c6bfe83a50f68757f18b3070 100644 --- a/tools/firmware/hvmloader/hvmloader.c +++ b/tools/firmware/hvmloader/hvmloader.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/mp_tables.c b/tools/firmware/hvmloader/mp_tables.c index d207ecbf00c9297c491fea8952a4a2f7215ccb9b..6acdd1be488557b0354d495833d18e95b9aa8a1f 100644 --- a/tools/firmware/hvmloader/mp_tables.c +++ b/tools/firmware/hvmloader/mp_tables.c @@ -24,7 +24,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/firmware/hvmloader/optionroms.c b/tools/firmware/hvmloader/optionroms.c index 97080583cca7aba7269cc7e68feec4e5beab8990..2d57890724ac7394d3535d10199d0f60d6a2487e 100644 --- a/tools/firmware/hvmloader/optionroms.c +++ b/tools/firmware/hvmloader/optionroms.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c index 23610a071797f143bb712e03df5e492d0e91a7a6..def5b9e41ea43c3de834117aaf361175ac476366 100644 --- a/tools/firmware/hvmloader/ovmf.c +++ b/tools/firmware/hvmloader/ovmf.c @@ -18,7 +18,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c index 257a6feb6148c4d0cd3fa608cf4cc902251ee000..944afeb3b8b0ddb7998d04517921371884a57557 100644 --- a/tools/firmware/hvmloader/pci.c +++ b/tools/firmware/hvmloader/pci.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h index 5129b0c7fd9a087810a299ee8930f755814a263b..01e1bfbcf4d088269fd5dde97dbc729d5a0c7f1b 100644 --- a/tools/firmware/hvmloader/pir_types.h +++ b/tools/firmware/hvmloader/pir_types.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) Citrix Systems, 2011 * diff --git a/tools/firmware/hvmloader/rombios.c b/tools/firmware/hvmloader/rombios.c index 46f331e465966d241f2a0e970ef3ab46adf24b31..6f9f2a59b5713dc6d86376d8ff3a449a145c04aa 100644 --- a/tools/firmware/hvmloader/rombios.c +++ b/tools/firmware/hvmloader/rombios.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/seabios.c b/tools/firmware/hvmloader/seabios.c index 444d118ddb01451aac393ee1cb6fb23dcb1ba72d..33062f6f331292658444649875211318270b7607 100644 --- a/tools/firmware/hvmloader/seabios.c +++ b/tools/firmware/hvmloader/seabios.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/smbios.c b/tools/firmware/hvmloader/smbios.c index 97a054e9e3fe9918aee64c036662334679e74a71..5547edfd127b8ce4d80ca1700d02e738f3c70d66 100644 --- a/tools/firmware/hvmloader/smbios.c +++ b/tools/firmware/hvmloader/smbios.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h index 3f1c120da60b6aa95cb2b6b1f03cc31d912832a4..c75cfee7028779b709d407f2b1e44d2e4b574e64 100644 --- a/tools/firmware/hvmloader/smbios_types.h +++ b/tools/firmware/hvmloader/smbios_types.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/hvmloader/smp.c b/tools/firmware/hvmloader/smp.c index 082b17f138186c48e936f621d154955bf1dfe652..0f464517ab62ce80333a39c04e802501cc237d4c 100644 --- a/tools/firmware/hvmloader/smp.c +++ b/tools/firmware/hvmloader/smp.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/hvmloader/tests.c b/tools/firmware/hvmloader/tests.c index a70c72dffbbb3922faae6cc2832fc8195018c0da..948cd360d71591d96571481599d7f0b0d7d7d78e 100644 --- a/tools/firmware/hvmloader/tests.c +++ b/tools/firmware/hvmloader/tests.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "config.h" diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 581b35e5cfb5ad1be1aa09e8536cfc3bd70c82ee..611a0603c7e3ed6278e0479eb0a9e0db90ec56f7 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include "util.h" diff --git a/tools/firmware/rombios/32bit/32bitbios.c b/tools/firmware/rombios/32bit/32bitbios.c index 87acf209c3fdb6185910cd5e29e4b1538c59548f..39b141a23b3ad241b38b11fde33d14c89a766674 100644 --- a/tools/firmware/rombios/32bit/32bitbios.c +++ b/tools/firmware/rombios/32bit/32bitbios.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/mkhex b/tools/firmware/rombios/32bit/mkhex index 7200d007e460021d1b25b6d3b29a34c08b82eb69..cfdd011c37d3e808a5a17b1d662b775acc22f7d4 100644 --- a/tools/firmware/rombios/32bit/mkhex +++ b/tools/firmware/rombios/32bit/mkhex @@ -16,7 +16,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # echo "unsigned $1[] = {" diff --git a/tools/firmware/rombios/32bit/pmm.c b/tools/firmware/rombios/32bit/pmm.c index e0e39fef68a7b8d1695738e5e6f3c045c6dceaa4..49e603fd0297760b6efae70444ea975bc832a66a 100644 --- a/tools/firmware/rombios/32bit/pmm.c +++ b/tools/firmware/rombios/32bit/pmm.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) 2009 FUJITSU LIMITED * diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c index fa22c4460aac6f45aa67ceb991033c93b25a84fa..8da795ed4b642eec2d1e02953023fdec1625551f 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c index 59d16bbae6b422cd77d9faf719b4faad075d4ece..8897df75b21d364da9da58a498cc61d8e58295c8 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c +++ b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/rombios/32bit/util.c b/tools/firmware/rombios/32bit/util.c index 6c1c4805144bf520abe6545f70bb0720a709102b..e5f9acbadf19bf65d073a6aee0e32560d9d5b016 100644 --- a/tools/firmware/rombios/32bit/util.c +++ b/tools/firmware/rombios/32bit/util.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include #include diff --git a/tools/firmware/rombios/32bitgateway.c b/tools/firmware/rombios/32bitgateway.c index 3d58a6b0a1cdd8b6b8a24bb7da1ea1d236597345..9f28ea3b5d27e7dc585039f0355dcc1a17469835 100644 --- a/tools/firmware/rombios/32bitgateway.c +++ b/tools/firmware/rombios/32bitgateway.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * Copyright (c) 2008, Citrix Systems, Inc. diff --git a/tools/firmware/rombios/apmbios.S b/tools/firmware/rombios/apmbios.S index 814be8fd57eba8998a177c3ebd757de557c92599..9dd6b3390eab5a679771de429f893362b20c4b75 100644 --- a/tools/firmware/rombios/apmbios.S +++ b/tools/firmware/rombios/apmbios.S @@ -15,7 +15,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . #if defined(APM_REAL) #define APMSYM(s) apmreal_ ## s diff --git a/tools/firmware/rombios/rombios.c b/tools/firmware/rombios/rombios.c index 52ba4a988f262f41b6d98ce41cca791db13c21be..1e08e16826a182d3defa114db01843e7d9134991 100644 --- a/tools/firmware/rombios/rombios.c +++ b/tools/firmware/rombios/rombios.c @@ -21,7 +21,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // ROM BIOS for use with Bochs/Plex86/QEMU emulation environment diff --git a/tools/firmware/rombios/rombios.h b/tools/firmware/rombios/rombios.h index 8726d37737b4f980311a2695156b34c42af16fa2..a3849de73d096d570dbd160eec0a484bf30ff57f 100644 --- a/tools/firmware/rombios/rombios.h +++ b/tools/firmware/rombios/rombios.h @@ -15,7 +15,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . /* define it to include QEMU specific code */ //#define BX_QEMU diff --git a/tools/firmware/rombios/tcgbios.c b/tools/firmware/rombios/tcgbios.c index e725ef9d1bdc3b995044e2a27bbfbc399dbd8e5c..8f5ab34bce24199d6922d11a4d3a6f6484833773 100644 --- a/tools/firmware/rombios/tcgbios.c +++ b/tools/firmware/rombios/tcgbios.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) IBM Corporation, 2006 * diff --git a/tools/firmware/vgabios/COPYING b/tools/firmware/vgabios/COPYING index 05956269987638868d4aea655e8fd4c9d5b6ecd5..8b44515327c654405640f624ea7de292302a431c 100644 --- a/tools/firmware/vgabios/COPYING +++ b/tools/firmware/vgabios/COPYING @@ -484,7 +484,7 @@ convey the exclusion of warranty; and each file should have at least the Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/firmware/vgabios/biossums.c b/tools/firmware/vgabios/biossums.c index 85ecc04e1665c6c3902a95f4687859513cc6e358..144467ae327e403a547fa8174db0fd760ddf6b15 100644 --- a/tools/firmware/vgabios/biossums.c +++ b/tools/firmware/vgabios/biossums.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include #include diff --git a/tools/firmware/vgabios/clext.c b/tools/firmware/vgabios/clext.c index d727cd59f270d6658c1bc0dee82eff40ceff0074..c6b1fcbad1505a27fb8e1c131c1c7994e24fa7be 100644 --- a/tools/firmware/vgabios/clext.c +++ b/tools/firmware/vgabios/clext.c @@ -14,7 +14,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // //#define CIRRUS_VESA3_PMINFO diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c index 8e6408733ae68bdc582054ee58778c03f180b220..2bda60d1aefe1c4922b07efa975b3d0932dc0426 100644 --- a/tools/firmware/vgabios/vbe.c +++ b/tools/firmware/vgabios/vbe.c @@ -13,7 +13,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // // ============================================================================================ // diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c index 3ad98ca254a4ce8e7359a8a2d1a259b098ab927b..9b96029f09b89adfda25dc021194c70ce4591644 100644 --- a/tools/firmware/vgabios/vgabios.c +++ b/tools/firmware/vgabios/vgabios.c @@ -17,7 +17,7 @@ // Lesser General Public License for more details. // // You should have received a copy of the GNU Lesser General Public -// License along with this library; If not, see . +// License along with this library; If not, see . // // ============================================================================================ // diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index a45c636952520823f3c13a314e476cdbf4e1629f..a456518e8339446e40edf971c0231a90ae0f5fe2 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ // Package xenlight provides bindings to Xen's libxl C library. diff --git a/tools/hotplug/Linux/block-common.sh b/tools/hotplug/Linux/block-common.sh index f86a88c4ebce21036a3e029223099ef9501fad21..de57b642546f95251d8e3ebbebd63279aa025a91 100644 --- a/tools/hotplug/Linux/block-common.sh +++ b/tools/hotplug/Linux/block-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/block-drbd-probe b/tools/hotplug/Linux/block-drbd-probe index 7b2968b6d944ea7222b79b1acda8c5f0dab8ab23..fca46fb32c5fb94bf07fe3b8363e2bdea3f6ccf8 100755 --- a/tools/hotplug/Linux/block-drbd-probe +++ b/tools/hotplug/Linux/block-drbd-probe @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # Usage: # block-drbd-probe devicename diff --git a/tools/hotplug/Linux/external-device-migrate b/tools/hotplug/Linux/external-device-migrate index f5942a6a954fc1ac9f21974f0e2a70a4d8dd3dbd..68eaac145bec13de5ce038e882d62ce14fa79fbb 100644 --- a/tools/hotplug/Linux/external-device-migrate +++ b/tools/hotplug/Linux/external-device-migrate @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # set -x diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in index e854ca1eb8957f616122a6d96b88bb891142318d..5028d1d09f4da30d458f354687488da002c94905 100644 --- a/tools/hotplug/Linux/launch-xenstore.in +++ b/tools/hotplug/Linux/launch-xenstore.in @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # XENSTORED=@XENSTORED@ diff --git a/tools/hotplug/Linux/locking.sh b/tools/hotplug/Linux/locking.sh index 2e6fb35f02785c7a2c5a164df417f47659f829bd..13fb7134c6b6a20f7de2be4394406377abdb8167 100644 --- a/tools/hotplug/Linux/locking.sh +++ b/tools/hotplug/Linux/locking.sh @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # diff --git a/tools/hotplug/Linux/logging.sh b/tools/hotplug/Linux/logging.sh index 3e94df1a9e900d1b2b368568e2400063882f74eb..b7ed7b292dd54f4ff085eb2fe9cdf346c9ec1c33 100644 --- a/tools/hotplug/Linux/logging.sh +++ b/tools/hotplug/Linux/logging.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # log() { diff --git a/tools/hotplug/Linux/vif-common.sh b/tools/hotplug/Linux/vif-common.sh index a8e65178f9074390eb6a1bdf5b1f741fffac66ad..43ea7bbf775fb4688ef9849ca5805facaaa7cd47 100644 --- a/tools/hotplug/Linux/vif-common.sh +++ b/tools/hotplug/Linux/vif-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/xen-hotplug-common.sh.in b/tools/hotplug/Linux/xen-hotplug-common.sh.in index 8c2cb9e25a1a401cf4dc366e2cdcb45eb59cf95a..9e5207fee85f39248b8cd12ec52c8dddb2a7e922 100644 --- a/tools/hotplug/Linux/xen-hotplug-common.sh.in +++ b/tools/hotplug/Linux/xen-hotplug-common.sh.in @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # dir=$(dirname "$0") diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh index 42fa704e8d40f683ed3a7d3562b7c9685b7f804c..89542b2b9ac0bc8b0089bf05d9e3251c3c0ba6ef 100644 --- a/tools/hotplug/Linux/xen-network-common.sh +++ b/tools/hotplug/Linux/xen-network-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/Linux/xen-script-common.sh b/tools/hotplug/Linux/xen-script-common.sh index 370a50a3cd9849e9348be5934b12d21d3f7b05d0..a8d36414df691e6d729b3011aea598c5fa03d110 100644 --- a/tools/hotplug/Linux/xen-script-common.sh +++ b/tools/hotplug/Linux/xen-script-common.sh @@ -11,7 +11,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # diff --git a/tools/hotplug/NetBSD/locking.sh b/tools/hotplug/NetBSD/locking.sh index 2098d0e3ab6ed60c9b52acf2d36f67dde8550e0b..4a63fb2e1c77dc98bdb8cafc40dca7cd8c1f4c50 100644 --- a/tools/hotplug/NetBSD/locking.sh +++ b/tools/hotplug/NetBSD/locking.sh @@ -12,7 +12,7 @@ # Lesser General Public License for more details. # # You should have received a copy of the GNU Lesser General Public -# License along with this library; If not, see . +# License along with this library; If not, see . # # diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index ad771866e44321f6c880733a3df8e9315c2b348e..049e334426855661c3487d7fbfc3eec64b2655c5 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/include/xencall.h b/tools/include/xencall.h index fc95ed0fe58eea7fb7830458fe6207bce610d63a..e577b927b8e6e4091dd9e6bf35d57952ea96f410 100644 --- a/tools/include/xencall.h +++ b/tools/include/xencall.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENCALL_H #define XENCALL_H diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 23037874d3d5a01ddf55766088bf782393a9c483..fc0c72ae0265e610047b9a8fd950973e34198e2f 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENCTRL_H diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h index 797e0c6b2961926a68cd96b8ff5e1627067903ac..58dbb1bdda2fb8a9ee237ed20e0ecf1c09abe42e 100644 --- a/tools/include/xendevicemodel.h +++ b/tools/include/xendevicemodel.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENDEVICEMODEL_H #define XENDEVICEMODEL_H diff --git a/tools/include/xenevtchn.h b/tools/include/xenevtchn.h index 1255c85178d2d5049aa2406c5be1b7932bec728d..51fbc42eb0598f95015a6754636ce70e9d20aba8 100644 --- a/tools/include/xenevtchn.h +++ b/tools/include/xenevtchn.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from: * xenctrl.h diff --git a/tools/include/xenforeignmemory.h b/tools/include/xenforeignmemory.h index 0ab1dd19d3b56db4a9dccd784d54919d390b47a9..eb897603862d519dcd40ecff6c9e8be8d1810222 100644 --- a/tools/include/xenforeignmemory.h +++ b/tools/include/xenforeignmemory.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENFOREIGNMEMORY_H #define XENFOREIGNMEMORY_H diff --git a/tools/include/xengnttab.h b/tools/include/xengnttab.h index 111fc88caeb3ef1186f6a3d0051688ceed14dc5c..188c7a9fdb8bdc4f1bad6b6ed7656f1921a0142d 100644 --- a/tools/include/xengnttab.h +++ b/tools/include/xengnttab.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from: * xenctrl.h diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h index e01f494b772a4800fbd8d9d7ced8b45a811e8219..f8e248c5a2e30486a78e1207dd36b96159ce211e 100644 --- a/tools/include/xenguest.h +++ b/tools/include/xenguest.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENGUEST_H diff --git a/tools/include/xenhypfs.h b/tools/include/xenhypfs.h index 25432d2a1657d8a59b04ffdefca6d7ee1734cf55..7818198ee184c9c8c8fa2e5a50272cc4bb360b64 100644 --- a/tools/include/xenhypfs.h +++ b/tools/include/xenhypfs.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENHYPFS_H #define XENHYPFS_H diff --git a/tools/include/xenstore.h b/tools/include/xenstore.h index 2b3f69fb61d3434f00dbc7870739258c81882d2a..c72e66e513720ebee2b11bcf901c3f9ba7af1416 100644 --- a/tools/include/xenstore.h +++ b/tools/include/xenstore.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XENSTORE_H diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h index 2266009ec12410b07b8109b185c6c5d40b3b8771..7fd536234a937ff87d147abe34a0d67c905faa1f 100644 --- a/tools/include/xenstore_lib.h +++ b/tools/include/xenstore_lib.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XENSTORE_LIB_H diff --git a/tools/include/xentoolcore.h b/tools/include/xentoolcore.h index b3a3c934e28314a9f0d2856376916a0d5eb8c00e..3ff9dd6dbbcbdd9a3c3f5067aec1ccfd1e7921a6 100644 --- a/tools/include/xentoolcore.h +++ b/tools/include/xentoolcore.h @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLCORE_H diff --git a/tools/include/xentoolcore_internal.h b/tools/include/xentoolcore_internal.h index 1be014434d32f399de1ba3bcc9fcbb7f61c08749..be67c5fb7f41232cb1644751b4b9b9dc3b99039c 100644 --- a/tools/include/xentoolcore_internal.h +++ b/tools/include/xentoolcore_internal.h @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLCORE_INTERNAL_H diff --git a/tools/include/xentoollog.h b/tools/include/xentoollog.h index 76f17fe125d103af9ba587cb56fb147a23b5e615..817db123dd3136409f7a190fcdca56896b0342ec 100644 --- a/tools/include/xentoollog.h +++ b/tools/include/xentoollog.h @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENTOOLLOG_H diff --git a/tools/libfsimage/ext2fs/fsys_ext2fs.c b/tools/libfsimage/ext2fs/fsys_ext2fs.c index 5ed8fce90ef1dd663862f085865c7050a0eb9524..019bbffb475098158bb9798894e6a416b96a10a6 100644 --- a/tools/libfsimage/ext2fs/fsys_ext2fs.c +++ b/tools/libfsimage/ext2fs/fsys_ext2fs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/fat/fat.h b/tools/libfsimage/fat/fat.h index 2abb43084f47fa83e628ea01e237efd4d797bdd6..e9f535ce8827ef61851cfbfebd8e4242692d7146 100644 --- a/tools/libfsimage/fat/fat.h +++ b/tools/libfsimage/fat/fat.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/libfsimage/fat/fsys_fat.c b/tools/libfsimage/fat/fsys_fat.c index b89354a8721b280045a91a7b15151c1fe0380438..f540c6413339da4f1c23f95d4e856a4952937a46 100644 --- a/tools/libfsimage/fat/fsys_fat.c +++ b/tools/libfsimage/fat/fsys_fat.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/iso9660/fsys_iso9660.c b/tools/libfsimage/iso9660/fsys_iso9660.c index 6e767357bfdc2e35d7aa788977280218e1937aa5..15cde87307e842af4a1fa09e314dd3b38473bfa4 100644 --- a/tools/libfsimage/iso9660/fsys_iso9660.c +++ b/tools/libfsimage/iso9660/fsys_iso9660.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * References: diff --git a/tools/libfsimage/iso9660/iso9660.h b/tools/libfsimage/iso9660/iso9660.h index 4ea9b3eed36a416c0faaaceb12f345da318cd7b7..6ac443e6dcc91f86b33c5420a2d32591f7d1b58f 100644 --- a/tools/libfsimage/iso9660/iso9660.h +++ b/tools/libfsimage/iso9660/iso9660.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * References: diff --git a/tools/libfsimage/reiserfs/fsys_reiserfs.c b/tools/libfsimage/reiserfs/fsys_reiserfs.c index 299b257e999426547199753508fcf76f1d440ed7..a83b69a059e1fec3b73c171fef66690310303c56 100644 --- a/tools/libfsimage/reiserfs/fsys_reiserfs.c +++ b/tools/libfsimage/reiserfs/fsys_reiserfs.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/ufs/fsys_ufs.c b/tools/libfsimage/ufs/fsys_ufs.c index a545bc9f65e82748c931f6f30a1c8c9abf0a712d..3f6ff873078656f914e2a0ccb9398f55365fcd81 100644 --- a/tools/libfsimage/ufs/fsys_ufs.c +++ b/tools/libfsimage/ufs/fsys_ufs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2006 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/xfs/fsys_xfs.c b/tools/libfsimage/xfs/fsys_xfs.c index d735a88e55f3ac30b11ba7e5fe6a8a07b97bce0c..a8d8f249ad2cb1bbf53ab2fdb5bdbf5779ca433b 100644 --- a/tools/libfsimage/xfs/fsys_xfs.c +++ b/tools/libfsimage/xfs/fsys_xfs.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/libfsimage/xfs/xfs.h b/tools/libfsimage/xfs/xfs.h index e9f93531d82aa12264ef3b4c8bbc8f56d9c7d58f..5d3c19d6883140ddd3c3426c6f7dd5555c7d5b99 100644 --- a/tools/libfsimage/xfs/xfs.h +++ b/tools/libfsimage/xfs/xfs.h @@ -20,7 +20,7 @@ * other software, or any other product whatsoever. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, * Mountain View, CA 94043, or: diff --git a/tools/libfsimage/zfs/Makefile b/tools/libfsimage/zfs/Makefile index 434a9c3580e6ab029f0b54779decfd8107a08f10..b8cbca7f1a9da28b79cc0f855b23389f8364ad1e 100644 --- a/tools/libfsimage/zfs/Makefile +++ b/tools/libfsimage/zfs/Makefile @@ -13,7 +13,7 @@ # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # # diff --git a/tools/libfsimage/zfs/filesys.h b/tools/libfsimage/zfs/filesys.h index 36cc720709f7b238e1aa746afeabf6b961cda1c0..c1f64eb282034965cb329bf6a1b6a92adfd7bd00 100644 --- a/tools/libfsimage/zfs/filesys.h +++ b/tools/libfsimage/zfs/filesys.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsi_zfs.c b/tools/libfsimage/zfs/fsi_zfs.c index 187a8bc6b2d9502cd20a6306f98d75c9e8f9a939..bd24a5e7c84afcb8f2d993a7ca4e65717c1d4a8c 100644 --- a/tools/libfsimage/zfs/fsi_zfs.c +++ b/tools/libfsimage/zfs/fsi_zfs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsi_zfs.h b/tools/libfsimage/zfs/fsi_zfs.h index 980ce8f30478f0707146cac2d2ba4b1e160d4c5d..e3b4a8116e386c16f504cd7fb87344461a549cbf 100644 --- a/tools/libfsimage/zfs/fsi_zfs.h +++ b/tools/libfsimage/zfs/fsi_zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsys_zfs.c b/tools/libfsimage/zfs/fsys_zfs.c index e881fbb09ba9311e1e3001f148244e5416d61e16..941068b1339242b6b8a6e8f5710495bce3a46b84 100644 --- a/tools/libfsimage/zfs/fsys_zfs.c +++ b/tools/libfsimage/zfs/fsys_zfs.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/fsys_zfs.h b/tools/libfsimage/zfs/fsys_zfs.h index b4be51b50d1f3411f43f14ccc956bb80e21a920e..14595dffa998da725e39fa24e9ab0fb49e05cfbf 100644 --- a/tools/libfsimage/zfs/fsys_zfs.h +++ b/tools/libfsimage/zfs/fsys_zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/mb_info.h b/tools/libfsimage/zfs/mb_info.h index 16e9013f58b3f28b3c2cd3a211f0eb6c265d1451..2c68dbea43d9259152cf20b69fe628d8217dfabe 100644 --- a/tools/libfsimage/zfs/mb_info.h +++ b/tools/libfsimage/zfs/mb_info.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/tools/libfsimage/zfs/shared.h b/tools/libfsimage/zfs/shared.h index e4a239abe19c130ea2e48c6a8d7fb16079fd4dd7..55ffefce2020a00d2e74c859ad7bdb874904173d 100644 --- a/tools/libfsimage/zfs/shared.h +++ b/tools/libfsimage/zfs/shared.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dmu.h b/tools/libfsimage/zfs/zfs-include/dmu.h index b39a951cf7c9725b9198bbd2876fd31080f90ee3..d37b02f04eadc6316dcd2dc5fca4c7d9f92d2e0e 100644 --- a/tools/libfsimage/zfs/zfs-include/dmu.h +++ b/tools/libfsimage/zfs/zfs-include/dmu.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dmu_objset.h b/tools/libfsimage/zfs/zfs-include/dmu_objset.h index 2680fcf1bd8082e2e6f78997b35dcb4b6c35ef48..8a9c6ae3bf85f29055b1a8bddeb9ed68958d0e0f 100644 --- a/tools/libfsimage/zfs/zfs-include/dmu_objset.h +++ b/tools/libfsimage/zfs/zfs-include/dmu_objset.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dnode.h b/tools/libfsimage/zfs/zfs-include/dnode.h index dd90a8779c70074dfcce14e61ad94e069f42eb35..49bfb54fc3feae4f7e02be6e94b3dc5f2396d135 100644 --- a/tools/libfsimage/zfs/zfs-include/dnode.h +++ b/tools/libfsimage/zfs/zfs-include/dnode.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h index 470b60758840438cc8f655ece37311f1793f23bf..8ac92c60bcdbe1494568370d5d38475013899fc9 100644 --- a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h +++ b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dir.h b/tools/libfsimage/zfs/zfs-include/dsl_dir.h index 0e71b6b4808ed847560b2b62e0bbe3c865ebe521..e25bc139f3d94ed993c64992889a264eeb824a69 100644 --- a/tools/libfsimage/zfs/zfs-include/dsl_dir.h +++ b/tools/libfsimage/zfs/zfs-include/dsl_dir.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/sa_impl.h b/tools/libfsimage/zfs/zfs-include/sa_impl.h index 0679c93f2999d951adafa477be6e72975884995b..a9af9024194cda52d7a75c98faface583a5c847e 100644 --- a/tools/libfsimage/zfs/zfs-include/sa_impl.h +++ b/tools/libfsimage/zfs/zfs-include/sa_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/spa.h b/tools/libfsimage/zfs/zfs-include/spa.h index ee708ef60bdc355e9d895967e00b277c3a897bf5..ba35ab740a4a8086830335fdcf920a3c910da11b 100644 --- a/tools/libfsimage/zfs/zfs-include/spa.h +++ b/tools/libfsimage/zfs/zfs-include/spa.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h index 282d3b92827c70e4982530608b0ce0a028cf1ca2..2f879666cbd7e3c4b8fb0bf55cca91b8cea71bc0 100644 --- a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h +++ b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/vdev_impl.h b/tools/libfsimage/zfs/zfs-include/vdev_impl.h index f3823b298d134379483b8c8e196c9fe196617e93..fe69c31fb9e51d0c64b3dea25276510adc768c92 100644 --- a/tools/libfsimage/zfs/zfs-include/vdev_impl.h +++ b/tools/libfsimage/zfs/zfs-include/vdev_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zap_impl.h b/tools/libfsimage/zfs/zfs-include/zap_impl.h index 7adfc347c3a15dc89d97510827468a02fb2643da..44fedf9f665722da05c6b6adc54da251f7f989cc 100644 --- a/tools/libfsimage/zfs/zfs-include/zap_impl.h +++ b/tools/libfsimage/zfs/zfs-include/zap_impl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zap_leaf.h b/tools/libfsimage/zfs/zfs-include/zap_leaf.h index ecf3faacb6407856e247521012242aff0e8fb2ee..9517d055f2d5b107faf081b80642604a1bb3853c 100644 --- a/tools/libfsimage/zfs/zfs-include/zap_leaf.h +++ b/tools/libfsimage/zfs/zfs-include/zap_leaf.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs.h b/tools/libfsimage/zfs/zfs-include/zfs.h index 592d23a768d1ded2d521a1135f791888bef3ae5f..0f0e2552051ed291797febd690f6782599ae467d 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs.h +++ b/tools/libfsimage/zfs/zfs-include/zfs.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs_acl.h b/tools/libfsimage/zfs/zfs-include/zfs_acl.h index 6a685e0536711617abe5ba770fc9b89666ea109c..e0f458b68a9d4b0ce9914b78f806956eb5831bf4 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs_acl.h +++ b/tools/libfsimage/zfs/zfs-include/zfs_acl.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zfs_znode.h b/tools/libfsimage/zfs/zfs-include/zfs_znode.h index 902c4972caf61fab31de2d7ec08beefcc5f509ef..a46f7d765422a7f1abcb4f638601717a6255f5ed 100644 --- a/tools/libfsimage/zfs/zfs-include/zfs_znode.h +++ b/tools/libfsimage/zfs/zfs-include/zfs_znode.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zil.h b/tools/libfsimage/zfs/zfs-include/zil.h index f34173c36b1859d20958f1a8d6913163b0dbb666..ec70d71ad3d42db0d7bf91c37a9f03b027b2f10f 100644 --- a/tools/libfsimage/zfs/zfs-include/zil.h +++ b/tools/libfsimage/zfs/zfs-include/zil.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2009 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zio.h b/tools/libfsimage/zfs/zfs-include/zio.h index 513f321f9a82584acacbde1620b60d954bcdcb5e..c9dce12271379196bcab6e64562a6db132daaba1 100644 --- a/tools/libfsimage/zfs/zfs-include/zio.h +++ b/tools/libfsimage/zfs/zfs-include/zio.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs-include/zio_checksum.h b/tools/libfsimage/zfs/zfs-include/zio_checksum.h index 5f22f29995765835586b0baadfb9410a5ffdca84..b9864ee32722e317abc774f2c2fb91ab6e54f26c 100644 --- a/tools/libfsimage/zfs/zfs-include/zio_checksum.h +++ b/tools/libfsimage/zfs/zfs-include/zio_checksum.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2010 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_fletcher.c b/tools/libfsimage/zfs/zfs_fletcher.c index cc9e8c4954d46eb47ce4321b05e1bddc7f61fc89..368beed6b06f329d631d60def1656e7503d50f21 100644 --- a/tools/libfsimage/zfs/zfs_fletcher.c +++ b/tools/libfsimage/zfs/zfs_fletcher.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_lzjb.c b/tools/libfsimage/zfs/zfs_lzjb.c index 0b11eee63af1b584feb1d7aab8365c0319a61584..f904e0b7dc4590411274b55e464adeefc94a1af7 100644 --- a/tools/libfsimage/zfs/zfs_lzjb.c +++ b/tools/libfsimage/zfs/zfs_lzjb.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libfsimage/zfs/zfs_sha256.c b/tools/libfsimage/zfs/zfs_sha256.c index 18a5c05008ef4a5f5b2cec57e343ed8ea1f9ccfe..9a5b4af54e3c0f7da8c685d700a41fdc09e536a5 100644 --- a/tools/libfsimage/zfs/zfs_sha256.c +++ b/tools/libfsimage/zfs/zfs_sha256.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* * Copyright 2007 Sun Microsystems, Inc. All rights reserved. diff --git a/tools/libs/call/buffer.c b/tools/libs/call/buffer.c index 085674d882ae5d031460f26451f48a3da790e549..34d0c90c58ce57125fda700571999122b2918269 100644 --- a/tools/libs/call/buffer.c +++ b/tools/libs/call/buffer.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/call/core.c b/tools/libs/call/core.c index 02c4f8e1aefa9a87846daf0ae811cc91e12a0c00..ae82ff9535d870ce764242d21b5325eaa663b2b8 100644 --- a/tools/libs/call/core.c +++ b/tools/libs/call/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/call/freebsd.c b/tools/libs/call/freebsd.c index 6d2e8704b3de549f8e3e6e1de158138fc0c8ef11..20ec28a564684cdec8fb49f4ec21a7fb5b7fcd63 100644 --- a/tools/libs/call/freebsd.c +++ b/tools/libs/call/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_freebsd_osdep.c */ diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c index 6d588e6bea8fab3e2dfe18966d95ae09c14899c3..65d5a764689d998f02adaa389b2be7ba4d25ac1e 100644 --- a/tools/libs/call/linux.c +++ b/tools/libs/call/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/call/minios.c b/tools/libs/call/minios.c index 3f33b8357829cc632f8775eda46e1a15699f0d5a..9b1435ca11494eb7600d52d520a537ae4d5910fe 100644 --- a/tools/libs/call/minios.c +++ b/tools/libs/call/minios.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_minios.c * diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c index 91ae68357e3ef7b973499c7621515bb4150c61bb..e27c0f32d7a40b9287593b56f3a8a78e0497c970 100644 --- a/tools/libs/call/netbsd.c +++ b/tools/libs/call/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_netbsd.c */ diff --git a/tools/libs/call/solaris.c b/tools/libs/call/solaris.c index 304262bd057b37e9724cf9e177b20e1b70e9dcde..b79102fe996e19e4f605aec0862075442ec733a4 100644 --- a/tools/libs/call/solaris.c +++ b/tools/libs/call/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split from xc_solaris.c */ diff --git a/tools/libs/ctrl/xc_altp2m.c b/tools/libs/ctrl/xc_altp2m.c index 6987c9541fd15cacb9880fb8f73763f63b023db7..cad63f74a1c922dcde6a0322387f3dc26e5a8de8 100644 --- a/tools/libs/ctrl/xc_altp2m.c +++ b/tools/libs/ctrl/xc_altp2m.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_cpu_hotplug.c b/tools/libs/ctrl/xc_cpu_hotplug.c index 2ea98257792ba0b10330de492e96c4b73860d7a8..9f3916300000a63703abee19f214c112383764f5 100644 --- a/tools/libs/ctrl/xc_cpu_hotplug.c +++ b/tools/libs/ctrl/xc_cpu_hotplug.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/ctrl/xc_cpupool.c b/tools/libs/ctrl/xc_cpupool.c index fbd8cc9d037c7761e78e5d7111e6eead027f8b3a..52dcfe4a274a5d64c534dd47ede42da9c889a5dd 100644 --- a/tools/libs/ctrl/xc_cpupool.c +++ b/tools/libs/ctrl/xc_cpupool.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2009, J Gross. */ diff --git a/tools/libs/ctrl/xc_csched.c b/tools/libs/ctrl/xc_csched.c index 8e8c67220a0bc88db1bbc1d7880a8a95dd39570a..24213fc4c3cf53939357d01f37b68b803e220675 100644 --- a/tools/libs/ctrl/xc_csched.c +++ b/tools/libs/ctrl/xc_csched.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_csched2.c b/tools/libs/ctrl/xc_csched2.c index 5eb753ad99158cfcd743fa4eb2260b17002f3793..14e4d15ad2644e1ffd5e08b4d6464cdab84e2f04 100644 --- a/tools/libs/ctrl/xc_csched2.c +++ b/tools/libs/ctrl/xc_csched2.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index e939d0715739f288bcf5c5f3c2a6f8865dddbbd1..d87105331dc3d394b16757b36cf9ebb9cf5db098 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2003, K A Fraser. */ diff --git a/tools/libs/ctrl/xc_evtchn.c b/tools/libs/ctrl/xc_evtchn.c index 614786d3f3197e93958abe4321f40a0becb11d3b..7578869367b922ef8182e9ec96b242409a276be1 100644 --- a/tools/libs/ctrl/xc_evtchn.c +++ b/tools/libs/ctrl/xc_evtchn.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2004, K A Fraser. */ diff --git a/tools/libs/ctrl/xc_flask.c b/tools/libs/ctrl/xc_flask.c index c1652ba48d7c9163080cea92ea874e729f1ad96f..e3b6e9f279d73b7abb7a0d7d12e5801d3837de59 100644 --- a/tools/libs/ctrl/xc_flask.c +++ b/tools/libs/ctrl/xc_flask.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_foreign_memory.c b/tools/libs/ctrl/xc_foreign_memory.c index 4053d268513673d18fedaeccd739b4186d33846d..47d65bf2f6c59574d2217be6c2239701cb9b507f 100644 --- a/tools/libs/ctrl/xc_foreign_memory.c +++ b/tools/libs/ctrl/xc_foreign_memory.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #define XC_BUILDING_COMPAT_MAP_FOREIGN_API diff --git a/tools/libs/ctrl/xc_freebsd.c b/tools/libs/ctrl/xc_freebsd.c index 9dd48a3a08bb00c4bd1f75caf99b7865a977030b..661e49a9a110e2e3f8f82a75d733c4c5c49012b1 100644 --- a/tools/libs/ctrl/xc_freebsd.c +++ b/tools/libs/ctrl/xc_freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_gnttab.c b/tools/libs/ctrl/xc_gnttab.c index eb92d897d49e54d48d08db56a3b7b3dd17bde7c8..7db3f81613cb915de47350a8889baddb87689b94 100644 --- a/tools/libs/ctrl/xc_gnttab.c +++ b/tools/libs/ctrl/xc_gnttab.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_hcall_buf.c b/tools/libs/ctrl/xc_hcall_buf.c index 200671f36ff2a036743de545243e29b786337bbe..59127484841bb835e1a5fb3db64e33b3e6d9a8eb 100644 --- a/tools/libs/ctrl/xc_hcall_buf.c +++ b/tools/libs/ctrl/xc_hcall_buf.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/ctrl/xc_linux.c b/tools/libs/ctrl/xc_linux.c index c67c71c08be3f43fbe579e9ec76d8f1218fe4d28..c961f53124caa57aff6a27c4996c0a526b0265e6 100644 --- a/tools/libs/ctrl/xc_linux.c +++ b/tools/libs/ctrl/xc_linux.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_mem_access.c b/tools/libs/ctrl/xc_mem_access.c index 6d613037d04ea81369c1ccde40126c0da574277a..15c047174b253ea28484f77e604e1ba8432537d1 100644 --- a/tools/libs/ctrl/xc_mem_access.c +++ b/tools/libs/ctrl/xc_mem_access.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_mem_paging.c b/tools/libs/ctrl/xc_mem_paging.c index 999a572cefdcbadfec7d1c1a854acecd0f2c6411..a940f3b95702f991e47f02e1f22c95bd2ff5d694 100644 --- a/tools/libs/ctrl/xc_mem_paging.c +++ b/tools/libs/ctrl/xc_mem_paging.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c index 2f65b3b22e13b37a7c7055920ab52b541e83b291..9813a731a359ff6905c8c814fe72be1cd5674698 100644 --- a/tools/libs/ctrl/xc_memshr.c +++ b/tools/libs/ctrl/xc_memshr.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_minios.c b/tools/libs/ctrl/xc_minios.c index 3dea7a78a576d7425f36096837cb25099a2577ab..0a75f382615caf9d2d9a7d2c2572ae5d2863a93d 100644 --- a/tools/libs/ctrl/xc_minios.c +++ b/tools/libs/ctrl/xc_minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #undef NDEBUG diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 265f15ec2da344e948cbbe532d6d456a09accfc0..3b8b19801be53efc1bb025cd6aa713ce1f4976c3 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_bitops.h" diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c index c5fa62ff30d2bc3107e52ed70242644d182730fc..4a29f199b0b4152d4767a2539eb5e4ced6ba5b5b 100644 --- a/tools/libs/ctrl/xc_monitor.c +++ b/tools/libs/ctrl/xc_monitor.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_netbsd.c b/tools/libs/ctrl/xc_netbsd.c index 31979937621ebd37de7578878b2825bd8f9b05b0..4609ba8599d8e3d02bb8a9f7335b615d6667c100 100644 --- a/tools/libs/ctrl/xc_netbsd.c +++ b/tools/libs/ctrl/xc_netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_pagetab.c b/tools/libs/ctrl/xc_pagetab.c index db25c20247573a3c638d7725c976433221a40141..b938d8b8369c54a4ebf4245268f43d572f0a7501 100644 --- a/tools/libs/ctrl/xc_pagetab.c +++ b/tools/libs/ctrl/xc_pagetab.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_physdev.c b/tools/libs/ctrl/xc_physdev.c index 460a8e779ce857e764e414c6dc118d6918d7aa6b..2fc2ac67a174d570bfddf2d7a1ce6cdbb46c575e 100644 --- a/tools/libs/ctrl/xc_physdev.c +++ b/tools/libs/ctrl/xc_physdev.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 76d7eb7f265da4e52a69f944e13e10621d6ad2e2..5af84c2bbeff0e80e5f89b5b439e1b080f595548 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c index 2f99a7d2cfb560cdf57ae6777f55d0310f943602..444e2e6ad92458dc811b16895eec365c6698d676 100644 --- a/tools/libs/ctrl/xc_private.c +++ b/tools/libs/ctrl/xc_private.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index ed960c6f30e65baf1b0857961cfdb276e12fdcfe..818c7a6c750e4bc618e6e658d665958c4a9daa01 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XC_PRIVATE_H diff --git a/tools/libs/ctrl/xc_rt.c b/tools/libs/ctrl/xc_rt.c index ad257c6e52878b652e5449804de02d61aa3d05ff..03bbacffa37b484cf51025c3ebf5a8260dc3f57d 100644 --- a/tools/libs/ctrl/xc_rt.c +++ b/tools/libs/ctrl/xc_rt.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_solaris.c b/tools/libs/ctrl/xc_solaris.c index 5128f3f0f49040cbe88d762f6f42448cbb8a8f21..629b0b21faadbdc6616c0b9e38641b1d6eac5989 100644 --- a/tools/libs/ctrl/xc_solaris.c +++ b/tools/libs/ctrl/xc_solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_tbuf.c b/tools/libs/ctrl/xc_tbuf.c index 283fbd1c8fb898bbbcb978e0fb71ca018504e362..110e4323a69a2d4ee02d356a19440863c1d8d8d7 100644 --- a/tools/libs/ctrl/xc_tbuf.c +++ b/tools/libs/ctrl/xc_tbuf.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_vm_event.c b/tools/libs/ctrl/xc_vm_event.c index a97c615b18999e96a29dd1ef0bfc09c5455e062a..a371cca306496d9f4cd4a8e3085d2f2aa1431783 100644 --- a/tools/libs/ctrl/xc_vm_event.c +++ b/tools/libs/ctrl/xc_vm_event.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/ctrl/xc_vmtrace.c b/tools/libs/ctrl/xc_vmtrace.c index 602502367f2393ab38b5680a707a7f3a444fa57a..b36455f1dd3d8fd56610593382e8bdfd56f224d3 100644 --- a/tools/libs/ctrl/xc_vmtrace.c +++ b/tools/libs/ctrl/xc_vmtrace.c @@ -19,7 +19,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/devicemodel/common.c b/tools/libs/devicemodel/common.c index 0fdc7121f1eb7707f1f330577c9f4a2c948199f9..e18c2379e55d939323c91eb214d1e35900fa9bc1 100644 --- a/tools/libs/devicemodel/common.c +++ b/tools/libs/devicemodel/common.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/devicemodel/compat.c b/tools/libs/devicemodel/compat.c index 5b4fdae2980450518919d60d50bf4acbeb6b100b..3c72737b0c50e3bea926317c4bea412b4089febc 100644 --- a/tools/libs/devicemodel/compat.c +++ b/tools/libs/devicemodel/compat.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index 8e619eeb0a1fc5faf7043e90ceb91becf9999db0..a30bdaa465ed8f03ed2316b3e42b991e2293be2c 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c index de925fc9630c0ca398b75c3d02ad81cbddbe21ed..5d70e827a8a450d3624e6357319ad0ee77b2a5b8 100644 --- a/tools/libs/evtchn/core.c +++ b/tools/libs/evtchn/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c index 422836f1a1145de40dbbe771e0825b6d327ab377..0a557fce99b72cbf6205a26ae25689d7166c1f02 100644 --- a/tools/libs/evtchn/freebsd.c +++ b/tools/libs/evtchn/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from xc_freebsd_osdep.c */ diff --git a/tools/libs/evtchn/linux.c b/tools/libs/evtchn/linux.c index e61b77ca618a502448b7fcf4eedc83de4dfbca65..e9576e6ffc7fda7bb7bef7795bef35a9517ee58f 100644 --- a/tools/libs/evtchn/linux.c +++ b/tools/libs/evtchn/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c index 28743cb055753f02976c9258003203b51c40a242..6f5482edcfa716fb27f1818178a4cdc05d6317d9 100644 --- a/tools/libs/evtchn/minios.c +++ b/tools/libs/evtchn/minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split off from xc_minios.c */ diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c index 2de9cefc67f89b2a0ebd39c3008be0147701de1c..68047ef65c6fe77723308ec02fc77be523ee7324 100644 --- a/tools/libs/evtchn/netbsd.c +++ b/tools/libs/evtchn/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_netbsd.c */ diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c index 375a5f9b4fce280688fa0c6dcf8480cfb40fb78f..d137c7a30c044366ca36e03f766450f6ba490919 100644 --- a/tools/libs/evtchn/solaris.c +++ b/tools/libs/evtchn/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_solaris.c */ diff --git a/tools/libs/foreignmemory/compat.c b/tools/libs/foreignmemory/compat.c index 5f730ca919d670de43cd1581a131224a856a050d..2d743720a42cf575f220d80cf3cd3d1f61fdf8a4 100644 --- a/tools/libs/foreignmemory/compat.c +++ b/tools/libs/foreignmemory/compat.c @@ -11,7 +11,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_foreign_memory.c */ diff --git a/tools/libs/foreignmemory/core.c b/tools/libs/foreignmemory/core.c index 7edc6f0dbfe35859819b9d5f6a21b12c61a8b471..ab6e8820e67a232c6c9002ba4c03f8604e0b9cf6 100644 --- a/tools/libs/foreignmemory/core.c +++ b/tools/libs/foreignmemory/core.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/freebsd.c b/tools/libs/foreignmemory/freebsd.c index 2cf0fa1c38b1544e43116867bf48b3e3bf47f959..d18e9f9112b3bad4444ec0ccfb0cd1d24cc243ab 100644 --- a/tools/libs/foreignmemory/freebsd.c +++ b/tools/libs/foreignmemory/freebsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c index 9062117407a998634c6115043bbe33339e53ee19..7f6a327a9b43ee2b76f58fb918ffe004afab7d85 100644 --- a/tools/libs/foreignmemory/linux.c +++ b/tools/libs/foreignmemory/linux.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linus_osdep.c: * diff --git a/tools/libs/foreignmemory/minios.c b/tools/libs/foreignmemory/minios.c index f2f4dfb2be51851431b776e8b0d0c277cb13ec7e..0f7570772e3d9389f6373e8becaa8a6e292bd98f 100644 --- a/tools/libs/foreignmemory/minios.c +++ b/tools/libs/foreignmemory/minios.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_minios.c * diff --git a/tools/libs/foreignmemory/netbsd.c b/tools/libs/foreignmemory/netbsd.c index 597db775d7ea428f865f3a53192494617e69cb49..8220452d6dd47662f76bc5d1fe2e3580ebd1eaad 100644 --- a/tools/libs/foreignmemory/netbsd.c +++ b/tools/libs/foreignmemory/netbsd.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/foreignmemory/solaris.c b/tools/libs/foreignmemory/solaris.c index 958fb01f6d24a0e166b3a1d0db3000c2e84659ac..8dceeab84053fe8ed8472e6e94e015a4254acae7 100644 --- a/tools/libs/foreignmemory/solaris.c +++ b/tools/libs/foreignmemory/solaris.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/gnttab/freebsd.c b/tools/libs/gnttab/freebsd.c index e42ac3fbf351470d43b085eed0e172a0f85b8e09..97373b3faee3fc91a006c870fa431ab0e5aa013e 100644 --- a/tools/libs/gnttab/freebsd.c +++ b/tools/libs/gnttab/freebsd.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from linux.c */ diff --git a/tools/libs/gnttab/gntshr_core.c b/tools/libs/gnttab/gntshr_core.c index 1117e29c91335eb50b0c848b7ead2449ab148df9..2483d4987618aebff4b62f3673dc53fa62f9316c 100644 --- a/tools/libs/gnttab/gntshr_core.c +++ b/tools/libs/gnttab/gntshr_core.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gntshr_unimp.c b/tools/libs/gnttab/gntshr_unimp.c index e21048435b1795ec5f057966aacbab5e09ae3892..dd08bc1265b97e86e7a69b0d03c1a4a8fe89782a 100644 --- a/tools/libs/gnttab/gntshr_unimp.c +++ b/tools/libs/gnttab/gntshr_unimp.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gnttab_core.c b/tools/libs/gnttab/gnttab_core.c index 92e7228a267123c1e5156ea3d74b081bcbd7cbf0..4b6cdf26747bca181286a405efca64815e4c179a 100644 --- a/tools/libs/gnttab/gnttab_core.c +++ b/tools/libs/gnttab/gnttab_core.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/gnttab_unimp.c b/tools/libs/gnttab/gnttab_unimp.c index dee1afd2647f9f69a1d2a0dc5450b31ffd81a4da..bef13af9d85cd1aa71516dea052781f4bec824eb 100644 --- a/tools/libs/gnttab/gnttab_unimp.c +++ b/tools/libs/gnttab/gnttab_unimp.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_gnttab.c */ diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c index 5628fd5719d1d7f95f5c5ca3f6e22cee708b32cf..e730250bcf8e2876f618321fbc45735c1f961a5c 100644 --- a/tools/libs/gnttab/linux.c +++ b/tools/libs/gnttab/linux.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from xc_linux_osdep.c */ diff --git a/tools/libs/gnttab/minios.c b/tools/libs/gnttab/minios.c index cac89f0ba6206df7e4271427269cd4e39069a459..410b545ec694605688f909d014380bf3c3febe5c 100644 --- a/tools/libs/gnttab/minios.c +++ b/tools/libs/gnttab/minios.c @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Splitfrom xc_minios.c */ diff --git a/tools/libs/gnttab/netbsd.c b/tools/libs/gnttab/netbsd.c index a4ad624b5415f050bcd23503e5e478ff6a5699f7..2c1a80f45421473f9dfb7303c7a07ade97ccbf37 100644 --- a/tools/libs/gnttab/netbsd.c +++ b/tools/libs/gnttab/netbsd.c @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Split out from linux.c */ diff --git a/tools/libs/guest/xg_core.c b/tools/libs/guest/xg_core.c index c52f1161c1c8ff7e7f6effdc8a40ee449d4eaa81..6cb3d1b24a5d331e2480e83fab2a82cfe816d515 100644 --- a/tools/libs/guest/xg_core.c +++ b/tools/libs/guest/xg_core.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ /* diff --git a/tools/libs/guest/xg_core.h b/tools/libs/guest/xg_core.h index aaca9e0a8b992b5915ddfd20ef474ace8eccaeaf..a7585fa7aae06534cfd536cad6815ea0cc0a6fa6 100644 --- a/tools/libs/guest/xg_core.h +++ b/tools/libs/guest/xg_core.h @@ -13,7 +13,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_core_arm.c b/tools/libs/guest/xg_core_arm.c index aaabd075585e4ab69f7b690bab6a8256509a5fa6..c4a89b15e48fe6acba6f3f75a13412f1d0d98b35 100644 --- a/tools/libs/guest/xg_core_arm.c +++ b/tools/libs/guest/xg_core_arm.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011 Citrix Systems * diff --git a/tools/libs/guest/xg_core_arm.h b/tools/libs/guest/xg_core_arm.h index 162f7a7569e7067ebdb096c571439c4f6e7714b8..df0a2a2d2a7451c9a7e948aed0646f1a8d79fb7d 100644 --- a/tools/libs/guest/xg_core_arm.h +++ b/tools/libs/guest/xg_core_arm.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2012 Citrix Systems * diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 61106b98b87701330d0833e7d138a55b2f614416..dcfe6a7c59796f0114c8c5f6740f271a246df5f0 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2007 Isaku Yamahata * VA Linux Systems Japan K.K. diff --git a/tools/libs/guest/xg_core_x86.h b/tools/libs/guest/xg_core_x86.h index 867146b1d9e73bed2810f6aa60f22bcc9b12d58b..4c9f82480861b6c24f331d243e7cf9a58b83d651 100644 --- a/tools/libs/guest/xg_core_x86.h +++ b/tools/libs/guest/xg_core_x86.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2007 Isaku Yamahata * VA Linux Systems Japan K.K. diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 57f81eb0a0822b6d17cb5dfce90ef964a9178b75..72b23b5f7610e5c549f446da480ca50a91bee527 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c index 5e3b76355ec4850056a415cdbba25b52e7ca8c28..0aa693047e0a5d3779272b11276797d8a771ba74 100644 --- a/tools/libs/guest/xg_dom_arm.c +++ b/tools/libs/guest/xg_dom_arm.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011, Citrix Systems */ diff --git a/tools/libs/guest/xg_dom_armzimageloader.c b/tools/libs/guest/xg_dom_armzimageloader.c index 6d837cefc4a25b85d4974c1672b7d649d61edf32..ac822a213cb14264be946ce546493209e500124a 100644 --- a/tools/libs/guest/xg_dom_armzimageloader.c +++ b/tools/libs/guest/xg_dom_armzimageloader.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_dom_binloader.c b/tools/libs/guest/xg_dom_binloader.c index f5e3ddc5dc4d515f455ef70aaa3cf607eaad4d37..bf8bfbefb994a58761d38961e12ff65b50faca86 100644 --- a/tools/libs/guest/xg_dom_binloader.c +++ b/tools/libs/guest/xg_dom_binloader.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Some of the field descriptions were copied from "The Multiboot * Specification", Copyright 1995, 96 Bryan Ford , diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c index 263a3f4c85a660790a8794b9147e338047bda18e..d20b37401269d0481658b502ffe9c694cbf884d6 100644 --- a/tools/libs/guest/xg_dom_boot.c +++ b/tools/libs/guest/xg_dom_boot.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_bzimageloader.c b/tools/libs/guest/xg_dom_bzimageloader.c index 764ddbb43eb82dfe8c12eb95f38d952ed5c8c374..4e1693e625b16dfd017e4b7f38fdc5e985248e20 100644 --- a/tools/libs/guest/xg_dom_bzimageloader.c +++ b/tools/libs/guest/xg_dom_bzimageloader.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * written 2007 by Jeremy Fitzhardinge diff --git a/tools/libs/guest/xg_dom_compat_linux.c b/tools/libs/guest/xg_dom_compat_linux.c index a0d9c7a04e85946804ecf48bc4e1d3bf47e83220..1b18b51ba6df30f67724fa395a9aeab2c06e71c7 100644 --- a/tools/libs/guest/xg_dom_compat_linux.c +++ b/tools/libs/guest/xg_dom_compat_linux.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c index c4f4e7f3e27a13f4cb72eb96552c921c6b45e4c8..a228496fd4066bae8e9a862d6548b6e6f65bc78b 100644 --- a/tools/libs/guest/xg_dom_core.c +++ b/tools/libs/guest/xg_dom_core.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_elfloader.c b/tools/libs/guest/xg_dom_elfloader.c index f17930d98bf70fa3a0a7dced02177e0ce6123538..f71a49a4332c973ab3f3c58964cf4f764ca4c6c4 100644 --- a/tools/libs/guest/xg_dom_elfloader.c +++ b/tools/libs/guest/xg_dom_elfloader.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_dom_hvmloader.c b/tools/libs/guest/xg_dom_hvmloader.c index 39e1e5f579a738b5f71c0ef28dcd821817b22a94..e78754ce26b3af00447d14fa45a219d855fc5061 100644 --- a/tools/libs/guest/xg_dom_hvmloader.c +++ b/tools/libs/guest/xg_dom_hvmloader.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * */ diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c index 9328fbf804853d98db175b6a02bcc925fd8b1181..b536afbe3cf2229872be53618781d2fa41332ba3 100644 --- a/tools/libs/guest/xg_dom_x86.c +++ b/tools/libs/guest/xg_dom_x86.c @@ -16,7 +16,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * written 2006 by Gerd Hoffmann . * diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c index f0e7748449a1c7b13ec601d66bef4d18eb9485c0..ce4562b024defb0cad10bf1b441b244b1812e679 100644 --- a/tools/libs/guest/xg_domain.c +++ b/tools/libs/guest/xg_domain.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2003, K A Fraser. */ diff --git a/tools/libs/guest/xg_nomigrate.c b/tools/libs/guest/xg_nomigrate.c index 6795c62ddc2803527bf0e74843cb86ef99231de0..f9b528cf25c9e20f72bd85cc33c976641987472e 100644 --- a/tools/libs/guest/xg_nomigrate.c +++ b/tools/libs/guest/xg_nomigrate.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (c) 2011, Citrix Systems */ diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index c594fdba415de8cde8d08e53710b9c0437a8b5a4..406ec536e169d3b489c9dadd155160c122f4d10a 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_private.c b/tools/libs/guest/xg_private.c index 2073dba2ef2091b71e175252b5da7b14549602d2..291ed0b237eb9bb380751ae40a938953918fbe1d 100644 --- a/tools/libs/guest/xg_private.c +++ b/tools/libs/guest/xg_private.c @@ -14,7 +14,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h index 09e24f122760a4bfc6a8e73c922ed44b5f8da635..62d8a153210684a24103650cc1c4e283d190c50e 100644 --- a/tools/libs/guest/xg_private.h +++ b/tools/libs/guest/xg_private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XG_PRIVATE_H diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c index 77e2451a3c4daa7712a056bf9886661ff474bcdb..0b5451c8a4fdf154342bc0b38f4459297f1bc84a 100644 --- a/tools/libs/guest/xg_resume.c +++ b/tools/libs/guest/xg_resume.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xg_private.h" diff --git a/tools/libs/guest/xg_save_restore.h b/tools/libs/guest/xg_save_restore.h index 3dbbc8dcd271c59a35836ab9d2a911cdb5126843..a30c909271c596627dfa74714e98ec359ae0a5dd 100644 --- a/tools/libs/guest/xg_save_restore.h +++ b/tools/libs/guest/xg_save_restore.h @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xc_private.h" diff --git a/tools/libs/guest/xg_suspend.c b/tools/libs/guest/xg_suspend.c index 0ce63649636905851e03750a0ae8bcb63dd926f1..62d9b3d9ed65364c982065169d4d9941fa9861d5 100644 --- a/tools/libs/guest/xg_suspend.c +++ b/tools/libs/guest/xg_suspend.c @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c index 52b30db8d777c357fb85f3e936ce120d1431f421..522576a152251280d4e73ed0254d83782650edf4 100644 --- a/tools/libs/hypfs/core.c +++ b/tools/libs/hypfs/core.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #define __XEN_TOOLS__ 1 diff --git a/tools/libs/stat/COPYING b/tools/libs/stat/COPYING index 480e5f18765e660f5e9d00f9bb09097bdc3d3084..d49f0cf1a31a59bda21b086c12cc4e5071bcb635 100644 --- a/tools/libs/stat/COPYING +++ b/tools/libs/stat/COPYING @@ -489,7 +489,7 @@ notice is found. Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index 7a9a8b1656b05799515b75520cbc32bba72069a0..faafb3a1c5fc65a76603c47ab29cdd0ae010150f 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #define _GNU_SOURCE diff --git a/tools/libs/toolcore/handlereg.c b/tools/libs/toolcore/handlereg.c index b43cb0e8acab7a06d65a3215934bd56e1e8d93a0..4a9d87b64107ad9b0aaa112926a8cf7bf946a3ea 100644 --- a/tools/libs/toolcore/handlereg.c +++ b/tools/libs/toolcore/handlereg.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoolcore_internal.h" diff --git a/tools/libs/toollog/xtl_core.c b/tools/libs/toollog/xtl_core.c index 099d2f30951d613e189cd7d980f39f274c91a772..c526c44ab4918ce1f67cd778d95054ad0fe8eaef 100644 --- a/tools/libs/toollog/xtl_core.c +++ b/tools/libs/toollog/xtl_core.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoollog.h" diff --git a/tools/libs/toollog/xtl_logger_stdio.c b/tools/libs/toollog/xtl_logger_stdio.c index 52dfbf51e35b122462fa966f4c4171b768dd0204..4fc17aad96929eb2cf75a45d2b6027975fdb9515 100644 --- a/tools/libs/toollog/xtl_logger_stdio.c +++ b/tools/libs/toollog/xtl_logger_stdio.c @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "xentoollog.h" diff --git a/tools/libs/util/libxlu_cfg_y.c b/tools/libs/util/libxlu_cfg_y.c index 6d4638afc937368065943fee2386aa523a1c12a3..055b697437d9dc7d9ce9d63fa965ded14ba10932 100644 --- a/tools/libs/util/libxlu_cfg_y.c +++ b/tools/libs/util/libxlu_cfg_y.c @@ -16,7 +16,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program. If not, see . */ + along with this program. If not, see . */ /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work diff --git a/tools/libs/util/libxlu_cfg_y.h b/tools/libs/util/libxlu_cfg_y.h index 1233cb94fccc3d7c442ebb3692af23000c550983..01f12531a641c78a2e5265361dab01e31974170a 100644 --- a/tools/libs/util/libxlu_cfg_y.h +++ b/tools/libs/util/libxlu_cfg_y.h @@ -16,7 +16,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program. If not, see . */ + along with this program. If not, see . */ /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98759897d324bf0a712f7788be1e5865..9136a118753858e3e70dbbe37247d4747b449af9 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c index 1f201ad554f2dc050f45e63b92446d301fb76d89..00281ebf36f1a3cbb93316b458e9eddc9b7f32d9 100644 --- a/tools/libs/vchan/io.c +++ b/tools/libs/vchan/io.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h index 621016ef42e5eaf57f1c0d5e333801d35b3abe35..9aec37906960f80c5bbf717717eb2e6f9cf528ba 100644 --- a/tools/libs/vchan/vchan.h +++ b/tools/libs/vchan/vchan.h @@ -17,7 +17,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * @section DESCRIPTION * diff --git a/tools/misc/mkhex b/tools/misc/mkhex index d0982d5787286ba894087358115824cc75eaea30..0cc49047cbf33aabde0291ce407f314210d4c42f 100755 --- a/tools/misc/mkhex +++ b/tools/misc/mkhex @@ -16,7 +16,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # echo "unsigned $1[] = {" diff --git a/tools/misc/xen-mceinj.c b/tools/misc/xen-mceinj.c index df55eefbacc585e7e62eff1c40972cfa15015b35..b385eaac57021a1bbb6b2691c9178bdd2339cf55 100644 --- a/tools/misc/xen-mceinj.c +++ b/tools/misc/xen-mceinj.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Authors: Yunhong Jiang * Haicheng Li diff --git a/tools/misc/xen-vmtrace.c b/tools/misc/xen-vmtrace.c index 5b688a54af5a1c59a4cc85acbf81c9b0e164a5e9..93af18ebbd8adfe364bb1f72c414188f685d6053 100644 --- a/tools/misc/xen-vmtrace.c +++ b/tools/misc/xen-vmtrace.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/misc/xencov.c b/tools/misc/xencov.c index e5b40dba9cf1c1f42f4efc2d851cdefcb33ad37a..28e006569a204eef5593dee8868ab32a5b80b396 100644 --- a/tools/misc/xencov.c +++ b/tools/misc/xencov.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 4f8cde690a7c77f4465fd0815c901b4232240419..162a18fe7e1485145a6255f8c653b47552f24a97 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define MAX_NR_CPU 512 diff --git a/tools/misc/xenpvnetboot b/tools/misc/xenpvnetboot index be972b9e19b7ff55e7723c37d1e2affd306fae22..2d56c279f07e013bea811c37d4ffca14bb61c6a5 100755 --- a/tools/misc/xenpvnetboot +++ b/tools/misc/xenpvnetboot @@ -8,7 +8,7 @@ # useful, but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General # Public License for more details. You should have received a copy of the GNU -# General Public License along with this program; If not, see . +# General Public License along with this program; If not, see . import sys import os diff --git a/tools/ocaml/LICENSE b/tools/ocaml/LICENSE index d4d1f176886856c1e536ca925471520ba9c7bcfe..f11101ec2d33d936815e259bd757869e456d2bfd 100644 --- a/tools/ocaml/LICENSE +++ b/tools/ocaml/LICENSE @@ -181,7 +181,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public -License along with this library; If not, see . +License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/pygrub/src/ExtLinuxConf.py b/tools/pygrub/src/ExtLinuxConf.py index 9fd635b9cf7ad56a925e955be9702922d2648121..c12fa3a1912c92ced8ecf3f1f3596af55f67773f 100644 --- a/tools/pygrub/src/ExtLinuxConf.py +++ b/tools/pygrub/src/ExtLinuxConf.py @@ -7,7 +7,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function, absolute_import diff --git a/tools/pygrub/src/GrubConf.py b/tools/pygrub/src/GrubConf.py index 73f1bbed2f543333172104683768710ed61b6bf3..958a15a44af1b284b1a5b69aa8557ae1585f4af2 100644 --- a/tools/pygrub/src/GrubConf.py +++ b/tools/pygrub/src/GrubConf.py @@ -9,7 +9,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function, absolute_import diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub index ce7ab0eb8cf3c352dfc5ac1726b88cbbf953ff28..eda2aa1f4e0de8fb70749140e0f52f365277b7de 100755 --- a/tools/pygrub/src/pygrub +++ b/tools/pygrub/src/pygrub @@ -9,7 +9,7 @@ # general public license. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . # from __future__ import print_function diff --git a/tools/python/xen/lowlevel/xs/xs.c b/tools/python/xen/lowlevel/xs/xs.c index 3ba5a8b893d9c0ce7b5aaf242242568910807d06..bb78f5b84bb6771ea6786cd14267cb8f9c4de3db 100644 --- a/tools/python/xen/lowlevel/xs/xs.c +++ b/tools/python/xen/lowlevel/xs/xs.c @@ -11,7 +11,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Copyright (C) 2005 Mike Wray Hewlett-Packard * Copyright (C) 2005 Christian Limpach diff --git a/tools/tests/depriv/depriv-fd-checker.c b/tools/tests/depriv/depriv-fd-checker.c index 98a27a03d5438b783c6ae4cf0c23591b48b57c93..bd0bdb2d54f2aeef910843e645e30bb6cc7b89c6 100644 --- a/tools/tests/depriv/depriv-fd-checker.c +++ b/tools/tests/depriv/depriv-fd-checker.c @@ -47,7 +47,7 @@ * * You should have received a copy of the GNU Lesser General Public * License along with this library; If not, see - * . + * . */ #include diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index b022cc0eab0373f8e1896df6d710ad94afb3c62f..bec67fcea1361cabb858fae618a3907ba14f769f 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -10,7 +10,7 @@ * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. . + * General Public License for more details. . */ #include diff --git a/tools/tests/vhpet/main.c b/tools/tests/vhpet/main.c index 4054eec6296910d3117334091b3dac190f9aea29..8452da8a60192b66f3980987a74caf19d48fff4c 100644 --- a/tools/tests/vhpet/main.c +++ b/tools/tests/vhpet/main.c @@ -10,7 +10,7 @@ * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. . + * General Public License for more details. . */ /* diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index f03e3a56d18121184f725c6003943fdb7c5e40eb..50f4c1b9d3e9067cbafdfdf25c77ddb8779cb139 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef _TEST_VPCI_ diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c index b9a0a6006bb98c4b7d28ad5d2b9a20ecaff0352a..1348722947f2cad87ed9b39d195b35413bab97a3 100644 --- a/tools/tests/vpci/main.c +++ b/tools/tests/vpci/main.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include "emul.h" diff --git a/tools/tests/x86_emulator/blowfish.c b/tools/tests/x86_emulator/blowfish.c index 8f0939c101879ad5fd2aab202b4619960f5231c0..7c02bbd3ac2219960ca6937e97956410381e417c 100644 --- a/tools/tests/x86_emulator/blowfish.c +++ b/tools/tests/x86_emulator/blowfish.c @@ -12,7 +12,7 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public -License along with this library; If not, see . +License along with this library; If not, see . */ #include diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c index d3574b3fa27025de7115b6c4dda80e8408141fe0..37bde5a67316ec853b6567f5ffd9e7fba57676d0 100644 --- a/tools/tests/xenstore/test-xenstore.c +++ b/tools/tests/xenstore/test-xenstore.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/vchan/node-select.c b/tools/vchan/node-select.c index 039464427a8b54f3a4bc8cd3d5de7bca1aaf9509..e885a05a33c4b1357b0c1ead5799cc9661ba58cd 100644 --- a/tools/vchan/node-select.c +++ b/tools/vchan/node-select.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/vchan/node.c b/tools/vchan/node.c index f1638f013d3d5fc4f00427080848f8022ae7efed..d9720154aaa7801deee7669ff74b9005e83ce627 100644 --- a/tools/vchan/node.c +++ b/tools/vchan/node.c @@ -21,7 +21,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/vchan/vchan-socket-proxy.c b/tools/vchan/vchan-socket-proxy.c index e1d959c6d15ce84e71bafcb512743d1c65f1dc07..72f16e05420b1c42b3b8cc6810932e49975cadc7 100644 --- a/tools/vchan/vchan-socket-proxy.c +++ b/tools/vchan/vchan-socket-proxy.c @@ -22,7 +22,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * @section DESCRIPTION * diff --git a/tools/xenmon/COPYING b/tools/xenmon/COPYING index ec0f60d1ffd93b956159a23858b2393c58f26d4e..a7ee562a7c71f5ae42a698d0f3fc8cbabf919646 100644 --- a/tools/xenmon/COPYING +++ b/tools/xenmon/COPYING @@ -304,7 +304,7 @@ the "copyright" line and a pointer to where the full notice is found. GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/xenmon/setmask.c b/tools/xenmon/setmask.c index 7e7b7b8f4378c4f690520a3e000b6f90ca0b9201..4452ceacf7151c6585cc28fa5e3b5527a84febea 100644 --- a/tools/xenmon/setmask.c +++ b/tools/xenmon/setmask.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c index 4dddbd20e2fb39a4216f5efe351c13dee0305836..9df18480d5e5401d23871c68efd8e237d2ed7887 100644 --- a/tools/xenmon/xenbaked.c +++ b/tools/xenmon/xenbaked.c @@ -26,7 +26,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenmon/xenbaked.h b/tools/xenmon/xenbaked.h index 9eeacbb5843a3af6efceb10bd953df3249ce8266..b2943edd8135fa132fd621c98fe8d639011b9cf8 100644 --- a/tools/xenmon/xenbaked.h +++ b/tools/xenmon/xenbaked.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __QOS_H__ diff --git a/tools/xenmon/xenmon.py b/tools/xenmon/xenmon.py index 977ada68877139b783345980e78769efd47ca3f5..f37fc29afb573d8abcf6b4b66df97ad246462b64 100644 --- a/tools/xenmon/xenmon.py +++ b/tools/xenmon/xenmon.py @@ -20,7 +20,7 @@ # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License -# along with this program; If not, see . +# along with this program; If not, see . ##################################################################### from __future__ import print_function diff --git a/tools/xenpaging/file_ops.c b/tools/xenpaging/file_ops.c index 301fb3427cc5f8ca271fcc00343772e87efde76f..f13ba9848c26137c8f3c1cd7b82eb01efed48ace 100644 --- a/tools/xenpaging/file_ops.c +++ b/tools/xenpaging/file_ops.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/file_ops.h b/tools/xenpaging/file_ops.h index ee3fd7d8b86c9d2a187daaf7aaa7c8a94a761aaa..5a9466fb587583bb727a42d6a82d8f062be1cea7 100644 --- a/tools/xenpaging/file_ops.h +++ b/tools/xenpaging/file_ops.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/policy.h b/tools/xenpaging/policy.h index b1425a90ef6d3bb5c5132354bb8abe4daf28a006..81356f9c18770988559a242bbcbfe801dd5d511b 100644 --- a/tools/xenpaging/policy.h +++ b/tools/xenpaging/policy.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpaging/policy_default.c b/tools/xenpaging/policy_default.c index 979d251230451710de9087ee348bad47a2261d04..801dfa182d7b743fb9ec3db82e3bab7facc064cb 100644 --- a/tools/xenpaging/policy_default.c +++ b/tools/xenpaging/policy_default.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 6e5490315d0128ed9065308675dab10de3a31c44..a579394b35c2bacbb9468adacbec86c696fd50c0 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define _GNU_SOURCE diff --git a/tools/xenpaging/xenpaging.h b/tools/xenpaging/xenpaging.h index e0fc7b31b863b2c4390e6c9f317898f41a1005d2..a1a5074b9ee3b70a13b37102213114d6439e1abc 100644 --- a/tools/xenpaging/xenpaging.h +++ b/tools/xenpaging/xenpaging.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index 15e6169c449de77517de2cb67c21a5c5c4cd4851..f5a8513bc1b6da7fe45f09c31ac98412932dc3b5 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* Xen extended power management support provides HVM guest power management diff --git a/tools/xenstore/COPYING b/tools/xenstore/COPYING index c764b2e3292196157cafb19aef908c9565146be4..00f925a24f36e388fca35ebb9ac1f188c6774ffd 100644 --- a/tools/xenstore/COPYING +++ b/tools/xenstore/COPYING @@ -494,7 +494,7 @@ notice is found. Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/tools/xenstore/include/xenstore_state.h b/tools/xenstore/include/xenstore_state.h index ae0d053c8ffc07c1e0491da647bcc40728d127f3..d949d3aa6522c0b0cc563fc3451e3e62cedc0c82 100644 --- a/tools/xenstore/include/xenstore_state.h +++ b/tools/xenstore/include/xenstore_state.h @@ -15,7 +15,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef XENSTORE_STATE_H diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c index 9eda1bfc00c0b6b35d34ce25268fc9c070d9da55..91b620c2c604307f3fd662697ab152bcae7c1836 100644 --- a/tools/xenstore/talloc.c +++ b/tools/xenstore/talloc.c @@ -22,7 +22,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ /* diff --git a/tools/xenstore/talloc.h b/tools/xenstore/talloc.h index a0f4bff25788e6964cc42ad9f9c3b5af0fe4a49a..bd027e0f8db2873d9c0231a47baa03b69f9b75ca 100644 --- a/tools/xenstore/talloc.h +++ b/tools/xenstore/talloc.h @@ -21,7 +21,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #include diff --git a/tools/xenstore/tdb.c b/tools/xenstore/tdb.c index 29593b76c308a928e109dec32aea7563dc5b2b8b..d53dfed7979aba9d9ad0f7113cb33a2bdadeb85b 100644 --- a/tools/xenstore/tdb.c +++ b/tools/xenstore/tdb.c @@ -22,7 +22,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ diff --git a/tools/xenstore/tdb.h b/tools/xenstore/tdb.h index ce3c7339f884af1fb381266d729148aefe62f8c7..4676b9058b554ee0b06d1f121e07bc1a40729678 100644 --- a/tools/xenstore/tdb.h +++ b/tools/xenstore/tdb.h @@ -25,7 +25,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifdef __cplusplus diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index cbd62556c3ae50a9d539de14d28890c8d9a9f81a..3d8be860bdf9846c10edb4bde60b4d4e091a507e 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_control.h b/tools/xenstore/xenstored_control.h index a8cb76559ba1e4e13b9c12d14f82765afa090a2b..6ea1194d3ce214dc12a3e83525d47ad3aa3f1373 100644 --- a/tools/xenstore/xenstored_control.h +++ b/tools/xenstore/xenstored_control.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ int do_control(const void *ctx, struct connection *conn, diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 4f00e0cdc0cf30f57a9ab972e9b5752f83724856..5893dfa2560eb844e476d2e56ab06692d6299414 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h index c59b06551f543b3909fdb6a49ef57ff9db000d45..3d9c6c66b987e412a3f7ddbe615391db7ec2157a 100644 --- a/tools/xenstore/xenstored_core.h +++ b/tools/xenstore/xenstored_core.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_CORE_H diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 9ef41ede03ae16a86ad8274df9d53a0209c96a31..2dae7fc4bdf017c3980a1c7d51e43a667560de98 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index dc4660861eb752142e931d3c870e4c46228016d0..f5f5e0d71e1adb3be00717675b311634755a31d7 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_DOMAIN_H diff --git a/tools/xenstore/xenstored_minios.c b/tools/xenstore/xenstored_minios.c index aa384e50c8fec8297d9870ab3f8c9275fd20babd..3f5ceef9fc9380fdeb9922bfd2391a2dc7c84f8d 100644 --- a/tools/xenstore/xenstored_minios.c +++ b/tools/xenstore/xenstored_minios.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include #include diff --git a/tools/xenstore/xenstored_posix.c b/tools/xenstore/xenstored_posix.c index b20504d1b656b004e5d0dd5cc77cef80d24d9f7f..c422ac1d44d399d2b5ecda0508b07cbdaf0e2128 100644 --- a/tools/xenstore/xenstored_posix.c +++ b/tools/xenstore/xenstored_posix.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 1aa9d3cb3dce2792256e0f373f1f6e65f8523e35..f347c4fb8e367f993aaebfe7aa92d78c44a59f64 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_transaction.h b/tools/xenstore/xenstored_transaction.h index b6f8cb7d0a3b13d9f68eed1fc2443b8ac40c33b8..4e2eb585ebd194fc114a8fa630ec6befc165cf16 100644 --- a/tools/xenstore/xenstored_transaction.h +++ b/tools/xenstore/xenstored_transaction.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_TRANSACTION_H #define _XENSTORED_TRANSACTION_H diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 8ad0229df648361a40435927f85c4341f72f3658..a2d1054bb581b4733bc5ca2a386a0d59cbe85b4e 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #include diff --git a/tools/xenstore/xenstored_watch.h b/tools/xenstore/xenstored_watch.h index 091890edca966c4e714fd77397f48f4122aecf73..51f7f64ff4ff911754380e7447cf0600ce13eb8f 100644 --- a/tools/xenstore/xenstored_watch.h +++ b/tools/xenstore/xenstored_watch.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . */ #ifndef _XENSTORED_WATCH_H diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index b9941c567cd0559ee76431e9eee525cf0f3ea30c..e8cf37d0bb092efe24be6544743301c2cefd7aff 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #include diff --git a/tools/xenstore/xs_lib.h b/tools/xenstore/xs_lib.h index efa05997d67c30f75be28f0389980117351f396f..78a0a9549a51cf6030b9d37a5ac1464771eca1a2 100644 --- a/tools/xenstore/xs_lib.h +++ b/tools/xenstore/xs_lib.h @@ -13,7 +13,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with this library; If not, see . + License along with this library; If not, see . */ #ifndef XS_LIB_H diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c index 950e8935c4c149f9bcd15eeb8691837d0ea881a4..0037f4f1f30e786152631ab89b47d0f1f4967d80 100644 --- a/tools/xentop/xentop.c +++ b/tools/xentop/xentop.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* get curses header from configure */ diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 5de167031e01d73a7e3fdfa1b8bd67352b2b45d9..e555e0cca37a939818f95b6314b105bf87461d9a 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define _XOPEN_SOURCE 600 #include diff --git a/xen/COPYING b/xen/COPYING index ddb3494147a1312ffb8120c9486eea0d21ec4718..e76aa91592a88ed1510ef6fa8066050d89af6c14 100644 --- a/xen/COPYING +++ b/xen/COPYING @@ -331,7 +331,7 @@ the "copyright" line and a pointer to where the full notice is found. GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . Also add information on how to contact you by electronic and paper mail. diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index db5085e15d84321b6d05aa338ffbf25e26ec8913..dda7b4e74e76490a0a77a0db020d4ac3a45a5f0e 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c index 41d521f720ac5fe4fe2a2f5f2e1f82b4add3ceba..482dac701f340373071b3233c64fc762b732ed60 100644 --- a/xen/arch/arm/acpi/lib.c +++ b/xen/arch/arm/acpi/lib.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/arm32/insn.c b/xen/arch/arm/arm32/insn.c index 49953a042aee62a56e6785ed030ece3848701169..b8ea6005419221f2333746ddbbaf8fb2d257c308 100644 --- a/xen/arch/arm/arm32/insn.c +++ b/xen/arch/arm/arm32/insn.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include #include diff --git a/xen/arch/arm/arm32/lib/bitops.c b/xen/arch/arm/arm32/lib/bitops.c index ceddd76d1b008e3c9f712fdf686fca979401eb51..6df685a0e910e29d1f2b64ca6eaa445325959fa6 100644 --- a/xen/arch/arm/arm32/lib/bitops.c +++ b/xen/arch/arm/arm32/lib/bitops.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/lib1funcs.S index f1278bd6c1399414b4fc28fd3c7d93b5db6156a4..8b766baa00437ff9bcf35490f3a1af09d2274e39 100644 --- a/xen/arch/arm/arm32/lib/lib1funcs.S +++ b/xen/arch/arm/arm32/lib/lib1funcs.S @@ -28,7 +28,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License -along with this program; see the file COPYING. If not, see . */ +along with this program; see the file COPYING. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm32/lib/lshrdi3.S b/xen/arch/arm/arm32/lib/lshrdi3.S index 88b9655282abde3598fc2396da24877c450d821b..e1470e657022dfa05e2e230f9da75cc38ca03605 100644 --- a/xen/arch/arm/arm32/lib/lshrdi3.S +++ b/xen/arch/arm/arm32/lib/lshrdi3.S @@ -21,7 +21,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License -along with this program; see the file COPYING. If not, see . */ +along with this program; see the file COPYING. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/bpi.S b/xen/arch/arm/arm64/bpi.S index 4e638252204893ce8fe38b81c45639d256f29be2..79831dc026243e1b5fd8e1af87a46b9eee4c02c7 100644 --- a/xen/arch/arm/arm64/bpi.S +++ b/xen/arch/arm/arm64/bpi.S @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/cache.S b/xen/arch/arm/arm64/cache.S index 9a88a2b49731f2196cae99112bc3b5b33548c179..01f514c169251e9d58fa0b71a23ffb1ce425d135 100644 --- a/xen/arch/arm/arm64/cache.S +++ b/xen/arch/arm/arm64/cache.S @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/debug-meson.inc b/xen/arch/arm/arm64/debug-meson.inc index e65e1ccde4823521b275de7f133c2db12fbde693..67e91fee21d61f712ed9d13efb30e2d3d124eaeb 100644 --- a/xen/arch/arm/arm64/debug-meson.inc +++ b/xen/arch/arm/arm64/debug-meson.inc @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define AML_UART_WFIFO_REG 0x00 diff --git a/xen/arch/arm/arm64/debug-mvebu.inc b/xen/arch/arm/arm64/debug-mvebu.inc index 63b12dc3d37bb429a1eda25731b75b8126d0c279..72edc5e23ce721e74d686da90a4da21246c0eb0e 100644 --- a/xen/arch/arm/arm64/debug-mvebu.inc +++ b/xen/arch/arm/arm64/debug-mvebu.inc @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #define UART_STATUS_REG 0x0c diff --git a/xen/arch/arm/arm64/insn.c b/xen/arch/arm/arm64/insn.c index 22f2bdebd544f7e5f789361844bf14e73f15c604..2f55c243f3b67e19ee201d73ee0dbf4047c33745 100644 --- a/xen/arch/arm/arm64/insn.c +++ b/xen/arch/arm/arm64/insn.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include #include diff --git a/xen/arch/arm/arm64/lib/bitops.c b/xen/arch/arm/arm64/lib/bitops.c index 20e3f3d6ceafc0f66310d6dccab1c78e3afd8702..6b638b7632d1dad5f2594d5acd46bf6e1b4d7a41 100644 --- a/xen/arch/arm/arm64/lib/bitops.c +++ b/xen/arch/arm/arm64/lib/bitops.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/clear_page.S b/xen/arch/arm/arm64/lib/clear_page.S index a767e63686d872210ca4f7c0aa3400868ec6f67d..2185c0987e1c630d5eed09344b2e88d8df0833a1 100644 --- a/xen/arch/arm/arm64/lib/clear_page.S +++ b/xen/arch/arm/arm64/lib/clear_page.S @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memchr.S b/xen/arch/arm/arm64/lib/memchr.S index 81f113bb1cabbc240d3b04fa427f37bb4dc86531..0becb12666288bd9cab299ec4590b5f70873752e 100644 --- a/xen/arch/arm/arm64/lib/memchr.S +++ b/xen/arch/arm/arm64/lib/memchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/memcmp.S b/xen/arch/arm/arm64/lib/memcmp.S index afa73bd7ef264a5a68c0bd01d052f82d216ba690..57bb7b8a6060080636442be7b3f10f725e3ca6f6 100644 --- a/xen/arch/arm/arm64/lib/memcmp.S +++ b/xen/arch/arm/arm64/lib/memcmp.S @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/memcpy.S b/xen/arch/arm/arm64/lib/memcpy.S index e7a667c2be280d9a5a4b8d991cbbf645ace5374e..b6bd157ca4da645f4df5b0b3fc0d55fdeebf1681 100644 --- a/xen/arch/arm/arm64/lib/memcpy.S +++ b/xen/arch/arm/arm64/lib/memcpy.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memmove.S b/xen/arch/arm/arm64/lib/memmove.S index 35d9b62fa0bb2430f65def7b0c0fc8e6cb04dec3..00e790e5c03d5f985bd7272c717a5ceac5a3fb08 100644 --- a/xen/arch/arm/arm64/lib/memmove.S +++ b/xen/arch/arm/arm64/lib/memmove.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/memset.S b/xen/arch/arm/arm64/lib/memset.S index 5ce1db2e76e4a06bb51e8b5acc9f3ae0cb9313c4..d4c906ec409fb039c68129c7fab3b04c45f87961 100644 --- a/xen/arch/arm/arm64/lib/memset.S +++ b/xen/arch/arm/arm64/lib/memset.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/arm64/lib/strchr.S b/xen/arch/arm/arm64/lib/strchr.S index 0506b0ff7f3aef45d2ef9932d071a7100253b5f4..e3fd8a263cec7d9ea1de5227891bffa4f070e759 100644 --- a/xen/arch/arm/arm64/lib/strchr.S +++ b/xen/arch/arm/arm64/lib/strchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strcmp.S b/xen/arch/arm/arm64/lib/strcmp.S index 5492a8482fa59e0463042f2deb4ef3ca515f24d5..793da9658b64b343b962b9ea47ecc51b317d4eae 100644 --- a/xen/arch/arm/arm64/lib/strcmp.S +++ b/xen/arch/arm/arm64/lib/strcmp.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/strlen.S b/xen/arch/arm/arm64/lib/strlen.S index d8d513d18f87d5ff36539dfd6f85dece8ba9ec66..439d4c0c9f5caf2fde899c8c1844b2b82bb84b7a 100644 --- a/xen/arch/arm/arm64/lib/strlen.S +++ b/xen/arch/arm/arm64/lib/strlen.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include "assembler.h" diff --git a/xen/arch/arm/arm64/lib/strncmp.S b/xen/arch/arm/arm64/lib/strncmp.S index 90d3eb67055577f3d4514221d48ab69edcda202d..71c6a6404b1480c912b136bf072033c01a617851 100644 --- a/xen/arch/arm/arm64/lib/strncmp.S +++ b/xen/arch/arm/arm64/lib/strncmp.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strnlen.S b/xen/arch/arm/arm64/lib/strnlen.S index 9e2683790b1f33d3d12ec03f758c2c8a62f0baf1..4ad5c9a954e9bd969a9b3c328ff588d59b274702 100644 --- a/xen/arch/arm/arm64/lib/strnlen.S +++ b/xen/arch/arm/arm64/lib/strnlen.S @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ diff --git a/xen/arch/arm/arm64/lib/strrchr.S b/xen/arch/arm/arm64/lib/strrchr.S index 07059983f828cdbe0b29cd615987172c8336fa8d..19118c6b9844a6e4613b1e5a6724a944c95a55dc 100644 --- a/xen/arch/arm/arm64/lib/strrchr.S +++ b/xen/arch/arm/arm64/lib/strrchr.S @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ /* diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c index aae0f979112ae8cd81d0dfd9785f14fa814aa411..fb75d7db75cf5c619087377961036a0a61112e8e 100644 --- a/xen/arch/arm/efi/efi-dom0.c +++ b/xen/arch/arm/efi/efi-dom0.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/include/asm/acpi.h b/xen/arch/arm/include/asm/acpi.h index e53973e0542b6aa7d8a32c325c47f343e2c4438b..3b61a82c31c297c08d0bb2f5221e8dba32fee3e0 100644 --- a/xen/arch/arm/include/asm/acpi.h +++ b/xen/arch/arm/include/asm/acpi.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/arm/include/asm/altp2m.h b/xen/arch/arm/include/asm/altp2m.h index df50cb2f0988f344a5e1bf065157a0a98ece4db6..ed325988130686a7808b242edf162b3afbfaa517 100644 --- a/xen/arch/arm/include/asm/altp2m.h +++ b/xen/arch/arm/include/asm/altp2m.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_ALTP2M_H diff --git a/xen/arch/arm/include/asm/arm32/insn.h b/xen/arch/arm/include/asm/arm32/insn.h index c800cbfff544f5240a80e2635caf6ca742562784..48ee26fa02c8d7428b53e6ed66c5952431760afe 100644 --- a/xen/arch/arm/include/asm/arm32/insn.h +++ b/xen/arch/arm/include/asm/arm32/insn.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM32_INSN #define __ARCH_ARM_ARM32_INSN diff --git a/xen/arch/arm/include/asm/arm64/atomic.h b/xen/arch/arm/include/asm/arm64/atomic.h index 2d425678660b90f2417317bc66c16691b5679c12..fbc4bff39d15d3428b6d5c35e3484231aeeed7e9 100644 --- a/xen/arch/arm/include/asm/arm64/atomic.h +++ b/xen/arch/arm/include/asm/arm64/atomic.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM64_ATOMIC #define __ARCH_ARM_ARM64_ATOMIC diff --git a/xen/arch/arm/include/asm/arm64/insn.h b/xen/arch/arm/include/asm/arm64/insn.h index 4e0d364d412869615bb02a42a841db2eb717989b..44eb394b07b36ccbdbeaa6a0f031b0c73d262612 100644 --- a/xen/arch/arm/include/asm/arm64/insn.h +++ b/xen/arch/arm/include/asm/arm64/insn.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARCH_ARM_ARM64_INSN #define __ARCH_ARM_ARM64_INSN diff --git a/xen/arch/arm/include/asm/arm64/io.h b/xen/arch/arm/include/asm/arm64/io.h index 2e2ab24f7838b56c9fb9968f0a98f1e7a1c8e6b4..4f98dbbdfe4929f40c6c4409311f4a6d76d92ea7 100644 --- a/xen/arch/arm/include/asm/arm64/io.h +++ b/xen/arch/arm/include/asm/arm64/io.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef _ARM_ARM64_IO_H #define _ARM_ARM64_IO_H diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h index fae3f6ecefe99fe7841d1d1fef5b9cd6571f8634..7f2d125288167cfb923b24124ad13ff647623179 100644 --- a/xen/arch/arm/include/asm/gic_v3_its.h +++ b/xen/arch/arm/include/asm/gic_v3_its.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_ARM_ITS_H__ diff --git a/xen/arch/arm/include/asm/iommu.h b/xen/arch/arm/include/asm/iommu.h index d57bd8a38ccd4b042e6a72d54bf326ebed411af9..c12a45e5c6a177b5e2da4006ab49836f000921e8 100644 --- a/xen/arch/arm/include/asm/iommu.h +++ b/xen/arch/arm/include/asm/iommu.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ARCH_ARM_IOMMU_H__ #define __ARCH_ARM_IOMMU_H__ diff --git a/xen/arch/arm/include/asm/iommu_fwspec.h b/xen/arch/arm/include/asm/iommu_fwspec.h index 5cdb53f8e84bd09b22bc03be9e4481717a5e715a..0cabb191c4da18e91ef8c3bdcfc6f981a201ac8c 100644 --- a/xen/arch/arm/include/asm/iommu_fwspec.h +++ b/xen/arch/arm/include/asm/iommu_fwspec.h @@ -21,7 +21,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ARCH_ARM_IOMMU_FWSPEC_H__ diff --git a/xen/arch/arm/include/asm/ioreq.h b/xen/arch/arm/include/asm/ioreq.h index 50185978d51621ec9978aef89f92226891433a88..fd1e775d10d9aa8e0bf16a3dd918dd36aaf38c04 100644 --- a/xen/arch/arm/include/asm/ioreq.h +++ b/xen/arch/arm/include/asm/ioreq.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_IOREQ_H__ diff --git a/xen/arch/arm/include/asm/mem_access.h b/xen/arch/arm/include/asm/mem_access.h index 35ed0ad15471c3a4e2eddc5810668c3ef152619b..7920f856822415149ed0cabc0aa919fed3ba81e7 100644 --- a/xen/arch/arm/include/asm/mem_access.h +++ b/xen/arch/arm/include/asm/mem_access.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _ASM_ARM_MEM_ACCESS_H diff --git a/xen/arch/arm/include/asm/monitor.h b/xen/arch/arm/include/asm/monitor.h index 7567be66bdc5b314943caaba73d9f891bafab43c..01619b6eefebc3a08f555ff37fe58417a87be379 100644 --- a/xen/arch/arm/include/asm/monitor.h +++ b/xen/arch/arm/include/asm/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ASM_ARM_MONITOR_H__ diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm/new_vgic.h index b7fa9ab11a0bb991cd475c6dadff650a73a4af4b..bac6f778dcdfae836cde88c39ef065cd8fd19fcd 100644 --- a/xen/arch/arm/include/asm/new_vgic.h +++ b/xen/arch/arm/include/asm/new_vgic.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ASM_ARM_NEW_VGIC_H #define __ASM_ARM_NEW_VGIC_H diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h index 8cb46f6b718597a8b620bb02e2097579d7e00f35..7c1f75970c474a3cb2724c3b66d03ce2d9e44c3a 100644 --- a/xen/arch/arm/include/asm/pci.h +++ b/xen/arch/arm/include/asm/pci.h @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __ARM_PCI_H__ diff --git a/xen/arch/arm/include/asm/vm_event.h b/xen/arch/arm/include/asm/vm_event.h index abe7db1970cab6e102ae670f6ea15d7ddd7023e1..1cfcc46f1410a44ce13411a59a937d4d985e7dd8 100644 --- a/xen/arch/arm/include/asm/vm_event.h +++ b/xen/arch/arm/include/asm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_ARM_VM_EVENT_H__ diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/vpl011.h index c09abcd7a9b3356d0809743517934adae00087f5..61d66ed2f62827f47228ef57ed4fb886f662d7d7 100644 --- a/xen/arch/arm/include/asm/vpl011.h +++ b/xen/arch/arm/include/asm/vpl011.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _VPL011_H_ diff --git a/xen/arch/arm/include/asm/vpsci.h b/xen/arch/arm/include/asm/vpsci.h index 0cca5e6830b8c72963aa5607a38c0a09ae224aad..1b3546739242f738939b83482cbbd0386cceb997 100644 --- a/xen/arch/arm/include/asm/vpsci.h +++ b/xen/arch/arm/include/asm/vpsci.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_VPSCI_H__ diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c index 3987f96b01783e0d96b5c2b729bbea72bae0c57e..da1d19a9d8d2807f723af352c5adace68f25795a 100644 --- a/xen/arch/arm/pci/ecam.c +++ b/xen/arch/arm/pci/ecam.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index 9f9aac43d7e9b30e01b1afe1ecf37101981582bc..8a3a476eae2172d61cf13a5d56bf229bfac85761 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a8ece94303ca8070e8a6c2d5bc326ed4ae11d22a..e603dcf3d03f1d575078099ff4a80069cfaaf6ec 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c index 46de6e43cc722adda4a20aa9e1cead2a528ddca3..ab262f0f7678c73cc03a181d3904e9074732da67 100644 --- a/xen/arch/arm/pci/pci-host-generic.c +++ b/xen/arch/arm/pci/pci-host-generic.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c index 101edb8593c1e9b3647b00aaccf1b44c56ebb2f1..1d63769bace8520bcd995ac37fb094628f505c9f 100644 --- a/xen/arch/arm/pci/pci-host-zynqmp.c +++ b/xen/arch/arm/pci/pci-host-zynqmp.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c index 78b97beaef12e85771602af4b296e075596affb7..1cc61272e02a32bc3f541aa80dacf5d42922a6b0 100644 --- a/xen/arch/arm/pci/pci.c +++ b/xen/arch/arm/pci/pci.c @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/platforms/thunderx.c b/xen/arch/arm/platforms/thunderx.c index 9b32a29c6b05eff94847189c1de7b69609720a9f..f46f3344294123091bb7d857a480dd385e2f38d5 100644 --- a/xen/arch/arm/platforms/thunderx.c +++ b/xen/arch/arm/platforms/thunderx.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic-init.c b/xen/arch/arm/vgic/vgic-init.c index 62ae5536997be5d0be7eae2cbc9e89be63d81185..dfbe1b03f1c1cd1bfd8aeeff3d0a602a1843d6da 100644 --- a/xen/arch/arm/vgic/vgic-init.c +++ b/xen/arch/arm/vgic/vgic-init.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic-mmio.h b/xen/arch/arm/vgic/vgic-mmio.h index 3566cf237cee2c15bde3fb32e9a3b12c98cb1e1d..2203f87dd835271b6671cb2503100853267621cc 100644 --- a/xen/arch/arm/vgic/vgic-mmio.h +++ b/xen/arch/arm/vgic/vgic-mmio.h @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __XEN_ARM_VGIC_VGIC_MMIO_H__ #define __XEN_ARM_VGIC_VGIC_MMIO_H__ diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c index 1a99d3a8b48446cbd031e325c941580e8a9ec7a8..11efab7b3e074b375177dbfc63e4c051d1bf2681 100644 --- a/xen/arch/arm/vgic/vgic-v2.c +++ b/xen/arch/arm/vgic/vgic-v2.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index f0f2ea502195901d6c9654f00ae9e330eff95215..b4a177106dc497642d780b91ca99f82b2cc51481 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #include diff --git a/xen/arch/arm/vgic/vgic.h b/xen/arch/arm/vgic/vgic.h index 534b24bcd3f431a389cb866747535929e5622a8b..c2a1bef3dd9d0ac997205270401e978917133c71 100644 --- a/xen/arch/arm/vgic/vgic.h +++ b/xen/arch/arm/vgic/vgic.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . */ #ifndef __XEN_ARM_VGIC_VGIC_H__ #define __XEN_ARM_VGIC_VGIC_H__ diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 54b72d716beda91bfee09b62e6e7e8ba12ece5c8..4e04bf4d6177c455959cc89f535cb0e054f0685b 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c index 427c8c89c5c438d610de3470f0daf1840c7cb0ee..ec879af0c10452a5159a0a9379dd816c650f1cd6 100644 --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -25,7 +25,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index c27cbb2304f27dbb0dbde0b74322a006d860dccc..c21794715cebef404ba9da17692bf6bffabbc49b 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -22,7 +22,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c index d4c7dcd5d99d239462ba6c523a94ee8e970ba141..3fb3e1a5faf6fa937086606957042728083d5364 100644 --- a/xen/arch/x86/acpi/cpufreq/powernow.c +++ b/xen/arch/x86/acpi/cpufreq/powernow.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/cpuidle_menu.c b/xen/arch/x86/acpi/cpuidle_menu.c index a275436d799c9440f3895d00cbf9bec48ce15b9d..66d95fc1450a0e2d11d70ceb76bb594db5738e9b 100644 --- a/xen/arch/x86/acpi/cpuidle_menu.c +++ b/xen/arch/x86/acpi/cpuidle_menu.c @@ -18,7 +18,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c index 43831b92d1322ba4cc3c65ceebc7e88bcfefe484..895b52c3ab1f9e325b594199c49d7e45e6e38382 100644 --- a/xen/arch/x86/acpi/lib.c +++ b/xen/arch/x86/acpi/lib.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 0c6fc7b4fb0cb3d961f020dade3e3d42fede5c40..f715bcf1575c2d1ec7860481cdabd57257787de7 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/boot/build32.lds b/xen/arch/x86/boot/build32.lds index 56edaa727be77424d09f0e525be76f7c7b0403c2..a00183a28b8c63d9a523e5d5f79a0f58303072cd 100644 --- a/xen/arch/x86/boot/build32.lds +++ b/xen/arch/x86/boot/build32.lds @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . */ ENTRY(_start) diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c index fc11c6d3c5c45fc8cdcd51ddd12923bfee3c0447..ffd5d060686e2b01ea74ea0418ac7f01e86feae2 100644 --- a/xen/arch/x86/boot/cmdline.c +++ b/xen/arch/x86/boot/cmdline.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . * * strlen(), strncmp(), strchr(), strspn() and strcspn() were copied from * Linux kernel source (linux/lib/string.c). diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec69636525e3a028058328d1dca2f324..95cfb053b7a827308680884331315c927a7b67b4 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program. If not, see . + * with this program. If not, see . * * max() was copied from xen/xen/include/xen/kernel.h. */ diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c index be44d7f611b1c06ce00dd5ff73c696b3d616ccd1..c9d124ec9901f5eff26e4c68cb5abb4b8fa6203a 100644 --- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c +++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/arch/x86/cpu/mcheck/mce-apei.c b/xen/arch/x86/cpu/mcheck/mce-apei.c index 53b6735896bf105e22f38400f8a02e1ed422a5a2..1e21265fd510b647be80dc56090ddf1711c6d2fc 100644 --- a/xen/arch/x86/cpu/mcheck/mce-apei.c +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c @@ -25,7 +25,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index 98c630fc86295ca38e248f9db8329e2a15794bda..b695f142375059a920d4e9e6bcf24d72519c2d65 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* K8 common MCA documentation published at diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c index af30811afd445fe38d629f5fa220a868861cf6a6..a8d3aa68ae7beef9fb6ced8c1729883f69f07cad 100644 --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/cpu/mcheck/x86_mca.h b/xen/arch/x86/cpu/mcheck/x86_mca.h index 8f7fced0fee057326ef7d87699b1b5ab9d5fb170..420dabf288f3a6bef73b5473a822f50f46cd7b62 100644 --- a/xen/arch/x86/cpu/mcheck/x86_mca.h +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef X86_MCA_H diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c index 2946003b84938f3b83c98b62dfaa3ace90822983..88ee0f8444227287b57ba8018e4343720a555346 100644 --- a/xen/arch/x86/cpu/mtrr/main.c +++ b/xen/arch/x86/cpu/mtrr/main.c @@ -14,7 +14,7 @@ Library General Public License for more details. You should have received a copy of the GNU Library General Public - License along with this library; If not, see . + License along with this library; If not, see . Richard Gooch may be reached by email at rgooch@atnf.csiro.au The postal address is: diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c index 9e981e7e26dceff1a75c76b073a59a3fc0dcc800..78d2e7bb65911b78f0792c9bbc0b0b02f26199ed 100644 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ /* diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index b6b7342fb466e4ad2240516c0c3afc21472566e7..9b85e443ebf83bd73f31f41aaa32c8248aa577cc 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 58794a16f06cd4041935922a51eb813a364a5d14..112409cbcc898f04dc83017616bcbbab0feae1ec 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index a8df52579db8e455b24f2f4a89367cbfe81d77ab..f3f855e7c3e90e40f7ba77a90aaf309b80c85487 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c index 961cae0be74f5514eb2f05536727786a74f9e250..6a7ad0f5578d11af14dda92d07d7a82ad0313c2c 100644 --- a/xen/arch/x86/gdbstub.c +++ b/xen/arch/x86/gdbstub.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include #include diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c index 6ef46e8ea77d8de3178ff50340bdf4fa2d0b9d95..e7b20a7202a1133ea14be39aab0538465e2748e3 100644 --- a/xen/arch/x86/gdbsx.c +++ b/xen/arch/x86/gdbsx.c @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c index f73390cdb017caae149d2e1057723958a66ee7ae..36a30ec43e86b59c2135d1c4bdb2938038f51370 100644 --- a/xen/arch/x86/genapic/x2apic.c +++ b/xen/arch/x86/genapic/x2apic.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c index b101ba3080b44a95cadd893c521454eb321572e6..f28df2cb45f8f67f3a16157345edd9051f9e79b0 100644 --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/private.h b/xen/arch/x86/guest/hyperv/private.h index fea3e291e944ef8d22de7c8da7dd4f488167c428..a33e2501ff53ed9042a64a23a33431ea1125cbeb 100644 --- a/xen/arch/x86/guest/hyperv/private.h +++ b/xen/arch/x86/guest/hyperv/private.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/tlb.c b/xen/arch/x86/guest/hyperv/tlb.c index f249b259253daaa747dee5989d9f7d85a3be3846..986b8083cfae508cf27a4c886138a693892036b2 100644 --- a/xen/arch/x86/guest/hyperv/tlb.c +++ b/xen/arch/x86/guest/hyperv/tlb.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/util.c b/xen/arch/x86/guest/hyperv/util.c index 2c5f421b7bd9a5039ba59653a09b1e06700b2a3d..2db9b68136b31d5b3aef2467450c44cab5929217 100644 --- a/xen/arch/x86/guest/hyperv/util.c +++ b/xen/arch/x86/guest/hyperv/util.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c index 366af1d6500104dd97ca592c1a5a6d58bb4296f7..b4e01a25018513585fbc73bd04364bc1e85d920c 100644 --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 498625eae0a3f065c41366aa8b51c2e571c6ca63..45af2a7caa3066ad8805e1fed409f40c931e18ca 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index 9c2defaa6621864e359ea45e554ae8322c1d4610..417cd713ec29a4161c4b7d50fb473a139d6cadf5 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/hvm/asid.c b/xen/arch/x86/hvm/asid.c index 1fd2770a3ae062031687b4d9b0d38f9516f5b0d2..b4ea2d90c030b6fd6dcc33cac1518aec0d5f96fa 100644 --- a/xen/arch/x86/hvm/asid.c +++ b/xen/arch/x86/hvm/asid.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index f8e6089870b01b45fb88739658b17fae92b687ec..fd66243984cbe955eecfa7cdbd3a79d069b30294 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 3ac6b7b423b10fae313950a1d443e6e2fb42ad39..8d7cfc074f6b25496a6b99baf685c6b5e816b970 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c index 10e30175a1b6865d4924d08e5baf357794342cb7..82308a5cdb91f2a854fbd9a21e098246641e5072 100644 --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/grant_table.c b/xen/arch/x86/hvm/grant_table.c index b7a896ea5855f4ae1c99e26b204b69a610ee2338..fa23d5ad83257493783fde4c916c7b5d4be7a654 100644 --- a/xen/arch/x86/hvm/grant_table.c +++ b/xen/arch/x86/hvm/grant_table.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index c65e1b27d09ea5931fc13919697de088c1b9a8fe..60be48f6cf6347c5a8b51590b9397214a0621c90 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5c1e64189600df7d5c700ea500cf4afce12391ca..9339fc94bec0354eaff1b79b391d6139faf8a02d 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c index 405d0a95afd8ef77d298f3d4dd261ba3cd3f7920..2fef069930318ddc4aa50e7baab9332d67a1ea97 100644 --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c index ffa31b7467161054c7b8b0f156d088f51c642f6e..e028f96b6ee46d3834b8803d81718eeed2115e4e 100644 --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 5ae209d3b6b3a5453290320d83bc09a9a3c6c8cd..9f16521c4449a3240e18638fca1cb2a96528e76c 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 0bdcca1e1a5f68d213cb9a73637df4610c8d68aa..67427efe4dd9de2c2397358a6009dc0428deced8 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 4fe87a71c12b36bd88233c061130105317a1654c..2ceed080e99deff38806c416ffcc0a77064fbd49 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c index a11cd76f4d18003012ae502b0bd0fc6c408fcf9b..ddd83ba6cd8d36ef82c4d1818e21f8c0f94b50e9 100644 --- a/xen/arch/x86/hvm/monitor.c +++ b/xen/arch/x86/hvm/monitor.c @@ -19,7 +19,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 344edc2d6a96e4c9ab2aa68b2f40c51853ca2e6a..23382e936f43178dcb997b4f35c5bd680c0d0985 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c index 58370190ffc91fc9fc277e4f3532e09e4719bbbd..bfbba9df2ac4c63dc8be93296547fad6931e9fe1 100644 --- a/xen/arch/x86/hvm/nestedhvm.c +++ b/xen/arch/x86/hvm/nestedhvm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index b89d0fd53ba16422792af9940a0fa1fac577f772..b4b33747225e6c1a96137493ecb8fd1d4483cd2b 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c index 2adab1f4b84b459c443029d129b69c22f8e6d44b..ef084b1d9659bfaa8e18877b694e1e2fd0673919 100644 --- a/xen/arch/x86/hvm/quirks.c +++ b/xen/arch/x86/hvm/quirks.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index c1675e3d9fb097ec88eda0b333cc6c0f6561d326..d0918b492916bf32de5e9f552d74fd493616da60 100644 --- a/xen/arch/x86/hvm/save.c +++ b/xen/arch/x86/hvm/save.c @@ -17,7 +17,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index ab06dd3f3ae27d0c7f1e42dca429e275aa980032..d18ee50c2d0467bdc8ea018922578e40e1a3a728 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883cff49c1fc335cbfbabc321d371295d..089cd946f55b9e4d3b39f36e1ae3fa45f8650b62 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 981cd82e7c0b2bab093476c38b9e29d7e58a2d3c..6e1ed4a3f8a0740dce835c2fe6d9d09d79779d77 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ .file "svm/entry.S" diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 9525f3559392de8063bca90fd5000db82499ec06..ca4a6ccec0c0ebd954819f2c5183e0d251f24ab7 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 9f5f35f16aff2a11320a3719b0668ab57776b610..8bcfc65dc4f5304d47511c79771fe00dc5e02fc6 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index fa7325720328ba562948c8e921ee2ce8e1bde20f..1713966530d0bb3905e39268f340f05f565258c4 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index bce86f0ef706d5f1baeb21943cf3028d283cd6c5..4de3480737b18a8ee678df936290f87d1ac0e019 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e38726540a637c1a2d7f9f2c6c482e2c..88b5d745c0efde3a21ea6755905214583a9d0d4b 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c index 41e3c4d5e42de151a3fb49bc93e4429e37be604a..d3b7d9fdfa5a07bd5d8124db3dff7c650598de7d 100644 --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Yunhong Jiang * Ported to xen by using virtual IRQ line. diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d149c1a23ed8e8495d982a27cc367e6..031c04a61b7de6e09846d143a82dc1bb2b656958 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vm_event.c b/xen/arch/x86/hvm/vm_event.c index 19aac19bc35406675624c0cd7e64f78f10bf8005..867a0eb902148bf069324069e14d97c2ae5b07a1 100644 --- a/xen/arch/x86/hvm/vm_event.c +++ b/xen/arch/x86/hvm/vm_event.c @@ -17,7 +17,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060c85cbd7d339bcdca488cdb143b47ac..34311f17a5de12eeedafaea8403780860533ee07 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . * * Support for virtual MSI logic * Will be merged it with virtual IOAPIC logic, since most is the same diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index 5f5de45a1309c7d667cc6755e7f3da269c3de9a9..3ee68881a0fdbae73981193a69ab1998a61bd857 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ .file "vmx/entry.S" diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e25bc894918da392675076d91ef143b..e5e88f9dbd3d32ba58a5761fe49f71e10c80f7b9 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 09edbd23b3990dd88994f716145da07778f29cd3..edc99e6106d3555c1a9d97870ca4928fb9f78863 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index ade2a25ce7c20bb0220630b7b70ab0a13b1072e8..af76300a4d76ebb7a1d4ec7cd33cc30bf3ffa629 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb073672e371e1546efc9f573087bfe435..50779030b4c55a73376c2d24017bf02d716cbc0c 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 621f5bb88b63850a4f4acbd39c5a66f7fe421568..05b1c37ca244aec58b04e39135d0bf4ad54dfbd7 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c index 6b73cff9b9ff3fb271836b97aac28f0fa9d389c9..b087621726720bc66171163144c0c62ced582100 100644 --- a/xen/arch/x86/hypercall.c +++ b/xen/arch/x86/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2015,2016 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 6ce79ce465b45b336138786a4fa8694e2c029b44..52bf6423b905e5e36714efe1b582e72463d372d4 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/include/asm/altp2m.h b/xen/arch/x86/include/asm/altp2m.h index b206e95863a63d35324778695300f668a1050327..d5914d6a96f1d060d77d8bf28d1d640225296beb 100644 --- a/xen/arch/x86/include/asm/altp2m.h +++ b/xen/arch/x86/include/asm/altp2m.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_ALTP2M_H diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h index d946fac131306049b44d8e52f2a0f9cf1bb3c5f4..46f02fd0812ca6dc85e8cda717194b2e0509c93f 100644 --- a/xen/arch/x86/include/asm/endbr.h +++ b/xen/arch/x86/include/asm/endbr.h @@ -10,7 +10,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2021-2022 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest.h b/xen/arch/x86/include/asm/guest.h index ccf1ffbb729af6aeb4dc8259ab26dd610ade69a1..9aa3edcca571ae4ae275715db44cf2dd62e9a78c 100644 --- a/xen/arch/x86/include/asm/guest.h +++ b/xen/arch/x86/include/asm/guest.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv-hcall.h b/xen/arch/x86/include/asm/guest/hyperv-hcall.h index 423ca0860b5d517a48b81a86240b898a31f913f1..fb2ab0e341f51dd1974f66d7959bc383d366a8d0 100644 --- a/xen/arch/x86/include/asm/guest/hyperv-hcall.h +++ b/xen/arch/x86/include/asm/guest/hyperv-hcall.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv.h b/xen/arch/x86/include/asm/guest/hyperv.h index 1a1b47831c8d602f568636053a69da0ab863f4ba..783baced2f5177f16c7875896b15e1d7a2f34abb 100644 --- a/xen/arch/x86/include/asm/guest/hyperv.h +++ b/xen/arch/x86/include/asm/guest/hyperv.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h index 0a6c3b47ab36cb4a1f6dffdef1e7535c96c49638..e966926a934ec31c3bfdd715ba505a058abcc35c 100644 --- a/xen/arch/x86/include/asm/guest/hypervisor.h +++ b/xen/arch/x86/include/asm/guest/hypervisor.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 48ffd1a0b1b40a8729e4cea9f045af978567173c..bedf8ba86779cd4c087549503feae4b081f8cd2d 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen-hcall.h b/xen/arch/x86/include/asm/guest/xen-hcall.h index 03d5868a9efd698353d22578abc19c503fa84038..f6f0d576d3629df8e6e7475dca3ad2d51f8505b2 100644 --- a/xen/arch/x86/include/asm/guest/xen-hcall.h +++ b/xen/arch/x86/include/asm/guest/xen-hcall.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen.h b/xen/arch/x86/include/asm/guest/xen.h index 2042a9a0c2537bcacfe781e8bad0cb42cf069dfa..ea46d83de7865825272aab1d322ad7ec49989211 100644 --- a/xen/arch/x86/include/asm/guest/xen.h +++ b/xen/arch/x86/include/asm/guest/xen.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index 6802db2a415a9c3aa0faf55f8e5ee97c83cdc4f9..15c2d9383fa542f886b32b1fc82fa0ad9a0256dd 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -22,7 +22,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_ASM_GUEST_PT_H diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 90dece29decad0dba7f7682a498493a06baa904f..9d7e2bbaf020ec76cb2b58c076f22dea9c513d82 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_HAP_H diff --git a/xen/arch/x86/include/asm/hvm/asid.h b/xen/arch/x86/include/asm/hvm/asid.h index 633ddb72e494a85e42200298db4cda585d3a374a..f1e5525c8301f215709300d43c4dea8007041b6b 100644 --- a/xen/arch/x86/include/asm/hvm/asid.h +++ b/xen/arch/x86/include/asm/hvm/asid.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444ea85b691126c3e8a31c08bbd48acb25..c5152049ed30799e1dffa4a309058cab180b2dcb 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/hvm/grant_table.h b/xen/arch/x86/include/asm/hvm/grant_table.h index a5612585b35e520a87f0566a1f49d4574a34681f..342631b170c7cfc0ae452c93d8a3b5b7f2b3928b 100644 --- a/xen/arch/x86/include/asm/hvm/grant_table.h +++ b/xen/arch/x86/include/asm/hvm/grant_table.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_HVM_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 65768c797ea7547f50962af5b1a379a8c275a47c..d92ecbdc7c805bc37ffd33c60f18292f43885596 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_HVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h index 54e0161b492c3714f13112e0ebffa91dbc9e0229..3253c68a82a787c8ad3748c42551d6f26f2c559b 100644 --- a/xen/arch/x86/include/asm/hvm/io.h +++ b/xen/arch/x86/include/asm/hvm/io.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IO_H__ diff --git a/xen/arch/x86/include/asm/hvm/ioreq.h b/xen/arch/x86/include/asm/hvm/ioreq.h index 9b2eb6fedf99bafd52c1395dca6887d4107460ae..9bd11077393cff0390130321db369adc529d52e8 100644 --- a/xen/arch/x86/include/asm/hvm/ioreq.h +++ b/xen/arch/x86/include/asm/hvm/ioreq.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/irq.h b/xen/arch/x86/include/asm/hvm/irq.h index c4369ceb7aaaf5f3e50af0913ee8b78b81501d3a..fde58a7734a3d04bc7a6de63b40f539d94ca7e2b 100644 --- a/xen/arch/x86/include/asm/hvm/irq.h +++ b/xen/arch/x86/include/asm/hvm/irq.h @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_IRQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h index 639f6dfa374cf18b9f9088bd45007c1962eb452f..61358dcc055dbf9746f759db29d812eeb3f1f241 100644 --- a/xen/arch/x86/include/asm/hvm/monitor.h +++ b/xen/arch/x86/include/asm/hvm/monitor.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_MONITOR_H__ diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h index 7184928c2bb179a424554cdab534f0373305a9a9..0b179f58192e5025e2f47e1824b6a058ac1100be 100644 --- a/xen/arch/x86/include/asm/hvm/nestedhvm.h +++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _HVM_NESTEDHVM_H diff --git a/xen/arch/x86/include/asm/hvm/save.h b/xen/arch/x86/include/asm/hvm/save.h index e975011ddb7112a2286242468a3df79c6a410d7b..39debb0a764b308c60a476abfeeb8f112282c4c6 100644 --- a/xen/arch/x86/include/asm/hvm/save.h +++ b/xen/arch/x86/include/asm/hvm/save.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_HVM_SAVE_H__ diff --git a/xen/arch/x86/include/asm/hvm/support.h b/xen/arch/x86/include/asm/hvm/support.h index 6b583738ecb5667c8bf3fa3545e0b02cfbec179b..fd2a51c4f6ca25ae0392a80fb2af82e6b5d1e3a9 100644 --- a/xen/arch/x86/include/asm/hvm/support.h +++ b/xen/arch/x86/include/asm/hvm/support.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SUPPORT_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h index 0e5ec3ab788a578121b4c4eb2f88757718bc5991..70acd037b5d235c68737a974b75184e1587a44fc 100644 --- a/xen/arch/x86/include/asm/hvm/svm/asid.h +++ b/xen/arch/x86/include/asm/hvm/svm/asid.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/include/asm/hvm/svm/emulate.h index eb1a8c24af6d23ddb20ab2d346ea8e9165538de0..f1bdeff74fd5ad436766c337d7202602c863a642 100644 --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h +++ b/xen/arch/x86/include/asm/hvm/svm/emulate.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_EMULATE_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/intr.h b/xen/arch/x86/include/asm/hvm/svm/intr.h index ae52d9f948b127c7cff5c27a33f0719be159e297..817e5a713978cfd1a60f7951994f7e207e3a398d 100644 --- a/xen/arch/x86/include/asm/hvm/svm/intr.h +++ b/xen/arch/x86/include/asm/hvm/svm/intr.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 656d7d1a9a71ac5144115523a91204ed9c2729ef..3a5615dbaa205fe94bb462d1abc3df736a56602a 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_SVM_NESTEDSVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59b76bcd412ec409565193501618599b..6ce1f59ca788c8e2aae55eedf6f976f82f5851d5 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h index 330c1d91aad54a2ca47e28a67c44d58c465459ab..d4544c589de8a65141226738b6215cc04f5ea050 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h +++ b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index e87728fa81cd26fe014dd3eb47d622105063760f..ce33d4cc72d9616de774b7bf62f686d494a705ec 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_SVM_VMCB_H__ diff --git a/xen/arch/x86/include/asm/hvm/vcpu.h b/xen/arch/x86/include/asm/hvm/vcpu.h index 8adf4555c2ab491980c0de823d424be15219413c..577ca66752f10ee31f869271b045bf8247df34b9 100644 --- a/xen/arch/x86/include/asm/hvm/vcpu.h +++ b/xen/arch/x86/include/asm/hvm/vcpu.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VCPU_H__ diff --git a/xen/arch/x86/include/asm/hvm/vioapic.h b/xen/arch/x86/include/asm/hvm/vioapic.h index 2944ec20dd53bf90fa9b7776df20e4a5f54af7e9..0c157f828973e99b035472efc7c909f94f42148f 100644 --- a/xen/arch/x86/include/asm/hvm/vioapic.h +++ b/xen/arch/x86/include/asm/hvm/vioapic.h @@ -18,7 +18,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef __ASM_X86_HVM_VIOAPIC_H__ diff --git a/xen/arch/x86/include/asm/hvm/vlapic.h b/xen/arch/x86/include/asm/hvm/vlapic.h index 8f908928c35c824359c0a998133a4675767b32ed..8905858a8fbfed0355974fecc83811920e444b49 100644 --- a/xen/arch/x86/include/asm/hvm/vlapic.h +++ b/xen/arch/x86/include/asm/hvm/vlapic.h @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VLAPIC_H__ diff --git a/xen/arch/x86/include/asm/hvm/vm_event.h b/xen/arch/x86/include/asm/hvm/vm_event.h index 28cb07ce8ff608212ccacd3140cf1b9423cadceb..714b8dd38984fd303660f4f504641a5bccdfc9eb 100644 --- a/xen/arch/x86/include/asm/hvm/vm_event.h +++ b/xen/arch/x86/include/asm/hvm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e744780543e3350694d376644c06af88b7d0..dc316cdf89b74e0616feb433ecb4e34acad4468f 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VMX_VMCS_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f4459b70d9f14d9e8267af3902e49339..9d33e6e200de018080c588c72cce3268b0ccfaed 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VMX_VMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h index 2c3adb5dd6b348475875ff2835653f8f4297b56d..7d1c415ec17a1153c8c33f5744a199969fa04e5a 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __ASM_X86_HVM_VVMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h index 74c0cedd11cce8567c12aef946ef4fad4c5a647f..193e0d01cd6c00cc1f8bc2037d7bd9a77c9f7adf 100644 --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_HVM_VPT_H__ diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h index fc0afe35bf6b9160f3514797e1d8c8203fd74230..bc43c3a35993cd7771f7360c88943a10ed976529 100644 --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ARCH_X86_IOMMU_H__ #define __ARCH_X86_IOMMU_H__ diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h index d06ce9a6ea56ef4e6528872be2029a3177b8b313..5b659fb345382c4b45e794c8f1ad2a4ba90e4e8d 100644 --- a/xen/arch/x86/include/asm/ioreq.h +++ b/xen/arch/x86/include/asm/ioreq.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h index 18091610aea0439f7ad7bd60b2f205a3404aa99b..615eac2f8c3d72bd9c799e062bfd8f4f379bf84a 100644 --- a/xen/arch/x86/include/asm/mem_access.h +++ b/xen/arch/x86/include/asm/mem_access.h @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_ACCESS_H__ diff --git a/xen/arch/x86/include/asm/mem_paging.h b/xen/arch/x86/include/asm/mem_paging.h index d3635e96cffc0bb18efe2b865b3fee03bf537dad..67ebddbbe33be779a5acc965f1a0648ea228d6f3 100644 --- a/xen/arch/x86/include/asm/mem_paging.h +++ b/xen/arch/x86/include/asm/mem_paging.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_PAGING_H__ diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h index 2c00069bc91ce53b0e04b3eeb89e35c15fcf2676..5ed531af16a14a551a6cc48c1cdc5fa3787e3dde 100644 --- a/xen/arch/x86/include/asm/mem_sharing.h +++ b/xen/arch/x86/include/asm/mem_sharing.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __MEM_SHARING_H__ #define __MEM_SHARING_H__ diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h index d8d54c5f23d691fd1af049680552b11fd7b2267f..11ecd70b41831c1930256feb4a30fdf388814f13 100644 --- a/xen/arch/x86/include/asm/monitor.h +++ b/xen/arch/x86/include/asm/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __ASM_X86_MONITOR_H__ diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h index bd684d02f3676fba3b39b347e27556040fc36aa8..4b71075fe91400ab754cd5038b5ed29e9d05712a 100644 --- a/xen/arch/x86/include/asm/p2m.h +++ b/xen/arch/x86/include/asm/p2m.h @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_ASM_X86_P2M_H diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h index 8c0b0ef29a10d1199ea92c3bc8084a83b18c91e9..480f4aeefef094c02311e2d93a9429511a674ba3 100644 --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_PAGING_H diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h index 924508bbb4f0c199b3cd2306d9d8f0bd0ef399f9..77800439a187b7cc43355b1d445b4f7499854f43 100644 --- a/xen/arch/x86/include/asm/pv/domain.h +++ b/xen/arch/x86/include/asm/pv/domain.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/pv/grant_table.h b/xen/arch/x86/include/asm/pv/grant_table.h index 85442b60749f6b17195eb9925887f9c98ae6a28b..72afc193abd5970b0d72fa317836722f29e630d8 100644 --- a/xen/arch/x86/include/asm/pv/grant_table.h +++ b/xen/arch/x86/include/asm/pv/grant_table.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/pv/mm.h b/xen/arch/x86/include/asm/pv/mm.h index 9983f8257c63fa492120662d10ec192366560216..912b006875aaae76f2872ccddae3c766c1da4ec1 100644 --- a/xen/arch/x86/include/asm/pv/mm.h +++ b/xen/arch/x86/include/asm/pv/mm.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_MM_H__ diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h index a43c3689b48aa85ce6a413a8b5df3d9540475966..22acad0233ccaf9213e47e248064be9bfa8e0444 100644 --- a/xen/arch/x86/include/asm/pv/shim.h +++ b/xen/arch/x86/include/asm/pv/shim.h @@ -11,7 +11,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/pv/traps.h b/xen/arch/x86/include/asm/pv/traps.h index 855203c4e288bd7f1dd12d62dbfcb5379e5b69ca..f64993b2a349a8d403c86df0bbf86835cea2ec53 100644 --- a/xen/arch/x86/include/asm/pv/traps.h +++ b/xen/arch/x86/include/asm/pv/traps.h @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __X86_PV_TRAPS_H__ diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h index 1365fe48051827acc3cac2a9640d4e1b560c5309..d83d705f3aca08a6807c234e65ac690fed506e3b 100644 --- a/xen/arch/x86/include/asm/shadow.h +++ b/xen/arch/x86/include/asm/shadow.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_H diff --git a/xen/arch/x86/include/asm/shstk.h b/xen/arch/x86/include/asm/shstk.h index fdc9cc65a3fa6d673e5a79149a1d451a019d0126..4c580a34976c343826a2c79bedb291a2efee9437 100644 --- a/xen/arch/x86/include/asm/shstk.h +++ b/xen/arch/x86/include/asm/shstk.h @@ -10,7 +10,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2022 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index e928596450f7ba65f6af9c005dbb1a1609dd6c95..b480db11ad5c3a7914020fdb49fc46d613c8af40 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532be63d849f5eb94d47d9cb30bb3b67..18245921c27c7f4618a04ac46fc1c2a0c8dd6467 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/traps.h b/xen/arch/x86/include/asm/traps.h index b0dd2d24614dbead8e51bc0924afbb8cdeabb617..d6cb16541148fe0a7cda26071f31ee376ab768c9 100644 --- a/xen/arch/x86/include/asm/traps.h +++ b/xen/arch/x86/include/asm/traps.h @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef ASM_TRAP_H diff --git a/xen/arch/x86/include/asm/vm_event.h b/xen/arch/x86/include/asm/vm_event.h index 0756124075231d0b7aa9e1a0367b756033750d72..8c98b177a62c5af15fac37af032f8f5f1e3cd51f 100644 --- a/xen/arch/x86/include/asm/vm_event.h +++ b/xen/arch/x86/include/asm/vm_event.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __ASM_X86_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index 05e1fbfccfcf9f592108a8db70f7955e52129cca..ded3cff7fb314499b18461408301152a2f5a2dd9 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Haitao Shan */ diff --git a/xen/arch/x86/include/asm/xenoprof.h b/xen/arch/x86/include/asm/xenoprof.h index cf6af8c5df525c6925df9eeaae4be52738d21fee..bd93ef6e7cccf099d8f4679764340e328d1ca229 100644 --- a/xen/arch/x86/include/asm/xenoprof.h +++ b/xen/arch/x86/include/asm/xenoprof.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __ASM_X86_XENOPROF_H__ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0fe14faa5fa7f4c384b44324c86743e823b53917..409c8b32536666fb51a3474d0ae04e7c6e17ec96 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/mm/altp2m.c b/xen/arch/x86/mm/altp2m.c index 07393befeeed4e9b0230306e60a9167460c511f8..a48cb5567de880e44324f5fd02b8379e7eaf8465 100644 --- a/xen/arch/x86/mm/altp2m.c +++ b/xen/arch/x86/mm/altp2m.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 76b4e0425887ff9f3e932dfd54c9fab70ca4585e..989006cb1b377d8192acfea668e891c126c6eef7 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c index 1da8d3b99edcb81b1eaa46ed2055ddb343209d04..f12467001082fd3922f18338ead92ed10b46d3c4 100644 --- a/xen/arch/x86/mm/hap/guest_walk.c +++ b/xen/arch/x86/mm/hap/guest_walk.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index 84cb358df1231a4b3a93997b9b2281bb2506b3c5..bcfd6e450268b75483206a7536d9b88a008d3b6e 100644 --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c index 605e47c16cd54480fce0a2b3d5251f327e91eec7..9ffad29d346cd09ed38dbfe9dc2d486c582c9519 100644 --- a/xen/arch/x86/mm/hap/nested_ept.c +++ b/xen/arch/x86/mm/hap/nested_ept.c @@ -14,7 +14,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include #include diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c index 098e8e5d4ca9c00de9e9cc870d2573a1b659e670..95d853994037764ecd6fd39d0f2de6f61dd171cb 100644 --- a/xen/arch/x86/mm/hap/nested_hap.c +++ b/xen/arch/x86/mm/hap/nested_hap.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/private.h b/xen/arch/x86/mm/hap/private.h index 1040eaf69f437a90b183c3e8cec683a9659fa028..f60bc084b2fe2ec35200d5b845562b3829e67da8 100644 --- a/xen/arch/x86/mm/hap/private.h +++ b/xen/arch/x86/mm/hap/private.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * */ #ifndef __HAP_PRIVATE_H__ diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index f3aed9fcc966037ebd94451fdc2098cacfbd7e04..07c53bff9566583779291e5a9b5a600161663bab 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include /* copy_from_guest() */ diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c index 01281f786ee05e83d1860340bcf7486f47914d4d..79158a1266090052bbb9fd9d6aa00aa5274a2bcb 100644 --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc54440a15723eb827ba28ae4b4221e877..d3f3d2007502c4480cb5fc4f36e6bff1c618d728 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h index c1523aeccf992db0313f3eadbd050a35222cf1bd..93200149ee739badd6ab5e431036939de7830775 100644 --- a/xen/arch/x86/mm/mm-locks.h +++ b/xen/arch/x86/mm/mm-locks.h @@ -19,7 +19,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _MM_LOCKS_H diff --git a/xen/arch/x86/mm/nested.c b/xen/arch/x86/mm/nested.c index fab62b2b2dc1db8f76f0b2a3cfb16c8f74d81511..56b0017aac0d70b2eca899f2ca7e5e3bda1210d9 100644 --- a/xen/arch/x86/mm/nested.c +++ b/xen/arch/x86/mm/nested.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-basic.c b/xen/arch/x86/mm/p2m-basic.c index 47b780d6d63aeccc699567568ecfd5ebf119caac..56da2cae3db622db050c74cd2e2bab219740f071 100644 --- a/xen/arch/x86/mm/p2m-basic.c +++ b/xen/arch/x86/mm/p2m-basic.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index bb143c6c42c69db4e054b9156aad9a18ea0b2378..6cb7fcfcf0e9236443fa78ee228a44ba638f5667 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index 2edab5e5cd91feb2ade4450a56b95ca3c55ee91b..2444ea5690cbd1ef6073cdf17e46cce6db02b251 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index cd1af33b6772ab1016e8d4c3284a6bc5d282869d..9735cf19ded2e85dd8fe8288852c8a4a3382249d 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -21,7 +21,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index c5561fe22160114d0d18124bd6ff35c3171dd523..a757474fb9577a1982b35166c0e8cfdabbb2039e 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h index cc0f6766e4df2d9db78463e2c2dcf55b26266820..dcbb5d9875b42f0c2b3c05362a0836ddf5c6825e 100644 --- a/xen/arch/x86/mm/p2m.h +++ b/xen/arch/x86/mm/p2m.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ struct p2m_domain *p2m_init_one(struct domain *d); diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 1c5f54f92aefcb79b891c25d8d1e922d8c21c37f..59dabd64065b16cc87d4afa8d97e9ba40df92a65 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/physmap.c b/xen/arch/x86/mm/physmap.c index 2d267b42f73b87554f328eaa69ed5062f7f7a65a..d4cb0317dc4aae8c0fdac763ab734628b82969da 100644 --- a/xen/arch/x86/mm/physmap.c +++ b/xen/arch/x86/mm/physmap.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index a74b15e3e75b6e882709f0ce0e72001f14e8e9d0..69bd2306733eea291f46c787655a9cc967205cdc 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index 88c3c16322f2777231538e382c148af4cb6bc070..a168b6c9d7a52ef5945e8ed22df9387e8cd689d5 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 3b06cfaf9a5aefb4d7678d9a5a5fb5c361d0319c..3567b6457896803a2c61b50ebd1ddd24daea3931 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h index 5bcd6ae1a8da2a77f3640bb69c010181f0624f2e..34e8186718f793c10285681fb57b8ee7583601fa 100644 --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ extern int diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h index 79d82364fc92e650317b8cc68a73c8abe3ae8028..c0954e85d37386c34f155c7531ab0196b909ee3c 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_PRIVATE_H diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c index ed10d5479c5ef09cc1a1dc0447552d47e608c6ca..9235b24a9f0903fe0c5178f3d2e808374079d4dd 100644 --- a/xen/arch/x86/mm/shadow/pv.c +++ b/xen/arch/x86/mm/shadow/pv.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c index bd6c68b547c9b02cf31182e407ab8900de0dc254..2aea9894ed24e1630356c2a7fa5b9e6881e78ac5 100644 --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #define GUEST_PAGING_LEVELS 0 diff --git a/xen/arch/x86/mm/shadow/types.h b/xen/arch/x86/mm/shadow/types.h index fac59522b008d8a7fbcd60d99e585b346dd387a0..f491d80306339f7fe46c0cce38016b65e6dc952d 100644 --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_SHADOW_TYPES_H diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c index 30ca71432c0b822dea660b7ee391b79ed2951f76..db2ea5bd59e30ae46cfdd3b7a8559a0900806710 100644 --- a/xen/arch/x86/monitor.c +++ b/xen/arch/x86/monitor.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 7ddf0078c3a20ac2e4acf1d09292ba8d581aeac4..f5ae1ca82b63f7a9bf111cbad7cb0e2502ad2485 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c index 067ee3b795d0c906702d05ad67e71512396e5b5d..73e99a13f2dc26d8b3e3a5fd6827d8eaf619a3e9 100644 --- a/xen/arch/x86/pv/callback.c +++ b/xen/arch/x86/pv/callback.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descriptor-tables.c index b4135b450cdfb0a5e7b49bcc71f03cb1355ad079..4ac7d6169a31fae87c1c2a49d1049ef6c9a85654 100644 --- a/xen/arch/x86/pv/descriptor-tables.c +++ b/xen/arch/x86/pv/descriptor-tables.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index 758a20ad9df424db9dfeb8ea08707bf6405b97e8..8249f7561ee4c2a2acf3495df548913a3eca5397 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c index 2c07eed9a092df5882161e1a28557e5862c4a5d1..62b7fdefa322c31e674d7bd8263e17c77f0d24c5 100644 --- a/xen/arch/x86/pv/emul-inv-op.c +++ b/xen/arch/x86/pv/emul-inv-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 5da00e24e4ff15a9ef61c10002a3e511fced799c..61994058a8171b7aceb8b0117e67cfc44b5271bd 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 0a7907ec5e846c00df5fc461cbb3948b7efece40..3ac280963c487e0663a6a0818eb764181ff0b00d 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/grant_table.c b/xen/arch/x86/pv/grant_table.c index 81c72e61ed55888308e51e437805e2b91e7bc112..4c4dadd909064bbdd6e77f766ee89a326d784ad6 100644 --- a/xen/arch/x86/pv/grant_table.c +++ b/xen/arch/x86/pv/grant_table.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c index 2eedfbfae86417a48a682b3cc201ec0d8bfc478e..799407a1808cdd8e36d7fa5977cac35e308a4c23 100644 --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c index 316a23e77eb76eb7c532601d2779586fc54a7fea..a00816e7535de63726b3cbef307dbc57ced31c77 100644 --- a/xen/arch/x86/pv/iret.c +++ b/xen/arch/x86/pv/iret.c @@ -14,7 +14,7 @@ * * You should have received a copy of the GNU General Public * License along with this program; If not, see - * . + * . */ #include diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c index aaaf70eb633063e34cc2672dfe5e316f5b023065..e7a731b310a0455048611bdc681d97fab6d5855e 100644 --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/mm.c b/xen/arch/x86/pv/mm.c index 5ed7b3ccdbf209fb94b45c8e6c72eb510aeb5f19..44b74a6ec42a09dc74f39b2ff05c0779899da305 100644 --- a/xen/arch/x86/pv/mm.c +++ b/xen/arch/x86/pv/mm.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index 5963f5ee2d512a482b76f040eca4f4f314f91390..568dae9db6aa3d96baf0d12d150be2081bcf11df 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index ae1a0e6e65af04715b27fe55a5c316d74923ddb8..5c2b0481d7896066cb1e4ffa61cc9bbcc8e73415 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 97fe54b5ee5a6a95daa6146314f0d3fa482118b8..61de39eece9c514be14777dd4ae7690a018fc3c8 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b26758c2c89faf00719d75db5000c2c12331c848..621da7c204fd25362a96603c2bfe04fee3273b4f 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index a320b81947c85b39e1cea551b68b7aa7fdc4fab7..c61a95f7165e82e408959dd8e6074893e2b63e79 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8fa7aa8f6c8f8c73b8094e05855378e..ec8e67fadf70f3b9ae28aa369c25e0c1ebfca860 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c index 7027c08a926b3a9be0f296c56f7be5d4de537058..3067cb552af3af09ae8376519f2874b85b78e0b8 100644 --- a/xen/arch/x86/vm_event.c +++ b/xen/arch/x86/vm_event.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/x86_64/acpi_mmcfg.c b/xen/arch/x86/x86_64/acpi_mmcfg.c index 2159c68189e4b4f749f8e5a65c55a8a788ec659e..02c557449f9a18f1a06869d34bd308f9c0e8202d 100644 --- a/xen/arch/x86/x86_64/acpi_mmcfg.c +++ b/xen/arch/x86/x86_64/acpi_mmcfg.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/arch/x86/x86_64/cpu_idle.c b/xen/arch/x86/x86_64/cpu_idle.c index e2195d57bec7c768f80cef57bcde1c3b8e81b05d..0a5654cc122eaf60223d1c8591063bd959fd6559 100644 --- a/xen/arch/x86/x86_64/cpu_idle.c +++ b/xen/arch/x86/x86_64/cpu_idle.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/x86_64/cpufreq.c b/xen/arch/x86/x86_64/cpufreq.c index 9e1e2050da09688f2cd1cc5343f1a70b7af51ae2..f9ffc6275e6abc41d4a199bcf2f54c1ce59c036e 100644 --- a/xen/arch/x86/x86_64/cpufreq.c +++ b/xen/arch/x86/x86_64/cpufreq.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c index 8287124dfb1d0934e8a6d29de82fca374ca00357..4191cc148b9de3887204ba8b30302b19eced0d9b 100644 --- a/xen/arch/x86/x86_64/gdbstub.c +++ b/xen/arch/x86/x86_64/gdbstub.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 60db439af3ecb5cda1f641f0a18c5dea6b531ab6..5d7bb0ca3ed249277469ebcc29b01017545050b2 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . */ EMIT_FILE; diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h index 433046be663a4983ca5cdfb67b53df4e587f481b..057ae6ad758430c81b0f4c3c8303d2265a7a581f 100644 --- a/xen/arch/x86/x86_64/mmconfig.h +++ b/xen/arch/x86/x86_64/mmconfig.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay - adapted from linux */ diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index e38f98b547263b505078b649efbb8b9b666f657d..2ea0408e38c6a95f3cc08ad12b899488a97308eb 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* Operand sizes: 8-bit operands or specified/overridden size. */ diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index bb7af967ffee61e13fc1d4d2e0220fed77a88707..c5dc51330499b318d71ec60207e577491b10bc21 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __X86_EMULATE_H__ diff --git a/xen/common/argo.c b/xen/common/argo.c index 9ad2ecaa1e42337567cef6ecd53d56965590d60e..dad5b4a5e97d59ad7b8e687e61740264b37fdc67 100644 --- a/xen/common/argo.c +++ b/xen/common/argo.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c index 167ffb7f73967111724b900b296bd6ebbd12711a..041db16dbc3714aefbf01902ff7593bacab75280 100644 --- a/xen/common/bunzip2.c +++ b/xen/common/bunzip2.c @@ -7,7 +7,7 @@ Robert Sedgewick, and Jon L. Bentley. This code is licensed under the LGPLv2: - LGPL (http://www.gnu.org/copyleft/lgpl.html + LGPL (https://www.gnu.org/copyleft/lgpl.html */ /* diff --git a/xen/common/coverage/coverage.c b/xen/common/coverage/coverage.c index bd90f2866373795137912561c3897e01ab95a501..efecaceb2ebd7ae0a949c68960fc363563f1b0bd 100644 --- a/xen/common/coverage/coverage.c +++ b/xen/common/coverage/coverage.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/common/dm.c b/xen/common/dm.c index 201b652deb7eb09e9b78bdaefdf07ca3faa0a135..a335edb982f2814cd953678feb2777d22153724e 100644 --- a/xen/common/dm.c +++ b/xen/common/dm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index f5e0b12d15209d3d43ba1877e9def37b31ca32b7..65b75bc43837b52b891cca493bc4eedd82e21cc5 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include "event_channel.h" diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c index df8d122bce8d8c7fe0ede2303bfc46148712f4c4..a97f75ce94f140325300d64669a65cad973965cf 100644 --- a/xen/common/gdbstub.c +++ b/xen/common/gdbstub.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index b896f9af0e48d77b5d8e4d62d4bf2c15a3d675f7..a679c269d2680fff23b110eea8e80dbd4ec1fa4c 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -20,7 +20,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index ecb8f545e1c4c158272c9cd48090bb62ef88a567..763fa524806c925096443f1740cdebd5932ec696 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/libelf/libelf-dominfo.c b/xen/common/libelf/libelf-dominfo.c index 24d1371dd7a95d8d8f199ddd24f7d3fd0df398ea..22f5105412fe39361a239cf478dcb22d6e29ec92 100644 --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "libelf-private.h" diff --git a/xen/common/libelf/libelf-loader.c b/xen/common/libelf/libelf-loader.c index 629cc0d3e611f065689f239e368100c0624ee5a6..69571dfb6b3215ba381d8546b72774506c3704bc 100644 --- a/xen/common/libelf/libelf-loader.c +++ b/xen/common/libelf/libelf-loader.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifdef __XEN__ diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h index 47db679966c6d0019a883123e7323fd28a96e1a6..d2f71196e1d80e00b499a4e80b5802b1ddf0dc63 100644 --- a/xen/common/libelf/libelf-private.h +++ b/xen/common/libelf/libelf-private.h @@ -10,7 +10,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #ifndef __LIBELF_PRIVATE_H__ #define __LIBELF_PRIVATE_H__ diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c index a9edb6a8dcb348b1de77966dd96e6c2dcc82d4ef..245ca26fbea8f9e9058d02d23155b8ca1472482f 100644 --- a/xen/common/libelf/libelf-tools.c +++ b/xen/common/libelf/libelf-tools.c @@ -12,7 +12,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "libelf-private.h" diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 010e6f8dbfe9fbbd5223c9d1322a48e4f1d324f3..4bb463b5226065deb5be3983e994a71d190174ea 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/common/monitor.c b/xen/common/monitor.c index d5c9ff1cbf8cc71dfc1f31fbefa8ad21e2cdab99..4c89d9b85e38cf43c1f12cd9404c25667cc0e774 100644 --- a/xen/common/monitor.c +++ b/xen/common/monitor.c @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e40473f71ead2dbc182ecb80cac980b678e69280..806fc2ff37e0a7e2d61e600b6744b909043d10d9 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ /* diff --git a/xen/common/pdx.c b/xen/common/pdx.c index c91875fabe2b070ba42a043be2a95ec846c5f832..dae46270c15f022ae24aa9a9d71f7c03b5a47902 100644 --- a/xen/common/pdx.c +++ b/xen/common/pdx.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/preempt.c b/xen/common/preempt.c index 3b4178fd44acaef5d99e1b01c38a8ee483adea47..5d7a85c7f8623fc84940c3dfe246ef424babe9d2 100644 --- a/xen/common/preempt.c +++ b/xen/common/preempt.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c index adc3034222dc9f7177b415d6ef895ce6ad80f3f6..06fe1bd5d36da89ba0b6cc33995b9f05ab09e930 100644 --- a/xen/common/radix-tree.c +++ b/xen/common/radix-tree.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c index 70b4d21b0f1d6da758f1df0f1c5229c6afdf200e..e3caf0e322ff6fb9f9bcc421be32a752d7601f2d 100644 --- a/xen/common/rcupdate.c +++ b/xen/common/rcupdate.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2001 * diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c index 65a0a6c5312d25052fda69c0be1898ce41062bb9..e375f715e50ff885f5a27fec90b1144994a70b28 100644 --- a/xen/common/sched/null.c +++ b/xen/common/sched/null.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ /* diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c index 3adbe380de965d7e11ff0692fe707a1803c1d22a..af4b5ef728419a63d25c604f292727226ba4a0cd 100644 --- a/xen/common/stop_machine.c +++ b/xen/common/stop_machine.c @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/common/time.c b/xen/common/time.c index 92f7b72464723e6b4830c6db29d9d30ef46f47a7..8f659118dada04384682222f3e4dc98418102054 100644 --- a/xen/common/time.c +++ b/xen/common/time.c @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c index 69448d7b398634b6543b1fcea7b6101724c17b36..a45996744b424a2a9ee073c1bc69d2d4853b4624 100644 --- a/xen/common/unlzma.c +++ b/xen/common/unlzma.c @@ -25,7 +25,7 @@ * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this library; If not, see . + * License along with this library; If not, see . */ #include "decompress.h" diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c index 23eff1354fe0679299951abfb3fbe2bcc2adc699..65f76c890d3b8fd18de1716942ceb694b5dd4f6a 100644 --- a/xen/common/unlzo.c +++ b/xen/common/unlzo.c @@ -22,7 +22,7 @@ * * You should have received a copy of the GNU General Public License * along with this program; see the file COPYING. - * If not, see . + * If not, see . * * Markus F.X.J. Oberhumer * diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index ecf49c38a9889f4ddb6c7f73b3cabb386f18ba73..2a64811551081217c0b8eca185c5f879f2b62a01 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/common/wait.c b/xen/common/wait.c index 86d3b15419db27ad54ef4d9c94fc8418d0471406..8ce592ee0440f56c5804e64a0d8eb514f7ab2e34 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/apei-base.c b/xen/drivers/acpi/apei/apei-base.c index de75c1cef9922f8fd7a82b13ce1446b6231a612e..699e7f0e613ef2c24db3fff01bf4d7af5a2d2f5c 100644 --- a/xen/drivers/acpi/apei/apei-base.c +++ b/xen/drivers/acpi/apei/apei-base.c @@ -28,7 +28,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include #include diff --git a/xen/drivers/acpi/apei/apei-io.c b/xen/drivers/acpi/apei/apei-io.c index eadf7a4dab53d7be15c6d4183c1beec0491bfb14..3bc468a1d10a33dc998ae7acda2cc0707cd7242a 100644 --- a/xen/drivers/acpi/apei/apei-io.c +++ b/xen/drivers/acpi/apei/apei-io.c @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c index 40d8f00270d0ac5acab558661d4041f1634c6bf9..2dad97cff70ee564de66c4878eb66ce85c07e771 100644 --- a/xen/drivers/acpi/apei/erst.c +++ b/xen/drivers/acpi/apei/erst.c @@ -22,7 +22,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/apei/hest.c b/xen/drivers/acpi/apei/hest.c index 5881275d2f3762342043c7a7323ca3e42014e0da..d83795c7c6dbf5c82cbcb6347871d0a8a8bbec75 100644 --- a/xen/drivers/acpi/apei/hest.c +++ b/xen/drivers/acpi/apei/hest.c @@ -23,7 +23,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c index bc6e888234e4cb6266909130377c90bed5f5f2ba..d1e2a51eb14d098a5dc84a8f994c7c7a50498bd1 100644 --- a/xen/drivers/acpi/numa.c +++ b/xen/drivers/acpi/numa.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/acpi/osl.c b/xen/drivers/acpi/osl.c index 389505f786668dc4b6859956ee51f4f4df85f675..c080882cc71d7b42e00dccc7ed49949fa371bad2 100644 --- a/xen/drivers/acpi/osl.c +++ b/xen/drivers/acpi/osl.c @@ -18,7 +18,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 1bae6351019be9662c33ebc479d2d7470e8096fb..5d52ffdad1e1b6065888e01e5a00412f6a365f01 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -14,7 +14,7 @@ # more details. # # You should have received a copy of the GNU General Public License along with -# this program; If not, see . +# this program; If not, see . # # The full GNU General Public License is included in this distribution in the # file called LICENSE. diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c index 96ff96b84c6676ec9c6b13070382b2533de1f88c..c6c950598add102d19b9321a13fd7d76b4082bf5 100644 --- a/xen/drivers/acpi/tables.c +++ b/xen/drivers/acpi/tables.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * diff --git a/xen/drivers/char/consoled.c b/xen/drivers/char/consoled.c index 222e01844271a927e693d9c242e2124374bb1b3c..c53c6645ea2f900e9944b5b6a6c7ad04251bf8eb 100644 --- a/xen/drivers/char/consoled.c +++ b/xen/drivers/char/consoled.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c index b1e25e0468a49d764f1b40c522019e75dd496f4e..0e4a56dbef3dc955299ce6f38f701aa03a54df50 100644 --- a/xen/drivers/char/meson-uart.c +++ b/xen/drivers/char/meson-uart.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c index a00618b96fbc3bbdeaf09203e297b1b972bd9443..42307c4de81a44f5418700e0353a8c8d47338fcb 100644 --- a/xen/drivers/char/mvebu-uart.c +++ b/xen/drivers/char/mvebu-uart.c @@ -15,7 +15,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/char/xen_pv_console.c b/xen/drivers/char/xen_pv_console.c index 1536bdaf524583feb910a7bcf693c865df692265..37a9539e537ac2d2d388ebfb028c4dfb1d755d65 100644 --- a/xen/drivers/char/xen_pv_console.c +++ b/xen/drivers/char/xen_pv_console.c @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 60b781f872027c99c75c6d7eb3be82fa8e00ffbd..5127a085e6384352230c7bf9749da7ad07da4e1a 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (c) 2019 Assured Information Security. */ diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index a94520ee57ac914be1d51a4a498c8d66cf15f3c2..30368afc6bec2ae579286b4953f7fd8d0966bb7f 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -21,7 +21,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/drivers/passthrough/amd/iommu-defs.h b/xen/drivers/passthrough/amd/iommu-defs.h index 35de548e3a783c8e2be4aa6a2a04bfbc8f9bb7af..11726aeaa742687b72053ac51ccd3659a475bba6 100644 --- a/xen/drivers/passthrough/amd/iommu-defs.h +++ b/xen/drivers/passthrough/amd/iommu-defs.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef AMD_IOMMU_DEFS_H diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index 8bc3c35b1bb1d13d7d321145788996197821f1e5..9692c89aee9c7fc5f841faac7b2792423108ca76 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef AMD_IOMMU_H #define AMD_IOMMU_H diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b390cad35960eef212f5d4d75fd1c2a75..bb821cf29936645bf2545d467c184630eee4a37f 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_cmd.c b/xen/drivers/passthrough/amd/iommu_cmd.c index 40ddf366bb4d01b8effe21cc6bcb5adc4f55fff4..a94caada9597e2160bfb27427de2fb5d557d7c6e 100644 --- a/xen/drivers/passthrough/amd/iommu_cmd.c +++ b/xen/drivers/passthrough/amd/iommu_cmd.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include "iommu.h" diff --git a/xen/drivers/passthrough/amd/iommu_detect.c b/xen/drivers/passthrough/amd/iommu_detect.c index 2317fa6a7d8dc9967ca7320861da27009047a008..6d6d7e17a885f28088da766017fb24970b3cf0e1 100644 --- a/xen/drivers/passthrough/amd/iommu_detect.c +++ b/xen/drivers/passthrough/amd/iommu_detect.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 80a331f546ed847ffcc418e25e16e3789fe7a950..f8d1d9a4b1b72b63d4c0844d7ba2de54fc2ad919 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 9773ccfcb41fe700af5c592777ba9d3eab3f0ef7..2c5a9ac2bca1fcc8036b76cd00bc10106a9705ea 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c index f4de09f43180e4f07c1b354eab39152afe6f50f0..6af1bca33c146d4351f6833e751dde328033ec06 100644 --- a/xen/drivers/passthrough/amd/iommu_intr.c +++ b/xen/drivers/passthrough/amd/iommu_intr.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 993bac6f8878d2b64521ce5c59e8589e40be5af1..b4cb59ca2ea21a607a8e5b554848b117e320cae6 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 4ba8e764b22f4b5bfd6772071144cfecfa323816..bcd928078d532e76c3efc590698a920663875750 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/iommu_fwspec.c b/xen/drivers/passthrough/arm/iommu_fwspec.c index 8c97c7ca4807c4b01bf171a9a7dee5f0bfc4648f..bc082a7e1ff532cdfaab917213bd19c8e22914d7 100644 --- a/xen/drivers/passthrough/arm/iommu_fwspec.c +++ b/xen/drivers/passthrough/arm/iommu_fwspec.c @@ -20,7 +20,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/iommu_helpers.c b/xen/drivers/passthrough/arm/iommu_helpers.c index 5cb19874819357b5cd58638864b56c505d07b37a..4e026eca681f5653996cd72debefb7ccc0259581 100644 --- a/xen/drivers/passthrough/arm/iommu_helpers.c +++ b/xen/drivers/passthrough/arm/iommu_helpers.c @@ -20,7 +20,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c index 682bf12aaaf5bd7b50afda56cdc9694984442c57..425ba0330f1100d0ce7729d6a534d3172728233e 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -34,7 +34,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c index d58c5cd0bf772226904038e5c05d901ba1d5e1f9..e1f59f5889cc397921eedebed43cb5d6ebaea2b2 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -67,7 +67,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program. If not, see . + * along with this program. If not, see . * */ diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index 0a514821b3360b677a183b45a73c19ac191a4edc..e62b51c3d7f3db228b58f37138e77bd46fb549c9 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) 2013 ARM Limited * diff --git a/xen/drivers/passthrough/ats.c b/xen/drivers/passthrough/ats.c index 7f7b16dc490c2e287b838fa8e9a1b0c6a18c3c72..8b8a424f7a22e262862b42d17c2a2d6fb5cc3927 100644 --- a/xen/drivers/passthrough/ats.c +++ b/xen/drivers/passthrough/ats.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/ats.h b/xen/drivers/passthrough/ats.h index c202f4ecdd6753de10427bb4adfeaa00d6a4915a..2e8bf13d07dbd40ff0222f32b72684b6eed21626 100644 --- a/xen/drivers/passthrough/ats.h +++ b/xen/drivers/passthrough/ats.h @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef _ATS_H_ diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index b4dfa95dfd8e49b2c953d09bbfe5190ef04f7109..d72ac5f94a953d165d175f05467ca02ffa9114aa 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 9f8819785b49f26d7a03e30d51ac5dd0d6700719..d9d6e0e6db990cf822705bd583085465e13de4b3 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 78c8bad1515a231b0a501308e3003a5ce124fb2b..d71ad72dc434832308c047526021481c5622fbe3 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/dmar.h b/xen/drivers/passthrough/vtd/dmar.h index a1f2353a511f4f432494cd0d318ae9531a6c9001..33b9cea7ac835e812c690d6120da93968bb7b12c 100644 --- a/xen/drivers/passthrough/vtd/dmar.h +++ b/xen/drivers/passthrough/vtd/dmar.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h index 39602d1f88f82fdc94d2d94bab07dc4d95692223..4115e48b6047091f60e929199e1f13a264446ae1 100644 --- a/xen/drivers/passthrough/vtd/extern.h +++ b/xen/drivers/passthrough/vtd/extern.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c index 1512e4866b8cce8453c4c65838425c1ae093f197..0f0d390714ee77924570af6a7d6d0b8a954f0cc7 100644 --- a/xen/drivers/passthrough/vtd/intremap.c +++ b/xen/drivers/passthrough/vtd/intremap.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 62e143125d99443e9949e51ccc65a1b92ff3b648..7f3780fadff7e48d8a5e9f98e87d9533b22194bd 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj * Copyright (C) Shaohua Li diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h index 78aa8a96f5a01b7a5fb01d5ebcb3a934c0a51f29..caaa3d51ea9eafe50eeae2cc22691e8ecf55f3e3 100644 --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Ashok Raj */ diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c index 4f9ad136b9c50ec2ea86cd698879d7beb5444133..8952b454d5b28ce110346807169d8476b0b73e11 100644 --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index fcc8f73e8b906a3a7279410b7e80b55c6e4e61bd..763dd335a8ff7a4bf23ad4f135c7fdf6d523b94b 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c index 7c4d032f4f275dca753b011ef6f337e231fd3107..0a1e2ced49db198b6b02dd0471c184803d26c7cd 100644 --- a/xen/drivers/passthrough/vtd/utils.c +++ b/xen/drivers/passthrough/vtd/utils.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/vtd.h b/xen/drivers/passthrough/vtd/vtd.h index cb2df76eeddbd1f1e3682f7acc28433efdc5c643..af6d64ce20a41ec74ebbd02dce3509b5539834d8 100644 --- a/xen/drivers/passthrough/vtd/vtd.h +++ b/xen/drivers/passthrough/vtd/vtd.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c index 04d702b1d6b1985e4e0a07eb29118133b1682c77..fba0d92d6011ae5c422b777af31c4b5efedba93a 100644 --- a/xen/drivers/passthrough/vtd/x86/ats.c +++ b/xen/drivers/passthrough/vtd/x86/ats.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Author: Allen Kay */ diff --git a/xen/drivers/passthrough/vtd/x86/hvm.c b/xen/drivers/passthrough/vtd/x86/hvm.c index bc776cf7daaa206273f1e90ef9667a0725444f69..420bc6aa4e3b4c0624535761e7882561c9552dec 100644 --- a/xen/drivers/passthrough/vtd/x86/hvm.c +++ b/xen/drivers/passthrough/vtd/x86/hvm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/vtd/x86/vtd.c b/xen/drivers/passthrough/vtd/x86/vtd.c index 76f12adc23dfc5f3d6d62056f7e85029d212e618..ccb5710683a3179b3e7a3b091612a60adc0cb786 100644 --- a/xen/drivers/passthrough/vtd/x86/vtd.c +++ b/xen/drivers/passthrough/vtd/x86/vtd.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Weidong Han diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c index dd09ec22f12d53c1f1a3f1643a7792281eeffc0b..c424a7fd01a6c62b7318ade02d66ad2c70ac28de 100644 --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay * Copyright (C) Xiaohui Xin diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index f671b0f2bb45b22059a04be8f76d92c80b6700e9..dc5924d1ef6b7a3bfab941f6724e1d8b0e0077a8 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -9,7 +9,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index ec2e978a4e6b16706f1c6ad61e4648b56c15f009..ac0418cffd9a42bbd92ce02e9476127ea84cac3e 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c index 8f2b59e61aa42eca4d2bb583019a6e2df952b9f3..9649cf30c116346497017009ba32ad9df866a999 100644 --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -13,7 +13,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index bea0cc7aede17847bdfc1a4735d1e0a06acf6fb0..cdad7cbcb6a96bf74250b4f61b46bb011ff03a82 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 6d48d496bb4871e28f3c25a730dcbdf88dd48151..662419892399f5c5f2daec705fcedaf83e9dfef7 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #include diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h index 352f27f6a72396ada2dc30c6374d766614c2094f..1e1ea51fc6b55868f7d7643100d84ec008285762 100644 --- a/xen/include/xen/acpi.h +++ b/xen/include/xen/acpi.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/include/xen/argo.h b/xen/include/xen/argo.h index fd4cfdd55c0ab90cd9ed2723a1fd7e867d33f4de..6653970bc45b9c23484985b27e7aef14c4223363 100644 --- a/xen/include/xen/argo.h +++ b/xen/include/xen/argo.h @@ -9,7 +9,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_ARGO_H__ diff --git a/xen/include/xen/atomic.h b/xen/include/xen/atomic.h index 529213ebbb4b8cf6ab40b3f32fcf93c8be8a29e7..550087f5f29b3a1c4826b50a80ad9db7a2d0a190 100644 --- a/xen/include/xen/atomic.h +++ b/xen/include/xen/atomic.h @@ -16,7 +16,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_ATOMIC_H__ diff --git a/xen/include/xen/cper.h b/xen/include/xen/cper.h index 8788ceff126d98d7edd9d963c89934a2671fbd59..5df340bae735d22deb5359ee299bacbb46cbeab5 100644 --- a/xen/include/xen/cper.h +++ b/xen/include/xen/cper.h @@ -15,7 +15,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef LINUX_CPER_H diff --git a/xen/include/xen/cpuidle.h b/xen/include/xen/cpuidle.h index 521a8deb04c23bba99178d341d0cc05288b6382d..e04d928291a32054298241f26f7f3a141b1d2c01 100644 --- a/xen/include/xen/cpuidle.h +++ b/xen/include/xen/cpuidle.h @@ -19,7 +19,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License along - * with this program; If not, see . + * with this program; If not, see . * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ diff --git a/xen/include/xen/dm.h b/xen/include/xen/dm.h index 18417d57f1e5a20d2f97d40bb19cfebfb5e6217a..cfeef82473a276efa07c9fa6fbdc50f480021829 100644 --- a/xen/include/xen/dm.h +++ b/xen/include/xen/dm.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_DM_H__ diff --git a/xen/include/xen/gdbstub.h b/xen/include/xen/gdbstub.h index 18c960969b769d20d035855479391407587c3636..9fd079d85616df1b12356109969a36cb25459eb9 100644 --- a/xen/include/xen/gdbstub.h +++ b/xen/include/xen/gdbstub.h @@ -14,7 +14,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_GDBSTUB_H__ diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h index 85fe6b7b5eb20c078ee422d1550be755af799a86..84d61b3ce99c0a0672bbd69afdaf53b12764ca94 100644 --- a/xen/include/xen/grant_table.h +++ b/xen/include/xen/grant_table.h @@ -17,7 +17,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef __XEN_GRANT_TABLE_H__ diff --git a/xen/include/xen/inttypes.h b/xen/include/xen/inttypes.h index 28c0053f1c7adab0d56615b2a217ebbeb4e516a8..4db9ab779331caf7826c6bcaf14574de8b704b64 100644 --- a/xen/include/xen/inttypes.h +++ b/xen/include/xen/inttypes.h @@ -12,7 +12,7 @@ Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; If not, see . */ + License along with the GNU C Library; If not, see . */ /* * ISO C99: 7.8 Format conversion of integer types diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 4f22fc1bed5523c5b1a8951579975e0712c08c28..964b690628faef1bbd9ec3edc2775fd79f3bbe0f 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -11,7 +11,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . * * Copyright (C) Allen Kay */ diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h index a26614d331e3c98f9d4b7967b6fdd9d4e6a49de6..2e2004cf6a07e8992c5db80972685a4e4c5c7fd8 100644 --- a/xen/include/xen/ioreq.h +++ b/xen/include/xen/ioreq.h @@ -13,7 +13,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #ifndef __XEN_IOREQ_H__ diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h index 4e4811680dc96fc40928f1b21208c6dc3f5f49ec..1ed4fde2a8cafce4f6a549ea286837b90d3e418b 100644 --- a/xen/include/xen/mem_access.h +++ b/xen/include/xen/mem_access.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_MEM_ACCESS_H diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h index 6b17a9307195df172b62bd9acf2cbb2c964dfad4..2652b016ed8a2f855717a32a2977c7266c049749 100644 --- a/xen/include/xen/monitor.h +++ b/xen/include/xen/monitor.h @@ -16,7 +16,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public - * License along with this program; If not, see . + * License along with this program; If not, see . */ #ifndef __XEN_MONITOR_H__ diff --git a/xen/include/xen/multiboot.h b/xen/include/xen/multiboot.h index 80a1761d9ee7742b30d5c8a18a4d962dfed181da..d3a1998c93d9527aef2a8a224fa6778783e157b8 100644 --- a/xen/include/xen/multiboot.h +++ b/xen/include/xen/multiboot.h @@ -12,7 +12,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . */ + along with this program; If not, see . */ #ifndef __MULTIBOOT_H__ #define __MULTIBOOT_H__ diff --git a/xen/include/xen/radix-tree.h b/xen/include/xen/radix-tree.h index 58c40312e61986e311576beff7b8627cfde64c7b..3ffe32b27c60ab7bc74515550bee1f09b57e3985 100644 --- a/xen/include/xen/radix-tree.h +++ b/xen/include/xen/radix-tree.h @@ -14,7 +14,7 @@ * General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ #ifndef _XEN_RADIX_TREE_H #define _XEN_RADIX_TREE_H diff --git a/xen/include/xen/rbtree.h b/xen/include/xen/rbtree.h index 77bf57d4abc8da2ed7cfa6adbe5f8ab78fc17a29..99473a8db0a46bdbe845c4730956e2e6c1e35e25 100644 --- a/xen/include/xen/rbtree.h +++ b/xen/include/xen/rbtree.h @@ -13,7 +13,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . linux/include/linux/rbtree.h diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h index f123b77aafaa1cb50ba6bceea88cfb4408e9cb6d..cde46128944ae23dad12061225410f88b1e1f468 100644 --- a/xen/include/xen/rcupdate.h +++ b/xen/include/xen/rcupdate.h @@ -12,7 +12,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . * * Copyright (C) IBM Corporation, 2001 * diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h index 92811d9110e5509009aaa47278d63643412bd0ee..d60681bec668ebf0d27dac69b8d3ade6ae3f333d 100644 --- a/xen/include/xen/vm_event.h +++ b/xen/include/xen/vm_event.h @@ -16,7 +16,7 @@ * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with this program; If not, see . + * along with this program; If not, see . */ diff --git a/xen/lib/list-sort.c b/xen/lib/list-sort.c index de1af2ef8b0c279f3fbd9b93aa68619bb34dad51..82670110e20efda833a85f99838f461f42e10fdd 100644 --- a/xen/lib/list-sort.c +++ b/xen/lib/list-sort.c @@ -12,7 +12,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #include diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c index 8b6c2c7572cd9793bbb77192704db27e04cb3988..ba03bfae71aafa1c590f66f96d586a2b4169eadc 100644 --- a/xen/lib/rbtree.c +++ b/xen/lib/rbtree.c @@ -15,7 +15,7 @@ GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; If not, see . + along with this program; If not, see . linux/lib/rbtree.c */ diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index b89b364287840623792f853e44070ce24a2b3cc4..1570fb2b2f72b6829f7bb39d939240d7bcb6e69e 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -15,7 +15,7 @@ * more details. * * You should have received a copy of the GNU General Public License along with - * this program; If not, see . + * this program; If not, see . */ #define XSM_NO_WRAPPERS #include -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Wed Feb 08 22:59:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 22:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492039.761423 (Exim 4.92) (envelope-from ) id 1pPtOx-0006wC-Ki; Wed, 08 Feb 2023 22:58:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492039.761423; Wed, 08 Feb 2023 22:58:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtOx-0006w5-Gl; Wed, 08 Feb 2023 22:58:55 +0000 Received: by outflank-mailman (input) for mailman id 492039; Wed, 08 Feb 2023 22:58:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtOu-0006vx-Ue for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 22:58:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2494ac15-a804-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 23:58:47 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7CBB461705; Wed, 8 Feb 2023 22:58:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B99F6C433EF; Wed, 8 Feb 2023 22:58:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2494ac15-a804-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675897123; bh=6I2/S1cR8P2HKExYCPphUyBSZsDS4bn35ZwrQXJ6MIk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=K1s6s4pOcvHpLKzxqPbRSSdGjo+qRwYJhwDCrh2x33sSJar8ZuyKPPNMB8vAOw37I Bkmv+s4X3Prj/l1lej2RlBqYKy9dtZpR3tZKq4JMJ8XcbfhMtvBtecVZU3J0cHcyYL sBpHJzaCCytCTnBSEpHyqG9Pn3n4DQ5g0IKhAMw78KSF/RP1ziqx38rQBxm4wEagYG bcca6bb1FIwmW5VQCbvt4jk0KD8/YYCGL2IBGZFIgQj2qL15U7MrUqRU9q9uSy9Ige 2UvMbRdjqDJu7nnOmZlnOXtQgFmxtIT/4+Fs2f+exkikVFYLMI4Rt5pMUoIR2EHdsI Z099vpOQKbJ8Q== Date: Wed, 8 Feb 2023 14:58:38 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Demi Marie Obenour cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS In-Reply-To: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> Message-ID: References: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > This patch changes GPL boilerplate. > > Signed-off-by: Demi Marie Obenour For the licensing boilerplate, I think it would be better to switch to SPDX instead. That said, given that you have already done the work to covert the GPL boilerplate everywhere, I think this is OK. But if you have time and energy I would love to see a patch switching to SPDX in as many places as possible. > --- > m4/pkg.m4 | 2 +- > m4/systemd.m4 | 2 +- > stubdom/grub.patches/10graphics.diff | 4 ++-- > stubdom/grub.patches/61btrfs.diff | 4 ++-- > stubdom/vtpmmgr/tpmrsa.c | 2 +- > stubdom/vtpmmgr/tpmrsa.h | 2 +- > tools/configure | 4 ++-- > tools/console/client/main.c | 2 +- > tools/console/daemon/io.c | 2 +- > tools/console/daemon/io.h | 2 +- > tools/console/daemon/main.c | 2 +- > tools/console/daemon/utils.c | 2 +- > tools/console/daemon/utils.h | 2 +- > tools/debugger/gdbsx/gx/gx.h | 2 +- > tools/debugger/gdbsx/gx/gx_comm.c | 4 ++-- > tools/debugger/gdbsx/gx/gx_local.c | 2 +- > tools/debugger/gdbsx/gx/gx_main.c | 2 +- > tools/debugger/gdbsx/gx/gx_utils.c | 2 +- > tools/debugger/gdbsx/gx/xg_dummy.c | 2 +- > tools/debugger/gdbsx/xg/xg_main.c | 2 +- > tools/debugger/gdbsx/xg/xg_public.h | 2 +- > tools/firmware/hvmloader/32bitbios_support.c | 2 +- > tools/firmware/hvmloader/Makefile | 2 +- > tools/firmware/hvmloader/cacheattr.c | 2 +- > tools/firmware/hvmloader/e820.c | 2 +- > tools/firmware/hvmloader/hvmloader.c | 2 +- > tools/firmware/hvmloader/mp_tables.c | 2 +- > tools/firmware/hvmloader/optionroms.c | 2 +- > tools/firmware/hvmloader/ovmf.c | 2 +- > tools/firmware/hvmloader/pci.c | 2 +- > tools/firmware/hvmloader/pir_types.h | 2 +- > tools/firmware/hvmloader/rombios.c | 2 +- > tools/firmware/hvmloader/seabios.c | 2 +- > tools/firmware/hvmloader/smbios.c | 2 +- > tools/firmware/hvmloader/smbios_types.h | 2 +- > tools/firmware/hvmloader/smp.c | 2 +- > tools/firmware/hvmloader/tests.c | 2 +- > tools/firmware/hvmloader/util.c | 2 +- > tools/firmware/rombios/32bit/32bitbios.c | 2 +- > tools/firmware/rombios/32bit/mkhex | 2 +- > tools/firmware/rombios/32bit/pmm.c | 2 +- > tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- > tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c | 2 +- > tools/firmware/rombios/32bit/util.c | 2 +- > tools/firmware/rombios/32bitgateway.c | 2 +- > tools/firmware/rombios/apmbios.S | 2 +- > tools/firmware/rombios/rombios.c | 2 +- > tools/firmware/rombios/rombios.h | 2 +- > tools/firmware/rombios/tcgbios.c | 2 +- > tools/firmware/vgabios/COPYING | 2 +- > tools/firmware/vgabios/biossums.c | 2 +- > tools/firmware/vgabios/clext.c | 2 +- > tools/firmware/vgabios/vbe.c | 2 +- > tools/firmware/vgabios/vgabios.c | 2 +- > tools/golang/xenlight/xenlight.go | 2 +- > tools/hotplug/Linux/block-common.sh | 2 +- > tools/hotplug/Linux/block-drbd-probe | 2 +- > tools/hotplug/Linux/external-device-migrate | 2 +- > tools/hotplug/Linux/launch-xenstore.in | 2 +- > tools/hotplug/Linux/locking.sh | 2 +- > tools/hotplug/Linux/logging.sh | 2 +- > tools/hotplug/Linux/vif-common.sh | 2 +- > tools/hotplug/Linux/xen-hotplug-common.sh.in | 2 +- > tools/hotplug/Linux/xen-network-common.sh | 2 +- > tools/hotplug/Linux/xen-script-common.sh | 2 +- > tools/hotplug/NetBSD/locking.sh | 2 +- > tools/include/libxenvchan.h | 2 +- > tools/include/xencall.h | 2 +- > tools/include/xenctrl.h | 2 +- > tools/include/xendevicemodel.h | 2 +- > tools/include/xenevtchn.h | 2 +- > tools/include/xenforeignmemory.h | 2 +- > tools/include/xengnttab.h | 2 +- > tools/include/xenguest.h | 2 +- > tools/include/xenhypfs.h | 2 +- > tools/include/xenstore.h | 2 +- > tools/include/xenstore_lib.h | 2 +- > tools/include/xentoolcore.h | 2 +- > tools/include/xentoolcore_internal.h | 2 +- > tools/include/xentoollog.h | 2 +- > tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 +- > tools/libfsimage/fat/fat.h | 2 +- > tools/libfsimage/fat/fsys_fat.c | 2 +- > tools/libfsimage/iso9660/fsys_iso9660.c | 2 +- > tools/libfsimage/iso9660/iso9660.h | 2 +- > tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 +- > tools/libfsimage/ufs/fsys_ufs.c | 2 +- > tools/libfsimage/xfs/fsys_xfs.c | 2 +- > tools/libfsimage/xfs/xfs.h | 2 +- > tools/libfsimage/zfs/Makefile | 2 +- > tools/libfsimage/zfs/filesys.h | 2 +- > tools/libfsimage/zfs/fsi_zfs.c | 2 +- > tools/libfsimage/zfs/fsi_zfs.h | 2 +- > tools/libfsimage/zfs/fsys_zfs.c | 2 +- > tools/libfsimage/zfs/fsys_zfs.h | 2 +- > tools/libfsimage/zfs/mb_info.h | 2 +- > tools/libfsimage/zfs/shared.h | 2 +- > tools/libfsimage/zfs/zfs-include/dmu.h | 2 +- > tools/libfsimage/zfs/zfs-include/dmu_objset.h | 2 +- > tools/libfsimage/zfs/zfs-include/dnode.h | 2 +- > tools/libfsimage/zfs/zfs-include/dsl_dataset.h | 2 +- > tools/libfsimage/zfs/zfs-include/dsl_dir.h | 2 +- > tools/libfsimage/zfs/zfs-include/sa_impl.h | 2 +- > tools/libfsimage/zfs/zfs-include/spa.h | 2 +- > tools/libfsimage/zfs/zfs-include/uberblock_impl.h | 2 +- > tools/libfsimage/zfs/zfs-include/vdev_impl.h | 2 +- > tools/libfsimage/zfs/zfs-include/zap_impl.h | 2 +- > tools/libfsimage/zfs/zfs-include/zap_leaf.h | 2 +- > tools/libfsimage/zfs/zfs-include/zfs.h | 2 +- > tools/libfsimage/zfs/zfs-include/zfs_acl.h | 2 +- > tools/libfsimage/zfs/zfs-include/zfs_znode.h | 2 +- > tools/libfsimage/zfs/zfs-include/zil.h | 2 +- > tools/libfsimage/zfs/zfs-include/zio.h | 2 +- > tools/libfsimage/zfs/zfs-include/zio_checksum.h | 2 +- > tools/libfsimage/zfs/zfs_fletcher.c | 2 +- > tools/libfsimage/zfs/zfs_lzjb.c | 2 +- > tools/libfsimage/zfs/zfs_sha256.c | 2 +- > tools/libs/call/buffer.c | 2 +- > tools/libs/call/core.c | 2 +- > tools/libs/call/freebsd.c | 2 +- > tools/libs/call/linux.c | 2 +- > tools/libs/call/minios.c | 2 +- > tools/libs/call/netbsd.c | 2 +- > tools/libs/call/solaris.c | 2 +- > tools/libs/ctrl/xc_altp2m.c | 2 +- > tools/libs/ctrl/xc_cpu_hotplug.c | 2 +- > tools/libs/ctrl/xc_cpupool.c | 2 +- > tools/libs/ctrl/xc_csched.c | 2 +- > tools/libs/ctrl/xc_csched2.c | 2 +- > tools/libs/ctrl/xc_domain.c | 2 +- > tools/libs/ctrl/xc_evtchn.c | 2 +- > tools/libs/ctrl/xc_flask.c | 2 +- > tools/libs/ctrl/xc_foreign_memory.c | 2 +- > tools/libs/ctrl/xc_freebsd.c | 2 +- > tools/libs/ctrl/xc_gnttab.c | 2 +- > tools/libs/ctrl/xc_hcall_buf.c | 2 +- > tools/libs/ctrl/xc_linux.c | 2 +- > tools/libs/ctrl/xc_mem_access.c | 2 +- > tools/libs/ctrl/xc_mem_paging.c | 2 +- > tools/libs/ctrl/xc_memshr.c | 2 +- > tools/libs/ctrl/xc_minios.c | 2 +- > tools/libs/ctrl/xc_misc.c | 2 +- > tools/libs/ctrl/xc_monitor.c | 2 +- > tools/libs/ctrl/xc_netbsd.c | 2 +- > tools/libs/ctrl/xc_pagetab.c | 2 +- > tools/libs/ctrl/xc_physdev.c | 2 +- > tools/libs/ctrl/xc_pm.c | 2 +- > tools/libs/ctrl/xc_private.c | 2 +- > tools/libs/ctrl/xc_private.h | 2 +- > tools/libs/ctrl/xc_rt.c | 2 +- > tools/libs/ctrl/xc_solaris.c | 2 +- > tools/libs/ctrl/xc_tbuf.c | 2 +- > tools/libs/ctrl/xc_vm_event.c | 2 +- > tools/libs/ctrl/xc_vmtrace.c | 2 +- > tools/libs/devicemodel/common.c | 2 +- > tools/libs/devicemodel/compat.c | 2 +- > tools/libs/devicemodel/core.c | 2 +- > tools/libs/evtchn/core.c | 2 +- > tools/libs/evtchn/freebsd.c | 2 +- > tools/libs/evtchn/linux.c | 2 +- > tools/libs/evtchn/minios.c | 2 +- > tools/libs/evtchn/netbsd.c | 2 +- > tools/libs/evtchn/solaris.c | 2 +- > tools/libs/foreignmemory/compat.c | 2 +- > tools/libs/foreignmemory/core.c | 2 +- > tools/libs/foreignmemory/freebsd.c | 2 +- > tools/libs/foreignmemory/linux.c | 2 +- > tools/libs/foreignmemory/minios.c | 2 +- > tools/libs/foreignmemory/netbsd.c | 2 +- > tools/libs/foreignmemory/solaris.c | 2 +- > tools/libs/gnttab/freebsd.c | 2 +- > tools/libs/gnttab/gntshr_core.c | 2 +- > tools/libs/gnttab/gntshr_unimp.c | 2 +- > tools/libs/gnttab/gnttab_core.c | 2 +- > tools/libs/gnttab/gnttab_unimp.c | 2 +- > tools/libs/gnttab/linux.c | 2 +- > tools/libs/gnttab/minios.c | 2 +- > tools/libs/gnttab/netbsd.c | 2 +- > tools/libs/guest/xg_core.c | 2 +- > tools/libs/guest/xg_core.h | 2 +- > tools/libs/guest/xg_core_arm.c | 2 +- > tools/libs/guest/xg_core_arm.h | 2 +- > tools/libs/guest/xg_core_x86.c | 2 +- > tools/libs/guest/xg_core_x86.h | 2 +- > tools/libs/guest/xg_cpuid_x86.c | 2 +- > tools/libs/guest/xg_dom_arm.c | 2 +- > tools/libs/guest/xg_dom_armzimageloader.c | 2 +- > tools/libs/guest/xg_dom_binloader.c | 2 +- > tools/libs/guest/xg_dom_boot.c | 2 +- > tools/libs/guest/xg_dom_bzimageloader.c | 2 +- > tools/libs/guest/xg_dom_compat_linux.c | 2 +- > tools/libs/guest/xg_dom_core.c | 2 +- > tools/libs/guest/xg_dom_elfloader.c | 2 +- > tools/libs/guest/xg_dom_hvmloader.c | 2 +- > tools/libs/guest/xg_dom_x86.c | 2 +- > tools/libs/guest/xg_domain.c | 2 +- > tools/libs/guest/xg_nomigrate.c | 2 +- > tools/libs/guest/xg_offline_page.c | 2 +- > tools/libs/guest/xg_private.c | 2 +- > tools/libs/guest/xg_private.h | 2 +- > tools/libs/guest/xg_resume.c | 2 +- > tools/libs/guest/xg_save_restore.h | 2 +- > tools/libs/guest/xg_suspend.c | 2 +- > tools/libs/hypfs/core.c | 2 +- > tools/libs/stat/COPYING | 2 +- > tools/libs/store/xs.c | 2 +- > tools/libs/toolcore/handlereg.c | 2 +- > tools/libs/toollog/xtl_core.c | 2 +- > tools/libs/toollog/xtl_logger_stdio.c | 2 +- > tools/libs/util/libxlu_cfg_y.c | 2 +- > tools/libs/util/libxlu_cfg_y.h | 2 +- > tools/libs/vchan/init.c | 2 +- > tools/libs/vchan/io.c | 2 +- > tools/libs/vchan/vchan.h | 2 +- > tools/misc/mkhex | 2 +- > tools/misc/xen-mceinj.c | 2 +- > tools/misc/xen-vmtrace.c | 2 +- > tools/misc/xencov.c | 2 +- > tools/misc/xenpm.c | 2 +- > tools/misc/xenpvnetboot | 2 +- > tools/ocaml/LICENSE | 2 +- > tools/pygrub/src/ExtLinuxConf.py | 2 +- > tools/pygrub/src/GrubConf.py | 2 +- > tools/pygrub/src/pygrub | 2 +- > tools/python/xen/lowlevel/xs/xs.c | 2 +- > tools/tests/depriv/depriv-fd-checker.c | 2 +- > tools/tests/vhpet/emul.h | 2 +- > tools/tests/vhpet/main.c | 2 +- > tools/tests/vpci/emul.h | 2 +- > tools/tests/vpci/main.c | 2 +- > tools/tests/x86_emulator/blowfish.c | 2 +- > tools/tests/xenstore/test-xenstore.c | 2 +- > tools/vchan/node-select.c | 2 +- > tools/vchan/node.c | 2 +- > tools/vchan/vchan-socket-proxy.c | 2 +- > tools/xenmon/COPYING | 2 +- > tools/xenmon/setmask.c | 2 +- > tools/xenmon/xenbaked.c | 2 +- > tools/xenmon/xenbaked.h | 2 +- > tools/xenmon/xenmon.py | 2 +- > tools/xenpaging/file_ops.c | 2 +- > tools/xenpaging/file_ops.h | 2 +- > tools/xenpaging/policy.h | 2 +- > tools/xenpaging/policy_default.c | 2 +- > tools/xenpaging/xenpaging.c | 2 +- > tools/xenpaging/xenpaging.h | 2 +- > tools/xenpmd/xenpmd.c | 2 +- > tools/xenstore/COPYING | 2 +- > tools/xenstore/include/xenstore_state.h | 2 +- > tools/xenstore/talloc.c | 2 +- > tools/xenstore/talloc.h | 2 +- > tools/xenstore/tdb.c | 2 +- > tools/xenstore/tdb.h | 2 +- > tools/xenstore/xenstored_control.c | 2 +- > tools/xenstore/xenstored_control.h | 2 +- > tools/xenstore/xenstored_core.c | 2 +- > tools/xenstore/xenstored_core.h | 2 +- > tools/xenstore/xenstored_domain.c | 2 +- > tools/xenstore/xenstored_domain.h | 2 +- > tools/xenstore/xenstored_minios.c | 2 +- > tools/xenstore/xenstored_posix.c | 2 +- > tools/xenstore/xenstored_transaction.c | 2 +- > tools/xenstore/xenstored_transaction.h | 2 +- > tools/xenstore/xenstored_watch.c | 2 +- > tools/xenstore/xenstored_watch.h | 2 +- > tools/xenstore/xs_lib.c | 2 +- > tools/xenstore/xs_lib.h | 2 +- > tools/xentop/xentop.c | 2 +- > tools/xentrace/xenalyze.c | 2 +- > xen/COPYING | 2 +- > xen/arch/arm/acpi/boot.c | 2 +- > xen/arch/arm/acpi/lib.c | 2 +- > xen/arch/arm/arm32/insn.c | 2 +- > xen/arch/arm/arm32/lib/bitops.c | 2 +- > xen/arch/arm/arm32/lib/lib1funcs.S | 2 +- > xen/arch/arm/arm32/lib/lshrdi3.S | 2 +- > xen/arch/arm/arm64/bpi.S | 2 +- > xen/arch/arm/arm64/cache.S | 2 +- > xen/arch/arm/arm64/debug-meson.inc | 2 +- > xen/arch/arm/arm64/debug-mvebu.inc | 2 +- > xen/arch/arm/arm64/insn.c | 2 +- > xen/arch/arm/arm64/lib/bitops.c | 2 +- > xen/arch/arm/arm64/lib/clear_page.S | 2 +- > xen/arch/arm/arm64/lib/memchr.S | 2 +- > xen/arch/arm/arm64/lib/memcmp.S | 2 +- > xen/arch/arm/arm64/lib/memcpy.S | 2 +- > xen/arch/arm/arm64/lib/memmove.S | 2 +- > xen/arch/arm/arm64/lib/memset.S | 2 +- > xen/arch/arm/arm64/lib/strchr.S | 2 +- > xen/arch/arm/arm64/lib/strcmp.S | 2 +- > xen/arch/arm/arm64/lib/strlen.S | 2 +- > xen/arch/arm/arm64/lib/strncmp.S | 2 +- > xen/arch/arm/arm64/lib/strnlen.S | 2 +- > xen/arch/arm/arm64/lib/strrchr.S | 2 +- > xen/arch/arm/efi/efi-dom0.c | 2 +- > xen/arch/arm/include/asm/acpi.h | 2 +- > xen/arch/arm/include/asm/altp2m.h | 2 +- > xen/arch/arm/include/asm/arm32/insn.h | 2 +- > xen/arch/arm/include/asm/arm64/atomic.h | 2 +- > xen/arch/arm/include/asm/arm64/insn.h | 2 +- > xen/arch/arm/include/asm/arm64/io.h | 2 +- > xen/arch/arm/include/asm/gic_v3_its.h | 2 +- > xen/arch/arm/include/asm/iommu.h | 2 +- > xen/arch/arm/include/asm/iommu_fwspec.h | 2 +- > xen/arch/arm/include/asm/ioreq.h | 2 +- > xen/arch/arm/include/asm/mem_access.h | 2 +- > xen/arch/arm/include/asm/monitor.h | 2 +- > xen/arch/arm/include/asm/new_vgic.h | 2 +- > xen/arch/arm/include/asm/pci.h | 2 +- > xen/arch/arm/include/asm/vm_event.h | 2 +- > xen/arch/arm/include/asm/vpl011.h | 2 +- > xen/arch/arm/include/asm/vpsci.h | 2 +- > xen/arch/arm/pci/ecam.c | 2 +- > xen/arch/arm/pci/pci-access.c | 2 +- > xen/arch/arm/pci/pci-host-common.c | 2 +- > xen/arch/arm/pci/pci-host-generic.c | 2 +- > xen/arch/arm/pci/pci-host-zynqmp.c | 2 +- > xen/arch/arm/pci/pci.c | 2 +- > xen/arch/arm/platforms/thunderx.c | 2 +- > xen/arch/arm/vgic/vgic-init.c | 2 +- > xen/arch/arm/vgic/vgic-mmio.h | 2 +- > xen/arch/arm/vgic/vgic-v2.c | 2 +- > xen/arch/arm/vgic/vgic.c | 2 +- > xen/arch/arm/vgic/vgic.h | 2 +- > xen/arch/x86/acpi/boot.c | 2 +- > xen/arch/x86/acpi/cpu_idle.c | 2 +- > xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- > xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- > xen/arch/x86/acpi/cpuidle_menu.c | 2 +- > xen/arch/x86/acpi/lib.c | 2 +- > xen/arch/x86/alternative.c | 2 +- > xen/arch/x86/boot/build32.lds | 2 +- > xen/arch/x86/boot/cmdline.c | 2 +- > xen/arch/x86/boot/defs.h | 2 +- > xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 2 +- > xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- > xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- > xen/arch/x86/cpu/mcheck/vmce.c | 2 +- > xen/arch/x86/cpu/mcheck/x86_mca.h | 2 +- > xen/arch/x86/cpu/mtrr/main.c | 2 +- > xen/arch/x86/cpu/mwait-idle.c | 2 +- > xen/arch/x86/cpu/vpmu.c | 2 +- > xen/arch/x86/cpu/vpmu_amd.c | 2 +- > xen/arch/x86/cpu/vpmu_intel.c | 2 +- > xen/arch/x86/gdbstub.c | 2 +- > xen/arch/x86/gdbsx.c | 2 +- > xen/arch/x86/genapic/x2apic.c | 2 +- > xen/arch/x86/guest/hyperv/hyperv.c | 2 +- > xen/arch/x86/guest/hyperv/private.h | 2 +- > xen/arch/x86/guest/hyperv/tlb.c | 2 +- > xen/arch/x86/guest/hyperv/util.c | 2 +- > xen/arch/x86/guest/hypervisor.c | 2 +- > xen/arch/x86/guest/xen/pvh-boot.c | 2 +- > xen/arch/x86/guest/xen/xen.c | 2 +- > xen/arch/x86/hvm/asid.c | 2 +- > xen/arch/x86/hvm/dm.c | 2 +- > xen/arch/x86/hvm/dom0_build.c | 2 +- > xen/arch/x86/hvm/domain.c | 2 +- > xen/arch/x86/hvm/grant_table.c | 2 +- > xen/arch/x86/hvm/hpet.c | 2 +- > xen/arch/x86/hvm/hvm.c | 2 +- > xen/arch/x86/hvm/hypercall.c | 2 +- > xen/arch/x86/hvm/intercept.c | 2 +- > xen/arch/x86/hvm/io.c | 2 +- > xen/arch/x86/hvm/ioreq.c | 2 +- > xen/arch/x86/hvm/irq.c | 2 +- > xen/arch/x86/hvm/monitor.c | 2 +- > xen/arch/x86/hvm/mtrr.c | 2 +- > xen/arch/x86/hvm/nestedhvm.c | 2 +- > xen/arch/x86/hvm/pmtimer.c | 2 +- > xen/arch/x86/hvm/quirks.c | 2 +- > xen/arch/x86/hvm/save.c | 2 +- > xen/arch/x86/hvm/svm/asid.c | 2 +- > xen/arch/x86/hvm/svm/emulate.c | 2 +- > xen/arch/x86/hvm/svm/entry.S | 2 +- > xen/arch/x86/hvm/svm/intr.c | 2 +- > xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- > xen/arch/x86/hvm/svm/svm.c | 2 +- > xen/arch/x86/hvm/svm/svmdebug.c | 2 +- > xen/arch/x86/hvm/svm/vmcb.c | 2 +- > xen/arch/x86/hvm/vioapic.c | 2 +- > xen/arch/x86/hvm/vlapic.c | 2 +- > xen/arch/x86/hvm/vm_event.c | 2 +- > xen/arch/x86/hvm/vmsi.c | 2 +- > xen/arch/x86/hvm/vmx/entry.S | 2 +- > xen/arch/x86/hvm/vmx/intr.c | 2 +- > xen/arch/x86/hvm/vmx/vmcs.c | 2 +- > xen/arch/x86/hvm/vmx/vmx.c | 2 +- > xen/arch/x86/hvm/vmx/vvmx.c | 2 +- > xen/arch/x86/hvm/vpt.c | 2 +- > xen/arch/x86/hypercall.c | 2 +- > xen/arch/x86/include/asm/acpi.h | 2 +- > xen/arch/x86/include/asm/altp2m.h | 2 +- > xen/arch/x86/include/asm/endbr.h | 2 +- > xen/arch/x86/include/asm/guest.h | 2 +- > xen/arch/x86/include/asm/guest/hyperv-hcall.h | 2 +- > xen/arch/x86/include/asm/guest/hyperv.h | 2 +- > xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- > xen/arch/x86/include/asm/guest/pvh-boot.h | 2 +- > xen/arch/x86/include/asm/guest/xen-hcall.h | 2 +- > xen/arch/x86/include/asm/guest/xen.h | 2 +- > xen/arch/x86/include/asm/guest_pt.h | 2 +- > xen/arch/x86/include/asm/hap.h | 2 +- > xen/arch/x86/include/asm/hvm/asid.h | 2 +- > xen/arch/x86/include/asm/hvm/domain.h | 2 +- > xen/arch/x86/include/asm/hvm/grant_table.h | 2 +- > xen/arch/x86/include/asm/hvm/hvm.h | 2 +- > xen/arch/x86/include/asm/hvm/io.h | 2 +- > xen/arch/x86/include/asm/hvm/ioreq.h | 2 +- > xen/arch/x86/include/asm/hvm/irq.h | 2 +- > xen/arch/x86/include/asm/hvm/monitor.h | 2 +- > xen/arch/x86/include/asm/hvm/nestedhvm.h | 2 +- > xen/arch/x86/include/asm/hvm/save.h | 2 +- > xen/arch/x86/include/asm/hvm/support.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/asid.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/emulate.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/intr.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/svm.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 2 +- > xen/arch/x86/include/asm/hvm/svm/vmcb.h | 2 +- > xen/arch/x86/include/asm/hvm/vcpu.h | 2 +- > xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- > xen/arch/x86/include/asm/hvm/vlapic.h | 2 +- > xen/arch/x86/include/asm/hvm/vm_event.h | 2 +- > xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 2 +- > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- > xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 2 +- > xen/arch/x86/include/asm/hvm/vpt.h | 2 +- > xen/arch/x86/include/asm/iommu.h | 2 +- > xen/arch/x86/include/asm/ioreq.h | 2 +- > xen/arch/x86/include/asm/mem_access.h | 2 +- > xen/arch/x86/include/asm/mem_paging.h | 2 +- > xen/arch/x86/include/asm/mem_sharing.h | 2 +- > xen/arch/x86/include/asm/monitor.h | 2 +- > xen/arch/x86/include/asm/p2m.h | 2 +- > xen/arch/x86/include/asm/paging.h | 2 +- > xen/arch/x86/include/asm/pv/domain.h | 2 +- > xen/arch/x86/include/asm/pv/grant_table.h | 2 +- > xen/arch/x86/include/asm/pv/mm.h | 2 +- > xen/arch/x86/include/asm/pv/shim.h | 2 +- > xen/arch/x86/include/asm/pv/traps.h | 2 +- > xen/arch/x86/include/asm/shadow.h | 2 +- > xen/arch/x86/include/asm/shstk.h | 2 +- > xen/arch/x86/include/asm/spec_ctrl.h | 2 +- > xen/arch/x86/include/asm/spec_ctrl_asm.h | 2 +- > xen/arch/x86/include/asm/traps.h | 2 +- > xen/arch/x86/include/asm/vm_event.h | 2 +- > xen/arch/x86/include/asm/vpmu.h | 2 +- > xen/arch/x86/include/asm/xenoprof.h | 2 +- > xen/arch/x86/mm.c | 2 +- > xen/arch/x86/mm/altp2m.c | 2 +- > xen/arch/x86/mm/guest_walk.c | 2 +- > xen/arch/x86/mm/hap/guest_walk.c | 2 +- > xen/arch/x86/mm/hap/hap.c | 2 +- > xen/arch/x86/mm/hap/nested_ept.c | 2 +- > xen/arch/x86/mm/hap/nested_hap.c | 2 +- > xen/arch/x86/mm/hap/private.h | 2 +- > xen/arch/x86/mm/mem_access.c | 2 +- > xen/arch/x86/mm/mem_paging.c | 2 +- > xen/arch/x86/mm/mem_sharing.c | 2 +- > xen/arch/x86/mm/mm-locks.h | 2 +- > xen/arch/x86/mm/nested.c | 2 +- > xen/arch/x86/mm/p2m-basic.c | 2 +- > xen/arch/x86/mm/p2m-ept.c | 2 +- > xen/arch/x86/mm/p2m-pod.c | 2 +- > xen/arch/x86/mm/p2m-pt.c | 2 +- > xen/arch/x86/mm/p2m.c | 2 +- > xen/arch/x86/mm/p2m.h | 2 +- > xen/arch/x86/mm/paging.c | 2 +- > xen/arch/x86/mm/physmap.c | 2 +- > xen/arch/x86/mm/shadow/common.c | 2 +- > xen/arch/x86/mm/shadow/hvm.c | 2 +- > xen/arch/x86/mm/shadow/multi.c | 2 +- > xen/arch/x86/mm/shadow/multi.h | 2 +- > xen/arch/x86/mm/shadow/private.h | 2 +- > xen/arch/x86/mm/shadow/pv.c | 2 +- > xen/arch/x86/mm/shadow/set.c | 2 +- > xen/arch/x86/mm/shadow/types.h | 2 +- > xen/arch/x86/monitor.c | 2 +- > xen/arch/x86/msr.c | 2 +- > xen/arch/x86/pv/callback.c | 2 +- > xen/arch/x86/pv/descriptor-tables.c | 2 +- > xen/arch/x86/pv/emul-gate-op.c | 2 +- > xen/arch/x86/pv/emul-inv-op.c | 2 +- > xen/arch/x86/pv/emul-priv-op.c | 2 +- > xen/arch/x86/pv/emulate.c | 2 +- > xen/arch/x86/pv/grant_table.c | 2 +- > xen/arch/x86/pv/hypercall.c | 2 +- > xen/arch/x86/pv/iret.c | 2 +- > xen/arch/x86/pv/misc-hypercalls.c | 2 +- > xen/arch/x86/pv/mm.c | 2 +- > xen/arch/x86/pv/ro-page-fault.c | 2 +- > xen/arch/x86/pv/shim.c | 2 +- > xen/arch/x86/pv/traps.c | 2 +- > xen/arch/x86/smpboot.c | 2 +- > xen/arch/x86/spec_ctrl.c | 2 +- > xen/arch/x86/traps.c | 2 +- > xen/arch/x86/vm_event.c | 2 +- > xen/arch/x86/x86_64/acpi_mmcfg.c | 2 +- > xen/arch/x86/x86_64/cpu_idle.c | 2 +- > xen/arch/x86/x86_64/cpufreq.c | 2 +- > xen/arch/x86/x86_64/gdbstub.c | 2 +- > xen/arch/x86/x86_64/mm.c | 2 +- > xen/arch/x86/x86_64/mmconfig.h | 2 +- > xen/arch/x86/x86_emulate/x86_emulate.c | 2 +- > xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- > xen/common/argo.c | 2 +- > xen/common/bunzip2.c | 2 +- > xen/common/coverage/coverage.c | 2 +- > xen/common/dm.c | 2 +- > xen/common/event_channel.c | 2 +- > xen/common/gdbstub.c | 2 +- > xen/common/grant_table.c | 2 +- > xen/common/ioreq.c | 2 +- > xen/common/libelf/libelf-dominfo.c | 2 +- > xen/common/libelf/libelf-loader.c | 2 +- > xen/common/libelf/libelf-private.h | 2 +- > xen/common/libelf/libelf-tools.c | 2 +- > xen/common/mem_access.c | 2 +- > xen/common/monitor.c | 2 +- > xen/common/page_alloc.c | 2 +- > xen/common/pdx.c | 2 +- > xen/common/preempt.c | 2 +- > xen/common/radix-tree.c | 2 +- > xen/common/rcupdate.c | 2 +- > xen/common/sched/null.c | 2 +- > xen/common/stop_machine.c | 2 +- > xen/common/time.c | 2 +- > xen/common/unlzma.c | 2 +- > xen/common/unlzo.c | 2 +- > xen/common/vm_event.c | 2 +- > xen/common/wait.c | 2 +- > xen/drivers/acpi/apei/apei-base.c | 2 +- > xen/drivers/acpi/apei/apei-io.c | 2 +- > xen/drivers/acpi/apei/erst.c | 2 +- > xen/drivers/acpi/apei/hest.c | 2 +- > xen/drivers/acpi/numa.c | 2 +- > xen/drivers/acpi/osl.c | 2 +- > xen/drivers/acpi/pmstat.c | 2 +- > xen/drivers/acpi/tables.c | 2 +- > xen/drivers/char/consoled.c | 2 +- > xen/drivers/char/meson-uart.c | 2 +- > xen/drivers/char/mvebu-uart.c | 2 +- > xen/drivers/char/xen_pv_console.c | 2 +- > xen/drivers/char/xhci-dbc.c | 2 +- > xen/drivers/cpufreq/cpufreq.c | 2 +- > xen/drivers/passthrough/amd/iommu-defs.h | 2 +- > xen/drivers/passthrough/amd/iommu.h | 2 +- > xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- > xen/drivers/passthrough/amd/iommu_cmd.c | 2 +- > xen/drivers/passthrough/amd/iommu_detect.c | 2 +- > xen/drivers/passthrough/amd/iommu_guest.c | 2 +- > xen/drivers/passthrough/amd/iommu_init.c | 2 +- > xen/drivers/passthrough/amd/iommu_intr.c | 2 +- > xen/drivers/passthrough/amd/iommu_map.c | 2 +- > xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- > xen/drivers/passthrough/arm/iommu_fwspec.c | 2 +- > xen/drivers/passthrough/arm/iommu_helpers.c | 2 +- > xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- > xen/drivers/passthrough/arm/smmu-v3.c | 2 +- > xen/drivers/passthrough/arm/smmu.c | 2 +- > xen/drivers/passthrough/ats.c | 2 +- > xen/drivers/passthrough/ats.h | 2 +- > xen/drivers/passthrough/iommu.c | 2 +- > xen/drivers/passthrough/pci.c | 2 +- > xen/drivers/passthrough/vtd/dmar.c | 2 +- > xen/drivers/passthrough/vtd/dmar.h | 2 +- > xen/drivers/passthrough/vtd/extern.h | 2 +- > xen/drivers/passthrough/vtd/intremap.c | 2 +- > xen/drivers/passthrough/vtd/iommu.c | 2 +- > xen/drivers/passthrough/vtd/iommu.h | 2 +- > xen/drivers/passthrough/vtd/qinval.c | 2 +- > xen/drivers/passthrough/vtd/quirks.c | 2 +- > xen/drivers/passthrough/vtd/utils.c | 2 +- > xen/drivers/passthrough/vtd/vtd.h | 2 +- > xen/drivers/passthrough/vtd/x86/ats.c | 2 +- > xen/drivers/passthrough/vtd/x86/hvm.c | 2 +- > xen/drivers/passthrough/vtd/x86/vtd.c | 2 +- > xen/drivers/passthrough/x86/hvm.c | 2 +- > xen/drivers/passthrough/x86/iommu.c | 2 +- > xen/drivers/vpci/header.c | 2 +- > xen/drivers/vpci/msi.c | 2 +- > xen/drivers/vpci/msix.c | 2 +- > xen/drivers/vpci/vpci.c | 2 +- > xen/include/xen/acpi.h | 2 +- > xen/include/xen/argo.h | 2 +- > xen/include/xen/atomic.h | 2 +- > xen/include/xen/cper.h | 2 +- > xen/include/xen/cpuidle.h | 2 +- > xen/include/xen/dm.h | 2 +- > xen/include/xen/gdbstub.h | 2 +- > xen/include/xen/grant_table.h | 2 +- > xen/include/xen/inttypes.h | 2 +- > xen/include/xen/iommu.h | 2 +- > xen/include/xen/ioreq.h | 2 +- > xen/include/xen/mem_access.h | 2 +- > xen/include/xen/monitor.h | 2 +- > xen/include/xen/multiboot.h | 2 +- > xen/include/xen/radix-tree.h | 2 +- > xen/include/xen/rbtree.h | 2 +- > xen/include/xen/rcupdate.h | 2 +- > xen/include/xen/vm_event.h | 2 +- > xen/lib/list-sort.c | 2 +- > xen/lib/rbtree.c | 2 +- > xen/xsm/silo.c | 2 +- > 606 files changed, 610 insertions(+), 610 deletions(-) > > diff --git a/m4/pkg.m4 b/m4/pkg.m4 > index bb59b15417268411e83f9ae6ba8fbe01faf2e38f..398cafe97b20c7a0ee74586b2ca247bc58e08570 100644 > --- a/m4/pkg.m4 > +++ b/m4/pkg.m4 > @@ -14,7 +14,7 @@ > # General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > # As a special exception to the GNU General Public License, if you > # distribute this file as part of a program that contains a > diff --git a/m4/systemd.m4 b/m4/systemd.m4 > index 112dc11b5e05e11d730e33a133c08527cfb4990f..a0a1b856aaa59fc4b97a9a90c88029953b878a2b 100644 > --- a/m4/systemd.m4 > +++ b/m4/systemd.m4 > @@ -13,7 +13,7 @@ > # General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > > dnl Some optional path options > AC_DEFUN([AX_SYSTEMD_OPTIONS], [ > diff --git a/stubdom/grub.patches/10graphics.diff b/stubdom/grub.patches/10graphics.diff > index 5ee2852fd7d7595c7fe17acbb6096ae96f04aaf4..5c1067ba9c31ada35086d8f2f4da989bfdfc7046 100644 > --- a/stubdom/grub.patches/10graphics.diff > +++ b/stubdom/grub.patches/10graphics.diff > @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c grub-0.97/stage2/graphics.c > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > -+ * along with this program; If not, see > ++ * along with this program; If not, see > + */ > + > +#ifdef SUPPORT_GRAPHICS > @@ -1769,7 +1769,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.h grub-0.97/stage2/graphics.h > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > -+ * along with this program; If not, see > ++ * along with this program; If not, see > + */ > + > +#ifndef GRAPHICS_H > diff --git a/stubdom/grub.patches/61btrfs.diff b/stubdom/grub.patches/61btrfs.diff > index ae8f866e509ef23ac3cb607651e56de193ef6c55..a96062e685e4f6a1922132e9ba6ee30abfd3c8aa 100644 > --- a/stubdom/grub.patches/61btrfs.diff > +++ b/stubdom/grub.patches/61btrfs.diff > @@ -70,7 +70,7 @@ diff -up /dev/null grub-upstream.wip/stage2/btrfs.h > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public > -+ * License along with this program; If not, see > ++ * License along with this program; If not, see > + */ > + > +/* include/asm-i386/types.h */ > @@ -1561,7 +1561,7 @@ diff -up /dev/null grub-upstream.wip/stage2/fsys_btrfs.c > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > -+ * along with this program. If not, see . > ++ * along with this program. If not, see . > + */ > + > +#ifdef FSYS_BTRFS > diff --git a/stubdom/vtpmmgr/tpmrsa.c b/stubdom/vtpmmgr/tpmrsa.c > index 7731640f6899dfde21106b0a34575b70ca25699d..5a9f6b29e5831a9fbd7f920c1c5edbc0d9ad60d5 100644 > --- a/stubdom/vtpmmgr/tpmrsa.c > +++ b/stubdom/vtpmmgr/tpmrsa.c > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > */ > /* > * RSA was designed by Ron Rivest, Adi Shamir and Len Adleman. > diff --git a/stubdom/vtpmmgr/tpmrsa.h b/stubdom/vtpmmgr/tpmrsa.h > index efeb5f2a21e4ac43b3cda417c0c8cea62052087c..45e1f72e4b816bb9c4c3c6b4055c522192c69ec8 100644 > --- a/stubdom/vtpmmgr/tpmrsa.h > +++ b/stubdom/vtpmmgr/tpmrsa.h > @@ -21,7 +21,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > */ > #ifndef TPMRSA_H > #define TPMRSA_H > diff --git a/tools/configure b/tools/configure > index f6f13bfdc0901b0cea125c5ac13208c92e7b7a0f..50d1abfe2b5579651fb1ef43db87ec8ceb109547 100755 > --- a/tools/configure > +++ b/tools/configure > @@ -3647,7 +3647,7 @@ esac > # General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > # As a special exception to the GNU General Public License, if you > # distribute this file as part of a program that contains a > @@ -3868,7 +3868,7 @@ esac > # General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > > > > diff --git a/tools/console/client/main.c b/tools/console/client/main.c > index 1a6fa162f750692e4affa33abecae1fd22031d4f..f694af558544d294a82c60c50739341d94038ae7 100644 > --- a/tools/console/client/main.c > +++ b/tools/console/client/main.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > \*/ > > #include > diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c > index 682c1f4008e0c984987e2e712c84175c923888b9..54b28dd29c69f6887171fd1e70b2dcbde41bb252 100644 > --- a/tools/console/daemon/io.c > +++ b/tools/console/daemon/io.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #define _GNU_SOURCE > diff --git a/tools/console/daemon/io.h b/tools/console/daemon/io.h > index d016addac896c6d6930495af2e9e4f19bc09abf5..8486cfaaed19604e21e1b36ed4e8a2cb55a316ff 100644 > --- a/tools/console/daemon/io.h > +++ b/tools/console/daemon/io.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > \*/ > > #ifndef CONSOLED_IO_H > diff --git a/tools/console/daemon/main.c b/tools/console/daemon/main.c > index aac7233a48c93e8542f8f8637445be592080fb3f..75643b8023fe6552ead2b5be15bc3c6c3ad12322 100644 > --- a/tools/console/daemon/main.c > +++ b/tools/console/daemon/main.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > \*/ > > #include > diff --git a/tools/console/daemon/utils.c b/tools/console/daemon/utils.c > index f9dd8a60c5c497c3dc2c9c5779b38bca547dd5a9..d609fb05198d98f55312a25f11ffd84b55c3b33e 100644 > --- a/tools/console/daemon/utils.c > +++ b/tools/console/daemon/utils.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > \*/ > > #include > diff --git a/tools/console/daemon/utils.h b/tools/console/daemon/utils.h > index a010ac44e0fa2c99be586fccdac66261c9a67992..e828fb7eef71753c4cefab220653bd463e155444 100644 > --- a/tools/console/daemon/utils.h > +++ b/tools/console/daemon/utils.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > \*/ > > #ifndef CONSOLED_UTILS_H > diff --git a/tools/debugger/gdbsx/gx/gx.h b/tools/debugger/gdbsx/gx/gx.h > index af3957587aab02396b393dff6428eb2204c46b1f..d3f7ef913a3b422428e210c61a10bf84c373fee4 100644 > --- a/tools/debugger/gdbsx/gx/gx.h > +++ b/tools/debugger/gdbsx/gx/gx.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > typedef uint16_t domid_t; > diff --git a/tools/debugger/gdbsx/gx/gx_comm.c b/tools/debugger/gdbsx/gx/gx_comm.c > index 5a0c61df4bd4d984aff33f5cda661ed075911b22..2a4967a78273580fecb7e114fb268744e088a770 100644 > --- a/tools/debugger/gdbsx/gx/gx_comm.c > +++ b/tools/debugger/gdbsx/gx/gx_comm.c > @@ -15,7 +15,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . */ > + along with this program; If not, see . */ > /* > * Copyright (C) 2009, Mukesh Rathor, Oracle Corp. All rights reserved. > * > @@ -29,7 +29,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > /* This module handles communication with remote gdb. courtesy > diff --git a/tools/debugger/gdbsx/gx/gx_local.c b/tools/debugger/gdbsx/gx/gx_local.c > index 023f5a391f43aa253411fde90e1559c23b869ac2..6af2d442fbae0382a5ec515607c95e4d46f81b74 100644 > --- a/tools/debugger/gdbsx/gx/gx_local.c > +++ b/tools/debugger/gdbsx/gx/gx_local.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > > diff --git a/tools/debugger/gdbsx/gx/gx_main.c b/tools/debugger/gdbsx/gx/gx_main.c > index 15de2c350135e76e965efe9b54c5224087c4266d..d9e556affa468f72fbe4eaebc4815db7881550a5 100644 > --- a/tools/debugger/gdbsx/gx/gx_main.c > +++ b/tools/debugger/gdbsx/gx/gx_main.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > /* This module is the main module for gdbsx implementation. gdbsx is a remote > diff --git a/tools/debugger/gdbsx/gx/gx_utils.c b/tools/debugger/gdbsx/gx/gx_utils.c > index f3c003960c4e407834468f2760bb4279a5121a92..428e2c24ad15af9468055df3fab6ad5c65d6df5c 100644 > --- a/tools/debugger/gdbsx/gx/gx_utils.c > +++ b/tools/debugger/gdbsx/gx/gx_utils.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/tools/debugger/gdbsx/gx/xg_dummy.c b/tools/debugger/gdbsx/gx/xg_dummy.c > index e995fad7d5d30ddf24034db70ec9ff603d50e2ae..b75bdfb724e5c4c6f9b8766f7cdc70a1912a6359 100644 > --- a/tools/debugger/gdbsx/gx/xg_dummy.c > +++ b/tools/debugger/gdbsx/gx/xg_dummy.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > #include > #include > diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c > index 4576c762af0c29521e75db5ba3355d89250a0047..2dfaec7df065002d128c24c2df1c81b3aa5212fc 100644 > --- a/tools/debugger/gdbsx/xg/xg_main.c > +++ b/tools/debugger/gdbsx/xg/xg_main.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > /* This is the main module to interface with xen. This module exports APIs that > diff --git a/tools/debugger/gdbsx/xg/xg_public.h b/tools/debugger/gdbsx/xg/xg_public.h > index 31513c817796897d22af915fbdb9a7d7d1587421..95fc6e11c2900c4182df658b068b250d043c8da6 100644 > --- a/tools/debugger/gdbsx/xg/xg_public.h > +++ b/tools/debugger/gdbsx/xg/xg_public.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #define XGERR(...) \ > diff --git a/tools/firmware/hvmloader/32bitbios_support.c b/tools/firmware/hvmloader/32bitbios_support.c > index cee3804888c447df7e952960312ad07023a07acc..7b76fb4fdb4ed685dfaf2b614d497c227f433d62 100644 > --- a/tools/firmware/hvmloader/32bitbios_support.c > +++ b/tools/firmware/hvmloader/32bitbios_support.c > @@ -17,7 +17,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile > index 4f31c881613ca5a5b44aa6afbe860daa1b3ee7a0..3d745c30d2c2074578afb4d99d91fd2e2f19dcdc 100644 > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefile > @@ -14,7 +14,7 @@ > # more details. > # > # You should have received a copy of the GNU General Public License along with > -# this program; If not, see . > +# this program; If not, see . > # > > XEN_ROOT = $(CURDIR)/../../.. > diff --git a/tools/firmware/hvmloader/cacheattr.c b/tools/firmware/hvmloader/cacheattr.c > index b7215fba2e0200228e063e2f7e16e79b6f916a52..3abf460eacd4859174156a1a9d40c3e5d168150a 100644 > --- a/tools/firmware/hvmloader/cacheattr.c > +++ b/tools/firmware/hvmloader/cacheattr.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "util.h" > diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c > index c490a0bc790c1e70912411f9b1cdf09e661dada2..427cde142b7f0ac74513392d5e966166ac6b0927 100644 > --- a/tools/firmware/hvmloader/e820.c > +++ b/tools/firmware/hvmloader/e820.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/hvmloader.c b/tools/firmware/hvmloader/hvmloader.c > index c58841e5b55624c6f50b2a2756b81e914295c3ea..417dec5cad20bcd2c6bfe83a50f68757f18b3070 100644 > --- a/tools/firmware/hvmloader/hvmloader.c > +++ b/tools/firmware/hvmloader/hvmloader.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "util.h" > diff --git a/tools/firmware/hvmloader/mp_tables.c b/tools/firmware/hvmloader/mp_tables.c > index d207ecbf00c9297c491fea8952a4a2f7215ccb9b..6acdd1be488557b0354d495833d18e95b9aa8a1f 100644 > --- a/tools/firmware/hvmloader/mp_tables.c > +++ b/tools/firmware/hvmloader/mp_tables.c > @@ -24,7 +24,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/tools/firmware/hvmloader/optionroms.c b/tools/firmware/hvmloader/optionroms.c > index 97080583cca7aba7269cc7e68feec4e5beab8990..2d57890724ac7394d3535d10199d0f60d6a2487e 100644 > --- a/tools/firmware/hvmloader/optionroms.c > +++ b/tools/firmware/hvmloader/optionroms.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c > index 23610a071797f143bb712e03df5e492d0e91a7a6..def5b9e41ea43c3de834117aaf361175ac476366 100644 > --- a/tools/firmware/hvmloader/ovmf.c > +++ b/tools/firmware/hvmloader/ovmf.c > @@ -18,7 +18,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/pci.c b/tools/firmware/hvmloader/pci.c > index 257a6feb6148c4d0cd3fa608cf4cc902251ee000..944afeb3b8b0ddb7998d04517921371884a57557 100644 > --- a/tools/firmware/hvmloader/pci.c > +++ b/tools/firmware/hvmloader/pci.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "util.h" > diff --git a/tools/firmware/hvmloader/pir_types.h b/tools/firmware/hvmloader/pir_types.h > index 5129b0c7fd9a087810a299ee8930f755814a263b..01e1bfbcf4d088269fd5dde97dbc729d5a0c7f1b 100644 > --- a/tools/firmware/hvmloader/pir_types.h > +++ b/tools/firmware/hvmloader/pir_types.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) Citrix Systems, 2011 > * > diff --git a/tools/firmware/hvmloader/rombios.c b/tools/firmware/hvmloader/rombios.c > index 46f331e465966d241f2a0e970ef3ab46adf24b31..6f9f2a59b5713dc6d86376d8ff3a449a145c04aa 100644 > --- a/tools/firmware/hvmloader/rombios.c > +++ b/tools/firmware/hvmloader/rombios.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/seabios.c b/tools/firmware/hvmloader/seabios.c > index 444d118ddb01451aac393ee1cb6fb23dcb1ba72d..33062f6f331292658444649875211318270b7607 100644 > --- a/tools/firmware/hvmloader/seabios.c > +++ b/tools/firmware/hvmloader/seabios.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/smbios.c b/tools/firmware/hvmloader/smbios.c > index 97a054e9e3fe9918aee64c036662334679e74a71..5547edfd127b8ce4d80ca1700d02e738f3c70d66 100644 > --- a/tools/firmware/hvmloader/smbios.c > +++ b/tools/firmware/hvmloader/smbios.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/hvmloader/smbios_types.h b/tools/firmware/hvmloader/smbios_types.h > index 3f1c120da60b6aa95cb2b6b1f03cc31d912832a4..c75cfee7028779b709d407f2b1e44d2e4b574e64 100644 > --- a/tools/firmware/hvmloader/smbios_types.h > +++ b/tools/firmware/hvmloader/smbios_types.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/hvmloader/smp.c b/tools/firmware/hvmloader/smp.c > index 082b17f138186c48e936f621d154955bf1dfe652..0f464517ab62ce80333a39c04e802501cc237d4c 100644 > --- a/tools/firmware/hvmloader/smp.c > +++ b/tools/firmware/hvmloader/smp.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "util.h" > diff --git a/tools/firmware/hvmloader/tests.c b/tools/firmware/hvmloader/tests.c > index a70c72dffbbb3922faae6cc2832fc8195018c0da..948cd360d71591d96571481599d7f0b0d7d7d78e 100644 > --- a/tools/firmware/hvmloader/tests.c > +++ b/tools/firmware/hvmloader/tests.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "config.h" > diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c > index 581b35e5cfb5ad1be1aa09e8536cfc3bd70c82ee..611a0603c7e3ed6278e0479eb0a9e0db90ec56f7 100644 > --- a/tools/firmware/hvmloader/util.c > +++ b/tools/firmware/hvmloader/util.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include "util.h" > diff --git a/tools/firmware/rombios/32bit/32bitbios.c b/tools/firmware/rombios/32bit/32bitbios.c > index 87acf209c3fdb6185910cd5e29e4b1538c59548f..39b141a23b3ad241b38b11fde33d14c89a766674 100644 > --- a/tools/firmware/rombios/32bit/32bitbios.c > +++ b/tools/firmware/rombios/32bit/32bitbios.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/rombios/32bit/mkhex b/tools/firmware/rombios/32bit/mkhex > index 7200d007e460021d1b25b6d3b29a34c08b82eb69..cfdd011c37d3e808a5a17b1d662b775acc22f7d4 100644 > --- a/tools/firmware/rombios/32bit/mkhex > +++ b/tools/firmware/rombios/32bit/mkhex > @@ -16,7 +16,7 @@ > # more details. > # > # You should have received a copy of the GNU General Public License along with > -# this program; If not, see . > +# this program; If not, see . > # > > echo "unsigned $1[] = {" > diff --git a/tools/firmware/rombios/32bit/pmm.c b/tools/firmware/rombios/32bit/pmm.c > index e0e39fef68a7b8d1695738e5e6f3c045c6dceaa4..49e603fd0297760b6efae70444ea975bc832a66a 100644 > --- a/tools/firmware/rombios/32bit/pmm.c > +++ b/tools/firmware/rombios/32bit/pmm.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) 2009 FUJITSU LIMITED > * > diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > index fa22c4460aac6f45aa67ceb991033c93b25a84fa..8da795ed4b642eec2d1e02953023fdec1625551f 100644 > --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c > index 59d16bbae6b422cd77d9faf719b4faad075d4ece..8897df75b21d364da9da58a498cc61d8e58295c8 100644 > --- a/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c > +++ b/tools/firmware/rombios/32bit/tcgbios/tpm_drivers.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/rombios/32bit/util.c b/tools/firmware/rombios/32bit/util.c > index 6c1c4805144bf520abe6545f70bb0720a709102b..e5f9acbadf19bf65d073a6aee0e32560d9d5b016 100644 > --- a/tools/firmware/rombios/32bit/util.c > +++ b/tools/firmware/rombios/32bit/util.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #include > #include > diff --git a/tools/firmware/rombios/32bitgateway.c b/tools/firmware/rombios/32bitgateway.c > index 3d58a6b0a1cdd8b6b8a24bb7da1ea1d236597345..9f28ea3b5d27e7dc585039f0355dcc1a17469835 100644 > --- a/tools/firmware/rombios/32bitgateway.c > +++ b/tools/firmware/rombios/32bitgateway.c > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * Copyright (c) 2008, Citrix Systems, Inc. > diff --git a/tools/firmware/rombios/apmbios.S b/tools/firmware/rombios/apmbios.S > index 814be8fd57eba8998a177c3ebd757de557c92599..9dd6b3390eab5a679771de429f893362b20c4b75 100644 > --- a/tools/firmware/rombios/apmbios.S > +++ b/tools/firmware/rombios/apmbios.S > @@ -15,7 +15,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > > #if defined(APM_REAL) > #define APMSYM(s) apmreal_ ## s > diff --git a/tools/firmware/rombios/rombios.c b/tools/firmware/rombios/rombios.c > index 52ba4a988f262f41b6d98ce41cca791db13c21be..1e08e16826a182d3defa114db01843e7d9134991 100644 > --- a/tools/firmware/rombios/rombios.c > +++ b/tools/firmware/rombios/rombios.c > @@ -21,7 +21,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > > // ROM BIOS for use with Bochs/Plex86/QEMU emulation environment > > diff --git a/tools/firmware/rombios/rombios.h b/tools/firmware/rombios/rombios.h > index 8726d37737b4f980311a2695156b34c42af16fa2..a3849de73d096d570dbd160eec0a484bf30ff57f 100644 > --- a/tools/firmware/rombios/rombios.h > +++ b/tools/firmware/rombios/rombios.h > @@ -15,7 +15,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > > /* define it to include QEMU specific code */ > //#define BX_QEMU > diff --git a/tools/firmware/rombios/tcgbios.c b/tools/firmware/rombios/tcgbios.c > index e725ef9d1bdc3b995044e2a27bbfbc399dbd8e5c..8f5ab34bce24199d6922d11a4d3a6f6484833773 100644 > --- a/tools/firmware/rombios/tcgbios.c > +++ b/tools/firmware/rombios/tcgbios.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) IBM Corporation, 2006 > * > diff --git a/tools/firmware/vgabios/COPYING b/tools/firmware/vgabios/COPYING > index 05956269987638868d4aea655e8fd4c9d5b6ecd5..8b44515327c654405640f624ea7de292302a431c 100644 > --- a/tools/firmware/vgabios/COPYING > +++ b/tools/firmware/vgabios/COPYING > @@ -484,7 +484,7 @@ convey the exclusion of warranty; and each file should have at least the > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > > Also add information on how to contact you by electronic and paper mail. > > diff --git a/tools/firmware/vgabios/biossums.c b/tools/firmware/vgabios/biossums.c > index 85ecc04e1665c6c3902a95f4687859513cc6e358..144467ae327e403a547fa8174db0fd760ddf6b15 100644 > --- a/tools/firmware/vgabios/biossums.c > +++ b/tools/firmware/vgabios/biossums.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #include > #include > diff --git a/tools/firmware/vgabios/clext.c b/tools/firmware/vgabios/clext.c > index d727cd59f270d6658c1bc0dee82eff40ceff0074..c6b1fcbad1505a27fb8e1c131c1c7994e24fa7be 100644 > --- a/tools/firmware/vgabios/clext.c > +++ b/tools/firmware/vgabios/clext.c > @@ -14,7 +14,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > // > > //#define CIRRUS_VESA3_PMINFO > diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c > index 8e6408733ae68bdc582054ee58778c03f180b220..2bda60d1aefe1c4922b07efa975b3d0932dc0426 100644 > --- a/tools/firmware/vgabios/vbe.c > +++ b/tools/firmware/vgabios/vbe.c > @@ -13,7 +13,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > // > // ============================================================================================ > // > diff --git a/tools/firmware/vgabios/vgabios.c b/tools/firmware/vgabios/vgabios.c > index 3ad98ca254a4ce8e7359a8a2d1a259b098ab927b..9b96029f09b89adfda25dc021194c70ce4591644 100644 > --- a/tools/firmware/vgabios/vgabios.c > +++ b/tools/firmware/vgabios/vgabios.c > @@ -17,7 +17,7 @@ > // Lesser General Public License for more details. > // > // You should have received a copy of the GNU Lesser General Public > -// License along with this library; If not, see . > +// License along with this library; If not, see . > // > // ============================================================================================ > // > diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go > index a45c636952520823f3c13a314e476cdbf4e1629f..a456518e8339446e40edf971c0231a90ae0f5fe2 100644 > --- a/tools/golang/xenlight/xenlight.go > +++ b/tools/golang/xenlight/xenlight.go > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > // Package xenlight provides bindings to Xen's libxl C library. > diff --git a/tools/hotplug/Linux/block-common.sh b/tools/hotplug/Linux/block-common.sh > index f86a88c4ebce21036a3e029223099ef9501fad21..de57b642546f95251d8e3ebbebd63279aa025a91 100644 > --- a/tools/hotplug/Linux/block-common.sh > +++ b/tools/hotplug/Linux/block-common.sh > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > > diff --git a/tools/hotplug/Linux/block-drbd-probe b/tools/hotplug/Linux/block-drbd-probe > index 7b2968b6d944ea7222b79b1acda8c5f0dab8ab23..fca46fb32c5fb94bf07fe3b8363e2bdea3f6ccf8 100755 > --- a/tools/hotplug/Linux/block-drbd-probe > +++ b/tools/hotplug/Linux/block-drbd-probe > @@ -12,7 +12,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > # Usage: > # block-drbd-probe devicename > diff --git a/tools/hotplug/Linux/external-device-migrate b/tools/hotplug/Linux/external-device-migrate > index f5942a6a954fc1ac9f21974f0e2a70a4d8dd3dbd..68eaac145bec13de5ce038e882d62ce14fa79fbb 100644 > --- a/tools/hotplug/Linux/external-device-migrate > +++ b/tools/hotplug/Linux/external-device-migrate > @@ -12,7 +12,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > set -x > diff --git a/tools/hotplug/Linux/launch-xenstore.in b/tools/hotplug/Linux/launch-xenstore.in > index e854ca1eb8957f616122a6d96b88bb891142318d..5028d1d09f4da30d458f354687488da002c94905 100644 > --- a/tools/hotplug/Linux/launch-xenstore.in > +++ b/tools/hotplug/Linux/launch-xenstore.in > @@ -12,7 +12,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > XENSTORED=@XENSTORED@ > diff --git a/tools/hotplug/Linux/locking.sh b/tools/hotplug/Linux/locking.sh > index 2e6fb35f02785c7a2c5a164df417f47659f829bd..13fb7134c6b6a20f7de2be4394406377abdb8167 100644 > --- a/tools/hotplug/Linux/locking.sh > +++ b/tools/hotplug/Linux/locking.sh > @@ -12,7 +12,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > # > diff --git a/tools/hotplug/Linux/logging.sh b/tools/hotplug/Linux/logging.sh > index 3e94df1a9e900d1b2b368568e2400063882f74eb..b7ed7b292dd54f4ff085eb2fe9cdf346c9ec1c33 100644 > --- a/tools/hotplug/Linux/logging.sh > +++ b/tools/hotplug/Linux/logging.sh > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > log() { > diff --git a/tools/hotplug/Linux/vif-common.sh b/tools/hotplug/Linux/vif-common.sh > index a8e65178f9074390eb6a1bdf5b1f741fffac66ad..43ea7bbf775fb4688ef9849ca5805facaaa7cd47 100644 > --- a/tools/hotplug/Linux/vif-common.sh > +++ b/tools/hotplug/Linux/vif-common.sh > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > > diff --git a/tools/hotplug/Linux/xen-hotplug-common.sh.in b/tools/hotplug/Linux/xen-hotplug-common.sh.in > index 8c2cb9e25a1a401cf4dc366e2cdcb45eb59cf95a..9e5207fee85f39248b8cd12ec52c8dddb2a7e922 100644 > --- a/tools/hotplug/Linux/xen-hotplug-common.sh.in > +++ b/tools/hotplug/Linux/xen-hotplug-common.sh.in > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > dir=$(dirname "$0") > diff --git a/tools/hotplug/Linux/xen-network-common.sh b/tools/hotplug/Linux/xen-network-common.sh > index 42fa704e8d40f683ed3a7d3562b7c9685b7f804c..89542b2b9ac0bc8b0089bf05d9e3251c3c0ba6ef 100644 > --- a/tools/hotplug/Linux/xen-network-common.sh > +++ b/tools/hotplug/Linux/xen-network-common.sh > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > > diff --git a/tools/hotplug/Linux/xen-script-common.sh b/tools/hotplug/Linux/xen-script-common.sh > index 370a50a3cd9849e9348be5934b12d21d3f7b05d0..a8d36414df691e6d729b3011aea598c5fa03d110 100644 > --- a/tools/hotplug/Linux/xen-script-common.sh > +++ b/tools/hotplug/Linux/xen-script-common.sh > @@ -11,7 +11,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > > diff --git a/tools/hotplug/NetBSD/locking.sh b/tools/hotplug/NetBSD/locking.sh > index 2098d0e3ab6ed60c9b52acf2d36f67dde8550e0b..4a63fb2e1c77dc98bdb8cafc40dca7cd8c1f4c50 100644 > --- a/tools/hotplug/NetBSD/locking.sh > +++ b/tools/hotplug/NetBSD/locking.sh > @@ -12,7 +12,7 @@ > # Lesser General Public License for more details. > # > # You should have received a copy of the GNU Lesser General Public > -# License along with this library; If not, see . > +# License along with this library; If not, see . > # > > # > diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h > index ad771866e44321f6c880733a3df8e9315c2b348e..049e334426855661c3487d7fbfc3eec64b2655c5 100644 > --- a/tools/include/libxenvchan.h > +++ b/tools/include/libxenvchan.h > @@ -21,7 +21,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/include/xencall.h b/tools/include/xencall.h > index fc95ed0fe58eea7fb7830458fe6207bce610d63a..e577b927b8e6e4091dd9e6bf35d57952ea96f410 100644 > --- a/tools/include/xencall.h > +++ b/tools/include/xencall.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #ifndef XENCALL_H > #define XENCALL_H > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 23037874d3d5a01ddf55766088bf782393a9c483..fc0c72ae0265e610047b9a8fd950973e34198e2f 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENCTRL_H > diff --git a/tools/include/xendevicemodel.h b/tools/include/xendevicemodel.h > index 797e0c6b2961926a68cd96b8ff5e1627067903ac..58dbb1bdda2fb8a9ee237ed20e0ecf1c09abe42e 100644 > --- a/tools/include/xendevicemodel.h > +++ b/tools/include/xendevicemodel.h > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #ifndef XENDEVICEMODEL_H > #define XENDEVICEMODEL_H > diff --git a/tools/include/xenevtchn.h b/tools/include/xenevtchn.h > index 1255c85178d2d5049aa2406c5be1b7932bec728d..51fbc42eb0598f95015a6754636ce70e9d20aba8 100644 > --- a/tools/include/xenevtchn.h > +++ b/tools/include/xenevtchn.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split off from: > * xenctrl.h > diff --git a/tools/include/xenforeignmemory.h b/tools/include/xenforeignmemory.h > index 0ab1dd19d3b56db4a9dccd784d54919d390b47a9..eb897603862d519dcd40ecff6c9e8be8d1810222 100644 > --- a/tools/include/xenforeignmemory.h > +++ b/tools/include/xenforeignmemory.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #ifndef XENFOREIGNMEMORY_H > #define XENFOREIGNMEMORY_H > diff --git a/tools/include/xengnttab.h b/tools/include/xengnttab.h > index 111fc88caeb3ef1186f6a3d0051688ceed14dc5c..188c7a9fdb8bdc4f1bad6b6ed7656f1921a0142d 100644 > --- a/tools/include/xengnttab.h > +++ b/tools/include/xengnttab.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split off from: > * xenctrl.h > diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h > index e01f494b772a4800fbd8d9d7ced8b45a811e8219..f8e248c5a2e30486a78e1207dd36b96159ce211e 100644 > --- a/tools/include/xenguest.h > +++ b/tools/include/xenguest.h > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENGUEST_H > diff --git a/tools/include/xenhypfs.h b/tools/include/xenhypfs.h > index 25432d2a1657d8a59b04ffdefca6d7ee1734cf55..7818198ee184c9c8c8fa2e5a50272cc4bb360b64 100644 > --- a/tools/include/xenhypfs.h > +++ b/tools/include/xenhypfs.h > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #ifndef XENHYPFS_H > #define XENHYPFS_H > diff --git a/tools/include/xenstore.h b/tools/include/xenstore.h > index 2b3f69fb61d3434f00dbc7870739258c81882d2a..c72e66e513720ebee2b11bcf901c3f9ba7af1416 100644 > --- a/tools/include/xenstore.h > +++ b/tools/include/xenstore.h > @@ -13,7 +13,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #ifndef XENSTORE_H > diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h > index 2266009ec12410b07b8109b185c6c5d40b3b8771..7fd536234a937ff87d147abe34a0d67c905faa1f 100644 > --- a/tools/include/xenstore_lib.h > +++ b/tools/include/xenstore_lib.h > @@ -13,7 +13,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #ifndef XENSTORE_LIB_H > diff --git a/tools/include/xentoolcore.h b/tools/include/xentoolcore.h > index b3a3c934e28314a9f0d2856376916a0d5eb8c00e..3ff9dd6dbbcbdd9a3c3f5067aec1ccfd1e7921a6 100644 > --- a/tools/include/xentoolcore.h > +++ b/tools/include/xentoolcore.h > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENTOOLCORE_H > diff --git a/tools/include/xentoolcore_internal.h b/tools/include/xentoolcore_internal.h > index 1be014434d32f399de1ba3bcc9fcbb7f61c08749..be67c5fb7f41232cb1644751b4b9b9dc3b99039c 100644 > --- a/tools/include/xentoolcore_internal.h > +++ b/tools/include/xentoolcore_internal.h > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENTOOLCORE_INTERNAL_H > diff --git a/tools/include/xentoollog.h b/tools/include/xentoollog.h > index 76f17fe125d103af9ba587cb56fb147a23b5e615..817db123dd3136409f7a190fcdca56896b0342ec 100644 > --- a/tools/include/xentoollog.h > +++ b/tools/include/xentoollog.h > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENTOOLLOG_H > diff --git a/tools/libfsimage/ext2fs/fsys_ext2fs.c b/tools/libfsimage/ext2fs/fsys_ext2fs.c > index 5ed8fce90ef1dd663862f085865c7050a0eb9524..019bbffb475098158bb9798894e6a416b96a10a6 100644 > --- a/tools/libfsimage/ext2fs/fsys_ext2fs.c > +++ b/tools/libfsimage/ext2fs/fsys_ext2fs.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/libfsimage/fat/fat.h b/tools/libfsimage/fat/fat.h > index 2abb43084f47fa83e628ea01e237efd4d797bdd6..e9f535ce8827ef61851cfbfebd8e4242692d7146 100644 > --- a/tools/libfsimage/fat/fat.h > +++ b/tools/libfsimage/fat/fat.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/tools/libfsimage/fat/fsys_fat.c b/tools/libfsimage/fat/fsys_fat.c > index b89354a8721b280045a91a7b15151c1fe0380438..f540c6413339da4f1c23f95d4e856a4952937a46 100644 > --- a/tools/libfsimage/fat/fsys_fat.c > +++ b/tools/libfsimage/fat/fsys_fat.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/libfsimage/iso9660/fsys_iso9660.c b/tools/libfsimage/iso9660/fsys_iso9660.c > index 6e767357bfdc2e35d7aa788977280218e1937aa5..15cde87307e842af4a1fa09e314dd3b38473bfa4 100644 > --- a/tools/libfsimage/iso9660/fsys_iso9660.c > +++ b/tools/libfsimage/iso9660/fsys_iso9660.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * References: > diff --git a/tools/libfsimage/iso9660/iso9660.h b/tools/libfsimage/iso9660/iso9660.h > index 4ea9b3eed36a416c0faaaceb12f345da318cd7b7..6ac443e6dcc91f86b33c5420a2d32591f7d1b58f 100644 > --- a/tools/libfsimage/iso9660/iso9660.h > +++ b/tools/libfsimage/iso9660/iso9660.h > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * References: > diff --git a/tools/libfsimage/reiserfs/fsys_reiserfs.c b/tools/libfsimage/reiserfs/fsys_reiserfs.c > index 299b257e999426547199753508fcf76f1d440ed7..a83b69a059e1fec3b73c171fef66690310303c56 100644 > --- a/tools/libfsimage/reiserfs/fsys_reiserfs.c > +++ b/tools/libfsimage/reiserfs/fsys_reiserfs.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/libfsimage/ufs/fsys_ufs.c b/tools/libfsimage/ufs/fsys_ufs.c > index a545bc9f65e82748c931f6f30a1c8c9abf0a712d..3f6ff873078656f914e2a0ccb9398f55365fcd81 100644 > --- a/tools/libfsimage/ufs/fsys_ufs.c > +++ b/tools/libfsimage/ufs/fsys_ufs.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2006 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/xfs/fsys_xfs.c b/tools/libfsimage/xfs/fsys_xfs.c > index d735a88e55f3ac30b11ba7e5fe6a8a07b97bce0c..a8d8f249ad2cb1bbf53ab2fdb5bdbf5779ca433b 100644 > --- a/tools/libfsimage/xfs/fsys_xfs.c > +++ b/tools/libfsimage/xfs/fsys_xfs.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/libfsimage/xfs/xfs.h b/tools/libfsimage/xfs/xfs.h > index e9f93531d82aa12264ef3b4c8bbc8f56d9c7d58f..5d3c19d6883140ddd3c3426c6f7dd5555c7d5b99 100644 > --- a/tools/libfsimage/xfs/xfs.h > +++ b/tools/libfsimage/xfs/xfs.h > @@ -20,7 +20,7 @@ > * other software, or any other product whatsoever. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * Contact information: Silicon Graphics, Inc., 1600 Amphitheatre Pkwy, > * Mountain View, CA 94043, or: > diff --git a/tools/libfsimage/zfs/Makefile b/tools/libfsimage/zfs/Makefile > index 434a9c3580e6ab029f0b54779decfd8107a08f10..b8cbca7f1a9da28b79cc0f855b23389f8364ad1e 100644 > --- a/tools/libfsimage/zfs/Makefile > +++ b/tools/libfsimage/zfs/Makefile > @@ -13,7 +13,7 @@ > # GNU General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > > # > diff --git a/tools/libfsimage/zfs/filesys.h b/tools/libfsimage/zfs/filesys.h > index 36cc720709f7b238e1aa746afeabf6b961cda1c0..c1f64eb282034965cb329bf6a1b6a92adfd7bd00 100644 > --- a/tools/libfsimage/zfs/filesys.h > +++ b/tools/libfsimage/zfs/filesys.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/fsi_zfs.c b/tools/libfsimage/zfs/fsi_zfs.c > index 187a8bc6b2d9502cd20a6306f98d75c9e8f9a939..bd24a5e7c84afcb8f2d993a7ca4e65717c1d4a8c 100644 > --- a/tools/libfsimage/zfs/fsi_zfs.c > +++ b/tools/libfsimage/zfs/fsi_zfs.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/fsi_zfs.h b/tools/libfsimage/zfs/fsi_zfs.h > index 980ce8f30478f0707146cac2d2ba4b1e160d4c5d..e3b4a8116e386c16f504cd7fb87344461a549cbf 100644 > --- a/tools/libfsimage/zfs/fsi_zfs.h > +++ b/tools/libfsimage/zfs/fsi_zfs.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/fsys_zfs.c b/tools/libfsimage/zfs/fsys_zfs.c > index e881fbb09ba9311e1e3001f148244e5416d61e16..941068b1339242b6b8a6e8f5710495bce3a46b84 100644 > --- a/tools/libfsimage/zfs/fsys_zfs.c > +++ b/tools/libfsimage/zfs/fsys_zfs.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/fsys_zfs.h b/tools/libfsimage/zfs/fsys_zfs.h > index b4be51b50d1f3411f43f14ccc956bb80e21a920e..14595dffa998da725e39fa24e9ab0fb49e05cfbf 100644 > --- a/tools/libfsimage/zfs/fsys_zfs.h > +++ b/tools/libfsimage/zfs/fsys_zfs.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/mb_info.h b/tools/libfsimage/zfs/mb_info.h > index 16e9013f58b3f28b3c2cd3a211f0eb6c265d1451..2c68dbea43d9259152cf20b69fe628d8217dfabe 100644 > --- a/tools/libfsimage/zfs/mb_info.h > +++ b/tools/libfsimage/zfs/mb_info.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* > diff --git a/tools/libfsimage/zfs/shared.h b/tools/libfsimage/zfs/shared.h > index e4a239abe19c130ea2e48c6a8d7fb16079fd4dd7..55ffefce2020a00d2e74c859ad7bdb874904173d 100644 > --- a/tools/libfsimage/zfs/shared.h > +++ b/tools/libfsimage/zfs/shared.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/dmu.h b/tools/libfsimage/zfs/zfs-include/dmu.h > index b39a951cf7c9725b9198bbd2876fd31080f90ee3..d37b02f04eadc6316dcd2dc5fca4c7d9f92d2e0e 100644 > --- a/tools/libfsimage/zfs/zfs-include/dmu.h > +++ b/tools/libfsimage/zfs/zfs-include/dmu.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/dmu_objset.h b/tools/libfsimage/zfs/zfs-include/dmu_objset.h > index 2680fcf1bd8082e2e6f78997b35dcb4b6c35ef48..8a9c6ae3bf85f29055b1a8bddeb9ed68958d0e0f 100644 > --- a/tools/libfsimage/zfs/zfs-include/dmu_objset.h > +++ b/tools/libfsimage/zfs/zfs-include/dmu_objset.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2009 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/dnode.h b/tools/libfsimage/zfs/zfs-include/dnode.h > index dd90a8779c70074dfcce14e61ad94e069f42eb35..49bfb54fc3feae4f7e02be6e94b3dc5f2396d135 100644 > --- a/tools/libfsimage/zfs/zfs-include/dnode.h > +++ b/tools/libfsimage/zfs/zfs-include/dnode.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h > index 470b60758840438cc8f655ece37311f1793f23bf..8ac92c60bcdbe1494568370d5d38475013899fc9 100644 > --- a/tools/libfsimage/zfs/zfs-include/dsl_dataset.h > +++ b/tools/libfsimage/zfs/zfs-include/dsl_dataset.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/dsl_dir.h b/tools/libfsimage/zfs/zfs-include/dsl_dir.h > index 0e71b6b4808ed847560b2b62e0bbe3c865ebe521..e25bc139f3d94ed993c64992889a264eeb824a69 100644 > --- a/tools/libfsimage/zfs/zfs-include/dsl_dir.h > +++ b/tools/libfsimage/zfs/zfs-include/dsl_dir.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/sa_impl.h b/tools/libfsimage/zfs/zfs-include/sa_impl.h > index 0679c93f2999d951adafa477be6e72975884995b..a9af9024194cda52d7a75c98faface583a5c847e 100644 > --- a/tools/libfsimage/zfs/zfs-include/sa_impl.h > +++ b/tools/libfsimage/zfs/zfs-include/sa_impl.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/spa.h b/tools/libfsimage/zfs/zfs-include/spa.h > index ee708ef60bdc355e9d895967e00b277c3a897bf5..ba35ab740a4a8086830335fdcf920a3c910da11b 100644 > --- a/tools/libfsimage/zfs/zfs-include/spa.h > +++ b/tools/libfsimage/zfs/zfs-include/spa.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h > index 282d3b92827c70e4982530608b0ce0a028cf1ca2..2f879666cbd7e3c4b8fb0bf55cca91b8cea71bc0 100644 > --- a/tools/libfsimage/zfs/zfs-include/uberblock_impl.h > +++ b/tools/libfsimage/zfs/zfs-include/uberblock_impl.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/vdev_impl.h b/tools/libfsimage/zfs/zfs-include/vdev_impl.h > index f3823b298d134379483b8c8e196c9fe196617e93..fe69c31fb9e51d0c64b3dea25276510adc768c92 100644 > --- a/tools/libfsimage/zfs/zfs-include/vdev_impl.h > +++ b/tools/libfsimage/zfs/zfs-include/vdev_impl.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zap_impl.h b/tools/libfsimage/zfs/zfs-include/zap_impl.h > index 7adfc347c3a15dc89d97510827468a02fb2643da..44fedf9f665722da05c6b6adc54da251f7f989cc 100644 > --- a/tools/libfsimage/zfs/zfs-include/zap_impl.h > +++ b/tools/libfsimage/zfs/zfs-include/zap_impl.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2009 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zap_leaf.h b/tools/libfsimage/zfs/zfs-include/zap_leaf.h > index ecf3faacb6407856e247521012242aff0e8fb2ee..9517d055f2d5b107faf081b80642604a1bb3853c 100644 > --- a/tools/libfsimage/zfs/zfs-include/zap_leaf.h > +++ b/tools/libfsimage/zfs/zfs-include/zap_leaf.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zfs.h b/tools/libfsimage/zfs/zfs-include/zfs.h > index 592d23a768d1ded2d521a1135f791888bef3ae5f..0f0e2552051ed291797febd690f6782599ae467d 100644 > --- a/tools/libfsimage/zfs/zfs-include/zfs.h > +++ b/tools/libfsimage/zfs/zfs-include/zfs.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zfs_acl.h b/tools/libfsimage/zfs/zfs-include/zfs_acl.h > index 6a685e0536711617abe5ba770fc9b89666ea109c..e0f458b68a9d4b0ce9914b78f806956eb5831bf4 100644 > --- a/tools/libfsimage/zfs/zfs-include/zfs_acl.h > +++ b/tools/libfsimage/zfs/zfs-include/zfs_acl.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zfs_znode.h b/tools/libfsimage/zfs/zfs-include/zfs_znode.h > index 902c4972caf61fab31de2d7ec08beefcc5f509ef..a46f7d765422a7f1abcb4f638601717a6255f5ed 100644 > --- a/tools/libfsimage/zfs/zfs-include/zfs_znode.h > +++ b/tools/libfsimage/zfs/zfs-include/zfs_znode.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zil.h b/tools/libfsimage/zfs/zfs-include/zil.h > index f34173c36b1859d20958f1a8d6913163b0dbb666..ec70d71ad3d42db0d7bf91c37a9f03b027b2f10f 100644 > --- a/tools/libfsimage/zfs/zfs-include/zil.h > +++ b/tools/libfsimage/zfs/zfs-include/zil.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2009 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zio.h b/tools/libfsimage/zfs/zfs-include/zio.h > index 513f321f9a82584acacbde1620b60d954bcdcb5e..c9dce12271379196bcab6e64562a6db132daaba1 100644 > --- a/tools/libfsimage/zfs/zfs-include/zio.h > +++ b/tools/libfsimage/zfs/zfs-include/zio.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs-include/zio_checksum.h b/tools/libfsimage/zfs/zfs-include/zio_checksum.h > index 5f22f29995765835586b0baadfb9410a5ffdca84..b9864ee32722e317abc774f2c2fb91ab6e54f26c 100644 > --- a/tools/libfsimage/zfs/zfs-include/zio_checksum.h > +++ b/tools/libfsimage/zfs/zfs-include/zio_checksum.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2010 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs_fletcher.c b/tools/libfsimage/zfs/zfs_fletcher.c > index cc9e8c4954d46eb47ce4321b05e1bddc7f61fc89..368beed6b06f329d631d60def1656e7503d50f21 100644 > --- a/tools/libfsimage/zfs/zfs_fletcher.c > +++ b/tools/libfsimage/zfs/zfs_fletcher.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs_lzjb.c b/tools/libfsimage/zfs/zfs_lzjb.c > index 0b11eee63af1b584feb1d7aab8365c0319a61584..f904e0b7dc4590411274b55e464adeefc94a1af7 100644 > --- a/tools/libfsimage/zfs/zfs_lzjb.c > +++ b/tools/libfsimage/zfs/zfs_lzjb.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libfsimage/zfs/zfs_sha256.c b/tools/libfsimage/zfs/zfs_sha256.c > index 18a5c05008ef4a5f5b2cec57e343ed8ea1f9ccfe..9a5b4af54e3c0f7da8c685d700a41fdc09e536a5 100644 > --- a/tools/libfsimage/zfs/zfs_sha256.c > +++ b/tools/libfsimage/zfs/zfs_sha256.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > /* > * Copyright 2007 Sun Microsystems, Inc. All rights reserved. > diff --git a/tools/libs/call/buffer.c b/tools/libs/call/buffer.c > index 085674d882ae5d031460f26451f48a3da790e549..34d0c90c58ce57125fda700571999122b2918269 100644 > --- a/tools/libs/call/buffer.c > +++ b/tools/libs/call/buffer.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/call/core.c b/tools/libs/call/core.c > index 02c4f8e1aefa9a87846daf0ae811cc91e12a0c00..ae82ff9535d870ce764242d21b5325eaa663b2b8 100644 > --- a/tools/libs/call/core.c > +++ b/tools/libs/call/core.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/call/freebsd.c b/tools/libs/call/freebsd.c > index 6d2e8704b3de549f8e3e6e1de158138fc0c8ef11..20ec28a564684cdec8fb49f4ec21a7fb5b7fcd63 100644 > --- a/tools/libs/call/freebsd.c > +++ b/tools/libs/call/freebsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split from xc_freebsd_osdep.c > */ > diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c > index 6d588e6bea8fab3e2dfe18966d95ae09c14899c3..65d5a764689d998f02adaa389b2be7ba4d25ac1e 100644 > --- a/tools/libs/call/linux.c > +++ b/tools/libs/call/linux.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_linus_osdep.c: > * > diff --git a/tools/libs/call/minios.c b/tools/libs/call/minios.c > index 3f33b8357829cc632f8775eda46e1a15699f0d5a..9b1435ca11494eb7600d52d520a537ae4d5910fe 100644 > --- a/tools/libs/call/minios.c > +++ b/tools/libs/call/minios.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_minios.c > * > diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c > index 91ae68357e3ef7b973499c7621515bb4150c61bb..e27c0f32d7a40b9287593b56f3a8a78e0497c970 100644 > --- a/tools/libs/call/netbsd.c > +++ b/tools/libs/call/netbsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split from xc_netbsd.c > */ > diff --git a/tools/libs/call/solaris.c b/tools/libs/call/solaris.c > index 304262bd057b37e9724cf9e177b20e1b70e9dcde..b79102fe996e19e4f605aec0862075442ec733a4 100644 > --- a/tools/libs/call/solaris.c > +++ b/tools/libs/call/solaris.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split from xc_solaris.c > */ > diff --git a/tools/libs/ctrl/xc_altp2m.c b/tools/libs/ctrl/xc_altp2m.c > index 6987c9541fd15cacb9880fb8f73763f63b023db7..cad63f74a1c922dcde6a0322387f3dc26e5a8de8 100644 > --- a/tools/libs/ctrl/xc_altp2m.c > +++ b/tools/libs/ctrl/xc_altp2m.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_cpu_hotplug.c b/tools/libs/ctrl/xc_cpu_hotplug.c > index 2ea98257792ba0b10330de492e96c4b73860d7a8..9f3916300000a63703abee19f214c112383764f5 100644 > --- a/tools/libs/ctrl/xc_cpu_hotplug.c > +++ b/tools/libs/ctrl/xc_cpu_hotplug.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > */ > > diff --git a/tools/libs/ctrl/xc_cpupool.c b/tools/libs/ctrl/xc_cpupool.c > index fbd8cc9d037c7761e78e5d7111e6eead027f8b3a..52dcfe4a274a5d64c534dd47ede42da9c889a5dd 100644 > --- a/tools/libs/ctrl/xc_cpupool.c > +++ b/tools/libs/ctrl/xc_cpupool.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2009, J Gross. > */ > diff --git a/tools/libs/ctrl/xc_csched.c b/tools/libs/ctrl/xc_csched.c > index 8e8c67220a0bc88db1bbc1d7880a8a95dd39570a..24213fc4c3cf53939357d01f37b68b803e220675 100644 > --- a/tools/libs/ctrl/xc_csched.c > +++ b/tools/libs/ctrl/xc_csched.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_csched2.c b/tools/libs/ctrl/xc_csched2.c > index 5eb753ad99158cfcd743fa4eb2260b17002f3793..14e4d15ad2644e1ffd5e08b4d6464cdab84e2f04 100644 > --- a/tools/libs/ctrl/xc_csched2.c > +++ b/tools/libs/ctrl/xc_csched2.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c > index e939d0715739f288bcf5c5f3c2a6f8865dddbbd1..d87105331dc3d394b16757b36cf9ebb9cf5db098 100644 > --- a/tools/libs/ctrl/xc_domain.c > +++ b/tools/libs/ctrl/xc_domain.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2003, K A Fraser. > */ > diff --git a/tools/libs/ctrl/xc_evtchn.c b/tools/libs/ctrl/xc_evtchn.c > index 614786d3f3197e93958abe4321f40a0becb11d3b..7578869367b922ef8182e9ec96b242409a276be1 100644 > --- a/tools/libs/ctrl/xc_evtchn.c > +++ b/tools/libs/ctrl/xc_evtchn.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2004, K A Fraser. > */ > diff --git a/tools/libs/ctrl/xc_flask.c b/tools/libs/ctrl/xc_flask.c > index c1652ba48d7c9163080cea92ea874e729f1ad96f..e3b6e9f279d73b7abb7a0d7d12e5801d3837de59 100644 > --- a/tools/libs/ctrl/xc_flask.c > +++ b/tools/libs/ctrl/xc_flask.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_foreign_memory.c b/tools/libs/ctrl/xc_foreign_memory.c > index 4053d268513673d18fedaeccd739b4186d33846d..47d65bf2f6c59574d2217be6c2239701cb9b507f 100644 > --- a/tools/libs/ctrl/xc_foreign_memory.c > +++ b/tools/libs/ctrl/xc_foreign_memory.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #define XC_BUILDING_COMPAT_MAP_FOREIGN_API > diff --git a/tools/libs/ctrl/xc_freebsd.c b/tools/libs/ctrl/xc_freebsd.c > index 9dd48a3a08bb00c4bd1f75caf99b7865a977030b..661e49a9a110e2e3f8f82a75d733c4c5c49012b1 100644 > --- a/tools/libs/ctrl/xc_freebsd.c > +++ b/tools/libs/ctrl/xc_freebsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_gnttab.c b/tools/libs/ctrl/xc_gnttab.c > index eb92d897d49e54d48d08db56a3b7b3dd17bde7c8..7db3f81613cb915de47350a8889baddb87689b94 100644 > --- a/tools/libs/ctrl/xc_gnttab.c > +++ b/tools/libs/ctrl/xc_gnttab.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_hcall_buf.c b/tools/libs/ctrl/xc_hcall_buf.c > index 200671f36ff2a036743de545243e29b786337bbe..59127484841bb835e1a5fb3db64e33b3e6d9a8eb 100644 > --- a/tools/libs/ctrl/xc_hcall_buf.c > +++ b/tools/libs/ctrl/xc_hcall_buf.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/ctrl/xc_linux.c b/tools/libs/ctrl/xc_linux.c > index c67c71c08be3f43fbe579e9ec76d8f1218fe4d28..c961f53124caa57aff6a27c4996c0a526b0265e6 100644 > --- a/tools/libs/ctrl/xc_linux.c > +++ b/tools/libs/ctrl/xc_linux.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_mem_access.c b/tools/libs/ctrl/xc_mem_access.c > index 6d613037d04ea81369c1ccde40126c0da574277a..15c047174b253ea28484f77e604e1ba8432537d1 100644 > --- a/tools/libs/ctrl/xc_mem_access.c > +++ b/tools/libs/ctrl/xc_mem_access.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_mem_paging.c b/tools/libs/ctrl/xc_mem_paging.c > index 999a572cefdcbadfec7d1c1a854acecd0f2c6411..a940f3b95702f991e47f02e1f22c95bd2ff5d694 100644 > --- a/tools/libs/ctrl/xc_mem_paging.c > +++ b/tools/libs/ctrl/xc_mem_paging.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_memshr.c b/tools/libs/ctrl/xc_memshr.c > index 2f65b3b22e13b37a7c7055920ab52b541e83b291..9813a731a359ff6905c8c814fe72be1cd5674698 100644 > --- a/tools/libs/ctrl/xc_memshr.c > +++ b/tools/libs/ctrl/xc_memshr.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_minios.c b/tools/libs/ctrl/xc_minios.c > index 3dea7a78a576d7425f36096837cb25099a2577ab..0a75f382615caf9d2d9a7d2c2572ae5d2863a93d 100644 > --- a/tools/libs/ctrl/xc_minios.c > +++ b/tools/libs/ctrl/xc_minios.c > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #undef NDEBUG > diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c > index 265f15ec2da344e948cbbe532d6d456a09accfc0..3b8b19801be53efc1bb025cd6aa713ce1f4976c3 100644 > --- a/tools/libs/ctrl/xc_misc.c > +++ b/tools/libs/ctrl/xc_misc.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_bitops.h" > diff --git a/tools/libs/ctrl/xc_monitor.c b/tools/libs/ctrl/xc_monitor.c > index c5fa62ff30d2bc3107e52ed70242644d182730fc..4a29f199b0b4152d4767a2539eb5e4ced6ba5b5b 100644 > --- a/tools/libs/ctrl/xc_monitor.c > +++ b/tools/libs/ctrl/xc_monitor.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_netbsd.c b/tools/libs/ctrl/xc_netbsd.c > index 31979937621ebd37de7578878b2825bd8f9b05b0..4609ba8599d8e3d02bb8a9f7335b615d6667c100 100644 > --- a/tools/libs/ctrl/xc_netbsd.c > +++ b/tools/libs/ctrl/xc_netbsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_pagetab.c b/tools/libs/ctrl/xc_pagetab.c > index db25c20247573a3c638d7725c976433221a40141..b938d8b8369c54a4ebf4245268f43d572f0a7501 100644 > --- a/tools/libs/ctrl/xc_pagetab.c > +++ b/tools/libs/ctrl/xc_pagetab.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_physdev.c b/tools/libs/ctrl/xc_physdev.c > index 460a8e779ce857e764e414c6dc118d6918d7aa6b..2fc2ac67a174d570bfddf2d7a1ce6cdbb46c575e 100644 > --- a/tools/libs/ctrl/xc_physdev.c > +++ b/tools/libs/ctrl/xc_physdev.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c > index 76d7eb7f265da4e52a69f944e13e10621d6ad2e2..5af84c2bbeff0e80e5f89b5b439e1b080f595548 100644 > --- a/tools/libs/ctrl/xc_pm.c > +++ b/tools/libs/ctrl/xc_pm.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > */ > > diff --git a/tools/libs/ctrl/xc_private.c b/tools/libs/ctrl/xc_private.c > index 2f99a7d2cfb560cdf57ae6777f55d0310f943602..444e2e6ad92458dc811b16895eec365c6698d676 100644 > --- a/tools/libs/ctrl/xc_private.c > +++ b/tools/libs/ctrl/xc_private.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h > index ed960c6f30e65baf1b0857961cfdb276e12fdcfe..818c7a6c750e4bc618e6e658d665958c4a9daa01 100644 > --- a/tools/libs/ctrl/xc_private.h > +++ b/tools/libs/ctrl/xc_private.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XC_PRIVATE_H > diff --git a/tools/libs/ctrl/xc_rt.c b/tools/libs/ctrl/xc_rt.c > index ad257c6e52878b652e5449804de02d61aa3d05ff..03bbacffa37b484cf51025c3ebf5a8260dc3f57d 100644 > --- a/tools/libs/ctrl/xc_rt.c > +++ b/tools/libs/ctrl/xc_rt.c > @@ -19,7 +19,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_solaris.c b/tools/libs/ctrl/xc_solaris.c > index 5128f3f0f49040cbe88d762f6f42448cbb8a8f21..629b0b21faadbdc6616c0b9e38641b1d6eac5989 100644 > --- a/tools/libs/ctrl/xc_solaris.c > +++ b/tools/libs/ctrl/xc_solaris.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_tbuf.c b/tools/libs/ctrl/xc_tbuf.c > index 283fbd1c8fb898bbbcb978e0fb71ca018504e362..110e4323a69a2d4ee02d356a19440863c1d8d8d7 100644 > --- a/tools/libs/ctrl/xc_tbuf.c > +++ b/tools/libs/ctrl/xc_tbuf.c > @@ -19,7 +19,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_vm_event.c b/tools/libs/ctrl/xc_vm_event.c > index a97c615b18999e96a29dd1ef0bfc09c5455e062a..a371cca306496d9f4cd4a8e3085d2f2aa1431783 100644 > --- a/tools/libs/ctrl/xc_vm_event.c > +++ b/tools/libs/ctrl/xc_vm_event.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/ctrl/xc_vmtrace.c b/tools/libs/ctrl/xc_vmtrace.c > index 602502367f2393ab38b5680a707a7f3a444fa57a..b36455f1dd3d8fd56610593382e8bdfd56f224d3 100644 > --- a/tools/libs/ctrl/xc_vmtrace.c > +++ b/tools/libs/ctrl/xc_vmtrace.c > @@ -19,7 +19,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/devicemodel/common.c b/tools/libs/devicemodel/common.c > index 0fdc7121f1eb7707f1f330577c9f4a2c948199f9..e18c2379e55d939323c91eb214d1e35900fa9bc1 100644 > --- a/tools/libs/devicemodel/common.c > +++ b/tools/libs/devicemodel/common.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/devicemodel/compat.c b/tools/libs/devicemodel/compat.c > index 5b4fdae2980450518919d60d50bf4acbeb6b100b..3c72737b0c50e3bea926317c4bea412b4089febc 100644 > --- a/tools/libs/devicemodel/compat.c > +++ b/tools/libs/devicemodel/compat.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c > index 8e619eeb0a1fc5faf7043e90ceb91becf9999db0..a30bdaa465ed8f03ed2316b3e42b991e2293be2c 100644 > --- a/tools/libs/devicemodel/core.c > +++ b/tools/libs/devicemodel/core.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/evtchn/core.c b/tools/libs/evtchn/core.c > index de925fc9630c0ca398b75c3d02ad81cbddbe21ed..5d70e827a8a450d3624e6357319ad0ee77b2a5b8 100644 > --- a/tools/libs/evtchn/core.c > +++ b/tools/libs/evtchn/core.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c > index 422836f1a1145de40dbbe771e0825b6d327ab377..0a557fce99b72cbf6205a26ae25689d7166c1f02 100644 > --- a/tools/libs/evtchn/freebsd.c > +++ b/tools/libs/evtchn/freebsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split off from xc_freebsd_osdep.c > */ > diff --git a/tools/libs/evtchn/linux.c b/tools/libs/evtchn/linux.c > index e61b77ca618a502448b7fcf4eedc83de4dfbca65..e9576e6ffc7fda7bb7bef7795bef35a9517ee58f 100644 > --- a/tools/libs/evtchn/linux.c > +++ b/tools/libs/evtchn/linux.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_linus_osdep.c: > * > diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c > index 28743cb055753f02976c9258003203b51c40a242..6f5482edcfa716fb27f1818178a4cdc05d6317d9 100644 > --- a/tools/libs/evtchn/minios.c > +++ b/tools/libs/evtchn/minios.c > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split off from xc_minios.c > */ > diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c > index 2de9cefc67f89b2a0ebd39c3008be0147701de1c..68047ef65c6fe77723308ec02fc77be523ee7324 100644 > --- a/tools/libs/evtchn/netbsd.c > +++ b/tools/libs/evtchn/netbsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_netbsd.c > */ > diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c > index 375a5f9b4fce280688fa0c6dcf8480cfb40fb78f..d137c7a30c044366ca36e03f766450f6ba490919 100644 > --- a/tools/libs/evtchn/solaris.c > +++ b/tools/libs/evtchn/solaris.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_solaris.c > */ > diff --git a/tools/libs/foreignmemory/compat.c b/tools/libs/foreignmemory/compat.c > index 5f730ca919d670de43cd1581a131224a856a050d..2d743720a42cf575f220d80cf3cd3d1f61fdf8a4 100644 > --- a/tools/libs/foreignmemory/compat.c > +++ b/tools/libs/foreignmemory/compat.c > @@ -11,7 +11,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_foreign_memory.c > */ > diff --git a/tools/libs/foreignmemory/core.c b/tools/libs/foreignmemory/core.c > index 7edc6f0dbfe35859819b9d5f6a21b12c61a8b471..ab6e8820e67a232c6c9002ba4c03f8604e0b9cf6 100644 > --- a/tools/libs/foreignmemory/core.c > +++ b/tools/libs/foreignmemory/core.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/foreignmemory/freebsd.c b/tools/libs/foreignmemory/freebsd.c > index 2cf0fa1c38b1544e43116867bf48b3e3bf47f959..d18e9f9112b3bad4444ec0ccfb0cd1d24cc243ab 100644 > --- a/tools/libs/foreignmemory/freebsd.c > +++ b/tools/libs/foreignmemory/freebsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c > index 9062117407a998634c6115043bbe33339e53ee19..7f6a327a9b43ee2b76f58fb918ffe004afab7d85 100644 > --- a/tools/libs/foreignmemory/linux.c > +++ b/tools/libs/foreignmemory/linux.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_linus_osdep.c: > * > diff --git a/tools/libs/foreignmemory/minios.c b/tools/libs/foreignmemory/minios.c > index f2f4dfb2be51851431b776e8b0d0c277cb13ec7e..0f7570772e3d9389f6373e8becaa8a6e292bd98f 100644 > --- a/tools/libs/foreignmemory/minios.c > +++ b/tools/libs/foreignmemory/minios.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_minios.c > * > diff --git a/tools/libs/foreignmemory/netbsd.c b/tools/libs/foreignmemory/netbsd.c > index 597db775d7ea428f865f3a53192494617e69cb49..8220452d6dd47662f76bc5d1fe2e3580ebd1eaad 100644 > --- a/tools/libs/foreignmemory/netbsd.c > +++ b/tools/libs/foreignmemory/netbsd.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/foreignmemory/solaris.c b/tools/libs/foreignmemory/solaris.c > index 958fb01f6d24a0e166b3a1d0db3000c2e84659ac..8dceeab84053fe8ed8472e6e94e015a4254acae7 100644 > --- a/tools/libs/foreignmemory/solaris.c > +++ b/tools/libs/foreignmemory/solaris.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/gnttab/freebsd.c b/tools/libs/gnttab/freebsd.c > index e42ac3fbf351470d43b085eed0e172a0f85b8e09..97373b3faee3fc91a006c870fa431ab0e5aa013e 100644 > --- a/tools/libs/gnttab/freebsd.c > +++ b/tools/libs/gnttab/freebsd.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from linux.c > */ > diff --git a/tools/libs/gnttab/gntshr_core.c b/tools/libs/gnttab/gntshr_core.c > index 1117e29c91335eb50b0c848b7ead2449ab148df9..2483d4987618aebff4b62f3673dc53fa62f9316c 100644 > --- a/tools/libs/gnttab/gntshr_core.c > +++ b/tools/libs/gnttab/gntshr_core.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_gnttab.c > */ > diff --git a/tools/libs/gnttab/gntshr_unimp.c b/tools/libs/gnttab/gntshr_unimp.c > index e21048435b1795ec5f057966aacbab5e09ae3892..dd08bc1265b97e86e7a69b0d03c1a4a8fe89782a 100644 > --- a/tools/libs/gnttab/gntshr_unimp.c > +++ b/tools/libs/gnttab/gntshr_unimp.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_gnttab.c > */ > diff --git a/tools/libs/gnttab/gnttab_core.c b/tools/libs/gnttab/gnttab_core.c > index 92e7228a267123c1e5156ea3d74b081bcbd7cbf0..4b6cdf26747bca181286a405efca64815e4c179a 100644 > --- a/tools/libs/gnttab/gnttab_core.c > +++ b/tools/libs/gnttab/gnttab_core.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_gnttab.c > */ > diff --git a/tools/libs/gnttab/gnttab_unimp.c b/tools/libs/gnttab/gnttab_unimp.c > index dee1afd2647f9f69a1d2a0dc5450b31ffd81a4da..bef13af9d85cd1aa71516dea052781f4bec824eb 100644 > --- a/tools/libs/gnttab/gnttab_unimp.c > +++ b/tools/libs/gnttab/gnttab_unimp.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_gnttab.c > */ > diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c > index 5628fd5719d1d7f95f5c5ca3f6e22cee708b32cf..e730250bcf8e2876f618321fbc45735c1f961a5c 100644 > --- a/tools/libs/gnttab/linux.c > +++ b/tools/libs/gnttab/linux.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from xc_linux_osdep.c > */ > diff --git a/tools/libs/gnttab/minios.c b/tools/libs/gnttab/minios.c > index cac89f0ba6206df7e4271427269cd4e39069a459..410b545ec694605688f909d014380bf3c3febe5c 100644 > --- a/tools/libs/gnttab/minios.c > +++ b/tools/libs/gnttab/minios.c > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Splitfrom xc_minios.c > */ > diff --git a/tools/libs/gnttab/netbsd.c b/tools/libs/gnttab/netbsd.c > index a4ad624b5415f050bcd23503e5e478ff6a5699f7..2c1a80f45421473f9dfb7303c7a07ade97ccbf37 100644 > --- a/tools/libs/gnttab/netbsd.c > +++ b/tools/libs/gnttab/netbsd.c > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Split out from linux.c > */ > diff --git a/tools/libs/guest/xg_core.c b/tools/libs/guest/xg_core.c > index c52f1161c1c8ff7e7f6effdc8a40ee449d4eaa81..6cb3d1b24a5d331e2480e83fab2a82cfe816d515 100644 > --- a/tools/libs/guest/xg_core.c > +++ b/tools/libs/guest/xg_core.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > /* > diff --git a/tools/libs/guest/xg_core.h b/tools/libs/guest/xg_core.h > index aaca9e0a8b992b5915ddfd20ef474ace8eccaeaf..a7585fa7aae06534cfd536cad6815ea0cc0a6fa6 100644 > --- a/tools/libs/guest/xg_core.h > +++ b/tools/libs/guest/xg_core.h > @@ -13,7 +13,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > */ > > diff --git a/tools/libs/guest/xg_core_arm.c b/tools/libs/guest/xg_core_arm.c > index aaabd075585e4ab69f7b690bab6a8256509a5fa6..c4a89b15e48fe6acba6f3f75a13412f1d0d98b35 100644 > --- a/tools/libs/guest/xg_core_arm.c > +++ b/tools/libs/guest/xg_core_arm.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2011 Citrix Systems > * > diff --git a/tools/libs/guest/xg_core_arm.h b/tools/libs/guest/xg_core_arm.h > index 162f7a7569e7067ebdb096c571439c4f6e7714b8..df0a2a2d2a7451c9a7e948aed0646f1a8d79fb7d 100644 > --- a/tools/libs/guest/xg_core_arm.h > +++ b/tools/libs/guest/xg_core_arm.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2012 Citrix Systems > * > diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c > index 61106b98b87701330d0833e7d138a55b2f614416..dcfe6a7c59796f0114c8c5f6740f271a246df5f0 100644 > --- a/tools/libs/guest/xg_core_x86.c > +++ b/tools/libs/guest/xg_core_x86.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2007 Isaku Yamahata > * VA Linux Systems Japan K.K. > diff --git a/tools/libs/guest/xg_core_x86.h b/tools/libs/guest/xg_core_x86.h > index 867146b1d9e73bed2810f6aa60f22bcc9b12d58b..4c9f82480861b6c24f331d243e7cf9a58b83d651 100644 > --- a/tools/libs/guest/xg_core_x86.h > +++ b/tools/libs/guest/xg_core_x86.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2007 Isaku Yamahata > * VA Linux Systems Japan K.K. > diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c > index 57f81eb0a0822b6d17cb5dfce90ef964a9178b75..72b23b5f7610e5c549f446da480ca50a91bee527 100644 > --- a/tools/libs/guest/xg_cpuid_x86.c > +++ b/tools/libs/guest/xg_cpuid_x86.c > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c > index 5e3b76355ec4850056a415cdbba25b52e7ca8c28..0aa693047e0a5d3779272b11276797d8a771ba74 100644 > --- a/tools/libs/guest/xg_dom_arm.c > +++ b/tools/libs/guest/xg_dom_arm.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2011, Citrix Systems > */ > diff --git a/tools/libs/guest/xg_dom_armzimageloader.c b/tools/libs/guest/xg_dom_armzimageloader.c > index 6d837cefc4a25b85d4974c1672b7d649d61edf32..ac822a213cb14264be946ce546493209e500124a 100644 > --- a/tools/libs/guest/xg_dom_armzimageloader.c > +++ b/tools/libs/guest/xg_dom_armzimageloader.c > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > */ > > diff --git a/tools/libs/guest/xg_dom_binloader.c b/tools/libs/guest/xg_dom_binloader.c > index f5e3ddc5dc4d515f455ef70aaa3cf607eaad4d37..bf8bfbefb994a58761d38961e12ff65b50faca86 100644 > --- a/tools/libs/guest/xg_dom_binloader.c > +++ b/tools/libs/guest/xg_dom_binloader.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Some of the field descriptions were copied from "The Multiboot > * Specification", Copyright 1995, 96 Bryan Ford , > diff --git a/tools/libs/guest/xg_dom_boot.c b/tools/libs/guest/xg_dom_boot.c > index 263a3f4c85a660790a8794b9147e338047bda18e..d20b37401269d0481658b502ffe9c694cbf884d6 100644 > --- a/tools/libs/guest/xg_dom_boot.c > +++ b/tools/libs/guest/xg_dom_boot.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * > diff --git a/tools/libs/guest/xg_dom_bzimageloader.c b/tools/libs/guest/xg_dom_bzimageloader.c > index 764ddbb43eb82dfe8c12eb95f38d952ed5c8c374..4e1693e625b16dfd017e4b7f38fdc5e985248e20 100644 > --- a/tools/libs/guest/xg_dom_bzimageloader.c > +++ b/tools/libs/guest/xg_dom_bzimageloader.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * written 2007 by Jeremy Fitzhardinge > diff --git a/tools/libs/guest/xg_dom_compat_linux.c b/tools/libs/guest/xg_dom_compat_linux.c > index a0d9c7a04e85946804ecf48bc4e1d3bf47e83220..1b18b51ba6df30f67724fa395a9aeab2c06e71c7 100644 > --- a/tools/libs/guest/xg_dom_compat_linux.c > +++ b/tools/libs/guest/xg_dom_compat_linux.c > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * > diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c > index c4f4e7f3e27a13f4cb72eb96552c921c6b45e4c8..a228496fd4066bae8e9a862d6548b6e6f65bc78b 100644 > --- a/tools/libs/guest/xg_dom_core.c > +++ b/tools/libs/guest/xg_dom_core.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * > diff --git a/tools/libs/guest/xg_dom_elfloader.c b/tools/libs/guest/xg_dom_elfloader.c > index f17930d98bf70fa3a0a7dced02177e0ce6123538..f71a49a4332c973ab3f3c58964cf4f764ca4c6c4 100644 > --- a/tools/libs/guest/xg_dom_elfloader.c > +++ b/tools/libs/guest/xg_dom_elfloader.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * > diff --git a/tools/libs/guest/xg_dom_hvmloader.c b/tools/libs/guest/xg_dom_hvmloader.c > index 39e1e5f579a738b5f71c0ef28dcd821817b22a94..e78754ce26b3af00447d14fa45a219d855fc5061 100644 > --- a/tools/libs/guest/xg_dom_hvmloader.c > +++ b/tools/libs/guest/xg_dom_hvmloader.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > */ > > diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c > index 9328fbf804853d98db175b6a02bcc925fd8b1181..b536afbe3cf2229872be53618781d2fa41332ba3 100644 > --- a/tools/libs/guest/xg_dom_x86.c > +++ b/tools/libs/guest/xg_dom_x86.c > @@ -16,7 +16,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * written 2006 by Gerd Hoffmann . > * > diff --git a/tools/libs/guest/xg_domain.c b/tools/libs/guest/xg_domain.c > index f0e7748449a1c7b13ec601d66bef4d18eb9485c0..ce4562b024defb0cad10bf1b441b244b1812e679 100644 > --- a/tools/libs/guest/xg_domain.c > +++ b/tools/libs/guest/xg_domain.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2003, K A Fraser. > */ > diff --git a/tools/libs/guest/xg_nomigrate.c b/tools/libs/guest/xg_nomigrate.c > index 6795c62ddc2803527bf0e74843cb86ef99231de0..f9b528cf25c9e20f72bd85cc33c976641987472e 100644 > --- a/tools/libs/guest/xg_nomigrate.c > +++ b/tools/libs/guest/xg_nomigrate.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (c) 2011, Citrix Systems > */ > diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c > index c594fdba415de8cde8d08e53710b9c0437a8b5a4..406ec536e169d3b489c9dadd155160c122f4d10a 100644 > --- a/tools/libs/guest/xg_offline_page.c > +++ b/tools/libs/guest/xg_offline_page.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/guest/xg_private.c b/tools/libs/guest/xg_private.c > index 2073dba2ef2091b71e175252b5da7b14549602d2..291ed0b237eb9bb380751ae40a938953918fbe1d 100644 > --- a/tools/libs/guest/xg_private.c > +++ b/tools/libs/guest/xg_private.c > @@ -14,7 +14,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/guest/xg_private.h b/tools/libs/guest/xg_private.h > index 09e24f122760a4bfc6a8e73c922ed44b5f8da635..62d8a153210684a24103650cc1c4e283d190c50e 100644 > --- a/tools/libs/guest/xg_private.h > +++ b/tools/libs/guest/xg_private.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XG_PRIVATE_H > diff --git a/tools/libs/guest/xg_resume.c b/tools/libs/guest/xg_resume.c > index 77e2451a3c4daa7712a056bf9886661ff474bcdb..0b5451c8a4fdf154342bc0b38f4459297f1bc84a 100644 > --- a/tools/libs/guest/xg_resume.c > +++ b/tools/libs/guest/xg_resume.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xg_private.h" > diff --git a/tools/libs/guest/xg_save_restore.h b/tools/libs/guest/xg_save_restore.h > index 3dbbc8dcd271c59a35836ab9d2a911cdb5126843..a30c909271c596627dfa74714e98ec359ae0a5dd 100644 > --- a/tools/libs/guest/xg_save_restore.h > +++ b/tools/libs/guest/xg_save_restore.h > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xc_private.h" > diff --git a/tools/libs/guest/xg_suspend.c b/tools/libs/guest/xg_suspend.c > index 0ce63649636905851e03750a0ae8bcb63dd926f1..62d9b3d9ed65364c982065169d4d9941fa9861d5 100644 > --- a/tools/libs/guest/xg_suspend.c > +++ b/tools/libs/guest/xg_suspend.c > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include > diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c > index 52b30db8d777c357fb85f3e936ce120d1431f421..522576a152251280d4e73ed0254d83782650edf4 100644 > --- a/tools/libs/hypfs/core.c > +++ b/tools/libs/hypfs/core.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #define __XEN_TOOLS__ 1 > diff --git a/tools/libs/stat/COPYING b/tools/libs/stat/COPYING > index 480e5f18765e660f5e9d00f9bb09097bdc3d3084..d49f0cf1a31a59bda21b086c12cc4e5071bcb635 100644 > --- a/tools/libs/stat/COPYING > +++ b/tools/libs/stat/COPYING > @@ -489,7 +489,7 @@ notice is found. > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > > Also add information on how to contact you by electronic and paper mail. > > diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c > index 7a9a8b1656b05799515b75520cbc32bba72069a0..faafb3a1c5fc65a76603c47ab29cdd0ae010150f 100644 > --- a/tools/libs/store/xs.c > +++ b/tools/libs/store/xs.c > @@ -13,7 +13,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #define _GNU_SOURCE > diff --git a/tools/libs/toolcore/handlereg.c b/tools/libs/toolcore/handlereg.c > index b43cb0e8acab7a06d65a3215934bd56e1e8d93a0..4a9d87b64107ad9b0aaa112926a8cf7bf946a3ea 100644 > --- a/tools/libs/toolcore/handlereg.c > +++ b/tools/libs/toolcore/handlereg.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xentoolcore_internal.h" > diff --git a/tools/libs/toollog/xtl_core.c b/tools/libs/toollog/xtl_core.c > index 099d2f30951d613e189cd7d980f39f274c91a772..c526c44ab4918ce1f67cd778d95054ad0fe8eaef 100644 > --- a/tools/libs/toollog/xtl_core.c > +++ b/tools/libs/toollog/xtl_core.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xentoollog.h" > diff --git a/tools/libs/toollog/xtl_logger_stdio.c b/tools/libs/toollog/xtl_logger_stdio.c > index 52dfbf51e35b122462fa966f4c4171b768dd0204..4fc17aad96929eb2cf75a45d2b6027975fdb9515 100644 > --- a/tools/libs/toollog/xtl_logger_stdio.c > +++ b/tools/libs/toollog/xtl_logger_stdio.c > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "xentoollog.h" > diff --git a/tools/libs/util/libxlu_cfg_y.c b/tools/libs/util/libxlu_cfg_y.c > index 6d4638afc937368065943fee2386aa523a1c12a3..055b697437d9dc7d9ce9d63fa965ded14ba10932 100644 > --- a/tools/libs/util/libxlu_cfg_y.c > +++ b/tools/libs/util/libxlu_cfg_y.c > @@ -16,7 +16,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program. If not, see . */ > + along with this program. If not, see . */ > > /* As a special exception, you may create a larger work that contains > part or all of the Bison parser skeleton and distribute that work > diff --git a/tools/libs/util/libxlu_cfg_y.h b/tools/libs/util/libxlu_cfg_y.h > index 1233cb94fccc3d7c442ebb3692af23000c550983..01f12531a641c78a2e5265361dab01e31974170a 100644 > --- a/tools/libs/util/libxlu_cfg_y.h > +++ b/tools/libs/util/libxlu_cfg_y.h > @@ -16,7 +16,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program. If not, see . */ > + along with this program. If not, see . */ > > /* As a special exception, you may create a larger work that contains > part or all of the Bison parser skeleton and distribute that work > diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c > index 9195bd3b98759897d324bf0a712f7788be1e5865..9136a118753858e3e70dbbe37247d4747b449af9 100644 > --- a/tools/libs/vchan/init.c > +++ b/tools/libs/vchan/init.c > @@ -21,7 +21,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c > index 1f201ad554f2dc050f45e63b92446d301fb76d89..00281ebf36f1a3cbb93316b458e9eddc9b7f32d9 100644 > --- a/tools/libs/vchan/io.c > +++ b/tools/libs/vchan/io.c > @@ -21,7 +21,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h > index 621016ef42e5eaf57f1c0d5e333801d35b3abe35..9aec37906960f80c5bbf717717eb2e6f9cf528ba 100644 > --- a/tools/libs/vchan/vchan.h > +++ b/tools/libs/vchan/vchan.h > @@ -17,7 +17,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/misc/mkhex b/tools/misc/mkhex > index d0982d5787286ba894087358115824cc75eaea30..0cc49047cbf33aabde0291ce407f314210d4c42f 100755 > --- a/tools/misc/mkhex > +++ b/tools/misc/mkhex > @@ -16,7 +16,7 @@ > # more details. > # > # You should have received a copy of the GNU General Public License along with > -# this program; If not, see . > +# this program; If not, see . > # > > echo "unsigned $1[] = {" > diff --git a/tools/misc/xen-mceinj.c b/tools/misc/xen-mceinj.c > index df55eefbacc585e7e62eff1c40972cfa15015b35..b385eaac57021a1bbb6b2691c9178bdd2339cf55 100644 > --- a/tools/misc/xen-mceinj.c > +++ b/tools/misc/xen-mceinj.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Authors: Yunhong Jiang > * Haicheng Li > diff --git a/tools/misc/xen-vmtrace.c b/tools/misc/xen-vmtrace.c > index 5b688a54af5a1c59a4cc85acbf81c9b0e164a5e9..93af18ebbd8adfe364bb1f72c414188f685d6053 100644 > --- a/tools/misc/xen-vmtrace.c > +++ b/tools/misc/xen-vmtrace.c > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/misc/xencov.c b/tools/misc/xencov.c > index e5b40dba9cf1c1f42f4efc2d851cdefcb33ad37a..28e006569a204eef5593dee8868ab32a5b80b396 100644 > --- a/tools/misc/xencov.c > +++ b/tools/misc/xencov.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c > index 4f8cde690a7c77f4465fd0815c901b4232240419..162a18fe7e1485145a6255f8c653b47552f24a97 100644 > --- a/tools/misc/xenpm.c > +++ b/tools/misc/xenpm.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #define MAX_NR_CPU 512 > > diff --git a/tools/misc/xenpvnetboot b/tools/misc/xenpvnetboot > index be972b9e19b7ff55e7723c37d1e2affd306fae22..2d56c279f07e013bea811c37d4ffca14bb61c6a5 100755 > --- a/tools/misc/xenpvnetboot > +++ b/tools/misc/xenpvnetboot > @@ -8,7 +8,7 @@ > # useful, but WITHOUT ANY WARRANTY; without even the implied warranty of > # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General > # Public License for more details. You should have received a copy of the GNU > -# General Public License along with this program; If not, see . > +# General Public License along with this program; If not, see . > > import sys > import os > diff --git a/tools/ocaml/LICENSE b/tools/ocaml/LICENSE > index d4d1f176886856c1e536ca925471520ba9c7bcfe..f11101ec2d33d936815e259bd757869e456d2bfd 100644 > --- a/tools/ocaml/LICENSE > +++ b/tools/ocaml/LICENSE > @@ -181,7 +181,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > -License along with this library; If not, see . > +License along with this library; If not, see . > > Also add information on how to contact you by electronic and paper mail. > > diff --git a/tools/pygrub/src/ExtLinuxConf.py b/tools/pygrub/src/ExtLinuxConf.py > index 9fd635b9cf7ad56a925e955be9702922d2648121..c12fa3a1912c92ced8ecf3f1f3596af55f67773f 100644 > --- a/tools/pygrub/src/ExtLinuxConf.py > +++ b/tools/pygrub/src/ExtLinuxConf.py > @@ -7,7 +7,7 @@ > # general public license. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > > from __future__ import print_function, absolute_import > diff --git a/tools/pygrub/src/GrubConf.py b/tools/pygrub/src/GrubConf.py > index 73f1bbed2f543333172104683768710ed61b6bf3..958a15a44af1b284b1a5b69aa8557ae1585f4af2 100644 > --- a/tools/pygrub/src/GrubConf.py > +++ b/tools/pygrub/src/GrubConf.py > @@ -9,7 +9,7 @@ > # general public license. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > > from __future__ import print_function, absolute_import > diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub > index ce7ab0eb8cf3c352dfc5ac1726b88cbbf953ff28..eda2aa1f4e0de8fb70749140e0f52f365277b7de 100755 > --- a/tools/pygrub/src/pygrub > +++ b/tools/pygrub/src/pygrub > @@ -9,7 +9,7 @@ > # general public license. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > # > > from __future__ import print_function > diff --git a/tools/python/xen/lowlevel/xs/xs.c b/tools/python/xen/lowlevel/xs/xs.c > index 3ba5a8b893d9c0ce7b5aaf242242568910807d06..bb78f5b84bb6771ea6786cd14267cb8f9c4de3db 100644 > --- a/tools/python/xen/lowlevel/xs/xs.c > +++ b/tools/python/xen/lowlevel/xs/xs.c > @@ -11,7 +11,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Copyright (C) 2005 Mike Wray Hewlett-Packard > * Copyright (C) 2005 Christian Limpach > diff --git a/tools/tests/depriv/depriv-fd-checker.c b/tools/tests/depriv/depriv-fd-checker.c > index 98a27a03d5438b783c6ae4cf0c23591b48b57c93..bd0bdb2d54f2aeef910843e645e30bb6cc7b89c6 100644 > --- a/tools/tests/depriv/depriv-fd-checker.c > +++ b/tools/tests/depriv/depriv-fd-checker.c > @@ -47,7 +47,7 @@ > * > * You should have received a copy of the GNU Lesser General Public > * License along with this library; If not, see > - * . > + * . > */ > > #include > diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h > index b022cc0eab0373f8e1896df6d710ad94afb3c62f..bec67fcea1361cabb858fae618a3907ba14f769f 100644 > --- a/tools/tests/vhpet/emul.h > +++ b/tools/tests/vhpet/emul.h > @@ -10,7 +10,7 @@ > * This file is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * General Public License for more details. . > + * General Public License for more details. . > */ > > #include > diff --git a/tools/tests/vhpet/main.c b/tools/tests/vhpet/main.c > index 4054eec6296910d3117334091b3dac190f9aea29..8452da8a60192b66f3980987a74caf19d48fff4c 100644 > --- a/tools/tests/vhpet/main.c > +++ b/tools/tests/vhpet/main.c > @@ -10,7 +10,7 @@ > * This file is distributed in the hope that it will be useful, > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - * General Public License for more details. . > + * General Public License for more details. . > */ > > /* > diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h > index f03e3a56d18121184f725c6003943fdb7c5e40eb..50f4c1b9d3e9067cbafdfdf25c77ddb8779cb139 100644 > --- a/tools/tests/vpci/emul.h > +++ b/tools/tests/vpci/emul.h > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef _TEST_VPCI_ > diff --git a/tools/tests/vpci/main.c b/tools/tests/vpci/main.c > index b9a0a6006bb98c4b7d28ad5d2b9a20ecaff0352a..1348722947f2cad87ed9b39d195b35413bab97a3 100644 > --- a/tools/tests/vpci/main.c > +++ b/tools/tests/vpci/main.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include "emul.h" > diff --git a/tools/tests/x86_emulator/blowfish.c b/tools/tests/x86_emulator/blowfish.c > index 8f0939c101879ad5fd2aab202b4619960f5231c0..7c02bbd3ac2219960ca6937e97956410381e417c 100644 > --- a/tools/tests/x86_emulator/blowfish.c > +++ b/tools/tests/x86_emulator/blowfish.c > @@ -12,7 +12,7 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > Lesser General Public License for more details. > You should have received a copy of the GNU Lesser General Public > -License along with this library; If not, see . > +License along with this library; If not, see . > */ > > #include > diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c > index d3574b3fa27025de7115b6c4dda80e8408141fe0..37bde5a67316ec853b6567f5ffd9e7fba57676d0 100644 > --- a/tools/tests/xenstore/test-xenstore.c > +++ b/tools/tests/xenstore/test-xenstore.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #define _GNU_SOURCE > diff --git a/tools/vchan/node-select.c b/tools/vchan/node-select.c > index 039464427a8b54f3a4bc8cd3d5de7bca1aaf9509..e885a05a33c4b1357b0c1ead5799cc9661ba58cd 100644 > --- a/tools/vchan/node-select.c > +++ b/tools/vchan/node-select.c > @@ -21,7 +21,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/vchan/node.c b/tools/vchan/node.c > index f1638f013d3d5fc4f00427080848f8022ae7efed..d9720154aaa7801deee7669ff74b9005e83ce627 100644 > --- a/tools/vchan/node.c > +++ b/tools/vchan/node.c > @@ -21,7 +21,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/vchan/vchan-socket-proxy.c b/tools/vchan/vchan-socket-proxy.c > index e1d959c6d15ce84e71bafcb512743d1c65f1dc07..72f16e05420b1c42b3b8cc6810932e49975cadc7 100644 > --- a/tools/vchan/vchan-socket-proxy.c > +++ b/tools/vchan/vchan-socket-proxy.c > @@ -22,7 +22,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * @section DESCRIPTION > * > diff --git a/tools/xenmon/COPYING b/tools/xenmon/COPYING > index ec0f60d1ffd93b956159a23858b2393c58f26d4e..a7ee562a7c71f5ae42a698d0f3fc8cbabf919646 100644 > --- a/tools/xenmon/COPYING > +++ b/tools/xenmon/COPYING > @@ -304,7 +304,7 @@ the "copyright" line and a pointer to where the full notice is found. > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > > > Also add information on how to contact you by electronic and paper mail. > diff --git a/tools/xenmon/setmask.c b/tools/xenmon/setmask.c > index 7e7b7b8f4378c4f690520a3e000b6f90ca0b9201..4452ceacf7151c6585cc28fa5e3b5527a84febea 100644 > --- a/tools/xenmon/setmask.c > +++ b/tools/xenmon/setmask.c > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c > index 4dddbd20e2fb39a4216f5efe351c13dee0305836..9df18480d5e5401d23871c68efd8e237d2ed7887 100644 > --- a/tools/xenmon/xenbaked.c > +++ b/tools/xenmon/xenbaked.c > @@ -26,7 +26,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/xenmon/xenbaked.h b/tools/xenmon/xenbaked.h > index 9eeacbb5843a3af6efceb10bd953df3249ce8266..b2943edd8135fa132fd621c98fe8d639011b9cf8 100644 > --- a/tools/xenmon/xenbaked.h > +++ b/tools/xenmon/xenbaked.h > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __QOS_H__ > diff --git a/tools/xenmon/xenmon.py b/tools/xenmon/xenmon.py > index 977ada68877139b783345980e78769efd47ca3f5..f37fc29afb573d8abcf6b4b66df97ad246462b64 100644 > --- a/tools/xenmon/xenmon.py > +++ b/tools/xenmon/xenmon.py > @@ -20,7 +20,7 @@ > # GNU General Public License for more details. > # > # You should have received a copy of the GNU General Public License > -# along with this program; If not, see . > +# along with this program; If not, see . > ##################################################################### > > from __future__ import print_function > diff --git a/tools/xenpaging/file_ops.c b/tools/xenpaging/file_ops.c > index 301fb3427cc5f8ca271fcc00343772e87efde76f..f13ba9848c26137c8f3c1cd7b82eb01efed48ace 100644 > --- a/tools/xenpaging/file_ops.c > +++ b/tools/xenpaging/file_ops.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/tools/xenpaging/file_ops.h b/tools/xenpaging/file_ops.h > index ee3fd7d8b86c9d2a187daaf7aaa7c8a94a761aaa..5a9466fb587583bb727a42d6a82d8f062be1cea7 100644 > --- a/tools/xenpaging/file_ops.h > +++ b/tools/xenpaging/file_ops.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/tools/xenpaging/policy.h b/tools/xenpaging/policy.h > index b1425a90ef6d3bb5c5132354bb8abe4daf28a006..81356f9c18770988559a242bbcbfe801dd5d511b 100644 > --- a/tools/xenpaging/policy.h > +++ b/tools/xenpaging/policy.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/tools/xenpaging/policy_default.c b/tools/xenpaging/policy_default.c > index 979d251230451710de9087ee348bad47a2261d04..801dfa182d7b743fb9ec3db82e3bab7facc064cb 100644 > --- a/tools/xenpaging/policy_default.c > +++ b/tools/xenpaging/policy_default.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c > index 6e5490315d0128ed9065308675dab10de3a31c44..a579394b35c2bacbb9468adacbec86c696fd50c0 100644 > --- a/tools/xenpaging/xenpaging.c > +++ b/tools/xenpaging/xenpaging.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #define _GNU_SOURCE > diff --git a/tools/xenpaging/xenpaging.h b/tools/xenpaging/xenpaging.h > index e0fc7b31b863b2c4390e6c9f317898f41a1005d2..a1a5074b9ee3b70a13b37102213114d6439e1abc 100644 > --- a/tools/xenpaging/xenpaging.h > +++ b/tools/xenpaging/xenpaging.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c > index 15e6169c449de77517de2cb67c21a5c5c4cd4851..f5a8513bc1b6da7fe45f09c31ac98412932dc3b5 100644 > --- a/tools/xenpmd/xenpmd.c > +++ b/tools/xenpmd/xenpmd.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* Xen extended power management support provides HVM guest power management > diff --git a/tools/xenstore/COPYING b/tools/xenstore/COPYING > index c764b2e3292196157cafb19aef908c9565146be4..00f925a24f36e388fca35ebb9ac1f188c6774ffd 100644 > --- a/tools/xenstore/COPYING > +++ b/tools/xenstore/COPYING > @@ -494,7 +494,7 @@ notice is found. > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > > Also add information on how to contact you by electronic and paper mail. > > diff --git a/tools/xenstore/include/xenstore_state.h b/tools/xenstore/include/xenstore_state.h > index ae0d053c8ffc07c1e0491da647bcc40728d127f3..d949d3aa6522c0b0cc563fc3451e3e62cedc0c82 100644 > --- a/tools/xenstore/include/xenstore_state.h > +++ b/tools/xenstore/include/xenstore_state.h > @@ -15,7 +15,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef XENSTORE_STATE_H > diff --git a/tools/xenstore/talloc.c b/tools/xenstore/talloc.c > index 9eda1bfc00c0b6b35d34ce25268fc9c070d9da55..91b620c2c604307f3fd662697ab152bcae7c1836 100644 > --- a/tools/xenstore/talloc.c > +++ b/tools/xenstore/talloc.c > @@ -22,7 +22,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > /* > diff --git a/tools/xenstore/talloc.h b/tools/xenstore/talloc.h > index a0f4bff25788e6964cc42ad9f9c3b5af0fe4a49a..bd027e0f8db2873d9c0231a47baa03b69f9b75ca 100644 > --- a/tools/xenstore/talloc.h > +++ b/tools/xenstore/talloc.h > @@ -21,7 +21,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #include > diff --git a/tools/xenstore/tdb.c b/tools/xenstore/tdb.c > index 29593b76c308a928e109dec32aea7563dc5b2b8b..d53dfed7979aba9d9ad0f7113cb33a2bdadeb85b 100644 > --- a/tools/xenstore/tdb.c > +++ b/tools/xenstore/tdb.c > @@ -22,7 +22,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > > diff --git a/tools/xenstore/tdb.h b/tools/xenstore/tdb.h > index ce3c7339f884af1fb381266d729148aefe62f8c7..4676b9058b554ee0b06d1f121e07bc1a40729678 100644 > --- a/tools/xenstore/tdb.h > +++ b/tools/xenstore/tdb.h > @@ -25,7 +25,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #ifdef __cplusplus > diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c > index cbd62556c3ae50a9d539de14d28890c8d9a9f81a..3d8be860bdf9846c10edb4bde60b4d4e091a507e 100644 > --- a/tools/xenstore/xenstored_control.c > +++ b/tools/xenstore/xenstored_control.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_control.h b/tools/xenstore/xenstored_control.h > index a8cb76559ba1e4e13b9c12d14f82765afa090a2b..6ea1194d3ce214dc12a3e83525d47ad3aa3f1373 100644 > --- a/tools/xenstore/xenstored_control.h > +++ b/tools/xenstore/xenstored_control.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > int do_control(const void *ctx, struct connection *conn, > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 4f00e0cdc0cf30f57a9ab972e9b5752f83724856..5893dfa2560eb844e476d2e56ab06692d6299414 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index c59b06551f543b3909fdb6a49ef57ff9db000d45..3d9c6c66b987e412a3f7ddbe615391db7ec2157a 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #ifndef _XENSTORED_CORE_H > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index 9ef41ede03ae16a86ad8274df9d53a0209c96a31..2dae7fc4bdf017c3980a1c7d51e43a667560de98 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index dc4660861eb752142e931d3c870e4c46228016d0..f5f5e0d71e1adb3be00717675b311634755a31d7 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #ifndef _XENSTORED_DOMAIN_H > diff --git a/tools/xenstore/xenstored_minios.c b/tools/xenstore/xenstored_minios.c > index aa384e50c8fec8297d9870ab3f8c9275fd20babd..3f5ceef9fc9380fdeb9922bfd2391a2dc7c84f8d 100644 > --- a/tools/xenstore/xenstored_minios.c > +++ b/tools/xenstore/xenstored_minios.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > #include > #include > diff --git a/tools/xenstore/xenstored_posix.c b/tools/xenstore/xenstored_posix.c > index b20504d1b656b004e5d0dd5cc77cef80d24d9f7f..c422ac1d44d399d2b5ecda0508b07cbdaf0e2128 100644 > --- a/tools/xenstore/xenstored_posix.c > +++ b/tools/xenstore/xenstored_posix.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c > index 1aa9d3cb3dce2792256e0f373f1f6e65f8523e35..f347c4fb8e367f993aaebfe7aa92d78c44a59f64 100644 > --- a/tools/xenstore/xenstored_transaction.c > +++ b/tools/xenstore/xenstored_transaction.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_transaction.h b/tools/xenstore/xenstored_transaction.h > index b6f8cb7d0a3b13d9f68eed1fc2443b8ac40c33b8..4e2eb585ebd194fc114a8fa630ec6befc165cf16 100644 > --- a/tools/xenstore/xenstored_transaction.h > +++ b/tools/xenstore/xenstored_transaction.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > #ifndef _XENSTORED_TRANSACTION_H > #define _XENSTORED_TRANSACTION_H > diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c > index 8ad0229df648361a40435927f85c4341f72f3658..a2d1054bb581b4733bc5ca2a386a0d59cbe85b4e 100644 > --- a/tools/xenstore/xenstored_watch.c > +++ b/tools/xenstore/xenstored_watch.c > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #include > diff --git a/tools/xenstore/xenstored_watch.h b/tools/xenstore/xenstored_watch.h > index 091890edca966c4e714fd77397f48f4122aecf73..51f7f64ff4ff911754380e7447cf0600ce13eb8f 100644 > --- a/tools/xenstore/xenstored_watch.h > +++ b/tools/xenstore/xenstored_watch.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > */ > > #ifndef _XENSTORED_WATCH_H > diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c > index b9941c567cd0559ee76431e9eee525cf0f3ea30c..e8cf37d0bb092efe24be6544743301c2cefd7aff 100644 > --- a/tools/xenstore/xs_lib.c > +++ b/tools/xenstore/xs_lib.c > @@ -13,7 +13,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #include > diff --git a/tools/xenstore/xs_lib.h b/tools/xenstore/xs_lib.h > index efa05997d67c30f75be28f0389980117351f396f..78a0a9549a51cf6030b9d37a5ac1464771eca1a2 100644 > --- a/tools/xenstore/xs_lib.h > +++ b/tools/xenstore/xs_lib.h > @@ -13,7 +13,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > */ > > #ifndef XS_LIB_H > diff --git a/tools/xentop/xentop.c b/tools/xentop/xentop.c > index 950e8935c4c149f9bcd15eeb8691837d0ea881a4..0037f4f1f30e786152631ab89b47d0f1f4967d80 100644 > --- a/tools/xentop/xentop.c > +++ b/tools/xentop/xentop.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* get curses header from configure */ > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index 5de167031e01d73a7e3fdfa1b8bd67352b2b45d9..e555e0cca37a939818f95b6314b105bf87461d9a 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #define _XOPEN_SOURCE 600 > #include > diff --git a/xen/COPYING b/xen/COPYING > index ddb3494147a1312ffb8120c9486eea0d21ec4718..e76aa91592a88ed1510ef6fa8066050d89af6c14 100644 > --- a/xen/COPYING > +++ b/xen/COPYING > @@ -331,7 +331,7 @@ the "copyright" line and a pointer to where the full notice is found. > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > > > Also add information on how to contact you by electronic and paper mail. > diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c > index db5085e15d84321b6d05aa338ffbf25e26ec8913..dda7b4e74e76490a0a77a0db020d4ac3a45a5f0e 100644 > --- a/xen/arch/arm/acpi/boot.c > +++ b/xen/arch/arm/acpi/boot.c > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/arm/acpi/lib.c b/xen/arch/arm/acpi/lib.c > index 41d521f720ac5fe4fe2a2f5f2e1f82b4add3ceba..482dac701f340373071b3233c64fc762b732ed60 100644 > --- a/xen/arch/arm/acpi/lib.c > +++ b/xen/arch/arm/acpi/lib.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/arm/arm32/insn.c b/xen/arch/arm/arm32/insn.c > index 49953a042aee62a56e6785ed030ece3848701169..b8ea6005419221f2333746ddbbaf8fb2d257c308 100644 > --- a/xen/arch/arm/arm32/insn.c > +++ b/xen/arch/arm/arm32/insn.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #include > #include > diff --git a/xen/arch/arm/arm32/lib/bitops.c b/xen/arch/arm/arm32/lib/bitops.c > index ceddd76d1b008e3c9f712fdf686fca979401eb51..6df685a0e910e29d1f2b64ca6eaa445325959fa6 100644 > --- a/xen/arch/arm/arm32/lib/bitops.c > +++ b/xen/arch/arm/arm32/lib/bitops.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm32/lib/lib1funcs.S b/xen/arch/arm/arm32/lib/lib1funcs.S > index f1278bd6c1399414b4fc28fd3c7d93b5db6156a4..8b766baa00437ff9bcf35490f3a1af09d2274e39 100644 > --- a/xen/arch/arm/arm32/lib/lib1funcs.S > +++ b/xen/arch/arm/arm32/lib/lib1funcs.S > @@ -28,7 +28,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > General Public License for more details. > > You should have received a copy of the GNU General Public License > -along with this program; see the file COPYING. If not, see . */ > +along with this program; see the file COPYING. If not, see . */ > > > #include "assembler.h" > diff --git a/xen/arch/arm/arm32/lib/lshrdi3.S b/xen/arch/arm/arm32/lib/lshrdi3.S > index 88b9655282abde3598fc2396da24877c450d821b..e1470e657022dfa05e2e230f9da75cc38ca03605 100644 > --- a/xen/arch/arm/arm32/lib/lshrdi3.S > +++ b/xen/arch/arm/arm32/lib/lshrdi3.S > @@ -21,7 +21,7 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > General Public License for more details. > > You should have received a copy of the GNU General Public License > -along with this program; see the file COPYING. If not, see . */ > +along with this program; see the file COPYING. If not, see . */ > > > #include "assembler.h" > diff --git a/xen/arch/arm/arm64/bpi.S b/xen/arch/arm/arm64/bpi.S > index 4e638252204893ce8fe38b81c45639d256f29be2..79831dc026243e1b5fd8e1af87a46b9eee4c02c7 100644 > --- a/xen/arch/arm/arm64/bpi.S > +++ b/xen/arch/arm/arm64/bpi.S > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/cache.S b/xen/arch/arm/arm64/cache.S > index 9a88a2b49731f2196cae99112bc3b5b33548c179..01f514c169251e9d58fa0b71a23ffb1ce425d135 100644 > --- a/xen/arch/arm/arm64/cache.S > +++ b/xen/arch/arm/arm64/cache.S > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/debug-meson.inc b/xen/arch/arm/arm64/debug-meson.inc > index e65e1ccde4823521b275de7f133c2db12fbde693..67e91fee21d61f712ed9d13efb30e2d3d124eaeb 100644 > --- a/xen/arch/arm/arm64/debug-meson.inc > +++ b/xen/arch/arm/arm64/debug-meson.inc > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #define AML_UART_WFIFO_REG 0x00 > diff --git a/xen/arch/arm/arm64/debug-mvebu.inc b/xen/arch/arm/arm64/debug-mvebu.inc > index 63b12dc3d37bb429a1eda25731b75b8126d0c279..72edc5e23ce721e74d686da90a4da21246c0eb0e 100644 > --- a/xen/arch/arm/arm64/debug-mvebu.inc > +++ b/xen/arch/arm/arm64/debug-mvebu.inc > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #define UART_STATUS_REG 0x0c > diff --git a/xen/arch/arm/arm64/insn.c b/xen/arch/arm/arm64/insn.c > index 22f2bdebd544f7e5f789361844bf14e73f15c604..2f55c243f3b67e19ee201d73ee0dbf4047c33745 100644 > --- a/xen/arch/arm/arm64/insn.c > +++ b/xen/arch/arm/arm64/insn.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #include > #include > diff --git a/xen/arch/arm/arm64/lib/bitops.c b/xen/arch/arm/arm64/lib/bitops.c > index 20e3f3d6ceafc0f66310d6dccab1c78e3afd8702..6b638b7632d1dad5f2594d5acd46bf6e1b4d7a41 100644 > --- a/xen/arch/arm/arm64/lib/bitops.c > +++ b/xen/arch/arm/arm64/lib/bitops.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/lib/clear_page.S b/xen/arch/arm/arm64/lib/clear_page.S > index a767e63686d872210ca4f7c0aa3400868ec6f67d..2185c0987e1c630d5eed09344b2e88d8df0833a1 100644 > --- a/xen/arch/arm/arm64/lib/clear_page.S > +++ b/xen/arch/arm/arm64/lib/clear_page.S > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/lib/memchr.S b/xen/arch/arm/arm64/lib/memchr.S > index 81f113bb1cabbc240d3b04fa427f37bb4dc86531..0becb12666288bd9cab299ec4590b5f70873752e 100644 > --- a/xen/arch/arm/arm64/lib/memchr.S > +++ b/xen/arch/arm/arm64/lib/memchr.S > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include "assembler.h" > diff --git a/xen/arch/arm/arm64/lib/memcmp.S b/xen/arch/arm/arm64/lib/memcmp.S > index afa73bd7ef264a5a68c0bd01d052f82d216ba690..57bb7b8a6060080636442be7b3f10f725e3ca6f6 100644 > --- a/xen/arch/arm/arm64/lib/memcmp.S > +++ b/xen/arch/arm/arm64/lib/memcmp.S > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include "assembler.h" > diff --git a/xen/arch/arm/arm64/lib/memcpy.S b/xen/arch/arm/arm64/lib/memcpy.S > index e7a667c2be280d9a5a4b8d991cbbf645ace5374e..b6bd157ca4da645f4df5b0b3fc0d55fdeebf1681 100644 > --- a/xen/arch/arm/arm64/lib/memcpy.S > +++ b/xen/arch/arm/arm64/lib/memcpy.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/lib/memmove.S b/xen/arch/arm/arm64/lib/memmove.S > index 35d9b62fa0bb2430f65def7b0c0fc8e6cb04dec3..00e790e5c03d5f985bd7272c717a5ceac5a3fb08 100644 > --- a/xen/arch/arm/arm64/lib/memmove.S > +++ b/xen/arch/arm/arm64/lib/memmove.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/lib/memset.S b/xen/arch/arm/arm64/lib/memset.S > index 5ce1db2e76e4a06bb51e8b5acc9f3ae0cb9313c4..d4c906ec409fb039c68129c7fab3b04c45f87961 100644 > --- a/xen/arch/arm/arm64/lib/memset.S > +++ b/xen/arch/arm/arm64/lib/memset.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/arm64/lib/strchr.S b/xen/arch/arm/arm64/lib/strchr.S > index 0506b0ff7f3aef45d2ef9932d071a7100253b5f4..e3fd8a263cec7d9ea1de5227891bffa4f070e759 100644 > --- a/xen/arch/arm/arm64/lib/strchr.S > +++ b/xen/arch/arm/arm64/lib/strchr.S > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > > diff --git a/xen/arch/arm/arm64/lib/strcmp.S b/xen/arch/arm/arm64/lib/strcmp.S > index 5492a8482fa59e0463042f2deb4ef3ca515f24d5..793da9658b64b343b962b9ea47ecc51b317d4eae 100644 > --- a/xen/arch/arm/arm64/lib/strcmp.S > +++ b/xen/arch/arm/arm64/lib/strcmp.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include "assembler.h" > diff --git a/xen/arch/arm/arm64/lib/strlen.S b/xen/arch/arm/arm64/lib/strlen.S > index d8d513d18f87d5ff36539dfd6f85dece8ba9ec66..439d4c0c9f5caf2fde899c8c1844b2b82bb84b7a 100644 > --- a/xen/arch/arm/arm64/lib/strlen.S > +++ b/xen/arch/arm/arm64/lib/strlen.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include "assembler.h" > diff --git a/xen/arch/arm/arm64/lib/strncmp.S b/xen/arch/arm/arm64/lib/strncmp.S > index 90d3eb67055577f3d4514221d48ab69edcda202d..71c6a6404b1480c912b136bf072033c01a617851 100644 > --- a/xen/arch/arm/arm64/lib/strncmp.S > +++ b/xen/arch/arm/arm64/lib/strncmp.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > > diff --git a/xen/arch/arm/arm64/lib/strnlen.S b/xen/arch/arm/arm64/lib/strnlen.S > index 9e2683790b1f33d3d12ec03f758c2c8a62f0baf1..4ad5c9a954e9bd969a9b3c328ff588d59b274702 100644 > --- a/xen/arch/arm/arm64/lib/strnlen.S > +++ b/xen/arch/arm/arm64/lib/strnlen.S > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > > diff --git a/xen/arch/arm/arm64/lib/strrchr.S b/xen/arch/arm/arm64/lib/strrchr.S > index 07059983f828cdbe0b29cd615987172c8336fa8d..19118c6b9844a6e4613b1e5a6724a944c95a55dc 100644 > --- a/xen/arch/arm/arm64/lib/strrchr.S > +++ b/xen/arch/arm/arm64/lib/strrchr.S > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > /* > diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c > index aae0f979112ae8cd81d0dfd9785f14fa814aa411..fb75d7db75cf5c619087377961036a0a61112e8e 100644 > --- a/xen/arch/arm/efi/efi-dom0.c > +++ b/xen/arch/arm/efi/efi-dom0.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/arm/include/asm/acpi.h b/xen/arch/arm/include/asm/acpi.h > index e53973e0542b6aa7d8a32c325c47f343e2c4438b..3b61a82c31c297c08d0bb2f5221e8dba32fee3e0 100644 > --- a/xen/arch/arm/include/asm/acpi.h > +++ b/xen/arch/arm/include/asm/acpi.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/arm/include/asm/altp2m.h b/xen/arch/arm/include/asm/altp2m.h > index df50cb2f0988f344a5e1bf065157a0a98ece4db6..ed325988130686a7808b242edf162b3afbfaa517 100644 > --- a/xen/arch/arm/include/asm/altp2m.h > +++ b/xen/arch/arm/include/asm/altp2m.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_ARM_ALTP2M_H > diff --git a/xen/arch/arm/include/asm/arm32/insn.h b/xen/arch/arm/include/asm/arm32/insn.h > index c800cbfff544f5240a80e2635caf6ca742562784..48ee26fa02c8d7428b53e6ed66c5952431760afe 100644 > --- a/xen/arch/arm/include/asm/arm32/insn.h > +++ b/xen/arch/arm/include/asm/arm32/insn.h > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __ARCH_ARM_ARM32_INSN > #define __ARCH_ARM_ARM32_INSN > diff --git a/xen/arch/arm/include/asm/arm64/atomic.h b/xen/arch/arm/include/asm/arm64/atomic.h > index 2d425678660b90f2417317bc66c16691b5679c12..fbc4bff39d15d3428b6d5c35e3484231aeeed7e9 100644 > --- a/xen/arch/arm/include/asm/arm64/atomic.h > +++ b/xen/arch/arm/include/asm/arm64/atomic.h > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __ARCH_ARM_ARM64_ATOMIC > #define __ARCH_ARM_ARM64_ATOMIC > diff --git a/xen/arch/arm/include/asm/arm64/insn.h b/xen/arch/arm/include/asm/arm64/insn.h > index 4e0d364d412869615bb02a42a841db2eb717989b..44eb394b07b36ccbdbeaa6a0f031b0c73d262612 100644 > --- a/xen/arch/arm/include/asm/arm64/insn.h > +++ b/xen/arch/arm/include/asm/arm64/insn.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __ARCH_ARM_ARM64_INSN > #define __ARCH_ARM_ARM64_INSN > diff --git a/xen/arch/arm/include/asm/arm64/io.h b/xen/arch/arm/include/asm/arm64/io.h > index 2e2ab24f7838b56c9fb9968f0a98f1e7a1c8e6b4..4f98dbbdfe4929f40c6c4409311f4a6d76d92ea7 100644 > --- a/xen/arch/arm/include/asm/arm64/io.h > +++ b/xen/arch/arm/include/asm/arm64/io.h > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef _ARM_ARM64_IO_H > #define _ARM_ARM64_IO_H > diff --git a/xen/arch/arm/include/asm/gic_v3_its.h b/xen/arch/arm/include/asm/gic_v3_its.h > index fae3f6ecefe99fe7841d1d1fef5b9cd6571f8634..7f2d125288167cfb923b24124ad13ff647623179 100644 > --- a/xen/arch/arm/include/asm/gic_v3_its.h > +++ b/xen/arch/arm/include/asm/gic_v3_its.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __ASM_ARM_ITS_H__ > diff --git a/xen/arch/arm/include/asm/iommu.h b/xen/arch/arm/include/asm/iommu.h > index d57bd8a38ccd4b042e6a72d54bf326ebed411af9..c12a45e5c6a177b5e2da4006ab49836f000921e8 100644 > --- a/xen/arch/arm/include/asm/iommu.h > +++ b/xen/arch/arm/include/asm/iommu.h > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #ifndef __ARCH_ARM_IOMMU_H__ > #define __ARCH_ARM_IOMMU_H__ > diff --git a/xen/arch/arm/include/asm/iommu_fwspec.h b/xen/arch/arm/include/asm/iommu_fwspec.h > index 5cdb53f8e84bd09b22bc03be9e4481717a5e715a..0cabb191c4da18e91ef8c3bdcfc6f981a201ac8c 100644 > --- a/xen/arch/arm/include/asm/iommu_fwspec.h > +++ b/xen/arch/arm/include/asm/iommu_fwspec.h > @@ -21,7 +21,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __ARCH_ARM_IOMMU_FWSPEC_H__ > diff --git a/xen/arch/arm/include/asm/ioreq.h b/xen/arch/arm/include/asm/ioreq.h > index 50185978d51621ec9978aef89f92226891433a88..fd1e775d10d9aa8e0bf16a3dd918dd36aaf38c04 100644 > --- a/xen/arch/arm/include/asm/ioreq.h > +++ b/xen/arch/arm/include/asm/ioreq.h > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_ARM_IOREQ_H__ > diff --git a/xen/arch/arm/include/asm/mem_access.h b/xen/arch/arm/include/asm/mem_access.h > index 35ed0ad15471c3a4e2eddc5810668c3ef152619b..7920f856822415149ed0cabc0aa919fed3ba81e7 100644 > --- a/xen/arch/arm/include/asm/mem_access.h > +++ b/xen/arch/arm/include/asm/mem_access.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef _ASM_ARM_MEM_ACCESS_H > diff --git a/xen/arch/arm/include/asm/monitor.h b/xen/arch/arm/include/asm/monitor.h > index 7567be66bdc5b314943caaba73d9f891bafab43c..01619b6eefebc3a08f555ff37fe58417a87be379 100644 > --- a/xen/arch/arm/include/asm/monitor.h > +++ b/xen/arch/arm/include/asm/monitor.h > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __ASM_ARM_MONITOR_H__ > diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm/new_vgic.h > index b7fa9ab11a0bb991cd475c6dadff650a73a4af4b..bac6f778dcdfae836cde88c39ef065cd8fd19fcd 100644 > --- a/xen/arch/arm/include/asm/new_vgic.h > +++ b/xen/arch/arm/include/asm/new_vgic.h > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __ASM_ARM_NEW_VGIC_H > #define __ASM_ARM_NEW_VGIC_H > diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h > index 8cb46f6b718597a8b620bb02e2097579d7e00f35..7c1f75970c474a3cb2724c3b66d03ce2d9e44c3a 100644 > --- a/xen/arch/arm/include/asm/pci.h > +++ b/xen/arch/arm/include/asm/pci.h > @@ -9,7 +9,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #ifndef __ARM_PCI_H__ > diff --git a/xen/arch/arm/include/asm/vm_event.h b/xen/arch/arm/include/asm/vm_event.h > index abe7db1970cab6e102ae670f6ea15d7ddd7023e1..1cfcc46f1410a44ce13411a59a937d4d985e7dd8 100644 > --- a/xen/arch/arm/include/asm/vm_event.h > +++ b/xen/arch/arm/include/asm/vm_event.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_ARM_VM_EVENT_H__ > diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/vpl011.h > index c09abcd7a9b3356d0809743517934adae00087f5..61d66ed2f62827f47228ef57ed4fb886f662d7d7 100644 > --- a/xen/arch/arm/include/asm/vpl011.h > +++ b/xen/arch/arm/include/asm/vpl011.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef _VPL011_H_ > diff --git a/xen/arch/arm/include/asm/vpsci.h b/xen/arch/arm/include/asm/vpsci.h > index 0cca5e6830b8c72963aa5607a38c0a09ae224aad..1b3546739242f738939b83482cbbd0386cceb997 100644 > --- a/xen/arch/arm/include/asm/vpsci.h > +++ b/xen/arch/arm/include/asm/vpsci.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __ASM_VPSCI_H__ > diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c > index 3987f96b01783e0d96b5c2b729bbea72bae0c57e..da1d19a9d8d2807f723af352c5adace68f25795a 100644 > --- a/xen/arch/arm/pci/ecam.c > +++ b/xen/arch/arm/pci/ecam.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c > index 9f9aac43d7e9b30e01b1afe1ecf37101981582bc..8a3a476eae2172d61cf13a5d56bf229bfac85761 100644 > --- a/xen/arch/arm/pci/pci-access.c > +++ b/xen/arch/arm/pci/pci-access.c > @@ -9,7 +9,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index a8ece94303ca8070e8a6c2d5bc326ed4ae11d22a..e603dcf3d03f1d575078099ff4a80069cfaaf6ec 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c > index 46de6e43cc722adda4a20aa9e1cead2a528ddca3..ab262f0f7678c73cc03a181d3904e9074732da67 100644 > --- a/xen/arch/arm/pci/pci-host-generic.c > +++ b/xen/arch/arm/pci/pci-host-generic.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c > index 101edb8593c1e9b3647b00aaccf1b44c56ebb2f1..1d63769bace8520bcd995ac37fb094628f505c9f 100644 > --- a/xen/arch/arm/pci/pci-host-zynqmp.c > +++ b/xen/arch/arm/pci/pci-host-zynqmp.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c > index 78b97beaef12e85771602af4b296e075596affb7..1cc61272e02a32bc3f541aa80dacf5d42922a6b0 100644 > --- a/xen/arch/arm/pci/pci.c > +++ b/xen/arch/arm/pci/pci.c > @@ -9,7 +9,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/platforms/thunderx.c b/xen/arch/arm/platforms/thunderx.c > index 9b32a29c6b05eff94847189c1de7b69609720a9f..f46f3344294123091bb7d857a480dd385e2f38d5 100644 > --- a/xen/arch/arm/platforms/thunderx.c > +++ b/xen/arch/arm/platforms/thunderx.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/arm/vgic/vgic-init.c b/xen/arch/arm/vgic/vgic-init.c > index 62ae5536997be5d0be7eae2cbc9e89be63d81185..dfbe1b03f1c1cd1bfd8aeeff3d0a602a1843d6da 100644 > --- a/xen/arch/arm/vgic/vgic-init.c > +++ b/xen/arch/arm/vgic/vgic-init.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/vgic/vgic-mmio.h b/xen/arch/arm/vgic/vgic-mmio.h > index 3566cf237cee2c15bde3fb32e9a3b12c98cb1e1d..2203f87dd835271b6671cb2503100853267621cc 100644 > --- a/xen/arch/arm/vgic/vgic-mmio.h > +++ b/xen/arch/arm/vgic/vgic-mmio.h > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __XEN_ARM_VGIC_VGIC_MMIO_H__ > #define __XEN_ARM_VGIC_VGIC_MMIO_H__ > diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c > index 1a99d3a8b48446cbd031e325c941580e8a9ec7a8..11efab7b3e074b375177dbfc63e4c051d1bf2681 100644 > --- a/xen/arch/arm/vgic/vgic-v2.c > +++ b/xen/arch/arm/vgic/vgic-v2.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c > index f0f2ea502195901d6c9654f00ae9e330eff95215..b4a177106dc497642d780b91ca99f82b2cc51481 100644 > --- a/xen/arch/arm/vgic/vgic.c > +++ b/xen/arch/arm/vgic/vgic.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > > #include > diff --git a/xen/arch/arm/vgic/vgic.h b/xen/arch/arm/vgic/vgic.h > index 534b24bcd3f431a389cb866747535929e5622a8b..c2a1bef3dd9d0ac997205270401e978917133c71 100644 > --- a/xen/arch/arm/vgic/vgic.h > +++ b/xen/arch/arm/vgic/vgic.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > */ > #ifndef __XEN_ARM_VGIC_VGIC_H__ > #define __XEN_ARM_VGIC_VGIC_H__ > diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c > index 54b72d716beda91bfee09b62e6e7e8ba12ece5c8..4e04bf4d6177c455959cc89f535cb0e054f0685b 100644 > --- a/xen/arch/x86/acpi/boot.c > +++ b/xen/arch/x86/acpi/boot.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c > index 427c8c89c5c438d610de3470f0daf1840c7cb0ee..ec879af0c10452a5159a0a9379dd816c650f1cd6 100644 > --- a/xen/arch/x86/acpi/cpu_idle.c > +++ b/xen/arch/x86/acpi/cpu_idle.c > @@ -25,7 +25,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c > index c27cbb2304f27dbb0dbde0b74322a006d860dccc..c21794715cebef404ba9da17692bf6bffabbc49b 100644 > --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c > +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c > @@ -22,7 +22,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c > index d4c7dcd5d99d239462ba6c523a94ee8e970ba141..3fb3e1a5faf6fa937086606957042728083d5364 100644 > --- a/xen/arch/x86/acpi/cpufreq/powernow.c > +++ b/xen/arch/x86/acpi/cpufreq/powernow.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/acpi/cpuidle_menu.c b/xen/arch/x86/acpi/cpuidle_menu.c > index a275436d799c9440f3895d00cbf9bec48ce15b9d..66d95fc1450a0e2d11d70ceb76bb594db5738e9b 100644 > --- a/xen/arch/x86/acpi/cpuidle_menu.c > +++ b/xen/arch/x86/acpi/cpuidle_menu.c > @@ -18,7 +18,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c > index 43831b92d1322ba4cc3c65ceebc7e88bcfefe484..895b52c3ab1f9e325b594199c49d7e45e6e38382 100644 > --- a/xen/arch/x86/acpi/lib.c > +++ b/xen/arch/x86/acpi/lib.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c > index 0c6fc7b4fb0cb3d961f020dade3e3d42fede5c40..f715bcf1575c2d1ec7860481cdabd57257787de7 100644 > --- a/xen/arch/x86/alternative.c > +++ b/xen/arch/x86/alternative.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/boot/build32.lds b/xen/arch/x86/boot/build32.lds > index 56edaa727be77424d09f0e525be76f7c7b0403c2..a00183a28b8c63d9a523e5d5f79a0f58303072cd 100644 > --- a/xen/arch/x86/boot/build32.lds > +++ b/xen/arch/x86/boot/build32.lds > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program. If not, see . > + * with this program. If not, see . > */ > > ENTRY(_start) > diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c > index fc11c6d3c5c45fc8cdcd51ddd12923bfee3c0447..ffd5d060686e2b01ea74ea0418ac7f01e86feae2 100644 > --- a/xen/arch/x86/boot/cmdline.c > +++ b/xen/arch/x86/boot/cmdline.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program. If not, see . > + * with this program. If not, see . > * > * strlen(), strncmp(), strchr(), strspn() and strcspn() were copied from > * Linux kernel source (linux/lib/string.c). > diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h > index f9840044ec69636525e3a028058328d1dca2f324..95cfb053b7a827308680884331315c927a7b67b4 100644 > --- a/xen/arch/x86/boot/defs.h > +++ b/xen/arch/x86/boot/defs.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program. If not, see . > + * with this program. If not, see . > * > * max() was copied from xen/xen/include/xen/kernel.h. > */ > diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c > index be44d7f611b1c06ce00dd5ff73c696b3d616ccd1..c9d124ec9901f5eff26e4c68cb5abb4b8fa6203a 100644 > --- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c > +++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/xen/arch/x86/cpu/mcheck/mce-apei.c b/xen/arch/x86/cpu/mcheck/mce-apei.c > index 53b6735896bf105e22f38400f8a02e1ed422a5a2..1e21265fd510b647be80dc56090ddf1711c6d2fc 100644 > --- a/xen/arch/x86/cpu/mcheck/mce-apei.c > +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c > @@ -25,7 +25,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c > index 98c630fc86295ca38e248f9db8329e2a15794bda..b695f142375059a920d4e9e6bcf24d72519c2d65 100644 > --- a/xen/arch/x86/cpu/mcheck/mce_amd.c > +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* K8 common MCA documentation published at > diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c > index af30811afd445fe38d629f5fa220a868861cf6a6..a8d3aa68ae7beef9fb6ced8c1729883f69f07cad 100644 > --- a/xen/arch/x86/cpu/mcheck/vmce.c > +++ b/xen/arch/x86/cpu/mcheck/vmce.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/cpu/mcheck/x86_mca.h b/xen/arch/x86/cpu/mcheck/x86_mca.h > index 8f7fced0fee057326ef7d87699b1b5ab9d5fb170..420dabf288f3a6bef73b5473a822f50f46cd7b62 100644 > --- a/xen/arch/x86/cpu/mcheck/x86_mca.h > +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef X86_MCA_H > diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c > index 2946003b84938f3b83c98b62dfaa3ace90822983..88ee0f8444227287b57ba8018e4343720a555346 100644 > --- a/xen/arch/x86/cpu/mtrr/main.c > +++ b/xen/arch/x86/cpu/mtrr/main.c > @@ -14,7 +14,7 @@ > Library General Public License for more details. > > You should have received a copy of the GNU Library General Public > - License along with this library; If not, see . > + License along with this library; If not, see . > > Richard Gooch may be reached by email at rgooch@atnf.csiro.au > The postal address is: > diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c > index 9e981e7e26dceff1a75c76b073a59a3fc0dcc800..78d2e7bb65911b78f0792c9bbc0b0b02f26199ed 100644 > --- a/xen/arch/x86/cpu/mwait-idle.c > +++ b/xen/arch/x86/cpu/mwait-idle.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > /* > diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c > index b6b7342fb466e4ad2240516c0c3afc21472566e7..9b85e443ebf83bd73f31f41aaa32c8248aa577cc 100644 > --- a/xen/arch/x86/cpu/vpmu.c > +++ b/xen/arch/x86/cpu/vpmu.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Haitao Shan > */ > diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c > index 58794a16f06cd4041935922a51eb813a364a5d14..112409cbcc898f04dc83017616bcbbab0feae1ec 100644 > --- a/xen/arch/x86/cpu/vpmu_amd.c > +++ b/xen/arch/x86/cpu/vpmu_amd.c > @@ -17,7 +17,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c > index a8df52579db8e455b24f2f4a89367cbfe81d77ab..f3f855e7c3e90e40f7ba77a90aaf309b80c85487 100644 > --- a/xen/arch/x86/cpu/vpmu_intel.c > +++ b/xen/arch/x86/cpu/vpmu_intel.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Haitao Shan > */ > diff --git a/xen/arch/x86/gdbstub.c b/xen/arch/x86/gdbstub.c > index 961cae0be74f5514eb2f05536727786a74f9e250..6a7ad0f5578d11af14dda92d07d7a82ad0313c2c 100644 > --- a/xen/arch/x86/gdbstub.c > +++ b/xen/arch/x86/gdbstub.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > #include > #include > diff --git a/xen/arch/x86/gdbsx.c b/xen/arch/x86/gdbsx.c > index 6ef46e8ea77d8de3178ff50340bdf4fa2d0b9d95..e7b20a7202a1133ea14be39aab0538465e2748e3 100644 > --- a/xen/arch/x86/gdbsx.c > +++ b/xen/arch/x86/gdbsx.c > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c > index f73390cdb017caae149d2e1057723958a66ee7ae..36a30ec43e86b59c2135d1c4bdb2938038f51370 100644 > --- a/xen/arch/x86/genapic/x2apic.c > +++ b/xen/arch/x86/genapic/x2apic.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c > index b101ba3080b44a95cadd893c521454eb321572e6..f28df2cb45f8f67f3a16157345edd9051f9e79b0 100644 > --- a/xen/arch/x86/guest/hyperv/hyperv.c > +++ b/xen/arch/x86/guest/hyperv/hyperv.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2019 Microsoft. > */ > diff --git a/xen/arch/x86/guest/hyperv/private.h b/xen/arch/x86/guest/hyperv/private.h > index fea3e291e944ef8d22de7c8da7dd4f488167c428..a33e2501ff53ed9042a64a23a33431ea1125cbeb 100644 > --- a/xen/arch/x86/guest/hyperv/private.h > +++ b/xen/arch/x86/guest/hyperv/private.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2020 Microsoft. > */ > diff --git a/xen/arch/x86/guest/hyperv/tlb.c b/xen/arch/x86/guest/hyperv/tlb.c > index f249b259253daaa747dee5989d9f7d85a3be3846..986b8083cfae508cf27a4c886138a693892036b2 100644 > --- a/xen/arch/x86/guest/hyperv/tlb.c > +++ b/xen/arch/x86/guest/hyperv/tlb.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2020 Microsoft. > */ > diff --git a/xen/arch/x86/guest/hyperv/util.c b/xen/arch/x86/guest/hyperv/util.c > index 2c5f421b7bd9a5039ba59653a09b1e06700b2a3d..2db9b68136b31d5b3aef2467450c44cab5929217 100644 > --- a/xen/arch/x86/guest/hyperv/util.c > +++ b/xen/arch/x86/guest/hyperv/util.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2020 Microsoft. > */ > diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c > index 366af1d6500104dd97ca592c1a5a6d58bb4296f7..b4e01a25018513585fbc73bd04364bc1e85d920c 100644 > --- a/xen/arch/x86/guest/hypervisor.c > +++ b/xen/arch/x86/guest/hypervisor.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2019 Microsoft. > */ > diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c > index 498625eae0a3f065c41366aa8b51c2e571c6ca63..45af2a7caa3066ad8805e1fed409f40c931e18ca 100644 > --- a/xen/arch/x86/guest/xen/pvh-boot.c > +++ b/xen/arch/x86/guest/xen/pvh-boot.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c > index 9c2defaa6621864e359ea45e554ae8322c1d4610..417cd713ec29a4161c4b7d50fb473a139d6cadf5 100644 > --- a/xen/arch/x86/guest/xen/xen.c > +++ b/xen/arch/x86/guest/xen/xen.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/hvm/asid.c b/xen/arch/x86/hvm/asid.c > index 1fd2770a3ae062031687b4d9b0d38f9516f5b0d2..b4ea2d90c030b6fd6dcc33cac1518aec0d5f96fa 100644 > --- a/xen/arch/x86/hvm/asid.c > +++ b/xen/arch/x86/hvm/asid.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c > index f8e6089870b01b45fb88739658b17fae92b687ec..fd66243984cbe955eecfa7cdbd3a79d069b30294 100644 > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c > index 3ac6b7b423b10fae313950a1d443e6e2fb42ad39..8d7cfc074f6b25496a6b99baf685c6b5e816b970 100644 > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c > index 10e30175a1b6865d4924d08e5baf357794342cb7..82308a5cdb91f2a854fbd9a21e098246641e5072 100644 > --- a/xen/arch/x86/hvm/domain.c > +++ b/xen/arch/x86/hvm/domain.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/grant_table.c b/xen/arch/x86/hvm/grant_table.c > index b7a896ea5855f4ae1c99e26b204b69a610ee2338..fa23d5ad83257493783fde4c916c7b5d4be7a654 100644 > --- a/xen/arch/x86/hvm/grant_table.c > +++ b/xen/arch/x86/hvm/grant_table.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c > index c65e1b27d09ea5931fc13919697de088c1b9a8fe..60be48f6cf6347c5a8b51590b9397214a0621c90 100644 > --- a/xen/arch/x86/hvm/hpet.c > +++ b/xen/arch/x86/hvm/hpet.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 5c1e64189600df7d5c700ea500cf4afce12391ca..9339fc94bec0354eaff1b79b391d6139faf8a02d 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c > index 405d0a95afd8ef77d298f3d4dd261ba3cd3f7920..2fef069930318ddc4aa50e7baab9332d67a1ea97 100644 > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/arch/x86/hvm/hypercall.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c > index ffa31b7467161054c7b8b0f156d088f51c642f6e..e028f96b6ee46d3834b8803d81718eeed2115e4e 100644 > --- a/xen/arch/x86/hvm/intercept.c > +++ b/xen/arch/x86/hvm/intercept.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c > index 5ae209d3b6b3a5453290320d83bc09a9a3c6c8cd..9f16521c4449a3240e18638fca1cb2a96528e76c 100644 > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c > index 0bdcca1e1a5f68d213cb9a73637df4610c8d68aa..67427efe4dd9de2c2397358a6009dc0428deced8 100644 > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c > index 4fe87a71c12b36bd88233c061130105317a1654c..2ceed080e99deff38806c416ffcc0a77064fbd49 100644 > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c > index a11cd76f4d18003012ae502b0bd0fc6c408fcf9b..ddd83ba6cd8d36ef82c4d1818e21f8c0f94b50e9 100644 > --- a/xen/arch/x86/hvm/monitor.c > +++ b/xen/arch/x86/hvm/monitor.c > @@ -19,7 +19,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c > index 344edc2d6a96e4c9ab2aa68b2f40c51853ca2e6a..23382e936f43178dcb997b4f35c5bd680c0d0985 100644 > --- a/xen/arch/x86/hvm/mtrr.c > +++ b/xen/arch/x86/hvm/mtrr.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c > index 58370190ffc91fc9fc277e4f3532e09e4719bbbd..bfbba9df2ac4c63dc8be93296547fad6931e9fe1 100644 > --- a/xen/arch/x86/hvm/nestedhvm.c > +++ b/xen/arch/x86/hvm/nestedhvm.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c > index b89d0fd53ba16422792af9940a0fa1fac577f772..b4b33747225e6c1a96137493ecb8fd1d4483cd2b 100644 > --- a/xen/arch/x86/hvm/pmtimer.c > +++ b/xen/arch/x86/hvm/pmtimer.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c > index 2adab1f4b84b459c443029d129b69c22f8e6d44b..ef084b1d9659bfaa8e18877b694e1e2fd0673919 100644 > --- a/xen/arch/x86/hvm/quirks.c > +++ b/xen/arch/x86/hvm/quirks.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c > index c1675e3d9fb097ec88eda0b333cc6c0f6561d326..d0918b492916bf32de5e9f552d74fd493616da60 100644 > --- a/xen/arch/x86/hvm/save.c > +++ b/xen/arch/x86/hvm/save.c > @@ -17,7 +17,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c > index ab06dd3f3ae27d0c7f1e42dca429e275aa980032..d18ee50c2d0467bdc8ea018922578e40e1a3a728 100644 > --- a/xen/arch/x86/hvm/svm/asid.c > +++ b/xen/arch/x86/hvm/svm/asid.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c > index 16fc134883cff49c1fc335cbfbabc321d371295d..089cd946f55b9e4d3b39f36e1ae3fa45f8650b62 100644 > --- a/xen/arch/x86/hvm/svm/emulate.c > +++ b/xen/arch/x86/hvm/svm/emulate.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S > index 981cd82e7c0b2bab093476c38b9e29d7e58a2d3c..6e1ed4a3f8a0740dce835c2fe6d9d09d79779d77 100644 > --- a/xen/arch/x86/hvm/svm/entry.S > +++ b/xen/arch/x86/hvm/svm/entry.S > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > .file "svm/entry.S" > diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c > index 9525f3559392de8063bca90fd5000db82499ec06..ca4a6ccec0c0ebd954819f2c5183e0d251f24ab7 100644 > --- a/xen/arch/x86/hvm/svm/intr.c > +++ b/xen/arch/x86/hvm/svm/intr.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c > index 9f5f35f16aff2a11320a3719b0668ab57776b610..8bcfc65dc4f5304d47511c79771fe00dc5e02fc6 100644 > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/x86/hvm/svm/nestedsvm.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > index fa7325720328ba562948c8e921ee2ce8e1bde20f..1713966530d0bb3905e39268f340f05f565258c4 100644 > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c > index bce86f0ef706d5f1baeb21943cf3028d283cd6c5..4de3480737b18a8ee678df936290f87d1ac0e019 100644 > --- a/xen/arch/x86/hvm/svm/svmdebug.c > +++ b/xen/arch/x86/hvm/svm/svmdebug.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c > index 305d4767e38726540a637c1a2d7f9f2c6c482e2c..88b5d745c0efde3a21ea6755905214583a9d0d4b 100644 > --- a/xen/arch/x86/hvm/svm/vmcb.c > +++ b/xen/arch/x86/hvm/svm/vmcb.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c > index 41e3c4d5e42de151a3fb49bc93e4429e37be604a..d3b7d9fdfa5a07bd5d8124db3dff7c650598de7d 100644 > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Yunhong Jiang > * Ported to xen by using virtual IRQ line. > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c > index eb32f12e2d149c1a23ed8e8495d982a27cc367e6..031c04a61b7de6e09846d143a82dc1bb2b656958 100644 > --- a/xen/arch/x86/hvm/vlapic.c > +++ b/xen/arch/x86/hvm/vlapic.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/vm_event.c b/xen/arch/x86/hvm/vm_event.c > index 19aac19bc35406675624c0cd7e64f78f10bf8005..867a0eb902148bf069324069e14d97c2ae5b07a1 100644 > --- a/xen/arch/x86/hvm/vm_event.c > +++ b/xen/arch/x86/hvm/vm_event.c > @@ -17,7 +17,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c > index 3cd4923060c85cbd7d339bcdca488cdb143b47ac..34311f17a5de12eeedafaea8403780860533ee07 100644 > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > * > * Support for virtual MSI logic > * Will be merged it with virtual IOAPIC logic, since most is the same > diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S > index 5f5de45a1309c7d667cc6755e7f3da269c3de9a9..3ee68881a0fdbae73981193a69ab1998a61bd857 100644 > --- a/xen/arch/x86/hvm/vmx/entry.S > +++ b/xen/arch/x86/hvm/vmx/entry.S > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > .file "vmx/entry.S" > diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c > index 6a8316de0e25bc894918da392675076d91ef143b..e5e88f9dbd3d32ba58a5761fe49f71e10c80f7b9 100644 > --- a/xen/arch/x86/hvm/vmx/intr.c > +++ b/xen/arch/x86/hvm/vmx/intr.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index 09edbd23b3990dd88994f716145da07778f29cd3..edc99e6106d3555c1a9d97870ca4928fb9f78863 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index ade2a25ce7c20bb0220630b7b70ab0a13b1072e8..af76300a4d76ebb7a1d4ec7cd33cc30bf3ffa629 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c > index 674cdabb073672e371e1546efc9f573087bfe435..50779030b4c55a73376c2d24017bf02d716cbc0c 100644 > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c > index 621f5bb88b63850a4f4acbd39c5a66f7fe421568..05b1c37ca244aec58b04e39135d0bf4ad54dfbd7 100644 > --- a/xen/arch/x86/hvm/vpt.c > +++ b/xen/arch/x86/hvm/vpt.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c > index 6b73cff9b9ff3fb271836b97aac28f0fa9d389c9..b087621726720bc66171163144c0c62ced582100 100644 > --- a/xen/arch/x86/hypercall.c > +++ b/xen/arch/x86/hypercall.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2015,2016 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h > index 6ce79ce465b45b336138786a4fa8694e2c029b44..52bf6423b905e5e36714efe1b582e72463d372d4 100644 > --- a/xen/arch/x86/include/asm/acpi.h > +++ b/xen/arch/x86/include/asm/acpi.h > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/include/asm/altp2m.h b/xen/arch/x86/include/asm/altp2m.h > index b206e95863a63d35324778695300f668a1050327..d5914d6a96f1d060d77d8bf28d1d640225296beb 100644 > --- a/xen/arch/x86/include/asm/altp2m.h > +++ b/xen/arch/x86/include/asm/altp2m.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_ALTP2M_H > diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h > index d946fac131306049b44d8e52f2a0f9cf1bb3c5f4..46f02fd0812ca6dc85e8cda717194b2e0509c93f 100644 > --- a/xen/arch/x86/include/asm/endbr.h > +++ b/xen/arch/x86/include/asm/endbr.h > @@ -10,7 +10,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2021-2022 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/guest.h b/xen/arch/x86/include/asm/guest.h > index ccf1ffbb729af6aeb4dc8259ab26dd610ade69a1..9aa3edcca571ae4ae275715db44cf2dd62e9a78c 100644 > --- a/xen/arch/x86/include/asm/guest.h > +++ b/xen/arch/x86/include/asm/guest.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/guest/hyperv-hcall.h b/xen/arch/x86/include/asm/guest/hyperv-hcall.h > index 423ca0860b5d517a48b81a86240b898a31f913f1..fb2ab0e341f51dd1974f66d7959bc383d366a8d0 100644 > --- a/xen/arch/x86/include/asm/guest/hyperv-hcall.h > +++ b/xen/arch/x86/include/asm/guest/hyperv-hcall.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2019 Microsoft. > */ > diff --git a/xen/arch/x86/include/asm/guest/hyperv.h b/xen/arch/x86/include/asm/guest/hyperv.h > index 1a1b47831c8d602f568636053a69da0ab863f4ba..783baced2f5177f16c7875896b15e1d7a2f34abb 100644 > --- a/xen/arch/x86/include/asm/guest/hyperv.h > +++ b/xen/arch/x86/include/asm/guest/hyperv.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2019 Microsoft. > */ > diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h > index 0a6c3b47ab36cb4a1f6dffdef1e7535c96c49638..e966926a934ec31c3bfdd715ba505a058abcc35c 100644 > --- a/xen/arch/x86/include/asm/guest/hypervisor.h > +++ b/xen/arch/x86/include/asm/guest/hypervisor.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2019 Microsoft. > */ > diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h > index 48ffd1a0b1b40a8729e4cea9f045af978567173c..bedf8ba86779cd4c087549503feae4b081f8cd2d 100644 > --- a/xen/arch/x86/include/asm/guest/pvh-boot.h > +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/guest/xen-hcall.h b/xen/arch/x86/include/asm/guest/xen-hcall.h > index 03d5868a9efd698353d22578abc19c503fa84038..f6f0d576d3629df8e6e7475dca3ad2d51f8505b2 100644 > --- a/xen/arch/x86/include/asm/guest/xen-hcall.h > +++ b/xen/arch/x86/include/asm/guest/xen-hcall.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/guest/xen.h b/xen/arch/x86/include/asm/guest/xen.h > index 2042a9a0c2537bcacfe781e8bad0cb42cf069dfa..ea46d83de7865825272aab1d322ad7ec49989211 100644 > --- a/xen/arch/x86/include/asm/guest/xen.h > +++ b/xen/arch/x86/include/asm/guest/xen.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h > index 6802db2a415a9c3aa0faf55f8e5ee97c83cdc4f9..15c2d9383fa542f886b32b1fc82fa0ad9a0256dd 100644 > --- a/xen/arch/x86/include/asm/guest_pt.h > +++ b/xen/arch/x86/include/asm/guest_pt.h > @@ -22,7 +22,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_ASM_GUEST_PT_H > diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h > index 90dece29decad0dba7f7682a498493a06baa904f..9d7e2bbaf020ec76cb2b58c076f22dea9c513d82 100644 > --- a/xen/arch/x86/include/asm/hap.h > +++ b/xen/arch/x86/include/asm/hap.h > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_HAP_H > diff --git a/xen/arch/x86/include/asm/hvm/asid.h b/xen/arch/x86/include/asm/hvm/asid.h > index 633ddb72e494a85e42200298db4cda585d3a374a..f1e5525c8301f215709300d43c4dea8007041b6b 100644 > --- a/xen/arch/x86/include/asm/hvm/asid.h > +++ b/xen/arch/x86/include/asm/hvm/asid.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_ASID_H__ > diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h > index 698455444ea85b691126c3e8a31c08bbd48acb25..c5152049ed30799e1dffa4a309058cab180b2dcb 100644 > --- a/xen/arch/x86/include/asm/hvm/domain.h > +++ b/xen/arch/x86/include/asm/hvm/domain.h > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_DOMAIN_H__ > diff --git a/xen/arch/x86/include/asm/hvm/grant_table.h b/xen/arch/x86/include/asm/hvm/grant_table.h > index a5612585b35e520a87f0566a1f49d4574a34681f..342631b170c7cfc0ae452c93d8a3b5b7f2b3928b 100644 > --- a/xen/arch/x86/include/asm/hvm/grant_table.h > +++ b/xen/arch/x86/include/asm/hvm/grant_table.h > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __X86_HVM_GRANT_TABLE_H__ > diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h > index 65768c797ea7547f50962af5b1a379a8c275a47c..d92ecbdc7c805bc37ffd33c60f18292f43885596 100644 > --- a/xen/arch/x86/include/asm/hvm/hvm.h > +++ b/xen/arch/x86/include/asm/hvm/hvm.h > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_HVM_H__ > diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h > index 54e0161b492c3714f13112e0ebffa91dbc9e0229..3253c68a82a787c8ad3748c42551d6f26f2c559b 100644 > --- a/xen/arch/x86/include/asm/hvm/io.h > +++ b/xen/arch/x86/include/asm/hvm/io.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_IO_H__ > diff --git a/xen/arch/x86/include/asm/hvm/ioreq.h b/xen/arch/x86/include/asm/hvm/ioreq.h > index 9b2eb6fedf99bafd52c1395dca6887d4107460ae..9bd11077393cff0390130321db369adc529d52e8 100644 > --- a/xen/arch/x86/include/asm/hvm/ioreq.h > +++ b/xen/arch/x86/include/asm/hvm/ioreq.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_IOREQ_H__ > diff --git a/xen/arch/x86/include/asm/hvm/irq.h b/xen/arch/x86/include/asm/hvm/irq.h > index c4369ceb7aaaf5f3e50af0913ee8b78b81501d3a..fde58a7734a3d04bc7a6de63b40f539d94ca7e2b 100644 > --- a/xen/arch/x86/include/asm/hvm/irq.h > +++ b/xen/arch/x86/include/asm/hvm/irq.h > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_IRQ_H__ > diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h > index 639f6dfa374cf18b9f9088bd45007c1962eb452f..61358dcc055dbf9746f759db29d812eeb3f1f241 100644 > --- a/xen/arch/x86/include/asm/hvm/monitor.h > +++ b/xen/arch/x86/include/asm/hvm/monitor.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_MONITOR_H__ > diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h > index 7184928c2bb179a424554cdab534f0373305a9a9..0b179f58192e5025e2f47e1824b6a058ac1100be 100644 > --- a/xen/arch/x86/include/asm/hvm/nestedhvm.h > +++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef _HVM_NESTEDHVM_H > diff --git a/xen/arch/x86/include/asm/hvm/save.h b/xen/arch/x86/include/asm/hvm/save.h > index e975011ddb7112a2286242468a3df79c6a410d7b..39debb0a764b308c60a476abfeeb8f112282c4c6 100644 > --- a/xen/arch/x86/include/asm/hvm/save.h > +++ b/xen/arch/x86/include/asm/hvm/save.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __XEN_HVM_SAVE_H__ > diff --git a/xen/arch/x86/include/asm/hvm/support.h b/xen/arch/x86/include/asm/hvm/support.h > index 6b583738ecb5667c8bf3fa3545e0b02cfbec179b..fd2a51c4f6ca25ae0392a80fb2af82e6b5d1e3a9 100644 > --- a/xen/arch/x86/include/asm/hvm/support.h > +++ b/xen/arch/x86/include/asm/hvm/support.h > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_SUPPORT_H__ > diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h > index 0e5ec3ab788a578121b4c4eb2f88757718bc5991..70acd037b5d235c68737a974b75184e1587a44fc 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/asid.h > +++ b/xen/arch/x86/include/asm/hvm/svm/asid.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_SVM_ASID_H__ > diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/include/asm/hvm/svm/emulate.h > index eb1a8c24af6d23ddb20ab2d346ea8e9165538de0..f1bdeff74fd5ad436766c337d7202602c863a642 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h > +++ b/xen/arch/x86/include/asm/hvm/svm/emulate.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_SVM_EMULATE_H__ > diff --git a/xen/arch/x86/include/asm/hvm/svm/intr.h b/xen/arch/x86/include/asm/hvm/svm/intr.h > index ae52d9f948b127c7cff5c27a33f0719be159e297..817e5a713978cfd1a60f7951994f7e207e3a398d 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/intr.h > +++ b/xen/arch/x86/include/asm/hvm/svm/intr.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h > index 656d7d1a9a71ac5144115523a91204ed9c2729ef..3a5615dbaa205fe94bb462d1abc3df736a56602a 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h > +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __ASM_X86_HVM_SVM_NESTEDSVM_H__ > diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h > index 65e35a4f59b76bcd412ec409565193501618599b..6ce1f59ca788c8e2aae55eedf6f976f82f5851d5 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/svm.h > +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h > index 330c1d91aad54a2ca47e28a67c44d58c465459ab..d4544c589de8a65141226738b6215cc04f5ea050 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h > +++ b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > > diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h > index e87728fa81cd26fe014dd3eb47d622105063760f..ce33d4cc72d9616de774b7bf62f686d494a705ec 100644 > --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h > +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __ASM_X86_HVM_SVM_VMCB_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vcpu.h b/xen/arch/x86/include/asm/hvm/vcpu.h > index 8adf4555c2ab491980c0de823d424be15219413c..577ca66752f10ee31f869271b045bf8247df34b9 100644 > --- a/xen/arch/x86/include/asm/hvm/vcpu.h > +++ b/xen/arch/x86/include/asm/hvm/vcpu.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_VCPU_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vioapic.h b/xen/arch/x86/include/asm/hvm/vioapic.h > index 2944ec20dd53bf90fa9b7776df20e4a5f54af7e9..0c157f828973e99b035472efc7c909f94f42148f 100644 > --- a/xen/arch/x86/include/asm/hvm/vioapic.h > +++ b/xen/arch/x86/include/asm/hvm/vioapic.h > @@ -18,7 +18,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifndef __ASM_X86_HVM_VIOAPIC_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vlapic.h b/xen/arch/x86/include/asm/hvm/vlapic.h > index 8f908928c35c824359c0a998133a4675767b32ed..8905858a8fbfed0355974fecc83811920e444b49 100644 > --- a/xen/arch/x86/include/asm/hvm/vlapic.h > +++ b/xen/arch/x86/include/asm/hvm/vlapic.h > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_VLAPIC_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vm_event.h b/xen/arch/x86/include/asm/hvm/vm_event.h > index 28cb07ce8ff608212ccacd3140cf1b9423cadceb..714b8dd38984fd303660f4f504641a5bccdfc9eb 100644 > --- a/xen/arch/x86/include/asm/hvm/vm_event.h > +++ b/xen/arch/x86/include/asm/hvm/vm_event.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_VM_EVENT_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > index 0a84e744780543e3350694d376644c06af88b7d0..dc316cdf89b74e0616feb433ecb4e34acad4468f 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __ASM_X86_HVM_VMX_VMCS_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > index 234da4a7f4459b70d9f14d9e8267af3902e49339..9d33e6e200de018080c588c72cce3268b0ccfaed 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __ASM_X86_HVM_VMX_VMX_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h > index 2c3adb5dd6b348475875ff2835653f8f4297b56d..7d1c415ec17a1153c8c33f5744a199969fa04e5a 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __ASM_X86_HVM_VVMX_H__ > diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h > index 74c0cedd11cce8567c12aef946ef4fad4c5a647f..193e0d01cd6c00cc1f8bc2037d7bd9a77c9f7adf 100644 > --- a/xen/arch/x86/include/asm/hvm/vpt.h > +++ b/xen/arch/x86/include/asm/hvm/vpt.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_VPT_H__ > diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h > index fc0afe35bf6b9160f3514797e1d8c8203fd74230..bc43c3a35993cd7771f7360c88943a10ed976529 100644 > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #ifndef __ARCH_X86_IOMMU_H__ > #define __ARCH_X86_IOMMU_H__ > diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h > index d06ce9a6ea56ef4e6528872be2029a3177b8b313..5b659fb345382c4b45e794c8f1ad2a4ba90e4e8d 100644 > --- a/xen/arch/x86/include/asm/ioreq.h > +++ b/xen/arch/x86/include/asm/ioreq.h > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_IOREQ_H__ > diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h > index 18091610aea0439f7ad7bd60b2f205a3404aa99b..615eac2f8c3d72bd9c799e062bfd8f4f379bf84a 100644 > --- a/xen/arch/x86/include/asm/mem_access.h > +++ b/xen/arch/x86/include/asm/mem_access.h > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __ASM_X86_MEM_ACCESS_H__ > diff --git a/xen/arch/x86/include/asm/mem_paging.h b/xen/arch/x86/include/asm/mem_paging.h > index d3635e96cffc0bb18efe2b865b3fee03bf537dad..67ebddbbe33be779a5acc965f1a0648ea228d6f3 100644 > --- a/xen/arch/x86/include/asm/mem_paging.h > +++ b/xen/arch/x86/include/asm/mem_paging.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __ASM_X86_MEM_PAGING_H__ > diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h > index 2c00069bc91ce53b0e04b3eeb89e35c15fcf2676..5ed531af16a14a551a6cc48c1cdc5fa3787e3dde 100644 > --- a/xen/arch/x86/include/asm/mem_sharing.h > +++ b/xen/arch/x86/include/asm/mem_sharing.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > #ifndef __MEM_SHARING_H__ > #define __MEM_SHARING_H__ > diff --git a/xen/arch/x86/include/asm/monitor.h b/xen/arch/x86/include/asm/monitor.h > index d8d54c5f23d691fd1af049680552b11fd7b2267f..11ecd70b41831c1930256feb4a30fdf388814f13 100644 > --- a/xen/arch/x86/include/asm/monitor.h > +++ b/xen/arch/x86/include/asm/monitor.h > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __ASM_X86_MONITOR_H__ > diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h > index bd684d02f3676fba3b39b347e27556040fc36aa8..4b71075fe91400ab754cd5038b5ed29e9d05712a 100644 > --- a/xen/arch/x86/include/asm/p2m.h > +++ b/xen/arch/x86/include/asm/p2m.h > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_ASM_X86_P2M_H > diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h > index 8c0b0ef29a10d1199ea92c3bc8084a83b18c91e9..480f4aeefef094c02311e2d93a9429511a674ba3 100644 > --- a/xen/arch/x86/include/asm/paging.h > +++ b/xen/arch/x86/include/asm/paging.h > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_PAGING_H > diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h > index 924508bbb4f0c199b3cd2306d9d8f0bd0ef399f9..77800439a187b7cc43355b1d445b4f7499854f43 100644 > --- a/xen/arch/x86/include/asm/pv/domain.h > +++ b/xen/arch/x86/include/asm/pv/domain.h > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __X86_PV_DOMAIN_H__ > diff --git a/xen/arch/x86/include/asm/pv/grant_table.h b/xen/arch/x86/include/asm/pv/grant_table.h > index 85442b60749f6b17195eb9925887f9c98ae6a28b..72afc193abd5970b0d72fa317836722f29e630d8 100644 > --- a/xen/arch/x86/include/asm/pv/grant_table.h > +++ b/xen/arch/x86/include/asm/pv/grant_table.h > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __X86_PV_GRANT_TABLE_H__ > diff --git a/xen/arch/x86/include/asm/pv/mm.h b/xen/arch/x86/include/asm/pv/mm.h > index 9983f8257c63fa492120662d10ec192366560216..912b006875aaae76f2872ccddae3c766c1da4ec1 100644 > --- a/xen/arch/x86/include/asm/pv/mm.h > +++ b/xen/arch/x86/include/asm/pv/mm.h > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __X86_PV_MM_H__ > diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h > index a43c3689b48aa85ce6a413a8b5df3d9540475966..22acad0233ccaf9213e47e248064be9bfa8e0444 100644 > --- a/xen/arch/x86/include/asm/pv/shim.h > +++ b/xen/arch/x86/include/asm/pv/shim.h > @@ -11,7 +11,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/pv/traps.h b/xen/arch/x86/include/asm/pv/traps.h > index 855203c4e288bd7f1dd12d62dbfcb5379e5b69ca..f64993b2a349a8d403c86df0bbf86835cea2ec53 100644 > --- a/xen/arch/x86/include/asm/pv/traps.h > +++ b/xen/arch/x86/include/asm/pv/traps.h > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __X86_PV_TRAPS_H__ > diff --git a/xen/arch/x86/include/asm/shadow.h b/xen/arch/x86/include/asm/shadow.h > index 1365fe48051827acc3cac2a9640d4e1b560c5309..d83d705f3aca08a6807c234e65ac690fed506e3b 100644 > --- a/xen/arch/x86/include/asm/shadow.h > +++ b/xen/arch/x86/include/asm/shadow.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_SHADOW_H > diff --git a/xen/arch/x86/include/asm/shstk.h b/xen/arch/x86/include/asm/shstk.h > index fdc9cc65a3fa6d673e5a79149a1d451a019d0126..4c580a34976c343826a2c79bedb291a2efee9437 100644 > --- a/xen/arch/x86/include/asm/shstk.h > +++ b/xen/arch/x86/include/asm/shstk.h > @@ -10,7 +10,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2022 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h > index e928596450f7ba65f6af9c005dbb1a1609dd6c95..b480db11ad5c3a7914020fdb49fc46d613c8af40 100644 > --- a/xen/arch/x86/include/asm/spec_ctrl.h > +++ b/xen/arch/x86/include/asm/spec_ctrl.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017-2018 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h > index fab27ff5532be63d849f5eb94d47d9cb30bb3b67..18245921c27c7f4618a04ac46fc1c2a0c8dd6467 100644 > --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h > +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017-2018 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/include/asm/traps.h b/xen/arch/x86/include/asm/traps.h > index b0dd2d24614dbead8e51bc0924afbb8cdeabb617..d6cb16541148fe0a7cda26071f31ee376ab768c9 100644 > --- a/xen/arch/x86/include/asm/traps.h > +++ b/xen/arch/x86/include/asm/traps.h > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef ASM_TRAP_H > diff --git a/xen/arch/x86/include/asm/vm_event.h b/xen/arch/x86/include/asm/vm_event.h > index 0756124075231d0b7aa9e1a0367b756033750d72..8c98b177a62c5af15fac37af032f8f5f1e3cd51f 100644 > --- a/xen/arch/x86/include/asm/vm_event.h > +++ b/xen/arch/x86/include/asm/vm_event.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __ASM_X86_VM_EVENT_H__ > diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h > index 05e1fbfccfcf9f592108a8db70f7955e52129cca..ded3cff7fb314499b18461408301152a2f5a2dd9 100644 > --- a/xen/arch/x86/include/asm/vpmu.h > +++ b/xen/arch/x86/include/asm/vpmu.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Haitao Shan > */ > diff --git a/xen/arch/x86/include/asm/xenoprof.h b/xen/arch/x86/include/asm/xenoprof.h > index cf6af8c5df525c6925df9eeaae4be52738d21fee..bd93ef6e7cccf099d8f4679764340e328d1ca229 100644 > --- a/xen/arch/x86/include/asm/xenoprof.h > +++ b/xen/arch/x86/include/asm/xenoprof.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __ASM_X86_XENOPROF_H__ > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index 0fe14faa5fa7f4c384b44324c86743e823b53917..409c8b32536666fb51a3474d0ae04e7c6e17ec96 100644 > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* > diff --git a/xen/arch/x86/mm/altp2m.c b/xen/arch/x86/mm/altp2m.c > index 07393befeeed4e9b0230306e60a9167460c511f8..a48cb5567de880e44324f5fd02b8379e7eaf8465 100644 > --- a/xen/arch/x86/mm/altp2m.c > +++ b/xen/arch/x86/mm/altp2m.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c > index 76b4e0425887ff9f3e932dfd54c9fab70ca4585e..989006cb1b377d8192acfea668e891c126c6eef7 100644 > --- a/xen/arch/x86/mm/guest_walk.c > +++ b/xen/arch/x86/mm/guest_walk.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c > index 1da8d3b99edcb81b1eaa46ed2055ddb343209d04..f12467001082fd3922f18338ead92ed10b46d3c4 100644 > --- a/xen/arch/x86/mm/hap/guest_walk.c > +++ b/xen/arch/x86/mm/hap/guest_walk.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c > index 84cb358df1231a4b3a93997b9b2281bb2506b3c5..bcfd6e450268b75483206a7536d9b88a008d3b6e 100644 > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c > index 605e47c16cd54480fce0a2b3d5251f327e91eec7..9ffad29d346cd09ed38dbfe9dc2d486c582c9519 100644 > --- a/xen/arch/x86/mm/hap/nested_ept.c > +++ b/xen/arch/x86/mm/hap/nested_ept.c > @@ -14,7 +14,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #include > #include > diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c > index 098e8e5d4ca9c00de9e9cc870d2573a1b659e670..95d853994037764ecd6fd39d0f2de6f61dd171cb 100644 > --- a/xen/arch/x86/mm/hap/nested_hap.c > +++ b/xen/arch/x86/mm/hap/nested_hap.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/hap/private.h b/xen/arch/x86/mm/hap/private.h > index 1040eaf69f437a90b183c3e8cec683a9659fa028..f60bc084b2fe2ec35200d5b845562b3829e67da8 100644 > --- a/xen/arch/x86/mm/hap/private.h > +++ b/xen/arch/x86/mm/hap/private.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > */ > #ifndef __HAP_PRIVATE_H__ > diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c > index f3aed9fcc966037ebd94451fdc2098cacfbd7e04..07c53bff9566583779291e5a9b5a600161663bab 100644 > --- a/xen/arch/x86/mm/mem_access.c > +++ b/xen/arch/x86/mm/mem_access.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include /* copy_from_guest() */ > diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c > index 01281f786ee05e83d1860340bcf7486f47914d4d..79158a1266090052bbb9fd9d6aa00aa5274a2bcb 100644 > --- a/xen/arch/x86/mm/mem_paging.c > +++ b/xen/arch/x86/mm/mem_paging.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > index 649d93dc54440a15723eb827ba28ae4b4221e877..d3f3d2007502c4480cb5fc4f36e6bff1c618d728 100644 > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h > index c1523aeccf992db0313f3eadbd050a35222cf1bd..93200149ee739badd6ab5e431036939de7830775 100644 > --- a/xen/arch/x86/mm/mm-locks.h > +++ b/xen/arch/x86/mm/mm-locks.h > @@ -19,7 +19,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _MM_LOCKS_H > diff --git a/xen/arch/x86/mm/nested.c b/xen/arch/x86/mm/nested.c > index fab62b2b2dc1db8f76f0b2a3cfb16c8f74d81511..56b0017aac0d70b2eca899f2ca7e5e3bda1210d9 100644 > --- a/xen/arch/x86/mm/nested.c > +++ b/xen/arch/x86/mm/nested.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m-basic.c b/xen/arch/x86/mm/p2m-basic.c > index 47b780d6d63aeccc699567568ecfd5ebf119caac..56da2cae3db622db050c74cd2e2bab219740f071 100644 > --- a/xen/arch/x86/mm/p2m-basic.c > +++ b/xen/arch/x86/mm/p2m-basic.c > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c > index bb143c6c42c69db4e054b9156aad9a18ea0b2378..6cb7fcfcf0e9236443fa78ee228a44ba638f5667 100644 > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c > index 2edab5e5cd91feb2ade4450a56b95ca3c55ee91b..2444ea5690cbd1ef6073cdf17e46cce6db02b251 100644 > --- a/xen/arch/x86/mm/p2m-pod.c > +++ b/xen/arch/x86/mm/p2m-pod.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c > index cd1af33b6772ab1016e8d4c3284a6bc5d282869d..9735cf19ded2e85dd8fe8288852c8a4a3382249d 100644 > --- a/xen/arch/x86/mm/p2m-pt.c > +++ b/xen/arch/x86/mm/p2m-pt.c > @@ -21,7 +21,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c > index c5561fe22160114d0d18124bd6ff35c3171dd523..a757474fb9577a1982b35166c0e8cfdabbb2039e 100644 > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h > index cc0f6766e4df2d9db78463e2c2dcf55b26266820..dcbb5d9875b42f0c2b3c05362a0836ddf5c6825e 100644 > --- a/xen/arch/x86/mm/p2m.h > +++ b/xen/arch/x86/mm/p2m.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > struct p2m_domain *p2m_init_one(struct domain *d); > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > index 1c5f54f92aefcb79b891c25d8d1e922d8c21c37f..59dabd64065b16cc87d4afa8d97e9ba40df92a65 100644 > --- a/xen/arch/x86/mm/paging.c > +++ b/xen/arch/x86/mm/paging.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/physmap.c b/xen/arch/x86/mm/physmap.c > index 2d267b42f73b87554f328eaa69ed5062f7f7a65a..d4cb0317dc4aae8c0fdac763ab734628b82969da 100644 > --- a/xen/arch/x86/mm/physmap.c > +++ b/xen/arch/x86/mm/physmap.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c > index a74b15e3e75b6e882709f0ce0e72001f14e8e9d0..69bd2306733eea291f46c787655a9cc967205cdc 100644 > --- a/xen/arch/x86/mm/shadow/common.c > +++ b/xen/arch/x86/mm/shadow/common.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c > index 88c3c16322f2777231538e382c148af4cb6bc070..a168b6c9d7a52ef5945e8ed22df9387e8cd689d5 100644 > --- a/xen/arch/x86/mm/shadow/hvm.c > +++ b/xen/arch/x86/mm/shadow/hvm.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c > index 3b06cfaf9a5aefb4d7678d9a5a5fb5c361d0319c..3567b6457896803a2c61b50ebd1ddd24daea3931 100644 > --- a/xen/arch/x86/mm/shadow/multi.c > +++ b/xen/arch/x86/mm/shadow/multi.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h > index 5bcd6ae1a8da2a77f3640bb69c010181f0624f2e..34e8186718f793c10285681fb57b8ee7583601fa 100644 > --- a/xen/arch/x86/mm/shadow/multi.h > +++ b/xen/arch/x86/mm/shadow/multi.h > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > extern int > diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h > index 79d82364fc92e650317b8cc68a73c8abe3ae8028..c0954e85d37386c34f155c7531ab0196b909ee3c 100644 > --- a/xen/arch/x86/mm/shadow/private.h > +++ b/xen/arch/x86/mm/shadow/private.h > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_SHADOW_PRIVATE_H > diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c > index ed10d5479c5ef09cc1a1dc0447552d47e608c6ca..9235b24a9f0903fe0c5178f3d2e808374079d4dd 100644 > --- a/xen/arch/x86/mm/shadow/pv.c > +++ b/xen/arch/x86/mm/shadow/pv.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c > index bd6c68b547c9b02cf31182e407ab8900de0dc254..2aea9894ed24e1630356c2a7fa5b9e6881e78ac5 100644 > --- a/xen/arch/x86/mm/shadow/set.c > +++ b/xen/arch/x86/mm/shadow/set.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #define GUEST_PAGING_LEVELS 0 > diff --git a/xen/arch/x86/mm/shadow/types.h b/xen/arch/x86/mm/shadow/types.h > index fac59522b008d8a7fbcd60d99e585b346dd387a0..f491d80306339f7fe46c0cce38016b65e6dc952d 100644 > --- a/xen/arch/x86/mm/shadow/types.h > +++ b/xen/arch/x86/mm/shadow/types.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_SHADOW_TYPES_H > diff --git a/xen/arch/x86/monitor.c b/xen/arch/x86/monitor.c > index 30ca71432c0b822dea660b7ee391b79ed2951f76..db2ea5bd59e30ae46cfdd3b7a8559a0900806710 100644 > --- a/xen/arch/x86/monitor.c > +++ b/xen/arch/x86/monitor.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > index 7ddf0078c3a20ac2e4acf1d09292ba8d581aeac4..f5ae1ca82b63f7a9bf111cbad7cb0e2502ad2485 100644 > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c > index 067ee3b795d0c906702d05ad67e71512396e5b5d..73e99a13f2dc26d8b3e3a5fd6827d8eaf619a3e9 100644 > --- a/xen/arch/x86/pv/callback.c > +++ b/xen/arch/x86/pv/callback.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descriptor-tables.c > index b4135b450cdfb0a5e7b49bcc71f03cb1355ad079..4ac7d6169a31fae87c1c2a49d1049ef6c9a85654 100644 > --- a/xen/arch/x86/pv/descriptor-tables.c > +++ b/xen/arch/x86/pv/descriptor-tables.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c > index 758a20ad9df424db9dfeb8ea08707bf6405b97e8..8249f7561ee4c2a2acf3495df548913a3eca5397 100644 > --- a/xen/arch/x86/pv/emul-gate-op.c > +++ b/xen/arch/x86/pv/emul-gate-op.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c > index 2c07eed9a092df5882161e1a28557e5862c4a5d1..62b7fdefa322c31e674d7bd8263e17c77f0d24c5 100644 > --- a/xen/arch/x86/pv/emul-inv-op.c > +++ b/xen/arch/x86/pv/emul-inv-op.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > index 5da00e24e4ff15a9ef61c10002a3e511fced799c..61994058a8171b7aceb8b0117e67cfc44b5271bd 100644 > --- a/xen/arch/x86/pv/emul-priv-op.c > +++ b/xen/arch/x86/pv/emul-priv-op.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c > index 0a7907ec5e846c00df5fc461cbb3948b7efece40..3ac280963c487e0663a6a0818eb764181ff0b00d 100644 > --- a/xen/arch/x86/pv/emulate.c > +++ b/xen/arch/x86/pv/emulate.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/grant_table.c b/xen/arch/x86/pv/grant_table.c > index 81c72e61ed55888308e51e437805e2b91e7bc112..4c4dadd909064bbdd6e77f766ee89a326d784ad6 100644 > --- a/xen/arch/x86/pv/grant_table.c > +++ b/xen/arch/x86/pv/grant_table.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c > index 2eedfbfae86417a48a682b3cc201ec0d8bfc478e..799407a1808cdd8e36d7fa5977cac35e308a4c23 100644 > --- a/xen/arch/x86/pv/hypercall.c > +++ b/xen/arch/x86/pv/hypercall.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c > index 316a23e77eb76eb7c532601d2779586fc54a7fea..a00816e7535de63726b3cbef307dbc57ced31c77 100644 > --- a/xen/arch/x86/pv/iret.c > +++ b/xen/arch/x86/pv/iret.c > @@ -14,7 +14,7 @@ > * > * You should have received a copy of the GNU General Public > * License along with this program; If not, see > - * . > + * . > */ > > #include > diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c > index aaaf70eb633063e34cc2672dfe5e316f5b023065..e7a731b310a0455048611bdc681d97fab6d5855e 100644 > --- a/xen/arch/x86/pv/misc-hypercalls.c > +++ b/xen/arch/x86/pv/misc-hypercalls.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/mm.c b/xen/arch/x86/pv/mm.c > index 5ed7b3ccdbf209fb94b45c8e6c72eb510aeb5f19..44b74a6ec42a09dc74f39b2ff05c0779899da305 100644 > --- a/xen/arch/x86/pv/mm.c > +++ b/xen/arch/x86/pv/mm.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c > index 5963f5ee2d512a482b76f040eca4f4f314f91390..568dae9db6aa3d96baf0d12d150be2081bcf11df 100644 > --- a/xen/arch/x86/pv/ro-page-fault.c > +++ b/xen/arch/x86/pv/ro-page-fault.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c > index ae1a0e6e65af04715b27fe55a5c316d74923ddb8..5c2b0481d7896066cb1e4ffa61cc9bbcc8e73415 100644 > --- a/xen/arch/x86/pv/shim.c > +++ b/xen/arch/x86/pv/shim.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c > index 97fe54b5ee5a6a95daa6146314f0d3fa482118b8..61de39eece9c514be14777dd4ae7690a018fc3c8 100644 > --- a/xen/arch/x86/pv/traps.c > +++ b/xen/arch/x86/pv/traps.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c > index b26758c2c89faf00719d75db5000c2c12331c848..621da7c204fd25362a96603c2bfe04fee3273b4f 100644 > --- a/xen/arch/x86/smpboot.c > +++ b/xen/arch/x86/smpboot.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c > index a320b81947c85b39e1cea551b68b7aa7fdc4fab7..c61a95f7165e82e408959dd8e6074893e2b63e79 100644 > --- a/xen/arch/x86/spec_ctrl.c > +++ b/xen/arch/x86/spec_ctrl.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017-2018 Citrix Systems Ltd. > */ > diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c > index cade9e12f8fa7aa8f6c8f8c73b8094e05855378e..ec8e67fadf70f3b9ae28aa369c25e0c1ebfca860 100644 > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* > diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c > index 7027c08a926b3a9be0f296c56f7be5d4de537058..3067cb552af3af09ae8376519f2874b85b78e0b8 100644 > --- a/xen/arch/x86/vm_event.c > +++ b/xen/arch/x86/vm_event.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/x86_64/acpi_mmcfg.c b/xen/arch/x86/x86_64/acpi_mmcfg.c > index 2159c68189e4b4f749f8e5a65c55a8a788ec659e..02c557449f9a18f1a06869d34bd308f9c0e8202d 100644 > --- a/xen/arch/x86/x86_64/acpi_mmcfg.c > +++ b/xen/arch/x86/x86_64/acpi_mmcfg.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > * > diff --git a/xen/arch/x86/x86_64/cpu_idle.c b/xen/arch/x86/x86_64/cpu_idle.c > index e2195d57bec7c768f80cef57bcde1c3b8e81b05d..0a5654cc122eaf60223d1c8591063bd959fd6559 100644 > --- a/xen/arch/x86/x86_64/cpu_idle.c > +++ b/xen/arch/x86/x86_64/cpu_idle.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/x86_64/cpufreq.c b/xen/arch/x86/x86_64/cpufreq.c > index 9e1e2050da09688f2cd1cc5343f1a70b7af51ae2..f9ffc6275e6abc41d4a199bcf2f54c1ce59c036e 100644 > --- a/xen/arch/x86/x86_64/cpufreq.c > +++ b/xen/arch/x86/x86_64/cpufreq.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/arch/x86/x86_64/gdbstub.c b/xen/arch/x86/x86_64/gdbstub.c > index 8287124dfb1d0934e8a6d29de82fca374ca00357..4191cc148b9de3887204ba8b30302b19eced0d9b 100644 > --- a/xen/arch/x86/x86_64/gdbstub.c > +++ b/xen/arch/x86/x86_64/gdbstub.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c > index 60db439af3ecb5cda1f641f0a18c5dea6b531ab6..5d7bb0ca3ed249277469ebcc29b01017545050b2 100644 > --- a/xen/arch/x86/x86_64/mm.c > +++ b/xen/arch/x86/x86_64/mm.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > */ > > EMIT_FILE; > diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h > index 433046be663a4983ca5cdfb67b53df4e587f481b..057ae6ad758430c81b0f4c3c8303d2265a7a581f 100644 > --- a/xen/arch/x86/x86_64/mmconfig.h > +++ b/xen/arch/x86/x86_64/mmconfig.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Allen Kay - adapted from linux > */ > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c > index e38f98b547263b505078b649efbb8b9b666f657d..2ea0408e38c6a95f3cc08ad12b899488a97308eb 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* Operand sizes: 8-bit operands or specified/overridden size. */ > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h > index bb7af967ffee61e13fc1d4d2e0220fed77a88707..c5dc51330499b318d71ec60207e577491b10bc21 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.h > +++ b/xen/arch/x86/x86_emulate/x86_emulate.h > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __X86_EMULATE_H__ > diff --git a/xen/common/argo.c b/xen/common/argo.c > index 9ad2ecaa1e42337567cef6ecd53d56965590d60e..dad5b4a5e97d59ad7b8e687e61740264b37fdc67 100644 > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/bunzip2.c b/xen/common/bunzip2.c > index 167ffb7f73967111724b900b296bd6ebbd12711a..041db16dbc3714aefbf01902ff7593bacab75280 100644 > --- a/xen/common/bunzip2.c > +++ b/xen/common/bunzip2.c > @@ -7,7 +7,7 @@ > Robert Sedgewick, and Jon L. Bentley. > > This code is licensed under the LGPLv2: > - LGPL (http://www.gnu.org/copyleft/lgpl.html > + LGPL (https://www.gnu.org/copyleft/lgpl.html > */ > > /* > diff --git a/xen/common/coverage/coverage.c b/xen/common/coverage/coverage.c > index bd90f2866373795137912561c3897e01ab95a501..efecaceb2ebd7ae0a949c68960fc363563f1b0bd 100644 > --- a/xen/common/coverage/coverage.c > +++ b/xen/common/coverage/coverage.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/common/dm.c b/xen/common/dm.c > index 201b652deb7eb09e9b78bdaefdf07ca3faa0a135..a335edb982f2814cd953678feb2777d22153724e 100644 > --- a/xen/common/dm.c > +++ b/xen/common/dm.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c > index f5e0b12d15209d3d43ba1877e9def37b31ca32b7..65b75bc43837b52b891cca493bc4eedd82e21cc5 100644 > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include "event_channel.h" > diff --git a/xen/common/gdbstub.c b/xen/common/gdbstub.c > index df8d122bce8d8c7fe0ede2303bfc46148712f4c4..a97f75ce94f140325300d64669a65cad973965cf 100644 > --- a/xen/common/gdbstub.c > +++ b/xen/common/gdbstub.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c > index b896f9af0e48d77b5d8e4d62d4bf2c15a3d675f7..a679c269d2680fff23b110eea8e80dbd4ec1fa4c 100644 > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -20,7 +20,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c > index ecb8f545e1c4c158272c9cd48090bb62ef88a567..763fa524806c925096443f1740cdebd5932ec696 100644 > --- a/xen/common/ioreq.c > +++ b/xen/common/ioreq.c > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/common/libelf/libelf-dominfo.c b/xen/common/libelf/libelf-dominfo.c > index 24d1371dd7a95d8d8f199ddd24f7d3fd0df398ea..22f5105412fe39361a239cf478dcb22d6e29ec92 100644 > --- a/xen/common/libelf/libelf-dominfo.c > +++ b/xen/common/libelf/libelf-dominfo.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "libelf-private.h" > diff --git a/xen/common/libelf/libelf-loader.c b/xen/common/libelf/libelf-loader.c > index 629cc0d3e611f065689f239e368100c0624ee5a6..69571dfb6b3215ba381d8546b72774506c3704bc 100644 > --- a/xen/common/libelf/libelf-loader.c > +++ b/xen/common/libelf/libelf-loader.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #ifdef __XEN__ > diff --git a/xen/common/libelf/libelf-private.h b/xen/common/libelf/libelf-private.h > index 47db679966c6d0019a883123e7323fd28a96e1a6..d2f71196e1d80e00b499a4e80b5802b1ddf0dc63 100644 > --- a/xen/common/libelf/libelf-private.h > +++ b/xen/common/libelf/libelf-private.h > @@ -10,7 +10,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > #ifndef __LIBELF_PRIVATE_H__ > #define __LIBELF_PRIVATE_H__ > diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c > index a9edb6a8dcb348b1de77966dd96e6c2dcc82d4ef..245ca26fbea8f9e9058d02d23155b8ca1472482f 100644 > --- a/xen/common/libelf/libelf-tools.c > +++ b/xen/common/libelf/libelf-tools.c > @@ -12,7 +12,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "libelf-private.h" > diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c > index 010e6f8dbfe9fbbd5223c9d1322a48e4f1d324f3..4bb463b5226065deb5be3983e994a71d190174ea 100644 > --- a/xen/common/mem_access.c > +++ b/xen/common/mem_access.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/xen/common/monitor.c b/xen/common/monitor.c > index d5c9ff1cbf8cc71dfc1f31fbefa8ad21e2cdab99..4c89d9b85e38cf43c1f12cd9404c25667cc0e774 100644 > --- a/xen/common/monitor.c > +++ b/xen/common/monitor.c > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index e40473f71ead2dbc182ecb80cac980b678e69280..806fc2ff37e0a7e2d61e600b6744b909043d10d9 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > /* > diff --git a/xen/common/pdx.c b/xen/common/pdx.c > index c91875fabe2b070ba42a043be2a95ec846c5f832..dae46270c15f022ae24aa9a9d71f7c03b5a47902 100644 > --- a/xen/common/pdx.c > +++ b/xen/common/pdx.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/preempt.c b/xen/common/preempt.c > index 3b4178fd44acaef5d99e1b01c38a8ee483adea47..5d7a85c7f8623fc84940c3dfe246ef424babe9d2 100644 > --- a/xen/common/preempt.c > +++ b/xen/common/preempt.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/radix-tree.c b/xen/common/radix-tree.c > index adc3034222dc9f7177b415d6ef895ce6ad80f3f6..06fe1bd5d36da89ba0b6cc33995b9f05ab09e930 100644 > --- a/xen/common/radix-tree.c > +++ b/xen/common/radix-tree.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/rcupdate.c b/xen/common/rcupdate.c > index 70b4d21b0f1d6da758f1df0f1c5229c6afdf200e..e3caf0e322ff6fb9f9bcc421be32a752d7601f2d 100644 > --- a/xen/common/rcupdate.c > +++ b/xen/common/rcupdate.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) IBM Corporation, 2001 > * > diff --git a/xen/common/sched/null.c b/xen/common/sched/null.c > index 65a0a6c5312d25052fda69c0be1898ce41062bb9..e375f715e50ff885f5a27fec90b1144994a70b28 100644 > --- a/xen/common/sched/null.c > +++ b/xen/common/sched/null.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > /* > diff --git a/xen/common/stop_machine.c b/xen/common/stop_machine.c > index 3adbe380de965d7e11ff0692fe707a1803c1d22a..af4b5ef728419a63d25c604f292727226ba4a0cd 100644 > --- a/xen/common/stop_machine.c > +++ b/xen/common/stop_machine.c > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/common/time.c b/xen/common/time.c > index 92f7b72464723e6b4830c6db29d9d30ef46f47a7..8f659118dada04384682222f3e4dc98418102054 100644 > --- a/xen/common/time.c > +++ b/xen/common/time.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/common/unlzma.c b/xen/common/unlzma.c > index 69448d7b398634b6543b1fcea7b6101724c17b36..a45996744b424a2a9ee073c1bc69d2d4853b4624 100644 > --- a/xen/common/unlzma.c > +++ b/xen/common/unlzma.c > @@ -25,7 +25,7 @@ > * Lesser General Public License for more details. > * > * You should have received a copy of the GNU Lesser General Public > - * License along with this library; If not, see . > + * License along with this library; If not, see . > */ > > #include "decompress.h" > diff --git a/xen/common/unlzo.c b/xen/common/unlzo.c > index 23eff1354fe0679299951abfb3fbe2bcc2adc699..65f76c890d3b8fd18de1716942ceb694b5dd4f6a 100644 > --- a/xen/common/unlzo.c > +++ b/xen/common/unlzo.c > @@ -22,7 +22,7 @@ > * > * You should have received a copy of the GNU General Public License > * along with this program; see the file COPYING. > - * If not, see . > + * If not, see . > * > * Markus F.X.J. Oberhumer > * > diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c > index ecf49c38a9889f4ddb6c7f73b3cabb386f18ba73..2a64811551081217c0b8eca185c5f879f2b62a01 100644 > --- a/xen/common/vm_event.c > +++ b/xen/common/vm_event.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/xen/common/wait.c b/xen/common/wait.c > index 86d3b15419db27ad54ef4d9c94fc8418d0471406..8ce592ee0440f56c5804e64a0d8eb514f7ab2e34 100644 > --- a/xen/common/wait.c > +++ b/xen/common/wait.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/acpi/apei/apei-base.c b/xen/drivers/acpi/apei/apei-base.c > index de75c1cef9922f8fd7a82b13ce1446b6231a612e..699e7f0e613ef2c24db3fff01bf4d7af5a2d2f5c 100644 > --- a/xen/drivers/acpi/apei/apei-base.c > +++ b/xen/drivers/acpi/apei/apei-base.c > @@ -28,7 +28,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > #include > #include > diff --git a/xen/drivers/acpi/apei/apei-io.c b/xen/drivers/acpi/apei/apei-io.c > index eadf7a4dab53d7be15c6d4183c1beec0491bfb14..3bc468a1d10a33dc998ae7acda2cc0707cd7242a 100644 > --- a/xen/drivers/acpi/apei/apei-io.c > +++ b/xen/drivers/acpi/apei/apei-io.c > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c > index 40d8f00270d0ac5acab558661d4041f1634c6bf9..2dad97cff70ee564de66c4878eb66ce85c07e771 100644 > --- a/xen/drivers/acpi/apei/erst.c > +++ b/xen/drivers/acpi/apei/erst.c > @@ -22,7 +22,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/acpi/apei/hest.c b/xen/drivers/acpi/apei/hest.c > index 5881275d2f3762342043c7a7323ca3e42014e0da..d83795c7c6dbf5c82cbcb6347871d0a8a8bbec75 100644 > --- a/xen/drivers/acpi/apei/hest.c > +++ b/xen/drivers/acpi/apei/hest.c > @@ -23,7 +23,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/acpi/numa.c b/xen/drivers/acpi/numa.c > index bc6e888234e4cb6266909130377c90bed5f5f2ba..d1e2a51eb14d098a5dc84a8f994c7c7a50498bd1 100644 > --- a/xen/drivers/acpi/numa.c > +++ b/xen/drivers/acpi/numa.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > * > diff --git a/xen/drivers/acpi/osl.c b/xen/drivers/acpi/osl.c > index 389505f786668dc4b6859956ee51f4f4df85f675..c080882cc71d7b42e00dccc7ed49949fa371bad2 100644 > --- a/xen/drivers/acpi/osl.c > +++ b/xen/drivers/acpi/osl.c > @@ -18,7 +18,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > * > diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c > index 1bae6351019be9662c33ebc479d2d7470e8096fb..5d52ffdad1e1b6065888e01e5a00412f6a365f01 100644 > --- a/xen/drivers/acpi/pmstat.c > +++ b/xen/drivers/acpi/pmstat.c > @@ -14,7 +14,7 @@ > # more details. > # > # You should have received a copy of the GNU General Public License along with > -# this program; If not, see . > +# this program; If not, see . > # > # The full GNU General Public License is included in this distribution in the > # file called LICENSE. > diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c > index 96ff96b84c6676ec9c6b13070382b2533de1f88c..c6c950598add102d19b9321a13fd7d76b4082bf5 100644 > --- a/xen/drivers/acpi/tables.c > +++ b/xen/drivers/acpi/tables.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > * > diff --git a/xen/drivers/char/consoled.c b/xen/drivers/char/consoled.c > index 222e01844271a927e693d9c242e2124374bb1b3c..c53c6645ea2f900e9944b5b6a6c7ad04251bf8eb 100644 > --- a/xen/drivers/char/consoled.c > +++ b/xen/drivers/char/consoled.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c > index b1e25e0468a49d764f1b40c522019e75dd496f4e..0e4a56dbef3dc955299ce6f38f701aa03a54df50 100644 > --- a/xen/drivers/char/meson-uart.c > +++ b/xen/drivers/char/meson-uart.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c > index a00618b96fbc3bbdeaf09203e297b1b972bd9443..42307c4de81a44f5418700e0353a8c8d47338fcb 100644 > --- a/xen/drivers/char/mvebu-uart.c > +++ b/xen/drivers/char/mvebu-uart.c > @@ -15,7 +15,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/char/xen_pv_console.c b/xen/drivers/char/xen_pv_console.c > index 1536bdaf524583feb910a7bcf693c865df692265..37a9539e537ac2d2d388ebfb028c4dfb1d755d65 100644 > --- a/xen/drivers/char/xen_pv_console.c > +++ b/xen/drivers/char/xen_pv_console.c > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2017 Citrix Systems Ltd. > */ > diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c > index 60b781f872027c99c75c6d7eb3be82fa8e00ffbd..5127a085e6384352230c7bf9749da7ad07da4e1a 100644 > --- a/xen/drivers/char/xhci-dbc.c > +++ b/xen/drivers/char/xhci-dbc.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (c) 2019 Assured Information Security. > */ > diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c > index a94520ee57ac914be1d51a4a498c8d66cf15f3c2..30368afc6bec2ae579286b4953f7fd8d0966bb7f 100644 > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -21,7 +21,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/drivers/passthrough/amd/iommu-defs.h b/xen/drivers/passthrough/amd/iommu-defs.h > index 35de548e3a783c8e2be4aa6a2a04bfbc8f9bb7af..11726aeaa742687b72053ac51ccd3659a475bba6 100644 > --- a/xen/drivers/passthrough/amd/iommu-defs.h > +++ b/xen/drivers/passthrough/amd/iommu-defs.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef AMD_IOMMU_DEFS_H > diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h > index 8bc3c35b1bb1d13d7d321145788996197821f1e5..9692c89aee9c7fc5f841faac7b2792423108ca76 100644 > --- a/xen/drivers/passthrough/amd/iommu.h > +++ b/xen/drivers/passthrough/amd/iommu.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > #ifndef AMD_IOMMU_H > #define AMD_IOMMU_H > diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c > index 3b577c9b390cad35960eef212f5d4d75fd1c2a75..bb821cf29936645bf2545d467c184630eee4a37f 100644 > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/iommu_cmd.c b/xen/drivers/passthrough/amd/iommu_cmd.c > index 40ddf366bb4d01b8effe21cc6bcb5adc4f55fff4..a94caada9597e2160bfb27427de2fb5d557d7c6e 100644 > --- a/xen/drivers/passthrough/amd/iommu_cmd.c > +++ b/xen/drivers/passthrough/amd/iommu_cmd.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include "iommu.h" > diff --git a/xen/drivers/passthrough/amd/iommu_detect.c b/xen/drivers/passthrough/amd/iommu_detect.c > index 2317fa6a7d8dc9967ca7320861da27009047a008..6d6d7e17a885f28088da766017fb24970b3cf0e1 100644 > --- a/xen/drivers/passthrough/amd/iommu_detect.c > +++ b/xen/drivers/passthrough/amd/iommu_detect.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c > index 80a331f546ed847ffcc418e25e16e3789fe7a950..f8d1d9a4b1b72b63d4c0844d7ba2de54fc2ad919 100644 > --- a/xen/drivers/passthrough/amd/iommu_guest.c > +++ b/xen/drivers/passthrough/amd/iommu_guest.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c > index 9773ccfcb41fe700af5c592777ba9d3eab3f0ef7..2c5a9ac2bca1fcc8036b76cd00bc10106a9705ea 100644 > --- a/xen/drivers/passthrough/amd/iommu_init.c > +++ b/xen/drivers/passthrough/amd/iommu_init.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c > index f4de09f43180e4f07c1b354eab39152afe6f50f0..6af1bca33c146d4351f6833e751dde328033ec06 100644 > --- a/xen/drivers/passthrough/amd/iommu_intr.c > +++ b/xen/drivers/passthrough/amd/iommu_intr.c > @@ -13,7 +13,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c > index 993bac6f8878d2b64521ce5c59e8589e40be5af1..b4cb59ca2ea21a607a8e5b554848b117e320cae6 100644 > --- a/xen/drivers/passthrough/amd/iommu_map.c > +++ b/xen/drivers/passthrough/amd/iommu_map.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c > index 4ba8e764b22f4b5bfd6772071144cfecfa323816..bcd928078d532e76c3efc590698a920663875750 100644 > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/arm/iommu_fwspec.c b/xen/drivers/passthrough/arm/iommu_fwspec.c > index 8c97c7ca4807c4b01bf171a9a7dee5f0bfc4648f..bc082a7e1ff532cdfaab917213bd19c8e22914d7 100644 > --- a/xen/drivers/passthrough/arm/iommu_fwspec.c > +++ b/xen/drivers/passthrough/arm/iommu_fwspec.c > @@ -20,7 +20,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/arm/iommu_helpers.c b/xen/drivers/passthrough/arm/iommu_helpers.c > index 5cb19874819357b5cd58638864b56c505d07b37a..4e026eca681f5653996cd72debefb7ccc0259581 100644 > --- a/xen/drivers/passthrough/arm/iommu_helpers.c > +++ b/xen/drivers/passthrough/arm/iommu_helpers.c > @@ -20,7 +20,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > index 682bf12aaaf5bd7b50afda56cdc9694984442c57..425ba0330f1100d0ce7729d6a534d3172728233e 100644 > --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c > +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > @@ -34,7 +34,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index d58c5cd0bf772226904038e5c05d901ba1d5e1f9..e1f59f5889cc397921eedebed43cb5d6ebaea2b2 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -67,7 +67,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program. If not, see . > + * along with this program. If not, see . > * > */ > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index 0a514821b3360b677a183b45a73c19ac191a4edc..e62b51c3d7f3db228b58f37138e77bd46fb549c9 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -11,7 +11,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) 2013 ARM Limited > * > diff --git a/xen/drivers/passthrough/ats.c b/xen/drivers/passthrough/ats.c > index 7f7b16dc490c2e287b838fa8e9a1b0c6a18c3c72..8b8a424f7a22e262862b42d17c2a2d6fb5cc3927 100644 > --- a/xen/drivers/passthrough/ats.c > +++ b/xen/drivers/passthrough/ats.c > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/ats.h b/xen/drivers/passthrough/ats.h > index c202f4ecdd6753de10427bb4adfeaa00d6a4915a..2e8bf13d07dbd40ff0222f32b72684b6eed21626 100644 > --- a/xen/drivers/passthrough/ats.h > +++ b/xen/drivers/passthrough/ats.h > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef _ATS_H_ > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c > index b4dfa95dfd8e49b2c953d09bbfe5190ef04f7109..d72ac5f94a953d165d175f05467ca02ffa9114aa 100644 > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 9f8819785b49f26d7a03e30d51ac5dd0d6700719..d9d6e0e6db990cf822705bd583085465e13de4b3 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c > index 78c8bad1515a231b0a501308e3003a5ce124fb2b..d71ad72dc434832308c047526021481c5622fbe3 100644 > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthrough/vtd/dmar.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Ashok Raj > * Copyright (C) Shaohua Li > diff --git a/xen/drivers/passthrough/vtd/dmar.h b/xen/drivers/passthrough/vtd/dmar.h > index a1f2353a511f4f432494cd0d318ae9531a6c9001..33b9cea7ac835e812c690d6120da93968bb7b12c 100644 > --- a/xen/drivers/passthrough/vtd/dmar.h > +++ b/xen/drivers/passthrough/vtd/dmar.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Ashok Raj > * Copyright (C) Shaohua Li > diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h > index 39602d1f88f82fdc94d2d94bab07dc4d95692223..4115e48b6047091f60e929199e1f13a264446ae1 100644 > --- a/xen/drivers/passthrough/vtd/extern.h > +++ b/xen/drivers/passthrough/vtd/extern.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Weidong Han > diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c > index 1512e4866b8cce8453c4c65838425c1ae093f197..0f0d390714ee77924570af6a7d6d0b8a954f0cc7 100644 > --- a/xen/drivers/passthrough/vtd/intremap.c > +++ b/xen/drivers/passthrough/vtd/intremap.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Xiaohui Xin > diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c > index 62e143125d99443e9949e51ccc65a1b92ff3b648..7f3780fadff7e48d8a5e9f98e87d9533b22194bd 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Ashok Raj > * Copyright (C) Shaohua Li > diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h > index 78aa8a96f5a01b7a5fb01d5ebcb3a934c0a51f29..caaa3d51ea9eafe50eeae2cc22691e8ecf55f3e3 100644 > --- a/xen/drivers/passthrough/vtd/iommu.h > +++ b/xen/drivers/passthrough/vtd/iommu.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Ashok Raj > */ > diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c > index 4f9ad136b9c50ec2ea86cd698879d7beb5444133..8952b454d5b28ce110346807169d8476b0b73e11 100644 > --- a/xen/drivers/passthrough/vtd/qinval.c > +++ b/xen/drivers/passthrough/vtd/qinval.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Xiaohui Xin > diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c > index fcc8f73e8b906a3a7279410b7e80b55c6e4e61bd..763dd335a8ff7a4bf23ad4f135c7fdf6d523b94b 100644 > --- a/xen/drivers/passthrough/vtd/quirks.c > +++ b/xen/drivers/passthrough/vtd/quirks.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Allen Kay > */ > diff --git a/xen/drivers/passthrough/vtd/utils.c b/xen/drivers/passthrough/vtd/utils.c > index 7c4d032f4f275dca753b011ef6f337e231fd3107..0a1e2ced49db198b6b02dd0471c184803d26c7cd 100644 > --- a/xen/drivers/passthrough/vtd/utils.c > +++ b/xen/drivers/passthrough/vtd/utils.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > */ > diff --git a/xen/drivers/passthrough/vtd/vtd.h b/xen/drivers/passthrough/vtd/vtd.h > index cb2df76eeddbd1f1e3682f7acc28433efdc5c643..af6d64ce20a41ec74ebbd02dce3509b5539834d8 100644 > --- a/xen/drivers/passthrough/vtd/vtd.h > +++ b/xen/drivers/passthrough/vtd/vtd.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Weidong Han > diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c > index 04d702b1d6b1985e4e0a07eb29118133b1682c77..fba0d92d6011ae5c422b777af31c4b5efedba93a 100644 > --- a/xen/drivers/passthrough/vtd/x86/ats.c > +++ b/xen/drivers/passthrough/vtd/x86/ats.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Author: Allen Kay > */ > diff --git a/xen/drivers/passthrough/vtd/x86/hvm.c b/xen/drivers/passthrough/vtd/x86/hvm.c > index bc776cf7daaa206273f1e90ef9667a0725444f69..420bc6aa4e3b4c0624535761e7882561c9552dec 100644 > --- a/xen/drivers/passthrough/vtd/x86/hvm.c > +++ b/xen/drivers/passthrough/vtd/x86/hvm.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Weidong Han > diff --git a/xen/drivers/passthrough/vtd/x86/vtd.c b/xen/drivers/passthrough/vtd/x86/vtd.c > index 76f12adc23dfc5f3d6d62056f7e85029d212e618..ccb5710683a3179b3e7a3b091612a60adc0cb786 100644 > --- a/xen/drivers/passthrough/vtd/x86/vtd.c > +++ b/xen/drivers/passthrough/vtd/x86/vtd.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Weidong Han > diff --git a/xen/drivers/passthrough/x86/hvm.c b/xen/drivers/passthrough/x86/hvm.c > index dd09ec22f12d53c1f1a3f1643a7792281eeffc0b..c424a7fd01a6c62b7318ade02d66ad2c70ac28de 100644 > --- a/xen/drivers/passthrough/x86/hvm.c > +++ b/xen/drivers/passthrough/x86/hvm.c > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > * Copyright (C) Xiaohui Xin > diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c > index f671b0f2bb45b22059a04be8f76d92c80b6700e9..dc5924d1ef6b7a3bfab941f6724e1d8b0e0077a8 100644 > --- a/xen/drivers/passthrough/x86/iommu.c > +++ b/xen/drivers/passthrough/x86/iommu.c > @@ -9,7 +9,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c > index ec2e978a4e6b16706f1c6ad61e4648b56c15f009..ac0418cffd9a42bbd92ce02e9476127ea84cac3e 100644 > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -14,7 +14,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c > index 8f2b59e61aa42eca4d2bb583019a6e2df952b9f3..9649cf30c116346497017009ba32ad9df866a999 100644 > --- a/xen/drivers/vpci/msi.c > +++ b/xen/drivers/vpci/msi.c > @@ -13,7 +13,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c > index bea0cc7aede17847bdfc1a4735d1e0a06acf6fb0..cdad7cbcb6a96bf74250b4f61b46bb011ff03a82 100644 > --- a/xen/drivers/vpci/msix.c > +++ b/xen/drivers/vpci/msix.c > @@ -14,7 +14,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c > index 6d48d496bb4871e28f3c25a730dcbdf88dd48151..662419892399f5c5f2daec705fcedaf83e9dfef7 100644 > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -14,7 +14,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #include > diff --git a/xen/include/xen/acpi.h b/xen/include/xen/acpi.h > index 352f27f6a72396ada2dc30c6374d766614c2094f..1e1ea51fc6b55868f7d7643100d84ec008285762 100644 > --- a/xen/include/xen/acpi.h > +++ b/xen/include/xen/acpi.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/include/xen/argo.h b/xen/include/xen/argo.h > index fd4cfdd55c0ab90cd9ed2723a1fd7e867d33f4de..6653970bc45b9c23484985b27e7aef14c4223363 100644 > --- a/xen/include/xen/argo.h > +++ b/xen/include/xen/argo.h > @@ -9,7 +9,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __XEN_ARGO_H__ > diff --git a/xen/include/xen/atomic.h b/xen/include/xen/atomic.h > index 529213ebbb4b8cf6ab40b3f32fcf93c8be8a29e7..550087f5f29b3a1c4826b50a80ad9db7a2d0a190 100644 > --- a/xen/include/xen/atomic.h > +++ b/xen/include/xen/atomic.h > @@ -16,7 +16,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __XEN_ATOMIC_H__ > diff --git a/xen/include/xen/cper.h b/xen/include/xen/cper.h > index 8788ceff126d98d7edd9d963c89934a2671fbd59..5df340bae735d22deb5359ee299bacbb46cbeab5 100644 > --- a/xen/include/xen/cper.h > +++ b/xen/include/xen/cper.h > @@ -15,7 +15,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef LINUX_CPER_H > diff --git a/xen/include/xen/cpuidle.h b/xen/include/xen/cpuidle.h > index 521a8deb04c23bba99178d341d0cc05288b6382d..e04d928291a32054298241f26f7f3a141b1d2c01 100644 > --- a/xen/include/xen/cpuidle.h > +++ b/xen/include/xen/cpuidle.h > @@ -19,7 +19,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License along > - * with this program; If not, see . > + * with this program; If not, see . > * > * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > */ > diff --git a/xen/include/xen/dm.h b/xen/include/xen/dm.h > index 18417d57f1e5a20d2f97d40bb19cfebfb5e6217a..cfeef82473a276efa07c9fa6fbdc50f480021829 100644 > --- a/xen/include/xen/dm.h > +++ b/xen/include/xen/dm.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __XEN_DM_H__ > diff --git a/xen/include/xen/gdbstub.h b/xen/include/xen/gdbstub.h > index 18c960969b769d20d035855479391407587c3636..9fd079d85616df1b12356109969a36cb25459eb9 100644 > --- a/xen/include/xen/gdbstub.h > +++ b/xen/include/xen/gdbstub.h > @@ -14,7 +14,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __XEN_GDBSTUB_H__ > diff --git a/xen/include/xen/grant_table.h b/xen/include/xen/grant_table.h > index 85fe6b7b5eb20c078ee422d1550be755af799a86..84d61b3ce99c0a0672bbd69afdaf53b12764ca94 100644 > --- a/xen/include/xen/grant_table.h > +++ b/xen/include/xen/grant_table.h > @@ -17,7 +17,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef __XEN_GRANT_TABLE_H__ > diff --git a/xen/include/xen/inttypes.h b/xen/include/xen/inttypes.h > index 28c0053f1c7adab0d56615b2a217ebbeb4e516a8..4db9ab779331caf7826c6bcaf14574de8b704b64 100644 > --- a/xen/include/xen/inttypes.h > +++ b/xen/include/xen/inttypes.h > @@ -12,7 +12,7 @@ > Lesser General Public License for more details. > > You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; If not, see . */ > + License along with the GNU C Library; If not, see . */ > > /* > * ISO C99: 7.8 Format conversion of integer types > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index 4f22fc1bed5523c5b1a8951579975e0712c08c28..964b690628faef1bbd9ec3edc2775fd79f3bbe0f 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -11,7 +11,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > * > * Copyright (C) Allen Kay > */ > diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h > index a26614d331e3c98f9d4b7967b6fdd9d4e6a49de6..2e2004cf6a07e8992c5db80972685a4e4c5c7fd8 100644 > --- a/xen/include/xen/ioreq.h > +++ b/xen/include/xen/ioreq.h > @@ -13,7 +13,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #ifndef __XEN_IOREQ_H__ > diff --git a/xen/include/xen/mem_access.h b/xen/include/xen/mem_access.h > index 4e4811680dc96fc40928f1b21208c6dc3f5f49ec..1ed4fde2a8cafce4f6a549ea286837b90d3e418b 100644 > --- a/xen/include/xen/mem_access.h > +++ b/xen/include/xen/mem_access.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > #ifndef _XEN_MEM_ACCESS_H > diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h > index 6b17a9307195df172b62bd9acf2cbb2c964dfad4..2652b016ed8a2f855717a32a2977c7266c049749 100644 > --- a/xen/include/xen/monitor.h > +++ b/xen/include/xen/monitor.h > @@ -16,7 +16,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > - * License along with this program; If not, see . > + * License along with this program; If not, see . > */ > > #ifndef __XEN_MONITOR_H__ > diff --git a/xen/include/xen/multiboot.h b/xen/include/xen/multiboot.h > index 80a1761d9ee7742b30d5c8a18a4d962dfed181da..d3a1998c93d9527aef2a8a224fa6778783e157b8 100644 > --- a/xen/include/xen/multiboot.h > +++ b/xen/include/xen/multiboot.h > @@ -12,7 +12,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . */ > + along with this program; If not, see . */ > > #ifndef __MULTIBOOT_H__ > #define __MULTIBOOT_H__ > diff --git a/xen/include/xen/radix-tree.h b/xen/include/xen/radix-tree.h > index 58c40312e61986e311576beff7b8627cfde64c7b..3ffe32b27c60ab7bc74515550bee1f09b57e3985 100644 > --- a/xen/include/xen/radix-tree.h > +++ b/xen/include/xen/radix-tree.h > @@ -14,7 +14,7 @@ > * General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > #ifndef _XEN_RADIX_TREE_H > #define _XEN_RADIX_TREE_H > diff --git a/xen/include/xen/rbtree.h b/xen/include/xen/rbtree.h > index 77bf57d4abc8da2ed7cfa6adbe5f8ab78fc17a29..99473a8db0a46bdbe845c4730956e2e6c1e35e25 100644 > --- a/xen/include/xen/rbtree.h > +++ b/xen/include/xen/rbtree.h > @@ -13,7 +13,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > > linux/include/linux/rbtree.h > > diff --git a/xen/include/xen/rcupdate.h b/xen/include/xen/rcupdate.h > index f123b77aafaa1cb50ba6bceea88cfb4408e9cb6d..cde46128944ae23dad12061225410f88b1e1f468 100644 > --- a/xen/include/xen/rcupdate.h > +++ b/xen/include/xen/rcupdate.h > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > * > * Copyright (C) IBM Corporation, 2001 > * > diff --git a/xen/include/xen/vm_event.h b/xen/include/xen/vm_event.h > index 92811d9110e5509009aaa47278d63643412bd0ee..d60681bec668ebf0d27dac69b8d3ade6ae3f333d 100644 > --- a/xen/include/xen/vm_event.h > +++ b/xen/include/xen/vm_event.h > @@ -16,7 +16,7 @@ > * GNU General Public License for more details. > * > * You should have received a copy of the GNU General Public License > - * along with this program; If not, see . > + * along with this program; If not, see . > */ > > > diff --git a/xen/lib/list-sort.c b/xen/lib/list-sort.c > index de1af2ef8b0c279f3fbd9b93aa68619bb34dad51..82670110e20efda833a85f99838f461f42e10fdd 100644 > --- a/xen/lib/list-sort.c > +++ b/xen/lib/list-sort.c > @@ -12,7 +12,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > > #include > diff --git a/xen/lib/rbtree.c b/xen/lib/rbtree.c > index 8b6c2c7572cd9793bbb77192704db27e04cb3988..ba03bfae71aafa1c590f66f96d586a2b4169eadc 100644 > --- a/xen/lib/rbtree.c > +++ b/xen/lib/rbtree.c > @@ -15,7 +15,7 @@ > GNU General Public License for more details. > > You should have received a copy of the GNU General Public License > - along with this program; If not, see . > + along with this program; If not, see . > > linux/lib/rbtree.c > */ > diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c > index b89b364287840623792f853e44070ce24a2b3cc4..1570fb2b2f72b6829f7bb39d939240d7bcb6e69e 100644 > --- a/xen/xsm/silo.c > +++ b/xen/xsm/silo.c > @@ -15,7 +15,7 @@ > * more details. > * > * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > + * this program; If not, see . > */ > #define XSM_NO_WRAPPERS > #include > -- > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab > From xen-devel-bounces@lists.xenproject.org Wed Feb 08 22:59:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 22:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492044.761434 (Exim 4.92) (envelope-from ) id 1pPtPo-0007PL-DD; Wed, 08 Feb 2023 22:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492044.761434; Wed, 08 Feb 2023 22:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtPo-0007PC-9U; Wed, 08 Feb 2023 22:59:48 +0000 Received: by outflank-mailman (input) for mailman id 492044; Wed, 08 Feb 2023 22:59:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtPn-0007Kn-8u for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 22:59:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47ee4f12-a804-11ed-933c-83870f6b2ba8; Wed, 08 Feb 2023 23:59:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6DF28617F5; Wed, 8 Feb 2023 22:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3532C4339B; Wed, 8 Feb 2023 22:59:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47ee4f12-a804-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675897184; bh=YnK7HRJ4hK2uu+41T7pp/AupUdbQmAdObEN04h8C2U0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=C4OZWlarqbqgXTzUTXxTgRgPSqm+iTcyAQtKcRHbTbCjJy2XgwzPg3+U7rrgWP2nO /9RmR0EK5bh38ebNB1FgEdkkIWmVjPn2nTgO9osd1dU1YqbbUJgFBQ03WM3myW2ttn qg3XZ3x8IwOyc025KSpP7+nTaqhL9tKZIrteG+A6ZfvPUfM26dAZ//AxKCLxUIKOX8 HfSht4wyQLcXX1LTH1++tqm01kd8L4aVUIxpN3O4j3br8aqFGDaOd9WUaeLrHFEzUM xcNH5tJbxRhLFRVd5DTO/vm0sZme+FvHyLDpGwVtHJEqQFv26tImvnPdVcy5Sj7Zb2 tuBuZmks7HRAg== Date: Wed, 8 Feb 2023 14:59:42 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksii Kurochko cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Doug Goldstein Subject: Re: [PATCH v3 14/14] automation: modify RISC-V smoke test In-Reply-To: <95527748699e6ab643dc2fdee634fe934ae12f60.1675779308.git.oleksii.kurochko@gmail.com> Message-ID: References: <95527748699e6ab643dc2fdee634fe934ae12f60.1675779308.git.oleksii.kurochko@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 7 Feb 2023, Oleksii Kurochko wrote: > The patch modifies the grep pattern to reflect the usage of WARN. > > Signed-off-by: Oleksii Kurochko Acked-by: Stefano Stabellini > --- > Changes in V3: > - Update commit message > --- > Changes in V2: > - Leave only the latest "grep ..." > --- > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > index e0f06360bc..02fc66be03 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > |& tee smoke.serial > > set -e > -(grep -q "Hello from C env" smoke.serial) || exit 1 > +(grep -q "WARN is most likely working" smoke.serial) || exit 1 > exit 0 > -- > 2.39.0 > From xen-devel-bounces@lists.xenproject.org Wed Feb 08 23:21:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 23:21:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492053.761444 (Exim 4.92) (envelope-from ) id 1pPtki-0002jT-3G; Wed, 08 Feb 2023 23:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492053.761444; Wed, 08 Feb 2023 23:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtki-0002jM-0U; Wed, 08 Feb 2023 23:21:24 +0000 Received: by outflank-mailman (input) for mailman id 492053; Wed, 08 Feb 2023 23:21:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPtkg-0002jG-I5 for xen-devel@lists.xenproject.org; Wed, 08 Feb 2023 23:21:22 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a498852-a807-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 00:21:20 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D35AD5C0110; Wed, 8 Feb 2023 18:21:17 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 08 Feb 2023 18:21:17 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 18:21:14 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a498852-a807-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675898477; x= 1675984877; bh=bKBpNMNaZlqzKjlPvpCySfuqS5eEM4ZOMXPseCuUqYI=; b=M STq6MfnG95qDHkYvBIpAmRAz6ytJ8Sobe3oEgXfMdmI0W+q6LKlMpNVeOCkYzgJs hvAlPORzF8ctam2dp22+aJm4zcKqhAQfLs16WlnVIcZzP8SfW/wfHOfTT51+8xsc dnG+22o2JLxTPHIrgS+0MMu01hMlRjcYI002qq49Mr/O/BCuM5gMbDUC29zELTaR f+QxxALJSbk0Y9zxsM05lh06eHW3B0aBQYD5bzKOysfkQ3I7rL+WKorZb7MrCgKe WUKN9QcGtXM9MtGsDmssgU15KGlJ3YuZyhZc6c3uKVe3IJqElGVLo+VWnIvdMUDC LRfdaFJMPtPZ/Lh/IxQ+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675898477; x=1675984877; bh=bKBpNMNaZlqzKjlPvpCySfuqS5eE M4ZOMXPseCuUqYI=; b=ZoUR7HNBekGqfBFoxf8+F60YCgohU7kXAwJ9ypNTyXQ4 +cZ7lAwZAPcPMN9kB45arxry/Rtl9rFzdW2P4VpAzHEaPrtyd8LjFp9QWXw6PUN3 uEtfMqXBbVrNahOeNl6QXEHfACAQR9UlXj7nPAWODoDAUvOegwEzkw0LFRK9Sh+j 6uZtiR2pbgYSPuvWbIHr9tqNXJc0n0sZaVhns8MYsKPcr7YO6gUtOq6eqxOtwUp4 6SmvhItroS9rvV8O8k1QPhUQVlJPPTlUjwD2v3JTLWJe2FhTGUEm0yO3ykoHxPHB Q06PDmorSjdfTDxWNbON8+lWePGJFCJmU2L688RCjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehuddguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeiteevfeeuuefgtdevuedvjedt geejteelheehueevgfejteehfffftdeuvdeuieenucffohhmrghinhepghhnuhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 8 Feb 2023 18:21:08 -0500 From: Demi Marie Obenour To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , Roger Pau =?utf-8?B?TW9ubsOp?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Message-ID: References: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XW67PB3rWBKnfQ2K" Content-Disposition: inline In-Reply-To: --XW67PB3rWBKnfQ2K Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 8 Feb 2023 18:21:08 -0500 From: Demi Marie Obenour To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , Roger Pau =?utf-8?B?TW9ubsOp?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS On Wed, Feb 08, 2023 at 02:58:38PM -0800, Stefano Stabellini wrote: > On Wed, 8 Feb 2023, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > >=20 > > This patch changes GPL boilerplate. > >=20 > > Signed-off-by: Demi Marie Obenour >=20 > For the licensing boilerplate, I think it would be better to switch to > SPDX instead. >=20 > That said, given that you have already done the work to covert the GPL > boilerplate everywhere, I think this is OK. But if you have time and > energy I would love to see a patch switching to SPDX in as many places > as possible. The only part of this patch I actually wrote is the commit message. The rest was generatedy by: git ls-files -z | xargs -0 -- sed -Ei -- 's@(http)(://www\.gnu\.org)@\1s\2@g' followed by the usual git stuff. Do you know of a similar automated tool for SPDX conversion? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --XW67PB3rWBKnfQ2K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPkLmgACgkQsoi1X/+c IsEKRw//W22Z2zX2t7k3Fz9Fhmd5gKTaRiil22nAIRkg68VVcKBhQhh+lO13i5L/ nWNH4W7MBLvdiJxTIh7Fs7l3HrJoVb4LX/xCe4RRqpx4yUeQgaBsUEPnpw9LdqrO dMxkxlSivgp4qDTtx8lN3q29rlxJCKym1V+BUdNG6gE3rP/jeZxZknb+nV6vzu/0 juig8OLPhVNDnBN291bC8M7ubLZ+a8IRrscWj9KnHH9h5jTLbeSbnZgqEx7tPyBA 3xYuEzFJksmtDEgKJIvjSG9KRwwP03x4itoFaJo90JG1nZXA8YJcAD70Y5GeV51g U4RI2b4jxr6VmMpUjnQaI/Yqlq0xw93ErdbVKNCKzqmZsa6uKI1E50W07Evza8Gq VEOLL74uv7xB2ck1oEZsejG8xmarI8gPpxsMh7qEaUwYN0H3oZwp5A6FBkBWvCoJ O/YjL/cQwoG3O9WilTw1sCcApJW6E2DnK6Dxz8XfYnWX6PFW2KeWpGaQE4AmmFOE P/EfyqxuPJaDkbn6pcAcofDDucD3CUsAw2KpSaNyzQXsTlVR+Tu3d1hEpFw+GbGD KTsk1dbSQmQrpWaIHBgTqrx5ceX2uiUcmuidTPpAFDMIjwv9qvuhOn7FLs8dII/5 63RnppaVLXYpNmid539EzLyXy6AH0hZCaF3w/4ArGw7dHN+lTaE= =8f2c -----END PGP SIGNATURE----- --XW67PB3rWBKnfQ2K-- From xen-devel-bounces@lists.xenproject.org Wed Feb 08 23:41:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Feb 2023 23:41:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492061.761456 (Exim 4.92) (envelope-from ) id 1pPu3Z-0005Ws-Mq; Wed, 08 Feb 2023 23:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492061.761456; Wed, 08 Feb 2023 23:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPu3Z-0005Wl-Jy; Wed, 08 Feb 2023 23:40:53 +0000 Received: by outflank-mailman (input) for mailman id 492061; Wed, 08 Feb 2023 23:40:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPu3Y-0005WY-Nt; Wed, 08 Feb 2023 23:40:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPu3Y-0001RC-Lq; Wed, 08 Feb 2023 23:40:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPu3Y-00029K-C3; Wed, 08 Feb 2023 23:40:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPu3Y-0006m8-Ba; Wed, 08 Feb 2023 23:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9jrhPuAeEKygsKqEEiRdStLki4c7+iTvxZ5A7CunmVI=; b=Eatuh3dgadPG/ohX9alRXQCDUi bZPPJiCo34vRemyPtk+2IPibyzHmL8W/lKvHX/6iFyNA/T2mEq6TKRWSl713/N4keVzE+Tnk9proj Q6GNEJShzreoMiED/Yi1i/4OS6ygRccv1R2IuVHC7ECM+HbCR5lSWW+fiHd4FgVnMvYo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176670: all pass - PUSHED X-Osstest-Versions-This: ovmf=b59e6fdae2545b45c36c8c5373f4b858fb83c8cd X-Osstest-Versions-That: ovmf=5db84c85c3544b92fa236c4d169440d523712ae0 From: osstest service owner Date: Wed, 08 Feb 2023 23:40:52 +0000 flight 176670 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176670/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b59e6fdae2545b45c36c8c5373f4b858fb83c8cd baseline version: ovmf 5db84c85c3544b92fa236c4d169440d523712ae0 Last test of basis 176447 2023-02-07 08:42:10 Z 1 days Testing same since 176670 2023-02-08 20:40:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marvin H?user Marvin Ha?user Pedro Falcato jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5db84c85c3..b59e6fdae2 b59e6fdae2545b45c36c8c5373f4b858fb83c8cd -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 09 00:52:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 00:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492069.761467 (Exim 4.92) (envelope-from ) id 1pPvAH-0006Bz-UM; Thu, 09 Feb 2023 00:51:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492069.761467; Thu, 09 Feb 2023 00:51:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvAH-0006Bs-Qt; Thu, 09 Feb 2023 00:51:53 +0000 Received: by outflank-mailman (input) for mailman id 492069; Thu, 09 Feb 2023 00:51:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvAG-0006Bm-1i for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 00:51:52 +0000 Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [2607:f8b0:4864:20::92b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef9b2998-a813-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 01:51:50 +0100 (CET) Received: by mail-ua1-x92b.google.com with SMTP id g12so103455uae.6 for ; Wed, 08 Feb 2023 16:51:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef9b2998-a813-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7+TV0fkdU6X12b+A1wHLdsyQQ3x519TYuYkm7fw8epo=; b=F640WW24qGDF927dHX9hxDpuNvh6Jwjm1ZgmjdspD5c91LaDHUmbf+/ZcZ1feuXHn9 xRZwoE/TOPybU04wVFLZKxmEEm+jGtstRRWpqNDAi5F1DLfM/nPY1IjHHspYYlu9MOrL 1Bl1OlI6xC1SPXdo3i0XlifZA6t87KbE/MNxXWZbbHNaQ+x6OMFp2jtOlgV6vEL0Mh+I S7QiwUtKkgxSr+CbNNJzE57Am/EG790mXEFaJBntQ4ySNuHQ3fwM8xNyARVGj9XRe2ot oyZO16r3m2KrGu2Fg3lFkfIsat6X+1B70Mde5VyQTXpB3Emet8dPx9r5vKZtOet9gaQn A1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7+TV0fkdU6X12b+A1wHLdsyQQ3x519TYuYkm7fw8epo=; b=p9SQPzXaAkKnpsrEBrPIcrK1Fz32m9GJyJO7jFBqP6Beq3ayLxCie9mLWUxWtgcAbt VgFDo1sNJ0V6GOpOXFN8lVPnkw5/VIMh3I8Hqc3C1S22yQAS+NgKdRl01mWa72QNRUZb GZ7b7wGmDoeArifYs1WSjxVsg/4YEF5vfn3YOwejdfxWUuAy8dt6E7BDYuv1xZ54FUtN g8Mmekrb2i11Dbn6mfr+wOfibMICvfBYIESd7WhZuiHfCMcSqZFcbLEA6gDH8GBvSJIb mAGn+7NM1GPfKVFLPxAPG3EX0/lMl+OCwLmPU0MetL08rVZUvhXY0LlOaz8ZT5IJ5GQp 455g== X-Gm-Message-State: AO0yUKX8F1ZCZt8Sa3abetCaEi1hd931Z0wIrW1S3QZqMEykBcDwD4tG EsWazuF+9I5heW2oXv4jWtZPNkG8eacwlRnOh28= X-Google-Smtp-Source: AK7set9oXcpHFuYqPseZ3dfpPssveaEQDjouxGdGICfE76lTfgbxBUr9TeFv/b0p5Buf8TqO6rp+2EC3ofbwblbYOHw= X-Received: by 2002:ab0:2401:0:b0:683:8d8f:2671 with SMTP id f1-20020ab02401000000b006838d8f2671mr2506358uan.24.1675903909094; Wed, 08 Feb 2023 16:51:49 -0800 (PST) MIME-Version: 1.0 References: <0c7192216497663865fa220c95301c357a846568.1675779308.git.oleksii.kurochko@gmail.com> In-Reply-To: <0c7192216497663865fa220c95301c357a846568.1675779308.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Thu, 9 Feb 2023 10:51:23 +1000 Message-ID: Subject: Re: [PATCH v3 02/14] xen/riscv: add header To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/include/asm/asm.h | 54 ++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/asm.h > > diff --git a/xen/arch/riscv/include/asm/asm.h b/xen/arch/riscv/include/asm/asm.h > new file mode 100644 > index 0000000000..6d426ecea7 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/asm.h > @@ -0,0 +1,54 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only) */ > +/* > + * Copyright (C) 2015 Regents of the University of California > + */ > + > +#ifndef _ASM_RISCV_ASM_H > +#define _ASM_RISCV_ASM_H > + > +#ifdef __ASSEMBLY__ > +#define __ASM_STR(x) x > +#else > +#define __ASM_STR(x) #x > +#endif > + > +#if __riscv_xlen == 64 > +#define __REG_SEL(a, b) __ASM_STR(a) > +#elif __riscv_xlen == 32 > +#define __REG_SEL(a, b) __ASM_STR(b) > +#else > +#error "Unexpected __riscv_xlen" > +#endif > + > +#define REG_L __REG_SEL(ld, lw) > +#define REG_S __REG_SEL(sd, sw) > + > +#if __SIZEOF_POINTER__ == 8 > +#ifdef __ASSEMBLY__ > +#define RISCV_PTR .dword > +#else > +#define RISCV_PTR ".dword" > +#endif > +#elif __SIZEOF_POINTER__ == 4 > +#ifdef __ASSEMBLY__ > +#define RISCV_PTR .word > +#else > +#define RISCV_PTR ".word" > +#endif > +#else > +#error "Unexpected __SIZEOF_POINTER__" > +#endif > + > +#if (__SIZEOF_INT__ == 4) > +#define RISCV_INT __ASM_STR(.word) > +#else > +#error "Unexpected __SIZEOF_INT__" > +#endif > + > +#if (__SIZEOF_SHORT__ == 2) > +#define RISCV_SHORT __ASM_STR(.half) > +#else > +#error "Unexpected __SIZEOF_SHORT__" > +#endif > + > +#endif /* _ASM_RISCV_ASM_H */ > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 00:54:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 00:54:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492077.761477 (Exim 4.92) (envelope-from ) id 1pPvCk-0006lq-AU; Thu, 09 Feb 2023 00:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492077.761477; Thu, 09 Feb 2023 00:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvCk-0006lj-7l; Thu, 09 Feb 2023 00:54:26 +0000 Received: by outflank-mailman (input) for mailman id 492077; Thu, 09 Feb 2023 00:54:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvCj-0006ld-FE for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 00:54:25 +0000 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [2607:f8b0:4864:20::e2a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ae180d4-a814-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 01:54:23 +0100 (CET) Received: by mail-vs1-xe2a.google.com with SMTP id g8so524075vso.3 for ; Wed, 08 Feb 2023 16:54:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ae180d4-a814-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZsyKuqauJPKtpDsmsifibQRF8pa1HwPAIGcTuEkm8GM=; b=nGF9+JemXquELKcMWUSqEpfTQU/jEcZmRmmFHx3+io/OZRVeuQKJRBxODLZxIMRKiD FioY8VGcOHtfbFzNAOIYbur7vdWNqUTlVc0XscqyK/5BQMxU4RX88eZgPEayw52hn/Cs PRt7oUdJWbniE9PFG8T0LoQaUYGZkPSYrAaTs+Mh0Vtz2N3vHDJB2WtyapVLIeYoPSh5 RtWTCWTN9yAMytR/76PwWCU20zThXWeJ6ddizIpPh3R172OZNp2sh77M1AeSaWPH9kti ayf9ZyiviPRnk9PqI8DZX9a6uw+lSgU1mwcyGtJGiTbijNZtSDw5KYdVsZJueub251LL JUUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZsyKuqauJPKtpDsmsifibQRF8pa1HwPAIGcTuEkm8GM=; b=tC4reQYSb0klyU0H+mjG9Q0/GBKBBBVZ8kPmmmQ41OOWx9M/Y0I+n9dwJgRrCaQwAy 6hkWOOAvQjQe3D2+axKVnkCi7jaHU3eXvVQ7V06HAx20xsUNhyVsKk/rr9f5N2x+t09m RMp0vJ0zz+4KECvg/QuuGk7tzIJpO1C6/KSBKXQhij0OOsHHfl9HQtZNhjq//YIuVBnj uKW3IojBqWdIEDez2iRmvqjFgl4nAVQS4svThiHIwxx3ehH+t7Pnzz7Z3JNlTG4fNQMB j3XZWeos7rxOEqihh0eDYzeUlA/FkfqndfmeHp4g4NNpKxCZAkbJnKUXTjycxqzNIzll cwSQ== X-Gm-Message-State: AO0yUKXSXpNIjFeNuv34tOkiUdsIoGLgwmG8m+Jd0gZokuMbY7UZGXYb /5pLcjTrv0m59k8ZcRMPbAlz9nCzEKLfBQitMwU= X-Google-Smtp-Source: AK7set/BPQ9bRHYqNJRo3P74L1kS/U7/nG7rAVvr5dWI5SX326PwpvVuaa0KDJ/Pzrn44BxoGddxxN2wz+Xc3RH6YnQ= X-Received: by 2002:a67:a208:0:b0:3ee:4ef8:45d3 with SMTP id l8-20020a67a208000000b003ee4ef845d3mr1934042vse.64.1675904062319; Wed, 08 Feb 2023 16:54:22 -0800 (PST) MIME-Version: 1.0 References: <94a46f35bc9387c699d9d24b1c792b54ec290255.1675779308.git.oleksii.kurochko@gmail.com> In-Reply-To: <94a46f35bc9387c699d9d24b1c792b54ec290255.1675779308.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Thu, 9 Feb 2023 10:53:56 +1000 Message-ID: Subject: Re: [PATCH v3 04/14] xen/riscv: add header To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > The following changes were made in comparison with from > Linux: > * remove all defines as they are defined in riscv_encoding.h > * leave only csr_* macros > > Origin: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ d2d11f342b17 > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Update origin to https://git.kernel.org/... > --- > Changes in V2: > - Minor refactoring mentioned in the commit message, switch tabs to > spaces and refactor things around __asm__ __volatile__. > - Update the commit message and add "Origin:" tag. > --- > xen/arch/riscv/include/asm/csr.h | 84 ++++++++++++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/csr.h > > diff --git a/xen/arch/riscv/include/asm/csr.h b/xen/arch/riscv/include/asm/csr.h > new file mode 100644 > index 0000000000..4275cf6515 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/csr.h > @@ -0,0 +1,84 @@ > +/* > + * SPDX-License-Identifier: GPL-2.0-only > + * > + * Copyright (C) 2015 Regents of the University of California > + */ > + > +#ifndef _ASM_RISCV_CSR_H > +#define _ASM_RISCV_CSR_H > + > +#include > +#include > +#include > + > +#ifndef __ASSEMBLY__ > + > +#define csr_read(csr) \ > +({ \ > + register unsigned long __v; \ > + __asm__ __volatile__ ( "csrr %0, " __ASM_STR(csr) \ > + : "=r" (__v) \ > + : : "memory" ); \ > + __v; \ > +}) > + > +#define csr_write(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrw " __ASM_STR(csr) ", %0" \ > + : /* no outputs */ \ > + : "rK" (__v) \ > + : "memory" ); \ > +}) > + > +#define csr_swap(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrrw %0, " __ASM_STR(csr) ", %1" \ > + : "=r" (__v) \ > + : "rK" (__v) \ > + : "memory" ); \ > + __v; \ > +}) > + > +#define csr_read_set(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrrs %0, " __ASM_STR(csr) ", %1" \ > + : "=r" (__v) \ > + : "rK" (__v) \ > + : "memory" ); \ > + __v; \ > +}) > + > +#define csr_set(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrs " __ASM_STR(csr) ", %0" \ > + : /* no outputs */ \ > + : "rK" (__v) \ > + : "memory" ); \ > +}) > + > +#define csr_read_clear(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrrc %0, " __ASM_STR(csr) ", %1" \ > + : "=r" (__v) \ > + : "rK" (__v) \ > + : "memory" ); \ > + __v; \ > +}) > + > +#define csr_clear(csr, val) \ > +({ \ > + unsigned long __v = (unsigned long)(val); \ > + __asm__ __volatile__ ( "csrc " __ASM_STR(csr) ", %0" \ > + : /*no outputs */ \ > + : "rK" (__v) \ > + : "memory" ); \ > +}) > + > +#endif /* __ASSEMBLY__ */ > + > +#endif /* _ASM_RISCV_CSR_H */ > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 00:57:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 00:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492086.761489 (Exim 4.92) (envelope-from ) id 1pPvFZ-0007ab-Sm; Thu, 09 Feb 2023 00:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492086.761489; Thu, 09 Feb 2023 00:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvFZ-0007aU-Pz; Thu, 09 Feb 2023 00:57:21 +0000 Received: by outflank-mailman (input) for mailman id 492086; Thu, 09 Feb 2023 00:57:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvFY-0007aN-J6 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 00:57:20 +0000 Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [2607:f8b0:4864:20::933]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3490c28-a814-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 01:57:18 +0100 (CET) Received: by mail-ua1-x933.google.com with SMTP id u3so114902uae.0 for ; Wed, 08 Feb 2023 16:57:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3490c28-a814-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4uHBjjVmNrtcdknf+hhlTiF9Ollq5qqhwybOZJGangk=; b=cCZ0rcl0R0zr6qzJQyvsivbSHn87dnZ0nh+2OUwXNOFNJPP5cOjSgJdykmEsoEp2V5 +R6jvAWZSZv7GA7xzmQJT8UOHWa1ZGo4mVX6LZn8AjWWVxm9WBRazmcUm5T8fiuqRzIM aMEQ6lf42ABLKUgCSle97YW79ZD85Ff42dn6GTkDKc73n/aV69MxYR3+9oupw2bNaUC8 TylyhZQepc/4Fqb8TFkDNNsI0S95ZnApmQ6WL3R4DBJ1ljShe7FrnRIKYOsfJGOaSMzY T3ktfdtu2KjGR/Sh3bFipSILRDceJcVmmQoKmhsvGR/sLG3CHHy9XgkPzYMn2+RrHaOz qTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4uHBjjVmNrtcdknf+hhlTiF9Ollq5qqhwybOZJGangk=; b=6k0EJVkr5cYm+duP6SNaYf6lRoUZN34NNi6iHKw2gC0viPppQFQPPenh7maO+N8TLq MOih6QL8xnIIvPYBYWKGYpaUAeM1uFfdbyFzw+3wKuBWHc8szrzZd+gJu0N9/Aw/vDpB Tcc2vUulGbjv+05Jykp+xLV6GKQaBTfpc9fU1ZhBAHipIbrD/PLnpQS/mpvWZ0/2kFdR h0PpabhHmIShy7+C1eDqi8f3M8Gb3NSwykcaJwAt/K8C5uNwWOv98wWiSRDV5MGns8sJ fvFgUzPVHJULYXuD7N+7G7w72pauoRMGSUzZ76EKlrjB8Enkc+kvqUxd7EgfWGtO2n80 BsJA== X-Gm-Message-State: AO0yUKVZBUzllXIEK+Ndybi9BpG77IXQ8OXl48R6G/UPLgmNxH7//+Hx 4ItRmj5UNvqpbU25gozMy70ymCKdd+o3pXpcQFQ= X-Google-Smtp-Source: AK7set8FGJL8tZKfgggACdVWUfcy1hzFe5ek7l5CvvPOa1xap77UBHrR5J1xzkPZNAexHSkhUh8Rs7P9Le8d/96HV5o= X-Received: by 2002:ab0:3488:0:b0:67f:50ba:4c23 with SMTP id c8-20020ab03488000000b0067f50ba4c23mr2272832uar.11.1675904237473; Wed, 08 Feb 2023 16:57:17 -0800 (PST) MIME-Version: 1.0 References: <95527748699e6ab643dc2fdee634fe934ae12f60.1675779308.git.oleksii.kurochko@gmail.com> In-Reply-To: <95527748699e6ab643dc2fdee634fe934ae12f60.1675779308.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Thu, 9 Feb 2023 10:56:51 +1000 Message-ID: Subject: Re: [PATCH v3 14/14] automation: modify RISC-V smoke test To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Doug Goldstein Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > The patch modifies the grep pattern to reflect the usage of WARN. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Update commit message > --- > Changes in V2: > - Leave only the latest "grep ..." > --- > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > index e0f06360bc..02fc66be03 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > |& tee smoke.serial > > set -e > -(grep -q "Hello from C env" smoke.serial) || exit 1 > +(grep -q "WARN is most likely working" smoke.serial) || exit 1 > exit 0 > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 00:57:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 00:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492093.761500 (Exim 4.92) (envelope-from ) id 1pPvG7-000869-5n; Thu, 09 Feb 2023 00:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492093.761500; Thu, 09 Feb 2023 00:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvG7-000862-2a; Thu, 09 Feb 2023 00:57:55 +0000 Received: by outflank-mailman (input) for mailman id 492093; Thu, 09 Feb 2023 00:57:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvG5-0007aN-Ma for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 00:57:53 +0000 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [2607:f8b0:4864:20::e29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c747e195-a814-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 01:57:52 +0100 (CET) Received: by mail-vs1-xe29.google.com with SMTP id y8so569937vsq.0 for ; Wed, 08 Feb 2023 16:57:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c747e195-a814-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W/gygIBzeY+/Bn31eT4Up3+fgWIBvdQ6VPZ6/wo1O9w=; b=afCq2cQSmdJCiHa+vvT50HauHPEHVoR2+ifJvxgfcnRcBcxPkbXMQ405dvvkE0L9D0 OA9/a9rq575u5VjXQ7eq+gQMZSxqoW+c4zLPPCqS7M8B7Ko2m9u0+7Q6T25O1QUEa5++ T5G0cRyUwrYY2DlF5Adph8djeVmgZ2Z8nzixdghJ3tpE/147m4eJZItByhQBe66lfWhC ZkXvJr1pk27LwDBy5lyfvH21uv6Jv3iZzxVEIGPud6h/omEG+ZsPOEFgEaydUueLoB2G ZZlosxe3lSEXxMdiRiNmSTymSNgE7HTPxXHVXC7KZDb/vyL/vO2Z3wsGjy2a7yXXbO2t HagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W/gygIBzeY+/Bn31eT4Up3+fgWIBvdQ6VPZ6/wo1O9w=; b=G+rWidm7a1C9CW0ar98PqCIfcT0edSium6V+NO+zsqyEZIYtW2SKdKiyc21cOXQNKd h8wBSFUJfXQg7YOOpSgELE/bJ+fpG4y/KX6qCh/QSgU8KUj/9elhYIUmuqmBGQrKEOOC SWQ8y9Wu3qvC9GdN3wbvFC4sxXiOVt0xuTeINesTqXMdFEl5nV0lsVa2eWMB5ZTS1pwA bas9R5+u5WbwGphe/bCUry47EvrwCKAhS0XOMuv9KyIk4DcVEJN1f/xAFuB9TBhAmtjM TQ4FE1R1Xegs9AhRo2VtYfH/6PvcfPmcyQH/Me+SZ8omDhhZZXr6R6W2JMttZyiunQZx 5EXw== X-Gm-Message-State: AO0yUKWM6ATF5sWHiuxfffs5gonZathvCth+70VcAaVsOU47Ujcytq1F F+VRs4qgrFRlEZRygLeKZGZkQfwdlul822Z5mtQ= X-Google-Smtp-Source: AK7set/R5eS+UrVs3uDbV6ETd2cKP2RK5ZHS3nT7iIgPTs/QGGB6yDGspAceDaFLUae6DRxUo1EdY+7J7COv2bpf5Gw= X-Received: by 2002:a67:c297:0:b0:3fe:5a64:f8ea with SMTP id k23-20020a67c297000000b003fe5a64f8eamr1954726vsj.54.1675904271066; Wed, 08 Feb 2023 16:57:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alistair Francis Date: Thu, 9 Feb 2023 10:57:25 +1000 Message-ID: Subject: Re: [PATCH v3 13/14] xen/riscv: test basic handling stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/setup.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index d502cf06b0..8d070244fd 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -9,12 +9,28 @@ > unsigned char __initdata cpu0_boot_stack[STACK_SIZE] > __aligned(STACK_SIZE); > > +static void test_run_in_exception(struct cpu_user_regs *regs) > +{ > + early_printk("If you see this message, "); > + early_printk("run_in_exception_handler is most likely working\n"); > +} > + > +static void test_macros_from_bug_h(void) > +{ > + run_in_exception_handler(test_run_in_exception); > + WARN(); > + early_printk("If you see this message, "); > + early_printk("WARN is most likely working\n"); > +} > + > void __init noreturn start_xen(void) > { > early_printk("Hello from C env\n"); > > trap_init(); > > + test_macros_from_bug_h(); > + > for ( ;; ) > asm volatile ("wfi"); > > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 01:07:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 01:07:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492100.761510 (Exim 4.92) (envelope-from ) id 1pPvOy-00084x-1H; Thu, 09 Feb 2023 01:07:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492100.761510; Thu, 09 Feb 2023 01:07:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvOx-00084q-UO; Thu, 09 Feb 2023 01:07:03 +0000 Received: by outflank-mailman (input) for mailman id 492100; Thu, 09 Feb 2023 01:07:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvOw-00084k-7U for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 01:07:02 +0000 Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [2607:f8b0:4864:20::a30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e7bd30d-a816-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 02:07:01 +0100 (CET) Received: by mail-vk1-xa30.google.com with SMTP id bs10so184338vkb.3 for ; Wed, 08 Feb 2023 17:07:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e7bd30d-a816-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5Tp+8218BSg+jf4CQ/XhyyAu9DfvR01Ukl0OrJXyrxY=; b=W8qVelgd6h34jJdqWbNgYjaXzN2xsLAbY9nsWJU8HFgc44kiMthyzEYpORSaKg0Rru 2z8g3Mvix4Y59tWH9cUHsrEi382kB0i/ibpLro/TTRdFgLneHmqlHpTL+N9q8DMz1Q+I GaUb2oCxyZxi32GD4qcUE++hPs/U2ly20aZJ/JJovQ/Err2+6RsfiGy3Zlm9hPyxgL9G t/WQ/PPmY3hZ0uaQD09jAgMP5WaUActfMLgIAwZIiTq8ufe0ii1sZwGHPxLGGAaV8Rk+ AmUvAjt/qEcvUJqv7bPqPwlcGOcFC7zboA6lHvWOPCJ1p20Zt2Go7EnNypYmJU+L4nKh TApA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Tp+8218BSg+jf4CQ/XhyyAu9DfvR01Ukl0OrJXyrxY=; b=ZUTWM5+buNlIPoZYX3Ij7idFn1IXoazUaxpPJLt6gh4Bkb61CAOqJxmkIdBX/qxGDy xqm80usU2Hqw1VDlbgch16XgcwiuSbS5FtevhcNLXr5wmf0NizfDNq/T4WSF2lgkjQ3U 4yDBVk3xaMxmwHWS/CEl6YwyN5vfI63V/6d5ZTAOCmfdJuR5VDXa2wAJH5VojY3ElrpS ixOcrmfbuHaBnl9W4NFS8OoVTB3iNuaMkiulANvK+IzwPfeNwdV6EOgfcEzIYQBpVHm3 qXh0jcEY84nL5VJK19KnVRKWCzKXjYNDwdEB85z+Xpd27Ba7aQbdBwet5pZW6MhiVNMI ZFUg== X-Gm-Message-State: AO0yUKVVIJ36Ue2jrJKWt19vDOUk3Gi1jPPHgiTVUtethtaf9Nl1IKtV D67Rdt9/1atPKMDjzyv6w92VdQpSYJfOPrcvcP0= X-Google-Smtp-Source: AK7set/bNd3LTv6oXtoU8ajtJjd6p2+rtyeo2M0oESELGK15Ss6EmYMe7gRtBtFm9GADo1xvKhrb5NYJiefGcaPo2L0= X-Received: by 2002:a1f:2414:0:b0:3ea:3dee:4545 with SMTP id k20-20020a1f2414000000b003ea3dee4545mr2031416vkk.26.1675904819893; Wed, 08 Feb 2023 17:06:59 -0800 (PST) MIME-Version: 1.0 References: <5aa05592497ba9c4d207185d81981442d43ba676.1675780434.git.oleksii.kurochko@gmail.com> In-Reply-To: <5aa05592497ba9c4d207185d81981442d43ba676.1675780434.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Thu, 9 Feb 2023 11:06:34 +1000 Message-ID: Subject: Re: [PATCH v3 07/14] xen/riscv: introduce exception context To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > The patch introduces a set of registers which should be saved to and > restored from a stack after an exception occurs and a set of defines > which will be used during exception context saving/restoring. > > Originally header was introduced in the patch series > from Bobby so partially it was > re-used and the following changes were done: > - Move all RISCV_CPU_USER_REGS_* to asm/asm-offsets.c > - Remove RISCV_CPU_USER_REGS_OFFSET & RISCV_CPU_USER_REGS_SIZE as > there is no sense in them after RISCV_CPU_USER_REGS_* were moved to > asm/asm-offsets.c > - Remove RISCV_PCPUINFO_* as they aren't needed for current status of > the RISC-V port > - register_t renamed to unsigned long > - rename wait_for_interrupt to wfi > > Signed-off-by: Bobby Eshleman > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - update code style for die() function > --- > Changes in V2: > - All the changes were added to the commit message. > - temporarily was added function die() to stop exectution it will be > removed after panic() will be available. > --- > xen/arch/riscv/include/asm/processor.h | 83 ++++++++++++++++++++++++++ > xen/arch/riscv/riscv64/asm-offsets.c | 53 ++++++++++++++++ > 2 files changed, 136 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/processor.h > > diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h > new file mode 100644 > index 0000000000..a71448e02e > --- /dev/null > +++ b/xen/arch/riscv/include/asm/processor.h > @@ -0,0 +1,83 @@ > +/* SPDX-License-Identifier: MIT */ > +/****************************************************************************** > + * > + * Copyright 2019 (C) Alistair Francis > + * Copyright 2021 (C) Bobby Eshleman > + * Copyright 2023 (C) Vates > + * > + */ > + > +#ifndef _ASM_RISCV_PROCESSOR_H > +#define _ASM_RISCV_PROCESSOR_H > + > +#ifndef __ASSEMBLY__ > + > +/* On stack VCPU state */ > +struct cpu_user_regs > +{ > + unsigned long zero; > + unsigned long ra; > + unsigned long sp; > + unsigned long gp; > + unsigned long tp; > + unsigned long t0; > + unsigned long t1; > + unsigned long t2; > + unsigned long s0; > + unsigned long s1; > + unsigned long a0; > + unsigned long a1; > + unsigned long a2; > + unsigned long a3; > + unsigned long a4; > + unsigned long a5; > + unsigned long a6; > + unsigned long a7; > + unsigned long s2; > + unsigned long s3; > + unsigned long s4; > + unsigned long s5; > + unsigned long s6; > + unsigned long s7; > + unsigned long s8; > + unsigned long s9; > + unsigned long s10; > + unsigned long s11; > + unsigned long t3; > + unsigned long t4; > + unsigned long t5; > + unsigned long t6; > + unsigned long sepc; > + unsigned long sstatus; > + /* pointer to previous stack_cpu_regs */ > + unsigned long pregs; > +}; > + > +static inline void wfi(void) > +{ > + __asm__ __volatile__ ("wfi"); > +} > + > +/* > + * panic() isn't available at the moment so an infinite loop will be > + * used temporarily. > + * TODO: change it to panic() > + */ > +static inline void die(void) > +{ > + for ( ;; ) > + wfi(); > +} > + > +#endif /* __ASSEMBLY__ */ > + > +#endif /* _ASM_RISCV_PROCESSOR_H */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/riscv/riscv64/asm-offsets.c b/xen/arch/riscv/riscv64/asm-offsets.c > index e69de29bb2..d632b75c2a 100644 > --- a/xen/arch/riscv/riscv64/asm-offsets.c > +++ b/xen/arch/riscv/riscv64/asm-offsets.c > @@ -0,0 +1,53 @@ > +#define COMPILE_OFFSETS > + > +#include > +#include > + > +#define DEFINE(_sym, _val) \ > + asm volatile ("\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \ > + : : "i" (_val) ) > +#define BLANK() \ > + asm volatile ( "\n.ascii\"==><==\"" : : ) > +#define OFFSET(_sym, _str, _mem) \ > + DEFINE(_sym, offsetof(_str, _mem)); > + > +void asm_offsets(void) > +{ > + BLANK(); > + DEFINE(CPU_USER_REGS_SIZE, sizeof(struct cpu_user_regs)); > + OFFSET(CPU_USER_REGS_ZERO, struct cpu_user_regs, zero); > + OFFSET(CPU_USER_REGS_RA, struct cpu_user_regs, ra); > + OFFSET(CPU_USER_REGS_SP, struct cpu_user_regs, sp); > + OFFSET(CPU_USER_REGS_GP, struct cpu_user_regs, gp); > + OFFSET(CPU_USER_REGS_TP, struct cpu_user_regs, tp); > + OFFSET(CPU_USER_REGS_T0, struct cpu_user_regs, t0); > + OFFSET(CPU_USER_REGS_T1, struct cpu_user_regs, t1); > + OFFSET(CPU_USER_REGS_T2, struct cpu_user_regs, t2); > + OFFSET(CPU_USER_REGS_S0, struct cpu_user_regs, s0); > + OFFSET(CPU_USER_REGS_S1, struct cpu_user_regs, s1); > + OFFSET(CPU_USER_REGS_A0, struct cpu_user_regs, a0); > + OFFSET(CPU_USER_REGS_A1, struct cpu_user_regs, a1); > + OFFSET(CPU_USER_REGS_A2, struct cpu_user_regs, a2); > + OFFSET(CPU_USER_REGS_A3, struct cpu_user_regs, a3); > + OFFSET(CPU_USER_REGS_A4, struct cpu_user_regs, a4); > + OFFSET(CPU_USER_REGS_A5, struct cpu_user_regs, a5); > + OFFSET(CPU_USER_REGS_A6, struct cpu_user_regs, a6); > + OFFSET(CPU_USER_REGS_A7, struct cpu_user_regs, a7); > + OFFSET(CPU_USER_REGS_S2, struct cpu_user_regs, s2); > + OFFSET(CPU_USER_REGS_S3, struct cpu_user_regs, s3); > + OFFSET(CPU_USER_REGS_S4, struct cpu_user_regs, s4); > + OFFSET(CPU_USER_REGS_S5, struct cpu_user_regs, s5); > + OFFSET(CPU_USER_REGS_S6, struct cpu_user_regs, s6); > + OFFSET(CPU_USER_REGS_S7, struct cpu_user_regs, s7); > + OFFSET(CPU_USER_REGS_S8, struct cpu_user_regs, s8); > + OFFSET(CPU_USER_REGS_S9, struct cpu_user_regs, s9); > + OFFSET(CPU_USER_REGS_S10, struct cpu_user_regs, s10); > + OFFSET(CPU_USER_REGS_S11, struct cpu_user_regs, s11); > + OFFSET(CPU_USER_REGS_T3, struct cpu_user_regs, t3); > + OFFSET(CPU_USER_REGS_T4, struct cpu_user_regs, t4); > + OFFSET(CPU_USER_REGS_T5, struct cpu_user_regs, t5); > + OFFSET(CPU_USER_REGS_T6, struct cpu_user_regs, t6); > + OFFSET(CPU_USER_REGS_SEPC, struct cpu_user_regs, sepc); > + OFFSET(CPU_USER_REGS_SSTATUS, struct cpu_user_regs, sstatus); > + OFFSET(CPU_USER_REGS_PREGS, struct cpu_user_regs, pregs); > +} > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 01:38:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 01:38:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492106.761522 (Exim 4.92) (envelope-from ) id 1pPvt0-0003Ry-DE; Thu, 09 Feb 2023 01:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492106.761522; Thu, 09 Feb 2023 01:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvt0-0003Rr-8w; Thu, 09 Feb 2023 01:38:06 +0000 Received: by outflank-mailman (input) for mailman id 492106; Thu, 09 Feb 2023 01:38:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPvsz-0003RV-2l for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 01:38:05 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63a71ec5-a81a-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 02:38:02 +0100 (CET) Received: by mail-vs1-xe2d.google.com with SMTP id h19so557983vsv.13 for ; Wed, 08 Feb 2023 17:38:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63a71ec5-a81a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=I9/AsQ+9YDYkdE8thYzzfDAwKmpmIOg22nzWOAJZgrM=; b=RyHqpU/SqBXhNGRXpDIrN3TR2jxXvSI42Wu52zbsd531RW5DNhxaIg2NQ324rWPYd7 M7VFWbPiSK+a+MEQhf8USM/tG+6TbGhk+ifSBHWOyZ5etfcSVxOK2NDzLqblUu8OBUEK AUU4mebJYn1gfL4RSbMVuGaU84kmK9wIZ4fNJFpJiI4ZRPHFBm8xIda3DV6KdRFGzB6G qDyIJjVIXel9U8iX18wIGausBXQBabc8D/FmSp674MmYpWOdM4A24dPExNzHjKgoQgRx eMs9wSAvZ6mxszJ5Y7Jr0Hm2VMawROAvA3KwRa85dSKZNP0jc6YsHspWE4LrlCJ1Aqe5 kKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I9/AsQ+9YDYkdE8thYzzfDAwKmpmIOg22nzWOAJZgrM=; b=m+uU4FxWJwi3Lmhhdhambl9jb9qNje4odqsvbEgf4uatEFyBzypYgO0KV/EpoDtg5l dT44PkNYfqUyIoDpFS9laZT/V6KjfsSiCdSTscG4uYLDLEoFc7iT1GvqkwPtKmLg10ZB Z+7yOeGivg/CCciD0wuLQSyy2EO1TA1DJXf4udsy4n0pZKbl/iv65y+XnfmXlrKGdR+w RlQsPL9Gv7AO0eWP2SCWFXHUG9nTVXwPTcmvjZiDThLCRvnY3v1sBMDLO/gCfJtUbtYu gzJ9McUSi3gEZV5MC9KESIbsut9FQv1CpM/JfxmCUnYef4YekNEoq0Rckuaacp5KPny4 Z4KQ== X-Gm-Message-State: AO0yUKWXPGrqTLU5V466NFwNp4mSpGIrDIs8GXwbcb1bjuc+tuhL44w7 26VOhDB9uVN4m2MV3FSx23FVMyp9PPXQklQ9+R8= X-Google-Smtp-Source: AK7set/EHva/vRwELT9Xgnjv40fRt+QLy8whfy2Y8IqrG5SNVzM0PhV+KHkoE06Fp5R/68R8sgBFxd2IPSQUSfeHbwY= X-Received: by 2002:a67:a407:0:b0:3f0:89e1:7c80 with SMTP id n7-20020a67a407000000b003f089e17c80mr1967804vse.72.1675906680793; Wed, 08 Feb 2023 17:38:00 -0800 (PST) MIME-Version: 1.0 References: <15e29bb67e9dc0a24811c02c8ef6965523dac27e.1675773832.git.oleksii.kurochko@gmail.com> In-Reply-To: <15e29bb67e9dc0a24811c02c8ef6965523dac27e.1675773832.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Thu, 9 Feb 2023 11:37:34 +1000 Message-ID: Subject: Re: [PATCH v10 1/2] xen/riscv: introduce early_printk basic stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Bobby Eshleman Content-Type: text/plain; charset="UTF-8" On Tue, Feb 7, 2023 at 10:49 PM Oleksii Kurochko wrote: > > Because printk() relies on a serial driver (like the ns16550 driver) > and drivers require working virtual memory (ioremap()) there is not > print functionality early in Xen boot. > > The patch introduces the basic stuff of early_printk functionality > which will be enough to print 'hello from C environment". > > Originally early_printk.{c,h} was introduced by Bobby Eshleman > (https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d1aab71384) > but some functionality was changed: > early_printk() function was changed in comparison with the original as > common isn't being built now so there is no vscnprintf. > > This commit adds early printk implementation built on the putc SBI call. > > As sbi_console_putchar() is already being planned for deprecation > it is used temporarily now and will be removed or reworked after > real uart will be ready. > > Signed-off-by: Bobby Eshleman > Signed-off-by: Oleksii Kurochko > Reviewed-by: Bobby Eshleman Reviewed-by: Alistair Francis Alistair > --- > Changes in V10: > - Miss to add the check in V9 so add it in V10 > --- > Changes in V9: > - Bring "cmodel=medany" check back to be sure that C function is safe to be > called in early boot when MMU is off ( e.g. VA != PA ) > --- > Changes in V8: > - Nothing was changed > --- > Changes in V7: > - Nothing was changed > --- > Changes in V6: > - Remove __riscv_cmodel_medany check from early_printk.c > --- > Changes in V5: > - Code style fixes > - Change an error message of #error in case of __riscv_cmodel_medany > isn't defined > --- > Changes in V4: > - Remove "depends on RISCV*" from Kconfig.debug as it is located in > arch specific folder so by default RISCV configs should be ebabled. > - Add "ifdef __riscv_cmodel_medany" to be sure that PC-relative addressing > is used as early_*() functions can be called from head.S with MMU-off and > before relocation (if it would be needed at all for RISC-V) > - fix code style > --- > Changes in V3: > - reorder headers in alphabetical order > - merge changes related to start_xen() function from "[PATCH v2 7/8] > xen/riscv: print hello message from C env" to this patch > - remove unneeded parentheses in definition of STACK_SIZE > --- > Changes in V2: > - introduce STACK_SIZE define. > - use consistent padding between instruction mnemonic and operand(s) > --- > xen/arch/riscv/Kconfig.debug | 5 +++ > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/early_printk.c | 44 +++++++++++++++++++++++ > xen/arch/riscv/include/asm/early_printk.h | 12 +++++++ > xen/arch/riscv/setup.c | 4 +++ > 5 files changed, 66 insertions(+) > create mode 100644 xen/arch/riscv/early_printk.c > create mode 100644 xen/arch/riscv/include/asm/early_printk.h > > diff --git a/xen/arch/riscv/Kconfig.debug b/xen/arch/riscv/Kconfig.debug > index e69de29bb2..608c9ff832 100644 > --- a/xen/arch/riscv/Kconfig.debug > +++ b/xen/arch/riscv/Kconfig.debug > @@ -0,0 +1,5 @@ > +config EARLY_PRINTK > + bool "Enable early printk" > + default DEBUG > + help > + Enables early printk debug messages > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index fd916e1004..1a4f1a6015 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,3 +1,4 @@ > +obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += sbi.o > obj-y += setup.o > diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c > new file mode 100644 > index 0000000000..dfe4ad77e2 > --- /dev/null > +++ b/xen/arch/riscv/early_printk.c > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * RISC-V early printk using SBI > + * > + * Copyright (C) 2021 Bobby Eshleman > + */ > +#include > +#include > + > +/* > + * When the MMU is off during early boot, any C function called has to > + * use PC-relative rather than absolute address because the physical address > + * may not match the virtual address. > + * > + * To guarantee PC-relative address cmodel=medany should be used > + */ > +#ifndef __riscv_cmodel_medany > +#error "early_*() can be called from head.S with MMU-off" > +#endif > + > +/* > + * TODO: > + * sbi_console_putchar is already planned for deprecation > + * so it should be reworked to use UART directly. > +*/ > +void early_puts(const char *s, size_t nr) > +{ > + while ( nr-- > 0 ) > + { > + if ( *s == '\n' ) > + sbi_console_putchar('\r'); > + sbi_console_putchar(*s); > + s++; > + } > +} > + > +void early_printk(const char *str) > +{ > + while ( *str ) > + { > + early_puts(str, 1); > + str++; > + } > +} > diff --git a/xen/arch/riscv/include/asm/early_printk.h b/xen/arch/riscv/include/asm/early_printk.h > new file mode 100644 > index 0000000000..05106e160d > --- /dev/null > +++ b/xen/arch/riscv/include/asm/early_printk.h > @@ -0,0 +1,12 @@ > +#ifndef __EARLY_PRINTK_H__ > +#define __EARLY_PRINTK_H__ > + > +#include > + > +#ifdef CONFIG_EARLY_PRINTK > +void early_printk(const char *str); > +#else > +static inline void early_printk(const char *s) {}; > +#endif > + > +#endif /* __EARLY_PRINTK_H__ */ > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index 13e24e2fe1..d09ffe1454 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,12 +1,16 @@ > #include > #include > > +#include > + > /* Xen stack for bringing up the first CPU. */ > unsigned char __initdata cpu0_boot_stack[STACK_SIZE] > __aligned(STACK_SIZE); > > void __init noreturn start_xen(void) > { > + early_printk("Hello from C env\n"); > + > for ( ;; ) > asm volatile ("wfi"); > > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 02:50:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 02:50:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492116.761533 (Exim 4.92) (envelope-from ) id 1pPx0T-0003dR-T2; Thu, 09 Feb 2023 02:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492116.761533; Thu, 09 Feb 2023 02:49:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPx0T-0003dK-PM; Thu, 09 Feb 2023 02:49:53 +0000 Received: by outflank-mailman (input) for mailman id 492116; Thu, 09 Feb 2023 02:49:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPx0S-0003dA-8x; Thu, 09 Feb 2023 02:49:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPx0S-0005IR-6K; Thu, 09 Feb 2023 02:49:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPx0R-0006f8-Tb; Thu, 09 Feb 2023 02:49:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPx0R-0003lD-TD; Thu, 09 Feb 2023 02:49:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hDCl23Go5C9g02uKJE+et2ErTqEl6sRJ298ZveO/A/Y=; b=iBcvWvyT/orJhkfTPuULMK6gGM fwloMZMQGbsMQFHnkS7QaqDC+9FYU6Rq1fn1GBH0TrQ1kOmMrgfQFOdwmBO6Gilz/0ejeO1dinzs9 8NrC1VD/BoMhQfEFjFFIB4wXdP7HsndG7W7uuzfrP1QwdJxV0im0mbD+mhCP6H/zvcvg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176591: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c0e202194bfcb413d7cf662b333550ed444c469b X-Osstest-Versions-That: xen=6c707d4573f5df2b60503dfeedc10b33cebd60d1 From: osstest service owner Date: Thu, 09 Feb 2023 02:49:51 +0000 flight 176591 xen-unstable real [real] flight 176689 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176591/ http://logs.test-lab.xenproject.org/osstest/logs/176689/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176689-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176453 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176453 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176453 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176453 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176453 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176453 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176453 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176453 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176453 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c0e202194bfcb413d7cf662b333550ed444c469b baseline version: xen 6c707d4573f5df2b60503dfeedc10b33cebd60d1 Last test of basis 176453 2023-02-07 12:55:29 Z 1 days Testing same since 176591 2023-02-08 02:50:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6c707d4573..c0e202194b c0e202194bfcb413d7cf662b333550ed444c469b -> master From xen-devel-bounces@lists.xenproject.org Thu Feb 09 03:08:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 03:08:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492128.761556 (Exim 4.92) (envelope-from ) id 1pPxHs-0006V7-Ig; Thu, 09 Feb 2023 03:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492128.761556; Thu, 09 Feb 2023 03:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPxHs-0006V0-FS; Thu, 09 Feb 2023 03:07:52 +0000 Received: by outflank-mailman (input) for mailman id 492128; Thu, 09 Feb 2023 03:07:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPxHq-0006Uq-Qh; Thu, 09 Feb 2023 03:07:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPxHq-0005de-On; Thu, 09 Feb 2023 03:07:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPxHq-000730-AR; Thu, 09 Feb 2023 03:07:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPxHq-0006WI-9v; Thu, 09 Feb 2023 03:07:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A6DWSx+Z0jCqw78pGTkH05A5WIdFoeRVGwlVeBEXNBA=; b=3t+kzxlAmlkcgO38rVC90+uxyQ aoiM0GnMZ6Zm5Z5beaKQoqjzjI5MnitTGfq1pwIecO2A+zMlntSlS19esHjxgza/tJfpNmRyy1DWS nmq+KmKK2AhZoZPfjRjsZ2tH3Etz7kJ3choygFYgPCnHyWu9u36cshpmmJAiNnwKB+OI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176598: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=c3f16cea3bef578c498c720aa90c677ee9511e2f X-Osstest-Versions-That: libvirt=5c4007ddc6c29632b5cc96ab4ef81ebb7797d1bb From: osstest service owner Date: Thu, 09 Feb 2023 03:07:50 +0000 flight 176598 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176598/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt c3f16cea3bef578c498c720aa90c677ee9511e2f baseline version: libvirt 5c4007ddc6c29632b5cc96ab4ef81ebb7797d1bb Last test of basis 176441 2023-02-07 04:20:57 Z 1 days Testing same since 176598 2023-02-08 04:20:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jim Fehlig jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 5c4007ddc6..c3f16cea3b c3f16cea3bef578c498c720aa90c677ee9511e2f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 09 04:11:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 04:11:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492137.761566 (Exim 4.92) (envelope-from ) id 1pPyHY-00066I-8j; Thu, 09 Feb 2023 04:11:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492137.761566; Thu, 09 Feb 2023 04:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPyHY-00066A-5l; Thu, 09 Feb 2023 04:11:36 +0000 Received: by outflank-mailman (input) for mailman id 492137; Thu, 09 Feb 2023 04:11:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPyHW-00065y-9z; Thu, 09 Feb 2023 04:11:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPyHW-0007BT-3h; Thu, 09 Feb 2023 04:11:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPyHV-0000qH-QH; Thu, 09 Feb 2023 04:11:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pPyHV-0006O3-Po; Thu, 09 Feb 2023 04:11:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=geHwqx8olYO4+gBygvy8X7JzjHS604izARRh0neb1s0=; b=QWxNZJSVSGjP4M1Qa/gfnLd8Bt 5RTywPfzdwIO0Nsl4M9EDerzdW81iQO7JtjopganIyOw9+HRrZMd5hBl0bMWdA2y101HOrM84I+L8 VEA7xmDHKtfmaCSNQrDf6l7Xd0zq1Vrh97c8mj+LanUPSVD5C5FK4RPwd9+XxcM/yIMs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176694: all pass - PUSHED X-Osstest-Versions-This: ovmf=f6ce1a5cd8932844ec24701d158254ccf75b6159 X-Osstest-Versions-That: ovmf=b59e6fdae2545b45c36c8c5373f4b858fb83c8cd From: osstest service owner Date: Thu, 09 Feb 2023 04:11:33 +0000 flight 176694 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176694/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f6ce1a5cd8932844ec24701d158254ccf75b6159 baseline version: ovmf b59e6fdae2545b45c36c8c5373f4b858fb83c8cd Last test of basis 176670 2023-02-08 20:40:45 Z 0 days Testing same since 176694 2023-02-09 02:10:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Deric Cole jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b59e6fdae2..f6ce1a5cd8 f6ce1a5cd8932844ec24701d158254ccf75b6159 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 09 05:54:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 05:54:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492149.761578 (Exim 4.92) (envelope-from ) id 1pPzt4-0001EC-NX; Thu, 09 Feb 2023 05:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492149.761578; Thu, 09 Feb 2023 05:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPzt4-0001E5-JR; Thu, 09 Feb 2023 05:54:26 +0000 Received: by outflank-mailman (input) for mailman id 492149; Thu, 09 Feb 2023 05:54:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pPzt2-0001Dz-HL for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 05:54:24 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30090f59-a83e-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 06:54:18 +0100 (CET) Received: by mail-pj1-x102e.google.com with SMTP id d13-20020a17090ad3cd00b0023127b2d602so1291383pjw.2 for ; Wed, 08 Feb 2023 21:54:17 -0800 (PST) Received: from localhost ([122.172.83.155]) by smtp.gmail.com with ESMTPSA id z14-20020a17090a1fce00b002311a83e333sm2098575pjz.44.2023.02.08.21.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 21:54:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30090f59-a83e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d7TFb8XDrlHhSX4AMlpcSukotYRX1ULZv1KvAGm5TWI=; b=wRIIZNlQneBoIPNhNzoc57T3PqGEEQEUfpX+9cE1ZWqU+eSvJw0CIQharyyZqErB9c EVI+6yST//AK5p0L5LZwYcVfOcqYvlE+T9dzUMCCsgtlN5AnvCS3z2vjHntaM7qHWwNL tJGQcv5eET76kZu1L6VyK/pboWxwb2hkQQSOG0LITR66wxXoswGHkl6A7bykoKDlaq7X dhhvGC7kpJKKZIPMbmgK3o4ciYTbg0WAbOHvGQTC/wBdSDiUCt52+YDvRBvdQrdlp+77 xzZ9PGqGM7V6r+Nj3kW8853JFosDSvMywHvpo5xLUdjQebfi1PfUqKry2HyZGTq5VQ3q ABTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d7TFb8XDrlHhSX4AMlpcSukotYRX1ULZv1KvAGm5TWI=; b=jjGLv4YG4Elu9O4m+K5lbHVqYIv2xpxjbdrfcY6I+qIYG5STKO7Xms9Yjjnrp0Z+VN OUIC6i1BkIk9vfvs0cGPog49mNWdkpvSJYQWKb0LN6NWAvNCDmJKjwbbw4V5V9TWn3LA THZI7+Gcq9gSAUge0/kRGw+3yr2YObxa5z2LAApEjSAYsMY0vvIhhawSPxSvKcY5lgrb ZgoQUzhfbY6BImdh+dN1pazM6psp1eWLkjpBS2HaKDPUKNU/4DKuDCR5+FzCnpBxoV6J GHgFQ3vMDinASNUTYJkMCA2RGLhaF2Noh993x6zsZ2CQZxRjw7ugupWZqOZDtCa/28+e ZuzA== X-Gm-Message-State: AO0yUKVJGkrtGJYp0sYFfsItcJn2xURL5mz5oF1e4qnovHu9xL7V+klv mong7njfAxpzxCSy9jnM4K9E+Q== X-Google-Smtp-Source: AK7set9gpKfCzCj2Ll21QW8zIUO4z1bmq1VMSVFsF72HERDXfuh9ya2AaWtEKox4BHH+HKVEuiZr8g== X-Received: by 2002:a17:90b:1b07:b0:230:8956:79f1 with SMTP id nu7-20020a17090b1b0700b00230895679f1mr12011918pjb.36.1675922056018; Wed, 08 Feb 2023 21:54:16 -0800 (PST) Date: Thu, 9 Feb 2023 11:24:13 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Oleksandr Tyshchenko , Juergen Gross , Stefano Stabellini Subject: Re: [PATCH] xen/grant-dma-iommu: Implement a dummy probe_device() callback Message-ID: <20230209055413.k2jbmqvqg636jrgw@vireshk-i7> References: <20230208153649.3604857-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230208153649.3604857-1-olekstysh@gmail.com> On 08-02-23, 17:36, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Update stub IOMMU driver (which main purpose is to reuse generic > IOMMU device-tree bindings by Xen grant DMA-mapping layer on Arm) > according to the recent changes done in the following > commit 57365a04c921 ("iommu: Move bus setup to IOMMU device registration"). > > With probe_device() callback being called during IOMMU device registration, > the uninitialized callback just leads to the "kernel NULL pointer > dereference" issue during boot. Fix that by adding a dummy callback. > > Looks like the release_device() callback is not mandatory to be > implemented as IOMMU framework makes sure that callback is initialized > before dereferencing. > > Reported-by: Viresh Kumar > Signed-off-by: Oleksandr Tyshchenko > --- > drivers/xen/grant-dma-iommu.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Tested-by: Viresh Kumar -- viresh From xen-devel-bounces@lists.xenproject.org Thu Feb 09 07:22:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 07:22:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492186.761605 (Exim 4.92) (envelope-from ) id 1pQ1GF-0004XA-Dk; Thu, 09 Feb 2023 07:22:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492186.761605; Thu, 09 Feb 2023 07:22:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1GF-0004X3-B7; Thu, 09 Feb 2023 07:22:27 +0000 Received: by outflank-mailman (input) for mailman id 492186; Thu, 09 Feb 2023 07:22:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1GD-0004Wx-Q4 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 07:22:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f578cfd-a84a-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 08:22:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3E44220C8B; Thu, 9 Feb 2023 07:22:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B266A1339E; Thu, 9 Feb 2023 07:22:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id e00xKi6f5GPgeAAAMHmgww (envelope-from ); Thu, 09 Feb 2023 07:22:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f578cfd-a84a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675927343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QHDr4/oY9jwjgsuyt0ENY6hb99lvK8llTbmW7FwD1WY=; b=hkd/8ZSN2yr1EXH/otlZ2IOhrexNw9ZlHMfSi/2RYl35jCKYc1+CxTPbtthvkyKAMbhsIJ g4kzzt5oIWj2s2vNcLDEo0ZCc5isCqLAHsLy88icLk+t71MwZA7susB62v8ObQjk5OzYP+ PN1MAI+by459aRFgxt6PvL8nvvRR3SU= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org Cc: lists@nerdbynature.de, mikelley@microsoft.com, torvalds@linux-foundation.org, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , xen-devel@lists.xenproject.org, Andy Lutomirski , Peter Zijlstra Subject: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Date: Thu, 9 Feb 2023 08:22:12 +0100 Message-Id: <20230209072220.6836-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series tries to fix the rather special case of PAT being available without having MTRRs (either due to CONFIG_MTRR being not set, or because the feature has been disabled e.g. by a hypervisor). The main use cases are Xen PV guests and SEV-SNP guests running under Hyper-V. Instead of trying to work around all the issues by adding if statements here and there, just try to use the complete available infrastructure by setting up a read-only MTRR state when needed. In the Xen PV case the current MTRR MSR values can be read from the hypervisor, while for the SEV-SNP case all needed is to set the default caching mode to "WB". I have added more cleanup which has been discussed when looking into the most recent failures. Note that I couldn't test the Hyper-V related change (patch 3). Running on bare metal and with Xen didn't show any problems with the series applied. Changes in V2: - replaced former patches 1+2 with new patches 1-4, avoiding especially the rather hacky approach of V1, while making all the MTRR type conflict tests available for the Xen PV case - updated patch 6 (was patch 4 in V1) Juergen Gross (8): x86/mtrr: split off physical address size calculation x86/mtrr: support setting MTRR state for software defined MTRRs x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest x86/xen: set MTRR state when running as Xen PV initial domain x86/mtrr: revert commit 90b926e68f50 x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID x86/mm: only check uniform after calling mtrr_type_lookup() x86/mtrr: drop sanity check in mtrr_type_lookup_fixed() arch/x86/include/asm/mtrr.h | 9 +++- arch/x86/include/uapi/asm/mtrr.h | 6 +-- arch/x86/kernel/cpu/mshyperv.c | 8 +++ arch/x86/kernel/cpu/mtrr/generic.c | 56 +++++++++++++++++---- arch/x86/kernel/cpu/mtrr/mtrr.c | 79 ++++++++++++++++-------------- arch/x86/mm/pat/memtype.c | 3 +- arch/x86/mm/pgtable.c | 6 +-- arch/x86/xen/enlighten_pv.c | 49 ++++++++++++++++++ 8 files changed, 159 insertions(+), 57 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 07:22:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 07:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492187.761616 (Exim 4.92) (envelope-from ) id 1pQ1Ga-0004u7-LH; Thu, 09 Feb 2023 07:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492187.761616; Thu, 09 Feb 2023 07:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1Ga-0004u0-Ic; Thu, 09 Feb 2023 07:22:48 +0000 Received: by outflank-mailman (input) for mailman id 492187; Thu, 09 Feb 2023 07:22:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1GZ-0004Wx-0j for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 07:22:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cea6629-a84a-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 08:22:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 476D85C220; Thu, 9 Feb 2023 07:22:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E04511339E; Thu, 9 Feb 2023 07:22:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id W5psNUWf5GMEeQAAMHmgww (envelope-from ); Thu, 09 Feb 2023 07:22:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cea6629-a84a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675927366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPHTwfsDZTgmdyR5HshjupjvhAk0TKRehG5uFEDCaGY=; b=jTQFlvog2tMj+BfGgU8rR5EaQbbXOxSH0z7WFdcmWrC4Ksfox4FiMX3eJAmKvb7DyQNkv0 KJE7/cahAd1ty7jbY4etBmQrkyOMWfGfL/UYbaKnz5sQzTi9sDtat3hOCW61/Bx2sXpirP fTZDfv+AJdEdeCjgCTqTHZ+DUyWwi5A= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: lists@nerdbynature.de, mikelley@microsoft.com, torvalds@linux-foundation.org, Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH v2 4/8] x86/xen: set MTRR state when running as Xen PV initial domain Date: Thu, 9 Feb 2023 08:22:16 +0100 Message-Id: <20230209072220.6836-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230209072220.6836-1-jgross@suse.com> References: <20230209072220.6836-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as Xen PV initial domain (aka dom0), MTRRs are disabled by the hypervisor, but the system should nevertheless use correct cache memory types. This has always kind of worked, as disabled MTRRs resulted in disabled PAT, too, so that the kernel avoided code paths resulting in inconsistencies. This bypassed all of the sanity checks the kernel is doing with enabled MTRRs in order to avoid memory mappings with conflicting memory types. This has been changed recently, leading to PAT being accepted to be enabled, while MTRRs stayed disabled. The result is that mtrr_type_lookup() no longer is accepting all memory type requests, but started to return WB even if UC- was requested. This led to driver failures during initialization of some devices. In reality MTRRs are still in effect, but they are under complete control of the Xen hypervisor. It is possible, however, to retrieve the MTRR settings from the hypervisor. In order to fix those problems, overwrite the MTRR state via mtrr_overwrite_state() with the MTRR data from the hypervisor, if the system is running as a Xen dom0. Fixes: 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() properly reflect state when running on Xen") Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/xen/enlighten_pv.c | 49 +++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5b1379662877..9cf520c0c810 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #include #include @@ -1200,6 +1201,52 @@ static void __init xen_boot_params_init_edd(void) #endif } +/* Get MTRR settings from Xen and put them into mtrr_state. */ +static void __init xen_set_mtrr_data(void) +{ +#ifdef CONFIG_MTRR + struct xen_platform_op op = { + .cmd = XENPF_read_memtype, + .interface_version = XENPF_INTERFACE_VERSION, + }; + unsigned int reg; + unsigned long mask; + uint32_t eax, width; + static struct mtrr_var_range var[MTRR_MAX_VAR_RANGES] __initdata; + + /* Get physical address width (only 64-bit cpus supported). */ + width = 36; + eax = cpuid_eax(0x80000000); + if ((eax >> 16) == 0x8000 && eax >= 0x80000008) { + eax = cpuid_eax(0x80000008); + width = eax & 0xff; + } + + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { + op.u.read_memtype.reg = reg; + if (HYPERVISOR_platform_op(&op)) + break; + + /* + * Only called in dom0, which has all RAM PFNs mapped at + * RAM MFNs, and all PCI space etc. is identity mapped. + * This means we can treat MFN == PFN regarding MTTR settings. + */ + var[reg].base_lo = op.u.read_memtype.type; + var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT; + var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT); + mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1); + mask &= (1UL << width) - 1; + if (mask) + mask |= 1 << 11; + var[reg].mask_lo = mask; + var[reg].mask_hi = mask >> 32; + } + + mtrr_overwrite_state(var, reg, NULL, MTRR_TYPE_UNCACHABLE); +#endif +} + /* * Set up the GDT and segment registers for -fstack-protector. Until * we do this, we have to be careful not to call any stack-protected @@ -1403,6 +1450,8 @@ asmlinkage __visible void __init xen_start_kernel(struct start_info *si) xen_boot_params_init_edd(); + xen_set_mtrr_data(); + #ifdef CONFIG_ACPI /* * Disable selecting "Firmware First mode" for correctable -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 07:39:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 07:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492198.761627 (Exim 4.92) (envelope-from ) id 1pQ1WC-00070g-Vz; Thu, 09 Feb 2023 07:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492198.761627; Thu, 09 Feb 2023 07:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1WC-00070Z-TP; Thu, 09 Feb 2023 07:38:56 +0000 Received: by outflank-mailman (input) for mailman id 492198; Thu, 09 Feb 2023 07:38:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1WA-00070T-T8 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 07:38:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0617.outbound.protection.outlook.com [2a01:111:f400:fe0e::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ccf4f2a5-a84c-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 08:38:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6890.eurprd04.prod.outlook.com (2603:10a6:10:117::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.30; Thu, 9 Feb 2023 07:38:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 07:38:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccf4f2a5-a84c-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9A6iM5WzLpDdh+ELKhsprosdiI4vd86yfY/pPH9oMbmGvD+Qoa9viJ1qzZdUlKmXIkle80J8NdMSbWBnsFZnhxhTa43p9j2HxGk6Y6FIca/ERTpRfWWMLj5ey77qWtBfoFimRfrA4pk1Me+pEi88bHksAIWCo88NM4WxCNIGdI6nKbyRQPJ6zonyg5A/dCEH8edzazLv4xP42Ojsvki0yBScEQU1muBq7E2DVaPPkGDDTVueUPbn+PQVp7K7rBR/78EXG7ZFa0mmNud0DiLhYSrZCNLqT9DeqeX0uhOKdQpJNg1kZOjRyVQ84Sd1/vYLJg9Qx3SwBPmL+EOwpuiWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SA8Y9dUQxQ31dGbPEWhaaTsLMMUMB1hFbTfDymXaAYo=; b=RYuDbZJMfHbVSzGHAediwp0Ggo1YTdW/zSC0Yh5ddppXI/4xohNtomPU15D/UdEhbmBs4T3WMICdL8SVnZsYk6PSGQmwk3vQ/vpeeJh1oKoW5/rQ8+JBln2zQqCGcT0N5eI0jB61ycgczQRcv4yLCnERQpmMI6pnkb8WNcGQtrEg9bx8tXsTuLGUQV1cR7q8IOFVt2ngRfdqx7F2iQMzqo39gKdGJHV5Uj2d45HJdk04FVL8pK90lMZahT+AcrUDVf4eCpizrD+R34c0MWTW7mRagVYDNKKHrSSYymEVMDnHtJHSEVja/2olR7jce8bM7kzvvj0jLYpGqiaJq+0KWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SA8Y9dUQxQ31dGbPEWhaaTsLMMUMB1hFbTfDymXaAYo=; b=iDBmJad4iEABko4kPyBGk+MeGglhdvdbsu35LPBeuVBnqakzaPSGvfo7bKAYe5JOGc+YbBTrCnJCO8+a6cmVWsKFrXVFtUc79icuZ+FyH5+Mt5yXDihfwvosnuOlgOoo0YJ+8UmqUCRe4qhBFg49cJF7y8aNRKzwZsI6Mq1tsUtfx2oXKqWb3snBd0PjQsl7mBu1K/TVGQPvtlqsiMdZxZyedi8xAVFTnUomporvKlJyKjv+u2PHx3UD2/+caOqYc4QWMcRJtdsRgvacoKOvixMeTzuYhXkod6hqZDdQIGt0lsODdAhk+wLyEk3Y3vIM9BlafUEt/BTZ9S57OF3GgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 08:38:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v3 2/9] xen/arm: Typecast the DT values into paddr_t Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-3-ayan.kumar.halder@amd.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6890:EE_ X-MS-Office365-Filtering-Correlation-Id: 0881a8cb-91c0-41d3-dd0a-08db0a70afc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6BIx747dtsstnBLsdgyn4utZ8DEKX1+vQLLkRgdo9px+CMPbNwA8ml/dGtZyYH0jsMTaR9DrW/38I7smzel0B98hU6iSww3MMv3bgcwPyg89zUvV6ApbjCKvQiKZJRn3KlVVCV/uEYv62efM4648/OKvQwDZplR4fuNi4vJ3zA2B61B1LyKVvLbvLjE59tMRrRqcyQ9helxbiIdkX3uPwNrVi19pPCAPgMmzUyIimnNMCEnDZpsvhVxOoA90B9/9ly07Fd7vkqjgFKMFQh19tz0Tv2j7rqolgHYZMh/wFsulBaevalsbDctAE9fuhEA4zrCEBsyZYcJ5OHCVePyRcShthGezs4StD0b7yI6A9ZeUV+XxSJFO4vKwNnrmvelkW54GnewSpi+1F70W0CAJG+co1uc9LVUYUyrZSTXFiA7W97ul/EE5q8QGQ/OueuvVM9J/GI4rhnZk423AVgR5jMblj66wjKseH70mzVgNhVxMRR0vdQXMWGuTxKrPvMbB8ymnHEIJHFabHifwUfAgjwdN9qFG6PS4ROvKo7wMZitEa/Pe/DAzXTC28oZY8JL1ctp+YzDywy9TSJ8VeWH69IC03Htd6KnIembBVYnTRrd2/SnNRyw0fJDIa59wjk/Vt8nstUpf4gkeh4tgJHytpDdlgPzcCYtrU9w1nKgd3gKw+9KNVBKYgrltmmlgcpTxZ06AFPZhu7Io6KryWe6Znr6re82zAy4rywG4FNZpLIA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(366004)(136003)(396003)(346002)(451199018)(83380400001)(66476007)(316002)(5660300002)(8936002)(8676002)(4326008)(66556008)(66946007)(110136005)(478600001)(6666004)(41300700001)(2616005)(26005)(6506007)(6512007)(7416002)(53546011)(186003)(6486002)(36756003)(86362001)(31696002)(2906002)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0ZzeTVES2phMXp3NVg0QmVPd0dyWWk4bXM3SDY3THVvSjgxRjI1d00wZG9j?= =?utf-8?B?ZFloZlBJQTZFeXlXc25nd25DZVpBdkhPc0NraHFVT2VuWTdYcmdIQjhzM0lU?= =?utf-8?B?b25nUUI1b29wT3RKMG5sNXJyRmV4ekp0bC9CUjlsR1U4TXh1aDBkVjhacnIx?= =?utf-8?B?eWNEVHRjcUs1QitWeHM2MUpPR2ZmcmM1M2J3RWJCa2FoWDdSaVMwbXF5TG9p?= =?utf-8?B?bkZSUDZhT3ZGczM1SVppNU1nN2YwWXlLWVcrY1MvMFBSNXR3K21wSmRBR0V2?= =?utf-8?B?RVpXd1dReUJvcytVb2FLM0owVUJZMnB4eUdPK2ptMnczSG9nVE5wKy9vZERB?= =?utf-8?B?SEQxSWRlcU92WjV3cUdOLzFmTFRrcXd0aHoyZG5FOUg2OFdNeHVEL2RUSUFT?= =?utf-8?B?MDNTMDFnUmpvK3U3NUJCbHlEZFhQSWNwTVVLZlpTRkhBdmdWMXRPTFovTDZx?= =?utf-8?B?cTdtZUJ1bEhZZmdkNGo4djhWRm9jRXBOV0NHbzg3V1ZKTFhqdFpCKzRUNnBI?= =?utf-8?B?aGZmeUQrbVpsT3YvRzhKbFlQaWU3dHJyV29rK3hVQ29QcExSVzA1ZGRvblRU?= =?utf-8?B?TXFTWUgrbHVSbnJjVFEvMmlqelRZd1V1ak5ITGNtNVVIUWQ2Q0laWDliRkVv?= =?utf-8?B?R0Zva082czh1dXh1Vmk3T3QvUWlOT0ZPVnlNeFFCY2JOeWZyOUU5d2U4NlJl?= =?utf-8?B?Q2laWiswMHpaSUdOK0F1QUUxODJseER6QTY5M3dHbHpkckw2VTJvQzRNZjZF?= =?utf-8?B?b2orM3VScDFwc0lTR3ZrZ3U5RExNRjd0elgrM2xsNXdZem9RM083OS9Yc3ky?= =?utf-8?B?TnczOC9JVlVGVDhsU2JLOGIrWElrOXlNSk0rTzIxZ2VXQ1BoMGhVeExEbXF0?= =?utf-8?B?SlNDcWdpVi9NV3RlSmUrMEFHcjRQUWZLVUxCQkVacmdiSHFxTWlSUzZ0SmF1?= =?utf-8?B?M1BjMzM4ZXdsYkdwNW9WLzVaS1p0bXVTNXd6dDQ3Q05oOStBT2txek1xT3Yw?= =?utf-8?B?dTNzT2pUM1h4SDBxc3hsNjNqb05SWmZuNGtxNi93N3dwN1NSKzdPYWw2V1Jk?= =?utf-8?B?clhFOUFkR3E4eHFzZERJa2hxN1k5QzVxNlVsSUlacDgyY3hwR0dGNmRTWitU?= =?utf-8?B?d2dUeURWa09MRHNZQ0o2eEpUS1dMZnlhVFIzSGZzSmFtQStWR294WE9ZYytF?= =?utf-8?B?M0ErVnBqajZETW8vNXJTL0xpbWRVd3p5N3dXREd3RktQVjJ3QVRlS1gycmQx?= =?utf-8?B?NnFtTjNkZUVxaWVWYXpLL0R5NzFBZXgxOUtzL0pMSithVGdnK1RtUUEwUE14?= =?utf-8?B?VWRUTzFaUHlhSkFudVRSZVdBWUtseWFveXpGcDArb0FkNEtEUVRnK3pSNDJp?= =?utf-8?B?T2tkS21lVFZyd1dvRmhid1lWbWd4OUhSellqeXVCcStRM2M1MzBqV2E1WVpF?= =?utf-8?B?VlcyNE54bW5tWkFrbm43cmlTdUJhcGlaQzZpbzdvUHpubFhIODVvN05SVVUx?= =?utf-8?B?dStHOUFJbWZVdzhLcUc0bWpGTXdsalJnMUROWjBxckdHY3pWMXdnQVg0bkEw?= =?utf-8?B?eFYzc3Y5dmxRNXZ6d1I0YWErckVTOWNNQ3E2ajduRW5FY0NvditaM1R3ZFpu?= =?utf-8?B?czYxZ1UyNEF5QmtvMkdxbjhXNUxCNmllOU5WbEhUbk9vb3VqNzAzeWI4eGxD?= =?utf-8?B?Y3c1WkhVNDUrK2ltWlk1QTJmeFJkeEVtdW12MkFaY0w1MFNMY1BJZlVCYlFW?= =?utf-8?B?a3MvSEIvTTJTY1NicUtEVGk2cTA1Qk1sN3NHRmpFRXhXcUIxQ2EyT2FLbVVH?= =?utf-8?B?OGhubnJWN0pQUGdjemx6cXlybzN2VmxqRTVSY3BhUE8wV0dLMmJVbFdFNHNU?= =?utf-8?B?Sk80RXRFRGJ2akZKUENvK2dzeHpwdXNtYUhqTXM0SkxRM1pUVWJVMHZpOU54?= =?utf-8?B?WXkzRGFqY2ZPVnQ3WGxQY2NCRDdnaEVYUnduc3grRzRHT3BHUkRmYlJXQ0Na?= =?utf-8?B?aEtZdW04ZTRWeWRjbE1rTmxUSzdoQkdxMU5WNHB1RG5PUzZ0b2ZCZDBNT3Rm?= =?utf-8?B?aVNKWkkxVUdnYnI5L2lTeFNZMHBEUkJqSVJSekVsR1VOeDh3UEpRQkNLbWUv?= =?utf-8?Q?dMHJl+7xwzDgwKkuiW4mr57jt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0881a8cb-91c0-41d3-dd0a-08db0a70afc2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 07:38:51.3204 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LlOV0OduX2wSDnUbNTyFBJ0GWSamwPNnW62cExATCg/SP5VrJZzNBd9FXZi0q2iJOWchvGMPABeMe7W+NAh2ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6890 On 08.02.2023 16:51, Ayan Kumar Halder wrote: > On 08/02/2023 13:33, Jan Beulich wrote: >> On 08.02.2023 13:05, Ayan Kumar Halder wrote: >>> In future, we wish to support 32 bit physical address. >>> However, the current dt and fdt functions can only read u64 values. >>> We wish to make the DT functions read u64 as well u32 values (depending >>> on the width of physical address). Also, we wish to detect if any >>> truncation has occurred (ie while reading u32 physical addresses from >>> u64 values read from DT). >>> >>> device_tree_get_reg() should now be able to return paddr_t. This is >>> invoked by various callers to get DT address and size. >>> >>> For fdt_get_mem_rsv(), we have introduced wrapper ie >>> fdt_get_mem_rsv_paddr() while will invoke fdt_get_mem_rsv() and translate >>> u64 to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as >>> it has been imported from external source. >>> >>> For dt_read_number(), we have also introduced a wrapper ie >>> dt_read_paddr() to read physical addresses. We chose not to modify the >>> original function as it been used in places where it needs to >>> specifically u64 values from dt (For eg dt_property_read_u64()). >>> >>> Xen prints an error when it detects a truncation (during typecast >>> between u64 and paddr_t). It is not possible to return an error in all >>> scenarios. So, it is user's responsibility to check the error logs. >>> >>> To detect truncation, we right shift physical address by >>> "PADDR_BITS - 1" and then if the resulting number is greater than 1, >>> we know that truncation has occurred and an appropriate error log is >>> printed. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> >>> Changes from >>> >>> v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and >>> "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead >>> this approach achieves the same purpose. >>> >>> 2. No need to check for truncation while converting values from u64 to paddr_t. >>> >>> v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. >>> 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr >>> 3. Logged error messages in case truncation is detected. >>> >>> xen/arch/arm/bootfdt.c | 38 ++++++++++++++++----- >>> xen/arch/arm/domain_build.c | 2 +- >>> xen/arch/arm/include/asm/setup.h | 2 +- >>> xen/arch/arm/setup.c | 14 ++++---- >>> xen/arch/arm/smpboot.c | 2 +- >>> xen/include/xen/device_tree.h | 21 ++++++++++++ >>> xen/include/xen/libfdt/libfdt_xen.h | 52 +++++++++++++++++++++++++++++ >>> xen/include/xen/types.h | 2 ++ >>> 8 files changed, 115 insertions(+), 18 deletions(-) >>> create mode 100644 xen/include/xen/libfdt/libfdt_xen.h >> Can you please avoid underscores in the names of new files, unless they're >> strictly required for some reason? > > Actually I introduced libfdt_xen.h as I did not wish to modify the > fdt_get_mem_rsv() (present in fdt_ro.c). > > So I created libfdt_xen.h to implement fdt_get_mem_rsv_paddr(). The > *_xen.h denotes that it is derived from * (which can be modified like > any other file). > > Let me know what name you suggest. I don't mind the new file, all I do mind is the underscore in its name when a dash will do. Underscores should be used in place of dashes only when dashes can't be used (e.g. in identifiers, where dash represents the minus operator and hence can't be used in identifiers). >>> --- a/xen/include/xen/types.h >>> +++ b/xen/include/xen/types.h >>> @@ -71,4 +71,6 @@ typedef bool bool_t; >>> #define test_and_set_bool(b) xchg(&(b), true) >>> #define test_and_clear_bool(b) xchg(&(b), false) >>> >>> +#define PADDR_SHIFT PADDR_BITS >> Why do we need this alias? > I could have use PADDR_BITS instead, but decided to use PADDR_SHIFT for > cosmetic reasons. I, for one, disagree with this (it's pretty unclear to me what "shift" here is to express) as well as ... >> And if we need it, on what basis did you pick >> the file you've put it in? > > I wanted to put in an arch independent file (where we have defined > macros related to data types). ... this placement. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 07:49:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 07:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492206.761639 (Exim 4.92) (envelope-from ) id 1pQ1g2-0000JL-1q; Thu, 09 Feb 2023 07:49:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492206.761639; Thu, 09 Feb 2023 07:49:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1g1-0000JE-VD; Thu, 09 Feb 2023 07:49:05 +0000 Received: by outflank-mailman (input) for mailman id 492206; Thu, 09 Feb 2023 07:49:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1g0-0000J8-T2 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 07:49:04 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7e1b::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38aaf1b0-a84e-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 08:49:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8620.eurprd04.prod.outlook.com (2603:10a6:20b:43b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 07:49:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 07:49:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38aaf1b0-a84e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H5YWvBqzxzVzfnaSSADuJAdjh97Ri5IGyAAKoDcA2FvKoE9dPoYft5eLj9aVTAt2HNn+LuWgUXwhXLlyyn7TcMBSGvXWTjRAWx7eO2nFVSOyIxpb52L5HkC/tVzJoYQmMBrhxZlPJQ7ahMRXE1cGaPu2QmPTb9BnFPOzEZLqHbwp4BTQeowY/v1yqjscqni0OrHF0iY5cz0MBXA037iu3AlXXk+oMIGdKDx/AooOdhqxSoGwLhg5A1EVU4WCdk4sbXd4s6DAZUpbk6y8VlqeMZvvLYjjOepRa97ldNpanDXK7dMj5vRh5SSyZQQyapjOp489qdnnYGmOqMnaIKd1+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=50Q7QsxYqlbt6OCOWWyZxG+DYtjXGvXKmJwVrKliLw8=; b=ec7j//IVTjy/woBwPkBDKSpqTVaD4QCy1FxZ55gxb+ZazfETFZJURjfzyLPz/ZIuY4F1dVlDeYqdSjW6mvByvHMmjmEFFjWkJqW+GyK607f/eERcpPEGNZrffmVtjIZ1Ztqs1HhGWtfE8SPkZy9ZuKG3yI2K++8MIAk+cwpRFmJXid/wY5PI+3dXWH3VOQCrj54K2JNqqSvse/ETTgOckwFh9wP6eE0NgwyK9Vv43CtFPNwFoaq/coXNtV4XlcEZbm4F4OI0n0uLOftnajgIt161etIXM7PL1pNeQGT3RTV9JFwDAU6HQtyQzmLd+XTJAcYHOftoV+v5YATf93d+Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=50Q7QsxYqlbt6OCOWWyZxG+DYtjXGvXKmJwVrKliLw8=; b=xS4s7yUF5+H9/v/lXu377ueC5r++6xC94RVpbJoBiPcuEji5+zZh5neXaeLZgnEtmCDYYikUaThvZsllByQZC0QOrTmKPomIE30JtoBOWQJc21ki1F67hOvXiPrrU+XJODTYXcRn7Cqt44+CkA6jBrcw7Qb/x31vUu6OZYR03iF/8CjGkedL+4eFkwh7186ebJNVzQ5tzw46SA6NYztZbRsxm1f45+1WI0/JAIZUq82Xzd+LhIekDXxVONel5JB1dUNwoTUhQ3/YiIItoGKIwkeET0/imOhzNrtahFFWejZdmVP5CzP3IJlbLzaVNtDr5thWbYX9kdFrNKPea0ghFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8e21b928-7d4b-4a2a-24e2-5fd40647d842@suse.com> Date: Thu, 9 Feb 2023 08:48:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v3 3/9] xen/drivers: ns16550: Use paddr_t for io_base/io_size Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, wl@xen.org, rahul.singh@arm.com, xen-devel@lists.xenproject.org References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-4-ayan.kumar.halder@amd.com> <216343f3-6045-c6fe-ff4c-3a70d5061b78@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8620:EE_ X-MS-Office365-Filtering-Correlation-Id: b4144bae-c21d-481d-1fa9-08db0a721b9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3rcZG5GVsoG8McTLmlzeSfAKdeKsZgKpOWoITbLzrwkSJlwaGbTRE+IjA+PacDif2gA3LBNPh/xXvxGqrSYdd1H+BpvKUtkGVEDZsyag3FeswFkdAWuK4aH3CvxT7HyrcyoKsMJCU6TuhdGvrDmDEnUO/5WDvuYqxxJhQr4TcxMEYijvHUqaab5I/mQkkdKJJbtKr5/EWlaHfXJCQf9XgW2Td0+VCFpkdXUeGgcuf0As4ck3O7FC2StnR7fzbU1inMx1oefPtkG++79e/TAnXdlP6m7Yciub2ycC8ySZYbSjFuaCIbaTDGF6t+SyAYcDEdf68dNMbpdEQUSZBZchP0/F7yF/CtFaIoDnR+CIBfajK+CZSj3vlDxyfyxzja3QPe89XJv7Z7rf2EIJ/rMJWMMEGbxlAtezO32NqfUD4Yn0Y0oCEorUvudrPKEyXGKU2hqtF8rmocEuoKr2X5ZN7vLDo1aaXlUst1ZJ+tEjCAsPgY3Ud6T5Uga30azjxbT9huGrxNXOu8M/PDUaqS0dDtOQxMVf5c0WtnND7imIZmq8X4j7rURdWaXHlrVlSXki/7u5wLjUpAR7yUL03HFfEZCMxU7uOLYSkT4AkFLRGxhDYyI7UWaQcyYHBQ2kuWsMryzMBggHDmoJv7AuypB2hhbOwP5WMyw2NpDx+WS4QxFGHH67CwoICSNgh/eyzlshfMc8cFAzeZdN84wuVaMCX42mEivCOZp5DW/UqtwGZR8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199018)(7416002)(5660300002)(53546011)(6506007)(26005)(8936002)(186003)(6512007)(2616005)(38100700002)(83380400001)(66946007)(66476007)(4326008)(8676002)(316002)(31696002)(66556008)(36756003)(86362001)(41300700001)(478600001)(6486002)(110136005)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3VyWVF0M044TkEwZk03NVcrREl2MDVMN1VIT2NGUmVUaHJpVmgyQzJ0bGtr?= =?utf-8?B?cjUxdkNJMUpTMXZ4SkRJSXNqMWx2TnpzaDM4aUgrWDlNUW1QUzhOcnkyM2RN?= =?utf-8?B?Ryt2TnZtbjg5TDFlbXFQdmFVUHV6cTVKemNrZ3hteUhUOUt3anRZazI3OXA1?= =?utf-8?B?WDNzOU5ldzlZNkkvOXVTR0RrblA4djVWMUFMdUIvMi8xM2s0QUlhVndSWHBm?= =?utf-8?B?T0k2R29qMDM2alhXVFBKWTZXWGhoL2FtWFRWUmg4UVR3bHJGUWFCRzZvZ1c5?= =?utf-8?B?U2V4NUl0dVA2bVRFRVVsMXJtQU5XMVVXa1FzYWJVczFBR3lZa2JjeGt2RVlJ?= =?utf-8?B?N3QvR09QTlhSNnIxQkFOTnQ5K1ZQRFdRK3Z0KzF1MkNqSzJBTGFtSnI2Tllr?= =?utf-8?B?TmNEYmtTWlhhRXZucFBlcEF4SUJXRGpPdk40V2dLRUNNcW1XaXExLzNhSjZP?= =?utf-8?B?OXpqaTNtYm96OHNENGZLc0VQeFhiVjlUcVJpL082Nk03aWduNWlFN0lQMU5r?= =?utf-8?B?MFVOcThONFp1cERobW5zNS9XZmhYaDJOdnpwN2FPQTdMQ3NDVjRoTGZFeVNP?= =?utf-8?B?UU53MWJXbzdpS0pUZ1h6aHNHa0pKVGVwRzU1TldGY2xJaDFiVC9WUm5ZdFUr?= =?utf-8?B?ME4yMksxV1NIRlB2TVFxL0p6UHNRVWl6WERtTFBTUFVEK2hGVmpOTk9FbUM1?= =?utf-8?B?eGxwMUk2VFRnM1o1NnlLOHZBSzlQakVNd01FS1VsbWlnd3Zhck04UHUzUEF4?= =?utf-8?B?Rm9vOU85dFVpQUlNaWUzS3N1TjNQU0QrQU5LMlEyeUl2cjdTOUM3MTJadVVt?= =?utf-8?B?QlJDMXlLZ21LaGY3NG1ieHFPeCtab2YxU2cyUG1hbU82a2s4TnNkL09xRmdk?= =?utf-8?B?eXN0Tkx0RkV4YS82U3FKekxiSDc4U0NEQzBkKzB5UE1OaVNweDNPZjBsZFcw?= =?utf-8?B?SVRXRk10VTdReVdCSkxzMG9lZ09lRTIxeXNOd3piQ25Hb1RsY1B3WU16dDlI?= =?utf-8?B?VGc3Y251VExDRVZrRlFNRWtWZzVhYVhqOWVTNlZaNVo0WUNxV3BEUVFhN05K?= =?utf-8?B?UXlNM3BlZE1lWVZFd096c2lpT1dtdTRVd0lKcGdyOUJJVFQ0ZHVkeERIb3Ar?= =?utf-8?B?cUZBNTg0RG03N3NoTFVSd0tOTjd1RHRlRjlWT0wzYmlNWjUzdFhRR3g0dnZD?= =?utf-8?B?SDBhNzljVUs5MDRUL3ZMVm5Gb25kRU9Vbjc0SUxqaGxwUmQrcnRDajc2b2lS?= =?utf-8?B?SHJndkJhdVhqZ0RJekRlenN5U3lPMG56Vk9RRkNCUUE0UkxCK2x2U001eCtV?= =?utf-8?B?OHNsaU8yZHdtbkt0dW54aDhzNzZ4NXl4eGhkQ2xTTFNzNVdrVUJsM255cXZy?= =?utf-8?B?VnJmY3BEbnNJN1EraE9qNlFHWlJBOXdhbFBWZ25SUE9kaVdiNHNXd3ZoZ3cr?= =?utf-8?B?ZGJJZHNnbTVRWm02VDVQRkRESXhuaEx1Um5PNElVSURlSG9OSEJzWjVhQk9n?= =?utf-8?B?cTBYMGttbDFKbDd4QW12N0ZGTEpQcStyYXNSYmxCZEdpVnFMcWluSSsxeDdB?= =?utf-8?B?TjdoWFQxVzBEQXpVTVJMQnZ6WEFhMGVGUlVWeGNUVDZKZUlwTFZnZjB1SXdh?= =?utf-8?B?V3k1K2NIR3F5OVR3cFZVVlo3R1VyWVV2UGxsZ20yM1RmeGFsdmdSRlpudDlu?= =?utf-8?B?TVlIY0RJZmRHM1ZmbjFKT29MTG0zWGJFQWt0NE9uT3M5NndMU0g1d1FhdDZY?= =?utf-8?B?NWV6SWhJbnJjelREU0V4cCtTZlFud0I5YzE5S0EzSUdyYlZuMUpQajQzNktD?= =?utf-8?B?UWYzM0ZocjlZdGczSlVZWDdMN0lETFA4bFFIemh6SUF0MTFITHlVRDBHWkRC?= =?utf-8?B?bDFZSGF0cG80enRBNndMbG9WNWlva3VmYUwrVERoTExJV2Z5cWo0Y3NiNEd3?= =?utf-8?B?QitnT1h1dFFPbWhEZUw0UjVWMWl1bjJNblduY3ZwMXZ6bmhIcVhHbTlzc2Mv?= =?utf-8?B?NXRlVlVXOUdTbnc3d3VmQ1lpdzVVcUxUVUJwVkp0RFJtcGhxWEcvcWRDTkNV?= =?utf-8?B?c3RqTXN4a2VkZUU5TWFuMDNwcjF6ZGtiTWpnN0xhMmc5MlhJSndHY1RqQXpU?= =?utf-8?Q?wlryIE5ox/5nkHzq3osBVMSXt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4144bae-c21d-481d-1fa9-08db0a721b9b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 07:49:01.0788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wJZvAebz+DP7D+5nNYMMzyIFLtfbwMy0pqDOnQKcSgFJWmcupxTPrjNp4DxjsB+He+Zkd4GzEB5d0wBUpebr6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8620 On 08.02.2023 18:07, Ayan Kumar Halder wrote: > Hi Jan, > > On 08/02/2023 13:52, Jan Beulich wrote: >> On 08.02.2023 13:05, Ayan Kumar Halder wrote: >>> @@ -1166,8 +1166,9 @@ static const struct ns16550_config __initconst uart_config[] = >>> static int __init >>> pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >>> { >>> - u64 orig_base = uart->io_base; >>> + paddr_t orig_base = uart->io_base; >>> unsigned int b, d, f, nextf, i; >>> + u64 pci_uart_io_base; >> uint64_t please (also elsewhere as needed), assuming the variable >> actually needs to survive. And if it needs to, please move it into >> a more narrow scope (and perhaps shorten its name). > Ack. >> >>> @@ -1259,8 +1260,13 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, unsigned int idx) >>> else >>> size = len & PCI_BASE_ADDRESS_MEM_MASK; >>> >>> - uart->io_base = ((u64)bar_64 << 32) | >>> - (bar & PCI_BASE_ADDRESS_MEM_MASK); >>> + pci_uart_io_base = ((u64)bar_64 << 32) | >>> + (bar & PCI_BASE_ADDRESS_MEM_MASK); >>> + >>> + /* Truncation detected while converting to paddr_t */ >>> + BUG_ON((pci_uart_io_base >> (PADDR_SHIFT - 1)) > 1); >> Why would we want to crash during early boot at all? And then even at a >> point where it'll be hard to figure out what's going on, as we're only >> in the process of configuring the serial console? > > I do not understand the best way to return an error from pci_uart_config(). > > Out of the 4 invocations of pci_uart_config(), the return value is > checked in two invocations only like this. > > if ( pci_uart_config(uart, 0, uart - ns16550_com) ) >                 return true; > > pci_uart_config() returns 0 in case of success and -1 in case of error. > But the caller seems to be checking the opposite. The callers look a little odd, I agree, but iirc that's intentional. Since this is all PCI _and_ x86-only code, which you don't care all that much about, one option is to leave that code alone for the time being. The other is to properly propagate such an error through all involved code paths, e.g. by way of invoking PARSE_ERR_RET() in parse_namevalue_pairs() in the failure case. >>> @@ -1532,7 +1539,12 @@ static bool __init parse_positional(struct ns16550 *uart, char **str) >>> else >>> #endif >>> { >>> - uart->io_base = simple_strtoull(conf, &conf, 0); >>> + uart_io_base = simple_strtoull(conf, &conf, 0); >>> + >>> + /* Truncation detected while converting to paddr_t */ >>> + BUG_ON((uart_io_base >> (PADDR_SHIFT - 1)) > 1); >> All the same here. > > I can return false from here and let ns16550_parse_port_config() return. > > I think that might be the correct thing to do here. Perhaps, and likely again by way of using PARSE_ERR_RET(). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 07:58:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 07:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492212.761649 (Exim 4.92) (envelope-from ) id 1pQ1oX-0001y6-Si; Thu, 09 Feb 2023 07:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492212.761649; Thu, 09 Feb 2023 07:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1oX-0001xz-Ps; Thu, 09 Feb 2023 07:57:53 +0000 Received: by outflank-mailman (input) for mailman id 492212; Thu, 09 Feb 2023 07:57:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ1oW-0001xp-Pq for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 07:57:52 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe12::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 736cdcf3-a84f-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 08:57:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7798.eurprd04.prod.outlook.com (2603:10a6:20b:2a3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 07:57:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 07:57:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 736cdcf3-a84f-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbBP6srEfoJI/HJZPW79KuuIFThY6Rky8jZpuTzorKJ1lRnbSnG+so4MbBJgAgJvrDoNw0Sq8fHLIHOnfyo8oDxUa6f07QkpRWQcY+U0WjvWK+zp33jAdfZjNZS8z0NE/kjYa8blBjlE/wh/FafUS8Zv3w7fNHzxJVQCUU9i0eqjTYMcgHFeNHbqSAyz+lKgjXgyT4cGCP+Xy8GKfgOIu9hjlGJWM8P1AqhESAMJXl5+1scZ5PQqnMLvvSAaTAVj4CJwW0Hg54tUsOcRGamZjioKiG0MYwufW0ND+q/JSl4CLOenC57X6FYuVDPgUIs1Iq7pB5Tw0LnC4WSLsSwz/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=83QCFni1/ZU7RzXfpSgXvWIy3SfQ2Dbqde21hRD1oZE=; b=UFUvA3NdXRu71mo/jCQ2NGjXYDg/u7HpySK5lP4ojiySW4fsHismVXJsq3VPPff694ghsELNhMxMcSfd0regXj+bwabJ7pRdOg7NgMzK8L12OcyhR4a3U1qbC0GLo2CI8Jwz+kr/A+cYDtsdhMIERorWZEiYkyR1L3jplkg8+x4GQ+YekIWRy9LgMX51c6K4/zu1IkqSAEiYblUHHy6lgbGWEY7SxqeVeSZsT8VK1os3Y5RFoudn1e7eHIxuaB3bv2AOUWJny4yGobvIno+bGqC+U9Q/N2++N8ASiFcPpLeh26zAVlUOcgkk5iUfm3B+QrgTNunEjmwY9lJJfJzV8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=83QCFni1/ZU7RzXfpSgXvWIy3SfQ2Dbqde21hRD1oZE=; b=wl6tcZ44T9DImv+tTkshayO86j/fvOBIbl2tKoVB1tKH/9Xh2fYNizkvyMcp5dC5ANvy7syvCTCpbvRjePAlySNaVI+LV/0M0VmQezIzZIV3yMmJO1x+tmqO+SyAVeXsXt+KCcp9h29UNOu1dXlE+qSyEdFC3ebdX2WYABET7Jg5IGV3dn0QNJ3Nn2wuNF8mX2SX1GbwOyOL7Eem9lIrVTaoxCf97L4aEVLW2U6yhHpsR0JUQSqaT8kQjj3tNa9P52fMT5joFCpLUWDxxbAS5CVm8bf+QmAgV6egPI5QowQWP8Lzne1t/FZ1Jy7bMbec0ylmCkskn/GYdI6t/SVZbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 08:57:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Content-Language: en-US To: Demi Marie Obenour , Julien Grall Cc: Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Stefano Stabellini , Samuel Thibault , Daniel De Graaf , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <32fae62c9eb9e9536d49fdd28e1bf54430842023.1675829867.git.demi@invisiblethingslab.com> <3f3c358e-02b9-94e0-0b06-8a96ff92519b@suse.com> <1770bab7-3e25-d611-1d3f-58c02a2f7492@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0203.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7798:EE_ X-MS-Office365-Filtering-Correlation-Id: 267677b3-d964-491b-fc16-08db0a7355a7 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CCwUjHQovCBs2kxPcTCr1g6ZTYSIcl9j1P4bgYr6bEPinUBoN4miUws6NHeDGtyLx9jjJ4kadMdZvo9dCfwwk57LOhgPzcVliycgnM8WpKtDDz3pWaTkCrSjikmWybCvlSrJesB2PCRa/8Tj3nimmSPyYFnsvNsx/z86kYL6+7aL8W1GiCl+R5q0AtHTqSZG2K4m6zg5mjUl3BZhZU7s9lMmxlJJ0vPzSuLkrnibzHkQbhJ5vWwaHIfmW6KYhvN4Nb2Fgrardbz9SjngVBbyxYwP/Yxv4Q7X5dX/LoW+QjrDIZLF1U03Wpd/e2kMnvJzvs8k3oGzFk9IQR0N9CGPvqpjTVrlYe/HttYzsEl8eRg5U6lZXJlRPY3eOf5QTVKh/EnNhLqcgqg0UAT0kmnmEJCsz3bbDYwHHcJwCnpQyDt2NSFLLdi+sZ3BaivJ7cO/UEzhBm0KIwarHBJWQj5CsD3NrTzLD8xRbC8KtAzr6AFHT63tstFuoS8pqH7HB+KFk5FaojTW9TMeb+JXf9D+aLUsmIkVqUPpZXZcEVvV+pwBhaEQbaqOvjF9Q9mNPfVTQbg7mFr0lAEL91Yg5VFCMJK+XEIfxPXf1BRR2Sk2qILPZnhfvF+ApzO2jYI/iZRZxPImi3nA2RBCKF6cw0R4bzpUkvnpSxg1aKtxzmWoriEKcNiPLk/9a2KggwKezxtsB84yBgopmDYOU2AbKelEW4/JFDbtK63gSQI5qtFrIDCfM7yKWCZTqtUdX6aWYckIbd8BowainyZrQG4Ct7oyss2DVN52i3LOlvnChj2C4U8NLgT6DxfSPwMsto0iQc0O X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199018)(478600001)(6486002)(966005)(2906002)(26005)(186003)(6666004)(6512007)(53546011)(6506007)(41300700001)(8936002)(66556008)(66476007)(66946007)(8676002)(4326008)(7416002)(110136005)(316002)(54906003)(5660300002)(38100700002)(36756003)(31696002)(86362001)(2616005)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXlGcmphcDF2Wk45bXo1TVdVRU5BZFpxZEtOdVpCR3VXTE9yZFVkVVRVRWc2?= =?utf-8?B?a1ZGUTRxMEdGODJoanRtOWhrT3Z4eGw1N3F4WkRpa0dmRzNJTHlWYytrTjdX?= =?utf-8?B?QS9sZkVuaXF6aEk0L1U4dVJES201ajU1WU9JMWhDc1hCc0FEYUVxaWdUc0Rr?= =?utf-8?B?RzFQZnloYjdOTXhQK2FlZkRjSyt2emFBeEFkU0NxM3VxOTE2d1RSdGI4SVhE?= =?utf-8?B?YVo2RzNBZ1BveEZHNnZXYXB0ckFVU1R0dktOZldLODVidDd2YnhENmNBbDhL?= =?utf-8?B?M1o5eHVZZEJEY0tCaDdGd0wwWGxpWnJvQk9oK2VhUnJ2TUVCbTBhV2xkcWdo?= =?utf-8?B?d3I2ZFlIbTFRUXRjeU1OSis2dFlIdDdteDhMbHIrdUV0REY1bEFYYjBPbCsw?= =?utf-8?B?Y3NETDhYdDRJbGNSTzNPR2x4MlZ4SGR0bk5wVTJFeTBXSFlVSFlXWm43cWJG?= =?utf-8?B?NlB5dzd0b2ZnQW9TMUY5Vjh0NTZoeTNDUm9aTU13NnlMd3BGT3dxL05xTDY3?= =?utf-8?B?TXdibWw3ZTZnb0VQOW1HQmR3WXNobHJEUytaNXE4eTNKMkNaakgyNzUxbkVC?= =?utf-8?B?L3ZkWHdBQzRXc0ZNYkxHc1lJSjd1Z1JUcEVrbFRsd25yeS9Ga2c4b0o5OC93?= =?utf-8?B?VTBBNEwzUnJycEFHS0t6WkdzTVdPUE9nalVrSEN1bWNZQUd5Z3E4NHpaTkRw?= =?utf-8?B?MEhHL3dWUForZi9ST3ZycjNWRUZwSVRSNmR0SkFGd2R3QWdTdXF4V0RWS0ll?= =?utf-8?B?LzEranNNbWhPMzF4cVZhZmpPaTZkS0RaV0RFRVVDNmYycGN1NmpJdDh4K0w5?= =?utf-8?B?ZmN6eUZxTC9XK2FxQlhyZ2FHNFNTZHdKOEx3MW5iSEJkMkVMZW93bU1LK1dL?= =?utf-8?B?eTBQbjRRSjNmWTdvVFBQaFdxcG5NeUZNSzBJYlMwZzRabTBqRGNqUlczYmo2?= =?utf-8?B?Y0kvK0dCZThiVEpFbjQzM3RtTHRrWWVIcDhrbGdlaExGK0VXYU9UMXZHRXNE?= =?utf-8?B?eHJJSFFTcHhXMmRXMlRteDk2TGw5TFkvU1REZWtYSTRhRkJ1TFQ2Nkw2SGt6?= =?utf-8?B?ZW1nZlFDRlVIYnRGeGJXT084WXhNOHRFUENtYzIzVkFaR3RncVhZbXhlOElu?= =?utf-8?B?TW93Yjk3S2JULzgwU3pEZnZoMDhkNnp0MEJlaUFIOVRQT3pVVHp2U0JvV2J1?= =?utf-8?B?Z2JGMGN1T2RuUDNPZ0tPdGsrd0doTlk4SW5mcEhCcElrVm43YWJtb1ltL3hY?= =?utf-8?B?cTZEekh2Sm1GVUlwQU9lTlBzV0hVRDNLT2hIalY4NXJGNHVQamVOVTY5d3hk?= =?utf-8?B?OU9XY21IVnFxZVYrQTZ0ZWMvcE9iMW9PUTNETU5ZN0JpS1plMTN4OWMzYk1T?= =?utf-8?B?ZWZLQTljRm5BVFNvcERRMXlRaVZ0RUpnRmJGMGVvMnFEblBmR2JubjdZK2g0?= =?utf-8?B?aktLdERVVzBjUXoyelhLSTlqR0E5UXY0TzBJWTlqYVFpbzg2QzR6Y2c3SjEw?= =?utf-8?B?N1U4Q0RzdjcyT3ZFSWIxdHhOaTBORlRZTjYyNWxrWHNveFhsdUlJZlZVM3Br?= =?utf-8?B?dVl0RE5WRlJ5RnJtRlM0YXRKdUpkYllNbGZTV3FmbTE5YTU1bGhRdnIvSzUw?= =?utf-8?B?Mll2TE5SbFBhTFdDelN2c0FTVUdpRUozazZrQ21JWTdZaVZ2ZDBuTTZNMGkz?= =?utf-8?B?anE5ZGRUWEFFSG5QZStqZHlVdmZVczdIU3BoRGJIaG85eWZIZmVOc0FFVDY4?= =?utf-8?B?ZUpMOVBEa29PTDUvNDdFL09ENGZocGl2dmlWTmNpRUpqU0tlSHpHUmloMFVN?= =?utf-8?B?bm5tUTBUc0Ewb2d5MFJ1SEpXK0RyYnNXNTlGWWxNYXF2emlOUi9NemgwRjI5?= =?utf-8?B?bEl2VURuTFdXMEJyUEtuWDB6bHJ6MGFlckFrZDNSZFp2V3kvcWc1SWsyMFpa?= =?utf-8?B?TGJRYjYrelp4a1RBZHBIeVBMckkxcWxjdkxMTXczNjJiRWg2U0lNdVl6TExQ?= =?utf-8?B?RWVvd0dGVjhhV1JXMUQzS0pyTTlnVXBCWG5KY3pYTjBQZEN6a3N6VFVxZXhK?= =?utf-8?B?OEVaVkc1K1ZuaGlObkQrZGhoVzFnSUpwblF1Kzg1Ui9RUjYwTlpSTTY5WE16?= =?utf-8?Q?KnRHXujtSVYZlniSKwCZWYtrQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 267677b3-d964-491b-fc16-08db0a7355a7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 07:57:48.0771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xQdkVB8lOulPJe214wV+T1jy1K+b7kEAvVmLNiOxBC5PpVrM1KabMup7VAbTftrnFGIknr/pySq2LCIQQ/QESQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7798 On 08.02.2023 20:19, Demi Marie Obenour wrote: > On Wed, Feb 08, 2023 at 08:26:37AM +0000, Julien Grall wrote: >> On 08/02/2023 07:40, Jan Beulich wrote: >>> On 08.02.2023 05:51, Demi Marie Obenour wrote: >>>> --- a/xen/drivers/passthrough/pci.c >>>> +++ b/xen/drivers/passthrough/pci.c >>>> @@ -11,7 +11,7 @@ >>>> * more details. >>>> * >>>> * You should have received a copy of the GNU General Public License along with >>>> - * this program; If not, see . >>>> + * this program; If not, see . >>>> */ >>>> #include >>> >>> At the example of this file: While the above matches $subject, ... >>> >>>> @@ -285,14 +285,14 @@ static void apply_quirks(struct pci_dev *pdev) >>>> * Device [8086:2fc0] >>>> * Erratum HSE43 >>>> * CONFIG_TDP_NOMINAL CSR Implemented at Incorrect Offset >>>> - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html >>>> + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v3-spec-update.html >>>> */ >>>> { PCI_VENDOR_ID_INTEL, 0x2fc0 }, >>>> /* >>>> * Devices [8086:6f60,6fa0,6fc0] >>>> * Errata BDF2 / BDX2 >>>> * PCI BARs in the Home Agent Will Return Non-Zero Values During Enumeration >>>> - * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html >>>> + * https://www.intel.com/content/www/us/en/processors/xeon/xeon-e5-v4-spec-update.html >>>> */ >>>> { PCI_VENDOR_ID_INTEL, 0x6f60 }, >>>> { PCI_VENDOR_ID_INTEL, 0x6fa0 }, >>> >>> ... this doesn't (and would rather belong in the earlier patch). >>> >>> As to $subject: Wouldn't it be more logical to replace the license boiler >>> plates by SPDX headers instead? This was done to some degree on Arm >>> already, but I haven't gone check why it was done incompletely there. >> >> Skimming through xen-devel, it sounds like it was most likely a lack of >> time. I think it would be a good idea here to switch to SPDX. >> >> That said, I can appreciate that Demi may not want to take on that works. So >> I would be happy to give a try if no-one else wants to. > > Should I drop this patch then? I don’t have time for the SPDX change, > sorry. My view is: Yes, except for the part(s) which don't fit $subject and which hence belong elsewhere. It makes little sense to me to touch text we mean to fully replace anyway. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 08:24:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 08:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492221.761661 (Exim 4.92) (envelope-from ) id 1pQ2Dg-0006EK-9b; Thu, 09 Feb 2023 08:23:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492221.761661; Thu, 09 Feb 2023 08:23:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2Dg-0006ED-6H; Thu, 09 Feb 2023 08:23:52 +0000 Received: by outflank-mailman (input) for mailman id 492221; Thu, 09 Feb 2023 08:23:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2De-0006E7-Cm for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 08:23:50 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on062d.outbound.protection.outlook.com [2a01:111:f400:fe02::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12e294f3-a853-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 09:23:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7415.eurprd04.prod.outlook.com (2603:10a6:10:1aa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 08:23:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 08:23:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12e294f3-a853-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgiMCKGz8LMNIXI0+nAQBUVH488RTAPjgc7T9KVqoGipERBegv20iWr1YuMhZyIv9FKM+d6yrk8WorxWYQREW81tb/RPy1hmPLsUt9A8P/RuEGJkSyF81ZlQHUSv2w9J1UpwQkX5GvieK4P6S/IVf1GE7PSGOXQnLz7+R5tcfFsyVB/W8c7HTH8lZM47swJYx9mNw3bfTzOPmfg338oUSZjbmtggePWxe5cq/ZJ8eiiDVbIQc1kC4lC49Z7hhA05d0djISboJOkO7qxeNjwo5vNfjV2/8DAL7R7Rqi8JrmdJ54zL7Zq2WoQYId59aWRXGpViT7wpdJS9F6R/GUyPsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2MSLTr5bJCc0vZPXbtdi9LRKuhnsxihgxdpYrsAZF5s=; b=R1zdywdUPgnkqE56gNH+VVk8VSe/lRRQHHT9JKEbkGJ6hqYpf6bSpyN3ksUCYGXhjE+EvHXoXNcH5MbcM+Xca4P/7JHTTBjU4GjHE3hjmjn5piUq3O9URudf3EgAHiD7UGLYKh/JAodkpBhfTsQR/nstroT6YGCHWPE3ZGL4/nPxMmxRBP5dBoS2mRsy1QZN/UDNgMHNmlI5PXhlDIXoVCkAHE37kYefjWuw67fl0GogmVsRVv8FDpGgLJNSnRJfYLGEtqV7t6MdQ//V9DFUpB6/ZKZ6IlGjoSXMQm7wQxSP2ss0pSBWd6GOvimSgZ44pciBRkbGnobDWNzkAwX10w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2MSLTr5bJCc0vZPXbtdi9LRKuhnsxihgxdpYrsAZF5s=; b=liDxfVMwnyNOd/2rzqF5/IPj5DT/u97jdcpkOjE4m3WHV64Qb8EXNb1tkwf8dq4t/pwHs9m+BUHSz6fmv+2jxWUsDr7TFlg5SucWXpufEEvGZO0g2Y/fUN71K7tBd8TakkVSwyASXi+vB8nuC6CNnRiE++m62XuPSiKvmPCEf3b026U6mppS1pqQjxF1iOsytO7i3D5tNwMq5V41hx5ONhCcOLgSsFoP8/1K1N9mpONh/y2e2P+bIXSSRVG44Hu7Ufffjuv7HZPdFz99wFjk90J/g+eJTpG7H+P2U9Tony4WLB0Zw3CUbf4aNPzDR9k5tzifGK6jN4NIHlSne2tI8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <16bf6ab7-6130-a851-2546-7bea5b64ee57@suse.com> Date: Thu, 9 Feb 2023 09:23:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Content-Language: en-US To: Elliott Mitchell Cc: Anthony PERARD , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20230207160948.3169-1-anthony.perard@citrix.com> <7e01f840-1d42-f31e-4471-ee06820b4b31@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0197.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7415:EE_ X-MS-Office365-Filtering-Correlation-Id: d83cbc81-b93d-4c54-8b39-08db0a76f63a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EzNNV+9UHTFf3uo9a0Hsc/2Z8qX5CWo7SMVWZbKggXpm3iDhOEY+K5V6bLbwmz41aWuHrr9zVfiwCLSRBg5rO031Im1ZKnMrTvP5tbES1fqeapJVDibQCr86FJqQEXUvn78SKzC3LzPFngGM4S+b5gN3nzTLj45ZVBvwdzBtAmr7AHYuVuDth9chrMeJAcXIZteteaIa6PBZ7V12dUmJSeLKbbKanGeD7VNbNhIg64NYbe62BlgYukEI5kR2N7yNlSPh/ccg2aplylHFGYnTeRZOjefz3h++YTatFve8u6rNiTFPcmqumCUiEBttuudTF+lzTRnZiNn5jgNF3XOtGgFz/p4Wecu8KVgD0GLxwxvbUdZPU58rIUpO+NZOWuUbRvvoqMK+s4A4MaelmKVUFgKKhPP6h02Y7H7rQdb81zXittv7qO3hljOQaLr3TSaCxbMbyk5SvBdhcabYtPtojnoltRRjEW+ItUjfeGZaKHeJ1HTPLeqEDDqOsCwBJvF3QffciBeSPU4/RcnrY0oMW05aXKo5ezj6yUQgzTFPRJ0OGPys9CmpNg7TsuDWcMwDHxLwIet9j5TPQKU6iZT+BQZpHqTor3dmteIThDGfjSlaSIHOdo7xrEOoiDtR3Rv+HUfuWLSZaDWyG032jONfxmIdIJ6fehRJ4QjvEvvmDOVtWdxnX4UDlDwpfGMrlWsMO9hUB4ta7S18cagE+RAECuZee2afSUD0rPX+X89D3Tc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(136003)(366004)(346002)(39850400004)(451199018)(6512007)(186003)(2906002)(53546011)(6506007)(26005)(36756003)(5660300002)(478600001)(31686004)(6486002)(8936002)(41300700001)(2616005)(66899018)(8676002)(66946007)(4326008)(66476007)(83380400001)(66556008)(86362001)(31696002)(54906003)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1dDdExyZGxwWnFGUm80dzhjTjBDQlh1eThKcFdlaEhoVEI5NE00RDArVjBh?= =?utf-8?B?ZHNtVTk3YVhEdElMWUQ3NzdlZ09Fb2I3N1dTNW1abWxzenBVc0YzV2Q4REU2?= =?utf-8?B?L3k5WFhmdUd4d0g1ckxlVFo0Y1hsMFJraUIzMnNOR1AwdnVRa0ZNeFRncUk5?= =?utf-8?B?RVA4OTdSMEptYWZlTElwNWwraUZRVWJCeVp1ajlQTjNpNi9hNHA5VWx3SkVm?= =?utf-8?B?ODBlVU0wWE5zb2szVGFoWFcwdUpNMDVVTERMaElMdzc3bFdCS2o4L1k1SjM1?= =?utf-8?B?YkpuNkl2V05tc0ZVN0c2YWRhZkErdm9wRnZQWmJRRXRYWmdFajZUeXVLM3RQ?= =?utf-8?B?MWpjTm5ZVHM5ek5JYmFjWnY0clR3YWVjSWRzYXZPdmpMeFJmSFNCZFJNK2dU?= =?utf-8?B?SnVYd0hwUm1ldXp6VlpNaXlJVS9DM2FvNk1KOEZNZHZhTGUxY2pSd0ZaWjF6?= =?utf-8?B?OG1ic3pRK3VYNXduSWdtVlNOVFJ0UFNkbDAzcFp4OVhXQ3B4bFJybmU4Y1Vq?= =?utf-8?B?MVZ0RTRERnBDOVUzYlZPbEoxV0UvbDFJQTduSDI1UDNaZHhmNm56Y25tSFRB?= =?utf-8?B?aEsyVFMxRUVWazloQkR4OWV2ckZ0blIyUDdCTzlBQVRJd2tZMC9OMGhKMjR4?= =?utf-8?B?SEcwNitST3RGY004RENTeEVYYU1OVU8rZ0RzQytiNVA3YWNrbnArK2U5QW1O?= =?utf-8?B?STQvT1RUVWJHWHowd3E2WUQvSFBwc3NzK1ZndFo4eUZybGg3REtiaElCbVZi?= =?utf-8?B?THN3cTZueVNLWEZLd0s3NmtXVmtPRUJSRUprVEVobkRUWUp0YjR1czRqa1FB?= =?utf-8?B?am5FcUJsNDFhY1gwU3JLNkdIOHB4UVdVY1RnTS9Iak43TUFRb0ZwS0NrSzk5?= =?utf-8?B?VmtBeWJKdElBUmlwQVhwd1JhZHBVTlJJMWJ0Vmxwbk1ibFJPS1RqbXpSTnM3?= =?utf-8?B?MFh1eEs3QU84aXJlajg5QXBtZkw1QnNnZTNWN1pqaTZOL09BN294SmJXNURI?= =?utf-8?B?dkxRWlJ1a2pTeHBwUnQvS2Y4MXVFNngrVlVmeUlTcXlPWHdJWDlYUURacGRM?= =?utf-8?B?K1Z4TWU3dWVlV0orNWdEaTdqcXphbWR2RkgvL0FjSXJ5K1RiQjA2Sm1WdWth?= =?utf-8?B?REJwNWhlMUVHV3JqUWdkT1pad2JYdUM3V0RhZ083dXkwY0ZFM0tCOWl0STdm?= =?utf-8?B?eVVGaXN6eWc3eVZvOU90ZE1SOXI5M0JBWS9WSjdwWVorMXJEQ3k3QlRCNFNm?= =?utf-8?B?dmtZV3hkeWgwRnozbGhuMFVzNFFxenpURG1BbW9lbEFZNkx6Q0cvUFllMEtl?= =?utf-8?B?eGRqKzhROU1oMTQxdjBZa1JIYm03UTAvRmtyRysrNXB0c0pTQkVOeHRDdE9r?= =?utf-8?B?RVJMZ2xnRUZka1VKZ3YzbVFKbjJuZWJVNStKS2IzdkhIYWJkWGdNdTQrM0ZM?= =?utf-8?B?RHlPeldLZ1Y1ckREZUVWeGlTQ0x3K1A5Ym42NExIS3JEbHhNd05yTTl2QmdL?= =?utf-8?B?b0tObnVnSjRMQm9Za0F4dEwwdWVRMjVTbVpYbDBDZ0xGbk9GUkZQb082MVAy?= =?utf-8?B?cVhmZGZYamZiaXp0MW5XQkJxV1hHM0k2NURTRlg1NUVic1l0Ukd5dXBZZUVh?= =?utf-8?B?djRVZC9FOW53eEEyY2E0aWMxYmhpSExGNUpkUzZTaWFlSTRRZTBZcGFWNG1V?= =?utf-8?B?OHhPT2dOZDVSbzNIc2xnckJJaXNoOFMxNmk4RElNSkFCK2R4M3V4N213WG5J?= =?utf-8?B?ZkNYVEpDRWRZSHkxMlo3U1FaZlhwaitPcmU3eGhLbWR1UlpWR3hHSCt4ZUxJ?= =?utf-8?B?eGxIUENYS0grYnpvT2NhNUIyaWZPSWVWOUE2V1ZDVUFRZExMU2VtNzFXSDQ1?= =?utf-8?B?Um5IcGQ5WEw3VkRiQ2tRWTdTcUVyS1VWOHNaUThvNEFkNlhJc2xjb25ObHIz?= =?utf-8?B?VTVIY2xZTW5BTW1IaHR1T0RaMmxTSkZGbmxYQU9OTitORU0wT2JpRUl5cVdr?= =?utf-8?B?SnRucnZzUllmSWVqNHprSGllM1pLVndlU09DeDJGRWd0NVdNMHR2NWMrQTk4?= =?utf-8?B?WTRQOVY4R2x2NXgzVVl1Z1JIRy9qRWFCSktQM05qWjVqKzhyb2FvazN2M0Uv?= =?utf-8?Q?ZDigUug/+RJLWuR2ebr3KO6a3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d83cbc81-b93d-4c54-8b39-08db0a76f63a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 08:23:45.8382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /RiGHgnvar2EHZ9wyXXM0GNWmGfuikxzryPX+ZyI4975cCtJ6EF4ewZCUXCNUVhZKHvpnIl473KksqkquFV4kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7415 On 08.02.2023 19:51, Elliott Mitchell wrote: > On Wed, Feb 08, 2023 at 09:02:35AM +0100, Jan Beulich wrote: >> On 07.02.2023 19:02, Anthony PERARD wrote: >>> >>> I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" >>> failing to build while "libxlu_cfg_l.[ch]" are been regenerated is >>> probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of >>> targets. >>> >>> If for some reason we have: >>> libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c >>> >>> Then make seems to take two parallel decision: >>> When building libxlu_cfg_y.o: >>> libxlu_cfg_l.h is newer than libxlu_cfg_l.l >>> -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o >>> When building libxlu_cfg_l.o: >>> libxlu_cfg_l.c is older than libxlu_cfg_l.l >>> -> we need to generate libxlu_cfg_l.c first >>> Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been >>> updated do to the parallel build of libxlu_cfg_l.o. >>> >>> I can easily reproduce the issue with: >>> touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; >>> touch libxlu_cfg_l.h; sleep .1; make -j >>> And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. >> >> Interesting. In my somewhat similar experiments I found that an issue >> exists only when one of the .c files is missing. Things looked to work >> properly when both were there, but one was outdated. Clearly that's >> yet more surprising behavior than, as you appear to observe, the issue >> simply being tied too "needs updating". > > The actual problem is flex and bison output both files at the same time. > One process sees all of its prerequisites are up to do and therefore > proceeds to the next step. A second process sees an out of date > prerequisite, and starts to run flex which wipes out the prerequisite of > the first process. > > > Crucially libxlu_cfg_y.o does NOT depend on libxlu_cfg_l.c, therefore GNU > Make is allowed to proceed with building libxlu_cfg_y.o even if > libxlu_cfg_l.c is out of date. > > The problem is the rule to update libxlu_cfg_l.c ALSO updates > libxlu_cfg_l.h as a side-effect. > > > As such libxlu_cfg_y.o needs an order-only dependency (assuming GNU Make > syntax is allowed) on libxlu_cfg_l.c, so the two rules DON'T run in > parallel and cause havoc. Since you keep referring to this: Yes, GNU make syntax is allowed. We use pattern rules, which themselves are an extension of the original suffix rules. The issue is that we can't (unconditionally) use stuff which was added only in newer versions of GNU make. (See ./README both for a statement on us requiring GNU make as well as one on the minimum version we expect to be in use.) According to my reading, an order-only prereq isn't what would help us here: "Occasionally you may want to ensure that a prerequisite is built before a target, but without forcing the target to be updated if the prerequisite is updated." This isn't the situation we're dealing with, I would say. We want the prereq updating to occur and the building of the dependent target to be deferred until all the prereqs were updated. >>> I don't know how to properly fix this yet. >>> Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is >>> supposed to be grouped targets. But that's is maybe fixed in 4.4. >> >> Well, in my tests while 4.4 has fixed one issue with intermediate files >> affecting the behavior here, the issue we're possibly running into is >> still there. I've sent an inquiry to bug-make@gnu.org. > > I do not believe this is a bug in GNU Make. Merely double-output rules > cause precisely this sort of trouble in Make when run in parallel. I suppose it can be viewed both ways: Make has all information to know that the file _is_ going to be touched, so it _could_ order operations accordingly. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 08:31:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 08:31:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492230.761672 (Exim 4.92) (envelope-from ) id 1pQ2L1-0007tv-4z; Thu, 09 Feb 2023 08:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492230.761672; Thu, 09 Feb 2023 08:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2L1-0007to-1k; Thu, 09 Feb 2023 08:31:27 +0000 Received: by outflank-mailman (input) for mailman id 492230; Thu, 09 Feb 2023 08:31:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2L0-0007te-6u; Thu, 09 Feb 2023 08:31:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2L0-00068C-2M; Thu, 09 Feb 2023 08:31:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2Kz-0004vl-SO; Thu, 09 Feb 2023 08:31:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQ2Kz-0002Bd-Rt; Thu, 09 Feb 2023 08:31:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uz7PrT8gO7+W8w4Tgm69uR9hWN+q3xaxqaVkh+lrhcw=; b=guCW9ZWnv6aDn1AasM0XOJ45BW wzoyO9g/TS6c0jB5h7EHuWi35TqGdKvVlz+lPktsTqfKWeAA+E+sPtiSw44ZdS5/gAuNNToUEOI/5 xFUdyStYRZlXYvXAHDuSSbX6eke8xNrMElWOqSYdae9zfQ6zMKH3oPO2ELhH8M4zWqCQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176653: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-5.4:test-amd64-amd64-pair::broken:regression linux-5.4:build-arm64-pvops:kernel-build:fail:regression linux-5.4:test-amd64-amd64-pair:host-install/src_host(6):broken:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-examine:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Thu, 09 Feb 2023 08:31:25 +0000 flight 176653 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/176653/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pair broken in 176460 build-arm64-pvops 6 kernel-build fail in 176438 REGR. vs. 176106 Tests which are failing intermittently (not blocking): test-amd64-amd64-pair 6 host-install/src_host(6) broken in 176460 pass in 176653 test-amd64-i386-libvirt-raw 7 xen-install fail in 176438 pass in 176653 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176460 pass in 176653 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 176460 pass in 176653 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176460 pass in 176653 test-amd64-i386-examine 6 xen-install fail pass in 176438 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 176460 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 176460 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 176438 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 176438 n/a test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 15 days Testing same since 176413 2023-02-06 07:13:34 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-pair broken Not pushing. (No revision log; it would be 4165 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 09 08:44:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 08:44:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492238.761683 (Exim 4.92) (envelope-from ) id 1pQ2XI-0001BR-9O; Thu, 09 Feb 2023 08:44:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492238.761683; Thu, 09 Feb 2023 08:44:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2XI-0001BK-62; Thu, 09 Feb 2023 08:44:08 +0000 Received: by outflank-mailman (input) for mailman id 492238; Thu, 09 Feb 2023 08:44:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2XH-0001BC-3w for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 08:44:07 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0613.outbound.protection.outlook.com [2a01:111:f400:fe0c::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e86de637-a855-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 09:44:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7338.eurprd04.prod.outlook.com (2603:10a6:102:80::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 9 Feb 2023 08:44:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 08:44:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e86de637-a855-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=diVfFRjyW4jQxEkPjDup+bwZyucJ519j7ZLqe/bkRFoOsZ3Nd1oE4rsNesM5vRolrFQzsrwRSdFSbRTjAUkASJJwxMmLO2uuSqLknhmdaw6ao7UAtCemHQvHDUYVBz2pVCluaWoYJl6cuFAM2uRPQfBsdkXbvNilADrjIABCsvYy4jc6JbhN4Bq3MOnf4en23R/CLaIazDyMZxOzczIzkz7Qj9l1RHb146scPPZmFA4OXE3ve8yygkahRh2oP2VDZNgPiwBBk6YuNAo+L8oY2QcSGKfB+9HCXD+qov5BABWOGaX2SmhUrnfGOLQAWXc76MrefhLaQOnTuYweQbTuuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oSUux6/54go8UABCZxIEZeLRzksdaTnN8Sc75jvVj1A=; b=V7RJs5ghOz5TCKho7iwp+Lc71plYMGjrteEXHVWJ6qgGcwq0iIwnYkv+OAezSttdblhEyDxQM2C0YhvqEW1UhCzsyNNdkS7BqO3/uS8ToS+9I6ZFnNEvs8J+FuzLFw0KDEVSbu+A2CXxph6ukmZtk2OfFdtb5DgBp8d4zc5jZ6FFJqAwFF4iLztjYVvdLDXHGpnl8X+8EIvU0E6Tk76iv4jVb202YLB0jzsOo9CU/QKy5PAgq3tsSGVqU2Wz/OIaDsAh39yxU+Bmvrad6aemoN+dvbrxA6sUGRWxHIoBmTBIeF6dTvMQhpoOriQ0c+rEd0IBz4LH3/KMOgaZbzO9lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oSUux6/54go8UABCZxIEZeLRzksdaTnN8Sc75jvVj1A=; b=uBraj4cP9kK2MaDiHUFJp1GkX/XYKiDjh/cyZjuP3feQ1tN6MFX1nIZKhlHDJKtIYczve83FEgDNGcg6XtrvreeQlfYZeZImagiwf+1OZ9H1/FgAaKL8QEzqbWbKn6gut04Nb5yHI9/2qNl06DzTqWAtygPbYAvuf3TMgHbM9cRRs5lpF8n9S/VHO1IBJnL4wn9tNbNC1qBIngcwz6xZV26HDiV7jguMFCd3RkmUKm57w94oBGYlX8VvdiXVItZBZYl7M3/HE3khNrmAdm/E4MGU3e4dXcY4T2So3EhC5fd562r1czZ/aM9vdF1izT6cQBRj5auFzOXqQQLx4BtrUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6d281c88-83a0-ee86-18b3-6c9d856a0971@suse.com> Date: Thu, 9 Feb 2023 09:44:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] build: Make FILE symbol paths consistent Content-Language: en-US To: Ross Lagerwall , Anthony PERARD Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230208172416.725028-1-ross.lagerwall@citrix.com> From: Jan Beulich In-Reply-To: <20230208172416.725028-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7338:EE_ X-MS-Office365-Filtering-Correlation-Id: 0126931b-0f2d-4c6d-0e4a-08db0a79cb8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xjDhGUGgAAAs543AEk/v/jz0SjsvEKyk6f+xEurXJ+4PRnPfLSc4f+Lmsr/7bAK5qUUggwyl5tXqXQR7za6nkt2UZWuNDcC6CCZFOd601ZaaFq4dB/NaojZua3cItgfow+rKM+B0OUNW6ogaVZjCsGA4WrnefUrt4eT/eb02iiLKkwH4H9MxaF58J2X9WsJik4/hoOohUX+2bONr66/lBlP8WaPeSizOrgabVikzTGVpIy40vsP2cvPl8mqnCBU2eTxkKUIHsUUlpFvLoQMqz28vMsYfpL9Jr/y4SP1E/O3s4gKBYHRzJTuFlRvjyXJxiSARTJJKELKZgwOX5sjK3g6YKNaGZZVuunOLAAjfeCTrL88z0KcPwT0ty119z0OdXqu9vYwkEkdQ267m/qN7VDHJjp76MVag5thBcON2lCJpyH2X60oKhWe8lf0K7Cf91etueYKe6JWwX4u/cCyr/it88geVSVbqCHuknxH4N69eh80IVLX9vilsoMFBPe7BQvrzpL8I+UqQzE86dZIZfmLSNaK5rdktb025snOlFQmyDD82FSa9D+Nk780KHcZ35v6MpCF4kOS0MtuPosPgje27ZkcrptrIBi9Y77kL5zKe1yIIlFCEwgoCv3S39dcQ45Ob35VgDvqf96RE6RgH9rc9w50/aU+OUxbAicAeVFg+m1pzVG18+qIZ36S2fv/LdBx4Vk7W4nCim/RtlDj176hLZos+tdyX5eBDZk/a1Ws= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199018)(2906002)(53546011)(36756003)(2616005)(38100700002)(66556008)(110136005)(66476007)(66946007)(54906003)(316002)(5660300002)(8676002)(41300700001)(4326008)(8936002)(186003)(26005)(6512007)(6506007)(6486002)(31696002)(478600001)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXplWjBrWVNNRGIvUGIySGFMbjM5UFdaeEp3UDBOd2xBVHd3Q1QxZ0JIODJr?= =?utf-8?B?bFBOdjVKK1hSVGJqTFdsaG1QNEJRUi9pRytUYXpRaE1jK1hoeUV2UUhYN2dh?= =?utf-8?B?UG9zdExRQnRoVC9yOS9YSEkyeGRHQ1V3MVp0bDlvcW1oNVlNZFhTWlV2N1Zi?= =?utf-8?B?S1ZJZkZiZ2VSSHJPekRnQmFzeC9TdU56NVd6ZHhIRVdScnVOVjRyZUFHSlFB?= =?utf-8?B?WTRoR1hGR0Jjb1RSa3NzalkrRit1cXZRM0QweEJpV043NzNlN25KYWd0NTFz?= =?utf-8?B?b2I0NUl5cWRTWXowZXFlZEsvRlAyVnliMzdjS2MzVGdSSStKWEJzYUhhRXJ4?= =?utf-8?B?YVV4ZW91U2pPZVhiSlh2c1NNNUlqbktiSDFrNGU0TmpwdG52dGc2eXJONGtw?= =?utf-8?B?Zkx4YjZnNHpBQ2ZDTUxqdFBBdmV2c3JNUE5mTjhFcDRlMDdDSW1GT0cxNklT?= =?utf-8?B?MlkxSXBIUE5pVEdlVnRjK3pENnQ4ZU42MHVRM0JRNUFmMlk4NWtmdndHR01N?= =?utf-8?B?YVA2VDRyNTlPbmVJUms2YVo4S3Y3THFrejRUeEJOQjlVLzBhellwdXBEOUM2?= =?utf-8?B?WDltcDNmeEYvYi9lTXVQeDBVN1k0Wml0YjdaK2hQMVpNZS8yT3p3VU5UQll1?= =?utf-8?B?Zm40NTlLWG83R1hYZFUwbDFIRjZNNEpURmpkMk4zTm95UTAwVDkxS2tyNXdT?= =?utf-8?B?b2JoNGlIYlpCeEh0ZzBoR2xwNjM0ZjNsQmtUM0w5djFkQXlIOEZiYUpvakU2?= =?utf-8?B?bjV3eTQ0ZEF3cHk1c1NqYjNhMEJ5UW12Q1FtanRqV0tKQ1doWC9JbjQvelVE?= =?utf-8?B?bmpCNURBSytOdXBYY3ZwQjBmKzd6MDJ2dEZDeGFQSnhnbXplLzZwSzVMMkFI?= =?utf-8?B?SUdMamNIZWd5azJaY3E0NXBpZWQ5SUNseDlyd0hYM2htUW5tZk5OdnEzQmN0?= =?utf-8?B?RTZSMnBNUXZ6YUtGMFU1azNjOFBVYmpmRzQzNVNGaklybkVNNU1IRFFTSzA2?= =?utf-8?B?MVNrUzhMNU53ek14eVFrZm5JOWVaakM5ekFiT2M4VkJSVlowQkFIUUhLQ2o5?= =?utf-8?B?QzlYd1VWNmJxS1Vud3NqWHdVODl4VStSTTFsZUpoYTk4cGYxTWtOazljc2lW?= =?utf-8?B?ZlFEamtvRThBZmJueXI5WllrSlhOcFI2czJITGdHL2hOeVFqVlluRlR3Z3BU?= =?utf-8?B?VWZESEZ0OWNYVzhSV3VXR2lzanBDY2JBUVNqbWZmTXc3MldSZjcxU2d5d0VR?= =?utf-8?B?b2RMNWdKVk5wODZsNU40cVdrQkhzZGFIQTNJMGFGVElReWlWQ3U3eE1JQXBF?= =?utf-8?B?M0ZWc3JQQVk2TytpSHAzclMzQmtFaVplQ2ZhNkpnNlZRM0pRMXFZMC9UWDJi?= =?utf-8?B?QXdZK3UxdTRhVUNwclUxWjVoN2VBcTduY25GSkdiTXNJVUlsSVc0c0M1WkpS?= =?utf-8?B?OXBocjZLQi82cVE1R25VUUMzTUZZTEs1T2dOWVpFalJCblNiVTlGcjlsK3VE?= =?utf-8?B?Wm1hL0NUNm5rWHZuVUV1elBHbFFpVlk5WGw3cnA5aDBGajNQSnFyS0lTcWxs?= =?utf-8?B?eE5SdGpYNjNGWk40akIyNXRxNGFTMnpPcExyR1JvR1JCa3dGYUFidHR2SEYr?= =?utf-8?B?NWVYSUtQRm1rY3JkeE14VU4vbCtYOHU0Z1V4OEpTdGoyeWhvN1VQcEh3ajRX?= =?utf-8?B?dXZJUkhGbk93cjAxNHkyeEkxS0p2ZTNnRC9zeGkrQTlmcTlZelJrVWlISDgv?= =?utf-8?B?SUg0TWZWM1NadDdwc1BPZ3JpMk04MjVZNGkvOTZyWDhmR3BiY0RhajlpazJG?= =?utf-8?B?eW9kd2tIaklOYTNaRlNsdkVaY0RUcTlrcmx2VEFVK0Frd3JzTkZLckd5QWpm?= =?utf-8?B?aStyWUlHMDRzWVh4aGYyQm1EOUMyT0pvWm10Q0cvTk4zSyt2WmhVYkowNVNl?= =?utf-8?B?ZFhqL3NSM2xpaTBjVWVBOURvZ1YzS0twVHY3QlA1eFhOTVRpdGdybEtoZlpi?= =?utf-8?B?YSt1TTBQamN5S3JnM1lGUFZPa2RCWmttbm9xYjAzaFl2NElwckVPWkpSeFFm?= =?utf-8?B?RWJaZzZwN1VMc25iV3VHNFV0QWo5WWJKN25STUhod1hGMjNDNVM1RWYzeHNu?= =?utf-8?Q?a9oFDzSoqMQCsP0cxjOpuRmEb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0126931b-0f2d-4c6d-0e4a-08db0a79cb8b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 08:44:02.7140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NoeS1E3UtxKv+OHWaXWm6ekK5wkoRihGnG6GKe9zazrYB8rTiLcBJ/2JqiHZpQkTH0agRpj7lt0+DbIFM6fXAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7338 On 08.02.2023 18:24, Ross Lagerwall wrote: > The FILE symbols in out-of-tree builds may be either a relative path to > the object dir or an absolute path depending on how the build is > invoked. Fix the paths for C files so that they are consistent with > in-tree builds - the path is relative to the "xen" directory (e.g. > common/irq.c). > > This fixes livepatch builds when the original Xen build was out-of-tree > since livepatch-build always does in-tree builds. Sounds all plausible, except that I was under the impression that as of 035ab75d8e37 ("build: fix enforce unique symbols for recent clang version") things were consistent already. To clarify - Anthony, was this aspect simply not considered at the time? What would help here is a Fixes: tag, both for the purpose of review and for the purpose of deciding whether to backport. It might be that 7a3bcd2babcc ("build: build everything from the root dir, use obj=$subdir") is to blame, but I'm not really sure. > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -228,8 +228,9 @@ quiet_cmd_cc_o_c = CC $@ > ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) > cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@ > ifneq ($(CONFIG_CC_IS_CLANG)$(call clang-ifversion,-lt,600,y),yy) You're altering only logic for pre-6.0.0 Clang, aiui. This is something that's absolutely necessary to state the latest in the description, but perhaps already in the subject. Among other things that's also an aspect when it comes to considering whether to backport. > + rel_path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1))) Personally I'm against use of underscores when dashes would do, and using a dash here would also be consistent with e.g. ... > cmd_objcopy_fix_sym = \ > - $(OBJCOPY) --redefine-sym $( + $(OBJCOPY) --redefine-sym $( else > cmd_objcopy_fix_sym = mv -f $(dot-target).tmp $@ > endif ... the several visible uses of $(dot-target) here. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 08:47:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 08:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492247.761693 (Exim 4.92) (envelope-from ) id 1pQ2a7-0001zP-TV; Thu, 09 Feb 2023 08:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492247.761693; Thu, 09 Feb 2023 08:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2a7-0001zI-QO; Thu, 09 Feb 2023 08:47:03 +0000 Received: by outflank-mailman (input) for mailman id 492247; Thu, 09 Feb 2023 08:47:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2a6-0001zC-6W for xen-devel@lists.xen.org; Thu, 09 Feb 2023 08:47:02 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe12::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50e38231-a856-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 09:47:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9390.eurprd04.prod.outlook.com (2603:10a6:102:2a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 9 Feb 2023 08:46:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 08:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50e38231-a856-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIROl3lBXgzQXOB2QTBsgAteOzTqqPgeI3JKfwFdaG7nSe7q+4r83QKMXXCes3mYDypfHApunULfC3VCUaS3Sip/F5Uji+S5sGsyy3nsQU+6O56BaxcR7XVJHzriMlFgEHoDtu5Qg+XDhpdJUj73RXIBh+xdYsLs/1Nb6pfefuhHvTF+KW6hKfJiE24J3oMFBCBySPDT7dCzG+VFx13ad+5lJKYoM7T6rBqDFrwUKQmgyjzXD9p5/YLD0+7lCByoBwbwoPTr+tbBS3IBPT5Zs1EottM1dc9g1Z4JTsF7qZGOUSuJRPbGlC8XvnLAGwRb6yB9arWK75PHlb8S4JhSkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMwvSSS0gF+lZ/JTBQIWgHHwuL56XGrlMC/d6GqnOD4=; b=AVyGEYpWavzKzfnBFZiTGCH7PVRYtivy2NeXN9sIrqGhzzKk8aOxPJKUP1naggyLRT+97tkjb+Mt4IGQR77fEbuHigWKA/BGJajI0Z5rHiNWDQP9TVju2TSPsCTBJamnvbrsZNRwIzCUcS6+ObVmXxx9QHtJnF5dk4KUqTTRx2MuPgvjbdUahzjWg2ffoYQS/R/MQBBALBVxfolZxBZclp3GftpAtMOixkIFH76zjKym9BH9DrOZx65s2+9QwjzATVZ1A41ztTVWV2hZgJbWXcKzUs7Jl8lhsJ5H39hSUFchLAfF33IXOQ8pXYg+yBgID7n2aHrECknanjbr/1HuNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pMwvSSS0gF+lZ/JTBQIWgHHwuL56XGrlMC/d6GqnOD4=; b=XeRvhA6gg5QOq9KdLTsBdUWUQv7HbKqGaKySMC+YTI9xwP0S9nG7k2Yjc3H1H74Sy0XjCVY4lA3oQnChupXCBef2yu6YGQPIYSQfRA/zXDw9BxmR5BiqQIrx2Cw0jot4rjLWxsELi5+VX546BaEXCtsGQcjlTuLaEUpSgCdTO+G5txmKurfqBP1/PU3b0+LKkAjVfax44zNwuLJBLntkUlhpzrCYUykekE7h+bx3FffPUSSTUbPfsuIa0ve3siE2lhSgR90OqabaAShSy52XfGulvOssHG6+7OKZeuZToRjpXSxXnNtG03auO3mkrMpIHpMIo5jEsSJVif5/o5PGRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 09:46:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] create-diff-object: Handle missing secsym for debug sections Content-Language: en-US To: Ross Lagerwall Cc: Konrad Rzeszutek Wilk , Andrew Cooper , sergey.dyasli@citrix.com, xen-devel@lists.xen.org References: <20230208180457.800671-1-ross.lagerwall@citrix.com> From: Jan Beulich In-Reply-To: <20230208180457.800671-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9390:EE_ X-MS-Office365-Filtering-Correlation-Id: e18371bb-9021-400a-20c0-08db0a7a3460 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nLqkRBA4CpDgwHS6aTWj7amyXYsu/Myhrzv36yx4R4nLNrePKfhUHAYE23ymsHG56f1dmVGxuLaN3c9iAbkS34EBCYjBiY87hCfDVT7S/pdWjVU7U0+srTzKKXP7KuhLuISBkSBF1XPaHlZKLo8MbMzXzZS2kaENNtSg6nJIFzow+xNIh4uWPNUGgv5ISy94gBJ+bdmJb4wYvUYblWC64Rky0OS0xsT/zXahBao9AgnFKEmf9c/yH5dVcjhYpmIHkcA2e6RZB3ZgnC5W23Rpy9kRF6ukK+NvQqw+0iS4kTrswdA6/5E38sZsNvRATvnAJuTc5s55hhvsQC9upg5gbaWuC63S62229ezl0kSNx564ryQ1iHS0TVCqPn8XLc1Tfic6VmFhS/Xdfp7HXEQwzRC2wAVIWY/I/HFaLwljdq0GR3J/mY6jI41hfdgkBveF1zvD5Z5SbTRkfhRIO/Du4WFjLMXH24k6DWp+Yiw1ee+wp+66FMQMPtBAJUcA3ZRtcjsSRUEsAmBTzsDBLGibM0+HcfZBZgD7n51nPpGqDOkOHr+2GctX3wlfWVn6INjzqm62Kba3Z+ZqteVWzAl5fHYa9+Lh2GZODr7uM7/8EWbspXn27RNrfElTRZySjUGsM1C//ix7a7pbioUDPRzR6kex/+DHKBNiEHKQ4D04nxJaau3zY2dPDEs/JAplQpkT8AqMwGxANxfQPeUe69bAUaZ4IPxN4gFa25wD7KEoeWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199018)(2906002)(31696002)(5660300002)(38100700002)(31686004)(36756003)(6486002)(2616005)(86362001)(53546011)(478600001)(6506007)(26005)(6512007)(6916009)(66476007)(8676002)(66556008)(66946007)(316002)(8936002)(41300700001)(4326008)(186003)(558084003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2srNWVMWVFWMEMwKytrUjkvTTNOa3hIRHhmSUJYdmZ1U2l4aUhIRkVOSGlV?= =?utf-8?B?bFE1VkhhekJZVmpDZzZVQnJuemlIZDZFbnZIYWZVZmJhVG1uZGo5UHZmbEpq?= =?utf-8?B?RGtqeDlTS21ZaVlGQldxK201YitEMkZGZmhlYmJUYUxGbXFQK3BibVg0RVpQ?= =?utf-8?B?dUpha0NtQnVJUGJCUGFBYnRDaXQyaExzbUJQU0tFWFVsRmFyeDJpVkh3blM3?= =?utf-8?B?NUU5bE1VWWJjM01wejF3SVRJdDdJbnV3M0FyYkhEUHU3MTdZaTN3RmdYOTV2?= =?utf-8?B?aE1seFpNNG9ackdWOTN1TzVRazU0VjFTQ0Q2SXJXTlVLZjJpZkRBeFovSXNP?= =?utf-8?B?ZHJIZ0FWZkQwZUs2d3ZNbkdTREl1bmVWY3RyTFUwVHo3NDZVRWRoY2s5NTVS?= =?utf-8?B?ckZGanp2UjAyYVNNVDFuR2hZWUtXVkhPRmlQSmJqbDQzMnB3L25vYTRMbVIv?= =?utf-8?B?Nnk4ZGs2QTRVM1dQN0U0bE9TcUFwcFd3cTlINThrUEhIcS9jQXJKcmlIUHJC?= =?utf-8?B?TGxZTHRrK3F3UWpadmdZT2NVMDZiQ2hnN21pemxqTXA1ZUFDWW5UTE9LdjJy?= =?utf-8?B?Z3JqMU9oZVRHRVlmWUc4UXJnb0FjWVF3dEdjWC8zK3kvWlFwRHJuZzhmUGFC?= =?utf-8?B?ZkJoV1NETEtNVDdvOHhJLyt2T3ZBUE5hcHVUNWF4K0xZVjRZUkREVWxrL2VG?= =?utf-8?B?OHcrTUkxWi9lNUJFVFFnUGRCQ0xRckhiRTJtMzlHS3hlMW9kUzBldXA1VVhM?= =?utf-8?B?MDFTOFNWeW41WGowQXRzM3VGNFBGVVp6L1h5RnJBb3gyYS96L3VKcGdNcWxJ?= =?utf-8?B?Rm1GZzVINCtHSURRZzU2bXl1Q1YvVjFWLzMvTERha3Q0eVI4NUhHSTJYYjJN?= =?utf-8?B?YU9vNm5wWHRBT2N5TXI5QXdOUFh3RitnVGdoRFl3SEdxa0pvbDlFamxGcllS?= =?utf-8?B?bTF6OGY0YTJNQ2hjQ0YxZVQ4S2d0Umg1U2l5SERTSEhTUEJBcFZ5UGl6aWlQ?= =?utf-8?B?Z3dzcVZyR21YMVhCTTEzTkNBMjBiZ0UrR0hVeEtDNXFOMmZtR1U0WHhzSmVQ?= =?utf-8?B?TVljdWZPZ0FUbzFzZklpSHllSTVnWmRxZzRYcTAyVGE1MlUremcyV3o0MU5J?= =?utf-8?B?NjAxWFp4YWtPMnpYaWxMNkI0RitEZ3UwQkZ6UkFQVEltWWpmY0pHUUlpa1o0?= =?utf-8?B?eHlyTTdGcjl5N284YXhWc3pLYnllQWZmS1dISDZlVWQ1TjE3VlRRY0lNQWp5?= =?utf-8?B?ZTBwb2xtVFhoNnRWNENuenc0SFdhdm1yZzBKYW1heHFKZzc3SkFwN1dYZDJT?= =?utf-8?B?TDdqMGdFejB2Smx0SlBGUy90TCtFZzZuc1M5dGJOUEtVcnd3OG44L09NZDB6?= =?utf-8?B?NE1QOXJ5bEZKTUlXeXlpWW9MN3FzbjlKNEhPTHdkelBmaHhwTlZQRmNtempq?= =?utf-8?B?TWcwWnplSkhqd2FCa0E2KzZHRVFDSTE3WHFhTmh2K0V6bE9vQXdRNmVXaTFS?= =?utf-8?B?cm1kUTU3MXlMRVhQV1lqM2t1QlJtMDBxVEpRVG9UZWxnMjZPZHptc056eGxl?= =?utf-8?B?WkVBV2N1OVJBTEZ2eUwyMTFuYVBWcFVQR0tFOXpINkx3TFo1Q2NjaWVqUzJP?= =?utf-8?B?STdCd1NrUlNsUkJTUGZoS3krc2VuV21uZ245OXpvUXRjcVRhSnQrNGpGeVQ0?= =?utf-8?B?U3c1NlhJSTdDUE1XTGEvZXhndG44b1R2dHBvNmZlZ3c1WHNWQUE2ME5rUVk3?= =?utf-8?B?R0k3MHlMNDVKc21ESkxvMUkvUnJQWUFEUWsrREVpbURta2Yra293ZHVNUG5z?= =?utf-8?B?OGVJbTQ3Zlk2WmFMaldqQ01wTzVDNUd5SENIMG5ndHJmZnRHTGhrMVlzZm5O?= =?utf-8?B?cEJWeHliNEgzQ2w5RXFncUU5L3lreFQrc0FQeVNscWxLZnJFTzIreVdjaTQv?= =?utf-8?B?dmxwK1dkQlh5NklmQUZVeTBBQ3pUc1ptT1l1NG5RczJhT2d5bGtSd1BDRnZU?= =?utf-8?B?TWpHdWpna1IrdHNsa0lKaE9XWTl6NXUxeXZYazZnZlhWMVd4SkhKQ1IwSDRi?= =?utf-8?B?akNpOE1aQmI0M2FTTTVQZFg2VWhqY3FNL2IwM0ZmTFRuRW10WFl6LzZ4b2JO?= =?utf-8?Q?tjR2Yo7kP4dkeWPU3gxloKjAB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e18371bb-9021-400a-20c0-08db0a7a3460 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 08:46:58.6403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PC33GGiSzmbD/B2UYEv8Pp9H0YBCOwbxey31dEa8iibPTOIGJO0CHBddK/8UCRiSwPmC96a+aV2dYh/sxIcayg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9390 On 08.02.2023 19:04, Ross Lagerwall wrote: > Certain debug sections like ".debug_aranges" when built with GCC 11.2.1 > are missing section symbols (presumably because they're not needed). Is it really gcc (not gas) which controls whether section symbols are emitted for a particular section? Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 09:09:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 09:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492253.761705 (Exim 4.92) (envelope-from ) id 1pQ2vc-0004p7-MY; Thu, 09 Feb 2023 09:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492253.761705; Thu, 09 Feb 2023 09:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2vc-0004p0-Jn; Thu, 09 Feb 2023 09:09:16 +0000 Received: by outflank-mailman (input) for mailman id 492253; Thu, 09 Feb 2023 09:09:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ2va-0004ou-Jf for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 09:09:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0601.outbound.protection.outlook.com [2a01:111:f400:fe0c::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6aa8ad96-a859-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 10:09:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8762.eurprd04.prod.outlook.com (2603:10a6:20b:409::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 09:09:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 09:09:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aa8ad96-a859-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jlpy2UW0V74PEDUcEVggCZsmGr1o7YipxAiWWluV4ahsV5GzD9BrkrJ55PSULgxmuH20N4E5hbAGv6k7S1x0dKcJJpEB6FcG135xwt8s1g3FP4DsCk73/eDirp9qZjFyYu0PxLy4YG8k6plbaeE/WV5bR1aPxb5FDHzMUIdJFpf+zsyBnCF7B3bJk5LxV+joDSGSnH23V08Wk4npQxNOrv5Hyju4ZT7SlXHDYDpUkyvmmKbdmWgzCkk4AzquWjNFxdNMChkHqXuyUW49RtXt4Oxr+qwGjP72mX9i5RGru9fPvLeKfFkLWTCxtPUVdGsyccfGNvD4zmN9SHo+KhZO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYYg6cPBjseN5jLs9fYWcCE6w8K3jMwizwZEyylffCk=; b=dSK4Siz12Nb7lqKEe3VyZbHgvsW58vyXWe13hdif0Zf8guyNAruUYjVebT5Gka12Z4oqhjRq/SxAMqsxwAqFc3GOX5VK133In7LEbdlnB+UpY4T9wXt8MZ214nZhRNOK5MoIhyZB3pzh+YWWHxDsSSJFykED3ZCmZSQ+T6pfdOqKW2gGN6UIubuuFavFROc4JVSUBfD0EGRmh3Trm3i5V4OHxpM1MS4mtXnY/tI4YEfrTJXzz+xU/pcd70inhjmR7TpUkhsgPJxj0m7NuRzyf0C1R1EVFRpGQbnswhqebx2skHHZNVJeNL7H6q5BT9+zrsfam1gi2Nv+EJmzr07cbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYYg6cPBjseN5jLs9fYWcCE6w8K3jMwizwZEyylffCk=; b=m1DsN5A5LP4zyuuDvzCWD2IqKuvFkyO9h87WTDgfWjBuLB496K6FHh28QNeWrBbZZuHBSWnQ6kwR9YtulBfsOILpux3+V2xknY7N3RUXYRqZ9lhM13FSyE4VvCfTHo74kP3MQqA8lfEV2rfdvm/KOh2EUpqVeaUzAP68/TV9fsHJIIWFLvzXjo1LwfU2oF4wTMjkkHPx1D5AB0aEVR+DN87cMlpRp0B30YKIL2ZnLBKBss9VjqRLiLiJHZtlg2eyUcMxppfNrXGuE2Oe3Q24dA98YV2M+WRutDDHtUJluRWaiy/vPstEz81q3nIvYg5kApmdSaFPd2aDEXDJSkwXkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 10:09:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 0/4] Stop using insecure transports Content-Language: en-US To: Demi Marie Obenour Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , Doug Goldstein , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Daniel De Graaf , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant , Elena Ufimtseva , Nick Rosbrook , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, Jun Nakajima , Kevin Tian , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8762:EE_ X-MS-Office365-Filtering-Correlation-Id: 60c6fd4a-8267-4a72-622e-08db0a7d4e17 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /EkvlEgglDGJied0vUEW8rSmxYhZpAt8Ls70Ym5lrqXgvWulA/3vvVQ6WDHKIjSLHkEzi7MRGdXX5dwjAf+AbbuHOjqwXUtEtTlPnvmnvNY2DNuYfoiPZlutPIvOyLMUDDoNtzJ1KnunIXyJdmCR4YQ5R7E/fWaU20WdP6S0A+Kr9Ok1M7lEkO6O3+kYbCpgT8HRVNY2+Z5eBZdYNMSBnjHx02xKMm+BT+H6OuAFls6qnlct4qp8m5nZKczRTozCpNi/PmIYfz/vRzWGnJEtGHT1J2b9E6/4kvdDq++k+4Oq+QVMpoQvJDTzw0oCNxI6OfRyaHB0KEdBS8rz+Jz4IN/+L5LoJXYadj6VERu+sMpnAM1qnC0+CgfGo9X8EScSPxnLOhvdvjpGSN+49xYJgsF0LH9+xuS7DIzPyR/Uollk7zfmd23/j87Opw3yR9h01yc1HQE8B/fP7He1mWkFJyewby3VIQnKoKTYslKTX1S+63J0aDHF20oPFoy4m9lAvpQaE3SlvbjWZ+q9dt2SOa8KO2Uc4QdgBpnHh+e5soo3Lwnqfp0NSnb7XTg0ODfmOTHIAj9TRRxMQ45R5KwDVJvbBuWgPADsJDTdgxwmR/yI0BitMk8dHOy1SmQ7WCkmloQ2ES4m5RqH5vEh17hyto0MfY7nByOktfd3Iiutllmc8xZey/lDkAg7CbUGB9g1I3otUBHGxAj1CZZEUYR0PLj9DKhbAXC1G/nWDXUfiLsRltvvEOgZfBKESL3ra2gbMychZYSDDTNxGYbzZ49WZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199018)(478600001)(54906003)(316002)(2906002)(7406005)(5660300002)(8936002)(86362001)(7416002)(26005)(31696002)(4744005)(41300700001)(66946007)(4326008)(66556008)(8676002)(6506007)(6916009)(53546011)(66476007)(6666004)(186003)(6512007)(38100700002)(36756003)(6486002)(966005)(31686004)(2616005)(45980500001)(43740500002)(376185003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T28zV3ZIZkVTaXU4NTRCSXdWdGZveXdNaEdVRWI3SGs0SDZFS0RUQks4d1Zl?= =?utf-8?B?a1puVHFmQ0QzeTVpeEl6bVVFTUhhd09IdjdzbUtNL2Y5VEo3b0g5d0wvRnV4?= =?utf-8?B?Um1UdmN5NktFWFkxUEJaK3dCUEpTckFBcHROc1Z0RjAwbjRMQ3Vaa0NiVTlw?= =?utf-8?B?WEdVN3BkVVRFZHh1Vkh2NDJpc1dxK3dBOWMrbUcyWEFQclg3SVFWNkVnNUJW?= =?utf-8?B?M1dJVXlsQ05BbTBQTDVUTEdCQTJBeGZLSHYwUnZWRjYramhPdGRmTm14ZGR5?= =?utf-8?B?Wko5ZmM3VjdTUFhyRm5BREQ5MnRHeTdmbjhvcVJYaDVaR3dsRFB2bk54ZmJW?= =?utf-8?B?RTF6S0ZQazZZNG9wS09sVEhjK1FlclRCOUM5clg0TjZZMVBtdWlGMzVaL2xX?= =?utf-8?B?emh5VUJ2ay9RNUlDT05jUkowVVU3RCt5ODgwaGFSYTZ3ekt2MndXTkFuZU8w?= =?utf-8?B?NkphTGpMOHl6Q3F2QUZtYllVTklOVE11WWxLUWFXYjlFY0N2UmFTaEo5UGp0?= =?utf-8?B?b2JVSlkxeGt2czFiMEdNdHNoU2p0eDJONDRzcFBMeWNkWjdVbHFYK05Cd2Q2?= =?utf-8?B?Rmx5LzU3ZnNseWpDb1AzQjhMUG5iS1ZYcWxOSXJUNVVrOHhnOGNJTDBOQ2hM?= =?utf-8?B?SXJ2ZGpvRHpoZ1BnUUYvZjBHejk3cnR4WlVTUkxubUUxSDJiTS9zbk9MSUlR?= =?utf-8?B?ZSt0L3d3UkFHRFFicHVpMVkraytmazZWSm14YjV4dXF0VS9Pck42Vmptck42?= =?utf-8?B?OFFVSU4rSEFxSDhVTWNzbjlaTWlJbm41TUZSNjB4enYyZnlnS3FMeDlkc3Ri?= =?utf-8?B?a2dLZmVVUWZ1bTdXdnAyUk5Wc3dwTHpVRGtYcmowSzVhVkN6OGJUb3RzY203?= =?utf-8?B?d3ZXUVhBM0pJMTVZQlgwUGlCcDZ3enZDMHpVUTFTcExZVlovV3JxWXFKbTRi?= =?utf-8?B?V3V0WjUvbXE5TWpPcDY5eWJrTDFCZUZYdldNVFpib3VVc21EZTJKb1RKOUFO?= =?utf-8?B?TXNVSnVnQUNiUWx4Z1REelNCVkRPWFdGSXBKMDlDYS8xZEsreVVabE9iM0tI?= =?utf-8?B?NHFqMDR3Ukd6STlmY0FPbkNoMEMwemdrb2Y5ck5EZkVnV3hXc1M4UC90VVFo?= =?utf-8?B?Q2g0aEphdHJLczl1Y1UrVzdTdFR4d2s2TEdmRmdqdlVrRjM5OFJZRXMrdmFV?= =?utf-8?B?WTl1UEJhK2N6TzZ2S0h5ZUZZN0F0dmRQU2tSQkpTaCtFbEVmdGVQZFVNNXhO?= =?utf-8?B?UjM3MUFHUTdZYXlkaExQUmtzOUh5NTA3OGJ4TTB6QW1zYVJJOFc5K3FQbDAr?= =?utf-8?B?ZlRDd2ZKWFlKakFoVTNTdThPQmtuUUdyUmpEWVBZNjZ0YTMrS0h6VnF6dGRp?= =?utf-8?B?ME9IT1VmKzM3K052UEZhSEI0NXV5ZGg0TndFbkZTYWhkSnJWL0M5SmVkNThG?= =?utf-8?B?ZzhPaE1xWmQwVTkvOU93bFlIU2lReTVycW5lM2xGZVU0SU15M1B3b0haWDU4?= =?utf-8?B?QS9qWm14TW90SVBzTXRpWDduU1pJWHJ0TE0rU3dTQUdwWG9lVVMvcUF3QXBt?= =?utf-8?B?SWpJcVo2S1BHM2Q4SDVpK0JqejVYNCtxbTBlV243VkczK3JuYXVvVFlhNGUw?= =?utf-8?B?Y1hVUEl5T1RVK2tKZS9XM3BOZVMxNm9PL3U4SDdNU3pucG94cnBRUUJVM3ZX?= =?utf-8?B?STQyY1psNnVxWENlYnJFQXRPZW5SS25tckVLVVUwUGVCdExKaDliVXEvOXBE?= =?utf-8?B?bm1iQmw2TUh2ZFBER1JHdm1wekJac0dVZDF0RW4yZ0NvajBPeXBUWjR0NHJ4?= =?utf-8?B?emh6NXhUQkVZMFF3MTVmdVJqV2hrMTRSQVAwVklHWk1wME0rbURUTnFTTFhM?= =?utf-8?B?cE8zQVQ1TW1JZ1JxRS9RLzNlSzl6Um8zdFZVbmVSbEpLcXJhQStHaUhlTG5O?= =?utf-8?B?YzBaOU50dVlyUThybXhYa09pcVNFaUZOZ1VYYXdORlBHaE9jQ2RDZVlkbEE4?= =?utf-8?B?ZVFYZEw4bEpxRmF0b3FlbnhCTldGMFBXQzZWeWd5MFlSemQzUzY3VEI4c0Yv?= =?utf-8?B?clZoTnBwVVVBaVc0VHUrUGVlODAvUmsydTJzb2RENmhnQUowcEJ2bE5zY1RR?= =?utf-8?Q?373yB6rcMj9btIdG2t0JZZNjQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60c6fd4a-8267-4a72-622e-08db0a7d4e17 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 09:09:10.2589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Es7gVGhEYjYxAyLNn/hoX0RhkaEuzVAL9IBddntUuKjelj4oOb2WDTEPROgZgx6z47eBkm3l/G0eZb57vT+Wxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8762 On 08.02.2023 21:58, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > Demi Marie Obenour (4): > Build system: Replace git:// and http:// with https:// > Automation and CI: Replace git:// and http:// with https:// > Miscellaneous and documentation: Only use TLS-protected transports > GPL License Boilerplate: Switch from HTTP to HTTPS Mind me asking what changed from v1? Neither here nor in the individual patches there's any information about that. Yet especially for the voluminous patches it would be quite relevant, to avoid reviewers needing to go through everything again that they may have checked already. Furthermore I'd like to ask that in submissions of new versions you drop recipients whose email addresses bounce. Like I did get bounces from Quan Xu's, I'd expect you did as well. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:02:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:02:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492260.761715 (Exim 4.92) (envelope-from ) id 1pQ3kp-0003LX-L1; Thu, 09 Feb 2023 10:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492260.761715; Thu, 09 Feb 2023 10:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ3kp-0003LQ-IE; Thu, 09 Feb 2023 10:02:11 +0000 Received: by outflank-mailman (input) for mailman id 492260; Thu, 09 Feb 2023 10:02:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ3ko-0003L4-8J for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:02:10 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf2594bd-a860-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 11:02:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8209.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 10:02:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:02:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf2594bd-a860-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGDCmiHPIBBTZrOwojCPZ3cDi4UjCQp9OxQ8avkQErOIvUWy1+vm/tW2P/1QOwqNEKECU1DArGVfmtdrLZC7QCRsorqNzgoidSVr0rpXLP1paOM9oTkHEvQyZ7PN9/iwDH4Dpd3Y+tqyxqVISOVZdrvhwInvo8G9KzoGsSY52Q4SNue11zLJnkoddvo3Ojn59/nbpdbuk/EIi1JPfncMyUTriRXxdWXkYBVyH4Q19HPZBz49P2xlaDQ+j4LKigDyvrxjFTVDHwMsYrwEN21hQzj1rbTCTE1+VGLsPh2R8ObCF39x2mLLUusjMY9ejNg4HNylVxKGh+vZEBUO1y9Ugw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xITieCvaNEutDuBjygYCGsMQHCOrX7cQXP2FUxCmTh0=; b=QsAZYM4/og/mBnUei0L394Mco7AsjVbiAlkv5jrWAFh2ZH1NeSd2J5QdVjIQHB7YnRH6rYxpeE4dNau9mblLSj4tucjtBpOuxOs977RmXx37lds6vmzhMMXUCEmsL2qBt5gnIX+gxLvTpIqkbch20qPd6CgIxAVxXJEh2PDT7Zo0LoZGatOPeZO5PZuJE4Hg4FjXlrEcyT32NkyTfoyR4I0otsFy9dyKOiYPrv+r6hzfKHWZJ4Zv6FZtflxstZZ56HRB3XvS7NBiEem8CpcpBzCGNUjbEVTzmcoiX2ZCDM93sQBg0kYyNf931YQnr7+S7OgyqwmGHPsGiiEqp8m/8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xITieCvaNEutDuBjygYCGsMQHCOrX7cQXP2FUxCmTh0=; b=IKnzQCtVIGKt34L0hZmboqDNcv6zx8KGZIjSEFdTXmscVm9IqI0lsGNjmaE/UIlqsl5uc/6y+bdPk+QrYeJjc1uoCRui3yupRS8K5fgMGszNlcQo/ZHFi2BtLcKjfhLDTpAUQ1urDJiPmQvTJiuolkkX3qf2OrcV3DQkOSXjtODPsBFj8OAfZS1JZePScuKbJIojmXHtERAg0LOCLfw2vquz8Up+o1zv4VwSwF41JbfoBolJWNS7/XpxpfO0GNZ/xJNCvFM8cLmibL09qYxg3pod/bpp5KlLxnY8YgGX4AmX0Ok5f+3wiCsi3G+FV5gAf5F4sJtJB4UDoD359Z8t5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15a27b40-54ab-6b7a-9702-f72cf870e6d1@suse.com> Date: Thu, 9 Feb 2023 11:02:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Bobby Eshleman , Alistair Francis , Connor Davis From: Jan Beulich Subject: [PATCH] riscv: add temporary riscv64_defconfig alias Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8209:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ce5f9d3-bd03-4f6e-e5c7-08db0a84b2a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JvLMYS4eNY4zuChrO4zMe/Awo9eJKfxYsOhu5+cjc10rMUyRj5kkX7CNox+YOxV8evajXSIxOP3wm9RlPLuikrpCW58yHQh6hFTHUWoR/iLqHZ1jJsseylej7/MTGK9dPb9kXufrYQAUJZWEa3q2o8OaOAm7AtBksUJCH66Qi75Ndx3LTpdF2XGhbSywBX9kMO17eFxhBQN8bkwxHxBQxBLtY0qcvuvupHs/qXGE/uRsI2KcpKhczINYv9XtmsCJ0S77ijfl3+7YDEjtfUbUyKVas33EIKFkJ6DpV1/jahgRqz2LnebV8UB/pmkAjdpgGpYP5261U+MIlF/wtfvOKlIIiY8O0UV8odP9lM8bSlVMUTdbEyaLiFCNPDdxUT4LYhRLWsDNy/GULryvGoW96ZfDOf4sWIvBvReLGzS5by7N413d0FC0KF7yEiqYIE5ScpRUjldttaZoS/z80eyh6bd6/8gWBrk99B9tALN88sXB1VR9+vwHy4ghsZazpOYCX6yV6V/XsccqADcPEh0MsuGBWYeFUrEeyIMDWLWyEKzT+akqfi2o827PZaJCT8l6GYzxgUN81XU4rfQ97yn/bI7G+lPhRLF/dxDzqn9uBpWGP700NOArF25Ex0B2sFTD1+aHMBtUihpDpcDG8i5O6FpQ7iZArIFSWvkEIUVmM992s6xCdATGHmTzD2P+rNzNojeM+Z08B4ZiJrrPgvCcSAawA3d9vxf6PXs6rq6jEeM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(136003)(39860400002)(346002)(451199018)(31686004)(2616005)(478600001)(54906003)(2906002)(316002)(6486002)(38100700002)(36756003)(66946007)(4326008)(66556008)(41300700001)(4744005)(6506007)(6916009)(8676002)(5660300002)(8936002)(26005)(31696002)(86362001)(6512007)(186003)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1d6Wkh3M1pseGoxUG1aaGsvVk1kWlMxQXFSdTJ2bXIvWmdzQ3Bmcm1GNjI2?= =?utf-8?B?SEE5dXZvZStKVlhkaEorb2hnNUs4MFJ0cTNmejdYL3BzSE52bzlFUWlMTEtY?= =?utf-8?B?YXB3dXpCL0VPaVRzWVo5a1VoL2NoZUJsMHhzZTVpV3FnTWxwVEU2YmNCRWxP?= =?utf-8?B?amtqTGNlVGx5YkxNSHg4dVFOVnE5d0lCZU9uaE1NSzhvRW5hSXJ0alZYbTB6?= =?utf-8?B?UUc2MHRJYU5zQi90SU9LVkp0QXNjby9QKytwbkNwSktSZFQ5cFZnRzZTMGFB?= =?utf-8?B?cngvcDVncDlicmVPUUVwNmZJNzZHOUkzZW9uMzdhMitOUDcvZklqV1plb0JL?= =?utf-8?B?TnpvSCtDajdPbHBqT25XZjlQK2FDaEJYQnYza21vMFNuZG9NWW9jTG1KM1Fp?= =?utf-8?B?UHlsR1ExYk9BVFVKVGNIS0J6QWhxRjF5YmtlcitzUUtHUUFwakVKVGlHYXFB?= =?utf-8?B?VVRDSUhIUVdnOUUyY0FES3JaelBpNHJFL2JGR0xIRjNtelhab2lOZXkxTnhv?= =?utf-8?B?bWs3TGtLbjQ0NEJJUFpWMzN5ZlJNTlhDaDlreEFYR2lOZlZsQ3l5eXU4dGRi?= =?utf-8?B?SVI5UHJ5c1UwTEh1VkNibkNRKyt0dVJjSThTbXZFSk5JNHN5Z0ZZdEh0Qmhi?= =?utf-8?B?SDFmaXFnQ1plMzlFT0dhaTQ0eW9qV0FDamxtTWJOY1IzK2pWMFFlYmd5QVFs?= =?utf-8?B?SVB1ZlVnUmRPcmZsaXR3RXMrQldLODJZdzJiNTRGdlZNSGxrSVFKOHZYWXlW?= =?utf-8?B?eDJEaW00WHZkQVpUMklzZVA4WndqWjVlNk0vZm9XOG9iRENlMHNXcHVUd0tu?= =?utf-8?B?TzNYb3hvNWw3ZGQwYW9hcDJWWWpTSXVhU2VMUDFPUGU0eVdnZ05OaTVnZTBo?= =?utf-8?B?ZktLSXl2cnVCeWE4UUJCcGkzSWVVMHc1NitWNzR4TjZiMFlHVG9XbVBLQW93?= =?utf-8?B?LzVpV1NTSFZKbUhoQVllaFFpc1VUWWNVRGpWempUaTJCM2F5YUZINXlpWGJS?= =?utf-8?B?S1poU1NRaDZRRGZjVVR4eE1iME9JS2RDVklsZFNFNHVCRVpiRmNMVk5zL3RH?= =?utf-8?B?Q3phN0xjaTZaaFdmR3ExbHJ3VnJJbFdDMnhXT2FJeThXMkx0THg3TklNYUI4?= =?utf-8?B?REpGWUx6M3loWVlZYmJObmtGUHg4b2FWN3plVFBvWjFzRWR6MC8vc2tkR00z?= =?utf-8?B?VzM0amM5RzhwZ0hrNGM3RWZpNVNLTG9GZjZBWFFiNmtOdStIRFZQZjlPN2Ix?= =?utf-8?B?UUYwVE5rbUx1QTV6Y0FScjZXOFdoWmtMbnFtREZtelBGN0tqNFo4N0Rkc3Ft?= =?utf-8?B?Vno5VmM4WVc2K0xZcHpGQk16SnlkNEpnbmx1WGhvSVFLcXhpZkFHVGphU2Ex?= =?utf-8?B?WjRRTEcxTm1iMVRjTVA1d3cvSUlOcDhkYVhhdzRQTkFvSi82T3hTNkwrdDNX?= =?utf-8?B?VlVjaVRzNjVzSlU4N0sxVVpCNmMrcW5TYzg2K2RtU3MrZEF3VCtLeFI2RU1I?= =?utf-8?B?UzhaU3N3VGcyV3ZNVUg4ajIyZTYwY1Vtd2lBVGtFb3NSVlpWUFNHYkhWSzZ2?= =?utf-8?B?U21DRlJMbXROZmxrNTRSZGhJaFByazlnQmN6eXc5T0ZKTDVCNFJYVFhVMEdI?= =?utf-8?B?UDh2dkRFakFwcVhqckVSUXE3cjhER1ZNdSthTFJWcFhUV05UWEVYZXkrZmdG?= =?utf-8?B?RWJhQlg1V29EeFNhbzc2cmRTa1NFSVJzTmtrOXJ2VkJDTEtYM3ZvdXRKQUZy?= =?utf-8?B?d0FuSmoraldaQndwekFhSk40Z1RDRjF3VWdZOWNJR0htNWNZZ2JiQW5PNGtm?= =?utf-8?B?Tk54eDZpVzBvaUtuelcxQWN5VzAwYWlpVGViMXZKRWFLS1h1WUVuZTNEcDBV?= =?utf-8?B?c05MWFpKaUwwYWpSOW5ubHR6ZEREUC94dVdubUxRTEJrNUY3RkhxMGhtbWU2?= =?utf-8?B?dktER3RyczVHcXJmem9taHFKZDBHdElaNExWc2FFMTgzc3l5MzRESzBTa0N1?= =?utf-8?B?MERFWGczVDdQNDE1QjE2YVVwR2J3aDVjb2ozejRhbWZLYi9pVHRtaHByeFd0?= =?utf-8?B?U0wwbGNuTEtCTjdYNmc3QXN0M3JWdHpXM3hLTUlQME9udDEzc0JtVTFWZk1a?= =?utf-8?Q?NP94sVQXAfpYhy/bpf3lQ5njz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce5f9d3-bd03-4f6e-e5c7-08db0a84b2a6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:02:05.4643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oe2p8+BLble0yVUp6hfnXYMSYRNq9tU6pY5Oxk9S4O32BRFDI7Nia5XVV0tBORXfOXkjJ8+UgFh5+fqpfL45hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8209 This is to allow building of Xen without going through a separate tiny64_defconfig build step, just like is possible for all other architectures. Eventually the symlink will want replacing by, presumably, an empty file just like other arches have. Signed-off-by: Jan Beulich --- xen/arch/riscv/configs/riscv64_defconfig | 1 + 1 file changed, 1 insertion(+) create mode 120000 xen/arch/riscv/configs/riscv64_defconfig diff --git a/xen/arch/riscv/configs/riscv64_defconfig b/xen/arch/riscv/configs/riscv64_defconfig new file mode 120000 index 000000000000..c3c97b4d109b --- /dev/null +++ b/xen/arch/riscv/configs/riscv64_defconfig @@ -0,0 +1 @@ +tiny64_defconfig \ No newline at end of file -- 2.37.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:36:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:36:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492268.761727 (Exim 4.92) (envelope-from ) id 1pQ4I4-0007Vf-C2; Thu, 09 Feb 2023 10:36:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492268.761727; Thu, 09 Feb 2023 10:36:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4I4-0007VY-8G; Thu, 09 Feb 2023 10:36:32 +0000 Received: by outflank-mailman (input) for mailman id 492268; Thu, 09 Feb 2023 10:36:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4I3-0007VS-65 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:36:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7d00::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a9e6ecf-a865-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 11:36:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6854.eurprd04.prod.outlook.com (2603:10a6:20b:10c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Thu, 9 Feb 2023 10:36:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:36:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a9e6ecf-a865-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kR87EaiBvlHqGitK3SET5VcV8cvRGFjbc+Yg3FJ4HkvQXrNfsVf396CBghpdJWgY1wlykuZszLqsAnl2fIZgPuQALzidMjlWxlztzoFGi8d93uxSVDFHtWkBLFEj91RHC9F2jBsOux+v/VdzADAcmbwV1RrtkDy3ifPTPPNk6E2/sOcVHMggy2oAi2yJmgAzO1trxiw7UDP/fjm9MWtGi/sUXkbNgs9WXOk2bXQLZ2Dq8YnOcdi5MoN/GF+A4qmXsGmVHgPxuPXYeOucdm8yqxqJV8WwbIJxm3+nSCc0yZfqe7n5veujt3QXWTfdadNXOYqeJhUZpoYa9nOKEJv2kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7nE5hHfn8VL/t8o9WHYe9LxU5J0yDdsSMk2IhuzELhU=; b=XypKgFJk5heMW+04JiG9b8jYxoUFR0ikkpF3XSbAaGU4PR+21FdCJoOw+c0CuVxrEunA2E8MdeDAAdrDsmq4TYYyizMitIiaCY/gcQqeKN5duySRZt4cjTEijPQXFQqnOE+Wdt9fi5iHSFuOcQ8JU0/w5/Byx2LFkzMpk8LK5zStTuLRvWG7XCDHvctgi+slbkvMh8E6Thy5VMNeQHH3+/iaa+9Oh0J5X35dsYDXpWTAhAefWGSfScfqsrLmVwnTLv/x4eWyuQ0CNVgE+Q4bkbUpE8XwDyywjDKRXq1gfn7eeqVjLbLifhuPIRsjmqT3KQCtKfgs5mSzuLZWQt/+vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7nE5hHfn8VL/t8o9WHYe9LxU5J0yDdsSMk2IhuzELhU=; b=DMC95tBoLzYcnAAgMk09zsDmD1kszgUt/5y8tX04ijD1CvxjOLwwiqKVHk67jTNIEVhrwWDZwNW5QEnp99fAsGii+hn/hsWbADc3/5RXQsRNquyW21bFqXZx5J+cJLkQ5IvOP10zbNjxoJxB9SMF8KgrlMDdTi5Y9Cr/0nBrXxK07HYuAi7QU0JOrBqaV+e5dYKp8X6+dglEql0c2d9DIrl14bhyL/1q6r9vcGbSrpCVyyKwm1N90dv2nErUCx/Is1vUrFnLRuIL/Fh68RjX6+8rO4cGZQI5DKe9tABwUkQSxsfpbux6ciAg7tTJ1Jguas99MpQPXBKIcapGHU/zAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Date: Thu, 9 Feb 2023 11:36:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Paul Durrant From: Jan Beulich Subject: [PATCH 0/6] fixed width type adjustments Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6854:EE_ X-MS-Office365-Filtering-Correlation-Id: 989bd08f-b0ca-408f-cc97-08db0a897e91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FgWNlg86mfigZehyYmRUZ50elWp1xzyyBj2a0msPrhp36J16mp+C5wcRHbYKXXyr3Zv9RnAt5tGM7J4BoYSWYNk9igvCAd3CjkWZy7qPhGFvT4sRFpZQFqnB44j5PUDET194RUP3TqsJKZrmztQM9WSfBx1sr87hGxp4yqTRJ6pj4cwM3I8WIFNYGsPyLvKw9Nbnup5FgcjGMfXwIRj7suy22t1g9+IL0C3vbSNnaiAsOTiiR76daN4sovfYvwh/WukBdQYnKE5WpLJUn+XoQz6OF6FeS5kXuwegNPas/+Mm6oYDerhhiRbi/r0a/gBfZkaz0/XdXrM6oqeK19j9UirByGukRGHGBN2Dm3d7lMLQiXSlPOGdmyHQshXVmUqsrfyTmoE1M66MhY8T7tC2n/48l+bKV4lCCNPvfk4YiTf+Ot2h0Fz7cfVFDFE4pdm9oVBAe97fwNQFKAi21sJeUX3y5ysHAbXLdojUqLeDdDNn4fGSGpmP8qG8jqZ3BX+Z5hfHiY+t8WHB4CPAuV/MGVEa+0Z0OCzl+j2iG9P5xEUk+hIq2NQAveDWSqBNrMRm4VKgjHPweBEyAoE+XIhpW/7lRRXdVUyg3y8sows0yfbv/JFaGQyo+m82rrfzJ+JsbFFfHeoJjY1+lVjeR8nwC/0yKUMx1pjFI9Xa8E6AkcD9OhVUnCdwjRUN97xQo7BtvioRz0TTSUmyQHT9goVq8Q4mZFqR3E3u0KO28qMGCU4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39850400004)(396003)(346002)(366004)(136003)(451199018)(38100700002)(86362001)(2616005)(31696002)(478600001)(316002)(6506007)(26005)(54906003)(6486002)(6512007)(186003)(4744005)(5660300002)(7416002)(2906002)(36756003)(6916009)(8676002)(4326008)(8936002)(66946007)(66476007)(41300700001)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFovSzNxeFkyV0MwRXB6emFDN09XL1YxQzNENm5VTXhtbGdodjkwMlFCV2Np?= =?utf-8?B?bWE1bWtCc1lua1hHa0M4WHRJbEpvQkVpbmZUZFFzUEs0NVViSm51SXg5WlpI?= =?utf-8?B?N2huRlViRUE1cXpOYUFqbUs5SUFLY2xuQm1HSEtqWUZiR3JQOFVkQ21rc2hE?= =?utf-8?B?cGNwbVRLcGVwajAyNHYxSXh1QmRMZ09JNlczeW1iV0xOZUpib3J2VzFCWVhK?= =?utf-8?B?Z1ZYWmhCU09EcHo0UHNQZkQ4M0tIdUhheEdjRUVDRmJscUU2V1J0RE9pNFcv?= =?utf-8?B?bnh0Z0EzSGYvRzZFSTVZYjJYWHZSNHVtQyt4R1VKVHU3SitPUnpETGw0c2Va?= =?utf-8?B?UFd5WmFQZnRFZWxQLzhibHdwVjZmNmNNTFMxZEZKNEZMWW03THM1V3R5RTdK?= =?utf-8?B?R0NEbTVCVXNUdWErZVNkd0V2Tm9wNXBBaVIvbDREaU8rcS9KVEpaWk5MYkxB?= =?utf-8?B?dGMyd2hvYXpXaS9lV1NNbndtaFZJS0xHbTVZeGs0N01FOHhnc09NWCt0eUgr?= =?utf-8?B?V1UzQnBOS3FPcVB4emhzOEpFc3c5ZjVkY2dZUHVaS3hNZ21KRllnQ1hYemdX?= =?utf-8?B?VWdEYWdRWlNFei9hODJxZ1BhTnRZbDRIdXdtam9qWG9FMnlOZlRaZDE4Q3hm?= =?utf-8?B?TjlxRnlRR1A3dW9nRDVBdExFb0FYd1ZkSmN6dDVOWmYrbWJkNEw5aVZWTTdW?= =?utf-8?B?eCtSWmJMbktGV2EwZDNWbTdPRzdBc1hyNFQyUUZET01KdTlZeFlkL2J5S3Nq?= =?utf-8?B?TWwzd2FKU2s3d0ZCb3BvZDYvcm14TUZCOUovck9rNkhubVdic1ZpRkZwNEMx?= =?utf-8?B?UFhRcFArT2NOWkw1L1RnQ3g3ZENra3B3MnlxN1pkSVcyNFJBS3B6azFiRStp?= =?utf-8?B?SUxHQmhFL1R4azAzeDVYSXBWTk9JeG5qM2Z2UDhjNjZaK3lSVk1vM1p2Znpk?= =?utf-8?B?d0hzVXgrUFozcnhWUnJvSDJXVEtEUVFqajhzdml1WWg2M0srUktnMjYwVlNu?= =?utf-8?B?OHdZUGN4VEJGNDQ4Y2hCMlYzLzVMRGg5MzV2bzlZNGNJcWhFbS9Pam1hUE1O?= =?utf-8?B?K3NvSUJmSDlDN2U1MlBVQnhaNVk3TWVHRFFEa3puV1dZQUlmRUE1MHFlQmNh?= =?utf-8?B?YVFiQnhiK2NkQ2lpTFl3d0QvNlQyQ3IwT090Vm1jRXI3NlI5ZXpMYVcvTW9E?= =?utf-8?B?QUJpRTFGcElOc1Z2NkVLakJVTnQxTzEzMms3TlAwRzlXc1ZLdW1CNUFsSmlk?= =?utf-8?B?SkYwRUJvRnJZaG8rOFNNU3BMWTdmZGIvVU96VjlCUzRPdXVvUWVqZ2h6SUdR?= =?utf-8?B?Zk1XdUt3akJIZ0FIa1ZoQkpxSjQwWlVoNnlORmdsOGpzUzJwdU9EcXFxN2lI?= =?utf-8?B?d1FVMnJhbFpTZXIxRnp2YW9GWlRVbzBMVXM1RDdmODVrY1ZsUW5MOHpIZkY4?= =?utf-8?B?UGM4eGFvRTUvZWJjbEtFakZ6T3lnUGR5U3BCRmptQXEwT0RkWGNlamtCZXZN?= =?utf-8?B?N2pjUlVnWGdneGhBTU90SXBXL1Zpd1RCNXpyUmpyVVJadVZwWG9hQVJHQWdS?= =?utf-8?B?MkFNOFlTMERrRVoxcXlockpST3gvTW5pRW82V0NXTTh2U3cvYjFaUjFmR3Ny?= =?utf-8?B?eTBLaDRPMURTczZES053ZEpDMzMyYnJFbFNVb01Qa0U1bjlYKzNDc3BRZmZS?= =?utf-8?B?bHhpd05nbFU3TUtybVpvWFpqb1p5NUhhVHpXL0c4MWsyMGZaeDZ0MmNjSU9m?= =?utf-8?B?M3JxSko5M3JLa2hyd3JNN2dZUStLaEVUTHNBZEVjaE1nSFlPT3pvL0JqQWNP?= =?utf-8?B?bjg4QWduWURRTjdDKysrL1dwdEs4SG9OMXozUndkNU52M3JrZVNIZGdXQXFQ?= =?utf-8?B?blBZd24vTlphQWNWWXF4U1ZsbllGeFJEbXhPN3BreTh3NUF0b0h6bGFVdnBh?= =?utf-8?B?dDViWmliaUovZzJwZDM2c3BkejgrSmM0VmFaMXRrVzFDcEpkK3ZzS00zdHhj?= =?utf-8?B?RjdJczVzY0thelR0TFFxYmRERm1GOW9yd01tSDFmbmtCYTZ6b1IrL3MwaWZS?= =?utf-8?B?R0JDRFBjdS9oNGRGa3FmYkcrNXZReGQrdHFkcmNaRDMwKzUyRTJmT2RWMHhT?= =?utf-8?Q?TJWMc03a8FL9ACc+xHG75ojto?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 989bd08f-b0ca-408f-cc97-08db0a897e91 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:36:25.6932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JOJMHC8XP9i/6I+aRIKBc88VfSwuu+y099yKfGwsjsUuGcWnztJ7nzOAPEJ84EXs8YcKE6PyKB6yjM3+8gkJig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6854 Most of this is merely tidying, with patch 2 being the real meat, but partly RFC (see there). 1: x86/Hyper-V: use standard C types in hyperv-tlfs.h 2: common: move standard C fixed width type declarations to common header 3: ACPI/CPER: use standard C types 4: x86/MSI: use standard C types in structures/unions 5: x86: use standard C types in struct cpuinfo_x86 6: common: __u8 is history Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:38:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:38:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492275.761737 (Exim 4.92) (envelope-from ) id 1pQ4Ji-00082Y-My; Thu, 09 Feb 2023 10:38:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492275.761737; Thu, 09 Feb 2023 10:38:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Ji-00082R-K6; Thu, 09 Feb 2023 10:38:14 +0000 Received: by outflank-mailman (input) for mailman id 492275; Thu, 09 Feb 2023 10:38:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Jh-00082J-CU for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:38:13 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060b.outbound.protection.outlook.com [2a01:111:f400:7eaf::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d798d6e0-a865-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 11:38:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 10:38:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:38:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d798d6e0-a865-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6S1Djz67JKipNyZQ647Hz0v+jdoj88sPhBvohNy3tf1eCvyDwffycUvxz/B7Xxx+g6jPV7SYLFAVBZTE7WYHVMuCu9oeXS+WBvYXZzV4wJAfmP04EHm5Jby8Zv4VrtQvIMhH0h0k2vRfcUWWGSQuS7CgVBOThe7vgjq8v4sR0NybSbowcnQpUUrajE4GD1NePoDwN0tLArN0oW2KJGQjeRl8w7CXJZY1GqnBTbXLCiqTsUIZV9WrXjCGdVsE5q7V/dHApUabowL9b/aDXiZk7Is7aaxcHSIH4vICNTPUwIkPHyHMZjk0AQQqGgQHFgR1usmMDBgWbql5P5t/ipdTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TG2Rx4pKN111MpETmzA9hKXV1FMjq3bxnugIAbeKEN4=; b=dNOITZcunT9z6jaWwa62dlIpr7owDZDbn0mGMGWbR+Do4NFtXPkOVsR2npkWiathcqi0wOtEwAjUcMuAzGU+VK7L5sXsG1LQUGVE0kiSQQRc75mQaxwUJOKraUKJ00EicfF8bEExl82hppt9HRLxHHFgoA+3sXe3hN2h1EXCnRxuMeK2ORNimndEWWHRQjBNWLVie1VwMNE/rbbfFQ6eslVDVO2U+tPwyXwAKQ5RTpcM87rGpeIH/3+GWXgIFUq5cM/JW3iuC2URTIEpJJH6rKhQbBM+ofVMdNA7vdZihxWYxjgYV/dLQQhy2swYJI2ixOvZlJgY5hPkPbb3ztNrDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TG2Rx4pKN111MpETmzA9hKXV1FMjq3bxnugIAbeKEN4=; b=YvCVOxoEzpfSivFWVCB9bb3g+kGgoIy4uj3Gpro25Aq3AlY6wUCM9le18oPM+u49meaJJyVPC2ZutaB7hIis3OBdNQiOFjPa/JFmXdt6FJWVCv1cXyT3LUT3If+0p4DmP1GXq+mPwjGlDKbO9RrmPr2SxSwRMOoH720lYnHT4NQMPSbGaGNdHurJ7U3mX8co2Pb8L2WeA/1gwnOYa2B6Ph8g1hkJzZraJeY6fQzDjTKw2UDXLEJfPrPMGcpQsyjW7uA4dHCafIc/BAksTOCL/IGjZNQPE/hH2um89wzLSrhvd1hV9EMZalvIFVpEPxuOA2ctD0z2Hby4gc7zsBEWhw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 11:38:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Wei Liu , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8630:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b6f00dc-9eda-437c-b596-08db0a89bb2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b58577ciHBqBlNs0MdWhltJcHodUsSwnvlGvnqUPqbVnYc5BRJtbHQE5rq2VscZ3i3ZNSZBttfWbWWGT6EtzAK9zdE/+y4o0bTc25kfvf0T3Sor03UsbsgMJXCrFs2zslfpNU1/KdsiKD+atI6q/n+0FHYz8DrtMzdkSudr6Y1PEtJq5/fe1D5jffyS/tBiF0a3pSiQMyxxx3mhjE9zXqewK4levC7zUsrRhyYyORCQssDguPGOn03BPm9FVji1cN1WeYKHbkxkNBZaDVc78z6FB/1qmGF3zs4NTGV6IJbThi0034favtqODtCUjw6cVWT1YJNJi5QklfraSogyLBBS/bLCnFPZHYklok1gdYZjn0SUXoi1P0OhF5YdIzUheViBKVIuSHB8dcNxV5HkNLVUmv9QPbwqaxxx3mwf+Ot2mszpfWdbWjHIMeIY0WOmtwaiKqBu6lbwjE3hPIgzFszponoG4A9+I9vnFEIlTOdF59b0NIo38oYheMybh0bD8udR9bV2iqVRo21fXR+PGwyBYhNmE7Qs5SsgQDRH5TGfTBBp+R84GS8trUceFERNwfoaUCKcCMJAiuyGf+zC9GXtod1DBi4d2idcijuZxCR2xuqfd1Q1y/007nS/MIkasnXaLSi+fh3Cz675HRmZkUbkNouNyVAlw8U/LxJtvqvlpkt7lWAVrKRpXqY3Yn7Q8kpXW+mqvRc4/n7R9XT5JU8mt8gBnqu7Sf52ZAVAPM1g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199018)(478600001)(6666004)(2616005)(5660300002)(6486002)(30864003)(8936002)(6512007)(186003)(26005)(31686004)(6506007)(54906003)(316002)(4326008)(8676002)(6916009)(66556008)(66946007)(41300700001)(83380400001)(66476007)(38100700002)(36756003)(31696002)(86362001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHBwazR6VVdnaXVEc3ZsSStFMHYzYkhrNUtBOFJiY3AzYmo0YU9uM29yd3pP?= =?utf-8?B?Q1lGVmYwZEYxcmRtcGZWRmJ3aTkvZUx0eVJzdFdXTG0rOWcrMmRPRER1VEpR?= =?utf-8?B?ZEdOWjdmS202YjV1U0VYbjJOenZhQWFacnk5eUZHbjdnYVhOclpualFROXAv?= =?utf-8?B?WmJkbmNuejdCeEtCeEFRVTNZU3ZTZ1JNV2JEamJ4UHlNUWg2V0IxazdGNy9Y?= =?utf-8?B?ZzlPbmJpNnlRWVRrOGJPQ3hVd2NnbTh4d1BodDdCZXRuNnh5NXAwaGVnUWhE?= =?utf-8?B?S3ZFekhkTnZYNG9ITXpTakY2UGVTQzExbk5KQnhSbVNjUnZPN2szMDdqRGp0?= =?utf-8?B?TjlmMEFLUlJ5NUdqdzR6K04wbkpFcHRueTByWURkNGVoSEIybFRLVmk4R3lV?= =?utf-8?B?SHhNVmFTeE5Relg3MVJUQ2RMOG5UekVreW9heEpuc0EzWEVsUkg5czk0QWIw?= =?utf-8?B?MTFBSHA5dkdsZG5qNnV3REZCUWdEYVlnS3J3S3Z2TnNBOEZoT21hZ0lZd0Zt?= =?utf-8?B?NmJhY3ZIaGF3cWxLSkQydkZJN2tLVmRsemdrOEhvZ0NRSURHdnIweGhwMmpq?= =?utf-8?B?aFBLbXZQYVFYNFVOR3MxOXBZMi9oRG43MnljWFVuSTA5RDJ0eTcyeWpyRXpG?= =?utf-8?B?TTZwZXBvOVcrYm9seGxSaENla0tuQUk1UVlPaGl4M0RhR1haUVBnR2RUb0Zv?= =?utf-8?B?YWVndEpVOWdCcGRUSDVpKzdTaWE3cGYvbVFnVGFlNTNyTVJIYjlTQWhORFRt?= =?utf-8?B?WVdUMEdXbU01YjRCUmJHTEh1UHEwN1NMcW5TS1pDdEZDeXJmTjFBMkxSdVBu?= =?utf-8?B?OThGMldRdEEwa1dFY1RRYWQ4dSt5MExsTW9BZDVFMkpQOEhxdFM1SnVTWTEz?= =?utf-8?B?WEd6cHYwdzB2UnZUWDdCZlQ5YVJKYmt0YUIvY0tUL2NTK05oVVRLb2dYaWpo?= =?utf-8?B?NkIrVkJidTZXUDBMNXhiWDJ1bVJIaVM3aVhEdTRuZ2VQRWRIUDZ5ZUdZUFR0?= =?utf-8?B?YkpONGFGbkwrT3VzUGJ2WjhaangycnM5bnAxV25nOVpIemFJTmtMMzYxcDJV?= =?utf-8?B?ZGk0aXFnSDZIWWJHYkllTE1HQ3FSc3NpTnMyL00zODl5Z09qQks4V28vTEJU?= =?utf-8?B?VVhaMGZjdWxGRGhoQjhteFVCNE5QMkRlRC9WblpObjUvMGJGenZTckViUG83?= =?utf-8?B?MU9QSFVLajFMSGc1TUlQcU81VEtzUFRrdlZjWHJOQmhxMm94WTBxQUdJYnVy?= =?utf-8?B?L3o1V0tpdjM1YlIwOFRtYksxT1huc2pFZjdiT0FkZ3B3SVNDeCtqZ1FmSXZ6?= =?utf-8?B?OGtkK1dxa1dNK1p3aDhlWkF2Mng4dnRDUTNVTTJwZ01oelhnNmN0Wkc3VTkz?= =?utf-8?B?clNVcW1ZbjJWNU95WmdvbXRBdUlaUERvN0J1eUdDeFcvRE1KZzVOYWpvbzFy?= =?utf-8?B?NGJDSEM4Mk5nWWdHNmpLaUVWRnJhU1lLV0E0M1NDdWY5TW5LU2JKazloK0ZF?= =?utf-8?B?aTVXZlVQU1JSWllTcDNsRVZmM00xZm95WDk0UlJlTFN5bEdTL1J0TVZFTEEy?= =?utf-8?B?dlNueHFINENWZFJhcWtTRzBqWFhHL0k5bnVoekVNaWk2dWVtTVMvb05RYVlj?= =?utf-8?B?S0M5cWZzUWhuUEplYjhmODgycUlXdXNBMHB3QTMyb0Y2S3puSEpFTThsYjRk?= =?utf-8?B?WXhBdkJVVXFNdzBCMkVoNWZpQ2ZFQWxLcXZEZ1RPaUhDWDlKeEIwL1BwUFRT?= =?utf-8?B?ZTl0eFlZZ2lzTWVVTk5mS2FEZ05yOVNscEFuN2ZQU1N0cnFLYVlOcWdlY045?= =?utf-8?B?OTMzeG9QZmRUTWJnRkVXTzVOUURhbUVkSEVseXExZkl5YlhMbHBNOWpSNXVa?= =?utf-8?B?Qy81VEpTYXlnVCtDc0lBdSs0SVVwNVBicmNUdU90d3FOMTQ4NHA1dXptQWhD?= =?utf-8?B?YkZIdnlUM2RzTytIdTBkMVZHRkl4V1A1cCsySDhjMUlUVGM5TE1NN3Z5RGNO?= =?utf-8?B?WFFFQjliWi9iUlViK1JTMkNMN3ROM1BscE9vRERrZXF4bFZZUmFLT0dYWUdH?= =?utf-8?B?UnM5Z3RQWnZYTXRUL1RrMndZRTE2UzN0NFRBTWtPRmJkLzRDK3YrZ2hPMHBx?= =?utf-8?Q?FXiAj3W3uGDN7ybubumRAvDme?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b6f00dc-9eda-437c-b596-08db0a89bb2a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:38:07.2180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EoFb+FYw6TDBL4WQfEqLe76TGwaFMv1NI0ayepXTh3D9duQf7TixbDC/fdX5gMFdn4XJCktM2gXi7wM7Lpryww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8630 This is the only file left with a use of an __s type coming from Linux. Since the file has been using an apparently random mix of all three classes of fixed-width types (__{s,u}, {s,u}, and {,u}int_t), consolidate this to use exclusively standard types. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/guest/hyperv-tlfs.h +++ b/xen/arch/x86/include/asm/guest/hyperv-tlfs.h @@ -283,11 +283,11 @@ * Declare the MSR used to setup pages used to communicate with the hypervisor. */ union hv_x64_msr_hypercall_contents { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 enable:1; - u64 reserved:11; - u64 guest_physical_address:52; + uint64_t enable:1; + uint64_t reserved:11; + uint64_t guest_physical_address:52; }; }; @@ -295,11 +295,11 @@ union hv_x64_msr_hypercall_contents { * TSC page layout. */ struct ms_hyperv_tsc_page { - volatile u32 tsc_sequence; - u32 reserved1; - volatile u64 tsc_scale; - volatile s64 tsc_offset; - u64 reserved2[509]; + volatile uint32_t tsc_sequence; + uint32_t reserved1; + volatile uint64_t tsc_scale; + volatile int64_t tsc_offset; + uint64_t reserved2[509]; }; /* @@ -343,21 +343,21 @@ union hv_guest_os_id }; struct hv_reenlightenment_control { - __u64 vector:8; - __u64 reserved1:8; - __u64 enabled:1; - __u64 reserved2:15; - __u64 target_vp:32; + uint64_t vector:8; + uint64_t reserved1:8; + uint64_t enabled:1; + uint64_t reserved2:15; + uint64_t target_vp:32; }; struct hv_tsc_emulation_control { - __u64 enabled:1; - __u64 reserved:63; + uint64_t enabled:1; + uint64_t reserved:63; }; struct hv_tsc_emulation_status { - __u64 inprogress:1; - __u64 reserved:63; + uint64_t inprogress:1; + uint64_t reserved:63; }; #define HV_X64_MSR_HYPERCALL_ENABLE 0x00000001 @@ -442,10 +442,10 @@ enum HV_GENERIC_SET_FORMAT { #define HV_CLOCK_HZ (NSEC_PER_SEC/100) typedef struct _HV_REFERENCE_TSC_PAGE { - __u32 tsc_sequence; - __u32 res1; - __u64 tsc_scale; - __s64 tsc_offset; + uint32_t tsc_sequence; + uint32_t res1; + uint64_t tsc_scale; + int64_t tsc_offset; } HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE; /* Define the number of synthetic interrupt sources. */ @@ -499,30 +499,30 @@ enum hv_message_type { /* Define synthetic interrupt controller message flags. */ union hv_message_flags { - __u8 asu8; + uint8_t asu8; struct { - __u8 msg_pending:1; - __u8 reserved:7; + uint8_t msg_pending:1; + uint8_t reserved:7; }; }; /* Define port identifier type. */ union hv_port_id { - __u32 asu32; + uint32_t asu32; struct { - __u32 id:24; - __u32 reserved:8; + uint32_t id:24; + uint32_t reserved:8; } u; }; /* Define synthetic interrupt controller message header. */ struct hv_message_header { - __u32 message_type; - __u8 payload_size; + uint32_t message_type; + uint8_t payload_size; union hv_message_flags message_flags; - __u8 reserved[2]; + uint8_t reserved[2]; union { - __u64 sender; + uint64_t sender; union hv_port_id port; }; }; @@ -531,7 +531,7 @@ struct hv_message_header { struct hv_message { struct hv_message_header header; union { - __u64 payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT]; + uint64_t payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT]; } u; }; @@ -542,19 +542,19 @@ struct hv_message_page { /* Define timer message payload structure. */ struct hv_timer_message_payload { - __u32 timer_index; - __u32 reserved; - __u64 expiration_time; /* When the timer expired */ - __u64 delivery_time; /* When the message was delivered */ + uint32_t timer_index; + uint32_t reserved; + uint64_t expiration_time; /* When the timer expired */ + uint64_t delivery_time; /* When the message was delivered */ }; struct hv_nested_enlightenments_control { struct { - __u32 directhypercall:1; - __u32 reserved:31; + uint32_t directhypercall:1; + uint32_t reserved:31; } features; struct { - __u32 reserved; + uint32_t reserved; } hypercallControls; }; @@ -571,199 +571,199 @@ union hv_vp_assist_page_msr /* Define virtual processor assist page structure. */ struct hv_vp_assist_page { - __u32 apic_assist; - __u32 reserved1; - __u64 vtl_control[3]; + uint32_t apic_assist; + uint32_t reserved1; + uint64_t vtl_control[3]; struct hv_nested_enlightenments_control nested_control; - __u8 enlighten_vmentry; - __u8 reserved2[7]; - __u64 current_nested_vmcs; + uint8_t enlighten_vmentry; + uint8_t reserved2[7]; + uint64_t current_nested_vmcs; }; struct hv_enlightened_vmcs { - u32 revision_id; - u32 abort; + uint32_t revision_id; + uint32_t abort; - u16 host_es_selector; - u16 host_cs_selector; - u16 host_ss_selector; - u16 host_ds_selector; - u16 host_fs_selector; - u16 host_gs_selector; - u16 host_tr_selector; - - u16 padding16_1; - - u64 host_ia32_pat; - u64 host_ia32_efer; - - u64 host_cr0; - u64 host_cr3; - u64 host_cr4; - - u64 host_ia32_sysenter_esp; - u64 host_ia32_sysenter_eip; - u64 host_rip; - u32 host_ia32_sysenter_cs; - - u32 pin_based_vm_exec_control; - u32 vm_exit_controls; - u32 secondary_vm_exec_control; - - u64 io_bitmap_a; - u64 io_bitmap_b; - u64 msr_bitmap; - - u16 guest_es_selector; - u16 guest_cs_selector; - u16 guest_ss_selector; - u16 guest_ds_selector; - u16 guest_fs_selector; - u16 guest_gs_selector; - u16 guest_ldtr_selector; - u16 guest_tr_selector; - - u32 guest_es_limit; - u32 guest_cs_limit; - u32 guest_ss_limit; - u32 guest_ds_limit; - u32 guest_fs_limit; - u32 guest_gs_limit; - u32 guest_ldtr_limit; - u32 guest_tr_limit; - u32 guest_gdtr_limit; - u32 guest_idtr_limit; - - u32 guest_es_ar_bytes; - u32 guest_cs_ar_bytes; - u32 guest_ss_ar_bytes; - u32 guest_ds_ar_bytes; - u32 guest_fs_ar_bytes; - u32 guest_gs_ar_bytes; - u32 guest_ldtr_ar_bytes; - u32 guest_tr_ar_bytes; - - u64 guest_es_base; - u64 guest_cs_base; - u64 guest_ss_base; - u64 guest_ds_base; - u64 guest_fs_base; - u64 guest_gs_base; - u64 guest_ldtr_base; - u64 guest_tr_base; - u64 guest_gdtr_base; - u64 guest_idtr_base; - - u64 padding64_1[3]; - - u64 vm_exit_msr_store_addr; - u64 vm_exit_msr_load_addr; - u64 vm_entry_msr_load_addr; - - u64 cr3_target_value0; - u64 cr3_target_value1; - u64 cr3_target_value2; - u64 cr3_target_value3; - - u32 page_fault_error_code_mask; - u32 page_fault_error_code_match; - - u32 cr3_target_count; - u32 vm_exit_msr_store_count; - u32 vm_exit_msr_load_count; - u32 vm_entry_msr_load_count; - - u64 tsc_offset; - u64 virtual_apic_page_addr; - u64 vmcs_link_pointer; - - u64 guest_ia32_debugctl; - u64 guest_ia32_pat; - u64 guest_ia32_efer; - - u64 guest_pdptr0; - u64 guest_pdptr1; - u64 guest_pdptr2; - u64 guest_pdptr3; - - u64 guest_pending_dbg_exceptions; - u64 guest_sysenter_esp; - u64 guest_sysenter_eip; - - u32 guest_activity_state; - u32 guest_sysenter_cs; - - u64 cr0_guest_host_mask; - u64 cr4_guest_host_mask; - u64 cr0_read_shadow; - u64 cr4_read_shadow; - u64 guest_cr0; - u64 guest_cr3; - u64 guest_cr4; - u64 guest_dr7; - - u64 host_fs_base; - u64 host_gs_base; - u64 host_tr_base; - u64 host_gdtr_base; - u64 host_idtr_base; - u64 host_rsp; - - u64 ept_pointer; - - u16 virtual_processor_id; - u16 padding16_2[3]; - - u64 padding64_2[5]; - u64 guest_physical_address; - - u32 vm_instruction_error; - u32 vm_exit_reason; - u32 vm_exit_intr_info; - u32 vm_exit_intr_error_code; - u32 idt_vectoring_info_field; - u32 idt_vectoring_error_code; - u32 vm_exit_instruction_len; - u32 vmx_instruction_info; - - u64 exit_qualification; - u64 exit_io_instruction_ecx; - u64 exit_io_instruction_esi; - u64 exit_io_instruction_edi; - u64 exit_io_instruction_eip; - - u64 guest_linear_address; - u64 guest_rsp; - u64 guest_rflags; - - u32 guest_interruptibility_info; - u32 cpu_based_vm_exec_control; - u32 exception_bitmap; - u32 vm_entry_controls; - u32 vm_entry_intr_info_field; - u32 vm_entry_exception_error_code; - u32 vm_entry_instruction_len; - u32 tpr_threshold; - - u64 guest_rip; - - u32 hv_clean_fields; - u32 hv_padding_32; - u32 hv_synthetic_controls; - struct { - u32 nested_flush_hypercall:1; - u32 msr_bitmap:1; - u32 reserved:30; + uint16_t host_es_selector; + uint16_t host_cs_selector; + uint16_t host_ss_selector; + uint16_t host_ds_selector; + uint16_t host_fs_selector; + uint16_t host_gs_selector; + uint16_t host_tr_selector; + + uint16_t padding16_1; + + uint64_t host_ia32_pat; + uint64_t host_ia32_efer; + + uint64_t host_cr0; + uint64_t host_cr3; + uint64_t host_cr4; + + uint64_t host_ia32_sysenter_esp; + uint64_t host_ia32_sysenter_eip; + uint64_t host_rip; + uint32_t host_ia32_sysenter_cs; + + uint32_t pin_based_vm_exec_control; + uint32_t vm_exit_controls; + uint32_t secondary_vm_exec_control; + + uint64_t io_bitmap_a; + uint64_t io_bitmap_b; + uint64_t msr_bitmap; + + uint16_t guest_es_selector; + uint16_t guest_cs_selector; + uint16_t guest_ss_selector; + uint16_t guest_ds_selector; + uint16_t guest_fs_selector; + uint16_t guest_gs_selector; + uint16_t guest_ldtr_selector; + uint16_t guest_tr_selector; + + uint32_t guest_es_limit; + uint32_t guest_cs_limit; + uint32_t guest_ss_limit; + uint32_t guest_ds_limit; + uint32_t guest_fs_limit; + uint32_t guest_gs_limit; + uint32_t guest_ldtr_limit; + uint32_t guest_tr_limit; + uint32_t guest_gdtr_limit; + uint32_t guest_idtr_limit; + + uint32_t guest_es_ar_bytes; + uint32_t guest_cs_ar_bytes; + uint32_t guest_ss_ar_bytes; + uint32_t guest_ds_ar_bytes; + uint32_t guest_fs_ar_bytes; + uint32_t guest_gs_ar_bytes; + uint32_t guest_ldtr_ar_bytes; + uint32_t guest_tr_ar_bytes; + + uint64_t guest_es_base; + uint64_t guest_cs_base; + uint64_t guest_ss_base; + uint64_t guest_ds_base; + uint64_t guest_fs_base; + uint64_t guest_gs_base; + uint64_t guest_ldtr_base; + uint64_t guest_tr_base; + uint64_t guest_gdtr_base; + uint64_t guest_idtr_base; + + uint64_t padding64_1[3]; + + uint64_t vm_exit_msr_store_addr; + uint64_t vm_exit_msr_load_addr; + uint64_t vm_entry_msr_load_addr; + + uint64_t cr3_target_value0; + uint64_t cr3_target_value1; + uint64_t cr3_target_value2; + uint64_t cr3_target_value3; + + uint32_t page_fault_error_code_mask; + uint32_t page_fault_error_code_match; + + uint32_t cr3_target_count; + uint32_t vm_exit_msr_store_count; + uint32_t vm_exit_msr_load_count; + uint32_t vm_entry_msr_load_count; + + uint64_t tsc_offset; + uint64_t virtual_apic_page_addr; + uint64_t vmcs_link_pointer; + + uint64_t guest_ia32_debugctl; + uint64_t guest_ia32_pat; + uint64_t guest_ia32_efer; + + uint64_t guest_pdptr0; + uint64_t guest_pdptr1; + uint64_t guest_pdptr2; + uint64_t guest_pdptr3; + + uint64_t guest_pending_dbg_exceptions; + uint64_t guest_sysenter_esp; + uint64_t guest_sysenter_eip; + + uint32_t guest_activity_state; + uint32_t guest_sysenter_cs; + + uint64_t cr0_guest_host_mask; + uint64_t cr4_guest_host_mask; + uint64_t cr0_read_shadow; + uint64_t cr4_read_shadow; + uint64_t guest_cr0; + uint64_t guest_cr3; + uint64_t guest_cr4; + uint64_t guest_dr7; + + uint64_t host_fs_base; + uint64_t host_gs_base; + uint64_t host_tr_base; + uint64_t host_gdtr_base; + uint64_t host_idtr_base; + uint64_t host_rsp; + + uint64_t ept_pointer; + + uint16_t virtual_processor_id; + uint16_t padding16_2[3]; + + uint64_t padding64_2[5]; + uint64_t guest_physical_address; + + uint32_t vm_instruction_error; + uint32_t vm_exit_reason; + uint32_t vm_exit_intr_info; + uint32_t vm_exit_intr_error_code; + uint32_t idt_vectoring_info_field; + uint32_t idt_vectoring_error_code; + uint32_t vm_exit_instruction_len; + uint32_t vmx_instruction_info; + + uint64_t exit_qualification; + uint64_t exit_io_instruction_ecx; + uint64_t exit_io_instruction_esi; + uint64_t exit_io_instruction_edi; + uint64_t exit_io_instruction_eip; + + uint64_t guest_linear_address; + uint64_t guest_rsp; + uint64_t guest_rflags; + + uint32_t guest_interruptibility_info; + uint32_t cpu_based_vm_exec_control; + uint32_t exception_bitmap; + uint32_t vm_entry_controls; + uint32_t vm_entry_intr_info_field; + uint32_t vm_entry_exception_error_code; + uint32_t vm_entry_instruction_len; + uint32_t tpr_threshold; + + uint64_t guest_rip; + + uint32_t hv_clean_fields; + uint32_t hv_padding_32; + uint32_t hv_synthetic_controls; + struct { + uint32_t nested_flush_hypercall:1; + uint32_t msr_bitmap:1; + uint32_t reserved:30; } hv_enlightenments_control; - u32 hv_vp_id; + uint32_t hv_vp_id; - u64 hv_vm_id; - u64 partition_assist_page; - u64 padding64_4[4]; - u64 guest_bndcfgs; - u64 padding64_5[7]; - u64 xss_exit_bitmap; - u64 padding64_6[7]; + uint64_t hv_vm_id; + uint64_t partition_assist_page; + uint64_t padding64_4[4]; + uint64_t guest_bndcfgs; + uint64_t padding64_5[7]; + uint64_t xss_exit_bitmap; + uint64_t padding64_6[7]; }; #define HV_VMX_ENLIGHTENED_CLEAN_FIELD_NONE 0 @@ -794,17 +794,17 @@ struct hv_enlightened_vmcs { * Synthetic timer configuration. */ union hv_stimer_config { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 enable:1; - u64 periodic:1; - u64 lazy:1; - u64 auto_enable:1; - u64 apic_vector:8; - u64 direct_mode:1; - u64 reserved_z0:3; - u64 sintx:4; - u64 reserved_z1:44; + uint64_t enable:1; + uint64_t periodic:1; + uint64_t lazy:1; + uint64_t auto_enable:1; + uint64_t apic_vector:8; + uint64_t direct_mode:1; + uint64_t reserved_z0:3; + uint64_t sintx:4; + uint64_t reserved_z1:44; }; }; @@ -816,70 +816,70 @@ union hv_synic_event_flags { /* Define SynIC control register. */ union hv_synic_scontrol { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 enable:1; - u64 reserved:63; + uint64_t enable:1; + uint64_t reserved:63; }; }; /* Define synthetic interrupt source. */ union hv_synic_sint { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 vector:8; - u64 reserved1:8; - u64 masked:1; - u64 auto_eoi:1; - u64 polling:1; - u64 reserved2:45; + uint64_t vector:8; + uint64_t reserved1:8; + uint64_t masked:1; + uint64_t auto_eoi:1; + uint64_t polling:1; + uint64_t reserved2:45; }; }; /* Define the format of the SIMP register */ union hv_synic_simp { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 simp_enabled:1; - u64 preserved:11; - u64 base_simp_gpa:52; + uint64_t simp_enabled:1; + uint64_t preserved:11; + uint64_t base_simp_gpa:52; }; }; /* Define the format of the SIEFP register */ union hv_synic_siefp { - u64 as_uint64; + uint64_t as_uint64; struct { - u64 siefp_enabled:1; - u64 preserved:11; - u64 base_siefp_gpa:52; + uint64_t siefp_enabled:1; + uint64_t preserved:11; + uint64_t base_siefp_gpa:52; }; }; struct hv_vpset { - u64 format; - u64 valid_bank_mask; - u64 bank_contents[]; + uint64_t format; + uint64_t valid_bank_mask; + uint64_t bank_contents[]; }; /* HvCallSendSyntheticClusterIpi hypercall */ struct hv_send_ipi { - u32 vector; - u32 reserved; - u64 cpu_mask; + uint32_t vector; + uint32_t reserved; + uint64_t cpu_mask; }; /* HvCallSendSyntheticClusterIpiEx hypercall */ struct hv_send_ipi_ex { - u32 vector; - u32 reserved; + uint32_t vector; + uint32_t reserved; struct hv_vpset vp_set; }; /* HvFlushGuestPhysicalAddressSpace hypercalls */ struct hv_guest_mapping_flush { - u64 address_space; - u64 flags; + uint64_t address_space; + uint64_t flags; }; /* @@ -890,11 +890,11 @@ struct hv_guest_mapping_flush { /* HvFlushGuestPhysicalAddressList hypercall */ union hv_gpa_page_range { - u64 address_space; + uint64_t address_space; struct { - u64 additional_pages:11; - u64 largepage:1; - u64 basepfn:52; + uint64_t additional_pages:11; + uint64_t largepage:1; + uint64_t basepfn:52; } page; }; @@ -903,32 +903,32 @@ union hv_gpa_page_range { * count is equal with how many entries of union hv_gpa_page_range can * be populated into the input parameter page. */ -#define HV_MAX_FLUSH_REP_COUNT ((HV_HYP_PAGE_SIZE - 2 * sizeof(u64)) / \ +#define HV_MAX_FLUSH_REP_COUNT ((HV_HYP_PAGE_SIZE - 2 * sizeof(uint64_t)) / \ sizeof(union hv_gpa_page_range)) struct hv_guest_mapping_flush_list { - u64 address_space; - u64 flags; + uint64_t address_space; + uint64_t flags; union hv_gpa_page_range gpa_list[HV_MAX_FLUSH_REP_COUNT]; }; /* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */ struct hv_tlb_flush { - u64 address_space; - u64 flags; - u64 processor_mask; - u64 gva_list[]; + uint64_t address_space; + uint64_t flags; + uint64_t processor_mask; + uint64_t gva_list[]; }; /* HvFlushVirtualAddressSpaceEx hypercall */ struct hv_tlb_flush_ex { - u64 address_space; - u64 flags; + uint64_t address_space; + uint64_t flags; struct hv_vpset hv_vp_set; - /* u64 gva_list[]; */ + /* uint64_t gva_list[]; */ }; struct hv_partition_assist_pg { - u32 tlb_lock_count; + uint32_t tlb_lock_count; }; #endif From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492282.761749 (Exim 4.92) (envelope-from ) id 1pQ4Kc-0000Ej-5K; Thu, 09 Feb 2023 10:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492282.761749; Thu, 09 Feb 2023 10:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Kc-0000Ec-2A; Thu, 09 Feb 2023 10:39:10 +0000 Received: by outflank-mailman (input) for mailman id 492282; Thu, 09 Feb 2023 10:39:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Ka-0000EU-Kd for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:39:08 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id faca7aaf-a865-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 11:39:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8812.eurprd04.prod.outlook.com (2603:10a6:20b:40b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 9 Feb 2023 10:38:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:38:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faca7aaf-a865-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMCrkf98kIMouAlCo/62YTxWBCI8/x0p0vF/cgQNOiEgRLI/iJoCCDcOpyu5dO0t7ibIDqlpG49njqMdqvo0bn4U4Kl8vUUoK8Vw+G70gO3RVmP416crU+7Fyr61u02OhDRmLADdWc5zAzw4y2wqqlnCjp5whdOu+DOVqivBgkpnRgDC0jTOGUAVMSu6yIUKr1MoouNU/+CnM9x+KW1yaFuBCngcgcNIoWmtZiEwcBw2IED7erPfSkvuhzUOWdGgwqwJK1duZAFyXcmPQJ09QdGrLAqf04Ur5TTHxSAWHqTd4xW/dhs4/iidE8C9d2VQC8AUCSDgLDaP4CVzfFRsbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rILu2n+55PxWhIc3uZf00lTC9CxB/k+P+ibUVXcR5pE=; b=kRNb/Hr5WovfO5ROemcIzfmjPBIEL3viad6d2WP5sGxkNzTR7hzPOaCE5eqiFtfLC6yiypiuFZ4LLlZUPPUSLNJoCkZkgNI0mD5ir28Bb9agKEbK2j+nxm25Q3bMktmfIsKtiilTfqSLVYvCK9Y+yqj1Ln9skJAnkYnh6iuX5+DKmWoIVQB7ytdifM0hpP1hJHe3dVKqnu16kVG3aLfhASBMvEsr3WOOsmBJa5NhvdPHWf/8zmbaF4kSetqF0C494c2nGLY7+h88s1NKf6WikQL+2a3tq+lKHSGlyFDHMY+i1t+nyACqPnd5hcwrld5Qyg4HK37kZIggh8MLc6WqWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rILu2n+55PxWhIc3uZf00lTC9CxB/k+P+ibUVXcR5pE=; b=h+4Ct9hinHdoKZaCNytvCOQEa7ck9UMC4Nc6qV+jhtJ8KI+fcOtaqt7sdA7QqoQCmxbKsWHNYXDs0rxoxTA6MvMnnO3tDaOIQdnGtrVCzJH1XZ4EV+HroDe2RvpFqEAwIcTAHj75k7/pxEqDKj93Rt2SgPP56cLNC9s4kP9uNf+k8R9svqWqaLhoAnZtZoAvD0xWQyQKSe/xF3sSh1tPpF0pGaMLbpiuHN1YORS+PDiCsEcNHyY2n88g2H2D5hXvMIkFGN1Oj70Mia0V+yvuUAaU4Vq0ngu9XjmDKvHdVAf+R002rnMumHrjiG+LqAeaduoFSoz3sXmt6cY6KhWQmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> Date: Thu, 9 Feb 2023 11:38:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 2/6] common: move standard C fixed width type declarations to common header Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8812:EE_ X-MS-Office365-Filtering-Correlation-Id: f5787135-ddb2-4de9-b95e-08db0a89cc30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xZDN7h274UmwGO384UrUp4P7Mlql0OI9lp2zKjToRlzW757DdLfRh1nJUD86GqPUMjwRw8btEr1eUTT6z4HRg1ji19AHyiHArzyWIogeWO4qX1S12o37DywPBN/LVhIX44TCWVpg/Q/0lwXG+tDWpVqm54gEqL5ZDkzl106LQxB6dEV10HpOY+MhxAsMGyGoMI4cGBPK+ILczJfFxElFtgX62QwHdEqAJrqQxk/5ylsKs/AsvnPNpC1uZtP1sbEdS4HEdWQX/QDaAuYvL5LOigDhK6zTMelKvJkKv79WbswYjK8aaawn0sTC56WLFeophoQRNEaGtoz2T99ckW1G1Dj8Jyx7dxAqkanqi2yNnp+0NU8IqBNPUz8gWsSce1Jl9sOO30l35ED0EIJUm0km1g8i3aa1tom9AJrPkiXDT+KuIPu/ywKOfmikpuFN3qEVVL0OwlWSlgYs3pKPhNCIOQwILxFhBZOZX/skIt15VR5oInyofoTVlVUS6XNNHD7EA2EomBMAcaRmDiK+kn/46NlmsdpAISZEZXbNTXe4h5kBVl1l0SFhHULBaEcvcwkjBfKXuAmcny6R0BzUqlJGosxlmIqanfI/VzbF5Pvt+69HVwPEstVETRzp5t2up9aGh1CXpjPiCsKni4f7sRSb9dtAunrlKQXlEtMEgyBQ04uz6bdueDUhaXS1bSXauaA42hVh+pmlUqt713qtA2lSSxyPdNLmJWGt+qCVSpXTW00= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199018)(5660300002)(7416002)(86362001)(31696002)(186003)(8936002)(2616005)(26005)(38100700002)(6512007)(83380400001)(54906003)(66946007)(316002)(4326008)(41300700001)(8676002)(66556008)(66476007)(6916009)(478600001)(6506007)(36756003)(6486002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlVPVlB4SnUzU09KYmFNbE5CRTN5RExFRElPS2t4Q1RRVzM4bENkZVIzYzZB?= =?utf-8?B?aUFUS3BsbzFEc2NweXA5eDZYY0Y1eEtiNGFkQ1ZvZVRHSEV4ZElsSk1CZ0dy?= =?utf-8?B?TG9pajRvQTY5elJ3RTc4Q0ZWVktZMmVpUmZmUFk3NkFrdThWZTNSSndqUTBL?= =?utf-8?B?WXVZMlZrbXg0VUJPWGhxN1p5VzhMNUJ6V1dtSmk5UWRQbFNWVk1RbDZjL0Vk?= =?utf-8?B?dXVJd1YyNmt5by9XTzlMVyt4SnFNSjdWTnp6cHR2Rytlempvck53WFNpN251?= =?utf-8?B?Y01YNTVuYmhsbzR0ZWtPZ3N4T2MvWE9kbTJUc0lCZVA5OGlySit3dUFOQ3Vt?= =?utf-8?B?M0UyR3Q4c2JUcjFuSldZYmtvcU9wQmVuRjlBdEcveVJ1WGtkK1cyd2dWM0Nu?= =?utf-8?B?V3pjaVVZMy93TUN1allJM1FHMzlBenJPNnVQTHVnME1LMnZraDgzdVZuTHJw?= =?utf-8?B?dzR2Z2l6RmRWMzRzMzBRWVJBMlZVcUtnZkI0Y1FPNU5EbVR1cWw1Z1A4ME43?= =?utf-8?B?cmNLdTRhbThTNEMvQW5kQUNIcjVRNE1xc00rd1ZScjhxRHNDcll6TVhKVHJw?= =?utf-8?B?dHRDUnV4U1RQSzRFa2dGY2lEd2NyYVI4dWNIRnZibHVnSlFONW8rTkgya3ZH?= =?utf-8?B?UEZHYXNhSVhQaWtiM3MrNHl2YlVNZE5wUEkyK090ZTdCdzZUZHVaQncvenFH?= =?utf-8?B?YmpGRitGRzk4V3hlcjlZSVBXakc5dlFQeVdQSHg0UmVHUVV1YzVmS1FBVzA1?= =?utf-8?B?SmRNckt3TUpQVzRWOGYyS2R2S0F5SzRxbE9BcXZvSGt3LzVkRDJMOC9IL3VV?= =?utf-8?B?Rno5bmROeWZTV3VCK09wNzBnbXY2dGluWW5tcDErSUcva00ybThTMkZKditl?= =?utf-8?B?WEU0cFN1N0t6SFZJUytCcittUXJORkZxSGJEMVpWSEZIZ2xzR0FySWNzL0dU?= =?utf-8?B?Z2JpQjV0RmxXY1ZyVkxocWs4eStXdm9XbDN6T2owa3VjVlJ6UTV6Z20ySkRS?= =?utf-8?B?MGd2Ulg5MUc2K0tYRUVuWVEvU2lxYmE0cnB0RTdlejhaQmc5Y3VQbFZSS1Ny?= =?utf-8?B?YndjNldHaXpNTGpxWWdsSzZoT25ja2VyM1NHbktvV1FtNkpCa21BUHVnRDJq?= =?utf-8?B?OXNvTUIzYk5GZERMSWg4YWxBU3BoYXNQa2EveXJWcjJGMDlpUDJVejYvaGtt?= =?utf-8?B?b0Y2Y1FJL1dRWGVWWDVDSmtMR2FIbDh6OStLUWhpZ2x3T3hhUEpTR2xkWXdj?= =?utf-8?B?MnBlNzNlbStxZVE3eDFKamdXdmZrYjM0TFkrMWYxeFo3WU5CaW1oaGhMS3c5?= =?utf-8?B?SEFweDRVcnU1dEl6UnFBRGl0dzZCaW9ibVJDaVZLdTVtWU4yam1kVGNVM2RS?= =?utf-8?B?UVl3MkNabVpiZ2YxeGFYSlVxUVN6THRYbTViRjdLQU55YlR5Z3pFSytISXZD?= =?utf-8?B?S3pWYzhCcHRlcUJmVm1Qd1VpRTlNc1BHQVZOcldhaWFrUnhNV3Q4czBuVEt5?= =?utf-8?B?WktqRlAwN3RzbUh6alF5eVNCQ0pOZWpEUi9STi80dStIcGJEUTk3SE9EL0pa?= =?utf-8?B?T1A4aE5jR3BBaFBNNWsxMml4Q3JtY1I4eUQxZEkyZFo5U2NNdlVNNG9KMmZ2?= =?utf-8?B?YTB0bmNtSGJxMDNMTHJSb2RHU1BoVkxaTDF3V1RLR2RqdnU4WFpRZ1JERmZO?= =?utf-8?B?NjdzUUVoamxucjlhRGtIRy9sV2tVT3AwZW9Nb1Q2b01kWERHSWlMNld5NDlG?= =?utf-8?B?aVBJTnUrZkxobG12YzMwVmlvcEs4dkg2OFowOHdTajQ2L2I1d2dFSjhGR2NV?= =?utf-8?B?dXpjdG5nQnNIUXZmY1ZLZjhVNDh1OUhtR1M3SjJoSlBPdHF0Y2E2LzdtMGh3?= =?utf-8?B?WjNaRGliTWcrVW54bWZJckZNMzQ0VWQ3MW91UEVwZ3J0NW1LZ0lodjFFK2xE?= =?utf-8?B?eWFueFcyYVV3YkRPUjFSVStJNmliNTByOFlsbEllTHQ4aWxGaGU2MTFaL1R5?= =?utf-8?B?YVU2cDlnQUhLZ0RLNTBEdWNBRGIrS21XZWl1bFhpYWoySVhKMGYvWjRtUHJx?= =?utf-8?B?bXhmekJXWjBseXpYa2VEQ2U0aGd4alhMb2VoeEZqMTlTS0xieERBamJwOTZM?= =?utf-8?Q?WanG7VLBzrbysN4JIhST8Vh+/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5787135-ddb2-4de9-b95e-08db0a89cc30 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:38:35.8412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ri+eI6HX8DtkrxNlqljsJdvmUy3/yfa7COjsdEh+Cy7giW+eEbWPZMBD/2MuhQjdMzgSWxU9ltDaIX7bIL633A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8812 Have these in one place, for all architectures to use. Also use the C99 types as the "original" ones, and derive the Linux compatible ones (which we're trying to phase out). For __s, seeing that no uses exist anymore, move them to a new Linux compatibility header (as an act of precaution - we don't have any uses of these types right now). Modern compilers supply __{,U}INT_TYPE__ - use those if available. Otherwise fall back to using "mode" attributes, but this can be relied upon only when bytes are 8 bits wide. Should there ever be a port to an architecture not matching this, it would need to define the fixed width types locally by some other means. In a few cases inclusion of asm/types.h needs replacing by xen/types.h. Further in common/trace.c take the opportunity and also drop the apparently unused inclusion of asm/io.h at the same time. Finally in some Flask sources inclusion of asm/byteorder.h needs moving later. No functional change intended. Signed-off-by: Jan Beulich --- RFC: I know Andrew would prefer these types to move to a new xen/stdint.h, but not being fully convinced of this myself, I was hoping for others to voice views. --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -1,37 +1,8 @@ #ifndef __ARM_TYPES_H__ #define __ARM_TYPES_H__ -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) #if defined(CONFIG_ARM_32) -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#elif defined (CONFIG_ARM_64) -typedef __signed__ long __s64; -typedef unsigned long __u64; -#endif -#endif - -typedef signed char s8; -typedef unsigned char u8; -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -#if defined(CONFIG_ARM_32) -typedef signed long long s64; -typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 typedef u64 paddr_t; @@ -39,9 +10,9 @@ typedef u64 paddr_t; #define PRIpaddr "016llx" typedef u32 register_t; #define PRIregister "08x" -#elif defined (CONFIG_ARM_64) -typedef signed long s64; -typedef unsigned long u64; + +#elif defined(CONFIG_ARM_64) + typedef u64 vaddr_t; #define PRIvaddr PRIx64 typedef u64 paddr_t; @@ -49,6 +20,7 @@ typedef u64 paddr_t; #define PRIpaddr "016lx" typedef u64 register_t; #define PRIregister "016lx" + #endif #endif /* __ARM_TYPES_H__ */ --- a/xen/arch/riscv/include/asm/types.h +++ b/xen/arch/riscv/include/asm/types.h @@ -1,38 +1,8 @@ #ifndef __RISCV_TYPES_H__ #define __RISCV_TYPES_H__ -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -#if defined(CONFIG_RISCV_32) -typedef __signed__ long long __s64; -typedef unsigned long long __u64; -#elif defined (CONFIG_RISCV_64) -typedef __signed__ long __s64; -typedef unsigned long __u64; -#endif -#endif - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - #if defined(CONFIG_RISCV_32) -typedef signed long long s64; -typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 typedef u64 paddr_t; @@ -43,8 +13,6 @@ typedef u32 register_t; #elif defined (CONFIG_RISCV_64) -typedef signed long s64; -typedef unsigned long u64; typedef u64 vaddr_t; #define PRIvaddr PRIx64 typedef u64 paddr_t; --- a/xen/arch/x86/include/asm/types.h +++ b/xen/arch/x86/include/asm/types.h @@ -1,31 +1,6 @@ #ifndef __X86_TYPES_H__ #define __X86_TYPES_H__ -typedef __signed__ char __s8; -typedef unsigned char __u8; - -typedef __signed__ short __s16; -typedef unsigned short __u16; - -typedef __signed__ int __s32; -typedef unsigned int __u32; - -#if defined(__GNUC__) && !defined(__STRICT_ANSI__) -typedef __signed__ long __s64; -typedef unsigned long __u64; -#endif - -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long s64; -typedef unsigned long u64; typedef unsigned long paddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" --- a/xen/common/trace.c +++ b/xen/common/trace.c @@ -16,8 +16,6 @@ * it's possible to reconstruct a chronological record of trace events. */ -#include -#include #include #include #include --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -1,6 +1,7 @@ #ifndef _LINUX_BITOPS_H #define _LINUX_BITOPS_H -#include + +#include /* * Create a contiguous bitmask starting at bit position @l and ending at --- /dev/null +++ b/xen/include/xen/linux-compat.h @@ -0,0 +1,19 @@ +/****************************************************************************** + * linux-compat.h + * + * Container for types and other definitions use in Linux (and hence in files + * we "steal" from there), but which shouldn't be used (anymore) in normal Xen + * files. + */ + +#ifndef __XEN_LINUX_COMPAT_H__ +#define __XEN_LINUX_COMPAT_H__ + +#include + +typedef int8_t __s8; +typedef int16_t __s16; +typedef int32_t __s32; +typedef int64_t __s64; + +#endif /* __XEN_LINUX_COMPAT_H__ */ --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -3,6 +3,66 @@ #include +/* Fixed width types */ + +#if defined(__INT8_TYPE__) +typedef __INT8_TYPE__ int8_t; +#elif BITS_PER_BYTE == 8 +typedef signed int __attribute__((__mode__(__QI__))) int8_t; +#endif + +#if defined(__UINT8_TYPE__) +typedef __UINT8_TYPE__ uint8_t; +#elif BITS_PER_BYTE == 8 +typedef unsigned int __attribute__((__mode__(__QI__))) uint8_t; +#endif + +#if defined(__INT16_TYPE__) +typedef __INT16_TYPE__ int16_t; +#elif BITS_PER_BYTE == 8 +typedef signed int __attribute__((__mode__(__HI__))) int16_t; +#endif + +#if defined(__UINT16_TYPE__) +typedef __UINT16_TYPE__ uint16_t; +#elif BITS_PER_BYTE == 8 +typedef unsigned int __attribute__((__mode__(__HI__))) uint16_t; +#endif + +#if defined(__INT32_TYPE__) +typedef __INT32_TYPE__ int32_t; +#elif BITS_PER_BYTE == 8 +typedef signed int __attribute__((__mode__(__SI__))) int32_t; +#endif + +#if defined(__UINT32_TYPE__) +typedef __UINT32_TYPE__ uint32_t; +#elif BITS_PER_BYTE == 8 +typedef unsigned int __attribute__((__mode__(__SI__))) uint32_t; +#endif + +#if defined(__INT64_TYPE__) +typedef __INT64_TYPE__ int64_t; +#elif BITS_PER_BYTE == 8 +typedef signed int __attribute__((__mode__(__DI__))) int64_t; +#endif + +#if defined(__UINT64_TYPE__) +typedef __UINT64_TYPE__ uint64_t; +#elif BITS_PER_BYTE == 8 +typedef unsigned int __attribute__((__mode__(__DI__))) uint64_t; +#endif + +/* Linux inherited types which are being phased out */ +typedef int8_t s8; +typedef uint8_t u8, __u8; +typedef int16_t s16; +typedef uint16_t u16, __u16; +typedef int32_t s32; +typedef uint32_t u32, __u32; +typedef int64_t s64; +typedef uint64_t u64, __u64; + #include #if defined(__SIZE_TYPE__) @@ -46,18 +106,6 @@ typedef signed long ptrdiff_t; #define LONG_MIN (-LONG_MAX - 1) #define ULONG_MAX (~0UL) -typedef __u8 uint8_t; -typedef __s8 int8_t; - -typedef __u16 uint16_t; -typedef __s16 int16_t; - -typedef __u32 uint32_t; -typedef __s32 int32_t; - -typedef __u64 uint64_t; -typedef __s64 int64_t; - typedef __u16 __le16; typedef __u16 __be16; typedef __u32 __le32; --- a/xen/xsm/flask/ss/conditional.c +++ b/xen/xsm/flask/ss/conditional.c @@ -9,7 +9,6 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include @@ -17,6 +16,8 @@ #include #include +#include + #include "security.h" #include "conditional.h" --- a/xen/xsm/flask/ss/ebitmap.c +++ b/xen/xsm/flask/ss/ebitmap.c @@ -10,12 +10,14 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include #include #include + +#include + #include "ebitmap.h" #include "policydb.h" --- a/xen/xsm/flask/ss/policydb.c +++ b/xen/xsm/flask/ss/policydb.c @@ -22,12 +22,14 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include #include #include + +#include + #include #include "security.h" From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:39:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:39:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492283.761760 (Exim 4.92) (envelope-from ) id 1pQ4Kg-0000WR-DF; Thu, 09 Feb 2023 10:39:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492283.761760; Thu, 09 Feb 2023 10:39:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Kg-0000WI-9v; Thu, 09 Feb 2023 10:39:14 +0000 Received: by outflank-mailman (input) for mailman id 492283; Thu, 09 Feb 2023 10:39:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Kf-00082J-4W for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:39:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1b::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbd729c4-a865-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 11:39:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8812.eurprd04.prod.outlook.com (2603:10a6:20b:40b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 9 Feb 2023 10:39:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:39:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbd729c4-a865-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nb7TAX9XbHRjntH435Ii1Y/1h1GrE1jI3njwEnd6CLgWQInk4nUM0hx/8y9AgeWvSRmNjH1gBQxwRjc4/OZuASEA+0Zkz3XNQTcTnHivfZ5T426ofjydc0TU65NIqmDAwqV73n5QKDA5t455WYDdFlSKyqWgqicX4cZ7zf3XkJ1kW60vAmzsYJ6gYzjAIWm+4p0u+prf3do1aq5jKPC4hjJxQG6EjcCkmJ287Kwra6cz/SMukIt8f6J+5H2ZyF3zk2edWwEdPI6PK/yd2ss650y3QAX0DhIQtz0aG8OPZZ3k4TYoSEdMusvdKWxXmovpurMve5p34dyTu+a7jYZoxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZ6dMhewYflEJz8XfzAjeFgRRV7iuGsvgI4j+vcP/zo=; b=PMkgax1bK6bUa2JrdkJZM7CekKC5LxnsOgisHk/OlPNU5pULQlAyoxIdTcizge77fvhpfdxrbEkVVfvjp7XYk1R0H3TfWiFwU7IPHtm9S0H/miKmc2sStDFJBqnEWTfE/SM8G+OYtRI/Ebhv+mQyH8IGOF21QhMYeDECxh/xXHLCpFPq+0nMsx44lQr0UuukS1MIbJedBUfvIotB5PFplambSIN63hwlRGDvef7lYucBn8Ohjc8BjmP08IPNWO22zoHjLtt32m9fAwPXHdzQ5fFbzoTIQDKrDFToN8occB1yxpdgDjBVy1TPLiETh9sqypHwEKlZR+YjROnUpWc8yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZ6dMhewYflEJz8XfzAjeFgRRV7iuGsvgI4j+vcP/zo=; b=5q1MTHOd+W1I/BYvBPolA2lWuSa+Cwso0BwX3Apma4GMnZQ50awMWmtVgXLa8e4nQXdmr45evOXQO+7jpupViPFDqE3e5V4VxfxTQozh5sUloGnrDCsF+NHAtDxmYhtTzGFLTmoKKpw+s5ZVnkllATiCUhQJMJbtungeX2F9qEaZP3S33+0PQAMGzjYbOM6m8SiG1HG1w4EuepzBJosPnMsOSdGlCpRTvZvmtWZbVF+BZrMG+8wupqIVARDskUyd7uyChC6xUb2hnioU78uU6DoUHC3uZEIv6bHMaXrXrFpSBSOQGxMpQ0yJV+cFi7X93Uaznf+OyOfY6Vni787klQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <68bb1c78-2b6c-4b8d-725d-f1d6a6c92dcb@suse.com> Date: Thu, 9 Feb 2023 11:39:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 3/6] ACPI/CPER: use standard C types Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8812:EE_ X-MS-Office365-Filtering-Correlation-Id: d13952fa-7d8d-4bec-c235-08db0a89e095 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aVZu7CDR3mW+eRsPE8rdamQyutMkNkiE1cfBktYMi4JjoWZPoAka63yxGdeqOb0Eqhzfs+XqUC1bdeEQ1rBU17kSOBjjrMFxAqu4xEEvRS/+lFzqWt8se6zPRXJlVVhQbu6yDmIMgwCUa4cYelgoghrtc60WEe1uzgrvTmyLpOmvUotCWLdjZikkP7+LFQ8ah3MFmocL7LQd2dQyx/Yjzjcq+Sl2W/QvRoXQpum44d0TV0uyLucD6hhnfp2w/9w45SYOA+c5t0UiQZeyu+kN42OprIGpJfWkLB6GAfuARvgAig7F/gdY1MjZ6MC3KlsiPrMSCmk/BWY46NOBquUxCJLEJ1ZKD5vs2bGbw3rrZHUMeiGl4TGQqM4LU0OZ7oHsRCOvbOcXVA/eHDabdmn4ZCfAHm4JqlQRgn6Bqn2JAvGgIiGCKvLuSmoWSa43h9Nug2jMYDfJG+N6DAaN2usaOOozTnZtFlTB0OAYVayzH6QUPmYYCC+s5PC9KPOW3jsalZY8skoBNUeukMticrmq97zfderoO91rwMenRCJleMwc5XMPAGY9EMwAAHdNH+xSCHNDP1TG1lJyj++vi3PAi0v+yhbXVkERZOjgKxBlBLvkAifgsKg6g2k1KU26dIdTA80Or2H0T0NiMxLPljsJer6s1FsdLw+8yR7ffc5jI5gsTp0G+2Mii4p9pjPpgF8iK//h8fZ283nF1ghSaHVX9Etz+jRp68fP+axWe+HOXY4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199018)(5660300002)(86362001)(31696002)(186003)(8936002)(2616005)(26005)(38100700002)(6512007)(83380400001)(54906003)(66946007)(316002)(4326008)(41300700001)(8676002)(66556008)(66476007)(6916009)(478600001)(6506007)(36756003)(6486002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0duTkhIMkQra3IwMEgwNGhQRHdraUJuRFNFdG5GcTU2YkU4aDJtdWFUa29i?= =?utf-8?B?R3JyWCtpalA2SlJQUmk0YkkxMkIzTW5hRW5seDViY00xZzlpY2thNk52QW9K?= =?utf-8?B?RDA3SE1aVnJzV2JjMVZDSXVTTzBsN2hja0YyUmllOG45K0pHcmIzUUI1T2ly?= =?utf-8?B?Y2psdzd4RXArc0xtUmsrVkZ3MldqSlp3TDJpMW1NbzduMWxBUExFS3d1Z2M5?= =?utf-8?B?bVlmMWFvRVFwSlNWUHYvblpUNWw0UzBITWVmQlgzY2hScU5YS0VJQXJ2Nndm?= =?utf-8?B?RC8yVlNYVWdpMmpneDBINndvKzMrZ0ZMOVhveUxSMXNTdVpCN0xYbG00QXVW?= =?utf-8?B?R0hKQzNXcDNUaStpYWM1ZkJ0K2ZvcmY1eXhiVnV0Z25GZkFwMG1IVmIvdWVH?= =?utf-8?B?Q1ZkTU41MndRUG1RcjI1SFJVWXFhK1VzWVFDczd6cHhlQ01WRkFHSm9zOVhY?= =?utf-8?B?MEV6eklsckR1akdNMWN3UFVTY2F2RDhvbXRzcFVVZEtmZm5yeHBadXN3Q1ho?= =?utf-8?B?cG1WRWdiZ2pzQ25VREhxQ2VWbi9GdGtZUG8reDhVc1N0aEl3NEZ2M3VSTXNk?= =?utf-8?B?dEZXUmM4cFIxVSt5TUp1SWFNSWNUb2dlQzcreFk4ODZhZGg1OE1ZQWdITGNM?= =?utf-8?B?bE1Ya0NET0VGUU1ZQlZSTkE3cnZOaDAzK1krbW5qS3lzeVJ5NlQyQ2lLNWoz?= =?utf-8?B?OTBpcnpnaWFheUVCR21qNlEzZmloSnB3Y3cxeFZBSU1RcVFnRTh6dTN6aFoz?= =?utf-8?B?V2U2ZVB2S0xldGp5UUVOVkZHT29QaXRMVlBwWDQ5cWIxVHRNNGxaOUlmRGM3?= =?utf-8?B?eEZKUk1YUHR3eUNIaTNqNVg1N3RKMEM1RXNlUnNQaDhvbFVSeW1LcG8zVHlv?= =?utf-8?B?WjVMS3lzbGNmckZSY3JNMlI1RDcvdUZOUUJxMlFPRExrY2tQMGFKUmErbUhj?= =?utf-8?B?elFpcW91a2krbVlHWEwrK2FtdktLVG9IKzdXeXMvOHpJdnI1c0F5b3Bmc3BG?= =?utf-8?B?c3dpcTNWdUNVWkN2MFk0dk9lS25OK0hRVjlINXVmOEl6eiswemVscUlGUEJm?= =?utf-8?B?V0xXT1FnZnlxbFJvUHVCVFNJcFBRV3VRNm5id05xdFM5R2VGNmQzdVpnVHEx?= =?utf-8?B?WlYyS2lEZTM5NjJzWDZnb1l4WTN3TytGNmJrWVJoWEFNREJsTmJFVHIrbXlK?= =?utf-8?B?UFBWM3FFb2orTEFCYlVWV1Y1TUFBdmlHN0FWY0dMeXE4ZHFnVFc0YWxaWk1x?= =?utf-8?B?Rkdxcms4TWVpaVVVRVdkMnZjY2J2dy9rRHNOTUpiZzJUV3I4a3BpOG84Wkpx?= =?utf-8?B?MVZOU2JyUUlUVHFqTkhOdy94N2p0czVXZTNlWG1xQUZ4SjZNUkZBY1Bsa3A5?= =?utf-8?B?c1BrSVp1OGNrLzdCa0hnUVR0TE9WaUM3bEpoT1FORThBNmw3S3IyOUl6TlR2?= =?utf-8?B?VzFIc2h1TVZpRlE3Vm56L2pHeURVZk1XQjRKNHlqRFBPYXJCbGl3MXBha1Er?= =?utf-8?B?Wmd2dGFOaUZEa0t2ZjVtakFmUmxsRUV0VUhKV1UyeituR1UxeUc5WXFLSnc4?= =?utf-8?B?cDk0U01vMnpTTDcvcXpvUEQzdWF4TFczd25JTUxMc1VqQVlYR2VodlZzTm5Y?= =?utf-8?B?RDNXUHk1SFk3b0pNTXBabHc3NlNDMnJHTlArOGwveEk0VUwvbitaOCtmMWJa?= =?utf-8?B?KzZwYTR6bXBWZFlpWW1TbW00NUZ3b002Y09KMkZoTExhR0xZQTZSS3I1M3FU?= =?utf-8?B?Z0xVMW40ZUJYcmF1Wk1yWmV3YlJKWFFQb0s4THkvVnJPVFlCeFdJS0RROEE3?= =?utf-8?B?MkVRYk1HVXR5NDB2a2wrNHovUnNMdEFIY1h6WVVLTi9TSlFmS3hYRXZQaTVt?= =?utf-8?B?cFpHVG10VUwvMFVLc1pXcEJaVFArcldlLzY4NnZXcm8zSTE3VDR4Yjl1VVI5?= =?utf-8?B?VjZkS2tNWGRJNTJtNmNrWU93NDJuU0xaZUFVY3MyVkpMWlExL1FCcEJtSk91?= =?utf-8?B?eXYrb2dsT1ErT2JWWXg1R1pZMEY4MFFtb2JPeU42T3FVMS90WThoRlY2Qy9k?= =?utf-8?B?cjJiSjhEWHNuOFBvWFI3OHd5QkhZNzdKVGNiMmlMcWlUcnhtYmYvQ0dHNFEr?= =?utf-8?Q?mxfjbZURAoENBDKuqNzNXfrgQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d13952fa-7d8d-4bec-c235-08db0a89e095 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:39:09.9327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ij1zuDafS55VRwyH3CfYoxU8FvupoEEmXjhYnPpPix0DEfzIC5cjGFFkla0ndAjpxJQoY6hZuN/BI9/ueMBL/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8812 Consolidate cper.h to use exclusively standard types. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/include/xen/cper.h +++ b/xen/include/xen/cper.h @@ -27,7 +27,7 @@ extern unsigned long get_sec(void); typedef struct { - __u8 b[16]; + uint8_t b[16]; } uuid_le; static inline int uuid_le_cmp(const uuid_le u1, const uuid_le u2) @@ -35,12 +35,12 @@ static inline int uuid_le_cmp(const uuid return memcmp(&u1, &u2, sizeof(uuid_le)); } -static inline u64 cper_next_record_id(void) +static inline uint64_t cper_next_record_id(void) { - static u64 record_id; + static uint64_t record_id; if (!record_id) - record_id = (u64)get_sec() << 32; + record_id = (uint64_t)get_sec() << 32; return ++record_id; } @@ -154,36 +154,36 @@ static inline u64 cper_next_record_id(vo struct cper_record_header { char signature[CPER_SIG_SIZE]; /* must be CPER_SIG_RECORD */ - __u16 revision; /* must be CPER_RECORD_REV */ - __u32 signature_end; /* must be CPER_SIG_END */ - __u16 section_count; - __u32 error_severity; - __u32 validation_bits; - __u32 record_length; - __u64 timestamp; + uint16_t revision; /* must be CPER_RECORD_REV */ + uint32_t signature_end; /* must be CPER_SIG_END */ + uint16_t section_count; + uint32_t error_severity; + uint32_t validation_bits; + uint32_t record_length; + uint64_t timestamp; uuid_le platform_id; uuid_le partition_id; uuid_le creator_id; uuid_le notification_type; - __u64 record_id; - __u32 flags; - __u64 persistence_information; - __u8 reserved[12]; /* must be zero */ + uint64_t record_id; + uint32_t flags; + uint64_t persistence_information; + uint8_t reserved[12]; /* must be zero */ }; struct cper_section_descriptor { - __u32 section_offset; /* Offset in bytes of the + uint32_t section_offset; /* Offset in bytes of the * section body from the base * of the record header */ - __u32 section_length; - __u16 revision; /* must be CPER_RECORD_REV */ - __u8 validation_bits; - __u8 reserved; /* must be zero */ - __u32 flags; + uint32_t section_length; + uint16_t revision; /* must be CPER_RECORD_REV */ + uint8_t validation_bits; + uint8_t reserved; /* must be zero */ + uint32_t flags; uuid_le section_type; uuid_le fru_id; - __u32 section_severity; - __u8 fru_text[20]; + uint32_t section_severity; + uint8_t fru_text[20]; }; /* Reset to default packing */ From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:40:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492294.761770 (Exim 4.92) (envelope-from ) id 1pQ4LL-0001N7-QH; Thu, 09 Feb 2023 10:39:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492294.761770; Thu, 09 Feb 2023 10:39:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4LL-0001N0-NU; Thu, 09 Feb 2023 10:39:55 +0000 Received: by outflank-mailman (input) for mailman id 492294; Thu, 09 Feb 2023 10:39:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4LJ-0000EU-Qd for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:39:54 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe13::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 160a4f14-a866-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 11:39:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9387.eurprd04.prod.outlook.com (2603:10a6:20b:4ea::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.32; Thu, 9 Feb 2023 10:39:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:39:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 160a4f14-a866-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUF/5wg0yAoQ5BnNkl3+d8S1Z49SeY+Vq6ogeiMo6lweg7aUOHx8mgMNunFIvpRz4r2LugQ5LoK/79sRUBQc/y+muqZiCTJPNUI1wN/jEwsshJerPeitPgye+4QOtqBA9QlDXCl3Qed39dUlnvOPb1MLexkA9qnGfOBqpZUmVCIVZKeuIAaYvq1rmpDkfTI+c/SmafQexSXe4uwpSFWQEk8QwI+E0SVYNJFjo3qPmCv1HBQawDWIuC5mBqDGeUrnvIbT0x0ngHCObYwAZLroqLot7v7thfMXt9zc8PQYNJiyAqJI3M4/0rMlORAwHQZ4CCMEBSFMO5iO39aYn02TKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsV8xTifBcj/y3tgKvVpVcGSALX044cesQDYK+Fr4Ek=; b=QR2u6+HCW2e/dhqtz+gEW629Zb3W0R9VPCj+j4tkqltGJ67bNnhHyPz5MEAFyZuHsytaN9+GpAHbcD0v2ALSHer8la79VoVR2LAa91j5qfM+EQxEzIgpsKk4H6IOETfiWq97O2sYMKY9CALqaK7toGp1NUJwmB2KPQ10u7SjDMhfNPyTf+//gxXK7FrpvDeiO0DJYBKvBCn/aCDSudVvQsx9ReY6cGdof5wfC+id4kgAbRAnjNUyPEIORnITGtHvhfYsUb6qsOCyJO291uj6X4qPd+wMqEWYj82OnCi7vyS9h1q9cRrCqYGyRC3dNjgxCzpYWu2584RJS+XXk264Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsV8xTifBcj/y3tgKvVpVcGSALX044cesQDYK+Fr4Ek=; b=AnqoOJYGekNWGqT455/63I735z95vafYL1j8sp8/dVnvMMMZFUkBBP+LiTK6Qyl+e2ByOhC14PbNoFVEPwIRnhgdFIBv1tGcEJsPh+6TJCWnNEIZiIFq/1D0md5lMWcVKrE4QAYiBa0rp+1LMz9R5FXM5jkGOadmZL5GRDo7pxHe+BoW5XQZSvVo4M5jgNFdG4OB83Ku71titSb9a2W7zzsas56b+jkeySZOtxsGiQyIYfMzjlIs6uuYTeOh1s4lyPLOm88UVLbX9EfBx3UKF8hyBQ5juiKB4+nCia4vPTSokmdPH2FUbN7CYC/PRo/2EDWyElQIVSXAmvnz9KEOJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f375055-eff2-010b-c904-e4122b834777@suse.com> Date: Thu, 9 Feb 2023 11:39:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 4/6] x86/MSI: use standard C types in structures/unions Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0101.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9387:EE_ X-MS-Office365-Filtering-Correlation-Id: 52788b22-d743-4a63-6823-08db0a89f8b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mu35lepH7Ed1r5RZ0TjaXbzpzyhfsKABQiMpnZ4HUHxPBEhCEduQdsqI1PH8kl7iGtgXasskD+u0DeMh384cxB5BRjC0R6Fr+cAappZbptdg49Bgd4lO9OTW6tAoCQanNL7RqSEgDXKkfZZI3iDbwtJ2tntQlVsEV14fKprZHpK/OPL8ZxejIfNwZaU4wlMuxC7manYl/FEu1oE/UXXriMxUy9JlJlTPcdy1+pZ/oTXSgKxpZz3za6nG7VJ6uMSTvmG/8k+545I9Hu6L+cPPFUvJZClwPCSzZD+SoLVm1QcZxpoTXKvZlkn5i91stpJ/3TnH9yPxTPYmhGWC3qEupSqe1+h2MFO7yZmjDyBjGoBGCRRIM8Djeb8P6mbA0jdAdJE0SEBnQcoINCC1IDX8NkwgiRDfLIShDsJ2bLuBsEcFQijbZWgR2SqjWAtKqUYHPZlxJI7wFbKArsgQ8sObIw7+lzh8/QPVp8YuRhWYhxo9T1NOBtB5+gd9No/zQnpTZ9cGctdjOSrvJVt3/6x04kyokOQHSB2ln0DNehxGqTjutfrEXRmoJOLuyAS6+SOLClMa9mOlIGb0ZYNDV7urhbKRAIJHr+ZWqa8c38hEANANjod/q7z/hFTCW+/iDo1fxgonW0lUhZs94tsQOSOQusW7z7zjgWJu/1xkac1XftokDTURokRZRmKyLD90meDPWSFLDO2pn/noMkpnFZOpiMVJjE9WmFOJsPk3Td/8KDY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199018)(26005)(5660300002)(31696002)(86362001)(8936002)(186003)(41300700001)(83380400001)(4326008)(2616005)(6512007)(38100700002)(54906003)(8676002)(66946007)(316002)(6916009)(66556008)(66476007)(6506007)(478600001)(36756003)(6486002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTlhVUJTbDU2Z3N5Si9FVnZtdTZ0WWkwbmJXazgzZlJiVDNCdHUyS2dSNVBs?= =?utf-8?B?TDRTbk9kRE1zRFRYdWtkWThlUlcxa3FwTUUzaXRyaWRoRVJyM3hsYTVzVEM2?= =?utf-8?B?dmplNjBjN24walBjckNYejV6Q0ZReG9sN1hyN0xrUTVJWFpaNlJlZlprb1FL?= =?utf-8?B?Q1BkZy9veDlHR0ExaWJtRklRRDJJcG16bFJDMHhsaTA2MUFiQk83U3lyU1Fx?= =?utf-8?B?S2pQZGQ1Z2pWWVR2VWJaUzVqaHR4ZVlvSWZ6U3lheGhDRktMcVJjdGJwcm9m?= =?utf-8?B?cEc0T0VoOG5HcTQ2eTUvaktxTUM3QXpoNG5ienU5aWt4Q2Z2cWtRT3BYSm5k?= =?utf-8?B?c0MyQU9BbTU3c2NmUExORDJtSzBFY3JiS1NLaDVmeFo2QmVvUkttdWc0S24y?= =?utf-8?B?aUp5T0ZGSWExajhQSkgweXFHRDlVblRMREpJRHE5SGYxT0lkSnN6aEhhM3Aw?= =?utf-8?B?RU5hRFJ0dVIwZitNeEYySDdsZkxHVWtRQ0xnMG1wRGZLd2JWYkhJMUtENEdJ?= =?utf-8?B?blBwVVAyQmw2U2dpZm1CUUNSODRhbEYwZ0dXQjh0SnVVS0p3akdZVXZoallN?= =?utf-8?B?c0FZZkxKQnIzcDZsSHlrRkROWUIwanJsVG4yczdjOFY0dHNzYW1xc3N3cHlu?= =?utf-8?B?bkhRdTN3V0VpaU1Gejh4eENBYUdYQzQ3aDhnL0wydU5ZRkJHT0NSWHUwK3Aw?= =?utf-8?B?NjF4c25JTks2eEFiYjFDTEFZUWdONERFTEg3dGJmRTZaemlMUnp5UWM0R0xm?= =?utf-8?B?T2ViV1VpdDFNNkZmRGZoMXRqZ0NCekp0eElnYTd5ajBmU20wVTNZTUZWdnhk?= =?utf-8?B?TXFtS09sWXhTNVI4UWZ6Q3dJVWd1VHIyMUlOTkdBakFkcXc0S2U4cDB3NGJH?= =?utf-8?B?L2RlQ05QKzVkNWNmZzlaMWxmV2lVL3lGYzRKaDNvMmJnV3hqNnRheEpJRnN1?= =?utf-8?B?WUo2L1FMRW9MZGZMNTJCUEJlcU4vOUJQVmtUSWVUY1k3ZU1hSWZBY215ZnhV?= =?utf-8?B?ekJLcWdHZXk4Q2lKRkwyd2VHRUxGMERGV1ZVVU1vMWEwMXB6R0g5R2tkaFkw?= =?utf-8?B?NU9HazhXcmZmeXllS2tjWWZyQzN2RnFBa2xxb1NWWTJTbjA4Y09jbXVSV0ZE?= =?utf-8?B?RWJ5QmZkWERzYXhHcWpua2NWamlNVWtIWWxJRitDRTc1bVEzSnAwNFAzaUtS?= =?utf-8?B?TzhqbjRMelBiQ3RvWFBTR20xMGVYWmNrWlozRGRUaDVrZTF5bVJjald6ejIy?= =?utf-8?B?VTExL1NVZlpROCs5eWI5TjJpUThvUWFFTm4xaFdaU2ZyL0k2TSs5U2tJbUR6?= =?utf-8?B?VnlXUGZLOW9pRTlHSjZDNHhDaUJiTGxkejRPZUczUDNXK0doS2dwanJiYVh6?= =?utf-8?B?OHpJQjlrSEJYNCtkS2UyZ0RBN2hhbVA4WHdVTWlaRWlFS0dzUlQ1U0t4amVQ?= =?utf-8?B?MTF2bWxXUFgwM0c0bHkxbTJTbHRWWlN5Ylg0RWZVTXpuTEpKYXY5RlhHL1M4?= =?utf-8?B?L0VYSVJDM1U4YW5sc2VaMkgzclJ1UnhrSmdLcTlJOEtKTDRJUmJkN3p2K010?= =?utf-8?B?VWhueGczazJKYndpSERTYXV6SVo2U0lUczVlSS9icjQvRXhNalRyRk5jdVNT?= =?utf-8?B?Z2lCb3UwOVRWSHdGVjloUEMrOHhzK3d1YnF5ZUdRUTVXalo4Q1kxTVQrblJ2?= =?utf-8?B?Si9qNWpIYkZFMEdMR1NraENYZXdRMExsK1ZaTEkwMG14VkwyMTdoYVNuOUYy?= =?utf-8?B?K2VKZ1hINGNESDR3UWdabTZoc2Fnc0hoZXlHL016Z2FzajUxMEw4T21CT2x6?= =?utf-8?B?aUtFbHFOakZxTVlNZ2dGeVZWdkpzTGxqZjZ6dC8xQlVGL2toNGNkd2s3L201?= =?utf-8?B?bkxTbXRJczhueFFZL1ZiTUZIRHRCb3c2R2ZKeEFBRm1ERTZ5aXoxcG5MN0NR?= =?utf-8?B?V2JTTzZZcDF4YUJ0cnlxYWxVUWIvRFc5L1RnclAwVmYveTd0ZytuSGxZSU53?= =?utf-8?B?MWl5b1pNQWxXMGYzbU5kOEZ1MXlJRHd5Sk11MkQvZER3NVNZb2Y5a05LbDc0?= =?utf-8?B?WU1qSGtMY1FTMUdrQmdsVDFmdkVQMVVzVC82cko5dmxIVWIxMVJ4Yzk3Z3By?= =?utf-8?Q?cMpLTQudyHTzDeYgL0CKPZhBP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52788b22-d743-4a63-6823-08db0a89f8b4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:39:50.4458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gRReWV91OHYdd6o799k+9OBuIvuYe5ogMzmGUr7zsyGHNnEr+tJmR4KfrwrTbWQNsiQC+HlWFfUBRe1D7LKzjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9387 Consolidate this to use exclusively standard types, and change indentation style to Xen's there at the same time (the file already had a mix of styles). No functional change intended. Signed-off-by: Jan Beulich --- For most (all?) of the single bit I was on the edge of switching them to bool - thoughts? --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -66,15 +66,15 @@ struct msi_info { }; struct msi_msg { - union { - u64 address; /* message address */ - struct { - u32 address_lo; /* message address low 32 bits */ - u32 address_hi; /* message address high 32 bits */ - }; - }; - u32 data; /* 16 bits of msi message data */ - u32 dest32; /* used when Interrupt Remapping with EIM is enabled */ + union { + uint64_t address; /* message address */ + struct { + uint32_t address_lo; /* message address low 32 bits */ + uint32_t address_hi; /* message address high 32 bits */ + }; + }; + uint32_t data; /* 16 bits of msi message data */ + uint32_t dest32; /* used when Interrupt Remapping with EIM is enabled */ }; struct irq_desc; @@ -94,35 +94,35 @@ extern int pci_restore_msi_state(struct extern int pci_reset_msix_state(struct pci_dev *pdev); struct msi_desc { - struct msi_attrib { - __u8 type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ - __u8 pos; /* Location of the MSI capability */ - __u8 maskbit : 1; /* mask/pending bit supported ? */ - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ - __u8 host_masked : 1; - __u8 guest_masked : 1; - __u16 entry_nr; /* specific enabled entry */ - } msi_attrib; - - bool irte_initialized; - uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ - const struct pi_desc *pi_desc; /* pointer to posted descriptor */ - - struct list_head list; - - union { - void __iomem *mask_base;/* va for the entry in mask table */ - struct { - unsigned int nvec;/* number of vectors */ - unsigned int mpos;/* location of mask register */ - } msi; - unsigned int hpet_id; /* HPET (dev is NULL) */ - }; - struct pci_dev *dev; - int irq; - int remap_index; /* index in interrupt remapping table */ + struct msi_attrib { + uint8_t type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ + uint8_t pos; /* Location of the MSI capability */ + uint8_t maskbit : 1; /* mask/pending bit supported ? */ + uint8_t is_64 : 1; /* Address size: 0=32bit 1=64bit */ + uint8_t host_masked : 1; + uint8_t guest_masked : 1; + uint16_t entry_nr; /* specific enabled entry */ + } msi_attrib; + + bool irte_initialized; + uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ + const struct pi_desc *pi_desc; /* pointer to posted descriptor */ + + struct list_head list; + + union { + void __iomem *mask_base; /* va for the entry in mask table */ + struct { + unsigned int nvec; /* number of vectors */ + unsigned int mpos; /* location of mask register */ + } msi; + unsigned int hpet_id; /* HPET (dev is NULL) */ + }; + struct pci_dev *dev; + int irq; + int remap_index; /* index in interrupt remapping table */ - struct msi_msg msg; /* Last set MSI message */ + struct msi_msg msg; /* Last set MSI message */ }; /* @@ -180,48 +180,48 @@ int msi_free_irq(struct msi_desc *entry) struct __packed msg_data { #if defined(__LITTLE_ENDIAN_BITFIELD) - __u32 vector : 8; - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ - __u32 reserved_1 : 3; - __u32 level : 1; /* 0: deassert | 1: assert */ - __u32 trigger : 1; /* 0: edge | 1: level */ - __u32 reserved_2 : 16; + uint32_t vector : 8; + uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ + uint32_t reserved_1 : 3; + uint32_t level : 1; /* 0: deassert | 1: assert */ + uint32_t trigger : 1; /* 0: edge | 1: level */ + uint32_t reserved_2 : 16; #elif defined(__BIG_ENDIAN_BITFIELD) - __u32 reserved_2 : 16; - __u32 trigger : 1; /* 0: edge | 1: level */ - __u32 level : 1; /* 0: deassert | 1: assert */ - __u32 reserved_1 : 3; - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ - __u32 vector : 8; + uint32_t reserved_2 : 16; + uint32_t trigger : 1; /* 0: edge | 1: level */ + uint32_t level : 1; /* 0: deassert | 1: assert */ + uint32_t reserved_1 : 3; + uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ + uint32_t vector : 8; #else #error "Bitfield endianness not defined! Check your byteorder.h" #endif }; struct __packed msg_address { - union { - struct { + union { + struct { #if defined(__LITTLE_ENDIAN_BITFIELD) - __u32 reserved_1 : 2; - __u32 dest_mode : 1; /*0:physic | 1:logic */ - __u32 redirection_hint: 1; /*0: dedicated CPU - 1: lowest priority */ - __u32 reserved_2 : 4; - __u32 dest_id : 24; /* Destination ID */ + uint32_t reserved_1 : 2; + uint32_t dest_mode : 1; /* 0:phys | 1:logic */ + uint32_t redirection_hint : 1; /* 0: dedicated CPU + 1: lowest priority */ + uint32_t reserved_2 : 4; + uint32_t dest_id : 24; /* Destination ID */ #elif defined(__BIG_ENDIAN_BITFIELD) - __u32 dest_id : 24; /* Destination ID */ - __u32 reserved_2 : 4; - __u32 redirection_hint: 1; /*0: dedicated CPU - 1: lowest priority */ - __u32 dest_mode : 1; /*0:physic | 1:logic */ - __u32 reserved_1 : 2; + uint32_t dest_id : 24; /* Destination ID */ + uint32_t reserved_2 : 4; + uint32_t redirection_hint : 1; /* 0: dedicated CPU + 1: lowest priority */ + uint32_t dest_mode : 1; /* 0:phys | 1:logic */ + uint32_t reserved_1 : 2; #else #error "Bitfield endianness not defined! Check your byteorder.h" #endif - }u; - __u32 value; - }lo_address; - __u32 hi_address; + } u; + uint32_t value; + } lo_address; + uint32_t hi_address; }; #define MAX_MSIX_TABLE_ENTRIES (PCI_MSIX_FLAGS_QSIZE + 1) From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:43:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:43:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492300.761782 (Exim 4.92) (envelope-from ) id 1pQ4OT-0002r7-8F; Thu, 09 Feb 2023 10:43:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492300.761782; Thu, 09 Feb 2023 10:43:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4OT-0002r0-5V; Thu, 09 Feb 2023 10:43:09 +0000 Received: by outflank-mailman (input) for mailman id 492300; Thu, 09 Feb 2023 10:43:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4OR-0002qh-Df for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:43:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0628.outbound.protection.outlook.com [2a01:111:f400:fe0e::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8726017f-a866-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 11:43:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9649.eurprd04.prod.outlook.com (2603:10a6:20b:4cc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Thu, 9 Feb 2023 10:43:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:43:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8726017f-a866-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGVQX2k2/gZbC2/zFX7PsMzUPIQZHjCjEv0pkHxb5+suyv6EqKeT0picWHB9B2heVw4ijaecjG2VVuflcRDhaD2p1ZFz4SkGEe6e6NeDxprXoPnDx6IPVJjXTPg/O+dr7KHrPXCOkCVwTAl85zxY8dNqMj9457mOCsTjZJJLp1worygIz8ebrpeaSh86ilVjDBo3Ypbmq3RKoEtM6s1bVVZbuPGKW5HkeWa1N+TbLlWt/Zt1NrSRDLFTgCxrxUqQPYPVd8nCVLRet/2DOyP+IC+KxD6wOW8nPLd32YZRGm+PVxINrMWgs8aoj8HF4IyrD1EygOpT6zz4cnK+ZraFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJVJeI3VEzCV6YzhKqBfgIWU3kFqNTq9u2bZ49rhjQk=; b=NtN72dCwfen2oRhnSjBrLirE4DEQduXdLtDAanyolrc/xudQ3nnuJcLxw6ag40mcAbcr+foW4xvdbGqOPygeoexQLgB7GGMB+KYemQcs9HjGO1WG9W4OinmqahX1qEXcEQo2oxr5qaR0cY6Qnwx5SvFkj1C76XcTSif2lHfHiJZguGXzImXCwR4bsbHVGzzpncXxEGFSiIUZOu2d2IGWb1trA87YRkTLmli9qzmtgv/52Ty5thk30ImmocJeD1U493aWta/1cIEvSwiM//KsU1gdq9+SN2OG88CjOJQV/lwFOVogy6WFjRkBNqY+1GPpnaO15FK3By+sUlI7PC7IIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJVJeI3VEzCV6YzhKqBfgIWU3kFqNTq9u2bZ49rhjQk=; b=w+W64sXlQehQ0GrzRlLJmLNgtwCFrNV1+Hc5mSl2rtluAevrC+pLsro6ShBB21iTdXx0w2t+ED0zeV5TN9WIOTr272QL+MsS2hdVn+tb3fVLNeWoSCKEl3XQ58BZ55gkfeKC3LWGJLZTJimZRxr7EiCMhGBvTHCmbkYnrADefCdnUAA7UQP5eAcpY/1qaswiYkpPDPo3sbC+FWBlai/D0+oOPFheBA04UrUJMRcz4yTL5NHtoIZBsEBX/B1wWHyemB3aIbnB8H7A9tIS5p6lhtIWH3R0vuyLxQshusX4KO2J6/F08Gr6lYx/gHlt/LdKdrHZpypt4GcSJYSxzBciPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <969e851e-5674-9aa5-b00f-4fe4d4cf8e5e@suse.com> Date: Thu, 9 Feb 2023 11:42:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 5/6] x86: use standard C types in struct cpuinfo_x86 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9649:EE_ X-MS-Office365-Filtering-Correlation-Id: 13d93d16-cae3-4276-3880-08db0a8a6aac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QyOkqZrvgrRuO6IjBt3DPNA2UivYIMN+D5ynzjUX3Ygy1Ck0BPmMysFETOROs5c2kkhjML6J2kmHG1w9yN7OSrXrFPfX4jkIiO3HMEWR+SffWNbNd7kv7yTDc8Xkl7wOTGULROhADId4rI5ISPs6vozxHhOaSJNuzJnLX7Z2uUk6pWz+r7wYmTVjWLZN4u6ObpZCrJVngxS1W98sJS6J9lDinW5B8q6ZwaEe6Jjd1O9vgx6RWUQtsR18SWTKxnX8+MlOCilmpifqyMZhyHswNRo2N/Um5ODlrmTtHdoT4JgRtwdIaWPXnP9T1jF56xQ3DhkXpR23cT2hVAS/AR8tMs8WFuD+qpF/C1iov56Z7N3AcEpGI5I7ZelRl9kSGNdr+hR6EbqzGcl67InASe28Tf9Vo0AxZYKdqjdsdvfxxW80OKK0AxAH0FAdjtmnZ07IhkQGrrFMi8p4v2Q6vhF2HBw9NX2D97ls3hmN9rmgoFaUTH6G9R3fi/bOpy/YRgYpkZ0L0EnX35ueNnSoYhfDnB5LIA5fA+HrBlIfoB4pu8fAjppbIZ2GBYhZ18ZLsJZx0AZ2urIm8dTgqolKq/dJhlP6ybBSxPM1n5vk1fbhh9/+M5v6DpImf/4796UUZ+okc02HwTsdFkJ5L1ESj5e4/BzWso4lCUzmIqfdug3M0vi8DsTqEQzIUOgmzGmc4kXwIrpqTUvM383GrhErrsz8yLyO3goKvbBOPavXA98dxQg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199018)(4326008)(6916009)(8676002)(41300700001)(66476007)(66556008)(66946007)(2906002)(36756003)(86362001)(31696002)(8936002)(38100700002)(5660300002)(478600001)(6486002)(316002)(2616005)(54906003)(6512007)(186003)(26005)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUxmSnlRM0VOOUNWdlNqWDZFMzFTVEJRZmluaHhDTUZMZ2Y5ckNISGpFdStj?= =?utf-8?B?K0s2S3FnalQ4QXA2ZkRCOFBUSHpYbWowTzRnS0h4VHJsRnQzVmROK1M4TTM5?= =?utf-8?B?RnI5Vnd1RHFGQ1NTcTJTRFRoeGtGRzJhUEpROUs0b3J4UDRzdTJ1V0Nxajhv?= =?utf-8?B?VXdROGNSRFdvR1JtQ21zcjhvd2F0N3k4V00vK1VjeWY0ZEQ4K3M4VFNoVWtN?= =?utf-8?B?dWJ2WTBldUcxMSsvdDE5K2dtMDhxaGtTUklzekhzTko0d0NxdVJxcHcwMHBo?= =?utf-8?B?bEhyTzFvUEVJRFhHSG1DMEo3cHFJL1g3UExmeUc0YXBkN2RvZVdlMVY0OE5N?= =?utf-8?B?cCtUYnUrZXAxay92ZmY1NHE2RHVxTTJGRVpWSk1Xa1RtcHdCR1JXTS9CVFpT?= =?utf-8?B?cXFUMFNJZHhkYU9BdEhOL1o2eFpacFZsTHhmdXBGbHBrbjZRM1kwOWFPVEdO?= =?utf-8?B?TVpLZExSY3FUVS9xNTZ0NmpDVVZuTzJiMGtkMGZjWS95UGpBNTkzd3RIZjJu?= =?utf-8?B?U0VOVXpvdHJlUlR0bVBNYmlzNmhjdkdzbmRCQm5LSXgzNTZKZW42QnpQdlhs?= =?utf-8?B?VzU2Y0phZ01Oamhzc0JPMkpLTFhSZVl1WlV4VW9vSStEOXN0ZTNDbzZaZDRx?= =?utf-8?B?RXJlTloxaS9IaWhZQWw4aHVDNzFKNUVVYmVUVzdvNXA0TUp0eU1JSmlsTnQr?= =?utf-8?B?NkZlS1lJdDA2MlhzMFFHYWtQMHVsdzNSeGx4TUtDdm1hQXM2emEwSldKcGto?= =?utf-8?B?dEUvTUZQVEVLWkxCeXMwTTNuWENoci9WNEZDaVN6bS83Nnp6ZWRrSkdWdzl0?= =?utf-8?B?ejhZRkRocytKVTNRZFNxcmFtVnpGTVJGbXRiTmx6VEJtNUNlODdWcUdCU3ZR?= =?utf-8?B?b0hFMkNuNE94MDZWRUs2eFFUYVFPT1Y4WGhFbVBsYXZ6UFhuU0thRXBlL2lj?= =?utf-8?B?OUZRWGQ5QStRNlF1MER3UGZMdWFJQkpmWE5EdGorRlczQ0pkUFRSOXdOZkpo?= =?utf-8?B?dFJ4TTYweTlJNXRhYmJBNnB0R3Vnamk5ZzR3TDFlNElGMG5yaWxmTVVrOUty?= =?utf-8?B?bU54aVdSUTR6Vis0RlF5NjRqNzBXOUp4blFKQk5SemVpU0lnQ1NvUkRHUDNF?= =?utf-8?B?dHJjOERpeE9IOTBwejFETk8vU3J3S1BQdmdEWno4cTF6YlluMTIvZ2VxUFg0?= =?utf-8?B?UVplK3JSRGRRcmczMkl5QldleDltYTlWcEY2V1RERE1MUUdyV3pWUk02TDhE?= =?utf-8?B?SnVva1FIWU9UUUs2WkRFc0twY0NCbzAreVo5d3lYckUwNGhwRHZjS1BJVytq?= =?utf-8?B?T3cyNXJ0OTdwa21odjUvZzVHcnJYS1RPbmxPV1JmcWVVbmxON1ZiWVYzZzRE?= =?utf-8?B?eEx2OTArenNEMjFBbnVLQk1jWmpaamZKMWw2c1VUWGNrOTIzNFhHSU9VUTBO?= =?utf-8?B?WG9TSVlvUVdvRXhBd2NHdTlGbFRyQlRPOGlMOXY3MVNIMHc3N214dzAraW5L?= =?utf-8?B?UEVIbCtQQzl0M1VFWHB3QXJaZUh0UWE0eTF6aFNXam5Qbit4SjdBR1FETkNK?= =?utf-8?B?ejJtKzczbmFvRFVHbXpnRXduY1FIUjZQWWNOeTlqaHpoUGJVVWRPN0RzQWxB?= =?utf-8?B?UDZrc0p2WVZTSHlTc0xNY0hLaHc5K3crdzIxOVBKeEpoOENEK1ArS3pLaURx?= =?utf-8?B?cjRJVG9Pd0ZHRDFLaGxrM2JrdWR5MG9FeTdYSzBCeWZqcC9hQ1h2QjgxSjNh?= =?utf-8?B?M0NUbzQ0UlMvb1ZmTkUrejRibXdKRUt5S1dDZVF2RzczUDUrSEQyZTZ3V1Fq?= =?utf-8?B?SDBhZUhrWVFNaXpQaldEQjBWaTBmTk42eDdkZElqaGlJeDhGZEpUL2tpSjVQ?= =?utf-8?B?Y3ZML1VlR00rdkQ5VDROZlVWa0NMTDlDbzhXd1V5cm0zamlJMDZiOVBJSVhy?= =?utf-8?B?Vnd5QjVEOUduUVl6VEpmOG42MGJ5aWhyZUtxelJ1QWtqM01xUzFPZTZEeXJS?= =?utf-8?B?QkYvL204T2R2L1RaRjZEOUFwN0R3ZllIQkN3NVB3Rkk3b2ZMb0JWaXlNeWho?= =?utf-8?B?dUl0cDdKQ0JzdW4xS1BPcnIwbkgzLzN4VWRwVlVQV1V4djcxZEVSN2R5VWJW?= =?utf-8?Q?t4dwrMRDEO7MASw2/mqtjCHmc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13d93d16-cae3-4276-3880-08db0a8a6aac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:43:01.6836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xnabBtj8Heszq/9zguIyLxYQx8fDP631u41/UHx+clJdfiz3ND0cAQx7zGUj3ZmuW9w0BfMpEJAZmVbksxMTpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9649 Consolidate this to use exclusively standard types, and change oprofile code (apparently trying to mirror those types) at the same time. Where sensible actually drop local variables. No functional change intended. Signed-off-by: Jan Beulich --- Much like x86_capability[] already doesn't use a fixed width type, most if not all of the other fields touched here probably also shouldn't. I wasn't sure though whether switching might be controversial for some of them ... --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -119,24 +119,24 @@ struct x86_cpu_id { }; struct cpuinfo_x86 { - __u8 x86; /* CPU family */ - __u8 x86_vendor; /* CPU vendor */ - __u8 x86_model; - __u8 x86_mask; + uint8_t x86; /* CPU family */ + uint8_t x86_vendor; /* CPU vendor */ + uint8_t x86_model; + uint8_t x86_mask; int cpuid_level; /* Maximum supported CPUID level, -1=no CPUID */ - __u32 extended_cpuid_level; /* Maximum supported CPUID extended level */ + uint32_t extended_cpuid_level; /* Maximum supported CPUID extended level */ unsigned int x86_capability[NCAPINTS]; char x86_vendor_id[16]; char x86_model_id[64]; int x86_cache_size; /* in KB - valid for CPUS which support this call */ int x86_cache_alignment; /* In bytes */ - __u32 x86_max_cores; /* cpuid returned max cores value */ - __u32 booted_cores; /* number of cores as seen by OS */ - __u32 x86_num_siblings; /* cpuid logical cpus per chip value */ - __u32 apicid; - __u32 phys_proc_id; /* package ID of each logical CPU */ - __u32 cpu_core_id; /* core ID of each logical CPU*/ - __u32 compute_unit_id; /* AMD compute unit ID of each logical CPU */ + uint32_t x86_max_cores; /* cpuid returned max cores value */ + uint32_t booted_cores; /* number of cores as seen by OS */ + uint32_t x86_num_siblings; /* cpuid logical cpus per chip value */ + uint32_t apicid; + uint32_t phys_proc_id; /* package ID of each logical CPU */ + uint32_t cpu_core_id; /* core ID of each logical CPU */ + uint32_t compute_unit_id; /* AMD compute unit ID of each logical CPU */ unsigned short x86_clflush_size; } __cacheline_aligned; --- a/xen/arch/x86/oprofile/nmi_int.c +++ b/xen/arch/x86/oprofile/nmi_int.c @@ -311,11 +311,11 @@ void nmi_stop(void) static int __init p4_init(char ** cpu_type) { - __u8 cpu_model = current_cpu_data.x86_model; + unsigned int cpu_model = current_cpu_data.x86_model; if ((cpu_model > 6) || (cpu_model == 5)) { printk("xenoprof: Initialization failed. " - "Intel processor model %d for pentium 4 family is not " + "Intel processor model %u for pentium 4 family is not " "supported\n", cpu_model); return 0; } @@ -355,12 +355,10 @@ custom_param("cpu_type", force_cpu_type) static int __init ppro_init(char ** cpu_type) { - __u8 cpu_model = current_cpu_data.x86_model; - if (force_arch_perfmon && cpu_has_arch_perfmon) return 0; - switch (cpu_model) { + switch (current_cpu_data.x86_model) { case 14: *cpu_type = "i386/core"; break; @@ -390,9 +388,8 @@ static int __init arch_perfmon_init(char static int __init cf_check nmi_init(void) { - __u8 vendor = current_cpu_data.x86_vendor; - __u8 family = current_cpu_data.x86; - __u8 _model = current_cpu_data.x86_model; + unsigned int vendor = current_cpu_data.x86_vendor; + unsigned int family = current_cpu_data.x86; if (!cpu_has_apic) { printk("xenoprof: Initialization failed. No APIC\n"); @@ -406,7 +403,7 @@ static int __init cf_check nmi_init(void switch (family) { default: printk("xenoprof: Initialization failed. " - "AMD processor family %d is not " + "AMD processor family %u is not " "supported\n", family); return -ENODEV; case 0xf: @@ -458,15 +455,15 @@ static int __init cf_check nmi_init(void } if (!cpu_type && !arch_perfmon_init(&cpu_type)) { printk("xenoprof: Initialization failed. " - "Intel processor family %d model %d " - "is not supported\n", family, _model); + "Intel processor family %u model %d is not supported\n", + family, current_cpu_data.x86_model); return -ENODEV; } break; default: printk("xenoprof: Initialization failed. " - "Unsupported processor. Unknown vendor %d\n", + "Unsupported processor. Unknown vendor %u\n", vendor); return -ENODEV; } From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:43:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:43:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492306.761793 (Exim 4.92) (envelope-from ) id 1pQ4PD-0003Pr-II; Thu, 09 Feb 2023 10:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492306.761793; Thu, 09 Feb 2023 10:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4PD-0003Pk-F4; Thu, 09 Feb 2023 10:43:55 +0000 Received: by outflank-mailman (input) for mailman id 492306; Thu, 09 Feb 2023 10:43:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4PB-0003Ar-EJ for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:43:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0618.outbound.protection.outlook.com [2a01:111:f400:fe0e::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4c7e637-a866-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 11:43:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9649.eurprd04.prod.outlook.com (2603:10a6:20b:4cc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Thu, 9 Feb 2023 10:43:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 10:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4c7e637-a866-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJR55GaZQIWOrmDagCBS9+tQbyv6h13ridGPWMoIz/nJseQFvbu+jV0Fj1QbMvowkLA8/gpJ3X6EwOHNy9YU8Z2VAwI8tI4w3wmjaZIzhahksjMObOpgoa45NZVQ55wuDggP6ePWZg1Bh/TgGGE4fkBOBIz8fXmaI7NbUPgwylyBVzjqAwbWpyD+bQTIFJdMDNi2VVgr0MmxyWPuejbtPIcEJVP6HW5DYRpPzebErbvSO1scFtS7Qu9qr8dgud0S0efU8Sz2LKnxIWtgk/6zzs/lbeU4w5wYYnvWYWb21kGITq/P8zl2aUTunIc/ryd0fOEVAiaIf40aCkJDZzJ5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xw8mCtU+Oy7VuL6oxtGntwYumtAFZyIQqnEOo+ExMsY=; b=cllWuWQ53azBWMfNfU+pK5BcWCSuora2G3PJKm/ejL0aJGD8T5xGhobBIq0o+y/4dg+hFC0G744HEHYDv9BcQCPybUHAlLbwp4nmv5hzRbxahXxZ87aXlrkrkQZMKV2uRYB3gKmBxCnEuCC8bxyI3Q9LlGTvp5yTrFPGUVGCWALdmPXVExdN67Bje8s9s5DxkOTH6dtokV8Lj+h/CrT6o5siK43/9l76oMlC+tvf2zs4UO4nkJx3NtwOwQ6Z+N1MgPwtak1ZfC/NkmzaOGnJjStnQ268+FWlt5A0jpmYdJEm19o6KRr2Q7cT4jiPn1X7ZoQibX/iF7i8oj+22qmFVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xw8mCtU+Oy7VuL6oxtGntwYumtAFZyIQqnEOo+ExMsY=; b=D8p01gsJ21aRF1psxOAreZBFo9vi1y4Ly98cSLrRSKUydJ0aDAEnDLSem8eWTq3xXj4WEOp6WGXamohAoc4TYxwtVf7ME8gUHkAU62I10xOqMLch1cRKkDTj/gPdP8K0Pzwt3KXrGPIkqhbk12Zc6XCMKRs5cdURpkugMI7TQFVZdSFVUFLzbYpO8JVKpV29Pi8Iq63ZIQYb+4UeOYKFedouVCgTmPFQgidJWbmOmfX5ghXzbxhChBb1kYGMS11Re48DwckQ0w91uVftK/nJgW9yjG6kiRNutcoX8+kgkqQcbGIEti7WvxniRHRalq+pZG9wwEfxDVx99lDDL15Ayg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e3c6641-1ab8-83ae-724d-a85af8e9ec17@suse.com> Date: Thu, 9 Feb 2023 11:43:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH 6/6] common: __u8 is history Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9649:EE_ X-MS-Office365-Filtering-Correlation-Id: c4758f9c-ffd8-4bf4-397d-08db0a8a882f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: am+Sj4y0Zy9eaE0UBXVyRPw2tEe9xi/L+ai5gl1BjOBeiNq8O4srcv2YBge1U9ETpwsVMkU+7rZ66oKPo0RLbsEC5lhbFIaaCv0UTWgK7sKZZNMXf29MwZBULZVIiUYZMeRnGsca+SPWIytt1156iw9Yk4VKoPUlo6hCipgiWXoDM0XHrFjjjxyPbegykIGK80MuNJNz+ZSV2SjtDw6GGtlXdJtOnUoCSdEcydQYEOZ3Sj3Qv7WI6ND8UMj11D0EUtsyVVSnRcN2Mb7i89xftrGJ2NAq+LIWHlGwXg1XEKxipDD2qNWaIeEfuAyU+iA9CypptHaQr7wzX1jeknPpbiJwYHR8IVWmHzwm1asNz6CTM9rHfpdcJb6l1xuC9anvNWewoChbeV0TmDbzXE3PteDLW5jYbJrQJAz9adDZ25uq9pMxSnbOk53D+E2L5bi4EK8BFVRCSYphmiwqk686YjvvLHn6X2ENtnvODWit9qlZ50B/+Y0tJfM4dkW1sguaQ9mJXNvcFmZBmhpL2IdBhvWVV1jNeJJTUhqqcRKKPsAYg5pCfJE7FAHYWsvhLGeHfAJsREMP35nSk7AmUYLv88C0ffDcEqk8KzjnJZo9lhCnlKEQeJeMhMxxlJlHDkwQJ3XxI0qULd733sljSN6zsPgkD56TpJ1/2ry8clTruK4jxpjgbgrQ29SANR+Eumyhw00nwRU0E2vCusR4O1dwEXN0TyLN3S5AEq0tqdvF8ew= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199018)(4326008)(6916009)(8676002)(41300700001)(66476007)(66556008)(66946007)(2906002)(36756003)(86362001)(31696002)(8936002)(38100700002)(4744005)(5660300002)(478600001)(6486002)(316002)(2616005)(54906003)(6512007)(186003)(26005)(83380400001)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2F4dnlPc2FxdCttZDFnRFFWbGxIaEVDUVhhVVR4bHF6VEI5VmdiWjl1Qkoy?= =?utf-8?B?M3FPWHRVb2J0c1dnaDNGQXgwUE9iL3U3eXF3NHhyczFWZUFCakRZTk5FdXZn?= =?utf-8?B?R3l5eHlrVklUOGNIZWZEeDZzOTViUUx1WEt0ZHpONlpka2M4bnR6Qkc1TENX?= =?utf-8?B?bzVjb0gxOXlWdm9yVDErYWpDdEplSStRT2ZDNE42RVVDbVpEcnF2ekk1TDB2?= =?utf-8?B?aCtsdDl2MFpTcFNqa01uT2J3cVR1cllmdi9HWlM3TzI1WVlidDMrK3hKbFA2?= =?utf-8?B?NmdjOUhhS2swVi9iVHpEQkU2c1FnUlZtWmdiSUJjVU9QMUZyNkNuc0N5UEpl?= =?utf-8?B?MUFxbnVuUFY5QmhudTd1K3JkemxWNkl5OUdHN0NTaGJzdm95NEdKWTNiU0lh?= =?utf-8?B?anJhdFpycGdPZHpoZU0yQkRXMHB0ZTkzNkdjRC9DTndtL3E1RkZSelRYSUJX?= =?utf-8?B?eklUNVhrTHoxcGVVRW1nN3gyVVdiV0xWTHVHRm5JN2VMM0ZkWHg4WDFSVndS?= =?utf-8?B?WHJaU2FtWUFvUVpBVm52aFFvRGgrMlN5TmZvQlhudVZSMURUUG16Kzc2NHVJ?= =?utf-8?B?T2FUZVQzdXNBdHJSc253UWdDalFnbGpRMXFVSlQwb09lVTdUbjlaZFRUQWkr?= =?utf-8?B?MmpPU05BbnVkbyt0TDFteDlxdXVMMi9aTzlnQ1NCcFFHZFJJRzFsL2RmOHpl?= =?utf-8?B?aDdSK1VpVVB5SFYxQXNOanJNUUZLTlYra00wZ1RhajJXVmkyYlNBUnR2TXhB?= =?utf-8?B?aVFTeWhmSEE3amtyN2FTWFFWMEhXb0Y0d29KeU1jdDd5OStLZ1pZa2xWdlFN?= =?utf-8?B?QnMvYmt3WjJLdWRtMmRBTEFLdWhGQWNHaGdCS0VwSmR0c0hJWHVMM2ZiNDVD?= =?utf-8?B?eVdKMEJ5WCtpa21NYW11bkw5blpidXRkTUYrZGFtN2p2aW5YRTZyWThKci9T?= =?utf-8?B?KzBHZVdoRkpIUlFQaHpSeStkMVhGMUhSTUtodk1BSUhQakU3Wnc2MnZvNS8r?= =?utf-8?B?RkRXR1QrQ2xJd3NIU2lnMHBGSzFBYVdIYno2SGZCbG5Td2lGc09Nd3ZrMU05?= =?utf-8?B?OFZlUVRiOWRTbmVHYysvRGtxZGl3YlpjM3I3YWExb3Jsa1JwSG1ZVGtxSzcx?= =?utf-8?B?RnY4aldMVlljU0Z3c3dlVmJkdGJCNDVCR09vR0JFSk9FWStnZk5DREdFdyt5?= =?utf-8?B?cFF4a00yWHlmUm9KUkhNMGR6YldJMkU5bGJMSUR6bmg2eVc4SDBjSFBwRXBu?= =?utf-8?B?azRxbThKOUwxUHE5YVZzTDVJOGxiRk02cjZIcUQxRC9BSWZsRWllTUZwdkFn?= =?utf-8?B?K1pKUmp3ZUlpcGRQTkczdzE4b3h1c1MrYkNiVmNIejF6b0lUQmFUUWxXbkFj?= =?utf-8?B?a3hGMVA4SmFqRFpjOFovS1Uvb05jbEdyL0ZpZ0oxYlM4b2s2dUpXdVJzY25R?= =?utf-8?B?dnNGdlprb3lPM2lsMTJrK25vRk13SjFFK05OQlVBcGdVT2x4bDNuZHBPcGp4?= =?utf-8?B?YkdEMDVrNHc3c2czYjhzTFpHQncxMlh2a0xCZEpFd1NGZEp1UmFDeHZScmFE?= =?utf-8?B?WlU4RVh5Qitxc1FFUkVrQldpRjlOYXNzRW9LS043dVo0RmVFY05XNkh4aGpT?= =?utf-8?B?Rnc2M2FGNmU4U25PS1VBK2hpY1ZoVnBGdU4wZHo0T2MwbTFEWUhMTzNwWUM4?= =?utf-8?B?N1I3RlQyczZ6Ky9Ic2hkWmtHQWlRZWZlOEYwUW5ZNTZPMDN5dlRYbGUxU3V0?= =?utf-8?B?amdGNFVuVGNuVnpxUXo0cEIvSGlWbnZKMFRPVWlGcUVMS1IwZVpGajZic204?= =?utf-8?B?eDFyVVpibVBUazVWN1ZTZGl4Z3ZvelhpbU5Pa2lZblF5cUZ3WGtVQWF3dk5Y?= =?utf-8?B?dTNzUGxjVHJqV1BLTjV5dE9jVFNtaGlFWjRRME9acTQxMlcrSG1MNUMrVWM1?= =?utf-8?B?enB6MWFhanI3L3J2NU51Q1JFZWlUWHBDaTVMYnByNUNHMWxPVWlObmtFY0JY?= =?utf-8?B?TnBkR2U0dEJES0w3K1FwNVVoakpCd0VuejZCVEQyb2R1WmRVTEtKVjZsNU1T?= =?utf-8?B?MjlyVXFJZG9Pc1VnWE5UMzBBSDR4Um1vL2sxcEZlQWhmWHh0alpKczZWdFRY?= =?utf-8?Q?ziHtuEQttq6P/NWAGhiqwT+L9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4758f9c-ffd8-4bf4-397d-08db0a8a882f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 10:43:51.1336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xym67MkgslfHVU/qGwa0AF04Kfyaxd1T1VEluGAIPF6cAzQYEnNnvtkcyZTS0rQ+VehlpNOATpILrDhzfXtfPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9649 With the last uses gone, move the type to linux-compat.h. No functional change intended. Signed-off-by: Jan Beulich --- The primary use of __u{16,32,64} is in the byte-order headers. Iirc there is a series re-working part of that, so I guess before touching the logic there that other series would better land first. --- a/xen/include/xen/linux-compat.h +++ b/xen/include/xen/linux-compat.h @@ -12,6 +12,7 @@ #include typedef int8_t __s8; +typedef uint8_t __u8; typedef int16_t __s16; typedef int32_t __s32; typedef int64_t __s64; --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -55,7 +55,7 @@ typedef unsigned int __attribute__((__mo /* Linux inherited types which are being phased out */ typedef int8_t s8; -typedef uint8_t u8, __u8; +typedef uint8_t u8; typedef int16_t s16; typedef uint16_t u16, __u16; typedef int32_t s32; From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:51:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492318.761804 (Exim 4.92) (envelope-from ) id 1pQ4Wf-0005AV-Ht; Thu, 09 Feb 2023 10:51:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492318.761804; Thu, 09 Feb 2023 10:51:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Wf-0005AO-EB; Thu, 09 Feb 2023 10:51:37 +0000 Received: by outflank-mailman (input) for mailman id 492318; Thu, 09 Feb 2023 10:51:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4We-0005AF-8q for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:51:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4Wd-0001BW-VK; Thu, 09 Feb 2023 10:51:35 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ4Wd-0004SY-OS; Thu, 09 Feb 2023 10:51:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N5BQRSbnLCTBz2imc5cAnBRt9nKiQwNqQAW1XkoWFto=; b=1rG8W2fT78eJO8+ehnCCMIEiwW RQOoLCNFzVztfkQd4zAyEPRCbrxbQ6oyLAZXuv7yhLLIinkpr9XIKTlV/OsIfMIMd+4HyeraSRLV7 xBh8cBBTEkcbXFYnUkIAdrb/nKSy9Gc3CVTZ7FRe9bXxzJ+ql4lmjmAOcyZgSJRebvMw=; Message-ID: Date: Thu, 9 Feb 2023 10:51:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 25/40] xen/mpu: map MPU guest memory section before static memory initialization Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-26-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-26-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:28, Penny Zheng wrote: > Previous commit introduces a new device tree property > "mpu,guest-memory-section" to define MPU guest memory section, which > will mitigate the scattering of statically-configured guest RAM. > > We only need to set up MPU memory region mapping for MPU guest memory section > to have access to all guest RAM. > And this should happen before static memory initialization(init_staticmem_pages()) > > MPU memory region for MPU guest memory secction gets switched out when > idle vcpu leaving, to avoid region overlapping if the vcpu enters into guest > mode later. On the contrary, it gets switched in when idle vcpu entering. As I pointed out in a separate thread, I don't quite understand why you are making the difference between idle vCPU and guest vCPU. > We introduce a bit in region "region.prlar.sw"(struct pr_t region) to > indicate this kind of feature. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 14 ++++++--- > xen/arch/arm/mm_mpu.c | 47 +++++++++++++++++++++++++--- > 2 files changed, 53 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index b85e420a90..0044bbf05d 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -45,22 +45,26 @@ > * [3:4] Execute Never > * [5:6] Access Permission > * [7] Region Present > - * [8] Boot-only Region > + * [8:9] 0b00: Fixed Region; 0b01: Boot-only Region; > + * 0b10: Region needs switching out/in during vcpu context switch; > */ > #define _REGION_AI_BIT 0 > #define _REGION_XN_BIT 3 > #define _REGION_AP_BIT 5 > #define _REGION_PRESENT_BIT 7 > -#define _REGION_BOOTONLY_BIT 8 > +#define _REGION_TRANSIENT_BIT 8 > #define _REGION_XN (2U << _REGION_XN_BIT) > #define _REGION_RO (2U << _REGION_AP_BIT) > #define _REGION_PRESENT (1U << _REGION_PRESENT_BIT) > -#define _REGION_BOOTONLY (1U << _REGION_BOOTONLY_BIT) > +#define _REGION_BOOTONLY (1U << _REGION_TRANSIENT_BIT) > +#define _REGION_SWITCH (2U << _REGION_TRANSIENT_BIT) > #define REGION_AI_MASK(x) (((x) >> _REGION_AI_BIT) & 0x7U) > #define REGION_XN_MASK(x) (((x) >> _REGION_XN_BIT) & 0x3U) > #define REGION_AP_MASK(x) (((x) >> _REGION_AP_BIT) & 0x3U) > #define REGION_RO_MASK(x) (((x) >> _REGION_AP_BIT) & 0x2U) > #define REGION_BOOTONLY_MASK(x) (((x) >> _REGION_BOOTONLY_BIT) & 0x1U) > +#define REGION_SWITCH_MASK(x) (((x) >> _REGION_TRANSIENT_BIT) & 0x2U) > +#define REGION_TRANSIENT_MASK(x) (((x) >> _REGION_TRANSIENT_BIT) & 0x3U) > > /* > * _REGION_NORMAL is convenience define. It is not meant to be used > @@ -73,6 +77,7 @@ > > #define REGION_HYPERVISOR REGION_HYPERVISOR_RW > #define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) > +#define REGION_HYPERVISOR_SWITCH (REGION_HYPERVISOR_RW|_REGION_SWITCH) > > #define INVALID_REGION (~0UL) > > @@ -98,7 +103,8 @@ typedef union { > unsigned long ns:1; /* Not-Secure */ > unsigned long res:1; /* Reserved 0 by hardware */ > unsigned long limit:42; /* Limit Address */ > - unsigned long pad:16; > + unsigned long pad:15; > + unsigned long sw:1; /* Region gets switched out/in during vcpu context switch? */ > } reg; > uint64_t bits; > } prlar_t; > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 7b282be4fb..d2e19e836c 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -71,6 +71,10 @@ static paddr_t dtb_paddr; > > struct page_info *frame_table; > > +static const unsigned int mpu_section_mattr[MSINFO_MAX] = { > + REGION_HYPERVISOR_SWITCH, > +}; > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -414,10 +418,13 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > if ( system_state <= SYS_STATE_active ) > { > /* > - * If it is a boot-only region (i.e. region for early FDT), > - * it shall be added from the tail for late init re-organizing > + * If it is a transient region, including boot-only region > + * (i.e. region for early FDT), and region which needs switching > + * in/out during vcpu context switch(i.e. region for guest memory > + * section), it shall be added from the tail for late init > + * re-organizing > */ > - if ( REGION_BOOTONLY_MASK(flags) ) > + if ( REGION_TRANSIENT_MASK(flags) ) Please introduce REGION_TRANSIENT_MAKS() from the start. > idx = next_transient_region_idx; > else > idx = next_fixed_region_idx; > @@ -427,6 +434,13 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > /* Set permission */ > xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); > xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); > + /* > + * Bit sw indicates that region gets switched out when idle vcpu > + * leaving hypervisor mode, and region gets switched in when idle vcpu > + * entering hypervisor mode. > + */ The idle vCPU will never exit the hypervisor mode. In that fact vCPU only exists for the scheduling purpose. So I don't quite understand this comment. > + if ( REGION_SWITCH_MASK(flags) ) > + xen_mpumap[idx].prlar.reg.sw = 1; > > /* Update and enable the region */ > access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), > @@ -552,6 +566,29 @@ static void __init setup_staticheap_mappings(void) > } > } > > +static void __init map_mpu_memory_section_on_boot(enum mpu_section_info type, > + unsigned int flags) > +{ > + unsigned int i = 0; > + > + for ( ; i < mpuinfo.sections[type].nr_banks; i++ ) > + { > + paddr_t start = round_pgup( > + mpuinfo.sections[type].bank[i].start); > + paddr_t size = round_pgdown(mpuinfo.sections[type].bank[i].size); I think it would be better if we force the address to be aligned in the Device-Tree. This will avoid the user to chase why a part of the region is not mapped. > + > + /* > + * Map MPU memory section with transient MPU memory region, > + * as they are either boot-only, or will be switched out/in > + * during vcpu context switch(i.e. guest memory section). > + */ > + if ( map_pages_to_xen(start, maddr_to_mfn(start), size >> PAGE_SHIFT, > + flags) ) > + panic("mpu: failed to map MPU memory section %s\n", > + mpu_section_info_str[type]); > + } > +} > + > /* > * System RAM is statically partitioned into different functionality > * section in Device Tree, including static xenheap, guest memory > @@ -563,7 +600,9 @@ void __init setup_static_mappings(void) > { > setup_staticheap_mappings(); > > - /* TODO: guest memory section, device memory section, boot-module section, etc */ > + for ( uint8_t i = MSINFO_GUEST; i < MSINFO_MAX; i++ ) > + map_mpu_memory_section_on_boot(i, mpu_section_mattr[i]); > + /* TODO: device memory section, boot-module section, etc */ > } > > /* Map a frame table to cover physical addresses ps through pe */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 10:57:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 10:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492324.761815 (Exim 4.92) (envelope-from ) id 1pQ4cG-0005xc-5D; Thu, 09 Feb 2023 10:57:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492324.761815; Thu, 09 Feb 2023 10:57:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4cG-0005xV-2R; Thu, 09 Feb 2023 10:57:24 +0000 Received: by outflank-mailman (input) for mailman id 492324; Thu, 09 Feb 2023 10:57:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4cE-0005xP-LC for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 10:57:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4cE-0001Hu-Bp; Thu, 09 Feb 2023 10:57:22 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ4cE-0004iR-52; Thu, 09 Feb 2023 10:57:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=j0FaGNS3xdMcRAsMtJE5NepljQ1PXXzMJg/bIWAoLww=; b=j0Y6yimnFW1ekkk0QHGxBRH8No zoj/ZLA1iXehmqa0w5zTkDZ1CglbMt6nd03cQGF9ykv49XY/k3bys5+G9kqZ03uLhpNwLhVMFf+qx XKWsskfbuHSyldy8/RxKHOOwWT8oCCd9lUhppNJF+YQO+WQaS1e9VABkswyN9J30TWB8=; Message-ID: <7ac6e234-0b1f-fdb0-bc21-90776b6a9d2f@xen.org> Date: Thu, 9 Feb 2023 10:57:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 26/40] xen/mpu: destroy an existing entry in Xen MPU memory mapping table Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-27-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-27-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:28, Penny Zheng wrote: > This commit expands xen_mpumap_update/xen_mpumap_update_entry to include > destroying an existing entry. > > We define a new helper "control_xen_mpumap_region_from_index" to enable/disable > the MPU region based on index. If region is within [0, 31], we could quickly > disable the MPU region through PRENR_EL2 which provides direct access to the > PRLAR_EL2.EN bits of EL2 MPU regions. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 20 ++++++ > xen/arch/arm/include/asm/arm64/sysregs.h | 3 + > xen/arch/arm/mm_mpu.c | 77 ++++++++++++++++++++++-- > 3 files changed, 95 insertions(+), 5 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index 0044bbf05d..c1dea1c8e9 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -16,6 +16,8 @@ > */ > #define ARM_MAX_MPU_MEMORY_REGIONS 255 > > +#define MPU_PRENR_BITS 32 > + > /* Access permission attributes. */ > /* Read/Write at EL2, No Access at EL1/EL0. */ > #define AP_RW_EL2 0x0 > @@ -132,6 +134,24 @@ typedef struct { > _pr->prlar.reg.en; \ > }) > > +/* > + * Access to get base address of MPU protection region(pr_t). > + * The base address shall be zero extended. > + */ > +#define pr_get_base(pr) ({ \ > + pr_t *_pr = pr; \ > + (uint64_t)_pr->prbar.reg.base << MPU_REGION_SHIFT; \ > +}) Can this be a static inline? > + > +/* > + * Access to get limit address of MPU protection region(pr_t). > + * The limit address shall be concatenated with 0x3f. > + */ > +#define pr_get_limit(pr) ({ \ > + pr_t *_pr = pr; \ > + (uint64_t)((_pr->prlar.reg.limit << MPU_REGION_SHIFT) | 0x3f); \ > +}) Same. > + > #endif /* __ASSEMBLY__ */ > > #endif /* __ARM64_MPU_H__ */ > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index aca9bca5b1..c46daf6f69 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -505,6 +505,9 @@ > /* MPU Type registers encode */ > #define MPUIR_EL2 S3_4_C0_C0_4 > > +/* MPU Protection Region Enable Register encode */ > +#define PRENR_EL2 S3_4_C6_C1_1 > + > #endif > > /* Access to system registers */ > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index d2e19e836c..3a0d110b13 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -385,6 +385,45 @@ static int mpumap_contain_region(pr_t *mpu, uint64_t nr_regions, > return MPUMAP_REGION_FAILED; > } > > +/* Disable or enable EL2 MPU memory region at index #index */ > +static void control_mpu_region_from_index(uint64_t index, bool enable) > +{ > + pr_t region; > + > + access_protection_region(true, ®ion, NULL, index); > + if ( (region_is_valid(®ion) && enable) || > + (!region_is_valid(®ion) && !enable) ) You could write: !(region_is_valid(®ion) ^ enable) > + { > + printk(XENLOG_WARNING > + "mpu: MPU memory region[%lu] is already %s\n", index, > + enable ? "enabled" : "disabled"); > + return; > + } > + > + /* > + * ARM64v8R provides PRENR_EL2 to have direct access to the > + * PRLAR_EL2.EN bits of EL2 MPU regions from 0 to 31. > + */ > + if ( index < MPU_PRENR_BITS ) > + { > + uint64_t orig, after; > + > + orig = READ_SYSREG(PRENR_EL2); > + if ( enable ) > + /* Set respective bit */ > + after = orig | (1UL << index); > + else > + /* Clear respective bit */ > + after = orig & (~(1UL << index)); > + WRITE_SYSREG(after, PRENR_EL2); Don't you need an isb (or similar) to ensure this is visible before... > + } > + else > + { > + region.prlar.reg.en = enable ? 1 : 0; > + access_protection_region(false, NULL, (const pr_t*)®ion, index); > + } > +} > + > /* > * Update an entry at the index @idx. > * @base: base address > @@ -449,6 +488,30 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > if ( system_state <= SYS_STATE_active ) > update_boot_xen_mpumap_idx(idx); > } > + else > + { > + /* > + * Currently, we only support destroying a *WHOLE* MPU memory region, > + * part-region removing is not supported, as in worst case, it will > + * lead to two fragments in result after destroying. > + * part-region removing will be introduced only when actual usage > + * comes. > + */ > + if ( rc == MPUMAP_REGION_INCLUSIVE ) > + { > + region_printk("mpu: part-region removing is not supported\n"); > + return -EINVAL; > + } > + > + /* We are removing the region */ > + if ( rc != MPUMAP_REGION_FOUND ) > + return -EINVAL; > + > + control_mpu_region_from_index(idx, false); > + > + /* Clear the according MPU memory region entry.*/ > + memset(&xen_mpumap[idx], 0, sizeof(pr_t)); ... zeroing the entry? Also, you could use memzero() here. > + } > > return 0; > } > @@ -589,6 +652,15 @@ static void __init map_mpu_memory_section_on_boot(enum mpu_section_info type, > } > } > > +int destroy_xen_mappings(unsigned long s, unsigned long e) > +{ > + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > + ASSERT(s <= e); > + > + return xen_mpumap_update(s, e, 0); > +} > + > /* > * System RAM is statically partitioned into different functionality > * section in Device Tree, including static xenheap, guest memory > @@ -656,11 +728,6 @@ void *ioremap(paddr_t pa, size_t len) > return NULL; > } > > -int destroy_xen_mappings(unsigned long s, unsigned long e) > -{ > - return -ENOSYS; > -} > - > int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) > { > return -ENOSYS; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:01:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492331.761826 (Exim 4.92) (envelope-from ) id 1pQ4fu-0007No-Lb; Thu, 09 Feb 2023 11:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492331.761826; Thu, 09 Feb 2023 11:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4fu-0007Nh-Ic; Thu, 09 Feb 2023 11:01:10 +0000 Received: by outflank-mailman (input) for mailman id 492331; Thu, 09 Feb 2023 11:01:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4ft-0007Nb-Eh for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:01:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4fn-0001Oh-SN; Thu, 09 Feb 2023 11:01:03 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ4fn-0004zR-Lu; Thu, 09 Feb 2023 11:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RW106rl1fQFXuUIoFYfUQuUJuq0X/pDgQA2BjdR4iCc=; b=SVpGzDQZgqqy60qrbYCq7Ts67a 0BEOPV5it88qYHoDXwyxoRoAx3eUOJVFyijmFJpIE0SwUsWeQjGSpCyUtZND/EOOZYppq9+KdJ6J+ s8DaiTqwgm2suqW/pZEQddMCGH6GlHlF3bb0FOFj4NUfybi/Y8BmOp801Mm9d1E7Oaq0=; Message-ID: <76b615ea-f899-76fb-6e50-98bd071ebf60@xen.org> Date: Thu, 9 Feb 2023 11:01:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system Content-Language: en-US To: Jan Beulich , Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-32-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 10:10, Jan Beulich wrote: > On 13.01.2023 06:29, Penny Zheng wrote: >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -13,9 +13,10 @@ config ARM >> def_bool y >> select HAS_ALTERNATIVE if !ARM_V8R >> select HAS_DEVICE_TREE >> + select HAS_FIXMAP if !ARM_V8R >> select HAS_PASSTHROUGH >> select HAS_PDX >> - select HAS_PMAP >> + select HAS_PMAP if !ARM_V8R >> select IOMMU_FORCE_PT_SHARE >> select HAS_VMAP if !ARM_V8R > > Thinking about it - wouldn't it make sense to fold HAS_VMAP and HAS_FIXMAP > into a single HAS_MMU? I think it would make sense. Furthermore, this patch would be better towards the start of the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:15:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:15:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492337.761837 (Exim 4.92) (envelope-from ) id 1pQ4t6-0000g0-R1; Thu, 09 Feb 2023 11:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492337.761837; Thu, 09 Feb 2023 11:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4t6-0000ft-OB; Thu, 09 Feb 2023 11:14:48 +0000 Received: by outflank-mailman (input) for mailman id 492337; Thu, 09 Feb 2023 11:14:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4t5-0000fn-1A for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:14:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4t4-0001d6-77; Thu, 09 Feb 2023 11:14:46 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ4t3-0005dm-Uz; Thu, 09 Feb 2023 11:14:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0zkqc/e7rF276KWQ2dyibDzBtDXzSZp2UNgONOSp1ts=; b=m+4Ya6y3Hwn8MWzGm7K71eeKdr cF3U8nVSBfoKT7IPx78l40eN6GSNSMaOS/+L4UR/LzbqR1vv3pAFvxcxBzaO8zzFdYzShRuqijBSP nj9RsQG02jvvq1wdpH+dcZX0YznAnSoKkeSAhfNdD1BlR0vjM4H34UAg9D3o4Fxvn/5M=; Message-ID: <967734ca-4792-6b39-07c9-c850815a289c@xen.org> Date: Thu, 9 Feb 2023 11:14:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 32/40] xen/mpu: implement MPU version of ioremap_xxx Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-33-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-33-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 05:29, Penny Zheng wrote: > Function ioremap_xxx is normally being used to remap device address ranges > in MMU system during device driver initialization. > > However, in MPU system, virtual translation is not supported and > device memory layout is statically configured in Device Tree, and being mapped > at very early stage. > So here we only add a check to verify this assumption. > > But for tolerating a few cases where the function is called to map for > temporary copy and paste, like ioremap_wc in kernel image loading, the > region attribute mismatch will be treated as warning than error. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/include/asm/arm64/mpu.h | 1 + > xen/arch/arm/include/asm/mm.h | 16 ++++- > xen/arch/arm/include/asm/mm_mpu.h | 2 + > xen/arch/arm/mm_mpu.c | 88 ++++++++++++++++++++++++---- > xen/include/xen/vmap.h | 12 ++++ > 5 files changed, 106 insertions(+), 13 deletions(-) > > diff --git a/xen/arch/arm/include/asm/arm64/mpu.h b/xen/arch/arm/include/asm/arm64/mpu.h > index 8e8679bc82..b4e50a9a0e 100644 > --- a/xen/arch/arm/include/asm/arm64/mpu.h > +++ b/xen/arch/arm/include/asm/arm64/mpu.h > @@ -82,6 +82,7 @@ > #define REGION_HYPERVISOR_BOOT (REGION_HYPERVISOR_RW|_REGION_BOOTONLY) > #define REGION_HYPERVISOR_SWITCH (REGION_HYPERVISOR_RW|_REGION_SWITCH) > #define REGION_HYPERVISOR_NOCACHE (_REGION_DEVICE|MT_DEVICE_nGnRE|_REGION_SWITCH) > +#define REGION_HYPERVISOR_WC (_REGION_DEVICE|MT_NORMAL_NC) > > #define INVALID_REGION (~0UL) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 7969ec9f98..fa44cfc50d 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -14,6 +14,10 @@ > # error "unknown ARM variant" > #endif > > +#if defined(CONFIG_HAS_MPU) > +# include > +#endif > + > /* Align Xen to a 2 MiB boundary. */ > #define XEN_PADDR_ALIGN (1 << 21) > > @@ -198,19 +202,25 @@ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); > /* map a physical range in virtual memory */ > void __iomem *ioremap_attr(paddr_t start, size_t len, unsigned int attributes); > > +#ifndef CONFIG_HAS_MPU > +#define DEFINE_ATTRIBUTE(var) (PAGE_##var) > +#else > +#define DEFINE_ATTRIBUTE(var) (REGION_##var) > +#endif The macro implies that part of the naming would be common between the MPU and MMU code. So I think it would be better if the full name is the shared. My preference would be to go with PAGE_* as this is used for both x86 and MMU arm. I think the naming would still be OK on the MPU because, AFAICT, you still map at a page granularity (or aligned to). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:23:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492343.761848 (Exim 4.92) (envelope-from ) id 1pQ51l-0002JE-OB; Thu, 09 Feb 2023 11:23:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492343.761848; Thu, 09 Feb 2023 11:23:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51l-0002J7-LN; Thu, 09 Feb 2023 11:23:45 +0000 Received: by outflank-mailman (input) for mailman id 492343; Thu, 09 Feb 2023 11:23:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51k-0002J1-H5 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:23:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35cd24b9-a86c-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 12:23:43 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AAEC05C830; Thu, 9 Feb 2023 11:23:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 30D901339E; Thu, 9 Feb 2023 11:23:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XWZfCr7X5GNtPAAAMHmgww (envelope-from ); Thu, 09 Feb 2023 11:23:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35cd24b9-a86c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675941822; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YZDBQEJqdfzaqhG2vhc/FlqleNU9E8m2vwmBY9M2pBs=; b=dZdZmNv5wXxkGx7h2v4aY9ZeNCOc6+hJNfbWm9lZFd6KenT7OFYtpkuMqoDRFZpD1FerAm x5f+S3JjtwGgJ9EaLRFKl/+MZJw3m++xSaamPoXqslX06aIcPcZmzSameVMsiUxaH6B5d2 CBqKRpVVmCZWbjBg1vGix1xQXsu/sY4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org, Juergen Gross Subject: [PATCH v4 0/2 RESEND] xen/public move and fix 9pfs documentation Date: Thu, 9 Feb 2023 12:23:36 +0100 Message-Id: <20230209112338.26287-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Resend of the remaining 2 patches adding some more people to Cc: Changes in V4: - patch split into 3 patches Juergen Gross (2): xen/public: fix 9pfs Xenstore entry documentation xen/public: fix 9pfs documentation of connection sequence xen/include/public/io/9pfs.h | 44 +++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 16 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:23:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492344.761859 (Exim 4.92) (envelope-from ) id 1pQ51s-0002af-4V; Thu, 09 Feb 2023 11:23:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492344.761859; Thu, 09 Feb 2023 11:23:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51s-0002aT-15; Thu, 09 Feb 2023 11:23:52 +0000 Received: by outflank-mailman (input) for mailman id 492344; Thu, 09 Feb 2023 11:23:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51q-0002Zd-Fg for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:23:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38fe8b53-a86c-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 12:23:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 56FF35C833; Thu, 9 Feb 2023 11:23:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A1451339E; Thu, 9 Feb 2023 11:23:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dFbyBMTX5GN9PAAAMHmgww (envelope-from ); Thu, 09 Feb 2023 11:23:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38fe8b53-a86c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675941828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIKqSOQIHwMFBZvx0nM7IWyLZBtpfrkRHMl2wjqjT3E=; b=IwewnNqTk3JobxZe6TSwZ4V1BTOCmwaP1HnJByDYdSpVU7YFTBJlqOkOijfcEgVvpmbQQ8 hNmMqF5h4Ri9IoPsuUjYpPv7IvbuAR5GzjZFpTTkUFbdx0Ns9SzLstxiS2eOhvTdYwG15K CzNoCFenAB/ZF+d+BbtDTdAlsQKSFAY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org, Juergen Gross Subject: [PATCH v4 1/2 RESEND] xen/public: fix 9pfs Xenstore entry documentation Date: Thu, 9 Feb 2023 12:23:37 +0100 Message-Id: <20230209112338.26287-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230209112338.26287-1-jgross@suse.com> References: <20230209112338.26287-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In xen/include/public/io/9pfs.h the documentation regarding the Xenstore entries isn't reflecting reality: the "tag" Xenstore entry is on the frontend side, not on the backend one. Signed-off-by: Juergen Gross --- V4: - patch split off (Julien Grall) --- xen/include/public/io/9pfs.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/include/public/io/9pfs.h b/xen/include/public/io/9pfs.h index 5dad0db869..617ad9afd7 100644 --- a/xen/include/public/io/9pfs.h +++ b/xen/include/public/io/9pfs.h @@ -64,12 +64,6 @@ * * Host filesystem path to share. * - * tag - * Values: - * - * Alphanumeric tag that identifies the 9pfs share. The client needs - * to know the tag to be able to mount it. - * * security-model * Values: "none" * @@ -106,6 +100,12 @@ * map a page with information to setup a share ring. One for each * ring. * + * tag + * Values: + * + * Alphanumeric tag that identifies the 9pfs share. The client needs + * to know the tag to be able to mount it. + * ****************************************************************************** * State Machine ****************************************************************************** -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:23:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492345.761870 (Exim 4.92) (envelope-from ) id 1pQ51w-0002tM-CR; Thu, 09 Feb 2023 11:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492345.761870; Thu, 09 Feb 2023 11:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51w-0002tF-9V; Thu, 09 Feb 2023 11:23:56 +0000 Received: by outflank-mailman (input) for mailman id 492345; Thu, 09 Feb 2023 11:23:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ51u-0002J1-Q2 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:23:54 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c5783f4-a86c-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 12:23:54 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 055735C830; Thu, 9 Feb 2023 11:23:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C222E1339E; Thu, 9 Feb 2023 11:23:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4G8qLsnX5GONPAAAMHmgww (envelope-from ); Thu, 09 Feb 2023 11:23:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c5783f4-a86c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675941834; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l9hWyX1xxO2Hr5xWFMrMhIclyrLkWDLxq1LOLbj+I4I=; b=cnhgXp3QLOM22dAa7iRHOVdKpkMg18w1JaOg3jmcq2AVgi8YWHZcTkRa1ICbbL190fAENl ToyEe2sNNx6IUFhuH49oVwBp/dCk0HRnTCxLSUjzcmJB348wrE/2pESJP9WwSqV1PXYBs8 GJAh7ysO0cVYdUy1dsEGJ+znJl0Bttc= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org, Juergen Gross Subject: [PATCH v4 2/2 RESEND] xen/public: fix 9pfs documentation of connection sequence Date: Thu, 9 Feb 2023 12:23:38 +0100 Message-Id: <20230209112338.26287-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230209112338.26287-1-jgross@suse.com> References: <20230209112338.26287-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The documented connection sequence in xen/include/public/io/9pfs.h has a bug: the frontend needs to wait for the backend to have published its features before being able to allocate its rings and event-channels. While correcting that, make it clear that there might be multiple rings and event-channels by adding "(s)". Signed-off-by: Juergen Gross --- V4: - patch split off (Julien Grall) --- xen/include/public/io/9pfs.h | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/xen/include/public/io/9pfs.h b/xen/include/public/io/9pfs.h index 617ad9afd7..a0ce82d0a8 100644 --- a/xen/include/public/io/9pfs.h +++ b/xen/include/public/io/9pfs.h @@ -114,14 +114,26 @@ * * *Front* *Back* * XenbusStateInitialising XenbusStateInitialising - * - Query virtual device - Query backend device - * properties. identification data. - * - Setup OS device instance. - Publish backend features - * - Allocate and initialize the and transport parameters - * request ring. | - * - Publish transport parameters | - * that will be in effect during V - * this connection. XenbusStateInitWait + * - Query backend device + * identification data. + * - Publish backend features + * and transport parameters. + * | + * | + * V + * XenbusStateInitWait + * + * - Query virtual device + * properties. + * - Query backend features and + * transport parameters. + * - Setup OS device instance. + * - Allocate and initialize the + * request ring(s) and + * event-channel(s). + * - Publish transport parameters + * that will be in effect during + * this connection. * | * | * V @@ -129,8 +141,8 @@ * * - Query frontend transport * parameters. - * - Connect to the request ring and - * event channel. + * - Connect to the request ring(s) + * and event channel(s). * | * | * V -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:27:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:27:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492366.761881 (Exim 4.92) (envelope-from ) id 1pQ555-0004BB-Sr; Thu, 09 Feb 2023 11:27:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492366.761881; Thu, 09 Feb 2023 11:27:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ555-0004B4-Q9; Thu, 09 Feb 2023 11:27:11 +0000 Received: by outflank-mailman (input) for mailman id 492366; Thu, 09 Feb 2023 11:27:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ554-0004Aw-Mj for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:27:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ554-00025G-5m; Thu, 09 Feb 2023 11:27:10 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ553-000625-VR; Thu, 09 Feb 2023 11:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=l8xKBW3Ps51StnTZpqRDWsODFvx92XlF9VFH9umiv1M=; b=rzdiFBmXxnDQw/4rtlbAh0bcco qlF7a1G996ltGhiykGOzA9JTAF6zRj/CdZRcqUh0y9XSZtLXzciaCdIc7dROPKQODhe9KPIdxKvmS d8uiVZHZ3D5tcx7sKP7sdzV+0inD/6tjf5fZMAuCnF1+AYWC+vTxKYvTNQd5TJn0JnGY=; Message-ID: Date: Thu, 9 Feb 2023 11:27:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 34/40] xen/mpu: free init memory in MPU system Content-Language: en-US To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-35-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20230113052914.3845596-35-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/01/2023 05:29, Penny Zheng wrote: > This commit implements free_init_memory in MPU system, trying to keep > the same strategy with MMU system. > > In order to inserting BRK instruction into init code section, which > aims to provok a fault on purpose, we should change init code section > permission to RW at first. > Function modify_xen_mappings is introduced to modify permission of the > existing valid MPU memory region. > > Then we nuke the instruction cache to remove entries related to init > text. > At last, we destroy these two MPU memory regions referring init text and > init data using destroy_xen_mappings. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > --- > xen/arch/arm/mm_mpu.c | 85 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 83 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/mm_mpu.c b/xen/arch/arm/mm_mpu.c > index 0b720004ee..de0c7d919a 100644 > --- a/xen/arch/arm/mm_mpu.c > +++ b/xen/arch/arm/mm_mpu.c > @@ -20,6 +20,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -77,6 +78,8 @@ static const unsigned int mpu_section_mattr[MSINFO_MAX] = { > REGION_HYPERVISOR_BOOT, > }; > > +extern char __init_data_begin[], __init_end[]; Now we have two places define __init_end as extern. Can this instead be defined in setup.h? > + > /* Write a MPU protection region */ > #define WRITE_PROTECTION_REGION(sel, pr, prbar_el2, prlar_el2) ({ \ > uint64_t _sel = sel; \ > @@ -443,8 +446,41 @@ static int xen_mpumap_update_entry(paddr_t base, paddr_t limit, > if ( rc == MPUMAP_REGION_OVERLAP ) > return -EINVAL; > > + /* We are updating the permission. */ > + if ( (flags & _REGION_PRESENT) && (rc == MPUMAP_REGION_FOUND || > + rc == MPUMAP_REGION_INCLUSIVE) ) > + { > + > + /* > + * Currently, we only support modifying a *WHOLE* MPU memory region, > + * part-region modification is not supported, as in worst case, it will > + * lead to three fragments in result after modification. > + * part-region modification will be introduced only when actual usage > + * come > + */ > + if ( rc == MPUMAP_REGION_INCLUSIVE ) > + { > + region_printk("mpu: part-region modification is not supported\n"); > + return -EINVAL; > + } > + > + /* We don't allow changing memory attributes. */ > + if (xen_mpumap[idx].prlar.reg.ai != REGION_AI_MASK(flags) ) > + { > + region_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", > + xen_mpumap[idx].prlar.reg.ai, REGION_AI_MASK(flags)); > + return -EINVAL; > + } > + > + /* Set new permission */ > + xen_mpumap[idx].prbar.reg.ap = REGION_AP_MASK(flags); > + xen_mpumap[idx].prbar.reg.xn = REGION_XN_MASK(flags); > + > + access_protection_region(false, NULL, (const pr_t*)(&xen_mpumap[idx]), > + idx); > + } > /* We are inserting a mapping => Create new region. */ > - if ( flags & _REGION_PRESENT ) > + else if ( flags & _REGION_PRESENT ) > { > if ( rc != MPUMAP_REGION_FAILED ) > return -EINVAL; > @@ -831,11 +867,56 @@ void mmu_init_secondary_cpu(void) > > int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) > { > - return -ENOSYS; > + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > + ASSERT(s <= e); > + return xen_mpumap_update(s, e, flags); > } > > void free_init_memory(void) > { > + /* Kernel init text section. */ > + paddr_t init_text = virt_to_maddr(_sinittext); > + paddr_t init_text_end = round_pgup(virt_to_maddr(_einittext)); > + /* Kernel init data. */ > + paddr_t init_data = virt_to_maddr(__init_data_begin); > + paddr_t init_data_end = round_pgup(virt_to_maddr(__init_end)); > + unsigned long init_section[4] = {(unsigned long)init_text, > + (unsigned long)init_text_end, > + (unsigned long)init_data, > + (unsigned long)init_data_end}; > + unsigned int nr_init = 2; At first, it wasn't obvious what's the 2 meant here. It also seems you expect the number to be in-sync with the one above. I don't think the genericity is necessary here. But if you want it, then it would be better to use an array of structure (begin/end) so you can use ARRAY_SIZE() afterwards and avoid magic like "i * 2". > + uint32_t insn = AARCH64_BREAK_FAULT; AMD is also working on 32-bit ARMv8R support. When it is easy (like) here it would best to avoid making the assumption about 64-bit only. That said, to me it feels like a big part of this code could be shared with the MMU version. > + unsigned int i = 0, j = 0; > + > + /* Change kernel init text section to RW. */ > + modify_xen_mappings((unsigned long)init_text, > + (unsigned long)init_text_end, REGION_HYPERVISOR_RW); > + > + /* > + * From now on, init will not be used for execution anymore, > + * so nuke the instruction cache to remove entries related to init. > + */ > + invalidate_icache_local(); > + > + /* Destroy two MPU memory regions referring init text and init data. */ > + for ( ; i < nr_init; i++ ) > + { > + uint32_t *p; > + unsigned int nr; > + int rc; > + > + i = 2 * i; ... avoid such magic. > + p = (uint32_t *)init_section[i]; > + nr = (init_section[i + 1] - init_section[i]) / sizeof(uint32_t); > + > + for ( ; j < nr ; j++ ) > + *(p + j) = insn; > + > + rc = destroy_xen_mappings(init_section[i], init_section[i + 1]); > + if ( rc < 0 ) > + panic("Unable to remove the init section (rc = %d)\n", rc); > + } > } > > int xenmem_add_to_physmap_one( Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:40:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:40:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492379.761895 (Exim 4.92) (envelope-from ) id 1pQ5Hq-0006mL-2I; Thu, 09 Feb 2023 11:40:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492379.761895; Thu, 09 Feb 2023 11:40:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5Hp-0006mE-Vg; Thu, 09 Feb 2023 11:40:21 +0000 Received: by outflank-mailman (input) for mailman id 492379; Thu, 09 Feb 2023 11:40:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5Ho-0006m8-B5 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:40:20 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 858b44a6-a86e-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 12:40:17 +0100 (CET) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 06:40:12 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by PH0PR03MB5926.namprd03.prod.outlook.com (2603:10b6:510:35::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 11:40:06 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%6]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 11:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 858b44a6-a86e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675942817; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PF7vTThuVCOAUt/1NEGOBbhrKn/lQ2AKokltyd0IAj8=; b=Yt7phZb121aADfszvWt1jeAPfykc2S/p+XvF4XV3e1PvjYCA2wfm18t+ BMhkalEMp1YTJDY9c0stYMkDxkHSREc6cyJha6/fl47g2vAWiyVFZe2pE 2pUgGTLhXxFtv5PN5p4kSvqgEPojAuhqdfDjxh4jTHe7nYNAbD8qiiRft 4=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 98768532 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:fpL92aAugFdMkxVW/+Piw5YqxClBgxIJ4kV8jS/XYbTApGsr1DUPy GNJCD2GbKrZZ2TyL911bo6xpE4B68eExtIwQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlA7wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw//1FKl0f+ s4hCgsBTyCogbPszLSQc7w57igjBJGD0II3nFhFlGmcJ9B5BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/exuuzO7IA9ZidABNPLPfceRA8FckUuCu WvC+0zyAw0ANczZwj2Amp6prr6fwn2rBdlIfFG+3uFTslecwE0zMQ8fcEma/fyplmiEX/sKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwAOQzqvZ5S6JC25CSSROAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnp+LqRuiNC5TKnUNDQcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+91aYhTup/8DNVlRsvl6RWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:Y/L+MaltmHpyaepdFoaH10bDsoDpDfMsimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIa7Sde9qADnhOZICOgqTNGftWzd1FdAQ7sSircKrweQfhEWs9Qtr5 uIEJIOauEYb2IK9voSiTPQe7lPsbq6HbiT5ds2jU0dMD2CA5sQnjuRYTzrbXGeMTM2eabReq DsgvavkwDQCUj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrAHx2Rzn4lIkRyKeNJyw n4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKx334zzYJbhJavmnhnQYseuv4FElnJ 3nuBE7Jfl+7HvXYyWcvQbt4Q/9yzwjgkWSh2NwuUGT4fAReQhKR/apxLgpPycx0nBQ9u2UBZ g7kF5w/vBsfGr9dCeU3am9a/glrDv2nZMYq59ns5Vua/psVFZvl/1swKp0KuZ3IMuo0vFvLA ApNrCW2Mpr X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="98768532" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFh1bluAtKMN5eV29zapSuHwobx81LvXZfTRDHTD0+vCBgXdbIraWlyjA7C0RuVaF9/n9vOlkbgLwLVuhrrK4kTp+r6LouYcuOCLFEvQBdA2AiLJvIr29ifii+SJBRS1aINSp6TPlpOjLRJO6ASRFwWIru4SRaddEMUL0o8Vgp5UoA6ejdSHIthYkS4OGEdTLW9c70kfgQMlhVqsGmmQUOWuVigQAH3ekbSHf13zpGUC/uoIGmY7JTr7ONo1H77Pw++jP6+M5TImdmR1xRmv9LwyfRwz8YPyHUGHuCyq8E4QZimuwaXkEJbmRSP87pc/rPgTUjahnSBGsV/KjKgjUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF7vTThuVCOAUt/1NEGOBbhrKn/lQ2AKokltyd0IAj8=; b=Qpxf0Ejq5D31Oyc4xqeRh5drGG+lEhzPhivbd+U0Nc9UvpGAmfYgH53rkummTMT8MLTVMdNa/Vcjfkya4X82ZJ4WICqYuUrCMCUMYKWYJquO0JI7ZHpZeV8uPg0AQq5JgH455pfoMEZAQ+qKN0XHRfvFEXiFNkTNHaIsdWJ3R71UEffKOUefC/WP0tTbRMKAQCptZEFzXbVgqrgtl9UOoWjPsJze0uN95Mam7p2yvxJ69/8lUlA583fT+ghdw3XtqtfCO87uPIOCDLbmR9jNeCH/B2U56JaIGvzPSCe6eYz60dWOUzcQI/0p3ltrZ0hnsYHxwgF9AvDJNGVybQFKiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF7vTThuVCOAUt/1NEGOBbhrKn/lQ2AKokltyd0IAj8=; b=gHWHE2581p/ANInrJ3csNJqb4osTYqoZOIxeGerVTHLWJr6fDAY48dCxxPDrfAf2mP5utAsBcsG/IhZqo94tizg9BDc+tsDiFzIIFc2d0nTMvnOJWoCBQqtmLqDZCPBD8SAZXvVCW5AWWG02Bl23n+NbTeS0nP9ld3hUkZIuaCI= From: Ross Lagerwall To: Jan Beulich , Anthony Perard CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] build: Make FILE symbol paths consistent Thread-Topic: [PATCH] build: Make FILE symbol paths consistent Thread-Index: AQHZO+JENUXJLbr7Kk6Vg23vMgRDg67GTYoAgAAe+3g= Date: Thu, 9 Feb 2023 11:40:06 +0000 Message-ID: References: <20230208172416.725028-1-ross.lagerwall@citrix.com> <6d281c88-83a0-ee86-18b3-6c9d856a0971@suse.com> In-Reply-To: <6d281c88-83a0-ee86-18b3-6c9d856a0971@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|PH0PR03MB5926:EE_ x-ms-office365-filtering-correlation-id: 09909d5a-fcdf-4157-683b-08db0a92642a x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MTNkqrM/5IOujEEx437cFX7iKcbVS3s6vznyMInzymNF0ahTEfS9I0E4E7IFFagIFd9Ee1JLu/j/x30I9QZlDMSNZKl3fAgFjEHB9cwOVUPl76+zcHfIHizm9OP60oY1jtrK3vKT8yq22ebIp4vBVBIYJzbA8u7VfwNmU2Z/ODA7HcsYSGsGjcvCo/BwdUKJi7Y4P7ffGMmuCk5Q49xtfdGfy2oruHsv0R8t4ptFPhJpGg7yV6CNMmcW/Xo6NDAqa5E7sXhEIUo9yoLqGsioygfwEM1X40kKltCXHHYu7yclb2M9TJ7gWmz3ykk1FWW7mO7zjw/ozmmL8se+6Oz1Z15/MP8D57nKWaoWtSxvuz2SXV8gv41E3dCfqJw25N4Fs9aoCmLlz12LvsgqHcJeLMCfymRB/2unvl07YaQYY1XrzUK6PThz5iE7nFizeRLDtfEoOTYysPEy2Nti0DuS+Z1RfGRmuEn0xJ2uSQNeC5AwTm2+VvZ1IwcAz3iOBAEjngzLqFVHXhDp6jKfHCl+bQPMo3JFCCJHTR2K8ooa6CAsVGkgZSv1bTpVXwERmMJVTuEO/U1gPRttC/CCroVK3zaW3+wGhZQ+kCnjcCOMCVzssd2LorLw0TfE8XA3+4Cd0liu9IWs93Kxr6p/8DsWkZBaUKaRqCOideZXk31vZ5X/vk/g0IWjw/pI0Hk88NRrch9A/KwBkbbbeZqCVCPWYw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199018)(33656002)(82960400001)(38100700002)(86362001)(66946007)(66476007)(66556008)(64756008)(66446008)(91956017)(76116006)(122000001)(55016003)(38070700005)(53546011)(6506007)(186003)(478600001)(9686003)(26005)(7696005)(71200400001)(54906003)(110136005)(6636002)(52536014)(5660300002)(4326008)(8676002)(2906002)(316002)(44832011)(8936002)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?aRWcJ5w/myeQ/SIxG+aM4dCe0/BS5ZWpcK3al7MhzNoyEUUT4cK5Xp7qP3?= =?iso-8859-1?Q?6AJk59Q4BQVB/fruVf6Dy9UoirLO2D7DG4TGL1hMM5Md0OQrjlb00QJEts?= =?iso-8859-1?Q?KPxXJewD1qW9S1+KTGTtVb1JT3PVwIzzCVM7dpyu3+vxGakt+uyYc0rW5W?= =?iso-8859-1?Q?pf8JXu5g18HVQ50avk4ddR9hkmklTHl1cm7xmVvtq5W5AtrtaDHS0NAfCM?= =?iso-8859-1?Q?cHO3aiR/La/omQ9s+GZfwea5KUJMnM/JSizjTZmOT4xfuI3y4o9f/VG1Ct?= =?iso-8859-1?Q?Qmh/SFzntfQSxBllatIirBWj7rp241lSUDbFMIZYKKn5YULq9ZD4rYAFW5?= =?iso-8859-1?Q?GS9+Es0/ocmH1i2nGmO4ubS+2O+A9oAzstVqrQvDWTxm8MlY9ESNqvsDmt?= =?iso-8859-1?Q?1C5F8RwC0pfmdvbU6x2tCh10oKQRdKSj8nwu3ufRu92N1hyrB/EiL0qmpI?= =?iso-8859-1?Q?iBK/CxVwFjO5Gfa6UOFO2WNK6jqQnnwvo5z/3R19cOWQnx2v6H8UYsKxt/?= =?iso-8859-1?Q?MbxeTDe1CDr/V0uRjT2svQumu1rKvjVNhEodw5NuLDWYiFilGl4bn+4Awh?= =?iso-8859-1?Q?jnNtM2FlE6+sX9HdloX1KWZIPuak2GwPy555GAwXqZkVQsqTJvgJ9rfRE6?= =?iso-8859-1?Q?qXq8huZwEYd6L6OSkm0Xz3H4cYvtj8WFnTWa0TLTszumviPpmLttuapxB5?= =?iso-8859-1?Q?PJ7Xlblq7zv6kwO9UQ0oZGLXMZHblKcdVWBuzIwiaSNAvXKr2wXym4xNhv?= =?iso-8859-1?Q?qe1DVYy/SNBpzwB5H/X8YkvDv1eU3WodaCTsYRdcazXG0bHPCKagWZKbLW?= =?iso-8859-1?Q?nAtxdi4maMKZzrrzLfGJupqBAAnMRN/JdHi7vSt/CbU/pXmj2jdYr/tET1?= =?iso-8859-1?Q?8MxZTJl8lDRs6XGIWy1b6YGkbcJlFqynAw/paPV/tqreFVaaUc7NzSNQjc?= =?iso-8859-1?Q?Tiv4X/YCwpJoUwOR7H2/PU4mC1a2H27/IV+/RJZkLEJkC8aODbLJMHieti?= =?iso-8859-1?Q?i+jjWm0PGp2tctaPSQcc7dNg+cGcNHOPW8XtPRWzFPNKnjjjGD7wC2aGrv?= =?iso-8859-1?Q?BiGjEomYbexvrRh5ZuWYra5gcJHnJWbNif3pTxtA3pgUGhvs6lXbP3O2+3?= =?iso-8859-1?Q?toa6QfeuJsJORGFGIY8JTMbJIIbOTmutrVFDVF3YkE1bz5yaOLzHNUh1+H?= =?iso-8859-1?Q?pJsF9MsNT1dts2rtf1u/KN6sH/F0tnXfErUfL4jUTtRIcsYONz7spDuo2s?= =?iso-8859-1?Q?he3uDTd8JisSujMCqDlwN+2v5g/WgFaUYUYmLpxRX8PSS+eNxoD8qp2wDY?= =?iso-8859-1?Q?cH8BvasFf9759rWLrnKULXeMQ05hV1tk/+1plQszdCVjQsWfIPrKFeSk2b?= =?iso-8859-1?Q?TpjA/QE0/dFDxzsokYnt6m8esSOb4p050dnHPEK13Zr28pCkOjL3c6RzXE?= =?iso-8859-1?Q?MNGpixOn+/ERF4JKpx48kvxU+OkYwiBGVqCpBxRBsZgQwujPZpfLXb/g6E?= =?iso-8859-1?Q?SyDdvRfzMykt0PO0uzoqEYBbZEPaGsL38HSzFg9ocHODZuflqNsme8xgbE?= =?iso-8859-1?Q?QJFTdgfeGKqs1tAcUzXMtAZaa/cZgMQ1t9stK/LiEzh8AsGuerijfTPRAK?= =?iso-8859-1?Q?c8+7eWLq7axAbUaQNItYAt9eWerhqboVkP?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WBMs+1g+W6un9nzPMoZt7DBYDqvPus6uWkshowHNGMPuakhmS3m5Hutu9LLgXn+0Mv23+TiRGqaf766L5LZX5V47fXWW9j5wLeJJ2odp2ZMxW95V+HPSsqhb/V+GvSHyCn9vXyqr4KIgJ2x0H/+bDYTAOKybzMnIE48vcGDSQO2tFo7qWHaV+u49E+i2vM0GUmD6xlhcDOIqbLcxYBLq36hFj8mv8OfF78hhrAXU3olCK0ATxGFBXx+hTGug3mQDHHMzS2T0mhkEdhY0DMpxTDS42V414NShtqpKqPgjnt1Gh7DVcPZxVLAdN5RmgPf4gclJWTw11qA7gmGFG1oVH2xZMSom+ZGlqYqvujUijim/3dptFC36EbSSxWcHplZ9cgGZI38suNdVGRrIxveFCaXdabRE/IQV05Kjog7BISxPDH16Z0n5Y30gefqLh23xge7KkTRTVNYduf038oH4d+EnJ3Fl/ySJj04lFAEhM+pSXqZKC5Y17ZVAd18OdLG7yn5gI5fLd4qFSARt6DrpBw4mFdiBocHIHiaBgAhjZVDM9TKzHilhRmslmHqW4Mlacj4v+Ionle5kdiyAW6kZp5YrEyV7Wmpo3hruzQwsUWKQAwrkNvGZNVpFG7jTJ+ho33fMCfVz68sobJ9yOYeAQ6wIRGrhL2kGJyPd/dp3rF9oHWV2LPNuyv/DMQn9XaoUs+zk1B7aRbJEj+bvuIYeOWiPQMLplsYF+b/TYk2qsfPxfqTWXaZYTJCVAad4BcroYxJEtGiKl8czF7GCa+HqY3JLyRzOLpwa/x8EWccXurh8loeikfJQNGW+wHRks7J29VkTdSC8tx7/vEWj7Q5ItPawEVfLTTn347udeNHz6sk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09909d5a-fcdf-4157-683b-08db0a92642a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 11:40:06.4436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 23TbkXp/AnBnkjk4ifrl6cFPSOhl3IA2ljn7BkH4ArTqyxvkW6os9uWHE6j+kQSFTX7eAbz1LYE4k3rOFBsB5PxdtDFTvZLJ4u7rLn67rGA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5926 > From: Jan Beulich =0A= > Sent: Thursday, February 9, 2023 8:44 AM=0A= > To: Ross Lagerwall ; Anthony Perard =0A= > Cc: Andrew Cooper ; George Dunlap ; Julien Grall ; Stefano Stabellini ; Wei Liu ; xen-devel@lists.xenproject.org =0A= > Subject: Re: [PATCH] build: Make FILE symbol paths consistent =0A= > =A0=0A= > On 08.02.2023 18:24, Ross Lagerwall wrote:=0A= > > The FILE symbols in out-of-tree builds may be either a relative path to= =0A= > > the object dir or an absolute path depending on how the build is=0A= > > invoked. Fix the paths for C files so that they are consistent with=0A= > > in-tree builds - the path is relative to the "xen" directory (e.g.=0A= > > common/irq.c).=0A= > > =0A= > > This fixes livepatch builds when the original Xen build was out-of-tree= =0A= > > since livepatch-build always does in-tree builds.=0A= > =0A= > Sounds all plausible, except that I was under the impression that as of= =0A= > 035ab75d8e37 ("build: fix enforce unique symbols for recent clang version= ")=0A= > things were consistent already. To clarify - Anthony, was this aspect=0A= > simply not considered at the time? What would help here is a Fixes: tag,= =0A= > both for the purpose of review and for the purpose of deciding whether to= =0A= > backport. It might be that 7a3bcd2babcc ("build: build everything from th= e=0A= > root dir, use obj=3D$subdir") is to blame, but I'm not really sure.=0A= =0A= 035ab75d8e37 ensures uniqueness for symbols but it doesn't ensure they=0A= are consistent when using out of tree builds, i.e. the FILE symbols are=0A= the same regardless of the value of "O=3D". Since this inconsistency=0A= could only happen after out-of-tree builds were introduced, I guess it=0A= should be:=0A= Fixes: 7115fa562fe7 ("build: adding out-of-tree support to the xen build")= =0A= =0A= > =0A= > > --- a/xen/Rules.mk=0A= > > +++ b/xen/Rules.mk=0A= > > @@ -228,8 +228,9 @@ quiet_cmd_cc_o_c =3D CC=A0=A0=A0=A0=A0 $@=0A= > >=A0 ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)=0A= > >=A0=A0=A0=A0=A0 cmd_cc_o_c =3D $(CC) $(c_flags) -c $< -o $(dot-target).t= mp -MQ $@=0A= > >=A0=A0=A0=A0=A0 ifneq ($(CONFIG_CC_IS_CLANG)$(call clang-ifversion,-lt,6= 00,y),yy)=0A= > =0A= > You're altering only logic for pre-6.0.0 Clang, aiui. This is something= =0A= > that's absolutely necessary to state the latest in the description, but= =0A= > perhaps already in the subject. Among other things that's also an aspect= =0A= > when it comes to considering whether to backport.=0A= =0A= I think that's backwards. The check is: if !(cc_is_clang && clang-version <= 6)=0A= =0A= I can mention in the description that this change doesn't cover older=0A= versions of clang (which presumably have never worked with=0A= livepatch-build-tools since it embeds full paths but that is a separate=0A= issue).=0A= =0A= > =0A= > > +=A0=A0=A0=A0=A0=A0=A0 rel_path =3D $(patsubst $(abs_srctree)/%,%,$(cal= l realpath,$(1)))=0A= > =0A= > Personally I'm against use of underscores when dashes would do, and using= =0A= > a dash here would also be consistent with e.g. ...=0A= > =0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 cmd_objcopy_fix_sym =3D \=0A= > > -=A0=A0=A0=A0=A0=A0=A0=A0 $(OBJCOPY) --redefine-sym $( > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 $(OBJCOPY) --redefine-sym $( >=A0=A0=A0=A0=A0 else=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 cmd_objcopy_fix_sym =3D mv -f $(dot-target).= tmp $@=0A= > >=A0=A0=A0=A0=A0 endif=0A= > =0A= > ... the several visible uses of $(dot-target) here.=0A= =0A= I'm not sure if there is much consistency since other variables like=0A= abs_srctree and abs_objtree also use underscores but I can change it=0A= if you prefer.=0A= =0A= Ross= From xen-devel-bounces@lists.xenproject.org Thu Feb 09 11:45:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 11:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492387.761907 (Exim 4.92) (envelope-from ) id 1pQ5Md-0007dC-P1; Thu, 09 Feb 2023 11:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492387.761907; Thu, 09 Feb 2023 11:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5Md-0007d5-M6; Thu, 09 Feb 2023 11:45:19 +0000 Received: by outflank-mailman (input) for mailman id 492387; Thu, 09 Feb 2023 11:45:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5Mc-0007cy-VZ for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:45:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5Mc-0002S0-JL; Thu, 09 Feb 2023 11:45:18 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ5Mc-0006tl-Ah; Thu, 09 Feb 2023 11:45:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=K7uFwIjAWN/sUvp8ClQquJ09JAmT7kQoYn3AN+LsTLI=; b=iyIWR9yrpRxsQFfPFVyEsA7JMb vK3vCLi7VesXIlxTRYs0vir4fVyHm8J+YsYjt8OznDcXiACAcvGNPI+mVVPYGNQ35RTvr0RaarVVn PppLQcDU3P/we/B4DWPl9LgjnMnHiybg/2M8C3Ip96r8Mu9mO0Bfl1M4rsnQ0B6CZEg8=; Message-ID: <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> Date: Thu, 9 Feb 2023 11:45:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 07/02/2023 15:34, Ayan Kumar Halder wrote: > > On 20/01/2023 11:06, Julien Grall wrote: >> Hi Ayan, > Hi Julien, >> >> On 17/01/2023 17:43, Ayan Kumar Halder wrote: >>> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >>> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >>> "Virtualization Translation Control Register" for the bit descriptions. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> Changes from - >>> >>> v1 - New patch. >>> >>>   xen/arch/arm/p2m.c | 10 +++++++--- >>>   1 file changed, 7 insertions(+), 3 deletions(-) >>> >>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>> index 948f199d84..cfdea55e71 100644 >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>>       register_t val = >>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>>     #ifdef CONFIG_ARM_32 >>> -    if ( p2m_ipa_bits < 40 ) >>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>>           panic("P2M: Not able to support %u-bit IPA at the moment\n", >>>                 p2m_ipa_bits); >>>   -    printk("P2M: 40-bit IPA\n"); >>> -    p2m_ipa_bits = 40; >>> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >>> +    p2m_ipa_bits = PADDR_BITS; >>> +#ifdef CONFIG_ARM_PA_32 >>> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >>> +#else >>>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>> +#endif >> >> I am wondering whether this is right time to switch to an array like >> the arm64 code? This would allow to use 32-bit IPA also when Xen >> support 64-bit physical address. > > In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the physical > address range supported at runtime. This is then used as an index into > pa_range_info[] to determine t0sz, root_order, etc. It is using both the ID_AA64MMFR0_EL1 but also p2m_ipa_bits to decide the size. > > However, for AArch32 I do not see an equivalent register (similar to > ID_AA64MMFR0_EL1) or any register to determine the physical address > range. Thus, I will prefer to keep the code as it is unless you suggest > any alternative. I looked at the Arm Arm and indeed it doesn't look like there are equivalent for ID_AA64MMFR0_EL1.PARange. However, my point was less about reading the system register but more about the fact we could have the code a bit more generic and avoid the assumption that PADDR_BITS is only modified when CONFIG_ARM_PA_32 is set. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 12:01:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 12:01:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492399.761918 (Exim 4.92) (envelope-from ) id 1pQ5br-0001uA-Ew; Thu, 09 Feb 2023 12:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492399.761918; Thu, 09 Feb 2023 12:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5br-0001u3-BH; Thu, 09 Feb 2023 12:01:03 +0000 Received: by outflank-mailman (input) for mailman id 492399; Thu, 09 Feb 2023 12:01:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5bp-0001tr-UB; Thu, 09 Feb 2023 12:01:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5bp-0002vH-QQ; Thu, 09 Feb 2023 12:01:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5bp-0007GT-FZ; Thu, 09 Feb 2023 12:01:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQ5bp-0002QQ-F7; Thu, 09 Feb 2023 12:01:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Bq2tmO6qQrEiSAHRaEeOC61dCOwlRK+TKC2QlcpQLQs=; b=M0/f7wZuwj7twnlovBc8EknQ5Y Cs1FOp4ITCcARZj5cUE8I/BaA/eHGd7S490bfYjx/s9XAzSny7xy8QgG4uhWteu3tCzzR1y0XJ54N q1Ek05JF+x9BuzCvaPhiRmgEWNdEaxjffo12gFz9XL2PEfubRHMB6jlY76jWbcXjTo1Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176667: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=0983f6bf2bfc0789b51ddf7315f644ff4da50acb X-Osstest-Versions-That: linux=513c1a3d3f1982fb850c910937099525b0d35e24 From: osstest service owner Date: Thu, 09 Feb 2023 12:01:01 +0000 flight 176667 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176667/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176498 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176498 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176498 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176498 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176498 test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 0983f6bf2bfc0789b51ddf7315f644ff4da50acb baseline version: linux 513c1a3d3f1982fb850c910937099525b0d35e24 Last test of basis 176498 2023-02-07 17:26:36 Z 1 days Testing same since 176667 2023-02-08 20:26:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Shevchenko Lad Prabhakar Linus Torvalds Mark Brown Michal Suchanek Rob Herring jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 513c1a3d3f19..0983f6bf2bfc 0983f6bf2bfc0789b51ddf7315f644ff4da50acb -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Feb 09 12:12:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 12:12:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492415.761929 (Exim 4.92) (envelope-from ) id 1pQ5mY-0003iF-FN; Thu, 09 Feb 2023 12:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492415.761929; Thu, 09 Feb 2023 12:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5mY-0003i8-CZ; Thu, 09 Feb 2023 12:12:06 +0000 Received: by outflank-mailman (input) for mailman id 492415; Thu, 09 Feb 2023 12:12:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5mW-0003i2-Fe for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 12:12:04 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4bf1684-a872-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 13:12:02 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4bf1684-a872-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675944722; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=abgN/ZAr8rV/3HOV7E7gPEvQBK2pQRmnd+JqKbakiQQ=; b=MiFMN73kuc5C4CrfwrDhz8BcL5mrRtq1BxdtekGnNu13De7xeIR/sKYr 01mthNFEACaBxJyu0O98tIT7C5dQUgAF3ms+sTUu/SbTZ++wYLmqBRBS/ BgwneZGbxKw3qeYfo4KWpYDY9I3uGGYW6ST+j7CQU2TXY9oQJBT74/Fv9 E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95192122 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:gMz8fKpesvw7ziUkRaqo59/2c5BeBmILZRIvgKrLsJaIsI4StFCzt garIBmCOvyCM2SnKdtxOt+1oxkFuZeHmtUwSQc9+Sk0E34S8puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyhNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACk9fxupptCr+rKiELVpgN4YcsrzYbpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jObpjWjW0tAXDCZ4Suu/lisor+Spwb2SNIfD6G77cZWsXTGkwT/DzVJDADm8JFVkHWWRNZ3O 0ESvC00osAa9kOxScLmdwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDhoj/yLWUx6vvPEyvbr+rK62roYkD5MFPuewcdfRoOyfjRvbszl0iTS9B5K/C2loDMTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4umkWyKRBaJxsldrVj Kj752tsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon4zNR7Jhz68wRJ9+U3aB Xt9WZ38ZZr9If04pAdaus9HieN7rszA7Ty7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Mm +uzw/Cikk0FOMWnO3m/zGLmBQxSRZTNLcys+pM/my/qClYOJVzN/NeInO19IdE4xP0F/goKl 1nkMnJlJJPErSWvAW23hrpLMdsDgb4XQaoHABER IronPort-HdrOrdr: A9a23:+E7dq6rYwNURWiLboU54KvAaV5oieYIsimQD101hICG9E/bo8v xG88526faZslkssRIb6LK90cu7IU80nKQdieN9AV7FZmfbUQOTXeZfBODZsl7d8kPFl9K105 0KT0EEMqyVMWRH X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="95192122" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu , "Juergen Gross" Subject: [XEN PATCH] libs/util: Remove unused headers in libxlu_pci.c Date: Thu, 9 Feb 2023 12:11:40 +0000 Message-ID: <20230209121140.10982-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain libxlu_pci.c doesn't use any "xlu__cfg*()" functions and doesn't use any of the disk parsing functions "xlu__disk*()", so all those headers can be removed. Signed-off-by: Anthony PERARD --- tools/libs/util/libxlu_pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/libs/util/libxlu_pci.c b/tools/libs/util/libxlu_pci.c index 551d8e3aed..294482c6d7 100644 --- a/tools/libs/util/libxlu_pci.c +++ b/tools/libs/util/libxlu_pci.c @@ -3,9 +3,6 @@ #include #include "libxlu_internal.h" -#include "libxlu_disk_l.h" -#include "libxlu_disk_i.h" -#include "libxlu_cfg_i.h" #define XLU__PCI_ERR(_c, _x, _a...) \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 12:12:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 12:12:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492417.761940 (Exim 4.92) (envelope-from ) id 1pQ5mo-00043c-Ng; Thu, 09 Feb 2023 12:12:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492417.761940; Thu, 09 Feb 2023 12:12:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5mo-00043V-KM; Thu, 09 Feb 2023 12:12:22 +0000 Received: by outflank-mailman (input) for mailman id 492417; Thu, 09 Feb 2023 12:12:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ5mn-000433-Ts for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 12:12:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff3a5762-a872-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 13:12:19 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff3a5762-a872-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675944739; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=b/weYmisqByS+WOypNaop0HmptEvzBJtExfdTfUZWBY=; b=BWJeoGD5G7OsQOMfmIZyzgUUgGYo6nB3lcqL2qjxTlryYQdUX4WZJuWm JOOZ1EyfV0GeJEGSTt6jqvHq9ePDBNCZm7F3CnDvRoHHX5WQdmQt+/bDF 46FC+uRaCBgaCR9LZvl+TcRm0YV/VmWf2NRvm17IFFWtGihyS3ybiK5WQ w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95748331 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:uJO91aLUskIzXp0jFE+RwpUlxSXFcZb7ZxGr2PjKsXjdYENS3j0Oy TMXDDyGOK3fNmL1L40gaI3ko00F6sTVzNRlHQNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5ARvPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5rIkd2p M4CdAlcVQmx1/npkImyd/Rj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbGJoJzh3D/ woq+UzYLg4ULs6HwwDY+yuHq9TpngeqZY47QejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 04b4C01toAp6VemCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3PLaXhRzi AXPxYmwQ2Uy7vvMEyn1GqqoQS2aJQszFT4wf3M9HDAc0Yn4/9EIhy/SQYM2eEKqteHdFTb1y jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD3271k5JAVdoKiN2bGKuOGphsRNMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QRP8ghLVfZrXA0NCZ8OlwBdmB3wcnT3 r/CLq6R4YsyU/w7nFJauc9CuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimN4gEAFe/iFyNq b53bpLaoyizpcWiOkE7B6ZPdwFVRZX6bLiqw/Fqmhmre1c4RDt8VqSIkdvMueVNxsxoqwsBx VnlMmcw9bY1rSSvxdmiApy7VI7SYA== IronPort-HdrOrdr: A9a23:Jxl9f6CZMCgueG7lHeml55DYdb4zR+YMi2TDtnoBLCC9Hfb1qy nDppsmPHzP+VQssRMb+exoUZPoKRmwyXcS2+cs1N+ZLW7bUQCTXeJfBOXZogEIHReUygcn79 YFT5RD X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="95748331" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH] libs/util: Fix parallel build between flex/bison and CC rules Date: Thu, 9 Feb 2023 12:11:56 +0000 Message-ID: <20230209121156.11040-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain flex/bison generate two targets, and when those targets are prerequisite of other rules they are considered independently by make. We can have a situation where the .c file is out-of-date but not the .h, git checkout for example. In this case, if a rule only have the .h file as prerequiste, make will procced and start to build the object. In parallel, another target can have the .c file as prerequisite and make will find out it need re-generating and do so, changing the .h at the same time. This parallel task breaks the first one. To avoid this scenario, we put both the header and the source as prerequisite for all object even if they only need the header. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- We could add those new prerequisite as order-only, but since the header is going to be re-generated anyway, the object will be too. I tried to simply have something like "libxlu_cfg_l.h: libxlu_cfg_l.c", but make find it to be a circular dependency. I tried to use grouped target ( &: ) with a recent version of make (4.3), but that didn't work. And we couldn't use it as it's a new feature. As reference, this is the minimum dependencies, as not all object needs all generated headers, but keeping that in sync with source change could be problematique: libxlu_cfg_l.o libxlu_cfg_l.opic: libxlu_cfg_y.h libxlu_cfg_y.o libxlu_cfg_y.opic: libxlu_cfg_l.h libxlu_cfg.o libxlu_cfg.opic: libxlu_cfg_y.h libxlu_cfg_l.h libxlu_disk.o libxlu_disk.opic: libxlu_cfg_y.h libxlu_disk_l.h libxlu_vif.o: libxlu_pci.o: And the .c files prerequisite libxlu_cfg_l.o libxlu_cfg_l.opic: libxlu_cfg_y.c libxlu_cfg_y.o libxlu_cfg_y.opic: libxlu_cfg_l.c libxlu_cfg.o libxlu_cfg.opic: libxlu_cfg_y.c libxlu_cfg_l.c libxlu_disk.o libxlu_disk.opic: libxlu_cfg_y.c libxlu_disk_l.c --- tools/libs/util/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile index 93ebf930a4..8a8c218eb5 100644 --- a/tools/libs/util/Makefile +++ b/tools/libs/util/Makefile @@ -28,6 +28,14 @@ include $(XEN_ROOT)/tools/libs/libs.mk $(OBJS-y) $(PIC_OBJS): $(AUTOINCS) +# Adding the .c conterparts of the headers generated by flex/bison as +# prerequisite of all objects. +# This is to tell make that if only the .c file is out-of-date but not the +# header, it should still wait for the .c file to be rebuilt. +# Otherwise, make doesn't considered "%.c %.h" as grouped targets, and will run +# the flex/bison rules in parallel of CC rules which only need the header. +$(OBJS-y) $(PIC_OBJS): libxlu_cfg_l.c libxlu_cfg_y.c libxlu_disk_l.c + %.c %.h: %.y @rm -f $*.[ch] $(BISON) --output=$*.c $< -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 12:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 12:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492427.761951 (Exim 4.92) (envelope-from ) id 1pQ696-0007Mq-JO; Thu, 09 Feb 2023 12:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492427.761951; Thu, 09 Feb 2023 12:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ696-0007Mj-Gj; Thu, 09 Feb 2023 12:35:24 +0000 Received: by outflank-mailman (input) for mailman id 492427; Thu, 09 Feb 2023 12:35:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ695-0007MN-FW for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 12:35:23 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36d2090b-a876-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 13:35:20 +0100 (CET) Received: by mail-wr1-x430.google.com with SMTP id az16so782604wrb.1 for ; Thu, 09 Feb 2023 04:35:19 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id f8-20020a05600c4e8800b003da28dfdedcsm1998948wmq.5.2023.02.09.04.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 04:35:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36d2090b-a876-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=riU3/BjBr4ZRmoxCxftod6B1mftUjCR8AN/UhtyxNHg=; b=n7fZld7HMYMtJ+GUyuIcR3EWrBhMI5RamoN7cY9ytltaryUCH75Q+tCxZoMhlqagMO /OjukcvSVw56N5ShI+ABOWyQzX+UgH/yMMI6+eJqt/gDBLfEBKH7hnw0PEiN3L5StAPs 1lGYpuzfRqIAxMoLBbyszh80Cr1Yy4PBUg5IfeOxUT0LizAQtUYk+OSSZpe45soqUe7s hV6n9+OS4FUAlAbH2dzXUgSeRTm/Z48BAgq/0nQkghpEjGHsZVT91DZ0L0aXrI48p72L 2Xbqu2EsefM2DtWDQfJSdADVUsmtoe7x/0wK35ZEopIrmWFnQkhC1PNgbMZNPS2eSqfo 1igQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=riU3/BjBr4ZRmoxCxftod6B1mftUjCR8AN/UhtyxNHg=; b=q2tfFYBjGUPG8g3sQ5X8akEk5IzLKlNQ9WHipvXau6KSrCZ7YeZk9sGb2Y6Ou7iiVH 2DiPRxGdtCdAyiSR2MFA3AitxZ8t5aojDV/qXqZUlcNdr6tz2CH5fG+XVXMisADtUmI6 dxFJFXNH7bDFS4fyNSclUn99e0Kn2tSwributjhzcv3N8O/R5WMsIFTwq2W6J3o45/g0 qLlPjPfcT9dl53tYiOyltDuS4Mcl0STh/oTbuuGrUHrVMJNgsC6bxkKULe7UKvTbkNiQ k1xnFJV+VP7URVjK2rickequXJiDHISbg+74JRQSeLcjUV2HfJq1RV2LYjbbGS6f8XU0 6SiQ== X-Gm-Message-State: AO0yUKXwjSpwROZ5Q5m+Jkf/Gmd2FKKVDj2DU84bkDygGAYSFrs9P4YM /ecOFTwhEfEGmMhKbItAi/w= X-Google-Smtp-Source: AK7set/8E7DBXdICQURPYH0qpape6O6ogFkK+POXlXkny4SSpyjjjD1aZuDYZ2WUjRNAIfc/uVq7tg== X-Received: by 2002:adf:e40c:0:b0:2c3:ec55:b1b5 with SMTP id g12-20020adfe40c000000b002c3ec55b1b5mr11500640wrm.15.1675946119358; Thu, 09 Feb 2023 04:35:19 -0800 (PST) Message-ID: <25bd709316631ceac04876b40898d3c970e4ba50.camel@gmail.com> Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from From: Oleksii To: Jan Beulich Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Thu, 09 Feb 2023 14:35:17 +0200 In-Reply-To: <1331e8eb-652a-3bdd-2c98-ee695b03d12a@suse.com> References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> <1331e8eb-652a-3bdd-2c98-ee695b03d12a@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Wed, 2023-02-08 at 15:01 +0100, Jan Beulich wrote: > On 08.02.2023 13:00, Oleksii wrote: > > On Tue, 2023-02-07 at 16:07 +0100, Jan Beulich wrote: > > > On 07.02.2023 15:46, Oleksii Kurochko wrote: > > > > --- /dev/null > > > > +++ b/xen/arch/riscv/include/asm/bug.h > > > > @@ -0,0 +1,38 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > +/* > > > > + * Copyright (C) 2012 Regents of the University of California > > > > + * Copyright (C) 2021-2023 Vates > > > > + * > > > > + */ > > > > +#ifndef _ASM_RISCV_BUG_H > > > > +#define _ASM_RISCV_BUG_H > > > > + > > > > +#include > > > > + > > > > +#ifndef __ASSEMBLY__ > > > > + > > > > +#define BUG_FN_REG t0 > > > > + > > > > +#define BUG_INSTR "ebreak" > > > > + > > > > +#define INSN_LENGTH_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= _UL(0x3) > > > > +#define INSN_LENGTH_32=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 _UL(0x3) > > >=20 > > > I assume these are deliberately over-simplified (not accounting > > > for > > > wider than 32-bit insns in any way)? > > The base instruction set has a fixed length of 32-bit naturally > > aligned > > instructions. > >=20 > > There are extensions of variable length ( where each instruction > > can be > > any number of 16-bit parcels in length ) but they aren't used in > > Xen > > and Linux kernel ( where these definitions were taken from ). >=20 > Can there then please be a comment here about this (current) > assumption? >=20 Sure, I'll do it. > > > > +#define BUG_INSN_32=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 _UL(0x00100073) /* ebreak */ > > > > +#define BUG_INSN_16=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 _UL(0x9002)=C2=A0=C2=A0=C2=A0=C2=A0 /* c.ebreak= */ > > > > +#define COMPRESSED_INSN_MASK=C2=A0=C2=A0=C2=A0 _UL(0xffff) > > > > + > > > > +#define GET_INSN_LENGTH(insn)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > +({=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > +=C2=A0=C2=A0=C2=A0 unsigned long len;=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > > +=C2=A0=C2=A0=C2=A0 len =3D ((insn & INSN_LENGTH_MASK) =3D=3D INSN_= LENGTH_32) ?=C2=A0=C2=A0 \ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 4UL : 2UL;=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 \ > > > > +=C2=A0=C2=A0=C2=A0 len;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > >=20 > > > Any reason for the use of "unsigned long" (not "unsigned int") > > > here? > > >=20 > > There is no specific reason (at least I don't see it now). It looks > > like it can be used here even smaller type than 'unsigned int' as > > len, > > in current case, can be either 4 or 2. >=20 > Often working with more narrow types isn't as efficient, so using > (signed/unsigned) int is generally best unless there are specific > reasons to use a wider or more narrow type. >=20 Thanks for explaining. > > > > @@ -97,7 +98,136 @@ static void do_unexpected_trap(const struct > > > > cpu_user_regs *regs) > > > > =C2=A0=C2=A0=C2=A0=C2=A0 die(); > > > > =C2=A0} > > > > =C2=A0 > > > > +void show_execution_state(const struct cpu_user_regs *regs) > > > > +{ > > > > +=C2=A0=C2=A0=C2=A0 early_printk("implement show_execution_state(re= gs)\n"); > > > > +} > > > > + > > > > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > > > > +{ > > > > +=C2=A0=C2=A0=C2=A0 struct bug_frame *start, *end; > > > > +=C2=A0=C2=A0=C2=A0 struct bug_frame *bug =3D NULL; > > >=20 > > > const? > > regs aren't changed in the function so I decided to put it as > > const. >=20 > Hmm, a misunderstanding? I was asking whether there is a reason not > to have the three local variables be "pointer to const". As a rule > of thumb, const should be added to pointed-to types whenever > possible. > That way it's very obvious even when looking only in passing that the > value/array pointed to isn't supposed to be modified through the > variable (or function parameter). Oh, got it. I though that you wrote about const in "const struct cpu_user_regs *regs". >=20 > > > > +=C2=A0=C2=A0=C2=A0 unsigned int id =3D 0; > > > > +=C2=A0=C2=A0=C2=A0 const char *filename, *predicate; > > > > +=C2=A0=C2=A0=C2=A0 int lineno; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 unsigned long bug_frames[] =3D { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unsigned long)&__start= _bug_frames[0], > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unsigned long)&__stop_= bug_frames_0[0], > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unsigned long)&__stop_= bug_frames_1[0], > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unsigned long)&__stop_= bug_frames_2[0], > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unsigned long)&__stop_= bug_frames_3[0], > > > > +=C2=A0=C2=A0=C2=A0 }; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 for ( id =3D 0; id < BUGFRAME_NR; id++ ) > > > > +=C2=A0=C2=A0=C2=A0 { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start =3D (struct=C2=A0= bug_frame *)bug_frames[id]; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 end =3D (struct=C2=A0 b= ug_frame *)bug_frames[id + 1]; > > >=20 > > > Nit: Stray double blanks. But I'd like to suggest that you get > > > away > > > without casts here in the first place. Such casts are always a > > > certain > > > risk going forward. > > Do you mean that it is better to re-write bug_frame[] to: > > =C2=A0=C2=A0=C2=A0 struct bug_frane bug_frames[] =3D { > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__start_bug_frame[0], > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... >=20 > Yes - the fewer casts the better. Also as per above, as much const as > possible. And I expect the array can actually also be static rather > than living on the stack. Thanks. I'll update with the proposed changes. >=20 > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( start !=3D end = ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= if ( (vaddr_t)bug_loc(start) =3D=3D pc ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 bug =3D start; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 goto found; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= } > > > > + > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= start++; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > > > +=C2=A0=C2=A0=C2=A0 } > > > > + > > > > + found: > > > > +=C2=A0=C2=A0=C2=A0 if ( bug =3D=3D NULL ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOENT; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 if ( id =3D=3D BUGFRAME_run_fn ) > > > > +=C2=A0=C2=A0=C2=A0 { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void (*fn)(const struct= cpu_user_regs *) =3D (void > > > > *)regs- > > > > > BUG_FN_REG; > > > > + > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fn(regs); > > > > + > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto end; > > > > +=C2=A0=C2=A0=C2=A0 } > > > > + > > > > +=C2=A0=C2=A0=C2=A0 /* WARN, BUG or ASSERT: decode the filename poi= nter and > > > > line > > > > number. */ > > > > +=C2=A0=C2=A0=C2=A0 filename =3D bug_file(bug); > > > > +=C2=A0=C2=A0=C2=A0 lineno =3D bug_line(bug); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 switch ( id ) > > > > +=C2=A0=C2=A0=C2=A0 { > > > > +=C2=A0=C2=A0=C2=A0 case BUGFRAME_warn: > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * TODO: change ea= rly_printk's function to > > > > early_printk > > > > with format > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 when s(n)printf() will be added. > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 early_printk("Xen WARN = at "); > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 early_printk(filename); > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 early_printk(":"); > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // early_printk_hnum(li= neno); > > >=20 > > > What's this? At the very least the comment is malformed. > > It's an old code that should be removed. >=20 > Removed? I.e. the line number will never be logged? It will, but: 1. I decided not to provide early_printk_hnum() and focus on getting printk() working. 2. I introduced generic do_bug_frame() [1] (at least, for ARM and RISC- V) so the current implementation will be switched to generic one when panic, printk and find_text_region() (virtual memory) will be ready/merged. It is what I am going to do next. [2] - is a link to patch series with introduction of generic implementation of macros from bug.h. Probably you can look at it too when you will have free time. Thank you so much for your attention and participation. [1] https://lore.kernel.org/xen-devel/8adf4aeff96750982e3d670cb3aed11553d546d5.= 1675441720.git.oleksii.kurochko@gmail.com/ [2] https://lore.kernel.org/xen-devel/?q=3D%22introduce+generic+implementation+= of+macros+from+bug.h%22 >=20 > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Feb 09 12:38:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 12:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492436.761962 (Exim 4.92) (envelope-from ) id 1pQ6Bn-00080H-5k; Thu, 09 Feb 2023 12:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492436.761962; Thu, 09 Feb 2023 12:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6Bn-00080A-2s; Thu, 09 Feb 2023 12:38:11 +0000 Received: by outflank-mailman (input) for mailman id 492436; Thu, 09 Feb 2023 12:38:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6Bm-000804-6Q for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 12:38:10 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b2cb662-a876-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 13:38:08 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id r2so1611470wrv.7 for ; Thu, 09 Feb 2023 04:38:08 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id a6-20020a056000100600b0029a06f11022sm1137073wrx.112.2023.02.09.04.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 04:38:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b2cb662-a876-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DsTtFzjI9O3ilClM1Q3fiW7nVydjW3fsa9s7dJGWl4A=; b=iE04V8b1KruKZTeBZMwpQxHxUGt6vFPwbWnQnoP7jFuZbqyy1sTGVzzBlcckvYW4bi dkwbEm3REJfw2qmbPzvqcupB2gfpbqY6WV11l3w4R5MOkRXaldcMQmw6JfSFNFrwsh8s 1MzU6JM7HOpDuM+O0BAUyyXMX4fBlIbnyUvAkMVqq/1SQE5XN/s8gf0fsWZq3ONKWIk0 5sazI3jnGcdCIJSaEzqMYZO4QNm7hgiAUAb+57J2Q3vdUsavS51RtQlDrRN20vCvJryk lZppayaovkdSlLbjFr8OseOS3/ti/T7Hp8ajNenAuFQ8CrbYNtLb/ClqfJ/GvmFULAZJ QxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DsTtFzjI9O3ilClM1Q3fiW7nVydjW3fsa9s7dJGWl4A=; b=2M2cbJyUsDTckcU1BL5pRQb2Nr52k3HT6EFH3ucEEh9ya6uhdkCK+mMbWrlXsQAX4S M6Zxr/dMpghA681jqOG8CFHZN1chXrYaGnjwIxhJfxHczJgizQAJ8mmbA0UnOBIzMry9 zFJwze/rxUjl6/0qocvYTXtTAf7pa/69eVDaBZ9Lo8ALlquruS4rERutbf5BYnbuQB3F /hEPhlVr4q4Pp22w8ys50ZK0Um0dPZAxTeduqNxX6pLVchMUfwC0BCjiT5Rz2iZjifI7 gnEtHioQC5b8uzCZ4uSYOFZkOFQ/kZyYTJDtSw/ckwErQ4C8KFmWUiDDU5Chwi+p4yz2 aWSA== X-Gm-Message-State: AO0yUKUIPxoursz3Q6n15duUzGky8F+4a02wOjwqqVBSmV0C7xgDhnI3 1gj4JIoJEqFKB3pt5SL09amp7shIqFY= X-Google-Smtp-Source: AK7set/kLF3W042jaX6KoxsZS4+SrboDpFr5dCQJpVETYatE4LtOnx+DyGO3nmKOlzD5kJjls2s7Yg== X-Received: by 2002:adf:dc51:0:b0:2c3:db5b:7278 with SMTP id m17-20020adfdc51000000b002c3db5b7278mr9964339wrj.60.1675946287662; Thu, 09 Feb 2023 04:38:07 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 00/14] RISCV basic exception handling implementation From: Oleksii To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Date: Thu, 09 Feb 2023 14:38:05 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi all, I don't know why but 1 patch was commited as a separate patch: [PATCH v3 07/14] xen/riscv: introduce exception context https://lore.kernel.org/xen-devel/5aa05592497ba9c4d207185d81981442d43ba676.= 1675780434.git.oleksii.kurochko@gmail.com/ ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Feb 09 13:18:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 13:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492446.761973 (Exim 4.92) (envelope-from ) id 1pQ6o6-0004es-4T; Thu, 09 Feb 2023 13:17:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492446.761973; Thu, 09 Feb 2023 13:17:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6o6-0004el-1H; Thu, 09 Feb 2023 13:17:46 +0000 Received: by outflank-mailman (input) for mailman id 492446; Thu, 09 Feb 2023 13:17:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6o3-0004eb-Sk; Thu, 09 Feb 2023 13:17:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6o3-00052A-QT; Thu, 09 Feb 2023 13:17:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ6o3-0000vn-KX; Thu, 09 Feb 2023 13:17:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQ6o3-0008WD-K8; Thu, 09 Feb 2023 13:17:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=a4UhGxwJTESB9RjrOOaNHWi9K/XobKhaacjpWw/GHj0=; b=EgxDEffBHvFvTlSGzu+jsHpNxk PVLeYafRQDUMNrcj8NzE0WCWZi5cTEAiiha9xjqqQt4CDSBaBNGb722jj7i2xRwbSFWME27UFFAU2 bsLBYBdnS1WTrbThSb4RgaaDrK/ezxx4OmMq6wcYkY+agmYGjoLVtlCPvyCa1aNF8mKU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176733: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e1528c54d3c44e50f0460f1ff721a876c81479b9 X-Osstest-Versions-That: xen=6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 From: osstest service owner Date: Thu, 09 Feb 2023 13:17:43 +0000 flight 176733 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176733/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e1528c54d3c44e50f0460f1ff721a876c81479b9 baseline version: xen 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 Last test of basis 176640 2023-02-08 14:02:01 Z 0 days Testing same since 176733 2023-02-09 11:02:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ayan Kumar Halder Bobby Eshleman Oleksii Kurochko Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6d317b10f8..e1528c54d3 e1528c54d3c44e50f0460f1ff721a876c81479b9 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 09 13:44:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 13:44:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492454.761984 (Exim 4.92) (envelope-from ) id 1pQ7DX-0008J6-2T; Thu, 09 Feb 2023 13:44:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492454.761984; Thu, 09 Feb 2023 13:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7DW-0008Iz-VW; Thu, 09 Feb 2023 13:44:02 +0000 Received: by outflank-mailman (input) for mailman id 492454; Thu, 09 Feb 2023 13:44:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7DU-0008It-Kv for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 13:44:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccc0bace-a87f-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 14:43:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8974.eurprd04.prod.outlook.com (2603:10a6:102:20d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 9 Feb 2023 13:43:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 13:43:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccc0bace-a87f-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GoejXy1Q65jIW8kXPgx6JO3orS3X9vnNNAasqna3R8luVOeyQI3uajLoM4ZBMjy8jU3CSXnDgNd1H+U6yckEvUikwbZ2dV47WXHDogQAfLXPIATQIHT7IANTiqPAs2FX8n0yqAZ35+Wmz3VIgIHD9sx84bu57LYyz+X9xuXxu0McuwNnA+R/6BwYsfwNNmZt0zJP4prpul1PI2EgkKhgW4W1FjkyJDxbT6voRnuejEPPTvh6Bf5pRcwFSSu399KOt3c4eROfc/6E0zzce9Cu3FVU/5hkc77id2d2Ke1PzZz06MDel42IxnPTxkiC6urTitTY1O0MUWGuiS0IqiUZ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EB/QdfctYPXrhMft+Ws3yV7LH89cspSGYvVA8BflDKY=; b=kLNsZxqy/k8gQZ8pyOX30uAqN4HYw2DaHnGIyo3bsQmR0MUVtYeLkXOddctoxzg6V8wolHbkxMXUPPkfhbykMdjhsqgJdV77MVO0j5+sZWOdzgHJpqXLOcj6TX4IwNi5k5CSkeYCek9zWEqdyr5ixnVkbIMUQwpuzn3Wkzuxe3Dd76RAbZAolrrUcazMLjJoSZ0erF9gtgQJd5jqa8SMk62JyZuipS7GxXUEml3OK36yrdYZ+6jjR4ScDAKJ2x49NIVL1XDJV6pH1OHvcjE6Ryr7lOPk+AkKyZa/sc5g9QA1ZKg50BKMpNVUqw2bB1bllF80X5rVbBJamO65lpDdbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EB/QdfctYPXrhMft+Ws3yV7LH89cspSGYvVA8BflDKY=; b=UGpktDzKXsikUNoCYS19HyphmWALTKAh8gehBcYr37oHpS5auXyJQ4vZwEnktvcim/oL8eNhJvpgiJJYiCm+QYGdC4BkLwdrRNPDwBHwY0G/zPhxvuKfaYXJdQAaw3PuRhFoXWaQIYHSdDFhGKOErAan7pFgc+Bt4Lk1pOP+XSPM8/tVYCvzrRVHy3QvEAuSr+FipGlkHGgcHaKPZTtryMVl4mU79ycP0FraLIo5UoVoflBKksipKPZ+maC7I64HiJ2Dm/uNwWxfNvKWC+L/3Sd7eaVVvClDE7vIysIcG2nhPk3MT4m9cgV/kG1zIYC1LCfhTR/l1Om1/ErC7fVYJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 14:43:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal for consistent Kconfig usage by the hypervisor build system Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> From: Jan Beulich In-Reply-To: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8974:EE_ X-MS-Office365-Filtering-Correlation-Id: e883ff24-e22c-422b-3d4f-08db0aa39f98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9wC95S0Crcm8rW66iPv/fj2Ku5ycsBWXblAo2VKDGdPkBlz2CHl1M6iXMRqcwlkLG12fEJ1hZ1kXK6TaAxg1qwdGSphwV8m4vDk20rbTuVkNHEr3nmMH0pOhsq5QhV0qyB3875sHgvAHp0+U19QCCFwdN//kR0BmJxCqJdEDDS9fhi3POlXPEezRuVbdZDwnAKBLGb/jmV1IPySBlps49LUaqSkYg9zsFhzk7p1JS74RXwWw+fyHhqHCu8YeBmZMi2WYV1K+DD7Y466ixW3qI3mzWHHe9ChhIKcW71tuTRvpKid+FY9PN04C8Q79l1Tk8hahEwfQwTnfVnnPRpyZvyW2/pZGdEiMkVCxdWuOvfqb5ETbdnK/vqbDF0fyWFAR00GrIdNexV0hn1CWyjEQTltpAI/kRIMoNvv+KjeUR1ftRGoEl9eT/SMDLEFm0jdmDXQl5xx8NXoLc5rR2a9/BG924Z3uSEws9Vkv4l0XyUgjHrZKEP60DrCd97PnLjS/W2WfmdogXodrf1YNK92AaffYYYeh0WKABZEmtgkLcJMVBucGf+3/uBAQkKgIfVJACcCfTjkFmMXe86ncQhVCKvLphHjp47wb00KpjcBxIhWh+sc6nmileboIsHT8OCpjxvMhX3uXV/O9keZXZW/zdgIrlqyKPOqlqOl3xLzkoHaRL3McbjPvgYQG2y8JXZVP+xRWK9+uYVEEduXq0p/bSBRCm5vNYKZwVaG2OVx+TTY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(376002)(346002)(39860400002)(451199018)(5660300002)(26005)(31696002)(86362001)(186003)(8936002)(2616005)(38100700002)(6512007)(83380400001)(54906003)(66946007)(41300700001)(4326008)(316002)(6916009)(66556008)(8676002)(66476007)(6506007)(53546011)(478600001)(6486002)(36756003)(31686004)(66899018)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXJBaStPeHhoTFBwQmIxSmMzaEwzWnVCOVJGYURoTWZReU5TWG4zK3JpZC9l?= =?utf-8?B?K00wdTRwSW5TV0tZMEVjS2hKS2IrVkhaRU1Zb0N2bnhOK0N2Q2FXN0NiLzhD?= =?utf-8?B?N1NmRENxSzg2bXZGS3VIYTg2eCtlbjlsSmx1YkhRaHpOb3dwTEhmVDQxdmFV?= =?utf-8?B?TXBSNVNrNVZ1SEFLZG1uM2Viai8yYXhEbmwrSVhxWGtxNXFXdEpiM0lNNlIy?= =?utf-8?B?VHlEdUJHQWRWTlFCWUhjT2lVZVV4ci9URTZsbXRQanJtL0w0dGNPOXpuRUU2?= =?utf-8?B?bGpKN2xaUitSOURhT2R4V2llVktWeWh5em5hTTUxMGs4a1c3Z3dsOHo0ZXdP?= =?utf-8?B?QWE2UEhwNXNTaENmVkxKbm50bGNuTGY1cXlTVHdELzByT0ZsZ2JLM1p6L3FO?= =?utf-8?B?ZUl3NGJLaDJ4eHFxYVp0NUQzWVh4Y24vMDBYTlRvd0ZYVjRuc3p3aGVvUXJI?= =?utf-8?B?M2J2eXVQeFRGb01pVFVxSGk4NlhOeU1kcWpqTmY1SWk5TlFiNmRvdk03bGd2?= =?utf-8?B?S0JOTTk0OVhDSHhqeXQ3S2F1SW55VmpuU0MwUDlsSHZHQ2FzSnMyb1dPaVl4?= =?utf-8?B?SENKdFlNSm44RWRlSTNmaXdxN3pKaENFUXhGa1g5Qk1icHQ3cmFpMDlxZ1RJ?= =?utf-8?B?TmtjbDBlRVk4MitiVXFsU1Y2eHZiNXdzTVRnbDBweDRGTXVOb0pQMUtMSEgz?= =?utf-8?B?cE1HTHNPSTRCcEFxN01hd1NxV1hsOFUzRW0vUWRZaDBNVnJjSGJDRERnVy9W?= =?utf-8?B?QVdwS1FKOUdDM2pqMkN1a25jRzB5UjVySHZjQisrSWVBYm9oajliZkxXNno0?= =?utf-8?B?NUljaFFOcTZHalBYVG1Ba2ZxRjZtQXNra212M0xIT3ljMkZ6enpGS09tRjBk?= =?utf-8?B?MlUxejJlRVRmcW9VSjFoMVprQ1NNQ0NXTmMvZUgvbG4xcXViSlR6QXIwL0dH?= =?utf-8?B?OUIwQlU5dW0wNXByMFFIZ1BOK3pxYzU5c0xxN3VxaC9jamdZVHExNGEvMUJz?= =?utf-8?B?S1RGTElKT2s0NnNaTE5iZHVET1FvUHU4eTNLQkxRUXM2TGpTVEtKcUluN2pL?= =?utf-8?B?Rm00aHRjSEtZUWJ0OGVHRWg4NVlqYkFSdFJObEVKZ3Fab1RSUk1oZDNCRWVS?= =?utf-8?B?QTZacVNUeTVja0pXWCtUNm5jTDdCa282U1Z3OWJuR2JMZS96eENmWDlTV0Fh?= =?utf-8?B?NEtVWlNkZ21KVXZWMlpSeVNqUXpnLzFKR1Via2xXQzdtRWNpM3M4MFJDU2Rl?= =?utf-8?B?K3BheGhkb3hIQm01Y3ZUMXZiNUowVytiZjBpeXN1SUNCYUJTKy85OHZLdWZp?= =?utf-8?B?aHRXcGw1RGlYaFZnS04vMVZIKzQvcUpldjNCZElDdnFBY3VvV2d2QXlKUk9C?= =?utf-8?B?UXhjMGxteXh2aEg0UzM4MkVMT0pBMlRmWEp3MFFBMHJRZUgyWUpKTW5rMlRF?= =?utf-8?B?VEFub0ZNRHJGcmx1NFU1aldDdEE5L3NHYXBJR1prQ0R5R2p2dmtGdU4reE4v?= =?utf-8?B?eGY2L0Y0eVY2TTVRNFpUbC9VRUIwS1pMclJNU01sZ2ZNWk9nbzdKaGhUTUlj?= =?utf-8?B?cTRMNmVVdGJINHN3YVFvczBsellkczJLYXQrd1hITUNxS2xZVHJ0U0VlREZy?= =?utf-8?B?bXFyQkNWdkQ0OWtNUFZ6QXczMVRKblBaN1FjbFpGZlNNam53d1NMWFZNbVlu?= =?utf-8?B?bmM1OEg5cjlubFUxdlNnTG56b2xHcWZhQ2I0eXV6clNwd3NGYXpXVUh2Rm9p?= =?utf-8?B?dm9UZHZsR21WZmw2Z3JYaWM2T09ucTlQc1lFRGVYWEFMcDBWaXo5Rm9RV0dh?= =?utf-8?B?MWlBUWpkdXJQeUQ1K2hGN0l5YnpGUG5yZTZ3Nmg0N0Z1N1RsMlR3SnBQbTQ4?= =?utf-8?B?V2ZocDFmM3pUcGh5VDZ3MkdzMVNINU9KbkVOVVNxaGRPc1ZkVTMzd0c4L2VN?= =?utf-8?B?R3BtK0c0TEhacmkydDJPQmdoWEZJTCtwc2Q2SHhFQkZQU2N2ZUxKbW9MZGJz?= =?utf-8?B?a1RBVkhMUU51VUlEaGZGa3lieER5N2F0cmtZTG8yUHZ6VFV0RUd1RVIzaFh4?= =?utf-8?B?dU16aVdRTUhQY1MzUjcyQmxGNzRxVGRVdDBmS3NJY3pidUVDbDBaN2R0bEgy?= =?utf-8?Q?mU+ArzHbdXi19J2MyUn5l7npb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e883ff24-e22c-422b-3d4f-08db0aa39f98 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:43:27.8433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wdp6awDOqWYa7N8o7aHd4eN0TP9F3yacxUIctYFlFKLeXWrNzoedOi1/m7sw5aXZ56xGS/Ooq5VLSIONY/v0GA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8974 On 02.02.2023 16:51, Andrew Cooper wrote: > On 12/01/2023 4:52 pm, Jan Beulich wrote: >> (re-sending with REST on Cc, as requested at the community call) >> >> At present we use a mix of Makefile and Kconfig driven capability checks for >> tool chain components involved in the building of the hypervisor. What approach >> is used where is in some part a result of the relatively late introduction of >> Kconfig into the build system, but in other places also simply a result of >> different taste of different contributors. Switching to a uniform model, >> however, has drawbacks as well: >> - A uniformly Makefile based model is not in line with Linux, where Kconfig is >> actually coming from (at least as far as we're concerned; there may be >> earlier origins). This model is also being disliked by some community >> members. >> - A uniformly Kconfig based model suffers from a weakness of Kconfig in that >> dependent options are silently turned off when dependencies aren't met. > > This is deliberate behaviour of Kconfig, and not related to toolchain > dependences. > > Exactly the same thing happens for a change that edits a regular > dependency, or inserts/removes an option. That's sufficiently different: Options depending on one another of course can have that effect. But we're talking about depending on something outside of the control of the person doing the configury. In fact there's a use case where tool chain dependencies get in the way: Our kernel repo holds (often multiple per arch) pre-built .config files. Prior to Linux introducing tool chain dependencies, anyone could update them (without actually trying to build the result right away) using whatever compiler they had to hand, even cross-arch (as the kconfig step only requires a host compiler, not also a target [cross] one). The resulting configs would then be consumed by the build system, using the proper environment for the targeted code stream, i.e. including that code stream's tool chain. If the build resulted in a change to .config, this would be flagged as an error. When the first few tool chain dependencies appeared upstream, they tries to hack around that. I have to admit that I don't know what the state there is nowadays. >> This >> has the undesirable effect that a carefully crafted .config may be silently >> converted to one with features turned off which were intended to be on. > > The Makefile model does exactly the same.  It *will* check feature > availability of the toolchain, and *will* modify code generation as a > result. > > The programmer just doesn't get to see this because there's no written > record of it happening when it's not encoded in Kconfig. I don't think I'm following you here. The Makefile model in particular won't turn off and CONFIG_* values. >> While this could be deemed expected behavior when a dependency is also an >> option which was selected by the person configuring the hypervisor, it >> certainly can be surprising when the dependency is an auto-detected tool >> chain capability. Furthermore there's no automatic re-running of kconfig if >> any part of the tool chain changed. (Despite knowing of this in principle, >> I've still been hit by this more than once in the past: If one rebuilds a >> tree which wasn't touched for a while, and if some time has already passed >> since the updating to the newer component, one may not immediately make the >> connection.) >> >> Therefore I'd like to propose that we use an intermediate model: Detected tool >> chain capabilities (and alike) may only be used to control optimization (i.e. >> including their use as dependencies for optimization controls) and to establish >> the defaults of options. They may not be used to control functionality, i.e. >> they may in particular not be specified as a dependency of an option controlling >> functionality. This way unless defaults were overridden things will build, and >> non-default settings will be honored (albeit potentially resulting in a build >> failure). >> >> For example >> >> config AS_VMX >> def_bool $(as-instr,vmcall) >> >> would be okay (as long as we have fallback code to deal with the case of too >> old an assembler; raising the baseline there is a separate topic), but instead >> of what we have currently >> >> config XEN_SHSTK >> bool "Supervisor Shadow Stacks" >> default HAS_AS_CET_SS > > Yes.  This is very intentional, and is AFAICT an example of something > which cannot be encoded in the existing Makefile scheme. > > There is a tonne of stuff we can only do with proper toolchain support.  > CET (both shstk, and ibt) are examples, and plenty more to come, where > playing around with .byte in older toolchains simply will not work. > > There are also plenty of cases where it would be technically possible, > but the cost of doing so is so large that it's not going to happen. Right. Hence there'll still be cases where we simply will fail the build vs ones where we merely create less optimal code. >> It was additionally suggested that, for a better user experience, unmet >> dependencies which are known to result in build failures (which at times may be >> hard to associate back with the original cause) would be re-checked by Makefile >> based logic, leading to an early build failure with a comprehensible error >> message. Personally I'd prefer this to be just warnings (first and foremost to >> avoid failing the build just because of a broken or stale check), but I can see >> that they might be overlooked when there's a lot of other output. In any event >> we may want to try to figure an approach which would make sufficiently sure that >> Makefile and Kconfig checks don't go out of sync. > > This is a brand new feature request. Not really, no. That's an aspect that should have been considered before switching any tool chain capability detection to the Kconfig model. >  But it looks like you're trying to reinvent ./configure without using ./configure. How that? I'm specifically trying to stay away from pinning down what can or cannot be built depending on the capabilities of the tool chain used for the *config step of the build process (which, as said above, may deliberately happen in an entirely different environment). Anyway, I have a prototype for the two CET controls mostly ready now, so I guess we'll continue the discussion there once I've submitted that one. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 13:48:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 13:48:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492461.761995 (Exim 4.92) (envelope-from ) id 1pQ7HT-0000dd-JF; Thu, 09 Feb 2023 13:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492461.761995; Thu, 09 Feb 2023 13:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7HT-0000dW-Fi; Thu, 09 Feb 2023 13:48:07 +0000 Received: by outflank-mailman (input) for mailman id 492461; Thu, 09 Feb 2023 13:48:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7HS-0000dO-1C for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 13:48:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2044.outbound.protection.outlook.com [40.107.7.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60573613-a880-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 14:48:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7652.eurprd04.prod.outlook.com (2603:10a6:20b:285::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Thu, 9 Feb 2023 13:47:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 13:47:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60573613-a880-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRHXfMZuK4cHoXID0uSOOd5L/P/GOS0Jbk1n7pdPDZihB9d2LMMyzJfqmjvjgO/eheexmZ6F47KNq+mVOCk4zdFW/YeDJGXyTajqc3Kc1hOAaZv6g1oSxXF6wDmKnv9Q4PHa8CDUXbkrGi835MEcDr2+Gzyy5KLHJuJD7vTQEXgqEKjjm8MxlA4ir284Qcxst5MuhtzycmMNLbivg+zwsWCpyym1QD0DrfnZytY0RgDDFltY5GyvWFKksrakEFPwWSGwyAb8vnMmluO8K35A2s0NfZ/C5v5QyJkqt9ODJ/yZOiYChmHqT++hn2oBpOF0BeFzDkv8+SpQkn4qNeuqIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahjvpTi7fKt9B0aA/ag7jEDPCf+7ZgQC4lifzUe4apQ=; b=m3P4zA7FFqXXnanq/sPYz/jgZJioblXBasOjFTK+MGuDPx6paY8nBk0ALCNziC+HD+rqeoOdIMrG8nHZR8b67atjW49DdGYyg6yyH8OzpRbIQ5+rwmqwF63Di1qCN28uo/d4bfvJxWSDc1Y7wCxfvKO0+0jOjAstPVEvfnb6mTHpCmk7sTyRo8I2zlnzV56gIHVqONmavmlE1SAi+VvP0H7NJH4S7m98TtssSx9cGDpDDe/wVlG8MuTwWR1ETLBOsDGRMrRyqJ+GcUzS/okPk65I0skyLOUrbyHKTkLpYyb+9+0oRzT/dPu68P//aibTDunikUwbO6zQTpSS2iGQ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ahjvpTi7fKt9B0aA/ag7jEDPCf+7ZgQC4lifzUe4apQ=; b=AuFiFxUskU4iJKFU2Zbzu0asjpMg1KXmiGgKw7o5RSKfsULK7awZu6ht+glBO3i3sGtfrnRPkaA/W94yQGSd9/l8pPfcoh9oJR8hY52L2wTgy4LdKpJ3T4ZsWHFwNvBk92tjE2YWUyAOWdDmag0pU3Cwg0133wcRhRL/gNo3i5iGEBNNd8FAyhZj0zqew4Tf701x30rg0vXNVJ/n4JEPFT0TtW+ik62mD8SThIycA98oBNyH7lJ2QyBKITuzGoTj0Z4/RPrxdp0tnt373npvjLytT9OPgXr1ZLuWZq0mee9XQjoJRjjyLeydTf0kS5HE1p0jlv+nC0qO728ikTHGnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 14:47:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] build: Make FILE symbol paths consistent Content-Language: en-US To: Ross Lagerwall Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <20230208172416.725028-1-ross.lagerwall@citrix.com> <6d281c88-83a0-ee86-18b3-6c9d856a0971@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7652:EE_ X-MS-Office365-Filtering-Correlation-Id: 64b9d3c7-4b1e-444e-06c1-08db0aa4334b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZCtCfZsRo+orpYJXLZmbysOaibHU525Ga/w4OP0w9Q1mibihCHFbqSpYiuAEfDlRR2Sgd4/EPKjq6n66DA/ObFPjUqacmn1h25VXv9k6zmeOS5y1WTim1IJT+74TVQQY/iMI0VgS9OCQX8diGsufRc+NizNzMNblHkUw5N4005nacGYJ74ZMzPelIzov7kGg4R/X2GDlzRh3f5JDSrZPghKNc9hNqg5TG782Kd06BmoF267xF6z5V6jzh7teHShU/uccSNUy2n+ZRKg2PGbsonXEgSPHQgwxeKULtSVbtC9sZhLOb5JhX+I7chKkda1+YZUrATOye4kZlksqeeMTqLgp+pta3U/bQG+RmI0zr2apVaWVdB4rJmv0tQqDxesREr59T56b4t2RFW58yaIsOpFkLxg6K2ESyLwkHqDigZ/07SQ13iDTZmb+2oa099VXKLFE2O6y2+a/HJcNBKbrWdAbEChICv7q2I+7iQb1rSuWKD7X6vf8CbPF8hIni5WNG99lYS/nZ2yhdo3bDvJW4TuMImvg2yOK6VWoU8ODanp7dEVDesf0PwW3BcD7BMqVc7y7fDF7VbHfDuVdIVTstDpQ6QwO959+WoCaixcUmkaDKmY1AJLcnEe0fNJox9Lwzpim9Cqu6dIaQwz+tZ02Q45RrPphhpKlhsyIsJwyMheONiFAUCNvtmnV+Ib0HTCLFulW1P0fllPndW6/lJXDG9Kx4kDwNrYU69rIFQrfK3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199018)(6666004)(38100700002)(6486002)(4326008)(6916009)(2616005)(478600001)(54906003)(31696002)(316002)(41300700001)(86362001)(66556008)(8676002)(66946007)(66476007)(8936002)(5660300002)(36756003)(6506007)(2906002)(53546011)(6512007)(26005)(186003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFowd3Z5c3JsSXJWdkJobkkyYWxtVEk2bmp5bFJEQ2M0VXU5WElRSXpvV1Qv?= =?utf-8?B?dGk3UzVpb3R6T20yc29ZcytVeGcyZEs2OHR4Z1RMZDRrR2lnSitBclNxT001?= =?utf-8?B?czROQkk5VCtNdDVmRVF4OTRyVmpKNU1UR202cHAwWXczUlBwdnc5aENBMGl4?= =?utf-8?B?TDBwaFFuYURpWG5NOVZjbHQ0WWVOZDFSY284L3ZkNVdNYWVoSDBuaWNVelZW?= =?utf-8?B?bTdqTmtyOEU2RmppQ25MS1FYNDJOSVBEU0g2RUlDdUIyWUZabGhyNGRhZjNK?= =?utf-8?B?UGE0ZUczd3RPQk5ZVkNkVVpZS1hNK3U3VFZqRHVFN1VPY0VTbVdCY1I4QytL?= =?utf-8?B?VGdqMVI4OHVCRTFjNFl3d1NKN1pNcWluRFJhOG11TDdlclhkODFlU0VPZ21X?= =?utf-8?B?bytuaFIwYlF4RHhVZ3k3Rk0rL2ZJdGhtL0JSTFc3ZHVBUkE5eDV1V0VuZ0ZH?= =?utf-8?B?Sk9RWGJ2eWc4czdySEJFWXJGM2pjS0ZSU2JaVkgxWVVla3NGYUpiVFlpY2Vu?= =?utf-8?B?Rm1zbDhNT1JhcmxOVDY4KzdJWWZNL3RyYVUzVVZtQnRINnp2ZjFEeWs4TkNo?= =?utf-8?B?SWYyVDJ5L1FzeWtOZnpMd1JwendQdWUvMWZ3WU9BVFJSRjYvVWx3KzBoMkth?= =?utf-8?B?VExsUHE0UXJSaDFLMnJ0VmxyZzlTNzFzVndGaWRtemVYb1pnQ3RuWXRBajRi?= =?utf-8?B?VzVPV0t1clhmMmZIMVZRSU9UMUN2R3pzVEV1UTVNR3hhcUE2cEUyZ3dtRSs3?= =?utf-8?B?anJESWdYTldVejdYa3gxUXljQ1p4eXhRYk1IUzhQSVdEN2pUdVRTVmVEcFQw?= =?utf-8?B?b2NoM2FDdXJUQWFrYVlIYzh5eXVteTRZaUxYeVE1bUpUd252MXRGR05NV1FT?= =?utf-8?B?eVd0MzlJa1FzSy83elFKb3htR0l1U09jYWNVYVd5TlpPOVo5UHR0ZDRJKzQx?= =?utf-8?B?cVdsNkQ1QmJjOXFVUXBveDBLQVpmZ0l3czhsTjRYdktOalo5NW5wQ1k5bks0?= =?utf-8?B?RFdPdlpuNk5YQXJrdU4vSjFrS0Fpamp1SEdnSGVPbHdGV0tDbXFzV1JXZ3k2?= =?utf-8?B?Z0dYaXd6cWpBc2dybFZHK1NJRHprOS9GUEpwbHg4dDFTMXNzZ29iRTB4MFRF?= =?utf-8?B?NmNHUFdrR2Z2TDJ2YS84RU5WYVdSRC8vakQ0TXFzQ1lBVVBqKzkwSjkwTkdP?= =?utf-8?B?TDBKUWg2Z1BmWVVGWUN0cHpiRjRoN2Q5N3dOemZyZGJHOHQyT0Z0Z1RFNldl?= =?utf-8?B?U1BMVFppNHgwLzVGSHlwd2YvcTQvQ05BdXBhN0VGcTlEaVVGZDUzQkN6UEdN?= =?utf-8?B?bGdpQkl6RDBJZC9IdjFzTGsyc0x0ZkpYdzM5aFI5aXZUeDNubzdqaUJqLzFj?= =?utf-8?B?QjE0MmVXNjc3ZlRtVWs2OHA1YzlsNUJSUjlna0VzcnduZnVpVWhoalhpUHM0?= =?utf-8?B?TVhoVUtqbmhMaERUMlNYemRKckJhcEl2aTNjUTNmU2ZvajhicDFNTEFDYTFn?= =?utf-8?B?NHNxcy8zSjh5eU9KdlBGV1FVUGFlRTgwNHp6T1I0Ny96WlVuNityNkpzbjA2?= =?utf-8?B?T2tyY21SQUtDMHBBRWx1L1JIWXMyQVJ3bldEbjErOXRERDdRUjluN1FLMWhL?= =?utf-8?B?UFVhV2ltZDJLU2pxMXlKeGhpZ3Z2ZkZWaWQ2UmJpMFZPNXdmSmQ3OFRZNVZH?= =?utf-8?B?T2F5M1R3dTN3bXZpQ2U1WkpiQWdTYU44bGxDWVJaWHBmKy9pOFVaMkhoQzFI?= =?utf-8?B?M3ovY2V6MWFiNGczanZYeUdEdGx6Sms4bHpDUkhtYnlZd2E0M0JlUVVGS1ZS?= =?utf-8?B?bkdRYlk2OXp5RWlpRG1xMStLY0ZHcENzallpSGdJdDQ2ZjIvZk1mU0tEbE55?= =?utf-8?B?dDJEZ3N6UklNQmNHdWJuL2g2V2JmWWxYcFNUSnpNT2lIWnNmNkVlWjRyVVhu?= =?utf-8?B?R2l6ZzNmQmRMMEFUVlhvN0liblNxZWJkVWxOcXlZcGpqeG5yT1MwaDBlcFVG?= =?utf-8?B?aTlyY3piNEZMTlZ2d3o0bnQyWi9oQzlRV0h4aStreWVtSzNJOGZqZjJxZEhs?= =?utf-8?B?dUFZMHlERERxMVNCM3VGNDZ4eVZYQmVvR2YvT0sxdXhRblhua0U5VGQ5T2Ux?= =?utf-8?Q?1bxlGi+imPzoWI1/CYXVfT8YP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64b9d3c7-4b1e-444e-06c1-08db0aa4334b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:47:35.7494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X7+/KL3WYdrT4AM4YpkoGb4P0oNdY7piiujV9W6ZJ9fuDHnA0TCSeiOkXYHrRESnBcBQ7lvnOBJsjyC/vtMOSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7652 On 09.02.2023 12:40, Ross Lagerwall wrote: >> From: Jan Beulich >> Sent: Thursday, February 9, 2023 8:44 AM >>   >> On 08.02.2023 18:24, Ross Lagerwall wrote: >>> +        rel_path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1))) >> >> Personally I'm against use of underscores when dashes would do, and using >> a dash here would also be consistent with e.g. ... >> >>>           cmd_objcopy_fix_sym = \ >>> -         $(OBJCOPY) --redefine-sym $(>> +           $(OBJCOPY) --redefine-sym $(>>       else >>>           cmd_objcopy_fix_sym = mv -f $(dot-target).tmp $@ >>>       endif >> >> ... the several visible uses of $(dot-target) here. > > I'm not sure if there is much consistency since other variables like > abs_srctree and abs_objtree also use underscores but I can change it > if you prefer. These two variables had their names kept from their Linux origin, iirc, so they aren't an overly good target for comparison. Nor are, for the same reason, the various cmd_*. Linux, sadly, isn't consistent in that regard ... Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 13:52:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 13:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492470.762006 (Exim 4.92) (envelope-from ) id 1pQ7Lw-00028G-87; Thu, 09 Feb 2023 13:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492470.762006; Thu, 09 Feb 2023 13:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7Lw-000289-5L; Thu, 09 Feb 2023 13:52:44 +0000 Received: by outflank-mailman (input) for mailman id 492470; Thu, 09 Feb 2023 13:52:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7Lv-00027S-28 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 13:52:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7d00::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0513ab4e-a881-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 14:52:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8277.eurprd04.prod.outlook.com (2603:10a6:20b:3fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Thu, 9 Feb 2023 13:52:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 13:52:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0513ab4e-a881-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbNLCj1HwAAUHx5eTazFh52OrBXLOV9i4GQxEryfubVYLSKQaLPKfcPkKl2++HyB34ejqTFBlEQV8r2GWSNkiXrYQyiq2xG4i2BFwY01QPPnWIE95IrySDCukNU7p0Wzzd+l6lq9NrFiJPbu0pSyU04pii7b68haoexdH9kLZmLrsneh4Ktolh1R+oM0bKBwuLXW1BxPD4kbd168Fp0TuTbzrjrSttWHYeFKggJm7y/Ks+JXwLg9AfP07Q/txumFVt/9LH+rBei/LVW99j6+1/9L8o4QPr2geKloLoUTa92e/wNW9pBftvjFVjkFiqQ/Ix6zD9UzkYXGvuIim9+cCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BIh58v5MdV3BdPr4+i6BcZ+zdr62X2V6VkBVxHDVuX4=; b=S4OGt/Ae3BMsSB3kTClKp2px5803DtjdKbSLN9ImiBwtfkQ5UbDvGYCsv+TmsEk3QO2IIs2reKH61u72uYwydE4wQ13Peb96v0RWXGSBZ5Ybb/cNcgaUwDvo0z1vzm0M8i9gWHa/qDwLBiSlTT1lvowALZtO1wmmlraiJoo+YJfrYnUqTex+j1FAVdYwWlDAwlx4+piCOyEuD9G/cLD1FahuU6gC8vNgpkxbqBzOHiVSU+gTzHxcC/SeH0t6xqe9NcVoVWSgiNh49M8tRT5oJ8R6LoTu8qLWv08KSd4gO1IGSuofYWOI4/nwU0wKXHjPDblWP0zDkx1NqVl+cBKmCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BIh58v5MdV3BdPr4+i6BcZ+zdr62X2V6VkBVxHDVuX4=; b=nv4nlA4D3hJgVJuLF13j1gFVBaz7cAKJmIU32aSZZCwpze3Wky7thrHr1eQb1Z25FPGrcGqZXSVHnrKTn0MR7PQC5rXMjEAVOk1++QFrtQQr5ST/iibdcDQxPJnUX2ILl8qJQraj9ViZoI6VzQOMeFa74kIo8W0+4olRUKULsu84D4a/CNQs8zL9sjxK9KKy7zfNJ9kMjjaC9Vsd0UIXuwGs1F6ocHNieoS5CYF3Aac9kiyva+ggA7CgM/fKjVk33zS9HC3aQrd7TQt9VrGbPCga+jM+cvuL8Cx8uK5MJiCtn65pzXshGH3Ecs6iXzr5gs+23bEsaGM5gbMQQbQacA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f439ef1-ee1f-e1f8-4432-0ead84e43fde@suse.com> Date: Thu, 9 Feb 2023 14:52:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 12/14] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <404a4d6621a2e5eb276d2fa61188429294d682ba.1675779308.git.oleksii.kurochko@gmail.com> <1331e8eb-652a-3bdd-2c98-ee695b03d12a@suse.com> <25bd709316631ceac04876b40898d3c970e4ba50.camel@gmail.com> From: Jan Beulich In-Reply-To: <25bd709316631ceac04876b40898d3c970e4ba50.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8277:EE_ X-MS-Office365-Filtering-Correlation-Id: 60f319c3-eb26-403e-8ad3-08db0aa4e7d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a6kevZhTj3LS2hsbP38gx8gszaxUVd2Ww15AOy0PrDDZZNt5LnBritYKiSDYS3tK3V5JoDHATHUockfyZnrgP7lGKrnVEh91fQaqlDOD+F4WG09fY1D0q/5oEhFk8CDdyL3WJgM8+gXoYEndSxHMghxLdbh9XcBcRgNNJzWKVdBEaL9BMDoN6sfvxKPMZ+b+WKoZlJSvFO97L4kFQNzN03lfK8sqcVfqAe3oapAKC2IlsrpF47+GMgA/4rHhoy4Iqaa08NS43p2nNmQIGGUHinLEu6Pq6EeTdu9Odvfr09lZJ4BMuqmbQ1QiwdWxIvuK2tg5tuJoWXSZz3QubmVhZt6cdlhfgA5R8QVBWdTXjtb6w9Kn9/qNK8zRq/ZXg9Gkx61ytjxSvw3iHT5jyz+w3ivgUaQrXw2RmljiTZpRKzMe4IAbqPHVA8p/pcuWv6VyUgmlJvGV2fuCIEI8vEXEI7khOkojE++RNpIFVSZesA5DV92oWF/Bol9gTju6QfJL33Uzc1Fa9zF+kM+QqEUU6Z0ZjhuKcB4aAa0RGEmUUlFm/bYuXArEQ6efxWUgzFrWaCClldM0TqsVMJzL6u9p2QFYWYcaTz2yhPuVt260eDH7IL+DdX9spReDVFPXPOzYc6WEuRzIMKwlEZoOj4bplvhJmjxNlhYf4n1FAlkKtkLQ8555UoAPdLsVTqI7iQ6d3gYnI9m7k2buIe235VMMsy1YpALM2O/t6i2YXMc9HNlYTTlMV2OmY87tnUqZ6D1NySvSPfRHgny0DNCTUy41tAxgWFgXEmQ7bh1XWxqBA5c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(136003)(39860400002)(376002)(451199018)(38100700002)(26005)(6512007)(41300700001)(6666004)(186003)(2906002)(8936002)(316002)(6486002)(966005)(2616005)(478600001)(4326008)(66946007)(6916009)(31686004)(86362001)(66556008)(66476007)(8676002)(36756003)(6506007)(54906003)(5660300002)(53546011)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEZPRGJoS1l5TUZXSEFmNmNheXBxWjFjUkgxdjBWaTJLd1V3NVMzdUZFZ0hJ?= =?utf-8?B?TEZyUElQTU1ob21oaDBTNVBKWFVIeUZsRnZ5SFN2a2k4MDR6aXpRSkl4K1R5?= =?utf-8?B?by9LMDVjYkpYcUhQZFVvWWYzcWxEbzhpK0RzVHRONENlV1R1bkVLRnNwY3pn?= =?utf-8?B?TklZUmdvZDBNMXFvUEExZGFKZ0VmOUJJUjdhVjh6SHJROHFVMEFWenpUcnlC?= =?utf-8?B?elZVcDIyRG9wMnBZNjc2cllDRmltVE13b0IxdDc4Vm42N3FaVllCQTVIM3RD?= =?utf-8?B?MHZsRDhsaGNsUlR4d2tRbWJZVUN2L2VodWhMZWF3c0hBK1JmajdERVE2R3B3?= =?utf-8?B?N2VMaFN3RFo0YjZ3MzM2anVVTzQwU2poWG8vcDRzeWpYSEtIQ1ZDVXJUeFVV?= =?utf-8?B?MmJsVGdSbEhWNFZwMitDUWpOZVp6YkNTREF5NFZZdWF1NzNpTEl6Wm5OUFFQ?= =?utf-8?B?TEoyWXFKL1prT3RlZHlFWW9vNGwvUjE1dlprMGZWTUNGRFhneXJjbFkyZE1q?= =?utf-8?B?cHlKazJFZXlZMlI5U1lxTFRpakZneUVYdDFmZG9MNEh2ZDVtR2xlQjdxY1Bi?= =?utf-8?B?ZUNrUHNJMHp4SE9hZ0xzNktHWmR4UE9FSThHM3I5TWhBRUd0NHBPdmlmQUN5?= =?utf-8?B?NUxaSVFGSm9sZG1SdVZHSGZERUFla1B6UUx2QUVOWkJWanMzQ0xPUDF2SlMv?= =?utf-8?B?SDRZQUxmam1PRCtDN2NsZjNZNE5VT1RMa1M2WGpxcS8wN3NjNWJzMncrS0pm?= =?utf-8?B?SUlhd2pSU0h5ZExpTWFEcVpuVUdzMHlXOUlTenFqRU5oRFVCT2pEaXo2UW1E?= =?utf-8?B?TWNYbUNzQVhDMHNKMjBwaWpNMkZBelV1bmpOVVZzbGtEZWhRU3l1L0F4MVlr?= =?utf-8?B?U25pVHF4KzJESmJJTVRpQ1ZHZXJwclN3U0JKLy9FckIvZmR1bzBXbmIxNFBY?= =?utf-8?B?ZmZheFBDT1Nua3R6R3FrcXNOc2dVejdRb1htdW5DQ2VFTTZMbVdYNXpMY1Nm?= =?utf-8?B?aTljbitVQURaazNGaHdaTlpvWnV3cGZOMUhPNjlBYnBrMldHdG9YZWFYQkd6?= =?utf-8?B?MnhsK3FLYldSeW9ieE9zRnVERUNxQ1MyeDRFamg1SFBQaWxYWGRodkl4bjZj?= =?utf-8?B?d3lwS3NSRFc2V0FORUNDRlRsTjZsVis2bkZXRVJmVCtHUk43bUFrQkZ2UnFB?= =?utf-8?B?bnZmR0ZSYWIrSzlabk5oZlhJMkoxOW95N04rc0Z4UHkvc1NLLzhmK01uWTRw?= =?utf-8?B?T0wySXA0OG01SHlnYVJGQUZrcElwTk1XaDQ4RU1GaER4bFBlQm95ZlAzSnla?= =?utf-8?B?S3NqQ293cHNmbkphQmFHZmUxSWo1blRqL3lhZmYxV09nRlBEU1ZZZnB0OXg1?= =?utf-8?B?d29vUDFLL3pmZ0tTOXBHSXB3Nk5BUjNoUE9heEJZa0ordVk0RDBjbithMkNv?= =?utf-8?B?c1ZpS1c4Z2lybW45ZnE1akpybWZuZ1ozRzJ5dlFTUDh2UnFoVExHZ2VQTkJa?= =?utf-8?B?aWlUMjJkd1NaeHg3UXFROGRDbG5mdEhzYzNoS2cwS3hFc28zR2Y1dGJBdHFK?= =?utf-8?B?L01hSE1qdW15RHBDNzRHTDdBbUd2ZmgyNXJFK0ZpNXRzVGdaNzJjajZWa2dX?= =?utf-8?B?MkhPNW90SEZSVjg4R2F6enh4aWFIMTNWK1RiUzlRV1hiNWNwUHkwK3F3a0pj?= =?utf-8?B?RUc1Mnp5bDR1MnZ6R3lyOWMwWXBIZEJMTjRoTGduSkY3aXZlUUhOclVKUW84?= =?utf-8?B?bVlCK215WTRDMkdpcXIraCswMG5mMGEvZExOdiswT1YyUVdJMFlsSVNPQ3RX?= =?utf-8?B?U0hRRmppZ3YzVkIxVkkvT2pSK1R3bW5tRGU4Z1FMMC8rYlo0RTIyTFpMa2Ev?= =?utf-8?B?TnNLSGlWRkxFOTBzVi9LaVJoMDZNWmJIMmRuV0NmK1R4YzJLeENjaUc3cDIy?= =?utf-8?B?Um9Cdno4RUZkSGZuejEwejZuNytEenYwZ25KLzVNK1ZVR2krNnpLanlTZ1hH?= =?utf-8?B?QzVFNEhGZXl1OHNYMWUrcWYrWjl0WWFRMnNDT2tnU29YTTVxclRiYWc3WnZN?= =?utf-8?B?bFpNNW00L3lPOEYwQ2VQdDgzdkRIR3hTWVpaWU9ySUFUclRQYUI2bGhmOU1K?= =?utf-8?Q?kK/zuHPiZZajr+teJQT34ssVZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60f319c3-eb26-403e-8ad3-08db0aa4e7d1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:52:38.4647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x9CxJA5F6EFceFO1UFsoOsEOE3v9lEb/Sp08ETY7qV8fWtXKMtDw4hteJV04DdLreFPFGefGiZF0Zgl4khvgvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8277 On 09.02.2023 13:35, Oleksii wrote: > On Wed, 2023-02-08 at 15:01 +0100, Jan Beulich wrote: >> On 08.02.2023 13:00, Oleksii wrote: >>> On Tue, 2023-02-07 at 16:07 +0100, Jan Beulich wrote: >>>> On 07.02.2023 15:46, Oleksii Kurochko wrote: >>>>> +    switch ( id ) >>>>> +    { >>>>> +    case BUGFRAME_warn: >>>>> +        /* >>>>> +         * TODO: change early_printk's function to >>>>> early_printk >>>>> with format >>>>> +         *       when s(n)printf() will be added. >>>>> +         */ >>>>> +        early_printk("Xen WARN at "); >>>>> +        early_printk(filename); >>>>> +        early_printk(":"); >>>>> +        // early_printk_hnum(lineno); >>>> >>>> What's this? At the very least the comment is malformed. >>> It's an old code that should be removed. >> >> Removed? I.e. the line number will never be logged? > It will, but: > 1. I decided not to provide early_printk_hnum() and focus on getting > printk() working. > 2. I introduced generic do_bug_frame() [1] (at least, for ARM and RISC- > V) so the current implementation will be switched to generic one when > panic, printk and find_text_region() (virtual memory) will be > ready/merged. It is what I am going to do next. If that's to tell me that the code above to going to be replaced soon, then a well-formed commented-out piece of code is probably best for now. Jan > [2] - is a link to patch series with introduction of generic > implementation of macros from bug.h. Probably you can look at it too > when you will have free time. Thank you so much for your attention and > participation. > > [1] > https://lore.kernel.org/xen-devel/8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com/ > [2] > https://lore.kernel.org/xen-devel/?q=%22introduce+generic+implementation+of+macros+from+bug.h%22 >> >> Jan > > ~ Oleksii > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 13:59:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 13:59:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492477.762017 (Exim 4.92) (envelope-from ) id 1pQ7SE-0002xe-V0; Thu, 09 Feb 2023 13:59:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492477.762017; Thu, 09 Feb 2023 13:59:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7SE-0002xX-Rk; Thu, 09 Feb 2023 13:59:14 +0000 Received: by outflank-mailman (input) for mailman id 492477; Thu, 09 Feb 2023 13:59:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7SD-0002x8-5R for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 13:59:13 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec2444da-a881-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 14:59:10 +0100 (CET) Received: from mail-dm3nam02lp2043.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 08:59:07 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5269.namprd03.prod.outlook.com (2603:10b6:610:90::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 13:59:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 13:59:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec2444da-a881-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675951150; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Sy6v6H0WAeZN6YNYDw3vqNAuMQ3fl5RTcL9lcfZbgpM=; b=CT5y3BNLdLG4l3dEdKjiG+Sn/HwHAdgpXBdQWmiqoUCiUIFYH6gv9l2m wvEaGjNAgSWQkC/5JbMDns2pKv/jtXF0r6UhySjiR3QBhThAu1ZOUFDEW hoh/2ZZbKzI2cI/+2LPHClCVKjglZw10GpGc0SQQsw27NPymcopPqXOV5 E=; X-IronPort-RemoteIP: 104.47.56.43 X-IronPort-MID: 96274333 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:nXaji6n3Ujn2u1MxE0J+D9Po5gygJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWCmuCbP6OZ2L3f40la4znp0IBvcODzN5lSABr+yE3RCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5A6GzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dkpNAoVSQ6Cu/6/xu6nDdI8gu4xdOC+aevzulk4pd3YJdAPZMiZBonvvppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3jOOF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMTuLkraUx6LGV7msRVzgsCkWHm6jnjmqEVtdBO mwMwyV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcpQRQ62 1nPmMnmbRRtv6eSUmm17aqPoHW5Pi19EIMZTSoNTA9A79y4pog21kjLVow7TPXzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:HpEOMqqI8ccBSiRH2oFU/msaV5rdeYIsimQD101hICG9Evb0qy lhppQmPH7P+VAssRQb8+xoV5PufZqxz/BICMwqTNWftWrdyQyVxeNZnOjfKlTbckWTygce79 YET0EXMrbN5DNB/KLHCWeDcurJwLO8gd+VbeW19QYScem9AZsQnjuQCWygYz1LrBEtP+tBKH IFjPA32gZJfx4sH7yGL0hAZcfvjfvRmqnrZBYXbiRXlDVn3VuTmcXH+wHz5GZlbw9y X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="96274333" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lKY2mB6y8d1ZXxdljuxosgR2B1ccSUDJtB1jd4r1qz4k2vagXDy7OPhr+ENBljVg60M+fyXlrtD3Vhsc7e2PJOD6rJlMEXmfgeqEa3zyVwvMkFaA8J/auCmeCe0pkiHUEky46uXLF+v+83BfUxIT9HOh8y9T3xVhPp5hpv30zXyN1yBLDMbJBj+lcxFpKK7qfhVx0iEt++JIba8RSMyIhps3B3gh6/sitMo4j401hkOMh/IGgSIWESxSVhVGwI184yhaj0tzL2PtInZV2q/j6VlUFIOeyvm3+wp6+w9F7YBO1wCfMS+imSBWofMLyRaHndTN8BlFOyiKg1fo4LergQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sy6v6H0WAeZN6YNYDw3vqNAuMQ3fl5RTcL9lcfZbgpM=; b=AQyW0SyGtxZPbRcTJ17GPfUA6A+cYvHeZ0TdXhqIBCKienOHPxg14TEtlXK2tukPd0x908tXBXvPYenbF9dvvDaSlQS6XkAJY0yhKcFI7pTK3y6zBjlO5ZWXFr8Oa2+vp50UWHsSguoRsHgN5ErZOqwRop+IPuq4zeqWIdtMghMvrJQaWNRmAjISyPWFPJU4oU+Mp4Leh4KsKfmSxHGKmPgubTPf+NtV+mOfFiD+Ebxgpj8nOb1iz+V+bix9iewhWqH8UNaS4smjSIBcJruBdratPdfnfCPd5Y12nnaQqKp9dAajYSzXCxo4Fu/DtUv5P5GTkZmXRTVbbA7Mx1avAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sy6v6H0WAeZN6YNYDw3vqNAuMQ3fl5RTcL9lcfZbgpM=; b=R92fyLVODI03cdsyRkiDL1TsXOq2RPhD9R2Sj+ldtgfagNEztRzPHuDtiMCMmPND2qQBHTuVSIV3WHWGwaKAxsCn4R5tdUK8GIJLyb7uEMuBYQ8+A5z2POL8FEPjqn7gLOr8Qay+TxSSPYssONkb2gbV3AbVhJ5PGOSYCkLxUwg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1c579c3d-6fc3-733c-90b9-d71c761c66d6@citrix.com> Date: Thu, 9 Feb 2023 13:58:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH] libs/util: Remove unused headers in libxlu_pci.c Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Juergen Gross References: <20230209121140.10982-1-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230209121140.10982-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0662.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5269:EE_ X-MS-Office365-Filtering-Correlation-Id: bfe78ebf-cfc4-4839-9cd3-08db0aa5cb45 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mi0P+mY+bCO0uNcLcfTXuQszCUmhI+XiY4Mfhf3JZG889R915iTJrErJ1hG9ZFWi4tG1xEHcpHB+tYnJr9ycC4gZd9Vltj0EUG39Gpa3d4zrGm5ovac821UaG+4RRYtT9zi5AJhwL8048cjujpTzBRf3YfZ1AHUlvyXAYhV01Y0equ9ntlYXWJQ2XQ+NdFDozxRWDtF5/bQL2hH+Lf7S9t1vCfpzbZ3ZYuiXa0NSD2xFzHCiHXarhEtJpQYyytYmGvWmheYTvWHJLKO2aJLf/04FAT3zKGFKPbXRkWCUEVQ9ImIaOe+b3g0avdk9+5d3LLhKikq8LZR6vVaY46rdd1O4CnQF78YJ6gWus+7M0KCL419XrG3cbFqS+XPGrimfu6DT3lPvhkfBkHDxDPiKr6gQQL8VzV22jzt6GL+MuwR6idaqI2qSMNVD0ff5nQ2U0GNizPXVrtJF3I0tkqSlFORZxl5WQumdw6Ee1Ao1LF7zJCoA97kerGZQxeU/2E0LG/9N1iBButV//EIOiLvgwliZGBUI/n7B4/+rvogTcyp78xEjWMW6tWP2VBSUAIQSSYd635E8QLlNJWiENNHPLyBsTlCBUWP1s3l9bsgA4JLKkjCog6cWeCnVywStcE8dhVgYw6/Okc6ETjJOr8WQkWioa267W8f+MXSUHrW9+A6KR7MQQvtP241KdnvpZIFdTYYzMa5vwYHwy1f/xBxXM19Hxp2Bvgjss28+fU5fXr8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(136003)(376002)(39860400002)(346002)(451199018)(36756003)(2906002)(6486002)(478600001)(53546011)(2616005)(26005)(6506007)(186003)(6512007)(4326008)(66556008)(41300700001)(66476007)(6666004)(66946007)(31696002)(4744005)(8676002)(86362001)(5660300002)(38100700002)(8936002)(82960400001)(316002)(54906003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alpLZlV3U00xMTdueG95M253dFRBVXMyV2VEUGJRTUdrNUczZmluZnJSNjNC?= =?utf-8?B?dU8xc0dxU2x3TGk4RHdlOHNxbWpEZkdTUFJhN2NKU1dEWWZ3cUJxS2VDYkZZ?= =?utf-8?B?WDQ4NXhWUFp3c1laOTVOcWJKOXdHQk85SFhVblZJMThaRlhFUWNCVndRTUdI?= =?utf-8?B?TVRtcVhSZ2RXdGxScUpmRHhWQngzdjJxRWtOcGF4a012cG1ud0lGb0x3a2lv?= =?utf-8?B?cUtlNVp5dEx0SThwRTRwV2FHbnBYK1gxWkRJcVF1QVdMTEM5eEpMeVpHQnpN?= =?utf-8?B?MjdWTzNNeDVIaHA5QWVVOWVteHF4K21Qd1NPa2hHWTBTUWlwN2NBNGF2MnY2?= =?utf-8?B?TFBodEhjcGxiZVVNamZkMGpYRnM0U3VsVENmeloyUzkycHY3Z08xTzgxazUy?= =?utf-8?B?cU5jYjlsL1RTK0FlejNDZHAyK1YwQWxTQUQ0cUVoV3hnalo3RmpGaTUyNTZq?= =?utf-8?B?TTdkM0ZPajNYbWRhVVZCRVBMRXliTlNncC9QODZPancwNE8rMW8rcFd5VE5O?= =?utf-8?B?TDNJRWVEaWhuOE05QmtLcFRNL29oVDJLTVBlc1ErYjhwWVNMM3kzWDFmaDlH?= =?utf-8?B?L1pVUHEzMEk5TklTMmNGa1Z4YkR3SG5QVVU4ZnFWb1hxTFhZSFZPbFBLQkF4?= =?utf-8?B?Z0owU054c1NPNUlXYzdxTVJNeENEZlN6eE9jam01ZFBwUzltRzl2YVJDNTlQ?= =?utf-8?B?WkIwU2hBRzJ1VTJ3aW9Hb2pVc0tEMVRCRm8wNXFlU0dRaWljRklVYlhGRmpp?= =?utf-8?B?T09USVhFT29DM0p4ZXoxc1RVeUpzTXlsNWk4aUQrNFlGK2N0RFhON1htWEFI?= =?utf-8?B?Q2V4MHE4bUozdjBHUXBsTFRKVXNFeGhJS3FQT0FqbUNSRitRc1d4R2dyNlUv?= =?utf-8?B?Ti9xcjc3SXJvTUhmNUZYbFVPeHJRUlRxSTF2Q0lpbkgrUy8yRlNXOHV4WHpH?= =?utf-8?B?dVhrQkVMNHYwaVdGS3dubm9BQmlXQ3RvblR2KzA4ZnBjY0JYRncxblFqOEhr?= =?utf-8?B?WDRIMkMxOFNwK3F2QnRJdis4MGM3djREbkI1VDVwNTM0NkdoR3pZdVlvWXdX?= =?utf-8?B?MFpQREhWZWVwdjBobnVzcnZrcmo4VytVeGxFYnN2UENjMTJ5WmhOeWo0MHZE?= =?utf-8?B?aWJkenU1UVlrS0cxc3FldmtOTTZrZVlXZVhXMDBlT2MxVUZybnEwRWNucmlB?= =?utf-8?B?Ti9TM24yT0FJVzlINC96VnZWUm1LaGpYbFU5WnZ3OGFEdU9tdXFTQ1VPYzNx?= =?utf-8?B?SDNhMFcrdElJMFFqQVdNQ25nMW82V25tSnR6NzFNMTZiV2xDQTY5ZW5UclVu?= =?utf-8?B?anhJOC9TM3VpOFplQURFTWdxVTFXS3UzYnRhRDZqU1U1K25COTk4SkFtZlE2?= =?utf-8?B?THdBKzlSczFJaTdldUgzYTRIa3VKTHlaRk14UXRLaW8xTE56cW9lUTNaSW1Q?= =?utf-8?B?ZURVVGRaejNtekF4RUFzd3hVclhETnJLZnRhR001RzJyaFVhV2lWWmNGZ0px?= =?utf-8?B?R2VhZm91cFFpVW5VQlZvbkZISkx4cC9TbXE3T1BaSi9oRDVOOEFuSDZ3R0w2?= =?utf-8?B?aU5Xc2FHZWUwVVhNV1FZdW0vekV0NmZOOERDLzdEMlpua0VuVklJTHFZLzRn?= =?utf-8?B?bnBRWmlkbHhQZ1hqWnFtN21vaTlZek9WZ3hWWlFnNUdWME5NSFpoODFNS0Jh?= =?utf-8?B?QUUrcW5YS2pNVllUMFRYQWlMREdrT2tVeVJ0L2Zoam0rNnA4YXVqaDdMaWk4?= =?utf-8?B?dzNuR1dMZ21mZU8wbERGNW9zWVlYTmxLNUZINkgremFXdXBCanRpTlVBeHd2?= =?utf-8?B?Vzk1ZnVxbGVQN3I5V1JxUHpoOGM5V1JrcWFKdC83OUVmNWV5SzM2QzBvaTNY?= =?utf-8?B?WjV6NCtFMGV4UUdWUytoZGNkN0YyNDhKdzNoWkV5MGFJcFF3RDNOSkR1cXlV?= =?utf-8?B?UjNjVzk3alBqM3lpTXlha1FKdWlVMVFmNHRIK21mV1duamVjdE5HWEpGazVs?= =?utf-8?B?a1dyYVBHdTBVYlhMamhWSFRSaXRjVXFrUXBSWk84R0YyS3J4cllFRnRQU010?= =?utf-8?B?RlhoWGdEV2dFd0FRYUtLVXYvdks2MFcxS1dML01wWVFtRVYxb2dkZ3JkRnc4?= =?utf-8?B?bWZPVDZHL3hJWjVoUnQ4WCtpR29yczNzNGloN2dlZ1JJOGhUYUQwbVFibkFP?= =?utf-8?B?Mmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6pmtGW1ywirS5NAjdx7qBeokSgOvySs4rCPV8XDxAUVZg0LYDUp3Npa9IV9j/DJCWZdweLiqmomkk/ET38mHRvqGMOtVyoHaJe0+OKnLOiMJEhrdJcq5ZOrhO/eB7wf7PfJ7piZUSneImDxRZ1flWV5u68hCKa2qxm5OIUqA3I1JQWaHrFZ3Ux0cNfDy53WHQ9xTsdOijPyE4QGDvSORG15NP9/9H7DOcCn7Prb0NlafnNTEOLMKsfqrRaU+jRWsYD1s42ZSeBNYL39Cex60NcSzuZXDxTOudK4O9M+WCOhnlucgJD3HCiRc979tyN5LCkcJVKGYdyinWvoIULDZNRA8B88fJNraTScEFMKw+VaxbcR629U2Fa/wN1IMbcBf6hv/Zc7a084yt/ag2N9EDZG7hmwtB3W0Cab/VOFnCGAIWOkY+6LTVyVO70z5wN7iLGzX7OmGhSLLaGDu0uNUzxYIAgmY2j564QDQmFkhRIUshCwrq+KAn1hIPsPs1jW1lyW3dPbv8r8vH21sSv5kqsBBhcz2rywTwmlfgKr8+foca7BztQfCcay4pI8hvvcf/QCo3GZZDlxt8W1jzHhw5OwsxKlBY431+FJzFqEDNydLKrMO4aypt8RLYt9r5RiiOMqZU1AOyvQhqIqueuoRqMfCq6aChERKegTz6Sksfx2oDEVZIAneyVfpNEByCiyDY7IA1nFq+humCbci47/Jfquy8MQMeo0+a+sm56s46FlDZYoYXhlr0U7BJDri83LPmH+BZ63x8haRn/qYHainm3OA229ceaBg4w4niIWdOtDeXgUs1JZQeWDkgn/KMYno X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfe78ebf-cfc4-4839-9cd3-08db0aa5cb45 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 13:59:00.2400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +9ZQq5ZT7Oe4xP/vsw/QitWnzU8uo3fkyxD0yNunfxJKPNKTanblrhQOBbwymw3Bauf4AfUNrxUIY+g+gaR/FUtAFuTnYJhE4cMiZkWZl90= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5269 On 09/02/2023 12:11 pm, Anthony PERARD wrote: > libxlu_pci.c doesn't use any "xlu__cfg*()" functions and doesn't use > any of the disk parsing functions "xlu__disk*()", so all those headers > can be removed. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:02:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:02:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492483.762028 (Exim 4.92) (envelope-from ) id 1pQ7V0-0004OV-BS; Thu, 09 Feb 2023 14:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492483.762028; Thu, 09 Feb 2023 14:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7V0-0004OO-8b; Thu, 09 Feb 2023 14:02:06 +0000 Received: by outflank-mailman (input) for mailman id 492483; Thu, 09 Feb 2023 14:02:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7Uy-0004OI-JR for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:02:04 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5471ea57-a882-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 15:02:03 +0100 (CET) Received: by mail-lj1-x22c.google.com with SMTP id l3so2150600ljo.5 for ; Thu, 09 Feb 2023 06:02:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5471ea57-a882-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wJAF3fyyl0empCmQtcu8CcGo550fBA1awJpNU79+SxI=; b=l1oQLHM2hHxZYnllFHpySXOpa94+zD85NUDHPOWieXvRCUGYrvFlvnNwWbeYTF76IO FTdDJEN5IQSPAHC5yrtAAwd3HsMLYcMbMs9Z4vlRKObpTC3a4kda8SKwdtKqru18RFPV 7eM8AGdetgqaE58k/4s2ZJsr824euvTPqeZUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wJAF3fyyl0empCmQtcu8CcGo550fBA1awJpNU79+SxI=; b=KiI8OVtBDmAu+CJd+E5/yNo+KTCMzGIl8Q0fnd83JFNd7I6nlTJD1AAOkUglWOSYfC Xsij9c7xHqPDRpjzlxR6bTWwBHunhYHKom6FMfGKZmCuAcewIuncbtSAcFn045nRRw04 4Hoq3LrKMEkFwZvC//0nMq3riE8IS0UPmGuQJ3quo6k/VS2WeIYTY2NTuFFcRFRZLyZC C+rAjEImONNLD06IRoqQHSn8OUjDh2/IP16OjAS8zlkVg7HDMsv7OD6HZ+vM6WLqCyhw iH99H9PAggso8sEISfBzz2GxauEZ+C82bt06dayw+dDCZ+XhgdpEabHXcWtfEwsxW3Ws Vq/g== X-Gm-Message-State: AO0yUKUR7Sp6ApTz6TEgGkrxWks8IFvdEH0E9GMSv6V0EXCkwa47GOnw UnGI+8d8tcYjfIGzo8PfPUFZbkT+ubjjCWGYLjZGRg== X-Google-Smtp-Source: AK7set8aRAZDw4pYeKT480eJ7Tk5pkIroAEBhXdT3QUL1K/J7HD7iXEJbjg2TuZB14zMbvAj8xEwyybp8rdJJc3mUnM= X-Received: by 2002:a05:651c:3c5:b0:284:6390:1f8 with SMTP id f5-20020a05651c03c500b00284639001f8mr2056303ljp.167.1675951323008; Thu, 09 Feb 2023 06:02:03 -0800 (PST) MIME-Version: 1.0 References: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> From: George Dunlap Date: Thu, 9 Feb 2023 14:01:52 +0000 Message-ID: Subject: Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Content-Type: multipart/alternative; boundary="00000000000044ee6605f444d3bc" --00000000000044ee6605f444d3bc Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour < demi@invisiblethingslab.com> wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > This patch enforces the use of secure transports in the build system. > > Signed-off-by: Demi Marie Obenour > Hey Demi, Thanks for this series -- we definitely want the build system to use secure transports when available. Can you confirm that you've tested the "+s" versions of all the URLs in this patch, and verified that they actually work? If you haven't, I realize that may be somewhat tedious, but I think it's pretty important. You should be able to automate a lot of it using `curl --head --fail`. [1] -George [1] https://stackoverflow.com/questions/12199059/how-to-check-if-an-url-exists-with-the-shell-and-probably-curl --00000000000044ee6605f444d3bc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 8, 2023 at 8:58 PM Demi M= arie Obenour <demi@invisi= blethingslab.com> wrote:
Obtaining code over an insecure transport is a terrible ide= a for
blatently obvious reasons.=C2=A0 Even for non-executable data, insecure
transports are considered deprecated.

This patch enforces the use of secure transports in the build system.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>

Hey Demi,

Thanks=C2=A0for= this series -- we definitely want the build system to use secure transport= s when available.=C2=A0 Can you confirm that you've tested the "+s= " versions of all the URLs in this patch, and verified that they actua= lly work?

If you haven't, I realize that may b= e somewhat tedious, but I think it's pretty important.=C2=A0 You should= be able to automate=C2=A0 a lot of it using `curl --head --fail`. [1]

=C2=A0-George


--00000000000044ee6605f444d3bc-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:03:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:03:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492491.762050 (Exim 4.92) (envelope-from ) id 1pQ7Wd-0005Ih-4i; Thu, 09 Feb 2023 14:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492491.762050; Thu, 09 Feb 2023 14:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7Wd-0005IY-0u; Thu, 09 Feb 2023 14:03:47 +0000 Received: by outflank-mailman (input) for mailman id 492491; Thu, 09 Feb 2023 14:03:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7Wc-0004OI-5x for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:03:46 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 915a1d69-a882-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 15:03:45 +0100 (CET) Received: by mail-lj1-x236.google.com with SMTP id h17so2159596ljq.4 for ; Thu, 09 Feb 2023 06:03:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 915a1d69-a882-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=orY8+KMLnKfslQJnE14XiaXMjZAa+hkRKQd5u/p26Dw=; b=Bv9ixm0D9TOn1V4hEZzfD0PkUtaUYuvZJqgMlOdgdZTmR32kjpGDQ/tdXKI6cb/3li lPWsJqs1T7iiQUPSz3FcwMAmQaRM0zwMQpoOwMAjkAp7w2YoWgG5qk6otVsZwgvBZ+vj vezXNrP98bfDsxdiB+/EKeP0Yy/m7EYjs9zB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=orY8+KMLnKfslQJnE14XiaXMjZAa+hkRKQd5u/p26Dw=; b=FFY1c6JU+2KF67HgAPJcQHnQuyFBs5w92crFTRPs51LsgOXvbXOMLuix5W2vUc+q4K w82D5r8n0BhfrZni2/n3b6jfhQIHfZ/aWJZ0o/ckjJP/M2HO3J5asE+Hmmaw3mhyCCL7 24JmYbxcjrpqqwixyxvqGwpJKK3m8LUe2lJHovbfbNtUQQ63GmgVCQMkFqihlIsEpaan wOopam8Imi6xgnLgJFZjTXWJHdjBGmP1zfd2AMUoJs52vAHj7FPYtrgEwPLx/Fwv8AAN jMmSzEGu7QB/VsBk1i0D2hyrjOij+9WQloxl+oc/+caskyoUBHFytYngE/DASsnAlTFZ 7zxQ== X-Gm-Message-State: AO0yUKVeuaKbXWSr2CwY/4wLdovaXtb3PtHwReS5sawaB004jog6wuCS dHk6aXn2I4wPjUidNwu10XbI2FhrN0lYroW1mh5BSQ== X-Google-Smtp-Source: AK7set/OosX6C8dnwrpyM0kcbx1rnR7RWdXl6ofEbU/wXvRpUF2wgMmJo6E0pErqU18oW+w/F3YetvPU6ipEJHaJCrY= X-Received: by 2002:a2e:b539:0:b0:290:5823:cde1 with SMTP id z25-20020a2eb539000000b002905823cde1mr1849073ljm.122.1675951425116; Thu, 09 Feb 2023 06:03:45 -0800 (PST) MIME-Version: 1.0 References: <8a3d0ce9747e486e91ad5b47777c80293e0fd168.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: <8a3d0ce9747e486e91ad5b47777c80293e0fd168.1675889602.git.demi@invisiblethingslab.com> From: George Dunlap Date: Thu, 9 Feb 2023 14:03:34 +0000 Message-ID: Subject: Re: [PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https:// To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Content-Type: multipart/alternative; boundary="0000000000005af77505f444d907" --0000000000005af77505f444d907 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < demi@invisiblethingslab.com> wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > This patch enforces the use of secure transports in automation and CI. > > Signed-off-by: Demi Marie Obenour > Same question here -- have you verified somehow that the new URLs work? -George > > --0000000000005af77505f444d907 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 8, 2023 at 8:59 PM Demi M= arie Obenour <demi@invisi= blethingslab.com> wrote:
Obtaining code over an insecure transport is a terrible ide= a for
blatently obvious reasons.=C2=A0 Even for non-executable data, insecure
transports are considered deprecated.

This patch enforces the use of secure transports in automation and CI.

Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>

Same question here -- have you verified somehow th= at the new URLs work?

=C2=A0-George

--0000000000005af77505f444d907-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:03:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:03:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492490.762039 (Exim 4.92) (envelope-from ) id 1pQ7WY-00052c-SW; Thu, 09 Feb 2023 14:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492490.762039; Thu, 09 Feb 2023 14:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7WY-00052V-PM; Thu, 09 Feb 2023 14:03:42 +0000 Received: by outflank-mailman (input) for mailman id 492490; Thu, 09 Feb 2023 14:03:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7WW-0004zr-GJ for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:03:40 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b68595e-a882-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 15:03:38 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 09:03:33 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5368.namprd03.prod.outlook.com (2603:10b6:610:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 14:03:28 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 14:03:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b68595e-a882-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675951418; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=HwyilBnRdDbuxMM6JJ4sSuRfOgu/7IiLLvWlt4iDtZ8=; b=YlWNZzX5qBlezjbVVD4cG+Rmifod3mjC8l7jVmD4xpkMqzHaCsXgr+q7 9KrFhTU29Xl53v5mb5hgMlFwy45TeyYL8xoAmkz+3s67LG/L2EgFdXL+V U8v3YMA05R3+sAt/E25ZD/cMppbMI+GiSNQYltTOiW3+8A4G01fPM2Dnt 8=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 96365029 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lUhara9IJ7e5Gz/ecRBUDrUDoH+TJUtcMsCJ2f8bNWPcYEJGY0x3n DQZWD+BaKneNGT2e4p3OdvjoxkFsJeEmodmGwY4+SA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6ga5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklWz domdGEsQyqjqOjtwJWgY6ow2eQ8eZyD0IM34hmMzBn/JNN/G9XmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTaNilAvuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqBtlMSeXip5aGhnWzmF1IUg1HRGLmqLqA1We8XtZ5I hALr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOq8seVTEsk FiTkLvBBzN1t6aOYWmA7brSpjS3URX5NkcHbC4ACA4aud/qpdhpigqVFoo9VqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxtDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:gy7Kxqpc24DVHbcLZDTJCaoaV5oveYIsimQD101hICG9E/b1qy nKpp8mPHDP5wr5NEtPpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qH/xTQXwH46+5Bxe NBXsFFebrN5IFB/KTHCd+DYrMd/OU= X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="96365029" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ep5JwyqbLKrPS6VR+FHfA94mASTVVCSOp2GuAfEG3yU7mk0Kjd8Dt62l/2w7+KfqUmG+bxIYuUR9qhj/bxnK3SMeObo/pi6C8l9iAvm72/Vhbl2ETK7H2h3UnB/T4JAXUe0PWuIpa7Dxr1ZxJ3XYMLKzC/15hKiKAaacxNzFph2/HRY3fVb32Uz3DTP7rCXi6WZI1mwA1cbleqCckLmX7dUwWO+3n7uJI+9siCn9sFieLl7j8/peFLvC2NnRqT1dOuLED4bI4dLY8HYw1HtScbpSDymazYu7mR/xhm36x8lkimFm2gk93O1GToNZgI/0b/4NyZKx9xgv61+AXmZRpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HwyilBnRdDbuxMM6JJ4sSuRfOgu/7IiLLvWlt4iDtZ8=; b=kN+yL8cfuIqHSz6OKNCiZcDrUSGLFVQSiv+i3PH3ge0wJpUJZKtEWFkHZ27z1l+HptQck1COsv4UwrMoKu1weBSj9VuzFvLBapaOhlAs2xhiZ/H3GYae9lA+YMq9tMUzLEALXiZgaqNlIJ1k0Nnq2kKOy0h1D32OXyTzBVKk+TpBjRJ9bgb4NVErFBRTy7lk7cxPIBXpBP3KI7282naVdKtWqJWQex2BpaqVkYunmlWlwkjt++zE48+5LQuBXb4DMz3crDfxVV0mU9i/Qzhc3ExTEZEtQLcfQy6Wy90CQRuAiiappDN42qqCiNsKprqZePYAqjwHPKSr1jAMEqwLCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HwyilBnRdDbuxMM6JJ4sSuRfOgu/7IiLLvWlt4iDtZ8=; b=LoT2GRMWRHXMt1MCPPuFIT7ilwLYiEE4Ch0fHlcpTO6WORT/qs3maeUlvz0ASK+uJyYKwcimAY8eaZ59lOZt0CZz5JEfoqjTB5+xT4xJfVN00pkg2JVEL7hHg/4p+aRq5J5lqO9S6HqVFuy+78rrmh3Xm573/GnOrmpFdXgM52M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 9 Feb 2023 14:03:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH] libs/util: Fix parallel build between flex/bison and CC rules Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Juergen Gross References: <20230209121156.11040-1-anthony.perard@citrix.com> In-Reply-To: <20230209121156.11040-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5368:EE_ X-MS-Office365-Filtering-Correlation-Id: 07fb5ce1-5402-432d-76b9-08db0aa66adc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: luYDRHtvqRVKR4AL3fA/GuGPFXwrdcRyeKc7Ldey9yqr7g2dfj19uedOwV9OGO2mOEImRGABPKPL+1ubSMD7V5NgnucuHpZCrIwsJmgn+3M+3CIwtge/pT7rsgsqLXEY7jU+BWK8hPAgan3gD+fH3q0YLYXfkYaJ64lkOcQYj4zlRJ+d4ZwSgpiiHqymZ2DIJYL+kw7tpgMLmy6S9LHD4Q9Kcdjj2yNT3nUJ7qtrQZmB4dqU0+CTdEcCNvpIoKZ6h5da8GjXJHMtSsAJ2zM0EV8CqzWSPhVSIvj6WgML/24yDfo7MC/nTtx46RZAO+yyL1w4RUa52t7Oxd8tslRA/HTuzGzBV5PbbIfgH4sh9dASsl4e+5W8T2G0vCYPInV10+5DSMvHWBkb9TCDYpMw0nGKCGOXzE1KiLPipwklvFsezg5upgKiOgLEU7RqObyFCaEjktS4FKSIhzf06knJdDThy1Z5lFcoS8z90pfw3DxodBU7op+Qa88F9EhlqWNrhvOlb4WeEew+qCNjTNVTCAKuvrdovdkiAgKFhyNl+Z2EXlnCpu5l/+Umo5fX4NMoXjk5jNypdM6DKNaBxyfrMAiuNe7FiJnrRhv00WvGf5X4fmk4s9nUguwS+roKzB+GEhcX5kPNP/Swjf6YW2ZFZAEmSGuqeMWjGAeJo3cC2V6zou+lo4PZj3e2YGVg/6wmJK4CJbQb7DR4EDoazSTTN/tFypdhMLJrW4WIOD5dRl8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(396003)(376002)(366004)(346002)(451199018)(8936002)(41300700001)(8676002)(186003)(26005)(6512007)(82960400001)(38100700002)(2906002)(66946007)(66556008)(66476007)(4326008)(2616005)(54906003)(31686004)(31696002)(4744005)(5660300002)(316002)(86362001)(478600001)(6486002)(6666004)(53546011)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vjc0NlhYdnArdkJoZXRHYkwzcytyZjlmMzBRQmtlMUdXaDBDbUZRdnp5cUhJ?= =?utf-8?B?VnVybTI1ZFZsU01UQm1zclZmdzc1bHVmVC9ZdG4wUHhQV0paK2lMeE4waHhp?= =?utf-8?B?eTZhcU9rT1UzZHdvTlBlTVZ2WGJHQ0hTWGNwTkRDT01XTXgrZit2Sjdvck4y?= =?utf-8?B?SGlIWStPeDVrVnhoK3dXdlk1eEdncTBPZ3hoQWFMNGtYYllLV1JJZHR2aEhO?= =?utf-8?B?by9pUzV0NlZHTjNuTjh4TE5RZ1diTEk0VHE1M3hRRHBMVDRvb2ppcHhvYUhS?= =?utf-8?B?WWg3bEp0eGJSYmk3cm1BUXpkR2V5RUxEa2tyU2oyOEFSY0d5TDhPM3FqQ0Ft?= =?utf-8?B?aFJJdW4xbFdwTjk4OWZHV3h1ZVFIWWpxaVpHcWpSUHRqc053dFBsSC83WnJu?= =?utf-8?B?MzJYUEdLeWZoMXdhRjhsZDEyanYrbjVyNk1lWTY0MlZQQXd4NWZKSFZnSDJz?= =?utf-8?B?U3haMHUxTkd4L2NYSEM1b21HUUlmSVZOcTM4dm80dXh1dGVTbjZNbkxRbHpY?= =?utf-8?B?eWtQak1ESjM0TzZFTXRsWVMvTEZhQ3JrelJuVnhhS0JXVDRCbXFsWlRZOXZ3?= =?utf-8?B?NnBEc0hhb0NBWlRkZnpoK3B1bkVuNjIyTGNoYXl4T3ptZGZVN2hyam16bmxY?= =?utf-8?B?eUZMUlpEc1ZZYWJycDdPelVJTVk3WkkvNUxRbDNLNnF2eGVwVEFrVGVQUVRV?= =?utf-8?B?dElRWW1zbGFyQ2NZOHpaVktVQkt5Q3pKL1Zxd2tTSWxCc2VPb1RTS1laR2Jx?= =?utf-8?B?UmR0U3N3TktVTEJZTTAwamdna3hRNEErYStTYVFjc1ZLMjdGamd4cVpZR2h3?= =?utf-8?B?S0lsV1FoeXhFazBJeWFid1RYMisrZUpINjh2Z04wWHBtMEkvQzZpcGkzeTV4?= =?utf-8?B?U3VNWUIvQ2pRMlN0QmV1Wm1qQXZ3MXhsdktBM0wrN0R6U3FBaHNMaXB6WVZN?= =?utf-8?B?V1NMYVFqd0prUXRLdlZpU2swUnhJdlRENm1neHVFQm9BTjUxb2tFNnVTdkpK?= =?utf-8?B?ci8wVFQ0WTZmazFwbm9aKzZ0VXc0WVZIQ0QyaUovZHp4djdwaUNxWC90QzNw?= =?utf-8?B?WDJUcTJZSEhqbFJoRjZsL1c3aXV2Yy9lYitRTDhCMFdLMUhiV3g1MGxQNEJJ?= =?utf-8?B?bmFNejl0Y2FqZm9TZTcrVGNKUzFMYXRvYi9yZEtIZUdDSVpQUW5SUGNQcS9Q?= =?utf-8?B?QU03Q3NLdzNrelp1amo0VmlKWC8zVmdYeVRtSlM5dVVvZzVFZU5HMFRHdEpW?= =?utf-8?B?N1NCS05IM2p2b3hZTjZqN0xzQndhTFhSWWY0dDd1eERsRmlTZFBwV2MyT0Jo?= =?utf-8?B?RXJKeVdFSzZrcFVsbDYzUERRNTZLTlFMTlJCdGRuYlBDbVpxNmFkL1BJcXIx?= =?utf-8?B?OHVPOWVEcjRYMXNybjBDQXhiS1pBcVJTTzhzdTdpSjBuNWhQTzJXMURRb3Ja?= =?utf-8?B?a0FlTXBqMDl2THJ3MmoxLzZWdDYzd2tWV1ZkY3dNc3VHdjFMbUZiUjAxYWdu?= =?utf-8?B?NlNJNWRiQk5vUlllTlp6NmpOR0xZQU5rTGNFTzZMSHpkSk5GZklPL1I4WGZz?= =?utf-8?B?U3N2QUtZMWl2RXN3Rm1oeThzNHlocjhucFlkZ1REaEpaaHZMdmJyRVV2UWRs?= =?utf-8?B?U1ZoSGVaOHhiNlE3RW90VVZVcnNzRTNiTkRPYlhHU3BYWk14TEtmcVdhVVl1?= =?utf-8?B?Y3pNSHRsVnFDQjVQVGNSRmx1SHVxWk1hSHNRZzFuUFdLOStXMlllTWFKdW45?= =?utf-8?B?RlROUW8xc2UzT2hzSm91YWRLdFh3NDhpK1d1bnZGcVdGM2xUUHVHUURlTWE0?= =?utf-8?B?bjF3V2JUTGd2Mk5qVlF2bWlvSFF6VmMwb05Dc3ZjZ1dmY0FkeEZDNWlKdXNB?= =?utf-8?B?V1NmcUJTbUJ2YmlGR3JBbnRnK0VOdjN5QURnMmlwQXdiZW1rdzM3VlFvYnNz?= =?utf-8?B?K1M3OTRVcjZZTUkvOU8wUFBhWVc1UTFvazFRdXUvaU52cDJlQ3BVbG9aMTha?= =?utf-8?B?dFBsdjNleTJQWW5uaWpMeTdpOWdkZ0FmTU5UOUI2MFEyQy80bTZpS0ZOSnc5?= =?utf-8?B?SnZlUjBFSFE3UXc2RWp1WFovdEFkamh0YmNYeXF0VmIvUFBURitGbFh2L0RL?= =?utf-8?B?TURZQzZRZ2kvSDQrMnBSYThJWXYxOU9Lc3NMNWhXTDJVNGVUTGo0elVHUjRi?= =?utf-8?B?Snc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wkP0enxLkFbbYbaNNCwmf7rEgjzlmyiD72sZuSrMxN5wBc6RwZRN2zwyY48LR9bto1kyzkJhAMHYtICKmmenbQpIn81z1bI2aO6w6tDDF5IHIQqkLytvrxd3pECxvF2Eut4762bFfT/SIpPp/cns27VEkIVLmAkHD5yTho139/mvf1q5Mel9tKnFl6z2XjeBH1e9sMJlo2Icq56x9q04bXSbJcJNZwXgGHzZGA+7+btcUSQG+G4heDRr7HLSClBe9mnJCkunfUuq8d4q3JoorKxhgv8NHahvpfqRnVY1XruW5F9viDZYWIGhl4NDTOzEW6H+W38AkyHoNC0HAps/TATW8/LaCyZMbPie2V4IpTDOiFZ/v6C6eeTOKfJJGMggfq+LL1nNRc472tsuqzcIr7t5iz6z8PjdgpginA7gkroY4CMFG0GAb7XC1UmUmiUisnySiuNhvfM9etuqhB4RZoi4NK7y+K2W3oeJiZKkvxSzFZZ3gLOrLgxl/lWFcNjPzaRRMd50j9x+sngH7HjYnW7g8Vs/1BplTPnKyA6fXNLuMTl8ghMa2uH7LjpuKRpGfcrMviRqrAD0jdNWX4WJuezDBBGk/vuPoW4jKKCg3g7CnbXCxHQuDetZClkS0K4eocDYc0kzlnxhvRLr1pG89K9tKYLp+8jDy0v+MUGVF+e1bxAIT4F0G8UFffYQcTTv0YvtsSSNho/paQnfgT5utdMw6VSOKQpPSthpj5R9UFeuZPl3NNySh8bc6NkQlEuPS2ksc16884PCs5NuxCpP1nXdI55FwnIOCrVo29V5a7weky4kjwH6usWkjmmP3Ghj X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07fb5ce1-5402-432d-76b9-08db0aa66adc X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 14:03:27.9239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eGup5Axn4wZ5iD8r0QmtCOJ+l4y8U5hWrQITMifALj+2szWvVtKTUmm8z32FxfnOSEXdnDRbXD7amgYDyF0qyH5BdLxbJU7ck9g8QMcMNIU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5368 On 09/02/2023 12:11 pm, Anthony PERARD wrote: > flex/bison generate two targets, and when those targets are > prerequisite of other rules they are considered independently by make. > > We can have a situation where the .c file is out-of-date but not the > .h, git checkout for example. In this case, if a rule only have the .h Nit.  s/have/has/ (Can fix on commit.) > file as prerequiste, make will procced and start to build the object. > In parallel, another target can have the .c file as prerequisite and > make will find out it need re-generating and do so, changing the .h at > the same time. This parallel task breaks the first one. > > To avoid this scenario, we put both the header and the source as > prerequisite for all object even if they only need the header. > > Reported-by: Andrew Cooper > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper This is a very subtle corner case. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:17:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492504.762061 (Exim 4.92) (envelope-from ) id 1pQ7jF-0007U0-BH; Thu, 09 Feb 2023 14:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492504.762061; Thu, 09 Feb 2023 14:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7jF-0007Tt-6t; Thu, 09 Feb 2023 14:16:49 +0000 Received: by outflank-mailman (input) for mailman id 492504; Thu, 09 Feb 2023 14:16:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7jD-0007Tn-T4 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:16:47 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62aa6125-a884-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 15:16:46 +0100 (CET) Received: by mail-lj1-x22d.google.com with SMTP id h17so2205986ljq.4 for ; Thu, 09 Feb 2023 06:16:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62aa6125-a884-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mYBVpQ5IUOfQCY2t2hp407RYRtDn73JjCCQEERmdOxQ=; b=VV1AFx2F+J7Vg3JIVVr8s1OnLH/wc/Z+gQriHsCOERx17Tf4VfoeQSCIQCTjdZGBk6 BFCKsvRX4UXGVqNsVz6NK+6BMIp0zYwe3wK2Pd9Ese4o1LblULkGBgENsvN8+GBGipAL TOtzsXaQnfRWSIOXziPjXWSaPbSyIbfm3OtVw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mYBVpQ5IUOfQCY2t2hp407RYRtDn73JjCCQEERmdOxQ=; b=YHSYKOAdXAUn6Pd/cVoDprOKz0BvK6jl/xzDfWhiCzFmcUxBzrHCkBVilyLmEc/Q5V LiTSCVBHzjeZ2c69IM0LQAKFQGGAQGdRvbqRpPpWzCXaynCmmCi0pT5gwAU8slYOYn/m +q/r8bg7EwfFf5rH7SQ5fZf3R2n6pE0q45dM4/ZNSQjhLpJuZx6sb3uh7tob1UKF1RMU yR0Ws/nGsEKe5FFV7HyZUcKtSLp+tmw/zxnue9SrOVBJWOXwVpo3NsLVARjHAUowRJZC HkalLm8X9M2miI1GhAtFtWBtUTnRq3+qZBMnPHtCaaSv56JItktHTSNvFuZEAyZY6wBk qnbg== X-Gm-Message-State: AO0yUKU+ADZSur5eJyUF252tPxzSXXIiRa1705dCFbIVQkSCaekYGoCM rRCrHVAz1C9dvdury6wRHFEpNgyXoi3TYwZR8yz6ZQ== X-Google-Smtp-Source: AK7set/QrMN9v3tpc5aA25agRnmx13ZvshQhU07KiTjWlC3RmdWdYdsK/wsk16BhpW/Fz4QSgpRQf3hsichDLkEXBJs= X-Received: by 2002:a2e:7a09:0:b0:293:2e0a:da94 with SMTP id v9-20020a2e7a09000000b002932e0ada94mr616027ljc.136.1675952205932; Thu, 09 Feb 2023 06:16:45 -0800 (PST) MIME-Version: 1.0 References: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: From: George Dunlap Date: Thu, 9 Feb 2023 14:16:34 +0000 Message-ID: Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS To: Demi Marie Obenour Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Content-Type: multipart/alternative; boundary="000000000000e5420405f4450719" --000000000000e5420405f4450719 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 11:21 PM Demi Marie Obenour < demi@invisiblethingslab.com> wrote: > On Wed, Feb 08, 2023 at 02:58:38PM -0800, Stefano Stabellini wrote: > > On Wed, 8 Feb 2023, Demi Marie Obenour wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > > blatently obvious reasons. Even for non-executable data, insecure > > > transports are considered deprecated. > > > > > > This patch changes GPL boilerplate. > > > > > > Signed-off-by: Demi Marie Obenour > > > > For the licensing boilerplate, I think it would be better to switch to > > SPDX instead. > > > > That said, given that you have already done the work to covert the GPL > > boilerplate everywhere, I think this is OK. But if you have time and > > energy I would love to see a patch switching to SPDX in as many places > > as possible. > > The only part of this patch I actually wrote is the commit message. The > rest was generatedy by: > > git ls-files -z | > xargs -0 -- sed -Ei -- 's@(http)(://www\.gnu\.org)@\1s\2@g' > > followed by the usual git stuff. Thank you for doing this; but unfortunately, to feel comfortable giving an 'R-b', we'd want to have some confidence that the new URLs were correct; making this patch as posted is basically impossible to review, even knowing the rune used to create it. I think if you specifically focused only on the URL in the license boilerplate (i.e., http://www.gnu.org/licenses/), and included the runes used to create it in the commit message, then it should be easier to review. Alternately, if you had some runes you'd used to verify that the new URLs worked, then we could review *that* instead of reviewing all of the individual URLs. That said, since it's been suggested that we intend to move over to SPDX entirely, I'd understand if you didn't want to put in the extra effort here. -George --000000000000e5420405f4450719 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 8, 2023 at 11:21 PM Demi = Marie Obenour <demi@invisiblethingslab.com> wrote:
On Wed, Feb 08, 2023 at 02:58:38PM -0800= , Stefano Stabellini wrote:
> On Wed, 8 Feb 2023, Demi Marie Obenour wrote:
> > Obtaining code over an insecure transport is a terrible idea for<= br> > > blatently obvious reasons.=C2=A0 Even for non-executable data, in= secure
> > transports are considered deprecated.
> >
> > This patch changes GPL boilerplate.
> >
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com> >
> For the licensing boilerplate, I think it would be better to switch to=
> SPDX instead.
>
> That said, given that you have already done the work to covert the GPL=
> boilerplate everywhere, I think this is OK. But if you have time and > energy I would love to see a patch switching to SPDX in as many places=
> as possible.

The only part of this patch I actually wrote is the commit message.=C2=A0 T= he
rest was generatedy by:

=C2=A0 =C2=A0 git ls-files -z |
=C2=A0 =C2=A0 xargs -0 -- sed -Ei -- 's@(http)(://www\.gnu\.org)@\1s\2@= g'

followed by the usual git stuff.=C2=A0

Tha= nk you for doing this; but unfortunately, to feel comfortable giving an = 9;R-b', we'd want to have some confidence that the new URLs were co= rrect; making this patch as posted is basically impossible to review, even = knowing the rune used to create it.

I think if you= specifically focused only on the URL in the license boilerplate (i.e.,=C2= =A0http://www.gnu.org/licenses/), and included the runes used to cre= ate it in the commit message, then it should be easier to review.

Alternately, if you had some runes you'd used to verify= that the new URLs worked, then we could review *that* instead of reviewing= all of the individual URLs.

That said, since it&#= 39;s been suggested that we intend to move over to SPDX entirely, I'd u= nderstand if you didn't want to put in the extra effort here.

=C2=A0-George
--000000000000e5420405f4450719-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:23:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492509.762072 (Exim 4.92) (envelope-from ) id 1pQ7pj-0000Wv-1l; Thu, 09 Feb 2023 14:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492509.762072; Thu, 09 Feb 2023 14:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7pi-0000Wo-Uy; Thu, 09 Feb 2023 14:23:30 +0000 Received: by outflank-mailman (input) for mailman id 492509; Thu, 09 Feb 2023 14:23:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7pg-0000Wg-VG for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:23:29 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 500993f0-a885-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 15:23:26 +0100 (CET) Received: from [192.168.76.135] (c-73-221-192-123.hsd1.wa.comcast.net [73.221.192.123]) by mx.zohomail.com with SMTPS id 1675952597302467.34783408887415; Thu, 9 Feb 2023 06:23:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 500993f0-a885-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; t=1675952601; cv=none; d=zohomail.com; s=zohoarc; b=b8NPf8768ZiwPMXtR7cM+wQKzDM9DBoqus8bta44MSQNZ6bGIdpQOmYazuyD99iMcsNfI+peOKpASWqpXpKcm7YNxkcIyVVESN0IXBj2Ke37+OC5nZbGdwCPiT1oLGKwndD0rLPWWHww/fxNVQ/oS4vQixcCmNDwNIspZpC/NVU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675952601; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hdeCoY/YoXDXf/A4m7BydX1bIlOrLfHRzkWbqt74sEE=; b=jMFJQLkZNlOu/wuLuWDlg42/CpSKTDdaTegHmIGhx95tUi6wJf4BSyfu95bkSaa9A3xE9uzFccugIhjuBFtlFj+QIoYQo2N3OLt8LyNbE4dgvZGS2dGKndATLZcCSijLp0qsmavLB8cru18Oii+lnJuBOI1IhDBqbO9oW54lb8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1675952601; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=hdeCoY/YoXDXf/A4m7BydX1bIlOrLfHRzkWbqt74sEE=; b=YOk0GBorXrcg6/LdVuZ7WD2taRJRCrBxkS/HX02a15E3lRxQRw//t6d+DdaBkl3y cl1xuXnhwjhPBEedrB054lAxGf2pVKlxSeHHXwIKiAafVwa5BZ2iQt9k5KBIFf15M3T qs2qLV4ip5K6HBgRIjERa1wROap+1pq8fUPT12ig= Message-ID: Date: Thu, 9 Feb 2023 09:23:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/6] common: move standard C fixed width type declarations to common header To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 2/9/23 05:38, Jan Beulich wrote: > Have these in one place, for all architectures to use. Also use the C99 > types as the "original" ones, and derive the Linux compatible ones > (which we're trying to phase out). For __s, seeing that no uses exist > anymore, move them to a new Linux compatibility header (as an act of > precaution - we don't have any uses of these types right now). > > Modern compilers supply __{,U}INT_TYPE__ - use those if available. > Otherwise fall back to using "mode" attributes, but this can be relied > upon only when bytes are 8 bits wide. Should there ever be a port to an > architecture not matching this, it would need to define the fixed width > types locally by some other means. > > In a few cases inclusion of asm/types.h needs replacing by xen/types.h. > Further in common/trace.c take the opportunity and also drop the > apparently unused inclusion of asm/io.h at the same time. Finally in > some Flask sources inclusion of asm/byteorder.h needs moving later. > > No functional change intended. > > Signed-off-by: Jan Beulich > --- > RFC: I know Andrew would prefer these types to move to a new > xen/stdint.h, but not being fully convinced of this myself, I was > hoping for others to voice views. > IHHO since there is already stdarg.h and stdbool.h, which establishes some degree of following C standard library includes, it would seem more logical to move to stdint.h. The main point here is not whether following the C standard library includes is the right approach, but that consistency is more important. Having a mixture of types.h and C standard library includes leaves one having to keep track of which C standard library includes are present versus what is in type.h. From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:24:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:24:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492514.762083 (Exim 4.92) (envelope-from ) id 1pQ7qG-00013o-Eg; Thu, 09 Feb 2023 14:24:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492514.762083; Thu, 09 Feb 2023 14:24:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7qG-00013h-B7; Thu, 09 Feb 2023 14:24:04 +0000 Received: by outflank-mailman (input) for mailman id 492514; Thu, 09 Feb 2023 14:24:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7qE-0000Wg-Gp for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:24:02 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6585bda7-a885-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 15:24:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 34D973758C; Thu, 9 Feb 2023 14:24:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E5084138E4; Thu, 9 Feb 2023 14:23:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nSxUNv8B5WNgEwAAMHmgww (envelope-from ); Thu, 09 Feb 2023 14:23:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6585bda7-a885-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675952640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kPVYtTshZElt05IeISW6FY+2mHTaltTEBhtcX6TDcSc=; b=ESf3uEpaXBGZyuiAjbFSTk9+XQKaKbsIq9f5UIbAijUYX14nH4joqMDPyBpUzPgrcJ1TUr /u0jNjKkI79WzwJSHF1lQawATZFa81JnlKquFQcCyzZH8OJmhtbXrR/zEKltHKghVT+vzg lBJ/9FmlKE5PObEGZzgY6VMxVlQMtjU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] SUPPORT.md: update version to 4.18-unstable Date: Thu, 9 Feb 2023 15:23:57 +0100 Message-Id: <20230209142357.3270-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current version is no longer 4.17-rc. Update it to "4.18-unstable". Signed-off-by: Juergen Gross --- SUPPORT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SUPPORT.md b/SUPPORT.md index 295369998e..aa1940e55f 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -9,7 +9,7 @@ for the definitions of the support status levels etc. # Release Support - Xen-Version: 4.17-rc + Xen-Version: 4.18-unstable Initial-Release: n/a Supported-Until: TBD Security-Support-Until: Unreleased - not yet security-supported -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:25:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:25:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492522.762094 (Exim 4.92) (envelope-from ) id 1pQ7rV-0001kc-OP; Thu, 09 Feb 2023 14:25:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492522.762094; Thu, 09 Feb 2023 14:25:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7rV-0001kV-LY; Thu, 09 Feb 2023 14:25:21 +0000 Received: by outflank-mailman (input) for mailman id 492522; Thu, 09 Feb 2023 14:25:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7rU-0001kE-Ac for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:25:20 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 946a7ec9-a885-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 15:25:19 +0100 (CET) Received: by mail-lf1-x129.google.com with SMTP id x40so3323344lfu.12 for ; Thu, 09 Feb 2023 06:25:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 946a7ec9-a885-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nmbUHYaFb20s3IDUop8Y1ksEqgfrq5NYyk493kgF8DQ=; b=Xkjbjlig6xdp3EekhpNd5CFjKTIA93kdWZPou0FhGAApJx1GH6ocCv11UTKPCbPlqp PrRq6P6hzUwgYRAh4dsxF3FOFqcfQK7PcHlkxz6EUP8W+8Pa6KgN4nW7EY5uZKYy3f73 OJ+n23jzbeY5u9rB0n+r76tvb6JSvsrheBzt0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nmbUHYaFb20s3IDUop8Y1ksEqgfrq5NYyk493kgF8DQ=; b=A2ONJ/zMyPlPqeXHp/gEuY7WCuVqN/PXHDmXH1eXeJt4djQJ46Xpb2aow3LVitFCBt Z/BzOQq2D97ad0EV1SNh5SubzWkbIYx3txNKcj0VhF+HU4++bUpCgdwGjSDPwXSqb8Qd MOZdkTIAVSEDM4k9orz/6e4o6faFxUdMEgIw2qZG6UaXL60m6xu372+0/XlxkmWZufqk fVOfk34H/nXD4A0zSYt1iIRleO2fBzP8okMMfMrZ8tUbDvDNZ/ob+cqRl+XgZaVohGUE scMY+atoBULkVVRR3wCeI16EX0MK93gdhRAnTrBeoLizLvJ2Wu0Kti9IIS05xmFkoi+w Rw8Q== X-Gm-Message-State: AO0yUKXqBZu0FTOFsbIqYHLAPapbeICl1XFsD3P6G05BqAnLD3IKen9l Heq6XkeQMQJ7ugzXLw/K/RuJQ55b8a+FatuYK5rciQ== X-Google-Smtp-Source: AK7set/kOpnSj3uD891pkNboMFNiBg8SwpeTAAbthaiYJIzLjG0zIfhgDYpk/xx1523tPk82gd2KGcQBApKPw1vBjDI= X-Received: by 2002:ac2:4830:0:b0:4d3:f1f7:9632 with SMTP id 16-20020ac24830000000b004d3f1f79632mr2256643lft.51.1675952718918; Thu, 09 Feb 2023 06:25:18 -0800 (PST) MIME-Version: 1.0 References: <8c476ad1d36919f31c3d37edc813182e8f1489e8.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: <8c476ad1d36919f31c3d37edc813182e8f1489e8.1675889602.git.demi@invisiblethingslab.com> From: George Dunlap Date: Thu, 9 Feb 2023 14:25:07 +0000 Message-ID: Subject: Re: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant Content-Type: multipart/alternative; boundary="00000000000078cade05f4452658" --00000000000078cade05f4452658 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < demi@invisiblethingslab.com> wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. > > This patch changes miscellaneous links that are not used by any > automated tool. Some of these links are dead anyway. > As I said in response to patch 4, I appreciate the goal and the effort here. But I'd rather not replace a working link with a broken link, or a broken link with another broken link. If we want to make this change, I think we're going to have to be creative with how the link replacement is done, as well as in how it's demonstrated to reviewers that the new URLs are valid. One option, for instance, could be writing a small script that would check the link validity first and only make the change if the link was valid; and then including that script in the commit message. The reviewer could then convince themselves that the script was correct, and give an Ack or R-b on that basis. There are probably other ideas as well. Any thoughts? -George --00000000000078cade05f4452658 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 8, 2023 at 8:59 PM Demi M= arie Obenour <demi@invisi= blethingslab.com> wrote:
Obtaining code over an insecure transport is a terrible ide= a for
blatently obvious reasons.=C2=A0 Even for non-executable data, insecure
transports are considered deprecated.

This patch changes miscellaneous links that are not used by any
automated tool.=C2=A0 Some of these links are dead anyway.
=

As I said in response to patch 4, I appreciate the goal= and the effort here.=C2=A0 But I'd rather not replace a working link w= ith a broken link, or a broken link with another broken link.
If we want to make this change, I think we're going to have= to be creative with how the link replacement is done, as well as in how it= 's demonstrated to reviewers that the new URLs are valid.
One option, for instance, could be writing a small script that = would check the link validity first and only make the change if the link wa= s valid; and then including that script in the commit message.=C2=A0 The re= viewer could then convince themselves that the script was correct, and give= an Ack or R-b on that basis.=C2=A0 There are probably other ideas as well.= =C2=A0=C2=A0

Any thoughts?

=C2=A0-George
--00000000000078cade05f4452658-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:26:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:26:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492527.762105 (Exim 4.92) (envelope-from ) id 1pQ7sa-0002PF-2D; Thu, 09 Feb 2023 14:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492527.762105; Thu, 09 Feb 2023 14:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7sZ-0002P6-VK; Thu, 09 Feb 2023 14:26:27 +0000 Received: by outflank-mailman (input) for mailman id 492527; Thu, 09 Feb 2023 14:26:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7sZ-0002Oy-2S for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:26:27 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7ddb38c-a885-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 15:26:23 +0100 (CET) Received: from mail-bn8nam04lp2042.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 09:26:17 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5293.namprd03.prod.outlook.com (2603:10b6:208:1ec::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Thu, 9 Feb 2023 14:26:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 14:26:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7ddb38c-a885-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675952783; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=KunQBhK7Hj4Hztta0KGeACXw5xMSAty9n5B7VdzjNFI=; b=PTDMHVV37dkde/YA0jEkPWhOfnfQ0LJGx+WEdsp15NvA1XEo82BtAhAK 9zTxbSSoBuK+3/8P6004Grs7Wc6D17Yq1Oc2ygafAACjiOPVEf3FEnkLd GbJUCTaqqIOBx2/qHgVx/FjcBpJCtMOUTQAcXOVqRR1/F/zWszpRBXDqz w=; X-IronPort-RemoteIP: 104.47.74.42 X-IronPort-MID: 96772526 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IchvKa/fOwe8oV+41X+7DrUDWn+TJUtcMsCJ2f8bNWPcYEJGY0x3x mcaUDqPaP+PZmL8ftx+b9/ioEJVupaBzIViSQNq/ik8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6ga5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkltq /5GLikrTCvY2d+p/uO8F/BTqPoaeZyD0IM34hmMzBn/JNN+HdXpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTePilAruFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqBt1NTuDiqJaGhnWY2mwvLQRHR2GWmtWYs2Odf9l7N xULr39GQa8asRbDosPGdx+3unmfpTYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXQ3+A8rafrRupJDMYa2QFYEcsTxYB4tTliJE+iFTIVNkLOLWuktT/FDX0w jaLhCsznbMeiYgMzarT1U/DqyKhoN7OVAFd2+nMdmes7wc8boj1YYWtsQTf9awYcNzfSUSdt n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB0B3hosEdMxX HLuhA== IronPort-HdrOrdr: A9a23:EMN2parn7/ke7rZyv6YfVwEaV5ofeYIsimQD101hICG9E/bo8P xG+c5x6faaslgssR0b+OxoRpPwI080hKQFhbU5GqznZgXgtS+DLYlk6ofmqgeQfREWn9Q1vc tdms5FaOEYImIUsS+Q2njcLz9P+qjlzEjh7d21858mJTsGV51d X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="96772526" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alySsNWia1HRXUZqbfqCqZL4zkE4Q/iD4FLKK28BU3/a/OxsKgtkX7RxWXfH2oMkaKBImeN8twPXedCfS99BHM9N5W2qjmaZFx98ElmPbu13T2VNstMkvM30cbneAt+Anyt7dFA3wHE/yoUgo5ZiiCoku/eJQ2muCleleSiqW0Qye7XR9P5A7vaxjctBdhzDupxH5b4d81sPrLF8JGF4lfrUR7G1ZgA0lLCaub6CqQFvpsQRXYgmvX/YvdKimEcX0of4jmtQ8RzBI+Cs3bBVtC0feqH2ELWDfw6tg1pup+InYdqncmeZW/hUgbj8dtHQzeYB+epY9PywNvwlU4bbdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KunQBhK7Hj4Hztta0KGeACXw5xMSAty9n5B7VdzjNFI=; b=KiUPhAoFtXB8L1oKb3+9IYnw/+gzzAoYgxBGITSFFIt9p2/wfRPN7Y7umBJ7G3yyjW5yNoazOlhLIqBfqf4hbRTWP6YIbt+XcPguUfhqAacDUA2Lkqef4jK58T/Fd0F15iyo7gIvzuJHcD+LZ0QKo2pf53OQ55dXx5tqKOE5wGSRB6pSkxybWP5ORWR1LhbUVrx/SW/XLKQVFtjd1c89O7gm6flU9j1VvKJDyhjrpIpawkfV5XFTNb9n5HaVRdO1hGx0ZMFeYkL6HLX7+EiO7U2ZuuNc1ls42J+Za5w9EYLEugdCPEx+/DlMIC1N49vN+kyaxaYVbCIUb6voPWsfJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KunQBhK7Hj4Hztta0KGeACXw5xMSAty9n5B7VdzjNFI=; b=HDe0lkNaTQmZ83aVvwu+CfMLq8yCfIQNIUz/MeBXLqSX1DALY/lSqDMcTdEnoqL/aA6itBf9MZ2YtxLUtKl5bR+7etiHiEAbTXVTrLyZSu0EDE9wJqKiIJROF9QPcd5HI/7tpAV8MZHhUH0Wj2cyMa3iNq9MjL7Gijoih6uivDU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 9 Feb 2023 14:26:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] SUPPORT.md: update version to 4.18-unstable Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230209142357.3270-1-jgross@suse.com> In-Reply-To: <20230209142357.3270-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0242.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5293:EE_ X-MS-Office365-Filtering-Correlation-Id: 327fdaac-5c5c-45e1-8b46-08db0aa99926 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mDVBfP/eeR+tsB4bGp3kLwvbR6HvdyCrtESSYLgq2R0He17o+2GFJEWkqNmwA6246AVa3deF4Y3WPebU31gbqCxAa2FJTX3UuKkfVU7aK6dXuehLX0W95QBXYlUtSCHKgj+CRN8Y40aRKid+KRsunxtyHfZ40eOpJeL07ltIf/8khSHew9hjyLg5IPfTKUyvWpgbCvPADo56ZjijRCGH3UO5AYt+jTBbxf+Iwj4NtRY7jN7PRr9TVoPnU87T3NeDhvrUVOON0v64lGYlNS2ZMDtAQnJcvfg+HB99A//IMAUndqpcDJvGgpfiIdhHqY2cRb6Q6gRU22ooIpL8L8yrK0JIeAPlTyjpeDxsfA6KIEt2yTxwWbR1idCRVISX7i20/i1CmSnU9gP3t2m6kvTMvdifN9qKpWYL+KgF28jGo6pVNl6vc5Dh33K8ywSAo+xZdJLWwfDYv89p52fjXvA6/fFpPesl4WAd8hmWoCUOmy+bWsTKAeI4Ar6xtkVCfZ/2xajlc6AW5IhFUt/Yq0LJdVmivfcam2PC2fE/GFHVVVcu4x5FEHwAYO8hQXjHIbphJuziRbwTMgLirflCINiwMxagpJukadywQKfM7J/+0k40+iMGSAnpWEXYMng/Z5ygzOfaIkW4YqSlJTxkYkAXIt32vEWIK2mUBSu8oRnJhvEVg+C7MS9qC781Xi24jVVuR4hg8apT36qZ43CLEGF7zwswqavbg/4xTK5dGV/nM3s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(451199018)(8936002)(15650500001)(5660300002)(66556008)(2906002)(31686004)(41300700001)(4326008)(66476007)(66946007)(558084003)(8676002)(53546011)(54906003)(316002)(6666004)(31696002)(478600001)(6506007)(6486002)(86362001)(36756003)(186003)(26005)(2616005)(6512007)(82960400001)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmF2VEYwWkxkMzNTY20xbmVqZ2RSa3phelIxeXFKV2czS3RybHBqWnFDT3NQ?= =?utf-8?B?Q0JwSzVVM05od1RaZitZaTN6ZEMxUS8yczhGQnFodmFzenNJSjZ5N1lmMHVN?= =?utf-8?B?R1g4TW1ILzY1UHVaQlY4eThsUnhpSVF6cXVLZmM5S3hxdGZIRkFHWFRIZ05G?= =?utf-8?B?ams4WDBKVkxIRHgzRDduSGQ3RS9EcllYV3RnMFdGbTUxb3E1R3BHdmFYaVpD?= =?utf-8?B?bjRsYXJKcnlmNVFLVjRmMGJ0S01jdzRsZFk4aWt4NkF1eG1zN3Nja2tDZEll?= =?utf-8?B?Zk8vaFZMdmVieXdrWmdMYXVCWUdHNXVRVURJbFV4VnUxTDB3VktjNGl5VEJ3?= =?utf-8?B?RjZQMjMyeE5hVzJjd1VzMFpVQ2Fxc0w1MXp1cnNzMlZ6QVhBR0wySVNVUlAx?= =?utf-8?B?ZHNWd3V1VFRINzEyclFVVlBlU1BRUjJwM0NuS2dCREhPYU9yTmM0Y296ZWUv?= =?utf-8?B?czY5UjNpTzFkb1B5b3E2NStkRmlpTWJKNVh1Wkpia001bnhsa0oxZHpTdkFI?= =?utf-8?B?eGJzQm9MZ2lpYTA1ampoY3NJaC9RWEJOWjhZaU9YN1RQeHE1aEx5OXlTdEEx?= =?utf-8?B?WEVqYVpQSHRCV3dqc0lCK3hhb0VrS1JVeXA3WTZmeGRUT2szQ29GU2pjSkV1?= =?utf-8?B?U3MyOFI5MDRFempLcUpiVURRZ3o5TlhnSjg2R1VyUnpTbHR6OWlOeTdOQit4?= =?utf-8?B?NTUvN0krWEpoYkljSWxNT3pEVG92eTRmcGhyamNBYmQ0Y1dzUnQxYWdKMHFN?= =?utf-8?B?YjNLbFNTQ3N5NUJmVnVOdnh3dXlXRm0ramp6UG1Wb2lqRzc1WjZJODdHdlZN?= =?utf-8?B?WTZjL2NmMzlhL2dDNlcvTEdhRkZnZWtSbzJac0tBZ3g0cE5BOTZYQTlkV2dQ?= =?utf-8?B?ejFMTk14MGFoa2lkckNsMkxsYlhLN2E1d0NaUDN1ZjRObkRVMUQybGdNY0Vk?= =?utf-8?B?Q3FkRGxsRzN0QnMxZm1YTjU4Z0J6UFZING5FNlExb3ZjSGVJSlNXYU9zdTlU?= =?utf-8?B?L20rRGw5ZUJlUmQ0TjIzYWVYY2J2QzZEcXl0VXdOakgvdnEyeThIK2Zjemlw?= =?utf-8?B?SllqdkxFZlQ4c1NWVVBkM0Q3cS81SWhhMmFzRXZpZTZCLzhuRkpab2hrWW5n?= =?utf-8?B?SktOM0pVRlNYTzB0K2NYWEZmRnJmamdDTm92UERwbzFJNithSFJaVk9TUDlQ?= =?utf-8?B?SjN4Z0JvRkVYZ21ZdEVEdnRXdzl3T1U3aHh6WGMyNitid0JZVHR0NE1SdnVt?= =?utf-8?B?ZTV3YXdiQlNUdGVpcElhUUJVYU1BN0pVZDlKYWpKd1hsWWtKc1BXakErQllJ?= =?utf-8?B?dUhCeVh6WHYvdm9waUNIdmNYcUcyVDI2MllQNVJyNExYL2xyblBHS2NlNnNM?= =?utf-8?B?NGw2R3NSMFJoLzV1T09pWVFReWExN3ZjMlcyRWY1eTlKNnpJQmFtV1BhazNk?= =?utf-8?B?VUxjODZ2QUlXZDVlZVVGK2NMWTNXQmEwcnVQSkFpRGRXUVZ3SU5SMkxnMURl?= =?utf-8?B?ZWhKTjJCTEwxcXhCRjFsRDZhNUxrOVhwbGxnSUl4T3JEVXNCRVowRFpNV2Na?= =?utf-8?B?R0RENGIzUkl6Z0x0SlFzejgvYi8vclAyTHJwNHdBcE5NU05FZkJINGNOOFRZ?= =?utf-8?B?dTRHYXRDSmdsSmE0THZwZStXcXBnWXdidnVtZCt1Vm0zMjMvaWxRemR4SXMz?= =?utf-8?B?di9JdEsyQ3E4bWdvcDA3OE00M1Nad1p6M3d2RGptZURHVzF5VHFLNVpIeWd3?= =?utf-8?B?RDU0T0VRSkh0ZjV5eU8wR2g4bmdwSzBYcjNleHU3QTN1UjZGeUFYZFhSNFFL?= =?utf-8?B?OWZ0bjAyTDkyUERQMFhtc0pCOEpkWUs3aUg0ZjlPaWo3RytydDVBSHJZWENm?= =?utf-8?B?eThLM1lmZ2E2alI5bkYxV25RZ21JamMvbi9HTzlYSENOeEN4cERYVmZZOTlu?= =?utf-8?B?SEt2aFh2VmFYN3l3TERtbDdvWk1ucmd3RXBuZkFIQ0xsL0dyRFNQL1FBZFhP?= =?utf-8?B?R0VJQ0h2anBoRStmQ1Y3Ri8welRvanF0NUorZCtMcXRjWGVkNDdhUlhDY3ph?= =?utf-8?B?OTNDc25vM0hwNVRCcERmdVRNOUhVRVRsakJsZWFIRWZLRWp4ekI0WnJhc1Zz?= =?utf-8?B?b1FZWVpmL0lHRGFqVXZFSXNSc3RSdzFKQ1hNcGN0K0dFUDFCUXgrR3luSXZO?= =?utf-8?B?OEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XKm8VtzO+5mdzDwy8ZY9+ScfpBKAwzGlRrUrb1OI/1SRYa2knPzJq1D5gPkppEAYkMrZ33cBF2WwsnqYACCwRFtG0x0n6XVC9wCS1+PHa7vXvY3IV3gpKM5PJ1KN2SXrnwIARlX0KFnWS6GhaSCw70P+J348aMLjh+Nl5/wSold74SM1xqsGcgCzi/XdHTCh8sD/Ul7LFAfBRPaJoX0r6Lpi3HcQmAF4i+9EilNKfeMdi5ZmHlQkf3EgWxD5nt/v6/f9NtKltAtrOvVriUAXQHOKYo2RSJU30+zwdobKy3slsOr82GDJbX8nQyGLpx1EwrZ3ZkZvQ1eIsODfA0juoANula3TWjfiWIfIofhbKLc0w0ewmd4BfsRk7UgQ/9tN8xe1A/k66BMjgMHFFBLQRikfMPjaFFRrTexHW0X/fdj5phV1KcMekEurB4TkTmWrB9TuLrx4EpXkG7YexvY3ZdgA6mP/dpu3PW8C7yvoIfdMD9crNnmfClU1YSmYKhE5gfnUwqOBaCiEHnYWfyWPHwy0x1ztbHjfNkf12V71YVuQNnx9MK+YX0+dmaPeV+ub7dxry7tO6AxlEs7exdxNDHibMS8ee5YE221WT/9fOhAV7sljkF5bqInKu0l1GNU0kxDBwalij/76nsMx4AFVc2mp5tRURMQC+yJQtjV1REs6I03viFr/lGuHOtu9uxS0Vtkl0651mGH99KqTTYhcauehsZFRU1hidTYz3ppDgT4g2wzBISxHKLW8Obv8kwELJQdG2HAa7ULuCFmEfm9tf4aXnY22AtUGwzWivv5j31Bx/MRWWdU8BvepAfTZZu7HaZfzze924dIJ3lmuMVOvjbNvFlWzt8tR2/uxpoYlk7A= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 327fdaac-5c5c-45e1-8b46-08db0aa99926 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 14:26:14.0904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jQjq5CI/OZD1li9vHE4rUmiOjxYYQ8Xpgur/riAV5twgdtKlK+awbXbiKbZxZp921nwIJnx7/v+MPTn02azBC9hwYgHMXwdvKmF8YkWeVcE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5293 On 09/02/2023 2:23 pm, Juergen Gross wrote: > The current version is no longer 4.17-rc. Update it to "4.18-unstable". > > Signed-off-by: Juergen Gross Acked-by: Andrew Cooper Shouldn't this be on the release technicians checklist? ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:29:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:29:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492533.762116 (Exim 4.92) (envelope-from ) id 1pQ7vY-00033w-GM; Thu, 09 Feb 2023 14:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492533.762116; Thu, 09 Feb 2023 14:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7vY-00033p-Cy; Thu, 09 Feb 2023 14:29:32 +0000 Received: by outflank-mailman (input) for mailman id 492533; Thu, 09 Feb 2023 14:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7vX-00033h-7b for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:29:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ7vW-0006mt-UF; Thu, 09 Feb 2023 14:29:30 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ7vW-0005PQ-O1; Thu, 09 Feb 2023 14:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=q2RUcxkoa+Cgk7J/9Kck8+Un6PMtoauiMIj3g6RocVI=; b=s1Zo/yoNXn/2WZ7TYZfTem8raZ H8RPDhgD9sAzmJWGx2825GRW7PCpyMB4iUWjGGBsmJfFE9OWedute0UOTZQOqRg06BcOpQFYXELNf jqr9yYExrcAsivJGA7v+xjk8I6KeKFZE2S3orA0wnmcGOhdJvDZzT8JoNNCsCt4gLz+U=; Message-ID: Date: Thu, 9 Feb 2023 14:29:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] SUPPORT.md: update version to 4.18-unstable Content-Language: en-US To: Andrew Cooper , Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230209142357.3270-1-jgross@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, On 09/02/2023 14:26, Andrew Cooper wrote: > On 09/02/2023 2:23 pm, Juergen Gross wrote: >> The current version is no longer 4.17-rc. Update it to "4.18-unstable". >> >> Signed-off-by: Juergen Gross > > Acked-by: Andrew Cooper > > Shouldn't this be on the release technicians checklist? It is. But somehow I missed it. This reminds me that I also need to respin my branch checklist series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:49:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492538.762127 (Exim 4.92) (envelope-from ) id 1pQ8EL-0005qF-6B; Thu, 09 Feb 2023 14:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492538.762127; Thu, 09 Feb 2023 14:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8EL-0005q8-1J; Thu, 09 Feb 2023 14:48:57 +0000 Received: by outflank-mailman (input) for mailman id 492538; Thu, 09 Feb 2023 14:48:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8EJ-0005q0-TN for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:48:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd4ea7e8-a888-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 15:48:50 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B68B833D84; Thu, 9 Feb 2023 14:48:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E0D5138E4; Thu, 9 Feb 2023 14:48:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4WuNHdEH5WOUIQAAMHmgww (envelope-from ); Thu, 09 Feb 2023 14:48:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd4ea7e8-a888-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675954129; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YjnpbWlmXohZDrED88H73FNHl2lxTAanQxhg+wPy9ao=; b=flUWnbOojtD+1k4RLXKRfdwpPfhfAd07cMb9StAj8t6A65Qp3FKQZuzHFll8SUbrN9dfUG 018xslWP5gQXtF0YIggHBlTxBjduw7QARas+dyDpaecl10sIA+ClPh5VOwjdvDnim2sCsz AjeVGtDgPnRtBafjvAKsP4J33XiTmg4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] docs: clarify xenstore permission documentation Date: Thu, 9 Feb 2023 15:41:48 +0100 Message-Id: <20230209144148.4132-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In docs/misc/xenstore.txt the description of the Xenstore node access permissions is missing one important aspect, which can be found only in the code or in the wiki [1]: The first permission entry is defining the owner of the node via the domid, and the access rights for all domains NOT having a dedicated permission entry. Make that aspect clear in the official documentation. [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions Signed-off-by: Juergen Gross --- docs/misc/xenstore.txt | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt index 8887e7df88..d807ef0709 100644 --- a/docs/misc/xenstore.txt +++ b/docs/misc/xenstore.txt @@ -45,13 +45,16 @@ them to within 2048 bytes. (See XENSTORE_*_PATH_MAX in xs_wire.h.) Each node has one or multiple permission entries. Permissions are granted by domain-id, the first permission entry of each node specifies -the owner of the node. Permissions of a node can be changed by the -owner of the node, the owner can only be modified by the control -domain (usually domain id 0). The owner always has the right to read -and write the node, while other permissions can be setup to allow -read and/or write access. When a domain is being removed from Xenstore -nodes owned by that domain will be removed together with all of those -nodes' children. +the owner of the node, who always has full access to the node (read and +write permission). The access rights of the first entry specify the +allowed access for all domains not having a dedicated permission entry +(the default is "n", removing access for all domains not explicitly +added via additional permission entries). Permissions of a node can be +changed by the owner of the node, the owner can only be modified by the +control domain (usually domain id 0). Other permissions can be setup to +allow read and/or write access for other domains. When a domain is +being removed from Xenstore nodes owned by that domain will be removed +together with all of those nodes' children. Communication with xenstore is via either sockets, or event channel -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:51:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:51:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492544.762138 (Exim 4.92) (envelope-from ) id 1pQ8GD-0007Fw-MQ; Thu, 09 Feb 2023 14:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492544.762138; Thu, 09 Feb 2023 14:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8GD-0007Fp-Jf; Thu, 09 Feb 2023 14:50:53 +0000 Received: by outflank-mailman (input) for mailman id 492544; Thu, 09 Feb 2023 14:50:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8GC-0007Fg-Vr for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:50:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8GC-0007LC-Km; Thu, 09 Feb 2023 14:50:52 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ8GC-0006Ly-Dk; Thu, 09 Feb 2023 14:50:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tSfnllD+Zrre9jYvjDVVI4NYSAgVHLcBv4njeELtNfo=; b=HYpbofla7BQWPCmYytcz8DO+xE qiq9rnVtGUdEHg5e/W+YSmGjm93Lnpe3YqXl6qGcKW71IayfrVkkEgdoprikx1LfFBFjkFnl8q6kr Py2xSIMlv6aOtM+2c46Bm69ot0UYai6MROcowL0OrRGF5hbA+/T0wwq/EkgJvg4IO8QY=; Message-ID: <9dbd5118-7cb1-37f0-6e50-e861b225d7ef@xen.org> Date: Thu, 9 Feb 2023 14:50:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] docs: clarify xenstore permission documentation Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230209144148.4132-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20230209144148.4132-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 09/02/2023 14:41, Juergen Gross wrote: > In docs/misc/xenstore.txt the description of the Xenstore node access > permissions is missing one important aspect, which can be found only > in the code or in the wiki [1]: > > The first permission entry is defining the owner of the node via the > domid, and the access rights for all domains NOT having a dedicated > permission entry. > > Make that aspect clear in the official documentation. Thanks for the commit. I am not very thrilled with the current behavior but at least it is now clearly documented in xenstore.txt. So: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:55:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:55:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492549.762148 (Exim 4.92) (envelope-from ) id 1pQ8Kp-00084d-8C; Thu, 09 Feb 2023 14:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492549.762148; Thu, 09 Feb 2023 14:55:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8Kp-00084W-5R; Thu, 09 Feb 2023 14:55:39 +0000 Received: by outflank-mailman (input) for mailman id 492549; Thu, 09 Feb 2023 14:55:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8Ko-00084Q-8B for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:55:38 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce6cb417-a889-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 15:55:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce6cb417-a889-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675954536; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=A6hlMDSnlzJyxRxqV+a44ni/qT+xG0p++0x6TFrshFA=; b=OFL8zCQJ+r7YUaZMr6dqesVVoroCzHJqvdTyK5KBikaZIQcuK/qc6kuz HtMuNI6gaS2knFV68zCdGF5IqZIAt1/Hgu7C3yjxq5w7xntAe06kyud4T F1fe4u6DoJmXQMwlauF+qPTwUIp8/AOJC75FGNh+pevI3N83zhWjMcI8S 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98795105 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:YkO3p6ni/sFpTKKW1XsGUbXo5gxYIERdPkR7XQ2eYbSJt1+Wr1Gzt xIbWT/VP/qDM2Txc4onad+/ph5Q657SytA3TlQ9rSAwRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5A6GzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cBHCx0qQzeyvPKrh7KxEvhUrcQbDfC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfI+ TObpjykav0cHP665yGV32CQvd3ClBHHf9I2SLnny8c/1TV/wURMUUZLBDNXu8KRhkO7WvpeL VIV4SskqaUu9E2tQcL5Vhf+q3mB1jYGUtpNF6sh6QeCyoLd+QPfDW8BJhZNZtUpu84xQT0Cz UKSkpXiAjkHmLaVU3OG6rCMrT6ofzdTJmsLfywsQg4M4t2lq4Y25jrTT9NLAKOzyNrvFlnY2 yiLtiM3g7wZkOYB1rm38F7KhT6hvN7CSQtdzgzWRWuk6gpRbo+5a4Gm5F7X4OwGJ4GcJnGdt X0NgOCC7+QDC56cmSjLS+IIdJmx7uuBGC3RhxhoBZZJ3zeg5X+lO5xR6TdWJUF1P8JCcjjsC GfRpAUX4pZQNXmraKZfYoStBsBsxq/lffzbUfTTYstLc4JGXgaN9yFzZmadx2no1kMrlMkXM 5qBbdylC3pcDK191Se3XM8Uy7ptzSc7rUvWTIr+xg6q0pKfYmCUUrYPNFaSbuE/47iAqQ+T+ NFaX+OGwgtSePfzaS7W9cgUN19iBXo0H5ftsORMa/WOZAFhHQkJEfjKy6kmfI9jt6tQn+bMu Hq6XydwxV7yg3SBNAuLb2x4Za3mdZFlpHk/MGonOlPA82E+aIDp/LpHX5QydLgjsudkyJZcQ /YJdsqaC9xTWz/H/HIbdpC7o4t8HDywjAeTMi7jfDg+dZd9QxDh99n/Ow/+8y9ICTC43eM8v rmh2wXzUZcFAQN4A67+avii0lewtng1g/9pUg3DJdw7UFro2JhnLWr2lPBfC9EBL1DPyyWX0 y6SAAwEvq/drokt6t7LiKuY6YCzHINWBVFGFmPW6bK3Myjy/We5x4JEFuGSclj1WHvv/aS+Z c1c1/zmLOAch1FOrpZ9FLBwi6k54rPHrqdX1A1+EF3Xbl6gDfVrJXzu4CVUnvQTnPkD41LwA x/RvIAAYt1lJf8JDnYteykIScmk5MoEh37S56wkGG763A5Oqe/vvVppAzGAjylULb1QOYwjw Ps8tMN+1zFTmibGIf7d0HkKqj3kwmgoFvx+68pEWNODZh8DkAkqXHDKNsPhDHhjgf1oO1JiH DKbjbGqa190lhubKCpb+ZQgMINgaXUyVPJilgdqy7ehwICtahoLMPp5r1wKovx9lEkv7g6KE jED27dJDauP5Sx0o8NIQnqhHQpMbDXApBOsmwtQzDOIHhP5PoAoEIHbEb3dlKz+2zsDFgW3A ZnCkDq1OdoUVJ6ZMtQOtb5N9KW4EI0ZGvzqk8G7BcWVd6TWkhK86pJCkVEg8kO9aeto3R2vm AWf1LooAUENHXJK8vJT5kjz/eh4dS1o00QbHK89pv5URjiMENxwsBDXQ32Mlgp2D6Si2SeF5 wZGfKqjizzWOP6ykw0m IronPort-HdrOrdr: A9a23:FN3p0a7BwaKnnOyN8APXwDjXdLJyesId70hD6qkQc3Fom62j5q STdZEgvyMc5wx/ZJhNo7690cq7MBbhHPxOkOos1N6ZNWGLhILPFuBfBOPZqAEIcBeOlNK1u5 0BT0EEMqyWMbB75/yKnDVREbwbsaa6GHbDv5ah859vJzsaGp2J921Ce2Cm+tUdfng9OXI+fq Dsn/Zvln6bVlk8SN+0PXUBV/irnay3qHq3CSR2fyLO8WO1/EiV1II= X-IronPort-AV: E=Sophos;i="5.97,283,1669093200"; d="scan'208";a="98795105" Date: Thu, 9 Feb 2023 14:55:16 +0000 From: Anthony PERARD To: Demi Marie Obenour CC: Stefano Stabellini , , Wei Liu , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , Samuel Thibault , Daniel De Graaf , "Quan Xu" , Elena Ufimtseva , "Roger Pau =?iso-8859-1?Q?Monn=E9?=" , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , "Kevin Tian" , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , "Petre Pircalabu" , Tim Deegan , "Christopher Clark" , Dario Faggioli , Rahul Singh , "Daniel P. Smith" Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Message-ID: References: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Feb 08, 2023 at 06:21:08PM -0500, Demi Marie Obenour wrote: > On Wed, Feb 08, 2023 at 02:58:38PM -0800, Stefano Stabellini wrote: > > On Wed, 8 Feb 2023, Demi Marie Obenour wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > > blatently obvious reasons. Even for non-executable data, insecure > > > transports are considered deprecated. > > > > > > This patch changes GPL boilerplate. > > > > > > Signed-off-by: Demi Marie Obenour > > > > For the licensing boilerplate, I think it would be better to switch to > > SPDX instead. > > > > That said, given that you have already done the work to covert the GPL > > boilerplate everywhere, I think this is OK. But if you have time and > > energy I would love to see a patch switching to SPDX in as many places > > as possible. > > The only part of this patch I actually wrote is the commit message. The > rest was generatedy by: > > git ls-files -z | > xargs -0 -- sed -Ei -- 's@(http)(://www\.gnu\.org)@\1s\2@g' > > followed by the usual git stuff. Do you know of a similar automated > tool for SPDX conversion? I did this with a little script in the past: https://lore.kernel.org/xen-devel/20221103115204.49610-7-anthony.perard@citrix.com/ It could be adapted for the different licenses. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 14:58:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 14:58:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492555.762160 (Exim 4.92) (envelope-from ) id 1pQ8Nq-0000GE-MN; Thu, 09 Feb 2023 14:58:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492555.762160; Thu, 09 Feb 2023 14:58:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8Nq-0000G2-JP; Thu, 09 Feb 2023 14:58:46 +0000 Received: by outflank-mailman (input) for mailman id 492555; Thu, 09 Feb 2023 14:58:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8Np-0000Fq-7M for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 14:58:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8Nj-0007TG-0w; Thu, 09 Feb 2023 14:58:39 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ8Ni-0006uY-Oy; Thu, 09 Feb 2023 14:58:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vuScadvmbFEBVyExlZAHuucRaBoj9Bj2Wq0F+OjL8YE=; b=WVFblwJjia7ZtL622hOa91sPjj eYlsFozRxuLQDEW71JrPwHd7bRn2q34nJ2W9m9zEwgWUJCeAmKBfQg5x7DgunsI8QmiGyQIXOh4zy P4r8TI0iv/OSRNea6boWNHyhpvkdahMHP80szNQyVmszNgFdUYYaDwcPG8HhRuQyZDDE=; Message-ID: <8bf18e22-5ef1-25ff-ff63-b5a390e92bbd@xen.org> Date: Thu, 9 Feb 2023 14:58:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 4/4] GPL License Boilerplate: Switch from HTTP to HTTPS Content-Language: en-US To: Anthony PERARD , Demi Marie Obenour Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Samuel Thibault , Daniel De Graaf , Quan Xu , Elena Ufimtseva , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Bertrand Marquis , Volodymyr Babchuk , Jun Nakajima , Kevin Tian , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , Christopher Clark , Dario Faggioli , Rahul Singh , "Daniel P. Smith" References: <6ff3e64e1dafd869caf23660cafdd46070209e2e.1675889602.git.demi@invisiblethingslab.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Anthony, On 09/02/2023 14:55, Anthony PERARD wrote: > On Wed, Feb 08, 2023 at 06:21:08PM -0500, Demi Marie Obenour wrote: >> On Wed, Feb 08, 2023 at 02:58:38PM -0800, Stefano Stabellini wrote: >>> On Wed, 8 Feb 2023, Demi Marie Obenour wrote: >>>> Obtaining code over an insecure transport is a terrible idea for >>>> blatently obvious reasons. Even for non-executable data, insecure >>>> transports are considered deprecated. >>>> >>>> This patch changes GPL boilerplate. >>>> >>>> Signed-off-by: Demi Marie Obenour >>> >>> For the licensing boilerplate, I think it would be better to switch to >>> SPDX instead. >>> >>> That said, given that you have already done the work to covert the GPL >>> boilerplate everywhere, I think this is OK. But if you have time and >>> energy I would love to see a patch switching to SPDX in as many places >>> as possible. >> >> The only part of this patch I actually wrote is the commit message. The >> rest was generatedy by: >> >> git ls-files -z | >> xargs -0 -- sed -Ei -- 's@(http)(://www\.gnu\.org)@\1s\2@g' >> >> followed by the usual git stuff. Do you know of a similar automated >> tool for SPDX conversion? > > I did this with a little script in the past: > https://lore.kernel.org/xen-devel/20221103115204.49610-7-anthony.perard@citrix.com/ > > It could be adapted for the different licenses. Thanks! Yesterday evening, I was looking at scancode which is able to detect licenses but I didn't manage to figure out if it was possible to replace license text with SPDX. In v1, IIRC, Demi said she didn't have time to look at it. But I am happy to give a try as it shouldn't be too complicated to replace the majority. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:05:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492566.762171 (Exim 4.92) (envelope-from ) id 1pQ8UU-0001ui-D8; Thu, 09 Feb 2023 15:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492566.762171; Thu, 09 Feb 2023 15:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8UU-0001ub-9o; Thu, 09 Feb 2023 15:05:38 +0000 Received: by outflank-mailman (input) for mailman id 492566; Thu, 09 Feb 2023 15:05:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8UT-0001uV-Q5 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:05:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 336b1d49-a88b-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:05:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 336b1d49-a88b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675955135; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PjNIe2uJUTNVgm09BTrA+sVuQ00HBFz5tLePF6521FQ=; b=ci9PI5C+/YzkkwayWJd38faPLXZuAnP81TLMoytNoUPGA53bEH8MO+Un wtrGYEUZOOkP8h2PcMiDfMEswdItOGvOYFgMnrY1JLx6UlM91F83Q0UOH x8FTN4Cj+pqf34ZQqVBbPjchyS+NtiqX+4sxIFbYAtKmlszB42iruvng8 Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98797387 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:N5/Kl6zDfJEWZWKdCuN6t+e9xirEfRIJ4+MujC+fZmUNrF6WrkUPy mIdWDiHOq3eZDCnc9lxYYiz9RwDvJaAx9FmQQRrpSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPaET5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVwU8 eRFKC0nVzKSiN+rnu/rac1Fov12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQFwRfH/ TKZl4j/KjcabPfYyjTbyS+tjOvjnQGjApk4BLLto5aGh3XMnzdOWXX6T2CTrfS8i2a/XcxeM E0e/icyrak0+1evR9O7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebT4g2 0KNntjpLSdyq7DTQnWYnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2T5lnCnj+o4ITJTwQ8+wHLdm+j9UZ9dYmjIYuy5jDz5O5NNo+DQnGdv XIPnI6V6+VmMH2WvHXTGqNXRujvvqvbdmSG2jaDAqXN6RyQoXq7IIBNyghcNUhUL5hZKRzNS Wvq7FY5CIBoAFOmaqp+YoSUAssszLT9GdmNas04fuaicbAqKlbZoXgGiVq4mjm0zRNyyf1X1 YKzK57EMJoMNUhwINNarc852KRj+C0xzHi7qXvTn0X+iur2iJJ4pN443LqyggIRtvvsTOb9q Yw32y62J/J3DoXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdM4z/QMzrmZr yvsMqO99LYZrSaXQeltQik8AI4DoL4l9S5rVcDSFQnAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ 8TpiO3Zasmjvg/vomxHBbGk9dwKSfherV7WV8ZTSGRlLsEIqs2g0oOMQzYDAwFXU3Tr75Zj+ OTwvu4ZKLJaLzlf4A/tQKrH5zuMUbI1xL8as5fgSjWLRHjRzQ== IronPort-HdrOrdr: A9a23:j59A267GIJjTEHl8uAPXwPnXdLJyesId70hD6qm+c20sTiX4rb HUoB1/73XJYVkqKRUdcLy7Scy9qDbnhP1ICOoqXItKPjOW31dARbsKheCD/9SjIVydygc379 YHT0ERMqyIMbG4t6rHCcuDfurIDOPpzElgv4nj80s= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="98797387" Date: Thu, 9 Feb 2023 15:05:14 +0000 From: Anthony PERARD To: George Dunlap , Demi Marie Obenour CC: , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Samuel Thibault Subject: Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// Message-ID: References: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, Feb 09, 2023 at 02:01:52PM +0000, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour < > demi@invisiblethingslab.com> wrote: > > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > > > > This patch enforces the use of secure transports in the build system. > > > > Signed-off-by: Demi Marie Obenour > > > > Hey Demi, > > Thanks for this series -- we definitely want the build system to use secure > transports when available. Can you confirm that you've tested the "+s" > versions of all the URLs in this patch, and verified that they actually > work? :'( -> https://gitlab.com/xen-project/patchew/xen/-/pipelines/771746628/ Our GitLab tests are very unhappy with the switch to TLS. Too many containers aren't recent enough, and don't have the right certificates (Let's encrypt I guess). I've only looked at two failures: ubuntu-focal-clang: fatal: unable to access 'https://xenbits.xen.org/git-http/qemu-xen.git/': server certificate verification failed. CAfile: none CRLfile: none ubuntu-xenial-gcc: ERROR: cannot verify xenbits.xen.org's certificate, issued by 'CN=R3,O=Let\'s Encrypt,C=US': I'll try to have a look at updating those containers. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:16:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:16:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492576.762182 (Exim 4.92) (envelope-from ) id 1pQ8ek-0003Zz-D4; Thu, 09 Feb 2023 15:16:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492576.762182; Thu, 09 Feb 2023 15:16:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8ek-0003Zr-8v; Thu, 09 Feb 2023 15:16:14 +0000 Received: by outflank-mailman (input) for mailman id 492576; Thu, 09 Feb 2023 15:16:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8ej-0003Zg-Bm for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:16:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9e49341-a88c-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:16:03 +0100 (CET) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 10:15:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5679.namprd03.prod.outlook.com (2603:10b6:a03:2db::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:15:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 15:15:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e49341-a88c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675955763; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=gbt/S871SWKQZNPYbBggF76yvQhiVuOPzHK2tiR0vOE=; b=PzGBBcP1rwUS6QD+OXALlcyEn56kkTHUs/KqHGZBk3aifokPgONS20ac HrzVxpzT9Mce5St470i3/wlrvrfzVyvFLypWf6LHMaQo2cguUu7XtnrR0 noA7Pp0BvgMvj2OLjzqI63KpZ6fQHRauM2Wskugh/jA8cXYH/SQKBKQHr o=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 96377985 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:M8nrm6qGxX4YTpujrtqgBhwOhAheBmL8ZBIvgKrLsJaIsI4StFCzt garIBmGOv/bZjShf9AlbN+//EwOusKGytRrSQY5pC01HnkVopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADwKMhveveaJ+ZKqSuJrj5QtcZLtP7pK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqKU13wzDmwT/DjUrRHqCjfjgjXKEfMkHG V4+93YOq7c9oRnDot7VGkfQTGS/lhwTQd1LCMUh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLopw3jx/JZsZuFuiylNKdMSrr3 zmAoSw6hrMSpc0GzaO2+RbAmT3EjofNZh444EPQRG3N0+9iTIusZojt5V2F6/9Fdd6dVgPY5 CdCnNWC5ucTC53LjDaKXOgGALCu4bCCLSHYhllsWZIm8lxB5kKeQGyZ2xkmTG8BDyrOUWO1C KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:XkVGHKDIhC3WFDjlHel+55DYdb4zR+YMi2TDtnoBMyC9F/byqy nAppomPHPP5Qr5G0tBpTn4AtjnfZqEz+8N3WBzB9aftWvdyRCVxehZhOOJ/9SKIULDH4BmuZ uIPJIOa+HYPBxWgcP7/wWiA78bsby6GMfBv5an857Bd3APV0gl1XYfNi+LVkl7XhNPC5YaGI r03Lskmwad X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96377985" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W2EotzuG5oPOfW7TwThUSh5rn+6y45bw1WVxrUoERe7/bHcZVmo+RNKm6dvKVlEm5cp3Mt7AB97zAiECr4cQLUqOilAax9OwzYfjwU9QbKRUJctHQvTU8lJEGJ/qmi5UsVAeCFBtNCyCpsYYYpbWEU0ijYD7IOVTJ6q6XvKbzydFQnyZ7mgpKVlSidwfTjV5J7IcqpL1SaqP420Gx5FEgy9eiI0iD1zsa7VZ7PCbzOkIyj79lwdGdJrGds7bIuAT1qWL8Tsi+ocsXCS7SclHdvR7uAKj3xRnXKSQcvmnQvDac4AlzRjdZ45UgnAZKO3N96HCJhHNAncHyxtqlGQs3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R1dy27LkRf7OQPFi3BOzbyJXyGzwsItRcKR442purcQ=; b=mPwVGXx6QwuRpIZGQUSkBSx8oaPDksXeKcvRqioBQHYi1n1fMTvHuGex5GJvGr6GAtBm4JpTy/6ZMxamWFHEL88S8oKbvaaBxAUhMyMGG00qYyheegAsbhKrXagWaIUGtdLRIRdkC3ZEOdgwknajejXMoaPJBnYwMAm9E9PffOXhRqL3mP5MMsBb60+o69OX2sYQr5VQrm5O9DVku/QmV2/6HT7dHZMX18+HQ9UC6pvZmIblkkAUqWOsNFj1THph+T1HlG3+JYlpYefcbghwYrr0JQBA65jz2/vybEzzhEM6YtC/IwUp9Tj5eQjC8SXBqLPqZQ/fQLc1eFxSBOVQxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R1dy27LkRf7OQPFi3BOzbyJXyGzwsItRcKR442purcQ=; b=b9u33uEcaNXeQxmTua1lGGRcjNJ/ZJo7r2xrclWSuTOzyk47klZTrHyJiVhQFmlWVSONnFvLo+qlMdC8I95LPTiESrbnsZ0ZU3RNX38r7mAWciGJxQkaRMKJGFsASSwRAm75bmlIc/9wFPTo1TfOaZMS2/cIL4/VaBwAdQQUQKc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> Date: Thu, 9 Feb 2023 15:15:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] docs: clarify xenstore permission documentation Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok References: <20230209144148.4132-1-jgross@suse.com> In-Reply-To: <20230209144148.4132-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0490.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5679:EE_ X-MS-Office365-Filtering-Correlation-Id: d1c145a3-e6b9-4a79-1ae8-08db0ab080cb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QCq3yxw15x16EDgEWJgmDM4KFC9IyMjgL2TYTlZ6bviXoXZXUvFN5EBwmsebO5R0ZJK4e66R4O/m73dtKyq3F/C+nDRJ9fMggarMmfEdnipsq82YkZR/hJ2NDxDzhDf6egS5BZhcoayJZyqcesyafYn9wkd0jUTYjYfF8Tp8Z8/A3ofaH6KIvsBXbnYkuOzJlsmy2qMNoBu0jdxX5eP23DMrR3HFCkpYjteLx+hGeFMAvnbSxummTgEIAvfQv0nqaRD1+pwQNqGCONO5/nMGE6YElauX4DYHyYOf18EnElSn8XOx+WmT0FtWHJh0ukzIUT9RFO9uwSXYiksDck1FAkUFR+cgFI4tWGE4dS7qL7/69dnj41WBMfutZ16ntF7qHAfCbOHAh6H9xOxAQBt9bQDW1VSGbSxI1897LbC2mMInI+YXAko7MsUtNbs6RKL/yqTxQGTeG9eQmPngXpkd2qOQpligtxKmIVTRRoq5O7R6CKLKrMtJukreY/GXbBrfW1lk8WKmQOXa0JkIavbC9p3U8/88GU9Tw7sI3mUUJs8cKiGRn5yr6v8cVnbXmMeSZ+hzj06hLqwNckwpAjHBrPTsEKcvEg2Y0Y/r7Qc7Nstr/f2qxl9nk2jsfkfM1JsOJ7Xl9HLWCeBCOI4WS2UUOSsA8ANPixMofwvrFwgtOrm31/wjPoMCUMfhfHE9gylGTJn7kU7GBkYX6ouF8GM3vSucBwRnslUJ3180ncEX8oixvx57tEqd3+CCHsHcF3TwcWmJz6LsvODlAnoXsTbHTg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199018)(2906002)(186003)(31696002)(86362001)(2616005)(8936002)(5660300002)(26005)(36756003)(966005)(6486002)(82960400001)(107886003)(478600001)(6666004)(53546011)(6506007)(31686004)(83380400001)(6512007)(38100700002)(316002)(66946007)(41300700001)(4326008)(8676002)(66476007)(66556008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVBMa2hkTkZCY1gvcS83eFZMdWlZa25CdVZJVEd2K3ROeHBvY051S3NmSHJE?= =?utf-8?B?RFdtVVdha2MveGcrd0FSakllRnhuZUFENjU2a21EYXpTNEVQcEl4K0x1UXdP?= =?utf-8?B?NUd5ZVRNV3BER1hBYzljSm1xNVlNM3h5Z0RBTndZSVV6ZU85MHcxZkVIa2ZR?= =?utf-8?B?a2pyYkNFN3Y0M1kva1VIS2VUZExMWWsraXdCQTROcHJ1bVBGb3R2M3Y0cEho?= =?utf-8?B?U01MbkNhYlFCQXdPM0h0SEtqZ00zV3hkK3d6YkxZMStCbEhnMWZYRmJRcUli?= =?utf-8?B?WG0xV2YyVWF3RGNaeEpCOVBFWXBKdzdhMGJuY0djRThXcWozcFNMVCt5b1R0?= =?utf-8?B?UFliMHhBU01paVptNXlRVFN5aS9YSXUyWUNEMCtjTXFHVU5tRnNFM0N6YkJX?= =?utf-8?B?QkNQWUVHWGV3QkYwVjByaUhzc0luOE9Kd3BuTXRobnZvSWlURjArL2dWNTVM?= =?utf-8?B?cFlsMlNxcUxHQ0R4WHhXVW01S2RCUTJVa2tNeVVScEV5MUFDV0YycmxFQWda?= =?utf-8?B?SDBtTXVCNlladmI1TkxReEpHdm52azZvV3FUWDhObVpEcTY2ZlAxRENUaFp0?= =?utf-8?B?Rm1abHFQSEI3aVlyS0pEOVRWNDVpMm4zTldCdkhYQTNqbnVDR1NmY3prZHlS?= =?utf-8?B?VWVub3lheEg2QkIxZnRpc1hPWEUzd2pxMFpFSVFhRWhFWTdDRmYzV0xFOUZF?= =?utf-8?B?VjRuQitpMGhyOTRwUDFUSjIzN2dOMHFFdXNWVjhtSTdDTU1GTWxhYkNDVU16?= =?utf-8?B?b2FsckUxZnlRRlk2V3FEMEtQelhtcHRJOFYrTlR3Vm90TWd1L3BxVWRscnRi?= =?utf-8?B?YmZ2Z01wY3Y4SUtpc0NQTHpkaFAwNjFMd0cyb3ZwVEE1bUxkRVlTNnNiNURB?= =?utf-8?B?TWd1VVFpRnFPdHdYS2JHUmZhRm9Ec015ZkU3bVA5VFVzRTVPUzVnUVpuUGcw?= =?utf-8?B?ZDg3VTYwcDNxVEtwUlZWMXdsSXhWNnRsYkJRVUV0bWJERmw4QStkcWtlK0Zl?= =?utf-8?B?QmIwdFY1Qmp2eVRYVXgvM3VYaWpHbGc0M1BaamgvT0JNZmVlUkxzM3AwN3VG?= =?utf-8?B?MFJDaWVaOHRobGhEVTRaME9DQTM2UjQ4WGhTbUxIVk90NFE1MVJiZWNiTk1r?= =?utf-8?B?U3hnQ2dqSXBaTnFOTWU4Rmk1WDVyYXE5emx4NHpvMjQycjhXYUMwQXBsT2pl?= =?utf-8?B?cThPREp1NTRFVzU3dTFISHdkWUZHNXlYdlpoMTJvNStEaW1GU1NTemhtNGVl?= =?utf-8?B?OUFNWFNNcE1EV2lsMFNZMkEvaGVHMXNtdU5CeFNncnRUb3lHeHpDNEEwNEhy?= =?utf-8?B?STJneTNvaEoyVnVGeGFIMFdlYW4yUzlDa2oySUFlQ2hmYkFieDlVMGJlOENq?= =?utf-8?B?eUVqNnZTaE5yRVl2YUQ4aU5PNFJBZTl2VjB4MzhIY1p2T1BvSS9tVVk1VVhY?= =?utf-8?B?TXBScXRpZXJUKzMwTFpmRnZmc3ZyMTRxOWhrMnRyY1NhU3U5bGpYd2x5UXNW?= =?utf-8?B?SHppbjRjUFNyUVRESXVQbjFuSEZRRm8ycnRXNUxqZ2NMZVY0eXFFSVlnK1dP?= =?utf-8?B?OUlBbEUvbi8zbjUyb2l5WFlZRWpNQnQ4ZlFOUFFrbDlHbk5DZlFqKytSclZt?= =?utf-8?B?YzdmM2Mzbkg4K0ZxM0drSWduNk9Ec1RUYytTUGRRVzVRYjVqajIzSzRtcjBy?= =?utf-8?B?RFN2a0pCN3pBOTFBRW9aSEwzaHBEaEFqaUlPeDl0UGJJVjEvLzlIanhBbUtX?= =?utf-8?B?bTVaZzJWam0rVjZVTVVQdVdHakNxbzRJR293QXkwVkEyaCtobTdLeGMxZ1Za?= =?utf-8?B?ckZnUmJlYzBEaUw3UFRaWFYyNnNKV1lLUWorS1V5NnRXT1A2U25KeWcvZklN?= =?utf-8?B?a1g3aHBpa1RlL3kwQTdGVmRsTmJHZ2w0Rm43MU5zTzVxSUZiV21mVGdnNlhN?= =?utf-8?B?MWNSZEZPMnVvQndOZXZaUHpRaG9NS0QyMWp5UXAyU0ZIdEhkdDl5L1dWU1Zr?= =?utf-8?B?aUkwR3A3cVR1RUNBRno1ZnRIOVFHRXJWTFhrL2prZW9iU0M3RGUvcHNveWxw?= =?utf-8?B?MmRQckVRUHhQSUFMN0VyaU9ZV0N3NzdSRHJBQ1RYWXZWZ2U1bkt0MW1DdEd1?= =?utf-8?B?ZWFOVjMzUS9HSGxGNmJ1WXNSMFU2SDZJb2hrR3JCcjVyM2E1d1QrbXlPMDR0?= =?utf-8?B?dWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: f2TN3f5ny4YnFxP6QVa+huJRfJ7uGOu8w+JLTX39HmQ7u7IhUaE8V4uODz4PNYj5IbQKqEX5MZfzHZAXjlzSP2KkYkL49SFhCeDColAd2GTHkUmkGlSuiPTHw4cQf4YBq0CUur+aiJIiRp47cjFkSK7E2wBDdGADZLImMOa/i8RhCSftzHgQrHQPxMDgShwVX0vpmwtZmCVViin7TQCRiKFIH5AGaZMVKMCeUq7JTtym1oQ0Dzjyf7r8yhVPDkXTHM6a30a3Q7rtifm1b912Y9yQj3llP6xeYIAPrH6yK8zBiqA1WBkZ/1JTFaSGoht/8LVsfhzyqGddXLiWcNKtwyIU+op/V+cRWrqV1lIS2FszXvcy/eHszVH3T8KmS3JwrobxJObJFZUA1GdUkjFP1DqXNNriZFdoGCJI+n/QciGek+yCIJiqLoGyV0OZK7Y6U/rMUKdxdBLN41vFxyaDAFs0N5NIpSLirBW1faGJQcWzdXPezg6vC3dQmv+5BhX1/P1g6U2ToPssj5FCnyeAq85/54c+7ezj/lssG7AOhr61hM66oh0TBHTygKlDcE6Dr7Kvs1G6d514iWBa1vX14am6cmgpsA+VevAuPG9woixP3/43X4oExQDeb30zA2erd2Q2W9j91NZWIBHdY3RqHD4KkkuGH88kZBlMt0trxwhk5yMHDFt1tOxKrndLxatT9874iXWyU7innSb9zuBTB73qXHGNiTbyL4qyhDdZivrMpuWweOVVfkoJpcXGFQppGCCxpRqt31WW4bHIOKOgLY+YDv9YGoO2RhA5g1xOwnniSif/TzCBNixQ8HBTuGbzOqmqdiTyxO/RgmyQmtEfQEPWe9u3k/++p55lfsz5ffg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1c145a3-e6b9-4a79-1ae8-08db0ab080cb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:15:39.7654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UBdhJnMt7Bfi5eRhRNyMuuTJktS1kUQdjwPPMwoYqo7VHROXHGYI6wYTWUn2z1I3tgvWJJ+YFrbpPnv/jn3IluqIAO07KdPzSfug8phRX00= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5679 On 09/02/2023 2:41 pm, Juergen Gross wrote: > In docs/misc/xenstore.txt the description of the Xenstore node access > permissions is missing one important aspect, which can be found only > in the code or in the wiki [1]: > > The first permission entry is defining the owner of the node via the > domid, and the access rights for all domains NOT having a dedicated > permission entry. > > Make that aspect clear in the official documentation. > > [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions > > Signed-off-by: Juergen Gross I feel as if Edvin deserves some kind of credit here, seeing as it was his observation... Also, CC to double check the wording. ~Andrew > --- > docs/misc/xenstore.txt | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt > index 8887e7df88..d807ef0709 100644 > --- a/docs/misc/xenstore.txt > +++ b/docs/misc/xenstore.txt > @@ -45,13 +45,16 @@ them to within 2048 bytes. (See XENSTORE_*_PATH_MAX in xs_wire.h.) > > Each node has one or multiple permission entries. Permissions are > granted by domain-id, the first permission entry of each node specifies > -the owner of the node. Permissions of a node can be changed by the > -owner of the node, the owner can only be modified by the control > -domain (usually domain id 0). The owner always has the right to read > -and write the node, while other permissions can be setup to allow > -read and/or write access. When a domain is being removed from Xenstore > -nodes owned by that domain will be removed together with all of those > -nodes' children. > +the owner of the node, who always has full access to the node (read and > +write permission). The access rights of the first entry specify the > +allowed access for all domains not having a dedicated permission entry > +(the default is "n", removing access for all domains not explicitly > +added via additional permission entries). Permissions of a node can be > +changed by the owner of the node, the owner can only be modified by the > +control domain (usually domain id 0). Other permissions can be setup to > +allow read and/or write access for other domains. When a domain is > +being removed from Xenstore nodes owned by that domain will be removed > +together with all of those nodes' children. > > > Communication with xenstore is via either sockets, or event channel From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:25:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:25:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492586.762193 (Exim 4.92) (envelope-from ) id 1pQ8nH-00057i-DH; Thu, 09 Feb 2023 15:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492586.762193; Thu, 09 Feb 2023 15:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8nH-00057b-AG; Thu, 09 Feb 2023 15:25:03 +0000 Received: by outflank-mailman (input) for mailman id 492586; Thu, 09 Feb 2023 15:25:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8nF-00057T-Jh for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:25:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea294e7f-a88d-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:24:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B3DDE21CFF; Thu, 9 Feb 2023 15:24:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71F0A1339E; Thu, 9 Feb 2023 15:24:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6rxYGkoQ5WMENgAAMHmgww (envelope-from ); Thu, 09 Feb 2023 15:24:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea294e7f-a88d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675956298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Iy8Eb2M4P0ITdUmne0PgSM5cwbx56kcFx+hQ500uRd8=; b=DmtlvF44HQJpJw6YQo2gpeiiN2vq6E9zpYeSemIEOd5u8ugZ8pWhwjE2SaORZ+0JXDdwP/ jhrrQRp8Vq5WFaMf25ReHjxbC6sBMdd4mNXbkWzp43q0LXnq3VxRWfHVmf//m2uRinxOwa LwTzmFJPvfn6MgJnq6bnBAn5axEXslQ= Message-ID: Date: Thu, 9 Feb 2023 16:24:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] docs: clarify xenstore permission documentation Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> From: Juergen Gross In-Reply-To: <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------uLAgZPQsSRpGIoAqy4tPAeu0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------uLAgZPQsSRpGIoAqy4tPAeu0 Content-Type: multipart/mixed; boundary="------------s3xuugCybWC600gcqKB0C6hJ"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok Message-ID: Subject: Re: [PATCH] docs: clarify xenstore permission documentation References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> In-Reply-To: <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> --------------s3xuugCybWC600gcqKB0C6hJ Content-Type: multipart/mixed; boundary="------------KGSFDY2i2Td44PPazvwKvCZV" --------------KGSFDY2i2Td44PPazvwKvCZV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDIuMjMgMTY6MTUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA5LzAyLzIw MjMgMjo0MSBwbSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IEluIGRvY3MvbWlzYy94ZW5z dG9yZS50eHQgdGhlIGRlc2NyaXB0aW9uIG9mIHRoZSBYZW5zdG9yZSBub2RlIGFjY2Vzcw0K Pj4gcGVybWlzc2lvbnMgaXMgbWlzc2luZyBvbmUgaW1wb3J0YW50IGFzcGVjdCwgd2hpY2gg Y2FuIGJlIGZvdW5kIG9ubHkNCj4+IGluIHRoZSBjb2RlIG9yIGluIHRoZSB3aWtpIFsxXToN Cj4+DQo+PiBUaGUgZmlyc3QgcGVybWlzc2lvbiBlbnRyeSBpcyBkZWZpbmluZyB0aGUgb3du ZXIgb2YgdGhlIG5vZGUgdmlhIHRoZQ0KPj4gZG9taWQsIGFuZCB0aGUgYWNjZXNzIHJpZ2h0 cyBmb3IgYWxsIGRvbWFpbnMgTk9UIGhhdmluZyBhIGRlZGljYXRlZA0KPj4gcGVybWlzc2lv biBlbnRyeS4NCj4+DQo+PiBNYWtlIHRoYXQgYXNwZWN0IGNsZWFyIGluIHRoZSBvZmZpY2lh bCBkb2N1bWVudGF0aW9uLg0KPj4NCj4+IFsxXTogaHR0cHM6Ly93aWtpLnhlbnByb2plY3Qu b3JnL3dpa2kvWGVuQnVzI1Blcm1pc3Npb25zDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gSSBmZWVsIGFzIGlmIEVkdmlu IGRlc2VydmVzIHNvbWUga2luZCBvZiBjcmVkaXQgaGVyZSwgc2VlaW5nIGFzIGl0IHdhcw0K PiBoaXMgb2JzZXJ2YXRpb24uLi4NCg0KSSB3b3VsZG4ndCBtaW5kLiBXaGF0IGtpbmQgb2Yg dGFnIHdvdWxkIGJlIGFwcHJvcHJpYXRlPyAiUmVwb3J0ZWQtYnk6Ij8NCg0KDQpKdWVyZ2Vu DQo= --------------KGSFDY2i2Td44PPazvwKvCZV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------KGSFDY2i2Td44PPazvwKvCZV-- --------------s3xuugCybWC600gcqKB0C6hJ-- --------------uLAgZPQsSRpGIoAqy4tPAeu0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPlEEkFAwAAAAAACgkQsN6d1ii/Ey+G +wf8CyEInSlHh8FcuKh0nEWx7WFQwTxUFMtDaNIrC3ebs3sZFyvyQuqA4UWt7xpXTQWPfbM+oTW3 9smmcUwejqq7n+03pZ2SJnk8BvzOc51UUPd5GVvQ7HHdj0hI/Gwa7tJ6N2gIniLqUrh51Z/Ovpj3 Gps/3Nb21Wk/WYaNRv8WjG/uMEwp5y+7M3GBFb0yXpKqE7D3+62glppNuTMf/VHJuVkpjtoMXwM8 1suVMO2p26aglv5ohqvwDeFsBL9oGEtqB0bMNHxOR6d1CQGixGoPDHr7sLHwcItKbUjtvTEuik7v /JpTa5q+z4OssTT9NCjGwe+jDVq/JhLgE5l23hhNUg== =K9k7 -----END PGP SIGNATURE----- --------------uLAgZPQsSRpGIoAqy4tPAeu0-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:27:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:27:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492592.762204 (Exim 4.92) (envelope-from ) id 1pQ8p4-0005rO-OH; Thu, 09 Feb 2023 15:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492592.762204; Thu, 09 Feb 2023 15:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8p4-0005rE-LE; Thu, 09 Feb 2023 15:26:54 +0000 Received: by outflank-mailman (input) for mailman id 492592; Thu, 09 Feb 2023 15:26:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8p2-0005r8-I5 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:26:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7e1b::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c57745d-a88e-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:26:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7509.eurprd04.prod.outlook.com (2603:10a6:20b:23e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:26:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 15:26:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c57745d-a88e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fhfrt6BTgik3eOsKMdEGv1J9PhYzFlV2TOTbovHqBb++zTkIv0+/sKwXmh8efBjpY7t+esODK/7LP9ecB66Pxg/PnHdYBqAYWXZ1+lHyMD5Cxaf6hiB3Tal2Vo09cn//EBfrszYHpVc2IbQ99LGXkTDwnHL7b3xeVYv9CLYK44xghOoUCU28o1awyuNRG2vxvmXD71RoXe9jkrgx3NEPm8AKSD8UQMD5jpOPcLv0YRQ9PcoTDGZSlXnJmVsZ0QJnJP99AfiXEOC4Df6KR7dfVlcsO+b/qj/xx0GYjOWWYmKEnuWybl58iPtQKWDBOAOT8QSz8fpX92b6Fd0onZNmcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+E8uy3EmUjVT0/Hgl1+aAmLi46INoWFLAroCorsyqrw=; b=aBZ5Rknwghj5IbJe4hwEdpgjqttZJNLuHDFxlzYIkxV/tNhCoX8o853wRSCY8i96tqc0IA8LhStR7KSLVviM6rczx2ixOQrHPdXhBGL3cUv+3+9MxEY08wZOSP9cm878sqHlQbVKh10yZnYC/LVP6Dxq3VIO72yMhhEsVgwbfFp6NWlGuDLACRuf5LsIdttUDGiKsGMdMuNlP4pcmekmGnlJyCYaM/zi86/5Ac/YkFqgy+FLyjqbZIRRQcJZcF6tbWHlAGmq9Lx9talbe7uTKhxlMf0JkZoOouQ3G38nXqbMEvEYH1aUhbfVIO3SATS9FrXnrpMJnNlHgKs4P/NZ4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+E8uy3EmUjVT0/Hgl1+aAmLi46INoWFLAroCorsyqrw=; b=HcpDdjMEry6TVaOPASwuFz9XROFJU4vBBa0vlCs72hBf8yT3kPv3p/Ox2vzmMs2fwgN9C8Pi/y9TlQs/Cj+Igx71uHguswTZip6PfHTX8DqV9Mmnzy4ei+8gKESAErzxRgHM6Izp364kKpUWwIA/9ILu5P6KGUBvko5FhGqw1SuXT7aRpWYHoRDMi46UXoGTLbkFRPYnU6wzYO2JFFxPJjzVTWui0bp4wqKC4KvWAM7j2UdlrI7hrBhamHwn2x7h00DBqJTwj+FKDIxwLPqM8WSdLWr911hk9SgfQh3FfBsRGReigJ5mbeJi5hatNjHL2IxfNPQ6UH94/6iP0QBU5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6eecd308-b871-7826-a99e-57c6d7d52140@suse.com> Date: Thu, 9 Feb 2023 16:26:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] build: move double-$ into as-option-add Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7509:EE_ X-MS-Office365-Filtering-Correlation-Id: 8796582b-3663-4736-5a54-08db0ab20f31 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RIC7RGBFIIW03kn4fEZo1rPnKZPH9WD+9I7ZR3hVfn71Iaw7ISFhxXkzrfSLzVs3yhVo/9ZJIFsqnU4NOxKNMBQqHvn5xu2YrmM33L63M3YLS4fAySQH1AIkZFSFGbD2sLUmXeBGDJbNJquB1TVoibbmNHal8Nld4IYUXO5E5wA5BTZvtv3aXhBoGnZFqs7mYufZtN3Sz4xlorCSTTSLCprhCOFlnMNQoUq+OIBQn4Uo/L56kLOzHTOfPAXtGFYYekWg73FsdxpGsRWHBMvWSn3dkVgrDRzYrsc/lG+Qv9JwTVhxzeQ/q9D7RlqNJA87+oR6xGiWAFQM16EU5s7IMqjmROFwYAxcFxovLw5S+gSK9MmOFbHbMeU/jUjVMYGNyPrMgwan9B68cF6L4nMo0tk9XGGz6wauTil9YSFmjvVdqzr4LiIEntferi1V5unCuPBNvQxd+cR+X2iFVuyOOgOIrLD7XVE7GUaBckWqLEx+gXmF+9DP/6G2kt9fk162jdJFUoiV0XObXKp0dzMnj9n8GrJSvjf7WSu5biu9H8Iw4yteR/0mpbbILQdQoegczWxXr4uj0TLQ1KG5jj0Y39HWFdTZDxeBLync3erdEP2iGl75Qc7cIlq5R31dQmKwi4rM4hwSBSXE5SzM8hSiCBaLKXYo+IdDkTAMegL+tLsWEZAP59K/7jHqqcWN2UeShGjvV6/M63o96ozsHa2qhXgIdjKfoHcp7p1XfEUfCBc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199018)(2906002)(186003)(31696002)(86362001)(2616005)(8936002)(5660300002)(26005)(36756003)(6486002)(478600001)(6666004)(6506007)(31686004)(83380400001)(6512007)(38100700002)(6916009)(316002)(66946007)(41300700001)(4326008)(8676002)(66476007)(66556008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nnk2UURFMUU5UGEvNGZiRU9QbkJBM3NVL1VEbWwyTk9USnZ4Y1NLQXloZWJh?= =?utf-8?B?WWgxK2VLNG5pVjBUbVlxTFB4NmZzWkpkUW1CMll2RVRHU2Q4ZHZpMmR0K0hD?= =?utf-8?B?Sm9USzFXQW5tNFUxV3VVcDJXUWlmR0VLcUlHTExxZFdURnBBOUdaQlNBMm1Z?= =?utf-8?B?dWsxOE1Eak8zcUJyZGxiWUxCU3B5YSs0SzJjYkpYS044UkJWV05ualQyOWly?= =?utf-8?B?VXZwQ0lGbjNLZHpWUEthL3EvOEQwSXVSbnl5WVJyYmF0RFVINWpvMkpQbEdT?= =?utf-8?B?YjR4Ung1S1gxL1d1YXE5THB0UDZvVHFoc0JYNGsveGJBWW5xOTRoU1dQWnJT?= =?utf-8?B?ZkZJZGkwQ0xUQWZ0QURXN3hWSUlOejdXV1NlVWJmOUo5WUoyaXFDTUduank2?= =?utf-8?B?M0R6S3I4Q0pQSDE0YS9KcSt1SVZ3RlNTMitzNEtKbmlienNhcEJsV280RW1U?= =?utf-8?B?OFRrTmZaS2xlYUpVdFl3aDJHdHhqOFNjbFAyUjdzRmVFbm10ekNXWTdGWEJR?= =?utf-8?B?SGRkeWwvdlRGdEJOb2dtWkN3Z1VXTExwZTZPc1RuSGdETGszbm81QkVsOUZ6?= =?utf-8?B?bFV5M1FtT253QnV1dlYwSDdlRGphOXBpYUtBelp0SXJXYWEzbHBhd1dSQTZs?= =?utf-8?B?U21GU1krbWE4SmpMeDZ5OXdEby80MGdBcWhJL1Jlb2FaQmt2WkduUlpZeDMw?= =?utf-8?B?YWVnT1hOYWVwdzRJZWxpRTVOazQ5TURLaCt5K1hOKyt3SHR3OFoxMHc3MFRT?= =?utf-8?B?QlltSUZHQnNsRXpTSklGMkdHdFpYZWpuRE1YbXU1OVNvdUs1TWJaS1pjYzhQ?= =?utf-8?B?Y0UwMS9oMmZPK2RwUXJraWlqdC82QUx4REY3UWVvYmloK1MrcWcrTHlyOWp4?= =?utf-8?B?aGhDVjhCQ3Z2TWtYMUFlVE5KcXhFMG9HSTZzMkZGN0d2T0xsckdNMzdnMXlk?= =?utf-8?B?aHhHQmdaSE1rQWUyTEtlVm0wUE1lbjFBVHhONFI2c0dYdmExdk5xMHhhTGln?= =?utf-8?B?NmdJUFZmYXJRdTREbDVoRW5WNEhFajA3V3V0dmttaU9rNkV4azdhVExtV2NV?= =?utf-8?B?YkU4RzY3engzUXNhUVhDdFZQSWVPMm9vMzVXUGFEQ0lHSUU2RmN1blY0YmJm?= =?utf-8?B?MVVjQlVxbUR6WlpFSjlSeFZVSEc2SkU5eWxNYjRhcURwaEZCcUp3T0ZPNkZV?= =?utf-8?B?aTdsc09nRE9VZmNQQlFSbzhUcHJEZ0djYlgrZWg3U1MwU1crazJ5TFkxZUl6?= =?utf-8?B?bUZJVi93UE0yL2FrMzBCSkZFaDlPRXk3MGpwTU5jYnJRS3V6UXNMZzZvYnRP?= =?utf-8?B?anZOVUhuaXhBa1JsKzh2U0F6RE5hYjBXTlJzWSs0aHdzVWJ6VE41S0JuYkFq?= =?utf-8?B?WjE1Y05WMU5TZVlzZWZucG5JRG9FbVd5cXQ3MUlUcDdxRFZ6SDRhcHRxWDFW?= =?utf-8?B?aTY0N1RKZmxJRzlsYzRxbTg0VERHaVlMcEhra0wxVUp6dk94YkJPTUlmMWRr?= =?utf-8?B?aFNiVE9pTk9UVy84K2tGdXJOQktlazIzQ2lrN2Y3VHJiNjFHRWx2dnVVaWZX?= =?utf-8?B?ZTJCaW1oMGxHKy9yZVBmdVl1SWJreFMrM2o0TVhIdzh0L010T1dtZ0xldG9v?= =?utf-8?B?UStCanFFMmJrOGVyWDB6MjhYd296TVpXd3VkY0w4VkF4QmVMQ0lVVDlpWlZK?= =?utf-8?B?VHQ2MncyYjVOd085bTRrandWb0RyNVA3YWEvRElVcG1tdWN5RDB5eDZ6Sk52?= =?utf-8?B?MnEvbXc3d3ROZFE3YkRGQlhmckNWL1ZiS3Awb1lxd25DN01OMkF6QkFMVUEy?= =?utf-8?B?MVRQaUdxN3ZWNVhKNUNyVjdPZzBpK2JSYytuNVFVYlhVZ3BXODZHejE1K1dm?= =?utf-8?B?R1FzM2lTR3BJaDhzYnkrbEV6NjlEc3lqU0xvVzM5VWZVVGZkMUlueHVBUXZJ?= =?utf-8?B?TVQwY2pUWHVCdk1uTDhtM3dndDVvUUdPRTBhNjRSbUovOHF0T0QydjVJN0lt?= =?utf-8?B?VVZQMGZmd0NSQmRYNXB2S2J2RWI4c2J3cFd6TTkxU2pHeFB4S3hqM0NpbDlF?= =?utf-8?B?K2xDSm1WczFWVUJBaGFNbEdnMVhxcWFBZTRZZVpXRXBSemE3dVR4emNMTnI1?= =?utf-8?Q?uUQN1l/+/Y7aX/oqW5QNE4eKG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8796582b-3663-4736-5a54-08db0ab20f31 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:26:48.0281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LRAhRC0XqAtoYsAvoQ3QtWUJbIMVgUFNAXIqsAVP0Apb0DxcHCfb4mSN6kme5gwTUEQExspLEZJCGRz1F3oi+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7509 It's imo helping readability as well as uses a little if properly arranging for sufficiently late macro expansion is part of the macro itself, rather than all (applicable) instances of its users. No functional change intended. Signed-off-by: Jan Beulich --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -13,8 +13,8 @@ CFLAGS += -msoft-float $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) $(call cc-option-add,CFLAGS,CC,-Wnested-externs) $(call as-option-add,CFLAGS,CC,"vmcall",-DHAVE_AS_VMX) -$(call as-option-add,CFLAGS,CC,"crc32 %eax$$(comma)%eax",-DHAVE_AS_SSE4_2) -$(call as-option-add,CFLAGS,CC,"invept (%rax)$$(comma)%rax",-DHAVE_AS_EPT) +$(call as-option-add,CFLAGS,CC,"crc32 %eax$(comma)%eax",-DHAVE_AS_SSE4_2) +$(call as-option-add,CFLAGS,CC,"invept (%rax)$(comma)%rax",-DHAVE_AS_EPT) $(call as-option-add,CFLAGS,CC,"rdrand %eax",-DHAVE_AS_RDRAND) $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) $(call as-option-add,CFLAGS,CC,"xsaveopt (%rax)",-DHAVE_AS_XSAVEOPT) @@ -21,10 +21,10 @@ $(call as-option-add,CFLAGS,CC,"rdseed % $(call as-option-add,CFLAGS,CC,"rdseed %eax",-DHAVE_AS_RDSEED) $(call as-option-add,CFLAGS,CC,"clac",-DHAVE_AS_CLAC_STAC) $(call as-option-add,CFLAGS,CC,"clwb (%rax)",-DHAVE_AS_CLWB) -$(call as-option-add,CFLAGS,CC,".equ \"x\"$$(comma)1",-DHAVE_AS_QUOTED_SYM) -$(call as-option-add,CFLAGS,CC,"invpcid (%rax)$$(comma)%rax",-DHAVE_AS_INVPCID) -$(call as-option-add,CFLAGS,CC,"movdiri %rax$$(comma)(%rax)",-DHAVE_AS_MOVDIR) -$(call as-option-add,CFLAGS,CC,"enqcmd (%rax)$$(comma)%rax",-DHAVE_AS_ENQCMD) +$(call as-option-add,CFLAGS,CC,".equ \"x\"$(comma)1",-DHAVE_AS_QUOTED_SYM) +$(call as-option-add,CFLAGS,CC,"invpcid (%rax)$(comma)%rax",-DHAVE_AS_INVPCID) +$(call as-option-add,CFLAGS,CC,"movdiri %rax$(comma)(%rax)",-DHAVE_AS_MOVDIR) +$(call as-option-add,CFLAGS,CC,"enqcmd (%rax)$(comma)%rax",-DHAVE_AS_ENQCMD) # GAS's idea of true is -1. Clang's idea is 1 $(call as-option-add,CFLAGS,CC,\ @@ -32,7 +32,7 @@ $(call as-option-add,CFLAGS,CC,\ # Check to see whether the assmbler supports the .nop directive. $(call as-option-add,CFLAGS,CC,\ - ".L1: .L2: .nops (.L2 - .L1)$$(comma)9",-DHAVE_AS_NOPS_DIRECTIVE) + ".L1: .L2: .nops (.L2 - .L1)$(comma)9",-DHAVE_AS_NOPS_DIRECTIVE) CFLAGS += -mno-red-zone -fpic --- a/xen/scripts/Kbuild.include +++ b/xen/scripts/Kbuild.include @@ -66,7 +66,7 @@ as-insn = $(if $(shell echo 'void _(void # Usage: $(call as-option-add,CFLAGS,CC,"insn",option-yes,option-no) as-option-add = $(eval $(call as-option-add-closure,$(1),$(2),$(3),$(4),$(5))) define as-option-add-closure - ifeq ($$(call as-insn,$$($(2)) $$($(1)),$(3),y,n),y) + ifeq ($$(call as-insn,$$($(2)) $$($(1)),$$(3),y,n),y) $(1) += $(4) else $(1) += $(5) From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:27:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:27:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492597.762214 (Exim 4.92) (envelope-from ) id 1pQ8pu-0006Ns-2d; Thu, 09 Feb 2023 15:27:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492597.762214; Thu, 09 Feb 2023 15:27:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8pt-0006Nl-WD; Thu, 09 Feb 2023 15:27:46 +0000 Received: by outflank-mailman (input) for mailman id 492597; Thu, 09 Feb 2023 15:27:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8ps-0006Ho-Ni for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:27:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ac0e3e1-a88e-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:27:43 +0100 (CET) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 10:27:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB4950.namprd03.prod.outlook.com (2603:10b6:a03:1e1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:27:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 15:27:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac0e3e1-a88e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675956463; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=gwL1S2wToJj4TH07ojDEZCKN8n8oHN+LSMCKlg5Dj50=; b=e0XGoklz39wiGt1kzDS3XziZHvXt66wknXHZcux0cwzgXGfcS2p+Ark3 fI8NqiFvf9wRM9p9w6YWiOPjBS3RYNhfDhBfoHcsNMzHoNw9ZYaOtkSXX 6lnrp8TFVe66JdLs1aMnzGJQcan2tfHwGMx7sAxLMARKHsuiYe8gNgagz I=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 96380039 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:OfX2EaDnnaL3SxVW/8ziw5YqxClBgxIJ4kV8jS/XYbTApDwhhDQOm GYeXG6DbqnfYmqjKNtxbIu1p0wHucPQzNVnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlA7wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/8BrLUtA/ NgkFg8uKS+DgvC7wbKnY7w57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+Oxuuzm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6RxnOjANlDfFG+3sxMn1DM+TMLND0Hd2n4k6iUtm6XXfsKf iT4/QJr98De7neDTNbnWAajiGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLT5lvaCRSHmd3qyJtj70Mi8QRUcAeCsFQA0t89Tl5oYpgXrnVc1/GaS4itn0HzDYw D2QqiU6wbIJgqYjyKGT7V3BxTW2qfD0ohUd4wzWWieg8Vl/bYv8P4iwswGDvLBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4ulmS+G8B3h44RALU IronPort-HdrOrdr: A9a23:H6YS66//d0dOWkDhrBduk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96380039" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CfsOrpXJM3NK2XlFhy4x+mfDptjtzBy5niC5P1plvVao2T3wfvy02LJkfy9MyucH8Z7qS3XbI4LwWGKU+XBbBDYUc76eRyAq+bj67TiJpP9A65JQzZZvDglZEwadnLk0i71FjZm4xMM/ULyOhWhYWWmbEAEzfOGW/5ZMcE88LIgF2T9cOCByne6TxHAqoh6uxuDhEzCx0k2lroAyVjB1/koDYB+UhKl5rPcESzVbz7LMQTOOH9whEOgXFBSTSUpyCXwEjVfYUu1Pm5ZB8sdBt76C/v1njyya3nvjd0I1YG433j3zCjd0aYqW1sg+/7FrI1kb6aFbO9Qz7l+2D9C/Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gwL1S2wToJj4TH07ojDEZCKN8n8oHN+LSMCKlg5Dj50=; b=I8bbPfqebaMqiH+OoghLEUyVVXms6QGyJwwOMfKJnDWIs1azQBcS3YeQuflMf9Xhaz26iOhx8KwWBIyoOIENsipEk8vlNvy3RgBPh7IhuyV8uNYbFIvzfUpqWL14c47MBlBD/FRXvtBQxli6QkM/v6ATxlscpUkLYLpCn7bWKUwNYO1q42nN/+7B53cpA8iFSGMl7yVOpRLDYFkRS2yJuAUqJyYsUTiKcHkdVVteEcu8TkBP/g64RWK22/+VX7nDpmt9kXw7AWBwNo+O7hpNZl9i5+LIZxSbrpJvdCFnZMVGpOpuuudKdx8TRJuKemyEgBu/drrPY4aYzJdeC4ILiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gwL1S2wToJj4TH07ojDEZCKN8n8oHN+LSMCKlg5Dj50=; b=WgMJhw+AESG/+K3jhJpdO5Rcz/fKwL7v7/MN+xCvwx2EZxw10d5fnnsTfph85IVMQ4icnCSsn2J4kjggBenEQIPxllJasMKjD+1Ri4qGqIcTb5fCfY2ecr+RekAresvY4Y35aUGBp1oZpQirRGBNPPlh17Ld9B9bfI4Bc1KmBKs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <748b07d4-a114-1d5e-70ad-611f66780119@citrix.com> Date: Thu, 9 Feb 2023 15:27:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] docs: clarify xenstore permission documentation Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB4950:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c50f7ac-ed5b-43f8-d96c-08db0ab22d32 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqCrILnAJeiieUYPRuaKE/cQG3GQUxzZCR16dMGjYXrw903euL5+LKg27dTJBWXIU39Y1FSpkPyFD9cT3y4dUfiNVrt8BtYpCdCIWthLY2ydYrxHgrwZ5EFFLOSUj1VS7imG7yYsCvknyASpnekzxVvUgpLY1uEkm1PBm8Idt8hz0Qgjxg0nUjCLd+xDf++jxFwC1hc6rxuWgvedQL24Gdt0K53QevOGw0Z58eXeoLpw7BxbUvBPU07qDcJotPsJ4FfQi/AxGIvMwqHS5BwC9OIQc+OsopEzqZDzrblMw/DUxAqD8cXF3TGmqmPIgS+ghc3PSJZC7idlgSTc454YtHRcXdCbrYWq85jgQc1HTpHjyTHn00jW7uQ3DhRr62+lXgc1IBanXUvqu4xqA/4soRF99zU6592zKvkftGrnE1jLF9fPPx7fgOP/KQ9Oxx667vXXblfqVOz1IZa6Pj7mK5tZIW3WI8Nmpra7YIsA3RVrS48MwDtDyjcrYt9hUY9sEIwizHyCCELGoPcHOhW+54wJtfVpnpwNZrpzBuGbeNO217qHxW6gm0eVy5PR2r1pjTiJ8biNe6taLm9DzA+GzA7IY7Xrhtz4IbylhzxbdLecCmAAiSCvokhSABCHuXldCcedOCxsvw9S6IxEm039YX0NnIUMoJ7nGEx7ND+iyNVL47s+Kr5ghv33XYc51VfH/uCyQ52sJIvgQF0wT3e6LL2lWip5bn1sTm8sPETWREsCIa0tT26Qtkwm6156E2yT6HTxLj/fBwiuB/UJJ4SI0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(451199018)(31686004)(36756003)(82960400001)(38100700002)(31696002)(86362001)(66476007)(66556008)(66946007)(2616005)(83380400001)(6486002)(6506007)(53546011)(478600001)(186003)(966005)(26005)(6512007)(54906003)(107886003)(5660300002)(4326008)(8676002)(316002)(6666004)(2906002)(4744005)(8936002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXVEMWJPYkxGelVVMlRZRTNibzRTOERKNWRKVHRYZ2FUV3k3QkE4eW9xbFEw?= =?utf-8?B?dWd5SlJ3RUFZZm94aWhOWTNSNHNCRldKZUhxOG5FTlZyWHVaQUpOTFRqaEtx?= =?utf-8?B?ZVBseDgwVDJvVG5MU2pNcm5OSmlPSFNhWGJsTElyUTE2NGQ0TS8zREIrRzlj?= =?utf-8?B?dnFSZHIvME5EQ3BEbUFVZmhtdmY4R2tPTUgwNk5LUjhxZk9rbjRuYm5zNWJr?= =?utf-8?B?REVvQkI5RHgrSUlDUzJzNGR1WVNLUVBVSkFzNnJ5aDBZaWIxbW1kVVRWT2FV?= =?utf-8?B?Zkg2VFhRK1UvTERiRm9ITzJnYVV0cWQrY2x0T1k2VWoxM2V6RVpLdm1IeFRt?= =?utf-8?B?N25UTHhIMFlxUUdlVWZveVlwRTRWSTIwdXRZb1YxbEJ5aWtOZUM1c2o4OW5h?= =?utf-8?B?anNSSFRWN085Y0FMQndCNVArUFFVblVaNnVDR3JNK1dRWHZPdlord1FsTUx3?= =?utf-8?B?T2ZqSnNYR1hBanJGOVB3UTcwSlJFR0VZcmYxYnlHRkVNaWwwdmZkd3pCbHgw?= =?utf-8?B?TFZRcEtnZm5zWFpUOC91OTBXaWVGaFNGUjAxeXFJUXdIWlBjbTNBNU5hcDVI?= =?utf-8?B?eUc2L0ZXMXFkQjBnODF6WE9hbS9tTUtwdU5EckZIUGgwTEJQV3dwRVFtaE9H?= =?utf-8?B?bTMxVG9pR1RXRWRPSk0vYW9JQW5GT1pldGNDelk5bTdaY0tnb1NyU1MwdUJS?= =?utf-8?B?c2FxR09OQVY3S0Z4UWpxYTFxVUEvbndUc2RNZ1pualhsMzRyeGlKdWl1ZkVP?= =?utf-8?B?SHV1cjlZTnlaemIvWFZkUjE0cjVva0pIT2xwNFBmRUU3NkRxMVZ4aytkYmkz?= =?utf-8?B?bjdqR0lVaURnL08zMlB2NWlkRW1pR3dBKzBvclBzUGt1T2k3cXRYTUN4ZUVi?= =?utf-8?B?MjJlU1lXOEp2YTUyazZ3QUcwWUtVL29NWEowZXQ3b3BaekJJdFFQM0JGRVVN?= =?utf-8?B?ZG9HaUV6OHRHOUxMQlMrQXR3NXUyZUNoQjZmS0tGNng2S0FCdnVMWXViRElq?= =?utf-8?B?TXFBczllbzJaaHBBdTVlbjU0dHBXaXJmY0NvVW5QOEpncUcrRGJCYU9XU2hm?= =?utf-8?B?SG5YNkJkMmFYUm8rS3pRT3BWMWxjeHd6VUVtRUNKTlNuZTl6Tm9ZMDJ6NHdU?= =?utf-8?B?YkszaUd0eFFrUUF6bVZ4UXU3MUQ5UHlBQnlub013bDN0WDVvb0NCZks4dGpm?= =?utf-8?B?QVRSSUhESlFxaHZ0WHZ5cUh3Qk4wSXBhYUhUck5pc05FY2xGd3pjR1JlVUpw?= =?utf-8?B?anVOOTdXRFpJVTVxYlZuTTRleXlNb2tIMDIvSGdZMFpSOVpBcUgrZUs4aE4r?= =?utf-8?B?bVlqK1JiYmhZbWQ3cWRWV2tYUWRBLzhIY0xGNjN0dnk3dGZ1MStaRVc4eTJi?= =?utf-8?B?L0Qwa1JyNm5hSTRSUVdWNHE5U1F5WGhVVmlFRGdtZk41QnZzODIvc0ZYMWF1?= =?utf-8?B?eStRZ28rMlkyR0dlcjNpMmtucWJkZW90SnVkSmRPa29NMkF6cEo4OVdsc0pG?= =?utf-8?B?Y2J3cTNYU0dCdmRzUWUvNzN3Q2tVNzViQW9xYm9UMERYYzhkNnd5QUN6MlVj?= =?utf-8?B?bTREaHJ0dFByQ3hQQnNWa0k1MzJzaVNMQ0t2RG9sZ01pWEhmSUpJdGJCTGNr?= =?utf-8?B?ZDBkamIvZGhSTEVGVzN4YytTeUdQVTVWSkJJSjlHSE9LUS81Snd0ZWJHOTho?= =?utf-8?B?ZGFTY2EyVTdMdGFlU3QrUFIrM3Exc29ld01aOHRPczJ0RVd4bzc5VjJpcitP?= =?utf-8?B?M3B4NW91dDFRQ3poL1NZc1dNVjF0c2lLWWRiMTdKUFJ3VTVyU2ZhK0JRQnZ6?= =?utf-8?B?dlF5cGd6K1JZTlMyL3hEcWp6bGY4Um12dDFQQjA0QXRYVDIrRFlIM0tsZFYy?= =?utf-8?B?WC9lWlJVYythb3NOdWlJbkhkZWdCcHVRbDZuMXJkNFVNbFlyY0dYRnQxZ2xs?= =?utf-8?B?ZUJORTdNdVFvUTBDbmlhWlJreWNHdWNRUExMZSs3NnRVTmtWMmFzVlorS1k2?= =?utf-8?B?Q0JLbEZyNlVzYmtFL1grUnZSU0ZkNXdLSHB0QjRia0hEZXZEU2hiWnFjdUlu?= =?utf-8?B?QnBiZnRkKzVHcjZRTitteStjUm1PQ3h1LzJ1d3hFZmxUVzk1R214WGR4N1BK?= =?utf-8?B?dlRQWjAvUTVxQktTclA0TDRvM3V1bUNUaHNSNGQ4R0lrTlJ0SFR6Vy9iOVRY?= =?utf-8?B?ZXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qHIfKvdFR2++dZ8y1lC3UJpiDKxQ/W+qYnlGnlNV6q3B3D7YybS/TvelyEfPY3OGN1xBJJ/zHFDDPGAPLMZ/t3wbhkr/2xGkfRVADNcKRYArjAsWxPD2umnMXaNj7sYAUtApQgC9vrh2pqUOUluMgFxsab135IDFTag4suMe1Pwx10k2eJhsADSu/Kg0IOk8//3RepoUVruuKQ6eskVHhe4NYOfEriBO1kNH/1dmhV7JfFA3870DZMMrksbIK0qGCldaDdkOQjf5Gcv53CBMoM5UkvtFab5QuMSt3gjwfHKw7IQa8xWt+qtuGbqpx3C2/Hx0yTMBiBNU9qyGTlgWHFCDvLhQI4RT2/SoSzdufekvf2EpVjGqZdzdGcQOG1umW84970gPMouuX5PodR611QVYU+yMPetSdxLsYH7MLoT92L8zxDifkHW7Zle42QxkMeZHnRu606cZTGTuduEu1IYxRIWI7mPWb4HtdvBmK4Ycc6nHIyNeq4edgmHCzk9TtSCNt/+NIkOIop1vHlT7tPSej4ZCbgK0Oii5F6nUFbaH0W7sZ9Ab5k7G53XM+otcYKipu7fKtQGI44lTAWzDRW+u45Ur6zQvAylVH1/KT/yiBi4SrgOmIFvIk61u2ux1LRCpehnQllmAwnsP+hFweWo3KVQlkIe3YOfP9p9fS4rF9GtvUC1OrqYxdUjZ9SOpcB7OnhdL6Fy2+XqASd2kUHRel5/FwjyVqt3JyUIIcwpnbB+r8bLfJdFeczk8l7K2+wEn1zTV50xPJRpIE6wnJmSGYgd/O7hM1bNLvEthrgEeLMLpvO7gsd91Cf7Vxx4b3zhNTUNyq5L13JCXy6Q4AuOXnyNoyRlMu40hLg7sev0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c50f7ac-ed5b-43f8-d96c-08db0ab22d32 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:27:38.4164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1gDVXqAevX4h9DTMLsp7y70JBzYRLYuHu/qvMx7xuSeavRKJGwhJxgDZx2GSJld4AgXrry0NL+Re2nePgB0H1tZzLMU85uSA3AbKWX5LwRk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4950 On 09/02/2023 3:24 pm, Juergen Gross wrote: > On 09.02.23 16:15, Andrew Cooper wrote: >> On 09/02/2023 2:41 pm, Juergen Gross wrote: >>> In docs/misc/xenstore.txt the description of the Xenstore node access >>> permissions is missing one important aspect, which can be found only >>> in the code or in the wiki [1]: >>> >>> The first permission entry is defining the owner of the node via the >>> domid, and the access rights for all domains NOT having a dedicated >>> permission entry. >>> >>> Make that aspect clear in the official documentation. >>> >>> [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions >>> >>> Signed-off-by: Juergen Gross >> >> I feel as if Edvin deserves some kind of credit here, seeing as it was >> his observation... > > I wouldn't mind. What kind of tag would be appropriate? "Reported-by:"? Probably.  I can't think of anything better. (and as usual, can be fixed on commit if that's the only issue) ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:30:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:30:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492606.762226 (Exim 4.92) (envelope-from ) id 1pQ8s0-000741-Jg; Thu, 09 Feb 2023 15:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492606.762226; Thu, 09 Feb 2023 15:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8s0-00073u-GT; Thu, 09 Feb 2023 15:29:56 +0000 Received: by outflank-mailman (input) for mailman id 492606; Thu, 09 Feb 2023 15:29:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8rz-00073k-Eb for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:29:55 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 994df588-a88e-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:29:53 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so4154367wma.1 for ; Thu, 09 Feb 2023 07:29:53 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id s12-20020a05600c45cc00b003dfe5190376sm2365624wmo.35.2023.02.09.07.29.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2023 07:29:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 994df588-a88e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WVDe833MzmSGDZZpxWGzdw93FcDtlMCnEHb70rs7kjo=; b=TLpvSbGsAB8/hXRb6Px4uVKWwY1DnBIq/+mhdOJSoamwGznLgLruASrNR42OQ5bYDp s0c+BoHt9j24lPaMdu2T3SxvDFFI2XdydK8+71XDv2fliugM4gfQ0MPA+hIQMvAzHRSo v1IYG/e3WsXDT7QLrrILv4osam5FkTe5Bc4DY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVDe833MzmSGDZZpxWGzdw93FcDtlMCnEHb70rs7kjo=; b=BD0gC0igu2BUBMHYScEeG3Hx4z3eDqWT5LZxDXn8AHlMRT4gp5JHvM4HE3HyRVp4eK zmnQExEIVuWP1Fj4g74avy6bCYU8X8QzBVNLx1X12gNZVj1WJsMDSO6ztHP/WH46EhYj pYLna6xVo9doU4WbgwR3myPhxtPp5LWDIHnl90yHYrCokb2CRQHH3eviNqQ5JUvzs4HH eM2iIkVcinyyq08DGBXHSiWSidI3L569mt/luGqOBncYuWnIQn6J9HtSn/hk3W1jFDvG PO5JuXq1G9QR7KtpunpENyus6c0cPUxKnCnf3k3KUI/RXyAA+XrK6Z6ghAUHhOg5Fx6K k1AQ== X-Gm-Message-State: AO0yUKVdgvG/DwNhPCGWyrrYbk+LnD/LcoH4ax1dUPhpXQ78ura5oeZb A3nRTjb0wjEHLO4ifY4C+Zairg== X-Google-Smtp-Source: AK7set+cOS2bND4YP5mM4tsTtnNDbzKmGb9eXE0GXc1R+lrPjk/22flEz9qvLy+NkOYA7AgzPP0vNQ== X-Received: by 2002:a05:600c:43c4:b0:3dc:5302:ad9 with SMTP id f4-20020a05600c43c400b003dc53020ad9mr13541350wmn.27.1675956592515; Thu, 09 Feb 2023 07:29:52 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH] docs: clarify xenstore permission documentation From: Edwin Torok In-Reply-To: <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> Date: Thu, 9 Feb 2023 15:29:40 +0000 Cc: Juergen Gross , xen-devel@lists.xenproject.org, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3731.300.101.1.3) > On 9 Feb 2023, at 15:15, Andrew Cooper = wrote: >=20 > On 09/02/2023 2:41 pm, Juergen Gross wrote: >> In docs/misc/xenstore.txt the description of the Xenstore node access >> permissions is missing one important aspect, which can be found only >> in the code or in the wiki [1]: >>=20 >> The first permission entry is defining the owner of the node via the >> domid, and the access rights for all domains NOT having a dedicated >> permission entry. >>=20 >> Make that aspect clear in the official documentation. >>=20 >> [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions >>=20 >> Signed-off-by: Juergen Gross >=20 > I feel as if Edvin deserves some kind of credit here, seeing as it was > his observation... >=20 > Also, CC to double check the wording. >=20 > ~Andrew >=20 >> --- >> docs/misc/xenstore.txt | 17 ++++++++++------- >> 1 file changed, 10 insertions(+), 7 deletions(-) >>=20 >> diff --git a/docs/misc/xenstore.txt b/docs/misc/xenstore.txt >> index 8887e7df88..d807ef0709 100644 >> --- a/docs/misc/xenstore.txt >> +++ b/docs/misc/xenstore.txt >> @@ -45,13 +45,16 @@ them to within 2048 bytes. (See = XENSTORE_*_PATH_MAX in xs_wire.h.) >>=20 >> Each node has one or multiple permission entries. Permissions are >> granted by domain-id, the first permission entry of each node = specifies >> -the owner of the node. Permissions of a node can be changed by the >> -owner of the node, the owner can only be modified by the control >> -domain (usually domain id 0). The owner always has the right to = read >> -and write the node, while other permissions can be setup to allow >> -read and/or write access. When a domain is being removed from = Xenstore >> -nodes owned by that domain will be removed together with all of = those >> -nodes' children. >> +the owner of the node, who always has full access to the node (read = and >> +write permission). >> The access rights of the first entry specify the >> +allowed access for all domains not having a dedicated permission = entry >> +(the default is "n", removing access for all domains not explicitly >> +added via additional permission entries). Permissions of a node can = be >> +changed by the owner of the node, the owner can only be modified by = the >> +control domain (usually domain id 0). This looks good in general, one small nitpick, maybe we need something = like this too: ", or domains equivalent to the owner or control domain (domain = equivalence can be established with the privileged SET_TARGET = operation)" Thanks, --Edwin >> Other permissions can be setup to >> +allow read and/or write access for other domains. When a domain is >> +being removed from Xenstore nodes owned by that domain will be = removed >> +together with all of those nodes' children. >>=20 >>=20 >> Communication with xenstore is via either sockets, or event channel >=20 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:31:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:31:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492611.762237 (Exim 4.92) (envelope-from ) id 1pQ8tM-0008Si-Uk; Thu, 09 Feb 2023 15:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492611.762237; Thu, 09 Feb 2023 15:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8tM-0008Sb-RA; Thu, 09 Feb 2023 15:31:20 +0000 Received: by outflank-mailman (input) for mailman id 492611; Thu, 09 Feb 2023 15:31:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8tL-0008SK-85 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:31:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20604.outbound.protection.outlook.com [2a01:111:f400:7e1b::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbfe292a-a88e-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:31:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7514.eurprd04.prod.outlook.com (2603:10a6:10:1f7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:31:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 15:31:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbfe292a-a88e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5h9osjiUsCy+f8LDaJCmzUibR+yU4fCyIdvHBPbyiIN5Sj8rVWwX4p955gQ3IPA/ou/kbqCj7eKXA524Wf0g5b/S4YQP5sP/nrup9bMBOjiVE1hgindYGZ9yA5ymuEwg8hxLhytVrYsMmFpbvx3S+n4wtbaA4RI+FDfpBCJQLSqqBzNAaQkL1FzNa35HGYKdgkbHggoBIGmwZLkP5y5xp4QJeR8fOqzaJiSrsMB/eyV7wU/4lzjB3fPszoUCkMsRE3sZ9lN4qnHVi8bJtaMrzvgARxFN+TzQ0XH1VzzCyWSLdot9OowwuvdXfHRKcuWMJ1Xu9sA/y4bfN2G6lZ46w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l5UQVFLuzt6IGlVVpfkm+LdZ1XJxsG7rq7LHpAwW1zo=; b=Aic3ujZtcxDCiNy0V7M9nZQ6rBa7tNCvZvlCUrVw6GjNCTku/HvSWNtEHSOujqdCLTCkBMLDSZobBA8J18R8+Z5KcJxxpvinp0CxkFWl+Y/aJlGz+ULLaavCuk0ihbWRHZY0Yx9QiimSyaD31tEtEuY3uRLCIrcUrB02mSv4N9UIKcD/HYdxIXmvsMPZPC1etTelB++904/6lZsMzU5dptp/SUfPlLmUkPJACPytwK5fRCaVZluQEs61D3MRgq/tEU8wWqkX6b2hS7SnGaFSZuFMnGaQoXhITQjZ8/u/9E1XvKl9xXaF4Z7H40B9t5Eru+QT3sg4Uw+renw/NUBImQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5UQVFLuzt6IGlVVpfkm+LdZ1XJxsG7rq7LHpAwW1zo=; b=yzyyv2VWQAKBR18HI0soAzQg4Z/5E6awG19alUOnGzMBYvC1ZxTousNewD+YJMU3oBJaosgKbzkMjYtbbyYWNnnbJCpESuKFpf4DGJl0Tp+/hdpBu9ZR0IcJF6QNLLoap6/GtL4cmzzrB1HNPLeg/jEdOGP3Qysw33tieHQIVkrBWgEU7i7LpCExlbtU7XXAMrYbZamRlbDEx78UvCCc46X/pyvOuZWAQkCKC3Oqxo8jY6FgiTqvFLUsVY/dixlRk9+iokQopSie081MVns/UMFQgk9je+H9orutUnI/U60mExYb9cz47BKH6TCNhZ6/GYsWyn2E/+2angWbUQQqGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 9 Feb 2023 16:31:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH RFC] x86: convert CET tool chain feature checks to mixed Kconfig/Makefile model Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7514:EE_ X-MS-Office365-Filtering-Correlation-Id: 1da27511-ed84-4f2f-df75-08db0ab2ae98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dgu4xMFjZuGl4GSF4sK+izzx+crIf73hgJPL0bKzRkiVbrdz5L5Ltrfg+wj6PmaWamIOxo86l+0DJcZkWfsVFk2qooxGwiH31TRrMvdVBzVAIs7Vk77/1Uv3F4Y5w/BusrqShOtQ5eCEROqwhIvikXx8d+RzRaerREqTkyjHbsMXxSSuoagkRZZZN2z0yExR53ckAgT7X0OanpVvat2ccFJsxRHIYTKpgyapYmkxJlHuqYsYejTE+UJHoRKxNcOqmKjyGhBIZwzPeQYukawn0xoIhkmdmqV/aaSssH3D30CeP4Snkl76V4t4Gq/HUKYjVw98QtI78vVbXV4N4lm9v+O31WNAhNNdecMUa1NNrDTD7raxEAZmy3VOopjbzJ+taXb3xuOPmEymtQPM4+yVa6YeAtiCPRF+iJSYHHWJo3g2+PG/b/ekcMs/dE1Cn4Gkgz2Jr+c4x3vjnoJ+HaPEdi+4G2jcSTS4iypmU5O5BeoR6mx0Xtvre7PzVi6s3TvBzSylpvTmgiBswwE8N8RvYUgyx1xAaPg2JSsCJ0Giia3r4VKzkDoFNt4MKQBeeTbXP2i9D8eQJIIXK9GOEXt3iSJVS78CgFWpgejz5Rej5S3mt97udS5rAJMBKpQjsCNqRBz1SrWf8qkW7dn8MyggDpACJ+8j2gqmYOApMepzbpIpWNw1dSgM8mMMTKN1rrrG0pwSyDebh3Po3WFx47lRdcVKS2sfs6imMW8Be01r9h6d+7bmlZv88rP5Xdss54fF5A34YNuyCb+79M2Kum3CxJ6KA8zQrxlJmuGjbUcd0NvfvojiHYMvCLmwK0LU1Xvv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199018)(31686004)(966005)(478600001)(6486002)(84970400001)(8936002)(6506007)(31696002)(38100700002)(86362001)(5660300002)(83380400001)(66556008)(66946007)(66476007)(41300700001)(316002)(54906003)(36756003)(6512007)(4326008)(186003)(2906002)(2616005)(26005)(8676002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUl2NUZFN0ZMZTNGV0djYTZqSmV2MGE2WUpLQTJZYjJOcEk0SjBtWEc0c2dK?= =?utf-8?B?UWdOUnZJa0VEZk5HZWx1cFBTRkcvZXNaRjBYSWp5NGtXM2FTeStwUFBJUmJE?= =?utf-8?B?R0oyV3o5UWVrOFhLaGNUUldTUTUrQkpjNUxVRVMyWUZvdEZyblc5dk8rNzVV?= =?utf-8?B?cVNIK1hVeFovSjYrSGpab3ZSVDlMNmFKR1RFRHFhYUZTbjh0Yk81eXA0VDBW?= =?utf-8?B?VVkyNkREeWljbEFjODAzeXVOa1Raems0cjArdlFML2hobGxCaXpVNEpGempX?= =?utf-8?B?Z2VKQ2h6c2kwNEFJNFdYbkx5ck40aEJhQVRwa1Z3VEdSaFVNbDk5Z2VqLzdI?= =?utf-8?B?M2xQWVhuN0RWRVZIOGFnU3FWTU91VVB1NWtYVzU5V1FYRVRuc3hxZ2g4T1ZY?= =?utf-8?B?YTlZUFZEa1ozaWFNSWlnb1A2QUhTRlFiTnlBa0hJU25CVmJhOWtYSk5TY3Zs?= =?utf-8?B?bC9LK3htSXZxeW9Vd29pV0VpNWIyaGdGWVoyWnRuc3dqNUkrSDc1UGlUZVgx?= =?utf-8?B?TE4wQUc2blFLQlVIc29MTWVlZW5Cc0J1NUZFaXY3L2xXci9HSTQ4MFhibTU1?= =?utf-8?B?d0xwaDd4RVk2WTRTc0QwcnBaaElBb1FJN1phMXAxaXNCQnJTUWdRdkpEWEQ4?= =?utf-8?B?V2dFK1FQOElOOGxORVd1enYrZ3AzTngzQnJDYmFocUZwTFcwMmJCNlkzakVj?= =?utf-8?B?eVBJVzFyUXRLcTFFUjBKOVNYcWtpM1ZGK3ljYnBHaS9teHh3d3hEdFdmMlBl?= =?utf-8?B?S3BPOHltTzlCbDVBN1FaRktKQjZpWGN2NmxrVk9QY0dBWFZpeEF1eHcwaFpT?= =?utf-8?B?VmtuZWlvdVowQkg1QjVKT3pYN3AzWjlFbHN6YlJ0ZzRNL2V5bll3MmlZb0cw?= =?utf-8?B?a2ZRU0FQeXo1TXdCMTl3N1FpZ1dvNEkrZk5kRW91VDF4L3F0UE5KbWhOTVZy?= =?utf-8?B?c2ZObHNYU1h4SVVsVU53RmluUzBrYS9yL0dyeWhGbFluYWJodDVBMCs5OFRy?= =?utf-8?B?TkEvR1U0SDZkbDVqaUVRaENSVG5CWGVrTisvVUoyVVBLZEtBSjZBbnpGY3hr?= =?utf-8?B?cEdoUFdLeGJlY3RVK0NWRDdtVHFaNCtZeWl2NkpCU1pqRXpsbTdWYXE3eCt6?= =?utf-8?B?a3ZIeXBXck55LzZEMis2bExMakJGZHU4SGt1V0o3VUZIUDJrc2wyUHhjVFpF?= =?utf-8?B?bFFMdGovYUpYQTJaRzQ5L053a1J1cnBGb2R3aDVmZTFaWmlOK1BqZnBaSE5a?= =?utf-8?B?cVdKK2diN0lINFpxNEVPN000SmY5Y2pvN0lkcjFkWjJ0MTJzTW5HdUJnSk9j?= =?utf-8?B?eWZlV0tWeWxqc01NWVFEM2RhRlVVa08xdURKZTJxZWdHTkNpNzhCS0pLcDdz?= =?utf-8?B?RmtPOXozNW1LRlQ5c1QzWnpYM0d2WkRDUTJDV0FUMHlMTVZ2a3NqVlV3Ylkx?= =?utf-8?B?SUpKalF5UjlWYjV1eE5CUzRHUkJNaGFSUGZWOGczUkVBejNZL09aVzZiRUcy?= =?utf-8?B?V3lEcGVuNXNlbUlHaTBCTHY0cEtMVlhBZDE2aWJKSnRFMWgrL3dycVZsdFE1?= =?utf-8?B?Y2JuNG1tQldRNG5XM2JETmlHelRFbk8yT2hlVzlHVUFpSjN1NXpmQWdXYTNQ?= =?utf-8?B?QUNSU0U4eUx0ZzhQTUhURU1Rd2FwbElkZzhuRk90NlcxZFZoUHE4Y1Jha09M?= =?utf-8?B?M3k2WERFR3MwZ21QZndTWlRpdHBYTVF0VDhWTldDdTFkT1ZSRWkyZEpQVTZz?= =?utf-8?B?SGh6cWNBWDhvWUgvNGRYSlhyT25OenFLK0NWUGYrdVA3YzVYbzFlWTdaTWFG?= =?utf-8?B?NFpSd2RQaElSYk9nUUcxOWx2VmVKWDQyUEVLSU8xYjR0OTZXQXNpZkhZN0Z0?= =?utf-8?B?S2JjQU4ycG5FMHl3RWRJU3JrSkFKekE1WUwyTkdPZUFJamVsRVRhWEdMNmRC?= =?utf-8?B?TFcwM2RmWExCTUlqZ0hQTWk2bksxakMzU20wMHhPY1hGTzJmNEdCdTVBc0pm?= =?utf-8?B?ZVNRYWtJaGR2NXRlcDFpVGtRaFpYNUpYWUNTdHhyNk1MUkl0Nm53ZFJ6Q292?= =?utf-8?B?blJJdHRyM0NDcjlSd0NwMW1BdlpoeGFVVjBmVVBmZUFLZmxWVmNnQ1NNdFYz?= =?utf-8?Q?8fu5G9xY7MdAYxSvKpRurLCN+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1da27511-ed84-4f2f-df75-08db0ab2ae98 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:31:15.4330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OSOsw+dF0kvyHuBI8mzVj9xULSiYptHS8PoKrpifEDolIUproO8O43ZN8ym/XkEl1c/jHYqaxvl2h0fdvbbQ6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7514 To make sure user choices solely affected by tool chain capabilities can't silently go off, convert the two Kconfig controls from "depends on ..." to "default ...". Suggest a default matching what the presently selected tool chain is capable of. To compensate, double check compiler option availability as well as the assembler recognizing the necessary insns early on when actually starting a build. This then also allows to run the configure step with a compiler version different from (perhaps older than) the one later used for actual building. Signed-off-by: Jan Beulich --- Using warnings instead of errors in the Makefile-based checks for now, despite the opposite suggestion during the design session in Cambridge. This is primarily to avoid failing the build just in case our double- checking is flawed. And in fact there is such a quirk right now with the changes made here: arch.mk is included ahead of .config being updated, so the checks are carried out with potentially stale CONFIG_* settings. Perhaps the checks need suppressing when .config is in the process of being updated (after which make will re-start, then doing the checks with the correct CONFIG_* values). It's not (yet) clear to me how to arrange for that, though, as the inclusion of arch.mk already sits inside the !config-build section of the top-level Makefile. For initial feedback I've modelled cc-option-check pretty closely after cc-option-add, whereas I've tried to make as-insn-check's output more useful while at the same time removing the need to pass both CFLAGS and CC into the macro (if anything, HOST would now need passing if the check was for the host compiler; we could certainly decide to drop that likely unnecessary flexibility). --- unstable.orig/Config.mk 2023-02-09 15:08:24.195431817 +0100 +++ unstable/Config.mk 2023-02-09 14:09:05.000000000 +0100 @@ -105,6 +105,18 @@ endef cc-options-add = $(foreach o,$(3),$(call cc-option-add,$(1),$(2),$(o))) +# cc-option-check: Double-check availablility of a compiler option. +# Usage: $(call cc-option-check CFLAGS,CC,-march=winchip-c6) +cc-option-check = $(eval $(call cc-option-check-closure,$(1),$(2),$(3))) +define cc-option-check-closure + ifeq ($$(call cc-option,$$($(2)),$(3),n),n) + $$(warning '$$($(2))' does not recognize '$(3)') + endif + $(1) += $(3) +endef + +cc-options-check = $(foreach o,$(3),$(call cc-option-check,$(1),$(2),$(o))) + # cc-ver: Check compiler against the version requirement. Return boolean 'y'/'n'. # Usage: ifeq ($(call cc-ver,$(CC),ge,0x030400),y) cc-ver = $(shell if [ $$((`$(1) -dumpversion | awk -F. \ --- unstable.orig/xen/arch/x86/Kconfig 2023-02-09 15:08:24.195431817 +0100 +++ unstable/xen/arch/x86/Kconfig 2023-02-09 11:59:29.000000000 +0100 @@ -119,9 +119,8 @@ config HVM config XEN_SHSTK bool "Supervisor Shadow Stacks" - depends on HAS_AS_CET_SS - default y - ---help--- + default HAS_AS_CET_SS + help Control-flow Enforcement Technology (CET) is a set of features in hardware designed to combat Return-oriented Programming (ROP, also call/jump COP/JOP) attacks. Shadow Stacks are one CET feature @@ -133,8 +132,7 @@ config XEN_SHSTK config XEN_IBT bool "Supervisor Indirect Branch Tracking" - depends on HAS_CC_CET_IBT - default y + default HAS_CC_CET_IBT help Control-flow Enforcement Technology (CET) is a set of features in hardware designed to combat Return-oriented Programming (ROP, also --- unstable.orig/xen/arch/x86/arch.mk 2023-02-09 15:08:24.195431817 +0100 +++ unstable/xen/arch/x86/arch.mk 2023-02-09 15:08:37.088842654 +0100 @@ -34,6 +34,10 @@ $(call as-option-add,CFLAGS,CC,\ $(call as-option-add,CFLAGS,CC,\ ".L1: .L2: .nops (.L2 - .L1)$$(comma)9",-DHAVE_AS_NOPS_DIRECTIVE) +$(call as-insn-check,XEN_IBT,,endbr64) +$(call as-insn-check,XEN_SHSTK,,wrssq %rax$(comma)0) +$(call as-insn-check,XEN_SHSTK,,setssbsy) + CFLAGS += -mno-red-zone -fpic # Xen doesn't use MMX or SSE interally. If the compiler supports it, also skip @@ -51,10 +55,11 @@ CFLAGS-$(CONFIG_CC_IS_CLANG) += -mretpol endif ifdef CONFIG_XEN_IBT +$(call cc-options-check,CFLAGS,CC,-fcf-protection=branch -mmanual-endbr) # Force -fno-jump-tables to work around # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104816 # https://github.com/llvm/llvm-project/issues/54247 -CFLAGS += -fcf-protection=branch -mmanual-endbr -fno-jump-tables +CFLAGS += -fno-jump-tables $(call cc-option-add,CFLAGS,CC,-fcf-check-attribute=no) else $(call cc-option-add,CFLAGS,CC,-fcf-protection=none) --- unstable.orig/xen/scripts/Kbuild.include 2023-02-09 15:08:24.195431817 +0100 +++ unstable/xen/scripts/Kbuild.include 2023-02-09 14:13:52.000000000 +0100 @@ -73,6 +73,18 @@ define as-option-add-closure endif endef +# as-insn-check: Double-check that the assembler backing (or built into) the +# compiler recognizes "insn" +# Usage: $(call as-insn-check,,,) +as-insn-check = $(eval $(call as-insn-check-closure,$(1),$(2),$(3))) +define as-insn-check-closure + ifeq ($$(CONFIG_$(1)),y) + ifneq ($$(call as-insn,$$($(2)CC) $$($(2)CFLAGS),"$$(3)",y,n),y) + $$(warning CONFIG_$(1)=y but assembler used by '$$($(2)CC)' doesn't recognize '$$(3)') + endif + endif +endef + # $(call if-success,,,) # Return if exits with 0, otherwise. if-success = $(shell { $(1); } >/dev/null 2>&1 && echo "$(2)" || echo "$(3)") From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:32:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492618.762248 (Exim 4.92) (envelope-from ) id 1pQ8un-0000aw-9h; Thu, 09 Feb 2023 15:32:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492618.762248; Thu, 09 Feb 2023 15:32:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8un-0000ap-6n; Thu, 09 Feb 2023 15:32:49 +0000 Received: by outflank-mailman (input) for mailman id 492618; Thu, 09 Feb 2023 15:32:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ8ul-0000af-KD for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:32:47 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20600.outbound.protection.outlook.com [2a01:111:f400:fe1a::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 002a6dfb-a88f-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:32:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8274.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 15:32:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 15:32:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 002a6dfb-a88f-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAnyfNRi+ll36KzYeGyd6Dw++S0NlrJ9sMxHsWBpeFUYfkU9qFSXEa9a3M4NrVBCmK+vQJANqXyng/yfGi6gso7L3OwPiH2z1ilbYqYXLAR056xEVxg5qm4HOhtVYWWlkRKnebvMpiQ5cjA9lwFAOWdKjhN7x3TxvNRsLZCI6pZpmWHRw6kec+R97jC2soRVvcTWaLebgDntpvP27blC+TqGH4tjS8DEYULqGkDcUdhHmFRvVxPRscHilWYvMZDuwm6+XMQX+abR7Bd+ruSMluoEd6R9W9nDynU5FdtYHG999GajoZqp+LMaUq1y46NmI6A2DL0wJV8Ba3jFjiOODA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XQ+uHizeSoKLL3Pg9FTYVUHeQBMPxJ4WX+hi/cZJMcM=; b=iirNk3mT69twO5KdZXOBOmtPUiHCosjWxBvjvUGPKmui4TM38uy0n9mhyUuIcHyfMxwZ/GKU0KMIT3iHvuHyw1uevc+SNI8n4MwoScGvwcythapeyrbF7jF4O1EeRI6xeHuxCuLzTZpjgR0IgWZWBnvd7L3mE97PwqLTxXSWXcBwYh7nJdm9be74VFeaGqWs3Z9+4/jFv+Z133cBS2nbZ0skv5O8bknE/V293W5/hD0og+Qba6o/jqOKPlvdzoClbFxDOSx8fShHheGv7f6585Ua/9WVYL5piHQbnuwNDMwQgPP9DY6RBUVnkHtkgz0mINHipF/WVNlQ5LwTR/Ye2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XQ+uHizeSoKLL3Pg9FTYVUHeQBMPxJ4WX+hi/cZJMcM=; b=sFbTkTQsOQBAxbrVJiK7ffOVqzLBQxZbWkXcOHkj0zcZ4rcpYJt6IJi1mxvaTZ+YFNAATEUh68zFEB3wQ5mNkZempPbR7NpBqCDWyAjr61a3AjU9MCywJ2dKU81tUWI6vsnXwpuOl5FpqUIbFpRrwbKSPGVsG4PFFERPoPFnx73tsn52QEy8ePEzA2of3QX0ZvUzT7GDsgdQ8Lmuwc2s8uW/T/DqUS5/zuFdRjoPRUt5/Fcn3r5P6mI83qTGCVqUTroy64dfjDtElteCBK2ziVr9O/qD/4/toivaKNJlWlp0ZjSK7ZCVdOY+1Z0bnlvSr4TURIWTDjd3OkZmnpw72g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f60e273-e8e3-848d-f3fd-68d7318e2e62@suse.com> Date: Thu, 9 Feb 2023 16:32:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Jan Beulich Subject: [PATCH v2] x86/p2m: tighten old-MFN check in p2m_add_page() To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8274:EE_ X-MS-Office365-Filtering-Correlation-Id: e3521cb0-c010-4e9a-a511-08db0ab2e393 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xgQFFqcl9A9AnP66xobqHJ3Bh0ZUS+3Le/6Kp5KRxkD9dWU8RmvIQojt39BS7U/uTs008060WP+JgyV8Z/7U7v4uWkurPBQyaY65+3Xx581kehmppYRP7lAM13UZtCg+NpfPaNj7w2ZTFAOeXrgULH6N7U5w1TjDyjphWVBuFidwKuwINI2Hz+iESCWYyTpmkdXIFZAZO+BRCnlz/WCaIZMCBpKG4Ryq+OILx3AYYWu6eM3dPz2jmRj13FxqrrTMPGNGtAwo4mDIqZ5ckDyrDBjygT2nqd6Gne1q10Azc3Gu/wGGb8M+dPPc5j8Ge0bF1ob42/cF8upyn+lUoHC9FkdUiF0/ND+BumB7SHhBsrQE+2ogc4TyyeBwNLC0Rced3m+pAq+JDqdO1DWf26+EsFijjzravth0dggfVmkVSmhIsda6nNEpF1Lzf5PKPn6A3DDjDrumeyhiz6jc8qAyf4Aja9cBdw+S7bYjXE6OyWLueil2wVZeQt2zm7EJQKg+RuFT86lDxUp0YSIw1uNBM5zd2LHn3BNaeF2Bedq2NQagnnsUlDblAOZAwuYs+TonP4m4S1nTI2ZvsT0je4ecVt7KmleA/FkCoYbCYwXCdcqLqNZCzGLQM5lxC/5jcTT4Ihz9BPcZJaONLqiKU/aSNkEPHFvIIEbMdLxqjAQV4bX/nNjCKV1zhv7lsf8uPjf/1RlmLQ+6mTtgH7Jx0I+abJsXWeFtFROLO+zU5WLTj7c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(376002)(346002)(39860400002)(396003)(451199018)(5660300002)(26005)(31696002)(86362001)(186003)(8936002)(2616005)(38100700002)(6512007)(83380400001)(54906003)(41300700001)(4326008)(66946007)(316002)(6916009)(66556008)(8676002)(66476007)(6506007)(478600001)(6486002)(36756003)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlI3TVA5SW0xZGgweTR4Rzg0dVdxdi8wYVBCMUVXK2t2MWFWcVoyNDF3SEZw?= =?utf-8?B?K3pKZFVaYVhXNWw3NXdvMmI2TkNwakVtZFZFczdCRzdCaHdnTk5lK29zaUpD?= =?utf-8?B?K3BQdG5wSlZwZ0RpeVVPNzY2K25uMjU5ZE1wOE8yU05vVGIveXRXYVN4d2Fv?= =?utf-8?B?Mkh5dXRGR1kwR0FZekR0YlhMMmNpS1d1SmFBcVVEVHAya0hpeXNqWENIREJ1?= =?utf-8?B?R3IvSVZ4U2JiUUFYL2FDdlcxOHg0SUMyWHFiKzZIVUhQWHA0MFU1SEtSSkVO?= =?utf-8?B?ZXQ0K29BSTIzZlB2T21ITmRqWWxQZzRuRnVOazJMd2JuQWxncnV5YUFFUjFn?= =?utf-8?B?Z25nS2F2MXhRTGFSekVqTU16VW05Ry9xMnFHbDQrcm00ZHZVZTVQUXA5dTVi?= =?utf-8?B?UEhhNVp0WldabEw4aXJpSFA1YW9pSk14MGtsMHJFclRtWXl0cE5ZcFllR0Zx?= =?utf-8?B?cmVFVjE3eC9mUjR2UnJxam1FQ0JVcmV4TnRzV3NBbExMeDY4dEU1d2JaNVRR?= =?utf-8?B?Z2krTzdrUnRxWU1neVV6UnFwMmdMNlpTeEoxYzBpWXZEVW9CcFdFVzZIWHlh?= =?utf-8?B?dGp5aFVldEV6UER4Vk9MYWVDMzE5QktmZ2crRnNCb3BvdzhYV0kwVHdwMlNJ?= =?utf-8?B?YW9wbDJjYmU0Mmk1bEdjK3lDNkZpbWR1VlFDTHVuWFYrRGwrdUV4Y3JYckxL?= =?utf-8?B?REVTVHExalRNOWtFZU5rTUF6eWhlQjhKRkttb1pxQVJOdTlCZ2d2R3pZendx?= =?utf-8?B?UEExQUtIWWZMNEtHVVJSWDd4djZwQy9zb21YcXk0R254bTcrZUxYbjhWdWdJ?= =?utf-8?B?eGN0S0x4cVJhbGZqYTNWd0ZhUDhGQVprc1BlUWlUa3hIRkpGUkUwclVvRmtN?= =?utf-8?B?WG8xRHo2V1RLK3VkOXR5UXNwT0ZhTWcybU9YZCtvdjFsTWtrQjhzY1pVSHRX?= =?utf-8?B?ZVBwNkUvaHdicSsrMWhldFcwT0xhWUh1SmhUK29xRWllZGhnVmlVcWEzd1FL?= =?utf-8?B?bHhWOWhsSFhGWnpESitPZXNjZW1qTmc3RzFNZ2pBS3Nhb3pPRFRsek1qZHBl?= =?utf-8?B?SENZTEt5RG5xdlZkcFp0dy9IaXVQVzlLTlorUXNoUEtMTUpGQklFYnA2WUZ2?= =?utf-8?B?TUJoSzVTU3o4Qk9MZ0I1T3VOeWhxS2FFdXkvRjRKQWhEYkdtbjQ4NHFZSWY2?= =?utf-8?B?YVh2M3dVbFQySDdUU2xIaWViN2hHMWphRkRVRUxGSk8xVWtoVjM3QnhMc3Nn?= =?utf-8?B?NWFRTnl3NnBoVlJ6WWk2b1hzWFhIazI5TGpraXB0Y1IwZHlSUUJQdGNrS2xG?= =?utf-8?B?RU9XSjdZWVI0b3lhQVVCTUQ5S29wN2U0WnRURTkveVB5cXU1aE00OTRzTldx?= =?utf-8?B?MTVtRlJGampSSnVGbkNITEdvMng3bmY0WjNaR1J3VnRJSExTSG0yM2ZaWnhZ?= =?utf-8?B?QWkvaEZtZERZaXZpUWdVcU9ZUUxwVTZrZDQ5cG1kUjNLa1dnM0k4cVFUempB?= =?utf-8?B?QTlWdjhwS3ZwRjFrWk1IQzFyRXNPa0JneFRFME1jd0liemh5eGgxY3RsUmpk?= =?utf-8?B?c0gra2VIaEI5VHhleXM2Q2Y5MU5uRnlwNUZTWnRMT2pMOVVQZHN1S0JoUkdj?= =?utf-8?B?VWZQV0dVREZhQTZEN1drcE9Da3JxODBHZlA4SG1zUDdTazNta2Z2eERNclFL?= =?utf-8?B?K0NFZXY4WmNSV1pvTmh3VjZsbXArZzRYbFVnYmFRWGI2MDhVbFV0clpxWmsr?= =?utf-8?B?OXZPWkZzV0Y1blU0eUl6OFV3bXlqWk9lME5lL3M2ZHl1K21ZMjhNaG1LbTVv?= =?utf-8?B?Vm1lRDZOT1RhTzRCczJDL2pUT0o5NGVnbG1oZ0ZGZHdTQjBHaHIrMm80aDVY?= =?utf-8?B?NEJoR3lXckpqeXVXdW5TT3ZzRTM3Ri9UcGZVODZvVHVzaTZNS0I5UXV2UDd1?= =?utf-8?B?NVNQa0xTOEZoS0d1dmkvQmE2YTBXT2htRjFxbEwyNk92a0NiRDRLbE4xVlZQ?= =?utf-8?B?dnhGWDVpeCttR0cwTHlQMDc2K04wQW9OT3RMOEZZTkZOdUEvSUpURUhnT0Vs?= =?utf-8?B?SHpPT0laU0pkOG9kTi9QN1FNaytPUnllQjliVGQ4alhvQnlWZWZRT3NMdGNY?= =?utf-8?Q?4uGSI9BOiYJKoJCUGAzuz9A+j?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3521cb0-c010-4e9a-a511-08db0ab2e393 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 15:32:44.3180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z3wabkzpCjij8RmqUOz43w8QwHPkbEzkEs3B/zydR5U1cS/5ljI7BRYAGgN3qsFgs1ekyz7FM80xoXHFUqF0rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8274 Just ahead of the logic in question we've translated the subject MFN to a valid original GFN, in order to then translate that GFN back to an MFN. Restricting the call to p2m_remove_page() to the case where these two MFNs match is too weak. Instead refuse the operation altogether when there's a mismatch (which likely indicates a bug elsewhere in Xen), by leveraging the checking in p2m_remove_entry() via passing in the expected MFN. Signed-off-by: Jan Beulich --- If we were certain that a mismatch indicates a bug elsewhere, we might want to consider crashing the domain instead, to limit damage as well as to make sure the issue is actually noticed. --- v2: Drop the check rather than separating it out. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -719,8 +719,7 @@ p2m_add_page(struct domain *d, gfn_t gfn ASSERT(mfn_valid(omfn)); P2M_DEBUG("old gfn=%#lx -> mfn %#lx\n", gfn_x(ogfn) , mfn_x(omfn)); - if ( mfn_eq(omfn, mfn_add(mfn, i)) && - (rc = p2m_remove_entry(p2m, ogfn, omfn, 0)) ) + if ( (rc = p2m_remove_entry(p2m, ogfn, mfn_add(mfn, i), 0)) ) goto out; } } From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:43:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492629.762259 (Exim 4.92) (envelope-from ) id 1pQ94y-0002Ng-Ez; Thu, 09 Feb 2023 15:43:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492629.762259; Thu, 09 Feb 2023 15:43:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ94y-0002NZ-Ap; Thu, 09 Feb 2023 15:43:20 +0000 Received: by outflank-mailman (input) for mailman id 492629; Thu, 09 Feb 2023 15:43:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ94w-0002MA-S8 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:43:19 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76c8d14c-a890-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:43:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76c8d14c-a890-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675957395; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=55kE0HTPmlwaufUDDLRel8X/8YuHKHFsZZWYGoztJTY=; b=SvicFw39kQbHjTyrFj0AalkA2cK6zwc0RBrjJ5TomjfK/lO4lNgNxeE1 BNXejZu3Sauz/fHUuvGXU68PAd07fHAHd6l3zZu9zkcEERkGCKpqjqI8k kyT9UuM8waoREw/Uu/11cK03eRuDIYVbh0TMCdCg6hlIasii1EekgzciD Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98804802 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:kYXRYKnFUULN4q/0wb6CtYDo5gyOJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIfWWGEMvaIYjGge9h2aNzl9B9X7ZCAmtdkSVNpqnozFCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5A6GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dM8ESIxYAqovMeJx7GhELYxoeUhFda+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthfI9 jqarzyjav0cHPDO8QLY20yrvLXKnAH8Zo4VCeGy+cc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JcGvM3wBuAwa3V50CeHGdsc9JaQIV47olsH2Vsj wLX2YqzXlSDrYF5V1qy0o6GkT2oEhMwEmgBf3VbECwk4eD89dRbYg30cv5vF6u8j9vQED72w iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N/02wYH83oJrW7FF5ufkWd4vllDyL9BaJpsRNMQS Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4u4BqCNNoQfM8IgHONiwM2ITRXAt4wKuBFz+ZzTx L/BKZr8ZZrkIfsPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bMIYrpxGCmN7hjhIvd+VW9z jqqH5fSo/mpeLGkM3a/HE96BQxiEEXX8ris8ZYHJ7fceFY9cIzjYteIqY4cl0Vet/w9vo/1E ruVBie0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:wNoys6tch7RlZjkYpkPnEJud7skC6oMji2hC6mlwRA09TyXGra qTdaUgviMc1gx4ZJh5o6H5BEGBKUm9yXcH2/hrAV7CZniuhILMFuxfBOTZslnd8kHFmNK1kJ 0QCpSWa+eARWSS7/yKhzVQeuxIrLa6GeKT9IHjJhxWPGJXgtRbnmJE43GgYy9LrWd9ZKYRJd 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njFsRqYrJrBVzSI1BYXVD1ChZ0493 LergD/7qK/99mm1x7n0XPJ5Zg+oqqt9jIDPr3BtiEmEESjtu+aXvUhZ1S2hkF7nAjg0idrrD CGmWZbAy060QKtQojym2qn5+Co6kdT11byjVCfmnftusr/WXYzDNdAn5tQdl/D51Mnp8wU6t M+44u1jeskMfr7plWJ2/HYExVx0kakq3srluAey3RZTIsFcbdU6YgS5llcHpsMFD/zrNlPKp gZMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wi0EY2MsclHEd849Vcegy28 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBQnBNWqDSG6XZ53v+0i926IfzI9Fld1CIqZ4s6fasK 6xLm9liQ== X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="98804802" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Christian Lindig , David Scott , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Rob Hoes Subject: [PATCH] tools/ocaml: Drop libxl bindings Date: Thu, 9 Feb 2023 15:43:00 +0000 Message-ID: <20230209154300.22130-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There are significant issues with these bindings, and their companion half in Xapi was deleted in 2018 https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d owing to there having been no development of these bindings since 2014. In the unlikely event that we'd want to reinstate them, they'd need reworking basically from scratch anyway. Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: David Scott CC: Edwin Török CC: Rob Hoes I'm unsure whether to drop xentoollog. They're technically orphaned by this change, but could be used in principle by the other bindings. --- tools/ocaml/Makefile | 4 - tools/ocaml/libs/Makefile | 2 +- tools/ocaml/libs/xl/META.in | 5 - tools/ocaml/libs/xl/Makefile | 71 -- tools/ocaml/libs/xl/genwrap.py | 582 ------------ tools/ocaml/libs/xl/xenlight.ml.in | 94 -- tools/ocaml/libs/xl/xenlight.mli.in | 93 -- tools/ocaml/libs/xl/xenlight_stubs.c | 1663 ---------------------------------- tools/ocaml/test/Makefile | 55 -- tools/ocaml/test/dmesg.ml | 17 - tools/ocaml/test/list_domains.ml | 26 - tools/ocaml/test/raise_exception.ml | 9 - tools/ocaml/test/send_debug_keys.ml | 13 - tools/ocaml/test/xtl.ml | 39 - 14 files changed, 1 insertion(+), 2672 deletions(-) delete mode 100644 tools/ocaml/libs/xl/META.in delete mode 100644 tools/ocaml/libs/xl/Makefile delete mode 100644 tools/ocaml/libs/xl/genwrap.py delete mode 100644 tools/ocaml/libs/xl/xenlight.ml.in delete mode 100644 tools/ocaml/libs/xl/xenlight.mli.in delete mode 100644 tools/ocaml/libs/xl/xenlight_stubs.c delete mode 100644 tools/ocaml/test/Makefile delete mode 100644 tools/ocaml/test/dmesg.ml delete mode 100644 tools/ocaml/test/list_domains.ml delete mode 100644 tools/ocaml/test/raise_exception.ml delete mode 100644 tools/ocaml/test/send_debug_keys.ml delete mode 100644 tools/ocaml/test/xtl.ml diff --git a/tools/ocaml/Makefile b/tools/ocaml/Makefile index 85bfd087c9c6..1557fd6c3c1a 100644 --- a/tools/ocaml/Makefile +++ b/tools/ocaml/Makefile @@ -4,10 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk SUBDIRS := libs SUBDIRS += xenstored -ifeq ($(CONFIG_TESTS),y) -SUBDIRS += test -endif - .NOTPARALLEL: # targets here must be run in order, otherwise we can try # to build programs before the libraries are done diff --git a/tools/ocaml/libs/Makefile b/tools/ocaml/libs/Makefile index 5146c5248460..49ea7dd1cb8a 100644 --- a/tools/ocaml/libs/Makefile +++ b/tools/ocaml/libs/Makefile @@ -5,7 +5,7 @@ SUBDIRS= \ mmap \ xentoollog \ eventchn xc \ - xb xs xl + xb xs .PHONY: all all: subdirs-all diff --git a/tools/ocaml/libs/xl/META.in b/tools/ocaml/libs/xl/META.in deleted file mode 100644 index 3f0c5526cb2e..000000000000 --- a/tools/ocaml/libs/xl/META.in +++ /dev/null @@ -1,5 +0,0 @@ -version = "@VERSION@" -description = "Xen Toolstack Library" -requires = "xentoollog" -archive(byte) = "xenlight.cma" -archive(native) = "xenlight.cmxa" diff --git a/tools/ocaml/libs/xl/Makefile b/tools/ocaml/libs/xl/Makefile deleted file mode 100644 index 22d6c93aae7a..000000000000 --- a/tools/ocaml/libs/xl/Makefile +++ /dev/null @@ -1,71 +0,0 @@ -OCAML_TOPLEVEL=$(CURDIR)/../.. -XEN_ROOT=$(OCAML_TOPLEVEL)/../.. -include $(OCAML_TOPLEVEL)/common.make - -# ignore unused generated functions and allow mixed declarations and code -CFLAGS += -Wno-unused -Wno-declaration-after-statement - -CFLAGS += $(CFLAGS_libxenlight) -CFLAGS += -I ../xentoollog -CFLAGS += $(APPEND_CFLAGS) - -OBJS = xenlight -INTF = xenlight.cmi -LIBS = xenlight.cma xenlight.cmxa - -OCAMLINCLUDE += -I ../xentoollog - -LIBS_xenlight = $(call xenlibs-ldflags-ldlibs,light) - -xenlight_OBJS = $(OBJS) -xenlight_C_OBJS = xenlight_stubs - -OCAML_LIBRARY = xenlight - -GENERATED_FILES += xenlight.ml xenlight.ml.tmp xenlight.mli xenlight.mli.tmp -GENERATED_FILES += _libxl_types.ml.in _libxl_types.mli.in -GENERATED_FILES += _libxl_types.inc META - -all: $(INTF) $(LIBS) - -xenlight.ml: xenlight.ml.in _libxl_types.ml.in - $(Q)sed -e '1i\ -(*\ - * AUTO-GENERATED FILE DO NOT EDIT\ - * Generated from xenlight.ml.in and _libxl_types.ml.in\ - *)\ -' \ - -e '/^(\* @@LIBXL_TYPES@@ \*)$$/r_libxl_types.ml.in' \ - < xenlight.ml.in > xenlight.ml.tmp - $(Q)mv xenlight.ml.tmp xenlight.ml - -xenlight.mli: xenlight.mli.in _libxl_types.mli.in - $(Q)sed -e '1i\ -(*\ - * AUTO-GENERATED FILE DO NOT EDIT\ - * Generated from xenlight.mli.in and _libxl_types.mli.in\ - *)\ -' \ - -e '/^(\* @@LIBXL_TYPES@@ \*)$$/r_libxl_types.mli.in' \ - < xenlight.mli.in > xenlight.mli.tmp - $(Q)mv xenlight.mli.tmp xenlight.mli - -_libxl_types.ml.in _libxl_types.mli.in _libxl_types.inc: genwrap.py $(XEN_ROOT)/tools/libs/light/libxl_types.idl \ - $(XEN_ROOT)/tools/libs/light/idl.py - PYTHONPATH=$(XEN_ROOT)/tools/libs/light $(PYTHON) genwrap.py \ - $(XEN_ROOT)/tools/libs/light/libxl_types.idl \ - _libxl_types.mli.in _libxl_types.ml.in _libxl_types.inc - -libs: $(LIBS) - -.PHONY: install -install: $(LIBS) META - mkdir -p $(OCAMLDESTDIR) - $(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenlight - $(OCAMLFIND) install -destdir $(OCAMLDESTDIR) -ldconf ignore xenlight META $(INTF) $(LIBS) *.a *.so *.cmx - -.PHONY: uninstall -uninstall: - $(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenlight - -include $(OCAML_TOPLEVEL)/Makefile.rules diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py deleted file mode 100644 index 7bf26bdcd831..000000000000 --- a/tools/ocaml/libs/xl/genwrap.py +++ /dev/null @@ -1,582 +0,0 @@ -#!/usr/bin/python - -from __future__ import print_function - -import sys,os -from functools import reduce - -import idl - -# typename -> ( ocaml_type, c_from_ocaml, ocaml_from_c ) -builtins = { - "bool": ("bool", "%(c)s = Bool_val(%(o)s)", "Val_bool(%(c)s)" ), - "int": ("int", "%(c)s = Int_val(%(o)s)", "Val_int(%(c)s)" ), - "char *": ("string option", "%(c)s = String_option_val(%(o)s)", "Val_string_option(%(c)s)"), - "libxl_domid": ("domid", "%(c)s = Int_val(%(o)s)", "Val_int(%(c)s)" ), - "libxl_devid": ("devid", "%(c)s = Int_val(%(o)s)", "Val_int(%(c)s)" ), - "libxl_defbool": ("bool option", "%(c)s = Defbool_val(%(o)s)", "Val_defbool(%(c)s)" ), - "libxl_uuid": ("int array", "Uuid_val(&%(c)s, %(o)s)", "Val_uuid(&%(c)s)"), - "libxl_bitmap": ("bool array", "Bitmap_val(ctx, &%(c)s, %(o)s)", "Val_bitmap(&%(c)s)"), - "libxl_key_value_list": ("(string * string) list", "libxl_key_value_list_val(&%(c)s, %(o)s)", "Val_key_value_list(&%(c)s)"), - "libxl_string_list": ("string list", "libxl_string_list_val(&%(c)s, %(o)s)", "Val_string_list(&%(c)s)"), - "libxl_mac": ("int array", "Mac_val(&%(c)s, %(o)s)", "Val_mac(&%(c)s)"), - "libxl_hwcap": ("int32 array", None, "Val_hwcap(&%(c)s)"), - "libxl_ms_vm_genid": ("int array", "Ms_vm_genid_val(&%(c)s, %(o)s)", "Val_ms_vm_genid(&%(c)s)"), - # The following needs to be sorted out later - "libxl_cpuid_policy_list": ("unit", "%(c)s = 0", "Val_unit"), - } - -DEVICE_FUNCTIONS = [ ("add", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), - ("remove", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), - ("destroy", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), - ] -DEVICE_LIST = [ ("list", ["ctx", "domid", "t list"]), - ] - -functions = { # ( name , [type1,type2,....] ) - "device_vfb": DEVICE_FUNCTIONS, - "device_vkb": DEVICE_FUNCTIONS, - "device_disk": DEVICE_FUNCTIONS + DEVICE_LIST + - [ ("insert", ["ctx", "t", "domid", "?async:'a", "unit", "unit"]), - ("of_vdev", ["ctx", "domid", "string", "t"]), - ], - "device_nic": DEVICE_FUNCTIONS + DEVICE_LIST + - [ ("of_devid", ["ctx", "domid", "int", "t"]), - ], - "device_pci": DEVICE_FUNCTIONS + DEVICE_LIST + - [ ("assignable_add", ["ctx", "t", "bool", "unit"]), - ("assignable_remove", ["ctx", "t", "bool", "unit"]), - ("assignable_list", ["ctx", "t list"]), - ], - "dominfo": [ ("list", ["ctx", "t list"]), - ("get", ["ctx", "domid", "t"]), - ], - "physinfo": [ ("get", ["ctx", "t"]), - ], - "cputopology": [ ("get", ["ctx", "t array"]), - ], - "domain_sched_params": - [ ("get", ["ctx", "domid", "t"]), - ("set", ["ctx", "domid", "t", "unit"]), - ], -} -def stub_fn_name(ty, name): - return "stub_xl_%s_%s" % (ty.rawname,name) - -def ocaml_type_of(ty): - if ty.rawname in ["domid","devid"]: - return ty.rawname - elif isinstance(ty,idl.UInt): - if ty.width in [8, 16]: - # handle as ints - width = None - elif ty.width in [32, 64]: - width = ty.width - else: - raise NotImplementedError("Cannot handle %d-bit int" % ty.width) - if width: - return "int%d" % ty.width - else: - return "int" - elif isinstance(ty,idl.Array): - return "%s array" % ocaml_type_of(ty.elem_type) - elif isinstance(ty,idl.Builtin): - if ty.typename not in builtins: - raise NotImplementedError("Unknown Builtin %s (%s)" % (ty.typename, type(ty))) - typename,_,_ = builtins[ty.typename] - if not typename: - raise NotImplementedError("No typename for Builtin %s (%s)" % (ty.typename, type(ty))) - return typename - elif isinstance(ty,idl.KeyedUnion): - return ty.union_name - elif isinstance(ty,idl.Aggregate): - if ty.rawname is None: - return ty.anon_struct - else: - return ty.rawname.capitalize() + ".t" - else: - return ty.rawname - -ocaml_keywords = ['and', 'as', 'assert', 'begin', 'end', 'class', 'constraint', - 'do', 'done', 'downto', 'else', 'if', 'end', 'exception', 'external', 'false', - 'for', 'fun', 'function', 'functor', 'if', 'in', 'include', 'inherit', - 'initializer', 'lazy', 'let', 'match', 'method', 'module', 'mutable', 'new', - 'object', 'of', 'open', 'or', 'private', 'rec', 'sig', 'struct', 'then', 'to', - 'true', 'try', 'type', 'val', 'virtual', 'when', 'while', 'with'] - -def munge_name(name): - if name in ocaml_keywords: - return "xl_" + name - else: - return name - -def ocaml_instance_of_field(f): - if isinstance(f.type, idl.KeyedUnion): - name = f.type.keyvar.name - else: - name = f.name - return "%s : %s" % (munge_name(name), ocaml_type_of(f.type)) - -def gen_struct(ty, indent): - s = "" - for f in ty.fields: - if f.type.private: - continue - x = ocaml_instance_of_field(f) - x = x.replace("\n", "\n"+indent) - s += indent + x + ";\n" - return s - -def gen_ocaml_keyedunions(ty, interface, indent, parent = None): - s = "" - union_type = "" - - if ty.rawname is not None: - # Non-anonymous types need no special handling - pass - elif isinstance(ty, idl.KeyedUnion): - if parent is None: - nparent = ty.keyvar.name - else: - nparent = parent + "_" + ty.keyvar.name - - for f in ty.fields: - if f.type is None: continue - if f.type.rawname is not None: continue - if isinstance(f.type, idl.Struct) and not f.type.has_fields(): continue - s += "\ntype %s_%s =\n" % (nparent,f.name) - s += "{\n" - s += gen_struct(f.type, indent + "\t") - s += "}\n" - - name = "%s__union" % ty.keyvar.name - s += "\n" - s += "type %s = " % name - u = [] - for f in ty.fields: - if f.type is None: - u.append("%s" % (f.name.capitalize())) - elif isinstance(f.type, idl.Struct): - if f.type.rawname is not None: - u.append("%s of %s.t" % (f.name.capitalize(), f.type.rawname.capitalize())) - elif f.type.has_fields(): - u.append("%s of %s_%s" % (f.name.capitalize(), nparent, f.name)) - else: - u.append("%s" % (f.name.capitalize())) - else: - raise NotImplementedError("Cannot handle KeyedUnion fields which are not Structs") - - s += " | ".join(u) + "\n" - ty.union_name = name - - union_type = "?%s:%s" % (munge_name(nparent), ty.keyvar.type.rawname) - - if s == "": - return None, None - return s.replace("\n", "\n%s" % indent), union_type - -def gen_ocaml_anonstruct(ty, interface, indent, parent = None): - s= "" - - if ty.rawname is not None: - # Non-anonymous types need no special handling - pass - elif isinstance(ty, idl.Struct): - name = "%s__anon" % parent - s += "type %s = {\n" % name - s += gen_struct(ty, indent) - s += "}\n" - ty.anon_struct = name - if s == "": - return None - s = indent + s - return s.replace("\n", "\n%s" % indent) - -def gen_ocaml_ml(ty, interface, indent=""): - - if interface: - s = ("""(* %s interface *)\n""" % ty.typename) - else: - s = ("""(* %s implementation *)\n""" % ty.typename) - - if isinstance(ty, idl.Enumeration): - s += "type %s = \n" % ty.rawname - for v in ty.values: - s += "\t | %s\n" % v.rawname - - if interface: - s += "\nval string_of_%s : %s -> string\n" % (ty.rawname, ty.rawname) - else: - s += "\nlet string_of_%s = function\n" % ty.rawname - for v in ty.values: - s += '\t| %s -> "%s"\n' % (v.rawname, v.valuename) - - elif isinstance(ty, idl.Aggregate): - s += "" - - if ty.typename is None: - raise NotImplementedError("%s has no typename" % type(ty)) - else: - - module_name = ty.rawname[0].upper() + ty.rawname[1:] - - if interface: - s += "module %s : sig\n" % module_name - else: - s += "module %s = struct\n" % module_name - - # Handle KeyedUnions... - union_types = [] - for f in ty.fields: - ku, union_type = gen_ocaml_keyedunions(f.type, interface, "\t") - if ku is not None: - s += ku - s += "\n" - if union_type is not None: - union_types.append(union_type) - - # Handle anonymous structs... - for f in ty.fields: - anon = gen_ocaml_anonstruct(f.type, interface, "\t", f.name) - if anon is not None: - s += anon - s += "\n" - - s += "\ttype t =\n" - s += "\t{\n" - s += gen_struct(ty, "\t\t") - s += "\t}\n" - - if ty.init_fn is not None: - union_args = "".join([u + " -> " for u in union_types]) - if interface: - s += "\tval default : ctx -> %sunit -> t\n" % union_args - else: - s += "\texternal default : ctx -> %sunit -> t = \"stub_libxl_%s_init\"\n" % (union_args, ty.rawname) - - if ty.rawname in functions: - for name,args in functions[ty.rawname]: - s += "\texternal %s : " % name - s += " -> ".join(args) - s += " = \"%s\"\n" % stub_fn_name(ty,name) - - s += "end\n" - - else: - raise NotImplementedError("%s" % type(ty)) - return s.replace("\n", "\n%s" % indent) - -def c_val(ty, c, o, indent="", parent = None): - s = indent - if isinstance(ty,idl.UInt): - if ty.width in [8, 16]: - # handle as ints - width = None - elif ty.width in [32, 64]: - width = ty.width - else: - raise NotImplementedError("Cannot handle %d-bit int" % ty.width) - if width: - s += "%s = Int%d_val(%s);" % (c, width, o) - else: - s += "%s = Int_val(%s);" % (c, o) - elif isinstance(ty,idl.Builtin): - if ty.typename not in builtins: - raise NotImplementedError("Unknown Builtin %s (%s)" % (ty.typename, type(ty))) - _,fn,_ = builtins[ty.typename] - if not fn: - raise NotImplementedError("No c_val fn for Builtin %s (%s)" % (ty.typename, type(ty))) - s += "%s;" % (fn % { "o": o, "c": c }) - elif isinstance (ty,idl.Array): - s += "{\n" - s += "\tint i;\n" - s += "\t%s = Wosize_val(%s);\n" % (parent + ty.lenvar.name, o) - s += "\t%s = (%s) calloc(%s, sizeof(*%s));\n" % (c, ty.typename, parent + ty.lenvar.name, c) - s += "\tfor(i=0; i<%s; i++) {\n" % (parent + ty.lenvar.name) - s += c_val(ty.elem_type, c+"[i]", "Field(%s, i)" % o, indent="\t\t", parent=parent) + "\n" - s += "\t}\n" - s += "}\n" - elif isinstance(ty,idl.Enumeration) and (parent is None): - n = 0 - s += "switch(Int_val(%s)) {\n" % o - for e in ty.values: - s += " case %d: *%s = %s; break;\n" % (n, c, e.name) - n += 1 - s += " default: failwith_xl(ERROR_FAIL, \"cannot convert value to %s\"); break;\n" % ty.typename - s += "}" - elif isinstance(ty, idl.KeyedUnion): - s += "{\n" - s += "\tif(Is_long(%s)) {\n" % o - n = 0 - s += "\t\tswitch(Int_val(%s)) {\n" % o - for f in ty.fields: - if f.type is None or not f.type.has_fields(): - s += "\t\t case %d: %s = %s; break;\n" % (n, - parent + ty.keyvar.name, - f.enumname) - n += 1 - s += "\t\t default: failwith_xl(ERROR_FAIL, \"variant handling bug %s%s (long)\"); break;\n" % (parent, ty.keyvar.name) - s += "\t\t}\n" - s += "\t} else {\n" - s += "\t\t/* Is block... */\n" - s += "\t\tswitch(Tag_val(%s)) {\n" % o - n = 0 - for f in ty.fields: - if f.type is not None and f.type.has_fields(): - if f.type.private: - continue - s += "\t\t case %d:\n" % (n) - s += "\t\t %s = %s;\n" % (parent + ty.keyvar.name, f.enumname) - (nparent,fexpr) = ty.member(c, f, False) - s += "%s" % c_val(f.type, fexpr, "Field(%s, 0)" % o, parent=nparent, indent=indent+"\t\t ") - s += "break;\n" - n += 1 - s += "\t\t default: failwith_xl(ERROR_FAIL, \"variant handling bug %s%s (block)\"); break;\n" % (parent, ty.keyvar.name) - s += "\t\t}\n" - s += "\t}\n" - s += "}" - elif isinstance(ty, idl.Aggregate) and (parent is None or ty.rawname is None): - n = 0 - for f in ty.fields: - if f.type.private: - continue - (nparent,fexpr) = ty.member(c, f, ty.rawname is not None) - s += "%s\n" % c_val(f.type, fexpr, "Field(%s, %d)" % (o,n), parent=nparent) - n = n + 1 - else: - s += "%s_val(ctx, %s, %s);" % (ty.rawname, ty.pass_arg(c, parent is None, passby=idl.PASS_BY_REFERENCE), o) - - return s.replace("\n", "\n%s" % indent) - -def gen_c_val(ty, indent=""): - s = "/* Convert caml value to %s */\n" % ty.rawname - - s += "static int %s_val (libxl_ctx *ctx, %s, value v)\n" % (ty.rawname, ty.make_arg("c_val", passby=idl.PASS_BY_REFERENCE)) - s += "{\n" - s += "\tCAMLparam1(v);\n" - s += "\n" - - s += c_val(ty, "c_val", "v", indent="\t") + "\n" - - s += "\tCAMLreturn(0);\n" - s += "}\n" - - return s.replace("\n", "\n%s" % indent) - -def ocaml_Val(ty, o, c, indent="", parent = None): - s = indent - if isinstance(ty,idl.UInt): - if ty.width in [8, 16]: - # handle as ints - width = None - elif ty.width in [32, 64]: - width = ty.width - else: - raise NotImplementedError("Cannot handle %d-bit int" % ty.width) - if width: - s += "%s = caml_copy_int%d(%s);" % (o, width, c) - else: - s += "%s = Val_int(%s);" % (o, c) - elif isinstance(ty,idl.Builtin): - if ty.typename not in builtins: - raise NotImplementedError("Unknown Builtin %s (%s)" % (ty.typename, type(ty))) - _,_,fn = builtins[ty.typename] - if not fn: - raise NotImplementedError("No ocaml Val fn for Builtin %s (%s)" % (ty.typename, type(ty))) - s += "%s = %s;" % (o, fn % { "c": c }) - elif isinstance(ty, idl.Array): - s += "{\n" - s += "\t int i;\n" - s += "\t CAMLlocal1(array_elem);\n" - s += "\t %s = caml_alloc(%s,0);\n" % (o, parent + ty.lenvar.name) - s += "\t for(i=0; i<%s; i++) {\n" % (parent + ty.lenvar.name) - s += "\t %s\n" % ocaml_Val(ty.elem_type, "array_elem", c + "[i]", "", parent=parent) - s += "\t Store_field(%s, i, array_elem);\n" % o - s += "\t }\n" - s += "\t}" - elif isinstance(ty,idl.Enumeration) and (parent is None): - n = 0 - s += "switch(%s) {\n" % c - for e in ty.values: - s += " case %s: %s = Val_int(%d); break;\n" % (e.name, o, n) - n += 1 - s += " default: failwith_xl(ERROR_FAIL, \"cannot convert value from %s\"); break;\n" % ty.typename - s += "}" - elif isinstance(ty, idl.KeyedUnion): - n = 0 - m = 0 - s += "switch(%s) {\n" % (parent + ty.keyvar.name) - for f in ty.fields: - s += "\t case %s:\n" % f.enumname - if f.type is None: - s += "\t /* %d: None */\n" % n - s += "\t %s = Val_long(%d);\n" % (o,n) - n += 1 - elif not f.type.has_fields(): - s += "\t /* %d: Long */\n" % n - s += "\t %s = Val_long(%d);\n" % (o,n) - n += 1 - else: - s += "\t /* %d: Block */\n" % m - (nparent,fexpr) = ty.member(c, f, parent is None) - s += "\t {\n" - s += "\t\t CAMLlocal1(tmp);\n" - s += "\t\t %s = caml_alloc(%d,%d);\n" % (o, 1, m) - s += ocaml_Val(f.type, 'tmp', fexpr, indent="\t\t ", parent=nparent) - s += "\n" - s += "\t\t Store_field(%s, 0, tmp);\n" % o - s += "\t }\n" - m += 1 - #s += "\t %s = caml_alloc(%d,%d);\n" % (o,len(f.type.fields),n) - s += "\t break;\n" - s += "\t default: failwith_xl(ERROR_FAIL, \"cannot convert value from %s\"); break;\n" % ty.typename - s += "\t}" - elif isinstance(ty,idl.Aggregate) and (parent is None or ty.rawname is None): - s += "{\n" - if ty.rawname is None: - fn = "anon_field" - else: - fn = "%s_field" % ty.rawname - s += "\tCAMLlocal1(%s);\n" % fn - s += "\n" - s += "\t%s = caml_alloc_tuple(%d);\n" % (o, len(ty.fields)) - - n = 0 - for f in ty.fields: - if f.type.private: - continue - - (nparent,fexpr) = ty.member(c, f, parent is None) - - s += "\n" - s += "\t%s\n" % ocaml_Val(f.type, fn, ty.pass_arg(fexpr, c), parent=nparent) - s += "\tStore_field(%s, %d, %s);\n" % (o, n, fn) - n = n + 1 - s += "}" - else: - s += "%s = Val_%s(%s);" % (o, ty.rawname, ty.pass_arg(c, parent is None)) - - return s.replace("\n", "\n%s" % indent).rstrip(indent) - -def gen_Val_ocaml(ty, indent=""): - s = "/* Convert %s to a caml value */\n" % ty.rawname - - s += "static value Val_%s (%s)\n" % (ty.rawname, ty.make_arg(ty.rawname+"_c")) - s += "{\n" - s += "\tCAMLparam0();\n" - s += "\tCAMLlocal1(%s_ocaml);\n" % ty.rawname - - s += ocaml_Val(ty, "%s_ocaml" % ty.rawname, "%s_c" % ty.rawname, indent="\t") + "\n" - - s += "\tCAMLreturn(%s_ocaml);\n" % ty.rawname - s += "}\n" - return s.replace("\n", "\n%s" % indent) - -def gen_c_stub_prototype(ty, fns): - s = "/* Stubs for %s */\n" % ty.rawname - for name,args in fns: - # For N args we return one value and take N-1 values as parameters - s += "value %s(" % stub_fn_name(ty, name) - s += ", ".join(["value v%d" % v for v in range(1,len(args))]) - s += ");\n" - return s - -def gen_c_default(ty): - s = "/* Get the defaults for %s */\n" % ty.rawname - # Handle KeyedUnions... - union_types = [] - for f in ty.fields: - if isinstance(f.type, idl.KeyedUnion): - union_types.append(f.type.keyvar) - - s += "value stub_libxl_%s_init(value ctx, %svalue unit)\n" % (ty.rawname, - "".join(["value " + u.name + ", " for u in union_types])) - s += "{\n" - s += "\tCAMLparam%d(ctx, %sunit);\n" % (len(union_types) + 2, "".join([u.name + ", " for u in union_types])) - s += "\tCAMLlocal1(val);\n" - s += "\tlibxl_%s c_val;\n" % ty.rawname - s += "\tlibxl_%s_init(&c_val);\n" % ty.rawname - for u in union_types: - s += "\tif (%s != Val_none) {\n" % u.name - s += "\t\t%s c = 0;\n" % u.type.typename - s += "\t\t%s_val(CTX, &c, Some_val(%s));\n" % (u.type.rawname, u.name) - s += "\t\tlibxl_%s_init_%s(&c_val, c);\n" % (ty.rawname, u.name) - s += "\t}\n" - s += "\tval = Val_%s(&c_val);\n" % ty.rawname - if ty.dispose_fn: - s += "\tlibxl_%s_dispose(&c_val);\n" % ty.rawname - s += "\tCAMLreturn(val);\n" - s += "}\n" - return s - -def gen_c_defaults(ty): - s = gen_c_default(ty) - return s - -def autogen_header(open_comment, close_comment): - s = open_comment + " AUTO-GENERATED FILE DO NOT EDIT " + close_comment + "\n" - s += open_comment + " autogenerated by \n" - s += reduce(lambda x,y: x + " ", range(len(open_comment + " ")), "") - s += "%s" % " ".join(sys.argv) - s += "\n " + close_comment + "\n\n" - return s - -if __name__ == '__main__': - if len(sys.argv) < 4: - print("Usage: genwrap.py ", file=sys.stderr) - sys.exit(1) - - (_,types) = idl.parse(sys.argv[1]) - - # Do not generate these yet. - blacklist = [ - "cpupoolinfo", - "vcpuinfo", - ] - - for t in blacklist: - if t not in [ty.rawname for ty in types]: - print("unknown type %s in blacklist" % t) - - types = [ty for ty in types if not ty.rawname in blacklist] - - _ml = sys.argv[3] - ml = open(_ml, 'w') - ml.write(autogen_header("(*", "*)")) - - _mli = sys.argv[2] - mli = open(_mli, 'w') - mli.write(autogen_header("(*", "*)")) - - _cinc = sys.argv[4] - cinc = open(_cinc, 'w') - cinc.write(autogen_header("/*", "*/")) - - for ty in types: - if ty.private: - continue - #sys.stdout.write(" TYPE %-20s " % ty.rawname) - ml.write(gen_ocaml_ml(ty, False)) - ml.write("\n") - - mli.write(gen_ocaml_ml(ty, True)) - mli.write("\n") - - if ty.marshal_in(): - cinc.write(gen_c_val(ty)) - cinc.write("\n") - cinc.write(gen_Val_ocaml(ty)) - cinc.write("\n") - if ty.rawname in functions: - cinc.write(gen_c_stub_prototype(ty, functions[ty.rawname])) - cinc.write("\n") - if ty.init_fn is not None: - cinc.write(gen_c_defaults(ty)) - cinc.write("\n") - #sys.stdout.write("\n") - - ml.write("(* END OF AUTO-GENERATED CODE *)\n") - ml.close() - mli.write("(* END OF AUTO-GENERATED CODE *)\n") - mli.close() - cinc.close() diff --git a/tools/ocaml/libs/xl/xenlight.ml.in b/tools/ocaml/libs/xl/xenlight.ml.in deleted file mode 100644 index 6989bb6638cd..000000000000 --- a/tools/ocaml/libs/xl/xenlight.ml.in +++ /dev/null @@ -1,94 +0,0 @@ -(* - * Copyright (C) 2009-2011 Citrix Ltd. - * Author Vincent Hanquez - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - *) - -type ctx -type domid = int -type devid = int - -(* @@LIBXL_TYPES@@ *) - -exception Error of (error * string) - -external ctx_alloc: Xentoollog.handle -> ctx = "stub_libxl_ctx_alloc" - -external test_raise_exception: unit -> unit = "stub_raise_exception" - -type event = - | POLLIN (* There is data to read *) - | POLLPRI (* There is urgent data to read *) - | POLLOUT (* Writing now will not block *) - | POLLERR (* Error condition (revents only) *) - | POLLHUP (* Device has been disconnected (revents only) *) - | POLLNVAL (* Invalid request: fd not open (revents only). *) - -module Domain = struct - external create_new : ctx -> Domain_config.t -> ?async:'a -> unit -> domid = "stub_libxl_domain_create_new" - external create_restore : ctx -> Domain_config.t -> (Unix.file_descr * Domain_restore_params.t) -> - ?async:'a -> unit -> domid = "stub_libxl_domain_create_restore" - external shutdown : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_shutdown" - external reboot : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_reboot" - external destroy : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_destroy" - external suspend : ctx -> domid -> Unix.file_descr -> ?async:'a -> unit -> unit = "stub_libxl_domain_suspend" - external pause : ctx -> domid -> ?async:'a -> unit = "stub_libxl_domain_pause" - external unpause : ctx -> domid -> ?async:'a -> unit = "stub_libxl_domain_unpause" - - external send_trigger : ctx -> domid -> trigger -> int -> ?async:'a -> unit = "stub_xl_send_trigger" - external send_sysrq : ctx -> domid -> char -> unit = "stub_xl_send_sysrq" -end - -module Host = struct - type console_reader - exception End_of_file - - external xen_console_read_start : ctx -> int -> console_reader = "stub_libxl_xen_console_read_start" - external xen_console_read_line : ctx -> console_reader -> string = "stub_libxl_xen_console_read_line" - external xen_console_read_finish : ctx -> console_reader -> unit = "stub_libxl_xen_console_read_finish" - - external send_debug_keys : ctx -> string -> unit = "stub_xl_send_debug_keys" -end - -module Async = struct - type for_libxl - type event_hooks - type osevent_hooks - - external osevent_register_hooks' : ctx -> 'a -> osevent_hooks = "stub_libxl_osevent_register_hooks" - external osevent_occurred_fd : ctx -> for_libxl -> Unix.file_descr -> event list -> event list -> unit = "stub_libxl_osevent_occurred_fd" - external osevent_occurred_timeout : ctx -> for_libxl -> unit = "stub_libxl_osevent_occurred_timeout" - - let osevent_register_hooks ctx ~user ~fd_register ~fd_modify ~fd_deregister ~timeout_register ~timeout_fire_now = - Callback.register "libxl_fd_register" fd_register; - Callback.register "libxl_fd_modify" fd_modify; - Callback.register "libxl_fd_deregister" fd_deregister; - Callback.register "libxl_timeout_register" timeout_register; - Callback.register "libxl_timeout_fire_now" timeout_fire_now; - osevent_register_hooks' ctx user - - let async_register_callback ~async_callback = - Callback.register "libxl_async_callback" async_callback - - external evenable_domain_death : ctx -> domid -> int -> unit = "stub_libxl_evenable_domain_death" - external event_register_callbacks' : ctx -> 'a -> event_hooks = "stub_libxl_event_register_callbacks" - - let event_register_callbacks ctx ~user ~event_occurs_callback ~event_disaster_callback = - Callback.register "libxl_event_occurs_callback" event_occurs_callback; - Callback.register "libxl_event_disaster_callback" event_disaster_callback; - event_register_callbacks' ctx user -end - -let register_exceptions () = - Callback.register_exception "Xenlight.Error" (Error(ERROR_FAIL, "")); - Callback.register_exception "Xenlight.Host.End_of_file" (Host.End_of_file) - diff --git a/tools/ocaml/libs/xl/xenlight.mli.in b/tools/ocaml/libs/xl/xenlight.mli.in deleted file mode 100644 index b98a3db7e777..000000000000 --- a/tools/ocaml/libs/xl/xenlight.mli.in +++ /dev/null @@ -1,93 +0,0 @@ -(* - * Copyright (C) 2009-2011 Citrix Ltd. - * Author Vincent Hanquez - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - *) - -type ctx -type domid = int -type devid = int - -(* @@LIBXL_TYPES@@ *) - -exception Error of (error * string) - -val register_exceptions: unit -> unit - -external ctx_alloc: Xentoollog.handle -> ctx = "stub_libxl_ctx_alloc" - -external test_raise_exception: unit -> unit = "stub_raise_exception" - -type event = - | POLLIN (* There is data to read *) - | POLLPRI (* There is urgent data to read *) - | POLLOUT (* Writing now will not block *) - | POLLERR (* Error condition (revents only) *) - | POLLHUP (* Device has been disconnected (revents only) *) - | POLLNVAL (* Invalid request: fd not open (revents only). *) - -module Domain : sig - external create_new : ctx -> Domain_config.t -> ?async:'a -> unit -> domid = "stub_libxl_domain_create_new" - external create_restore : ctx -> Domain_config.t -> (Unix.file_descr * Domain_restore_params.t) -> - ?async:'a -> unit -> domid = "stub_libxl_domain_create_restore" - external shutdown : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_shutdown" - external reboot : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_reboot" - external destroy : ctx -> domid -> ?async:'a -> unit -> unit = "stub_libxl_domain_destroy" - external suspend : ctx -> domid -> Unix.file_descr -> ?async:'a -> unit -> unit = "stub_libxl_domain_suspend" - external pause : ctx -> domid -> ?async:'a -> unit = "stub_libxl_domain_pause" - external unpause : ctx -> domid -> ?async:'a -> unit = "stub_libxl_domain_unpause" - - external send_trigger : ctx -> domid -> trigger -> int -> ?async:'a -> unit = "stub_xl_send_trigger" - external send_sysrq : ctx -> domid -> char -> unit = "stub_xl_send_sysrq" -end - -module Host : sig - type console_reader - exception End_of_file - - external xen_console_read_start : ctx -> int -> console_reader = "stub_libxl_xen_console_read_start" - external xen_console_read_line : ctx -> console_reader -> string = "stub_libxl_xen_console_read_line" - external xen_console_read_finish : ctx -> console_reader -> unit = "stub_libxl_xen_console_read_finish" - - external send_debug_keys : ctx -> string -> unit = "stub_xl_send_debug_keys" -end - -module Async : sig - type for_libxl - type event_hooks - type osevent_hooks - - val osevent_register_hooks : ctx -> - user:'a -> - fd_register:('a -> Unix.file_descr -> event list -> for_libxl -> 'b) -> - fd_modify:('a -> Unix.file_descr -> 'b -> event list -> 'b) -> - fd_deregister:('a -> Unix.file_descr -> 'b -> unit) -> - timeout_register:('a -> int64 -> int64 -> for_libxl -> 'c) -> - timeout_fire_now:('a -> 'c -> 'c) -> - osevent_hooks - - external osevent_occurred_fd : ctx -> for_libxl -> Unix.file_descr -> event list -> event list -> unit = "stub_libxl_osevent_occurred_fd" - external osevent_occurred_timeout : ctx -> for_libxl -> unit = "stub_libxl_osevent_occurred_timeout" - - val async_register_callback : - async_callback:(result:error option -> user:'a -> unit) -> - unit - - external evenable_domain_death : ctx -> domid -> int -> unit = "stub_libxl_evenable_domain_death" - - val event_register_callbacks : ctx -> - user:'a -> - event_occurs_callback:('a -> Event.t -> unit) -> - event_disaster_callback:('a -> event_type -> string -> int -> unit) -> - event_hooks -end - diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c b/tools/ocaml/libs/xl/xenlight_stubs.c deleted file mode 100644 index 45b8af61c74a..000000000000 --- a/tools/ocaml/libs/xl/xenlight_stubs.c +++ /dev/null @@ -1,1663 +0,0 @@ -/* - * Copyright (C) 2009-2011 Citrix Ltd. - * Author Vincent Hanquez - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - */ - -#include - -#define CAML_NAME_SPACE -#include -#include -#include -#include -#include -#include - -#include -#include -#include - -#include -#include - -#include -#include - -#include "caml_xentoollog.h" - -/* - * Starting with ocaml-3.09.3, CAMLreturn can only be used for ``value'' - * types. CAMLreturnT was only added in 3.09.4, so we define our own - * version here if needed. - */ -#ifndef CAMLreturnT -#define CAMLreturnT(type, result) do { \ - type caml__temp_result = (result); \ - caml_local_roots = caml__frame; \ - return (caml__temp_result); \ -} while (0) -#endif - -/* The following is equal to the CAMLreturn macro, but without the return */ -#define CAMLdone do{ \ -caml_local_roots = caml__frame; \ -}while (0) - -#define Ctx_val(x)(*((libxl_ctx **) Data_custom_val(x))) -#define CTX ((libxl_ctx *) Ctx_val(ctx)) - -static char * dup_String_val(value s) -{ - int len; - char *c; - len = caml_string_length(s); - c = calloc(len + 1, sizeof(char)); - if (!c) - caml_raise_out_of_memory(); - memcpy(c, String_val(s), len); - return c; -} - -/* Forward reference: this is defined in the auto-generated include file below. */ -static value Val_error (libxl_error error_c); - -static void failwith_xl(int error, char *fname) -{ - CAMLparam0(); - CAMLlocal1(arg); - static const value *exc = NULL; - - /* First time around, lookup by name */ - if (!exc) - exc = caml_named_value("Xenlight.Error"); - - if (!exc) - caml_invalid_argument("Exception Xenlight.Error not initialized, please link xenlight.cma"); - - arg = caml_alloc(2, 0); - - Store_field(arg, 0, Val_error(error)); - Store_field(arg, 1, caml_copy_string(fname)); - - caml_raise_with_arg(*exc, arg); - CAMLreturn0; -} - -CAMLprim value stub_raise_exception(value unit) -{ - CAMLparam1(unit); - failwith_xl(ERROR_FAIL, "test exception"); - CAMLreturn(Val_unit); -} - -void ctx_finalize(value ctx) -{ - libxl_ctx_free(CTX); -} - -static struct custom_operations libxl_ctx_custom_operations = { - "libxl_ctx_custom_operations", - ctx_finalize /* custom_finalize_default */, - custom_compare_default, - custom_hash_default, - custom_serialize_default, - custom_deserialize_default -}; - -CAMLprim value stub_libxl_ctx_alloc(value logger) -{ - CAMLparam1(logger); - CAMLlocal1(handle); - libxl_ctx *ctx; - int ret; - - ret = libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, (xentoollog_logger *) Xtl_val(logger)); - if (ret != 0) \ - failwith_xl(ERROR_FAIL, "cannot init context"); - - handle = caml_alloc_custom(&libxl_ctx_custom_operations, sizeof(ctx), 0, 1); - Ctx_val(handle) = ctx; - - CAMLreturn(handle); -} - -static int list_len(value v) -{ - int len = 0; - while ( v != Val_emptylist ) { - len++; - v = Field(v, 1); - } - return len; -} - -static int libxl_key_value_list_val(libxl_key_value_list *c_val, - value v) -{ - CAMLparam1(v); - CAMLlocal1(elem); - int nr, i; - libxl_key_value_list array; - - nr = list_len(v); - - array = calloc((nr + 1) * 2, sizeof(char *)); - if (!array) - caml_raise_out_of_memory(); - - for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) { - elem = Field(v, 0); - - array[i * 2] = dup_String_val(Field(elem, 0)); - array[i * 2 + 1] = dup_String_val(Field(elem, 1)); - } - - *c_val = array; - CAMLreturn(0); -} - -static value Val_key_value_list(libxl_key_value_list *c_val) -{ - CAMLparam0(); - CAMLlocal5(list, cons, key, val, kv); - int i; - - list = Val_emptylist; - for (i = libxl_string_list_length((libxl_string_list *) c_val) - 1; i >= 0; i -= 2) { - val = caml_copy_string((*c_val)[i]); - key = caml_copy_string((*c_val)[i - 1]); - kv = caml_alloc_tuple(2); - Store_field(kv, 0, key); - Store_field(kv, 1, val); - - cons = caml_alloc(2, 0); - Store_field(cons, 0, kv); // head - Store_field(cons, 1, list); // tail - list = cons; - } - - CAMLreturn(list); -} - -static int libxl_string_list_val(libxl_string_list *c_val, value v) -{ - CAMLparam1(v); - int nr, i; - libxl_string_list array; - - nr = list_len(v); - - array = calloc(nr + 1, sizeof(char *)); - if (!array) - caml_raise_out_of_memory(); - - for (i=0; v != Val_emptylist; i++, v = Field(v, 1) ) - array[i] = dup_String_val(Field(v, 0)); - - *c_val = array; - CAMLreturn(0); -} - -static value Val_string_list(libxl_string_list *c_val) -{ - CAMLparam0(); - CAMLlocal3(list, cons, string); - int i; - - list = Val_emptylist; - for (i = libxl_string_list_length(c_val) - 1; i >= 0; i--) { - string = caml_copy_string((*c_val)[i]); - cons = caml_alloc(2, 0); - Store_field(cons, 0, string); // head - Store_field(cons, 1, list); // tail - list = cons; - } - - CAMLreturn(list); -} - -/* Option type support as per http://www.linux-nantes.org/~fmonnier/ocaml/ocaml-wrapping-c.php */ -#ifndef Val_none -#define Val_none Val_int(0) -#endif -#ifndef Some_val -#define Some_val(v) Field(v,0) -#endif - -static value Val_some(value v) -{ - CAMLparam1(v); - CAMLlocal1(some); - some = caml_alloc(1, 0); - Store_field(some, 0, v); - CAMLreturn(some); -} - -static value Val_mac (libxl_mac *c_val) -{ - CAMLparam0(); - CAMLlocal1(v); - int i; - - v = caml_alloc_tuple(6); - - for(i=0; i<6; i++) - Store_field(v, i, Val_int((*c_val)[i])); - - CAMLreturn(v); -} - -static int Mac_val(libxl_mac *c_val, value v) -{ - CAMLparam1(v); - int i; - - for(i=0; i<6; i++) - (*c_val)[i] = Int_val(Field(v, i)); - - CAMLreturn(0); -} - -static value Val_bitmap (libxl_bitmap *c_val) -{ - CAMLparam0(); - CAMLlocal1(v); - int i; - - if (c_val->size == 0) - v = Atom(0); - else { - v = caml_alloc(8 * (c_val->size), 0); - libxl_for_each_bit(i, *c_val) { - if (libxl_bitmap_test(c_val, i)) - Store_field(v, i, Val_true); - else - Store_field(v, i, Val_false); - } - } - CAMLreturn(v); -} - -static int Bitmap_val(libxl_ctx *ctx, libxl_bitmap *c_val, value v) -{ - CAMLparam1(v); - int i, len = Wosize_val(v); - - c_val->size = 0; - if (len > 0 && libxl_bitmap_alloc(ctx, c_val, len)) - failwith_xl(ERROR_NOMEM, "cannot allocate bitmap"); - for (i=0; ibytes[i])); - - CAMLreturn(v); -} - -static int Ms_vm_genid_val(libxl_ms_vm_genid *c_val, value v) -{ - CAMLparam1(v); - int i; - - for(i=0; ibytes[i] = Int_val(Field(v, i)); - - CAMLreturn(0); -} - -static value Val_string_option(const char *c_val) -{ - CAMLparam0(); - CAMLlocal2(tmp1, tmp2); - if (c_val) { - tmp1 = caml_copy_string(c_val); - tmp2 = Val_some(tmp1); - CAMLreturn(tmp2); - } - else - CAMLreturn(Val_none); -} - -static char *String_option_val(value v) -{ - CAMLparam1(v); - char *s = NULL; - if (v != Val_none) - s = dup_String_val(Some_val(v)); - CAMLreturnT(char *, s); -} - -#include "_libxl_types.inc" - -void async_callback(libxl_ctx *ctx, int rc, void *for_callback) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal2(error, tmp); - static const value *func = NULL; - value *p = (value *) for_callback; - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_async_callback"); - } - - if (rc == 0) - error = Val_none; - else { - tmp = Val_error(rc); - error = Val_some(tmp); - } - - /* for_callback is a pointer to a "value" that was malloc'ed and - * registered with the OCaml GC. The value is handed back to OCaml - * in the following callback, after which the pointer is unregistered - * and freed. */ - caml_callback2(*func, error, *p); - - caml_remove_global_root(p); - free(p); - - CAMLdone; - caml_enter_blocking_section(); -} - -static libxl_asyncop_how *aohow_val(value async) -{ - CAMLparam1(async); - libxl_asyncop_how *ao_how = NULL; - value *p; - - if (async != Val_none) { - /* for_callback must be a pointer to a "value" that is malloc'ed and - * registered with the OCaml GC. This ensures that the GC does not remove - * the corresponding OCaml heap blocks, and allows the GC to update the value - * when blocks are moved around, while libxl is free to copy the pointer if - * it needs to. - * The for_callback pointer must always be non-NULL. */ - p = malloc(sizeof(value)); - if (!p) - failwith_xl(ERROR_NOMEM, "cannot allocate value"); - *p = Some_val(async); - caml_register_global_root(p); - ao_how = malloc(sizeof(*ao_how)); - ao_how->callback = async_callback; - ao_how->u.for_callback = (void *) p; - } - - CAMLreturnT(libxl_asyncop_how *, ao_how); -} - -value stub_libxl_domain_create_new(value ctx, value domain_config, value async, value unit) -{ - CAMLparam4(ctx, async, domain_config, unit); - int ret; - libxl_domain_config c_dconfig; - uint32_t c_domid; - libxl_asyncop_how *ao_how; - - libxl_domain_config_init(&c_dconfig); - ret = domain_config_val(CTX, &c_dconfig, domain_config); - if (ret != 0) { - libxl_domain_config_dispose(&c_dconfig); - failwith_xl(ret, "domain_create_new"); - } - - ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_create_new(CTX, &c_dconfig, &c_domid, ao_how, NULL); - caml_leave_blocking_section(); - - free(ao_how); - libxl_domain_config_dispose(&c_dconfig); - - if (ret != 0) - failwith_xl(ret, "domain_create_new"); - - CAMLreturn(Val_int(c_domid)); -} - -value stub_libxl_domain_create_restore(value ctx, value domain_config, value params, - value async, value unit) -{ - CAMLparam5(ctx, domain_config, params, async, unit); - int ret; - libxl_domain_config c_dconfig; - libxl_domain_restore_params c_params; - uint32_t c_domid; - libxl_asyncop_how *ao_how; - int restore_fd; - - libxl_domain_config_init(&c_dconfig); - ret = domain_config_val(CTX, &c_dconfig, domain_config); - if (ret != 0) { - libxl_domain_config_dispose(&c_dconfig); - failwith_xl(ret, "domain_create_restore"); - } - - libxl_domain_restore_params_init(&c_params); - ret = domain_restore_params_val(CTX, &c_params, Field(params, 1)); - if (ret != 0) { - libxl_domain_restore_params_dispose(&c_params); - failwith_xl(ret, "domain_create_restore"); - } - - ao_how = aohow_val(async); - restore_fd = Int_val(Field(params, 0)); - - caml_enter_blocking_section(); - ret = libxl_domain_create_restore(CTX, &c_dconfig, &c_domid, restore_fd, - -1, &c_params, ao_how, NULL); - caml_leave_blocking_section(); - - free(ao_how); - libxl_domain_config_dispose(&c_dconfig); - libxl_domain_restore_params_dispose(&c_params); - - if (ret != 0) - failwith_xl(ret, "domain_create_restore"); - - CAMLreturn(Val_int(c_domid)); -} - -value stub_libxl_domain_shutdown(value ctx, value domid, value async, value unit) -{ - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_shutdown(CTX, c_domid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_shutdown"); - - CAMLreturn(Val_unit); -} - -value stub_libxl_domain_reboot(value ctx, value domid, value async, value unit) -{ - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_reboot(CTX, c_domid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_reboot"); - - CAMLreturn(Val_unit); -} - -value stub_libxl_domain_destroy(value ctx, value domid, value async, value unit) -{ - CAMLparam4(ctx, domid, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_destroy(CTX, c_domid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_destroy"); - - CAMLreturn(Val_unit); -} - -value stub_libxl_domain_suspend(value ctx, value domid, value fd, value async, value unit) -{ - CAMLparam5(ctx, domid, fd, async, unit); - int ret; - uint32_t c_domid = Int_val(domid); - int c_fd = Int_val(fd); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_suspend(CTX, c_domid, c_fd, 0, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_suspend"); - - CAMLreturn(Val_unit); -} - -value stub_libxl_domain_pause(value ctx, value domid, value async) -{ - CAMLparam3(ctx, domid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_pause(CTX, c_domid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_pause"); - - CAMLreturn(Val_unit); -} - -value stub_libxl_domain_unpause(value ctx, value domid, value async) -{ - CAMLparam3(ctx, domid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_asyncop_how *ao_how = aohow_val(async); - - caml_enter_blocking_section(); - ret = libxl_domain_unpause(CTX, c_domid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "domain_unpause"); - - CAMLreturn(Val_unit); -} - -#define _STRINGIFY(x) #x -#define STRINGIFY(x) _STRINGIFY(x) - -#define _DEVICE_ADDREMOVE(type,fn,op) \ -value stub_xl_device_##type##_##op(value ctx, value info, value domid, \ - value async, value unit) \ -{ \ - CAMLparam5(ctx, info, domid, async, unit); \ - libxl_device_##type c_info; \ - int ret, marker_var; \ - uint32_t c_domid = Int_val(domid); \ - libxl_asyncop_how *ao_how = aohow_val(async); \ - \ - device_##type##_val(CTX, &c_info, info); \ - \ - caml_enter_blocking_section(); \ - ret = libxl_##fn##_##op(CTX, c_domid, &c_info, ao_how); \ - caml_leave_blocking_section(); \ - \ - free(ao_how); \ - libxl_device_##type##_dispose(&c_info); \ - \ - if (ret != 0) \ - failwith_xl(ret, STRINGIFY(type) "_" STRINGIFY(op)); \ - \ - CAMLreturn(Val_unit); \ -} - -#define DEVICE_ADDREMOVE(type) \ - _DEVICE_ADDREMOVE(type, device_##type, add) \ - _DEVICE_ADDREMOVE(type, device_##type, remove) \ - _DEVICE_ADDREMOVE(type, device_##type, destroy) - -DEVICE_ADDREMOVE(disk) -DEVICE_ADDREMOVE(nic) -DEVICE_ADDREMOVE(vfb) -DEVICE_ADDREMOVE(vkb) -DEVICE_ADDREMOVE(pci) -_DEVICE_ADDREMOVE(disk, cdrom, insert) - -value stub_xl_device_nic_of_devid(value ctx, value domid, value devid) -{ - CAMLparam3(ctx, domid, devid); - CAMLlocal1(nic); - libxl_device_nic c_nic; - uint32_t c_domid = Int_val(domid); - int c_devid = Int_val(devid); - - caml_enter_blocking_section(); - libxl_devid_to_device_nic(CTX, c_domid, c_devid, &c_nic); - caml_leave_blocking_section(); - - nic = Val_device_nic(&c_nic); - libxl_device_nic_dispose(&c_nic); - - CAMLreturn(nic); -} - -value stub_xl_device_nic_list(value ctx, value domid) -{ - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_nic *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); - - caml_enter_blocking_section(); - c_list = libxl_device_nic_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); - - if (!c_list) - failwith_xl(ERROR_FAIL, "nic_list"); - - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_nic(&c_list[i])); - } - libxl_device_nic_list_free(c_list, nb); - - CAMLreturn(list); -} - -value stub_xl_device_disk_list(value ctx, value domid) -{ - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_disk *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); - - caml_enter_blocking_section(); - c_list = libxl_device_disk_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); - - if (!c_list) - failwith_xl(ERROR_FAIL, "disk_list"); - - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_disk(&c_list[i])); - } - libxl_device_disk_list_free(c_list, nb); - - CAMLreturn(list); -} - -value stub_xl_device_disk_of_vdev(value ctx, value domid, value vdev) -{ - CAMLparam3(ctx, domid, vdev); - CAMLlocal1(disk); - libxl_device_disk c_disk; - char *c_vdev; - uint32_t c_domid = Int_val(domid); - - c_vdev = strdup(String_val(vdev)); - - caml_enter_blocking_section(); - libxl_vdev_to_device_disk(CTX, c_domid, c_vdev, &c_disk); - caml_leave_blocking_section(); - - disk = Val_device_disk(&c_disk); - libxl_device_disk_dispose(&c_disk); - free(c_vdev); - - CAMLreturn(disk); -} - -value stub_xl_device_pci_list(value ctx, value domid) -{ - CAMLparam2(ctx, domid); - CAMLlocal2(list, temp); - libxl_device_pci *c_list; - int i, nb; - uint32_t c_domid = Int_val(domid); - - caml_enter_blocking_section(); - c_list = libxl_device_pci_list(CTX, c_domid, &nb); - caml_leave_blocking_section(); - - if (!c_list) - failwith_xl(ERROR_FAIL, "pci_list"); - - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_pci(&c_list[i])); - libxl_device_pci_dispose(&c_list[i]); - } - free(c_list); - - CAMLreturn(list); -} - -value stub_xl_device_pci_assignable_add(value ctx, value info, value rebind) -{ - CAMLparam3(ctx, info, rebind); - libxl_device_pci c_info; - int ret, marker_var; - int c_rebind = (int) Bool_val(rebind); - - device_pci_val(CTX, &c_info, info); - - caml_enter_blocking_section(); - ret = libxl_device_pci_assignable_add(CTX, &c_info, c_rebind); - caml_leave_blocking_section(); - - libxl_device_pci_dispose(&c_info); - - if (ret != 0) - failwith_xl(ret, "pci_assignable_add"); - - CAMLreturn(Val_unit); -} - -value stub_xl_device_pci_assignable_remove(value ctx, value info, value rebind) -{ - CAMLparam3(ctx, info, rebind); - libxl_device_pci c_info; - int ret, marker_var; - int c_rebind = (int) Bool_val(rebind); - - device_pci_val(CTX, &c_info, info); - - caml_enter_blocking_section(); - ret = libxl_device_pci_assignable_remove(CTX, &c_info, c_rebind); - caml_leave_blocking_section(); - - libxl_device_pci_dispose(&c_info); - - if (ret != 0) - failwith_xl(ret, "pci_assignable_remove"); - - CAMLreturn(Val_unit); -} - -value stub_xl_device_pci_assignable_list(value ctx) -{ - CAMLparam1(ctx); - CAMLlocal2(list, temp); - libxl_device_pci *c_list; - int i, nb; - uint32_t c_domid; - - caml_enter_blocking_section(); - c_list = libxl_device_pci_assignable_list(CTX, &nb); - caml_leave_blocking_section(); - - if (!c_list) - failwith_xl(ERROR_FAIL, "pci_assignable_list"); - - list = temp = Val_emptylist; - for (i = 0; i < nb; i++) { - list = caml_alloc_small(2, Tag_cons); - Field(list, 0) = Val_int(0); - Field(list, 1) = temp; - temp = list; - Store_field(list, 0, Val_device_pci(&c_list[i])); - } - libxl_device_pci_assignable_list_free(c_list, nb); - - CAMLreturn(list); -} - -value stub_xl_physinfo_get(value ctx) -{ - CAMLparam1(ctx); - CAMLlocal1(physinfo); - libxl_physinfo c_physinfo; - int ret; - - caml_enter_blocking_section(); - ret = libxl_get_physinfo(CTX, &c_physinfo); - caml_leave_blocking_section(); - - if (ret != 0) - failwith_xl(ret, "get_physinfo"); - - physinfo = Val_physinfo(&c_physinfo); - - libxl_physinfo_dispose(&c_physinfo); - - CAMLreturn(physinfo); -} - -value stub_xl_cputopology_get(value ctx) -{ - CAMLparam1(ctx); - CAMLlocal3(topology, v, v0); - libxl_cputopology *c_topology; - int i, nr; - - caml_enter_blocking_section(); - c_topology = libxl_get_cpu_topology(CTX, &nr); - caml_leave_blocking_section(); - - if (!c_topology) - failwith_xl(ERROR_FAIL, "get_cpu_topologyinfo"); - - topology = caml_alloc_tuple(nr); - for (i = 0; i < nr; i++) { - if (c_topology[i].core != LIBXL_CPUTOPOLOGY_INVALID_ENTRY) { - v0 = Val_cputopology(&c_topology[i]); - v = Val_some(v0); - } - else - v = Val_none; - Store_field(topology, i, v); - } - - libxl_cputopology_list_free(c_topology, nr); - - CAMLreturn(topology); -} - -value stub_xl_dominfo_list(value ctx) -{ - CAMLparam1(ctx); - CAMLlocal2(domlist, temp); - libxl_dominfo *c_domlist; - int i, nb; - - caml_enter_blocking_section(); - c_domlist = libxl_list_domain(CTX, &nb); - caml_leave_blocking_section(); - - if (!c_domlist) - failwith_xl(ERROR_FAIL, "dominfo_list"); - - domlist = temp = Val_emptylist; - for (i = nb - 1; i >= 0; i--) { - domlist = caml_alloc_small(2, Tag_cons); - Field(domlist, 0) = Val_int(0); - Field(domlist, 1) = temp; - temp = domlist; - - Store_field(domlist, 0, Val_dominfo(&c_domlist[i])); - } - - libxl_dominfo_list_free(c_domlist, nb); - - CAMLreturn(domlist); -} - -value stub_xl_dominfo_get(value ctx, value domid) -{ - CAMLparam2(ctx, domid); - CAMLlocal1(dominfo); - libxl_dominfo c_dominfo; - int ret; - uint32_t c_domid = Int_val(domid); - - caml_enter_blocking_section(); - ret = libxl_domain_info(CTX, &c_dominfo, c_domid); - caml_leave_blocking_section(); - - if (ret != 0) - failwith_xl(ERROR_FAIL, "domain_info"); - dominfo = Val_dominfo(&c_dominfo); - - CAMLreturn(dominfo); -} - -value stub_xl_domain_sched_params_get(value ctx, value domid) -{ - CAMLparam2(ctx, domid); - CAMLlocal1(scinfo); - libxl_domain_sched_params c_scinfo; - int ret; - uint32_t c_domid = Int_val(domid); - - caml_enter_blocking_section(); - ret = libxl_domain_sched_params_get(CTX, c_domid, &c_scinfo); - caml_leave_blocking_section(); - - if (ret != 0) - failwith_xl(ret, "domain_sched_params_get"); - - scinfo = Val_domain_sched_params(&c_scinfo); - - libxl_domain_sched_params_dispose(&c_scinfo); - - CAMLreturn(scinfo); -} - -value stub_xl_domain_sched_params_set(value ctx, value domid, value scinfo) -{ - CAMLparam3(ctx, domid, scinfo); - libxl_domain_sched_params c_scinfo; - int ret; - uint32_t c_domid = Int_val(domid); - - domain_sched_params_val(CTX, &c_scinfo, scinfo); - - caml_enter_blocking_section(); - ret = libxl_domain_sched_params_set(CTX, c_domid, &c_scinfo); - caml_leave_blocking_section(); - - libxl_domain_sched_params_dispose(&c_scinfo); - - if (ret != 0) - failwith_xl(ret, "domain_sched_params_set"); - - CAMLreturn(Val_unit); -} - -value stub_xl_send_trigger(value ctx, value domid, value trigger, value vcpuid, value async) -{ - CAMLparam5(ctx, domid, trigger, vcpuid, async); - int ret; - uint32_t c_domid = Int_val(domid); - libxl_trigger c_trigger = LIBXL_TRIGGER_UNKNOWN; - int c_vcpuid = Int_val(vcpuid); - libxl_asyncop_how *ao_how = aohow_val(async); - - trigger_val(CTX, &c_trigger, trigger); - - caml_enter_blocking_section(); - ret = libxl_send_trigger(CTX, c_domid, c_trigger, c_vcpuid, ao_how); - caml_leave_blocking_section(); - - free(ao_how); - - if (ret != 0) - failwith_xl(ret, "send_trigger"); - - CAMLreturn(Val_unit); -} - -value stub_xl_send_sysrq(value ctx, value domid, value sysrq) -{ - CAMLparam3(ctx, domid, sysrq); - int ret; - uint32_t c_domid = Int_val(domid); - int c_sysrq = Int_val(sysrq); - - caml_enter_blocking_section(); - ret = libxl_send_sysrq(CTX, c_domid, c_sysrq); - caml_leave_blocking_section(); - - if (ret != 0) - failwith_xl(ret, "send_sysrq"); - - CAMLreturn(Val_unit); -} - -value stub_xl_send_debug_keys(value ctx, value keys) -{ - CAMLparam2(ctx, keys); - int ret; - char *c_keys; - - c_keys = dup_String_val(keys); - - caml_enter_blocking_section(); - ret = libxl_send_debug_keys(CTX, c_keys); - caml_leave_blocking_section(); - - free(c_keys); - - if (ret != 0) - failwith_xl(ret, "send_debug_keys"); - - CAMLreturn(Val_unit); -} - -static struct custom_operations libxl_console_reader_custom_operations = { - "libxl_console_reader_custom_operations", - custom_finalize_default, - custom_compare_default, - custom_hash_default, - custom_serialize_default, - custom_deserialize_default -}; - -#define Console_reader_val(x)(*((libxl_xen_console_reader **) Data_custom_val(x))) - -value stub_libxl_xen_console_read_start(value ctx, value clear) -{ - CAMLparam2(ctx, clear); - CAMLlocal1(handle); - int c_clear = Int_val(clear); - libxl_xen_console_reader *cr; - - caml_enter_blocking_section(); - cr = libxl_xen_console_read_start(CTX, c_clear); - caml_leave_blocking_section(); - - handle = caml_alloc_custom(&libxl_console_reader_custom_operations, sizeof(cr), 0, 1); - Console_reader_val(handle) = cr; - - CAMLreturn(handle); -} - -static void raise_eof(void) -{ - static const value *exc = NULL; - - /* First time around, lookup by name */ - if (!exc) - exc = caml_named_value("Xenlight.Host.End_of_file"); - - if (!exc) - caml_invalid_argument("Exception Xenlight.Host.End_of_file not initialized, please link xenlight.cma"); - - caml_raise_constant(*exc); -} - -value stub_libxl_xen_console_read_line(value ctx, value reader) -{ - CAMLparam2(ctx, reader); - CAMLlocal1(line); - int ret; - char *c_line; - libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); - - caml_enter_blocking_section(); - ret = libxl_xen_console_read_line(CTX, cr, &c_line); - caml_leave_blocking_section(); - - if (ret < 0) - failwith_xl(ret, "xen_console_read_line"); - if (ret == 0) - raise_eof(); - - line = caml_copy_string(c_line); - - CAMLreturn(line); -} - -value stub_libxl_xen_console_read_finish(value ctx, value reader) -{ - CAMLparam2(ctx, reader); - libxl_xen_console_reader *cr = (libxl_xen_console_reader *) Console_reader_val(reader); - - caml_enter_blocking_section(); - libxl_xen_console_read_finish(CTX, cr); - caml_leave_blocking_section(); - - CAMLreturn(Val_unit); -} - -/* Event handling */ - -short Poll_val(value event) -{ - CAMLparam1(event); - short res = -1; - - switch (Int_val(event)) { - case 0: res = POLLIN; break; - case 1: res = POLLPRI; break; - case 2: res = POLLOUT; break; - case 3: res = POLLERR; break; - case 4: res = POLLHUP; break; - case 5: res = POLLNVAL; break; - } - - CAMLreturn(res); -} - -short Poll_events_val(value event_list) -{ - CAMLparam1(event_list); - short events = 0; - - while (event_list != Val_emptylist) { - events |= Poll_val(Field(event_list, 0)); - event_list = Field(event_list, 1); - } - - CAMLreturn(events); -} - -value Val_poll(short event) -{ - CAMLparam0(); - CAMLlocal1(res); - - switch (event) { - case POLLIN: res = Val_int(0); break; - case POLLPRI: res = Val_int(1); break; - case POLLOUT: res = Val_int(2); break; - case POLLERR: res = Val_int(3); break; - case POLLHUP: res = Val_int(4); break; - case POLLNVAL: res = Val_int(5); break; - default: failwith_xl(ERROR_FAIL, "cannot convert poll event value"); break; - } - - CAMLreturn(res); -} - -value add_event(value event_list, short event) -{ - CAMLparam1(event_list); - CAMLlocal1(new_list); - - new_list = caml_alloc(2, 0); - Store_field(new_list, 0, Val_poll(event)); - Store_field(new_list, 1, event_list); - - CAMLreturn(new_list); -} - -value Val_poll_events(short events) -{ - CAMLparam0(); - CAMLlocal1(event_list); - - event_list = Val_emptylist; - if (events & POLLIN) - event_list = add_event(event_list, POLLIN); - if (events & POLLPRI) - event_list = add_event(event_list, POLLPRI); - if (events & POLLOUT) - event_list = add_event(event_list, POLLOUT); - if (events & POLLERR) - event_list = add_event(event_list, POLLERR); - if (events & POLLHUP) - event_list = add_event(event_list, POLLHUP); - if (events & POLLNVAL) - event_list = add_event(event_list, POLLNVAL); - - CAMLreturn(event_list); -} - -/* The process for dealing with the for_app_registration_ values in the - * callbacks below (GC registrations etc) is similar to the way for_callback is - * handled in the asynchronous operations above. */ - -int fd_register(void *user, int fd, void **for_app_registration_out, - short events, void *for_libxl) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - value *for_app; - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_register"); - } - - args[0] = *p; - args[1] = Val_int(fd); - args[2] = Val_poll_events(events); - args[3] = (value) for_libxl; - - for_app = malloc(sizeof(value)); - if (!for_app) { - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } - - *for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(*for_app)) { - ret = ERROR_OSEVENT_REG_FAIL; - free(for_app); - goto err; - } - - caml_register_global_root(for_app); - *for_app_registration_out = for_app; - -err: - CAMLdone; - caml_enter_blocking_section(); - return ret; -} - -int fd_modify(void *user, int fd, void **for_app_registration_update, - short events) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - value *for_app = *for_app_registration_update; - - /* If for_app == NULL, then something is very wrong */ - assert(for_app); - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_modify"); - } - - args[0] = *p; - args[1] = Val_int(fd); - args[2] = *for_app; - args[3] = Val_poll_events(events); - - *for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(*for_app)) { - /* If an exception is caught, *for_app_registration_update is not - * changed. It remains a valid pointer to a value that is registered - * with the GC. */ - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } - - *for_app_registration_update = for_app; - -err: - CAMLdone; - caml_enter_blocking_section(); - return ret; -} - -void fd_deregister(void *user, int fd, void *for_app_registration) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 3); - static const value *func = NULL; - value *p = (value *) user; - value *for_app = for_app_registration; - - /* If for_app == NULL, then something is very wrong */ - assert(for_app); - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_fd_deregister"); - } - - args[0] = *p; - args[1] = Val_int(fd); - args[2] = *for_app; - - caml_callbackN_exn(*func, 3, args); - /* This hook does not return error codes, so the best thing we can do - * to avoid trouble, if we catch an exception from the app, is abort. */ - if (Is_exception_result(*for_app)) - abort(); - - caml_remove_global_root(for_app); - free(for_app); - - CAMLdone; - caml_enter_blocking_section(); -} - -struct timeout_handles { - void *for_libxl; - value for_app; -}; - -int timeout_register(void *user, void **for_app_registration_out, - struct timeval abs, void *for_libxl) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal2(sec, usec); - CAMLlocalN(args, 4); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - struct timeout_handles *handles; - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_timeout_register"); - } - - sec = caml_copy_int64(abs.tv_sec); - usec = caml_copy_int64(abs.tv_usec); - - /* This struct of "handles" will contain "for_libxl" as well as "for_app". - * We'll give a pointer to the struct to the app, and get it back in - * occurred_timeout, where we can clean it all up. */ - handles = malloc(sizeof(*handles)); - if (!handles) { - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } - - handles->for_libxl = for_libxl; - - args[0] = *p; - args[1] = sec; - args[2] = usec; - args[3] = (value) handles; - - handles->for_app = caml_callbackN_exn(*func, 4, args); - if (Is_exception_result(handles->for_app)) { - ret = ERROR_OSEVENT_REG_FAIL; - free(handles); - goto err; - } - - caml_register_global_root(&handles->for_app); - *for_app_registration_out = handles; - -err: - CAMLdone; - caml_enter_blocking_section(); - return ret; -} - -int timeout_modify(void *user, void **for_app_registration_update, - struct timeval abs) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocal1(for_app_update); - CAMLlocalN(args, 2); - int ret = 0; - static const value *func = NULL; - value *p = (value *) user; - struct timeout_handles *handles = *for_app_registration_update; - - /* If for_app == NULL, then something is very wrong */ - assert(handles->for_app); - - /* Libxl currently promises that timeout_modify is only ever called with - * abs={0,0}, meaning "right away". We cannot deal with other values. */ - assert(abs.tv_sec == 0 && abs.tv_usec == 0); - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_timeout_fire_now"); - } - - args[0] = *p; - args[1] = handles->for_app; - - for_app_update = caml_callbackN_exn(*func, 2, args); - if (Is_exception_result(for_app_update)) { - /* If an exception is caught, *for_app_registration_update is not - * changed. It remains a valid pointer to a value that is registered - * with the GC. */ - ret = ERROR_OSEVENT_REG_FAIL; - goto err; - } - - handles->for_app = for_app_update; - -err: - CAMLdone; - caml_enter_blocking_section(); - return ret; -} - -void timeout_deregister(void *user, void *for_app_registration) -{ - /* This hook will never be called by libxl. */ - abort(); -} - -value stub_libxl_osevent_register_hooks(value ctx, value user) -{ - CAMLparam2(ctx, user); - CAMLlocal1(result); - libxl_osevent_hooks *hooks; - value *p; - - hooks = malloc(sizeof(*hooks)); - if (!hooks) - failwith_xl(ERROR_NOMEM, "cannot allocate osevent hooks"); - hooks->fd_register = fd_register; - hooks->fd_modify = fd_modify; - hooks->fd_deregister = fd_deregister; - hooks->timeout_register = timeout_register; - hooks->timeout_modify = timeout_modify; - hooks->timeout_deregister = timeout_deregister; - - p = malloc(sizeof(value)); - if (!p) - failwith_xl(ERROR_NOMEM, "cannot allocate value"); - *p = user; - caml_register_global_root(p); - - caml_enter_blocking_section(); - libxl_osevent_register_hooks(CTX, hooks, (void *) p); - caml_leave_blocking_section(); - - result = caml_alloc(1, Abstract_tag); - *((libxl_osevent_hooks **) result) = hooks; - - CAMLreturn(result); -} - -value stub_libxl_osevent_occurred_fd(value ctx, value for_libxl, value fd, - value events, value revents) -{ - CAMLparam5(ctx, for_libxl, fd, events, revents); - int c_fd = Int_val(fd); - short c_events = Poll_events_val(events); - short c_revents = Poll_events_val(revents); - - caml_enter_blocking_section(); - libxl_osevent_occurred_fd(CTX, (void *) for_libxl, c_fd, c_events, c_revents); - caml_leave_blocking_section(); - - CAMLreturn(Val_unit); -} - -value stub_libxl_osevent_occurred_timeout(value ctx, value handles) -{ - CAMLparam1(ctx); - struct timeout_handles *c_handles = (struct timeout_handles *) handles; - - caml_enter_blocking_section(); - libxl_osevent_occurred_timeout(CTX, (void *) c_handles->for_libxl); - caml_leave_blocking_section(); - - caml_remove_global_root(&c_handles->for_app); - free(c_handles); - - CAMLreturn(Val_unit); -} - -struct user_with_ctx { - libxl_ctx *ctx; - value user; -}; - -void event_occurs(void *user, libxl_event *event) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 2); - struct user_with_ctx *c_user = (struct user_with_ctx *) user; - static const value *func = NULL; - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_event_occurs_callback"); - } - - args[0] = c_user->user; - args[1] = Val_event(event); - libxl_event_free(c_user->ctx, event); - - caml_callbackN(*func, 2, args); - CAMLdone; - caml_enter_blocking_section(); -} - -void disaster(void *user, libxl_event_type type, - const char *msg, int errnoval) -{ - caml_leave_blocking_section(); - CAMLparam0(); - CAMLlocalN(args, 4); - struct user_with_ctx *c_user = (struct user_with_ctx *) user; - static const value *func = NULL; - - if (func == NULL) { - /* First time around, lookup by name */ - func = caml_named_value("libxl_event_disaster_callback"); - } - - args[0] = c_user->user; - args[1] = Val_event_type(type); - args[2] = caml_copy_string(msg); - args[3] = Val_int(errnoval); - - caml_callbackN(*func, 4, args); - CAMLdone; - caml_enter_blocking_section(); -} - -value stub_libxl_event_register_callbacks(value ctx, value user) -{ - CAMLparam2(ctx, user); - CAMLlocal1(result); - struct user_with_ctx *c_user = NULL; - libxl_event_hooks *hooks; - - c_user = malloc(sizeof(*c_user)); - if (!c_user) - failwith_xl(ERROR_NOMEM, "cannot allocate user value"); - c_user->user = user; - c_user->ctx = CTX; - caml_register_global_root(&c_user->user); - - hooks = malloc(sizeof(*hooks)); - if (!hooks) - failwith_xl(ERROR_NOMEM, "cannot allocate event hooks"); - hooks->event_occurs_mask = LIBXL_EVENTMASK_ALL; - hooks->event_occurs = event_occurs; - hooks->disaster = disaster; - - caml_enter_blocking_section(); - libxl_event_register_callbacks(CTX, hooks, (void *) c_user); - caml_leave_blocking_section(); - - result = caml_alloc(1, Abstract_tag); - *((libxl_event_hooks **) result) = hooks; - - CAMLreturn(result); -} - -value stub_libxl_evenable_domain_death(value ctx, value domid, value user) -{ - CAMLparam3(ctx, domid, user); - uint32_t c_domid = Int_val(domid); - int c_user = Int_val(user); - libxl_evgen_domain_death *evgen_out; - - caml_enter_blocking_section(); - libxl_evenable_domain_death(CTX, c_domid, c_user, &evgen_out); - caml_leave_blocking_section(); - - CAMLreturn(Val_unit); -} - -/* - * Local variables: - * indent-tabs-mode: t - * c-basic-offset: 8 - * tab-width: 8 - * End: - */ diff --git a/tools/ocaml/test/Makefile b/tools/ocaml/test/Makefile deleted file mode 100644 index 256c830c512b..000000000000 --- a/tools/ocaml/test/Makefile +++ /dev/null @@ -1,55 +0,0 @@ -XEN_ROOT = $(CURDIR)/../../.. -OCAML_TOPLEVEL = $(CURDIR)/.. -include $(OCAML_TOPLEVEL)/common.make - -CFLAGS += $(APPEND_CFLAGS) - -OCAMLINCLUDE += \ - -I $(OCAML_TOPLEVEL)/libs/xentoollog \ - -I $(OCAML_TOPLEVEL)/libs/xl - -OBJS = xtl send_debug_keys list_domains raise_exception dmesg - -PROGRAMS = xtl send_debug_keys list_domains raise_exception dmesg - -xtl_LIBS = \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xentoollog $(OCAML_TOPLEVEL)/libs/xentoollog/xentoollog.cmxa \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xl $(OCAML_TOPLEVEL)/libs/xl/xenlight.cmxa - -xtl_OBJS = xtl - -send_debug_keys_LIBS = \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xentoollog $(OCAML_TOPLEVEL)/libs/xentoollog/xentoollog.cmxa \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xl $(OCAML_TOPLEVEL)/libs/xl/xenlight.cmxa - -send_debug_keys_OBJS = xtl send_debug_keys - -list_domains_LIBS = \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xentoollog $(OCAML_TOPLEVEL)/libs/xentoollog/xentoollog.cmxa \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xl $(OCAML_TOPLEVEL)/libs/xl/xenlight.cmxa - -list_domains_OBJS = xtl list_domains - -raise_exception_LIBS = \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xentoollog $(OCAML_TOPLEVEL)/libs/xentoollog/xentoollog.cmxa \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xl $(OCAML_TOPLEVEL)/libs/xl/xenlight.cmxa - -raise_exception_OBJS = raise_exception - -dmesg_LIBS = \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xentoollog $(OCAML_TOPLEVEL)/libs/xentoollog/xentoollog.cmxa \ - -ccopt -L -ccopt $(OCAML_TOPLEVEL)/libs/xl $(OCAML_TOPLEVEL)/libs/xl/xenlight.cmxa - -dmesg_OBJS = xtl dmesg - -OCAML_PROGRAM = xtl send_debug_keys list_domains raise_exception dmesg - -all: $(PROGRAMS) - -bins: $(PROGRAMS) - -install: - -uninstall: - -include $(OCAML_TOPLEVEL)/Makefile.rules diff --git a/tools/ocaml/test/dmesg.ml b/tools/ocaml/test/dmesg.ml deleted file mode 100644 index f9efe5dc3066..000000000000 --- a/tools/ocaml/test/dmesg.ml +++ /dev/null @@ -1,17 +0,0 @@ - -let _ = - Xenlight.register_exceptions (); - let logger = Xtl.create_stdio_logger ~level:Xentoollog.Debug () in - let ctx = Xenlight.ctx_alloc logger in - - let open Xenlight.Host in - let reader = xen_console_read_start ctx 0 in - (try - while true do - let line = xen_console_read_line ctx reader in - print_string line - done - with End_of_file -> ()); - let _ = xen_console_read_finish ctx reader in - () - diff --git a/tools/ocaml/test/list_domains.ml b/tools/ocaml/test/list_domains.ml deleted file mode 100644 index 94f1cec05043..000000000000 --- a/tools/ocaml/test/list_domains.ml +++ /dev/null @@ -1,26 +0,0 @@ -open Printf - -let bool_as_char b c = if b then c else '-' - -let print_dominfo dominfo = - let id = dominfo.Xenlight.Dominfo.domid - and running = bool_as_char dominfo.Xenlight.Dominfo.running 'r' - and blocked = bool_as_char dominfo.Xenlight.Dominfo.blocked 'b' - and paused = bool_as_char dominfo.Xenlight.Dominfo.paused 'p' - and shutdown = bool_as_char dominfo.Xenlight.Dominfo.shutdown 's' - and dying = bool_as_char dominfo.Xenlight.Dominfo.dying 'd' - and memory = dominfo.Xenlight.Dominfo.current_memkb - in - printf "Dom %d: %c%c%c%c%c %LdKB\n" id running blocked paused shutdown dying memory - -let _ = - let logger = Xtl.create_stdio_logger (*~level:Xentoollog.Debug*) () in - let ctx = Xenlight.ctx_alloc logger in - try - let domains = Xenlight.Dominfo.list ctx in - List.iter (fun d -> print_dominfo d) domains - with Xenlight.Error(err, fn) -> begin - printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; - end - - diff --git a/tools/ocaml/test/raise_exception.ml b/tools/ocaml/test/raise_exception.ml deleted file mode 100644 index 8c24c3555b58..000000000000 --- a/tools/ocaml/test/raise_exception.ml +++ /dev/null @@ -1,9 +0,0 @@ -open Printf - -let _ = - try - Xenlight.test_raise_exception () - with Xenlight.Error(err, fn) -> begin - printf "Caught Exception: %s: %s\n" (Xenlight.string_of_error err) fn; - end - diff --git a/tools/ocaml/test/send_debug_keys.ml b/tools/ocaml/test/send_debug_keys.ml deleted file mode 100644 index 67b1605dfe20..000000000000 --- a/tools/ocaml/test/send_debug_keys.ml +++ /dev/null @@ -1,13 +0,0 @@ -open Printf - -let send_keys ctx s = - printf "Sending debug key %s\n" s; - Xenlight.Host.send_debug_keys ctx s; - () - -let _ = - let logger = Xtl.create_stdio_logger () in - let ctx = Xenlight.ctx_alloc logger in - Arg.parse [ - ] (fun s -> send_keys ctx s) "usage: send_debug_keys " - diff --git a/tools/ocaml/test/xtl.ml b/tools/ocaml/test/xtl.ml deleted file mode 100644 index 458b11bbaac2..000000000000 --- a/tools/ocaml/test/xtl.ml +++ /dev/null @@ -1,39 +0,0 @@ -open Printf -open Xentoollog - -let stdio_vmessage min_level level errno ctx msg = - let level_str = level_to_string level - and errno_str = match errno with None -> "" | Some s -> sprintf ": errno=%d" s - and ctx_str = match ctx with None -> "" | Some s -> sprintf ": %s" s in - if compare min_level level <= 0 then begin - printf "%s%s%s: %s\n" level_str ctx_str errno_str msg; - flush stdout; - end - -let stdio_progress _ctx what percent dne total = - let nl = if dne = total then "\n" else "" in - printf "\rProgress %s %d%% (%Ld/%Ld)%s" what percent dne total nl; - flush stdout - -let create_stdio_logger ?(level=Info) () = - let cbs = { - vmessage = stdio_vmessage level; - progress = stdio_progress; } in - create "Xentoollog.stdio_logger" cbs - -let do_test level = - let lgr = create_stdio_logger ~level:level () in - begin - test lgr; - end - -let () = - let debug_level = ref Info in - let speclist = [ - ("-v", Arg.Unit (fun () -> debug_level := Debug), "Verbose"); - ("-q", Arg.Unit (fun () -> debug_level := Critical), "Quiet"); - ] in - let usage_msg = "usage: xtl [OPTIONS]" in - Arg.parse speclist (fun _ -> ()) usage_msg; - - do_test !debug_level -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492637.762270 (Exim 4.92) (envelope-from ) id 1pQ96i-0002yu-V9; Thu, 09 Feb 2023 15:45:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492637.762270; Thu, 09 Feb 2023 15:45:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ96i-0002yn-SK; Thu, 09 Feb 2023 15:45:08 +0000 Received: by outflank-mailman (input) for mailman id 492637; Thu, 09 Feb 2023 15:45:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ96h-0002yh-TF for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:45:07 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8987b01-a890-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:45:06 +0100 (CET) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 319FiiHJ066904 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 9 Feb 2023 10:44:50 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 319Fiikv066903; Thu, 9 Feb 2023 07:44:44 -0800 (PST) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8987b01-a890-11ed-933c-83870f6b2ba8 Date: Thu, 9 Feb 2023 07:44:44 -0800 From: Elliott Mitchell To: Jan Beulich Cc: Anthony PERARD , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] tools: Have flex and bison mandatory Message-ID: References: <20230207160948.3169-1-anthony.perard@citrix.com> <7e01f840-1d42-f31e-4471-ee06820b4b31@suse.com> <16bf6ab7-6130-a851-2546-7bea5b64ee57@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16bf6ab7-6130-a851-2546-7bea5b64ee57@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Thu, Feb 09, 2023 at 09:23:43AM +0100, Jan Beulich wrote: > On 08.02.2023 19:51, Elliott Mitchell wrote: > > On Wed, Feb 08, 2023 at 09:02:35AM +0100, Jan Beulich wrote: > >> On 07.02.2023 19:02, Anthony PERARD wrote: > >>> > >>> I think the issue that Andrew saw in the CI with "libxlu_cfg_y.o" > >>> failing to build while "libxlu_cfg_l.[ch]" are been regenerated is > >>> probably because make doesn't consider "libxlu_cfg_l.[ch]" as a group of > >>> targets. > >>> > >>> If for some reason we have: > >>> libxlu_cfg_l.h newer than libxlu_cfg_l.l newer than libxlu_cfg_l.c > >>> > >>> Then make seems to take two parallel decision: > >>> When building libxlu_cfg_y.o: > >>> libxlu_cfg_l.h is newer than libxlu_cfg_l.l > >>> -> libxlu_cfg_l.h is up-to-date, start building libxlu_cfg_y.o > >>> When building libxlu_cfg_l.o: > >>> libxlu_cfg_l.c is older than libxlu_cfg_l.l > >>> -> we need to generate libxlu_cfg_l.c first > >>> Then, libxlu_cfg_y.o fails to build because libxlu_cfg_l.h is been > >>> updated do to the parallel build of libxlu_cfg_l.o. > >>> > >>> I can easily reproduce the issue with: > >>> touch libxlu_cfg_l.c; sleep .1; touch libxlu_cfg_l.l; sleep .1; > >>> touch libxlu_cfg_l.h; sleep .1; make -j > >>> And having "sleep 1" in "%.c %.h: %.l" recipe, between `rm` and `flex`. > >> > >> Interesting. In my somewhat similar experiments I found that an issue > >> exists only when one of the .c files is missing. Things looked to work > >> properly when both were there, but one was outdated. Clearly that's > >> yet more surprising behavior than, as you appear to observe, the issue > >> simply being tied too "needs updating". > > > > The actual problem is flex and bison output both files at the same time. > > One process sees all of its prerequisites are up to do and therefore > > proceeds to the next step. A second process sees an out of date > > prerequisite, and starts to run flex which wipes out the prerequisite of > > the first process. > > > > > > Crucially libxlu_cfg_y.o does NOT depend on libxlu_cfg_l.c, therefore GNU > > Make is allowed to proceed with building libxlu_cfg_y.o even if > > libxlu_cfg_l.c is out of date. > > > > The problem is the rule to update libxlu_cfg_l.c ALSO updates > > libxlu_cfg_l.h as a side-effect. > According to my reading, an order-only prereq isn't what would help > us here: "Occasionally you may want to ensure that a prerequisite is > built before a target, but without forcing the target to be updated > if the prerequisite is updated." This isn't the situation we're > dealing with, I would say. We want the prereq updating to occur and > the building of the dependent target to be deferred until all the > prereqs were updated. You could create a parser which handled all the tokenization itself and only needed the constants for the tokens. The result would need the Lexer header (for the token constants), but not the Lexer itself. In such case case foo_y.o wouldn't need foo_l.c to be rebuilt if foo_l.h was up to date. "libxlu_cfg_y.o" does NOT require "libxlu_cfg_l.c". What "libxlu_cfg_y.o" requires is that IF "libxlu_cfg_l.c" (and thereby "libxlu_cfg_l.h") is rebuilt, it must be rebuilt BEFORE "libxlu_cfg_y.o" is built. "libxlu_cfg_y.o" needs "libxlu_cfg_l.c" to be built before it, but does not itself require "libxlu_cfg_l.c" to be rebuilt. Hopefully this is sounding rather more similar to what GNU Make's manual says? > >>> I don't know how to properly fix this yet. > >>> Event writing "%.c %.h &: %.l" doesn't work, with make 4.3, which is > >>> supposed to be grouped targets. But that's is maybe fixed in 4.4. > >> > >> Well, in my tests while 4.4 has fixed one issue with intermediate files > >> affecting the behavior here, the issue we're possibly running into is > >> still there. I've sent an inquiry to bug-make@gnu.org. > > > > I do not believe this is a bug in GNU Make. Merely double-output rules > > cause precisely this sort of trouble in Make when run in parallel. > > I suppose it can be viewed both ways: Make has all information to know > that the file _is_ going to be touched, so it _could_ order operations > accordingly. Indeed, the syntax of the Makefile implies this, but the parser isn't intelligent enough to add this extra constraint. This makes it harder for humans to write correct Makefiles, but it meets the requirements of the specifications. (may also yield faster builds in some situations) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:45:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:45:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492645.762281 (Exim 4.92) (envelope-from ) id 1pQ97M-0003hV-7A; Thu, 09 Feb 2023 15:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492645.762281; Thu, 09 Feb 2023 15:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97M-0003hL-4H; Thu, 09 Feb 2023 15:45:48 +0000 Received: by outflank-mailman (input) for mailman id 492645; Thu, 09 Feb 2023 15:45:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97K-0003h3-PI; Thu, 09 Feb 2023 15:45:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97K-00006N-Nk; Thu, 09 Feb 2023 15:45:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97K-0004SD-Go; Thu, 09 Feb 2023 15:45:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQ97K-0006hh-GN; Thu, 09 Feb 2023 15:45:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6hk925i0VMfi2EXES14IsOTp/AYNKxRP+fV7GKwvBno=; b=Y1mBX74HkUWV7G+iH1zf4P1sbI N8be0sG0UJ5kTP4V6uTh5R0rFPJ6M9+pYiT+VZXFofmtLr5ChuWfUPmoIlCHKeDQPh2tK6G4iUHXH T35ootM4eJuuByHBgWF7249iPom0FhwRywB+xngBy8ZxpeobpHeOLZcRQIldUEW1AEQ8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176746: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=4e0b4ccfc504f26187939068796295340ffd0e2f X-Osstest-Versions-That: xen=e1528c54d3c44e50f0460f1ff721a876c81479b9 From: osstest service owner Date: Thu, 09 Feb 2023 15:45:46 +0000 flight 176746 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176746/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 4e0b4ccfc504f26187939068796295340ffd0e2f baseline version: xen e1528c54d3c44e50f0460f1ff721a876c81479b9 Last test of basis 176733 2023-02-09 11:02:08 Z 0 days Testing same since 176746 2023-02-09 14:01:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Juergen Gross Roger Pau Monné jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e1528c54d3..4e0b4ccfc5 4e0b4ccfc504f26187939068796295340ffd0e2f -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:46:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:46:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492652.762291 (Exim 4.92) (envelope-from ) id 1pQ97q-0004AY-G7; Thu, 09 Feb 2023 15:46:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492652.762291; Thu, 09 Feb 2023 15:46:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97q-0004AR-DF; Thu, 09 Feb 2023 15:46:18 +0000 Received: by outflank-mailman (input) for mailman id 492652; Thu, 09 Feb 2023 15:46:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ97o-0002yh-G2 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:46:16 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e302cf95-a890-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:46:15 +0100 (CET) Received: by mail-wr1-x42c.google.com with SMTP id y1so2226628wru.2 for ; Thu, 09 Feb 2023 07:46:15 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id a6-20020a056000100600b0029a06f11022sm1488681wrx.112.2023.02.09.07.46.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2023 07:46:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e302cf95-a890-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E7QhE9VUwLzOQDNYqMHGbQCK/VEIqlKB/JKpOSEY7sw=; b=ac52u488UcMEug01OhTBIqrVKvpqSNM976Vfl5NgGL0+izEh2/tnzVo140TlQYAhZl v1MmdvzWq4kr9a4qjWIb+HIZRnwkoLm1SHYuR2vZYYg18qE4gF0QYYQNr32hrtxlSmAO n7dYX1JE0Nm1il6OLLFYQrUPAfKdMjEgIM6Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7QhE9VUwLzOQDNYqMHGbQCK/VEIqlKB/JKpOSEY7sw=; b=OL8IEvt0xBy2I7oiDzYUizIQC7e5OYR82T2WcFES/1+dHBr77ElRFqXQycDuRyZx/3 Ts33gTFM3MglN2mMcLaSNGQD8yq0SzwbbHKGuwYUNs6EVXgHFnS956xBQeiHDgdG3SOk Jb47zYqGK8rtPztnyrwcFKE12vElai3Eq0QJRbe+6LriwR7cTYD+95HYHyYv2sY0gjSm sfVkKOZDb9nYSRQKil2jrTIUQCNB+jhZdvc/VYtYe1cd8ti1XzfXwXhpHHJ/YUOM6FYH DBm1wdMq8upcb2dflWq1yt91D2CS8SNcNt3yz2dYJmb5TwenHjXdgr067pT8M9N2FKJJ o5Fw== X-Gm-Message-State: AO0yUKWpfoeY+X/ncsatlMXRvma4lwO0HkG8uAUTB03a75yb/j4JrtzD KFttNqPBi5NQJSQ8iR0HlvCuKw== X-Google-Smtp-Source: AK7set/SI8GY2juQyzVGn8z43LEFO8ZTJrS/ZgcSkAyOjbUjlNa/j0OgWe0NolSXpj774xHNsiUBAQ== X-Received: by 2002:adf:fb03:0:b0:2bf:c09e:e7bc with SMTP id c3-20020adffb03000000b002bfc09ee7bcmr12698914wrr.7.1675957575302; Thu, 09 Feb 2023 07:46:15 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] tools/ocaml: Drop libxl bindings From: Christian Lindig In-Reply-To: <20230209154300.22130-1-andrew.cooper3@citrix.com> Date: Thu, 9 Feb 2023 15:46:13 +0000 Cc: Xen-devel , Christian Lindig , David Scott , =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , Rob Hoes Content-Transfer-Encoding: quoted-printable Message-Id: <1DCF8B7B-2DF9-4C56-96A2-BBA6BEF749F3@cloud.com> References: <20230209154300.22130-1-andrew.cooper3@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 9 Feb 2023, at 15:43, Andrew Cooper = wrote: >=20 > There are significant issues with these bindings, and their companion = half in > Xapi was deleted in 2018 >=20 > = https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6= d080f4fbe933d >=20 > owing to there having been no development of these bindings since = 2014. >=20 > In the unlikely event that we'd want to reinstate them, they'd need = reworking > basically from scratch anyway. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig > CC: David Scott > CC: Edwin T=C3=B6r=C3=B6k > CC: Rob Hoes >=20 > I'm unsure whether to drop xentoollog. They're technically orphaned = by this > change, but could be used in principle by the other bindings. > --- > tools/ocaml/Makefile | 4 - > tools/ocaml/libs/Makefile | 2 +- > tools/ocaml/libs/xl/META.in | 5 - > tools/ocaml/libs/xl/Makefile | 71 -- > tools/ocaml/libs/xl/genwrap.py | 582 ------------ > tools/ocaml/libs/xl/xenlight.ml.in | 94 -- > tools/ocaml/libs/xl/xenlight.mli.in | 93 -- > tools/ocaml/libs/xl/xenlight_stubs.c | 1663 = ---------------------------------- > tools/ocaml/test/Makefile | 55 -- > tools/ocaml/test/dmesg.ml | 17 - > tools/ocaml/test/list_domains.ml | 26 - > tools/ocaml/test/raise_exception.ml | 9 - > tools/ocaml/test/send_debug_keys.ml | 13 - > tools/ocaml/test/xtl.ml | 39 - > 14 files changed, 1 insertion(+), 2672 deletions(-) > delete mode 100644 tools/ocaml/libs/xl/META.in > delete mode 100644 tools/ocaml/libs/xl/Makefile > delete mode 100644 tools/ocaml/libs/xl/genwrap.py > delete mode 100644 tools/ocaml/libs/xl/xenlight.ml.in > delete mode 100644 tools/ocaml/libs/xl/xenlight.mli.in > delete mode 100644 tools/ocaml/libs/xl/xenlight_stubs.c > delete mode 100644 tools/ocaml/test/Makefile > delete mode 100644 tools/ocaml/test/dmesg.ml > delete mode 100644 tools/ocaml/test/list_domains.ml > delete mode 100644 tools/ocaml/test/raise_exception.ml > delete mode 100644 tools/ocaml/test/send_debug_keys.ml > delete mode 100644 tools/ocaml/test/xtl.ml >=20 Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:51:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:51:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492660.762303 (Exim 4.92) (envelope-from ) id 1pQ9Cf-0005kq-42; Thu, 09 Feb 2023 15:51:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492660.762303; Thu, 09 Feb 2023 15:51:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Cf-0005kj-0h; Thu, 09 Feb 2023 15:51:17 +0000 Received: by outflank-mailman (input) for mailman id 492660; Thu, 09 Feb 2023 15:51:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Cc-0005kH-SN for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:51:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9333d317-a891-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:51:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D877C20450; Thu, 9 Feb 2023 15:51:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8FCC31339E; Thu, 9 Feb 2023 15:51:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id G5q7IW4W5WPaRAAAMHmgww (envelope-from ); Thu, 09 Feb 2023 15:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9333d317-a891-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675957870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=49U/iiVX7PU9aoLxVLWAYTP6lS61c51jmxydm29uHtc=; b=bxpfDs8Fan+FwI3Qxv5RkD2ZK0WTQl7B+8LMv68tdxRAVVEarvcAeSee2cBtjZ+Vb2zm4S vnMnjjvAVC9diSzZe5EdwJVsam8ZpRA6izlY4Av3DfkDSM6VFWxL4JXPyoZNmTupHkpqPw 1/uqX2aaD3+QhwlT23xSnKWIH/JDT4I= Message-ID: Date: Thu, 9 Feb 2023 16:51:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] docs: clarify xenstore permission documentation Content-Language: en-US To: Edwin Torok , Andrew Cooper Cc: xen-devel@lists.xenproject.org, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9qqJbNJh8l4PnAyA0OIR80Vm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9qqJbNJh8l4PnAyA0OIR80Vm Content-Type: multipart/mixed; boundary="------------i0UYneXcMppfZVX06uWtRjDq"; protected-headers="v1" From: Juergen Gross To: Edwin Torok , Andrew Cooper Cc: xen-devel@lists.xenproject.org, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Edwin Torok Message-ID: Subject: Re: [PATCH] docs: clarify xenstore permission documentation References: <20230209144148.4132-1-jgross@suse.com> <201204d9-038b-9edf-8132-fa697ab36175@citrix.com> In-Reply-To: --------------i0UYneXcMppfZVX06uWtRjDq Content-Type: multipart/mixed; boundary="------------hcwcFmc84N72XMQbRi5L07yj" --------------hcwcFmc84N72XMQbRi5L07yj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDIuMjMgMTY6MjksIEVkd2luIFRvcm9rIHdyb3RlOg0KPiANCj4gDQo+PiBPbiA5 IEZlYiAyMDIzLCBhdCAxNToxNSwgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4gd3JvdGU6DQo+Pg0KPj4gT24gMDkvMDIvMjAyMyAyOjQxIHBtLCBKdWVyZ2Vu IEdyb3NzIHdyb3RlOg0KPj4+IEluIGRvY3MvbWlzYy94ZW5zdG9yZS50eHQgdGhlIGRlc2Ny aXB0aW9uIG9mIHRoZSBYZW5zdG9yZSBub2RlIGFjY2Vzcw0KPj4+IHBlcm1pc3Npb25zIGlz IG1pc3Npbmcgb25lIGltcG9ydGFudCBhc3BlY3QsIHdoaWNoIGNhbiBiZSBmb3VuZCBvbmx5 DQo+Pj4gaW4gdGhlIGNvZGUgb3IgaW4gdGhlIHdpa2kgWzFdOg0KPj4+DQo+Pj4gVGhlIGZp cnN0IHBlcm1pc3Npb24gZW50cnkgaXMgZGVmaW5pbmcgdGhlIG93bmVyIG9mIHRoZSBub2Rl IHZpYSB0aGUNCj4+PiBkb21pZCwgYW5kIHRoZSBhY2Nlc3MgcmlnaHRzIGZvciBhbGwgZG9t YWlucyBOT1QgaGF2aW5nIGEgZGVkaWNhdGVkDQo+Pj4gcGVybWlzc2lvbiBlbnRyeS4NCj4+ Pg0KPj4+IE1ha2UgdGhhdCBhc3BlY3QgY2xlYXIgaW4gdGhlIG9mZmljaWFsIGRvY3VtZW50 YXRpb24uDQo+Pj4NCj4+PiBbMV06IGh0dHBzOi8vd2lraS54ZW5wcm9qZWN0Lm9yZy93aWtp L1hlbkJ1cyNQZXJtaXNzaW9ucw0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4NCj4+IEkgZmVlbCBhcyBpZiBFZHZpbiBkZXNl cnZlcyBzb21lIGtpbmQgb2YgY3JlZGl0IGhlcmUsIHNlZWluZyBhcyBpdCB3YXMNCj4+IGhp cyBvYnNlcnZhdGlvbi4uLg0KPj4NCj4+IEFsc28sIENDIHRvIGRvdWJsZSBjaGVjayB0aGUg d29yZGluZy4NCj4+DQo+PiB+QW5kcmV3DQo+Pg0KPj4+IC0tLQ0KPj4+IGRvY3MvbWlzYy94 ZW5zdG9yZS50eHQgfCAxNyArKysrKysrKysrLS0tLS0tLQ0KPj4+IDEgZmlsZSBjaGFuZ2Vk LCAxMCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdp dCBhL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgYi9kb2NzL21pc2MveGVuc3RvcmUudHh0DQo+ Pj4gaW5kZXggODg4N2U3ZGY4OC4uZDgwN2VmMDcwOSAxMDA2NDQNCj4+PiAtLS0gYS9kb2Nz L21pc2MveGVuc3RvcmUudHh0DQo+Pj4gKysrIGIvZG9jcy9taXNjL3hlbnN0b3JlLnR4dA0K Pj4+IEBAIC00NSwxMyArNDUsMTYgQEAgdGhlbSB0byB3aXRoaW4gMjA0OCBieXRlcy4gIChT ZWUgWEVOU1RPUkVfKl9QQVRIX01BWCBpbiB4c193aXJlLmguKQ0KPj4+DQo+Pj4gRWFjaCBu b2RlIGhhcyBvbmUgb3IgbXVsdGlwbGUgcGVybWlzc2lvbiBlbnRyaWVzLiAgUGVybWlzc2lv bnMgYXJlDQo+Pj4gZ3JhbnRlZCBieSBkb21haW4taWQsIHRoZSBmaXJzdCBwZXJtaXNzaW9u IGVudHJ5IG9mIGVhY2ggbm9kZSBzcGVjaWZpZXMNCj4+PiAtdGhlIG93bmVyIG9mIHRoZSBu b2RlLiAgUGVybWlzc2lvbnMgb2YgYSBub2RlIGNhbiBiZSBjaGFuZ2VkIGJ5IHRoZQ0KPj4+ IC1vd25lciBvZiB0aGUgbm9kZSwgdGhlIG93bmVyIGNhbiBvbmx5IGJlIG1vZGlmaWVkIGJ5 IHRoZSBjb250cm9sDQo+Pj4gLWRvbWFpbiAodXN1YWxseSBkb21haW4gaWQgMCkuICBUaGUg b3duZXIgYWx3YXlzIGhhcyB0aGUgcmlnaHQgdG8gcmVhZA0KPj4+IC1hbmQgd3JpdGUgdGhl IG5vZGUsIHdoaWxlIG90aGVyIHBlcm1pc3Npb25zIGNhbiBiZSBzZXR1cCB0byBhbGxvdw0K Pj4+IC1yZWFkIGFuZC9vciB3cml0ZSBhY2Nlc3MuICBXaGVuIGEgZG9tYWluIGlzIGJlaW5n IHJlbW92ZWQgZnJvbSBYZW5zdG9yZQ0KPj4+IC1ub2RlcyBvd25lZCBieSB0aGF0IGRvbWFp biB3aWxsIGJlIHJlbW92ZWQgdG9nZXRoZXIgd2l0aCBhbGwgb2YgdGhvc2UNCj4+PiAtbm9k ZXMnIGNoaWxkcmVuLg0KPj4+ICt0aGUgb3duZXIgb2YgdGhlIG5vZGUsIHdobyBhbHdheXMg aGFzIGZ1bGwgYWNjZXNzIHRvIHRoZSBub2RlIChyZWFkIGFuZA0KPj4+ICt3cml0ZSBwZXJt aXNzaW9uKS4NCj4gDQo+Pj4gICBUaGUgYWNjZXNzIHJpZ2h0cyBvZiB0aGUgZmlyc3QgZW50 cnkgc3BlY2lmeSB0aGUNCj4+PiArYWxsb3dlZCBhY2Nlc3MgZm9yIGFsbCBkb21haW5zIG5v dCBoYXZpbmcgYSBkZWRpY2F0ZWQgcGVybWlzc2lvbiBlbnRyeQ0KPj4+ICsodGhlIGRlZmF1 bHQgaXMgIm4iLCByZW1vdmluZyBhY2Nlc3MgZm9yIGFsbCBkb21haW5zIG5vdCBleHBsaWNp dGx5DQo+Pj4gK2FkZGVkIHZpYSBhZGRpdGlvbmFsIHBlcm1pc3Npb24gZW50cmllcykuICBQ ZXJtaXNzaW9ucyBvZiBhIG5vZGUgY2FuIGJlDQo+Pj4gK2NoYW5nZWQgYnkgdGhlIG93bmVy IG9mIHRoZSBub2RlLCB0aGUgb3duZXIgY2FuIG9ubHkgYmUgbW9kaWZpZWQgYnkgdGhlDQo+ Pj4gK2NvbnRyb2wgZG9tYWluICh1c3VhbGx5IGRvbWFpbiBpZCAwKS4NCj4gDQo+IFRoaXMg bG9va3MgZ29vZCBpbiBnZW5lcmFsLCBvbmUgc21hbGwgbml0cGljaywgbWF5YmUgd2UgbmVl ZCBzb21ldGhpbmcgbGlrZSB0aGlzIHRvbzoNCj4gIiwgb3IgZG9tYWlucyBlcXVpdmFsZW50 IHRvIHRoZSBvd25lciBvciBjb250cm9sIGRvbWFpbiAoZG9tYWluIGVxdWl2YWxlbmNlIGNh biBiZSBlc3RhYmxpc2hlZCB3aXRoIHRoZSBwcml2aWxlZ2VkIFNFVF9UQVJHRVQgb3BlcmF0 aW9uKSINCg0KVGhpcyBpcyBhbHJlYWR5IHBhcnQgb2YgdGhlIFNFVF9UQVJHRVQgZGVzY3Jp cHRpb24uIFNvIEkgZG9uJ3QgdGhpbmsgd2UNCm5lZWQgdG8gYWRkIGl0IGhlcmUsIHRvby4N Cg0KDQpKdWVyZ2VuDQo= --------------hcwcFmc84N72XMQbRi5L07yj Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------hcwcFmc84N72XMQbRi5L07yj-- --------------i0UYneXcMppfZVX06uWtRjDq-- --------------9qqJbNJh8l4PnAyA0OIR80Vm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPlFm4FAwAAAAAACgkQsN6d1ii/Ey+m QAf/bj6vNccMlTvInb3jfCrGaMK37l83R0qRkU/LSRw3mhnF1T+vDNVVhd3JKg6kEyonAXUGvFYX Vn76ln/vyNwK3RzN/y92nHH27Qe54pASno3bguUoPE5661/z5jNQOzo0mGgjyFXLAUkPesGBK8Rr N7sy07eLJ19rum/icIsy3yloNRVLFAalIceu5355t92LYsWFszLta5xBaFR4jKw0xkikkJqY7iu6 sGYevT2OGSc5MSpUA8Q+/Jy1XmsESfUXOQBB0uTtQYONFVs6JLbG+oHk+ulRD6I2R+QBoNbPFm5g SyAZYJ6EzruepuPdO0VYlPiMjl8lGWk4SlJv35Iy6Q== =Pzsx -----END PGP SIGNATURE----- --------------9qqJbNJh8l4PnAyA0OIR80Vm-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492669.762314 (Exim 4.92) (envelope-from ) id 1pQ9HZ-0006cy-Qi; Thu, 09 Feb 2023 15:56:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492669.762314; Thu, 09 Feb 2023 15:56:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9HZ-0006cr-O0; Thu, 09 Feb 2023 15:56:21 +0000 Received: by outflank-mailman (input) for mailman id 492669; Thu, 09 Feb 2023 15:56:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9HY-0006cl-9b for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:20 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a1763a9-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:18 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id h3so2494206eda.5 for ; Thu, 09 Feb 2023 07:56:18 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a1763a9-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nhWZ5xP8ug0pEon/NuBy4vBE1mK/xsvyvXyQ+nn10LI=; b=F3S1iq+pYwlbIvtE9ysvRCapCGdVf7bX2eizENTk5/zHuTdIBpY8oFM4g8Lvs9NQ1z eMsdBhQQCMvwNxFKNYin6UQg2Bit/a9UADIPlj0+HiEAFW6dk0Lg8rL+NqbCS7V9t+KB ec9EVK/RNM0/6UvLrjDjYl0n1RIFISfba5vCTgGN5RtGS/XLhkQFbbShegNbeHRpxZE8 NiLKHth+4icena/W/lkUt1kihn/s9z5hQazg5HgqEn0/UwOIIOz6C1tL9IIBsuyuqiPE /CqkK+YOQThPNclh90cK6fmAnfz+j4TsiWx1ouiR7xEmodanldR4FHo4qPl4sGavelFE Nq0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nhWZ5xP8ug0pEon/NuBy4vBE1mK/xsvyvXyQ+nn10LI=; b=MZQVUSAWXhtt7bA9VV+hN3keF9TF7y3XPB6eV9WemKRREgHW9xNUjRu5sn55d6TzlZ RMxMXxMZp9njdQ6ZGfhli650BnZ230pqq6sIGp/ARtrbtTBBmfOjqAGIS5lRjFkZjyxZ +Ab5Ck2m5ZqGHAmO9KWR0VQMeEyzt4kKhJAzC/f92I9mlzG2ui9wYbRM4Fr9BREPDNoW P4K82sGT8l1xFnQs9V/u1cliiFhDesrOC5Awcp4gZsQ5VTw0fdBniCAgu7/qHzW3SXVl Ma3oQ2UYkltOQ3O5eudcZf9rKEceI2cysFpYM9/KyXb4cmcGIepRWGaCQFPMChvdmJwz TUWg== X-Gm-Message-State: AO0yUKUhu5XuZTns2WxTlDpytvXy8TZ5CVJeMFcdMAtuMsy/NWu9JP+9 2PL6Z45qdItVTKqb2yEG6TaQRoJvWHU= X-Google-Smtp-Source: AK7set+rJYqjx31sRsBUjiRMqE30uHApRRjyJs6X7bFGirA6EBV05Hr1VhZ/KDDlkWe0nXG+s5QbUA== X-Received: by 2002:a05:6402:34cc:b0:4a2:5b11:1a51 with SMTP id w12-20020a05640234cc00b004a25b111a51mr13552279edc.2.1675958177318; Thu, 09 Feb 2023 07:56:17 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 0/9] PCID server Date: Thu, 9 Feb 2023 17:55:54 +0200 Message-Id: <20230209155604.2753219-1-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Moved pcid server from xl command to standalone application Dmytro Semenets (7): tools/libs/light: Add vchan support to libxl tools/xlpcid: Add xlpcid daemon tools/libs/light: pcid: implement list_assignable command tools/libs/light: pcid: implement is_device_assigned command tools/libs/light: pcid: implement reset_device command tools/libs/light: pcid: implement resource_list command tools/libs/light: pcid: implement write_bdf command Oleksandr Andrushchenko (1): tools: allow vchan XenStore paths more then 64 bytes long Volodymyr Babchuk (1): tools/light: pci: move assign/revert logic to pcid tools/Makefile | 1 + tools/configure | 8 +- tools/configure.ac | 1 + tools/helpers/Makefile | 4 +- tools/hotplug/FreeBSD/rc.d/xlpcid.in | 75 ++ tools/hotplug/Linux/init.d/xlpcid.in | 76 ++ tools/hotplug/Linux/systemd/Makefile | 1 + .../hotplug/Linux/systemd/xenpcid.service.in | 10 + tools/hotplug/NetBSD/rc.d/xlpcid.in | 75 ++ tools/include/xen-pcid.h | 229 ++++ tools/libs/light/Makefile | 8 +- tools/libs/light/libxl_pci.c | 673 +++++----- tools/libs/light/libxl_pcid.c | 1110 +++++++++++++++++ tools/libs/light/libxl_vchan.c | 496 ++++++++ tools/libs/light/libxl_vchan.h | 94 ++ tools/libs/vchan/init.c | 28 +- tools/xl/Makefile | 3 +- tools/xlpcid/Makefile | 52 + tools/xlpcid/bash-completion | 20 + tools/xlpcid/xlpcid.c | 213 ++++ 20 files changed, 2810 insertions(+), 367 deletions(-) create mode 100644 tools/hotplug/FreeBSD/rc.d/xlpcid.in create mode 100644 tools/hotplug/Linux/init.d/xlpcid.in create mode 100644 tools/hotplug/Linux/systemd/xenpcid.service.in create mode 100644 tools/hotplug/NetBSD/rc.d/xlpcid.in create mode 100644 tools/include/xen-pcid.h create mode 100644 tools/libs/light/libxl_pcid.c create mode 100644 tools/libs/light/libxl_vchan.c create mode 100644 tools/libs/light/libxl_vchan.h create mode 100644 tools/xlpcid/Makefile create mode 100644 tools/xlpcid/bash-completion create mode 100644 tools/xlpcid/xlpcid.c -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492670.762325 (Exim 4.92) (envelope-from ) id 1pQ9Hj-0006uL-2X; Thu, 09 Feb 2023 15:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492670.762325; Thu, 09 Feb 2023 15:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hi-0006uE-Vj; Thu, 09 Feb 2023 15:56:30 +0000 Received: by outflank-mailman (input) for mailman id 492670; Thu, 09 Feb 2023 15:56:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hh-0006cl-H3 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:29 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4fe65f33-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:27 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id p26so7633950ejx.13 for ; Thu, 09 Feb 2023 07:56:27 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fe65f33-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TBqwkdTRqUwsY27EiP5YbesMgj7n7qTjOsQBFo8GYrE=; b=Otue27v9JKkHSwyRJM7inigaaJ/A+nbUdm6nZA67OVZlQxRV2xH6IO+UkKh40PN8xB gWeXV+CpZp2jp5QOYprBO4JngVU9bzeiYjYYXRQGzqdDyvTgWe3DH6EhBJvJ0nrGRLA8 jCZ8w3K7PCdkgSUPL1rWA6Zo8PHMZIxP6Vf7QPZNeqbjX/YMGqjAPzNRiOtDbEqZJthw XDwXJnzBVvintI3+0my827uVjYyy5wHDcB7KQhYJbFqE838Ol7ozyeqk8t2rIXh5dUr6 urhnHkBIV3BKesNt2F7IbEr5Sma4fNYyOoh9+/zbbLHzS9l5hn4TxT/KHXfbOvsU0Srx U+kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TBqwkdTRqUwsY27EiP5YbesMgj7n7qTjOsQBFo8GYrE=; b=xa5D7uPWlej6ux3cqXPXQnEMGEvVXoTVIwZdh334bjVdjCaKKuCkcwMv/pgz0pJj6Y aV5KHXSs2OsikVGGvA5za/pHEfoyHxbWaVzAmls4zpNQ18KT4wqMS+LrW50xIsUgDnFg w4+wtiHOJImX4gwgHui6sbk8kxmU2M0Zla/nlOOtZEuSBTpfo3KoA5/5MJCp1zAQWKpN MWzI7WOe2ZBvkgGDg+0wRysqKfm4gk6NtdJzudhjS7NZfDb2CvpXcYON+jqh2aOMLAST YaBIGAu41R//RdPpgWeikLFsLwS3RHBm6ts1Ks5cal8lYieZpu51ZMvZcRRLtZ0QSBdw 0gpA== X-Gm-Message-State: AO0yUKWQFNwjvhUlVq+3ZAgB3uPYPIlplJpJlGpchJiPzny19s+4Qjsr bbx1uvcjzwS1Pkgx9QbR81V7vt5VjbZBSQ== X-Google-Smtp-Source: AK7set/puazmZO3ubl7G7w9/AN0S6fj2NUEpt69AFT0wH2aw4Z2mQuXg8i+CRoMJLfRMK0hs7qYXjA== X-Received: by 2002:a17:906:7383:b0:88d:5f84:2756 with SMTP id f3-20020a170906738300b0088d5f842756mr10021510ejl.0.1675958187167; Thu, 09 Feb 2023 07:56:27 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Dmytro Semenets Subject: [RFC PATCH v4 1/9] tools: allow vchan XenStore paths more then 64 bytes long Date: Thu, 9 Feb 2023 17:55:55 +0200 Message-Id: <20230209155604.2753219-2-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Current vchan implementation, while dealing with XenStore paths, allocates 64 bytes buffer on the stack which may not be enough for some use-cases. Make the buffer longer to respect maximum allowed XenStore path of XENSTORE_ABS_PATH_MAX. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets --- tools/libs/vchan/init.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98..fec650dc32 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -249,7 +249,7 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base int ret = -1; struct xs_handle *xs; struct xs_permissions perms[2]; - char buf[64]; + char *buf; char ref[16]; char* domid_str = NULL; xs_transaction_t xs_trans = XBT_NULL; @@ -259,6 +259,10 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base if (!ctrl->xs_path) return -1; + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) + return -1; + xs = xs_open(0); if (!xs) goto fail; @@ -280,14 +284,14 @@ retry_transaction: goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ring_ref); - snprintf(buf, sizeof buf, "%s/ring-ref", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ctrl->event_port); - snprintf(buf, sizeof buf, "%s/event-channel", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) @@ -303,6 +307,7 @@ retry_transaction: free(domid_str); xs_close(xs); fail: + free(buf); return ret; } @@ -419,13 +424,20 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, { struct libxenvchan *ctrl = malloc(sizeof(struct libxenvchan)); struct xs_handle *xs = NULL; - char buf[64]; + char *buf; char *ref; int ring_ref; unsigned int len; if (!ctrl) - return 0; + return NULL; + + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) { + free(ctrl); + return NULL; + } + ctrl->ring = NULL; ctrl->event = NULL; ctrl->gnttab = NULL; @@ -436,8 +448,9 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, if (!xs) goto fail; + // find xenstore entry - snprintf(buf, sizeof buf, "%s/ring-ref", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -445,7 +458,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, free(ref); if (!ring_ref) goto fail; - snprintf(buf, sizeof buf, "%s/event-channel", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -475,6 +488,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, out: if (xs) xs_close(xs); + free(buf); return ctrl; fail: libxenvchan_close(ctrl); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492671.762336 (Exim 4.92) (envelope-from ) id 1pQ9Hl-0007BE-E7; Thu, 09 Feb 2023 15:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492671.762336; Thu, 09 Feb 2023 15:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hl-0007B7-7y; Thu, 09 Feb 2023 15:56:33 +0000 Received: by outflank-mailman (input) for mailman id 492671; Thu, 09 Feb 2023 15:56:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hj-0006cl-Fc for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:31 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50ba1841-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:29 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id hx15so7652455ejc.11 for ; Thu, 09 Feb 2023 07:56:29 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50ba1841-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=03O/96QsOqq4aLYpGvEXu2Bk6X9D5zYH6rdH2Rhto3Q=; b=HH8rRKbcQejrQ139t78ATSMAMZyF0w+2salzQaCKfYP2KbwZ0i+OK4nFIL2kX38QlT 8qKK0TsA4htSkcN6otudBu2dWYjAXsVHIUlZiTwD+GnugBNKj/G9jw1a5uYoDxuHj01z Fn54o+FVreKOb6B1xAZQX2z763SYtxj0AZnM70Kx0ZlNf9nthoguVFUHhGov3mQZGPT8 NtyiD9vASz0I4uHl6gFZLJAWFArjFtABP/EY3SPR3C+j9zc/FksPC6LX4ZNY8BlyGuOx /AUHLz2CFZ9qB+eWr/36bKITxV2vzdZzm+4hyATaYaV227qbX36U2uOTsx1EMEQEr3FZ UwWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=03O/96QsOqq4aLYpGvEXu2Bk6X9D5zYH6rdH2Rhto3Q=; b=i8qUtyo12LgN90rxp1VZvnGJgJ9v9CoXahuiR4rlTsHUXqB/hRIYjR6mmmKNKpjjt/ /zgYKlUhNWT+ZO3ZwRjHqljz8ozkw9FjrwMSQPSchatPuOZHqoGgmUQGTs4JDgdDewwd 2b8nOrp5sYcdU1lzXRKk4kHdjX/eCzRgcI2XU+iZNWozN8i4U5U9CS84PG0S57OD1GeO gYZ+9vS+RgugMbVhMH1SnYApmA6c0k0KmEA77Novs4m5HxCgF20ftcQGdJrfJH7rVK2d a/pSHolJjHqZc4Z5XfmvLQ20kJVHKlshfvOkG3nigln/vIdPYBqP2L4tv5zUzigO1Lux UpIQ== X-Gm-Message-State: AO0yUKUA7YJkGMboVI7etZzS0s8w6sFE8tq0I+eJXnsgoJsUveZeuix1 yCxQN/IcbPo94XjAwctB+T2ri4iL0+7LLQ== X-Google-Smtp-Source: AK7set+LrEMplV6Q2EZwwQvoyOuh1xvJjRc43Jm6NbMsOKFIqs4HGgniioDQpgURAH79l0GC4g4gWw== X-Received: by 2002:a17:906:283:b0:878:5946:c0ac with SMTP id 3-20020a170906028300b008785946c0acmr11785944ejf.3.1675958188282; Thu, 09 Feb 2023 07:56:28 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross , Oleksandr Andrushchenko , Anastasiia Lukianenko Subject: [RFC PATCH v4 2/9] tools/libs/light: Add vchan support to libxl Date: Thu, 9 Feb 2023 17:55:56 +0200 Message-Id: <20230209155604.2753219-3-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Add possibility to send commands from libxl and execute them on server side. Libxl vchan adds support for JSON messages processing. The using of libxl vchan is preventing the client from libxl from reading and writing from / to the local sysfs directly.To do this, the libxl vchan was added - instead of working with the read and write functions from / to the sysfs, functionality allows to send requests to the server, then receive and process the response. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko Signed-off-by: Dmytro Semenets --- tools/helpers/Makefile | 4 +- tools/libs/light/Makefile | 7 +- tools/libs/light/libxl_vchan.c | 488 +++++++++++++++++++++++++++++++++ tools/libs/light/libxl_vchan.h | 92 +++++++ tools/xl/Makefile | 3 +- 5 files changed, 588 insertions(+), 6 deletions(-) create mode 100644 tools/libs/light/libxl_vchan.c create mode 100644 tools/libs/light/libxl_vchan.h diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 09590eb5b6..2bf52d055d 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -20,7 +20,7 @@ $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxentoollog) $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenstore) $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenlight) $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenctrl) -xen-init-dom0: LDLIBS += $(call xenlibs-ldlibs,ctrl toollog store light) +xen-init-dom0: LDLIBS += $(call xenlibs-ldlibs,ctrl toollog store light vchan) INIT_XENSTORE_DOMAIN_OBJS = init-xenstore-domain.o init-dom-json.o $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxentoollog) @@ -29,7 +29,7 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight) $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h -init-xenstore-domain: LDLIBS += $(call xenlibs-ldlibs,toollog store ctrl guest light) +init-xenstore-domain: LDLIBS += $(call xenlibs-ldlibs,toollog store ctrl guest light vchan) INIT_DOM0LESS_OBJS = init-dom0less.o init-dom-json.o $(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxentoollog) diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 4fddcc6f51..0941ad2cf4 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -71,6 +71,7 @@ OBJS-y += libxl.o OBJS-y += libxl_create.o OBJS-y += libxl_dm.o OBJS-y += libxl_pci.o +OBJS-y += libxl_vchan.o OBJS-y += libxl_dom.o OBJS-y += libxl_exec.o OBJS-y += libxl_xshelp.o @@ -170,7 +171,7 @@ LDLIBS-y += $(PTHREAD_LIBS) LDLIBS-y += -lyajl LDLIBS += $(LDLIBS-y) -$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h +$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) $(CFLAGS_libxenevtchn) -include $(XEN_ROOT)/tools/config.h $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\" $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore) libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools # include libacpi/x86.h @@ -241,13 +242,13 @@ libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS) test_%: test_%.o test_common.o libxenlight_test.so - $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) testidl: testidl.o libxenlight.so - $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) install:: $(LIBHEADERS) libxl-save-helper $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c new file mode 100644 index 0000000000..7611816f52 --- /dev/null +++ b/tools/libs/light/libxl_vchan.c @@ -0,0 +1,488 @@ +/* + * Vchan support for JSON messages processing + * + * Copyright (C) 2021 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#define VCHAN_EOM "\r\n" +/* + * http://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html + * 1.4.4 Domain Controlled Paths + * 1.4.4.1 ~/data [w] + * A domain writable path. Available for arbitrary domain use. + */ +#define VCHAN_SRV_DIR "/local/domain" + +struct vchan_state { + struct libxenvchan *ctrl; + + /* Server domain ID. */ + libxl_domid domid; + + /* XenStore path of the server with the ring buffer and event channel. */ + char *xs_path; + + int select_fd; + + /* GC used for state's lifetime allocations, such as rx_buf. */ + libxl__gc *gc; + /* Receive buffer. */ + char *rx_buf; + /* Current allocated size. */ + size_t rx_buf_size; + /* Actual data in the buffer. */ + size_t rx_buf_used; + + /* YAJL generator used to parse and create requests/replies. */ + yajl_gen gen; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen gen, + const char *field, char *val) +{ + libxl__json_object *result; + + libxl__yajl_gen_asciiz(gen, field); + result = libxl__json_object_alloc(gc, JSON_STRING); + result->u.string = val; + return libxl__json_object_to_yajl_gen(gc, gen, result); +} + +static libxl__json_object *libxl__vchan_arg_new(libxl__gc *gc, + libxl__json_node_type type, + libxl__json_object *args, + char *key) +{ + libxl__json_map_node *arg; + libxl__json_object *obj; + + obj = libxl__json_object_alloc(gc, type); + + GCNEW(arg); + + arg->map_key = key; + arg->obj = obj; + + flexarray_append(args->u.map, arg); + + return obj; +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_STRING, args, key); + + obj->u.string = val; +} + +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_BOOL, args, key); + + obj->u.b = val; +} + +static void reset_yajl_generator(struct vchan_state *state) +{ + yajl_gen_clear(state->gen); + yajl_gen_reset(state->gen, NULL); +} + +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf = NULL; + size_t len = 0; + + yajl_gen_get_buf(gen, &buf, &len); + LOG(DEBUG, "%s\n", buf); +} + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state) +{ + vchan_dump_gen(gc, state->gen); +} + +/* + * Find a JSON object and store it in o_r. + * return ERROR_NOTFOUND if no object is found. + */ +static int vchan_get_next_msg(libxl__gc *gc, struct vchan_state *state, + libxl__json_object **o_r) +{ + size_t len; + char *end = NULL; + const size_t eoml = sizeof(VCHAN_EOM) - 1; + libxl__json_object *o = NULL; + + if (!state->rx_buf_used) + return ERROR_NOTFOUND; + + /* Search for the end of a message which is CRLF. */ + end = memmem(state->rx_buf, state->rx_buf_used, VCHAN_EOM, eoml); + if (!end) + return ERROR_NOTFOUND; + + len = (end - state->rx_buf) + eoml; + + LOGD(DEBUG, state->domid, "parsing %zuB: '%.*s'", len, (int)len, + state->rx_buf); + + /* Replace \r by \0 so that libxl__json_parse can use strlen */ + state->rx_buf[len - eoml] = '\0'; + + o = libxl__json_parse(gc, state->rx_buf); + state->rx_buf_used -= len; + if (!o) { + LOGD(ERROR, state->domid, "Parse error"); + /* + * In case of parsing error get back to a known state: + * reset the buffer and continue reading. + */ + return ERROR_INVAL; + } + + memmove(state->rx_buf, state->rx_buf + len, state->rx_buf_used); + + LOGD(DEBUG, state->domid, "JSON object received: %s", JSON(o)); + + *o_r = o; + + return 0; +} + +static int vchan_process_packet(libxl__gc *gc, struct vchan_info *vchan, + libxl__json_object **resp_result) +{ + while (true) { + struct vchan_state *state = vchan->state; + int rc; + ssize_t r; + + if (!libxenvchan_is_open(state->ctrl)) + return ERROR_FAIL; + + /* Check if the buffer still has space or increase its size. */ + if (state->rx_buf_size - state->rx_buf_used < vchan->receive_buf_size) { + size_t newsize = state->rx_buf_size * 2 + vchan->receive_buf_size; + + if (newsize > vchan->max_buf_size) { + LOGD(ERROR, state->domid, + "receive buffer is too big (%zu > %zu)", + newsize, vchan->max_buf_size); + return ERROR_NOMEM; + } + + state->rx_buf_size = newsize; + state->rx_buf = libxl__realloc(state->gc, state->rx_buf, + state->rx_buf_size); + } + + do { + libxl__json_object *msg; + + r = libxenvchan_read(state->ctrl, + state->rx_buf + state->rx_buf_used, + state->rx_buf_size - state->rx_buf_used); + + if (r < 0) { + LOGED(ERROR, state->domid, "error reading"); + return ERROR_FAIL; + } else if (r == 0) + continue; + + LOG(DEBUG, "received %zdB: '%.*s'", r, + (int)r, state->rx_buf + state->rx_buf_used); + + state->rx_buf_used += r; + assert(state->rx_buf_used <= state->rx_buf_size); + + /* parse rx buffer to find one json object */ + rc = vchan_get_next_msg(gc, state, &msg); + if ((rc == ERROR_INVAL) || (rc == ERROR_NOTFOUND)) + continue; + if (rc) + return rc; + + if (resp_result) + return vchan->handle_response(gc, msg, resp_result); + else { + reset_yajl_generator(state); + return vchan->handle_request(gc, state->gen, msg); + } + } while (libxenvchan_data_ready(state->ctrl)); + } + + return 0; +} + +static int vchan_write(libxl__gc *gc, struct vchan_state *state, char *cmd) +{ + size_t len; + int ret; + + len = strlen(cmd); + while (len) { + ret = libxenvchan_write(state->ctrl, cmd, len); + if (ret < 0) { + LOGE(ERROR, "vchan write failed"); + return ERROR_FAIL; + } + cmd += ret; + len -= ret; + } + return 0; +} + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args) +{ + libxl__json_object *result; + char *request; + int ret; + + reset_yajl_generator(vchan->state); + request = vchan->prepare_request(gc, vchan->state->gen, cmd, args); + if (!request) + return NULL; + + ret = vchan_write(gc, vchan->state, request); + if (ret < 0) + return NULL; + + ret = vchan_write(gc, vchan->state, VCHAN_EOM); + if (ret < 0) + return NULL; + + ret = vchan_process_packet(gc, vchan, &result); + if (ret < 0) + return NULL; + + return result; +} + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan) +{ + char *json_str; + int ret; + + ret = vchan_process_packet(gc, vchan, NULL); + if (ret) + return ret; + + json_str = vchan->prepare_response(gc, vchan->state->gen); + if (!json_str) + return ERROR_INVAL; + + ret = vchan_write(gc, vchan->state, json_str); + if (ret) + return ret; + + return vchan_write(gc, vchan->state, VCHAN_EOM); +} + +static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file) +{ + char **domains; + unsigned int i, n; + libxl_domid domid = DOMID_INVALID; + + domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); + if (domains == NULL) + goto out; + + for (i = 0; i < n; i++) { + const char *tmp; + int d; + + if (sscanf(domains[i], "%d", &d) != 1) + continue; + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); + /* Found the domain where the server lives. */ + if (tmp) { + domid = d; + break; + } + } + +out: + return domid; +} + +static int vchan_init_client(libxl__gc *gc, struct vchan_state *state, + bool is_server) +{ + if (is_server) { + state->ctrl = libxenvchan_server_init(NULL, state->domid, + state->xs_path, 0, 0); + if (!state->ctrl) { + perror("Couldn't initialize vchan server"); + exit(1); + } + + } else { + state->ctrl = libxenvchan_client_init(CTX->lg, state->domid, + state->xs_path); + if (!state->ctrl) { + LOGE(ERROR, "Couldn't initialize vchan client"); + return ERROR_FAIL; + } + } + + state->ctrl->blocking = 1; + state->select_fd = libxenvchan_fd_for_select(state->ctrl); + if (state->select_fd < 0) { + LOGE(ERROR, "Couldn't read file descriptor for vchan client"); + return ERROR_FAIL; + } + + LOG(DEBUG, "Initialized vchan %s, XenSore at %s", + is_server ? "server" : "client", state->xs_path); + + return 0; +} + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server) +{ + struct vchan_state *state; + yajl_gen gen; + int ret; + + gen = libxl_yajl_gen_alloc(NULL); + if (!gen) { + LOGE(ERROR, "Failed to allocate yajl generator"); + return NULL; + } + +#if HAVE_YAJL_V2 + /* Disable beautify for data */ + yajl_gen_config(gen, yajl_gen_beautify, 0); +#endif + + state = libxl__zalloc(gc, sizeof(*state)); + state->domid = domid; + state->xs_path = vchan_xs_path; + state->gc = gc; + ret = vchan_init_client(gc, state, is_server); + if (ret) { + state = NULL; + yajl_gen_free(gen); + } + + state->gen = gen; + + return state; +} + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name) +{ + return GCSPRINTF(VCHAN_SRV_DIR "/%d/data/%s", domid, srv_name); +} + +/* + * Wait for the server to create the ring and event channel: + * since the moment we create a XS folder to the moment we start + * watching it the server may have already created the ring and + * event channel entries. Thus, we cannot watch reliably here without + * races, so poll for both entries to be created. + */ +static int vchan_wait_server_available(libxl__gc *gc, const char *xs_path) +{ + char *xs_ring, *xs_evt; + int timeout_ms = 5000; + + xs_ring = GCSPRINTF("%s/ring-ref", xs_path); + xs_evt = GCSPRINTF("%s/event-channel", xs_path); + + while (timeout_ms) { + unsigned int len; + void *file; + int entries = 0; + + file = xs_read(CTX->xsh, XBT_NULL, xs_ring, &len); + if (file) { + entries++; + free(file); + } + + file = xs_read(CTX->xsh, XBT_NULL, xs_evt, &len); + if (file) { + entries++; + free(file); + } + + if (entries == 2) + return 0; + + timeout_ms -= 10; + usleep(10000); + } + + return ERROR_TIMEDOUT; +} + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) +{ + libxl_domid domid; + char *xs_path, *vchan_xs_path; + libxl_uuid uuid; + libxl_ctx *ctx = libxl__gc_owner(gc); + + domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name); + if (domid == DOMID_INVALID) { + LOGE(ERROR, "Can't find vchan server"); + return NULL; + } + + xs_path = vchan_get_server_xs_path(gc, domid, srv_name); + LOG(DEBUG, "vchan server at %s\n", xs_path); + + /* Generate unique client id. */ + libxl_uuid_generate(&uuid); + + vchan_xs_path = GCSPRINTF("%s/" LIBXL_UUID_FMT, xs_path, + LIBXL_UUID_BYTES((uuid))); + + if (!xs_mkdir(ctx->xsh, XBT_NULL, vchan_xs_path)) { + LOG(ERROR, "Can't create xs_dir at %s", vchan_xs_path); + return NULL; + } + + if (vchan_wait_server_available(gc, vchan_xs_path)) { + LOG(ERROR, "Failed to wait for the server to come up at %s", + vchan_xs_path); + return NULL; + } + + return vchan_init_new_state(gc, domid, vchan_xs_path, false); +} + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state) +{ + if (!state) + return; + + LOG(DEBUG, "Closing vchan"); + libxenvchan_close(state->ctrl); + + yajl_gen_free(state->gen); +} diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h new file mode 100644 index 0000000000..0968875298 --- /dev/null +++ b/tools/libs/light/libxl_vchan.h @@ -0,0 +1,92 @@ +/* + Common definitions for JSON messages processing by vchan + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef LIBXL_VCHAN_H +#define LIBXL_VCHAN_H + +#include + +struct vchan_state; + +struct vchan_info { + struct vchan_state *state; + + /* Process request and produce the result by adding json-objects to gen .*/ + int (*handle_request)(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request); + /* Convert the prepared response into JSON string. */ + char *(*prepare_response)(libxl__gc *gc, yajl_gen gen); + + /* Prepare request as JSON string which will be sent. */ + char *(*prepare_request)(libxl__gc *gc, yajl_gen gen, char *request, + libxl__json_object *args); + /* Handle response and produce the output suitable for the requester. */ + int (*handle_response)(libxl__gc *gc, const libxl__json_object *response, + libxl__json_object **result); + + /* Handle new client connection on the server side. */ + int (*handle_new_client)(libxl__gc *gc); + + /* Buffer info. */ + size_t receive_buf_size; + size_t max_buf_size; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen hand, + const char *field, char *val); + +static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) +{ + return libxl__json_object_alloc(gc, JSON_MAP); +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val); +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val); + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args); + +void vchan_reset_generator(struct vchan_state *state); + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan); + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name); + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server); + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name); + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state); + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state); +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen); + +#endif /* LIBXL_VCHAN_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/xl/Makefile b/tools/xl/Makefile index 5f7aa5f46c..da4591b6a9 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -15,6 +15,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS) CFLAGS_XL += $(CFLAGS_libxenlight) CFLAGS_XL += $(CFLAGS_libxenutil) CFLAGS_XL += -Wshadow +CFLAGS_XL += $(CFLAGS_libxenvchan) XL_OBJS-$(CONFIG_X86) = xl_psr.o XL_OBJS = xl.o xl_cmdtable.o xl_sxp.o xl_utils.o $(XL_OBJS-y) @@ -33,7 +34,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492672.762347 (Exim 4.92) (envelope-from ) id 1pQ9Hm-0007ST-TG; Thu, 09 Feb 2023 15:56:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492672.762347; Thu, 09 Feb 2023 15:56:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hm-0007SJ-O8; Thu, 09 Feb 2023 15:56:34 +0000 Received: by outflank-mailman (input) for mailman id 492672; Thu, 09 Feb 2023 15:56:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hl-0007Ak-2K for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:33 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 519d4f8f-a892-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:56:30 +0100 (CET) Received: by mail-ej1-x62f.google.com with SMTP id c26so2920514ejz.10 for ; Thu, 09 Feb 2023 07:56:30 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 519d4f8f-a892-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yJepENBooB8tnoAsGQEI6uVGIC9PbSV8wMNtT1M+PBA=; b=lVKyPCvi1P3BzjR0R1P0UuDTd3etXpBDEHEpBz7XajqUzfGRqEpK4po3AHGdPahnBc feUq7TBn90f16l37u1nPgV/yLIRGA5NX9pMqkhxg4XZj4tB6TAiqcqqymDcIF3Qvk6RB ILPb/cM3Ng3Q1YtDovAUKtz1OkZqVPikWXRT6m7SlWQdkcNA9Vb13DYryFoedH8FBcJD hFKZM8WmV3uE01vui46Vv3UN3kRpwrPEXG8OOVgXvtqdWRLeU3/DhcrqVfYZk3S2E1+V vdjEynY77IIIQVKifqGBl206Bb3TgRsKSb2LTpUXzjG/2Qu3bh7muNrFOvDtB8doU6Ed iVnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yJepENBooB8tnoAsGQEI6uVGIC9PbSV8wMNtT1M+PBA=; b=WMCrpxnE0t6PgSO/j5Vff/FQubXWxTvsjZDuBTiVcvJ9FJRzMz2k9F/yjKTrPXENSO tamHQUEnWo0Zl9cuWyHi/nZ/6yqSuDVs4Z5esLcUxdNB2R5pW1BwcvMgaeuHlL0hlk7g 6mqazOTzpF6RKjj+Qt7IVX9DVWsVxNHdnsOgDZlSpfpXO1xBn95OgrmdqGuggG+lbUBq zu70guwuIlkcmfz000OA+4/kHdiSPxJG2DAdF85SeTRtsb+vTIOPiobOK62i2TPO/JNd gv63Kj9pvMr9/OgfNzXrJ4/WY0+uBLYJPThoLpRo/qALHb4ExsV2exxRFlaUNPK+xEaS hsaw== X-Gm-Message-State: AO0yUKXLB2/EaB0PDo8/Vs9mztdFxq5neCWCwxk8vgxNTlSA49i5NQR4 f+Rdcor44cYtPp7YZ0moyiBOlgKIBOIn4A== X-Google-Smtp-Source: AK7set81phE31Bybl/PFIIPg1DndlV9xZvdjfkV6IeUrl6A1qoPYapdjwju8W1yUblqTS9BP/VV9og== X-Received: by 2002:a17:906:1d2:b0:893:526b:c77b with SMTP id 18-20020a17090601d200b00893526bc77bmr12880215ejj.7.1675958189713; Thu, 09 Feb 2023 07:56:29 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross , Oleksandr Andrushchenko , Anastasiia Lukianenko Subject: [RFC PATCH v4 3/9] tools/xlpcid: Add xlpcid daemon Date: Thu, 9 Feb 2023 17:55:57 +0200 Message-Id: <20230209155604.2753219-4-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Add draft version of pcid server (based on vchan-node2), which can receive messages from the client. Add essential functionality to handle pcid protocol: - define required constants - prepare for handling remote requests - prepare and send an error packet Signed-off-by: Dmytro Semenets Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko --- tools/Makefile | 1 + tools/configure | 8 +- tools/configure.ac | 1 + tools/hotplug/FreeBSD/rc.d/xlpcid.in | 75 +++ tools/hotplug/Linux/init.d/xlpcid.in | 76 ++++ tools/hotplug/Linux/systemd/Makefile | 1 + .../hotplug/Linux/systemd/xenpcid.service.in | 10 + tools/hotplug/NetBSD/rc.d/xlpcid.in | 75 +++ tools/include/xen-pcid.h | 95 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_pci.c | 128 ++++++ tools/libs/light/libxl_pcid.c | 428 ++++++++++++++++++ tools/xlpcid/Makefile | 52 +++ tools/xlpcid/bash-completion | 20 + tools/xlpcid/xlpcid.c | 213 +++++++++ 15 files changed, 1182 insertions(+), 2 deletions(-) create mode 100644 tools/hotplug/FreeBSD/rc.d/xlpcid.in create mode 100644 tools/hotplug/Linux/init.d/xlpcid.in create mode 100644 tools/hotplug/Linux/systemd/xenpcid.service.in create mode 100644 tools/hotplug/NetBSD/rc.d/xlpcid.in create mode 100644 tools/include/xen-pcid.h create mode 100644 tools/libs/light/libxl_pcid.c create mode 100644 tools/xlpcid/Makefile create mode 100644 tools/xlpcid/bash-completion create mode 100644 tools/xlpcid/xlpcid.c diff --git a/tools/Makefile b/tools/Makefile index 4906fdbc23..5a99f7bb61 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -30,6 +30,7 @@ endif SUBDIRS-y += xenpmd SUBDIRS-$(CONFIG_GOLANG) += golang SUBDIRS-y += xl +SUBDIRS-y += xlpcid SUBDIRS-y += helpers SUBDIRS-$(CONFIG_X86) += xenpaging SUBDIRS-$(CONFIG_X86) += debugger diff --git a/tools/configure b/tools/configure index dae377c982..0cd6edb6ca 100755 --- a/tools/configure +++ b/tools/configure @@ -2455,7 +2455,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu -ac_config_files="$ac_config_files ../config/Tools.mk hotplug/common/hotplugpath.sh hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/libs/xs/paths.ml ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf" +ac_config_files="$ac_config_files ../config/Tools.mk hotplug/common/hotplugpath.sh hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/FreeBSD/rc.d/xlpcid hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xlpcid hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain hotplug/NetBSD/rc.d/xlpcid ocaml/libs/xs/paths.ml ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf" ac_config_headers="$ac_config_headers config.h" @@ -10081,7 +10081,7 @@ fi if test "x$systemd" = "xy"; then : - ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service" + ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service hotplug/Linux/systemd/xenpcid.service" fi @@ -10946,8 +10946,10 @@ do "hotplug/common/hotplugpath.sh") CONFIG_FILES="$CONFIG_FILES hotplug/common/hotplugpath.sh" ;; "hotplug/FreeBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xencommons" ;; "hotplug/FreeBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xendriverdomain" ;; + "hotplug/FreeBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xlpcid" ;; "hotplug/Linux/init.d/sysconfig.xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xencommons" ;; "hotplug/Linux/init.d/sysconfig.xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xendomains" ;; + "hotplug/Linux/init.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xlpcid" ;; "hotplug/Linux/init.d/xen-watchdog") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xen-watchdog" ;; "hotplug/Linux/init.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xencommons" ;; "hotplug/Linux/init.d/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xendomains" ;; @@ -10958,6 +10960,7 @@ do "hotplug/Linux/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/xendomains" ;; "hotplug/NetBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xencommons" ;; "hotplug/NetBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xendriverdomain" ;; + "hotplug/NetBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xlpcid" ;; "ocaml/libs/xs/paths.ml") CONFIG_FILES="$CONFIG_FILES ocaml/libs/xs/paths.ml" ;; "ocaml/xenstored/paths.ml") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/paths.ml" ;; "ocaml/xenstored/oxenstored.conf") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/oxenstored.conf" ;; @@ -10970,6 +10973,7 @@ do "hotplug/Linux/systemd/xendomains.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendomains.service" ;; "hotplug/Linux/systemd/xendriverdomain.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendriverdomain.service" ;; "hotplug/Linux/systemd/xenstored.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenstored.service" ;; + "hotplug/Linux/systemd/xenpcid.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenpcid.service" ;; *) as_fn_error $? "invalid argument: \`$ac_config_target'" "$LINENO" 5;; esac diff --git a/tools/configure.ac b/tools/configure.ac index 3a2f6a2da9..d2b22e94a9 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -489,6 +489,7 @@ AS_IF([test "x$systemd" = "xy"], [ hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service + hotplug/Linux/systemd/xenpcid.service ]) ]) diff --git a/tools/hotplug/FreeBSD/rc.d/xlpcid.in b/tools/hotplug/FreeBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..ad414c25ba --- /dev/null +++ b/tools/hotplug/FreeBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xlpcid... + ${sbindir}/xlpcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/hotplug/Linux/init.d/xlpcid.in b/tools/hotplug/Linux/init.d/xlpcid.in new file mode 100644 index 0000000000..d8e38501a7 --- /dev/null +++ b/tools/hotplug/Linux/init.d/xlpcid.in @@ -0,0 +1,76 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xlpcid... + ${sbindir}/xlpcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac + diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index e29889156d..49f0f87296 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -12,6 +12,7 @@ XEN_SYSTEMD_SERVICE += xendomains.service XEN_SYSTEMD_SERVICE += xen-watchdog.service XEN_SYSTEMD_SERVICE += xen-init-dom0.service XEN_SYSTEMD_SERVICE += xendriverdomain.service +XEN_SYSTEMD_SERVICE += xenpcid.service ALL_XEN_SYSTEMD := $(XEN_SYSTEMD_MODULES) \ $(XEN_SYSTEMD_MOUNT) \ diff --git a/tools/hotplug/Linux/systemd/xenpcid.service.in b/tools/hotplug/Linux/systemd/xenpcid.service.in new file mode 100644 index 0000000000..b0bfd72734 --- /dev/null +++ b/tools/hotplug/Linux/systemd/xenpcid.service.in @@ -0,0 +1,10 @@ +[Unit] +Description=Xen PCI host daemon +ConditionVirtualization=xen + +[Service] +Type=forking +ExecStart=@sbindir@/xlpcid + +[Install] +WantedBy=multi-user.target diff --git a/tools/hotplug/NetBSD/rc.d/xlpcid.in b/tools/hotplug/NetBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..ad414c25ba --- /dev/null +++ b/tools/hotplug/NetBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xlpcid... + ${sbindir}/xlpcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h new file mode 100644 index 0000000000..098118a0c3 --- /dev/null +++ b/tools/include/xen-pcid.h @@ -0,0 +1,95 @@ +/* + Common definitions for Xen PCI client-server protocol. + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + SPDX-License-Identifier: LGPL-2.1+ +*/ + +#ifndef XEN_PCID_H +#define XEN_PCID_H + +#define PCID_SRV_NAME "pcid" +#define PCID_XS_TOKEN "pcid-token" + +#define PCI_RECEIVE_BUFFER_SIZE 4096 +#define PCI_MAX_SIZE_RX_BUF MB(1) + +/* + ******************************************************************************* + * Common request and response structures used be the pcid remote protocol are + * described below. + ******************************************************************************* + * Request: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | cmd | string | String identifying the command | + * +-------------+--------------+----------------------------------------------+ + * + * Response: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | resp | string | Command string as in the request | + * +-------------+--------------+----------------------------------------------+ + * | error | string | "okay", "failed" | + * +-------------+--------------+----------------------------------------------+ + * | error_desc | string | Optional error description string | + * +-------------+--------------+----------------------------------------------+ + * + * Notes. + * 1. Every request and response must contain the above mandatory structures. + * 2. In case if a bad packet or an unknown command received by the server side + * a valid reply with the corresponding error code must be sent to the client. + * + * Requests and responses, which require SBDF as part of their payload, must + * use the following convention for encoding SBDF value: + * + * pci_device object: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | sbdf | string | SBDF string in form SSSS:BB:DD.F | + * +-------------+--------------+----------------------------------------------+ + */ + +/* Fileld names */ +#define PCID_MSG_FIELD_CMD "cmd" + +#define PCID_MSG_FIELD_RESP "resp" +#define PCID_MSG_FIELD_ERR "error" +#define PCID_MSG_FIELD_ERR_DESC "error_desc" + +/* pci_device object fields. */ +#define PCID_MSG_FIELD_SBDF "sbdf" + +/* Error values */ +#define PCID_MSG_ERR_OK "okay" +#define PCID_MSG_ERR_FAILED "failed" +#define PCID_MSG_ERR_NA "NA" + +#define PCID_SBDF_FMT "%04x:%02x:%02x.%01x" + +int libxl_pcid_process(libxl_ctx *ctx); + +#endif /* XEN_PCID_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 0941ad2cf4..72997eaac9 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -71,6 +71,7 @@ OBJS-y += libxl.o OBJS-y += libxl_create.o OBJS-y += libxl_dm.o OBJS-y += libxl_pci.o +OBJS-y += libxl_pcid.o OBJS-y += libxl_vchan.o OBJS-y += libxl_dom.o OBJS-y += libxl_exec.o diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index f4c4f17545..3d9ed0d50c 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -18,6 +18,10 @@ #include "libxl_internal.h" +#include + +#include "libxl_vchan.h" + #define PCI_BDF "%04x:%02x:%02x.%01x" #define PCI_BDF_SHORT "%02x:%02x.%01x" #define PCI_BDF_VDEVFN "%04x:%02x:%02x.%01x@%02x" @@ -25,6 +29,130 @@ #define PCI_BDF_XSPATH "%04x-%02x-%02x-%01x" #define PCI_PT_QDEV_ID "pci-pt-%02x_%02x.%01x" +static int pci_handle_response(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + const libxl__json_object *command_obj; + const libxl__json_object *err_obj; + char *command_name; + int ret = 0; + + *result = NULL; + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_RESP, response, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad response. */ + return 0; + } + + err_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR, response, JSON_STRING); + if (!err_obj) { + /* Bad packet without error code field. */ + return 0; + } + + if (strcmp(err_obj->u.string, PCID_MSG_ERR_OK) != 0) { + const libxl__json_object *err_desc_obj; + + /* The response may contain an optional error string. */ + err_desc_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR_DESC, + response, JSON_STRING); + if (err_desc_obj) + LOG(ERROR, "%s", err_desc_obj->u.string); + else + LOG(ERROR, "%s", err_obj->u.string); + return ERROR_FAIL; + } + + command_name = command_obj->u.string; + LOG(DEBUG, "command: %s", command_name); + + return ret; +} + +#define CONVERT_YAJL_GEN_TO_STATUS(gen) \ + ((gen) == yajl_gen_status_ok ? yajl_status_ok : yajl_status_error) + +static char *pci_prepare_request(libxl__gc *gc, yajl_gen gen, char *cmd, + libxl__json_object *args) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + yajl_status ret; + char *request = NULL; + int rc; + + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_open(gen)); + if (ret != yajl_status_ok) + return NULL; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_CMD, cmd); + if (rc) + return NULL; + + if (args) { + int idx = 0; + libxl__json_map_node *node = NULL; + + assert(args->type == JSON_MAP); + for (idx = 0; idx < args->u.map->count; idx++) { + if (flexarray_get(args->u.map, idx, (void**)&node) != 0) + break; + + ret = CONVERT_YAJL_GEN_TO_STATUS(libxl__yajl_gen_asciiz(gen, node->map_key)); + if (ret != yajl_status_ok) + return NULL; + ret = libxl__json_object_to_yajl_gen(gc, gen, node->obj); + if (ret != yajl_status_ok) + return NULL; + } + } + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_close(gen)); + if (ret != yajl_status_ok) + return NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + return NULL; + + request = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + + return request; +} + +struct vchan_info *pci_vchan_get_client(libxl__gc *gc); +struct vchan_info *pci_vchan_get_client(libxl__gc *gc) +{ + struct vchan_info *vchan; + + vchan = libxl__zalloc(gc, sizeof(*vchan)); + if (!vchan) + goto out; + vchan->state = vchan_new_client(gc, PCID_SRV_NAME); + if (!(vchan->state)) { + vchan = NULL; + goto out; + } + + vchan->handle_response = pci_handle_response; + vchan->prepare_request = pci_prepare_request; + vchan->receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + vchan->max_buf_size = PCI_MAX_SIZE_RX_BUF; + +out: + return vchan; +} + +void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan); +void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan) +{ + vchan_fini_one(gc, vchan->state); +} + static unsigned int pci_encode_bdf(libxl_device_pci *pci) { unsigned int value; diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c new file mode 100644 index 0000000000..2ce8f1504d --- /dev/null +++ b/tools/libs/light/libxl_pcid.c @@ -0,0 +1,428 @@ +/* + Utils for xl pcid daemon + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#include +#include + +#include + +#include +#include +#include + +#include +#include + +#define DOM0_ID 0 + +struct vchan_client { + XEN_LIST_ENTRY(struct vchan_client) list; + + /* This is the watch entry fired for this client. */ + char **watch_ret; + /* Length of the watch_ret[XS_WATCH_PATH]. */ + size_t watch_len; + + struct vchan_info info; + + /* + * This context is used by the processing loop to create its own gc + * and use it while processing commands, so we do not get OOM. + */ + libxl_ctx *ctx; + /* This gc holds all allocations made for the client needs itself. */ + libxl__gc gc[1]; + pthread_t run_thread; +}; + +static XEN_LIST_HEAD(clients_list, struct vchan_client) vchan_clients; + +static pthread_mutex_t vchan_client_mutex; + +static int make_error_reply(libxl__gc *gc, yajl_gen gen, char *desc, + char *command_name) +{ + int rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_FAILED); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR_DESC, desc); + if (rc) + return rc; + + return 0; +} + +static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request) +{ + const libxl__json_object *command_obj; + libxl__json_object *command_response = NULL; + char *command_name; + int ret = 0; + + yajl_gen_map_open(gen); + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_CMD, request, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad request. */ + ret = make_error_reply(gc, gen, "Unsupported request or bad packet", + PCID_MSG_ERR_NA); + goto out; + } + + command_name = command_obj->u.string; + + /* + * This is an unsupported command: make a reply and proceed over + * the error path. + */ + ret = make_error_reply(gc, gen, "Unsupported command", + command_name); + if (!ret) + ret = ERROR_NOTFOUND; + + if (ret) { + /* + * The command handler on error must provide a valid response, + * so we don't need to add any other field below. + */ + ret = 0; + goto out; + } + + if (command_response) { + ret = libxl__json_object_to_yajl_gen(gc, gen, command_response); + if (ret) + goto out; + } + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (ret) + goto out; + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_OK); +out: + yajl_gen_map_close(gen); + + vchan_dump_gen(gc, gen); + + return ret; +} + +static char *pcid_prepare_response(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + char *reply = NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + goto out; + + reply = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + +out: + return reply; +} + +static void server_fini_one(libxl__gc *gc, struct vchan_client *client) +{ + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_REMOVE(client, list); + pthread_mutex_unlock(&vchan_client_mutex); + + GC_FREE; + free(client->watch_ret); + free(client); +} + +static bool is_vchan_exist(libxl_ctx *ctx, char *watch_dir) +{ + char **dir = NULL; + unsigned int nb; + bool ret = false; + + dir = xs_directory(ctx->xsh, XBT_NULL, watch_dir, &nb); + if (dir) { + free(dir); + ret = true; + } + return ret; +} + +static void *client_thread(void *arg) +{ + struct vchan_client *client = arg; + + while (true) { + int ret; + /* + * libvchan uses garbage collector for processing requests, + * so we create a new one each time we process a packet and + * dispose it right away to prevent OOM. + */ + GC_INIT(client->ctx); + ret = vchan_process_command(gc, &client->info); + GC_FREE; + + if ((ret == ERROR_NOTFOUND) || (ret == ERROR_INVAL)) + continue; + if (ret < 0) + break; + } + vchan_fini_one(client->gc, client->info.state); + server_fini_one(client->gc, client); + return NULL; +} + +#define DEFAULT_THREAD_STACKSIZE (24 * 1024) +/* NetBSD doesn't have PTHREAD_STACK_MIN. */ +#ifndef PTHREAD_STACK_MIN +#define PTHREAD_STACK_MIN 0 +#endif + +#define READ_THREAD_STACKSIZE \ + ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ? \ + PTHREAD_STACK_MIN : DEFAULT_THREAD_STACKSIZE) + +static bool init_client_thread(libxl__gc *gc, struct vchan_client *new_client) +{ + + sigset_t set, old_set; + pthread_attr_t attr; + static size_t stack_size; +#ifdef USE_DLSYM + size_t (*getsz)(pthread_attr_t *attr); +#endif + + if (pthread_attr_init(&attr) != 0) + return false; + if (!stack_size) { +#ifdef USE_DLSYM + getsz = dlsym(RTLD_DEFAULT, "__pthread_get_minstack"); + if (getsz) + stack_size = getsz(&attr); +#endif + if (stack_size < READ_THREAD_STACKSIZE) + stack_size = READ_THREAD_STACKSIZE; + } + if (pthread_attr_setstacksize(&attr, stack_size) != 0) { + pthread_attr_destroy(&attr); + return false; + } + + sigfillset(&set); + pthread_sigmask(SIG_SETMASK, &set, &old_set); + + if (pthread_create(&new_client->run_thread, &attr, client_thread, + new_client) != 0) { + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + return false; + } + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + + return true; +} + +static void init_new_client(libxl_ctx *ctx, libxl__gc *gc, + struct clients_list *list, char **watch_ret) +{ + struct vchan_client *new_client; + char *xs_path = watch_ret[XS_WATCH_PATH]; + + LOG(DEBUG, "New client at \"%s\"", xs_path); + + new_client = malloc(sizeof(*new_client)); + if (!new_client) { + LOGE(ERROR, "Failed to allocate new client at \"%s\"", xs_path); + return; + } + + memset(new_client, 0, sizeof(*new_client)); + + new_client->watch_ret = watch_ret; + new_client->watch_len = strlen(xs_path); + new_client->ctx = ctx; + /* + * Remember the GC of this client, so we can dispose its memory. + * Use it from now on. + */ + LIBXL_INIT_GC(new_client->gc[0], ctx); + + new_client->info.state = vchan_init_new_state(new_client->gc, DOM0_ID, + xs_path, true); + if (!(new_client->info.state)) { + LOGE(ERROR, "Failed to add new client at \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + new_client->info.handle_request = pcid_handle_request; + new_client->info.prepare_response = pcid_prepare_response; + new_client->info.receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + new_client->info.max_buf_size = PCI_MAX_SIZE_RX_BUF; + + if (!init_client_thread(new_client->gc, new_client)) { + LOGE(ERROR, "Failed to create client's thread for \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_INSERT_HEAD(&vchan_clients, new_client, list); + pthread_mutex_unlock(&vchan_client_mutex); +} + +static void terminate_clients(void) +{ + struct vchan_client *client; + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + pthread_join(client->run_thread, NULL); + } + pthread_mutex_unlock(&vchan_client_mutex); +} + +int libxl_pcid_process(libxl_ctx *ctx) +{ + GC_INIT(ctx); + char *xs_path, *str; + char **watch_ret; + unsigned int watch_num; + libxl_domid domid; + int ret; + + pthread_mutex_init(&vchan_client_mutex, NULL); + + str = xs_read(ctx->xsh, 0, "domid", NULL); + if (!str) { + LOGE(ERROR, "Can't read own domid\n"); + ret = -ENOENT; + goto out; + } + + ret = sscanf(str, "%d", &domid); + free(str); + if (ret != 1) + { + LOGE(ERROR, "Own domid is not an integer\n"); + ret = -EINVAL; + goto out; + } + + xs_path = vchan_get_server_xs_path(gc, domid, PCID_SRV_NAME); + + /* Recreate the base folder: remove all leftovers. */ + ret = libxl__xs_rm_checked(gc, XBT_NULL, xs_path); + if (ret) + goto out; + + if (!xs_mkdir(CTX->xsh, XBT_NULL, xs_path)) + { + LOGE(ERROR, "xenstore mkdir failed: `%s'", xs_path); + ret = ERROR_FAIL; + goto out; + } + + /* Wait for vchan client to create a new UUID under the server's folder. */ + if (!xs_watch(CTX->xsh, xs_path, PCID_XS_TOKEN)) { + LOGE(ERROR, "xs_watch (%s) failed", xs_path); + ret = ERROR_FAIL; + goto out; + } + + while ((watch_ret = xs_read_watch(CTX->xsh, &watch_num))) { + struct vchan_client *client; + size_t len; + bool found; + + /* + * Any change under the base directory will fire an event, so we need + * to filter if this is indeed a new client or it is because vchan + * server creates nodes under its UUID. + * + * Never try to instantiate a vchan server right under xs_path. + */ + if (!strcmp(watch_ret[XS_WATCH_PATH], xs_path)) + continue; + + found = false; + len = strlen(watch_ret[XS_WATCH_PATH]); + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + str = client->watch_ret[XS_WATCH_PATH]; + + if (strstr(watch_ret[XS_WATCH_PATH], str)) { + /* + * Base path is a substring of the current path, so it can be: + * - a new node with different name, but starting with str + * - a subnode under str, so it will have '/' after str + * - same string + */ + if (len == client->watch_len) { + found = true; + break; + } + if (len > client->watch_len) { + if (watch_ret[XS_WATCH_PATH][client->watch_len] == '/') { + found = true; + break; + } + } + } + } + pthread_mutex_unlock(&vchan_client_mutex); + + if (!found && is_vchan_exist(ctx, watch_ret[XS_WATCH_PATH])) + init_new_client(ctx, gc, &vchan_clients, watch_ret); + } + + xs_unwatch(CTX->xsh, xs_path, PCID_XS_TOKEN); + +out: + terminate_clients(); + GC_FREE; + pthread_mutex_destroy(&vchan_client_mutex); + return ret; +} diff --git a/tools/xlpcid/Makefile b/tools/xlpcid/Makefile new file mode 100644 index 0000000000..238b6ef02f --- /dev/null +++ b/tools/xlpcid/Makefile @@ -0,0 +1,52 @@ +# +# tools/xlpcid/Makefile +# + +XEN_ROOT = $(CURDIR)/../.. +include $(XEN_ROOT)/tools/Rules.mk + +CFLAGS += -Wno-format-zero-length -Wmissing-declarations \ + -Wno-declaration-after-statement -Wformat-nonliteral +CFLAGS += -fPIC + +CFLAGS += $(PTHREAD_CFLAGS) +LDFLAGS += $(PTHREAD_LDFLAGS) + +CFLAGS_XLPCID += $(CFLAGS_libxenlight) +CFLAGS_XLPCID += $(CFLAGS_libxenutil) +CFLAGS_XLPCID += -Wshadow +CFLAGS_XLPCID += $(CFLAGS_libxenvchan) + +#XL_OBJS-$(CONFIG_X86) = xl_psr.o +XLPCID_OBJS = xlpcid.o $(XLPCID_OBJS-y) + +$(XLPCID_OBJS): CFLAGS += $(CFLAGS_libxentoollog) +$(XLPCID_OBJS): CFLAGS += $(CFLAGS_XLPCID) +$(XLPCID_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs it. + +.PHONY: all +all: xlpcid + +xlpcid: $(XLPCID_OBJS) + $(CC) $(LDFLAGS) -o $@ $(XLPCID_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) + +.PHONY: install +install: all + $(INSTALL_DIR) $(DESTDIR)$(sbindir) + $(INSTALL_DIR) $(DESTDIR)$(BASH_COMPLETION_DIR) + $(INSTALL_PROG) xlpcid $(DESTDIR)$(sbindir) + $(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xlpcid + +.PHONY: uninstall +uninstall: + rm -f $(DESTDIR)$(BASH_COMPLETION_DIR)/xlpcid + rm -f $(DESTDIR)$(sbindir)/xlpcid + +.PHONY: clean +clean: + $(RM) *.o xlpcid $(DEPS_RM) + +distclean: clean + + +-include $(DEPS_INCLUDE) diff --git a/tools/xlpcid/bash-completion b/tools/xlpcid/bash-completion new file mode 100644 index 0000000000..578ef38b9f --- /dev/null +++ b/tools/xlpcid/bash-completion @@ -0,0 +1,20 @@ +# Copy this file to /etc/bash_completion.d/xl + +_xlpcid() +{ + local IFS=$'\n,' + + local cur opts xlpcid + COMPREPLY=() + cur="${COMP_WORDS[COMP_CWORD]}" + xlpcid=xlpcid + + if [[ $COMP_CWORD == 1 ]] ; then + opts=`${xlpcid} help 2>/dev/null | sed '1,4d' | awk '/^ [^ ]/ {print $1}' | sed 's/$/ ,/g'` && COMPREPLY=( $(compgen -W "${opts}" -- ${cur}) ) + return 0 + fi + + return 0 +} + +complete -F _xlpcid -o nospace -o default xlpcid diff --git a/tools/xlpcid/xlpcid.c b/tools/xlpcid/xlpcid.c new file mode 100644 index 0000000000..cb5804341d --- /dev/null +++ b/tools/xlpcid/xlpcid.c @@ -0,0 +1,213 @@ +/* + Pcid daemon that acts as a server for the client in the libxl PCI + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include +#include + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +libxl_ctx *ctx; +xentoollog_logger_stdiostream *logger; +libxl_bitmap global_vm_affinity_mask; +libxl_bitmap global_hvm_affinity_mask; +libxl_bitmap global_pv_affinity_mask; +char *lockfile; +int logfile; + +static void help(void) +{ + fprintf(stderr, "Usage xlpcid [-ftTvp]\n") + fprintf(stderr, " --foreground - run in foreground mode\n"); + fprintf(stderr, " --pidfile - specify pid file\n"); + fprintf(stderr, " -t - Always use carriage-return-based overwriting\n"); + fprintf(stderr, " for displaying progress messages without scrolling\n"); + fprintf(stderr, " the screen. Without -t, this is done only if stderr is a tty.\n"); + fprintf(stderr, " -T - Include timestamps and pid of the xl process in output.\n"); + fprintf(stderr, " -v - Verbose\n"); +} + +static void xlpcid_ctx_alloc(void) +{ + if (libxl_ctx_alloc(&ctx, LIBXL_VERSION, 0, (xentoollog_logger*)logger)) { + fprintf(stderr, "cannot init xl context\n"); + exit(1); + } + + libxl_bitmap_init(&global_vm_affinity_mask); + libxl_bitmap_init(&global_hvm_affinity_mask); + libxl_bitmap_init(&global_pv_affinity_mask); +} + +static void xlpcid_ctx_free(void) +{ + libxl_bitmap_dispose(&global_pv_affinity_mask); + libxl_bitmap_dispose(&global_hvm_affinity_mask); + libxl_bitmap_dispose(&global_vm_affinity_mask); + if (ctx) { + libxl_ctx_free(ctx); + ctx = NULL; + } + if (logger) { + xtl_logger_destroy((xentoollog_logger*)logger); + logger = NULL; + } + if (lockfile) { + free(lockfile); + lockfile = NULL; + } +} + +static int do_daemonize(const char *name, const char *pidfile) +{ + char *fullname; + int nullfd, ret = 0; + + ret = libxl_create_logfile(ctx, name, &fullname); + if (ret) { + fprintf(stderr, "Failed to open logfile %s: %s", fullname, strerror(errno)); + exit(-1); + } + + logfile = open(fullname, O_WRONLY|O_CREAT|O_APPEND, 0644); + free(fullname); + assert(logfile >= 3); + + nullfd = open("/dev/null", O_RDONLY); + assert(nullfd >= 3); + + dup2(nullfd, 0); + dup2(logfile, 1); + dup2(logfile, 2); + + close(nullfd); + + if (daemon(0, 1)) { + perror("daemon"); + close(logfile); + return 1; + } + + if (pidfile) { + int fd = open(pidfile, O_RDWR | O_CREAT, S_IRUSR|S_IWUSR); + char *pid = NULL; + + if (fd == -1) { + perror("Unable to open pidfile"); + exit(1); + } + + if (asprintf(&pid, "%ld\n", (long)getpid()) == -1) { + perror("Formatting pid"); + exit(1); + } + + if (write(fd, pid, strlen(pid)) < 0) { + perror("Writing pid"); + exit(1); + } + + if (close(fd) < 0) { + perror("Closing pidfile"); + exit(1); + } + + free(pid); + } + + return ret; +} + +int main(int argc, char *argv[]) +{ + int opt = 0, daemonize = 1, ret = 0; + const char *pidfile = NULL; + unsigned int xtl_flags = 0; + bool progress_use_cr = 0; + bool timestamps = 0; + xentoollog_level minmsglevel = XTL_PROGRESS; + static const struct option opts[] = { + {"pidfile", 1, 0, 'p'}, + {"foreground", 0, 0, 'f'}, + {"help", 0, 0, 'h'}, + {0, 0, 0, 0} + }; + + while ((opt = getopt_long(argc, argv, "hftTvp:", opts, NULL)) != -1) + switch (opt) { + case 'f': + daemonize = 0; + break; + case 'p': + pidfile = optarg; + break; + case 't': + timestamps = 1; + break; + case 'T': + progress_use_cr = 1; + break; + case 'v': + if (minmsglevel > 0) + minmsglevel--; + break; + case 'h': + help(); + exit(1); + break; + default: + fprintf(stderr, "Unknown option '%c'\n", opt); + break; + } + + if (progress_use_cr) + xtl_flags |= XTL_STDIOSTREAM_PROGRESS_USE_CR; + if (timestamps) + xtl_flags |= XTL_STDIOSTREAM_SHOW_DATE | XTL_STDIOSTREAM_SHOW_PID; + logger = xtl_createlogger_stdiostream(stderr, minmsglevel, xtl_flags); + if (!logger) + exit(EXIT_FAILURE); + + xlpcid_ctx_alloc(); + + if (daemonize) { + ret = do_daemonize("xlpcid", pidfile); + if (ret) { + ret = (ret == 1) ? 0 : ret; + goto out_daemon; + } + } + + libxl_pcid_process(ctx); + +out_daemon: + xlpcid_ctx_free(); + exit(ret); +} -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492673.762354 (Exim 4.92) (envelope-from ) id 1pQ9Hn-0007a3-KQ; Thu, 09 Feb 2023 15:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492673.762354; Thu, 09 Feb 2023 15:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hn-0007Zd-Bo; Thu, 09 Feb 2023 15:56:35 +0000 Received: by outflank-mailman (input) for mailman id 492673; Thu, 09 Feb 2023 15:56:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hl-0006cl-6Z for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:33 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 520f343b-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:31 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id p26so7634464ejx.13 for ; Thu, 09 Feb 2023 07:56:31 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 520f343b-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmsCcMttxSYbw0pYCwcBt+l3AXaiynpdRsxaUXNJnFU=; b=XlEv70xEZXanGY83K7ttIqvpYBScKUNktKlPY0TNVpppood+1d70q32NBmaUYCy6xQ IJZJDYIGMDxk3Sz3N0xiPTxYAvvvPlpcE+sbvFM20PoyVmGKjD3uIteiWuP185Ik2zfz 4Gh/UxZIUiYLPx0kdolsndd04+fF6D1pf6pVlz3tK2TtVHteHdiktzYGbZu9m56augmo JKc3fEsqOzbnnbmXS2i33e8W+vSigVQlkGM3KANhXkeYST6ucrbNjfS3oo8Nd36NqM9m mlQqVuWBScq3/QbX7W08CGCMqRG8WYCmQNrJI38yI+2LIL9NSRW0i39EyAFFsJlsE/pC PTWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmsCcMttxSYbw0pYCwcBt+l3AXaiynpdRsxaUXNJnFU=; b=szxVtd4RypTbUejWpQEBk+3DALJfn/xz/ILY6Q7Y3fzEgiaazQiDJzxW3Ekj0woPFX pHjnhxOdc/ceBDcAGgymjKhashFkB5lUiAeGqT/LoIfKDNnQVJ4/BlVoDszvmKhoXAWL y2ofoRIlXhllCv0WLmb6zQlGJdJM3CJQooEH7REkAeKz7kfe30cCINQcRrM6xKCgOSzX ac+ObPtchRg8QI4qS+NkXAEc8xhRtC4nKWs9JW9RmAhqspbCi2y8HI6xb6QAIOTWgsbd G5D8fwAbls/23WIHWMVID4WYgNGwnwsnFsowuEcD6TVD8YWEvmTdz9Y8UItxs2UA4n58 lHoQ== X-Gm-Message-State: AO0yUKU+lyfDBSmoDgYSw3APkRmSep9ewYQs4ZVbq//2QKYSF733JT1X GV2hqKsXEQ6f0KLcYsbASLodubuegtQntA== X-Google-Smtp-Source: AK7set9WOPbNmChLMlaNwilvjNpmtQqdh0PqIIhGzFj9tr3YfvIYFxIiBolR11n0JK/CIL1A6ly3XA== X-Received: by 2002:a17:906:5185:b0:8ae:ea08:3842 with SMTP id y5-20020a170906518500b008aeea083842mr5504778ejk.7.1675958190806; Thu, 09 Feb 2023 07:56:30 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross , Oleksandr Andrushchenko Subject: [RFC PATCH v4 4/9] tools/libs/light: pcid: implement list_assignable command Date: Thu, 9 Feb 2023 17:55:58 +0200 Message-Id: <20230209155604.2753219-5-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets --- tools/include/xen-pcid.h | 19 ++++++++++++ tools/libs/light/libxl_pci.c | 54 ++++++++++++++++++++++----------- tools/libs/light/libxl_pcid.c | 56 ++++++++++++++++++++++++++++++----- 3 files changed, 103 insertions(+), 26 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index 098118a0c3..6a5724363d 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -80,6 +80,25 @@ #define PCID_SBDF_FMT "%04x:%02x:%02x.%01x" +/* + ******************************************************************************* + * List assignable devices + * + * This command lists PCI devices that can be passed through to a guest domain. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "list_assignable". + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "list_assignable". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | devices | list | List of of pci_device objects | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_LIST_ASSIGNABLE "list_assignable" +#define PCID_MSG_FIELD_DEVICES "devices" + int libxl_pcid_process(libxl_ctx *ctx); #endif /* XEN_PCID_H */ diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 3d9ed0d50c..c4b04ccb92 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -29,6 +29,18 @@ #define PCI_BDF_XSPATH "%04x-%02x-%02x-%01x" #define PCI_PT_QDEV_ID "pci-pt-%02x_%02x.%01x" +static int process_list_assignable(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_DEVICES, + response, JSON_ARRAY); + if (!*result) + return ERROR_INVAL; + + return 0; +} + static int pci_handle_response(libxl__gc *gc, const libxl__json_object *response, libxl__json_object **result) @@ -68,6 +80,9 @@ static int pci_handle_response(libxl__gc *gc, command_name = command_obj->u.string; LOG(DEBUG, "command: %s", command_name); + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, response, result); + return ret; } @@ -124,8 +139,7 @@ static char *pci_prepare_request(libxl__gc *gc, yajl_gen gen, char *cmd, return request; } -struct vchan_info *pci_vchan_get_client(libxl__gc *gc); -struct vchan_info *pci_vchan_get_client(libxl__gc *gc) +static struct vchan_info *pci_vchan_get_client(libxl__gc *gc) { struct vchan_info *vchan; @@ -147,8 +161,7 @@ out: return vchan; } -void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan); -void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan) +static void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan) { vchan_fini_one(gc, vchan->state); } @@ -561,26 +574,29 @@ libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) { GC_INIT(ctx); libxl_device_pci *pcis = NULL, *new; - struct dirent *de; - DIR *dir; + struct vchan_info *vchan; + libxl__json_object *result, *dev_obj; + int i; *num = 0; - dir = opendir(SYSFS_PCIBACK_DRIVER); - if (NULL == dir) { - if (errno == ENOENT) { - LOG(ERROR, "Looks like pciback driver not loaded"); - } else { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER); - } + vchan = pci_vchan_get_client(gc); + if (!vchan) goto out; - } - while((de = readdir(dir))) { + result = vchan_send_command(gc, vchan, PCID_CMD_LIST_ASSIGNABLE, NULL); + if (!result) + goto vchan_free; + + for (i = 0; (dev_obj = libxl__json_array_get(result, i)); i++) { + const char *sbdf_str = libxl__json_object_get_string(dev_obj); unsigned int dom, bus, dev, func; - char *name; + const char *name; + + if (!sbdf_str) + continue; - if (sscanf(de->d_name, PCI_BDF, &dom, &bus, &dev, &func) != 4) + if (sscanf(sbdf_str, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) continue; new = realloc(pcis, ((*num) + 1) * sizeof(*new)); @@ -602,7 +618,9 @@ libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) (*num)++; } - closedir(dir); +vchan_free: + pci_vchan_free(gc, vchan); + out: GC_FREE; return pcis; diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 2ce8f1504d..8dfccc439d 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -84,6 +84,41 @@ static int make_error_reply(libxl__gc *gc, yajl_gen gen, char *desc, return 0; } +static int process_list_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct dirent *de; + DIR *dir = NULL; + + dir = opendir(SYSFS_PCI_DEV); + if (dir == NULL) { + make_error_reply(gc, gen, strerror(errno), command_name); + return ERROR_FAIL; + } + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_DEVICES); + + *response = libxl__json_object_alloc(gc, JSON_ARRAY); + + while ((de = readdir(dir))) { + unsigned int dom, bus, dev, func; + + if (sscanf(de->d_name, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) + continue; + + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + node->u.string = de->d_name; + flexarray_append((*response)->u.array, node); + } + + closedir(dir); + + return 0; +} + static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, const libxl__json_object *request) { @@ -104,14 +139,19 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, command_name = command_obj->u.string; - /* - * This is an unsupported command: make a reply and proceed over - * the error path. - */ - ret = make_error_reply(gc, gen, "Unsupported command", - command_name); - if (!ret) - ret = ERROR_NOTFOUND; + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, gen, command_name, + request, &command_response); + else { + /* + * This is an unsupported command: make a reply and proceed over + * the error path. + */ + ret = make_error_reply(gc, gen, "Unsupported command", + command_name); + if (!ret) + ret = ERROR_NOTFOUND; + } if (ret) { /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492676.762359 (Exim 4.92) (envelope-from ) id 1pQ9Ho-0007gM-1j; Thu, 09 Feb 2023 15:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492676.762359; Thu, 09 Feb 2023 15:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hn-0007eU-Sm; Thu, 09 Feb 2023 15:56:35 +0000 Received: by outflank-mailman (input) for mailman id 492676; Thu, 09 Feb 2023 15:56:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hm-0007Ak-AH for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:34 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53603fd5-a892-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:56:33 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id l12so2559643edb.0 for ; Thu, 09 Feb 2023 07:56:33 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53603fd5-a892-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/WzhJP9vhJfuiyyeXqbJkYqC2dcjt2F4IfvVYqlat9I=; b=RbS+SRI0DAe2NW3ljtd+w56OHWnEQ0kuZADvIx4vdHTld72mZdDC3W5dzvB12y9iv9 AHt/Ave5j/NWiQTXGZHMuuP2n+PlxxySMDWSI+DwUoPyi63O6nofra2XV2MqgveFRaR1 +J84hurhWYxdgnlAfMBEAZ/KwZwVrqj/tpaXko2/oWpNtnQNd607WurF1qxoV3sZbAud WSBCKcpHCUY/gneQj9/z3c+JRxn7Ik8jK+c/iKOZ3fIq2nJCOnocz8YEUEoyElgHREyg HtFESFV952blNkHsUCqJZGs7w3N/mkT/rmw3J340qpam21S93yfHJzZJrmxZfS0jIX6N N/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/WzhJP9vhJfuiyyeXqbJkYqC2dcjt2F4IfvVYqlat9I=; b=SfxuPy10RjZs0F/N631heSOiuLIFFRpqNNeabiXyURa3QbeOxA3cSj/vRKiDYENOGh EuzGmYt1KAXrxKbQ1fotP06sLk1nXA2TtUB8gSCnUzHR1VmpTi4yiFzHnsfa2xFt0Z2P EnGzckJkHUmMlCLIOo/zpKAC9C8aWkUh0zY6Kdi0RaLfEXIUTkiQYvMY6p4agzf16l97 4Skv8/tYS0xhwPXdPTIfLWAJE9aA6SwO9vlagTGoTjZWXKIB4coyuhQ8FmGTXL/y8KLl kdm7FxH2Ipp08nE3cKBStbXPbIxMylDLKrMgkm/qLOFRmc1mxGmRYYSxQ9fATco8yl2I 1jIQ== X-Gm-Message-State: AO0yUKW0xtcsRCnjvWGakKo2+0H5oViXGUNSyokF7pRxb+eJkrRAsP7k EQpFeLh5GFasqHdeQdjXe+M+1+nYWC15Vg== X-Google-Smtp-Source: AK7set8X2pu/O+NwWpgWtYA7j/136tsDHLByBf2Zdygp1XeRwKhHiRrK2eba1uzSt8xRbY1PBn4POg== X-Received: by 2002:a05:6402:268b:b0:4a2:2e9e:c2ec with SMTP id w11-20020a056402268b00b004a22e9ec2ecmr14461550edd.4.1675958192956; Thu, 09 Feb 2023 07:56:32 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 6/9] tools/libs/light: pcid: implement is_device_assigned command Date: Thu, 9 Feb 2023 17:56:00 +0200 Message-Id: <20230209155604.2753219-7-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Signed-off-by: Dmytro Semenets --- tools/include/xen-pcid.h | 19 ++++++++++++++++ tools/libs/light/libxl_pci.c | 43 +++++++++++++++++++---------------- tools/libs/light/libxl_pcid.c | 34 ++++++++++++++++++++++++++- 3 files changed, 75 insertions(+), 21 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index 5e96b8de6e..843066a54c 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -136,6 +136,25 @@ */ #define PCID_CMD_REVERT_ASSIGNABLE "revert_assignable" +/* + ******************************************************************************* + * Check is device assigned + * + * This command checks device is assigned + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "is_device_assigned". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "is_device_assigned". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | result | bool | true if device assigned | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_IS_ASSIGNED "is_device_assigned" +#define PCID_MSG_FIELD_RESULT "result" int libxl_pcid_process(libxl_ctx *ctx); diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index b3dfd95fd3..841b97172d 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -86,7 +86,9 @@ static int pci_handle_response(libxl__gc *gc, *result = libxl__json_object_alloc(gc, JSON_NULL); else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) *result = libxl__json_object_alloc(gc, JSON_NULL); - + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESULT, + response, JSON_BOOL); return ret; } @@ -753,30 +755,31 @@ bool libxl__is_igd_vga_passthru(libxl__gc *gc, static int pciback_dev_is_assigned(libxl__gc *gc, libxl_device_pci *pci) { - char * spath; + struct vchan_info *vchan; int rc; - struct stat st; + libxl__json_object *args, *result; - if ( access(SYSFS_PCIBACK_DRIVER, F_OK) < 0 ) { - if ( errno == ENOENT ) { - LOG(ERROR, "Looks like pciback driver is not loaded"); - } else { - LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); - } - return -1; + vchan = pci_vchan_get_client(gc); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, - pci->domain, pci->bus, - pci->dev, pci->func); - rc = lstat(spath, &st); + args = libxl__vchan_start_args(gc); - if( rc == 0 ) - return 1; - if ( rc < 0 && errno == ENOENT ) - return 0; - LOGE(ERROR, "Accessing %s", spath); - return -1; + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + + result = vchan_send_command(gc, vchan, PCID_CMD_IS_ASSIGNED, args); + if (!result) { + rc = ERROR_FAIL; + } + rc = result->u.b; + pci_vchan_free(gc, vchan); + +out: + return rc; } static int libxl__device_pci_assignable_add(libxl__gc *gc, diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 5e1e41feb5..7b6c7fe6a6 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -147,7 +147,7 @@ static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, if (rc < 0 && errno == ENOENT) return 0; LOGE(ERROR, "Accessing %s", spath); - return -1; + return 0; } #define PCID_INFO_PATH "pcid" @@ -335,6 +335,35 @@ static int pciback_dev_assign(libxl__gc *gc, unsigned int domain, return 0; } +static int process_pciback_dev_is_assigned(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESULT); + *response = libxl__json_object_alloc(gc, JSON_BOOL); + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + (*response)->u.b = rc; + return 0; +} + static int process_make_assignable(libxl__gc *gc, yajl_gen gen, char *command_name, const struct libxl__json_object *request, @@ -538,6 +567,9 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) ret = process_revert_assignable(gc, gen, command_name, request, &command_response); + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + ret = process_pciback_dev_is_assigned(gc, gen, command_name, + request, &command_response); else { /* * This is an unsupported command: make a reply and proceed over -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492677.762368 (Exim 4.92) (envelope-from ) id 1pQ9Ho-0007qk-NV; Thu, 09 Feb 2023 15:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492677.762368; Thu, 09 Feb 2023 15:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Ho-0007nh-El; Thu, 09 Feb 2023 15:56:36 +0000 Received: by outflank-mailman (input) for mailman id 492677; Thu, 09 Feb 2023 15:56:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hn-0007Ak-Cl for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:35 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53ffdf13-a892-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:56:34 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id lu11so7732123ejb.3 for ; Thu, 09 Feb 2023 07:56:34 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53ffdf13-a892-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hqOdci0RnBqfM9zuF9NcrL5pTTcWWQ4ya+aJqtMi5ro=; b=KQTeOkBryB2Q8oZq5V1y4TlLeWD66B8FECePbXBBby9JLo4VuAk856HunjSpdJaKMU lZsB1d0mk7aghoHYPjZ4vDJ3hfInS2J5/I2e7NYut68prIHrSAsAOvGrwnP6PDJWGKTD dWfH5j03UBrsFxbP8xguXINWV05au4EpUFCMY7HuQ5yLOVhdNiEU6cQdeLmmC/SypO7D iPXF01qMycAZgo/4qgLjIYy6gRcfC86ekJulvV7UpJCi1z8VW2djKpoXL/5Ya7UEy4Ge TPgNYatHxQp9mUuZtiA5qDW4cjVzHmy+QOSPTXJ+j6xzscLt3J0ygTsvD/EnFFj24afN YkTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hqOdci0RnBqfM9zuF9NcrL5pTTcWWQ4ya+aJqtMi5ro=; b=NoWbTutExY9HiBS6LWNaQf8iW/06QCmB+TUdfiQ4fbOGSRaU9Qbq6zmisGUzcU4Fie XywC4tvyk8e2u94MjfcYRlrFIHz82q/mxyYXEqg2FegLK2/w2mbQ5qTtq16v3rd2hcgB gQVsS4aiKBIjonk9G+SFxzDoBpBY5kWDkrV2rAq5RztwcOU2ilj+nmR8TuSjGZMy0W7E 6IXLeSCwoZwJoIJ5UIBaidiyThHCi6/e1DGER+dsL7GnPsOGIkjv9a7KSIKE5w2IzqVX xlpBDzXcbps1sZu30Maf6dCI3EiFsSkl83lUi5+duUmWGa1+9moYsC/2dZyYEkAaAiEj jngA== X-Gm-Message-State: AO0yUKWZPVnht7F9wonUYI8eC5ePmTKVAiDJrMFQlGOHwrCdFiaC2KQD w2fjtJCMSygy3ilLYReMJdAuCCBvORGnbg== X-Google-Smtp-Source: AK7set8b/9mmAz5+IWSOO/j4AOTz5RYR51wseZ5L3zVSGxCuVqTqhs2WxC4zTSOAJxwdKL4In7fRcg== X-Received: by 2002:a17:906:1011:b0:8af:11b5:fabd with SMTP id 17-20020a170906101100b008af11b5fabdmr5210562ejm.5.1675958194017; Thu, 09 Feb 2023 07:56:34 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 7/9] tools/libs/light: pcid: implement reset_device command Date: Thu, 9 Feb 2023 17:56:01 +0200 Message-Id: <20230209155604.2753219-8-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Signed-off-by: Dmytro Semenets --- tools/include/xen-pcid.h | 15 ++++++++ tools/libs/light/libxl_pci.c | 52 +++++++++++---------------- tools/libs/light/libxl_pcid.c | 66 +++++++++++++++++++++++++++++++++++ 3 files changed, 102 insertions(+), 31 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index 843066a54c..65be441250 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -156,6 +156,21 @@ #define PCID_CMD_IS_ASSIGNED "is_device_assigned" #define PCID_MSG_FIELD_RESULT "result" +/* + ******************************************************************************* + * Reset PCI device + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "reset_device". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "reset_device". + */ +#define PCID_CMD_RESET_DEVICE "reset_device" + int libxl_pcid_process(libxl_ctx *ctx); #endif /* XEN_PCID_H */ diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 841b97172d..e920a1fa4b 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -89,6 +89,8 @@ static int pci_handle_response(libxl__gc *gc, else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESULT, response, JSON_BOOL); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); return ret; } @@ -1518,38 +1520,26 @@ out: static int libxl__device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, unsigned int dev, unsigned int func) { - char *reset; - int fd, rc; - - reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); - rc = write(fd, buf, strlen(buf)); - if (rc < 0) - LOGD(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno != ENOENT) - LOGED(ERROR, domain, "Failed to access pciback path %s", reset); - reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - rc = write(fd, "1", 1); - if (rc < 0) - LOGED(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno == ENOENT) { - LOGD(ERROR, domain, - "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, - domain, bus, dev, func); - } else { - LOGED(ERROR, domain, "Failed to access reset path %s", reset); + struct vchan_info *vchan; + int rc = 0; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - return -1; + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, domain, bus, dev, func)); + result = vchan_send_command(gc, vchan, PCID_CMD_RESET_DEVICE, args); + if (!result) + rc = ERROR_FAIL; + pci_vchan_free(gc, vchan); + + out: + return rc; } int libxl__device_pci_setdefault(libxl__gc *gc, uint32_t domid, diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 7b6c7fe6a6..05c0b69324 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -364,6 +364,69 @@ static int process_pciback_dev_is_assigned(libxl__gc *gc, yajl_gen gen, return 0; } +static int device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + char *reset; + int fd, rc; + + reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + if (rc < 0) + LOGD(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno != ENOENT) + LOGED(ERROR, domain, "Failed to access pciback path %s", reset); + reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + rc = write(fd, "1", 1); + if (rc < 0) + LOGED(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno == ENOENT) { + LOGD(ERROR, domain, + "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, + domain, bus, dev, func); + } else { + LOGED(ERROR, domain, "Failed to access reset path %s", reset); + } + return -1; +} + +static int process_device_pci_reset(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = device_pci_reset(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + return rc; +} + static int process_make_assignable(libxl__gc *gc, yajl_gen gen, char *command_name, const struct libxl__json_object *request, @@ -570,6 +633,9 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) ret = process_pciback_dev_is_assigned(gc, gen, command_name, request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + ret = process_device_pci_reset(gc, gen, command_name, + request, &command_response); else { /* * This is an unsupported command: make a reply and proceed over -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492678.762375 (Exim 4.92) (envelope-from ) id 1pQ9Hp-00081W-Aj; Thu, 09 Feb 2023 15:56:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492678.762375; Thu, 09 Feb 2023 15:56:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Ho-0007yN-VO; Thu, 09 Feb 2023 15:56:36 +0000 Received: by outflank-mailman (input) for mailman id 492678; Thu, 09 Feb 2023 15:56:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hn-0006cl-8z for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:35 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52e438b2-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:32 +0100 (CET) Received: by mail-ej1-x630.google.com with SMTP id jg8so7713077ejc.6 for ; Thu, 09 Feb 2023 07:56:32 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52e438b2-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iDSIcL+mVhfPXUiOzfh6UyHDqJq2g2EiKPGtIhsGJug=; b=Tsv1J0SIn2AQiBfOIN4Zx1VU1h6vO/6e70o2ZhUZs1UiNXjuI/zPs7jf4dClIGaS8t l85GPQopTZuCo2FHS+b1lalYeHUlQ4ie6cA+jlbzjVs+Lb3duAjyldyKv1SFo5wWoXk2 Pw//cSTqS+xhdEWjGLqNMfRPjX5JmZiQQbF861Ehqu7BWobMCTrwlBFpha8ZHOPoMWmX PN3YF+W5vS8S24dHFVllwRDKLunUzuk8BYmK20XY4Xtm1O7Od3Clx4Tqi3V9bPHd0vnU SiJVvMLv2Ae3QpDVNauzbWu+g7v3swyVM9oafKHSjr/dE5LNa7TW7Fg2Ipv4jAc1IUTh 3f9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iDSIcL+mVhfPXUiOzfh6UyHDqJq2g2EiKPGtIhsGJug=; b=waTH0u9x/p8oupDs6YEUJ8G8AnlUR4F6+6I3orO2Kgl0czTcU5ABpp4YWZ9QTs3lfq 5dte2vA8imvWI5KgYl7ztQvDCFWGe20vXZ7JJI/a+wL3SWzTXtTxObDWsUoQ5LKWsZa3 mhhakWVldEfaphVgSt5+sGKP6fBiGfxpT86Rcb0ZdutdzYaSBST2mjkQ6cRqELhqXI4Y wDmz7hzJw2mfmaYpTMLC2qAeZa1E+p5wCC27tOPYT8jxeWXhuiUSSHRld8/8fmKMQzLD gCT13grUtCb9nBhRdo/RgGSEjOHoME65n+ocoJWnMpwEpDEkzmnJ7oJiBtaUtNhkLQ0F 5gfQ== X-Gm-Message-State: AO0yUKU/oQ6fO+xJ5n7nNvWTZtu1fQXqBUkf4GikTVRyTrRlKJ35I9FA LJUqpM116qy1Zu46xQS+oQiPMaTk0OzCfA== X-Google-Smtp-Source: AK7set9QCgZKoZwqmEPnbSoTdDC1nIasulaWiBEwtR3KAzfx+GskGsW+KyFfVuWD/lcbAarUsjLZeg== X-Received: by 2002:a17:906:5307:b0:88f:1255:59c with SMTP id h7-20020a170906530700b0088f1255059cmr9552033ejo.1.1675958191909; Thu, 09 Feb 2023 07:56:31 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Volodymyr Babchuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 5/9] tools/light: pci: move assign/revert logic to pcid Date: Thu, 9 Feb 2023 17:55:59 +0200 Message-Id: <20230209155604.2753219-6-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Volodymyr Babchuk Implement commands MAKE_ASSIGNABLE and REVERT_ASSIGNABLE in pcid in the same way as they were implemented in libxl_pci.c Replace original logic in libxl_pci.c by calling appropriate functions from pcid. This is quite huge patch, as lots of code were moved from lixbl_pci.c to libxl_pcid.c. Signed-off-by: Volodymyr Babchuk --- tools/include/xen-pcid.h | 38 ++++ tools/libs/light/libxl_pci.c | 292 +++++-------------------- tools/libs/light/libxl_pcid.c | 396 ++++++++++++++++++++++++++++++++++ 3 files changed, 492 insertions(+), 234 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index 6a5724363d..5e96b8de6e 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -99,6 +99,44 @@ #define PCID_CMD_LIST_ASSIGNABLE "list_assignable" #define PCID_MSG_FIELD_DEVICES "devices" +/* + ******************************************************************************* + * Make device assignable + * + * This command makes given device assignable by ensuring that OS + * will not try to access it. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "make_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to save original driver name, + * so device later can be rebound back. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "make_assignable". + */ +#define PCID_CMD_MAKE_ASSIGNABLE "make_assignable" +#define PCID_MSG_FIELD_REBIND "rebind" + +/* + ******************************************************************************* + * Revert device from assignable state + * + * This command reverts effect of "make_assignable" command. Basically, + * now device can be used by OS again. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "revert_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to rebind device back to it's + * original driver, which name was saved by "make_assignable" command + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "revert_assignable". + */ +#define PCID_CMD_REVERT_ASSIGNABLE "revert_assignable" + + int libxl_pcid_process(libxl_ctx *ctx); #endif /* XEN_PCID_H */ diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index c4b04ccb92..b3dfd95fd3 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -82,6 +82,10 @@ static int pci_handle_response(libxl__gc *gc, if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) ret = process_list_assignable(gc, response, result); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); return ret; } @@ -636,44 +640,6 @@ void libxl_device_pci_assignable_list_free(libxl_device_pci *list, int num) free(list); } -/* Unbind device from its current driver, if any. If driver_path is non-NULL, - * store the path to the original driver in it. */ -static int sysfs_dev_unbind(libxl__gc *gc, libxl_device_pci *pci, - char **driver_path) -{ - char * spath, *dp = NULL; - struct stat st; - - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", - pci->domain, - pci->bus, - pci->dev, - pci->func); - if ( !lstat(spath, &st) ) { - /* Find the canonical path to the driver. */ - dp = libxl__zalloc(gc, PATH_MAX); - dp = realpath(spath, dp); - if ( !dp ) { - LOGE(ERROR, "realpath() failed"); - return -1; - } - - LOG(DEBUG, "Driver re-plug path: %s", dp); - - /* Unbind from the old driver */ - spath = GCSPRINTF("%s/unbind", dp); - if ( sysfs_write_bdf(gc, spath, pci) < 0 ) { - LOGE(ERROR, "Couldn't unbind device"); - return -1; - } - } - - if ( driver_path ) - *driver_path = dp; - - return 0; -} - static uint16_t sysfs_dev_get_vendor(libxl__gc *gc, libxl_device_pci *pci) { char *pci_device_vendor_path = @@ -785,49 +751,6 @@ bool libxl__is_igd_vga_passthru(libxl__gc *gc, return false; } -/* - * A brief comment about slots. I don't know what slots are for; however, - * I have by experimentation determined: - * - Before a device can be bound to pciback, its BDF must first be listed - * in pciback/slots - * - The way to get the BDF listed there is to write BDF to - * pciback/new_slot - * - Writing the same BDF to pciback/new_slot is not idempotent; it results - * in two entries of the BDF in pciback/slots - * It's not clear whether having two entries in pciback/slots is a problem - * or not. Just to be safe, this code does the conservative thing, and - * first checks to see if there is a slot, adding one only if one does not - * already exist. - */ - -/* Scan through /sys/.../pciback/slots looking for pci's BDF */ -static int pciback_dev_has_slot(libxl__gc *gc, libxl_device_pci *pci) -{ - FILE *f; - int rc = 0; - unsigned dom, bus, dev, func; - - f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); - - if (f == NULL) { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); - return ERROR_FAIL; - } - - while (fscanf(f, "%x:%x:%x.%d\n", &dom, &bus, &dev, &func) == 4) { - if (dom == pci->domain - && bus == pci->bus - && dev == pci->dev - && func == pci->func) { - rc = 1; - goto out; - } - } -out: - fclose(f); - return rc; -} - static int pciback_dev_is_assigned(libxl__gc *gc, libxl_device_pci *pci) { char * spath; @@ -856,133 +779,34 @@ static int pciback_dev_is_assigned(libxl__gc *gc, libxl_device_pci *pci) return -1; } -static int pciback_dev_assign(libxl__gc *gc, libxl_device_pci *pci) -{ - int rc; - - if ( (rc = pciback_dev_has_slot(gc, pci)) < 0 ) { - LOGE(ERROR, "Error checking for pciback slot"); - return ERROR_FAIL; - } else if (rc == 0) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - } - - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - return 0; -} - -static int pciback_dev_unassign(libxl__gc *gc, libxl_device_pci *pci) -{ - /* Remove from pciback */ - if ( sysfs_dev_unbind(gc, pci, NULL) < 0 ) { - LOG(ERROR, "Couldn't unbind device!"); - return ERROR_FAIL; - } - - /* Remove slot if necessary */ - if ( pciback_dev_has_slot(gc, pci) > 0 ) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't remove pciback slot"); - return ERROR_FAIL; - } - } - return 0; -} - static int libxl__device_pci_assignable_add(libxl__gc *gc, libxl_device_pci *pci, int rebind) { libxl_ctx *ctx = libxl__gc_owner(gc); - unsigned dom, bus, dev, func; - char *spath, *driver_path = NULL; - const char *name; + struct vchan_info *vchan; int rc; - struct stat st; - - /* Local copy for convenience */ - dom = pci->domain; - bus = pci->bus; - dev = pci->dev; - func = pci->func; - name = pci->name; - - /* Sanitise any name that is set */ - if (name) { - unsigned int i, n = strlen(name); + libxl__json_object *args, *result; - if (n > 64) { /* Reasonable upper bound on name length */ - LOG(ERROR, "Name too long"); - return ERROR_FAIL; - } - - for (i = 0; i < n; i++) { - if (!isgraph(name[i])) { - LOG(ERROR, "Names may only include printable characters"); - return ERROR_FAIL; - } - } - } - - /* See if the device exists */ - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); - if ( lstat(spath, &st) ) { - LOGE(ERROR, "Couldn't lstat %s", spath); - return ERROR_FAIL; - } - - /* Check to see if it's already assigned to pciback */ - rc = pciback_dev_is_assigned(gc, pci); - if ( rc < 0 ) { - return ERROR_FAIL; - } - if ( rc ) { - LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); - goto name; + vchan = pci_vchan_get_client(gc); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Check to see if there's already a driver that we need to unbind from */ - if ( sysfs_dev_unbind(gc, pci, &driver_path ) ) { - LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", - dom, bus, dev, func); - return ERROR_FAIL; - } + args = libxl__vchan_start_args(gc); - /* Store driver_path for rebinding to dom0 */ - if ( rebind ) { - if ( driver_path ) { - pci_info_xs_write(gc, pci, "driver_path", driver_path); - } else if ( (driver_path = - pci_info_xs_read(gc, pci, "driver_path")) != NULL ) { - LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", - dom, bus, dev, func, driver_path); - } else { - LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", - dom, bus, dev, func); - } - } else { - pci_info_xs_remove(gc, pci, "driver_path"); - } + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_bool(gc, args, PCID_MSG_FIELD_REBIND, rebind); - if ( pciback_dev_assign(gc, pci) ) { - LOG(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; + result = vchan_send_command(gc, vchan, PCID_CMD_MAKE_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } -name: - if (name) - pci_info_xs_write(gc, pci, "name", name); - else - pci_info_xs_remove(gc, pci, "name"); - /* * DOMID_IO is just a sentinel domain, without any actual mappings, * so always pass XEN_DOMCTL_DEV_RDM_RELAXED to avoid assignment being @@ -990,12 +814,15 @@ name: */ rc = xc_assign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci), XEN_DOMCTL_DEV_RDM_RELAXED); - if ( rc < 0 ) { - LOG(ERROR, "failed to quarantine "PCI_BDF, dom, bus, dev, func); - return ERROR_FAIL; - } + if ( rc < 0 ) + LOG(ERROR, "failed to quarantine "PCI_BDF, pci->domain, pci->bus, + pci->dev, pci->func); - return 0; +vchan_free: + pci_vchan_free(gc, vchan); + +out: + return rc; } static int name2bdf(libxl__gc *gc, libxl_device_pci *pci) @@ -1038,13 +865,8 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, { libxl_ctx *ctx = libxl__gc_owner(gc); int rc; - char *driver_path; - - /* If the device is named then we need to look up the BDF */ - if (pci->name) { - rc = name2bdf(gc, pci); - if (rc) return rc; - } + struct vchan_info *vchan; + libxl__json_object *args, *temp_obj, *result; /* De-quarantine */ rc = xc_deassign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci)); @@ -1054,41 +876,43 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, return ERROR_FAIL; } - /* Unbind from pciback */ - if ( (rc = pciback_dev_is_assigned(gc, pci)) < 0 ) { - return ERROR_FAIL; - } else if ( rc ) { - pciback_dev_unassign(gc, pci); - } else { - LOG(WARN, "Not bound to pciback"); + vchan = pci_vchan_get_client(gc); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Rebind if necessary */ - driver_path = pci_info_xs_read(gc, pci, "driver_path"); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_STRING); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } + temp_obj->u.string = GCSPRINTF(PCID_SBDF_FMT, pci->domain, pci->bus, + pci->dev, pci->func); + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_SBDF, temp_obj); - if ( driver_path ) { - if ( rebind ) { - LOG(INFO, "Rebinding to driver at %s", driver_path); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_BOOL); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } - if ( sysfs_write_bdf(gc, - GCSPRINTF("%s/bind", driver_path), - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to %s", driver_path); - return -1; - } + temp_obj->u.b = rebind; + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_REBIND, temp_obj); - pci_info_xs_remove(gc, pci, "driver_path"); - } - } else { - if ( rebind ) { - LOG(WARN, - "Couldn't find path for original driver; not rebinding"); - } + result = vchan_send_command(gc, vchan, PCID_CMD_REVERT_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } - pci_info_xs_remove(gc, pci, "name"); +vchan_free: + pci_vchan_free(gc, vchan); - return 0; +out: + return rc; } int libxl_device_pci_assignable_add(libxl_ctx *ctx, libxl_device_pci *pci, diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 8dfccc439d..5e1e41feb5 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -38,6 +38,8 @@ #define DOM0_ID 0 +#define PCI_BDF "%04x:%02x:%02x.%01x" + struct vchan_client { XEN_LIST_ENTRY(struct vchan_client) list; @@ -119,6 +121,394 @@ static int process_list_assignable(libxl__gc *gc, yajl_gen gen, return 0; } +static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + char * spath; + int rc; + struct stat st; + + if (access(SYSFS_PCIBACK_DRIVER, F_OK) < 0) { + if (errno == ENOENT) { + LOG(ERROR, "Looks like pciback driver is not loaded"); + } else { + LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); + } + return -1; + } + + spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, + domain, bus, dev, func); + rc = lstat(spath, &st); + + if (rc == 0) + return 1; + if (rc < 0 && errno == ENOENT) + return 0; + LOGE(ERROR, "Accessing %s", spath); + return -1; +} + +#define PCID_INFO_PATH "pcid" +#define PCID_BDF_XSPATH "%04x-%02x-%02x-%01x" + +static char *pcid_info_xs_path(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + return node ? + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH"/%s", + domain, bus, dev, func, node) : + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH, + domain, bus, dev, func); +} + + +static int pcid_info_xs_write(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node, + const char *val) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + int rc = libxl__xs_printf(gc, XBT_NULL, path, "%s", val); + + if (rc) LOGE(WARN, "Write of %s to node %s failed.", val, path); + + return rc; +} + +static char *pcid_info_xs_read(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + + return libxl__xs_read(gc, XBT_NULL, path); +} + +static void pcid_info_xs_remove(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + libxl_ctx *ctx = libxl__gc_owner(gc); + + /* Remove the xenstore entry */ + xs_rm(ctx->xsh, XBT_NULL, path); +} + + +/* Write the standard BDF into the sysfs path given by sysfs_path. */ +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + int rc, fd; + char *buf; + + fd = open(sysfs_path, O_WRONLY); + if (fd < 0) { + LOGE(ERROR, "Couldn't open %s", sysfs_path); + return ERROR_FAIL; + } + + buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + /* Annoying to have two if's, but we need the errno */ + if (rc < 0) + LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); + close(fd); + + if (rc < 0) + return ERROR_FAIL; + + return 0; +} + + +/* Unbind device from its current driver, if any. If driver_path is non-NULL, + * store the path to the original driver in it. */ +static int sysfs_dev_unbind(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, + char **driver_path) +{ + char * spath, *dp = NULL; + struct stat st; + + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", + domain, bus, dev, func); + if (!lstat(spath, &st)) { + /* Find the canonical path to the driver. */ + dp = libxl__zalloc(gc, PATH_MAX); + dp = realpath(spath, dp); + if ( !dp ) { + LOGE(ERROR, "realpath() failed"); + return -1; + } + + LOG(DEBUG, "Driver re-plug path: %s", dp); + + /* Unbind from the old driver */ + spath = GCSPRINTF("%s/unbind", dp); + if (sysfs_write_bdf(gc, spath, domain, bus, dev, func) < 0) { + LOGE(ERROR, "Couldn't unbind device"); + return -1; + } + } + + if (driver_path) + *driver_path = dp; + + return 0; +} + +/* + * A brief comment about slots. I don't know what slots are for; however, + * I have by experimentation determined: + * - Before a device can be bound to pciback, its BDF must first be listed + * in pciback/slots + * - The way to get the BDF listed there is to write BDF to + * pciback/new_slot + * - Writing the same BDF to pciback/new_slot is not idempotent; it results + * in two entries of the BDF in pciback/slots + * It's not clear whether having two entries in pciback/slots is a problem + * or not. Just to be safe, this code does the conservative thing, and + * first checks to see if there is a slot, adding one only if one does not + * already exist. + */ + +/* Scan through /sys/.../pciback/slots looking for pci's BDF */ +static int pciback_dev_has_slot(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + FILE *f; + int rc = 0; + unsigned s_domain, s_bus, s_dev, s_func; + + f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); + + if (f == NULL) { + LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); + return ERROR_FAIL; + } + + while (fscanf(f, "%x:%x:%x.%d\n", + &s_domain, &s_bus, &s_dev, &s_func) == 4) { + if (s_domain == domain && + s_bus == bus && + s_dev == dev && + s_func == func) { + rc = 1; + goto out; + } + } +out: + fclose(f); + return rc; +} + +static int pciback_dev_assign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + int rc; + + if ( (rc = pciback_dev_has_slot(gc, domain, bus, dev, func)) < 0 ) { + LOGE(ERROR, "Error checking for pciback slot"); + return ERROR_FAIL; + } else if (rc == 0) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + } + + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + return 0; +} + +static int process_make_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct stat st; + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *spath, *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* See if the device exists */ + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); + if ( lstat(spath, &st) ) { + make_error_reply(gc, gen, strerror(errno), command_name); + LOGE(ERROR, "Couldn't lstat %s", spath); + return ERROR_FAIL; + } + + /* Check to see if it's already assigned to pciback */ + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) { + make_error_reply(gc, gen, "Can't check if device is assigned", + command_name); + return ERROR_FAIL; + } + if (rc) { + LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); + goto done; + } + + /* Check to see if there's already a driver that we need to unbind from */ + if (sysfs_dev_unbind(gc, dom, bus, dev, func, &driver_path)) { + LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", + dom, bus, dev, func); + return ERROR_FAIL; + } + + /* Store driver_path for rebinding back */ + if (rebind) { + if (driver_path) { + pcid_info_xs_write(gc, dom, bus, dev, func, "driver_path", + driver_path); + } else if ( (driver_path = + pcid_info_xs_read(gc, dom, bus, dev, func, + "driver_path")) != NULL ) { + LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", + dom, bus, dev, func, driver_path); + } else { + LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", + dom, bus, dev, func); + } + } else { + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + + if (pciback_dev_assign(gc, dom, bus, dev, func)) { + LOG(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + +done: + return 0; +} + +static int pciback_dev_unassign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + /* Remove from pciback */ + if ( sysfs_dev_unbind(gc, domain, bus, dev, func, NULL) < 0 ) { + LOG(ERROR, "Couldn't unbind device!"); + return ERROR_FAIL; + } + + /* Remove slot if necessary */ + if ( pciback_dev_has_slot(gc, domain, bus, dev, func) > 0 ) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't remove pciback slot"); + return ERROR_FAIL; + } + } + return 0; +} + +static int process_revert_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* Unbind from pciback */ + if ( (rc = pciback_dev_is_assigned(gc, dom, bus, dev, func)) < 0 ) { + make_error_reply(gc, gen, "Can't unbind from pciback", command_name); + return ERROR_FAIL; + } else if ( rc ) { + pciback_dev_unassign(gc, dom, bus, dev, func); + } else { + LOG(WARN, "Not bound to pciback"); + } + + /* Rebind if necessary */ + driver_path = pcid_info_xs_read(gc, dom, bus, dev, func, "driver_path"); + + if ( driver_path ) { + if ( rebind ) { + LOG(INFO, "Rebinding to driver at %s", driver_path); + + if ( sysfs_write_bdf(gc, + GCSPRINTF("%s/bind", driver_path), + dom, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to %s", driver_path); + return -1; + } + + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + } else { + if ( rebind ) { + LOG(WARN, + "Couldn't find path for original driver; not rebinding"); + } + } + + return 0; +} + static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, const libxl__json_object *request) { @@ -142,6 +532,12 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) ret = process_list_assignable(gc, gen, command_name, request, &command_response); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + ret = process_make_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + ret = process_revert_assignable(gc, gen, command_name, + request, &command_response); else { /* * This is an unsupported command: make a reply and proceed over -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492679.762399 (Exim 4.92) (envelope-from ) id 1pQ9Hr-0000Ku-K2; Thu, 09 Feb 2023 15:56:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492679.762399; Thu, 09 Feb 2023 15:56:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hr-0000Io-BB; Thu, 09 Feb 2023 15:56:39 +0000 Received: by outflank-mailman (input) for mailman id 492679; Thu, 09 Feb 2023 15:56:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Ho-0007Ak-Pn for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:37 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 549b6a4a-a892-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 16:56:35 +0100 (CET) Received: by mail-ej1-x629.google.com with SMTP id sa10so7667153ejc.9 for ; Thu, 09 Feb 2023 07:56:35 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 549b6a4a-a892-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dce94Jrl1fONboV6egU+yvi+P6trFx/LtuUcWDWz0QA=; b=IhnidZZp4ea6CBm47aSbqq7R1WCTIMgi4psDVc0OE6qhmbLyVc1pyEFY6HNMW1FQ4K /sQtr+cVkFwXmiVCnpkYpJakN+5GALP2GKhH4Gf4Jbhf8Mj3W0QZz8WJ8bu8if3rId1o noExBk+hMw4q/J0cmRwflAEMSYGufg9qIdlSribwOM7WAbgKKlJFBNNRrQiOb+1yJJva rqgPrhJrvN8oxVEWgGqrF5woObUbgypZS7HZqqydgmh5zAC0Th+sbgZ3JZ5MNoRGNsca UqKnIwIkFlyZ1sKzBnxBsdBUDlZ7re6bNoXO+Qavf351nZqmBIDh4SWMfNJ+ixtON9KA 6luA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dce94Jrl1fONboV6egU+yvi+P6trFx/LtuUcWDWz0QA=; b=KsCKsphsg/UYSIsQbQdzbqlo6ZiX1QWov7XALflJDaM1ySNwE8UD1gi1IZEN0bOGoR S7XhKCZd3Fi3AOwx0PN2AnLRkqJvM/W7DCR/MSwLTCz7RDR4pdnP+qp965orGbqq00aI Jy3RdeXyV9fmV5p11hsep7TBWebSQXLXSNJJK9XplWCY7hI6PoldkgOPqjpLZalF8ENj IsZNjNc4z/gZaPkGmDqETZ367v7y/2S98gouS5yQych7hnC5KPeiQh0VVZmx5uKqL4Zi xgqbJBzh6RQGPfDUT1W7ycB4ukFD289ZVui/NzpXnb1C4qeCT3+GyQJOVurADSsk713d dcAg== X-Gm-Message-State: AO0yUKUsR672psjKYYV9sjJ5FE6N37ihgGbvbAk1jBPx+ZmSwXBLvVZb 1cb+/rvEwjjJVe6ygUwF/TrlihM/DFYtNg== X-Google-Smtp-Source: AK7set8pRZCT1H9vWbqv9sxCrORaJZd+fnWVtZoHfl2TftEMSIR+RGUkeXqiN7vejRoVCOr4Fbjgdw== X-Received: by 2002:a17:906:2085:b0:8aa:a9df:b7f0 with SMTP id 5-20020a170906208500b008aaa9dfb7f0mr11655733ejq.7.1675958195071; Thu, 09 Feb 2023 07:56:35 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 8/9] tools/libs/light: pcid: implement resource_list command Date: Thu, 9 Feb 2023 17:56:02 +0200 Message-Id: <20230209155604.2753219-9-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Signed-off-by: Dmytro Semenets --- tools/include/xen-pcid.h | 26 ++++++++ tools/libs/light/libxl_pci.c | 63 ++++++++++--------- tools/libs/light/libxl_pcid.c | 110 +++++++++++++++++++++++++++++++++ tools/libs/light/libxl_vchan.c | 8 +++ tools/libs/light/libxl_vchan.h | 4 +- 5 files changed, 180 insertions(+), 31 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index 65be441250..ad2dec80df 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -156,6 +156,32 @@ #define PCID_CMD_IS_ASSIGNED "is_device_assigned" #define PCID_MSG_FIELD_RESULT "result" +/* + ******************************************************************************* + * Get device resources + * + * This command returns resource list of device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "resource_list". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "resource_list". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | resources | map | key 'iomem' - list of memory regions | + * | | | key 'irqs' - list of irqs | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_RESOURCE_LIST "resource_list" +/* Arguments */ +#define PCID_MSG_FIELD_DOMID "domid" +/* Result */ +#define PCID_MSG_FIELD_RESOURCES "resources" +#define PCID_RESULT_KEY_IOMEM "iomem" +#define PCID_RESULT_KEY_IRQS "irqs" + /* ******************************************************************************* * Reset PCI device diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index e920a1fa4b..955635125f 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -81,16 +81,19 @@ static int pci_handle_response(libxl__gc *gc, LOG(DEBUG, "command: %s", command_name); if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) - ret = process_list_assignable(gc, response, result); + ret = process_list_assignable(gc, response, result); else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) *result = libxl__json_object_alloc(gc, JSON_NULL); else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) *result = libxl__json_object_alloc(gc, JSON_NULL); else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESULT, - response, JSON_BOOL); + response, JSON_BOOL); else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESOURCES, + response, JSON_MAP); return ret; } @@ -1388,14 +1391,21 @@ static void pci_add_dm_done(libxl__egc *egc, STATE_AO_GC(pas->aodev->ao); libxl_ctx *ctx = libxl__gc_owner(gc); libxl_domid domid = pas->pci_domid; - char *sysfs_path; - FILE *f; unsigned long long start, end, flags, size; int irq, i; int r; uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED; uint32_t domainid = domid; bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid); + struct vchan_info *vchan; + libxl__json_object *result; + libxl__json_object *args; + const libxl__json_object *value; + libxl__json_object *res_obj; + + vchan = pci_vchan_get_client(gc); + if (!vchan) + goto out; /* Convenience aliases */ bool starting = pas->starting; @@ -1404,25 +1414,27 @@ static void pci_add_dm_done(libxl__egc *egc, libxl__ev_qmp_dispose(gc, &pas->qmp); - if (rc) goto out; + args = libxl__vchan_start_args(gc); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_integer(gc, args, PCID_MSG_FIELD_DOMID, domid); + + result = vchan_send_command(gc, vchan, PCID_CMD_RESOURCE_LIST, args); + if (!result) + goto vchan_free; + value = libxl__json_map_get(PCID_RESULT_KEY_IOMEM, result, JSON_ARRAY); /* stubdomain is always running by now, even at create time */ if (isstubdom) starting = false; - - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); start = end = flags = size = 0; irq = 0; - - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - rc = ERROR_FAIL; - goto out; - } for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { - if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + if ((res_obj = libxl__json_array_get(value, i)) == NULL) + continue; + const char *iomem_str = libxl__json_object_get_string(res_obj); + if (sscanf(iomem_str, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) continue; size = end - start + 1; if (start) { @@ -1432,7 +1444,6 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_ioport_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1443,29 +1454,21 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_iomem_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } } } } - fclose(f); if (!pci_supp_legacy_irq()) goto out_no_irq; - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - goto out_no_irq; - } - if ((fscanf(f, "%u", &irq) == 1) && irq) { + value = libxl__json_map_get(PCID_RESULT_KEY_IRQS, result, JSON_ARRAY); + if ((res_obj = libxl__json_array_get(value, i)) && + (irq = libxl__json_object_get_integer(res_obj))) { r = xc_physdev_map_pirq(ctx->xch, domid, irq, &irq); if (r < 0) { LOGED(ERROR, domainid, "xc_physdev_map_pirq irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1473,12 +1476,10 @@ static void pci_add_dm_done(libxl__egc *egc, if (r < 0) { LOGED(ERROR, domainid, "xc_domain_irq_permission irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } } - fclose(f); /* Don't restrict writes to the PCI config space from this VM */ if (pci->permissive) { @@ -1511,6 +1512,8 @@ out_no_irq: rc = libxl__device_pci_add_xenstore(gc, domid, pci, starting); else rc = 0; +vchan_free: + pci_vchan_free(gc, vchan); out: libxl__ev_time_deregister(gc, &pas->timeout); libxl__ev_time_deregister(gc, &pas->timeout_retries); diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 05c0b69324..0befb1999d 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -40,6 +40,10 @@ #define PCI_BDF "%04x:%02x:%02x.%01x" +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func); + struct vchan_client { XEN_LIST_ENTRY(struct vchan_client) list; @@ -121,6 +125,109 @@ static int process_list_assignable(libxl__gc *gc, yajl_gen gen, return 0; } +static bool pci_supp_legacy_irq(void) +{ +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ + return true; +#else + return false; +#endif +} + +static int process_list_resources(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct libxl__json_object *iomem = + libxl__json_object_alloc(gc, JSON_ARRAY); + struct libxl__json_object *irqs = + libxl__json_object_alloc(gc, JSON_ARRAY); + const struct libxl__json_object *json_sdbf; + const struct libxl__json_object *json_domid; + unsigned int dom, bus, dev, func; + libxl_domid domainid; + char *sysfs_path; + FILE *f; + unsigned long long start, end, flags; + int irq, i; + int rc = 0; + libxl__json_map_node *map_node = NULL; + + json_sdbf = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_sdbf) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + if (sscanf(libxl__json_object_get_string(json_sdbf), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_domid = libxl__json_map_get(PCID_MSG_FIELD_DOMID, request, JSON_INTEGER); + if (!json_domid) { + make_error_reply(gc, gen, "No mandatory parameter 'domid'", command_name); + return ERROR_FAIL; + } + domainid = libxl__json_object_get_integer(json_domid); + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESOURCES); + *response = libxl__json_object_alloc(gc, JSON_MAP); + + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + start = 0; + irq = 0; + + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + rc = ERROR_FAIL; + goto out; + } + for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { + if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + continue; + if (start) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + + node->u.string = GCSPRINTF("0x%llx 0x%llx 0x%llx", start, end, flags); + flexarray_append(iomem->u.array, node); + } + } + fclose(f); + if (!pci_supp_legacy_irq()) + goto out_no_irq; + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + goto out_no_irq; + } + if ((fscanf(f, "%u", &irq) == 1) && irq) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_INTEGER); + + node->u.i = irq; + flexarray_append(irqs->u.array, node); + } + fclose(f); + + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IRQS); + map_node->obj = irqs; + flexarray_append((*response)->u.map, map_node); +out_no_irq: + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IOMEM); + map_node->obj = iomem; + flexarray_append((*response)->u.map, map_node); + rc = 0; +out: + return rc; +} + static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, unsigned int bus, unsigned int dev, unsigned int func) @@ -636,6 +743,9 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) ret = process_device_pci_reset(gc, gen, command_name, request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + ret = process_list_resources(gc, gen, command_name, + request, &command_response); else { /* * This is an unsupported command: make a reply and proceed over diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c index 7611816f52..a1beda9e1b 100644 --- a/tools/libs/light/libxl_vchan.c +++ b/tools/libs/light/libxl_vchan.c @@ -99,6 +99,14 @@ void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, obj->u.b = val; } +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_INTEGER, args, key); + + obj->u.i = val; +} + static void reset_yajl_generator(struct vchan_state *state) { yajl_gen_clear(state->gen); diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h index 0968875298..07f0db4e93 100644 --- a/tools/libs/light/libxl_vchan.h +++ b/tools/libs/light/libxl_vchan.h @@ -58,7 +58,9 @@ static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, char *key, char *val); void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, - char *key, bool val); + char *key, bool val); +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val); libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, char *cmd, libxl__json_object *args); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 15:56:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 15:56:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492680.762406 (Exim 4.92) (envelope-from ) id 1pQ9Hs-0000SI-EL; Thu, 09 Feb 2023 15:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492680.762406; Thu, 09 Feb 2023 15:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hs-0000R2-07; Thu, 09 Feb 2023 15:56:40 +0000 Received: by outflank-mailman (input) for mailman id 492680; Thu, 09 Feb 2023 15:56:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Hq-0006cl-Gy for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 15:56:38 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 553d0ea0-a892-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 16:56:36 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id gr7so7725460ejb.5 for ; Thu, 09 Feb 2023 07:56:36 -0800 (PST) Received: from dsemenets-HP-EliteBook-850-G8-Notebook-PC.. ([91.219.254.72]) by smtp.gmail.com with ESMTPSA id v1-20020a170906b00100b0087862f45a29sm1027594ejy.174.2023.02.09.07.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:56:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 553d0ea0-a892-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0HDRmSfELdHFsxew+hy0RMD843CMREA2B14by0pRDE0=; b=eYe8PdysANwGLi6ir/z7GNejeEdFb/yKqwstsPaWymqLfX8vtQr7IqGQgI+gOfY3LH VFCyJ076kspR56gqmhLKKIexWkAtpnhoAsFtVTMLLaSjNDSMMmlbVpFOoZEqPP7dDTwn n0hq+80Ud/gDYmdBAbtJmjl9OMJoMOGuX5z8l5UQcn1cZ7QmuJQt1wTY+MkEn5Zmfce7 ScyGnS4TCH8ZBXIC/R/AUI3WBf5Kd4k8dZfpPHMQg77sf84sHq7tsYReNfVibj+oWI2r 4mgN8ftv+I0Fq7kJvv+oWrDTOxiWRKDgAvUVS9/SXzN7fz56PHvagVejcYsWTzpjuNpj ig2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0HDRmSfELdHFsxew+hy0RMD843CMREA2B14by0pRDE0=; b=ngxWWP4/ok8nVlqCjcUPrlwN7/Ncnc2BTxCi8hnT0/QaonyDToM41XWe1D8sPEeYG4 6OhT+QlAptCSS6RW7OQYuvafdIuVc3nqOr/MbCvPdLy/GdcDP5TknxGfHID8gwg3/ZnF uQmvfgPvx3qkg2XUcM3Y1j465mj/YOq0bw6a71tFB8yYP0uhDqYANPUsoGvpITEFVaNG cMZTXQvSO5knLI7VBtcTkNNINLLmJRzDFZf9TY2vTQ861b1R8WHs6yab8N1RHLFFyTpt kwS+FQgYwIMpBE/Do/gS3mrWc2160rYQmJQMYBei2MhYsfY8xEedX9yPXS71L/+qCFpU T7QA== X-Gm-Message-State: AO0yUKWU6z9yQnGVe5Ae6fhxFj/ZN8ahHMP917dzP8uphL0frQJVbGVN roW+zNgv83X6g8EiljTa7og6n6Z02KwpTQ== X-Google-Smtp-Source: AK7set8PttQf/A23scnNgYDmyUMC5SpM1LhW3fDa0espq2v56go0uO1k4JI44QLi/+dq2VClCOZYPA== X-Received: by 2002:a17:906:74ca:b0:8a9:e5c2:e3b8 with SMTP id z10-20020a17090674ca00b008a9e5c2e3b8mr10166753ejl.2.1675958196068; Thu, 09 Feb 2023 07:56:36 -0800 (PST) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Dmytro Semenets , Wei Liu , Anthony PERARD , Juergen Gross Subject: [RFC PATCH v4 9/9] tools/libs/light: pcid: implement write_bdf command Date: Thu, 9 Feb 2023 17:56:03 +0200 Message-Id: <20230209155604.2753219-10-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209155604.2753219-1-dmitry.semenets@gmail.com> References: <20230209155604.2753219-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dmytro Semenets Signed-off-by: Dmytro Semenets --- tools/include/xen-pcid.h | 17 +++++++++ tools/libs/light/libxl_pci.c | 67 ++++++++++++++++++----------------- tools/libs/light/libxl_pcid.c | 38 ++++++++++++++++++++ 3 files changed, 90 insertions(+), 32 deletions(-) diff --git a/tools/include/xen-pcid.h b/tools/include/xen-pcid.h index ad2dec80df..e731340653 100644 --- a/tools/include/xen-pcid.h +++ b/tools/include/xen-pcid.h @@ -182,6 +182,23 @@ #define PCID_RESULT_KEY_IOMEM "iomem" #define PCID_RESULT_KEY_IRQS "irqs" +/* + ******************************************************************************* + * Write BDF values to the pciback sysfs path + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "write_bdf". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "name" name of sysfs file of pciback driver + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "write_bdf". + */ +#define PCID_CMD_WRITE_BDF "write_bdf" +#define PCID_MSG_FIELD_NAME "name" + /* ******************************************************************************* * Reset PCI device diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 955635125f..d771f587c5 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -94,6 +94,8 @@ static int pci_handle_response(libxl__gc *gc, else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESOURCES, response, JSON_MAP); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); return ret; } @@ -511,33 +513,6 @@ static bool is_pci_in_array(libxl_device_pci *pcis, int num, return i < num; } -/* Write the standard BDF into the sysfs path given by sysfs_path. */ -static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, - libxl_device_pci *pci) -{ - int rc, fd; - char *buf; - - fd = open(sysfs_path, O_WRONLY); - if (fd < 0) { - LOGE(ERROR, "Couldn't open %s", sysfs_path); - return ERROR_FAIL; - } - - buf = GCSPRINTF(PCI_BDF, pci->domain, pci->bus, - pci->dev, pci->func); - rc = write(fd, buf, strlen(buf)); - /* Annoying to have two if's, but we need the errno */ - if (rc < 0) - LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); - close(fd); - - if (rc < 0) - return ERROR_FAIL; - - return 0; -} - #define PCI_INFO_PATH "/libxl/pci" static char *pci_info_xs_path(libxl__gc *gc, libxl_device_pci *pci, @@ -1384,6 +1359,36 @@ static bool pci_supp_legacy_irq(void) #endif } +static int pciback_write_bdf(libxl__gc *gc, char *name, libxl_device_pci *pci) +{ + struct vchan_info *vchan; + int rc; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; + } + + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_NAME, name); + + result = vchan_send_command(gc, vchan, PCID_CMD_WRITE_BDF, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; + } +vchan_free: + pci_vchan_free(gc, vchan); +out: + return rc; +} + static void pci_add_dm_done(libxl__egc *egc, pci_add_state *pas, int rc) @@ -1421,8 +1426,9 @@ static void pci_add_dm_done(libxl__egc *egc, libxl__vchan_arg_add_integer(gc, args, PCID_MSG_FIELD_DOMID, domid); result = vchan_send_command(gc, vchan, PCID_CMD_RESOURCE_LIST, args); + pci_vchan_free(gc, vchan); if (!result) - goto vchan_free; + goto out; value = libxl__json_map_get(PCID_RESULT_KEY_IOMEM, result, JSON_ARRAY); /* stubdomain is always running by now, even at create time */ @@ -1483,8 +1489,7 @@ static void pci_add_dm_done(libxl__egc *egc, /* Don't restrict writes to the PCI config space from this VM */ if (pci->permissive) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/permissive", - pci) < 0 ) { + if (pciback_write_bdf(gc, "permissive", pci)) { LOGD(ERROR, domainid, "Setting permissive for device"); rc = ERROR_FAIL; goto out; @@ -1512,8 +1517,6 @@ out_no_irq: rc = libxl__device_pci_add_xenstore(gc, domid, pci, starting); else rc = 0; -vchan_free: - pci_vchan_free(gc, vchan); out: libxl__ev_time_deregister(gc, &pas->timeout); libxl__ev_time_deregister(gc, &pas->timeout_retries); diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c index 0befb1999d..9368ba6c73 100644 --- a/tools/libs/light/libxl_pcid.c +++ b/tools/libs/light/libxl_pcid.c @@ -257,6 +257,41 @@ static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, return 0; } +static int process_pciback_write_bdf(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc = 0; + const char *name; + char *spath; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_NAME, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + name = libxl__json_object_get_string(json_o); + spath = GCSPRINTF("%s/%s", SYSFS_PCIBACK_DRIVER, name); + LOG(WARN, "sysf_write_bdf(%s, %d, %d, %d, %d)", spath, dom, bus, dev,func); + return rc; +} + #define PCID_INFO_PATH "pcid" #define PCID_BDF_XSPATH "%04x-%02x-%02x-%01x" @@ -746,6 +781,9 @@ static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) ret = process_list_resources(gc, gen, command_name, request, &command_response); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + ret = process_pciback_write_bdf(gc, gen, command_name, + request, &command_response); else { /* * This is an unsupported command: make a reply and proceed over -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 16:02:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 16:02:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492701.762424 (Exim 4.92) (envelope-from ) id 1pQ9NJ-0005OJ-1a; Thu, 09 Feb 2023 16:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492701.762424; Thu, 09 Feb 2023 16:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9NI-0005OC-U7; Thu, 09 Feb 2023 16:02:16 +0000 Received: by outflank-mailman (input) for mailman id 492701; Thu, 09 Feb 2023 16:02:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9NH-0005Nq-Gm for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:02:15 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e8f100b-a893-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 17:02:14 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id x40so3733463lfu.12 for ; Thu, 09 Feb 2023 08:02:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e8f100b-a893-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IooKS56JceovXpfIA9G2QdG2hZ0P9K7lg7umfAPb5L4=; b=bhdI8zS8ZyDA26V7r45EqJMt0m8aERJ4U4R20i4iohU1fPcDXd5HJkHx7RaMJM73dq l7twYaummB9h75xKyfbEVUxQlx3AY4qwLZwGtrjEo1kUPmEyrrQidUfe7P+IWRl9Uc1S AOHQrySbGq1ZAd4TfAIj3CV69ZvYgf8lTLf9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IooKS56JceovXpfIA9G2QdG2hZ0P9K7lg7umfAPb5L4=; b=ktoqAguyxEj4+GlSeoDn7geTksz6hC5Jtlb4DpdCCPxMLgbibDX/lruWVcqTasyGwc NLrGGdHTm0pzprmT7QwuOnya8qxMCtBPoqlJGXGrE/73dnbPt2R78hdVQBPBLgsr4C9+ vmkrTJi8Of/ZJ3jZryLW8qbq0Jx5pgM9r9b3tZCvUHlkn6desICGwTz/y35dGnCVGtsL wXHL7+BomXXgqylwQTWpPeTGlE+WkbWBFNJKEPk+mdR8ycr+5YGd6YAy7hY+6PTL+xLK elVBlYHEqnRopk54+BA4nCImx0j9PAlBvR7iGf9lTHJu7uYG5egCm3bH/NfuXzBlVUfI Fy2g== X-Gm-Message-State: AO0yUKVdyhMOwiyhJrRXURmvCbmxvpF4R49rcl6BK7C0sqOuLlEdXdE3 h/hDhH2KYcjT2YaKDwRZWixZsQbl+ODImUnAkrhkSg== X-Google-Smtp-Source: AK7set8KshKSNp7AMaPgSBh6iafFedONWlcQz/JvRp4WV3V1SBVmZbC8al1NXb6ZdqQ2T+4BQaM/ZwHunrukaTNOnEM= X-Received: by 2002:ac2:418c:0:b0:4da:fddc:da02 with SMTP id z12-20020ac2418c000000b004dafddcda02mr1889842lfh.116.1675958533955; Thu, 09 Feb 2023 08:02:13 -0800 (PST) MIME-Version: 1.0 References: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> In-Reply-To: From: George Dunlap Date: Thu, 9 Feb 2023 16:02:03 +0000 Message-ID: Subject: Re: Proposal for consistent Kconfig usage by the hypervisor build system To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Content-Type: multipart/alternative; boundary="000000000000133eab05f44681aa" --000000000000133eab05f44681aa Content-Type: text/plain; charset="UTF-8" On Thu, Feb 9, 2023 at 1:43 PM Jan Beulich wrote: > On 02.02.2023 16:51, Andrew Cooper wrote: > > On 12/01/2023 4:52 pm, Jan Beulich wrote: > > Anyway, I have a prototype for the two CET controls mostly ready now, so > I guess we'll continue the discussion there once I've submitted that one. > One thing that it occured to me will be important: `make randconfig` must continue to work somehow. I'm not sure how Anthony's patch to deal with `checkpolicy` deals with that. -George --000000000000133eab05f44681aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 9, 2023 at 1:43 PM Jan Be= ulich <jbeulich@suse.com> wr= ote:
On 02.02.20= 23 16:51, Andrew Cooper wrote:
> On 12/01/2023 4:52 pm, Jan Beulich wrote:

Anyway, I have a prototype for the two CET controls mostly ready now, so I guess we'll continue the discussion there once I've submitted tha= t one.

One thing that it occured to me = will be important: `make randconfig` must continue to work somehow.=C2=A0 I= 'm not sure how Anthony's patch to deal with `checkpolicy` deals wi= th that.

=C2=A0-George=C2=A0
--000000000000133eab05f44681aa-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 16:05:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 16:05:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492720.762434 (Exim 4.92) (envelope-from ) id 1pQ9QB-0006AZ-Kh; Thu, 09 Feb 2023 16:05:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492720.762434; Thu, 09 Feb 2023 16:05:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9QB-0006AS-Ff; Thu, 09 Feb 2023 16:05:15 +0000 Received: by outflank-mailman (input) for mailman id 492720; Thu, 09 Feb 2023 16:05:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9QA-00067S-Cl for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:05:14 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86c3e662-a893-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 17:05:09 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id j17so3818972lfr.3 for ; Thu, 09 Feb 2023 08:05:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86c3e662-a893-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uU5XW1oBviPYVXjF6pnAUE1uhzLd8k2qXYASLluuumw=; b=lRk98YwJow6YTwLEXa2koWXSbFNO5LXYaT1AdH0/OuDHfuudolrRxTMnOXrTCALf64 BvHviFbxfFWDQJcMfsJRKXodcBa+Iv0C2zUELg+tAuZDNk1QI5S3Iy0uUrqGXmUld48C 6Qq+2oy5zgsz5KDkdESou3LJnqKwEP4obOdVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uU5XW1oBviPYVXjF6pnAUE1uhzLd8k2qXYASLluuumw=; b=hKszUZ06Kf33GFNrwLsmUqygydrXztr6wp1BQMxPrEzxr1F1hGREgVP67P1B506s/D 0CHistK65jnCOUwr2fNxLVRpmARmBsMc0WMhC5aikLcmodCOvkjfTcL1//aQNuJ6pmE2 oZC5BgQ+9/N4ORb9OKfS/Cd/KBNDehIi+2g+JNkEEoX2oDcynG+lWSx3TpRZ/nDNteGE yeJ6QrvH4qzX4Wca3wsS8sVJf+HI4WDdxS2ZimTvzLOBv9U/K3KqHjl9kz4jLYbyXNBh vPvb/DJR+VkB5H8+D9Wx7kAy6hmj88FqRxCD8fW572PPOIE9d1/QCV2N7luKezvB53z8 OwwA== X-Gm-Message-State: AO0yUKW8zEtGi7EIzmlpobRxzWRqfmMyICggpMG/J6TuljcS2vBddbMu T4P5LytBEJeYxVauBbSyH2hE2RWOipD2v9okoQfA01iWE6z9zA== X-Google-Smtp-Source: AK7set8e+D3Y3Vo+sWYXLOkH6j/6C+3fvDGLGu/oPiUTpx4BPdNjK6Va+XwZmmxFPJ7rkJm1Q+TEnvuURhee0Yhchmo= X-Received: by 2002:ac2:4830:0:b0:4d3:f1f7:9632 with SMTP id 16-20020ac24830000000b004d3f1f79632mr2322816lft.51.1675958708419; Thu, 09 Feb 2023 08:05:08 -0800 (PST) MIME-Version: 1.0 References: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: From: George Dunlap Date: Thu, 9 Feb 2023 16:04:57 +0000 Message-ID: Subject: Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// To: Anthony PERARD Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault Content-Type: multipart/alternative; boundary="000000000000795ff905f4468b09" --000000000000795ff905f4468b09 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 9, 2023 at 3:05 PM Anthony PERARD wrote: > On Thu, Feb 09, 2023 at 02:01:52PM +0000, George Dunlap wrote: > > On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour < > > demi@invisiblethingslab.com> wrote: > > > > > Obtaining code over an insecure transport is a terrible idea for > > > blatently obvious reasons. Even for non-executable data, insecure > > > transports are considered deprecated. > > > > > > This patch enforces the use of secure transports in the build system. > > > > > > Signed-off-by: Demi Marie Obenour > > > > > > > Hey Demi, > > > > Thanks for this series -- we definitely want the build system to use > secure > > transports when available. Can you confirm that you've tested the "+s" > > versions of all the URLs in this patch, and verified that they actually > > work? > > :'( -> https://gitlab.com/xen-project/patchew/xen/-/pipelines/771746628/ > > Our GitLab tests are very unhappy with the switch to TLS. Too many > containers aren't recent enough, and don't have the right certificates > (Let's encrypt I guess). > > I've only looked at two failures: > ubuntu-focal-clang: > fatal: unable to access ' > https://xenbits.xen.org/git-http/qemu-xen.git/': server certificate > verification failed. CAfile: none CRLfile: none > ubuntu-xenial-gcc: > ERROR: cannot verify xenbits.xen.org's certificate, issued by > 'CN=R3,O=Let\'s Encrypt,C=US': > > I'll try to have a look at updating those containers. > Just to clarify: This isn't an argument against the patch; only perhaps an argument to delay it being checked in until we get the containers fixed. Another advantage of this patch may be that it will naturally prod us to update the containers whenever the root certificates expire. :-D -George --000000000000795ff905f4468b09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 9, 2023 at 3:05 PM Anthon= y PERARD <anthony.perard@ci= trix.com> wrote:
On Thu, Feb 09, 2023 at 02:01:52PM +0000, George Dunlap wrote:
> On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour <
> demi@= invisiblethingslab.com> wrote:
>
> > Obtaining code over an insecure transport is a terrible idea for<= br> > > blatently obvious reasons.=C2=A0 Even for non-executable data, in= secure
> > transports are considered deprecated.
> >
> > This patch enforces the use of secure transports in the build sys= tem.
> >
> > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com> > >
>
> Hey Demi,
>
> Thanks for this series -- we definitely want the build system to use s= ecure
> transports when available.=C2=A0 Can you confirm that you've teste= d the "+s"
> versions of all the URLs in this patch, and verified that they actuall= y
> work?

:'(=C2=A0 =C2=A0-> https://g= itlab.com/xen-project/patchew/xen/-/pipelines/771746628/

Our GitLab tests are very unhappy with the switch to TLS. Too many
containers aren't recent enough, and don't have the right certifica= tes
(Let's encrypt I guess).

I've only looked at two failures:
=C2=A0 =C2=A0 ubuntu-focal-clang:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fatal: unable to access 'https://xenbits.xen.org/git-http/qemu-xen.git/': server certific= ate verification failed. CAfile: none CRLfile: none
=C2=A0 =C2=A0 ubuntu-xenial-gcc:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ERROR: cannot verify xenbits.xen.org's cer= tificate, issued by 'CN=3DR3,O=3DLet\'s Encrypt,C=3DUS':

I'll try to have a look at updating those containers.
<= div>
Just to clarify: This isn't an argument against the = patch; only perhaps an argument to delay it being checked in until we get t= he containers fixed.

Another advantage of this pat= ch may be that it will naturally prod us to update the containers whenever = the root certificates expire. :-D

=C2=A0-George=C2= =A0
--000000000000795ff905f4468b09-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 16:08:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 16:08:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492757.762445 (Exim 4.92) (envelope-from ) id 1pQ9T9-0006u8-2C; Thu, 09 Feb 2023 16:08:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492757.762445; Thu, 09 Feb 2023 16:08:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9T8-0006u1-Vq; Thu, 09 Feb 2023 16:08:18 +0000 Received: by outflank-mailman (input) for mailman id 492757; Thu, 09 Feb 2023 16:08:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9T7-0006tv-NB for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:08:17 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20630.outbound.protection.outlook.com [2a01:111:f400:fe16::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5d983b6-a893-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 17:08:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9470.eurprd04.prod.outlook.com (2603:10a6:102:2b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 16:08:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6064.036; Thu, 9 Feb 2023 16:08:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5d983b6-a893-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZ7iO6umQarhhhPleMCifPLodKr2A+So/lt46PzTn5Hr2sgMyitfxEM68N0ui1fTJHrsdjRAUV0uvEPOKnxSwqATCp1ZlomwXEnuLsW+neGzHusSrsFJ/Lht2IcZoDVTCGen8OFveyj4TR8fiFPwCZDMMm6TMEmtsqC8S61YygDWBLzEA5X+oG4iZl8Kt8WKsdpAbYzacoIpMvcVa1TONmU+xVrT2vhUbZbG0I110UOMznJ84rEV+6G21rG0M5Z3MS3/KlFscbyXbIVauGTZEuQC/IIKJ6kQn4GeSrCFxTJFvsxsv8iz/x2tnWlmu/yThOt5q0DuIfJlWhandLOPmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79wRkhAenkox8Qp/Szgxrxgo1rm9npoc8+2/CpWSrRU=; b=eHNX6LZYdapjOYoIQ0wxr767IWFu4s2t1nmp14ZRbPVr7QeWbDKoOBhb2uAlFEgh+na3/DZ0eDvuh1DPgJIzz3I5ZQVnsnMc4HlHZVMUFHyAJEEOZnzqxMxFExmqcVPRai3n9dpVH2MM9CKNB7lRHQip2xLOE49l7L/DjQJdINCLGtR2OR+FcAJ4BnmwItqK+mq2i5CnVFCjP+Tnb7JkmQQ5UhveRbnIch0PMXgJ4u5Hq7SV/3mqiUTy7cLhqTJC413sglIZ8671xtkdKezxzvSsH9PYNsa8SuOAJVgzVDdpcu90H//B2stFcVL+8U1+Oagdas5dQgEW8sp4uA4lAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79wRkhAenkox8Qp/Szgxrxgo1rm9npoc8+2/CpWSrRU=; b=K3bRE+w6gn4ROoWVyWhBi8WqKfxDxNfGyAmkyCTNV7vwh1eAIrloisiIKSFh3iD4lxLB9lLmW7XynhuPfa3FOoma0iiQPs4inIWrjCxq0w6oc77VkEKUOwd+rC1oNjCpb4wcZwGNXx1Gd+pSQPFPfmh1Bf1NZWW/P+5Ru2BZrepycJ3z40MVYMgtj8vuZBy4LeKtRA+Kt1DZnctDOg2OZTA/hKJUIAagf+UToNORVX8AunqfifUDvRSK06pb20Qbn7CqmLaUXG5JpLhk9nR/FJJATnL1PBdeNeZw4CGOvqHtv1mm3MBvUHSIPKztZE590yaKEjjqnUT9MWEw/Cc3+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <383dfffe-ed1b-7539-d601-c9e7caee22ee@suse.com> Date: Thu, 9 Feb 2023 17:08:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Proposal for consistent Kconfig usage by the hypervisor build system Content-Language: en-US To: George Dunlap Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9470:EE_ X-MS-Office365-Filtering-Correlation-Id: 84a06015-dd70-4e37-2da1-08db0ab7d8a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g0bTCcnHd+WKfcCIE3RZAgZ5RWkG92gyBv0QqwEPMNHI+CpeUG8wnVQ5/qbImuCpHMSmEC24mNt5NOiue/CoH9w6+l3VJC9zAaP4VbPDVTfxtpG4wF3FPzMBloYRVlfI+LwLgmdZij3d49yYhbrad2Ulgo+OAXtQDorVajVIv38vg3CWJwno4v0u23Yah+jhtKTIB6boYOCK7jWvN1xz8/Qx6zZonoayxSCUs9YmWcqTb1U5x8hf+gJQjGE6zA/Byge+fJTktQmWPvMmdQYMnu69AIFe0PQwtUwh82saMT3qfMM3aDzJ8gAtuBOqNvtcW+4SGebv6XVn0JVtQgPPx8QDYwKXMmJ5haeeoe3oyQojMzJ0bTzW0Xv0Nq6H1t8iSopa7tR8D8EI0RM4Wr8+8LfiJqpENM3g+9EbqsWfty3CQQr8RHgNYY+JBmjd7OUEMFMAd5zDO+oAtGZdRS6d0B9ejdNKJPnG6iFNKLMrpufbPgQsX0HeMxWZtv93z3Iz3WqRGwBH8x1LNvpwZYJE2KqaWyjn1R/pCIeio4HCALaAUfP0x0OdNnRrLKnPZztox5MZU8FP3ogSfbOuNpavo2qAxrMqW1/ubFxMnp7SVv0renb4ErfCELa/POK9IyDEmER3eZVx4kj+r4jNqDLfONhputrPqfQG0j11k5J7L8DRugPTs9jZkffh6nc8UPaQRkzAD8PVghLQYdG2KeFWdsAsvlGtmDanHeAULsFdbVA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(346002)(136003)(376002)(366004)(451199018)(2616005)(2906002)(41300700001)(36756003)(66476007)(66556008)(66946007)(6916009)(4326008)(8676002)(478600001)(53546011)(6506007)(38100700002)(6512007)(186003)(26005)(54906003)(86362001)(6486002)(31696002)(66899018)(31686004)(316002)(4744005)(83380400001)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXZlaUh6VENzWTMzeDNWMlVVZG9ROEllZXhNdmZ5OERUMnZKdW5mc1ZVUitu?= =?utf-8?B?S2t1Q2lGb1FzNHd3cXZ2c1NCYnA3U0ZJZm5YNGduM0Y0cTVLcFBwQUNJQ2FL?= =?utf-8?B?RStQdDh5OHRlMlNBN0hRU2ZrOUJCemI0N2lyNFFVRW5PaHFuazFOc1hJWmZY?= =?utf-8?B?VTlWNFdMZlVxTXhTRVJXZjJEbkNnTmcrZlN4WmIvZ2p0dFNZMnoyejlOZzFW?= =?utf-8?B?Y25zU0JCa01reVloTTRvcDd1OHFOclpVR1liSjN4QmlzRW1RY0tkRmlRQXJm?= =?utf-8?B?WHl3alNadG11aDJaMVdxRllQeUM3akJMZlpQOEk5ZG15VG5yU1Z2aGt0Um11?= =?utf-8?B?MDM3azdzYUt6OTVyL2ZUa0M5RmlFUUlPcklpenVJdVhRQWIvOUhLUGtOd2R0?= =?utf-8?B?MW1KTkcrK1Q2emdHdzFndWpYcGh2blJKdWwxYk1xNFNKY3lmYUFyN0VMMXla?= =?utf-8?B?dlhxYVh4KzRrclI3cjFtbGVjYXh6Mkk2b2M4SFNwbWU1dDhmN3JuUXl3TTU2?= =?utf-8?B?NGQ3RllJMWp6Z1QzNXlycFhVallYNW1KMkRsaGp3a0oxbS9kdlV0NXBjMlV5?= =?utf-8?B?RDBSeUE3VFMreVpxaWltZ3RqbVNwOG8wR3lRS1hPRDM2SGp0OFhKMklod0M5?= =?utf-8?B?ZXFaMm9VdTF4RFV0TllabXlJRStGUzQ1OWRmNDJYT2poWmJYRTJWK2hlcUda?= =?utf-8?B?VVIzcEdGTXU3b3hUOGFZeUxkaDkrbWFIazdvR0kzSW52Ym13MmRiZTNXYlE0?= =?utf-8?B?MkQ0YVNUQ2NZOE9MZXMwMTlkdTlMYWphSUVuU0xvcVNrR0EyQVBONkJ5ZFNv?= =?utf-8?B?RzJjNytxc21yYWZmOEhsZUNzbk1nOHVWUGJUbWlmR0pSUitUWDNVSFBSZTFK?= =?utf-8?B?NzJlOUxXT2JoaEdOazZMVG1VaThLa01ka2FOSkFhMFY2MWVNQWFCM0JZM0ZU?= =?utf-8?B?K2xZL0tBSHdrUGxiSUNYTExrcTYwdFEzV2ppZnVxdWRtemlOQjZkTGt4eXJ0?= =?utf-8?B?anpxVWhXMlhad3VPY3FaRlVkTnFQZ0paV2o4U1c3dGl6dXdaakUzSFkrZXZm?= =?utf-8?B?NzB0cjNvaVhEQkRQL3pSaGtVTWQydUlMN0ZTS0ZYVENwTWZLZmR2VGdYYUdR?= =?utf-8?B?Ni9kcUt2ZnlNamJ3L0NCTVVWcGxBeEF4ajRZU0xYeVFOU00vUzdjMm01Vkht?= =?utf-8?B?Wmh0aGJlOEN0cGxTZUNqSzh3NW9pMmxUMFBzWEVQOWN5U3lhRk1FMDB5RzY2?= =?utf-8?B?OWRXdjZDTjVmUXk0dEZKcGl4U3JVd1ZrcDd0RytFNjJkL0ZYL3ZLM2hTQVND?= =?utf-8?B?bEU2K3VkNUJsN2xYUGd5YUVZOWQyWEdMU2FoczFxaHN4cTRrVVRTK21SQTJT?= =?utf-8?B?SEgxSlg4Y2NvWG9NWXFCU2o0VUJDREhJajBUSC9TSllmVzZ6WVNkUDdRUVFZ?= =?utf-8?B?K3BZT3RNQXNFbXVmbzcrK045Q3FuRkZPbTZVSDV5OE5ES0JubndiV1BUOEVu?= =?utf-8?B?VVhUd2x0VkpjOENFRGtQbytCcnB6NFBtTE1qSGZuUnNpSFBwMk9tZ3dtT2ty?= =?utf-8?B?RDh5Wnc2bkNUWStkRmVuZ2gzNkdQZFFId3owVDJwV1pEcXpSd3VScUQrNWRo?= =?utf-8?B?aVlQUmt3OVRVanVITmRjSDRycHNVZEQxZmVmN2FoRGFYN0thbklnQmZpM205?= =?utf-8?B?WHBVaXlWZ1dOMlRNQ1BZSC9BU3hvSmViTVRKMDV5S29RSHFxbFExNHBhMUJE?= =?utf-8?B?TDh2SEpwMGpVbExrSGNPOHFITlV1eDNSbi9UZ3Vqbzd5Q00vbUVTZ2dRNVRa?= =?utf-8?B?Z0RhMk5rS3dlZlI3c1V2ZUZlOEZidGd2bVZJb3ltRUQ3NVhTWTdDQi9kSVhM?= =?utf-8?B?K3g3b1pWMEljSjFtTUVCUlNDQkZwRlo4eWIxY0NMQWdQMmRhOUlwazZNUGtF?= =?utf-8?B?bjNFZmlQQ2l0UUhCSi9haVFKV3BhM29hRlFJMzIwVGxoWUtkUmVYOUFWMnVV?= =?utf-8?B?N0tnZGFWMkJYWitnakNQaHF4MnJQR08rMXhwYnQzWWhZeDkzUEJFa1RSa0F4?= =?utf-8?B?SG1VQnRaNTAyN2VHSTYyam44OW52TGR3eWs2Z3oyQllEd1BDZVRVKzFUVmEx?= =?utf-8?Q?3XV+FH/X87aVp5M652YVH5eBF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84a06015-dd70-4e37-2da1-08db0ab7d8a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 16:08:13.4953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H9oLxIHCyMsYh7vv7OMWVtAnu8wuTaYs1SJB7a66xGoydwUyFKFjn5TbmqLJGEA61Yb3Zqmf55uCBvRCNNWzZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9470 On 09.02.2023 17:02, George Dunlap wrote: > On Thu, Feb 9, 2023 at 1:43 PM Jan Beulich wrote: > >> On 02.02.2023 16:51, Andrew Cooper wrote: >>> On 12/01/2023 4:52 pm, Jan Beulich wrote: >> >> Anyway, I have a prototype for the two CET controls mostly ready now, so >> I guess we'll continue the discussion there once I've submitted that one. >> > > One thing that it occured to me will be important: `make randconfig` must > continue to work somehow. Hmm, good point. For now I've merely added a TBD to the patch I've already sent. Right now I can't see how that might be possible without the user specifying which options cannot be turned on due to tool chain dependencies (by way of a seeding .config, I suppose). > I'm not sure how Anthony's patch to deal with `checkpolicy` deals with that. Given his remark on the community call I did actually try to locate it, assuming that it had at least "policy" in the title. But I couldn't find anything in my mailbox. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 09 16:15:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 16:15:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492763.762457 (Exim 4.92) (envelope-from ) id 1pQ9Zj-0008Q3-Pu; Thu, 09 Feb 2023 16:15:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492763.762457; Thu, 09 Feb 2023 16:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Zj-0008Pw-M5; Thu, 09 Feb 2023 16:15:07 +0000 Received: by outflank-mailman (input) for mailman id 492763; Thu, 09 Feb 2023 16:15:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9Zi-0008Pp-7B for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:15:06 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e83e4e91-a894-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 17:15:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e83e4e91-a894-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675959304; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=chmXOk/3WgEjn30+l9uOCrphnQ3lpcNyWSCe347vpgY=; b=bPKyUjqLAByeBglge4c2UUXm4B98z/yoMSujlP4JV3Ixqbw0riXhCDn/ 83nEB3P7+zLtAMXiebF3QRqvcu99WtFE8nb4wqbJFOY9lFaz01JkN7LSq 3AV9El6NQOEJP1vQkC+N+MDC4PK29bACcc2bOum44eos3cbglL7Oh6GNv 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96389816 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:BPQREazlZfT1bA86tBd6t+ckxirEfRIJ4+MujC+fZmUNrF6WrkUGx zBODT/SPK7YZWPzft8nbNu+80hXv8PVydAySAZlpSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPaET5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVFh2 /kRJxYdUhKolsWp/u6FFNsxhu12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQLxRbJ9 juYl4j/Ki4QGeDOzRqeznyhmdbWryHLfZhCNoTto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYDX/JAHut87xuCooLW7ByeHXMsVSNaZZots8peeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwAlAkEHbCAiXTcHyMjEv79vsEz9E9ZKRfvdYsLOJRn8x DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zt64oEWqPcrWWU JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9aFoSbLkWN4umsWyKJV3iEsJ1fUj Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMcsJF/epH8/NBTBt4wIrKTKufpvU Xt8WZ/zZUv29Iw9lGbmLwvj+eBDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGZinchghJ5oVD79q o4FX+PTkkU3bQELSnWPmWLlBQxQfCdT6FGfg5A/S9Nv1SI8QjtxWqaOm+96E2Gn9owM/tr1E riGchcw4DLCabfvcG1mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:FrbU366/rQH7F9CqWAPXwAjXdLJyesId70hD6qkRc203TiX8ra uTdZsgpH3JYVoqNk3IuOrwXZVoIkmxyXcW2+Ys1N6ZNWGKhILrFvAE0WMmqAeQfxEWndQ86U 4PSclDIeHRSX5nkM39/A60KNo4xsKbmZrY/9s2tE0dND2DcMtbnn9E4+ugYzZLbTgDObp8MJ aH/MJIq36caW0aB/7LYEXs1IX4zeH2qA== X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96389816" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH v2] libs/util: Fix parallel build between flex/bison and CC rules Date: Thu, 9 Feb 2023 16:14:48 +0000 Message-ID: <20230209161448.38896-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230209121156.11040-1-anthony.perard@citrix.com> References: <20230209121156.11040-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain flex/bison generate two targets, and when those targets are prerequisite of other rules they are considered independently by make. We can have a situation where the .c file is out-of-date but not the .h, git checkout for example. In this case, if a rule only have the .h file as prerequiste, make will procced and start to build the object. In parallel, another target can have the .c file as prerequisite and make will find out it need re-generating and do so, changing the .h at the same time. This parallel task breaks the first one. To avoid this scenario, we put both the header and the source as prerequisite for all object even if they only need the header. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD --- v2: - fix patch context We could add those new prerequisite as order-only, but since the header is going to be re-generated anyway, the object will be too. I tried to simply have something like "libxlu_cfg_l.h: libxlu_cfg_l.c", but make find it to be a circular dependency. I tried to use grouped target ( &: ) with a recent version of make (4.3), but that didn't work. And we couldn't use it as it's a new feature. As reference, this is the minimum dependencies, as not all object needs all generated headers, but keeping that in sync with source change could be problematique: libxlu_cfg_l.o libxlu_cfg_l.opic: libxlu_cfg_y.h libxlu_cfg_y.o libxlu_cfg_y.opic: libxlu_cfg_l.h libxlu_cfg.o libxlu_cfg.opic: libxlu_cfg_y.h libxlu_cfg_l.h libxlu_disk.o libxlu_disk.opic: libxlu_cfg_y.h libxlu_disk_l.h libxlu_vif.o: libxlu_pci.o: And the .c files prerequisite libxlu_cfg_l.o libxlu_cfg_l.opic: libxlu_cfg_y.c libxlu_cfg_y.o libxlu_cfg_y.opic: libxlu_cfg_l.c libxlu_cfg.o libxlu_cfg.opic: libxlu_cfg_y.c libxlu_cfg_l.c libxlu_disk.o libxlu_disk.opic: libxlu_cfg_y.c libxlu_disk_l.c --- tools/libs/util/Makefile | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile index e016baf888..c3b21875dc 100644 --- a/tools/libs/util/Makefile +++ b/tools/libs/util/Makefile @@ -40,6 +40,14 @@ include $(XEN_ROOT)/tools/libs/libs.mk $(OBJS-y) $(PIC_OBJS): $(AUTOINCS) +# Adding the .c conterparts of the headers generated by flex/bison as +# prerequisite of all objects. +# This is to tell make that if only the .c file is out-of-date but not the +# header, it should still wait for the .c file to be rebuilt. +# Otherwise, make doesn't considered "%.c %.h" as grouped targets, and will run +# the flex/bison rules in parallel of CC rules which only need the header. +$(OBJS-y) $(PIC_OBJS): libxlu_cfg_l.c libxlu_cfg_y.c libxlu_disk_l.c + %.c %.h:: %.y @rm -f $*.[ch] $(BISON) --output=$*.c $< -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 16:41:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 16:41:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492769.762468 (Exim 4.92) (envelope-from ) id 1pQ9zO-0003xh-UD; Thu, 09 Feb 2023 16:41:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492769.762468; Thu, 09 Feb 2023 16:41:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9zO-0003xa-QY; Thu, 09 Feb 2023 16:41:38 +0000 Received: by outflank-mailman (input) for mailman id 492769; Thu, 09 Feb 2023 16:41:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ9zM-0003xT-My for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:41:36 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9aebdaf4-a898-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 17:41:33 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 11:41:29 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6173.namprd03.prod.outlook.com (2603:10b6:5:398::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 16:41:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 16:41:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9aebdaf4-a898-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675960893; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ug7a1NPUTyNj/QHnZYpUUeMdmOMKtVrrzJhZrS1QEX4=; b=EBLEyRhQmHCq3cEWDC4Yaqq3qDGZ67FHZiFugBYTDsmpX9VEAbg0NXU7 dbbxqNu+2c7b9HJZgy4TXCMCG2YF9QI2I27JXffMwXgQADadXH/1VIe2W hBRPuG47iNQAgSLFZiukKtuouNgtu+S3n5tbHKJRq2F5FnffI6LWMfHgR U=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 96306456 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:QoPLaKpPDelKV2TzzPg5U5UqyTVeBmItZBIvgKrLsJaIsI4StFCzt garIBmPb6reYjP2c4tzat/g9UIEuZLTy4M3GlZp/Cg0ES5E85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADZXNjqvi+yn+eKcR8B3t/gtfJTqH6pK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqKUy3gHOmAT/DjU3Z2bqg6PnmHWsGOliD VImoxdx9KEboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC2 laXkvvzCDdosbnTTmiSnp+ZoSyzP24JKnUFZgcPSQwY75/op4Rbs/7UZtNqEarwhNulHzj1m mmOtHJn2eVVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5L2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:idELCa1CHZiJK6EkzQXk7wqjBIQkLtp133Aq2lEZdPU1SL3gqy nKpp9w6faaslossQ4b6LK90cW7LE80jKQFgrX5Xo3SOjUOxlHHEGgK1+KL/9SHIU3DH4Vmup uIHZIeNPTASXN9kcHx7E2AG8sgqeP3lZxA/d2uqEuFujsaD51d0w== X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96306456" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bg2r4lX4pepouwrIr0nRAEy/GCwILgj0f6Ed+72zK7DhOe2WihSIpW/0Bw3r0lwv0ZzWTDYOSWetNbx9F+mFVxTbcTHzim9GFJzQiCXmrA85hclDgpjSHWUA+5xlbB0vh/I3NHpR6yv4hfETGyZUmhPArBp9sE6qF1TTjFEecAwrcWsPXFOb10QkYGwtJdkGJnDkXFe/goNZeSykny150cDvxL3bH6CPCUgDga9l4tpcQrGa82gdxCpWIBYnedNBRNO5z8w4mRaAkyxi8ITwPe3Ab/BgAtrdY1d/Axo/azQ1nOCvBXpEH3YvXMS3/L6oVR7YksV4KggZg4Ft/OHRrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sufq3IKddfs6jvjPRMD7WCi0B2YbpDb61ilwYUwtVOY=; b=gMzNk2EoGc69xYcoHbMgY7SYEzWLbNrSL4Y9QW9NC0iO4lRz9i/3slx3X5DJ/PbPDSTrMUclbLKQtz6yBowUbUvnD//BCF3fqZO9T28O/25pk+LPHP87GatgTD6XYWiDrwcE1FlGwfpI4Py78kXMZIUsS9aU3Kkyl0mUxp1lDmIQ5PaI3ompg+XUURWU/3rqzxFaV1XN6RRG2f41oH+Z81HEal8L5StGkGKtZmZCvij/ZxgAucYiF36mH/0jcm7HvUHVskxvBkUuIYUri15ltP7hF1GjwN8XWfLPxzqTlvzk6B5dhza4BhVm/unHNd1lzFL4oGNP5D+RRafDPX6Vfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sufq3IKddfs6jvjPRMD7WCi0B2YbpDb61ilwYUwtVOY=; b=kZS/YG2Y7F4Xoh3uyUFFWVAOUlqiyq3vaVoLJxotrtjM6RzZm6nTae7Y/aqJ6mPaDbq0jYnn9LToSt+TU7XTdhpU37j4pZfF7QlnqA9APBOajyXhMoNiZBkbpgnFjA0HYuUVuJd8LiIURLyzL5wF5bcxohEXQnfIHbdeH1OGIg8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <131d89b6-3681-3776-aae1-453ece0a0ead@citrix.com> Date: Thu, 9 Feb 2023 16:41:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] tools/ocaml: Drop libxl bindings Content-Language: en-GB To: Xen-devel Cc: Christian Lindig , David Scott , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Rob Hoes References: <20230209154300.22130-1-andrew.cooper3@citrix.com> In-Reply-To: <20230209154300.22130-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0034.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6173:EE_ X-MS-Office365-Filtering-Correlation-Id: b377a220-2509-4981-0e2c-08db0abc7c92 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SYbrJPk/kbJIarzqoRZpWD86GclxSwRjt2AG8lp6QIvS3jVnUGQhaaDXcsMAsgi/39va4+dmczLYidySw+ru1DFPdsYQ+csTZVINMLlpeDdM9ojYlGj78TRYzht9oOVOPjZb/s7rA4p0TDWTXWHyOmu9pd0eON/G3w3GlioEYoJua6N2jti78ziJit6Gm3+QsLsia/oWz2t6ZIYfHKXwOx71FfYXVvWix1c9X2Bs7azMSMnsPTyUyffpj5vg76EYv5rU6K4nZ2GdV0KdUwEnDl7oifzuN9qi0klTyoZO1vbCiHrIbOayvzS4Trr5tYTN2eXLypCBzSRAjuUdrO8yZyV/AK3w/F040J3ia44RLKtebmELAWmLrx3rQLJfVAf9dEynhUyMAT8LuZqyUKqN0jngcnusTWO2fdlkd1vRKzQXQ62tjhQeCiay2mk4NWMZ9KbF7/Pip0zQxrdGVACrhhA5jY0NyWUIgvQWEzNFJ4vPh4CcgBlA769SUJREeZp538bBHQMpHbPG7jY0nno7BFB7WzQFTwRrigiAbgfGzEj0oxGKl6Ig4/AqgOHTpwj0C/VxD3YeGQ1AW9/I5PGZaJ+Pj6ad3rulCvWYtywm7/xv/cH2k5b28hHwmu1VxSpPJXCTHXGjAV+yLqb2BhGjM3XsyHjOCtU/hL39+7v4dZgePzYi5FNg+TxJCLG4RIXtoI6w0iVTIJ4CPm8WBPuRtS5QMVUI78OyXTpXx7SArU2YE0fdO9m3NUWe5niXiOqu0rV8etdvCZqsl6YjEai0mA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199018)(31686004)(83380400001)(66574015)(36756003)(2906002)(41300700001)(966005)(6486002)(478600001)(31696002)(107886003)(53546011)(26005)(6506007)(186003)(6512007)(6666004)(38100700002)(86362001)(2616005)(82960400001)(316002)(8676002)(6916009)(66946007)(4326008)(5660300002)(8936002)(66476007)(66556008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnJHaC9VMlVtbzhLVytHYjBWaEZhb0tvS09oditpTFdPbTVoUDYzQk03bm90?= =?utf-8?B?UWtXbVVGaXMyaEJRTUdjd2hINzhYUTRNRzBlU2NkbzdwRUJPTGxHeGtmMDk4?= =?utf-8?B?NUtLaG5NNWRPUXlHeFdibm9rclFZZWI0RzF3Ym9HZkFzK3hOWGtlTldHK0Q2?= =?utf-8?B?QVF3ajZCMUgvQkljZHZobHBVMCtUUkI1NGgxbWtvOVFkbW1VUDY1OXlDN0dN?= =?utf-8?B?VXYxcnNuaWJUOXdaQ0tLUTNrL1hGeHo5RWIrMGZUSDVha1IrNW5lTXlLeU5C?= =?utf-8?B?OW5FQWt5ZEpURXVzUTZYN2k5cnM2TVB5alRxWThNZ3dsVmlrZ0JFamtrdGhx?= =?utf-8?B?enpkaGJxL2hiZVJhOU1YYlBaS3loU09BNC8wY3BiY3VsWGlqazZVc25FUXBi?= =?utf-8?B?TkdZMi94QVVaZncxOXdYc3lJd1FJVUlLUWhadVR5Y0pDUUdBV3phbFBLbUNs?= =?utf-8?B?ektPd0t2eEIrSDlqYXJ6NXNTKzhvem9ZMGFaN2FKNXJQMVRBWERLeHNGdVpm?= =?utf-8?B?Yk4zMmRDcktKajN4eWJuOEQ2UlQ5NEpIRXJ4OFBkNW9kT0tlQ1hDb2lNSElP?= =?utf-8?B?M3NUOFRTdEp0cHZPRnJTWk9WVWpsTEJaN1Q3UXdLd2NFMFpmVWpOUUFTS2Qv?= =?utf-8?B?dzd3MEpDRG1zL0drQWxnQUdVNUROREx5WTJMNTNCUlF0ZlA2WE40VHlKenhz?= =?utf-8?B?dWtLcFpGZnBoQW5wOXZlZ05kTE9kdG1GamVYYk9zKzlQekw4d1NMY3lQTzNB?= =?utf-8?B?UGR3OFVCS2VwNnIrL1NuV1BpRkZzMGMxWmhrV0pEWEdxam5jejMwNFhhTWxm?= =?utf-8?B?TWxLR2k3QmJUSFZNekxocDVjaEFoUzdNZTc1Y0pXS2N6djJhb2daV0p2ME41?= =?utf-8?B?amo3Qy9yQjVQVy9IVnBBLzlOVm96N0NtWlhEbzRJM0hiemphMHkyMExWaUF2?= =?utf-8?B?bVhUNHFMb3RKQ2pkV2xFUEkrQ1NzciszaE9Lc2RMdEp1bWZvR3QyQTA3Qm1W?= =?utf-8?B?VVI5R3JqVGxkbXBTWVRmYk5wMnowRUg1U3Q1VFhuR0wxV2tnQTVvZ0JIelJJ?= =?utf-8?B?VDRjRnV0dVRUd3QwWFVRWk1BZTdjOXUra2NiSTNtbGhSRjE1MDFiSWdGSEFO?= =?utf-8?B?bW1GZ0N3SmNEcHJtaFJvNXErcklvWjNyeVFSQ3grajlZMlhONk5HQTJNNk1V?= =?utf-8?B?d1VsNlJldFE5emdSS21vUVE2NTB0YVY0M2FkU0tnbHBQWWdTRC8vc0RYeU1P?= =?utf-8?B?QnRVS2tzcytiUDdmckpEYmh6ZDFMZjFkcjRhRzUweW8yakhCaTRjL2dIM0Fm?= =?utf-8?B?dThKNjhoNkdPVEtDbkRTZWJHQlhrWUI2enJLZTVjMUtwYmxNQ3daKytIcW5t?= =?utf-8?B?eG10NXdpYTBUaDNDTm4rRC9HQnZVTnZWc0RHNVlIbktoeStBUzk1aDZRSk1F?= =?utf-8?B?bENsS2p3RVBsYXBvWnZJRDYzd2hOZWhxNFliREdvOGtmSVFycHRadWpBZzB3?= =?utf-8?B?empNSkFxZHRjWmFQUlcyNytiZ3dqQklaeHNRWlZNaXV0U242YTFVblJndXh4?= =?utf-8?B?VjQya3dYQVF0d3JldGdBa3RHWnV6YlRveHR0TkJhdjJaRGxEU2xVS0M5eCsy?= =?utf-8?B?eWd0Y1g5WEc4eGg2d1NiOEZ2YUc5aVRiQjZYZ1Niajc5dWRJSytUQS9aNU9j?= =?utf-8?B?eFhOa0ZtS3gxZGtTMUZhaU1kaEZwS1N3L3JJUXhzVlozWi9iSUFpdmFtM2dO?= =?utf-8?B?NmpXeVVhYWdlL2o3SE9MK0tPbEFUUjM3ejd4dGY4SFpLRGlYOE9FTldZekRG?= =?utf-8?B?eG9GaTFyZVRLSGw5TEcxL3ZOQmtUNnNUUDJoSU1XekhMTTNoRTEydCt4bHVT?= =?utf-8?B?NHFvNGVPMG10WEltdEVlYnV0blNkcExLdzNiQ0VNN3pJdHZzWlM2ZThVZHRn?= =?utf-8?B?UTRmV2QwWHdyRWNQTlRnRzYxTFp2Z0E5TlVVVHRwTG1aRjBwOTlkc3lBTFhw?= =?utf-8?B?UlI5RW40c2EveFlCSmRuRHd4UjlyQndQWWwzZy9nbjk2ZDVZVSszeTdnd2ln?= =?utf-8?B?dWpRNmg2RHFqU2pvSS9rMHM4dFcwM0g3M0xCemRBcVdkR0RYanh4aWhrVy84?= =?utf-8?B?bHBHQzVDS05ZTUh3QmtEYUV1elJzYVllWHIzWlFQb2NqUDJSUTNCa2xLdnBU?= =?utf-8?B?ZkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 41eiVw7BWPaZarhTfGQNdOrUVWjGG+exjkzSvYKV/5qgnndLpjv6STE5wtWv+Ttl7IAbHjOHWCAui0dq6B+wjTUrYYielG3HUp4YRGjUFraAHwWpRE/MZy+c1YriSb7HC44PeVIXK98Trf/YiOMMq8WOmoNuoixA9WofyZivBPaNbQk1STgCDY0ssBN4LwTg0+7AkCFJAGP0Hq39YxDBqPhtafOaUZq0HCnvQtpDPGJ+eWye++TN0EWEQbf2wT6UeAKVvFqk0mN/zQChnRYlgIVCq5VWZrbg9XxkFWy0/Oc77aShXYS0JcokRNtAEuF0Pu0Py/Ah7ciqNhbrlLlrazxhL21WM5JVsCB/IDbnntsM+YBXUYX9f6KujICo1+UrSfQRqlLSzHF7wk2jeevIrz/6/dgsaglKpN4yfO1qUJoKuzq93zw+vk9q1yrPEqJKknyGitcy3kyw7yhEL2YW5TdbwGzX1GtEB38el0LlMH/vIVyNKvswyXPUX4nE151TZBI/NDeXmZ83Ri8rIqK9olrxasO/NQ4xFxzCfXKJKxc57BlrbabwAORrbEnnC+W50WBQOaiXVne3SaIGLUMS9nelnDSJorgcqrK3T+VyuKXTyxUPwGgHvIdluejePguq2piRx6ClF2QyxKskl5FvU9hC7+E0eXIeW5hP+ZXf4H3ywdCFOuibHB7IzJjWYCi2ApCv2HoBW4xwO0iLItDchwyO54UZ+0bujCEc0IruJrM2JneKqz4QDYV5JL/CqRmhac8qEs3+3uXCjreiI63kV4O0tRzXy+pdVEsHT/QcJJt0nf4mi0iNLATJSwAbSKmLyR6xJMXljiX4Dp9qCp1OzA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b377a220-2509-4981-0e2c-08db0abc7c92 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 16:41:26.6570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iiqEU5TsBSqoRJ66XvC325xpHR6V0IXICDB969nPMt2eU6rY9cCP85SWteaw54v2g9zmUntsZ4ARp9MCXw+uAnKBAUy4R3RfqhFW4hlzfno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6173 On 09/02/2023 3:43 pm, Andrew Cooper wrote: > There are significant issues with these bindings, and their companion half in > Xapi was deleted in 2018 > > https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d > > owing to there having been no development of these bindings since 2014. > > In the unlikely event that we'd want to reinstate them, they'd need reworking > basically from scratch anyway. > > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig > CC: David Scott > CC: Edwin Török > CC: Rob Hoes > > I'm unsure whether to drop xentoollog. They're technically orphaned by this > change, but could be used in principle by the other bindings. It turns out that the xentoollog bindings segfault anyway, and are an an equal state of disrepair to the libxl bindings.  In agreement with Edvin and Christian, I've dropped them too in this change, but I won't bother reposting an extra several thousand line deletion. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:00:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492778.762478 (Exim 4.92) (envelope-from ) id 1pQAH5-00061j-HH; Thu, 09 Feb 2023 16:59:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492778.762478; Thu, 09 Feb 2023 16:59:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAH5-00061c-Ef; Thu, 09 Feb 2023 16:59:55 +0000 Received: by outflank-mailman (input) for mailman id 492778; Thu, 09 Feb 2023 16:59:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAH4-00061W-CG for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 16:59:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAH3-0002gM-6v; Thu, 09 Feb 2023 16:59:53 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAH2-0000hR-WB; Thu, 09 Feb 2023 16:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZUSzi/wdDUAimOkEc/kmjMP1f0yhFP0kEzE9IINWkBU=; b=C6nvDIAG3ZheVVVKBaIGUv+I7k C1WjysEl2yPfpO3HCo6odxuAPqowLik4lDQOyoWOn/jZeJMcBtacH5s2hnNaZqFa6RUmyGiY/vbyW mKTMZBa5KGn+TXEPEQukX67+6sauXVqYBroKGJiKoZt8cUBtCFR9ebpJwIMkapJgO8zE=; Message-ID: <96b3edcc-fa20-6be2-e0a3-966a50ecbbcb@xen.org> Date: Thu, 9 Feb 2023 16:59:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 5/8] docs/process: branching-checklist: Reword the section about Config.mk Content-Language: en-US To: George Dunlap Cc: xen-devel@lists.xenproject.org, Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20221212093410.36289-1-julien@xen.org> <20221212093410.36289-6-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi George, Sorry for the late answer. On 12/12/2022 12:33, George Dunlap wrote: > On Mon, Dec 12, 2022 at 9:34 AM Julien Grall wrote: > >> From: Julien Grall >> >> Since at least Xen 4.12, the revision for external trees don't contain >> the word "unstable". So explicitely list the *_REVISION variables that >> need to be updated as part of the branching process. >> >> Signed-off-by: Julien Grall >> --- >> docs/process/branching-checklist.txt | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/docs/process/branching-checklist.txt >> b/docs/process/branching-checklist.txt >> index d1550385c96e..7004f16e8311 100644 >> --- a/docs/process/branching-checklist.txt >> +++ b/docs/process/branching-checklist.txt >> @@ -69,11 +69,9 @@ ov=4.0 >> git add versions >> git commit -m "Branch for $v" >> >> -Ensure references to qemu trees in xen.git's Config.mk are updated. >> -Check this with >> - grep unstable Config.mk >> -which should produce no output. Replace as necessary. >> -(There may well be none.) >> +Ensure references to qemu trees and Mini-OS in xen.git's Config.mk are >> updated. >> +The variables are QEMU_UPSTREAM_REVISION, QEMU_TRADITIONAL_REVISION and >> +MINIOS_UPSTREAM_REVISION. >> > > One advantage of the previous wording was that it helped you know what the > references *weren't* supposed to look like (although it might have been > more helpful to know what the references *were* supposed to look like). > Would it make sense to add a few words about what they're supposed to look > like? Good point. I will replace the last sentences to: The variables and there content should be: - QEMU_UPSTREAM_REVISION: qemu-xen-X.Y.0 - QEMU_TRADITIONAL_REVISION: xen-X.Y.0 - MINIOS_UPSTREAM_REVISION: xen-RELEASE-X.Y.0 Where X.Y is the release version (e.g. 4.17). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:10:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:10:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492785.762490 (Exim 4.92) (envelope-from ) id 1pQAQs-0007u0-F4; Thu, 09 Feb 2023 17:10:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492785.762490; Thu, 09 Feb 2023 17:10:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAQs-0007tQ-Bp; Thu, 09 Feb 2023 17:10:02 +0000 Received: by outflank-mailman (input) for mailman id 492785; Thu, 09 Feb 2023 17:10:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAQr-0007jg-Ba for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:10:01 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95cfd57f-a89c-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 18:10:00 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id j23so2520390wra.0 for ; Thu, 09 Feb 2023 09:10:00 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id n18-20020a5d4012000000b002b57bae7174sm1730636wrp.5.2023.02.09.09.09.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2023 09:09:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95cfd57f-a89c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u3UOEvVGLa7nvfAmL0eKXVl8ZhK8JMc34Dxz1vYCigw=; b=k1qQ8F25uN34lVXG57adr4dvOgz4XL7JXSj6L7KaLyFOY6zwcc8ZhVSem+YFA/K52C 2ALPIxb8Cfl28/QHz+5OEk47ohQU7YAH9ueWdurDQG12oGQf6Sfhi1o1QwuJM0UN8Zcr woFycYlFomzvhW+94MMRCRaqye5iqvH2h1cCs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u3UOEvVGLa7nvfAmL0eKXVl8ZhK8JMc34Dxz1vYCigw=; b=RWvQYfJABshBFDMtcMkjf1UA9nnp/mvRMKcEp8doEs+5Ufms9yiH3GXt2jguBTiaAX zWrBNPNK02H5zm6gDxVjatnFtwiFtbE3rvsePCVRuSdn9bBiuYK2WxLhrOGw9lfYQOZF xUsGzHlW/ixYJgIuOlpJtD87pPHxqIlY+4IG/JmMXRsAlV0E5j96u7InDiSQH6wOxQcA LdF4iZjsBOpbSeYloo3PbwWjMFkorFB3b0JbmVNr2mrddr82Zb96qqs1MpqyFwDYut3Q pUtqE+IAQBfW0jOetj3I16v2qPvMgsGoQyHnBcjKV5Uz4t+Na4AZ9cUtCExJsGrmdL3O dZqA== X-Gm-Message-State: AO0yUKUpeLtAPWWLRrhmldmmtPfT8PDmS5Th4+abIjhnNabJgY4JTCI+ wWJ3ESYeuCYI550sTI5PHCPirg== X-Google-Smtp-Source: AK7set+0ZD0ce5Dx9an+mEXBrKVDCtP7X8uOalpLRBXELoqI9ljqV2C3RPDpOz5tKr65QP4WZ2h9/A== X-Received: by 2002:adf:ff89:0:b0:2c3:efe7:c632 with SMTP id j9-20020adfff89000000b002c3efe7c632mr12253774wrr.15.1675962599809; Thu, 09 Feb 2023 09:09:59 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] tools/ocaml: Drop libxl bindings From: Christian Lindig In-Reply-To: <131d89b6-3681-3776-aae1-453ece0a0ead@citrix.com> Date: Thu, 9 Feb 2023 17:09:58 +0000 Cc: Xen-devel , Christian Lindig , David Scott , =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , Rob Hoes Content-Transfer-Encoding: quoted-printable Message-Id: <42E86602-7DBB-408A-8E66-D433B65E4FA7@cloud.com> References: <20230209154300.22130-1-andrew.cooper3@citrix.com> <131d89b6-3681-3776-aae1-453ece0a0ead@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 9 Feb 2023, at 16:41, Andrew Cooper = wrote: >=20 > On 09/02/2023 3:43 pm, Andrew Cooper wrote: >> There are significant issues with these bindings, and their companion = half in >> Xapi was deleted in 2018 >>=20 >> = https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6= d080f4fbe933d >>=20 >> owing to there having been no development of these bindings since = 2014. >>=20 >> In the unlikely event that we'd want to reinstate them, they'd need = reworking >> basically from scratch anyway. >>=20 >> Signed-off-by: Andrew Cooper >> --- >> CC: Christian Lindig >> CC: David Scott >> CC: Edwin T=C3=B6r=C3=B6k >> CC: Rob Hoes >>=20 >> I'm unsure whether to drop xentoollog. They're technically orphaned = by this >> change, but could be used in principle by the other bindings. >=20 > It turns out that the xentoollog bindings segfault anyway, and are an = an > equal state of disrepair to the libxl bindings. In agreement with = Edvin > and Christian, I've dropped them too in this change, but I won't = bother > reposting an extra several thousand line deletion. >=20 > ~Andrew Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:14:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:14:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492791.762500 (Exim 4.92) (envelope-from ) id 1pQAVW-0000jN-1A; Thu, 09 Feb 2023 17:14:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492791.762500; Thu, 09 Feb 2023 17:14:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAVV-0000jG-Ui; Thu, 09 Feb 2023 17:14:49 +0000 Received: by outflank-mailman (input) for mailman id 492791; Thu, 09 Feb 2023 17:14:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAVU-0000jA-5L for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:14:48 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e885964-a89d-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 18:14:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e885964-a89d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675962885; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jQ1PLlNDwtqU3pjQr0Mg+mLYkOOB2zsi0o8onM3YLg8=; b=B3+d25wRUjSKGthJhomsWlaSAvDqQOj61jT+AM4nzFJR7IitxQch75nt BNjD/y75IRxiLy5QJ8F7MsPaF522tZ5La6+BwfRLKU3q/MyxC+tUwudVZ xYbssSrbvEqHUO908nTogefMcqNtBp7/0nk8/+jEOpRQhrHPCX8cI8CtH g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95798381 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:pScv+6LHcWlcAIenFE+RB5UlxSXFcZb7ZxGr2PjKsXjdYENS1WcGy jBLWmqHb/bcamTzfY92boi+oUNV6JGEmt5iHgdlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5ARvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5rDV1eq MEVJgwCNB6/2NibnYqEUcZV05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbGJoEzh3I/ woq+UzaXxwEboKR1QOU+zWIvvLslA/2RNwrQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 1cP5iMkoKw29UqqZtrwRRu1pDiDpBF0c9NIHvcz8g2l1qve6AHfDW8BJhZDddgnuckeVTEsk FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkxhB/SStdoEIauk8b4Xzr3x li3QDMW3utJy5RRjuPioA6B2mj3znTUcuIrzhnbYnL40w53WIH/abD303WG1clbA7/MGzFto 0M4s8SZ6ekPC7SEmyqMXPgBEdmV2hqVDNHPqQUxRsd8rlxB71bmJNkNu28meC+FJ+5eIVfUj FnvVRS9DXO5FF+jdudJbo24EKzGJoCwRI2+Bpg4gjejC6WdlTNrHgk0PSZ8PEi3yiDAdJ3T3 r/FGftA9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLFupVYALWMLFotvLsTODpH zB3bJviJ/J3CbKWX8Uq2dRLcQBiwYYTWvgaVPC7hsbce1E7SQnN+tfawK87epwNokimvr6gw 51JYWcBkACXrSSeeW23hoVLNOuHsWBX8ShqYkTB/D+AhxAeXGpYxP1FLctmJOZ9qLcLIDwdZ 6BtRvhsy89nElzvkwnxp7GkxGC+XHxHXT6zAhc= IronPort-HdrOrdr: A9a23:lEmHsKg+FKGNgRQmwLRcnWvDjXBQXt8ji2hC6mlwRA09TyXqrb HVoB17726NtN91YhsdcL+7Sc69qB/nhPxICOoqTM6ftWvdyQ2VxehZhOOIrlGOdUyfh41gPM xbAsxD4ajLfCVHZKjBkWyF+q4bsaK6zJw= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="95798381" Date: Thu, 9 Feb 2023 17:14:29 +0000 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH] build: move double-$ into as-option-add Message-ID: References: <6eecd308-b871-7826-a99e-57c6d7d52140@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6eecd308-b871-7826-a99e-57c6d7d52140@suse.com> On Thu, Feb 09, 2023 at 04:26:45PM +0100, Jan Beulich wrote: > It's imo helping readability as well as uses a little if properly > arranging for sufficiently late macro expansion is part of the macro > itself, rather than all (applicable) instances of its users. > > No functional change intended. > > Signed-off-by: Jan Beulich I agree, that's much better. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:17:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:17:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492797.762512 (Exim 4.92) (envelope-from ) id 1pQAXT-0001Ke-Cy; Thu, 09 Feb 2023 17:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492797.762512; Thu, 09 Feb 2023 17:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAXT-0001KX-9z; Thu, 09 Feb 2023 17:16:51 +0000 Received: by outflank-mailman (input) for mailman id 492797; Thu, 09 Feb 2023 17:16:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAXR-0001KR-ML for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:16:49 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 873a7160-a89d-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 18:16:46 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 12:16:29 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6935.namprd03.prod.outlook.com (2603:10b6:8:47::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.35; Thu, 9 Feb 2023 17:16:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 17:16:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 873a7160-a89d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675963006; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=giigtPHYRUqpsXx8HCxypn8sKhOTkNCN48q7v0A35vg=; b=QZEfDOy881OnZDU1aeTj47DrU2STGMy7lr3mYXbMDlHX6IiThyW0R4VJ dc0+hRVz3rEy/qT1dlcVaA36nxQbRwSIyxLaRpOp6D4M92jdqX0Eyh6x4 qJd4cj5WW9K/cstA+mDTOK9Vak+5R3xyFK4/yvRG72D4ej3kVVbW1EAza M=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 95243317 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GzGQAamBYBwzV4lngO5jV63o5gxUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIYWGjUOviDamD3Kd5/bY638hwOvZ6AyNQwHgBsqiEzQiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5A6GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 c4edHMMcUuNu+C73rm6CbZhi9wYIfC+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDSefkraUz3zV/wEQwSw0Nf2TqrMWJgw23WOhnD WIO13sh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWJqTK/PwAFIGlEYjULJSMe+MXqqow3ihPJT/5gHbSzg9mzHiv/q xiVqAAuirNVitQEv5hX5njCijOo45LPHgg841yOWnr/t10oIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF6rFxBJ1bLkVhs3QxD IronPort-HdrOrdr: A9a23:SOwmwKgKUMAkdnGEhj3FAJcTwnBQX8d23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewKkyXcH2/h3AV7EZniahILIFvAZ0WKG+VHd8kLFh41gPM tbAs1D4ZjLfCNHZKXBkXeF+rQboOVvmZrA7Ym+854ud3ATV0gJ1XYHNu/xKDwTeOApP+teKH PR3Lskm9L2Ek5nEvhTS0N1F9Qq4Lbw5eDbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK7aY+/X PDmwnZ4Lzml/2g0BfT20La8pwTwbLau5d+Lf3JrvJQBiTniw6uaogkc7qevAotqOXqxEc2nM LKqxIAOd02z3/KZGm6rTbkxgGl+jcz7H3Jz0OenBLY0IHEbQN/L/AEqZNScxPf5UZllNZg0J hT12bck5ZMFxvPkAn0+tCNDnhR5wCJiEtntdRWo21UUIMYZrMUhYsD/HlNGJNFOC7h8ogoHM RnEcmZzvdLdlGxaWzfowBUsZeRd0V2Oi3DblkJu8ST3TQTtHdlz3EAzMhapXsE/IJVcegy28 30doBT0J1eRM4faqxwQM0bR9GsN2DLSRXQdEqPPFXODsg8SjLwgq+yxI9wyPCheZQOwpd3so /GSklkuWk7fF+rIdGS3adM7gvGTAyGLHXQI/llltpEU4DHNf/W2XXpciFrryLgmYRQPiTjYY fxBHoMaMWTalcHGu5yrnnDstdpWD8jufYuy6UGsmK107P2w7LRx5zmmdboVczQ+GUfKyrCK0 pGegTPD+N9yW3uckPEoXHqKgbQkwrEjN1NLJQ= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="95243317" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7SWLBe0bVvOfwIkOZ308lS6XLYwMxvdZURj//9o5akKU0mvTtmhBTtRG8hC1hGTHzHGKJIOn1EF3Ctkyfwj7g4ydEIXVIu8RR8FZre5UFLd1gmsjT1ZZzmEbQl3x+Qi5uZ4ohOQSQyZuYFpn6L05+z56orvwPMLcKuRMYB6zNU//dOMXKBuMZntxenFUF5Xuus1hfSWG66qks+baM0OFAZCScJrelqqG9l1eFkzoDj0dpU5MzPY8feL6sZBgEytgVxcQyjIVI9iD1+5RMVb9ZCN1b8z4FaNQsPcvE1t9+EarZcevvbji8exp99DAZ2L/vLivJPheKmKCeHPbRYNhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=giigtPHYRUqpsXx8HCxypn8sKhOTkNCN48q7v0A35vg=; b=ZSYcMtLPTqC+U8bqFrESM2C9l9DeCJ8xhr69Pvk18GKG02UXLX+PlqOTM5/D8JauIPQzB77afPYLaWYVfG9Gxjkd5TjVK01s7SuWuNSR4BH1jqubAaTWkz1cXBwW4a2VS6Cz9xBFg315sMwasCVuElD7Sz6q6gDju2sQPZ2MXEh+F6EcdzQujv72p5+CaElgZR+cmlon2jyKDFiEU0qOmbcyRR4h13TIy/HZx3vocW3dDulnVpmatoP4kjgB3+zMmw0uSlH/iSzhdolWz352w7NRQx9CFL5taipwxnf5vRwb0aU6BcdRnaXIDZ6r07WVGzYamfRJNDDYHuFWhlqSIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=giigtPHYRUqpsXx8HCxypn8sKhOTkNCN48q7v0A35vg=; b=m+GrwPKXq44O2Os2Rg4TJkB1HF1C8q/0nEXQO0XfWG0YaS7L0BEcs4Nd1WzOzPOV8U7iulLlN2JcQ86tJQFKimDCk6YdIDOrv/x809a05lzg21wZNOyDbTskvyAyWAf6ztspi0WhhE+iV5ey1ooxfjT/662NCNHHFGnJZRAacyA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 9 Feb 2023 17:16:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] build: move double-$ into as-option-add Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <6eecd308-b871-7826-a99e-57c6d7d52140@suse.com> In-Reply-To: <6eecd308-b871-7826-a99e-57c6d7d52140@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0015.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ce2c12b-e483-44e1-071a-08db0ac160a7 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WdFq9ydNzJMxA/iYARpysBHUYi40TejOCnhd8idCQYeqGpHQMdjL7IHnLfSIwAYZ4V+7P9Vqd/L5SgqFZbjkwAd42vM4Y6T/iElhVsroe13YwFO0MRBM+DwjmePEUQE96vwA6Pm+wZzhiPUTuL8RSjnZw85crNl+QHoTNInq9O2coyQcBOU+t1cvKgAA4rYlm+XNi3u0AXv1Mkc+1JlV/qS8smRi83X4UfH1mrFOnytK3NLEwysp+6XjYsfjry6d2Z0Z3b2ARcZQytedkmynY7mFwPZFaGNN0kEXe6vttQxV6izcEaLc5Si/jDsH/gI179LMM0aRuGjXCHcD83ka1C/aBa9Ngbk144wpV83RjNVNES21S2P95xdgRfgPgywHSQDlSGFTVuI18gy/XSW4sUc23s9jgJnE26WMJk8G5V86o8hHHHpp1g5stW92Ydvf1pTLeBvfo6t5r+9UZRWbBMn4GO1q5RYledCNiZZrAcI3XVDfni1tQBQfvn4eafRzW9vYYwN6VzHsO1v3lPvcDaeHgtTkcs+qyg93+2Wal2eAYejENERfoEvbMv6oSQiN2XZzGpPtbMO8SJW3630tHcKGlwSsxS9QNV++OCf14KmcOmOlUx00xWreTAYJf/NytvtOavPL0nxd8JGIzGGmoYhhO6egzRegpTD4hHOSDBfYbbwwRpu3DRJQg38tMtZ91CPPRgzRt2CB0gHrJaOtJB3Fh8zXozNJDBZOXYbeO1k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199018)(6512007)(186003)(6506007)(53546011)(2906002)(26005)(36756003)(6666004)(5660300002)(478600001)(31686004)(107886003)(6486002)(8936002)(82960400001)(41300700001)(2616005)(4744005)(8676002)(66946007)(4326008)(66476007)(83380400001)(66556008)(86362001)(31696002)(110136005)(54906003)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MENVS3c4Y21lT3UvaXNXZElqRmFCd1hQcnFCWkdoM0xadzBKYmpiTzl4Q1ZH?= =?utf-8?B?ZEtOT1MrM2s3NkhYd0Q1NDVzT3Z2VUpJamordUUrVWNNZHRHZHJvbDZWT1RK?= =?utf-8?B?NkN4NDBZQUlTTVFmZWsxV0JaNnMrTE9mSUZkS0NJOTkvdnlrck5xcGZkc21q?= =?utf-8?B?TFViY1FMcHhtZzlycmpLd0N4cTJ4SFNnUHpzTlZRTnZLWklZUTBFMCtqd0tz?= =?utf-8?B?cG1kME9kZFl6QUlZYkdkSDhsbEdHcVJ6dmRkeXd6RURKL1o3RHkvYlVGVXBO?= =?utf-8?B?L24xSkdvT0FTRnY4Q2NIbzk3RHF0VmJpUFJYRUJJY2xxS09ZdS9xK09CcUpD?= =?utf-8?B?d0RSK29LazZmNG1WSE8yQytZSXVvaE5qSEc4ZERmOUsyb2l6V1UvNkFhV0cr?= =?utf-8?B?WWwyeHdEMXVKeUtRQmt2V3hGV1BXNERDTm1DOFBvUmdIK0VnZ04zSEE5YW9C?= =?utf-8?B?aURrZCtmMTNLTXBaQWtjNjJJbC8xN0JWczJBQXNmZ3BYdDBvelZ0N2xZSTZS?= =?utf-8?B?K0I1RUFENUdTZDFCbGZIQTVFOWE3UHBtNDhzV3N0ZmE1dFIxSTE0NWFSSVFU?= =?utf-8?B?bWhKUHFsNllWV1dleEhacGNjcDdTRm9xQTgyZ0hhd05yNTUwVzE1QjJuMHNK?= =?utf-8?B?dDFtWjFWdHk4bzVFb3prSThEUmhMN3JCS016ZXBOQWNZNCtDMURaS1c5T1l4?= =?utf-8?B?dGRDaVFiZFhvbmFKZ3NXbWR4bURpdGx5cXRqR2NvQkZVNGhrQ0JtQ29yc2x4?= =?utf-8?B?ZGV2dUc5elhnSit2VExPM1k3RXl4MFZCREdEck52amJZUFBmUXVrRzU3K2Fm?= =?utf-8?B?c1YvRUFoS3BYRGQ2MkJua3ZOVEJhdk1mQXZCTU1nZXNhYTF2ZEZFYy81NVhV?= =?utf-8?B?eHF0NnRQRHhRZjZCVGlNZFVuNHJETXQrQzNNNm5mSTJNK0tjMVQzcVlwWjdC?= =?utf-8?B?ZE51TkRpalArTVhuWVc3UUZQMzFJdVJIdEgxeU5lemNDYlR6SlNkTHpuN1g3?= =?utf-8?B?UVNXa00raTl3eklRMDRUNG1aM1dwSXdZeHQvc1FKYloveVV1ZjlTTnNFQTQ3?= =?utf-8?B?c0s3R1dNZW1UMlZaaVRsczlGZWcraURJcURkTGVWVWEzWFRqV0xXdE50YmZJ?= =?utf-8?B?ZEJVVEROQlRBNmdwZ3lKcFBHcWF3SVhmZEpNYkorbjMyVHJkbkpCSVVDK2Ez?= =?utf-8?B?a2VnZGNseCtHaGdFcjlSVnRpQnhRK0JRODI1NzNVWXllcEFXdXYzQlh4aWNF?= =?utf-8?B?SUM2ZWFlb0Qwc0VFNnhUOXVWNlFkQnVwOUI2eEg2Z3Awajd6cU9BQWpGRTZE?= =?utf-8?B?UnZFOXRsKzZFZDhGcjg3M0R1TkRIYXRqMWl4R09xN0F2RTlRZHpQdmpvS3p2?= =?utf-8?B?QjdJd1FMdzBpRHlkenc3ZFZpalFaUW0rWTljMUZpRTkwU3pwdFN1M0JtaThG?= =?utf-8?B?OUtUQ0JNazNEMUFtY0JuRHhOVHVlclp5YVVPT3ZhYVEvNHRBdUdKUEVaQVVz?= =?utf-8?B?SjlJWS9RVHdrdm9OOTRSOHFyZzYwSlpEUkl5ZGtzY3ByMVVaeVpTMUpCTC9R?= =?utf-8?B?SjZoRHFMcUE1Z0pMalV6WlFVemNzY1pROTNkdVlPWEhkaFU4Sjk0Umk1aDJn?= =?utf-8?B?anZzNnZWeU5ZcDRFaW05U1h6V3R4QVA3MFRmU05IaWo5Rk1TZHVCYmxMV1ND?= =?utf-8?B?R2lJZzB4c0RpRFhNZ25KdkRBb0U4MkgweXRtb0JjQ1p2ZnYyU0JlbUZEV2wx?= =?utf-8?B?QnEvenROT0krMEVGa3hBZ2dVMkgzVGYwZ1A1WG5PR3ZjYU0xb1dzdGorelhM?= =?utf-8?B?cDhENTBRa052bWcwQit1QjczY3NoWnlwNlI4NWxwOG5XZHR2S1BsSEE2Tm83?= =?utf-8?B?S1B2R0pRTnZkQjZLUWpXdVlSOFR5YW1jQldKUjk2aiswZXp6cmdYUUYxV2dS?= =?utf-8?B?NXYyb0l0cWU3cFFpa3V1NnNCcnhrWUpMZThEeXFFRUlHSnZBWENla21hdkRw?= =?utf-8?B?Z2VBZGU1c3o2NjNJcmRaVEhUbkYzNDF5QUFqMUVybTZLTXh0Z2V1alQ5YmRS?= =?utf-8?B?M0xuQXI4WW11Ty9FQ2NOc3B6MkRwVTdDd01laFFSRjRxYVFCTGJXbUxzRWlX?= =?utf-8?B?NHBvNnVDeFpRRTAxeU9MK01KaGp4S0t0RVdTcmlYcTRId2F6SU1SbEh3Vld0?= =?utf-8?B?M0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6f7/2COhkCASqrQxFfehXQTM7wg42X3iAQNUCG4E8aUp8t1jjdiccplJYB4KEhkJe6rxjqBRB4ydGb/OeKxv0lYVVuDlEqzdD+Hm5XKLSv331KrURx6xbE9HiNti9OlAqXHp0qc780aqPhZlvO7OJjyR58upcvViHrys0OiNwY7jvWRM5LUi4w5EWsMS8enF1iGEOTfANEd5v8awOsWgANh600ZTTmUcqC3SwxZbG/ItaQ64fpWXQrcewWjtSnMycq/MhO2vivCzNl06wEIVCUnyQh2RoQKDZNLgIHO0kMJYx/UkjDHWhf31rFgYiT3aDbqXbny/yE8MJpjBhunwQkMQthB4Xy+qRSCTwz9T72YC+KjVXsvYa7Dp5I0UE0m+5c20M6sObulYB4IYt50INw5yhcutf2ZyN/l9llGyZ/55ePlSSifD8hG89ZUJ93Y9f1eNshkhgTLhsqTXG1LgBD1Si7BNF+G9eKOMjMAJw+hZRky8rjpy8KTU6Gk8f1StvH4toXhGa1/MsslU3EVDiFP5xVmEkKHpebQrUOztDhz2l1UZC6Lg35MFKpAmC9/Ilj9lt7dddCpNFSFoPmxosBoXgtG1Bkfy0xSCEfHe6d1L73k5eQZq1duaxnOfF6fZQnNvsbh9fclyaWxB2gUKVy06qpJ4EIUMwYa1v5UbnoDGNkTa1dPMO8XCAQ1PdDb+jgyY8AO3xf22HJBElFxOV3dpb9kepsM3hB63VKxeXy3l1v8yFfhOiNoz5IZixvCp/qAYcZNaA2sV5PjQQY/awXoEEvI9qKguF6z2LSuhAy7jUEF/DbmqNrYqdu5eLK6rkQ3ZgeR41xlyns0IMFKYXNv/YOlSlYReQeX9kuRbvKw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce2c12b-e483-44e1-071a-08db0ac160a7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 17:16:27.3019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mneIjQ3ORdmCmsXK8z5GbCQwupUz78KpE7d2vDX6151y+55EHBmXLh7lCyqmuo3uCyeqrkKoWBe+/CuIAeHiyjHxNLK1li0rD2vhsVO03KM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6935 On 09/02/2023 3:26 pm, Jan Beulich wrote: > It's imo helping readability as well as uses a little if properly > arranging for sufficiently late macro expansion is part of the macro > itself, rather than all (applicable) instances of its users. > > No functional change intended. > > Signed-off-by: Jan Beulich It is an improvement, but I bet this is going to trip you or me up on the next relevant security backport.  Just something to be aware of. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:24:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492804.762523 (Exim 4.92) (envelope-from ) id 1pQAef-0002yn-5v; Thu, 09 Feb 2023 17:24:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492804.762523; Thu, 09 Feb 2023 17:24:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAef-0002yg-22; Thu, 09 Feb 2023 17:24:17 +0000 Received: by outflank-mailman (input) for mailman id 492804; Thu, 09 Feb 2023 17:24:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAed-0002yK-0w for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:24:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAeb-0003Ln-SS; Thu, 09 Feb 2023 17:24:13 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAeb-00023q-L5; Thu, 09 Feb 2023 17:24:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Gwv0+i9rGhdmE7m4P9YKBe4hHLpaLETIcWI34rg75Ec=; b=Dn9l+ylQDQwC5KwdXTiyeADsn7 6iMpxo/PvIYkXGtWTzacM2fNnzlEmOF7VfQB8n7q9jpjbiHWYgF9lR5lxEYU9jN02IV+dJlr7W/zx /LoNhvrhxRu+YjDt1xXd2oGA3IFrSHJa6Ec4cbSUyg9tGztucOthYe4x4eXC+a3wo5SI=; Message-ID: Date: Thu, 9 Feb 2023 17:24:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 0/8] docs/process: branching-checklist: Update it Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , "ijackson@chiark.greenend.org.uk" References: <20221212093410.36289-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/12/2022 09:49, Henry Wang wrote: > Hi Julien, Hi Henry, Sorry for the late reply. >> -----Original Message----- >> From: Julien Grall >> Subject: [PATCH 0/8] docs/process: branching-checklist: Update it >> >> From: Julien Grall >> >> Hi all, >> >> This is a collection of improvement for the branching checklist. > > Thanks for this work! Since from the docs/process/RUBRIC we are having: > ``` > They are living documents, and no special approval is needed to modify > them beyond the usual acks for commit. They should be updated as and > when it seems expediant. > ``` > > I don't know if my reviewed-by counts but I did go through the whole > series, so for the whole series: > > Reviewed-by: Henry Wang All reviews count :). Thanks for looking through them. I have added your tag to all but one which needs a respin. > > Kind regards, > Henry > >> >> Cheers, >> >> Julien Grall (8): >> docs/process: branching-checklist: Use consistent indentation >> docs/process: branching-checklist: Remove reference to qemu-ijw.git >> docs/process: branching-checklist: Remove reference to root >> docs/process: branching-checklist: Clarify steps to add the branch in >> osstest I have committed up to this patch. >> docs/process: branching-checklist: Reword the section about Config.mk >> docs/process: branching-checklist: Remove section about the cambridge >> colo >> docs/proces: branching-checklist: Update the section "add to patchbot" >> docs/process: branching-checklist: Add a list of accounts at the >> beginning >> >> docs/process/branching-checklist.txt | 122 +++++++++++++-------------- >> 1 file changed, 60 insertions(+), 62 deletions(-) >> >> -- >> 2.38.1 > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:26:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492812.762534 (Exim 4.92) (envelope-from ) id 1pQAgx-0003oo-Nn; Thu, 09 Feb 2023 17:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492812.762534; Thu, 09 Feb 2023 17:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAgx-0003oh-Kt; Thu, 09 Feb 2023 17:26:39 +0000 Received: by outflank-mailman (input) for mailman id 492812; Thu, 09 Feb 2023 17:26:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAgx-0003ob-1N for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:26:39 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e7137179-a89e-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 18:26:37 +0100 (CET) Received: from mail-sn1nam02lp2045.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 12:26:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5130.namprd03.prod.outlook.com (2603:10b6:5:1e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 17:26:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 17:26:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7137179-a89e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675963597; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=wDHncq4T8makkjtymMII6kUCENYxW9Uo3GjETb4cFi4=; b=ffpy7JP1AHcKZJjeF29J85+wWLkkbAfyTmMUWnMVw+p4+UGeV0n3AbES 6Y+pN8a9kAxpHa6u0lnazaGoVD1vqpZHsnGSP9cRNxDSZj4CTffsgwl+l ibwzuoQIpSlONa1N9ykuOOgi7a9YrsokqoO6GxHdFYwRZ/mkoOUcyOHZt o=; X-IronPort-RemoteIP: 104.47.57.45 X-IronPort-MID: 96401910 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KB/Kmarq9yU7RwLMEwsP7lKV/DVeBmIuZBIvgKrLsJaIsI4StFCzt garIBmFbvrfMGOnfI0laI+28EwOvJKEz9dmHQdsrX8yQn8Q9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACpKQC6koMGt+7aYZvFr2MslN+7kN6pK7xmMzRmBZRonabbqZv2QoOR+hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeerbIe9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzmqqYz0QTLroAVIAE0TQOigt+SsRadR/97N UYKxyp1rYFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsUQoAy8nupsc0lB2nczp4OKu8j9mwAjepx TmP9HI6n+9L0ZNN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:0B5KVq5H1fYF+3E+KAPXwBTXdLJyesId70hD6qkoc20tTiX5ra qTdPRy726WtN9jYgBZpTngAtj9fZq4z/VICOYqTNCftWXd2VdAT7sSkrcKoQeQfREWn9Q1vc sOHZSSEOecMbETt7eF3ODSKadD/DDzytHNuQ6o9QYJcegFUcFdBkxCe32m+wVNNXN77LQCZe eh2vY= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96401910" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWYmMWh1x/LuA2eMLd8qCNyzB3/iIlxPAFEhGB+LU4CeWaxyVDy3PkUkarrOiPIIQsbdmxoDuR8a8r/EsMGcxNLtTFhwaKRxl81mdZyQGlHWVW/ViLSUnVR+blyr2h/HfkR3Q4Yj4osiGiBI7se758M+HYqOmhFdqsaGEYaKaU3ufIdhXyIucUbHcKQpzvITr6TiKYs+jPaNMCxi1/ILTdOHU/AFzhJ9ivWG7GSNdNkiHQlB1RCMnap7VX+bsfyjyClRkJonQpFpaAAUS6yhKNPfzTu+tCHHQ5AUPLp65qIMEdvy53zHvUxNo0OYEiGKsZN0nSRkNaKs7DR4OqQRGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qXSoiHqzF5sku05KOPYN+Fkj22jfeW5+TWc/spDNkbU=; b=oS53/YsQQJFQFnn4sDQ1u0jDjZ/1IKvuV7XM84QEOR/eatncRJ/0iVxyOKej/JFYj/sZhzXrbP4TDplpYQWMQWvB8rPZbR4AGJUAfhEnjsP+26hx0HOrkORMwXeGXXxRquRHIU8YhGJ480G5KpmLpgy4y/eH47IdTsuY5GGHbgYX8KfTtq946f4+yZpQvOzzfPXHQUTPRz6v0pOMHeSUHagw0YEalmcQpnyeYmaHWhx5raBdySvOL6GL+ECE2L8K1ALRu4uEUfIlmP4HT2PAlG93P/W/ehJZml7o0cXbm6Pzy00NNhBYcXDVRYysJ9FfzpHdUumIkvk5stE4VIuhVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qXSoiHqzF5sku05KOPYN+Fkj22jfeW5+TWc/spDNkbU=; b=mXhCxu7PiVFlauOVhJC7SRqUqMEwx6/0dYY6Bin+QgLvePM8XwL0Bxt8I3fD1RgsV6x7vgqEMJ7VDnYK8MkssxTzULfa+X8jVqwSvdtvSuxMRv1FYyVVYfkq9pvuit5JHEpLfJG7iqf8v2DHi/ASQtjit4sV9Azs6RWoO1ostVQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7751faad-d281-bdce-60c3-74b17f57313b@citrix.com> Date: Thu, 9 Feb 2023 17:26:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 4/4] x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <7d2dd28a-a821-e906-6245-ab26e5518706@suse.com> In-Reply-To: <7d2dd28a-a821-e906-6245-ab26e5518706@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0226.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5130:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ac1f3ce-f69b-43d7-306f-08db0ac2c8e6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IU9A8pq2hU8XTY8Z+rhZrhpjjGD/xccykdbI3RJzHUgdj+WAt9An4UEuQn0bjPhqEPZKCPLefVCiLZq1sGJTvq1+2aex8R+9XIKI/ZnhE1wI2fl2ltvhKtTOeV9T6DtZO359ycACpI/G283A3Kfrmpdk1hrf/VlU4NR7b8vBkHxLlJQLdqbHxkpROM9xBGWNSwd3cfDmZUQtkQViN+U3PPvsY+8j2bn2P2DcIZrbvxXZ0LBZRsV1kDyFy56PEqv0IdAfdrFRi6c7d8dY6ZYqYAqBBMUafHY62W5gJwQ3iKZTeWMbwzV3WL/3ZhWOV2bbLXwObzQzRmryI7/xCKpUD7sWJI8ZzRj3bZDFhMqu20C+MayEmnG+Mc5tXamKedzqARnVytwPp3366lx1TUu6mWFXeomOE93T6xXdVOMBU1LQ4+NsO3rJPxyW+XZXb76yR6cf6/Jvj3l4kMNNnBzXa+0faYAr5mN/+tp8UiQIKCI5x1cIt9yEgYJGCrwo7GZ9DJbAIOSrUPec0gz0up24aD0T36iSXlGXQjPUrOwZWqnodYOF/z7ojEG13Ayb/VKSj54KicuM+eae3t1ao5maBRqfJ7MSA9KzOXqgHBEtG2ZbmGoRSoDCFQ/ifpWv64eOsKN+Fb4GNDeuMrCjxXYz5u06N+QsFBTOX0VjvZxCaKtrj5ZZMFNqGvy4Az/1W1bKzZBYyagcXIwWZYT8zT0spZItdFycxHMMRJY+xoi9fl0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199018)(66946007)(4326008)(66476007)(8676002)(31696002)(38100700002)(316002)(66556008)(110136005)(54906003)(86362001)(5660300002)(6486002)(31686004)(478600001)(186003)(53546011)(36756003)(26005)(6506007)(6512007)(6666004)(107886003)(2906002)(41300700001)(82960400001)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3JZbE03Wkg3VERWQUd0bUMxSW5SbHNqTHBqejNjZm5BcWxmc0ZyNWdnNDBM?= =?utf-8?B?MS9oWmZkMWVabkYxREYvMHNOT25aMk5kam44Y0JNZG53ZU5yelhGdnFyWm5q?= =?utf-8?B?NGg5bXVxVFpLajE5OEU4WTV6NldyL2ZJMmJvOVBPUldWOUYvcXFrYWxzQkNa?= =?utf-8?B?ZngxNUVzNFd6d1F2RWMrZG1tdmc1TUlUeFRPNGtRKzZHT2xXVCtUenBrcmg0?= =?utf-8?B?dlFHZi96Y3QwcXJpRy9yUk1ZdXBjcTFjaU1MZTRuMm5BNkRUTlFaN0dJWG9W?= =?utf-8?B?K1BYUFBvV0xVUnlqK3NJaUZZOGI2dVRlS1BhVzdMWW1CYjlQRTFNUmIxMi9i?= =?utf-8?B?NVZuOEVHNk85a2o4TGc1SDJWemZJbE5Sc1hCT0tuVjFyNnRjaHdMZjNpbDBE?= =?utf-8?B?THBTRnZhclZrOHVHQUdyb0ltVFF6K0puWjRkTVBuaTF6ZVNmOWx2eGd6WjVp?= =?utf-8?B?dFlmKzFpY2pWSUxaMDBaQ3NacVpKYlYyNUEvUWxmYlJ6MzFTdmZ4MjJSUC9L?= =?utf-8?B?eE5zeFhKRlE5eHBwU2MvZGp6Y2xvVXBzWE5CekJIaUVYbFVxV1lQNnBSd0Za?= =?utf-8?B?cVIxYW9saDVqVE1QNDZKakhmVXFDN0g5UWN0WjhjTFg0dmF3OWhmR1JWTTdy?= =?utf-8?B?d05jWUsrZk12V2RLMzBjSU10NWF4UUhLU1FqMStMNjNNWU5weWpGTFNFYlYw?= =?utf-8?B?QUVFME9lL0dqM2ZJZWptalhQUEh4ZFJYM2h4Tkx1Z3ZWSXRHc2xrNFZSbS9U?= =?utf-8?B?eEhMRXBZbHRKZHBTVkFiVzBNcmo3TXhhTXZyTGM2blQ0TTZYYUMrNUNPNndY?= =?utf-8?B?SmRhM3hBTjN0dHlzUXRtNGJaYmtaUUJXRHhHaUpERU9saUU0MmFyczFUWWZQ?= =?utf-8?B?d0xiMVVTL3BnMFlyUDBabUdyNHQ4bFRuWklNaVdjRUVwNW9OWWV1UXFqSU91?= =?utf-8?B?TFNrTW93R2puc2VVd3VPVlFsZTFFUDRxNDBCdHNKT0Y0THppNERyaFU5TURQ?= =?utf-8?B?UmJWQnpkQ0NXbzcvZWhpQ0NuaWgyZGdFb2NVemtydFlwbjZ5dUY4MVNTMkFE?= =?utf-8?B?Y0FIWXh2cGlLLzN3aHZ3c0lyT0huSXpZRGlMV2IxaDM3NFB6R0dmTHNXTm9w?= =?utf-8?B?TStzRTZIT3BmREcvTTBhR3c3VGc0MGhUNzNkLzd3WnVMMEZOclVLTGdFaHdj?= =?utf-8?B?bHFJc0V4ZU5DRHozRmpqbkNFa1BRaWtaRnFRNm5zSkZOckNRMmMvakIwbTRi?= =?utf-8?B?cUkvSTMrTkR0MW51QVVZZzVPaUswYWRaczYyRHVRTXBpVjYvSE1hWkNnYmhB?= =?utf-8?B?amk1OU01VEVkeU1PMmMrS0lMT25Zek9lT2Vpd2tMaDQ4TW42M3k2b2NUVnEv?= =?utf-8?B?dGhLYWR5TmpPRmRRYk5mT2IyYTRIQWRCMEpDc2Y4S3lOM0J6Q3NHWG5ITDF0?= =?utf-8?B?SVNCZ2laa1RpWm53VlZqbXBVZ1ZWR3Vya3YvR0ZoSDBSZDQ5L2RDVDgzVnho?= =?utf-8?B?TW9vSzFIWDF5VnE4Sy9pUldyY2szbHNZWU4rWitSSzQwSXVRMDFoTmRvV2ZF?= =?utf-8?B?aVgzZXlhZXFhSUNodCsyNGdGb1Z4bHlDa0FDUFkvVUJMalMvdjRRTW14Wlg0?= =?utf-8?B?QVIva2xSSE82N1FYTEU0OWZwbmwwbWxqMFNyaHZTTFhyMGY5bzZkUkxNMldO?= =?utf-8?B?RTFDM0xpR0RWbWxNcGw1ZDljVURyaFNlUW40cnU5OGQwUGR3dWUzYUc0cEt4?= =?utf-8?B?aXFVZCsyWUhjcGk5cjhGZjRwMmx4NTk0bUc3OTFuTUR6bHhwL1IwZ0UvUkw0?= =?utf-8?B?ek81N1gzUGk0MnhKRTFsK29VejFkWXpsNGNvUlRnTUVBSVJkekhPeU91eHJV?= =?utf-8?B?bkNNbXM1NWsxK25ZY3ZWS3RUYWp6N2FZTUtYZzJHYnl4QVl6SDJZb3h2Y28r?= =?utf-8?B?T25CUUdlS0FzdGlIRnVXdWVyWC81ZkJxYjZ1eis2UGFIWTdRdmNRdWNmcXUx?= =?utf-8?B?b1lLRlNmSm43ZnQ2ZytFdWVnOE5JelZ6VVF3NWNLMUkrQXlCdWhINGc1SG9y?= =?utf-8?B?VTc3c1VwOTZNQTkxRnBCOXhjWm9LODU4Z09UK0xvWmZFbjE0Nk9sc2lMSVV3?= =?utf-8?B?ck9Edmp1OHBkK1hYRUJpeDFxZ0UyZndid1pySlowcy9tbml1YWxmYUlBVmps?= =?utf-8?B?OEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yEiMrk+hMPjyQnXF7gpalO2OlN7LXwF9oFbWKKxbgalKZY6SU8exXO1PJprArfkHhgwTl0yG9nogrKbrmTx7KQdAzS1cFJqZd9Pvwohro/ybYFjJg3OvAE5FEUvf/3rLhC5tH8KnHW3QLiRgYQ5WRKSDSSX0Vv8FyCxMoyeklGJ/a/Wt5k9XwEDQVjUMED9CnTRjDhQbjbgpGIosYc8U6T5vT2sNOdOiBJj/XwbO2nIHtLeJTe2UMcsU2tteSFFZ0n4H69/c51WvjEIpp+WhlvDOBsSHC2/L++88cFtCsnCTMd7jVnWdr6GL2TuPQRaFxGpcMkdLYE2WyiMMiHnFg2ERNcZ6wu71vir+VtaiwKwQsn/qew2BCux7G5ecytpNFHmek+HdNUxGzhaLSSC8e3+GqRT0qf4hK5Cl3mlu7bGxCVQeCoAsUTfS/PcrixCYj2Q1kZcXK9E0AX6ZorGWhZflhNxOvtVz/u1ujdlV/HeImySrlEu3dal6vr7E7tKjTudGty3pNkPXU1K3xSUpi/+gBxRfOeUFBgpeRAUJABORfTYemIfXN+wjniROiojRkLcRVfoDuHJ840N001eJkxkQsWRahG3purCAJaWwbVOfQdiVR3BYKFzHRRgFvpIHOxi5LNs3qJ6iNYeszn0YIUTV4LJLptxXGTPaLFArl40bolVx9avW1geW2rBL6Xo9rS7O+ZQUBbRT5kQB+s2qB+UdMdZgxjyYISZ78xaxQVUQ0oQ/Q63DsplAoYQSkGmkP9l/pwjNC3zflEd2no6JOuLbbl5TXUWQCmyia8+uf/CjrtOIJoP9zmdLkWbHqmtO X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac1f3ce-f69b-43d7-306f-08db0ac2c8e6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 17:26:31.7268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cz6GXtqgMB2JXxCCbK8B15qDlWQmBdPxR6tXR6Z6z6QdsmKMTuYE/wiwmHjsk+KahY0rVGeuJMLvfEx2JYcVQZ1jopc8uE4SZh6c3Uljgzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5130 On 08/02/2023 2:38 pm, Jan Beulich wrote: > First of all move the almost loop-invariant condition out of the loop; > transform it into an altered loop boundary, noting that the updating of > _gl2p is relevant only at one use site, and then also only inside the > _code blob it provides. Then drop the shadow_mode_external() part of the > condition as being redundant with the is_pv_32bit_domain() check. > Further, since the new local variable wants to be "unsigned int", > convert the loop induction variable accordingly. Finally also adjust > formatting as most code needs touching anyway. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > --- a/xen/arch/x86/mm/shadow/multi.c > +++ b/xen/arch/x86/mm/shadow/multi.c > @@ -861,23 +861,22 @@ do { > /* 64-bit l2: touch all entries except for PAE compat guests. */ > #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code) \ > do { \ > - int _i; \ > - int _xen = !shadow_mode_external(_dom); \ > + unsigned int _i, _end = SHADOW_L2_PAGETABLE_ENTRIES; \ > shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ > ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ > - for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ > + if ( is_pv_32bit_domain(_dom) /* implies !shadow_mode_external(_dom) */ && \ As this is a comment, I think can reasonably be /* implies !shadow_mode_external */ which shortens it enough to maintain the RHS justification. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492821.762572 (Exim 4.92) (envelope-from ) id 1pQAij-00050U-0Z; Thu, 09 Feb 2023 17:28:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492821.762572; Thu, 09 Feb 2023 17:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAii-0004yZ-Qj; Thu, 09 Feb 2023 17:28:28 +0000 Received: by outflank-mailman (input) for mailman id 492821; Thu, 09 Feb 2023 17:28:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAii-0004ud-AU for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAih-0003S4-To; Thu, 09 Feb 2023 17:28:27 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAih-0002Aq-Lt; Thu, 09 Feb 2023 17:28:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=s5BFpJN+RHpTf1V7aOw2lLRr1sJNG3mQ0d/1DqAPibY=; b=6znmKaCsqyOpsSL5zpLyKkXjnz D/YPqiohE+1ZFbTRSAFZxFhSCp9LviR7ej5L895UMC7ER4JU4c1vVR/CgiSoMOjATc80RSnBHhzLf 9R1gGqr4eCgOxGz8L9HJVmNRtEU9vhVjfGEYZ/e6G4Zmuh6+TN6e0dGo/716O3aoyUmo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 3/4] docs/proces: branching-checklist: Update the section "add to patchbot" Date: Thu, 9 Feb 2023 17:28:19 +0000 Message-Id: <20230209172820.56292-4-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209172820.56292-1-julien@xen.org> References: <20230209172820.56292-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Make clear the patchbot is accessible from the user "xen" on xenbits. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang --- Changes in v2: - Add Henry's reviewed-by - Add George's acked-by --- docs/process/branching-checklist.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/process/branching-checklist.txt b/docs/process/branching-checklist.txt index 6fd1ab334185..6710cc234034 100644 --- a/docs/process/branching-checklist.txt +++ b/docs/process/branching-checklist.txt @@ -48,7 +48,7 @@ ov=4.0 git commit -m "cr-for-branches: Add Xen and QEMU $v branch" * add to patchbot - on xenbits + ssh xen@xenbits.xen.org cd ~/HG/patchbot/ cp xen--master.patchbot-reported-heads xen--stable-$v.patchbot-reported-heads -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492818.762544 (Exim 4.92) (envelope-from ) id 1pQAif-0004P3-2q; Thu, 09 Feb 2023 17:28:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492818.762544; Thu, 09 Feb 2023 17:28:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAif-0004Ow-02; Thu, 09 Feb 2023 17:28:25 +0000 Received: by outflank-mailman (input) for mailman id 492818; Thu, 09 Feb 2023 17:28:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAid-0004Oq-VK for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAid-0003RL-MY; Thu, 09 Feb 2023 17:28:23 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAid-0002Aq-Cn; Thu, 09 Feb 2023 17:28:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=7COyLm3qPWYO0z2xdcM7WXIh1QKSdpXXmRgHmbzyNd8=; b=D8bJxf aJqLr9rP2tRjIUK6rhjmtfQS7WCN6f6bzxqHpidJeO3BKan9BWo8xAtbM6tkC2RiJFEyhWhEp2BKw jOHOWQNVtFLCkt3BTqLhCACXChE4FetkMUeFlHFuJTY9TWZ+qPPCWo5gLmCaymVrvIBdfvS6/wTHW bJ7bdLIKkCQ=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 0/4] docs/process: branching-checklist: Update it Date: Thu, 9 Feb 2023 17:28:16 +0000 Message-Id: <20230209172820.56292-1-julien@xen.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, This is a collection of improvement for the branching checklist. Cheers, Julien Grall (4): docs/process: branching-checklist: Reword the section about Config.mk docs/process: branching-checklist: Remove section about the cambridge colo docs/proces: branching-checklist: Update the section "add to patchbot" docs/process: branching-checklist: Add a list of accounts at the beginning docs/process/branching-checklist.txt | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492822.762589 (Exim 4.92) (envelope-from ) id 1pQAil-0005Tl-AF; Thu, 09 Feb 2023 17:28:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492822.762589; Thu, 09 Feb 2023 17:28:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAil-0005TW-5b; Thu, 09 Feb 2023 17:28:31 +0000 Received: by outflank-mailman (input) for mailman id 492822; Thu, 09 Feb 2023 17:28:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAij-0005Dp-FH for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAij-0003SO-9x; Thu, 09 Feb 2023 17:28:29 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAij-0002Aq-1u; Thu, 09 Feb 2023 17:28:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=sCrD4nFlt1u+rYJPMeoIkTrye/Mk1XafmA3Bnu04F/4=; b=roQiV/9gN6CK1Uc2GOGhyIqJpp w6XF2pHIvm98kUyGYFEnXm8Z/5LY+BE4RvgTbdCwSVhzhfLfW29xFtcuRfCEtFmG0arQqYhI8kJ7d G09xg5pJ7e9WOo3F5rZ/GfL93Fh38OspSnSGIH4mcHqeyrIvo51zk/hlUjCGzeluXdWk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 4/4] docs/process: branching-checklist: Add a list of accounts at the beginning Date: Thu, 9 Feb 2023 17:28:20 +0000 Message-Id: <20230209172820.56292-5-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209172820.56292-1-julien@xen.org> References: <20230209172820.56292-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The checklist requires to have access to several accounts on both xenbits and osstest. List those accounts at the beginning of the file so it is easier to check if one has the permissions before starting the branching process. Signed-off-by: Julien Grall Reviewed-by: Henry Wang --- Changes in v2: - Add Henry's reviewed-by --- docs/process/branching-checklist.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/process/branching-checklist.txt b/docs/process/branching-checklist.txt index 6710cc234034..3dfa8ec2570b 100644 --- a/docs/process/branching-checklist.txt +++ b/docs/process/branching-checklist.txt @@ -1,3 +1,11 @@ +=== Before starting === + +Access to the following accounts is necessary: + * xenbits.xen.org: xen, xendocs + * osstest.osstest-test-lab: osstest + +=== Check list === + v=4.1 ov=4.0 -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492820.762567 (Exim 4.92) (envelope-from ) id 1pQAii-0004v3-JO; Thu, 09 Feb 2023 17:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492820.762567; Thu, 09 Feb 2023 17:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAii-0004ut-GU; Thu, 09 Feb 2023 17:28:28 +0000 Received: by outflank-mailman (input) for mailman id 492820; Thu, 09 Feb 2023 17:28:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAig-0004eR-Nd for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAig-0003Ro-Hd; Thu, 09 Feb 2023 17:28:26 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAig-0002Aq-9f; Thu, 09 Feb 2023 17:28:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=w4iF+gTE5wQfDiL31rxrejwQ7YJE6MtJmOBI/C4iJE4=; b=d0yEGQCjQY9XR9bpJlK8u8K1qu CM9SeXL3vZ8lU8QeDb+l5yCRF92kFr4uycD9NMDeAPPPljZ0KMkHfOhJwhRkH3f/ahLlGB597eLNv 9idfH+0QFwZAWyEYSBIY0CuFjckLhHUs91oW1ZmAUlhxeA/C/Ik5nzGV3KQRaTMZbCM4=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , George Dunlap Subject: [PATCH v2 2/4] docs/process: branching-checklist: Remove section about the cambridge colo Date: Thu, 9 Feb 2023 17:28:18 +0000 Message-Id: <20230209172820.56292-3-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209172820.56292-1-julien@xen.org> References: <20230209172820.56292-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The cambridge colo was internal to Citrix (now Cloud) and hasn't been used by the community for a while. So remove the section. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang --- Changes in v2: - Add George's acked-by - Add Henry's reviewed-by --- docs/process/branching-checklist.txt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/process/branching-checklist.txt b/docs/process/branching-checklist.txt index 7c4c107c250c..6fd1ab334185 100644 --- a/docs/process/branching-checklist.txt +++ b/docs/process/branching-checklist.txt @@ -42,12 +42,6 @@ ov=4.0 OSSTEST_CONFIG=production-config ./mg-branch-setup xen-$v-testing bisect OSSTEST_CONFIG=production-config ./mg-branch-setup qemu-upstream-$v-testing bisect -# make branches etc. in Cambridge osstest - ssh osstest@osstest.xs.citrite.net - cd testing.git - OSSTEST_CONFIG=production-config-cambridge ./mg-branch-setup xen-$v-testing bisect - OSSTEST_CONFIG=production-config-cambridge ./mg-branch-setup qemu-upstream-$v-testing bisect - * add branch to osstest Add both qemu-upstream-$v-testing and xen-$v-testing to BRANCHES in cr-for-branches git add -p -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492819.762556 (Exim 4.92) (envelope-from ) id 1pQAih-0004en-BA; Thu, 09 Feb 2023 17:28:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492819.762556; Thu, 09 Feb 2023 17:28:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAih-0004eg-75; Thu, 09 Feb 2023 17:28:27 +0000 Received: by outflank-mailman (input) for mailman id 492819; Thu, 09 Feb 2023 17:28:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAif-0004YW-Gz for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAif-0003RV-2l; Thu, 09 Feb 2023 17:28:25 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQAie-0002Aq-QI; Thu, 09 Feb 2023 17:28:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=mAbwzoszS/MgYnUjT1K/UPIKO2jAFGSyw2bBiFLt0Ao=; b=k5CGVjwmjsftboZcTKxfJETw4n 6AJW2Mzxpfg6Jk9Qa8TKFJ3t5CANWhkI4XQ2jFbiKpHcLDrRSiBXJnhVU748kO7uWea4q9E+t4Q2q biGrnDhL2oDTOhZkpBZI/vgCduwpYiotQHDXoZl/5aFbS50UILoYrJVtZKd5skxNg4UI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/4] docs/process: branching-checklist: Reword the section about Config.mk Date: Thu, 9 Feb 2023 17:28:17 +0000 Message-Id: <20230209172820.56292-2-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209172820.56292-1-julien@xen.org> References: <20230209172820.56292-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Since at least Xen 4.12, the revision for external trees don't contain the word "unstable". So explicitely list the *_REVISION variables that need to be updated as part of the branching process. Signed-off-by: Julien Grall --- Changes in v2: * Explain what should be the tag format for each variables --- docs/process/branching-checklist.txt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/process/branching-checklist.txt b/docs/process/branching-checklist.txt index d1550385c96e..7c4c107c250c 100644 --- a/docs/process/branching-checklist.txt +++ b/docs/process/branching-checklist.txt @@ -69,11 +69,12 @@ ov=4.0 git add versions git commit -m "Branch for $v" -Ensure references to qemu trees in xen.git's Config.mk are updated. -Check this with - grep unstable Config.mk -which should produce no output. Replace as necessary. -(There may well be none.) +Ensure references to qemu trees and Mini-OS in xen.git's Config.mk are updated. +The variables and there content should be: + * QEMU_UPSTREAM_REVISION: qemu-xen-X.Y.0 + * QEMU_TRADITIONAL_REVISION: xen-X.Y.0 + * MINIOS_UPSTREAM_REVISION: xen-RELEASE-X.Y.0 +Where X.Y is the release version (e.g. 4.17). Update newly diverging staging (unstable) according to release-technician-checklist.txt section re README etc. -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:28:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492834.762600 (Exim 4.92) (envelope-from ) id 1pQAj3-0006fu-PD; Thu, 09 Feb 2023 17:28:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492834.762600; Thu, 09 Feb 2023 17:28:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAj3-0006fn-Lu; Thu, 09 Feb 2023 17:28:49 +0000 Received: by outflank-mailman (input) for mailman id 492834; Thu, 09 Feb 2023 17:28:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAj1-00060C-GR for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:28:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33c2069e-a89f-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 18:28:45 +0100 (CET) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Feb 2023 12:28:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 17:28:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 17:28:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c2069e-a89f-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675963725; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=sXD9az4p+c3IoeHYNHwgBsFRy4V8+JXh4R/P6E1A7SQ=; b=N/U042Elv72CLxHqpshJOpyraoqLgPWHezICcF+mIaI24xZsL2uRXOIc Aq0YEhfrC43WApavrfQOLealksnki4N2C9c2WXMlgFmJwYi2EbWY00MoK AT5CSMza2/8xy8WWfwNmRPlz70loQOcZjarHn2Mvw7jfAzV3KNhg4JmAI U=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 96402252 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:cKJxQ6n0FOfOPE24KQgTb9To5gywJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZDGvSMvuLMGTzeo9/Otiy8k8GsZaGzddmSAs9/3gwEiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5A6GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 a05IgsKRDzcvtrs4qOyEco2ne16dPC+aevzulk4pd3YJdAPZMmZBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkV03iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDSuHgrKQ32jV/wEQZJEVLFmmJvMO/k2PkZN5da EMF/xsX+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqTTMFSCMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mnQqDBk3utCy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:ZtLFdaMCMSAXLsBcTh2jsMiBIKoaSvp037By7TEJdfU0SKalf8 DHpoV56faGskdoZJhAo6H9BEDkexjhHPFOkO4s1NuZPTUO21HYU72Kj7GSpQEIcheWnoIzu5 uMa5ISNDSZNykFsS+Q2njbLz9U+qjizEnev5a6854Cd2FXgupbnnxE406gYzdLrSd9dOcEKK Y= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="96402252" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iqjoqmv8rXVgaGnjBGjR+Ed9tsMlK1hS1uN7FK8w6sp0Q5eWKcZrKV6z8mEEJMj/jr9nYJ/+Fqa8broGWU6rlGAaJ3IqcJLxmMnK2umYmtaSCy9TtUl+OuLlAoyKHwfvas0DuPFGHTULMm1cj9sKjN+0ze23b6dZh1yw6Ib8ppYnWVYlCv5Wf8EEugVyIXVne40TY7RrsIKXCV8fuJ49+3L7gkEP2HuTkYtKgT414EsAGFcOKTPar0JLvzU06mW4PF8T5BZpZKUc7e4RSPfJrV31WrF74MxPFUMI/1ytB5mo1/tqoxkI+GEHZZ03KI5wXQgYrfNCnxOL5N4UXtBXgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sXD9az4p+c3IoeHYNHwgBsFRy4V8+JXh4R/P6E1A7SQ=; b=oWruzryN7mCTCNg+yCPt0zS0B35G2fZtgceD3Jzr6g1QBCDjtOEtKpjCfIhYg9KZptreCwqD6CDkzZEK0aM7cujoHuaqhU8mMdtMXIHzp78IexOVbxSZUrZo/stjLJb5BU0ja9Ym3G3RZI7iBzsTRMqd2WBwkFt7O3G1h5NMZM34pf4GRCSFNSqEMVOfFukOakigRvNOZpHrXuEkhEFkmxzlqDY278ALk2bQBEzQ/rmCuW131cZM2o2oE5eNxmgklTPVLpw4FmkaeViZpSlWjVhWg/SqlKRReNOWOKPyQ+MY706GPUg595U2rpMX5NermZWfLzz2+DNfngmyQ0XjKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sXD9az4p+c3IoeHYNHwgBsFRy4V8+JXh4R/P6E1A7SQ=; b=YxWg0VWwmfmntprXchEV9cwoshUjyoVtlqE1VhYnJ5OyA2naEgfgctHiayKtbAmJp/9Esa/EMQDe0YNKLnb9kZNoHuxwTkp5bX06VvP12zv3BG4vyb2EFlv3ofDerDYsfG83qiK7ICOZbGowM/my3P026BBOIXqdmuBr221pa7I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <45ff484e-0b1f-7fb2-6e61-0dce4306e1a5@citrix.com> Date: Thu, 9 Feb 2023 17:28:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 1/4] x86/shadow: replace sh_reset_l3_up_pointers() Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <55114c08-6407-db9c-a25c-06fa7bbfd4e8@suse.com> In-Reply-To: <55114c08-6407-db9c-a25c-06fa7bbfd4e8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0108.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5888:EE_ X-MS-Office365-Filtering-Correlation-Id: 90bb23f8-8c3c-4363-74d7-08db0ac315c1 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oXQUE9Bc5P71bgn4aNmu0AELBf/12KohLcaPySsWaI5h0Ublm5S1lUsS0rmKkbt8x5942BY7LeTyMDjyGV8YdREl/krspNyxbXQSszYT5xVlRnC/UXD+saBN3H3o+vPHImykgIDSedqanzUYkZxHIpQv5C31BDHKMa8xHmdqiubB/l0xF0QwiaiM06WBj/5IpGhtOUykpTzw2KaADMGNjg1plk6d9YqFitAmQKXGt/qOfWso4TbsQiMBVZql6TiTx/1gQZ2IPPUHx+sJuUr0ktLVDt0JbhI/fQ79aH7ijhG3XzqkpN7VGAjUI0SkZhEz1MK5/RBDJUUhP1J4vMzJzmdjR+/lv6CwLnwqd066xmtq7RxE517kV0fEQk/0IHovQ/0wEepDQ9rKOojfGwFNK8D8I60sLlui3woZaNcyIC0Si3ek1A4svOlJMYyIeksWjtM6JFezUvMQR6pezaTTQDzUe/xromnE7F20KXr+HmDrkW5Eh3mdSFuX43lgLncvNmMUR3EuAThm3g/izN1YKCg9hIi4zoUBMqvvnQV6W8QnAal6HmHOGONOiNs25Ky3GdsnIhDp0lvwv8+HLtlZA4b+2A5T7v4HYhHvDmmImlHCQXolAILCcTEl/01JaUR9EcasuqvdS7kFTLA5UMxWz8KXUQOjgHHnhk/dZdGPtC/xIXFCzNNzgF8PaCXZoH240t8UqlferN+8Z3THkTYnjmxu+EHYlC1gwMqXtNxnCjE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(451199018)(31686004)(2906002)(4744005)(36756003)(8936002)(5660300002)(41300700001)(83380400001)(2616005)(66946007)(66556008)(66476007)(4326008)(38100700002)(110136005)(6512007)(86362001)(186003)(54906003)(31696002)(6506007)(53546011)(26005)(6486002)(478600001)(8676002)(316002)(82960400001)(107886003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFBGbHIyVGNKYXMyTzI2M092c0wvWnR6ajJITlhyQVNhNEs3cVVONjVQRTR4?= =?utf-8?B?VElsRzA1ejZMRXdyckpjQ2NFZ285Yjdhby9ScWNtakE0TkRFam04cjhpWDU4?= =?utf-8?B?b0ZScGtMVTZveVl4UjdrTzZ3dUFBZWV5ZDlTcTVXUkpycGpFYTZPbG8xaGJq?= =?utf-8?B?UjBub0Yxb3c1TEhzZk5BQm1ZYVovNVQzVlEyMFZ0Ylg3UUQ5Wlo0TXNyWGxo?= =?utf-8?B?bVhqOHVOYkp2K1NGUkpocUhUZmZ6QXFmSHNWRmpOcDRPZ0hma0ZMUFo5SHNM?= =?utf-8?B?ZDhRakJWTzArQnJFV1loNm81b3pvTUxoV3hEWDh4b0t4dXRsT25KY1BnemxU?= =?utf-8?B?NEd5cXVka0N2amV6eWZ1OFQvZmNWVHlabm5ZU1MyM1VnMXk2T05ZZkI2SzVh?= =?utf-8?B?eEQ3MGczQkp6d1RrRHR2WjFkUjhUODVEby9peXdzajFCY2F5R0pFNGcvQVha?= =?utf-8?B?aW1PZEZac3kyWVM4ZXVDdW5SVHp5alV6QVNLWkw3YTc0THZiUEkzVTEwQU1Q?= =?utf-8?B?dTJ5UC9kUXpBWnYyY2pTcFBsQ2toRkpqN3VUNXcvUEhvemhNa0QzdU41Zm1V?= =?utf-8?B?TzJDclI1bEZIem51U3orcWNIRUVqamczZXRXWFVRT0J2QjJFN0daSG0rSUxk?= =?utf-8?B?SFJrcndMV09PNk5MSXJPazcvV1kwLzJvQnpwWWZqMTVzOFRWeXhhRXRiRnpY?= =?utf-8?B?QUdVc0t3K2N6dVhXZkJaOSt0OU5FaVU4a0lDYVBzQUhPT2ttdlJ4MVBvWEE1?= =?utf-8?B?a2RSLzVoVCthcS9OSXNyUVdFMDRqYWt5S21nM3dtU0NxL1l5UFpCdjVKMTU2?= =?utf-8?B?aExnb1dqcVo0dHk5K0FKNnJ5azd6aXEwY3ZhVEg2RElSN0IzY2IwcDFYd0tC?= =?utf-8?B?ZkorSWU4N0lTbDRMK0RmNGd2QWZ6MzhaSzkyN056R0ZMUmg1YWk3Z2VmTkF4?= =?utf-8?B?QTA3RUFDeGFXVXp4bmxudG1jWEltbkE4alZnZzVJWHJtRXh1UDQ0VnBubmEx?= =?utf-8?B?Q2N0b3hEZVBNVjJnMno0WHFWZTFrT3c5RjM4YklyOFNzYTVvOFErTE9NeW15?= =?utf-8?B?QUxRanZML2F4dzRYYXEySGRHTWNkRmtuRWEzSzFrWnNCNTFYS2Z5TmNKS0FR?= =?utf-8?B?Q1hpUDBVY21UYk8wWTBRUFk1Q2FWOTRhN29uT2VzQW5STUxaZDY2QUdlQ1RE?= =?utf-8?B?UURVM2UxWWFXTU51bDBTZlA2TUNnaisvNnlvakprMzNRSi9scFZjem51NmZL?= =?utf-8?B?N0d2QklsUEx2SmFPazlaTDJnKy9yelJ6TmdXYVZDdENETlJ0U1pUUUsyYTRk?= =?utf-8?B?YXd0ZnF6Wk5GaFB4dkEzSkVsUGsxYjJPd1RMdmNUbWdISW5EejVEOGdTdDN4?= =?utf-8?B?WVFIZnhJYlNCZnNZVFp3aGIzQnJmQXBqa1hDOEVsT2dEVDZIV2RpbnRvUlZX?= =?utf-8?B?RGVrdDN2WUtneG13elNTeTZ1ZjRPUGZSNXNTcUNXMG9zdGhFNG41SjlRbGpw?= =?utf-8?B?Y1FrbWcyQndKT2s0enN2alQxalRuZzFhMHNVZktXeVRYamRiTnJla3oycHBI?= =?utf-8?B?TWcvOTVLZzA0OTJ3UEg1QURldVNsbnZkVzRrYm4vUmovWllseWYwSEdpSFRK?= =?utf-8?B?TW9hMllYNzBCQ2E3OFhNdDg4a1d4VXhYZHV0R1l3bG5JVlgvOWdwRVJuN2pV?= =?utf-8?B?UE5yL2s0K2N3UWJTZHFmeXJDQUwwaC9zcDJSVHA0LythTVRHclA4REpVQ1Fl?= =?utf-8?B?bGFTZnFOYTZPaklJQndaR1U4bVJsdktVUk04RTBEUExNTmR5eTRHY3pKNm5N?= =?utf-8?B?TnJBSVBmd3lndlllMEkrNkRTdVJCQ2pscDNPQ2w3Q2s3Q2lYcnhHQ3FFcVNZ?= =?utf-8?B?bndrV0dHM1BKdmFhcldCWUNGM1JJMjlITENscDFtcU1uclV2TSttbTdPdlo0?= =?utf-8?B?QlAvcWNNUXF0YWdtWWRkMWlwUlJDMHNtcnF4RHU0YXM3eWVNZ3p2L0QrYS9n?= =?utf-8?B?WVJmeCtvL2NqWXFVS1k5ZGovcTVXY2JycUp2UnNYdnN0bTFpS1oyZ0RCUE9F?= =?utf-8?B?bElqckc2cjh4TTJGMnlnSStTOWw1dzUyOWVOblNmaHArTmxxc0FMTjBqSVh2?= =?utf-8?B?eU9aSWd0K2RHMXVqU0NJTnUxNHdRM2NQZVFyM3BLOWVJeTcySVRBUlVNb1hy?= =?utf-8?B?REE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4btKyq04PPJu1SPG0vOt7uU0wsVGXyjNOnvuKXmlt6zLILodyh1F28P+//5/CF96XEDz5x0c1ZvQjcsUX+d7eanVtDs4j/NoUaYAWy8Khk4ChG0MlcE4FIC/o84lpz1L/sTy4NK1MCBFw2A0CmKrh22UTSw9RM/ZnC5zTti/x0RqoEqHwX1Z6sZII+qFYT0+1PkTiK0A/safXN4vPEUcZDnNKDYeZnEIWl1BD4nPiLKx4YqoQbLYEs5Lwzqw5Nxc73jqYJGUOI6IrrjLKXKDUb5czjYY1NmrbIffVC6d7ZzV+AX7OXoERe8fEGW7Z7pHFNuCXpf6fBz2/h7VNsnhuFojPdX/RdN7szJt15G7cglpHCcF53ubPP4XelLq7n+WzEwTfrmDRNCY4Knu9h8ZwT370tLA6EIdKGgOMrHlk7WDbwK23xLARhQlEhhdTokvSA9EgYppPO7JMhLtOIJLji3HfvB5SpulB7ZxXpAi2shoDfvCjUB9UeCu8AU42I5XYn2TsNzXMn0Q0LtePq8Lz34WockDE1kbq7Z6G4+/eDq/cFsW3+uLw7Zlt47IjigK3wtFkGC+zHM2joIZBJiESqbFPQlgryPXNgnATn3+aPq1k8LaclbneKM4BIuHuNS0HqJMSx3ex3+mFE3heEq2ygyBlklE6RVlBhVLaaHE0QGldxvNIWYYkdkSJojMs/oicxlo3tT1+t0D9YSeDOJPCzzcRtZ/DIZtFTj0bh+CVZ5OEnG7YDulGqQPSE8yAWheT+ULolDJqtEpxuUump7mFUAqMEp4cYqpHWmDMm+6bef34zf9pKuaFz2y8bk9raby X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90bb23f8-8c3c-4363-74d7-08db0ac315c1 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 17:28:40.5457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W+fP2lS+QW4LC7y/gNaTYkI38TeDjkfilFBv9bNqBuQtcUw8+5k9wmmFvDt8LiI+XbJ/3R8PuC8XhBWjNMt1hatbbT1jzFuycnyJDWPIRms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5888 On 08/02/2023 2:37 pm, Jan Beulich wrote: > Rather than doing a separate hash walk (and then even using the vCPU > variant, which is to go away), do the up-pointer-clearing right in > sh_unpin(), as an alternative to the (now further limited) enlisting on > a "free floating" list fragment. This utilizes the fact that such list > fragments are traversed only for multi-page shadows (in shadow_free() > and sh_next_page()). Furthermore sh_terminate_list() is a safe guard > only anyway, which isn't in use in the common case (it actually does > something only for BIGMEM configurations). > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492850.762610 (Exim 4.92) (envelope-from ) id 1pQAnq-0000F6-BZ; Thu, 09 Feb 2023 17:33:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492850.762610; Thu, 09 Feb 2023 17:33:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAnq-0000Ez-8U; Thu, 09 Feb 2023 17:33:46 +0000 Received: by outflank-mailman (input) for mailman id 492850; Thu, 09 Feb 2023 17:33:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAnp-0000Et-Pd for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:33:45 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e675a4c4-a89f-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 18:33:44 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id BC89D320090D; Thu, 9 Feb 2023 12:33:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 09 Feb 2023 12:33:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Feb 2023 12:33:41 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e675a4c4-a89f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675964022; x= 1676050422; bh=+gWL5kImMUsYHMpsPGwx6t2ZADiSvIHJdC0B/YhuKUM=; b=W e/K0JpTmtOQFrvGXnavJ/sCK3UKgvG3CbJe1ZuEjFCiH93CfHKZkOavBQPxMClSc myPVAzkF0Od9oi+nVinEAnzIa1fRadjAF5EyQ6Nohqhih875SAQtZ71+XmPeXPc2 Sp+SRNZbbUzeAEVa2pYpXVIA3jQmBFyuFftcdoeZPpwzr5io4613oTn1KOqcUuZH 7EyFqbGB62+RwQFyPCuhs8sD7rnm5qKgybx/wJ3qnlZsvk/jjVIjbhnySKByp5tV UznQUf7ICEQY3gwt6s4purNFDTWP10pCJ03W0j/gIT7Y3BWfQ+vVQVwHHXayJ/Zn l03evkkqwBKV2x7zVvd3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675964022; x=1676050422; bh=+gWL5kImMUsYHMpsPGwx6t2ZADiS vIHJdC0B/YhuKUM=; b=t4pqXj9O06j9KbydeWNqJP7dST2DBMcTUPyITLwDY4mL M4DbFOFRVsAtqKaamDpAJ+0kQecI9ycyVvXWmYDl1PQlmtn0Oon1Dk93ax/QEJF/ TgltlFGbUAW0sl/TKgAza8wT3AA3WQl1iHtUz1Fsz1gPpRgcESq92zABNn0I0MG0 24UJTog5z9+SA4vlsFKyMKDBb4AZ4GFqRxvIv3aA5YWDtvEKcy0Q/piMIK9RZ39C zyF4dDvaKUhgXn8nQ0XAmHvkWhgcgMc4Uvq2bp5X5uZXkLr7RZriDIY8hkc5RC2E LRrGqW36oWx1xqNTs6ElXU6l5HLYXHjSiZuG1B84lg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehfedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduieelfeeutedvleehueetffej geejgeffkeelveeuleeukeejjeduffetjeekteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 9 Feb 2023 12:33:37 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: Re: [PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https:// Message-ID: References: <8a3d0ce9747e486e91ad5b47777c80293e0fd168.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ZxjEK4Mi/gAGzVS" Content-Disposition: inline In-Reply-To: --5ZxjEK4Mi/gAGzVS Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 9 Feb 2023 12:33:37 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: Re: [PATCH v2 2/4] Automation and CI: Replace git:// and http:// with https:// On Thu, Feb 09, 2023 at 02:03:34PM +0000, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < > demi@invisiblethingslab.com> wrote: >=20 > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > > > > This patch enforces the use of secure transports in automation and CI. > > > > Signed-off-by: Demi Marie Obenour > > >=20 > Same question here -- have you verified somehow that the new URLs work? I had not, but I just checked and they all do.=20 --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --5ZxjEK4Mi/gAGzVS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPlLnMACgkQsoi1X/+c IsG6/g/+P102TDvpkUA6eFt5f1mkhy7m2uF77jRmcAVsG7nUuvpQ4O0wf/51H7re ZwCPeM6A7I6lH6TZgfSItgYHEKwjig/IoDzlCi4w/PIJuvSi5y7fxiWNDtTy2k65 yjDP67BraZ/f5p429Ulkqoh7NBytU3Pbdzikgrdm/UhXBJalhuenu7uTLK4r/NZ4 DuxngFXxAG/JDf3mqfLv1La8iUeRK2YmcqI2dU0j0COSMVwr1VQ2YAnwykcAgQ8A baLegM0btKNftgwYDdHPiY30clOpGbogbDXyq764LNpRCWgpH8YrJrvdgz0FvrQn taOXbwjbErVU4tm12ObC6q/kxMaEpeBb18hWieU3uEpELtPxZ4p8UatYD9Yhj8/1 WxlDcmZmTfX6+jDrt+CSWRRqP7F/q7I4D5wKzdWW5Yr9jqU5dkNygaqG+0tuwrhx YrZQ5xL0W02pK/dAikWhy7eIgENxoA5ou7ZukUaGWGvbXc6tI1Ij+UxNHt2AQn2B khGB1FO0uReHDkcPuqrsxqSZFenoSDOlZcXtlJsWz89IiqOvqTLjBlUGqkHvk1fg kR6kgFSRw+WclA4beoV0OWfSZ3t4/oR4d4WqY+s8n5sq+b820IFA5+iXZlZr5YyF AOZOnPdQBoG4Satao3pnLhiSbHVMXffGmeOCorpXMzMNKWrFQ+M= =kpc1 -----END PGP SIGNATURE----- --5ZxjEK4Mi/gAGzVS-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:35:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:35:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492860.762621 (Exim 4.92) (envelope-from ) id 1pQApG-0000ri-MR; Thu, 09 Feb 2023 17:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492860.762621; Thu, 09 Feb 2023 17:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQApG-0000rb-Jb; Thu, 09 Feb 2023 17:35:14 +0000 Received: by outflank-mailman (input) for mailman id 492860; Thu, 09 Feb 2023 17:35:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQAkS-0005qC-B1 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:30:16 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68a5b7a5-a89f-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 18:30:14 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id BDF27320095C; Thu, 9 Feb 2023 12:30:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 09 Feb 2023 12:30:11 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Feb 2023 12:30:08 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68a5b7a5-a89f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675963810; x= 1676050210; bh=9ONn4jeJnzY4RbURezybz2EzV94m+2kzfhLz2FCfSBY=; b=g WL3QGUa6EwSfV+nxEOefuDMWruOCV9Vil+RQew9uWZm+SChcvcDNqia+f3eZLNYG aaAuqGzILm7l/YJhpvyNsmIevy5bBIbvvHK1DydQ2lJHRengMCqgDPh/I9wa7xVz BbKaxmtk7YBiv8KHjMM+09JmBo5QtiWv9AjljqULDJToS2y2GPBmD97psgJBznKj JTiTISBjh9N+zhk4tKasppinJb9TgosglzWZwF46cXuIBLWfypmrcRIxvie5NG1O Mr+Iu/uT9e1ZGRf4G41b55wMxrF9BfuNqN6jHEsGCvpuWDa1+C+OjJXv57qDixiH YdD6AHtuxSAztqCTDobvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675963810; x=1676050210; bh=9ONn4jeJnzY4RbURezybz2EzV94m +2kzfhLz2FCfSBY=; b=Y7z7THhBNglzTPpV0DN6kPMP2NO1hhBJXjht21BOWSbP UnxI1cyejB9wEX2KpQoFhAGh/MuALicDF7oUyx3mfeGbFMKmfvSJ8xSMJ7B2ipDY XmdOAC5+2ecGNqIPx6Dwad+oLJtgKEI7HyIFGiagIB7pesVgsdeEbzg1NNoVF+vi l2FyV401otsdkvyfhYX8xbIt6VptmQSVK6HBGFoyCMcFpmC/Z7bCTr9gNMrD/Bnd vi9AFSiPwYwr5k7+sY3VfR/vW4CRwXbMV8JM1FDD5l3o5c+mHSpuPr/J/mvKY0ZZ px+wdIXXUQv154XFcsM9DrbWGvlIx+ZXGsiIuUnkbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehfedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehkefhiefgffeileffieekkedv kedufeeuteekiefgiedufeehfeeifefhvdekleenucffohhmrghinhepshhouhhrtggvfi grrhgvrdhorhhgpdhrvgguhhgrthdrtghomhenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 9 Feb 2023 12:30:03 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// Message-ID: References: <75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HYepDk4+IANRBz0A" Content-Disposition: inline In-Reply-To: --HYepDk4+IANRBz0A Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 9 Feb 2023 12:30:03 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v2 1/4] Build system: Replace git:// and http:// with https:// On Thu, Feb 09, 2023 at 02:01:52PM +0000, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:58 PM Demi Marie Obenour < > demi@invisiblethingslab.com> wrote: >=20 > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > > > > This patch enforces the use of secure transports in the build system. > > > > Signed-off-by: Demi Marie Obenour > > >=20 > Hey Demi, >=20 > Thanks for this series -- we definitely want the build system to use secu= re > transports when available. Can you confirm that you've tested the "+s" > versions of all the URLs in this patch, and verified that they actually > work? I had not, but a subsequent review indicated that most do work. The exceptions are: - Neither the PolarSSL nor TPM emulator links work, but the http:// verison of these links is also broken. I added an AC_MSG_ERROR to fail the TPM emulator build if they would be used, but a Xen committer will need to regenerate configure. - the newlib url should be https://sourceware.org/ftp/newlib, not https://source.redhat.com/ftp/newlib. This was changed in configure.ac but not in configure. > If you haven't, I realize that may be somewhat tedious, but I think it's > pretty important. You should be able to automate a lot of it using `curl > --head --fail`. [1] That does not work for the Xen git repositories, but those all do work. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --HYepDk4+IANRBz0A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPlLZ8ACgkQsoi1X/+c IsHTTQ/+PQkqXyTptUZxmAn9zU/a2jLEJSR7vRpHN4M9qmezFoal36y35Phk2XRN 7OrdkHqhYEnkOX8PrPW8tY0wULH8aZsveve+RQRrq6R9Fkiw/ALwaPs+0WkRqCbd qPhOmS5fqi+9xoS9gOsv9RGpdlGJdBGur0+Erd2MTUdmLlm416DeVCCtWLh7rulN z2ruBGMmBkTZHRDj7J5w81RaJOzx5Pgez9jXKiuC6CI6zWNK2EQtOkUqglWG9oVy nssRervVahjofqg9crDrSS+ao7JRzqjEFEl9PlE1u+ivS2mTAkgv6IOuonmDm/ry Vb2oMA6vHYSgW36pDVLe2Z8W+hAuC6z3OyvvNOKBEX7TllErApGpVOAbC1+5+h+O BrePYk2WjOj90ZFccISakxU4BW4nfObf77i76fsm3I7UFeXoI+QJOXet+f7XSxwd 8CFHZDwLuQjdUyOTaGwhi3q7LRf9FA63Sb9BBGsJ8/Uuahh790ad2Sqd3/Czt0u4 3LKUHQnAR4dqbvyrGcCWpFzVvwMlPAJKs2kgUKJi1Rdpvqs1q7A0+Us5yCOcqAgo czCe1IlCBNjyT5yHUleXMFSLey947uI/LtMDF/pCpo5Nb2Lrf0BeeMWvr3DznqAU bcCy0KhqfIcZDOnXhpiBNro3Tb19xvSJo1MI3xlGGhPrVze2tss= =iPFj -----END PGP SIGNATURE----- --HYepDk4+IANRBz0A-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 17:52:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 17:52:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492875.762633 (Exim 4.92) (envelope-from ) id 1pQB5K-0003cY-43; Thu, 09 Feb 2023 17:51:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492875.762633; Thu, 09 Feb 2023 17:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQB5K-0003cR-0Q; Thu, 09 Feb 2023 17:51:50 +0000 Received: by outflank-mailman (input) for mailman id 492875; Thu, 09 Feb 2023 17:51:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQB5I-0003cL-AH for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 17:51:48 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6aec5190-a8a2-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 18:51:46 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0C6723200952; Thu, 9 Feb 2023 12:51:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 09 Feb 2023 12:51:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Feb 2023 12:51:38 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aec5190-a8a2-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675965101; x= 1676051501; bh=diSmzBlF2MmmtyrCfWIQfmZm5ZWHPl8mbWdnYSJQ94g=; b=F SGsov8/Se26hQx6HOVKDHV4eOHChCyg24KLpSrZyoz062+AvpnuvYtf7LCgM2arL fBj0C0yPpYL8ZelQK8wEvwTCbjw96/neRs1TQ4nGcKqnDH6TM0e9/G3sg6Up9Nbj diL78dv3ldk5zoz8iV1AYtjwkhc2wNysoT6+51uR60cWF6l2Ebo5HtiZqCJbcC0i TM0JsRAxOdkr/EBHUrMbhx/ZvDrjD4mFFNdvyPQGU/V7OdHuej//wnW+wPwQwMq1 vW22GmD9dgOqRj9Cl62CWd/4154uW5QzUejKu8+e3Nby9+gagrEIX6ilECRVI6Z4 6e8H5KB1qmXc/VnFQEkYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675965101; x=1676051501; bh=diSmzBlF2MmmtyrCfWIQfmZm5ZWH Pl8mbWdnYSJQ94g=; b=pJrkdrQpVkjxT90+gF/1bhkEMz2risLYS9HU8bfvOJrS xi3GKnXAYxQFRCTLMl5bnjJx0WENpAAvEzM25VwcY2X396iLwnAP3NX+7EIIZ2mb uY8t89hKC4jykhFMukgt8DORYeH1R7f0FtydZad4g3EIPEBjDl9S+bZBjnt0DgYM /TnXROpLbdE9wxrBntSStHNFgHYMkTBoq56iUi65tcJv5NjSZL/qabjN37KmO9Jc pKRvFwMs6LM6TrSnk+nxVLJU/XVjefTYL1nkzOqo8o5+QHgfgl7iJICpUriqSGK/ M1mEUOqoBnkQbg9DrE8BENdUiWiMCRbKeJaYsnai4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehfedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetieelleffffdtudffvddugfel feejtdektdfghfefgfejteeutddvfffgieegjeenucffohhmrghinhepgigvnhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Thu, 9 Feb 2023 12:51:16 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , Roger Pau =?utf-8?B?TW9ubsOp?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant Subject: Re: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports Message-ID: References: <8c476ad1d36919f31c3d37edc813182e8f1489e8.1675889602.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3twc6P7aNkhOC967" Content-Disposition: inline In-Reply-To: --3twc6P7aNkhOC967 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 9 Feb 2023 12:51:16 -0500 From: Demi Marie Obenour To: George Dunlap Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , Roger Pau =?utf-8?B?TW9ubsOp?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant Subject: Re: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports On Thu, Feb 09, 2023 at 02:25:07PM +0000, George Dunlap wrote: > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < > demi@invisiblethingslab.com> wrote: >=20 > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > > > > This patch changes miscellaneous links that are not used by any > > automated tool. Some of these links are dead anyway. > > >=20 > As I said in response to patch 4, I appreciate the goal and the effort > here. But I'd rather not replace a working link with a broken link, or a > broken link with another broken link. >=20 > If we want to make this change, I think we're going to have to be creative > with how the link replacement is done, as well as in how it's demonstrated > to reviewers that the new URLs are valid. >=20 > One option, for instance, could be writing a small script that would check > the link validity first and only make the change if the link was valid; a= nd > then including that script in the commit message. The reviewer could then > convince themselves that the script was correct, and give an Ack or R-b on > that basis. There are probably other ideas as well. >=20 > Any thoughts? >=20 > -George What about breaking the patch up into smaller ones? One could change all of the xenbits.xen.org links in one patch, since those are known to support HTTPS. Then keep going for other domains. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --3twc6P7aNkhOC967 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPlMqkACgkQsoi1X/+c IsFAyw/+Izax+D9FitbxfFeROnthD+Z5oe7M22tfYjEI/Ks6aZ6cyM+ocBmxvFAA sikXezwoElWO2HmNpVmECyvBBQ1NwrmptQJg975l+zSSkoHYmRT0DBc+4AIDx8Ye OQXRz72byi5V8GbWjkH1w7BrSw+BzdvXzoZuw+gv/OllhV0STr1YADvLSOtjG0cV PTY+DM77lpR4PNhPVh8HYgb9wM33/yx3CoR3pyrsKCkqay7OOw1rL3oiapPIQQbc pJ+iTJzNOF2Dr+Iw4ClpM5y3OUEFZQfoGhursHFoXpRUWXv2EyVTPBUOOX5AmbQQ 1hFQ35nYT5PpHhQWVsW4zdFZK2VFHrlsg7RG4/P58nH3C1zcDxDE6X2FHSnOKR+K NYhD4GxAi02yRQfuEQYHmAVGPySjpnjuCPG+OOam/z65FmphXGEsxiMBwf/EGXO3 RhSZwFzkolx/qmP832De7lgI4/VimCeQbSvb72UXqGX+UcMPNN/GdD3jhxZ6yGA8 Y1gDpMXkFsUDKR09BoVS8fnuVlSuHe4n+dw6ydz2JFq5loDG2TRd8L2EOzXgT2to 6lAqTKsFKsXu8/cX1jkEPgYLWBOY9wQg7OFwLESixvILYtGXyNX9C0e7Gk68pJ7p 9pn7dJVRBHxBmAOKnMNcHOxbMpzne1ye2znmQUQfC45TdDUFQjU= =lVv4 -----END PGP SIGNATURE----- --3twc6P7aNkhOC967-- From xen-devel-bounces@lists.xenproject.org Thu Feb 09 18:00:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 18:00:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492885.762644 (Exim 4.92) (envelope-from ) id 1pQBDR-0005RM-1A; Thu, 09 Feb 2023 18:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492885.762644; Thu, 09 Feb 2023 18:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBDQ-0005RF-Ua; Thu, 09 Feb 2023 18:00:12 +0000 Received: by outflank-mailman (input) for mailman id 492885; Thu, 09 Feb 2023 18:00:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBDP-0005R9-At for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 18:00:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96f87304-a8a3-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 19:00:09 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96f87304-a8a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1675965609; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wl3c0Qfxyvotoj1ZLLkshjDTcebAgiJ+acqaZNuN4gI=; b=UiSk2rersj97rcepSimBLx4n6+ROXRuicRmhHZrVXXpLE8gD80akZmWi Bh70t4+GF1OgJk8JA8JRj9WhvdcCZ5C0LN5uED8TnC/zFKGZ4HZ7gtkrM ILolKzxpeQp83DELfDLtVFK3PfmlAMcNKrtWGBck3KBf0RNK0KHp6LnHF w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95248249 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:jPER9qD30CzfTRVW///jw5YqxClBgxIJ4kV8jS/XYbTApD933mMGz WtLD2CDPqzYYmHzeItwO4Xn8ElS6pDTyNRmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlA7wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwq/RzBCZ82 P0jExMCTBqIrdDo+7WeY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9K4HQGZUPwhfwS mTup0X7QQ8YKsOllz+dzCmIptTFnzPiR9dHfFG/3qEz2wDCroAJMzUUX1ampfiyimalRslSb UcT/0IGr7U29UGtZsnwWVu/unHslgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQMMinN87Q3otz FDht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHLqZk+lBvVQv5/EaS+iZv+HjSY/ tyRhHFg3fNJ15dNjvjluwmd2FpAu6QlUCZk9AHSGVCI7zhCR4GHbYeC2wbg6tNpedPxoka6g FAInM2X7eYrBJ6LlTCQTOhlIIxF98ppIxWH3wcxQsBJGyCFvif6INsOuG0WyFJBaJ5sRNP/X KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2vpnkGia24hTqFfK0QfUYXZ /+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiHIGedcaAXfP7pohE9hnOkz2 40PXydt40wAONASnwGNqdJDRbz0BSdT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwM/tokC kqVAxcCoHKm3C2vFOl/Qiw7AF8Zdcol/C1T0O1FFQrA5kXPlq71tv1PJsJoJ+V8nAGhpNYtJ 8Q4lwy7KqwnYlz6F/41N/ERcKQKmMyXuD+z IronPort-HdrOrdr: A9a23:OsXi9qMyDOqU/sBcTjejsMiBIKoaSvp037BK7S1MoHtuA6qlfq GV7ZMmPHrP4gr5N0tOpTntAse9qDbnhP1ICOoqTNOftWvd2FdARbsKheffKn/bak/DH4Zmvp uIGJIObeEYY2IasS77ijPIbOrJwrO8gd6VbTG19QYdceloAZsQnzuQEmygYzRLrJEtP+tFKH KbjPA33waISDAsQemQIGIKZOTHr82jruObXfZXbyRXkzVnlFmTmcTHLyQ= X-IronPort-AV: E=Sophos;i="5.97,284,1669093200"; d="scan'208";a="95248249" Date: Thu, 9 Feb 2023 17:59:57 +0000 From: Anthony PERARD To: Jan Beulich CC: George Dunlap , Andrew Cooper , George Dunlap , "Julien Grall" , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: Proposal for consistent Kconfig usage by the hypervisor build system Message-ID: References: <906028ef-b9cd-93bd-8ee2-f263851496f5@citrix.com> <383dfffe-ed1b-7539-d601-c9e7caee22ee@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <383dfffe-ed1b-7539-d601-c9e7caee22ee@suse.com> On Thu, Feb 09, 2023 at 05:08:10PM +0100, Jan Beulich wrote: > On 09.02.2023 17:02, George Dunlap wrote: > > On Thu, Feb 9, 2023 at 1:43 PM Jan Beulich wrote: > > > >> On 02.02.2023 16:51, Andrew Cooper wrote: > >>> On 12/01/2023 4:52 pm, Jan Beulich wrote: > >> > >> Anyway, I have a prototype for the two CET controls mostly ready now, so > >> I guess we'll continue the discussion there once I've submitted that one. > >> > > > > One thing that it occured to me will be important: `make randconfig` must > > continue to work somehow. > > Hmm, good point. For now I've merely added a TBD to the patch I've already > sent. Right now I can't see how that might be possible without the user > specifying which options cannot be turned on due to tool chain dependencies > (by way of a seeding .config, I suppose). > > > I'm not sure how Anthony's patch to deal with `checkpolicy` deals with that. > > Given his remark on the community call I did actually try to locate it, > assuming that it had at least "policy" in the title. But I couldn't find > anything in my mailbox. 0b000a2ce813 ("xen: rework `checkpolicy` detection when using "randconfig"") It boil down to adding "CONFIG_XSM_FLASK_POLICY=n" via KCONFIG_ALLCONFIG option. The macro $(filechk_kconfig_allconfig,) does the job. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 09 18:06:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 18:06:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492892.762655 (Exim 4.92) (envelope-from ) id 1pQBJj-0006If-Ms; Thu, 09 Feb 2023 18:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492892.762655; Thu, 09 Feb 2023 18:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBJj-0006IY-Jr; Thu, 09 Feb 2023 18:06:43 +0000 Received: by outflank-mailman (input) for mailman id 492892; Thu, 09 Feb 2023 18:06:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBJi-0006IO-7U; Thu, 09 Feb 2023 18:06:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBJi-0004TC-3i; Thu, 09 Feb 2023 18:06:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQBJh-0001RS-QR; Thu, 09 Feb 2023 18:06:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQBJh-0000pR-Pw; Thu, 09 Feb 2023 18:06:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WwkSFCETQnBGt7V0q1jAa9hm7mVDQu0d1ukAXglJx/w=; b=rsB9YDVH0n0o2W5Vl6Mhrz7/NQ MLpk9awgLuZxbt8pD1yqGz41jlHTU0uJYwJK6SfHRcQfYSFoLzZeXha6DUmwbxHJvPCR/tgYZ/MzM 59xJ+/JLdlbHaHzciP8+edhtcV+WF23JvnjaCx6RH4AKP3VF5vIZmPMhqBPFB3c/kb7Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176697: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-unstable:test-amd64-amd64-xl-credit2::broken:regression xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:regression xen-unstable:test-amd64-amd64-xl-credit2:host-install(5):broken:regression xen-unstable:test-amd64-amd64-xl-credit1:host-ping-check-native:fail:regression xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 X-Osstest-Versions-That: xen=c0e202194bfcb413d7cf662b333550ed444c469b From: osstest service owner Date: Thu, 09 Feb 2023 18:06:41 +0000 flight 176697 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176697/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken test-amd64-amd64-xl-credit2 broken test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken REGR. vs. 176591 test-amd64-amd64-xl-credit2 5 host-install(5) broken REGR. vs. 176591 test-amd64-amd64-xl-credit1 6 host-ping-check-native fail REGR. vs. 176591 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 176591 test-amd64-i386-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail REGR. vs. 176591 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176591 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176591 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176591 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176591 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176591 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 baseline version: xen c0e202194bfcb413d7cf662b333550ed444c469b Last test of basis 176591 2023-02-08 02:50:13 Z 1 days Testing same since 176697 2023-02-09 02:53:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anthony PERARD Julien Grall Michal Orzel Oleksii Kurochko Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-job test-amd64-amd64-xl-credit2 broken broken-step test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict host-install(5) broken-step test-amd64-amd64-xl-credit2 host-install(5) Not pushing. ------------------------------------------------------------ commit 6d317b10f8e4cbc8092c00ce462d79f13e3ca4f6 Author: Michal Orzel Date: Thu Feb 2 09:49:05 2023 +0100 xen/arm: Add support for booting gzip compressed uImages At the moment, Xen does not support booting gzip compressed uImages. This is because we are trying to decompress the kernel before probing the u-boot header. This leads to a failure as the header always appears at the top of the image (and therefore obscuring the gzip header). Move the call to kernel_uimage_probe before kernel_decompress and make the function self-containing by taking the following actions: - take a pointer to struct bootmodule as a parameter, - check the comp field of a u-boot header to determine compression type, - in case of compressed image, call kernel_decompress passing uImage header size as an offset to gzip header, - set up zimage.{kernel_addr,len} accordingly, - return -ENOENT in case of a u-boot header not found to distinguish it amongst other return values and make it the only case for falling through to try to probe other image types. Modify kernel_decompress to take an additional parameter being an offset to a gzip header from start address. This is needed so that a function can first operate on a region containing actually compressed kernel (in case of compressed uImage, size of u-boot header is an offset to a gzip header) and then at the end pass the entire region (as it was before taking an offset into account) to fw_unreserved_regions for freeing. This approach avoids splitting the uImage probing into 2 stages (executed before and after decompression) which otherwise would be necessary to properly parse header, update boot module start and size before decompression and update zimage.{kernel_addr,len} afterwards. Remove the limitation from the booting.txt documentation. Signed-off-by: Michal Orzel Reviewwed-by: Julien Grall commit 3da5c20cd9223ae122611270bdf25cb29fd9c42a Author: Michal Orzel Date: Thu Feb 2 09:49:04 2023 +0100 xen/arm: Move kernel_uimage_probe definition after kernel_decompress In a follow-up patch, we will be calling kernel_decompress function from within kernel_uimage_probe to support booting compressed images with u-boot header. Therefore, move the kernel_uimage_probe definition after kernel_decompress so that the latter is visible to the former. No functional change intended. Signed-off-by: Michal Orzel Reviewed-by: Ayan Kumar Halder Acked-by: Julien Grall commit b9adcb5ab910b61e5332728bd248906e68a45900 Author: Xenia Ragiadakou Date: Fri Feb 3 21:09:08 2023 +0200 xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros Macro dt_irq() is broken because the macro parameter has the same name with the struct dt_irq member "irq". Macro dt_irq_flags() is broken as well because struct dt_irq has no member named "flags". Since no one seems to have ever tried to use them and eventually stumble upon the issues above, remove them instead of fixing them. Fixes: 886f34045bf0 ("xen/arm: Add helpers to retrieve an interrupt description from the device tree") Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu Acked-by: Julien Grall commit 97266d2ac71e0d966debd9e0b847502b1815e41b Author: Xenia Ragiadakou Date: Fri Feb 3 21:09:07 2023 +0200 xen/device_tree: add parentheses around macro parameters Add parentheses around macro parameters when the precedence and associativity of the performed operators can lead to unintended order of evaluation. This is fixing some ECLAIR finding for Misra Rule 20.7. Link: https://lore.kernel.org/xen-devel/20230203190908.211541-2-burzalodowa@gmail.com/ Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu [jgrall: Reworded the commit message] Acked-by: Julien Grall commit 78c04e24adff84e3325fbdb04e8ffae559876aba Author: Anthony PERARD Date: Wed Feb 8 09:21:24 2023 +0100 libs/light: Makefile cleanup Rework "libacpi.h" include in "libxl_x86_acpi.c" as to be more selective about the include path and only add "tools/libacpi/". Also "libxl_dom.c" don't use "libacpi.h" anymore. Use "-iquote" for libacpi headers. Get rid of the weird "$(eval stem =" in the middle of a recipe and use a make automatic variable "$(*F)" instead. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross commit a2a5d091d0ca78c6a9346c8d4bb8cddc37a07375 Author: Anthony PERARD Date: Wed Feb 8 09:21:11 2023 +0100 libs/light: Rework targets prerequisites No need for $(AUTOSRCS), GNU make can generate them as needed when trying to build them as needed when trying to build the object. Also, those two AUTOSRCS don't need to be a prerequisite of "all". As for the "clean" target, those two files are already removed via "_*.c". We don't need $(AUTOINCS) either: - As for both _libxl_save_msgs*.h headers, we are adding more selective dependencies so the headers will still be generated as needed. - "clean" rule already delete the _*.h files, so AUTOINCS aren't needed there. "libxl_internal_json.h" doesn't seems to have ever existed, so the dependency is removed. Rework objects prerequisites, to have them dependents on either "libxl.h" or "libxl_internal.h". "libxl.h" is not normally included directly in the source code as "libxl_internal.h" is used instead, but we have "libxl.h" as prerequisite of "libxl_internal.h", so generated headers will still be generated as needed. Make doesn't need "libxl.h" to generate "testidl.c", "libxl.h" is only needed later when building "testidl.o". This avoid the need to regenerate "testidl.c" when only "libxl.h" changed. Also use automatic variables $< and $@. Signed-off-by: Anthony PERARD Reviewed-by: Juergen Gross commit 826b270337fe9380519e8dea03442d5430a916b9 Author: Oleksii Kurochko Date: Wed Feb 8 09:20:39 2023 +0100 xen/riscv: introduce empty To include is required Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis commit a49cf4fb61946d79d997eb83b7695f2c5f29892c Author: Oleksii Kurochko Date: Wed Feb 8 09:20:37 2023 +0100 xen/riscv: introduce empty To include is required Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis commit aa492912a64c051e4d3a9246c0d8d7b0f5269152 Author: Oleksii Kurochko Date: Wed Feb 8 09:20:35 2023 +0100 xen/riscv: add " as most of the stuff inside it is present in Xen code base. * Add macros _UL and _ULL as they were in before * Add SATP32_MODE_SHIFT/SATP64_MODE_SHIFT/SATP_MODE_SHIFT as they will be used in riscv/mm.c * Add CAUSE_IRQ_FLAG which is going to be used insised exception handler * Change ulong to unsigned long in macros REG_PTR(...) * Change s32 to int32_t Originally authored by Anup Patel Origin: https://github.com/riscv-software-src/opensbi.git c45992cc2b12 Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis commit 48aabc5de261177c011a55732afbe09373acf465 Author: Oleksii Kurochko Date: Wed Feb 8 09:20:33 2023 +0100 xen/riscv: change ISA to r64G Work with some registers requires csr command which is part of Zicsr. Also ISA was changed from r64ima to r64g where G is represented the “IMAFDZicsr Zifencei” base and extensions so basically it is the same as it was before plus additional extensions we will need in the nearest future. Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 09 20:03:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 20:03:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492903.762666 (Exim 4.92) (envelope-from ) id 1pQD80-0003ma-38; Thu, 09 Feb 2023 20:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492903.762666; Thu, 09 Feb 2023 20:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQD7z-0003mT-VA; Thu, 09 Feb 2023 20:02:43 +0000 Received: by outflank-mailman (input) for mailman id 492903; Thu, 09 Feb 2023 20:02:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQD7y-0003mJ-Q6; Thu, 09 Feb 2023 20:02:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQD7y-0007J8-OT; Thu, 09 Feb 2023 20:02:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQD7y-0006yC-De; Thu, 09 Feb 2023 20:02:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQD7y-0005wM-D8; Thu, 09 Feb 2023 20:02:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/3uHzw1nGlHvRBdSQ6prOHS9tU5Wyeff5lHcG1ArVUo=; b=Zxn3/XRkyYvyimDO0czNNUpHqZ Xp2pswMLcySLzQfdhZQxaoD0SM97FUaS1YLz1VdSNRlO+IwqwwaTvXPAxJ+MT+3V/a0WDAxIlkztH QW1c5Cwr/BKAh7XVrjVm5OGTeDqakh2++v53pxEnBh7j5Ov8Qya/qECwm8yqIa+Hjahg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176766: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5b46dd85d051ceecc2c00a0de27f03e571bff379 X-Osstest-Versions-That: xen=4e0b4ccfc504f26187939068796295340ffd0e2f From: osstest service owner Date: Thu, 09 Feb 2023 20:02:42 +0000 flight 176766 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176766/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5b46dd85d051ceecc2c00a0de27f03e571bff379 baseline version: xen 4e0b4ccfc504f26187939068796295340ffd0e2f Last test of basis 176746 2023-02-09 14:01:53 Z 0 days Testing same since 176766 2023-02-09 18:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Henry Wang Ian Jackson Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4e0b4ccfc5..5b46dd85d0 5b46dd85d051ceecc2c00a0de27f03e571bff379 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 09 20:11:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 20:11:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492911.762677 (Exim 4.92) (envelope-from ) id 1pQDGm-0005To-Vw; Thu, 09 Feb 2023 20:11:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492911.762677; Thu, 09 Feb 2023 20:11:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQDGm-0005Th-SH; Thu, 09 Feb 2023 20:11:48 +0000 Received: by outflank-mailman (input) for mailman id 492911; Thu, 09 Feb 2023 20:11:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQDGl-0005Tb-EE for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 20:11:47 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on20619.outbound.protection.outlook.com [2a01:111:f400:7e8c::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f888fd21-a8b5-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 21:11:44 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by SN7PR12MB7980.namprd12.prod.outlook.com (2603:10b6:806:341::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Thu, 9 Feb 2023 20:11:40 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%8]) with mapi id 15.20.6086.017; Thu, 9 Feb 2023 20:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f888fd21-a8b5-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KVJNTnU7QoMO6jp/TvQ5JkVjtT9iu/Fr66agRDuf87I89iO4BO1ROeh7Cx0L8uYTbkPCSI1J39Fqcjlm/T5fgg59h3GIV6+qXXRDLex9sa6bYwWstHWfgFm1WTHIub8f9UYKoFg0s0F9jo3td1LI79ka4QwlGKd1pd3FKhK1mRWSBYfdmGM2On2nNov+Kh06JxVTKisPko0Jgq9yGo5SdjC/EtY98FQRrQaMc/6TzxHgbQTyGiCHShHSY5ojlGeJ+O/cPEGYnrKgu/yg7+KOf4et5Qzz35OCUWTvZEU1/oam3ekTSE5t2TjC2v+nbOQIDnDYSD90/9wDyzMwuLEmLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OFGY06zPTNqnKGYkvDoBvSMwGEqziDiz8aErmM1+Bp0=; b=BOdDbXb5uTJy4XfACMclP6oGXkrhqDzz1NSXF/aTEZre4LM8IvFO+WfBFx48hzxnBtkJ5Vk+osNznKWL4DiRYjpQ9DOAvqZ8cOZ91bWSY0l3UfDZvjuF59QO0ufgiz0D6srP9krwVDBRl6/hvhChoPngIZN7+xUdjlE0Mkt1ARjtFCi/PEXmBjUTlxJcGUgaisDaPqddjjjIEFFCsNHpx9b/0EiS43vHb3xJOPgnU8C3kTRFJTARZzhQvkdtA0kvEpoGu5sDLb84w/JD0L7QBADvnrFwCmB4/L7LcpMtEFowQi+dotFWMO/HYL/os9FySD3DYp9q2HX51MYl9w3d0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFGY06zPTNqnKGYkvDoBvSMwGEqziDiz8aErmM1+Bp0=; b=qtj4raWz/c8nGgjlMDCQb1WeUHH9ocUAmUaNmM7NhXcb0dov3mLE6ryOeNngo8c2A4opARoVeB2hgVpgKyzOTiQ8eM+aFw1yvcD62LROBKOeoMb+in+SR8o1e+KW7WJVaWrRjNq34VDVPFri4EpGTCAttvHqnvbPhANZPl6AYqQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <7a1d10b9-083c-a8f5-0315-c9f77ad04239@amd.com> Date: Thu, 9 Feb 2023 12:11:36 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 01/16] xen/arm/device: Remove __init from function type To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, Bertrand Marquis , Volodymyr Babchuk References: <20221207061537.7266-1-vikram.garhwal@amd.com> <20221207061537.7266-2-vikram.garhwal@amd.com> <1be7ea27-aec5-e2ae-48c1-fe0c1f099181@amd.com> Content-Language: en-US From: Vikram Garhwal In-Reply-To: <1be7ea27-aec5-e2ae-48c1-fe0c1f099181@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR02CA0016.namprd02.prod.outlook.com (2603:10b6:a02:ee::29) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|SN7PR12MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d409a9a-5968-4572-21cc-08db0ad9dabf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 99Rkf32ZGFmKDDEPnpkv5b4h1vL58WPuvfD4PFnNI5y8HPn31kDSRro+5xAPJYP2AxtDVct5iZCsbf/xCQzz9XuMDXTVoOcAnE2sTP31JlALew368iQkdEcxT9OeVLxzwpOyGwLhnLZy9d0gdZNFe7Iplks9K9yYi6lckwui7Fv+D+Hmoij/eWvoFz2IG7Ensq7n1xdSbCOqDSNNAzdd7PZaB0GGwCzmgrQVWe03gOK8sVHMeF+mSqLLdX3YWgK2E7GrB40Ld8y7vhuj1z4mNI9tfuh/TJaufcEJEOZ0YIXkirXic6gEF0nxHrV6ct8GKsnNhcHoY9VDGdNe0hrCu05NY4J7aEmxbfz44/yDBQsAfcOaletMu4X5E3UbZWeoxrisJhCOU0kUlNX+UvU6dZx+DSMsaqbCUn2MT2Ljvx5HMrwU2KFEnNmEN5gn3y5rStJowlgF7S0qNlxaq4NdoUzDB9at8lqvHohOqc+RXYnbFmareixidhVQai29XKQAVetQ1ne+GwQxm/zvWd8Dtjmsg2Nq4NQmNk67L7nD7zY5OGpTQEeB/QFq3X7JVvW7efjYAdCkXaOjThS6P3xkOI7OcF/u29BGiek4rqIfMCuyGczR4MbVlOsbORaLBEkkuh82JMo+Ie6LkwLAHCKekzmfkCGkudu7tclCh7fRDlyhXATHGadeAUYfuGoT2nDF/8LHnh7J7XhvLGeZNPR5rq/ZNlEAAdoxBQV1IwWMeRI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199018)(6506007)(53546011)(478600001)(186003)(6486002)(26005)(6512007)(31686004)(2616005)(6666004)(8676002)(54906003)(316002)(83380400001)(66946007)(66556008)(66476007)(38100700002)(4326008)(2906002)(36756003)(8936002)(30864003)(44832011)(86362001)(31696002)(41300700001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3U0Wm50ek9YaGU4WTRQWjJiV2Y4ek8xUEc1SGVrZVV4THYyWlZhSktzUWVh?= =?utf-8?B?T1FnckhtTFJjNklXU0pOWEgvUlRlSnZsNXZ4alRwTXFpaWdCM2x6Z3oxOVNR?= =?utf-8?B?b0NTZndzUHc4RTdMdGJEMjcxdkJqZjVac2gvUGJuUk9UK295VDBueUR3RWdY?= =?utf-8?B?VUI5RkR4L2k4QTgyNkhQMktnelI3L1dzM2JHcEhJSWFlSFo1RDVtYXlBamtt?= =?utf-8?B?TEEwRmsya1l0bjJjMW9ERXVEL1VPYm01UVAwUDlWTnFWNXdCTERkVEpZSGlY?= =?utf-8?B?NGxZcTNrcTMxL1NCcjhjZ1U0Qlc0TXo5V3pCMUVPZ05RRFA0YWphRmJYSWxx?= =?utf-8?B?eVFCeS9HMVFPaXNpazRHRGJBdlNwK3Fxbnh3MUFXNHoxT0NSdDFTRFR5RjI3?= =?utf-8?B?ZVRPbHA4Z3VwdG1NamRRREluYWRybDJNVzQ5a0FrdkkxL0ZjNVBhUU5jWDRZ?= =?utf-8?B?RWR6YW9GTDRGVUJaY2ZZL1NPOHh4dVN3OVJibUkydkNlRHZPRFk4elhqcVVD?= =?utf-8?B?YUNCV2lTZENKOGkyaFFrZGh1ZUFhc1pmOUpaL0hjT05OaFN1YTBHWHFiM1B3?= =?utf-8?B?ZjM2TXJkc1V2NEFzTlF4NTM0S1hjYk42Y2tlWXJtRjNlUUd0ZlJReWwvM09q?= =?utf-8?B?a0F3aGtjNFJFSklLZDc3TGxvTmxNNXRQcTNWeTVYa05JQ3VJSmlIdUdKZ3Zz?= =?utf-8?B?bHFSbGwzWFZ2cWlNcUs5SlZpbTM3UXhXcTA3VFFjRUlPQzlUOUdlVkdrNXNy?= =?utf-8?B?N1VBV2szd3ovL3hSSGcrY0RRK3lzOXZHU052MWJMOXF6ZWRIMk91Sm82QnUy?= =?utf-8?B?NVUyUzZJMEFvblAvZEMwcEZaclF0czA3ei9XeWtzMWRIV1RYS1pwUlpsamNT?= =?utf-8?B?ZHZVRWRIU3dWQ21BaFJCZXNJSHEyVnBPSy96c3BqMWZzKzliY00zdnA0R1Nh?= =?utf-8?B?aWZRVkF3TEY0dnovNkRZUWZRTXpnc0Q0Q01uZVFXeVJjT2x3SFVwSzhieDR4?= =?utf-8?B?Y3M5MlRXc3dFNTdJeFhTeE9Ib2N5M3BSK3FpNEhZblFNSUd1SzVsQXQ3SWZo?= =?utf-8?B?SjZCUmI2MzBRQlg0b2FIdnJRUzdEemFJS0tmaGRGOTI5YndNaVhpZ2NscEFs?= =?utf-8?B?TlRvZUtnMEFySzFEcTVvclZOREVGUWZrMzlTc3oyUVNaVENzWURiY2FWUkw1?= =?utf-8?B?U0RiN1JXalB6bUo2L1VLWmtpaVVMMERoTTV6bGZzQmhqVExicEZBcE1rNHpE?= =?utf-8?B?d3BwNDl2ZGl1QXNqSTVHMjhMYkJYTXdDUUh0bEE1V1gyWUZCdWptYlJ1aGpj?= =?utf-8?B?N0tmSU5TKy81RHM2dno2aThJQitGWGtna3hPV3BabDEwTndNVkZvOE02aU1t?= =?utf-8?B?c2k4b3U2cU1tR2ZPZ2k3bmxwZHNraVcxZFVzcnRJL0VMTVZHWHh4azgxcGs4?= =?utf-8?B?bmk3dzV6Zm5ldysrd3JVc1V2cUprKytnWEhxN2F6dXZyYmU0R2FwenlRNVc2?= =?utf-8?B?K3RBT1ZPQVdCWVdWdXM3VmNRNndRMWd0U0FBcXd6ODRWcG9HcElxdWNLSmo1?= =?utf-8?B?TVNEbk5HbDc0QStwVGRNZTRQT00rTldTOGhvd2hpL3FHeWljai9zMGhCbSt0?= =?utf-8?B?M2lCVlJwYm9DUXBweU51R0ErU0lKQ010K3RwOHRKMFVsTHh3NXdsWWtEYmk3?= =?utf-8?B?S3o5SXZ2RXloUENWcFFLNU1pN1ltOG5rZjA1a01uLy9xaVFmQjJWVGE4blVo?= =?utf-8?B?bXAzMndxZjBlZ21nbnpKRXJObU43STlNalBjTzlRNmczQWpUQ1B1dk9GZ0hT?= =?utf-8?B?NjdHenNodTdxclQrdVM3OGRka0dDbmNEUlVISzlqWFRVNnhOc2I4cmpkaXM1?= =?utf-8?B?aHdHblcrUEhEZDN0T3R5b01JUi9CK2xTbEtTc3M3MUM3VncxbC80aWVBQ210?= =?utf-8?B?ajEvSXVuTUoxRmlIMDNKOWF2am9UMVRYeG5ucmhNUkFDdDhPY3JFWFA0c2hK?= =?utf-8?B?bGdaVXBnTmhnZ1N4Z0IwOGFBRlV5ZUIrYUJkM3VPakx0ak5qdEt2YmhQYU4r?= =?utf-8?B?TW9kSUpBdVJucGZISlNhaS85U1BHbFpieDYwRHNVQjhHWUJtRjJIcWFwWkdF?= =?utf-8?Q?H25PPeZyGx4dzoH6oedtBQy3g?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d409a9a-5968-4572-21cc-08db0ad9dabf X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 20:11:39.8915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v1UNeH/jlBVYxWJMa6tpJMVk9b5suAGBCR5H30b/Ur9IDzqdAD0Hgr9nYbIPfZ+SLFfQ65L7o9qbQHbfz3DAJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7980 Hi Michal, Thanks for reviewing this. Please see my comments below. On 1/20/23 4:39 AM, Michal Orzel wrote: > Hi Vikram, > > On 07/12/2022 07:15, Vikram Garhwal wrote: >> >> Change function type of following function to access during runtime: >> 1. map_irq_to_domain() >> 2. handle_device_interrupt() >> 3. map_range_to_domain() >> 4. unflatten_dt_node() >> 5. unflatten_device_tree() > If you do not want to do this at first use, then this should be a separate patch. >> Move map_irq_to_domain(), handle_device_interrupt() and map_range_to_domain() to >> device.c. > This should be a separate patch (without removing __init) to make the comparison easier. Okay > >> unflatten_device_tree(): Add handling of memory allocation failure. > Apart from that you also renamed __unflatten_device_tree to unflatten_device_tree > and you did not mention it. I will add this in commit. > >> These changes are done to support the dynamic programming of a nodes where an >> overlay node will be added to fdt and unflattened node will be added to dt_host. >> Furthermore, IRQ and mmio mapping will be done for the added node. >> >> Signed-off-by: Vikram Garhwal >> --- >> xen/arch/arm/device.c | 145 +++++++++++++++++++++++++++++++ >> xen/arch/arm/domain_build.c | 142 ------------------------------ >> xen/arch/arm/include/asm/setup.h | 3 + >> xen/common/device_tree.c | 27 +++--- >> xen/include/xen/device_tree.h | 5 ++ >> 5 files changed, 170 insertions(+), 152 deletions(-) >> >> diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c >> index 70cd6c1a19..d299c04e62 100644 >> --- a/xen/arch/arm/device.c >> +++ b/xen/arch/arm/device.c >> @@ -21,6 +21,9 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> extern const struct device_desc _sdevice[], _edevice[]; >> extern const struct acpi_device_desc _asdevice[], _aedevice[]; >> @@ -84,6 +87,148 @@ enum device_class device_get_class(const struct dt_device_node *dev) >> return DEVICE_UNKNOWN; >> } >> >> +int map_irq_to_domain(struct domain *d, unsigned int irq, >> + bool need_mapping, const char *devname) >> +{ >> + int res; >> + >> + res = irq_permit_access(d, irq); >> + if ( res ) >> + { >> + printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", >> + d->domain_id, irq); >> + return res; >> + } >> + >> + if ( need_mapping ) >> + { >> + /* >> + * Checking the return of vgic_reserve_virq is not >> + * necessary. It should not fail except when we try to map >> + * the IRQ twice. This can legitimately happen if the IRQ is shared >> + */ >> + vgic_reserve_virq(d, irq); >> + >> + res = route_irq_to_guest(d, irq, irq, devname); >> + if ( res < 0 ) >> + { >> + printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", >> + irq, d->domain_id); >> + return res; >> + } >> + } >> + >> + dt_dprintk(" - IRQ: %u\n", irq); >> + return 0; >> +} >> + >> +int map_range_to_domain(const struct dt_device_node *dev, >> + u64 addr, u64 len, void *data) >> +{ >> + struct map_range_data *mr_data = data; >> + struct domain *d = mr_data->d; >> + int res; >> + >> + /* >> + * reserved-memory regions are RAM carved out for a special purpose. >> + * They are not MMIO and therefore a domain should not be able to >> + * manage them via the IOMEM interface. >> + */ >> + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", >> + strlen("/reserved-memory/")) != 0 ) >> + { >> + res = iomem_permit_access(d, paddr_to_pfn(addr), >> + paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); >> + if ( res ) >> + { >> + printk(XENLOG_ERR "Unable to permit to dom%d access to" >> + " 0x%"PRIx64" - 0x%"PRIx64"\n", >> + d->domain_id, >> + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); >> + return res; >> + } >> + } >> + >> + if ( !mr_data->skip_mapping ) >> + { >> + res = map_regions_p2mt(d, >> + gaddr_to_gfn(addr), >> + PFN_UP(len), >> + maddr_to_mfn(addr), >> + mr_data->p2mt); >> + >> + if ( res < 0 ) >> + { >> + printk(XENLOG_ERR "Unable to map 0x%"PRIx64 >> + " - 0x%"PRIx64" in domain %d\n", >> + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, >> + d->domain_id); >> + return res; >> + } >> + } >> + >> + dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", >> + addr, addr + len, mr_data->p2mt); >> + >> + return 0; >> +} >> + >> +/* >> + * handle_device_interrupts retrieves the interrupts configuration from >> + * a device tree node and maps those interrupts to the target domain. >> + * >> + * Returns: >> + * < 0 error >> + * 0 success >> + */ >> +int handle_device_interrupts(struct domain *d, >> + struct dt_device_node *dev, >> + bool need_mapping) >> +{ >> + unsigned int i, nirq; >> + int res; >> + struct dt_raw_irq rirq; >> + >> + nirq = dt_number_of_irq(dev); >> + >> + /* Give permission and map IRQs */ >> + for ( i = 0; i < nirq; i++ ) >> + { >> + res = dt_device_get_raw_irq(dev, i, &rirq); >> + if ( res ) >> + { >> + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", >> + i, dt_node_full_name(dev)); >> + return res; >> + } >> + >> + /* >> + * Don't map IRQ that have no physical meaning >> + * ie: IRQ whose controller is not the GIC >> + */ >> + if ( rirq.controller != dt_interrupt_controller ) >> + { >> + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", >> + i, dt_node_full_name(rirq.controller)); >> + continue; >> + } >> + >> + res = platform_get_irq(dev, i); >> + if ( res < 0 ) >> + { >> + printk(XENLOG_ERR "Unable to get irq %u for %s\n", >> + i, dt_node_full_name(dev)); >> + return res; >> + } >> + >> + res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); >> + if ( res ) >> + return res; >> + } >> + >> + return 0; >> +} >> + >> /* >> * Local variables: >> * mode: C >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 4fb5c20b13..acde8e714e 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -2229,41 +2229,6 @@ int __init make_chosen_node(const struct kernel_info *kinfo) >> return res; >> } >> >> -int __init map_irq_to_domain(struct domain *d, unsigned int irq, >> - bool need_mapping, const char *devname) >> -{ >> - int res; >> - >> - res = irq_permit_access(d, irq); >> - if ( res ) >> - { >> - printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ %u\n", >> - d->domain_id, irq); >> - return res; >> - } >> - >> - if ( need_mapping ) >> - { >> - /* >> - * Checking the return of vgic_reserve_virq is not >> - * necessary. It should not fail except when we try to map >> - * the IRQ twice. This can legitimately happen if the IRQ is shared >> - */ >> - vgic_reserve_virq(d, irq); >> - >> - res = route_irq_to_guest(d, irq, irq, devname); >> - if ( res < 0 ) >> - { >> - printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", >> - irq, d->domain_id); >> - return res; >> - } >> - } >> - >> - dt_dprintk(" - IRQ: %u\n", irq); >> - return 0; >> -} > If you move map_irq_to_domain from domain_build.c to device.c, then the prototype needs to also > be moved from domain_build.h to setup.h > >> - >> static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, >> const struct dt_irq *dt_irq, >> void *data) >> @@ -2295,57 +2260,6 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, >> return 0; >> } >> >> -int __init map_range_to_domain(const struct dt_device_node *dev, >> - u64 addr, u64 len, void *data) >> -{ >> - struct map_range_data *mr_data = data; >> - struct domain *d = mr_data->d; >> - int res; >> - >> - /* >> - * reserved-memory regions are RAM carved out for a special purpose. >> - * They are not MMIO and therefore a domain should not be able to >> - * manage them via the IOMEM interface. >> - */ >> - if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", >> - strlen("/reserved-memory/")) != 0 ) >> - { >> - res = iomem_permit_access(d, paddr_to_pfn(addr), >> - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); >> - if ( res ) >> - { >> - printk(XENLOG_ERR "Unable to permit to dom%d access to" >> - " 0x%"PRIx64" - 0x%"PRIx64"\n", >> - d->domain_id, >> - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); >> - return res; >> - } >> - } >> - >> - if ( !mr_data->skip_mapping ) >> - { >> - res = map_regions_p2mt(d, >> - gaddr_to_gfn(addr), >> - PFN_UP(len), >> - maddr_to_mfn(addr), >> - mr_data->p2mt); >> - >> - if ( res < 0 ) >> - { >> - printk(XENLOG_ERR "Unable to map 0x%"PRIx64 >> - " - 0x%"PRIx64" in domain %d\n", >> - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, >> - d->domain_id); >> - return res; >> - } >> - } >> - >> - dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", >> - addr, addr + len, mr_data->p2mt); >> - >> - return 0; >> -} >> - >> /* >> * For a node which describes a discoverable bus (such as a PCI bus) >> * then we may need to perform additional mappings in order to make >> @@ -2373,62 +2287,6 @@ static int __init map_device_children(const struct dt_device_node *dev, >> return 0; >> } >> >> -/* >> - * handle_device_interrupts retrieves the interrupts configuration from >> - * a device tree node and maps those interrupts to the target domain. >> - * >> - * Returns: >> - * < 0 error >> - * 0 success >> - */ >> -static int __init handle_device_interrupts(struct domain *d, >> - struct dt_device_node *dev, >> - bool need_mapping) >> -{ >> - unsigned int i, nirq; >> - int res; >> - struct dt_raw_irq rirq; >> - >> - nirq = dt_number_of_irq(dev); >> - >> - /* Give permission and map IRQs */ >> - for ( i = 0; i < nirq; i++ ) >> - { >> - res = dt_device_get_raw_irq(dev, i, &rirq); >> - if ( res ) >> - { >> - printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", >> - i, dt_node_full_name(dev)); >> - return res; >> - } >> - >> - /* >> - * Don't map IRQ that have no physical meaning >> - * ie: IRQ whose controller is not the GIC >> - */ >> - if ( rirq.controller != dt_interrupt_controller ) >> - { >> - dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", >> - i, dt_node_full_name(rirq.controller)); >> - continue; >> - } >> - >> - res = platform_get_irq(dev, i); >> - if ( res < 0 ) >> - { >> - printk(XENLOG_ERR "Unable to get irq %u for %s\n", >> - i, dt_node_full_name(dev)); >> - return res; >> - } >> - >> - res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); >> - if ( res ) >> - return res; >> - } >> - >> - return 0; >> -} >> - >> /* >> * For a given device node: >> * - Give permission to the guest to manage IRQ and MMIO range >> diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h >> index fdbf68aadc..ec050848aa 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -163,6 +163,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells, >> u32 device_tree_get_u32(const void *fdt, int node, >> const char *prop_name, u32 dflt); >> >> +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, >> + bool need_mapping); >> + >> int map_range_to_domain(const struct dt_device_node *dev, >> u64 addr, u64 len, void *data); >> >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index 6c9712ab7b..6518eff9b0 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -1811,12 +1811,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, >> * @allnextpp: pointer to ->allnext from last allocated device_node >> * @fpsize: Size of the node path up at the current depth. >> */ >> -static unsigned long __init unflatten_dt_node(const void *fdt, >> - unsigned long mem, >> - unsigned long *p, >> - struct dt_device_node *dad, >> - struct dt_device_node ***allnextpp, >> - unsigned long fpsize) >> +static unsigned long unflatten_dt_node(const void *fdt, >> + unsigned long mem, >> + unsigned long *p, >> + struct dt_device_node *dad, >> + struct dt_device_node ***allnextpp, >> + unsigned long fpsize) >> { >> struct dt_device_node *np; >> struct dt_property *pp, **prev_pp = NULL; >> @@ -2047,7 +2047,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, >> } >> >> /** >> - * __unflatten_device_tree - create tree of device_nodes from flat blob >> + * unflatten_device_tree - create tree of device_nodes from flat blob >> * >> * unflattens a device-tree, creating the >> * tree of struct device_node. It also fills the "name" and "type" >> @@ -2056,8 +2056,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, >> * @fdt: The fdt to expand >> * @mynodes: The device_node tree created by the call >> */ >> -static void __init __unflatten_device_tree(const void *fdt, >> - struct dt_device_node **mynodes) >> +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) >> { >> unsigned long start, mem, size; >> struct dt_device_node **allnextp = mynodes; >> @@ -2079,6 +2078,12 @@ static void __init __unflatten_device_tree(const void *fdt, >> /* Allocate memory for the expanded device tree */ >> mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct dt_device_node)); >> >> + if ( mem == 0 ) > NIT: !mem would be preffered. > >> + { >> + printk(XENLOG_ERR "Cannot allocate memory for unflatten device tree\n"); >> + return -ENOMEM; > What is the point of modifying the function to return a value if ... >> + } >> + >> ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); >> >> dt_dprintk(" unflattening %lx...\n", mem); >> @@ -2095,6 +2100,8 @@ static void __init __unflatten_device_tree(const void *fdt, >> *allnextp = NULL; >> >> dt_dprintk(" <- unflatten_device_tree()\n"); >> + >> + return 0; >> } >> >> static void dt_alias_add(struct dt_alias_prop *ap, >> @@ -2179,7 +2186,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) >> >> void __init dt_unflatten_host_device_tree(void) >> { >> - __unflatten_device_tree(device_tree_flattened, &dt_host); >> + unflatten_device_tree(device_tree_flattened, &dt_host); > ... you do not check it anyway? So, here we kept it same but unflatten_device_tree() return is checked in dt_overlay.c. Return of this function will be useful in dt_overlay as we can run out of mem during runtime. Perhaps I will add another comment about the reasoning for adding this. > >> dt_alias_scan(); >> } >> >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >> index a28937d12a..bde46d7120 100644 >> --- a/xen/include/xen/device_tree.h >> +++ b/xen/include/xen/device_tree.h >> @@ -181,6 +181,11 @@ int device_tree_for_each_node(const void *fdt, int node, >> */ >> void dt_unflatten_host_device_tree(void); >> >> +/** >> + * unflatten any device tree. >> + */ >> +int unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); >> + >> /** >> * IRQ translation callback >> * TODO: For the moment we assume that we only have ONE >> -- >> 2.17.1 >> >> > ~Michal > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 20:59:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 20:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492920.762688 (Exim 4.92) (envelope-from ) id 1pQE0g-0002Zr-Md; Thu, 09 Feb 2023 20:59:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492920.762688; Thu, 09 Feb 2023 20:59:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQE0g-0002Zk-JC; Thu, 09 Feb 2023 20:59:14 +0000 Received: by outflank-mailman (input) for mailman id 492920; Thu, 09 Feb 2023 20:59:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQE0f-0002Za-Gj; Thu, 09 Feb 2023 20:59:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQE0f-00009N-E9; Thu, 09 Feb 2023 20:59:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQE0f-0001wG-1e; Thu, 09 Feb 2023 20:59:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQE0f-0005Yg-1D; Thu, 09 Feb 2023 20:59:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=veRPVjuTWfIi6B3SkU46U5kJn9JJ58CKp7Qr8cNJ+Ug=; b=bgMhh8Fbdvf2wGqcrbpqRcVgrc 1eK42C6psqGUd77TqG+Ry1V3aDnesTwWxVecQEIr24gHbKuyBvPJxEtPh3OIjBIEPBd0Z/zoY+hrw WOylkU8mwT2bI6Gmg4fzttp5gDjs4olShTF6HyNGehBmo91XYvpoBl+o/t2s5JBgTtMM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176704: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=8a63add283c310952b7df161b4b413e817468d01 X-Osstest-Versions-That: libvirt=c3f16cea3bef578c498c720aa90c677ee9511e2f From: osstest service owner Date: Thu, 09 Feb 2023 20:59:13 +0000 flight 176704 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176704/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 8a63add283c310952b7df161b4b413e817468d01 baseline version: libvirt c3f16cea3bef578c498c720aa90c677ee9511e2f Last test of basis 176598 2023-02-08 04:20:28 Z 1 days Testing same since 176704 2023-02-09 04:21:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Erik Skultety Martin Kletzander Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git c3f16cea3b..8a63add283 8a63add283c310952b7df161b4b413e817468d01 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 09 21:16:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 21:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492929.762700 (Exim 4.92) (envelope-from ) id 1pQEH6-0005EO-5w; Thu, 09 Feb 2023 21:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492929.762700; Thu, 09 Feb 2023 21:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQEH6-0005EH-1W; Thu, 09 Feb 2023 21:16:12 +0000 Received: by outflank-mailman (input) for mailman id 492929; Thu, 09 Feb 2023 21:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQEH4-0005E7-SX for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 21:16:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6455f47-a8be-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 22:16:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CB8E61BBE; Thu, 9 Feb 2023 21:16:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4643FC433D2; Thu, 9 Feb 2023 21:16:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6455f47-a8be-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675977363; bh=tdg3Xf6UaRzZYsb0hyMnspMERa1wzVeI/TLAqHpLSyc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pROLccJ9n8N9OlrR+drGROH+VB2DyyQZO2ra8VE1P5wXiLjvIRASFrHGqyYjVJwfj ttWox9dJ/LjKqGO+y4kTzSpNBoUx1NCP+nGsPT4G1QpY/WCQJBH5sGae1FbfrSf6TK 2QXiztYB1/HsDlTl0znC9Ek5BK6YnlbzPZjkxCDYq20WNVwDfUHeDJsISt3gvMiKFz QRAXAAfuye9mIeFVDqeEKnCpIdD0RqlnbUvqRizN9ArTQp66kEmapjmTjP81vlRL+g MSnPahc9lz8Zonsm+8+X5EWbGRDfBXb/D2C8WbdMRzc+1AqFG1kjzqVxV2505Cbq+3 W4MDSTKeRK6mQ== Date: Thu, 9 Feb 2023 13:16:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org Subject: Re: [PATCH v4 1/2 RESEND] xen/public: fix 9pfs Xenstore entry documentation In-Reply-To: <20230209112338.26287-2-jgross@suse.com> Message-ID: References: <20230209112338.26287-1-jgross@suse.com> <20230209112338.26287-2-jgross@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 9 Feb 2023, Juergen Gross wrote: > In xen/include/public/io/9pfs.h the documentation regarding the > Xenstore entries isn't reflecting reality: the "tag" Xenstore entry > is on the frontend side, not on the backend one. > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > V4: > - patch split off (Julien Grall) > --- > xen/include/public/io/9pfs.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/xen/include/public/io/9pfs.h b/xen/include/public/io/9pfs.h > index 5dad0db869..617ad9afd7 100644 > --- a/xen/include/public/io/9pfs.h > +++ b/xen/include/public/io/9pfs.h > @@ -64,12 +64,6 @@ > * > * Host filesystem path to share. > * > - * tag > - * Values: > - * > - * Alphanumeric tag that identifies the 9pfs share. The client needs > - * to know the tag to be able to mount it. > - * > * security-model > * Values: "none" > * > @@ -106,6 +100,12 @@ > * map a page with information to setup a share ring. One for each > * ring. > * > + * tag > + * Values: > + * > + * Alphanumeric tag that identifies the 9pfs share. The client needs > + * to know the tag to be able to mount it. > + * > ****************************************************************************** > * State Machine > ****************************************************************************** > -- > 2.35.3 > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 21:18:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 21:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492936.762710 (Exim 4.92) (envelope-from ) id 1pQEJ8-0005yX-GL; Thu, 09 Feb 2023 21:18:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492936.762710; Thu, 09 Feb 2023 21:18:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQEJ8-0005yQ-DL; Thu, 09 Feb 2023 21:18:18 +0000 Received: by outflank-mailman (input) for mailman id 492936; Thu, 09 Feb 2023 21:18:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQEJ7-0005yK-Ch for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 21:18:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43a39313-a8bf-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 22:18:15 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36FF261B9A; Thu, 9 Feb 2023 21:18:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B4DFC433D2; Thu, 9 Feb 2023 21:18:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43a39313-a8bf-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675977493; bh=TwrkKixYUqMGSHQPsVFoLPt/9m66xB78HwuINd6WUfI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mpZjpjgwArJcU3nB8W+YxNaWJkrrnYb8fC0uOBjUOY5b3ij4BGJLKTeyG66u1rN1b Obi4a5ty06j1cs+jqVUj1KgXdXcCj8FFjhRX8rukTt0UZyuN/xZmUjJ3wk4XbC6neZ I3qC3Ih29JfRYN31XDJIIZmCDpzBTA+8vkgiw1tr1FArObQVyLMXpYhrJhxIU57sg3 La7Yfa50YiqMWS1qqsU149jKPmISmhE6PgamDaM4ysKMIofMiDtVzseZppiOi840BX l6ald6KXkY/oYYbR66+9oKC2FtQQ1+pdoaNskdCwBlecNeIDdH3c5lSfh20nmTAHkF fxXwp8EbBHDtw== Date: Thu, 9 Feb 2023 13:18:10 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Juergen Gross cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, julien@xen.org, sstabellini@kernel.org, wl@xen.org Subject: Re: [PATCH v4 2/2 RESEND] xen/public: fix 9pfs documentation of connection sequence In-Reply-To: <20230209112338.26287-3-jgross@suse.com> Message-ID: References: <20230209112338.26287-1-jgross@suse.com> <20230209112338.26287-3-jgross@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 9 Feb 2023, Juergen Gross wrote: > The documented connection sequence in xen/include/public/io/9pfs.h has > a bug: the frontend needs to wait for the backend to have published its > features before being able to allocate its rings and event-channels. > > While correcting that, make it clear that there might be multiple > rings and event-channels by adding "(s)". > > Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini > --- > V4: > - patch split off (Julien Grall) > --- > xen/include/public/io/9pfs.h | 32 ++++++++++++++++++++++---------- > 1 file changed, 22 insertions(+), 10 deletions(-) > > diff --git a/xen/include/public/io/9pfs.h b/xen/include/public/io/9pfs.h > index 617ad9afd7..a0ce82d0a8 100644 > --- a/xen/include/public/io/9pfs.h > +++ b/xen/include/public/io/9pfs.h > @@ -114,14 +114,26 @@ > * > * *Front* *Back* > * XenbusStateInitialising XenbusStateInitialising > - * - Query virtual device - Query backend device > - * properties. identification data. > - * - Setup OS device instance. - Publish backend features > - * - Allocate and initialize the and transport parameters > - * request ring. | > - * - Publish transport parameters | > - * that will be in effect during V > - * this connection. XenbusStateInitWait > + * - Query backend device > + * identification data. > + * - Publish backend features > + * and transport parameters. > + * | > + * | > + * V > + * XenbusStateInitWait > + * > + * - Query virtual device > + * properties. > + * - Query backend features and > + * transport parameters. > + * - Setup OS device instance. > + * - Allocate and initialize the > + * request ring(s) and > + * event-channel(s). > + * - Publish transport parameters > + * that will be in effect during > + * this connection. > * | > * | > * V > @@ -129,8 +141,8 @@ > * > * - Query frontend transport > * parameters. > - * - Connect to the request ring and > - * event channel. > + * - Connect to the request ring(s) > + * and event channel(s). > * | > * | > * V > -- > 2.35.3 > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 21:54:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 21:54:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492945.762720 (Exim 4.92) (envelope-from ) id 1pQErb-0002L2-7V; Thu, 09 Feb 2023 21:53:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492945.762720; Thu, 09 Feb 2023 21:53:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQErb-0002Kv-4s; Thu, 09 Feb 2023 21:53:55 +0000 Received: by outflank-mailman (input) for mailman id 492945; Thu, 09 Feb 2023 21:53:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQErZ-0002Kp-DM for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 21:53:53 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d8a86a3-a8c4-11ed-933c-83870f6b2ba8; Thu, 09 Feb 2023 22:53:52 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id c26so5902992ejz.10 for ; Thu, 09 Feb 2023 13:53:51 -0800 (PST) Received: from [127.0.0.1] (dynamic-077-011-177-219.77.11.pool.telefonica.de. [77.11.177.219]) by smtp.gmail.com with ESMTPSA id q25-20020a50cc99000000b004a24b8b58cbsm1318598edi.16.2023.02.09.13.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 13:53:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d8a86a3-a8c4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=itT7CNNYwIbGw/NdhBVioMq1qk/0q2en8jeZiTvu8fM=; b=gvkdPO+ea8gbJrkwujaXuq7jqd/x4q/yoZr/60V6ZoeTTF6CXPrsxdbDvp58h25VsY gMCOWNcSa8jF3Z7//UFAWiQIDoN9oOAvoPxiQpMeFziN3CCAwwMJ6GJ1zrartjupv+ZG grh6lZGDFObX5DwdUHW8wwXlMMISHQubCBP0pXVVualrI4IHsFeFvDXp61y6n9JvotOr JW4rtSkplS8r0DJZxifuoVbFWSom8YloiJ9CKfnW6TaK1TNNHrkkBsjuAFxpML2kCxV1 wTt4V7NnWFpOa80BgYPhVfH+Hgk2Wqb47ehOk/qi9VoRyjUzG3edsXPnpzq+Ca/44qoP KE+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=itT7CNNYwIbGw/NdhBVioMq1qk/0q2en8jeZiTvu8fM=; b=zQo+Edo2Pa0K+36EgDm9LCsI0rUqmRvPt2upY/K+rhBfnAVLf0V5yy6KLG8DISy3xU VHqRVpg8hwTQZ66oKQBuNeT6PXbdjFLhNgFXipUPV6xXcIT6ranX/4Z1vadljLDeWsnP +uIKKa8tyTMBys45x43agl0EFLIgu/hdsAduYr3pOqXOqvUpYjd//U1fCcBG0hHUICBQ LtgyvbqAh4WcoiTy4wL6+LPvRuj4P+j/8PycQQvTkQPxHRaBKBEyxMyV62jsMQZ0ya8g /4ed0nKZ1/BYU8qBhGLsLjH5AUl7TZWrGyUGZXfT5eyiHHrHPzGygqau/bvVmo7+8Tvi kv6A== X-Gm-Message-State: AO0yUKWpvARL20xzYI6NWEL8Ni/ZOe0eRccB6AVS3OU1VeozdUTuWfte dSRrfZfatXTtiwbXh9nAy1A= X-Google-Smtp-Source: AK7set+8AOKT8imCofnKhSOXuWnoO7CZmbZIKmaAC/5ETBa5KX7LXmOcaqdQ1HR9CDMB3Tr6dFoSnA== X-Received: by 2002:a17:906:1252:b0:889:7781:f62e with SMTP id u18-20020a170906125200b008897781f62emr14288663eja.22.1675979631428; Thu, 09 Feb 2023 13:53:51 -0800 (PST) Date: Thu, 09 Feb 2023 21:53:41 +0000 From: Bernhard Beschow To: Anthony PERARD CC: qemu-devel@nongnu.org, Richard Henderson , Stefano Stabellini , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Aurelien Jarno , Paul Durrant , Marcel Apfelbaum , Paolo Bonzini , Eduardo Habkost , =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Chuck Zmudzinski , "Michael S. Tsirkin" Subject: Re: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE In-Reply-To: <96A4863B-D6BA-48B5-B5E4-54DD103FEBAA@gmail.com> References: <20230104144437.27479-1-shentey@gmail.com> <20230118051230-mutt-send-email-mst@kernel.org> <0C2B1FE4-BB48-4C38-9161-6569BA1D6226@gmail.com> <96A4863B-D6BA-48B5-B5E4-54DD103FEBAA@gmail.com> Message-ID: <6C8AA4D4-FF57-4E43-A464-7F64C576ED5B@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 1=2E Februar 2023 08:11:10 UTC schrieb Bernhard Beschow : > > >Am 24=2E Januar 2023 17:07:30 UTC schrieb Bernhard Beschow : >> >> >>Am 24=2E Januar 2023 16:11:47 UTC schrieb Anthony PERARD : >>>On Wed, Jan 18, 2023 at 05:13:03AM -0500, Michael S=2E Tsirkin wrote: >>>> On Wed, Jan 04, 2023 at 03:44:31PM +0100, Bernhard Beschow wrote: >>>> > This series first renders TYPE_PIIX3_XEN_DEVICE redundant and final= ly removes >>>> > it=2E The motivation is to 1/ decouple PIIX from Xen and 2/ to make= Xen in the PC >>>> > machine agnostic to the precise southbridge being used=2E 2/ will b= ecome >>>> > particularily interesting once PIIX4 becomes usable in the PC machi= ne, avoiding >>>> > the "Frankenstein" use of PIIX4_ACPI in PIIX3=2E >>>>=20 >>>> Looks ok to me=2E >>>> Reviewed-by: Michael S=2E Tsirkin >>>>=20 >>>> Feel free to merge through Xen tree=2E >>> >>>Hi Bernhard, >> >>Hi Anthony, >> >>>The series currently doesn't apply on master=2E And a quick try at >>>applying the series it is based on also failed=2E Could you rebase it ,= or >>>maybe you would prefer to wait until the other series "Consolidate >>>PIIX=2E=2E=2E" is fully applied? >> >>Thanks for looking into it! >> >>You can get the compilable series from https://patchew=2Eorg/QEMU/202301= 04144437=2E27479-1-shentey@gmail=2Ecom/ =2E If it doesn't work for you let = me know, then I can rebase onto master=2E All necessary dependencies for th= e series are upstreamed meanwhile=2E > >Ping Ping^2 > >> >>Thanks, >>Bernhard >>> >>>Thanks=2E >>> >>>> > Testing done: >>>> > None, because I don't know how to conduct this properly :( >>>> >=20 >>>> > Based-on: <20221221170003=2E2929-1-shentey@gmail=2Ecom> >>>> > "[PATCH v4 00/30] Consolidate PIIX south bridges" >>> From xen-devel-bounces@lists.xenproject.org Thu Feb 09 22:46:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 22:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492956.762732 (Exim 4.92) (envelope-from ) id 1pQFfw-0000D3-05; Thu, 09 Feb 2023 22:45:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492956.762732; Thu, 09 Feb 2023 22:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFfv-0000Cw-SQ; Thu, 09 Feb 2023 22:45:55 +0000 Received: by outflank-mailman (input) for mailman id 492956; Thu, 09 Feb 2023 22:45:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFft-0000Cn-Ug for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 22:45:53 +0000 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [2607:f8b0:4864:20::e31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ffce9c8-a8cb-11ed-93b5-47a8fe42b414; Thu, 09 Feb 2023 23:45:51 +0100 (CET) Received: by mail-vs1-xe31.google.com with SMTP id l8so3769505vsm.11 for ; Thu, 09 Feb 2023 14:45:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ffce9c8-a8cb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y8kFwis3pzEZ5yShlWxbV4o74IEFVkY2Kbc/fc1drLg=; b=OtoiH4yr1E1UD0IDRsByA222jIV5cwfiknYtPetwtgrr2fzs3JplVE1qTrTgWLxC8s 0w9qgIMApVrueQYH263P3680ikbO5WWuhCllcRJPPEiEZDs2rldm2JeNbtfkouZ/jrlT aEEqacx8V1Mvc8mxby9O5+meFI2cstNuRUoGpCmlFQqDFyKv/qFFL8R14/kf2W+iY78x MH6K1kLIB43E3EPF9Q6DUnNuv+NFJgrinXYkcYsL78w/2AUIPmyM9alBMLaoF/JyXo3J J10Z9tIQFmrKPebiXlTfD6SJWpMNuxkShsqlD8ET5HxJSt8kKDmw2sNGK4dF3zwaeFXo rBBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y8kFwis3pzEZ5yShlWxbV4o74IEFVkY2Kbc/fc1drLg=; b=L0R7qdWSd3PJ7u52dZykqyhP+mD8XejTTPW1kBO9Ze1F3cs0vNUKm8tDTYtRWfVArP CSv252fJ/rFcCZTxqdgiMAiwECbxYmulBeHYklZTCR+NzEieu5zao2YOkv4UiMSoCQp4 v9EOKTsZ4Mz4+rRG8sUJALMwcANtNr3IQ23F3tEOhgYJ2WDkLYjicY+B+xSbAgSpHE3D 541L+DAXOYMsCDEjTqEK/6MuMvIs1P45JxSqxSPQsktAUXj79vlRBnrXzZpalBxfu/M0 9lsuj2Z+xZKuXFx1zgxNnarFgUO6IAQ1pp2eeth8wRTzV4iCzgPeyg/rB9gpNO8MSm5v RXfA== X-Gm-Message-State: AO0yUKXJ1+kzhn2+Wmy5jCSprw9E4zeDC4eUdurGsP49Obm5SLEa0tsE W+l1CHnTI0PgWy6uKwt/SK+n4HNcSHAENG4aUQI= X-Google-Smtp-Source: AK7set+TDB/iSty1FOgMcwRZnU0o/YA3V6ejbyFonm3GmJ+O1pKlXwSYLXDLSUFqHw2fMNcOBSBimJxU6sXqiRw9mq4= X-Received: by 2002:a67:a407:0:b0:3f0:89e1:7c80 with SMTP id n7-20020a67a407000000b003f089e17c80mr2444094vse.72.1675982749302; Thu, 09 Feb 2023 14:45:49 -0800 (PST) MIME-Version: 1.0 References: <15a27b40-54ab-6b7a-9702-f72cf870e6d1@suse.com> In-Reply-To: <15a27b40-54ab-6b7a-9702-f72cf870e6d1@suse.com> From: Alistair Francis Date: Fri, 10 Feb 2023 08:45:23 +1000 Message-ID: Subject: Re: [PATCH] riscv: add temporary riscv64_defconfig alias To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Bobby Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Thu, Feb 9, 2023 at 8:02 PM Jan Beulich wrote: > > This is to allow building of Xen without going through a separate > tiny64_defconfig build step, just like is possible for all other > architectures. Eventually the symlink will want replacing by, > presumably, an empty file just like other arches have. > > Signed-off-by: Jan Beulich Acked-by: Alistair Francis Alistair > --- > xen/arch/riscv/configs/riscv64_defconfig | 1 + > 1 file changed, 1 insertion(+) > create mode 120000 xen/arch/riscv/configs/riscv64_defconfig > > diff --git a/xen/arch/riscv/configs/riscv64_defconfig b/xen/arch/riscv/configs/riscv64_defconfig > new file mode 120000 > index 000000000000..c3c97b4d109b > --- /dev/null > +++ b/xen/arch/riscv/configs/riscv64_defconfig > @@ -0,0 +1 @@ > +tiny64_defconfig > \ No newline at end of file > -- > 2.37.1 > From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492970.762807 (Exim 4.92) (envelope-from ) id 1pQFu8-0004KD-8W; Thu, 09 Feb 2023 23:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492970.762807; Thu, 09 Feb 2023 23:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu8-0004Jr-2A; Thu, 09 Feb 2023 23:00:36 +0000 Received: by outflank-mailman (input) for mailman id 492970; Thu, 09 Feb 2023 23:00:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu6-0003mg-HT for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu6-00030C-1f; Thu, 09 Feb 2023 23:00:34 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFu5-00085P-QW; Thu, 09 Feb 2023 23:00:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=0krr1/40/JlLOTiOy4EMHtxQHCIKvf7q62mQbRVJo8Q=; b=WTGF/tpeIxAkgEdAGJjU2Y1PkT ZERB9K4+VdsxOaUBUzOp8wcYXg+hSAXRS4UUbhMuzLcjgocz7Agil7pe2QyMiSwVamP/XEoZ0Px4Y tAKGl8bdP8EGFkbDxFHkF8+dvF6HdSGuEtZk6pOQaZrE22wd8efl75ayKeF37eWJGtjs=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [PATCH 6/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 3) Date: Thu, 9 Feb 2023 23:00:20 +0000 Message-Id: <20230209230020.52695-7-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0-pattern-3.txt * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . 42sh> find xen/arch/x86/ -name '*.h' -exec replace_license.py gpl-2.0-pattern-3.txt GPL-2.0 {} \; --- xen/arch/x86/include/asm/guest.h | 13 +------------ xen/arch/x86/include/asm/guest/hyperv-hcall.h | 13 +------------ xen/arch/x86/include/asm/guest/hyperv.h | 13 +------------ xen/arch/x86/include/asm/guest/hypervisor.h | 13 +------------ xen/arch/x86/include/asm/guest/pvh-boot.h | 13 +------------ xen/arch/x86/include/asm/guest/xen-hcall.h | 13 +------------ xen/arch/x86/include/asm/guest/xen.h | 13 +------------ xen/arch/x86/include/asm/hvm/grant_table.h | 13 +------------ xen/arch/x86/include/asm/pv/domain.h | 13 +------------ xen/arch/x86/include/asm/pv/grant_table.h | 13 +------------ xen/arch/x86/include/asm/pv/mm.h | 13 +------------ xen/arch/x86/include/asm/pv/shim.h | 13 +------------ xen/arch/x86/include/asm/pv/traps.h | 13 +------------ 13 files changed, 13 insertions(+), 156 deletions(-) diff --git a/xen/arch/x86/include/asm/guest.h b/xen/arch/x86/include/asm/guest.h index ccf1ffbb729a..5f30de747c8c 100644 --- a/xen/arch/x86/include/asm/guest.h +++ b/xen/arch/x86/include/asm/guest.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv-hcall.h b/xen/arch/x86/include/asm/guest/hyperv-hcall.h index 423ca0860b5d..6af8c5c57b09 100644 --- a/xen/arch/x86/include/asm/guest/hyperv-hcall.h +++ b/xen/arch/x86/include/asm/guest/hyperv-hcall.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/hyperv-hcall.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hyperv.h b/xen/arch/x86/include/asm/guest/hyperv.h index 1a1b47831c8d..9e16961dc52f 100644 --- a/xen/arch/x86/include/asm/guest/hyperv.h +++ b/xen/arch/x86/include/asm/guest/hyperv.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/hyperv.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h index 0a6c3b47ab36..f06ea0a85cd8 100644 --- a/xen/arch/x86/include/asm/guest/hypervisor.h +++ b/xen/arch/x86/include/asm/guest/hypervisor.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/hypervisor.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2019 Microsoft. */ diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 48ffd1a0b1b4..215955e24ce1 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/pvh-boot.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen-hcall.h b/xen/arch/x86/include/asm/guest/xen-hcall.h index 03d5868a9efd..87274e21ff29 100644 --- a/xen/arch/x86/include/asm/guest/xen-hcall.h +++ b/xen/arch/x86/include/asm/guest/xen-hcall.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/xen-hcall.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/guest/xen.h b/xen/arch/x86/include/asm/guest/xen.h index 2042a9a0c253..e81fafd080c6 100644 --- a/xen/arch/x86/include/asm/guest/xen.h +++ b/xen/arch/x86/include/asm/guest/xen.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/xen.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/hvm/grant_table.h b/xen/arch/x86/include/asm/hvm/grant_table.h index a5612585b35e..d2cee25f5de3 100644 --- a/xen/arch/x86/include/asm/hvm/grant_table.h +++ b/xen/arch/x86/include/asm/hvm/grant_table.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asm-x86/hvm/grant_table.h * * Grant table interfaces for HVM guests * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #ifndef __X86_HVM_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h index 924508bbb4f0..11426dd7cb75 100644 --- a/xen/arch/x86/include/asm/pv/domain.h +++ b/xen/arch/x86/include/asm/pv/domain.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * pv/domain.h * * PV guest interface definitions * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #ifndef __X86_PV_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/pv/grant_table.h b/xen/arch/x86/include/asm/pv/grant_table.h index 85442b60749f..402bbd345a83 100644 --- a/xen/arch/x86/include/asm/pv/grant_table.h +++ b/xen/arch/x86/include/asm/pv/grant_table.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asm-x86/pv/grant_table.h * * Grant table interfaces for PV guests * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #ifndef __X86_PV_GRANT_TABLE_H__ diff --git a/xen/arch/x86/include/asm/pv/mm.h b/xen/arch/x86/include/asm/pv/mm.h index 9983f8257c63..39b42f5d706a 100644 --- a/xen/arch/x86/include/asm/pv/mm.h +++ b/xen/arch/x86/include/asm/pv/mm.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asm-x86/pv/mm.h * * Memory management interfaces for PV guests * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #ifndef __X86_PV_MM_H__ diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h index a43c3689b48a..311b83972600 100644 --- a/xen/arch/x86/include/asm/pv/shim.h +++ b/xen/arch/x86/include/asm/pv/shim.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/guest/shim.h * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/pv/traps.h b/xen/arch/x86/include/asm/pv/traps.h index 855203c4e288..36bff76e0d74 100644 --- a/xen/arch/x86/include/asm/pv/traps.h +++ b/xen/arch/x86/include/asm/pv/traps.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * pv/traps.h * * PV guest traps interface definitions * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #ifndef __X86_PV_TRAPS_H__ -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492965.762749 (Exim 4.92) (envelope-from ) id 1pQFu2-0002vP-Lt; Thu, 09 Feb 2023 23:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492965.762749; Thu, 09 Feb 2023 23:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu2-0002vF-HS; Thu, 09 Feb 2023 23:00:30 +0000 Received: by outflank-mailman (input) for mailman id 492965; Thu, 09 Feb 2023 23:00:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu0-0002rg-Ti for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFty-0002z1-Un; Thu, 09 Feb 2023 23:00:26 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFty-00085P-Im; Thu, 09 Feb 2023 23:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=LljhuvpwgXyxpkGUKmVnFpYI6mcRI4zQJLFFFZ5wgts=; b=pBiaBDG7mHoQDSDoCg3R0hpQOF 25ztjt2Lw261AYCROpdpsRKAmZekA0EFdNXZwSkIW5/V7Ae48g7PZYkcE4gxSKfLBvML2uWkP0Vqy xAy+bgECfAGvPBqPcgDkmGSRJ8MejRywk0EH/si0Lv1YV2xhbvL8K0Czp7XN2XZJfFZ4=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap Subject: [PATCH 1/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c Date: Thu, 9 Feb 2023 23:00:15 +0000 Message-Id: <20230209230020.52695-2-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0.txt * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . 42sh> find xen/arch/x86/ -name '*.c' -exec replace_license.py gpl-2.0.txt GPL-2.0 {} \; --- xen/arch/x86/cpu/mwait-idle.c | 13 +------------ xen/arch/x86/cpu/vpmu.c | 13 +------------ xen/arch/x86/cpu/vpmu_amd.c | 13 +------------ xen/arch/x86/cpu/vpmu_intel.c | 13 +------------ xen/arch/x86/genapic/x2apic.c | 13 +------------ xen/arch/x86/hvm/asid.c | 13 +------------ xen/arch/x86/hvm/dm.c | 13 +------------ xen/arch/x86/hvm/hpet.c | 13 +------------ xen/arch/x86/hvm/hvm.c | 13 +------------ xen/arch/x86/hvm/intercept.c | 13 +------------ xen/arch/x86/hvm/io.c | 13 +------------ xen/arch/x86/hvm/ioreq.c | 13 +------------ xen/arch/x86/hvm/irq.c | 13 +------------ xen/arch/x86/hvm/mtrr.c | 13 +------------ xen/arch/x86/hvm/nestedhvm.c | 13 +------------ xen/arch/x86/hvm/pmtimer.c | 13 +------------ xen/arch/x86/hvm/quirks.c | 13 +------------ xen/arch/x86/hvm/save.c | 13 +------------ xen/arch/x86/hvm/svm/asid.c | 13 +------------ xen/arch/x86/hvm/svm/emulate.c | 13 +------------ xen/arch/x86/hvm/svm/intr.c | 13 +------------ xen/arch/x86/hvm/svm/nestedsvm.c | 13 +------------ xen/arch/x86/hvm/svm/svm.c | 13 +------------ xen/arch/x86/hvm/svm/svmdebug.c | 13 +------------ xen/arch/x86/hvm/svm/vmcb.c | 13 +------------ xen/arch/x86/hvm/vlapic.c | 13 +------------ xen/arch/x86/hvm/vmx/intr.c | 13 +------------ xen/arch/x86/hvm/vmx/vmcs.c | 13 +------------ xen/arch/x86/hvm/vmx/vmx.c | 13 +------------ xen/arch/x86/hvm/vmx/vvmx.c | 13 +------------ xen/arch/x86/hvm/vpt.c | 13 +------------ xen/arch/x86/mm/altp2m.c | 13 +------------ xen/arch/x86/mm/hap/guest_walk.c | 13 +------------ xen/arch/x86/mm/hap/nested_ept.c | 13 +------------ xen/arch/x86/mm/p2m-ept.c | 13 +------------ 35 files changed, 35 insertions(+), 420 deletions(-) diff --git a/xen/arch/x86/cpu/mwait-idle.c b/xen/arch/x86/cpu/mwait-idle.c index 9e981e7e26dc..83bd9956ed36 100644 --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * mwait_idle.c - native hardware idle loop for modern processors * * Copyright (c) 2013, Intel Corporation. * Len Brown - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ /* diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index b6b7342fb466..22d5d476ac3f 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpmu.c: PMU virtualization for HVM domain. * * Copyright (c) 2007, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * * Author: Haitao Shan */ #include diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 58794a16f06c..229b46268052 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpmu.c: PMU virtualization for HVM domain. * @@ -7,18 +8,6 @@ * Author: Wei Wang * Tested by: Suravee Suthikulpanit * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #include diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index a8df52579db8..24c3b91eda56 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpmu_core2.c: CORE 2 specific PMU virtualization for HVM domain. * * Copyright (c) 2007, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * * Author: Haitao Shan */ diff --git a/xen/arch/x86/genapic/x2apic.c b/xen/arch/x86/genapic/x2apic.c index f73390cdb017..f38cb160ce6e 100644 --- a/xen/arch/x86/genapic/x2apic.c +++ b/xen/arch/x86/genapic/x2apic.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * x2APIC driver. * * Copyright (c) 2008, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/asid.c b/xen/arch/x86/hvm/asid.c index 1fd2770a3ae0..81969ba483e9 100644 --- a/xen/arch/x86/hvm/asid.c +++ b/xen/arch/x86/hvm/asid.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asid.c: ASID management * Copyright (c) 2007, Advanced Micro Devices, Inc. * Copyright (c) 2009, Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index f8e6089870b0..ffe7a48a55c7 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -1,17 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2016 Citrix Systems Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index c65e1b27d09e..b760a321cbf2 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hpet.c: HPET emulation for HVM guests. * Copyright (c) 2006, Intel Corporation. * Copyright (c) 2006, Keir Fraser - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5c1e64189600..8718401655e4 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm.c: Common hardware virtual machine abstractions. * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2005, International Business Machines Corporation. * Copyright (c) 2008, Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c index ffa31b746716..6eef70d4ae8c 100644 --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * intercept.c: Handle performance critical I/O packets in hypervisor space * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2008, Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 5ae209d3b6b3..77a14bdd0fa3 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * io.c: Handling I/O and interrupts. * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2005, International Business Machines Corporation. * Copyright (c) 2008, Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 0bdcca1e1a5f..ab2fcae8836e 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm/io.c: hardware virtual machine I/O emulation * * Copyright (c) 2016 Citrix Systems Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 4fe87a71c12b..a75c514917f8 100644 --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * irq.c * * Interrupt distribution and delivery logic. * * Copyright (c) 2006, K A Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 344edc2d6a96..0bd8852dd3e8 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * mtrr.c: MTRR/PAT virtualization * * Copyright (c) 2007, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/nestedhvm.c b/xen/arch/x86/hvm/nestedhvm.c index 58370190ffc9..b7ad5cb94788 100644 --- a/xen/arch/x86/hvm/nestedhvm.c +++ b/xen/arch/x86/hvm/nestedhvm.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Nested HVM * Copyright (c) 2011, Advanced Micro Devices, Inc. * Author: Christoph Egger - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c index b89d0fd53ba1..8075cc139b09 100644 --- a/xen/arch/x86/hvm/pmtimer.c +++ b/xen/arch/x86/hvm/pmtimer.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm/pmtimer.c: emulation of the ACPI PM timer * * Copyright (c) 2007, XenSource inc. * Copyright (c) 2006, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/quirks.c b/xen/arch/x86/hvm/quirks.c index 2adab1f4b84b..d0b91031cf07 100644 --- a/xen/arch/x86/hvm/quirks.c +++ b/xen/arch/x86/hvm/quirks.c @@ -1,17 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * x86/hvm/quirks.c - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/save.c b/xen/arch/x86/hvm/save.c index c1675e3d9fb0..a4b7d90d55aa 100644 --- a/xen/arch/x86/hvm/save.c +++ b/xen/arch/x86/hvm/save.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm/save.c: Save and restore HVM guest's emulated hardware state. * @@ -6,18 +7,6 @@ * Copyright (c) 2007, Isaku Yamahata * VA Linux Systems Japan K.K. * split x86 specific part - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index ab06dd3f3ae2..a48666f0e2fe 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asid.c: handling ASIDs in SVM. * Copyright (c) 2007, Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883cf..37ad64e60e5d 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * emulate.c: handling SVM emulate instructions help. * Copyright (c) 2005 AMD Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 9525f3559392..807ce82b4861 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * intr.c: Interrupt handling for SVM. * Copyright (c) 2005, AMD Inc. * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 9f5f35f16aff..c5658ae9f131 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * nestedsvm.c: Nested Virtualization * Copyright (c) 2011, Advanced Micro Devices, Inc * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #include diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index fa7325720328..22a7dab03924 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * svm.c: handling SVM architecture-related VM exits * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2005-2007, Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index bce86f0ef706..87a2fe49638a 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * svmdebug.c: debug functions * Copyright (c) 2011, Advanced Micro Devices, Inc. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #include diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e387..b9354e359514 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmcb.c: VMCB management * Copyright (c) 2005-2007, Advanced Micro Devices, Inc. * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #include diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d14..57f599dee4ea 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vlapic.c: virtualize LAPIC for HVM vcpus. * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006 Keir Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e25..38f86530c37d 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * intr.c: handling I/O, interrupts related VMX entry/exit * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2004-2007, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 09edbd23b399..c0b1ae9ba296 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmcs.c: VMCS management * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index ade2a25ce7c2..60a1dd6aca2f 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmx.c: handling VMX architecture-related VM exits * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb0736..5696ba89d113 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vvmx.c: Support virtual VMX for nested virtualization. * @@ -5,18 +6,6 @@ * Author: Qing He * Eddie Dong * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #include diff --git a/xen/arch/x86/hvm/vpt.c b/xen/arch/x86/hvm/vpt.c index 621f5bb88b63..f0a6424d7f36 100644 --- a/xen/arch/x86/hvm/vpt.c +++ b/xen/arch/x86/hvm/vpt.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpt.c: Virtual Platform Timer * * Copyright (c) 2006, Xiaowei Yang, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/altp2m.c b/xen/arch/x86/mm/altp2m.c index 07393befeeed..4077889f204c 100644 --- a/xen/arch/x86/mm/altp2m.c +++ b/xen/arch/x86/mm/altp2m.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Alternate p2m HVM * Copyright (c) 2014, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/guest_walk.c b/xen/arch/x86/mm/hap/guest_walk.c index 1da8d3b99edc..4dd67027e50b 100644 --- a/xen/arch/x86/mm/hap/guest_walk.c +++ b/xen/arch/x86/mm/hap/guest_walk.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * arch/x86/mm/hap/guest_walk.c * * Guest page table walker * Copyright (c) 2007, AMD Corporation (Wei Huang) * Copyright (c) 2007, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/nested_ept.c b/xen/arch/x86/mm/hap/nested_ept.c index 605e47c16cd5..f9a600213444 100644 --- a/xen/arch/x86/mm/hap/nested_ept.c +++ b/xen/arch/x86/mm/hap/nested_ept.c @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * nested_ept.c: Handling virtulized EPT for guest in nested case. * * Copyright (c) 2012, Intel Corporation * Xiantao Zhang - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include #include diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index bb143c6c42c6..f643085d236d 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * ept-p2m.c: use the EPT page table as p2m * Copyright (c) 2007, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #include -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492964.762743 (Exim 4.92) (envelope-from ) id 1pQFu2-0002s0-De; Thu, 09 Feb 2023 23:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492964.762743; Thu, 09 Feb 2023 23:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu2-0002rt-9J; Thu, 09 Feb 2023 23:00:30 +0000 Received: by outflank-mailman (input) for mailman id 492964; Thu, 09 Feb 2023 23:00:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu0-0002rb-Pv for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFtx-0002yz-Ek; Thu, 09 Feb 2023 23:00:25 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFtx-00085P-0T; Thu, 09 Feb 2023 23:00:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=u0XO7zY3xxZkOXNcRsgzmllO1dTZNOs6NIok2T7CJDM=; b=eUsdVF q6weWAjpy7At1kXbkIUaghLBY+1zUGPltCoY4wl2mciafom4ssll8Pd2DikF+JQkwxvKT6muVlPQt I3gk1RzWcz9x/Nu5jT+kKaEodWYbE3V4mmL6KzGsILdUXknEbblAA8mw9+O5Bb2xhLqg3cb+e/W60 Gnlh6JJjPkM=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan Subject: [PATCH 0/6] xen/x86: Use SPDX (take 1) Date: Thu, 9 Feb 2023 23:00:14 +0000 Message-Id: <20230209230020.52695-1-julien@xen.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, This is a first attempt to replace all the full license text with SPX tag in xen/arch/x86/. For now, this is only covering files with GPL 2.0 and 3 different patterns. I have used the script below to remove the full license and add an SPDX tag. The script is based on the work from Anthony [1] 42sh> cat replace_license.py #! /usr/bin/python3 ## We are opening/writing to files using the binary mode to avoid ## python interpreting the content (reading ./drivers/video/font_8x14.c ## will throw some encoding error otherwise). import sys if len(sys.argv) < 4: print("./replace_license [debug]") exit(1) licence_file = sys.argv[1] spdx = str.encode(sys.argv[2]) file = sys.argv[3] # HACK: enable debug if there is a 4th argument debug = len(sys.argv) == 5 with open(licence_file, 'rb') as f: licence = f.read() licence_spdx = b"/* SPDX-License-Identifier: " + spdx + b" */\n" print(f"reading {file}") with open(file, 'rb') as f: whole_file = f.read() try: licence_loc = whole_file.index(licence) except ValueError: print("licence not found. Ignoring") exit(0) # Replace one the below pattern with nothing ## Pattern 1 # * # * whole_file = whole_file.replace(licence + b' *\n', b'') ## Pattern 2 # * # * whole_file = whole_file.replace(b' *\n' + licence, b'') ## Pattern 3 # /* # * # */ whole_file = whole_file.replace(b'/*\n' + licence + b' */\n', b'') ## Pattern 4 # * # * whole_file = whole_file.replace(b' * \n' + licence, b'') if debug: print(whole_file) else: with open('%s' % file, 'wb') as f: f.write(licence_spdx) f.write(whole_file) [1] https://lore.kernel.org/xen-devel/20221103115204.49610-7-anthony.perard@citrix.com/ Julien Grall (6): xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 2) xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 3) xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 3) xen/arch/x86/alternative.c | 14 +------------- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 14 +------------- xen/arch/x86/cpu/mcheck/mce_amd.c | 14 +------------- xen/arch/x86/cpu/mcheck/vmce.c | 14 +------------- xen/arch/x86/cpu/mcheck/x86_mca.h | 14 +------------- xen/arch/x86/cpu/mwait-idle.c | 13 +------------ xen/arch/x86/cpu/vpmu.c | 13 +------------ xen/arch/x86/cpu/vpmu_amd.c | 13 +------------ xen/arch/x86/cpu/vpmu_intel.c | 13 +------------ xen/arch/x86/genapic/x2apic.c | 13 +------------ xen/arch/x86/guest/hyperv/hyperv.c | 14 +------------- xen/arch/x86/guest/hyperv/private.h | 14 +------------- xen/arch/x86/guest/hyperv/tlb.c | 14 +------------- xen/arch/x86/guest/hyperv/util.c | 14 +------------- xen/arch/x86/guest/hypervisor.c | 14 +------------- xen/arch/x86/guest/xen/pvh-boot.c | 14 +------------- xen/arch/x86/guest/xen/xen.c | 14 +------------- xen/arch/x86/hvm/asid.c | 13 +------------ xen/arch/x86/hvm/dm.c | 13 +------------ xen/arch/x86/hvm/dom0_build.c | 13 +------------ xen/arch/x86/hvm/domain.c | 13 +------------ xen/arch/x86/hvm/grant_table.c | 14 +------------- xen/arch/x86/hvm/hpet.c | 13 +------------ xen/arch/x86/hvm/hvm.c | 13 +------------ xen/arch/x86/hvm/hypercall.c | 14 +------------- xen/arch/x86/hvm/intercept.c | 13 +------------ xen/arch/x86/hvm/io.c | 13 +------------ xen/arch/x86/hvm/ioreq.c | 13 +------------ xen/arch/x86/hvm/irq.c | 13 +------------ xen/arch/x86/hvm/mtrr.c | 13 +------------ xen/arch/x86/hvm/nestedhvm.c | 13 +------------ xen/arch/x86/hvm/pmtimer.c | 13 +------------ xen/arch/x86/hvm/quirks.c | 13 +------------ xen/arch/x86/hvm/save.c | 13 +------------ xen/arch/x86/hvm/svm/asid.c | 13 +------------ xen/arch/x86/hvm/svm/emulate.c | 13 +------------ xen/arch/x86/hvm/svm/intr.c | 13 +------------ xen/arch/x86/hvm/svm/nestedsvm.c | 13 +------------ xen/arch/x86/hvm/svm/svm.c | 13 +------------ xen/arch/x86/hvm/svm/svmdebug.c | 13 +------------ xen/arch/x86/hvm/svm/vmcb.c | 13 +------------ xen/arch/x86/hvm/vlapic.c | 13 +------------ xen/arch/x86/hvm/vmx/intr.c | 13 +------------ xen/arch/x86/hvm/vmx/vmcs.c | 13 +------------ xen/arch/x86/hvm/vmx/vmx.c | 13 +------------ xen/arch/x86/hvm/vmx/vvmx.c | 13 +------------ xen/arch/x86/hvm/vpt.c | 13 +------------ xen/arch/x86/hypercall.c | 14 +------------- xen/arch/x86/include/asm/altp2m.h | 13 +------------ xen/arch/x86/include/asm/endbr.h | 14 +------------- xen/arch/x86/include/asm/guest.h | 13 +------------ xen/arch/x86/include/asm/guest/hyperv-hcall.h | 13 +------------ xen/arch/x86/include/asm/guest/hyperv.h | 13 +------------ xen/arch/x86/include/asm/guest/hypervisor.h | 13 +------------ xen/arch/x86/include/asm/guest/pvh-boot.h | 13 +------------ xen/arch/x86/include/asm/guest/xen-hcall.h | 13 +------------ xen/arch/x86/include/asm/guest/xen.h | 13 +------------ xen/arch/x86/include/asm/guest_pt.h | 14 +------------- xen/arch/x86/include/asm/hap.h | 14 +------------- xen/arch/x86/include/asm/hvm/asid.h | 13 +------------ xen/arch/x86/include/asm/hvm/domain.h | 13 +------------ xen/arch/x86/include/asm/hvm/grant_table.h | 13 +------------ xen/arch/x86/include/asm/hvm/hvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/io.h | 13 +------------ xen/arch/x86/include/asm/hvm/ioreq.h | 13 +------------ xen/arch/x86/include/asm/hvm/irq.h | 13 +------------ xen/arch/x86/include/asm/hvm/monitor.h | 13 +------------ xen/arch/x86/include/asm/hvm/nestedhvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/save.h | 13 +------------ xen/arch/x86/include/asm/hvm/support.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/asid.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/emulate.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/intr.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/svm.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 13 +------------ xen/arch/x86/include/asm/hvm/vcpu.h | 13 +------------ xen/arch/x86/include/asm/hvm/vlapic.h | 13 +------------ xen/arch/x86/include/asm/hvm/vm_event.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 13 +------------ xen/arch/x86/include/asm/hvm/vpt.h | 13 +------------ xen/arch/x86/include/asm/iommu.h | 1 + xen/arch/x86/include/asm/ioreq.h | 13 +------------ xen/arch/x86/include/asm/mem_access.h | 14 +------------- xen/arch/x86/include/asm/mem_paging.h | 14 +------------- xen/arch/x86/include/asm/mem_sharing.h | 14 +------------- xen/arch/x86/include/asm/p2m.h | 14 +------------- xen/arch/x86/include/asm/paging.h | 14 +------------- xen/arch/x86/include/asm/pv/domain.h | 13 +------------ xen/arch/x86/include/asm/pv/grant_table.h | 13 +------------ xen/arch/x86/include/asm/pv/mm.h | 13 +------------ xen/arch/x86/include/asm/pv/shim.h | 13 +------------ xen/arch/x86/include/asm/pv/traps.h | 13 +------------ xen/arch/x86/include/asm/shstk.h | 14 +------------- xen/arch/x86/include/asm/spec_ctrl.h | 14 +------------- xen/arch/x86/include/asm/spec_ctrl_asm.h | 14 +------------- xen/arch/x86/include/asm/traps.h | 14 +------------- xen/arch/x86/include/asm/vm_event.h | 13 +------------ xen/arch/x86/include/asm/vpmu.h | 13 +------------ xen/arch/x86/include/asm/xenoprof.h | 14 +------------- xen/arch/x86/mm.c | 14 +------------- xen/arch/x86/mm/altp2m.c | 13 +------------ xen/arch/x86/mm/guest_walk.c | 14 +------------- xen/arch/x86/mm/hap/guest_walk.c | 13 +------------ xen/arch/x86/mm/hap/hap.c | 14 +------------- xen/arch/x86/mm/hap/nested_ept.c | 13 +------------ xen/arch/x86/mm/hap/nested_hap.c | 14 +------------- xen/arch/x86/mm/hap/private.h | 13 +------------ xen/arch/x86/mm/mem_access.c | 14 +------------- xen/arch/x86/mm/mem_paging.c | 14 +------------- xen/arch/x86/mm/mem_sharing.c | 14 +------------- xen/arch/x86/mm/mm-locks.h | 14 +------------- xen/arch/x86/mm/nested.c | 14 +------------- xen/arch/x86/mm/p2m-basic.c | 14 +------------- xen/arch/x86/mm/p2m-ept.c | 13 +------------ xen/arch/x86/mm/p2m-pod.c | 14 +------------- xen/arch/x86/mm/p2m-pt.c | 14 +------------- xen/arch/x86/mm/p2m.c | 14 +------------- xen/arch/x86/mm/p2m.h | 14 +------------- xen/arch/x86/mm/paging.c | 14 +------------- xen/arch/x86/mm/physmap.c | 14 +------------- xen/arch/x86/mm/shadow/common.c | 14 +------------- xen/arch/x86/mm/shadow/hvm.c | 14 +------------- xen/arch/x86/mm/shadow/multi.c | 14 +------------- xen/arch/x86/mm/shadow/multi.h | 14 +------------- xen/arch/x86/mm/shadow/private.h | 14 +------------- xen/arch/x86/mm/shadow/pv.c | 14 +------------- xen/arch/x86/mm/shadow/set.c | 14 +------------- xen/arch/x86/mm/shadow/types.h | 14 +------------- xen/arch/x86/msr.c | 14 +------------- xen/arch/x86/pv/callback.c | 13 +------------ xen/arch/x86/pv/descriptor-tables.c | 13 +------------ xen/arch/x86/pv/emul-gate-op.c | 14 +------------- xen/arch/x86/pv/emul-inv-op.c | 14 +------------- xen/arch/x86/pv/emul-priv-op.c | 14 +------------- xen/arch/x86/pv/emulate.c | 14 +------------- xen/arch/x86/pv/grant_table.c | 13 +------------ xen/arch/x86/pv/hypercall.c | 14 +------------- xen/arch/x86/pv/misc-hypercalls.c | 14 +------------- xen/arch/x86/pv/mm.c | 13 +------------ xen/arch/x86/pv/ro-page-fault.c | 14 +------------- xen/arch/x86/pv/shim.c | 14 +------------- xen/arch/x86/pv/traps.c | 14 +------------- xen/arch/x86/smpboot.c | 14 +------------- xen/arch/x86/spec_ctrl.c | 14 +------------- xen/arch/x86/traps.c | 14 +------------- xen/arch/x86/x86_64/mmconfig.h | 13 +------------ xen/arch/x86/x86_emulate/x86_emulate.c | 14 +------------- xen/arch/x86/x86_emulate/x86_emulate.h | 14 +------------- 152 files changed, 152 insertions(+), 1879 deletions(-) -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492966.762757 (Exim 4.92) (envelope-from ) id 1pQFu3-00033G-4h; Thu, 09 Feb 2023 23:00:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492966.762757; Thu, 09 Feb 2023 23:00:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu2-00031t-S2; Thu, 09 Feb 2023 23:00:30 +0000 Received: by outflank-mailman (input) for mailman id 492966; Thu, 09 Feb 2023 23:00:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu1-0002rn-Gi for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu0-0002z9-Ln; Thu, 09 Feb 2023 23:00:28 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFu0-00085P-B8; Thu, 09 Feb 2023 23:00:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=QoBP6FbuC6DyQyjP3W6Vg4nX2DjQ/IKq+YX7AEDswDA=; b=aElsOwWdCQAktqkGg3RwyDmpiH 0if86kqr1BWDv/5smXDY8zDtjy1eL62DoUdD/mvsw+yVUyVPmCO6/7ScpC4iikk7pgqmc/JIF+3Ml vC96essT3qNBbASva+G+Pyia8Wr9U/yQdo/VHiJA9j5R4Fi62EqScPelkwbugAWxFvQc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan Subject: [PATCH 2/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) Date: Thu, 9 Feb 2023 23:00:16 +0000 Message-Id: <20230209230020.52695-3-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0-pattern-2.txt * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . 42sh> find xen/arch/x86/ -name '*.c' -exec replace_license.py gpl-2.0-pattern-2.txt GPL-2.0 {} \; --- xen/arch/x86/alternative.c | 14 +------------- xen/arch/x86/cpu/mcheck/amd_nonfatal.c | 14 +------------- xen/arch/x86/cpu/mcheck/mce_amd.c | 14 +------------- xen/arch/x86/cpu/mcheck/vmce.c | 14 +------------- xen/arch/x86/guest/hyperv/hyperv.c | 14 +------------- xen/arch/x86/guest/hyperv/tlb.c | 14 +------------- xen/arch/x86/guest/hyperv/util.c | 14 +------------- xen/arch/x86/guest/hypervisor.c | 14 +------------- xen/arch/x86/guest/xen/pvh-boot.c | 14 +------------- xen/arch/x86/guest/xen/xen.c | 14 +------------- xen/arch/x86/hvm/grant_table.c | 14 +------------- xen/arch/x86/hvm/hypercall.c | 14 +------------- xen/arch/x86/hypercall.c | 14 +------------- xen/arch/x86/mm.c | 14 +------------- xen/arch/x86/mm/guest_walk.c | 14 +------------- xen/arch/x86/mm/hap/hap.c | 14 +------------- xen/arch/x86/mm/hap/nested_hap.c | 14 +------------- xen/arch/x86/mm/mem_access.c | 14 +------------- xen/arch/x86/mm/mem_paging.c | 14 +------------- xen/arch/x86/mm/mem_sharing.c | 14 +------------- xen/arch/x86/mm/nested.c | 14 +------------- xen/arch/x86/mm/p2m-basic.c | 14 +------------- xen/arch/x86/mm/p2m-pod.c | 14 +------------- xen/arch/x86/mm/p2m-pt.c | 14 +------------- xen/arch/x86/mm/p2m.c | 14 +------------- xen/arch/x86/mm/paging.c | 14 +------------- xen/arch/x86/mm/physmap.c | 14 +------------- xen/arch/x86/mm/shadow/common.c | 14 +------------- xen/arch/x86/mm/shadow/hvm.c | 14 +------------- xen/arch/x86/mm/shadow/multi.c | 14 +------------- xen/arch/x86/mm/shadow/pv.c | 14 +------------- xen/arch/x86/mm/shadow/set.c | 14 +------------- xen/arch/x86/msr.c | 14 +------------- xen/arch/x86/pv/emul-gate-op.c | 14 +------------- xen/arch/x86/pv/emul-inv-op.c | 14 +------------- xen/arch/x86/pv/emul-priv-op.c | 14 +------------- xen/arch/x86/pv/emulate.c | 14 +------------- xen/arch/x86/pv/hypercall.c | 14 +------------- xen/arch/x86/pv/misc-hypercalls.c | 14 +------------- xen/arch/x86/pv/ro-page-fault.c | 14 +------------- xen/arch/x86/pv/shim.c | 14 +------------- xen/arch/x86/pv/traps.c | 14 +------------- xen/arch/x86/smpboot.c | 14 +------------- xen/arch/x86/spec_ctrl.c | 14 +------------- xen/arch/x86/traps.c | 14 +------------- xen/arch/x86/x86_emulate/x86_emulate.c | 14 +------------- 46 files changed, 46 insertions(+), 598 deletions(-) diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c index 0c6fc7b4fb0c..04c199ff79e4 100644 --- a/xen/arch/x86/alternative.c +++ b/xen/arch/x86/alternative.c @@ -1,18 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * alternative.c - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c index efb45c931e1f..5bd319d1cc92 100644 --- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c +++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * MCA implementation for AMD CPUs * Copyright (c) 2007 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index d7ae8919df77..2bc7d07bb509 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * common MCA implementation for AMD CPUs. * Copyright (c) 2012-2014 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ /* K8 common MCA documentation published at diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c index af30811afd44..a3cb9807a7b5 100644 --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmce.c - provide software emulated vMCE support to guest * * Copyright (C) 2010, 2011 Jiang, Yunhong * Copyright (C) 2012, 2013 Liu, Jinsong - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c index b101ba3080b4..3a1a03e9b2f4 100644 --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/hyperv/hyperv.c * * Support for detecting and running under Hyper-V. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2019 Microsoft. */ #include diff --git a/xen/arch/x86/guest/hyperv/tlb.c b/xen/arch/x86/guest/hyperv/tlb.c index f249b259253d..7c21b889785f 100644 --- a/xen/arch/x86/guest/hyperv/tlb.c +++ b/xen/arch/x86/guest/hyperv/tlb.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/hyperv/tlb.c * * Support for TLB management using hypercalls * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hyperv/util.c b/xen/arch/x86/guest/hyperv/util.c index 2c5f421b7bd9..fb1c09d8615b 100644 --- a/xen/arch/x86/guest/hyperv/util.c +++ b/xen/arch/x86/guest/hyperv/util.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/hyperv/util.c * * Hyper-V utility functions * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c index 366af1d65001..e896c8879856 100644 --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/hypervisor.c * * Support for detecting and running under a hypervisor. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2019 Microsoft. */ #include diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 498625eae0a3..9294aaa5cb01 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/pvh-boot.c * * PVH boot time support * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ #include diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index 9c2defaa6621..9b1bddb12bb6 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/xen.c * * Support for detecting and running under Xen. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ #include diff --git a/xen/arch/x86/hvm/grant_table.c b/xen/arch/x86/hvm/grant_table.c index b7a896ea5855..4a46e9effa6b 100644 --- a/xen/arch/x86/hvm/grant_table.c +++ b/xen/arch/x86/hvm/grant_table.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/hvm/grant_table.c * * Grant table interfaces for HVM guests * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c index 405d0a95afd8..e49e29084168 100644 --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/hvm/hypercall.c * * HVM hypercall dispatching routines * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ #include diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c index 6b73cff9b9ff..42f3d5d6dc46 100644 --- a/xen/arch/x86/hypercall.c +++ b/xen/arch/x86/hypercall.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/hypercall.c * * Common x86 hypercall infrastructure. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2015,2016 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0fe14faa5fa7..039d9e187033 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm.c * * Copyright (c) 2002-2005 K A Fraser * Copyright (c) 2004 Christian Limpach - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c index 76b4e0425887..532eec159a36 100644 --- a/xen/arch/x86/mm/guest_walk.c +++ b/xen/arch/x86/mm/guest_walk.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/guest_walk.c * @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c index 84cb358df123..5cce88fd8123 100644 --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/hap/hap.c * * hardware assisted paging * Copyright (c) 2007 Advanced Micro Devices (Wei Huang) * Parts of this code are Copyright (c) 2007 by XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/hap/nested_hap.c b/xen/arch/x86/mm/hap/nested_hap.c index 098e8e5d4ca9..4b0602cf3c2a 100644 --- a/xen/arch/x86/mm/hap/nested_hap.c +++ b/xen/arch/x86/mm/hap/nested_hap.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/hap/nested_hap.c * * Code for Nested Virtualization * Copyright (c) 2011 Advanced Micro Devices - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index f3aed9fcc966..23930d50771a 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/mem_access.c * @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include /* copy_from_guest() */ diff --git a/xen/arch/x86/mm/mem_paging.c b/xen/arch/x86/mm/mem_paging.c index 01281f786ee0..c1e4508b830c 100644 --- a/xen/arch/x86/mm/mem_paging.c +++ b/xen/arch/x86/mm/mem_paging.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/mem_paging.c * * Memory paging support. * * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp) - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc5444..366f047cd101 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/mem_sharing.c * @@ -5,19 +6,6 @@ * * Copyright (c) 2011 GridCentric, Inc. (Adin Scannell & Andres Lagar-Cavilla) * Copyright (c) 2009 Citrix Systems, Inc. (Grzegorz Milos) - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/nested.c b/xen/arch/x86/mm/nested.c index fab62b2b2dc1..b648f590a0ca 100644 --- a/xen/arch/x86/mm/nested.c +++ b/xen/arch/x86/mm/nested.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/nested.c * @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-basic.c b/xen/arch/x86/mm/p2m-basic.c index 47b780d6d63a..63873e59c9eb 100644 --- a/xen/arch/x86/mm/p2m-basic.c +++ b/xen/arch/x86/mm/p2m-basic.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/p2m-basic.c * @@ -8,19 +9,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index 2edab5e5cd91..c3fcc6058519 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/p2m-pod.c * * Populate-on-demand p2m entries. * * Copyright (c) 2009-2011 Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index cd1af33b6772..38bd6f6f5168 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/p2m-pt.c * @@ -9,19 +10,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index c5561fe22160..d075fe2b662a 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/p2m.c * @@ -8,19 +9,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c index 2991585117a8..c67cb05aae64 100644 --- a/xen/arch/x86/mm/paging.c +++ b/xen/arch/x86/mm/paging.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/paging.c * * x86 specific paging support * Copyright (c) 2007 Advanced Micro Devices (Wei Huang) * Copyright (c) 2007 XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/physmap.c b/xen/arch/x86/mm/physmap.c index 2d267b42f73b..c0cb63aed25a 100644 --- a/xen/arch/x86/mm/physmap.c +++ b/xen/arch/x86/mm/physmap.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/physmap.c * @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index a74b15e3e75b..3a2c0b93dcbd 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/common.c * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index 88c3c16322f2..4741140cb692 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/hvm.c @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 3b06cfaf9a5a..b02c569af34d 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/multi.c * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/pv.c b/xen/arch/x86/mm/shadow/pv.c index ed10d5479c5e..acae2d69aaf0 100644 --- a/xen/arch/x86/mm/shadow/pv.c +++ b/xen/arch/x86/mm/shadow/pv.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/pv.c * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c index bd6c68b547c9..816139aeb8c3 100644 --- a/xen/arch/x86/mm/shadow/set.c +++ b/xen/arch/x86/mm/shadow/set.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/set.c * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #define GUEST_PAGING_LEVELS 0 diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 7ddf0078c3a2..44bc2cf7ef56 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/msr.c * * Policy objects for Model-Specific Registers. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index 758a20ad9df4..aa3e85e023a0 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/emul-gate-op.c * * Emulate gate op for PV guests * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c index 2c07eed9a092..304e3f3a4887 100644 --- a/xen/arch/x86/pv/emul-inv-op.c +++ b/xen/arch/x86/pv/emul-inv-op.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/emul-inv-op.c * * Emulate invalid op for PV guests * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 5da00e24e4ff..ae7ee41d40c7 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/emul-priv-op.c * * Emulate privileged instructions for PV guests * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 0a7907ec5e84..d50c2b42d6f7 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/emulate.c * * Common PV emulation code * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c index 2eedfbfae864..aad1ed4fdb1f 100644 --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/hypercall.c * * PV hypercall dispatching routines * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c index aaaf70eb6330..c2cdbe34a647 100644 --- a/xen/arch/x86/pv/misc-hypercalls.c +++ b/xen/arch/x86/pv/misc-hypercalls.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/misc-hypercalls.c * * Misc hypercall handlers * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index 5963f5ee2d51..7d38d4549b14 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/ro-page-fault.c * @@ -5,19 +6,6 @@ * * Copyright (c) 2002-2005 K A Fraser * Copyright (c) 2004 Christian Limpach - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index ae1a0e6e65af..abcc0c888286 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/shim.c * * Functionaltiy for PV Shim mode * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ #include diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 97fe54b5ee5a..0e1e97ece8c7 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/pv/traps.c * * PV low level entry points. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index b26758c2c89f..9541f4003dac 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * x86 SMP booting functions * * This inherits a great deal from Linux's SMP boot code: * (c) 1995 Alan Cox, Building #3 * (c) 1998, 1999, 2000 Ingo Molnar - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #include diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index a320b81947c8..8038fea377aa 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/spec_ctrl.c * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ #include diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8fa..b2cb46aafe8f 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1,20 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/traps.c * * Modifications to Linux original are copyright (c) 2002-2004, K A Fraser - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ /* diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index e38f98b54726..0f64890519a8 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * x86_emulate.c * @@ -5,19 +6,6 @@ * * Copyright (c) 2005-2007 Keir Fraser * Copyright (c) 2005-2007 XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ /* Operand sizes: 8-bit operands or specified/overridden size. */ -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492969.762790 (Exim 4.92) (envelope-from ) id 1pQFu7-0003tJ-3k; Thu, 09 Feb 2023 23:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492969.762790; Thu, 09 Feb 2023 23:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu6-0003rp-Od; Thu, 09 Feb 2023 23:00:34 +0000 Received: by outflank-mailman (input) for mailman id 492969; Thu, 09 Feb 2023 23:00:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu5-0003dE-80 for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu4-0002zz-SB; Thu, 09 Feb 2023 23:00:32 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFu4-00085P-Kt; Thu, 09 Feb 2023 23:00:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=QGBspIB/BwKX6V8510VRb5qkohNT9oZRupuWADfxJJE=; b=Kayc5UunpXPJgu7VoS08TQ62wD twR91Q4Nm3G4/daA+A1dr9ZmiKQXeLUKiZx2NrpboM+FE77qYXzhcgYL7mJm0bfF0QRuYrbR5go/H LQsrSPJmyALzBt9/FurBaCN7utEUDtSKdNNokPDwefO/eFWZvVDCUqZJOdCFdNGreJqI=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 5/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 3) Date: Thu, 9 Feb 2023 23:00:19 +0000 Message-Id: <20230209230020.52695-6-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.c: * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0-pattern-3.txt * This program is free software; you can redistribute it and/or * modify it under the terms and conditions of the GNU General Public * License, version 2, as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public * License along with this program; If not, see . 42sh> find xen/arch/x86/ -name '*.c' -exec replace_license.py gpl-2.0-pattern-3.txt GPL-2.0 {} \; --- xen/arch/x86/hvm/dom0_build.c | 13 +------------ xen/arch/x86/hvm/domain.c | 13 +------------ xen/arch/x86/pv/callback.c | 13 +------------ xen/arch/x86/pv/descriptor-tables.c | 13 +------------ xen/arch/x86/pv/grant_table.c | 13 +------------ xen/arch/x86/pv/mm.c | 13 +------------ 6 files changed, 6 insertions(+), 72 deletions(-) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 3ac6b7b423b1..d5be115e90c9 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm/dom0_build.c * * Dom0 builder for PVH guest. * * Copyright (C) 2017 Citrix Systems R&D - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c index 10e30175a1b6..282784572ad6 100644 --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * HVM domain specific functions. * * Copyright (C) 2017 Citrix Systems R&D - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c index 067ee3b795d0..5db0dd4226d2 100644 --- a/xen/arch/x86/pv/callback.c +++ b/xen/arch/x86/pv/callback.c @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * pv/callback.c * * hypercall handles and helper functions for guest callback - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/descriptor-tables.c b/xen/arch/x86/pv/descriptor-tables.c index b4135b450cdf..9002c262a1fb 100644 --- a/xen/arch/x86/pv/descriptor-tables.c +++ b/xen/arch/x86/pv/descriptor-tables.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * arch/x86/pv/descriptor-tables.c * @@ -5,18 +6,6 @@ * * Copyright (c) 2002-2005 K A Fraser * Copyright (c) 2004 Christian Limpach - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/grant_table.c b/xen/arch/x86/pv/grant_table.c index 81c72e61ed55..910c50141278 100644 --- a/xen/arch/x86/pv/grant_table.c +++ b/xen/arch/x86/pv/grant_table.c @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * pv/grant_table.c * * Grant table interfaces for PV guests * * Copyright (C) 2017 Wei Liu - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include diff --git a/xen/arch/x86/pv/mm.c b/xen/arch/x86/pv/mm.c index 5ed7b3ccdbf2..69d746be6e8a 100644 --- a/xen/arch/x86/pv/mm.c +++ b/xen/arch/x86/pv/mm.c @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * pv/mm.c * @@ -5,18 +6,6 @@ * * Copyright (c) 2002-2005 K A Fraser * Copyright (c) 2004 Christian Limpach - * - * This program is free software; you can redistribute it and/or - * modify it under the terms and conditions of the GNU General Public - * License, version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public - * License along with this program; If not, see . */ #include -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492967.762776 (Exim 4.92) (envelope-from ) id 1pQFu5-0003e7-UL; Thu, 09 Feb 2023 23:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492967.762776; Thu, 09 Feb 2023 23:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu5-0003dp-Qz; Thu, 09 Feb 2023 23:00:33 +0000 Received: by outflank-mailman (input) for mailman id 492967; Thu, 09 Feb 2023 23:00:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu4-0003Z9-BM for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu2-0002zT-EM; Thu, 09 Feb 2023 23:00:30 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFu2-00085P-6V; Thu, 09 Feb 2023 23:00:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=UaeXAyK9G+d6uKBLeX0Ry/BqypqCs7yld6AbDMZh2nY=; b=23o7qg/+CRZJ591D00CzlQ5hxI nqaS1++g8bII0fn6+fb5eeeLE6VQPR0dn1bAPusVBtVrqoiO7wkW3F5V7w+Dq3fS/B+2wCcX6FHVt FijU5UnYPYjOKFGiuk4mr2pTWBLFH12GKLy0GbuxmSR+4WaLncjn9Qu/N1vFkuEwnrqk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Jun Nakajima , Kevin Tian , George Dunlap Subject: [PATCH 3/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h Date: Thu, 9 Feb 2023 23:00:17 +0000 Message-Id: <20230209230020.52695-4-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0.txt * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; If not, see . 42sh> find xen/arch/x86/ -name '*.h' -exec replace_license.py gpl-2.0.txt GPL-2.0 {} \; --- xen/arch/x86/include/asm/altp2m.h | 13 +------------ xen/arch/x86/include/asm/hvm/asid.h | 13 +------------ xen/arch/x86/include/asm/hvm/domain.h | 13 +------------ xen/arch/x86/include/asm/hvm/hvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/io.h | 13 +------------ xen/arch/x86/include/asm/hvm/ioreq.h | 13 +------------ xen/arch/x86/include/asm/hvm/irq.h | 13 +------------ xen/arch/x86/include/asm/hvm/monitor.h | 13 +------------ xen/arch/x86/include/asm/hvm/nestedhvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/save.h | 13 +------------ xen/arch/x86/include/asm/hvm/support.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/asid.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/emulate.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/intr.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/svm.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 13 +------------ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 13 +------------ xen/arch/x86/include/asm/hvm/vcpu.h | 13 +------------ xen/arch/x86/include/asm/hvm/vlapic.h | 13 +------------ xen/arch/x86/include/asm/hvm/vm_event.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 13 +------------ xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 13 +------------ xen/arch/x86/include/asm/hvm/vpt.h | 13 +------------ xen/arch/x86/include/asm/iommu.h | 1 + xen/arch/x86/include/asm/ioreq.h | 13 +------------ xen/arch/x86/include/asm/vm_event.h | 13 +------------ xen/arch/x86/include/asm/vpmu.h | 13 +------------ xen/arch/x86/mm/hap/private.h | 13 +------------ xen/arch/x86/x86_64/mmconfig.h | 13 +------------ 31 files changed, 31 insertions(+), 360 deletions(-) diff --git a/xen/arch/x86/include/asm/altp2m.h b/xen/arch/x86/include/asm/altp2m.h index b206e95863a6..a2b2bc02f2f5 100644 --- a/xen/arch/x86/include/asm/altp2m.h +++ b/xen/arch/x86/include/asm/altp2m.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Alternate p2m HVM * Copyright (c) 2014, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_ALTP2M_H diff --git a/xen/arch/x86/include/asm/hvm/asid.h b/xen/arch/x86/include/asm/hvm/asid.h index 633ddb72e494..ed6a5e760ce0 100644 --- a/xen/arch/x86/include/asm/hvm/asid.h +++ b/xen/arch/x86/include/asm/hvm/asid.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asid.h: ASID management * Copyright (c) 2007, Advanced Micro Devices, Inc. * Copyright (c) 2009, Citrix Systems, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444ea8..a3482c170668 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * domain.h: HVM per domain definitions * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2005, International Business Machines Corporation - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_DOMAIN_H__ diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 65768c797ea7..108682aafe92 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm.h: Hardware virtual machine assist interface definitions. * * Leendert van Doorn, leendert@watson.ibm.com * Copyright (c) 2005, International Business Machines Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_HVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/io.h b/xen/arch/x86/include/asm/hvm/io.h index 54e0161b492c..554c31b01fab 100644 --- a/xen/arch/x86/include/asm/hvm/io.h +++ b/xen/arch/x86/include/asm/hvm/io.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * io.h: HVM IO support * * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_IO_H__ diff --git a/xen/arch/x86/include/asm/hvm/ioreq.h b/xen/arch/x86/include/asm/hvm/ioreq.h index 9b2eb6fedf99..bf76189d8e13 100644 --- a/xen/arch/x86/include/asm/hvm/ioreq.h +++ b/xen/arch/x86/include/asm/hvm/ioreq.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm.h: Hardware virtual machine assist interface definitions. * * Copyright (c) 2016 Citrix Systems Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/irq.h b/xen/arch/x86/include/asm/hvm/irq.h index c4369ceb7aaa..e0c33f2fe7d5 100644 --- a/xen/arch/x86/include/asm/hvm/irq.h +++ b/xen/arch/x86/include/asm/hvm/irq.h @@ -1,21 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * irq.h * * Interrupt distribution and delivery logic. * * Copyright (c) 2006, K A Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_IRQ_H__ diff --git a/xen/arch/x86/include/asm/hvm/monitor.h b/xen/arch/x86/include/asm/hvm/monitor.h index 639f6dfa374c..7077cd9da64e 100644 --- a/xen/arch/x86/include/asm/hvm/monitor.h +++ b/xen/arch/x86/include/asm/hvm/monitor.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * include/asm-x86/hvm/monitor.h * * Arch-specific hardware virtual machine monitor abstractions. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_MONITOR_H__ diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h index 7184928c2bb1..7b827f0245af 100644 --- a/xen/arch/x86/include/asm/hvm/nestedhvm.h +++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Nested HVM * Copyright (c) 2011, Advanced Micro Devices, Inc. * Author: Christoph Egger - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef _HVM_NESTEDHVM_H diff --git a/xen/arch/x86/include/asm/hvm/save.h b/xen/arch/x86/include/asm/hvm/save.h index e975011ddb71..be4a5b4e41ef 100644 --- a/xen/arch/x86/include/asm/hvm/save.h +++ b/xen/arch/x86/include/asm/hvm/save.h @@ -1,17 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * save.h: HVM support routines for save/restore - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __XEN_HVM_SAVE_H__ diff --git a/xen/arch/x86/include/asm/hvm/support.h b/xen/arch/x86/include/asm/hvm/support.h index 6b583738ecb5..8c0dc11f4d20 100644 --- a/xen/arch/x86/include/asm/hvm/support.h +++ b/xen/arch/x86/include/asm/hvm/support.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * support.h: HVM support routines used by VT-x and SVM. * * Leendert van Doorn, leendert@watson.ibm.com * Copyright (c) 2005, International Business Machines Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_SUPPORT_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h index 0e5ec3ab788a..8e5323f3417b 100644 --- a/xen/arch/x86/include/asm/hvm/svm/asid.h +++ b/xen/arch/x86/include/asm/hvm/svm/asid.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * asid.h: handling ASIDs in SVM. * Copyright (c) 2007, Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_ASID_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/include/asm/hvm/svm/emulate.h index eb1a8c24af6d..81866f970b3b 100644 --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h +++ b/xen/arch/x86/include/asm/hvm/svm/emulate.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * emulate.h: SVM instruction emulation bits. * Copyright (c) 2005, AMD Corporation. * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_SVM_EMULATE_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/intr.h b/xen/arch/x86/include/asm/hvm/svm/intr.h index ae52d9f948b1..d8548876fdd1 100644 --- a/xen/arch/x86/include/asm/hvm/svm/intr.h +++ b/xen/arch/x86/include/asm/hvm/svm/intr.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * intr.h: SVM Architecture related definitions * Copyright (c) 2005, AMD Corporation. * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_SVM_INTR_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 656d7d1a9a71..c84a9ae9eed3 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * nestedsvm.h: Nested Virtualization * Copyright (c) 2011, Advanced Micro Devices, Inc * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_SVM_NESTEDSVM_H__ #define __ASM_X86_HVM_SVM_NESTEDSVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59b7..e9facc1e41ae 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * svm.h: SVM Architecture related definitions * Copyright (c) 2005, AMD Corporation. * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_SVM_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h index 330c1d91aad5..6c3dbbecada8 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h +++ b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * svmdebug.h: SVM related debug defintions * Copyright (c) 2011, AMD Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_SVM_SVMDEBUG_H__ diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index e87728fa81cd..f3737ae50784 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmcb.h: VMCB related definitions * Copyright (c) 2005-2007, Advanced Micro Devices, Inc * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_SVM_VMCB_H__ #define __ASM_X86_HVM_SVM_VMCB_H__ diff --git a/xen/arch/x86/include/asm/hvm/vcpu.h b/xen/arch/x86/include/asm/hvm/vcpu.h index 8adf4555c2ab..9a73cec688c3 100644 --- a/xen/arch/x86/include/asm/hvm/vcpu.h +++ b/xen/arch/x86/include/asm/hvm/vcpu.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vcpu.h: HVM per vcpu definitions * * Copyright (c) 2005, International Business Machines Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_VCPU_H__ diff --git a/xen/arch/x86/include/asm/hvm/vlapic.h b/xen/arch/x86/include/asm/hvm/vlapic.h index 8f908928c35c..729eeca11009 100644 --- a/xen/arch/x86/include/asm/hvm/vlapic.h +++ b/xen/arch/x86/include/asm/hvm/vlapic.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * hvm_vlapic.h: virtualize LAPIC definitions. * * Copyright (c) 2004, Intel Corporation. * Copyright (c) 2006 Keir Fraser, XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_VLAPIC_H__ diff --git a/xen/arch/x86/include/asm/hvm/vm_event.h b/xen/arch/x86/include/asm/hvm/vm_event.h index 28cb07ce8ff6..e5c64334fa52 100644 --- a/xen/arch/x86/include/asm/hvm/vm_event.h +++ b/xen/arch/x86/include/asm/hvm/vm_event.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * include/asm-x86/hvm/vm_event.h * * Hardware virtual machine vm_event abstractions. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e7447805..a7b0623295d3 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmcs.h: VMCS related definitions * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_VMX_VMCS_H__ #define __ASM_X86_HVM_VMX_VMCS_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f445..b8cf14795f46 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vmx.h: VMX Architecture related definitions * Copyright (c) 2004, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_VMX_VMX_H__ #define __ASM_X86_HVM_VMX_VMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h index 2c3adb5dd6b3..6bb0c778c583 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vvmx.h: Support virtual VMX for nested virtualization. @@ -6,18 +7,6 @@ * Author: Qing He * Eddie Dong * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __ASM_X86_HVM_VVMX_H__ #define __ASM_X86_HVM_VVMX_H__ diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h index 74c0cedd11cc..c0e1380076a7 100644 --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpt.h: Virtual Platform Timer definitions * * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_HVM_VPT_H__ diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h index fc0afe35bf6b..8e1e0ad9ee18 100644 --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, diff --git a/xen/arch/x86/include/asm/ioreq.h b/xen/arch/x86/include/asm/ioreq.h index d06ce9a6ea56..3a3b5923485c 100644 --- a/xen/arch/x86/include/asm/ioreq.h +++ b/xen/arch/x86/include/asm/ioreq.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * ioreq.h: Hardware virtual machine assist interface definitions. * @@ -5,18 +6,6 @@ * from the common code. * * Copyright (c) 2016 Citrix Systems Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_IOREQ_H__ diff --git a/xen/arch/x86/include/asm/vm_event.h b/xen/arch/x86/include/asm/vm_event.h index 075612407523..2434446a7c75 100644 --- a/xen/arch/x86/include/asm/vm_event.h +++ b/xen/arch/x86/include/asm/vm_event.h @@ -1,19 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vm_event.h: architecture specific vm_event handling routines * * Copyright (c) 2015 Tamas K Lengyel (tamas@tklengyel.com) - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ #ifndef __ASM_X86_VM_EVENT_H__ diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index 05e1fbfccfcf..bdf2f9dd0473 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * vpmu.h: PMU virtualization for HVM domain. * * Copyright (c) 2007, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * * Author: Haitao Shan */ diff --git a/xen/arch/x86/mm/hap/private.h b/xen/arch/x86/mm/hap/private.h index 1040eaf69f43..4442a0daf103 100644 --- a/xen/arch/x86/mm/hap/private.h +++ b/xen/arch/x86/mm/hap/private.h @@ -1,20 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * arch/x86/mm/hap/private.h * * Copyright (c) 2007, AMD Corporation (Wei Huang) * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * */ #ifndef __HAP_PRIVATE_H__ #define __HAP_PRIVATE_H__ diff --git a/xen/arch/x86/x86_64/mmconfig.h b/xen/arch/x86/x86_64/mmconfig.h index 433046be663a..671cd4cfea37 100644 --- a/xen/arch/x86/x86_64/mmconfig.h +++ b/xen/arch/x86/x86_64/mmconfig.h @@ -1,18 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2006, Intel Corporation. * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * * Author: Allen Kay - adapted from linux */ -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.492968.762783 (Exim 4.92) (envelope-from ) id 1pQFu6-0003hs-EC; Thu, 09 Feb 2023 23:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492968.762783; Thu, 09 Feb 2023 23:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu6-0003h7-58; Thu, 09 Feb 2023 23:00:34 +0000 Received: by outflank-mailman (input) for mailman id 492968; Thu, 09 Feb 2023 23:00:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu4-0003cJ-Nc for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 23:00:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQFu3-0002zd-Pt; Thu, 09 Feb 2023 23:00:31 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQFu3-00085P-IU; Thu, 09 Feb 2023 23:00:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=MrRIIHWAZk7Sn1zkqMOz+M0nmfhsUTbnBLesFNoF668=; b=LBZA2klrN/u3jnUNSKU65Bm4jJ EW28C8UNxq5DaBRsfx3slTtObcMWCTnPUspdnMbMPUanulwVCA8XC2Mk+fldnq2+gn80KspDoCoTE yyODpipUO9kIRwVcd2odl3itv3iSOf3BLQpRUPWVNVj3R7cxUHdHtpZTxR6IDwDEH1Cw=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , George Dunlap , Tim Deegan Subject: [PATCH 4/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 2) Date: Thu, 9 Feb 2023 23:00:18 +0000 Message-Id: <20230209230020.52695-5-julien@xen.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209230020.52695-1-julien@xen.org> References: <20230209230020.52695-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall It is easier to understand the license of a file when using SPDX. This is replacing the below pattern with the SPDX tag GPL-2.0 in xen/arch/x86/*.h: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . Signed-off-by: Julien Grall ---- 42sh> cat gpl-2.0-pattern-2.txt * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; If not, see . 42sh> find xen/arch/x86/ -name '*.h' -exec replace_license.py gpl-2.0-pattern-2.txt GPL-2.0 {} \; --- xen/arch/x86/cpu/mcheck/x86_mca.h | 14 +------------- xen/arch/x86/guest/hyperv/private.h | 14 +------------- xen/arch/x86/include/asm/endbr.h | 14 +------------- xen/arch/x86/include/asm/guest_pt.h | 14 +------------- xen/arch/x86/include/asm/hap.h | 14 +------------- xen/arch/x86/include/asm/mem_access.h | 14 +------------- xen/arch/x86/include/asm/mem_paging.h | 14 +------------- xen/arch/x86/include/asm/mem_sharing.h | 14 +------------- xen/arch/x86/include/asm/p2m.h | 14 +------------- xen/arch/x86/include/asm/paging.h | 14 +------------- xen/arch/x86/include/asm/shstk.h | 14 +------------- xen/arch/x86/include/asm/spec_ctrl.h | 14 +------------- xen/arch/x86/include/asm/spec_ctrl_asm.h | 14 +------------- xen/arch/x86/include/asm/traps.h | 14 +------------- xen/arch/x86/include/asm/xenoprof.h | 14 +------------- xen/arch/x86/mm/mm-locks.h | 14 +------------- xen/arch/x86/mm/p2m.h | 14 +------------- xen/arch/x86/mm/shadow/multi.h | 14 +------------- xen/arch/x86/mm/shadow/private.h | 14 +------------- xen/arch/x86/mm/shadow/types.h | 14 +------------- xen/arch/x86/x86_emulate/x86_emulate.h | 14 +------------- 21 files changed, 21 insertions(+), 273 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/x86_mca.h b/xen/arch/x86/cpu/mcheck/x86_mca.h index 8f7fced0fee0..81cabc9ddb97 100644 --- a/xen/arch/x86/cpu/mcheck/x86_mca.h +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * MCA implementation for AMD CPUs * Copyright (c) 2007-2012 Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef X86_MCA_H diff --git a/xen/arch/x86/guest/hyperv/private.h b/xen/arch/x86/guest/hyperv/private.h index fea3e291e944..f768f647d877 100644 --- a/xen/arch/x86/guest/hyperv/private.h +++ b/xen/arch/x86/guest/hyperv/private.h @@ -1,21 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/guest/hyperv/private.h * * Definitions / declarations only useful to Hyper-V code. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2020 Microsoft. */ diff --git a/xen/arch/x86/include/asm/endbr.h b/xen/arch/x86/include/asm/endbr.h index d946fac13130..80a53187782c 100644 --- a/xen/arch/x86/include/asm/endbr.h +++ b/xen/arch/x86/include/asm/endbr.h @@ -1,17 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2021-2022 Citrix Systems Ltd. */ #ifndef XEN_ASM_ENDBR_H diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index 6802db2a415a..2afaf20a775c 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * xen/asm-x86/guest_pt.h * @@ -10,19 +11,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_ASM_GUEST_PT_H diff --git a/xen/arch/x86/include/asm/hap.h b/xen/arch/x86/include/asm/hap.h index 90dece29deca..5de40d599ca4 100644 --- a/xen/arch/x86/include/asm/hap.h +++ b/xen/arch/x86/include/asm/hap.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/hap.h * @@ -7,19 +8,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_HAP_H diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h index 18091610aea0..9584ae2260a2 100644 --- a/xen/arch/x86/include/asm/mem_access.h +++ b/xen/arch/x86/include/asm/mem_access.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/mem_access.h * @@ -8,19 +9,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_ACCESS_H__ diff --git a/xen/arch/x86/include/asm/mem_paging.h b/xen/arch/x86/include/asm/mem_paging.h index d3635e96cffc..04e17b827fce 100644 --- a/xen/arch/x86/include/asm/mem_paging.h +++ b/xen/arch/x86/include/asm/mem_paging.h @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/mem_paging.h * * Memory paging support. * * Copyright (c) 2009 Citrix Systems, Inc. (Patrick Colp) - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef __ASM_X86_MEM_PAGING_H__ diff --git a/xen/arch/x86/include/asm/mem_sharing.h b/xen/arch/x86/include/asm/mem_sharing.h index 2c00069bc91c..c072953c6c0b 100644 --- a/xen/arch/x86/include/asm/mem_sharing.h +++ b/xen/arch/x86/include/asm/mem_sharing.h @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/mem_sharing.h * * Memory sharing support. * * Copyright (c) 2009 Citrix Systems, Inc. (Grzegorz Milos) - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef __MEM_SHARING_H__ #define __MEM_SHARING_H__ diff --git a/xen/arch/x86/include/asm/p2m.h b/xen/arch/x86/include/asm/p2m.h index bd684d02f367..f72dd62064f0 100644 --- a/xen/arch/x86/include/asm/p2m.h +++ b/xen/arch/x86/include/asm/p2m.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/paging.h * @@ -8,19 +9,6 @@ * Parts of this code are Copyright (c) 2006-2007 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_ASM_X86_P2M_H diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h index 8c0b0ef29a10..dab2ad598cc3 100644 --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/paging.h * @@ -6,19 +7,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_PAGING_H diff --git a/xen/arch/x86/include/asm/shstk.h b/xen/arch/x86/include/asm/shstk.h index fdc9cc65a3fa..21eed6c2fb0c 100644 --- a/xen/arch/x86/include/asm/shstk.h +++ b/xen/arch/x86/include/asm/shstk.h @@ -1,17 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2022 Citrix Systems Ltd. */ #ifndef XEN_ASM_SHSTK_H diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index e928596450f7..847e0659f67a 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/spec_ctrl.h * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532b..5239f274369e 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * include/asm-x86/spec_ctrl.h * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . - * * Copyright (c) 2017-2018 Citrix Systems Ltd. */ diff --git a/xen/arch/x86/include/asm/traps.h b/xen/arch/x86/include/asm/traps.h index b0dd2d24614d..99585d091931 100644 --- a/xen/arch/x86/include/asm/traps.h +++ b/xen/arch/x86/include/asm/traps.h @@ -1,19 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2007, 2008 Advanced Micro Devices, Inc. * Author: Christoph Egger - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef ASM_TRAP_H diff --git a/xen/arch/x86/include/asm/xenoprof.h b/xen/arch/x86/include/asm/xenoprof.h index cf6af8c5df52..bef9d5278634 100644 --- a/xen/arch/x86/include/asm/xenoprof.h +++ b/xen/arch/x86/include/asm/xenoprof.h @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * asm-x86/xenoprof.h * xenoprof x86 arch specific header file * * Copyright (c) 2006 Isaku Yamahata * VA Linux Systems Japan K.K. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef __ASM_X86_XENOPROF_H__ diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h index c1523aeccf99..a8df7fc0530f 100644 --- a/xen/arch/x86/mm/mm-locks.h +++ b/xen/arch/x86/mm/mm-locks.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/mm-locks.h * @@ -7,19 +8,6 @@ * Copyright (c) 2007 Advanced Micro Devices (Wei Huang) * Copyright (c) 2006-2007 XenSource Inc. * Copyright (c) 2006 Michael A Fetterman - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _MM_LOCKS_H diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h index cc0f6766e4df..261cf6f7aeec 100644 --- a/xen/arch/x86/mm/p2m.h +++ b/xen/arch/x86/mm/p2m.h @@ -1,18 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/p2m.h - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ struct p2m_domain *p2m_init_one(struct domain *d); diff --git a/xen/arch/x86/mm/shadow/multi.h b/xen/arch/x86/mm/shadow/multi.h index 5bcd6ae1a8da..77e71299f02c 100644 --- a/xen/arch/x86/mm/shadow/multi.h +++ b/xen/arch/x86/mm/shadow/multi.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/multi.h * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ extern int diff --git a/xen/arch/x86/mm/shadow/private.h b/xen/arch/x86/mm/shadow/private.h index 79d82364fc92..257befe30ada 100644 --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/private.h * @@ -5,19 +6,6 @@ * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_SHADOW_PRIVATE_H diff --git a/xen/arch/x86/mm/shadow/types.h b/xen/arch/x86/mm/shadow/types.h index fac59522b008..afe0180d6298 100644 --- a/xen/arch/x86/mm/shadow/types.h +++ b/xen/arch/x86/mm/shadow/types.h @@ -1,22 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * arch/x86/mm/shadow/types.h * * Parts of this code are Copyright (c) 2006 by XenSource Inc. * Parts of this code are Copyright (c) 2006 by Michael A Fetterman * Parts based on earlier work by Michael A Fetterman, Ian Pratt et al. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef _XEN_SHADOW_TYPES_H diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index bb7af967ffee..324cb5607ad4 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /****************************************************************************** * x86_emulate.h * @@ -5,19 +6,6 @@ * * Copyright (c) 2005-2007 Keir Fraser * Copyright (c) 2005-2007 XenSource Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; If not, see . */ #ifndef __X86_EMULATE_H__ -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 09 23:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 09 Feb 2023 23:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493017.762820 (Exim 4.92) (envelope-from ) id 1pQG2m-0007LV-JZ; Thu, 09 Feb 2023 23:09:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493017.762820; Thu, 09 Feb 2023 23:09:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQG2m-0007LO-Fx; Thu, 09 Feb 2023 23:09:32 +0000 Received: by outflank-mailman (input) for mailman id 493017; Thu, 09 Feb 2023 23:09:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQG2l-0007LE-Bh; Thu, 09 Feb 2023 23:09:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQG2l-0003A9-4M; Thu, 09 Feb 2023 23:09:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQG2k-00017b-UL; Thu, 09 Feb 2023 23:09:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQG2k-0000oy-Tq; Thu, 09 Feb 2023 23:09:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wxpzGGWvqvBKb0MP8w/Hzf+LMRCDJSFFdyu1weBksOU=; b=jE1KoU0xHN1puYsJKAzWDt2eGa QA33puNbWwBo593H0sCqAmAtPkB9hrcVJC0K4vNadoL5Pi7Cko263cuHStXfFzGl6pY5qRg1FbkBH aD1Hl6SZqZObJ7zTpj4ZrQX1BnTti/79S3ucL0DTONSieIBsL+YqpZLPFYNGiD3SusUg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176764: all pass - PUSHED X-Osstest-Versions-This: ovmf=289d93b79c18f42b9dd09770a22d15a11fd40670 X-Osstest-Versions-That: ovmf=f6ce1a5cd8932844ec24701d158254ccf75b6159 From: osstest service owner Date: Thu, 09 Feb 2023 23:09:30 +0000 flight 176764 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176764/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 289d93b79c18f42b9dd09770a22d15a11fd40670 baseline version: ovmf f6ce1a5cd8932844ec24701d158254ccf75b6159 Last test of basis 176694 2023-02-09 02:10:40 Z 0 days Testing same since 176764 2023-02-09 17:42:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Girish Mahadevan Rebecca Cran Rebecca Cran jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f6ce1a5cd8..289d93b79c 289d93b79c18f42b9dd09770a22d15a11fd40670 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 10 01:39:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 01:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493026.762831 (Exim 4.92) (envelope-from ) id 1pQINE-0006xX-Mm; Fri, 10 Feb 2023 01:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493026.762831; Fri, 10 Feb 2023 01:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQINE-0006x9-Gs; Fri, 10 Feb 2023 01:38:48 +0000 Received: by outflank-mailman (input) for mailman id 493026; Fri, 10 Feb 2023 01:38:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQINC-0006wx-NX; Fri, 10 Feb 2023 01:38:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQINC-0005Qw-C3; Fri, 10 Feb 2023 01:38:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQINB-0002qw-Qo; Fri, 10 Feb 2023 01:38:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQINB-0004Ic-P0; Fri, 10 Feb 2023 01:38:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ajV6BI1AUDwHxOTkgpcswrjiYSFXFvlthP8VAVd8gy8=; b=mzjghI2alV+0fdBQR2G02aHqef S0rjlsU8zWLmPVAAebn6RJ+Rz5m2408bpWmZNoy1U/V2Mw00i5y+8D0zZWR5C/BhNnGf792FdkGKr FS4oEjlGoBSk/1XZutD/JukF0jJw+Fi7RsLBOewWu++475ai8kxfVr9XO7kespO02Al8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176756: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-pair:xen-install/dst_host:fail:regression xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=587823eca162d063027faf1826ec3544f0a06e78 X-Osstest-Versions-That: xen=3dae50283d9819c691a97f15b133124c00d39a2f From: osstest service owner Date: Fri, 10 Feb 2023 01:38:45 +0000 flight 176756 xen-4.17-testing real [real] flight 176796 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176756/ http://logs.test-lab.xenproject.org/osstest/logs/176796/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 176459 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176459 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a version targeted for testing: xen 587823eca162d063027faf1826ec3544f0a06e78 baseline version: xen 3dae50283d9819c691a97f15b133124c00d39a2f Last test of basis 176459 2023-02-07 16:39:55 Z 2 days Testing same since 176756 2023-02-09 16:07:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Edwin Török Pau Ruiz Safont jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 587823eca162d063027faf1826ec3544f0a06e78 Author: Andrew Cooper Date: Wed Feb 1 11:27:42 2023 +0000 tools/ocaml/libs: Fix memory/resource leaks with caml_alloc_custom() All caml_alloc_*() functions can throw exceptions, and longjump out of context. If this happens, we leak the xch/xce handle. Reorder the logic to allocate the the Ocaml object first. Fixes: 8b3c06a3e545 ("tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free") Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit d69ccf52ad467ccc22029172a8e61dc621187889) commit bf935b1ff7cc76b2d25f877e56a359afaafcac1f Author: Andrew Cooper Date: Tue Jan 31 17:19:30 2023 +0000 tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock released The intf->{addr,len} references in the xc_map_foreign_range() call are unsafe. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called, the C code must not access any OCaml data, nor call any function of the run-time system, nor call back into OCaml code." More than what the manual says, the intf pointer is (potentially) invalidated by caml_enter_blocking_section() if another thread happens to perform garbage collection at just the right (wrong) moment. Rewrite the logic. There's no need to stash data in the Ocaml object until the success path at the very end. Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 9e7c74e6f9fd2e44df1212643b80af9032b45b07) commit afdcc108566e5a4ee352b6427c98ebad6885a81d Author: Edwin Török Date: Thu Jan 12 11:38:38 2023 +0000 tools/ocaml/xc: Fix binding for xc_domain_assign_device() The patch adding this binding was plain broken, and unreviewed. It modified the C stub to add a 4th parameter without an equivalent adjustment in the Ocaml side of the bindings. In 64bit builds, this causes us to dereference whatever dead value is in %rcx when trying to interpret the rflags parameter. This has gone unnoticed because Xapi doesn't use this binding (it has its own), but unbreak the binding by passing RDM_RELAXED unconditionally for now (matching the libxl default behaviour). Fixes: 9b34056cb4 ("tools: extend xc_assign_device() to support rdm reservation policy") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 4250683842104f02996428f93927a035c8e19266) commit 021b82cc0c71ba592439f175c1ededa800b172a9 Author: Edwin Török Date: Thu Jan 12 17:48:29 2023 +0000 tools/ocaml/evtchn: Don't reference Custom objects with the GC lock released The modification to the _H() macro for Ocaml 5 support introduced a subtle bug. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called, the C code must not access any OCaml data, nor call any function of the run-time system, nor call back into OCaml code." Previously, the value was a naked C pointer, so dereferencing it wasn't "accessing any Ocaml data", but the fix to avoid naked C pointers added a layer of indirection through an Ocaml Custom object, meaning that the common pattern of using _H() in a blocking section is unsafe. In order to fix: * Drop the _H() macro and replace it with a static inline xce_of_val(). * Opencode the assignment into Data_custom_val() in the two constructors. * Rename "value xce" parameters to "value xce_val" so we can consistently have "xenevtchn_handle *xce" on the stack, and obtain the pointer with the GC lock still held. Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 2636d8ff7a670c4d2485757dbe966e36c259a960) commit 5797b798a542a7e5be34698463152cb92f18776f Author: Andrew Cooper Date: Tue Jan 31 10:59:42 2023 +0000 tools/ocaml/libs: Allocate the correct amount of memory for Abstract_tag caml_alloc() takes units of Wsize (word size), not bytes. As a consequence, we're allocating 4 or 8 times too much memory. Ocaml has a helper, Wsize_bsize(), but it truncates cases which aren't an exact multiple. Use a BUILD_BUG_ON() to cover the potential for truncation, as there's no rounding-up form of the helper. Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Fixes: d3e649277a13 ("ocaml: add mmap bindings implementation.") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 36eb2de31b6ecb8787698fb1a701bd708c8971b2) commit 2c21e1bee6d62cbd523069e839086addf35da9f2 Author: Edwin Török Date: Thu Jan 12 11:28:29 2023 +0000 tools/ocaml/libs: Don't declare stubs as taking void There is no such thing as an Ocaml function (C stub or otherwise) taking no parameters. In the absence of any other parameters, unit is still passed. This doesn't explode with any ABI we care about, but would malfunction for an ABI environment such as stdcall. Fixes: c3afd398ba7f ("ocaml: Add XS bindings.") Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit ff8b560be80b9211c303d74df7e4b3921d2bb8ca) commit e74d868b48d55dfb20f5a41ec20fbec93d8e5deb Author: Edwin Török Date: Tue May 11 15:56:50 2021 +0000 tools/oxenstored: validate config file before live update The configuration file can contain typos or various errors that could prevent live update from succeeding (e.g. a flag only valid on a different version). Unknown entries in the config file would be ignored on startup normally, add a strict --config-test that live-update can use to check that the config file is valid *for the new binary*. For compatibility with running old code during live update recognize --live --help as an equivalent to --config-test. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit e6f07052ce4a0f0b7d4dc522d87465efb2d9ee86) commit f0e653fb4aea77210b8096c170e82de3c2039d89 Author: Edwin Török Date: Fri Dec 16 18:25:20 2022 +0000 tools/ocaml/xb: Drop Xs_ring.write This function is unusued (only Xs_ring.write_substring is used), and the bytes/string conversion here is backwards: the C stub implements the bytes version and then we use a Bytes.unsafe_of_string to convert a string into bytes. However the operation here really is read-only: we read from the string and write it to the ring, so the C stub should implement the read-only string version, and if needed we could use Bytes.unsafe_to_string to be able to send 'bytes'. However that is not necessary as the 'bytes' version is dropped above. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit 01f139215e678c2dc7d4bb3f9f2777069bb1b091) commit 7d516fc87637dc551494f8eca08f106f578f7112 Author: Edwin Török Date: Fri Dec 16 18:25:10 2022 +0000 tools/ocaml/xb,mmap: Use Data_abstract_val wrapper This is not strictly necessary since it is essentially a no-op currently: a cast to void * and value *, even in OCaml 5.0. However it does make it clearer that what we have here is not a regular OCaml value, but one allocated with Abstract_tag or Custom_tag, and follows the example from the manual more closely: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head It also makes it clearer that these modules have been reviewed for compat with OCaml 5.0. We cannot use OCaml finalizers here, because we want exact control over when to unmap these pages from remote domains. No functional change. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit d2ccc637111d6dbcf808aaffeec7a46f0b1e1c81) commit 5d8f9cfa166c55a308856e7b021d778350edbd6c Author: Edwin Török Date: Tue Nov 1 17:59:17 2022 +0000 tools/ocaml/xenctrl: Use larger chunksize in domain_getinfolist domain_getinfolist() is quadratic with the number of domains, because of the behaviour of the underlying hypercall. Nevertheless, getting domain info in blocks of 1024 is far more efficient than blocks of 2. In a scalability testing scenario with ~1000 VMs, a combination of this and the previous change takes xenopsd's wallclock time in domain_getinfolist() down from 88% to 0.02% Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont Acked-by: Christian Lindig (cherry picked from commit 95db09b1b154fb72fad861815ceae1f3fa49fc4e) commit 03f545b6cf3220b4647677b588e5525a781a4813 Author: Edwin Török Date: Tue Nov 1 17:59:16 2022 +0000 tools/ocaml/xenctrl: Make domain_getinfolist tail recursive domain_getinfolist() is quadratic with the number of domains, because of the behaviour of the underlying hypercall. xenopsd was further observed to be wasting excessive quantites of time manipulating the list of already-obtained domains. Implement a tail recursive `rev_concat` equivalent to `concat |> rev`, and use it instead of calling `@` multiple times. An incidental benefit is that the list of domains will now be in domid order, instead of having pairs of 2 domains changing direction every time. In a scalability testing scenario with ~1000 VMs, a combination of this and the subsequent change takes xenopsd's wallclock time in domain_getinfolist() down from 88% to 0.02% Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont Acked-by: Christian Lindig (cherry picked from commit c3b6be714c64aa62b56d0bce96f4b6a10b5c2078) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Feb 10 01:46:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 01:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493036.762841 (Exim 4.92) (envelope-from ) id 1pQIUs-0000E1-M1; Fri, 10 Feb 2023 01:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493036.762841; Fri, 10 Feb 2023 01:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIUs-0000Du-J4; Fri, 10 Feb 2023 01:46:42 +0000 Received: by outflank-mailman (input) for mailman id 493036; Fri, 10 Feb 2023 01:46:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIUr-0000Do-EX for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 01:46:41 +0000 Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [2607:f8b0:4864:20::931]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2397c41-a8e4-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 02:46:39 +0100 (CET) Received: by mail-ua1-x931.google.com with SMTP id b11so715857uae.4 for ; Thu, 09 Feb 2023 17:46:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2397c41-a8e4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3bZyRdx/tBTOfbHOAIRS378NmZr2nfsGuMCm41Sv5BI=; b=MVkkD1Zsrzamw4LcETsWm9FVOP9uuLOArbbbu7NRt1CwD0RAtjh1WpGRh6O/yMkmJ8 skcOkRdaKHJRvM0M08EIewFi0ezUaB8z9JkNwTFaqAiaNFuBlRcvAbF0QYr+MC0m1NQL UVhEO47lv+AiS3efWxNGFkWd+Bf78Xg6Ye0pvDLpvRGDlheCReQzEQOANd+R79OZyG1b 8hK6fK21aVkwEuqXL6HTh/n9yyE/wPKDU8jzKk+ssxISKoqGOo8kgtAqSWXY4c3K96fY p0388soavvfAZ0PEwxM33hB0mRHtgwVbxqO6Sce6swreDy5OPoyULInWMqEwFkLWMRND 9P4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3bZyRdx/tBTOfbHOAIRS378NmZr2nfsGuMCm41Sv5BI=; b=gleK8AKp0o267JlImQPG4fEhqwBpbnR6BVfOFSClnKOY5HQp0Xn72cm6++H8wGMu1S +1Hpc6MUw0ML96rs22bDCtjLpIWKNaG1o+hopeex3/beusVMHr6DHqB4x9BMGt7dS+o/ DhrI/uAiX1/M9jBOGKxQq8UcEJW2Ll6SA7zQJIxUvwuyEQ9A0S0pRZD5Xs8Sm5d/TE2F kJf/Z9OhGERGw0HJLFOzRKaY0xY37pMaomCVAXYuWyAmq/Q56prhDbvnf5Zcc/DUT687 VMv62YIxyNBZHHnqReSdFMlCQJT1Os5+HZ8WG/ni5jcfyzeqCkB5i+IZzAiLk8ycQxUP IYxw== X-Gm-Message-State: AO0yUKXUVgqmamk3NuoMQoHRThR0X79OdGMmZTRfKvI4LVr0IGHQUCHr CoTaTOGklfmspdGZ0kqnanMQXGh6eS+T3c79Q1M= X-Google-Smtp-Source: AK7set85KH7pDDzlzhcJ3ZCDfwaSAOhStZj+BYybrRQG22yB+8hChhJj15YdM4JkNE6QXX6IqN1e1VDNmWepu5K4WXY= X-Received: by 2002:ab0:3b90:0:b0:683:c74a:af60 with SMTP id p16-20020ab03b90000000b00683c74aaf60mr2744470uaw.74.1675993597834; Thu, 09 Feb 2023 17:46:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alistair Francis Date: Fri, 10 Feb 2023 11:46:03 +1000 Message-ID: Subject: Re: [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > The patch introduces an implementation of basic exception handlers: > - to save/restore context > - to handle an exception itself. The handler calls wait_for_interrupt > now, nothing more. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Refactor entry.S to start using of defines introduced in asm_offsets.C > - Rename {__,}handle_exception to handle_trap() and do_trap() to be more > consistent with RISC-V spec. > - Wrap handle_trap() to ENTRY(). > --- > xen/arch/riscv/Makefile | 2 + > xen/arch/riscv/entry.S | 94 ++++++++++++++++++++++++++++++ > xen/arch/riscv/include/asm/traps.h | 13 +++++ > xen/arch/riscv/traps.c | 13 +++++ > 4 files changed, 122 insertions(+) > create mode 100644 xen/arch/riscv/entry.S > create mode 100644 xen/arch/riscv/include/asm/traps.h > create mode 100644 xen/arch/riscv/traps.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 1a4f1a6015..443f6bf15f 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,7 +1,9 @@ > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > +obj-y += entry.o > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += sbi.o > obj-y += setup.o > +obj-y += traps.o > > $(TARGET): $(TARGET)-syms > $(OBJCOPY) -O binary -S $< $@ > diff --git a/xen/arch/riscv/entry.S b/xen/arch/riscv/entry.S > new file mode 100644 > index 0000000000..0be543f8e0 > --- /dev/null > +++ b/xen/arch/riscv/entry.S > @@ -0,0 +1,94 @@ > +#include > +#include > +#include > +#include > +#include > + > +/* WIP: only works while interrupting Xen context */ > +ENTRY(handle_trap) > + > + /* Exceptions from xen */ > +save_to_stack: > + /* Save context to stack */ > + REG_S sp, (CPU_USER_REGS_SP - CPU_USER_REGS_SIZE) (sp) > + addi sp, sp, -CPU_USER_REGS_SIZE > + REG_S t0, CPU_USER_REGS_T0(sp) > + > + /* Save registers */ > + REG_S ra, CPU_USER_REGS_RA(sp) > + REG_S gp, CPU_USER_REGS_GP(sp) > + REG_S t1, CPU_USER_REGS_T1(sp) > + REG_S t2, CPU_USER_REGS_T2(sp) > + REG_S s0, CPU_USER_REGS_S0(sp) > + REG_S s1, CPU_USER_REGS_S1(sp) > + REG_S a0, CPU_USER_REGS_A0(sp) > + REG_S a1, CPU_USER_REGS_A1(sp) > + REG_S a2, CPU_USER_REGS_A2(sp) > + REG_S a3, CPU_USER_REGS_A3(sp) > + REG_S a4, CPU_USER_REGS_A4(sp) > + REG_S a5, CPU_USER_REGS_A5(sp) > + REG_S a6, CPU_USER_REGS_A6(sp) > + REG_S a7, CPU_USER_REGS_A7(sp) > + REG_S s2, CPU_USER_REGS_S2(sp) > + REG_S s3, CPU_USER_REGS_S3(sp) > + REG_S s4, CPU_USER_REGS_S4(sp) > + REG_S s5, CPU_USER_REGS_S5(sp) > + REG_S s6, CPU_USER_REGS_S6(sp) > + REG_S s7, CPU_USER_REGS_S7(sp) > + REG_S s8, CPU_USER_REGS_S8(sp) > + REG_S s9, CPU_USER_REGS_S9(sp) > + REG_S s10,CPU_USER_REGS_S10(sp) > + REG_S s11,CPU_USER_REGS_S11(sp) > + REG_S t3, CPU_USER_REGS_T3(sp) > + REG_S t4, CPU_USER_REGS_T4(sp) > + REG_S t5, CPU_USER_REGS_T5(sp) > + REG_S t6, CPU_USER_REGS_T6(sp) > + csrr t0, CSR_SEPC > + REG_S t0, CPU_USER_REGS_SEPC(sp) > + csrr t0, CSR_SSTATUS > + REG_S t0, CPU_USER_REGS_SSTATUS(sp) > + > + mv a0, sp > + jal do_trap > + > +restore_registers: > + /* Restore stack_cpu_regs */ > + REG_L t0, CPU_USER_REGS_SEPC(sp) > + csrw CSR_SEPC, t0 > + REG_L t0, CPU_USER_REGS_SSTATUS(sp) > + csrw CSR_SSTATUS, t0 > + > + REG_L ra, CPU_USER_REGS_RA(sp) > + REG_L gp, CPU_USER_REGS_GP(sp) > + REG_L t0, CPU_USER_REGS_T0(sp) > + REG_L t1, CPU_USER_REGS_T1(sp) > + REG_L t2, CPU_USER_REGS_T2(sp) > + REG_L s0, CPU_USER_REGS_S0(sp) > + REG_L s1, CPU_USER_REGS_S1(sp) > + REG_L a0, CPU_USER_REGS_A0(sp) > + REG_L a1, CPU_USER_REGS_A1(sp) > + REG_L a2, CPU_USER_REGS_A2(sp) > + REG_L a3, CPU_USER_REGS_A3(sp) > + REG_L a4, CPU_USER_REGS_A4(sp) > + REG_L a5, CPU_USER_REGS_A5(sp) > + REG_L a6, CPU_USER_REGS_A6(sp) > + REG_L a7, CPU_USER_REGS_A7(sp) > + REG_L s2, CPU_USER_REGS_S2(sp) > + REG_L s3, CPU_USER_REGS_S3(sp) > + REG_L s4, CPU_USER_REGS_S4(sp) > + REG_L s5, CPU_USER_REGS_S5(sp) > + REG_L s6, CPU_USER_REGS_S6(sp) > + REG_L s7, CPU_USER_REGS_S7(sp) > + REG_L s8, CPU_USER_REGS_S8(sp) > + REG_L s9, CPU_USER_REGS_S9(sp) > + REG_L s10, CPU_USER_REGS_S10(sp) > + REG_L s11, CPU_USER_REGS_S11(sp) > + REG_L t3, CPU_USER_REGS_T3(sp) > + REG_L t4, CPU_USER_REGS_T4(sp) > + REG_L t5, CPU_USER_REGS_T5(sp) > + REG_L t6, CPU_USER_REGS_T6(sp) > + > + /* Restore sp */ > + REG_L sp, CPU_USER_REGS_SP(sp) > + > + sret > diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h > new file mode 100644 > index 0000000000..f3fb6b25d1 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/traps.h > @@ -0,0 +1,13 @@ > +#ifndef __ASM_TRAPS_H__ > +#define __ASM_TRAPS_H__ > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +void do_trap(struct cpu_user_regs *cpu_regs); > +void handle_trap(void); > + > +#endif /* __ASSEMBLY__ */ > + > +#endif /* __ASM_TRAPS_H__ */ > diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c > new file mode 100644 > index 0000000000..ccd3593f5a > --- /dev/null > +++ b/xen/arch/riscv/traps.c > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Copyright (C) 2023 Vates > + * > + * RISC-V Trap handlers > + */ > +#include > +#include > + > +void do_trap(struct cpu_user_regs *cpu_regs) > +{ > + die(); > +} > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Fri Feb 10 01:58:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 01:58:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493045.762856 (Exim 4.92) (envelope-from ) id 1pQIg2-0001wh-OF; Fri, 10 Feb 2023 01:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493045.762856; Fri, 10 Feb 2023 01:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIg2-0001wa-LN; Fri, 10 Feb 2023 01:58:14 +0000 Received: by outflank-mailman (input) for mailman id 493045; Fri, 10 Feb 2023 01:58:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIg1-0001wU-1N for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 01:58:13 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe16::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e6f3b4c-a8e6-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 02:58:10 +0100 (CET) Received: from AM6PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:20b:6e::14) by AS8PR08MB9118.eurprd08.prod.outlook.com (2603:10a6:20b:5b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 01:58:01 +0000 Received: from AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::e9) by AM6PR02CA0001.outlook.office365.com (2603:10a6:20b:6e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21 via Frontend Transport; Fri, 10 Feb 2023 01:58:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT034.mail.protection.outlook.com (100.127.140.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19 via Frontend Transport; Fri, 10 Feb 2023 01:58:01 +0000 Received: ("Tessian outbound baf1b7a96f25:v132"); Fri, 10 Feb 2023 01:58:00 +0000 Received: from 004a2ca34f67.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B8EA516A-6A66-4B6F-9ED5-D6B043AC1B02.1; Fri, 10 Feb 2023 01:57:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 004a2ca34f67.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Feb 2023 01:57:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR3PR08MB5723.eurprd08.prod.outlook.com (2603:10a6:102:89::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 01:57:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::d1d7:166d:6c34:d19e%4]) with mapi id 15.20.6064.035; Fri, 10 Feb 2023 01:57:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e6f3b4c-a8e6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2M8XVoSVQzj1eLY7upvJZiKmO3vJoeH8m934rCew6kk=; b=KfkIhEMwZAbeuIaN85oHrFysWpGIx3qGhGXNM0qxa91w0mHB6Djx03G0sKv7Aj98AGd0nVGXv1X9dUEsU3n6xaocKlBjKpf8m3OgoAS1j99uUXvT4WRRRxLqVb9RrGH2kZ04A+g6Wc0NKGgRFM7wQcFu7aY822q1EmTQA0uZqBY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mi2ohxfE4lK1qB+1jd3nyqVRSvVOcwrsTrKBr5mTcn4uQjTnqUt19JZLrbhZzq08qn/K2HyqLLRKeBXdDgfFWwP+qsEa9lvgntW7bh/dK+i6+81yspjvB18xU3MaI3wH5mZWyF1jqP4GyluMslHrTKh7jGnwCfl+Md8GvHIzL6OGydF2TK8g9fkcRdVYT9M0GflIfgUCZhCyLN+nI+OYZdbpTwz80EzhEEujG+H8Bc/iNd3q6NtJRqoMatPcCLp/NupNlpc9BF6EK1phqgXFFhDA6TA3VYCafZKc517xCQdoMmwSBh60uwEEDKc3RXWswsO5IlYHiyfNxfgPu+igBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2M8XVoSVQzj1eLY7upvJZiKmO3vJoeH8m934rCew6kk=; b=hoHMpmOWSM3wDQc0h9CQJhmLc3GbhbXA54U/LSm5hbo7mri1I3Qg44DwlDygoZ21G7dlfEHk6ZuF9wWyUur+rod6lgBfDon8ud3XUOgQlBjiXDC9K/e+m0nRBScf4N955gX2JXOlEqEwW0PhkSQy3hbLdp5eELGHQQ+WpJKhNDVXolf8JFwI75uuKB56BAA5udV9UcPECaddsiLUVdIg06ClsXJtbB25zPnW2/o1Zz0m2U7mF6Q/Ow+6zrN2DWa5mQhCacFMzLWxq4HPTOSlZfMO8dE49lq0WZwrzbumNScignpMu83GXDn7/7kkPM2JjYh5t5Wu8KRwUueBOK48Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2M8XVoSVQzj1eLY7upvJZiKmO3vJoeH8m934rCew6kk=; b=KfkIhEMwZAbeuIaN85oHrFysWpGIx3qGhGXNM0qxa91w0mHB6Djx03G0sKv7Aj98AGd0nVGXv1X9dUEsU3n6xaocKlBjKpf8m3OgoAS1j99uUXvT4WRRRxLqVb9RrGH2kZ04A+g6Wc0NKGgRFM7wQcFu7aY822q1EmTQA0uZqBY= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v2 1/4] docs/process: branching-checklist: Reword the section about Config.mk Thread-Topic: [PATCH v2 1/4] docs/process: branching-checklist: Reword the section about Config.mk Thread-Index: AQHZPKvv515bR3UnJEOFsOrA2YinZa7HazWA Date: Fri, 10 Feb 2023 01:57:52 +0000 Message-ID: References: <20230209172820.56292-1-julien@xen.org> <20230209172820.56292-2-julien@xen.org> In-Reply-To: <20230209172820.56292-2-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 68CF94D2BF3B5E4DB2180453436FA4DC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PR3PR08MB5723:EE_|AM7EUR03FT034:EE_|AS8PR08MB9118:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d8ef17a-c7da-475f-59fd-08db0b0a3d71 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VKaHRG/42uTAp6RXVTWVTirnU0ON4Ukbr1ZeFsU2F2LGV9QHPf49rUlosqjMO0ewcDilqmmeDkfqQvT9u27uKrTd9pTo8/cD1CgenFjxdjtBStL7bjwAI7nx4MD9tKj4fnPURRmJXQzI6o9Qx7mNXc8kGgm5SDZrDY33KEvtlWaIy3C3kO9YJwKpwG4DmSXCC1+bpUqCQdawT0fpTyUvxpiFXR8yvHKfc7Si0bIC3h7c+Ccp5JVBrQoOrpdoRiM7a9uB9L8+fJDXOXYr7rCca8eX8IgjG0Gevw8bSuR7jyJYtZRSzt6eoKFjEOy7usE54GGbUgKGnAh6y4Z31koUCpXI6ErDHqmtyGORt0k6P3KKPTaoAHYz0OblHtzlEMPpROELLGCGHVcs/eJp2oxYSRGGHTCjAfouvHH7CGunwRzaXOjN3QD27eftMvvkMQq34+qijS8lYWCbCIAQyx1t1Uqn/RvZvJjlvgXig89OkO3pXYoYOIqu+pws1tmeZ7KyoqGkBTxDqII48tUvwU3TIUbtblLOyYEM6cY7j2ybglBMgbsCK2LxM6nokoaB9HG37JiKKJlNyZWd+ErarS0PXl9z4l4wcl/tCf+/BREz8DCWpVHYVdwxr1nIiJBRowCmL+3XQFmw9VwfSSmvsbU4jjgE+SD5T+uI48USKKh4BHeqIxl/JdlOcm8HetslhG5+t9M0p0FDBVcOD5z1A+WTtg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199018)(122000001)(38070700005)(38100700002)(8676002)(86362001)(33656002)(7696005)(2906002)(4744005)(41300700001)(52536014)(4326008)(5660300002)(8936002)(9686003)(55016003)(64756008)(66446008)(6506007)(26005)(186003)(316002)(54906003)(83380400001)(110136005)(66946007)(66476007)(66556008)(478600001)(71200400001)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5723 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f5094a81-df7d-49f6-7717-08db0b0a3837 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 47B/RLWuFmKeAK4EU2zc4+xJpfPBZ1BhrzLcCrH8qs8+CXvC2zHiV4WYR/GLyOa970+uTHqTZSfGKj1Cps9lI0n9m5TRMdSfrintzgTplGNmuTzQZwnk2nBWvn8JzUpEsQ/63sjwLn4mhkZXFJ5dAAvo8MDZpxwzxG1tclfWPMtFYjkK9ZVWJKqjXni8mHBF+JO5MS9EWlQdxdxEIERbzhlxTiA6EqY7DLVTzBlai2j2X7Odi/IR0UfacpEA+GMA6RTJ3yjzoLaH5ceRerYSadH/OJug5Z7OB0URiYhCoKXxNW+1zr93JYFB2qA+c0Ric3iRsW2Lwkmtr0gzcvK+hnI924YBSAw8WOe/LFblwHNOYBVUxytsHokfwtE7d2TX7p1/N5O2YUrbbljV1LpY5qKEmGVp1CynHYJ02yj9MCx1Qr56A4jNBfYC+R14NooXLthikerKHFdihW1Lf6xbEaJ1j330VNhVGkvxoMx1Z2Gueyw+ziOlvMHAtbZ7H8pqyoDflTjTGlwfiqA4RxXKCjJ9rBacPzXJFNdbVVlCfATnubymy3Y7JI4gxDwMTHGurT3YMoGTn7EzKWqxXpqsOxvoAa54i1JW8G9Jx7CLstHgHRdec3u+yB38WXWuWFwQY8mnOCTNnyr/BkPmzrKKRPmHJtTJV3a7+4+7BS/cgTswFrlsZKGvVVOSrI9u/9sxtex7c2WYQYK4sFdgjfyJ4g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(396003)(451199018)(36840700001)(40470700004)(46966006)(478600001)(33656002)(86362001)(41300700001)(8936002)(8676002)(70206006)(70586007)(82310400005)(5660300002)(52536014)(4744005)(4326008)(2906002)(36860700001)(81166007)(356005)(82740400003)(83380400001)(40480700001)(7696005)(186003)(55016003)(40460700003)(6506007)(54906003)(110136005)(316002)(47076005)(9686003)(26005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 01:58:01.1005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d8ef17a-c7da-475f-59fd-08db0b0a3d71 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9118 Hi Julien, > -----Original Message----- > Subject: [PATCH v2 1/4] docs/process: branching-checklist: Reword the > section about Config.mk >=20 > From: Julien Grall >=20 > Since at least Xen 4.12, the revision for external trees don't contain > the word "unstable". So explicitely list the *_REVISION variables that A small typo that can be fixed on commit: s/explicitely/explicitly > need to be updated as part of the branching process. >=20 > Signed-off-by: Julien Grall Change looks good, thanks for updating the doc :) Reviewed-by: Henry Wang Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Feb 10 02:01:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 02:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493052.762866 (Exim 4.92) (envelope-from ) id 1pQIik-0003iB-4m; Fri, 10 Feb 2023 02:01:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493052.762866; Fri, 10 Feb 2023 02:01:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIik-0003i4-27; Fri, 10 Feb 2023 02:01:02 +0000 Received: by outflank-mailman (input) for mailman id 493052; Fri, 10 Feb 2023 02:01:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQIii-0003hy-LD for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 02:01:00 +0000 Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [2607:f8b0:4864:20::a29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c29b9de0-a8e6-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 03:00:58 +0100 (CET) Received: by mail-vk1-xa29.google.com with SMTP id v81so1964618vkv.5 for ; Thu, 09 Feb 2023 18:00:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c29b9de0-a8e6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=w1+QKU5JvS4tdko2OIBLzePqxsG9Ng28xzz9v2ybgZM=; b=cpV6YvfeKrFwSlOopNZQzXMfcl3OlzEu+nqJ6F/HpYOUQtAHyJGEpZ58qW4wKHbrcc emVZ/awCpsxspRmn+SELLZmYiPyZRZQngjYzkCwUVkwWKo/mQyydjr66ASE3SoJgBMzW RVFk54kZBBxTZUGOXRL19Gj3EX/OTyaY8hlzlObQ76vB0BZ9Q2wEJzAKKtbASz96DLSg c4Otyk5baMZUSYEioKLRVYwdjqsHIqjRO28Yb7JSFtBpE9IQiq7s/d5R3o1BZ29F3L5z OG9IpN13IirjTHNmKp5Ljjq9IIR9cA8QRq4B9Rup8Hn7AJ9IzkGY1Jw4GNTQKFTl5qmU FL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w1+QKU5JvS4tdko2OIBLzePqxsG9Ng28xzz9v2ybgZM=; b=JsFkqGrA8w7A0G+CcAbObcL8ZdbUM6CHZ2yCEP/Z/B2hoh0lI5fUujTwuCnIzxcn3r WHCh/S4eqQ0qPvEeIAvQU/AJdhHOQ8S9s2fM1bHsZ96IOEbVAHFFHnrhBuPN/aWWWoZP +Be3jJyXsqARIdLHORh49/l0l0sad7MoX7eFQREujSouH7JKAlsnCYESuWrq5fFBrt8U zKN47pX7SJMkH3yFE0/+KTd6Mds8m1hG/V9MTjFwH3R3EH+BxVG3XTtSx9hj2fpAMRe2 nC19OFi2bL8mP52R4bYfu3JZ5sBsb9FoJ9Clkr0vgpdPTHHhMlZHhMZz4yq0BoTYz9tE WHxg== X-Gm-Message-State: AO0yUKUAVOqoEz4Qu2CIbDU9P7rlBC+Ph3M5POwwD5WMmsANlYf2arbI Oagfodi/R8Yk0fbunBVjP+NIGLrQgTIR4SYzAVk= X-Google-Smtp-Source: AK7set86rFd0+/xoEiZ29FbQH7dGuAaHOUEUkumV3pl9keMcuJL5TjH+YqPW+8QWMbfvEvwm+TjpH6ANGBw6Kriv9gM= X-Received: by 2002:a1f:2414:0:b0:3ea:3dee:4545 with SMTP id k20-20020a1f2414000000b003ea3dee4545mr2653666vkk.26.1675994457534; Thu, 09 Feb 2023 18:00:57 -0800 (PST) MIME-Version: 1.0 References: <0198e2a5b572b9031eafe7cd1c85c6f9537b704c.1675779308.git.oleksii.kurochko@gmail.com> In-Reply-To: <0198e2a5b572b9031eafe7cd1c85c6f9537b704c.1675779308.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Fri, 10 Feb 2023 12:00:31 +1000 Message-ID: Subject: Re: [PATCH v3 09/14] xen/riscv: introduce decode_cause() stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" On Wed, Feb 8, 2023 at 12:48 AM Oleksii Kurochko wrote: > > The patch introduces stuff needed to decode a reason of an > exception. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Make decode_trap_cause() more optimization friendly. > - Merge the pathc which introduces do_unexpected_trap() to the current one. > --- > xen/arch/riscv/traps.c | 85 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 84 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c > index ccd3593f5a..f2a1e1ffcf 100644 > --- a/xen/arch/riscv/traps.c > +++ b/xen/arch/riscv/traps.c > @@ -4,10 +4,93 @@ > * > * RISC-V Trap handlers > */ > +#include > +#include > #include > #include > +#include > +#include > > -void do_trap(struct cpu_user_regs *cpu_regs) > +static const char *decode_trap_cause(unsigned long cause) > +{ > + static const char *const trap_causes[] = { > + [CAUSE_MISALIGNED_FETCH] = "Instruction Address Misaligned", > + [CAUSE_FETCH_ACCESS] = "Instruction Access Fault", > + [CAUSE_ILLEGAL_INSTRUCTION] = "Illegal Instruction", > + [CAUSE_BREAKPOINT] = "Breakpoint", > + [CAUSE_MISALIGNED_LOAD] = "Load Address Misaligned", > + [CAUSE_LOAD_ACCESS] = "Load Access Fault", > + [CAUSE_MISALIGNED_STORE] = "Store/AMO Address Misaligned", > + [CAUSE_STORE_ACCESS] = "Store/AMO Access Fault", > + [CAUSE_USER_ECALL] = "Environment Call from U-Mode", > + [CAUSE_SUPERVISOR_ECALL] = "Environment Call from S-Mode", > + [CAUSE_MACHINE_ECALL] = "Environment Call from M-Mode", > + [CAUSE_FETCH_PAGE_FAULT] = "Instruction Page Fault", > + [CAUSE_LOAD_PAGE_FAULT] = "Load Page Fault", > + [CAUSE_STORE_PAGE_FAULT] = "Store/AMO Page Fault", > + [CAUSE_FETCH_GUEST_PAGE_FAULT] = "Instruction Guest Page Fault", > + [CAUSE_LOAD_GUEST_PAGE_FAULT] = "Load Guest Page Fault", > + [CAUSE_VIRTUAL_INST_FAULT] = "Virtualized Instruction Fault", > + [CAUSE_STORE_GUEST_PAGE_FAULT] = "Guest Store/AMO Page Fault", > + }; > + > + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) > + return trap_causes[cause]; > + return "UNKNOWN"; > +} > + > +const char *decode_reserved_interrupt_cause(unsigned long irq_cause) > +{ > + switch ( irq_cause ) > + { > + case IRQ_M_SOFT: > + return "M-mode Software Interrupt"; > + case IRQ_M_TIMER: > + return "M-mode TIMER Interrupt"; > + case IRQ_M_EXT: > + return "M-mode TIMER Interrupt"; Wrong string here Alistair > + default: > + return "UNKNOWN IRQ type"; > + } > +} > + > +const char *decode_interrupt_cause(unsigned long cause) > +{ > + unsigned long irq_cause = cause & ~CAUSE_IRQ_FLAG; > + > + switch ( irq_cause ) > + { > + case IRQ_S_SOFT: > + return "Supervisor Software Interrupt"; > + case IRQ_S_TIMER: > + return "Supervisor Timer Interrupt"; > + case IRQ_S_EXT: > + return "Supervisor External Interrupt"; > + default: > + return decode_reserved_interrupt_cause(irq_cause); > + } > +} > + > +const char *decode_cause(unsigned long cause) > +{ > + if ( cause & CAUSE_IRQ_FLAG ) > + return decode_interrupt_cause(cause); > + > + return decode_trap_cause(cause); > +} > + > +static void do_unexpected_trap(const struct cpu_user_regs *regs) > { > + unsigned long cause = csr_read(CSR_SCAUSE); > + > + early_printk("Unhandled exception: "); > + early_printk(decode_cause(cause)); > + early_printk("\n"); > + > die(); > } > + > +void do_trap(struct cpu_user_regs *cpu_regs) > +{ > + do_unexpected_trap(cpu_regs); > +} > -- > 2.39.0 > > From xen-devel-bounces@lists.xenproject.org Fri Feb 10 03:22:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 03:22:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493060.762877 (Exim 4.92) (envelope-from ) id 1pQJzC-0004xk-4v; Fri, 10 Feb 2023 03:22:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493060.762877; Fri, 10 Feb 2023 03:22:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQJzC-0004xd-1k; Fri, 10 Feb 2023 03:22:06 +0000 Received: by outflank-mailman (input) for mailman id 493060; Fri, 10 Feb 2023 03:22:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQJzA-0004xT-7g; Fri, 10 Feb 2023 03:22:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQJzA-0008TH-3r; Fri, 10 Feb 2023 03:22:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQJz9-0001l5-QJ; Fri, 10 Feb 2023 03:22:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQJz9-0002Hy-Pk; Fri, 10 Feb 2023 03:22:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rMK2HbzSdv7TvxH3QI6jxjc71Ju9rJpbLMDOEQqH2hI=; b=gcUUI2Stmx2dmSkvgki4V1aOVN e8ekxIZc/4axWZwI7hOXT8ZjWBxz6tUe6apL3JDZSD1+p0otnC41rfxjqhNCSv3gBf7doHQDGQtH9 kZtESgIoLzQ+sF5RNVNjECChlkYYroExuUuzA/3QrrtdOXsCXimtMnuZmMKOZUXs5YWg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176722: trouble: fail/pass/starved X-Osstest-Failures: linux-5.4:test-amd64-amd64-pair::broken:regression linux-5.4:test-amd64-amd64-pair:host-install/src_host(6):broken:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-examine:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Fri, 10 Feb 2023 03:22:03 +0000 flight 176722 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/176722/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pair broken in 176460 Tests which are failing intermittently (not blocking): test-amd64-amd64-pair 6 host-install/src_host(6) broken in 176460 pass in 176722 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 176460 pass in 176722 test-amd64-i386-libvirt-raw 7 xen-install fail in 176460 pass in 176722 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 176460 pass in 176722 test-amd64-i386-examine 6 xen-install fail in 176653 pass in 176722 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail in 176653 pass in 176722 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 176460 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail pass in 176653 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 176653 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 16 days Testing same since 176413 2023-02-06 07:13:34 Z 3 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-pair broken Not pushing. (No revision log; it would be 4165 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Feb 10 04:14:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 04:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493070.762888 (Exim 4.92) (envelope-from ) id 1pQKo3-00030x-8p; Fri, 10 Feb 2023 04:14:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493070.762888; Fri, 10 Feb 2023 04:14:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQKo3-00030q-5o; Fri, 10 Feb 2023 04:14:39 +0000 Received: by outflank-mailman (input) for mailman id 493070; Fri, 10 Feb 2023 04:14:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQKo1-00030g-2t; Fri, 10 Feb 2023 04:14:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQKo1-0001Dj-18; Fri, 10 Feb 2023 04:14:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQKo0-0003qB-JZ; Fri, 10 Feb 2023 04:14:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQKo0-00017s-J5; Fri, 10 Feb 2023 04:14:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l65fN9GvSQyGdXlRSjN9b5N87fFtsU8fLIstgXe1yck=; b=OOK+cgXmCG7j/fcXIvRiE4V4uu vu+mKmeQtrzoPY5zG3R5Dj0mpe2Wq/MVyFbF3D0vTa/E2VGttpZuZQu040+EcdPvzKPScjw4HXJQH 4ok8IROXfu6B5P4YL4qwR66k/xDkMdT/n9v9p0woRkwFtN/ufbh3/7+6ZPfldpI/o/F0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176790: all pass - PUSHED X-Osstest-Versions-This: ovmf=39254d922e550ccc9c5ab5639c3c28a4ee4e13fd X-Osstest-Versions-That: ovmf=289d93b79c18f42b9dd09770a22d15a11fd40670 From: osstest service owner Date: Fri, 10 Feb 2023 04:14:36 +0000 flight 176790 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176790/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 39254d922e550ccc9c5ab5639c3c28a4ee4e13fd baseline version: ovmf 289d93b79c18f42b9dd09770a22d15a11fd40670 Last test of basis 176764 2023-02-09 17:42:33 Z 0 days Testing same since 176790 2023-02-09 23:14:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Igor Kulchytskyy jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 289d93b79c..39254d922e 39254d922e550ccc9c5ab5639c3c28a4ee4e13fd -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 10 07:07:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 07:07:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493110.762922 (Exim 4.92) (envelope-from ) id 1pQNUc-0007Mp-Su; Fri, 10 Feb 2023 07:06:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493110.762922; Fri, 10 Feb 2023 07:06:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQNUc-0007Mi-Q2; Fri, 10 Feb 2023 07:06:46 +0000 Received: by outflank-mailman (input) for mailman id 493110; Fri, 10 Feb 2023 07:06:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQNUa-0007Mc-UR for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 07:06:45 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20608.outbound.protection.outlook.com [2a01:111:f400:7e88::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7847d3f1-a911-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 08:06:43 +0100 (CET) Received: from MN2PR12MB4408.namprd12.prod.outlook.com (2603:10b6:208:26c::14) by IA0PR12MB7775.namprd12.prod.outlook.com (2603:10b6:208:431::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 07:06:39 +0000 Received: from MN2PR12MB4408.namprd12.prod.outlook.com ([fe80::949:db4a:46d6:ed7c]) by MN2PR12MB4408.namprd12.prod.outlook.com ([fe80::949:db4a:46d6:ed7c%5]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 07:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7847d3f1-a911-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dusCKnU/k6S2dqXrAWgFc+n4/fVKT1M9WH7ByD9SJIr8aNpgkTV+vxU2YVvuTaaonY2WesgnCReUT0NcnmSZjswpTpwCb9vFytcnbHHMyovPEFUAiKvXKDvthmD6MjiXiZGZpTXnYLamAWmZyG2iX9jKeCR4K14k1BYGiBn4euMcAXuKzoCTjPVSmWntni7Jvv/skfYctn+OWZeYZlAYJ2lMgXy8Q5ld/GfDroYU9o+YV09s9nFakpxsfQ0NyT1O0yftE6RI8OhN0zC0uo3riC09qDdXKTB3p+VE/87+xa1IbuPZVvu4ZAPta6UDYGC1OLwpZLxoZJqoAf1CDzVvmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8aLkufrf21sr24vi1qYvnsgcw3tzCrDJ6V4niJVEoPw=; b=hsBXPdDZ4Ka5Z6Y1KbqwRBH7tgt1Pv5wCn7P3dLRX+s9trR5Yw8vY1gXqmHOw1hQTrD1Uj7ognfMNI0VIY3OPa+zsBkf3Pxqx8os3qMfsWRWTHYH/Ahnm5G2IUE5hd6ycApXPQVFrHPxUlAuv/1K45N9o5Y3q+hfyUsy72IWvU/lz7eul7irMVNFnB/qMy0bhHGcaVm6NkaJ6r9yldihr3ivSI+v7us/UxpceoJ6SBu50l4Hg2kgtlQ2SPAq2DqDBahOr89nknT4+TLPx+z0BURKDDb5hi+8pzgBIeMU2lT9v/4BTMKHo/Uk6CquaM3WHxyzgNHRLVs2gWBHQDY+Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8aLkufrf21sr24vi1qYvnsgcw3tzCrDJ6V4niJVEoPw=; b=mxjBU1cqGJmmlcGv7BvLa7L1DmAtO1b3LhdBw7PO2y3h1lpIE946ix61PsYDPfbpsVnZmfeP1k5/q5EmOJ8JJWNkijw5FiVKo54aB9z6g1cCcdACiOVOwmG1aG6HPbgAHkkR4Bt5C28SSN/L1FwAl1F6zllwv5ZUvVPdFtciAhY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <312395a4-2eda-e9ad-43c5-eddbad826935@amd.com> Date: Thu, 9 Feb 2023 23:06:34 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 09/16] xen/iommu: Introduce iommu_remove_dt_device() Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, Luca.Fancellu@arm.com, Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-3-vikram.garhwal@amd.com> <311dc97d-e924-e9ad-25d3-1135d4b24f7e@amd.com> From: Vikram Garhwal In-Reply-To: <311dc97d-e924-e9ad-25d3-1135d4b24f7e@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR06CA0011.namprd06.prod.outlook.com (2603:10b6:a03:d4::24) To MN2PR12MB4408.namprd12.prod.outlook.com (2603:10b6:208:26c::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4408:EE_|IA0PR12MB7775:EE_ X-MS-Office365-Filtering-Correlation-Id: d302969e-7a53-4235-a077-08db0b355aae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8jWckoFkxdm+YKEoTlGrHqsY7qf1dYNuIR61nbzY2+LO6tYufsTOKMLJpIKqkYRoEzGwjLV8XnwtHeyZZQTmb+uMlEXX1X6Rs3TLht5K3UmhHRSVPLNfl+YgwtLx1d6ONgfHO96hvxfr2JG9p+JmIK34E3tFi/l+sFZtqxHJeEoo4O3vX/6pYVxlLbWFVHDoYQJN7rVcIKYqrMVQ9L47gpv1Uz8dTTbteSLJotAyWb4+rYY9ekvKMnOxwAq+QaTOWDsxrDCGphQxzMjFwqTJnGaMQQDXYUPu8FMypU7OYTkYcbNVExLuIKC4jOMlxpVO8XifNY4L9Ii2HJeWH0CbNC4IjFneQ8fyM9FDO2abhrsB3g4/EORn6VvtdFFAmghB1dZwdipn/cg9Yv7j8A4Xo676dqnyxENWdR3fgoRKG4d+a278HNboHkS8lLr5aC5hADdYftPqbSxaDntgFffFuwx4Kj4tCReapCCVZvwPJ18Kh19FJwTHGQ5no50c8Zp0Tg2+AXxQSVaPmKiwe/mn/8JQXYHYwI06g4fEQuLgwEnTxKeON2zNwU+pTwHIWVeWc6D37SYKrIt2j7Kk1cOLoGnOOvh2YQtzCzihVZC8kWa06K2p3KgNd5GhspZLzB38lf9fO0UIAD0wBYhuC98FnDqdfwsZjbOfM+Bl/KWOzy5r/BW/u3XzCc9PYMDI5+fGZK8EnOTRn1W1xRXwh4Y6r9tdhXTSLGuVys0EHFegTBI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4408.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199018)(31686004)(8676002)(186003)(8936002)(66476007)(66556008)(66946007)(6506007)(6512007)(4326008)(26005)(36756003)(31696002)(86362001)(38100700002)(2616005)(53546011)(2906002)(6486002)(316002)(54906003)(41300700001)(6666004)(44832011)(5660300002)(478600001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWU3TXJBcVU5dm5qaHVvSXRmd282Z1VUSUQvOE1TWWx0bE85ajYyYVkrSzVT?= =?utf-8?B?NFdYTC90UDZqdjBKY1Fwamhvemp3c2RmZ05YU1d5dVpGNDJjZmhxekJHRmp5?= =?utf-8?B?aXdURk10aWladXhJcmZBcFlPVW9tVlpraFVvUm9iVXRpdi9qVU5KNjlCTXlk?= =?utf-8?B?dDFUU2d5em54dkJKSGhsdkdLMXMyTXFHczZ0Zm82K1Z2K0MvVVdMeUYySWdC?= =?utf-8?B?ZGRoc0wra2tOQThhaHNTMXZjeW9tT2NWR05MUkpuZXVFN24wMitpSzQ3NmVC?= =?utf-8?B?RG1xNVgrQ3lDQnh2OFNJRzcvUTZHSXJRb0RjZGk2V2hvd0JzSDZvK085Qlln?= =?utf-8?B?WE5hSEdUZDkyTDdLcklTdkhnQmlRZmNyUGhlMEhQTG1xc0hWY2JCYURtbGhC?= =?utf-8?B?UklObmNzT3paRWZOcExYN3ZiZHhNUUxKQjJUa1hQZlRTc0FpWjZjNWhhS3Fy?= =?utf-8?B?MHBBa1dRNFZiVzRuOUF3bFptMEwzTW9tTlVWaFltcGtLdStvZWM1SUprRE5t?= =?utf-8?B?aXJPWlBYMXQwemswaWZ1UlhKSmlZSE1PbEdTS3l3Kys4TjRNQVJvK3hzTjhM?= =?utf-8?B?SVJWMU5WNDJEZUxHa3FsUVNxeGNuMElrZGlpU0hXak44SkJiUUhNREZ0S2ky?= =?utf-8?B?dWl0QzI2VUc3L1RGV1VuVzB6OTMvUnNvNnlhaUsySHdaT2gzWG8rVDM0R3hh?= =?utf-8?B?TTVHUTJPQVpSb2dRTUFQcyt0S2ZLcmtWSi9nOFBnRWY1SzJ6eS8yZXZPQThj?= =?utf-8?B?dUxHWXRUeGhxcWZPeHZnTzBVaWRGQ0g2akpaUHhnSXpBQ2FUWkRCVnVvYVhJ?= =?utf-8?B?MDdpYmU1cmtNZ3l6YW1VRERRUDl6QXBSZnNXUEIyUHlCT1JmN3lDTGdXUGZy?= =?utf-8?B?bHNUL1Ntb3d6QlpnWmMvMlcwYy9hZnNwYWJya2pxTjdKV3g2SWxqQ2txUGtO?= =?utf-8?B?dlVvZjZFdXBHRzlCUnZJdUFHWHRWazRtR3FxcHNFdkduTngwT09HOVJBM0tU?= =?utf-8?B?UlZ4UWNISjMwKzN1dzNRNW1udEpRTmZmVVA1aEJHS3cvSGZUVmJFWlFzZGRM?= =?utf-8?B?cHB4MG95R0ZuNEdhM3VFb2gvb3dVWjhoazhsWXVlenI3UzA0QktSV09NQ3VZ?= =?utf-8?B?ZU5BK2x5eDNDMUN4bFZqaEdqODJTeURwbWUwZnpyZmYxbkNaeGNEc2NZbCto?= =?utf-8?B?TXN0eU1EWlhRR29RK3pTbkFpdlE0OVJkVVUyTUZuY3BFQm94UWk5WE1EZTdy?= =?utf-8?B?NGlqTkJiMmgyMVlqOFc2T1Nsc3N5K1FVemUydWRJd25PTSt1VTNoZnhjR0Zm?= =?utf-8?B?VEZyWWtweEpzWDJOelJsbnZEUmovbitYaXBoZFEzRnlWc1pyWGpSQnd3NlI5?= =?utf-8?B?d1ZNMkdqcU9ieDBISXFaRWp4K250UUdPaFRaWExsYnF6NmRNbFhHWVUzOE9N?= =?utf-8?B?K0JRN1AvRHNzdklNcmZpZkM5VFlBRTl4ZGwxT3NSSTZ1RytuZlJ1K2N0ZERa?= =?utf-8?B?b2FIOFhUdmd4NW90ZXZTRTd0RzJyVkdib3lMUzdzNG9KUFJQOXNxNFpieGJE?= =?utf-8?B?b1hvam03NzlGd0pyN3lYdURLNXJ5YlliNDZjd25hSVMzRm9yUTlNYW5TNjdt?= =?utf-8?B?SE9vRDJlMHVzK1hRdUQ2dC9pZEtXQ1dGZVRkVlFVeS82WVBqWXZOYStSTU1Z?= =?utf-8?B?WTlNUlhBOENycW9ZVnZXUmdjVXkzRjVRSWFKSWRjc01QQzkySGxTNytpQlg2?= =?utf-8?B?SGkyQm5WcHB6YktPM2FRallYcHM0K01GOWdFOUFUczJCOFQ5ZnQ2WmwyQm40?= =?utf-8?B?TFJiRm8wcnBhZ3pCTUUrcG1Lc2UrZnBXeG04di9qWU9PaUdodGQ2UWgxcyti?= =?utf-8?B?RTNWSXJoci9EcGFheS9LLy90RGFtSjdUQmZTRm4yVk1CcUpZcEk5RWJ5Vi9F?= =?utf-8?B?dlRpN2MwU3Q5Ykw3QWNKVldzTFVSMkRMUDBNK1ZJa2U4KzZHMW8vdnBRQTBn?= =?utf-8?B?Q1VSREcvV1hWRlNONzdFTGxzNDhNQjMzYllHUmxHOFdkak8wVm1WRVJ2aDRV?= =?utf-8?B?ZElRVlVBaXpQR284Z0F0U01tTms4K3RPVU5GbmRJeGRqemJwNkpacXI5dnJN?= =?utf-8?Q?mmSnT6TH/u1KF3tl3CquEOKaY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d302969e-7a53-4235-a077-08db0b355aae X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4408.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 07:06:39.8276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EPPRvpKQeSoP8XnJmA6HjAQuqFRmmYyJUNQtrwFTUpZJFeI2+TZvKUCQjAhlr+2suJXLu6UkVejoA3mTDMpsXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7775 Hi Michal, On 1/23/23 2:00 AM, Michal Orzel wrote: > Hi Vikram, > > On 07/12/2022 07:18, Vikram Garhwal wrote: >> >> Remove master device from the IOMMU. > Adding some description on the purpose would be beneficial. will do. >> Signed-off-by: Vikram Garhwal >> --- >> xen/drivers/passthrough/device_tree.c | 38 +++++++++++++++++++++++++++ >> xen/include/xen/iommu.h | 2 ++ >> 2 files changed, 40 insertions(+) >> >> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c >> index 457df333a0..a8ba0b0d17 100644 >> --- a/xen/drivers/passthrough/device_tree.c >> +++ b/xen/drivers/passthrough/device_tree.c >> @@ -126,6 +126,44 @@ int iommu_release_dt_devices(struct domain *d) >> return 0; >> } >> >> +int iommu_remove_dt_device(struct dt_device_node *np) >> +{ >> + const struct iommu_ops *ops = iommu_get_ops(); >> + struct device *dev = dt_to_dev(np); >> + int rc; >> + > Aren't we missing a check if iommu is enabled? IIUC your question: There is only one caller which is in dynamic programming part handle_remove_irq_iommu(). The call only happen if the dt_node has iommu property. >> + if ( !ops ) >> + return -EOPNOTSUPP; > -EINVAL to match the return values returned by other functions? > >> + >> + spin_lock(&dtdevs_lock); >> + >> + if ( iommu_dt_device_is_assigned_locked(np) ) { > Incorrect coding style. The closing brace should be placed on the next line. Fixed this for v5. > >> + rc = -EBUSY; >> + goto fail; >> + } >> + >> + /* >> + * The driver which supports generic IOMMU DT bindings must have >> + * these callback implemented. >> + */ >> + if ( !ops->remove_device ) { > Incorrect coding style. The closing brace should be placed on the next line. Fixed this for v5. > >> + rc = -EOPNOTSUPP; > -EINVAL to match the return values returned by other functions? > >> + goto fail; >> + } >> + >> + /* >> + * Remove master device from the IOMMU if latter is present and available. >> + */ > No need for a multi-line comment style. Fixed this for v5. > >> + rc = ops->remove_device(0, dev); >> + >> + if ( rc == 0 ) > !rc is preffered. Fixed this for v5. > >> + iommu_fwspec_free(dev); >> + >> +fail: >> + spin_unlock(&dtdevs_lock); >> + return rc; >> +} >> + >> int iommu_add_dt_device(struct dt_device_node *np) >> { >> const struct iommu_ops *ops = iommu_get_ops(); >> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h >> index 4f22fc1bed..1b36c0419d 100644 >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -225,6 +225,8 @@ int iommu_release_dt_devices(struct domain *d); >> */ >> int iommu_add_dt_device(struct dt_device_node *np); >> >> +int iommu_remove_dt_device(struct dt_device_node *np); > These prototypes look to be placed in order. So your function should be > placed before add function. Fixed this for v5. > >> + >> int iommu_do_dt_domctl(struct xen_domctl *, struct domain *, >> XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); >> >> -- >> 2.17.1 >> >> > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 10 07:07:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 07:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493115.762934 (Exim 4.92) (envelope-from ) id 1pQNVI-0007rX-5L; Fri, 10 Feb 2023 07:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493115.762934; Fri, 10 Feb 2023 07:07:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQNVI-0007rQ-2W; Fri, 10 Feb 2023 07:07:28 +0000 Received: by outflank-mailman (input) for mailman id 493115; Fri, 10 Feb 2023 07:07:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQNVF-0007Mc-WF for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 07:07:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1b::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91f55e1d-a911-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 08:07:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7029.eurprd04.prod.outlook.com (2603:10a6:20b:118::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 07:07:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 07:07:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91f55e1d-a911-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvRySI0DlVTF9N0PcBcFDb5WDvAdaE1RecI9kJkX3IR5mcoaF+6MqYCvuoUXYU6pGGc/mkC9s7D2mxLf5XDy8zN4/qMicRItfUyH5zxGcvPLeb7JWg7sKCfezsUUtAUn3VbTcILve9ci6cxio9tpDmTxat8Mp1xKiNN5VGJu1A6r/w9fmbZ2kKtcxcYSo9AgqE+bxAM82deVv5jQPhmf10gl2/v3HS23aX9t2v/o/a/PyYydNTSjHLqKKE5S5OtUQPPxAc+Gc7JpzyGcKe7EZKEPrFUT8zuO6j5byISWmSNM757yK4mF1GSsvz5Rm5ianWYgvJLs4fTmZiPvXimftQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xdZufVofTAmzX8PPw6oGCkz3RIXqxNKnbYb4efDk5Lw=; b=e4sCdqRTpzyKfeUDDlGMYiX1p3GmmeCjb0UG/Yb/WroTi4Zm15yMB1Kbg2WTpj35AfvgEiGygzyXv/EHpWJOFLO6NA3EpSBskR/Vl0sBpCe4gyJXjgTEk1aGmIUvn2pfKoK3asZ+OkhAIzzYDhWZ65MmwTJzEQcUddWolorjdkf43uIm/nj5lTAFgoLZ3opJjNquNBPIlZ2/NT3NkWqkbEtxOEgaJPlCd/BWsHBsFdUgFZ39FeiTZh5Ham8f5I7Mq3leOKqNNdbXUe9fE6WGLkKVFHc5LlhOFT+I1g/juCCKCTtVMZitYIigSR2/Zud9IVcEb2m6dEn/1gR8C8qr6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xdZufVofTAmzX8PPw6oGCkz3RIXqxNKnbYb4efDk5Lw=; b=mcTEVxqzPxy/7QRE9U6aGLNB8ZtscPp1053KFGk/S+B+yZyT9OJG50Z7ATvRkXD2FTA3UkppHSduXzpHLoioI0gm4PQVjJh9OC+aq5fGXWzQKdJ8olOPETDfgO5tmuL2oy+e5e+ALlkaGjoA0Qj4r4BqThbiSB4Wbr9IPdZJqD3yuzQQc14K1Gimq6weWjEsfu5QcLaW6RUySg2sKUkZPn8/mTtpIfJSVqk2kSrXpB7C+LRDwIu4o6NGVxbxAdL6QOcTEvfGog2aUUxZwvUftsgHnXLQ00VHLT6wCF3ITUgu17KWVp9nGbACmyTJqLN7iqOOoaLTNQnjYDHfqECyIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 10 Feb 2023 08:07:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 4/4] x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap , "xen-devel@lists.xenproject.org" References: <7d2dd28a-a821-e906-6245-ab26e5518706@suse.com> <7751faad-d281-bdce-60c3-74b17f57313b@citrix.com> From: Jan Beulich In-Reply-To: <7751faad-d281-bdce-60c3-74b17f57313b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7029:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e687a41-a009-4312-fc06-08db0b3574e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2H13tlB4Zr7+QmN+toMbceO7iLSjIdxKzGFR+0/Cjgoh5h9WtGP4PyUtq+ftpUID98hAYC3H5OHzFj804qWCL/5Ak7DZWYRoJdLhgI8iVe/x6V29KJi/RUCy8reatNIe4FZFdplVEG/eQYXrfoImd4CcUrPRquPpLRWQu0VfpH7hyT6f6bQnk9tAKH8QSUyjlxCciuf8nPPVPkG9Aig9FCRuK0TsGoEZ+LH/jV7VtG6WWZdiJz2de71ykPBm1yWSLkTW794yMCEFmBpjGgvuDKoljmr7dwiCowWa8pa6bCPluNN9JFVm22pvOkJTtd+/2M+iQYENurotBzKRF6Tg51lrhY7Rhq6wRPeraukbNW8uSCR3Q/EPnPiUbeBogG8900rITIJW0UMlXqSygPuX1e0ZRZ/nMg3dQkxN990dmSQHS22Jy2NpoPssap53c8SlXmtTZjaI1zqpkwjHHna5c/9gXZHej08KVwdMe3sdASg9rwrC2vcdWpRGl+gQMHCHGPhmpKwm1wJfImwRCCETmuss4FgYhWIJtWKyMdOYMZY2Sr+9UqwC4fR4ssgiCQ7oSxVlkkd2Abz/Azk8nmNrimX3oOkOVV6AOemByWyIj27Lgw5NuMdpNElTnB8hYJZ3vIUEnwnQ6K1rktowFm9Nxz5q6J7VmnBFg/nQRq/RfLHZm4pbCusKhqcucdHjjoW20VFFFQ7Czp03ICkDl7OqfuAENZbqm/aJUsruG2ZRhN8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(39850400004)(346002)(376002)(396003)(451199018)(31686004)(4326008)(8676002)(6916009)(6486002)(54906003)(316002)(66556008)(66476007)(41300700001)(8936002)(66946007)(5660300002)(36756003)(86362001)(31696002)(478600001)(26005)(186003)(6506007)(53546011)(6512007)(2616005)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yno0WVZBemkvMUpCUUYvWTVWdHJtQTBKOUttdlAycDNKZmJuVmxiVkxRM1Jo?= =?utf-8?B?UCtrM2dFQWNKS1dsbTlPOGJoZ1EvMUo5eTlyUjJKVEQxWU1UZ0p1cnU4OFZ1?= =?utf-8?B?MnZVeXBWZXY4cE5HWjI5OHgzRFVTRHh2SjlQOGdMREl4NDE4c0tHUW8zZGVR?= =?utf-8?B?aS9ib2hnc0RUN1FqNkpOL3VtZEZlSFlwYlN1SzBSeWhlVUJVd092amViVUlr?= =?utf-8?B?dzZBb2dLNElkZU5KVnNDSFRkT3hLVGJIaCt4cHF2SEZKd3pxdFdLR0lMUlFS?= =?utf-8?B?VlB0dUJpbXlDc2lpMU1WbCt0eG9SU3RBcnhnQkVVcXU3YXN5SnphcUsrZmIy?= =?utf-8?B?M0FrbFhhRUZ2WXJHMGxacG5nMzQ1d21kMk53ZGJDd1JEdnZISzhqTVRZdCtW?= =?utf-8?B?UHlEaTdIVWhJR3NXSCtGdmtSbS9ncGVDNWFuczNsNHRDSjNNaXk0YXovcXh4?= =?utf-8?B?Rit0YkhRZkVlOEs1ZTRXSW1JR0t6TmZsa2lZTHFYZ1pHdmxrSnpSaG5GUzc5?= =?utf-8?B?cW1SSVBCK2x5V0F5UmFadUxMcDJqN2NzVWhZTjl2NTlLMG9vNTVHaW5FVXhL?= =?utf-8?B?UnVuSWRucWE4Y0NkTk8zZ2x6eWM5YVdiSWxjdVVPR3Ryd0EwVEhCVzRRQ3gw?= =?utf-8?B?ZC9NL2loWnlncFVMUnBzL3JwZWNFOWpNbFN6eGpIVHZDU2tob3RpdGRMZUJO?= =?utf-8?B?N3pQaythOExhVFFBckVMb2hxN3UwZU5IK0xaa3ZHTm45TWFWYno5ZVZOQ2Vn?= =?utf-8?B?OFVoMUhWOHdKY2l3Vjh1bS9KWVFtS0N1QUFGcFFTQXJaWkluTHZyQnpNSUwy?= =?utf-8?B?TEp6MnUrbVFITGxCYVZOaVFFYTk0Q28vS2R4SUx5bVRKOFhETXdMeTFObktS?= =?utf-8?B?bjl4YnNUSjZNR0thOUNnd1JGTmF6WEpBL1k3cTNqZVFwU0VPbkdsV2ZnNUJS?= =?utf-8?B?dzNydUtEWTVrUEVjbHJBWGg4cjZYc1V3eFFQcU5xV2o3QVVFTUVOR0JTdlp0?= =?utf-8?B?VjN2cGtWbW1LSnVmS0RqQmh0OW93UHNGQkJITUFGZFVKbkE2V0c4MVFHUCtn?= =?utf-8?B?L2F6cjlQTEt3NlFWa1VYWVZoVXo1Z0I5azFrZytrVmtLcTZBN0ZNTXp4UzRT?= =?utf-8?B?aU9KL0pqdTZ5ZGp0SUVBeitJcFRtZGQ2YW5FNDcxS0crK1kxTDgvaVZTbkp0?= =?utf-8?B?WU5RK05NRklsUGdXOFp3SXViaWp5d0ZxbTBXQzJvSE1JWjEydDhaT01KZnJZ?= =?utf-8?B?a3laZDBGNjV6NVRLWm15TVpjUnhkY1BNUGR4YU1vVWFTZWd6dmorM2lxWjR0?= =?utf-8?B?Rk54U2FWWWZpRy9ibkFTKytDRW80cEpNdnYxNC93VmNYWVlwUWxNbnRSaUFs?= =?utf-8?B?ZDl5aGhiUnBKR3BlanVVREplUldURldRMHdSNFR4SnRWSHU2UGZqR2RMVVhQ?= =?utf-8?B?WUV4Q3lvVjR2TEZLaWpDUFQ3WmJiMjcvK0tqUE55K3V6S0FiTWxGaC9BbnpP?= =?utf-8?B?cFhreEZpRzBYc2dMNTM2MkpENUNORGFBUHVJV3Q0NlhjV1VSMWVPWmJJTFlD?= =?utf-8?B?ektoNXBRaUM0SmZoQldPcGVTamdhZG1ScHRWOXBvdVVqYmNIQnFyVHk1THUw?= =?utf-8?B?TWd2dzVJZ0JTem5xMS9Edy9zeEF1Y1dsdTJ5MTQ5NE94LzhJQWZBeStnZ3lT?= =?utf-8?B?VnNFVmo5dHUzM05UcXNWSVBzUUhqWGpCdzQzZ0JKUWdyckhNMVV0TlA1dVhN?= =?utf-8?B?S0NBbTNaNk1XKzR6MkJyMkI1cFhmYWFTbVlOSThMZjZwTlZzcnJVT0ZsNHB2?= =?utf-8?B?QVRlMjJ5ZVZrSklqdXprRm1ZSVB3bDVoYVkzUkNqTnBmelZ5cVdvMFVXNVlp?= =?utf-8?B?ZEExYVE4ZlZwWVcrKzRoSmtOU3AwUW5jTlJuVzl5ek8vb2g1QW82Mm1hR1pF?= =?utf-8?B?TG45VS93QUt3MjRlQVZwaHEyMDJBWXUwUHF0Y1VRRzIzM0VyeHZ3azd3OXM4?= =?utf-8?B?ZHBlRThKT0RIOXNtV0s5cUF3Qm1SMHdVdXI1K2ZiTUdWb1BITThIaUxWNjMx?= =?utf-8?B?RUZkd3Y4bnpwY3liZmZINjFCRG5JM1lHWVVFaWljelhpcWUzS2lmUDJmb2Jp?= =?utf-8?Q?+GG+6mu3Ge93YEbVCqeDRgb4b?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e687a41-a009-4312-fc06-08db0b3574e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 07:07:22.7595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lgg3yHz4S3nvvtu57wTjDtX6ehb5Iv63t1stOreSGA4NgUVBm0FAA7GPHGLX3gm8UkWq9pJCJkbSxE/2h7B4kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7029 On 09.02.2023 18:26, Andrew Cooper wrote: > On 08/02/2023 2:38 pm, Jan Beulich wrote: >> First of all move the almost loop-invariant condition out of the loop; >> transform it into an altered loop boundary, noting that the updating of >> _gl2p is relevant only at one use site, and then also only inside the >> _code blob it provides. Then drop the shadow_mode_external() part of the >> condition as being redundant with the is_pv_32bit_domain() check. >> Further, since the new local variable wants to be "unsigned int", >> convert the loop induction variable accordingly. Finally also adjust >> formatting as most code needs touching anyway. >> >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c >> @@ -861,23 +861,22 @@ do { >> /* 64-bit l2: touch all entries except for PAE compat guests. */ >> #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code) \ >> do { \ >> - int _i; \ >> - int _xen = !shadow_mode_external(_dom); \ >> + unsigned int _i, _end = SHADOW_L2_PAGETABLE_ENTRIES; \ >> shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ >> ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ >> - for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ >> + if ( is_pv_32bit_domain(_dom) /* implies !shadow_mode_external(_dom) */ && \ > > As this is a comment, I think can reasonably be > > /* implies !shadow_mode_external */ > > which shortens it enough to maintain the RHS justification. I would certainly have done it without pushing out the escape, but both alternative variants look worse to me: In /* Implies !shadow_mode_external(_dom) */ \ if ( is_pv_32bit_domain(_dom) && \ mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ it isn't clear that the comment applies to only the first part of the conditions, whereas if ( /* Implies !shadow_mode_external(_dom): */ \ is_pv_32bit_domain(_dom) && \ mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ looks more clumsy to me. I'm not very likely to accept a suggestion to for the former route; if you think the latter variant is strictly better than the original, I might make the change while committing. Hmm, or maybe if ( mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ /* Implies !shadow_mode_external(_dom): */ \ is_pv_32bit_domain(_dom) && \ _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ ? Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 10 08:15:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 08:15:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493129.762945 (Exim 4.92) (envelope-from ) id 1pQOYf-0008Gk-8Y; Fri, 10 Feb 2023 08:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493129.762945; Fri, 10 Feb 2023 08:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOYf-0008Gd-5M; Fri, 10 Feb 2023 08:15:01 +0000 Received: by outflank-mailman (input) for mailman id 493129; Fri, 10 Feb 2023 08:14:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOYd-0008GT-EL; Fri, 10 Feb 2023 08:14:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOYd-0007hs-B1; Fri, 10 Feb 2023 08:14:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOYd-0000Bx-2u; Fri, 10 Feb 2023 08:14:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQOYd-0000q7-2N; Fri, 10 Feb 2023 08:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8WKpLO++KSq7PSmjCC96xqVUz+/ol2Q+qJ7WpECXzmE=; b=VApeExlJcOBz7aTQmUtbb0vtGV U4tAztHNZrEgd6GeDKQtb8526UJawdg3dDAZ/lBdtlATULy/j4Ws65qM7f/ZnwaAwCu43NjoCwxmF Mj55C7az2jCFWebnJ9HfnIqA8fFTuUFXLarb9b05MrevBEpn1dGW6Ml17PeXo1Wymgg0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 176755: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=1b6acdeeb2323c53d841356da50440e274e7bf9a X-Osstest-Versions-That: xen=6e081438bf8ef616d0123aab7a743476d8114ef6 From: osstest service owner Date: Fri, 10 Feb 2023 08:14:59 +0000 flight 176755 xen-4.16-testing real [real] flight 176830 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176755/ http://logs.test-lab.xenproject.org/osstest/logs/176830/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 176458 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176458 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176458 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176458 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176458 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176458 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 1b6acdeeb2323c53d841356da50440e274e7bf9a baseline version: xen 6e081438bf8ef616d0123aab7a743476d8114ef6 Last test of basis 176458 2023-02-07 16:39:55 Z 2 days Testing same since 176755 2023-02-09 16:07:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Edwin Török Pau Ruiz Safont jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 1b6acdeeb2323c53d841356da50440e274e7bf9a Author: Andrew Cooper Date: Wed Feb 1 11:27:42 2023 +0000 tools/ocaml/libs: Fix memory/resource leaks with caml_alloc_custom() All caml_alloc_*() functions can throw exceptions, and longjump out of context. If this happens, we leak the xch/xce handle. Reorder the logic to allocate the the Ocaml object first. Fixes: 8b3c06a3e545 ("tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free") Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit d69ccf52ad467ccc22029172a8e61dc621187889) commit 1fdff77e26290ae1ed40e8253959d12a0c4b3d3f Author: Andrew Cooper Date: Tue Jan 31 17:19:30 2023 +0000 tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock released The intf->{addr,len} references in the xc_map_foreign_range() call are unsafe. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called, the C code must not access any OCaml data, nor call any function of the run-time system, nor call back into OCaml code." More than what the manual says, the intf pointer is (potentially) invalidated by caml_enter_blocking_section() if another thread happens to perform garbage collection at just the right (wrong) moment. Rewrite the logic. There's no need to stash data in the Ocaml object until the success path at the very end. Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 9e7c74e6f9fd2e44df1212643b80af9032b45b07) commit 854013084e2c6267af7787df8b35d85646f79a54 Author: Edwin Török Date: Thu Jan 12 11:38:38 2023 +0000 tools/ocaml/xc: Fix binding for xc_domain_assign_device() The patch adding this binding was plain broken, and unreviewed. It modified the C stub to add a 4th parameter without an equivalent adjustment in the Ocaml side of the bindings. In 64bit builds, this causes us to dereference whatever dead value is in %rcx when trying to interpret the rflags parameter. This has gone unnoticed because Xapi doesn't use this binding (it has its own), but unbreak the binding by passing RDM_RELAXED unconditionally for now (matching the libxl default behaviour). Fixes: 9b34056cb4 ("tools: extend xc_assign_device() to support rdm reservation policy") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 4250683842104f02996428f93927a035c8e19266) commit e18faeb91e620624106b94c8821f8c9574eddb17 Author: Edwin Török Date: Thu Jan 12 17:48:29 2023 +0000 tools/ocaml/evtchn: Don't reference Custom objects with the GC lock released The modification to the _H() macro for Ocaml 5 support introduced a subtle bug. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called, the C code must not access any OCaml data, nor call any function of the run-time system, nor call back into OCaml code." Previously, the value was a naked C pointer, so dereferencing it wasn't "accessing any Ocaml data", but the fix to avoid naked C pointers added a layer of indirection through an Ocaml Custom object, meaning that the common pattern of using _H() in a blocking section is unsafe. In order to fix: * Drop the _H() macro and replace it with a static inline xce_of_val(). * Opencode the assignment into Data_custom_val() in the two constructors. * Rename "value xce" parameters to "value xce_val" so we can consistently have "xenevtchn_handle *xce" on the stack, and obtain the pointer with the GC lock still held. Fixes: 22d5affdf0ce ("tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 2636d8ff7a670c4d2485757dbe966e36c259a960) commit 6d66fb984cc768406158353cabf9a55652b0dea7 Author: Andrew Cooper Date: Tue Jan 31 10:59:42 2023 +0000 tools/ocaml/libs: Allocate the correct amount of memory for Abstract_tag caml_alloc() takes units of Wsize (word size), not bytes. As a consequence, we're allocating 4 or 8 times too much memory. Ocaml has a helper, Wsize_bsize(), but it truncates cases which aren't an exact multiple. Use a BUILD_BUG_ON() to cover the potential for truncation, as there's no rounding-up form of the helper. Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Fixes: d3e649277a13 ("ocaml: add mmap bindings implementation.") Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit 36eb2de31b6ecb8787698fb1a701bd708c8971b2) commit 552e5f28d411c1a1a92f2fd3592a76e74f47610b Author: Edwin Török Date: Thu Jan 12 11:28:29 2023 +0000 tools/ocaml/libs: Don't declare stubs as taking void There is no such thing as an Ocaml function (C stub or otherwise) taking no parameters. In the absence of any other parameters, unit is still passed. This doesn't explode with any ABI we care about, but would malfunction for an ABI environment such as stdcall. Fixes: c3afd398ba7f ("ocaml: Add XS bindings.") Fixes: 8b7ce06a2d34 ("ocaml: Add XC bindings.") Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper Acked-by: Christian Lindig (cherry picked from commit ff8b560be80b9211c303d74df7e4b3921d2bb8ca) commit fd1c70442d3aa962be4d041d5f8fce9d2fa72ce1 Author: Edwin Török Date: Tue May 11 15:56:50 2021 +0000 tools/oxenstored: validate config file before live update The configuration file can contain typos or various errors that could prevent live update from succeeding (e.g. a flag only valid on a different version). Unknown entries in the config file would be ignored on startup normally, add a strict --config-test that live-update can use to check that the config file is valid *for the new binary*. For compatibility with running old code during live update recognize --live --help as an equivalent to --config-test. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit e6f07052ce4a0f0b7d4dc522d87465efb2d9ee86) commit f7c4fab9b50af74d0e1170fbf35367ced48d8209 Author: Edwin Török Date: Fri Dec 16 18:25:20 2022 +0000 tools/ocaml/xb: Drop Xs_ring.write This function is unusued (only Xs_ring.write_substring is used), and the bytes/string conversion here is backwards: the C stub implements the bytes version and then we use a Bytes.unsafe_of_string to convert a string into bytes. However the operation here really is read-only: we read from the string and write it to the ring, so the C stub should implement the read-only string version, and if needed we could use Bytes.unsafe_to_string to be able to send 'bytes'. However that is not necessary as the 'bytes' version is dropped above. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit 01f139215e678c2dc7d4bb3f9f2777069bb1b091) commit 049d16c8ce900dfc8f4b657849aeb82b95ed857c Author: Edwin Török Date: Fri Dec 16 18:25:10 2022 +0000 tools/ocaml/xb,mmap: Use Data_abstract_val wrapper This is not strictly necessary since it is essentially a no-op currently: a cast to void * and value *, even in OCaml 5.0. However it does make it clearer that what we have here is not a regular OCaml value, but one allocated with Abstract_tag or Custom_tag, and follows the example from the manual more closely: https://v2.ocaml.org/manual/intfc.html#ss:c-outside-head It also makes it clearer that these modules have been reviewed for compat with OCaml 5.0. We cannot use OCaml finalizers here, because we want exact control over when to unmap these pages from remote domains. No functional change. Signed-off-by: Edwin Török Acked-by: Christian Lindig (cherry picked from commit d2ccc637111d6dbcf808aaffeec7a46f0b1e1c81) commit 8c66a2d88a9f17e5b5099fcb83231b7a1169ca25 Author: Edwin Török Date: Tue Nov 1 17:59:17 2022 +0000 tools/ocaml/xenctrl: Use larger chunksize in domain_getinfolist domain_getinfolist() is quadratic with the number of domains, because of the behaviour of the underlying hypercall. Nevertheless, getting domain info in blocks of 1024 is far more efficient than blocks of 2. In a scalability testing scenario with ~1000 VMs, a combination of this and the previous change takes xenopsd's wallclock time in domain_getinfolist() down from 88% to 0.02% Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont Acked-by: Christian Lindig (cherry picked from commit 95db09b1b154fb72fad861815ceae1f3fa49fc4e) commit c6a3d14df051bae0323af539e34cf5a65fba1112 Author: Edwin Török Date: Tue Nov 1 17:59:16 2022 +0000 tools/ocaml/xenctrl: Make domain_getinfolist tail recursive domain_getinfolist() is quadratic with the number of domains, because of the behaviour of the underlying hypercall. xenopsd was further observed to be wasting excessive quantites of time manipulating the list of already-obtained domains. Implement a tail recursive `rev_concat` equivalent to `concat |> rev`, and use it instead of calling `@` multiple times. An incidental benefit is that the list of domains will now be in domid order, instead of having pairs of 2 domains changing direction every time. In a scalability testing scenario with ~1000 VMs, a combination of this and the subsequent change takes xenopsd's wallclock time in domain_getinfolist() down from 88% to 0.02% Signed-off-by: Edwin Török Tested-by: Pau Ruiz Safont Acked-by: Christian Lindig (cherry picked from commit c3b6be714c64aa62b56d0bce96f4b6a10b5c2078) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Feb 10 08:39:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 08:39:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493142.762961 (Exim 4.92) (envelope-from ) id 1pQOvd-000359-D3; Fri, 10 Feb 2023 08:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493142.762961; Fri, 10 Feb 2023 08:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOvd-000352-9w; Fri, 10 Feb 2023 08:38:45 +0000 Received: by outflank-mailman (input) for mailman id 493142; Fri, 10 Feb 2023 08:38:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQOvb-00034u-Pk for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 08:38:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 510e9ca5-a91e-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 09:38:42 +0100 (CET) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Feb 2023 03:38:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5528.namprd03.prod.outlook.com (2603:10b6:5:2c5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Fri, 10 Feb 2023 08:38:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.017; Fri, 10 Feb 2023 08:38:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 510e9ca5-a91e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676018322; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=f10DM3HQyVPyHarqupCih9gZsKZsEkMc07SwIAc+88U=; b=HLHfsism1caaOIShakVRqg/AdaYwiPGYRmptlfDKDd4HZ69Jg0m3NcSa 24sy5OGV2zKRp88PqWl56IwHU2StqrRToUmDsVSdcOcBIqBCP8Utzgmzv bQb1xLDIDK+pPt4hEBkNj2D5s5FsYhZyH6tKi8CeaTrdYYjUUDTEW7CAY 0=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 95888811 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kRnl/K1oy3sHbYpiD/bD5eJwkn2cJEfYwER7XKvMYLTBsI5bpz0Ex 2AWWWjSOPyJa2ajfo90bt+1/ElV68ODmNA2TVNkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnPagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfIzgQ6 ccCaxI0aivTpuyo8Li5TbF0r5F2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1UZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKmCNJCROThnhJsqH+8zWc4Ej0ZbFX48NybuxGzZugDF WVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMAnsecmSDps0 UWG9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLnW0ophfGT9ImHKvriNTwQGv02 2rT83F4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CFsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:MzYF0KxhE+MgrMgcGdD3KrPw3L1zdoMgy1knxilNoHxuH/Bw9v re+8jzsCWftN9/Yh4dcLy7VpVoBEmslqKdgrNhWYtKPjOHhILAFugLgbcKgQeQeREWntQ36U 4KSdkaNDSfNzlHZcaR2njFLz4jquP3j5xBU43lvglQpQIBUdAQ0+9gYDzrdHGf3GN9dOAE/J z33Ls/mxOQPU45Q+6cHXc/U+3Kt7Tw5e/biU5vPW9e1OGW5wnYk4LHLw== X-IronPort-AV: E=Sophos;i="5.97,286,1669093200"; d="scan'208";a="95888811" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqBRDU7/ngQVdusYVytnS9hLWDpGNgRo6m7OMEEdf2ZUx+BO3Ti6cXI2ExZ8Rz6Wm13b3VBTYqErljT5y5XzEfHBpP3RGX7LzVMDITEUTLX3+Oz3+vbZWFkzSSrfZy9mUULauEvj0OF4lBM9vVAUIl59Eft512uaAS01O0FNHvSgUoNbgh/+AI63R0UB8lI6ikAdo5PcquEJ73XPGhv/hn+y52bNAIrWDeQir5qCO5KzfXfJeUZW4lHyQvLQCnIfndLOMgyPFdOCsz9IC/gPaypQSkt39/KcQ+EKPYIBAWTgBZIKgifQDIAS+1PXtmJhvKraJZFbbGd2dLduYjlrgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wse9i7PQQCT7mpq4yHOBI6RpsTexJCJeYMFvDaMso+Q=; b=c54yijjnmYpyKeyueiLmzjHb7UWIx69aqLsSmfAPnt3aq83sHcGBGicQjOqgisVIohQP+D+gOVlpgVG4/Fe9zxFg7fAOl+W+m7QT1V+dJoLRfU38xoosJltK+qNrdGbAaJC9k1qXxna/la9yLGY52yLPhlFSvkqsG37KXpV2cnpDsJ85tinsQ0vHpk0ZMAW8Uc3rwB78A4Xcm9AGclv6BJ2wvr0UlCVzhq35RKBIHDz3M2509MBAjk4sowzB9sTUjajHGI9HJbO0kp1OUO2BaV/t+f2HIQYL4J+XZVjtxM1uqocke79pIL59PdW8Qt/KJsshBC7Efk1ckc+A+POaow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wse9i7PQQCT7mpq4yHOBI6RpsTexJCJeYMFvDaMso+Q=; b=O/yuOATYbIpjofcV87LjFaRYxlmhfe6Z0jKvvTqws2EKWWVXmC3jB5X+4kA37OrmG2+Em6hvRXeTt1VtSpT+fz+dUQH6Hk6NiijXtoxw8PY418TF3CzuChOVCavSCbx6Be0gTUIJx06FZT3sQD+g+lQaokqx3Sv513dWvPLm8PY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 10 Feb 2023 08:38:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 4/4] x86/shadow: re-work 4-level SHADOW_FOREACH_L2E() Content-Language: en-GB To: Jan Beulich Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap , "xen-devel@lists.xenproject.org" References: <7d2dd28a-a821-e906-6245-ab26e5518706@suse.com> <7751faad-d281-bdce-60c3-74b17f57313b@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0652.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5528:EE_ X-MS-Office365-Filtering-Correlation-Id: 68682012-d528-489b-010c-08db0b42308d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L5KLEMejbC+Jw/fdEz75P/ExAeR3qB1ST9aPPUFysI2NXxj7OzoxaS4SQZFNSccCf5skChOtZcco5Eof8c3zOxFLNL82GUlBnRGgd2zASgZbiE1vpHf82iFepGCioOFci/IDj6aXo2l2qfA8UyW9wGm+iK388bYTS81w4j5ocx2hvqzeXJJ6DxwpZ8shZMZcMZIvi9Fs/3BahTV1nYnTCkHUOayhbXJOppj60wBkIGVnLQIRubB2GA7EftmL+dWccP8Rn4bKmsb51krhHbDdO9aKocOaQ7B9sE4aKpi+NWNtr5W0tluSM/+hTgHbnwM9olOujN4BA/yCdemj8L0wIsYlXqeIeSAf2JQ1CtLOT0QL2fOgZoQfDrhwTHbxf2AmyDdAtqjBXD3AgfWmx4Wpa5C3U2ekr6xTHjC16fWjwhUd72PqkQETi49rNJ9YMmBO689Za/wOqkKxb1hmoe7eQ9swTcr3xt+K/Ol8OhjMX5OV8REenpblbsFwWT+jSveB6Afe4JmiEEawYtCw0z2AomcZk/qCLGzXbsEkxpNorxXypXyOx6XqdGkEqEO216MWVzLYjfqSmvLVitOYDjqupxx6Rob9rQ7EyIet6G32FN/x0JLkBd2tIHSkKa+1FgcVmlKdKBbZe55yyEVv5ATrRQgavhVxVE4ekxhGmooJ59vO2cvxkjxgJz9u99PQi90kPC4AnlZRTQuKJj41SWN3MoG7eMdCf+oJ8DW55Nu2TP8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199018)(31686004)(4326008)(86362001)(8676002)(66476007)(66946007)(66556008)(6916009)(38100700002)(82960400001)(2616005)(41300700001)(26005)(6512007)(186003)(2906002)(478600001)(8936002)(6506007)(53546011)(316002)(6666004)(6486002)(31696002)(5660300002)(54906003)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFpBWVBJbi82VGlOZ2FoS0tWb056aU9VOUlrbVVJK0llSThWSkVzdlNaeXox?= =?utf-8?B?c2VGM01HVlhWbzczbEVLdHk0b3V2MjNqVVpQVmpyYjQ5OXFrMVJSeE1QTU4z?= =?utf-8?B?ZW52SW5xaGErZjZtZ3RCRWRTbVh3YTJmTjNoNmpKRFhwMDN3amtNTTVhVzZS?= =?utf-8?B?ektoaFFOSG5zcG1kUFZiSllyNHhBTU5zYVdCbzhVQ01pYXhxeEtjdFJzT0Uw?= =?utf-8?B?QVFHaWR5eUlpdWRicUhvOS92QVMweVk2NzVyRFk5d0QvUmhUVVBxM1J2Mm5G?= =?utf-8?B?M29pWmd4b2pMMGdtWTlNK2ZacU1JQ05EdURhMEczL3llUDlieGJxdFhCaDFW?= =?utf-8?B?SGg5a096Vk9hc09lVTFHekV1QTBKc21DT2d6ajRKOG8rTHJjMjVqK1NEb1Bn?= =?utf-8?B?MEJPYXE0SW5xcnNPYmNlTDBLY3hKRzYybS94dnNkbUVWcGJIUjVNRmNkUENo?= =?utf-8?B?bEgzMnFhdTh6TVlEcHUwRWx0T01zNTdQb1NjckdEYVN3bmE1OURybkVydDRo?= =?utf-8?B?b2tDYW96Uy82V1FsRzJrWVA3YU1QM1NFSlRwWkRlT09SbjZFdW9PbkxzY080?= =?utf-8?B?MzFFR1k2OWtjVFphRndQSzlXeCtBTzdYWkN2UnhhNklQM2pycVBiVUMrK1Jz?= =?utf-8?B?NGJ5TWZ0bzhlUlNzdFlHWGxwRHgwZ2hhRnBhZUlpR3ZnVUlELzlrdFluNkpJ?= =?utf-8?B?dDd6NUZ1Z0sva0drOXlRSnBaL2FGWVZ6YWQwU094TldacnJHOTN1NDFnSHlw?= =?utf-8?B?Mi9kUFF1YXN5TE1XeXVUenZtY0NYK3FxbUVpRWZTWnFIK0hwNC8rM282Q3JI?= =?utf-8?B?STVRa1o1aGcySDFMUFVTZXdrTUo3V1NSaHdUNDgvYWxLSWZvdWFhb1JkSkVq?= =?utf-8?B?WTZadTg0VTZIZy96ZGFwNlFSS1BnRVZDM2hYUlBzQ1FqL2JlWGdoTW5kV3NR?= =?utf-8?B?Y0dOWVpNZmU4b3JtNlBOY0tJZXRxcjc1OG1WVjZJN3NtZk1NazFQZGFxN1Jn?= =?utf-8?B?T1dUT1kzcEoyVlRFMWNUQzZVSEcrTWpwL2RjbW8wclJsY29nZHBscEMvaFA1?= =?utf-8?B?dFZWeVRvejNzWjI2WmpNcHU5MnFKZHVrMUZHZ1VVc3A5bHFjZ2JKTFc3RG91?= =?utf-8?B?Qyt0VFB3ZjVDcklaUnNzQ2JmU3o3Q2FJdDFrUFg0c0kyTEJSZFBaWnJZZ3U2?= =?utf-8?B?YmVsbXV2RFVxVVgxNTFhMzVnbTZGeDFWaUt5emxmanR5SEJWKzRzUUd6NzV1?= =?utf-8?B?YUFWVmVCdGZ3UW45WCtXZDBpK0tSM0kzeXgwTmpXK3B4MzBkeWZPL1NwNEpX?= =?utf-8?B?N3VYMXVScTJGVFhma1FGTGxkbExrYXppeUc5a2lNVG1mSk02b3RJME9KL0pP?= =?utf-8?B?OVArc2NuUjBXcVVHMGtKaS9nams3eVkvQjQwVitEazBOcW9LbXZDdVBrR1Zp?= =?utf-8?B?QlRaWUtEVHNIS0NFbmJ5SXZ1aWRyN1lTMDRlc0M0cTJYNE55aXoxWTZQTkZ2?= =?utf-8?B?SWZQUUdsY0hqYjlYMURIbHo5SzFFV1BweXpBVEVyYi81cmNkZklGT09XdTJ0?= =?utf-8?B?ejA0eXdkWSt0L1FzeFJKYm5oYnVHL0RXTzErMGZ6N2ozeFoxdG1yVDZLYWg5?= =?utf-8?B?L0VVd2I2dnFqVW9ENlhUOTFvejREKy9yaE83R0tRemJRdjFjMjhIMkpmQkVq?= =?utf-8?B?NHV2aWlzczRZTWNTdTBia0JQekZ0eUc4VG5lK1YxSTNnS3BPYlNsZ3NLMzdk?= =?utf-8?B?VVBpMlFCMy9JRGJQdk14TzVleTZQOTVWbE8rNkpENWdjcmlHWTNOcjF0TlQw?= =?utf-8?B?M3d2M3Bsem94WEUrKzg0ZDY5RkdGYnNoTHJXcldXQjcrdHliVEp6ZS8yeWx2?= =?utf-8?B?a3ZnVUtNSE5pWG1OL2huOEVPY2Vod0dQVEdVRzhvOU1ieWhsQmM3YmFSeWZh?= =?utf-8?B?UFFtd21iemtCU0hYR2JhMjJaSDFBOWx3ZUljZTNqOFRlL2NoTitzZVRWZEQy?= =?utf-8?B?a0pTTWZsZ01TbnY1SW1iYnJjbjVSZ05Dc05RZXpLbjJKOEdaajlzT0JvSXJp?= =?utf-8?B?MTlENElHSTYzSEZackpTLzl0MjdmTWdSaC9Jbk5pZEJnVmVDdjU2UGJFdTdj?= =?utf-8?B?ZStBUStVallnZy9ZVzdUMjI0TUhqMW10cjB6Wk5ja3dXNFBFM2FuOHVteDE0?= =?utf-8?B?cHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LbF8DqgqnW8+fHZMm36l5j02s+fHzGx1B8tH+jzm3SX/Gi5u0bLaLC3O4Ds6olwdVPTnB6SSHfLbdJkpJWf1VSxDl89iKdQWMpM2y+TwbKtUTLttiwoZ03/81lJvlHzvDjia0vzww7z4oGroSYM8PW9VTntsgpXe/uWyW9d4SHdciOwGMy0SaxST9SaSL/jSxKsOK9u4yOXU0muxtA/2oe+NOBG8cdjEdP5y++Z325MzPC9DQe2ogoJshpR07ids/x/hbdwboTLMy80tgYRZm54EijRiekqBYJU+Ws1gIcapYLyivzN/iJLnnchBemo9r9Zr313N745Efdlc6YgQ6nX+z8Z0Y34wbN3UXOGhcepb+uK3J+ymP+Ki7dCBJkl7FT4SmWp9G7o5wOBW3zdm/M9iIACcri3glMpiK+P1xG1hExfNwpj7Qwl84W5bupWddHjEeXRmP4yo5x3HpxkJxmGipPDYlm9lQpBHmvXtXu8zRNfqsTZdSf8nmlhJ1N9wv8k/0jcw+X+HI00H3j1HyzoJlPGG5EInWFtjHW3odta1Qt0U9DSqUDLK/OMxPWk9orXuZQcT24yK0Mdvpo5hzIhUMa0bXoSRR9t3Y9Ac08PMYpd3DF9knlr1ngk85dg2KkhrAsj9VDfrCzzJJNUaRhApi/yFjwEUZA4jFckBzQQd490v99ukPfm0R7XOx8vswX+V9Ilh0U7lOVAFYpP8Y15+zOiGo/U2n9462+7VEIIEsAyWAqCB/4cK7cDRHbYPSw5wAXCEQAME1rykRM3fzBScxmrCnIGoUmPGaHzT5SQfX6/FF4lGbjMCRmZGPYum X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68682012-d528-489b-010c-08db0b42308d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 08:38:31.6476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zpHQHylnAF1nKZPjfALtnKT8jv2B6B1/5bvHERHBQGdQlhpXqydT3GmB0mnKbQAdHKUSvOgBOHLWddYqRiJHVv60sARrCtmmQxYLwlYy3eQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5528 On 10/02/2023 7:07 am, Jan Beulich wrote: > On 09.02.2023 18:26, Andrew Cooper wrote: >> On 08/02/2023 2:38 pm, Jan Beulich wrote: >>> First of all move the almost loop-invariant condition out of the loop; >>> transform it into an altered loop boundary, noting that the updating of >>> _gl2p is relevant only at one use site, and then also only inside the >>> _code blob it provides. Then drop the shadow_mode_external() part of the >>> condition as being redundant with the is_pv_32bit_domain() check. >>> Further, since the new local variable wants to be "unsigned int", >>> convert the loop induction variable accordingly. Finally also adjust >>> formatting as most code needs touching anyway. >>> >>> Signed-off-by: Jan Beulich >> Acked-by: Andrew Cooper > Thanks. > >>> --- a/xen/arch/x86/mm/shadow/multi.c >>> +++ b/xen/arch/x86/mm/shadow/multi.c >>> @@ -861,23 +861,22 @@ do { >>> /* 64-bit l2: touch all entries except for PAE compat guests. */ >>> #define SHADOW_FOREACH_L2E(_sl2mfn, _sl2e, _gl2p, _done, _dom, _code) \ >>> do { \ >>> - int _i; \ >>> - int _xen = !shadow_mode_external(_dom); \ >>> + unsigned int _i, _end = SHADOW_L2_PAGETABLE_ENTRIES; \ >>> shadow_l2e_t *_sp = map_domain_page((_sl2mfn)); \ >>> ASSERT_VALID_L2(mfn_to_page(_sl2mfn)->u.sh.type); \ >>> - for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ ) \ >>> + if ( is_pv_32bit_domain(_dom) /* implies !shadow_mode_external(_dom) */ && \ >> As this is a comment, I think can reasonably be >> >> /* implies !shadow_mode_external */ >> >> which shortens it enough to maintain the RHS justification. > I would certainly have done it without pushing out the escape, but both > alternative variants look worse to me: In > > /* Implies !shadow_mode_external(_dom) */ \ > if ( is_pv_32bit_domain(_dom) && \ > mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ > _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ > > it isn't clear that the comment applies to only the first part of the > conditions, whereas > > if ( /* Implies !shadow_mode_external(_dom): */ \ > is_pv_32bit_domain(_dom) && \ > mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ > _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ > > looks more clumsy to me. I'm not very likely to accept a suggestion to > for the former route; if you think the latter variant is strictly > better than the original, I might make the change while committing. > > Hmm, or maybe > > if ( mfn_to_page(_sl2mfn)->u.sh.type != SH_type_l2_64_shadow ) \ > /* Implies !shadow_mode_external(_dom): */ \ > is_pv_32bit_domain(_dom) && \ > _end = COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(_dom); \ > > ? I simply meant: -    for ( _i = 0; _i < SHADOW_L2_PAGETABLE_ENTRIES; _i++ )                  \ +    if ( is_pv_32bit_domain(_dom) /* implies !shadow_mode_external */ &&   \ (If this renderers properly.) It is not important for the comment to be syntactically valid C, especially as you're saying one predicate implies the other. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 10 09:24:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 09:24:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493182.762989 (Exim 4.92) (envelope-from ) id 1pQPdN-00012j-2c; Fri, 10 Feb 2023 09:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493182.762989; Fri, 10 Feb 2023 09:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQPdM-00012c-Vz; Fri, 10 Feb 2023 09:23:56 +0000 Received: by outflank-mailman (input) for mailman id 493182; Fri, 10 Feb 2023 09:23:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQPdL-00012W-0l for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 09:23:55 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1cb642c-a924-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 10:23:51 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id m14so4356097wrg.13 for ; Fri, 10 Feb 2023 01:23:51 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id l3-20020a5d6683000000b002bdf3809f59sm3163585wru.38.2023.02.10.01.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 01:23:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1cb642c-a924-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=fF4hictUgKkFuGyL59Ei48VpWVLxxgngBHdigpfEiME=; b=duJ1DSMCfr7hlQl0TQVMdkDt3UZ+bNrrey6Yz+MtO8p7v+ABqBBRe6w5dHDr27ujlR SocaXsf4M4nUizkwGCDwYqpehIb+jUwAccjBGgVNhNO2sYqizyLQBF13ku4CDz1N3+Ad H7r/kBcXyQ59rZe7w26MgHMbJTwQMlmQQxwalmTB1KIGldjXl3OhLAYceM2G8QOYN/dX 2oJcR+HyLqoSXKbL8YrbF1QbUiirDnc39jdP/2vdM1wDPq/KuX3yldHUlEXOgPL4k/vV dfi+oVHlPsK7435FBEEgWnVkWVZCOVdc8gSR7xj3yu0+UmIlMXaZyp25LuEhQIFLCpQl UO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fF4hictUgKkFuGyL59Ei48VpWVLxxgngBHdigpfEiME=; b=6s1MkXQwiTXJ9H+7u/4AFURDkQxLGBf63xPpwdVxdWXA4MRJbNXB8TlHhwRMi6dizG HyLIOrUBaibioYUYy71Eh93vR9r3i9n02LMz6dr7P9oK/23Ba8ulmxxZZjKu9fw7eW/a KxzDRLm0LvtezDZSW2pr4nxfSY81hcDQVzu3MBM6EX+iSV00FSlxmzwKdUp1UVjjuZnl 4/YMWdlx85f4oYqRLGR29UzhXTig1VZZBjQqPutQc36bcusdSey+80mghGJ25mkxmrlx ZcfojL+IUdyJKzZtJij5hG0Su+6QEF+ED1ii3gKKt6wYeuG7MrxyTLNsV+W3420feBF5 aEaQ== X-Gm-Message-State: AO0yUKXWEb3+xMhfSlXDNHtG00bJmE9aP3o6xKH2cEGZvUuDeOI4T18d 5VXJSKx8CYbNtQoGoZDcrSA= X-Google-Smtp-Source: AK7set8BLx4nSmBaP4NS+B/ULkskAuTrLs2OXN6QKAoOwzOOQFkfsdcQHFzoD/zd9p/IT3CYDp4njw== X-Received: by 2002:a5d:4c44:0:b0:2c3:e4f5:17f with SMTP id n4-20020a5d4c44000000b002c3e4f5017fmr15559606wrt.33.1676021031281; Fri, 10 Feb 2023 01:23:51 -0800 (PST) Message-ID: <13c3a5fbf6528ce6232be5ed56c8449a90e5c3ad.camel@gmail.com> Subject: Re: [PATCH v3 09/14] xen/riscv: introduce decode_cause() stuff From: Oleksii To: Alistair Francis Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Fri, 10 Feb 2023 11:23:48 +0200 In-Reply-To: References: <0198e2a5b572b9031eafe7cd1c85c6f9537b704c.1675779308.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-10 at 12:00 +1000, Alistair Francis wrote: > On Wed, Feb 8, 2023 at 12:48 AM Oleksii Kurochko > wrote: > >=20 > > The patch introduces stuff needed to decode a reason of an > > exception. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > > =C2=A0 - Nothing changed > > --- > > Changes in V2: > > =C2=A0 - Make decode_trap_cause() more optimization friendly. > > =C2=A0 - Merge the pathc which introduces do_unexpected_trap() to the > > current one. > > --- > > =C2=A0xen/arch/riscv/traps.c | 85 > > +++++++++++++++++++++++++++++++++++++++++- > > =C2=A01 file changed, 84 insertions(+), 1 deletion(-) > >=20 > > diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c > > index ccd3593f5a..f2a1e1ffcf 100644 > > --- a/xen/arch/riscv/traps.c > > +++ b/xen/arch/riscv/traps.c > > @@ -4,10 +4,93 @@ > > =C2=A0 * > > =C2=A0 * RISC-V Trap handlers > > =C2=A0 */ > > +#include > > +#include > > =C2=A0#include > > =C2=A0#include > > +#include > > +#include > >=20 > > -void do_trap(struct cpu_user_regs *cpu_regs) > > +static const char *decode_trap_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 static const char *const trap_causes[] =3D { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_FETCH] = =3D "Instruction Address > > Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_ACCESS] =3D "I= nstruction Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_ILLEGAL_INSTRUCTION]= =3D "Illegal Instruction", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_BREAKPOINT] =3D "Bre= akpoint", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_LOAD] =3D= "Load Address Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_ACCESS] =3D "Lo= ad Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_STORE] = =3D "Store/AMO Address Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_ACCESS] =3D "S= tore/AMO Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_USER_ECALL] =3D "Env= ironment Call from U-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_SUPERVISOR_ECALL] = =3D "Environment Call from S-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MACHINE_ECALL] =3D "= Environment Call from M-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_PAGE_FAULT] = =3D "Instruction Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_PAGE_FAULT] =3D= "Load Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_PAGE_FAULT] = =3D "Store/AMO Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_GUEST_PAGE_FAU= LT] =3D "Instruction Guest Page > > Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_GUEST_PAGE_FAUL= T] =3D "Load Guest Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_VIRTUAL_INST_FAULT] = =3D "Virtualized Instruction > > Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_GUEST_PAGE_FAU= LT] =3D "Guest Store/AMO Page > > Fault", > > +=C2=A0=C2=A0=C2=A0 }; > > + > > +=C2=A0=C2=A0=C2=A0 if ( cause < ARRAY_SIZE(trap_causes) && trap_causes= [cause] ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return trap_causes[cause]; > > +=C2=A0=C2=A0=C2=A0 return "UNKNOWN"; > > +} > > + > > +const char *decode_reserved_interrupt_cause(unsigned long > > irq_cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 switch ( irq_cause ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_SOFT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode Software Int= errupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_TIMER: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode TIMER Interr= upt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_EXT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode TIMER Interr= upt"; >=20 > Wrong string here >=20 > Alistair Nice catch. Thanks. >=20 > > +=C2=A0=C2=A0=C2=A0 default: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "UNKNOWN IRQ type"; > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > +const char *decode_interrupt_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 unsigned long irq_cause =3D cause & ~CAUSE_IRQ_FLAG= ; > > + > > +=C2=A0=C2=A0=C2=A0 switch ( irq_cause ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_SOFT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor Software= Interrupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_TIMER: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor Timer In= terrupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_EXT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor External= Interrupt"; > > +=C2=A0=C2=A0=C2=A0 default: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return decode_reserved_inte= rrupt_cause(irq_cause); > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > +const char *decode_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 if ( cause & CAUSE_IRQ_FLAG ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return decode_interrupt_cau= se(cause); > > + > > +=C2=A0=C2=A0=C2=A0 return decode_trap_cause(cause); > > +} > > + > > +static void do_unexpected_trap(const struct cpu_user_regs *regs) > > =C2=A0{ > > +=C2=A0=C2=A0=C2=A0 unsigned long cause =3D csr_read(CSR_SCAUSE); > > + > > +=C2=A0=C2=A0=C2=A0 early_printk("Unhandled exception: "); > > +=C2=A0=C2=A0=C2=A0 early_printk(decode_cause(cause)); > > +=C2=A0=C2=A0=C2=A0 early_printk("\n"); > > + > > =C2=A0=C2=A0=C2=A0=C2=A0 die(); > > =C2=A0} > > + > > +void do_trap(struct cpu_user_regs *cpu_regs) > > +{ > > +=C2=A0=C2=A0=C2=A0 do_unexpected_trap(cpu_regs); > > +} > > -- > > 2.39.0 > >=20 > >=20 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 09:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 09:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493192.763000 (Exim 4.92) (envelope-from ) id 1pQPog-0002yr-3T; Fri, 10 Feb 2023 09:35:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493192.763000; Fri, 10 Feb 2023 09:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQPog-0002yk-0x; Fri, 10 Feb 2023 09:35:38 +0000 Received: by outflank-mailman (input) for mailman id 493192; Fri, 10 Feb 2023 09:35:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQPoe-0002ye-NS for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 09:35:36 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44eec9a1-a926-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 10:35:35 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so5831260wma.1 for ; Fri, 10 Feb 2023 01:35:35 -0800 (PST) Received: from [192.168.8.199] (46.204.104.21.nat.umts.dynamic.t-mobile.pl. [46.204.104.21]) by smtp.gmail.com with ESMTPSA id p1-20020a1c7401000000b003cfa622a18asm7803974wmc.3.2023.02.10.01.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 01:35:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44eec9a1-a926-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pB+VdG7PJklnLwo9yvMgFdwLNlutsCER1KpWKkOLKiE=; b=g4hj8VC4JVfC6FFFGnc7d4IczlKZCpoy5eEzIXeyggcB6JyyEHq4G0xF0+yta6fysJ ODrjsWNH7rRRW6Rvouui7xzXXMPz/8pSJpyyk5kpGJFblo/4hU3cKVLKCZylFJYEGyly 2dX14MGqZ0XilQOT10nneKCMxCtBZ5a00f8Oi7jo3G2jp37hDRKeBthfiLcLinhQyC4D LJSR1HEHmss7ZSFoXKI5f01zOpdfpTsRQB6TMW+y+BX44MSe9nDkKdYzdc0D7eurD46Y PWu4sk7aSYZnstV/AwLi+yBa4L24ShRfDfHOGzTiJVmYCb1JCMT3ySBvVqYwliWU1Ze0 +JIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pB+VdG7PJklnLwo9yvMgFdwLNlutsCER1KpWKkOLKiE=; b=vCYhaCzw6q/Ld34vlXuO7DXm5nL/D/T52f164ECUFtZysdnrt1ctrdQyZhkwlurgac MbuKcUZdb3EQYxbleRkYfwR3B6BZARa/6EqHgNJx19No7CMGyKB6TSWhSSh/RuSBsl0f 1lQE+7s54rt0sNmN6LzTuk3pKz1PpA9dkugrIx+F0ZuFuc9QeyPFXdf+PVTj7D9p+m/r EWISaA8S1LY55+djampI21vpw1EenVf+oX1vnQjtMMUV8v9JtSgEgbUzSGSLe5Qu54St 3H4x83plng50fawnAzFkycOEs9rs1r4z4ifkC1VbsNR6/Bpg/ObkV0sl5FOX5AwbuxdW 5BVQ== X-Gm-Message-State: AO0yUKVvEdG9RIZQHYUvqDX08u+vdAsteZ9G4/7uRc48RLygSuQjoMEg OcSIe0jF58HGVW4ycHtLEjc= X-Google-Smtp-Source: AK7set9Vw8pAgwCIMJgTkdtevj3haVyWnyEoOxgdVL8UvOLH2TJE1XajRXPSTD12GZsunv+T97Srqw== X-Received: by 2002:a05:600c:1713:b0:3dc:5b88:e6dd with SMTP id c19-20020a05600c171300b003dc5b88e6ddmr13890439wmn.10.1676021734919; Fri, 10 Feb 2023 01:35:34 -0800 (PST) Message-ID: <448b79128a0f010af40f9f063a341cbdca17f206.camel@gmail.com> Subject: Re: [PATCH v3 09/14] xen/riscv: introduce decode_cause() stuff From: Oleksii To: Alistair Francis Cc: xen-devel@lists.xenproject.org, Jan Beulich , Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Fri, 10 Feb 2023 11:35:32 +0200 In-Reply-To: References: <0198e2a5b572b9031eafe7cd1c85c6f9537b704c.1675779308.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-10 at 12:00 +1000, Alistair Francis wrote: > On Wed, Feb 8, 2023 at 12:48 AM Oleksii Kurochko > wrote: > >=20 > > The patch introduces stuff needed to decode a reason of an > > exception. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > > =C2=A0 - Nothing changed > > --- > > Changes in V2: > > =C2=A0 - Make decode_trap_cause() more optimization friendly. > > =C2=A0 - Merge the pathc which introduces do_unexpected_trap() to the > > current one. > > --- > > =C2=A0xen/arch/riscv/traps.c | 85 > > +++++++++++++++++++++++++++++++++++++++++- > > =C2=A01 file changed, 84 insertions(+), 1 deletion(-) > >=20 > > diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c > > index ccd3593f5a..f2a1e1ffcf 100644 > > --- a/xen/arch/riscv/traps.c > > +++ b/xen/arch/riscv/traps.c > > @@ -4,10 +4,93 @@ > > =C2=A0 * > > =C2=A0 * RISC-V Trap handlers > > =C2=A0 */ > > +#include > > +#include > > =C2=A0#include > > =C2=A0#include > > +#include > > +#include > >=20 > > -void do_trap(struct cpu_user_regs *cpu_regs) > > +static const char *decode_trap_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 static const char *const trap_causes[] =3D { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_FETCH] = =3D "Instruction Address > > Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_ACCESS] =3D "I= nstruction Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_ILLEGAL_INSTRUCTION]= =3D "Illegal Instruction", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_BREAKPOINT] =3D "Bre= akpoint", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_LOAD] =3D= "Load Address Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_ACCESS] =3D "Lo= ad Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MISALIGNED_STORE] = =3D "Store/AMO Address Misaligned", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_ACCESS] =3D "S= tore/AMO Access Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_USER_ECALL] =3D "Env= ironment Call from U-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_SUPERVISOR_ECALL] = =3D "Environment Call from S-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_MACHINE_ECALL] =3D "= Environment Call from M-Mode", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_PAGE_FAULT] = =3D "Instruction Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_PAGE_FAULT] =3D= "Load Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_PAGE_FAULT] = =3D "Store/AMO Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_FETCH_GUEST_PAGE_FAU= LT] =3D "Instruction Guest Page > > Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_LOAD_GUEST_PAGE_FAUL= T] =3D "Load Guest Page Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_VIRTUAL_INST_FAULT] = =3D "Virtualized Instruction > > Fault", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [CAUSE_STORE_GUEST_PAGE_FAU= LT] =3D "Guest Store/AMO Page > > Fault", > > +=C2=A0=C2=A0=C2=A0 }; > > + > > +=C2=A0=C2=A0=C2=A0 if ( cause < ARRAY_SIZE(trap_causes) && trap_causes= [cause] ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return trap_causes[cause]; > > +=C2=A0=C2=A0=C2=A0 return "UNKNOWN"; > > +} > > + > > +const char *decode_reserved_interrupt_cause(unsigned long > > irq_cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 switch ( irq_cause ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_SOFT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode Software Int= errupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_TIMER: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode TIMER Interr= upt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_M_EXT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "M-mode TIMER Interr= upt"; >=20 > Wrong string here >=20 > Alistair >=20 Nice catch. Thanks a lot. > > +=C2=A0=C2=A0=C2=A0 default: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "UNKNOWN IRQ type"; > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > +const char *decode_interrupt_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 unsigned long irq_cause =3D cause & ~CAUSE_IRQ_FLAG= ; > > + > > +=C2=A0=C2=A0=C2=A0 switch ( irq_cause ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_SOFT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor Software= Interrupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_TIMER: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor Timer In= terrupt"; > > +=C2=A0=C2=A0=C2=A0 case IRQ_S_EXT: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "Supervisor External= Interrupt"; > > +=C2=A0=C2=A0=C2=A0 default: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return decode_reserved_inte= rrupt_cause(irq_cause); > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > +const char *decode_cause(unsigned long cause) > > +{ > > +=C2=A0=C2=A0=C2=A0 if ( cause & CAUSE_IRQ_FLAG ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return decode_interrupt_cau= se(cause); > > + > > +=C2=A0=C2=A0=C2=A0 return decode_trap_cause(cause); > > +} > > + > > +static void do_unexpected_trap(const struct cpu_user_regs *regs) > > =C2=A0{ > > +=C2=A0=C2=A0=C2=A0 unsigned long cause =3D csr_read(CSR_SCAUSE); > > + > > +=C2=A0=C2=A0=C2=A0 early_printk("Unhandled exception: "); > > +=C2=A0=C2=A0=C2=A0 early_printk(decode_cause(cause)); > > +=C2=A0=C2=A0=C2=A0 early_printk("\n"); > > + > > =C2=A0=C2=A0=C2=A0=C2=A0 die(); > > =C2=A0} > > + > > +void do_trap(struct cpu_user_regs *cpu_regs) > > +{ > > +=C2=A0=C2=A0=C2=A0 do_unexpected_trap(cpu_regs); > > +} > > -- > > 2.39.0 > >=20 > >=20 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:02:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:02:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493205.763011 (Exim 4.92) (envelope-from ) id 1pQQEp-0006wh-9z; Fri, 10 Feb 2023 10:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493205.763011; Fri, 10 Feb 2023 10:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQEp-0006wa-7O; Fri, 10 Feb 2023 10:02:39 +0000 Received: by outflank-mailman (input) for mailman id 493205; Fri, 10 Feb 2023 10:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQEn-0006wQ-MP for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:02:37 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a6dc517-a92a-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:02:35 +0100 (CET) Received: by mail-lj1-x235.google.com with SMTP id y19so5462769ljq.7 for ; Fri, 10 Feb 2023 02:02:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a6dc517-a92a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tJHHiFB6XTRc5bRBoVCvpiltWq8Bcwgzl8DV3TsVtdE=; b=arPkwq2x/OrO4FYavOalh4uFpS8gMk3a7BOTCHZwXD/txt2wEwdsS0Bn7SigQEt2xy BIRKX7T+/YQtwoBQpy8V5gqr5KL+lbKsOGJn2nYugPI9atnh02YBpoEh32LtoqNG2u0A k/GE3nA5zLkxo/om/hFCrkVUs2fREDjt4iKYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tJHHiFB6XTRc5bRBoVCvpiltWq8Bcwgzl8DV3TsVtdE=; b=1sQiCWXDQtj9VQo1G+y7iFpjRoNzNUKS9jjheljKELSANl6rFaUVV0Fsu6qF/yJoe3 RyIuvskG7y48DPA2v3LqFc3loQBnEbR6xH98KMlPVX8ng5LxVD35mSMnOh7YHWOkUmoI /ZvWgOHO27LaHZto3KXF00HVSYQivpDTSDvQMGRTXlsylLTa2WdDiLwp/fgP+of2/teb H+muOevPnHG3LBH62euc+6S1UqajH4NGDsJEahjxCCxYNHbx4gQ4Btl8SzQAjq0xMDUK 3DUnKsmLcSBScvif4nUmrqZ2Lsh7KWqilMPvTIPWK5iQR8K7KEWZ8eEglqPmyc2Xdh3Z JQfw== X-Gm-Message-State: AO0yUKUfHVA7VMqaAYQ8GA+FT0eo7fEXbOSfDsDWFXrPYYNtBw0RZmSd EqFK436AftZdLWKzmVBnjXjpbV3wCDx8Tv+CPqSmiA== X-Google-Smtp-Source: AK7set9XkIgZnFCV5HtdqJYRyAxFvnPkD4e0unubfGNYbsyKILaVotBip6KzDOzDYzPYDkQGBcaXi3tMAiwqLVpU9xE= X-Received: by 2002:a2e:7a09:0:b0:293:2e0a:da94 with SMTP id v9-20020a2e7a09000000b002932e0ada94mr1342061ljc.136.1676023354053; Fri, 10 Feb 2023 02:02:34 -0800 (PST) MIME-Version: 1.0 References: <8c476ad1d36919f31c3d37edc813182e8f1489e8.1675889602.git.demi@invisiblethingslab.com> In-Reply-To: From: George Dunlap Date: Fri, 10 Feb 2023 10:02:23 +0000 Message-ID: Subject: Re: [PATCH v2 3/4] Miscellaneous and documentation: Only use TLS-protected transports To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , "Daniel P. Smith" , Anthony PERARD , Daniel De Graaf , Quan Xu , Samuel Thibault , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott , Paul Durrant Content-Type: multipart/alternative; boundary="000000000000a76ade05f4559841" --000000000000a76ade05f4559841 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 9, 2023 at 5:51 PM Demi Marie Obenour < demi@invisiblethingslab.com> wrote: > On Thu, Feb 09, 2023 at 02:25:07PM +0000, George Dunlap wrote: > > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour < > > demi@invisiblethingslab.com> wrote: > > > > > Obtaining code over an insecure transport is a terrible idea for > > > blatently obvious reasons. Even for non-executable data, insecure > > > transports are considered deprecated. > > > > > > This patch changes miscellaneous links that are not used by any > > > automated tool. Some of these links are dead anyway. > > > > > > > As I said in response to patch 4, I appreciate the goal and the effort > > here. But I'd rather not replace a working link with a broken link, or a > > broken link with another broken link. > > > > If we want to make this change, I think we're going to have to be > creative > > with how the link replacement is done, as well as in how it's > demonstrated > > to reviewers that the new URLs are valid. > > > > One option, for instance, could be writing a small script that would > check > > the link validity first and only make the change if the link was valid; > and > > then including that script in the commit message. The reviewer could > then > > convince themselves that the script was correct, and give an Ack or R-b > on > > that basis. There are probably other ideas as well. > > > > Any thoughts? > > > > -George > > What about breaking the patch up into smaller ones? One could change > all of the xenbits.xen.org links in one patch, since those are known to > support HTTPS. Then keep going for other domains. > That would work for me. -George --000000000000a76ade05f4559841 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Feb 9, 2023 at 5:51 PM Demi Marie= Obenour <demi@invisiblet= hingslab.com> wrote:
On Thu, Feb 09, 2023 at 02:25:07PM +0000, George Dunlap wrote:<= br> > On Wed, Feb 8, 2023 at 8:59 PM Demi Marie Obenour <
> demi@= invisiblethingslab.com> wrote:
>
> > Obtaining code over an insecure transport is a terrible idea for<= br> > > blatently obvious reasons.=C2=A0 Even for non-executable data, in= secure
> > transports are considered deprecated.
> >
> > This patch changes miscellaneous links that are not used by any > > automated tool.=C2=A0 Some of these links are dead anyway.
> >
>
> As I said in response to patch 4, I appreciate the goal and the effort=
> here.=C2=A0 But I'd rather not replace a working link with a broke= n link, or a
> broken link with another broken link.
>
> If we want to make this change, I think we're going to have to be = creative
> with how the link replacement is done, as well as in how it's demo= nstrated
> to reviewers that the new URLs are valid.
>
> One option, for instance, could be writing a small script that would c= heck
> the link validity first and only make the change if the link was valid= ; and
> then including that script in the commit message.=C2=A0 The reviewer c= ould then
> convince themselves that the script was correct, and give an Ack or R-= b on
> that basis.=C2=A0 There are probably other ideas as well.
>
> Any thoughts?
>
>=C2=A0 -George

What about breaking the patch up into smaller ones?=C2=A0 One could change<= br> all of the xenbits.xen.org links in one patch, since those are known to support HTTPS.=C2=A0 Then keep going for other domains.

That would work for me.

=C2=A0-Ge= orge
--000000000000a76ade05f4559841-- From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:16:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:16:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493218.763022 (Exim 4.92) (envelope-from ) id 1pQQRy-0000Xb-F6; Fri, 10 Feb 2023 10:16:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493218.763022; Fri, 10 Feb 2023 10:16:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQRy-0000XU-CP; Fri, 10 Feb 2023 10:16:14 +0000 Received: by outflank-mailman (input) for mailman id 493218; Fri, 10 Feb 2023 10:16:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQRx-0000XE-AP; Fri, 10 Feb 2023 10:16:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQRx-0002DY-7h; Fri, 10 Feb 2023 10:16:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQRw-0006s3-T0; Fri, 10 Feb 2023 10:16:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQQRw-0005yC-Sa; Fri, 10 Feb 2023 10:16:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LOiUpjMMzJ84HIUQlxbdNe7DV/OpuKOheZW9ws9UU3o=; b=cR3KNj49ddVUbRryTz4LgXiYDy Sj9hgh8mTy9CxCNPaLLF3hfhK8CBN+7CtGH3kwL+AvF0DVdRq2uq7FXq3qDaqydVkLDrdm6IZebCB atNEA+kwDnUE5QtAMxvpRjOSmrO2+PpwdroAMe85pGbp+iV89tLffYcQsmB9xDoOt/1I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 176804: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=587823eca162d063027faf1826ec3544f0a06e78 X-Osstest-Versions-That: xen=3dae50283d9819c691a97f15b133124c00d39a2f From: osstest service owner Date: Fri, 10 Feb 2023 10:16:12 +0000 flight 176804 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176804/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail in 176756 pass in 176804 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 176756 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176459 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176459 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176459 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176756 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved n/a test-arm64-arm64-xl 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-arm64-pvops 2 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 587823eca162d063027faf1826ec3544f0a06e78 baseline version: xen 3dae50283d9819c691a97f15b133124c00d39a2f Last test of basis 176459 2023-02-07 16:39:55 Z 2 days Testing same since 176756 2023-02-09 16:07:09 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Edwin Török Pau Ruiz Safont jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops starved build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3dae50283d..587823eca1 587823eca162d063027faf1826ec3544f0a06e78 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:25:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:25:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493239.763076 (Exim 4.92) (envelope-from ) id 1pQQb2-0002la-QX; Fri, 10 Feb 2023 10:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493239.763076; Fri, 10 Feb 2023 10:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQb2-0002lT-N9; Fri, 10 Feb 2023 10:25:36 +0000 Received: by outflank-mailman (input) for mailman id 493239; Fri, 10 Feb 2023 10:25:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQb0-0002lH-Qp; Fri, 10 Feb 2023 10:25:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQb0-0002OZ-Q9; Fri, 10 Feb 2023 10:25:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQb0-0007C5-FD; Fri, 10 Feb 2023 10:25:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQQb0-0003Zz-Ek; Fri, 10 Feb 2023 10:25:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+cu/1jRXYzUV7Xa5SkTrOCtx5jv50xihDBhxk619b40=; b=2zy421x/EnrDjj4fdhzBr8QAE6 U8L2NmNee57VL8mFXwaol3gtXEZ4euWgUtGvVW7Yc3hdV7WWkMJ3t8H7SYggCR+a/nz7EMCtlBfDG EgI8b1nS+BrwNRGHOEIDmIZih5SzPAEuMs1hKKQE6ArQRR5seQWKHzwZzhtHNp2O3DIc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 176815: all pass - PUSHED X-Osstest-Versions-This: ovmf=93a21b465bda44cecdd6347ad481ca6f55286547 X-Osstest-Versions-That: ovmf=39254d922e550ccc9c5ab5639c3c28a4ee4e13fd From: osstest service owner Date: Fri, 10 Feb 2023 10:25:34 +0000 flight 176815 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176815/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 93a21b465bda44cecdd6347ad481ca6f55286547 baseline version: ovmf 39254d922e550ccc9c5ab5639c3c28a4ee4e13fd Last test of basis 176790 2023-02-09 23:14:11 Z 0 days Testing same since 176815 2023-02-10 04:16:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael D Kinney Weipu Zhu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 39254d922e..93a21b465b 93a21b465bda44cecdd6347ad481ca6f55286547 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493253.763107 (Exim 4.92) (envelope-from ) id 1pQQvU-00062x-17; Fri, 10 Feb 2023 10:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493253.763107; Fri, 10 Feb 2023 10:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvT-00062k-Rx; Fri, 10 Feb 2023 10:46:43 +0000 Received: by outflank-mailman (input) for mailman id 493253; Fri, 10 Feb 2023 10:46:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvS-000617-DB for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31429bb5-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B835E5CA5F; Fri, 10 Feb 2023 10:46:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 892191325E; Fri, 10 Feb 2023 10:46:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6FYVIIwg5mPFUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31429bb5-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676025996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EcyQSQ8MTpZXgX1s81+j7sy99tw1SNkYAs91wZGwPfs=; b=Q4izeK3vg+QRNfe+B27h8+Led+RcTZCktMmPvigGZDrNU4Xj1dllvMlKXG1Qnar/sdGTIV iPJC/ElqxDe3JzAxXD6BVOv6ZawW+yI0oj+q1LFSKjm3J8Xn8MnTjmftES/f6AsOFtjNWf yh+Gmy315qlOSF8ALfKeXDfBXBJihg4= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Fri, 10 Feb 2023 11:46:22 +0100 Message-Id: <20230210104628.14374-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common directory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross --- V2: - check sscanf() return value (Samuel Thibault) --- include/xenbus.h | 6 ++++++ xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..923e8181 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + if ( sscanf(str, "%u", value) != 1 ) + msg = strdup("EINVAL"); + free(str); + + return msg; +} + /* * Local variables: * mode: C -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493251.763091 (Exim 4.92) (envelope-from ) id 1pQQvN-0005lG-M4; Fri, 10 Feb 2023 10:46:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493251.763091; Fri, 10 Feb 2023 10:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvN-0005l9-JM; Fri, 10 Feb 2023 10:46:37 +0000 Received: by outflank-mailman (input) for mailman id 493251; Fri, 10 Feb 2023 10:46:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvL-0005jA-Lj for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:35 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e0ba236-a930-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 11:46:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 25A61204CF; Fri, 10 Feb 2023 10:46:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EAC411325E; Fri, 10 Feb 2023 10:46:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6hvXN4Yg5mO2UwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e0ba236-a930-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676025991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PDgHDMzjJXo9wSzs1oG9zdzpDquZjD5pWP6GxGhcd4Q=; b=IIhrADpIWTxEgSUvnVokfAXrtMyY9JruXt9ebOrSqdyvfpjRScTWchz+ul03TXgTOEVYub Q4aMkSdVqbIkhyVX8hvNdlOioRuUI4tu7XuFSzXmaDRIdKDcWCWaYM5jxklOqkyzFfbScb oQ2DRiUrJxmNxQAy6XqyWuLV2Q2vutw= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 0/7] Mini-OS: add minimal 9pfs support Date: Fri, 10 Feb 2023 11:46:21 +0100 Message-Id: <20230210104628.14374-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and then verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Changes in V2: - addressed comments by Samuel Thibault Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1291 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 128 +++- xenbus.c | 40 +- 11 files changed, 1469 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:46:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493255.763122 (Exim 4.92) (envelope-from ) id 1pQQvY-0006PG-8Q; Fri, 10 Feb 2023 10:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493255.763122; Fri, 10 Feb 2023 10:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvY-0006P9-4l; Fri, 10 Feb 2023 10:46:48 +0000 Received: by outflank-mailman (input) for mailman id 493255; Fri, 10 Feb 2023 10:46:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvW-000617-Jz for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:46 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34a04e52-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:42 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 615EC3FEC5; Fri, 10 Feb 2023 10:46:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 39D171325E; Fri, 10 Feb 2023 10:46:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5aTuDJIg5mPXUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34a04e52-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026002; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/AHf/75zmPALL2yeH8dnyZ0qXj5tN9xIh6TXHZM0XmI=; b=uUnrQU6OBTmGEoK5GrqQ5X1uKYO50tysm/j0qaooTSeJQ2BfFKK4egmCT4hUuwYhyS1ZEq LxH6MFeQ7hdpMDYz59hrNEqR8JXTYmxpLEpUk7LM/Qn5LZD28KoJep29gwFa0s0TS9Jbzz iE28cYUEKlTy1HyP4v909JUgLcPRPOA= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 2/7] Mini-OS: add concept of mount points Date: Fri, 10 Feb 2023 11:46:23 +0100 Message-Id: <20230210104628.14374-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross --- V2: - pass path below mount point to open callbacks (Samuel Thibault) --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..2f33c937 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname + mlen, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:47:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:47:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493257.763133 (Exim 4.92) (envelope-from ) id 1pQQvc-0006kO-FD; Fri, 10 Feb 2023 10:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493257.763133; Fri, 10 Feb 2023 10:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvc-0006kF-CM; Fri, 10 Feb 2023 10:46:52 +0000 Received: by outflank-mailman (input) for mailman id 493257; Fri, 10 Feb 2023 10:46:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQva-000617-R2 for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37f94573-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F1F095CA5F; Fri, 10 Feb 2023 10:46:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C403B1325E; Fri, 10 Feb 2023 10:46:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B395Lpcg5mPlUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37f94573-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026007; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r6yg48m3tvne8UEfBZnk+9j9B6sQe1QaY7lXxFABCRM=; b=Pg/wOl+X1wnAx5gv9QVCPC0Svx3QQQCb9FVnjkyyR0ckKiDByOeK9io6QiUwEU2tS+WTuZ jr0/+13du395NvWMczqy1XTIzTajelRXA3VJZmpKoJWyyQOYDXyuLwEKSb6FRNDbNi3K0h c4X9mMUISJcSo6IT1RKi1Tr0gEuQDjs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Date: Fri, 10 Feb 2023 11:46:24 +0100 Message-Id: <20230210104628.14374-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- include/lib.h | 5 +++++ lib/sys.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 2f33c937..dc8a8c69 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +#ifdef CONFIG_CONSFRONT +#define STATIC_MNTS 4 +#else +#define STATIC_MNTS 2 +#endif +#define DYNAMIC_MNTS 8 + +static struct mount_point mount_points[STATIC_MNTS + DYNAMIC_MNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +372,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +384,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:47:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493262.763148 (Exim 4.92) (envelope-from ) id 1pQQvi-0007KO-Rk; Fri, 10 Feb 2023 10:46:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493262.763148; Fri, 10 Feb 2023 10:46:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvi-0007KD-O1; Fri, 10 Feb 2023 10:46:58 +0000 Received: by outflank-mailman (input) for mailman id 493262; Fri, 10 Feb 2023 10:46:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvg-000617-Oy for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:46:56 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b473f65-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:53 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 875945CA5F; Fri, 10 Feb 2023 10:46:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A2101325E; Fri, 10 Feb 2023 10:46:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zWCwFJ0g5mPzUwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b473f65-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LfzPuWES19Z6zkc6ddDA2+HHqNpphAyol7vuoCqTTog=; b=GIBT8TTNBayaUmMcymygthXHVyC152KeQDlcror7XNkR6fy91STK/zBi9jv06fw1TW0mVD NUZW4SFP7o63G6Moegu++0snEw5DKiTUwXXw20BJSTj6s7qyanIAE70qP7qj3jwvwBaMN3 FGk5rL7CQO1tvOLGFOlkAW7jPaBt9GY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 4/7] Mini-OS: add 9pfs frontend Date: Fri, 10 Feb 2023 11:46:25 +0100 Message-Id: <20230210104628.14374-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross --- V2: - add better error handling to version parsing (Samuel Thibault) --- 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 298 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..89ecb3a1 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,286 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) + { + v = NULL; + break; + } + if ( *v != ',' && *v != 0 ) + { + reason = "backend published illegal version string"; + free(version); + goto err; + } + } + free(version); + if ( v ) + { + reason = "backend doesn't support version 1"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493274.763166 (Exim 4.92) (envelope-from ) id 1pQQvw-0008P8-J2; Fri, 10 Feb 2023 10:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493274.763166; Fri, 10 Feb 2023 10:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvw-0008P1-GC; Fri, 10 Feb 2023 10:47:12 +0000 Received: by outflank-mailman (input) for mailman id 493274; Fri, 10 Feb 2023 10:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvv-0005jA-Mw for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:11 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45732faa-a930-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 11:47:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9B2403FEC6; Fri, 10 Feb 2023 10:47:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6202C1325E; Fri, 10 Feb 2023 10:47:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ApZvFq4g5mMjVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:47:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45732faa-a930-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026030; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQI5EY4iGPACMuqIgP0kKRTaNVN1WVxx1P8uV/lIB7o=; b=oV9d+cW6hqWzg0jCv6JPRO0kUaBN5Zgsf8SQZg5LpJMKDYArbtsjuJ0TJpO2HQCgPOgkcV ywousDOOm1JjkmUDLWTFlFyU7YTy38rQanmoDmjXH67uJEImxpQI7+FJgkG7yE9rXQ4gsz e1RRnbRCO6el+4skulPXuq2mZ0oSWXU= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Date: Fri, 10 Feb 2023 11:46:28 +0100 Message-Id: <20230210104628.14374-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- V2: - add check for max message size - return EAGAIN in case no free request got (Samuel Thibault) - loop until all data read/written (Samuel Thibault) --- 9pfront.c | 211 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 211 insertions(+) diff --git a/9pfront.c b/9pfront.c index b4c54535..c606c437 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -88,11 +91,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[13]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); @@ -640,6 +708,110 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_READ; + + while ( len ) + { + count = len; + if ( count > dev->msize_max - 24 ) + count = dev->msize_max - 24; + + send_9p(dev, req, "ULU", fid, offset, count); + rcv_9p(dev, req, "D", &count, data); + + if ( !count ) + break; + if ( req->result ) + { + ret = -1; + errno = EIO; + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_WRITE; + + while ( len ) + { + count = len; + if ( count > dev->msize_max - 24 ) + count = dev->msize_max - 24; + + send_9p(dev, req, "ULD", fid, offset, count, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -727,6 +899,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1068,6 +1277,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:53:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:53:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493285.763182 (Exim 4.92) (envelope-from ) id 1pQR1Z-00024B-Bd; Fri, 10 Feb 2023 10:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493285.763182; Fri, 10 Feb 2023 10:53:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR1Z-000244-8z; Fri, 10 Feb 2023 10:53:01 +0000 Received: by outflank-mailman (input) for mailman id 493285; Fri, 10 Feb 2023 10:53:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR1Y-00023u-D4; Fri, 10 Feb 2023 10:53:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR1Y-00031g-9b; Fri, 10 Feb 2023 10:53:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR1X-0008Ci-Ur; Fri, 10 Feb 2023 10:53:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQR1X-0002LF-UR; Fri, 10 Feb 2023 10:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lbQ6vGrcNl9QHIk8aVnrer98WMxKZBLPfGk6JcfrOMs=; b=suHjpjA5Na1cPY9iOKRvTfaGbA 5n9txLTxcH27iuPTI02i3DrM7qrxLPPCXXqEVVDtLR1DIygJBIOiWup70ueFeilREuPEppXjdXmRe KlGelDQ3/3hubigYD1JWb4glFzUHhyKNl3JcIy2w11P3wQ55PdY0TK1C8H697XMQXV+Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 176840: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=5b46dd85d051ceecc2c00a0de27f03e571bff379 From: osstest service owner Date: Fri, 10 Feb 2023 10:52:59 +0000 flight 176840 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176840/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 5b46dd85d051ceecc2c00a0de27f03e571bff379 Last test of basis 176766 2023-02-09 18:00:26 Z 0 days Testing same since 176840 2023-02-10 09:02:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Juergen Gross jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5b46dd85d0..01e7477d1b 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:55:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493298.763193 (Exim 4.92) (envelope-from ) id 1pQR3i-0002lf-SD; Fri, 10 Feb 2023 10:55:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493298.763193; Fri, 10 Feb 2023 10:55:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR3i-0002lY-O4; Fri, 10 Feb 2023 10:55:14 +0000 Received: by outflank-mailman (input) for mailman id 493298; Fri, 10 Feb 2023 10:55:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvn-000617-VA for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:04 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e9e5fb6-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:46:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 286413FEC5; Fri, 10 Feb 2023 10:46:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC1231325E; Fri, 10 Feb 2023 10:46:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t2tDOKIg5mMAVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e9e5fb6-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AjLtvshfjPJLxhGdXS+IgJVdKslWSTSlXSgC0tGAfD0=; b=NOT/uNDL/q3Nh9a1C32Rlo3B2Dyw3tSWtTow1koZyC/xfTeUU+zab4gzRWdQhPxW9MhA9h JfGEdoK2tm+/YaKjFmY6K14mBmlYXzsL0TURz4/IZFuIN9MwZKHFno9uQvLBOGAmFeIgi1 Ar1vr/wksJI1o4ekhjZl3Nyo8Kk0hYk= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 5/7] Mini-OS: add 9pfs transport layer Date: Fri, 10 Feb 2023 11:46:26 +0100 Message-Id: <20230210104628.14374-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross --- V2: - add more comments (Samuel Thibault) - log short copy (Samuel Thibault) - send event after consuming response (Samuel Thibault) - reaturn EAGAIN in case no free request could be got (Samuel Thibault) --- 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 478 insertions(+) diff --git a/9pfront.c b/9pfront.c index 89ecb3a1..0b8d5461 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,470 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +#define P9_QID_SIZE 13 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + * + * Helper functions: + * + * copy_bufs(): copy raw data into a target buffer. There can be 2 source + * buffers involved (in case the copy is done from the ring and it is across + * the ring end). The buffer pointers and lengths are updated according to + * the number of bytes copied. + * + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response + * to the specified variables using the specified format string for + * deciphering the single item types. The decision whether to copy from the + * ring or an allocated buffer is done via the "hdr" parameter, which is + * NULL in the buffer case (in that case the header is located at the start + * of the buffer). + * + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in + * it. If none is found, consumes one response. It checks the tag of the + * response in order to decide whether to allocate a buffer for putting the + * data into, or to fill the user supplied variables. Return true, if the + * tag did match. Waits if no data is ready to be consumed. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + { + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); + len = *len1; + } + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + notify_remote_via_evtchn(dev->evtchn); + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[P9_QID_SIZE]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 10:55:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 10:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493311.763208 (Exim 4.92) (envelope-from ) id 1pQR3w-0003Hq-BJ; Fri, 10 Feb 2023 10:55:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493311.763208; Fri, 10 Feb 2023 10:55:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQR3w-0003Hh-7H; Fri, 10 Feb 2023 10:55:28 +0000 Received: by outflank-mailman (input) for mailman id 493311; Fri, 10 Feb 2023 10:55:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQQvt-000617-JG for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 10:47:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4205029c-a930-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 11:47:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D5DC85CA5F; Fri, 10 Feb 2023 10:47:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A94551325E; Fri, 10 Feb 2023 10:47:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hKAUKKgg5mMOVAAAMHmgww (envelope-from ); Fri, 10 Feb 2023 10:47:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4205029c-a930-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676026024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yGjQysJi2clZT+3RgGQtfxmXBb6C9V7YM0oN6qZktqE=; b=DN7mFMD2WhwPI+vBEQysLSoQpzspVI+X7+tFvlT64t5SwokXtsCOVozaggSUNqFJohmiWa GPaIB7A+v1JqrAGshcJS5d8/taM0oth79rDulBOGh1vNWhpYdgvgQ0Ek28D3UskYv5fLEg Li1ljbnDQ5RnOI5M/YHTrljgjK10JR0= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Fri, 10 Feb 2023 11:46:27 +0100 Message-Id: <20230210104628.14374-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230210104628.14374-1-jgross@suse.com> References: <20230210104628.14374-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. Signed-off-by: Juergen Gross --- V2: - check path to be canonical - avoid short read when walking the path - fix get_fid() (Samuel Thibault) - return EAGAIN if no free request got (Samuel Thibault) --- 9pfront.c | 320 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 318 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index 0b8d5461..b4c54535 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ #define P9_QID_SIZE 13 @@ -69,10 +89,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= ~(1ULL << (fid - 1)); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -486,6 +549,166 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[P9_QID_SIZE]; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + { + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + rcv_9p(dev, req, "uQ", &nqid, qid); + } + else + { + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "u", &nqid); + } + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + +static bool path_canonical(const char *pathname) +{ + unsigned int len = strlen(pathname); + const char *c; + + /* Empty path is allowed. */ + if ( !len ) + return true; + + /* No trailing '/'. */ + if ( pathname[len - 1] == '/' ) + return false; + + /* No self or parent references. */ + c = pathname; + while ( (c = strstr(c, "/.")) != NULL ) + { + if ( c[2] == '.' ) + c++; + if ( c[2] == 0 || c[2] == '/' ) + return false; + c += 2; + } + + return true; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -504,10 +727,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + if ( !path_canonical(pathname) ) + return EINVAL; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname, &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -552,6 +866,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -753,6 +1068,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 11:09:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 11:09:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493330.763218 (Exim 4.92) (envelope-from ) id 1pQRHI-0005PI-Gy; Fri, 10 Feb 2023 11:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493330.763218; Fri, 10 Feb 2023 11:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRHI-0005PB-EI; Fri, 10 Feb 2023 11:09:16 +0000 Received: by outflank-mailman (input) for mailman id 493330; Fri, 10 Feb 2023 11:09:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRHH-0005P5-D3 for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 11:09:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRHE-0003KR-Rt; Fri, 10 Feb 2023 11:09:12 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQRHE-0007bs-Jm; Fri, 10 Feb 2023 11:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=qAQKf3ZgLfRydlGQCnsXnvQTJPMsbGPflQesNI/O3x8=; b=DuNOKKhH9zMlMsjHxNr2aUGPiN J8V7sUsBT2Xj41IOLcjCkbUIXx9iZ4ta8bYI1XFwR9a441c5AUEhHPPm5W6NdUCF/Ttz894/Q+KiV WaYdNqB9oemRzIoTc5q1PdjFMp6cPFvCSwNcJ4u4YSpXK98YKyPQwTmIbTkprBaFJxsc=; Message-ID: Date: Fri, 10 Feb 2023 11:09:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h Content-Language: en-US From: Julien Grall To: xen-devel@lists.xenproject.org Cc: demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Jun Nakajima , Kevin Tian , George Dunlap References: <20230209230020.52695-1-julien@xen.org> <20230209230020.52695-4-julien@xen.org> In-Reply-To: <20230209230020.52695-4-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/02/2023 23:00, Julien Grall wrote: > diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h > index 74c0cedd11cc..c0e1380076a7 100644 > --- a/xen/arch/x86/include/asm/hvm/vpt.h > +++ b/xen/arch/x86/include/asm/hvm/vpt.h > @@ -1,19 +1,8 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > /* > * vpt.h: Virtual Platform Timer definitions > * > * Copyright (c) 2004, Intel Corporation. > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms and conditions of the GNU General Public License, > - * version 2, as published by the Free Software Foundation. > - * > - * This program is distributed in the hope it will be useful, but WITHOUT > - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > - * more details. > - * > - * You should have received a copy of the GNU General Public License along with > - * this program; If not, see . > */ > > #ifndef __ASM_X86_HVM_VPT_H__ > diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h > index fc0afe35bf6b..8e1e0ad9ee18 100644 > --- a/xen/arch/x86/include/asm/iommu.h > +++ b/xen/arch/x86/include/asm/iommu.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Hmmm... I didn't notice that the licence text wasn't removed in iommu.h. It looks like this is... > /* > * This program is free software; you can redistribute it and/or modify it > * under the terms and conditions of the GNU General Public License, ... because '*/' is the indented the usual way. I will add the pattern in the python script and also harden it to throw an error if it can't replace the licence text. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 11:44:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 11:44:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493341.763240 (Exim 4.92) (envelope-from ) id 1pQRp4-0001zd-9e; Fri, 10 Feb 2023 11:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493341.763240; Fri, 10 Feb 2023 11:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRp4-0001zW-6o; Fri, 10 Feb 2023 11:44:10 +0000 Received: by outflank-mailman (input) for mailman id 493341; Fri, 10 Feb 2023 11:44:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQRp2-0001xX-Ll for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 11:44:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36b8ed52-a938-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 12:44:04 +0100 (CET) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Feb 2023 06:43:53 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5259.namprd03.prod.outlook.com (2603:10b6:5:245::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 11:43:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 11:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36b8ed52-a938-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676029444; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=L8/7Mz6SoGufMxhP0MH7kRY/O+E6cfykxtojQvlf/kA=; b=THHj/vtP8c0p7Z7OaWCl1BIuDRWyd3fx9Lr+1HvMZYNQwu5vMO/XV4fX aXsSQDi5ZE2DlfahDoi8xjVhVIhJl3ziRUiXuXDZb/Y+Owf4jrdSU6eXr J0cwDGSolNNeCmEnKWQyS2gPiVH/ecW2EixfrcqonfHe/N5C1z+jGgx4X o=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 95910277 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4gyftqNBVdqE3QHvrR1HlsFynXyQoLVcMsEvi/4bfWQNrUol0zBTx mNMWmqOb6yNN2fxKop+YY2y9kMBvJHcmN9lGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wRmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vl4IUhRy u4CEREud1ediOeznOnqVPY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujaCpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewHKiANhNS9VU8NZ3uxqC2FAXFScwD3enkfSTs2OCCv9Qf hl8Fi0G6PJaGFaQZtvyRRqju1afowURHdFXFoUS7QCLy63PpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZs1qFbO4ipvpGTD6y i2OsAAzga5Wid8M0eO851+vqy2ojojESEgy/Aq/Y46+xgZwZYrgbIvx71HetK9ENNzAEAjHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxdEdM1S Cc/YT9s2aI= IronPort-HdrOrdr: A9a23:pCmEYaOBKDoR+8BcTuejsMiBIKoaSvp037B87TEKdfVwSL3gqy nIpoV86faUskd3ZJhEo7q90ca7MBDhHPJOgbX5Xo3SODUO2lHYTr2KtrGSuwEIcheWnoVgPM xbAs1D4bPLbGRSvILT/BS/CNo4xcnvytHSuQ4c9RtQpMNRBp2IIz0XNu9TKCNLeDU= X-IronPort-AV: E=Sophos;i="5.97,286,1669093200"; d="scan'208";a="95910277" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMz4VXTj6Sh5fQCDL5t9rpQCwsjFJIg9S3L9jd6q6ei40AUdYdqxOCTgckcuPon1JApU7T6UE7/4JOLO1TQGQPkc66RCW0NUvYrTTCdfyzEy/Nzfgz8IR8drxOM94rmAogbv4oKkSt+NM3nWw9pw8DB+FxD87bLXvvMAsnkFTi6WIujMdMD7smw0bIIdmzVpFwvyoA53k764I2nYGzVUKF/u9tZQedGNhc0Kz73ayN03bou9j2YcWYHCXZG75aAz35QTJiQWNoeo9Wk2I10L1svSfG6/XlrGMZ/5/vZelOyWFowj4pYSCTn62vYqlV3AEqjt8eH+0ABASycKRzpXMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TamF8SrNO6lCSMT/cBeMvIiv3d8WU5RPQ1qkqPNlfSs=; b=MfUvUlx4CkuvJ2w69ET8IZ+K6ffVRzM4W0iWK7QSuWQz2FpxE2TedVMewHm+toys4mA4o91foIGLHzlBuDgaBRYkKFPzjFDqUpEZDrUzulMYkKHkRKsvxJxfanjZn1BoQTasXJzE0dPXY2PKCGigTmoDGZ74YkzQZx+EKLhp3nzrB2N8482/KK9KJU4Xmywz7DWs7vigJ5CTvpqtDZL3PomQ0AKsevGMN9pA7npgvBUdr+oQH3dw0smYtsKb4Qtxd3rUKSwJQvZqps22TQAw9oNrcSb4Exk2zK7PyOD3yqNGtJOOOIrg81DyqHO7b4PRXs9U4Lfb6Um7FddMAKGuUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TamF8SrNO6lCSMT/cBeMvIiv3d8WU5RPQ1qkqPNlfSs=; b=HpNSVPuPHCrisrH6JyCsUlXNoLyM57QQZJFWtFbEFPqjhwAMPDZ5jOH22W9QhP+r3PcJVc31LqgSieMc6beQAL34mB+9nxvWJBl6W2c5Nyef8oCIiOFTKYUaUm3Bu7AV4Yc0kt9kHSmYNBtg+utxBO7+sGg8sy4q23dewkYY7X4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> Date: Fri, 10 Feb 2023 11:43:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Content-Language: en-GB To: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20230210104628.14374-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5259:EE_ X-MS-Office365-Filtering-Correlation-Id: 299e8c9c-fc4d-4d59-394b-08db0b5c1437 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LNCPtDoP03078hM0tD0zNbMCUvoGoEPMJW29lO2dYtUANcI5TwWjgv/VS6jTexOXQ5CEcYGS72Ian56+ic6wotbznByRSN2NuSGD8eBBemM8b0Wz7Wfpchjf/NosWrU/+qLPN2+/H/p4l/TvJZ8nrvqfHkBdIBS2Qb/9ybY2Yowr+DjyyyC1+zXNF/EmGmcjjKRJYysQnRlc0/AQh5nMJM6RJMlVdbGVA6TfCxNI0ahfzerPS0sRH1NdreO5uyzyIrZRbJXZQgM6qlN8yA0MciXoSNcPqYNGsxIndgg1OJvl7oByJqtoK13KFXd6/Z95WA+Aow4QtLw5187I4F4zlOZ1vi4VYkq3BXk7GivhZJNHd2wSBAxecA8xSjqtY9yURj1nt0EW7bDme8VwwidZF4fR4h0Fg95/YnfMVU+CndkRu3SevuKnmx7CUtCwO7IAygEI67ZWqhpRfUIsWpEIFx7bGrSNEM6pPD9TPz2p+IAsajPy20UoPq+H0Ywzay5cQ0jftBghl53/Dzt8dyggwJ33vvE85CyRDJedX63PCXr+iahQ/w1k4a3rofFrGezAGjTDUMv0P58s6lLnMHASf3OXVF8WKiZ3+3pH325dT6g1hnVxqKaUY/Hp6lDK+qVOI15MtvhPfDaSoCm8zommHyOLZAxQQ3eoCp04YT0dA8y6V7e/d5ozk4/hpVfWwrLlZPILhre7m71M3LTXxJZIzavY94wlQaFYQtHEzzkt8qA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199018)(478600001)(6486002)(316002)(2906002)(4326008)(66476007)(66556008)(66946007)(8676002)(41300700001)(6666004)(31686004)(6506007)(8936002)(6512007)(186003)(5660300002)(26005)(53546011)(4744005)(38100700002)(2616005)(36756003)(82960400001)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzdOZHBVcjJyMXNtT2xIb0dYUHQxNm10amFjOWxyQkV0ekVUdUM2MUxTSEV0?= =?utf-8?B?ZVN4dkxtVGpvYnVENkdhS01xeEVpZklXYnZycE5yZGcySU4wNjBRdnFBT2Ft?= =?utf-8?B?OWF2RDVQTllRY3JCbEZRb3orUmNtREs4T2x6SWZqdFZ5cFdVSW12SExmWlJE?= =?utf-8?B?eHhlN3Z5SVB3QmxDbklDdStzWEtZZzJpejlRTGkwMy9iTHplY3V4L1B6TWRL?= =?utf-8?B?SnVhZm5mUmZPUnZJV2QxUUhwSHRDV0tPczZXTUZGNitiTmZvZW8ya3UxSmpk?= =?utf-8?B?a0twb2RCd3RvMERKMklvM051b3p0bjN5QTFKdUttY1dCZFhBVmx4NzZnay84?= =?utf-8?B?NHNpN0V1NFVjRGFaWXprL1pnWDBET1dyZ3dYSzAwbXkvdGllKzBIZW8zNFFS?= =?utf-8?B?QlZBa3pGT0RwVjdzK3JHTkYyR2dVS2F0SjlwTHoyeUNLbnNZQThoRmh6a3Fj?= =?utf-8?B?SnlGRnJGdDVxdm5JK1QvcWxNVzA3T1dlMWNmV3lLQWpyV2hMQnQ4YlhTYk1C?= =?utf-8?B?WkM5UERvS2hJdzJ6Y2I4Qlk3YjVFK1RBQWhwamdtZ3V2amlkT0NKeDI3WFo5?= =?utf-8?B?SlQ0NUtzUWNGMkZzTmpXaVl5Q0NLa0laOHRQMXMwVWhvMWRTUVFMRGk5bFFI?= =?utf-8?B?U1dQb1pFNnh5d285N2V1N3V3b3h0UEZmd3JnN1VsYnFZZ0Z4ZFFLSkIxUmln?= =?utf-8?B?N1pLNjdwRk5jSWhUTHFVUTFsSWFtRVFVZFA4QzdEZ2JTU3prdllmR0krZU1G?= =?utf-8?B?M0dWSmNZR3hLYVQzaU1zSzJKZUNvNTQwNy9tYjR3MThEc2J1TEFOZ3VremhL?= =?utf-8?B?WTVuMnNsRE1hWVdvQmhRR0VQVkpENjFmd1Y3ZTZmSE9jK29KWDNWQlNEclBi?= =?utf-8?B?MXhiL2d6NUNIRmFNRnllVHRqZlRxMW9LVUZvQ2FRcHIrZHVmQ2N0Z2N3Ynlu?= =?utf-8?B?bmlOS3QvUHU4b05zRnZBTzhxbCtOTHpuT3Z2WTVKdkNlMkxia0gvYTA0V3ZI?= =?utf-8?B?dHYxV1BXRyt6bXBWOXlCNTV2NG90dzZWRmdPVXIweXhNcW04WThmc25mSXBQ?= =?utf-8?B?SHJ2SWdPbVNIYVhLKzRSaGhPNUU2YWg0OXpxcHFvbStWNUs0Y1hWM0R0SmtM?= =?utf-8?B?UWxJYmxMOSsraWI2TmpqZythOHdlckpWK0F5OUpQeTE0MlFUc1l6OXVWWHV3?= =?utf-8?B?YStWUEFwZmNIbU5pWE5XYnNuVzBFNFlSRWw0UktjY0h3MTY1WWxqUUtNVjhS?= =?utf-8?B?RnhvM0RwOFVpOXhuL3FTWmE2clVoc3dHU0U1cGZrMlc0RkIzVk5lU05lQndh?= =?utf-8?B?cXJFKzZjV2twbklzVnA5MERNQjFIUjJ0MkdtS0hpMUZaQ3FLL0xZQldoYjhL?= =?utf-8?B?clN2Uk5RTVo2enFZcXJkRTRxanQwNC9mZXJkT2lLRFNORWk5NHNMMU4xWFFo?= =?utf-8?B?S3d1aDZOK1BzWmdrTThMMVl4N29ncWRBaXhmUm1Fc3ljb1o4VWVtLzNQaHJz?= =?utf-8?B?UXV6RDU5UGNEcTYxbjliZVhHTGd4b3FHazBETVlra1dpM2FobExNcHpFSjU0?= =?utf-8?B?TGNETXowUmVYWkIxOTBXa2xwRHg0eSsxNUxWTTZKT0JBYUNWelhZVnBxUlo4?= =?utf-8?B?MjRkVWg4NTkwQldPSE5CTnBpNnVsbmVlS0tNVE1ZUHhUMGMvRzJZZGFZYU9P?= =?utf-8?B?R1dNblZHQTVDcjBrMy9mZURMYjk4cDdhWDZuQkNnSk14Rm52MFRPV2sxcGZk?= =?utf-8?B?Tmt0cEptY3FsR3kwSWNYSWdJMklHcWlNSThXTWp4RWJsQzBmZE9iSldGSXov?= =?utf-8?B?K3FmUmtyOUhVczlHYjI1dXptOXJkcnlEREY3V3dFRzBoS2Yyc2h2ZjVDa3pT?= =?utf-8?B?NnlhcFgwaDhKRnJUMWZkMWRzb05CR2RGa0M2RUg4cXY3TElaYWZmdFNkdDdE?= =?utf-8?B?MEtyS1BJZjBKUXRtNnEvRC9sa1dCYzcvVWNyc3prckg5R1Z1ZWZtSmlYdVhQ?= =?utf-8?B?MmMxT1J1SFlxbmJFTFZmS3NjSDN1bDQyRkxTbGFrWTczL1diTCtzbEFqSGo4?= =?utf-8?B?VmZ1WlQ3NWh1M3pSQmdFdEVMMSs2T2kxMlJxVXI4QUxUS0dKSkFuNXY4ZzBZ?= =?utf-8?B?VmlUa21zekx3eUhQdUJBaDVIaCtvcTJvMXd5by81elRweW81Nms2c3VQaUQ2?= =?utf-8?B?OWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: F046j0uk+90fB5KZHaWe+J+YFoIdNDzRigjQtXbsbytnSb8AEksQCpbcYzJjxxBrifgy/eWR4YiHBcmWVkT4HCJX0jgGzxezIBqio46mRbXkSyrFAqpur6DBe/m0JBAGCAzWcENeHfPW8nCTSkm2LXlHI8pxDC1N319ERT3E3D2oWHtVp6pNUOHtIgCO+pYDtSJ+9Zhmlz1rATzqUgNdDLgfmfu33Y+W48B1Ujyb1lLq/fIQV6x9t99kj5DAWUsJHGxREng48v507BbT+5pMOC9vmZ60P0DXE9volg1+3hXFV0WxORDbRVxqcemG8wL6ptFmXzTnU9BeKMFyntfRdahu8gW5z25T+HctbIcjTImyzu6/SbMwQhgHQLmO90aXvSaH1gG1FmmoEi2AVG8YaVVTC9wo7PWs77cGTm1uDudTYMv6WEumCJs0lbijBxwgWVBu6RW08GgpTTkRQXYulRWbs0fdCO9ywouPI/emaMFUseM4L4KWcj9d/gvzvOCZmVMUsRyZOU5u6rnBexJWmSq0uOcHiDoRsBcbN4PDykWpJoXyib7JhVZUk0SGu3ed+4mcX6Tefr5WNFYOSyqEywLZcsM2G2wGo1lUeAOYUaSWRF0eoM7Jgwx/ePquHPFUVKJD+9fxRdaiD1JvMTr18YZrF6jzKSwmjG+7CzR65PoT97yiOzmLn+FHzWlqW2Vebu4ptPC27v4V9xrBSE+JzUDVY9HJhXjEHGzBWKC3W85go1KsPo/2AVcSmsyyFKwvwcjWTD1NFI2GUu4ECwM6wBw4Mon753blPgCvylq5LePrpTrFLB91Un/61iZttcs3k57JbDLwYexDqQacFiI6cDccRsTCmDw+/SEQvm79WX4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 299e8c9c-fc4d-4d59-394b-08db0b5c1437 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 11:43:51.0867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0QZMfPrzWEcCq522loYKnQklShJ2Kl5tCMJ/hhZaBiwtCAtpXQXaePP2ccEfDrs77hIkgGIYqGJi0/9dkVtCtxRWI6a2hVcMcc/97EpEO8Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5259 On 10/02/2023 10:46 am, Juergen Gross wrote: > diff --git a/lib/sys.c b/lib/sys.c > index 2f33c937..dc8a8c69 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > return fd; > } > > -static struct mount_point mount_points[] = { > +#ifdef CONFIG_CONSFRONT > +#define STATIC_MNTS 4 > +#else > +#define STATIC_MNTS 2 > +#endif This ought to be #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) because it shows where the parts come from, and is much cleaner to add a 3rd one to in due course. That said, it would be simpler to just have a total mounts set at 16 or so?  Does a difference of two dynamic mounts depending on CONSFRONT actually matter? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 10 12:13:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 12:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493373.763303 (Exim 4.92) (envelope-from ) id 1pQSH7-0006rd-MS; Fri, 10 Feb 2023 12:13:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493373.763303; Fri, 10 Feb 2023 12:13:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSH7-0006rW-Iz; Fri, 10 Feb 2023 12:13:09 +0000 Received: by outflank-mailman (input) for mailman id 493373; Fri, 10 Feb 2023 12:13:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSH6-0006rE-9O; Fri, 10 Feb 2023 12:13:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSH6-0004tL-7u; Fri, 10 Feb 2023 12:13:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSH5-0004CM-Rl; Fri, 10 Feb 2023 12:13:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQSH5-0004JL-RL; Fri, 10 Feb 2023 12:13:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nZGyTnJZT1O3z49Z3dWwBXAg3tYu09skxibRZSG6wYQ=; b=XQiO8b0dDoDJo7hjr4C5sCn0a4 mV9H0Dt2lzk99zyaNIhxc4FJFxP10zr/AvcSKtz3t0ORGQDe+MApTEXnYSCLmf5t4ngtoN1kBlnvi 19Olm0jM5A4LDSy11bHruZ8B0BMB+i1FQfiKeWQqrxrbYKPh9Cx2T2fbSUAbW3i2Bdak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176769: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=4e0b4ccfc504f26187939068796295340ffd0e2f X-Osstest-Versions-That: xen=c0e202194bfcb413d7cf662b333550ed444c469b From: osstest service owner Date: Fri, 10 Feb 2023 12:13:07 +0000 flight 176769 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176769/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176591 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176591 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176591 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176591 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176591 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176591 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 4e0b4ccfc504f26187939068796295340ffd0e2f baseline version: xen c0e202194bfcb413d7cf662b333550ed444c469b Last test of basis 176591 2023-02-08 02:50:13 Z 2 days Failing since 176697 2023-02-09 02:53:32 Z 1 days 2 attempts Testing same since 176769 2023-02-09 18:40:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Andrew Cooper Anthony PERARD Ayan Kumar Halder Bobby Eshleman Juergen Gross Julien Grall Michal Orzel Oleksii Kurochko Roger Pau Monné Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c0e202194b..4e0b4ccfc5 4e0b4ccfc504f26187939068796295340ffd0e2f -> master From xen-devel-bounces@lists.xenproject.org Fri Feb 10 12:14:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 12:14:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493388.763338 (Exim 4.92) (envelope-from ) id 1pQSIN-0007iC-AP; Fri, 10 Feb 2023 12:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493388.763338; Fri, 10 Feb 2023 12:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSIN-0007i5-7g; Fri, 10 Feb 2023 12:14:27 +0000 Received: by outflank-mailman (input) for mailman id 493388; Fri, 10 Feb 2023 12:14:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSIL-0007g6-Ik for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 12:14:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 734b821d-a93c-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 13:14:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3129138C6F; Fri, 10 Feb 2023 12:14:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0643913206; Fri, 10 Feb 2023 12:14:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u4geAB015mPzAwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 12:14:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 734b821d-a93c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676031261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/7LL8YFeevoXTCk3DqI4RZG1qm/mpzkWP4bI9bxHzc=; b=k0BQzmIHjgo4E4iqbBFAKg8OeZ8Dzipc4yMeuHlwkBpcUkgMaCFGulYyJAeyYKn1mf61gT wSX170aqyK/yVrni2ywFF2s9ZWOfSaWBVq0b5FXuI7qU+C1b1LRnffyzSfUM7u4YKUA6Z9 G8IbhP1ll7cwjMwe/B1d4BoFGywAMiQ= Message-ID: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Date: Fri, 10 Feb 2023 13:14:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> From: Juergen Gross Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts In-Reply-To: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------gYHr6Z1L8dY8JCyXyg5uCt7O" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------gYHr6Z1L8dY8JCyXyg5uCt7O Content-Type: multipart/mixed; boundary="------------ZaUrE1zYQss3ulHEXpjQy7bV"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> In-Reply-To: <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> --------------ZaUrE1zYQss3ulHEXpjQy7bV Content-Type: multipart/mixed; boundary="------------lk0kNtLJLnA1v7uhw6G0v4ci" --------------lk0kNtLJLnA1v7uhw6G0v4ci Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTI6NDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDEwLzAyLzIw MjMgMTA6NDYgYW0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBkaWZmIC0tZ2l0IGEvbGli L3N5cy5jIGIvbGliL3N5cy5jDQo+PiBpbmRleCAyZjMzYzkzNy4uZGM4YThjNjkgMTAwNjQ0 DQo+PiAtLS0gYS9saWIvc3lzLmMNCj4+ICsrKyBiL2xpYi9zeXMuYw0KPj4gQEAgLTMzOSw3 ICszMzksMTQgQEAgc3RhdGljIGludCBvcGVuX21lbShzdHJ1Y3QgbW91bnRfcG9pbnQgKm1u dCwgY29uc3QgY2hhciAqcGF0aG5hbWUsIGludCBmbGFncywNCj4+ICAgICAgIHJldHVybiBm ZDsNCj4+ICAgfQ0KPj4gICANCj4+IC1zdGF0aWMgc3RydWN0IG1vdW50X3BvaW50IG1vdW50 X3BvaW50c1tdID0gew0KPj4gKyNpZmRlZiBDT05GSUdfQ09OU0ZST05UDQo+PiArI2RlZmlu ZSBTVEFUSUNfTU5UUyAgIDQNCj4+ICsjZWxzZQ0KPj4gKyNkZWZpbmUgU1RBVElDX01OVFMg ICAyDQo+PiArI2VuZGlmDQo+IA0KPiBUaGlzIG91Z2h0IHRvIGJlDQo+IA0KPiAjZGVmaW5l IFNUQVRJQ19NTlRTICgyICsgKElTX0VOQUJMRUQoQ09ORklHX0NPTlNGUk9OVCkgKiAyKSkN Cj4gDQo+IGJlY2F1c2UgaXQgc2hvd3Mgd2hlcmUgdGhlIHBhcnRzIGNvbWUgZnJvbSwgYW5k IGlzIG11Y2ggY2xlYW5lciB0byBhZGQgYQ0KPiAzcmQgb25lIHRvIGluIGR1ZSBjb3Vyc2Uu DQoNCkluIHByaW5jaXBsZSBmaW5lLCBidXQgSSdtIG5vdCBzdXJlIGl0IGlzIHdvcnRoIHRo ZSBlZmZvcnQgdG8gYWRkDQpJU19FTkFCTEVEKCkgc3VwcG9ydCB0byBNaW5pLU9TLg0KDQo+ IFRoYXQgc2FpZCwgaXQgd291bGQgYmUgc2ltcGxlciB0byBqdXN0IGhhdmUgYSB0b3RhbCBt b3VudHMgc2V0IGF0IDE2IG9yDQo+IHNvP8KgIERvZXMgYSBkaWZmZXJlbmNlIG9mIHR3byBk eW5hbWljIG1vdW50cyBkZXBlbmRpbmcgb24gQ09OU0ZST05UDQo+IGFjdHVhbGx5IG1hdHRl cj8NCg0KUHJvYmFibHkgbm90LiBTYW11ZWwsIGFueSB0aG91Z2h0cyBvbiB0aGF0Pw0KDQoN Ckp1ZXJnZW4NCg0K --------------lk0kNtLJLnA1v7uhw6G0v4ci Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------lk0kNtLJLnA1v7uhw6G0v4ci-- --------------ZaUrE1zYQss3ulHEXpjQy7bV-- --------------gYHr6Z1L8dY8JCyXyg5uCt7O Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPmNRwFAwAAAAAACgkQsN6d1ii/Ey8S ngf/UNYiWsjsaAcKMRDx6fEDCyFeOm6XXBnOIj7C7XEt1lZUJFmcwcYzMmbuJquh8laOwcs0Orpi NDjLFQb20xHxlWvOHYTD0G/qldZVUUSfd3Xto03EmoTrMqH/oNh7Q/xE6EJouPns22lkNJMaHHOY vVpvjuRNIqSP2U6GGr82qmqKWQPovJ86p+TBaYbmpnTKBd22ReEmEUh+PicLxjjH6Hbf79TqrrqZ GsR0JfQPkNuzqo3Y1gn+MClsEDLS4uxmJmyoi3tQYIHACPQ7HMUqtzYE/fTnN8AvkQeXNbAqlNo5 +wt0ZtC2r8VdIfl/OY1qBHGf8cWX7ukv0nqkbmBz6A== =HSde -----END PGP SIGNATURE----- --------------gYHr6Z1L8dY8JCyXyg5uCt7O-- From xen-devel-bounces@lists.xenproject.org Fri Feb 10 12:45:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 12:45:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493401.763349 (Exim 4.92) (envelope-from ) id 1pQSlr-0003W3-MO; Fri, 10 Feb 2023 12:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493401.763349; Fri, 10 Feb 2023 12:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlr-0003Vw-JV; Fri, 10 Feb 2023 12:44:55 +0000 Received: by outflank-mailman (input) for mailman id 493401; Fri, 10 Feb 2023 12:44:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQSlq-0003Vh-9S for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 12:44:54 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3056868-a940-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 13:44:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 462F62015B; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h12om-dWo-29; Fri, 10 Feb 2023 13:44:46 +0100 (CET) Received: from begin (p-gweduroam01.u-bordeaux.fr [147.210.179.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id EB59120158; Fri, 10 Feb 2023 13:44:45 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQSlg-005qZZ-0w; Fri, 10 Feb 2023 13:44:44 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3056868-a940-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 13:44:44 +0100 From: Samuel Thibault To: Juergen Gross Cc: Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Message-ID: <20230210124444.bc7siuuj5dwgf3pb@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , Andrew Cooper , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: > On 10.02.23 12:43, Andrew Cooper wrote: > > On 10/02/2023 10:46 am, Juergen Gross wrote: > > > diff --git a/lib/sys.c b/lib/sys.c > > > index 2f33c937..dc8a8c69 100644 > > > --- a/lib/sys.c > > > +++ b/lib/sys.c > > > @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > > > return fd; > > > } > > > -static struct mount_point mount_points[] = { > > > +#ifdef CONFIG_CONSFRONT > > > +#define STATIC_MNTS 4 > > > +#else > > > +#define STATIC_MNTS 2 > > > +#endif > > > > This ought to be > > > > #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) > > > > because it shows where the parts come from, and is much cleaner to add a > > 3rd one to in due course. > > In principle fine, but I'm not sure it is worth the effort to add > IS_ENABLED() support to Mini-OS. > > > That said, it would be simpler to just have a total mounts set at 16 or > > so?  Does a difference of two dynamic mounts depending on CONSFRONT > > actually matter? > > Probably not. Samuel, any thoughts on that? We can probably as well just have 16 mount entries indeed. Samuel From xen-devel-bounces@lists.xenproject.org Fri Feb 10 15:40:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 15:40:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493446.763367 (Exim 4.92) (envelope-from ) id 1pQVVZ-0001XQ-7H; Fri, 10 Feb 2023 15:40:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493446.763367; Fri, 10 Feb 2023 15:40:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQVVZ-0001XJ-4Y; Fri, 10 Feb 2023 15:40:17 +0000 Received: by outflank-mailman (input) for mailman id 493446; Fri, 10 Feb 2023 15:40:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQVVY-0001X9-4S for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 15:40:16 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 346f5cbf-a959-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 16:40:13 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by MW6PR12MB7085.namprd12.prod.outlook.com (2603:10b6:303:238::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 15:40:07 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 15:40:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 346f5cbf-a959-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZohWWnnXwrxto3WWnm0VQhGtPHVBG+yMlHtX+fLbBIjZX0jq8/Q2nlQ4NWjSt7J3ejtPeuQilNGRAKqTSY33lPz3JEYU2K3HkFljgoq5hSDNdmwtQHxrhIpgsISSxk0vak3He1RqCMUXsnw1D9Hx5y1CWd1w/qOr+sq4xOlhahHgId5Kq1WIvvdBXRkUrFp/XkWQ54RVeoq8Jd+wrIsa+7jaFZ3LdeT0ZorYRLKeOZihVNMZlgYXGqZoeXCPfIS50aBSUkqPb1lH/t2YH5r1XmgvDeeXwAu2ngJeTI6ppAqQE0XHls3dyZ7kaB1PknSQpUk5PZUqjXzGk9kfy0Ckug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CXC1ckvMjQ/POezF4mf58NIim0l8n17FtbycQXtWOFE=; b=EUUd4JVWEWrdb8lA1+b2IJqm/BgQC06xKNxfyA2jtG0TT2jTOIsrKZtDMFQjye/58RvhPiKD4Tm6tjI3BYc1PIqqrTlOdTlL5BQSxgaLPgv1bQLA+KBUgmrd3XCnSAdMfjfnOiJOL5QZ/bBOHB/ho44PM+Zw2lqtIz/9+GpF8eJgKlkdikth2z9TJbrrOV0zjllWm+TqGAgQ2NYBS5En435ypjC7kEEUeLb8UK4Z4CwRgag67liwpNwfNbSwgIKzU2mgqVpeGiH/RWizn3m74jFrz9r6VBCsK/iV5KmnmlvWiB05uQH/Mg5OwP4sc8XA3oQkASVpg6jgpnFw2LagmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CXC1ckvMjQ/POezF4mf58NIim0l8n17FtbycQXtWOFE=; b=WxSYLWm/vXrvBxQlehkkXzfndVGOAT0ZI2OxRNc1KWare66e85lYrfcnzrSqA3oBSeYZZLWmLQSJmDlIZZMyvI60OMG9fUSz58SFAZ0yW7kgPfaKbkkeQ4Q5hsY/4/kbMV8WhsEtFlLTZHn1+GyQ4RCY9Y4W+RVGaLncQu/Cb8s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <1e5d905c-0511-ed80-c899-e679d955775d@amd.com> Date: Fri, 10 Feb 2023 15:39:59 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> From: Ayan Kumar Halder In-Reply-To: <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0267.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::7) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|MW6PR12MB7085:EE_ X-MS-Office365-Filtering-Correlation-Id: 06675983-a5bb-465a-1ef1-08db0b7d15af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uXN4XT1TH49dHM8d5CNMRlT9ttTPei281ZIf+0EYFpWe8H28iayIfHGk2/wUvhdIEMlbf5a+VaHLIiGu0/6ROQzz9kA0QCloday5RzOugPPaBObm5x1q+K2/8PXvZ+D1ZBFSQCzzSnYlYIy8MOdrZeDTD9zqbLeVVOK5hoR4oZGt1JjT7ExAaNsr0o2x5KDmgx4VQqTE9IguKkLlGMACnt0mTPmka2ksxpZBjc74mZpNSWXQvaYaAZ3Ovx7zMcfz1/WtIQtCywbJqGe3qijauY0C93nM1nRsWtjk5Vc5+fTDKwyltOwksXpYhMCkex20KYb7CmNiyJ6y1EGDUUjec72EB2kGx8Q7FWy+C98E6ds8TdN4+iB3e09JGziz/MtV6wFsKlQm1JPQkEDt7Oaj4TH+5f1XT4JcNKGJnRtpbLmUWTKZzmZc7xH8Pl8WIjjHT1oEXPn5QLXUFl1cmUf3V6LC1UqgMW3BIPlhsmMg/od9bzx5iYkz+q6ICAen27Uwa1shz3xURNYGIg0kETZ6z6PWSdomOeHy4KtpMum4lqovMVBWO+MelBhZCDn5Abt9MA2Ss1ndX+tbk/OwvSh1ZcIGuzWqb0W5EwjEqBbJbhYzvz4eQWxSxKmEvAYdrz03zGIs+kA3m/TaNYHpdtBAL62ffWsfwvGkHuXu6e4J5vPSpJhUdFJhNwgh2Il9QuqjZ1yC4MCJDsycyBBCYLmlIhD9gmwu2JktmGTjH+wZVVo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(451199018)(6666004)(41300700001)(6506007)(8676002)(4326008)(66556008)(66946007)(66476007)(83380400001)(31696002)(38100700002)(36756003)(2616005)(53546011)(5660300002)(8936002)(26005)(186003)(6486002)(478600001)(110136005)(316002)(6512007)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjFBbmJMeFBlZllxejdTRWMwTmNtUVJhWnRyemgzVTk4dEdpdDh4b3dkUlVZ?= =?utf-8?B?NG1uVWdMcmNxUmZzRUlYeTBnUkJoYzVqeVNwR1BlTjZsRUF1c2VqSXhKZW5i?= =?utf-8?B?TFNYS1FqSFoyZzdDVzhFR1poaWNtUmdtcTFqRlg3dEVVWS94ZSs4d2dESDZO?= =?utf-8?B?RHBqNmdld2JSck90dXNqN29LR0tJd2UvdTVNTWVkNFpCT082ZFVhTjNMdmdo?= =?utf-8?B?Nis5NDI0eDNsOGtIc3AzNmdBVkQwelRRcklpbDJMK0I4WWRzRTB6UXlOTG0v?= =?utf-8?B?K01ZcTNUcWxDc2lTZmVBc1VHc3JjZzRmanUzcHlTZzYrTjBTcGY3OFFKNmJX?= =?utf-8?B?djcyeVM4bTIzNGtpS3FhVCt3cG1JeGpubTRZaFlLMzBEeW5zNXZ6NE5KYkxz?= =?utf-8?B?ZFB0TWt5WnRlMmlTVE5Gc1dPWHRRMW1JTDZqNzYxN3lEQlA2SXdPTE1jZFBC?= =?utf-8?B?cTZBWmlRNzRXU01ldjdBMUF6UHhXNlJSSzJuSlBvSFdQNzRMbXY3aU4vcFBB?= =?utf-8?B?R0pRbTU5ZjZPcDVJYVV6TnRrNTdPREQ2aENTUWdRWDhvUUdlTHZ0dWl2aUFC?= =?utf-8?B?RDJkZCtRTnM0MlZWVmhHdnQwa1BFZGova2duWVBHaEY0YjFNTEYxV2lIdWpZ?= =?utf-8?B?UVBEb0V3cjVaSTBaeTBmcCtnV01rNENJRnIyVEJkYTBReDdxWEpXU040QVZy?= =?utf-8?B?QUdPUWNTcGIwY3VRYUxrcW13TUJOcFBZSXBtN2FveFhKWW9DZWFOUXptOXdE?= =?utf-8?B?YWIwMkhZcGhsYmkwU0h6Uzc4VXRML3JadkNvY0ljd3BvZ3JNVXhJTkN0RGl5?= =?utf-8?B?dnJPNUtBTW9rdHBNRDlKMStscFdMSWo3dGRxR1NKT3o5c0g0UkNwajQ1Q1ll?= =?utf-8?B?RXN4Mm1MT3ZxQU84akZoUlBkRmhuWUp1ZS9mejJabzlWQXVUdHBoSFByRWlZ?= =?utf-8?B?OXBsODZqYURMVEhFVW1wRXJ1cXdYUitMaGo0bEk0SGpKSE1YYWg5Q1NuWVFa?= =?utf-8?B?TzMwRjRENWh0RFh1djhZL2dMTkZKekxmZ3FWcGo4RjlUa2RaVHJpTmxDUmov?= =?utf-8?B?N3ljWU9kOU1hcjRPNGZzZ3hWOGl4dDRia2lZL3l1NVljRWJkRDNWWFpkVkJY?= =?utf-8?B?eDJNUEE5dW0vVnE1Yzl1RlZ3R2ZXWVQwVEdUekZMZk9zVGFMMG5vSkJGSzJM?= =?utf-8?B?aE5UQ1QrWjBUTzM2V3c1cmdrL1NLTjM2cHc3bnBiZzBLTGcxNjhETndqT1NN?= =?utf-8?B?M1FXOU5jTWNlV1g5M3QxdVF1UTR3OEVyNjQzV0F5TzhZTllQMnRtQzgvYWtD?= =?utf-8?B?bUgyb1lEdGt2ejhNTTJ6WTZ4UTNVK055QjB5MnovWS8xSnF1L01mYTFzdC9n?= =?utf-8?B?d2laVzkvRVlaVHlUYXVWTFlwSTdjaVk3M2ZNSURXTk13NjdTb1kycmxSYXJR?= =?utf-8?B?RnVPRU9uaFlMWHIwSFNKRkpQYUI5ZHZOSDVzK1d6NkRRSGwvdjZ4bjdRRHRq?= =?utf-8?B?U0EyYUt4b1g5cVRCVzJFT3dyWU1jdnpsY3RLZFNIWU8wZkxxb1VaenlSOXBF?= =?utf-8?B?WWtzd0h1eXRhcVFDM0RyMTVaQzc5ZnZJb0FFdzhJWVR3azRXMEgzSFZ2M0Rw?= =?utf-8?B?eHYzdCtwMHdaQUJjOEh5WDVOV29ySHRXZWorWE1rMzIrMFVoRGFNcmJ1Rm5N?= =?utf-8?B?RFI0YzdnWDZDUEdZaGh1UG9KRkhqR1l1MUs2QWlwZVhzOFE2dHIxY3diaHl1?= =?utf-8?B?TU5GSncyeWtKOTdMdFpZUkZSVW9wMlFmc2E5ZXpxZGJhdy9NejRNNHNtZXR5?= =?utf-8?B?dS81UHFWNUR4SmhpNG5CVG04UmpZRWpSSUs4UlI4ZGd6VWRucDk2MHBFM3Fp?= =?utf-8?B?UE5tUVJpQUNjMjRIR1l5UGJtT3FRamVWa0p0ZytNVTZ2TlB1d0JOOExZL2JD?= =?utf-8?B?ZHVTMk1CS1RlS1hUbGplQzRqMVNsTS9QNTR3Z2lPZXlGR0U4Y0M4aEZEWERq?= =?utf-8?B?b0Q4bGR3YStOYjcvc3N4WUtqakx5SEJRSmZKRnZTM2ZzamI2Zkx4K2RzSnVV?= =?utf-8?B?eHU2MTN0S2hWNk10UXVXVUh3bU5CckhiZnZVUkpyckRuMVVacWMxSHNwcVNZ?= =?utf-8?Q?EE7oQNjubRGAtNd+3+6IPIn/n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06675983-a5bb-465a-1ef1-08db0b7d15af X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 15:40:06.8485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RcBP/LHhn3vLBrMP8gw9tuLubj+CAVR8asEG+2kIXm7b1a97p3XLbnKtGGrq4r4NyYY06uOBwc7UTLKbTjoDwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7085 On 09/02/2023 11:45, Julien Grall wrote: > Hi, Hi Julien, > > On 07/02/2023 15:34, Ayan Kumar Halder wrote: >> >> On 20/01/2023 11:06, Julien Grall wrote: >>> Hi Ayan, >> Hi Julien, >>> >>> On 17/01/2023 17:43, Ayan Kumar Halder wrote: >>>> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >>>> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >>>> "Virtualization Translation Control Register" for the bit >>>> descriptions. >>>> >>>> Signed-off-by: Ayan Kumar Halder >>>> --- >>>> Changes from - >>>> >>>> v1 - New patch. >>>> >>>>   xen/arch/arm/p2m.c | 10 +++++++--- >>>>   1 file changed, 7 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>>> index 948f199d84..cfdea55e71 100644 >>>> --- a/xen/arch/arm/p2m.c >>>> +++ b/xen/arch/arm/p2m.c >>>> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>>>       register_t val = >>>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>>>     #ifdef CONFIG_ARM_32 >>>> -    if ( p2m_ipa_bits < 40 ) >>>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>>>           panic("P2M: Not able to support %u-bit IPA at the moment\n", >>>>                 p2m_ipa_bits); >>>>   -    printk("P2M: 40-bit IPA\n"); >>>> -    p2m_ipa_bits = 40; >>>> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >>>> +    p2m_ipa_bits = PADDR_BITS; >>>> +#ifdef CONFIG_ARM_PA_32 >>>> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >>>> +#else >>>>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>>> +#endif >>> >>> I am wondering whether this is right time to switch to an array like >>> the arm64 code? This would allow to use 32-bit IPA also when Xen >>> support 64-bit physical address. >> >> In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the physical >> address range supported at runtime. This is then used as an index >> into pa_range_info[] to determine t0sz, root_order, etc. > > It is using both the ID_AA64MMFR0_EL1 but also p2m_ipa_bits to decide > the size. Ack. > >> >> However, for AArch32 I do not see an equivalent register (similar to >> ID_AA64MMFR0_EL1) or any register to determine the physical address >> range. Thus, I will prefer to keep the code as it is unless you >> suggest any alternative. > > I looked at the Arm Arm and indeed it doesn't look like there are > equivalent for ID_AA64MMFR0_EL1.PARange. > > However, my point was less about reading the system register but more > about the fact we could have the code a bit more generic and avoid the > assumption that PADDR_BITS is only modified when CONFIG_ARM_PA_32 is set. I had a rework at the patch. Please let me know if the following looks better. diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d84..bc3bdf5f3e 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2266,14 +2266,35 @@ void __init setup_virt_paging(void)      register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA;  #ifdef CONFIG_ARM_32 -    if ( p2m_ipa_bits < 40 ) +    static const struct { +        unsigned int pabits; /* Physical Address Size */ +        unsigned int t0sz;   /* Desired T0SZ */ +        unsigned int sl0;    /* Desired SL0 */ +    } pa_range_info[] __initconst = { +        [0] = { 32,     32,     1 }, +        [1] = { 40,     24,     1 }, +    }; +    int i = 0; + +    if ( p2m_ipa_bits < PADDR_BITS ) +        panic("P2M: Not able to support %u-bit IPA at the moment\n", +              p2m_ipa_bits); + +    printk("P2M: %u-bit IPA\n",PADDR_BITS); +    p2m_ipa_bits = PADDR_BITS; + +    for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) +        if ( p2m_ipa_bits == pa_range_info[i].pabits ) +            break; + +    if ( i == ARRAY_SIZE(pa_range_info) )          panic("P2M: Not able to support %u-bit IPA at the moment\n",                p2m_ipa_bits); -    printk("P2M: 40-bit IPA\n"); -    p2m_ipa_bits = 40; -    val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ -    val |= VTCR_SL0(0x1); /* P2M starts at first level */ +    val |= VTCR_T0SZ(pa_range_info[i].t0sz); +    val |= VTCR_SL0(pa_range_info[i].sl0); + - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Fri Feb 10 15:54:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 15:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493452.763377 (Exim 4.92) (envelope-from ) id 1pQVjY-0003KB-F6; Fri, 10 Feb 2023 15:54:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493452.763377; Fri, 10 Feb 2023 15:54:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQVjY-0003K4-CT; Fri, 10 Feb 2023 15:54:44 +0000 Received: by outflank-mailman (input) for mailman id 493452; Fri, 10 Feb 2023 15:54:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQVjX-0003Jy-48 for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 15:54:43 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0622.outbound.protection.outlook.com [2a01:111:f400:fe0c::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a62fe50-a95b-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 16:54:40 +0100 (CET) Received: from DU2PR04CA0221.eurprd04.prod.outlook.com (2603:10a6:10:2b1::16) by DU0PR08MB9155.eurprd08.prod.outlook.com (2603:10a6:10:416::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Fri, 10 Feb 2023 15:54:29 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::e1) by DU2PR04CA0221.outlook.office365.com (2603:10a6:10:2b1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.20 via Frontend Transport; Fri, 10 Feb 2023 15:54:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19 via Frontend Transport; Fri, 10 Feb 2023 15:54:28 +0000 Received: ("Tessian outbound 333ca28169fa:v132"); Fri, 10 Feb 2023 15:54:28 +0000 Received: from 9f58a4ada647.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F301EAC-E4C7-45DD-9466-A95A731D4384.1; Fri, 10 Feb 2023 15:54:22 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f58a4ada647.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 10 Feb 2023 15:54:22 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB7389.eurprd08.prod.outlook.com (2603:10a6:10:32d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Fri, 10 Feb 2023 15:54:20 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a%2]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 15:54:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a62fe50-a95b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98taQzGah3ofEajGEbOVk4UyDCJzptUQSk2tUKtT1iY=; b=M8GXyvRBAdB48KM/mxcuZ72s7hKDtREZSxjp5zY38ktSEotlurmSe1IeEoY3dk25zR+Z7VZrJRy/wqM7zBINDPDOTU2sGXE5VFK2ZzRzSC7dapLIPsZYjdauMnYKAaf0wgybS7lmg54DCCGMRP2JdCz/Tmg0f2owyUJODokljvc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 263af402050996e0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqS1Odk+uOm6+InbbQ+4zQcakyvcPh4qpBN9Q8MT2K5XwhtUEW0dxuqzcD5Mus0FFK/pKgm+j0HIFITCSpgoYGjkQP2Cl4PBR4jMZkotlZ/a6twQUNgWLH12Jccquo/vMaB43x0yBNFgoGHAeRf+OGBnFXll5iTeCVvC/sAc2J/vNHj47ToA1Ny5BGqfzR84Aga6Q8VFLPlJR01hwuRWDpfQl4TSg3i806a0rrRlAK401J34wrEw3GO5yFoaGPEnrXrvifeof+g9CHPsBQB3E4WdODI/LQ4iQaw5gX92BFJZt1PwPBiBTjH3jPxIl5mx3jIKnhDe6zOBsoJ7MRP/ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=98taQzGah3ofEajGEbOVk4UyDCJzptUQSk2tUKtT1iY=; b=bLA56P0vuo82Uea0xABkkTUPbKlgFg47vPTx8NnzqqTF+F+GNIOh244mtasDYFjzlGxXH3f6QBIS1k8DA51VV4HqRgiFR7KEWc1ytQf3a00vaSGpaeH+96/x+mvn5rbJKVk7DgjUoBpfdWiblDxH9R7uuHLxnJPEMSpGsPoqEzh6YtT2ul1Q6A4mZzr0wPs6pE1dyULYI2B296EKSMFUh+in1KEmoraHK4B8ZXPtdX/PxR6Yh6krpco259JKwuVg4my87tA9mqhllkOl6V77mIi4VXKmTB5z6kLIcopzbtpL32q3GqesHcTLE4JleOWEmeDmr6KMORuCzGWiayCzjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98taQzGah3ofEajGEbOVk4UyDCJzptUQSk2tUKtT1iY=; b=M8GXyvRBAdB48KM/mxcuZ72s7hKDtREZSxjp5zY38ktSEotlurmSe1IeEoY3dk25zR+Z7VZrJRy/wqM7zBINDPDOTU2sGXE5VFK2ZzRzSC7dapLIPsZYjdauMnYKAaf0wgybS7lmg54DCCGMRP2JdCz/Tmg0f2owyUJODokljvc= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 07/10] xen/physinfo: add arm SVE arch capability and vector length Thread-Topic: [PATCH 07/10] xen/physinfo: add arm SVE arch capability and vector length Thread-Index: AQHZNvbF5ObUISPUqkWspwE0cSOTMa67j3YAgAzSeIA= Date: Fri, 10 Feb 2023 15:54:19 +0000 Message-ID: <781EDC8B-B24C-431F-AB08-F2ACF64E4D4E@arm.com> References: <20230202110816.1252419-1-luca.fancellu@arm.com> <20230202110816.1252419-8-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB7389:EE_|DBAEUR03FT031:EE_|DU0PR08MB9155:EE_ X-MS-Office365-Filtering-Correlation-Id: fc2629d8-9029-4c97-31c7-08db0b7f176e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LhOKZSbYhDEwaHQxDTV4ZGyIdRIMpYEwLS3s+op0C7L79k1AxO/RsZvMboNrEaZEsyxvdxss/r0rKoGhoj3Hgro+b2799VOWcJsdcPN1EdDTo6+RHKTYi02cBRSlBgasYwFcI23cs/rGPDyLiJGhLnXysq93ifgPV7S/YJtrJcGxn3ysIvBxaTj8EkSvi1+ugkII9+ihOvtqKrPwynVwmqIAwqDMD9hxuZVEIFp1JFMRMN7GoTxW23e3ExyLrlxq/bbukXVFFUC44MdBUfIB4BQO61nafwZCJorb7kpmKtst04Sv5iArMtzScjOuZoT/7pd8VPyHinnnOgp0bjASVwMRUVH8Bg7AlhR8Z6DtK3t+rBha9DrR0bkyBEEjrl5U+HGVNlNxSEfiBwkRLaPiuWMrgADAph2KkNPosCh3wCrd0dHhVyy4sDlYm8tJnsgY+BM88A79NrlrntOazmmM73hvOnBjqE/aPoa121pGLKLBbFL+b0qdERtilPZiU/SKJphCJnf8sereX/YPw8SCnsGvjLAkwnDnBOf3FhlYzxobHTmDjY1mn5krAioaCylQrbNa4SNSNWEs+HxSdxoD8eI8l7+i5pCh98gQjv30a/+aV6hJ1ejojbglTu0kkdZTP94bPUnotZqIsls2XaSSynGurOgOhQx6I+avP86CfeMeL5wrROdgUkKW0/VUPBmlxDKBHBM+RCqGVslSza9kxO3FfQr0QbsXDWB9+yg2o00= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(451199018)(6512007)(5660300002)(186003)(26005)(478600001)(122000001)(8936002)(83380400001)(53546011)(2616005)(6506007)(2906002)(71200400001)(8676002)(36756003)(41300700001)(6486002)(4326008)(6916009)(38100700002)(76116006)(66556008)(33656002)(66946007)(66476007)(66446008)(64756008)(38070700005)(91956017)(316002)(54906003)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5EAAC0AB52B7D140BEAE1F534F818AD6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7389 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 83f523bb-5435-43d0-4534-08db0b7f120e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O3ulop5o5+q1j5YK0mafpdkqYrb/ibFT3b6Eud2l0wKCzHSJfEv0Eyro96I/5Z2ZQBewfs8YAtbWhJg6zZKq4Ey7xViGUTG6U8t5PVd1qKRfO2TELk7nEYJj+Z9UiwayXjrx5hEZr8YDBUtPlsr65NsMTzc2LHslkPq96XLnLC8hlx57t0EMs+ZEnkRojElfxPN4jOjcWASExNv8qoUuojlJhkIZG0medg0xmaiQCtWd1FFM3XSisnHFa88zocGrXKKyqMMJOnvlAf1It1ewn+WFIUh8jtg9vgjHxAK562tE4YyhECySEHITQVcgoHKlbOr1wqRU5l1THbRygTz1XAgplyyfFDkQYlvM6r7ArK9NBxCcqdqkP1JvW/lItOI499KDm3F7oNlql26o+81593EqbuhMlcQgIBcDhUUg+LLmZvwqeLp/pYLtnsCE92ViIAck3/E0CuEWg7O1wZ+sgl2av6OL/z5wAk7C4dOgipYKT3eiJgauJj6V5TJMtFCPyNl/Icw2c/kuKz95oZoI2lQ/v1VFV/cu4jKytlt41m6M9PhkZZ6/wB+6kMcl3mdhWcYcMzajYG4FSry+NisjR3CjymST86doFEoTm0JhZXHgjKLEP7KoyeQ2UyCFWGo0LgPrL8rkJFOknKpxNNtyco3lBvoCBbzyzcgHKUTaWEiJanyY6DqC/nlR2ArCRmu3P014fMyAZMnQ/NlXxy4GRg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199018)(40470700004)(46966006)(36840700001)(6506007)(83380400001)(47076005)(5660300002)(2906002)(36756003)(26005)(186003)(40460700003)(86362001)(478600001)(53546011)(33656002)(41300700001)(6512007)(6486002)(36860700001)(81166007)(40480700001)(336012)(82310400005)(82740400003)(70206006)(4326008)(70586007)(54906003)(8936002)(8676002)(316002)(6862004)(356005)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 15:54:28.4750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc2629d8-9029-4c97-31c7-08db0b7f176e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9155 DQoNCj4gT24gMiBGZWIgMjAyMywgYXQgMTI6MDUsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwMi4wMi4yMDIzIDEyOjA4LCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4gV2hlbiB0aGUgYXJtIHBsYXRmb3JtIHN1cHBvcnRzIFNWRSwgYWR2ZXJ0aXNlIHRo ZSBmZWF0dXJlIGJ5IGEgbmV3DQo+PiBmbGFnIGZvciB0aGUgYXJjaF9jYXBhYmlsaXRpZXMgaW4g c3RydWN0IHhlbl9zeXNjdGxfcGh5c2luZm8gYW5kIGFkZA0KPj4gYSBuZXcgZmllbGQgImFybV9z dmVfdmxfYml0cyIgd2hlcmUgb24gYXJtIHRoZXJlIGNhbiBiZSBzdG9yZWQgdGhlDQo+PiBtYXhp bXVtIFNWRSB2ZWN0b3IgbGVuZ3RoIGluIGJpdHMuDQo+PiANCj4+IFVwZGF0ZSB0aGUgcGFkZGlu Zy4NCj4+IA0KPj4gQnVtcCBYRU5fU1lTQ1RMX0lOVEVSRkFDRV9WRVJTSU9OIGZvciB0aGUgY2hh bmdlcy4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxs dUBhcm0uY29tPg0KPj4gLS0tDQo+PiBDaGFuZ2VzIGZyb20gUkZDOg0KPj4gLSBuZXcgcGF0Y2gN Cj4+IC0tLQ0KDQpIaSBKYW4sDQoNClRoYW5rcyBmb3IgeW91ciByZXZpZXcsDQoNCj4+IEhlcmUg SSBuZWVkIGFuIG9waW5pb24gZnJvbSBhcm0gYW5kIHg4NiBtYWludGFpbmVyLCBJIHNlZSB0aGVy ZSBpcyBubyBhcmNoDQo+PiBzcGVjaWZpYyBzdHJ1Y3R1cmUgaW4gc3RydWN0IHhlbl9zeXNjdGxf cGh5c2luZm8sIGh3X2NhcCBpcyB1c2VkIG9ubHkgYnkgeDg2DQo+PiBhbmQgbm93IGFyY2hfY2Fw YWJpbGl0aWVzIGFuZCB0aGUgbmV3IGFybV9zdmVfdmxfYml0cyB3aWxsIGJlIHVzZWQgb25seSBi eSBhcm0uDQo+PiBTbyBob3cgc2hvdWxkIHdlIHByb2NlZWQgaGVyZT8gU2hhbGwgd2UgY3JlYXRl IGEgc3RydWN0IGFyY2ggZm9yIGVhY2gNCj4+IGFyY2hpdGVjdHVyZSBhbmQgZm9yIGV4YW1wbGUg bW92ZSBhcmNoX2NhcGFiaWxpdGllcyBpbnNpZGUgaXQgKHJlbmFtaW5nIHRvDQo+PiBjYXBhYmls aXRpZXMpIGFuZCBldmVyeSBhcmNoIHNwZWNpZmljIGZpZWxkIGFzIHdlbGw/DQo+IA0KPiBDb3Vu dGVyIHF1ZXN0aW9uOiBXaHkgZG9uJ3QgeW91IHVzZSAocGFydCBvZikgYXJjaF9jYXBhYmlsaXRp ZXMgKGFuZCBub3QNCj4ganVzdCBhIHNpbmdsZSBiaXQpPyBJdCBsb29rcyB0byBiZSBlbnRpcmVs eSB1bnVzZWQgYXQgcHJlc2VudC4gVmVjdG9yDQo+IGxlbmd0aCBiZWluZyB6ZXJvIHdvdWxkIHN1 ZmZpY2llbnRseSBpbmRpY2F0ZSBhYnNlbmNlIG9mIHRoZSBmZWF0dXJlDQo+IHdpdGhvdXQgYSBz ZXBhcmF0ZSBib29sZWFuLg0KDQpZZXMgSSBjb3VsZCBoYXZlIHVzZWQganVzdCB0aGUgdmFsdWUg dG8gZGV0ZXJtaW5lIGlmIHRoZSBwbGF0Zm9ybSBpcyBTVkUgY2FwYWJsZQ0Kb3Igbm90LCBidXQg c2luY2UgdGhpcyBmaWVsZCB3YXMgdGhlcmUgKGV2ZW4gaWYgd2l0aCBubyB1c2VyKSBJIHdhcyB1 bnN1cmUgYWJvdXQNCnJlbmFtaW5nIGl0IGFuZCB1c2UgaXQgZm9yIHRoaXMgcHVycG9zZS4NCklu IHRoZSBlbmQgSSBkaWQgd2hhdCB3YXMgbW9yZSBsb2dpYyB0byBtZSBhdCB0aGUgbW9tZW50LCBh bmQgSSByZXNlcnZlZCBhIGZsYWcNCmluIGl0IGZvciBTVkUuDQoNCj4gDQo+IA0KPj4gKGlzIGh3 X2NhcCBvbmx5IGZvciB4ODY/KQ0KPiANCj4gSSBzdXBwb3NlIGl0IGlzLCBidXQgSSBhbHNvIGV4 cGVjdCBpdCB3b3VsZCBiZXR0ZXIgZ28gYXdheSB0aGFuIGJlIG1vdmVkLg0KPiBJdCBkb2Vzbid0 IGhvbGQgYSBjb21wbGV0ZSBzZXQgb2YgaW5mb3JtYXRpb24sIGFuZCBpdCBoYXMgYmVlbiBzdXBl cnNlZGVkLg0KPiANCj4gUXVlc3Rpb24gaXMgKGFuZCBJIHRoaW5rIEkgZGlkIHJhaXNlIHRoaXMg YmVmb3JlLCBwZXJoYXBzIGluIGRpZmZlcmVudA0KPiBjb250ZXh0KSB3aGV0aGVyIEFybSB3b3Vs ZG4ndCB3YW50IHRvIGZvbGxvdyB4ODYgaW4gaG93IGhhcmR3YXJlIGFzIHdlbGwNCj4gYXMgaHlw ZXJ2aXNvciBkZXJpdmVkIC8gdXNlZCBvbmVzIGFyZSBleHBvc2VkIHRvIHRoZSB0b29sIHN0YWNr DQo+IChYRU5fU1lTQ1RMX2dldF9jcHVfZmVhdHVyZXNldCkuIEkgZ3Vlc3MgdGhlcmUncyBub3Ro aW5nIHJlYWxseSBwcmVjbHVkaW5nDQo+IHRoYXQgZGF0YSB0byBjb25zaXN0IG9mIG1vcmUgdGhh biBqdXN0IGJvb2xlYW4gZmllbGRzLg0KDQpZZXMgSSBndWVzcyB0aGF0IGluZnJhc3RydWN0dXJl IGNvdWxkIHdvcmssIGhvd2V2ZXIgSSBkb27igJl0IGhhdmUgdGhlIGJhbmR3aWR0aCB0bw0KcHV0 IGl0IGluIHBsYWNlIGF0IHRoZSBtb21lbnQsIHNvIEkgd291bGQgbGlrZSB0aGUgQXJtIG1haW50 YWluZXJzIHRvIGdpdmUgbWUgYQ0Kc3VnZ2VzdGlvbiBvbiBob3cgSSBjYW4gZXhwb3NlIHRoZSB2 ZWN0b3IgbGVuZ3RoIHRvIFhMIGlmIHB1dHRpbmcgaXRzIHZhbHVlIGhlcmUNCm5lZWRzIHRvIGJl IGF2b2lkZWQNCg0KPiANCj4+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9zeXNjdGwuaA0KPj4g KysrIGIveGVuL2luY2x1ZGUvcHVibGljL3N5c2N0bC5oDQo+PiBAQCAtMTgsNyArMTgsNyBAQA0K Pj4gI2luY2x1ZGUgImRvbWN0bC5oIg0KPj4gI2luY2x1ZGUgInBoeXNkZXYuaCINCj4+IA0KPj4g LSNkZWZpbmUgWEVOX1NZU0NUTF9JTlRFUkZBQ0VfVkVSU0lPTiAweDAwMDAwMDE1DQo+PiArI2Rl ZmluZSBYRU5fU1lTQ1RMX0lOVEVSRkFDRV9WRVJTSU9OIDB4MDAwMDAwMTYNCj4gDQo+IFdoeT8g WW91IC4uLg0KPiANCj4+IEBAIC0xMDQsNyArMTEwLDggQEAgc3RydWN0IHhlbl9zeXNjdGxfcGh5 c2luZm8gew0KPj4gICAgIHVpbnQzMl90IGNwdV9raHo7DQo+PiAgICAgdWludDMyX3QgY2FwYWJp bGl0aWVzOy8qIFhFTl9TWVNDVExfUEhZU0NBUF8/Pz8gKi8NCj4+ICAgICB1aW50MzJfdCBhcmNo X2NhcGFiaWxpdGllczsvKiBYRU5fU1lTQ1RMX1BIWVNDQVBfe1g4NixBUk0sLi4ufV8/Pz8gKi8N Cj4+IC0gICAgdWludDMyX3QgcGFkOw0KPj4gKyAgICB1aW50MTZfdCBhcm1fc3ZlX3ZsX2JpdHM7 DQo+PiArICAgIHVpbnQxNl90IHBhZDsNCj4+ICAgICB1aW50NjRfYWxpZ25lZF90IHRvdGFsX3Bh Z2VzOw0KPj4gICAgIHVpbnQ2NF9hbGlnbmVkX3QgZnJlZV9wYWdlczsNCj4+ICAgICB1aW50NjRf YWxpZ25lZF90IHNjcnViX3BhZ2VzOw0KPiANCj4gLi4uIGFkZCBubyBuZXcgZmllbGRzLCBhbmQg dGhlIG9ubHkgcHJvZHVjZXIgb2YgdGhlIGRhdGEgemVyby1maWxscyB0aGUNCj4gc3RydWN0IGZp cnN0IHRoaW5nLg0KDQpZZXMgdGhhdCBpcyByaWdodCwgSSB3aWxsIHdhaXQgdG8gdW5kZXJzdGFu ZCBob3cgSSBjYW4gcHJvY2VlZCBoZXJlOg0KDQoxKSByZW5hbWUgYXJjaF9jYXBhYmlsaXRpZXMg dG8gYXJtX3N2ZV92bF9iaXRzIGFuZCBwdXQgdmVjdG9yIGxlbmd0aCB0aGVyZS4NCjIpIGxlYXZl IGFyY2hfY2FwYWJpbGl0aWVzIHVudG91Y2hlZCwgbm8gZmxhZyBjcmVhdGlvbi9zZXR0aW5nLCBj cmVhdGUgdWludDMyX3QgYXJtX3N2ZV92bF9iaXRzIGZpZWxkIHJlbW92aW5nIOKAnHBhZOKAnSwN CiAgICBVc2UgaXRzIHZhbHVlIHRvIGRldGVybWluZSBpZiBTVkUgaXMgcHJlc2VudCBvciBub3Qu DQozKSA/Pw0KDQpUaGFuayB5b3UNCg0KQ2hlZXJzLA0KTHVjYQ0KDQo+IA0KPiBKYW4NCg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Feb 10 16:19:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 16:19:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493467.763389 (Exim 4.92) (envelope-from ) id 1pQW7O-0006yA-KH; Fri, 10 Feb 2023 16:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493467.763389; Fri, 10 Feb 2023 16:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQW7O-0006y3-H1; Fri, 10 Feb 2023 16:19:22 +0000 Received: by outflank-mailman (input) for mailman id 493467; Fri, 10 Feb 2023 16:19:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQW7M-0006xw-Ir for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 16:19:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQW7M-0003GH-4F; Fri, 10 Feb 2023 16:19:20 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQW7L-0004zp-Rg; Fri, 10 Feb 2023 16:19:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=p6+oTOtiOTmEaR8NKZP2gD5Jp5xbNhPjcvyQOOSxhJY=; b=G725kLh6T59IPHHqk8e56agJmP ESDJlG7XfnSdCpNld+CPhykfjCAWRREtpJVCewTmaMWJg3plul7J8FRp/0ogqV73/rhvOLOPxe0Yk y3fdd8Mvh8J8QG52irB/8M3p0BwUHDbVTPZR3hGS7c1HabNF1/xuc/ysw+lvBz+DbNQ4=; Message-ID: <5eb92203-2d99-7dfc-4f01-d92b7a23c3e5@xen.org> Date: Fri, 10 Feb 2023 16:19:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> <1e5d905c-0511-ed80-c899-e679d955775d@amd.com> From: Julien Grall In-Reply-To: <1e5d905c-0511-ed80-c899-e679d955775d@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 10/02/2023 15:39, Ayan Kumar Halder wrote: > > On 09/02/2023 11:45, Julien Grall wrote: >> Hi, > Hi Julien, >> >> On 07/02/2023 15:34, Ayan Kumar Halder wrote: >>> >>> On 20/01/2023 11:06, Julien Grall wrote: >>>> Hi Ayan, >>> Hi Julien, >>>> >>>> On 17/01/2023 17:43, Ayan Kumar Halder wrote: >>>>> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >>>>> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >>>>> "Virtualization Translation Control Register" for the bit >>>>> descriptions. >>>>> >>>>> Signed-off-by: Ayan Kumar Halder >>>>> --- >>>>> Changes from - >>>>> >>>>> v1 - New patch. >>>>> >>>>>   xen/arch/arm/p2m.c | 10 +++++++--- >>>>>   1 file changed, 7 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>>>> index 948f199d84..cfdea55e71 100644 >>>>> --- a/xen/arch/arm/p2m.c >>>>> +++ b/xen/arch/arm/p2m.c >>>>> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>>>>       register_t val = >>>>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>>>>     #ifdef CONFIG_ARM_32 >>>>> -    if ( p2m_ipa_bits < 40 ) >>>>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>>>>           panic("P2M: Not able to support %u-bit IPA at the moment\n", >>>>>                 p2m_ipa_bits); >>>>>   -    printk("P2M: 40-bit IPA\n"); >>>>> -    p2m_ipa_bits = 40; >>>>> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >>>>> +    p2m_ipa_bits = PADDR_BITS; >>>>> +#ifdef CONFIG_ARM_PA_32 >>>>> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >>>>> +#else >>>>>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>>>> +#endif >>>> >>>> I am wondering whether this is right time to switch to an array like >>>> the arm64 code? This would allow to use 32-bit IPA also when Xen >>>> support 64-bit physical address. >>> >>> In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the physical >>> address range supported at runtime. This is then used as an index >>> into pa_range_info[] to determine t0sz, root_order, etc. >> >> It is using both the ID_AA64MMFR0_EL1 but also p2m_ipa_bits to decide >> the size. > Ack. >> >>> >>> However, for AArch32 I do not see an equivalent register (similar to >>> ID_AA64MMFR0_EL1) or any register to determine the physical address >>> range. Thus, I will prefer to keep the code as it is unless you >>> suggest any alternative. >> >> I looked at the Arm Arm and indeed it doesn't look like there are >> equivalent for ID_AA64MMFR0_EL1.PARange. >> >> However, my point was less about reading the system register but more >> about the fact we could have the code a bit more generic and avoid the >> assumption that PADDR_BITS is only modified when CONFIG_ARM_PA_32 is set. > > I had a rework at the patch. Please let me know if the following looks > better. > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 948f199d84..bc3bdf5f3e 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -2266,14 +2266,35 @@ void __init setup_virt_paging(void) >      register_t val = > VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; > >  #ifdef CONFIG_ARM_32 > -    if ( p2m_ipa_bits < 40 ) > +    static const struct { > +        unsigned int pabits; /* Physical Address Size */ > +        unsigned int t0sz;   /* Desired T0SZ */ > +        unsigned int sl0;    /* Desired SL0 */ Hmmm... Why don't you include the root order? In fact... > +    } pa_range_info[] __initconst = { > +        [0] = { 32,     32,     1 }, > +        [1] = { 40,     24,     1 }, ... looking at the ARMv7 specification (see B3-1345 in ARM DDI 0406C.d), the root page-table is only concatenated for 40-bits. > +    }; > +    int i = 0; > + > +    if ( p2m_ipa_bits < PADDR_BITS ) > +        panic("P2M: Not able to support %u-bit IPA at the moment\n", > +              p2m_ipa_bits); This check seems unnecessary now. > + > +    printk("P2M: %u-bit IPA\n",PADDR_BITS); > +    p2m_ipa_bits = PADDR_BITS; > + > +    for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) > +        if ( p2m_ipa_bits == pa_range_info[i].pabits ) > +            break; > + > +    if ( i == ARRAY_SIZE(pa_range_info) ) >          panic("P2M: Not able to support %u-bit IPA at the moment\n", >                p2m_ipa_bits); > > -    printk("P2M: 40-bit IPA\n"); > -    p2m_ipa_bits = 40; > -    val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ > -    val |= VTCR_SL0(0x1); /* P2M starts at first level */ > +    val |= VTCR_T0SZ(pa_range_info[i].t0sz); > +    val |= VTCR_SL0(pa_range_info[i].sl0); > + I think you can share a lot of code between arm64 and arm32. A diff below (not tested): diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 91df922e1c9f..05f26780a29d 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -14,16 +14,10 @@ /* Holds the bit size of IPAs in p2m tables. */ extern unsigned int p2m_ipa_bits; -#ifdef CONFIG_ARM_64 extern unsigned int p2m_root_order; extern unsigned int p2m_root_level; #define P2M_ROOT_ORDER p2m_root_order #define P2M_ROOT_LEVEL p2m_root_level -#else -/* First level P2M is always 2 consecutive pages */ -#define P2M_ROOT_ORDER 1 -#define P2M_ROOT_LEVEL 1 -#endif struct domain; diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d848f..6fda0b92230a 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2264,17 +2264,6 @@ void __init setup_virt_paging(void) { /* Setup Stage 2 address translation */ register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; - -#ifdef CONFIG_ARM_32 - if ( p2m_ipa_bits < 40 ) - panic("P2M: Not able to support %u-bit IPA at the moment\n", - p2m_ipa_bits); - - printk("P2M: 40-bit IPA\n"); - p2m_ipa_bits = 40; - val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ - val |= VTCR_SL0(0x1); /* P2M starts at first level */ -#else /* CONFIG_ARM_64 */ static const struct { unsigned int pabits; /* Physical Address Size */ unsigned int t0sz; /* Desired T0SZ, minimum in comment */ @@ -2286,29 +2275,26 @@ void __init setup_virt_paging(void) [0] = { 32, 32/*32*/, 0, 1 }, [1] = { 36, 28/*28*/, 0, 1 }, [2] = { 40, 24/*24*/, 1, 1 }, +#ifdef CONFIG_ARM_64 [3] = { 42, 22/*22*/, 3, 1 }, [4] = { 44, 20/*20*/, 0, 2 }, [5] = { 48, 16/*16*/, 0, 2 }, [6] = { 52, 12/*12*/, 4, 2 }, [7] = { 0 } /* Invalid */ +#endif }; unsigned int i; unsigned int pa_range = 0x10; /* Larger than any possible value */ +#ifdef CONFIG_ARM_64 /* * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured * with IPA bits == PA bits, compare against "pabits". */ if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; - - /* - * cpu info sanitization made sure we support 16bits VMID only if all - * cores are supporting it. - */ - if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) - max_vmid = MAX_VMID_16_BIT; +#endif /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) @@ -2324,12 +2310,22 @@ void __init setup_virt_paging(void) if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", pa_range); - val |= VTCR_PS(pa_range); - val |= VTCR_TG0_4K; +#ifdef CONFIG_ARM_64 + /* + * cpu info sanitization made sure we support 16bits VMID only if all + * cores are supporting it. + */ + if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) + max_vmid = MAX_VMID_16_BIT; /* Set the VS bit only if 16 bit VMID is supported. */ if ( MAX_VMID == MAX_VMID_16_BIT ) val |= VTCR_VS; +#endif + + val |= VTCR_PS(pa_range); + val |= VTCR_TG0_4K; + val |= VTCR_SL0(pa_range_info[pa_range].sl0); val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); @@ -2341,7 +2337,7 @@ void __init setup_virt_paging(void) p2m_ipa_bits, pa_range_info[pa_range].pabits, ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); -#endif + printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 16:43:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 16:43:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493475.763400 (Exim 4.92) (envelope-from ) id 1pQWUh-0002An-HX; Fri, 10 Feb 2023 16:43:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493475.763400; Fri, 10 Feb 2023 16:43:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQWUh-0002Ag-EG; Fri, 10 Feb 2023 16:43:27 +0000 Received: by outflank-mailman (input) for mailman id 493475; Fri, 10 Feb 2023 16:43:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQWUf-0002AW-Kn; Fri, 10 Feb 2023 16:43:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQWUf-0003hw-Ha; Fri, 10 Feb 2023 16:43:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQWUf-00028g-4U; Fri, 10 Feb 2023 16:43:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQWUf-0007Wy-40; Fri, 10 Feb 2023 16:43:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=m+wDdZYFExVk0F9cZZfwzYdyK8Pt32uyUz5gU6pZkyc=; b=z9AFqWLvHa39+rfHxTSAzG7pXC LQJrCTCJPi6wax7vIqRdQz9Js9i0PmFEgJmeQ5wwYleGditsx9ww4delTh2iGnxr6P0YL83/YtwNn fDDah1eV0znwcTm1blmY+0hY3fEEIjzL8cm/7WstHfLoCgnfoFG05XfmerrmD3sQes0Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176771: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-xsm:debian-install:fail:heisenbug linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=35674e787518768626d3a0ffce1c13a7eeed922d X-Osstest-Versions-That: linux=0983f6bf2bfc0789b51ddf7315f644ff4da50acb From: osstest service owner Date: Fri, 10 Feb 2023 16:43:25 +0000 flight 176771 linux-linus real [real] flight 176869 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176771/ http://logs.test-lab.xenproject.org/osstest/logs/176869/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-xsm 12 debian-install fail pass in 176869-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail in 176869 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176667 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176667 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176667 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176667 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176667 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 35674e787518768626d3a0ffce1c13a7eeed922d baseline version: linux 0983f6bf2bfc0789b51ddf7315f644ff4da50acb Last test of basis 176667 2023-02-08 20:26:33 Z 1 days Testing same since 176771 2023-02-09 18:42:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adham Faris Alan Stern Allen Hubbe Amir Tzin Amritha Nambiar Anastasia Belova Anirudh Venkataramanan Arnd Bergmann Arınç ÜNAL Basavaraj Natikar Bastien Nocera Benedict Wong Benjamin Tissoires Bharathi Sreenivas Brett Creeley Carlos O'Donell Casper Andersson Christian Hopps Clément Léger Dan Carpenter Dan Carpenter David S. Miller Devid Antonio Filoni Dmitry Safonov <0x7f454c46@gmail.com> Dragos Tatulea Eric Dumazet Frank Wunderlich Gurucharan G (A Contingent worker at Intel) Haiyang Zhang Hangbin Liu Heiner Kallweit Herbert Xu Herton R. Krzesinski Ido Schimmel Jakub Andrysiak Jakub Kicinski Jay Vosburgh Jiawen Wu Jiri Kosina Jiri Pirko Julian Anastasov Karen Ostrowska Kevin Yang Linus Torvalds Luka Guzenko Maher Sanalla Marc Kleine-Budde Marcin Szycik Marco Rodolfi marco.rodolfi@tuta.io Marek Szlosek Mario Limonciello Matthieu Baerts Michael Kelley Michal Simek Michal Swiatkowski Naama Meir Neel Patel Oleksij Rempel Paolo Abeni Paulo Alcantara (SUSE) Pietro Borrello Qi Zheng Radhey Shyam Pandey Richard van Schagen Saeed Mahameed Sasha Neftin Shannon Nelson Shay Drory Simon Horman Steffen Klassert Steve French Sujai Buvaneswaran Takahiro Fujii Tariq Toukan Tobias Klausmann Tony Nguyen Vlad Buslov Vladimir Oltean Xin Zhao Yevgeny Kliteynik Yu Xiao Zhang Changzhong ZhaoLong Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 0983f6bf2bfc..35674e787518 35674e787518768626d3a0ffce1c13a7eeed922d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Feb 10 17:52:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 17:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493491.763411 (Exim 4.92) (envelope-from ) id 1pQXYy-00025U-KZ; Fri, 10 Feb 2023 17:51:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493491.763411; Fri, 10 Feb 2023 17:51:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQXYy-00025N-Gs; Fri, 10 Feb 2023 17:51:56 +0000 Received: by outflank-mailman (input) for mailman id 493491; Fri, 10 Feb 2023 17:51:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQXYw-00025H-Df for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 17:51:54 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20613.outbound.protection.outlook.com [2a01:111:f400:7e88::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 988f046b-a96b-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 18:51:52 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SA1PR12MB6824.namprd12.prod.outlook.com (2603:10b6:806:25f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 17:51:47 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6086.019; Fri, 10 Feb 2023 17:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 988f046b-a96b-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UMBvu7xyG5b9I/8eUrUb5eBsHwQbu1ofm6kEW93z3fNaF3hnUqG+qEBOqsyFmsW5d7kptof/4tuu+7aEIrs7GaJoQEbXCBNw52SIg+ecmJzP1IcBmPOqxjpMUHNMU8+ypH1VdSz42oDbmomuQYACqsw9Bg8JpYW9J96FbfxhvImVnW8AEZLy99jvOZXmaXBsq7Ckjz58PBa8Iz/FEWszDXd0XWphUBGDjRHpqMXRjSo9nPbhLhwPCuBR4uM5Z3nKca/PW92sVXfbymCpvZT0NHvo/8tAPyCjSem+2X1q19WPhHq1VyPKzq1sN9o9xOAn0KVF9Ia2eT+xLhD7R2v0cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o9dJaofF2mMFAjIJachcFyElqYhc42IHerTfIkQO7vY=; b=Nj7ZNU9RF1pJmPX7lh1HdMajdX7BW8GiyHQi0YqGVlrjk+1Qvr95OMG4yRAT7OZDafggyWPbhnbnol/10e42J7itbA88aN/wkgzqqO3JhWhpu/9jw1tbV8oSYLkrEAuWWMIW1cxiEy9O4Vg4/vvPoLn3koUwjnN4MkbYWYcwr8flgVc1aJpHQDEo8cs7/PXl3qizPWSz3H3IRKk0LpCBZTlTxzj9AYCmg29CA71l7mF4ZiT6kfCACmuIoV2oYKJIAaznuaW7fiBXhjbSeXM0urwIHIjoOXSeY9n2S6qPG0RQxbkRioUn2CW32rLUTPSmRfJlNYp8ULRfaL5dIxz+KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o9dJaofF2mMFAjIJachcFyElqYhc42IHerTfIkQO7vY=; b=t20UsrUhd4e3o0AcF2yxUahe6p+5uwLHP5h3Y+gQkvfEd82whPQaTFrRCWwiodg8gqB2DvPy84ypHJf9PCShvLHxMv6AokesIfh4unehYNYebUQUzMtMxTluX3f/0ge+6p5Pzanf15gjW69En3Gl+I4QU1vs+Xzsc1yFCwf2n6U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <3b3c3846-5464-4914-3b28-f451f7e70c9a@amd.com> Date: Fri, 10 Feb 2023 17:51:41 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> <1e5d905c-0511-ed80-c899-e679d955775d@amd.com> <5eb92203-2d99-7dfc-4f01-d92b7a23c3e5@xen.org> From: Ayan Kumar Halder In-Reply-To: <5eb92203-2d99-7dfc-4f01-d92b7a23c3e5@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0303.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::20) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SA1PR12MB6824:EE_ X-MS-Office365-Filtering-Correlation-Id: 34e33f90-d99e-4ce1-248f-08db0b8f7abb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sknLyqt5Twd5XBPv1ei0HafzWuXDWR8433amWeMVlwTq8Clys68CgJ0AfnEp002dxbyRlWOGZIaK0rcL+PPOvFRUX0yF5gGOcgMXIC8VsgAxE+ybwv40BQd5qC+coRC/76cMHR0oABCyL8jEOcCSRXdY0n/kyg4pnSFyuo+xQxodJZ+qhzrYs/c93g3vNOfPqHls3vdDv8INEvjCeVChy+7bM1ds/xgK4oB8bZKfXJ0yPB/6ob4Qxe/LcAs5ndUT/w6qCf58nLDpPL2d/9iUmFH+l/HOggZ9pOLVKyMl0xC7gP/rs9Swn/y/RiWf/cYAVMRWrTarI+0yYE9Vi2/WOj/j5WfnQoboWQxxAL3qW58i9HfUILgc97UXsz74h/CYNIo4CuCDeIYUHTCAamcvlAzo17R3WmC/iVNDvUmX8KO5spxfJKOWizCg7bOhfaZQlO6UJSN1ocvc9fvJjG1n05kQSwPWL2liH/slV6IzqxcprQZ1l+jTI+hQTD5+G4chskKMTil8giTVMdoMqzIVVXSfhyxUhN5PcUauq/aFzGA8FZgFuaXNSsMo2TDp9kN+PZ6nu2i+p0YFpCYR5PgMTcWtILRW3tM/NiXQDmpRBp8wy4TjwKgq3hS/cY2xPfZXXeFvMys5IJ/b2TyNoN9W+NpXsh4tmsYGamHnugAPTP+k/tk9CwUc9nzJDXqCIzp2FvlTr09AmfBkuYn9fKhZprOmXTPVqAakeaeQbbdmdPk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(38100700002)(6512007)(26005)(2616005)(83380400001)(186003)(36756003)(66946007)(110136005)(316002)(4326008)(66556008)(66476007)(478600001)(6486002)(31696002)(6506007)(6666004)(53546011)(8936002)(31686004)(8676002)(5660300002)(41300700001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWQxZlFrblRreHZoK1FFNTZyT05qZUZwSnNuWTlPb2hhc2E2YlFvT0dNV2J6?= =?utf-8?B?K1dQTjhPZWdmTEIrU09jOGg1WDRmaTM5aFlabHp2MjlTWGhkRnNMMkI3WjN4?= =?utf-8?B?NWhhSWJpbWQ3bXNVOXhDR3RHYUlwa082dFRydWhWQm0wTElvYjdZZVJjYURR?= =?utf-8?B?Mk1MWFA2VmdTc1VkVlB5Q2drRUM3VG91OTlXb3ZhMmhTVW45THhjRUpKbkxr?= =?utf-8?B?MHBHRVRpOFdzUmRubllwMGxYR05nWVViUW5HNmVUYzBGRGJ4M0VvNklUYVVX?= =?utf-8?B?NnJFK3F1L1VzRzhnNDZwbDJWaWRVR2pQL2JybFR6dFVsbVNTdWhCT3ZyR3lr?= =?utf-8?B?TlVOYWlMNXRwSXJrMitiVlVLd28xNStHcUU0ZEdpOXhPSXN1czNyR0xTQXk5?= =?utf-8?B?QWNEdHQyd3VyRnVTdlBqOEFYRWlEMDVKSUI3cHFDU2YyY1ZMSzhyM0pQbHBk?= =?utf-8?B?Q1hjYkltTFR5bkhVVDN3NHk1SzROUzZQSHVFTy9tcDBNNlhOakwrZlFad0Jq?= =?utf-8?B?VnluUHptQzh6eGgrNlhBNXQ0UUZYK3RsMnd4T0p1VEt5a2RjN1FjOWo4QlV2?= =?utf-8?B?MzlWR3FHMmhhZUlMeEdBUmxNUjd5THRURlBJdGw0WDJWbUtrNWxnUndMaE42?= =?utf-8?B?TGhUd3hEZis2VDY2bllPOERXZ2s0eHNMcnVpMEVxTXF2Qm01b0xnWVpxNXpV?= =?utf-8?B?eEJBNERtUGpteG9kZTZTRy9KTis5VmJORFRZUUZHZTZVazF3WDgrRDI0Mlo2?= =?utf-8?B?M2pkeEtUZGcwU2tzM1JrbTJYS0p1UzBJYmtCTEpsVUFQeTlDSjlXak5xeXB0?= =?utf-8?B?bXNaeG1CS1M2eURpSEhkWXNSRlBCMjVna014OFpPMUhWcXZHcmxLZmdyODZQ?= =?utf-8?B?WE5sRGVUd1dSZE4wTWR3OWJYYnhTSDBPOC85WXRRVFFIYkozd3VQeitEZXlr?= =?utf-8?B?d2t6UGxGOU1FSFd2ck9LN1lkWFI4aldaUXY1cG1XZm5MQVRuSkxQNitTQThT?= =?utf-8?B?T1Y1RjRzMUwwa1dPVEh1czE5Z0JTV3k3MzZaRUFzZi9YSjk1UnhFV0JlRTg5?= =?utf-8?B?QVNjclUzLzV6TnFMcDZ0QS95Z1Q1NmhKeWR6azNoY1VKV1Y4YUl4UERXYk1D?= =?utf-8?B?YThQL1JMZmZDSkVLUm5aQjB3VkszY1NmSTBDbGxCbVFtdy9mZjFNbk1pYjB1?= =?utf-8?B?ZlNzcXVLUWRkUTdoV3M0cVFOS05NTHlGcEZ2ei9XUmY4V3h2Mi9SRXU2MnFn?= =?utf-8?B?UnBFWUdnTTQvQXNqczBraWxpbVcreWFKRTFSV1JLWlZNcGdRTzl1OGN0SUV1?= =?utf-8?B?emM5RzRoTmVDVlVVZ2w3VFUvNFV2L09RMGd2cGo3UHhQMmFEZElrZkFMbFIw?= =?utf-8?B?TVlsb05XTmZNQkhiOGJwUjdTVWE5anBQWHdnU2VqcnN5VmJWaUU3Tm5qT0xJ?= =?utf-8?B?MmN4WlhKVU1FTUMza29Ic1VCOUs1VFUvbTNJdzBOVTk2a2grRDlDUE14anl2?= =?utf-8?B?RC9pUWdTOXZWL3BQUWxQY2FxdG4xeG9wL2lSdzV1clJ6T0pmOXp5UWprSnJT?= =?utf-8?B?RUdibk4yUnFwUE9Gc3I3alM2c1BKc3p4cXVUeVhlTVE5VldDSEcyNDZlWVB6?= =?utf-8?B?eHc3eEdlNFdDdklvZG5EWVI1eHB3ZFdYSjd4RUZUaVVTb3VlcWFGcEtSRmMx?= =?utf-8?B?elV1NkprUzhMVmVHc1RiZ3BKUDdNVDd6T1NMZTdCSzNaRDZPQS92Y1lYQ0Ex?= =?utf-8?B?eWdRaElXaE1jVC90b0dpa2FxYmdGQ1NkR25Lbjc5ajRNRjJWTW1RWDdtcURt?= =?utf-8?B?aVFINDFwdlFXVjhabVQ1am4rY09jSmNzZG94Ni9hcmlWMGREWTRkK1Rjc0lk?= =?utf-8?B?dE1KTVNkdlZ6ejY1MFljOGhuTTJCTzdOaVkrTTZHMTkveEp5Y2xOT2x3bDlr?= =?utf-8?B?WGplcnJTcGx3RVUyVEtNcmlNbkZWRDVocEVuYmVHSnZJbWFremo2NC91R09R?= =?utf-8?B?aXlWNE1BVnZ1WjhnS3Y5Z3ZYQnY3SzBFaEJOdmJzMjU0UGlZdDBROTZWb1dK?= =?utf-8?B?dzZid2JzQnJJbE1oUUFIN29JOW1IQm82M1FlUFkrOFhhYmtybVNRQ1hjOFg1?= =?utf-8?Q?wN7z1rA+eyGBlHc9vYei2Zuqm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e33f90-d99e-4ce1-248f-08db0b8f7abb X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:51:47.3183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YMp9tS5x7ZgNTBpANs8BVS/28z8ZVR0MU7/I8UUJEzm6F+4Z2pqiWt6qXIIRZmvAwZstb5HcM6RJBsupebwSpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6824 On 10/02/2023 16:19, Julien Grall wrote: > Hi, Hi Julien, I need some inputs. > > On 10/02/2023 15:39, Ayan Kumar Halder wrote: >> >> On 09/02/2023 11:45, Julien Grall wrote: >>> Hi, >> Hi Julien, >>> >>> On 07/02/2023 15:34, Ayan Kumar Halder wrote: >>>> >>>> On 20/01/2023 11:06, Julien Grall wrote: >>>>> Hi Ayan, >>>> Hi Julien, >>>>> >>>>> On 17/01/2023 17:43, Ayan Kumar Halder wrote: >>>>>> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >>>>>> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >>>>>> "Virtualization Translation Control Register" for the bit >>>>>> descriptions. >>>>>> >>>>>> Signed-off-by: Ayan Kumar Halder >>>>>> --- >>>>>> Changes from - >>>>>> >>>>>> v1 - New patch. >>>>>> >>>>>>   xen/arch/arm/p2m.c | 10 +++++++--- >>>>>>   1 file changed, 7 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>>>>> index 948f199d84..cfdea55e71 100644 >>>>>> --- a/xen/arch/arm/p2m.c >>>>>> +++ b/xen/arch/arm/p2m.c >>>>>> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>>>>>       register_t val = >>>>>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>>>>>     #ifdef CONFIG_ARM_32 >>>>>> -    if ( p2m_ipa_bits < 40 ) >>>>>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>>>>>           panic("P2M: Not able to support %u-bit IPA at the >>>>>> moment\n", >>>>>>                 p2m_ipa_bits); >>>>>>   -    printk("P2M: 40-bit IPA\n"); >>>>>> -    p2m_ipa_bits = 40; >>>>>> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >>>>>> +    p2m_ipa_bits = PADDR_BITS; >>>>>> +#ifdef CONFIG_ARM_PA_32 >>>>>> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >>>>>> +#else >>>>>>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>>>>> +#endif >>>>> >>>>> I am wondering whether this is right time to switch to an array >>>>> like the arm64 code? This would allow to use 32-bit IPA also when >>>>> Xen support 64-bit physical address. >>>> >>>> In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the >>>> physical address range supported at runtime. This is then used as >>>> an index into pa_range_info[] to determine t0sz, root_order, etc. >>> >>> It is using both the ID_AA64MMFR0_EL1 but also p2m_ipa_bits to >>> decide the size. >> Ack. >>> >>>> >>>> However, for AArch32 I do not see an equivalent register (similar >>>> to ID_AA64MMFR0_EL1) or any register to determine the physical >>>> address range. Thus, I will prefer to keep the code as it is unless >>>> you suggest any alternative. >>> >>> I looked at the Arm Arm and indeed it doesn't look like there are >>> equivalent for ID_AA64MMFR0_EL1.PARange. >>> >>> However, my point was less about reading the system register but >>> more about the fact we could have the code a bit more generic and >>> avoid the assumption that PADDR_BITS is only modified when >>> CONFIG_ARM_PA_32 is set. >> >> I had a rework at the patch. Please let me know if the following >> looks better. >> >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index 948f199d84..bc3bdf5f3e 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >> @@ -2266,14 +2266,35 @@ void __init setup_virt_paging(void) >>       register_t val = >> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >> >>   #ifdef CONFIG_ARM_32 >> -    if ( p2m_ipa_bits < 40 ) >> +    static const struct { >> +        unsigned int pabits; /* Physical Address Size */ >> +        unsigned int t0sz;   /* Desired T0SZ */ >> +        unsigned int sl0;    /* Desired SL0 */ > > Hmmm... Why don't you include the root order? In fact... > >> +    } pa_range_info[] __initconst = { >> +        [0] = { 32,     32,     1 }, >> +        [1] = { 40,     24,     1 }, > > ... looking at the ARMv7 specification (see B3-1345 in ARM DDI > 0406C.d), the root page-table is only concatenated for 40-bits. Sorry, I could not follow how you inferred this. Can you paste the relevant snippet ? > >> +    }; >> +    int i = 0; >> + >> +    if ( p2m_ipa_bits < PADDR_BITS ) >> +        panic("P2M: Not able to support %u-bit IPA at the moment\n", >> +              p2m_ipa_bits); > > This check seems unnecessary now. We still need this check as arm_smmu_device_cfg_probe() invokes p2m_restrict_ipa_bits(size). And referARM IHI 0062D.cID070116 (SMMU arch version 2.0 Specification), the IPA address size can be 0. 0b0000 32-bit. 1. 0b0001 36-bit. 10. 0b0010 40-bit. 11. 0b0011 42-bit. 100. 0b0100 44-bit. 101. 0b0101 48-bit. So if p2m_ipa_bits = 36 bits and PADDR_BITS = 40, then we want to panic. - Ayan > >> + >> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >> +    p2m_ipa_bits = PADDR_BITS; >> + >> +    for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) >> +        if ( p2m_ipa_bits == pa_range_info[i].pabits ) >> +            break; >> + >> +    if ( i == ARRAY_SIZE(pa_range_info) ) >>           panic("P2M: Not able to support %u-bit IPA at the moment\n", >>                 p2m_ipa_bits); >> >> -    printk("P2M: 40-bit IPA\n"); >> -    p2m_ipa_bits = 40; >> -    val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >> -    val |= VTCR_SL0(0x1); /* P2M starts at first level */ >> +    val |= VTCR_T0SZ(pa_range_info[i].t0sz); >> +    val |= VTCR_SL0(pa_range_info[i].sl0); >> + > > I think you can share a lot of code between arm64 and arm32. A diff > below (not tested): > > diff --git a/xen/arch/arm/include/asm/p2m.h > b/xen/arch/arm/include/asm/p2m.h > index 91df922e1c9f..05f26780a29d 100644 > --- a/xen/arch/arm/include/asm/p2m.h > +++ b/xen/arch/arm/include/asm/p2m.h > @@ -14,16 +14,10 @@ >  /* Holds the bit size of IPAs in p2m tables.  */ >  extern unsigned int p2m_ipa_bits; > > -#ifdef CONFIG_ARM_64 >  extern unsigned int p2m_root_order; >  extern unsigned int p2m_root_level; >  #define P2M_ROOT_ORDER    p2m_root_order >  #define P2M_ROOT_LEVEL p2m_root_level > -#else > -/* First level P2M is always 2 consecutive pages */ > -#define P2M_ROOT_ORDER    1 > -#define P2M_ROOT_LEVEL 1 > -#endif > >  struct domain; > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index 948f199d848f..6fda0b92230a 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -2264,17 +2264,6 @@ void __init setup_virt_paging(void) >  { >      /* Setup Stage 2 address translation */ >      register_t val = > VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; > - > -#ifdef CONFIG_ARM_32 > -    if ( p2m_ipa_bits < 40 ) > -        panic("P2M: Not able to support %u-bit IPA at the moment\n", > -              p2m_ipa_bits); > - > -    printk("P2M: 40-bit IPA\n"); > -    p2m_ipa_bits = 40; > -    val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ > -    val |= VTCR_SL0(0x1); /* P2M starts at first level */ > -#else /* CONFIG_ARM_64 */ >      static const struct { >          unsigned int pabits; /* Physical Address Size */ >          unsigned int t0sz;   /* Desired T0SZ, minimum in comment */ > @@ -2286,29 +2275,26 @@ void __init setup_virt_paging(void) >          [0] = { 32,      32/*32*/,  0,          1 }, >          [1] = { 36,      28/*28*/,  0,          1 }, >          [2] = { 40,      24/*24*/,  1,          1 }, > +#ifdef CONFIG_ARM_64 >          [3] = { 42,      22/*22*/,  3,          1 }, >          [4] = { 44,      20/*20*/,  0,          2 }, >          [5] = { 48,      16/*16*/,  0,          2 }, >          [6] = { 52,      12/*12*/,  4,          2 }, >          [7] = { 0 }  /* Invalid */ > +#endif >      }; > >      unsigned int i; >      unsigned int pa_range = 0x10; /* Larger than any possible value */ > > +#ifdef CONFIG_ARM_64 >      /* >       * Restrict "p2m_ipa_bits" if needed. As P2M table is always > configured >       * with IPA bits == PA bits, compare against "pabits". >       */ >      if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < > p2m_ipa_bits ) >          p2m_ipa_bits = > pa_range_info[system_cpuinfo.mm64.pa_range].pabits; > - > -    /* > -     * cpu info sanitization made sure we support 16bits VMID only if > all > -     * cores are supporting it. > -     */ > -    if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) > -        max_vmid = MAX_VMID_16_BIT; > +#endif > >      /* Choose suitable "pa_range" according to the resulted > "p2m_ipa_bits". */ >      for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) > @@ -2324,12 +2310,22 @@ void __init setup_virt_paging(void) >      if ( pa_range >= ARRAY_SIZE(pa_range_info) || > !pa_range_info[pa_range].pabits ) >          panic("Unknown encoding of ID_AA64MMFR0_EL1.PARange %x\n", > pa_range); > > -    val |= VTCR_PS(pa_range); > -    val |= VTCR_TG0_4K; > +#ifdef CONFIG_ARM_64 > +    /* > +     * cpu info sanitization made sure we support 16bits VMID only if > all > +     * cores are supporting it. > +     */ > +    if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) > +        max_vmid = MAX_VMID_16_BIT; > >      /* Set the VS bit only if 16 bit VMID is supported. */ >      if ( MAX_VMID == MAX_VMID_16_BIT ) >          val |= VTCR_VS; > +#endif > + > +    val |= VTCR_PS(pa_range); > +    val |= VTCR_TG0_4K; > + >      val |= VTCR_SL0(pa_range_info[pa_range].sl0); >      val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); > > @@ -2341,7 +2337,7 @@ void __init setup_virt_paging(void) >             p2m_ipa_bits, >             pa_range_info[pa_range].pabits, >             ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); > -#endif > + >      printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", >             4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); > > Cheers, > From xen-devel-bounces@lists.xenproject.org Fri Feb 10 17:58:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 17:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493498.763422 (Exim 4.92) (envelope-from ) id 1pQXfP-0002vb-B1; Fri, 10 Feb 2023 17:58:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493498.763422; Fri, 10 Feb 2023 17:58:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQXfP-0002vU-6w; Fri, 10 Feb 2023 17:58:35 +0000 Received: by outflank-mailman (input) for mailman id 493498; Fri, 10 Feb 2023 17:58:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQXfN-0002vK-Ps for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 17:58:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQXfN-0005TP-AS; Fri, 10 Feb 2023 17:58:33 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQXfN-00069h-42; Fri, 10 Feb 2023 17:58:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1Vy12ZjwbXyB0msoMPe47eFj66Jb1B1r+RbbesZQwc4=; b=B1yq6XnshVZLV9cDY2ouL8Jq9b E6bHzU1xtzttf01MEbIBfrMm7YnweFCowTjrJ8SsJf9949CPu37dIaoI6+Yr5ucXP146X/iSrvDXS TdThX+T05TeSvgBxo9lxtIhjxzu10hRQ3YCEbCrTGCnOkogJn05wK3FD1HhCnxbiH2rk=; Message-ID: <6f6f30e1-d1a0-97f8-d230-dbbd18373e2c@xen.org> Date: Fri, 10 Feb 2023 17:58:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN v2 11/11] xen/arm: p2m: Enable support for 32bit IPA Content-Language: en-US To: Ayan Kumar Halder , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20230117174358.15344-1-ayan.kumar.halder@amd.com> <20230117174358.15344-12-ayan.kumar.halder@amd.com> <3655dce9-f795-3d37-3236-d95d74c865ff@xen.org> <1e5d905c-0511-ed80-c899-e679d955775d@amd.com> <5eb92203-2d99-7dfc-4f01-d92b7a23c3e5@xen.org> <3b3c3846-5464-4914-3b28-f451f7e70c9a@amd.com> From: Julien Grall In-Reply-To: <3b3c3846-5464-4914-3b28-f451f7e70c9a@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/02/2023 17:51, Ayan Kumar Halder wrote: > > On 10/02/2023 16:19, Julien Grall wrote: >> Hi, >> On 10/02/2023 15:39, Ayan Kumar Halder wrote: >>> >>> On 09/02/2023 11:45, Julien Grall wrote: >>>> Hi, >>> Hi Julien, >>>> >>>> On 07/02/2023 15:34, Ayan Kumar Halder wrote: >>>>> >>>>> On 20/01/2023 11:06, Julien Grall wrote: >>>>>> Hi Ayan, >>>>> Hi Julien, >>>>>> >>>>>> On 17/01/2023 17:43, Ayan Kumar Halder wrote: >>>>>>> VTCR.T0SZ should be set as 0x20 to support 32bit IPA. >>>>>>> Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, >>>>>>> "Virtualization Translation Control Register" for the bit >>>>>>> descriptions. >>>>>>> >>>>>>> Signed-off-by: Ayan Kumar Halder >>>>>>> --- >>>>>>> Changes from - >>>>>>> >>>>>>> v1 - New patch. >>>>>>> >>>>>>>   xen/arch/arm/p2m.c | 10 +++++++--- >>>>>>>   1 file changed, 7 insertions(+), 3 deletions(-) >>>>>>> >>>>>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>>>>>> index 948f199d84..cfdea55e71 100644 >>>>>>> --- a/xen/arch/arm/p2m.c >>>>>>> +++ b/xen/arch/arm/p2m.c >>>>>>> @@ -2266,13 +2266,17 @@ void __init setup_virt_paging(void) >>>>>>>       register_t val = >>>>>>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>>>>>>     #ifdef CONFIG_ARM_32 >>>>>>> -    if ( p2m_ipa_bits < 40 ) >>>>>>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>>>>>>           panic("P2M: Not able to support %u-bit IPA at the >>>>>>> moment\n", >>>>>>>                 p2m_ipa_bits); >>>>>>>   -    printk("P2M: 40-bit IPA\n"); >>>>>>> -    p2m_ipa_bits = 40; >>>>>>> +    printk("P2M: %u-bit IPA\n",PADDR_BITS); >>>>>>> +    p2m_ipa_bits = PADDR_BITS; >>>>>>> +#ifdef CONFIG_ARM_PA_32 >>>>>>> +    val |= VTCR_T0SZ(0x20); /* 32 bit IPA */ >>>>>>> +#else >>>>>>>       val |= VTCR_T0SZ(0x18); /* 40 bit IPA */ >>>>>>> +#endif >>>>>> >>>>>> I am wondering whether this is right time to switch to an array >>>>>> like the arm64 code? This would allow to use 32-bit IPA also when >>>>>> Xen support 64-bit physical address. >>>>> >>>>> In AArch64, we use ID_AA64MMFR0_EL1.PARange to determine the >>>>> physical address range supported at runtime. This is then used as >>>>> an index into pa_range_info[] to determine t0sz, root_order, etc. >>>> >>>> It is using both the ID_AA64MMFR0_EL1 but also p2m_ipa_bits to >>>> decide the size. >>> Ack. >>>> >>>>> >>>>> However, for AArch32 I do not see an equivalent register (similar >>>>> to ID_AA64MMFR0_EL1) or any register to determine the physical >>>>> address range. Thus, I will prefer to keep the code as it is unless >>>>> you suggest any alternative. >>>> >>>> I looked at the Arm Arm and indeed it doesn't look like there are >>>> equivalent for ID_AA64MMFR0_EL1.PARange. >>>> >>>> However, my point was less about reading the system register but >>>> more about the fact we could have the code a bit more generic and >>>> avoid the assumption that PADDR_BITS is only modified when >>>> CONFIG_ARM_PA_32 is set. >>> >>> I had a rework at the patch. Please let me know if the following >>> looks better. >>> >>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>> index 948f199d84..bc3bdf5f3e 100644 >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -2266,14 +2266,35 @@ void __init setup_virt_paging(void) >>>       register_t val = >>> VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; >>> >>>   #ifdef CONFIG_ARM_32 >>> -    if ( p2m_ipa_bits < 40 ) >>> +    static const struct { >>> +        unsigned int pabits; /* Physical Address Size */ >>> +        unsigned int t0sz;   /* Desired T0SZ */ >>> +        unsigned int sl0;    /* Desired SL0 */ >> >> Hmmm... Why don't you include the root order? In fact... >> >>> +    } pa_range_info[] __initconst = { >>> +        [0] = { 32,     32,     1 }, >>> +        [1] = { 40,     24,     1 }, >> >> ... looking at the ARMv7 specification (see B3-1345 in ARM DDI >> 0406C.d), the root page-table is only concatenated for 40-bits. > Sorry, I could not follow how you inferred this. Can you paste the > relevant snippet ? Use of concatenated second-level translation tables A stage 2 translation with an input address range of 31-34 bits can start the translation either: • With a first-level lookup, accessing a first-level translation table with 2-16 entries. • With a second-level lookup, accessing a set of concatenated second-level translation tables. >> >>> +    }; >>> +    int i = 0; >>> + >>> +    if ( p2m_ipa_bits < PADDR_BITS ) >>> +        panic("P2M: Not able to support %u-bit IPA at the moment\n", >>> +              p2m_ipa_bits); >> >> This check seems unnecessary now. > > We still need this check as arm_smmu_device_cfg_probe() invokes > p2m_restrict_ipa_bits(size). > > And referARM IHI 0062D.cID070116 (SMMU arch version 2.0 Specification), > the IPA address size can be > > 0. > >    0b0000 32-bit. > > 1. > >    0b0001 36-bit. > > 10. > >    0b0010 40-bit. > > 11. > >    0b0011 42-bit. > > 100. > >    0b0100 44-bit. > > 101. > >    0b0101 48-bit. > > So if p2m_ipa_bits = 36 bits and PADDR_BITS = 40, then we want to panic. We can have the same situation on Arm64 (PADDR_BITS = 48), yet we don't panic(). So I don't quite understand why we would need to differ... Or are you saying that for 64-bit we also need such check? If so, then I am still not sure why because p2m_ipa_bits represent the guest physical address space and PADDR_BITS the Xen physical address space. It is valid to have both of them differing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:25:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493516.763477 (Exim 4.92) (envelope-from ) id 1pQY5f-0007I9-0A; Fri, 10 Feb 2023 18:25:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493516.763477; Fri, 10 Feb 2023 18:25:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQY5e-0007I2-Ra; Fri, 10 Feb 2023 18:25:42 +0000 Received: by outflank-mailman (input) for mailman id 493516; Fri, 10 Feb 2023 18:25:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQY5d-0007Hs-81; Fri, 10 Feb 2023 18:25:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQY5d-0006EQ-6U; Fri, 10 Feb 2023 18:25:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQY5c-0006yg-FW; Fri, 10 Feb 2023 18:25:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQY5T-0001hR-6Q; Fri, 10 Feb 2023 18:25:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bszKjaWlM3Jx1paU+iNcW+dn+LtcQRK7fsfOsrPSICA=; b=KN2JnLjCQVMrkLIHzN88HqOVYu QEjXVJZDWfuQxuXNYM3VwqvB4iMyNpUCevmXOwc3aP/JCPZNiNpV3L/aI38cfvFZJCBp2GJ3miSem rFidSR8CrP3LUpD/ktwkUKVNu4du84MAvG/+EY9N+3lWHv7ZfDju88p8gt1V9Yk60J7w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 176835: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=1b6acdeeb2323c53d841356da50440e274e7bf9a X-Osstest-Versions-That: xen=6e081438bf8ef616d0123aab7a743476d8114ef6 From: osstest service owner Date: Fri, 10 Feb 2023 18:25:31 +0000 flight 176835 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176835/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176458 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176458 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176458 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176458 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176458 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176458 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 1b6acdeeb2323c53d841356da50440e274e7bf9a baseline version: xen 6e081438bf8ef616d0123aab7a743476d8114ef6 Last test of basis 176458 2023-02-07 16:39:55 Z 3 days Testing same since 176755 2023-02-09 16:07:08 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Edwin Török Pau Ruiz Safont jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6e081438bf..1b6acdeeb2 1b6acdeeb2323c53d841356da50440e274e7bf9a -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:44:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:44:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493526.763487 (Exim 4.92) (envelope-from ) id 1pQYNH-0001Tw-IP; Fri, 10 Feb 2023 18:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493526.763487; Fri, 10 Feb 2023 18:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYNH-0001Tp-Fm; Fri, 10 Feb 2023 18:43:55 +0000 Received: by outflank-mailman (input) for mailman id 493526; Fri, 10 Feb 2023 18:43:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYNF-0001Te-GE for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:43:53 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dbbb633f-a972-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:43:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 6A2A62015E; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UulWY7rJiZS1; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 1FD4C20152; Fri, 10 Feb 2023 19:43:49 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYNA-006gMI-2V; Fri, 10 Feb 2023 19:43:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbbb633f-a972-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:43:48 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 1/7] Mini-OS: xenbus: add support for reading node from directory Message-ID: <20230210184348.mbbxhuroralr7q64@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-2-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:22 +0100, a ecrit: > Especially PV device drivers often need to read multiple Xenstore > nodes from a common directory. Add support for reading a string or an > unsigned value by specifying the directory and the node. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - check sscanf() return value (Samuel Thibault) > --- > include/xenbus.h | 6 ++++++ > xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- > 2 files changed, 43 insertions(+), 3 deletions(-) > > diff --git a/include/xenbus.h b/include/xenbus.h > index 3871f358..c0fc0ac5 100644 > --- a/include/xenbus.h > +++ b/include/xenbus.h > @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); > * read and parsing were successful, 0 if not */ > int xenbus_read_uuid(const char* path, unsigned char uuid[16]); > > +/* Support functions for reading values from directory/node tuple. */ > +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, > + const char *node, char **value); > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value); > + > /* Contraction of snprintf and xenbus_write(path/node). */ > char* xenbus_printf(xenbus_transaction_t xbt, > const char* node, const char* path, > diff --git a/xenbus.c b/xenbus.c > index 81e9b65d..923e8181 100644 > --- a/xenbus.c > +++ b/xenbus.c > @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) > return 1; > } > > +#define BUFFER_SIZE 256 > +static void xenbus_build_path(const char *dir, const char *node, char *res) > +{ > + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); > + sprintf(res,"%s/%s", dir, node); > +} > + > char *xenbus_printf(xenbus_transaction_t xbt, const char* node, > const char* path, const char* fmt, ...) > { > -#define BUFFER_SIZE 256 > char fullpath[BUFFER_SIZE]; > char val[BUFFER_SIZE]; > va_list args; > > - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); > - sprintf(fullpath,"%s/%s", node, path); > + xenbus_build_path(node, path, fullpath); > va_start(args, fmt); > vsprintf(val, fmt, args); > va_end(args); > @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) > return ret; > } > > +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, > + const char *node, char **value) > +{ > + char path[BUFFER_SIZE]; > + > + xenbus_build_path(dir, node, path); > + > + return xenbus_read(xbt, path, value); > +} > + > +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, > + const char *node, unsigned int *value) > +{ > + char path[BUFFER_SIZE]; > + char *msg; > + char *str; > + > + xenbus_build_path(dir, node, path); > + msg = xenbus_read(xbt, path, &str); > + if ( msg ) > + return msg; > + > + if ( sscanf(str, "%u", value) != 1 ) > + msg = strdup("EINVAL"); > + free(str); > + > + return msg; > +} > + > /* > * Local variables: > * mode: C > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:45:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:45:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493536.763507 (Exim 4.92) (envelope-from ) id 1pQYO9-00025V-VZ; Fri, 10 Feb 2023 18:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493536.763507; Fri, 10 Feb 2023 18:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYO9-00025O-So; Fri, 10 Feb 2023 18:44:49 +0000 Received: by outflank-mailman (input) for mailman id 493536; Fri, 10 Feb 2023 18:44:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYO9-0001sh-2z for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:44:49 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd8c19a5-a972-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 379F62015E; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Am5c1eVhXUX; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 0F16F20152; Fri, 10 Feb 2023 19:44:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYO5-006gNA-2T; Fri, 10 Feb 2023 19:44:45 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd8c19a5-a972-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:44:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 2/7] Mini-OS: add concept of mount points Message-ID: <20230210184445.p7aopsjlmvplfdze@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-3-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:23 +0100, a ecrit: > Add the concept of mount points to Mini-OS. A mount point is a path > associated with a device pointer and an open() callback. A mount point > can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). > > This allows to replace the special casing in the generic open() > handling with a generic mount point handling. > > Prepare the open() callbacks to support creating new files by adding a > mode parameter. > > Additionally add a close() prototype to include/lib.h, as it is missing > today. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - pass path below mount point to open callbacks (Samuel Thibault) > --- > include/lib.h | 9 ++++++ > lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ > 2 files changed, 70 insertions(+), 19 deletions(-) > > diff --git a/include/lib.h b/include/lib.h > index bec99646..36d94ec4 100644 > --- a/include/lib.h > +++ b/include/lib.h > @@ -187,6 +187,13 @@ struct file_ops { > bool (*select_wr)(struct file *file); > }; > > +struct mount_point { > + const char *path; > + int (*open)(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode); > + void *dev; > +}; > + > unsigned int alloc_file_type(const struct file_ops *ops); > > off_t lseek_default(struct file *file, off_t offset, int whence); > @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); > void close_all_files(void); > extern struct thread *main_thread; > void sparse(unsigned long data, size_t size); > + > +int close(int fd); > #endif > > #endif /* _LIB_H_ */ > diff --git a/lib/sys.c b/lib/sys.c > index 8f8a3de2..2f33c937 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) > return buf; > } > > -#define LOG_PATH "/var/log/" > -#define SAVE_PATH "/var/lib/xen" > -#define SAVE_CONSOLE 1 > -#define RESTORE_CONSOLE 2 > - > int mkdir(const char *pathname, mode_t mode) > { > errno = EIO; > @@ -286,18 +281,30 @@ int posix_openpt(int flags) > return fd; > } > > +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return posix_openpt(flags); > +} > + > int open_savefile(const char *path, int save) > { > int fd; > char nodename[64]; > > - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); > + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); > > fd = open_consfront(nodename); > printk("fd(%d) = open_savefile\n", fd); > > return fd; > } > + > +static int open_save(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + return open_savefile(pathname, flags & O_WRONLY); > +} > #else > int posix_openpt(int flags) > { > @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) > } > #endif > > -int open(const char *pathname, int flags, ...) > +static int open_log(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > { > int fd; > + > /* Ugly, but fine. */ > - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { > - fd = alloc_fd(FTYPE_CONSOLE); > - printk("open(%s) -> %d\n", pathname, fd); > - return fd; > + fd = alloc_fd(FTYPE_CONSOLE); > + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); > + return fd; > +} > + > +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + int fd; > + > + fd = alloc_fd(FTYPE_MEM); > + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); > + return fd; > +} > + > +static struct mount_point mount_points[] = { > + { .path = "/var/log", .open = open_log, .dev = NULL }, > + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, > +#ifdef CONFIG_CONSFRONT > + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, > + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, > +#endif > +}; > + > +int open(const char *pathname, int flags, ...) > +{ > + unsigned int m, mlen; > + struct mount_point *mnt; > + mode_t mode = 0; > + va_list ap; > + > + if ( flags & O_CREAT ) > + { > + va_start(ap, flags); > + mode = va_arg(ap, mode_t); > + va_end(ap); > } > - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { > - fd = alloc_fd(FTYPE_MEM); > - printk("open(/dev/mem) -> %d\n", fd); > - return fd; > + > + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) > + { > + mnt = mount_points + m; > + mlen = strlen(mnt->path); > + if ( !strncmp(pathname, mnt->path, mlen) && > + (pathname[mlen] == '/' || pathname[mlen] == 0) ) > + return mnt->open(mnt, pathname + mlen, flags, mode); > } > - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) > - return posix_openpt(flags); > - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) > - return open_savefile(pathname, flags & O_WRONLY); > + > errno = EIO; > return -1; > } > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:46:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493547.763521 (Exim 4.92) (envelope-from ) id 1pQYQ4-0002x7-D1; Fri, 10 Feb 2023 18:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493547.763521; Fri, 10 Feb 2023 18:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYQ4-0002wy-AO; Fri, 10 Feb 2023 18:46:48 +0000 Received: by outflank-mailman (input) for mailman id 493547; Fri, 10 Feb 2023 18:46:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYQ3-0002uf-60 for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:46:47 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4303baa0-a973-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:46:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B74222015E; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CiSvYmAxpibe; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 7736720152; Fri, 10 Feb 2023 19:46:42 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYPy-006gPP-0Q; Fri, 10 Feb 2023 19:46:42 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4303baa0-a973-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:46:42 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 4/7] Mini-OS: add 9pfs frontend Message-ID: <20230210184642.7pliosfbx7us2va7@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-5-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:25 +0100, a ecrit: > Add a frontend for the 9pfs PV device. For now add only the code needed > to connect to the backend and the related disconnect functionality. The > 9pfs protocol support will be added later. > > Due to its nature (ability to access files) the whole code is guarded > by "#ifdef HAVE_LIBC". > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add better error handling to version parsing (Samuel Thibault) > --- > 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ > Config.mk | 1 + > Makefile | 1 + > arch/x86/testbuild/all-no | 1 + > arch/x86/testbuild/all-yes | 1 + > arch/x86/testbuild/newxen-yes | 1 + > include/9pfront.h | 7 + > 7 files changed, 298 insertions(+) > create mode 100644 9pfront.c > create mode 100644 include/9pfront.h > > diff --git a/9pfront.c b/9pfront.c > new file mode 100644 > index 00000000..89ecb3a1 > --- /dev/null > +++ b/9pfront.c > @@ -0,0 +1,286 @@ > +/* > + * Minimal 9pfs PV frontend for Mini-OS. > + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#ifdef HAVE_LIBC > +struct dev_9pfs { > + int id; > + char nodename[20]; > + unsigned int dom; > + char *backend; > + > + char *tag; > + const char *mnt; > + > + struct xen_9pfs_data_intf *intf; > + struct xen_9pfs_data data; > + RING_IDX prod_pvt_out; > + RING_IDX cons_pvt_in; > + > + grant_ref_t ring_ref; > + evtchn_port_t evtchn; > + unsigned int ring_order; > + xenbus_event_queue events; > +}; > + > +#define DEFAULT_9PFS_RING_ORDER 4 > + > +static unsigned int ftype_9pfs; > + > +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > +{ > +} > + > +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > + mode_t mode) > +{ > + errno = ENOSYS; > + > + return -1; > +} > + > +static void free_9pfront(struct dev_9pfs *dev) > +{ > + unsigned int i; > + > + if ( dev->data.in && dev->intf ) > + { > + for ( i = 0; i < (1 << dev->ring_order); i++ ) > + gnttab_end_access(dev->intf->ref[i]); > + free_pages(dev->data.in, dev->ring_order); > + } > + unbind_evtchn(dev->evtchn); > + gnttab_end_access(dev->ring_ref); > + free_page(dev->intf); > + free(dev->backend); > + free(dev->tag); > + free(dev); > +} > + > +void *init_9pfront(unsigned int id, const char *mnt) > +{ > + struct dev_9pfs *dev; > + char *msg; > + char *reason = ""; > + xenbus_transaction_t xbt; > + int retry = 1; > + char bepath[64] = { 0 }; > + XenbusState state; > + unsigned int i; > + void *addr; > + char *version; > + char *v; > + > + printk("9pfsfront add %u, for mount at %s\n", id, mnt); > + dev = malloc(sizeof(*dev)); > + memset(dev, 0, sizeof(*dev)); > + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); > + dev->id = id; > + > + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); > + if ( msg ) > + goto err; > + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); > + if ( msg ) > + goto err; > + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); > + if ( msg ) > + goto err; > + > + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); > + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateInitWait ) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); > + if ( msg || state != XenbusStateInitWait ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", > + &dev->ring_order); > + if ( msg ) > + goto err; > + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) > + dev->ring_order = DEFAULT_9PFS_RING_ORDER; > + > + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); > + if ( msg ) > + goto err; > + for ( v = version; *v; v++ ) > + { > + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) > + { > + v = NULL; > + break; > + } > + if ( *v != ',' && *v != 0 ) > + { > + reason = "backend published illegal version string"; > + free(version); > + goto err; > + } > + } > + free(version); > + if ( v ) > + { > + reason = "backend doesn't support version 1"; > + goto err; > + } > + > + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); > + memset(dev->intf, 0, PAGE_SIZE); > + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) > + { > + reason = "no event channel"; > + goto err; > + } > + dev->intf->ring_order = dev->ring_order; > + dev->data.in = (void *)alloc_pages(dev->ring_order); > + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); > + for ( i = 0; i < (1 << dev->ring_order); i++ ) > + { > + addr = dev->data.in + i * PAGE_SIZE; > + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); > + } > + > + while ( retry ) > + { > + msg = xenbus_transaction_start(&xbt); > + if ( msg ) > + { > + free(msg); > + msg = NULL; > + reason = "starting transaction"; > + goto err; > + } > + > + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", > + dev->ring_ref); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", > + dev->evtchn); > + if ( msg ) > + goto err_tr; > + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", > + XenbusStateInitialised); > + if ( msg ) > + goto err_tr; > + > + free(xenbus_transaction_end(xbt, 0, &retry)); > + } > + > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateConnected ) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); > + if ( msg || state != XenbusStateConnected ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", > + XenbusStateConnected); > + if ( msg ) > + goto err; > + > + unmask_evtchn(dev->evtchn); > + > + dev->mnt = mnt; > + if ( mount(dev->mnt, dev, open_9pfs) ) > + { > + reason = "mount failed"; > + goto err; > + } > + > + return dev; > + > + err_tr: > + free(xenbus_transaction_end(xbt, 1, &retry)); > + > + err: > + if ( bepath[0] ) > + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); > + if ( msg ) > + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", > + id, msg); > + else > + printk("9pfsfront add %u failed, %s\n", id, reason); > + free_9pfront(dev); > + free(msg); > + return NULL; > +} > + > +void shutdown_9pfront(void *dev) > +{ > + struct dev_9pfs *dev9p = dev; > + char bepath[64]; > + XenbusState state; > + char *msg; > + char *reason = ""; > + > + umount(dev9p->mnt); > + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); > + > + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", > + XenbusStateClosing); > + if ( msg ) > + goto err; > + > + state = xenbus_read_integer(bepath); > + while ( msg == NULL && state < XenbusStateClosing) > + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); > + if ( msg || state != XenbusStateClosing ) > + { > + reason = "illegal backend state"; > + goto err; > + } > + > + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", > + XenbusStateClosed); > + if ( msg ) > + goto err; > + > + free_9pfront(dev9p); > + > + return; > + > + err: > + if ( msg ) > + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", > + dev9p->id, msg); > + else > + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); > + free(msg); > +} > + > +static const struct file_ops ops_9pfs = { > + .name = "9pfs", > +}; > + > +__attribute__((constructor)) > +static void initialize_9pfs(void) > +{ > + ftype_9pfs = alloc_file_type(&ops_9pfs); > +} > + > +#endif /* HAVE_LIBC */ > diff --git a/Config.mk b/Config.mk > index 1a24b30e..677e93df 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS > CONFIG-n += CONFIG_TEST > CONFIG-n += CONFIG_PCIFRONT > CONFIG-n += CONFIG_TPMFRONT > +CONFIG-n += CONFIG_9PFRONT > CONFIG-n += CONFIG_TPM_TIS > CONFIG-n += CONFIG_TPMBACK > CONFIG-n += CONFIG_BALLOON > diff --git a/Makefile b/Makefile > index 747c7c01..7ee181a2 100644 > --- a/Makefile > +++ b/Makefile > @@ -39,6 +39,7 @@ SUBDIRS := lib > src-$(CONFIG_BLKFRONT) += blkfront.c > src-$(CONFIG_CONSFRONT) += consfront.c > src-$(CONFIG_TPMFRONT) += tpmfront.c > +src-$(CONFIG_9PFRONT) += 9pfront.c > src-$(CONFIG_TPM_TIS) += tpm_tis.c > src-$(CONFIG_TPMBACK) += tpmback.c > src-y += console.c > diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no > index f79a1012..5b3e99ed 100644 > --- a/arch/x86/testbuild/all-no > +++ b/arch/x86/testbuild/all-no > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n > CONFIG_FBFRONT = n > CONFIG_KBDFRONT = n > CONFIG_CONSFRONT = n > +CONFIG_9PFRONT = n > CONFIG_XENBUS = n > CONFIG_LIBXS = n > CONFIG_LWIP = n > diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes > index faa3af32..8ae489a4 100644 > --- a/arch/x86/testbuild/all-yes > +++ b/arch/x86/testbuild/all-yes > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y > CONFIG_FBFRONT = y > CONFIG_KBDFRONT = y > CONFIG_CONSFRONT = y > +CONFIG_9PFRONT = y > CONFIG_XENBUS = y > CONFIG_LIBXS = y > CONFIG_BALLOON = y > diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes > index dc83e670..ee27a328 100644 > --- a/arch/x86/testbuild/newxen-yes > +++ b/arch/x86/testbuild/newxen-yes > @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y > CONFIG_FBFRONT = y > CONFIG_KBDFRONT = y > CONFIG_CONSFRONT = y > +CONFIG_9PFRONT = y > CONFIG_XENBUS = y > CONFIG_LIBXS = y > CONFIG_BALLOON = y > diff --git a/include/9pfront.h b/include/9pfront.h > new file mode 100644 > index 00000000..722ec564 > --- /dev/null > +++ b/include/9pfront.h > @@ -0,0 +1,7 @@ > +#ifndef __9PFRONT_H__ > +#define __9PFRONT_H__ > + > +void *init_9pfront(unsigned int id, const char *mnt); > +void shutdown_9pfront(void *dev); > + > +#endif /* __9PFRONT_H__ */ > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:48:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493557.763537 (Exim 4.92) (envelope-from ) id 1pQYS3-0003ap-Sv; Fri, 10 Feb 2023 18:48:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493557.763537; Fri, 10 Feb 2023 18:48:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS3-0003aX-P0; Fri, 10 Feb 2023 18:48:51 +0000 Received: by outflank-mailman (input) for mailman id 493557; Fri, 10 Feb 2023 18:48:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS2-0003a2-EP for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:48:50 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d633d36-a973-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 7A6802015E; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZI2BQOBURiHz; Fri, 10 Feb 2023 19:48:47 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 4514320152; Fri, 10 Feb 2023 19:48:46 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYRx-006gS9-37; Fri, 10 Feb 2023 19:48:45 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d633d36-a973-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:48:45 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 5/7] Mini-OS: add 9pfs transport layer Message-ID: <20230210184845.mbxvnqdgy66el6jx@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-6-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:26 +0100, a ecrit: > Add the transport layer of 9pfs. This is basically the infrastructure > to send requests to the backend and to receive the related answers via > the rings. > > As a first example add the version and attach requests of the 9pfs > protocol when mounting a new 9pfs device. For the version use the > "9P2000.u" variant, as it is the smallest subset supported by the qemu > based backend. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add more comments (Samuel Thibault) > - log short copy (Samuel Thibault) > - send event after consuming response (Samuel Thibault) > - reaturn EAGAIN in case no free request could be got (Samuel Thibault) > --- > 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 478 insertions(+) > > diff --git a/9pfront.c b/9pfront.c > index 89ecb3a1..0b8d5461 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -7,6 +7,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > #include > @@ -14,6 +16,9 @@ > #include > > #ifdef HAVE_LIBC > + > +#define N_REQS 64 > + > struct dev_9pfs { > int id; > char nodename[20]; > @@ -22,6 +27,7 @@ struct dev_9pfs { > > char *tag; > const char *mnt; > + unsigned int msize_max; > > struct xen_9pfs_data_intf *intf; > struct xen_9pfs_data data; > @@ -32,14 +38,470 @@ struct dev_9pfs { > evtchn_port_t evtchn; > unsigned int ring_order; > xenbus_event_queue events; > + > + unsigned int free_reqs; > + struct req { > + unsigned int id; > + unsigned int next_free; /* N_REQS == end of list. */ > + unsigned int cmd; > + int result; > + bool inflight; > + unsigned char *data; /* Returned data. */ > + } req[N_REQS]; > + > + struct wait_queue_head waitq; > + struct semaphore ring_out_sem; > + struct semaphore ring_in_sem; > }; > > #define DEFAULT_9PFS_RING_ORDER 4 > > +#define P9_CMD_VERSION 100 > +#define P9_CMD_ATTACH 104 > +#define P9_CMD_ERROR 107 > + > +#define P9_QID_SIZE 13 > + > +struct p9_header { > + uint32_t size; > + uint8_t cmd; > + uint16_t tag; > +} __attribute__((packed)); > + > +#define P9_VERSION "9P2000.u" > +#define P9_ROOT_FID ~0 > + > static unsigned int ftype_9pfs; > > +static struct req *get_free_req(struct dev_9pfs *dev) > +{ > + struct req *req; > + > + if ( dev->free_reqs == N_REQS ) > + return NULL; > + > + req = dev->req + dev->free_reqs; > + dev->free_reqs = req->next_free; > + > + return req; > +} > + > +static void put_free_req(struct dev_9pfs *dev, struct req *req) > +{ > + req->next_free = dev->free_reqs; > + req->inflight = false; > + req->data = NULL; > + dev->free_reqs = req->id; > +} > + > +static unsigned int ring_out_free(struct dev_9pfs *dev) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned int queued; > + > + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); > + rmb(); > + > + return ring_size - queued; > +} > + > +static unsigned int ring_in_data(struct dev_9pfs *dev) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned int queued; > + > + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); > + rmb(); > + > + return queued; > +} > + > +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); > + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); > + > + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); > + dev->prod_pvt_out += len; > +} > + > +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > +{ > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); > + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); > + > + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); > + dev->cons_pvt_in += len; > +} > + > +/* > + * send_9p() and rcv_9p() are using a special format string for specifying > + * the kind of data sent/expected. Each data item is represented by a single > + * character: > + * U: 4 byte unsigned integer (uint32_t) > + * S: String (2 byte length + characters) > + * in the rcv_9p() case the data for string is allocated (length omitted, > + * string terminated by a NUL character) > + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version > + * and 8 bytes unique file id. Only valid for receiving. > + */ > +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + struct p9_header hdr; > + va_list ap, aq; > + const char *f; > + uint32_t intval; > + uint16_t len; > + char *strval; > + > + hdr.size = sizeof(hdr); > + hdr.cmd = req->cmd; > + hdr.tag = req->id; > + > + va_start(ap, fmt); > + > + va_copy(aq, ap); > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + hdr.size += 4; > + intval = va_arg(aq, unsigned int); > + break; > + case 'S': > + hdr.size += 2; > + strval = va_arg(aq, char *); > + hdr.size += strlen(strval); > + break; > + default: > + printk("send_9p: unknown format character %c\n", *f); > + break; > + } > + } > + va_end(aq); > + > + /* > + * Waiting for free space must be done in the critical section! > + * Otherwise we might get overtaken by other short requests. > + */ > + down(&dev->ring_out_sem); > + > + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); > + > + copy_to_ring(dev, &hdr, sizeof(hdr)); > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + intval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &intval, sizeof(intval)); > + break; > + case 'S': > + strval = va_arg(ap, char *); > + len = strlen(strval); > + copy_to_ring(dev, &len, sizeof(len)); > + copy_to_ring(dev, strval, len); > + break; > + } > + } > + > + wmb(); /* Data on ring must be seen before updating index. */ > + dev->intf->out_prod = dev->prod_pvt_out; > + req->inflight = true; > + > + up(&dev->ring_out_sem); > + > + va_end(ap); > + > + notify_remote_via_evtchn(dev->evtchn); > +} > + > +/* > + * Using an opportunistic approach for receiving data: in case multiple > + * requests are outstanding (which is very unlikely), we nevertheless need > + * to consume all data available until we reach the desired request. > + * For requests other than the one we are waiting for, we link the complete > + * data to the request via an intermediate buffer. For our own request we can > + * omit that buffer and directly fill the caller provided variables. > + * > + * Helper functions: > + * > + * copy_bufs(): copy raw data into a target buffer. There can be 2 source > + * buffers involved (in case the copy is done from the ring and it is across > + * the ring end). The buffer pointers and lengths are updated according to > + * the number of bytes copied. > + * > + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response > + * to the specified variables using the specified format string for > + * deciphering the single item types. The decision whether to copy from the > + * ring or an allocated buffer is done via the "hdr" parameter, which is > + * NULL in the buffer case (in that case the header is located at the start > + * of the buffer). > + * > + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in > + * it. If none is found, consumes one response. It checks the tag of the > + * response in order to decide whether to allocate a buffer for putting the > + * data into, or to fill the user supplied variables. Return true, if the > + * tag did match. Waits if no data is ready to be consumed. > + */ > +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, > + unsigned int *len1, unsigned int *len2, > + void *target, unsigned int len) > +{ > + if ( len <= *len1 ) > + { > + memcpy(target, *buf1, len); > + *buf1 += len; > + *len1 -= len; > + } > + else > + { > + memcpy(target, *buf1, *len1); > + target = (char *)target + *len1; > + len -= *len1; > + *buf1 = *buf2; > + *len1 = *len2; > + *buf2 = NULL; > + *len2 = 0; > + if ( len > *len1 ) > + { > + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); > + len = *len1; > + } > + memcpy(target, *buf1, *len1); > + } > +} > + > +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > + struct p9_header *hdr, const char *fmt, va_list ap) > +{ > + struct p9_header *h = hdr ? hdr : (void *)req->data; > + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); > + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); > + unsigned char *buf1, *buf2; > + unsigned int len1, len2; > + const char *f; > + char *str; > + uint16_t len; > + uint32_t err; > + uint32_t *val; > + char **strval; > + uint8_t *qval; > + > + if ( hdr ) > + { > + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); > + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); > + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); > + if ( len1 > h->size - sizeof(*h) ) > + len1 = h->size - sizeof(*h); > + len2 = h->size - sizeof(*h) - len1; > + } > + else > + { > + buf1 = req->data + sizeof(*h); > + buf2 = NULL; > + len1 = h->size - sizeof(*h); > + len2 = 0; > + } > + > + if ( h->cmd == P9_CMD_ERROR ) > + { > + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > + str = malloc(len + 1); > + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); > + str[len] = 0; > + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); > + free(str); > + err = EIO; > + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); > + req->result = err; > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > + > + return; > + } > + > + if ( h->cmd != req->cmd + 1 ) > + { > + req->result = EDOM; > + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", > + h->cmd, req->cmd + 1); > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > + > + return; > + } > + > + req->result = 0; > + > + for ( f = fmt; *f; f++ ) > + { > + switch ( *f ) > + { > + case 'U': > + val = va_arg(ap, uint32_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > + break; > + case 'S': > + strval = va_arg(ap, char **); > + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > + *strval = malloc(len + 1); > + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); > + (*strval)[len] = 0; > + break; > + case 'Q': > + qval = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); > + break; > + default: > + printk("rcv_9p: unknown format character %c\n", *f); > + break; > + } > + } > + > + if ( hdr ) > + dev->cons_pvt_in = cons; > +} > + > +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, > + va_list ap) > +{ > + struct p9_header hdr; > + struct req *tmp; > + > + if ( req->data ) > + { > + rcv_9p_copy(dev, req, NULL, fmt, ap); > + free(req->data); > + req->data = NULL; > + > + return true; > + } > + > + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); > + > + copy_from_ring(dev, &hdr, sizeof(hdr)); > + > + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); > + > + tmp = dev->req + hdr.tag; > + if ( hdr.tag >= N_REQS || !tmp->inflight ) > + { > + printk("9pfs: illegal response: %s\n", > + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); > + dev->cons_pvt_in += hdr.size - sizeof(hdr); > + > + return false; > + } > + > + tmp->inflight = false; > + > + if ( tmp != req ) > + { > + tmp->data = malloc(hdr.size); > + memcpy(tmp->data, &hdr, sizeof(hdr)); > + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); > + > + return false; > + } > + > + rcv_9p_copy(dev, req, &hdr, fmt, ap); > + > + return true; > +} > + > +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > +{ > + va_list ap; > + > + va_start(ap, fmt); > + > + down(&dev->ring_in_sem); > + > + while ( !rcv_9p_one(dev, req, fmt, ap) ); > + > + rmb(); /* Read all data before updating ring index. */ > + dev->intf->in_cons = dev->cons_pvt_in; > + > + notify_remote_via_evtchn(dev->evtchn); > + > + up(&dev->ring_in_sem); > + > + va_end(ap); > +} > + > +static int p9_version(struct dev_9pfs *dev) > +{ > + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; > + struct req *req = get_free_req(dev); > + char *verret; > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_VERSION; > + send_9p(dev, req, "US", msize, P9_VERSION); > + rcv_9p(dev, req, "US", &dev->msize_max, &verret); > + ret = req->result; > + > + put_free_req(dev, req); > + > + if ( ret ) > + return ret; > + > + if ( strcmp(verret, P9_VERSION) ) > + ret = ENOMSG; > + free(verret); > + > + return ret; > +} > + > +static int p9_attach(struct dev_9pfs *dev) > +{ > + uint32_t fid = P9_ROOT_FID; > + uint32_t afid = 0; > + uint32_t uid = 0; > + uint8_t qid[P9_QID_SIZE]; > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_ATTACH; > + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); > + rcv_9p(dev, req, "Q", qid); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int connect_9pfs(struct dev_9pfs *dev) > +{ > + int ret; > + > + ret = p9_version(dev); > + if ( ret ) > + return ret; > + > + return p9_attach(dev); > +} > + > static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > { > + struct dev_9pfs *dev = data; > + > + wake_up(&dev->waitq); > } > > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) > memset(dev, 0, sizeof(*dev)); > snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); > dev->id = id; > + init_waitqueue_head(&dev->waitq); > + init_SEMAPHORE(&dev->ring_out_sem, 1); > + init_SEMAPHORE(&dev->ring_in_sem, 1); > + > + for ( i = 0; i < N_REQS; i++ ) > + { > + dev->req[i].id = i; > + dev->req[i].next_free = i + 1; > + } > + dev->free_reqs = 0; > > msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); > if ( msg ) > @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) > > unmask_evtchn(dev->evtchn); > > + if ( connect_9pfs(dev) ) > + { > + reason = "9pfs connect failed"; > + goto err; > + } > + > dev->mnt = mnt; > if ( mount(dev->mnt, dev, open_9pfs) ) > { > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493558.763548 (Exim 4.92) (envelope-from ) id 1pQYS6-0003sS-9A; Fri, 10 Feb 2023 18:48:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493558.763548; Fri, 10 Feb 2023 18:48:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS6-0003sJ-5t; Fri, 10 Feb 2023 18:48:54 +0000 Received: by outflank-mailman (input) for mailman id 493558; Fri, 10 Feb 2023 18:48:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS5-0003s4-LR for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:48:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYS5-0006pz-CM; Fri, 10 Feb 2023 18:48:53 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQYS5-0008Se-6u; Fri, 10 Feb 2023 18:48:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QwYFujgDUIOUFVIzvX71PlEI78uZdq3MdNYbJwHkR9Y=; b=veFaRSvXm+99hXWlBAfrmxJKdg znGqA6eijd1+PnQqE6nxWmyCjd0WcrdGFBhOEr+OAtKtiOJTUweXiBgURNxbpr5Ysk/vX6Onzxio7 KJAV/Ena+fAJsdsGLBUKIr5dP1y+oa/dMmXrIslXgOCveGWGFgUF/2YyDkXTob1Hqyp0=; Message-ID: <44ccfe42-2dd2-9739-bbf1-fe39ce63ae33@xen.org> Date: Fri, 10 Feb 2023 18:48:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN][RFC PATCH v4 11/16] common/device_tree: Add rwlock for dt_host Content-Language: en-US To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Luca.Fancellu@arm.com References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-5-vikram.garhwal@amd.com> <9560a124-020c-6a5c-d4ce-c26e52413bd2@xen.org> <796a88a8-03d2-14f8-be50-10085d785eed@amd.com> From: Julien Grall In-Reply-To: <796a88a8-03d2-14f8-be50-10085d785eed@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 01/02/2023 17:05, Vikram Garhwal wrote: > On 12/7/22 8:31 AM, Julien Grall wrote: >>> Signed-off-by: Vikram Garhwal >>> --- >>>   xen/common/device_tree.c      | 27 +++++++++++++++++++++++++++ >>>   xen/include/xen/device_tree.h |  6 ++++++ >>>   2 files changed, 33 insertions(+) >>> >>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>> index acf26a411d..51ee2a5edf 100644 >>> --- a/xen/common/device_tree.c >>> +++ b/xen/common/device_tree.c >>> @@ -140,6 +140,8 @@ const struct dt_property *dt_find_property(const >>> struct dt_device_node *np, >>>       if ( !np ) >>>           return NULL; >>>   +    read_lock(&dt_host->lock); >>> + >>>       for ( pp = np->properties; pp; pp = pp->next ) >>>       { >>>           if ( dt_prop_cmp(pp->name, name) == 0 ) >>> @@ -150,6 +152,7 @@ const struct dt_property *dt_find_property(const >>> struct dt_device_node *np, >>>           } >>>       } >>>   +    read_unlock(&dt_host->lock); >>>       return pp; >>>   } >>>   @@ -336,11 +339,14 @@ struct dt_device_node >>> *dt_find_node_by_name(struct dt_device_node *from, >>>       struct dt_device_node *np; >>>       struct dt_device_node *dt; >>>   +    read_lock(&dt_host->lock); >>> + >>>       dt = from ? from->allnext : dt_host; >>>       dt_for_each_device_node(dt, np) >>>           if ( np->name && (dt_node_cmp(np->name, name) == 0) ) >>>               break; >>>   +    read_unlock(&dt_host->lock); >>>       return np; >> >> ... I was expecting the read lock to also protect the value returned >> from being freed. But this is not the case. >> > Okay. Shall I remove the lock from here and perhaps add it when > dt_find_node_by_name() and other related functions are called? It is a possibility. I would need to see the end result to be sure a lock is actually suitable. Maybe we will end up to need a refcounting instead if we keep the DT node for longer. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:51:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:51:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493575.763563 (Exim 4.92) (envelope-from ) id 1pQYUY-0005gF-Qw; Fri, 10 Feb 2023 18:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493575.763563; Fri, 10 Feb 2023 18:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYUY-0005g8-Nn; Fri, 10 Feb 2023 18:51:26 +0000 Received: by outflank-mailman (input) for mailman id 493575; Fri, 10 Feb 2023 18:51:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYUX-0005dq-F8 for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:51:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e80b016a-a973-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:51:22 +0100 (CET) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Feb 2023 13:51:18 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6138.namprd03.prod.outlook.com (2603:10b6:408:11b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 18:51:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 18:51:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e80b016a-a973-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676055082; h=message-id:date:from:subject:to:references:in-reply-to: content-transfer-encoding:mime-version; bh=uYkLE6i11nbs5+q7zuAGj51J3zDiw8XIjvKLLP1lMK0=; b=MZRMhNHMGtmnFhY+yRkQoHVWm8nwOaZx8ELtc3JAhDkd2zI9zj2RYRGh vEf20A1xu3DqjIZqMrlYJgSvTZchQWCKmxMTZHFXxBe1qr2poMuecDy0w tm6NBIV8izmCGyKk9/GZZRAvtTsUWvwqwsaO+sblPaJWTeZP8ItAbRLSq A=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 96483984 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+Xst4KgpTrO0z73uRLidXS3AX161gxEKZh0ujC45NGQN5FlHY01je htvDWjQbP+IYTfxf9onYdu2o0JUvcXWmtMwTgplrH0xF3wb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaGzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQDczEubA6EhN6P4+3iErR+vfoYB+z0adZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RePkpqU70AH7Kmo7EwwGDH6n+fKD2xCmfM9Fb FEG93Unov1nnKCsZpynN/Gim1aftxsBVt4WD+074giQzrb87gCCQ2wVSTgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YXec8LaTtna+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJiYq4i3HU2Tj6Rl2DLNJfKSt4FnfqPpFcoCQSwDbu GBewpfDqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:8/RnG6DFK9TNNcHlHeko55DYdb4zR+YMi2TDGXoBLCC9Ffbo6v xG+c516faaskd3ZJhNo6HiBEDEewKlyXc32/hkAV7AZnidhILXFvAF0WK4+UyUJ8SWzIc0vs 0MH8YeaOEYT2IK9voSizPId+rIruP3kpyAtKP+9lsodytOApsQkTuRcjzra3FedU1jDZo9FJ 2Tou9GvSfIQwVhUu2LQkAfWe7NvtvKk4+jTyInKnccmXWzpALt0aX9FReA2BcYTndo+pcNtU b4syGR3NTdjxmcoiWsp1M7K64m6ecJ0uEzdvBklPJlWQnRtg== X-IronPort-AV: E=Sophos;i="5.97,287,1669093200"; d="scan'208";a="96483984" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmCvKihCI5SbN3jPyoIdzBkPvDLOk+lsadJORRbKzZSo1ct7vmNDuwwZS59JkdhjEK4JgNVtzyvpn6q3LeheYl2QAqWFLHuLdzS99nP/fyIPE6iN/OioLyWYXV8ryfGsAGiqyVZcrQO9AE8W/58FuzZs7Hy1BS9apP57Yt/Ekw1q7aXXnSTMtQcV5wL0ZNYBd2VRrc01QzEPzq4KEa0OKHEbTcmeogdzgW1Vaw2rnx7Ih7L1oZJuKo4kKpYGtMg7riHzZfD2Tm3FrtyCTTgIbJ/w0cJsVmqKJuYXYHDv6VT32/DhyfrM2SxoL2M0gI37xPgL2D9JBPrGiTmfit+bQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10Y/pN9zzZyq5FpSK5ush7e+XYwTwTQ2g3oGNW5huOo=; b=SDtIz9hTnZA68F9N0G+Skxsboubl9QpFFNuzcC7pv28u8Q8bt+UEGHOO1TLawGIghPvEaWc2MbZKfULUzmw3tCt+caCq+B0OJZrVVHkru9j/nkggV2s8tNKHE/PVwkvrOS4jRqXqJs0vEaAUq2uoNx+8ZZc68ofLoDs+aax0zcQQoYS2FngDJQ6NJHjGRxj2CCgEz2XV1erKPzgr79Z/n5uqwNG3Gt+DADIBGsrNzuX/062cBkGtjkf9fUrq3vp8jWQkE2Wd4aaHPRKOC8grR6dc8Tce7t+vjW9fi5IKiykp+3N68rAak0ecBIrXeSFr3PaM2E8kU87EdFJESONAIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10Y/pN9zzZyq5FpSK5ush7e+XYwTwTQ2g3oGNW5huOo=; b=vFk5aZgDzkk8eNGCPzh673oumd+0/b7rlR9qTgOwtydAQ/4YFprVmcAhJBJbG643WCKk7lqyfG+FvpLFAzEejN23a5tk0T1AUJWgof/kdztxb+gCbXWqnrU4K2W4xJckF3558ex5k88aUg4KzgK5oI7ql3h/WsTB1MLzMUoOMPw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <77aebee5-92d8-304e-5cd0-ff6442f82f76@citrix.com> Date: Fri, 10 Feb 2023 18:51:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts Content-Language: en-GB To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-4-jgross@suse.com> <9d4810c5-10f4-d9f8-5a8a-3c52db6623bf@citrix.com> <8c007a9a-1466-f200-d7f6-27c81622ef27@suse.com> <20230210124444.bc7siuuj5dwgf3pb@begin> In-Reply-To: <20230210124444.bc7siuuj5dwgf3pb@begin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0487.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6138:EE_ X-MS-Office365-Filtering-Correlation-Id: d6004c88-bbb9-43ff-c876-08db0b97c89c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SqxdOARle0P5a+RGsIqfFCM62zY3cD7oXZ6aC6uNKkT9T6NgfIhdo3ALbB8KO9mfDHVXZGgp8rUeJyhucaNrmqL0baEgG6LFFQnmlSc5miCvV20lr95Us2Q14VMjtPhezU1c25y69Tz5edIfMICEVTcGaY4sfWl9rxoLUryJ7k0lWXRG64XcZZrVvaenI47pcr7mSSezHzF2nAq2Uxh26qhIUSxLsv9yjKbfQDSoDOluZB9suI4o8UjxYUCe8Si20gldXk14Kw/QxPQwWbkpAAnjM5/57h9b6yaTdugwGmaGAbwntPTh/sWFfQH0tnWlH9tPx/QzIkbmGkY6sQi8Ec6op5MmuHL9D/S+LcSX36xCTDu51uwE+XQOqQVvzcgngLeIxr58Zu+2HKksfsql7AADa5kMP5Qy7AF3nNTXZjS0D+yoCBRjCnscO0XHh4Cx26VvAOb8mZB7iMWBUPlkdFWnTpJxsSBc7MD/2VU4HXTLGnyXmQbhTv7D15Lv8DikmlSmNOFKRm4Rd1nNm+ifbvFRDi/iwx3C1zUFfZQFvEX7yqQr45MWrY3qsAYbH8iwRjwcM/ELMLD+HIbwLO/qOo4troFrh89BVQF0Oxz5oZ8BUWtpah42z/0LVZRJuu7NyCQaWN1fgZjOK26u7ISQpv/FCTa7rzhkky/SgvvZEdbzCo5e3BbqMmqS1ozVIS04VFv9b0zJOpOLMrhxGXF0wz9fn14MPc4lo5maRZ25baI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199018)(66946007)(38100700002)(82960400001)(316002)(41300700001)(8936002)(8676002)(66556008)(66476007)(2906002)(5660300002)(2616005)(6666004)(6506007)(6486002)(53546011)(478600001)(186003)(26005)(31696002)(86362001)(36756003)(31686004)(6512007)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUFjZVlOQU04OExicHhQYms2UG91amFuS3RsMkY5Y3poYlpnRGJqZ3hKVXhY?= =?utf-8?B?elVCS2krN2x4YU5xcGk2b1pTdm9sdVdaT3FPcThkcS9kT0lVUFlkQzZmUXFN?= =?utf-8?B?ZXZHRHgvK2RYS3NGQnd4YzJXTU95eVg4emc1Y0RNN1NqV0tGNUU4L3Fjamdj?= =?utf-8?B?YUcycEVaNTJ6TnRuZlBwa1pDblVQc0xVY1VBSGxEQ0JOaGRsQXo0cythbjQ0?= =?utf-8?B?ckVuTnM3RGlmSXNQdEVlZ2FzOXIwNnBMYjY5TjZVREYvZGxicmZ0TldlWDFs?= =?utf-8?B?ellaRVE2UEMvQnBRQ0wxOW5RNU1vSDNkUzIxa3RScmNXVmthTm9GU3h2NGVa?= =?utf-8?B?TzlRb0E2Q01HdlhqUEZEZU1nWnExUW44NzFMK0g2NFBGbkpDeXpPeFVGdGhr?= =?utf-8?B?UmJQNWlhb01BZFpDRlRpYllLTHdxd0dKcGZ3NDRTZzlzTytZOTM5eUloaEox?= =?utf-8?B?TUR3V29vS2JyVWVIMG5EWXB1dTRLbWs4YXJ4QlFnd3Q0alNtMk1vL2dGZDFQ?= =?utf-8?B?WDJWSVFIdHdncXVPNDZxbTVqakFsbXl0b1F0ZDRNb0p6a212cHVZRHVVcmYr?= =?utf-8?B?Yk1RNjhCMWVuaDJiN2FtVGxVS2JwWSs1U0phc09wYVFXQ2o4WkhiTFUzMUFo?= =?utf-8?B?OWZmTnBRaklwN1lYaEFaKzg2K2VUNDQ2c3VWYlhSVkJkVDVLN1U4NGcxWHBi?= =?utf-8?B?YmNRYkh1dzJ3dlp3QlVrL0VwRitTVE1GT1F2VWRhSXROM3ZQZ3hCV0lBVjB2?= =?utf-8?B?K1NWTGt1ZXJ2WElSczl0WG5lck1YQTM0L2hqWDlidkx2bU9oUkpXRUZkRXBR?= =?utf-8?B?NEQxMXRhSnljREJKdWRINzNudUx4OGI3Y2QydjRzS0hheFQ4eUhvZlEvVTBv?= =?utf-8?B?WnJiRkpuVzhGQlh2dXJRbndMSi9zandKSmZPWitBb0lzbjN5WWJ0Nzl5Q1Ev?= =?utf-8?B?djhJemhDVjZSVHpCd3pkZ0QyeFVTUnNBdzQ4T29hbmE0K3dhKzlBem5idlVy?= =?utf-8?B?dEMycjRUV2I2K0RsRjFkcmVNcWIycFFJaXlYbmhPUC9CaGpiUmhtUkJTQUp3?= =?utf-8?B?RU53Qy9ka0EyVExRQXNiWlZRUWRZb0hlYkdlMlFLTDJkUmxxRVljd2lXbXZC?= =?utf-8?B?bWxSWmxIYmVMbk5QdzBUMTZRWG13WC85NnJUa2cycDh0bFpGdCtaZlhFQjN5?= =?utf-8?B?cnVhWDJ2YXNrRnlhbWtyQkJ2UThkMEZYbzBLVGR0UFY2Q3lUbEc5S3VKdWln?= =?utf-8?B?VCtHOTZpN2wvdnd0UWJFQ3VmUkxqMjc0cUFvWnNyV0FjWW5hMGhLblRjN21m?= =?utf-8?B?Vm9WU3ZVMXRRYStpQVJSQ1BndWY1S1ZSWkl6WElaUkNZeURJbXFNbFRFYU5v?= =?utf-8?B?dmpMbVZvaGljQkxMcVJTak1nUWJBMFV6cWg4R3pLUjh6VkgwcjdEc2xiNTZL?= =?utf-8?B?Y0dMUndLMnhrZ3UvS05UaVlkckhmLzhWVkR1dTZycTZxNmZzVlVhcnRId1kw?= =?utf-8?B?M0M1bU1nc2w1bDlaTmkzaGxZbjVTbG5iRjZNRldkM0ZFQU1pTDZnVzZ0N1RG?= =?utf-8?B?ZlJQb3NaUzk0SklyeUdVK3MwQVlCa3Fjcjc4UStRNTlHVXBXMGRiN1pVeEQ1?= =?utf-8?B?SUxqVVJrQmw0UVZMVUxqZkdaQVVHQ3RObjhkS1dUK2diaURhQlVlM0ZwK3Iw?= =?utf-8?B?bkxYNExoYXdkZkRoU0N4VVdsczcvYVhSRDVFajdnMGZqRUhNNzJkVXlSK3ZS?= =?utf-8?B?WWpGb2l5OWhzVzRkOUR0Z0w0WVluU2xFTGhWeTVucDRsVFJ3ZDF6VmVOcG83?= =?utf-8?B?NFBnNzlYTEZxM1BpTUhQZ212VlZaSEY5bTRmeDQrck1QTVpBa0xtWmkybFMz?= =?utf-8?B?RHFsNjM0WFo1ZTF1TU9qWDhWeDROYnNFMUhrdnRiZDdTaW5jSUVZQjhnWUw5?= =?utf-8?B?aW44djhKc29Dd3N5VVN5NWJlUGplMExXUzJzeVBPc2F3S3I5UkxQUmdWU21J?= =?utf-8?B?dCtDaVBHbjNmY2NjazhMOWtsTU9RcWFYZGxHRHpYWitmMmxHWEpFelpwckVy?= =?utf-8?B?bmF6NXJxcVRGT041OVBXUy9UaTdVaE8wR1kveEc3bmRGZEdQRks1RFU5ME5V?= =?utf-8?B?bE5OYlVnQ1RTeUE0UzIzTjRTb0tMSDlucmZ4eTRlRzdQS1RMM01zMGorOE0w?= =?utf-8?B?MUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: a0eQV9svz8HuGG+FDncfgzHKISzcV7MdHy51cUCgrj3nMlngf6d3TKxf1ZHOxoE3sxGq/8PRQfkf8DHEqtUUChOEC25xVrVbdGW1qJFwBgqs0VzdUfsIdjciQ16vzWWwn4AVGGrBkTuJpcV/lZoyykOcKM3bwFLIrPLYAwlpnG2rkSmoaNMB6awI2dBshL+bcUURuaRjaDuEpLpBZogCcuv8aKU4pATykisj8p2EewGM6ympSNsBKlcPXs6lMgZ1ImWE4ZOvkUQunvTtws/l5gDYOH1eQLE2m3AC6q5/OLGlwEACkZHbHc9jmvWLjl04srUtOcxdTSPkMPawHlnrf92KcUtpwrLgwdo0oDbiQTLP9fVrL2VhP+Vc7Uapguhi1lJa/87teF8dM7uMDrIL9+Ps/UvndmPJDW2sXzAZ3rDv5dG9WO9f8HW25QVoui23sRk64mDlwxRQ3BxGj40JjZdMboxBJOfIy46sADch4dg44GQjvc2d1GJ8H/vTEtm/sHQHrWYOgj3MsyaOipPiIjblvIVMtPYIrmEkwZG1xcPDhOtLusG+wb4lmPgypW3tpTL87ncLhxGVlZNSTwJWVPnEkiFRmhLq4OYH2Wfx3owCaYLVZfQ6XeZMjoBcmovAAiRZaiuSI4iqTco7cqQgU6R2UeeUWJYFDwoUS3ko7ef+SbVd1WkqdpbTc2MfOIQ1lSpW32s5FNPmxxt+/EnRzV/cma1DOakvC8FAMCRbECNXkIwyc1SgbS0jK8+kAeaSPVNSSgH9nriyCO05raHQ7bemN9rTYC9psin7YCIdaWSfvQyMzsxk7KLRM/wHlvKgE3qK4GfFvNzQT0vpg7FNjZ6AWzNkjY+2fAJ2rd2DGvQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6004c88-bbb9-43ff-c876-08db0b97c89c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:51:14.0023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xrKiGyiIDTStX+ytGR+lWiWa5p+0eanqcd8k0EPicHAsMZHyW6bWYSOvAve7l6fJ6JnCfGPMUY53+i7tPnZXp493qUv9jqHm5e4RJCudaKc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6138 On 10/02/2023 12:44 pm, Samuel Thibault wrote: > Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: >> On 10.02.23 12:43, Andrew Cooper wrote: >>> On 10/02/2023 10:46 am, Juergen Gross wrote: >>>> diff --git a/lib/sys.c b/lib/sys.c >>>> index 2f33c937..dc8a8c69 100644 >>>> --- a/lib/sys.c >>>> +++ b/lib/sys.c >>>> @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, >>>> return fd; >>>> } >>>> -static struct mount_point mount_points[] = { >>>> +#ifdef CONFIG_CONSFRONT >>>> +#define STATIC_MNTS 4 >>>> +#else >>>> +#define STATIC_MNTS 2 >>>> +#endif >>> This ought to be >>> >>> #define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2)) >>> >>> because it shows where the parts come from, and is much cleaner to add a >>> 3rd one to in due course. >> In principle fine, but I'm not sure it is worth the effort to add >> IS_ENABLED() support to Mini-OS. >> >>> That said, it would be simpler to just have a total mounts set at 16 or >>> so?  Does a difference of two dynamic mounts depending on CONSFRONT >>> actually matter? >> Probably not. Samuel, any thoughts on that? > We can probably as well just have 16 mount entries indeed. I'm happy to fix that up on commit if it's the only other issue in this patch. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:53:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:53:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493584.763578 (Exim 4.92) (envelope-from ) id 1pQYWd-0006KF-A6; Fri, 10 Feb 2023 18:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493584.763578; Fri, 10 Feb 2023 18:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYWd-0006Jr-5r; Fri, 10 Feb 2023 18:53:35 +0000 Received: by outflank-mailman (input) for mailman id 493584; Fri, 10 Feb 2023 18:53:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYWb-0006J4-QO for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:53:33 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 355a1b2a-a974-11ed-93b5-47a8fe42b414; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 51E1320162; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5qNXIv7BGRAa; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2AD872015E; Fri, 10 Feb 2023 19:53:29 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYWW-006gXg-2V; Fri, 10 Feb 2023 19:53:28 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 355a1b2a-a974-11ed-93b5-47a8fe42b414 Date: Fri, 10 Feb 2023 19:53:28 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230210185328.2zqo5xvklpke3ie2@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:27 +0100, a ecrit: > +static bool path_canonical(const char *pathname) > +{ > + unsigned int len = strlen(pathname); > + const char *c; > + > + /* Empty path is allowed. */ > + if ( !len ) > + return true; > + > + /* No trailing '/'. */ > + if ( pathname[len - 1] == '/' ) > + return false; > + > + /* No self or parent references. */ > + c = pathname; > + while ( (c = strstr(c, "/.")) != NULL ) > + { > + if ( c[2] == '.' ) > + c++; > + if ( c[2] == 0 || c[2] == '/' ) > + return false; > + c += 2; > + } > + > + return true; > +} This doesn't seem to be catching "//"? Samuel From xen-devel-bounces@lists.xenproject.org Fri Feb 10 18:59:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 18:59:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493595.763593 (Exim 4.92) (envelope-from ) id 1pQYcE-0007Dp-0C; Fri, 10 Feb 2023 18:59:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493595.763593; Fri, 10 Feb 2023 18:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYcD-0007Di-Td; Fri, 10 Feb 2023 18:59:21 +0000 Received: by outflank-mailman (input) for mailman id 493595; Fri, 10 Feb 2023 18:59:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYcC-0007Bl-5B for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 18:59:20 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04fc30ba-a975-11ed-933c-83870f6b2ba8; Fri, 10 Feb 2023 19:59:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 9912B20162; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sn_dddDhMJVD; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 6B9572015E; Fri, 10 Feb 2023 19:59:17 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pQYc8-006ghi-2H; Fri, 10 Feb 2023 19:59:16 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04fc30ba-a975-11ed-933c-83870f6b2ba8 Date: Fri, 10 Feb 2023 19:59:16 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230210185916.2qjo6yh7c3usheyp@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230210104628.14374-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le ven. 10 févr. 2023 11:46:28 +0100, a ecrit: > + while ( len ) > + { > + count = len; > + if ( count > dev->msize_max - 24 ) > + count = dev->msize_max - 24; 24 should be detailed, to include e.g. sizeof(p9_header) and the sum of sizes of the fields (I'm surprised that it's the same 24 for read and write, notably). > + send_9p(dev, req, "ULU", fid, offset, count); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( !count ) > + break; > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; I'd say log req->result? > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + const uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_WRITE; > + > + while ( len ) > + { > + count = len; > + if ( count > dev->msize_max - 24 ) > + count = dev->msize_max - 24; Same here. > + send_9p(dev, req, "ULD", fid, offset, count, data); > + rcv_9p(dev, req, "U", &count); > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; Same here. > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} From xen-devel-bounces@lists.xenproject.org Fri Feb 10 19:00:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 19:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493605.763603 (Exim 4.92) (envelope-from ) id 1pQYdC-0000AZ-8r; Fri, 10 Feb 2023 19:00:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493605.763603; Fri, 10 Feb 2023 19:00:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYdC-0000AS-69; Fri, 10 Feb 2023 19:00:22 +0000 Received: by outflank-mailman (input) for mailman id 493605; Fri, 10 Feb 2023 19:00:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYdA-0000AJ-UJ for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 19:00:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYdA-00076j-Io; Fri, 10 Feb 2023 19:00:20 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQYdA-0000XJ-8t; Fri, 10 Feb 2023 19:00:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EY9fHXcQZYvbrmgDb4sBFvGy/e2Hl5KlxymnmKUHS8k=; b=RnTRmOtwsGnjMOnlkn30Bsm0xV ihBwJEzMrYL138hI2em2Qy7E8C9/pQCaJ1N4gukFoahry/gbnqIUwPdqfuG8dYdSivgyFt1edd0so wgJuSsTauIX6MN6oygOyzar81N8ggFg+S4+6dmvKje5zHazFmr0DChYovmhSdDykB9mM=; Message-ID: <8cc8c4a2-dc6b-6302-5ce6-7bdbb21772dc@xen.org> Date: Fri, 10 Feb 2023 19:00:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN][RFC PATCH v4 01/16] xen/arm/device: Remove __init from function type Content-Language: en-US To: Vikram Garhwal , Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Bertrand Marquis , Volodymyr Babchuk References: <20221207061537.7266-1-vikram.garhwal@amd.com> <20221207061537.7266-2-vikram.garhwal@amd.com> <1be7ea27-aec5-e2ae-48c1-fe0c1f099181@amd.com> <7a1d10b9-083c-a8f5-0315-c9f77ad04239@amd.com> From: Julien Grall In-Reply-To: <7a1d10b9-083c-a8f5-0315-c9f77ad04239@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09/02/2023 20:11, Vikram Garhwal wrote: > Hi Michal, > > Thanks for reviewing this. Please see my comments below. > > On 1/20/23 4:39 AM, Michal Orzel wrote: >> Hi Vikram, >> >> On 07/12/2022 07:15, Vikram Garhwal wrote: >>> >>> Change function type of following function to access during runtime: >>>      1. map_irq_to_domain() >>>      2. handle_device_interrupt() >>>      3. map_range_to_domain() >>>      4. unflatten_dt_node() >>>      5. unflatten_device_tree() >> If you do not want to do this at first use, then this should be a >> separate patch. >>> Move map_irq_to_domain(), handle_device_interrupt() and >>> map_range_to_domain() to >>> device.c. >> This should be a separate patch (without removing __init) to make the >> comparison easier. > Okay >> >>> unflatten_device_tree(): Add handling of memory allocation failure. >> Apart from that you also renamed __unflatten_device_tree to >> unflatten_device_tree >> and you did not mention it. > I will add this in commit. >> >>> These changes are done to support the dynamic programming of a nodes >>> where an >>> overlay node will be added to fdt and unflattened node will be added >>> to dt_host. >>> Furthermore, IRQ and mmio mapping will be done for the added node. >>> >>> Signed-off-by: Vikram Garhwal >>> --- >>>   xen/arch/arm/device.c            | 145 +++++++++++++++++++++++++++++++ >>>   xen/arch/arm/domain_build.c      | 142 ------------------------------ >>>   xen/arch/arm/include/asm/setup.h |   3 + >>>   xen/common/device_tree.c         |  27 +++--- >>>   xen/include/xen/device_tree.h    |   5 ++ >>>   5 files changed, 170 insertions(+), 152 deletions(-) >>> >>> diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c >>> index 70cd6c1a19..d299c04e62 100644 >>> --- a/xen/arch/arm/device.c >>> +++ b/xen/arch/arm/device.c >>> @@ -21,6 +21,9 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>> +#include >>> +#include >>> >>>   extern const struct device_desc _sdevice[], _edevice[]; >>>   extern const struct acpi_device_desc _asdevice[], _aedevice[]; >>> @@ -84,6 +87,148 @@ enum device_class device_get_class(const struct >>> dt_device_node *dev) >>>       return DEVICE_UNKNOWN; >>>   } >>> >>> +int map_irq_to_domain(struct domain *d, unsigned int irq, >>> +                      bool need_mapping, const char *devname) >>> +{ >>> +    int res; >>> + >>> +    res = irq_permit_access(d, irq); >>> +    if ( res ) >>> +    { >>> +        printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ >>> %u\n", >>> +               d->domain_id, irq); >>> +        return res; >>> +    } >>> + >>> +    if ( need_mapping ) >>> +    { >>> +        /* >>> +         * Checking the return of vgic_reserve_virq is not >>> +         * necessary. It should not fail except when we try to map >>> +         * the IRQ twice. This can legitimately happen if the IRQ is >>> shared >>> +         */ >>> +        vgic_reserve_virq(d, irq); >>> + >>> +        res = route_irq_to_guest(d, irq, irq, devname); >>> +        if ( res < 0 ) >>> +        { >>> +            printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", >>> +                   irq, d->domain_id); >>> +            return res; >>> +        } >>> +    } >>> + >>> +    dt_dprintk("  - IRQ: %u\n", irq); >>> +    return 0; >>> +} >>> + >>> +int map_range_to_domain(const struct dt_device_node *dev, >>> +                        u64 addr, u64 len, void *data) >>> +{ >>> +    struct map_range_data *mr_data = data; >>> +    struct domain *d = mr_data->d; >>> +    int res; >>> + >>> +    /* >>> +     * reserved-memory regions are RAM carved out for a special >>> purpose. >>> +     * They are not MMIO and therefore a domain should not be able to >>> +     * manage them via the IOMEM interface. >>> +     */ >>> +    if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", >>> +                     strlen("/reserved-memory/")) != 0 ) >>> +    { >>> +        res = iomem_permit_access(d, paddr_to_pfn(addr), >>> +                paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); >>> +        if ( res ) >>> +        { >>> +            printk(XENLOG_ERR "Unable to permit to dom%d access to" >>> +                   " 0x%"PRIx64" - 0x%"PRIx64"\n", >>> +                   d->domain_id, >>> +                   addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); >>> +            return res; >>> +        } >>> +    } >>> + >>> +    if ( !mr_data->skip_mapping ) >>> +    { >>> +        res = map_regions_p2mt(d, >>> +                               gaddr_to_gfn(addr), >>> +                               PFN_UP(len), >>> +                               maddr_to_mfn(addr), >>> +                               mr_data->p2mt); >>> + >>> +        if ( res < 0 ) >>> +        { >>> +            printk(XENLOG_ERR "Unable to map 0x%"PRIx64 >>> +                   " - 0x%"PRIx64" in domain %d\n", >>> +                   addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, >>> +                   d->domain_id); >>> +            return res; >>> +        } >>> +    } >>> + >>> +    dt_dprintk("  - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", >>> +               addr, addr + len, mr_data->p2mt); >>> + >>> +    return 0; >>> +} >>> + >>> +/* >>> + * handle_device_interrupts retrieves the interrupts configuration from >>> + * a device tree node and maps those interrupts to the target domain. >>> + * >>> + * Returns: >>> + *   < 0 error >>> + *   0   success >>> + */ >>> +int handle_device_interrupts(struct domain *d, >>> +                             struct dt_device_node *dev, >>> +                             bool need_mapping) >>> +{ >>> +    unsigned int i, nirq; >>> +    int res; >>> +    struct dt_raw_irq rirq; >>> + >>> +    nirq = dt_number_of_irq(dev); >>> + >>> +    /* Give permission and map IRQs */ >>> +    for ( i = 0; i < nirq; i++ ) >>> +    { >>> +        res = dt_device_get_raw_irq(dev, i, &rirq); >>> +        if ( res ) >>> +        { >>> +            printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", >>> +                   i, dt_node_full_name(dev)); >>> +            return res; >>> +        } >>> + >>> +        /* >>> +         * Don't map IRQ that have no physical meaning >>> +         * ie: IRQ whose controller is not the GIC >>> +         */ >>> +        if ( rirq.controller != dt_interrupt_controller ) >>> +        { >>> +            dt_dprintk("irq %u not connected to primary controller. >>> Connected to %s\n", >>> +                       i, dt_node_full_name(rirq.controller)); >>> +            continue; >>> +        } >>> + >>> +        res = platform_get_irq(dev, i); >>> +        if ( res < 0 ) >>> +        { >>> +            printk(XENLOG_ERR "Unable to get irq %u for %s\n", >>> +                   i, dt_node_full_name(dev)); >>> +            return res; >>> +        } >>> + >>> +        res = map_irq_to_domain(d, res, need_mapping, >>> dt_node_name(dev)); >>> +        if ( res ) >>> +            return res; >>> +    } >>> + >>> +    return 0; >>> +} >>> + >>>   /* >>>    * Local variables: >>>    * mode: C >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index 4fb5c20b13..acde8e714e 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -2229,41 +2229,6 @@ int __init make_chosen_node(const struct >>> kernel_info *kinfo) >>>       return res; >>>   } >>> >>> -int __init map_irq_to_domain(struct domain *d, unsigned int irq, >>> -                             bool need_mapping, const char *devname) >>> -{ >>> -    int res; >>> - >>> -    res = irq_permit_access(d, irq); >>> -    if ( res ) >>> -    { >>> -        printk(XENLOG_ERR "Unable to permit to dom%u access to IRQ >>> %u\n", >>> -               d->domain_id, irq); >>> -        return res; >>> -    } >>> - >>> -    if ( need_mapping ) >>> -    { >>> -        /* >>> -         * Checking the return of vgic_reserve_virq is not >>> -         * necessary. It should not fail except when we try to map >>> -         * the IRQ twice. This can legitimately happen if the IRQ is >>> shared >>> -         */ >>> -        vgic_reserve_virq(d, irq); >>> - >>> -        res = route_irq_to_guest(d, irq, irq, devname); >>> -        if ( res < 0 ) >>> -        { >>> -            printk(XENLOG_ERR "Unable to map IRQ%"PRId32" to dom%d\n", >>> -                   irq, d->domain_id); >>> -            return res; >>> -        } >>> -    } >>> - >>> -    dt_dprintk("  - IRQ: %u\n", irq); >>> -    return 0; >>> -} >> If you move map_irq_to_domain from domain_build.c to device.c, then >> the prototype needs to also >> be moved from domain_build.h to setup.h >> >>> - >>>   static int __init map_dt_irq_to_domain(const struct dt_device_node >>> *dev, >>>                                          const struct dt_irq *dt_irq, >>>                                          void *data) >>> @@ -2295,57 +2260,6 @@ static int __init map_dt_irq_to_domain(const >>> struct dt_device_node *dev, >>>       return 0; >>>   } >>> >>> -int __init map_range_to_domain(const struct dt_device_node *dev, >>> -                               u64 addr, u64 len, void *data) >>> -{ >>> -    struct map_range_data *mr_data = data; >>> -    struct domain *d = mr_data->d; >>> -    int res; >>> - >>> -    /* >>> -     * reserved-memory regions are RAM carved out for a special >>> purpose. >>> -     * They are not MMIO and therefore a domain should not be able to >>> -     * manage them via the IOMEM interface. >>> -     */ >>> -    if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", >>> -                     strlen("/reserved-memory/")) != 0 ) >>> -    { >>> -        res = iomem_permit_access(d, paddr_to_pfn(addr), >>> -                paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); >>> -        if ( res ) >>> -        { >>> -            printk(XENLOG_ERR "Unable to permit to dom%d access to" >>> -                    " 0x%"PRIx64" - 0x%"PRIx64"\n", >>> -                    d->domain_id, >>> -                    addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); >>> -            return res; >>> -        } >>> -    } >>> - >>> -    if ( !mr_data->skip_mapping ) >>> -    { >>> -        res = map_regions_p2mt(d, >>> -                               gaddr_to_gfn(addr), >>> -                               PFN_UP(len), >>> -                               maddr_to_mfn(addr), >>> -                               mr_data->p2mt); >>> - >>> -        if ( res < 0 ) >>> -        { >>> -            printk(XENLOG_ERR "Unable to map 0x%"PRIx64 >>> -                   " - 0x%"PRIx64" in domain %d\n", >>> -                   addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, >>> -                   d->domain_id); >>> -            return res; >>> -        } >>> -    } >>> - >>> -    dt_dprintk("  - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", >>> -               addr, addr + len, mr_data->p2mt); >>> - >>> -    return 0; >>> -} >>> - >>>   /* >>>    * For a node which describes a discoverable bus (such as a PCI bus) >>>    * then we may need to perform additional mappings in order to make >>> @@ -2373,62 +2287,6 @@ static int __init map_device_children(const >>> struct dt_device_node *dev, >>>       return 0; >>>   } >>> >>> -/* >>> - * handle_device_interrupts retrieves the interrupts configuration from >>> - * a device tree node and maps those interrupts to the target domain. >>> - * >>> - * Returns: >>> - *   < 0 error >>> - *   0   success >>> - */ >>> -static int __init handle_device_interrupts(struct domain *d, >>> -                                           struct dt_device_node *dev, >>> -                                           bool need_mapping) >>> -{ >>> -    unsigned int i, nirq; >>> -    int res; >>> -    struct dt_raw_irq rirq; >>> - >>> -    nirq = dt_number_of_irq(dev); >>> - >>> -    /* Give permission and map IRQs */ >>> -    for ( i = 0; i < nirq; i++ ) >>> -    { >>> -        res = dt_device_get_raw_irq(dev, i, &rirq); >>> -        if ( res ) >>> -        { >>> -            printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", >>> -                   i, dt_node_full_name(dev)); >>> -            return res; >>> -        } >>> - >>> -        /* >>> -         * Don't map IRQ that have no physical meaning >>> -         * ie: IRQ whose controller is not the GIC >>> -         */ >>> -        if ( rirq.controller != dt_interrupt_controller ) >>> -        { >>> -            dt_dprintk("irq %u not connected to primary controller. >>> Connected to %s\n", >>> -                      i, dt_node_full_name(rirq.controller)); >>> -            continue; >>> -        } >>> - >>> -        res = platform_get_irq(dev, i); >>> -        if ( res < 0 ) >>> -        { >>> -            printk(XENLOG_ERR "Unable to get irq %u for %s\n", >>> -                   i, dt_node_full_name(dev)); >>> -            return res; >>> -        } >>> - >>> -        res = map_irq_to_domain(d, res, need_mapping, >>> dt_node_name(dev)); >>> -        if ( res ) >>> -            return res; >>> -    } >>> - >>> -    return 0; >>> -} >>> - >>>   /* >>>    * For a given device node: >>>    *  - Give permission to the guest to manage IRQ and MMIO range >>> diff --git a/xen/arch/arm/include/asm/setup.h >>> b/xen/arch/arm/include/asm/setup.h >>> index fdbf68aadc..ec050848aa 100644 >>> --- a/xen/arch/arm/include/asm/setup.h >>> +++ b/xen/arch/arm/include/asm/setup.h >>> @@ -163,6 +163,9 @@ void device_tree_get_reg(const __be32 **cell, u32 >>> address_cells, >>>   u32 device_tree_get_u32(const void *fdt, int node, >>>                           const char *prop_name, u32 dflt); >>> >>> +int handle_device_interrupts(struct domain *d, struct dt_device_node >>> *dev, >>> +                             bool need_mapping); >>> + >>>   int map_range_to_domain(const struct dt_device_node *dev, >>>                           u64 addr, u64 len, void *data); >>> >>> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >>> index 6c9712ab7b..6518eff9b0 100644 >>> --- a/xen/common/device_tree.c >>> +++ b/xen/common/device_tree.c >>> @@ -1811,12 +1811,12 @@ int dt_count_phandle_with_args(const struct >>> dt_device_node *np, >>>    * @allnextpp: pointer to ->allnext from last allocated device_node >>>    * @fpsize: Size of the node path up at the current depth. >>>    */ >>> -static unsigned long __init unflatten_dt_node(const void *fdt, >>> -                                              unsigned long mem, >>> -                                              unsigned long *p, >>> -                                              struct dt_device_node >>> *dad, >>> -                                              struct dt_device_node >>> ***allnextpp, >>> -                                              unsigned long fpsize) >>> +static unsigned long unflatten_dt_node(const void *fdt, >>> +                                       unsigned long mem, >>> +                                       unsigned long *p, >>> +                                       struct dt_device_node *dad, >>> +                                       struct dt_device_node >>> ***allnextpp, >>> +                                       unsigned long fpsize) >>>   { >>>       struct dt_device_node *np; >>>       struct dt_property *pp, **prev_pp = NULL; >>> @@ -2047,7 +2047,7 @@ static unsigned long __init >>> unflatten_dt_node(const void *fdt, >>>   } >>> >>>   /** >>> - * __unflatten_device_tree - create tree of device_nodes from flat blob >>> + * unflatten_device_tree - create tree of device_nodes from flat blob >>>    * >>>    * unflattens a device-tree, creating the >>>    * tree of struct device_node. It also fills the "name" and "type" >>> @@ -2056,8 +2056,7 @@ static unsigned long __init >>> unflatten_dt_node(const void *fdt, >>>    * @fdt: The fdt to expand >>>    * @mynodes: The device_node tree created by the call >>>    */ >>> -static void __init __unflatten_device_tree(const void *fdt, >>> -                                           struct dt_device_node >>> **mynodes) >>> +int unflatten_device_tree(const void *fdt, struct dt_device_node >>> **mynodes) >>>   { >>>       unsigned long start, mem, size; >>>       struct dt_device_node **allnextp = mynodes; >>> @@ -2079,6 +2078,12 @@ static void __init >>> __unflatten_device_tree(const void *fdt, >>>       /* Allocate memory for the expanded device tree */ >>>       mem = (unsigned long)_xmalloc (size + 4, __alignof__(struct >>> dt_device_node)); >>> >>> +    if ( mem == 0 ) >> NIT: !mem would be preffered. >> >>> +    { >>> +        printk(XENLOG_ERR "Cannot allocate memory for unflatten >>> device tree\n"); >>> +        return -ENOMEM; >> What is the point of modifying the function to return a value if ... >>> +    } >>> + >>>       ((__be32 *)mem)[size / 4] = cpu_to_be32(0xdeadbeef); >>> >>>       dt_dprintk("  unflattening %lx...\n", mem); >>> @@ -2095,6 +2100,8 @@ static void __init >>> __unflatten_device_tree(const void *fdt, >>>       *allnextp = NULL; >>> >>>       dt_dprintk(" <- unflatten_device_tree()\n"); >>> + >>> +    return 0; >>>   } >>> >>>   static void dt_alias_add(struct dt_alias_prop *ap, >>> @@ -2179,7 +2186,7 @@ dt_find_interrupt_controller(const struct >>> dt_device_match *matches) >>> >>>   void __init dt_unflatten_host_device_tree(void) >>>   { >>> -    __unflatten_device_tree(device_tree_flattened, &dt_host); >>> +    unflatten_device_tree(device_tree_flattened, &dt_host); >> ... you do not check it anyway? > So, here we kept it same but unflatten_device_tree() return is checked > in dt_overlay.c. Return of this function will be useful in dt_overlay as > we can run out of mem during runtime. Perhaps I will add another comment > about the reasoning for adding this. It is a good practice to check the error return. In this case, I would call panic() when there is an error. With that said, the hardening of __unflatten_device_tree() deserve its own patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 19:01:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 19:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493611.763615 (Exim 4.92) (envelope-from ) id 1pQYeA-0000ns-Og; Fri, 10 Feb 2023 19:01:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493611.763615; Fri, 10 Feb 2023 19:01:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYeA-0000nl-Ki; Fri, 10 Feb 2023 19:01:22 +0000 Received: by outflank-mailman (input) for mailman id 493611; Fri, 10 Feb 2023 19:01:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYe9-0000nb-Et for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 19:01:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYe9-00077z-5h; Fri, 10 Feb 2023 19:01:21 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQYe8-0000bH-Ub; Fri, 10 Feb 2023 19:01:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IvZqNFzBG13Al56zK+lxg3Yn6QmzOEO8qs5LmuOecs8=; b=v+zYR8mUBOC7I3Saz0qFjlru6d JcnJh4O9xAh5KjYhQoh41zMwjjpJ5IQUID3W5BnPr0cvIxXL5wSzIXvBMu3nHflLojlkim1y7frxY V/YiSO+7uVgglEQYYm8so7RVAr4VXbk/103snP7O/yWWcvTQbK0SfVdCmeAfhzPccZcE=; Message-ID: Date: Fri, 10 Feb 2023 19:01:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN][RFC PATCH v4 02/16] xen/arm: Add CONFIG_OVERLAY_DTB Content-Language: en-US To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Bertrand Marquis , Volodymyr Babchuk References: <20221207061537.7266-1-vikram.garhwal@amd.com> <20221207061537.7266-3-vikram.garhwal@amd.com> From: Julien Grall In-Reply-To: <20221207061537.7266-3-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/12/2022 06:15, Vikram Garhwal wrote: > Introduce a config option where the user can enable support for adding/removing > device tree nodes using a device tree binary overlay. > > Signed-off-by: Vikram Garhwal > --- > xen/arch/arm/Kconfig | 5 +++++ You also want to update SUPPORT.md. > 1 file changed, 5 insertions(+) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 1fe5faf847..ae2ebf1697 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -52,6 +52,11 @@ config HAS_ITS > bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED > depends on GICV3 && !NEW_VGIC > > +config OVERLAY_DTB > + bool "DTB overlay support (UNSUPPORTED)" if UNSUPPORTED > + help > + Dynamic addition/removal of Xen device tree nodes using a dtbo. > + > config HVM > def_bool y > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 19:02:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 19:02:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493618.763625 (Exim 4.92) (envelope-from ) id 1pQYfO-0001OY-20; Fri, 10 Feb 2023 19:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493618.763625; Fri, 10 Feb 2023 19:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYfN-0001OR-Vh; Fri, 10 Feb 2023 19:02:37 +0000 Received: by outflank-mailman (input) for mailman id 493618; Fri, 10 Feb 2023 19:02:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYfN-0001OH-4d for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 19:02:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQYfM-00079H-Tq; Fri, 10 Feb 2023 19:02:36 +0000 Received: from [54.239.6.186] (helo=[192.168.26.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQYfM-0000dW-Me; Fri, 10 Feb 2023 19:02:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1QRQJ1FQyrM3QlsVI/CPr4VYYyWlLkbTnFYWEK2PiUQ=; b=QS+64WPfE8dEudSxCJzLfYDss7 8j3Ad09kL3nv0f5ZEyWGyqnaLt8g7o12UfkeOTJYKcBAHpfSxkHbFwC0fQprgrO19kjeVvquQvbKx zxkyT0d8g7P51EojTltFmLv6YVbROlZjMK60Ik+w6CihVIHHE6+ez86YxsUm6UlR87os=; Message-ID: <0d29c301-497e-1868-ee98-e986b732d073@xen.org> Date: Fri, 10 Feb 2023 19:02:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN][RFC PATCH v4 03/16] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB. Content-Language: en-US To: Vikram Garhwal , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org References: <20221207061537.7266-1-vikram.garhwal@amd.com> <20221207061537.7266-4-vikram.garhwal@amd.com> From: Julien Grall In-Reply-To: <20221207061537.7266-4-vikram.garhwal@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 07/12/2022 06:15, Vikram Garhwal wrote: > This is done to access fdt library function which are required for adding device > tree overlay nodes for dynamic programming of nodes. > > Acked-by: Julien Grall > Signed-off-by: Vikram Garhwal The tags are usually ordered chronologically: you first wrote the patch and then I acked. So please switch the two tags. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 10 21:24:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 21:24:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493646.763637 (Exim 4.92) (envelope-from ) id 1pQasJ-00019h-Gb; Fri, 10 Feb 2023 21:24:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493646.763637; Fri, 10 Feb 2023 21:24:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQasJ-00019a-CA; Fri, 10 Feb 2023 21:24:07 +0000 Received: by outflank-mailman (input) for mailman id 493646; Fri, 10 Feb 2023 21:24:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQasI-00019Q-Ol; Fri, 10 Feb 2023 21:24:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQasI-00029l-Kr; Fri, 10 Feb 2023 21:24:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQasI-0005cf-DY; Fri, 10 Feb 2023 21:24:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQasI-0006AV-D8; Fri, 10 Feb 2023 21:24:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZoYfNWx1qq73gWXDzE/akUfwU3dGF2gjJEDdJWf+n88=; b=nZ6Tm0kndOpN7kq7v02n9XAu+E Ry+SWtqAZ9MGbFnp5NiyQjJzHZJcKazafAMv28JOX8ayQYg02Ua2hXNJdauzbz0Zp2+yxMvAsAPqy iRMKm/69hWYCvydYE6Iw+bpTB4sc5KiRMJ4lHSFkYvustyX6ylHTjSqB0uLvcFOoPmiI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 176810: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-qemuu-nested-amd:xen-boot/l1:fail:heisenbug linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 X-Osstest-Versions-That: linux=90245959a5b936ee013266e5d1e6a508ed69274e From: osstest service owner Date: Fri, 10 Feb 2023 21:24:06 +0000 flight 176810 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/176810/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail in 176722 pass in 176810 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 176722 pass in 176810 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176722 pass in 176810 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 176722 test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail pass in 176722 Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail in 176722 like 176106 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176106 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 baseline version: linux 90245959a5b936ee013266e5d1e6a508ed69274e Last test of basis 176106 2023-01-24 20:10:07 Z 17 days Testing same since 176413 2023-02-06 07:13:34 Z 4 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: "Eric W. Biederman" Adrian Hunter Ajith Nayak Alexander Potapenko Alexey V. Vissarionov Andrew Halaney # sa8540p-ride Andrew Lunn Andrew Morton Andrey Konovalov Archie Pusaka Arnd Bergmann Baoquan He Bartosz Golaszewski Borislav Petkov (AMD) Chancel Liu Chen Zhongjin Christian Borntraeger Christoph Hellwig Chuck Lever Claudiu Beznea # on SAMA7G5 Colin Ian King Daniel Borkmann Daniel Vetter Dario Binacchi David Christensen David Gow David Howells David Morley David S. Miller David Sterba Dean Luick Dennis Dalessandro Dmitry Torokhov Don Brace Dongliang Mu Eric Biggers Eric Dumazet Eric W. Biederman Esina Ekaterina Fabio Estevam Fabio Estevam Fedor Pchelkin Florian Fainelli Florian Westphal Gaosheng Cui Geert Uytterhoeven Giulio Benetti Gong, Sishuai Greg Kroah-Hartman Guenter Roeck Haibo Chen Hans de Goede Hao Sun Heiko Carstens Heiner Kallweit Hendrik Borghorst Henriette Hofmeier Hui Wang Hulk Robot Ian Rogers Ingo Molnar Jakub Kicinski Jakub Sitnicki Jan Kara Jann Horn Jason Xing Jens Axboe Jerome Brunet Jiasheng Jiang Jiri Kosina Jisoo Jang Joel Fernandes (Google) Joel Savitz Kalle Valo Kees Cook Kim Phillips Koba Ko Krishna Kurapati Krzysztof Kozlowski Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linux Kernel Functional Testing Liu Shixin Luis Chamberlain Luis Gerhorst Luiz Augusto von Dentz Manivannan Sadhasivam Marcelo Ricardo Leitner Marek Szyprowski Marek Vasut Mark Brown Mark Rutland Martin K. Petersen Martin Wilck Masahiro Yamada Mateusz Guzik Mathias Nyman Matthias Kaehlcke Miaoqian Lin Michael Klein Mikulas Patocka Miles Chen Natalia Petrova Nathan Chancellor Neal Cardwell Nicholas Piggin # powerpc Niklas Schnelle Nikos Tsironis Ovidiu Panait Pablo Neira Ayuso Paolo Abeni Paolo Bonzini Patrick Thompson Peter Chen Peter Korsgaard Peter Zijlstra (Intel) Peter Zijlstra Petr Pavlu Pietro Borrello Radhey Shyam Pandey Rafael J. Wysocki Raju Rangoju Rakesh Sankaranarayanan Randy Dunlap Robert Hancock Russell King (Oracle) Saeed Mahameed Sasha Levin Shang XiaoJing Shawn Guo Shengjiu Wang Shuah Khan Shyam Sundar S K Sishuai Gong Soenke Huster Srinivas Pandruvada Sriram Yagnaraman Stanislav Fomichev Steev Klimaszewski # Thinkpad X13s Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sudheesh Mavila Sumit Gupta Swati Agarwal Szymon Heidrich Tejun Heo Tetsuo Handa Thomas Gleixner Tiezhu Yang Tim Harvey Tom Talpey Tony Luck # ia64 Trond Myklebust Tudor Ambarus Udipto Goswami Ulf Hansson Uwe Kleine-König Vinod Koul Viresh Kumar Will Deacon # arm64 Xiang Chen Xiaoming Ni Yang Yingliang Yihang Li Yonatan Nachum Yoshihiro Shimoda Yu Kuai jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 90245959a5b9..59342376e8f0 59342376e8f0c704299dc7a2c14fed07ffb962e2 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Fri Feb 10 23:15:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 23:15:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493663.763648 (Exim 4.92) (envelope-from ) id 1pQcbG-0005Td-M8; Fri, 10 Feb 2023 23:14:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493663.763648; Fri, 10 Feb 2023 23:14:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcbG-0005TW-I1; Fri, 10 Feb 2023 23:14:38 +0000 Received: by outflank-mailman (input) for mailman id 493663; Fri, 10 Feb 2023 23:14:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcbF-0005TM-Iq; Fri, 10 Feb 2023 23:14:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcbF-0004dq-HN; Fri, 10 Feb 2023 23:14:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcbF-00088x-6Q; Fri, 10 Feb 2023 23:14:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQcbF-0001gm-5y; Fri, 10 Feb 2023 23:14:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+D8XYSicQuF1veoTUpb5TxDDVHSmnkNEk1m7xb4YbYo=; b=b+HYo62861X7zKnhJt5BLgeWAB Xth4x9UhrYE10DuxQuYMPngcAehp+M3OYbfhU8/hHdFnQA1RSz5lLr6Cg9y0YpmFK8jAsnw58Uwuu 9yIuzGp51qZFc7+dGjklRT7yhGy2tQv9eKQSgNzp6kNBm1gSCIEYXjmKQ/XGIKPWL6vA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176816: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=86cfe93ef7fdc2d665a2fc88b79af89e7978ba78 X-Osstest-Versions-That: libvirt=8a63add283c310952b7df161b4b413e817468d01 From: osstest service owner Date: Fri, 10 Feb 2023 23:14:37 +0000 flight 176816 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176816/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 86cfe93ef7fdc2d665a2fc88b79af89e7978ba78 baseline version: libvirt 8a63add283c310952b7df161b4b413e817468d01 Last test of basis 176704 2023-02-09 04:21:54 Z 1 days Testing same since 176816 2023-02-10 04:18:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 8a63add283..86cfe93ef7 86cfe93ef7fdc2d665a2fc88b79af89e7978ba78 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 10 23:24:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 23:24:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493671.763659 (Exim 4.92) (envelope-from ) id 1pQcku-000781-Jh; Fri, 10 Feb 2023 23:24:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493671.763659; Fri, 10 Feb 2023 23:24:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcku-00077u-Gu; Fri, 10 Feb 2023 23:24:36 +0000 Received: by outflank-mailman (input) for mailman id 493671; Fri, 10 Feb 2023 23:24:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcks-00077Y-Hq for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 23:24:34 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062d.outbound.protection.outlook.com [2a01:111:f400:7eab::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 108daf73-a99a-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 00:24:31 +0100 (CET) Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by DS7PR12MB8252.namprd12.prod.outlook.com (2603:10b6:8:ee::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Fri, 10 Feb 2023 23:24:24 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::f803:f951:a68f:663a%8]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 23:24:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 108daf73-a99a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKO6qDc2uIUTY4ndQdXCVxhwGru0PPetS7fSaK0ALhkGXJkoiAIbC0hnBUaQmNgrvuJwfbOAKZJRm5+S1+IlKi/n83BVNyyril10T4Epm1uZz80K2jNsiLwEtk1VQkUKYWCdSKr8Fo2j4zCvCpQ4VJZW5JRaRYVlvgxGxzsHu7yyNUxTI5RT2UenviXm/YLt07M3lVFTTPoeY49ddhe9zZ5CVa8jrDi2l6hpIqNvl2WeCgKqeXSQo52bm1LmpZVjNgJT0iwhuNWfwo6FtNVXkeI15+47hY6GWALamJLGJYGR2EQIY/Q03DQuZyz9AbZIwPw54dJEZOQcLNMaiJD+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nehvKniT6zbTnTg+jqNY3Bg4NdxEA5bq+i0j6ucH91Y=; b=dP1u0BhOKZug0Zgc2B/PHjjuNClJ+0ANu29/ygzDjaxcG3o9VsiupwQ/kfZ8msavxv5+9QnhTwuebq2CMfX/G5GKhDD6e+h8RVYbzoe1v/DaRV1dpbBPk+9gAXctzO7irIuBwbnzKNnEpY3EenA8aZQm/FuT3aOobtpRtdhPyu+dZd7wz79mlpWK27Ty5zrVVlUJm0VYGtZXlLT9QaBzfQYkGXCrnCKouS4nEezjy+xHP3OZSUkC/jQXIlJzb/7gmLzVqb7QVRaPSeqvc5UoqD2KI/wLdhLH31T/mw28iIA5C2kWvEoMHWH4mAEmV44sH+fJgGabOxhA1LAaAFKydg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nehvKniT6zbTnTg+jqNY3Bg4NdxEA5bq+i0j6ucH91Y=; b=i2hzGamsCOx/Vjg9QPofFK49cJkcHr7V0mOKBpolPHSjUkfGGEWsGUAmyrrSd9Yg0R3ISucRVUIHHewUyFC+GiI6mYV2YK3L2xSlL0lVWLqdu0gCb32jbh9yqwbVKXL/n50OPVm3eJfd8lHe3XIDF58cSf3JWsGL9u0M4Ji/6W8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <44fca341-b40a-12cd-c97b-7f16f8de0e85@amd.com> Date: Fri, 10 Feb 2023 15:24:22 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN][RFC PATCH v4 12/16] xen/arm: Implement device tree node removal functionalities Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, Luca.Fancellu@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20221207061815.7404-1-vikram.garhwal@amd.com> <20221207061815.7404-6-vikram.garhwal@amd.com> From: Vikram Garhwal In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0083.namprd03.prod.outlook.com (2603:10b6:a03:331::28) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|DS7PR12MB8252:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f20fc56-805e-48b5-b60d-08db0bbdf1f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: izjVo3pPRmfPD+V9tOO1OGI0gq1KSz6sfGOHxPgpIuOfRvE7I6WZQDmTuEZCeBE/EJCHNmoDEA0EeOWbmuQ5N/bd68bcdl6CxjB/NRWisB6V2mQnkbA5dbr8tKJd11ktxWckpeUYUVOPZ2j8f4GgHEd3fCB1V4EFIHm2bdVSYXBmeJuPqHM9sY9TX4udeuLXpvr85LByh+igfCVW/vsqcnVWNJGrvQioStKB6l0RpRHvNebjFgtFbIDL9VbCfRRdJGaib/eyBdsOqOfe+MAJeE4z9RdCcW4qfA4xHszXRSNASBABI9BPRiWrHVTuBB15z97Bwdvib+nLGcFRNQNd8V4CVqFJtU/KsYnhj0bc6d/2dxdERKhgvqwfXy1e9P91m1UL7A5FJXb98pchlwXjCDL8RQLYC2PQJhUbVN5PbXgskraK6qeBb861pRbvO8mHyblJNjtWot4Sl8i2W1fQbUDnUD+df0OK0HH1+4vSzCySQeocLlxrBsf7IEVGWC1bXotKuF/zhkAZP8PxId4C8KLFcsik80sfKIPqmR23SVBxV7i/t/80Z3yIg9S9eTX/NA3TX9dcPNz2Jt5DX0MofT1nkb3UZt/DERtJmvBcQzmefFp4SVKRJIUoTfcmd4PU2phrRAabdon0n7Vwluqi34O8TDDzLbvFZFtrNc8hIa2n0xrJ9OCpngk83WSJosPlFCStR68os1t6kUk/JAG7aP67E0WLc63N19+PQlsIPDDXeD/XtRIdyfW6nWi1xQ+V3lT0PXWm5izJqHUBi6Cq0uflkP8MvEx3SsN2MD/t+6To6qt7Wip6BhXPgMLVkYoR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4409.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(451199018)(66946007)(66556008)(4326008)(66476007)(8676002)(36756003)(38100700002)(86362001)(31696002)(316002)(44832011)(5660300002)(41300700001)(30864003)(8936002)(2906002)(83380400001)(26005)(186003)(6506007)(53546011)(2616005)(54906003)(31686004)(6512007)(478600001)(966005)(6486002)(403724002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2U0Y254c2E3eExWSUNNSWdKWkxPSy9HRGR5TjZaWVNscTU4U3JJaERqWGJF?= =?utf-8?B?cDZBZ0ZseHN2eEx4MEUyb0FXTGtaaGZteE5sdFpuaDZFb2NFSVdURHpTMlQ3?= =?utf-8?B?VTFGd1Jqa2pzT3M1YVZRaCt4dlFWRDJZS0VPMjF1RFJiYmZDK3lONHBEMUd6?= =?utf-8?B?Z1VDQ1ptaUlCUC9aTEZQa2k4cW10d1gyL0psSmtQUzRQQWRCUkg3SjZRbmVw?= =?utf-8?B?QlBzNWcvNTFEZUNzSEdIVDhuOHV3WVBReTBDRzc0K3NSMHF6bzJnMlp2OGJi?= =?utf-8?B?U0xtaTNNU2NRdURCWnoxL3B1UWF6NjZ6QzJPVC9uaVVXY1BvZzQwa1JmNWgv?= =?utf-8?B?cmUrdzlvRGw1WDluOVJOQktUclp0UmIzMlpQc0o2dVRYMGVjUWR1dm15bjhN?= =?utf-8?B?YWZBdklZNU94bEozTitvcXNWN0ZxUkVJQ0MwYlNpRERtVnIxNVA2QndINmdi?= =?utf-8?B?anFQczdZelFSY09HQ3JIU0V1NWxqbHhwYlk4RE14cDFiS3Y3QnY1SFRORlhP?= =?utf-8?B?SEF5aVZaMVNXdWd6WjBZUlIzUGllSzYrWklTNkNxYlN2QUo0SHlmQXdjNHVC?= =?utf-8?B?c3RUVmFqZ2xybU1DZzIwVHFVV3N3TUxqb1hNemczU0tOU2pQOTdVNmQvUXpP?= =?utf-8?B?VXZOWnhQSjcvRzd3RmcyMWZMalpVUWlsN0M3Y0Vhc1BXQ3Naa3p2SUxxcklq?= =?utf-8?B?V1phQTNNZDFSNjFHMCtWVlFabE9xTi9BMk1CdUd6Vldpdy9EODFpbnJaZ3pT?= =?utf-8?B?WFpWazRoK1dOWkppaXROb3Z5Zmt2MmN6Um5JSkV1d1YwYlFQODRZUHB3S0N6?= =?utf-8?B?KzROY0VDRGIrdHBZd3dGa0t0cTQwZ0xuZzN2b25QWHNhUld5Vlk0djRpUk9I?= =?utf-8?B?OWJ2L3h4TXBNNXk1M2NZRmQvenVCeDdJMzk2TFZSNjlEZm9JNENsTmpZSnlj?= =?utf-8?B?Ti9IN2tidXhsTEp1dEU5ZXJFWGtUbDcrZmFsOUZ1dVZ5cWl6MWxQeXhDdFN5?= =?utf-8?B?OGY1TkNHS1hDZE11aHQraDRoY3NjM285STRLYm9SY1dqdTk4VW1VdkVDckJv?= =?utf-8?B?c011NzE1WENrczlORXp1QkxVYjE1RFA3OXFlUGZNbDZUdGZMMWpOUkM1bkxq?= =?utf-8?B?VkFJS1pKT1JEL0J3bDAzOUowNUdIRWxzNHZ4VkxKL3FzSDVSK1lhcDBUSXRK?= =?utf-8?B?amdWZmphVzRIN21pMFpFbm9ud0hUQWZNV0xsYzdWK0hiSFhzeUJENmRZcDMx?= =?utf-8?B?cmRYeXB2SXA2K002SXEyNWFSelI5alRvNmI0aGFvS21QYzR1SWNqNkRBRUh5?= =?utf-8?B?TFVoL0dXQVZZcWYrcGF1L3U0RE9YbUJQZ0tNK0J4S0lXK3B6NVRQeE5QSHly?= =?utf-8?B?ZmFQcC9jZVJPNGJ2RDJFdDE1QUxkZkhWTi9rMFpiMWJkcHNLY1pSQm1VK1VG?= =?utf-8?B?RGYwejg0S3c1VStsRHhMVXkrV1NnNEdBUXBnTVQ5dXNmR3BJRGF3T1J3WmE5?= =?utf-8?B?TldaajRVamtqYk5zUTBOalhNcVFnOThLUjVuZzM1WHRPeEM2VEZpcWtDQ3JM?= =?utf-8?B?aWQrZG1rVEhsWDhqUHZRQ25GQUpFOGhSdHptSk9DSHRSaWhCQmZyUDRYSE5E?= =?utf-8?B?YnU0OFFxQUhsak5qczg0VWhTdHBpTVJMR0NPc0ZjRnFRcUNNamh3bkNBbTR6?= =?utf-8?B?ZG10eXVXZTMraXN4SURqdXdWSm51VzQ4dFlSNHpZLytreGF5ajQzUU9zWmFs?= =?utf-8?B?TEVVWXBBV1hDcnRPcEhMNDNHVi9FYTQ4Z2Rtb0prZWlpTVJlL3dERDlCdzhK?= =?utf-8?B?aGZQR1loK1VOU0YxeStyeHVrd21hWFg1RWtteGp4VU56d0U2ZDAvQndGbHU3?= =?utf-8?B?N01HNkNDbEU1MnB1ZzYyeGQvbGp5SUk3SWFWUW10R2pzM2I0THZpeXkrUm9K?= =?utf-8?B?amZSRTMyUGhHVHRWMFhZZ3UyREc5L0d6Z083M0s3TVdRQllGTnlaZ2dpL2Iy?= =?utf-8?B?WnMwOFB0M0JYMEQvNkZsckhLMXM3d1gvTlZQcEl0VkJmbXJaZ1JINHBuQXJm?= =?utf-8?B?RnU2d0JqZTM1SUhseUlnUERxclZINWJXQ1VwNlN0MWhPRGRJZkN5SnpvOFpN?= =?utf-8?Q?mejY975zKoTj/r063Svjok3hF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f20fc56-805e-48b5-b60d-08db0bbdf1f0 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 23:24:24.0752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 15TEUbUvmLy+l9EXyRBEKnSvsQntVNA04IYRyBVRz0nKpIH0lfVb1BBmd0nVmRc+UIFdyAgymw3JrTPnS3o/LA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8252 Hi Michal, On 1/24/23 1:01 AM, Michal Orzel wrote: > Hi Vikram, > > You received extensive feedback for v3 from others, so I will limit my review to just coding > and general comments. > > On 07/12/2022 07:18, Vikram Garhwal wrote: >> >> Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using >> device tree overlay. >> >> xl dt_overlay remove file.dtbo: >> Removes all the nodes in a given dtbo. >> First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes >> in dt_host and delete the device node entries from dt_host. >> >> The nodes get removed only if it is not used by any of dom0 or domio. >> >> Also, added overlay_track struct to keep the track of added node through device >> tree overlay. overlay_track has dt_host_new which is unflattened form of updated >> fdt and name of overlay nodes. When a node is removed, we also free the memory >> used by overlay_track for the particular overlay node. >> >> Nested overlay removal is supported in sequential manner only i.e. if >> overlay_child nests under overlay_parent, it is assumed that user first removes >> overlay_child and then removes overlay_parent. >> >> Signed-off-by: Vikram Garhwal >> --- >> xen/common/Makefile | 1 + >> xen/common/dt_overlay.c | 411 +++++++++++++++++++++++++++++++++++ >> xen/common/sysctl.c | 5 + >> xen/include/public/sysctl.h | 19 ++ >> xen/include/xen/dt_overlay.h | 55 +++++ >> 5 files changed, 491 insertions(+) >> create mode 100644 xen/common/dt_overlay.c >> create mode 100644 xen/include/xen/dt_overlay.h >> >> diff --git a/xen/common/Makefile b/xen/common/Makefile >> index 3baf83d527..58a35f55b2 100644 >> --- a/xen/common/Makefile >> +++ b/xen/common/Makefile >> @@ -7,6 +7,7 @@ obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o >> obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o >> obj-$(CONFIG_IOREQ_SERVER) += dm.o >> obj-y += domain.o >> +obj-$(CONFIG_OVERLAY_DTB) += dt_overlay.o >> obj-y += event_2l.o >> obj-y += event_channel.o >> obj-y += event_fifo.o >> diff --git a/xen/common/dt_overlay.c b/xen/common/dt_overlay.c >> new file mode 100644 >> index 0000000000..477341f0aa >> --- /dev/null >> +++ b/xen/common/dt_overlay.c >> @@ -0,0 +1,411 @@ >> +/* >> + * xen/common/dt_overlay.c > New files should start with SPDX comment expressing license. > >> + * >> + * Device tree overlay support in Xen. >> + * >> + * Copyright (c) 2022 AMD Inc. >> + * Written by Vikram Garhwal >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms and conditions of the GNU General Public >> + * License, version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static LIST_HEAD(overlay_tracker); >> +static DEFINE_SPINLOCK(overlay_lock); >> + >> +/* Find last descendants of the device_node. */ >> +static struct dt_device_node *find_last_descendants_node( >> + struct dt_device_node *device_node) >> +{ >> + struct dt_device_node *child_node; >> + >> + for ( child_node = device_node->child; child_node->sibling != NULL; >> + child_node = child_node->sibling ) >> + { >> + } >> + >> + /* If last child_node also have children. */ >> + if ( child_node->child ) >> + child_node = find_last_descendants_node(child_node); > Please add a blank line here. > >> + return child_node; >> +} >> + >> +static int dt_overlay_remove_node(struct dt_device_node *device_node) >> +{ >> + struct dt_device_node *np; >> + struct dt_device_node *parent_node; >> + struct dt_device_node *device_node_last_descendant = device_node->child; >> + >> + parent_node = device_node->parent; >> + >> + if ( parent_node == NULL ) >> + { >> + dt_dprintk("%s's parent node not found\n", device_node->name); >> + return -EFAULT; >> + } >> + >> + np = parent_node->child; >> + >> + if ( np == NULL ) >> + { >> + dt_dprintk("parent node %s's not found\n", parent_node->name); >> + return -EFAULT; >> + } >> + >> + /* If node to be removed is only child node or first child. */ >> + if ( !dt_node_cmp(np->full_name, device_node->full_name) ) >> + { >> + parent_node->child = np->sibling; >> + >> + /* >> + * Iterate over all child nodes of device_node. Given that we are >> + * removing parent node, we need to remove all it's descendants too. >> + */ >> + if ( device_node_last_descendant ) >> + { >> + device_node_last_descendant = >> + find_last_descendants_node(device_node); >> + parent_node->allnext = device_node_last_descendant->allnext; >> + } >> + else >> + parent_node->allnext = np->allnext; >> + >> + return 0; >> + } >> + >> + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) >> + { >> + if ( !dt_node_cmp(np->sibling->full_name, device_node->full_name) ) >> + { >> + /* Found the node. Now we remove it. */ >> + np->sibling = np->sibling->sibling; >> + >> + if ( np->child ) >> + np = find_last_descendants_node(np); >> + >> + /* >> + * Iterate over all child nodes of device_node. Given that we are >> + * removing parent node, we need to remove all it's descendants too. >> + */ >> + if ( device_node_last_descendant ) >> + device_node_last_descendant = >> + find_last_descendants_node(device_node); >> + >> + if ( device_node_last_descendant ) >> + np->allnext = device_node_last_descendant->allnext; >> + else >> + np->allnext = np->allnext->allnext; >> + >> + break; >> + } >> + } >> + >> + return 0; >> +} >> + >> +/* Basic sanity check for the dtbo tool stack provided to Xen. */ >> +static int check_overlay_fdt(const void *overlay_fdt, uint32_t overlay_fdt_size) >> +{ >> + if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) || >> + fdt_check_header(overlay_fdt) ) >> + { >> + printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n"); >> + return -EINVAL; >> + } >> + >> + return 0; >> +} >> + >> +/* Count number of nodes till one level of __overlay__ tag. */ >> +static unsigned int overlay_node_count(void *fdto) >> +{ >> + unsigned int num_overlay_nodes = 0; >> + int fragment; >> + >> + fdt_for_each_subnode(fragment, fdto, 0) >> + { >> + int subnode; >> + int overlay; >> + >> + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); >> + >> + /* >> + * overlay value can be < 0. But fdt_for_each_subnode() loop checks for >> + * overlay >= 0. So, no need for a overlay>=0 check here. >> + */ >> + fdt_for_each_subnode(subnode, fdto, overlay) >> + { >> + num_overlay_nodes++; >> + } >> + } >> + >> + return num_overlay_nodes; >> +} >> + >> +static int handle_remove_irq_iommu(struct dt_device_node *device_node) >> +{ >> + int rc = 0; >> + struct domain *d = hardware_domain; >> + domid_t domid = 0; > No need for this assignment. > >> + unsigned int naddr, len; >> + unsigned int i, nirq; >> + u64 addr, size; > We should not be using types like these anymore. Use uint64_t. > >> + >> + domid = dt_device_used_by(device_node); >> + >> + dt_dprintk("Checking if node %s is used by any domain\n", >> + device_node->full_name); >> + >> + /* Remove the node iff it's assigned to domain 0 or domain io. */ >> + if ( domid != 0 && domid != DOMID_IO ) >> + { >> + printk(XENLOG_ERR "Device %s as it is being used by domain %d. Removing nodes failed\n", >> + device_node->full_name, domid); >> + return -EINVAL; >> + } >> + >> + dt_dprintk("Removing node: %s\n", device_node->full_name); >> + >> + nirq = dt_number_of_irq(device_node); >> + >> + /* Remove IRQ permission */ >> + for ( i = 0; i < nirq; i++ ) >> + { >> + rc = platform_get_irq(device_node, i);; >> + >> + if ( irq_access_permitted(d, rc) == false ) >> + { >> + printk(XENLOG_ERR "IRQ %d is not routed to domain %d\n", rc, >> + domid); >> + return -EINVAL; >> + } >> + /* >> + * TODO: We don't handle shared IRQs for now. So, it is assumed that >> + * the IRQs was not shared with another devices. >> + */ >> + rc = irq_deny_access(d, rc); >> + if ( rc ) >> + { >> + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", >> + i, device_node->full_name); >> + return rc; >> + } >> + } >> + >> + /* Check if iommu property exists. */ >> + if ( dt_get_property(device_node, "iommus", &len) ) >> + { >> + > Remove extra line. > >> + rc = iommu_remove_dt_device(device_node); >> + if ( rc != 0 && rc != -ENXIO ) >> + return rc; >> + } >> + >> + naddr = dt_number_of_address(device_node); >> + >> + /* Remove mmio access. */ >> + for ( i = 0; i < naddr; i++ ) >> + { >> + rc = dt_device_get_address(device_node, i, &addr, &size); >> + if ( rc ) >> + { >> + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", >> + i, dt_node_full_name(device_node)); >> + return rc; >> + } >> + >> + rc = iomem_deny_access(d, paddr_to_pfn(addr), >> + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); >> + if ( rc ) >> + { >> + printk(XENLOG_ERR "Unable to remove dom%d access to" >> + " 0x%"PRIx64" - 0x%"PRIx64"\n", >> + d->domain_id, >> + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); >> + return rc; >> + } > What about removing p2m mappings (comment from Julien on v3)? The main purpose of this series to address first part of dynamic programming i.e. making Xen aware of new device tree node which means updating the dt_host with overlay node information. Here we are adding/removing node from dt_host, and checking/set IOMMU and IRQ permission but never mapping them to any domain. Right now, mapping/Un-mapping will happen only when a new domU is created/destroyed using "xl create". To map IOREQ and IOMMU during runtime, there will be another small series after this one where we will do the actual IOMMU and IRQ mapping do a running domain and will call unmap_mmio_regions() to remove the mapping. Here is the patch for that series: https://github.com/Xilinx/xen/commit/76fcd5defc1c7c375cb99ac73a4d1138aa87d474 I will clean it and send once current series is done. Also, If you see addition part of this series, we put "skip_mapping = true" which means map_range_to_domain()->map_range_p2mt() is never called. The only thing function which will be called is iomem_permit_access() while adding the node and here we are calling opposite function to remove the access. Please let me know if my explanation is not clear. I addressed rest of your comments in next series. Regards, Vikram > >> + >> + } >> + >> + return rc; >> +} >> + >> +/* Removes all descendants of the given node. */ >> +static int remove_all_descendant_nodes(struct dt_device_node *device_node) >> +{ >> + int rc = 0; >> + struct dt_device_node *child_node; >> + >> + for ( child_node = device_node->child; child_node != NULL; >> + child_node = child_node->sibling ) >> + { >> + if ( child_node->child ) >> + remove_all_descendant_nodes(child_node); >> + >> + rc = handle_remove_irq_iommu(child_node); >> + if ( rc ) >> + return rc; >> + } >> + >> + return rc; >> +} >> + >> +/* Remove nodes from dt_host. */ >> +static int remove_nodes(const struct overlay_track *tracker) >> +{ >> + int rc = 0; >> + struct dt_device_node *overlay_node; >> + unsigned int j; >> + >> + for ( j = 0; j < tracker->num_nodes; j++ ) >> + { >> + overlay_node = (struct dt_device_node *)tracker->nodes_address[j]; >> + if ( overlay_node == NULL ) >> + { >> + printk(XENLOG_ERR "Device %s is not present in the tree. Removing nodes failed\n", >> + overlay_node->full_name); >> + return -EINVAL; >> + } >> + >> + rc = remove_all_descendant_nodes(overlay_node); >> + >> + /* All children nodes are unmapped. Now remove the node itself. */ >> + rc = handle_remove_irq_iommu(overlay_node); >> + if ( rc ) >> + return rc; >> + >> + read_lock(&dt_host->lock); >> + >> + rc = dt_overlay_remove_node(overlay_node); >> + if ( rc ) >> + { >> + read_unlock(&dt_host->lock); >> + >> + return rc; >> + } >> + >> + read_unlock(&dt_host->lock); >> + } >> + >> + return rc; >> +} >> + >> +/* >> + * First finds the device node to remove. Check if the device is being used by >> + * any dom and finally remove it from dt_host. IOMMU is already being taken care >> + * while destroying the domain. >> + */ >> +static long handle_remove_overlay_nodes(void *overlay_fdt, >> + uint32_t overlay_fdt_size) >> +{ >> + int rc = 0; >> + struct overlay_track *entry, *temp, *track; >> + bool found_entry = false; >> + >> + rc = check_overlay_fdt(overlay_fdt, overlay_fdt_size); >> + if ( rc ) >> + return rc; >> + >> + if ( overlay_node_count(overlay_fdt) == 0 ) >> + return -ENOMEM; >> + >> + spin_lock(&overlay_lock); >> + >> + /* >> + * First check if dtbo is correct i.e. it should one of the dtbo which was >> + * used when dynamically adding the node. >> + * Limitation: Cases with same node names but different property are not >> + * supported currently. We are relying on user to provide the same dtbo >> + * as it was used when adding the nodes. >> + */ >> + list_for_each_entry_safe( entry, temp, &overlay_tracker, entry ) >> + { >> + if ( memcmp(entry->overlay_fdt, overlay_fdt, overlay_fdt_size) == 0 ) >> + { >> + track = entry; >> + found_entry = true; >> + break; >> + } >> + } >> + >> + if ( found_entry == false ) >> + { >> + rc = -EINVAL; >> + >> + printk(XENLOG_ERR "Cannot find any matching tracker with input dtbo." >> + " Removing nodes is supported for only prior added dtbo. Please" >> + " provide a valid dtbo which was used to add the nodes.\n"); >> + goto out; >> + >> + } >> + >> + rc = remove_nodes(entry); >> + >> + if ( rc ) >> + { >> + printk(XENLOG_ERR "Removing node failed\n"); >> + goto out; >> + } >> + >> + list_del(&entry->entry); >> + >> + xfree(entry->dt_host_new); >> + xfree(entry->fdt); >> + xfree(entry->overlay_fdt); >> + >> + xfree(entry->nodes_address); >> + >> + xfree(entry); >> + >> +out: >> + spin_unlock(&overlay_lock); >> + return rc; >> +} >> + >> +long dt_sysctl(struct xen_sysctl_dt_overlay *op) >> +{ >> + long ret = 0; > No need for assignign a value that will be reassigned anyway. > >> + void *overlay_fdt; >> + >> + if ( op->overlay_fdt_size <= 0 || op->overlay_fdt_size > 500000 ) > FWICS, you want to limit the fdt size to 500KB which should be 512000. > Also, it would be clearer to use KB(500). Otherwise such value is a bit ambiguous. > Also overlay_fdt_size cannot be < 0. > >> + return -EINVAL; >> + >> + overlay_fdt = xmalloc_bytes(op->overlay_fdt_size); > If you alloc the bytes here and the op will not be XEN_SYSCTL_DT_OVERLAY_REMOVE, > then you will end up without freeing it. > >> + >> + if ( overlay_fdt == NULL ) >> + return -ENOMEM; >> + >> + ret = copy_from_guest(overlay_fdt, op->overlay_fdt, op->overlay_fdt_size); >> + if ( ret ) >> + { >> + gprintk(XENLOG_ERR, "copy from guest failed\n"); >> + xfree(overlay_fdt); >> + >> + return -EFAULT; >> + } >> + >> + switch ( op->overlay_op ) >> + { >> + case XEN_SYSCTL_DT_OVERLAY_REMOVE: >> + ret = handle_remove_overlay_nodes(overlay_fdt, op->overlay_fdt_size); >> + xfree(overlay_fdt); >> + >> + break; >> + >> + default: >> + break; >> + } >> + >> + return ret; >> +} > Don't you want to put EMACS comments block here? > >> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >> index 02505ab044..bb338b7c27 100644 >> --- a/xen/common/sysctl.c >> +++ b/xen/common/sysctl.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> >> long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) >> { >> @@ -482,6 +483,10 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) >> copyback = 1; >> break; >> >> + case XEN_SYSCTL_dt_overlay: > If you protect xen_sysctl_dt_overlay with ARM ifdefery as Jan suggested, > then you should move this handling to arch_do_sysctl. > >> + ret = dt_sysctl(&op->u.dt_overlay); >> + break; >> + >> default: >> ret = arch_do_sysctl(op, u_sysctl); >> copyback = 0; >> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h >> index 5672906729..4bc76bbe27 100644 >> --- a/xen/include/public/sysctl.h >> +++ b/xen/include/public/sysctl.h >> @@ -1079,6 +1079,23 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t; >> DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t); >> #endif >> >> +#define XEN_SYSCTL_DT_OVERLAY_ADD 1 > I'm not sure whether the ADD macro should be added in this patch. > >> +#define XEN_SYSCTL_DT_OVERLAY_REMOVE 2 >> + >> +/* >> + * XEN_SYSCTL_dt_overlay >> + * Performs addition/removal of device tree nodes under parent node using dtbo. >> + * This does in three steps: >> + * - Adds/Removes the nodes from dt_host. >> + * - Adds/Removes IRQ permission for the nodes. >> + * - Adds/Removes MMIO accesses. >> + */ >> +struct xen_sysctl_dt_overlay { >> + XEN_GUEST_HANDLE_64(void) overlay_fdt; > FWICS, this is the output variable and it would be beneficial to add a comment. > Also, usually IN variables appear first. > >> + uint32_t overlay_fdt_size; /* Overlay dtb size. */ >> + uint8_t overlay_op; /* Add or remove. */ > These are the input variables, so the comment should be e.g. /* IN: Overlay dtb size */ > >> +}; >> + >> struct xen_sysctl { >> uint32_t cmd; >> #define XEN_SYSCTL_readconsole 1 >> @@ -1109,6 +1126,7 @@ struct xen_sysctl { >> #define XEN_SYSCTL_livepatch_op 27 >> /* #define XEN_SYSCTL_set_parameter 28 */ >> #define XEN_SYSCTL_get_cpu_policy 29 >> +#define XEN_SYSCTL_dt_overlay 30 >> uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */ >> union { >> struct xen_sysctl_readconsole readconsole; >> @@ -1139,6 +1157,7 @@ struct xen_sysctl { >> #if defined(__i386__) || defined(__x86_64__) >> struct xen_sysctl_cpu_policy cpu_policy; >> #endif >> + struct xen_sysctl_dt_overlay dt_overlay; >> uint8_t pad[128]; >> } u; >> }; >> diff --git a/xen/include/xen/dt_overlay.h b/xen/include/xen/dt_overlay.h >> new file mode 100644 >> index 0000000000..30f4b86586 >> --- /dev/null >> +++ b/xen/include/xen/dt_overlay.h >> @@ -0,0 +1,55 @@ >> +/* > Missing SPDX comment at the top of the files. > >> + * xen/common/dt_overlay.h > Incorrect path. > >> + * >> + * Device tree overlay support in Xen. >> + * >> + * Copyright (c) 2022 AMD Inc. >> + * Written by Vikram Garhwal >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms and conditions of the GNU General Public >> + * License, version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#ifndef __XEN_DT_SYSCTL_H__ >> +#define __XEN_DT_SYSCTL_H__ >> + >> +#include >> +#include >> +#include >> +#include >> + >> +/* >> + * overlay_node_track describes information about added nodes through dtbo. >> + * @entry: List pointer. >> + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. >> + * @fdt: Stores the fdt. >> + * @nodes_fullname: Stores the full name of nodes. >> + * @nodes_irq: Stores the IRQ added from overlay dtb. >> + * @node_num_irq: Stores num of IRQ for each node in overlay dtb. >> + * @num_nodes: Stores total number of nodes in overlay dtb. >> + */ >> +struct overlay_track { >> + struct list_head entry; >> + struct dt_device_node *dt_host_new; >> + void *fdt; >> + void *overlay_fdt; >> + unsigned long *nodes_address; >> + unsigned int num_nodes; >> +}; >> + >> +struct xen_sysctl_dt_overlay; >> + >> +#ifdef CONFIG_OVERLAY_DTB >> +long dt_sysctl(struct xen_sysctl_dt_overlay *op); >> +#else >> +static inline long dt_sysctl(struct xen_sysctl_dt_overlay *op) >> +{ >> + return -ENOSYS; >> +} >> +#endif >> +#endif > Don't you want to put EMACS comments block here? > >> -- >> 2.17.1 >> >> > ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 10 23:28:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 23:28:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493680.763669 (Exim 4.92) (envelope-from ) id 1pQcoD-0007wk-6A; Fri, 10 Feb 2023 23:28:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493680.763669; Fri, 10 Feb 2023 23:28:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcoD-0007wd-3Y; Fri, 10 Feb 2023 23:28:01 +0000 Received: by outflank-mailman (input) for mailman id 493680; Fri, 10 Feb 2023 23:27:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQcoB-0007wX-KR for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 23:27:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cd7a883-a99a-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 00:27:57 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C07C9B82554; Fri, 10 Feb 2023 23:27:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA3ACC433EF; Fri, 10 Feb 2023 23:27:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cd7a883-a99a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676071675; bh=Y/eWYE1eQNJcUQc3hqpKZ3UVZm2vTYENq36azC8YBZE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=T8GBIEYF0NdmvAivcXXzcuzJTzhOLPHSuCzczQwROQ0rGGfzTACZaqsO5G/7p9thA UR+B0eSsuTUQh+ugz2pgNZrAB3aRE4JphK0yQCIMBTCp8KG3uwLFT9oxDTBGxmxSpx HmHX3g/VUgBmBqZlayK8Kg+K2byWzM9g2HAr05o1XN85yC/KQMtCaMPBsx5KT1y9ZJ cm4poAs3fy3dlLOAnfBXB4eb8bwQATYGBDkMpIA5jOtOK23jRt3NQWvAKvY2OaISxI PmawuZZ1s73sE6ThTXLnWNTMpapYHh1chXWpz4+J2LJ/xYaV6fU3g91OY561THBsga NsdMFX5BuUcFA== Date: Fri, 10 Feb 2023 15:27:52 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Chuck Zmudzinski cc: qemu-devel@nongnu.org, Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , xen-devel@lists.xenproject.org, qemu-stable@nongnu.org Subject: Re: [PATCH] xen/pt: fix igd passthrough for pc machine with xen accelerator In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 7 Feb 2023, Chuck Zmudzinski wrote: > Commit 998250e97661 ("xen, gfx passthrough: register host bridge specific > to passthrough") uses the igd-passthrough-i440FX pci host device with > the xenfv machine type and igd-passthru=on, but using it for the pc > machine type, xen accelerator, and igd-passtru=on was omitted from that > commit. > > The igd-passthru-i440FX pci host device is also needed for guests > configured with the pc machine type, the xen accelerator, and > igd-passthru=on. Specifically, tests show that not using the igd-specific > pci host device with the Intel igd passed through to the guest results > in slower startup performance and reduced resolution of the display > during startup. This patch fixes this issue. > > To simplify the logic that is needed to support both the --enable-xen > and the --disable-xen configure options, introduce the boolean symbol > pc_xen_igd_gfx_pt_enabled() whose value is set appropriately in the > sysemu/xen.h header file as the test to determine whether or not > to use the igd-passthrough-i440FX pci host device instead of the > normal i440FX pci host device. > > Fixes: 998250e97661 ("xen, gfx passthrough: register host bridge specific to passthrough") > Signed-off-by: Chuck Zmudzinski I think this is OK Acked-by: Stefano Stabellini > --- > This patch is intended to replace or complement a recently proposed > patch that modifies slot_reserved_mask for the xenfv machine with > igd-passthru=on in order to fix the problem of Qemu not reserving slot 2 > for the Intel IGD for the xenfv machine type. This patch provides a > simple way to improve Qemu support for the Intel IGD with the xen > accelerator without needing to change how slot_reserved_mask functions. > > For reference, the latest version of the patch to fix the xenfv machine > using slot_reserved_mask is at: > > https://lore.kernel.org/qemu-devel/b1b4a21fe9a600b1322742dda55a40e9961daa57.1674346505.git.brchuckz@aol.com/ > > Reason for introducing the new boolean pc_xen_igd_gfx_pt_enabled(): > > It is also possible to use xen_igd_gfx_pt_enabled() directly to check > if the igd-passthru-i440FX pci host device is needed in this patch, > but in that case it would be necessary to implement it in > accel/stubs/xen-stub.c like this: > > bool xen_igd_gfx_pt_enabled(void) > { > return false; > } > > to cover the case when Qemu is configured with --disable-xen. I thought > it was simpler to introduce the same boolean prefixed with pc_ and > set it to 0 when --disable-xen is the configure option, and that explains > why the proposed patch introduces pc_xen_igd_gfx_pt_enabled() instead of > using xen_igd_gfx_pt_enabled() directly. > > Another reason to use pc_xen_igd_gfx_pt_enabled() is to distinguish it > from xen_igd_gfx_pt_enabled() in hw/i386/pc_piix.c, because the use of > xen_igd_gfx_pt_enabled() is guarded by CONFIG_XEN but this patch needs > to place the boolean in a position that is not guarded by CONFIG_XEN. > This approach will simplify any future effort to move the code in > pc_piix.c that is not guarded by CONFIG_XEN to a xen-specific file. > > hw/i386/pc_piix.c | 2 ++ > include/sysemu/xen.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index df64dd8dcc..fd5b9ae1eb 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -433,6 +433,8 @@ static void pc_xen_hvm_init(MachineState *machine) > compat(machine); \ > } \ > pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, \ > + pc_xen_igd_gfx_pt_enabled() ? \ > + TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE : \ > TYPE_I440FX_PCI_DEVICE); \ > } \ > DEFINE_PC_MACHINE(suffix, name, pc_init_##suffix, optionfn) > diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h > index 0ca25697e4..99ae41e619 100644 > --- a/include/sysemu/xen.h > +++ b/include/sysemu/xen.h > @@ -23,6 +23,7 @@ > extern bool xen_allowed; > > #define xen_enabled() (xen_allowed) > +#define pc_xen_igd_gfx_pt_enabled() xen_igd_gfx_pt_enabled() > > #ifndef CONFIG_USER_ONLY > void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length); > @@ -33,6 +34,7 @@ void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, > #else /* !CONFIG_XEN_IS_POSSIBLE */ > > #define xen_enabled() 0 > +#define pc_xen_igd_gfx_pt_enabled() 0 > #ifndef CONFIG_USER_ONLY > static inline void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length) > { > -- > 2.39.1 > From xen-devel-bounces@lists.xenproject.org Fri Feb 10 23:33:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 10 Feb 2023 23:33:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493686.763681 (Exim 4.92) (envelope-from ) id 1pQct1-0000wE-O8; Fri, 10 Feb 2023 23:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493686.763681; Fri, 10 Feb 2023 23:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQct1-0000w7-Lc; Fri, 10 Feb 2023 23:32:59 +0000 Received: by outflank-mailman (input) for mailman id 493686; Fri, 10 Feb 2023 23:32:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQct0-0000w1-Dq for xen-devel@lists.xenproject.org; Fri, 10 Feb 2023 23:32:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f5e98d6-a99b-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 00:32:57 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4628261EB4; Fri, 10 Feb 2023 23:32:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB79C433D2; Fri, 10 Feb 2023 23:32:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f5e98d6-a99b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676071975; bh=viXOvaeCoLP52MV8gaJBodxikjoeBS1XcEbdT3P79ZA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IFc1Yh/BULyN7rXPWP8Bc15yRXRRsuJqwPyXLCCJU14Bz3DP6/QdM9qVC1NUNyTTu SzO4cZyepM86ffMRAFoUYAYM/Mu/qpBxBAbYgiLMHeP0PmnZGaVfcbBQnoagQLNY/t qNNd2vBvlXcAi32p6mA5QdttayEyN529liiP98+Uf1Xr9TQOuNScQRVCtMy0tYhdZH OVz+Hl4MtOO33J/Vq2Ni4cxuKJ+qhFFXEjhRx8q7Ic3PqoiXdm/glRznb964kpaY+J pDMdKndLnbTzlID8rIKsqz047ALFqqdNJgXEjPtMLP82xzXXFw+yDKU6tRWT0cQa9/ hxx/IH1E7j/xA== Date: Fri, 10 Feb 2023 15:32:53 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Oleksandr Tyshchenko cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Oleksandr Tyshchenko , Juergen Gross , Stefano Stabellini , Viresh Kumar Subject: Re: [PATCH] xen/grant-dma-iommu: Implement a dummy probe_device() callback In-Reply-To: <20230208153649.3604857-1-olekstysh@gmail.com> Message-ID: References: <20230208153649.3604857-1-olekstysh@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Update stub IOMMU driver (which main purpose is to reuse generic > IOMMU device-tree bindings by Xen grant DMA-mapping layer on Arm) > according to the recent changes done in the following > commit 57365a04c921 ("iommu: Move bus setup to IOMMU device registration"). > > With probe_device() callback being called during IOMMU device registration, > the uninitialized callback just leads to the "kernel NULL pointer > dereference" issue during boot. Fix that by adding a dummy callback. > > Looks like the release_device() callback is not mandatory to be > implemented as IOMMU framework makes sure that callback is initialized > before dereferencing. > > Reported-by: Viresh Kumar > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini > --- > drivers/xen/grant-dma-iommu.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/grant-dma-iommu.c b/drivers/xen/grant-dma-iommu.c > index 16b8bc0c0b33..6a9fe02c6bfc 100644 > --- a/drivers/xen/grant-dma-iommu.c > +++ b/drivers/xen/grant-dma-iommu.c > @@ -16,8 +16,15 @@ struct grant_dma_iommu_device { > struct iommu_device iommu; > }; > > -/* Nothing is really needed here */ > -static const struct iommu_ops grant_dma_iommu_ops; > +static struct iommu_device *grant_dma_iommu_probe_device(struct device *dev) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +/* Nothing is really needed here except a dummy probe_device callback */ > +static const struct iommu_ops grant_dma_iommu_ops = { > + .probe_device = grant_dma_iommu_probe_device, > +}; > > static const struct of_device_id grant_dma_iommu_of_match[] = { > { .compatible = "xen,grant-dma" }, > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:03:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:03:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493694.763692 (Exim 4.92) (envelope-from ) id 1pQdMa-0005Qn-UW; Sat, 11 Feb 2023 00:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493694.763692; Sat, 11 Feb 2023 00:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdMa-0005Qg-Rj; Sat, 11 Feb 2023 00:03:32 +0000 Received: by outflank-mailman (input) for mailman id 493694; Sat, 11 Feb 2023 00:03:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdMY-0005QW-NL; Sat, 11 Feb 2023 00:03:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdMY-0006XC-Jz; Sat, 11 Feb 2023 00:03:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdMY-0000m7-4p; Sat, 11 Feb 2023 00:03:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQdMY-0005Yt-49; Sat, 11 Feb 2023 00:03:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7Jb79gROf2++UtUlUzz5Krv3V8w/bONrzu8xR3/PNmI=; b=AzFlnw3WnuNgiA4PnZ7D++Zo5m iQUFAU6Co1AqlRUWjvUve+4K50cjFc3tyrzQWC8YkTrZJebQ/akby1W3zTPDIamY4Fdb5yG/tU+/1 UFz1/4IqCLK3tyxgEHvKH8x7UBNeV8oUXNoooDZaToXUJHnCp5IN0qcb09sv8B49WdQI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176855: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=4e0b4ccfc504f26187939068796295340ffd0e2f From: osstest service owner Date: Sat, 11 Feb 2023 00:03:30 +0000 flight 176855 xen-unstable real [real] flight 176902 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176855/ http://logs.test-lab.xenproject.org/osstest/logs/176902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 176769 Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 176902-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176769 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 4e0b4ccfc504f26187939068796295340ffd0e2f Last test of basis 176769 2023-02-09 18:40:48 Z 1 days Testing same since 176855 2023-02-10 12:17:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig George Dunlap Henry Wang Ian Jackson Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/shskt: Disable CET-SS on parts susceptible to fractured updates Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack Token". Architecturally, an event delivery which starts in CPL<3 and switches shadow stack will first validate the Supervisor Shadow Stack Token (setting the busy bit), then pushes CS/LIP/SSP. One example of this is an NMI interrupting Xen. Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/etc between setting the busy bit and completing the event injection renders the action non-restartable, because when it comes time to restart, the busy bit is found to be already set. This is far more easily encountered under virt, yet it is not the fault of the hypervisor, nor the fault of the guest kernel. The fault lies somewhere between the architectural specification, and the uarch behaviour. Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervisor shadow stacks are safe to use. Because of how Xen lays out its shadow stacks, fracturing is not expected to be a problem on native. Detect this case on boot and default to not using shstk if virtualised. Specifying `cet=shstk` on the command line will override this heuristic and enable shadow stacks irrespective. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit b4a23bf6293aadecfd03bf9e83974443e2eac9cb Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} We don't actually need ecx yet, but adding it in now will reduce the amount to which leaf 7 is out of order in a featureset. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 789ed08abb8f5e411cf06f6acb61c2d261f625da Author: Juergen Gross Date: Thu Feb 9 15:41:48 2023 +0100 docs: clarify xenstore permission documentation In docs/misc/xenstore.txt the description of the Xenstore node access permissions is missing one important aspect, which can be found only in the code or in the wiki [1]: The first permission entry is defining the owner of the node via the domid, and the access rights for all domains NOT having a dedicated permission entry. Make that aspect clear in the official documentation. [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions Reported-by: Edwin Török Signed-off-by: Juergen Gross Reviewed-by: Julien Grall commit d184b26db2b29b5f610b61c43580becd7a4057b1 Author: Juergen Gross Date: Thu Feb 9 15:23:57 2023 +0100 SUPPORT.md: update version to 4.18-unstable The current version is no longer 4.17-rc. Update it to "4.18-unstable". Signed-off-by: Juergen Gross Acked-by: Andrew Cooper commit e51d31f79edc10f8d622e7f5bf4b935af6d4618f Author: Andrew Cooper Date: Thu Feb 9 15:25:10 2023 +0000 tools/ocaml: Drop libxl and xentoollog bindings There are significant issues with these bindings (they segfault for starters) and their companion half in Xapi was deleted in 2018 https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d owing to there having been no development of these bindings since 2014. In the unlikely event that we'd want to reinstate them, they'd need reworking basically from scratch anyway. Signed-off-by: Andrew Cooper Acked-by: Christian Lindig commit bf652a50fb3bb3b1b3d93db6fb79bc28f978fe75 Author: Anthony PERARD Date: Thu Feb 9 16:14:48 2023 +0000 libs/util: Fix parallel build between flex/bison and CC rules flex/bison generate two targets, and when those targets are prerequisite of other rules they are considered independently by make. We can have a situation where the .c file is out-of-date but not the .h, git checkout for example. In this case, if a rule only have the .h file as prerequiste, make will procced and start to build the object. In parallel, another target can have the .c file as prerequisite and make will find out it need re-generating and do so, changing the .h at the same time. This parallel task breaks the first one. To avoid this scenario, we put both the header and the source as prerequisite for all object even if they only need the header. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 52493ec3e32a6e631b3ae3571db7ed41f10d9b06 Author: Anthony PERARD Date: Thu Feb 9 12:11:40 2023 +0000 libs/util: Remove unused headers in libxlu_pci.c libxlu_pci.c doesn't use any "xlu__cfg*()" functions and doesn't use any of the disk parsing functions "xlu__disk*()", so all those headers can be removed. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 5b46dd85d051ceecc2c00a0de27f03e571bff379 Author: Julien Grall Date: Fri Jan 27 18:55:46 2023 +0000 tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested-by: Henry Wang Reviewed-by: Juergen Gross commit 4e0e7a29d2fe318e4e60e77a56773b4d020ebc6a Author: Julien Grall Date: Thu Feb 9 17:07:28 2023 +0000 docs/process: branching-checklist: Clarify steps to add the branch in osstest The steps to add the new branch in osstest doesn't mention the change should be committed. Update the steps to clarify that. Take the opportunity to switch to use $v instead hardcoded version. Signed-off-by: Julien Grall Reviewed-by: Henry Wang commit 6a6ae4ac349ee31030d4fb3952f2c3b48e60d09f Author: Julien Grall Date: Thu Feb 9 17:07:13 2023 +0000 docs/process: branching-checklist: Remove reference to root The steps to generate the documentation for the new branch requires to ssh as root and then su to run with the user xendocs. The release technician may not (and should not) have access to root. So update the step to directly ssh as xendocs. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang commit f87a15f5cce5c76c3d8028b7129f3a1abf1d6b7d Author: Julien Grall Date: Thu Feb 9 17:04:41 2023 +0000 docs/process: branching-checklist: Remove reference to qemu-ijw.git Per [1], qemu-iwj.git was a clone of QEMU traditional on Ian's computer for tagging QEMU trad. The next section will provide tag for the official tree. So remove the section about qemu-ijw.git. [1] 25482.10006.140155.984629@chiark.greenend.org.uk Signed-off-by: Julien Grall Acked-by: George Dunlap Acked-by: Ian Jackson Reviewed-by: Henry Wang commit 5dbe775c2b622a9473ddb9492db63cc320d562c4 Author: Julien Grall Date: Thu Feb 9 17:04:30 2023 +0000 docs/process: branching-checklist: Use consistent indentation At the moment, branch-checklist.txt is using a mix of soft and hard tab. They are both meant to be represented using 8 characters. In Xen we tend to use 4-space softtab represented with 4 characters. So to avoid having to use a different editor configuration, switch all the indentation to 4-space softtab. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:09:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493707.763703 (Exim 4.92) (envelope-from ) id 1pQdRx-0006Jt-RB; Sat, 11 Feb 2023 00:09:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493707.763703; Sat, 11 Feb 2023 00:09:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdRx-0006Jm-Nt; Sat, 11 Feb 2023 00:09:05 +0000 Received: by outflank-mailman (input) for mailman id 493707; Sat, 11 Feb 2023 00:09:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdRx-0006Jg-2p for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:09:05 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a351711-a9a0-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 01:09:02 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 897D0B825C8; Sat, 11 Feb 2023 00:09:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78691C433D2; Sat, 11 Feb 2023 00:08:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a351711-a9a0-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676074140; bh=4xsS3cdAr9Zk4ShNP/Sq8ynINBtn61Cn4xIw2WIhYpE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eusabe4ZrKMeEBe3rmFphHRvreGYduruVz36ByHABxCsjxgzryP1uC03vEPXq3EtA 6oMhHN0RQiv/1SWGQpVcA+cPNZ6cVnVxGDhijVTDJLuhh2vNLULAH6S9Bx9SdL1k2N BE5KVdCDKi8VCnM2TozdGCllmiGZc95L4v86n2PRzj8WI3K+jq5JWAamFM9b35TfT5 RQJU8JMirm5GhpJUs1Tvg7YTSYTHSHnImejzE+dfn9aKkJgO0oa2uFYpPxwnGsjGaO l9wzD6NVsbSphR8V1zC8ihJvHncE49tb7BORnUOGtsmMIZDyD5ig7PxeC/o/VINZi6 7sPE4Y9lw3BQw== Date: Fri, 10 Feb 2023 16:08:55 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 2/9] xen/arm: Typecast the DT values into paddr_t In-Reply-To: <20230208120529.22313-3-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-3-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > In future, we wish to support 32 bit physical address. > However, the current dt and fdt functions can only read u64 values. > We wish to make the DT functions read u64 as well u32 values (depending > on the width of physical address). Also, we wish to detect if any > truncation has occurred (ie while reading u32 physical addresses from > u64 values read from DT). > > device_tree_get_reg() should now be able to return paddr_t. This is > invoked by various callers to get DT address and size. > > For fdt_get_mem_rsv(), we have introduced wrapper ie > fdt_get_mem_rsv_paddr() while will invoke fdt_get_mem_rsv() and translate > u64 to paddr_t. The reason being we cannot modify fdt_get_mem_rsv() as > it has been imported from external source. > > For dt_read_number(), we have also introduced a wrapper ie > dt_read_paddr() to read physical addresses. We chose not to modify the > original function as it been used in places where it needs to > specifically u64 values from dt (For eg dt_property_read_u64()). > > Xen prints an error when it detects a truncation (during typecast > between u64 and paddr_t). It is not possible to return an error in all > scenarios. So, it is user's responsibility to check the error logs. > > To detect truncation, we right shift physical address by > "PADDR_BITS - 1" and then if the resulting number is greater than 1, > we know that truncation has occurred and an appropriate error log is > printed. > > Signed-off-by: Ayan Kumar Halder I just wanted to record that aside from Jan's feedback, this patch looks good to me > --- > > Changes from > > v1 - 1. Dropped "[XEN v1 2/9] xen/arm: Define translate_dt_address_size() for the translation between u64 and paddr_t" and > "[XEN v1 4/9] xen/arm: Use translate_dt_address_size() to translate between device tree addr/size and paddr_t", instead > this approach achieves the same purpose. > > 2. No need to check for truncation while converting values from u64 to paddr_t. > > v2 - 1. Use "( (dt_start >> (PADDR_SHIFT - 1)) > 1 )" to detect truncation. > 2. Introduced libfdt_xen.h to implement fdt_get_mem_rsv_paddr > 3. Logged error messages in case truncation is detected. > > xen/arch/arm/bootfdt.c | 38 ++++++++++++++++----- > xen/arch/arm/domain_build.c | 2 +- > xen/arch/arm/include/asm/setup.h | 2 +- > xen/arch/arm/setup.c | 14 ++++---- > xen/arch/arm/smpboot.c | 2 +- > xen/include/xen/device_tree.h | 21 ++++++++++++ > xen/include/xen/libfdt/libfdt_xen.h | 52 +++++++++++++++++++++++++++++ > xen/include/xen/types.h | 2 ++ > 8 files changed, 115 insertions(+), 18 deletions(-) > create mode 100644 xen/include/xen/libfdt/libfdt_xen.h > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 0085c28d74..f63da3e831 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -53,10 +53,30 @@ static bool __init device_tree_node_compatible(const void *fdt, int node, > } > > void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > - u32 size_cells, u64 *start, u64 *size) > + u32 size_cells, paddr_t *start, paddr_t *size) > { > - *start = dt_next_cell(address_cells, cell); > - *size = dt_next_cell(size_cells, cell); > + u64 dt_start, dt_size; > + > + /* > + * dt_next_cell will return u64 whereas paddr_t may be u64 or u32. Thus, > + * there is an implicit cast from u64 to paddr_t. > + */ > + dt_start = dt_next_cell(address_cells, cell); > + dt_size = dt_next_cell(size_cells, cell); > + > + if ( (dt_start >> (PADDR_SHIFT - 1)) > 1 ) > + printk("Error: Physical address greater than max width supported\n"); > + > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) > + printk("Error: Physical size greater than max width supported\n"); > + > + /* > + * Note: It is user's responsibility to check for the error messages. > + * Xen will sliently truncate in case if the address/size is greater than > + * the max supported width. > + */ > + *start = dt_start; > + *size = dt_size; > } > > static int __init device_tree_get_meminfo(const void *fdt, int node, > @@ -326,7 +346,7 @@ static int __init process_chosen_node(const void *fdt, int node, > printk("linux,initrd-start property has invalid length %d\n", len); > return -EINVAL; > } > - start = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); > + start = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); > > prop = fdt_get_property(fdt, node, "linux,initrd-end", &len); > if ( !prop ) > @@ -339,7 +359,7 @@ static int __init process_chosen_node(const void *fdt, int node, > printk("linux,initrd-end property has invalid length %d\n", len); > return -EINVAL; > } > - end = dt_read_number((void *)&prop->data, dt_size_to_cells(len)); > + end = dt_read_paddr((void *)&prop->data, dt_size_to_cells(len)); > > if ( start >= end ) > { > @@ -594,9 +614,11 @@ static void __init early_print_info(void) > for ( i = 0; i < nr_rsvd; i++ ) > { > paddr_t s, e; > - if ( fdt_get_mem_rsv(device_tree_flattened, i, &s, &e) < 0 ) > + > + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &s, &e) < 0 ) > continue; > - /* fdt_get_mem_rsv returns length */ > + > + /* fdt_get_mem_rsv_paddr returns length */ > e += s; > printk(" RESVD[%u]: %"PRIpaddr" - %"PRIpaddr"\n", i, s, e); > } > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index a798e0b256..4d7e67560f 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -949,7 +949,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, > BUG_ON(!prop); > cells = (const __be32 *)prop->value; > device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); > - psize = dt_read_number(cells, size_cells); > + psize = dt_read_paddr(cells, size_cells); > if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) > { > printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index a926f30a2b..6105e5cae3 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -158,7 +158,7 @@ extern uint32_t hyp_traps_vector[]; > void init_traps(void); > > void device_tree_get_reg(const __be32 **cell, u32 address_cells, > - u32 size_cells, u64 *start, u64 *size); > + u32 size_cells, paddr_t *start, paddr_t *size); > > u32 device_tree_get_u32(const void *fdt, int node, > const char *prop_name, u32 dflt); > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 1f26f67b90..5ade20e6e7 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -29,7 +29,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -222,11 +222,11 @@ static void __init dt_unreserved_regions(paddr_t s, paddr_t e, > { > paddr_t r_s, r_e; > > - if ( fdt_get_mem_rsv(device_tree_flattened, i, &r_s, &r_e ) < 0 ) > + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, i, &r_s, &r_e ) < 0 ) > /* If we can't read it, pretend it doesn't exist... */ > continue; > > - r_e += r_s; /* fdt_get_mem_rsv returns length */ > + r_e += r_s; /* fdt_get_mem_rsv_paddr returns length */ > > if ( s < r_e && r_s < e ) > { > @@ -502,13 +502,13 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, > { > paddr_t mod_s, mod_e; > > - if ( fdt_get_mem_rsv(device_tree_flattened, > - i - mi->nr_mods, > - &mod_s, &mod_e ) < 0 ) > + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, > + i - mi->nr_mods, > + &mod_s, &mod_e ) < 0 ) > /* If we can't read it, pretend it doesn't exist... */ > continue; > > - /* fdt_get_mem_rsv returns length */ > + /* fdt_get_mem_rsv_paddr returns length */ > mod_e += mod_s; > > if ( s < mod_e && mod_s < e ) > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index 412ae22869..c15c177487 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -159,7 +159,7 @@ static void __init dt_smp_init_cpus(void) > continue; > } > > - addr = dt_read_number(prop, dt_n_addr_cells(cpu)); > + addr = dt_read_paddr(prop, dt_n_addr_cells(cpu)); > > hwid = addr; > if ( hwid != addr ) > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index a28937d12a..b61bac2931 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -244,6 +244,27 @@ static inline u64 dt_read_number(const __be32 *cell, int size) > return r; > } > > +/* Wrapper for dt_read_number() to return paddr_t (instead of u64) */ > +static inline paddr_t dt_read_paddr(const __be32 *cell, int size) > +{ > + u64 dt_r = 0; > + paddr_t r; > + > + dt_r = dt_read_number(cell, size); > + > + if ( (dt_r >> (PADDR_SHIFT - 1)) > 1 ) > + printk("Error: Physical address greater than max width supported\n"); > + > + /* > + * Note: It is user's responsibility to check for the error messages. > + * Xen will sliently truncate in case if the address/size is greater than > + * the max supported width. > + */ > + r = dt_r; > + > + return r; > +} > + > /* Helper to convert a number of cells to bytes */ > static inline int dt_cells_to_size(int size) > { > diff --git a/xen/include/xen/libfdt/libfdt_xen.h b/xen/include/xen/libfdt/libfdt_xen.h > new file mode 100644 > index 0000000000..a3196dd96c > --- /dev/null > +++ b/xen/include/xen/libfdt/libfdt_xen.h > @@ -0,0 +1,52 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * xen/include/xen/libfdt/libfdt_xen.h > + * > + * Wrapper functions for device tree. This helps to convert dt values > + * between u64 and paddr_t. > + * > + * Copyright (C) 2023, Advanced Micro Devices, Inc. All Rights Reserved. > + */ > + > +#ifndef LIBFDT_XEN_H > +#define LIBFDT_XEN_H > + > +#include > + > +inline int fdt_get_mem_rsv_paddr(const void *fdt, int n, > + paddr_t *address, > + paddr_t *size) > +{ > + uint64_t dt_addr; > + uint64_t dt_size; > + int ret = 0; > + > + ret = fdt_get_mem_rsv(fdt, n, &dt_addr, &dt_size); > + > + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical address greater than max width supported\n"); > + return -1; > + } > + > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical size greater than max width supported\n"); > + return -1; > + } > + > + *address = dt_addr; > + *size = dt_size; > + > + return ret; > +} > + > +#endif /* LIBFDT_XEN_H */ > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/include/xen/types.h b/xen/include/xen/types.h > index 6aba80500a..b7255c7c38 100644 > --- a/xen/include/xen/types.h > +++ b/xen/include/xen/types.h > @@ -71,4 +71,6 @@ typedef bool bool_t; > #define test_and_set_bool(b) xchg(&(b), true) > #define test_and_clear_bool(b) xchg(&(b), false) > > +#define PADDR_SHIFT PADDR_BITS > + > #endif /* __TYPES_H__ */ > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:14:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:14:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493713.763714 (Exim 4.92) (envelope-from ) id 1pQdX0-0007kk-F5; Sat, 11 Feb 2023 00:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493713.763714; Sat, 11 Feb 2023 00:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdX0-0007kd-Bh; Sat, 11 Feb 2023 00:14:18 +0000 Received: by outflank-mailman (input) for mailman id 493713; Sat, 11 Feb 2023 00:14:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdWz-0007kX-C6 for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:14:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04b49c98-a9a1-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 01:14:15 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 76A1CB825C8; Sat, 11 Feb 2023 00:14:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A549C433D2; Sat, 11 Feb 2023 00:14:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04b49c98-a9a1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676074453; bh=oLICUezsJFv9B6NEozeKz2bJezO2yt2sPo61krm6Xss=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rVaFdv7Mn3ji0CRFHyU6YRmefE3NgbAYVbrthmySZoK2PdNI8wQrOoVDETOR3nmnW NTAmcGHgiKnzPLnF11/eeWQ5krt52wyIRNTon3gPjGb4vgPIV0Rpg31JNRUH4QnVrv /vP06YRJeeYcVnWVhUvl7Xp/74M/i9tsXxo1g/zrUK7SjScG++FwWzbGZiwp/q2HoM 3ScTB4Phx0ZsNJJzK142MtpvIUHW3MXSGC7yPSuWl6jA0fYm3D7WlsK2AKaGdwQiEF Pw9gZE9UAz8LfJnjxl2bD6sok2Yg4X2DdGUU23xhGp0+Jlow/8AINf5408tWSuLUZC g4yeOBCsQJcFQ== Date: Fri, 10 Feb 2023 16:14:09 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t In-Reply-To: <20230208120529.22313-5-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-5-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > dt_device_get_address() can accept u64 only for address and size. > However, the address/size denotes physical addresses. Thus, they should > be represented by 'paddr_t'. > Consequently, we introduce a wrapper for dt_device_get_address() ie > dt_device_get_paddr() which accepts address/size as paddr_t and inturn > invokes dt_device_get_address() after converting address/size to u64. > > The reason for introducing doing this is that in future 'paddr_t' may > be defined as u32. Thus, we need an explicit wrapper to do the type > conversion and return an error in case of truncation. > > With this, callers now invoke dt_device_get_paddr(). > dt_device_get_address() is invoked by dt_device_get_paddr() only. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from - > > v1 - 1. New patch. > > v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" > into this patch. > > 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. > > 3. Logged error in case of truncation. > > xen/arch/arm/domain_build.c | 10 +++--- > xen/arch/arm/gic-v2.c | 10 +++--- > xen/arch/arm/gic-v3-its.c | 4 +-- > xen/arch/arm/gic-v3.c | 10 +++--- > xen/arch/arm/pci/pci-host-common.c | 6 ++-- > xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- > xen/arch/arm/platforms/brcm.c | 4 +-- > xen/arch/arm/platforms/exynos5.c | 32 +++++++++---------- > xen/arch/arm/platforms/sunxi.c | 2 +- > xen/arch/arm/platforms/xgene-storm.c | 2 +- > xen/common/device_tree.c | 36 ++++++++++++++++++++-- > xen/drivers/char/cadence-uart.c | 4 +-- > xen/drivers/char/exynos4210-uart.c | 4 +-- > xen/drivers/char/imx-lpuart.c | 4 +-- > xen/drivers/char/meson-uart.c | 4 +-- > xen/drivers/char/mvebu-uart.c | 4 +-- > xen/drivers/char/ns16550.c | 2 +- > xen/drivers/char/omap-uart.c | 4 +-- > xen/drivers/char/pl011.c | 6 ++-- > xen/drivers/char/scif-uart.c | 4 +-- > xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- > xen/drivers/passthrough/arm/smmu-v3.c | 2 +- > xen/drivers/passthrough/arm/smmu.c | 8 ++--- > xen/include/xen/device_tree.h | 6 ++-- > 24 files changed, 105 insertions(+), 73 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4d7e67560f..c7e88f5011 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1692,13 +1692,13 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > dt_for_each_device_node( dt_host, np ) > { > unsigned int naddr; > - u64 addr, size; > + paddr_t addr, size; > > naddr = dt_number_of_address(np); > > for ( i = 0; i < naddr; i++ ) > { > - res = dt_device_get_address(np, i, &addr, &size); > + res = dt_device_get_paddr(np, i, &addr, &size); > if ( res ) > { > printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > @@ -2471,7 +2471,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, > unsigned int naddr; > unsigned int i; > int res; > - u64 addr, size; > + paddr_t addr, size; > bool own_device = !dt_device_for_passthrough(dev); > /* > * We want to avoid mapping the MMIO in dom0 for the following cases: > @@ -2526,7 +2526,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, > /* Give permission and map MMIOs */ > for ( i = 0; i < naddr; i++ ) > { > - res = dt_device_get_address(dev, i, &addr, &size); > + res = dt_device_get_paddr(dev, i, &addr, &size); > if ( res ) > { > printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > @@ -2957,7 +2957,7 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, > if ( res ) > { > printk(XENLOG_ERR "Unable to permit to dom%d access to" > - " 0x%"PRIx64" - 0x%"PRIx64"\n", > + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", > kinfo->d->domain_id, > mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); > return res; > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index 5d4d298b86..6476ff4230 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -993,7 +993,7 @@ static void gicv2_extension_dt_init(const struct dt_device_node *node) > continue; > > /* Get register frame resource from DT. */ > - if ( dt_device_get_address(v2m, 0, &addr, &size) ) > + if ( dt_device_get_paddr(v2m, 0, &addr, &size) ) > panic("GICv2: Cannot find a valid v2m frame address\n"); > > /* > @@ -1018,19 +1018,19 @@ static void __init gicv2_dt_init(void) > paddr_t vsize; > const struct dt_device_node *node = gicv2_info.node; > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("GICv2: Cannot find a valid address for the distributor\n"); > > - res = dt_device_get_address(node, 1, &cbase, &csize); > + res = dt_device_get_paddr(node, 1, &cbase, &csize); > if ( res ) > panic("GICv2: Cannot find a valid address for the CPU\n"); > > - res = dt_device_get_address(node, 2, &hbase, NULL); > + res = dt_device_get_paddr(node, 2, &hbase, NULL); > if ( res ) > panic("GICv2: Cannot find a valid address for the hypervisor\n"); > > - res = dt_device_get_address(node, 3, &vbase, &vsize); > + res = dt_device_get_paddr(node, 3, &vbase, &vsize); > if ( res ) > panic("GICv2: Cannot find a valid address for the virtual CPU\n"); > > diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c > index 1ec9934191..3aa4edda10 100644 > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -1004,12 +1004,12 @@ static void gicv3_its_dt_init(const struct dt_device_node *node) > */ > dt_for_each_child_node(node, its) > { > - uint64_t addr, size; > + paddr_t addr, size; > > if ( !dt_device_is_compatible(its, "arm,gic-v3-its") ) > continue; > > - if ( dt_device_get_address(its, 0, &addr, &size) ) > + if ( dt_device_get_paddr(its, 0, &addr, &size) ) > panic("GICv3: Cannot find a valid ITS frame address\n"); > > add_to_host_its_list(addr, size, its); > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index bb59ea94cd..4e6c98bada 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -1377,7 +1377,7 @@ static void __init gicv3_dt_init(void) > int res, i; > const struct dt_device_node *node = gicv3_info.node; > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("GICv3: Cannot find a valid distributor address\n"); > > @@ -1393,9 +1393,9 @@ static void __init gicv3_dt_init(void) > > for ( i = 0; i < gicv3.rdist_count; i++ ) > { > - uint64_t rdist_base, rdist_size; > + paddr_t rdist_base, rdist_size; > > - res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size); > + res = dt_device_get_paddr(node, 1 + i, &rdist_base, &rdist_size); > if ( res ) > panic("GICv3: No rdist base found for region %d\n", i); > > @@ -1417,10 +1417,10 @@ static void __init gicv3_dt_init(void) > * For GICv3 supporting GICv2, GICC and GICV base address will be > * provided. > */ > - res = dt_device_get_address(node, 1 + gicv3.rdist_count, > + res = dt_device_get_paddr(node, 1 + gicv3.rdist_count, > &cbase, &csize); > if ( !res ) > - dt_device_get_address(node, 1 + gicv3.rdist_count + 2, > + dt_device_get_paddr(node, 1 + gicv3.rdist_count + 2, > &vbase, &vsize); > } > > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index a8ece94303..5550f9478d 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -93,7 +93,7 @@ gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops) > cfg_reg_idx = 0; > > /* Parse our PCI ecam register address */ > - err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size); > + err = dt_device_get_paddr(dev, cfg_reg_idx, &addr, &size); > if ( err ) > goto err_exit; > > @@ -349,10 +349,10 @@ int __init pci_host_bridge_mappings(struct domain *d) > > for ( i = 0; i < dt_number_of_address(dev); i++ ) > { > - uint64_t addr, size; > + paddr_t addr, size; > int err; > > - err = dt_device_get_address(dev, i, &addr, &size); > + err = dt_device_get_paddr(dev, i, &addr, &size); > if ( err ) > { > printk(XENLOG_ERR > diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c > index 811b40b1a6..407ec07f63 100644 > --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c > +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c > @@ -64,7 +64,7 @@ static void __iomem *rpi4_map_watchdog(void) > if ( !node ) > return NULL; > > - ret = dt_device_get_address(node, 0, &start, &len); > + ret = dt_device_get_paddr(node, 0, &start, &len); > if ( ret ) > { > printk("Cannot read watchdog register address\n"); > diff --git a/xen/arch/arm/platforms/brcm.c b/xen/arch/arm/platforms/brcm.c > index d481b2c60f..4310feee73 100644 > --- a/xen/arch/arm/platforms/brcm.c > +++ b/xen/arch/arm/platforms/brcm.c > @@ -40,7 +40,7 @@ static __init int brcm_get_dt_node(char *compat_str, > u32 *reg_base) > { > const struct dt_device_node *node; > - u64 reg_base_64; > + paddr_t reg_base_64; > int rc; > > node = dt_find_compatible_node(NULL, NULL, compat_str); > @@ -50,7 +50,7 @@ static __init int brcm_get_dt_node(char *compat_str, > return -ENOENT; > } > > - rc = dt_device_get_address(node, 0, ®_base_64, NULL); > + rc = dt_device_get_paddr(node, 0, ®_base_64, NULL); > if ( rc ) > { > dprintk(XENLOG_ERR, "%s: missing \"reg\" prop\n", __func__); > diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c > index 6560507092..c48093cd4f 100644 > --- a/xen/arch/arm/platforms/exynos5.c > +++ b/xen/arch/arm/platforms/exynos5.c > @@ -42,8 +42,8 @@ static int exynos5_init_time(void) > void __iomem *mct; > int rc; > struct dt_device_node *node; > - u64 mct_base_addr; > - u64 size; > + paddr_t mct_base_addr; > + paddr_t size; > > node = dt_find_compatible_node(NULL, NULL, "samsung,exynos4210-mct"); > if ( !node ) > @@ -52,14 +52,14 @@ static int exynos5_init_time(void) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, &mct_base_addr, &size); > + rc = dt_device_get_paddr(node, 0, &mct_base_addr, &size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in \"samsung,exynos4210-mct\"\n"); > return -ENXIO; > } > > - dprintk(XENLOG_INFO, "mct_base_addr: %016llx size: %016llx\n", > + dprintk(XENLOG_INFO, "mct_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", > mct_base_addr, size); > > mct = ioremap_nocache(mct_base_addr, size); > @@ -97,9 +97,9 @@ static int __init exynos5_smp_init(void) > struct dt_device_node *node; > void __iomem *sysram; > char *compatible; > - u64 sysram_addr; > - u64 size; > - u64 sysram_offset; > + paddr_t sysram_addr; > + paddr_t size; > + paddr_t sysram_offset; > int rc; > > node = dt_find_compatible_node(NULL, NULL, "samsung,secure-firmware"); > @@ -125,13 +125,13 @@ static int __init exynos5_smp_init(void) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, &sysram_addr, &size); > + rc = dt_device_get_paddr(node, 0, &sysram_addr, &size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in %s\n", compatible); > return -ENXIO; > } > - dprintk(XENLOG_INFO, "sysram_addr: %016llx size: %016llx offset: %016llx\n", > + dprintk(XENLOG_INFO,"sysram_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"offset: 0x%"PRIpaddr"\n", > sysram_addr, size, sysram_offset); > > sysram = ioremap_nocache(sysram_addr, size); > @@ -189,7 +189,7 @@ static int exynos5_cpu_power_up(void __iomem *power, int cpu) > return 0; > } > > -static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > +static int exynos5_get_pmu_baseandsize(paddr_t *power_base_addr, paddr_t *size) > { > struct dt_device_node *node; > int rc; > @@ -208,14 +208,14 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, power_base_addr, size); > + rc = dt_device_get_paddr(node, 0, power_base_addr, size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in \"samsung,exynos5XXX-pmu\"\n"); > return -ENXIO; > } > > - dprintk(XENLOG_DEBUG, "power_base_addr: %016llx size: %016llx\n", > + dprintk(XENLOG_DEBUG, "power_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", > *power_base_addr, *size); > > return 0; > @@ -223,8 +223,8 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > > static int exynos5_cpu_up(int cpu) > { > - u64 power_base_addr; > - u64 size; > + paddr_t power_base_addr; > + paddr_t size; > void __iomem *power; > int rc; > > @@ -256,8 +256,8 @@ static int exynos5_cpu_up(int cpu) > > static void exynos5_reset(void) > { > - u64 power_base_addr; > - u64 size; > + paddr_t power_base_addr; > + paddr_t size; > void __iomem *pmu; > int rc; > > diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c > index e8e4d88bef..2b2c215f20 100644 > --- a/xen/arch/arm/platforms/sunxi.c > +++ b/xen/arch/arm/platforms/sunxi.c > @@ -50,7 +50,7 @@ static void __iomem *sunxi_map_watchdog(bool *new_wdt) > return NULL; > } > > - ret = dt_device_get_address(node, 0, &wdt_start, &wdt_len); > + ret = dt_device_get_paddr(node, 0, &wdt_start, &wdt_len); > if ( ret ) > { > dprintk(XENLOG_ERR, "Cannot read watchdog register address\n"); > diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c > index befd0c3c2d..6fc2f9679e 100644 > --- a/xen/arch/arm/platforms/xgene-storm.c > +++ b/xen/arch/arm/platforms/xgene-storm.c > @@ -50,7 +50,7 @@ static void __init xgene_check_pirq_eoi(void) > if ( !node ) > panic("%s: Can not find interrupt controller node\n", __func__); > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("%s: Cannot find a valid address for the distributor\n", __func__); > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 6c9712ab7b..d0f19d5cfc 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -934,8 +934,9 @@ bail: > } > > /* dt_device_address - Translate device tree address and return it */ > -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > - u64 *addr, u64 *size) > +static int dt_device_get_address(const struct dt_device_node *dev, > + unsigned int index, > + u64 *addr, u64 *size) > { > const __be32 *addrp; > unsigned int flags; > @@ -955,6 +956,37 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > return 0; > } > > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size) > +{ > + u64 dt_addr = 0, dt_size = 0; > + int ret; > + > + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); Here we should have: if ( ret != 0 ) return ret; > + if ( addr ) > + { > + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) If we are going to update the way this check is written in patch #2, please also update it here... > + { > + printk("Error: Physical address greater than max width supported\n"); > + return -EINVAL; > + } > + > + *addr = dt_addr; > + } > + > + if ( size ) > + { > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) ... and here In any case this patch looks good to me > + { > + printk("Error: Physical size greater than max width supported\n"); > + return -EINVAL; > + } > + *size = dt_size; > + } > + > + return ret; > +} > > int dt_for_each_range(const struct dt_device_node *dev, > int (*cb)(const struct dt_device_node *, > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uart.c > index 22905ba66c..c38d7ed143 100644 > --- a/xen/drivers/char/cadence-uart.c > +++ b/xen/drivers/char/cadence-uart.c > @@ -158,14 +158,14 @@ static int __init cuart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct cuart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &cuart_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("cadence: Unable to retrieve the base" > diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c > index 43aaf02e18..2503392ccd 100644 > --- a/xen/drivers/char/exynos4210-uart.c > +++ b/xen/drivers/char/exynos4210-uart.c > @@ -303,7 +303,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, > const char *config = data; > struct exynos4210_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -316,7 +316,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, > uart->parity = PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("exynos4210: Unable to retrieve the base" > diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c > index 9c1f3b71a3..77f70c2719 100644 > --- a/xen/drivers/char/imx-lpuart.c > +++ b/xen/drivers/char/imx-lpuart.c > @@ -204,7 +204,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, > const char *config = data; > struct imx_lpuart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -216,7 +216,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, > uart->parity = 0; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("imx8-lpuart: Unable to retrieve the base" > diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c > index b1e25e0468..c627328122 100644 > --- a/xen/drivers/char/meson-uart.c > +++ b/xen/drivers/char/meson-uart.c > @@ -209,14 +209,14 @@ static int __init meson_uart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct meson_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &meson_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("meson: Unable to retrieve the base address of the UART\n"); > diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c > index a00618b96f..cc55173513 100644 > --- a/xen/drivers/char/mvebu-uart.c > +++ b/xen/drivers/char/mvebu-uart.c > @@ -231,14 +231,14 @@ static int __init mvebu_uart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct mvebu3700_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &mvebu3700_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("mvebu3700: Unable to retrieve the base address of the UART\n"); > diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > index 2aee5642f9..9a5e26a8d2 100644 > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1769,7 +1769,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, > uart->parity = UART_PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &uart->io_base, &uart->io_size); > + res = dt_device_get_paddr(dev, 0, &uart->io_base, &uart->io_size); > if ( res ) > return res; > > diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c > index d6a5d59aa2..8e643cb039 100644 > --- a/xen/drivers/char/omap-uart.c > +++ b/xen/drivers/char/omap-uart.c > @@ -324,7 +324,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, > struct omap_uart *uart; > u32 clkspec; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -344,7 +344,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, > uart->parity = UART_PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("omap-uart: Unable to retrieve the base" > diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c > index be67242bc0..052a651251 100644 > --- a/xen/drivers/char/pl011.c > +++ b/xen/drivers/char/pl011.c > @@ -222,7 +222,7 @@ static struct uart_driver __read_mostly pl011_driver = { > .vuart_info = pl011_vuart, > }; > > -static int __init pl011_uart_init(int irq, u64 addr, u64 size, bool sbsa) > +static int __init pl011_uart_init(int irq, paddr_t addr, paddr_t size, bool sbsa) > { > struct pl011 *uart; > > @@ -258,14 +258,14 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev, > { > const char *config = data; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > { > printk("WARNING: UART configuration is not supported\n"); > } > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("pl011: Unable to retrieve the base" > diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c > index 2fccafe340..1b28ba90e9 100644 > --- a/xen/drivers/char/scif-uart.c > +++ b/xen/drivers/char/scif-uart.c > @@ -311,14 +311,14 @@ static int __init scif_uart_init(struct dt_device_node *dev, > const char *config = data; > struct scif_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &scif_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("scif-uart: Unable to retrieve the base" > diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > index 091f09b217..611d9eeba5 100644 > --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c > +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > @@ -794,7 +794,7 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu) > static __init bool ipmmu_stage2_supported(void) > { > struct dt_device_node *np; > - uint64_t addr, size; > + paddr_t addr, size; > void __iomem *base; > uint32_t product, cut; > bool stage2_supported = false; > @@ -806,7 +806,7 @@ static __init bool ipmmu_stage2_supported(void) > return false; > } > > - if ( dt_device_get_address(np, 0, &addr, &size) ) > + if ( dt_device_get_paddr(np, 0, &addr, &size) ) > { > printk(XENLOG_ERR "ipmmu: Failed to get PRR MMIO\n"); > return false; > @@ -884,7 +884,7 @@ static int ipmmu_probe(struct dt_device_node *node) > { > const struct dt_device_match *match; > struct ipmmu_vmsa_device *mmu; > - uint64_t addr, size; > + paddr_t addr, size; > uint32_t reg; > int irq, ret; > > @@ -905,7 +905,7 @@ static int ipmmu_probe(struct dt_device_node *node) > bitmap_zero(mmu->ctx, IPMMU_CTX_MAX); > > /* Map I/O memory and request IRQ. */ > - ret = dt_device_get_address(node, 0, &addr, &size); > + ret = dt_device_get_paddr(node, 0, &addr, &size); > if ( ret ) > { > dev_err(&node->dev, "Failed to get MMIO\n"); > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index d58c5cd0bf..79d20eed20 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -2451,7 +2451,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > } > > /* Base address */ > - ret = dt_device_get_address(dev_to_dt(pdev), 0, &ioaddr, &iosize); > + ret = dt_device_get_paddr(dev_to_dt(pdev), 0, &ioaddr, &iosize); > if (ret) > goto out_free_smmu; > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index 0a514821b3..79281075ba 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -73,8 +73,8 @@ > /* Xen: Helpers to get device MMIO and IRQs */ > struct resource > { > - u64 addr; > - u64 size; > + paddr_t addr; > + paddr_t size; > unsigned int type; > }; > > @@ -101,7 +101,7 @@ static struct resource *platform_get_resource(struct platform_device *pdev, > > switch (type) { > case IORESOURCE_MEM: > - ret = dt_device_get_address(pdev, num, &res.addr, &res.size); > + ret = dt_device_get_paddr(pdev, num, &res.addr, &res.size); > > return ((ret) ? NULL : &res); > > @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, > ptr = ioremap_nocache(res->addr, res->size); > if (!ptr) { > dev_err(dev, > - "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", > + "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", > res->addr, res->size); > return ERR_PTR(-ENOMEM); > } > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index b61bac2931..04aa43e0ee 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -583,7 +583,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, > const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); > > /** > - * dt_device_get_address - Resolve an address for a device > + * dt_device_get_paddr - Resolve an address for a device > * @device: the device whose address is to be resolved > * @index: index of the address to resolve > * @addr: address filled by this function > @@ -592,8 +592,8 @@ const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); > * This function resolves an address, walking the tree, for a give > * device-tree node. It returns 0 on success. > */ > -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > - u64 *addr, u64 *size); > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size); > > /** > * dt_number_of_irq - Get the number of IRQ for a device > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:20:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:20:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493723.763728 (Exim 4.92) (envelope-from ) id 1pQdcm-00011A-AG; Sat, 11 Feb 2023 00:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493723.763728; Sat, 11 Feb 2023 00:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdcm-000113-6X; Sat, 11 Feb 2023 00:20:16 +0000 Received: by outflank-mailman (input) for mailman id 493723; Sat, 11 Feb 2023 00:20:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdck-00010x-Ao for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:20:14 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d975dc83-a9a1-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 01:20:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89F15B8261F; Sat, 11 Feb 2023 00:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41FDAC433D2; Sat, 11 Feb 2023 00:20:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d975dc83-a9a1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676074810; bh=CvRQE9mI+c60oRT291r19E64f3jKbyg3PTbUuM7VsOE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sWgXnx6ktOUa5KRZdpy0ysegt8p8vp3QmnoXl1T4CB0jI2TJIW10ERPP5St2jmMat it7eHCzT2DXPhjKSWOU+NvtYq8w287opoI0Teim/FCV7g9UO/HImQkHIhxajKw/Uyi 6MgTwyz4DtHNp16N91gmYewOZHHcLLrkkSRzn5x3H180/0/7sO2prSN9jUZNJzEGVF +QWw9DoXF+UUdW2ICFEf2D/g2oGzaE9E1afsqyA2ATycCzR+5FPjpDEf91QPw9nBK/ jsFelUFEBmkUowTRo84Lhdphw3l/VCymIXQv7uVRi/b9q7Di2LmkJZfm+Iherf6f+W 54lxX8Iysqxnw== Date: Fri, 10 Feb 2023 16:20:06 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t In-Reply-To: <20230208120529.22313-5-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-5-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > dt_device_get_address() can accept u64 only for address and size. > However, the address/size denotes physical addresses. Thus, they should > be represented by 'paddr_t'. > Consequently, we introduce a wrapper for dt_device_get_address() ie > dt_device_get_paddr() which accepts address/size as paddr_t and inturn > invokes dt_device_get_address() after converting address/size to u64. > > The reason for introducing doing this is that in future 'paddr_t' may > be defined as u32. Thus, we need an explicit wrapper to do the type > conversion and return an error in case of truncation. > > With this, callers now invoke dt_device_get_paddr(). > dt_device_get_address() is invoked by dt_device_get_paddr() only. > > Signed-off-by: Ayan Kumar Halder > --- > Changes from - > > v1 - 1. New patch. > > v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" > into this patch. > > 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. > > 3. Logged error in case of truncation. > > xen/arch/arm/domain_build.c | 10 +++--- > xen/arch/arm/gic-v2.c | 10 +++--- > xen/arch/arm/gic-v3-its.c | 4 +-- > xen/arch/arm/gic-v3.c | 10 +++--- > xen/arch/arm/pci/pci-host-common.c | 6 ++-- > xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- > xen/arch/arm/platforms/brcm.c | 4 +-- > xen/arch/arm/platforms/exynos5.c | 32 +++++++++---------- > xen/arch/arm/platforms/sunxi.c | 2 +- > xen/arch/arm/platforms/xgene-storm.c | 2 +- > xen/common/device_tree.c | 36 ++++++++++++++++++++-- > xen/drivers/char/cadence-uart.c | 4 +-- > xen/drivers/char/exynos4210-uart.c | 4 +-- > xen/drivers/char/imx-lpuart.c | 4 +-- > xen/drivers/char/meson-uart.c | 4 +-- > xen/drivers/char/mvebu-uart.c | 4 +-- > xen/drivers/char/ns16550.c | 2 +- > xen/drivers/char/omap-uart.c | 4 +-- > xen/drivers/char/pl011.c | 6 ++-- > xen/drivers/char/scif-uart.c | 4 +-- > xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- > xen/drivers/passthrough/arm/smmu-v3.c | 2 +- > xen/drivers/passthrough/arm/smmu.c | 8 ++--- > xen/include/xen/device_tree.h | 6 ++-- > 24 files changed, 105 insertions(+), 73 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 4d7e67560f..c7e88f5011 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1692,13 +1692,13 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > dt_for_each_device_node( dt_host, np ) > { > unsigned int naddr; > - u64 addr, size; > + paddr_t addr, size; > > naddr = dt_number_of_address(np); > > for ( i = 0; i < naddr; i++ ) > { > - res = dt_device_get_address(np, i, &addr, &size); > + res = dt_device_get_paddr(np, i, &addr, &size); One thing to be careful here is that "start" and "end" in find_memory_holes are defined now as paddr_t and passed to rangeset_add_range and rangeset_remove_range. rangeset_add_range and rangeset_remove_range take an unsigned long as parameter, so in an arm32 configuration with paddr_t set to 64-bit it would result in truncation > if ( res ) > { > printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > @@ -2471,7 +2471,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, > unsigned int naddr; > unsigned int i; > int res; > - u64 addr, size; > + paddr_t addr, size; > bool own_device = !dt_device_for_passthrough(dev); > /* > * We want to avoid mapping the MMIO in dom0 for the following cases: > @@ -2526,7 +2526,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev, > /* Give permission and map MMIOs */ > for ( i = 0; i < naddr; i++ ) > { > - res = dt_device_get_address(dev, i, &addr, &size); > + res = dt_device_get_paddr(dev, i, &addr, &size); > if ( res ) > { > printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", > @@ -2957,7 +2957,7 @@ static int __init handle_passthrough_prop(struct kernel_info *kinfo, > if ( res ) > { > printk(XENLOG_ERR "Unable to permit to dom%d access to" > - " 0x%"PRIx64" - 0x%"PRIx64"\n", > + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", > kinfo->d->domain_id, > mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); > return res; > diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c > index 5d4d298b86..6476ff4230 100644 > --- a/xen/arch/arm/gic-v2.c > +++ b/xen/arch/arm/gic-v2.c > @@ -993,7 +993,7 @@ static void gicv2_extension_dt_init(const struct dt_device_node *node) > continue; > > /* Get register frame resource from DT. */ > - if ( dt_device_get_address(v2m, 0, &addr, &size) ) > + if ( dt_device_get_paddr(v2m, 0, &addr, &size) ) > panic("GICv2: Cannot find a valid v2m frame address\n"); > > /* > @@ -1018,19 +1018,19 @@ static void __init gicv2_dt_init(void) > paddr_t vsize; > const struct dt_device_node *node = gicv2_info.node; > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("GICv2: Cannot find a valid address for the distributor\n"); > > - res = dt_device_get_address(node, 1, &cbase, &csize); > + res = dt_device_get_paddr(node, 1, &cbase, &csize); > if ( res ) > panic("GICv2: Cannot find a valid address for the CPU\n"); > > - res = dt_device_get_address(node, 2, &hbase, NULL); > + res = dt_device_get_paddr(node, 2, &hbase, NULL); > if ( res ) > panic("GICv2: Cannot find a valid address for the hypervisor\n"); > > - res = dt_device_get_address(node, 3, &vbase, &vsize); > + res = dt_device_get_paddr(node, 3, &vbase, &vsize); > if ( res ) > panic("GICv2: Cannot find a valid address for the virtual CPU\n"); > > diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c > index 1ec9934191..3aa4edda10 100644 > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -1004,12 +1004,12 @@ static void gicv3_its_dt_init(const struct dt_device_node *node) > */ > dt_for_each_child_node(node, its) > { > - uint64_t addr, size; > + paddr_t addr, size; > > if ( !dt_device_is_compatible(its, "arm,gic-v3-its") ) > continue; > > - if ( dt_device_get_address(its, 0, &addr, &size) ) > + if ( dt_device_get_paddr(its, 0, &addr, &size) ) > panic("GICv3: Cannot find a valid ITS frame address\n"); > > add_to_host_its_list(addr, size, its); > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c > index bb59ea94cd..4e6c98bada 100644 > --- a/xen/arch/arm/gic-v3.c > +++ b/xen/arch/arm/gic-v3.c > @@ -1377,7 +1377,7 @@ static void __init gicv3_dt_init(void) > int res, i; > const struct dt_device_node *node = gicv3_info.node; > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("GICv3: Cannot find a valid distributor address\n"); > > @@ -1393,9 +1393,9 @@ static void __init gicv3_dt_init(void) > > for ( i = 0; i < gicv3.rdist_count; i++ ) > { > - uint64_t rdist_base, rdist_size; > + paddr_t rdist_base, rdist_size; > > - res = dt_device_get_address(node, 1 + i, &rdist_base, &rdist_size); > + res = dt_device_get_paddr(node, 1 + i, &rdist_base, &rdist_size); > if ( res ) > panic("GICv3: No rdist base found for region %d\n", i); > > @@ -1417,10 +1417,10 @@ static void __init gicv3_dt_init(void) > * For GICv3 supporting GICv2, GICC and GICV base address will be > * provided. > */ > - res = dt_device_get_address(node, 1 + gicv3.rdist_count, > + res = dt_device_get_paddr(node, 1 + gicv3.rdist_count, > &cbase, &csize); > if ( !res ) > - dt_device_get_address(node, 1 + gicv3.rdist_count + 2, > + dt_device_get_paddr(node, 1 + gicv3.rdist_count + 2, > &vbase, &vsize); > } > > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > index a8ece94303..5550f9478d 100644 > --- a/xen/arch/arm/pci/pci-host-common.c > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -93,7 +93,7 @@ gen_pci_init(struct dt_device_node *dev, const struct pci_ecam_ops *ops) > cfg_reg_idx = 0; > > /* Parse our PCI ecam register address */ > - err = dt_device_get_address(dev, cfg_reg_idx, &addr, &size); > + err = dt_device_get_paddr(dev, cfg_reg_idx, &addr, &size); > if ( err ) > goto err_exit; > > @@ -349,10 +349,10 @@ int __init pci_host_bridge_mappings(struct domain *d) > > for ( i = 0; i < dt_number_of_address(dev); i++ ) > { > - uint64_t addr, size; > + paddr_t addr, size; > int err; > > - err = dt_device_get_address(dev, i, &addr, &size); > + err = dt_device_get_paddr(dev, i, &addr, &size); > if ( err ) > { > printk(XENLOG_ERR > diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c > index 811b40b1a6..407ec07f63 100644 > --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c > +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c > @@ -64,7 +64,7 @@ static void __iomem *rpi4_map_watchdog(void) > if ( !node ) > return NULL; > > - ret = dt_device_get_address(node, 0, &start, &len); > + ret = dt_device_get_paddr(node, 0, &start, &len); > if ( ret ) > { > printk("Cannot read watchdog register address\n"); > diff --git a/xen/arch/arm/platforms/brcm.c b/xen/arch/arm/platforms/brcm.c > index d481b2c60f..4310feee73 100644 > --- a/xen/arch/arm/platforms/brcm.c > +++ b/xen/arch/arm/platforms/brcm.c > @@ -40,7 +40,7 @@ static __init int brcm_get_dt_node(char *compat_str, > u32 *reg_base) > { > const struct dt_device_node *node; > - u64 reg_base_64; > + paddr_t reg_base_64; > int rc; > > node = dt_find_compatible_node(NULL, NULL, compat_str); > @@ -50,7 +50,7 @@ static __init int brcm_get_dt_node(char *compat_str, > return -ENOENT; > } > > - rc = dt_device_get_address(node, 0, ®_base_64, NULL); > + rc = dt_device_get_paddr(node, 0, ®_base_64, NULL); > if ( rc ) > { > dprintk(XENLOG_ERR, "%s: missing \"reg\" prop\n", __func__); > diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c > index 6560507092..c48093cd4f 100644 > --- a/xen/arch/arm/platforms/exynos5.c > +++ b/xen/arch/arm/platforms/exynos5.c > @@ -42,8 +42,8 @@ static int exynos5_init_time(void) > void __iomem *mct; > int rc; > struct dt_device_node *node; > - u64 mct_base_addr; > - u64 size; > + paddr_t mct_base_addr; > + paddr_t size; > > node = dt_find_compatible_node(NULL, NULL, "samsung,exynos4210-mct"); > if ( !node ) > @@ -52,14 +52,14 @@ static int exynos5_init_time(void) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, &mct_base_addr, &size); > + rc = dt_device_get_paddr(node, 0, &mct_base_addr, &size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in \"samsung,exynos4210-mct\"\n"); > return -ENXIO; > } > > - dprintk(XENLOG_INFO, "mct_base_addr: %016llx size: %016llx\n", > + dprintk(XENLOG_INFO, "mct_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", > mct_base_addr, size); > > mct = ioremap_nocache(mct_base_addr, size); > @@ -97,9 +97,9 @@ static int __init exynos5_smp_init(void) > struct dt_device_node *node; > void __iomem *sysram; > char *compatible; > - u64 sysram_addr; > - u64 size; > - u64 sysram_offset; > + paddr_t sysram_addr; > + paddr_t size; > + paddr_t sysram_offset; > int rc; > > node = dt_find_compatible_node(NULL, NULL, "samsung,secure-firmware"); > @@ -125,13 +125,13 @@ static int __init exynos5_smp_init(void) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, &sysram_addr, &size); > + rc = dt_device_get_paddr(node, 0, &sysram_addr, &size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in %s\n", compatible); > return -ENXIO; > } > - dprintk(XENLOG_INFO, "sysram_addr: %016llx size: %016llx offset: %016llx\n", > + dprintk(XENLOG_INFO,"sysram_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"offset: 0x%"PRIpaddr"\n", > sysram_addr, size, sysram_offset); > > sysram = ioremap_nocache(sysram_addr, size); > @@ -189,7 +189,7 @@ static int exynos5_cpu_power_up(void __iomem *power, int cpu) > return 0; > } > > -static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > +static int exynos5_get_pmu_baseandsize(paddr_t *power_base_addr, paddr_t *size) > { > struct dt_device_node *node; > int rc; > @@ -208,14 +208,14 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > return -ENXIO; > } > > - rc = dt_device_get_address(node, 0, power_base_addr, size); > + rc = dt_device_get_paddr(node, 0, power_base_addr, size); > if ( rc ) > { > dprintk(XENLOG_ERR, "Error in \"samsung,exynos5XXX-pmu\"\n"); > return -ENXIO; > } > > - dprintk(XENLOG_DEBUG, "power_base_addr: %016llx size: %016llx\n", > + dprintk(XENLOG_DEBUG, "power_base_addr: 0x%"PRIpaddr" size: 0x%"PRIpaddr"\n", > *power_base_addr, *size); > > return 0; > @@ -223,8 +223,8 @@ static int exynos5_get_pmu_baseandsize(u64 *power_base_addr, u64 *size) > > static int exynos5_cpu_up(int cpu) > { > - u64 power_base_addr; > - u64 size; > + paddr_t power_base_addr; > + paddr_t size; > void __iomem *power; > int rc; > > @@ -256,8 +256,8 @@ static int exynos5_cpu_up(int cpu) > > static void exynos5_reset(void) > { > - u64 power_base_addr; > - u64 size; > + paddr_t power_base_addr; > + paddr_t size; > void __iomem *pmu; > int rc; > > diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c > index e8e4d88bef..2b2c215f20 100644 > --- a/xen/arch/arm/platforms/sunxi.c > +++ b/xen/arch/arm/platforms/sunxi.c > @@ -50,7 +50,7 @@ static void __iomem *sunxi_map_watchdog(bool *new_wdt) > return NULL; > } > > - ret = dt_device_get_address(node, 0, &wdt_start, &wdt_len); > + ret = dt_device_get_paddr(node, 0, &wdt_start, &wdt_len); > if ( ret ) > { > dprintk(XENLOG_ERR, "Cannot read watchdog register address\n"); > diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c > index befd0c3c2d..6fc2f9679e 100644 > --- a/xen/arch/arm/platforms/xgene-storm.c > +++ b/xen/arch/arm/platforms/xgene-storm.c > @@ -50,7 +50,7 @@ static void __init xgene_check_pirq_eoi(void) > if ( !node ) > panic("%s: Can not find interrupt controller node\n", __func__); > > - res = dt_device_get_address(node, 0, &dbase, NULL); > + res = dt_device_get_paddr(node, 0, &dbase, NULL); > if ( res ) > panic("%s: Cannot find a valid address for the distributor\n", __func__); > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 6c9712ab7b..d0f19d5cfc 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -934,8 +934,9 @@ bail: > } > > /* dt_device_address - Translate device tree address and return it */ > -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > - u64 *addr, u64 *size) > +static int dt_device_get_address(const struct dt_device_node *dev, > + unsigned int index, > + u64 *addr, u64 *size) > { > const __be32 *addrp; > unsigned int flags; > @@ -955,6 +956,37 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > return 0; > } > > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size) > +{ > + u64 dt_addr = 0, dt_size = 0; > + int ret; > + > + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); > + > + if ( addr ) > + { > + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical address greater than max width supported\n"); > + return -EINVAL; > + } > + > + *addr = dt_addr; > + } > + > + if ( size ) > + { > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical size greater than max width supported\n"); > + return -EINVAL; > + } > + *size = dt_size; > + } > + > + return ret; > +} > > int dt_for_each_range(const struct dt_device_node *dev, > int (*cb)(const struct dt_device_node *, > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uart.c > index 22905ba66c..c38d7ed143 100644 > --- a/xen/drivers/char/cadence-uart.c > +++ b/xen/drivers/char/cadence-uart.c > @@ -158,14 +158,14 @@ static int __init cuart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct cuart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &cuart_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("cadence: Unable to retrieve the base" > diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c > index 43aaf02e18..2503392ccd 100644 > --- a/xen/drivers/char/exynos4210-uart.c > +++ b/xen/drivers/char/exynos4210-uart.c > @@ -303,7 +303,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, > const char *config = data; > struct exynos4210_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -316,7 +316,7 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, > uart->parity = PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("exynos4210: Unable to retrieve the base" > diff --git a/xen/drivers/char/imx-lpuart.c b/xen/drivers/char/imx-lpuart.c > index 9c1f3b71a3..77f70c2719 100644 > --- a/xen/drivers/char/imx-lpuart.c > +++ b/xen/drivers/char/imx-lpuart.c > @@ -204,7 +204,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, > const char *config = data; > struct imx_lpuart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -216,7 +216,7 @@ static int __init imx_lpuart_init(struct dt_device_node *dev, > uart->parity = 0; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("imx8-lpuart: Unable to retrieve the base" > diff --git a/xen/drivers/char/meson-uart.c b/xen/drivers/char/meson-uart.c > index b1e25e0468..c627328122 100644 > --- a/xen/drivers/char/meson-uart.c > +++ b/xen/drivers/char/meson-uart.c > @@ -209,14 +209,14 @@ static int __init meson_uart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct meson_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &meson_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("meson: Unable to retrieve the base address of the UART\n"); > diff --git a/xen/drivers/char/mvebu-uart.c b/xen/drivers/char/mvebu-uart.c > index a00618b96f..cc55173513 100644 > --- a/xen/drivers/char/mvebu-uart.c > +++ b/xen/drivers/char/mvebu-uart.c > @@ -231,14 +231,14 @@ static int __init mvebu_uart_init(struct dt_device_node *dev, const void *data) > const char *config = data; > struct mvebu3700_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &mvebu3700_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("mvebu3700: Unable to retrieve the base address of the UART\n"); > diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > index 2aee5642f9..9a5e26a8d2 100644 > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1769,7 +1769,7 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, > uart->parity = UART_PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &uart->io_base, &uart->io_size); > + res = dt_device_get_paddr(dev, 0, &uart->io_base, &uart->io_size); > if ( res ) > return res; > > diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c > index d6a5d59aa2..8e643cb039 100644 > --- a/xen/drivers/char/omap-uart.c > +++ b/xen/drivers/char/omap-uart.c > @@ -324,7 +324,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, > struct omap_uart *uart; > u32 clkspec; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > @@ -344,7 +344,7 @@ static int __init omap_uart_init(struct dt_device_node *dev, > uart->parity = UART_PARITY_NONE; > uart->stop_bits = 1; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("omap-uart: Unable to retrieve the base" > diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c > index be67242bc0..052a651251 100644 > --- a/xen/drivers/char/pl011.c > +++ b/xen/drivers/char/pl011.c > @@ -222,7 +222,7 @@ static struct uart_driver __read_mostly pl011_driver = { > .vuart_info = pl011_vuart, > }; > > -static int __init pl011_uart_init(int irq, u64 addr, u64 size, bool sbsa) > +static int __init pl011_uart_init(int irq, paddr_t addr, paddr_t size, bool sbsa) > { > struct pl011 *uart; > > @@ -258,14 +258,14 @@ static int __init pl011_dt_uart_init(struct dt_device_node *dev, > { > const char *config = data; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > { > printk("WARNING: UART configuration is not supported\n"); > } > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("pl011: Unable to retrieve the base" > diff --git a/xen/drivers/char/scif-uart.c b/xen/drivers/char/scif-uart.c > index 2fccafe340..1b28ba90e9 100644 > --- a/xen/drivers/char/scif-uart.c > +++ b/xen/drivers/char/scif-uart.c > @@ -311,14 +311,14 @@ static int __init scif_uart_init(struct dt_device_node *dev, > const char *config = data; > struct scif_uart *uart; > int res; > - u64 addr, size; > + paddr_t addr, size; > > if ( strcmp(config, "") ) > printk("WARNING: UART configuration is not supported\n"); > > uart = &scif_com; > > - res = dt_device_get_address(dev, 0, &addr, &size); > + res = dt_device_get_paddr(dev, 0, &addr, &size); > if ( res ) > { > printk("scif-uart: Unable to retrieve the base" > diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > index 091f09b217..611d9eeba5 100644 > --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c > +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c > @@ -794,7 +794,7 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu) > static __init bool ipmmu_stage2_supported(void) > { > struct dt_device_node *np; > - uint64_t addr, size; > + paddr_t addr, size; > void __iomem *base; > uint32_t product, cut; > bool stage2_supported = false; > @@ -806,7 +806,7 @@ static __init bool ipmmu_stage2_supported(void) > return false; > } > > - if ( dt_device_get_address(np, 0, &addr, &size) ) > + if ( dt_device_get_paddr(np, 0, &addr, &size) ) > { > printk(XENLOG_ERR "ipmmu: Failed to get PRR MMIO\n"); > return false; > @@ -884,7 +884,7 @@ static int ipmmu_probe(struct dt_device_node *node) > { > const struct dt_device_match *match; > struct ipmmu_vmsa_device *mmu; > - uint64_t addr, size; > + paddr_t addr, size; > uint32_t reg; > int irq, ret; > > @@ -905,7 +905,7 @@ static int ipmmu_probe(struct dt_device_node *node) > bitmap_zero(mmu->ctx, IPMMU_CTX_MAX); > > /* Map I/O memory and request IRQ. */ > - ret = dt_device_get_address(node, 0, &addr, &size); > + ret = dt_device_get_paddr(node, 0, &addr, &size); > if ( ret ) > { > dev_err(&node->dev, "Failed to get MMIO\n"); > diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c > index d58c5cd0bf..79d20eed20 100644 > --- a/xen/drivers/passthrough/arm/smmu-v3.c > +++ b/xen/drivers/passthrough/arm/smmu-v3.c > @@ -2451,7 +2451,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > } > > /* Base address */ > - ret = dt_device_get_address(dev_to_dt(pdev), 0, &ioaddr, &iosize); > + ret = dt_device_get_paddr(dev_to_dt(pdev), 0, &ioaddr, &iosize); > if (ret) > goto out_free_smmu; > > diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c > index 0a514821b3..79281075ba 100644 > --- a/xen/drivers/passthrough/arm/smmu.c > +++ b/xen/drivers/passthrough/arm/smmu.c > @@ -73,8 +73,8 @@ > /* Xen: Helpers to get device MMIO and IRQs */ > struct resource > { > - u64 addr; > - u64 size; > + paddr_t addr; > + paddr_t size; > unsigned int type; > }; > > @@ -101,7 +101,7 @@ static struct resource *platform_get_resource(struct platform_device *pdev, > > switch (type) { > case IORESOURCE_MEM: > - ret = dt_device_get_address(pdev, num, &res.addr, &res.size); > + ret = dt_device_get_paddr(pdev, num, &res.addr, &res.size); > > return ((ret) ? NULL : &res); > > @@ -169,7 +169,7 @@ static void __iomem *devm_ioremap_resource(struct device *dev, > ptr = ioremap_nocache(res->addr, res->size); > if (!ptr) { > dev_err(dev, > - "ioremap failed (addr 0x%"PRIx64" size 0x%"PRIx64")\n", > + "ioremap failed (addr 0x%"PRIpaddr" size 0x%"PRIpaddr")\n", > res->addr, res->size); > return ERR_PTR(-ENOMEM); > } > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index b61bac2931..04aa43e0ee 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -583,7 +583,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, > const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); > > /** > - * dt_device_get_address - Resolve an address for a device > + * dt_device_get_paddr - Resolve an address for a device > * @device: the device whose address is to be resolved > * @index: index of the address to resolve > * @addr: address filled by this function > @@ -592,8 +592,8 @@ const struct dt_device_node *dt_get_parent(const struct dt_device_node *node); > * This function resolves an address, walking the tree, for a give > * device-tree node. It returns 0 on success. > */ > -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > - u64 *addr, u64 *size); > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size); > > /** > * dt_number_of_irq - Get the number of IRQ for a device > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:34:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:34:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493731.763739 (Exim 4.92) (envelope-from ) id 1pQdqH-0002pI-Jl; Sat, 11 Feb 2023 00:34:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493731.763739; Sat, 11 Feb 2023 00:34:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdqH-0002pB-GE; Sat, 11 Feb 2023 00:34:13 +0000 Received: by outflank-mailman (input) for mailman id 493731; Sat, 11 Feb 2023 00:34:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdqF-0002p5-HB for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:34:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb8a988c-a9a3-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 01:34:09 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CD9D61EE4; Sat, 11 Feb 2023 00:34:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34040C433EF; Sat, 11 Feb 2023 00:34:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb8a988c-a9a3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676075646; bh=fowtCkN0OB1OoqfanJ+GUfswAR2zenTwMqMgokzSFKw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cpJOldqrTc0q9FhjsVJvn2VtIfHwa7wNzGnLam67Y1Y4/xGcwUwu0DNIpcD7G1950 gcNwS1R46+lmqwd2Ux5jNJibYNeM+zFT9pIsXBbs1UWRiBw7dBYb4P4HWg5SBS5hos ZsywC1qk6FOsc9FyPMDutpsLksPqLTbXAFTUcNgiJ/iNgruI/CZ53uM4Y4U03xTC/P nOxMyPqb3anZO0ZROMvos0lhKPckD0xwVZ6f3w3KSukGhOCSQ1yRlkkeeAVyq3fUjE ByrwcS3N186dTw5y6eYD2zvngkEkJm4j4tr7N8X/2AkSjL1iAkkyFHBocvTERBzcmy yUZqfCjFD3u+A== Date: Fri, 10 Feb 2023 16:34:03 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 6/9] xen/arm: Introduce choice to enable 64/32 bit physical addressing In-Reply-To: <20230208120529.22313-7-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-7-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > Some Arm based hardware platforms which does not support LPAE > (eg Cortex-R52), uses 32 bit physical addresses. > Also, users may choose to use 32 bits to represent physical addresses > for optimization. > > To support the above use cases, we have introduced arch independent > configs to choose if the physical address can be represented using > 32 bits (PHYS_ADDR_32) or 64 bits (PHYS_ADDR_64). > For now only ARM_32 provides support to enable 32 bit physical > addressing. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from - > v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". > > v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 only whereas > ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. > 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. > > (Jan,Julien please let me know if I understood your suggestion about Kconfig correctly). > > xen/arch/Kconfig | 12 +++++++++++ > xen/arch/arm/Kconfig | 31 ++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/page-bits.h | 2 ++ > xen/arch/arm/include/asm/types.h | 6 ++++++ > 4 files changed, 51 insertions(+) > > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index 7028f7b74f..1eff312b51 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -1,6 +1,18 @@ > config 64BIT > bool > > +config PHYS_ADDR_32 > + bool > + help > + Select this option if the physical addresses can be represented by > + 32 bits. > + > +config PHYS_ADDR_64 > + bool > + help > + Select this option if the physical addresses can be represented > + 64 bits. These two config symbols should be defined in xen/arch/arm/Kconfig (unless you plan to also define them for x86). > config NR_CPUS > int "Maximum number of CPUs" > range 1 4095 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 239d3aed3c..0955891e86 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -18,6 +18,37 @@ config ARM > select HAS_PDX > select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > + choice This shows up at the very beginning of the global menu. I think it would be better to move it under "Architecture Features" Also given that there is not choice on arm64, I don't think the choice option should be visible to the user (because the user cannot change selection for arm64). > + bool "Representative width for any physical address (default 64bit)" > + optional should not be "optional", optional means that neither ARM_PA_64 nor ARM_PA_32 could be selected. I think we want one of the two to always be selected, ARM_PA_64 being the default option, and the only option on arm64. > + ---help--- > + You may want to specify the width to represent the physical > + address space. > + By default, the physical addresses are represented using > + 64 bits. > + > + However in certain platforms, the physical addresses may be > + represented using 32 bits. > + Also, the user may decide that the physical addresses can be > + represented using 32 bits for a given SoC. In those cases, > + user may want to enable 32 bit physical address for > + optimization. > + For now, we have enabled this choice for ARM_32 only. > + > + config ARM_PA_64 > + select PHYS_ADDR_64 > + bool "Select 64 bits to represent physical address" > + ---help--- > + Use 64 bits to represent physical address. > + > + config ARM_PA_32 > + select PHYS_ADDR_32 > + depends on ARM_32 > + bool "Select 32 bits to represent physical address" > + ---help--- > + Use 32 bits to represent physical address. > + > + endchoice > > config ARCH_DEFCONFIG > string > diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h > index 5d6477e599..8f4dcebcfd 100644 > --- a/xen/arch/arm/include/asm/page-bits.h > +++ b/xen/arch/arm/include/asm/page-bits.h > @@ -5,6 +5,8 @@ > > #ifdef CONFIG_ARM_64 > #define PADDR_BITS 48 > +#elif CONFIG_ARM_PA_32 > +#define PADDR_BITS 32 > #else > #define PADDR_BITS 40 > #endif > diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h > index e218ed77bd..26144bc87e 100644 > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -34,9 +34,15 @@ typedef signed long long s64; > typedef unsigned long long u64; > typedef u32 vaddr_t; > #define PRIvaddr PRIx32 > +#if defined(CONFIG_ARM_PA_32) > +typedef unsigned long paddr_t; > +#define INVALID_PADDR (~0UL) > +#define PRIpaddr "08lx" > +#else > typedef u64 paddr_t; > #define INVALID_PADDR (~0ULL) > #define PRIpaddr "016llx" > +#endif > typedef u32 register_t; > #define PRIregister "08x" > #elif defined (CONFIG_ARM_64) > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:35:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493737.763749 (Exim 4.92) (envelope-from ) id 1pQdrC-0003Li-TJ; Sat, 11 Feb 2023 00:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493737.763749; Sat, 11 Feb 2023 00:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdrC-0003Lb-QV; Sat, 11 Feb 2023 00:35:10 +0000 Received: by outflank-mailman (input) for mailman id 493737; Sat, 11 Feb 2023 00:35:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdrB-0003LN-Ja for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:35:09 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eea33dd6-a9a3-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 01:35:07 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 36BC3B825B6; Sat, 11 Feb 2023 00:35:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FDC6C433EF; Sat, 11 Feb 2023 00:35:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eea33dd6-a9a3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676075705; bh=uau6Q8yjbCes0epO1WxHdWSk8LWiToScWHNk9jAsh7w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=U1E2d7/nHlvdb48npqoxgDRB8IQgXyjdedNjdA6eaRPS3P7alZ9Ijgmmym/eLUCg5 ZGsfP0qnLpWDK3j1WcpJoP1BG/oGSEpahjYIDh5UG4vZAcRvU/qR5NfdGXpAdSSNn5 gftn8cVdBnyZryuCknOumyK4RVZr+TcY0ku2mJqQH+WTDfjVi6qDerF/Q5x9M+MxbF diU2O9zIZuoIhUMOtwl7whpqLOyod3mu2oyKDqgbaghuGW80sRFPoLN1m5dQKLkZGt dfDeUqdlS95SQD6XsCfCV2rAfzYNym3jlDhJK6zHCF6Dinvm1AyTU4fMsI7oVBvrUS HAVDXRVT6L4BQ== Date: Fri, 10 Feb 2023 16:35:02 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 7/9] xen/arm: guest_walk: LPAE specific bits should be enclosed within "ifndef CONFIG_ARM_PA_32" In-Reply-To: <20230208120529.22313-8-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-8-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > In the subsequent patch, we introduce "CONFIG_ARM_PA_32" to support > 32 bit physical addresses. Thus, the code specific to > "Large Physical Address Extension" (ie LPAE) should be enclosed within > "ifndef CONFIG_ARM_PA_32". this statement needs an update > Refer xen/arch/arm/include/asm/short-desc.h, "short_desc_l1_supersec_t" > unsigned int extbase1:4; /* Extended base address, PA[35:32] */ > unsigned int extbase2:4; /* Extended base address, PA[39:36] */ > > Thus, extbase1 and extbase2 are not valid when 32 bit physical addresses > are supported. > > Signed-off-by: Ayan Kumar Halder Aside from the above: Acked-by: Stefano Stabellini > --- > > Changes from - > v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". > > v2 - 1. Reordered this patch so that it appears after CONFIG_ARM_PA_32 is > introduced (in 6/9). > > xen/arch/arm/guest_walk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c > index 43d3215304..0feb7b76ec 100644 > --- a/xen/arch/arm/guest_walk.c > +++ b/xen/arch/arm/guest_walk.c > @@ -154,8 +154,10 @@ static bool guest_walk_sd(const struct vcpu *v, > mask = (1ULL << L1DESC_SUPERSECTION_SHIFT) - 1; > *ipa = gva & mask; > *ipa |= (paddr_t)(pte.supersec.base) << L1DESC_SUPERSECTION_SHIFT; > +#ifndef CONFIG_ARM_PA_32 > *ipa |= (paddr_t)(pte.supersec.extbase1) << L1DESC_SUPERSECTION_EXT_BASE1_SHIFT; > *ipa |= (paddr_t)(pte.supersec.extbase2) << L1DESC_SUPERSECTION_EXT_BASE2_SHIFT; > +#endif /* CONFIG_ARM_PA_32 */ > } > > /* Set permissions so that the caller can check the flags by herself. */ > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:39:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493744.763761 (Exim 4.92) (envelope-from ) id 1pQdut-0004Cj-Cl; Sat, 11 Feb 2023 00:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493744.763761; Sat, 11 Feb 2023 00:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdut-0004Cc-A1; Sat, 11 Feb 2023 00:38:59 +0000 Received: by outflank-mailman (input) for mailman id 493744; Sat, 11 Feb 2023 00:38:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdus-0004CW-60 for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:38:58 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 771d8018-a9a4-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 01:38:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F278ACE2A08; Sat, 11 Feb 2023 00:38:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C29E0C433EF; Sat, 11 Feb 2023 00:38:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 771d8018-a9a4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676075930; bh=xK+uegO2hwQc+JAe7itgKZBCr5RFCqTsE4BtQojh/OM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=s1d43aqrPWFZLWzTyh2ks3kV0OWRMerJQCG2TJPQC5af79yjfCreN+5Uihm7ABE/O Em/kivdVlFIXwh0TpUbiI3jkIxy9iJ1UZhGbNm7iJk6DkPkIt5bBGnlM/hf5ioOskH 6+1EgXpZ3V/lQBFDmnt0GGSiKxzSG/Ug5Yn4fjiCem5eYAlFJ1G7oqsMCwFzWPHNq7 ePZZpx0NwUKqjnpCU9wWXf9TYw4NoxqlTtRMQWOR0Tnh2b+8a47DBoy4ru4LGyB+3w a8NFKANgA0vdlB9+G9c92tcrxBFW63L34m2osXJNzNsYmqdXgd2qhBH3Kv8stafznH LeXZWGwKC436Q== Date: Fri, 10 Feb 2023 16:38:47 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Ayan Kumar Halder cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, stefano.stabellini@amd.com, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com Subject: Re: [XEN v3 8/9] xen/arm: Restrict zeroeth_table_offset for ARM_64 In-Reply-To: <20230208120529.22313-9-ayan.kumar.halder@amd.com> Message-ID: References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-9-ayan.kumar.halder@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: > When 32 bit physical addresses are used (ie ARM_PA_32=y), > "va >> ZEROETH_SHIFT" causes an overflow. > Also, there is no zeroeth level page table on Arm 32-bit. > > Also took the opportunity to clean up dump_pt_walk(). One could use > DECLARE_OFFSETS() macro instead of declaring the declaring an array > of page table offsets. > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini > --- > Changes from - > > v1 - Removed the duplicate declaration for DECLARE_OFFSETS. > > v2 - 1. Reworded the commit message. > 2. Use CONFIG_ARM_PA_32 to restrict zeroeth_table_offset. > > xen/arch/arm/include/asm/lpae.h | 4 ++++ > xen/arch/arm/mm.c | 7 +------ > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h > index 3fdd5d0de2..998edeed6e 100644 > --- a/xen/arch/arm/include/asm/lpae.h > +++ b/xen/arch/arm/include/asm/lpae.h > @@ -259,7 +259,11 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); > #define first_table_offset(va) TABLE_OFFSET(first_linear_offset(va)) > #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va)) > #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) > +#ifdef CONFIG_ARM_PA_32 > +#define zeroeth_table_offset(va) 0 > +#else > #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) > +#endif > > /* > * Macros to define page-tables: > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index b99806af99..44942c6a4f 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -221,12 +221,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr, > { > static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; > const mfn_t root_mfn = maddr_to_mfn(ttbr); > - const unsigned int offsets[4] = { > - zeroeth_table_offset(addr), > - first_table_offset(addr), > - second_table_offset(addr), > - third_table_offset(addr) > - }; > + DECLARE_OFFSETS(offsets, addr); > lpae_t pte, *mapping; > unsigned int level, root_table; > > -- > 2.17.1 > > From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:48:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:48:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493750.763771 (Exim 4.92) (envelope-from ) id 1pQe3s-0005rS-8i; Sat, 11 Feb 2023 00:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493750.763771; Sat, 11 Feb 2023 00:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQe3s-0005rL-64; Sat, 11 Feb 2023 00:48:16 +0000 Received: by outflank-mailman (input) for mailman id 493750; Sat, 11 Feb 2023 00:48:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQe3q-0005rF-Oj for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:48:14 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c32c9179-a9a5-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 01:48:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 446FCB825B7; Sat, 11 Feb 2023 00:48:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F08C2C433D2; Sat, 11 Feb 2023 00:48:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c32c9179-a9a5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676076490; bh=pxWZHecd82zZuYTCuNFIJt0UN+Di0MpKCnAPsIsptq4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AURwFrQIi8chdOalPbnxT3DqJpDi4T9wC5FiVAwvF5pqnTTbmyWXI7/Uy2X1FzbA7 O/xx1qU9H8GZgnIFICLdlY8qSLDS6165K0k3D2Ao8k8J5iMD87cpmS4SkjD1szVbHY vPab81iCWTO2GmYe7XOSkfODz/THwfsBMtq8SOrFbxGRurw0MkRFnidK7xmbywy0DK lzMDpK89numO9lqCPRwIM1NrhivtOMTUF+HXxzHdA3ARSq3mXTuL4wbcg+KbWgCBFh bpKmc+4jb9j3UbwNATJs4+ahm7AQ7rEiVj6VuGZzdwwlN++3A7cJwVrb2Y8XatvFv8 //NP0CDh4Cb7g== Date: Fri, 10 Feb 2023 16:48:08 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Michal Orzel , Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic In-Reply-To: Message-ID: References: <20230206130528.22401-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 6 Feb 2023, Luca Fancellu wrote: > > On 6 Feb 2023, at 13:05, Michal Orzel wrote: > > > > This might be helpful in providing additional debugging information (in > > most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the > > code to include printing return code in panic message. In create_dom0, > > move the call to alloc_dom0_vcpu0() to a separate condition and call a > > meaningful panic message. > > > > Signed-off-by: Michal Orzel > > --- > > Hi Michal, > > The code looks good to me > > Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Sat Feb 11 00:56:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 00:56:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493757.763783 (Exim 4.92) (envelope-from ) id 1pQeBf-0007Wz-3M; Sat, 11 Feb 2023 00:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493757.763783; Sat, 11 Feb 2023 00:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQeBf-0007Ws-0B; Sat, 11 Feb 2023 00:56:19 +0000 Received: by outflank-mailman (input) for mailman id 493757; Sat, 11 Feb 2023 00:56:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQeBc-0007Wl-PN for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:56:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0674653-a9a6-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 01:56:12 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BCF8661EF4; Sat, 11 Feb 2023 00:56:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93CC7C433EF; Sat, 11 Feb 2023 00:56:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0674653-a9a6-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676076970; bh=NrBYVm4xp/0D/tT+thD7/E4LRpIFa7BezzoqeXNTaaw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JP0j1/AMtmJzy5K+dY+R08xZ9/GQ6Og9q2eSi1qOW2E9+3Iy5CnjLZbp6P9uKWBhT CNkzckAFxXDADyg3zWam1LgaDOo1DmqKowXSSNxf7kUIxXGS1siqtTvSMFvWCFDGo+ lCOo/rodugwqjtLuLUMjJTZcZoOekfi+BrSp2PrCU4Av9+b+U0T0xN2tcEp5iiXu0V /BtGbVCRGzqg/uv1yH8Z4xO8ZYzD35Ns09Qmquj2Qdfposxd1iq/Q1iuuDB7c/T4CJ QuuYEhEgw0srabalCwQWF45pmfoI/qktLE78a97HSFJYHSGkXdyWrCgAkPGHl/PX+Z rfsR4V7SneEew== Date: Fri, 10 Feb 2023 16:56:07 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: El Mesdadi Youssef ESK UILD7 cc: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini Subject: Re: AW: AW: Xenstore failed to start / Xenalyze on ARM ( NXP S32G3 with Cortex-A53) In-Reply-To: Message-ID: References: <3e7059c2-0d23-03f2-9a93-f88de09171f4@xen.org> <619a00f0-0f9f-5f5f-13a7-ea86f9c24eec@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2097830747-1676076969=:4661" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2097830747-1676076969=:4661 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 7 Feb 2023, El Mesdadi Youssef ESK UILD7 wrote: > > hello Julien, > > >first of all thank you so much for the support, after flashing Xen on the S32G3 I noticed that I cannot create DomUs. > >when I also give the xl list, it does not even show Dom0 and stays blocked. > > root@s32g399aevb3:~# xl list > Name ID Mem VCPUs State Time(s) > > root@s32g399aevb3:~# This is usually due to the init script (/etc/init.d/xencommons or systemd scripts) hanging or crashing. As a consequence xenstored doesn't get launched properly. > >I assume this is because xenstore failed to start, the error is shown in the messages during the boot time. > > [FAILED] Failed to start The Xen xenstore. > See 'systemctl status xenstored.service' for details. You need to fix this. A couple of options: - ignore the systemd scripts, and instead try to execute manually bash /etc/init.d/xencommons start - try to launch xenstored manually with: xenstored & - have a look at the way Yocto meta-virtualization sets up the systemd init scripts as this seems to be a "distro" error https://github.com/lgirdk/meta-virtualization/blob/master/recipes-extended/xen/xen-tools.inc - switch from systemd to SysVinit > [FAILED] Failed to mount NFSD configuration filesystem. > See 'systemctl status proc-fs-nfsd.mount' for details. > > >Here is xl.conf in case you need information about this file: > > root@s32g399aevb3:/etc/xen# cat xl.conf > ## Global XL config file ## > > # Set domain-id policy. "xen" means that the hypervisor will choose the > # id of a new domain. "random" means that a random value will be chosen. > #domid_policy="xen" > > # Control whether dom0 is ballooned down when xen doesn't have enough > # free memory to create a domain. "auto" means only balloon if dom0 > # starts with all the host's memory. > #autoballoon="auto" > > # full path of the lockfile used by xl during domain creation > #lockfile="/var/lock/xl" > > # default output format used by "xl list -l" > #output_format="json" > > # first block device to be used for temporary VM disk mounts > #blkdev_start="xvda" > > # default option to run hotplug scripts from xl > # if disabled the old behaviour will be used, and hotplug scripts will be > # launched by udev. > #run_hotplug_scripts=1 > > # default backend domain to connect guest vifs to. This can be any > # valid domain identifier. > #vif.default.backend="0" > > # default gateway device to use with vif-route hotplug script > #vif.default.gatewaydev="eth0" > > # default vif script to use if none is specified in the guest config > #vif.default.script="vif-bridge" > > # default bridge device to use with vif-bridge hotplug scripts > #vif.default.bridge="xenbr0" > > # Reserve a claim of memory when launching a guest. This guarantees immediate > # feedback whether the guest can be launched due to memory exhaustion > # (which can take a long time to find out if launching huge guests). > # see xl.conf(5) for details. > #claim_mode=1 > > # Specify global vcpu hard affinity masks. See xl.conf(5) for details. > #vm.cpumask="0-7" > #vm.pv.cpumask="0-3" > #vm.hvm.cpumask="3-7" > > > >next are the messages during the boot time: > > NOTICE: Reset status: Power-On Reset > NOTICE: BL2: v2.5(release):bsp33.0-2.5-dirty > NOTICE: BL2: Built : 14:01:09, Jun 15 2022 > NOTICE: BL2: Booting BL31 > > > U-Boot 2020.04+g9cdfca686e (Jun 10 2022 - 11:46:41 +0000) > > CPU: NXP S32G399A rev. 1.0 > Model: NXP S32G3XXX-EVB > DRAM: 3.5 GiB > MMC: FSL_SDHC: 0 > Loading Environment from MMC... OK > Using internal clock for PCIe0, CRNS > Configuring PCIe0 as RootComplex(x2) > Using internal clock for PCIe1, CRNS > Frequency 100Mhz configured for PCIe1 > Configuring PCIe1 as SGMII [XPCS0 1G, XPCS1 OFF(PCIex1)] > Setting PCI Device and Vendor IDs to 0x4300:0x1957 > PCIe0: Failed to get link up > Pcie0: LINK_DBG_1: 0x00000000, LINK_DBG_2: 0x00000800 (expected 0x000000d1) > DEBUG_R0: 0x00ed4001, DEBUG_R1: 0x08600000 > PCI: Failed autoconfig bar 1c > PCIe1: Not configuring PCIe, PHY not configured > In: serial@401c8000 > Out: serial@401c8000 > Err: serial@401c8000 > Loading SJA1105 firmware over SPI 5:0 > No matching device ID found for devid FFFFFFFF, cs 0. > Error SJA1105 configuration not completed > Net: EQOS phy: rgmii @ 4 > > Warning: eth_eqos (eth0) using random MAC address - f6:65:86:a2:0e:f8 > eth0: eth_eqos PFE: emac0: sgmii emac1: none emac2: none > > Warning: eth_pfeng using MAC address from ROM > , eth1: eth_pfeng > Hit any key to stop autoboot: 0 > PFE: emac0: sgmii emac1: none emac2: none > PFE: emac0: sgmii emac1: none emac2: none > 1039 bytes read in 9 ms (112.3 KiB/s) > ## Executing script at 80200000 > 1048688 bytes read in 36 ms (27.8 MiB/s) > 14034952 bytes read in 201 ms (66.6 MiB/s) > 38461 bytes read in 9 ms (4.1 MiB/s) > ## Flattened Device Tree blob at 86600000 > Booting using the fdt blob at 0x86600000 > Using Device Tree in place at 0000000086600000, end 000000008660dfff > DT: Enabling PFE > DT: Enabling PFE_EMAC_0 > DT: pfe0 set to 00:01:be:be:ef:11 > DT: Disabling PFE_EMAC_1 > DT: Disabling PFE_EMAC_2 > > Starting kernel ... > > - UART enabled - > - Boot CPU booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Zero BSS - > - Ready - > (XEN) Checking for initrd in /chosen > (XEN) RAM: 0000000080000000 - 00000000ffffffff > (XEN) RAM: 0000000880000000 - 00000008dfffffff > (XEN) > (XEN) MODULE[0]: 0000000085600000 - 00000000857430c8 Xen > (XEN) MODULE[1]: 0000000086600000 - 000000008660a000 Device Tree > (XEN) MODULE[2]: 0000000085800000 - 0000000086562808 Kernel > (XEN) RESVD[0]: 00000000ff800000 - 00000000ff9fffff > (XEN) RESVD[1]: 00000000c0000000 - 00000000c03fffff > (XEN) RESVD[2]: 00000000c0400000 - 00000000c07fffff > (XEN) RESVD[3]: 00000000d0000000 - 00000000d03fffff > (XEN) RESVD[4]: 0000000084000000 - 000000008407ffff > (XEN) RESVD[5]: 0000000034000000 - 000000003407ffff > (XEN) RESVD[6]: 0000000034080000 - 000000003409ffff > (XEN) RESVD[7]: 0000000083200000 - 00000000835dffff > (XEN) RESVD[8]: 00000000835e0000 - 00000000835fffff > (XEN) > (XEN) > (XEN) Command line: dom0_mem=512M dom0_max_vcpus=1 bootscrub=0 > (XEN) PFN compression on bits 20...22 > (XEN) Domain heap initialised > (XEN) Booting using Device Tree > (XEN) Platform: NXP S32-Gen1 > (XEN) No dtuart path configured > (XEN) Bad console= option 'dtuart' > Xen 4.14.0 > (XEN) Xen version 4.14.0 (xen-4.14-r0@fsl-auto) (aarch64-fsl-linux-gcc (GCC) 10. 2.0) debug=y 2022-05-18 > (XEN) Latest ChangeSet: Wed May 18 15:47:26 2022 +0300 git:becdd18e50-dirty > (XEN) build-id: c93be820bfe87b5abccd95ea86e98121e1231249 > (XEN) Processor: 410fd034: "ARM Limited", variant: 0x0, part 0xd03, rev 0x4 > (XEN) 64-bit Execution: > (XEN) Processor Features: 0000000001002222 0000000000000000 > (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32 > (XEN) Extensions: FloatingPoint AdvancedSIMD GICv3-SysReg > (XEN) Debug Features: 0000000010305106 0000000000000000 > (XEN) Auxiliary Features: 0000000000000000 0000000000000000 > (XEN) Memory Model Features: 0000000000001122 0000000000000000 > (XEN) ISA Features: 0000000000011120 0000000000000000 > (XEN) 32-bit Execution: > (XEN) Processor Features: 00000131:10011011 > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle > (XEN) Extensions: GenericTimer Security > (XEN) Debug Features: 03010066 > (XEN) Auxiliary Features: 00000000 > (XEN) Memory Model Features: 10201105 40000000 01260000 02102211 > (XEN) ISA Features: 02101110 13112111 21232042 01112131 00011142 00011121 > (XEN) Using SMC Calling Convention v1.2 > (XEN) Using PSCI v1.1 > (XEN) SMP: Allowing 8 CPUs > (XEN) enabled workaround for: ARM erratum 1530924 > (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 5000 KHz > (XEN) GICv3 initialization: > (XEN) gic_dist_addr=0x00000050800000 > (XEN) gic_maintenance_irq=25 > (XEN) gic_rdist_stride=0 > (XEN) gic_rdist_regions=1 > (XEN) redistributor regions: > (XEN) - region 0: 0x00000050900000 - 0x00000050b00000 > (XEN) GICv3 compatible with GICv2 cbase 0x00000050400000 vbase 0x00000050420000 > (XEN) GICv3: 576 lines, (IID 0001143b). > (XEN) GICv3: CPU0: Found redistributor in region 0 @000000004001a000 > (XEN) XSM Framework v1.0.0 initialized > (XEN) Initialising XSM SILO mode > (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2) > (XEN) Initializing Credit2 scheduler > (XEN) load_precision_shift: 18 > (XEN) load_window_shift: 30 > (XEN) underload_balance_tolerance: 0 > (XEN) overload_balance_tolerance: -3 > (XEN) runqueues arrangement: socket > (XEN) cap enforcement granularity: 10ms > (XEN) load tracking window length 1073741824 ns > (XEN) Allocated console ring of 64 KiB. > (XEN) CPU0: Guest atomics will try 13 times before pausing the domain > (XEN) Bringing up CPU1 > - CPU 00000001 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU1: Found redistributor in region 0 @000000004003a000 > (XEN) CPU1: Guest atomics will try 15 times before pausing the domain > (XEN) CPU 1 booted. > (XEN) Bringing up CPU2 > - CPU 00000100 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU2: Found redistributor in region 0 @000000004009a000 > (XEN) CPU2: Guest atomics will try 15 times before pausing the domain > (XEN) CPU 2 booted. > (XEN) Bringing up CPU3 > - CPU 00000101 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU3: Found redistributor in region 0 @00000000400ba000 > (XEN) CPU3: Guest atomics will try 15 times before pausing the domain > (XEN) CPU 3 booted. > (XEN) Bringing up CPU4 > - CPU 00000002 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU4: Found redistributor in region 0 @000000004005a000 > (XEN) CPU4: Guest atomics will try 14 times before pausing the domain > (XEN) CPU 4 booted. > (XEN) Bringing up CPU5 > - CPU 00000003 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU5: Found redistributor in region 0 @000000004007a000 > (XEN) CPU5: Guest atomics will try 15 times before pausing the domain > (XEN) CPU 5 booted. > (XEN) Bringing up CPU6 > - CPU 00000102 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU6: Found redistributor in region 0 @00000000400da000 > (XEN) CPU6: Guest atomics will try 16 times before pausing the domain > (XEN) CPU 6 booted. > (XEN) Bringing up CPU7 > - CPU 00000103 booting - > - Current EL 00000008 - > - Initialize CPU - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU7: Found redistributor in region 0 @00000000400fa000 > (XEN) CPU7: Guest atomics will try 15 times before pausing the domain > (XEN) CPU 7 booted. > (XEN) Brought up 8 CPUs > (XEN) I/O virtualisation disabled > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > (XEN) P2M: 3 levels with order-1 root, VTCR 0x80023558 > (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource > (XEN) Adding cpu 0 to runqueue 0 > (XEN) First cpu on runqueue, activating > (XEN) Adding cpu 1 to runqueue 0 > (XEN) Adding cpu 2 to runqueue 0 > (XEN) Adding cpu 3 to runqueue 0 > (XEN) Adding cpu 4 to runqueue 0 > (XEN) Adding cpu 5 to runqueue 0 > (XEN) Adding cpu 6 to runqueue 0 > (XEN) Adding cpu 7 to runqueue 0 > (XEN) alternatives: Patching with alt table 00000000002d4308 -> 00000000002d4b3c > (XEN) *** LOADING DOMAIN 0 *** > (XEN) Loading d0 kernel from boot module @ 0000000085800000 > (XEN) Allocating 1:1 mappings totalling 512MB for dom0: > (XEN) BANK[0] 0x000000a0000000-0x000000c0000000 (512MB) > (XEN) Grant table range: 0x00000085600000-0x00000085640000 > (XEN) Allocating PPI 16 for event channel interrupt > (XEN) Loading zImage from 0000000085800000 to 00000000a0000000-00000000a0d62808 > (XEN) Loading d0 DTB to 0x00000000a8000000-0x00000000a800947a > (XEN) Initial low memory virq threshold set at 0x4000 pages. > (XEN) Std. Loglevel: All > (XEN) Guest Loglevel: All > (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) > (XEN) Freed 352kB init memory. > (XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER4 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER8 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER12 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER16 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER20 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER24 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER28 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER32 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER36 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER40 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER44 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER48 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER52 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER56 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER60 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER64 > (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER68 > (XEN) d0v0: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 > [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034] > [ 0.000000] Linux version 5.10.109-rt65+g0bace7fde5f5 (oe-user@oe-host) (aarc h64-fsl-linux-gcc (GCC) 10.2.0, GNU ld (GNU Binutils) 2.35.1) #1 SMP PREEMPT Fri Jun 24 15:01:08 UTC 2022 > [ 0.000000] Machine model: NXP S32G3XXX-EVB3 > [ 0.000000] Xen 4.14 support found > [ 0.000000] Reserved memory: created DMA memory pool at 0x0000000083200000, s ize 3 MiB > [ 0.000000] OF: reserved mem: initialized node pfebufs@83200000, compatible i d shared-dma-pool > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000034000000-0x00000000ff9fffff] > [ 0.000000] DMA32 empty > [ 0.000000] Normal empty > [ 0.000000] Movable zone start for each node > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000034000000-0x000000003409ffff] > [ 0.000000] node 0: [mem 0x0000000083200000-0x00000000835dffff] > [ 0.000000] node 0: [mem 0x00000000835e0000-0x00000000835fffff] > [ 0.000000] node 0: [mem 0x0000000084000000-0x000000008407ffff] > [ 0.000000] node 0: [mem 0x00000000a0000000-0x00000000bfffffff] > [ 0.000000] node 0: [mem 0x00000000c0000000-0x00000000c07fffff] > [ 0.000000] node 0: [mem 0x00000000d0000000-0x00000000d03fffff] > [ 0.000000] node 0: [mem 0x00000000ff800000-0x00000000ff9fffff] > [ 0.000000] Initmem setup node 0 [mem 0x0000000034000000-0x00000000ff9fffff] > [ 0.000000] cma: Reserved 256 MiB at 0x00000000ad000000 > [ 0.000000] psci: probing for conduit method from DT. > [ 0.000000] psci: PSCIv1.1 detected in firmware. > [ 0.000000] psci: Using standard PSCI v0.2 function IDs > [ 0.000000] psci: Trusted OS migration not required > [ 0.000000] psci: SMC Calling Convention v1.1 > [ 0.000000] percpu: Embedded 17 pages/cpu s32024 r8192 d29416 u69632 > [ 0.000000] Detected VIPT I-cache on CPU0 > [ 0.000000] CPU features: detected: ARM erratum 845719 > [ 0.000000] CPU features: detected: GIC system register CPU interface > [ 0.000000] CPU features: detected: ARM errata 1165522, 1319367, 1530923, or 1530924 > [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 134109 > [ 0.000000] Kernel command line: console=ttyLF0,115200 earlycon=xen earlyprin tk=xen root=/dev/mmcblk0p2 rw clk_ignore_unused > [ 0.000000] Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes, linear) > [ 0.000000] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes, li near) > [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off > [ 0.000000] Memory: 202252K/543872K available (8766K kernel code, 650K rwdata , 2880K rodata, 1344K init, 245K bss, 79476K reserved, 262144K cma-reserved) > [ 0.000000] rcu: Preemptible hierarchical RCU implementation. > [ 0.000000] rcu: RCU event tracing is enabled. > [ 0.000000] rcu: RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=1. > [ 0.000000] Trampoline variant of Tasks RCU enabled. > [ 0.000000] Tracing variant of Tasks RCU enabled. > [ 0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 25 jif fies. > [ 0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=1 > [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 > [ 0.000000] GICv3: 544 SPIs implemented > [ 0.000000] GICv3: 0 Extended SPIs implemented > [ 0.000000] GICv3: Distributor has no Range Selector support > [ 0.000000] GICv3: 16 PPIs implemented > [ 0.000000] GICv3: CPU0: found redistributor 0 region 0:0x0000000050900000 > [ 0.000000] random: get_random_bytes called from start_kernel+0x31c/0x4ec wit h crng_init=0 > [ 0.000000] arch_timer: cp15 timer(s) running at 5.00MHz (virt). > [ 0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x127350b88, max_idle_ns: 440795202120 ns > [ 0.000001] sched_clock: 56 bits at 5MHz, resolution 200ns, wraps every 43980 46511100ns > [ 0.000357] Console: colour dummy device 80x25 > [ 0.000385] Calibrating delay loop (skipped), value calculated using timer fr equency.. 10.00 BogoMIPS (lpj=20000) > [ 0.000395] pid_max: default: 32768 minimum: 301 > [ 0.000489] Mount-cache hash table entries: 2048 (order: 2, 16384 bytes, line ar) > [ 0.000500] Mountpoint-cache hash table entries: 2048 (order: 2, 16384 bytes, linear) > [ 0.001943] xen:grant_table: Grant tables using version 1 layout > [ 0.001964] Grant table initialized > [ 0.001994] xen:events: Using FIFO-based ABI > [ 0.002023] Xen: initializing cpu0 > [ 0.002127] rcu: Hierarchical SRCU implementation. > [ 0.002412] smp: Bringing up secondary CPUs ... > [ 0.002415] smp: Brought up 1 node, 1 CPU > [ 0.002419] SMP: Total of 1 processors activated. > [ 0.002427] CPU features: detected: 32-bit EL0 Support > [ 0.002433] CPU features: detected: CRC32 instructions > [ 0.009718] CPU: All CPU(s) started at EL1 > [ 0.009731] alternatives: patching kernel code > [ 0.010183] devtmpfs: initialized > [ 0.014415] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, ma x_idle_ns: 7645041785100000 ns > [ 0.014429] futex hash table entries: 256 (order: 2, 16384 bytes, linear) > [ 0.020426] pinctrl core: initialized pinctrl subsystem > [ 0.020983] NET: Registered protocol family 16 > [ 0.022141] DMA: preallocated 128 KiB GFP_KERNEL pool for atomic allocations > [ 0.022218] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA pool for atomic allo cations > [ 0.022309] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA32 pool for atomic al locations > [ 0.022851] thermal_sys: Registered thermal governor 'step_wise' > [ 0.023110] hw-breakpoint: found 6 breakpoint and 4 watchpoint registers. > [ 0.023153] ASID allocator initialised with 65536 entries > [ 0.023218] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB > [ 0.023933] software IO TLB: mapped [mem 0x00000000a1800000-0x00000000a1c0000 0] (4MB) > [ 0.023998] Serial: AMBA PL011 UART driver > [ 0.024571] arm-scmi firmware:scmi: SCMI Notifications - Core Enabled. > [ 0.024649] arm-scmi firmware:scmi: No. of Protocol > MAX_PROTOCOLS_IMP > [ 0.024654] arm-scmi firmware:scmi: SCMI Protocol v2.0 'NXP:S32G399A' Firmwar e version 0x0 > [ 0.039850] HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages > [ 0.039858] HugeTLB registered 32.0 MiB page size, pre-allocated 0 pages > [ 0.039862] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages > [ 0.039866] HugeTLB registered 64.0 KiB page size, pre-allocated 0 pages > [ 0.043412] scmi-clocks scmi_dev.1: failed to register clock 87 > [ 0.043421] scmi-clocks scmi_dev.1: failed to register clock 88 > [ 0.043428] scmi-clocks scmi_dev.1: failed to register clock 89 > [ 0.043434] scmi-clocks scmi_dev.1: failed to register clock 90 > [ 0.043507] scmi-clocks scmi_dev.1: failed to register clock 95 > [ 0.043514] scmi-clocks scmi_dev.1: failed to register clock 96 > [ 0.043520] scmi-clocks scmi_dev.1: failed to register clock 97 > [ 0.043526] scmi-clocks scmi_dev.1: failed to register clock 98 > [ 0.046871] xen:balloon: Initialising balloon driver > [ 0.047230] vgaarb: loaded > [ 0.047367] SCSI subsystem initialized > [ 0.047494] usbcore: registered new interface driver usbfs > [ 0.047521] usbcore: registered new interface driver hub > [ 0.047541] usbcore: registered new device driver usb > [ 0.047818] pps_core: LinuxPPS API ver. 1 registered > [ 0.047821] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giome tti > [ 0.047831] PTP clock support registered > [ 0.048664] clocksource: Switched to clocksource arch_sys_counter > [ 0.053083] NET: Registered protocol family 2 > [ 0.053173] IP idents hash table entries: 16384 (order: 5, 131072 bytes, line ar) > [ 0.053762] tcp_listen_portaddr_hash hash table entries: 512 (order: 1, 8192 bytes, linear) > [ 0.053787] TCP established hash table entries: 8192 (order: 4, 65536 bytes, linear) > [ 0.053847] TCP bind hash table entries: 8192 (order: 5, 131072 bytes, linear ) > [ 0.053970] TCP: Hash tables configured (established 8192 bind 8192) > [ 0.054028] UDP hash table entries: 512 (order: 2, 16384 bytes, linear) > [ 0.054052] UDP-Lite hash table entries: 512 (order: 2, 16384 bytes, linear) > [ 0.054147] NET: Registered protocol family 1 > [ 0.054435] RPC: Registered named UNIX socket transport module. > [ 0.054439] RPC: Registered udp transport module. > [ 0.054441] RPC: Registered tcp transport module. > [ 0.054443] RPC: Registered tcp NFSv4.1 backchannel transport module. > [ 0.054451] PCI: CLS 0 bytes, default 64 > [ 0.055375] workingset: timestamp_bits=62 max_order=17 bucket_order=0 > [ 0.055858] fuse: init (API version 7.32) > [ 0.055965] NET: Registered protocol family 38 > [ 0.055988] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 2 48) > [ 0.055993] io scheduler mq-deadline registered > [ 0.055997] io scheduler kyber registered > [ 0.057025] s32g-siul2-pinctrl 4009c240.siul2-pinctrl: initialized s32 pinctr l driver > [ 0.057965] gpio-339 (llcecan0-en): hogged as output/high > [ 0.057983] gpio-340 (llcecan0-stby): hogged as output/high > [ 0.057998] gpio-342 (llcecan4-en): hogged as output/high > [ 0.058014] gpio-343 (llcecan4-stby): hogged as output/high > [ 0.058029] gpio-345 (llcecan5-en): hogged as output/high > [ 0.058044] gpio-346 (llcecan5-stby): hogged as output/high > [ 0.058058] gpio-351 (llcecan6-en): hogged as output/high > [ 0.058072] gpio-352 (llcecan6-stby): hogged as output/high > [ 0.058089] gpio-353 (llcecan12-stby): hogged as output/high > [ 0.058103] gpio-358 (llcecan12-en): hogged as output/high > [ 0.058120] gpio-360 (llcecan13-en): hogged as output/high > [ 0.058135] gpio-361 (llcecan13-stby): hogged as output/high > [ 0.058151] gpio-382 (llcecan15-en): hogged as output/high > [ 0.058165] gpio-383 (llcecan15-stby): hogged as output/high > [ 0.059358] xen:xen_evtchn: Event-channel device installed > [ 0.060467] serial: Freescale linflex driver > [ 0.060686] 401c8000.serial: ttyLF0 at MMIO 0x401c8000 (irq = 25, base_baud = 7812500) is a FSL_LINFLEX > [ 0.060735] printk: console [ttyLF0] enabled > [ 0.061072] 401cc000.serial: ttyLF1 at MMIO 0x401cc000 (irq = 26, base_baud = 7812500) is a FSL_LINFLEX > [ 0.061385] 402bc000.serial: ttyLF2 at MMIO 0x402bc000 (irq = 44, base_baud = 7812500) is a FSL_LINFLEX > [ 0.061832] cacheinfo: Unable to detect cache hierarchy for CPU 0 > [ 0.061846] Invalid max_queues (4), will use default max: 1. > [ 0.062193] fsl_fccu 4030c000.fccu: FCCU status is 0 (normal) > [ 0.063813] spi-nor spi0.0: mt35xu02g (262144 Kbytes) > [ 0.065365] vcan: Virtual CAN interface driver > [ 0.065370] slcan: serial line CAN interface driver > [ 0.065372] slcan: 10 dynamic interface channels. > [ 0.065377] CAN device driver interface > [ 0.065555] e100: Intel(R) PRO/100 Network Driver > [ 0.065558] e100: Copyright(c) 1999-2006 Intel Corporation > [ 0.065585] e1000: Intel(R) PRO/1000 Network Driver > [ 0.065588] e1000: Copyright (c) 1999-2006 Intel Corporation. > [ 0.065615] e1000e: Intel(R) PRO/1000 Network Driver > [ 0.065616] e1000e: Copyright(c) 1999 - 2015 Intel Corporation. > [ 0.065642] igb: Intel(R) Gigabit Ethernet Network Driver > [ 0.065645] igb: Copyright (c) 2007-2014 Intel Corporation. > [ 0.065920] xen_netfront: Initialising Xen virtual ethernet driver > [ 0.066016] hse-uio 40211000.mu1b: firmware not found > [ 0.066208] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver > [ 0.066213] ehci-pci: EHCI PCI platform driver > [ 0.066318] usbcore: registered new interface driver uas > [ 0.066346] usbcore: registered new interface driver usb-storage > [ 0.067503] s32gen1-rtc 40060000.rtc: registered as rtc0 > [ 0.067533] s32gen1-rtc 40060000.rtc: setting system clock to 1970-01-01T00:0 0:00 UTC (0) > [ 0.067665] i2c /dev entries driver > [ 0.068026] sac58r-wdt 4010c000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.068204] sac58r-wdt 40200000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.068371] sac58r-wdt 40204000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.068538] sac58r-wdt 40208000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.068776] sac58r-wdt 40500000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.068950] sac58r-wdt 40504000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.069112] sac58r-wdt 40508000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.069279] sac58r-wdt 4050c000.swt: SAC58R/S32GEN1 Watchdog Timer Registered . timeout=30s (nowayout=0) > [ 0.069492] sdhci: Secure Digital Host Controller Interface driver > [ 0.069495] sdhci: Copyright(c) Pierre Ossman > [ 0.069497] sdhci-pltfm: SDHCI platform and OF driver helper > [ 0.069837] mmc0: CQHCI version 5.10 > [ 0.070452] hse 40210000.mu0b: firmware not found > [ 0.070658] usbcore: registered new interface driver usbhid > [ 0.070662] usbhid: USB HID core driver > [ 0.082993] s32-adc 401f8000.adc: Device initialized successfully. > [ 0.094947] s32-adc 402e8000.adc: Device initialized successfully. > [ 0.095109] nxp_s32_ddr_perf 403e0000.ddr-perf: probing device > [ 0.095353] nxp_s32_ddr_perf 403e0000.ddr-perf: device initialized successful ly > [ 0.095430] s32-siul2-nvmem 4009c000.nvram: initialize s32 siul2 nvmem driver > [ 0.095550] s32-siul2-nvmem 44010000.nvram: initialize s32 siul2 nvmem driver > [ 0.095949] NET: Registered protocol family 10 > [ 0.096436] Segment Routing with IPv6 > [ 0.096476] sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver > [ 0.096852] NET: Registered protocol family 17 > [ 0.096947] can: controller area network core > [ 0.096980] NET: Registered protocol family 29 > [ 0.096984] can: raw protocol > [ 0.096989] can: broadcast manager protocol > [ 0.096996] can: netlink gateway - max_hops=1 > [ 0.097014] 8021q: 802.1Q VLAN Support v1.8 > [ 0.097149] printk: console [ttyLF0]: printing thread started > [ 0.100703] mmc0: SDHCI controller on 402f0000.usdhc [402f0000.usdhc] using A DMA > [ 0.108674] phy-s32gen1-serdes 40480000.serdes: Using mode 0 for SerDes subsy stem > [ 0.109020] phy-s32gen1-serdes 44180000.serdes: Using mode 3 for SerDes subsy stem > [ 0.115131] phy-s32gen1-serdes 44180000.serdes: Unstable RX detected on XPCS1 > [ 0.115158] phy-s32gen1-serdes 44180000.serdes: Unstable RX detected on XPCS0 > [ 0.115337] s32gen1-pcie 40400000.pcie: Configured as RootComplex > [ 0.115627] s32gen1-pcie 40400000.pcie: Setting PCI Device and Vendor IDs to 0x4300:0x1957 > [ 0.116614] s32gen1-pcie 40400000.pcie: Allocated line 0 for interrupt 52 (ms i) > [ 0.383316] mmc0: Command Queue Engine enabled > [ 0.383326] mmc0: new DDR MMC card at address 0001 > [ 0.391409] mmcblk0: mmc0:0001 G1M15M 59.3 GiB > [ 0.391539] mmcblk0boot0: mmc0:0001 G1M15M partition 1 31.5 MiB > [ 0.391661] mmcblk0boot1: mmc0:0001 G1M15M partition 2 31.5 MiB > [ 0.391804] mmcblk0rpmb: mmc0:0001 G1M15M partition 3 4.00 MiB, chardev (243: 0) > [ 0.399208] mmcblk0: p1 p2 p3 > [ 1.136116] s32gen1-pcie 40400000.pcie: Failed to stabilize PHY link > [ 1.136123] s32gen1-pcie 40400000.pcie: Configuring as RootComplex > [ 1.136136] s32gen1-pcie 40400000.pcie: host bridge /soc/pcie@40400000 ranges : > [ 1.136177] s32gen1-pcie 40400000.pcie: IO 0x5ffffe0000..0x5ffffeffff - > 0x0000000000 > [ 1.136195] s32gen1-pcie 40400000.pcie: MEM 0x5800000000..0x5ffffdffff - > 0x0000000000 > (XEN) physdev.c:16:d0v0 PHYSDEVOP cmd=25: not implemented > [ 2.142041] s32gen1-pcie 40400000.pcie: Phy link never came up > (XEN) physdev.c:16:d0v0 PHYSDEVOP cmd=15: not implemented > [ 2.142133] s32gen1-pcie 40400000.pcie: PCI host bridge to bus 0000:00 > [ 2.142139] pci_bus 0000:00: root bus resource [bus 00-ff] > [ 2.142147] pci_bus 0000:00: root bus resource [io 0x0000-0xffff] > [ 2.142153] pci_bus 0000:00: root bus resource [mem 0x5800000000-0x5ffffdffff ] (bus address [0x00000000-0x7fffdffff]) > [ 2.142201] pci 0000:00:00.0: [16c3:4300] type 01 class 0x060400 > [ 2.142224] pci 0000:00:00.0: reg 0x10: [mem 0x5800000000-0x58000fffff] > [ 2.142242] pci 0000:00:00.0: reg 0x38: [mem 0x5800000000-0x580000ffff pref] > [ 2.142339] pci 0000:00:00.0: supports D1 > [ 2.142344] pci 0000:00:00.0: PME# supported from D0 D1 D3hot D3cold > [ 2.165526] pci 0000:00:00.0: Failed to add - passthrough or MSI/MSI-X might fail! > [ 2.168521] pci 0000:00:00.0: BAR 0: assigned [mem 0x5800000000-0x58000fffff] > [ 2.168532] pci 0000:00:00.0: BAR 6: assigned [mem 0x5800100000-0x580010ffff pref] > [ 2.168541] pci 0000:00:00.0: PCI bridge to [bus 01-ff] > [ 2.168839] pcieport 0000:00:00.0: PME: Signaling with IRQ 67 > [ 2.175158] clk: Not disabling unused clocks > [ 2.270457] random: fast init done > [ 2.282422] EXT4-fs (mmcblk0p2): recovery complete > [ 2.283171] EXT4-fs (mmcblk0p2): mounted filesystem with ordered data mode. O pts: (null) > [ 2.283229] VFS: Mounted root (ext4 filesystem) on device 179:2. > [ 2.283571] devtmpfs: mounted > [ 2.284179] Freeing unused kernel memory: 1344K > [ 2.284312] Run /sbin/init as init process > [ 2.413488] systemd[1]: System time before build time, advancing clock. > [ 2.441298] systemd[1]: systemd 246 running in system mode. (+PAM -AUDIT -SEL INUX +IMA -APPARMOR -SMACK +SYSVINIT +UTMP -LIBCRYPTSETUP -GCRYPT -GNUTLS +ACL + XZ -LZ4 -ZSTD -SECCOMP +BLKID -ELFUTILS +KMOD -IDN2 -IDN -PCRE2 default-hierarch y=hybrid) > > W[ 2.442307] systemd[1]: Detected architecture arm64. > elcome to Auto Linux BSP 33.0 (gatesgarth)! > > [ 2.484975] systemd[1]: Set hostname to . > [ 2.577683] systemd-sysv-generator[76]: SysV service '/etc/init.d/netperf' la cks a native systemd unit file. Automatically generating a unit file for compati bility. Please update package to include a native systemd unit file, in order to make it more safe and robust. > [ 2.766744] systemd[1]: /lib/systemd/system/xen-qemu-dom0-disk-backend.servic e:11: PIDFile= references a path below legacy directory /var/run/, updating /var /run/xen/qemu-dom0.pid → /run/xen/qemu-dom0.pid; please update the unit file acc ordingly. > [ OK [ 2.849603] systemd[1]: Queued start job for default target Multi-User System. > random: systemd: uninitialized urandom read (16 bytes read) > [[ 2.851615] systemd[1]: Created slice system-getty.slice. > 0m] Created slice system-getty.slice. > [ OK ] Created slice sy[ 2.884743] random: systemd: uninitialized urandom r ead (16 bytes read) > s[ 2.885064] systemd[1]: Created slice system-modprobe.slice. > tem-modprobe.slice. > [ OK ] Created slice sys[ 2.912705] random: systemd: uninitialized urandom read (16 bytes read) > t[ 2.913002] systemd[1]: Created slice system-serial\x2dgetty.slice. > em-serial\x2dgetty.slice. > [ OK ] Created slice Use[ 2.940962] systemd[1]: Created slice User and Sess ion Slice. > r and Session Slice. > [ OK ] Started Dispatch P[ 2.960876] systemd[1]: Started Dispatch Password Requests to Console Directory Watch. > assword …ts to Console Directory Watch. > [ OK ] Started Forward Pas[ 2.988824] systemd[1]: Started Forward Password Requests to Wall Directory Watch. > sword R…uests to Wall Directory Watch. > [ OK ] Reached target Path[ 3.012877] systemd[1]: Reached target Paths. > s. > [ OK ] Reached target Remot[ 3.032754] systemd[1]: Reached target Remote Fi le Systems. > e File Systems. > [ OK ] Reached target Slice[ 3.052744] systemd[1]: Reached target Slices. > s. > [ OK ] Reached target Swap systemd[1]: Reached target Swap. > [0m. > [ OK systemd[1]: Listening on RPCbind Server Activation Socket. > [0m] Listening on RPCbind Server Activation Socket. > [ OK ] Reached target RPC [ 3.124844] systemd[1]: Reached target RPC Port M apper. > Port Mapper. > [ OK ] Listening on Sy[ 3.145153] systemd[1]: Listening on Syslog Socket. > slog Socket. > [ OK ] Listening on initc[ 3.164886] systemd[1]: Listening on initctl Compa tibility Named Pipe. > tl Compatibility Named Pipe. > [ OK 3.191035] systemd[1]: Condition check resulted in Journal Audit Socke t being skipped. > m[ 3.191496] systemd[1]: Listening on Journal Socket (/dev/log). > ] Listening on Journal Socket (/dev/log). > [ OK ] Listening on Jou[ 3.221106] systemd[1]: Listening on Journal Socket. > rnal Socket. > [ OK ] Listening on Ne[ 3.241190] systemd[1]: Listening on Network Service Netlink Socket. > twork Service Netlink Socket. > [ OK ] Listening on ude[ 3.265051] systemd[1]: Listening on udev Control So cket. > v Control Socket. > [ OK ] Listening on udev [ 3.284919] systemd[1]: Listening on udev Kernel S ocket. > Kernel Socket. > [ OK ] Listening on User [ 3.304936] systemd[1]: Listening on User Database Manager Socket. > Database Manager Socket. > Mounting H[ 3.330591] systemd[1]: Mounting Huge Pages File System... > uge Pages File System... > Mounting 3.353156] systemd[1]: Condition check resulted in POSIX Me ssage Queue File System being skipped. > ;39mMount /proc/xen files... > [ 3.354954] systemd[1]: Mounting Mount /proc/xen files... > [ 3.370933] systemd[1]: Mounting Kernel Debug File System... > Mounting Kernel Debug File System... > Starti[ 3.401191] systemd[1]: Condition check resulted in Kernel Tra ce File System being skipped. > ng Load Kernel Module con[ 3.401679] systemd[1]: Condition check resulted in Create list of static device nodes for the current kernel being skipped. > fi[ 3.403642] systemd[1]: Starting Load Kernel Module configfs... > gfs... > Starting 3.446771] systemd[1]: Starting Load Kernel Module drm... > 9mLoad Kernel Module drm... > Starting 3.470771] systemd[1]: Starting Load Kernel Module fuse... > 9mLoad Kernel Module fuse... > Starting 3.494788] systemd[1]: Starting RPC Bind... > 9mRPC Bind... > [ 3.513000] systemd[1]: Condition check resulted in File System Check on Root Device being skipped. > Starting Jour[ 3.516455] systemd[1]: Starting Journal Service... > nal Service... > [ 3.548101] systemd[1]: Starting Load Kernel Modules... > Starting Load Kernel Modules... > Starting 3.570819] systemd[1]: Starting Remount Root and Kernel Fil e Systems... > 9mRemount Root and Kernel File Systems... > [ 3.595018] systemd[1]: Starting Coldplug All udev Devices... > Starting Coldplug All udev Devices... > [ 3.632457] llce_core 43ff8000.llce: Successfully loaded LLCE firmware > [ 3.639641] systemd[1]: Started RPC Bind. > 32m OK ] Started RPC Bind. > [ 3.651233] EXT4-fs (mmcblk0p2): re-mounted. Opts: (null) > [ 3.706544] systemd[1]: Mounted Huge Pages File System. > 32m OK ] Mounted Huge Pages File System. > [ 3.729184] systemd[1]: Mounted Mount /proc/xen files. > 32m OK ] Mounted Mount /proc/xen files. > [ OK ] Started Journa[ 3.749158] systemd[1]: Started Journal Service. > l Service. > [ OK ] Mounted Kernel Debug File System. > [ OK ] Finished Load Kernel Module configfs. > [ OK ] Finished Load Kernel Module drm. > [ 3.804694] llce_mb 43a00000.llce_mb: LLCE firmware version: GGEE_3A > [ 3.804711] llce_mb 43a00000.llce_mb: LLCE firmware: logging support disabled > [ OK ] Finished Load Kernel Module fuse. > [ OK ] Finished Remount Root and Kernel File Systems. > Mounting FUSE Control File System... > Mounting Kernel Configuration File System... > [ 3.916363] llce_can: unknown parameter 'logging' ignored > Starting Flush Journal to Persistent Storage... > Starting Create Static Device Nodes in /dev... > [ OK ] Mounted FUSE Control File System. > [ OK ] Finished Load Kernel Modules. > [ OK ] Mounted Kernel Configuration File System. > [ OK ] Finished Flush Journal to Persistent Storage. > [ OK ] Finished Create Static Device Nodes in /dev. > [ OK ] Reached target Local File Systems (Pre). > Mounting NFSD configuration filesystem... > Mounting /tmp... > Mounting mount xenstore file system... > Mounting /var/volatile... > Starting Apply Kernel Variables... > Starting Rule-based Manage…for Device Events and Files... > [ OK ] Finished Coldplug All udev Devices. > [FAILED] Failed to mount NFSD configuration filesystem. > See 'systemctl status proc-fs-nfsd.mount' for details. > [DEPEND] Dependency failed for NFS server and services. > [DEPEND] Dependency failed for NFS Mount Daemon. > [ OK ] Started Rule-based Manager for Device Events and Files. > [ OK ] Mounted /tmp. > [ OK ] Mounted mount xenstore file system. > [ OK ] Mounted /var/volatile. > [ OK ] Finished Apply Kernel Variables. > Mounting /var/volatile/tmp... > Starting Load/Save Random Seed... > [ OK ] Mounted /var/volatile/tmp. > [ OK ] Reached target Local File Systems. > Starting Create Volatile Files and Directories... > [ OK ] Finished Create Volatile Files and Directories. > [ 5.060091] pfeng: loading out-of-tree module taints kernel. > [ 5.087732] pfeng 46000000.pfe: PFEng ethernet driver loading ... > [ 5.087749] pfeng 46000000.pfe: Version: RTM 1.0.0 > [ 5.087753] pfeng 46000000.pfe: Multi instance support: disabled (standalone) > [ 5.087756] pfeng 46000000.pfe: Compiled by: 10.2.0 > [ 5.087783] pfeng 46000000.pfe: Cbus addr 0x46000000 size 0x1000000 > [ 5.087791] pfeng 46000000.pfe: nxp,fw-class-name: s32g_pfe_class.fw > [ 5.087796] pfeng 46000000.pfe: nxp,fw-util-name: s32g_pfe_util.fw > [ 5.087848] pfeng 46000000.pfe: irq 'hif0' : 58 > [ 5.087862] pfeng 46000000.pfe: irq 'hif1' : 59 > [ 5.087874] pfeng 46000000.pfe: irq 'hif2' : 60 > [ 5.087879] pfeng 46000000.pfe: HIF channels mask: 0x0007 > [ 5.087890] pfeng 46000000.pfe: netif name: pfe0 > [ 5.087896] pfeng 46000000.pfe: DT mac addr: 00:01:be:be:ef:11 > [ 5.087903] pfeng 46000000.pfe: netif(pfe0) mode: std > [ 5.087908] pfeng 46000000.pfe: netif(pfe0) EMAC: 0 > [ 5.087914] pfeng 46000000.pfe: netif(pfe0) HIFs: count 1 map 01 > [ 5.087923] pfeng 46000000.pfe: EMAC0 interface mode: 4 > [ 5.088060] pfeng 46000000.pfe: PFE port coherency enabled, mask 0x1e > [ 5.088249] pfeng 46000000.pfe: Clocks: sys=300MHz pe=600MHz > [ 5.088263] pfeng 46000000.pfe: Interface selected: EMAC0: 0x4 EMAC1: 0xfffff fff EMAC2: 0xffffffff > [ 5.120057] pfeng 46000000.pfe: PFE controller reset done > [ 5.120169] pfeng 46000000.pfe: TX clock on EMAC0 for interface sgmii install ed > [ 5.120219] pfeng 46000000.pfe: RX clock on EMAC0 for interface sgmii install ed > [ 5.120556] pfeng 46000000.pfe: assigned reserved memory node pfebufs@3400000 0 > [ 5.129221] pfeng 46000000.pfe: assigned reserved memory node pfebufs@34 080000 > Starting Network Time Synchronization... > [ 5.129320] pfeng 46000000.pfe: assigned reserved memory node pfebufs@8320000 0 > [ 5.129353] pfeng 46000000.pfe: assigned reserved memory node pfebufs@83 5e0000 > Starting Update UTMP about System Boot/Shutdown... > [ 5.137731] pfeng 46000000.pfe: Firmware: CLASS s32g_pfe_class.fw [39860 byte s] > [ 5.137746] pfeng 46000000.pfe: Firmware: UTIL s32g_pfe_util.fw [19940 bytes] > 32m OK ] Finished Update UTMP about System Boot/Shutdown. > [ 5.137765] pfeng 46000000.pfe: PFE CBUS p0x46000000 mapped @ v0xffffffc01300 0000 > [ 5.137781] pfeng 46000000.pfe: HW version 0x101 > [ 5.137788] pfeng 46000000.pfe: Silicon S32G3 > [ 5.137795] pfeng 46000000.pfe: Fail-Stop mode disabled > [ 5.139219] pfeng 46000000.pfe: BMU1 buffer base: p0xc0000000 > [ 5.139318] pfeng 46000000.pfe: BMU2 buffer base: p0x34000000 (0x80000 bytes) > [ 5.140631] pfeng 46000000.pfe: register IRQ 62 by name 'PFE BMU IRQ' > [ 5.173797] pfeng 46000000.pfe: BMU_EMPTY_INT (BMU @ p0x(____ptrval____)). Po ol ready. > [ 5.173819] pfeng 46000000.pfe: BMU_EMPTY_INT (BMU @ p0x(____ptrval____)). Po ol ready. > [ 5.173857] pfeng 46000000.pfe: Firmware .elf detected > 32m OK ] Started Network Time Synchronization 5.173864] pfeng 46000000.pfe: Uploading CLASS firmware > 0m. > [ 5.173871] pfeng 46000000.pfe: Selected FW loading OPs to load 8 PEs in para llel > [ 5.341346] pfeng 46000000.pfe: pfe_ct.h file version"e1cb376b67fa4d1de800b13 2b328b42c" > [ 5.383695] pfeng 46000000.pfe: [FW VERSION] 1.3.0, Build: May 31 2022, 08:22 :22 (), ID: 0x31454650 > [ 5.384015] pfeng 46000000.pfe: SAFETY instance created > 32m OK ] Reached target System Initialization 5.384025] pfeng 46000000.pfe: Watchdog instance created > 0m. > [ 5.384038] pfeng 46000000.pfe: Uploading UTIL firmware > [ 5.384043] pfeng 46000000.pfe: Selected FW loading OPs to load 1 PEs in para llel > 32m OK ] Started Daily Cleanup of Temporary Directories. > [ 5.396834] pfeng 46000000.pfe: pfe_ct.h file version"e1cb376b67fa4d1de800b13 2b328b42c" > [ 5.410446] pfeng 46000000.pfe: VLAN ID incorrect or not set. Using default V LAN ID = 0x01. > 32m OK ] Reached target System Time Set. > [ 5.410452] pfeng 46000000.pfe: VLAN stats size incorrect or not set. Using d efault VLAN stats size = 20. > [ 5.410544] pfeng 46000000.pfe: Fall-back bridge domain @ 0x20000a34 (class) > [ 5.410551] pfeng 46000000.pfe: Default bridge domain @ 0x20000a2c (class) > [ 5.416680] pfeng 46000000.pfe: Routing table created, Hash Table @ p0x340800 00, Pool @ p0x34088000 (65536 bytes) > [ 5.416989] pfeng 46000000.pfe: Feature err051211_workaround: DISABLED > 32m OK ] Reached target System Time Synchronized. > [ 5.418364] pfeng 46000000.pfe: MDIO bus 0 disabled: Not found in DT > [ 5.418370] pfeng 46000000.pfe: MDIO bus 1 disabled: No EMAC > [ 5.418374] pfeng 46000000.pfe: MDIO bus 2 disabled: No EMAC > 32m OK ] Started Daily rotation of log files. > [ 5.418705] pfeng 46000000.pfe: HIF0 enabled > [ 5.418967] pfeng 46000000.pfe: HIF1 enabled > [ 5.419229] pfeng 46000000.pfe: HIF2 enabled > [ 5.419235] pfeng 46000000.pfe: HIF3 not configured, skipped > 32m OK ] Reached target Timers. > [ 5.424471] pfeng 46000000.pfe pfe0: registered > [ 5.424496] pfeng 46000000.pfe pfe0: Subscribe to HIF0 > 32m OK ] Listening on D-Bus System Message Bus[ 5.425044] pfeng 46000000.pf e pfe0: Enable HIF0 > Socket. > [ 5.425207] pfeng 46000000.pfe pfe0: setting MAC addr: 00:01:be:be:ef:11 > [ 5.425234] pfeng 46000000.pfe pfe0: PTP HW addend 0x80000000, max_adj c onfigured to 46566128 ppb > Starting sshd.socket. > [ 5.425243] pfeng 46000000.pfe: IEEE1588: Input Clock: 200000000Hz, Output: 1 00000000Hz, Accuracy: 10.0ns > [ 5.431115] pfeng 46000000.pfe pfe0: Registered PTP HW clock successfully on EMAC0 > [ OK ] Listening on sshd.socket. > [ OK ] Reached target Sockets. > [ OK ] Reached target Basic System. > [ OK ] Started Job spooling tools. > [ OK ] Started Periodic Command Scheduler. > [ OK ] Started D-Bus System Message Bus. > [ OK ] Started A minimalistic net…Pv4, rdisc and DHCPv6 support. > Starting IPv6 Packet Filtering Framework... > Starting IPv4 Packet Filtering Framework... > [ OK ] Started irqbalance daemon. > [ OK ] Started Hardware RNG Entropy Gatherer Daemon. > [ OK ] Started strongSwan IPsec I…IKEv2 daemon using ipsec.conf. > [ 6.625086] random: crng init done > [ 6.625101] random: 7 urandom warning(s) missed due to ratelimiting > [ OK ] Started System Logging Service. > Starting User Login Management... > Starting The Xen xenstore... > Starting OpenSSH Key Generation... > [ OK ] Finished Load/Save Random Seed. > [ OK ] Finished IPv6 Packet Filtering Framework. > [ OK ] Finished IPv4 Packet Filtering Framework. > [ OK ] Reached target Network (Pre). > Starting Network Service... > [FAILED] Failed to start The Xen xenstore. Yep, this is the problem > See 'systemctl status xenstored.service' for details. > [DEPEND] Dependency failed for xen-…des, JSON configuration stub). > [DEPEND] Dependency failed for Xenc…guest consoles and hypervisor. > [DEPEND] Dependency failed for Xend…p guests on boot and shutdown. > [DEPEND] Dependency failed for qemu for xen dom0 disk backend. > [ OK ] Started Network Service. > [ OK ] Finished OpenSSH Key Generation. > [ OK ] Started User Login Management. > Starting Network Name Resolution... > Starting Xen-watchdog - run xen watchdog daemon... > [ OK ] Started Xen-watchdog - run xen watchdog daemon. > [ OK ] Started Network Name Resolution. > [ OK ] Reached target Network. > [ OK ] Reached target Host and Network Name Lookups. > [ OK ] Started NFS status monitor for NFSv2/3 locking.. > [ OK ] Started Respond to IPv6 Node Information Queries. > [ OK ] Started Network Router Discovery Daemon. > Starting Permit User Sessions... > [ OK ] Started Xinetd A Powerful Replacement For Inetd. > [ OK ] Finished Permit User Sessions. > [ OK ] Started Getty on tty1. > [ OK ] Started Serial Getty on hvc0. > [ OK ] Started Serial Getty on ttyLF0. > [ OK ] Reached target Login Prompts. > [ OK ] Reached target Multi-User System. > Starting Update UTMP about System Runlevel Changes... > [ OK ] Finished Update UTMP about System Runlevel Changes. > > 33.Auto Linux vb3 3t.LFs32g399aevb3 hvc0 > > > >Some extra information about xenstore: > > root@s32g399aevb3:~# systemctl status xenstored.service > * xenstored.service - The Xen xenstore > Loaded: loaded (/lib/systemd/system/xenstored.service; enabled; vendor pre> > Active: failed (Result: protocol) since Wed 2020-12-16 17:25:20 UTC; 6min > > Process: 182 ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities (co> > Process: 186 ExecStart=/etc/xen/scripts/launch-xenstore (code=exited, statu> > Main PID: 186 (code=exited, status=0/SUCCESS) > > Dec 16 17:25:20 s32g399aevb3 systemd[1]: Starting The Xen xenstore... > Dec 16 17:25:20 s32g399aevb3 launch-xenstore[186]: Starting /usr/sbin/xenstored> > Dec 16 17:25:20 s32g399aevb3 launch-xenstore[193]: FATAL: Failed to open connec> This has been truncated, but I bet there is a missing module in your Linux kernel build. Make sure you have all the following: CONFIG_XEN_BALLOON=y CONFIG_XEN_BALLOON_MEMORY_HOTPLUG=y CONFIG_XEN_SCRUB_PAGES_DEFAULT=y CONFIG_XEN_DEV_EVTCHN=y CONFIG_XEN_BACKEND=y CONFIG_XENFS=y CONFIG_XEN_COMPAT_XENFS=y CONFIG_XEN_SYS_HYPERVISOR=y CONFIG_XEN_XENBUS_FRONTEND=y CONFIG_XEN_GNTDEV=y CONFIG_XEN_GRANT_DEV_ALLOC=y CONFIG_XEN_GRANT_DMA_ALLOC=y CONFIG_SWIOTLB_XEN=y CONFIG_XEN_PRIVCMD=y > Dec 16 17:25:20 s32g399aevb3 systemd[1]: xenstored.service: Failed with result > > Dec 16 17:25:20 s32g399aevb3 systemd[1]: Failed to start The Xen xenstore. > > > >Any idea of how can I fix that? Thank you so much for the support > > Best regards > Youssef El Mesdadi > > > > -----Ursprüngliche Nachricht----- > Von: Julien Grall > Gesendet: Dienstag, 17. Januar 2023 15:38 > An: El Mesdadi Youssef ESK UILD7 ; xen-devel@lists.xenproject.org > Cc: Stefano Stabellini > Betreff: Re: AW: Xenalyze on ARM ( NXP S32G3 with Cortex-A53) > > > > On 13/01/2023 12:56, El Mesdadi Youssef ESK UILD7 wrote: > > Hello Julien, > > Hi, > > >>>> xentrace should work on upstream Xen. What did you version did you try? > > > > While building my image using the BSP-linux of NXP, the version that was downloaded is Xen 4.14. > > Do you know where the source are downloaded from? > > > > > > >>>> Can you also clarify the error you are seen? > > > > The error I receive while tipping xentrace is: Command not found. > > > "Command not found" means the program hasn't been installed. > > > I assume in this Xen version, Xentrace is not compatible with ARM > > architecture > The support for xentrace on Arm has been added around Xen 4.12. So it should work for Xen 4.14 (even though I don't recommend using older release). > > I would suggest to check how you are building the tools and which package will be installed. > > > > > My question is, is there any new version of Xen that supports Xentrace on ARM? If yes how could I install it? Because Xen.4.14 was installed automatically by typing this ( DISTRO_FEATURES_append += "xen") in the local.conf file while creating my image. > > I am not familiar with the BSP-linux of NXP as this is not a project maintained by Xen Project. > > If you need support for it, then I would suggest to discuss with NXP directly. > > > > > Or is there any source on Xentrace that is compatible with ARM on GitHub, that I could download and compile myself? > Even if the hypervisor is Xen, you seem to use code provided by an external entity. I can't advise on the next steps without knowing the modification that NXP made in the hypervisor. > > > > >>>> Yes if you assign (or provide para-virtualized driver) the GPIO/LED/Can-Interface to the guest. > > > > Is there any tutorial that could help me create those drivers? And how complicated is that, to create them? > > I am not aware of any tutorial. Regarding the complexity, it all depends on what exactly you want to do. > > > Or can they be assigned just with PCI-Passthrough? > > PCI passthrough is not yet supported on Arm. That said, I was not expecting the GPIO/LED/Can-interface to be PCI devices. > > If they are platform devices (i.e non-PCI devices), then you could potentially directly assign them to *one* guest (this would not work if you need to share them). > > I wrote potentially because if the device is DMA-capabable, then the device must be behind an IOMMU. > > Cheers, > > -- > Julien Grall > > --8323329-2097830747-1676076969=:4661-- From xen-devel-bounces@lists.xenproject.org Sat Feb 11 05:20:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 05:20:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493705.763802 (Exim 4.92) (envelope-from ) id 1pQiJM-00045l-1a; Sat, 11 Feb 2023 05:20:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493705.763802; Sat, 11 Feb 2023 05:20:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQiJL-00045h-UD; Sat, 11 Feb 2023 05:20:31 +0000 Received: by outflank-mailman (input) for mailman id 493705; Sat, 11 Feb 2023 00:06:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQdPK-00065i-Uv for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 00:06:23 +0000 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e87cabe8-a99f-11ed-933c-83870f6b2ba8; Sat, 11 Feb 2023 01:06:19 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2023 16:06:17 -0800 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2023 16:06:17 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 10 Feb 2023 16:06:16 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 10 Feb 2023 16:06:16 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 10 Feb 2023 16:06:16 -0800 Received: from MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) by CY8PR11MB7267.namprd11.prod.outlook.com (2603:10b6:930:9a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Sat, 11 Feb 2023 00:06:12 +0000 Received: from MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536]) by MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536%3]) with mapi id 15.20.6086.019; Sat, 11 Feb 2023 00:06:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e87cabe8-a99f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676073979; x=1707609979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1+f4QBcpN59TQ8NjHjhFmaLNd5JqBHEgtwqaH4WDH0g=; b=bd4XxwqZTfV4P8kpeeXXxNJvXjg0cUp6S6biYFDE8HZ0eFY2SXmc30o7 NNw2pcHU0uxVSQgrP3w01Zx7YCpTqn1nepKuJkEazQ83Hbk3cVeOkO8ON OiPvEUqQVOT2KPHLXgQMJc43lg5bI/MJNNK2txt8bYuwcHWhcRQZIVHzR JCjR2LFmsCYP0a9SDkkba/2+epY3AuyZCTcGLP7fhCZbTQRdbFxeEB3Sf 0aPlLo1GadQCBMje3XzacElW+4VCNN+f+gI6oDzgHi4F35MtusGxyMbkw xEXEbNMjrbCiNVLXC6oweZAhTIlyKh9Ukj2ZMCaAkiF6IPahTGkPw9iGG Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="331863672" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="331863672" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="756956906" X-IronPort-AV: E=Sophos;i="5.97,287,1669104000"; d="scan'208";a="756956906" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fuMW1FFVU96A3zS+9WSXt6hl7KGxsR0S7QGs6DOZ71shMF9/ChDtw/1LlUWKQpqDfMRWoNstjvvKCnHXWBJMmUTmtx3sL8dKKv3A8po0HU0ymZ8fF14SkDl8DA74auOlAsxAJce5ODaWXqQ5MpYJacAqZcphIQVI+aGp6sK6wA/FBE70GV+Lvrixi1NMWy3FTerBzNamy58diUSUg5Qs4p3dhqmlYTCYiBmjWgueCyf38QuRVoh/12Wm/tKZkbyl6cg2tnoRkXYgsheGlVrepMvoQ5OxShIQVlrMwVxKMUWZ9s7awQ4g9/kIZpiEUf2R2PAza+sYPU6SDNqryvAL3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+f4QBcpN59TQ8NjHjhFmaLNd5JqBHEgtwqaH4WDH0g=; b=jp4vcMAX3r++wdyrYLRDhklJe/jMfaEEcQILOnbyVQV/s6MOuWo81XFUPjs/+PIThGaKSNjDUgaOJCAJX/aHnuAYO0zurxAZRkKV2p8kyabLq2UjzsybfXhPd2mc3XvP+SpHBCBWcgTW7Re5IN/6tuu60KPoySmDnEhdZhPZmESDNnrKMUuq8Hz8ETAiN0Y+xgjB5MkASvYjiqB+6Ms8b0cXPdhNYMV14mTs2257SxKk5xS0cM5tTITJHizzJbOGwKmj0Rj6tydp8m3H8mBoHWRblPRpaEdtFOMLlq62HezXUQHnbdCdXU1bzg/W3snH4Mu+q9koUUh8mP+aVR5L7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Edgecombe, Rick P" To: "linux-kernel@vger.kernel.org" , "Gross, Jurgen" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" CC: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "lists@nerdbynature.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Thread-Topic: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Thread-Index: AQHZPaym1OeQ0uPDs0uotDA3o+cSyA== Date: Sat, 11 Feb 2023 00:06:11 +0000 Message-ID: References: <20230209072220.6836-1-jgross@suse.com> In-Reply-To: <20230209072220.6836-1-jgross@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1392:EE_|CY8PR11MB7267:EE_ x-ms-office365-filtering-correlation-id: f49b9f44-5d88-4e61-dc95-08db0bc3c8d8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B9uaqAUg7gYxRXI58MgbrQWbg/ndyPjD8yWRG9k9+MoGpDym+4aQp0mwV7yB3qdGIpL63cPkxUi5RoXcX8LSuUztej9LyNRwXHolmj91Ry+FSa3WR3LEQECzOjg8BTZ6uZIv8YlEW5iymysfbm8NcSHchBhHnRXRyYAiim6lN1wx1bvVhx6WIql02/O57mCtcyRdO/bIsSr1o/9HiDW02K8GQNy9e0j/d9nTTwb8SzhIZnBanJHNqE312Bx8ak7QBHzSroIicfOCbsfJwsOTkS41Jonz6iv+FrBrVmi5+twldzZJOKcQVcOL4BQdqXuYyV/szYllfXeUpkvhn6tpreFGvI8LnD8TLEoTHaBDlkfDjjriYjSkkJtHBOlyvGNN6KTMuVt7YqZLoNG3xdgy8xwEX22p5dMfw7T/jFpkIDrM2+gLGCGR5peMHZQZWxiZDTArsuHy0KeivVghmPvxX3cXVN7TCGzfilt9i0Hf6ICHI84PE600sL0PjhPTeA/szSoEE1+kO12XGx5Mi4sbBV1nBBAlBS0QjflZaHoYg+9Mq/L5R8O3bG645g/2PZ+3vsikLgfFO90AnJIdlclM+i6EunTi8LUgsFI/k5r9jFB/sm00VONcHYdEQFl5p/0xVmL6qXl6CWbYhfIqtvKzm/1LdUtWXFAw+C5urkdpehNEAbrHg99LvLq805l5fXv4HstauPPBs5PAxX5/NY46JVFTBQmalvtzoKiBPmrICFY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1392.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(346002)(396003)(366004)(39860400002)(451199018)(36756003)(38070700005)(122000001)(38100700002)(82960400001)(26005)(86362001)(6512007)(2616005)(83380400001)(71200400001)(186003)(6506007)(45080400002)(478600001)(6486002)(7416002)(91956017)(316002)(110136005)(8936002)(41300700001)(66476007)(5660300002)(54906003)(2906002)(64756008)(66446008)(76116006)(4326008)(66946007)(8676002)(66556008)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q2Q0SUZXMzAxb2VHcThLZDFwSEpZUW1Mcm52UWFTOFdPTSs1L2ZzM1VSQmJW?= =?utf-8?B?aktPZFR2UXN0ajZob2lnTFpyay9TdTBKT2tmQklqWmxwWUM0eTBOZVZPNUN3?= =?utf-8?B?U0NmRk9rVXRxb053Y3RycUFrTWVUK0Y3ZkFFUWJJZTFEUGI0eFlhbzRqVmUv?= =?utf-8?B?N0FJT1VZUkxlOGRvcUx3R1dwdlZGZEQxaHBMSWl1cDJkOXB4SXMyV3R6OUtz?= =?utf-8?B?RGVva0liRlZMc3Frd2U0d2NtY0JJNGdnMnBQRkg1TW9OcUU3dnlUc2RSTWlK?= =?utf-8?B?dDNNR1pSZmI1ZWw5OUhnODZNTTJ2dDZDbldUZFhuZVh0S1JVZXgvS3pmR2I0?= =?utf-8?B?TW9sOHdFVTRMQmRGSmhuS2ZVUUhoU2k2TmhvOHJuaXlyUmh5N3prWjZKbzc4?= =?utf-8?B?N0N1Zk9nL25wajFhVDB5TnVhRlpKZGZ1V2JnUWZqbGFsd29RT0NHc21SY1JG?= =?utf-8?B?a2x6WmFHNGdaTHdsSXcrcmozWXM0YWd3QSs5ZUhMK0w4NjZXb1g1bzladURO?= =?utf-8?B?bDhhaG5OV3QwcTBPQ044N2h0S081VGFpQURCVFdOR2o5amxaVXQyNW9YdTVo?= =?utf-8?B?OEIwMitobVZsbjNQVmVMMjZFOVhUNEs4Wm9aQXpTQTZyS2hRMWNKZER4bUQ2?= =?utf-8?B?R1pBakg5ZXBjTWcxc2xTeHBYNkkxemlwRm9Pc2VvZW94cC8rOFdqeThBeDUz?= =?utf-8?B?N3k0YmtRRnlLOFp2WW1iNW5wSys0d0tjZTVKTTVIcm1zNXgydWM0ZzNTYS9n?= =?utf-8?B?ekRNL2dCNW41Z3hwZmhPTVJDZVdaOW1QTTFsQWU2bVQ4T1Y5N3VHaFlwcitq?= =?utf-8?B?Nk43S1NwaVNqYk11bFNjTnBKZGFBcDB2dGF3d2pIdmRWQjg1VWk1VTBvZUx5?= =?utf-8?B?OUh4OVEydWFSQUdlZTIrcWpTeExUVnIreDBNVWMrZ2ZiUlRuRVAvR2tWcEx5?= =?utf-8?B?UG84dWVBREhmU0dZMC9Cdk1kOFZxZU9zdjJNRlRzNkM2M0k0MG5iRTMxZDU0?= =?utf-8?B?blliZENjaS9mdEdFWUFlY1VaUHV4dGZOYVZwZ2NnYXdBa0RNaVlwQkNSSmZI?= =?utf-8?B?dzBYNU82TU15L1RFRFNMZno2eXQ5eTVlUXdlbXJaRXVtQmFtQTlLbEIxbVVB?= =?utf-8?B?V2ZCTm9nK1E2TndVaHphZlVPMUhuUWlONjRkQXVNSkF5aDR1QnUrZURIVEtX?= =?utf-8?B?UzBiQmttbnNIVjZzV29RYTY3MDNHRUtFaDlkK3crbGo5OVJ5TjNKMHBma2dw?= =?utf-8?B?VWpjVjFFSjRGSGxueWhMdHVTaDRzWVYxZWtnekpkMjRBaHBzV2FLVlRkTmNL?= =?utf-8?B?QVY2L0RuNXJieEp0b0tBSDdpYW5HYThLNHp0aWJ1RCtCTi85bzdheWc0Ti9m?= =?utf-8?B?bTNmekVtNmd6OFpkZ3Nwd2FTK3ZPTTZ2RnkrLzMraDFhbWx6UkJaOGY1OXV5?= =?utf-8?B?bmx5R1dtL2pWRVBDRVJCUFlGMDdRY1JWYVlkVExXcDRKZHRVYWZNU0VKM2ln?= =?utf-8?B?ZUdkQ3pmREwwRHJ6OHNPSEJKVUJzTXB6L050RzlMV2VoYkkzRDBQTUprSlpX?= =?utf-8?B?TGdBcFlxN1J4aTk0bms1dkVBemttZGZWZmV5QWVmeFl4QjNvRGFpTW9UVnho?= =?utf-8?B?MzEwWXBYUTlTUFVUTGE3L3hMUFVUT2Z5alZMTXZVSElvMEVTSHRGODdMNXBW?= =?utf-8?B?NUdsS3E5alZhUjU4SjZnRFR1Z0w1NitMZW82SytOVjVlSzJBZmtaRTVaaDhX?= =?utf-8?B?eituMVNCQW1tN1V0VW5McEJQTGpnWWdMdk90MzV1SFUxSlZuTkhqU3U5REpZ?= =?utf-8?B?TXFZY3ZlY1kwUHhHYk9vOU02QmFGYmxWekpPbUpFbEhqdE9ZQnFxSG5YWG5l?= =?utf-8?B?M3l6Ty9vUXlTNTJZd0lYaENSdTE5RXVQTytzK0V6bmovM0xjb25nQjhLK3h0?= =?utf-8?B?ZURoZUtMbmROa1NnYk9SM29aUjV4ZXM5aDlkRmd2MnErNDhHMVh3ZGoybjNx?= =?utf-8?B?TkhWUEVYTjlwNi81aVVYSjdKalVxWXdJcWh0U1g3eHJGejRSSFM0TFJBeVZi?= =?utf-8?B?L1FpczBUQzRnSlRZb2ZhYWhxbzExRmNPYmVRQnIyOWtxT1NVUkR4YmlxdFR2?= =?utf-8?B?TVpJVzJTTWM1dENBNUYrVFlJMndJRmRmRjN2ZDVmYWxVMHc4UmdpY0VBNU82?= =?utf-8?Q?WTg5Ls2AZJGmsTkVHYIs9AU=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <6F2A589DF42C7A438427AE7894A5CA82@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1392.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f49b9f44-5d88-4e61-dc95-08db0bc3c8d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2023 00:06:11.8928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZJKg5VkUFmUggFaBGgklu5KRpG0ZxIdbkZy2OAB6Y9tZXh9A0aPZRus1mSD99C39CYZ5+6zprlLAbHZY8bgtLFkHGKtZV6NJvr8vK8ZI7r0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7267 X-OriginatorOrg: intel.com T24gVGh1LCAyMDIzLTAyLTA5IGF0IDA4OjIyICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K PiBUaGlzIHNlcmllcyB0cmllcyB0byBmaXggdGhlIHJhdGhlciBzcGVjaWFsIGNhc2Ugb2YgUEFU IGJlaW5nDQo+IGF2YWlsYWJsZQ0KPiB3aXRob3V0IGhhdmluZyBNVFJScyAoZWl0aGVyIGR1ZSB0 byBDT05GSUdfTVRSUiBiZWluZyBub3Qgc2V0LCBvcg0KPiBiZWNhdXNlIHRoZSBmZWF0dXJlIGhh cyBiZWVuIGRpc2FibGVkIGUuZy4gYnkgYSBoeXBlcnZpc29yKS4NCg0KZGVidWdfdm1fcGd0YWJs ZSBmYWlscyBpbiBhIEtWTSBndWVzdCB3aXRoIENPTkZJR19NVFJSPXkuIENPTkZJR19NVFJSPW4N CnN1Y2NlZWRzLg0KDQpbICAgIDAuODMwMjgwXSBkZWJ1Z192bV9wZ3RhYmxlOiBbZGVidWdfdm1f cGd0YWJsZSAgICAgICAgIF06DQpWYWxpZGF0aW5nIGFyY2hpdGVjdHVyZSBwYWdlIHRhYmxlIGhl bHBlcnMNClsgICAgMC44MzE5MDZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t LQ0KWyAgICAwLjgzMjcxMV0gV0FSTklORzogQ1BVOiAwIFBJRDogMSBhdCBtbS9kZWJ1Z192bV9w Z3RhYmxlLmM6NDYxDQpkZWJ1Z192bV9wZ3RhYmxlKzB4YjlhLzB4ZTE2DQpbICAgIDAuODMzOTk4 XSBNb2R1bGVzIGxpbmtlZCBpbjoNClsgICAgMC44MzQ0NTBdIENQVTogMCBQSUQ6IDEgQ29tbTog c3dhcHBlci8wIE5vdCB0YWludGVkIDYuMi4wLXJjNysNCiMyMzY2DQpbICAgIDAuODM1NDYyXSBS SVA6IDAwMTA6ZGVidWdfdm1fcGd0YWJsZSsweGI5YS8weGUxNg0KWyAgICAwLjgzNjIxN10gQ29k ZTogZTIgM2EgNzMgNGEgNDggYzcgMDAgMDAgMDAgMDAgMDAgNDggOGIgYjQgMjQgYTAgMDANCjAw IDAwIDQ4IDhiIDU0IDI0IDYwIDQ4IDhiIDdjIDI0IDIwIDQ4IGM0DQpbICAgIDAuODM5MDY4XSBS U1A6IDAwMDA6ZmZmZmM5MDAwMDAxM2RlMCBFRkxBR1M6IDAwMDEwMjQ2DQpbICAgIDAuODM5NzM1 XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiBmZmZmODg4MTAwMDQ4ODY4IFJDWDoNCmJmZmZm ZmZmZmZmZmZmZjANClsgICAgMC44NDA2NDZdIFJEWDogMDAwMDAwMDAwMDAwMDAwMCBSU0k6IDAw MDAwMDAwNDAwMDAwMDAgUkRJOg0KMDAwMDAwMDAwMDAwMDAwMA0KWyAgICAwLjg0MTY2MV0gUkJQ OiBmZmZmODg4MTAwMDRkMTQwIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6DQpmZmZmODg4MTAw MjgwODgwDQpbICAgIDAuODQyNjI1XSBSMTA6IDAwMDAwMDAwMDAwMDAwMDEgUjExOiAwMDAwMDAw MDAwMDAwMDAxIFIxMjoNCmZmZmY4ODgxMDM4MTAyOTgNClsgICAgMC44NDM1NzRdIFIxMzogZmZm Zjg4ODEwMDA0ODc4MCBSMTQ6IGZmZmZmZmZmODI4MmUwOTkgUjE1Og0KMDAwMDAwMDAwMDAwMDAw MA0KWyAgICAwLjg0NDUyNF0gRlM6ICAwMDAwMDAwMDAwMDAwMDAwKDAwMDApIEdTOmZmZmY4ODgx M2JjMDAwMDAoMDAwMCkNCmtubEdTOjAwMDAwMDAwMDAwMDAwMDANClsgICAgMC44NDU3MDZdIENT OiAgMDAxMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAwMzMNClsgICAgMC44 NDY0OTldIENSMjogZmZmZjg4ODEzZmZmZjAwMCBDUjM6IDAwMDAwMDAwMDIyMmQwMDEgQ1I0Og0K MDAwMDAwMDAwMDM3MGVmMA0KWyAgICAwLjg0NzQ2NF0gRFIwOiAwMDAwMDAwMDAwMDAwMDAwIERS MTogMDAwMDAwMDAwMDAwMDAwMCBEUjI6DQowMDAwMDAwMDAwMDAwMDAwDQpbICAgIDAuODQ4NDMy XSBEUjM6IDAwMDAwMDAwMDAwMDAwMDAgRFI2OiAwMDAwMDAwMGZmZmUwZmYwIERSNzoNCjAwMDAw MDAwMDAwMDA0MDANClsgICAgMC44NDkzNzFdIENhbGwgVHJhY2U6DQpbICAgIDAuODQ5Njk5XSAg PFRBU0s+DQpbICAgIDAuODQ5OTk3XSAgPyBkZXN0cm95X2FyZ3MrMHgxMzEvMHgxMzENClsgICAg MC44NTA0ODddICBkb19vbmVfaW5pdGNhbGwrMHg2MS8weDI1MA0KWyAgICAwLjg1MDk4M10gID8g cmRpbml0X3NldHVwKzB4MmMvMHgyYw0KWyAgICAwLjg1MTQ1MV0gIGtlcm5lbF9pbml0X2ZyZWVh YmxlKzB4MThlLzB4MWQ4DQpbICAgIDAuODUyMDMzXSAgPyByZXN0X2luaXQrMHgxMzAvMHgxMzAN ClsgICAgMC44NTI1MzNdICBrZXJuZWxfaW5pdCsweDE2LzB4MTIwDQpbICAgIDAuODUzMDM1XSAg cmV0X2Zyb21fZm9yaysweDFmLzB4MzANClsgICAgMC44NTM1MDddICA8L1RBU0s+DQpbICAgIDAu ODUzODAzXSAtLS1bIGVuZCB0cmFjZSAwMDAwMDAwMDAwMDAwMDAwIF0tLS0NClsgICAgMC44NTQ0 MjFdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQ0KWyAgICAwLjg1NTAyN10g V0FSTklORzogQ1BVOiAwIFBJRDogMSBhdCBtbS9kZWJ1Z192bV9wZ3RhYmxlLmM6NDYyDQpkZWJ1 Z192bV9wZ3RhYmxlKzB4YmFhLzB4ZTE2DQpbICAgIDAuODU2MTE1XSBNb2R1bGVzIGxpbmtlZCBp bjoNClsgICAgMC44NTY1MTddIENQVTogMCBQSUQ6IDEgQ29tbTogc3dhcHBlci8wIFRhaW50ZWQ6 DQpHICAgICAgICBXICAgICAgICAgIDYuMi4wLXJjNysgIzIzNjYNClsgICAgMC44NTc1NjJdIFJJ UDogMDAxMDpkZWJ1Z192bV9wZ3RhYmxlKzB4YmFhLzB4ZTE2DQpbICAgIDAuODU4MTg2XSBDb2Rl OiAwMCAwMCAwMCA0OCA4YiA1NCAyNCA2MCA0OCA4YiA3YyAyNCAyMCA0OCBjMSBlNiAwYw0KZTgg NzkgMTggN2YgZmUgODUgYzAgNzUgMDIgMGYgMGIgNDggOGIgN2INClsgICAgMC44NjA3NzhdIFJT UDogMDAwMDpmZmZmYzkwMDAwMDEzZGUwIEVGTEFHUzogMDAwMTAyNDYNClsgICAgMC44NjE1MTld IFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IGZmZmY4ODgxMDAwNDg4NjggUkNYOg0KYmZmZmZm ZmZmZmZmZmZmMA0KWyAgICAwLjg2MjUzMF0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogMDAw MDAwMDA0MDAwMDAwMCBSREk6DQpmZmZmODg4MTAzODBlN2Y4DQpbICAgIDAuODYzNTIyXSBSQlA6 IGZmZmY4ODgxMDAwNGQxNDAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIwOToNCmZmZmY4ODgxMDAy ODA4ODANClsgICAgMC44NjQ0NDldIFIxMDogMDAwMDAwMDAwMDAwMDAwMSBSMTE6IDAwMDAwMDAw MDAwMDAwMDEgUjEyOg0KZmZmZjg4ODEwMzgxMDI5OA0KWyAgICAwLjg2NTQ1NF0gUjEzOiBmZmZm ODg4MTAwMDQ4NzgwIFIxNDogZmZmZmZmZmY4MjgyZTA5OSBSMTU6DQowMDAwMDAwMDAwMDAwMDAw DQpbICAgIDAuODY2NDAxXSBGUzogIDAwMDAwMDAwMDAwMDAwMDAoMDAwMCkgR1M6ZmZmZjg4ODEz YmMwMDAwMCgwMDAwKQ0Ka25sR1M6MDAwMDAwMDAwMDAwMDAwMA0KWyAgICAwLjg2NzQzOF0gQ1M6 ICAwMDEwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMw0KWyAgICAwLjg2 ODE4MV0gQ1IyOiBmZmZmODg4MTNmZmZmMDAwIENSMzogMDAwMDAwMDAwMjIyZDAwMSBDUjQ6DQow MDAwMDAwMDAwMzcwZWYwDQpbICAgIDAuODY5MDk3XSBEUjA6IDAwMDAwMDAwMDAwMDAwMDAgRFIx OiAwMDAwMDAwMDAwMDAwMDAwIERSMjoNCjAwMDAwMDAwMDAwMDAwMDANClsgICAgMC44NzAwMjZd IERSMzogMDAwMDAwMDAwMDAwMDAwMCBEUjY6IDAwMDAwMDAwZmZmZTBmZjAgRFI3Og0KMDAwMDAw MDAwMDAwMDQwMA0KWyAgICAwLjg3MDk0M10gQ2FsbCBUcmFjZToNClsgICAgMC44NzEyNTldICA8 VEFTSz4NClsgICAgMC44NzE1MzddICA/IGRlc3Ryb3lfYXJncysweDEzMS8weDEzMQ0KWyAgICAw Ljg3MjAzMF0gIGRvX29uZV9pbml0Y2FsbCsweDYxLzB4MjUwDQpbICAgIDAuODcyNTIxXSAgPyBy ZGluaXRfc2V0dXArMHgyYy8weDJjDQpbICAgIDAuODczMDA1XSAga2VybmVsX2luaXRfZnJlZWFi bGUrMHgxOGUvMHgxZDgNClsgICAgMC44NzM2MDddICA/IHJlc3RfaW5pdCsweDEzMC8weDEzMA0K WyAgICAwLjg3NDExNl0gIGtlcm5lbF9pbml0KzB4MTYvMHgxMjANClsgICAgMC44NzQ2MThdICBy ZXRfZnJvbV9mb3JrKzB4MWYvMHgzMA0KWyAgICAwLjg3NTEyM10gIDwvVEFTSz4NClsgICAgMC44 NzU0MTFdIC0tLVsgZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAwMDAgXS0tLQ0K From xen-devel-bounces@lists.xenproject.org Sat Feb 11 06:24:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 06:24:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493786.763814 (Exim 4.92) (envelope-from ) id 1pQjIq-00035V-PG; Sat, 11 Feb 2023 06:24:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493786.763814; Sat, 11 Feb 2023 06:24:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQjIq-00035O-L7; Sat, 11 Feb 2023 06:24:04 +0000 Received: by outflank-mailman (input) for mailman id 493786; Sat, 11 Feb 2023 06:24:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQjIo-00035D-TU for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 06:24:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa859200-a9d4-11ed-93b5-47a8fe42b414; Sat, 11 Feb 2023 07:23:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 630743393C; Sat, 11 Feb 2023 06:23:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3958D13A1F; Sat, 11 Feb 2023 06:23:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R6MCDH0052P2WQAAMHmgww (envelope-from ); Sat, 11 Feb 2023 06:23:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa859200-a9d4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676096637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ehoRu52+j8qFCI7ZreeVaH5N+q71cuyzpByv070ySv0=; b=Enygx9O/MBsKiHnsvacdeEpoog/KNaGx0fXa2FhFjHslH5LbXvC02zy5z8JYMAUiLiAa8X OAZXoui9OcCi/yB5H4Np6Ut0mpnGelm6R4oRwpzzf5apx3MG/nWKzukp8yMTTRg98taTTW 2Ft5qJNsQMFlJpckS1LgrP86qejFpcw= Message-ID: <7309a521-7c8c-41c7-eae7-fa3d4c08f4f7@suse.com> Date: Sat, 11 Feb 2023 07:23:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> <20230210185328.2zqo5xvklpke3ie2@begin> From: Juergen Gross In-Reply-To: <20230210185328.2zqo5xvklpke3ie2@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------c1aQ0FFzOSLQ01YXxZ3gM7P8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------c1aQ0FFzOSLQ01YXxZ3gM7P8 Content-Type: multipart/mixed; boundary="------------K2w4L4SAQl3Vl94ujbCyYKK7"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <7309a521-7c8c-41c7-eae7-fa3d4c08f4f7@suse.com> Subject: Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-7-jgross@suse.com> <20230210185328.2zqo5xvklpke3ie2@begin> In-Reply-To: <20230210185328.2zqo5xvklpke3ie2@begin> --------------K2w4L4SAQl3Vl94ujbCyYKK7 Content-Type: multipart/mixed; boundary="------------X2SoR0QsTVz1xze8Z5c00D8n" --------------X2SoR0QsTVz1xze8Z5c00D8n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTk6NTMsIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAxMCBmw6l2ci4gMjAyMyAxMTo0NjoyNyArMDEwMCwgYSBlY3JpdDoN Cj4+ICtzdGF0aWMgYm9vbCBwYXRoX2Nhbm9uaWNhbChjb25zdCBjaGFyICpwYXRobmFtZSkN Cj4+ICt7DQo+PiArICAgIHVuc2lnbmVkIGludCBsZW4gPSBzdHJsZW4ocGF0aG5hbWUpOw0K Pj4gKyAgICBjb25zdCBjaGFyICpjOw0KPj4gKw0KPj4gKyAgICAvKiBFbXB0eSBwYXRoIGlz IGFsbG93ZWQuICovDQo+PiArICAgIGlmICggIWxlbiApDQo+PiArICAgICAgICByZXR1cm4g dHJ1ZTsNCj4+ICsNCj4+ICsgICAgLyogTm8gdHJhaWxpbmcgJy8nLiAqLw0KPj4gKyAgICBp ZiAoIHBhdGhuYW1lW2xlbiAtIDFdID09ICcvJyApDQo+PiArICAgICAgICByZXR1cm4gZmFs c2U7DQo+PiArDQo+PiArICAgIC8qIE5vIHNlbGYgb3IgcGFyZW50IHJlZmVyZW5jZXMuICov DQo+PiArICAgIGMgPSBwYXRobmFtZTsNCj4+ICsgICAgd2hpbGUgKCAoYyA9IHN0cnN0cihj LCAiLy4iKSkgIT0gTlVMTCApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGlmICggY1syXSA9 PSAnLicgKQ0KPj4gKyAgICAgICAgICAgIGMrKzsNCj4+ICsgICAgICAgIGlmICggY1syXSA9 PSAwIHx8IGNbMl0gPT0gJy8nICkNCj4+ICsgICAgICAgICAgICByZXR1cm4gZmFsc2U7DQo+ PiArICAgICAgICBjICs9IDI7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgcmV0dXJuIHRy dWU7DQo+PiArfQ0KPiANCj4gVGhpcyBkb2Vzbid0IHNlZW0gdG8gYmUgY2F0Y2hpbmcgIi8v Ij8NCg0KT2gsIHNpbGx5IG1lIQ0KDQoNCkp1ZXJnZW4NCg0K --------------X2SoR0QsTVz1xze8Z5c00D8n Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------X2SoR0QsTVz1xze8Z5c00D8n-- --------------K2w4L4SAQl3Vl94ujbCyYKK7-- --------------c1aQ0FFzOSLQ01YXxZ3gM7P8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPnNHwFAwAAAAAACgkQsN6d1ii/Ey8q hAf+LEyNJVeHchISPO3V/7N8ggVBC9SnwgHu/8vcF3mSNd2Xy7tUOKg94zjm3AhOc1/Vv9KeoxcY 9/1WqNx/Lyd11Y1e8W0swsBXEZOEdjHpgOBvh3CENgAC63+KB8otWtaxqrnGCTRd2c/L2c1Gc/j5 laMnYVrRG5hwbWg10CSOcjQ4oQIcikM7jPfL2LMvzLVNQtqRJwF1DZiTbWbpvUtyK1v5nTbGHVlv Gg6ki22g6NlbweyP7zDl+PQCxD0gfoM1QnwxQj5Ug3IdzKwz7+fWhWxM+uuCp6vL5tL/AgIFAKPy hFcYbEbwx0A1rtu4WVYWBV/i5cJCge2xKqWQC5Gctg== =v4pe -----END PGP SIGNATURE----- --------------c1aQ0FFzOSLQ01YXxZ3gM7P8-- From xen-devel-bounces@lists.xenproject.org Sat Feb 11 07:32:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 07:32:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493796.763828 (Exim 4.92) (envelope-from ) id 1pQkMw-00038l-Nl; Sat, 11 Feb 2023 07:32:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493796.763828; Sat, 11 Feb 2023 07:32:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQkMw-00038e-Kx; Sat, 11 Feb 2023 07:32:22 +0000 Received: by outflank-mailman (input) for mailman id 493796; Sat, 11 Feb 2023 07:32:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQkMu-00038T-Lz; Sat, 11 Feb 2023 07:32:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQkMu-0007jM-JU; Sat, 11 Feb 2023 07:32:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQkMu-0001Z8-5N; Sat, 11 Feb 2023 07:32:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQkMu-0002lC-4v; Sat, 11 Feb 2023 07:32:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7fPOjcq1KDs9nCe5n/RrNOBE0fx0x0LpCDF490lNvAI=; b=2G9Qh1esn5MGTAofqRM2TJqoNF 4B+HZWHLTC8oZPfH1kIlUaiKnIBmvgqgjdNWBd91WwjKqPtfciKC1Udj7s4GPH/NfehSl8cbP8FLJ o0TQuX5eLz1mJmydnCB8qRmAv2Pw4x053q96ZQduzxIYIqXilZgK/PnXJQIsE5OrsFuY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176875: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=38c1e0c65865426676123cc9a127526fa02bcac6 X-Osstest-Versions-That: linux=35674e787518768626d3a0ffce1c13a7eeed922d From: osstest service owner Date: Sat, 11 Feb 2023 07:32:20 +0000 flight 176875 linux-linus real [real] flight 176935 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176875/ http://logs.test-lab.xenproject.org/osstest/logs/176935/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 176935-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176771 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176771 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176771 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176771 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176771 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 38c1e0c65865426676123cc9a127526fa02bcac6 baseline version: linux 35674e787518768626d3a0ffce1c13a7eeed922d Last test of basis 176771 2023-02-09 18:42:21 Z 1 days Testing same since 176875 2023-02-10 16:48:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Aravind Iddamsetty Bert Karwatzki Christian König Dan Carpenter Dave Airlie Dean Luick Dennis Dalessandro Dmitry Osipenko Douglas Anderson Dragos Tatulea Evan Quan Friedrich Vock Guchun Chen Guilherme G. Piccoli Guoqing Jiang Hamza Mahfooz Harry Wentland Jack Wang Jane Jian Jason Gunthorpe JesseZhang Jouni Högander Kenneth Feng Kent Russell Leon Romanovsky Leon Romanovsky Li Zhijian Linus Torvalds Long Li Maor Gottlieb Maxime Ripard Melissa Wen Mikhail Gavrilov Nikita Zhandarovich Rafael J. Wysocki Rob Clark Rodrigo Vivi Ryan Neph Thomas Zimmermann Tvrtko Ursulin Ville Syrjälä Viresh Kumar Yang Yingliang Zeno Davatz jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 35674e787518..38c1e0c65865 38c1e0c65865426676123cc9a127526fa02bcac6 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Feb 11 08:56:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 08:56:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493814.763839 (Exim 4.92) (envelope-from ) id 1pQlfP-0005B5-6u; Sat, 11 Feb 2023 08:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493814.763839; Sat, 11 Feb 2023 08:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlfP-0005Ay-45; Sat, 11 Feb 2023 08:55:31 +0000 Received: by outflank-mailman (input) for mailman id 493814; Sat, 11 Feb 2023 08:55:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlfN-0005As-T3 for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 08:55:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlfM-0001rd-Uk; Sat, 11 Feb 2023 08:55:28 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQlfM-0001Ot-KS; Sat, 11 Feb 2023 08:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5G7KwCSiIP7XCMQmUXY3BXjgv/lGoB507b4BGIsiNpI=; b=sq/aJn0XssTrnsQTtqnJDFHtJE XDH8g7aLPDj1Qu/LS6HfE4OH2ZESYJVxW6LcPLumfIFr2mUv+KM8Gjvpwf+bfIoa3rc0X1jTGku+v cBQ7epbmxeSIFH/lvin2Xglu+IKi6RXWt0Yf3mVtuWvv+zHoc7eHvi6F1rZcZ60kdZqg=; Message-ID: <781a1beb-8a62-9623-a239-54586fc82dd2@xen.org> Date: Sat, 11 Feb 2023 08:55:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 1/9] xen/ns16550: Remove unneeded truncation check in the DT init code To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-2-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230208120529.22313-2-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan On 08/02/2023 12:05, Ayan Kumar Halder wrote: > In an earlier commit (7c1de0038895), "ns16550.io_size" was u32 and > "io_size" was u64. Thus, the ASSERT() was needed to check if the values > are the same. > However, in a later commit (c9f8e0aee507), "ns16550.io_size" was changed > to u64. Thus, the ASSERT() became redundant. > > So, now as "io_size" and "uart->io_size" are both u64, there will be no > truncation. Thus, one can remove the ASSERT() and extra assignment. > > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 09:07:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 09:07:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493822.763850 (Exim 4.92) (envelope-from ) id 1pQlqR-0006tz-66; Sat, 11 Feb 2023 09:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493822.763850; Sat, 11 Feb 2023 09:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlqR-0006ts-3R; Sat, 11 Feb 2023 09:06:55 +0000 Received: by outflank-mailman (input) for mailman id 493822; Sat, 11 Feb 2023 09:06:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlqP-0006ti-Eh; Sat, 11 Feb 2023 09:06:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlqP-00025w-C6; Sat, 11 Feb 2023 09:06:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlqP-0005Bv-2o; Sat, 11 Feb 2023 09:06:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQlqP-0001WL-2G; Sat, 11 Feb 2023 09:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EiEPC94+NhAVoIun+zTvneRCH+WUaDG8FYYlPMf27Wc=; b=JG6jzN1xZHYmxf3mMYG0LDT/Qv CJo1/p/hb4dNgMrpkRj34HUNcsEesU6MPhLnQ0ArwmzL0Dvjml6JvuPdSys5RXyRcGcuFPOTW84kk qrKvxx2r/jCieitCUb1H+DTOzDaHMGJ0lI6kI+JzkNKy2tONpKxJXQZHlhPu9JvcTEak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176906: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=4e0b4ccfc504f26187939068796295340ffd0e2f From: osstest service owner Date: Sat, 11 Feb 2023 09:06:53 +0000 flight 176906 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176906/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 176769 Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 176855 pass in 176906 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 176855 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 176855 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176769 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl 3 hosts-allocate starved in 176855 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 176855 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 4e0b4ccfc504f26187939068796295340ffd0e2f Last test of basis 176769 2023-02-09 18:40:48 Z 1 days Testing same since 176855 2023-02-10 12:17:08 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig George Dunlap Henry Wang Ian Jackson Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/shskt: Disable CET-SS on parts susceptible to fractured updates Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack Token". Architecturally, an event delivery which starts in CPL<3 and switches shadow stack will first validate the Supervisor Shadow Stack Token (setting the busy bit), then pushes CS/LIP/SSP. One example of this is an NMI interrupting Xen. Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/etc between setting the busy bit and completing the event injection renders the action non-restartable, because when it comes time to restart, the busy bit is found to be already set. This is far more easily encountered under virt, yet it is not the fault of the hypervisor, nor the fault of the guest kernel. The fault lies somewhere between the architectural specification, and the uarch behaviour. Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervisor shadow stacks are safe to use. Because of how Xen lays out its shadow stacks, fracturing is not expected to be a problem on native. Detect this case on boot and default to not using shstk if virtualised. Specifying `cet=shstk` on the command line will override this heuristic and enable shadow stacks irrespective. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit b4a23bf6293aadecfd03bf9e83974443e2eac9cb Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} We don't actually need ecx yet, but adding it in now will reduce the amount to which leaf 7 is out of order in a featureset. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 789ed08abb8f5e411cf06f6acb61c2d261f625da Author: Juergen Gross Date: Thu Feb 9 15:41:48 2023 +0100 docs: clarify xenstore permission documentation In docs/misc/xenstore.txt the description of the Xenstore node access permissions is missing one important aspect, which can be found only in the code or in the wiki [1]: The first permission entry is defining the owner of the node via the domid, and the access rights for all domains NOT having a dedicated permission entry. Make that aspect clear in the official documentation. [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions Reported-by: Edwin Török Signed-off-by: Juergen Gross Reviewed-by: Julien Grall commit d184b26db2b29b5f610b61c43580becd7a4057b1 Author: Juergen Gross Date: Thu Feb 9 15:23:57 2023 +0100 SUPPORT.md: update version to 4.18-unstable The current version is no longer 4.17-rc. Update it to "4.18-unstable". Signed-off-by: Juergen Gross Acked-by: Andrew Cooper commit e51d31f79edc10f8d622e7f5bf4b935af6d4618f Author: Andrew Cooper Date: Thu Feb 9 15:25:10 2023 +0000 tools/ocaml: Drop libxl and xentoollog bindings There are significant issues with these bindings (they segfault for starters) and their companion half in Xapi was deleted in 2018 https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d owing to there having been no development of these bindings since 2014. In the unlikely event that we'd want to reinstate them, they'd need reworking basically from scratch anyway. Signed-off-by: Andrew Cooper Acked-by: Christian Lindig commit bf652a50fb3bb3b1b3d93db6fb79bc28f978fe75 Author: Anthony PERARD Date: Thu Feb 9 16:14:48 2023 +0000 libs/util: Fix parallel build between flex/bison and CC rules flex/bison generate two targets, and when those targets are prerequisite of other rules they are considered independently by make. We can have a situation where the .c file is out-of-date but not the .h, git checkout for example. In this case, if a rule only have the .h file as prerequiste, make will procced and start to build the object. In parallel, another target can have the .c file as prerequisite and make will find out it need re-generating and do so, changing the .h at the same time. This parallel task breaks the first one. To avoid this scenario, we put both the header and the source as prerequisite for all object even if they only need the header. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 52493ec3e32a6e631b3ae3571db7ed41f10d9b06 Author: Anthony PERARD Date: Thu Feb 9 12:11:40 2023 +0000 libs/util: Remove unused headers in libxlu_pci.c libxlu_pci.c doesn't use any "xlu__cfg*()" functions and doesn't use any of the disk parsing functions "xlu__disk*()", so all those headers can be removed. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 5b46dd85d051ceecc2c00a0de27f03e571bff379 Author: Julien Grall Date: Fri Jan 27 18:55:46 2023 +0000 tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested-by: Henry Wang Reviewed-by: Juergen Gross commit 4e0e7a29d2fe318e4e60e77a56773b4d020ebc6a Author: Julien Grall Date: Thu Feb 9 17:07:28 2023 +0000 docs/process: branching-checklist: Clarify steps to add the branch in osstest The steps to add the new branch in osstest doesn't mention the change should be committed. Update the steps to clarify that. Take the opportunity to switch to use $v instead hardcoded version. Signed-off-by: Julien Grall Reviewed-by: Henry Wang commit 6a6ae4ac349ee31030d4fb3952f2c3b48e60d09f Author: Julien Grall Date: Thu Feb 9 17:07:13 2023 +0000 docs/process: branching-checklist: Remove reference to root The steps to generate the documentation for the new branch requires to ssh as root and then su to run with the user xendocs. The release technician may not (and should not) have access to root. So update the step to directly ssh as xendocs. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang commit f87a15f5cce5c76c3d8028b7129f3a1abf1d6b7d Author: Julien Grall Date: Thu Feb 9 17:04:41 2023 +0000 docs/process: branching-checklist: Remove reference to qemu-ijw.git Per [1], qemu-iwj.git was a clone of QEMU traditional on Ian's computer for tagging QEMU trad. The next section will provide tag for the official tree. So remove the section about qemu-ijw.git. [1] 25482.10006.140155.984629@chiark.greenend.org.uk Signed-off-by: Julien Grall Acked-by: George Dunlap Acked-by: Ian Jackson Reviewed-by: Henry Wang commit 5dbe775c2b622a9473ddb9492db63cc320d562c4 Author: Julien Grall Date: Thu Feb 9 17:04:30 2023 +0000 docs/process: branching-checklist: Use consistent indentation At the moment, branch-checklist.txt is using a mix of soft and hard tab. They are both meant to be represented using 8 characters. In Xen we tend to use 4-space softtab represented with 4 characters. So to avoid having to use a different editor configuration, switch all the indentation to 4-space softtab. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Feb 11 09:10:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 09:10:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493833.763862 (Exim 4.92) (envelope-from ) id 1pQltg-0008NT-Qo; Sat, 11 Feb 2023 09:10:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493833.763862; Sat, 11 Feb 2023 09:10:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQltg-0008NM-MX; Sat, 11 Feb 2023 09:10:16 +0000 Received: by outflank-mailman (input) for mailman id 493833; Sat, 11 Feb 2023 09:10:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQltf-0008NG-IG for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 09:10:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQlte-00028s-J2; Sat, 11 Feb 2023 09:10:14 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQlte-0001yS-8k; Sat, 11 Feb 2023 09:10:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=VLo1JSR4UZby/541LwEeRUgP8QQ/iSy/F88VSmuEyPA=; b=6qkKkCtDErvAGnxyzgsz6Ac0ig HrX2jp54NCrhOvxzHd91IYbju13oE54EBrDoa7A8sfUuVcSL+2kOpcMbL974+7kQ8T3mRUGIRwBa0 16qBCbQCPNXv8dmaSKlMMKEl5WDM4qYL8IOHbKKby+0DQKbBToSltFtcuReuFD/Kv6Vs=; Message-ID: <5631b4ea-decf-0e9d-3749-6f0bdffb73c4@xen.org> Date: Sat, 11 Feb 2023 09:10:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-5-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 11/02/2023 00:20, Stefano Stabellini wrote: > On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: >> dt_device_get_address() can accept u64 only for address and size. >> However, the address/size denotes physical addresses. Thus, they should >> be represented by 'paddr_t'. >> Consequently, we introduce a wrapper for dt_device_get_address() ie >> dt_device_get_paddr() which accepts address/size as paddr_t and inturn >> invokes dt_device_get_address() after converting address/size to u64. >> >> The reason for introducing doing this is that in future 'paddr_t' may >> be defined as u32. Thus, we need an explicit wrapper to do the type >> conversion and return an error in case of truncation. >> >> With this, callers now invoke dt_device_get_paddr(). >> dt_device_get_address() is invoked by dt_device_get_paddr() only. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> Changes from - >> >> v1 - 1. New patch. >> >> v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t instead of u64 for address/size" >> into this patch. >> >> 2. dt_device_get_address() callers now invoke dt_device_get_paddr() instead. >> >> 3. Logged error in case of truncation. >> >> xen/arch/arm/domain_build.c | 10 +++--- >> xen/arch/arm/gic-v2.c | 10 +++--- >> xen/arch/arm/gic-v3-its.c | 4 +-- >> xen/arch/arm/gic-v3.c | 10 +++--- >> xen/arch/arm/pci/pci-host-common.c | 6 ++-- >> xen/arch/arm/platforms/brcm-raspberry-pi.c | 2 +- >> xen/arch/arm/platforms/brcm.c | 4 +-- >> xen/arch/arm/platforms/exynos5.c | 32 +++++++++---------- >> xen/arch/arm/platforms/sunxi.c | 2 +- >> xen/arch/arm/platforms/xgene-storm.c | 2 +- >> xen/common/device_tree.c | 36 ++++++++++++++++++++-- >> xen/drivers/char/cadence-uart.c | 4 +-- >> xen/drivers/char/exynos4210-uart.c | 4 +-- >> xen/drivers/char/imx-lpuart.c | 4 +-- >> xen/drivers/char/meson-uart.c | 4 +-- >> xen/drivers/char/mvebu-uart.c | 4 +-- >> xen/drivers/char/ns16550.c | 2 +- >> xen/drivers/char/omap-uart.c | 4 +-- >> xen/drivers/char/pl011.c | 6 ++-- >> xen/drivers/char/scif-uart.c | 4 +-- >> xen/drivers/passthrough/arm/ipmmu-vmsa.c | 8 ++--- >> xen/drivers/passthrough/arm/smmu-v3.c | 2 +- >> xen/drivers/passthrough/arm/smmu.c | 8 ++--- >> xen/include/xen/device_tree.h | 6 ++-- >> 24 files changed, 105 insertions(+), 73 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 4d7e67560f..c7e88f5011 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -1692,13 +1692,13 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, >> dt_for_each_device_node( dt_host, np ) >> { >> unsigned int naddr; >> - u64 addr, size; >> + paddr_t addr, size; >> >> naddr = dt_number_of_address(np); >> >> for ( i = 0; i < naddr; i++ ) >> { >> - res = dt_device_get_address(np, i, &addr, &size); >> + res = dt_device_get_paddr(np, i, &addr, &size); > > One thing to be careful here is that "start" and "end" in > find_memory_holes are defined now as paddr_t and passed to > rangeset_add_range and rangeset_remove_range. I am a bit puzzled why you are saying "now". Without Ayan's patch addr was 64-bit so... > > rangeset_add_range and rangeset_remove_range take an unsigned long as > parameter, so in an arm32 configuration with paddr_t set to 64-bit it > would result in truncation ... the problem you are talking about would already exist. I would consider to store a frame number rather than the full address because we can only deal with page-aligned region. Stefano (or Ayan) can you look at it? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 09:25:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 09:25:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493840.763873 (Exim 4.92) (envelope-from ) id 1pQm8X-0001uF-43; Sat, 11 Feb 2023 09:25:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493840.763873; Sat, 11 Feb 2023 09:25:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQm8X-0001u8-0q; Sat, 11 Feb 2023 09:25:37 +0000 Received: by outflank-mailman (input) for mailman id 493840; Sat, 11 Feb 2023 09:25:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQm8V-0001u2-A8 for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 09:25:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQm8U-0002d0-Mc; Sat, 11 Feb 2023 09:25:34 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQm8U-0002az-Fm; Sat, 11 Feb 2023 09:25:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=hWMoGp/KYd7Hdn/gM32Fqd7HnigzVj93ec2z1aEYW8Y=; b=gXIAl5iX51WXRSmQ2f6JRz9e1w 0hC3ulFwd0ghTEMVYc4dy+rVG/vku3+3UVmltHXKM+9a/qJvYLSmqvlx5FfQ2XaGQIYJu1Z82AxyB xFJkbFZ8UpaOIjwNY2MAfzEZRCCiIrSbUbMZr2CAfvbaDt0AiJRLUVsgHO3M/tfS+3Qo=; Message-ID: <6ffc8be8-def5-1f55-7468-306bf758e9d1@xen.org> Date: Sat, 11 Feb 2023 09:25:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-5-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t In-Reply-To: <20230208120529.22313-5-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 08/02/2023 12:05, Ayan Kumar Halder wrote: > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 6c9712ab7b..d0f19d5cfc 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -934,8 +934,9 @@ bail: > } > > /* dt_device_address - Translate device tree address and return it */ > -int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > - u64 *addr, u64 *size) > +static int dt_device_get_address(const struct dt_device_node *dev, > + unsigned int index, > + u64 *addr, u64 *size) > { > const __be32 *addrp; > unsigned int flags; > @@ -955,6 +956,37 @@ int dt_device_get_address(const struct dt_device_node *dev, unsigned int index, > return 0; > } > > +int dt_device_get_paddr(const struct dt_device_node *dev, unsigned int index, > + paddr_t *addr, paddr_t *size) > +{ > + u64 dt_addr = 0, dt_size = 0; Please use uint64_t for new code. > + int ret; > + > + ret = dt_device_get_address(dev, index, &dt_addr, &dt_size); > + > + if ( addr ) > + { > + if ( (dt_addr >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical address greater than max width supported\n"); I would print the width, address and the node name to help debugging. > + return -EINVAL; NIT: -EINVAL tends to be quite overloaded. How about using -ERANGE? > + } > + > + *addr = dt_addr; > + } > + > + if ( size ) > + { > + if ( (dt_size >> (PADDR_SHIFT - 1)) > 1 ) > + { > + printk("Error: Physical size greater than max width supported\n"); Same here for the message but with s/address/size/. > + return -EINVAL; Same here for the errno. The rest looks fine so long Stefano's comment are addressed. > + } > + *size = dt_size; > + } > + > + return ret; > +} Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 10:02:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 10:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493848.763883 (Exim 4.92) (envelope-from ) id 1pQmhf-0006kA-S4; Sat, 11 Feb 2023 10:01:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493848.763883; Sat, 11 Feb 2023 10:01:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmhf-0006k3-P6; Sat, 11 Feb 2023 10:01:55 +0000 Received: by outflank-mailman (input) for mailman id 493848; Sat, 11 Feb 2023 10:01:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmhe-0006jx-BJ for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 10:01:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmhd-0003Zd-JE; Sat, 11 Feb 2023 10:01:53 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQmhd-0004A5-DO; Sat, 11 Feb 2023 10:01:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6dexXVAvbrJnM3ieaiV6wLjCkQKxgSvXJjNxfAESCHg=; b=nEDtejRgRJiPDYxJUFc/ocUkqO WKpeV7F8ilwTZuzxmq9cBOcarxtDv87EjT4otYwacekNkqzAymFZJEiSxg60VIwvjONz9KYUmQQXW mZQ3eeJqLb9V/gRNId4Fu+gPgIRJYfC34Zzzo4bTgYBLI7a02/TwOCXbDZ+d0aUeefds=; Message-ID: Date: Sat, 11 Feb 2023 10:01:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-7-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v3 6/9] xen/arm: Introduce choice to enable 64/32 bit physical addressing In-Reply-To: <20230208120529.22313-7-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 08/02/2023 12:05, Ayan Kumar Halder wrote: > Some Arm based hardware platforms which does not support LPAE > (eg Cortex-R52), uses 32 bit physical addresses. > Also, users may choose to use 32 bits to represent physical addresses > for optimization. > > To support the above use cases, we have introduced arch independent > configs to choose if the physical address can be represented using > 32 bits (PHYS_ADDR_32) or 64 bits (PHYS_ADDR_64). > For now only ARM_32 provides support to enable 32 bit physical > addressing. > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from - > v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". > > v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 only whereas > ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. > 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. > > (Jan,Julien please let me know if I understood your suggestion about Kconfig correctly). > > xen/arch/Kconfig | 12 +++++++++++ > xen/arch/arm/Kconfig | 31 ++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/page-bits.h | 2 ++ > xen/arch/arm/include/asm/types.h | 6 ++++++ > 4 files changed, 51 insertions(+) > > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index 7028f7b74f..1eff312b51 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -1,6 +1,18 @@ > config 64BIT > bool > > +config PHYS_ADDR_32 > + bool > + help > + Select this option if the physical addresses can be represented by > + 32 bits. > + > +config PHYS_ADDR_64 > + bool > + help > + Select this option if the physical addresses can be represented > + 64 bits. > + So you likely don't want to allow the user to select them directly (IOW remove the help section). However, I don't see any code using it. Did you actually intended to use PHYS_ADDR_{32, 64} in the code? > config NR_CPUS > int "Maximum number of CPUs" > range 1 4095 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 239d3aed3c..0955891e86 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -18,6 +18,37 @@ config ARM > select HAS_PDX > select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > + choice I think this is a bit odd that this choice is part of CONFIG_ARM. It would be better it is separate. You can do that by removing one indentation. > + bool "Representative width for any physical address (default 64bit)" > + optional > + ---help--- > + You may want to specify the width to represent the physical > + address space. > + By default, the physical addresses are represented using > + 64 bits. > + > + However in certain platforms, the physical addresses may be > + represented using 32 bits. > + Also, the user may decide that the physical addresses can be > + represented using 32 bits for a given SoC. In those cases, > + user may want to enable 32 bit physical address for > + optimization. > + For now, we have enabled this choice for ARM_32 only. > + > + config ARM_PA_64 > + select PHYS_ADDR_64 > + bool "Select 64 bits to represent physical address" > + ---help--- > + Use 64 bits to represent physical address. > + > + config ARM_PA_32 > + select PHYS_ADDR_32 > + depends on ARM_32 > + bool "Select 32 bits to represent physical address" > + ---help--- > + Use 32 bits to represent physical address. As I wrote in v2, I think this is a bit odd to ask the user what would be the width of paddr_t. It is also not scalable if we decide in the future to define different PADDR_BITS (i.e. 48, 40, 36, 32). So it would be better to allow the user to define PADDR_BITS that can then be translated by Xen to which ever paddr_t is suitable. Something like: choice prompt: "Physical address space size" if ARM_32 default ARM_PA_48 if ARM_64 default AMR_PA_40 if ARM_32 help ... config ARM_PA_BITS_32 bool "32-bit" help XXX Add help here to explain the benefits of using 32-bit. select PHYS_ADDR_T_32 depends on ARM_32 config ARM_PA_BITS_40 bool "40-bit" select PHYS_ADDR_T_64 depends on ARM_32 config ARM_PA_BITS_48 bool "40-bit" select PHYS_ADDR_T_64 depends on ARM_48 endchoice config PADDR_BITS int default 32 if ARM_PA_BITS_32 default 40 if ARM_PA_BITS_40 default 48 if ARM_PA_BITS_48 With this approach, there would be no structural change in the Kconfig if we wanted to support 32/40-bit on Arm64. > + > + endchoice > > config ARCH_DEFCONFIG > string > diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h > index 5d6477e599..8f4dcebcfd 100644 > --- a/xen/arch/arm/include/asm/page-bits.h > +++ b/xen/arch/arm/include/asm/page-bits.h > @@ -5,6 +5,8 @@ > > #ifdef CONFIG_ARM_64 > #define PADDR_BITS 48 > +#elif CONFIG_ARM_PA_32 > +#define PADDR_BITS 32 > #else > #define PADDR_BITS 40 > #endif With what I suggested above. This would be replaced with: #define PADDR_BITS CONFIG_PADDR_BITS > diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h > index e218ed77bd..26144bc87e 100644 > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -34,9 +34,15 @@ typedef signed long long s64; > typedef unsigned long long u64; > typedef u32 vaddr_t; > #define PRIvaddr PRIx32 > +#if defined(CONFIG_ARM_PA_32) And this could be replaced with #ifdef CONFIG_PHY_ADDR_T_32 I would also consider to add the following in mm.c BUILD_BUG_ON((sizeof(paddr_t) * 8) < PADDR_BITS); This is to make sure that the PADDR_BITS will always fit in paddr_t. > +typedef unsigned long paddr_t; > +#define INVALID_PADDR (~0UL) > +#define PRIpaddr "08lx" > +#else > typedef u64 paddr_t; > #define INVALID_PADDR (~0ULL) > #define PRIpaddr "016llx" > +#endif > typedef u32 register_t; > #define PRIregister "08x" > #elif defined (CONFIG_ARM_64) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 10:07:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 10:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493854.763895 (Exim 4.92) (envelope-from ) id 1pQmmq-0007XS-Gm; Sat, 11 Feb 2023 10:07:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493854.763895; Sat, 11 Feb 2023 10:07:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmmq-0007XL-D1; Sat, 11 Feb 2023 10:07:16 +0000 Received: by outflank-mailman (input) for mailman id 493854; Sat, 11 Feb 2023 10:07:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmmp-0007XF-1f for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 10:07:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmmo-0003g6-1z; Sat, 11 Feb 2023 10:07:14 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQmmn-0004OC-E4; Sat, 11 Feb 2023 10:07:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=fxr93fw4/ae1l9bsu7GempUTB9Wp2H7fgUKsKezB/Mg=; b=FxPU1SofBPCrP/4mweHzyzlvSS halbExqt4cdzw7rYDREpUtFbEPRGSOZXzBzrT5RLMTdsKbh9jNrAd4I0oSmJ138HORxsw0VUAUBxv BMupAEOCezmvNGh+admi0vJTozNipYUKI491JXGn0l0XwIdP8aDBqImNi/zI72IHWXCs=; Message-ID: Date: Sat, 11 Feb 2023 10:07:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 6/9] xen/arm: Introduce choice to enable 64/32 bit physical addressing To: Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-7-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 11/02/2023 00:34, Stefano Stabellini wrote: > On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: >> Some Arm based hardware platforms which does not support LPAE >> (eg Cortex-R52), uses 32 bit physical addresses. >> Also, users may choose to use 32 bits to represent physical addresses >> for optimization. >> >> To support the above use cases, we have introduced arch independent >> configs to choose if the physical address can be represented using >> 32 bits (PHYS_ADDR_32) or 64 bits (PHYS_ADDR_64). >> For now only ARM_32 provides support to enable 32 bit physical >> addressing. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from - >> v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr". >> >> v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 only whereas >> ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. >> 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. >> >> (Jan,Julien please let me know if I understood your suggestion about Kconfig correctly). >> >> xen/arch/Kconfig | 12 +++++++++++ >> xen/arch/arm/Kconfig | 31 ++++++++++++++++++++++++++++ >> xen/arch/arm/include/asm/page-bits.h | 2 ++ >> xen/arch/arm/include/asm/types.h | 6 ++++++ >> 4 files changed, 51 insertions(+) >> >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >> index 7028f7b74f..1eff312b51 100644 >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -1,6 +1,18 @@ >> config 64BIT >> bool >> >> +config PHYS_ADDR_32 >> + bool >> + help >> + Select this option if the physical addresses can be represented by >> + 32 bits. >> + >> +config PHYS_ADDR_64 >> + bool >> + help >> + Select this option if the physical addresses can be represented >> + 64 bits. > > These two config symbols should be defined in xen/arch/arm/Kconfig > (unless you plan to also define them for x86). We discussed with Jan to consolidate types.h as RISC-V may want to use a 32-bit paddr_t. This would mean paddr_t would be defined a common header and therefore those config needs to be in common. I am not asking Ayan to work on the consolidation, but I think they should be defined in common (assuming arm will make use of it) and I would at least consider to add "select PHYS_ADDR_64" in "config X86". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 10:18:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 10:18:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493861.763905 (Exim 4.92) (envelope-from ) id 1pQmxq-0000pu-IB; Sat, 11 Feb 2023 10:18:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493861.763905; Sat, 11 Feb 2023 10:18:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmxq-0000pn-FH; Sat, 11 Feb 2023 10:18:38 +0000 Received: by outflank-mailman (input) for mailman id 493861; Sat, 11 Feb 2023 10:18:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmxo-0000pd-P5 for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 10:18:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQmxo-00042h-7g; Sat, 11 Feb 2023 10:18:36 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQmxo-0004so-18; Sat, 11 Feb 2023 10:18:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=cVJAihXUdoT1WrjTuvBVuBdjG71ZehDkZkPrX9UT74U=; b=bPTFZ/XdVjU8MoS998gxffCPnY epC5u1uBCUCpHTngM+PPoAsDQFgDjOO1C6qTssV4BjLt1msagjRgP1qZa31XFXvcY931spntSqXs4 7iJmu0xfCwUJRBbPdL2psUSvh6INKouWRIx3itRjgsrtzDzgWMPgHHuIEIDecJe1Ldis=; Message-ID: Date: Sat, 11 Feb 2023 10:18:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-9-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v3 8/9] xen/arm: Restrict zeroeth_table_offset for ARM_64 In-Reply-To: <20230208120529.22313-9-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/02/2023 12:05, Ayan Kumar Halder wrote: > When 32 bit physical addresses are used (ie ARM_PA_32=y), > "va >> ZEROETH_SHIFT" causes an overflow. > Also, there is no zeroeth level page table on Arm 32-bit. > > Also took the opportunity to clean up dump_pt_walk(). One could use > DECLARE_OFFSETS() macro instead of declaring the declaring an array > of page table offsets. Technically this is unrelated to the goal of the patch. So this should have been split in a separate patch. No need to split it this time, but in the future please consider to split a patch when a change is unrelated. In general, I would only consider to bundle clean-up if all the below applies: 1) the patch is not doing code movement 2) the change is simple (e.g. typo, coding style fix) 3) the change is in the vicinity of the the rest of code (i.e. it would be visible in the diff). > > Signed-off-by: Ayan Kumar Halder Acked-by: Julien Grall > --- > Changes from - > > v1 - Removed the duplicate declaration for DECLARE_OFFSETS. > > v2 - 1. Reworded the commit message. > 2. Use CONFIG_ARM_PA_32 to restrict zeroeth_table_offset. > > xen/arch/arm/include/asm/lpae.h | 4 ++++ > xen/arch/arm/mm.c | 7 +------ > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h > index 3fdd5d0de2..998edeed6e 100644 > --- a/xen/arch/arm/include/asm/lpae.h > +++ b/xen/arch/arm/include/asm/lpae.h > @@ -259,7 +259,11 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); > #define first_table_offset(va) TABLE_OFFSET(first_linear_offset(va)) > #define second_table_offset(va) TABLE_OFFSET(second_linear_offset(va)) > #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) > +#ifdef CONFIG_ARM_PA_32 > +#define zeroeth_table_offset(va) 0 > +#else > #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) > +#endif > > /* > * Macros to define page-tables: > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index b99806af99..44942c6a4f 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -221,12 +221,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr, > { > static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; > const mfn_t root_mfn = maddr_to_mfn(ttbr); > - const unsigned int offsets[4] = { > - zeroeth_table_offset(addr), > - first_table_offset(addr), > - second_table_offset(addr), > - third_table_offset(addr) > - }; > + DECLARE_OFFSETS(offsets, addr); > lpae_t pte, *mapping; > unsigned int level, root_table; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 10:22:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 10:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493869.763917 (Exim 4.92) (envelope-from ) id 1pQn1A-0002HF-7P; Sat, 11 Feb 2023 10:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493869.763917; Sat, 11 Feb 2023 10:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQn1A-0002H8-27; Sat, 11 Feb 2023 10:22:04 +0000 Received: by outflank-mailman (input) for mailman id 493869; Sat, 11 Feb 2023 10:22:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQn18-0002H2-Cu for xen-devel@lists.xenproject.org; Sat, 11 Feb 2023 10:22:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQn17-00046t-Rz; Sat, 11 Feb 2023 10:22:01 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQn17-0004wm-LW; Sat, 11 Feb 2023 10:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RkylwcnVRQ8Ks7T/orrI2njcPI5xZg9nC77qmsjPHUU=; b=MyaV0RsgWBqN9zjl5gFxk4z7Ev ktX4HP8rg8tku+nTm81Y4VqJouA+o9bVE4k4Ua6cuBQTyd7ilmUoUNxUV3+6rRFkmxGPbj/6Yz0p9 aRYRMgkZMClG4cTmCWwxKkMBxE7vDlFs9LP7OSpY65w8LlvA4QnAp8YfE6HzpjbBdgRI=; Message-ID: <0a532421-60b4-5b9b-31a6-24ffafbe1870@xen.org> Date: Sat, 11 Feb 2023 10:21:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 9/9] xen/arm: p2m: Enable support for 32bit IPA To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-10-ayan.kumar.halder@amd.com> From: Julien Grall In-Reply-To: <20230208120529.22313-10-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, On 08/02/2023 12:05, Ayan Kumar Halder wrote: > VTCR.T0SZ should be set as 0x20 to support 32bit IPA. > Refer ARM DDI 0487I.a ID081822, G8-9824, G8.2.171, VTCR, > "Virtualization Translation Control Register" for the bit descriptions. > > Signed-off-by: Ayan Kumar Halder > Acked-by: Stefano Stabellini This will need a respin based on the discussion we had in v2. The main things are: - 32-bit IPA will be using one page at the root (not 2 like for 40-bit IPA) - the code should be consolidate with arm64 as the logic is mainly the same. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 11 13:50:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 13:50:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493899.763928 (Exim 4.92) (envelope-from ) id 1pQqG5-0000hX-B5; Sat, 11 Feb 2023 13:49:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493899.763928; Sat, 11 Feb 2023 13:49:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQqG5-0000hQ-79; Sat, 11 Feb 2023 13:49:41 +0000 Received: by outflank-mailman (input) for mailman id 493899; Sat, 11 Feb 2023 13:49:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQqG3-0000hG-S7; Sat, 11 Feb 2023 13:49:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQqG3-0000CX-PU; Sat, 11 Feb 2023 13:49:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQqG3-0002DO-CH; Sat, 11 Feb 2023 13:49:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQqG3-0004tx-Bp; Sat, 11 Feb 2023 13:49:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j+HuC3edWidfp+kxhKznfgUkI17xNs/HwJApo+KB8+s=; b=svDFMnfiaflbQ/0SeMIGK+946o GGetnG3gzc8GdAXMygraus767iwpTAdv9eWrxYdaaPkfUu7FrU2eOGuft70XdIrY+abTWKD2/Ag4B JQSmQlL3H8UXcn/jikh/HJ1e6LNsmQuEqeYFn51DakvpNrRRWKm9X/zivvLy0vEC8WEA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 176926: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=092176e5ec2f45d3b56a9e131c5237c52712d804 X-Osstest-Versions-That: libvirt=86cfe93ef7fdc2d665a2fc88b79af89e7978ba78 From: osstest service owner Date: Sat, 11 Feb 2023 13:49:39 +0000 flight 176926 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176926/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 092176e5ec2f45d3b56a9e131c5237c52712d804 baseline version: libvirt 86cfe93ef7fdc2d665a2fc88b79af89e7978ba78 Last test of basis 176816 2023-02-10 04:18:47 Z 1 days Testing same since 176926 2023-02-11 04:20:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Boris Fiuczynski Laine Stump Michal Privoznik Praveen K Paladugu Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 86cfe93ef7..092176e5ec 092176e5ec2f45d3b56a9e131c5237c52712d804 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 11 18:30:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 18:30:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493935.763939 (Exim 4.92) (envelope-from ) id 1pQudB-0007ND-1b; Sat, 11 Feb 2023 18:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493935.763939; Sat, 11 Feb 2023 18:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQudA-0007N6-Uv; Sat, 11 Feb 2023 18:29:48 +0000 Received: by outflank-mailman (input) for mailman id 493935; Sat, 11 Feb 2023 18:29:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQud9-0007Md-Ks; Sat, 11 Feb 2023 18:29:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQud9-0007PS-HY; Sat, 11 Feb 2023 18:29:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQud9-0002gJ-5B; Sat, 11 Feb 2023 18:29:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQud9-0001Za-4k; Sat, 11 Feb 2023 18:29:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iTeNhdLunNW8xGVX6pFum6Nq7A7cwxpiaquBD+PZVDo=; b=CmuWppIaQbLc+F1k2QWgJTCocL 5m1OchWpxOaeeWhT4+5hlEw4FRdlJXgIzRdj9BNCIBVigVjQNYUXmHjK1uc4EEGwTeIPcnHTjwnGc qBJc/BL3bAAhCM4wLur5u+/fI7HTqIwgkf/KryfWr0dcqY12XyW/CyiqFN+t0lcwGgT4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176941: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=420b2d431d18a2572c8e86579e78105cb5ed45b0 X-Osstest-Versions-That: linux=38c1e0c65865426676123cc9a127526fa02bcac6 From: osstest service owner Date: Sat, 11 Feb 2023 18:29:47 +0000 flight 176941 linux-linus real [real] flight 176981 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/176941/ http://logs.test-lab.xenproject.org/osstest/logs/176981/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 176875 Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 176981-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176875 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 420b2d431d18a2572c8e86579e78105cb5ed45b0 baseline version: linux 38c1e0c65865426676123cc9a127526fa02bcac6 Last test of basis 176875 2023-02-10 16:48:08 Z 1 days Testing same since 176941 2023-02-11 07:35:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Firago Amadeusz Sławiński Andy Chi Andy Shevchenko Andy Yan AngeloGioacchino Del Regno Arnaud Ferraris Arnd Bergmann Artemii Karasev Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Chukun Pan Claudiu Beznea Conor Dooley Corentin Labbe Dan Carpenter Dan Johansen Daniel Beer Dmitry Torokhov Edson Juliano Drosdeck Elvis Angelaccio FUKAUMI Naoki Geert Uytterhoeven Guillaume Pinot Guo Ren Guo Ren Guodong Liu Heiko Stuebner Heiner Kallweit Ilya Dryomov Jack Yu Jarrah Gosbell Jens Axboe Jensen Huang Jerome Brunet Jim Minter Joel Stanley Johan Jonker Jonas Karlman Krzysztof Kozlowski Linus Torvalds Linus Walleij Liu Shixin Lorenzo Pieralisi Mario Limonciello Mark Brown Mark Enriquez Martin Blumenstingl Matthias Brugger Maxim Korotkov Mayuresh Chitale Michael Riesch Mika Westerberg Neil Armstrong Palmer Dabbelt Patrice Chotard Paul Cercueil Peter Suti Samuel Holland Shengjiu Wang Stefan Binding Stephen Boyd Takashi Iwai Thomas Witt Tom Rix V sujith kumar Reddy Vyacheslav Bocharov Xiubo Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1334 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 11 21:30:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 11 Feb 2023 21:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493957.763949 (Exim 4.92) (envelope-from ) id 1pQxS5-0003HL-Sr; Sat, 11 Feb 2023 21:30:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493957.763949; Sat, 11 Feb 2023 21:30:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQxS5-0003HE-Pw; Sat, 11 Feb 2023 21:30:33 +0000 Received: by outflank-mailman (input) for mailman id 493957; Sat, 11 Feb 2023 21:30:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQxS5-0003H4-Au; Sat, 11 Feb 2023 21:30:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQxS5-00037w-71; Sat, 11 Feb 2023 21:30:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQxS4-0000v9-UY; Sat, 11 Feb 2023 21:30:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pQxS4-0005pU-U5; Sat, 11 Feb 2023 21:30:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jjBEYaqAxkqyuwKGqk54ZCtfdyU5qbyw2zP7DuEHjwQ=; b=dZZCC3gKxacunAYIzgBEEdQ/IB CMoJXQlbzjCV5p9jZGX2bVCwwKKfbQKZugP7fg4opwh9dQ9pJ24PLPFLnVqjJSeShslPvQB+MOhzw vjpfxqbK+r/VxXS8iBcSbf3AFdaHx4QD+UO7pf2TTSHxnfzlkUxuQTHJr9fq7oRowgxs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 176948: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=4e0b4ccfc504f26187939068796295340ffd0e2f From: osstest service owner Date: Sat, 11 Feb 2023 21:30:32 +0000 flight 176948 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176948/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 176769 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 176906 pass in 176948 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 176906 pass in 176948 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 176906 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176769 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 4e0b4ccfc504f26187939068796295340ffd0e2f Last test of basis 176769 2023-02-09 18:40:48 Z 2 days Testing same since 176855 2023-02-10 12:17:08 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig George Dunlap Henry Wang Ian Jackson Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/shskt: Disable CET-SS on parts susceptible to fractured updates Refer to Intel SDM Rev 70 (Dec 2022), Vol3 17.2.3 "Supervisor Shadow Stack Token". Architecturally, an event delivery which starts in CPL<3 and switches shadow stack will first validate the Supervisor Shadow Stack Token (setting the busy bit), then pushes CS/LIP/SSP. One example of this is an NMI interrupting Xen. Some CPUs suffer from an issue called fracturing, whereby a fault/vmexit/etc between setting the busy bit and completing the event injection renders the action non-restartable, because when it comes time to restart, the busy bit is found to be already set. This is far more easily encountered under virt, yet it is not the fault of the hypervisor, nor the fault of the guest kernel. The fault lies somewhere between the architectural specification, and the uarch behaviour. Intel have allocated CPUID.7[1].ecx[18] CET_SSS to enumerate that supervisor shadow stacks are safe to use. Because of how Xen lays out its shadow stacks, fracturing is not expected to be a problem on native. Detect this case on boot and default to not using shstk if virtualised. Specifying `cet=shstk` on the command line will override this heuristic and enable shadow stacks irrespective. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit b4a23bf6293aadecfd03bf9e83974443e2eac9cb Author: Andrew Cooper Date: Fri Oct 28 11:40:00 2022 +0100 x86/cpuid: Infrastructure for leaves 7:1{ecx,edx} We don't actually need ecx yet, but adding it in now will reduce the amount to which leaf 7 is out of order in a featureset. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 789ed08abb8f5e411cf06f6acb61c2d261f625da Author: Juergen Gross Date: Thu Feb 9 15:41:48 2023 +0100 docs: clarify xenstore permission documentation In docs/misc/xenstore.txt the description of the Xenstore node access permissions is missing one important aspect, which can be found only in the code or in the wiki [1]: The first permission entry is defining the owner of the node via the domid, and the access rights for all domains NOT having a dedicated permission entry. Make that aspect clear in the official documentation. [1]: https://wiki.xenproject.org/wiki/XenBus#Permissions Reported-by: Edwin Török Signed-off-by: Juergen Gross Reviewed-by: Julien Grall commit d184b26db2b29b5f610b61c43580becd7a4057b1 Author: Juergen Gross Date: Thu Feb 9 15:23:57 2023 +0100 SUPPORT.md: update version to 4.18-unstable The current version is no longer 4.17-rc. Update it to "4.18-unstable". Signed-off-by: Juergen Gross Acked-by: Andrew Cooper commit e51d31f79edc10f8d622e7f5bf4b935af6d4618f Author: Andrew Cooper Date: Thu Feb 9 15:25:10 2023 +0000 tools/ocaml: Drop libxl and xentoollog bindings There are significant issues with these bindings (they segfault for starters) and their companion half in Xapi was deleted in 2018 https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d owing to there having been no development of these bindings since 2014. In the unlikely event that we'd want to reinstate them, they'd need reworking basically from scratch anyway. Signed-off-by: Andrew Cooper Acked-by: Christian Lindig commit bf652a50fb3bb3b1b3d93db6fb79bc28f978fe75 Author: Anthony PERARD Date: Thu Feb 9 16:14:48 2023 +0000 libs/util: Fix parallel build between flex/bison and CC rules flex/bison generate two targets, and when those targets are prerequisite of other rules they are considered independently by make. We can have a situation where the .c file is out-of-date but not the .h, git checkout for example. In this case, if a rule only have the .h file as prerequiste, make will procced and start to build the object. In parallel, another target can have the .c file as prerequisite and make will find out it need re-generating and do so, changing the .h at the same time. This parallel task breaks the first one. To avoid this scenario, we put both the header and the source as prerequisite for all object even if they only need the header. Reported-by: Andrew Cooper Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 52493ec3e32a6e631b3ae3571db7ed41f10d9b06 Author: Anthony PERARD Date: Thu Feb 9 12:11:40 2023 +0000 libs/util: Remove unused headers in libxlu_pci.c libxlu_pci.c doesn't use any "xlu__cfg*()" functions and doesn't use any of the disk parsing functions "xlu__disk*()", so all those headers can be removed. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper commit 5b46dd85d051ceecc2c00a0de27f03e571bff379 Author: Julien Grall Date: Fri Jan 27 18:55:46 2023 +0000 tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall Reviewed-by: Henry Wang Tested-by: Henry Wang Reviewed-by: Juergen Gross commit 4e0e7a29d2fe318e4e60e77a56773b4d020ebc6a Author: Julien Grall Date: Thu Feb 9 17:07:28 2023 +0000 docs/process: branching-checklist: Clarify steps to add the branch in osstest The steps to add the new branch in osstest doesn't mention the change should be committed. Update the steps to clarify that. Take the opportunity to switch to use $v instead hardcoded version. Signed-off-by: Julien Grall Reviewed-by: Henry Wang commit 6a6ae4ac349ee31030d4fb3952f2c3b48e60d09f Author: Julien Grall Date: Thu Feb 9 17:07:13 2023 +0000 docs/process: branching-checklist: Remove reference to root The steps to generate the documentation for the new branch requires to ssh as root and then su to run with the user xendocs. The release technician may not (and should not) have access to root. So update the step to directly ssh as xendocs. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang commit f87a15f5cce5c76c3d8028b7129f3a1abf1d6b7d Author: Julien Grall Date: Thu Feb 9 17:04:41 2023 +0000 docs/process: branching-checklist: Remove reference to qemu-ijw.git Per [1], qemu-iwj.git was a clone of QEMU traditional on Ian's computer for tagging QEMU trad. The next section will provide tag for the official tree. So remove the section about qemu-ijw.git. [1] 25482.10006.140155.984629@chiark.greenend.org.uk Signed-off-by: Julien Grall Acked-by: George Dunlap Acked-by: Ian Jackson Reviewed-by: Henry Wang commit 5dbe775c2b622a9473ddb9492db63cc320d562c4 Author: Julien Grall Date: Thu Feb 9 17:04:30 2023 +0000 docs/process: branching-checklist: Use consistent indentation At the moment, branch-checklist.txt is using a mix of soft and hard tab. They are both meant to be represented using 8 characters. In Xen we tend to use 4-space softtab represented with 4 characters. So to avoid having to use a different editor configuration, switch all the indentation to 4-space softtab. Signed-off-by: Julien Grall Acked-by: George Dunlap Reviewed-by: Henry Wang (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sun Feb 12 02:46:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 12 Feb 2023 02:46:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493972.763961 (Exim 4.92) (envelope-from ) id 1pR2NX-0003He-5S; Sun, 12 Feb 2023 02:46:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493972.763961; Sun, 12 Feb 2023 02:46:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR2NW-0003HG-Vy; Sun, 12 Feb 2023 02:46:10 +0000 Received: by outflank-mailman (input) for mailman id 493972; Sun, 12 Feb 2023 02:46:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR2NU-0003H6-QY; Sun, 12 Feb 2023 02:46:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR2NU-0001jU-O1; Sun, 12 Feb 2023 02:46:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR2NU-0006rV-8r; Sun, 12 Feb 2023 02:46:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pR2NU-00073o-8N; Sun, 12 Feb 2023 02:46:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BZK67UzwHTzMxr4NkOYYx3B3q9XOhmjiP/K06SQF5bU=; b=m0jlGPjKcQVoImv/cDED78A5jn WGSeOL0Mmn3/gYx2v2Q3scnq8BeHqF1YH1Ae/jFFyM3Hiwe41kl+4ZuGlsdU8PSVQdPLarYZylteO bErwBVEqxLsOhiw0moFyuruO5FK5MTrQJ15mtj+HNBEStGIKwUGbJTAE70bgY42utJCE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 176989: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-coresched-amd64-xl::broken:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-amd64-coresched-amd64-xl:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=420b2d431d18a2572c8e86579e78105cb5ed45b0 X-Osstest-Versions-That: linux=38c1e0c65865426676123cc9a127526fa02bcac6 From: osstest service owner Date: Sun, 12 Feb 2023 02:46:08 +0000 flight 176989 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176989/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 176875 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 176875 Tests which are failing intermittently (not blocking): test-amd64-coresched-amd64-xl 5 host-install(5) broken pass in 176941 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176875 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 420b2d431d18a2572c8e86579e78105cb5ed45b0 baseline version: linux 38c1e0c65865426676123cc9a127526fa02bcac6 Last test of basis 176875 2023-02-10 16:48:08 Z 1 days Testing same since 176941 2023-02-11 07:35:11 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Firago Amadeusz Sławiński Andy Chi Andy Shevchenko Andy Yan AngeloGioacchino Del Regno Arnaud Ferraris Arnd Bergmann Artemii Karasev Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Chukun Pan Claudiu Beznea Conor Dooley Corentin Labbe Dan Carpenter Dan Johansen Daniel Beer Dmitry Torokhov Edson Juliano Drosdeck Elvis Angelaccio FUKAUMI Naoki Geert Uytterhoeven Guillaume Pinot Guo Ren Guo Ren Guodong Liu Heiko Stuebner Heiner Kallweit Ilya Dryomov Jack Yu Jarrah Gosbell Jens Axboe Jensen Huang Jerome Brunet Jim Minter Joel Stanley Johan Jonker Jonas Karlman Krzysztof Kozlowski Linus Torvalds Linus Walleij Liu Shixin Lorenzo Pieralisi Mario Limonciello Mark Brown Mark Enriquez Martin Blumenstingl Matthias Brugger Maxim Korotkov Mayuresh Chitale Michael Riesch Mika Westerberg Neil Armstrong Palmer Dabbelt Patrice Chotard Paul Cercueil Peter Suti Samuel Holland Shengjiu Wang Stefan Binding Stephen Boyd Takashi Iwai Thomas Witt Tom Rix V sujith kumar Reddy Vyacheslav Bocharov Xiubo Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl broken test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-coresched-amd64-xl broken broken-step test-amd64-coresched-amd64-xl host-install(5) Not pushing. (No revision log; it would be 1334 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 12 07:54:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 12 Feb 2023 07:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.493995.763972 (Exim 4.92) (envelope-from ) id 1pR7Ao-0004Am-Lw; Sun, 12 Feb 2023 07:53:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 493995.763972; Sun, 12 Feb 2023 07:53:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR7Ao-0004Af-IZ; Sun, 12 Feb 2023 07:53:22 +0000 Received: by outflank-mailman (input) for mailman id 493995; Sun, 12 Feb 2023 07:53:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR7Am-0004AV-NB; Sun, 12 Feb 2023 07:53:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR7Am-0000vU-Js; Sun, 12 Feb 2023 07:53:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pR7Am-0001Ca-4I; Sun, 12 Feb 2023 07:53:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pR7Am-0004x1-3r; Sun, 12 Feb 2023 07:53:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6hY0kDhunBxbP1djv/v204AcK1pPtWGa9dhgjCFKh14=; b=z7fQ34SR9LbzE82i9PKeSvor/O 8Q0s3Odh+4So+jZSjTF6E6WbWTNGvxWBIqMKug4L3BrqjXCZEsWDF4xXuXSE5S6rkWHOhroofNaH7 1TmYuvLUOP3kUEQVJYNOXqqtmj1tMVhhqKaM5SP8zB+Ro6pp5zTfU32TKKrt56PpoZws=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177001: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=4e0b4ccfc504f26187939068796295340ffd0e2f From: osstest service owner Date: Sun, 12 Feb 2023 07:53:20 +0000 flight 177001 xen-unstable real [real] flight 177042 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177001/ http://logs.test-lab.xenproject.org/osstest/logs/177042/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 177042-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176769 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176769 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176769 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176769 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 4e0b4ccfc504f26187939068796295340ffd0e2f Last test of basis 176769 2023-02-09 18:40:48 Z 2 days Testing same since 176855 2023-02-10 12:17:08 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig George Dunlap Henry Wang Ian Jackson Juergen Gross Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4e0b4ccfc5..01e7477d1b 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 -> master From xen-devel-bounces@lists.xenproject.org Sun Feb 12 13:38:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 12 Feb 2023 13:38:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494041.764031 (Exim 4.92) (envelope-from ) id 1pRCYC-0000Zh-Tx; Sun, 12 Feb 2023 13:37:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494041.764031; Sun, 12 Feb 2023 13:37:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRCYC-0000Za-Qa; Sun, 12 Feb 2023 13:37:52 +0000 Received: by outflank-mailman (input) for mailman id 494041; Sun, 12 Feb 2023 13:37:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRCYC-0000ZQ-44; Sun, 12 Feb 2023 13:37:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRCYC-0000ul-1i; Sun, 12 Feb 2023 13:37:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRCYB-0007fA-Nv; Sun, 12 Feb 2023 13:37:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRCYB-0003H1-NR; Sun, 12 Feb 2023 13:37:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9fKW7RMXwTfILxGgE5B6MFxVDq49c56TC1oFREr8Bd0=; b=wDbCAVVpDP+hBc7c1Smf6Cq5yM t/YxJQQCsgB3bYav9pylSN+d/Cf5TevY81EVmLL8aJcEnK9uXNYmGeCMuOPiQ6Plt3/VX5uw4yQ/l xQOFHIOwaMB2DcYTj/JOuzUrGIViNie1BenjvDF7AB1BUblxBHebX0g8C1Z8YIKAzmm8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177026: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f339c2597ebb00e738f2b6328c14804ed19f5d57 X-Osstest-Versions-That: linux=38c1e0c65865426676123cc9a127526fa02bcac6 From: osstest service owner Date: Sun, 12 Feb 2023 13:37:51 +0000 flight 177026 linux-linus real [real] flight 177069 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177026/ http://logs.test-lab.xenproject.org/osstest/logs/177069/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 176875 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176875 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f339c2597ebb00e738f2b6328c14804ed19f5d57 baseline version: linux 38c1e0c65865426676123cc9a127526fa02bcac6 Last test of basis 176875 2023-02-10 16:48:08 Z 1 days Failing since 176941 2023-02-11 07:35:11 Z 1 days 3 attempts Testing same since 177026 2023-02-12 02:50:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Thompson Alexey Firago Amadeusz Sławiński Andy Chi Andy Shevchenko Andy Yan AngeloGioacchino Del Regno Arnaud Ferraris Arnd Bergmann Artemii Karasev Bartosz Golaszewski Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Chukun Pan Claudiu Beznea Conor Dooley Corentin Labbe Dan Carpenter Dan Johansen Dan Williams Daniel Beer Dave Hansen Dmitry Torokhov Edson Juliano Drosdeck Elvis Angelaccio Fan Ni FUKAUMI Naoki Geert Uytterhoeven Gregory Price Guillaume Pinot Guo Ren Guo Ren Guodong Liu Heiko Stuebner Heiner Kallweit Ilya Dryomov Jack Yu Jarrah Gosbell Jens Axboe Jensen Huang Jerome Brunet Jim Minter Joel Stanley Johan Jonker Jonas Karlman Kan Liang Krzysztof Kozlowski Linus Torvalds Linus Walleij Liu Shixin Lorenzo Pieralisi Mario Limonciello Mark Brown Mark Enriquez Martin Blumenstingl Matthias Brugger Max Krummenacher Maxim Korotkov Mayuresh Chitale Michael Riesch Mika Westerberg Mike Rapoport (IBM) Nadav Amit Neil Armstrong Palmer Dabbelt Patrice Chotard Paul Cercueil Peter Suti Peter Zijlstra (Intel) Randy Dunlap Samuel Holland Serge Semin Shengjiu Wang Stefan Binding Stephen Boyd Takashi Iwai Thomas Gleixner Thomas Witt Tom Rix Tony Luck V sujith kumar Reddy Vishal Verma Vyacheslav Bocharov Wander Lairson Costa Xiubo Li Yu Zhao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1875 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 12 16:43:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 12 Feb 2023 16:43:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494067.764045 (Exim 4.92) (envelope-from ) id 1pRFQv-0004ki-5d; Sun, 12 Feb 2023 16:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494067.764045; Sun, 12 Feb 2023 16:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRFQv-0004kb-1e; Sun, 12 Feb 2023 16:42:33 +0000 Received: by outflank-mailman (input) for mailman id 494067; Sun, 12 Feb 2023 16:42:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRFQt-0004kR-6O; Sun, 12 Feb 2023 16:42:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRFQt-0005V2-3v; Sun, 12 Feb 2023 16:42:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRFQs-0006NA-Kd; Sun, 12 Feb 2023 16:42:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRFQs-0006da-K9; Sun, 12 Feb 2023 16:42:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n0ogCTD5jGqPD/rHSLM39JbDPPl0DhdXI2oRZ/+JEK4=; b=55Xoh8/+MUGGoY7HZ9cTpfporf 41LU8k3hogua89jl0w1VjGXSC42Mwrv9w2Le1UKrBKXcjOMYkyIsqOVcUiIDB6AEK7V13cKr1Impw tXHDEXdGCZP+E1wG7qs3o6tG2/9QiBA4uie86kvo+aFDgxoCbVlCvJQDHh4u0bsrY+HQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177049: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: xen-unstable:build-arm64:xen-build:fail:regression xen-unstable:test-amd64-amd64-xl-multivcpu:guest-localmigrate/x10:fail:heisenbug xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start.2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 From: osstest service owner Date: Sun, 12 Feb 2023 16:42:30 +0000 flight 177049 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail REGR. vs. 177001 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-multivcpu 20 guest-localmigrate/x10 fail pass in 177001 Tests which did not succeed, but are not blocking: build-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 22 guest-start.2 fail blocked in 177001 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 177001 like 176948 test-arm64-arm64-xl 15 migrate-support-check fail in 177001 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 177001 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail in 177001 never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail in 177001 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 177001 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 177001 never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 177001 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 177001 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 177001 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 177001 never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 177001 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 177001 never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 177001 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 177001 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177001 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177001 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177001 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177001 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177001 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177001 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177001 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177001 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177001 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Last test of basis 177049 2023-02-12 07:56:00 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 fail build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Feb 12 20:11:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 12 Feb 2023 20:11:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494085.764056 (Exim 4.92) (envelope-from ) id 1pRIga-0002jZ-1F; Sun, 12 Feb 2023 20:10:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494085.764056; Sun, 12 Feb 2023 20:10:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRIgZ-0002jS-Up; Sun, 12 Feb 2023 20:10:55 +0000 Received: by outflank-mailman (input) for mailman id 494085; Sun, 12 Feb 2023 20:10:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRIgY-0002jI-LP; Sun, 12 Feb 2023 20:10:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRIgY-000240-Ix; Sun, 12 Feb 2023 20:10:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRIgY-0003IL-6V; Sun, 12 Feb 2023 20:10:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRIgY-0007LX-65; Sun, 12 Feb 2023 20:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Fct9JDP4xpVHcv4uoK1cMRxoNY1GCTC9AjD4jq+L3dM=; b=gFfd2psJmbgPNg+PhFm0mryz6+ lm2NyQ1sVPvownLUxYcyeUzYRfL4ppEa8qbdHUC2b6iryeX3KqyCujbu36zdrYlQRnS+Kf1WSHi5F fKwBo3Yd8Ez/MB95rXqSeVHZZcHzxyO06461CB3A05V+Rkmuzy7GLfi89IQ4TFx/N+n0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177074: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f339c2597ebb00e738f2b6328c14804ed19f5d57 X-Osstest-Versions-That: linux=38c1e0c65865426676123cc9a127526fa02bcac6 From: osstest service owner Date: Sun, 12 Feb 2023 20:10:54 +0000 flight 177074 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177074/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176875 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176875 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176875 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f339c2597ebb00e738f2b6328c14804ed19f5d57 baseline version: linux 38c1e0c65865426676123cc9a127526fa02bcac6 Last test of basis 176875 2023-02-10 16:48:08 Z 2 days Failing since 176941 2023-02-11 07:35:11 Z 1 days 4 attempts Testing same since 177026 2023-02-12 02:50:43 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Thompson Alexey Firago Amadeusz Sławiński Andy Chi Andy Shevchenko Andy Yan AngeloGioacchino Del Regno Arnaud Ferraris Arnd Bergmann Artemii Karasev Bartosz Golaszewski Bjorn Helgaas Chen-Yu Tsai Christoph Hellwig Chukun Pan Claudiu Beznea Conor Dooley Corentin Labbe Dan Carpenter Dan Johansen Dan Williams Daniel Beer Dave Hansen Dmitry Torokhov Edson Juliano Drosdeck Elvis Angelaccio Fan Ni FUKAUMI Naoki Geert Uytterhoeven Gregory Price Guillaume Pinot Guo Ren Guo Ren Guodong Liu Heiko Stuebner Heiner Kallweit Ilya Dryomov Jack Yu Jarrah Gosbell Jens Axboe Jensen Huang Jerome Brunet Jim Minter Joel Stanley Johan Jonker Jonas Karlman Kan Liang Krzysztof Kozlowski Linus Torvalds Linus Walleij Liu Shixin Lorenzo Pieralisi Mario Limonciello Mark Brown Mark Enriquez Martin Blumenstingl Matthias Brugger Max Krummenacher Maxim Korotkov Mayuresh Chitale Michael Riesch Mika Westerberg Mike Rapoport (IBM) Nadav Amit Neil Armstrong Palmer Dabbelt Patrice Chotard Paul Cercueil Peter Suti Peter Zijlstra (Intel) Randy Dunlap Samuel Holland Serge Semin Shengjiu Wang Stefan Binding Stephen Boyd Takashi Iwai Thomas Gleixner Thomas Witt Tom Rix Tony Luck V sujith kumar Reddy Vishal Verma Vyacheslav Bocharov Wander Lairson Costa Xiubo Li Yu Zhao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 38c1e0c65865..f339c2597ebb f339c2597ebb00e738f2b6328c14804ed19f5d57 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Feb 13 03:36:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 03:36:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494113.764066 (Exim 4.92) (envelope-from ) id 1pRPcl-0007ML-Ol; Mon, 13 Feb 2023 03:35:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494113.764066; Mon, 13 Feb 2023 03:35:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRPcl-0007ME-Lz; Mon, 13 Feb 2023 03:35:27 +0000 Received: by outflank-mailman (input) for mailman id 494113; Mon, 13 Feb 2023 03:35:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRPck-0007M4-SU; Mon, 13 Feb 2023 03:35:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRPck-00047I-Nt; Mon, 13 Feb 2023 03:35:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRPck-0000NA-BE; Mon, 13 Feb 2023 03:35:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRPck-0001Xu-Ak; Mon, 13 Feb 2023 03:35:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F4lpSoyLn02nYAMkwCxTHCM0KRCVwUKWJyiRKz0GLak=; b=cgcGJfKPxNbnyP3368e/scGAdJ F3Y9TdIMD/68Lq00CCmJBXYMjZ7QzqpKVfAv4mUTJeJ7DJAgh1SagT5B5poJBIV96PHSr9qQSM8lI 36wTg5/GAFXzxFME7kB29yJ3tGW5bKZbm2nVcvli7KF2pJ+wjRjckVQrqefJEMaLZAEs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177104: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=711e9a4d52bf4e477e51c7135e1e6188c42018d0 X-Osstest-Versions-That: linux=f339c2597ebb00e738f2b6328c14804ed19f5d57 From: osstest service owner Date: Mon, 13 Feb 2023 03:35:26 +0000 flight 177104 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177104/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177074 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177074 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177074 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177074 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177074 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 711e9a4d52bf4e477e51c7135e1e6188c42018d0 baseline version: linux f339c2597ebb00e738f2b6328c14804ed19f5d57 Last test of basis 177074 2023-02-12 13:42:02 Z 0 days Testing same since 177104 2023-02-12 20:42:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anand Jain Ard Biesheuvel Chunwei Chen Darren Hart David Chen David Sterba Dennis Wassenberg Filipe Manana Greg Kroah-Hartman Josef Bacik Justin He Linus Torvalds Mark Pearson Michael Ellerman Miroslav Zatko Nicholas Piggin Paul Cercueil Prashant Malani Randy Dunlap Sachin Sant Sascha Hauer jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f339c2597ebb..711e9a4d52bf 711e9a4d52bf4e477e51c7135e1e6188c42018d0 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Feb 13 06:12:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 06:12:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494125.764078 (Exim 4.92) (envelope-from ) id 1pRS4Z-00086H-2i; Mon, 13 Feb 2023 06:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494125.764078; Mon, 13 Feb 2023 06:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRS4Y-00086A-W6; Mon, 13 Feb 2023 06:12:18 +0000 Received: by outflank-mailman (input) for mailman id 494125; Mon, 13 Feb 2023 06:12:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRS4X-000861-P7 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 06:12:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a644143-ab65-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 07:12:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3069333736; Mon, 13 Feb 2023 06:12:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FFAD1391B; Mon, 13 Feb 2023 06:12:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9j1ZCrrU6WN8fgAAMHmgww (envelope-from ); Mon, 13 Feb 2023 06:12:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a644143-ab65-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676268731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BLdwPfB+4D/AiyM/5+E2+N6MgxDwomI5dtk8SFrgHHI=; b=Dh4tr5axouvn57uHXUo/tVOszMBnsH+LXCzpAOSNUz61N2ao49WLs5JvpzhqxZc6v6QCuB //emi67roNziesAk/rv1qQu7gRqD5yWFYkjlRlhanifbveQMs0sJaDTVxMtOemeMCAz138 WjCbiHjT352CscnHZ0JDBOuXu5VIM9c= Message-ID: Date: Mon, 13 Feb 2023 07:12:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Content-Language: en-US To: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" Cc: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "lists@nerdbynature.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" References: <20230209072220.6836-1-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------f1vstKnhITA2oOGQSyz67zP0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------f1vstKnhITA2oOGQSyz67zP0 Content-Type: multipart/mixed; boundary="------------ACsfdmS5eSJC8hchh3zvew2M"; protected-headers="v1" From: Juergen Gross To: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" Cc: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "lists@nerdbynature.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR References: <20230209072220.6836-1-jgross@suse.com> In-Reply-To: --------------ACsfdmS5eSJC8hchh3zvew2M Content-Type: multipart/mixed; boundary="------------WIiv0hoECcgZufueRJws0bAS" --------------WIiv0hoECcgZufueRJws0bAS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDIuMjMgMDE6MDYsIEVkZ2Vjb21iZSwgUmljayBQIHdyb3RlOg0KPiBPbiBUaHUs IDIwMjMtMDItMDkgYXQgMDg6MjIgKzAxMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU aGlzIHNlcmllcyB0cmllcyB0byBmaXggdGhlIHJhdGhlciBzcGVjaWFsIGNhc2Ugb2YgUEFU IGJlaW5nDQo+PiBhdmFpbGFibGUNCj4+IHdpdGhvdXQgaGF2aW5nIE1UUlJzIChlaXRoZXIg ZHVlIHRvIENPTkZJR19NVFJSIGJlaW5nIG5vdCBzZXQsIG9yDQo+PiBiZWNhdXNlIHRoZSBm ZWF0dXJlIGhhcyBiZWVuIGRpc2FibGVkIGUuZy4gYnkgYSBoeXBlcnZpc29yKS4NCj4gDQo+ IGRlYnVnX3ZtX3BndGFibGUgZmFpbHMgaW4gYSBLVk0gZ3Vlc3Qgd2l0aCBDT05GSUdfTVRS Uj15LiBDT05GSUdfTVRSUj1uDQo+IHN1Y2NlZWRzLg0KPiANCj4gWyAgICAwLjgzMDI4MF0g ZGVidWdfdm1fcGd0YWJsZTogW2RlYnVnX3ZtX3BndGFibGUgICAgICAgICBdOg0KPiBWYWxp ZGF0aW5nIGFyY2hpdGVjdHVyZSBwYWdlIHRhYmxlIGhlbHBlcnMNCj4gWyAgICAwLjgzMTkw Nl0gLS0tLS0tLS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQo+IFsgICAgMC44MzI3 MTFdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDEgYXQgbW0vZGVidWdfdm1fcGd0YWJsZS5jOjQ2 MQ0KPiBkZWJ1Z192bV9wZ3RhYmxlKzB4YjlhLzB4ZTE2DQo+IFsgICAgMC44MzM5OThdIE1v ZHVsZXMgbGlua2VkIGluOg0KPiBbICAgIDAuODM0NDUwXSBDUFU6IDAgUElEOiAxIENvbW06 IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA2LjIuMC1yYzcrDQo+ICMyMzY2DQo+IFsgICAgMC44 MzU0NjJdIFJJUDogMDAxMDpkZWJ1Z192bV9wZ3RhYmxlKzB4YjlhLzB4ZTE2DQo+IFsgICAg MC44MzYyMTddIENvZGU6IGUyIDNhIDczIDRhIDQ4IGM3IDAwIDAwIDAwIDAwIDAwIDQ4IDhi IGI0IDI0IGEwIDAwDQo+IDAwIDAwIDQ4IDhiIDU0IDI0IDYwIDQ4IDhiIDdjIDI0IDIwIDQ4 IGM0DQo+IFsgICAgMC44MzkwNjhdIFJTUDogMDAwMDpmZmZmYzkwMDAwMDEzZGUwIEVGTEFH UzogMDAwMTAyNDYNCj4gWyAgICAwLjgzOTczNV0gUkFYOiAwMDAwMDAwMDAwMDAwMDAwIFJC WDogZmZmZjg4ODEwMDA0ODg2OCBSQ1g6DQo+IGJmZmZmZmZmZmZmZmZmZjANCj4gWyAgICAw Ljg0MDY0Nl0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogMDAwMDAwMDA0MDAwMDAwMCBS REk6DQo+IDAwMDAwMDAwMDAwMDAwMDANCj4gWyAgICAwLjg0MTY2MV0gUkJQOiBmZmZmODg4 MTAwMDRkMTQwIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6DQo+IGZmZmY4ODgxMDAyODA4 ODANCj4gWyAgICAwLjg0MjYyNV0gUjEwOiAwMDAwMDAwMDAwMDAwMDAxIFIxMTogMDAwMDAw MDAwMDAwMDAwMSBSMTI6DQo+IGZmZmY4ODgxMDM4MTAyOTgNCj4gWyAgICAwLjg0MzU3NF0g UjEzOiBmZmZmODg4MTAwMDQ4NzgwIFIxNDogZmZmZmZmZmY4MjgyZTA5OSBSMTU6DQo+IDAw MDAwMDAwMDAwMDAwMDANCj4gWyAgICAwLjg0NDUyNF0gRlM6ICAwMDAwMDAwMDAwMDAwMDAw KDAwMDApIEdTOmZmZmY4ODgxM2JjMDAwMDAoMDAwMCkNCj4ga25sR1M6MDAwMDAwMDAwMDAw MDAwMA0KPiBbICAgIDAuODQ1NzA2XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1Iw OiAwMDAwMDAwMDgwMDUwMDMzDQo+IFsgICAgMC44NDY0OTldIENSMjogZmZmZjg4ODEzZmZm ZjAwMCBDUjM6IDAwMDAwMDAwMDIyMmQwMDEgQ1I0Og0KPiAwMDAwMDAwMDAwMzcwZWYwDQo+ IFsgICAgMC44NDc0NjRdIERSMDogMDAwMDAwMDAwMDAwMDAwMCBEUjE6IDAwMDAwMDAwMDAw MDAwMDAgRFIyOg0KPiAwMDAwMDAwMDAwMDAwMDAwDQo+IFsgICAgMC44NDg0MzJdIERSMzog MDAwMDAwMDAwMDAwMDAwMCBEUjY6IDAwMDAwMDAwZmZmZTBmZjAgRFI3Og0KPiAwMDAwMDAw MDAwMDAwNDAwDQo+IFsgICAgMC44NDkzNzFdIENhbGwgVHJhY2U6DQo+IFsgICAgMC44NDk2 OTldICA8VEFTSz4NCj4gWyAgICAwLjg0OTk5N10gID8gZGVzdHJveV9hcmdzKzB4MTMxLzB4 MTMxDQo+IFsgICAgMC44NTA0ODddICBkb19vbmVfaW5pdGNhbGwrMHg2MS8weDI1MA0KPiBb ICAgIDAuODUwOTgzXSAgPyByZGluaXRfc2V0dXArMHgyYy8weDJjDQo+IFsgICAgMC44NTE0 NTFdICBrZXJuZWxfaW5pdF9mcmVlYWJsZSsweDE4ZS8weDFkOA0KPiBbICAgIDAuODUyMDMz XSAgPyByZXN0X2luaXQrMHgxMzAvMHgxMzANCj4gWyAgICAwLjg1MjUzM10gIGtlcm5lbF9p bml0KzB4MTYvMHgxMjANCj4gWyAgICAwLjg1MzAzNV0gIHJldF9mcm9tX2ZvcmsrMHgxZi8w eDMwDQo+IFsgICAgMC44NTM1MDddICA8L1RBU0s+DQo+IFsgICAgMC44NTM4MDNdIC0tLVsg ZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAwMDAgXS0tLQ0KPiBbICAgIDAuODU0NDIxXSAtLS0t LS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0NCj4gWyAgICAwLjg1NTAyN10gV0FS TklORzogQ1BVOiAwIFBJRDogMSBhdCBtbS9kZWJ1Z192bV9wZ3RhYmxlLmM6NDYyDQo+IGRl YnVnX3ZtX3BndGFibGUrMHhiYWEvMHhlMTYNCj4gWyAgICAwLjg1NjExNV0gTW9kdWxlcyBs aW5rZWQgaW46DQo+IFsgICAgMC44NTY1MTddIENQVTogMCBQSUQ6IDEgQ29tbTogc3dhcHBl ci8wIFRhaW50ZWQ6DQo+IEcgICAgICAgIFcgICAgICAgICAgNi4yLjAtcmM3KyAjMjM2Ng0K PiBbICAgIDAuODU3NTYyXSBSSVA6IDAwMTA6ZGVidWdfdm1fcGd0YWJsZSsweGJhYS8weGUx Ng0KPiBbICAgIDAuODU4MTg2XSBDb2RlOiAwMCAwMCAwMCA0OCA4YiA1NCAyNCA2MCA0OCA4 YiA3YyAyNCAyMCA0OCBjMSBlNiAwYw0KPiBlOCA3OSAxOCA3ZiBmZSA4NSBjMCA3NSAwMiAw ZiAwYiA0OCA4YiA3Yg0KPiBbICAgIDAuODYwNzc4XSBSU1A6IDAwMDA6ZmZmZmM5MDAwMDAx M2RlMCBFRkxBR1M6IDAwMDEwMjQ2DQo+IFsgICAgMC44NjE1MTldIFJBWDogMDAwMDAwMDAw MDAwMDAwMCBSQlg6IGZmZmY4ODgxMDAwNDg4NjggUkNYOg0KPiBiZmZmZmZmZmZmZmZmZmYw DQo+IFsgICAgMC44NjI1MzBdIFJEWDogMDAwMDAwMDAwMDAwMDAwMCBSU0k6IDAwMDAwMDAw NDAwMDAwMDAgUkRJOg0KPiBmZmZmODg4MTAzODBlN2Y4DQo+IFsgICAgMC44NjM1MjJdIFJC UDogZmZmZjg4ODEwMDA0ZDE0MCBSMDg6IDAwMDAwMDAwMDAwMDAwMDAgUjA5Og0KPiBmZmZm ODg4MTAwMjgwODgwDQo+IFsgICAgMC44NjQ0NDldIFIxMDogMDAwMDAwMDAwMDAwMDAwMSBS MTE6IDAwMDAwMDAwMDAwMDAwMDEgUjEyOg0KPiBmZmZmODg4MTAzODEwMjk4DQo+IFsgICAg MC44NjU0NTRdIFIxMzogZmZmZjg4ODEwMDA0ODc4MCBSMTQ6IGZmZmZmZmZmODI4MmUwOTkg UjE1Og0KPiAwMDAwMDAwMDAwMDAwMDAwDQo+IFsgICAgMC44NjY0MDFdIEZTOiAgMDAwMDAw MDAwMDAwMDAwMCgwMDAwKSBHUzpmZmZmODg4MTNiYzAwMDAwKDAwMDApDQo+IGtubEdTOjAw MDAwMDAwMDAwMDAwMDANCj4gWyAgICAwLjg2NzQzOF0gQ1M6ICAwMDEwIERTOiAwMDAwIEVT OiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMw0KPiBbICAgIDAuODY4MTgxXSBDUjI6IGZm ZmY4ODgxM2ZmZmYwMDAgQ1IzOiAwMDAwMDAwMDAyMjJkMDAxIENSNDoNCj4gMDAwMDAwMDAw MDM3MGVmMA0KPiBbICAgIDAuODY5MDk3XSBEUjA6IDAwMDAwMDAwMDAwMDAwMDAgRFIxOiAw MDAwMDAwMDAwMDAwMDAwIERSMjoNCj4gMDAwMDAwMDAwMDAwMDAwMA0KPiBbICAgIDAuODcw MDI2XSBEUjM6IDAwMDAwMDAwMDAwMDAwMDAgRFI2OiAwMDAwMDAwMGZmZmUwZmYwIERSNzoN Cj4gMDAwMDAwMDAwMDAwMDQwMA0KPiBbICAgIDAuODcwOTQzXSBDYWxsIFRyYWNlOg0KPiBb ICAgIDAuODcxMjU5XSAgPFRBU0s+DQo+IFsgICAgMC44NzE1MzddICA/IGRlc3Ryb3lfYXJn cysweDEzMS8weDEzMQ0KPiBbICAgIDAuODcyMDMwXSAgZG9fb25lX2luaXRjYWxsKzB4NjEv MHgyNTANCj4gWyAgICAwLjg3MjUyMV0gID8gcmRpbml0X3NldHVwKzB4MmMvMHgyYw0KPiBb ICAgIDAuODczMDA1XSAga2VybmVsX2luaXRfZnJlZWFibGUrMHgxOGUvMHgxZDgNCj4gWyAg ICAwLjg3MzYwN10gID8gcmVzdF9pbml0KzB4MTMwLzB4MTMwDQo+IFsgICAgMC44NzQxMTZd ICBrZXJuZWxfaW5pdCsweDE2LzB4MTIwDQo+IFsgICAgMC44NzQ2MThdICByZXRfZnJvbV9m b3JrKzB4MWYvMHgzMA0KPiBbICAgIDAuODc1MTIzXSAgPC9UQVNLPg0KPiBbICAgIDAuODc1 NDExXSAtLS1bIGVuZCB0cmFjZSAwMDAwMDAwMDAwMDAwMDAwIF0tLS0NCg0KVGhhbmtzIGZv ciB0aGUgcmVwb3J0Lg0KDQpJJ2xsIGhhdmUgYSBsb29rLiBQcm9iYWJseSBJJ2xsIG5lZWQg dG8gcmUtYWRkIHRoZSBjaGVjayBmb3IgV0IgaW4gcGF0Y2ggNy4NCg0KDQpKdWVyZ2VuDQo= --------------WIiv0hoECcgZufueRJws0bAS Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WIiv0hoECcgZufueRJws0bAS-- --------------ACsfdmS5eSJC8hchh3zvew2M-- --------------f1vstKnhITA2oOGQSyz67zP0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp1LkFAwAAAAAACgkQsN6d1ii/Ey8p vgf+MX3FtPvUqJ51vtu71gdi2LkG2zaQaYoChzNf5zu+U0J5YzssQ7LR6Okpi/Zc+iX5xTror/gh XeVCOkkM9SZw6JLjeYl2h1R9NRrBJiNKp8QBb+JWp5SAQd692DaLTc5NoKOM61QvFIdaf5euT2ht /JAizM62UbOHfaIxRsRaUSllQTvb9WnRu+45FlSWK5hovc4uydZFkMMDhCvUQOTAKA2W9NmpZWKd YiUfoqItqz2Rd5ongLB5HbSkK2fOQIEQQ7Zjc7UbjNZwozZmyRaPW+Kf+dQ7CAH2RyQZMWZJdo62 QQ2FdAqolZZL5kzHpXG6sc2gGandAabKKgnCh/61iQ== =+cRs -----END PGP SIGNATURE----- --------------f1vstKnhITA2oOGQSyz67zP0-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 06:48:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 06:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494133.764088 (Exim 4.92) (envelope-from ) id 1pRScy-0003VG-O6; Mon, 13 Feb 2023 06:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494133.764088; Mon, 13 Feb 2023 06:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRScy-0003V9-LH; Mon, 13 Feb 2023 06:47:52 +0000 Received: by outflank-mailman (input) for mailman id 494133; Mon, 13 Feb 2023 06:47:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRScx-0003Uy-Iv for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 06:47:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5364316a-ab6a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 07:47:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EDAB835354; Mon, 13 Feb 2023 06:47:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B64C11391B; Mon, 13 Feb 2023 06:47:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bCkYKhLd6WOzDAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 06:47:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5364316a-ab6a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676270866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NlMwrQ+B8I/w6bXL/LW7Sau/IV5bLsON9okQ/ZmOaxI=; b=Q0vWAxLIJptSJLevPEJt2ZjLTlA+dagTglf+Fdm1Mz5itMGe95i7Uphqk7aH1qZulE9LGj E+BXB+1MvbQCxvjWrVZEr8xO868+CtiAyO52EW6ZdD/o4pzs4hgJ8PBnJNrzWe50RB3aX6 qSQ9ybD1O9VNaWBG6Ukqk6sGpdDqeR0= Message-ID: <7e4efddc-2006-5092-d025-0a431cda5957@suse.com> Date: Mon, 13 Feb 2023 07:47:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront Content-Language: en-US To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> <20230210185916.2qjo6yh7c3usheyp@begin> From: Juergen Gross In-Reply-To: <20230210185916.2qjo6yh7c3usheyp@begin> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PrFEyCxYjiP4ohKFKzj6DVV2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PrFEyCxYjiP4ohKFKzj6DVV2 Content-Type: multipart/mixed; boundary="------------fqimO9s0fMTKrHoCeSwrp6ZL"; protected-headers="v1" From: Juergen Gross To: Samuel Thibault , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Message-ID: <7e4efddc-2006-5092-d025-0a431cda5957@suse.com> Subject: Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront References: <20230210104628.14374-1-jgross@suse.com> <20230210104628.14374-8-jgross@suse.com> <20230210185916.2qjo6yh7c3usheyp@begin> In-Reply-To: <20230210185916.2qjo6yh7c3usheyp@begin> --------------fqimO9s0fMTKrHoCeSwrp6ZL Content-Type: multipart/mixed; boundary="------------Y6e47tOoLmM0IZqFj560FLQV" --------------Y6e47tOoLmM0IZqFj560FLQV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDIuMjMgMTk6NTksIFNhbXVlbCBUaGliYXVsdCB3cm90ZToNCj4gSnVlcmdlbiBH cm9zcywgbGUgdmVuLiAxMCBmw6l2ci4gMjAyMyAxMTo0NjoyOCArMDEwMCwgYSBlY3JpdDoN Cj4+ICsgICAgd2hpbGUgKCBsZW4gKQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBjb3VudCA9 IGxlbjsNCj4+ICsgICAgICAgIGlmICggY291bnQgPiBkZXYtPm1zaXplX21heCAtIDI0ICkN Cj4+ICsgICAgICAgICAgICBjb3VudCA9IGRldi0+bXNpemVfbWF4IC0gMjQ7DQo+IA0KPiAy NCBzaG91bGQgYmUgZGV0YWlsZWQsIHRvIGluY2x1ZGUgZS5nLiBzaXplb2YocDlfaGVhZGVy KSBhbmQgdGhlIHN1bSBvZg0KPiBzaXplcyBvZiB0aGUgZmllbGRzIChJJ20gc3VycHJpc2Vk IHRoYXQgaXQncyB0aGUgc2FtZSAyNCBmb3IgcmVhZCBhbmQNCj4gd3JpdGUsIG5vdGFibHkp Lg0KDQpJdCB3YXMganVzdCBhIGNvbW1vbiB2YWx1ZSBjaG9zZW4gdG8gYmUgbGFyZ2UgZW5v dWdoLiBJIGV2ZW4gY29uc2lkZXJlZA0KdG8gbGltaXQgdG8gYSBwb3dlciBvZiAyIG9yIGEg bXVsdGlwbGUgb2YgUEFHRV9TSVpFIGluc3RlYWQuDQoNCkluZGVwZW5kZW50IGZyb20gdGhl IGNob3NlbiBuZXcgdmFsdWUgb2YgY291bnQgSSBhZ3JlZSwgdGhhdCBhdCBsZWFzdCB0aGUN CnRlc3QgZm9yIGNvdW50IG5lZWRpbmcgdG8gYmUgbW9kaWZpZWQgc2hvdWxkIGJlIGRvbmUg d2l0aCBhbiBleGFjdCB2YWx1ZQ0KZm9yIHRoZSB1cHBlciBsaW1pdC4NCg0KPiANCj4+ICsg ICAgICAgIHNlbmRfOXAoZGV2LCByZXEsICJVTFUiLCBmaWQsIG9mZnNldCwgY291bnQpOw0K Pj4gKyAgICAgICAgcmN2XzlwKGRldiwgcmVxLCAiRCIsICZjb3VudCwgZGF0YSk7DQo+PiAr DQo+PiArICAgICAgICBpZiAoICFjb3VudCApDQo+PiArICAgICAgICAgICAgYnJlYWs7DQo+ PiArICAgICAgICBpZiAoIHJlcS0+cmVzdWx0ICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAg ICAgICAgICByZXQgPSAtMTsNCj4+ICsgICAgICAgICAgICBlcnJubyA9IEVJTzsNCj4gDQo+ IEknZCBzYXkgbG9nIHJlcS0+cmVzdWx0Pw0KDQpPa2F5Lg0KDQo+IA0KPj4gKyAgICAgICAg ICAgIGJyZWFrOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgcmV0ICs9IGNvdW50Ow0K Pj4gKyAgICAgICAgb2Zmc2V0ICs9IGNvdW50Ow0KPj4gKyAgICAgICAgZGF0YSArPSBjb3Vu dDsNCj4+ICsgICAgICAgIGxlbiAtPSBjb3VudDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAg ICBwdXRfZnJlZV9yZXEoZGV2LCByZXEpOw0KPj4gKw0KPj4gKyAgICByZXR1cm4gcmV0Ow0K Pj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IHA5X3dyaXRlKHN0cnVjdCBkZXZfOXBmcyAq ZGV2LCB1aW50MzJfdCBmaWQsIHVpbnQ2NF90IG9mZnNldCwNCj4+ICsgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHVpbnQ4X3QgKmRhdGEsIHVpbnQzMl90IGxlbikNCj4+ICt7DQo+PiAr ICAgIHN0cnVjdCByZXEgKnJlcSA9IGdldF9mcmVlX3JlcShkZXYpOw0KPj4gKyAgICBpbnQg cmV0ID0gMDsNCj4+ICsgICAgdWludDMyX3QgY291bnQ7DQo+PiArDQo+PiArICAgIGlmICgg IXJlcSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIGVycm5vID0gRUFHQUlOOw0KPj4gKyAg ICAgICAgcmV0dXJuIC0xOw0KPj4gKyAgICB9DQo+PiArICAgIHJlcS0+Y21kID0gUDlfQ01E X1dSSVRFOw0KPj4gKw0KPj4gKyAgICB3aGlsZSAoIGxlbiApDQo+PiArICAgIHsNCj4+ICsg ICAgICAgIGNvdW50ID0gbGVuOw0KPj4gKyAgICAgICAgaWYgKCBjb3VudCA+IGRldi0+bXNp emVfbWF4IC0gMjQgKQ0KPj4gKyAgICAgICAgICAgIGNvdW50ID0gZGV2LT5tc2l6ZV9tYXgg LSAyNDsNCj4gDQo+IFNhbWUgaGVyZS4NCg0KWWVzLg0KDQo+IA0KPj4gKyAgICAgICAgc2Vu ZF85cChkZXYsIHJlcSwgIlVMRCIsIGZpZCwgb2Zmc2V0LCBjb3VudCwgZGF0YSk7DQo+PiAr ICAgICAgICByY3ZfOXAoZGV2LCByZXEsICJVIiwgJmNvdW50KTsNCj4+ICsgICAgICAgIGlm ICggcmVxLT5yZXN1bHQgKQ0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIHJldCA9 IC0xOw0KPj4gKyAgICAgICAgICAgIGVycm5vID0gRUlPOw0KPiANCj4gU2FtZSBoZXJlLg0K DQpZZXMuDQoNCg0KSnVlcmdlbg0K --------------Y6e47tOoLmM0IZqFj560FLQV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Y6e47tOoLmM0IZqFj560FLQV-- --------------fqimO9s0fMTKrHoCeSwrp6ZL-- --------------PrFEyCxYjiP4ohKFKzj6DVV2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp3RIFAwAAAAAACgkQsN6d1ii/Ey/1 SAf3c8XTGStAtXmFWG6YRrJNI2dReIKhzTCgnvFNY/C4vqoYWrFVf6zLeawbNRgomE285h8PjMiM LxtkiZpGqLp4pBVG+MNoJaUNO40HmjmMkjepKhgj0xw2hE/ieHFacJ0vfR8vJ32JVgzhh4Q19+d2 PxUiPp4JbQKUaoMUVeiJMALCv/df1nDAc9AN/W1h5+JLIGMxzsdbZcfeYm2+By2YZrJzeUHmYwYh roSIdX5pHzJ3gXvS5T4SKkuTjfd5o3mGtOKW3IE/c3RO3UgyKgnmQqXe0qXvvXqU87esLbrFBttQ IsoKE9j31xyJTgNIEb+E7+8qgkqNLcapfNmAU36w =XyW/ -----END PGP SIGNATURE----- --------------PrFEyCxYjiP4ohKFKzj6DVV2-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:13:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494148.764103 (Exim 4.92) (envelope-from ) id 1pRTx6-0005g6-91; Mon, 13 Feb 2023 08:12:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494148.764103; Mon, 13 Feb 2023 08:12:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRTx6-0005fz-6P; Mon, 13 Feb 2023 08:12:44 +0000 Received: by outflank-mailman (input) for mailman id 494148; Mon, 13 Feb 2023 08:12:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRTx4-0005ft-IR for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:12:42 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e977e6d-ab76-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:12:40 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0684C67A96; Mon, 13 Feb 2023 08:12:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B6406138E6; Mon, 13 Feb 2023 08:12:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id maG3Kvbw6WOJMgAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:12:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e977e6d-ab76-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676275959; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Goj0CVYbqJm9f9dvo9/K7xYI+JDbxMaoqo4CZZFkBBk=; b=LQEMz/X/MWGXbrqTPHrYKwlbxa3iGttJOvMPqltHTvt6iWpcUhsSJsA8ivRxYAn505tiH1 YWPgsupEz7eQLntjATa0KJapT1vpEP+6wq1sPOSMfCu3z+COXwKAHqNZinKleJ6elF85tQ hRSvtR6JjWXasMKTeKQgCCUEsrCRfTM= Message-ID: Date: Mon, 13 Feb 2023 09:12:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH][next] xen: Replace one-element array with flexible-array member Content-Language: en-US To: "Gustavo A. R. Silva" , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------eNpq4uVnbNf970ybwQrjr0CB" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------eNpq4uVnbNf970ybwQrjr0CB Content-Type: multipart/mixed; boundary="------------BMX3LvNHt974ooZRj4nUmQiw"; protected-headers="v1" From: Juergen Gross To: "Gustavo A. R. Silva" , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Message-ID: Subject: Re: [PATCH][next] xen: Replace one-element array with flexible-array member References: In-Reply-To: --------------BMX3LvNHt974ooZRj4nUmQiw Content-Type: multipart/mixed; boundary="------------0z5CCKY7k5kyMrtZRYWOKqVY" --------------0z5CCKY7k5kyMrtZRYWOKqVY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMDI6MjgsIEd1c3Rhdm8gQS4gUi4gU2lsdmEgd3JvdGU6DQo+IE9uZS1l bGVtZW50IGFycmF5cyBhcmUgZGVwcmVjYXRlZCwgYW5kIHdlIGFyZSByZXBsYWNpbmcgdGhl bSB3aXRoIGZsZXhpYmxlDQo+IGFycmF5IG1lbWJlcnMgaW5zdGVhZC4gU28sIHJlcGxhY2Ug b25lLWVsZW1lbnQgYXJyYXkgd2l0aCBmbGV4aWJsZS1hcnJheQ0KPiBtZW1iZXIgaW4gc3Ry dWN0IHhlbl9wYWdlX2RpcmVjdG9yeS4NCj4gDQo+IFRoaXMgaGVscHMgd2l0aCB0aGUgb25n b2luZyBlZmZvcnRzIHRvIHRpZ2h0ZW4gdGhlIEZPUlRJRllfU09VUkNFDQo+IHJvdXRpbmVz IG9uIG1lbWNweSgpIGFuZCBoZWxwIHVzIG1ha2UgcHJvZ3Jlc3MgdG93YXJkcyBnbG9iYWxs eQ0KPiBlbmFibGluZyAtZnN0cmljdC1mbGV4LWFycmF5cz0zIFsxXS4NCj4gDQo+IFRoaXMg cmVzdWx0cyBpbiBubyBkaWZmZXJlbmNlcyBpbiBiaW5hcnkgb3V0cHV0Lg0KPiANCj4gTGlu azogaHR0cHM6Ly9naXRodWIuY29tL0tTUFAvbGludXgvaXNzdWVzLzc5DQo+IExpbms6IGh0 dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xpbnV4L2lzc3Vlcy8yNTUNCj4gTGluazogaHR0cHM6 Ly9nY2MuZ251Lm9yZy9waXBlcm1haWwvZ2NjLXBhdGNoZXMvMjAyMi1PY3RvYmVyLzYwMjkw Mi5odG1sIFsxXQ0KPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0 YXZvYXJzQGtlcm5lbC5vcmc+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jv c3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo= --------------0z5CCKY7k5kyMrtZRYWOKqVY Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0z5CCKY7k5kyMrtZRYWOKqVY-- --------------BMX3LvNHt974ooZRj4nUmQiw-- --------------eNpq4uVnbNf970ybwQrjr0CB Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8PYFAwAAAAAACgkQsN6d1ii/Ey+9 uQf/eQfbMt2KRzkI4NOdIg9qgtM1yIbcE6jCTytb2TlPZD1woI72l+dOp7H/O9blL0vuRMZcd7wk icr1zJWysBJ9ZSJSZyPbHwbwX9A37t8L+DvK6gIbgm8tg6Si1jHY9KlvvxrzWJx0Qwtcl0dptfZY 6gjk/PEgxzbh1+dwFBApHucTQLZoxr9WXQVpzItZobKArtLTLbnHjvz7Nnqoxh2ljkRvue0QqjhA xTZeBaoow5rzQOVCyt5v+u0xxuPm1h0k33q2ScNl5Eapli/Cez1mtmiQSIa4mg8QTr5kYTwZGk3f 7wE/ZmlgP8nl5gXkM/cGCX1ANdOSlmdL3puiPcVNhg== =gH+G -----END PGP SIGNATURE----- --------------eNpq4uVnbNf970ybwQrjr0CB-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:17:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:17:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494156.764115 (Exim 4.92) (envelope-from ) id 1pRU1u-0006St-0P; Mon, 13 Feb 2023 08:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494156.764115; Mon, 13 Feb 2023 08:17:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU1t-0006Sm-TW; Mon, 13 Feb 2023 08:17:41 +0000 Received: by outflank-mailman (input) for mailman id 494156; Mon, 13 Feb 2023 08:17:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU1s-0006Sg-P0 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:17:40 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1687f39-ab76-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:17:39 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3402E67AB1; Mon, 13 Feb 2023 08:17:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 068E5138E6; Mon, 13 Feb 2023 08:17:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eHcQACPy6WM6NQAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:17:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1687f39-ab76-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=StpQBZwza4sJYTV0zdJUm/BBOAaYyUvS/zTc8OBhzug=; b=OsU1ItPZOWgPikaPoXumOAb74LaUquqlKDQFwUxkShD+c6ndgnl0WxTkT8bPSHE7zFeZa0 nQbSOlNMU7mrZM5aOnwWZoeuAxkmCuCa0I+Ip+8k9vtZ0vX+j3BXxjRYds3T4DAgkvwtBb DWZfYBh+rc5bB4m0NXRPlW3ATWwq/JQ= Message-ID: <5847d0b4-04ce-f412-e0d6-4517c0dff2b1@suse.com> Date: Mon, 13 Feb 2023 09:17:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3] drivers/xen/hypervisor: Expose Xen SIF flags to userspace Content-Language: en-US To: Per Bilse , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" References: <20230103130213.2129753-1-per.bilse@citrix.com> From: Juergen Gross In-Reply-To: <20230103130213.2129753-1-per.bilse@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RaRG7cOKtNWOYX9dGkvl5yvn" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RaRG7cOKtNWOYX9dGkvl5yvn Content-Type: multipart/mixed; boundary="------------i51NBJAy4qfMHQfYpHGYhZH2"; protected-headers="v1" From: Juergen Gross To: Per Bilse , linux-kernel@vger.kernel.org Cc: Stefano Stabellini , Oleksandr Tyshchenko , "moderated list:XEN HYPERVISOR INTERFACE" Message-ID: <5847d0b4-04ce-f412-e0d6-4517c0dff2b1@suse.com> Subject: Re: [PATCH v3] drivers/xen/hypervisor: Expose Xen SIF flags to userspace References: <20230103130213.2129753-1-per.bilse@citrix.com> In-Reply-To: <20230103130213.2129753-1-per.bilse@citrix.com> --------------i51NBJAy4qfMHQfYpHGYhZH2 Content-Type: multipart/mixed; boundary="------------0888ix6X9VRTBjOLUH0ruqnM" --------------0888ix6X9VRTBjOLUH0ruqnM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDEuMjMgMTQ6MDIsIFBlciBCaWxzZSB3cm90ZToNCj4gL3Byb2MveGVuIGlzIGEg bGVnYWN5IHBzZXVkbyBmaWxlc3lzdGVtIHdoaWNoIHByZWRhdGVzIFhlbiBzdXBwb3J0DQo+ IGdldHRpbmcgbWVyZ2VkIGludG8gTGludXguICBJdCBoYXMgbGFyZ2VseSBiZWVuIHJlcGxh Y2VkIHdpdGggbW9yZQ0KPiBub3JtYWwgbG9jYXRpb25zIGZvciBkYXRhICgvc3lzL2h5cGVy dmlzb3IvIGZvciBpbmZvLCAvZGV2L3hlbi8gZm9yDQo+IHVzZXIgZGV2aWNlcykuICBXZSB3 YW50IHRvIGNvbXBpbGUgeGVuZnMgc3VwcG9ydCBvdXQgb2YgdGhlIGRvbTAga2VybmVsLg0K PiANCj4gVGhlcmUgaXMgb25lIGl0ZW0gd2hpY2ggb25seSBleGlzdHMgaW4gL3Byb2MveGVu LCBuYW1lbHkNCj4gL3Byb2MveGVuL2NhcGFiaWxpdGllcyB3aXRoICJjb250cm9sX2QiIGJl aW5nIHRoZSBzaWduYWwgb2YgInlvdSdyZSBpbg0KPiB0aGUgY29udHJvbCBkb21haW4iLiAg VGhpcyB1bHRpbWF0ZWx5IGNvbWVzIGZyb20gdGhlIFNJRiBmbGFncyBwcm92aWRlZA0KPiBh dCBWTSBzdGFydC4NCj4gDQo+IFRoaXMgcGF0Y2ggZXhwb3NlcyBhbGwgU0lGIGZsYWdzIGlu IC9zeXMvaHlwZXJ2aXNvci9zdGFydF9mbGFncy8gYXMNCj4gYm9vbGVhbiBmaWxlcywgb25l IGZvciBlYWNoIGJpdCwgcmV0dXJuaW5nICcxJyBpZiBzZXQsICcwJyBvdGhlcndpc2UuDQo+ IFR3byBrbm93biBmbGFncywgJ3ByaXZpbGVnZWQnIGFuZCAnaW5pdGRvbWFpbicsIGFyZSBl eHBsaWNpdGx5IG5hbWVkLA0KPiBhbmQgYWxsIHJlbWFpbmluZyBmbGFncyBjYW4gYmUgYWNj ZXNzZWQgdmlhIGdlbmVyaWNhbGx5IG5hbWVkIGZpbGVzLA0KPiBhcyBzdWdnZXN0ZWQgYnkg QW5kcmV3IENvb3Blci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFBlciBCaWxzZSA8cGVyLmJp bHNlQGNpdHJpeC5jb20+DQoNClB1c2hlZCB0byB4ZW4vdGlwLmdvdCBmb3ItbGludXMtNi4z DQoNCg0KSnVlcmdlbg0KDQo= --------------0888ix6X9VRTBjOLUH0ruqnM Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0888ix6X9VRTBjOLUH0ruqnM-- --------------i51NBJAy4qfMHQfYpHGYhZH2-- --------------RaRG7cOKtNWOYX9dGkvl5yvn Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8iIFAwAAAAAACgkQsN6d1ii/Ey8j JAf/fxi6jU96yMOPfpl/bafO23MGg+TXJtrdGWexTW6vpPTqOh2xcmwST5CQYgoOKk0Wk7YiB+7k h6/DMV+Q9D2tX7S9FrzhygA7eu15d8nu6nX8epmQTb2k+G4vLpPrL8yoMlsNTcThYyQbP2tlSVk8 BSpGaHh44HvYKC0Qyf28UTgTHIgJRPH+gRpPsgwdk5THv6M3oinPkM3AbxO4cHJ0+sY9zJDQC6Za yYO80JgIFWsYe4R7DDOl/fLpTKWYxQf3+7+lYfKrArFpwX0JM9CgRtWKS5qj/SOqdrTPZc5pE2pM ufQ9/duYJdo32/8Qvg1M7tu7Fb9hwHq39qX8W7TZOg== =4AYr -----END PGP SIGNATURE----- --------------RaRG7cOKtNWOYX9dGkvl5yvn-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:18:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:18:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494162.764125 (Exim 4.92) (envelope-from ) id 1pRU2Z-000706-7j; Mon, 13 Feb 2023 08:18:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494162.764125; Mon, 13 Feb 2023 08:18:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU2Z-0006zz-54; Mon, 13 Feb 2023 08:18:23 +0000 Received: by outflank-mailman (input) for mailman id 494162; Mon, 13 Feb 2023 08:18:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU2Y-0006xw-4s for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:18:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa5ef7d2-ab76-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:18:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3BBF8376EC; Mon, 13 Feb 2023 08:18:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C2C02138E6; Mon, 13 Feb 2023 08:18:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6V6pLUzy6WOZNQAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa5ef7d2-ab76-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n2OOk70gj51JdKCOUTv6xRulLiFPZbvw42JsAJ/KCk0=; b=BykbiMwgjH5Ns+dwUqZYygB/MzoGLyukxXdW5/xbivg9SlmphFebNboZbPAEekeRuqBCac SwuKrtayKeio8dQMXtCJqZCjDQB8sDEO0yKg2fjQLw0/fW2rR+bSyHi3v2nwx4nDEOGhnO 9dK+rH2WzEJbCQmt4cikSydnCx53xNk= Message-ID: <51f4525e-7233-569f-f62d-07551c382deb@suse.com> Date: Mon, 13 Feb 2023 09:18:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH linux-next v3] x86/xen/time: prefer tsc as clocksource when it is invariant Content-Language: en-US To: Krister Johansen , Boris Ostrovsky , Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg References: <20221216162118.GB2633@templeofstupid.com> From: Juergen Gross In-Reply-To: <20221216162118.GB2633@templeofstupid.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------k9hLZD2BZbf0hFZ4lOz9NAKd" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------k9hLZD2BZbf0hFZ4lOz9NAKd Content-Type: multipart/mixed; boundary="------------EWvDk0ef4AchGgsNDia3wk4B"; protected-headers="v1" From: Juergen Gross To: Krister Johansen , Boris Ostrovsky , Jan Beulich Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Message-ID: <51f4525e-7233-569f-f62d-07551c382deb@suse.com> Subject: Re: [PATCH linux-next v3] x86/xen/time: prefer tsc as clocksource when it is invariant References: <20221216162118.GB2633@templeofstupid.com> In-Reply-To: <20221216162118.GB2633@templeofstupid.com> --------------EWvDk0ef4AchGgsNDia3wk4B Content-Type: multipart/mixed; boundary="------------ySj6xqIXWWVvBswX3GYsWw0f" --------------ySj6xqIXWWVvBswX3GYsWw0f Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTYuMTIuMjIgMTc6MjEsIEtyaXN0ZXIgSm9oYW5zZW4gd3JvdGU6DQo+IEt2bSBlbGVj dHMgdG8gdXNlIHRzYyBpbnN0ZWFkIG9mIGt2bS1jbG9jayB3aGVuIGl0IGNhbiBkZXRlY3Qg dGhhdCB0aGUNCj4gVFNDIGlzIGludmFyaWFudC4NCj4gDQo+IChBcyBvZiBjb21taXQgNzUz OWIxNzRhZWY0ICgieDg2OiBrdm1ndWVzdDogdXNlIFRTQyBjbG9ja3NvdXJjZSBpZg0KPiBp bnZhcmlhbnQgVFNDIGlzIGV4cG9zZWQiKSkuDQo+IA0KPiBOb3RhYmxlIGNsb3VkIHZlbmRv cnNbMV0gYW5kIHBlcmZvcm1hbmNlIGVuZ2luZWVyc1syXSByZWNvbW1lbmQgdGhhdCBYZW4N Cj4gdXNlcnMgcHJlZmVyZW50aWFsbHkgc2VsZWN0IHRzYyBvdmVyIHhlbi1jbG9ja3NvdXJj ZSBkdWUgdGhlIHBlcmZvcm1hbmNlDQo+IHBlbmFsdHkgaW5jdXJyZWQgYnkgdGhlIGxhdHRl ci4gIFRoZXNlIGFydGljbGVzIGFyZSBwZXJzdWFzaXZlIGFuZA0KPiB0YWlsb3JlZCB0byBz cGVjaWZpYyB1c2UgY2FzZXMuICBJbiBvcmRlciB0byB1bmRlcnN0YW5kIHRoZSB0cmFkZW9m ZnMNCj4gYXJvdW5kIHRoaXMgY2hvaWNlIG1vcmUgZnVsbHksIHRoaXMgYXV0aG9yIGhhZCB0 byByZWZlcmVuY2UgdGhlDQo+IGRvY3VtZW50ZWRbM10gY29tcGxleGl0aWVzIGFyb3VuZCB0 aGUgWGVuIGNvbmZpZ3VyYXRpb24sIGFzIHdlbGwgYXMgdGhlDQo+IGtlcm5lbCdzIGNsb2Nr c291cmNlIHNlbGVjdGlvbiBhbGdvcml0aG0uICBNYW55IHVzZXJzIG1heSBub3QgYXR0ZW1w dA0KPiB0aGlzIHRvIGNvcnJlY3RseSBjb25maWd1cmUgdGhlIHJpZ2h0IGNsb2NrIHNvdXJj ZSBpbiB0aGVpciBndWVzdC4NCj4gDQo+IFRoZSBhcHByb2FjaCB0YWtlbiBpbiB0aGUga3Zt LWNsb2NrIG1vZHVsZSBzcGFyZXMgdXNlcnMgdGhpcyBjb25mdXNpb24sDQo+IHdoZXJlIHBv c3NpYmxlLg0KPiANCj4gQm90aCB0aGUgSW50ZWwgU0RNWzRdIGFuZCB0aGUgWGVuIHRzYyBk b2N1bWVudGF0aW9uIGV4cGxhaW4gdGhhdCBtYXJraW5nDQo+IGEgdHNjIGFzIGludmFyaWFu dCBtZWFucyB0aGF0IGl0IHNob3VsZCBiZSBjb25zaWRlcmVkIHN0YWJsZSBieSB0aGUgT1MN Cj4gYW5kIGlzIGVsaWJpbGUgdG8gYmUgdXNlZCBhcyBhIHdhbGwgY2xvY2sgc291cmNlLg0K PiANCj4gSW4gb3JkZXIgdG8gb2J0YWluIGJldHRlciBvdXQtb2YtdGhlLWJveCBwZXJmb3Jt YW5jZSwgYW5kIHJlZHVjZSB0aGUNCj4gbmVlZCBmb3IgdXNlciB0dW5pbmcsIGZvbGxvdyBr dm0ncyBhcHByb2FjaCBhbmQgZGVjcmVhc2UgdGhlIHhlbiBjbG9jaw0KPiByYXRpbmcgc28g dGhhdCB0c2MgaXMgcHJlZmVyYWJsZSwgaWYgaXQgaXMgaW52YXJpYW50LCBzdGFibGUsIGFu ZCB0aGUNCj4gdHNjIHdpbGwgbmV2ZXIgYmUgZW11bGF0ZWQuDQo+IA0KPiBbMV0gaHR0cHM6 Ly9hd3MuYW1hem9uLmNvbS9wcmVtaXVtc3VwcG9ydC9rbm93bGVkZ2UtY2VudGVyL21hbmFn ZS1lYzItbGludXgtY2xvY2stc291cmNlLw0KPiBbMl0gaHR0cHM6Ly93d3cuYnJlbmRhbmdy ZWdnLmNvbS9ibG9nLzIwMjEtMDktMjYvdGhlLXNwZWVkLW9mLXRpbWUuaHRtbA0KPiBbM10g aHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZG9jcy91bnN0YWJsZS9tYW4veGVuLXRzY21vZGUu Ny5odG1sDQo+IFs0XSBJbnRlbCA2NCBhbmQgSUEtMzIgQXJjaGl0ZWN0dXJlcyBTb2Z3YXJl IERldmVsb3BlcidzIE1hbnVhbCBWb2x1bWUNCj4gICAgICAzYjogU3lzdGVtIFByb2dyYW1t aW5nIEd1aWRlLCBQYXJ0IDIsIFNlY3Rpb24gMTcuMTcuMSwgSW52YXJpYW50IFRTQw0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogS3Jpc3RlciBKb2hhbnNlbiA8a2pseEB0ZW1wbGVvZnN0dXBp ZC5jb20+DQo+IENvZGUtcmV2aWV3ZWQtYnk6IERhdmlkIFJlYXZlciA8bWVAZGF2aWRyZWF2 ZXIuY29tPg0KDQpQdXNoZWQgdG86IHhlbi90aXAuZ2l0IGZvci1saW51cy02LjMNCg0KDQpK dWVyZ2VuDQoNCg== --------------ySj6xqIXWWVvBswX3GYsWw0f Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ySj6xqIXWWVvBswX3GYsWw0f-- --------------EWvDk0ef4AchGgsNDia3wk4B-- --------------k9hLZD2BZbf0hFZ4lOz9NAKd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8kwFAwAAAAAACgkQsN6d1ii/Ey/P Ugf/cHWNkviRNhBfPNMYGtQYKH71Xmu4xiw5D+mbOmNBgEA8v3N01KpdzvjXCMBWSzZ/wEkRWdTv ncigdmPwxquNMMlQEVugAQxR9cDOlvDH42ORewkYnK6vArPzCKXNa4sbqGo77nxFO7DHmeSL/a6o kDyfvqK3Zd/a8SQIn7GTW1p7gc37tJKdBVulKLiJ+MRLSgo830NKZmUejJY5q77+MHOQvSirvtJk GZAA7R/YIW8+oDSts5TKxBskz1xDfD/CInMavCCqfeNlIEgadya5RDCp2MvV7JD1CYTOj8/953NE WL+IQJMRhoViC5pqqDGYkwJp6xRsPC932aVMdQjDCw== =Weww -----END PGP SIGNATURE----- --------------k9hLZD2BZbf0hFZ4lOz9NAKd-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:19:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:19:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494168.764137 (Exim 4.92) (envelope-from ) id 1pRU3C-0007X2-Gi; Mon, 13 Feb 2023 08:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494168.764137; Mon, 13 Feb 2023 08:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU3C-0007Wv-DN; Mon, 13 Feb 2023 08:19:02 +0000 Received: by outflank-mailman (input) for mailman id 494168; Mon, 13 Feb 2023 08:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU3A-0007Wh-O4 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:19:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1150029b-ab77-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:18:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B951E33A08; Mon, 13 Feb 2023 08:18:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 87541138E6; Mon, 13 Feb 2023 08:18:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id X0SOH3Py6WP3NQAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:18:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1150029b-ab77-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dVnZ7esjSavwyVx5aDMl7nXGYzgJrmRgZ8E0mkjqaU0=; b=pjQXaTSOIZXki8TtiDkPMi9Gk5NmWNQjKOkvzxK1OCRCDZJeWdqX8lGw+QLuv+mQh4rohh DnA6QzbqqfEYgk/sogw1vZomO5CKFlcKoS4ZJt7jEdYVxh/32S9L4dBOFBDZKGB6yoNFPe XYWMCV+zIc6Wz/rsEyI6AF0qJniYb+E= Message-ID: Date: Mon, 13 Feb 2023 09:18:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen: Allow platform PCI interrupt to be shared Content-Language: en-US To: David Woodhouse , Stefano Stabellini , xen-devel , linux-kernel@vger.kernel.org, Thomas Gleixner , Paul Durrant References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------XjEXuqBs0m1ktJEb7SXwGXVm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------XjEXuqBs0m1ktJEb7SXwGXVm Content-Type: multipart/mixed; boundary="------------sc7du0J3EGAH8GCtz6wUalHX"; protected-headers="v1" From: Juergen Gross To: David Woodhouse , Stefano Stabellini , xen-devel , linux-kernel@vger.kernel.org, Thomas Gleixner , Paul Durrant Message-ID: Subject: Re: [PATCH] xen: Allow platform PCI interrupt to be shared References: In-Reply-To: --------------sc7du0J3EGAH8GCtz6wUalHX Content-Type: multipart/mixed; boundary="------------TeW6mhYtv2gyTu4GdSJwXTix" --------------TeW6mhYtv2gyTu4GdSJwXTix Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTguMDEuMjMgMTM6MjIsIERhdmlkIFdvb2Rob3VzZSB3cm90ZToNCj4gRnJvbTogRGF2 aWQgV29vZGhvdXNlIDxkd213QGFtYXpvbi5jby51az4NCj4gDQo+IFdoZW4gd2UgZG9uJ3Qg dXNlIHRoZSBwZXItQ1BVIHZlY3RvciBjYWxsYmFjaywgd2UgYXNrIFhlbiB0byBkZWxpdmVy IGV2ZW50DQo+IGNoYW5uZWwgaW50ZXJydXB0cyBhcyBJTlR4IG9uIHRoZSBQQ0kgcGxhdGZv cm0gZGV2aWNlLiBBcyBzdWNoLCBpdCBjYW4gYmUNCj4gc2hhcmVkIHdpdGggSU5UeCBvbiBv dGhlciBQQ0kgZGV2aWNlcy4NCj4gDQo+IFNldCBJUlFGX1NIQVJFRCwgYW5kIG1ha2UgaXQg cmV0dXJuIElSUV9IQU5ETEVEIG9yIElSUV9OT05FIGFjY29yZGluZyB0bw0KPiB3aGV0aGVy IHRoZSBldnRjaG5fdXBjYWxsX3BlbmRpbmcgZmxhZyB3YXMgYWN0dWFsbHkgc2V0LiBOb3cg SSBjYW4gc2hhcmUNCj4gdGhlIGludGVycnVwdDoNCj4gDQo+ICAgMTE6ICAgICAgICAgODIg ICAgICAgICAgMCAgIElPLUFQSUMgIDExLWZhc3Rlb2kgICB4ZW4tcGxhdGZvcm0tcGNpLCBl bnM0DQo+IA0KPiBEcm9wIHRoZSBJUlFGX1RSSUdHRVJfUklTSU5HLiBJdCBoYXMgbm8gZWZm ZWN0IHdoZW4gdGhlIElSUSBpcyBzaGFyZWQsDQo+IGFuZCBiZXNpZGVzLCB0aGUgb25seSBl ZmZlY3QgaXQgd2FzIGhhdmluZyBldmVuIGJlZm9yZWhhbmQgd2FzIHRvIHRyaWdnZXINCj4g YSBkZWJ1ZyBtZXNzYWdlIGluIGJvdGggSS9PQVBJQyBhbmQgbGVnYWN5IFBJQyBjYXNlczoN Cj4gDQo+IFsgICAgMC45MTU0NDFdIGdlbmlycTogTm8gc2V0X3R5cGUgZnVuY3Rpb24gZm9y IElSUSAxMSAoSU8tQVBJQykNCj4gWyAgICAwLjk1MTkzOV0gZ2VuaXJxOiBObyBzZXRfdHlw ZSBmdW5jdGlvbiBmb3IgSVJRIDExIChYVC1QSUMpDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBE YXZpZCBXb29kaG91c2UgPGR3bXdAYW1hem9uLmNvLnVrPg0KDQpQdXNoZWQgdG86IHhlbi90 aXAuZ2l0IGZvci1saW51cy02LjMNCg0KDQpKdWVyZ2VuDQoNCg== --------------TeW6mhYtv2gyTu4GdSJwXTix Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TeW6mhYtv2gyTu4GdSJwXTix-- --------------sc7du0J3EGAH8GCtz6wUalHX-- --------------XjEXuqBs0m1ktJEb7SXwGXVm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8nMFAwAAAAAACgkQsN6d1ii/Ey9Q XQgAkeN5Ytwitra2Jv+KFtnD/SZfWvMnS6Gq0ml4iVdxUwKen+2jpZmczoCovziPt7hzUJSl9JiU TVTOrNG4mqPgHnhODHjRLI4dGpzM1evLusKbS5fMODi6HPQAzKQ5R/qp7y2NQQKnVhn7z3S8bXzb j7jO+P0f5n6FwR080IoGNmdMoB2d9LUYuQGu5wyrFP1qZ85fA1dTtrQaNugHF8fjEnk+jcMYw+re mxeWKANCdL1u20egHPZH30P4wZHvSLKzNGwH3Ep4/f+f8Oadm5p9ECc3MRlJ6bjrlRiq0c1yVczD UAZGCqpKexhEM7kWWq1PjAwow8xgHyuL6e29ENcVvQ== =zttk -----END PGP SIGNATURE----- --------------XjEXuqBs0m1ktJEb7SXwGXVm-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:19:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:19:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494175.764148 (Exim 4.92) (envelope-from ) id 1pRU3f-00085l-TP; Mon, 13 Feb 2023 08:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494175.764148; Mon, 13 Feb 2023 08:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU3f-00085e-QW; Mon, 13 Feb 2023 08:19:31 +0000 Received: by outflank-mailman (input) for mailman id 494175; Mon, 13 Feb 2023 08:19:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU3e-0007Wh-5z for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:19:30 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 230e11df-ab77-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:19:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8786C376F7; Mon, 13 Feb 2023 08:19:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 56D66138E6; Mon, 13 Feb 2023 08:19:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ib2uE5Hy6WNHNgAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:19:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 230e11df-ab77-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276369; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SkuA5xII7+Ncctp/H+cyI401E5MSoxuprPOZVgQ02vo=; b=RsY/DEF/MS2viQV0EowO8KkuorK0OAk9TqN2MF3+Y0loY5yTQXypryN9WHlbOQBegkBb+j 19GPh5bx7AQfjUQThikP6/lw6f1j5gHpGYBGADt3mdpXvj5aQdHXggXqNr3x9tR1Xywz6H n5ZuwDwtBbAkR/AC6h+jVNnmwxS9GQE= Message-ID: Date: Mon, 13 Feb 2023 09:19:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/pvcalls-back: fix permanently masked event channel Content-Language: en-US To: Volodymyr Babchuk , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Oleksii Moisieiev References: <20230119211037.1234931-1-volodymyr_babchuk@epam.com> From: Juergen Gross In-Reply-To: <20230119211037.1234931-1-volodymyr_babchuk@epam.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------o02q2LSfjS5J4W0k0xTSfHED" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------o02q2LSfjS5J4W0k0xTSfHED Content-Type: multipart/mixed; boundary="------------VrHgZmgU9EkzvUMOgLaXDPLp"; protected-headers="v1" From: Juergen Gross To: Volodymyr Babchuk , Boris Ostrovsky , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , Oleksii Moisieiev Message-ID: Subject: Re: [PATCH] xen/pvcalls-back: fix permanently masked event channel References: <20230119211037.1234931-1-volodymyr_babchuk@epam.com> In-Reply-To: <20230119211037.1234931-1-volodymyr_babchuk@epam.com> --------------VrHgZmgU9EkzvUMOgLaXDPLp Content-Type: multipart/mixed; boundary="------------YxAi6fY1IXewUiJhyUIbZRaX" --------------YxAi6fY1IXewUiJhyUIbZRaX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDEuMjMgMjI6MTEsIFZvbG9keW15ciBCYWJjaHVrIHdyb3RlOg0KPiBUaGVyZSBp cyBhIHNlcXVlbmNlIG9mIGV2ZW50cyB0aGF0IGNhbiBsZWFkIHRvIGEgcGVybWFuZW50bHkg bWFza2VkDQo+IGV2ZW50IGNoYW5uZWwsIGJlY2F1c2UgeGVuX2lycV9sYXRlZW9pKCkgaXMg bmV3ZXIgY2FsbGVkLiBUaGlzIGhhcHBlbnMNCj4gd2hlbiBhIGJhY2tlbmQgcmVjZWl2ZXMg c3B1cmlvdXMgd3JpdGUgZXZlbnQgZnJvbSBhIGZyb250ZW5kLiBJbiB0aGlzDQo+IGNhc2Ug cHZjYWxsc19jb25uX2JhY2tfd3JpdGUoKSByZXR1cm5zIGVhcmx5IGFuZCBpdCBkb2VzIG5v dCBjbGVhcnMgdGhlDQo+IG1hcC0+d3JpdGUgY291bnRlci4gQXMgbWFwLT53cml0ZSA+IDAs IHB2Y2FsbHNfYmFja19pb3dvcmtlcigpIHJldHVybnMNCj4gd2l0aG91dCBjYWxsaW5nIHhl bl9pcnFfbGF0ZWVvaSgpLiBUaGlzIGxlYXZlcyB0aGUgZXZlbnQgY2hhbm5lbCBpbg0KPiBt YXNrZWQgc3RhdGUsIGEgYmFja2VuZCBkb2VzIG5vdCByZWNlaXZlIGFueSBuZXcgZXZlbnRz IGZyb20gYQ0KPiBmcm9udGVuZCBhbmQgdGhlIHdob2xlIGNvbW11bmljYXRpb24gc3RvcHMu DQo+IA0KPiBNb3ZlIGF0b21pY19zZXQoJm1hcC0+d3JpdGUsIDApIHRvIHRoZSB2ZXJ5IGJl Z2lubmluZyBvZg0KPiBwdmNhbGxzX2Nvbm5fYmFja193cml0ZSgpIHRvIGZpeCB0aGlzIGlz c3VlLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVm9sb2R5bXlyIEJhYmNodWsgPHZvbG9keW15 cl9iYWJjaHVrQGVwYW0uY29tPg0KPiBSZXBvcnRlZC1ieTogT2xla3NpaSBNb2lzaWVpZXYg PG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KDQpQdXNoZWQgdG86IHhlbi90aXAuZ2l0 IGZvci1saW51cy02LjMNCg0KDQpKdWVyZ2VuDQoNCg== --------------YxAi6fY1IXewUiJhyUIbZRaX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------YxAi6fY1IXewUiJhyUIbZRaX-- --------------VrHgZmgU9EkzvUMOgLaXDPLp-- --------------o02q2LSfjS5J4W0k0xTSfHED Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8pAFAwAAAAAACgkQsN6d1ii/Ey/c nAf/cLnO2nQuoqUvqA94flf8a/e5q/wYnPzoH8W0BT+b4NvK0eJedhEb30hd3Xg5SPhALA8npJE+ /10ZXbYDuWbJYrEGMDs3ztFoGCLc+HlCbN7lIrbaBtHZMPCBUn5VUJe7mhoMYaOEqwT9Df6J8CPF 5TASi6wAl14sivDM05X8KAcAqYcst8KrsNAspCNL0dFGlx+OhPRHD5JQyy232pUB7rldYkDheplh OPEDMAjE1qFCTmWAY7E8j+8a80At+Drhrmf29AC8lLF+H5dO8SdYvKtu2vMjk/rzymd0e9KVdtn7 0Cmq35jyn6zfFiHTq0OYJbmPtH9xuQxdn7cWUYfrGw== =pCG1 -----END PGP SIGNATURE----- --------------o02q2LSfjS5J4W0k0xTSfHED-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:20:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:20:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494180.764159 (Exim 4.92) (envelope-from ) id 1pRU48-0000Cz-62; Mon, 13 Feb 2023 08:20:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494180.764159; Mon, 13 Feb 2023 08:20:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU48-0000Cs-2Q; Mon, 13 Feb 2023 08:20:00 +0000 Received: by outflank-mailman (input) for mailman id 494180; Mon, 13 Feb 2023 08:19:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU46-0007Wh-Nn for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:19:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 341073ce-ab77-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:19:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 162A467AC1; Mon, 13 Feb 2023 08:19:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB979138E6; Mon, 13 Feb 2023 08:19:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eZO8M63y6WN4NgAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:19:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 341073ce-ab77-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276398; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QE3+ImDbv+iRMg0urx+hhREwWMlTqSaDmNJTX/t3b28=; b=K8wk7UwJ8jvwXSQrTwUKGkT21bQRUW0XeObdsuY1QkLrz3CyFqteBaEltPWKxsPfaBqH3L Uk+qI6aAlvsVmHvplKSJyMn3aBLlmYGvls0b8UbxBPteNBCaCp55AYhBtHWKjwz+DVqXYb BuhDnfscfGqW2IQq3z1BJOqzUNG08lU= Message-ID: Date: Mon, 13 Feb 2023 09:19:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen/grant-dma-iommu: Implement a dummy probe_device() callback Content-Language: en-US To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Viresh Kumar References: <20230208153649.3604857-1-olekstysh@gmail.com> From: Juergen Gross In-Reply-To: <20230208153649.3604857-1-olekstysh@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RBH6UhIRkHMiUqsxgvy3xsXY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RBH6UhIRkHMiUqsxgvy3xsXY Content-Type: multipart/mixed; boundary="------------NGWlZ7vq7DpqRSV3qtp1bda3"; protected-headers="v1" From: Juergen Gross To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Viresh Kumar Message-ID: Subject: Re: [PATCH] xen/grant-dma-iommu: Implement a dummy probe_device() callback References: <20230208153649.3604857-1-olekstysh@gmail.com> In-Reply-To: <20230208153649.3604857-1-olekstysh@gmail.com> --------------NGWlZ7vq7DpqRSV3qtp1bda3 Content-Type: multipart/mixed; boundary="------------gsVpOz0V7CNMqpfHNUPpAH8n" --------------gsVpOz0V7CNMqpfHNUPpAH8n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDIuMjMgMTY6MzYsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBGcm9t OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+ DQo+IA0KPiBVcGRhdGUgc3R1YiBJT01NVSBkcml2ZXIgKHdoaWNoIG1haW4gcHVycG9zZSBp cyB0byByZXVzZSBnZW5lcmljDQo+IElPTU1VIGRldmljZS10cmVlIGJpbmRpbmdzIGJ5IFhl biBncmFudCBETUEtbWFwcGluZyBsYXllciBvbiBBcm0pDQo+IGFjY29yZGluZyB0byB0aGUg cmVjZW50IGNoYW5nZXMgZG9uZSBpbiB0aGUgZm9sbG93aW5nDQo+IGNvbW1pdCA1NzM2NWEw NGM5MjEgKCJpb21tdTogTW92ZSBidXMgc2V0dXAgdG8gSU9NTVUgZGV2aWNlIHJlZ2lzdHJh dGlvbiIpLg0KPiANCj4gV2l0aCBwcm9iZV9kZXZpY2UoKSBjYWxsYmFjayBiZWluZyBjYWxs ZWQgZHVyaW5nIElPTU1VIGRldmljZSByZWdpc3RyYXRpb24sDQo+IHRoZSB1bmluaXRpYWxp emVkIGNhbGxiYWNrIGp1c3QgbGVhZHMgdG8gdGhlICJrZXJuZWwgTlVMTCBwb2ludGVyDQo+ IGRlcmVmZXJlbmNlIiBpc3N1ZSBkdXJpbmcgYm9vdC4gRml4IHRoYXQgYnkgYWRkaW5nIGEg ZHVtbXkgY2FsbGJhY2suDQo+IA0KPiBMb29rcyBsaWtlIHRoZSByZWxlYXNlX2RldmljZSgp IGNhbGxiYWNrIGlzIG5vdCBtYW5kYXRvcnkgdG8gYmUNCj4gaW1wbGVtZW50ZWQgYXMgSU9N TVUgZnJhbWV3b3JrIG1ha2VzIHN1cmUgdGhhdCBjYWxsYmFjayBpcyBpbml0aWFsaXplZA0K PiBiZWZvcmUgZGVyZWZlcmVuY2luZy4NCj4gDQo+IFJlcG9ydGVkLWJ5OiBWaXJlc2ggS3Vt YXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQoNClB1c2hl ZC10bzogeGVuL3RpcC5naXQgZm9yLWxpbnVzLTYuMw0KDQoNCkp1ZXJnZW4NCg0K --------------gsVpOz0V7CNMqpfHNUPpAH8n Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------gsVpOz0V7CNMqpfHNUPpAH8n-- --------------NGWlZ7vq7DpqRSV3qtp1bda3-- --------------RBH6UhIRkHMiUqsxgvy3xsXY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8q0FAwAAAAAACgkQsN6d1ii/Ey/S QAf/fRXsFUEMr+WD5+EQRdD8h1X1IsQTLpZWHreyPibtO4+gl1AooVP8oBzbGTPhKeygMpT0A8BK 8i6optXzCxLAL6LYh8GNklO7XnwwSWCb39TKMtKrJ7kFkERbp1afX+EaWpArLoYzhOfQagpRZ7IX 5ABbAT+kmH3incsqG9BPePDOO0h5Rzrx7Kzv2xW4o9ZRgqCYGVC2XFBiTcyMNoKLY1xIY/tyB1II zxpG+A0v1cgX2xmxyvQOFOHXn/CqSEgUa9b+f//4r8+9V7mUCHyx75DXBM+kqTtRBAQTtWnrBdGH Cvfb/Y3fLUPVh4MNrI0IKc1f0YLoSoBF3AryktWAPQ== =Gzun -----END PGP SIGNATURE----- --------------RBH6UhIRkHMiUqsxgvy3xsXY-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:20:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:20:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494186.764169 (Exim 4.92) (envelope-from ) id 1pRU4Y-0001YF-Ff; Mon, 13 Feb 2023 08:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494186.764169; Mon, 13 Feb 2023 08:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU4Y-0001Y8-CJ; Mon, 13 Feb 2023 08:20:26 +0000 Received: by outflank-mailman (input) for mailman id 494186; Mon, 13 Feb 2023 08:20:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRU4X-0001RB-3a for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:20:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42fd8ea3-ab77-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:20:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1A2BE37706; Mon, 13 Feb 2023 08:20:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E345F138E6; Mon, 13 Feb 2023 08:20:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id x741Nsby6WPDNgAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42fd8ea3-ab77-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676276423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T67QN63umXnc0fRsL1qO+KXl0rONIm141v5QsXiqc7U=; b=nIZERco8BTO8Q9GkwypnEoUodoHwrDRZ6gVAHupOktjw74RpgcU3SdsiVBy8zC1nCXIOpV RNTMh5kE5zg8GlrELal5E9+o2kSFYYG9AJlort/DtAHv9MjyB3sfVyvWJ/jvt05uQa3Mw2 ygeiym/agAdWVhgk22j2m/6qu2gh3n8= Message-ID: <589edfa4-ae52-49dd-08b2-25ffb506084a@suse.com> Date: Mon, 13 Feb 2023 09:20:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH][next] xen: Replace one-element array with flexible-array member Content-Language: en-US To: "Gustavo A. R. Silva" , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mUBn580fjrlxklzUomy0ToCm" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mUBn580fjrlxklzUomy0ToCm Content-Type: multipart/mixed; boundary="------------MEG0JBht7zMjbG92DYZ0qhxr"; protected-headers="v1" From: Juergen Gross To: "Gustavo A. R. Silva" , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Message-ID: <589edfa4-ae52-49dd-08b2-25ffb506084a@suse.com> Subject: Re: [PATCH][next] xen: Replace one-element array with flexible-array member References: In-Reply-To: --------------MEG0JBht7zMjbG92DYZ0qhxr Content-Type: multipart/mixed; boundary="------------ZuHhLaWGSyu994BrV7gofsrQ" --------------ZuHhLaWGSyu994BrV7gofsrQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDIuMjMgMDI6MjgsIEd1c3Rhdm8gQS4gUi4gU2lsdmEgd3JvdGU6DQo+IE9uZS1l bGVtZW50IGFycmF5cyBhcmUgZGVwcmVjYXRlZCwgYW5kIHdlIGFyZSByZXBsYWNpbmcgdGhl bSB3aXRoIGZsZXhpYmxlDQo+IGFycmF5IG1lbWJlcnMgaW5zdGVhZC4gU28sIHJlcGxhY2Ug b25lLWVsZW1lbnQgYXJyYXkgd2l0aCBmbGV4aWJsZS1hcnJheQ0KPiBtZW1iZXIgaW4gc3Ry dWN0IHhlbl9wYWdlX2RpcmVjdG9yeS4NCj4gDQo+IFRoaXMgaGVscHMgd2l0aCB0aGUgb25n b2luZyBlZmZvcnRzIHRvIHRpZ2h0ZW4gdGhlIEZPUlRJRllfU09VUkNFDQo+IHJvdXRpbmVz IG9uIG1lbWNweSgpIGFuZCBoZWxwIHVzIG1ha2UgcHJvZ3Jlc3MgdG93YXJkcyBnbG9iYWxs eQ0KPiBlbmFibGluZyAtZnN0cmljdC1mbGV4LWFycmF5cz0zIFsxXS4NCj4gDQo+IFRoaXMg cmVzdWx0cyBpbiBubyBkaWZmZXJlbmNlcyBpbiBiaW5hcnkgb3V0cHV0Lg0KPiANCj4gTGlu azogaHR0cHM6Ly9naXRodWIuY29tL0tTUFAvbGludXgvaXNzdWVzLzc5DQo+IExpbms6IGh0 dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xpbnV4L2lzc3Vlcy8yNTUNCj4gTGluazogaHR0cHM6 Ly9nY2MuZ251Lm9yZy9waXBlcm1haWwvZ2NjLXBhdGNoZXMvMjAyMi1PY3RvYmVyLzYwMjkw Mi5odG1sIFsxXQ0KPiBTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0 YXZvYXJzQGtlcm5lbC5vcmc+DQoNClB1c2hlZC10bzogeGVuL3RpcC5naXQgZm9yLWxpbnVz LTYuMw0KDQoNCkp1ZXJnZW4NCg0K --------------ZuHhLaWGSyu994BrV7gofsrQ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZuHhLaWGSyu994BrV7gofsrQ-- --------------MEG0JBht7zMjbG92DYZ0qhxr-- --------------mUBn580fjrlxklzUomy0ToCm Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPp8sYFAwAAAAAACgkQsN6d1ii/Ey+z iggAlU6pTFIxYTeG+qBwseJU8IrA0YQD3rA/JBTv+2jARNlwIGkEwuZL5sAy6zYiIbGT6hADym+u WfKfojYMs2mEmylJBPQCgDWpW9K2924G7btecf3T5DPdqAeR9VkMMg2Y1eLPZ23xZA0Hc9xIreP8 5pRH3T966LJOXzn5J4nDCrU8fwSgUhIKmeSNw5kToVTkJKpdFmjd0zfO94ymQmMGEm0n8m184iUk 4O1SjtrSWG07d8UOqIvHlZpfGnabh6jY5h01oUS/i8DVqI76YT4/HBl/ze7I2T+zaUE1n7yuj8go 6JpL9C/kOGxzovfKVvw7WbdEUt2YOMSVNBEiJrVYkw== =6d2w -----END PGP SIGNATURE----- --------------mUBn580fjrlxklzUomy0ToCm-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:37:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:37:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494197.764180 (Exim 4.92) (envelope-from ) id 1pRUKb-0003Wu-Rk; Mon, 13 Feb 2023 08:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494197.764180; Mon, 13 Feb 2023 08:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUKb-0003Wn-Oi; Mon, 13 Feb 2023 08:37:01 +0000 Received: by outflank-mailman (input) for mailman id 494197; Mon, 13 Feb 2023 08:37:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUKa-0003Wh-PU for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:37:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0c::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 939b1d56-ab79-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:36:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8278.eurprd04.prod.outlook.com (2603:10a6:20b:3ff::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 08:36:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 08:36:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 939b1d56-ab79-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iA7rLSeNHaEmJHvHkG9Ky7XzO1ZAKSVhVrGD9L7tUGRc5iifP2tupaWFkX1N4lu1DbUyhML8ayCpEO2TKUL7Wc+150GWX1rtdZ/8xRWBnud+5h1yi52pY2Kmm/vHMnfHLKYR9/1e6+ZDcBE6iUfNezaN/6CFIVmR7A9wXpThNCiZZlz0yzfjxRrTyoa8l27unvpKWgkxsseWfGNZuvz9vFdsLuf0Il1ycEiYelR6PImDrYkassLHcXJuQsNpa1PcApAbiVCfEkNSnxU9pNUjiYXUk1C8dDf99vulKmCJT2xzkALmlmbnFBahZ8byx6CmD5si6dDfdUl4n8BzUJNWLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wHgOL/5PiMClizKFsipE6Yy9FpulTtf5ZXXjt5l6f1A=; b=bqs20xim/dugxTmAi5EB/SuR66EILGbaA9YryjL6wom1BqbCiVfNX58tQe0eF+O2/lz5N4r+XtQ9sgNvL2l910OJ//gngXxOpxLfNgPrxxduGiOPWFcPFPc5yo9H9xADpxIV8Lfxpws1NwVVUlRAeviH7f5MQyv9hws+uoFBbnrQBAiU0t7x/dAYjpI1X6lysa3Q//rtzXwGsU8aEuTn9IL1gPscqCN+hgPdWhV3IqspkJy/iSvmOLLCSCpgx8nPSK3F9hTV4yQElxHyQdHFqwwNB8HNXpxJL3ealt1hdUr/viYCwE1Bc+mvQSUdhWVXRYFcCrYg3DdkA7HCLY+M/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHgOL/5PiMClizKFsipE6Yy9FpulTtf5ZXXjt5l6f1A=; b=oRDgoyiqssuaxxtO2mg0bscr0SW9gYC1JSvuh5ofZGk05kumgYc2HdVb/DnvGqOv0dd1cfvv+L/GSDu9AU5vEwv3ng7xUUxhHbc+IxHvmnVsZTX7rjcpvcHYwGtmvI7GhlJKLeiCHQMEkMvQO90UcYGq2BAFvPEaww2I+hUIe6egQsnpWNP6Ziw1WvFUyWbkTOjhs5dbb7s+rim9E21zaGJnLs0gvosOLk2sAVDyU144jaw+QdUl51kdi8rLpxs05cSkwA7+8MehfzkSvdVbRmDu6CnhagNyhxeZN7tOpVycVIa8DnNV3xyB86nFLv5JNyIC2AJ6WmDLuXbLBXvxgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <083e8a1f-8db6-350a-9138-58751c3fb44b@suse.com> Date: Mon, 13 Feb 2023 09:36:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 07/10] xen/physinfo: add arm SVE arch capability and vector length Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" References: <20230202110816.1252419-1-luca.fancellu@arm.com> <20230202110816.1252419-8-luca.fancellu@arm.com> <781EDC8B-B24C-431F-AB08-F2ACF64E4D4E@arm.com> From: Jan Beulich In-Reply-To: <781EDC8B-B24C-431F-AB08-F2ACF64E4D4E@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0136.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8278:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ba24c4e-6f70-498a-19a5-08db0d9d763b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SiEXlE/mBp6tvZLUPBOpZOX0zPNJhoOO8mUs7tN53gWq81ZQEXZb65hTVOCXAnhNB1JwGHnkNp0XqT8t8B89ILhCvyeLjgOQIPNCsGgywnhL4KTfJyV4TfNPdkKJsUNOaOIE0ELs9fdQtmu/w3yuVrxz8HGyqKqu5MGZYD48kZkVNDl61QV0C/BO8wJuRZH6dd6v7d0aexLy8Xhgo+FQtyR+2OiiNYtnY4i10b0VDlfNePN5XZHNARMYfJDH55NxeBGGnFWV690wib1ylBWVGToqy1e8DBG0MQXLarnWVTq8C5TLJ/aHcf6yUMesmohp1MPy8Zor3FRoX1GcdMf2DVnDrKnaer2becFk3g5QdrChfSI+WU4kXZi9z2LWndOqvDwBzqh9phELADyqnSrc1M7KD8aCSB9NLHwozOkhsKGrXXmrHf7cPx1Ejzn5QlEm3otQRjdrhX8HefAXS0PhcIS1J5CGOjczZ7qi0bl+h8pf7MBJh0l6twoSnbQ6nqJAyN2FLdukdbgXOewGK8GJ9vxIPUfF/6TulL18qJXkvUYQM00aLV8qqVJkXYJja6S87op+zfT4is9BlT5xx25f8DtQyd8Rt03r1AWkSX8CTDvdKc3yJFXY1SSc7EvBxDpAesMiOIWF8IIrBp+GfV/VtTyLrA0qZpZPyIW5XY5OKUOYAvhnBu2I9jZ+zCoQDq+RujlzpiVuslDaofyrvHDBOzDhuy3nTiMxJwQVOifjgDU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199018)(4326008)(41300700001)(6916009)(83380400001)(86362001)(31696002)(38100700002)(54906003)(316002)(66556008)(66476007)(8676002)(186003)(66946007)(6512007)(2616005)(6506007)(53546011)(26005)(478600001)(6486002)(36756003)(2906002)(31686004)(7416002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3VaWVpUOVVOS0M0b3I0QWtSNTBXbkFyZHJRNDdNSGNrcmxBM293dTkxSnFQ?= =?utf-8?B?QXo0bGc0MDVJTWlsUzh2Q1ROekNpS2NMMTZXUFB5ZGdYTjB4K2JRRkliZkJx?= =?utf-8?B?OUt2cDU5RkQ3K2hjSWN5SElyREovTGQ1QVc4S1dBQ1NKVlFmdnlVSDlLdnhu?= =?utf-8?B?VDE3ZjJsaTJVd0tTMHl1dGUrNFN0cWZaaVVQcmR2NGN3SGpIWFhXUmdKamtu?= =?utf-8?B?TEgzMVZzeDYxenYzb2IxZmxCN0hDNTA3ODc1N1pobi9jVVlLbkxCT1gxRHVj?= =?utf-8?B?akoxTjdOd2twTE5BOURLQmRmRFZSbHNTWC93RzFhT3BzblhPVkx0MlBCeU1H?= =?utf-8?B?cnpKaTZGM1YrYzFpWmJJdEhFTDFNSzh5RHVKb1BUb21GMEFLdlNxOFN3NE1C?= =?utf-8?B?TkFLNkk2SHZqWmswN2thdTg5NEVJbm00QWdqZmJ0V2ZqcFZBVmR5MzB4d0VU?= =?utf-8?B?Q1hMQnRzamJxWHZWOW9QVmloa0xwQ0dNR1RYMU1HVC9RbDRaNm9WYi9RTnJ0?= =?utf-8?B?ck9OdGpDZUpiSW9rdVhhWHE5SXZTQkZIV25VbzRaS000NGU0b21Tc1A4cVNK?= =?utf-8?B?aitneVJ5TytkbHUySUJyOGxVOW82WHhBQlVENXlady9URWpuMnNxenlVSUZ0?= =?utf-8?B?bEEyWGlUVGprQXYrODJFa0hsSWFNdkQ2b3ZOSkY3NmZ3VjVhRFljalo0S0Qv?= =?utf-8?B?alNPNDUvMENEZStkZzk1QklucVI4VEJTalFpc2dtSkdMZEVUcm53WEpleTNZ?= =?utf-8?B?Q0NYYURLSWxjTm5Lc1pVOUVoK0IxN3piS2xPVVRsTEhNMXJBSm5mYWYvMGVM?= =?utf-8?B?Mk9rd3RSK0xjbkF4RjhvWmdsd0cwQzhjVjZIRWhzUVV6ZERsUkdadW55Njc4?= =?utf-8?B?MXZlaUJieWQrdlVpUVNHbXVsWUtMa1ZxN3MwaXcxWDlLeW5OOVpud3hIZDNp?= =?utf-8?B?TkJtZjBlV3JyL01lQ290UHZPM29DZm1GWmlnd21zTENIUEJjZlFaQ0pQOEdN?= =?utf-8?B?cVNwYStTSmdtWnBWZEFqd25ZNzlhdG5QajBYdVMwVFdBTE1PdkI2L3MzZVhk?= =?utf-8?B?aW03R1NGUVlGcXdMS3NxbHJKNUdma2kwMDVHWTdQNm5qMGJIMit0WVdaT3RM?= =?utf-8?B?eVVrRjdjUFlrS1F0bW5uY1VHRmRXN2ExcTRORHNuRGtRcjRzVkMrbnF3SytG?= =?utf-8?B?SVhmZ2ZrczB0bjkwVlRrMGNEbVN3M1NiMDZDN1ljQ2huZVQxVU53VFBRN0FT?= =?utf-8?B?YTl2MDF3QllqT2xLTWlKdG4zTWlVd00wQXlMcUQzMC9wT0c0eHJpN1VJWm9V?= =?utf-8?B?dVZ3WXBQNjBxb1AzcWpaMHdLbHFWNUYrY25rd09nSWk1RTV4NjZtZjRkZ0dY?= =?utf-8?B?TTJhSFNWVDRudE9uZjlNNDJSR2U2UFE4Z2kwd3REWEl0UEIrSmFCY1pOYlRm?= =?utf-8?B?TXJ4elRsUlBaN3BXa25aek5YR0pqcUNmRGRwR0JqNlBreXdaQi9wdXJ0bkcx?= =?utf-8?B?ZGN3TkwzdGNLVDM4b0lyM1cyYXlEbHk0OUU2YlhaSFR0VnNLa1N2MlVJMVd3?= =?utf-8?B?bGRqUHdhUVhIT0ZNZlJDdDhnak5JbTF2WVlzRW85bXgwSEhwQVYzNTFuakQw?= =?utf-8?B?UXR5Y25XWG0zK1I2RUcvZnNTNVNtQnVzR3FycXEwT21UUzBrZU9Ed1NNeGtP?= =?utf-8?B?c0Z1K3hzR1dGR1dlZzAzRzQ2UzR6TS9mWUN1U3ljOGRVVEh0dGYzWFdnMUJS?= =?utf-8?B?SWlsTW1yOWpPR1N1WU9YdE1iWDl2RGI5aW5mOUxZakd6VVFJNGpVbmw1ZmVB?= =?utf-8?B?Q2x1RFFuRFJwQzVRNUtQZXVkWEc4bHZQS3VPVnkzTFB4dHg5MW5WT0ZVR1hl?= =?utf-8?B?SG9XQVdaMXdMYkFueUVONGtxTnFmY1hpU3k5SXU4S0wwSmpJYk1sa0NPTUlO?= =?utf-8?B?d0VCbnd5eUZEN1NOQ3JxOXFZMDljSTdSZmY3cHBHZmpVMnRXclhaWnhRWndZ?= =?utf-8?B?TXo4Q2dLenkzT0czcnVUV2xLd1pHM3dtNE9qR2VhYzQ5NTBvWHo0UjFVSmo4?= =?utf-8?B?QkgvYVVCU3BnSVdRa1FPR09jUklMNVo1Z3NzbmJXNWhaRnJXYWhkSXA3YTVz?= =?utf-8?Q?BAT7SEqPlzvAwZ452QH/MdIag?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba24c4e-6f70-498a-19a5-08db0d9d763b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 08:36:54.9543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /wzoBnzulcFnL3BB/AOFdnuM0odSQq47959D8YFnaOSFymXMfljTSqZWnJ9mskL6HZQu963ORI8AVdMhlLjgnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8278 On 10.02.2023 16:54, Luca Fancellu wrote: >> On 2 Feb 2023, at 12:05, Jan Beulich wrote: >> On 02.02.2023 12:08, Luca Fancellu wrote: >>> (is hw_cap only for x86?) >> >> I suppose it is, but I also expect it would better go away than be moved. >> It doesn't hold a complete set of information, and it has been superseded. >> >> Question is (and I think I did raise this before, perhaps in different >> context) whether Arm wouldn't want to follow x86 in how hardware as well >> as hypervisor derived / used ones are exposed to the tool stack >> (XEN_SYSCTL_get_cpu_featureset). I guess there's nothing really precluding >> that data to consist of more than just boolean fields. > > Yes I guess that infrastructure could work, however I don’t have the bandwidth to > put it in place at the moment, so I would like the Arm maintainers to give me a > suggestion on how I can expose the vector length to XL if putting its value here > needs to be avoided Since you've got a reply from Andrew boiling down to the same suggestion (or should I even say request), I guess it wants seriously considering to introduce abstract base infrastructure first. As Andrew says, time not invested now will very likely mean yet more time to be invested later. >>> --- a/xen/include/public/sysctl.h >>> +++ b/xen/include/public/sysctl.h >>> @@ -18,7 +18,7 @@ >>> #include "domctl.h" >>> #include "physdev.h" >>> >>> -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015 >>> +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000016 >> >> Why? You ... >> >>> @@ -104,7 +110,8 @@ struct xen_sysctl_physinfo { >>> uint32_t cpu_khz; >>> uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */ >>> uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */ >>> - uint32_t pad; >>> + uint16_t arm_sve_vl_bits; >>> + uint16_t pad; >>> uint64_aligned_t total_pages; >>> uint64_aligned_t free_pages; >>> uint64_aligned_t scrub_pages; >> >> ... add no new fields, and the only producer of the data zero-fills the >> struct first thing. > > Yes that is right, I will wait to understand how I can proceed here: > > 1) rename arch_capabilities to arm_sve_vl_bits and put vector length there. > 2) leave arch_capabilities untouched, no flag creation/setting, create uint32_t arm_sve_vl_bits field removing “pad”, > Use its value to determine if SVE is present or not. > 3) ?? 3) Introduce suitable #define(s) to use part of arch_capabilities for your purpose, without renaming the field. (But that's of course only if Arm maintainers agree with you on _not_ going the proper feature handling route right away.) Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494207.764207 (Exim 4.92) (envelope-from ) id 1pRURj-0005Kp-24; Mon, 13 Feb 2023 08:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494207.764207; Mon, 13 Feb 2023 08:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURi-0005Kg-UG; Mon, 13 Feb 2023 08:44:22 +0000 Received: by outflank-mailman (input) for mailman id 494207; Mon, 13 Feb 2023 08:44:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURi-00053b-8Y for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bda6e54-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:20 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95DCF67B09; Mon, 13 Feb 2023 08:44:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D2A21391B; Mon, 13 Feb 2023 08:44:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VAl9GWX46WMuRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bda6e54-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4WUHNcXaKUs5EWJgyYOwx2UyA3oTZifWWQZCeAXA8E=; b=r91MzCy85Iz1/IfPwuNm+gVo6sS8uA04Tq51j4D7DN/0uBFeYTGxHmfLk5yiywCZbf8d6T udqXCa918VMQ+NMjKC7jCIr1fSLuylUAGZkkgITcfp8L0vXHP6QalG4N/BOyWNkewUwjCA eZVNhUqOzaW/mjJ2D+Bx2trwCwEyO4k= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 1/7] Mini-OS: xenbus: add support for reading node from directory Date: Mon, 13 Feb 2023 09:44:06 +0100 Message-Id: <20230213084412.21065-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Especially PV device drivers often need to read multiple Xenstore nodes from a common directory. Add support for reading a string or an unsigned value by specifying the directory and the node. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - check sscanf() return value (Samuel Thibault) --- include/xenbus.h | 6 ++++++ xenbus.c | 40 +++++++++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/include/xenbus.h b/include/xenbus.h index 3871f358..c0fc0ac5 100644 --- a/include/xenbus.h +++ b/include/xenbus.h @@ -108,6 +108,12 @@ int xenbus_read_integer(const char *path); * read and parsing were successful, 0 if not */ int xenbus_read_uuid(const char* path, unsigned char uuid[16]); +/* Support functions for reading values from directory/node tuple. */ +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value); +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value); + /* Contraction of snprintf and xenbus_write(path/node). */ char* xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, diff --git a/xenbus.c b/xenbus.c index 81e9b65d..923e8181 100644 --- a/xenbus.c +++ b/xenbus.c @@ -936,16 +936,21 @@ int xenbus_read_uuid(const char *path, unsigned char uuid[16]) return 1; } +#define BUFFER_SIZE 256 +static void xenbus_build_path(const char *dir, const char *node, char *res) +{ + BUG_ON(strlen(dir) + strlen(node) + 1 >= BUFFER_SIZE); + sprintf(res,"%s/%s", dir, node); +} + char *xenbus_printf(xenbus_transaction_t xbt, const char* node, const char* path, const char* fmt, ...) { -#define BUFFER_SIZE 256 char fullpath[BUFFER_SIZE]; char val[BUFFER_SIZE]; va_list args; - BUG_ON(strlen(node) + strlen(path) + 1 >= BUFFER_SIZE); - sprintf(fullpath,"%s/%s", node, path); + xenbus_build_path(node, path, fullpath); va_start(args, fmt); vsprintf(val, fmt, args); va_end(args); @@ -964,6 +969,35 @@ domid_t xenbus_get_self_id(void) return ret; } +char *xenbus_read_string(xenbus_transaction_t xbt, const char *dir, + const char *node, char **value) +{ + char path[BUFFER_SIZE]; + + xenbus_build_path(dir, node, path); + + return xenbus_read(xbt, path, value); +} + +char *xenbus_read_unsigned(xenbus_transaction_t xbt, const char *dir, + const char *node, unsigned int *value) +{ + char path[BUFFER_SIZE]; + char *msg; + char *str; + + xenbus_build_path(dir, node, path); + msg = xenbus_read(xbt, path, &str); + if ( msg ) + return msg; + + if ( sscanf(str, "%u", value) != 1 ) + msg = strdup("EINVAL"); + free(str); + + return msg; +} + /* * Local variables: * mode: C -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494205.764191 (Exim 4.92) (envelope-from ) id 1pRURh-00053t-Nw; Mon, 13 Feb 2023 08:44:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494205.764191; Mon, 13 Feb 2023 08:44:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURh-00053m-LP; Mon, 13 Feb 2023 08:44:21 +0000 Received: by outflank-mailman (input) for mailman id 494205; Mon, 13 Feb 2023 08:44:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURf-00053b-SJ for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:19 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98b9f786-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0C5A367B09; Mon, 13 Feb 2023 08:44:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CF8141391B; Mon, 13 Feb 2023 08:44:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aBtHMV/46WMoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98b9f786-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277856; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2TpvI14vjytLk+fJ6jQ6L4mTK2f8+asinqiPiJO4Cp8=; b=dF9Q7GVGtTjlVr5s7SWi6e7UVCaS3Pz8GB7geRxBSHm6ACnbQhmVy5seqA4Yu/+XSOtFuW goRiQVr8m40NdjQQ5hM/oPsJvLjCbQ1L+01XdSvYc/ub8XfNgFqedc776kPf5GV//AA5vc Dbnqt0/9PP2oO906XoBY1Z5jNZKxzXY= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 0/7] Mini-OS: add minimal 9pfs support Date: Mon, 13 Feb 2023 09:44:05 +0100 Message-Id: <20230213084412.21065-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is adding minimal support to use 9pfs in Mini-OS. It is adding a PV 9pfs frontend and the ability to open, close, read and write files. The series has been tested with qemu as 9pfs backend in a PVH Mini-OS guest (I've used a slightly modified Xenstore-stubdom for that purpose in order to reuse the build runes). This series is meant to setup the stage for adding file based logging support to Xenstore-stubdom and later to add live update support (being able to save the LU data stream in a dom0 file makes this a _lot_ easier). In order to keep Mini-OS's license I have only used the protocol docs available on the internet [1] and then verified those with the qemu 9pfs backend implementation (especially for supporting the 9P2000.u variant, as qemu doesn't support the basic 9P2000 protocol). The needed fixed values of the protocol have been taken from [2]. [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html [2]: https://github.com/0intro/libixp Changes in V2: - addressed comments by Samuel Thibault Changes in V3: - addressed comments by Samuel Thibault and Andrew Cooper Juergen Gross (7): Mini-OS: xenbus: add support for reading node from directory Mini-OS: add concept of mount points Mini-OS: add support for runtime mounts Mini-OS: add 9pfs frontend Mini-OS: add 9pfs transport layer Mini-OS: add open and close handling to the 9pfs frontend Mini-OS: add read and write support to 9pfsfront 9pfront.c | 1300 +++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + include/lib.h | 14 + include/xenbus.h | 6 + lib/sys.c | 123 +++- xenbus.c | 40 +- 11 files changed, 1473 insertions(+), 22 deletions(-) create mode 100644 9pfront.c create mode 100644 include/9pfront.h -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494210.764226 (Exim 4.92) (envelope-from ) id 1pRURq-0005kd-FL; Mon, 13 Feb 2023 08:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494210.764226; Mon, 13 Feb 2023 08:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURq-0005kU-Ar; Mon, 13 Feb 2023 08:44:30 +0000 Received: by outflank-mailman (input) for mailman id 494210; Mon, 13 Feb 2023 08:44:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURp-00053b-AI for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:29 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f3030d6-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:26 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30DED37870; Mon, 13 Feb 2023 08:44:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03E4E1391B; Mon, 13 Feb 2023 08:44:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yNUpO2r46WM2RAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f3030d6-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277867; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19ujpdeO6r/ntB3v/0hzqQCc5N6kEKU3yTBXBtOtbZg=; b=UxYiQRhP1uw/dAULpCCF9xOTAqeUbO9hm0aaDfQjC1i0wV90bjKIPIzKCsoIV41Aiq+/3K cV8NacSRhsjG58kxQNyVHDGZ+stNlJvON/xNpy6S2L7Q/dfUiMaRgda/eFqjmbcgYNkvLO EL5Y5HLwN8l3iKbedmbWVBMcX3x4Lxo= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 2/7] Mini-OS: add concept of mount points Date: Mon, 13 Feb 2023 09:44:07 +0100 Message-Id: <20230213084412.21065-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the concept of mount points to Mini-OS. A mount point is a path associated with a device pointer and an open() callback. A mount point can be either a file (e.g. "/dev/mem") or a directory ("/var/log"). This allows to replace the special casing in the generic open() handling with a generic mount point handling. Prepare the open() callbacks to support creating new files by adding a mode parameter. Additionally add a close() prototype to include/lib.h, as it is missing today. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - pass path below mount point to open callbacks (Samuel Thibault) --- include/lib.h | 9 ++++++ lib/sys.c | 80 +++++++++++++++++++++++++++++++++++++++------------ 2 files changed, 70 insertions(+), 19 deletions(-) diff --git a/include/lib.h b/include/lib.h index bec99646..36d94ec4 100644 --- a/include/lib.h +++ b/include/lib.h @@ -187,6 +187,13 @@ struct file_ops { bool (*select_wr)(struct file *file); }; +struct mount_point { + const char *path; + int (*open)(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode); + void *dev; +}; + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); @@ -198,6 +205,8 @@ int alloc_fd(unsigned int type); void close_all_files(void); extern struct thread *main_thread; void sparse(unsigned long data, size_t size); + +int close(int fd); #endif #endif /* _LIB_H_ */ diff --git a/lib/sys.c b/lib/sys.c index 8f8a3de2..2f33c937 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -263,11 +263,6 @@ char *getcwd(char *buf, size_t size) return buf; } -#define LOG_PATH "/var/log/" -#define SAVE_PATH "/var/lib/xen" -#define SAVE_CONSOLE 1 -#define RESTORE_CONSOLE 2 - int mkdir(const char *pathname, mode_t mode) { errno = EIO; @@ -286,18 +281,30 @@ int posix_openpt(int flags) return fd; } +static int open_pt(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return posix_openpt(flags); +} + int open_savefile(const char *path, int save) { int fd; char nodename[64]; - snprintf(nodename, sizeof(nodename), "device/console/%d", save ? SAVE_CONSOLE : RESTORE_CONSOLE); + snprintf(nodename, sizeof(nodename), "device/console/%d", save ? 1 : 2); fd = open_consfront(nodename); printk("fd(%d) = open_savefile\n", fd); return fd; } + +static int open_save(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + return open_savefile(pathname, flags & O_WRONLY); +} #else int posix_openpt(int flags) { @@ -311,24 +318,59 @@ int open_savefile(const char *path, int save) } #endif -int open(const char *pathname, int flags, ...) +static int open_log(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) { int fd; + /* Ugly, but fine. */ - if (!strncmp(pathname,LOG_PATH,strlen(LOG_PATH))) { - fd = alloc_fd(FTYPE_CONSOLE); - printk("open(%s) -> %d\n", pathname, fd); - return fd; + fd = alloc_fd(FTYPE_CONSOLE); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static int open_mem(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + int fd; + + fd = alloc_fd(FTYPE_MEM); + printk("open(%s%s) -> %d\n", mnt->path, pathname, fd); + return fd; +} + +static struct mount_point mount_points[] = { + { .path = "/var/log", .open = open_log, .dev = NULL }, + { .path = "/dev/mem", .open = open_mem, .dev = NULL }, +#ifdef CONFIG_CONSFRONT + { .path = "/dev/ptmx", .open = open_pt, .dev = NULL }, + { .path = "/var/lib/xen", .open = open_save, .dev = NULL }, +#endif +}; + +int open(const char *pathname, int flags, ...) +{ + unsigned int m, mlen; + struct mount_point *mnt; + mode_t mode = 0; + va_list ap; + + if ( flags & O_CREAT ) + { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); } - if (!strncmp(pathname, "/dev/mem", strlen("/dev/mem"))) { - fd = alloc_fd(FTYPE_MEM); - printk("open(/dev/mem) -> %d\n", fd); - return fd; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + mlen = strlen(mnt->path); + if ( !strncmp(pathname, mnt->path, mlen) && + (pathname[mlen] == '/' || pathname[mlen] == 0) ) + return mnt->open(mnt, pathname + mlen, flags, mode); } - if (!strncmp(pathname, "/dev/ptmx", strlen("/dev/ptmx"))) - return posix_openpt(flags); - if (!strncmp(pathname,SAVE_PATH,strlen(SAVE_PATH))) - return open_savefile(pathname, flags & O_WRONLY); + errno = EIO; return -1; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494216.764241 (Exim 4.92) (envelope-from ) id 1pRURy-0006N4-Ox; Mon, 13 Feb 2023 08:44:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494216.764241; Mon, 13 Feb 2023 08:44:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURy-0006Mu-LJ; Mon, 13 Feb 2023 08:44:38 +0000 Received: by outflank-mailman (input) for mailman id 494216; Mon, 13 Feb 2023 08:44:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRURw-0006An-NG for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3098a0a-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B5FC137870; Mon, 13 Feb 2023 08:44:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D23C1391B; Mon, 13 Feb 2023 08:44:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aHdDIXD46WNARAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3098a0a-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277872; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/tiDXbP/9+hZp0jDtSI+PwtYbXnE16R86Manl6T7bw=; b=qiR+HkdnGMmX36aZ+SoeWq7GNf4wwvzOGMdiNfYGeiA1zLvLOv6d/EiRWw5K3JRpmdJr1S 8nUOwXjEBHl7+0sNC8SUyEqCHPZOaAWUunLG4c6G56biCIP0q4goSBslMbUBZ2rS8JxS6/ MYvFRShMfQnaj/DJmzIY0bop4HB1F+M= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 3/7] Mini-OS: add support for runtime mounts Date: Mon, 13 Feb 2023 09:44:08 +0100 Message-Id: <20230213084412.21065-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the support to mount a device at runtime. The number of dynamic mounts is limited by a #define. For devices supporting multiple files struct file is modified to hold a pointer to file specific data in contrast to device specific data. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V3: - set number of possible mountpoints to 16 (Andrew Cooper) --- include/lib.h | 5 +++++ lib/sys.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/include/lib.h b/include/lib.h index 36d94ec4..fd8c36de 100644 --- a/include/lib.h +++ b/include/lib.h @@ -172,6 +172,7 @@ struct file { union { int fd; /* Any fd from an upper layer. */ void *dev; + void *filedata; }; }; @@ -194,6 +195,10 @@ struct mount_point { void *dev; }; +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)); +void umount(const char *path); + unsigned int alloc_file_type(const struct file_ops *ops); off_t lseek_default(struct file *file, off_t offset, int whence); diff --git a/lib/sys.c b/lib/sys.c index 2f33c937..118fc441 100644 --- a/lib/sys.c +++ b/lib/sys.c @@ -85,6 +85,8 @@ } #define NOFILE 32 +#define N_MOUNTS 16 + extern void minios_evtchn_close_fd(int fd); extern void minios_gnttab_close_fd(int fd); @@ -339,7 +341,7 @@ static int open_mem(struct mount_point *mnt, const char *pathname, int flags, return fd; } -static struct mount_point mount_points[] = { +static struct mount_point mount_points[N_MOUNTS] = { { .path = "/var/log", .open = open_log, .dev = NULL }, { .path = "/dev/mem", .open = open_mem, .dev = NULL }, #ifdef CONFIG_CONSFRONT @@ -365,6 +367,8 @@ int open(const char *pathname, int flags, ...) for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) { mnt = mount_points + m; + if ( !mnt->path ) + continue; mlen = strlen(mnt->path); if ( !strncmp(pathname, mnt->path, mlen) && (pathname[mlen] == '/' || pathname[mlen] == 0) ) @@ -375,6 +379,45 @@ int open(const char *pathname, int flags, ...) return -1; } +int mount(const char *path, void *dev, + int (*open)(struct mount_point *, const char *, int, mode_t)) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( !mnt->path ) + { + mnt->path = strdup(path); + mnt->open = open; + mnt->dev = dev; + return 0; + } + } + + errno = ENOSPC; + return -1; +} + +void umount(const char *path) +{ + unsigned int m; + struct mount_point *mnt; + + for ( m = 0; m < ARRAY_SIZE(mount_points); m++ ) + { + mnt = mount_points + m; + if ( mnt->path && !strcmp(mnt->path, path) ) + { + free((char *)mnt->path); + mnt->path = NULL; + return; + } + } +} + int isatty(int fd) { return files[fd].type == FTYPE_CONSOLE; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494222.764256 (Exim 4.92) (envelope-from ) id 1pRUS4-0006rw-4y; Mon, 13 Feb 2023 08:44:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494222.764256; Mon, 13 Feb 2023 08:44:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS4-0006r9-14; Mon, 13 Feb 2023 08:44:44 +0000 Received: by outflank-mailman (input) for mailman id 494222; Mon, 13 Feb 2023 08:44:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS2-0006An-PP for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:42 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a66207d9-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 574D037870; Mon, 13 Feb 2023 08:44:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27CEC1391B; Mon, 13 Feb 2023 08:44:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NVlaCHb46WNKRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a66207d9-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277878; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4NFSUNX/XcwJ+J4tdrvx1QT/0r6zmT/B4WFWAW17s1Y=; b=ustIl96+ogoy1DaxbvOYXnW7OajUyM3EpHALnPxdTl4PQWnCUph2nuuVepesGXpkt4r8NL iGr8qspU1Bgi5Hyqp2A6plTEteeirlzrHsxeFcST/dlYnekUQQjDJeKaBRVpOpxk1wU+R1 w3byhGuWbnR4KhqqjZNbmOlSHXa9Aps= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 4/7] Mini-OS: add 9pfs frontend Date: Mon, 13 Feb 2023 09:44:09 +0100 Message-Id: <20230213084412.21065-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a frontend for the 9pfs PV device. For now add only the code needed to connect to the backend and the related disconnect functionality. The 9pfs protocol support will be added later. Due to its nature (ability to access files) the whole code is guarded by "#ifdef HAVE_LIBC". Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - add better error handling to version parsing (Samuel Thibault) --- 9pfront.c | 286 ++++++++++++++++++++++++++++++++++ Config.mk | 1 + Makefile | 1 + arch/x86/testbuild/all-no | 1 + arch/x86/testbuild/all-yes | 1 + arch/x86/testbuild/newxen-yes | 1 + include/9pfront.h | 7 + 7 files changed, 298 insertions(+) create mode 100644 9pfront.c create mode 100644 include/9pfront.h diff --git a/9pfront.c b/9pfront.c new file mode 100644 index 00000000..89ecb3a1 --- /dev/null +++ b/9pfront.c @@ -0,0 +1,286 @@ +/* + * Minimal 9pfs PV frontend for Mini-OS. + * Copyright (c) 2023 Juergen Gross, SUSE Software Solution GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef HAVE_LIBC +struct dev_9pfs { + int id; + char nodename[20]; + unsigned int dom; + char *backend; + + char *tag; + const char *mnt; + + struct xen_9pfs_data_intf *intf; + struct xen_9pfs_data data; + RING_IDX prod_pvt_out; + RING_IDX cons_pvt_in; + + grant_ref_t ring_ref; + evtchn_port_t evtchn; + unsigned int ring_order; + xenbus_event_queue events; +}; + +#define DEFAULT_9PFS_RING_ORDER 4 + +static unsigned int ftype_9pfs; + +static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) +{ +} + +static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, + mode_t mode) +{ + errno = ENOSYS; + + return -1; +} + +static void free_9pfront(struct dev_9pfs *dev) +{ + unsigned int i; + + if ( dev->data.in && dev->intf ) + { + for ( i = 0; i < (1 << dev->ring_order); i++ ) + gnttab_end_access(dev->intf->ref[i]); + free_pages(dev->data.in, dev->ring_order); + } + unbind_evtchn(dev->evtchn); + gnttab_end_access(dev->ring_ref); + free_page(dev->intf); + free(dev->backend); + free(dev->tag); + free(dev); +} + +void *init_9pfront(unsigned int id, const char *mnt) +{ + struct dev_9pfs *dev; + char *msg; + char *reason = ""; + xenbus_transaction_t xbt; + int retry = 1; + char bepath[64] = { 0 }; + XenbusState state; + unsigned int i; + void *addr; + char *version; + char *v; + + printk("9pfsfront add %u, for mount at %s\n", id, mnt); + dev = malloc(sizeof(*dev)); + memset(dev, 0, sizeof(*dev)); + snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); + dev->id = id; + + msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "backend", &dev->backend); + if ( msg ) + goto err; + msg = xenbus_read_string(XBT_NIL, dev->nodename, "tag", &dev->tag); + if ( msg ) + goto err; + + snprintf(bepath, sizeof(bepath), "%s/state", dev->backend); + free(xenbus_watch_path_token(XBT_NIL, bepath, bepath, &dev->events)); + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateInitWait ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateInitWait ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_read_unsigned(XBT_NIL, dev->backend, "max-ring-page-order", + &dev->ring_order); + if ( msg ) + goto err; + if ( dev->ring_order > DEFAULT_9PFS_RING_ORDER ) + dev->ring_order = DEFAULT_9PFS_RING_ORDER; + + msg = xenbus_read_string(XBT_NIL, dev->backend, "versions", &version); + if ( msg ) + goto err; + for ( v = version; *v; v++ ) + { + if ( strtoul(v, &v, 10) == 1 && (*v == ',' || *v == 0) ) + { + v = NULL; + break; + } + if ( *v != ',' && *v != 0 ) + { + reason = "backend published illegal version string"; + free(version); + goto err; + } + } + free(version); + if ( v ) + { + reason = "backend doesn't support version 1"; + goto err; + } + + dev->ring_ref = gnttab_alloc_and_grant((void **)&dev->intf); + memset(dev->intf, 0, PAGE_SIZE); + if ( evtchn_alloc_unbound(dev->dom, intr_9pfs, dev, &dev->evtchn) ) + { + reason = "no event channel"; + goto err; + } + dev->intf->ring_order = dev->ring_order; + dev->data.in = (void *)alloc_pages(dev->ring_order); + dev->data.out = dev->data.in + XEN_FLEX_RING_SIZE(dev->ring_order); + for ( i = 0; i < (1 << dev->ring_order); i++ ) + { + addr = dev->data.in + i * PAGE_SIZE; + dev->intf->ref[i] = gnttab_grant_access(dev->dom, virt_to_mfn(addr), 0); + } + + while ( retry ) + { + msg = xenbus_transaction_start(&xbt); + if ( msg ) + { + free(msg); + msg = NULL; + reason = "starting transaction"; + goto err; + } + + msg = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", 1); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "ring-ref0", "%u", + dev->ring_ref); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "event-channel-0", "%u", + dev->evtchn); + if ( msg ) + goto err_tr; + msg = xenbus_printf(xbt, dev->nodename, "state", "%u", + XenbusStateInitialised); + if ( msg ) + goto err_tr; + + free(xenbus_transaction_end(xbt, 0, &retry)); + } + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateConnected ) + msg = xenbus_wait_for_state_change(bepath, &state, &dev->events); + if ( msg || state != XenbusStateConnected ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev->nodename, "state", "%u", + XenbusStateConnected); + if ( msg ) + goto err; + + unmask_evtchn(dev->evtchn); + + dev->mnt = mnt; + if ( mount(dev->mnt, dev, open_9pfs) ) + { + reason = "mount failed"; + goto err; + } + + return dev; + + err_tr: + free(xenbus_transaction_end(xbt, 1, &retry)); + + err: + if ( bepath[0] ) + free(xenbus_unwatch_path_token(XBT_NIL, bepath, bepath)); + if ( msg ) + printk("9pfsfront add %u failed, error %s accessing Xenstore\n", + id, msg); + else + printk("9pfsfront add %u failed, %s\n", id, reason); + free_9pfront(dev); + free(msg); + return NULL; +} + +void shutdown_9pfront(void *dev) +{ + struct dev_9pfs *dev9p = dev; + char bepath[64]; + XenbusState state; + char *msg; + char *reason = ""; + + umount(dev9p->mnt); + snprintf(bepath, sizeof(bepath), "%s/state", dev9p->backend); + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosing); + if ( msg ) + goto err; + + state = xenbus_read_integer(bepath); + while ( msg == NULL && state < XenbusStateClosing) + msg = xenbus_wait_for_state_change(bepath, &state, &dev9p->events); + if ( msg || state != XenbusStateClosing ) + { + reason = "illegal backend state"; + goto err; + } + + msg = xenbus_printf(XBT_NIL, dev9p->nodename, "state", "%u", + XenbusStateClosed); + if ( msg ) + goto err; + + free_9pfront(dev9p); + + return; + + err: + if ( msg ) + printk("9pfsfront shutdown %u failed, error %s accessing Xenstore\n", + dev9p->id, msg); + else + printk("9pfsfront shutdown %u failed, %s\n", dev9p->id, reason); + free(msg); +} + +static const struct file_ops ops_9pfs = { + .name = "9pfs", +}; + +__attribute__((constructor)) +static void initialize_9pfs(void) +{ + ftype_9pfs = alloc_file_type(&ops_9pfs); +} + +#endif /* HAVE_LIBC */ diff --git a/Config.mk b/Config.mk index 1a24b30e..677e93df 100644 --- a/Config.mk +++ b/Config.mk @@ -187,6 +187,7 @@ CONFIG-n += CONFIG_QEMU_XS_ARGS CONFIG-n += CONFIG_TEST CONFIG-n += CONFIG_PCIFRONT CONFIG-n += CONFIG_TPMFRONT +CONFIG-n += CONFIG_9PFRONT CONFIG-n += CONFIG_TPM_TIS CONFIG-n += CONFIG_TPMBACK CONFIG-n += CONFIG_BALLOON diff --git a/Makefile b/Makefile index 747c7c01..7ee181a2 100644 --- a/Makefile +++ b/Makefile @@ -39,6 +39,7 @@ SUBDIRS := lib src-$(CONFIG_BLKFRONT) += blkfront.c src-$(CONFIG_CONSFRONT) += consfront.c src-$(CONFIG_TPMFRONT) += tpmfront.c +src-$(CONFIG_9PFRONT) += 9pfront.c src-$(CONFIG_TPM_TIS) += tpm_tis.c src-$(CONFIG_TPMBACK) += tpmback.c src-y += console.c diff --git a/arch/x86/testbuild/all-no b/arch/x86/testbuild/all-no index f79a1012..5b3e99ed 100644 --- a/arch/x86/testbuild/all-no +++ b/arch/x86/testbuild/all-no @@ -12,6 +12,7 @@ CONFIG_NETFRONT = n CONFIG_FBFRONT = n CONFIG_KBDFRONT = n CONFIG_CONSFRONT = n +CONFIG_9PFRONT = n CONFIG_XENBUS = n CONFIG_LIBXS = n CONFIG_LWIP = n diff --git a/arch/x86/testbuild/all-yes b/arch/x86/testbuild/all-yes index faa3af32..8ae489a4 100644 --- a/arch/x86/testbuild/all-yes +++ b/arch/x86/testbuild/all-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/arch/x86/testbuild/newxen-yes b/arch/x86/testbuild/newxen-yes index dc83e670..ee27a328 100644 --- a/arch/x86/testbuild/newxen-yes +++ b/arch/x86/testbuild/newxen-yes @@ -12,6 +12,7 @@ CONFIG_NETFRONT = y CONFIG_FBFRONT = y CONFIG_KBDFRONT = y CONFIG_CONSFRONT = y +CONFIG_9PFRONT = y CONFIG_XENBUS = y CONFIG_LIBXS = y CONFIG_BALLOON = y diff --git a/include/9pfront.h b/include/9pfront.h new file mode 100644 index 00000000..722ec564 --- /dev/null +++ b/include/9pfront.h @@ -0,0 +1,7 @@ +#ifndef __9PFRONT_H__ +#define __9PFRONT_H__ + +void *init_9pfront(unsigned int id, const char *mnt); +void shutdown_9pfront(void *dev); + +#endif /* __9PFRONT_H__ */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494224.764270 (Exim 4.92) (envelope-from ) id 1pRUS9-0007Q4-Lo; Mon, 13 Feb 2023 08:44:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494224.764270; Mon, 13 Feb 2023 08:44:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS9-0007Pp-Ip; Mon, 13 Feb 2023 08:44:49 +0000 Received: by outflank-mailman (input) for mailman id 494224; Mon, 13 Feb 2023 08:44:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUS8-0006An-HL for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:48 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9b5cdd0-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E4B5837878; Mon, 13 Feb 2023 08:44:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3FCA1391B; Mon, 13 Feb 2023 08:44:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ph6mKnv46WNXRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9b5cdd0-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277883; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vQv13aoJJoMtKTA7WtwSo7Ix8wqfh+IDZYgezsgINzs=; b=mie5sBtfJneqcDqjPNYBjOVLK5Mu3eoXFYC456ywsuTdUnYRhVJU+tTnnuOQn6g7Mxk1xS i02GShmKVUR60G+JAADQN7b2FrADG7EUKEgiRfsG2p7CCSW2qQezvOsxKl7M6+XLIjYKE6 JhILyPnLiCHWUx18K/Wy7cgOE04GYvQ= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 5/7] Mini-OS: add 9pfs transport layer Date: Mon, 13 Feb 2023 09:44:10 +0100 Message-Id: <20230213084412.21065-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the transport layer of 9pfs. This is basically the infrastructure to send requests to the backend and to receive the related answers via the rings. As a first example add the version and attach requests of the 9pfs protocol when mounting a new 9pfs device. For the version use the "9P2000.u" variant, as it is the smallest subset supported by the qemu based backend. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- V2: - add more comments (Samuel Thibault) - log short copy (Samuel Thibault) - send event after consuming response (Samuel Thibault) - reaturn EAGAIN in case no free request could be got (Samuel Thibault) --- 9pfront.c | 478 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 478 insertions(+) diff --git a/9pfront.c b/9pfront.c index 89ecb3a1..0b8d5461 100644 --- a/9pfront.c +++ b/9pfront.c @@ -7,6 +7,8 @@ #include #include #include +#include +#include #include #include #include @@ -14,6 +16,9 @@ #include #ifdef HAVE_LIBC + +#define N_REQS 64 + struct dev_9pfs { int id; char nodename[20]; @@ -22,6 +27,7 @@ struct dev_9pfs { char *tag; const char *mnt; + unsigned int msize_max; struct xen_9pfs_data_intf *intf; struct xen_9pfs_data data; @@ -32,14 +38,470 @@ struct dev_9pfs { evtchn_port_t evtchn; unsigned int ring_order; xenbus_event_queue events; + + unsigned int free_reqs; + struct req { + unsigned int id; + unsigned int next_free; /* N_REQS == end of list. */ + unsigned int cmd; + int result; + bool inflight; + unsigned char *data; /* Returned data. */ + } req[N_REQS]; + + struct wait_queue_head waitq; + struct semaphore ring_out_sem; + struct semaphore ring_in_sem; }; #define DEFAULT_9PFS_RING_ORDER 4 +#define P9_CMD_VERSION 100 +#define P9_CMD_ATTACH 104 +#define P9_CMD_ERROR 107 + +#define P9_QID_SIZE 13 + +struct p9_header { + uint32_t size; + uint8_t cmd; + uint16_t tag; +} __attribute__((packed)); + +#define P9_VERSION "9P2000.u" +#define P9_ROOT_FID ~0 + static unsigned int ftype_9pfs; +static struct req *get_free_req(struct dev_9pfs *dev) +{ + struct req *req; + + if ( dev->free_reqs == N_REQS ) + return NULL; + + req = dev->req + dev->free_reqs; + dev->free_reqs = req->next_free; + + return req; +} + +static void put_free_req(struct dev_9pfs *dev, struct req *req) +{ + req->next_free = dev->free_reqs; + req->inflight = false; + req->data = NULL; + dev->free_reqs = req->id; +} + +static unsigned int ring_out_free(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->prod_pvt_out, dev->intf->out_cons, ring_size); + rmb(); + + return ring_size - queued; +} + +static unsigned int ring_in_data(struct dev_9pfs *dev) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned int queued; + + queued = xen_9pfs_queued(dev->intf->in_prod, dev->cons_pvt_in, ring_size); + rmb(); + + return queued; +} + +static void copy_to_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->prod_pvt_out, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->intf->out_cons, ring_size); + + xen_9pfs_write_packet(dev->data.out, data, len, &prod, cons, ring_size); + dev->prod_pvt_out += len; +} + +static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) +{ + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + RING_IDX prod = xen_9pfs_mask(dev->intf->in_prod, ring_size); + RING_IDX cons = xen_9pfs_mask(dev->cons_pvt_in, ring_size); + + xen_9pfs_read_packet(data, dev->data.in, len, prod, &cons, ring_size); + dev->cons_pvt_in += len; +} + +/* + * send_9p() and rcv_9p() are using a special format string for specifying + * the kind of data sent/expected. Each data item is represented by a single + * character: + * U: 4 byte unsigned integer (uint32_t) + * S: String (2 byte length + characters) + * in the rcv_9p() case the data for string is allocated (length omitted, + * string terminated by a NUL character) + * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version + * and 8 bytes unique file id. Only valid for receiving. + */ +static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + struct p9_header hdr; + va_list ap, aq; + const char *f; + uint32_t intval; + uint16_t len; + char *strval; + + hdr.size = sizeof(hdr); + hdr.cmd = req->cmd; + hdr.tag = req->id; + + va_start(ap, fmt); + + va_copy(aq, ap); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + break; + case 'S': + hdr.size += 2; + strval = va_arg(aq, char *); + hdr.size += strlen(strval); + break; + default: + printk("send_9p: unknown format character %c\n", *f); + break; + } + } + va_end(aq); + + /* + * Waiting for free space must be done in the critical section! + * Otherwise we might get overtaken by other short requests. + */ + down(&dev->ring_out_sem); + + wait_event(dev->waitq, ring_out_free(dev) >= hdr.size); + + copy_to_ring(dev, &hdr, sizeof(hdr)); + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + break; + case 'S': + strval = va_arg(ap, char *); + len = strlen(strval); + copy_to_ring(dev, &len, sizeof(len)); + copy_to_ring(dev, strval, len); + break; + } + } + + wmb(); /* Data on ring must be seen before updating index. */ + dev->intf->out_prod = dev->prod_pvt_out; + req->inflight = true; + + up(&dev->ring_out_sem); + + va_end(ap); + + notify_remote_via_evtchn(dev->evtchn); +} + +/* + * Using an opportunistic approach for receiving data: in case multiple + * requests are outstanding (which is very unlikely), we nevertheless need + * to consume all data available until we reach the desired request. + * For requests other than the one we are waiting for, we link the complete + * data to the request via an intermediate buffer. For our own request we can + * omit that buffer and directly fill the caller provided variables. + * + * Helper functions: + * + * copy_bufs(): copy raw data into a target buffer. There can be 2 source + * buffers involved (in case the copy is done from the ring and it is across + * the ring end). The buffer pointers and lengths are updated according to + * the number of bytes copied. + * + * rcv_9p_copy(): copy the data (without the generic header) of a 9p response + * to the specified variables using the specified format string for + * deciphering the single item types. The decision whether to copy from the + * ring or an allocated buffer is done via the "hdr" parameter, which is + * NULL in the buffer case (in that case the header is located at the start + * of the buffer). + * + * rcv_9p_one(): Checks for an already filled buffer with the correct tag in + * it. If none is found, consumes one response. It checks the tag of the + * response in order to decide whether to allocate a buffer for putting the + * data into, or to fill the user supplied variables. Return true, if the + * tag did match. Waits if no data is ready to be consumed. + */ +static void copy_bufs(unsigned char **buf1, unsigned char **buf2, + unsigned int *len1, unsigned int *len2, + void *target, unsigned int len) +{ + if ( len <= *len1 ) + { + memcpy(target, *buf1, len); + *buf1 += len; + *len1 -= len; + } + else + { + memcpy(target, *buf1, *len1); + target = (char *)target + *len1; + len -= *len1; + *buf1 = *buf2; + *len1 = *len2; + *buf2 = NULL; + *len2 = 0; + if ( len > *len1 ) + { + printk("9pfs: short copy (dropping %u bytes)\n", len - *len1); + len = *len1; + } + memcpy(target, *buf1, *len1); + } +} + +static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, + struct p9_header *hdr, const char *fmt, va_list ap) +{ + struct p9_header *h = hdr ? hdr : (void *)req->data; + RING_IDX cons = dev->cons_pvt_in + h->size - sizeof(*h); + RING_IDX ring_size = XEN_FLEX_RING_SIZE(dev->ring_order); + unsigned char *buf1, *buf2; + unsigned int len1, len2; + const char *f; + char *str; + uint16_t len; + uint32_t err; + uint32_t *val; + char **strval; + uint8_t *qval; + + if ( hdr ) + { + buf1 = xen_9pfs_get_ring_ptr(dev->data.in, dev->cons_pvt_in, ring_size); + buf2 = xen_9pfs_get_ring_ptr(dev->data.in, 0, ring_size); + len1 = ring_size - xen_9pfs_mask(dev->cons_pvt_in, ring_size); + if ( len1 > h->size - sizeof(*h) ) + len1 = h->size - sizeof(*h); + len2 = h->size - sizeof(*h) - len1; + } + else + { + buf1 = req->data + sizeof(*h); + buf2 = NULL; + len1 = h->size - sizeof(*h); + len2 = 0; + } + + if ( h->cmd == P9_CMD_ERROR ) + { + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + str = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, str, len); + str[len] = 0; + printk("9pfs: request %u resulted in \"%s\"\n", req->cmd, str); + free(str); + err = EIO; + copy_bufs(&buf1, &buf2, &len1, &len2, &err, sizeof(err)); + req->result = err; + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + if ( h->cmd != req->cmd + 1 ) + { + req->result = EDOM; + printk("9pfs: illegal response: wrong return type (%u instead of %u)\n", + h->cmd, req->cmd + 1); + + if ( hdr ) + dev->cons_pvt_in = cons; + + return; + } + + req->result = 0; + + for ( f = fmt; *f; f++ ) + { + switch ( *f ) + { + case 'U': + val = va_arg(ap, uint32_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + break; + case 'S': + strval = va_arg(ap, char **); + copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); + *strval = malloc(len + 1); + copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); + (*strval)[len] = 0; + break; + case 'Q': + qval = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); + break; + default: + printk("rcv_9p: unknown format character %c\n", *f); + break; + } + } + + if ( hdr ) + dev->cons_pvt_in = cons; +} + +static bool rcv_9p_one(struct dev_9pfs *dev, struct req *req, const char *fmt, + va_list ap) +{ + struct p9_header hdr; + struct req *tmp; + + if ( req->data ) + { + rcv_9p_copy(dev, req, NULL, fmt, ap); + free(req->data); + req->data = NULL; + + return true; + } + + wait_event(dev->waitq, ring_in_data(dev) >= sizeof(hdr)); + + copy_from_ring(dev, &hdr, sizeof(hdr)); + + wait_event(dev->waitq, ring_in_data(dev) >= hdr.size - sizeof(hdr)); + + tmp = dev->req + hdr.tag; + if ( hdr.tag >= N_REQS || !tmp->inflight ) + { + printk("9pfs: illegal response: %s\n", + hdr.tag >= N_REQS ? "tag out of bounds" : "request not pending"); + dev->cons_pvt_in += hdr.size - sizeof(hdr); + + return false; + } + + tmp->inflight = false; + + if ( tmp != req ) + { + tmp->data = malloc(hdr.size); + memcpy(tmp->data, &hdr, sizeof(hdr)); + copy_from_ring(dev, tmp->data + sizeof(hdr), hdr.size - sizeof(hdr)); + + return false; + } + + rcv_9p_copy(dev, req, &hdr, fmt, ap); + + return true; +} + +static void rcv_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) +{ + va_list ap; + + va_start(ap, fmt); + + down(&dev->ring_in_sem); + + while ( !rcv_9p_one(dev, req, fmt, ap) ); + + rmb(); /* Read all data before updating ring index. */ + dev->intf->in_cons = dev->cons_pvt_in; + + notify_remote_via_evtchn(dev->evtchn); + + up(&dev->ring_in_sem); + + va_end(ap); +} + +static int p9_version(struct dev_9pfs *dev) +{ + unsigned int msize = XEN_FLEX_RING_SIZE(dev->ring_order) / 2; + struct req *req = get_free_req(dev); + char *verret; + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_VERSION; + send_9p(dev, req, "US", msize, P9_VERSION); + rcv_9p(dev, req, "US", &dev->msize_max, &verret); + ret = req->result; + + put_free_req(dev, req); + + if ( ret ) + return ret; + + if ( strcmp(verret, P9_VERSION) ) + ret = ENOMSG; + free(verret); + + return ret; +} + +static int p9_attach(struct dev_9pfs *dev) +{ + uint32_t fid = P9_ROOT_FID; + uint32_t afid = 0; + uint32_t uid = 0; + uint8_t qid[P9_QID_SIZE]; + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_ATTACH; + send_9p(dev, req, "UUSSU", fid, afid, "root", "root", uid); + rcv_9p(dev, req, "Q", qid); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int connect_9pfs(struct dev_9pfs *dev) +{ + int ret; + + ret = p9_version(dev); + if ( ret ) + return ret; + + return p9_attach(dev); +} + static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) { + struct dev_9pfs *dev = data; + + wake_up(&dev->waitq); } static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, @@ -87,6 +549,16 @@ void *init_9pfront(unsigned int id, const char *mnt) memset(dev, 0, sizeof(*dev)); snprintf(dev->nodename, sizeof(dev->nodename), "device/9pfs/%u", id); dev->id = id; + init_waitqueue_head(&dev->waitq); + init_SEMAPHORE(&dev->ring_out_sem, 1); + init_SEMAPHORE(&dev->ring_in_sem, 1); + + for ( i = 0; i < N_REQS; i++ ) + { + dev->req[i].id = i; + dev->req[i].next_free = i + 1; + } + dev->free_reqs = 0; msg = xenbus_read_unsigned(XBT_NIL, dev->nodename, "backend-id", &dev->dom); if ( msg ) @@ -205,6 +677,12 @@ void *init_9pfront(unsigned int id, const char *mnt) unmask_evtchn(dev->evtchn); + if ( connect_9pfs(dev) ) + { + reason = "9pfs connect failed"; + goto err; + } + dev->mnt = mnt; if ( mount(dev->mnt, dev, open_9pfs) ) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:44:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:44:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494228.764282 (Exim 4.92) (envelope-from ) id 1pRUSD-0007mb-0c; Mon, 13 Feb 2023 08:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494228.764282; Mon, 13 Feb 2023 08:44:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSC-0007mK-SJ; Mon, 13 Feb 2023 08:44:52 +0000 Received: by outflank-mailman (input) for mailman id 494228; Mon, 13 Feb 2023 08:44:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSB-00053b-9D for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac7d7eb8-ab7a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 09:44:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E49637878; Mon, 13 Feb 2023 08:44:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EB861391B; Mon, 13 Feb 2023 08:44:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jYzjEYH46WNdRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac7d7eb8-ab7a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277889; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuLv/cVrd8nYj9ZnkPp0QX3mht4hZHquHGoCMyjlj9Y=; b=FOg9dV3cCjFNLjjcGtqOwZEN4eOnIsIPTWopUZeP4xCTUHeUT67PGlbAukAcIoUc7gl34J Y1jHcjKeWX2Yfr5RKdOo9j48QR8HReS229abwxdr3tT/jFsw0WmtlsltLteX+bYhSPRY7e +eHNiEzPz/WI6OVzvF1gAgUxMlJFznc= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 6/7] Mini-OS: add open and close handling to the 9pfs frontend Date: Mon, 13 Feb 2023 09:44:11 +0100 Message-Id: <20230213084412.21065-7-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the open() and close() support to the 9pfs frontend. This requires to split the path name and to walk to the desired directory level. Signed-off-by: Juergen Gross --- V2: - check path to be canonical - avoid short read when walking the path - fix get_fid() (Samuel Thibault) - return EAGAIN if no free request got (Samuel Thibault) V3: - add check for "//" in path_canonical() (Samuel Thibault) --- 9pfront.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 322 insertions(+), 2 deletions(-) diff --git a/9pfront.c b/9pfront.c index 0b8d5461..fb2e5669 100644 --- a/9pfront.c +++ b/9pfront.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -52,13 +53,32 @@ struct dev_9pfs { struct wait_queue_head waitq; struct semaphore ring_out_sem; struct semaphore ring_in_sem; + + unsigned long long fid_mask; /* Bit mask for free fids. */ +}; + +struct file_9pfs { + uint32_t fid; + struct dev_9pfs *dev; + bool append; }; #define DEFAULT_9PFS_RING_ORDER 4 +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ #define P9_CMD_VERSION 100 #define P9_CMD_ATTACH 104 #define P9_CMD_ERROR 107 +#define P9_CMD_WALK 110 +#define P9_CMD_OPEN 112 +#define P9_CMD_CREATE 114 +#define P9_CMD_CLUNK 120 + +/* P9 protocol open flags. */ +#define P9_OREAD 0 /* read */ +#define P9_OWRITE 1 /* write */ +#define P9_ORDWR 2 /* read and write */ +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ #define P9_QID_SIZE 13 @@ -69,10 +89,27 @@ struct p9_header { } __attribute__((packed)); #define P9_VERSION "9P2000.u" -#define P9_ROOT_FID ~0 +#define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static unsigned int get_fid(struct dev_9pfs *dev) +{ + unsigned int fid; + + fid = ffs(dev->fid_mask); + if ( fid ) + dev->fid_mask &= ~(1ULL << (fid - 1)); + + return fid; +} + +static void put_fid(struct dev_9pfs *dev, unsigned int fid) +{ + if ( fid ) + dev->fid_mask |= 1ULL << (fid - 1); +} + static struct req *get_free_req(struct dev_9pfs *dev) { struct req *req; @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * send_9p() and rcv_9p() are using a special format string for specifying * the kind of data sent/expected. Each data item is represented by a single * character: + * b: 1 byte unsigned integer (uint8_t) + * Only valid for sending. + * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) va_list ap, aq; const char *f; uint32_t intval; + uint16_t shortval; uint16_t len; + uint8_t byte; char *strval; hdr.size = sizeof(hdr); @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + hdr.size += 1; + byte = va_arg(aq, unsigned int); + break; + case 'u': + hdr.size += 2; + shortval = va_arg(aq, unsigned int); + break; case 'U': hdr.size += 4; intval = va_arg(aq, unsigned int); @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) { switch ( *f ) { + case 'b': + byte = va_arg(ap, unsigned int); + copy_to_ring(dev, &byte, sizeof(byte)); + break; + case 'u': + shortval = va_arg(ap, unsigned int); + copy_to_ring(dev, &shortval, sizeof(shortval)); + break; case 'U': intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, char *str; uint16_t len; uint32_t err; + uint16_t *shortval; uint32_t *val; char **strval; uint8_t *qval; @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, { switch ( *f ) { + case 'u': + shortval = va_arg(ap, uint16_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); + break; case 'U': val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); @@ -486,6 +549,170 @@ static int p9_attach(struct dev_9pfs *dev) return ret; } +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CLUNK; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, ""); + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, + char *name) +{ + struct req *req = get_free_req(dev); + int ret; + uint16_t nqid; + uint8_t qid[P9_QID_SIZE]; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_WALK; + if ( name[0] ) + { + send_9p(dev, req, "UUuS", fid, newfid, 1, name); + rcv_9p(dev, req, "uQ", &nqid, qid); + } + else + { + send_9p(dev, req, "UUu", fid, newfid, 0); + rcv_9p(dev, req, "u", &nqid); + } + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_OPEN; + send_9p(dev, req, "Ub", fid, omode); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, + uint32_t mode, uint8_t omode) +{ + struct req *req = get_free_req(dev); + int ret; + uint8_t qid[P9_QID_SIZE]; + uint32_t iounit; + + if ( !req ) + return EAGAIN; + + req->cmd = P9_CMD_CREATE; + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); + rcv_9p(dev, req, "QU", qid, &iounit); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +/* + * Walk from root levels with the levels listed in <*paths> as a + * sequence of names. Returns the number of steps not having been able to + * walk, with <*paths> pointing at the name of the failing walk step. + * will be associated with the last successful walk step. Note that + * the first step should always succeed, as it is an empty walk in order + * to start at the root (needed for creating new files in root). + */ +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, + unsigned int steps, char **paths) +{ + uint32_t curr_fid = P9_ROOT_FID; + int ret; + + while ( steps-- ) + { + ret = p9_walk(dev, curr_fid, fid, *paths); + if ( ret ) + return steps + 1; + curr_fid = fid; + *paths += strlen(*paths) + 1; + } + + return 0; +} + +static unsigned int split_path(const char *pathname, char **split_ptr) +{ + unsigned int parts = 1; + char *p; + + *split_ptr = strdup(pathname); + + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) + { + *p = 0; + parts++; + } + + return parts; +} + +static bool path_canonical(const char *pathname) +{ + unsigned int len = strlen(pathname); + const char *c; + + /* Empty path is allowed. */ + if ( !len ) + return true; + + /* No trailing '/'. */ + if ( pathname[len - 1] == '/' ) + return false; + + /* No self or parent references. */ + c = pathname; + while ( (c = strstr(c, "/.")) != NULL ) + { + if ( c[2] == '.' ) + c++; + if ( c[2] == 0 || c[2] == '/' ) + return false; + c += 2; + } + + /* No "//". */ + if ( strstr(pathname, "//") ) + return false; + + return true; +} + static int connect_9pfs(struct dev_9pfs *dev) { int ret; @@ -504,10 +731,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int close_9pfs(struct file *file) +{ + struct file_9pfs *f9pfs = file->filedata; + + if ( f9pfs->fid != P9_ROOT_FID ) + { + p9_clunk(f9pfs->dev, f9pfs->fid); + put_fid(f9pfs->dev, f9pfs->fid); + } + + free(f9pfs); + + return 0; +} + static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, mode_t mode) { - errno = ENOSYS; + int fd; + char *path = NULL; + char *p; + struct file *file; + struct file_9pfs *f9pfs; + uint16_t nwalk; + uint8_t omode; + int ret; + + if ( !path_canonical(pathname) ) + return EINVAL; + + f9pfs = calloc(1, sizeof(*f9pfs)); + f9pfs->dev = mnt->dev; + f9pfs->fid = P9_ROOT_FID; + + fd = alloc_fd(ftype_9pfs); + file = get_file_from_fd(fd); + file->filedata = f9pfs; + + switch ( flags & O_ACCMODE ) + { + case O_RDONLY: + omode = P9_OREAD; + break; + case O_WRONLY: + omode = P9_OWRITE; + break; + case O_RDWR: + omode = P9_ORDWR; + break; + default: + ret = EINVAL; + goto err; + } + + if ( flags & O_TRUNC ) + omode |= P9_OTRUNC; + f9pfs->append = flags & O_APPEND; + + nwalk = split_path(pathname, &path); + + f9pfs->fid = get_fid(mnt->dev); + if ( !f9pfs->fid ) + { + ret = ENFILE; + goto err; + } + p = path; + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); + if ( nwalk ) + { + if ( nwalk > 1 || !(flags & O_CREAT) ) + { + ret = ENOENT; + goto err; + } + + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); + if ( ret ) + goto err; + goto out; + } + + ret = p9_open(mnt->dev, f9pfs->fid, omode); + if ( ret ) + goto err; + + out: + free(path); + + return fd; + + err: + free(path); + close(fd); + errno = ret; return -1; } @@ -552,6 +870,7 @@ void *init_9pfront(unsigned int id, const char *mnt) init_waitqueue_head(&dev->waitq); init_SEMAPHORE(&dev->ring_out_sem, 1); init_SEMAPHORE(&dev->ring_in_sem, 1); + dev->fid_mask = ~0ULL; for ( i = 0; i < N_REQS; i++ ) { @@ -753,6 +1072,7 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .close = close_9pfs, }; __attribute__((constructor)) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 08:45:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 08:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494248.764300 (Exim 4.92) (envelope-from ) id 1pRUSf-0000xC-M9; Mon, 13 Feb 2023 08:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494248.764300; Mon, 13 Feb 2023 08:45:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSf-0000x3-Hv; Mon, 13 Feb 2023 08:45:21 +0000 Received: by outflank-mailman (input) for mailman id 494248; Mon, 13 Feb 2023 08:45:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRUSI-0006An-PA for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 08:44:58 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b05b9c56-ab7a-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 09:44:55 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 15D2437870; Mon, 13 Feb 2023 08:44:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2B901391B; Mon, 13 Feb 2023 08:44:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MGEsNob46WNwRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 08:44:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b05b9c56-ab7a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676277895; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nsb+k9M0ZRBDQHW/kSOuXta4SExd/WLGLnOu4GRbNW4=; b=Fcg2Q83nLC0WBcoRucEIdajqN7DsYJYPRsQPs+EnbbinXqqUVaSWq/5SZvWLrMiVUuH7OM 6RvXh3I1syHWV0+AbGaKQZEc3B5Qyxkga0cEwTzN1UWkD3UlVLAB08K6IfO2dgJZoPG94d ZQBwFac7ZekExICyEYzSUgC0BbM/mWs= From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH v3 7/7] Mini-OS: add read and write support to 9pfsfront Date: Mon, 13 Feb 2023 09:44:12 +0100 Message-Id: <20230213084412.21065-8-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213084412.21065-1-jgross@suse.com> References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support to read from and write to a file handled by 9pfsfront. Signed-off-by: Juergen Gross --- V2: - add check for max message size - return EAGAIN in case no free request got (Samuel Thibault) - loop until all data read/written (Samuel Thibault) V3: - use an exact limit for read/write (Samuel Thibault) - log read(write errors (Samuel Thibault) --- 9pfront.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 216 insertions(+) diff --git a/9pfront.c b/9pfront.c index fb2e5669..5da8a365 100644 --- a/9pfront.c +++ b/9pfront.c @@ -72,7 +72,10 @@ struct file_9pfs { #define P9_CMD_WALK 110 #define P9_CMD_OPEN 112 #define P9_CMD_CREATE 114 +#define P9_CMD_READ 116 +#define P9_CMD_WRITE 118 #define P9_CMD_CLUNK 120 +#define P9_CMD_STAT 124 /* P9 protocol open flags. */ #define P9_OREAD 0 /* read */ @@ -88,11 +91,39 @@ struct p9_header { uint16_t tag; } __attribute__((packed)); +struct p9_stat { + uint16_t size; + uint16_t type; + uint32_t dev; + uint8_t qid[P9_QID_SIZE]; + uint32_t mode; + uint32_t atime; + uint32_t mtime; + uint64_t length; + char *name; + char *uid; + char *gid; + char *muid; + char *extension; + uint32_t n_uid; + uint32_t n_gid; + uint32_t n_muid; +}; + #define P9_VERSION "9P2000.u" #define P9_ROOT_FID 0 static unsigned int ftype_9pfs; +static void free_stat(struct p9_stat *stat) +{ + free(stat->name); + free(stat->uid); + free(stat->gid); + free(stat->muid); + free(stat->extension); +} + static unsigned int get_fid(struct dev_9pfs *dev) { unsigned int fid; @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) * Only valid for sending. * u: 2 byte unsigned integer (uint16_t) * U: 4 byte unsigned integer (uint32_t) + * L: 8 byte unsigned integer (uint64_t) * S: String (2 byte length + characters) * in the rcv_9p() case the data for string is allocated (length omitted, * string terminated by a NUL character) + * D: Binary data (4 byte length + bytes of data), requires a length + * and a buffer pointer parameter. * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version * and 8 bytes unique file id. Only valid for receiving. */ @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) struct p9_header hdr; va_list ap, aq; const char *f; + uint64_t longval; uint32_t intval; uint16_t shortval; uint16_t len; uint8_t byte; + uint8_t *data; char *strval; hdr.size = sizeof(hdr); @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) hdr.size += 4; intval = va_arg(aq, unsigned int); break; + case 'L': + hdr.size += 8; + longval = va_arg(aq, uint64_t); + break; case 'S': hdr.size += 2; strval = va_arg(aq, char *); hdr.size += strlen(strval); break; + case 'D': + hdr.size += 4; + intval = va_arg(aq, unsigned int); + hdr.size += intval; + data = va_arg(aq, uint8_t *); + break; default: printk("send_9p: unknown format character %c\n", *f); break; @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) intval = va_arg(ap, unsigned int); copy_to_ring(dev, &intval, sizeof(intval)); break; + case 'L': + longval = va_arg(ap, uint64_t); + copy_to_ring(dev, &longval, sizeof(longval)); + break; case 'S': strval = va_arg(ap, char *); len = strlen(strval); copy_to_ring(dev, &len, sizeof(len)); copy_to_ring(dev, strval, len); break; + case 'D': + intval = va_arg(ap, unsigned int); + copy_to_ring(dev, &intval, sizeof(intval)); + data = va_arg(ap, uint8_t *); + copy_to_ring(dev, data, intval); + break; } } @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, uint32_t err; uint16_t *shortval; uint32_t *val; + uint64_t *longval; + uint8_t *data; char **strval; uint8_t *qval; @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, val = va_arg(ap, uint32_t *); copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); break; + case 'L': + longval = va_arg(ap, uint64_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); + break; case 'S': strval = va_arg(ap, char **); copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); (*strval)[len] = 0; break; + case 'D': + val = va_arg(ap, uint32_t *); + data = va_arg(ap, uint8_t *); + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); + break; case 'Q': qval = va_arg(ap, uint8_t *); copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); @@ -640,6 +708,115 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, return ret; } +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) +{ + struct req *req = get_free_req(dev); + int ret; + + if ( !req ) + return EAGAIN; + + memset(stat, 0, sizeof(*stat)); + req->cmd = P9_CMD_STAT; + send_9p(dev, req, "U", fid); + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, + &stat->n_uid, &stat->n_gid, &stat->n_muid); + + ret = req->result; + + put_free_req(dev, req); + + return ret; +} + +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count, count_max; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_READ; + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t)); + + while ( len ) + { + count = len; + if ( count > count_max ) + count = count_max; + + send_9p(dev, req, "ULU", fid, offset, count); + rcv_9p(dev, req, "D", &count, data); + + if ( !count ) + break; + if ( req->result ) + { + ret = -1; + errno = EIO; + printk("9pfs: read got error %d\n", req->result); + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, + const uint8_t *data, uint32_t len) +{ + struct req *req = get_free_req(dev); + int ret = 0; + uint32_t count, count_max; + + if ( !req ) + { + errno = EAGAIN; + return -1; + } + req->cmd = P9_CMD_WRITE; + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t) + + sizeof(uint64_t) + sizeof(uint32_t)); + + while ( len ) + { + count = len; + if ( count > count_max ) + count = count_max; + + send_9p(dev, req, "ULD", fid, offset, count, data); + rcv_9p(dev, req, "U", &count); + if ( req->result ) + { + ret = -1; + errno = EIO; + printk("9pfs: write got error %d\n", req->result); + break; + } + ret += count; + offset += count; + data += count; + len -= count; + } + + put_free_req(dev, req); + + return ret; +} + /* * Walk from root levels with the levels listed in <*paths> as a * sequence of names. Returns the number of steps not having been able to @@ -731,6 +908,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) wake_up(&dev->waitq); } +static int read_9pfs(struct file *file, void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + int ret; + + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) +{ + struct file_9pfs *f9pfs = file->filedata; + struct p9_stat stat; + int ret; + + if ( f9pfs->append ) + { + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); + free_stat(&stat); + if ( ret ) + { + errno = EIO; + return -1; + } + file->offset = stat.length; + } + + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); + if ( ret >= 0 ) + file->offset += ret; + + return ret; +} + static int close_9pfs(struct file *file) { struct file_9pfs *f9pfs = file->filedata; @@ -1072,6 +1286,8 @@ void shutdown_9pfront(void *dev) static const struct file_ops ops_9pfs = { .name = "9pfs", + .read = read_9pfs, + .write = write_9pfs, .close = close_9pfs, }; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 09:26:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 09:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494281.764312 (Exim 4.92) (envelope-from ) id 1pRV6I-0002Q2-Vg; Mon, 13 Feb 2023 09:26:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494281.764312; Mon, 13 Feb 2023 09:26:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRV6I-0002Pe-PY; Mon, 13 Feb 2023 09:26:18 +0000 Received: by outflank-mailman (input) for mailman id 494281; Mon, 13 Feb 2023 09:26:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRV6H-0002PY-AW for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 09:26:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 753f1586-ab80-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 10:26:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B545C1F45A; Mon, 13 Feb 2023 09:26:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 791121391B; Mon, 13 Feb 2023 09:26:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2WXBGDQC6mPaWQAAMHmgww (envelope-from ); Mon, 13 Feb 2023 09:26:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 753f1586-ab80-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676280372; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r2sjVhfd+q+uojrYtYYnj4aMFGOfssTh5v0PLQIcmB4=; b=tTQfAx5sxWPZimQPUVaHfWUwwg2dC0Rxj/R5qx5jFRit+89Exg33Kalc/uVbBB1xlQA2Iw 1iik1Ri0GTbkck5hpoyJjhzj+8pKTsKO8hU7AkvSaq9EjkkiFhsl4B04EpI3yzdF2wWGMG 4DnkOHGcZZ5p3AUf8s99mvSC1GgndtA= Message-ID: <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> Date: Mon, 13 Feb 2023 10:26:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230207021033.1797-1-demi@invisiblethingslab.com> From: Juergen Gross Subject: Re: [PATCH] xen: speed up grant-table reclaim In-Reply-To: <20230207021033.1797-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YR0M9lrsKJ1khWzPs4cz0bCG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YR0M9lrsKJ1khWzPs4cz0bCG Content-Type: multipart/mixed; boundary="------------WXAnykrIV00daOHG6Z0mg2gk"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> Subject: Re: [PATCH] xen: speed up grant-table reclaim References: <20230207021033.1797-1-demi@invisiblethingslab.com> In-Reply-To: <20230207021033.1797-1-demi@invisiblethingslab.com> --------------WXAnykrIV00daOHG6Z0mg2gk Content-Type: multipart/mixed; boundary="------------iH8yr0Lb8F8zxF095ePwpBum" --------------iH8yr0Lb8F8zxF095ePwpBum Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDIuMjMgMDM6MTAsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gV2hlbiBh IGdyYW50IGVudHJ5IGlzIHN0aWxsIGluIHVzZSBieSB0aGUgcmVtb3RlIGRvbWFpbiwgTGlu dXggbXVzdCBwdXQNCj4gaXQgb24gYSBkZWZlcnJlZCBsaXN0LiAgTm9ybWFsbHksIHRoaXMg bGlzdCBpcyB2ZXJ5IHNob3J0LCBiZWNhdXNlDQo+IHRoZSBQViBuZXR3b3JrIGFuZCBibG9j ayBwcm90b2NvbHMgZXhwZWN0IHRoZSBiYWNrZW5kIHRvIHVubWFwIHRoZSBncmFudA0KPiBm aXJzdC4gIEhvd2V2ZXIsIFF1YmVzIE9TJ3MgR1VJIHByb3RvY29sIGlzIHN1YmplY3QgdG8g dGhlIGNvbnN0cmFpbnRzDQo+IG9mIHRoZSBYIFdpbmRvdyBTeXN0ZW0sIGFuZCBhcyBzdWNo IHdpbmRzIHVwIHdpdGggdGhlIGZyb250ZW5kIHVubWFwcGluZw0KPiB0aGUgd2luZG93IGZp cnN0LiAgQXMgYSByZXN1bHQsIHRoZSBsaXN0IGNhbiBncm93IHZlcnkgbGFyZ2UsIHJlc3Vs dGluZw0KPiBpbiBhIG1hc3NpdmUgbWVtb3J5IGxlYWsgYW5kIGV2ZW50dWFsIFZNIGZyZWV6 ZS4NCj4gDQo+IEZpeCB0aGlzIHByb2JsZW0gYnkgYnVtcGluZyB0aGUgbnVtYmVyIG9mIGVu dHJpZXMgdGhhdCB0aGUgVk0gd2lsbA0KPiBhdHRlbXB0IHRvIGZyZWUgYXQgZWFjaCBpdGVy YXRpb24gdG8gMTAwMDAuICBUaGlzIGlzIGFuIHVnbHkgaGFjayB0aGF0DQo+IG1heSB3ZWxs IG1ha2UgYSBkZW5pYWwgb2Ygc2VydmljZSBlYXNpZXIsIGJ1dCBmb3IgUXViZXMgT1MgdGhh dCBpcyBsZXNzDQo+IGJhZCB0aGFuIHRoZSBwcm9ibGVtIFF1YmVzIE9TIHVzZXJzIGFyZSBm YWNpbmcgdG9kYXkuDQoNCj4gVGhlcmUgcmVhbGx5DQo+IG5lZWRzIHRvIGJlIGEgd2F5IGZv ciBhIGZyb250ZW5kIHRvIGJlIG5vdGlmaWVkIHdoZW4gdGhlIGJhY2tlbmQgaGFzDQo+IHVu bWFwcGVkIHRoZSBncmFudHMuDQoNClBsZWFzZSByZW1vdmUgdGhpcyBzZW50ZW5jZSBmcm9t IHRoZSBjb21taXQgbWVzc2FnZSwgb3IgbW92ZSBpdCBiZWxvdyB0aGUNCiItLS0iIG1hcmtl ci4NCg0KVGhlcmUgYXJlIHN0aWxsIHNvbWUgZmxhZyBiaXRzIHVuYWxsb2NhdGVkIGluIHN0 cnVjdCBncmFudF9lbnRyeV92MSBvcg0Kc3RydWN0IGdyYW50X2VudHJ5X2hlYWRlci4gWW91 IGNvdWxkIHN1Z2dlc3Qgc29tZSBwYXRjaGVzIGZvciBYZW4gdG8gdXNlDQpvbmUgb2YgdGhl IGJpdHMgYXMgYSBtYXJrZXIgdG8gZ2V0IGFuIGV2ZW50IGZyb20gdGhlIGh5cGVydmlzb3Ig aWYgYQ0KZ3JhbnQgd2l0aCBzdWNoIGEgYml0IHNldCBoYXMgYmVlbiB1bm1hcHBlZC4NCg0K SSBoYXZlIG5vIGlkZWEsIHdoZXRoZXIgc3VjaCBhbiBpbnRlcmZhY2Ugd291bGQgYmUgYWNj ZXB0ZWQgYnkgdGhlDQptYWludGFpbmVycywgdGhvdWdoLg0KDQo+IEFkZGl0aW9uYWxseSwg YSBtb2R1bGUgcGFyYW1ldGVyIGlzIHByb3ZpZGVkIHRvDQo+IGFsbG93IHR1bmluZyB0aGUg cmVjbGFpbSBzcGVlZC4NCj4gDQo+IFRoZSBjb2RlIHByZXZpb3VzbHkgdXNlZCBwcmludGso S0VSTl9ERUJVRykgd2hlbmV2ZXIgaXQgaGFkIHRvIGRlZmVyDQo+IHJlY2xhaW1pbmcgYSBw YWdlIGJlY2F1c2UgdGhlIGdyYW50IHdhcyBzdGlsbCBtYXBwZWQuICBUaGlzIHJlc3VsdGVk IGluDQo+IGEgbGFyZ2Ugdm9sdW1lIG9mIGxvZyBtZXNzYWdlcyB0aGF0IGJvdGhlcmVkIHVz ZXJzLiAgVXNlIHByX2RlYnVnDQo+IGluc3RlYWQsIHdoaWNoIHN1cHByZXNzZXMgdGhlIG1l c3NhZ2VzIGJ5IGRlZmF1bHQuICBEZXZlbG9wZXJzIGNhbg0KPiBlbmFibGUgdGhlbSB1c2lu ZyB0aGUgZHluYW1pYyBkZWJ1ZyBtZWNoYW5pc20uDQo+IA0KPiBGaXhlczogUXViZXNPUy9x dWJlcy1pc3N1ZXMjNzQxMCAobWVtb3J5IGxlYWspDQo+IEZpeGVzOiBRdWJlc09TL3F1YmVz LWlzc3VlcyM3MzU5IChleGNlc3NpdmUgbG9nZ2luZykNCj4gRml4ZXM6IDU2OWNhNWIzZjk0 YyAoInhlbi9nbnR0YWI6IGFkZCBkZWZlcnJlZCBmcmVlaW5nIGxvZ2ljIikNCj4gQ2M6IHN0 YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCj4gU2lnbmVkLW9mZi1ieTogRGVtaSBNYXJpZSBPYmVu b3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+IC0tLQ0KPiBBbnlvbmUgaGF2 ZSBzdWdnZXN0aW9ucyBmb3IgaW1wcm92aW5nIHRoZSBncmFudCBtZWNoYW5pc20/ICBBcmdv IGlzbid0DQo+IGEgZ29vZCBvcHRpb24sIGFzIGluIHRoZSBHVUkgcHJvdG9jb2wgdGhlcmUg YXJlIHN1YnN0YW50aWFsIHBlcmZvcm1hbmNlDQo+IHdpbnMgdG8gYmUgaGFkIGJ5IHVzaW5n IHRydWUgc2hhcmVkIG1lbW9yeS4gIFJlc2VuZGluZyBhcyBJIGZvcmdvdCB0aGUNCj4gU2ln bmVkLW9mZi1ieSBvbiB0aGUgZmlyc3Qgc3VibWlzc2lvbi4gIFNvcnJ5IGFib3V0IHRoYXQu DQo+IA0KPiAgIGRyaXZlcnMveGVuL2dyYW50LXRhYmxlLmMgfCAyICstDQo+ICAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy94ZW4vZ3JhbnQtdGFibGUuYyBiL2RyaXZlcnMveGVuL2dyYW50LXRh YmxlLmMNCj4gaW5kZXggNWM4M2Q0MS4uMmMyZmFhNyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy94ZW4vZ3JhbnQtdGFibGUuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9ncmFudC10YWJsZS5j DQo+IEBAIC0zNTUsMTQgKzM1NSwyMCBAQA0KPiAgIHN0YXRpYyB2b2lkIGdudHRhYl9oYW5k bGVfZGVmZXJyZWQoc3RydWN0IHRpbWVyX2xpc3QgKik7DQo+ICAgc3RhdGljIERFRklORV9U SU1FUihkZWZlcnJlZF90aW1lciwgZ250dGFiX2hhbmRsZV9kZWZlcnJlZCk7DQo+ICAgDQo+ ICtzdGF0aWMgYXRvbWljNjRfdCBkZWZlcnJlZF9jb3VudDsNCj4gK3N0YXRpYyBhdG9taWM2 NF90IGxlYWtlZF9jb3VudDsNCj4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgZnJlZV9wZXJfaXRl cmF0aW9uID0gMTAwMDA7DQoNCkFzIHlvdSBhcmUgYWRkaW5nIGEga2VybmVsIHBhcmFtZXRl ciB0byBjaGFuZ2UgdGhpcyB2YWx1ZSwgcGxlYXNlIHNldCB0aGUNCmRlZmF1bHQgdG8gYSB2 YWx1ZSBub3QgcG90ZW50aWFsbHkgY2F1c2luZyBhbnkgRG9TIHByb2JsZW1zLiBRdWJlcyBP UyBjYW4NCnN0aWxsIHVzZSBhIGhpZ2hlciB2YWx1ZSB0aGVuLg0KDQo+ICsNCj4gICBzdGF0 aWMgdm9pZCBnbnR0YWJfaGFuZGxlX2RlZmVycmVkKHN0cnVjdCB0aW1lcl9saXN0ICp1bnVz ZWQpDQo+ICAgew0KPiAtCXVuc2lnbmVkIGludCBuciA9IDEwOw0KPiArCXVuc2lnbmVkIGlu dCBuciA9IFJFQURfT05DRShmcmVlX3Blcl9pdGVyYXRpb24pOw0KDQpJIGRvbid0IHNlZSB3 aHkgeW91IGFyZSBuZWVkaW5nIFJFQURfT05DRSgpIGhlcmUuDQoNCj4gKwljb25zdCBib29s IGlnbm9yZV9saW1pdCA9IG5yID09IDA7DQoNCkkgZG9uJ3QgdGhpbmsgeW91IG5lZWQgdGhp cyBleHRyYSB2YXJpYWJsZSwgaWYgeW91IHdvdWxkIC4uLg0KDQo+ICAgCXN0cnVjdCBkZWZl cnJlZF9lbnRyeSAqZmlyc3QgPSBOVUxMOw0KPiAgIAl1bnNpZ25lZCBsb25nIGZsYWdzOw0K PiArCXNpemVfdCBmcmVlZCA9IDA7DQo+ICAgDQo+ICAgCXNwaW5fbG9ja19pcnFzYXZlKCZn bnR0YWJfbGlzdF9sb2NrLCBmbGFncyk7DQo+IC0Jd2hpbGUgKG5yLS0pIHsNCj4gKwl3aGls ZSAoKGlnbm9yZV9saW1pdCB8fCBuci0tKSAmJiAhbGlzdF9lbXB0eSgmZGVmZXJyZWRfbGlz dCkpIHsNCg0KLi4uIGNoYW5nZSB0aGlzIHRvICJ3aGlsZSAoKCFuciB8fCBuci0tKSAuLi4i Lg0KDQo+ICAgCQlzdHJ1Y3QgZGVmZXJyZWRfZW50cnkgKmVudHJ5DQo+ICAgCQkJPSBsaXN0 X2ZpcnN0X2VudHJ5KCZkZWZlcnJlZF9saXN0LA0KPiAgIAkJCQkJICAgc3RydWN0IGRlZmVy cmVkX2VudHJ5LCBsaXN0KTsNCj4gQEAgLTM3MiwxMCArMzc4LDEzIEBADQo+ICAgCQlsaXN0 X2RlbCgmZW50cnktPmxpc3QpOw0KPiAgIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZ250 dGFiX2xpc3RfbG9jaywgZmxhZ3MpOw0KPiAgIAkJaWYgKF9nbnR0YWJfZW5kX2ZvcmVpZ25f YWNjZXNzX3JlZihlbnRyeS0+cmVmKSkgew0KPiArCQkJdWludDY0X3QgcmV0ID0gYXRvbWlj NjRfc3ViX3JldHVybigxLCAmZGVmZXJyZWRfY291bnQpOw0KDQpVc2UgYXRvbWljNjRfZGVj X3JldHVybigpPw0KDQo+ICAgCQkJcHV0X2ZyZWVfZW50cnkoZW50cnktPnJlZik7DQo+IC0J CQlwcl9kZWJ1ZygiZnJlZWluZyBnLmUuICUjeCAocGZuICUjbHgpXG4iLA0KPiAtCQkJCSBl bnRyeS0+cmVmLCBwYWdlX3RvX3BmbihlbnRyeS0+cGFnZSkpOw0KPiArCQkJcHJfZGVidWco ImZyZWVpbmcgZy5lLiAlI3ggKHBmbiAlI2x4KSwgJWxsdSByZW1haW5pbmdcbiIsDQo+ICsJ CQkJIGVudHJ5LT5yZWYsIHBhZ2VfdG9fcGZuKGVudHJ5LT5wYWdlKSwNCj4gKwkJCQkgKHVu c2lnbmVkIGxvbmcgbG9uZylyZXQpOw0KDQpJcyBlYWNoIHNpbmdsZSBpbnN0YW5jZSBvZiB0 aGlzIG1lc3NhZ2UgcmVhbGx5IG5lZWRlZD8NCg0KSWYgbm90LCBJJ2Qgc3VnZ2VzdCB0byB1 c2UgcHJfZGVidWdfcmF0ZWxpbWl0ZWQoKSBpbnN0ZWFkLg0KDQo+ICAgCQkJcHV0X3BhZ2Uo ZW50cnktPnBhZ2UpOw0KPiArCQkJZnJlZWQrKzsNCj4gICAJCQlrZnJlZShlbnRyeSk7DQo+ ICAgCQkJZW50cnkgPSBOVUxMOw0KPiAgIAkJfSBlbHNlIHsNCj4gQEAgLTM4NywxNCArMzk2 LDE1IEBADQo+ICAgCQlzcGluX2xvY2tfaXJxc2F2ZSgmZ250dGFiX2xpc3RfbG9jaywgZmxh Z3MpOw0KPiAgIAkJaWYgKGVudHJ5KQ0KPiAgIAkJCWxpc3RfYWRkX3RhaWwoJmVudHJ5LT5s aXN0LCAmZGVmZXJyZWRfbGlzdCk7DQo+IC0JCWVsc2UgaWYgKGxpc3RfZW1wdHkoJmRlZmVy cmVkX2xpc3QpKQ0KPiAtCQkJYnJlYWs7DQo+ICAgCX0NCj4gLQlpZiAoIWxpc3RfZW1wdHko JmRlZmVycmVkX2xpc3QpICYmICF0aW1lcl9wZW5kaW5nKCZkZWZlcnJlZF90aW1lcikpIHsN Cj4gKwlpZiAobGlzdF9lbXB0eSgmZGVmZXJyZWRfbGlzdCkpDQo+ICsJCVdBUk5fT04oYXRv bWljNjRfcmVhZCgmZGVmZXJyZWRfY291bnQpKTsNCj4gKwllbHNlIGlmICghdGltZXJfcGVu ZGluZygmZGVmZXJyZWRfdGltZXIpKSB7DQo+ICAgCQlkZWZlcnJlZF90aW1lci5leHBpcmVz ID0gamlmZmllcyArIEhaOw0KPiAgIAkJYWRkX3RpbWVyKCZkZWZlcnJlZF90aW1lcik7DQo+ ICAgCX0NCj4gICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZ250dGFiX2xpc3RfbG9jaywg ZmxhZ3MpOw0KPiArCXByX2RlYnVnKCJGcmVlZCAlenUgcmVmZXJlbmNlcyIsIGZyZWVkKTsN Cj4gICB9DQo+ICAgDQo+ICAgc3RhdGljIHZvaWQgZ250dGFiX2FkZF9kZWZlcnJlZChncmFu dF9yZWZfdCByZWYsIHN0cnVjdCBwYWdlICpwYWdlKQ0KPiBAQCAtNDAyLDcgKzQxMiw3IEBA DQo+ICAgew0KPiAgIAlzdHJ1Y3QgZGVmZXJyZWRfZW50cnkgKmVudHJ5Ow0KPiAgIAlnZnBf dCBnZnAgPSAoaW5fYXRvbWljKCkgfHwgaXJxc19kaXNhYmxlZCgpKSA/IEdGUF9BVE9NSUMg OiBHRlBfS0VSTkVMOw0KPiAtCWNvbnN0IGNoYXIgKndoYXQgPSBLRVJOX1dBUk5JTkcgImxl YWtpbmciOw0KPiArCXVpbnQ2NF90IGxlYWtlZCwgZGVmZXJyZWQ7DQo+ICAgDQo+ICAgCWVu dHJ5ID0ga21hbGxvYyhzaXplb2YoKmVudHJ5KSwgZ2ZwKTsNCj4gICAJaWYgKCFwYWdlKSB7 DQo+IEBAIC00MjYsMTIgKzQzNiwyMCBAQA0KPiAgIAkJCWFkZF90aW1lcigmZGVmZXJyZWRf dGltZXIpOw0KPiAgIAkJfQ0KPiAgIAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZ250dGFi X2xpc3RfbG9jaywgZmxhZ3MpOw0KPiAtCQl3aGF0ID0gS0VSTl9ERUJVRyAiZGVmZXJyaW5n IjsNCj4gKwkJZGVmZXJyZWQgPSBhdG9taWM2NF9hZGRfcmV0dXJuKDEsICZkZWZlcnJlZF9j b3VudCk7DQo+ICsJCWxlYWtlZCA9IGF0b21pYzY0X3JlYWQoJmxlYWtlZF9jb3VudCk7DQo+ ICsJCXByX2RlYnVnKCJkZWZlcnJpbmcgZy5lLiAlI3ggKHBmbiAlI2x4KSAodG90YWwgZGVm ZXJyZWQgJWxsdSwgdG90YWwgbGVha2VkICVsbHUpXG4iLA0KPiArCQkJIHJlZiwgcGFnZSA/ IHBhZ2VfdG9fcGZuKHBhZ2UpIDogLTEsIGRlZmVycmVkLCBsZWFrZWQpOw0KPiArCX0gZWxz ZSB7DQo+ICsJCWRlZmVycmVkID0gYXRvbWljNjRfcmVhZCgmZGVmZXJyZWRfY291bnQpOw0K PiArCQlsZWFrZWQgPSBhdG9taWM2NF9hZGRfcmV0dXJuKDEsICZsZWFrZWRfY291bnQpOw0K PiArCQlwcl93YXJuKCJsZWFraW5nIGcuZS4gJSN4IChwZm4gJSNseCkgKHRvdGFsIGRlZmVy cmVkICVsbHUsIHRvdGFsIGxlYWtlZCAlbGx1KVxuIiwNCj4gKwkJCXJlZiwgcGFnZSA/IHBh Z2VfdG9fcGZuKHBhZ2UpIDogLTEsIGRlZmVycmVkLCBsZWFrZWQpOw0KDQpBZ2FpbiwgbWF5 YmUgdXNlIHRoZSByYXRlbGltaXRlZCB2YXJpYW50cyBvZiBwcl9kZWJ1ZygpIGFuZCBwcl93 YXJuKCk/DQoNCj4gICAJfQ0KPiAtCXByaW50aygiJXMgZy5lLiAlI3ggKHBmbiAlI2x4KVxu IiwNCj4gLQkgICAgICAgd2hhdCwgcmVmLCBwYWdlID8gcGFnZV90b19wZm4ocGFnZSkgOiAt MSk7DQo+ICAgfQ0KPiAgIA0KPiArbW9kdWxlX3BhcmFtKGZyZWVfcGVyX2l0ZXJhdGlvbiwg dWludCwgMDYwMCk7DQoNClBsZWFzZSBhZGQgdGhlIHBhcmFtZXRlciB0byBEb2N1bWVudGF0 aW9uL2FkbWluLWd1aWRlL2tlcm5lbC1wYXJhbWV0ZXJzLnR4dA0KDQoNCkp1ZXJnZW4NCg== --------------iH8yr0Lb8F8zxF095ePwpBum Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------iH8yr0Lb8F8zxF095ePwpBum-- --------------WXAnykrIV00daOHG6Z0mg2gk-- --------------YR0M9lrsKJ1khWzPs4cz0bCG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPqAjMFAwAAAAAACgkQsN6d1ii/Ey/x +gf+LnAvmmMI+yqrUxQkC16OHoy628JB3/HVUeD3B80HS7E9z8QAU5DQbtsaNtpWHjhS4DargVmz Nl9zsPNobfmZVWUBukbvu7DI57jSlQ1+GNaZ/EbBJo02KSznfFQMCGMp6sMRq3ymFS4zY+d31sC3 UsmZqQITNfyqUX5YI6zVAyRbKzBRhWBo2m/L8iLAdQj5Xpx6+8ue/vAUIkVCgqwBp4M1191rReBx tOxcL3EJWKlqlHd3cJfOtH3HlcIVsPlSnOQtEd0hMV+ZrCBBQmpKsc+eyhDR41mdoduHj3tHRMCe 7jWlbBcdfFLB3ty/roSEt6jLn3b40ntT5YaLyFoTww== =tTEw -----END PGP SIGNATURE----- --------------YR0M9lrsKJ1khWzPs4cz0bCG-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 09:27:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 09:27:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494290.764323 (Exim 4.92) (envelope-from ) id 1pRV7l-0002zR-BZ; Mon, 13 Feb 2023 09:27:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494290.764323; Mon, 13 Feb 2023 09:27:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRV7l-0002zK-81; Mon, 13 Feb 2023 09:27:49 +0000 Received: by outflank-mailman (input) for mailman id 494290; Mon, 13 Feb 2023 09:27:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRV7k-0002zC-96 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 09:27:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1a::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad1081e1-ab80-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 10:27:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7992.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 09:27:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 09:27:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad1081e1-ab80-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcsgTjeLb/LyqOHXZzFhp6r3UNL1eDzrkHqb9ZoqGEg/45jpS8WJ34qaNkRVNW0XzhJ6+JQxZfWrwSEZUQmjFNeVyD6uHG6RZAu1W2zE/CkPDO7r/EwLD/4xYR/DToaqAM5i4ApIsWQ+PDCrlb63yMn30XhuvQjYfSPvO15zMDtBUxGD44eT6z+0T3lE8QIFUPuNDy93dsIfxlRCZoKEbbUZkdt4CmggTqL6zpo9S6Lvn6CFryS8XfCjhFZ5+Oghw9l9TlmOFdE/OnUl5f+CXLTsvk3ubD9FWqwEIb5E9tjIaGI4zbw+ePNU7GeI/iQ9aYeP4Qcjqt6nHkrRoIbS3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fsBy0nU/hesAsokGG8TGpHf+mFJHlegQmMs09BzikFA=; b=FfG0byRVYX0jN2zc9PtpqbVeQR9QnuN/p3czWQNrHCT3sjZGkq1SMiszEMJ8gNIiLM5ydj4pVUJ14b5d8PdjWxbqnPGKt73yM5Q7Q8ic0b2ZgxDi0PKIZW+z3Gqh2w0q/w2zmtdZ/mR+QXKxaqkZbnYpOm+WRa6zWCg8CcIyM+1qjlp4tMkw7PfFEcQ9i0Qg99ZILGUbfKxZjjgGcg6kU+v7yMzI4tseuLEL0Ok4NKRfD3rfaXj9RuM/DXoPhQtJhS1WjNlu/c/UvTWM8jxY8QXlpE8wBJ6Nj3YMcLmWXbvzNLSNOZPe/o1XhkVitn6h0z7yVMu4yKXo+fFIFN9KYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fsBy0nU/hesAsokGG8TGpHf+mFJHlegQmMs09BzikFA=; b=AG13IfMPes6eGXu0Ogp8AO5Ydh2+LEGvroPWmflPTMudYkDY2i1zaaP1aDaRH0aVWorjqO23dZNG2jCA412yg+Iir5Iwe3L3hbdBA0qfwRHS0J8zfhPk3Ejp5TFEO7WKrwcnEH/AtFmCia99N2jpb0AKrS0SjejUWKFbZac7TbERvmHkX/frE4VmLpwF1JmwDo9PZs19+nwbhCbP7RrIl2OSTLC+guqoFV1rIfQI6wiYtBMTzJLfGAEiVs8k+fUrclm9mu4oej958mrBZ10lZ56u6iGmv1jtH94lus9aMCpgIc/tYsMRbulcHQIJAX3Kg9427hpGtG+aUVFuhxKtPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <34dd6673-a8b2-977c-adfd-928418cb5435@suse.com> Date: Mon, 13 Feb 2023 10:27:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 0/6] xen/x86: Use SPDX (take 1) Content-Language: en-US To: Julien Grall Cc: demi@invisiblethingslab.com, Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , xen-devel@lists.xenproject.org References: <20230209230020.52695-1-julien@xen.org> From: Jan Beulich In-Reply-To: <20230209230020.52695-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0091.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7992:EE_ X-MS-Office365-Filtering-Correlation-Id: fcb8b747-21cb-47c8-205e-08db0da49029 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDCw6BxnnxC3kJJT3gwN+jITBOHG2Fp16Q3NDEVoSpyqeZVAp6Zm+izg6yq5z44AyZQZaQ7dcAL6036MmMBGLicGgbPb1NZMamdtAN8tQM4OStu5s/ibjhzr/B8gXvoAFTWzzPiM9kEEE4AEO+Q1caPmQsd+VNDyjMGkHvP8MdkZxqpJb89He9TbTiTAzh20eIa9xDJzJI2WY4V1oSQMYdMU+O9aaoJlToj5PhFFdac9FK85iMhoJlpZ6liN3PiChxV7RNdIy1O1Qh+fuym840lrvsDS/BJPFAE916I5Q8KCUR0CUYNBZ1PhiYBXJKGH7+2BhMjyOnumjp8tH7AfiB/+LccpcCOW0LAz9l9TJl6QF3uFh+z39Rmwb4wnrJ6yObxW83ao2eOd3T57lcmrZuYhkHXedvbPtVoBidT8DNye4wTHlOO3yGfaiErCa6/xGjqA+R5s0STDVi6uwA7biqcsSU0mqQQZ9TDLZTE6wuT9exFRNkjb1L1tCbsZpt6Sj0XlL93+e/bSuSQwHctCS5oiWswvFOiuE7iLpjfB5D1iNlGi/CTC/CDcUredzf9Rpvt/Sv/lviPvd6l5EntgKVU+pOJSmTosialuzmP4hXGmM1o2n9/HAjiDGxFwyCTbpkWOy7USGVfx8DA1G67xuZ08WwqMfaKRzIu5qlj9ET3IdUnEM48M7zJA/2EB+nY1x9qUuKacTdLVXaxQLEHawT4qf+dWKTmE5SH5Yrwk4d0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(376002)(396003)(39860400002)(136003)(451199018)(41300700001)(8676002)(4326008)(6916009)(66946007)(66556008)(66476007)(38100700002)(2906002)(31696002)(86362001)(36756003)(7416002)(5660300002)(8936002)(31686004)(2616005)(478600001)(6486002)(6512007)(186003)(26005)(316002)(6506007)(54906003)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a09LMlcrcDVGMkNLNThqTW4xRkNtQVFLdnZBRmkxU2FQMDk1YWFtMTlhYTNy?= =?utf-8?B?WWM1YlVpS0RQbjN2Z1VrMUx2V2dWd2dHOHg4VTMxMm1xZjFUZEh2eUlQN2dW?= =?utf-8?B?MmJWbjR6MDlPUnM4UUdUU3pLZ1FkeTZpdlhTdGFMWndZemN3NDhWMmxhR0RW?= =?utf-8?B?K2c3b05ybXNQaXdrTm1IUE9DMXNBeW5vblYzMGpjdG5TZkN3blZSV1V4bTFI?= =?utf-8?B?WnZYRUxuWEYxT0VVTVdmK3B2bHg1dWJGZmdyZWNlSXJUYjZCa3MwajJyZnpC?= =?utf-8?B?VUMxWm9vWUpSRmt5NDIvaCsrUkhMSWJtMnJzN2RESlh3K05rNEJicmoyMmZn?= =?utf-8?B?allHalEzaG8rZGZyOFhFNUlKVThmSWZ1T0hBRmJoUzUzSktFVVh6bFowb2VM?= =?utf-8?B?NEtaTzExTVBTNzk5SEJXa2hLOUpJQ0kzc1lneUpNVFNnYWM4VXo2SW8yMFJC?= =?utf-8?B?d1dVYU9Xd0RQSlZyVWFselVQNGw4akJPMW5wcmMyOEM4b0x3REVsMWxlNW5p?= =?utf-8?B?WjJaeG42OFplZUhqSk1tT3JBMFhTYlNRUDlzVkVqNktKK3lwL0Y2NGVGZEpH?= =?utf-8?B?UTF4aG5IRmpGd1paMk9lQWF4QnZWSUZzUWtJY2hCNUR6YXN3WVZkSmZmWFZu?= =?utf-8?B?OXI3eGphOWlnbXVIK0o5NkhlVEMvZkxRYTRRWURsZnlBNlZFTElQNlZZRE1V?= =?utf-8?B?cXlDQkxSR3FWWVhkZTF1T3NQVlEzUFRnbnQ1Qmp1a3FBTHdYUzdHNG1mU2FU?= =?utf-8?B?bEFjS3ZkTnAxY2JkNWJsRTlNUEJNb0puYldFTVN6YmQvNmNDcDB3ZXlQQlR1?= =?utf-8?B?TWU3VW1pcE0vcXJiQ0lmVlNDZ1h0VE1NaG44YWhxa1NmeWNtV2hxVVdKRkw1?= =?utf-8?B?VkQyQVZuSXYwWHNVMWR4Sm1yVkhlSXpXcmZzMi9LLzFiSXEvNGEwWXBHQjlE?= =?utf-8?B?Y25reVJEYVdGUUR0c1o3R3dmcURZYUwrV2VoQU4xdEZjb0lSRG1BaHdSd1NV?= =?utf-8?B?VGVUbm90WmJNbDFVWlB2bGdtL0Z0WXQ1SUNMVW9MTU0xNXlZL2ZaVFNXTHI4?= =?utf-8?B?TGY4OGsvbXFpakV4d3dmd2xwckMrNVdTS1RxZzZ2aTVZa09lS3VJSnAxMDNh?= =?utf-8?B?M3ZvZi9lb1pTVm9LQVg1a2JFUG9FOGc1QTBsRE5UQkZIMlRLY1BHSmhtOEFU?= =?utf-8?B?anBvekxlSmhiZGVXMnpTWlJlZWVWemRyUVRoS2xnWWdqUHBicU1YRHdJUHp1?= =?utf-8?B?WFc0TUttQ2R3ZzVrTHFWaFJidmlvQklacXlDSVNhdUQ3UXREWWRESGZnUXZP?= =?utf-8?B?WlBiamdmY3RtLzZnVC9peHBQT1V4OGVoQ3g0bE52SnloM0JvdXZMWXhkQ0Qv?= =?utf-8?B?Ymt2WG9pNWhMb3lBZ1dIdTBJemlYWUJES1kxWWFMWjN0ZUx3dThXb1NmaFZV?= =?utf-8?B?a2xNaFhRZUFlN3hKd1BGbk55eEdJQzJINFhxSmNubmowTlh1Vkl0NHZTWGI5?= =?utf-8?B?Mmw0RVFSVVJxSFY0d3dQMWY1OG5HSE1UbkpOUG9TM0xuaGRBdUI2T2YxMUhM?= =?utf-8?B?UVlGTUdnbWJ6c045b0k3dGRwbzB3ZGZ4WG9iNXlLVzRjdGJMZkhhSW9TNVZv?= =?utf-8?B?RG8rbDdrRTU4VWViWU1GaWZvN01LNTBJWDBhMXQrdDk0WmtBdldleENaVGZt?= =?utf-8?B?OTlQMVJmM2VvZ2k0bmdkQ245MURVNjVqbUUySS9tTFVQOVRpS0FDeG16RldZ?= =?utf-8?B?WjIrb0xTeFg5UDkwVmFOM0o3YlQyNUxpZklsV0JLbGdWaExoVVBUd3hSRWgw?= =?utf-8?B?dlJmMFpCbHhQOHFFcUNqd21kdDJ6WFgrYnNteVNtWVhHM05qN2xnOWlCWTh1?= =?utf-8?B?NDNRM0VSZ1orV1NUT213TzZ1c2Zmc0U3Q2hWWExEMEtjZm5Jd1BuUDZxdjQ3?= =?utf-8?B?OE5OR2hSbzJUMWgvK1FicHlpNFdLT1BQSHVObjhVak02cWRydE9yby9UMDFu?= =?utf-8?B?eVBJbDUwajFNWXZFUFhmSW9NR29XaEl1Z0xzcjJ4NmU1Qjh1SWdReXF1alo3?= =?utf-8?B?TFJVTFVESktaNm9uOGRGakkwOW1sRWRoMUQzT0JiMWJxdVo3dzJJY01aL2Vj?= =?utf-8?Q?Zb9cFowdLxZAGSOFcYO3cBEtk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcb8b747-21cb-47c8-205e-08db0da49029 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 09:27:44.9344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P1wD5yeoofkmtDlV3QUPsOmE5QHAnmrQr4Mz7Iveb3n9h2Vl/vhqRdaOSnRMp71AHruMx8rlujuvxPQV4shJ/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7992 On 10.02.2023 00:00, Julien Grall wrote: > This is a first attempt to replace all the full license text with > SPX tag in xen/arch/x86/. For now, this is only covering files with GPL 2.0 > and 3 different patterns. For clarification - the three patterns mentioned here are the three slightly differently formatted/spelled versions of effectively the same text, not ... > I have used the script below to remove the full license and add > an SPDX tag. The script is based on the work from Anthony [1] > > 42sh> cat replace_license.py > #! /usr/bin/python3 > ## We are opening/writing to files using the binary mode to avoid > ## python interpreting the content (reading ./drivers/video/font_8x14.c > ## will throw some encoding error otherwise). > > import sys > > if len(sys.argv) < 4: > print("./replace_license [debug]") > exit(1) > > licence_file = sys.argv[1] > spdx = str.encode(sys.argv[2]) > file = sys.argv[3] > # HACK: enable debug if there is a 4th argument > debug = len(sys.argv) == 5 > > with open(licence_file, 'rb') as f: > licence = f.read() > > licence_spdx = b"/* SPDX-License-Identifier: " + spdx + b" */\n" > > print(f"reading {file}") > with open(file, 'rb') as f: > whole_file = f.read() > > try: > licence_loc = whole_file.index(licence) > except ValueError: > print("licence not found. Ignoring") > exit(0) > > # Replace one the below pattern with nothing > ## Pattern 1 > # * > # * > whole_file = whole_file.replace(licence + b' *\n', b'') > > ## Pattern 2 > # * > # * > whole_file = whole_file.replace(b' *\n' + licence, b'') > > ## Pattern 3 > # /* > # * > # */ > whole_file = whole_file.replace(b'/*\n' + licence + b' */\n', b'') > > ## Pattern 4 > # * > # * > whole_file = whole_file.replace(b' * \n' + licence, b'') ... referring to the (really four) patterns here? > Julien Grall (6): > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 2) > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 3) > xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 3) With the one further adjustment you did spot yourself: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 09:52:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 09:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494304.764334 (Exim 4.92) (envelope-from ) id 1pRVVe-0006k9-BI; Mon, 13 Feb 2023 09:52:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494304.764334; Mon, 13 Feb 2023 09:52:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVVe-0006k2-84; Mon, 13 Feb 2023 09:52:30 +0000 Received: by outflank-mailman (input) for mailman id 494304; Mon, 13 Feb 2023 09:52:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVVc-0006jn-PF; Mon, 13 Feb 2023 09:52:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVVc-0001OI-Ml; Mon, 13 Feb 2023 09:52:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVVc-0002Ew-AJ; Mon, 13 Feb 2023 09:52:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRVVc-000297-9t; Mon, 13 Feb 2023 09:52:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HtAYmzsZXm16o8O8PM6OGK1Ucd9dwKtG8i0DaMoK0cw=; b=HRhyf/DH1kx6bp/fOHdrgU8gM7 hfmBo2/MSCMLg7DMheOXNeVhSByNo8tbGWsWET1u8+YlBvfS8l3nzeJIXyBToQp1hVMyXkQ5AQyhZ jMsVnOccDn/U4gOke6ZKdn/fdGHFMBndZ5mm2vJ9dj7GvkBYnfosYwOXUPGsa117CkJ4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177125: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 X-Osstest-Versions-That: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 From: osstest service owner Date: Mon, 13 Feb 2023 09:52:28 +0000 flight 177125 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177125/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 177001 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177049 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177049 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177049 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177049 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177049 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177049 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177049 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177049 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177049 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 baseline version: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Last test of basis 177125 2023-02-13 01:53:31 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Feb 13 10:09:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 10:09:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494318.764344 (Exim 4.92) (envelope-from ) id 1pRVll-0000bX-PV; Mon, 13 Feb 2023 10:09:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494318.764344; Mon, 13 Feb 2023 10:09:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVll-0000bQ-Mu; Mon, 13 Feb 2023 10:09:09 +0000 Received: by outflank-mailman (input) for mailman id 494318; Mon, 13 Feb 2023 10:09:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRVlk-0000bG-L7 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 10:09:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7d00::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 738bdb08-ab86-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 11:09:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9421.eurprd04.prod.outlook.com (2603:10a6:102:2b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Mon, 13 Feb 2023 10:09:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 10:09:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 738bdb08-ab86-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/a2AWRl+hY5z1tdTt+5EPY2jIzUizdIZJaoyGzFWF02RxNiThOlc1AD8RwsEHjchjDA4md6tAjiC9ihvjK0pzr7tyHmle4o9GY0IR8oK6x7VDrw6rWB9LtwILo+UFelb41v2z4WEm/kXyHxwgFtvTADzjTVlUGu1PTKuo5d3xzFxyrSAroZE6Yw4Og+bAA5+1NKYDxKmRD7lYdrwgV4IyMm79vmUp4TkRcipXbqQcXVBmJNTzlEvHwG+ZIVBQ2vBXB8g435cDiZ/srMV4yLpU5oK0NaZFtit170PZnxGf0zj62nrixBWGO6UCpn5+O/v0h+oNgLXC6DECgPMW8cxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bs32FRsoUzDxNmNs6gGvFykdxxo0Z0MipiufvwNIX1I=; b=mwzWrIi0myOpbqpl4nbSav0tfWzC9c6bisSLjDvdoE9qNbbFnz/o4EGwfliuPsOfWobl/DRjxHaHfdkWMpne5Yoh6jmy1HWLGVE7JHIH/GscWOfrg6U8MnH9qip20Lvb6pP945rWOeiuxG1zbt6JC74eUhvgctJlj9Ph0TwXBnx8BGGHz7Utba3iZlKJgjE95WvZjHKFPLdJPbhLLg7VWAsIs2av8jiIr9TYd1uEW80LNDx2A8Hw92xyir0RRZvZA/GRI73nmy7K5uoE7pu2N6XeA8/ag+dcJ9oPIdICpsA/vK6vFZZB6GTi9a/KXvBTUJ47+K+cffz+6y8UtWzWbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bs32FRsoUzDxNmNs6gGvFykdxxo0Z0MipiufvwNIX1I=; b=reusc92x5+4k5mkqUAQQ75ve3/E7bmDOph09isCmVB6VU3bM5dd+BYhsoUEXnQo2NMLa3OUyPffl0Sdi6k0M6PUC+22bOIoG/fsdJUY0cVXU03dVhPfWl8XWTtljfcGmAFw5lj8rmgkEEWBYh6ygcs60NG5Xu1Yt26xyZhxcHEUmFeHr3JvhmwceTEwaoQOGYTc44fUAy5zWZpheRwB7phvzruS0skYFrEPnlgwNtzhEcWibn43VpODt/NjxvI/uPwHuJYUd7H9zmi5W+fkUisPaSUOhqYHgEunGmOFuYdV6hyJMLme38MwNoL9Z47zeXz8dvsXVh9Q68DQeTbDeoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 11:09:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230207094347.1059376-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230207094347.1059376-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9421:EE_ X-MS-Office365-Filtering-Correlation-Id: 916b0484-46e3-4900-4928-08db0daa5605 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eSd+QxlkOOzfUwu0hrOE2+4PgB1Efp9zlhDxFjRHgXzs7F4lawiq4/ZZUR6ZRnlnbGRLRUKvA8snkF3EIP2jIGOpmQUl6yaiWpJ5w8zTBVoUhF+P45htAs4EJWbwbyNVxJIrN+qI2wQRrO2+NNNxvtnXU/t4gJfDn7OHhhGVnTcMpTFvtOICJ+zBc7ujs9oHCcIxOnX01eNX59WVm/OnvHeX+wDUsaeFlyoCqMyD5j2bVekxuALw7YQMUO4qLN21i6OUOMD0zHD0OYw+2vQcW0mK+w2WxDNOpLcSe/bAfxl5wzx4M6TJg+icEEkjzmRDjmJ0xsOOc54jycnyl+8xcQElug03Xk2NTGINbWJdIBsRCuFe0QtMhCPjqvmpDXxfY6LLlLXwbRkUIjo3djy4TUlCV2cqbNzdlgm21qnyNx9FbWMX7BAkebj8alGdyqLkhyowzM8lACsOViWzLCGIzpGmNpowaut7D6TyAi72l7ICYgrCTUAS3AneZrw/Bz9i2MTCKUGlldDXLdCxdj1uvyr2S3Om0Xq3KiZWq4dpHCSVG4q2y8ZzCK0CEyr4H2lJicI/JUs4lYeFg7/2likR8XvX6MXnUPmX52xyZP7YNprUGjZaNE+xdVuPbHLXqIEE+3U5mzSVnBOJENC88myOACVILavP+d4/B4u0P2AWW7NWkwvQROTK7inmAx2vHb8mXeJDMFsCgQoRyd2u6UyUtD2acdzqEYr7Opu8BDvas/4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199018)(31686004)(31696002)(83380400001)(36756003)(2906002)(186003)(6916009)(6506007)(53546011)(86362001)(8676002)(478600001)(41300700001)(8936002)(2616005)(6486002)(4326008)(6512007)(5660300002)(38100700002)(26005)(66946007)(66476007)(66556008)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFWME15R0t0V0NBQWVwNlhGejVTU1NVN00zTTdjcWVQL0NWQ0UvL25mblVy?= =?utf-8?B?ZkdxUDFvOE02aTFpVHNETTBLcElHam5PSVBYUlNlbnVIYjRod1FTaFRGSW1N?= =?utf-8?B?VXIrZ2x0N2E2Y2tkOGFSSm9tV3hHZndVajNLQi8yK1gxWW5yMzl4UmdUZ1BG?= =?utf-8?B?SGt0Rjk1UG1DNmhKSnFGN3ZZb0pPdFdqT2EyZlZDY2VKUlhGdVR1RzFjWWcr?= =?utf-8?B?V29JVlVHVzFBN0YyN3FVVmI1VFhSdnlaMEQwdUlJM2htQ2RlQktqcnB4aytC?= =?utf-8?B?UG9wMkVrN3doZlFZRnBkTGZlbGRUbHpSaEVLT01meWdRQWtJQ1g5NXJJZUNJ?= =?utf-8?B?OWFUc04rc1ltNHZTMGord3NVMXo2S3FERy9RditudFFBSGM1ekVoekJYajlh?= =?utf-8?B?SzRDbkU3MGpDdTZrS0sreVVLSkdlMkViTlV2Ni9lL1JOQU1DaytCRi8rTmJZ?= =?utf-8?B?NXU5a0dOOTRyZmxKT3RXd1BjcVh3cE95K3RNbDFjbnFYOW9jeE1SeUpFYzFi?= =?utf-8?B?ZU9VWXB5a0dkZHdpellWbmdTczdyZEJsTE5rb0FseDRFSTJ4RDlnMmdVb1da?= =?utf-8?B?anpWZytMdUU1d09oY0J2L2F1K0ZjNFNRL0M3Rk9xcDU5cnpSYXI0K3owOERm?= =?utf-8?B?V1VBNjB3SCtoZEVMSnlHVE5SbWQxc1V5MDZKV2ZWOHZEZGtvN1BNZjNxbXBH?= =?utf-8?B?dS9Qdm82TVl3eFFOZi9LalFjZDJnVW1XY1Y5bnJRYlhONlVCOGJKSzM2dy9D?= =?utf-8?B?eUFSdXd1T09KTndLUHpTbHljZExTaWswc0NRK2d5QmRnUFFocXUrdVRvTi8x?= =?utf-8?B?MkNEYmN5eit6SThiaHdEK2JrU29FakFOeHU2N3NVVmtnVnNCdXUwSU1rMzZI?= =?utf-8?B?YW02dEFmZmY1TVJYTlc3NWFXWDlhRzhPMUFZK0dLRUN6VTZlWURsam16ejFX?= =?utf-8?B?TUR3MUFDVWlZNGgvZW5Eanc3WXdYYVR5eVEzVm9xUVdvMEJaSHB6TVAwbTJO?= =?utf-8?B?clhkM2d2SkxGQWZUQlJmUkg5V3E4QkJuRVZzdEUwb3YxV1VwaUN5aFBFcHFu?= =?utf-8?B?ZU9tRkJ2Y2ZzaG8rbmYyb3FNWjhPRXQ4d2NseFZKdVdXdXZVMFgvL2lMVzlG?= =?utf-8?B?SmEzVlhxdy92T1MxcjUyUiswenhZQnBZS3hJS1Y3b0tuMnl0VDZyUE1FRFlW?= =?utf-8?B?R2JSVktOK2xEQjBUYnQwMyswK3I1c1ZVSWFRd0p0bk9XUkVMWUN4SGVIbWow?= =?utf-8?B?ajhZL0I4NnZwelphWjdTOGFRRlhiUU13aDJrNTBpRGpqK2NLQzhwZ2QwZmNz?= =?utf-8?B?K1loazdFMXpXUTdrdnVVUmxhVXlKRFZucFh5ZitkTEI3Q2t6R1NPa0x4QXY1?= =?utf-8?B?YkZWc3hJTngzY0RZTmRBL09SeG4wa3hRK3ZQeUxJbGpQS3NhKy91TDVrbWpw?= =?utf-8?B?Zm52SFNGT1lDZmZaR1Q0aWpzNllIRVJ6aTlCbWg4clZwTXcrNDB4RlVzSHZ4?= =?utf-8?B?cnlpZTdKL0l2a214Y0pTVjJoY0QwV1BMWFFQRnZpWXlaTDQyY05YeFlVQ1lK?= =?utf-8?B?Tmc4R2xMYWdrNlVrYkx6YURKdU8vOEFPbUVYbWg4M3ZkTFgvdytoc0hXWS9u?= =?utf-8?B?bzBNcmM5MmtlK05hVTFQeEZBaFl4cUVKVjZNVktjZm9CdmtHVHByYWVmcXJv?= =?utf-8?B?d3pzR1ZoV3dFcm9POXBBYmZNN0hSSEROZ2hDOFo4bmJqTmhVR1o3K0FWQzJQ?= =?utf-8?B?S01GOVFLc3BxalpOSEJxRWI4eVZkdkd4dU1NYSsxMnlTd2ZFWE05NWlDU0lQ?= =?utf-8?B?U05jT2hUNCtLS0lDRDdFNFFTQ0ZUa1p5SE9hUUJOWGc1UWNhTEo4SENKTURu?= =?utf-8?B?V1J6cFRhZWRDR3VteEhNSStCUm93ZWxXekNndzhRSHRycUtjVVR2YnlldmtP?= =?utf-8?B?QnVCNnpuQXh2SmJTOTdIWjZveHNDdEhsRDZsampOdkExMmtieVc0dENRdVRu?= =?utf-8?B?Z21JL1BKZmJOQTdMVzhoSkVmWFp1d0hBWW9FOGM1VUhXdHZOdTcydi9WNEx2?= =?utf-8?B?Zi82bzFmT29vdmFRT0NMLzdRWTRCWW1UdzNXZmMyNHp5UlR2blZVUVlpZ1BI?= =?utf-8?Q?UZxOiPXqdmHoQzGmlkqMumMEb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 916b0484-46e3-4900-4928-08db0daa5605 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 10:09:04.3095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sbfYgNw5X8M8ivVtIUT+Prihw41ASlF6EXDyulvdoxrNUzraiOHbczVCegYP29D8ALjwe+8GG3aBLKjNwb7MyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9421 On 07.02.2023 10:43, Xenia Ragiadakou wrote: > APIC virtualization support is currently implemented only for Intel VT-x. > To aid future work on separating AMD-V from Intel VT-x code, instead of > calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub > to the hvm_function_table, named update_vlapic_mode, and create a wrapper > function, called hvm_update_vlapic_mode(), to be used by common hvm code. > > After the change above, do not include header asm/hvm/vmx/vmx.h as it is > not required anymore and resolve subsequent build errors for implicit > declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including > missing asm/hvm/trace.h header. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou > --- > > Changes in v2: > - rename set_virtual_apic_mode to update_vlapic_mode, suggested by Andrew > - in hvm_update_vlapic_mode(), call the stub only if available, otherwise > a BUG() will be triggered every time an svm guest writes the APIC_BASE MSR, > bug reported by Andrew > - initialize the stub for vmx unconditionally to maintain current behavior > since no functional change is intended, bug reported by Andrew (here, I > decided to place the initialization in start_vmx to be closer to the > initializations of the other stubs that are relevant to apic virtualization) I disagree with this - unconditional hooks are better put in place right in vmx_function_table's initializer. Also now that you use the function as a callback, vmx_vlapic_msr_changed() will need to have cf_check added (on both declaration and definition, albeit I keep forgetting why putting it on just the declaration isn't sufficient; I guess a short comment to that effect next to cf_check's definition in compiler.h would help). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 10:37:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 10:37:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494326.764355 (Exim 4.92) (envelope-from ) id 1pRWCf-000493-Sm; Mon, 13 Feb 2023 10:36:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494326.764355; Mon, 13 Feb 2023 10:36:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWCf-00048w-Q8; Mon, 13 Feb 2023 10:36:57 +0000 Received: by outflank-mailman (input) for mailman id 494326; Mon, 13 Feb 2023 10:36:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWCd-00048n-Oi for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 10:36:55 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20621.outbound.protection.outlook.com [2a01:111:f400:fe1a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54d0f62c-ab8a-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 11:36:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9661.eurprd04.prod.outlook.com (2603:10a6:102:273::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Mon, 13 Feb 2023 10:36:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 10:36:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54d0f62c-ab8a-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8waFm7G5vi0Vchv92s5N8fA7Ba1uAs34GJIdgs0PEfAQ7SFyTDK2VNjLTmHuriy277s6ZzKN5SvyojyZsoj+cmQY6ZjfEbTGPqycOE7+0cXn2v/d0t0dt17bME349gue/azDjUmjB59HLGOuGM6itcF+CbGf4AKpvH3d5g8a6TuJzGABt6Ti3fbKv9NXhDd0mp91V0U3qZmdxfGs9xng3YR2ZFhhKMw41ngHqLR0qMMpKO8lZ9mStF46KBpIxqSjnqfQee9g8YzGJwEG1HH9MHEy1cFVvih5tkBbUXD2Gs+oVaAYtTWcaMIpwIiuA5tofkaMGdJ5F45XDxoaULQ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4RMIeqTjoRmBwaSw/PmaJGTkdAMy1hi125x9Fuvw9MA=; b=J1xsPPJAZ/9pgqU9H4VBa/3iJ/Fg9SqbdgoqxEVnUVhFQzzTaJ5PQpEzubGPlNVrk29eRA3YXh6muaUl2y2p5Nz0eDy6KkDwVvcSwmSY9+TPhG80o6zeVtopr12GUImbMs7Q64jSDsSZUxCJ+UjjBWLSJ8jklB0dju5VwXVjUiqrMsAKk6PfqJ+DxaPjvwdhQHLFyl7Y6Y6Hee5anIQ1ma2KXBaENGXgeHJLW8hoJibDLOQLMcNvF1Ph5d1DG0kWHYk5Z7/DDHy/k4o8vjzqXjk+ETN9D8iELyAjtBf+uV3uD+MMyIZrfJtFOpT+c7d6ix+3p9cFo/Q5XF9smjuWFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4RMIeqTjoRmBwaSw/PmaJGTkdAMy1hi125x9Fuvw9MA=; b=ahRRFm4qE+zDVapAE/4bsvUunN+PwXj8uyoEFsSy0exoNWb60CsRd7aVkKL43//Jl37H0/EohMo0XwfViuut4aWrG8F42MvVK6wJN7CTHjC++js+rfYb+43DfLduacZyZk2Ekfh+gc2BCXjKp97DZzBlJ+/51z6kKlFvaF2bxXn2VOak605hfdpXaBSM2zSBZzV0mbwmCZwpWsaUB/2cgcUGHVHt9BiDxB2tBh/lWkXejLNbQk86WA4dvwqIpZjd2Ag6Wb4sjHH0Pwo4VDyEb+YE7lEuMoYm3KPotK3EBqP5MqRdrBW2YgHWHy6l9l4tyCC8/3nl9/89YUUhBt/XuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50dc066d-885d-ea3c-ab30-0e045a330250@suse.com> Date: Mon, 13 Feb 2023 11:36:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3] x86/ucode/AMD: apply the patch early on every logical thread Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230130115503.19941-1-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230130115503.19941-1-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9661:EE_ X-MS-Office365-Filtering-Correlation-Id: 69f4e9d1-0cfc-4a7a-da51-08db0dae3782 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7QaEtc0XFH16SZujMBLaP9yHAzjEwJxwKYKNz8+jBNbN8fizRlbCRu0Z6YsrIxXCH06D7DfAPgOo3eMKGQqCDcL6TdhPJSBHCZL2nCJNJKPSYD25jxQij//2Ecf8rg5g3DGUTj5WVjudByAdwUUIk2sk0UCvHgY8MhBhDbcbi6V8wM25fwvndTFDw80grcuKpfP99SXLzsmQOHbREpXMcS1nHilOUqN6u+UTOwPKCvJ1Pq+uDVPicX+HAvDVdqZkmP1H07XadonBK8nUf7PKqL6Nd/dFAVVNpt0g3l0/2jSIOgIFTa2zmgu+Q1r2gplPE5Flr6BoZKpe7Gx4uduXqvjKh0g5PlzauSihlKNf5uGWFEmUePonEXTpo8F2D3DE9vmaQhtj/itupn5u6XQ2TEPFVEYOnF2DKg8EGJHvpJWB8+tFw6lgX/eak1j3FiiRXhTBTjZQhAe8ygX/TR/UO18fH80UK8nAKz08bPSbycrHdKIOz7rH6+wzsq863XFc3CYriE89DaFSz8MJdKRMVv3uU9qCrWFvqaQygehf/MhYunQe3b9x1qVBown/FIedwQtsbViSIXrbt8kbeQ7UwmUTM7fOBWOnVOpH2PkYz9fVVqA7z+6SMf4lCxYE/v5nPCqF17Tg11zJ1xYigd2RSVab9BqsCFcAJKG1WfgB7I37AnZ6/TiyT3QZjA0W8csLUKQIutKBKyBVxm3DfpHb3sp9zCcJD6JfqsPQ6abEOnY+vidJ+LeP25O9WmNJ1Ok9apkF3HzctKXV6s+czHxHFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(39860400002)(346002)(366004)(376002)(451199018)(478600001)(186003)(83380400001)(86362001)(4326008)(38100700002)(31696002)(2616005)(8676002)(6916009)(66556008)(66946007)(66476007)(2906002)(6512007)(41300700001)(26005)(8936002)(6506007)(36756003)(54906003)(31686004)(5660300002)(316002)(53546011)(6486002)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akxJY004TjZUK0FkaWtMQk1GcE4wdE41YUtiUERTOHRuN0VHMVNmR3pUbC9x?= =?utf-8?B?dGlRbVhZVnZOa291UUM2Y29EWTgxWDRYZUE4dlNLRGRlWWxUUFlQNVdhMVpz?= =?utf-8?B?R2I3a0hiZWtYSWZkVFBuS2hQSENIcmFudnE0dXB1UEx5cjRFRHBDbzgrRkcz?= =?utf-8?B?SWVRcmg4THh2ZzlCSVRnQmVCS01naTJScXMwVW9XZVcxaTNsSDMyK0kwaDJm?= =?utf-8?B?dlFjR3FKU2U0ZDd4UXJtaFJpSnFzSnhjZ0lhSTFKUHFHNlRxSVQwemtUTTdy?= =?utf-8?B?THRseWlrc0VvK2djUjBHNFJQN2h5UE10V1hLUitxdEJvOHpwc1luNExoY1JT?= =?utf-8?B?bTZMdHV1V05BZmNYN1c1V3V0UlhhOHFvYkNBQ05qRFFjelh4Uy9GdVkrS281?= =?utf-8?B?TFVJUmpPWGRCWU5XdHA0UkFBenRkTzV1c1RkSTVCMXhXWk9oN3lpeEcvcmpr?= =?utf-8?B?MVFZM2xOQXJ3SCtuZXM0TlY1MWZzUGZQd3JJK1dxSWFpQ3dnUUgrRGxPckw4?= =?utf-8?B?N3EweHBFSCs1c0tjTW9hcGJYWHNlVHFoV1o2ejJ1eEk1NmdlK0FNbnpCZzZW?= =?utf-8?B?K05Sc1NzMFpGT3k5QjdTR1RDVC9Hd2dxdXZ5Y3dmRXFNVUlRUjYydDJHVGJW?= =?utf-8?B?b2xJd1NnakR6bWNHTnBzYlhzZi9nUmtDMk0rZGc0VmRmTHRPQ0ZqQ0lJUmYv?= =?utf-8?B?MjFvNUk1ZDhVQWVSdUx5ZC9Fck9XakRFQWRUcThiSXo4dUJQa3VEWjA3S1dh?= =?utf-8?B?V2xxM3BtYWs1dlFLMHViQkRxWHNtYnJZTmpFMU5XL1JRb0JWUEJsUHY1dWRo?= =?utf-8?B?MFFNRkRza3Z0N3FMcVZvc0REUFNJK3l0NzRINTdaUkNzbjlUQ2h0VmhYTGxh?= =?utf-8?B?eTlwN1Q2dlptQzd0ZjlYSXZpcGpjRU41WXZjNVNXSENiU3l0WW1jU09rMjhP?= =?utf-8?B?amZqQ2E2cFVxUTcvYUtnMTI3RGlwdVNSODJqcDgrcVlianN0ODN3T0dVQUVo?= =?utf-8?B?TDBXU0dWMTN1dGxTbzU5WlVVTXpLWlErc2VkSXk2bFh4VTZlMEFtYnhyTXNU?= =?utf-8?B?YTlJM1J2dHFlK0dQM2gvdHpicEJnMmNMSjFYajgyU2gxRzl2ekczcStxZDB4?= =?utf-8?B?R3ZTd1krQjJud2RDV2ZybDRtdzVpbmk2S2J5NlY0WkFORFVFNWFzTXZMZXdC?= =?utf-8?B?RllSTmRPeERsWkJ6Q0NWZ0phTEZXaWhBaGZwaGV5a25MSm5SWm42MVkybTBC?= =?utf-8?B?RjdrWm9mS3NITEFpaFJUT0tCa2EyMUZGK3NCc3ltZU4rbmhOYnd2bUk3ZFM5?= =?utf-8?B?ejgzcDZhWjdYU01NZVk3d093a2dOZUdGZzBURkg2SlBtQndzQmllRWxWZDd5?= =?utf-8?B?a0gzaUFsQUNmRWR3VFlLN1l0TWlIZTdXTTdtdjZPTFp6MjJ3QmRKallJbjlL?= =?utf-8?B?M1RJRnRBaC9uem1nQkhOSzJES3V4QXIwbzRET1hPd0NOYnlXZExGMHVMWGtZ?= =?utf-8?B?dE8zRm0yM0ZYcFNFVUZZUlBqMDdPb1ZnVFExOTRraDd5elF2YU5sWENKcXBK?= =?utf-8?B?QXZFWjZlbE0xSGhZOFVaNkRUeVZNb0lhbC91VGlDc2c5bWM1VmZ3NVA4M1Bk?= =?utf-8?B?RUU2YXpaMU9MVTZIYWhOalNTYTBoZmUwZmdrVm5iblF1Yk5FQURhUkRqRVhQ?= =?utf-8?B?K2hpMyttNC8wNWViNXdpU0xNS3VOcHRSUGJuOFZQY003VmROd25mckU4ZGt0?= =?utf-8?B?T2FVbloxZURoZklDZzMrWWt5cmhKSWNlWFg5aWZ3TkN6aXRDNWp0eFVxVGl3?= =?utf-8?B?OUpYWDRpRjNkTlN4RDY5U3RrWEZhdFg2UFFuOVdHRC9GeVNoZ0hSNzdLTm9q?= =?utf-8?B?dnZsbDlscmkwZVUvTC9oZlVBWFVkZ2NIdHpqK3lyQzZDNnB2MUpjMXdVTmtY?= =?utf-8?B?SlNFdUVPVzJkTmdZNmNqMjNaYUpyZCtPU0ovQ054RXlpbExQRDRodysydE9o?= =?utf-8?B?WGpIOEIrbXFVSWxMNUNHTVNVREZLaXNZUFV2cGQzaFNaMlhVNkVicWhQcEpO?= =?utf-8?B?UjFvbjJ1QjR3eTNtTXJadnlkd254ZVpOWGp3d2l6ajExWndhMkY5ZkZ3dUYv?= =?utf-8?Q?s0ejrVRYFVsClUJc59jzaOQ1r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69f4e9d1-0cfc-4a7a-da51-08db0dae3782 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 10:36:51.1100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r87MZqMw4BGmDYO5ubGC+mpx0eOSSCjU4LgHIDdgnX0cxyeoV3DO2uSiqfdO4NX9ayn/4hGrFU4x/vDkYPVfDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9661 On 30.01.2023 12:55, Sergey Dyasli wrote: > The original issue has been reported on AMD Bulldozer-based CPUs where > ucode loading loses the LWP feature bit in order to gain the IBPB bit. > LWP disabling is per-SMT/CMT core modification and needs to happen on > each sibling thread despite the shared microcode engine. Otherwise, > logical CPUs will end up with different cpuid capabilities. > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216211 > > Guests running under Xen happen to be not affected because of levelling > logic for the feature masking/override MSRs which causes the LWP bit to > fall out and hides the issue. The latest recommendation from AMD, after > discussing this bug, is to load ucode on every logical CPU. > > In Linux kernel this issue has been addressed by e7ad18d1169c > ("x86/microcode/AMD: Apply the patch early on every logical thread"). > Follow the same approach in Xen. > > Introduce SAME_UCODE match result and use it for early AMD ucode > loading. Take this opportunity and move opt_ucode_allow_same out of > compare_revisions() to the relevant callers and also modify the warning > message based on it. Intel's side of things is modified for consistency > but provides no functional change. > > Late loading is still performed only on the first of SMT/CMT > siblings and only if a newer ucode revision has been provided (unless > allow_same option is specified). Another sentence on the "why" would be helpful, or else it ends up looking as if there was an issue left in place. (I guess latently it's going to be left in place anyway, until such time where we re-evaluate features after ucode application.) > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -612,13 +612,21 @@ static long cf_check microcode_update_helper(void *data) > * that ucode revision. > */ > spin_lock(µcode_mutex); > - if ( microcode_cache && > - alternative_call(ucode_ops.compare_patch, > - patch, microcode_cache) != NEW_UCODE ) > + if ( microcode_cache ) > { > + enum microcode_match_result result; > + > + result = alternative_call(ucode_ops.compare_patch, patch, > + microcode_cache); Nit: Indentation (3rd arg wants to align with 1st one, not 2nd). > spin_unlock(µcode_mutex); > - printk(XENLOG_WARNING "microcode: couldn't find any newer revision " > - "in the provided blob!\n"); > + > + if ( result == NEW_UCODE || > + (opt_ucode_allow_same && result == SAME_UCODE) ) > + goto apply; > + > + printk(XENLOG_WARNING "microcode: couldn't find any newer%s revision " > + "in the provided blob!\n", opt_ucode_allow_same ? > + " (or the same)" : ""); Since you touch this entire printk() anyway, may I ask that you re-flow it to meet our guidelines: printk(XENLOG_WARNING "microcode: couldn't find any newer%s revision in the provided blob!\n", opt_ucode_allow_same ? " (or the same)" : ""); ? > @@ -626,6 +634,7 @@ static long cf_check microcode_update_helper(void *data) > } > spin_unlock(µcode_mutex); > > +apply: Nit: Style (labels indented by at least one blank; see ./CODING_STYLE). Personally I'd prefer if you got away without another "goto" here, as our rule of thumb suggests that "goto" generally is to be used only for error handling or other situations where the alternative would be significantly worse (excess indentation, code duplication, ...). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 10:41:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 10:41:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494335.764366 (Exim 4.92) (envelope-from ) id 1pRWHQ-0005gz-Eo; Mon, 13 Feb 2023 10:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494335.764366; Mon, 13 Feb 2023 10:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWHQ-0005gs-CB; Mon, 13 Feb 2023 10:41:52 +0000 Received: by outflank-mailman (input) for mailman id 494335; Mon, 13 Feb 2023 10:41:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWHP-0005gj-LG for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 10:41:51 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1b::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05dfdbfe-ab8b-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 11:41:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 10:41:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 10:41:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05dfdbfe-ab8b-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVnMwudzifh3qrS8PT+nZ6ldhHBCd77ruMZercGpkupxX8peduDyA86gGSbG1ZZca/TPJm+rxbM4rqKXA2yB3JiDQZnlTTz3NcdaVq6b35DusgoWenSHnADXP7xGwD4blePN0RvbD500VfarA1NsKz+0vOjYIdEAy+jRWFSnpe20ktoUG+Fe78F/VeP0IyVoDy2bvznZBDlG8rlgAnwQwZmTEM9uGO7GLzdWMdQPLQmC5EFmPR07FyaCW4KUsFaxGwfqKXVh0Q943z6hquzrk4QqBX6yyEWWxKq2IIMX7OFufErsZ0VrkYRB40kv9jO/Rp8o/obREK6/kKBqAnsjoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rpJK4eE/EBvGTE5bNTsY4VYJC3L1bXoChiUA8fT0EGA=; b=MVwclZYXOtG53jVZWTkOolJLTUmcZFBxzB+jD7vO4gmpcsHTBQwQ34IzejunKwzuvOS+4uKtDiKIu1SKykWH/0qQk0i2nKcguPyEZlxYBtffrwpBnXRoAT4cckXM+CVff8/DXNM2lACAxQ2Iy+Oqz4tJ2qRKbvm3y/yyYTM3Eoj4CzQ+kdwwImuM+oe1R9A/AOKydfZHuzmL8G+SNe1x37HT1uROoekA9O1PFXzvqtlq+N0kIRsxKEXv2ocHcdHdxPZGnXPvf14z7nzt+PS6YBYKKFxmYUlMeu0CGFxq5nc7OaVYxFbbFaFavpQddjGIGCgyn41Q4W3WpN7tdxJWaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rpJK4eE/EBvGTE5bNTsY4VYJC3L1bXoChiUA8fT0EGA=; b=fOreX5PA1XMnsrNDO0Q3THphp9w/jS4CcogZlkmJtt6Zw+soRadkastiBQFnx+DJcOtIAJ+haeMdLEeeBCWkYQJqh0Vn9zJn4d+IKgMuzw2nr6Fr+HWAe7Up+tUYHqRZ7trL+Z4e/4ZDAt0jz2E/oOilWyahf23+2ckCusD2cD+wiVEGoCZ+38oDGCbkgecWY76OuCawmDeIJ7VbyxGgXvprHYBSN3oweu8ApSEMGVMe2ZXDEIuxiHsYVqPuoHeWabXxv8hUOkTQfj+YkP5jQEpK+5lgMwNbe0VPXPPLzlHTfxY79qaZYOwDmTcNxytAJB+lzZUwyP6XzJ5dqT0MIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 11:41:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH_v2=5d_xen=3a_credit2=3a_respect_cr?= =?UTF-8?Q?edit2=5frunqueue=3dall_when_arranging_runqueues?= Content-Language: en-US From: Jan Beulich To: Dario Faggioli , George Dunlap Cc: Juergen Gross , Andrew Cooper , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <20221003162158.2042-1-marmarek@invisiblethingslab.com> <7f453f08-0bc5-04f8-02aa-0beb0f0f3b5f@suse.com> In-Reply-To: <7f453f08-0bc5-04f8-02aa-0beb0f0f3b5f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM0PR03CA0074.eurprd03.prod.outlook.com (2603:10a6:208:69::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8790:EE_ X-MS-Office365-Filtering-Correlation-Id: d5428da2-1c60-41e0-a250-08db0daee8c4 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bqjp/tNm6qj2TkZeMugth1y7+EiIkFcPnruCtElUmyl0BNozU7x8Ymw07hNPHAhxfby5XiaZKL8r8UZ5uyc42xlGRnnOWGPH7RIYEiYFPZ2DkyF0WZkidBDhCtSnOVW4ysPQVlX3RUx+MqNk7nJSqfVoGwINIbb4Vbh9jLWTVhLjXfBvW6mpXSRHJZeJhX970knyBtyFHTAhUlUbpkyvSjSi8XUqRcGtRdzpMNwzFDNsaLjtK6nWbyH3oWZQDL4h7Hl8QhjykDYRWDP5U39U/+ZJhPu4rruVkhQGl8u3rYbFwqqc1bUknFwU9IAIFnlRJ+O/qpszJl4VvjyIzWl8+yPcdLgr3YrQpO2xpLkNg73ZZ2ibWMqFLlGJn+9eRqa3a0bBbXqtT4WI65gFFWgBTkdnfGd69j3Ko6QvaKeLsqQyysRavfYbY2O5A8HsPsCdcOzPCyr2SEqNEZd+IDPuvLu9hQ9IUnwVlkMbH6JG6igaYekz3mMnjQTSsKnRgLep3kfT9KUbHZxOQhRQ2TCLbA4WEr6/l8DBPLyr1BNFOHLvIlUNRNsTiyADJY9kDea/HTQHqAFqkk7tcRsiUzS4LmFKuYSkRqR58kpLEyc7dxlQcDxwDEdHZ4PJVAmTYW5Rj9SsGxw7pYNtPb9KUiZXSjPFhlJXDfCoDzDB8I6uexQFpwV4N2UNL45D510ojgJraXRD/N57humXE4cjGOpn1gRnyoud+tOZ9U9RMmRcNAc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199018)(31686004)(6512007)(66574015)(83380400001)(26005)(186003)(36756003)(5660300002)(2906002)(53546011)(31696002)(110136005)(6506007)(86362001)(41300700001)(478600001)(6486002)(2616005)(54906003)(66556008)(8936002)(66476007)(316002)(38100700002)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2licmtiV2k0K2ZqN0phYnZtcUlkV3RGMmhYUE15UFYvQy9aV3o0SGtqaVFo?= =?utf-8?B?QUJNamxiSDVhVUxRTGZSYWg3ZjBHUXpEemxtOUFIYnhOdFFRS0pCMVVjeTd2?= =?utf-8?B?UVVaNnZIUXpMbEp0cXVoNjg3SzkvWTVvVEMvVWZVWEJGMS9LVmtraXJTNi9u?= =?utf-8?B?VDJKeE5QbW1NUU1nMHVjWGpldE9Bc2h4ci9XcmNSSkhQY1F6TjdNZnoweFZj?= =?utf-8?B?UWZ0WWNaY3BzZFZ0U1NMaWtZNlhFWmFuTUQ1QVlGRWJpNTFzbElDWlh3dERB?= =?utf-8?B?WkhxaGZ1Q1Fsa3NuaU03SXE0ZnBiWDdOODJ5bzFzaVF3cVhyNmd5TUNIZGNB?= =?utf-8?B?ZVhwY2tFVlFmYzdjTlRibGUzMFRXNGZyKzYwaENVOUZNN2YvdkZjZGh0Tlhk?= =?utf-8?B?ZGFQdVJ2dll6bzYzYnJLYW1FWEk5TCtCWVB5RHRZSjlxMStQNHVDWXAxSjhk?= =?utf-8?B?ak9VVkJFZFFGRjRIdjRpOGpSeU42Skw2OVlmRGc2WExhcEZ5TUNDZ0VUcmJS?= =?utf-8?B?L2FTMEN4ZmZWc1I4YU5hUUloMEdHRWlaNm5yQlNnL1NITHc3ejZJa0kyVlJC?= =?utf-8?B?VVA5WDh3MDRGcU9scy9icXd3c0xWOTZCSE5tWTQxWCtFVk4wN3V5US9zbzV5?= =?utf-8?B?VHJoS2RoZmNFNTZMbmJHQlBWaFdaNnlSV01Uc3hMa2Jzc0E1eXJWVTFUOC9q?= =?utf-8?B?YTYvYmF6blRJUjh6RWtkUXJzaGJMNjZmNlNTQysybm5DU1kyaU5LODhiNlJj?= =?utf-8?B?dzR5MTJzcmNRekwrbjYwMW1LR1FhcTRUVEFlTzk0Zzl3NEUwdWdRTUF4TURJ?= =?utf-8?B?WTFwbmNSMUx1dlN0QXdnVDhtU1ZuZmIxZTVMSDBXNnNkK3J2Tm1OUW5YZUtE?= =?utf-8?B?Tm1jZE9vWEpEQ1NVbnRlVzA5QjBaS1BOU2FqUHFQVm5UNytiaE1HSlU3NTZG?= =?utf-8?B?dEQyWkMxRmtDeExNbUFRRmJpbk1JMUpCeXJ5UmptU2RTVVRKdDdiL1R2OGJm?= =?utf-8?B?aWszd0F3SXpUYWhWZG4veVY4QWh0YThBOHZabnl3Q2tiOWpPd1FMOVZrU2RU?= =?utf-8?B?dFRNYWZkVkFPQm9KMm1KN0R4b1dwM1dmcDJIMWRnaURnZmt1WHh1cklVd2dM?= =?utf-8?B?ZXFsVVpLK0RhL2RQNDVaQnR3T0hOM05tR1dqbmQ2ckdFTFFWSFc0SllJY0Jy?= =?utf-8?B?WnZoaWlib21pOGlMd0dUdmhLQzViSlRnYlFNeXNMOXllQUV1SmR2SStESjBz?= =?utf-8?B?ejQ5ai80NFU5Z0pQZk13bklLeFhLc1VjNElaK0NRQ0xhMU41N3BvQUhPSG5v?= =?utf-8?B?bjdGcy9NSCtSQlVLQkVnYmZRUmRwci9XbkFUZjY4aDBwTDh0Q1pGVklrQ2lv?= =?utf-8?B?Z1pLY1pXTTkzWGlrRGhnRFJBNVl4Y1ROM0IzT2k3dzIwUWFCV2tHYkQ5OUFi?= =?utf-8?B?WVNBNForUWN4VUc4bUI3NkdDb1RDZVcxOGJ5eFUxaUNRTFJwRHEvejJqZGlk?= =?utf-8?B?a00zZm1xVnB5ZGg0bVpBanZudkZ0WnNXbW1TcmJYMTE0VDVCTXVXUy9OT2dZ?= =?utf-8?B?YytzK01sZGhvcFUwNGNUQUd4aEdVR0lqQ0xOSDZ2U21veDFaenpPQmNXa0NN?= =?utf-8?B?cWhBZEtxMXo0SFpRZjEvQUFOY0VJMkdsQzMrbVM0b1doME51VUdqaDR6b1dl?= =?utf-8?B?dzROeXRnZXJmNWp4UXI4M2ZLNVBBUmZHUkdPeE9TU215Z0V1WHFEeDliT09P?= =?utf-8?B?b1BYSXZmdTQrZDBWSFptdyswakxCTFovNWNjSTFSWW5PZ29INm1lbmRlNTJw?= =?utf-8?B?QkgvWlZYdEpnKzNPNW51RU5pR0Z6WEs1SERpWnY5RzBkREFOdDB1am81dmtO?= =?utf-8?B?UjUvUmJzQWZ4SWR1aksyN0owb1VNTG1RTk8vUkNqdzE3RlZoUEt6V3dSUnVB?= =?utf-8?B?YnRTWTN3Uzl6YUJSajlOU2hzOUQ3dnl5MGgxUWwvUWRQQk81VXg1VXJOZk4w?= =?utf-8?B?YTljeEhpVXNtZW5LVFc4NFU5cEwxdHpIb2hLc3VINE16TGJrNjdDTVpoQ3Zj?= =?utf-8?B?Y3pCZGxESjlDV2FEUjUyQnpvaTNiQ2xYRVdhbVlzVENqOGw4MWhTZml3NUgz?= =?utf-8?Q?v5a0opsWUBZkOBEjxxAceOZB5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5428da2-1c60-41e0-a250-08db0daee8c4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 10:41:48.5915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UIiXSA8NXyIHyeZDFac8aAdtJLQCbszhXOjDOrHginwwmtdvay4xF/BIiY2IqKFM1Vf/AABF6G2ytszxP6XLww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8790 On 07.12.2022 12:41, Jan Beulich wrote: > On 03.10.2022 18:21, Marek Marczykowski-Górecki wrote: >> Documentation for credit2_runqueue=all says it should create one queue >> for all pCPUs on the host. But since introduction >> sched_credit2_max_cpus_runqueue, it actually created separate runqueue >> per socket, even if the CPUs count is below >> sched_credit2_max_cpus_runqueue. >> >> Adjust the condition to skip syblink check in case of >> credit2_runqueue=all. >> >> Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a runqueue") >> Signed-off-by: Marek Marczykowski-Górecki >> Reviewed-by: Juergen Gross >> --- >> Changes in v2: >> - fix indentation >> - adjust doc >> >> The whole thing is under cpu_runqueue_match() already, so maybe >> cpu_runqueue_siblings_match() isn't needed at all? >> --- >> docs/misc/xen-command-line.pandoc | 5 +++++ >> xen/common/sched/credit2.c | 9 +++++++-- >> 2 files changed, 12 insertions(+), 2 deletions(-) > > George, Dario - any chance of an ack (or reasons not to)? Another two months later I'm inclined to commit this with just Jürgen's R-b (assuming it still applies cleanly). I'll give it a day or two more ... Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 10:54:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 10:54:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494347.764378 (Exim 4.92) (envelope-from ) id 1pRWTp-0007Pk-M6; Mon, 13 Feb 2023 10:54:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494347.764378; Mon, 13 Feb 2023 10:54:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWTp-0007Pd-Ix; Mon, 13 Feb 2023 10:54:41 +0000 Received: by outflank-mailman (input) for mailman id 494347; Mon, 13 Feb 2023 10:54:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWTo-0007PW-CI for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 10:54:40 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf6cbae0-ab8c-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 11:54:38 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id c26so26010595ejz.10 for ; Mon, 13 Feb 2023 02:54:38 -0800 (PST) Received: from [192.168.1.93] ([188.73.238.161]) by smtp.gmail.com with ESMTPSA id i8-20020a50c3c8000000b004a23558f01fsm6473647edf.43.2023.02.13.02.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 02:54:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf6cbae0-ab8c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F3gB7d3G2ApKRswibo/Uz2hUF5llYjZhxvF3E5z791M=; b=DmbOUTjoPk/Ul3TZLeDB7PRELyx5VS5W40Kd/1gde9Cl1audOD3WwspXLO9qQz/u5l vgouu+dx4VKMcS/qMf4ugrn/6THfl1k8SIpO5u4TUnhpH3zIXrRbFzBR25m6By6PH9fE SNgGrBrQ75Q8g4bIF4NMTCHPmW2kMYcOUVqS9EHPDXhnMaiYlI2aH+Jv+SYQi+Y5bnJq Xbc3gMSTzmC2PlbHeZLef3VvBTHuSFo0q2dAjyo+DM3CbFSzTABcajbWkt5ZVDqKjvoD bPWQMWe4dewVdWa2+/2LOLxyb2EUmsHysoONLarUx7JMxr+FeXpLPZOeM3mEgOiTA9Oj azCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F3gB7d3G2ApKRswibo/Uz2hUF5llYjZhxvF3E5z791M=; b=0EXDMin1MuBBU9eXxADcn2KzI3nuSr6zij/SmxZuKuaaTgP6kijkfiyBvTFITAAAJI H1zc8bm/nKryJ/wk8wQcnGMTa8D6+ZaWenK+7NQaKV0/DSJ5cEvaNyqBIxgthp1s+b2u 7DEB/ZOeiQa/f3dapLvXINMgqG70k6wfOTpYNePG7UEXNQsxNvHlfkfmm/dFA5TwCDyW SekDilNCKFiuh+gmcKek3F1Ynd6/i92x4GA4iMfQfbdCFUp0rkzkPTnibUiiUHyKf5te 6CjgupPbh5/5puRKTxTUH4uBiaD0SZljpX7bX3BKOonULzjmOuRLvQCjkr4Z3sexE3ZP Wv8w== X-Gm-Message-State: AO0yUKXlR+8hJsjPWpo5cZhsQYauDkppU7bWfVeN8ndeC19P35TIkfRV /z01luoJQsK/IIHENkO4/Sw= X-Google-Smtp-Source: AK7set89DwrJipKQ+DiT3rxJGwYdanLkMtBPM6aOkRHQLtq8boGe+N+Vvv/kWI0Kezh+4aMfMOu+uQ== X-Received: by 2002:a17:906:2297:b0:887:74b2:811 with SMTP id p23-20020a170906229700b0088774b20811mr22676423eja.74.1676285677837; Mon, 13 Feb 2023 02:54:37 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 12:54:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230207094347.1059376-1-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/13/23 12:09, Jan Beulich wrote: > On 07.02.2023 10:43, Xenia Ragiadakou wrote: >> APIC virtualization support is currently implemented only for Intel VT-x. >> To aid future work on separating AMD-V from Intel VT-x code, instead of >> calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub >> to the hvm_function_table, named update_vlapic_mode, and create a wrapper >> function, called hvm_update_vlapic_mode(), to be used by common hvm code. >> >> After the change above, do not include header asm/hvm/vmx/vmx.h as it is >> not required anymore and resolve subsequent build errors for implicit >> declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including >> missing asm/hvm/trace.h header. >> >> No functional change intended. >> >> Signed-off-by: Xenia Ragiadakou >> --- >> >> Changes in v2: >> - rename set_virtual_apic_mode to update_vlapic_mode, suggested by Andrew >> - in hvm_update_vlapic_mode(), call the stub only if available, otherwise >> a BUG() will be triggered every time an svm guest writes the APIC_BASE MSR, >> bug reported by Andrew >> - initialize the stub for vmx unconditionally to maintain current behavior >> since no functional change is intended, bug reported by Andrew (here, I >> decided to place the initialization in start_vmx to be closer to the >> initializations of the other stubs that are relevant to apic virtualization) > > I disagree with this - unconditional hooks are better put in place right > in vmx_function_table's initializer. Ok. I will fix it. > > Also now that you use the function as a callback, vmx_vlapic_msr_changed() > will need to have cf_check added (on both declaration and definition, Ok will do. albeit > I keep forgetting why putting it on just the declaration isn't sufficient; I > guess a short comment to that effect next to cf_check's definition in > compiler.h would help). Yes, that would help. I don't know why it is not sufficient placing it just in the declaration. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 13 10:55:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 10:55:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494353.764389 (Exim 4.92) (envelope-from ) id 1pRWUp-0007vj-0r; Mon, 13 Feb 2023 10:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494353.764389; Mon, 13 Feb 2023 10:55:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWUo-0007vc-T3; Mon, 13 Feb 2023 10:55:42 +0000 Received: by outflank-mailman (input) for mailman id 494353; Mon, 13 Feb 2023 10:55:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWUn-0007vU-K3 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 10:55:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3bfd6ee-ab8c-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 11:55:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7077.eurprd04.prod.outlook.com (2603:10a6:20b:11c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 10:55:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 10:55:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3bfd6ee-ab8c-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oh9UaLaLxYbaYoqVLGt6mSxKHZNUa8T0T8THiBT8PZYauGWQ3vgORfoXk6TJAWAJNBKmlbt83m6uZFSZK5H87p/l1hwUVCZFgguw5MJJi+ili36Kkm5GzG5lJwaYtLsLw0aemHj1sCByX4Ovb0VsAg5IVicOP2qmvNjThjavjiNmfIAuIoRdcLwbG34VlcaobUoJTgEQ8+Yh4uMVMQGzLngFOdDvsvTxgsrOXSqmVajrCp4ksCiUxf48G27eHe4bo5N97nDjOZtSxPVdXO6erJ8GCzmnRFthWidEC0BXwkuLe97auwGrDTYO+v0Mq+4Z0XUmwWGSuI9/m5hc7hAA+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b3iKdFNPxYhhVdd3DtbkCxa+1wmF8o+QpB/l21Dqtx4=; b=QtvKjgXpCUupy+T62thztxv0KXsr5jtYLLr7BRan/60ibMDqZn/tDEfLyWQE3GxZnM7bw9xjeonF44x/Y7RqZVXS4MDfkvvTi0LIAhFx8xDSbsK+360La463YEkzx2LBJBsD2un/duJmxwQjOmlKFKQvLTCOY3BCK8qfCYMwFebNB1I3ntYFgWJIaQFPUPiGwfN8XYTgsHcdj2rOSDtw5yjBYfrIS3+TK/ctsMkUC1IhjPQ0vIwKOgmHXtskQggWTZ1PZS+erPXSbM4yba6SUU6j3Jzfl5le1EIvC5XVELnKsQ9Eg+WWCwiOGZtgR5qLvHCh5ogktm+5nry8qZJgFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3iKdFNPxYhhVdd3DtbkCxa+1wmF8o+QpB/l21Dqtx4=; b=Ka7kKuO9Q6eF4qMojIEsyXTgrWMkQ6JpB1JIBi10HEehK9mRhcSFfzmqpmxUdrWB0tHZXIsGSz0UWL88QCUh0qCkrJ5oUgGGy+PsJ8wkqqProEvdCINVi1K8AnPaZOFmGd6eWxiUtIc9aKGghkK1XVzyBjahT57xftiI2SM/oSoQG9Ic0YOGa6wmV73rcBLyOEQoj6YavVp20+U3mn6esKxGBYm3K4IhiIlGKIe+u/RDsPfX7p2fl31QITsnDu/lbW12RY7e0pFdQ7sqyPO/F3ai45ybUyBMxCyxVqmsV0+ZnIKYaXKDU4K3T+kufmLpH5C1RUYTzEIgti3+7fv6Vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 11:55:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: Ping: [PATCH] Argo: don't obtain excess page references Content-Language: en-US From: Jan Beulich To: Christopher Clark Cc: "xen-devel@lists.xenproject.org" References: <44118a7a-3ef6-e984-babb-f5b75e5e53a2@suse.com> In-Reply-To: <44118a7a-3ef6-e984-babb-f5b75e5e53a2@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7077:EE_ X-MS-Office365-Filtering-Correlation-Id: 942dca22-fd0c-4fed-77a7-08db0db0c6ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KTmBfepsYxohbnnsT0QPnGxWa6PhplbQmNMydWte0tjM2twsa7Iq29xmDJ/ewSrToDEC829p1C7JYMkAuUACCtOEM8t8tVfAFClxo77fUk/IYSZl/cPvTBAulqwkCBnVakoMmal9fHrSYsUYFuFKjqzY5Kg3rrjJJur7umcS0peQfUT1cx3xE9UMfdGzOwJZ40OVzmgaCgEjWNbhEWcTsHhQdmS2l3QnHb2Qn/rm4AJ9C8SOZbdhwnIgxStgOd80Wh9aAYznQp81tjDiBelA11j7RoLvFw1gTAYTuKxn9SfVnYtGu3xq2xi2XwhYbLeRO89FMBnXLAqDyc0h/SR5gDZhzYzAi0jbL72WqMs1Cdj24kq3SofPLm7rNLzCVmZTR2F0hGcKFNVSrFTt0b/KIpkHAlyllNywMBn1NRPy/OOk+tRrXIwJt5UlugE0wk6juoQYZRY1pN6znCD9AWOO1x7XZ0oEo70+vOZjmtw1IDWfOi3S8/g7N5rzTm0Vg9xnQM6gF2Bw194OLNvvVkTUnOC4MqluY0aydNnmFtErc6vzXbTTHnBTQ4+m5R/tsjKpx4VP8qzi5s8ShdgNRIdnt5tv4gqfutWZL1Q3yuP7ukiVRoU+9wB/Ox6ImiYrfI/DnRU7+wxEknQ9eywcqZwvHyYYAjyYHLUfTNwxYll17I3TGERzXn2Jm06/qyVIKys4gO2zzXH6dJGH5obPNx86IuDsI5wklf9k4joTFldPOdY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39850400004)(136003)(396003)(376002)(366004)(451199018)(8936002)(41300700001)(36756003)(2906002)(38100700002)(5660300002)(83380400001)(26005)(66556008)(86362001)(6512007)(186003)(478600001)(31686004)(6506007)(53546011)(6486002)(31696002)(66946007)(66476007)(2616005)(8676002)(6916009)(316002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzNScllsMmwvcURlbU5qaXhGMUpGeGNBY0RKOWlBTkNwaDl4K0JaWkd6Q3ln?= =?utf-8?B?clVUUjJwc3p4YytvTVNlV2VwUzRzOGhERTRzYW8ya1JmR3ZmNVlISHh6a01y?= =?utf-8?B?aXZ6L0RXL0RpTGFSVjJYaWd1UWlWR0FycW0wL1l6ZndqWHNjRkM4cUZaYzUz?= =?utf-8?B?ZXRpVXprVWYwdTRqQ1laRVI0dWdFM0Fod2dJMHAxNkRZWnM3RWxjYkRxVUJl?= =?utf-8?B?aXMwQXRhVVFXUzFudlg3MG12ZDQwd0JNSUZKMm5xMVlsTUkrYWlqQXd5RXc0?= =?utf-8?B?WFJ6R3VaVHE0Ry8rYStVME82ZE5EVHNjZkdMWWtjYlo5Ynd1b00yQ3dOWDZ5?= =?utf-8?B?d2pvd3hNakJIT3NhaW54YjVDQWtpa095ajNxcStpMUJkcmdVRlVTenY3Ri9M?= =?utf-8?B?d2Z2aGZ4ci9iaU40cFhtemZ3UWNhdXlYWWNDMnR4YUZxRlVFYUdPcGt6VjJS?= =?utf-8?B?NEpQbzJYN2c3dFYxN3dMRVgyYmczR041MmdnbEQvRXBQSURrYmRWNFF4b3pK?= =?utf-8?B?SDZ6ZEpCNGJuZVBmTzR3QWQ4eHV5eTZBZHJVK1dHUWdjNmlFeHFYMTcxTnBn?= =?utf-8?B?aFZBb2JzN1pwQUxzMkxHNVhQTEppVGdsN1NSckxMMjJkQ3B6YmkwL2dnanpq?= =?utf-8?B?dUp3SGpyTXR5QmZkayt0TkZUMFJ4RFZUcThEZzRDS2h0V3BMKzRjUEFLM3ZB?= =?utf-8?B?OHd4aEU0NXVHcjU1Q215V1JRa1piMWhsSHp3OW9VV1JpM2wyOU1TRGhpSXI1?= =?utf-8?B?SnlyRFoyY0Z6SDBFZG1wMUUrZmtucDY4cEtSeUd4ekpoNUxxVERESTZJdVZs?= =?utf-8?B?aFhMYlg2UEUvZEVZamg2a3NEeEJxc2lrTDVQdzBFbGVSV1ZpMUUwUWxSckNn?= =?utf-8?B?akF6Y1c4Y1A2d3JwTno4VnJ1anMvWkpjMDYzQ2NWdDY4WFIwa1V1dStoRzBL?= =?utf-8?B?bWhWZ296b2FYTWI2SVcvY2V3YU1ncDkwTXpIWFBZLzhnaTBlUERwK2kxUEtK?= =?utf-8?B?S2V5S0ZxUlZwTE1uYmI4ZXdiSTNidzEwYnlGQzNjck5Od3ZYTW16YldGL1hi?= =?utf-8?B?akR6ZFhhaGtSVTBjT1V5MUI1YU9POXJOMTNBZmZOUGc2eGYrbGYwZWRVMks4?= =?utf-8?B?Qm9vbmNEVlN3cVhURmovYW1xbDBJSjk1Rlh3Wm1kNUc3UU5OUjBOb2wxbndN?= =?utf-8?B?YkJxTENiQTk1dmpQcE1yTkcwZW9QNUFnVFZPbTNDajR4VnlMNEZqV0lmVE0v?= =?utf-8?B?UlZsOCtrbDB2cElkUFdtSnJDYlczc01IZUxpZGFuczhsYnluUE9waWxzQk1O?= =?utf-8?B?VTNyYUZVUFZKM2doeGYvRGY5ditSNFNBcUpwTXI2eHhFS05Wam9mK3hXMDI3?= =?utf-8?B?SXRFV3VEOWV1Y0czTmNLMzJvcVFGY0wra1dNMEJTVWZsTUFpMWJXd2hSd3M5?= =?utf-8?B?NzBrNXpiWDQzZTAvejVoUkdWR3pQcWVpcEoyemtIakRCOEh2UkMrWDJUWk1K?= =?utf-8?B?ZFhVMUxEM2FzaEE5M1pyUEtZL01nYVhWc0FuMHN2UjJIMXpZaHNtOUExZExx?= =?utf-8?B?YjdLZ1o2UEVtNjRXS1RkdkUzUktCYkRUai9ZYmVjSEtNcGk4VzkxSmFLVXho?= =?utf-8?B?eUZQNXo5ZklGS2lwanRJUndZV2Q1NVh3cnFYdWtCTWgyTWlSL3FLVndaM2pO?= =?utf-8?B?VFkvQTltL2VJVE9sZ0NWaGZ4ZDVISkVnOURLWWNPdzRTQW5aMkE4VGFvOXk1?= =?utf-8?B?Nno3T1dsbkgzbG92YXlvVXBaL2dSS3lqWGpPUkl0Ky9wY0ovcjBlNmJOYkpV?= =?utf-8?B?bkQ2VDZlOGJtUDR4MmpsdkJ5Y200VXBPQytVWDgyWXc3ZXZKOExiajArOEYv?= =?utf-8?B?bzFISVpPSmJoMEpneWdHa1FUWkFhc1NNT001U3hhS1prdnVjdlNZR3FGcXlT?= =?utf-8?B?dno0QlZaYjhuNEQyZXpNQ21FNCs4V0xWanN0blJYSXZPRXl4Vjk0aDIwVGNx?= =?utf-8?B?azVHOUZuNEpQSDlPK2w1cXhGeHI2V0NENEJxR0haU2dzaUxPVk03MjdUSlVK?= =?utf-8?B?TlNpWXd0aTNDVjNIM3FOamxucXhidGpOck5CTzN4d1oyeFZoNzBXSEhiWkd2?= =?utf-8?Q?1a3WVhJ5m0f3XmoZXMSDM90Zu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 942dca22-fd0c-4fed-77a7-08db0db0c6ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 10:55:10.2903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: seyaQ/0YeAALkAM7Mue6JdV0zRq1b80I0VqFNYQdhP822exQRtYYuo2f/5UcYommOdAAIQaBgBpta5LokrII2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7077 On 30.01.2023 09:03, Jan Beulich wrote: > On 30.01.2023 05:35, Christopher Clark wrote: >> On Mon, Nov 21, 2022 at 4:41 AM Jan Beulich wrote: >> >>> On 11.10.2022 11:28, Jan Beulich wrote: >>>> find_ring_mfn() already holds a page reference when trying to obtain a >>>> writable type reference. We shouldn't make assumptions on the general >>>> reference count limit being effectively "infinity". Obtain merely a type >>>> ref, re-using the general ref by only dropping the previously acquired >>>> one in the case of an error. >>>> >>>> Signed-off-by: Jan Beulich >>> >>> Ping? >> >> Sorry it has taken me so long to review this patch and thank-you for >> posting it. The points raised are helpful. >> >> Wrt to the patch - I can't ack because: >> the general ref that is already held is from the page owner, and it may >> actually be foreign; so the second ref acquire is currently ensuring that >> it is a match for the owner of the ring. That needs addressing. > > I'm afraid I may not understand your reply: Are you saying there's something > wrong with the change? Or are you saying there's something wrong that merely > becomes apparent due to the change? Or yet something else? And to extend on the questions: What notion of "foreign" are you referring to here? The earlier check_get_page_from_gfn() is passed the very same domain. And anyway, get_page() wouldn't allow to acquire a ref with a domain other than the page owner. Plus the sole caller of find_ring_mfns() passes currd. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 11:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 11:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494362.764400 (Exim 4.92) (envelope-from ) id 1pRWeA-0001D6-Ty; Mon, 13 Feb 2023 11:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494362.764400; Mon, 13 Feb 2023 11:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWeA-0001Cz-Qc; Mon, 13 Feb 2023 11:05:22 +0000 Received: by outflank-mailman (input) for mailman id 494362; Mon, 13 Feb 2023 11:05:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWe9-0001Ct-Dl for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 11:05:21 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bf35e03-ab8e-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 12:05:19 +0100 (CET) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Feb 2023 06:05:15 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6355.namprd03.prod.outlook.com (2603:10b6:806:1b6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 11:05:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.023; Mon, 13 Feb 2023 11:05:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bf35e03-ab8e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676286319; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=r3/a8WF2x6t8QQ/NlA9CWJmt4lOO0SParreVHDBup30=; b=VTwtobEQCO99x15uu2e+qh6YPFAyFImvqOEsRZYQCU4PPSPD1siyasm+ uZGY5vu87jhrByxnFyNeumIoY6ntT89L8Ja5fuN1yaISpyUZU1Eb5ki3s qDqcfaSM5mtzfXStOC5Fdcg1nbiEJSAqRGpnlfgcJsSB5hc/jVfPeRnkR 0=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 96797059 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0mgtz62MM6VbslVAifbD5Tpwkn2cJEfYwER7XKvMYLTBsI5bpzcBm 2caUWyCOf3eZzHwLd52b96+/E0Gu8fSn9ZgSwJtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfCDxp3 sQdazM3Mhmp1tiR/53gcvVgr5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6KklwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKlB9NNTODpnhJsqFq07G8wGB1VaVC+hMOW1RC8C+hyA VNBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6bDGUZSj9KaPQ9qdQ7Azct0 zehgNfBFTFp9rqPRhq19KqS6zW7OiEXLGoLTS4CUQYBpdLkpekbjR/RT9AlDK+8iPX0Hy39x 3aBqy1Wr6Uei4sH2ru2+XjDgimwvd7ZQwgt/ALVU2m5qARja+aYi5eA7FHa6bNMKdifR1zY5 XwcwZHAvKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK IronPort-HdrOrdr: A9a23:8Vv4/a21vV4K/EBaebqw+gqjBW9xeYIsimQD101hICG9Lfb4qy n+ppomPEHP5wr5AEtQ5exoS5PwPk80lKQFrbX5WI3DYOCIghrREGgP1/qG/9SkIVyCygc/79 YuT0EdMqyKMbESt6+Ti2PUf6dCsbu6GeKT9J3jJh9WPFhXgspbnmBE43OgYzRLrX59dPwE/f Snl656jgvlW046Kuy9G3k+RuDG4/3NiZ78axIeGhg9rCmIgjXA0s+gLzGomjUlf3dmxqoj7m jfjxa8xqKttZiAu0Ph/l6Wza573PPn19tdBNeRkIw0LSjhkQylfZlmQPmjuz8yydvftWoCoZ 3vmTtlF9lv43nRem2zvDTs3hTtyzYo5TvDzkKVmnHuuNH+X3YbDMVG7LgpKCfx2g4Dhv056q 5RwG6Dl51ZC3r77XzAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEb8bdRiKprwPIa 1LNoXx9fxWeVSVYzTypW902uGhWXw1A1OvXlUCgMqIyDJb9UoJjnfwhfZv3kvoxqhNCaWs1N 60d5iAU4s+CvP+WJgNR9vph/HHTVAlDyi8dl56am6Xap3vc0i92qIfqY9Fl91DdPEzvesPsY WEX1VCuWEofUXyTcWIwZ1Q6xjIBH6wRDL316hlltNEU5DHNfPW2Be4ORgTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQ478AKh+zi9OOLpevuv3Qcf7VKraoGTE4WnnnCn 9GWDToPs1P4k2iR3e9ihnMXHHmfFD54PtLYeLn1vlWzJJIOpxHswATh1j87saXKSdauqhzZ0 d6KKOPqNLMmYB3xxe+04xEAGsoMq8O2sSTb5pjn35+D3/J X-IronPort-AV: E=Sophos;i="5.97,293,1669093200"; d="scan'208";a="96797059" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8NBIJedvppyG3xE0uCNSL0vwmhaUoOD36Y9B/VVEpkIfu4lEao4omwPECT+vUIcuc32321UctRY6addd4VcLs9YnegkiOfwtWgvFLx6yhwOtoPnYfmVt2L9zFpNmbzUnSVYan9VjpG4ur/OBte3pK/CQOQbISokgu4SHvr6fmSVFfDIPwb42inUlS0GUb35crGz3hRhgjhLGj/LoRpdAp3PIKNqhTa0jv9QTKhjflxBlu1ztzb+tjI21gOjsRPhuq3v2rGHBo+P2sLpidrkYz2TeE8B5x3qzeCdVa1XAdmmHvyaMEN8cWuuWEvnfwi14q2R+HaZbYE7Gi5BNxbqYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r3/a8WF2x6t8QQ/NlA9CWJmt4lOO0SParreVHDBup30=; b=QeRckJVR/00h1YFyUb5DLRxvcQkDJ6vmIh+/8CTcfje2jJEMw73HpG9l/i/ZjU3WORuoI0aHkJJh3br/uhbvRS+YUttHHN+eSfNTfBBzJJNZzz4/OHIN/6ras3ABf0qraWTIHDFnYKBHdJjWT7pr+QCnKBb2gM9/pTlu5wwsmvA8tXM8WBgbUmVTY4PKyjugIvv1edbnsIIMSm1K2BsQA8siO2mjvnu8Q3LLXTRx0E/19KD43yGc9a2D6rDNZIVlPvZx/cJrO1bPlt9HYiEOzEd0Z9Qs7lsggbDSe/PkhZKlLGp8TIbbV8Chq1YzhGeAFO12vsimLit5nQwmSa6+rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3/a8WF2x6t8QQ/NlA9CWJmt4lOO0SParreVHDBup30=; b=qMKRKqiF6yAlZus3SBNhlFORMW09Ty6hPTfQRzV4sD+k3HIxHkFN+fAyLXXBKKMrPpHiyeX9qgfN6F4V3oT+ZunWPURQ9nnM/4ozZD14m/t0DcJwEZPo/4Rje80gAEN41sGn12a60WYRugvEYVM4/IJbAdTTp53K+H954bZsQqQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4c3e3350-b415-3414-c1be-f5d7775ea867@citrix.com> Date: Mon, 13 Feb 2023 11:05:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-GB To: Xenia Ragiadakou , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230207094347.1059376-1-burzalodowa@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0612.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: f12801fc-4e4e-4a4b-5740-08db0db22c4c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dZoBIPrM1rDe5ypEewoVfSipBTB9y4jUNhHvtzz8ZZGv6cqi4Jm/4YUvc/S3vGgGGTe6N799Yhauj3Ray1yZTuLTVbYJR7B5wOuTTIFYPX7jVFy8bQAXD+2Mt7+mdKgoD4rbSw0o+oAfFwkZqzbeJv23PH3RxwO53TF4PLQXuL683H0M8HKmRGBee/TwjebYgZeqLq4ZFisDTkXeyLJmLPSJNwnvgPky1XZyoW0Th2SM/xlOuZJpLEGY35AiAQBDgwM7U3xhCP9S21J4ewufvidcPqPxuYW5XDDvpmm/10e611efofBD+P3vT60PqvQaCbIgx7Dlm91V8AR5OqkaXQZhbFpPt0rULn8aJAsxG0cmVGv61Y1zfSG46XsfbaIz1oKvzKMEWN1ny3C1eamT2k5kSxLYJLLUmU4Daan1Gz4D658Kk+z8wdG2TPDYx7FHK4pFAiDQqx+fZkfunqtoBC6t+v8rZs3gZNd1tciBy+zJ6nt+imy62lnoS+FdAalrVljHOehOxKBFAueHQzrWaSfToq8G2BM6IvhbUXPNgmXY+bbapjGnqbrpcD+DXvMp/uChtE73XYQqjZFBh3eQn9tmmal0N2QOwxL3/+S66tkgMrFg5mm3Shj0wsMhSu5t+HYRjr+VxYYpKfeYHFI1YDKkZh0apKea/cLPKGIbbTOVS95byfV69wS7zuDlbEqa/LU0SP0deQJMkrw6w33IsDWF79P/6P56UPPV6gJi+7M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199018)(38100700002)(82960400001)(36756003)(31696002)(86362001)(2906002)(41300700001)(4744005)(4326008)(5660300002)(8936002)(26005)(6512007)(186003)(6666004)(6506007)(53546011)(2616005)(316002)(110136005)(54906003)(66556008)(66476007)(66946007)(478600001)(6486002)(8676002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXBWVWU0cDRUM3RnUmlmT3o3M2E1RDhyMEJHKzJtN1YwYmREZkR3MlVYRHJD?= =?utf-8?B?V1hWdnZ4dTRlTUx2MkI1SGR3dnhXVjlyZzBRMmlzNnNDRnY3ZjgvYmxza24w?= =?utf-8?B?alhrNm5FQzY3ZmhlUWpIOEdib1RjZUI5T0lENmhzaXpXQmV0YVRzMEFaY1ZM?= =?utf-8?B?MHhYUDZtRVcwNUEvZHFUYXpNRDZJNW1xUGJSbDRYTzRxbmFzVHN4WnBpZnFz?= =?utf-8?B?K1lXcm1iY1A5UnRORUdlRHFNWDRwRE14UzN4b1RCazNGeWhFem4zZ2dJZkZv?= =?utf-8?B?TWpQVFNzMmo0MFF5bDZLTWQ2bDZwNzhkMjRMOExPTmNOY1NIUW9wb1RldDNh?= =?utf-8?B?eFFYbTA0NW9pRW80QUt5a1NUY1FXL01DeWhIdWVhK0pCcEZ2Zk5JREJtMUg1?= =?utf-8?B?TXd3ODZHKy9hdDlxSlpqNE1HbmxnQjMrNmtqUmZyY2lZZGFvUkk1bG9RY05m?= =?utf-8?B?NFg4c0h3Yi9mYnlsbG9ydlprTVZLYUQwTk0zcHRtZzlCUWpUMzl5Yk1PbzNL?= =?utf-8?B?VFYrR1FKSzhxWVFtZ2pKWmVhMHFiT2RWenpRM0VidFlZMW1ESHhNQk1yQ2x2?= =?utf-8?B?T0JmTzNwZ2xnKy8rY3NscEpKL1NwWmpWY2VHTUJBc01BZ2ZFbnBtN0w0emFo?= =?utf-8?B?SHltdHBWM3M5ckJGbEMyYzRKWHIwb3ZzU1BsUndKVG94L1Bva3lTeVFoOUNH?= =?utf-8?B?dUtaKzhPRHJnS1cyNjlHbzM2RTRrY2NVZjZoSXYwTVZRV0dSem5nZHVQOUo5?= =?utf-8?B?bXF1TlhHR09rdU8zc0NGdW9XdFMwNFFMUjlObWlFUFRHK3daS0JmQll3RVNH?= =?utf-8?B?YmYvS0RTR3NNNzRxdmMrUTB1SGxKbWFSZ0xlNzNBNTZHSS9SbS9jaEg1cEtj?= =?utf-8?B?OFVmY3JHODN1U2RSK242Mm1DZWNQbmVJU3BkUm1VR2g0R2xyWVpUWWl1UXND?= =?utf-8?B?Wm1CeVVCeGVnT1dEUzhQNmQyM25YU2V3OUVVU2lxQURhWmlKRy9HQm9PY1ZD?= =?utf-8?B?RHZ5ZTFsakR5eWVpMEM4TjQ4bTI2VXNETzhoMnVaRFdPZWJKdTlrZEhWdWRn?= =?utf-8?B?ZjJEbGQ5MTdBeGxWelpUdGUxMmdTVFZtNVNydERDcFF5UllIRmZXandEZW5a?= =?utf-8?B?bjlueVNjQ3JIdEl3a29pc2xoeDR4Z0xhVXRUU0Y0cnZweTcwNVNRVkl4T3o1?= =?utf-8?B?WlNnekRWVjJKLzEySkYxZkhZUzgyY0VHb2srYzFPUmJ5TjU5Ui85VHc5WnU5?= =?utf-8?B?TjVUZGJkdHF4cUdKN29UQ0lzeUpqQytEMENmc0dCYVBPZzczNnpmRjZGZ25R?= =?utf-8?B?Mm8raitKU3FpN0lWU2MxdERyVm8xNWhoQnpiZlBzVzNOQWhQU04vd2hhWFhI?= =?utf-8?B?OElSaFBoS0twNGV4eGtjU0VJSytDWlJqc2tFcTJnNmc4L1dyRVRCdVdCUjVy?= =?utf-8?B?M01LSE1wWkJLWC91azhYR0YvdjRGQzE2N01DeUh5RHJ2SnVFMmpUZEo2Z0t5?= =?utf-8?B?dkFHYmZqT0JKbVJSeTJFakN2a2l0WUlSNFBEdUxSYnZKL0tQandZQllOdjZ0?= =?utf-8?B?WXArZThydW1SZ2NndEVlS3NaY3NpcWNldmN1MXNpMkUxRzA4YkhCRU1Fei92?= =?utf-8?B?SGd6QTFOeVZNUVpueEhzZkQ1aGw4cTZFSURpZE1oaDBaWmc1Z3dIc24wK3d6?= =?utf-8?B?WXZEV1A5RnhES0NjRWcrbTFpNnVVRy9yUnlBdndjVExNZWdGd1lOcGl4Z3hV?= =?utf-8?B?QjY5QjI4SThCTEhPRU8rK2dxQTZGZmtQK3pwczFURW8vK2w1Z1BBSDVqMXNv?= =?utf-8?B?cnVBdHM1Q1lnbExvT1ZaNkVJRVNGUld2RDJNcmQ4SERHbE0rSHJPaXBXSVM0?= =?utf-8?B?bXRzNjlWcEQwdjJiRjlLZndJYmJhOTFIRm13MGhveG5qK0F1VjZ0c0wxY0V4?= =?utf-8?B?eTc0NTJOU2hRTDducVd5RC9KUjdqRGovMXpDb084bnNwR005QlhRRlNZUENK?= =?utf-8?B?S3NrZUJTb29EOHRjVGFyMkdzdmovcWxySDN5UHRhWFZWQ1lweXR4NllkRitl?= =?utf-8?B?UXhLd0JhRjdpeE9qNFgrbGpwYTgxc0w4cjlTdFZwWUdjS2ZSbGxobUNvbnBs?= =?utf-8?B?Z1l4TWVFNnBuRmptZGlBNzMvbC8yNU1yclRMV2hFMTN3K0MwQmd2ckZKWFpu?= =?utf-8?B?dkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hf1IRyZlpMRy0Nuagu7gaUFXiNZtG9Ic6xDVmHHU73UkDNY6TTad/AT1PuBT8e/yE1gNV3V99ER7vkqLEjWzi1JRDP/dOzPHZ4PiowG2bs5Q9cYZJ1JomwZa5RM5l+wn+7CUf80XNlt3+lcNVYjZTpZaYqLgEzwJsbB3o0iBORv5bsApsl6XbYTkyBuorMHhf2dfbVykeDRv2qQfcxIVIUYCs0B+M0SLOZJkmG+3df8GRy2lLhYX0me8jzWwPAiZOEpTVpjkMaQtUFHEyBCyAgEnCWAj2ppj+Avw5jx2+qkSI4nyjMoKn0YKBauDTqT6jYfeTV/BK/XR7SZ+amM9kCO4lr5UyeBAqt4yc7vrzGrL+NGbsL412WnH+A0KVfo7TQUYPToe0+PPMfGZ/XT1xHsutXoPotewoz3SVXb3kzobrkUXKGi+C4z1Dz2uCxNCu70N9+KggWs4T2HAamhibz5y5vVtHKJMRwGISvJYPSz767c42N4dm8q3H8DVZlfLM5pFqr5Ex3NWXdXqJraf4rEWf1AlJVgPKP+6+o8mbXPY7fACRoQVgMpbeOCuhskK0ehJmc3D/jl7yssImgVGUL7b47nBOFXiP1dKBzJBq9JhwAaLxKDiEXpn8MEDFvDZNOHyK7WSstOJO91VotjidmSOba5NlTzVjwYW3OUGLYHmJxixcIzMyxzEPhcuPDlzAVI5hMJXHKhbInld6vajcLRF5JDSpymROGlnTTdOBRdECt3DaMTWURc0Ip9DWIq78x0XlMY5BQtt5uTNgR7ctE1oqdGpZR9joQI8QdljI7g7AOmrgcfW+qBGMjPXxi5G2sORjdbqxMCLuflIA0bCc4SiFCxcy+L2fMRekEGWT4zmsRWQLvar+w6XZQI1MjjD X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f12801fc-4e4e-4a4b-5740-08db0db22c4c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 11:05:10.4566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4ZaqpSR2YeSq7fyW37pb84Jh60+MgOSPt/cOUcPTFusTG/Gg9OJOCQm0ba02LUq4faa5gd80B9tJPGe19ZWxnTQX8puBo5SZyq4yDIJsji8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6355 On 13/02/2023 10:54 am, Xenia Ragiadakou wrote: > > On 2/13/23 12:09, Jan Beulich wrote: >> I keep forgetting why putting it on just the declaration isn't >> sufficient; I >> guess a short comment to that effect next to cf_check's definition in >> compiler.h would help). > > Yes, that would help. I don't know why it is not sufficient placing it > just in the declaration. Because it's part of the function's type. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 13 11:15:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 11:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494371.764410 (Exim 4.92) (envelope-from ) id 1pRWnP-0002sN-S9; Mon, 13 Feb 2023 11:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494371.764410; Mon, 13 Feb 2023 11:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWnP-0002sG-PS; Mon, 13 Feb 2023 11:14:55 +0000 Received: by outflank-mailman (input) for mailman id 494371; Mon, 13 Feb 2023 11:14:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRWnO-0002sA-Ps for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 11:14:55 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1846ca4-ab8f-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 12:14:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 64FC45C0090 for ; Mon, 13 Feb 2023 06:14:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 13 Feb 2023 06:14:49 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 13 Feb 2023 06:14:48 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1846ca4-ab8f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm3; t=1676286889; x=1676373289; bh=2pPy/nkWBs pmeK2LkD1hV1s6LzYbozDlDEjpya7pepI=; b=ly7fbWCyyKlvyYjOPTO+/77EQo R6LorCs5v3Msc2iF9DjEjuJZTh7nkyRPbBbJki9VWrNo/uR+w8xTUFiR0B28Q0UE gxkpqhmngSN1V1tqjLysOWZtCzhAm92XCXkp5u5Jt0BkbKc62eTy1ibnPFjrEl8X IjsGlDYgU2XlrBv7nTOR+kAMfgLIjDwB1s9kVYxfI7ti6YkBLs3lbfuUKdw2OVsN KK24m3EOKQm7w9cw7bR6YHTQbg9W1xCaHxTIk/giouD8UhFqvCldviQNMsgJInt4 c0EspIhLu20GeMxVHoS6Kx44oG7Zu/HivGxJ4bZ5tkdpEpoyXWY+Im8VXBjw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676286889; x= 1676373289; bh=2pPy/nkWBspmeK2LkD1hV1s6LzYbozDlDEjpya7pepI=; b=G 2GuprV1hRYSrPJtrKFb1Uk6QlRwS1xXeeyi9vOk1rAx4ixgK3Y9h/EcjOw/SNSRh 6stFs7nE0+FwevCpYTj3zcO2QTz3HFbRE4BEFWhx0FdwKXQbgZkqVEcXHcv5Kpxm EydMqSqRTJ0Ox+8hq2805Hc1ojG+j45kUX1eR4ryG9dY+QL5ZwdfFSSq+HDEYKK7 1wZRYult/iOcYPQYQKH6SadLK7jm6AkqNgilbIghAWGRPleK3FiggTsZRdzrXsja AwAyY2zjRY4AzrR6JdOfhT24PadgF1pg10AwMIlZv9vEX2U4WIbuUCGpsdPYUmcK mILiZiR+sHGul1dVEueyA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiuddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnhepvddviefgjefhvddvjeduueeihfdvvdffjeevieektdejueei ffetffefieethfefnecuffhomhgrihhnpehquhgsvghsqdhoshdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 13 Feb 2023 12:14:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: xen (multiboot) binary gets corrupted ELF notes Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dVeArZAaTGNr5ot0" Content-Disposition: inline --dVeArZAaTGNr5ot0 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Feb 2023 12:14:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel Subject: xen (multiboot) binary gets corrupted ELF notes Hi, I'm getting some ELF note issues on multiboot binary specifically: xen/xen: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statical= ly linked, BuildID[sha1]=3Df7d2c37a4ad599b268f2f2d94bff3776d12649b3, bad no= te description size 0xc0010001, stripped readelf additionally says: Displaying notes found in: .note Owner Data size Description GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bits= tring) Build ID: c5825a0d08edc4d11b1138fedca6b14ce8ba7302 (NONE) 0x00000004 Unknown note type: (0x00000020) description data: 05 00 00 00=20 readelf: xen/xen: Warning: note with invalid namesz and/or descsz found= at offset 0x34 readelf: xen/xen: Warning: type: 0x4, namesize: 0x00554e47, descsize: = 0xc0010001, alignment: 4 Grub doesn't care, but launching such xen with kexec doesn't work. Initially found when booting Xen via Heads: https://openqa.qubes-os.org/tes= ts/60151#step/install_startup/11 Andy says: > yeah, I've seen the same on XTF > binutil's recent elf notes for CET compatibility use an unsigned long > so they're not compatible when we build as 64bit and then re-package as 32 > I think we need to strip all elf notes in mkelf32 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --dVeArZAaTGNr5ot0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPqG6YACgkQ24/THMrX 1yz2sQf8DiPk02lMWZw13na//TKTCOvhhpeMlAGQUshmnXuaB7LcR2naFQw5owmW ayMzzF6p5ibGd4HPrM/9xDhtnaN5PpEVy4xG0OgSiBrCIqftMujcv91VIiofmpBW uGwr1niDQvoVCCNA2ziX2s4HDa8PlFmvrFi9GLJd7sis/8IaeT1zmfuosvAE0exV tkz7ARNnxkyzeYtK5eE593463xDXVSsZw0U7Fs+GAjfNl/DNBYhvqny9oD8ytFg3 b17MUX9RAztQUEzqDLVoQQWsu02TByLQpaTIiUdObQNodtdjWhPpie2zcG0KRaCb iMd4638oBX5pnvGKSf2HeeZFyQTLbA== =FEtz -----END PGP SIGNATURE----- --dVeArZAaTGNr5ot0-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 11:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 11:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494385.764421 (Exim 4.92) (envelope-from ) id 1pRXLs-0007ZN-FT; Mon, 13 Feb 2023 11:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494385.764421; Mon, 13 Feb 2023 11:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXLs-0007ZG-Cw; Mon, 13 Feb 2023 11:50:32 +0000 Received: by outflank-mailman (input) for mailman id 494385; Mon, 13 Feb 2023 11:50:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXLq-0007ZA-WF for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 11:50:31 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c093b08-ab94-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 12:50:28 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id s11so4749757edd.10 for ; Mon, 13 Feb 2023 03:50:28 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id m2-20020a50d7c2000000b004acc123cd94sm2203615edj.30.2023.02.13.03.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 03:50:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c093b08-ab94-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=n2mxQM8AfXBAOtKyCgkY32aLZkpJUAewws57G3RsRmI=; b=VUfQNEnHCnTri3t2mZcoK1h55MXBOHpAeHnNzZRWkWUcEJfqHN3q5Ipau0SsjZnvnO zWnv3D+IGz1DOR6HGphp4Y2O/mVpnR+hGrRLAStPjHGQyce+b728TgrqRsxZck5FtfcY 10f1HDmRIuvbJVAkWL8ACa3Kg6zLRAljqISF2gLWs2a6NNyBJ0aOtV5mJaN4WnPE5GEx s+HLwdsESmAgZlrZjRGO1k6zT+bOW0SJDVy7Y5HlkMAf/iHzyY4YSOs/0VP5p3sRS3ml 63ygFqkpHwqm5qDZWGw+Pbqwo/3IBWMSANa8LhujjsGvC999L+NKJgsM2JjHVPvbED24 rc2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n2mxQM8AfXBAOtKyCgkY32aLZkpJUAewws57G3RsRmI=; b=kEeQesqZasfZNXD0QN4LRtVjX1fPpKlCdMe3KRhFONEUhkEtiqP1Xs8Imbc44GMaF+ Zt86Rs2Ul8FdZ9F4/yUMYb7kK3F81i1+10zKQppKGOfFfXbBMx34JhXSrtn9LnDKZi/d CmSwM3AIh5p1XXogbMp6K8SL8Hje5L+IfSl4YUFchiAuLB/9geoMbdmqUvhpQg1o2H57 1dUsNq3PnEbhsQ1Q0qsicjfpRyb18/R3R4dCvpQ5z/sAzi9ozk5nlpkUdv3YVXJQmXzD quyxSOF3qlYP3sxUYmlCOqngVf3MIw9QD0OKY4n4U7YOsuQqvQX3Ywybq0eM6cs5wxao LxOw== X-Gm-Message-State: AO0yUKWU59441UXKyqo83WWnxyIlO6ur9NMLsBWeYhmQoftg6uCt3eyr YWpo/CaC4KaO773lJ9ltNOf7e9gQgfI= X-Google-Smtp-Source: AK7set+asvVOWytEm+NHo+OiJOZLfjd2ZzwBMTdzhJoPVfQaBEecQGxI+8XpSspMuBt+sgkXITMgsA== X-Received: by 2002:a50:d681:0:b0:4ac:bcf9:6d7e with SMTP id r1-20020a50d681000000b004acbcf96d7emr6865901edi.11.1676289027496; Mon, 13 Feb 2023 03:50:27 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Date: Mon, 13 Feb 2023 13:50:17 +0200 Message-Id: <20230213115017.902037-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit APIC virtualization support is currently implemented only for Intel VT-x. To aid future work on separating AMD-V from Intel VT-x code, instead of calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub to the hvm_function_table, named update_vlapic_mode, and create a wrapper function, called hvm_vlapic_mode(), to be used by common hvm code. After the change above, do not include header asm/hvm/vmx/vmx.h as it is not required anymore and resolve subsequent build errors for implicit declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including missing asm/hvm/trace.h header. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - add cf_check attribute in both the function declaration and definition of vmx_vlapic_msr_changed since it is used as callback, bug reported by Jan - initialize update_vlapic_mode in the vmx_function_table initializer to keep unconditionally initialized cbs in a single place, reported by Jan xen/arch/x86/hvm/vlapic.c | 6 +++--- xen/arch/x86/hvm/vmx/vmx.c | 3 ++- xen/arch/x86/include/asm/hvm/hvm.h | 7 +++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 +- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c index eb32f12e2d..dc93b5e930 100644 --- a/xen/arch/x86/hvm/vlapic.c +++ b/xen/arch/x86/hvm/vlapic.c @@ -37,8 +37,8 @@ #include #include #include -#include #include +#include #include #include #include @@ -1165,7 +1165,7 @@ int guest_wrmsr_apic_base(struct vcpu *v, uint64_t value) if ( vlapic_x2apic_mode(vlapic) ) set_x2apic_id(vlapic); - vmx_vlapic_msr_changed(vlapic_vcpu(vlapic)); + hvm_update_vlapic_mode(vlapic_vcpu(vlapic)); HVM_DBG_LOG(DBG_LEVEL_VLAPIC, "apic base msr is 0x%016"PRIx64, vlapic->hw.apic_base_msr); @@ -1561,7 +1561,7 @@ static int cf_check lapic_load_hidden(struct domain *d, hvm_domain_context_t *h) unlikely(vlapic_x2apic_mode(s)) ) return -EINVAL; - vmx_vlapic_msr_changed(v); + hvm_update_vlapic_mode(v); return 0; } diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 270bc98195..0ec33bcc18 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2763,6 +2763,7 @@ static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { .nhvm_vcpu_vmexit_event = nvmx_vmexit_event, .nhvm_intr_blocked = nvmx_intr_blocked, .nhvm_domain_relinquish_resources = nvmx_domain_relinquish_resources, + .update_vlapic_mode = vmx_vlapic_msr_changed, .nhvm_hap_walk_L1_p2m = nvmx_hap_walk_L1_p2m, .enable_msr_interception = vmx_enable_msr_interception, .altp2m_vcpu_update_p2m = vmx_vcpu_update_eptp, @@ -3472,7 +3473,7 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) vmx_vmcs_exit(v); } -void vmx_vlapic_msr_changed(struct vcpu *v) +void cf_check vmx_vlapic_msr_changed(struct vcpu *v) { int virtualize_x2apic_mode; struct vlapic *vlapic = vcpu_vlapic(v); diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 80e4565bd2..43d3fc2498 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -217,6 +217,7 @@ struct hvm_function_table { void (*handle_eoi)(uint8_t vector, int isr); int (*pi_update_irte)(const struct vcpu *v, const struct pirq *pirq, uint8_t gvec); + void (*update_vlapic_mode)(struct vcpu *v); /*Walk nested p2m */ int (*nhvm_hap_walk_L1_p2m)(struct vcpu *v, paddr_t L2_gpa, @@ -786,6 +787,12 @@ static inline int hvm_pi_update_irte(const struct vcpu *v, return alternative_call(hvm_funcs.pi_update_irte, v, pirq, gvec); } +static inline void hvm_update_vlapic_mode(struct vcpu *v) +{ + if ( hvm_funcs.update_vlapic_mode ) + alternative_vcall(hvm_funcs.update_vlapic_mode, v); +} + #else /* CONFIG_HVM */ #define hvm_enabled false diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 234da4a7f4..97d6b810ec 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -85,7 +85,7 @@ typedef enum { void vmx_asm_vmexit_handler(struct cpu_user_regs); void vmx_intr_assist(void); void noreturn cf_check vmx_do_resume(void); -void vmx_vlapic_msr_changed(struct vcpu *v); +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); struct hvm_emulate_ctxt; void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt); void vmx_realmode(struct cpu_user_regs *regs); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:24:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494397.764433 (Exim 4.92) (envelope-from ) id 1pRXsx-00034e-4X; Mon, 13 Feb 2023 12:24:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494397.764433; Mon, 13 Feb 2023 12:24:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXsx-00034X-1W; Mon, 13 Feb 2023 12:24:43 +0000 Received: by outflank-mailman (input) for mailman id 494397; Mon, 13 Feb 2023 12:24:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXsv-00034Q-6v for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:24:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1a::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 627a8d80-ab99-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 13:24:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7888.eurprd04.prod.outlook.com (2603:10a6:102:b9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 12:24:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 12:24:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 627a8d80-ab99-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TkpyWLfqCZjHbzy2DaTLa7+ogv0Ekka7HNNctKBMsupL26KLDKwf2iyJIgLY0LLzGwapgPFDN1ILFcCNEYvb3lToX+ue17bxY3o9XsehbU1U0J2Gx1GpKcdxgrABMnHSxFcOSuZWn0AV7PP8HQd/CFAoAxDj1XUc1/BxTZgCLWw17gsPcR9itH3kzRB31x42tRlzbY3tF4e/61iOLrTwhtjTiQKZAMvUwG5lJV3SteoVEisluyFZTMxoQTzUP/AX5j8nIwTQ49tiqp4MSx1yX6q68FsX+sL6o5m6nWgu4SYUHS946984cyBOYaNW8uDDPThH5/6rk5WWITvCslYfgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7YsjAhCBjbwcxdKKFnvaYX2fjq8yJPWPxAaiLi//Jfc=; b=f6c/BD0dodQhY3GeE/q/29EyREql7zgMMdANQIRIGSzgDfHtDCUjpcZxGWAU+OrAPLvp0RzatmSrp8GAKaq5W6phJGGW4XSZnOmgS4LPuRgTPtr2AyjumeoQxhY03+sqIe48tKJFkrxlXRkTcQWCbP2PtgzVl7h55EgLpMEdIclz8Ytn/TZfPJDjc74aZ+w6KoWqx04G8hdegKPprDpHksPQEOO/kOCGzaXyodPvWwubqIBIdnTdyG9Pfsd8TNzU3JdqLvxvp0ow8wlCI6B0gNCxFewKvYH0diM1JCsoUuVYVQOBJAz2mSJ+7Ir1YB66DhAvwo5UrPhib8PN8Xb0aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7YsjAhCBjbwcxdKKFnvaYX2fjq8yJPWPxAaiLi//Jfc=; b=xs0P5DP69zXD1c3czTuIo8yoiMSDXJaWCMT7YIBkTg9hzB+y8ma5UWyaBr3JIqlXSuBj1nXei1Atd3HUifan0e/V+XMdPHFUzoFFLjdOgwu/9NR7wrTqz0arvVzNH1TQrl54g5yxXTB0qVM2EXNGCRmbfn2Ct0WqqhM0WlU1057rGgS/Dulxb8dhe5OkwGQRgOTJ2vWbh/tGGy4dx1IZPhY2yxvUI1Jbn6BxYdNQOH1ZOnNgiwRO5tmWSu3oKg5jYVbJ2ky4e/sI5oERbxndgazOrbda8dyi81/K/59GHgOcXTPThBdPWCSibUuJbUXZSePxRlWgpV+SkcY9i9KJ9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> Date: Mon, 13 Feb 2023 13:24:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7888:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e79e9ab-0cff-4137-24bc-08db0dbd456f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S9IDMKI287TOj765tExJ2keVAOK60eLF9lVQ2FqyNkIgeUt0xPtRs1hlfLsYHIqaW/WQo5IQ7W9vW7bXSs/GokPHV0/iK1ag9Nc9fqBI/8lbdpL93ylvPuN/1LE4lTulXAPfXM9eYUzg2tZpBBVzG354lg/76s+LpYCAeeeNBmBCzF/DGzP6ysZ/zCq3ICb00AHtiXG/elroTO4ejVjRmx6xvHRqvA85SSqOZ3+2r1GTzYLaecOess5sxK+zosL9ZwnT6YDTijTboQePRzGqLGl3CT2Cv56EBGm4UmQmkfOgp7qsjyd5KGq26n6lO6lANe6HAeowcBP+FAFUEMz3Y0vcj+AGQqQ/DoaS+KuCdmCsYDdyRsPqhu+IoOiSqJHfoRXtBrr5d3cf7+qcjwyOxZWUIkmDYu9GzTINVXc/SAw9SO9Urk9ZqqbBKzbaBJ7MzwKUPNUw8asUONiIwkPFuljwBxuqUpzR6eUN+mrVZjB8rXtirR9CoTbE9Pex0ShaIpJ4QAkiKCkeVBU5jTq8Pb/Q5aB9xWuNcv56u9gCjj+ELKwEVPDGxYftKzuVnqmk+5H+DluvrUiuy2UoJ/WuSx/OnUCmPBQMsmddBhQ66XhsOza3danD5abjIAnnUklwtEarRIwhmiOQZALjc2ojmN7IBBPzecUoQ+2GC58C8JGcbSQt6HARNbIeAka0XfI0K53a2XBIHn2atcysYksDwJizy8DCCd/XuCSUsz7FRg1kPdUMUEC6OdN0tIQJE54Z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199018)(31686004)(6512007)(83380400001)(186003)(26005)(36756003)(5660300002)(2906002)(53546011)(31696002)(6506007)(86362001)(41300700001)(478600001)(6486002)(2616005)(66556008)(54906003)(8936002)(66476007)(316002)(6916009)(38100700002)(8676002)(66946007)(4326008)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXdqQmdoMnFxalJzY2pDY2JCL3RYVmk2ZVJmZFg0YTE2dXQ1Q2hzV21HQzkw?= =?utf-8?B?eVNreUhoRW02Vmt4OStuOTdQZitsWU5DbEZSNmFSV2lHTEZ2SWdSMUd5MzMw?= =?utf-8?B?bUx5TVYwa1VnR29ndnJtaEsweVhxN29vbWVoeXZtMk1jN3NvZzFKTGhwNzB3?= =?utf-8?B?cnVjRmdnRHhNeHcwWjgvKzJPMUo5WlF5Q2lrQVNCdEdneHRhNlpmOFV2a05z?= =?utf-8?B?RGVNVzlnTkN2NkNOMEYyeWh5aitCZHErMVo3enNnK0RFdi9jZm9zRkZMVGMx?= =?utf-8?B?NWtjNHdRL3gwb2Y1Z29JMFhxbXpiSy9LclhtSVBncnF0bnVCQTZzNVZRU0ln?= =?utf-8?B?UWJnb1BobzNJUzEzOGVIRzU5a2g3ZlhmTEhFMWdXd3VneHV2a3JyMDBMaXM5?= =?utf-8?B?SUtRY1Ztb2EyeTBJZ09BREtQWldyT0xBYjBmWkxEdTFBdEtpMCtCL0lkVjJL?= =?utf-8?B?c3hwOEc2OWgra3Q5UmVHK0ZTWnJYU1hMV1lZWkJpWkp4UEd1NGVpeUM0WSt1?= =?utf-8?B?d2IrOWdmUEhTUmtqRjJrcGJGSW9kekZkdk1MLzg4aFRkc3FmdVZRaU9Gb2Vy?= =?utf-8?B?ZG9wNm5MSm9rdit1U29jYjdHUThDNmkvMklzUGk1RlhEK2ZtZlV3NmdydFJ5?= =?utf-8?B?eFlrcVZaZktiNTNLTzh3UCtldU5OaTVyQ1R4TEcwZHB0eGhCK1FqWWRmSXl5?= =?utf-8?B?WGxhMVdoKzJDS1ljUWpWN2hNRVlCdFVVSkpnQ09DdEVydDBHR2hkQnFMVm5C?= =?utf-8?B?UE1yMldid0cxT2xzczV5dTU0SnJIbjAxYUs0UlpkdWJtSHlOb2dZdDZUZml2?= =?utf-8?B?OXpFTjFoK1RkRUpmQWdvOURJTUxKK05sSzhIUjVITGp2NkZvNkc3WTk1eklW?= =?utf-8?B?dm9HbnAyZ1ZaaktmOVY4bzZyU01DSVFKb0ZmckhjbEErWko2UUhsUm51NEd3?= =?utf-8?B?NkwxMFVwdWRic1l2cDgwRXVOak92NG53dWlwWmlLbzBlOXp6UGIyNUlUMlFa?= =?utf-8?B?OEI4WFlnaVRCblJqcXVoUzFkRzlXMGM5b2wzNGJzVzBEMEpqUmUzM0dUUnpV?= =?utf-8?B?RTdDODY3ZUJid2xHUkVTYkk4WVprQnVTbUM0c1lqc1lneXFsUkx5enJhaFNE?= =?utf-8?B?cmJxUit0ZWVBbG1GcHFYUFhvc2t2UzZZd2plSEFLLzBXNnMrMElrQy9Ld0Nq?= =?utf-8?B?RzNCaDQrSzA0dERja0RhemEya3kwditlMmF5RU1qWVZuaEZia05KTlJmUDdT?= =?utf-8?B?ajV5Z0l6TmZaRGNYeG5PTWZIUU9lSUlGUGp4QzFjVHY1eVZCSTZ5Z0lGT2ZE?= =?utf-8?B?T1VOanFwanZEb1R6OGcwM3BRNS85Mkg5bVNubU5qc2JIVnhLREVzYUUzSjV1?= =?utf-8?B?WVVFVVBsMjhZRHpnVG1LeVZEUDRFMkFYdDVGa25hdFhsWW5ZOVVrcXRPYTNh?= =?utf-8?B?dEVaWDBqT2RQc2g2SE1KM0hRTTYwREJTckpHd3ZDUEl2dVJZNHR5NS96UlNt?= =?utf-8?B?RXB1ZUNBL1U4aDJISjFLaW0yWE9qdjRkcHBpVXlxaEN3NkF6bUhkSHY1QzFq?= =?utf-8?B?TnZuR2p6aXpOOU1wNmJlNGQreHpEL3U0ZWt5cDBxWnc0RDdmOTN0MkdpSkFH?= =?utf-8?B?NWY3STgrSWJ1U1UwdWNiaFV1RS90UlNXdUoxa1kwRUxSWk9VenY3S2RhRXhF?= =?utf-8?B?endiYzZVeHB1c3VMWUdWd2FEeVZlM3FkbkIzMnA2RkcxZjBCRU9wWXJVSFpL?= =?utf-8?B?Sll2b01hQWE4a1p6R3R1SmJMUDZSYUtIZTZaU2pmWHlVRDR3RU9CZnFuTkVs?= =?utf-8?B?ekFzSlRFdEdWallXK2J1MlB3R3lweDFJTzlvUHFyOElxb2lnWHhuOUx4WlI1?= =?utf-8?B?ekpVNmpTVVNBT1J6U1JiZDl1WlRwVytYTTlWY1QwOWhqWnZUQnR0alIrQnZQ?= =?utf-8?B?bnNrS0hlZUNEMlNPSkZ1UGp2bGNvWTI4dlJPZmNYQmVWdlFvM2ZrcXZCMElC?= =?utf-8?B?ZGpQMFlRVS9SMWNNdmpFNFBleTRDYWliT3RzTm94V0NRc2JzY2NONk9IWVd1?= =?utf-8?B?MldPZXlCeVRQaWdPTEM5dGxON1YvYlZJcC9yenp4Wkc1WCt1djNoQVJEUzlr?= =?utf-8?Q?eEyA6btqfIIkrNuJ5rVAhZSsV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e79e9ab-0cff-4137-24bc-08db0dbd456f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:24:36.9042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 274Rcgwt/UCWAqXcHN48FWd4OZZ/gWA854JZs6SSlCzKit344jCTzAzObx1zCoqup1lzeAcQJdTuERMTl7+Mhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7888 On 03.02.2023 18:05, Oleksii Kurochko wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -92,6 +92,12 @@ config STATIC_MEMORY > > If unsure, say N. > > +config GENERIC_DO_BUG_FRAME > + bool > + help > + Generic do_bug_frame() function is needed to handle the type of bug > + frame and print an information about it. Generally help text for prompt-less functions is not very useful. Assuming it is put here to inform people actually reading the source file, I'm okay for it to be left here, but please at least drop the stray "an". I also think this may want moving up in the file, e.g. ahead of all the HAS_* controls (which, as you will notice, all have no help text either). Plus finally how about shorter and more applicable GENERIC_BUG_FRAME - after all what becomes generic is more than just do_bug_frame()? > --- /dev/null > +++ b/xen/common/bug.c > @@ -0,0 +1,88 @@ > +#include > +#include > +#include > +#include Please order headers alphabetically unless there's anything preventing that from being done. > +#include > +#include > + > +#include > + > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like environments that's redundant with "unsigned long", and it's also redundant with C99's uintptr_t. Hence when seeing the type I always wonder whether it's really a host virtual address which is meant (and not perhaps a guest one, which in principle could differ from the host one for certain guest types). In any event the existence of this type should imo not be a prereq to using this generic piece of infrastructure. > +{ > + const struct bug_frame *bug = NULL; > + const char *prefix = "", *filename, *predicate; > + unsigned long fixup; > + int id = -1, lineno; For both of these I question them needing to be of a signed type. > + const struct virtual_region *region; > + > + region = find_text_region(pc); > + if ( region ) > + { > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + const struct bug_frame *b; > + unsigned int i; > + > + for ( i = 0, b = region->frame[id].bugs; > + i < region->frame[id].n_bugs; b++, i++ ) > + { > + if ( ((vaddr_t)bug_loc(b)) == pc ) Afaics this is the sole use of bug_loc(). If so, better change the macro to avoid the need for a cast here: #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > --- /dev/null > +++ b/xen/include/xen/bug.h > @@ -0,0 +1,127 @@ > +#ifndef __XEN_BUG_H__ > +#define __XEN_BUG_H__ > + > +#define BUG_DISP_WIDTH 24 > +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > + > +#define BUGFRAME_run_fn 0 > +#define BUGFRAME_warn 1 > +#define BUGFRAME_bug 2 > +#define BUGFRAME_assert 3 > + > +#define BUGFRAME_NR 4 > + > +#ifndef __ASSEMBLY__ > + > +#include > +#include > +#include > +#include Again - please sort headers. > +#include > + > +#ifndef BUG_FRAME_STUFF > +struct bug_frame { Please can we have a blank line between the above two ones and then similarly ahead of the #endif? > + signed int loc_disp; /* Relative address to the bug address */ > + signed int file_disp; /* Relative address to the filename */ > + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ > + uint16_t line; /* Line number */ > + uint32_t pad0:16; /* Padding for 8-bytes align */ Already the original comment in Arm code is wrong: The padding doesn't guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes size. Aiui there's also no need for 8-byte alignment anywhere here (in fact there's ".p2align 2" in the generator macros). I also wonder why this needs to be a named bitfield: Either make it plain uint16_t, or if you use a bitfield, then omit the name. > +}; > + > +#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > +#define bug_file(b) ((const void *)(b) + (b)->file_disp); > +#define bug_line(b) ((b)->line) > +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) > +#endif /* BUG_FRAME_STUFF */ > + > +#ifndef BUG_FRAME > +/* Many versions of GCC doesn't support the asm %c parameter which would > + * be preferable to this unpleasantness. We use mergeable string > + * sections to avoid multiple copies of the string appearing in the > + * Xen image. BUGFRAME_run_fn needs to be handled separately. > + */ When generalizing the logic, I wonder in how far the comment doesn't want re-wording some. For example, while Arm prefixes constant insn operands with # (and x86 uses $), there's no such prefix in RISC-V. At which point there's no need to use %c in the first place. (Which in turn means x86'es more compact representation may also be usable there. And yet in turn the question arises whether RISC-V wouldn't better have its own derivation of the machinery, rather than trying to generalize things. RISC-V's would then likely be closer to x86'es, just without the use of %c on asm() operands. Which might then suggest to rather generalize x86'es variant down the road.) At the very least the comment's style wants correcting, and in the first sentence s/doesn't/don't/. Also %c isn't a parameter, but a modifier. > +#define BUG_FRAME(type, line, file, has_msg, msg) do { \ > + BUILD_BUG_ON((line) >> 16); \ > + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ > + asm ("1:"BUG_INSTR"\n" \ Nit: Style (missing blank after opening parenthesis, and then also at the end of the construct ahead of the closing parenthesis). > + ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ > + "2:\t.asciz " __stringify(file) "\n" \ file is always a string literal; really it always is __FILE__ in this non-x86 implementation. So first preference ought to be to drop the macro parameter and use __FILE__ here (same then for line vs __LINE__). Yet even if not done like that, the __stringify() is largely unneeded (unless we expect file names to have e.g. backslashes in their names) and looks somewhat odd here. So how about "2:\t.asciz \"" __FILE__ "\"\n" ? But wait - peeking ahead to the x86 patch I notice that __FILE__ and __LINE__ need to remain arguments. But then the second preference would still be "2:\t.asciz \"" file "\"\n" imo. Yet maybe others disagree ... > + "3:\n" \ > + ".if " #has_msg "\n" \ > + "\t.asciz " #msg "\n" \ > + ".endif\n" \ > + ".popsection\n" \ > + ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ > + "4:\n" \ > + ".p2align 2\n" \ > + ".long (1b - 4b)\n" \ > + ".long (2b - 4b)\n" \ > + ".long (3b - 4b)\n" \ > + ".hword " __stringify(line) ", 0\n" \ Hmm, .hword. How generic is support for that in assemblers? I notice even very old gas has support for it, but architectures may not consider it two bytes wide. (On x86, for example, it's bogus to be two bytes, since .word also produces 2 bytes of data. And indeed MIPS and NDS32 override it in gas to produce 1 byte of data only, at least in certain cases.) I'd like to suggest to use a fourth .long here, and to drop the padding field from struct bug_frame in exchange. Furthermore, once assembly code is generalized, you need to pay attention to formatting: Only labels may start at the beginning of a line; in particular directives never should. > + ".popsection"); \ > +} while (0) Nit: Style (missing blanks, and preferably "false" instead of "0"). > +#endif /* BUG_FRAME */ > + > +#ifndef run_in_exception_handler > +/* > + * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the > + * flag but instead rely on the default value from the compiler). So the > + * easiest way to implement run_in_exception_handler() is to pass the to > + * be called function in a fixed register. > + */ > +#define run_in_exception_handler(fn) do { \ Nit: Just one blank please after #define (and on the first comment line there's also a double blank where only one should be). > + register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); \ x86 makes sure "fn" is of correct type. Arm doesn't, which likely is a mistake. May I ask that you use the correct type here (which is even better than x86'es extra checking construct): register void (*fn_)(struct cpu_user_regs *) asm(__stringify(BUG_FN_REG)) = (fn); > + asm ("1:"BUG_INSTR"\n" \ > + ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," \ > + " \"a\", %%progbits\n" \ > + "2:\n" \ > + ".p2align 2\n" \ > + ".long (1b - 2b)\n" \ > + ".long 0, 0, 0\n" \ > + ".popsection" :: "r" (fn_)); \ > +} while (0) > +#endif /* run_in_exception_handler */ > + > +#ifndef WARN > +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") > +#endif /* WARN */ > + > +#ifndef BUG > +#define BUG() do { \ > + BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ > + unreachable(); \ > +} while (0) > +#endif > + > +#ifndef assert_failed > +#define assert_failed(msg) do { \ > + BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ > + unreachable(); \ > +} while (0) > +#endif > + > +extern const struct bug_frame __start_bug_frames[], > + __stop_bug_frames_0[], > + __stop_bug_frames_1[], > + __stop_bug_frames_2[], > + __stop_bug_frames_3[]; > + > +#else /* !__ASSEMBLY__ */ > + > +#ifdef CONFIG_X86 > +#include > +#endif Why this x86 special? (To be precise: Why can this not be done uniformly?) Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:28:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:28:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494403.764443 (Exim 4.92) (envelope-from ) id 1pRXwW-0003gv-JP; Mon, 13 Feb 2023 12:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494403.764443; Mon, 13 Feb 2023 12:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXwW-0003go-Gq; Mon, 13 Feb 2023 12:28:24 +0000 Received: by outflank-mailman (input) for mailman id 494403; Mon, 13 Feb 2023 12:28:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXwV-0003ge-85; Mon, 13 Feb 2023 12:28:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXwV-0004xI-54; Mon, 13 Feb 2023 12:28:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRXwU-0005tB-UE; Mon, 13 Feb 2023 12:28:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRXwU-0003bk-Tj; Mon, 13 Feb 2023 12:28:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mdHlC45r5Nk1nUX62DmNUhwdMs/GGJJI5ASACvDpLfs=; b=wF0Jr4iVGyK9ZC/m7H9eOoUS4w G/oAa5aZBBF5oAaBODSn6K7eFBLlNQ929GSCSSe9Acq/xdUrIIcKmVgVZHrem2X00OUIdHSsjTHcX vo2oVI3iyPXDwfiEf+Jm+AQM6MmtaK9iwV/EBVTDsEWsyYJfZoiC2BrZ327mhcrS6gpA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177160: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f4f498d08d50259b9f25c274fd7b1e8ccf5693af X-Osstest-Versions-That: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 From: osstest service owner Date: Mon, 13 Feb 2023 12:28:22 +0000 flight 177160 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177160/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f4f498d08d50259b9f25c274fd7b1e8ccf5693af baseline version: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Last test of basis 176840 2023-02-10 09:02:03 Z 3 days Testing same since 177160 2023-02-13 10:03:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Andrew Cooper Jan Beulich Juergen Gross Oleksii Kurochko jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 01e7477d1b..f4f498d08d f4f498d08d50259b9f25c274fd7b1e8ccf5693af -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:45:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494414.764466 (Exim 4.92) (envelope-from ) id 1pRYCj-0006cC-A5; Mon, 13 Feb 2023 12:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494414.764466; Mon, 13 Feb 2023 12:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCj-0006c1-7J; Mon, 13 Feb 2023 12:45:09 +0000 Received: by outflank-mailman (input) for mailman id 494414; Mon, 13 Feb 2023 12:45:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCh-0006bE-LD for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:45:07 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062d.outbound.protection.outlook.com [2a01:111:f400:7e8a::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d50cf24-ab9c-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 13:45:06 +0100 (CET) Received: from DM6PR08CA0033.namprd08.prod.outlook.com (2603:10b6:5:80::46) by DS7PR12MB5767.namprd12.prod.outlook.com (2603:10b6:8:76::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 12:45:02 +0000 Received: from DM6NAM11FT104.eop-nam11.prod.protection.outlook.com (2603:10b6:5:80:cafe::63) by DM6PR08CA0033.outlook.office365.com (2603:10b6:5:80::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 12:45:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT104.mail.protection.outlook.com (10.13.173.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 12:45:02 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:45:02 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:45:01 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 06:45:00 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d50cf24-ab9c-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iYQKX4/gKMefQGovOPM2spOFhzCZ+IPIXWbHYXbYSu2jLmmr5HeQDuQVCosRKsifKVphZ5deaXEvViOUFzTvqEf8pSkSMptWLVH/mxE29VakIHrwsGrHf3x3Y771ZVtDiSYt7ixhFaIvO0wSAPL2nvTLwgkQSZBW0tK1QIQsxmitOm4DittoATw3+aQY2bznTEQ90kFMMgbpcsi7PJgSFjAr06rLDY3oHDDiqIcvXEsa54tq31F5yfnm8owXYLOM9jmxPIuNnBJvXQvdtw4J/RvJxDMNbrQV938jdyGekGB5WmS+CAtAnD9hSYP5LcA1KA34YeW8apukDLgeDnvPTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zlgQKmohEtacQnMD+bkEbzo8njZdJKjN33VbXURvNlw=; b=mdNQ+AXkWgB5RMNfMlyHtvGGYUePJ1wr/EWHzCgg2HoSzmjT7o63iGcfKgB0GdZGJBW11QKjs2dJHSIeWEaKKyF1mHi/e0XNKuHLPYad6jFRffxNQFKlf3HF1Y+g3QtIxdliJtoepu5BA6fX8EkTnXon4BX7cdyA6KfBHWGfqOwXyymJl1bgi7KhuXzFaP5y3M9oJL5gngb9MiqjN9Tz5wEUn+pnOTvD4F1Z4uvGOm+0c3DPzm6T72gfcyG0jq7lOt0XnnX1qjRFJ5WCYQv3VaAOycrrdkxCho6arXcwagAXgFHrmT6pYifCCt6S3jF6M/3NVKubmZTip3kt9WGpow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zlgQKmohEtacQnMD+bkEbzo8njZdJKjN33VbXURvNlw=; b=i5Gt7gT14si+2KvZDS4l/z7tdIrF8XrZ9XX6cQzdr2TF006G9YQPbRsLIaf6jRhRlC41f9JUScLasXu9Lojnvh/DDlNeqmE2u6NWZdG4G0/AaFskoOsnzdPcRXI9nEAm9DeawvC5w7SchlmqbZDfsVTn1NbSTtBGYhqCFxOOJes= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , Ayan Kumar Halder Subject: [XEN v6 1/2] xen/arm: Use the correct format specifier Date: Mon, 13 Feb 2023 12:44:37 +0000 Message-ID: <20230213124438.14836-2-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230213124438.14836-1-ayan.kumar.halder@amd.com> References: <20230213124438.14836-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT104:EE_|DS7PR12MB5767:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a442292-dd86-4c50-30ea-08db0dc02017 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W1GGhl4MfXQNiChkqe55syZHNEOryg8QShW1KeBWvGgLVkTddDtDZSwveab6gX1euA0IMq53uBr8kuEFi2Cmg4+kntHM433lBvegfvlm0k414oa1/Ke+z/pMIU9b4kgaMVxaqICh9Ojz5R60yelWCTppbbdtX2zBbwmtNzYdz9HIfF3zWMPc73JTSx+1FXUIkxiQdLik+6NbN1JNMnzVUNYkzpAIubCjOpP1QwstAReY4cnrmjTv03dtsmm+kjuZ1ztC9y6FE/9wDp1NBqKVjcFnBuOVYLNJ+JBlvTKTPOZ+0CO2SonYHlvGNyNnFSiGmOMV1ROpP2qyvVWa3M5yOvEOdEDQ1SGp8PhyGILzVyTTxN15iBHj/+QFf2g+Rn1JD+3j3b+nPKOrQDxy+Ho4HA5zQhtsL7l5s4X1pAYVJjbmGWsVvDuQZ7WxAcpUtkmz5yFuZ6NAbi4myZNdnB5/7PLjpEjEkWd9JUAXQdJnFdaFGqzpeDcU3Ey+WooZR+15bslpEEe9NZiXjOaD+C5Jd7w8JARMHqB3w+E6IgfHlJVhCZF165A72TKrWezwVAwgA3VWyIkJlkAp8r4EvrrkMqPM9/QBD3INTH/dekDRqAYLPaNYHCCbEdp47nFb3xF9L+vZ6w/szYfvndqQDRo9dDF2xGlLkjEDo0MIXV/fQuTUOjkSGV7SjMKgl4JF3rAeRSBn6c/cwIbTKmb+K3qw1ST3Vrk0fZmkc1AQjA05Uts0XD9M3PzeQrGAFcOYe+/q X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199018)(46966006)(36840700001)(40470700004)(6666004)(81166007)(2616005)(1076003)(356005)(83380400001)(40460700003)(478600001)(966005)(26005)(186003)(336012)(86362001)(47076005)(82310400005)(426003)(82740400003)(2906002)(8936002)(5660300002)(54906003)(40480700001)(316002)(103116003)(8676002)(36756003)(4326008)(41300700001)(36860700001)(70206006)(6916009)(70586007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:45:02.5548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a442292-dd86-4c50-30ea-08db0dc02017 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT104.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5767 1. One should use 'PRIpaddr' to display 'paddr_t' variables. However, while creating nodes in fdt, the address (if present in the node name) should be represented using 'PRIx64'. This is to be in conformance with the following rule present in https://elinux.org/Device_Tree_Linux . node names "unit-address does not have leading zeros" As 'PRIpaddr' introduces leading zeros, we cannot use it. So, we have introduced a wrapper ie domain_fdt_begin_node() which will represent physical address using 'PRIx64'. 2. One should use 'PRIx64' to display 'u64' in hex format. The current use of 'PRIpaddr' for printing PTE is buggy as this is not a physical address. Signed-off-by: Ayan Kumar Halder Reviewed-by: Stefano Stabellini Acked-by: Julien Grall --- Changes from - v1 - 1. Moved the patch earlier. 2. Moved a part of change from "[XEN v1 8/9] xen/arm: Other adaptations required to support 32bit paddr" into this patch. v2 - 1. Use PRIx64 for appending addresses to fdt node names. This fixes the CI failure. v3 - 1. Added a comment on top of domain_fdt_begin_node(). 2. Check for the return of snprintf() in domain_fdt_begin_node(). v4 - 1. Grammatical error fixes. v5 - 1. Added R-b and A-b. xen/arch/arm/domain_build.c | 64 +++++++++++++++++++++++-------------- xen/arch/arm/gic-v2.c | 6 ++-- xen/arch/arm/mm.c | 2 +- 3 files changed, 44 insertions(+), 28 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c2b97fa21e..a798e0b256 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1288,6 +1288,39 @@ static int __init fdt_property_interrupts(const struct kernel_info *kinfo, return res; } +/* + * Wrapper to convert physical address from paddr_t to uint64_t and + * invoke fdt_begin_node(). This is required as the physical address + * provided as part of node name should not contain any leading + * zeroes. Thus, one should use PRIx64 (instead of PRIpaddr) to append + * unit (which contains the physical address) with name to generate a + * node name. + */ +static int __init domain_fdt_begin_node(void *fdt, const char *name, + uint64_t unit) +{ + /* + * The size of the buffer to hold the longest possible string (i.e. + * interrupt-controller@ + a 64-bit number + \0). + */ + char buf[38]; + int ret; + + /* ePAPR 3.4 */ + ret = snprintf(buf, sizeof(buf), "%s@%"PRIx64, name, unit); + + if ( ret >= sizeof(buf) ) + { + printk(XENLOG_ERR + "Insufficient buffer. Minimum size required is %d\n", + (ret + 1)); + + return -FDT_ERR_TRUNCATED; + } + + return fdt_begin_node(fdt, buf); +} + static int __init make_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, @@ -1296,8 +1329,6 @@ static int __init make_memory_node(const struct domain *d, unsigned int i; int res, reg_size = addrcells + sizecells; int nr_cells = 0; - /* Placeholder for memory@ + a 64-bit number + \0 */ - char buf[24]; __be32 reg[NR_MEM_BANKS * 4 /* Worst case addrcells + sizecells */]; __be32 *cells; @@ -1314,9 +1345,7 @@ static int __init make_memory_node(const struct domain *d, dt_dprintk("Create memory node\n"); - /* ePAPR 3.4 */ - snprintf(buf, sizeof(buf), "memory@%"PRIx64, mem->bank[i].start); - res = fdt_begin_node(fdt, buf); + res = domain_fdt_begin_node(fdt, "memory", mem->bank[i].start); if ( res ) return res; @@ -1375,16 +1404,13 @@ static int __init make_shm_memory_node(const struct domain *d, { uint64_t start = mem->bank[i].start; uint64_t size = mem->bank[i].size; - /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ - char buf[27]; const char compat[] = "xen,shared-memory-v1"; /* Worst case addrcells + sizecells */ __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; __be32 *cells; unsigned int len = (addrcells + sizecells) * sizeof(__be32); - snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); - res = fdt_begin_node(fdt, buf); + res = domain_fdt_begin_node(fdt, "xen-shmem", mem->bank[i].start); if ( res ) return res; @@ -2716,12 +2742,9 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo) __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2]; __be32 *cells; const struct domain *d = kinfo->d; - /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */ - char buf[38]; - snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, - vgic_dist_base(&d->arch.vgic)); - res = fdt_begin_node(fdt, buf); + res = domain_fdt_begin_node(fdt, "interrupt-controller", + vgic_dist_base(&d->arch.vgic)); if ( res ) return res; @@ -2771,14 +2794,10 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo) int res = 0; __be32 *reg, *cells; const struct domain *d = kinfo->d; - /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */ - char buf[38]; unsigned int i, len = 0; - snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64, - vgic_dist_base(&d->arch.vgic)); - - res = fdt_begin_node(fdt, buf); + res = domain_fdt_begin_node(fdt, "interrupt-controller", + vgic_dist_base(&d->arch.vgic)); if ( res ) return res; @@ -2858,11 +2877,8 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo) __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; __be32 *cells; struct domain *d = kinfo->d; - /* Placeholder for sbsa-uart@ + a 64-bit number + \0 */ - char buf[27]; - snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr); - res = fdt_begin_node(fdt, buf); + res = domain_fdt_begin_node(fdt, "sbsa-uart", d->arch.vpl011.base_addr); if ( res ) return res; diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 61802839cb..5d4d298b86 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -1049,7 +1049,7 @@ static void __init gicv2_dt_init(void) if ( csize < SZ_8K ) { printk(XENLOG_WARNING "GICv2: WARNING: " - "The GICC size is too small: %#"PRIx64" expected %#x\n", + "The GICC size is too small: %#"PRIpaddr" expected %#x\n", csize, SZ_8K); if ( platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) ) { @@ -1280,11 +1280,11 @@ static int __init gicv2_init(void) gicv2.map_cbase += aliased_offset; printk(XENLOG_WARNING - "GICv2: Adjusting CPU interface base to %#"PRIx64"\n", + "GICv2: Adjusting CPU interface base to %#"PRIpaddr"\n", cbase + aliased_offset); } else if ( csize == SZ_128K ) printk(XENLOG_WARNING - "GICv2: GICC size=%#"PRIx64" but not aliased\n", + "GICv2: GICC size=%#"PRIpaddr" but not aliased\n", csize); gicv2.map_hbase = ioremap_nocache(hbase, PAGE_SIZE); diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index f758cad545..b99806af99 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -263,7 +263,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr, pte = mapping[offsets[level]]; - printk("%s[0x%03x] = 0x%"PRIpaddr"\n", + printk("%s[0x%03x] = 0x%"PRIx64"\n", level_strs[level], offsets[level], pte.bits); if ( level == 3 || !pte.walk.valid || !pte.walk.table ) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:45:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494413.764456 (Exim 4.92) (envelope-from ) id 1pRYCd-0006LU-10; Mon, 13 Feb 2023 12:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494413.764456; Mon, 13 Feb 2023 12:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCc-0006LN-RR; Mon, 13 Feb 2023 12:45:02 +0000 Received: by outflank-mailman (input) for mailman id 494413; Mon, 13 Feb 2023 12:45:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCb-0006LH-Lr for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:45:01 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37608525-ab9c-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 13:44:56 +0100 (CET) Received: from BL6PEPF00013E12.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1001:0:16) by CH0PR12MB5089.namprd12.prod.outlook.com (2603:10b6:610:bc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 12:44:52 +0000 Received: from BL02EPF000108EB.namprd05.prod.outlook.com (2a01:111:f403:f903::) by BL6PEPF00013E12.outlook.office365.com (2603:1036:903:4::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.28 via Frontend Transport; Mon, 13 Feb 2023 12:44:52 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL02EPF000108EB.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 12:44:51 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:44:51 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 06:44:49 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37608525-ab9c-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AiX1bjzQpZZt4X7+1+AI7eEFiK3T7PxHR+4aLVa3I1z3o9kSIMeEFKNUEoxUQpkIol3OaS5HgeBRbFV9uD4WK0ggIgwXrfk6UVa42DmgWBfyEH8xTB314yyqTHOpWLp8MUFzPXAPishr8W7rfgDEJ6taTmRfTW9sKZi/Db0TpCbTnIop8Y0TGpZeTvaEWzEUDdksDGHYGNxdoD5VS3rvlH3HV7oFVvN5cPRW9O7HfvfkebvUS69jhej/34+DG9C7SFB3jrJL+XrqnTF1JIgBZPo1A930uueIPRSGOgh7C9ladM6iGOP590TxgFtjTCJ3raBCQIA+aBe1MUz+Bt58Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a89X8gZImurmuVKLyGhjWmjmcdOeuEuc/3vmxTUjv70=; b=izGXhDe6EH8N5NHQNQymGMgss0rPj9kg0cqmGP62pmDths9mlJ9UfHdNKaHeZsNY5uTOK6q3fGOcuKPTNFkMCVNBVgc/XJiMJyupQkp6gG1WCiftH57MDbBYoLXD5LTmLniHOMVk/wUIYl15e6HInBSY4t0rKP7RrDA+SO0pt7+J1W4jAibYxH2TgwMUg2Aw/nauqif+z6AeDtjEGLBfVwrWVjDCI0psBgkEXxPKFEn7rg0PKvdENYCPBlfW3Y1TSyxSDaKGy7ds37ERt5VztHUJEKsdEPoUPEBhdnwAeqNpJaXzXoXj3OPsagIeEEjnFNv1niD1+D5rQWFBQaz6Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a89X8gZImurmuVKLyGhjWmjmcdOeuEuc/3vmxTUjv70=; b=KhO9zWt6of52Jk2vJasPKYErk13rfK8IJYlF00GNL1zJ0YWcbQLQvjlyXrBfaRd5EroIziNOfshUUdfJu+ptB8N4+f8rkFxK/mcdSNhoeI3QUSCMlU3ok5fZgZeUpOWggsCI4B1MdMxS/IbXsGqQejNBOXfDgmxP7Hs4cib9dm4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , Ayan Kumar Halder Subject: [XEN v6 0/2] Pre-requisite fixes for supporting 32 bit physical address Date: Mon, 13 Feb 2023 12:44:36 +0000 Message-ID: <20230213124438.14836-1-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000108EB:EE_|CH0PR12MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dd1262f-2d9f-4e00-c9ae-08db0dc019a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2W8hz5ferBSPgRDhz7X8vIvKcHyRKLZ0umyeTWrH7bOFPvtQiv4lNDW95VT+yfldbcnhz6mLs4ajVIegSoOiSZyHmsIrt5g8GtMw5o01Sf2mWRA12qQeQSvyRps3sjHZJbM6ICYJHu+4bQ0FhlNqOm5lgRHaPP0aRJ9VsSu2pTGKW8ebiLDE1ly8iOlcNjlFyo61aGky+qx3esnd2O5X6QOldJTir4QFzbA8AZ3w4QYmaUCpzJMU2sdzwJ1WHRt5H84QBiqOF0qQdb5FMs3ok/8h5pSF+6q9XpNC+pby4VeQNqgSzxnmKfR07cd1tXX3vnzvGUCY0gvWfvcfYyozTvNR4xN1Z93HzMePJZmBIKK9SuTNMtCfxUR/atcea/d1iPZ/vez0uAqsmFZPzGPqPwRZ6qzQETek31FBBuqseJ+fGfqyqw/O16hPB0ZtjTv6AFjmNraFaIDlS2qUG4mYngDN53NBZUPuyixlsaSNnswxZYx9KZC3WO3yP26BbeCnCmG8lzIPzaJ88w1V+3KySvufpiHeQk8rcix0Qn8ljh1pc41CdULpSNomAcQUJ4lHQGyH+qO1lVNCOz9Jb06ImYBmUqlRKZuZ9sjwD28yt5mLfp/PwusGfCedUxL6Cu1ynZln/9gTKjCJhvjb1YI0uZ8GvtG0X9gHK83yUsMgMTMTaUgwaotkVNnlIzaFpC9ZYevp0l6oU9qgX7DG6bbFT4LKHsoVRPj5xye9IBnqhZlM0cSlGW1jg/P5nm0zlVUzSya1ygRPestDSuYRK2Cmhg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199018)(36840700001)(40470700004)(46966006)(103116003)(40460700003)(36756003)(86362001)(54906003)(316002)(8676002)(4326008)(1076003)(70586007)(83380400001)(6666004)(82310400005)(478600001)(2906002)(70206006)(6916009)(4744005)(41300700001)(8936002)(5660300002)(81166007)(356005)(82740400003)(36860700001)(40480700001)(2616005)(336012)(26005)(186003)(47076005)(426003)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:44:51.7896 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd1262f-2d9f-4e00-c9ae-08db0dc019a7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000108EB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5089 Hi All, These series include some patches and fixes identified during the review of "[XEN v2 00/11] Add support for 32 bit physical address" and "[XEN v3 0/9] Add support for 32 bit physical address". Patch 1/2 : This has been reviewed and ack-ed. It needs to be committed before any of the "[XEN v3 0/9]" patches are applied. Patch 2/2 : This addresses an issue identified during the review of "[XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t". Ayan Kumar Halder (2): xen/arm: Use the correct format specifier xen/arm: domain_build: Use pfn start and end address for rangeset_{xxx}_range() xen/arch/arm/domain_build.c | 86 +++++++++++++++++++++++-------------- xen/arch/arm/gic-v2.c | 6 +-- xen/arch/arm/mm.c | 2 +- 3 files changed, 57 insertions(+), 37 deletions(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:45:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:45:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494416.764476 (Exim 4.92) (envelope-from ) id 1pRYCt-000701-IX; Mon, 13 Feb 2023 12:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494416.764476; Mon, 13 Feb 2023 12:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCt-0006zu-Fi; Mon, 13 Feb 2023 12:45:19 +0000 Received: by outflank-mailman (input) for mailman id 494416; Mon, 13 Feb 2023 12:45:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYCs-0006LH-A1 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:45:18 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061d.outbound.protection.outlook.com [2a01:111:f400:7e88::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43455734-ab9c-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 13:45:16 +0100 (CET) Received: from DS7PR03CA0021.namprd03.prod.outlook.com (2603:10b6:5:3b8::26) by DS0PR12MB7536.namprd12.prod.outlook.com (2603:10b6:8:11c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 12:45:11 +0000 Received: from DM6NAM11FT102.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b8:cafe::a0) by DS7PR03CA0021.outlook.office365.com (2603:10b6:5:3b8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23 via Frontend Transport; Mon, 13 Feb 2023 12:45:11 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT102.mail.protection.outlook.com (10.13.173.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 12:45:10 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:45:08 -0600 Received: from xcbayankuma41x.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 06:45:07 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43455734-ab9c-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK0raAxV1vdE+TzW9PrR0JHmSGtNORSjnOLANoOnCKHd5jtdGUWUXI5oJ8I1KMw9qzDM7yQ63F1qrThD44DR8LDL5JjVU74pU0zspsW5urfPsfqkxUrvoVjh3S0rOOHTB7PxQXiWMFaE7GLjTI1k3hobmZKpfd2sO4CSmUZZHE1HmEv6hfvxOJh3Obwg7+OhmOXUQcnMBj3MX/FmB5umtyU6/9pZUgIl0AHOzqkXMdicZ2KEAfSej18/vKkSHjU3ZTpB2CSHT3qcBFkEwfMSg17Yf5Fyq9pPUawdV9A3nWJdumGXmIcCe3eYsKex9oLYBGbtg/dVbQpYDG4nYGD/Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dDRwZ7ZvjA48oEAhFhPaFv6O7TQwmnUnkVyn+g6g4qQ=; b=D+KHkchKNyHyDbPYy7bUb+WC29oXcfUR0Qb3aMHwDwSdEgTHBqYxT+x0pyoWlXsXh8APLBD8EIOFWq/Ebxeq7sJDlRKKfDliqm7S7SP+MagTUJns8TSkeDmaeg7SWJYZWmdBLacTYyGP5FqbjOA41mCKI/5B6bV1lwQgQjIuxzT8fuuZMh+mfm8HQa+9SwLKB0ynzLvIaM8bxOCucgp9YKq79x/jkVdgX/a+g+PFuGWKrsbWpKh4OFZSwaUzEddYiBiMU6QJOw5lSClFmEzK7E8WePDDA4Zb4XHK6JsnPZS/tbOJmPYFC9G7xvqTk5uQlF4yst0D5qvMz0hUztQWhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dDRwZ7ZvjA48oEAhFhPaFv6O7TQwmnUnkVyn+g6g4qQ=; b=TreOAcegEs6wNN3yAoHGzcaRz3TdTuFeSw56nden8eQDx6WRnS2LoqZGw5WUEe7SE6fE3pu/WsQ+McqTbVvjfGofNhKsH6wYOFBI0hQq1AlJX3hOX5+oykQQVQko9rA/pixN9zRadB09KIuw7o39Bb8zG6OA0iU1MC9bAaceRQk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Ayan Kumar Halder To: CC: , , , , , , Ayan Kumar Halder Subject: [XEN v6 2/2] xen/arm: domain_build: Use pfn start and end address for rangeset_{xxx}_range() Date: Mon, 13 Feb 2023 12:44:38 +0000 Message-ID: <20230213124438.14836-3-ayan.kumar.halder@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230213124438.14836-1-ayan.kumar.halder@amd.com> References: <20230213124438.14836-1-ayan.kumar.halder@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT102:EE_|DS0PR12MB7536:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e487a48-7a6a-4b88-33ac-08db0dc02517 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LkU8i0ra120Cn33v9/kJY2cKDt9+VHvMhjb+ficfqysykG7Nbdu7JWeh3cYz43nQoG2Bxb12JyDWsVI3vo8qt8IoXT0c2oK4DlAiyeIzng0wCw77Uc3Y6W0gI1beebeC4OG/uD0UKQwCiva/Ctivp9yUFQ89pJ4blrkgMnAEtRpHivtbB1xjrxvvK7G2FNpgeNJHfqZG4Lp59l3CVdJsC0gEINwiHgGsJn51j7NEaXMSoHMgVgsGXpJCAvvLZOIgJvSmOwFLDfUFctSSvGYm7B8ogobNmc9LZIEdu2/OT2WcsECxmWN9qFhXSD81Ew8qD96N4WqG860pou/jyfIlLGBxTD4Dt6oh7MMuFTO/TLLpgstKuDCWzSCEOENQ5SrLF3jWojWKGtPRC+jCBfTGL5Ax7kkrulHzy5tz0c6U4rA2u5qCpvj7YaNkRT5rHNzU9QGTuX5pPNnwNPwed2G2ZkUU9ZMBLANaFNAUTI79Xn4suMpgt5IGcgnsEYPmvY78qqh4OLhdUsP/+2LxUKvhfwRMmVA//n+J+btXFUJEUEhtfWfWFKrrvH/JXn1i7L6xz92DdSDxgiwoHh2RbzOrB7g2Kwh9yz7ZgFqPCsOPPYxyQRi/mYPZTAG9hg0JsszXrlG4J+9IyK87frCBXMCi+B9VawCBR1aHobHKMRm82we2yN0X0NmApFsupzEjbha+H3t25mAQjqXNYvXQf3atz9+YTzTSnBKVZ/tfWc4zzCDy6YHhJo9ZCwY3bk1MLovk0e5jZtpg5FFZ8cQkTHNCtj7hvTh95p9qSeIkw61qsNI= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199018)(40470700004)(46966006)(36840700001)(36756003)(86362001)(103116003)(82310400005)(40460700003)(40480700001)(47076005)(426003)(83380400001)(70586007)(70206006)(8676002)(6916009)(4326008)(316002)(54906003)(1076003)(2616005)(186003)(26005)(336012)(6666004)(478600001)(82740400003)(2906002)(8936002)(356005)(41300700001)(5660300002)(81166007)(36860700001)(13513002)(21314003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:45:10.9279 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e487a48-7a6a-4b88-33ac-08db0dc02517 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT102.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7536 rangeset_{xxx}_range() functions are invoked with 'start' and 'size' as arguments which are either 'uint64_t' or 'paddr_t'. However, the function accepts 'unsigned long' for 'start' and 'size'. 'unsigned long' is 32 bits for ARM_32. Thus, there is an implicit downcasting from 'uint64_t'/'paddr_t' to 'unsigned long' when invoking rangeset_{xxx}_range(). However, it may seem there is a possibility of lose of data due to truncation. In reality, 'start' and 'size' are always page aligned. And ARM_32 currently supports 40 bits as the width of physical address. So if the addresses are page aligned, the last 12 bits contain zeroes. Thus, we could instead pass page frame number which will contain 28 bits (40-12 on Arm_32) and this can be represented using 'unsigned long'. On Arm_64, this change will not induce any adverse side effect as the width of physical address is 48 bits. Thus, the width of 'pfn' (ie 48 - 12 = 36) can be represented using 'unsigned long' (which is 64 bits wide). Signed-off-by: Ayan Kumar Halder --- Changes from - v1 - v5 - NA (New patch introduced in v6). xen/arch/arm/domain_build.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a798e0b256..6a8c7206ae 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1566,7 +1566,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, { start = bootinfo.mem.bank[i].start; end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size; - res = rangeset_add_range(unalloc_mem, start, end - 1); + res = rangeset_add_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1580,7 +1581,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, { start = assign_mem->bank[i].start; end = assign_mem->bank[i].start + assign_mem->bank[i].size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1595,7 +1597,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, start = bootinfo.reserved_mem.bank[i].start; end = bootinfo.reserved_mem.bank[i].start + bootinfo.reserved_mem.bank[i].size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1607,7 +1610,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, /* Remove grant table region */ start = kinfo->gnttab_start; end = kinfo->gnttab_start + kinfo->gnttab_size; - res = rangeset_remove_range(unalloc_mem, start, end - 1); + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1617,7 +1620,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(unalloc_mem, start, end, + res = rangeset_report_ranges(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end), add_ext_regions, ext_regions); if ( res ) ext_regions->nr_banks = 0; @@ -1639,7 +1642,7 @@ static int __init handle_pci_range(const struct dt_device_node *dev, start = addr & PAGE_MASK; end = PAGE_ALIGN(addr + len); - res = rangeset_remove_range(mem_holes, start, end - 1); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start),PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1677,7 +1680,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, /* Start with maximum possible addressable physical memory range */ start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_add_range(mem_holes, start, end); + res = rangeset_add_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); if ( res ) { printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1708,7 +1711,8 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, start = addr & PAGE_MASK; end = PAGE_ALIGN(addr + size); - res = rangeset_remove_range(mem_holes, start, end - 1); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), + PFN_DOWN(end - 1)); if ( res ) { printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", @@ -1735,7 +1739,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, start = 0; end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(mem_holes, start, end, + res = rangeset_report_ranges(mem_holes, PFN_DOWN(start), PFN_DOWN(end), add_ext_regions, ext_regions); if ( res ) ext_regions->nr_banks = 0; -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:47:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494435.764488 (Exim 4.92) (envelope-from ) id 1pRYFR-00087v-WA; Mon, 13 Feb 2023 12:47:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494435.764488; Mon, 13 Feb 2023 12:47:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYFR-00087o-SZ; Mon, 13 Feb 2023 12:47:57 +0000 Received: by outflank-mailman (input) for mailman id 494435; Mon, 13 Feb 2023 12:47:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYFQ-00087f-PH for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:47:56 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2062b.outbound.protection.outlook.com [2a01:111:f400:fe59::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a225146a-ab9c-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 13:47:55 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by BY5PR12MB4997.namprd12.prod.outlook.com (2603:10b6:a03:1d6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Mon, 13 Feb 2023 12:47:51 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%4]) with mapi id 15.20.6086.023; Mon, 13 Feb 2023 12:47:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a225146a-ab9c-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgKWr99RyI6RywXZG59d1iT0rlOWJa0OLavsUPo7ZnIz0mVwb5Td1v+7qnKBWToNGK7W3RYJ0wF6KK9+f0mQMm1eXqSzojwduUcbGYA4v8zJXPO52LRBvG9qdgVcAfW02B4Qag9iAN71ixn9m3WBNQLHmJi+6AtH9SS961ja/ruo5Zr8+VJ0HlQzFkMVLZ+H+zDrm1dlqKDQV30gr8XD9Cj0/EleXZ31ess9pVC1cBHYdmPoHOW+atmm6TwxvWDe3V/IQYs2Lj5rdJZ6yOfYx7HajRAmZ3IMHVU5CXjIDpIGC/QrF2ZFaIGxk9ZWi/+1RtSNLS719+N7yUxutVtlsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gLM/O2Imxi/CZGa+zG8LXPbr2AgWnpvfypJndQplNZw=; b=bG4t+PhRYW89kKPCh1+oIxcm4qIz/AiwploYlRc8Xat2ZloYA2V4ECHYgW/A6iatAxhawyFMpxqgH/rrLVb8RkiAH1YccQHv8YKJEZRLTe/DT398sKjg7mv81Gqvy/9ExSv/pce+8EKv6nOtzAYVerbOLvF+g0Z+Avzwq02ZpIHDPXWNMzc7f95mVKQgg/ATYnqCY8jGZhYsAyeP3dil62NlUSe1KgIBvz4w/WysF9c/fTxI5krs9NuZ5UQ4hnL9Aaj42SPjCfKrSZoo7Q+ItFZZg4PDYWHhUAyj+IfzT7ccFY9O8t0BZqHNZ5MxEWkYU6mLZaw5kL3ypMINO+aIew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLM/O2Imxi/CZGa+zG8LXPbr2AgWnpvfypJndQplNZw=; b=0EGzXEltHMsV7iL6LPe5obGD10lZ7e3quGGkamXjMlf3m/uOygsajWS+he6j/bFqVQardKMjES7/8NIWwQH8w7R/Kbk6n1UmPvhewiLjxXPYALcQKVDFSjGSdvVj2gMhzmNvfZ8PhVTKDVdEz5s7UokxD7sCVTXy4Qw0hZutPjU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <457fc135-e7f8-b6b4-4d8a-8d6347ef5751@amd.com> Date: Mon, 13 Feb 2023 12:47:44 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [XEN v3 4/9] xen/arm: Introduce a wrapper for dt_device_get_address() to handle paddr_t To: Julien Grall , Stefano Stabellini , Ayan Kumar Halder Cc: xen-devel@lists.xenproject.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-5-ayan.kumar.halder@amd.com> <5631b4ea-decf-0e9d-3749-6f0bdffb73c4@xen.org> From: Ayan Kumar Halder In-Reply-To: <5631b4ea-decf-0e9d-3749-6f0bdffb73c4@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::11) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|BY5PR12MB4997:EE_ X-MS-Office365-Filtering-Correlation-Id: 40abf111-4026-47b9-599a-08db0dc0849a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nHxbAi4fzKC6Bxbc39NscT5UBM/EsTW5pnmRppC0WG6NYAVnMNaIp8iJRATSlApaah9tMZqvah6X+XGD1bUh0YBPYEKOtQfotyPfZeGSkXxbjdZI/KWNomXOFO7cWUiQdX2aD8LtYBUSpSzZFoFp6WlSXoMgVNst+2oaeJterKsxlxtBEmLhmlixb6wuBIDEZOTHORP83i0Ef8al0hrL33F9p51ZkUuq/iOMbWYx+qZnUqvh+I+FgCtc6YS8OBlGYa6tRww7EL+e7RDe5Z4K3tzcDEqEQ7maP4pjp1amXAT0e2fUsZ3fENIKCvw1WdUQLgQJzS9lsf5IV+8VhHymaec8C8Gp+GHgLiFxEdbh0hnI12C2z1d7K9lcP2saLux5VBZmqJocrAn4I7OjERdjBSJcLjKYkhaZcxhiqal0uyTEh6ydQG1NbhQaNsY4+ysgvH7K0TnxS+Arm7u1QfKNG2EfmAVyW65djWh1s832OGKGmjYc+FU/jYAGNTeTwqbBNEtW17sI5ly0MsOAjZILJeY5d3qEbDlrwly/h9dCGtlXsg1xvHQnZvpUj/uBFYVpkWf9JGJ1/nSl2l1/XSsW9WikHV4iBqf/XHDAmGzXeMdmBj50+rQJxpLbaV0kymysjT3cdA0rB51uNjw1Sshp9t+plck4B32c9HEU3jwUZEG/nTOCF4xM+TxZrBjaZTYeOjMiG3kUMq3bpniZAAELD/2CnGHGPSmtNYv8wcLTN6xWBIxN4IO9CTQbzWIdIMur X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199018)(2906002)(66899018)(186003)(8936002)(5660300002)(26005)(6486002)(36756003)(6506007)(6666004)(53546011)(478600001)(7416002)(31686004)(2616005)(31696002)(83380400001)(66476007)(6512007)(38100700002)(316002)(6636002)(8676002)(4326008)(66556008)(66946007)(41300700001)(110136005)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUpOS2phYkJaOFo0QXFRODRIS2RxQnpXUmNueDB4R3Q4cld1MndpL2pJcDZR?= =?utf-8?B?S3lGNFRxcVNqRkZGS3F6eDBRbU1uL2ZzMlZyVWNnUjZRYm83V1VBSkovMkcx?= =?utf-8?B?cHVnaHM2YW9BTnRvSitCMnBEeGY5bi8wLzY3Z2pXR0xad2svNEhmNVNkS1Vy?= =?utf-8?B?QURhU2NuTTdOS1c0TjRhaElBY2tYc1JZODZNVWpxdzhWdVRadHVDcXJtRCtl?= =?utf-8?B?WENwNUhaY0hod2xqZFE1RXZwRmtoU1BCdmZsRHAzUUpzamhxbXVDT0JpSmN0?= =?utf-8?B?QjJhZE9WZ0tFaVprbGsxTWlqUEFZNWp3Rjh2UFAraEtwQURHcmJGQ3Z0bGRI?= =?utf-8?B?RHYxY1pFK0dUWEsrcE15Vzc0UTlrczJnSjYzU2Q4czZvR1BnMVZka3FtRGFh?= =?utf-8?B?bWoxdGs2Tk5lUUFyWlFHTjNFdVNBVkcxSkg1bmJQUWR0bElRWG5rckpXaWRP?= =?utf-8?B?UzZLRWtPVGl1UzFabmd5bUV3d3pEL2o1MGNURENkOWZkS29xVzJkWG5sZVM0?= =?utf-8?B?L1JDVzcyWlhXc1ZqRTZXR2YzZHJhOHJBam40OEo2OWEyNSt6Nk1rTVNLcTRB?= =?utf-8?B?STVpTjFneWVuckR4MEJRazFIMzFDd1pYL1dlcXNRcTcyak14Umx6VXpmN3RL?= =?utf-8?B?OE9pa0N3S3oxTjBicjd3SEpxYzh6ME1kdXc1NElLZUQvQUZ6NnRoZWc5SVFJ?= =?utf-8?B?WlNyZGJuQUVCVFpsVHhhckJPbEtBK2hWRUFMdEdLMlE3eXZJaFVBV3FsU1hI?= =?utf-8?B?STRBU2U0elRPd0lkOEYzaEltYjBubzhxRWJNNWNOMTBQWUFNeVFXZk1uWk9B?= =?utf-8?B?ZFBLb0E1ejAySjNiRjZ6K1lQVDBPajVydzR4OFlMR3JmMGkrTHMwQjNCRTRK?= =?utf-8?B?ODNWZGU3bDVhRHZRMjg5OEFGZEw2TUxEeExvbkYrRTY4YjRFd0dyeUxLdWkv?= =?utf-8?B?RnVZUDFSL2crNmNyVHlYY0daNmNjRHZ2d3FYY0lpNHVPMHluWXY0Z1NzSUhi?= =?utf-8?B?bFpIS252dG5ObEhPMmpCemRrR25mdmdDcHRXeXIwaFRZUlUwbnRITUkwY1Vy?= =?utf-8?B?WGJxSXBTTzhEZit5M1RHWVdzR2lWR0Y5cnJMYndiRjF2cDFKMXdYbjJuQjI4?= =?utf-8?B?amF1bWFIOHRlcmVjZXFwaUhGVHp5aHBCd0FodXBuL2tnZDFGRU1TT1AxMlZR?= =?utf-8?B?OTBkM2gyMldja24vVUNEWFl5OEFaNFNvUTlEYlBTMmxZczVaWmdLSjR6bi9S?= =?utf-8?B?dEVDUGtrR0QxdkxvRHZJKzg2VjJjVGlZck8wZFFGZUJERmN3S3Y3Z1FVKzlX?= =?utf-8?B?RUlranljTVRZWmRUOUxyWnYvMmFXMzhqQTB4M0gyUDhGc3hyVmlGYWRuT1BD?= =?utf-8?B?VTJoUUt2U0FQTTN4MFMxQzRNVlVKMlVOUFdiV2hkb1Y2RWhQZEJETjQwWnpY?= =?utf-8?B?aTNZaHptdGZINVhwK2h3TWpIckx2WllIS3BRN3dIUWFJOW9hNDZaSHd6SlN3?= =?utf-8?B?MmVpY0xucEpYZUhKQ1VONnVHaVMvN2t6ZmVoNTloa29JNDcvMkR0dlhjd1Bk?= =?utf-8?B?K1d2NWduemdwb2N6U29vUjlCZUJzUi9ISU40d3ZhWG1wSm5wYm0yTVZkU0h4?= =?utf-8?B?aUg5aTBSWmdUWmdhSjkyYTJWaHpJS09VUFcrQ25ySWp3R0JraEkyQk9lRkU3?= =?utf-8?B?M3I3akh5REZIUW9JZ2JLVjlzZExvL09nWVFDQVI0YU15NktCK052T2FZVWNS?= =?utf-8?B?U3BqUzg4WG1pQ01mQWNkZENuUzdjYjlPRkRBSFlpU0xnZ2VMVDV1ZjZaOUJO?= =?utf-8?B?RW5ZNTlUTW4xWnFuNGFWYW14VW5GTnpnTmV5S283Z3Zhcldnb0VMMEtmaVNY?= =?utf-8?B?bzBvUU9xQVpkU2o0K3VENGI1NUN2ZlBUaXhwKzduWjVTUGFBQldYanc2SCtj?= =?utf-8?B?M093SkJSK3o3NHJGNkRxdjNFWFVCM09CS1RnemtUcEQzWnlSNnc1QWk4SXMx?= =?utf-8?B?ZExPczBoNFpTNkJtdDdvcFRMZU50b0IxaUpHNXg2a0xncGd5VDQ3VjBuRkd4?= =?utf-8?B?NVBLMnZqR2NXOVk0SlQvWDdaMzcyMTRlam5nU2VuczdJT2pRa3VTMWxqR1Yy?= =?utf-8?Q?37DJNSY4FoHmSYcaMaYdLcLJ5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40abf111-4026-47b9-599a-08db0dc0849a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:47:51.4678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Aq5ypWk47mqU/m9lx9rL5jqpab84Knaqb+g9SY1Sm9NxBOVg0ThZNQYBSi36fm5IXiQBSQ7Lv3YRLKlLOyXoEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4997 On 11/02/2023 09:10, Julien Grall wrote: > Hi, Hi Julien/Stefano, > > On 11/02/2023 00:20, Stefano Stabellini wrote: >> On Wed, 8 Feb 2023, Ayan Kumar Halder wrote: >>> dt_device_get_address() can accept u64 only for address and size. >>> However, the address/size denotes physical addresses. Thus, they should >>> be represented by 'paddr_t'. >>> Consequently, we introduce a wrapper for dt_device_get_address() ie >>> dt_device_get_paddr() which accepts address/size as paddr_t and inturn >>> invokes dt_device_get_address() after converting address/size to u64. >>> >>> The reason for introducing doing this is that in future 'paddr_t' may >>> be defined as u32. Thus, we need an explicit wrapper to do the type >>> conversion and return an error in case of truncation. >>> >>> With this, callers now invoke dt_device_get_paddr(). >>> dt_device_get_address() is invoked by dt_device_get_paddr() only. >>> >>> Signed-off-by: Ayan Kumar Halder >>> --- >>> Changes from - >>> >>> v1 - 1. New patch. >>> >>> v2 - 1. Extracted part of "[XEN v2 05/11] xen/arm: Use paddr_t >>> instead of u64 for address/size" >>> into this patch. >>> >>> 2. dt_device_get_address() callers now invoke dt_device_get_paddr() >>> instead. >>> >>> 3. Logged error in case of truncation. >>> >>>   xen/arch/arm/domain_build.c                | 10 +++--- >>>   xen/arch/arm/gic-v2.c                      | 10 +++--- >>>   xen/arch/arm/gic-v3-its.c                  |  4 +-- >>>   xen/arch/arm/gic-v3.c                      | 10 +++--- >>>   xen/arch/arm/pci/pci-host-common.c         |  6 ++-- >>>   xen/arch/arm/platforms/brcm-raspberry-pi.c |  2 +- >>>   xen/arch/arm/platforms/brcm.c              |  4 +-- >>>   xen/arch/arm/platforms/exynos5.c           | 32 +++++++++---------- >>>   xen/arch/arm/platforms/sunxi.c             |  2 +- >>>   xen/arch/arm/platforms/xgene-storm.c       |  2 +- >>>   xen/common/device_tree.c                   | 36 >>> ++++++++++++++++++++-- >>>   xen/drivers/char/cadence-uart.c            |  4 +-- >>>   xen/drivers/char/exynos4210-uart.c         |  4 +-- >>>   xen/drivers/char/imx-lpuart.c              |  4 +-- >>>   xen/drivers/char/meson-uart.c              |  4 +-- >>>   xen/drivers/char/mvebu-uart.c              |  4 +-- >>>   xen/drivers/char/ns16550.c                 |  2 +- >>>   xen/drivers/char/omap-uart.c               |  4 +-- >>>   xen/drivers/char/pl011.c                   |  6 ++-- >>>   xen/drivers/char/scif-uart.c               |  4 +-- >>>   xen/drivers/passthrough/arm/ipmmu-vmsa.c   |  8 ++--- >>>   xen/drivers/passthrough/arm/smmu-v3.c      |  2 +- >>>   xen/drivers/passthrough/arm/smmu.c         |  8 ++--- >>>   xen/include/xen/device_tree.h              |  6 ++-- >>>   24 files changed, 105 insertions(+), 73 deletions(-) >>> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index 4d7e67560f..c7e88f5011 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -1692,13 +1692,13 @@ static int __init find_memory_holes(const >>> struct kernel_info *kinfo, >>>       dt_for_each_device_node( dt_host, np ) >>>       { >>>           unsigned int naddr; >>> -        u64 addr, size; >>> +        paddr_t addr, size; >>>             naddr = dt_number_of_address(np); >>>             for ( i = 0; i < naddr; i++ ) >>>           { >>> -            res = dt_device_get_address(np, i, &addr, &size); >>> +            res = dt_device_get_paddr(np, i, &addr, &size); >> >> One thing to be careful here is that "start" and "end" in >> find_memory_holes are defined now as paddr_t and passed to >> rangeset_add_range and rangeset_remove_range. > > I am a bit puzzled why you are saying "now". Without Ayan's patch addr > was 64-bit so... > >> >> rangeset_add_range and rangeset_remove_range take an unsigned long as >> parameter, so in an arm32 configuration with paddr_t set to 64-bit it >> would result in truncation > > ... the problem you are talking about would already exist. > > I would consider to store a frame number rather than the full address > because we can only deal with page-aligned region. > > Stefano (or Ayan) can you look at it? I have sent out a patch to address this "[XEN v6 2/2] xen/arm: domain_build: Use pfn start and end address for rangeset_{xxx}_range()". - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:53:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494443.764499 (Exim 4.92) (envelope-from ) id 1pRYKr-0001LB-NP; Mon, 13 Feb 2023 12:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494443.764499; Mon, 13 Feb 2023 12:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYKr-0001L4-KS; Mon, 13 Feb 2023 12:53:33 +0000 Received: by outflank-mailman (input) for mailman id 494443; Mon, 13 Feb 2023 12:53:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYKp-0001Kw-PF for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:53:31 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20611.outbound.protection.outlook.com [2a01:111:f400:fe12::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6948b137-ab9d-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 13:53:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9106.eurprd04.prod.outlook.com (2603:10a6:102:227::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Mon, 13 Feb 2023 12:53:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 12:53:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6948b137-ab9d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f0QgDoc/w891Cq03qRPvBg2l/GSWrsSGUKXFcIsXP0lzPPOiGTHq0JOo0I7wYEBV7HPGXW90dEved3sI7+QUOadLJ7fyhNFQ+5xg4pL6FzmCeS7gu9YwSkUwMo0vACG/GuU7W2tphQxy5t49d+hKHsYGRU4CKg+GwyBtmTb1OojFXzy+tgIQgQeX82QJyBRvJUaikroYX0ouWIHDqJXJ+fMOPk6vxk+pTdZMwXOqaLjvrBfizJGRq6GTbUm8DbozeH6jIa5Moiuq4rI6qb8659WGaYCPc6JKfj55PKSMocPw3CacUuNoAojPxSUYLzgpkutQbA5u/GVo1Ty4FsVdIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRQYmSh87Vw1h0q4Ice6jdtJ4Wzz8tkJkUXxp6vtqcQ=; b=h5ztjPg0+bYTj+pOToTA1wReaelII+dllmkCXbDe4Z3mMDAbU2Qjt9jlEpgxUU82UhoJyQOFFDRX3qHyGqgYHhnjyemKx8K97FxlVvFcWwsbTFiL7kg66/LsyLqPJFywJ5I7MWGRVjKcea76O3B296fJJN7BLvu822wEtd7MJ8jwW13i9uj20XbPo6tVQqwSaFHpPuzRgg7UhDvgGRNwUWSBUpsOPHSJmFPA3kvr5apMx26yPCJVDBFBngCkn4qwOXIFoQ6Fz7YiVdcEcXlAUQnIKxBzOOZ8MgDh4XoE39+8pkcIQ90CZARJ/PMzNpJ4z50rtD65Km7mFly8HnMbJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRQYmSh87Vw1h0q4Ice6jdtJ4Wzz8tkJkUXxp6vtqcQ=; b=JeudmUTpgIl9wo4UNQhQIHOgcowW/Ll7IGeZhBcUh1msXS6JWtjxoQRliXkQ9xUUW61owzPfHj0HPt98uB/nzgXUk6P6v7M7ZJWGamqkqgqHQEaJfnrBLeePfGbiZO1TUg6WiHc80Tu087OOnnqrlGnrp5eZbOKnFXMLMkfApXtPD9UebX34Fp4ya0Z1AOGHastVPoIE01Xdu+7TYnzS364n6TlxwlggmdIfDfVkfRQFEwCmYPm0heS+forHpe+VZa4EkRjgb/bbsffyK/f/gkb1CoPZDsuUUIgnLWEUWQcxPshOipilEZHTZd+7u/RqG8Nxv5Vzosg0eDvVcuFQIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e4e8000-9e2d-6e43-df7d-9a34a75b7163@suse.com> Date: Mon, 13 Feb 2023 13:53:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: xen (multiboot) binary gets corrupted ELF notes Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: Cc: xen-devel , Andrew Cooper From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9106:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cff414d-2412-48f2-5330-08db0dc14a5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FHY2uW7xhoHjxflRAVWRfViXTfdZvQmm9WFAe3feIAbd0XCCRXxDelZJ0PJXieLt7/oLZlt1/iVQjg0bwlRh9vQ1HEngqMnT7BCPn6bBHUbNryy94rGR1rm3yyTJ7njG8ouOK0a1577LaECfPy+fc5fRRfeCKU/YVKkqDq2nmKj/h4TchO+9QoJCD4l+G1rip/n0KjRfVHtZqcnmB7VcsEMOp5FtS1h2MuFWSHVQwOoDn5IhiQnygTpLD1Z8NEquzC4XXg8/ZiTm9rxeEqss7x73q48p/6HAGz6Ytm5iY7aXmjESPqX/zul1uHjR4/y3JPzMU0Eb3MB3/Y4/f07LbPnt+Opk2KdW2NroZjiHpf/XELM0Or9udhR89dliJbbMIjw6JL7R1GRENqdUD5iUOHy8DwXVtXC0SyBsQmAuRntYU1MvVEUWxydr4nNIthx0knnnLcsm+WBz94ofBvHy+ZHao+Wta+legQZHFRr0GYOnxGF7dDzyDHfVx/x6k7cXp1OIbzywYsJIVm2XvK2QsfcID0cQgU6N8mcksyzOu55f7t8K0Nu+qy2GgUefKQ3KS7NYdvZ0AFHPjzj4VHXdgB1Hb/O5SLICTszolF361iiMoqeAFAKreCy93/vaa9EtDkro9JJmdiZje2zEfd1OJDrw0o1YMe9MPIZNMvEXKuOCJBR1STAqoBWLua0TJVn2fxdHfEvMkpkEK1GXYrQPgrVNW4gmFYn5xolRs7nb7EWJAN/6zubml3CuCsPouXakTmERb4awTV16vwgaxtmb/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199018)(86362001)(31696002)(36756003)(6916009)(4326008)(8936002)(41300700001)(66556008)(66946007)(316002)(66476007)(54906003)(5660300002)(83380400001)(2906002)(38100700002)(53546011)(6506007)(186003)(966005)(6512007)(26005)(6666004)(6486002)(8676002)(66574015)(478600001)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHhneS9INzVFdkN1Q095dmdBT0VKVTRwR3ZyaDdaY3JsUkphQmdaU1h3bXFE?= =?utf-8?B?eU80dWZYaUZCVlZ6R3ZFakdPcnpkelhwVjh3S3RIRkI0NlN0NE5Lc3dFUEVH?= =?utf-8?B?dDg5a0RNVUIxTXZpUjB2bG1kZm92TUZIQzJlNnF5ditvYXJzMlpIUHhGbWNZ?= =?utf-8?B?RnFQcHdCY3dTZEtHWEp5eFdNNndnS3V1Y2Z0L2xsUXU3em91NHdhaWpmbmtq?= =?utf-8?B?WUt1aG0yeTNoQXlTUWtnbmdUVkZ6em9EdHE5eTJEeW0zNDQ0SDdYYmg4RUNX?= =?utf-8?B?NHBpMTJTUEtoZnVySnZBZEJwS3lyQ3F6cEVsRWJyeEp4YlZ0V2w0dzUyUWhO?= =?utf-8?B?Q0piUm1LUlVyRmQ3Vkk4d0I3eHl2bnJPSDB2bFZPZUsxOXJKSGVHU0JjNHZG?= =?utf-8?B?eEdnTjV4U3ZhbHpMdDZON2tEY3pCU0dITkRuZit3SVovT3ozSGtDYTVqUmNh?= =?utf-8?B?NVV4SG1yLzJNYWlINlBKSStBRElwaFVvL0pEM2tseUxiN2pKdm44aGxOdTVr?= =?utf-8?B?VGZRYmhFcXpoa2JnS1J3ZXpYMjdBUUlOWE9TdGFkYjUyempySUthYUVibUlO?= =?utf-8?B?WWoyM2JMWVNoMWxrRW9VNUxTQmU0dWZ6VUpPN2Y2WDhZNjZabGtCRGhKVGZ2?= =?utf-8?B?VmdEVkt2emhlemJiRkZjcy8yS1RIK25aWjNSZ1pwZlJPd3BjVi9OdEdtS0F0?= =?utf-8?B?VU1Ed1BvdmFRVEZYUXQ4Y2R0L2ZsellyakYrWDRFallBNFlvRE1zOTJXTC9D?= =?utf-8?B?NVBzS0ZEM3h3VW1jM2JRT2ZvOStMYk1SR1d2MkNDV1hlWTFVamEwOHMrTDF5?= =?utf-8?B?OWJIM09tYU5PbHVaSzlCZU02U3FqK2g0YnhxenQvaFNQcjlLMEJOWGMrYnlS?= =?utf-8?B?TjFhVFU5WExZUGZiZVIwL1FoQmtwaStlSXJJMG8yZXhhekY4RDBOQ253UlRl?= =?utf-8?B?WWl0Wm1kWURKdURQZmZPSnJyVzZMUHpDR3kvZDFXZTZyK2Z6TUlpajRKNUs2?= =?utf-8?B?RmN6ZkNXNG1nbXZDUXd6ZUtxR2RxQXhhYm1GdGZlRFdUMHNZR2RUYXAxYTN1?= =?utf-8?B?QlAvSURaVFVBUVZQR3VrVk9HUTAvWnJGV3VFaHkyRUI0NVRLTWZZZEVxR3da?= =?utf-8?B?VzY3WktKM05JUGFHdzJXclVxcWV0RTVRcEZ5SERGYVp2TlVzUmdLMDlPTHd2?= =?utf-8?B?ZENEcEdXQUJXQU95R2ZJSlNZYVJmcnhwOTVadUFBUVJNaVVoQWlXVjlRLzI4?= =?utf-8?B?elIyNmMxZ2hHUXJvSnc1V3RNdlVRRmNnODlvMGdEcEZMbTQ5THNYSm12ODVH?= =?utf-8?B?ZDBMOUIxQTFyS3pnTVRwMHFjR2pWQWJIOTFXdGpIVEJLa1lpd0VtcjhzRzE2?= =?utf-8?B?ZkhETjRUWkd1alBLTHQwcjhXOGRkZjZ5aU1WWkhSakxUL2FZenhtMk9HcGhn?= =?utf-8?B?WE9qQXE4VERVUGc3MWZNQmh6SDlnOU5rcXFGSVplTVVKSlJLcS96cHRCWmhN?= =?utf-8?B?cDg3Wnc1MkxRd3RFSFAvWUQwU2RBemgrNkExWHVGZTRaTGQxV2dQT01WeStw?= =?utf-8?B?SFM1emlVdTRsb0trUXVMMTljc29mNkEyQXc1ZExONHZpRGRWYUJUZnBkYnJr?= =?utf-8?B?cCsxZkdFbHBGeW5yL1pic1pLWFZEd1VxM0p2anU0ei8xbDZzR2V4VmQybk8v?= =?utf-8?B?MU00Zzc1am9OeGtyQ0wwejJnVmlXTFJFUHlLa1ZxcGt1OUtvU1M4ZjlOaXJJ?= =?utf-8?B?ZElNaEI5c1VSOGphL2xVdEhLdEwyaTlqZWUwSi9TRW1SbDZWTFZXVS9KQVdh?= =?utf-8?B?WEQ2cWRwRVRHS3FaM3Z6NEx3Si9BNlNUcHJXSjJ5dDBETlo3SDQ3cFBHc2xH?= =?utf-8?B?Z213OVJ6Zlgydk0wN2JQK081RjhXUWtyekRvQ3F4eEl1Zi8zMnZBRHVMVzFo?= =?utf-8?B?blhoZ1VESXd3Mjg1dHVOY05BMW9ybHlpOXFEcXdiTnJLRTdDZW9hTHlYN21z?= =?utf-8?B?TWlpVmpxZlhNT2M0OHhnclkxWHAzWHpXRms5VGpzbytzNHdTNm5iRlIwclV0?= =?utf-8?B?czh4dU41L2tZdVloVUxEaXdpWVhJL2s4MzI0aXBUTk1pcUljWDA5LytPYW5R?= =?utf-8?Q?62RqwPyuJrvxpJckZyn9akO1R?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cff414d-2412-48f2-5330-08db0dc14a5e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:53:26.0912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oMo7KGFibAyo/UNK18EyKpK+KVwvVdnLOU6PLuNToa5oVz0SStF28MU7iE8i0Q/UpbMyBIhSSI4CJj+Rw/h30w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9106 On 13.02.2023 12:14, Marek Marczykowski-Górecki wrote: > Hi, > > I'm getting some ELF note issues on multiboot binary > specifically: > xen/xen: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, BuildID[sha1]=f7d2c37a4ad599b268f2f2d94bff3776d12649b3, bad note description size 0xc0010001, stripped > > readelf additionally says: > > Displaying notes found in: .note > Owner Data size Description > GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) > Build ID: c5825a0d08edc4d11b1138fedca6b14ce8ba7302 > (NONE) 0x00000004 Unknown note type: (0x00000020) > description data: 05 00 00 00 > readelf: xen/xen: Warning: note with invalid namesz and/or descsz found at offset 0x34 > readelf: xen/xen: Warning: type: 0x4, namesize: 0x00554e47, descsize: 0xc0010001, alignment: 4 > > Grub doesn't care, but launching such xen with kexec doesn't work. > > Initially found when booting Xen via Heads: https://openqa.qubes-os.org/tests/60151#step/install_startup/11 > > Andy says: >> yeah, I've seen the same on XTF >> binutil's recent elf notes for CET compatibility use an unsigned long >> so they're not compatible when we build as 64bit and then re-package as 32 >> I think we need to strip all elf notes in mkelf32 Instead of complicating mkelf32 (we want to retain at least the build-id note, after all, and for PVH_GUEST builds also .note.Xen) why don't we discard the unwanted/unneeded notes then from the linker script, just like we already do for xen.efi? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 12:58:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 12:58:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494449.764510 (Exim 4.92) (envelope-from ) id 1pRYPK-0001yB-7s; Mon, 13 Feb 2023 12:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494449.764510; Mon, 13 Feb 2023 12:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYPK-0001y4-56; Mon, 13 Feb 2023 12:58:10 +0000 Received: by outflank-mailman (input) for mailman id 494449; Mon, 13 Feb 2023 12:58:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYPI-0001xy-OG for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 12:58:08 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20613.outbound.protection.outlook.com [2a01:111:f400:fe13::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fba8f95-ab9e-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 13:58:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6827.eurprd04.prod.outlook.com (2603:10a6:10:f8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 12:58:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 12:58:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fba8f95-ab9e-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAN7OBJRROoaP5W95NIm7Yn+vmbamXW8GIrWQJLOlsUw7A5EKGidaK0spI/XlhFfLF4Zdef5S/gADJAQhBXCK3WbjHNBHOlvAYMEfNlWsl9ck4EouXGqyR+hNzjeGSiqPInr9Mk28FKt/omUc1wbiiTnkjlIY1SPrNhU+/zYG9/81+pH2yJqU79+UnNMHF+NHTzzIeWFV3SPmz8rYzsC3nV/VfitwtUs82qPe9V47o8VtH28zxMTUO46srVANSc+hazTLoeG89+7V9NoZeV7BkF8mlDGDe7OFV+ZfijOPkae0zcoJbTCxpH+qWZo8Oq9eG6/bxiwIZKhHKFD4HanuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FSqCTzbQHgjNRQrU+5f4nfSA1DCHLoFe1pgl2iU8HYU=; b=aIbyDBuIhYlcJ9HKSb5m1onvPOtBvxAMUzkYamAPH8P3jAJ3sSQFFfe2FTpLx61iOfzNDwwXLhUicwL4B1wLp8EOrRKkQyEZEeIhE+23twl8Ws6ewBp9QrXg76rRiz3eIky2/HjmGVhLJLh2MDVkR7zeAAU43dTxuTAUdt0geK+qc/f5cpJM9LaJ/j6kctMTz98pkHHys2yOlX3S4I+j8+IssPEF+3E9WpRtXgBzy2NLvNBMB3GnTnYSWnR7tgr7gKk7FoP8iMhII5BXMvHdFKN+Rtd/YGAXyNkLpjwz9SZko/zKHvCI2Us3YVMqSaMm7KC/QwoXUMCMLjbsxV5CqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FSqCTzbQHgjNRQrU+5f4nfSA1DCHLoFe1pgl2iU8HYU=; b=k/2NcYzsj7OKhwhiHBmC76Xgxt46cJLpBUfxH5w0Sn2T5fMZzD0Twv6+vtyNqanZ3aLhQhWq0Q7x3w2x5BHWJt5n4nzH2n4J0WLa0HH/Ts3Omt3ZoEgvHDJ/OiAqvEtuNRwhm/aMYA3GmtLLmyccKzfFmaiP7IRco/PNbOH/Em7RKT8ZTvoVsA38KyGBTZsPL0sQeApz6+3Bf1bitHv/632RPFhdkgbF7MML3GOH31MutNmFYASNdMd1ekbLe7PBsVtZNfoHjdl8moZ5XO1BEWuV1Q3PCwEq4qQvJFu1XxussLOfsdEl5lK7mYCUgDLHG73zTvVaQOhskR0v3zPMUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 13:58:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org, Xenia Ragiadakou References: <20230207094347.1059376-1-burzalodowa@gmail.com> <4c3e3350-b415-3414-c1be-f5d7775ea867@citrix.com> From: Jan Beulich In-Reply-To: <4c3e3350-b415-3414-c1be-f5d7775ea867@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6827:EE_ X-MS-Office365-Filtering-Correlation-Id: 28ed3f66-4505-4a8e-1ada-08db0dc1f2fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dC1R8z4IKvUbTntH/T4OYvKn5EoD+bS0aEw76+G3H/ZkAMJkEn0cY16ncwKUViFicH9LWqlgNSMbCi8uQs6luwPC5YBQdut5UyjjVhD6cNA0Qg1rzPTPyRPA2wy1u3vZhIuJAhe2ZGmha3z0d7/9n4w7S2FQ0xtgfkFHkJeSBrU+2rZoKSO15NHJu1kN2r94jESKBGok39wScrp2ALw+olG+kY1DuhJtQfoA+HwdOJupAgHcKRhPtj3l0fY0+8FyDBc1yLVOGzUhCOINoEoj26zT2jWH1oO9zEhkdIvehowNt2VcQhdM+IIWcf4Ec04Qo72r1T0xvOWn25haoXvi8ZiiEOxk4bcOrsZgePZdqkF4hErLWXZTeOQH8oEo1N05TscPa38XjpXOgbRNEdFmJxNDTVZ84sp46nXLdvJsP9gFPc9eVs42Wj/AT3VG0X56aVQ0g1clCTml7EjwyABf7nIFQMgagBnZwS2vNQaDbDWTAiu51uvwZtMTTVm+G+1F0RPMvEl6Iv7H0c+UnczUHMNUfIylJ8jvd5VFLC8Rx0gDOej90x11mjjOMFzyF1ARC059Ce9UIJbLyQvX2JAAHJJu+uB16hfzWn5QpS8GWpyNWM7/pqlQOwtRSt4vUD8VSCeylsBNWtBqtzDqbztjdFfHJfZpH/8lgBuXjdRWBT4mhgTCqXJutTfcLsK/Irkaoh4q7rexk91hiGUcLO8eG0H9KsIwxXcQHzwtHhn+QNo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199018)(38100700002)(8936002)(2906002)(4744005)(31696002)(66556008)(6916009)(66476007)(66946007)(4326008)(8676002)(5660300002)(31686004)(36756003)(41300700001)(53546011)(86362001)(478600001)(54906003)(26005)(6486002)(186003)(2616005)(6666004)(6512007)(6506007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MllDV2dqWStWMTQzWW4vL3JoU0lKemNQeUNJeVZIN0lsRzdWd3I5cjRYYWpI?= =?utf-8?B?M0FZUHpRWmxDUlZPTnM5T04rQ0YvaVBwMW02cHd1UzdRelVxREtQdno2UzNv?= =?utf-8?B?TStJK2FwcHhNTTZDY3RQd2dnV1FoS0JIYmlsMmt6Umt0bWNOdzFWUEFIbURh?= =?utf-8?B?NzFYb0dhSkwzYmJFbi9qSUh4VVR6SlV4bDkwT3JpQ0tldTEzQWNYRmV2bmgx?= =?utf-8?B?VDRvbTVVZHkrK0RyNmRSNnk3WDQrSkRRZWI4YlVDUFdmbExKSUwrY2VqZHRW?= =?utf-8?B?cFNvdGd0cXR3dkRaa2x0a0JRWEFqb1lRdkp2emFUbitqNE15bVhNbzFZdG5N?= =?utf-8?B?SmlSalRtSmxoNTJmNk1Yem5INmNRZ1hhSHZWTW9RUVNmRG5iZU45a1hsYW1p?= =?utf-8?B?R1pXSlZwSUVtN0ZGQW9ZakFkSTJtckx2RlVnc2ZiK3pxb0RobnFSeHVKbTZ4?= =?utf-8?B?dE1xWXRYNEpXWTNaWmc5ZTN5T3E5QWpwUkpTU0JYRVpHcDRwZnRPVSttYUpE?= =?utf-8?B?M3ZUK0x4R2srMmZGandjVEdNQ28rYXpSc1JPYVBxMTJ5MXkyUmlGSWxiU2RS?= =?utf-8?B?WWtkbFM2VUFyR05Zc1FRTmNhZndRWDhna1dDVTBuVTdrV3BNOElnMCsycDB0?= =?utf-8?B?TG5ydTlBQTFOWlQ3L3pjWVhYQjZZaW53aTBGV0hLOTRpdGRucDc3cXRtMG94?= =?utf-8?B?cHROcGZnNXphWVZkM1ZLZGJnMDhYdEROZEZRYWExSElRclRYNmY3VDJUNm1R?= =?utf-8?B?ZU8rRmlqOFpEZG5Rd0ZlTUxMUkRPMWNjeGRyUENOZFBiNytQalFkNDlKcm9z?= =?utf-8?B?OG4yRm5oTVQrcnluRWZtc0ZjeVkzNFhEWGtxV21UUHZyVVo1c3F6dXY5QzFs?= =?utf-8?B?eGI2S0p1TVEycGtjYzhIWWZYVmhUMXBYRUtVT1UrSDFCUTZ2bWZELzdkcE9M?= =?utf-8?B?R1JNYXEzNXZiS3Z6bDZFVVVLNkx3M0ErNlZsdnBSeEkrM1pqUGhmd0ZwQmNL?= =?utf-8?B?dWNaTHJhcXNCREhPaWMvMDRKMjJhV3h3Szd2OFJlanJXTFg4TFJINkJGZTQ1?= =?utf-8?B?RDlkTzgvak83b3ZuYmZ0a0FiMTVaS0R5TGd5dHVNV0JGSUxrNUs5d3VCS0hE?= =?utf-8?B?bXJvY2k0MjlHb2YzcGpJVkROWDc0bVJqWDlURU12SjdCS21yK3p3MXBmWGFO?= =?utf-8?B?cmcvL2F4bDZHajF5SzVwZVNpalRETHd0QzR3Mnd1UlFBUTBYRE9SYVQ2Y2Nq?= =?utf-8?B?V1QwT0FWeE9nbjFxUmYzV2FjZVJVVi9nTlFzdzJHcDA2OUFEZnVmVDNFODVx?= =?utf-8?B?T0h6b282aXJvK21PVWNyVkgyYWhpb1hjaVZVcUcwUXZQZUUybEVZK3J0MTBB?= =?utf-8?B?R3NtMytBL25oRXN3TlBGN1dxRDZLeW1vU3hUc2g2V3U0VGFYM0h5MGxhY2Q0?= =?utf-8?B?dXJnOFFEblYvKzNkZ3lEN3BQbVUraThBazFDVjNDTEFNZkM5TEdtMEhuTlJn?= =?utf-8?B?dDViSzJwcXhGM2lFdjhKWUNSUzBIdm5JNGcyL2Y2QmYvQXNOUyt6THhGVFAr?= =?utf-8?B?T0hpUXJJL3ZJT25LTlRIb25yNUN2L1gyVDlubDhiR3k4WFN6TEVlbnhLMkRL?= =?utf-8?B?NFpDRmV2TEtoREVYbTBXRWV5STdCdjNnay9PVzdyTzJFUUZNa3FiRHF5WmRY?= =?utf-8?B?Y0xpTk15eXh2OU5uSTJBS3dRbkgyKytwYkZiMi9HN2hIdlY3NmpDQ1BXQUk0?= =?utf-8?B?VnZacmdQVUlmVkUrblZtMUtOQkpsY1Y4bFhpRUhua3hWMitnbmZCZW1tU3hi?= =?utf-8?B?eTlDYW50L1R4cllkd0JRWFczcHcrNTJLb3NubmE2U3dTelhZNXJxM0w3NUFN?= =?utf-8?B?bVYvR3FJeVBVWXhoeWQ3MHFuWHdNZlZRdzRLakVPOVFTVjUrUE43TFhSTUN6?= =?utf-8?B?KzZTbHFnejhrNy9wS2dRYUI5Uy9kMVArZUo3cHVpN20xalhaTlQybTNIZDIr?= =?utf-8?B?cmErTXlDRlllQkhDSTJOYzdOcElnQjY0OGJsMGY3cVRVR0JRZUpDRzU3R0dh?= =?utf-8?B?bnVyTzBVRTNNOW9MS3hCUHJLTEZzRmlNd3ZIeGkvRFA1b0syNjBXU0tMbHpO?= =?utf-8?Q?h+91K7ba5zIgx/prXtrKt4qW6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ed3f66-4505-4a8e-1ada-08db0dc1f2fe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 12:58:06.3238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IpQrzIB1GNY4sek/5Y/xnV6tlI4CIbgDkCT7usXc/LX4EB111Uyk+cOsXLnbKvV5a+x+BA+3G28iYv3rIcop2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6827 On 13.02.2023 12:05, Andrew Cooper wrote: > On 13/02/2023 10:54 am, Xenia Ragiadakou wrote: >> >> On 2/13/23 12:09, Jan Beulich wrote: >>> I keep forgetting why putting it on just the declaration isn't >>> sufficient; I >>> guess a short comment to that effect next to cf_check's definition in >>> compiler.h would help). >> >> Yes, that would help. I don't know why it is not sufficient placing it >> just in the declaration. > > Because it's part of the function's type. What does that mean? Is that any different from e.g. noreturn, which also is part of the function's type, and the compiler records this when seeing the declaration. It only ever accumulates (never removes) such attributes when seeing a 2nd declaration (unless multiple declarations are otherwise rejected) or, finally, the definition. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:02:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:02:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494455.764521 (Exim 4.92) (envelope-from ) id 1pRYTe-0003Yx-Ph; Mon, 13 Feb 2023 13:02:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494455.764521; Mon, 13 Feb 2023 13:02:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYTe-0003Yq-M2; Mon, 13 Feb 2023 13:02:38 +0000 Received: by outflank-mailman (input) for mailman id 494455; Mon, 13 Feb 2023 13:02:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYTd-0003Yk-Ey for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:02:37 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2043.outbound.protection.outlook.com [40.107.13.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af0386a7-ab9e-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 14:02:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9341.eurprd04.prod.outlook.com (2603:10a6:102:2a5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 13:02:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 13:02:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af0386a7-ab9e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MI+tDXM/bFLCaWjNM7xK3WO/r7EbrheAnJp+iQZt14rZ93/QaaEz+X8sG08CBILU3cuoZAQSR5h+Gfr0Uq6PeV9EgpHbeMrb4frfIGz2oNf2mTAStcFIkeV0do+H+b3SR4X0JmGwc3TfFvsuEES/DLZNlBIgJY7Aa2B0eRxNbupSuOvyEvB2YEUm39IfyQJ0hvorlMfkt85cMdQAIVke8ctFwMHVET43JuK7AX35YyygOUWHFhuRnKIc30+TPflDjYX23dNqckmwE1bydUPal/pfJFnPV5savcs4rlOCwdJ9z3GtZki2UBDKkCtlfnXhbDODBraTNXZJF9ijrcEdhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pogx/lqPTjqX7PW/pwy+rcn4gQE3t8tp/UEv8pTWbZ8=; b=CLB7Z7s4cYN9NJLpQDUvaF1o/zImjt6S0f7tdePJtK4QzLsrwn107uelHGby7izLlaLJhUbICpHSY2/t8dKKII/ugUY8agQuNKTYKFAN6CABNaJcCT120+2E2WJPy62cMfJ44RExiQOuJlBeBXpL07vX2INaonTbrwODwJYxASqrPRMaXJfcQByRmvzWU7DnSyGbEaHHbiWwEwf3ZY55AUqJGH1dZHESD5pdhFx4fibek4ZM9aS/XlVXljoMW9iL5kCKXSwp58MlcMoHBBzgF63FJ5D1m/ueFSt0jGAYSIvw2qYNWYGKZZOMdtwcSQWU/5Dx/cuHkQfX/r+kcA1LHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pogx/lqPTjqX7PW/pwy+rcn4gQE3t8tp/UEv8pTWbZ8=; b=akOoRRzZ65X++pgdok2oHQdX2OpBR6/A/7bHBy9EqYPuYoV1hPrRWvP33AP4c3Fe6Sl1uQ7Q0OZ79/DELffzPOUtKkr8l9SiwzPWIMR8Fo/7sVAzSPtA/sp4JKV2dfhpp4lyCpqJJAvQxTLBiP7aAlyoMbFCaOR7ShH5k4JiXWauKT8CiSPKX5iKI8PJznCWy2tta80J/19KtsuejOxQl1LxenTk2hslDYEcma8aj6u61KoJAVH/ntynGPC6TtO/DcuMwOpdrL9EUA2oetwtfj4ikrwVYnwI/m4oaebgJISEuYNzxOvVuBn+ZOKjNw3XDrueLzJynhLK7AajVCAD+g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <77deb11b-e460-ef70-9710-90b13c88b680@suse.com> Date: Mon, 13 Feb 2023 14:02:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 2/4] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Oleksii Kurochko Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <6c8b46f2f3326b833c73dbb86674ac5eb6ea45c8.1675441720.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <6c8b46f2f3326b833c73dbb86674ac5eb6ea45c8.1675441720.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9341:EE_ X-MS-Office365-Filtering-Correlation-Id: 68a740cd-cf96-4b6d-29fa-08db0dc280bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rjWt67ExUoXQ4mTi3VHM++/iWralovAflQRukHDAj0jlQokzIePsGi8F8ja5dErk8ObUGIt6iVi+2qJFm0zi6dEyjlixgYo/ZWtgGGsgSzlzSzvyI8HAjOQ2P1vSQfY5dh5hBTIDE/rh6MQtjRni0Xxp9KgmKN2T00cki1XhGk/Tv7Z//2wwMC2ZFS010rWylHUNb+G2o0buLPn3wHAABpKjRD9nQ+xFsiYuA4QFrIqw+Wa2r66fGs55jgFbzoB++pDGM+lpQQGS4uvJs7/ncriYp08x3gEiKlEkHS4WDnVkDnclBntvE9OgvnAo2KTN8Nl++UskIlxDRSYOnclLkXHp/6pVdjKJZkJ+RaP0fhsmuVu8C1Gl5Fxq1Nau56nhnTQWs2Z8fPc5FD+4rNE84M+nP/d/DXrMfocr6l0xs/bo90fUWzg8A/LQpwmnv3VnmfZYt8jBkzAFw614+SA6wgyvDQP5ApJCzfJz9pK/+84axz3WcY+eNQ0bh3uGYKWGi+GpBExNHjuMlT/AB3cvWL0zxsF0xoMBqNNlKarg10zgk3mMeFqasQAstm6ZxiRN8NmfiLNm9CNZSC7y+RdDpPb1riOXLnxy+XxbEw8RqqGK2tZEEZul+d+8NEVl2PLmipXT0SmH0JxstIu/LNgrKzraOaKVxyPKeNbS7cVx88wvB7SNkn/NANV/Yaup6ecxfgPNS5WDhx6lwIPoYRwJqzuSpzFi4Jxvo4qTfw4BQmfSx+LlmPsXsslVz+kebUgLR4hXHYoGr1cX9lYzIwRaLw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(346002)(136003)(39860400002)(376002)(451199018)(38100700002)(83380400001)(36756003)(31696002)(86362001)(4326008)(6916009)(2906002)(558084003)(41300700001)(5660300002)(8936002)(8676002)(6666004)(6512007)(186003)(26005)(53546011)(6506007)(2616005)(316002)(54906003)(66946007)(66556008)(66476007)(478600001)(6486002)(31686004)(41533002)(87944009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVVScUxFUGx4cG5TMXhGZXJaeDhkZ2t0YlRhcUxMNUNvV3VreTJjcmQyYUdk?= =?utf-8?B?VFZJNTNUcDdXQUExU0lQb2E4Ty9aeFYzQ3V3NWZHck05TC9oT3pFbklsaHhL?= =?utf-8?B?MUVMczJxR2JkaTZpVUtEWVBOVDB3cW5FMlU1T3hPaFozQnNXRkQ2Rnc5UnRs?= =?utf-8?B?Snl4cWhJZnNOM2k2OUwyZE1lWmxacENIOHhpZ3pvNGxXUTYxMXdmc3lyRmk4?= =?utf-8?B?TThWKzJMWENvSjVNK0MxZFZwa2pNT0ppdzVPM1RVVW1GWUMxRW0zSVBVNEFX?= =?utf-8?B?RmZRMUlDZm5tMXo2Q0UxaEtyaEZGd0U3S0cwOVRobXVCSG5aMisxZitpbWxm?= =?utf-8?B?TWNNR2JLT2JPY1dIWElIS2t5a00rUWNKRXhLeW5XczVTd0VKL00zZ2VNSnBr?= =?utf-8?B?MDVRQmhrTWNlcmtZU1ViYTBEZDF6emZ5SmZuNjU4RzdMK3lKdHVWajFBdyt4?= =?utf-8?B?TEFCdnJoK0JvUmowLzhSRnlMVEx0d1VCcVpuY1V5Qm1qcDcxNW9YV004OWM1?= =?utf-8?B?dnBGU1RZL3FLc0NScFdCWHlaOXBpTWluTUJ4ajJsdUlrcmUxMTZhWCszRWty?= =?utf-8?B?cWYrSWR5MFM3N2xXcko3bEw0WnNKdER6ZHFINGVYQjNHekVSWkFnSkNlVGRN?= =?utf-8?B?RkFjV2NrQUVKUldUejQzbHVKSDhQRzdLN0pCNFBhQldzWTY4L0VmVzlqRGV3?= =?utf-8?B?Qyt2MTJaNkQwTzJBazZEUlFtZ2kwejhwUWtzcmFRVnMrY0FueDlDSmRlV3Vk?= =?utf-8?B?cyt5bWVPR0FWTUkrc09GbWJjMlp5TUZtN0M5UjlubWVXeFMyOEQ0VzMxQmdZ?= =?utf-8?B?UDFvOGordzFyc2pqQ0J4YTdWVmhHQ3NJc2gvcFd6WkV4QzMwd0JKTXBuendx?= =?utf-8?B?cVhRN0hVRTdmVmpQaDJteENOZWUrTTNXcy9TMUZ2dGRyZnlGcm9EWU5HTFJQ?= =?utf-8?B?cEtuUWxrNFZoNm5SR1YySnpVR01uTTBOeWhXaFJzL2dpV1pVWGpuOE1yam5v?= =?utf-8?B?ZExKZXA3OEpNQlBTTDBiMnY1VkFXMlVyK0lMaFVONnprZjdpWGdSQUhiSlZy?= =?utf-8?B?TkJtS2w3NWIxOUpXelZvWjFRNHpTTmRJM2haN1RRMTgxTVMzbkF1MXBBZlZ4?= =?utf-8?B?M3JmbnZ4ZVd4VlN1bGtOdHMyb2ttZHlGVVdEbkVnamZFNkR5UjdndFQzNUZl?= =?utf-8?B?UFk3b1lzckVvOE82QWs2UHpRZjIxS1dURFhhUkFobDVSTzhOWlFsaVVrZEFL?= =?utf-8?B?SnhXRW9oOXpRd0NJQ01EeHZKZVlUTUFLNTFPVlR6cFA2WGkwSTBNdEd4UDNz?= =?utf-8?B?Z1JxdHZxWGdCemZoaXY1V0gvSy9WOWxudlVsSHRxeWM1d2gyV1Fsekh6MEor?= =?utf-8?B?ZG80WnVqMFpkTkNQdVFTcmRsdjZ1cU8vNU9JbTBQY3czaU81N1pocWw1SG5V?= =?utf-8?B?SVlNWFpBTVZjMVR5c1psYlZ0OXRJQ0RvMW5Lem1RT0REYXlWNktzOWJTQ2pv?= =?utf-8?B?cTdnMk9ZZElXM0hBViszK1Z6MVlqMVRwTm9VNXhzSmxkYTZFVVNMZmVyZnZH?= =?utf-8?B?ekhjSGlUMHJFVlZGWFhpRkdQc1Jhc0tURzczMGtiazA2ZzFsUFJMTExsVEVh?= =?utf-8?B?RE0yd0FaNjJmZ2JtMENoVlgrMDJROTVrdTZlY2cxejQ1VStQQVltUFZNWE5s?= =?utf-8?B?WEs0MkJob3RReEwwcmJQOU9hVVpkcTk1WWJ2T0pxaU9IZXc2a0Q4dEtlNHBH?= =?utf-8?B?Qm0wUklvQ0xkc2ZsbGRqdGd5MnZCQXRveXZsWFJXMXhIVFYvVkRVWHk4LzVY?= =?utf-8?B?a3dEdy9wdWxKR01md2lsNXFkYTNKRWVIWXVLampSU0ppcjkwRXFMckFFWjNa?= =?utf-8?B?UkFleVFQSUs4QStzVEE3WVdma205ZUVmbzJIMmRaaDRZeEZFbXNqNjMxUnd5?= =?utf-8?B?ZGtiNTlnMUg1R3pvNHFwejA3TDQzZ0ZpemhvTGpRQ0o3bWRzWDl1S1ZqdXlK?= =?utf-8?B?Mjg4Wm5ZZ1VWdlVJYWgrVnBFcDhuZ0R6S3ErQVE1Sk4xZkk0TW5mWkc5MmFO?= =?utf-8?B?YXBQbFgvb0h0dGJRSzYzZHJLM08rMEZaQzZxSFpRbEhabHJETmR0alJlOThz?= =?utf-8?Q?LeqRSjAUticJPLDKcLgLUT4xI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68a740cd-cf96-4b6d-29fa-08db0dc280bb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:02:04.2935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JcVAWluptMFOZ7ZHGLA51nGkxwIntC3RulLzZ6OwWJ/z21EzGXhhMGnoTZACZrulJWD1Uem30d+Hq14dBpBKUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9341 On 03.02.2023 18:05, Oleksii Kurochko wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -18,6 +18,7 @@ config ARM > select HAS_PDX > select HAS_PMAP > select IOMMU_FORCE_PT_SHARE > + select GENERIC_DO_BUG_FRAME Please maintain (largely?) alphabetic ordering here. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:11:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:11:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494467.764532 (Exim 4.92) (envelope-from ) id 1pRYbm-0005Ea-Rt; Mon, 13 Feb 2023 13:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494467.764532; Mon, 13 Feb 2023 13:11:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYbm-0005ET-OP; Mon, 13 Feb 2023 13:11:02 +0000 Received: by outflank-mailman (input) for mailman id 494467; Mon, 13 Feb 2023 13:11:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYbl-0005EL-J8 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:11:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc282852-ab9f-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 14:11:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8285.eurprd04.prod.outlook.com (2603:10a6:102:1ca::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 13:10:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 13:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc282852-ab9f-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXTxfmDGSuvpfSIL2Q9xewORxAKarov1J5n/EdcITML9DF4M9e4SZKwDiTFYU1CtT4eiUujMP5e8BdVxIf7zuyue8blGQtGTHxuornO82gmLxoYdq0aKtuGLlI22Y2OPdlONiMpebypiRf2aX/GTW1k//o2zC0wuKdfk/ciIWREluf3fIB9nXfYIRNfkZlecymoHH+Ke4njL6xn3JH56iewGR0aLUbyQEr9Z0FOJBI68jF/uSKku7MZVzfZvA/E6M26oO30a0RforHWyoXQGx1dWpOrVgKtZiKx0yHGpB0yCs81m85+AFu4oPRixqZUF2qPsUVw4E8AJzgqzucC4Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcMWHlqaGGYXsT7zSNF8Pj/c8v0UVXl56kUhTRl9B+E=; b=lTKTmD1kmhXFW8CFzxZXvxqiW7FhhTPwZnlJ91nkItLpc//NeDdxLvB4BA/TlOTrTe/lzaLFfJJPMbBwdP4xmHQe/+uv3EyyS8PYpHyiM1sGdsBrSU6hIRD+eah+5RDpnwqmCKvLxFpK6nEKHlhyhCqgTJJjlXAGEhSJvPxdMpc2HjW07abZYl3IcgLPvmTxf8WlRG+TYZpicgjrODTjI2qM5diStLxqD1CChBcPNgbKPxjl/YkZKDfU6hzlVsyYkR5yui+0oQC7v11teylTrZ9fLov+hwrmjSt8dBEjCrXjoufr2vOY3l4L4FGgRNy0Q+/sHTeNGc9JnhAyQvA3iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcMWHlqaGGYXsT7zSNF8Pj/c8v0UVXl56kUhTRl9B+E=; b=p8BiPJvkv9TRHLWnl58CChVEKTodRs4XSKBl+UBYj0+GNQYc/3XVnMJha/+74KYFc6dhBkaSPOSBLFImAiNhC8iqzo0PJz75QgmojekLz+dHIenU0qAFcSiC9dNVCJ3XDgCFZdY2bf8LWl4XCNNqRYdseJbYBOuQr9Qbsi5in7NuvZYdUgMOgkf9m01Gvc2yKyqYdgwBaFk4DrEyn3prxMfEX1IyVSDnJQaARVB6RZyiJAj130Qmdzv0ODm6UaDtm6xZbqyQPRXXPM4CJ941iFqh4y12JozOTrFUBnUtaeiHwgV/EgNh6Vy8ONlGw6HnHBuZyZIIEZMMfj52G4PIrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3dc6cdd4-30fe-b66a-bce3-44e798576fc4@suse.com> Date: Mon, 13 Feb 2023 14:10:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 3/4] xen/x86: switch x86 to use generic implemetation of bug.h Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8285:EE_ X-MS-Office365-Filtering-Correlation-Id: ee492b72-a566-4cce-3073-08db0dc3be73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZfIwQ2OnmIv5QYJOES6/uhOyLQ7aimwdTEOjIFuVrWPhmw4D6fWyYZ8Q8eP6nCk9mcR7NzBALt12fPVBRlmaeCEwG9+SNV6G+P9LhlGeH4zCF0R/+bASTU8ayDd+4zZ1Gf140jWCgUzrv3iYIDevlPw6QxBUGGJXNdxVn5LxiWdiwSCGwiNGXOZChlgakTKsWXrw71oxyAJiBi6IfgV+rkYXy/kDEqMfpTPjyaGb6kNo11CcMocIb65JpekV5ig4uGUnUl1pEGtII1Fhb5ODZV+G5KuL8kK4GZ4loCZkMwLrVbiAf4zqppus4i9XB4+W+hKo+irltKI8UOqRio/oZ2VpCkjuSpO44SvAZR8hlRNXQGawRn0j1kJSgbte1ITyfh+5snEm4x+HnKAw+noHA/Y5+F0gcT3eI0LuBu8ObzbXzi12MSWP7VEyPvBGvF0l6W9rUp6IgOLLbm1LTbh+rwC5fM60UI6Dv+l+RI+FHj8lPV2A5WpszVlQTjTQBnZmuAaMbosX7MKvfvT6aHlmb7DnfhInKXer2TO/+QXKWoyKvslcXfEmd7eyvMiePtBKUJmylu5BFm+ZPB1nhUS327Zgrv3SzMqM/GthyzF6Ik6rXVI123HdtOU4nyaRlGHyj9uDmTQR4DRtbDWhgMpq0KmeDWIb+r48GgRdlAvJBe68liNJcrvwx6mlM2icTUy81HZWt9xz4j0Z5AupmyYyO7vQ3iQ9pJwLNvjkS/ELgdo6WwhS3UyTBx4RWOATN3n+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199018)(8936002)(38100700002)(31696002)(2906002)(6486002)(66556008)(66476007)(8676002)(4326008)(6916009)(66946007)(41300700001)(5660300002)(31686004)(36756003)(86362001)(54906003)(6506007)(6512007)(26005)(186003)(558084003)(478600001)(316002)(2616005)(53546011)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2YxbzFsVVNXOXhIUXM1OEljZUlDREJOcFVUeDQxME96NWN5K1lqTjdzWStS?= =?utf-8?B?NEMxRGV6cGRETHFnL3lhNE14bmtsSEx0ZE5wdjFURW5nNFlseWdJcWJ4OU9h?= =?utf-8?B?Q2hzWVFtZDVwZ0lML25VWGMxVFhid2g1R0Qyek54STl1ZnBaMGFjcFczTk95?= =?utf-8?B?QU5PNUhwdGZaNkRVWndKS2oyTjlVbWZIZWlZT2dORVdiKzlPRnRXRjNYalNu?= =?utf-8?B?eTlKOXNJbXZJYVI5NEhZYU4xS3BIcGUvc0hORjBVaGsxZzRNREhSL2lkNEJE?= =?utf-8?B?SzRVaC9vWnRFbEtsdURHY2RjTkdFblJTeGtTMWdrWTcrL1RmMk90VENmZlJt?= =?utf-8?B?U2pOMnM1QVBNQWwxeE4rTWVLaFVZUklnYVRIR2V6SVd3aXRzNE5NT0Z0YVlP?= =?utf-8?B?dktXMXV2Kzc1ZnRtaE5tYUs5d2lINEg3SXNOMWRiMGhHMkJsUDZxMTlhSS9D?= =?utf-8?B?ZmFmdXVPa1Jqcks5MmczaFhtUytjckw0Qmd2bVE3VEZ4WVVNQ3hWVGNOL0pD?= =?utf-8?B?YXVXWXlVbzVmeXZKY0tpd0NWTTJ1WlN3K3BZV2I1R05yREhtOXBWUGF2V0Q1?= =?utf-8?B?N1Y4bjVFWERYSFVBYlkwUnd3c2E4QzhyektoaUNjY3N2bzA4Y3ptRHZBZjZr?= =?utf-8?B?VFB4dzVOUXA5NUt4bkdkV2RNRXVqMjRHTUhSeXVKcEJVMFJMUlR4SHVUNGlj?= =?utf-8?B?UzByaU9pdlJsaE1NWFBCQ3Rhb0J4bHhMemp3K2grdURqUnh3WFNNcXFXVVpJ?= =?utf-8?B?dWY5MG5uanVKNERxTjJQd1VHaWFDblhLVGViLytCWEZhcXluSHB6Rld0U2g5?= =?utf-8?B?aFIyOGlxMFUwdlF4YThwVWZvMVpMSlhrSHY2c2Q2Z3ZlR1RSZzJtclRFZ1VN?= =?utf-8?B?clBOMjlULzZkdXFacy9rWGxwSWR6cFlvMmVLT01YNlVRM09vSXRzNnEyeW1J?= =?utf-8?B?cnE5VTZ6SXNDWEhSZzQrRVREajErTGhhbHE5WHhUN1ovTVRYTFFwWE5PdjRi?= =?utf-8?B?OWNKdVB2bEdWdkRHZDM3TXFXMFZ1c28rTE5abmlQNkF3MGdOUFhjbmw3UFVI?= =?utf-8?B?alJuNER5RGJRWCt2Y1FBUHRZdGFkL3V2M1h5bHdRdEpRS1U4Q1FSWXhHa3FI?= =?utf-8?B?aVdZTHJEeStEWXY5MngxUklLQ01nMjRMYWFZVnZwU2MwVkZXcGp6WXM3WU0r?= =?utf-8?B?K3V3VnZ1Vlh4ME11T3BYWHhkOGNscGdHckxMZjdIZkNTUzhNdUVybFJ3Qjh5?= =?utf-8?B?SUFIMVNyTFJsMEY2dDZzcjhuUk9peWxTUTAwTVQ3NE4wbHNZU3YzWlRSQVE1?= =?utf-8?B?VmJxdWE2OXU5NEtNUWxmRFpSdHJNaFdkOGJXdjB2cDRiYUZlTis0RlI1cHRy?= =?utf-8?B?SGV4Ky9MaU02RGRmNnZJNHdKOEcxaHJMR1hmelRlQUJQVG1YdjBBZGpqWk44?= =?utf-8?B?VGdCQ3hkN3ZXUmM0MWIxZ1UyL25ZM1luUm5IMU11b00vamhWbFpsNnUwZVli?= =?utf-8?B?N20wT00yUDVCVlZDYlU0Z3ZkL0poWWxsZGMwQWh6Nm9QeU9PdHhKaVdTN3VT?= =?utf-8?B?TjU5bVdXV3BCdDhrNWxoN0ZGNkdvYmJkeElNRDNlSEZmKzZMTGdKOXZpdWpy?= =?utf-8?B?S1VzeGRsUGdic21xb0pla2RqNW5sNFNWM1dnSmxqS2gvR2c3eEI1WDFFMksv?= =?utf-8?B?eW13Njc0UEFWaEdra0xYenR0RjZPeElQVTdxNTA3dnRkLzNPWG1DRFRjRGhC?= =?utf-8?B?UkJ2UW5NSU8rSk1iUVVockNsKzZpS2pKNDJCU2hVdGJWbkFZczNnU1ZVc2x1?= =?utf-8?B?N09NUFNoVnB5MkczS3A3YWN4SWRQdW5weHBMaW9iWVJ6OEYvNjRHcWZhVlR0?= =?utf-8?B?dis1dCtaWFFScnprMkhveUFzYU1VdFhFUmZWdXJDVG9GUVlXaE4ydnh1UFFx?= =?utf-8?B?clNyeUlhSWFsMGEzak9FQ1R5VXo1cVZiMUVGQ1FOeE0raFhna3l2NUQ1Rmdr?= =?utf-8?B?WG1Wb0hMVEpzZlZjbTNKUVowQ2QvSmU5ZW80TzdzUTFmSUwvZGpXaVAwdFlB?= =?utf-8?B?Z2g1WVJlT0FJb3BoVmtORURKVFNxQ2wwOHJXeGE4MzJhUEd6eXpzdm9kRlNU?= =?utf-8?Q?/4TFccF/5JSIdq2GXabT1pDRQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee492b72-a566-4cce-3073-08db0dc3be73 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:10:57.3685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +OFUNfPKmDKwvwqP74+rTLQqhCLXiNPdF+56roAHwomlglcUpoYWIm3UUpEUV5UrhY1JX4rIohny78ULesO89g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8285 On 03.02.2023 18:05, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Is there anything keeping x86 from also using the generic do_bug_frame()? If not, switching over would then likely mean no need for the new Kconfig control. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:14:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494474.764542 (Exim 4.92) (envelope-from ) id 1pRYeY-0005qW-8h; Mon, 13 Feb 2023 13:13:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494474.764542; Mon, 13 Feb 2023 13:13:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYeY-0005qP-61; Mon, 13 Feb 2023 13:13:54 +0000 Received: by outflank-mailman (input) for mailman id 494474; Mon, 13 Feb 2023 13:13:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYeW-0005q3-Kr for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:13:52 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062b.outbound.protection.outlook.com [2a01:111:f400:fe1f::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41e2bab6-aba0-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 14:13:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6903.eurprd04.prod.outlook.com (2603:10a6:20b:10d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 13:13:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 13:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41e2bab6-aba0-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFQ74wYfU3hP+k2aqqlIfCnhAIDW8wPZuH8gYcf8VEURFWg9QMA4+c5biQVpwFEafHBoyOz6QtznPoLWx1sWlRmW/4ccAGPRRV6jn8oUJMbkwW8619L9kdhEGhL6alxpzNz+Bwd9KxZn5VU2ZtIvX9hlQlpXpgwSvcTVLSCPyZHrPl98ZmjqbHlz6Bjaz8b6MJoD4r0HmU8tyHgaS48u1R1K7FhONgGf0PEXh8hZ0qAKjwDpWAzmYfIsNHx0At4h6ku8lHjtHqCyEUCG9Qz3H4TDT6HGNN27In1z7bBvLn93Mrkk6Ce3iy027cXbhS11q3DvspEyLog/N8iLtslsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x98zAvMGEEcmjRtGcu7+qhbLmziWB2IG23JPGgudsqY=; b=jdk6zsH/u5xcJS5axnPFTpbvPgIZZIfpVRkSRXNGTy29ZDkiCJvBhtsnpVWmJ64rKiaur4uPPhAM9OnLi6opSwvcpS3TRCH2ALyKRLmoTF0BbfJrypyL6QjVUECk7L8brFb12420MuNhslIiimdS5SDhFjBI7eje+aP+0/HByEFJzUqGi5WetKCtNJ1Vk+X3F42wWNkDY74A4XwrYcASOl6ykvwb+/Ndtj5I3eN/F6KfAwAjl4W+cFlzAcWwf0GpFoqOv12Q5arjJAO2XRICSbT0IqnFUPGQJ98Q3iV6WBNtcHxMNYgsic5/qS9h/WwogNVkv5bmICBIRlEc/TUmQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x98zAvMGEEcmjRtGcu7+qhbLmziWB2IG23JPGgudsqY=; b=cyH+rTuTvSy4B/v2mf/Y251kdv0mC3IxOkMV32dL1mAUFRv0fvRNX3Jng6wpwjQaAFYd3IB3NWjMgpr/GEbgbpzlREMaq3dLy7UFoLZD9y+b2qdsQWqvxt+yTGvHqc/PaiUQ5TjnxGnNpZYiLAnjEirNYgxV4cPyYoOUCnsAmXJcQ6kM2/6CAErvbiPpU+11jgerqY2YSmAeTSjh73R3o8Lj2m7Df3ia2Sm3RpZm5FXkSXXnbWPCV/SFg86/rAeSXO2wKV79qIi9rEU+MlUZ+20akKEr+4H/cuZ8BaY6zfR++myRZMf1cs0Ihkcox9G0yCWU6sT77nakEcf2SsSzVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 14:13:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 4/4] xen: change to Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <5a427934949e3b0cf6026c8ad6c62e37e5250ca7.1675441720.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <5a427934949e3b0cf6026c8ad6c62e37e5250ca7.1675441720.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6903:EE_ X-MS-Office365-Filtering-Correlation-Id: b1f73001-5dfb-49c2-942e-08db0dc424c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kim/BDroFtVLohwKDhJ3cB8fz8MH98N0lFjwprzt1aocxP85kaxAnIp8Q+bAxYgbrBBAKLEH8AjDWwVR2yv7QXicFq2O8smS1an/ukAD7MuGYiKYfJrchCYZkMzt0TCj43t2cY46BDbBpUjgwtjyqh7XJ2HN/ngDW12pYzz/VcstCiFw0FAFDgMUaEHqJY3H4HmWz3nDYA6nN5W4QUzRFI944XJvRN4K5BABxW0dfvUn2QiWAHstLovmVWEsRrwAeXpsYXZ9cYBVyyeBvtlQKCzFnLT8wXSU5kSPy/Uy36MSEzjW4K7zNrv2jYs2AwnufWKD0gesj/vMAVGSohBW1PM1QariCwpbfLH1VqWN7BeQTZBdoalMXBGVyp7dqV7kMhCF4i/klJvs37bn9oEOjf7qxFdNmYNsYXQvExzyuJk6Nlm14I3n7YbIeFwCynlF8xjmk9AhKFePqzh1gnkpVu4XhBexop6YCe8Bt9Egsa/ZX0buN6wHz86+aD/g9ZXmO4y/yXNqTrmLHDVG+ZofbTMP6KFHt35cY8crxwQYsExdkIIA0s1taytI0auKPJJGpqvpBQ5QlMOB+SXgEFniel4savrhJAayqvjnKwWzL6JE1dM2EXqBW5N72p6UfdTxdK7i+HA9JaDzzzpHqWRTyqYcBibaZsVqZVZ3TZ/uQgwPzCqUUQnm7NanWLacPfMkQiJjv8XVyKvnl5emOgaAQ50GplaeWtLWDnacx17LRW4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(136003)(39850400004)(346002)(451199018)(6486002)(6506007)(478600001)(31686004)(53546011)(31696002)(86362001)(6512007)(26005)(66556008)(186003)(316002)(4326008)(54906003)(2616005)(8676002)(66946007)(66476007)(6916009)(36756003)(8936002)(41300700001)(5660300002)(38100700002)(4744005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0ZZVklNa2loUHpwZ1V3WjhjaFM5N3B2Wkl6M2MxZk13ZUxMZlN4WERvSnQ0?= =?utf-8?B?K1VpTHFmRHI3Z1lmZlIxS3JlOUZ3UFYydjJ6RGdJZHVycXc3ZUxHYmwrdGlR?= =?utf-8?B?dEhaSnBzVkVwOUlmUkNDZ0pBRForV2xzQTdNTmxjaVRSb2ZzT2RWYmZvaUw2?= =?utf-8?B?U2Z3dlNFblZDUlZoYjFFWmtidUExT0VlaXVSVWdwVW1MUXZpMDZaVXRFTjZZ?= =?utf-8?B?emh2V2U2QVMvanIyVEVBWmVUekVpaVcwelo2ZHdEanNmbjZOdy92Mm9TQUVQ?= =?utf-8?B?TTB4YjhzQk9MU09YQ0FEYnJ5NkhVWFVjTldBNXZ4WUxxTi9ZNFZvNU1Ld0lB?= =?utf-8?B?b1hVWm1WN01MZFhDSHgzcUViQTRsVk5meHRpTk8vbnBJY2dQcy82WmhOVkNW?= =?utf-8?B?UW1WTDQ2LzBweEpQbFlEYzFoSkhDditHcVAzRUkvUEkxblVMcURwcGFMNGVH?= =?utf-8?B?bHlUOWpZcDFBOFZ4UkVOa0hadnB3VDE3WngvMC9VZENaem5qa2NMN3hxOE5K?= =?utf-8?B?aG5TRUVhbFNweS9zcXRwQ3BpMU5Ja2c2dEhUK2srTXU2YWZ1L0RlWVR6Z1Fo?= =?utf-8?B?MVBVSXk2RWN5a1F3MXFHZjY1U2pyUVA1VTB1VGg4OFNobHljUnYreUJmaHVC?= =?utf-8?B?SW1JTUtFM2o0QzBJVmt3eWxLQzltOG9WNWZGSnljZkxvdGhzeEpGeXhoZ1BY?= =?utf-8?B?QnZTelFyS2NrUHFjUGpGUjArOFpmVGttNzBCQ2dJV2Z6V3k3MWloN2poVUwy?= =?utf-8?B?UkFSdUlyMXViTThXTlJKbmMzNlZ4d2pmdkR4UHNZU05hNFVIQ3NYNlhKM2Q1?= =?utf-8?B?aU52ZUxWd2k5RHlacTAyQ3Nwa29JbHhnYXZZL2VlaGhvZnF5RlRtL1BvZzJs?= =?utf-8?B?cDRNd3NQM0RTZ2lBRldzYkNOQjRGbE5IZ1d3aEJNbWZObk8wT2oyR01UcVlT?= =?utf-8?B?U1lWNlluWTdhWXVMUkhrOVV6eDhnTUJVTWQ4Tmw3dVVTcjVaNFdMWHJzVFBL?= =?utf-8?B?T1UxZjJFV2piVG5idXVtMlVOeUNiQnl1WkRNZVIzdUFXbFpKbFpCZkM5TjFi?= =?utf-8?B?NHpHSXBWbkJIaG1DTzlQbkxQSU1LTTIyVmhtaE9La1lsVlVoRlM0T3R5RFI1?= =?utf-8?B?T05xdE9PdlJVUWNPSTY5THUyNWFRbG1Ia2h2NjVYdFFLbjFHcUZSNDFZdThC?= =?utf-8?B?R0pYaE5MR0RtUWhDOTMrbkpKM05UUTZ3V2FIcERYajRPRlI0S3BnRzBRQXIw?= =?utf-8?B?SHdDaHlOaE9RVXdDdlhFc3pDdW9Ub2VERDJoQTFmT0lXWXBIV1E5a29hdVB5?= =?utf-8?B?eU02M2tSRE0vR3dmTGwrVWlqMGZXZWVPeXRYRXVDSEFuUm1KUjRiMVNhSnpT?= =?utf-8?B?Z2FVdFdaTzRESmczQVFTd0Z5NDJPemJoaGtodE4rMTN3UEl5TEU2MEtsa09V?= =?utf-8?B?c3lBSkhkcDRpaGQ1SUNFL1pXTXFIWHJWUitzS0docDZJSXFwNWp1ekZpUzZa?= =?utf-8?B?TWhOYkRDbzNzU1hkcUhkbXB2amFkMmJoNVR5M0kzZmZvaHBiYkV2R1EyYUI5?= =?utf-8?B?VFlUbmFIbmtrdmJkcmVhbmJJSkQ2NDB3VGtxZGI5SkFCMnhQQlR4U3N4MnFh?= =?utf-8?B?MHdXVWt6SHQvdWp5Ym9oLytEVERScU9RS3dVVndsbzBqaTRpSHVzZHQzSnQ4?= =?utf-8?B?K01hV3J6Nnp6NmVxcDZEQ0pEbnJXWXhIcnE4dmFXQWFuOHdPWm9CenJBRHFX?= =?utf-8?B?VndNM3JySlFzV0YvWkxCS0JLSGE0dkNrNldWZVIreG1hdFBVNjUyZHkybFlK?= =?utf-8?B?ZUFmaXFIVjRPalFLTnRMbzFFMDVsOG5VQkFXYnRYaHM5WU53UTZlWGdqaWJp?= =?utf-8?B?b3pIaDhmU3JMQ2NWSTdSdStNMjcyK2pCKzg5TUk3NEpldWdPMVlSOFIrS3Qv?= =?utf-8?B?V3J2ZUdmcTk0R3gxRUtHbE1oM0MzL1BGQ3Q1a2VxL25qS0pHSXMrVHcrZVRP?= =?utf-8?B?V09oUm41RmJKSGhNa3VnWWxYVU8xem1MaVAvMlYvcmhsODFOVW8xL2kzT2Y3?= =?utf-8?B?UEFNaDRTTThXTTlBUmZSbW0zTk5QYXoyb0dUUy9GU1FRRkViWWVrZG1zdWZJ?= =?utf-8?Q?AEQHqEH+lZrYjj9gCRPUzz+b/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f73001-5dfb-49c2-942e-08db0dc424c4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:13:48.6702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2LENhdG0r8ieUWfFw7lDrU8BtnTp+wzDnqVfE+39oknNycIj4r60Zvuzsd6Ro7JzggV3G8fF4E1uBgHwnBNB5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6903 On 03.02.2023 18:05, Oleksii Kurochko wrote: > Since the generic version of bug.h stuff was introduced it > is necessary to rename all uses of to > > Signed-off-by: Oleksii Kurochko Doesn't this change need to come ahead of at least what currently is patch 3? Or else why do you say "necessary" (I take this to mean the build otherwise is broken)? If the build works after patch 3, the change here may want to be drop the unnecessary asm/bug.h includes instead. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:15:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494481.764553 (Exim 4.92) (envelope-from ) id 1pRYgN-0006Pc-KT; Mon, 13 Feb 2023 13:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494481.764553; Mon, 13 Feb 2023 13:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYgN-0006PV-Hn; Mon, 13 Feb 2023 13:15:47 +0000 Received: by outflank-mailman (input) for mailman id 494481; Mon, 13 Feb 2023 13:15:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYgL-0006PK-TA for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:15:45 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0630.outbound.protection.outlook.com [2a01:111:f400:fe1f::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 853102a4-aba0-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 14:15:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6903.eurprd04.prod.outlook.com (2603:10a6:20b:10d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 13:15:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 13:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 853102a4-aba0-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/W1mGUsmas+5R96wcRRHp8e2vHNr6MyJYHkMi1mro5lsc1BeFPPzeWzg2iCtddFJZzhqWMjuX1NUfRsGNH911A9rKNyzEnSlmjnxwNGYUgoHgjW7vYc21GWK2ePyOj86GcRY3K+IJNxHxKtd15PoxGuSoo4uZQQw840OlkzCXNJJhsQjRYe3iyb2v5Xzeg3R5DgEYzRih93XLE63f3cItKunWxXq+5IVp0MEuAfTcguX0lPF3/rIx4jsC40XaPPGR/2nrGJSkVntoeHjorJ8nHJ6BIgvhR1S0oThWI8QvWZ0EtYsEKEPiSKwHJTA1v0oAMct72Stn3htTmXQIsTRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S9QZW/TJgcYW70GPlUd5E60yboVrl3mjfoXh880ekTU=; b=gFFRPKF0GPCl2RUrdqj2ccdHPakRI528RmLNPWMIkzm1XJOjT4YNp1lN72NEMGBAtbu8YKc1KwU7gBFnEX9QXMrxy1pBz7aGST4fqYmZ1HNcQUdfoIS2IhmXQnlj3yeIw2ZC/UE7L+4bk0cmt0hfslKQEYRuCezL4q9vqGH2R/ZT1NcCSCGeZuVXFAVq1nV3GP47u13CwVeNpAYFqGQYJObZJ0FN9agSJBxwTQ6Up2iVFqGUfzYfzPJm69pBb6SKG6z6vWKWAsF6vrfCF9vgZEuQjWldwhCEiRagYH20li0/JyIdrBFtGozSh6XrSX4pfv/s1zmSlDm3DBXmrcl0rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S9QZW/TJgcYW70GPlUd5E60yboVrl3mjfoXh880ekTU=; b=3RdDmitA8GtEpYi3FH0ZW8S4MIA6evRKPNF+Hulo2zIoPbfO2BFUkUTxA6UmJUBxo1y43XCCWiNhbs399J+25C4wpHZlVRiy9WP/k1cK8tXviOPQCG4szPNt5ELKg4aa7R8r7COROdMOzWz2H5ZJX7+XdxAs9O2ZvH1sJOTNf12u8CVaTUc1dMYsg5h+x/EUwHKYF60f6I5wUZzeoJ1x2WuKxEHC0KJpXUyi5vl0IoVxi7P5myEq1otLkB6hqWJPrbrvuNqKfz7ZqK6rBfgVbYNB+A8y5QgO6EvoIHTNtv04HdvlBh/nRBlTU+TMSPZ/0BR6S4x5mw9nxbECFk4YwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3800fe2b-6e20-d225-b57e-fdd3553b0123@suse.com> Date: Mon, 13 Feb 2023 14:15:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230213115017.902037-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213115017.902037-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6903:EE_ X-MS-Office365-Filtering-Correlation-Id: c7bebc5d-ce38-4e89-d2b9-08db0dc46835 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J97pDUArMQhoob+CDn4c4+Hik+KoIVF8Mb5sSaG3Nyo1lJEzrp0lxwvysDeRPcXaLy8fRyfqyLOyEAkLZsTuuDpT3vaV/mfajfeNLXa97fO4sJg1jvA33d+uAOw8lZUREsGQN234ixSSGtjiad8ZFw9Xsy7WHH9i1ppdeTm9CgPT777VGGhseJAfLR9Ou2QxfqT4v/5JTg0mc1zVtsAvWGIlzKqVpE+SUvdDNus7We1a2qrgE0mTMBssOvM72qmRZ+mpdVYVBbTzgf8Rg87KngYzRSI25yjd5P+o7QSCjDavcpjJG/G4kbi40i+xjffViwatGXenbABuB4lFfnUArm5pXONztKM09uxYDuQlL/a2FnLYwcLh0lTiuAJEAkMbvlTnEn/bnDGmlZSoepv6lR/Oc0BEF3C/xAvGzpPFN0U+7AX+dYZhi00/cOsFlA5Db8NX9TnZF2BtpjjRxCM6ja0HFPEmvZM6YiGeIoFX6sykkM4JWUbPn4duGFC3fEPnhwZ9LIrrgZ3fO4ef29jibyMZRNUCrfglZ7QRdIGiTkCBXkrvOFm/b98fatTQOLQg1OCpAGgVs3+PtOuCeLnWxfHsoa+k6m63GKHknXHD5lW38/kvStJx9CVHqHArK8JD4sxoSLYM8ZnfhUsab7g/0pZyU7vVjFEX/VTCTddvODufoJzvRhs33I3/EKUbqJA4uF3joL2GdBnOEwD/r93/EAdP+/S3zQLKfwmhpoZljOM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(136003)(39850400004)(346002)(451199018)(6486002)(6506007)(478600001)(31686004)(53546011)(31696002)(86362001)(6512007)(26005)(66556008)(186003)(316002)(4326008)(54906003)(2616005)(8676002)(66946007)(66476007)(6916009)(36756003)(8936002)(41300700001)(5660300002)(83380400001)(38100700002)(4744005)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE11NTVrcFVuTTY3Z281NXQvVytzcE9kbFdmclZXRjhmYzB0ODJRVnZrRGZq?= =?utf-8?B?WXhZcTZ4WWdmbXFDdjQ5TitqVmRscUVPQmFMcnlvQ0V1MzlvZGRVVTRvYnBM?= =?utf-8?B?ZnJ1Tm9lNWk0QWhhS0hNZTQ0MkZTckQzVFZTTmVxbUY5M3VQa1orckpnTWV5?= =?utf-8?B?anlhd0lqQ2t5Y1RhMktjMGxlV2ZlK0taRENNcmJaSkVtcldPSmMvOUxlQXpO?= =?utf-8?B?WkkvV1FuQ2xSTHZyOGdDRGQ4eHNrYmxWTjFQYTY1NlFYdUNiYXJUZXovU0dS?= =?utf-8?B?VXloM0VlNkJxTE5WeXI1L2UwU1RNc0Erd0x2TnpFeU1BeGRJMjhrN0JqaWM1?= =?utf-8?B?bkl2TEExTHROK2swT0h2cUN2NVdtdCtxTVRUM1cwa08vWGRWQUhFYzVndlQz?= =?utf-8?B?NlNWRlFSYURLcDZFZjRwbklyNEpYY245TEpseC9uTUh1UE9WMlVYeVRNRzBZ?= =?utf-8?B?UXEweTZUWEJWRW1MSnZmSjRSRTJJcjE3cFVmRXBnQU1wVVN0SnhJY1BKeW4y?= =?utf-8?B?N2wzRWFUNzk2VmlIZ1RtQ1pXRlBmWHg2bTJnS3ZNa3d4S2RMUGVjbW1OcWxy?= =?utf-8?B?UjZNRzh5VmpUa2lQaEk2MDZYMjdpY2ZCZGhVN3JiTGNUQnNzMndKc2w3WVhr?= =?utf-8?B?bVhTWlJwRTlwNFAyNE5QZ3AyM0Uyc0R1dE1VZWcrbUpWOXprZDBscGkyVzZJ?= =?utf-8?B?clBLQkFtQUdadVVVWGJwYVZuRVAvclpHcHBHckRqdUdRL2pYb0dlYmM1NjNP?= =?utf-8?B?d3J1VXVGMnNmbDZpYUVEY1BoRU0yQTRLcVBZZ2tERUdHRVZ5S0kvVGdxeTNr?= =?utf-8?B?SEgxaEcyTnczaFcyeUZZanhIRHRoMURlZW9yVDVhb0hCTXRSQVFwU0lIWFds?= =?utf-8?B?aWhBMXJvMmVJWVZla1lsaHJTclJ3VXVNdmZYMUFraEROcTcwWThwUjBSdmpV?= =?utf-8?B?Sk1GdlNYVmFYOUdGbGNoMVVjZmpoNjN5anRIOEgyRTZGdWErV0dzTGRzWm9R?= =?utf-8?B?U3BRZmJrRCsvbW9BdHBVRlNOSS9OV3Y4QSs5bTU5QzFkWWRCeWE3KzBiOWF1?= =?utf-8?B?czY4VEN1K1dmTXFLVndBMWExdUc4U0FMbDVTQ1JKZUZoMG4vMnlsK3ZmdEE1?= =?utf-8?B?NUo4NFZYQnROK0dobXZVSVFLUjRlS3cyMTFMT3I1NnQ5YUNsNXBjMHVKa0ZD?= =?utf-8?B?VXZUQnhFbXF4aW9EZG1oSzZJTXg5OEdrV0NTVHg3Y1paRGQzMHNZb2tpUGsv?= =?utf-8?B?eEFRTHNyQ28xd09INFJoNTJMdjkwbkNQRURXVFEwYXMxWVVvTVZIMVhNT3dy?= =?utf-8?B?and6SHdNdzdYMnhvVE9DaXhFOG1YeW1LWi9wVTlmRGtlRWlnMXVVREtIbXJU?= =?utf-8?B?dFJ3VjRKV2pJT0RYMW9zNnlneTkxV1pMQis4dzJ1T1F0NUN6MFhld29GcVRw?= =?utf-8?B?cCtCZGJMNUJyQ2NlcUY5WGlpc2I5WmxVd0dCNFNDL3JvRm1iUDVzY042UnBu?= =?utf-8?B?M3dWVU9lbGMvOXZQNklnaDNJWXVXVFhSMS8ra2ZuM0xvalhNVHRzMmJ4ZEVJ?= =?utf-8?B?bnZaMm9qMWVPQ3F4ZnQyOTRWV0ZNcndPQWlibE9zZGc2bTAzU2kybzFXT1Vu?= =?utf-8?B?YmVsQTNjbXRIeEZybEdDVHR3aDk3VTVsNmVLMmRpd0dtTnNhS3B2bG9Ldk1p?= =?utf-8?B?QU1MeFIvdVRia0JBWnBZRXR6ZnFKejJSRHpkdWxLdlFEdHdPdlY4VkJBK3ll?= =?utf-8?B?dzlHMXZzTFpKUlY3UUxoR1VpU2tLbkFjYUpoWUg2ZnQ4NzhzL1pnWUkycUtt?= =?utf-8?B?Z1hnODIyNHlBc0o0b3p0MG1vUVR3clMvVFF3RWM4WUNDNkZYSjgvZU41eXpr?= =?utf-8?B?VWZ0dW9TSXZ0UGtaNUk0U3g1TU5aTkxlNnFJVHZDT0xQQWRkNCt0aEN0V0Uz?= =?utf-8?B?UWtDZElWNjNQT0tyaDR5WVJDT1dCdUdFc2dzaWF1Z0sxamRDS3NrUksrRGJx?= =?utf-8?B?TUVjNXZEem9CM2tIaG9XTThTZGIzYTBLVUwvdzdrSmF2cnpvcCtsVmR0Vm52?= =?utf-8?B?UHkzSzgvcmhITjljNmluU092czBlL1M4RWl5U1pNSU1rVU9SVWk0NFUxMmNH?= =?utf-8?Q?mR0uI67GuSAFThLSRZ/ay0msM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7bebc5d-ce38-4e89-d2b9-08db0dc46835 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:15:41.8040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NJ8JOIUi0nizfRaavhlqD4oioRgmhnEP5ZYYoyrwBeZ8rNMtrYxG9Idhvn0Iq7kF5g+FUHCTlvfsBe1JuFa3uQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6903 On 13.02.2023 12:50, Xenia Ragiadakou wrote: > APIC virtualization support is currently implemented only for Intel VT-x. > To aid future work on separating AMD-V from Intel VT-x code, instead of > calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub > to the hvm_function_table, named update_vlapic_mode, and create a wrapper > function, called hvm_vlapic_mode(), to be used by common hvm code. > > After the change above, do not include header asm/hvm/vmx/vmx.h as it is > not required anymore and resolve subsequent build errors for implicit > declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including > missing asm/hvm/trace.h header. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:19:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:19:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494490.764564 (Exim 4.92) (envelope-from ) id 1pRYk0-0007FE-8O; Mon, 13 Feb 2023 13:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494490.764564; Mon, 13 Feb 2023 13:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYk0-0007F7-5W; Mon, 13 Feb 2023 13:19:32 +0000 Received: by outflank-mailman (input) for mailman id 494490; Mon, 13 Feb 2023 13:19:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYjz-0007F1-1V for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:19:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYjw-0006D6-MD; Mon, 13 Feb 2023 13:19:28 +0000 Received: from [54.239.6.185] (helo=[192.168.15.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pRYjw-0003Lm-Fx; Mon, 13 Feb 2023 13:19:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yhGpZgnntPpRs8Hh5jCyIam4Ay/fHr95E6vic4Pnb3M=; b=cqV/1y/Q0mKTkgNf9Tyz80Kq71 ASvZ6Ave0hB0Ph8nnd0jyQLQmzdxaQpucP6UGhHLZiXuiesUwx2Bsj1YHTqHnP8mk8uy6HODRZY2S B0VRqDykKezORqHO5gV59SCnTTAv1LY/xLNjELvqfvAHuxipLhd8XeZkz4ENzHkqtsL0=; Message-ID: <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> Date: Mon, 13 Feb 2023 13:19:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Jan Beulich , Oleksii Kurochko Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> From: Julien Grall In-Reply-To: <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/02/2023 12:24, Jan Beulich wrote: > On 03.02.2023 18:05, Oleksii Kurochko wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -92,6 +92,12 @@ config STATIC_MEMORY >> >> If unsure, say N. >> >> +config GENERIC_DO_BUG_FRAME >> + bool >> + help >> + Generic do_bug_frame() function is needed to handle the type of bug >> + frame and print an information about it. > > Generally help text for prompt-less functions is not very useful. Assuming > it is put here to inform people actually reading the source file, I'm okay > for it to be left here, but please at least drop the stray "an". I also > think this may want moving up in the file, e.g. ahead of all the HAS_* > controls (which, as you will notice, all have no help text either). Plus > finally how about shorter and more applicable GENERIC_BUG_FRAME - after > all what becomes generic is more than just do_bug_frame()? > >> --- /dev/null >> +++ b/xen/common/bug.c >> @@ -0,0 +1,88 @@ >> +#include >> +#include >> +#include >> +#include > > Please order headers alphabetically unless there's anything preventing > that from being done. > >> +#include >> +#include >> + >> +#include >> + >> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > > I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like > environments that's redundant with "unsigned long", and it's also > redundant with C99's uintptr_t. Hence when seeing the type I always > wonder whether it's really a host virtual address which is meant (and > not perhaps a guest one, which in principle could differ from the host > one for certain guest types). In any event the existence of this type > should imo not be a prereq to using this generic piece of infrastructure C spec aside, the use "unsigned long" is quite overloaded within Xen. Although, this has improved since we introduced mfn_t/gfn_t. In the future, I could imagine us to also introduce typesafe for vaddr_t, reducing further the risk to mix different meaning of unsigned long. Therefore, I think the introduction of vaddr_t should be a prereq for using the generic piece of infrastructure. > >> +{ >> + const struct bug_frame *bug = NULL; >> + const char *prefix = "", *filename, *predicate; >> + unsigned long fixup; >> + int id = -1, lineno; > > For both of these I question them needing to be of a signed type. > >> + const struct virtual_region *region; >> + >> + region = find_text_region(pc); >> + if ( region ) >> + { >> + for ( id = 0; id < BUGFRAME_NR; id++ ) >> + { >> + const struct bug_frame *b; >> + unsigned int i; >> + >> + for ( i = 0, b = region->frame[id].bugs; >> + i < region->frame[id].n_bugs; b++, i++ ) >> + { >> + if ( ((vaddr_t)bug_loc(b)) == pc ) > > Afaics this is the sole use of bug_loc(). If so, better change the macro > to avoid the need for a cast here: > > #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > >> --- /dev/null >> +++ b/xen/include/xen/bug.h >> @@ -0,0 +1,127 @@ >> +#ifndef __XEN_BUG_H__ >> +#define __XEN_BUG_H__ >> + >> +#define BUG_DISP_WIDTH 24 >> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >> + >> +#define BUGFRAME_run_fn 0 >> +#define BUGFRAME_warn 1 >> +#define BUGFRAME_bug 2 >> +#define BUGFRAME_assert 3 >> + >> +#define BUGFRAME_NR 4 >> + >> +#ifndef __ASSEMBLY__ >> + >> +#include >> +#include >> +#include >> +#include > > Again - please sort headers. > >> +#include >> + >> +#ifndef BUG_FRAME_STUFF >> +struct bug_frame { > > Please can we have a blank line between the above two ones and then similarly > ahead of the #endif? > >> + signed int loc_disp; /* Relative address to the bug address */ >> + signed int file_disp; /* Relative address to the filename */ >> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >> + uint16_t line; /* Line number */ >> + uint32_t pad0:16; /* Padding for 8-bytes align */ > > Already the original comment in Arm code is wrong: The padding doesn't > guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes > size. > Aiui there's also no need for 8-byte alignment anywhere here (in > fact there's ".p2align 2" in the generator macros). I would rather keep the pad0 here. > > I also wonder why this needs to be a named bitfield: Either make it > plain uint16_t, or if you use a bitfield, then omit the name. Everything you seem to suggest are clean ups. So I think it would be better if they are first applied to Arm and then we move the code to common afterwards. This will make easier to confirm what changed and also tracking the history (think git blame). That said, I don't view the clean-ups as necessary in order to move the code in common... They could be done afterwards by Oleksii or someone else. > >> +}; >> + >> +#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) >> +#define bug_file(b) ((const void *)(b) + (b)->file_disp); >> +#define bug_line(b) ((b)->line) >> +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) >> +#endif /* BUG_FRAME_STUFF */ >> + >> +#ifndef BUG_FRAME >> +/* Many versions of GCC doesn't support the asm %c parameter which would >> + * be preferable to this unpleasantness. We use mergeable string >> + * sections to avoid multiple copies of the string appearing in the >> + * Xen image. BUGFRAME_run_fn needs to be handled separately. >> + */ > > When generalizing the logic, I wonder in how far the comment doesn't > want re-wording some. For example, while Arm prefixes constant insn > operands with # (and x86 uses $), there's no such prefix in RISC-V. At > which point there's no need to use %c in the first place. (Which in > turn means x86'es more compact representation may also be usable there. > And yet in turn the question arises whether RISC-V wouldn't better have > its own derivation of the machinery, rather than trying to generalize > things. RISC-V's would then likely be closer to x86'es, just without > the use of %c on asm() operands. Which might then suggest to rather > generalize x86'es variant down the road.) > > At the very least the comment's style wants correcting, and in the first > sentence s/doesn't/don't/. Also %c isn't a parameter, but a modifier. > >> +#define BUG_FRAME(type, line, file, has_msg, msg) do { \ >> + BUILD_BUG_ON((line) >> 16); \ >> + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ >> + asm ("1:"BUG_INSTR"\n" \ > > Nit: Style (missing blank after opening parenthesis, and then also at the > end of the construct ahead of the closing parenthesis). > >> + ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ >> + "2:\t.asciz " __stringify(file) "\n" \ > > file is always a string literal; really it always is __FILE__ in this > non-x86 implementation. So first preference ought to be to drop the > macro parameter and use __FILE__ here (same then for line vs __LINE__). > Yet even if not done like that, the __stringify() is largely unneeded > (unless we expect file names to have e.g. backslashes in their names) > and looks somewhat odd here. So how about > > "2:\t.asciz \"" __FILE__ "\"\n" > > ? But wait - peeking ahead to the x86 patch I notice that __FILE__ and > __LINE__ need to remain arguments. But then the second preference would > still be > > "2:\t.asciz \"" file "\"\n" > > imo. Yet maybe others disagree ... I would prefer to keep the __stringify() version because it avoids relying on file to always be a string literal. [...] -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:26:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494496.764576 (Exim 4.92) (envelope-from ) id 1pRYr1-0000Gr-W0; Mon, 13 Feb 2023 13:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494496.764576; Mon, 13 Feb 2023 13:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYr1-0000Gk-SZ; Mon, 13 Feb 2023 13:26:47 +0000 Received: by outflank-mailman (input) for mailman id 494496; Mon, 13 Feb 2023 13:26:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYr0-0000Ga-V4; Mon, 13 Feb 2023 13:26:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYr0-0006Lo-Rb; Mon, 13 Feb 2023 13:26:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYr0-0007EX-Ep; Mon, 13 Feb 2023 13:26:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRYr0-0003Dc-EP; Mon, 13 Feb 2023 13:26:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FHWfpRxTuaoesYqtfq1iYaa7md4wBfKCZMm0WsbvTRo=; b=awW6WjuKfyvfhBOhTkg9G38uFW xX5wDJqXS1cX9/LAzHDnKbVDfl5zAXmBQZAfQSFAe27MnV7C3gLvPybokutA8LyeNRayvcui9qaOL ylTQI4PVkwjenSHabYwaiAFZzFNWvLSUgQ+ufxRZpxurMJPeqLN5Ok+seksyGXHL6C7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177133: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-pair::broken:regression linux-linus:test-amd64-amd64-libvirt-pair:host-install/dst_host(7):broken:regression linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=ceaa837f96adb69c0df0397937cd74991d5d821a X-Osstest-Versions-That: linux=711e9a4d52bf4e477e51c7135e1e6188c42018d0 From: osstest service owner Date: Mon, 13 Feb 2023 13:26:46 +0000 flight 177133 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177133/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken test-amd64-amd64-libvirt-pair 7 host-install/dst_host(7) broken REGR. vs. 177104 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 177104 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177104 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177104 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177104 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177104 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177104 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux ceaa837f96adb69c0df0397937cd74991d5d821a baseline version: linux 711e9a4d52bf4e477e51c7135e1e6188c42018d0 Last test of basis 177104 2023-02-12 20:42:38 Z 0 days Testing same since 177133 2023-02-13 03:40:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Geert Uytterhoeven John Paul Adrian Glaubitz Linus Torvalds Steven Rostedt (Google) Yafang Shao Yoshinori Sato jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair broken test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken broken-step test-amd64-amd64-libvirt-pair host-install/dst_host(7) Not pushing. ------------------------------------------------------------ commit ceaa837f96adb69c0df0397937cd74991d5d821a Author: Linus Torvalds Date: Sun Feb 12 14:10:17 2023 -0800 Linux 6.2-rc8 commit 80510b63f7b6bdd30e07b3a42115d0a324e20cd6 Author: John Paul Adrian Glaubitz Date: Tue Feb 7 17:57:15 2023 +0100 MAINTAINERS: Add myself as maintainer for arch/sh (SUPERH) Both Rich Felker and Yoshinori Sato haven't done any work on arch/sh for a while. As I have been maintaining Debian's sh4 port since 2014, I am interested to keep the architecture alive. Signed-off-by: John Paul Adrian Glaubitz Acked-by: Yoshinori Sato Acked-by: Geert Uytterhoeven Signed-off-by: Linus Torvalds commit 5e98e916f95bdc50e90f3199d7f3d74b94fa5976 Merge: 711e9a4d52bf b6c7abd1c28a Author: Linus Torvalds Date: Sun Feb 12 13:52:17 2023 -0800 Merge tag 'trace-v6.2-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace Pull tracing fix from Steven Rostedt: "Fix showing of TASK_COMM_LEN instead of its value The TASK_COMM_LEN was converted from a macro into an enum so that BTF would have access to it. But this unfortunately caused TASK_COMM_LEN to display in the format fields of trace events, as they are created by the TRACE_EVENT() macro and such, macros convert to their values, where as enums do not. To handle this, instead of using the field itself to be display, save the value of the array size as another field in the trace_event_fields structure, and use that instead. Not only does this fix the issue, but also converts the other trace events that have this same problem (but were not breaking tooling). With this change, the original work around b3bc8547d3be6 ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") could be reverted (but that should be done in the merge window)" * tag 'trace-v6.2-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace: tracing: Fix TASK_COMM_LEN in trace event format file commit b6c7abd1c28a63ad633433d037ee15a1bc3023ba Author: Yafang Shao Date: Sun Feb 12 15:13:03 2023 +0000 tracing: Fix TASK_COMM_LEN in trace event format file After commit 3087c61ed2c4 ("tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN"), the content of the format file under /sys/kernel/tracing/events/task/task_newtask was changed from field:char comm[16]; offset:12; size:16; signed:0; to field:char comm[TASK_COMM_LEN]; offset:12; size:16; signed:0; John reported that this change breaks older versions of perfetto. Then Mathieu pointed out that this behavioral change was caused by the use of __stringify(_len), which happens to work on macros, but not on enum labels. And he also gave the suggestion on how to fix it: :One possible solution to make this more robust would be to extend :struct trace_event_fields with one more field that indicates the length :of an array as an actual integer, without storing it in its stringified :form in the type, and do the formatting in f_show where it belongs. The result as follows after this change, $ cat /sys/kernel/tracing/events/task/task_newtask/format field:char comm[16]; offset:12; size:16; signed:0; Link: https://lore.kernel.org/lkml/Y+QaZtz55LIirsUO@google.com/ Link: https://lore.kernel.org/linux-trace-kernel/20230210155921.4610-1-laoar.shao@gmail.com/ Link: https://lore.kernel.org/linux-trace-kernel/20230212151303.12353-1-laoar.shao@gmail.com Cc: stable@vger.kernel.org Cc: Alexei Starovoitov Cc: Kajetan Puchalski CC: Qais Yousef Fixes: 3087c61ed2c4 ("tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN") Reported-by: John Stultz Debugged-by: Mathieu Desnoyers Suggested-by: Mathieu Desnoyers Suggested-by: Steven Rostedt Signed-off-by: Yafang Shao Signed-off-by: Steven Rostedt (Google) From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:31:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:31:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494506.764587 (Exim 4.92) (envelope-from ) id 1pRYv9-0001uK-LG; Mon, 13 Feb 2023 13:31:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494506.764587; Mon, 13 Feb 2023 13:31:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYv9-0001uD-HU; Mon, 13 Feb 2023 13:31:03 +0000 Received: by outflank-mailman (input) for mailman id 494506; Mon, 13 Feb 2023 13:31:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYv8-0001u7-3S for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:31:02 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20629.outbound.protection.outlook.com [2a01:111:f400:7eaf::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7cf8ff1-aba2-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 14:31:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Mon, 13 Feb 2023 13:30:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 13:30:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7cf8ff1-aba2-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YA9UqFBzGjdovV+aLDZshUIBq6FI2sIXFmEPpE+vWJs2JRL1JfhNoqcJ37sqhw9doZTww4c7y1Kq8GrtU0PvAsh5EmTGeVJN9Ds+bXW5LduezcQJy+6V1uSHqNZcFzCs7kMTGLRQm/Y173jmlTQKPGUs8Z0iRT4JF7WCYFLPfZ20tCqY/EVFmx0rjSK7ypuzZ2fxQsMLbTkFybO0MGh0fe7SSvgWhgLKORBom8XcUULGrjsur1DemBwJ7pL4lAWh9OBkfaxUAa5URSwbvMOPJnMgy6SBxIFcubpygkTZexsDUI19+tJ/GmkqfbYwa7B3vJloQH/isnM1k630fzseaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLy90Plo2c5BQpnyAucKeQuBGoHBB5cvkumlAXKjwdw=; b=k2h87FZl5gr9nvQ3AnlQhg8GWlj5bZdMclIdjeHHyLFdNrkrFD6QuXQlV9MyCdJGwCS4FcleTaHK7HnEFjX4ERMo3D6VjNGtCjKL+DWc8RqMlDuJu15zptuSEUUBsAJPC8FcMOUfEiNrjdXu3KsRiVFc8fcyYuBwRmLpCATufIqIt9eW8N2dtLPUFQZ+42p01IDviXd74CVraiUxK2I9ARznHkYOHJndOiXXztu7ouPgcmHNVJBFkxGbsoqx0cAWXgCOrp+71rze0M4DFkeHphFgIqLIttCy621m34cwDy1KOBp9PdpaCaCxqvri539yVJfzFyV87Yaq/XSwce0HAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLy90Plo2c5BQpnyAucKeQuBGoHBB5cvkumlAXKjwdw=; b=KpfqKM4Ipb9BXO9pnnczsB8l+kEhfce3Mw30EqzwwJO27szRSDvKVAQ54fTgC7221HFVv3KLBzysjgFG04ottQxg+EuO3QfmP4JMRW9agPCyziLBse1xHPKWvLZz1pZAJIdDiLYjUYneG8qNIQRg81K6nHHBvQr6UcuB8nCkqOGwBBZJ9UukPYStbN4+96BStDdduFozgG6C8ZjPBxnyE4A9UZ1EaoZVgU2y0ce7puKCP/2Y/JR7Jp4GV+foLyJzv+w0IPFaKr1+58W6di2VQRqQIoDfxnnybrl3x5koBXO28zLg83CeO3juDmLgS8Jo8+KnmB04BUBbfumIvHNVNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 14:30:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> From: Jan Beulich In-Reply-To: <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9642:EE_ X-MS-Office365-Filtering-Correlation-Id: 01add6f5-0ac8-409a-2697-08db0dc68ae6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z1rF8eeA1WlamaJUHr0S6M8mhxCNgxL6Fqasat5X5NI8h7nKjCmKmYDq4eqPDzMRmrvL+MHbnt1y+86gqvVrE2ZpSmkrDjLD9EX/nn7j1s7LC5zVlC09pj25L0ZAmgkP68wwUcoFaeuAS2k6f03ACmtuLgYTKXiDKfJ+iiz6v4HBymMpyiZ2/eOd++2blDVWViKEep7TeD875S7XApJLDyXxNq+qXY48kvlD6tq9N0XW0eqf8woOzWYlk7qaPAAVpyjILqidT7/hlSUUmG5qylPI6jIESO6ZDyMqS63NEfh3RGBIVJP192IMQPo9JdqYljZtZIF0lZpvStrRBOp40hxzAJEW22E+tCtt9yWL5/dAbd7v3qzRBuIMbAeQYXpDXpAuGfLDFhrk32//lKS2k0UXjEWDRIzdEXsjumd1v6uh4Y9MP3cTNvq8mEiXX2Jn5TXZ23NOO9hKHaqnR/d9b9svKqgoCT6ezPUGYZIcc+ePFQgAUVBJCMoiNRK3nzBF+1Imi53PuGNpgwBiBbXUlo/uoVHQ1NEAeyvHGFF36YEiM6uNzJLLy0pkPahV8Vdrm8UmHy05b9rFT8Fbd+7HslsKLO1JKqT9gBqNKKKogdsPONybdo/UJp7XxZJ4ZAQC+ND3d5mqh6PikvcfLm2Ha0CLIgLb53F1vI7GXw5LqT8Roj4VAC6RZDXZjB0oYWZoTnX4fTRkRNRvKk/WhbbHZaKel4Q+dVslr4xiqhd06pKanlq4og69PDNB9eKCjYcs X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199018)(6916009)(36756003)(41300700001)(4326008)(86362001)(8676002)(31686004)(54906003)(316002)(5660300002)(66946007)(66556008)(38100700002)(6486002)(66476007)(478600001)(6666004)(6512007)(26005)(186003)(6506007)(53546011)(31696002)(8936002)(83380400001)(2616005)(2906002)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWEwUGRVeitNblVodi9Vdnc5OXZZQlV1YmdZcHFqZTdUVDBZbUhlUVBleWJx?= =?utf-8?B?dS9qRE5TcmVuNGVQSktzNnF3Z2dsT3JCZVMzTVRHVVlQcGdiZGRRUHpGVXRZ?= =?utf-8?B?Tm1sbVVSa2tiT2xmWHVENlBVbmlMVGdJd25mR0VpVWYxR25iVzRHM2pmTXFV?= =?utf-8?B?Q3MzMVZSeVNDZVF5RHVXZFdwRi9zTTd4K0NFMVNFTUlSd2NhYU82N25WZ2pu?= =?utf-8?B?NFdXRWE5aTVUemkrTkcydVJjK2FvRkdvMkdjUHhWeXMyUXNQS3hLLzhiakpC?= =?utf-8?B?SkdKRFNvK0kzc1paenpVQjRpb1M4VDE3S2pwSXA0elRmM01uR0Nzd2RzeDFa?= =?utf-8?B?cXZzOVRCN2ZZQUVUMzBVazJKcHNVamdhaktDWDg1eWFtQmc0MHRwaCthYUJ4?= =?utf-8?B?N01EeExzSDErczlaRWdXMkVKdG0vaGYwNkRuZ2U0Y3hZcUdieUkzdTFKZXlz?= =?utf-8?B?RFIrNzVMWDdySU5sSGZ4R1Y1NUpiSjEwQkI5MlVMalN1UUo4b1dNTG0xVXhX?= =?utf-8?B?d0N4ckNoZXlBUFNFTnVTUUdzSk84dWd4blRJWm5RZmhvN0J2QUNURThSOW94?= =?utf-8?B?TERBZUVjRHExemFGODJndmdwQTZkMFdGQ29xTEZCWmFidnliQS83WHBYUSsy?= =?utf-8?B?UFVMdjNLVXJqeGtYRHV6N1NRQ01GUkhWR1JjUW1FT093V2xQcjcxYlNvRGV3?= =?utf-8?B?VDVGQnFDOXFPb1NHUjVZMjV0Nis0UFFGSG5wSklpSmhpbHdsWWZyOGpSZHR3?= =?utf-8?B?TDFjcTN2TVlNQ1VmQnd3TlUraUltMzdZSXQ5ZjFTbHJOT1ZUcFhuWkFQL3ls?= =?utf-8?B?d015MlhtRDFCWGZZWWtHNHVYTWhNVi9QcGY5cGpxU21nVmo5OGg0YzlJLzdz?= =?utf-8?B?Y3Y0R3NrRWNqNGY0eHhUdEU1cStsNUhGVTNscXlqVktRYUhuUks0d0xVcmdU?= =?utf-8?B?OXFLUHlpbFYzN3VkQU45WVlycFJTOEsvVDh3V0RPUXpiZ2JiNWFvVTZzUGFT?= =?utf-8?B?VjJHRTNCVnQwL1IrWlZVc1R6Q0pwSWpnVS8rVlg1NHdNdUM3L01NdmppcU0v?= =?utf-8?B?RW81R1orQVdVUkdVWEhhTEtxT1duY0RzUTFpS2xoVDlOdyt6dDZraGpyYzRu?= =?utf-8?B?Vk1DQ3h3dW16N2dhWUtqSUZseGlIQzRTeU95cDYrMGRUUXJDbEt4OVdpMDNt?= =?utf-8?B?azlmMGhKNkV1NjJEUkJ1MjBIZWU4eENkMFdZNmlWQmpvZnRrVUowcWw0SG02?= =?utf-8?B?QWtMcXVZblcxU0lnYWFqNWlZZHRhK2xFL0syaHRJQmo5Y3k3MUNhSUtzLzBz?= =?utf-8?B?Z0x2MmlDaGJ5ZFlKYUhKOVBudVFhMy85T3lPL1ZpWWU2ZGZ3a2F3NGZsVWta?= =?utf-8?B?YjIvN3d0QXdHT01WTllMZGFjanJVNlRkVzlZTlNCS1dQVnZYdE10YXVlTVdh?= =?utf-8?B?azNFN285MlozSS91Q3ZJQXhEVlVkeUJ5R1g0ajZhOEF2NGFlZVgvbDV0b2tq?= =?utf-8?B?ZHlkQS9Cc0FGWXZnVnNMZU1JSkFWRC9nbENDY1lJTVppUUN1UDFxL1k5N1hu?= =?utf-8?B?cXZJd0NHOEpMVC92dzJMZko4T2tZWUpMZTYvWkc5dkowa0RJUnFqVXJpL2JF?= =?utf-8?B?aFdKb0xPa2ZxYVFKWjBocjA2VWI2Q2lXRjBzSVJBT0w3S0MyQ21LMm1HT2RU?= =?utf-8?B?blBsYiszdHVxeDRKbFNKeFJ2RmJNNEkxYmFNc3ZJMlZ5Z0pPeDZIalFGTG5z?= =?utf-8?B?cWo2MGx3OXZobmNFMmthQ0F3ZVBTakRvTUFXT0VTTU8rWURtY3BVNDVWZDJy?= =?utf-8?B?bHgxVUFkMkhxQTZYTGtQanlaRk9rcUJQSHdXRkJPTitWaDl1ZzloZnpYcDVl?= =?utf-8?B?UGQ1ZHQyU3RuRHNLTmhCaERvQkZPZFhFZExIcGpMUU5BcG8yQ0gwS09sdWNV?= =?utf-8?B?clJTOTRXUU45NW9yd1hVak5BeHpqU1V6czk0UFRyNWNOZFZSZ05kQkhOSHZz?= =?utf-8?B?Z1BMQVFxRXZNUkVUOFRIUjlXNzdpcU5lVUFNaUl3Zy84Ym5zaVdXNis1Z3ZV?= =?utf-8?B?RFEzT3VDMnlwS1VsbDg2Q0pBSVN0TGljQWVMRnVzdjJqaDB0d1ZOSE1yaHU3?= =?utf-8?Q?7EGoLRgTEZ79v19inLumLOGGc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01add6f5-0ac8-409a-2697-08db0dc68ae6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:30:59.2612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HGn8WHDyp+PyGmWSQD9mk5vQq2ud/xkcf+JAvCggAZkgyA0w+HD3n9FMEGiCC3nG4WMO126eP/EDUnRexL98OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9642 On 13.02.2023 14:19, Julien Grall wrote: > On 13/02/2023 12:24, Jan Beulich wrote: >> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/common/bug.c >>> @@ -0,0 +1,88 @@ >>> +#include >>> +#include >>> +#include >>> +#include >> >> Please order headers alphabetically unless there's anything preventing >> that from being done. >> >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) >> >> I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like >> environments that's redundant with "unsigned long", and it's also >> redundant with C99's uintptr_t. Hence when seeing the type I always >> wonder whether it's really a host virtual address which is meant (and >> not perhaps a guest one, which in principle could differ from the host >> one for certain guest types). In any event the existence of this type >> should imo not be a prereq to using this generic piece of infrastructure > > C spec aside, the use "unsigned long" is quite overloaded within Xen. > Although, this has improved since we introduced mfn_t/gfn_t. > > In the future, I could imagine us to also introduce typesafe for > vaddr_t, reducing further the risk to mix different meaning of unsigned > long. > > Therefore, I think the introduction of vaddr_t should be a prereq for > using the generic piece of infrastructure. Would be nice if other maintainers could share their thoughts here. I, for one, would view a typesafe gaddr_t as reasonable, and perhaps also a typesafe gvaddr_t, but hypervisor addresses should be fine as void * or unsigned long. >>> --- /dev/null >>> +++ b/xen/include/xen/bug.h >>> @@ -0,0 +1,127 @@ >>> +#ifndef __XEN_BUG_H__ >>> +#define __XEN_BUG_H__ >>> + >>> +#define BUG_DISP_WIDTH 24 >>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>> + >>> +#define BUGFRAME_run_fn 0 >>> +#define BUGFRAME_warn 1 >>> +#define BUGFRAME_bug 2 >>> +#define BUGFRAME_assert 3 >>> + >>> +#define BUGFRAME_NR 4 >>> + >>> +#ifndef __ASSEMBLY__ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >> >> Again - please sort headers. >> >>> +#include >>> + >>> +#ifndef BUG_FRAME_STUFF >>> +struct bug_frame { >> >> Please can we have a blank line between the above two ones and then similarly >> ahead of the #endif? >> >>> + signed int loc_disp; /* Relative address to the bug address */ >>> + signed int file_disp; /* Relative address to the filename */ >>> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >>> + uint16_t line; /* Line number */ >>> + uint32_t pad0:16; /* Padding for 8-bytes align */ >> >> Already the original comment in Arm code is wrong: The padding doesn't >> guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes >> size. >> Aiui there's also no need for 8-byte alignment anywhere here (in >> fact there's ".p2align 2" in the generator macros). > > I would rather keep the pad0 here. May I ask why that is? >> I also wonder why this needs to be a named bitfield: Either make it >> plain uint16_t, or if you use a bitfield, then omit the name. > > Everything you seem to suggest are clean ups. So I think it would be > better if they are first applied to Arm and then we move the code to > common afterwards. > > This will make easier to confirm what changed and also tracking the > history (think git blame). > > That said, I don't view the clean-ups as necessary in order to move the > code in common... They could be done afterwards by Oleksii or someone else. I disagree: The wider the exposure / use of code, the more important it is to be reasonably tidy. Cleaning up first and then moving is certainly fine with me. >>> + ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ >>> + "2:\t.asciz " __stringify(file) "\n" \ >> >> file is always a string literal; really it always is __FILE__ in this >> non-x86 implementation. So first preference ought to be to drop the >> macro parameter and use __FILE__ here (same then for line vs __LINE__). >> Yet even if not done like that, the __stringify() is largely unneeded >> (unless we expect file names to have e.g. backslashes in their names) >> and looks somewhat odd here. So how about >> >> "2:\t.asciz \"" __FILE__ "\"\n" >> >> ? But wait - peeking ahead to the x86 patch I notice that __FILE__ and >> __LINE__ need to remain arguments. But then the second preference would >> still be >> >> "2:\t.asciz \"" file "\"\n" >> >> imo. Yet maybe others disagree ... > > I would prefer to keep the __stringify() version because it avoids > relying on file to always be a string literal. ... hiding possible mistakes (not passing a string literal is very likely unintentional here after all). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:34:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494513.764597 (Exim 4.92) (envelope-from ) id 1pRYy7-0002Vn-1r; Mon, 13 Feb 2023 13:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494513.764597; Mon, 13 Feb 2023 13:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYy6-0002Vg-VT; Mon, 13 Feb 2023 13:34:06 +0000 Received: by outflank-mailman (input) for mailman id 494513; Mon, 13 Feb 2023 13:34:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRYy5-0002VV-2I for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:34:05 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12c8cfd4-aba3-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 14:34:02 +0100 (CET) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Feb 2023 08:33:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB7000.namprd03.prod.outlook.com (2603:10b6:8:48::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 13:33:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.023; Mon, 13 Feb 2023 13:33:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12c8cfd4-aba3-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676295242; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=fU3C5XFJST73ONsVDOydkoum9yzfaDwok36FqCyALos=; b=C1Kp9csBHms3QdnfBVVpxrN2hZH4cG86tGe89QhpdBRDGKXVJhueLIOV oIVE+42Qb3Ylppw3KNWb9xTuxBKr8d8tO4HCYOBtUZgoIxis2S7Xh6Lvw cFuF4ueOf3+75QeoisDJcqL89ltsoIxN0tytH0kc/TwS+fkwvtuch8e2M E=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 99229319 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gXG3A6zzFRqDQPXZBqF6t+fexyrEfRIJ4+MujC+fZmUNrF6WrkUCy mMZD2mGPPmOY2akeNxyPoXgphlX6pbSzIIwGQpp/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPKsT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXlM9 aMyOAk8VxvAqs3o4LWEcPBLmP12eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQpuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCdhIRebhp5aGhnWv6E4fVzdOfmCJsMeJsRSeXtMEM 2E9r39GQa8asRbDosPGdx+lpH+JuDYMVtwWFPc1gCmPwKfJ5weSBkAfUyVMLtchsaceQjgn1 USInpXqGCZou72WTlqS876VqXW5Pi19BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdpsLxMSH9x XaNtidWr6Uei4sH2ru2+XjDgimwvd7ZQwgt/ALVU2m5qARja+aYi5eA7FHa6bNMKdifR1zY5 HwcwZHGtKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74185CEN7VJdyUZJKXg== IronPort-HdrOrdr: A9a23:VNKv6qr9JMnEZkyjfZwM7tAaV5tuLNV00zEX/kB9WHVpm5Oj5r 6TdaUgpGDJYWgqKQ0dcLC7Sdm9qL3nhNdICPoqTMCftW7dySeVxeBZnMbfKljbalzDH4FmpN VdmpZFeaXN5DRB/I3HCUyDYpwdKPfuytHPuQ719QYJcelSA5sQiDuQ4G6gYzRLrXB9dP4E/f mnl4R6TlibCAcqh5+AdwI4toH4zrWh+f6ID39ndn0aAUu1/HuVAZHBYmKlN3wlIkdyKNkZgB 74ekDCl9CeWzDS8G6/64eFhK4m1+cJh+EzQvCku4w0LSnpgQDtRKkJYcz+gBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5T/gwRPp3joC42LrjQbwuwq6neXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o/LISxZpvEyppmdKq59Ls1VvFa8lLJNBp40W+01YVL8GASLB8YgiVN JjCcnNjcwmNG+yXjT8hC1C0dasVnM8ElOtWU4ZoPGY1DBQgTRQ01YY7NZ3pAZdyLsND71/o8 jUOKVhk79DCuUMa7hmOesHScyrTkTQXBP3Nn6IK1iPLtBbB5v0ke+o3FwJ3pD6RHRRp6FCyK gpEWko71LaQnieVvFnh/Zwg0PwqGbUZ0Wu9igR3ekqhlTGfsupDcSyciFuryKemYRePiT6YY f2BHsEOY6lEYKpI/cT4yTOH79PNHYaWMoW/vIyW1eLqsWjEOfXitA= X-IronPort-AV: E=Sophos;i="5.97,294,1669093200"; d="scan'208";a="99229319" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQeOVUHMnvzR8gIWY+fgsXIztf+G1a21NpMO9rV8tawdNcbR6qpQoToTiQaa0nvfC+q5ATVJVQ2S5HKQf8HvgLKhwBYtenu/rs5/8MaUBIysNz/NquPRhwTMiDAw1qXadVG06QxnJW3Q2AYr8g2QuN+qYhLZG7PnH6sogtoqIoY49y0PtrwpF/pYFxcf9cDmw1I6he6x+ma+1yre6Ym+AZ2nonwya/hFHWbIydCtVvvunxs/UCTrB1Zn+pkoILJ05s9DdtugpxxWJX1dgK+Wv/QNv6Seh+yyftt44Nh45dgm1/SQ0ib42IN/jC1vYGbeOkEi7JILFgtFJLmzzky4Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fU3C5XFJST73ONsVDOydkoum9yzfaDwok36FqCyALos=; b=Xp92Zs2tuEsZfYpO6joqOrNMmU5eCYtcUp/iTa5sTbX1enZAuiRp6eswVuNsN53CYJDhcQOrkvlVHMfvcce3LtJbPyIPBs2cUW32hm9ZTDJcYXNojwkKRKyYKwMRdXC2utzCZoMHr+bVb1rpmBs53wa0Bt4ul/pVQjNrAzGSVAovLI3F1KfKUWjXC9anJd7gqUy00GTWuBauXnwG0YSyC8ywbtgTaarxPWzQvAxbLvOFW3tBbe6JCXfdntVbA2jbCidcGcANsHIsHlfFGph+X4r6JkJAbEj8nC5QQFvVt0bJcy7vOiXcRquC5RHExHH5dZA6z1FYne7T2B8VuxZy6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fU3C5XFJST73ONsVDOydkoum9yzfaDwok36FqCyALos=; b=QxppqNfXd74bjFS1/E8svnLpD9SrGUn0pasF6RnT5Cnz3c0Rd4cSFJeMtjFU1tGVsiRz+f869ENVQNe1M8so0qe2i+czRBgFYJJQiwPwvv1jPTedNjOk38fLri9BnHwQBXqb2/SvQdmo6avD+7o8Mj4WDlqoXCHBACok/IH7g5E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6ff62711-2826-72b9-5864-a37a56d8b74a@citrix.com> Date: Mon, 13 Feb 2023 13:33:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-GB To: Julien Grall , Jan Beulich , Oleksii Kurochko Cc: George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> In-Reply-To: <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0593.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB7000:EE_ X-MS-Office365-Filtering-Correlation-Id: bedd9fa8-6208-41c2-d47e-08db0dc6edef X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OOFE6hfTzU+ubRk33hB54nmiL+OLantx1uRAati39o69BPjvUTmK/Amvk2ygJb0sQFCNmAFpfahWK20t/GrwyjQL/TtpgO+ryHSf1wdyTxJvO1Jzj705hE2U3m1SOoyUS79iCtNHGDu4jeTXdRYagK9yiP04GNyw5Y6RtfkNnNmA0QcWp1GLBfeFMOf6nUSPoVW2kwhmDzqN6fSGB2Ps7+YRz52uNwUn5wKGej+pCD281jJCURjWw7XVczb6cPJNsHC9HQqn0tbDDhZyO2H7Bz0xDFTneyPIZVYUa1TeCFn4sYf7u44ursQjrEpAFVUhvNL79H9kHM/b8Q7rm5WuwkSsHSmDCd0zgy5l79lPoXXQlTc5scCcok252sr2BEzmGQN6bs4I7IpnStFNPn5VmUvTy8c6yD0i/yGS0mAxva2RdIn01NR+u2XUbuR+vRLsM5AhUYdiPdaetm/Ckr+NhVelp5RBZhJUGGJZETnalZJPPPLjKIuHg+88M2zFQLDXk4V7Zm3djTob92anJBiv3eXmiQNVSii7KE5rQUIGmaPgi7MFrM3QysEBhQcC+iGPlTkOQZ51IAaBRJ4OJOjefh9tVYNx+ialgBiOpmGFxSVLCKl1wErjjxNJk0YhuHndIESZTqs/xNr+uUSSr0kWVxP51GpK/Eq973Mr0Uc0E1nSTI49ceJp/6WSy15mGww1MktF+EnnS8P99YXb5J3+jgRxcbdPVa2C5JRPzpH+yIsFApLkJx8M92P1ArPR4xBt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199018)(478600001)(2616005)(83380400001)(53546011)(26005)(186003)(6506007)(6512007)(6666004)(2906002)(36756003)(110136005)(54906003)(316002)(6486002)(41300700001)(4326008)(5660300002)(8936002)(8676002)(66946007)(66556008)(66476007)(82960400001)(38100700002)(31696002)(86362001)(31686004)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1llOVpHZlJ1MUNBYitHcGVIeFpGaC9LOUVJOTFTOGd2c2ZDZnFhQWdUNldV?= =?utf-8?B?MHU2c2RrTytlVWxNejYvSE5hY3NGUmw2M1djRXQxU2Y1YXAreTJYSnZCZ0xL?= =?utf-8?B?aHVSd3RFcWN6aGJaSE43Uzc4Tms3WUl2UlJjc09ieERQazAzSlk5ZDdMdUVL?= =?utf-8?B?VXVIczVRMkFGRlRVQWVxaURTNTV3MHFnMnd5akFJenJiYjIyUlBRZXcyK1BZ?= =?utf-8?B?TU5RbERqaFpTZkhsTUpCckhpbzlYSW9DZDVEQ1hra0ljUkxYZ2ppWSt5aEJ5?= =?utf-8?B?MHh0U0FlOHI2SmZTWEY5ZkRtUUcrZHpoeEVVaUtsbGFYb1FXMW9RVkk1cGVo?= =?utf-8?B?c24zc2x2ckNBd0NKRjh5UnptRElpaTRGU0EyLzRaeU94bnBPU2FVQloxMGJ1?= =?utf-8?B?QlZyeHd0T0xYUmpkb3gyaDN2VG1PcENDUXo0a3BxZlhCQnZacUtBRWZHaEF4?= =?utf-8?B?dG1qU29vSXRSN3FVcmdMd0pqTkdVQ1lQUGlsK3F5YzhrQ2djMWtqemMxSEhv?= =?utf-8?B?RlIyZXgxSTEyMWIyenVHMzczMVY1SGJReGhvNUkzTGdNME5jOGRDbjBDdVNL?= =?utf-8?B?WC9vTWZKbU41ejB6MkNXbjRBaWJVbTB0WFlXTzVGWEduUjcxdjd2bTBreGE2?= =?utf-8?B?TUtpbmd4OU9OV2NYOWlLL0FSRUp1dU5TWVRydGl6RmVoZGd4bE5jTlJjQTU3?= =?utf-8?B?bExaMG1EQ2ZXTnIvbHRTYkZNcGhoaUlyQnQzbU95b2tVUWlTam9nYWJVd3B6?= =?utf-8?B?WHZvZm4zY210NnRwb0tSU1Q2c0lpVytsaHZzMUVaaUJ1dGlBc0p3SVZyVTlG?= =?utf-8?B?VGp0ajRWS2gwd2F1YUF3S3U1bkpvVkVQMjlzeWNubU9uSktGaXRFSW5peWxz?= =?utf-8?B?V2kwZUpac0FwekpqMlF6bnZjZktqK1BmYWZrejl1enpkbEhnSGh2TU1lQmJ4?= =?utf-8?B?OStmM2Jsa0pOUjhpOWRUSEpIdmxWQkZrejR6Ykhxc1RqTkdLU1BJSkZXcFVF?= =?utf-8?B?d0h1eENZN0pnTFNuNFB3bG83anpBNUhVcTl1TXQyZm5SMlRkMTYwU0p2dUlD?= =?utf-8?B?QTczT3hNWnQ5a3YvOVhTU0Z3d3U2VHRZSS9QZ2JDNmFpR010Q1FrSFdFSzhJ?= =?utf-8?B?b1ozTnVxRkhWRGQ0cktqZUFtSGloSVp2ZVViR1Q0NTVYS2lMelQzZTNnSm9N?= =?utf-8?B?MmRrZ3hrTTljUUVmQ1c5WjZpaGFJc0JUZnd5aWpFSmR0dDkxM0hoWE80blJx?= =?utf-8?B?eStVejNjTVAwZ2pveVFSSmpXMzdsVHBSa05YZitYc3R6TGxQa3hhWDdPUlgv?= =?utf-8?B?aVdZbUhLaHhoRkRuSUlVYlp2ajV6VVFCWDVkUkFydUcyLzVGM0JNejA4cFVL?= =?utf-8?B?RG51aCt5MmhROFdibitBa0xFbXFEZmNBeGtzQks3Y241NVBhOXlOcjdaaUEz?= =?utf-8?B?NVh1THJ0NEJZOFpWYlUwT1JodXo1ckRRaXVPMWMvMWVaVlYxdHVCVUxKdkZh?= =?utf-8?B?aG9VR2JCTFN4RC9xNjdjNTZUU2htTHdNQUV5d1JHTkV5d01iLzVVWVMzb1lN?= =?utf-8?B?WWVHMFFnMGYva3RFczlpNDFUQm81Qy96NmZ5RUVwVXA4ZEdKRnZYeEVkenlv?= =?utf-8?B?QVg2K2RDb0Q2dGpkclJEaU95T2NUWkJyU2JNaFlXb3RkRWVCb0xrbEVFWFVz?= =?utf-8?B?YTVMbXd3eVVVM29rN2RwY0tNQWcvQVZ0RVR2ZW5adWpLSXBLN21GbmhVYmds?= =?utf-8?B?S1pjd3lyaWdnNWRwWm9sT0lMRjJ6bnQyR0VuK0h6L2d0VXV6RVdjd2tOMnIw?= =?utf-8?B?ekFpVFFEVFM3SDgrUHcrL2RraFk0QVZKYit3Wml5ZWNSa3dGMkcyeFF6TVRp?= =?utf-8?B?RHBNeHFEYlhxbkJOaDNFb0YvUFczTGJ1Q1UzQzVac05XVTFGTW40ZjNDVTF3?= =?utf-8?B?c0JYU3BvNm9Nd29uWEFkS0orUkcwNE1LR3hmOE1VaGJaZnNCVjN1czRDZmE2?= =?utf-8?B?aGk4VlV5UDdadUtCeWZ6ZnA0dy9Bb0NROU41amhna2lIZ2lNM1J4VlY0K0Vx?= =?utf-8?B?UDIwRU91UGZFRHlyYlVVNU82TmhLZzlXeHdtNVpxRTZsMmpVdFdtTHZ2YjZN?= =?utf-8?B?NHBsQ25UV1hjRHBGWmU2UnIwY0NkbnpxYlp2Uk5KRDhJVllFMWlxcDBMd2x2?= =?utf-8?B?cVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2OuuHt8aJCJaMJD53GFqnAODBW3NLp3khvzEuP3QLAAezZUTKkKR65zt4NKaGtPcHyjKtQjPwdR7e0iOF484ugg9NILCersePf6lvX7n5ifyG96chk8TSiBKT/fpmS7u2cod7vY4NQ12vpqWEehQG5JZuoc9UTltIiNIbABscS5lYpZAUZSiXYdpKHdp68fPDIwNHNBhaJi/OTeW5vR//oT8AooGuoEPM6Z/SKMhE3hCMoJJAyW0kpzQXxP3F1OzMfrKfVJxmtCemwYNoYeoWrTezOtnRF5xgVBuknViGx9wkRdpHNVidSLIE2NTEd02T1DX49m/3BT5Y5hOAC5Wh9BJEK6eDbgd8Kp+xfXmgWInrwPVwKPt1HPY0zOEcRKJAgAaBcJRfEyV4GJSaR3a/wkeT8Q26D40JRzLxkVqoZTkhDu1kPNEyoaFFLhr2UPUkIjp7K0PuLG1GIbhXI6vYSp340xyWHblDxaJy9WzKpOQuAHuaC3lxfuQs1eijVMs01Xrdovnhw9DVTub7yHyRqteQEJKPkYdR39uhUbaGg87uPlsCQqrDo2UYWG1AueXmOnAW2elQ4HMuRGgIQvJuCdtJ7DUtr5MIj4qnpa9J4cNi5HYy/z+BUSAM37aYEAJzSXm3Gs+yMS+YHDOoX+2GxBaTbcwTbxC1HJgA5rEs+rvj6A7xZxCeq7wtu1BXgBomOnmxD2FYJGMszX9k0XFcb36o3Uxv4webWXBlWd33F89d9yKXTK6014RcYQO3MdSGdTq5XQ+SRrpKW21DHmMz5WrQWDqLPy3LuzywRBzWrBZPSSyN1ZY7Kz2oGI+elDgvVYlzIHmJyMaurEfT/+xnKKS2rnAhO8nC2kE8omGwqgzNhSUGj7zXa+BpX8GS182 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bedd9fa8-6208-41c2-d47e-08db0dc6edef X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 13:33:45.2160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wPSfFlMZdeUjFKyiKJxKfARKjkZfJZKACIMXdYcbOUoIh3qDinr7WipmbOEqOVleb9sOIa5hHJd4dzPwWvB73xW4BXLLoJs0p0iphuWYIS4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB7000 On 13/02/2023 1:19 pm, Julien Grall wrote: > > > On 13/02/2023 12:24, Jan Beulich wrote: >> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -92,6 +92,12 @@ config STATIC_MEMORY >>>           If unsure, say N. >>>   +config GENERIC_DO_BUG_FRAME >>> +    bool >>> +    help >>> +      Generic do_bug_frame() function is needed to handle the type >>> of bug >>> +      frame and print an information about it. >> >> Generally help text for prompt-less functions is not very useful. >> Assuming >> it is put here to inform people actually reading the source file, I'm >> okay >> for it to be left here, but please at least drop the stray "an". I also >> think this may want moving up in the file, e.g. ahead of all the HAS_* >> controls (which, as you will notice, all have no help text either). Plus >> finally how about shorter and more applicable GENERIC_BUG_FRAME - after >> all what becomes generic is more than just do_bug_frame()? >> >>> --- /dev/null >>> +++ b/xen/common/bug.c >>> @@ -0,0 +1,88 @@ >>> +#include >>> +#include >>> +#include >>> +#include >> >> Please order headers alphabetically unless there's anything preventing >> that from being done. >> >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) >> >> I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like >> environments that's redundant with "unsigned long", and it's also >> redundant with C99's uintptr_t. Hence when seeing the type I always >> wonder whether it's really a host virtual address which is meant (and >> not perhaps a guest one, which in principle could differ from the host >> one for certain guest types). In any event the existence of this type >> should imo not be a prereq to using this generic piece of infrastructure > > C spec aside, the use "unsigned long" is quite overloaded within Xen. > Although, this has improved since we introduced mfn_t/gfn_t. > > In the future, I could imagine us to also introduce typesafe for > vaddr_t, reducing further the risk to mix different meaning of > unsigned long. > > Therefore, I think the introduction of vaddr_t should be a prereq for > using the generic piece of infrastructure. I'm with Jan on this.  vaddr_t is pure obfuscation, and you can do what you like with it in ARM, but you will find very firm objection to it finding its way into common or x86 code. virtual addresses are spelt 'unsigned long'. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:55:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494523.764608 (Exim 4.92) (envelope-from ) id 1pRZIc-0005Iv-Nr; Mon, 13 Feb 2023 13:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494523.764608; Mon, 13 Feb 2023 13:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZIc-0005Io-L5; Mon, 13 Feb 2023 13:55:18 +0000 Received: by outflank-mailman (input) for mailman id 494523; Mon, 13 Feb 2023 13:55:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZIb-0005Ic-TV for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:55:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZIY-00075e-W7; Mon, 13 Feb 2023 13:55:14 +0000 Received: from [54.239.6.185] (helo=[192.168.15.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pRZIY-0004wX-P8; Mon, 13 Feb 2023 13:55:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7epD5TH6uwNTCfJb+oHBHOHk9U0051bjFRXD+mHLCow=; b=a6JklOfIO8W6j7l8rLM/L6UQrB OFgUYbIEiW943NmkWZMmPAn6yCN/lsYY0ubTQmQN2QqulJchRQY2keRvTbd1nYEkwtEvalP42QsGk 823gK75ypsHBXwgAcF2abY1sfN0FZCQRnVN6fTGI5uQGiIjXT3laaDSDoiQ7LnPMmliM=; Message-ID: <7e6e7db2-de4e-90aa-bcb3-69327d496c1e@xen.org> Date: Mon, 13 Feb 2023 13:55:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Andrew Cooper , Jan Beulich , Oleksii Kurochko Cc: George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> <6ff62711-2826-72b9-5864-a37a56d8b74a@citrix.com> From: Julien Grall In-Reply-To: <6ff62711-2826-72b9-5864-a37a56d8b74a@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 13/02/2023 13:33, Andrew Cooper wrote: > On 13/02/2023 1:19 pm, Julien Grall wrote: >> >> >> On 13/02/2023 12:24, Jan Beulich wrote: >>> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>>> --- a/xen/common/Kconfig >>>> +++ b/xen/common/Kconfig >>>> @@ -92,6 +92,12 @@ config STATIC_MEMORY >>>>           If unsure, say N. >>>>   +config GENERIC_DO_BUG_FRAME >>>> +    bool >>>> +    help >>>> +      Generic do_bug_frame() function is needed to handle the type >>>> of bug >>>> +      frame and print an information about it. >>> >>> Generally help text for prompt-less functions is not very useful. >>> Assuming >>> it is put here to inform people actually reading the source file, I'm >>> okay >>> for it to be left here, but please at least drop the stray "an". I also >>> think this may want moving up in the file, e.g. ahead of all the HAS_* >>> controls (which, as you will notice, all have no help text either). Plus >>> finally how about shorter and more applicable GENERIC_BUG_FRAME - after >>> all what becomes generic is more than just do_bug_frame()? >>> >>>> --- /dev/null >>>> +++ b/xen/common/bug.c >>>> @@ -0,0 +1,88 @@ >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>> >>> Please order headers alphabetically unless there's anything preventing >>> that from being done. >>> >>>> +#include >>>> +#include >>>> + >>>> +#include >>>> + >>>> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) >>> >>> I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like >>> environments that's redundant with "unsigned long", and it's also >>> redundant with C99's uintptr_t. Hence when seeing the type I always >>> wonder whether it's really a host virtual address which is meant (and >>> not perhaps a guest one, which in principle could differ from the host >>> one for certain guest types). In any event the existence of this type >>> should imo not be a prereq to using this generic piece of infrastructure >> >> C spec aside, the use "unsigned long" is quite overloaded within Xen. >> Although, this has improved since we introduced mfn_t/gfn_t. >> >> In the future, I could imagine us to also introduce typesafe for >> vaddr_t, reducing further the risk to mix different meaning of >> unsigned long. >> >> Therefore, I think the introduction of vaddr_t should be a prereq for >> using the generic piece of infrastructure. > > I'm with Jan on this.  vaddr_t is pure obfuscation, and you can do what > you like with it in ARM, but you will find very firm objection to it > finding its way into common or x86 code. Talking about obfuscation... 42sh> ack "unsigned long addr" | wc -l 143 2/3 of this is on x86. Without looking at the code, it can be quite difficult to figure out if this is meant to a virtual/physical host/guest address. > > virtual addresses are spelt 'unsigned long'. That's ok so long there are no way to mistakenly mix some parameters. For instance in the past, the type of map_pages_to_xen() was: int map_pages_to_xen(unsigned long virt, unsigned long mfn, unsigned long nr_mfns, unsigned int flags) Since then 'mfn' is now thankfully mfn_t... But before, it was easy to mix. For sure, there are other way to do it like properly naming the variable... But using a type as the advantage that it could be checked a compilation. I am open to other suggestions if you have a way to guarantee that mistake can be avoided. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 13 13:57:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 13:57:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494530.764620 (Exim 4.92) (envelope-from ) id 1pRZK4-0005os-2B; Mon, 13 Feb 2023 13:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494530.764620; Mon, 13 Feb 2023 13:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZK3-0005ol-Vq; Mon, 13 Feb 2023 13:56:47 +0000 Received: by outflank-mailman (input) for mailman id 494530; Mon, 13 Feb 2023 13:56:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZK3-0005of-3Z for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 13:56:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZK1-00077O-9v; Mon, 13 Feb 2023 13:56:45 +0000 Received: from [54.239.6.185] (helo=[192.168.15.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pRZK1-0004xW-4P; Mon, 13 Feb 2023 13:56:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hnGXkGUaSo6KFQgncZa+YU0pxZdZRutMdWypOr4o+qE=; b=aHrYtisgG0pK36kxWyqrnbkezp rpv9jpEe0v3tqHnS6qeTF2AP8WmC44TTfZeA8Qd4d772nTIAQVTiTiHkpMUZIAy7d5nLerd3Y9tl1 nI+JdmxsGT/8F3B/AmUbd2K9+nZRS/VRrkuYOswzsN942+GaGnlFH7wV+OgghOTC77/E=; Message-ID: <1b079086-ffb7-2716-8092-b69ede4aec8c@xen.org> Date: Mon, 13 Feb 2023 13:56:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/02/2023 13:30, Jan Beulich wrote: > On 13.02.2023 14:19, Julien Grall wrote: >> On 13/02/2023 12:24, Jan Beulich wrote: >>> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>>> --- /dev/null >>>> +++ b/xen/common/bug.c >>>> @@ -0,0 +1,88 @@ >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>> >>> Please order headers alphabetically unless there's anything preventing >>> that from being done. >>> >>>> +#include >>>> +#include >>>> + >>>> +#include >>>> + >>>> +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) >>> >>> I know Arm is using vaddr_t and RISC-V now also has it, but in UNIX-like >>> environments that's redundant with "unsigned long", and it's also >>> redundant with C99's uintptr_t. Hence when seeing the type I always >>> wonder whether it's really a host virtual address which is meant (and >>> not perhaps a guest one, which in principle could differ from the host >>> one for certain guest types). In any event the existence of this type >>> should imo not be a prereq to using this generic piece of infrastructure >> >> C spec aside, the use "unsigned long" is quite overloaded within Xen. >> Although, this has improved since we introduced mfn_t/gfn_t. >> >> In the future, I could imagine us to also introduce typesafe for >> vaddr_t, reducing further the risk to mix different meaning of unsigned >> long. >> >> Therefore, I think the introduction of vaddr_t should be a prereq for >> using the generic piece of infrastructure. > > Would be nice if other maintainers could share their thoughts here. I, > for one, would view a typesafe gaddr_t as reasonable, and perhaps also > a typesafe gvaddr_t, but hypervisor addresses should be fine as void * > or unsigned long. See my answer to Andrew. > >>>> --- /dev/null >>>> +++ b/xen/include/xen/bug.h >>>> @@ -0,0 +1,127 @@ >>>> +#ifndef __XEN_BUG_H__ >>>> +#define __XEN_BUG_H__ >>>> + >>>> +#define BUG_DISP_WIDTH 24 >>>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>>> + >>>> +#define BUGFRAME_run_fn 0 >>>> +#define BUGFRAME_warn 1 >>>> +#define BUGFRAME_bug 2 >>>> +#define BUGFRAME_assert 3 >>>> + >>>> +#define BUGFRAME_NR 4 >>>> + >>>> +#ifndef __ASSEMBLY__ >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>> >>> Again - please sort headers. >>> >>>> +#include >>>> + >>>> +#ifndef BUG_FRAME_STUFF >>>> +struct bug_frame { >>> >>> Please can we have a blank line between the above two ones and then similarly >>> ahead of the #endif? >>> >>>> + signed int loc_disp; /* Relative address to the bug address */ >>>> + signed int file_disp; /* Relative address to the filename */ >>>> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >>>> + uint16_t line; /* Line number */ >>>> + uint32_t pad0:16; /* Padding for 8-bytes align */ >>> >>> Already the original comment in Arm code is wrong: The padding doesn't >>> guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes >>> size. >>> Aiui there's also no need for 8-byte alignment anywhere here (in >>> fact there's ".p2align 2" in the generator macros). >> >> I would rather keep the pad0 here. > > May I ask why that is? It makes clear of the padding (which would have been hidden) when using .p2align 2. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:12:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:12:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494541.764630 (Exim 4.92) (envelope-from ) id 1pRZZJ-0000C0-Cn; Mon, 13 Feb 2023 14:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494541.764630; Mon, 13 Feb 2023 14:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZZJ-0000Bt-A9; Mon, 13 Feb 2023 14:12:33 +0000 Received: by outflank-mailman (input) for mailman id 494541; Mon, 13 Feb 2023 14:12:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZZI-0000Bn-2g for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:12:32 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 707a3598-aba8-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:12:28 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6230A3200754; Mon, 13 Feb 2023 09:12:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 13 Feb 2023 09:12:23 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Feb 2023 09:12:22 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 707a3598-aba8-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1676297542; x= 1676383942; bh=CLOIlYzbmg1DZi7Tu8o3YTVSaR3X2iddSKcMIH3yv7w=; b=n NvoGIx3VlZd1DHAmwQE6sSd8gfvKYmJ6EWe5XTB2IWbpaI9DFT07pjrIlwk39yCk MeUrS0F80r8gllUS9eDmNYRPJPS6bu6oqbYuS36NJfnP4BrdqOSSeNgoTWzEmk83 UULboaf+Mg/jrmGv7hG1coLhmozmxdBAG/io0N5mToaPs7dkSHvb7IxPDHePrnE9 vIYXXRVhrFR13pop81wSD8eutnwJ9+8VmjBNx721fSvoUQVOTum9LqyQumOwbbDF bfMz4LXFBmFAIXUEQ4q1fXSgxFP1/CMsxiv+KkiCOkSLC9Ll1zwJk6KSxmeYCvt1 0h4VwajyJAFqIVfD4GAfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676297542; x=1676383942; bh=CLOIlYzbmg1DZi7Tu8o3YTVSaR3X 2iddSKcMIH3yv7w=; b=YbTpybQ1cxI2xcCHUhoz3b7X5P28a9CDkn3Mkxg8QOz8 daGN76Nhr4MHUq0oD1k85heD+oBvvnEvGEVl4kiRRdzElOj9hS6Pry1SYpnTGLqR 0FTs1aB3gOLKcRZaDCtTZ/WSktV+qHX70W0FMHCfjE8vdlgUFDN5T3s50ESIqp7w OSuxqDgntWR332zgtJL6QCG0v/cJzAgA22Ekuq441WEYtGHn5jks311YPYw2M2cK cWaJn/owUkYQddJXU3eAjDMjVoulLCUZG3SG0xkZe2zU6Nob9ZlPD9Vr5Vt4KhTD eKpG1yY08p5noW3ZVi5JzRc+3sr++YokKRLRuYPlzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiuddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhephffg hfelueeitddvvddtveffueelfeevffeuiefhgeejjeejjeelveefueelheefnecuffhomh grihhnpehquhgsvghsqdhoshdrohhrghdplhgushdrshgsnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 13 Feb 2023 15:12:18 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel , Andrew Cooper Subject: Re: xen (multiboot) binary gets corrupted ELF notes Message-ID: References: <9e4e8000-9e2d-6e43-df7d-9a34a75b7163@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3mUomW0mmu7TtCj8" Content-Disposition: inline In-Reply-To: <9e4e8000-9e2d-6e43-df7d-9a34a75b7163@suse.com> --3mUomW0mmu7TtCj8 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Feb 2023 15:12:18 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: xen-devel , Andrew Cooper Subject: Re: xen (multiboot) binary gets corrupted ELF notes On Mon, Feb 13, 2023 at 01:53:21PM +0100, Jan Beulich wrote: > On 13.02.2023 12:14, Marek Marczykowski-G=C3=B3recki wrote: > > Hi, > >=20 > > I'm getting some ELF note issues on multiboot binary > > specifically: > > xen/xen: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), stat= ically linked, BuildID[sha1]=3Df7d2c37a4ad599b268f2f2d94bff3776d12649b3, ba= d note description size 0xc0010001, stripped > >=20 > > readelf additionally says: > >=20 > > Displaying notes found in: .note > > Owner Data size Description > > GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID = bitstring) > > Build ID: c5825a0d08edc4d11b1138fedca6b14ce8ba7302 > > (NONE) 0x00000004 Unknown note type: (0x00000020) > > description data: 05 00 00 00=20 > > readelf: xen/xen: Warning: note with invalid namesz and/or descsz f= ound at offset 0x34 > > readelf: xen/xen: Warning: type: 0x4, namesize: 0x00554e47, descsi= ze: 0xc0010001, alignment: 4 > >=20 > > Grub doesn't care, but launching such xen with kexec doesn't work. > >=20 > > Initially found when booting Xen via Heads: https://openqa.qubes-os.org= /tests/60151#step/install_startup/11 > >=20 > > Andy says: > >> yeah, I've seen the same on XTF > >> binutil's recent elf notes for CET compatibility use an unsigned long > >> so they're not compatible when we build as 64bit and then re-package a= s 32 > >> I think we need to strip all elf notes in mkelf32 >=20 > Instead of complicating mkelf32 (we want to retain at least the build-id > note, after all, and for PVH_GUEST builds also .note.Xen) why don't we > discard the unwanted/unneeded notes then from the linker script, just > like we already do for xen.efi? Ok, this seems to help: ---8<---- diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 8930e14fc40e..f0831bd677e7 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -192,13 +192,6 @@ SECTIONS #endif #endif =20 -#ifndef EFI - /* Retain these just for the purpose of possible analysis tools. */ - DECL_SECTION(.note) { - *(.note.*) - } PHDR(note) PHDR(text) -#endif - _erodata =3D .; =20 . =3D ALIGN(SECTION_ALIGN); ---8<--- The comment suggests some notes could be useful, but given they are broken anyway and nobody complained so far, maybe not really? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --3mUomW0mmu7TtCj8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPqRUMACgkQ24/THMrX 1ywjTwf7BNphGtDx6mroAUouaXpz95WIKCuDlnHd0/F/En86co6RliGRdZ/FtBPC 6x9mr8CHSl6I46SYSaxt8AHJ/dWx3CY6OVRZSMxYNs3OIkQFGhqmoUGZbNCzHYL1 HPKbkOoeOqBJazSSm5AErVIFqdngDrsgEmHdsfrXHRh3llzkJlOtZJRz0mRKRb5+ TsTMU2dJBdC4MXcTUPgsOIJ8cv6Edqcdul58uT3mZHGQtP67zS8wC3CVD/FSHWKg g/pREAZX99WKj4yBOV7eefEWnF3KVPefHv5z3umkAkbetLUmtC2IgWvjt0cz9CW2 Xrx5bElrs497oVQwkbSRTm422fRyzQ== =0x00 -----END PGP SIGNATURE----- --3mUomW0mmu7TtCj8-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494553.764659 (Exim 4.92) (envelope-from ) id 1pRZiq-00028z-UH; Mon, 13 Feb 2023 14:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494553.764659; Mon, 13 Feb 2023 14:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZiq-00028G-Mt; Mon, 13 Feb 2023 14:22:24 +0000 Received: by outflank-mailman (input) for mailman id 494553; Mon, 13 Feb 2023 14:22:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZio-0001q4-GA for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:22:22 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060c.outbound.protection.outlook.com [2a01:111:f400:fe5a::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d395d298-aba9-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:22:20 +0100 (CET) Received: from DM6PR18CA0026.namprd18.prod.outlook.com (2603:10b6:5:15b::39) by DM6PR12MB4499.namprd12.prod.outlook.com (2603:10b6:5:2ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:22:17 +0000 Received: from DS1PEPF0000B074.namprd05.prod.outlook.com (2603:10b6:5:15b:cafe::cd) by DM6PR18CA0026.outlook.office365.com (2603:10b6:5:15b::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:22:17 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B074.mail.protection.outlook.com (10.167.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 14:22:17 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:17 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:16 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 08:22:16 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d395d298-aba9-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lo9Wo3H21L8T3wnNJpzA46dqgk/I/Sb/E5pBcXiREJS2VSGk9aP4olix/L2fYa7HmwqzUqHESXBoU4A/wJP8EqvElhb61/TUmOyCguDNULw80kWe5YXBZKv3AX6TcQCkiLMNcaoNbPuHfFY3wZfyRxqsUKfdS2mWVm6pAZTL7Oc8b+Is92ovLr2xFqBFYVAt6Ka9O/0GtBP4I5rCDkEGHk/IyoAOTuHilyHd9s/JzySo/DHrnIazioLZMb+IfvtICE1bcKasM2PSOzv3T06XYnxMz9jUi92E9HhmpmNomJHbo7nz4Bb0lDVfiSS9fJzdnpaekPi/O/lKKGMp8hxkIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waugRkicvl3llDUPWXOfeZQsUfMsP5ZBgCPpOe6boXo=; b=XAxkk3K80QSvDyxsIU18vahl7zgLmuUcO62L9R5EufxTEND/sbEowDTRFFuYHdAsLx/1YL1MtoyXEAspWbTrz3qsFjMZnOZ8WPKv+NtS6Xnw3UzSn3TUMNU7zpNyVgpR5+5GT9Dd/3CGo21K8so3DlT8loTYfL1SE3u4Zgo0hzhvg19hx40H7j/w0WPRu66ps1Atm54UddLxibEYiCJa9wtE5JVWeO//I2d8Tf7Nc/zy0kMSxcrFMwmjDgwzh2NqWVtxztsHACqf0WxqnnT2TyIdEtzuh9IOIv/z3gxOod++Chx1faX0vaKKIRD84ZI3IbeqjxRXwMqHfsvYGuQz6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waugRkicvl3llDUPWXOfeZQsUfMsP5ZBgCPpOe6boXo=; b=AWt4BYhiUknKbxcSnJED3+SXxLF7XR+tEDi0o+MVMNqxr3Lf7ywZTfHEF6gIHABm0aVdIGMzhx1xwaMX/vBOE5HOQF2QR19oKv/qiUrevIXRBSWExytGHGz9NCMrGbsk8VSPb665h/FDR25HDBTm1kMXkzjK5OAfzrt/yVoS5cg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/3] automation: Add a static memory allocation test on arm32 Date: Mon, 13 Feb 2023 15:22:09 +0100 Message-ID: <20230213142210.11728-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230213142210.11728-1-michal.orzel@amd.com> References: <20230213142210.11728-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B074:EE_|DM6PR12MB4499:EE_ X-MS-Office365-Filtering-Correlation-Id: 28bad0fd-48df-44fd-7af3-08db0dcdb5ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Q9hxa5rxIsGvNkjAMu8/WbwRPzwSuW30gmpY8UCj/Zb66uQoGHdMiNXJyYNQIzUNyTyQdZnnpYko1o/Wg7VO70dID+NLQ68RUwTgHtLu1ViRu0PPrxW3dhAnWWyilguIKnx15nO/UM7xEcZMcfAnojdxPG1ZhnXp8ECuVmGaVbfHDoy2X34INIwY/55rxt5GNhvGoR9fE+9V5B+CJlhv9Hj3VukEoBSGcqmw2x/mACxf0HblA5UUMBCLquBEPSPDxmLC7JOsUG3/GKvuRdvJwoFFCFU1QpdT6j4265l5MPkrX75QKpwfETWLDTT2JIKRarST84tP6rSvQMnzj6eI885dctB8Tj5JBXYm3Xb07daKZyDHHCYj95DV/Hf0hj/BzCgO+39ouSHoYP3pRtXOY/b9XGMrC8QKnpnqgA2t5bN1KTJ4QLrJzfPNfh4iKTKaERnt3OT591So2GEE1EPzfHjzf4x7p1UFfwvlOZ2KpfFWryE2KR5xxe6raTvezQOY1mO5ygewqBlSxRTqED+QPaZcRrfHznUSDGZRqD3BNFSI2SMgSOwggCbMkej83adEk2H+jTtbcTsK+dnJZPRpXMdSZxVYGvTpQW7dO//NObS1MeBa2nsT4PGEtS10GZq/PEhZT+Z6GCopl399eKy8mib1cseQZ21oXblcbOUyX+GE2JB5PfKTwOi4pWMfib/WA1V9Mx3It7O2SisLGots2poMvL47u25GNb7NwxFgRIGGRevRUihpBMYhzmuAupi73GMkhVVNVsghHDqD++wHwoqMLmBD649ALrRsp+iM/w= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199018)(36840700001)(46966006)(40470700004)(40460700003)(70206006)(70586007)(316002)(54906003)(5660300002)(8936002)(4326008)(6916009)(8676002)(41300700001)(6666004)(2616005)(478600001)(1076003)(26005)(186003)(47076005)(426003)(336012)(966005)(356005)(36756003)(40480700001)(82310400005)(86362001)(2906002)(36860700001)(44832011)(81166007)(82740400003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:22:17.3972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28bad0fd-48df-44fd-7af3-08db0dcdb5ed X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B074.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4499 Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test static memory allocation feature. The test case itself is directly taken from dom0less arm64 testing. Populate build jobs to compile Xen with config options necessary to enable static memory feature. Populate test jobs passing "static-mem" as a test variant. The test configures domU with a static memory region (direct-mapped) and adds a check using /proc/iomem to determine the memory region marked as "System RAM". Signed-off-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 20 +++++++++++++++++++ automation/gitlab-ci/test.yaml | 16 +++++++++++++++ .../scripts/qemu-smoke-dom0less-arm32.sh | 17 ++++++++++++++++ 3 files changed, 53 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c7325d..166182bc595f 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig: HYPERVISOR_ONLY: y RANDCONFIG: y +debian-unstable-gcc-arm32-staticmem: + extends: .gcc-arm32-cross-build + variables: + CONTAINER: debian:unstable-arm32-gcc + HYPERVISOR_ONLY: y + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + +debian-unstable-gcc-arm32-debug-staticmem: + extends: .gcc-arm32-cross-build-debug + variables: + CONTAINER: debian:unstable-arm32-gcc + HYPERVISOR_ONLY: y + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + # Arm builds debian-unstable-gcc-arm64: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 84ab1fee50a4..c2bcc5d4d3e5 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -226,6 +226,22 @@ qemu-smoke-dom0less-arm32-gcc-debug: - *arm32-test-needs - debian-unstable-gcc-arm32-debug +qemu-smoke-dom0less-arm32-gcc-staticmem: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-staticmem + +qemu-smoke-dom0less-arm32-gcc-debug-staticmem: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug-staticmem + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index c81529cbbfd0..f89ee8b6464a 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -17,6 +17,19 @@ echo \"${passed}\" " fi +if [[ "${test_variant}" == "static-mem" ]]; then + # Memory range that is statically allocated to domU1 + domu_base="0x50000000" + domu_size="0x20000000" + passed="${test_variant} test passed" + domU_check=" +mem_range=$(printf \"%08x-%08x\" ${domu_base} $(( ${domu_base} + ${domu_size} - 1 ))) +if grep -q -x \"\${mem_range} : System RAM\" /proc/iomem; then + echo \"${passed}\" +fi +" +fi + # domU rootfs mkdir rootfs cd rootfs @@ -62,6 +75,10 @@ BOOT_CMD="bootm" UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr"' > config +if [[ "${test_variant}" == "static-mem" ]]; then + echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494552.764653 (Exim 4.92) (envelope-from ) id 1pRZiq-00025U-HT; Mon, 13 Feb 2023 14:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494552.764653; Mon, 13 Feb 2023 14:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZiq-00025L-EV; Mon, 13 Feb 2023 14:22:24 +0000 Received: by outflank-mailman (input) for mailman id 494552; Mon, 13 Feb 2023 14:22:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZio-0001qA-JC for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:22:22 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20600.outbound.protection.outlook.com [2a01:111:f400:7e8b::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d2e44241-aba9-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:22:20 +0100 (CET) Received: from DM6PR18CA0005.namprd18.prod.outlook.com (2603:10b6:5:15b::18) by IA1PR12MB6164.namprd12.prod.outlook.com (2603:10b6:208:3e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 14:22:17 +0000 Received: from DS1PEPF0000B074.namprd05.prod.outlook.com (2603:10b6:5:15b:cafe::a5) by DM6PR18CA0005.outlook.office365.com (2603:10b6:5:15b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:22:16 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B074.mail.protection.outlook.com (10.167.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 14:22:16 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:15 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:15 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 08:22:14 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2e44241-aba9-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Za9sOhlK1aV8/O1w5WEMl5McvGlCMtsGYBNHMjglaAqg4XBJSyc/p434mziu7MNt7z/N2Wixj2Sg1bQoohJdzBcx53DAwKD57dvXkCQVFAjJVJCDdtm1LSledaMjDPy26qURCyy6Ub/TrGA2FfYspKNTERQFzoTbGqBynwPQbrL9MbDBFFAICKmyQ6lcrxL9QFzbZ85VSRvhy6anMA4f+O6eXObCp9EQuKM9+H1f/ZdcmQr4eNWMPH7OzHKMzTD/zN4XT35qe5yDd0rnjtWTjnGBU4bjsixXcczlyT6ki++r0YcNXwfr4obZtZi6sVeF782N05Ea+fl4oLMyuWCfyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=81CL0P2OA/C5m54ZrKuh3FvynThfH/tSzp4cZrsFugY=; b=ep+NlUdC1C11bJRQydg3E8dmjVh1GZZdtjS8EQQD37KHp/WDCnqScXPmDGZSvbYKiC6iTuJUlGyZtvE2JbU53B/LpqOzfQNVsM9GsZk706l7ptznRepi4bfWGd6p//uyGHGh9DngPf7DfEPPQkPg0DbxtUyj5EwrVGMwzhF5as3zurW9+cemIqtduDRYaLuydfxYxJgXLmI2bS8/Ylew1amfTgsym29mE3Dius1gWOc0iylxhGfWa+I12B2BDfhTzflI1PMnrbtRuF/xRiVB8odZQlEEevCfPQdLXyIj/1gd7DxGlJJ6gWor/u/zYXZPWXLDDE/+b2KnBhlFPYgptQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=81CL0P2OA/C5m54ZrKuh3FvynThfH/tSzp4cZrsFugY=; b=WC5RkWPJtE7ZujQcv9P/MmhblI7ZKqHgUueQe59jAeEe0hYtO9lf2SlJMj/b2Wbg2DXizeUEtlRh3k7xAKnfzOEN2DFAxSZ+CwTofm5q9s+K7hDJfOXLNXTL2z3hEXJmzS4x2pRKinebNNcN/4057hfI25i4JocXFzRtSpQziMY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 1/3] automation: Add arm32 dom0less testing Date: Mon, 13 Feb 2023 15:22:08 +0100 Message-ID: <20230213142210.11728-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230213142210.11728-1-michal.orzel@amd.com> References: <20230213142210.11728-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B074:EE_|IA1PR12MB6164:EE_ X-MS-Office365-Filtering-Correlation-Id: d69c58c7-c461-49fa-0eaa-08db0dcdb55c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ns0xZX/gmg5QYyG8jExSVHZ8HKV2FNx0vieMngn+mlZSo6Ctz0tcM08svt22VfCvCZvCce6gDVbwsGbSYeLQiytMcvUaVHmb/+CyuiHRAklLuRuOBZb0o5Y27WjieCQ8/AuKpMl0vFWyoWGILyHcTjlYyVJWmSo+dUmrdjRTP7xUZLzt1WxbjcdQxWgPCq0EgfEkRheBsQC7A8l1ByUEwW4hgYl2ogZumdTU4sy7JgLWGjyCodh6mDUk3s9HDiJlYDYN0MrQ7PBOeQE1FZQX8td33BjVe2a2rC6ZPwVeqCExmwHxFUyDq7wh9EhMolI0c6HmtO4HQNku57E8wYtdn2cpKstt/i2ROEg4eylvwtBPARHZxVDXbK20jdn2PfsQNG+9SUMCS5966r3+TbKXFVffmwNx0PhopwgBsXy/DoevL77rWwMGvAzXYSeLnDUpN9GJQMnm9kDZ0Gp2w2EAUwJLjJenXw6QJTzA3rzeynRlEaxwszOyYeSPWfCvRvV4/8sdIwivj2Q4Y+KSkCKQPUuZD3zS+YGq3GyHjrqQOs40cXoAaivEq5FgRYGEEivsFoVkOe1zPGXMD+gb3rT/p3HR1GdiVXDJICEoTlPbMSIBTo0EP4A9EuEidQ6pycQWQuId4EJzZrYs4s9wV8wRQ002UbHJVxV9YIQwU9JhTcFGBAaUbs3b4za22s4BUgMiU/Mf2iI1lvjcgrQhHA0YEnuPq1QUGc/GKdW/hZ0AJICfvn7IyY3N46mOf95sDyBwbqVYVe9F75m+aFH3wDzTsUpujKAl/xWdsWh2wuUXYOkAQvkSaomdU3GJskqdA2RB5H0//SnBSFvbKPll8qlbsnp5gyXwVfJ0CSS8/2kIvnLtFSDpw0eQkZRFEEvvoRk X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199018)(40470700004)(36840700001)(46966006)(26005)(186003)(316002)(1076003)(2616005)(478600001)(966005)(70206006)(70586007)(8676002)(6916009)(4326008)(54906003)(6666004)(336012)(8936002)(426003)(44832011)(47076005)(41300700001)(5660300002)(83380400001)(356005)(40460700003)(2906002)(36860700001)(82740400003)(81166007)(36756003)(40480700001)(82310400005)(86362001)(21314003)(32563001)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:22:16.4441 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d69c58c7-c461-49fa-0eaa-08db0dcdb55c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B074.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6164 At the moment, we only perform a single arm32 test in our CI, checking whether dom0 boots successfully or not. This is mostly because we do not have any arm32 runners and we only execute a hypervisor only build. In order not to leave the arm32 testing in such a poor state, add a script qemu-smoke-dom0less-arm32.sh to start testing true dom0less configuration, in which case we do not need a dom0 with a toolstack. The script is mostly based on the one used for dom0 arm32 testing as well as the one used for dom0less arm64 testing. We obtain Debian Bullseye kernel and Alpine Linux busybox-based rootfs. Depending on the test variant, we prepare a test case contained within domU_check variable, that will be executed as part of /init script. Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 16 ++++ .../scripts/qemu-smoke-dom0less-arm32.sh | 89 +++++++++++++++++++ 2 files changed, 105 insertions(+) create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index ce543ef5c0ef..84ab1fee50a4 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -210,6 +210,22 @@ qemu-smoke-dom0-arm32-gcc-debug: - *arm32-test-needs - debian-unstable-gcc-arm32-debug +qemu-smoke-dom0less-arm32-gcc: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32 + +qemu-smoke-dom0less-arm32-gcc-debug: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh new file mode 100755 index 000000000000..c81529cbbfd0 --- /dev/null +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -0,0 +1,89 @@ +#!/bin/bash + +set -ex + +test_variant=$1 + +cd binaries +# Use the kernel from Debian +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +# Use a tiny initrd based on busybox from Alpine Linux +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz + +if [ -z "${test_variant}" ]; then + passed="generic test passed" + domU_check=" +echo \"${passed}\" +" +fi + +# domU rootfs +mkdir rootfs +cd rootfs +tar xvzf ../initrd.tar.gz +echo "#!/bin/sh + +mount -t proc proc /proc +mount -t sysfs sysfs /sys +mount -t devtmpfs devtmpfs /dev +${domU_check} +/bin/sh" > init +chmod +x init +find . | cpio -H newc -o | gzip > ../initrd.gz +cd .. + +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom +./qemu-system-arm \ + -machine virt \ + -machine virtualization=true \ + -smp 4 \ + -m 1024 \ + -serial stdio \ + -monitor none \ + -display none \ + -machine dumpdtb=virt.dtb + +# ImageBuilder +echo 'MEMORY_START="0x40000000" +MEMORY_END="0x80000000" + +DEVICE_TREE="virt.dtb" +XEN="xen" +XEN_CMD="console=dtuart bootscrub=0" + +DOMU_KERNEL[0]="vmlinuz" +DOMU_RAMDISK[0]="initrd.gz" +DOMU_MEM[0]="512" +NUM_DOMUS=1 + +LOAD_CMD="tftpb" +BOOT_CMD="bootm" +UBOOT_SOURCE="boot.source" +UBOOT_SCRIPT="boot.scr"' > config + +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config + +# Run the test +rm -f smoke.serial +set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ +timeout -k 1 240 \ +./qemu-system-arm \ + -machine virt \ + -machine virtualization=true \ + -smp 4 \ + -m 1024 \ + -serial stdio \ + -monitor none \ + -display none \ + -no-reboot \ + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=./ \ + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial + +set -e +(grep -q "${passed}" smoke.serial) || exit 1 +exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494554.764675 (Exim 4.92) (envelope-from ) id 1pRZis-0002b2-9l; Mon, 13 Feb 2023 14:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494554.764675; Mon, 13 Feb 2023 14:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZis-0002aC-5G; Mon, 13 Feb 2023 14:22:26 +0000 Received: by outflank-mailman (input) for mailman id 494554; Mon, 13 Feb 2023 14:22:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZiq-0001q4-Nc for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:22:24 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061d.outbound.protection.outlook.com [2a01:111:f400:7eab::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d40c1d29-aba9-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:22:23 +0100 (CET) Received: from DM6PR04CA0007.namprd04.prod.outlook.com (2603:10b6:5:334::12) by SJ0PR12MB6880.namprd12.prod.outlook.com (2603:10b6:a03:485::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 14:22:19 +0000 Received: from DS1PEPF0000B07A.namprd05.prod.outlook.com (2603:10b6:5:334:cafe::3e) by DM6PR04CA0007.outlook.office365.com (2603:10b6:5:334::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:22:19 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B07A.mail.protection.outlook.com (10.167.17.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 14:22:18 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:18 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:22:18 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 08:22:17 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d40c1d29-aba9-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LTTksxpAQHNbli+WIZ8vx4dbGg/st3TmObF8aO+q5t4D0JbxXjndPsm+Z4rcToKJcmOuDesegZ9NfP8FAl5t+8x/q1+mNpK2eA//DyulapZNw9huzqGYDawiOVyLYNfNJtqJDQm3DWcVkF3V+AVyNN6xOdJab8ahQlpc+qtPyCwXK7cqJI3l3HkUQ4XZJYLiYf2Y2rSqCrE/RYOozABX8ewUPaeV0IKlR2hn3lbOPH9xdoOYgvGFe8oYR7J+So13GwA4/9FbAOvP+8SYsFMpEs5rzEOhrsUIUsvosG3ofUxq9IJiqJa/Ga0RIvhLDIjSzizArC+ZxC+nNpNBHuNp3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KX0x3F3iElls3V3KW1MLbB7hkF0jKt3vYL8OtbmKh2M=; b=XzLqUsBSY3kysSnsJVf+24qVv3abZL3LNTZFaJgLfNSTj5sMtPH6ctSWg3H18w3JaFg9F1IifR+4UMHOREzveEAvHp3KlAtEXEIXfuQAlLZ7GOyamjTnHA5NhlkTCdwWecgd/ar+MtyKfhyz4MG/VtBuaLOiEU/AmRHxVIrglBAeTCfqdm5iM26DSIUij64GaBfvwdv/RE4wYKc5iRGB3EUzBwwIzsxNPT3TjuBIQjl3B9uOWo6vgDt/Mu7lB/wxdHB2sQNThYIzEEEf1vVmuUG1uIEYXBIpJl1yf3pHUMBpRexpRwNrNMtL8X3awLXmMej2u0FQRBVcZyqutgv5dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KX0x3F3iElls3V3KW1MLbB7hkF0jKt3vYL8OtbmKh2M=; b=FuMRhU3rwXIOwxL2P3zUWBU4aGuOLvxCG2Nq+bWf3nwQr4gEm1heX6xO0kSpCep+oBdFfZ4bWipqRTLro/PEr9VIZwB3fa1p7MllwEbSZORZlU1ZIRsVlLeLML6LqJgJExyCuz0Iqleh/ZqhwyBqgwZjS+IzJjb8gOydijCbx/g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 3/3] automation: Add a gzip compressed kernel image test on arm32 Date: Mon, 13 Feb 2023 15:22:10 +0100 Message-ID: <20230213142210.11728-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230213142210.11728-1-michal.orzel@amd.com> References: <20230213142210.11728-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B07A:EE_|SJ0PR12MB6880:EE_ X-MS-Office365-Filtering-Correlation-Id: a27b2705-ba8a-4242-ee71-08db0dcdb6c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vBn0GIQpOQqyKdt4efzcrOi7iaDlE6Am+JriouU58QgCAWDo1FS2eh6XPubejkjCekGrqpzu+NDFoVxz6w0/0aXzN5eOkHqA5ibvlIcSiGpNP1ZvNZDwJAg/QRDecMvSXdiHQV2HaZWOHtBSrDXml0pf359zlrxae0X2KgMhU64YY5cFr65iDhWTtC/ZAoHMyEK9dxE3DGYyegjap3tnDBLwNkX6W6HMdd148J9Nk+c8qjKDH21lWrcB65dSpkz6dm+leMWBK3oJkOaUPr986y36pwF6KOTigig3cCzsYiiLBdxPZ9uSPCJIjnvLx3O3Jln3dsWgVMly5oi509yweusGR49dZxkLxSxjzRtjavDaGvuNjxgWL93gFAHqMdCmXuc7j8gUG20AWECSKkX8J+0KLM8Si8l1oTrt5dSFEijSxNYIiX4oI9i/k9ETXoliCoyxJOAkw2xvWsBVZDEs9sLq9+Q/rCDLfdnRYV0OpAMHqM9eZoesRnxIB0DtircGHxu8FJs9xOKMrmVRn4w293DLJB3pyUfl7Avggzfp4noMrdmcJrrF7j+16Q+MD0HvM3rUOKsGAPY1SGVgny8If+6D08PJjsvtzEzIYWBuFk+rUloCaS3ULcbz8JXVfAWLyJhb7u2j4IqsTm/T8mla+Tx86lZmoYkI4wUGYt5uTc2MwJ8P4qLKp009oxdQhFSP/Wl/j3RDB/SfBvYWRtDzC2b8AwQ0AlMdM8Q92QPZx89S5AImGD4+5mvve8h7AThTmlllliZgjADXCxF7kNooGA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(8936002)(2906002)(82740400003)(356005)(40480700001)(44832011)(6916009)(4326008)(8676002)(70206006)(5660300002)(70586007)(36756003)(41300700001)(82310400005)(81166007)(86362001)(478600001)(54906003)(26005)(47076005)(336012)(426003)(186003)(2616005)(966005)(1076003)(6666004)(40460700003)(36860700001)(83380400001)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:22:18.8197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a27b2705-ba8a-4242-ee71-08db0dcdb6c8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B07A.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6880 Xen supports booting gzip compressed kernels, therefore add a new test job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test booting a domU with a gzip compressed kernel image (in our case zImage). By passing "gzip" as a test variant, the test will call gzip command to compress kernel image and use it in ImageBuilder configuration. No need for a specific check to be executed from domU. Being able to see a test message from a boot log is sufficient to mark a test as passed. Signed-off-by: Michal Orzel --- automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ 2 files changed, 29 insertions(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index c2bcc5d4d3e5..be7a55d89708 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -242,6 +242,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-staticmem: - *arm32-test-needs - debian-unstable-gcc-arm32-debug-staticmem +qemu-smoke-dom0less-arm32-gcc-gzip: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32 + +qemu-smoke-dom0less-arm32-gcc-debug-gzip: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index f89ee8b6464a..b420ee444f2a 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -30,6 +30,15 @@ fi " fi +if [[ "${test_variant}" == "gzip" ]]; then + # Compress kernel image with gzip + gzip vmlinuz + passed="${test_variant} test passed" + domU_check=" +echo \"${passed}\" +" +fi + # domU rootfs mkdir rootfs cd rootfs @@ -79,6 +88,10 @@ if [[ "${test_variant}" == "static-mem" ]]; then echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config fi +if [[ "${test_variant}" == "gzip" ]]; then + sed -i "s/vmlinuz/vmlinuz.gz/g" config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:22:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:22:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494551.764642 (Exim 4.92) (envelope-from ) id 1pRZip-0001qS-AP; Mon, 13 Feb 2023 14:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494551.764642; Mon, 13 Feb 2023 14:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZip-0001qL-7T; Mon, 13 Feb 2023 14:22:23 +0000 Received: by outflank-mailman (input) for mailman id 494551; Mon, 13 Feb 2023 14:22:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZin-0001q4-BN for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:22:21 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061e.outbound.protection.outlook.com [2a01:111:f400:7e8a::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1de0962-aba9-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:22:18 +0100 (CET) Received: from DM6PR17CA0029.namprd17.prod.outlook.com (2603:10b6:5:1b3::42) by BN9PR12MB5129.namprd12.prod.outlook.com (2603:10b6:408:136::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:22:15 +0000 Received: from DS1PEPF0000B073.namprd05.prod.outlook.com (2603:10b6:5:1b3:cafe::17) by DM6PR17CA0029.outlook.office365.com (2603:10b6:5:1b3::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:22:15 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B073.mail.protection.outlook.com (10.167.17.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 14:22:15 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:22:14 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 06:22:14 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 08:22:13 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1de0962-aba9-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDS5nCPhT0UCsTM3zsSfPjp1IFm2+0vCo77+QqlBEiPpUQ+461TYVqpNOKKgHR/GJ4cT5RcM520tU5b5atH7JPE1G4giSqeRqbSOPE4/tbwT85HL19Kvf1/JAP5jnpfjTSEpDzUuPd5NHYd5i4URhKvd6GgA5+0aHjAyQx72XjaqkzlHWDmFj41ttXBmdSoBqcFP3OYBpFnG7xa5Xlv/wZGs9v6Srlf/Wiz3GX6PH9FSkB2n8ZE0849hTQRRsOoQu2XcvXyUlMdT22GiPxTDdVvOFqGni+ulmS+DZo210gMeVWII37egmNZ635vu3znjEklT+sboCGfmRiszY+Um7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uryp0FBeOVB3D/UsJiltpcmedQ/Z3ksaraSj5aZ5Sjo=; b=X6t7n7LNG8VGESG4j+iFb6lJTzLr0TekGLRnxTYhqBOMlO8iMkHCkh8QtZJSO0U/QgUQgSnoAstCq4rIawi738w4ou/f5k6sKnVVDQoRi1ZeuaDUoKz1abCwBVJExpPeKJ4i7YW9C3zEQxTBQxw1E1+bJh4CECRMKLfItPDjvDUbmZ3sLqox/HOjXTJzjmT1yInYBu4gmFlUFjyQghQdU1CgpKXTuer855qo+ySvGiJUWsJfUlMI+mQ7Et94me21XP/wwppXwTd6gsbKhXXkPwAkfzov3BjwGb8xswbw5ijUgUIFubAVcdEaXj7gf2h8/EesYe1XVQhAb5pEk62PmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uryp0FBeOVB3D/UsJiltpcmedQ/Z3ksaraSj5aZ5Sjo=; b=gXs1rYn7s9Io/lV7EahCZPp9onAsgRvRLs7zxlkL/OIVCrmgNtv/S4xCRDkt4qYeGHkUWMXQByz+1wXX7VWGx76Ru2gEL35srPKOgoSD1yUU3RNpmWIAzD43v7SryNxjVM2tUBcoXltoGK94SDhZ+orQtb0pX0PCcMlvdQrMPfs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH 0/3] automation: dom0less arm32 testing Date: Mon, 13 Feb 2023 15:22:07 +0100 Message-ID: <20230213142210.11728-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B073:EE_|BN9PR12MB5129:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d3d5da6-f5d3-4b62-23bb-08db0dcdb48c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: obwmYGB//Nw3u6tRirNOLwhfX03WwXVzDFMXtwoRd3mgAw8ontwbCi81gVGIQOr+gm4OhgJDgip/pLBY3VWpqnCubzN68J8T87NhZn/4C1JcSyGbi4HW7Ipqo/scQc8BTExHvkzFpmcON6MOcjzWCzxRq97IjES+C6GR4pTKuomByfw7nlTJrJmVFNjPpqGAyoA2BqjCV/Jm7DszEfJSHXWR3LNNJod7gR8DxARF3qQO6qHNdMrlLNVZhgyWgCeW1d8NKGi/gHxLc4EDzi1RqHZpX9mfqsut8bYvc59WaoX3NmUqITqeHGq/VC1f2lg3c1WX21i2XSGgw9UbF22uhAvjztXGyAbEBgoDbJU/zuDJkxNgeBl3asSxFrts4PA2/NSxH4mcK/ZWyHfSpErBOaGVwvXvWvQID8OzpxeS5shDYS82AecPy8lfYDzyxZGNU4GtBWe9JlESIi83LTdQwzH4VX7qcS66EhkhvaoXOg0PyFoOwxbyQ11ac9XcjhjZfiMK9YeWYIVeSgnWdYMdWmj48GUN6g96tz1ic5JjgRcZxFjmu3e63xk8JR6ZsaivI6wkAAoaa+l+4UrTpFvWvQAWCbGphFtPPFrSVyklcHm1oX9oXCA2eAhA50qOgBA0CAqnJYppzC1XHOOCfPjO3dV0UfjWBW9EbKcDJcIb7WlCQ661+od8wPPPKn36AaV2Eou0ISkgH2vd+/5nDSYzwC8Fkjy5CFikcNM6qdXkFEcS1DHjXzKIryWX4gP+38XAZ+blFh6i7r9sQMDOuoBGpA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(86362001)(40480700001)(36860700001)(82310400005)(81166007)(82740400003)(40460700003)(36756003)(4326008)(70586007)(70206006)(8676002)(356005)(41300700001)(316002)(54906003)(6916009)(4744005)(8936002)(5660300002)(2906002)(2616005)(44832011)(336012)(47076005)(426003)(478600001)(6666004)(26005)(186003)(1076003)(32563001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:22:15.0819 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d3d5da6-f5d3-4b62-23bb-08db0dcdb48c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B073.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5129 This patch series aims at improving the arm32 CI testing by introducing the true dom0less-based tests that do not require dom0 with a toolstack. It creates a foundation for further test expansion. Michal Orzel (3): automation: Add arm32 dom0less testing automation: Add a static memory allocation test on arm32 automation: Add a gzip compressed kernel image test on arm32 automation/gitlab-ci/build.yaml | 20 +++ automation/gitlab-ci/test.yaml | 48 +++++++ .../scripts/qemu-smoke-dom0less-arm32.sh | 119 ++++++++++++++++++ 3 files changed, 187 insertions(+) create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:23:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:23:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494571.764686 (Exim 4.92) (envelope-from ) id 1pRZjZ-0003wV-I6; Mon, 13 Feb 2023 14:23:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494571.764686; Mon, 13 Feb 2023 14:23:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZjZ-0003wO-FG; Mon, 13 Feb 2023 14:23:09 +0000 Received: by outflank-mailman (input) for mailman id 494571; Mon, 13 Feb 2023 14:23:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZjY-0001qA-Fi for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:23:08 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060e.outbound.protection.outlook.com [2a01:111:f400:7eaf::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef92a1c1-aba9-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:23:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7976.eurprd04.prod.outlook.com (2603:10a6:20b:2af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:23:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 14:23:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef92a1c1-aba9-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jk9UVWC4UHZsVVWSysqCMn5obZYUrvwpwZFN0Riy94AMkw0XJZu+2aTMCOf7oBhtMRRpLNc4v612B75dg3795Np2zBUxLuuwlhi0mVBOsgELYsS3Hutw1fvvFmmPo07cBASi3bksUmsQP3QETzoTZyun+jWdeglvgCXOn24jOB/B4H8IvXzghZ9nGwNJgYOVusy5UC8Iz2dk1QClNsWfDfjHhqN0pjyea28+rpTMqp1OOHArSpUL72mEaI7VNzPhzLYbYd4sMzkAnem+69EM7z0cP+IcEIs32vtgn3WjnEiKQ8zFU61HLpVo2PyXzSR/Gf9kiJgWM4+hLUAEfiRQIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pfbolgYzCDhcMaxxQAQDX5yOXjbITBK7avB1Hq5jSBc=; b=nsH1ObcNy4js9pUCydjkbFgckRr7zFfChrxVYOCaMaMZ/U+k+K/uUwjuN7WxIbsTs8QRBP6L86BhjvovDZEi8Wn2oVz0jp8e4ZM1yuJtMrhHWBW4ouz0HtP0HIXtuU9Jcd6zAdOG9nExazOKUsD9BW+EcRtdyuQMCyFFqQrPbPFDvY7/vZ7xs56jqCVVeoCP8MTZ3FWGNmKmOT+zqhq7ZuRDpyTdLJasR8ADhZkLTAOpEfA12pXDdaFj1LpOXyAqhIly9oZeElYKDIPMvdiFt4VR2n8Rz4JigfZHJzpKaQMOL0x2UHcvjYl8we6EE/exMYWDC2TiJO1LTwGT04824Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pfbolgYzCDhcMaxxQAQDX5yOXjbITBK7avB1Hq5jSBc=; b=DQZO2Jx5nnK9XISj3GHSeu0nAVufvBZRM8owIvuHmpbXA+rNryAp304uOV3dw0V2oQIrLLnztuF+qWmxv3r+wvZhtoDPCuUM9zOaDnvMloi+2MvduRnN9xgnGZkGnSrwsfOwHzWUzrzV0pOybeWSG2/+EPCAcLp1cYWyKBTJKDRUIrvXhn/5JkrtIMV/aQlsvUqRA7pVyY1779ZkqdWh5M9rwzCQy04QrCWt/NvzZqNfY6YEtIIlAMkgSJxUDml/8iNqg4dgrRoq/AyaR6Iez4pVMbXPhm90elXqMva0BNT9msJaIA09IRabmLLEzsjN+BPZRTuSo7+hZrxisCOUNQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <339b59ed-3630-1de8-deb0-5cc9301ca139@suse.com> Date: Mon, 13 Feb 2023 15:23:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: xen (multiboot) binary gets corrupted ELF notes Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: xen-devel , Andrew Cooper References: <9e4e8000-9e2d-6e43-df7d-9a34a75b7163@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7976:EE_ X-MS-Office365-Filtering-Correlation-Id: 90f0e72b-0a50-4b21-df18-08db0dcdd2c6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dO207QkOkAytEbxAOPkb5n6KRnBLAuM8qllFUGa/fGCG8cZhC4MH/aCIcwyZ406P4KeS7XU3c7VPXuePRshX8p0Wq0P1rpkanLGlBeHMnxCyCHUcNR3N8oMgIbeJ78krWlCCbrOy9LHxlZS5gSG4yoQrDEpM4c3Hu9UxePO94ag0Z1q2hCap5PAkuplOl5GPplodV8eTs5il0HP14Q9gYfJL78xH+aFSmCBAgDwrjuLkTppm1TKbhJKb7GIej2XQXqlVbsV9fBzfitySA6bXiu3mEIgLn/iAorCu+qLMe1B9MhntkQwial5vy/neEyvS0LKRwGhGlyCw1FWB6sBZaGRNPMUqWeycuHFhSrpPQN+c3vax7bLc62KFRqFSQRQu1tiV7PyqC58lbQIa4imo3t+vxbHvIeeiuQlLDFIrysPHc3BKKAT8iDgZiajFo47MmjsemXR/fRRQ9kuu60BKcyw4SqkFyOZUp1y++2E7jJLLzlI+KrYCOoepFTvM+c0UZOBRhhaeCnA0vwsQEqKxyKGT7p8HZRpf4v53I6hF69nXwy0XrE9/LYSG/tSanJ6aKwomJ9r29Nn+C7ti2dnyyrA0tccvviUJeEWgsbIvcJBLBIz+HpTk+j0pYnzjN+E1/y7N4ZMYyo9pniAZ0n+khQMUc9CX62HiID2mE/UXzxivVCG/SL2ARk+LMDCbLNXxdA/vjHpJAb3vH5R5vrPDpN+PtZBpJdM+LHQhDcHQRQrqfm8CkKdfsTKeGLEkO9oxKYtBGhlJzKFBGyh/n+GXKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(346002)(366004)(136003)(39860400002)(451199018)(2906002)(36756003)(5660300002)(31696002)(83380400001)(66574015)(186003)(26005)(2616005)(4326008)(38100700002)(8676002)(6916009)(66946007)(316002)(54906003)(66476007)(66556008)(8936002)(41300700001)(478600001)(6506007)(6512007)(53546011)(86362001)(6486002)(966005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2c5VjhDZHV6UUVlZU5DUnpQamRpMjJxSFBOOXQ5VWdVYk5xNDEwVW9TUmdZ?= =?utf-8?B?RjM1ZUl1RDJ0ei9YYnFyb1o3QTFoNzJXRUpUeDJGSW1kd051WUs0WUFWU2VT?= =?utf-8?B?OGlmdFUzaDFJMjBrMEMzZDVuU3JMSm9ZSm03bmtySlQwci82VWNGc1oxeVNl?= =?utf-8?B?cW1oYjN4endPOTQ0RkpmODE5cHBKUmZWQkI5WU04ZnRzVk9CUTcyQW54THNo?= =?utf-8?B?b2Z6U0t3UzZhdlBVSnZod0JvN1RhRTF1V1pUMS9wdGdPbnJEejBhdFVmVStu?= =?utf-8?B?dWRVVDI2R3FHMy9RZHpnQmJNSGRDS0VBNmg3YVBSVW1MaVZ5QWY5MFY3RklW?= =?utf-8?B?Z2dNWlZJVW5uVS82Z3dsRnpGVWxxSkxPM28vMUxSaEFPRDA1cVBRaUQxL0xY?= =?utf-8?B?Y3hWNFBkb1JLdlhES1U0N2xlYzJrcnFENVg1Wk9URzk1NWh3ZkVEMzBvZVVF?= =?utf-8?B?WlU2UlZUMkx1anFVRitjVE5GcmZsTEY4YW9WOWZVOFNDVUZha2ZGaldWekdK?= =?utf-8?B?WkpXZjgySnE2K3JQUFE1aVp0SFNMUlJxU09ITmxibGtIbDl2d0dDdHpuVXdu?= =?utf-8?B?ZHVuZUlZYVpHdXlqOVNoY1pId3FNOU5OMWt0ZWlxcHVxUXZTdThFM0NmeCtK?= =?utf-8?B?S2tnMUdqMHNpUjJ3cmVWVkdSenRZcU9QSnJuTHJDMXNtcnBqR3U2U25wOUVj?= =?utf-8?B?QUpLN2tQVy9hcmF3S1Nzc1lEQ3JtVWQ2emMrVUF6RmdGWndKRUNLcnNFSE5v?= =?utf-8?B?ZUZaMmk1UUwxMEVRTjBlSnBBOFArVVM5Q3FzdCswN0FFTUkrcXZzRFVNcFpQ?= =?utf-8?B?WUM0WXR1RDBhQ0VhNisxZC9LOGhLWThLYnQxdXA4V0ZicEV4NTlMdHUvMUVs?= =?utf-8?B?bmJhY0ZqSlNqekhXaFRRZGZOT0Q5amwxWWFSZ3JyVzlKVTcrZ3daUE44aUVn?= =?utf-8?B?ck5lcURQVElYdGdNVitrbGsvekNNcFBDOEtTOVVtaTRrNVN3ajBteURnb3Zt?= =?utf-8?B?NUtKU1MvdDZTT2xvZFdlc0tKWEp1dGlMRUxqcFI0a29QUnptZFdSYUN2YWZj?= =?utf-8?B?Qzh2aHJYWFlvV09wc0txYkgxVTRTcXBOME1MZW93V1dCdkgzRzVEbzJlSXYz?= =?utf-8?B?RmgvdGtFYmhZbnMwSlQ1UVRUUi9rcklieU9qT0VTQTQzRUEwZjBpeUUvaUhL?= =?utf-8?B?OHpOWnRISzI4UUZjYkJDaFlmR0lFejlVWFpKZUoyMVpXUFRZVWxNNCtPclIw?= =?utf-8?B?N1VQVnJKckljZ0U4Qmg0OHY2cENxcTUwQU5FUnpKV2oxYlF0RFE5K1BJTlJM?= =?utf-8?B?R1hCZlVJMkZRdFZuN0NUNG1HT081QUllbmFUckI3NWRXMlkvdTN1K2pZNDFH?= =?utf-8?B?cXZFZ09BcTZvbXpweWNUNE1uU3UyTml5MUZ2Mmw2d1phemM4V2E5MmliK0Ry?= =?utf-8?B?MWtVVE9TMVJ5L1VrclZ2L0RURHNwVk9EYkU1NnJWYS8vWUZMbDZkTy92eTJG?= =?utf-8?B?TXh5dGg2c2IwYWtUNHEyTkdJRjQyTVFOS3NkMW0vTVlDZXRVbGQxVmZrM2My?= =?utf-8?B?ZjJoS0xwYjRKcm1hcGZ1ZkVzWFJGc3ZodG1DcDVXb0s0dDJKYjF2Ym4yTW8x?= =?utf-8?B?T0MreW9yUGpMVjBheXJnNVcyenBLRFdIem5IOUg5Y3N3Z0h2QmlzNVB0RjBu?= =?utf-8?B?dmdRZkFLa3ozUHREUzhUZ3FXaWxNV3V6ZEZMVWxnczVHbUdValhYV0NSOFJs?= =?utf-8?B?eHJhQ2svZW1qOWZ2QnFRMlBnbUVLd090cDNBOC9qSzgrVjRnQzQzcWpsS3Jp?= =?utf-8?B?YW1qSEZjbXQwWjlsZTdpVW01VWEzVGJNeVNqMnFrOTZwS200ZGpienIrODNs?= =?utf-8?B?WXNkelJTdnpGNTlhd09vMWFJK3RBaVlpSmpraVZXMThVNHdmWmpOSVlveTlP?= =?utf-8?B?WUxyZ2hjeDRMNjBLT1ZWeXRjelpLMlFYR1Y0Q2xCL2liRjBpTTJUdEYwNUF2?= =?utf-8?B?YWI4WWpkN2dKZlJsVjFnUXl6MmFFRUxVTGdKQy9iMTdGemwxcXY1d1gvY2lT?= =?utf-8?B?VXF2d2F5N3h5WHpsclpwQU84NFhORlpvOW9rSzdNdVR1STNmM1hKbmg5b3ZZ?= =?utf-8?Q?g8KmPrwTdEiK/6R3OLxyhB6JS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90f0e72b-0a50-4b21-df18-08db0dcdd2c6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:23:06.0949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SVgom7+l/Cg4gqnzKZakdqJykH+H9DqbVjVOmAmdncBjM7UNfM5Nvfo4Ca8xDLV2elrFNkBZyFx3Xz1xhUVUyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7976 On 13.02.2023 15:12, Marek Marczykowski-Górecki wrote: > On Mon, Feb 13, 2023 at 01:53:21PM +0100, Jan Beulich wrote: >> On 13.02.2023 12:14, Marek Marczykowski-Górecki wrote: >>> Hi, >>> >>> I'm getting some ELF note issues on multiboot binary >>> specifically: >>> xen/xen: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, BuildID[sha1]=f7d2c37a4ad599b268f2f2d94bff3776d12649b3, bad note description size 0xc0010001, stripped >>> >>> readelf additionally says: >>> >>> Displaying notes found in: .note >>> Owner Data size Description >>> GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) >>> Build ID: c5825a0d08edc4d11b1138fedca6b14ce8ba7302 >>> (NONE) 0x00000004 Unknown note type: (0x00000020) >>> description data: 05 00 00 00 >>> readelf: xen/xen: Warning: note with invalid namesz and/or descsz found at offset 0x34 >>> readelf: xen/xen: Warning: type: 0x4, namesize: 0x00554e47, descsize: 0xc0010001, alignment: 4 >>> >>> Grub doesn't care, but launching such xen with kexec doesn't work. >>> >>> Initially found when booting Xen via Heads: https://openqa.qubes-os.org/tests/60151#step/install_startup/11 >>> >>> Andy says: >>>> yeah, I've seen the same on XTF >>>> binutil's recent elf notes for CET compatibility use an unsigned long >>>> so they're not compatible when we build as 64bit and then re-package as 32 >>>> I think we need to strip all elf notes in mkelf32 >> >> Instead of complicating mkelf32 (we want to retain at least the build-id >> note, after all, and for PVH_GUEST builds also .note.Xen) why don't we >> discard the unwanted/unneeded notes then from the linker script, just >> like we already do for xen.efi? > > Ok, this seems to help: > > ---8<---- > diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S > index 8930e14fc40e..f0831bd677e7 100644 > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -192,13 +192,6 @@ SECTIONS > #endif > #endif > > -#ifndef EFI > - /* Retain these just for the purpose of possible analysis tools. */ > - DECL_SECTION(.note) { > - *(.note.*) > - } PHDR(note) PHDR(text) > -#endif > - > _erodata = .; > > . = ALIGN(SECTION_ALIGN); > ---8<--- > > The comment suggests some notes could be useful, but given they are > broken anyway and nobody complained so far, maybe not really? Well, much depends on those unspecified analysis tools. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:23:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:23:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494575.764697 (Exim 4.92) (envelope-from ) id 1pRZjr-0004OE-Uo; Mon, 13 Feb 2023 14:23:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494575.764697; Mon, 13 Feb 2023 14:23:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZjr-0004O7-Qz; Mon, 13 Feb 2023 14:23:27 +0000 Received: by outflank-mailman (input) for mailman id 494575; Mon, 13 Feb 2023 14:23:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRZjq-0001qA-9o for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:23:26 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2060a.outbound.protection.outlook.com [2a01:111:f400:7ea9::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9481789-aba9-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:23:25 +0100 (CET) Received: from DM6PR17CA0020.namprd17.prod.outlook.com (2603:10b6:5:1b3::33) by MW3PR12MB4570.namprd12.prod.outlook.com (2603:10b6:303:5f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:23:21 +0000 Received: from DS1PEPF0000B073.namprd05.prod.outlook.com (2603:10b6:5:1b3:cafe::f7) by DM6PR17CA0020.outlook.office365.com (2603:10b6:5:1b3::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Mon, 13 Feb 2023 14:23:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000B073.mail.protection.outlook.com (10.167.17.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Mon, 13 Feb 2023 14:23:21 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:23:20 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 13 Feb 2023 08:23:20 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 13 Feb 2023 08:23:19 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9481789-aba9-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZCuMvUI0XSa8xJ0j673rW7KwYuLlbs8Fffs3gDgliW8Qy0tUF/YwD3M/9GI6ws/oTTKI+YrmwOH5KwZLkF+S/+QYl3kqCeyYePvXbvgcobLVVafxtEppwy1nzyIOlEKHpkfz0LCj5S4rdZds+RORqACulphIJiydVNrn+VBK2a2Do5jJ7VvvLLc2PNM0AmGvimNJrgtcFa2UjT4CTfh2aqVzKI98ZDphPIbo+75j4f5jTxMB9xYXq7PjzvOqSwwwcF1kZmK/mx6yiYArnDHcM9omu5ZOM3zPsm1Rc54OUjICZ7ocNvdz7O6f0nkygagiF1nAd+vpBF2TN+9P+6iAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c3LAAQJ+In6ShGDftioJeaSS5XhI1kLDe3N52dbgbNc=; b=OBoE0upmKS5nPpARERd30ZXQaqlfI8n10DkdEpTKZaKjvp9x6RcobvThAI+4G4Q+UuGbl4/CSZeCU1rEqrCL1JojZ1G1H1KsXRRWIIz7BwiwitNbArputdy+X54sDy6jc/jhaEyY15pDzmnIqqzQnPzXzeDwwQyDWy+PhxXi4qk8CoUWf9DK26DaWqh4qLsmKeIeZAKuO8hqaPAJ9B+fAMANKyuxaYFUprDD5F/TtoMBArUQaKu1anMYe6/KnJ/Xw2duEnKVd39FJ+TLOQNzMBr6w/4UrGTsembtCbDYmzHT8Im7SJ7a2OvHEUg3XMl6+sfb+kwh604lDYqZ2MA/Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c3LAAQJ+In6ShGDftioJeaSS5XhI1kLDe3N52dbgbNc=; b=0Ud+Ibjetac8KJJHmSURTvXzgFV8Rbc/SHTJq0Id2cx053aCNTkX980ZKvDivsOj5LccH6UYRZcjFavEDmtpBQwpNq7TnVY9iyjUFzf39o5dm6ImqBGsDUZTG9rCEaLpyVVPAYGZBr2fun8sHLJAq4tm7FJbmkzmrHFSK9hFwEQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH] automation: Add container and build jobs to run cppcheck analysis Date: Mon, 13 Feb 2023 15:23:12 +0100 Message-ID: <20230213142312.11806-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000B073:EE_|MW3PR12MB4570:EE_ X-MS-Office365-Filtering-Correlation-Id: bf397c41-a80b-47b2-6c1f-08db0dcddbe0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ni0vVi62h9mP5TDki2SiPZgk/4Qt8PWN2ZZmjKHEQlh7W8QhCHmV0nwBmixQbxw2teEF/DhDVXO/LkbqjlCH0ZhmF1KcaJgApF5wf5J8PsjRUUTvjezoIjVPhx1I5YFztjAEJ6ELfEazB0xnXr2P0ka9i77xsvo9DY/fHI7IgclVCfiSY00bkCQFPfGoMQsQzqYyCmGmW1a6apRidp+4jWlMiW2AqTtveentPhSQ3upCcOq6EtZ5YnxHUeOtE8+y3HuQ24ZfcEyajUW3DvdsT+yV6r2Gl/0gAuQQSmm+T6U+SSINKLn0WBpvm7YkPP/ejZrbKf2yms9S4PmGE8x5vxPqOF8B8uZGUOYXCcqNSAJzGZXN7h93fAjRiofPEoeXdLzn3Ajr3bFc75y3T0mr4e2kwFaWVA7L0xNmW/cPsE5Pqtzzj/8O2vIBNoxZ1zdm+VhHNXBVK7xe9fbNcjpPvD0+hN20c0Y/UOFx/BiFEyzefXchP2st2+9At3AfesUyRAvTjoiNdYz4NsYnuAUp5W5sso9tvhiQgX482yK63dd6a3yNqBwkS+Ff93DsngS9kJaKWqCd9dQCK6QNH0NEd2p++ioPGOe7fdOR1h86+Z17pWZRFJmQyQ2KwgGVf0EMcsIt5z+TgYs9PM1BcfWVA8LwiOz1aaVsNu5jqDxcDED2VgpxqYTV0Tg7dJGGnFPylK7LHQCzfpEfh8eLOFhHtDuwD/Q2YgRhlbi07Z1PSYA079O6eonoDejP3tKDAY2DrMPcmZ5gyG3UxO55kVZNhQn/V/C2c7TRUKdMDuRf6cPkuzfjHXLJJ91cnqeUpNUw X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199018)(36840700001)(46966006)(40470700004)(36756003)(44832011)(2906002)(5660300002)(83380400001)(426003)(47076005)(26005)(186003)(356005)(336012)(40480700001)(2616005)(36860700001)(82740400003)(81166007)(54906003)(70586007)(8676002)(4326008)(70206006)(6916009)(316002)(8936002)(41300700001)(478600001)(6666004)(1076003)(86362001)(40460700003)(82310400005)(966005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:23:21.0650 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf397c41-a80b-47b2-6c1f-08db0dcddbe0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000B073.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4570 Add a debian container with cppcheck installation routine inside, capable of performing cppcheck analysis on Xen-only build including cross-builds for arm32 and arm64. Populate build jobs making use of that container to run cppcheck analysis to produce a text report (xen-cppcheck.txt) containing the list of all the findings. This patch does not aim at performing any sort of bisection. Cppcheck is imperfect and for now, our goal is to at least be aware of its reports, so that we can compare them with the ones produced by better tools and to be able to see how these reports change as a result of further infrastructure improvements (e.g. exception list, rules exclusion). Signed-off-by: Michal Orzel --- For those interested in, here is a sample pipeline: https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 --- .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ automation/scripts/build | 11 ++++- 3 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile new file mode 100644 index 000000000000..39bcc50673c8 --- /dev/null +++ b/automation/build/debian/unstable-cppcheck.dockerfile @@ -0,0 +1,37 @@ +FROM debian:unstable +LABEL maintainer.name="The Xen Project" \ + maintainer.email="xen-devel@lists.xenproject.org" + +ENV DEBIAN_FRONTEND=noninteractive +ENV CPPCHECK_VERSION=2.7 +ENV USER root + +RUN mkdir /build +WORKDIR /build + +# dependencies for cppcheck and Xen-only build/cross-build +RUN apt-get update && \ + apt-get --quiet --yes install \ + build-essential \ + curl \ + python-is-python3 \ + libpcre3-dev \ + flex \ + bison \ + gcc-arm-linux-gnueabihf \ + gcc-aarch64-linux-gnu + +# cppcheck release build (see cppcheck readme.md) +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ + cd cppcheck-"$CPPCHECK_VERSION" && \ + make install -j$(nproc) \ + MATCHCOMPILER=yes \ + FILESDIR=/usr/share/cppcheck \ + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" + +# clean +RUN apt-get autoremove -y && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* && \ + rm -rf cppcheck-"$CPPCHECK_VERSION"* "$CPPCHECK_VERSION".tar.gz diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c7325d..c8831ccbec7a 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -7,6 +7,7 @@ paths: - binaries/ - xen-config + - xen-cppcheck.txt - '*.log' - '*/*.log' when: always @@ -145,6 +146,23 @@ variables: <<: *gcc +.arm64-cross-build-tmpl: + <<: *build + variables: + XEN_TARGET_ARCH: arm64 + tags: + - x86_64 + +.arm64-cross-build: + extends: .arm64-cross-build-tmpl + variables: + debug: n + +.gcc-arm64-cross-build: + extends: .arm64-cross-build + variables: + <<: *gcc + .arm64-build-tmpl: <<: *build variables: @@ -679,6 +697,28 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Cppcheck analysis jobs + +debian-unstable-gcc-cppcheck: + extends: .gcc-x86-64-build + variables: + CONTAINER: debian:unstable-cppcheck + CPPCHECK: y + +debian-unstable-gcc-arm32-cppcheck: + extends: .gcc-arm32-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- + CPPCHECK: y + +debian-unstable-gcc-arm64-cppcheck: + extends: .gcc-arm64-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/aarch64-linux-gnu- + CPPCHECK: y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/scripts/build b/automation/scripts/build index f2f5e55bc04f..c219752d553e 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -38,7 +38,16 @@ cp xen/.config xen-config # Directory for the artefacts to be dumped into mkdir binaries -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then +if [[ "${CPPCHECK}" == "y" ]]; then + # Cppcheck analysis invokes Xen-only build. + # Known limitation: cppcheck generates inconsistent reports when running + # in parallel mode, therefore do not specify -j. + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra + + # Preserve artefacts + cp xen/xen binaries/xen + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then # Xen-only build make -j$(nproc) xen -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:52:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:52:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494598.764708 (Exim 4.92) (envelope-from ) id 1pRaBs-0000Pi-3s; Mon, 13 Feb 2023 14:52:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494598.764708; Mon, 13 Feb 2023 14:52:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaBs-0000Pb-0s; Mon, 13 Feb 2023 14:52:24 +0000 Received: by outflank-mailman (input) for mailman id 494598; Mon, 13 Feb 2023 14:52:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaBr-0000PV-4s for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:52:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0532d2af-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:52:22 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8378.eurprd04.prod.outlook.com (2603:10a6:10:25f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 14:51:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 14:51:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0532d2af-abae-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6yxHOstGHZui11p+BdH729lVFzxyI6NS09pGAmv1l8h8A4/h29OzNI18dy8jyf9MTNeh5Pw5QVb4g/qvryF0BYTB6KtpwaeEgZOANrUarP9xjCnztip5ICqK1yMsWNguTD0lbLUR4fzYOxo9/bwXgUcoJm+E1+dhOdH5pldu97+i7W/WxfmNkSj1Bk7oYLWtxnp0HZBUjdNOUlVudoERh8Yp9S/yMSuDgNwiPjXUkDAaabNi21wGlwRFCaxnueWTvK5CP9gnk6RPXgsEuXH5LcAa/8kK69SVxioII1Y+A6IMdHAwtObeD/iIH72ZRMBSaFzJ1zMkfteTcnUTlXKSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShS9+tjms6qa9jf847ybPoBZS94S1cWmOo2Zxm6z5J4=; b=i8WdS4fmedNMIxtkTtXW9vSxdn6PwCplxx7Nrsutxla0QaGTBuwJcbalXHh3YBmqFrTQUD7Q1Hb/oSGhYS7XZBFjbn5eLY2sjXdL1/Q7PyILYVsdAJc4NetCiQfHuhcpzjBhDohAWvUCxpZpa2A8qXfdtjLOzGdy6WHnb4peM8s4AKw0RJr3/yr7H2JFvL6zn9tDDI4+L0UnyHNdo/J/LGj7wRQvYxGxyzWwc2lMB3MCC3g6ElSUwcU2z4H02Qc3gcy5adW31UL2ynYQ02YPy1Cht9s4kDVCcEwEmlEatqCJsfWbuSalJZ4j9xvwmJYEfTGvxurSrhGfxHNTLXmbog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShS9+tjms6qa9jf847ybPoBZS94S1cWmOo2Zxm6z5J4=; b=P8fwGnjTQle9+qnYq9uH0i1OkRyXrcUVlFfj544HgZBXA7d384qKhJICT5P30InGTL5gqOViu8E3Qvx864SGljqsiJv8jAoFTGYVz62/r4Jg5cIfTMZV66fA9ZP5KA/NVAL7XBnKetocgBAY1VO6wVO662//ccJvrSrurIiPLY7mbGhfPekqUA6/t2JwE+slW2QVFoF3kLELoC29ZhtDaL7wi7MzaknbWnZNVVRHgC5GAD1UMBu6Hkck4JUr2jVek2JVtcu/mhyHm4fVI4hv7rGMpg/c+XxGR1au31+FgFETMxJKX9ts0//dmjMcLJTUqlc5jAqY/UKJIWpXxqdjuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 15:51:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/platform: make XENPF_get_dom0_console actually usable Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8378:EE_ X-MS-Office365-Filtering-Correlation-Id: 4bc6c387-3bac-459e-115a-08db0dd1d7e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QmleFYYnlJXoLbZTJtUHNda/sccf2L42LElPuvKc6KCbSi06No64NvPGeNprjSNZlPRcSGNcPqslbhJtROsbYJrMUQuNiDsFtnqwbRBKIaqrqirSwmaLl795p5DgOtX+EY5gVRPnSx8eR45VZ9lvkE+FsyQeH4hXSwBdvWcTWcaOnlG96d7fwsOAZpj384H2ph0OxEMLFkV+gSgX+SGgnD/eIdAbhNmcYVKS0m7P8BNsVREEIW3Ywdo3cEuKiFTAGEtPwe7Rz581CkDcC413RcuYdptXqjoqCcZh526DHqsusWomPLLAmc1R9yZ2cXm62ZsXShUIGn9x0TDmuF3VGkVu8vEACgdQXeUEbs76V/Rn8mNPUHdwpzURVFxbZKueQtAa+AyXlyc9D5lErmxuao5lk5x9PITqqoLE0uTHrHzBakDE0CEy1zNBnEL/WzXe/MZf01JV5tRVfwkvsRM1gpcvnQs3O1tXX5k80DwpCKhuUhA8TfGsdAobypApf+VBiu30SfipwLpIFXcg1tCpzixZ5S+TeFIbWRWTgROc/v7yfOY2g13U32MaWNIALOi/gtdYlr9k+nJ50FpM1Cy7hq4/XabMOUh++iCEHXxsb8szDowHKGv9jO8Ii8KHb7thll2JRRLeflqibjSbv7sa3gJU7TAN+QhUS3mTivgXOX4awovQVtoNYp4JDrBgplzW+fu7xQPhkZJ7+ao5NzP1Lq+R9Yt6DIFJmf0R/hcD4vw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199018)(31686004)(86362001)(36756003)(31696002)(2906002)(5660300002)(8936002)(41300700001)(38100700002)(83380400001)(6486002)(478600001)(8676002)(6916009)(6512007)(26005)(186003)(4326008)(316002)(54906003)(66476007)(66556008)(2616005)(6506007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yld2dVlOZW1XdmhRS0ZiVXoyM1orSzRMVTduTjVvV3N6WHIvM1JmY1lKZjBN?= =?utf-8?B?c0RITGxDWWJ2TUFXUVhnVjdDYzRQYXRhamZHSHU5L2dwdGJvZUVyYkYzTzdw?= =?utf-8?B?M2lVek4wcFR5MkhHMG1uWGtpS2V6Rmw3VnNTbHhxTXI0QUtLNXRzeUFoMEhI?= =?utf-8?B?Qnc0TEZwN2xHZld1ajA3SkNGb01zOUtoY2RRRUhDd21RSEJEb2hKcHVteEZF?= =?utf-8?B?TXlBQ3Z6TlJXVXNOSTNnbWRyaVVqTkg1dVZXUG1lT21zNFdpdkNxYlB6TEtw?= =?utf-8?B?MmN0VXZpSUkzZ1hWWG0rUGFSRFZYenRYWjArMjgvSmRBbytPREtVdTBzVjFw?= =?utf-8?B?eFRZdWMzNlhneTdkeXFrSXhTci9CSy91U2VjY25xaUhOTlBxaDVCVDZYYXUz?= =?utf-8?B?SWkzanUvbFNBZHhHc2dtaE9rNXQ4QU4rL09WZ3JYcFdMcVBwc05wczZJY0wz?= =?utf-8?B?QWsxZmpJSGFHRWZMZEFxNjVNSDM1Vi95OGV5VGtRRm51ODdkNzErV0FKajJj?= =?utf-8?B?b2xoTXI5aHoySngxVFZTSkpSZHRpSmF3N2xrTGZta0RUeWI1ei91WEErdUs0?= =?utf-8?B?Y010ZFNEUEJCcFQ1dU1VRDFxN2d6eUNPeDZGWCsvTGNkMmlJakc0NkZzSlBW?= =?utf-8?B?QkxCdU1Fenl2cW1RSkpSYWpTWFFXK0lXanZRbE56SUVQVDBzRC92T01ZS0JB?= =?utf-8?B?RVZ1THRrbjhNWjY0Tmg4djZ2OXJRL2hiY2xXa0V1Q0VSaEh1V0tCUGdzTExY?= =?utf-8?B?eWk0eFl0Kzh5STFuUUhPUXhEaFJPSmdOelZ3c0xkZ25URWJmVVg4N3NjNkFC?= =?utf-8?B?MTcveXhWSjVCcWliTDhRY05YYm1NMmpqWkNzdlkwWm9aM2NZb1NhTWFRbHQ2?= =?utf-8?B?QVlUSmNGSnFZUEZ2ZDZTaVVldkNGNmcvMEgyQTZvWS8yZno3V3B0MEVwMjNC?= =?utf-8?B?S0VTSVZQM1dsakcxY09BYmhDVlNxSUErNlFnNUJKNDJWR3o1WExubmJRMVZD?= =?utf-8?B?RHBXVEdQMUpkTFYzbG82aW5lcWJtenVWWTcvaFNIK3hsZjlnSjJTSThaY0N6?= =?utf-8?B?ekp0aDBZeDVoWUhCSkh5cDRtTHkyUW1YRGZIcS9MQStaNjBXZ1hrdkt0Zlk4?= =?utf-8?B?UzZYbnptajFRZFY2dDFqUDNTSXFHV1N1OVVzbERuZTZCaGdyNnhPMXl0dEJ3?= =?utf-8?B?VDllZVZGSzhpTklLWmY5MGl0d1JGQnI5TlRUcTFKV2U4WGhoNGtoMStIVFR4?= =?utf-8?B?U1NYWnhRQ3p2alZMMHZtaHBGNjF6eU9wZzlsSkhRdmFHNC9yQjVkRHkrWXZD?= =?utf-8?B?VEZWWFFOakxqNk51SU5nN0I3VXZ3NWtRWmo2c3A3eWlCOHJubU4ySThNMmE2?= =?utf-8?B?ejNkTGVqQUhTOFhMS2FRdlNWNUE2L3NzZU94RlEyamViSzZOSkVzbU4rdW1o?= =?utf-8?B?UjVkMU5FVFhkWEdQTE1wamU3cFpJaVJiT1NIdXdpejc4Y045citTTlA2M3hW?= =?utf-8?B?akNyTUY4dGdtOW44VUJKNCtua0d5dXZ0emZ6M0t6T2MyK2ZtS0oycHZRN2s4?= =?utf-8?B?V0lNN0J0MC9zM1hVTVFaZThDMU1xem43WUVyQ29lMEkrajU4bE5Yb0NrZis2?= =?utf-8?B?b05JeS9rVng0TWxFWjR4c2Z3LzNSamQzN2tyY1YzMDlpZmd2NkVUbU9uMXFy?= =?utf-8?B?ZkhZVlBVeGJRUEI2aFNDYnBNTndUYkFQdVRkc0JPaitjMnovZ1R2YXIzRFJu?= =?utf-8?B?b3A1K0lQNXQvS0dhOXp5QTc1RFhVU0ZPbG9TeEdZSEFxeUVoNDd5aHd1Y0VI?= =?utf-8?B?YTBSRzRVc2ZTRkE0bjJyQzNwQjFLRXVCb0RGM1YrNDVySHBFNndEQnp2QWhB?= =?utf-8?B?dDM4RjRQaTNqZzNIQzJtY2ZsWldwSTJRdElBdFJMWlU3YkNhd1o4SGV1bmRF?= =?utf-8?B?ZnplZ0xIOWVQSnNDUUN5SFV5aWZzZVpUck5Wcnp6eDZVUG1YRmprcXV0M0Zu?= =?utf-8?B?eHBIMVUwbFc2V1F4WWdDNy82UktvZ3BxZ1dlS053MTVhSFBvQU9wK1A1ejlG?= =?utf-8?B?VWVubFpWUXVORDltdmNsYjhMNWhrSTRiYThZTUNIcE5jdGpmVVEvNGdMeENF?= =?utf-8?Q?bYNWBLQoaJBAeL52HRKkoOc4H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc6c387-3bac-459e-115a-08db0dd1d7e1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 14:51:52.6265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gqwuro3Sv10lyp7Tz4JnGaJRgee6/FPgvv7RFxwkvEPLesL+8WhQpepwco7ZaVfPeGTlqHC0VC2w6mUM6Xo3YA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8378 struct dom0_vga_console_info has been extended in the past, and it may be extended again. The use in PV Dom0's start info already covers for that by supplying the size of the provided data. For the recently introduced platform-op size needs providing similarly. Go the easiest available route and simply supply size via the hypercall return value. While there also add a build-time check that possibly future growth of the struct won't affect xen_platform_op_t's size. Fixes: 4dd160583c79 ("x86/platform: introduce hypercall to get initial video console settings") Signed-off-by: Jan Beulich --- Noticed while trying to actually use the new hypercall in Linux. --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -841,6 +841,8 @@ ret_t do_platform_op( #ifdef CONFIG_VIDEO case XENPF_get_dom0_console: + BUILD_BUG_ON(sizeof(op->u.dom0_console) > sizeof(op->u.pad)); + ret = sizeof(op->u.dom0_console); if ( !fill_console_start_info(&op->u.dom0_console) ) { ret = -ENODEV; From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494609.764757 (Exim 4.92) (envelope-from ) id 1pRaHP-0001tn-82; Mon, 13 Feb 2023 14:58:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494609.764757; Mon, 13 Feb 2023 14:58:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHP-0001tW-01; Mon, 13 Feb 2023 14:58:07 +0000 Received: by outflank-mailman (input) for mailman id 494609; Mon, 13 Feb 2023 14:58:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHN-00012P-IR for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:05 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1cb4403-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:58:05 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id w3so6279037edc.2 for ; Mon, 13 Feb 2023 06:58:05 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1cb4403-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ujMzxZfrYB5JFSrASU3fn2r5SzOae7nTM8nRB1r5wJY=; b=qQUzqofAB7XHVlMOJ9/FiXdsAacgiS1HSqi/8gBRNXvR56Oj4eO3O8SJgrLiL9tVEt rfBTy+Qs9j5FxHLjB1uR8NE7soc6tL4v/cm6P4jMtPXiknjOjvWhOrZOUh6zb0ijU4Ep cr0sJL06LieL2T8A2eJgMYsz/7AqDWm0Ld+lEgshwqK1DKHLXbtXO9NTqn5sUqjyQxxZ VInXFl0fSpMym4dxoxV7fcorKp0jetIjKw+QeKDPOiuktGtcGGSZevTby+s9p3xDwi5r JeimrvjdRoXR2C+eEggRYLl22PNakIG5w572SRtHitcKA6yytQRD4oIF4KprCY+6Dk4G H9pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ujMzxZfrYB5JFSrASU3fn2r5SzOae7nTM8nRB1r5wJY=; b=gSAoZc59SWV6eX6ercuQFVU5I+i81uIPNtgRzftWyVYdLXFMeAeT2MCudJyIoCXzR6 b6z3lAAjNNuPXau3tV91fGVfuU6kU0NP9kXa3Jph3PlHtEwV9F3YlBOzwVm/GhuidNsz l2DOs3EBZnu9sQl54jOXZ5FfLtHZstPliUz5uxkfEsV61ht97Sy8uDu9ziDBqfKPPbaI FsSESlidVUkoI7WB2c01uryJGxQT995uqhrB03TxWZnyUrC5s9Hlzs/mB5T7hbEurcgB JTZqU/G5RujoJrlrdPDeWMX55gAsc589/4Ag6p5MtURraVZUdenUKQiQsch2xBuYAELj +tlQ== X-Gm-Message-State: AO0yUKVdyxDasLRnSTP8XxoOvpQmFPxaI64pD94dlOubufBX7EAG3Oky DQI0YsoEJ18IWg51o46IlWfSx+t20E0= X-Google-Smtp-Source: AK7set/AgUit0BtL52XxsnBZB07JuKhunWPqAOd3skmpuIm61VEmLFWBGHZlfOt4Hgg3BEozgoJVnA== X-Received: by 2002:a50:d547:0:b0:4ab:15d9:2dae with SMTP id f7-20020a50d547000000b004ab15d92daemr19565683edj.14.1676300284612; Mon, 13 Feb 2023 06:58:04 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 04/10] x86/vpmu: separate AMD-V and Intel VT-x init arch_vpmu_ops initializers Date: Mon, 13 Feb 2023 16:57:45 +0200 Message-Id: <20230213145751.1047236-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function core2_vpmu_init() is VT-x specific while the functions amd_vpmu_init() and hygon_vpmu_init() are AMD-V specific, thus need to be guarded with INTEL_VMX and AMD_SVM, respectively. Instead of adding #ifdef guards around the function calls in common vpu code, implement them as static inline null-returning functions when the respective technology is not enabled. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/include/asm/vpmu.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index 05e1fbfccf..1e08afb7af 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -53,9 +53,18 @@ struct arch_vpmu_ops { #endif }; +#ifdef CONFIG_INTEL_VMX const struct arch_vpmu_ops *core2_vpmu_init(void); +#else +static inline const struct arch_vpmu_ops *core2_vpmu_init(void) { return NULL; } +#endif /* CONFIG_INTEL_VMX */ +#ifdef CONFIG_AMD_SVM const struct arch_vpmu_ops *amd_vpmu_init(void); const struct arch_vpmu_ops *hygon_vpmu_init(void); +#else +static inline const struct arch_vpmu_ops *amd_vpmu_init(void) { return NULL; } +static inline const struct arch_vpmu_ops *hygon_vpmu_init(void) { return NULL; } +#endif /* CONFIG_AMD_SVM */ struct vpmu_struct { u32 flags; -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494608.764752 (Exim 4.92) (envelope-from ) id 1pRaHO-0001ps-OQ; Mon, 13 Feb 2023 14:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494608.764752; Mon, 13 Feb 2023 14:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHO-0001pd-L2; Mon, 13 Feb 2023 14:58:06 +0000 Received: by outflank-mailman (input) for mailman id 494608; Mon, 13 Feb 2023 14:58:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHM-0001Ha-W7 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:05 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0d24940-abae-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:58:03 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id eq11so13271373edb.6 for ; Mon, 13 Feb 2023 06:58:03 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0d24940-abae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ehevLc9UhGQTTXawWIjo+7aNcyD01VoFpnNrDZ36mVw=; b=c9lUKLlsbtltLGWVZRSYyjKUzvZBFCrc2pKH061xmq457BT5H00nnOlPWHpQJvU7xH EbMm9buOdH5hGvx/huQcGmVyF8qDpVcVf1oENRftqo1HH0Hwscai5fHS/WTdlvkl8IaA SX0thonEGefecuqO0oyKbsgozeCWdXWW/KKMf1fdM9KOozrFpWOIyS4FPXoVZKp/Ha7T JYF4yavwnmcbSyeULGB73vAF7X/nLc8RF63k2G8ZpacZKvyN60p4IlQT+oYbbPkqy25G nnjy2X4tcJYJG4Q2aHGT+n8eE0kMXVVGrGvvQRLq6BDv3YfMc+sjM+OkENAWC/S/qmh6 PRzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehevLc9UhGQTTXawWIjo+7aNcyD01VoFpnNrDZ36mVw=; b=qqOpeTFjtJrmOKgO0wZtQuWBEep6CmLP+g3MqBXes7mphlU79pq45boWkJSpC8GlRv XwLbe7obKUr4rYPlqHvEh0chCZPVPb49cqTByq7TyV8FfHVusLNzN6rcD63/E12Civqn rpJbazDeAhS469Y0c3BSvzxH0HB9xrF56ysOeC+rqTBLlnjNl9iKV/9xwxErzGQub3K/ NOrDK9+o/WZnhFq+sBU9VYdt+dCZsi8Nz/3Ms3kWOAZmkXY0gZL96ktUAw89c7aITeJg yiOffKpIht9QLu9ya97e7JC232ew1T65xnCG/1WhGkvu15TUZycighVMef1AImTrrqXH IZ1w== X-Gm-Message-State: AO0yUKW4SlBuJoJGdifF0FQBqO0O7tqA6uaPcvaN9manMphqI1lKXlIu mRFnH5pF4n8sadDPv+uBO+jAG8VvayM= X-Google-Smtp-Source: AK7set/RhU+VKXAMuoVSRcH0AkySbUzaBHdZAEoRN54+E6ZdszX6hHmjPmE+XYWHO9PeKbDe2npL9w== X-Received: by 2002:a50:bb4a:0:b0:4aa:f932:6f49 with SMTP id y68-20020a50bb4a000000b004aaf9326f49mr20931521ede.8.1676300282961; Mon, 13 Feb 2023 06:58:02 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 03/10] x86/p2m: guard vmx specific ept functions with INTEL_VMX Date: Mon, 13 Feb 2023 16:57:44 +0200 Message-Id: <20230213145751.1047236-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions ept_p2m_init(), ept_p2m_uninit() and p2m_init_altp2m_ept() are VT-x specific. Implement them as unreachable static inline functions when !INTEL_VMX. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/mm/p2m.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h index cc0f6766e4..ac80414688 100644 --- a/xen/arch/x86/mm/p2m.h +++ b/xen/arch/x86/mm/p2m.h @@ -35,9 +35,25 @@ void p2m_nestedp2m_init(struct p2m_domain *p2m); int p2m_init_nestedp2m(struct domain *d); void p2m_teardown_nestedp2m(struct domain *d); +#ifdef CONFIG_INTEL_VMX int ept_p2m_init(struct p2m_domain *p2m); void ept_p2m_uninit(struct p2m_domain *p2m); void p2m_init_altp2m_ept(struct domain *d, unsigned int i); +#else +static inline int ept_p2m_init(struct p2m_domain *p2m) +{ + ASSERT_UNREACHABLE(); + return -EINVAL; +} +static inline void ept_p2m_uninit(struct p2m_domain *p2m) +{ + ASSERT_UNREACHABLE(); +} +static inline void p2m_init_altp2m_ept(struct domain *d, unsigned int i) +{ + ASSERT_UNREACHABLE(); +} +#endif /* * Local variables: -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494606.764730 (Exim 4.92) (envelope-from ) id 1pRaHL-0001Ia-Vq; Mon, 13 Feb 2023 14:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494606.764730; Mon, 13 Feb 2023 14:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHL-0001IT-So; Mon, 13 Feb 2023 14:58:03 +0000 Received: by outflank-mailman (input) for mailman id 494606; Mon, 13 Feb 2023 14:58:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHK-00012P-2K for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:02 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfae58e8-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:58:01 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id bt8so7469884edb.12 for ; Mon, 13 Feb 2023 06:58:01 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfae58e8-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HeAl2muVNr+xBWeBNqW6dkb9Qt1VF+mqagJ51IbAAUY=; b=glvTuglrnCswKeleHOErx9yowMgXTUBT9C0pWMfJ/xQX5AgnDJtZgE5M0GiQlOt1qL 7HrGCJUw2pmCiV1UpKPIFD4kW3mOpkCzXx/kmSy61ZtBvCLXO2Dj4xXWzzOb1x/I0bq4 qCX/6njhrE2hX23krceYh9+3FND6fh4co0mo2AfpEimXAayLXuK+wUtLl11yTgTcxoIS eRrEEOTBFQHHT4aLCATyl856hBfV5+8tqyzW5idxN2rLC6qoPLJvW305aodrUVr+AbSC UhgAqQRRKzC5s84GZXENX290OPo13cGrxnf95aPgUGZzRaax8fwTX1RCLpKceP2/g8FK aRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HeAl2muVNr+xBWeBNqW6dkb9Qt1VF+mqagJ51IbAAUY=; b=V4DF7OKx+8wL8p1GrbTLeRRTeIvULoUQfgxb4GtHKbCmZzdMjuV8ZexS+NqdzlXODH qbYkgKT09XlCPUJ/avPnfhKMGkz4fZPqsKv4I34Y3bmKP6mWiqMLSJQMFW+gX/l0EcQG hjxhCzws3BaHdcLG6YNulRn4jO04lJrSbVXWkcI9Z9B4EEQJ7yeG/3gmBtM6fzLsoIHK YPHluiEPGrGCF4T+5zGsp0jEaK+3VZTV6q9oYCL2Fz/+mZ3QDJ82YsnkzSv8bctx1Sjq cAYrlGVPw3tGHK3gMJEAwc3TuqfUo0NF+tU4/HYgdELychHjPL2dHSQIMh5P55FFwyoM CFxA== X-Gm-Message-State: AO0yUKV1fKi2UPHz6Kc539VszsfqFnX60auqy5trzZRqCkXe+m3HFGvK wR404Sa+6kRu9TgiXXScDIsbZhHjviU= X-Google-Smtp-Source: AK7set9hI4WpTfinHmniGiBvx5mghdRr9a8iXiXXdwGMfGT7ZIOCMmJGN5cjSMJAOKkywpOEaF9zpw== X-Received: by 2002:a50:9ea2:0:b0:4ac:bbaa:867a with SMTP id a31-20020a509ea2000000b004acbbaa867amr7556802edf.24.1676300281111; Mon, 13 Feb 2023 06:58:01 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 02/10] x86/hvm: separate AMD-V and Intel VT-x hvm_function_table initializers Date: Mon, 13 Feb 2023 16:57:43 +0200 Message-Id: <20230213145751.1047236-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since start_svm() is AMD-V specific while start_vmx() is Intel VT-x specific, need to be guarded with AMD_SVM and INTEL_VMX, respectively. Instead of adding #ifdef guards around the function calls, implement them as static inline null-returning functions when the respective technology is not enabled. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/include/asm/hvm/hvm.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 43d3fc2498..353e48f4e3 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -261,8 +261,16 @@ extern struct hvm_function_table hvm_funcs; extern bool_t hvm_enabled; extern s8 hvm_port80_allowed; +#ifdef CONFIG_AMD_SVM extern const struct hvm_function_table *start_svm(void); +#else +static inline const struct hvm_function_table *start_svm(void) { return NULL; } +#endif +#ifdef CONFIG_INTEL_VMX extern const struct hvm_function_table *start_vmx(void); +#else +static inline const struct hvm_function_table *start_vmx(void) { return NULL; } +#endif int hvm_domain_initialise(struct domain *d, const struct xen_domctl_createdomain *config); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494605.764720 (Exim 4.92) (envelope-from ) id 1pRaHH-00012c-P0; Mon, 13 Feb 2023 14:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494605.764720; Mon, 13 Feb 2023 14:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHH-00012V-Kg; Mon, 13 Feb 2023 14:57:59 +0000 Received: by outflank-mailman (input) for mailman id 494605; Mon, 13 Feb 2023 14:57:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHG-00012P-6N for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:57:58 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd016c47-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:57:57 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id s11so5547936edd.10 for ; Mon, 13 Feb 2023 06:57:57 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:57:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd016c47-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pz7y6fakkviK8BUqb6LS14mzybL3uUwzelTkpr8P0S0=; b=N2maH1/mR97GVPsFJ7KnEBgVfdaufB93hYcPcQGoAXntHrOPNyNW5Vo/nAj84Fx8NJ 1MTFmb474/KQYDZk/UbtaEUJd74hV4ABhb+wM3gqk2ih5IrZSk7khTjpj16GJzqTIR0E rkcYNTMS7X/6uUuqrtmlyNr9RjLi9iEdBXrf2vXu2DaZ6w2ECp8wHNN0JmuYJ/480F1N dQMx42QC6y6UvVuqSNBTjC48sBb6XYYQgKlhigIjYiMvFTd7U2b8yYebbDYfrFkxxL8Q aY0NNXd914f2B08qGABRYeYSGpAYcSCV+iUAd+4emYNo1vB1rgFWLI73yGuxzlh3O0LA mY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pz7y6fakkviK8BUqb6LS14mzybL3uUwzelTkpr8P0S0=; b=0h4aYeZousE6yZcnTgYRfWc9e7JcwBMX9Sqgs+cbyHaocYut2F2fOSrlyqIjZ/tz/b BNkM8+8kz4sK10L1Jc/h3UJFT/9qaKHDoEuqUjIxXrhfIsyriH8OYMH9OFOWNfvidEVy W8Bm6L1vzkORJNonsemLUDC93zaoYaMQpM51S/2TDprLQ2EE7uyPjLWf/7Dh6a6Bx/hv BYiOqXJgrEbBUB2o9UEr+xxL8wt68QWA3hY42Ykt1zXuoWqwbYERpuFJnFlB0XYjXNxm jui/hSWkZgfyN5zQCccmX4b3q3xAHYI3OuZmsQptV0q5zBImkc2hkxx2noyKbGUr1qWe sh0g== X-Gm-Message-State: AO0yUKU5EtFo2PVWrkQ57+qEWUOzKg2LN7jJibvRci8ZCIK28627BcMQ kAiselUncCInTuKumQhpjby2aF86BpA= X-Google-Smtp-Source: AK7set/NFS9TNWlrQumydTYD6cBOz+GrHufuuGVeGixW6W4NwCWqCXuiF3pwerOEYw+9xBVEOq19Mw== X-Received: by 2002:a50:c31e:0:b0:4ab:4c5e:8828 with SMTP id a30-20020a50c31e000000b004ab4c5e8828mr11547045edb.37.1676300276498; Mon, 13 Feb 2023 06:57:56 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Paul Durrant , Jun Nakajima , Kevin Tian Subject: [RFC 00/10] x86: Make cpu virtualization support configurable Date: Mon, 13 Feb 2023 16:57:41 +0200 Message-Id: <20230213145751.1047236-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series aims to provide a means to render the cpu virtualization technology support in Xen configurable. Currently, irrespectively of the target platform, both AMD-V and Intel VT-x drivers are built. The series adds two new Kconfig controls, AMD_SVM and INTEL_VMX, that can be used to switch to a finer-grained configuration for a given platform, and reduce dead code. The code separation is done using the new config guards. The series is sent as an RFC to gather feedback in case the changes are in the wrong direction (I m mostly concerned about hap (ept/npt)) It depends on patch "x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback" (otherwise it won't compile with Intel VT-x support disabled) and on the series "Make x86 IOMMU driver support configurable" (AFAIU, the series has been reviewed but not merged yet) because Intel IOMMU depends on Intel VT-x for posted interrupts. Xenia Ragiadakou (10): x86: introduce AMD-V and Intel VT-x Kconfig options x86/hvm: separate AMD-V and Intel VT-x hvm_function_table initializers x86/p2m: guard vmx specific ept functions with INTEL_VMX x86/vpmu: separate AMD-V and Intel VT-x init arch_vpmu_ops initializers x86/traps: guard vmx specific functions with INTEL_VMX x86/domain: guard svm specific functions with AMD_SVM x86/oprofile: guard svm specific symbols with AMD_SVM x86: wire cpu_has_svm/vmx_* to false when svm/vmx not enabled x86/ioreq: guard VIO_realmode_completion with INTEL_VMX x86/hvm: make AMD-V and Intel VT-x support configurable xen/arch/x86/Kconfig | 20 ++++++++++++++ xen/arch/x86/cpu/Makefile | 4 ++- xen/arch/x86/domain.c | 4 +-- xen/arch/x86/hvm/Makefile | 4 +-- xen/arch/x86/hvm/ioreq.c | 2 ++ xen/arch/x86/include/asm/hvm/hvm.h | 8 ++++++ xen/arch/x86/include/asm/hvm/svm/svm.h | 17 ++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 35 +++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 18 +++++++++++++ xen/arch/x86/include/asm/vpmu.h | 9 +++++++ xen/arch/x86/mm/Makefile | 3 ++- xen/arch/x86/mm/hap/Makefile | 2 +- xen/arch/x86/mm/p2m.h | 16 +++++++++++ xen/arch/x86/oprofile/op_model_athlon.c | 2 +- xen/arch/x86/traps.c | 4 +-- xen/drivers/passthrough/Kconfig | 2 +- 16 files changed, 139 insertions(+), 11 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494607.764735 (Exim 4.92) (envelope-from ) id 1pRaHM-0001LF-An; Mon, 13 Feb 2023 14:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494607.764735; Mon, 13 Feb 2023 14:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHM-0001KR-4Z; Mon, 13 Feb 2023 14:58:04 +0000 Received: by outflank-mailman (input) for mailman id 494607; Mon, 13 Feb 2023 14:58:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHK-0001Ha-Qm for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:02 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ceaf1c9c-abae-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:58:00 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id eq11so13271083edb.6 for ; Mon, 13 Feb 2023 06:57:59 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:57:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceaf1c9c-abae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ADMJRcoEAWm10JX/p9S3CdQyxMC2w4XTtFoR/0gxu3M=; b=X1lGJBJhbDa/titkYOtiVh/LdtY8RONmn7XhmMApll5t74Nm5DTuN5PfrNMKOS3IBD OX5GmHus4G6QcuxoL4EtKl+0OuKMx4x1KxOcYRQu9HSpOVE05YAMg5dd1w866lxLW/64 IivBSvMpb/HOJcc78xLpttA03H0nHBxF4MXqsLNzVW4Bd82JcPZ1R6AQD3VUnwiyAGYM kiu1vhwmBxDWsL4thVzG0f6uaDQW8xUEbII3NiST44OfyAoOl1ADGBpPVCWmBUC5h387 Tq1dqKaMwWxSP3AcCI5L+vu50NBx5PYDQQOBEnTtjzQIkHBBU5oV+2XZme+6lTDWoEgj GHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADMJRcoEAWm10JX/p9S3CdQyxMC2w4XTtFoR/0gxu3M=; b=oU09j0XWtg4z9U03w1X/WiAB2wr3uQ9SO2phmCmtN3lzLrr6WN3nSTPBtDKoM/GBAh zNwvNQz8u/9VXFeEClBBHVlwGwVB3KyKPqR3IOtJtzyw+DR0J0GnwPQNppMpLe/xy40h stxiYL8OnORJfzr+/nSpFvUHaVTiRNvTsi8/2hxmWDAACaGTnfLfjDIi3N1+QNr8hSxo e2sPmphWLB6DNkQ0dra7rLDs3gvxy8zvA0IGfuLPqacK7yEmwLxGzf2XBUf+BgYg3gyG Ox5C1NEmYsG99FMGssw8jI39NHrugQ+bLsUnp/2g7bk4A1R18Qoe/AhN7DjPkUIPtJKJ Mb8Q== X-Gm-Message-State: AO0yUKXi0depnXSR5dQ+kIeSvtwOljtPRT5x1PHQtSVou+MHEsLrZkpo 6cb+qyR8hoh90u24F7x96c2Jzq0V3g8= X-Google-Smtp-Source: AK7set9UsZcVfGy81UB7eVU5IdMA6J8v5r9Aj7wABPQloH0Ui0vkXBWyinmWtBM20hhv/+XKmmOtxA== X-Received: by 2002:a50:d70f:0:b0:4ac:b619:80d5 with SMTP id t15-20020a50d70f000000b004acb61980d5mr8494122edi.2.1676300279322; Mon, 13 Feb 2023 06:57:59 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Paul Durrant Subject: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options Date: Mon, 13 Feb 2023 16:57:42 +0200 Message-Id: <20230213145751.1047236-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce two new Kconfig options, AMD_SVM and INTEL_VMX, to allow code specific to each virtualization technology to be separated and, when not required, stripped. AMD_SVM will be used to enable virtual machine extensions on platforms that implement the AMD Virtualization Technology (AMD-V). INTEL_VMX will be used to enable virtual machine extensions on platforms that implement the Intel Virtualization Technology (Intel VT-x). Both features depend on HVM support. Since, at this point, disabling any of them would cause Xen to not compile, the options are enabled by default if HVM and are not selectable by the user. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/Kconfig | 6 ++++++ xen/arch/x86/cpu/Makefile | 4 +++- xen/arch/x86/hvm/Makefile | 4 ++-- xen/arch/x86/mm/Makefile | 3 ++- xen/arch/x86/mm/hap/Makefile | 2 +- xen/drivers/passthrough/Kconfig | 2 +- 6 files changed, 15 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba..2a72111c23 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -117,6 +117,12 @@ config HVM If unsure, say Y. +config AMD_SVM + def_bool y if HVM + +config INTEL_VMX + def_bool y if HVM + config XEN_SHSTK bool "Supervisor Shadow Stacks" depends on HAS_AS_CET_SS diff --git a/xen/arch/x86/cpu/Makefile b/xen/arch/x86/cpu/Makefile index 35561fe51d..08bdf4abb8 100644 --- a/xen/arch/x86/cpu/Makefile +++ b/xen/arch/x86/cpu/Makefile @@ -10,4 +10,6 @@ obj-y += intel.o obj-y += intel_cacheinfo.o obj-y += mwait-idle.o obj-y += shanghai.o -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o +obj-y += vpmu.o +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o diff --git a/xen/arch/x86/hvm/Makefile b/xen/arch/x86/hvm/Makefile index 3464191544..4c1fa5c6c2 100644 --- a/xen/arch/x86/hvm/Makefile +++ b/xen/arch/x86/hvm/Makefile @@ -1,5 +1,5 @@ -obj-y += svm/ -obj-y += vmx/ +obj-$(CONFIG_AMD_SVM) += svm/ +obj-$(CONFIG_INTEL_VMX) += vmx/ obj-y += viridian/ obj-y += asid.o diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile index 0803ac9297..c53c94308a 100644 --- a/xen/arch/x86/mm/Makefile +++ b/xen/arch/x86/mm/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_MEM_SHARING) += mem_sharing.o obj-$(CONFIG_HVM) += nested.o obj-$(CONFIG_HVM) += p2m.o obj-y += p2m-basic.o -obj-$(CONFIG_HVM) += p2m-ept.o p2m-pod.o p2m-pt.o +obj-$(CONFIG_HVM) += p2m-pod.o p2m-pt.o +obj-$(CONFIG_INTEL_VMX) += p2m-ept.o obj-y += paging.o obj-y += physmap.o diff --git a/xen/arch/x86/mm/hap/Makefile b/xen/arch/x86/mm/hap/Makefile index 8ef54b1faa..67c29b2162 100644 --- a/xen/arch/x86/mm/hap/Makefile +++ b/xen/arch/x86/mm/hap/Makefile @@ -3,4 +3,4 @@ obj-y += guest_walk_2.o obj-y += guest_walk_3.o obj-y += guest_walk_4.o obj-y += nested_hap.o -obj-y += nested_ept.o +obj-$(CONFIG_INTEL_VMX) += nested_ept.o diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index 864fcf3b0c..f95e7e5902 100644 --- a/xen/drivers/passthrough/Kconfig +++ b/xen/drivers/passthrough/Kconfig @@ -51,7 +51,7 @@ config AMD_IOMMU config INTEL_IOMMU bool "Intel VT-d" if EXPERT - depends on X86 + depends on X86 && INTEL_VMX default y help Enables I/O virtualization on platforms that implement the -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494610.764773 (Exim 4.92) (envelope-from ) id 1pRaHR-0002Om-Bq; Mon, 13 Feb 2023 14:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494610.764773; Mon, 13 Feb 2023 14:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHR-0002OT-8O; Mon, 13 Feb 2023 14:58:09 +0000 Received: by outflank-mailman (input) for mailman id 494610; Mon, 13 Feb 2023 14:58:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHP-00012P-AL for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:07 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d2d8dd28-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:58:07 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id cq19so10543156edb.5 for ; Mon, 13 Feb 2023 06:58:06 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2d8dd28-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U5v/N22n2LqrdW7DqMvxVswsNGoZiD6T9tF2GDu61pk=; b=idPIyCoiAFOpr5KMigzgO35lMseihPsh34sqaciuVp5Ygz9GLa7eWZonWDYfOCrxAB re2+zBMqX9MiMvnygNeaBpZEzON46mN3PH1gZ6OxBrf+QhyHdaS68SRvmlYgXx1j3P8x r49v//ABzPD4Pg/N50IMvXwTocp7/nlHqFR6KGf7ymZ4aANcKw6pSnzkLs4liqLTW97/ MEtHTz0R+nvbw5NeNPVAobkgLQbsLh0NOUR6g92dk56bJriOT4PUpzTtb8j8lMbAm62E kkaUxlxtd+/c287k5fzOj6VepT8YAlGGsUZBA1SD5Nu8gBrKV28rMcnUJdTTUTe3QI9O VPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U5v/N22n2LqrdW7DqMvxVswsNGoZiD6T9tF2GDu61pk=; b=sJM2SfcY7fj1CDlPTI2slfuoGfU9HBiBJzhtOQnTClF+8kpTuQ/DobKRHVF04JDjph yxooVRbk2fxq1f/LDzYOpNKvDBLpsQXAsrwaQCTb1o82FxwiqR8YaUGEEOeAsD6Qj5TI A1g0W5pIQi12dffY/gbxT2VUM6kLxlocvIRSJkJwAzXXBKdCgPIbbswrx393E3FVZ5QD 1v7NawJSmqQIcjfK7suHIW2JUi1M7gPOjAI1iyDuLfZmSFVMTqf/o1vGBYtgIz0DVIZ1 CQr+u4Jjih1K1zQ22rTzaUm2oZfxDuCsQNFd82urZqkZYgVqrdbMfgMZO6Tp9BTK2Ul8 o80g== X-Gm-Message-State: AO0yUKXeoBgOHRFrmSIEVfj7GIiTLWjp7sEFGTkFBanOV/xk73bFCLX+ I0cuGqulNUerPoTy6BbE1hbPvIHYkUQ= X-Google-Smtp-Source: AK7set+oN4N2dbUMeM0v4BVjErq8kcyFD7IfbCxSH+ypx9T+wfJHOSIhZukL+SrLDTQe0dn6y3ij+Q== X-Received: by 2002:a50:cd48:0:b0:47e:eaae:9a69 with SMTP id d8-20020a50cd48000000b0047eeaae9a69mr25788468edj.41.1676300286331; Mon, 13 Feb 2023 06:58:06 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 05/10] x86/traps: guard vmx specific functions with INTEL_VMX Date: Mon, 13 Feb 2023 16:57:46 +0200 Message-Id: <20230213145751.1047236-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions vmx_vmcs_enter() and vmx_vmcs_exit() are VT-x specific. Guard their calls with INTEL_VMX. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/traps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8..77b4f772f2 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -694,7 +694,7 @@ void vcpu_show_execution_state(struct vcpu *v) vcpu_pause(v); /* acceptably dangerous */ -#ifdef CONFIG_HVM +#ifdef CONFIG_INTEL_VMX /* * For VMX special care is needed: Reading some of the register state will * require VMCS accesses. Engaging foreign VMCSes involves acquiring of a @@ -732,7 +732,7 @@ void vcpu_show_execution_state(struct vcpu *v) console_unlock_recursive_irqrestore(flags); } -#ifdef CONFIG_HVM +#ifdef CONFIG_INTEL_VMX if ( cpu_has_vmx && is_hvm_vcpu(v) ) vmx_vmcs_exit(v); #endif -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494611.764785 (Exim 4.92) (envelope-from ) id 1pRaHT-0002jf-Nd; Mon, 13 Feb 2023 14:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494611.764785; Mon, 13 Feb 2023 14:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHT-0002jX-Js; Mon, 13 Feb 2023 14:58:11 +0000 Received: by outflank-mailman (input) for mailman id 494611; Mon, 13 Feb 2023 14:58:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHS-0001Ha-3d for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:10 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3c4ce85-abae-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:58:08 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id fj20so13307858edb.1 for ; Mon, 13 Feb 2023 06:58:08 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3c4ce85-abae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ysij/ro07c0+TJWrYCtfS1joxXIrIyAx6s1ZIXpyeE=; b=FTblwDg1zWMM5BWbt/RyBbkeX6ZNWCNhXCIr31OBqIsdO403hTub6k4ryOSHp4apJ9 1Q1n8OeNkZxFyfI+A16rDQROCTh673T/AnBLay8tifziYwmZwNaXghuxzzb7tkUpGw+L 2f09xIlOSdLF5jmY681wVvoFdPPJOERENu1jYpwWphmsv+RL77liwbRpiaHwMJsxYBzD t3HCxHiLCwm1sceFOFNgbxQfndZZLoLfGecFd15iGrG59zHot3MXi4mVUN3BGDKoCT8P plOkEACe8phLE3lyGbIM9nAEEhxWfL1SqmrHmKl3NjLVk4UcTi1P7QvJczp944GDoJO0 FSzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ysij/ro07c0+TJWrYCtfS1joxXIrIyAx6s1ZIXpyeE=; b=hAfNhwTPcdv7J2i56jIEDQMzXX96vffVLw+aYLaVOIDVJRPrZ+VVeP2Oub0LDqFd1E 75YvzOw7SRMYjbdyfepwunQZMh/2+3RrujvkZe3f5Z2nV48VKqqQ0SqIeI5QERV6i/vo 69GIv6PGkaulF0CNfnJTPR8sn8rBzuRyr416x+ojY2mrmI1y1z0mE9EZ3yt+9UsUTSrL 27YoWvm1zqhzle8g0zwVsyrf9e+udQSkWWizIOBQ7z7RsZb/gyeqpzg0rh4paxC0B/8A RIFMK5k7zflLguW2QjyB87m+UYShG9JGh5WJkaiC6kr4qJv75w+gYdCBhB4LrJ0a8kBX LDmg== X-Gm-Message-State: AO0yUKWNQ10Mmt8eXTiTAjXw1OB0MgLzLsU6OTZcxv7M9jVN7oe8QveE SE5+RWmFfPdH2FyLt7RLUn3J+yKkJck= X-Google-Smtp-Source: AK7set+GkQzuNUROaeZkqPhJFMYN6bRqV/h4LSzc3WsL+gk+OfUAqC1YutzN7Qknx+IQLfp3UmAd+w== X-Received: by 2002:a50:a681:0:b0:4ac:c123:cd8f with SMTP id e1-20020a50a681000000b004acc123cd8fmr5228426edc.11.1676300287974; Mon, 13 Feb 2023 06:58:07 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 06/10] x86/domain: guard svm specific functions with AMD_SVM Date: Mon, 13 Feb 2023 16:57:47 +0200 Message-Id: <20230213145751.1047236-7-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions svm_load_segs() and svm_load_segs_prefetch() are AMD-V specific so guard their calls in common code with AMD_SVM. Since AMD_SVM depends on HVM, it can be used alone. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index db3ebf062d..576a410f4f 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1628,7 +1628,7 @@ static void load_segments(struct vcpu *n) if ( !(n->arch.flags & TF_kernel_mode) ) SWAP(gsb, gss); -#ifdef CONFIG_HVM +#ifdef CONFIG_AMD_SVM if ( cpu_has_svm && (uregs->fs | uregs->gs) <= 3 ) fs_gs_done = svm_load_segs(n->arch.pv.ldt_ents, LDT_VIRT_START(n), n->arch.pv.fs_base, gsb, gss); @@ -1951,7 +1951,7 @@ static void __context_switch(void) write_ptbase(n); -#if defined(CONFIG_PV) && defined(CONFIG_HVM) +#if defined(CONFIG_PV) && defined(CONFIG_AMD_SVM) /* Prefetch the VMCB if we expect to use it later in the context switch */ if ( cpu_has_svm && is_pv_64bit_domain(nd) && !is_idle_domain(nd) ) svm_load_segs_prefetch(); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494612.764791 (Exim 4.92) (envelope-from ) id 1pRaHU-0002nj-9c; Mon, 13 Feb 2023 14:58:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494612.764791; Mon, 13 Feb 2023 14:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHT-0002mt-VU; Mon, 13 Feb 2023 14:58:11 +0000 Received: by outflank-mailman (input) for mailman id 494612; Mon, 13 Feb 2023 14:58:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHS-00012P-K0 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:10 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4d22d39-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:58:10 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id dz21so1248919edb.13 for ; Mon, 13 Feb 2023 06:58:10 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4d22d39-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uTOuRMzovcu9U8yHdgtcg1aC/lNK90HeqMCP2DHSHtQ=; b=Uhk4AJdyUbsybuROvfNH7szECAyg6hEOSh/H07XBFIwbnYN6q6PxvBa6FQiCoot/MO VEM/q9LQtmW6uhQeHAALxuWc1w0fBsOCEWYU8iiZu1/gs4jaR5bVl7XfxnG1E2S1RM8/ Xg1BYvAS1CxV9tITTRaWtGZHy8C2GSRTu4ILaTWIPQmbbo5JTggo++dWJOemx72etxTK jRTKnaL5+1UOXBbTVD+fqN2tgUhz4VM8PT0HYp2pv9LBwq76+wYnSdUOLm/zgDVjyBEK Pm3DtKO6QhdHT8hRlNhYYfbGwgQDlMuDCwe/zZAM9SSs2f8GgpPQhi4lZssgPqJDI4LA fkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uTOuRMzovcu9U8yHdgtcg1aC/lNK90HeqMCP2DHSHtQ=; b=hcYQiLXBz/aSBMpeFmWsXAuioN2ld5NvMiYM4pHnweI5ForoKDGyk0KoNijajFJ3UC bN3BzlBBxzjd9s56J/3msGGtrljiA2057Q8912Hs0/uPDNZxJdaEUSl7Ewp+X33MKEZo 4PC/mhTidy4M2H12hH0NYuCWbYMXYcWA+KhDpNoHAbIsuBq3NQEmiAlvZ9cnagvEFHLT XVUMGMh7yxrrB17gcG+d6fbBwPqk7+dB6SM342On3znb3yUoiThtgBnpliSU4FUlQG1w qOrvUxphyuCUrIPgOR2oZHn+Xny/tG7o5RG4K1yzC+SVyaMtZEovarJ/3fazbg36ojuR UTQg== X-Gm-Message-State: AO0yUKX934p0U1V73HdMvLHkEeIgplpwVi2pXzAjyPmTsDW9qtdQVZ0G 0UfnSvYNVYOvB0n3yNZDRuEGWY15hGA= X-Google-Smtp-Source: AK7set9hXBu2M70GkVjxBxm3e15BzI8avJlnuyZR2dQq6aszC7C4QNGHdcTvn/vrdCT7HnC9og3zOQ== X-Received: by 2002:a50:d69b:0:b0:4ac:b866:7ebb with SMTP id r27-20020a50d69b000000b004acb8667ebbmr7971508edi.9.1676300289730; Mon, 13 Feb 2023 06:58:09 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 07/10] x86/oprofile: guard svm specific symbols with AMD_SVM Date: Mon, 13 Feb 2023 16:57:48 +0200 Message-Id: <20230213145751.1047236-8-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The symbol svm_stgi_label is AMD-V specific so guard its usage in common code with AMD_SVM. Since AMD_SVM depends on HVM, it can be used alone. Also, use #ifdef instead of #if. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/oprofile/op_model_athlon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/oprofile/op_model_athlon.c b/xen/arch/x86/oprofile/op_model_athlon.c index 69fd3fcc86..782fa606ee 100644 --- a/xen/arch/x86/oprofile/op_model_athlon.c +++ b/xen/arch/x86/oprofile/op_model_athlon.c @@ -320,7 +320,7 @@ static int cf_check athlon_check_ctrs( struct vcpu *v = current; unsigned int const nr_ctrs = model->num_counters; -#if CONFIG_HVM +#ifdef CONFIG_AMD_SVM struct cpu_user_regs *guest_regs = guest_cpu_user_regs(); if (!guest_mode(regs) && -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494615.764807 (Exim 4.92) (envelope-from ) id 1pRaHW-0003Qi-S6; Mon, 13 Feb 2023 14:58:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494615.764807; Mon, 13 Feb 2023 14:58:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHW-0003QU-KK; Mon, 13 Feb 2023 14:58:14 +0000 Received: by outflank-mailman (input) for mailman id 494615; Mon, 13 Feb 2023 14:58:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHV-0001Ha-Mj for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:13 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d5e0b7d7-abae-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:58:12 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id a10so13250838edu.9 for ; Mon, 13 Feb 2023 06:58:12 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5e0b7d7-abae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MvIoc5bBDL+U3AaRn4Z94l9PVnkFFMdQ2k/Ww5bMv0w=; b=JdMx4mznZ0/8VCrN7/smpGbxw2TcphyETjng1zV9KYbGGVRaESxC+YVH+QLmKMcwkv 2x1zLE9zM4IT0SWlFQ6Lb9FxMlcrKtVKs3cSonckkza7fuawSuWmc6ffbFng1eYmgF/3 oecTjTmqv8krRF4saVRHxKikfhJE5fS4x5nBYGkp5CanYufUBDBOsYtivWp0Psx/uTgw q0qeAiRaFjv7P3vikuPmM06m0Rvk2Y2D3Zq+02s915L6Yw7ZMmS4A9/CkHK9GiC8leZU HQDLeeRMtPjgj9TE6wt1LQVRLTL0QLaiu/fFgob9fFsTXNhE7utpMuIhPyd3CJp5hp8W BP8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MvIoc5bBDL+U3AaRn4Z94l9PVnkFFMdQ2k/Ww5bMv0w=; b=54i7I8seBsriLBhwm0qAjM5T64YLYjFSmXoZRpK1g8wvZZwVxYirlJYw0MRL/8JHDE k/hR001axfNJqlTfrRK+KemXVu83aBstY/mQTqChMKXyalL4LxFkCEBg/dAEKHizxK/J DvoP4ufOAGrgMiUH0Z2DWtdDODEFjiNfYvMZkuK+M8IDjIycgZLwltpxxVAfS6YfDTCM fKiwQ40QVs1OyUbLo3J5EF8iXvYKy3UAox53gWRB5AcS3wbD6cmvBVxrSA6uoZKriD0R 80T4CC5b5szMNw+GIoOTSDcUgN9ftQTEEwKRS4oSDk1GJgBC3G2Pv5j0vLQ6Ck0gNsYA idag== X-Gm-Message-State: AO0yUKWQWc7zC37oOGRnRSpEbLjphbNTphEFdncl4whExHYnVwXSXh3Y BPTOvQVf5Y5SWw8LE2tna2H2IPhUWUg= X-Google-Smtp-Source: AK7set9ISVZ/9+WhCVxmbwk/PEEwSzL7YpdteuK90ToMhP7WfzgjriLjNFMIjhZGZ5oqPZO1Z0CoMQ== X-Received: by 2002:a50:8d1e:0:b0:4ac:c426:6b4a with SMTP id s30-20020a508d1e000000b004acc4266b4amr4832781eds.36.1676300291502; Mon, 13 Feb 2023 06:58:11 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [RFC 08/10] x86: wire cpu_has_svm/vmx_* to false when svm/vmx not enabled Date: Mon, 13 Feb 2023 16:57:49 +0200 Message-Id: <20230213145751.1047236-9-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To be able to use cpu_has_svm/vmx_* macros in common code without enclosing them inside #ifdef guards when the respective virtualization technology is not enabled, define them as false when not applicable. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/include/asm/hvm/svm/svm.h | 17 ++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 35 +++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 18 +++++++++++++ 3 files changed, 70 insertions(+) diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59..556584851b 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -80,6 +80,7 @@ extern u32 svm_feature_flags; #define SVM_FEATURE_SSS 19 /* NPT Supervisor Shadow Stacks */ #define SVM_FEATURE_SPEC_CTRL 20 /* MSR_SPEC_CTRL virtualisation */ +#ifdef CONFIG_AMD_SVM #define cpu_has_svm_feature(f) (svm_feature_flags & (1u << (f))) #define cpu_has_svm_npt cpu_has_svm_feature(SVM_FEATURE_NPT) #define cpu_has_svm_lbrv cpu_has_svm_feature(SVM_FEATURE_LBRV) @@ -95,6 +96,22 @@ extern u32 svm_feature_flags; #define cpu_has_svm_vloadsave cpu_has_svm_feature(SVM_FEATURE_VLOADSAVE) #define cpu_has_svm_sss cpu_has_svm_feature(SVM_FEATURE_SSS) #define cpu_has_svm_spec_ctrl cpu_has_svm_feature(SVM_FEATURE_SPEC_CTRL) +#else +#define cpu_has_svm_npt false +#define cpu_has_svm_lbrv false +#define cpu_has_svm_svml false +#define cpu_has_svm_nrips false +#define cpu_has_svm_cleanbits false +#define cpu_has_svm_flushbyasid false +#define cpu_has_svm_decode false +#define cpu_has_svm_vgif false +#define cpu_has_pause_filter false +#define cpu_has_pause_thresh false +#define cpu_has_tsc_ratio false +#define cpu_has_svm_vloadsave false +#define cpu_has_svm_sss false +#define cpu_has_svm_spec_ctrl false +#endif /* CONFIG_AMD_SVM */ #define SVM_PAUSEFILTER_INIT 4000 #define SVM_PAUSETHRESH_INIT 1000 diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e74478..03d1f7480a 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -294,6 +294,7 @@ extern u64 vmx_ept_vpid_cap; #define VMX_TSC_MULTIPLIER_MAX 0xffffffffffffffffULL +#ifdef CONFIG_INTEL_VMX #define cpu_has_wbinvd_exiting \ (vmx_secondary_exec_control & SECONDARY_EXEC_WBINVD_EXITING) #define cpu_has_vmx_virtualize_apic_accesses \ @@ -352,6 +353,36 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) #define cpu_has_vmx_notify_vm_exiting \ (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) +#else +#define cpu_has_wbinvd_exiting false +#define cpu_has_vmx_virtualize_apic_accesses false +#define cpu_has_vmx_tpr_shadow false +#define cpu_has_vmx_vnmi false +#define cpu_has_vmx_msr_bitmap false +#define cpu_has_vmx_secondary_exec_control false +#define cpu_has_vmx_ept false +#define cpu_has_vmx_dt_exiting false +#define cpu_has_vmx_vpid false +#define cpu_has_monitor_trap_flag false +#define cpu_has_vmx_pat false +#define cpu_has_vmx_efer false +#define cpu_has_vmx_unrestricted_guest false +#define vmx_unrestricted_guest(v) false +#define cpu_has_vmx_ple false +#define cpu_has_vmx_apic_reg_virt false +#define cpu_has_vmx_virtual_intr_delivery false +#define cpu_has_vmx_virtualize_x2apic_mode false +#define cpu_has_vmx_posted_intr_processing false +#define cpu_has_vmx_vmcs_shadowing false +#define cpu_has_vmx_vmfunc false +#define cpu_has_vmx_virt_exceptions false +#define cpu_has_vmx_pml false +#define cpu_has_vmx_mpx false +#define cpu_has_vmx_xsaves false +#define cpu_has_vmx_tsc_scaling false +#define cpu_has_vmx_bus_lock_detection false +#define cpu_has_vmx_notify_vm_exiting false +#endif /* CONFIG_INTEL_VMX */ #define VMCS_RID_TYPE_MASK 0x80000000 @@ -374,8 +405,12 @@ extern u64 vmx_ept_vpid_cap; #define VMX_BASIC_DEFAULT1_ZERO (1ULL << 55) extern u64 vmx_basic_msr; +#ifdef CONFIG_INTEL_VMX #define cpu_has_vmx_ins_outs_instr_info \ (!!(vmx_basic_msr & VMX_BASIC_INS_OUT_INFO)) +#else +#define cpu_has_vmx_ins_outs_instr_info false +#endif /* CONFIG_INTEL_VMX */ /* Guest interrupt status */ #define VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK 0x0FF diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 97d6b810ec..fe9a5796f7 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -289,6 +289,7 @@ typedef union cr_access_qual { extern uint8_t posted_intr_vector; +#ifdef CONFIG_INTEL_VMX #define cpu_has_vmx_ept_exec_only_supported \ (vmx_ept_vpid_cap & VMX_EPT_EXEC_ONLY_SUPPORTED) @@ -301,6 +302,17 @@ extern uint8_t posted_intr_vector; #define cpu_has_vmx_ept_ad (vmx_ept_vpid_cap & VMX_EPT_AD_BIT) #define cpu_has_vmx_ept_invept_single_context \ (vmx_ept_vpid_cap & VMX_EPT_INVEPT_SINGLE_CONTEXT) +#else +#define cpu_has_vmx_ept_exec_only_supported false + +#define cpu_has_vmx_ept_wl4_supported false +#define cpu_has_vmx_ept_mt_uc false +#define cpu_has_vmx_ept_mt_wb false +#define cpu_has_vmx_ept_2mb false +#define cpu_has_vmx_ept_1gb false +#define cpu_has_vmx_ept_ad false +#define cpu_has_vmx_ept_invept_single_context false +#endif /* CONFIG_INTEL_VMX */ #define EPT_2MB_SHIFT 16 #define EPT_1GB_SHIFT 17 @@ -310,12 +322,18 @@ extern uint8_t posted_intr_vector; #define INVEPT_SINGLE_CONTEXT 1 #define INVEPT_ALL_CONTEXT 2 +#ifdef CONFIG_INTEL_VMX #define cpu_has_vmx_vpid_invvpid_individual_addr \ (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) #define cpu_has_vmx_vpid_invvpid_single_context \ (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT) #define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) +#else +#define cpu_has_vmx_vpid_invvpid_individual_addr false +#define cpu_has_vmx_vpid_invvpid_single_context false +#define cpu_has_vmx_vpid_invvpid_single_context_retaining_global false +#endif /* CONFIG_INTEL_VMX */ #define INVVPID_INDIVIDUAL_ADDR 0 #define INVVPID_SINGLE_CONTEXT 1 -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494617.764818 (Exim 4.92) (envelope-from ) id 1pRaHY-0003jw-GL; Mon, 13 Feb 2023 14:58:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494617.764818; Mon, 13 Feb 2023 14:58:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHY-0003io-4d; Mon, 13 Feb 2023 14:58:16 +0000 Received: by outflank-mailman (input) for mailman id 494617; Mon, 13 Feb 2023 14:58:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHW-00012P-Lk for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:14 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6ef06c8-abae-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 15:58:13 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id s11so5549253edd.10 for ; Mon, 13 Feb 2023 06:58:13 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6ef06c8-abae-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jy9MxG42u4Nv2Kmf3LwoFoiWXt3O4JC+9pElyhn6lpo=; b=g1GhuG7H3AgAo9I6Y1zdnMtEETZeI+HeHhmx99n/fL0O5qNoMAKeKwh7SzcG5XeR80 ueYyHZx+ACWlx/FAa0jzJszlhNfrp61mgSapkQQgmQquZd8d33yBWw/twVDeBygdT4bf aS5MwAz1Y0l+gsOX5QzNWbtghjofy5Y549nK+mJHghFjnaUj4KMid5fjGgiHNBPMdfMa G4rk9LtJfht9pgMmF5KaMh+9c4kDqdn79hP/cYG691ES2z3XN4U7Fcc5fVUkAnfdmepL /2sPbV3otOOKGJWF2bFi8zP7sfXIzUhlm/fz6yrFyXyqHMFlAxyVtVOkJppDRkptfvyL 2XXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jy9MxG42u4Nv2Kmf3LwoFoiWXt3O4JC+9pElyhn6lpo=; b=6bBm3S6JgWzMgFtK6hj/ktk8+NsX+mxmz/SYuDjJ118NNQ5umFdvxLozS1Q8E+pmLD 4kgbIdMo8yUIQr225gVREQeJRNfKE6sDyrXdLD+IDR0wBGloOZz2kO9M434j4/rjiGTf S6bBmjwXOYafzo7h3F3zXsfN2gghFxC5xdpAakfEos97ScEiGCPpf+wfGp9kpMmNDqCP UrfcEcCVXWEm+0PBZi2sA1R8OYjpZJXaeVJI4u7CjkYYyuRzbRoIF5ZWKqMOOpJ9f4j9 uwOByv7yX2Lf6t9zI4TiFeMXi7FEboSW2ZsPJxrq5fmKQQ0PahytwZoRDWam4SwsonDu RNOg== X-Gm-Message-State: AO0yUKV4CabVj+Ab0hvys1tZyCkZVoVhGrRX8s/NXnxe7yJB72X4i/BZ DcdGtKVo1XhlG6z88qFCyXqUnHlb+HU= X-Google-Smtp-Source: AK7set/sApjHPPTP1O6/z1JAvOV1iMnOSIJgco5nBsKflB+rmX5HgDRq3yl+57+4mm7+OY4MuOWzww== X-Received: by 2002:a50:874a:0:b0:4ab:f6c:1a47 with SMTP id 10-20020a50874a000000b004ab0f6c1a47mr19075094edv.31.1676300293281; Mon, 13 Feb 2023 06:58:13 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 09/10] x86/ioreq: guard VIO_realmode_completion with INTEL_VMX Date: Mon, 13 Feb 2023 16:57:50 +0200 Message-Id: <20230213145751.1047236-10-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit VIO_realmode_completion is specific to vmx realmode, so guard the completion handling code with INTEL_VMX. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/ioreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c index 0bdcca1e1a..1b0c0f1b12 100644 --- a/xen/arch/x86/hvm/ioreq.c +++ b/xen/arch/x86/hvm/ioreq.c @@ -44,6 +44,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) { switch ( completion ) { +#ifdef CONFIG_INTEL_VMX case VIO_realmode_completion: { struct hvm_emulate_ctxt ctxt; @@ -54,6 +55,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) break; } +#endif default: ASSERT_UNREACHABLE(); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 14:58:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 14:58:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494621.764829 (Exim 4.92) (envelope-from ) id 1pRaHa-0004Mh-Qq; Mon, 13 Feb 2023 14:58:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494621.764829; Mon, 13 Feb 2023 14:58:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHa-0004MP-JG; Mon, 13 Feb 2023 14:58:18 +0000 Received: by outflank-mailman (input) for mailman id 494621; Mon, 13 Feb 2023 14:58:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaHY-0001Ha-Vn for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 14:58:17 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7fe0c09-abae-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 15:58:15 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id eq11so13272291edb.6 for ; Mon, 13 Feb 2023 06:58:15 -0800 (PST) Received: from uni.router.wind (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.googlemail.com with ESMTPSA id v1-20020a50a441000000b004aab66d34c7sm6787617edb.7.2023.02.13.06.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:58:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7fe0c09-abae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z4XxNzz7rqsriFu3pt/xtkLxxWkI8GAzMmbRJ9k+P3k=; b=LIVU7Nn9rKw1Sx2lMV6AQsc501lDTNYf4YUZT8T+RQe3HEnEcWlUAkLkCDBPHdyeSn XSYCHC2ioaJPSJBc9pmsL4o4K9FZBIOKyLkM+ScNiB2zZEifYfYubSp1CnZJGEdhwE6x PHhKCUpimVfjTaqgC101oXU7Im8XBkpB4N8GxkE9RsIvnkNhzgp+nD1yLT2wWwD7jvqj o6LRjEXXX8Qw1wVsBF/nMyLFE6X4ngRMNvQJ9U4AEaUZ3NA4QZjiCId7fNHfCavXhEWm aqdlxa7HOc8BCSlnKFYsicDqhdiUQAVxRU7nnmyfSja0TYVaUVx6q/crAORjbImsbOWF dYOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z4XxNzz7rqsriFu3pt/xtkLxxWkI8GAzMmbRJ9k+P3k=; b=RTHCgql5+CuBdg8LBKmmeiPQeOiuEGakkJluYntETneh5YBkzxlPoWB97cBKrWizf6 PKqyA0oE/9coMAUCKcTWHvE/VYr2KXk4lOiUTriei+ltK8K67w2Bo/Jmp26FA3IRqcR2 o35djpte9YEY4jVmoDkhovnU2t+a4mH+BCMThysTP0TYfLQTFN5ZZNmPxuDqrRv+V6Ft YAaAGTDb/looVP3W5gXmtLP1BT+sXyG1tAg1DuC6mDSvkTsg2yUDWk6mcM9+YLHMdCaP dh91JrHB2YH6lFI8G5jk/hRSCPB7AfN5v27dz2eOVbgmw1Oh1J4DWWnqEPujdySmFq7z STqw== X-Gm-Message-State: AO0yUKX4PSsLK1nMcYDMEQvxOx1LYHiOSACou3GNhHFDMJQ9GugjRAtK GdWdiowsdimlqMmDUAgewqXdnM/xTIY= X-Google-Smtp-Source: AK7set+qOVFZEYPqf6090xY3A1jG/4TWdiNMUokFCls7wZJZ0YWyYbbwmfdRqnyNYh17MWf/omyhwg== X-Received: by 2002:a50:8705:0:b0:4ab:4569:4b9f with SMTP id i5-20020a508705000000b004ab45694b9fmr10836818edb.0.1676300294999; Mon, 13 Feb 2023 06:58:14 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [RFC 10/10] x86/hvm: make AMD-V and Intel VT-x support configurable Date: Mon, 13 Feb 2023 16:57:51 +0200 Message-Id: <20230213145751.1047236-11-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230213145751.1047236-1-burzalodowa@gmail.com> References: <20230213145751.1047236-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Provide the user with configuration control over the cpu virtualization support in Xen by making AMD_SVM and INTEL_VMX options user selectable. To preserve the current default behavior, both options depend on HVM and default to Y. To prevent users from unknowingly disabling virtualization support, make the controls user selectable only if EXPERT is enabled. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/Kconfig | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 2a72111c23..fce40f08b1 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -118,10 +118,24 @@ config HVM If unsure, say Y. config AMD_SVM - def_bool y if HVM + bool "AMD-V" if EXPERT + depends on HVM + default y + help + Enables virtual machine extensions on platforms that implement the + AMD Virtualization Technology (AMD-V). + If your system includes a processor with AMD-V support, say Y. + If in doubt, say Y. config INTEL_VMX - def_bool y if HVM + bool "Intel VT-x" if EXPERT + depends on HVM + default y + help + Enables virtual machine extensions on platforms that implement the + Intel Virtualization Technology (Intel VT-x). + If your system includes a processor with Intel VT-x support, say Y. + If in doubt, say Y. config XEN_SHSTK bool "Supervisor Shadow Stacks" -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 13 15:02:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 15:02:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494675.764840 (Exim 4.92) (envelope-from ) id 1pRaLP-0008LB-EY; Mon, 13 Feb 2023 15:02:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494675.764840; Mon, 13 Feb 2023 15:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaLP-0008L4-Bt; Mon, 13 Feb 2023 15:02:15 +0000 Received: by outflank-mailman (input) for mailman id 494675; Mon, 13 Feb 2023 15:02:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaLN-0008Ky-UK for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 15:02:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20620.outbound.protection.outlook.com [2a01:111:f400:7e1b::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64cb15d4-abaf-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 16:02:12 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6952.eurprd04.prod.outlook.com (2603:10a6:20b:107::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 15:02:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 15:02:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64cb15d4-abaf-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g98SUnCFshHsIxLc2gb/gn4hxPZ0/a54GYD8+v+s+8eDHRg+POltfwJ6BmrCSnrV+sHEb/2qchFXRJD3WPzcdgtanfFUNrUr4Uee8Oi86+vbayRw+JSSBSd9Pid+pudFa2I++s65fpLLvDdytJZpv4YJZkz23Xk/+eF4GhogcUXkHh6WP9PDID3MvXrfu0zCxWwK7yobH9y3y6JwBJ5Cr76uXh1Zreemn8fdBaifKP9/daLcNJQJsEwyu/YKGmei0gtwxXsqHiuYKPi8bcoEyX3+W6jRCBtB60ncx8hPlN57ftXmQ6Jczs50vNEGDbW1tkKF8s08TbC/ApwHRqAddg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GZv9Md6+lu19ooIb0ctvUsQHPY93LbVvBpO/ur3mqFY=; b=c7wJQr8qNj8wfo52Qw8S6U8Fe+j5zfyBRmv1Bqy+nva/+V9hTUGhha/2qoR8VGVRvAKw0ZYWcb0XfemT8f3DfsQL63+vlSDndhiGlhEhkaynpjLEjSi/0MFgOGNavQ/PXhJBxrJD9quyyx5eB3JT+AefUT3z/l8Z09TYxKV+kP2+GL43Ten57c44cgRiRS+AmoRryXf4bpV13sYNh7ZRRdN/e4UBMMo1+U95TESk3nFAGuef8JzFZxj7BMEX18v8BL+GAP2p6IWz1T6SN0GhXkpS817c7xwc59+vbdsCNr4u7bEvUSCPblmNn4qTIWQWwzVnknyw7ovU6SLl90jlFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZv9Md6+lu19ooIb0ctvUsQHPY93LbVvBpO/ur3mqFY=; b=xc+2ktGrBumwh14B74lXlWOQJJvTQJ4Qes3LOeiPzx+aE+Md+7aMR53YnPtGWhd4BB7ziM+3K54DS/qX+U03CEoRDLZi7MR2jA8+VSm/KSgSGgC13ezOMUMkAAZFAcZOBvVE+rZ9bp3Dmleatrs4cHrwP4thG7/Cab2/IR/fmoZxg+U/PnWYZxr4AO4hV2FTxyMLpwys/iOiZHdsx5ztA8YPmV1xmWtmXHZXl+s7sfWjv2sdijW0TzaJkQYYUigWCmh4Z9WnjiCVINNuXBAUtntaGlmpzO4E5CNXokPlj0rFAq6TveLozLE59B1KRG7sm/yFU0nKZKIKsUsBl/q/aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72b13300-57b5-022c-75a1-7fa588752f27@suse.com> Date: Mon, 13 Feb 2023 16:02:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> <1b079086-ffb7-2716-8092-b69ede4aec8c@xen.org> From: Jan Beulich In-Reply-To: <1b079086-ffb7-2716-8092-b69ede4aec8c@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6952:EE_ X-MS-Office365-Filtering-Correlation-Id: f4832199-a6b1-4146-128f-08db0dd347a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wN4dPTgSpgOA9EAUXWg+42ZPJR2EIRFJOmhomzOlSqHJkqmmhrR9lYZVC/2x+k/zg0sW/zzszwq4lieHrOcajdPLGhN0uIdFJ7MQaizDcNWSvcQY6z5XmEuDkkpZDpMFZ5AYmL4euZLegD0EokAm6VNSYmNNKGCM1LU08tOMjBdpFDR1JpQDUH9CrIoAKUYLX7tQgIEbYwWHcFffA6ROZjhWMfPKmKG/KmntuHqb2MvsLf/VRNEBYzKvbx+Amt1k4zZSmlsdtHEJLCk58Qzi8cR57Qzcm46xixZLKupUNZq5BeNIbLU5X2VuoZ7BOKdEAQK1VUSzUtp3zoR+YI8GO8CYzfCpa33baI3bUSGu/n7jgq/MYtKxXzjc8Z+FwjrB3Hj5hCuxZ+r7PWI9LMmoVe9bwRqpgu6/QMI9ZfVGMVjeJEsfe/C9xeOeK/6IbbSdkMOWwr76sZA2uQYXpVQUi+Hid+sG4mXX8T4ymDgzdprI539TLBOOSAsHvi0dVzxIz2nkJOIdJvSidQGXGKvP8G39LsPiauVRoAi1JZXZEuCS2/CeX7HefNUBbJynR2FlSScfC+zB5NIuLkLnMFBMT5WkCzcJxaTnpr6Bbp4/iNITb/WLIinc2VldclQ2a/12H/f/xbB7Wa2knXte9IY0Ri9l7HvlyaphcO12xEINZDglSAPeQqrUSKC1dwbqExtAhoqVpSziOrz6KPFZyZNIhjVbfgRTl5BV61jWcvx8TqREuJyVlNwy1kYlWU/9unBl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39850400004)(366004)(376002)(396003)(136003)(451199018)(26005)(186003)(31686004)(31696002)(86362001)(54906003)(83380400001)(36756003)(6486002)(316002)(6512007)(53546011)(6506007)(2906002)(38100700002)(5660300002)(478600001)(2616005)(8936002)(8676002)(6916009)(66556008)(66476007)(4326008)(66946007)(41300700001)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHlaaUxFZFBwSHNnNUdkSHA5WUxYT2FSWGpEU0ZaR2JTenVRcEhCeUtabW1J?= =?utf-8?B?UDdLSFpucjZJRlpORyt5ZTQvRFpIL2k2UjhVUldwam5QaFJ6aWRPQUhqOFVN?= =?utf-8?B?L3ZDa2RYOTU1YW9iZjQ0ZXVkTnB6NmI2dVpDREtrWUl6MlhrRFRtYXh1Q3hV?= =?utf-8?B?M3YzTU9hVU5KaTRZRTJMV1RDdDVya0dnQVlIUG1OY0tOa2lieDM1eEhOUHhr?= =?utf-8?B?Z0lFaUx2MUJZdm5Kd3NSMTRkZU5nWUhtRUREL21HeitCcHY4OFVuL1lWdmFw?= =?utf-8?B?cUo2VWVnVEo0akJiN3JCdE9nRjViQ2xIYzZvb3dOYmtUVmxFbm5EU0F1dW44?= =?utf-8?B?YWxhSU5DUFA1cS9qVWcxeHhmSUxnd0VvSTg1Q2p5ODZXdzJUSFBzQXlkV2dV?= =?utf-8?B?a3lzM0xUbVNQSnJvRnl5T1dXZmhhMUZWWnVmQVFqaE45VHNyTjRrTjBLaXht?= =?utf-8?B?UktTR094OVN0bVlHTFp5QzdndEJFSHZqNG9lbWVML2Rhb3k2QUI4NTUrdmM3?= =?utf-8?B?UURVVXZLV1NPY1BPcDRuYzFFMDM2YTVKNmxidEFibWNSRUsrTlpIUkJCVGs4?= =?utf-8?B?ZTFSU2RDOVZFUFhvbSsvWTNFOUlidHIybllsOXBMa1R2aVFRWTgxMDAyN1JE?= =?utf-8?B?eWQ1L25CLy9qYjVRZ25BS2Y5cVRhdGtoL1hxSUpmcWFERnNKWUNVeDVjWUZM?= =?utf-8?B?QUZZMkltTnNCakVpd2c3cXlSWnQrY3JOZDJJc0FINkFGU2ErdEdBcWMrNW1u?= =?utf-8?B?QUszSm5zK1ptQVhSVldKRHA5YnFTNGp1NWdDMXUrSFAwRWQvUlR3T3g3Tmhr?= =?utf-8?B?RTc5WFF2cGhEdDJzUW02OFFUdXh5K1RiSHdjSWhTWGt1UVR1b1lXU0FKU3Vp?= =?utf-8?B?UHZxK1krYU4zOUh5N2lYMXZhWFo3SC9lTm1tNkpDMjN6ZXdxaGtiaTdsWEZF?= =?utf-8?B?NkZzbnFYaXZEVDV2QkRpcVJmZHhIb2hKU0VDVmwwUUd3dFVKTmdSR3QvYmRZ?= =?utf-8?B?SHQrT3R6aHZLeFpDbjlSSFo0OStoRnUrd29jRUE2b1p5ZlpJWjRHM1ZHbjdM?= =?utf-8?B?SEdBd3NpRXJ6OGpnbnEwV2NCa0pldjl2a2t6T0tqOW1HZ2JXYzNORXowTC9T?= =?utf-8?B?Q3RwMUZYMnM1WjJFRERaOVQwN0ZQcENJaHRzUE1PRW1jMEptK1gxdTZzVXBT?= =?utf-8?B?Z2NyaHpKRXdmV2pyeE83c05YWlpsTWlTK3FKRzAyOVlqMUxLSXBKYkx3dnND?= =?utf-8?B?cjVtUUNVVURDYVR5WlN1bzNYMmkxanVHeUw2cFZaS3lZeUQ0cWh1LzAzYjJz?= =?utf-8?B?aUxmalVrSnNscWhzNkhoU29pNXF1MnkwR3MrU0R5dkpNU3I2UlNacUx3UVk5?= =?utf-8?B?ci9xZ2Y4WmdBNzlEZnlkNVNaZ2NSQVI0eEJxRzZ5dEsreEZEYzBwUHNsNUti?= =?utf-8?B?K1BpT2xaV3ZNOEVGQ1hOL1dUUm5yZGRNajlmY0I4SVZWZXluM09yUW1yQzNl?= =?utf-8?B?ZDR1WWlVRjRCYTRURS9vaWx4RUIvVlJib1BYWUJPVEtsdHpiREgzb1RIUnFt?= =?utf-8?B?SGJ6Z1dVQzBjR25VQ1orZU5JSXY3WjFNMVdGOXRQNWdjdWhUR1JvVmJUWktt?= =?utf-8?B?QjRGU3ZlUmNxWFR3RmcydGxVZjIrVGtqNkJqM1pnN0FMdm0wYm5vM0RjTVh2?= =?utf-8?B?QXhLWHFXMlZtRy9reitqWlNIb2FUQ3E3M0xEV1IwWDhubEFXd0Q0Yy8rT0dw?= =?utf-8?B?dXZCenhWOERxWFJocnBqRXA5VlpHVS9zUGFyZVVxbTdqTm4xTnNUUlNXNWZ3?= =?utf-8?B?blVHb29NMlVrR0xNK3JBWjNnWUVSY08vYTlDd2tIYlFCMUdRR29KdjhoVXFB?= =?utf-8?B?Qm40SW81QTUwdUZrYUk2QW9qSytybEM1REhzYXhxK0IvYnRkcGpZM3lHQmdn?= =?utf-8?B?YmRWM2JackY0ZXFHVUlRQXpyb1A4RytPanA5MHVmdXl5d0M3VUhrUEdKS3pL?= =?utf-8?B?VERlZnpOVGlWUHpLellsQ0tUcTNnS3RwejcyMm9rRmVKUjhSbzM5Qmg3TDNa?= =?utf-8?B?QmQ0YUJqRDBNekVnMGFoTWtvSUhlUGNRWFdlWnZqbmdvSXNiUDE3RjRsbkxt?= =?utf-8?Q?8W6extmcAR5V7U0YpOF+G7H28?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4832199-a6b1-4146-128f-08db0dd347a5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 15:02:09.8380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dg59qbpjiwjA/Za4JupaN82iCsYjs+Xa6yV3IGJkaxU+q7dTjpC+BaZReDtjvjbcRhpFvdI4Y9YJxB8NROfgkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6952 On 13.02.2023 14:56, Julien Grall wrote: > On 13/02/2023 13:30, Jan Beulich wrote: >> On 13.02.2023 14:19, Julien Grall wrote: >>> On 13/02/2023 12:24, Jan Beulich wrote: >>>> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>>>> --- /dev/null >>>>> +++ b/xen/include/xen/bug.h >>>>> @@ -0,0 +1,127 @@ >>>>> +#ifndef __XEN_BUG_H__ >>>>> +#define __XEN_BUG_H__ >>>>> + >>>>> +#define BUG_DISP_WIDTH 24 >>>>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>>>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>>>> + >>>>> +#define BUGFRAME_run_fn 0 >>>>> +#define BUGFRAME_warn 1 >>>>> +#define BUGFRAME_bug 2 >>>>> +#define BUGFRAME_assert 3 >>>>> + >>>>> +#define BUGFRAME_NR 4 >>>>> + >>>>> +#ifndef __ASSEMBLY__ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>> >>>> Again - please sort headers. >>>> >>>>> +#include >>>>> + >>>>> +#ifndef BUG_FRAME_STUFF >>>>> +struct bug_frame { >>>> >>>> Please can we have a blank line between the above two ones and then similarly >>>> ahead of the #endif? >>>> >>>>> + signed int loc_disp; /* Relative address to the bug address */ >>>>> + signed int file_disp; /* Relative address to the filename */ >>>>> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >>>>> + uint16_t line; /* Line number */ >>>>> + uint32_t pad0:16; /* Padding for 8-bytes align */ >>>> >>>> Already the original comment in Arm code is wrong: The padding doesn't >>>> guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes >>>> size. >>>> Aiui there's also no need for 8-byte alignment anywhere here (in >>>> fact there's ".p2align 2" in the generator macros). >>> >>> I would rather keep the pad0 here. >> >> May I ask why that is? > > It makes clear of the padding (which would have been hidden) when using > .p2align 2. But you realize that I didn't ask to drop the member? Besides (later in the reply to Oleksii) suggesting to make "line" uint32_t, you zapped the relevant further part of my reply here: "I also wonder why this needs to be a named bitfield: Either make it plain uint16_t, or if you use a bitfield, then omit the name." I thought that's clear enough as a request to change representation, but not asking for plain removal. The part of my reply that you commented on is merely asking to not move a bogus comment (whether it gets corrected up front or while being moved is secondary to me). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 15:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 15:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494684.764851 (Exim 4.92) (envelope-from ) id 1pRaQG-0000by-61; Mon, 13 Feb 2023 15:07:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494684.764851; Mon, 13 Feb 2023 15:07:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaQG-0000br-2r; Mon, 13 Feb 2023 15:07:16 +0000 Received: by outflank-mailman (input) for mailman id 494684; Mon, 13 Feb 2023 15:07:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaQE-0000bl-Gb for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 15:07:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaQA-0000Wn-SN; Mon, 13 Feb 2023 15:07:10 +0000 Received: from [54.239.6.185] (helo=[192.168.15.251]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pRaQA-0008Ox-LZ; Mon, 13 Feb 2023 15:07:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=62FwoNnNBqh0Nw0JIG6R3abksgyPBoHkVO3C7jnYJ44=; b=0BmNrT1zRQ2f4jlJlBXveM1sM8 /05ycoAP7OmUc2nwmIpFXnLO9Lekinvqu0gXBi9YHXTziMU1jTUfgFpI/ZPpXAGk+CtdT1IhA34DM PoC0NQtntnFzas3HumK4OkEjZal++dTzpVIsvuHcF37zRCOR9T68wTLxRVq2gQ2oFyos=; Message-ID: <8f062433-659d-fe4a-4ac0-7a6b426e85ed@xen.org> Date: Mon, 13 Feb 2023 15:07:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> <1b079086-ffb7-2716-8092-b69ede4aec8c@xen.org> <72b13300-57b5-022c-75a1-7fa588752f27@suse.com> From: Julien Grall In-Reply-To: <72b13300-57b5-022c-75a1-7fa588752f27@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/02/2023 15:02, Jan Beulich wrote: > On 13.02.2023 14:56, Julien Grall wrote: >> On 13/02/2023 13:30, Jan Beulich wrote: >>> On 13.02.2023 14:19, Julien Grall wrote: >>>> On 13/02/2023 12:24, Jan Beulich wrote: >>>>> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>>>>> --- /dev/null >>>>>> +++ b/xen/include/xen/bug.h >>>>>> @@ -0,0 +1,127 @@ >>>>>> +#ifndef __XEN_BUG_H__ >>>>>> +#define __XEN_BUG_H__ >>>>>> + >>>>>> +#define BUG_DISP_WIDTH 24 >>>>>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>>>>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>>>>> + >>>>>> +#define BUGFRAME_run_fn 0 >>>>>> +#define BUGFRAME_warn 1 >>>>>> +#define BUGFRAME_bug 2 >>>>>> +#define BUGFRAME_assert 3 >>>>>> + >>>>>> +#define BUGFRAME_NR 4 >>>>>> + >>>>>> +#ifndef __ASSEMBLY__ >>>>>> + >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>>> +#include >>>>> >>>>> Again - please sort headers. >>>>> >>>>>> +#include >>>>>> + >>>>>> +#ifndef BUG_FRAME_STUFF >>>>>> +struct bug_frame { >>>>> >>>>> Please can we have a blank line between the above two ones and then similarly >>>>> ahead of the #endif? >>>>> >>>>>> + signed int loc_disp; /* Relative address to the bug address */ >>>>>> + signed int file_disp; /* Relative address to the filename */ >>>>>> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >>>>>> + uint16_t line; /* Line number */ >>>>>> + uint32_t pad0:16; /* Padding for 8-bytes align */ >>>>> >>>>> Already the original comment in Arm code is wrong: The padding doesn't >>>>> guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes >>>>> size. >>>>> Aiui there's also no need for 8-byte alignment anywhere here (in >>>>> fact there's ".p2align 2" in the generator macros). >>>> >>>> I would rather keep the pad0 here. >>> >>> May I ask why that is? >> >> It makes clear of the padding (which would have been hidden) when using >> .p2align 2. > > But you realize that I didn't ask to drop the member? I misunderstood your first reply. But the second reply... Besides (later in > the reply to Oleksii) suggesting to make "line" uint32_t, you zapped the > relevant further part of my reply here: > > "I also wonder why this needs to be a named bitfield: Either make it > plain uint16_t, or if you use a bitfield, then omit the name." > > I thought that's clear enough as a request to change representation, ... "May I ask why that is?" added to the confusion because it implied that you disagree on keep the pad0. > but not asking for plain removal. The part of my reply that you commented > on is merely asking to not move a bogus comment (whether it gets corrected > up front or while being moved is secondary to me). I am fine with both suggestions. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 13 15:11:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 15:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494702.764862 (Exim 4.92) (envelope-from ) id 1pRaUY-0002Cd-NC; Mon, 13 Feb 2023 15:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494702.764862; Mon, 13 Feb 2023 15:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaUY-0002CW-KO; Mon, 13 Feb 2023 15:11:42 +0000 Received: by outflank-mailman (input) for mailman id 494702; Mon, 13 Feb 2023 15:11:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaUX-0002CL-GK for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 15:11:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7d00::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b793539b-abb0-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 16:11:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7749.eurprd04.prod.outlook.com (2603:10a6:20b:2a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 15:11:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 15:11:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b793539b-abb0-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsPEoj9IVHOqSJq1yZaZ7AmYRs5ncNtipaFzrSJEbv4prcZZyR5PU+/Mj/uWSwqTo9ntJ7s5vsFrmgqlXyN1QPU8MmXQmb0Wt/CWIyvzctHfHvbqqXqHhReVsoyNZMMSA4Puny9/vg3FbHPTxbGZgzZDm3T5wB5rZ78Ugo3k1C0NmHXfCtEXF4DvenjwzGuP1qCxIavKeL/bYQzQSIlxYGA+qi7Oa8ftXUbMSGW+u2QAlc/DYGFv4IG7hVcpuYlnB779umaR9tpv1B0+hdgfXYSjfmy+8RWm2hOVAlC2yraR89ARh88s+kh09SfiEMiq53L4xxmtL1HPhBtU6FjWUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pI7eCo0GaXU3EHmrxI+t/264N9K810g4h/vYfA5JWo=; b=E8xUqXJOa6v8PrlAxmf8h+EWf7d7S3B5U6n/cUpcEA4br0sEQVK/TWKRYpXxjQckBRgCqFL2MfVemaBbAxQy1dKO9612q4400oYVPymhiXwbKFtzECoDzQT0Y3BWlIPtYoNeJyHZC2BOvsJXV580S78a35E/iCsouuT9L8ly/iGvbn8ePeaFXJEQ9aOoLz0b0VqEKRoFakMGumrwb3XDqDlJ/8u3Dh9O3KBNBQvACSpR/3uPtpz6tSuSu5ZXsYFMq3E5V2VSkJ0eGhBd4nn0JuKmEmL5G59g+HW375PGatUbGKg5D4JmE2jDPHrGq0Lt+YR5uHg/QGRAxncc+5KsBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/pI7eCo0GaXU3EHmrxI+t/264N9K810g4h/vYfA5JWo=; b=limbqXbydMElGcs9IHpMeTw6Gu/XtaqKmOuXrRz2k7Xz0Mf5l14ZJYSQy6NDTCAO57EtvMf6vhBSa0FUaWBOizwJugRXYx8XLmSVD4hea69ZzmtJds82eAlc1Xg4r5PD2UfVUa1ATbiLb5Qk0/Y3Cc5JrGk791QbG+ourQTk24JN2rDyc15qWG1xG2eR5g9NwZJggCjoz/jIUQd7QvGFq+YYB2maMwMFMx8KIvn0DiaeSybWRLnrjhJ1zuaCTCcz8jVWQvhsRze1+30r87HHFEF7TzkD6oujCBCjJeGRkQCdzjNd0JTBGyO0GKsNmiRByztpdzj2lfSZDh2ZEeDj5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 16:11:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0184.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7749:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e0d2608-6bfd-4d9a-196d-08db0dd498f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qp8qrz6FIeu2c12vvp8FYmowuaOVnkpjrV8FzSdXzwRjY5jz2+ZnSVBrQ2uiAalmhrQxZ+o4wXuyV9qaIGSxMocq05D+lZwUGHJLmy6jwbYu/LLmCwq4UVnI4UZZQIr+86NQsZSzAr18FkvmJ/wUNp0f9VcqRQC56kd8He3tN/l8WP2Np1KrtULUeFSl3wjprmSBzLXxtaDFqhz3TT0YnK5NjqJeQDrjnnXKUMPCk7RhY7p/wSAJtVf/zJtvnICdCkc1SpZNbTBw9tuRVHXOq43BBh3wFdax2lGLp3BNe6ceLzA8AtJIwT4WuUef8rfDwLpnfjS2qFjImmgRvY/UwTGRFD+EBu2Dop4v20H0brM3Faxa1CIyYPCcN48JFE8Z+D7TtkLc95eiAAnPHIfd1dc54URMtMHbDhbsTaqfhvVorWmMrVACRSe8cOJakw++fcTMNNgCv5YQY86vYJ724wahrbt73v5WCByDSUZqDny1H1d1SmyFYzDjVsAuVl4hR+oMQDl2I0+Qr9uXPldUMlc0IZPBZQK4XHeq9tTqBWB01YRa4Wos0Uwz4reSZ4Z7EbmbfEvQumUzKHrfVSpXylR/1jxr7r3M9Oba/WKGodXAxGg3qf2ieNU61TN5WtrJX0YI1rllfHcsgOff+ViHnZuhxBhMZg3NRnN9bSJI3hRxKfNhLiQQ4UB7v8tN7xo+JUeumS6XIkJ+3pvAl703T2VWQEVpZkzKBP4fextBxlE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(136003)(346002)(366004)(39860400002)(451199018)(31686004)(2906002)(5660300002)(8936002)(41300700001)(6916009)(4326008)(478600001)(6486002)(36756003)(26005)(6512007)(186003)(66946007)(53546011)(2616005)(6506007)(31696002)(86362001)(66556008)(8676002)(66476007)(54906003)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3NGZVUrSUlKYU9sTUdza1l4Q05PbTFIOUpxc3pZWUY2a3AzckxWbDdiUUph?= =?utf-8?B?T1dNWURaQ0tyR2N5bXA0R3VBNzhqZlJtZ211V2xuL0dRZEVDMXhnYnl0bDNR?= =?utf-8?B?ejZLN3Bzb3lxdTVFdVRIQXkva05zczRJMkpyWkVGRVBjbnlpdVFPcUtWQ1ZZ?= =?utf-8?B?aU5OSXUvVDVac1o1ZCt5ZXhpdUs5NG13SzNFRnVncy9pR3NET3lURElVcitD?= =?utf-8?B?T2xUS1I0RlRsbTFKTUdxNEppdXJVMkV5bEt1V3hvbnhJY2dqc283QkhZMEhL?= =?utf-8?B?eUlsN2FMNEExZ01lODlZVE50NTJUdDhNQWlWN2tSd3J5a2gzOE9paElFN1hQ?= =?utf-8?B?WC9Cazd6QjlpVzl2cFJ6d0pKYlRaZnhhT0xtQjZ2azArTDNvYy9DN2w5RDZs?= =?utf-8?B?bkcrSWQyeGtiUk1GN1hraEJHL0pzRllMdWoweDVzR1JveHA3dDdxUlYybzhm?= =?utf-8?B?S0xFc05uZ1dxbXN6c1RDRnU0SmlEbTBLSzBqNSsyWk0wMHJDVGVuYnVwL09q?= =?utf-8?B?UGc1Szlhb2pOVEJodXBhS0lnNTFYY2lQSGpycmJnRVZhZmczU2pMeVM4STc5?= =?utf-8?B?ckhnSDhGRWZuZTgrZ290VkJDYVRRbFJIRGJ3ZENrajMzL3I5elY2NTE3VS9W?= =?utf-8?B?R3luc3Jkb3daalRJT1F5UXQ0TzQ4V0xmOU5DK2UxV2ozeG1MR0hNVU1UMVJt?= =?utf-8?B?aUZ6QkxYbHY5cXJTZXdiQjNxOFVHZE1YOGpKRDJ5NmRFS081YmpJQm1uTlVl?= =?utf-8?B?SzFsUDcwVDdSZUkwWVZDcXNxRzV1SXZRUnM3WkF2alBiQXU4amZMZGZ2K2l0?= =?utf-8?B?L253ZFkzWlZLUDVYb1pmZWduN3FyY2lnMEFYZ1hxRmQrOHpNWTNta1VVN1Qz?= =?utf-8?B?b1RPNys1M2g1ejBCU3ltK1cwUXpUcElOME5SMThyUVFSK0ZrcUg4U2FqZ3pK?= =?utf-8?B?azFwVk54bGRwYzdBNy9VaEcyaUI2dEVueUdmZXRNSUtqOWRtTFRRQ1VTNmNz?= =?utf-8?B?Q0M0dCtwUUs4Sjc0RlFEWFJDQ1crOW91SGtCSG52LzU2NjFuaCsyZHVtU0kz?= =?utf-8?B?UU9tYkZXUGhtVWdkS3E5MFBaM3IrYm84aTJ6eng0RWtYQTUxL1k3OXZrdnpG?= =?utf-8?B?amNxM2ZiYTQ2OEVQZlVMbVo1bHNodUZtUXE4RFE2K0VsdDkyTEZKOUtWZ1Vz?= =?utf-8?B?N1hMOFVuQjUreTkrTWFpZXFXVGhUQjhKY0lkZFkvcDVoZjgyWW8zWGg3Vktn?= =?utf-8?B?SFdSMnpoSjJhRDlHWlpaVk54QUVFMm5QdjgvTExlbTAzRTJJQUFweUV4ZWRQ?= =?utf-8?B?OXFiMW8wNWs1N2UyZFZuNER2c3d4Tzd6WTR5RDZXRUozMUJqV3F4anZSSlpy?= =?utf-8?B?SEZvZmthKzhWN2FOVEZTVDdmY2ZIcmQ0V0JpWDIvczhuYzZjWC9JRGllUkxT?= =?utf-8?B?ZG1MRHhRRkw0NU8rRHVEc1pRcFNnTXh3cCtMbGlOdWhmZmYyTE9LdE1NRDlN?= =?utf-8?B?dXRlOGN6WVliRWVNRExTUDMzaGZ1Mmg3YktNdkhtYjQ5RHlRQVNRMXZGQkZa?= =?utf-8?B?S25PWkozeFZpUVNGRHBad2M0dlV2UC8rWUcycmc4T3gyeU1adGowcEVQaTFu?= =?utf-8?B?Q0pOaFI3RzdkWjNXT1ZRMEt2VHNSM1Z3bXR0aGdON1BieXVjMEhyRThnQWRY?= =?utf-8?B?TGM0eEFBZlVoZXlSTUFzejhlallQNEdJZlYvT0xXSit6bU5oZGNKeHFGYUIy?= =?utf-8?B?bGQwMVJobGZaZG9VRC81Q3pNUzVVdWtvamhnUURLdCtHR0RJQ2FubnZMU2lD?= =?utf-8?B?STg0MmZ3MFhlUk94THhrZkN0QU5JRm5COWFHNWY3SU1aTDcvMmxmem9zOUli?= =?utf-8?B?Ukl0UGdMcnd5aWVTekJoZmdXekRKZmhEUU45Z05sb1k0MlFlaURNZzY5Qi9H?= =?utf-8?B?Y3h5Rlhnam5CWlA2Y3BZanN2WWNsNkN2T05jYy8xMjByTkZvWHpiQjBFaFZE?= =?utf-8?B?aFhDMUlrU2xCNjZGWmJoNXorRitMaFdESXd2dS93MWMwQXJFSlBlRURlVW0x?= =?utf-8?B?OVAxOWRLcnM4K0JYOUhWcHU4QXZuMTZ4eGY4NWVkY3cvUzg0anVhMHR0RWdq?= =?utf-8?Q?sYF9HfvnBZFr96aH/26Jkw7Zq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e0d2608-6bfd-4d9a-196d-08db0dd498f5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 15:11:35.5359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6HrihcYnWVMaeNMZjUkrOARW4sk52rqdRQgBg62rYf+OqFHdfACtOq7H08oLLVzUgwpLQ4GhR2LgVK0uYlgVHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7749 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -117,6 +117,12 @@ config HVM > > If unsure, say Y. > > +config AMD_SVM > + def_bool y if HVM > + > +config INTEL_VMX > + def_bool y if HVM I'm not convinced we want vendor names here - I'd prefer to go with just SVM and VMX. > --- a/xen/arch/x86/cpu/Makefile > +++ b/xen/arch/x86/cpu/Makefile > @@ -10,4 +10,6 @@ obj-y += intel.o > obj-y += intel_cacheinfo.o > obj-y += mwait-idle.o > obj-y += shanghai.o > -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o > +obj-y += vpmu.o > +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o > +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o This code was moved from hvm/ to cpu/ for the specific reason of also being used by PV guests. (Sadly the comments at the top weren't corrected at that time.) > --- a/xen/drivers/passthrough/Kconfig > +++ b/xen/drivers/passthrough/Kconfig > @@ -51,7 +51,7 @@ config AMD_IOMMU > > config INTEL_IOMMU > bool "Intel VT-d" if EXPERT > - depends on X86 > + depends on X86 && INTEL_VMX > default y > help > Enables I/O virtualization on platforms that implement the This is odd in three ways: For one PV domains (i.e. incl Dom0) also use the IOMMU. And then earlier on there was a change of yours specifically relaxing the connection between I/O and CPU virtualization. Plus finally you make no similar change for AMD. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 15:14:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 15:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494709.764872 (Exim 4.92) (envelope-from ) id 1pRaXY-0002o8-5C; Mon, 13 Feb 2023 15:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494709.764872; Mon, 13 Feb 2023 15:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaXY-0002o1-2X; Mon, 13 Feb 2023 15:14:48 +0000 Received: by outflank-mailman (input) for mailman id 494709; Mon, 13 Feb 2023 15:14:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRaXX-0002nv-8W for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 15:14:47 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060d.outbound.protection.outlook.com [2a01:111:f400:7d00::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26632a9a-abb1-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 16:14:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7749.eurprd04.prod.outlook.com (2603:10a6:20b:2a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 15:14:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 15:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26632a9a-abb1-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WHaq5x0G4y+DEWpQv7qxXwRh4ATCu5DdaQ7AC5UJ9KQrXy1TrZIiBVCdEhGTHglQmiKfHkBssnSHMs5wv3rfRU9AfjJ9FxCzGtbahSzD+ZdGixhnkvxUWdcLURtbEQENfaCLIWCOR55H/3yng0D8SpFHg1dz45UzY7nt4IEvE7N3kw7d5oc+g/lxZLOE12sSEXP+NIbw75gd5grI59zCunBauyiFq36PAztIiRUZYr2P+zOTCSMwpASHXtLDoI/Oj58ptt5LR3KVBAPP7437xlKXmwkahtWbEZOYGZmUeYYZsyONU1QcBlwCLrpBebF0Wui/SG838aJ9WA2IQDoi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=spa3gAD7DVlHrXt8S850gfXusBgd9j7WRe0hO//yQg4=; b=liuUdovEVe9omqOmm0muOyCi/3NS5jvewPMetgF3VcJ34Vy5geqy4W6r5GZ14XEEMu8tpEMx1lKyDpVOT+sZ8rnqvgjvH0CQiZhXHitwbWqTt8Sdx8gejL5QPkARoTfBpGyN+nPLidXMSJKbvYMv6fNtJAVSkItYWSQ8HWQ4Z6ocd+CeAzR8glikoX2vXKD9EGqc69wXQV2cH4AOp2xcsR2bmQqKplDJE0+7JSMreT+5u32yWradd6bRKrt8De+xKBkUaK+Ji1AlqkT0vNDOfkrC/qBeGn/EfNP+IzIN7Q5moynUQT5MssEXXv1TPaIOKOnxCDJ2HxeOM/86mxeM7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=spa3gAD7DVlHrXt8S850gfXusBgd9j7WRe0hO//yQg4=; b=Fmf/e4fCK5s5GtPVEWOGPptdvktDWqR1RYKyhBrrCksS8evv9QlCH/36xsUHczzdsfHO5kJYt79N7Lsp/jeUpdfghDDI5YklaMHvv0vLFj/oeQAJI2Nkx+OsxaHOfZHWELEJFjFhR9hmm6B+DshjepHq7NLodQuylOBPGfITobHkc/wOcmnqFyB030/CervfY9pqArcKlknRYs7Izp4WaOmJrxX4+eXF+XR8FtFKRn7j4xeEhiwHBUUPxUzxHDLvvVgJc4vQ1m+xd8XeWhVAK1/pqrkXLeCZVapTQr85FpD15sNfvX8uzYOuDB33Ts/RSWV9yMyyiKmsUJuPdjTuMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 16:14:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii Kurochko References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <64aba76d-1746-9f6c-109a-e8c3bf1e1b61@xen.org> <1b079086-ffb7-2716-8092-b69ede4aec8c@xen.org> <72b13300-57b5-022c-75a1-7fa588752f27@suse.com> <8f062433-659d-fe4a-4ac0-7a6b426e85ed@xen.org> From: Jan Beulich In-Reply-To: <8f062433-659d-fe4a-4ac0-7a6b426e85ed@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7749:EE_ X-MS-Office365-Filtering-Correlation-Id: cf45c5e5-aa19-4735-d994-08db0dd5099c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hU70iZWrMphLol9IBwieCNCPaWRjyYdJbB9Z+Ky++loJlGrOSTD6YYIL/as5atLV+DDaI/dwCRSOyuzY7XxQV2ttDAGBb8FFjGO/tdTC/ggXASNmXgK1VlyNipfo3UCx61LJ1Ty1zVlzy7csyEfS5PsoQCXi539rM87Pe7We1wcNf7vcpbI95RTOtu587UaneD2SVIjUtitycPDSXj9DtxTkh+6wJUOpPzujHzlkHBMRTSBg2XjMD/9w7eFa3ohW46Wop4Q1gpIlnIu9SOMQtj+waz8vurp+2ahhzTv/oHJZs0N9+PgGWLj/xwfZCdTDbsJribTDKVmag2Mr1cjt1pLIfgeRrb3x7W8Gr/idSZShQneCswMLg8NEahXTxiDcGAIf9PBMcRgieJgMMz0N29k5Ds0Iz5hg04kR0bYdgpuuVvktd74qBqJcK9mVI11GcJsKVOc4IJXab07aJ7V60vLRPaStkKG/Gny+6Xtj3APIOjI7P0LhLeu/lebTJvM3j4v925qqtsQ3hbVKpjn/GfNo95RsMOjuGdcgcL7/CJjohKuTLU7e3+bJGjst0AXqZ0jtmkXWlUSn2nr3k6JmUSvtfDNLCOG9Os3CoYEFtmOEtwMZm58SlfnARYXLuYJcpGldb1E6XLZ+rJlEtmaJn9w05Ji9MTPkKyCC733pJTpENor477sPkdIriuy1PAwPCBkZED5sX9Tq7bR6pNHp5Ee8gWByA0qmFD/di4rm+NafnrGOVo0nLkA7GcZRoYBH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(366004)(136003)(376002)(396003)(451199018)(4326008)(41300700001)(6916009)(83380400001)(31696002)(86362001)(54906003)(38100700002)(316002)(66556008)(66476007)(8676002)(186003)(66946007)(6512007)(53546011)(6506007)(2616005)(36756003)(478600001)(6486002)(26005)(2906002)(31686004)(5660300002)(8936002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUdvWWZkYlAxTU5aeEhhOE9WdFd4bkpVL0poU3pOdndXQVlBZG5JVmxJY1V0?= =?utf-8?B?aFlhQVI3MVJyRHpScUV2SlZmdEh6ZHhFd3k3UEtBOWd0SlFQRVIreWZhRU9o?= =?utf-8?B?bnpwSGJtN0QvZnQ2TkhZOStiNzU3TUlQYXViaTFRUUJ4Znl0eHRDN1hCUy9H?= =?utf-8?B?cTJCanlqUEsyU0xuOGNUZnpWaCt2a1pqTHlKcjNsbjlpeXFmZUJzSk10bVYw?= =?utf-8?B?clR0VG53Z2l6NnM2YitDMG5HczVsY0NnZ2tWeExhSnRyL01nRi9HNUVieFds?= =?utf-8?B?QVpXNGM3SUJ5V3BXLzBBWWNuUzZKMi9vTmI1VHJqc3J0YlNqMU1NaURuZllw?= =?utf-8?B?ZVlMRWU2VlJDY2RXWWU3UEIyc2hzUy83NWZGNGw2Q1E1WXh0b3dZTUE5NFlW?= =?utf-8?B?WlBMdEpHaFlwZHN4NHllcmFmd3VWVHpWblgrUnZEbUNacEZoWUtDc3pQcW1X?= =?utf-8?B?ODQvZW9CT3pkRnEzbCsrZzUxeWdQcmE1MzJLenVnNzZsaS9sNEtRcXlSOEI4?= =?utf-8?B?NUk3cEo0eXg2bWRFakJTSjd5QmpuVThTY1Iwc0ViNXUybHZGSkI4U2N3cXlN?= =?utf-8?B?elpGSmtIN1NtTUQzMkl1cm1RQzhoeTVSZkxLeEtnVVUzeFQ4OUxyQXgwYlpG?= =?utf-8?B?Z3kvc2tncjhlYnF6Ly9FdHBzdXI3VGJVYzNHdm4wRTJpLzdpVzFpY3paRUZj?= =?utf-8?B?S0o0OHlVdTh2c0pSWGxXU3dEWWdtUlhhOGlGZmhYazlHUXYzR2U5V3d1ejJL?= =?utf-8?B?Z3RlQ3JVZGJPRnJCTFlubnB4ZG9hOTRNUEYyVVZ3dGpkTFFmMWg3VUJGYmRo?= =?utf-8?B?N1ZmZCt6T0VGc3RER0N1MVVGOTEwZmpPV2VKcE51VVRocDRhWm16Y1FEN0gy?= =?utf-8?B?UHdNT0ZweVFzeGdXSDU4UWROSkRNREsvc0tNRW94VGFGNFBpbmh1S1RtUUo5?= =?utf-8?B?ZTE3aGEwY3hhcTdtQWo4ZHEyUTVRTm9OOFlXMHZsbzBzL2ZzRWlaU1FlS0xu?= =?utf-8?B?NHJvczBMRncvVEptUDByWFJ4TzBkaEV5UE9SNEhzU1NRay9Hbm9NODFxWWlH?= =?utf-8?B?bkIyOHB1czhqTTgxaERGUjV1L0hwenpnYUdkcTJZOE9BYU0xMkIyV1d3cTNH?= =?utf-8?B?UHJoOFBvVXdUZ25WUS9iTTlTckJET2o1akNjMTQwNnN5bCtabWNWWnNtWmkr?= =?utf-8?B?Y1RXUDMzbVFuc2lLRWI2ZHJseFlIYzc5aHpEWkZJcVQ5TCsyODMzQUhlNk1L?= =?utf-8?B?UlpIWktnWUZwNHRlMklHb01SenF1S09UdkdEWitIM3hLOGZpOFRaRmhzd0kz?= =?utf-8?B?dnlML2dnRmRtNDJBcEFLNXhWdjJscjJ0K01xRlVsZjdvQnFmRUplei9YNVRG?= =?utf-8?B?QkVVZVJzaFZHbzRMWmsrbWpuZFF0MDBqRG42SE1iZUNNT2ZaRWprUzRGWi9v?= =?utf-8?B?elcwUzhKTS8xNVhiMTE3Z2RvYmxWNlJIS29ZOXFOWnNGS0ZsUkhoaWZ0NGZQ?= =?utf-8?B?V0ZMRzdNUnhKQWhYNFBSVjRhVUlzN2dwcEg1L3RMdm90WDNDVnQ2cjJrZ1RQ?= =?utf-8?B?dHVQU3dCODVrM0l2VkVYMWJXWG9CdmtCeEFUbTFRQkdGT1g0czBMblhPNVFJ?= =?utf-8?B?OThQYkluK2RBdHFhRmwxTGVpeVJpTDJIVFUyMUo2QkczcUl5bnRYWC9XN0Rq?= =?utf-8?B?bXBwd2NPdkRGUXl6TlBqMXo4UmxlU3dGWnJ3R0JIYnpYek03MFNEeDgzUU5y?= =?utf-8?B?amw0cVN6ZjRLeXhXR0ZBV3BFUThmR04wUEsxQlZLelNGUkZGNnAzUmV3c3pl?= =?utf-8?B?NXNiTUUrcVFYVG1qWXE4YkFVS0RZNUphdzhKamE5YUlXaHJFeTljTDFoeThX?= =?utf-8?B?WG5iZCtEVVZKV3VUSnNUQ01KVmtueXArSjc4ZVYrcUVPb1RmaWVxS1NFRzZp?= =?utf-8?B?UmxvYVZmMnZGNnp5TXRXR2c3T2xobTIwTm0xdll0b3M5Z1JXQVk4cTdXbEwr?= =?utf-8?B?ZUhzcjBXWnkrOS8zZzM4aUdVSUNuNzZXTkhjbDZlZDhrWXhVbGdkL1FRNStQ?= =?utf-8?B?anFDSDRrZVNiZXdVUkhFaWNMTi9NamM2WEtYc2VhRXB6S2FmMFRIMlVrL0RU?= =?utf-8?Q?zZPwOgrFw66U7qQg2bfz/0W+r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf45c5e5-aa19-4735-d994-08db0dd5099c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 15:14:44.5870 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fcsi4ECpjqATPlskz8FYb8MptALX9NLYCOuQyoQqXctZhvBFWMtJZ2WMwSLMPugAYhGkZvTya5/gcUkvJXVXxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7749 On 13.02.2023 16:07, Julien Grall wrote: > On 13/02/2023 15:02, Jan Beulich wrote: >> On 13.02.2023 14:56, Julien Grall wrote: >>> On 13/02/2023 13:30, Jan Beulich wrote: >>>> On 13.02.2023 14:19, Julien Grall wrote: >>>>> On 13/02/2023 12:24, Jan Beulich wrote: >>>>>> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>>>>>> --- /dev/null >>>>>>> +++ b/xen/include/xen/bug.h >>>>>>> @@ -0,0 +1,127 @@ >>>>>>> +#ifndef __XEN_BUG_H__ >>>>>>> +#define __XEN_BUG_H__ >>>>>>> + >>>>>>> +#define BUG_DISP_WIDTH 24 >>>>>>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>>>>>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>>>>>> + >>>>>>> +#define BUGFRAME_run_fn 0 >>>>>>> +#define BUGFRAME_warn 1 >>>>>>> +#define BUGFRAME_bug 2 >>>>>>> +#define BUGFRAME_assert 3 >>>>>>> + >>>>>>> +#define BUGFRAME_NR 4 >>>>>>> + >>>>>>> +#ifndef __ASSEMBLY__ >>>>>>> + >>>>>>> +#include >>>>>>> +#include >>>>>>> +#include >>>>>>> +#include >>>>>> >>>>>> Again - please sort headers. >>>>>> >>>>>>> +#include >>>>>>> + >>>>>>> +#ifndef BUG_FRAME_STUFF >>>>>>> +struct bug_frame { >>>>>> >>>>>> Please can we have a blank line between the above two ones and then similarly >>>>>> ahead of the #endif? >>>>>> >>>>>>> + signed int loc_disp; /* Relative address to the bug address */ >>>>>>> + signed int file_disp; /* Relative address to the filename */ >>>>>>> + signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ >>>>>>> + uint16_t line; /* Line number */ >>>>>>> + uint32_t pad0:16; /* Padding for 8-bytes align */ >>>>>> >>>>>> Already the original comment in Arm code is wrong: The padding doesn't >>>>>> guarantee 8-byte alignment; it merely guarantees a multiple of 8 bytes >>>>>> size. >>>>>> Aiui there's also no need for 8-byte alignment anywhere here (in >>>>>> fact there's ".p2align 2" in the generator macros). >>>>> >>>>> I would rather keep the pad0 here. >>>> >>>> May I ask why that is? >>> >>> It makes clear of the padding (which would have been hidden) when using >>> .p2align 2. >> >> But you realize that I didn't ask to drop the member? > > I misunderstood your first reply. But the second reply... > > Besides (later in >> the reply to Oleksii) suggesting to make "line" uint32_t, you zapped the >> relevant further part of my reply here: > >> >> "I also wonder why this needs to be a named bitfield: Either make it >> plain uint16_t, or if you use a bitfield, then omit the name." >> >> I thought that's clear enough as a request to change representation, > > ... "May I ask why that is?" added to the confusion because it implied > that you disagree on keep the pad0. Hmm, yes, I can see how that may have been ambiguous: I understood that reply of yours as requesting to retain the _name_ (i.e. objecting to my thought of using an unnamed bitfield instead). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 16:31:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 16:31:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494743.764884 (Exim 4.92) (envelope-from ) id 1pRbiu-0004IJ-Fu; Mon, 13 Feb 2023 16:30:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494743.764884; Mon, 13 Feb 2023 16:30:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbiu-0004IC-D1; Mon, 13 Feb 2023 16:30:36 +0000 Received: by outflank-mailman (input) for mailman id 494743; Mon, 13 Feb 2023 16:30:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbit-0004I6-6s for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 16:30:35 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcfe357f-abbb-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 17:30:34 +0100 (CET) Received: by mail-ej1-x631.google.com with SMTP id hx15so33221978ejc.11 for ; Mon, 13 Feb 2023 08:30:33 -0800 (PST) Received: from [192.168.1.93] ([188.73.238.161]) by smtp.gmail.com with ESMTPSA id b12-20020a170906038c00b0088f464ac276sm6922391eja.30.2023.02.13.08.30.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 08:30:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcfe357f-abbb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pq3kexPu3NO3Jn2uKU7l+y+vB3Qu09wzUeg4RbrxHzM=; b=Nj1q6t5D0obFUPqgr921+fLAA8+oKjgtVYkG0+tzYh4uBnLS0CVOrMMLuGgUcZF4Nt hylnbFF6+q/lazJIrGID48q0uDXMVojPrVmsT3axzylyc1tq/v5arzlSO+kUGgvQwwLY vJovz2CHiNUbf6BrepLNb7f00weoeL2atAMFbXJIW+o4qipMh2ESpW8T2J+t+ufaKUs+ gqPTNja3FUuqABKeE9la7itYdv6tf7OTv/eNWfsfKx3g/lNaF/jm8/QsHd+gGP5Wgv9y oo3JgPFL6QrY7O1nVf/NnzWgNi/kdp2u0ulhesNwNGWZzd45w8GvdELWNwx3ueH/aGHC Rl5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pq3kexPu3NO3Jn2uKU7l+y+vB3Qu09wzUeg4RbrxHzM=; b=EW9arSvNHojsnn65y/NOCLrK3hfn4GcwWmSqQVxc4VLDvp5hQOu88nTM2DyuDx0zMF 4gL40PMcaKROKnv91w07u5SxqiFggRBzg9lmh+dgE673cE/fpawBm1KyUroZyk/e+z0Q HaZOcXiFPxYY96FZD08Q67zYGSmHO4H7AfRn+zC3TMTt8JnK61wMInpyiCIntiwXrV80 nS1CjbFDUnjhj4sgAfSQvNiOuvjxnPR4JPRgY1kXsRIXoFvDbdnakgoMCPezm3Lnnrm2 Ir5WQXaL/1tqsunmyiMl6VkozP8VN+mxz+jggEXBqGIWAM/zD8qoPLFxTuO3CofvzYZ3 yn/A== X-Gm-Message-State: AO0yUKUCkjbN+cw4tzfKhS+qtcLCvghRVZwkhcEqgcJGM++C+ps2qMm1 OduKGuw68rQRRA1pXaCAxBRA2RrAiQg= X-Google-Smtp-Source: AK7set91fB45fUPSHDQrbmUL8Bt6fh0f3bYkHBojCnFse661xEm5/Hjc2NLhFI+n21fY0m/n4N5aqg== X-Received: by 2002:a17:907:d19:b0:884:26ec:388b with SMTP id gn25-20020a1709070d1900b0088426ec388bmr31480131ejc.39.1676305833212; Mon, 13 Feb 2023 08:30:33 -0800 (PST) Message-ID: <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> Date: Mon, 13 Feb 2023 18:30:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> Content-Language: en-US From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/13/23 17:11, Jan Beulich wrote: > On 13.02.2023 15:57, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -117,6 +117,12 @@ config HVM >> >> If unsure, say Y. >> >> +config AMD_SVM >> + def_bool y if HVM >> + >> +config INTEL_VMX >> + def_bool y if HVM > > I'm not convinced we want vendor names here - I'd prefer to go with > just SVM and VMX. Ok, personally I have not strong preferences. > >> --- a/xen/arch/x86/cpu/Makefile >> +++ b/xen/arch/x86/cpu/Makefile >> @@ -10,4 +10,6 @@ obj-y += intel.o >> obj-y += intel_cacheinfo.o >> obj-y += mwait-idle.o >> obj-y += shanghai.o >> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o >> +obj-y += vpmu.o >> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o >> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o > > This code was moved from hvm/ to cpu/ for the specific reason of also > being used by PV guests. (Sadly the comments at the top weren't > corrected at that time.) Hmm, the init functions are prefixed with svm/vmx. Does vpmu depend on svm/vmx support? > >> --- a/xen/drivers/passthrough/Kconfig >> +++ b/xen/drivers/passthrough/Kconfig >> @@ -51,7 +51,7 @@ config AMD_IOMMU >> >> config INTEL_IOMMU >> bool "Intel VT-d" if EXPERT >> - depends on X86 >> + depends on X86 && INTEL_VMX >> default y >> help >> Enables I/O virtualization on platforms that implement the > > This is odd in three ways: For one PV domains (i.e. incl Dom0) also use > the IOMMU. And then earlier on there was a change of yours specifically > relaxing the connection between I/O and CPU virtualization. Plus > finally you make no similar change for AMD. I am planning to relax it as it is relevant only to posted interrupts (that's why there is no such a dependency for AMD). > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 13 16:42:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 16:42:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494751.764895 (Exim 4.92) (envelope-from ) id 1pRbtx-00062y-K4; Mon, 13 Feb 2023 16:42:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494751.764895; Mon, 13 Feb 2023 16:42:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbtx-00062r-Gm; Mon, 13 Feb 2023 16:42:01 +0000 Received: by outflank-mailman (input) for mailman id 494751; Mon, 13 Feb 2023 16:42:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbtw-00062l-2S for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 16:42:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7d00::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5493bb23-abbd-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 17:41:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7877.eurprd04.prod.outlook.com (2603:10a6:20b:2ad::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 16:41:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 16:41:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5493bb23-abbd-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1dJHAOzdDSdDwBlltThB2B3CuQgeFhnyhSo/gIEplAbagl+7daGO2Joel0oLbyE+yBA/Wz4XqayPoSM0BYBqNPsjBL4OZwmpUbYix51xQ/ZbcGHb1Oqo1711GjT23nMgNt9BP+crH9HvQmTBAfsoVdyfKiNeh6BPjLV9Zw5s+/7I2MF8uLZUMNJbQ1ZDEQ2oAatCnAth8gVlQvXEMobQRkdTFI3FU67wUj7OEaLvZ0c0lazbvU+7OzJj7x5ioztiH7/1WmY1XifuMX/gtTSBzsmbwKdXXZhWAtSwez5X8nO8SFi/l0iFNaVQHk62NzmQlGeDjXVK9lCZM1X4PQeHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CBWyEHL40bzC/0RUqJYebF16HgtCTqfgQ9Apk+RopvM=; b=MFUN1yM7sQH6GdaYkiHErYZ7PiOBu3uwLTYrY5aQR7N62vF5HYENy+KOXL5JguzT19+JJL43dsHIfq+c8V7gIQxQAvSoOOuZdxB7A5lIP13zstJFrAbyqBYKBqM5XWMaPbIsZzDcbaaFumsSbJg3Jyu5jI620TB/2TmbEs1cJg9cYhhpneQAcZ+9xej6qV5zktwB9nLDQiSVTPzFal0C8B3b8y9xbIrhATFi80aSHMTE53aFUoAfovm0THavFsMwAtwV51yIdDvUzY1LMT6w4Ug/bVpS90YW2K9XbNR7y+9ZYF6SAkvoRLpzHNA2GtYci2SYL6lG9Zd67pDwzI2xaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBWyEHL40bzC/0RUqJYebF16HgtCTqfgQ9Apk+RopvM=; b=YarVqM1yqlDvJBib0mM03+vFkZTnmtRy9VTpLx79Vc9UZaCpNfHemead4L49Q82LRUOg/SPw8HcZ5GxJ4FmN/tfPezkrqcBd5WHbgx6oVEQ3dEp+oIyo1/zAqbQQnnK7JE15gYda6VGHurqVAceiVJIECwzG544K/ejEI11U/vZrWDZUMViocCI5+8ixONMQI+NtfRSRqsbhfcy+M3afn11kDGI/g+MY6NpPGGEqr3GmHwu4HIgG8//kWeQdqrERFhpS585jr0dHPU/oYxjd/YU+rhtlFMI/cso/Tuxxpmq0NPt5IJhTRelajB4BLwrAPl/wCHp4P5G66gjlNDKspw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3cdfde6f-5af6-4044-f786-259c70e0ba69@suse.com> Date: Mon, 13 Feb 2023 17:41:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org, Boris Ostrovsky References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> From: Jan Beulich In-Reply-To: <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7877:EE_ X-MS-Office365-Filtering-Correlation-Id: d030e537-9b2b-4570-cf63-08db0de13723 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WOwj+MCoBgpLs4irR6pStE+L6CGKZTHqeiZgZhdhWRq0vn5iOw6QLGEVaaj87XpxuNnxUk5OltPxiPlfvRUD2a5O1qEVHCjxJcNNro9PGLW7unVkN0F/SCHYWJC6247Pv97QviS/5F/DVCCG+ksXT2C8K8E6+8d4qD4uJhF8DRIrst+t+lgIIfSCrQvtbL6vS9soYneLxfMUiiv/rNwtYt0Vl0mjDThqLJaV0vyGJ3lWSzw1rXy8tW3kPt+PLLCgIV9RMdpdMNj7KhRAkHwdPcntnTKxPdLvP/JF7k82HjISol1FaBJV5TOiUuUV3C4yZEgsi5mgKTi4nVnLI8t8aRfHVwZecUOqwWCWbApQrYU7WW7cXP4qOmLh5c1xGZtpUCS0M1/q9k5qeo6vQeox77CisV7aKlCt/w72QAfKi/1KV+LH6eE2EGzEUYqEvGLorHRh3IKkwKbfaDSGRcYRys93aVuy+lw5f4gegCvO3gSXPFTLyMVpBxLFx42qXbyDoWhnxliYMuw7VaK7N25EFpG528VQ9eyb/tgQmFwy6ujoUkqLIlkgeYl/m0JjusOyCth3cT2v/x+DErhaP0Q+T9ER1mi5C9NrGT9Zf+EZXuSyLmYFVuN5B2Ysx4eYawl7o5PNpplCxhYNYWKVjgokq+iDiFv6LboIkRf7nWrTbJRJ36iIA7t0zl9rKawCeF2PF5ySast1kCpB3wJL4yfNrVRMiIrjlcQIEZiBFNlO3f0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199018)(31686004)(2906002)(5660300002)(8936002)(4744005)(41300700001)(6916009)(4326008)(6486002)(36756003)(6666004)(186003)(66946007)(6512007)(53546011)(2616005)(6506007)(26005)(86362001)(31696002)(66556008)(478600001)(66476007)(8676002)(54906003)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXZOT2J3ME5GZGhSVlhOTG84L0FQZXpQMjlSdkVVYVI1d1MzTERleWhvT2p6?= =?utf-8?B?R28vS0w2QkowbS8zb2Q2bWtBWkRqdlNqdmt4NFRYMlI0SDlXRCtKK1FtcUtv?= =?utf-8?B?TS9JZVE4UU8raVlwVnBJdkVXcG5jU1lsMjhjc3BqODUrMmR2QTE0OHljUGpZ?= =?utf-8?B?THc4dmFWZ1NTNmx6TXhFQzYxRFdKZ2Q3QkpYR1lvNVUvYTQwUXlVRDZMZ3Zs?= =?utf-8?B?cU1oWnkrZ1ZkUll4RWlOc3FrSzhUNzJWUFh5dFJFd001Uk9NQnNQQzI0UWVF?= =?utf-8?B?elBwblFXaDd2cm9URDYvTXNlRDdEWU1LVVRKRUFzeWdaWjRNQThNMHg2Mk90?= =?utf-8?B?dDBQaWg3ejBOc0o1cktjT05xdjRkeENxMjhSV1RhR1VYWDdVQUNvYlI4MGV0?= =?utf-8?B?eW5xNk1uL3p0YWNJdVdpZSswR3JpRmZpQ0hreXQ5dncvU2RmVm1Ld1kzaG40?= =?utf-8?B?N2x0bDUwVlBwMnJKUXozVmx2OXFILzVLZU1ZOW9ic1ExUWUyZmUyMGU5WEFr?= =?utf-8?B?SmxOK0JGMXdXS05UNEZxbHkyZTk0QUFlcFo0VSt1RUd5eWZjdlJEVndoUjln?= =?utf-8?B?bzR6NDhlMWxxa3lEdTcrSlRnZXNhcUc1aWllMEd6dTZXVG9VQnN2ckFuZnFl?= =?utf-8?B?SGIreXVkWFpUVzZhOVJBakR5VmJjNWp0cXoyNHRhRGhLWS90Z3NzU2h5QVIw?= =?utf-8?B?dmp2Nk0vOUwwR25DVlZZNkFMdUlLVWpHK1hlaW0rZWdWQTNocGZOZFBOczhG?= =?utf-8?B?QnpGUy91cWk4TnBMTmVOQ1NLTFVaMGN3ZDZ6Y0l5YnRBbkNhK2VJZFdxQXhL?= =?utf-8?B?anhkejdXT0lYRjdQdlRGSDhkMnUzVXhqc0VoTDg3UlZLVG5INUdUZmpkeEhh?= =?utf-8?B?NmVnamlGQkpLQWk4TUFpTVBCbmFHbndBV3VLMkhHdkJ0UzJwN0FmbEJ3dHY4?= =?utf-8?B?RzlhTFRhYUpkc1Z4MXdqNUtiMmg3aVpzemx1QjNKeUc4ZkxVc2svalVkMUs2?= =?utf-8?B?bnlGTlVMQm5SamkxRUx0SG1xcWtXQmRrZnoyT01rUDVuck9GS2pLSXh3RDA5?= =?utf-8?B?eSs5MG41RUlscWI4YlZYQ0NDSXRtU0NzVzZtYVYraTJPY2JsQm96VjVJV1Nl?= =?utf-8?B?YW5uUGJTbGo5QnIrejlGUzRHMW5ubE1FcEN1bkxSQnFkaE9TU2JUUnBZZ0ZE?= =?utf-8?B?YWhwV0lNY1Rqa2Y2SVpEVkc2YmpKQXMvY08rRjIrMFVuZWRCMUJmdzYvT2tj?= =?utf-8?B?amZJbjNQbnFpRmp5cGFuR0ZheDc0S3psRUVoVW1ySy9tQmc2ck4xcCtQOFVF?= =?utf-8?B?WTVsS0FNdGNMZWkwMUhOa0hrQlVDNEl0MDkyWEs0VEZLaFlJMnhpTGZ2a3R4?= =?utf-8?B?K0NvNFFnK3dHYUVLM204bXJ6Y2NnUnJUaktTb20rbGlDeUx6bGc1cG9xckFr?= =?utf-8?B?Vm15WDRlbjVkWFFNU3QwZjQ3ckFQNld1U1N6WDBhd1NYY2UzK1dxMXhOa2dO?= =?utf-8?B?VE5uZ05sWTUvbkRLRXNQZTQ0N3NqekxnZ0UwUXBia3lwNWJEaHBJem00WWxO?= =?utf-8?B?ZHVWamhGaHhaTVFqNUE4eXBDUFp2MitaL3FqRFdLQ1VsZU1RcHBRM1g0S0xS?= =?utf-8?B?Zm9PbUU1UlpoNExWY0FOa2hsZkg3eDh6amd0OFVqdi94MWNsZHZrWk1DdVY4?= =?utf-8?B?MkRmWjNnZ0hSRjFkcXdpc3NvZUFIZEpTZkR2MjdoOVZtUUNWZy94aFVzYU83?= =?utf-8?B?bjBtOUdaL0VFVkgxcVZmRSt6V3FRSUFlRmkxRnlOOTg3TnYzdCtjb0o5Nzlw?= =?utf-8?B?dG5CS1BQa3J5TzhUWk5nVXR3MjFjYWo4VzNTbTlTQ0d1K1pHNkU2TWJhYTlD?= =?utf-8?B?NFN0QVJ1MmNRWkwva3Z0YnNOZFFUY0FUNU91eURieVpVMVdTTHp6eTh5N0pm?= =?utf-8?B?YTJmMmVSMmtGdWdCUElIUmdsYkdsOEVpd2pGWERBTVJiMnQwM3JORVpmME04?= =?utf-8?B?a3lHYlVDem5uN1NaOVlENGtKbG0xQjk0WXA1QXA3OGxaNzF1enozRllQaFpD?= =?utf-8?B?cUdXaGE1a1o3MHdjNkduYUZKczJyYzE1QXlHTjRmZThKNUd2a1ZNcmcrWnVw?= =?utf-8?Q?YbYpzlK4vVdFCRsWmi5sUx419?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d030e537-9b2b-4570-cf63-08db0de13723 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 16:41:55.2890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NXwxT1k4uS/v5sNycgnCDn8pZoz/QzqLneWnq7xccKiBiukX6ehlEoKOQVkza0fJhAvr0L321wIYZEOm1shhQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7877 On 13.02.2023 17:30, Xenia Ragiadakou wrote: > On 2/13/23 17:11, Jan Beulich wrote: >> On 13.02.2023 15:57, Xenia Ragiadakou wrote: >>> --- a/xen/arch/x86/cpu/Makefile >>> +++ b/xen/arch/x86/cpu/Makefile >>> @@ -10,4 +10,6 @@ obj-y += intel.o >>> obj-y += intel_cacheinfo.o >>> obj-y += mwait-idle.o >>> obj-y += shanghai.o >>> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o >>> +obj-y += vpmu.o >>> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o >>> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o >> >> This code was moved from hvm/ to cpu/ for the specific reason of also >> being used by PV guests. (Sadly the comments at the top weren't >> corrected at that time.) > > Hmm, the init functions are prefixed with svm/vmx. > Does vpmu depend on svm/vmx support? There are interactions, but I don't think there's a dependency. You may want to ask Boris (whom I have now added to Cc). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 16:48:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 16:48:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494758.764906 (Exim 4.92) (envelope-from ) id 1pRbzg-0006fr-7v; Mon, 13 Feb 2023 16:47:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494758.764906; Mon, 13 Feb 2023 16:47:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbzg-0006fk-53; Mon, 13 Feb 2023 16:47:56 +0000 Received: by outflank-mailman (input) for mailman id 494758; Mon, 13 Feb 2023 16:47:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRbze-0006fN-Ju for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 16:47:54 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2040.outbound.protection.outlook.com [40.107.13.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2897ed71-abbe-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 17:47:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7467.eurprd04.prod.outlook.com (2603:10a6:102:80::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 16:47:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 16:47:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2897ed71-abbe-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNI/oJCSxT6OmpDu2RWmfPEDG1QlAgbnaxDUTQUJVFEkWY8NcZA9rvrDC/nynup+g7Hb1scCmJwaek00i7cqGelUu1qS1Cuy3kVEJyJkgc6UBKeO2hP2SmT0Jyvu4G+8tMv3A1JBPqXVkCHxQrKc8NZzLYmGzTjWuk5ZGpCR+b9QdzcNuLgb22mmDiTJN4IxjQHfm/T9B776RTwks/l1m4IwXaak//4dCUzN+LidlvLLRHo3CF0aA5A2O3P4zmnb0JCtE9Agh6/V6Zho3b1yGdOf2T++FmSJ8+Rh9JB0iOXKYOybcLvz2kOTj+04n+EJi3Uk+I4rUBrAnceBxB59Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdrJ9L61zZ0PMSNiVVDrrcsKMclEyt21jp6M+ePmhk4=; b=gwjh3i/tUmPcOWFbqaIENUMU9l7q1ViO/nFBTNETksAoHgy/cHIXNpM9morfIyzTQ/LNjICQPvfbTUualrM338fYbKdCv3YH6CwchPgM9jyLeqJR+lnxQAs7o89PiWzBa7Ib/S6SVOYyW1TVaj3Q9VaWyFvcqTGPOkvk6gW1KlhPtrfOwd+J3wMaCf1QjgNTiuqAiKD2FSLXhP7Iv3KN/HZA0PnAbEw7Jx5Ieg/Byd+KIVXUWIQSDX7p+taXfbyvEF0awmLfBmSYR7UJ4kiUAW3LfLabb5V8u0VHtnNw3NjV7skcAMxDoMrksDEgsztit63Iq1LkfSNGCuLc+iyt0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdrJ9L61zZ0PMSNiVVDrrcsKMclEyt21jp6M+ePmhk4=; b=tC33Tihr67o29W7x7lGDvC7Gr8Px7Ynp3y1SmHI05xCWoGwThgTLyD5D0fjzfgChbqwTSSM+8tl4ePxpt2YEIlEfFCDGB9k0NoKvn29o4i7G4OS5Q7Z1jPau7Sx9rBi051OWccD4KJ+KKLVULqmzz0kkwxjbhQgh8UHMEuZfBGfgtCx12y2Tilf5Xgkx8nKo01sSeUbZpV56DSJbsQOoPsiN+eyvU58Bcthfo4L9Xij08nA/8HCaapHP3UtkhiD+j2cPAOzPSeoQ3ShCagqES/Z0HYSUrNK5fVsIW7iYRb/RBn8hqu9HJ+HeDBjWtzLSTN3UXWqDYYIItcpUWTi2BQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60b459c3-f81a-ecb4-35ff-76466a392db5@suse.com> Date: Mon, 13 Feb 2023 17:47:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 02/10] x86/hvm: separate AMD-V and Intel VT-x hvm_function_table initializers Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7467:EE_ X-MS-Office365-Filtering-Correlation-Id: 8eb75739-cb07-4b20-6e3b-08db0de1fbd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O1mNXyqdhQMAgAbVhSDNHkgzESuYHt8mIPRZ/yTqCXvvzwYn+xf+A0quJvzBe6aXQI70/IBR+6hHe3l3/nMBFgAcqf1KhYX9ycq18yHnH+LruKMz/bUYJqJGqdgDBEKgPnxviLZ7sm6rth+w8nPeDCKNmRyhRAi/Xg2vg2b/HDrq86zQNh4+b6bX3jgFrFI1n3G3N5nPBwiNsi9BsTUv4a58GcH/1U/Wo2x9CzO+cI2X7x4GB2PexneXQouCJXer9EQs/l3+W4Nwyc9xXU/Og2i3p13jBrumf50v0jKOQOIlUGLNv4uFfmw8rW4V8JE43Goz1TuxrNlamxKu3slbBvOS0/sec5ePzVCbIL29yD6CBdH/7HLb8pSMhvpqGWXKlGMzDVIn+OHl9wuZ92MdTRKLUZwABuXj36UxvEJxMzuxzDSUPpT6bhcDVfv1kLg4qnV2OqKxVtk4txHkZNLd5pm6PRk33Drn1E8gqGXoCYSLgl7DpmyX+EsGqikpbU/RnZ8w0pdm42WDmwKe3kniK5KovkLdNwkou0kWcGhwk6AoygqyGJxd52YvupA/kIlCw+sMoD5zWqatpJYijfsZavLBeLHWGsxDS2HPWzgBoztisBsfMZEO+/El4xxZkcRj6TW7QRLh7DBtFuoejZoXyNL5za9/zPdyhfWpSPEwre8UfL/1Qx0Y2vK9QSXr5enfVgb4t/kcik8l/+kcPdqvPUZp0JTqGq38S1jzpO4YGAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(346002)(396003)(366004)(39860400002)(451199018)(6486002)(478600001)(36756003)(38100700002)(31696002)(86362001)(26005)(2616005)(53546011)(186003)(6506007)(6512007)(54906003)(66556008)(66946007)(6916009)(5660300002)(66476007)(8676002)(316002)(41300700001)(4326008)(8936002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0p1djBhQTdzZlFFSG10YW9wUzVqV0w5eVZpNnFldVVIZlBDZzFIdUwvWjBp?= =?utf-8?B?SVJFOFNqMEg1WmRaRkFsWmRJeERBTjZnb0RiVG96M0FXSFQ3N1BsTVFvMGdY?= =?utf-8?B?TWN5SUYyK3JjOVFlM2gyY0RqY2Z4V3cwWGdDMHJhTUV4RmtlRkNDSE01dUxs?= =?utf-8?B?VUZxUkVjbXhINzZjdFAybjRycFZPNzhIZEZZR3BuNG40SXR0ZlM4THdxS0Jq?= =?utf-8?B?RFVjZHBRNWd0RGttc2JyYjF4Q1pjZGxrUzNOZDhvMHdhL0s2d0NMMXlQMUlI?= =?utf-8?B?QjR1NVZBSFBTZTByY3B1YmhCV1JHSU5tVzFwei81ckxGbXhvZDJNdEZkQUdp?= =?utf-8?B?SVZWS1Q2VDJ4OEp4QlZ4dnNuS1pmcEVPeUF1NFZSOWR2WGN6VS9SWHNHOUFm?= =?utf-8?B?dm9JaDAzQ3V2eU9KTUI2ODdQRGFjdEcyQnZaY2FGd3Q5YmdHNmR5MGRIR2lS?= =?utf-8?B?cGNGN3ppZVhQQVV3aEFTUkN4aHhNMHZQNUJTZ3lkN29HeVhURFRocnZiQ0hw?= =?utf-8?B?SjhTdjJ6Q3BFZkQ0Z2hUTnRHZVFtT1NJYjRDQ1laNUhsREhYVU9HL2VLdmlw?= =?utf-8?B?Mlk5RGE0eTJpa2w0NWJzcDNuTGo5RzN2aVBYMGFpRElkWlNwcklEQy9talUw?= =?utf-8?B?bVRTdjZmOGJ6VE8zWHN4WHlmclljYkpxc01OUkdhY1ZWM3NpTVN6ODZJbWx5?= =?utf-8?B?dGpqdFUyM2NIb0twUXB6RGN3a25hd0dqUzBpbCtsNC85UjN1SW15RFI3QUoz?= =?utf-8?B?ZkhyVExlNW9lSWFRV2wyN3hwVXI3R2pxVHdicWNRaDRQQmZvc2tSbEVRK0dn?= =?utf-8?B?MmdFWHBPOFVhMG5HZVdHUm81L3NjdXp1anUzMUpPYjBiVG1wbnFIYk9HdXAx?= =?utf-8?B?bHVHZHBJdzMzcEVXQm03M2NKQWlmcWdORk9URFlUR1ZFQ0t2MHltMm55TWIw?= =?utf-8?B?Tjl0TGlnbHFvc0M1cklkRkFBZGdTcFViVUV0Mzg3VGtXMjFZRllGQmIyK2NT?= =?utf-8?B?TjA4ZzRiR01PekhVWW81VG1FVUEyMGpKNExHNWNpU2tZZUZ5VHh3QWJXbmV3?= =?utf-8?B?WHRWK2piRlRzakdqMW4xOThRSStSbGZHZllCWDVtSkxCVW9GNHdmYWJyTlEr?= =?utf-8?B?bEg5MXljM0pmdnpWemphc01taFk2VGlTWTNOcU1vTUxtYkJGRTJFc1R1ajdz?= =?utf-8?B?bTR3aXByaXFDUXJEZXB2L1JvU2VxdEdsUWRvMGQ5TjJXSE1nVm1TbjBXbTU1?= =?utf-8?B?TVpPbDRqeU5RUzJRZEVaNGIxZlNIWXRTTzd6Q1AwbkUrLytBVEYzTDRqNHFk?= =?utf-8?B?MXNoUkYxRDNqWGxPSkFUZlNkZHJ1UnBHelc4S0s4SU84M3dxVnlkd1RNaWYx?= =?utf-8?B?dW1qRkNUWUxLZWZxYnAzZkpSZnVJemNQNFkxdFlpdkRib213NFZqWkxpMGhH?= =?utf-8?B?WkdVOVgwSHRhZFFpdnorWHpSSHBvaDJwVU05T2Z0OW03S283NHdyZ3A3MG0r?= =?utf-8?B?OE8xYzI0MUg4TWNFT2xBNHNkSG0wMXl1c3kxajNnZnJONkU5eXIyUjZGMDd3?= =?utf-8?B?OStIYWxvYjJDK3ovakhRSEU0V25EaURaTlhrSzJUVWdjRWFlMms3aXExZXNn?= =?utf-8?B?YXZFSEtJZHNNREdDZHhsbnBWTFJOMmp2aFA2Y1huZnJDb0U4OWFoNHM3bnFQ?= =?utf-8?B?OG1GNXVBOG5GeVFQNXdoRXpEOXp3cVRYWUIvdWRUTFRpMWd4eERpdmdJRER6?= =?utf-8?B?MUJ3T2RUcTgvYkZVK3hVNXJJZElnKzUyUlVoQjFxR1dWV2U3eGZwdjZXSzgx?= =?utf-8?B?ZEVXQm0yS0hKaHhITkxFUEhYYXRTSGNvODFKOHl5TGhmSDJueUVTWHcrV0Ro?= =?utf-8?B?dGxsK3c1anVGamVRalkrQlhodmcwUkdIbFFVSmVOUS9BUnY4OFFMNGZ6ZUN5?= =?utf-8?B?RTJ2akMvMnpNYUpjMkY1TlFOSFg2V2ZmWFprQ0V1YVpLZ0c4Vm1Td0NHN3da?= =?utf-8?B?U3FKMFh1NkhwOHRIN0QxaFo1eDI5Q25FeGl3TzNFOWl4dEpiNEZFWU9RNFVk?= =?utf-8?B?VnIyOG9vZTgzUEhFZlFDMTBXK2Jha2NRdkxjRFQ3eEM4dnRQQmpqSXd4amRJ?= =?utf-8?Q?N56JhDo3OHLuN+fCexgQ9RgtG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb75739-cb07-4b20-6e3b-08db0de1fbd0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 16:47:24.8163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TQc1UIz0hccNjM8BKOKRGYoF7Aiy9wh0pzXE5bnm3yGhOHqNnniw8bQ3NhmK9uxKKMVeUQaLgiOH0ihtOfw6tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7467 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/include/asm/hvm/hvm.h > +++ b/xen/arch/x86/include/asm/hvm/hvm.h > @@ -261,8 +261,16 @@ extern struct hvm_function_table hvm_funcs; > extern bool_t hvm_enabled; > extern s8 hvm_port80_allowed; > > +#ifdef CONFIG_AMD_SVM > extern const struct hvm_function_table *start_svm(void); > +#else > +static inline const struct hvm_function_table *start_svm(void) { return NULL; } > +#endif > +#ifdef CONFIG_INTEL_VMX > extern const struct hvm_function_table *start_vmx(void); > +#else > +static inline const struct hvm_function_table *start_vmx(void) { return NULL; } > +#endif > > int hvm_domain_initialise(struct domain *d, > const struct xen_domctl_createdomain *config); Instead of this (which I consider harder to read), may I suggest if ( IS_ENABLED(CONFIG_VMX) && cpu_has_vmx ) fns = start_vmx(); else if ( IS_ENABLED(CONFIG_SVM) && cpu_has_svm ) fns = start_svm(); in hvm_enable() instead (with DCE taking care of removing the dead calls)? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494764.764917 (Exim 4.92) (envelope-from ) id 1pRc7n-0008Gs-18; Mon, 13 Feb 2023 16:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494764.764917; Mon, 13 Feb 2023 16:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRc7m-0008Gl-UT; Mon, 13 Feb 2023 16:56:18 +0000 Received: by outflank-mailman (input) for mailman id 494764; Mon, 13 Feb 2023 16:56:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRc7l-0008Ge-0u for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 16:56:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 535fba3c-abbf-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 17:56:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8904.eurprd04.prod.outlook.com (2603:10a6:10:2e3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 16:55:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 16:55:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 535fba3c-abbf-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhJmU64giZB+grtDF7976FgwtAz3wTSji4EJpNGKsQ8F+YldGlqO0EMy3O0HT3LX16D8EOOdR3SHRagOhnrH7ylgUExEbBHX7Tunh6V3A/9pg7Oxwd/5dUUNG/si60mkHsaeyUfA//W621kkFxD3Q0WsecuKE9porWG696nLn8czwID4n7QnSeMFBH5JuNGgFD31lCi+jhzUidMrUC4GFQuFJTLgIXF/labljp4BJETkz44UmtyEgoZ388dR1EVxDeRz2sD6+jAH+XMCLnx5d8U4cxBnbUbL0Nz95D7CUzchZDsls1zYbKz7h3HkrLCQNIaa6d+E0Sng65KCVOOY7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JqhLLib1GKLw/+3JPpyq4zDc/2kFdwRU9iO3aoWRA6E=; b=O9nKIsiQqfVUJZELSI7qSEXQr+TfVgqymyviUESHyQDDUqN1uHQwc6rjwvNCji47pSVlcdPhaOIW234zWoYhUVFoHENeiOa4bPTN1A6FYdGG5qNibm/uvYZn6iHN0MbDcC9j8v/gWfFjYtG/oqgCNE/KD2kyldPSq5A9mR2kTzaSUwlR/bjIlAOftplWpFTViPbbZDB2YflhIDrZlaivQpWuBnPOGBfr8QLlLUp112db3RTMGzoDvFUOXt305BSsC4XTTI/j8AYmHXoPOKYhIP/frU9L2Krjamkai8SZlyF0IqD58OM9/G0C1HP8kgfUMyYSdKStogxu0RK/bERbxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JqhLLib1GKLw/+3JPpyq4zDc/2kFdwRU9iO3aoWRA6E=; b=oE7qcF/7OJ8IqnIpXUJTbSrappygbsiWppktitEx3W1CJ/J+uyfPGaEvLNatLYcznKfcQkUXd9idTRwl4/kZiHLd8KWEWxN2wTX7WUFU7UNIAm8CR4ZCbeol/A7JcUw/8O6DTTzlgx/HMotykBVyXHxYPlwzh8A6TBFmvZsgtjtGoMh5/J0yrampuBlwj5MK9A89VJde2xXMAcYf2ZG29x2kaVgsVAv7hlSZXUlabmiiTJySmykbmjo7Ea7s6CMXT7TrfDqm+EstrQevkmTmBK9jdG/v4hiSiC3IgHtp7bCd9gUQqrET7PL+v44mt6gEnTcN2q/wBUiUw52psHE7IA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 13 Feb 2023 17:55:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 03/10] x86/p2m: guard vmx specific ept functions with INTEL_VMX Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-4-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8904:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cb29f34-38d4-4611-4f13-08db0de3255a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 31h1V3cW9ns7RPZIW1HDWlGNTWn3n8h6m0MfM2gmXWiFX8to6GM5/dnFP/Bv8atrnr2A5baijDU+/K09nUVSUJK1Z/lA0TeDAK99ZHyuKcJUEHyRUqZWUuQSYCeFa1AvQ4gEH2rc48WJWYKFQJh3HaTXlk/AZV0wImcv2EHxxsNnd5aPI7eIiGb5D5i56KckM76KimHRP0jJrVIL6iAtgF2/AgGIBlekWD9kHLlzXycAVZ8eBgxSIv9498ed473f/XXhMYCUIgmQzxGh9OiH0+u4BXKpMlrz2vUfsZHlcPtLhzK7z8VMgX9RnGlS/33/KU6DDOvxG+kTpfDRKD7jgFTJx5pGUFp721PZ34DkP8R2h0T5n2zoU+Ffm6i+Jx44bI9zRh1RvTo1be6yAa+ragl3/vW7h1qEfOC1QzNLz9u3dYicDcOn1YGcqvuqDKJpR6AJTJukNtrYPUI52eXh+J0FR2HVRY7qm+q8KDyJ4jeAmKDCV0q2SArQSwWg3woj1VSu3cYs/P0S5jblwClS82p87G1aLozWUSSdDHm86M27qkz5dF2MqTrXeIqF3R19kfU9CRljm6YcypdigTZSOSn6BN6Af2ZXl+gnLYr/HF+sJU1yhfZRa/D44nkKaXdTakXxk06s3MvPNAQYdIivBdI1PT7rPLqx11HXIVBhrQWKsjomfJSuSMs8W2ACS2nSE4AdUpOGp1sxZ/qsK4VOjaMXXf45D9r9ROtFd8Xm7qo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199018)(31686004)(2906002)(5660300002)(8936002)(4744005)(41300700001)(6916009)(4326008)(6486002)(36756003)(6666004)(186003)(66946007)(6512007)(53546011)(2616005)(6506007)(26005)(86362001)(31696002)(66556008)(478600001)(66476007)(8676002)(54906003)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVBNOUxoaCtoVlhpeGI0a1FRWXYvaWRqR2hpMjJrYkE5cVdLWkRYTGMrR0dB?= =?utf-8?B?ckhiekFYUmlQcFYzNVlJY21mODdHYzJIc1B3aUsrVm5WWFI5UGp0NjFIMkNO?= =?utf-8?B?MG1YK2E5YVRhZG9EcXMwWW5pOTFQNDhiUDdNT1RCdVJ5UExvRW5nT2hQbU4w?= =?utf-8?B?V2I3SDRQRnZsWERid0IwZFR0d1ZHNlhsR0M4TW1zTC9BbUNld0Y4c0FJYWJJ?= =?utf-8?B?RmFIV0tGTHUzc1NQK2w4ck9kOW1QaURCRU9rbjdqcDJhbnhsOUIrc2paaXhw?= =?utf-8?B?T055VXFkc1RyRE9MS29MdzRYUkN0TEtrK0lnTXhPL3N1UUdkTW1IeFFYUzJi?= =?utf-8?B?VU5pZEczNWxxeEtQYk1IQlF6cFl0N3FzZHJ2cldUTjY4M3VINjBxb1RVYWJZ?= =?utf-8?B?UHNmN0FlMU1QVU9XLzhTSUpLd0t3bHhyOGxzM3BvUHVFU2ovU2duY05JUEZS?= =?utf-8?B?Uk1rcWFQWmVuS240UVpHeWJQaythUzdsZUxyTDVvYy9WeXFnZ2dKRVRLN0Ir?= =?utf-8?B?R1k1MHd2VnJWTm94U1d4QUJ0ODcwOE5WK1VKNW1TSGFscllOemMzazFYdTR3?= =?utf-8?B?cy9aNUlVZjUwYVUzayt5UVVVeS9aVlR3V0huU0krQ2tKS290dUhOTk95YU1S?= =?utf-8?B?MWlqV2hDUS83Q0RuT1RYTWkwd2xCdVhKUnBLMi9nYmlmVWNsQ2NVaFRNV05w?= =?utf-8?B?dlR6eWZOY05mT1QrMmZ1MVdQTGlSV2FSbVFUclJhbFkwMGZwWnNNZmhBT0Na?= =?utf-8?B?RWx0MFVJVmlpS1FaNEJVWEdieExpOWpwYzVadEZRNnN6ZkYwazN1cHFrTFg0?= =?utf-8?B?QmVIallMbG0xMDNoUDE0NHlFK2RPSDk4WlF5dkRHbWJkeGlDM0hmRjNVTktE?= =?utf-8?B?VUZqN0FzSGl1M3VqbDlZakpPbjhyV0FCZDJiT1paY00vSzQ1bG15UE9Nckd2?= =?utf-8?B?WnVRM0ZZNncxWU5senZVZ04rK0QvYm9MVFFjeVI5bXhxb1FUUzBvQTZOSksy?= =?utf-8?B?b0MzN2lKU29MNUpBUjZzOVYxeTBOQzhQMGtNeGliUXhWU0drbWgzUHdzbEdI?= =?utf-8?B?aGsyQmkzUHdVNHpzNnRHd0YyV291ZVp0QVkwT01KZlF4aDBzenhsdE55Qyto?= =?utf-8?B?cC9IMldmQS9rUElCYzZhUjZIaWI1cDdKTm41UHk4UE1tYjJRVkZwS2JPT1lB?= =?utf-8?B?dDRHS1kwR0pzUWNMUC9scFFKUnRHK0F2OFVmY1lsUjM1ZEJscFVhTC9GZFdU?= =?utf-8?B?QWVUcjY5alJLK1UwZmtZUXZnTHdNazFTa25rL2lOcjcyaXNrSldSWlROKzN6?= =?utf-8?B?dVhXVDRXZ2E5Y0c3TExtbFh4NGcxbHRaQnhWS3RyY2k5cDhkQVlXYVM1UzEz?= =?utf-8?B?MHpXNWc3RTRMSVdmS1QvZjhFdE14QllldGpjcUV4dk5kM1BWelI2dmVtUWdi?= =?utf-8?B?czBOTlUrQlR0TWZwZTFhbW4vY20vV3h1cnN5bHdCMS9hZnBOdysyMjNyT0VS?= =?utf-8?B?c1ZWeFZnN3hUT0hvVnZkN3Q0NDBOWENCNGJVNzErTktqUlpoMUM0K2pHYWVq?= =?utf-8?B?WkI5aFlaZWFXeTJ2ajl1V3VkSUY0Y2NyNlhtUFRjT05DOFA5RzEvRkplOVRH?= =?utf-8?B?TGdBT1EwRWdwaWNvYnFUdTU1TDhldW54T1JJZ2lFdGpyZnlSMURhUE1yaUlO?= =?utf-8?B?eGlwVXE5Smh3VUhGbVlYUGRjUFQ2Y0pXTlA0Q3Y3MVJSa25adnpQTncxQWEv?= =?utf-8?B?aTR0dW5BbFl2YWVCS2g4ZWlzTHRqQkZZcVlGbVV0dUQyWFkvbzlQQ0M3SFBo?= =?utf-8?B?TytCS3RZbXo1cmwvbXNHcmVhWHQyNWZzQTdZRElRUVVBUkd5TnNhbTNBeXlU?= =?utf-8?B?Mml5cXNPbVZoSjJvbnNjbWFiMEtjeklKZ1VwczEwWlRCWmRDSDdFTnZQekRW?= =?utf-8?B?SXJqZ1EzeXoxSVVIak5OV0N0S0lXcFUxaXNSZllrM3B6MDU3RC9QWGtkeVRx?= =?utf-8?B?OXVGbWlZV3lyRXpFTkFuV1RtQ0tEUW5QMlJpZ3dCR0VrNW9lc2FQWEo2dDRJ?= =?utf-8?B?enI4K010dTdBbnRqUlNsdEp3SHZFc0FtbkkvU2xUSnRndFNTbk5MRDVtbnlW?= =?utf-8?Q?H4SiUtB8lV4+yDqZHOCU3A80M?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb29f34-38d4-4611-4f13-08db0de3255a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 16:55:44.0969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iu2fenuSyA/JlkzDRce+r72ibFWUG5FkfsogeD/qd1IztXGkhwG/iHHpC8Ml0Ol3/GWArnkIklOA2VVhP+fiaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8904 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/mm/p2m.h > +++ b/xen/arch/x86/mm/p2m.h > @@ -35,9 +35,25 @@ void p2m_nestedp2m_init(struct p2m_domain *p2m); > int p2m_init_nestedp2m(struct domain *d); > void p2m_teardown_nestedp2m(struct domain *d); > > +#ifdef CONFIG_INTEL_VMX > int ept_p2m_init(struct p2m_domain *p2m); > void ept_p2m_uninit(struct p2m_domain *p2m); For the calls from p2m_initialise() and p2m_free_one() see my reply to patch 2. For the calls from altp2m functions, including ... > void p2m_init_altp2m_ept(struct domain *d, unsigned int i); ... to this one, I think you want to be more rigorous and hide much (most?) of altp2m altogether when !VMX. (It is perhaps high time for more of that code to move from p2m.c to altp2m.c, and altp2m.c then, if it doesn't already, to become dependent on VMX somewhere in the Makefile in your series.) Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 13 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494765.764928 (Exim 4.92) (envelope-from ) id 1pRc7v-00008y-BO; Mon, 13 Feb 2023 16:56:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494765.764928; Mon, 13 Feb 2023 16:56:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRc7v-00008p-8c; Mon, 13 Feb 2023 16:56:27 +0000 Received: by outflank-mailman (input) for mailman id 494765; Mon, 13 Feb 2023 16:56:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRc7u-00008A-K3 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 16:56:26 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57ef0b10-abbf-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 17:56:24 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57ef0b10-abbf-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676307385; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cefmvFjE/gB5Sf8lLJBVMjAL+tUgN04ZmfQbRRZBImA=; b=IjZxKB4Szo2v3lIreDCjNSI37M8CmLyT8mFr8wJZckfjrZ8L7Onxj2Kf 8NdYCfq9zSfIt7iUfOxBMLt7kyYyhHbeat238dGsSGt/kb/00x20CKNgm YrWn2a7EqNwBwPgMq5GesMVpkYMCQk75V2wBi4kJV2DwDI4n36QyWCr8G 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95691000 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:d+14/avRwO/DMT9SuSqvZjkvHOfnVGleMUV32f8akzHdYApBsoF/q tZmKTiObq7bNjOgfIsnbdnn9U5Vvp7Vz95hT1E9+3o0EHwQ+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWHzCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwJS02cDDevvuPz7udc8hHvNwcPeXSI9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7Wydfs0nToaM47nLMxQh1+LPsLMDUapqBQsA9ckOw9 z+Yrj2hWkly2Nq32H3e4iOrxfDzrybWW4cDT7iG9OxXnwjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vrGDhuvbu9WX+bsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5e/LWd14OvX2uqm nbT8XZ43u9I5SIW60ml1V3auCyM+6HQdwE8wDz2dVi90RJVXZHwMuRE9mPnxfpHKY+YSHyIs 34Fh9WS4YgyMH2dqMCeaL5TRe/0vp5pJBWZ2AcyRMd5q1xB7lb5JehtDCdCyFCF2yruURvge wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiONLKigbArLmdrGR2CgmbOt10BaGB2zckC1 W6zKK5A90oyB6V91yaRTOwAy7ItzS1W7TqNGs6hlUr4juDOPiL9pVI53LymNL1R0U95iF+Nr 4Y32zWilX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClMOJY3VMNeImelJU9U8z8xoehLgo inVtrlwlACu2hUq6GyiNhheVV8Ydcwu8yNqY3R8YwjANrpKSd/H0ZrzvqAfJdEPnNGPB9YvJ xXZU61s2shydwk= IronPort-HdrOrdr: A9a23:own0Bq981zAuqfRirZluk+DeI+orL9Y04lQ7vn2ZLiYlFPBw9v re+8jzsCWetN9/Yh8dcLy7WZVoI0mslqKdkLNhWItKNTOO0AeVxa5ZgrcKqAeQeREWmNQ86U 8pG5IVNDW7ZWIWsS5xijPId+od/A== X-IronPort-AV: E=Sophos;i="5.97,294,1669093200"; d="scan'208";a="95691000" From: Ross Lagerwall To: CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Ross Lagerwall Subject: [PATCH v2] build: Make FILE symbol paths consistent Date: Mon, 13 Feb 2023 16:55:39 +0000 Message-ID: <20230213165539.3257260-1-ross.lagerwall@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The FILE symbols in out-of-tree builds may be either a relative path to the object dir or an absolute path depending on how the build is invoked. Fix the paths for C files so that they are consistent with in-tree builds - the path is relative to the "xen" directory (e.g. common/irq.c). This fixes livepatch builds when the original Xen build was out-of-tree since livepatch-build always does in-tree builds. Note that this doesn't fix the behaviour for Clang < 6 which always embeds full paths. Fixes: 7115fa562fe7 ("build: adding out-of-tree support to the xen build") Signed-off-by: Ross Lagerwall --- In v2: * Adjust commit description. * Rename rel_path. xen/Rules.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 70b7489ea8..d6b7cec0a8 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -228,8 +228,9 @@ quiet_cmd_cc_o_c = CC $@ ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y) cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@ ifneq ($(CONFIG_CC_IS_CLANG)$(call clang-ifversion,-lt,600,y),yy) + rel-path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1))) cmd_objcopy_fix_sym = \ - $(OBJCOPY) --redefine-sym $( Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 17:19:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494778.764939 (Exim 4.92) (envelope-from ) id 1pRcTk-0003LT-5K; Mon, 13 Feb 2023 17:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494778.764939; Mon, 13 Feb 2023 17:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRcTk-0003LM-2h; Mon, 13 Feb 2023 17:19:00 +0000 Received: by outflank-mailman (input) for mailman id 494778; Mon, 13 Feb 2023 17:18:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRcTj-0003L7-12 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 17:18:59 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f7957f8-abc2-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 18:18:57 +0100 (CET) Received: by mail-ej1-x62c.google.com with SMTP id n10so6700721ejc.4 for ; Mon, 13 Feb 2023 09:18:57 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.139.tellas.gr. [109.242.139.89]) by smtp.gmail.com with ESMTPSA id g22-20020a170906199600b0087bd629e9e4sm7071403ejd.179.2023.02.13.09.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 09:18:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f7957f8-abc2-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RetJnbAkXuIXXMbuAB91Lo14JxtS+jzS2wxOg+0VJoE=; b=V8EeUz6rTIB1nirL8CXtJgjCW3ub5IYdkBtO+SlxTek47Mx2LZ3+74GPHC8gEhJQmM fAOeA0mYZo3b2iAgXFAlRYjiY2kdLo4rD9A4Lwn9rSFFFzxataFzIbBYsowRMNolr9IX VdTG5VszmWJHifRyoZRhCkCPtdXUaXUrIExZYPaTlfNBzy4avrJ/ROTJ073Jz6VauHdC TRa1yj9BqZaXuvamw1AIELeGhUdEaFOp5oMoJZSe8uE7Zi9cnPVTauXjwXClzARz8pbQ Y0LUYp2RCzOsafFhLFGlIKKZ6sBJT2TAo8M4Fht8+tB2luutq+IMWIKW8mYO+9dFjBeV i9qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RetJnbAkXuIXXMbuAB91Lo14JxtS+jzS2wxOg+0VJoE=; b=TStIeHk0/gsevG5X6uSTeQ/xTi4eUkYs0noI4FIw7m/0hUG6N0Yz4Zc1Zw+oH9od4I NPLXniUlTEoPLn1E3wBM5PfYWt1/m2UKfeoOHuovl7/+eQdpE3wSFmFxAQ9qWi9qNmRQ eDkW8uQ5GIE/s+lQfXfKo//w9FOG8/8Aw1G/iNWzVADHEO+mDyqmxAe7c7jcCWry7+cs oOuY2r7Lj3nMpgC7xHrXICD27uxw/vDwHjIdFX6GXMbcMwIOG6ht1JlA68T1GTyDt8EN gk89+bJrGIvmQBdCtkeifxemXxy6qU4kFrkmuuqOU2TqeCBApk59RS3VjJEkPA0Xi7+V LaUQ== X-Gm-Message-State: AO0yUKWAIx/3o+wXG12Aafx7wZq/naLF14OQeD2kJa2lV3KDnkoJKLND HnImcccLxDqyf6rQcyDDu38= X-Google-Smtp-Source: AK7set+c0lKs4ZC91Oj6WTxdetARCvhy/B1YN9rC0n3zZEYCEvFBGPQrwl8cQKR6sIjOd1ozSy8XeQ== X-Received: by 2002:a17:906:584:b0:888:6294:a1fa with SMTP id 4-20020a170906058400b008886294a1famr25338715ejn.14.1676308736678; Mon, 13 Feb 2023 09:18:56 -0800 (PST) Message-ID: <27df9808-b206-7cbe-7075-f4b04d22b87b@gmail.com> Date: Mon, 13 Feb 2023 19:18:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC 02/10] x86/hvm: separate AMD-V and Intel VT-x hvm_function_table initializers Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-3-burzalodowa@gmail.com> <60b459c3-f81a-ecb4-35ff-76466a392db5@suse.com> From: Xenia Ragiadakou In-Reply-To: <60b459c3-f81a-ecb4-35ff-76466a392db5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/13/23 18:47, Jan Beulich wrote: > On 13.02.2023 15:57, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/include/asm/hvm/hvm.h >> +++ b/xen/arch/x86/include/asm/hvm/hvm.h >> @@ -261,8 +261,16 @@ extern struct hvm_function_table hvm_funcs; >> extern bool_t hvm_enabled; >> extern s8 hvm_port80_allowed; >> >> +#ifdef CONFIG_AMD_SVM >> extern const struct hvm_function_table *start_svm(void); >> +#else >> +static inline const struct hvm_function_table *start_svm(void) { return NULL; } >> +#endif >> +#ifdef CONFIG_INTEL_VMX >> extern const struct hvm_function_table *start_vmx(void); >> +#else >> +static inline const struct hvm_function_table *start_vmx(void) { return NULL; } >> +#endif >> >> int hvm_domain_initialise(struct domain *d, >> const struct xen_domctl_createdomain *config); > > Instead of this (which I consider harder to read), may I suggest > > if ( IS_ENABLED(CONFIG_VMX) && cpu_has_vmx ) > fns = start_vmx(); > else if ( IS_ENABLED(CONFIG_SVM) && cpu_has_svm ) > fns = start_svm(); > > in hvm_enable() instead (with DCE taking care of removing the dead > calls)? Sure, it looks much better this way. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 13 17:37:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 17:37:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494794.764950 (Exim 4.92) (envelope-from ) id 1pRckw-00065D-L1; Mon, 13 Feb 2023 17:36:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494794.764950; Mon, 13 Feb 2023 17:36:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRckw-000656-Hg; Mon, 13 Feb 2023 17:36:46 +0000 Received: by outflank-mailman (input) for mailman id 494794; Mon, 13 Feb 2023 17:36:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRcku-000650-VN for xen-devel@lists.xen.org; Mon, 13 Feb 2023 17:36:45 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa24421e-abc4-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 18:36:43 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Feb 2023 12:36:30 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by BL1PR03MB6006.namprd03.prod.outlook.com (2603:10b6:208:313::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.20; Mon, 13 Feb 2023 17:36:27 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%6]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 17:36:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa24421e-abc4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676309803; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AyQStQMTYZQYv61QHCzNSv+Fhs5sThs+hE8iRJ2zWgI=; b=YvslsW06jlZfTvc+KOqBrMKyQ7R8TFpxjaxJf9+Gr95Sxdw0ijEbQcnY SrQLxmZhuTyq4FilkYNLdSr+gVXYyZJR7QokhI4fWMyDMrvtxkABMb0L0 ki3bFp+VaQQH8zmUcOJxTCWk/h2ljiSBsTFX0tDLfgWFzN/iT5LfUuKjn U=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 96245372 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HqOA0aORkpYkiAnvrR2MlsFynXyQoLVcMsEvi/4bfWQNrUorgmNTn zZJCjqOOvaJZmD2e4snPI6x9kNX75bVmtZjSgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wdmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rhVI31Wz NMZEz4AVTGqu9+kg/G9WMA506zPLOGzVG8ekldJ6GiDSNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujeIpOBy+OGF3N79YNuRXoNRl0mVv H3P+2DRCRAGLt2PjzGC9xpAg8eew3mnBdlNTtVU8NZprHyp9mg2FiFJFmWLoOWBzVbma/h2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmOzazO6grfGWkATRZGctUtsMJwTjsvv neZktWsCTFxvbm9TXOG6qzSvT60fy8PIgc/iTQsSAIE55zpptE1hxeWFNJ7Svfq1ZvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzt56s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:jaGOS6wdvhRt9+YvBjlzKrPxVeskLtp133Aq2lEZdPWaSL3+qy nIpoVl6faQslkssR4b6Km90Ze7MDzhHPJOkOws1PKZLXPbUIXBFvAo0WPNqweQVhEW3NQtnJ uJSsBFeZfN5bITt7e33ODAKadp/DDlytHVuQ6h9QYUcegwUdAX0+4RMG/yeScaKHglOXcgLu vj2iMEnUvcRZ05VLX0OpBvZZmkmzSkruODXfbGbyRXnDVmTgnI1Fc5KXalN9slMw+nuY1Sil QsHGTCl9KeWjiAu3zh/l6W1Y1fnO3owMZCAsvksLlhFhzczjywbIBWULWY1QpF092H2RIRid HJlQwtJsJp9hrqDxOIiCqo4RDp1AA14Xn4xTaj8AveiP28fiszD/xaj4RDfi3Y7FdIhqAM7J 52 X-IronPort-AV: E=Sophos;i="5.97,294,1669093200"; d="scan'208";a="96245372" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEW5C2R+Ry/p1kf9lf0a5vypWxGPB2AvmEqexkUiKlLqiFtSwdxdHsg8krLjJPVhc+2n7PaJ9Uu9oLo3Qu/f838xUO3SGLiuTdqMNxPa9XdlKyQaR6ZpVOQrc/un62zTlN5j5Os+djRl/z6/x3CjlqFVEDjSXFmxm9E80PviVIaQS7UN7TEpn2UBrJAfukjSx+ABH70TEad1xs6PzFbcqFQr7RdXkoIMMc7g2RaGAO36A76xI31mjgdHdtHNwGbelDmn1kyaLPsqjfZNeaPIDvDkAZkDPu3fzkvuWNQpVvEjbBdDOKPHb4H2mx7CQk68Crj420S7gOHBRZkcyR+HwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AyQStQMTYZQYv61QHCzNSv+Fhs5sThs+hE8iRJ2zWgI=; b=gFlg2BlJkGQfLWPaKYqmKP5C/kFr8Z84yBvlZ3Byhx2p0ydr0IRiechnxEakdaaxG22uhbO8S2U9dz2tQn8e2+MwPexfRuDEW5vIURQNrThBbA1X/wDIxsrh2/kjpzwWE18Ta4brsCtVan9M7VyslWbYqQZuXoNIj/n0lB/K5nnJDH9WvSVAI6Xi92UoR/A1GoFxE14z5xR1TEJE+YWV9W0EQVF92sLaF74dfEaFmBH+NyciL23bkz2TO532xaptahn9LXnv3yTcWblWy33Dl3ONh+sLxzXRls5zQwr7CMRtOREQ3WeINQ17EzCpmB1iefEs99ql5YmNZAPjNacqFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AyQStQMTYZQYv61QHCzNSv+Fhs5sThs+hE8iRJ2zWgI=; b=AOE9AjesBr2l7sZMTDkmInFX4bkTIOxZDL0NUw2gz+S0OzWXYk3yiuUxFzKQns8p1S+G01LER7jeNQemReuqLWNx8CkWj8KDer8qEquutsJqjf3+pnCxOXdjt7kxDTMaoyCUvRse/HVjCMVP8Z/GOXYP6bwPOHoyfhSMy+Ye3NY= From: Ross Lagerwall To: Jan Beulich CC: Konrad Rzeszutek Wilk , Andrew Cooper , Sergey Dyasli , "xen-devel@lists.xen.org" Subject: Re: [PATCH] create-diff-object: Handle missing secsym for debug sections Thread-Topic: [PATCH] create-diff-object: Handle missing secsym for debug sections Thread-Index: AQHZO+fsA+Vod/BpQUimyPUcdwpK1K7GTlEAgAbcoZ4= Date: Mon, 13 Feb 2023 17:36:26 +0000 Message-ID: References: <20230208180457.800671-1-ross.lagerwall@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|BL1PR03MB6006:EE_ x-ms-office365-filtering-correlation-id: 53fcb2ae-0459-4836-bb02-08db0de8d586 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /hm5uAT2YeWu3NDUrJSBGOZASZt9kuh3uBXKs4gAAwBiMtwqeORtLVdROUp1RSQiX9WlmL/t+nfXDL86fAQaV/wJ+HeI31DvxF4JM6aoLX/zTNZxM7tCEVY5jD9Vum5anFSxwUsrFdTjzw+GCA2ptNzF9HSFhQI6xDdIOzPQL68fYHbWeU5yQ/uIGY0CIJz4TJe3h6lXNvpP4eEWBuwXpJ/O9otwhjOoElw2GBggVSEAVk+42KWuX9qBARCtGiiuz4464AH4snwDQolLtX1bRuB6+nAC0JkI7CZ/U5aPSziGUbATwuiSHBpTFdBrayisJEAzr2uYiZpuiXDAukh2QX7YAAembJc8c3LshrtnrgGnbmUcruQLk6ibSieZki8bnnX1c5BjyS//dubA5vFPOCkFCARvyfo5/lrtvugf45ojdWmLmqC6+m1Q4LZu6mEQ/IowjnQp06Hye1pDSiCJgM1bEAqOvRc8p6K11u9XvtfjBIaMOiYcwBsScExPcbS3SSsl2MLRCFCYNj7ftC5J8RzbP7Xtlq4Egv2GuB8FcXJlboTsWfy730AXQZwyghYaJo8gLJVgoQBriDQu7wqBfx1DlS2q0llg8bl8hCgbkGDmwrWbRsFfab4Tk0UAmyALfPzSc9n5Iq1fS86Z8t41xx41g77b3aOj3UP3aJ0ed4d38BZ3wJ0oEmkPrLo+TBjRmqi1zCmr8E5aEuz3yUr/2w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199018)(44832011)(54906003)(122000001)(82960400001)(86362001)(38100700002)(2906002)(38070700005)(33656002)(66556008)(8676002)(4326008)(91956017)(52536014)(64756008)(6916009)(66946007)(316002)(41300700001)(66446008)(76116006)(66476007)(7696005)(55016003)(5660300002)(4744005)(186003)(9686003)(26005)(478600001)(71200400001)(8936002)(6506007)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?qp9fKNw4BNlCdhtOG1ok9AOeOEtwXWbzlvc2WOO+A8KoW19d3xHrTvgmDv?= =?iso-8859-1?Q?175ArDxyeqxa+cyhYigUXynytbh4wXgGdbixHd0qMbInOfkcjVdd8S2KWe?= =?iso-8859-1?Q?Fr1HqVqFGjWWtchLUj6gbztuwJS187QwVZUZDnD6zCW70aDfYD9VxEL0d8?= =?iso-8859-1?Q?PghAJbJTEjRe3bsT+cjIhInoxFq+cSxMsvbfNB+LzNZNQuPmEHTN4CtG/L?= =?iso-8859-1?Q?coKy7CmLbBzNWfEEot+QTMxQ39k1lroC0bCrZyPt+Gqu1pYfUULVBIHGWa?= =?iso-8859-1?Q?nF9LRRKa5uV+5rp5XSBWKU3W7AIMwo3D8bOED8QnFvl3K2mrY8GYD2SNk1?= =?iso-8859-1?Q?ppGrcCzSEMrn7WcckbIfXJycKcf3KwHQqu5FJLEM/613/0xC3oGmxOShS2?= =?iso-8859-1?Q?MObed7ucbMbm9y3EPBOv0HjDQj1f3kZ51YZJzgwleCsWugBGmUi9HNBBDy?= =?iso-8859-1?Q?44CSZG8/olPDK205pp8+SoeXYTjyEm3T3F+xsHWZ0QBUIfwYWyStqUwDHc?= =?iso-8859-1?Q?SBGfI3mwPQ8t+pyl3FEXhNqV+MB8fvDRv+8GogKLqRYPFos+qPoL1iDze5?= =?iso-8859-1?Q?GB1dgSw2IeWbZdI5AkPcaXx7BEG03hj3BrIEY57yWlWSpPiJy+rpe/ih4h?= =?iso-8859-1?Q?2PJ29UfzaPQx29nUAvq7djBh+rpgeS+fMSV7iyk6Hogvz8dTiBiEhtK93V?= =?iso-8859-1?Q?scvo+CoF3vjnnzqL2QaNGmk3q/mSsKGo7uVhgFL4dwOROqPMIweDzXnCik?= =?iso-8859-1?Q?CjKzcv/3fC0lFQVBy5/40ftqDySo3laWNm1EJDSvMjYDac4Gb4JhzCXZ9+?= =?iso-8859-1?Q?fO0MS8wcjxzlJsFXYbzwmmdvklPMrsdMK3hGWELGKso2xznMhHvfFsw4tx?= =?iso-8859-1?Q?c++eE0X2tPQIo2kGFweMUuuYB7wDwdb0ErTXrzdW6R+NTWXAl2NT8sFcsM?= =?iso-8859-1?Q?jeLhjtcZGp1wkx1NYxY9e9cYFWsboQwG8CodnKz5pLLFhz9Vpfyol315mJ?= =?iso-8859-1?Q?dm2XxcNCoXUHOzCo7/ljUinzrUYsrjMPU26KTop0s6Mp/bgBJfPw1a2xC/?= =?iso-8859-1?Q?pEjR4JBT7MyuAAPKxZr+oYhzEZ43uFscLK30AaohyTsW9ZDv+FBoBfnI8v?= =?iso-8859-1?Q?E4zsT+jDk1mvtM/lF/jFXViNZVwaqNLEAIoo/LMmeMG7Ej9W3kv7TVKJDv?= =?iso-8859-1?Q?XcpahbPICMrDQ6DUstFxR+8BaMb4qsFYzx8MJ2AAVt7W79jlzWkkWsT5Lm?= =?iso-8859-1?Q?G7mADw+49lMCX+RH2Hk7l3kI9ROoemfN3IXRS3WYokZMvbv9fPWF0pK0K4?= =?iso-8859-1?Q?klMu88578bnRjkeoFkUSKdPgCxhW0Lydxy57JEj+WXcUAIbzPiaZfwNtr5?= =?iso-8859-1?Q?oY+G30Q9pM5+idyvAkAiXt4FIIcAbZwKJhcyUhJZD9CrwRHQufPlWbHpd9?= =?iso-8859-1?Q?CALJNyleXIikCG1JoDWNLKHwkrkz7pcWEQsAHLTtSgQ1+DQR5HcYqQ81Ns?= =?iso-8859-1?Q?cuSZwbr4LmLtMU/ldBkvb4nYTzUEeJfO90XqJugkoWR1GDSBloW6eRvgQK?= =?iso-8859-1?Q?uHqR7LNz+5lKpHSXxLn3SeXGZDJk7SljvC5G9NrLvixQ5bF0NlsjzvHUBK?= =?iso-8859-1?Q?x8Tx26I+oQgWfq4MAGHrWI2dJcSP5B5gct?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hWxSnyf77URvht0oc7jZkaEonM4oX1D/8B08a7w1RVRQlBew2kM9sGQbuSTfBGbwK7riOxN4JZe6jr0Caqms0N9hb/JBVNFNGab+REgzG5CQH9WFiVr4cLp0jBBOXvYPidpwwlfR/RquyTI0sw7mpm17RaKLuc8FMtmyXIEjrQcLwadVQiUD9rWGVTNQEwc5cFRlJ3mP83pnOpaS9kNHgDh9xWhGtmnfzr6yS+gZAVqRFSzz/+XpMDmVVq/z8+XtGIJr4PRRPAH0U8rJV3f6kdE04JZGipdRMW0XPqk4Z7enZ1xkm1uS3byCz2wT7y4FdTxwVkOU8H5c9CfZBAdJkaZa1n1iHbp7TIcsoK3UYi7QV0vG4WKZbJrB1kTCTCc5DehrEEcpt8jZ8iY0Eq3r4/PPoUpNB3TCAK+kZlUQ5U2sF1nHwObUB58eUDY/jhJ1wbfTfSU051scMSZYiE9PbAy7ACcMqiatPAKzDpzeAsHZ70TGLA1gCj5B/DJxo1NW4GZHWkKbM+0SiAYnfR9ojSzRLs0Y4KutOF3oNK9G25UAXzGa71ZynBp9fIPp2Us2L5DiBhkIvm9e4oTVCmuhBAhdx7VHX0WXfXBMV5dgUBFzwOqoKyoDRk6q9nPSxz5sfkq8Ou0js8WLvdRgmI/aMO960Y5oyrler3L6lQv1btWPeqLtM8bZbaHSwlwozdCzhWjucPUXbObkgB2wHVEYm/EEG0NlnB2JD/zMpVSrGl/Hb5yxX+N1bMpGBMUVwTY3zuKbCXNBSGqTiOINiz54nI/q4qwOKfnrEBfZQwMT69WFs4tvSeS+lRM0TL+jO/oQ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53fcb2ae-0459-4836-bb02-08db0de8d586 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 17:36:26.8382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xw45j+PPiOJ0b7Iog1fTlhf6eDcvU5jyFrtCLZ/kK/Y8zNOwyV4Fwjv5Na2U3eLdTYe20lu/OlY9r2Ow0my0mWfNEBlagVoVA22r23mYnrA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6006 > From: Jan Beulich =0A= > Sent: Thursday, February 9, 2023 8:46 AM=0A= > To: Ross Lagerwall =0A= > Cc: Konrad Rzeszutek Wilk ; Andrew Cooper ; Sergey Dyasli ; xen-devel@l= ists.xen.org =0A= > Subject: Re: [PATCH] create-diff-object: Handle missing secsym for debug = sections =0A= > =A0=0A= > On 08.02.2023 19:04, Ross Lagerwall wrote:=0A= > > Certain debug sections like ".debug_aranges" when built with GCC 11.2.1= =0A= > > are missing section symbols (presumably because they're not needed).=0A= > =0A= > Is it really gcc (not gas) which controls whether section symbols are emi= tted=0A= > for a particular section?=0A= =0A= You're right. I tested it and it is down to the gas version (2.36.1 in this= =0A= case). I'll fix that before pushing it.=0A= =0A= Ross= From xen-devel-bounces@lists.xenproject.org Mon Feb 13 18:03:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 18:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494804.764961 (Exim 4.92) (envelope-from ) id 1pRdAA-0001Uy-Kp; Mon, 13 Feb 2023 18:02:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494804.764961; Mon, 13 Feb 2023 18:02:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdAA-0001Ur-HR; Mon, 13 Feb 2023 18:02:50 +0000 Received: by outflank-mailman (input) for mailman id 494804; Mon, 13 Feb 2023 18:02:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdA9-0001Uh-Fn; Mon, 13 Feb 2023 18:02:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdA9-0005Kr-Ec; Mon, 13 Feb 2023 18:02:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdA9-0004TE-8K; Mon, 13 Feb 2023 18:02:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRdA9-0002Uo-7v; Mon, 13 Feb 2023 18:02:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F0+q+gKMQ8PPOTVvLY+8ACqyJXVvfiSbdCmkP+Oe/cY=; b=oZ0asbwaSE5WMTa9nTkwv+6JOJ +R4sB5AjF+esRxKM4XUbuho8DwLTQjUdyo9YpgYSzVhHDOqR4uXUGiDwBnAID/XyFXxV6u1ixsV51 OsCnjraiaaR+V6X0/FzSNeGeN2MiqGmUVw3f5OkkhheCd272msMj5t8mfj2++w2KkRXE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177187: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 X-Osstest-Versions-That: xen=f4f498d08d50259b9f25c274fd7b1e8ccf5693af From: osstest service owner Date: Mon, 13 Feb 2023 18:02:49 +0000 flight 177187 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177187/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 baseline version: xen f4f498d08d50259b9f25c274fd7b1e8ccf5693af Last test of basis 177160 2023-02-13 10:03:22 Z 0 days Testing same since 177187 2023-02-13 16:01:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f4f498d08d..9b70bc6d96 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 13 18:21:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 18:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494814.764971 (Exim 4.92) (envelope-from ) id 1pRdSO-0004Ci-6E; Mon, 13 Feb 2023 18:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494814.764971; Mon, 13 Feb 2023 18:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdSO-0004Cb-3d; Mon, 13 Feb 2023 18:21:40 +0000 Received: by outflank-mailman (input) for mailman id 494814; Mon, 13 Feb 2023 18:21:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRdSM-0004CV-6s for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 18:21:38 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d78853b-abcb-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 19:21:34 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 10:21:31 -0800 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 13 Feb 2023 10:21:30 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 13 Feb 2023 10:21:30 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Feb 2023 10:21:30 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 13 Feb 2023 10:21:29 -0800 Received: from MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) by SN7PR11MB7067.namprd11.prod.outlook.com (2603:10b6:806:29a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Mon, 13 Feb 2023 18:21:26 +0000 Received: from MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536]) by MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536%3]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 18:21:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d78853b-abcb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676312494; x=1707848494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Fs5caYKjDLcwV+kqjLD3Y7ZErSP/GpZ9g8PUeJXCHhI=; b=i2e2tJ2z97cSr+tJIoeai1CVafORNfCWNGeL7Bt+a3L+WW0rP/WsqMCJ p15XC0n3Es7th/cgiAw3sbEe7rXoMRf/ksiFhjfaQdKegR5d03dhjJOtd n8rqC4Lhbq79qcpS9/ME8lbth8DyCHUfsfEZ2YyyhoG/agknVP+35qjvV Dy0h4SjdbACcjYGc/CuERA1L3t3+do6gOOjrjU0FzTWkbXWrj5cJDPxSe TfvH3GW4nYYe2wchzI8ifNxbJCMigKRvDcDvb1DVYbKNI/y9efGcdhJ02 ip0ehZP8TcTwVnZyn0AR8ejl/t5aspghHMZoEFzRnu0MppIVV+inWDobW Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="417177777" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="417177777" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="914419459" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="914419459" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4abGUitSBf+QMJz7T9aRbPWERvUNhCbzV9RjbGZsW0+EztDVsQfpk9pTVE228lMWjVp0LfPpm0QCybrbu95Eb5gHnPzfSMJ6iYg/AhYYSo5+xPZCkWbhlX+Cf0sdC85xR06Fj7/hSkxGFd0dvmQE+5bxFypMvD9IJs63alifMDvaqnqtvT/FWI1QpFzbhpei7zB9ruoOpAtoh88GEyd2M5cPUvZZ0OWFnNPn60cImsVZ3TCnMC/wwzm4j/xEtTKayDJxCBZ4E+aRu5yBwJH6/7GIrjRbGV2TAwlkxvT2KycqMfG0nkRPArQKvkM3uxU/03w4ETBMvW5khk6D+iodg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fs5caYKjDLcwV+kqjLD3Y7ZErSP/GpZ9g8PUeJXCHhI=; b=Q1XAyYPt4l8IOlTSrz7DCR5Q0/Z2x+EBEK0OEXL/GRpLbosMM8drr5YM5IouI+eWpqoA9BTY4Qc3xj3cquLztMQuNCXxJTvHoRtk5Q8rbpkKrJg/tKke+gkjbgIfvmCBZvzCWAKgDv7jTm9IgC0YuSEuokv84LuNgXP+fvyazHEklbwXP36/m+zZzByjw6i/zbwJIw9hKOrlzB5Pwf2/IiZqAg0kQ4ICtbwMLRr+ZnQdtRMjNbtO8zQF+iAPcCYAaiS2BHw7PdeLh1EJHeIhUcmY70R9b7tPE3lByY+atqjzO9p+d604iFPay3UGrmemvwZOv2eLBwimpW2PH31Bkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Edgecombe, Rick P" To: "linux-kernel@vger.kernel.org" , "Gross, Jurgen" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" CC: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Thread-Topic: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Thread-Index: AQHZPaym1OeQ0uPDs0uotDA3o+cSyK7MaNuAgADLwoA= Date: Mon, 13 Feb 2023 18:21:26 +0000 Message-ID: References: <20230209072220.6836-1-jgross@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1392:EE_|SN7PR11MB7067:EE_ x-ms-office365-filtering-correlation-id: b1868438-57b2-4397-f75c-08db0def1e85 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z5HC+XRbYu1M4Pe7xGCOz9zhKI82FpGUOGa5ObyE62HWgMR4JgXHANmVi1S1oPODMs0mVA+TJiu4kR9OTHX3WmOsIADa6M64A6qlZ2/+p+gk4Rste1MS4fov7wThiWT6OSMMhLz1PrwtWpv4mNVEM/iFf2KkaZdwL21osatpPuaDzgiyZzBKwIcACzYhpTtoMtIkeznGZv7d/r0G6+UbE/NhZAoFB7pBny+/nNvxTiAmTxRwAxPSOl5icGMRjFgyr5ZtYon0FWbrDqi0IqWKuYOnRq6m53dZM+sHTYaCJSbtCxvSzGBlGCDXdvSmCjDQtuiTy/2UhQA+us0xnJ/nMDCHdBIz9GRa+BNg7WHyKTfX/UTDM9+o9Ab7L4Ou99Hw1vvUS8tnbA+V0rJoDISQJqimdi9DQcPp0/3L4h4okq3wSYY9d7JiStBkzmeEfswTSM8YZiXa+RsBfEfxr/J2iyidc9Ikhg13mwSGa5czdZ/Yxfa8C/ogVhnOq8TnTZe1hxfOGOjbbtb5in2lWfvxLtul4Ii3T7w7Ox+9h+qW3X1KEta1QpbLG3sPx4X5J2rdsrAc8VkuesfunHrTv1EVccoM3iUqSUYhY2q2Q94s9NauB0Bltv4psGTSvvjo/9fqO6Zd96vmSdE49o6TGamAYfAt2RZfxG39Vtfu0lhjs3UzDzcNfWdigxEi2ZLvCirkfIk/J5ilOlMf+xYA1s/DMH0fjNE0gnFL5ahzAESPR34= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1392.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(366004)(39860400002)(396003)(136003)(451199018)(38100700002)(122000001)(82960400001)(5660300002)(86362001)(66446008)(36756003)(558084003)(2906002)(66556008)(66476007)(4326008)(7416002)(38070700005)(8676002)(64756008)(76116006)(66946007)(8936002)(41300700001)(2616005)(71200400001)(6512007)(6506007)(26005)(110136005)(54906003)(186003)(478600001)(91956017)(6486002)(316002)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cmJIQWRJaXNUYzlOY0Z5ZVk2dVo0NUZ1L2QzR1MvZWlrT3h6M0J0QUZ6b0N1?= =?utf-8?B?blJtbWpiRmh3UnNiODdCVi9NbEFmWTc0UUVIMmpUeXdkNHQ3Y3hHYS9TVE54?= =?utf-8?B?eUdjWVdLTGZrQ3RSRzVBQTRRcFBJNEswSmRZekVjYlluZ29nUHEwZklkU2Qw?= =?utf-8?B?d3BWY2xlclcvTWNoVndPUy9Xd1gydUkveVRsUkgvblloM0RxaXJTQUtaR3dE?= =?utf-8?B?Y1BlNk5WWmxoOEpyZEtKNzA3ZnpCMXBpQzBuelRnbXpOTEVadDhuRWJmUzRB?= =?utf-8?B?eldrQ2xQSHhyVW1BV0dhUTlDRnA1cWQ4dzJuc1RZMEs3UDMxWmRENnV0bkYz?= =?utf-8?B?TlN2MEtURCtjbHMzSG5Nc3ZnNzhEZnprUTQ1eWgyVWdXTllPVjNmcUZJczBQ?= =?utf-8?B?elREMEdpc1RpcUphczJmcUF4N1lvZnRnTTZabE0xckNndmFTSGlYRVg2V2M1?= =?utf-8?B?aVhVbHQvMU9hZkpMUjdqdW9oZ29FSXpYelFzZktBSnlLQ0JSaUJ1NGk2N2JR?= =?utf-8?B?SHYzQkVmamJZMldKUk1qY2tJUXUyVE5ocng0NXcwZWFYaGxxSjlsdW1VQW9N?= =?utf-8?B?QjBxU2ZRK091YVkzNFRvTzhVSmtZM1lBSnRhWVFQUWhGVlZqVnpkMVd6Q1Yx?= =?utf-8?B?emtjRjIxZzFFYVpORmpKQjJ5L1dOZU5vOGwzbUE1cklIUnZFWjhZdCsrZENN?= =?utf-8?B?SXVUN1FVV08wMXpyT2h3VUFCUGNpZEhQZDRmZ2tGRlFrWXJ6NVBrNEw2dHRQ?= =?utf-8?B?Z0NzaDVMLzJLTWw5ZllwOHdTYkdlRXVGYlUweUhZc0s5ZFJGdi9BR1A1d2sz?= =?utf-8?B?TWxwbDJ1YVlvZWowU0FLWldIUUFXUWY4MTFEVytZMHlIZ2dkR0RjeFp4cVZR?= =?utf-8?B?ZGVwV3N3S09FdXJEdHgydVRvY2IyNHprSEJkckE1MVNocW00ejhwcjBFVmdB?= =?utf-8?B?b0U2dW0vZjZrRTNCaXVuY2lYcXh0NFdYU0xaSjI4UUtqcVpzWmVKZ0Y1Z3JW?= =?utf-8?B?YkxoZ1JQL1orUERISENxODkxVlRIcmhpaDNpYlpReitPMTdqUUs4SThVRlAr?= =?utf-8?B?THRlUk1BMWhGbTNEOHVuYVU0d25RWTlnK25UTHhNK1Y4elpDcDJoeHFXTUNu?= =?utf-8?B?dWdHaTExL2pmZmZCQ1lodUdsNWNlNUNiWjZwTFhmVk9XMysvakttWmQ4NllB?= =?utf-8?B?am5NNFdhajdYT0treTYxNTZGT2ZPUTVMcFVGdlF5WkQwRjFwQ3VvLzVzL205?= =?utf-8?B?RTFFNU91aXpzSmE1WVNidmtTY29wdGtpYW1UZXkvU1BBbDlHOVUxemxldmJi?= =?utf-8?B?RUlpS1VPalc2dmhiazROY2ljaHdGdlQzV0V6QVFydXp2RTV6VkVXYTlPRjFm?= =?utf-8?B?Mmh2V04rQmRDdVZHNHhxNDI3bVBud0ZFME96VVZxTVVrV2k2ZVdSWGRkSkRZ?= =?utf-8?B?UllKV2Jqekl0Q2pBczZuY053Y0lEUWxTbVNIMVRSZTZvMDRPYml3NjZ1MGtG?= =?utf-8?B?THJ3U0NueXRmT1lRZHBGY2JmaHRpRzdKRzcreHBTMk1oUUY1RmFYRjhqSksw?= =?utf-8?B?dGFmSWpZS3Y4M0p5ZStRenlJNXJsRk8rZkZCS21sYm1FNjVTVDBjWnptV0pq?= =?utf-8?B?VFV1WGhHQ25SR25HVUg4MWRRQWZCczlsMDczSkNYL1EzTWM1Y0QxbEs5djFI?= =?utf-8?B?bGl6RW5uTGNRbnl1NXMxVnh3Vk9XS1VvbEZ3eGZzQkJlTUJkeE50SmI3S1Zn?= =?utf-8?B?SHRXOUpIaHJ2T1BMOVRyYVI0Vk1CT1dIOHpXWjdwRHh1YVJDWmhEZ0RBZ2JY?= =?utf-8?B?MW9MQ0gycHNIbkR5L0Q3b0ZSekJwbEpEUTRrTHlBeEpKa3pNQ3E0dldsbmhK?= =?utf-8?B?ZFpUNkRpUU1jQjkybElweFllY29uak5KUExOWXhuNTJkNExhSDB6N2hNdGpi?= =?utf-8?B?OVVjRHFzOGhrVmM1SldVNjh4YldmWDl4cjY2WlZkSTNDMEdOc2hVVDdWUC8r?= =?utf-8?B?UGIrOFJOZlNDNXdXbWJ2aDVWQU9WczRiNUI3Qy9lT1YzOGQ2WExVSjNPckV4?= =?utf-8?B?QXlnS05QRUVtb3pSVGZTY2l4TWsxU3hzUlk3N0dUa3BMMTBabjVEVTVtQzVI?= =?utf-8?B?azRPMnRHaU5HaWx3VzJuZjhXQzlJVXdNcXpsWHlUY0Mwc0Q0elJSOERWNGtQ?= =?utf-8?Q?BkSfQpzJ+nxCKASvefVWUhE=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <74584F4737DAA5409E00937B788D04EB@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1392.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1868438-57b2-4397-f75c-08db0def1e85 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 18:21:26.2873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vIK/QO5FhAKy9Jy2PiT/QpI7snKgqMGKRvr56uZr20UBZuDj8wHZVMVR23FPSgnMFBvxzyQK8Pz90U7JFLQ2lBO8Gzm5KQO07O01H5iHWLA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7067 X-OriginatorOrg: intel.com T24gTW9uLCAyMDIzLTAyLTEzIGF0IDA3OjEyICswMTAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K PiANCj4gVGhhbmtzIGZvciB0aGUgcmVwb3J0Lg0KPiANCj4gSSdsbCBoYXZlIGEgbG9vay4gUHJv YmFibHkgSSdsbCBuZWVkIHRvIHJlLWFkZCB0aGUgY2hlY2sgZm9yIFdCIGluDQo+IHBhdGNoIDcu DQoNClN1cmUsIGxldCBtZSBrbm93IGlmIHlvdSBuZWVkIGFueSBtb3JlIGRldGFpbHMgYWJvdXQg Ynkgc2V0dXAuDQo= From xen-devel-bounces@lists.xenproject.org Mon Feb 13 20:54:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 20:54:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494826.764983 (Exim 4.92) (envelope-from ) id 1pRfq4-0004WY-IX; Mon, 13 Feb 2023 20:54:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494826.764983; Mon, 13 Feb 2023 20:54:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRfq4-0004WR-Fk; Mon, 13 Feb 2023 20:54:16 +0000 Received: by outflank-mailman (input) for mailman id 494826; Mon, 13 Feb 2023 20:54:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRfq2-0004WJ-Kn for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 20:54:14 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9164514e-abe0-11ed-933c-83870f6b2ba8; Mon, 13 Feb 2023 21:54:13 +0100 (CET) Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31DI5dLd020240; Mon, 13 Feb 2023 20:54:10 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np1xb3vu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 20:54:09 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31DKKw27027254; Mon, 13 Feb 2023 20:54:06 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f54q4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 20:54:06 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DS7PR10MB5264.namprd10.prod.outlook.com (2603:10b6:5:3a7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.10; Mon, 13 Feb 2023 20:54:04 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6111.010; Mon, 13 Feb 2023 20:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9164514e-abe0-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=BqJz0I24jDVfN1J6TZQ1XSSUoF7YPuhKIBXQeXASTpM=; b=wZ88ITcNRUImrHXFxKKG6BoFddW51A5MQZOHt1do+6Umby7y6/g3I5gD7PLdpKnLReeB xAWr1UjhCOVFSDbUsmZ6aqXZ42qKtafjkYVD27RX6yLcfMi+/u1eo74VqJYIdzwhjjB4 zwtdo3CNqEccIUvTZFiBdlqQp3HJFXN9UnHiMGmrNn3q8MQpT75cJ78sOaYfnCQeLCph qXb3dAMzqDMophqwFAPTPE9aepJ7zE1vDdjYFSHkGlEi6nJXvjbRcxdj8bm2NNR8av0F WllV3NpEl8lbBDlbfWwyG2d3aUJavulMw6ND/lwIheiHZrvbPbJueGhIJZ2MPONV4ZVM hg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtJM6udrtkMc1UWOytx6wNyeNEsQs2P3saI3821UOHUwfxyTBkM2dzp8M1ka/OxUbxv2Quwtbqi8vSn1nG11MnfUJnWI2hAn/FmIj4M5+Qj1HvRJNWtiu76+YxyZCfn1z4LLydIsPk0uGaQbdPVuZiW1bQEuGUqiWyeDLjWoj0QytfKMMiAteCV4DplKf1xkjYZyDJPmdjPBVARtlCyGXK9/inW49SAJSxFNspzG3Dk5zfrDK5pCynxBIBdhFq8anC2JBAuaoWkTR0GfgJkQPABTdVtcNdOi44EGG3v1JjDSm6LULU61ePPpgObLw1LZl487AvL6NkCW5oqrr7Ezbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BqJz0I24jDVfN1J6TZQ1XSSUoF7YPuhKIBXQeXASTpM=; b=T4wBLMEhHojYswABesDZ9OJv340brlsKefFJbVCSlDtRMrzi2bEI2kdemT/3HyVtWGhJ3WCatMQVqlU194gBIo36Mq4veX8j8Lr3kghxMg2e/Gwbm0iCBc5boUeIeKpBki42eFdwyiiyT0EHW8n9Ux0y1CnKaJutHMgU7GLLP7QZgQddnHW9H9gFK38jz2vOM8ZewNEk3fleki9Anzja1Rod5AKE2QbBCGvdmU4bun0waJxvqjX/XPTmhEfl0CBjNKsZYKwb/aDoxZq8b5qBevYb+sw90Q4zuHWzEa9ueATD+gDyQ7IAagii3frRltQYsjpJbOWuJuJNFldZFbC2yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BqJz0I24jDVfN1J6TZQ1XSSUoF7YPuhKIBXQeXASTpM=; b=a64PBhaXRIg7tL1pOSPyuB6k7mDNb6KjpD9BCDE6uz+BEd9YZY/otCMEF8z+R5tvqIV2/bpvluvej9g4PNJmVrr/4QDRzqd9YbtQ+azs8O9+p323v9pepY5c17j9Jtkc1L+eti38Tq24Eg+Et/w3FLa011RuP+4jmFn7Mf2yPaE= Message-ID: <5892e7d6-bd08-0f2f-4dcb-fa5b9123a2eb@oracle.com> Date: Mon, 13 Feb 2023 15:53:58 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options Content-Language: en-US To: Jan Beulich , Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> <3cdfde6f-5af6-4044-f786-259c70e0ba69@suse.com> From: Boris Ostrovsky In-Reply-To: <3cdfde6f-5af6-4044-f786-259c70e0ba69@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR04CA0035.namprd04.prod.outlook.com (2603:10b6:a03:40::48) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|DS7PR10MB5264:EE_ X-MS-Office365-Filtering-Correlation-Id: 16247173-458a-4de2-c493-08db0e0470d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mqTq7RvA/0YOM5odJ3SDU62koW+0Mop8VeH6H3J9wm5Q4DiFxbFeT6D+rmJVTbIO735Hzopi2cO3pwR0SOrdV3NJ1SZa1R7/YVZrVC0wzL3IVVTrhcGt+AMEMsFjI+Zmu/HKMz59hvBwub4jhJvCNo1jRAtQSP0iJQoTgD5//URTov85l+JHEdrUq2EWY+q6PvSDaE+vgeWU+3PxGAt9agNtiRUmfOM1FHi0ll5iyqsJzcDNcNtypdm2L/Ax1w/Z71aacJIkUJULphLMvw9jBezqYnDbj/PV4iafzK+3A3JO/a8sAjGzdjq8YK7PIbPX41JLHAZwUE6TrBYI1hWtjANjsfHkbiAeGFTizFOPIl4xFC0yulZmY7SIq3UKa7LFQIy/hZiMXZjrR+yBkdtHAJAsY6bsfJ0J3rORWdJy2egDVr40RD2DtPddIbcYf0XAW9UEW5cgvqv8B1WLBemrzPHAB8EHfHOOoEW7x8NnqA1Pet327/wh76lujOcpMKXl7nwfUXTpArbyjsQY4keBC7rwTPwlTavm5aK7XvLrFgZ3a2VXgql12bkds9AX982FfKMFmc0RZB5x95EIvawpC6Xc6wtRYl2/kO/7flhANZO0LqcoAEXK4K28tYcJk2Ov2CBsfT6n+ShZPok2i5v/02rtz1MT1pyX00npSto8CZ5qQ+jH0Pery3VHwlpr37CBuoHjHtD/tlSYHlCFuVdOk+LJttj2JZSTi1xPPLLsSZQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(376002)(39860400002)(396003)(346002)(451199018)(478600001)(53546011)(8676002)(8936002)(44832011)(2906002)(66946007)(66556008)(66476007)(38100700002)(4326008)(4744005)(31686004)(54906003)(6486002)(316002)(41300700001)(26005)(110136005)(86362001)(6512007)(5660300002)(186003)(31696002)(6506007)(6666004)(36756003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnl3VUFSbWJmd1RCOWNIQ2Q4aGtKT0ZHaGw0SnczajVEQTBlaUZ1Y0ViVlhY?= =?utf-8?B?YW1WNnlLSUQ0dDRLVkszY1p5UHY5M1huRE85NjJIRk9UQnpMZHRRUHcrYzhk?= =?utf-8?B?Z2hJNWZBa2FEVzRRQm0vN2p2YzUwSjVUWk01Y3hlRHRWUXJLNndUd1h5ZzU0?= =?utf-8?B?M2hGbGVzMUY0cGF5cDQ2Vy9peGpoeFhqZGtOOW4rT3A1SVF4ODJrKzc5WWV5?= =?utf-8?B?a1hON3Z5bEl6Uk5TeXBnVlBZbDIyMjFaNkxrVzdXcWlsTmtZcG5kZTk0eDE4?= =?utf-8?B?a0t4M3pJVVFmZmw5ajNIV3lqb3NmZDRmSGUrZDQ5WW1sTmNnbmxPM0gvMC9h?= =?utf-8?B?UndXRGxwd2VyeWxYUWg0elo0WENZeUVGeHowL2xNY29DNUlEQ0MrQWx1Q2JM?= =?utf-8?B?WUMzd3M1OGpJc2NrWG10dzJqU1hFaVg5SUxZSFFrc2Y4TG5zS1VpaG42Uk91?= =?utf-8?B?KzdMdUZTWStHa0QzZ0lvVDFKSWViWnFSeTg4T1RFeE9ybnNuQjVKRnF6alRK?= =?utf-8?B?TlhEY1JkSWU0T1JmYzlwMTlnRStGUkUyekxORXowbVZTaGVMNVdtOEV4bk5I?= =?utf-8?B?cFh6ZW9sUllMSFl5WmUzYlBENGJOTnpHWkNBQ0lQdlRMU0d4aUwyM2ZkR0Js?= =?utf-8?B?R2o4RUxoMDF0VkpwL2g1R2pETkFzTGdJUXBvOTJUdGUyRXhQeHFtN1hIaU9m?= =?utf-8?B?TmsvUTNsT096Sk9OeWNMY0J4VGtjZlFRUnhnelROVEMyZHN0V2dSaVJVMUJL?= =?utf-8?B?V25CRFpVZEhUM1cyMkkyQmc0blZIeldrd0Y4VVZ4VzBHUkRwWHVhZGk1dy9k?= =?utf-8?B?SlNtQVgxTzAzNGJUZmdhUnRtOXBpQjk4cXBid2U0SFcyR0t2N3djR3NGaUdM?= =?utf-8?B?ZHNkdWc5NkpvU0xJbXpYUk1iMEEwT3lhbUtBSGovcFUwNU5mR01oZk1wRDBC?= =?utf-8?B?ZHlveVNmd0ZuTDUxY0p6RHRYSG5EWlByYWxwQWw2NkJzdENtTGQ3ak01d2FP?= =?utf-8?B?YVBnR2hTeWU5UWQzMk5VZ3lYT1N6dFFQRG9KY1BsZ2dCR0c3aG1nZEZWb0NG?= =?utf-8?B?KzlrdEFvczRDOFY2dUxPZVF2OEhPTW5mbDdSUGdRZXBuck5iN240Vy9YaTJx?= =?utf-8?B?UlRIeFhOcWM3UWxaNTlicmVTdllkQWpCTG5HdkZ4Tkt0WjYyNVlCRkZ0MkNa?= =?utf-8?B?M0Q5RHBDWGF4L3Q2YVhxeHdUOEpTTnFxRnZ1TE9NSExMcGZsWUtUV0gxbGd3?= =?utf-8?B?TEcwVVlpaEZUYjRvbnJ2aWhCRmpvSVhaZFhRV3F6ZGdPNU9ZUTE2NFk1WEhT?= =?utf-8?B?cmsrZEVPOGJvUVRSd1BTakppS2VDU3pvSndtZzhMWkdOc1pKSnBHYThuRmpn?= =?utf-8?B?REdlTTFqc3FTeDBsS25VOUl0OWMwNXowNHhCdll1TFVQRGV1eDFLZXFHSkZJ?= =?utf-8?B?QWhIRS9IUmd0YkprSC9Gdk9qa1VCSzRBR1c0Y0h1aXova1hJeUVUeUNYQ2FG?= =?utf-8?B?Q3JZT1BGUks5SnVrYXNxUWZRNFdFVm1ibXNDa2p0Mmo0MzNPWXhxV0o0QTMx?= =?utf-8?B?UUZlbE9TdnJtVnQvR0MyVXlPS1VSOGVBTDFvL3VKaEJ5REdBcmRFbmhGcXJH?= =?utf-8?B?L0Iwb3E4SVp2TnRjeTM0SmxpaGFzdzdXNUxJcTdkY2JXV09iOFpRckY1ZitQ?= =?utf-8?B?TFBLQVFzdXJ6NWtHaU1iWjcrRFdRd1BtV3puTW1sMnRDZjNYVkoyQk1PSXNF?= =?utf-8?B?UCttYnhzR0lqSVhMNTVwR3dQR243QU9nQmxybHFGQ1EzbEJad2RKcHBNUlRV?= =?utf-8?B?S1Zuak9ZaEJYRFJlQ1dobWJ0YWF2eTFnTDVrOXRmR0dUbE5BTjdXNzV0M1BZ?= =?utf-8?B?RjQ1c3FjTzFqSStWQnVqUjFCSkZEMlJYb2NZbGREaXRtK2VTcXcxVzR5SG9I?= =?utf-8?B?MkUxWWtjYjNBZXdoK3FWelM0bGVYOEtCMERwanNpY1d4ZThpdmV2WitQcEV1?= =?utf-8?B?N1cxZlRLcUdhb3I3Yndvb01JZlBFN1VmWVBDcEVUcjVNMU5CZmE4TEFEa1hD?= =?utf-8?B?N1JtRWNnODkrUE1kOWVIZGFmU2FtZnBzM01Ua3R6MTFGdzdXSDhjdnZvcGti?= =?utf-8?B?RW96QThyZnRCN0c3NVVNcXlKY1RJQ2tDVFlUWm5lQnMzM1hsZ201RlBCSGpp?= =?utf-8?B?bHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VjPWmij6fmChPfTUE5mPBIBxp4jAuozbhmQFa43mGyY5FroaOzSJz1R+TQ/x6s+a3A/NIRFG+snOEwYn4uI7u4dt18WfkyB+q/b7n5VxdiU0txoRkSNCKeaysgTPRTww0biAOYT7p4BpE4QLxTFNmUH3z1i37S9WdzStE/KAp7EY7pkipCs5TeFFo1Z3RNXm61OTt9UnixAzUTHO+X67gNNKOxEBAstTj94SgNOSH05a0/mVwYkH+VICD7SpB1w+ZeQFQUo1EkTqKCVtVEnG6Etjiq5sfrDPrH3mm7UtlgWM7BGUKuwSNm2890ccIXN947ZEpUy23tCKvZGzL7dZA9/XzXfbh/1Gv71HbTPMbfZ0K6AUMGaVTLWzDnEkTBYfjRKco10G1KmZC52gUrBGJbBwXRF8DSn4JY+QRvVZB6XzjWoSNlxeE5as9K+wPYY/rAFIvvCGW6ZnAYgHFMZOCZ1E/zB1zK68JV0X4RrVjaVXamtfSbjWtnYVAVOWJiA8YTnmtVNjl5VT1vvO50U8A2Ygq8SGScBHlL5viao34a9KGfsO1N80sNtODbf4B260QyQiK8BnaYdf/WwX8JyXMpzEMb6iFWu5+pOPbVFe4odiIwNKYPBp2q6g8sMkmRkvGRKKlBFbzIDbSHf5AoUa8eIpIdM8QzOGDUnDQbhNMsR8tA0UYiOrA1iK0cfnGkiXN4dBXzBAb8i6sm0nOhOKy+eKvz7ABYO1X02IJfaq9tjpOyz9NA0qoYoOjBceIXMwgE9h0MW2bdvzp7XryeA0PIAfQg+2CraMZqHOt+/+G6/X55DYG2QM74x+9zBlc9HpHMwz6Yfr59Th9EruExnt+rXqD+gOgvRzdiCqc3K5wu2WJ2To4CN5Wmgj7CG7NQFP X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16247173-458a-4de2-c493-08db0e0470d2 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 20:54:04.3418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9zNe74EqOITqLsWYCc9LPz6t0lsieSlhqsBGjdbBECx4AgRFbdOOBNgUA72EJPieAXXfXg7q6TU+5WwVpycOfgJhD360DQrqI1FAeO78lWg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5264 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_12,2023-02-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130184 X-Proofpoint-ORIG-GUID: AkmpXOEDbPFmZRmQbuNmG5i_K4UKwz0Y X-Proofpoint-GUID: AkmpXOEDbPFmZRmQbuNmG5i_K4UKwz0Y On 2/13/23 11:41 AM, Jan Beulich wrote: > On 13.02.2023 17:30, Xenia Ragiadakou wrote: >> On 2/13/23 17:11, Jan Beulich wrote: >>> On 13.02.2023 15:57, Xenia Ragiadakou wrote: >>>> --- a/xen/arch/x86/cpu/Makefile >>>> +++ b/xen/arch/x86/cpu/Makefile >>>> @@ -10,4 +10,6 @@ obj-y += intel.o >>>> obj-y += intel_cacheinfo.o >>>> obj-y += mwait-idle.o >>>> obj-y += shanghai.o >>>> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o >>>> +obj-y += vpmu.o >>>> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o >>>> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o >>> This code was moved from hvm/ to cpu/ for the specific reason of also >>> being used by PV guests. (Sadly the comments at the top weren't >>> corrected at that time.) >> Hmm, the init functions are prefixed with svm/vmx. >> Does vpmu depend on svm/vmx support? > There are interactions, but I don't think there's a dependency. You > may want to ask Boris (whom I have now added to Cc). MSR intercept bits need to be manipulated, which is SVM/VMX-specific. -boris From xen-devel-bounces@lists.xenproject.org Mon Feb 13 21:02:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 21:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494832.764994 (Exim 4.92) (envelope-from ) id 1pRfxY-0006Bp-CU; Mon, 13 Feb 2023 21:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494832.764994; Mon, 13 Feb 2023 21:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRfxY-0006Bi-8N; Mon, 13 Feb 2023 21:02:00 +0000 Received: by outflank-mailman (input) for mailman id 494832; Mon, 13 Feb 2023 21:01:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRfxW-0006Bc-EJ for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 21:01:58 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a446a483-abe1-11ed-93b5-47a8fe42b414; Mon, 13 Feb 2023 22:01:54 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9ECC45C0050; Mon, 13 Feb 2023 16:01:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 13 Feb 2023 16:01:52 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Feb 2023 16:01:50 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a446a483-abe1-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1676322112; x= 1676408512; bh=lzHvNNWJAMPknrAbQ/IZzM70dgUpshuc4xhit7Lw7fE=; b=D clb1csrbW5n88QQeP/05NBGqeWLarDm2gvhYkgkre2d4vqI2v936TBt3/GoaDXN8 mW/9maMz6OkNVnBiB4u9uGkHS0GmmZORwIiPveqAfTFdaiw9KDp8Dcyz9zkhVZ/V +NYwiYQa7iwuxi/SqP+3h8uEO7hi+ICkAhFRAtcZ+BfD2bYK6IGjdWPg5pg+lPdl icOswMsmd8ivODhiHMsNcb6ud+YJErwkdw2styv0aEpoWjZ5HjRerziJ2WenoiUF TIyDK5cIF6B/g/UBiG0FG7+zcHXeCXS6u/ukbqjX8MsXzAx8zJbK80ctNMjzprdP gf118/VCMvc8DdWhHFJ4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676322112; x=1676408512; bh=lzHvNNWJAMPknrAbQ/IZzM70dgUp shuc4xhit7Lw7fE=; b=ciBRmJ8Bea56AZVmMD0D+Ta4+tatkf686U7eVveufaMM XlXlzsTdxgXfIecD2kWxHkvkkideRnaoEtEenKIvdndsU33ao24fV3rhiqvBvt+C 6Uqt4JqbCvtC998JWzK2XDeyA9QW+pAOx7+0N9mUwZ6gPVDdoQS5/VN2EbFVA60O wLqsz6R4vx6DmNauVhmDnzR0GJK8nCKtXfc3n5abDqOwpUSd3RfXcu2kKUkSPggw 38fECmWjha79DcwgTPvbZ47EX3aIZdU3hU5FtbVDMYTMXtYrRpIedrgYNiQH3u60 OrnRi9YIy2g0jeVr6B7XkMW2iET2EMV0jqJ88NHABQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiuddgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvjeetgeekhfetudfhgfetffeg fffguddvgffhffeifeeikeektdehgeetheffleenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 13 Feb 2023 16:01:45 -0500 From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] xen: speed up grant-table reclaim Message-ID: References: <20230207021033.1797-1-demi@invisiblethingslab.com> <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N++tYrnEizmf3jUB" Content-Disposition: inline In-Reply-To: <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> --N++tYrnEizmf3jUB Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Feb 2023 16:01:45 -0500 From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] xen: speed up grant-table reclaim On Mon, Feb 13, 2023 at 10:26:11AM +0100, Juergen Gross wrote: > On 07.02.23 03:10, Demi Marie Obenour wrote: > > When a grant entry is still in use by the remote domain, Linux must put > > it on a deferred list. Normally, this list is very short, because > > the PV network and block protocols expect the backend to unmap the grant > > first. However, Qubes OS's GUI protocol is subject to the constraints > > of the X Window System, and as such winds up with the frontend unmapping > > the window first. As a result, the list can grow very large, resulting > > in a massive memory leak and eventual VM freeze. > >=20 > > Fix this problem by bumping the number of entries that the VM will > > attempt to free at each iteration to 10000. This is an ugly hack that > > may well make a denial of service easier, but for Qubes OS that is less > > bad than the problem Qubes OS users are facing today. >=20 > > There really > > needs to be a way for a frontend to be notified when the backend has > > unmapped the grants. >=20 > Please remove this sentence from the commit message, or move it below the > "---" marker. Will fix in v2. > There are still some flag bits unallocated in struct grant_entry_v1 or > struct grant_entry_header. You could suggest some patches for Xen to use > one of the bits as a marker to get an event from the hypervisor if a > grant with such a bit set has been unmapped. That is indeed a good idea. There are other problems with the grant interface as well, but those can be dealt with later. > I have no idea, whether such an interface would be accepted by the > maintainers, though. >=20 > > Additionally, a module parameter is provided to > > allow tuning the reclaim speed. > >=20 > > The code previously used printk(KERN_DEBUG) whenever it had to defer > > reclaiming a page because the grant was still mapped. This resulted in > > a large volume of log messages that bothered users. Use pr_debug > > instead, which suppresses the messages by default. Developers can > > enable them using the dynamic debug mechanism. > >=20 > > Fixes: QubesOS/qubes-issues#7410 (memory leak) > > Fixes: QubesOS/qubes-issues#7359 (excessive logging) > > Fixes: 569ca5b3f94c ("xen/gnttab: add deferred freeing logic") > > Cc: stable@vger.kernel.org > > Signed-off-by: Demi Marie Obenour > > --- > > Anyone have suggestions for improving the grant mechanism? Argo isn't > > a good option, as in the GUI protocol there are substantial performance > > wins to be had by using true shared memory. Resending as I forgot the > > Signed-off-by on the first submission. Sorry about that. > >=20 > > drivers/xen/grant-table.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > > index 5c83d41..2c2faa7 100644 > > --- a/drivers/xen/grant-table.c > > +++ b/drivers/xen/grant-table.c > > @@ -355,14 +355,20 @@ > > static void gnttab_handle_deferred(struct timer_list *); > > static DEFINE_TIMER(deferred_timer, gnttab_handle_deferred); > > +static atomic64_t deferred_count; > > +static atomic64_t leaked_count; > > +static unsigned int free_per_iteration =3D 10000; >=20 > As you are adding a kernel parameter to change this value, please set the > default to a value not potentially causing any DoS problems. Qubes OS can > still use a higher value then. Do you have any suggestions? I don=E2=80=99t know if this is actually a DoS concern anymore. Shrinking the interval between iterations would be. > > + > > static void gnttab_handle_deferred(struct timer_list *unused) > > { > > - unsigned int nr =3D 10; > > + unsigned int nr =3D READ_ONCE(free_per_iteration); >=20 > I don't see why you are needing READ_ONCE() here. free_per_iteration can be concurrently modified via sysfs. > > + const bool ignore_limit =3D nr =3D=3D 0; >=20 > I don't think you need this extra variable, if you would ... >=20 > > struct deferred_entry *first =3D NULL; > > unsigned long flags; > > + size_t freed =3D 0; > > spin_lock_irqsave(&gnttab_list_lock, flags); > > - while (nr--) { > > + while ((ignore_limit || nr--) && !list_empty(&deferred_list)) { >=20 > ... change this to "while ((!nr || nr--) ...". nr-- evaluates to the old value of nr, so "while ((!nr | nr--)) ..." is an infinite loop. > > struct deferred_entry *entry > > =3D list_first_entry(&deferred_list, > > struct deferred_entry, list); > > @@ -372,10 +378,13 @@ > > list_del(&entry->list); > > spin_unlock_irqrestore(&gnttab_list_lock, flags); > > if (_gnttab_end_foreign_access_ref(entry->ref)) { > > + uint64_t ret =3D atomic64_sub_return(1, &deferred_count); >=20 > Use atomic64_dec_return()? Will fix in v2. > > put_free_entry(entry->ref); > > - pr_debug("freeing g.e. %#x (pfn %#lx)\n", > > - entry->ref, page_to_pfn(entry->page)); > > + pr_debug("freeing g.e. %#x (pfn %#lx), %llu remaining\n", > > + entry->ref, page_to_pfn(entry->page), > > + (unsigned long long)ret); >=20 > Is each single instance of this message really needed? I=E2=80=99m not sure. > If not, I'd suggest to use pr_debug_ratelimited() instead. Fair. > > put_page(entry->page); > > + freed++; > > kfree(entry); > > entry =3D NULL; > > } else { > > @@ -387,14 +396,15 @@ > > spin_lock_irqsave(&gnttab_list_lock, flags); > > if (entry) > > list_add_tail(&entry->list, &deferred_list); > > - else if (list_empty(&deferred_list)) > > - break; > > } > > - if (!list_empty(&deferred_list) && !timer_pending(&deferred_timer)) { > > + if (list_empty(&deferred_list)) > > + WARN_ON(atomic64_read(&deferred_count)); > > + else if (!timer_pending(&deferred_timer)) { > > deferred_timer.expires =3D jiffies + HZ; > > add_timer(&deferred_timer); > > } > > spin_unlock_irqrestore(&gnttab_list_lock, flags); > > + pr_debug("Freed %zu references", freed); > > } > > static void gnttab_add_deferred(grant_ref_t ref, struct page *page) > > @@ -402,7 +412,7 @@ > > { > > struct deferred_entry *entry; > > gfp_t gfp =3D (in_atomic() || irqs_disabled()) ? GFP_ATOMIC : GFP_KE= RNEL; > > - const char *what =3D KERN_WARNING "leaking"; > > + uint64_t leaked, deferred; > > entry =3D kmalloc(sizeof(*entry), gfp); > > if (!page) { > > @@ -426,12 +436,20 @@ > > add_timer(&deferred_timer); > > } > > spin_unlock_irqrestore(&gnttab_list_lock, flags); > > - what =3D KERN_DEBUG "deferring"; > > + deferred =3D atomic64_add_return(1, &deferred_count); > > + leaked =3D atomic64_read(&leaked_count); > > + pr_debug("deferring g.e. %#x (pfn %#lx) (total deferred %llu, total = leaked %llu)\n", > > + ref, page ? page_to_pfn(page) : -1, deferred, leaked); > > + } else { > > + deferred =3D atomic64_read(&deferred_count); > > + leaked =3D atomic64_add_return(1, &leaked_count); > > + pr_warn("leaking g.e. %#x (pfn %#lx) (total deferred %llu, total lea= ked %llu)\n", > > + ref, page ? page_to_pfn(page) : -1, deferred, leaked); >=20 > Again, maybe use the ratelimited variants of pr_debug() and pr_warn()? Will fix in v2 unless someone objects. > > } > > - printk("%s g.e. %#x (pfn %#lx)\n", > > - what, ref, page ? page_to_pfn(page) : -1); > > } > > +module_param(free_per_iteration, uint, 0600); >=20 > Please add the parameter to Documentation/admin-guide/kernel-parameters.t= xt >=20 >=20 > Juergen Will fix in v2. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --N++tYrnEizmf3jUB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPqpTwACgkQsoi1X/+c IsGi/w/9FwOk5agFnZovITEblQY/gGnJFE7MAhQm8t008gzUbtwWbbl3NbrTvq4H f15E9IDsA7o1YWcKCx7kmHayIr8inQqX1MINULBIEwer+2KC4/MDjmT03abeENVt 9eb/F+BhsswQXuGPu9fNGdUmS6Qtoe6bb8X3586QUADUoUK4kK0LgidIjTopwKys gFmzOzZe9J2x8NIUD7fJTa5PMqJ8sErBP1RWzjB0JSJ9pV2pRFSKGeKEosc8ZOqH bNkb9Fuaaryhe72YL5MTnVnsaKN2sJDN1pmOrIjiN28dgc/IxZ+SkauG8mry3a14 50fBXCQ/SiX/deXMN+dIJ49qkMbCdXGZvLMFQ3059ySUUSV0kGab8SkEqb6eYnN0 RjMEQVywIp6FcSr5xv+8TNyYUNNrERf67GMkraMFi4si7vN/o6ojNX4iBBvq07nf M9IAiYhxzDEhiWZtbBWkew4W5gKlOXuelMEkNh7JyCXX3SB/3S2s8v/1uDg+N1NK nSuIRJOa9y8UksIjXyHvWAa0xoNs4IX0+GgEk+7zaiJufX396FvP/fqkYEK1xBtl xmHbA/Elrb3U5elvIUpJrOnEqUpUv9TrI+MylUZ6xRZPw7cUfk2a9/Hm675DnSpd xvmzdmBZz9Q1px6Xbx+QAFQYTWHGAxE6TJIQTNJ/k4KMz9c1Vjs= =bX8B -----END PGP SIGNATURE----- --N++tYrnEizmf3jUB-- From xen-devel-bounces@lists.xenproject.org Mon Feb 13 23:12:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 23:12:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494851.765005 (Exim 4.92) (envelope-from ) id 1pRhzH-0004DV-Np; Mon, 13 Feb 2023 23:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494851.765005; Mon, 13 Feb 2023 23:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRhzH-0004DO-L0; Mon, 13 Feb 2023 23:11:55 +0000 Received: by outflank-mailman (input) for mailman id 494851; Mon, 13 Feb 2023 23:11:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRhzF-0004DD-Pp for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:11:54 +0000 Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id caf602b8-abf3-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 00:11:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id B571B2015E; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fFJRHOnEtlpj; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 6AD3C20119; Tue, 14 Feb 2023 00:11:48 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRhzA-00FwGp-03; Tue, 14 Feb 2023 00:11:48 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: caf602b8-abf3-11ed-93b5-47a8fe42b414 Date: Tue, 14 Feb 2023 00:11:47 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 6/7] Mini-OS: add open and close handling to the 9pfs frontend Message-ID: <20230213231147.lw4iae5z4yq4focz@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> <20230213084412.21065-7-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-7-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 13 févr. 2023 09:44:11 +0100, a ecrit: > Add the open() and close() support to the 9pfs frontend. This requires > to split the path name and to walk to the desired directory level. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - check path to be canonical > - avoid short read when walking the path > - fix get_fid() (Samuel Thibault) > - return EAGAIN if no free request got (Samuel Thibault) > V3: > - add check for "//" in path_canonical() (Samuel Thibault) > --- > 9pfront.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 322 insertions(+), 2 deletions(-) > > diff --git a/9pfront.c b/9pfront.c > index 0b8d5461..fb2e5669 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -52,13 +53,32 @@ struct dev_9pfs { > struct wait_queue_head waitq; > struct semaphore ring_out_sem; > struct semaphore ring_in_sem; > + > + unsigned long long fid_mask; /* Bit mask for free fids. */ > +}; > + > +struct file_9pfs { > + uint32_t fid; > + struct dev_9pfs *dev; > + bool append; > }; > > #define DEFAULT_9PFS_RING_ORDER 4 > > +/* P9 protocol commands (response is either cmd+1 or P9_CMD_ERROR). */ > #define P9_CMD_VERSION 100 > #define P9_CMD_ATTACH 104 > #define P9_CMD_ERROR 107 > +#define P9_CMD_WALK 110 > +#define P9_CMD_OPEN 112 > +#define P9_CMD_CREATE 114 > +#define P9_CMD_CLUNK 120 > + > +/* P9 protocol open flags. */ > +#define P9_OREAD 0 /* read */ > +#define P9_OWRITE 1 /* write */ > +#define P9_ORDWR 2 /* read and write */ > +#define P9_OTRUNC 16 /* or'ed in, truncate file first */ > > #define P9_QID_SIZE 13 > > @@ -69,10 +89,27 @@ struct p9_header { > } __attribute__((packed)); > > #define P9_VERSION "9P2000.u" > -#define P9_ROOT_FID ~0 > +#define P9_ROOT_FID 0 > > static unsigned int ftype_9pfs; > > +static unsigned int get_fid(struct dev_9pfs *dev) > +{ > + unsigned int fid; > + > + fid = ffs(dev->fid_mask); > + if ( fid ) > + dev->fid_mask &= ~(1ULL << (fid - 1)); > + > + return fid; > +} > + > +static void put_fid(struct dev_9pfs *dev, unsigned int fid) > +{ > + if ( fid ) > + dev->fid_mask |= 1ULL << (fid - 1); > +} > + > static struct req *get_free_req(struct dev_9pfs *dev) > { > struct req *req; > @@ -140,6 +177,9 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > * send_9p() and rcv_9p() are using a special format string for specifying > * the kind of data sent/expected. Each data item is represented by a single > * character: > + * b: 1 byte unsigned integer (uint8_t) > + * Only valid for sending. > + * u: 2 byte unsigned integer (uint16_t) > * U: 4 byte unsigned integer (uint32_t) > * S: String (2 byte length + characters) > * in the rcv_9p() case the data for string is allocated (length omitted, > @@ -153,7 +193,9 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > va_list ap, aq; > const char *f; > uint32_t intval; > + uint16_t shortval; > uint16_t len; > + uint8_t byte; > char *strval; > > hdr.size = sizeof(hdr); > @@ -167,6 +209,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > { > switch ( *f ) > { > + case 'b': > + hdr.size += 1; > + byte = va_arg(aq, unsigned int); > + break; > + case 'u': > + hdr.size += 2; > + shortval = va_arg(aq, unsigned int); > + break; > case 'U': > hdr.size += 4; > intval = va_arg(aq, unsigned int); > @@ -196,6 +246,14 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > { > switch ( *f ) > { > + case 'b': > + byte = va_arg(ap, unsigned int); > + copy_to_ring(dev, &byte, sizeof(byte)); > + break; > + case 'u': > + shortval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &shortval, sizeof(shortval)); > + break; > case 'U': > intval = va_arg(ap, unsigned int); > copy_to_ring(dev, &intval, sizeof(intval)); > @@ -288,6 +346,7 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > char *str; > uint16_t len; > uint32_t err; > + uint16_t *shortval; > uint32_t *val; > char **strval; > uint8_t *qval; > @@ -345,6 +404,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > { > switch ( *f ) > { > + case 'u': > + shortval = va_arg(ap, uint16_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, shortval, sizeof(*shortval)); > + break; > case 'U': > val = va_arg(ap, uint32_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > @@ -486,6 +549,170 @@ static int p9_attach(struct dev_9pfs *dev) > return ret; > } > > +static int p9_clunk(struct dev_9pfs *dev, uint32_t fid) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_CLUNK; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, ""); > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_walk(struct dev_9pfs *dev, uint32_t fid, uint32_t newfid, > + char *name) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint16_t nqid; > + uint8_t qid[P9_QID_SIZE]; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_WALK; > + if ( name[0] ) > + { > + send_9p(dev, req, "UUuS", fid, newfid, 1, name); > + rcv_9p(dev, req, "uQ", &nqid, qid); > + } > + else > + { > + send_9p(dev, req, "UUu", fid, newfid, 0); > + rcv_9p(dev, req, "u", &nqid); > + } > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_open(struct dev_9pfs *dev, uint32_t fid, uint8_t omode) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t iounit; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_OPEN; > + send_9p(dev, req, "Ub", fid, omode); > + rcv_9p(dev, req, "QU", qid, &iounit); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, > + uint32_t mode, uint8_t omode) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t iounit; > + > + if ( !req ) > + return EAGAIN; > + > + req->cmd = P9_CMD_CREATE; > + send_9p(dev, req, "USUbS", fid, path, mode, omode, ""); > + rcv_9p(dev, req, "QU", qid, &iounit); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +/* > + * Walk from root levels with the levels listed in <*paths> as a > + * sequence of names. Returns the number of steps not having been able to > + * walk, with <*paths> pointing at the name of the failing walk step. > + * will be associated with the last successful walk step. Note that > + * the first step should always succeed, as it is an empty walk in order > + * to start at the root (needed for creating new files in root). > + */ > +static unsigned int walk_9pfs(struct dev_9pfs *dev, uint32_t fid, > + unsigned int steps, char **paths) > +{ > + uint32_t curr_fid = P9_ROOT_FID; > + int ret; > + > + while ( steps-- ) > + { > + ret = p9_walk(dev, curr_fid, fid, *paths); > + if ( ret ) > + return steps + 1; > + curr_fid = fid; > + *paths += strlen(*paths) + 1; > + } > + > + return 0; > +} > + > +static unsigned int split_path(const char *pathname, char **split_ptr) > +{ > + unsigned int parts = 1; > + char *p; > + > + *split_ptr = strdup(pathname); > + > + for ( p = strchr(*split_ptr, '/'); p; p = strchr(p + 1, '/') ) > + { > + *p = 0; > + parts++; > + } > + > + return parts; > +} > + > +static bool path_canonical(const char *pathname) > +{ > + unsigned int len = strlen(pathname); > + const char *c; > + > + /* Empty path is allowed. */ > + if ( !len ) > + return true; > + > + /* No trailing '/'. */ > + if ( pathname[len - 1] == '/' ) > + return false; > + > + /* No self or parent references. */ > + c = pathname; > + while ( (c = strstr(c, "/.")) != NULL ) > + { > + if ( c[2] == '.' ) > + c++; > + if ( c[2] == 0 || c[2] == '/' ) > + return false; > + c += 2; > + } > + > + /* No "//". */ > + if ( strstr(pathname, "//") ) > + return false; > + > + return true; > +} > + > static int connect_9pfs(struct dev_9pfs *dev) > { > int ret; > @@ -504,10 +731,101 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > wake_up(&dev->waitq); > } > > +static int close_9pfs(struct file *file) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + > + if ( f9pfs->fid != P9_ROOT_FID ) > + { > + p9_clunk(f9pfs->dev, f9pfs->fid); > + put_fid(f9pfs->dev, f9pfs->fid); > + } > + > + free(f9pfs); > + > + return 0; > +} > + > static int open_9pfs(struct mount_point *mnt, const char *pathname, int flags, > mode_t mode) > { > - errno = ENOSYS; > + int fd; > + char *path = NULL; > + char *p; > + struct file *file; > + struct file_9pfs *f9pfs; > + uint16_t nwalk; > + uint8_t omode; > + int ret; > + > + if ( !path_canonical(pathname) ) > + return EINVAL; > + > + f9pfs = calloc(1, sizeof(*f9pfs)); > + f9pfs->dev = mnt->dev; > + f9pfs->fid = P9_ROOT_FID; > + > + fd = alloc_fd(ftype_9pfs); > + file = get_file_from_fd(fd); > + file->filedata = f9pfs; > + > + switch ( flags & O_ACCMODE ) > + { > + case O_RDONLY: > + omode = P9_OREAD; > + break; > + case O_WRONLY: > + omode = P9_OWRITE; > + break; > + case O_RDWR: > + omode = P9_ORDWR; > + break; > + default: > + ret = EINVAL; > + goto err; > + } > + > + if ( flags & O_TRUNC ) > + omode |= P9_OTRUNC; > + f9pfs->append = flags & O_APPEND; > + > + nwalk = split_path(pathname, &path); > + > + f9pfs->fid = get_fid(mnt->dev); > + if ( !f9pfs->fid ) > + { > + ret = ENFILE; > + goto err; > + } > + p = path; > + nwalk = walk_9pfs(mnt->dev, f9pfs->fid, nwalk, &p); > + if ( nwalk ) > + { > + if ( nwalk > 1 || !(flags & O_CREAT) ) > + { > + ret = ENOENT; > + goto err; > + } > + > + ret = p9_create(mnt->dev, f9pfs->fid, p, mode, omode); > + if ( ret ) > + goto err; > + goto out; > + } > + > + ret = p9_open(mnt->dev, f9pfs->fid, omode); > + if ( ret ) > + goto err; > + > + out: > + free(path); > + > + return fd; > + > + err: > + free(path); > + close(fd); > + errno = ret; > > return -1; > } > @@ -552,6 +870,7 @@ void *init_9pfront(unsigned int id, const char *mnt) > init_waitqueue_head(&dev->waitq); > init_SEMAPHORE(&dev->ring_out_sem, 1); > init_SEMAPHORE(&dev->ring_in_sem, 1); > + dev->fid_mask = ~0ULL; > > for ( i = 0; i < N_REQS; i++ ) > { > @@ -753,6 +1072,7 @@ void shutdown_9pfront(void *dev) > > static const struct file_ops ops_9pfs = { > .name = "9pfs", > + .close = close_9pfs, > }; > > __attribute__((constructor)) > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Mon Feb 13 23:13:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 23:13:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494864.765024 (Exim 4.92) (envelope-from ) id 1pRi0d-0004tY-C4; Mon, 13 Feb 2023 23:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494864.765024; Mon, 13 Feb 2023 23:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0d-0004tR-7Y; Mon, 13 Feb 2023 23:13:19 +0000 Received: by outflank-mailman (input) for mailman id 494864; Mon, 13 Feb 2023 23:13:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0b-0004r4-6P for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:13:17 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fde687da-abf3-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 00:13:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3EB982015E; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0yD5qTvQaE0; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 17D792013C; Tue, 14 Feb 2023 00:13:14 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRi0X-00FwK0-2O; Tue, 14 Feb 2023 00:13:13 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fde687da-abf3-11ed-933c-83870f6b2ba8 Date: Tue, 14 Feb 2023 00:13:13 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 7/7] Mini-OS: add read and write support to 9pfsfront Message-ID: <20230213231313.hryz7fynrpztzmf2@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> <20230213084412.21065-8-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-8-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Juergen Gross, le lun. 13 févr. 2023 09:44:12 +0100, a ecrit: > Add support to read from and write to a file handled by 9pfsfront. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add check for max message size > - return EAGAIN in case no free request got (Samuel Thibault) > - loop until all data read/written (Samuel Thibault) > V3: > - use an exact limit for read/write (Samuel Thibault) > - log read(write errors (Samuel Thibault) > --- > 9pfront.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 216 insertions(+) > > diff --git a/9pfront.c b/9pfront.c > index fb2e5669..5da8a365 100644 > --- a/9pfront.c > +++ b/9pfront.c > @@ -72,7 +72,10 @@ struct file_9pfs { > #define P9_CMD_WALK 110 > #define P9_CMD_OPEN 112 > #define P9_CMD_CREATE 114 > +#define P9_CMD_READ 116 > +#define P9_CMD_WRITE 118 > #define P9_CMD_CLUNK 120 > +#define P9_CMD_STAT 124 > > /* P9 protocol open flags. */ > #define P9_OREAD 0 /* read */ > @@ -88,11 +91,39 @@ struct p9_header { > uint16_t tag; > } __attribute__((packed)); > > +struct p9_stat { > + uint16_t size; > + uint16_t type; > + uint32_t dev; > + uint8_t qid[P9_QID_SIZE]; > + uint32_t mode; > + uint32_t atime; > + uint32_t mtime; > + uint64_t length; > + char *name; > + char *uid; > + char *gid; > + char *muid; > + char *extension; > + uint32_t n_uid; > + uint32_t n_gid; > + uint32_t n_muid; > +}; > + > #define P9_VERSION "9P2000.u" > #define P9_ROOT_FID 0 > > static unsigned int ftype_9pfs; > > +static void free_stat(struct p9_stat *stat) > +{ > + free(stat->name); > + free(stat->uid); > + free(stat->gid); > + free(stat->muid); > + free(stat->extension); > +} > + > static unsigned int get_fid(struct dev_9pfs *dev) > { > unsigned int fid; > @@ -181,9 +212,12 @@ static void copy_from_ring(struct dev_9pfs *dev, void *data, unsigned int len) > * Only valid for sending. > * u: 2 byte unsigned integer (uint16_t) > * U: 4 byte unsigned integer (uint32_t) > + * L: 8 byte unsigned integer (uint64_t) > * S: String (2 byte length + characters) > * in the rcv_9p() case the data for string is allocated (length omitted, > * string terminated by a NUL character) > + * D: Binary data (4 byte length + bytes of data), requires a length > + * and a buffer pointer parameter. > * Q: A 13 byte "qid", consisting of 1 byte file type, 4 byte file version > * and 8 bytes unique file id. Only valid for receiving. > */ > @@ -192,10 +226,12 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > struct p9_header hdr; > va_list ap, aq; > const char *f; > + uint64_t longval; > uint32_t intval; > uint16_t shortval; > uint16_t len; > uint8_t byte; > + uint8_t *data; > char *strval; > > hdr.size = sizeof(hdr); > @@ -221,11 +257,21 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > hdr.size += 4; > intval = va_arg(aq, unsigned int); > break; > + case 'L': > + hdr.size += 8; > + longval = va_arg(aq, uint64_t); > + break; > case 'S': > hdr.size += 2; > strval = va_arg(aq, char *); > hdr.size += strlen(strval); > break; > + case 'D': > + hdr.size += 4; > + intval = va_arg(aq, unsigned int); > + hdr.size += intval; > + data = va_arg(aq, uint8_t *); > + break; > default: > printk("send_9p: unknown format character %c\n", *f); > break; > @@ -258,12 +304,22 @@ static void send_9p(struct dev_9pfs *dev, struct req *req, const char *fmt, ...) > intval = va_arg(ap, unsigned int); > copy_to_ring(dev, &intval, sizeof(intval)); > break; > + case 'L': > + longval = va_arg(ap, uint64_t); > + copy_to_ring(dev, &longval, sizeof(longval)); > + break; > case 'S': > strval = va_arg(ap, char *); > len = strlen(strval); > copy_to_ring(dev, &len, sizeof(len)); > copy_to_ring(dev, strval, len); > break; > + case 'D': > + intval = va_arg(ap, unsigned int); > + copy_to_ring(dev, &intval, sizeof(intval)); > + data = va_arg(ap, uint8_t *); > + copy_to_ring(dev, data, intval); > + break; > } > } > > @@ -348,6 +404,8 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > uint32_t err; > uint16_t *shortval; > uint32_t *val; > + uint64_t *longval; > + uint8_t *data; > char **strval; > uint8_t *qval; > > @@ -412,6 +470,10 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > val = va_arg(ap, uint32_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > break; > + case 'L': > + longval = va_arg(ap, uint64_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, longval, sizeof(*longval)); > + break; > case 'S': > strval = va_arg(ap, char **); > copy_bufs(&buf1, &buf2, &len1, &len2, &len, sizeof(len)); > @@ -419,6 +481,12 @@ static void rcv_9p_copy(struct dev_9pfs *dev, struct req *req, > copy_bufs(&buf1, &buf2, &len1, &len2, *strval, len); > (*strval)[len] = 0; > break; > + case 'D': > + val = va_arg(ap, uint32_t *); > + data = va_arg(ap, uint8_t *); > + copy_bufs(&buf1, &buf2, &len1, &len2, val, sizeof(*val)); > + copy_bufs(&buf1, &buf2, &len1, &len2, data, *val); > + break; > case 'Q': > qval = va_arg(ap, uint8_t *); > copy_bufs(&buf1, &buf2, &len1, &len2, qval, P9_QID_SIZE); > @@ -640,6 +708,115 @@ static int p9_create(struct dev_9pfs *dev, uint32_t fid, char *path, > return ret; > } > > +static int p9_stat(struct dev_9pfs *dev, uint32_t fid, struct p9_stat *stat) > +{ > + struct req *req = get_free_req(dev); > + int ret; > + > + if ( !req ) > + return EAGAIN; > + > + memset(stat, 0, sizeof(*stat)); > + req->cmd = P9_CMD_STAT; > + send_9p(dev, req, "U", fid); > + rcv_9p(dev, req, "uuUQUUULSSSSSUUU", &stat->size, &stat->type, &stat->dev, > + stat->qid, &stat->mode, &stat->atime, &stat->mtime, &stat->length, > + &stat->name, &stat->uid, &stat->gid, &stat->muid, &stat->extension, > + &stat->n_uid, &stat->n_gid, &stat->n_muid); > + > + ret = req->result; > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_read(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count, count_max; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_READ; > + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t)); > + > + while ( len ) > + { > + count = len; > + if ( count > count_max ) > + count = count_max; > + > + send_9p(dev, req, "ULU", fid, offset, count); > + rcv_9p(dev, req, "D", &count, data); > + > + if ( !count ) > + break; > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + printk("9pfs: read got error %d\n", req->result); > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > +static int p9_write(struct dev_9pfs *dev, uint32_t fid, uint64_t offset, > + const uint8_t *data, uint32_t len) > +{ > + struct req *req = get_free_req(dev); > + int ret = 0; > + uint32_t count, count_max; > + > + if ( !req ) > + { > + errno = EAGAIN; > + return -1; > + } > + req->cmd = P9_CMD_WRITE; > + count_max = dev->msize_max - (sizeof(struct p9_header) + sizeof(uint32_t) + > + sizeof(uint64_t) + sizeof(uint32_t)); > + > + while ( len ) > + { > + count = len; > + if ( count > count_max ) > + count = count_max; > + > + send_9p(dev, req, "ULD", fid, offset, count, data); > + rcv_9p(dev, req, "U", &count); > + if ( req->result ) > + { > + ret = -1; > + errno = EIO; > + printk("9pfs: write got error %d\n", req->result); > + break; > + } > + ret += count; > + offset += count; > + data += count; > + len -= count; > + } > + > + put_free_req(dev, req); > + > + return ret; > +} > + > /* > * Walk from root levels with the levels listed in <*paths> as a > * sequence of names. Returns the number of steps not having been able to > @@ -731,6 +908,43 @@ static void intr_9pfs(evtchn_port_t port, struct pt_regs *regs, void *data) > wake_up(&dev->waitq); > } > > +static int read_9pfs(struct file *file, void *buf, size_t nbytes) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + int ret; > + > + ret = p9_read(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); > + if ( ret >= 0 ) > + file->offset += ret; > + > + return ret; > +} > + > +static int write_9pfs(struct file *file, const void *buf, size_t nbytes) > +{ > + struct file_9pfs *f9pfs = file->filedata; > + struct p9_stat stat; > + int ret; > + > + if ( f9pfs->append ) > + { > + ret = p9_stat(f9pfs->dev, f9pfs->fid, &stat); > + free_stat(&stat); > + if ( ret ) > + { > + errno = EIO; > + return -1; > + } > + file->offset = stat.length; > + } > + > + ret = p9_write(f9pfs->dev, f9pfs->fid, file->offset, buf, nbytes); > + if ( ret >= 0 ) > + file->offset += ret; > + > + return ret; > +} > + > static int close_9pfs(struct file *file) > { > struct file_9pfs *f9pfs = file->filedata; > @@ -1072,6 +1286,8 @@ void shutdown_9pfront(void *dev) > > static const struct file_ops ops_9pfs = { > .name = "9pfs", > + .read = read_9pfs, > + .write = write_9pfs, > .close = close_9pfs, > }; > > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Mon Feb 13 23:13:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 23:13:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494866.765039 (Exim 4.92) (envelope-from ) id 1pRi0m-0005E8-Lr; Mon, 13 Feb 2023 23:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494866.765039; Mon, 13 Feb 2023 23:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0m-0005Dz-Id; Mon, 13 Feb 2023 23:13:28 +0000 Received: by outflank-mailman (input) for mailman id 494866; Mon, 13 Feb 2023 23:13:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRi0l-0004r4-A4 for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:13:27 +0000 Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04819dda-abf4-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 51D392015E; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I6mMgcOWUcc4; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from begin (lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr [92.158.138.184]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 33F742013C; Tue, 14 Feb 2023 00:13:25 +0100 (CET) Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRi0i-00FwLB-2v; Tue, 14 Feb 2023 00:13:24 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04819dda-abf4-11ed-933c-83870f6b2ba8 Date: Tue, 14 Feb 2023 00:13:24 +0100 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH v3 0/7] Mini-OS: add minimal 9pfs support Message-ID: <20230213231324.zfax6v5elvndzky3@begin> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20230213084412.21065-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230213084412.21065-1-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) Thanks!! Juergen Gross, le lun. 13 févr. 2023 09:44:05 +0100, a ecrit: > This series is adding minimal support to use 9pfs in Mini-OS. It is > adding a PV 9pfs frontend and the ability to open, close, read and > write files. > > The series has been tested with qemu as 9pfs backend in a PVH Mini-OS > guest (I've used a slightly modified Xenstore-stubdom for that purpose > in order to reuse the build runes). > > This series is meant to setup the stage for adding file based logging > support to Xenstore-stubdom and later to add live update support (being > able to save the LU data stream in a dom0 file makes this a _lot_ > easier). > > In order to keep Mini-OS's license I have only used the protocol docs > available on the internet [1] and then verified those with the qemu 9pfs > backend implementation (especially for supporting the 9P2000.u variant, > as qemu doesn't support the basic 9P2000 protocol). > > The needed fixed values of the protocol have been taken from [2]. > > [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html > [2]: https://github.com/0intro/libixp > > Changes in V2: > - addressed comments by Samuel Thibault > > Changes in V3: > - addressed comments by Samuel Thibault and Andrew Cooper > > Juergen Gross (7): > Mini-OS: xenbus: add support for reading node from directory > Mini-OS: add concept of mount points > Mini-OS: add support for runtime mounts > Mini-OS: add 9pfs frontend > Mini-OS: add 9pfs transport layer > Mini-OS: add open and close handling to the 9pfs frontend > Mini-OS: add read and write support to 9pfsfront > > 9pfront.c | 1300 +++++++++++++++++++++++++++++++++ > Config.mk | 1 + > Makefile | 1 + > arch/x86/testbuild/all-no | 1 + > arch/x86/testbuild/all-yes | 1 + > arch/x86/testbuild/newxen-yes | 1 + > include/9pfront.h | 7 + > include/lib.h | 14 + > include/xenbus.h | 6 + > lib/sys.c | 123 +++- > xenbus.c | 40 +- > 11 files changed, 1473 insertions(+), 22 deletions(-) > create mode 100644 9pfront.c > create mode 100644 include/9pfront.h > > -- > 2.35.3 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. From xen-devel-bounces@lists.xenproject.org Mon Feb 13 23:42:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 23:42:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494884.765050 (Exim 4.92) (envelope-from ) id 1pRiSS-0000xK-TU; Mon, 13 Feb 2023 23:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494884.765050; Mon, 13 Feb 2023 23:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRiSS-0000xD-Ps; Mon, 13 Feb 2023 23:42:04 +0000 Received: by outflank-mailman (input) for mailman id 494884; Mon, 13 Feb 2023 23:42:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRiSR-0000x3-E3; Mon, 13 Feb 2023 23:42:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRiSR-0005EA-As; Mon, 13 Feb 2023 23:42:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRiSQ-0007Ms-Vg; Mon, 13 Feb 2023 23:42:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRiSQ-0005F6-VF; Mon, 13 Feb 2023 23:42:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VqB2U9RzOF8+rn9XNNmIqbJypshiARBe8TzQufcdAPc=; b=1ag+X2ijbl89w/Mkoip3H/2cy4 m8lTFUmUrfx4oWWUEM+kvd60ADw6dATbvUCYXN9H3j+HTAe95K0Wv/8kfewpalmXnIqnjQ3gr2+8F rG/bK1ywQu5kGCPn7jCfWPCqUictIAD5X4gH0XVSoePy+o9yCbEWH3+hx7cGG00ECrhI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177177: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=ceaa837f96adb69c0df0397937cd74991d5d821a X-Osstest-Versions-That: linux=711e9a4d52bf4e477e51c7135e1e6188c42018d0 From: osstest service owner Date: Mon, 13 Feb 2023 23:42:02 +0000 flight 177177 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177177/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177104 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177104 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177104 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177104 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177104 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux ceaa837f96adb69c0df0397937cd74991d5d821a baseline version: linux 711e9a4d52bf4e477e51c7135e1e6188c42018d0 Last test of basis 177104 2023-02-12 20:42:38 Z 1 days Testing same since 177133 2023-02-13 03:40:57 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Geert Uytterhoeven John Paul Adrian Glaubitz Linus Torvalds Steven Rostedt (Google) Yafang Shao Yoshinori Sato jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 711e9a4d52bf..ceaa837f96ad ceaa837f96adb69c0df0397937cd74991d5d821a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Feb 13 23:57:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 13 Feb 2023 23:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494894.765060 (Exim 4.92) (envelope-from ) id 1pRih1-0002ln-9m; Mon, 13 Feb 2023 23:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494894.765060; Mon, 13 Feb 2023 23:57:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRih1-0002lg-6i; Mon, 13 Feb 2023 23:57:07 +0000 Received: by outflank-mailman (input) for mailman id 494894; Mon, 13 Feb 2023 23:57:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRih0-0002lW-8k for xen-devel@lists.xenproject.org; Mon, 13 Feb 2023 23:57:06 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ca9f1b2-abfa-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 00:57:04 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E8D03CE0B18; Mon, 13 Feb 2023 23:57:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFCB6C433EF; Mon, 13 Feb 2023 23:56:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ca9f1b2-abfa-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676332620; bh=ooG84o3Fy2ttUBPRj/D/CuBk20QbKBTFeLh70y8Iqi8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cV2b5FBj3UMizrspCC4XDHZJDFS8i4w/Fhw12GLGloz7Vr/67qfq2mJ+3bdLIFWMH qR3d6uu0hezC8AlFPEh1qRGAEO2D6hjQd5W2cAEUt/F76ByvAMAXZ1WRD5C7gPj3Ge 0kxpRRQhVgk55ggVX0CR6TJ/S9Zuy7mkB8Uez5ArY3ye394+2373X56cnHW+SsbvO6 Z4ZXahVWz8g0uY+RnQdfGofvhkkhbaARW3hfmZPZhLIg+3zWhYxiI4FwuBHxgPi9wS d9r1FfrU1Xy8KPlYNTWHt5zoi+tA5qa9x/lC/5ROKElHj9f5Q4heJLWKGTjmXWXwsF MuYZ+p+Mhlwvg== Date: Mon, 13 Feb 2023 15:56:58 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH] automation: Add container and build jobs to run cppcheck analysis In-Reply-To: <20230213142312.11806-1-michal.orzel@amd.com> Message-ID: References: <20230213142312.11806-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 13 Feb 2023, Michal Orzel wrote: > Add a debian container with cppcheck installation routine inside, > capable of performing cppcheck analysis on Xen-only build including > cross-builds for arm32 and arm64. > > Populate build jobs making use of that container to run cppcheck > analysis to produce a text report (xen-cppcheck.txt) containing the list > of all the findings. > > This patch does not aim at performing any sort of bisection. Cppcheck is > imperfect and for now, our goal is to at least be aware of its reports, > so that we can compare them with the ones produced by better tools and > to be able to see how these reports change as a result of further > infrastructure improvements (e.g. exception list, rules exclusion). > > Signed-off-by: Michal Orzel Thanks for the patch, very nice! > --- > For those interested in, here is a sample pipeline: > https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 > --- > .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ > automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ > automation/scripts/build | 11 ++++- > 3 files changed, 87 insertions(+), 1 deletion(-) > create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile > > diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile > new file mode 100644 > index 000000000000..39bcc50673c8 > --- /dev/null > +++ b/automation/build/debian/unstable-cppcheck.dockerfile > @@ -0,0 +1,37 @@ > +FROM debian:unstable > +LABEL maintainer.name="The Xen Project" \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV CPPCHECK_VERSION=2.7 > +ENV USER root > + > +RUN mkdir /build > +WORKDIR /build > + > +# dependencies for cppcheck and Xen-only build/cross-build > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + build-essential \ > + curl \ > + python-is-python3 \ > + libpcre3-dev \ > + flex \ > + bison \ > + gcc-arm-linux-gnueabihf \ > + gcc-aarch64-linux-gnu > + > +# cppcheck release build (see cppcheck readme.md) > +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ > + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ > + cd cppcheck-"$CPPCHECK_VERSION" && \ > + make install -j$(nproc) \ > + MATCHCOMPILER=yes \ > + FILESDIR=/usr/share/cppcheck \ > + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" > + > +# clean > +RUN apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* && \ > + rm -rf cppcheck-"$CPPCHECK_VERSION"* "$CPPCHECK_VERSION".tar.gz > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a053c5c7325d..c8831ccbec7a 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -7,6 +7,7 @@ > paths: > - binaries/ > - xen-config > + - xen-cppcheck.txt > - '*.log' > - '*/*.log' > when: always > @@ -145,6 +146,23 @@ > variables: > <<: *gcc > > +.arm64-cross-build-tmpl: > + <<: *build > + variables: > + XEN_TARGET_ARCH: arm64 > + tags: > + - x86_64 > + > +.arm64-cross-build: > + extends: .arm64-cross-build-tmpl > + variables: > + debug: n > + > +.gcc-arm64-cross-build: > + extends: .arm64-cross-build > + variables: > + <<: *gcc > + > .arm64-build-tmpl: > <<: *build > variables: > @@ -679,6 +697,28 @@ archlinux-current-gcc-riscv64-debug-randconfig: > EXTRA_FIXED_RANDCONFIG: > CONFIG_COVERAGE=n > > +# Cppcheck analysis jobs > + > +debian-unstable-gcc-cppcheck: > + extends: .gcc-x86-64-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CPPCHECK: y > + > +debian-unstable-gcc-arm32-cppcheck: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- > + CPPCHECK: y > + > +debian-unstable-gcc-arm64-cppcheck: > + extends: .gcc-arm64-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/aarch64-linux-gnu- > + CPPCHECK: y > + > ## Test artifacts common > > .test-jobs-artifact-common: > diff --git a/automation/scripts/build b/automation/scripts/build > index f2f5e55bc04f..c219752d553e 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -38,7 +38,16 @@ cp xen/.config xen-config > # Directory for the artefacts to be dumped into > mkdir binaries > > -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > +if [[ "${CPPCHECK}" == "y" ]]; then > + # Cppcheck analysis invokes Xen-only build. Given that when $CPPCHECK == y we are doing a hypervisor-only build, what do you think of also specifying $HYPERVISOR_ONLY == y in these cases? We could set both CPPCHECK=y and HYPERVISOR_ONLY=y in build.yaml and then here also check for both. > + # Known limitation: cppcheck generates inconsistent reports when running > + # in parallel mode, therefore do not specify -j. I take you tried -j$(nproc) on gitlab-ci and didn't work well? I tested -j$(nproc) in my native arm64 environment and seemed to work well. > + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra > + > + # Preserve artefacts > + cp xen/xen binaries/xen > + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt > +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > # Xen-only build > make -j$(nproc) xen > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 00:32:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 00:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494901.765083 (Exim 4.92) (envelope-from ) id 1pRjFJ-00007b-Ku; Tue, 14 Feb 2023 00:32:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494901.765083; Tue, 14 Feb 2023 00:32:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjFJ-00007T-HA; Tue, 14 Feb 2023 00:32:33 +0000 Received: by outflank-mailman (input) for mailman id 494901; Tue, 14 Feb 2023 00:32:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjFI-0008Jd-8V for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 00:32:32 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11392cc6-abff-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 01:32:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3805B81A2B; Tue, 14 Feb 2023 00:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE6CCC4339B; Tue, 14 Feb 2023 00:32:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11392cc6-abff-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676334749; bh=Iko+bq06Ug3Z5JNn58WE7Wj2iLf6aIMHm/3cFv7xpJs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EhLdV79I/6i80Yd8Aiz2Vg3Zi+a3bjaqeFgjqr8nW3FLxVi0RJgEe188ojSAUj54w 1Bf8Imhc5E4LWJAX6bcGAa5dI7Xwt7yHg5EeYed6VkmFSULiPQ2bvspK3C42CoaqWn gah+G8A0N/zjapmMAr5ojgyQKVsZc5rbAgnoxk2xn3eo17Lv90YAi/ZvYfThZ4+we0 P6lw6dDln8SeU+vWVEV+tmw8iOSmuy+1mv4xXug0NpkSdGEYDanrriKakrqfZhk1QV FrPZ9lhCkXq2Gnvtl31Da2LmWMQW95TVJkqxT0VH6NV6RyCvmL46m7J58jV1+CgvWQ Rl3wcPLKvzC1w== Date: Mon, 13 Feb 2023 16:32:27 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 2/3] automation: Add a static memory allocation test on arm32 In-Reply-To: <20230213142210.11728-3-michal.orzel@amd.com> Message-ID: References: <20230213142210.11728-1-michal.orzel@amd.com> <20230213142210.11728-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 13 Feb 2023, Michal Orzel wrote: > Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug > and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh > script to test static memory allocation feature. The test case itself > is directly taken from dom0less arm64 testing. > > Populate build jobs to compile Xen with config options necessary to > enable static memory feature. Populate test jobs passing "static-mem" > as a test variant. The test configures domU with a static memory region > (direct-mapped) and adds a check using /proc/iomem to determine the > memory region marked as "System RAM". > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/gitlab-ci/build.yaml | 20 +++++++++++++++++++ > automation/gitlab-ci/test.yaml | 16 +++++++++++++++ > .../scripts/qemu-smoke-dom0less-arm32.sh | 17 ++++++++++++++++ > 3 files changed, 53 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a053c5c7325d..166182bc595f 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig: > HYPERVISOR_ONLY: y > RANDCONFIG: y > > +debian-unstable-gcc-arm32-staticmem: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + HYPERVISOR_ONLY: y > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > +debian-unstable-gcc-arm32-debug-staticmem: > + extends: .gcc-arm32-cross-build-debug > + variables: > + CONTAINER: debian:unstable-arm32-gcc > + HYPERVISOR_ONLY: y > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > # Arm builds > > debian-unstable-gcc-arm64: > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 84ab1fee50a4..c2bcc5d4d3e5 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -226,6 +226,22 @@ qemu-smoke-dom0less-arm32-gcc-debug: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > > +qemu-smoke-dom0less-arm32-gcc-staticmem: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-staticmem > + > +qemu-smoke-dom0less-arm32-gcc-debug-staticmem: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug-staticmem > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > index c81529cbbfd0..f89ee8b6464a 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -17,6 +17,19 @@ echo \"${passed}\" > " > fi > > +if [[ "${test_variant}" == "static-mem" ]]; then > + # Memory range that is statically allocated to domU1 > + domu_base="0x50000000" > + domu_size="0x20000000" > + passed="${test_variant} test passed" > + domU_check=" > +mem_range=$(printf \"%08x-%08x\" ${domu_base} $(( ${domu_base} + ${domu_size} - 1 ))) > +if grep -q -x \"\${mem_range} : System RAM\" /proc/iomem; then > + echo \"${passed}\" > +fi > +" > +fi > + > # domU rootfs > mkdir rootfs > cd rootfs > @@ -62,6 +75,10 @@ BOOT_CMD="bootm" > UBOOT_SOURCE="boot.source" > UBOOT_SCRIPT="boot.scr"' > config > > +if [[ "${test_variant}" == "static-mem" ]]; then > + echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 00:32:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 00:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494900.765071 (Exim 4.92) (envelope-from ) id 1pRjFG-0008Jt-Cb; Tue, 14 Feb 2023 00:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494900.765071; Tue, 14 Feb 2023 00:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjFG-0008Jm-9e; Tue, 14 Feb 2023 00:32:30 +0000 Received: by outflank-mailman (input) for mailman id 494900; Tue, 14 Feb 2023 00:32:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjFE-0008Jd-LD for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 00:32:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d7fd0fa-abff-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 01:32:26 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E3C861321; Tue, 14 Feb 2023 00:32:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54FA4C4339C; Tue, 14 Feb 2023 00:32:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d7fd0fa-abff-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676334744; bh=CmzQ3ydrXF7DAdGULECQXOz0eLrdJLfR7PmGzb35Uzo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=B1o8lFwspR/5DbcILwtsqMXDkQcoWscbl1EBvsPG0Wx+3seaR5lHuv0YIwjd0THKx 6GR+g7WFWxAcUt3wqbnGIWHrw8HWeunjCPk3H4I2h7lBa02TnK9aoshyMPEKBvIERL 1VE15qpLq/plhTtwgoJtDtM3hGvujDuI/PgxSS2UEL0uiwz4+BOxqoi47BJgSBYn5r ENdz3AaVota3zhIWHi6cdAoStRwu1OE6/Ka/1rj+1X7tXlPvUCvN4efFEAml1yMM5/ 6AcLg6yC6b30abPGK1HBS0CSmkPjUmVyH5xasSgDPIU/XuDnjJcHKzInhwKYOgHk7H viEYgvxhR6jSw== Date: Mon, 13 Feb 2023 16:32:21 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 3/3] automation: Add a gzip compressed kernel image test on arm32 In-Reply-To: <20230213142210.11728-4-michal.orzel@amd.com> Message-ID: References: <20230213142210.11728-1-michal.orzel@amd.com> <20230213142210.11728-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 13 Feb 2023, Michal Orzel wrote: > Xen supports booting gzip compressed kernels, therefore add a new test > job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant > that will execute qemu-smoke-dom0less-arm32.sh script to test booting > a domU with a gzip compressed kernel image (in our case zImage). > > By passing "gzip" as a test variant, the test will call gzip command > to compress kernel image and use it in ImageBuilder configuration. > No need for a specific check to be executed from domU. Being able to > see a test message from a boot log is sufficient to mark a test as > passed. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ > automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index c2bcc5d4d3e5..be7a55d89708 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -242,6 +242,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-staticmem: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug-staticmem > > +qemu-smoke-dom0less-arm32-gcc-gzip: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32 > + > +qemu-smoke-dom0less-arm32-gcc-debug-gzip: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > index f89ee8b6464a..b420ee444f2a 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -30,6 +30,15 @@ fi > " > fi > > +if [[ "${test_variant}" == "gzip" ]]; then > + # Compress kernel image with gzip > + gzip vmlinuz > + passed="${test_variant} test passed" > + domU_check=" > +echo \"${passed}\" > +" > +fi > + > # domU rootfs > mkdir rootfs > cd rootfs > @@ -79,6 +88,10 @@ if [[ "${test_variant}" == "static-mem" ]]; then > echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config > fi > > +if [[ "${test_variant}" == "gzip" ]]; then > + sed -i "s/vmlinuz/vmlinuz.gz/g" config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 00:37:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 00:37:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494912.765094 (Exim 4.92) (envelope-from ) id 1pRjJk-00015O-67; Tue, 14 Feb 2023 00:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494912.765094; Tue, 14 Feb 2023 00:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjJk-00015H-32; Tue, 14 Feb 2023 00:37:08 +0000 Received: by outflank-mailman (input) for mailman id 494912; Tue, 14 Feb 2023 00:37:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjJj-00015B-Al for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 00:37:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3a7f48b-abff-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 01:37:04 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7023161321; Tue, 14 Feb 2023 00:37:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C52CC433D2; Tue, 14 Feb 2023 00:37:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a7f48b-abff-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676335022; bh=LWVgxA7660QhgQ8LMcPb/3gR9GHrpFJkhANiNSl2mZA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OyXMt5a5Z7P5DCLJrVfIAVtuu+TJI0bSWPsPOB97eS8enk+E/oawakZxz7HJwvL6l kXZcKf9bbYGLLm2hxPCQHaOQ51y2V+mKHjI3xZ2xtL/pppd59ep7AgHAf0n61E0UGa 4eNGCJTJDatFGtXSfPENs4wh5Q24cPX9C6Vb2tMVs9uG5V6DFz+egeu+zpUewggkuU qMqes7TxvQQdiOlsK+EP565QfN9sAbPTCfGyGNQNCVmYZZA286mikS40pYQ13Wt1T2 DxZu+jfplC8WIOzJaj+7LJ/tOlQlrhrdxH4t6OOUErv5k2kFyuzlSPQVx0YIPyhQgN /0zAKkhmu90hQ== Date: Mon, 13 Feb 2023 16:37:00 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 1/3] automation: Add arm32 dom0less testing In-Reply-To: <20230213142210.11728-2-michal.orzel@amd.com> Message-ID: References: <20230213142210.11728-1-michal.orzel@amd.com> <20230213142210.11728-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 13 Feb 2023, Michal Orzel wrote: > At the moment, we only perform a single arm32 test in our CI, checking > whether dom0 boots successfully or not. This is mostly because we do not > have any arm32 runners and we only execute a hypervisor only build. > > In order not to leave the arm32 testing in such a poor state, add a > script qemu-smoke-dom0less-arm32.sh to start testing true dom0less > configuration, in which case we do not need a dom0 with a toolstack. > > The script is mostly based on the one used for dom0 arm32 testing as well > as the one used for dom0less arm64 testing. We obtain Debian Bullseye > kernel and Alpine Linux busybox-based rootfs. Depending on the test > variant, we prepare a test case contained within domU_check variable, > that will be executed as part of /init script. > > Signed-off-by: Michal Orzel > --- > automation/gitlab-ci/test.yaml | 16 ++++ > .../scripts/qemu-smoke-dom0less-arm32.sh | 89 +++++++++++++++++++ > 2 files changed, 105 insertions(+) > create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index ce543ef5c0ef..84ab1fee50a4 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -210,6 +210,22 @@ qemu-smoke-dom0-arm32-gcc-debug: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > > +qemu-smoke-dom0less-arm32-gcc: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32 > + > +qemu-smoke-dom0less-arm32-gcc-debug: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > new file mode 100755 > index 000000000000..c81529cbbfd0 > --- /dev/null > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -0,0 +1,89 @@ > +#!/bin/bash > + > +set -ex > + > +test_variant=$1 > + > +cd binaries > +# Use the kernel from Debian > +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz > +# Use a tiny initrd based on busybox from Alpine Linux > +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz > + > +if [ -z "${test_variant}" ]; then > + passed="generic test passed" > + domU_check=" > +echo \"${passed}\" > +" > +fi > + > +# domU rootfs > +mkdir rootfs > +cd rootfs > +tar xvzf ../initrd.tar.gz > +echo "#!/bin/sh > + > +mount -t proc proc /proc > +mount -t sysfs sysfs /sys > +mount -t devtmpfs devtmpfs /dev > +${domU_check} > +/bin/sh" > init > +chmod +x init > +find . | cpio -H newc -o | gzip > ../initrd.gz > +cd .. > + > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > +./qemu-system-arm \ > + -machine virt \ > + -machine virtualization=true \ > + -smp 4 \ > + -m 1024 \ > + -serial stdio \ > + -monitor none \ > + -display none \ > + -machine dumpdtb=virt.dtb > + > +# ImageBuilder > +echo 'MEMORY_START="0x40000000" > +MEMORY_END="0x80000000" > + > +DEVICE_TREE="virt.dtb" > +XEN="xen" > +XEN_CMD="console=dtuart bootscrub=0" > + > +DOMU_KERNEL[0]="vmlinuz" > +DOMU_RAMDISK[0]="initrd.gz" > +DOMU_MEM[0]="512" > +NUM_DOMUS=1 Since we are at it I would prefer to create both dom0 and a domU to make the test more interesting. The following works on gitlab-ci on top of this patch. Would you be up for adding it to this patch? diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index b420ee444f..6e85bca21c 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -60,7 +60,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ @@ -68,11 +68,14 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt.dtb" XEN="xen" -XEN_CMD="console=dtuart bootscrub=0" +DOM0_KERNEL="vmlinuz" +DOM0_RAMDISK="initrd.gz" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" DOMU_KERNEL[0]="vmlinuz" DOMU_RAMDISK[0]="initrd.gz" @@ -105,7 +108,7 @@ timeout -k 1 240 \ -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ From xen-devel-bounces@lists.xenproject.org Tue Feb 14 01:11:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 01:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494921.765120 (Exim 4.92) (envelope-from ) id 1pRjrC-0004RA-Vb; Tue, 14 Feb 2023 01:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494921.765120; Tue, 14 Feb 2023 01:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjrC-0004R3-SN; Tue, 14 Feb 2023 01:11:42 +0000 Received: by outflank-mailman (input) for mailman id 494921; Tue, 14 Feb 2023 01:11:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjrB-0004Qe-LK; Tue, 14 Feb 2023 01:11:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjrB-0006Nt-Jl; Tue, 14 Feb 2023 01:11:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRjrB-0001SF-6H; Tue, 14 Feb 2023 01:11:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRjrB-0003Fm-5p; Tue, 14 Feb 2023 01:11:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o0wPHSYjjomlDXHYB+4KADCOcEjVLSZCxWxNnEIG6XY=; b=Oo4qINhdp21CQdzaVCZi1GZ+hg mS9xUVdn7oEd4z1ISDVm0WClfTKa3AdmW7ZeFhxWfFm9sNgn3jSJO1bEtrEtHkF8gAHa1UGiLNzR2 afXCJ6xNeUzjzYfyaVAaXVW9A3rkr1b1+TIDHrA0mPZ2rdPatCvkilOtIDG0ZJ8hBx+g=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177171: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f4f498d08d50259b9f25c274fd7b1e8ccf5693af X-Osstest-Versions-That: xen=01e7477d1b081cff4288ff9f51ec59ee94c03ee0 From: osstest service owner Date: Tue, 14 Feb 2023 01:11:41 +0000 flight 177171 xen-unstable real [real] flight 177219 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177171/ http://logs.test-lab.xenproject.org/osstest/logs/177219/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 177219-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 177219 like 177125 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177125 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177125 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177125 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177125 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 177125 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177125 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177125 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177125 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177125 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f4f498d08d50259b9f25c274fd7b1e8ccf5693af baseline version: xen 01e7477d1b081cff4288ff9f51ec59ee94c03ee0 Last test of basis 177125 2023-02-13 01:53:31 Z 0 days Testing same since 177171 2023-02-13 12:37:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Andrew Cooper Jan Beulich Juergen Gross Oleksii Kurochko jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 01e7477d1b..f4f498d08d f4f498d08d50259b9f25c274fd7b1e8ccf5693af -> master From xen-devel-bounces@lists.xenproject.org Tue Feb 14 01:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 01:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494937.765156 (Exim 4.92) (envelope-from ) id 1pRkPe-0000KC-4h; Tue, 14 Feb 2023 01:47:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494937.765156; Tue, 14 Feb 2023 01:47:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRkPe-0000K5-19; Tue, 14 Feb 2023 01:47:18 +0000 Received: by outflank-mailman (input) for mailman id 494937; Tue, 14 Feb 2023 01:47:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRkPa-0000Jz-Vh for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 01:47:17 +0000 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7bd1acd7-ac09-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 02:47:08 +0100 (CET) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PG3wj2fBzz4x83; Tue, 14 Feb 2023 12:47:01 +1100 (AEDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bd1acd7-ac09-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1676339222; bh=DqG9DcQPn7xEsXKwyAD0SLlB4Lu9cg4zqBqI7Y1r0YY=; h=Date:From:To:Cc:Subject:From; b=H7r1FGI9TymjxOnLcB046feu8PvCXoVRO2aP7Jr5UiZYcL1j6sxc7zJw1uedY3R1Y NPGwSbSdJ6vwT9DNEMWHQDbpNCL73+IgVxob0TEQ8bQ3wqF6kVbPMfqALI1B5vUuiJ D0O7oJFKZWYl72phOFRo/ZZ2qVDq58GcgLpEQ+WtwLxjq5qm+4sWdLzKp3D3WRWeka zCGy28KEBrzA8QGvGnBnoQ29PVTljU8upmpVbN5z1N0ERH94bz1W5ON9UxJsTafhVe fOe/miajREj61jfWr8Qxn9Os/lYIN92fyV8LPKD05j7J2jsRIEndbUVoMEuIoXlDSy wvSuG+IrW4seg== Date: Tue, 14 Feb 2023 12:47:00 +1100 From: Stephen Rothwell To: Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra Cc: Xen Devel , Per Bilse , Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: duplicate patches in the xen-tip tree Message-ID: <20230214124700.22f0a62e@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/trHzM3Ym2fGntxRvaoo7o_b"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/trHzM3Ym2fGntxRvaoo7o_b Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, The following commits are also in the tip tree as different commits (but the same patches): 415dab3c1796 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspace") 336f560a8917 ("x86/xen: don't let xen_pv_play_dead() return") f697cb00afa9 ("x86/xen: mark xen_pv_play_dead() as __noreturn") These are commits 859761e770f8 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspace") 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return") 1aff0d2658e5 ("x86/xen: mark xen_pv_play_dead() as __noreturn") in the tip tree. --=20 Cheers, Stephen Rothwell --Sig_/trHzM3Ym2fGntxRvaoo7o_b Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmPq6BQACgkQAVBC80lX 0GxOTwf8DeEtZRvi1HXWn6+sBS00XW/6BjrAguO5FZ8ihWzFqa3iyRGdb1/psFx2 /OTLtK52lGWaQlPX8f19NNNY13l2gbzfJtWs7QoIS3UnxPuauKcPryVOzKNpUVLe w4ooJkMnYuFXNTtKuNh5UyuEhyUKAaohZchzqSjxjIFDRbYbd+4kYZNNVriIRPhx eu9LC1eWZBCFFRJoJ5hqNdezalxw69rlLT2dGcFRPV6neeKIjROFFNADm14xktQo gzEZG7mg+B8RNbhHw4qwKspoc2wYS2tMCd2rGP/HuihzHvAYSpo2wnAe72QYX3UM ocU4tc07CA7R33n4y9qbv1DiRV/Q2A== =nOdd -----END PGP SIGNATURE----- --Sig_/trHzM3Ym2fGntxRvaoo7o_b-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 03:46:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 03:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494947.765167 (Exim 4.92) (envelope-from ) id 1pRmGl-0005v8-MB; Tue, 14 Feb 2023 03:46:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494947.765167; Tue, 14 Feb 2023 03:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRmGl-0005v1-JN; Tue, 14 Feb 2023 03:46:15 +0000 Received: by outflank-mailman (input) for mailman id 494947; Tue, 14 Feb 2023 03:46:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRmGk-0005ur-6W; Tue, 14 Feb 2023 03:46:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRmGk-00026Z-4F; Tue, 14 Feb 2023 03:46:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRmGj-0008WL-Cg; Tue, 14 Feb 2023 03:46:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRmGj-00070q-CF; Tue, 14 Feb 2023 03:46:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=n1/gV9f91HlswBmcf2Jow+gJnOyXTSc+h1fjQ2ZWmFo=; b=7GDsnjGcujGsugBspeOxqasB29 N4LDLNsRRXbN1u9+JLX58BItpyKWW2/7xyyzkLIAcc+VbLheQJXDf+22hMxJT18fXbKqfLoIIkFAx 33i1f6XdcDJdIIXIEargTN41DdRZXX1M0vNn5UumNV2A7/jzxm4bQ+R+l3qi9C9C3gkU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177223: all pass - PUSHED X-Osstest-Versions-This: ovmf=b3f321f2d7871868951cf73edb8fa4d5a88854a5 X-Osstest-Versions-That: ovmf=93a21b465bda44cecdd6347ad481ca6f55286547 From: osstest service owner Date: Tue, 14 Feb 2023 03:46:13 +0000 flight 177223 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177223/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b3f321f2d7871868951cf73edb8fa4d5a88854a5 baseline version: ovmf 93a21b465bda44cecdd6347ad481ca6f55286547 Last test of basis 176815 2023-02-10 04:16:45 Z 3 days Testing same since 177223 2023-02-14 00:11:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 93a21b465b..b3f321f2d7 b3f321f2d7871868951cf73edb8fa4d5a88854a5 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 14 05:07:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 05:07:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494958.765188 (Exim 4.92) (envelope-from ) id 1pRnXX-0007XO-TQ; Tue, 14 Feb 2023 05:07:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494958.765188; Tue, 14 Feb 2023 05:07:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRnXX-0007XH-Qh; Tue, 14 Feb 2023 05:07:39 +0000 Received: by outflank-mailman (input) for mailman id 494958; Tue, 14 Feb 2023 05:07:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRnXW-0007We-Hh for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 05:07:38 +0000 Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com [68.65.122.15]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e1664ff-ac25-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 06:07:35 +0100 (CET) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 18BBD18000B2; Tue, 14 Feb 2023 00:07:34 -0500 (EST) Received: from localhost.localdomain (c-73-126-95-14.hsd1.ma.comcast.net [73.126.95.14]) by mta-05.privateemail.com (Postfix) with ESMTPA id 6059718000B0; Tue, 14 Feb 2023 00:07:24 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e1664ff-ac25-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1676351254; bh=LPH/xf231W5X/KC3fQVF1Wp17WKoMNP0q+BN8zwfIbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LolOQG8tMtpM4vaSAopvlzPqvCfHDsvbsXQrXXg9O/fyMX+Nqwb904Fl8CMpB3guc UIMESDru24/g5UBpwTgdwg23gO+a51yMDNxKCggOQDDeAHTR2RH4VFATpeQaxyTQLO sZv+1KT3m12kRAB56Cpw7uG0xUcnYDHJ96yNIcTk9QSDOXct39Ft4iVZiN/SIcfo2p lQgqQs6k5dR0WKBro5YTBjBaew+7KD8SRgV5WkJExsFzwXMknHX5R1DwB5agfnZg6Z MrR2AM0idUXdQUd9nQcWx4YkkptuqN0KZ7OT5AINegWN29ywmotEjcRxQYaQ72MGoW sixgYWPzkbjFQ== From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap Subject: [PATCH 2/2] x86/mem_sharing: Add extra variable to track fork progress Date: Tue, 14 Feb 2023 00:07:07 -0500 Message-Id: <348063358f2ded237334b3cec7498a36296fd408.1676351034.git.tamas@tklengyel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP When VM forking is initiated a VM is not supposed to try to perform mem_sharing yet as the fork process hasn't completed all required steps. However, the vCPU bring-up paths trigger guest memory accesses that can lead to such premature sharing ops. However, the gating check to see whether a VM is a fork is set already (ie. the domain has a parent). In this patch we introduce a separate variable to store the information that forking has been initiated so that the non-restartable part of the forking op is not repeated and we avoid the premature sharing ops from triggering. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/include/asm/hvm/domain.h | 8 ++++++++ xen/arch/x86/mm/mem_sharing.c | 10 +++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444e..76a08b55f9 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -33,6 +33,14 @@ struct mem_sharing_domain { bool enabled, block_interrupts; + /* + * We need to avoid trying to nominate pages for forking until the + * fork operation is completely finished. As parts of fork creation + * is restartable we mark here if the process started to skip the + * non-restartable portion. + */ + bool fork_started; + /* * When releasing shared gfn's in a preemptible manner, recall where * to resume the search. diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 649d93dc54..b55c5bccdd 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1888,11 +1888,12 @@ static int copy_settings(struct domain *cd, struct domain *d) static int fork(struct domain *cd, struct domain *d) { int rc = -EBUSY; + struct mem_sharing_domain *msd = &cd->arch.hvm.mem_sharing; if ( !cd->controller_pause_count ) return rc; - if ( !cd->parent ) + if ( !msd->fork_started ) { if ( !get_domain(d) ) { @@ -1905,7 +1906,7 @@ static int fork(struct domain *cd, struct domain *d) *cd->arch.cpuid = *d->arch.cpuid; *cd->arch.msr = *d->arch.msr; cd->vmtrace_size = d->vmtrace_size; - cd->parent = d; + msd->fork_started = 1; } /* This is preemptible so it's the first to get done */ @@ -1918,8 +1919,11 @@ static int fork(struct domain *cd, struct domain *d) rc = copy_settings(cd, d); done: - if ( rc && rc != -ERESTART ) + if ( !rc ) + cd->parent = d; + else if ( rc != -ERESTART ) { + msd->fork_started = 0; cd->parent = NULL; domain_unpause(d); put_domain(d); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 05:07:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 05:07:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494957.765177 (Exim 4.92) (envelope-from ) id 1pRnXN-0007GY-Mu; Tue, 14 Feb 2023 05:07:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494957.765177; Tue, 14 Feb 2023 05:07:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRnXN-0007GR-K1; Tue, 14 Feb 2023 05:07:29 +0000 Received: by outflank-mailman (input) for mailman id 494957; Tue, 14 Feb 2023 05:07:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRnXM-0007GL-FW for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 05:07:28 +0000 Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com [68.65.122.15]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 783a7726-ac25-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 06:07:26 +0100 (CET) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 0FBA418000AF; Tue, 14 Feb 2023 00:07:24 -0500 (EST) Received: from localhost.localdomain (c-73-126-95-14.hsd1.ma.comcast.net [73.126.95.14]) by mta-05.privateemail.com (Postfix) with ESMTPA id D068A18000B2; Tue, 14 Feb 2023 00:07:16 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 783a7726-ac25-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1676351243; bh=U/t2aKecr1XPTUqutXYj+EG7n3HpJaTp5C9X4aDmHqY=; h=From:To:Cc:Subject:Date:From; b=OvBMe5ElsruzOj1OegqEs8cgxoeOwFDp7FMDTO/LL9IP0TCRoFm4iFHFS1GOKEjt5 FeXJnOvPPY2KQeMujIqb7Jxko6tFDxvL79LTJnF9JETZUmC719wH69aJydeviHBK9T U/R4Ef2yB+xbqwl8jVkXM9nv4U6BOJFyHhAdlYoWx5uMb7LV2yZOpbVQpZmzSinBjm ANE9Kl5iPY1pGK5zQrsr1WRPJ8UVsQPmbBkFklb8Zjqopz0PEjDPpJNzjNwyE+vS5b VALydlWAA/tQnpBV8kbvbuBGNH1pLBAxYv6BF/PggodYpB/vm50J2zGKJr0a+AgvzC xjwZScl/DHohg== From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown Date: Tue, 14 Feb 2023 00:07:06 -0500 Message-Id: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP An assert failure has been observed at p2m-basic.c:173 when performing vm forking and then destroying the forked VM. The assert checks whether the domain's shared pages counter is 0. According to the patch that originally added the assert (7bedbbb5c31) the p2m_teardown should only happen after mem_sharing already relinquished all shared pages. In this patch we flip the order in which relinquish ops are called to avoid tripping the assert. Signed-off-by: Tamas K Lengyel --- Note: it is unclear why this assert hasn't tripped in the past. It hasn't been observed with 4.17-rc1 but it is in RELEASE-4.17.0 --- xen/arch/x86/domain.c | 52 +++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index db3ebf062d..453ec52b6a 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2310,6 +2310,32 @@ int domain_relinquish_resources(struct domain *d) if ( ret ) return ret; +#ifdef CONFIG_MEM_SHARING + PROGRESS(shared): + + if ( is_hvm_domain(d) ) + { + /* If the domain has shared pages, relinquish them allowing + * for preemption. */ + ret = relinquish_shared_pages(d); + if ( ret ) + return ret; + + /* + * If the domain is forked, decrement the parent's pause count + * and release the domain. + */ + if ( mem_sharing_is_fork(d) ) + { + struct domain *parent = d->parent; + + d->parent = NULL; + domain_unpause(parent); + put_domain(parent); + } + } +#endif + PROGRESS(paging): /* Tear down paging-assistance stuff. */ @@ -2350,32 +2376,6 @@ int domain_relinquish_resources(struct domain *d) d->arch.auto_unmask = 0; } -#ifdef CONFIG_MEM_SHARING - PROGRESS(shared): - - if ( is_hvm_domain(d) ) - { - /* If the domain has shared pages, relinquish them allowing - * for preemption. */ - ret = relinquish_shared_pages(d); - if ( ret ) - return ret; - - /* - * If the domain is forked, decrement the parent's pause count - * and release the domain. - */ - if ( mem_sharing_is_fork(d) ) - { - struct domain *parent = d->parent; - - d->parent = NULL; - domain_unpause(parent); - put_domain(parent); - } - } -#endif - spin_lock(&d->page_alloc_lock); page_list_splice(&d->arch.relmem_list, &d->page_list); INIT_PAGE_LIST_HEAD(&d->arch.relmem_list); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:00:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:00:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494975.765200 (Exim 4.92) (envelope-from ) id 1pRpII-0004Lv-S2; Tue, 14 Feb 2023 07:00:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494975.765200; Tue, 14 Feb 2023 07:00:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpII-0004LB-Os; Tue, 14 Feb 2023 07:00:02 +0000 Received: by outflank-mailman (input) for mailman id 494975; Tue, 14 Feb 2023 07:00:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpIH-000486-BK; Tue, 14 Feb 2023 07:00:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpIH-000740-9Y; Tue, 14 Feb 2023 07:00:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpIG-000250-Pw; Tue, 14 Feb 2023 07:00:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRpIG-00009c-PP; Tue, 14 Feb 2023 07:00:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CJ8MiG5aFZXpwNfkMqVIc3Z0Lmy5w1aZ7idVuRHZYc4=; b=G4jFOYBUXEs3F3cY2o6OpDUWjO 9dByGxK08aJKzcA3ocpCiRCpg7X/714UyOQvAgQloN7oE9q/yW3y82eBYjpMRQDqyiT/rQBloFnJ1 WmMuQikFxYNmRPvhpt+GOijVhXgl+bF0LpFg94G6id5krE8eSyO5JUOACqz9NSMyAcp4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177222: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f6feea56f66d34259c4222fa02e8171c4f2673d1 X-Osstest-Versions-That: linux=ceaa837f96adb69c0df0397937cd74991d5d821a From: osstest service owner Date: Tue, 14 Feb 2023 07:00:00 +0000 flight 177222 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177222/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177177 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177177 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177177 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177177 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177177 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f6feea56f66d34259c4222fa02e8171c4f2673d1 baseline version: linux ceaa837f96adb69c0df0397937cd74991d5d821a Last test of basis 177177 2023-02-13 13:41:39 Z 0 days Testing same since 177222 2023-02-14 00:11:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Mikhalitsyn Andrew Morton Arnd Bergmann Catalin Marinas Christophe Leroy David E. Box David Hildenbrand Gayatri Kammela Hans de Goede Isaac J. Manjarres Jeff Moyer Jeff Xie Kefeng Wang Kuan-Ying Lee Li Lingfeng Linus Torvalds Michal Hocko Mike Rapoport (IBM) Qi Zheng Seth Jenkins Shiyang Ruan Tejun Heo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ceaa837f96ad..f6feea56f66d f6feea56f66d34259c4222fa02e8171c4f2673d1 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:22:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494987.765211 (Exim 4.92) (envelope-from ) id 1pRpdg-0007lR-Kz; Tue, 14 Feb 2023 07:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494987.765211; Tue, 14 Feb 2023 07:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpdg-0007lK-IH; Tue, 14 Feb 2023 07:22:08 +0000 Received: by outflank-mailman (input) for mailman id 494987; Tue, 14 Feb 2023 07:22:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRpdf-0007lC-5K for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 07:22:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47a6ef45-ac38-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 08:22:05 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8773.eurprd04.prod.outlook.com (2603:10a6:10:2e0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 07:21:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 07:21:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47a6ef45-ac38-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTpYR0udfnr+mPhtWKDZhMUYO/RJKIjoXZ85e19DdpWwPzIWfizvAfm8Fw8+pIw4rYJviV2WmWoRQUDalrtQpyMNtWyZX5aEZgt4aGROHA7kkvsmebZP8xOn4YFqnPELp3hY36lT9EvitmkBKutu/MF6aSI5WfkdBqFuq0ZaKDqWDXfLxWJJ4d4lIUCEMRtrbDDYC32UtuwS7JZ+AAWb8UX1sZc7/PIBzYmEuNGuK/VrloeeERA5ZL0FGaAEkKcxxawGKFxQ/87w+C4RLWKwiED/ZZF/4EyKvAy8J2gdYmW9F/DS1HtseyvH1/IIjERdfCG5RosCNGiLkPC68wTCOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ulJXw170r8WN8WSBOaLWRs33tLp8RRxGLUjOt9zeFtk=; b=hQEJBRQHlPVB87+migtbcE2SoV9UvhjWp29XNZD2UuzpfYsxsA7RfADfBe7KP5KZ4rpLiVB1X3ax/6HvhpU1GMwMWLzR3qYqDeUOpH/yUdRa3LG4+gxyrf2JWjBN8B8szx2G7wacPKePNaTM16bPJxKJ9KseK0St9Lna0F6rs1VzMRJR6/b5sSXrzMvXj7mqbpSrNNpsuHtNNqPE+htWHIcAkHcRuJTP1ZjPwzoYfR8+vJsvGomqjy1EpQ5lyBn45xzIEmmph0pSnMRv2n/CgetfkWdWE8TqZuWa0a6WmHjgJDOPkrXy56eEMLTSwF1qgc2iijg0IulDYnRRMXcR9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ulJXw170r8WN8WSBOaLWRs33tLp8RRxGLUjOt9zeFtk=; b=z12XoTeX+gxjFcNw+4rVQf5lgq7VdR/5YfxFRlJmfttyoA+NvFsgI7FLJtr/IJrPo/QqMMU1daceb/udjWUITQRhyLM5aWFlLUCFrUHWBBSjF/fa3fTn/DBM8ko98hCUYOgFvzCdnucKHA1gn0kIb8xX40HJtfOpOmMhPLb2YMcLMlQSNR9AxPTAmfxhcdEpYzJr5zcAe8Pn9LmL415gYcL87sU42DEBF3gZpNWcvkgLQShTzDt5Ve5ZvjAJ2legqF0NAVY0/YYhWMCvVmP4Dc5Td3ZzqjU7uiLfRc7Ylb0wq6R8pmI2udxYBxoq2lgG7KR8qPI+hBymIs/qq5a7wA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 14 Feb 2023 08:21:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/platform: make XENPF_get_dom0_console actually usable Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8773:EE_ X-MS-Office365-Filtering-Correlation-Id: cfac289a-124f-4dcc-f7f0-08db0e5c1974 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4pfhSiCc1JRTDZ+4pw/IDHRKbfLyL+H2gEbcdn6GrPMq7V/FhRtscIHkSVyjSzhueLUwLyarVdERky5WRlq4f4mxYfq4b+JVA4+ird9mgrtpYxSkkWL677KiMuw45g/zHBEXlzKwzzUJFnTvq9eHD3w2jcUS3dadIqqYiUxfvUtoaQnHiTpzZvl1YSinpAXGxFp36BelbB1EAbs3hq6uUQL3nU5mt6OBF1Mmaqty9sbu+EYIvJaaae6eqZl0WAWOrTmD5SIgg5Qga/sjLynKd6VQY9xts7ZmNklKs+QIyQ6NeqIRyIbIonIlIhwTG/sCbcNyh3BbrSh/lX+/73D9aRgmbtnthQLG21zwhAN8peelSa42qvC1Ol2m5FoWuAfz9zuPLN9Tj475p6TpLgxWu0OrhH4MorhqQukLZQL9nhln7Yyght2Q2cG56bqIh8shryb2BHS5v1blvV6Mnb9z2LBBPYDgUUjAAhG/fQWor5yR+oOGOe2HAttn3c21+emsMCsNFVBKEpPSmBhUK4t1/OR26FW1xccGM8BUj4Zgj4tLXcAsCzdbOBIHkkhRjoa1NA4r7m5kCQT3HPGfmW23LXpuchWPGgCsHUp90jNvz1TOun3YlAqMemJFQRVtvILhnOxUys6nxq8TlTEvXnz14JuxrtWXnK+RoZJyfW6leoAJz5xx/eNQFfKWvdit6ARz7qoVVP8xwxCP6zVG2E8xqcr//9DvfG42T6JQyv+Vzs8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199018)(36756003)(2906002)(26005)(5660300002)(31696002)(83380400001)(186003)(2616005)(66946007)(38100700002)(6916009)(8676002)(4326008)(66476007)(316002)(66556008)(54906003)(41300700001)(478600001)(86362001)(6506007)(6512007)(53546011)(6486002)(8936002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlNOT1NJWFBoSXR6eVdpYkx6eThEUmhqV25YL0RzbVBOMVUyMFp5YlR5SjRD?= =?utf-8?B?MGpYQWlWUkRoMkt6aHhzYi9iVUZFZGNxVEgvU0NjcHB1R3c2Q3hUMzJwUlhq?= =?utf-8?B?QjBwczRveEtLb0txcGdYeVppVHg5TlhrWVRSNkl1M2NsUGk3VGwyaUdFNFRJ?= =?utf-8?B?K2d6WW9ONFpzdHlsZEhub01rUThNZDIvVlRFZUhreFJKWUs1OXZ1VEl0a2xC?= =?utf-8?B?ZVQ3alhhOXpzRHZYSHBVSHp0TUdvYUxPNlBjMWxVeGdsMG9vdEd4UGoraW9y?= =?utf-8?B?cFFPdjNycGM5T3l5TVUyL2ZPa1JYVXptblpZZ250V0gvTHUrREg1Q2tQRG9D?= =?utf-8?B?Z0ZsWHNzbFk3akFwZjRUNE1xMmRoQ0dIUUpmaVFnY0JONDdKb1JuTkYvMVNH?= =?utf-8?B?dllBMnVMQjRHVDEvYmxIb2V6MlJtVHM2enRzOGJyQ05PQldyTXdKc3hDRlF2?= =?utf-8?B?eW42SnB4aVhxcVVRazNVSEgrUzM0b2ptUUN2c3ZQNHF0dXJ1UFVuRjJIYkE4?= =?utf-8?B?ZnIzT2JpV1Z4RVNNbkZ4eWdxVWdhc09mSWJzMTRMRVZaT2p3NVFsUTZuNWtQ?= =?utf-8?B?ZUVxdTJ1S25Wdyt1YkNyUVp3SUxVbEYyV0J0QnpPZXc5ejIwSFlVbkNDTUZx?= =?utf-8?B?Tm5ab3A1dEdNQlBoVTE1Y1lQUk1rdWNpU2g1eklKWWI0WGN5MFR1c2VMcVcz?= =?utf-8?B?V3U4bzhOVjRJZGlpRjl4dUlUR1ZxQzN5c3Q2dkt1OG5EWEIwTGxFcThxc0d1?= =?utf-8?B?RnU3bUk1WVpyNEpaTUxjR1JEbHhBbHcyODF0UGQ4d0ExZjVtS3UxMUtlWXpI?= =?utf-8?B?TndzSytvRCtCQ2pKdkx2ZjIzVnVjd01uUGZiZ2RQRHNoUlcwNEx1NzJlbEFF?= =?utf-8?B?ZktVVFZEVko2cDJGMlJNS25mVFRGeE5EazMzSG15eHd1MnVwcnZpZDA5VE5F?= =?utf-8?B?YnIxVitMaEVkQXEzaFNFbGVEdWZEbHVBQSt6T01QWlczUXBZd1hDaTMwaHRT?= =?utf-8?B?dFg0OHNBa0o0OTkxMTNidFhEZFZyeVR3SG13R01NQ0wraGxYNlAxdytNVit4?= =?utf-8?B?bHhwTjBxUkxxd2hLT1kxUXBJQ1pnRkRQbmNmcHVVMDRLMi8rK290ZTdmeHh4?= =?utf-8?B?a0pMcXE0MnNpeVRacHZHUkNvUnhmWlNrRm1DUkgyakNWbUV1OWxpMkcydjlv?= =?utf-8?B?bm1yMUF1cXUxVUtHUlo2Z2kvWC9IUDgvTGVXZFhnZEhOUW4xUUFBcEZLNUxZ?= =?utf-8?B?TnBlYURsOGZuZzlsLzRIQU95UWp0RUFXWFE1eGd4QVprRDB5MUVNY0hRVHoy?= =?utf-8?B?enlETlorbmxlNjRHcytQZ0I2UmkxOVdFek81Z0tONmZONE5aVHZ3OWovS251?= =?utf-8?B?dE92WklwV0Fkbk5PUzZvYzlsblEzOFg1c2xKaXZFelYrNlRMYUlvRXIvdXAw?= =?utf-8?B?RVJPL1FmVWRXZk9NT2VJQ1k4SUVTeTBzdjh3aVJOQytrN2ttbi9QN0lJWW9N?= =?utf-8?B?KzZPdC9ZVy9WcVcrR21rbGdoQlZtdUVEUm1GZ2JoODZBQStsMktFdEVzWCth?= =?utf-8?B?YUIyR1dWaW5IdlFQeXA4OXNuV05oSiswVzF4d1RWNUhMUmdJQkdlZDFFeW9I?= =?utf-8?B?ejlLZ2dNVkFvaXhmbVJIRmZZV0VtWmppdmpQVEdaM1kxRmxlMExPQmdmWUl0?= =?utf-8?B?M1M4M3FNQ3pnY0l4QjdZcnh1WWNHNCsrVnovSXFzSno1M0tyYU1CWjhEUm1x?= =?utf-8?B?R2pGeUJYZy82YjFzTmR1eWliUVNJanJvQlY3dFF2aGlGTjdvdkJqaVlURHR6?= =?utf-8?B?SEtPWFFpemN3ZS9DWWxPcis4M0RVRHhYQ0YyWWZLd0JyQ3paOTZ5S0RuL3Vh?= =?utf-8?B?UHpxZ0hVUHFDVlViN3Fqcnd4QjFZSWlCNmJVZDNQcTk1ZzVoQWVqM1BmVE9H?= =?utf-8?B?VDROM1p3a3hBb1J3VFZKU2lsV3dyU280Q1RhVU1ybjdxdjl6MDgzZER4alZr?= =?utf-8?B?YjlYZ3BWeittYjlyVC9sdW8zdEZHTjlaekRtdkpQeFhRcGN2OTVkQ0RpZmNZ?= =?utf-8?B?QkFOWFlHQm02S1hnaDhwNWhOYWVjcWdlRWRLZTFxWlNlTnhndHBEY0I2WjhP?= =?utf-8?Q?bSkUze4/t3FYhUa1UD2f0Kuge?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfac289a-124f-4dcc-f7f0-08db0e5c1974 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 07:21:33.4776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bWOOfKjjYW+5+gvf+t9wDi8h7MBJ/F5YF9QbMf5JUZ7PCl9CVkRVtYp1mYilx2AE4c+jDebHCsf/l3YtKydkmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8773 On 13.02.2023 15:51, Jan Beulich wrote: > struct dom0_vga_console_info has been extended in the past, and it may > be extended again. The use in PV Dom0's start info already covers for > that by supplying the size of the provided data. For the recently > introduced platform-op size needs providing similarly. Go the easiest > available route and simply supply size via the hypercall return value. > > While there also add a build-time check that possibly future growth of > the struct won't affect xen_platform_op_t's size. > > Fixes: 4dd160583c79 ("x86/platform: introduce hypercall to get initial video console settings") > Signed-off-by: Jan Beulich > --- > Noticed while trying to actually use the new hypercall in Linux. > > --- a/xen/arch/x86/platform_hypercall.c > +++ b/xen/arch/x86/platform_hypercall.c > @@ -841,6 +841,8 @@ ret_t do_platform_op( > > #ifdef CONFIG_VIDEO > case XENPF_get_dom0_console: > + BUILD_BUG_ON(sizeof(op->u.dom0_console) > sizeof(op->u.pad)); > + ret = sizeof(op->u.dom0_console); > if ( !fill_console_start_info(&op->u.dom0_console) ) > { > ret = -ENODEV; > Thinking about it, I've added the hunk below. Jan --- a/xen/include/public/platform.h +++ b/xen/include/public/platform.h @@ -605,7 +605,11 @@ struct xenpf_symdata { typedef struct xenpf_symdata xenpf_symdata_t; DEFINE_XEN_GUEST_HANDLE(xenpf_symdata_t); -/* Fetch the video console information and mode setup by Xen. */ +/* + * Fetch the video console information and mode setup by Xen. A non- + * negative return value indicates the size of the (part of the) structure + * which was filled. + */ #define XENPF_get_dom0_console 64 typedef struct dom0_vga_console_info xenpf_dom0_console_t; DEFINE_XEN_GUEST_HANDLE(xenpf_dom0_console_t); From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:49:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:49:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494993.765222 (Exim 4.92) (envelope-from ) id 1pRq3P-0002KL-QG; Tue, 14 Feb 2023 07:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494993.765222; Tue, 14 Feb 2023 07:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq3P-0002KE-NC; Tue, 14 Feb 2023 07:48:43 +0000 Received: by outflank-mailman (input) for mailman id 494993; Tue, 14 Feb 2023 07:48:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq3O-0002K8-9V for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 07:48:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe935086-ac3b-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 08:48:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6855.eurprd04.prod.outlook.com (2603:10a6:20b:dc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 07:48:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 07:48:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe935086-ac3b-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y+4p066Guek49K9MYPxzeN6rb87fId9rKYc64gQ1TeWrGh2NOMtjU6UL+BH7XXeGGI9bIromLINUkhgUdvCa0I8y9G833mTQHQPRdiTxI0Aytr8qM41Mo/WMvuWQIZGQwnusCtWuGbEKGCdcyEHXywma2Tmcn90zfdNiNruVYW/PuSlZ9oBAOs4tZ9cJ+UldkcKMDStpi54ijlGJp1w5AcavLeon4Nov9qjDyVEnq7/y1m92O+yD6daz8c2fKBl4NeM4z+H9Y5jSEmkdgcwKdatEJAkQnIBkrrAzIf6b4+P3hsvwR9go6Kll56VHK2aI8rH0ouhzyXVFj2Y5OucQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbyW7g/n2hz4XkVGlKoGQ7/VCjoSFDzdx34OPekR/zk=; b=GYsQC1iajxG9Y9HiKOJtsS1SFzXz08VmkSiUr6D6S98ggF+jNiQN7Mon7nV3WZ+OZ9e/fUFFQXKnb9gi8KOtZ1JihJzlzOzQIDDhAJjUQh+ujpHzXBh6dgVGgpUMWqlJy2sDa0RFJVpdNUB3JC44qkULWL0wQcBUyGHVpFLzk6IpNNML5oDqf8IirEPvn+rkCn0TLxKz/AbXLZ6oktdwc5zQ9Pw0tjQn5rSTPCDYgyzJpUu+rJTAy5U7JSW2DnzEq4/qE0mvSLkgwcWa3O5RfgiQFAA9cEYUymFuYjLNZU2AU/WmQUrIHGc3fqzwykADIk4HdpAtLRPDFqe1wSH92g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jbyW7g/n2hz4XkVGlKoGQ7/VCjoSFDzdx34OPekR/zk=; b=wD9znG4POiAwOYllHpUCaazEi4w+qubNRgOgGDsTESGxOk8TDvSyB9vC9ehq1baQAKE0xfqbi19cDoop4dQLaAOS2l85Pk0MtlQvWjQdivg6QFbQLAqTS+EosKmTX/X0BIbv1h4zyqTI8jrY57in6ZlnEgeBhmOZ4zuS8QoaqX2UA76uvu3NMzGubdY5MQRoEf+Ox0GrRkPHvHFeEfeDWeZD3FoU8yT+QWvRAu6cb7/wNOhGcdhw4wdOAf2Vo211yu1dZ/BLPF05Wk5NKyo/FxKr7Ebhmp0qiEDcSsSXiQdswjR4aGVw72bmtwBDE8Kb0EYE78GAsaHLf8/IRiOIVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <342bb651-b0f8-8cbe-53ef-e4a292446224@suse.com> Date: Tue, 14 Feb 2023 08:48:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xenia Ragiadakou , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> <3cdfde6f-5af6-4044-f786-259c70e0ba69@suse.com> <5892e7d6-bd08-0f2f-4dcb-fa5b9123a2eb@oracle.com> From: Jan Beulich In-Reply-To: <5892e7d6-bd08-0f2f-4dcb-fa5b9123a2eb@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6855:EE_ X-MS-Office365-Filtering-Correlation-Id: 92c13cd3-8292-45e3-996e-08db0e5fd14f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o5umqH8R1DyhdXfFjIjiEYIcvKKwSWF9vvLRd/VlI1NtMbrzG6jrOpd97YkWrhJ8XkBSO5HmKiOe2M0Ia9Gc/3B2n8PKk1H2QvtXA+tYavHFk1QZ1aKc9TwY/e7PIDDaqc+9K+LfQ+nGilxX4KMeEwYHFZPRUs7PKdSjf1guWFtlsegK7XQlZwnJhc7DiCnbnYsGmfgSFx9EZQgRgKFUvBD80fJPfFocqW8hRp58kSWzrutNjXp3uEmp/q34lbjEhkp9w3yfC2AaXi2Pfbz+NZlAzC5ZScS3Wh0XJ05wVgeG2evtcslOLoA0e/UulvxgB9XoYR7i/yyUdv/BnGHUc+4Z3d3DAWhTbXVb4ZqUDQlROw/aT/+We2r7ACGcInr8FanAVvwZmwn3p/qeXAySfekHyBtUGf+QR97W4xqvcuC89zJ8MPWngjlZCRIN7isqPy+tZ/VNyBrgmP8ub9bgjjnNVKx5UAmMeCp5PJ9+JLcNsi6YUYPy7VGK/O43T3+oaBerjssLskRYFmEl7F5ybHdXAK1wg3pdBfpDfVBNZiyFavaR6FUiVDaFm+JO/kfPnp6FpyeEdRtM0gE0f2hRi7EzQjTMKaUh92MIyZjzuw3oXApdHrcYqZmdpgp5SHQceh6eeCeO8fGr5SGrhJt9wR/psJk8emf5fOKuWLjgV6wgZMCOFm3rJ/PB2jcjaXWkrNlhkx/VSTtTMg5n1kbJddbbshJgNVJeawsK4pfr7JQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(346002)(39850400004)(136003)(451199018)(31686004)(53546011)(26005)(6486002)(2906002)(36756003)(6506007)(186003)(38100700002)(54906003)(6666004)(66556008)(66946007)(6916009)(66476007)(478600001)(8676002)(4326008)(2616005)(6512007)(8936002)(41300700001)(5660300002)(86362001)(316002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUU2cGgwWkt1SXR6R2QwcFhsWjJGZHBmdkJkWU9YWU1KanI2aktGYVR1T3FM?= =?utf-8?B?WmhJcGpCUlFJaWVpT3I5YmhCV1NPekpTWU43dmJMdWFkQmV3SWpzaStVaHdL?= =?utf-8?B?aG1FeU1XZDlRdVJ0MzNpVUt5TDdCZVV6WXREOEt6cHZiaEhmTzNNT2RxK25n?= =?utf-8?B?ZW5YWWVJR25IV2tlWFJVUWdFSHY4NDFZYnN5Sll3R3RxWmZJRTkwNXdCL2Vh?= =?utf-8?B?T3NCQ0FwaEp3c0xnakZ5alY1SVlvUW9LUE1iM2pSQy8vWGZsUnlEdCt4MXdy?= =?utf-8?B?a0JlL216c0xqRXQxQjBabEo3aFV4STZBWTBCK3B2MittSTV6ZlJhempvT3Bl?= =?utf-8?B?UEdyb3Brei9zZ2RDejNrM2NuMTZkVmtYQ1pXZWFXZjlkNGljSGh4d2I0SG9I?= =?utf-8?B?YmR4N2hkUTVoSXJIZXlOZzIyZEZtUG5adDZ1d3hoNGxwZVNVTWhVeWZ4elpQ?= =?utf-8?B?UFlRdHlUZzZXY3lCeWhDWWFUQWd6NjZhNjNZZERCUEhXblAzVjQzNHoxVllE?= =?utf-8?B?OEFidTg0RENYd1B0OS9EZTBTMkhva3c1OU5QTjczRG9mYkpMK0E5TzhrQUN2?= =?utf-8?B?dzNhUDlhWnNoZ0YyTDB6U0RVdkJtTEFQOUduRThpZVVnc1JQVkx3Ukk4cUlJ?= =?utf-8?B?SFJyTG90bGpQVWN6TDRpQndYb1V4OVBWSGtVNHVjQ1FGUUxJZHU5MTZNOXM1?= =?utf-8?B?TGw2RUVDN1cyaHdFbE16cldWanFBVjhYcVNiLy9icUhTbk5CQ3pMbmM3RmVu?= =?utf-8?B?YWxEQmg5eEtqQzRuQnNLc2tYQk5JYTRGUVA3WUFocmZheVlkTmNBNTJqSzZZ?= =?utf-8?B?T3ZhUFB4akhlMy9wMlNqQk1obC9JNDFlZ0ZtOGo3eWVsTG1WMVA5K1BWSDRa?= =?utf-8?B?cEZnTmpjRi9vaHUweTBydlpNMXdVN04yRmFhZCtVM0dvMm9Qb3VMZ1YxZUc0?= =?utf-8?B?alZ0T2ZBaEd1SEp2a2Npc1o4SjdOSFduamh3KzVHK1V6S0drUGR0WkdlNkhC?= =?utf-8?B?QzV1OUYxdjRicHJYM3Y4ZTJTdDhuczFHamNhKytFMUZGM2dXMjNGYlZkU0lK?= =?utf-8?B?YVpXd3NJYnlmeFNmSC8wbllZeGhUT3g2MkZ6VmNpcHlXWDJEdHJOUjl5MUJW?= =?utf-8?B?blNJWXROZTR3OGRNZUZaQnhhVTFOL3o0bkZObC9UdjZmb1BUQVdFMU9LQmpR?= =?utf-8?B?WTNGK3h0cTRyclJjd2VLTmFMZGN1TVhjKzhQSlZSanJFRGxiWGY3bGlnVDVw?= =?utf-8?B?T1U4VEZBaktRZ1lOVHZTMVJNcVAzdVJtOFlzdGpaeW1uQXo0V25tL3FBZ3Rw?= =?utf-8?B?NTdFNFptMnRLaU9oTU5Kdi8yeFNWQXY1SE9ncUJwV3daU0ZNeFR2QWd3VVdK?= =?utf-8?B?eUxBSE5sNUxUc25RdVloWjhhUFdwMUtFTlZpY056c2pKS2pWYjAvL0dKd0Nl?= =?utf-8?B?YW44QWNhYjJ4dzY2QjJxa05vcDlhbkNRQ0tTazNibXh6MTNGalBhQXZzanRX?= =?utf-8?B?TEZtcHBhZUs5TGVMMlphNjRMMFl6YVNrbGVjMzhVeHZsbkhXb1dabGR5Ymhm?= =?utf-8?B?NTFhV21RQ3hXdEJHd1ZIQUx4bUhkOWJGUTVlOFpRSWlJdGZEMk5naE5LSWxz?= =?utf-8?B?eElHZUQ5eThEcTNVU3hxY0FkVTZpYlpzcFYvUWxOUjdndDlEWXRZV0crdXBX?= =?utf-8?B?NTdqa1RNQ0REdk1uV0JHaXZQcXNCbU04Um5waHVZV003aHRZV0lnTmwrSTFj?= =?utf-8?B?U2ZObnJsWXNLa3pKeTRHL2J1dG9yQ1ZtVzNmSUxUTDNKdG8yNG12SGVSL3dH?= =?utf-8?B?czgxS3RRV2Q3Vkw2ZjBhY1BVbzlNaUFEa3Q1cUM0dzZiZUZPSm94TXo2TjUz?= =?utf-8?B?Wkl4UEc1RG90M2wzVnY0bFpVZ3dqQm16Z0NycmhiTGZrQ2JvM0cyZzdSRlBo?= =?utf-8?B?MWlCeGt1R01YYmdPTlJsMlpvc0xjZ2MySzJ6L3pGYWNBMFhMTGFtMjZDaTNr?= =?utf-8?B?YXlxZVlQWHNQNjBJd0RtcjROUHdWNXFNeS92eTBFL3o3ZlRoVkR2dzF4MEsv?= =?utf-8?B?WlR0UUI5OXpxTnpTaEM2Ui9qUzVKalNucnpkSktrYkY3VWZZdU8wOC9pWWRY?= =?utf-8?Q?sLo5wjRJ24vdvF6thMcVt8I6i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92c13cd3-8292-45e3-996e-08db0e5fd14f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 07:48:10.1425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qaDwGwwNw1h5J31UOEYaLMWB4Z5TiXZU6Spy/3ydXHTdNlp9I+HvK2UK7tg3ZkiwzG9X8AyY5shMF9tFcR3fRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6855 On 13.02.2023 21:53, Boris Ostrovsky wrote: > > On 2/13/23 11:41 AM, Jan Beulich wrote: >> On 13.02.2023 17:30, Xenia Ragiadakou wrote: >>> On 2/13/23 17:11, Jan Beulich wrote: >>>> On 13.02.2023 15:57, Xenia Ragiadakou wrote: >>>>> --- a/xen/arch/x86/cpu/Makefile >>>>> +++ b/xen/arch/x86/cpu/Makefile >>>>> @@ -10,4 +10,6 @@ obj-y += intel.o >>>>> obj-y += intel_cacheinfo.o >>>>> obj-y += mwait-idle.o >>>>> obj-y += shanghai.o >>>>> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o >>>>> +obj-y += vpmu.o >>>>> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o >>>>> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o >>>> This code was moved from hvm/ to cpu/ for the specific reason of also >>>> being used by PV guests. (Sadly the comments at the top weren't >>>> corrected at that time.) >>> Hmm, the init functions are prefixed with svm/vmx. >>> Does vpmu depend on svm/vmx support? >> There are interactions, but I don't think there's a dependency. You >> may want to ask Boris (whom I have now added to Cc). > > MSR intercept bits need to be manipulated, which is SVM/VMX-specific. But that's "interaction", not "dependency" aiui: The intercept bits aren't relevant for PV guests, are they? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:51:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.494999.765234 (Exim 4.92) (envelope-from ) id 1pRq5p-0003tR-86; Tue, 14 Feb 2023 07:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 494999.765234; Tue, 14 Feb 2023 07:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq5p-0003tK-3k; Tue, 14 Feb 2023 07:51:13 +0000 Received: by outflank-mailman (input) for mailman id 494999; Tue, 14 Feb 2023 07:51:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq5n-0003tE-EQ for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 07:51:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58869e28-ac3c-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 08:51:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D62FC20E88; Tue, 14 Feb 2023 07:51:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9969A13A21; Tue, 14 Feb 2023 07:51:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K3YiJG0962OdGwAAMHmgww (envelope-from ); Tue, 14 Feb 2023 07:51:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58869e28-ac3c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676361069; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59WLmwk/w22JF9sHJHSS4aoub+CRzVO8W2memNhS3Io=; b=ZM1ou+sZmB3tdCvuOCZ7vBoj/LGK7yKg5Z1FAIUR/BtMT50XZUuVtpclEwu14GFTqY0y1C GZ8+iM1iut34Cociirzm9i8zLRCR1g1tycKCECTZjVjIKKEvIrnsqJXAJjVE3dPhTQhUHH 516ikATzwHXHgsUhDbrvL8o9wUd06Gg= Message-ID: <763838a9-acd5-b330-6165-6c288973d51c@suse.com> Date: Tue, 14 Feb 2023 08:51:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230207021033.1797-1-demi@invisiblethingslab.com> <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> From: Juergen Gross Subject: Re: [PATCH] xen: speed up grant-table reclaim In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------lY03vSGRGRiVjwOo0Dl8sT1u" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------lY03vSGRGRiVjwOo0Dl8sT1u Content-Type: multipart/mixed; boundary="------------0awnHpg016kUQAzmDWn7XD0W"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <763838a9-acd5-b330-6165-6c288973d51c@suse.com> Subject: Re: [PATCH] xen: speed up grant-table reclaim References: <20230207021033.1797-1-demi@invisiblethingslab.com> <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> In-Reply-To: --------------0awnHpg016kUQAzmDWn7XD0W Content-Type: multipart/mixed; boundary="------------wNudRiZ2q9tWgKA01XjPCkif" --------------wNudRiZ2q9tWgKA01XjPCkif Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDIuMjMgMjI6MDEsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gT24gTW9u LCBGZWIgMTMsIDIwMjMgYXQgMTA6MjY6MTFBTSArMDEwMCwgSnVlcmdlbiBHcm9zcyB3cm90 ZToNCj4+IE9uIDA3LjAyLjIzIDAzOjEwLCBEZW1pIE1hcmllIE9iZW5vdXIgd3JvdGU6DQo+ Pj4gV2hlbiBhIGdyYW50IGVudHJ5IGlzIHN0aWxsIGluIHVzZSBieSB0aGUgcmVtb3RlIGRv bWFpbiwgTGludXggbXVzdCBwdXQNCj4+PiBpdCBvbiBhIGRlZmVycmVkIGxpc3QuICBOb3Jt YWxseSwgdGhpcyBsaXN0IGlzIHZlcnkgc2hvcnQsIGJlY2F1c2UNCj4+PiB0aGUgUFYgbmV0 d29yayBhbmQgYmxvY2sgcHJvdG9jb2xzIGV4cGVjdCB0aGUgYmFja2VuZCB0byB1bm1hcCB0 aGUgZ3JhbnQNCj4+PiBmaXJzdC4gIEhvd2V2ZXIsIFF1YmVzIE9TJ3MgR1VJIHByb3RvY29s IGlzIHN1YmplY3QgdG8gdGhlIGNvbnN0cmFpbnRzDQo+Pj4gb2YgdGhlIFggV2luZG93IFN5 c3RlbSwgYW5kIGFzIHN1Y2ggd2luZHMgdXAgd2l0aCB0aGUgZnJvbnRlbmQgdW5tYXBwaW5n DQo+Pj4gdGhlIHdpbmRvdyBmaXJzdC4gIEFzIGEgcmVzdWx0LCB0aGUgbGlzdCBjYW4gZ3Jv dyB2ZXJ5IGxhcmdlLCByZXN1bHRpbmcNCj4+PiBpbiBhIG1hc3NpdmUgbWVtb3J5IGxlYWsg YW5kIGV2ZW50dWFsIFZNIGZyZWV6ZS4NCj4+Pg0KPj4+IEZpeCB0aGlzIHByb2JsZW0gYnkg YnVtcGluZyB0aGUgbnVtYmVyIG9mIGVudHJpZXMgdGhhdCB0aGUgVk0gd2lsbA0KPj4+IGF0 dGVtcHQgdG8gZnJlZSBhdCBlYWNoIGl0ZXJhdGlvbiB0byAxMDAwMC4gIFRoaXMgaXMgYW4g dWdseSBoYWNrIHRoYXQNCj4+PiBtYXkgd2VsbCBtYWtlIGEgZGVuaWFsIG9mIHNlcnZpY2Ug ZWFzaWVyLCBidXQgZm9yIFF1YmVzIE9TIHRoYXQgaXMgbGVzcw0KPj4+IGJhZCB0aGFuIHRo ZSBwcm9ibGVtIFF1YmVzIE9TIHVzZXJzIGFyZSBmYWNpbmcgdG9kYXkuDQo+Pg0KPj4+IFRo ZXJlIHJlYWxseQ0KPj4+IG5lZWRzIHRvIGJlIGEgd2F5IGZvciBhIGZyb250ZW5kIHRvIGJl IG5vdGlmaWVkIHdoZW4gdGhlIGJhY2tlbmQgaGFzDQo+Pj4gdW5tYXBwZWQgdGhlIGdyYW50 cy4NCj4+DQo+PiBQbGVhc2UgcmVtb3ZlIHRoaXMgc2VudGVuY2UgZnJvbSB0aGUgY29tbWl0 IG1lc3NhZ2UsIG9yIG1vdmUgaXQgYmVsb3cgdGhlDQo+PiAiLS0tIiBtYXJrZXIuDQo+IA0K PiBXaWxsIGZpeCBpbiB2Mi4NCj4gDQo+PiBUaGVyZSBhcmUgc3RpbGwgc29tZSBmbGFnIGJp dHMgdW5hbGxvY2F0ZWQgaW4gc3RydWN0IGdyYW50X2VudHJ5X3YxIG9yDQo+PiBzdHJ1Y3Qg Z3JhbnRfZW50cnlfaGVhZGVyLiBZb3UgY291bGQgc3VnZ2VzdCBzb21lIHBhdGNoZXMgZm9y IFhlbiB0byB1c2UNCj4+IG9uZSBvZiB0aGUgYml0cyBhcyBhIG1hcmtlciB0byBnZXQgYW4g ZXZlbnQgZnJvbSB0aGUgaHlwZXJ2aXNvciBpZiBhDQo+PiBncmFudCB3aXRoIHN1Y2ggYSBi aXQgc2V0IGhhcyBiZWVuIHVubWFwcGVkLg0KPiANCj4gVGhhdCBpcyBpbmRlZWQgYSBnb29k IGlkZWEuICBUaGVyZSBhcmUgb3RoZXIgcHJvYmxlbXMgd2l0aCB0aGUgZ3JhbnQNCj4gaW50 ZXJmYWNlIGFzIHdlbGwsIGJ1dCB0aG9zZSBjYW4gYmUgZGVhbHQgd2l0aCBsYXRlci4NCj4g DQo+PiBJIGhhdmUgbm8gaWRlYSwgd2hldGhlciBzdWNoIGFuIGludGVyZmFjZSB3b3VsZCBi ZSBhY2NlcHRlZCBieSB0aGUNCj4+IG1haW50YWluZXJzLCB0aG91Z2guDQo+Pg0KPj4+IEFk ZGl0aW9uYWxseSwgYSBtb2R1bGUgcGFyYW1ldGVyIGlzIHByb3ZpZGVkIHRvDQo+Pj4gYWxs b3cgdHVuaW5nIHRoZSByZWNsYWltIHNwZWVkLg0KPj4+DQo+Pj4gVGhlIGNvZGUgcHJldmlv dXNseSB1c2VkIHByaW50ayhLRVJOX0RFQlVHKSB3aGVuZXZlciBpdCBoYWQgdG8gZGVmZXIN Cj4+PiByZWNsYWltaW5nIGEgcGFnZSBiZWNhdXNlIHRoZSBncmFudCB3YXMgc3RpbGwgbWFw cGVkLiAgVGhpcyByZXN1bHRlZCBpbg0KPj4+IGEgbGFyZ2Ugdm9sdW1lIG9mIGxvZyBtZXNz YWdlcyB0aGF0IGJvdGhlcmVkIHVzZXJzLiAgVXNlIHByX2RlYnVnDQo+Pj4gaW5zdGVhZCwg d2hpY2ggc3VwcHJlc3NlcyB0aGUgbWVzc2FnZXMgYnkgZGVmYXVsdC4gIERldmVsb3BlcnMg Y2FuDQo+Pj4gZW5hYmxlIHRoZW0gdXNpbmcgdGhlIGR5bmFtaWMgZGVidWcgbWVjaGFuaXNt Lg0KPj4+DQo+Pj4gRml4ZXM6IFF1YmVzT1MvcXViZXMtaXNzdWVzIzc0MTAgKG1lbW9yeSBs ZWFrKQ0KPj4+IEZpeGVzOiBRdWJlc09TL3F1YmVzLWlzc3VlcyM3MzU5IChleGNlc3NpdmUg bG9nZ2luZykNCj4+PiBGaXhlczogNTY5Y2E1YjNmOTRjICgieGVuL2dudHRhYjogYWRkIGRl ZmVycmVkIGZyZWVpbmcgbG9naWMiKQ0KPj4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3Jn DQo+Pj4gU2lnbmVkLW9mZi1ieTogRGVtaSBNYXJpZSBPYmVub3VyIDxkZW1pQGludmlzaWJs ZXRoaW5nc2xhYi5jb20+DQo+Pj4gLS0tDQo+Pj4gQW55b25lIGhhdmUgc3VnZ2VzdGlvbnMg Zm9yIGltcHJvdmluZyB0aGUgZ3JhbnQgbWVjaGFuaXNtPyAgQXJnbyBpc24ndA0KPj4+IGEg Z29vZCBvcHRpb24sIGFzIGluIHRoZSBHVUkgcHJvdG9jb2wgdGhlcmUgYXJlIHN1YnN0YW50 aWFsIHBlcmZvcm1hbmNlDQo+Pj4gd2lucyB0byBiZSBoYWQgYnkgdXNpbmcgdHJ1ZSBzaGFy ZWQgbWVtb3J5LiAgUmVzZW5kaW5nIGFzIEkgZm9yZ290IHRoZQ0KPj4+IFNpZ25lZC1vZmYt Ynkgb24gdGhlIGZpcnN0IHN1Ym1pc3Npb24uICBTb3JyeSBhYm91dCB0aGF0Lg0KPj4+DQo+ Pj4gICAgZHJpdmVycy94ZW4vZ3JhbnQtdGFibGUuYyB8IDIgKy0NCj4+PiAgICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4+Pg0KPj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC10YWJsZS5jIGIvZHJpdmVycy94ZW4vZ3JhbnQt dGFibGUuYw0KPj4+IGluZGV4IDVjODNkNDEuLjJjMmZhYTcgMTAwNjQ0DQo+Pj4gLS0tIGEv ZHJpdmVycy94ZW4vZ3JhbnQtdGFibGUuYw0KPj4+ICsrKyBiL2RyaXZlcnMveGVuL2dyYW50 LXRhYmxlLmMNCj4+PiBAQCAtMzU1LDE0ICszNTUsMjAgQEANCj4+PiAgICBzdGF0aWMgdm9p ZCBnbnR0YWJfaGFuZGxlX2RlZmVycmVkKHN0cnVjdCB0aW1lcl9saXN0ICopOw0KPj4+ICAg IHN0YXRpYyBERUZJTkVfVElNRVIoZGVmZXJyZWRfdGltZXIsIGdudHRhYl9oYW5kbGVfZGVm ZXJyZWQpOw0KPj4+ICtzdGF0aWMgYXRvbWljNjRfdCBkZWZlcnJlZF9jb3VudDsNCj4+PiAr c3RhdGljIGF0b21pYzY0X3QgbGVha2VkX2NvdW50Ow0KPj4+ICtzdGF0aWMgdW5zaWduZWQg aW50IGZyZWVfcGVyX2l0ZXJhdGlvbiA9IDEwMDAwOw0KPj4NCj4+IEFzIHlvdSBhcmUgYWRk aW5nIGEga2VybmVsIHBhcmFtZXRlciB0byBjaGFuZ2UgdGhpcyB2YWx1ZSwgcGxlYXNlIHNl dCB0aGUNCj4+IGRlZmF1bHQgdG8gYSB2YWx1ZSBub3QgcG90ZW50aWFsbHkgY2F1c2luZyBh bnkgRG9TIHByb2JsZW1zLiBRdWJlcyBPUyBjYW4NCj4+IHN0aWxsIHVzZSBhIGhpZ2hlciB2 YWx1ZSB0aGVuLg0KPiANCj4gRG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zPyAgSSBkb27i gJl0IGtub3cgaWYgdGhpcyBpcyBhY3R1YWxseSBhIERvUw0KPiBjb25jZXJuIGFueW1vcmUu ICBTaHJpbmtpbmcgdGhlIGludGVydmFsIGJldHdlZW4gaXRlcmF0aW9ucyB3b3VsZCBiZS4N Cg0KV2h5IGRvbid0IHlvdSB1c2UgdG9kYXkncyB2YWx1ZSBvZiAxMCBmb3IgdGhlIGRlZmF1 bHQ/DQoNCj4gDQo+Pj4gKw0KPj4+ICAgIHN0YXRpYyB2b2lkIGdudHRhYl9oYW5kbGVfZGVm ZXJyZWQoc3RydWN0IHRpbWVyX2xpc3QgKnVudXNlZCkNCj4+PiAgICB7DQo+Pj4gLQl1bnNp Z25lZCBpbnQgbnIgPSAxMDsNCj4+PiArCXVuc2lnbmVkIGludCBuciA9IFJFQURfT05DRShm cmVlX3Blcl9pdGVyYXRpb24pOw0KPj4NCj4+IEkgZG9uJ3Qgc2VlIHdoeSB5b3UgYXJlIG5l ZWRpbmcgUkVBRF9PTkNFKCkgaGVyZS4NCj4gDQo+IGZyZWVfcGVyX2l0ZXJhdGlvbiBjYW4g YmUgY29uY3VycmVudGx5IG1vZGlmaWVkIHZpYSBzeXNmcy4NCg0KTXkgcmVtYXJrIHdhcyBi YXNlZCBvbiB0aGUgd3JvbmcgYXNzdW1wdGlvbiB0aGF0IGlnbm9yZV9saW1pdCBjb3VsZCBi ZQ0KZHJvcHBlZC4NCg0KPiANCj4+PiArCWNvbnN0IGJvb2wgaWdub3JlX2xpbWl0ID0gbnIg PT0gMDsNCj4+DQo+PiBJIGRvbid0IHRoaW5rIHlvdSBuZWVkIHRoaXMgZXh0cmEgdmFyaWFi bGUsIGlmIHlvdSB3b3VsZCAuLi4NCj4+DQo+Pj4gICAgCXN0cnVjdCBkZWZlcnJlZF9lbnRy eSAqZmlyc3QgPSBOVUxMOw0KPj4+ICAgIAl1bnNpZ25lZCBsb25nIGZsYWdzOw0KPj4+ICsJ c2l6ZV90IGZyZWVkID0gMDsNCj4+PiAgICAJc3Bpbl9sb2NrX2lycXNhdmUoJmdudHRhYl9s aXN0X2xvY2ssIGZsYWdzKTsNCj4+PiAtCXdoaWxlIChuci0tKSB7DQo+Pj4gKwl3aGlsZSAo KGlnbm9yZV9saW1pdCB8fCBuci0tKSAmJiAhbGlzdF9lbXB0eSgmZGVmZXJyZWRfbGlzdCkp IHsNCj4+DQo+PiAuLi4gY2hhbmdlIHRoaXMgdG8gIndoaWxlICgoIW5yIHx8IG5yLS0pIC4u LiIuDQo+IA0KPiBuci0tIGV2YWx1YXRlcyB0byB0aGUgb2xkIHZhbHVlIG9mIG5yLCBzbyAi d2hpbGUgKCghbnIgfCBuci0tKSkgLi4uIiBpcw0KPiBhbiBpbmZpbml0ZSBsb29wLg0KDQpB aCwgcmlnaHQuDQoNCg0KSnVlcmdlbg0K --------------wNudRiZ2q9tWgKA01XjPCkif Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------wNudRiZ2q9tWgKA01XjPCkif-- --------------0awnHpg016kUQAzmDWn7XD0W-- --------------lY03vSGRGRiVjwOo0Dl8sT1u Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPrPW0FAwAAAAAACgkQsN6d1ii/Ey/C TAgAhxZVaExyeIg13ffZ9exlJPa/BeESqo4dgpaot8Oc7w8/cYA2s1CV1qDT48wPqiJpWr7zVOC0 uODWlsHtgYT9xMcG6YbeiSMmJcu8rqqDB5Tzh4CRvkdmXxkrDaTjeQtbvGVIgPvxfNWkXV8zldHG zq5wxk7o7C8BfGxaDEl0yANphvKTH9AVANxBJZ5HD0PzKxdCWUHPQ6+GYJ1i47Wbyh3cijDD7Ksv p0j4ZZiAzDgAhe6WxMyVIq1xCVVl3J+mY+DujNwMnK2VuEo/MREP+NTI/OGJJzw4ggNLQvP6KKsm 8WKlU2SYWoXcwH+z50Ic5udp1VztCd4NS6L/t60jWg== =q9pF -----END PGP SIGNATURE----- --------------lY03vSGRGRiVjwOo0Dl8sT1u-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:52:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:52:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495006.765244 (Exim 4.92) (envelope-from ) id 1pRq70-0004W7-KX; Tue, 14 Feb 2023 07:52:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495006.765244; Tue, 14 Feb 2023 07:52:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq70-0004W0-HT; Tue, 14 Feb 2023 07:52:26 +0000 Received: by outflank-mailman (input) for mailman id 495006; Tue, 14 Feb 2023 07:52:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRq6z-0004VG-D5 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 07:52:25 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2062b.outbound.protection.outlook.com [2a01:111:f400:fe59::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 839546e8-ac3c-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 08:52:23 +0100 (CET) Received: from MW4PR04CA0089.namprd04.prod.outlook.com (2603:10b6:303:6b::34) by MN2PR12MB4454.namprd12.prod.outlook.com (2603:10b6:208:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Tue, 14 Feb 2023 07:52:20 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::26) by MW4PR04CA0089.outlook.office365.com (2603:10b6:303:6b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 07:52:20 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 07:52:19 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 01:52:19 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 01:52:18 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 01:52:18 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839546e8-ac3c-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/4+4cB6x6bQeClFZHgbX3ZF+ki7IhSv1VZ5hpJ6Eafmw5fgG1OM/TmJzEGpJ4NkPEOjktAYBBuEFYeMAharc0qwBe21hWEU8PSykTl9eqHVJ9NVXVZ3DstNzR28USie+VeayOjYSy7dtjeEotwpZlL8e3DzuL4SJir/vIiH/YraWNVeky6pJE446HN885LMwtXCLUwsMY6Lg1dgI34UQU1XeKcqMutc4hXK+raHxKRN6w1C6KUOH5t0DU32m4s++4Qt3O/VMoKORm2Hapjpygh8YEMyLUE8oZetb51+vlDoR2EhB67/hNAxjLnK5i3SHyB8n+0TFmYhAPO2M3gHKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Rp3QHIazdVXBLCezcWIPqOQhG3XUpEGbOhHqnhMpfg=; b=mkVJQ+QiVF32dsMRap1BVv5V8yykbSpGdF9eWPoq+UVE2ZuVxLboNPTzuXvSNcaxPjr1hKuIBxRooOY1H2UJctXq8xPz5vn5GFx90t7NJTvcCQOG939GmIwy8gdP2YeOx4p6gzRtolzOHtId/oLRZZtFKJaRteMhNITsd1aENZ0NGws2geNLSMXkNdgRvUecaaFrvpLkBMlcIZfbi2sM7BnKjqAtrJARnWAeQTXz/Z0LDXpNtRCSLojaI3fszZMB7Jnwz6Hxg8wLXToAdIn2eH0CYo+N4qfshLssKUBhnLkga9aV3QZxjuyPQAba1YBc6rAOh7Y34EE5+4FLVj1/cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Rp3QHIazdVXBLCezcWIPqOQhG3XUpEGbOhHqnhMpfg=; b=t/yczx4m2vn8I0k676gB9F9UaYwoQhs8v3VnHD9v667CIvUR6vDuxCfpy635vlLIumQyAy5C/YQAY9eNgwJqCzXWz/qb6ioG9js/U+OjiJrtWUYH3MknbB3t5GC/wzwhMcLabMKiDPZqPh6VhNQtHPoHgLlGXhnprHLwDdfIUzs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <74d3f3db-9cb6-f944-50c2-5e94e2e342db@amd.com> Date: Tue, 14 Feb 2023 08:52:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] automation: Add container and build jobs to run cppcheck analysis To: Stefano Stabellini CC: , Doug Goldstein References: <20230213142312.11806-1-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|MN2PR12MB4454:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a227417-97fe-48eb-4eb0-08db0e60665f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uKy9AbCX6XHZrhVJxpRNsGiPo+xj+7Elk8ke+bKau9KWPgE1/3bnrCNy+zYTlKjz8oA3UHxDHOMCxHpaPOgpclRwelvbiVGgbsN4eKmVv/EwIBYg8HseBgVMnZg/DMTybFKRcrWibZXcumngmI2YrAoPn03qoUipLsJDONhKIMzMc1Bvzu6K0sp51TjHuwFgbBPw5C6qtbNKQg8ni54QTviytTv9jx7XKrJNatc4dtzNw2MHcvU2c/prLYiiVe7PNzq/idEbqrK+Rh0OGw8/RC08C8n+zlANdGoe1gT2JXFPbNBvkf+rbipMzw3w9aaYCw2JPPmRGUqSGdiclZ0mVc01wE3GrFK2iFtKS8SMIdE+NJ/RyRAYUZouW3IMWPULDSyae7v/VsKisfkB3rOmkK+j4nq8S34/x3038R+VbUp1GhTbL2AD55y/tzVHbNn8wGrexzmQFCLOVnXcmlx23CDfr++VvyGfHGR11IsMBWqGnrvBETBp9aE6vtIBkGGFS1BRKLzdIUrUUxa114PBRf+APqDD9fvjtuw0dfdx6YDiOGdzPmrbGUP3qnIW3m20Z6giadN+SYndn+WULyhTK8V5/CxsGuIpfVAs2vNW77unRjHzayoavVgTSoyUq2W1tD/e7+oepFm3z26aM8x57MilYTh0RahaPpkqm92xJrnwmOB9DBkEASh1C1EytMhTzUBvm0bgMRYBdZe9/MMmTzir+9od7aTlW9GA6oGHt7LXWDZmIumzegdIWvCy1zmQUD/ZY5KDOoT1cNP42PnXLUdjo6SfFf528VyzuIkKc+8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199018)(46966006)(40470700004)(36840700001)(53546011)(47076005)(82310400005)(82740400003)(31686004)(966005)(186003)(478600001)(26005)(2906002)(81166007)(356005)(40460700003)(83380400001)(426003)(86362001)(44832011)(36860700001)(54906003)(316002)(16576012)(41300700001)(31696002)(70206006)(36756003)(40480700001)(336012)(6916009)(5660300002)(8936002)(2616005)(4326008)(8676002)(70586007)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 07:52:19.8666 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a227417-97fe-48eb-4eb0-08db0e60665f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4454 Hi Stefano, On 14/02/2023 00:56, Stefano Stabellini wrote: > > > On Mon, 13 Feb 2023, Michal Orzel wrote: >> Add a debian container with cppcheck installation routine inside, >> capable of performing cppcheck analysis on Xen-only build including >> cross-builds for arm32 and arm64. >> >> Populate build jobs making use of that container to run cppcheck >> analysis to produce a text report (xen-cppcheck.txt) containing the list >> of all the findings. >> >> This patch does not aim at performing any sort of bisection. Cppcheck is >> imperfect and for now, our goal is to at least be aware of its reports, >> so that we can compare them with the ones produced by better tools and >> to be able to see how these reports change as a result of further >> infrastructure improvements (e.g. exception list, rules exclusion). >> >> Signed-off-by: Michal Orzel > > Thanks for the patch, very nice! > > >> --- >> For those interested in, here is a sample pipeline: >> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 >> --- >> .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ >> automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ >> automation/scripts/build | 11 ++++- >> 3 files changed, 87 insertions(+), 1 deletion(-) >> create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile >> >> diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile >> new file mode 100644 >> index 000000000000..39bcc50673c8 >> --- /dev/null >> +++ b/automation/build/debian/unstable-cppcheck.dockerfile >> @@ -0,0 +1,37 @@ >> +FROM debian:unstable >> +LABEL maintainer.name="The Xen Project" \ >> + maintainer.email="xen-devel@lists.xenproject.org" >> + >> +ENV DEBIAN_FRONTEND=noninteractive >> +ENV CPPCHECK_VERSION=2.7 >> +ENV USER root >> + >> +RUN mkdir /build >> +WORKDIR /build >> + >> +# dependencies for cppcheck and Xen-only build/cross-build >> +RUN apt-get update && \ >> + apt-get --quiet --yes install \ >> + build-essential \ >> + curl \ >> + python-is-python3 \ >> + libpcre3-dev \ >> + flex \ >> + bison \ >> + gcc-arm-linux-gnueabihf \ >> + gcc-aarch64-linux-gnu >> + >> +# cppcheck release build (see cppcheck readme.md) >> +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ >> + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ >> + cd cppcheck-"$CPPCHECK_VERSION" && \ >> + make install -j$(nproc) \ >> + MATCHCOMPILER=yes \ >> + FILESDIR=/usr/share/cppcheck \ >> + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" >> + >> +# clean >> +RUN apt-get autoremove -y && \ >> + apt-get clean && \ >> + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* && \ >> + rm -rf cppcheck-"$CPPCHECK_VERSION"* "$CPPCHECK_VERSION".tar.gz >> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml >> index a053c5c7325d..c8831ccbec7a 100644 >> --- a/automation/gitlab-ci/build.yaml >> +++ b/automation/gitlab-ci/build.yaml >> @@ -7,6 +7,7 @@ >> paths: >> - binaries/ >> - xen-config >> + - xen-cppcheck.txt >> - '*.log' >> - '*/*.log' >> when: always >> @@ -145,6 +146,23 @@ >> variables: >> <<: *gcc >> >> +.arm64-cross-build-tmpl: >> + <<: *build >> + variables: >> + XEN_TARGET_ARCH: arm64 >> + tags: >> + - x86_64 >> + >> +.arm64-cross-build: >> + extends: .arm64-cross-build-tmpl >> + variables: >> + debug: n >> + >> +.gcc-arm64-cross-build: >> + extends: .arm64-cross-build >> + variables: >> + <<: *gcc >> + >> .arm64-build-tmpl: >> <<: *build >> variables: >> @@ -679,6 +697,28 @@ archlinux-current-gcc-riscv64-debug-randconfig: >> EXTRA_FIXED_RANDCONFIG: >> CONFIG_COVERAGE=n >> >> +# Cppcheck analysis jobs >> + >> +debian-unstable-gcc-cppcheck: >> + extends: .gcc-x86-64-build >> + variables: >> + CONTAINER: debian:unstable-cppcheck >> + CPPCHECK: y >> + >> +debian-unstable-gcc-arm32-cppcheck: >> + extends: .gcc-arm32-cross-build >> + variables: >> + CONTAINER: debian:unstable-cppcheck >> + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- >> + CPPCHECK: y >> + >> +debian-unstable-gcc-arm64-cppcheck: >> + extends: .gcc-arm64-cross-build >> + variables: >> + CONTAINER: debian:unstable-cppcheck >> + CROSS_COMPILE: /usr/bin/aarch64-linux-gnu- >> + CPPCHECK: y >> + >> ## Test artifacts common >> >> .test-jobs-artifact-common: >> diff --git a/automation/scripts/build b/automation/scripts/build >> index f2f5e55bc04f..c219752d553e 100755 >> --- a/automation/scripts/build >> +++ b/automation/scripts/build >> @@ -38,7 +38,16 @@ cp xen/.config xen-config >> # Directory for the artefacts to be dumped into >> mkdir binaries >> >> -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then >> +if [[ "${CPPCHECK}" == "y" ]]; then >> + # Cppcheck analysis invokes Xen-only build. > > Given that when $CPPCHECK == y we are doing a hypervisor-only build, > what do you think of also specifying $HYPERVISOR_ONLY == y in these > cases? > > We could set both CPPCHECK=y and HYPERVISOR_ONLY=y in build.yaml and > then here also check for both. Well, these are just cosmetic changes not impacting anything important, so if you want, I am ok to explicitly set HYPERVISOR_ONLY=y for cppcheck jobs. > > >> + # Known limitation: cppcheck generates inconsistent reports when running >> + # in parallel mode, therefore do not specify -j. > > I take you tried -j$(nproc) on gitlab-ci and didn't work well? I tested > -j$(nproc) in my native arm64 environment and seemed to work well. Both me and Luca agreed on the fact that the reports are inconsistent when running cppcheck analysis with -j$(nproc). It is not that it would fail to create a report. Instead, there will be some internal cppcheck errors present in a report. Therefore, to minimize the risk of producing incorrect list of findings it is best not to specify -j. > > >> + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra >> + >> + # Preserve artefacts >> + cp xen/xen binaries/xen >> + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt >> +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then >> # Xen-only build >> make -j$(nproc) xen >> >> -- >> 2.25.1 >> ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 14 07:57:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 07:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495011.765254 (Exim 4.92) (envelope-from ) id 1pRqBK-00059x-4d; Tue, 14 Feb 2023 07:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495011.765254; Tue, 14 Feb 2023 07:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqBK-00059q-27; Tue, 14 Feb 2023 07:56:54 +0000 Received: by outflank-mailman (input) for mailman id 495011; Tue, 14 Feb 2023 07:56:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqBJ-00059k-Ht for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 07:56:53 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20608.outbound.protection.outlook.com [2a01:111:f400:7e8a::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23d925f3-ac3d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 08:56:52 +0100 (CET) Received: from DM6PR08CA0050.namprd08.prod.outlook.com (2603:10b6:5:1e0::24) by PH7PR12MB8156.namprd12.prod.outlook.com (2603:10b6:510:2b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Tue, 14 Feb 2023 07:56:49 +0000 Received: from DS1PEPF0000E649.namprd02.prod.outlook.com (2603:10b6:5:1e0:cafe::dc) by DM6PR08CA0050.outlook.office365.com (2603:10b6:5:1e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 07:56:48 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E649.mail.protection.outlook.com (10.167.18.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Tue, 14 Feb 2023 07:56:48 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 01:56:46 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 01:56:46 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 01:56:45 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23d925f3-ac3d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EFkM23ipgnXToOKTit0/H5zi6Glu8So/YQl4iGshLmeCKmGCu86y8rTxWkvgU5HPEnqautoooFbw4JUbqIf13JHsntWJ7rjcfqDgo7SimeTeI+Qe4PHNO/6umPg12kKo6NQ9Gd4Vt5WcCfQNYYB9VjTrBF91SqJGDrRXyPg71WDZrKZ9ZtX3BeWiNMUUZCo1ZEHhRe7mfNbbblwqSLFj1HEtJ+l7CjW2aWhNb7KoAKApD7DF90qpOFuJG+JrizEtlMYGaPBTTWlDGYiBOU6bD81fIBjLlSYXe2SYyucBgpqIRnIpTH4NDV6YhoTQz1TNL2Z810qN8XTPc3KtqPb+8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHRGeqFabrzqgtkCv/kwcmFJX8POG9wc4dVfDhSbL9g=; b=OOFNW714u2TRqv1cpkfX9H+Qr81ZG7g5ojhC3Cc9ZjQWaCZEGavt5jjUHUSb2YXFUC1PF7bfhBTMBBBbeYPfwmH5dXPnV4ODf3ooZwkR3RkIkNeJ2NmE2dUnG+915chRoeIVpZ6YHkHDqvY66AwxtkIqTD8PrlL/bJ+gtrpMC/HJhXfId9WWItVLVFDuXkQuXvGKyOYT7jHHQdIaGJSfIQnTzaVBZzI7pc5jJXF6vZCl2P0r6jf33EtI1tvCwylkgcJVmVP+UaCD078+bAYz8qHXChBLzBw3DDluyFlwS3tdidlLdMXP4vJ4SJb3FCAHmR0l3CP0VQHXRm1uH+nDvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHRGeqFabrzqgtkCv/kwcmFJX8POG9wc4dVfDhSbL9g=; b=IWmmC2I4B3p6xDTDzGWZS4sgxJ2PD0Ebmvg07ZM89Kf506gaIISNZOGPnQLJqmFXJGSLpmWJh4hX8f0C2RlAD7uyDQDDQAQzG/Ns1kTde5CuEeScggv5Ew92rR1696yHVkduL10cI8kADpY13MyQTnhlox9WR65sOi247WW6B2I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Tue, 14 Feb 2023 08:56:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/3] automation: Add arm32 dom0less testing Content-Language: en-US To: Stefano Stabellini CC: , Doug Goldstein References: <20230213142210.11728-1-michal.orzel@amd.com> <20230213142210.11728-2-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E649:EE_|PH7PR12MB8156:EE_ X-MS-Office365-Filtering-Correlation-Id: bcffba99-3af3-4ee2-be4d-08db0e61068a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W7DgCkVsOQoeRXK/ACKIkrlJE0EjvN8lVMIEY0+HS3++FY/Zq0+mAanAsw9+pXYhhtb5I6p1Su3cuZFVy/puG2DNjhvM1wJ6yn2cJ3gj/GVHkR0DNz7nhHPJnjQFkA+tx3uFlFRBZ5Yx7/Q+xoEtwVFnekfMQ7exrNnWr0UeuAZ62Eo0ESs3QARPGudvUSIIZSK8o2u6ECk6EW91J4pogz9LNtewbtswDCzdliF3WdxiCls+3bKR01IhWLfGUas9qK3FJ1dH21vcqLJkTeFRExOLZqgqRrihiHRPg3wjQ5zUOS4bHyKkHyRUGY6bw2Dq9dfm5/PpX6c3iS5ufb6ZMmbl/H38Vqe0/hGmaaR7fb4HyvGrlxvz0orjEJts9kWI7hwyIkRDC1fXaokIwqxmeyPmXfYxvmU6Mtgev4NTJxB4kcRwtN/ojB9b1eIHmpO9HO4Zox/2FUpcohKlQBQ9/wHM4/wMUuYSBaPHqzKIaTnQXwq956zBQMYVWPYl0LJoVtpPNn6HgIwX5SUz647CNIqv5EZhlrmH5Vlb/epRbGYiDrx9fq4LtnwBapG0YuJO5QlUEgyxQGZwrq7KuGySliW4TBta/3aqSF1r+pxqGgf7cnEs6WkXArrXAeCO/vtzPMLYQq7R4OrpRponHivc5G04qTgbYatRQ9YW8JtycJICqSBRuLga9fe2+iILORUaVgGea37V7+3DpL07u2cgkP/lLSJfM1KwIWHfVjDRwCaYzfJ3lJq0XpV4Kfxp2Ea8elhHJuTjWuko9cKblbvL7ciftLCl57MIFYY8nL1bdp8= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199018)(46966006)(40470700004)(36840700001)(82740400003)(82310400005)(40480700001)(83380400001)(47076005)(966005)(478600001)(36756003)(40460700003)(26005)(426003)(336012)(53546011)(2616005)(186003)(36860700001)(31686004)(44832011)(70206006)(6916009)(70586007)(86362001)(8936002)(5660300002)(41300700001)(81166007)(356005)(16576012)(316002)(31696002)(54906003)(8676002)(4326008)(2906002)(21314003)(32563001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 07:56:48.6492 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcffba99-3af3-4ee2-be4d-08db0e61068a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E649.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8156 Hi Stefano, On 14/02/2023 01:37, Stefano Stabellini wrote: > > > On Mon, 13 Feb 2023, Michal Orzel wrote: >> At the moment, we only perform a single arm32 test in our CI, checking >> whether dom0 boots successfully or not. This is mostly because we do not >> have any arm32 runners and we only execute a hypervisor only build. >> >> In order not to leave the arm32 testing in such a poor state, add a >> script qemu-smoke-dom0less-arm32.sh to start testing true dom0less >> configuration, in which case we do not need a dom0 with a toolstack. >> >> The script is mostly based on the one used for dom0 arm32 testing as well >> as the one used for dom0less arm64 testing. We obtain Debian Bullseye >> kernel and Alpine Linux busybox-based rootfs. Depending on the test >> variant, we prepare a test case contained within domU_check variable, >> that will be executed as part of /init script. >> >> Signed-off-by: Michal Orzel >> --- >> automation/gitlab-ci/test.yaml | 16 ++++ >> .../scripts/qemu-smoke-dom0less-arm32.sh | 89 +++++++++++++++++++ >> 2 files changed, 105 insertions(+) >> create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh >> >> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml >> index ce543ef5c0ef..84ab1fee50a4 100644 >> --- a/automation/gitlab-ci/test.yaml >> +++ b/automation/gitlab-ci/test.yaml >> @@ -210,6 +210,22 @@ qemu-smoke-dom0-arm32-gcc-debug: >> - *arm32-test-needs >> - debian-unstable-gcc-arm32-debug >> >> +qemu-smoke-dom0less-arm32-gcc: >> + extends: .qemu-arm32 >> + script: >> + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} >> + needs: >> + - *arm32-test-needs >> + - debian-unstable-gcc-arm32 >> + >> +qemu-smoke-dom0less-arm32-gcc-debug: >> + extends: .qemu-arm32 >> + script: >> + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} >> + needs: >> + - *arm32-test-needs >> + - debian-unstable-gcc-arm32-debug >> + >> qemu-alpine-x86_64-gcc: >> extends: .qemu-x86-64 >> script: >> diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh >> new file mode 100755 >> index 000000000000..c81529cbbfd0 >> --- /dev/null >> +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh >> @@ -0,0 +1,89 @@ >> +#!/bin/bash >> + >> +set -ex >> + >> +test_variant=$1 >> + >> +cd binaries >> +# Use the kernel from Debian >> +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz >> +# Use a tiny initrd based on busybox from Alpine Linux >> +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz >> + >> +if [ -z "${test_variant}" ]; then >> + passed="generic test passed" >> + domU_check=" >> +echo \"${passed}\" >> +" >> +fi >> + >> +# domU rootfs >> +mkdir rootfs >> +cd rootfs >> +tar xvzf ../initrd.tar.gz >> +echo "#!/bin/sh >> + >> +mount -t proc proc /proc >> +mount -t sysfs sysfs /sys >> +mount -t devtmpfs devtmpfs /dev >> +${domU_check} >> +/bin/sh" > init >> +chmod +x init >> +find . | cpio -H newc -o | gzip > ../initrd.gz >> +cd .. >> + >> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded >> +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom >> +./qemu-system-arm \ >> + -machine virt \ >> + -machine virtualization=true \ >> + -smp 4 \ >> + -m 1024 \ >> + -serial stdio \ >> + -monitor none \ >> + -display none \ >> + -machine dumpdtb=virt.dtb >> + >> +# ImageBuilder >> +echo 'MEMORY_START="0x40000000" >> +MEMORY_END="0x80000000" >> + >> +DEVICE_TREE="virt.dtb" >> +XEN="xen" >> +XEN_CMD="console=dtuart bootscrub=0" >> + >> +DOMU_KERNEL[0]="vmlinuz" >> +DOMU_RAMDISK[0]="initrd.gz" >> +DOMU_MEM[0]="512" >> +NUM_DOMUS=1 > > Since we are at it I would prefer to create both dom0 and a domU to make > the test more interesting. The following works on gitlab-ci on top of > this patch. Would you be up for adding it to this patch? This is exactly what I had in my initial approach. However, because this would not differ much from what we have in dom0 arm32 testing, I decided to go for true dom0less configuration. I'm ok to always boot dom0less domU with dom0. In this case I might add an additional test to run a true dom0less as well. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 14 08:15:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 08:15:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495018.765266 (Exim 4.92) (envelope-from ) id 1pRqSn-0008PS-Ve; Tue, 14 Feb 2023 08:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495018.765266; Tue, 14 Feb 2023 08:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqSn-0008PL-RR; Tue, 14 Feb 2023 08:14:57 +0000 Received: by outflank-mailman (input) for mailman id 495018; Tue, 14 Feb 2023 08:14:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqSm-0008PB-Oq; Tue, 14 Feb 2023 08:14:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqSm-0000zq-Mi; Tue, 14 Feb 2023 08:14:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRqSm-0004lE-Hn; Tue, 14 Feb 2023 08:14:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRqSm-0008NT-HJ; Tue, 14 Feb 2023 08:14:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HfVuaVqEORzvXePh8gl6cUNjc0od1jnEJFUOqnFHrAs=; b=gfnOaYnLJIXaYYeY8xTudIKJH1 l8HFzjGk0uyMWcHb3En/FpRbYz5s9AMl3z2bKTlgkhhbEv3TbE+F5MckV+eoxCCwL7T7GVI+B8Dsl 6q0GpVuOcOfk3Gyr6owmSAUQ+lAWTU4Ah6kD154aVrOZmisJiPvIJxIQtymoZMBfNCxI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177239: all pass - PUSHED X-Osstest-Versions-This: ovmf=540522fec06b87bf11ad5624abe23b515f282d60 X-Osstest-Versions-That: ovmf=b3f321f2d7871868951cf73edb8fa4d5a88854a5 From: osstest service owner Date: Tue, 14 Feb 2023 08:14:56 +0000 flight 177239 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177239/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 540522fec06b87bf11ad5624abe23b515f282d60 baseline version: ovmf b3f321f2d7871868951cf73edb8fa4d5a88854a5 Last test of basis 177223 2023-02-14 00:11:46 Z 0 days Testing same since 177239 2023-02-14 03:48:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b3f321f2d7..540522fec0 540522fec06b87bf11ad5624abe23b515f282d60 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 14 08:57:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 08:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495058.765316 (Exim 4.92) (envelope-from ) id 1pRr7T-0006bO-1W; Tue, 14 Feb 2023 08:56:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495058.765316; Tue, 14 Feb 2023 08:56:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7S-0006bF-UL; Tue, 14 Feb 2023 08:56:58 +0000 Received: by outflank-mailman (input) for mailman id 495058; Tue, 14 Feb 2023 08:56:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7R-0006UT-Iq for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 08:56:57 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 87023298-ac45-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 09:56:54 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA9211BC0; Tue, 14 Feb 2023 00:57:35 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D6D393F703; Tue, 14 Feb 2023 00:56:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87023298-ac45-11ed-93b5-47a8fe42b414 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu Subject: [PATCH 1/2] xen/cppcheck: add a way to exclude files from the scan Date: Tue, 14 Feb 2023 08:56:34 +0000 Message-Id: <20230214085635.3170962-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214085635.3170962-1-luca.fancellu@arm.com> References: <20230214085635.3170962-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a way to exclude files from the scan, in this way we can skip some findings from the report on those files that Xen doesn't own. To do that, introduce the exclude-list.json file under docs/misra, this file will be populated with relative path to the files/folder to be excluded. Introduce a new module, exclusion_file_list.py, to deal with the exclusion list file and use the new module in cppcheck_analysis.py to take a list of excluded paths to update the suppression list of cppcheck. Modified --suppress flag for cppcheck tool to remove unmatchedSuppression findings for those external file that are listed but for example not built for the current architecture. Add documentation for the file. Signed-off-by: Luca Fancellu --- docs/misra/exclude-list.json | 4 + docs/misra/exclude-list.rst | 44 +++++++++++ xen/scripts/xen_analysis/cppcheck_analysis.py | 21 ++++- .../xen_analysis/exclusion_file_list.py | 79 +++++++++++++++++++ 4 files changed, 146 insertions(+), 2 deletions(-) create mode 100644 docs/misra/exclude-list.json create mode 100644 docs/misra/exclude-list.rst create mode 100644 xen/scripts/xen_analysis/exclusion_file_list.py diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json new file mode 100644 index 000000000000..1fb0ac67747b --- /dev/null +++ b/docs/misra/exclude-list.json @@ -0,0 +1,4 @@ +{ + "version": "1.0", + "content": [] +} diff --git a/docs/misra/exclude-list.rst b/docs/misra/exclude-list.rst new file mode 100644 index 000000000000..969539c46beb --- /dev/null +++ b/docs/misra/exclude-list.rst @@ -0,0 +1,44 @@ +.. SPDX-License-Identifier: CC-BY-4.0 + +Exclude file list for xen-analysis script +========================================= + +The code analysis is performed on the Xen codebase for both MISRA checkers and +static analysis checkers, there are some files however that needs to be removed +from the findings report because they are not owned by Xen and they must be kept +in sync with their origin (completely or even partially), hence we can't easily +fix findings or deviate from them. + +For this reason the file docs/misra/exclude-list.json is used to exclude every +entry listed in that file from the final report. +Currently only the cppcheck analysis will use this file. + +Here is an example of the exclude-list.json file:: + +|{ +| "version": "1.0", +| "content": [ +| { +| "rel_path": "relative/path/from/xen/file", +| "comment": "This file is originated from ..." +| }, +| { +| "rel_path": "relative/path/from/xen/folder/*", +| "comment": "This folder is a library" +| }, +| { +| "rel_path": "relative/path/from/xen/mem*.c", +| "comment": "memcpy.c, memory.c and memcmp.c are from the outside" +| } +| ] +|} + +Here is an explanation of the fields inside an object of the "content" array: + - rel_path: it is the relative path from the Xen folder to the file/folder that + needs to be excluded from the analysis report, it can contain a wildcard to + match more than one file/folder at the time. This field is mandatory. + - comment: an optional comment to explain why the file is removed from the + analysis. + +To ease the review and the modifications of the entries, they shall be listed in +alphabetical order referring to the rel_path field. diff --git a/xen/scripts/xen_analysis/cppcheck_analysis.py b/xen/scripts/xen_analysis/cppcheck_analysis.py index cc1f403d315e..b681dca90836 100644 --- a/xen/scripts/xen_analysis/cppcheck_analysis.py +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py @@ -1,7 +1,8 @@ #!/usr/bin/env python3 import os, re, shutil -from . import settings, utils, cppcheck_report_utils +from . import settings, utils, cppcheck_report_utils, exclusion_file_list +from .exclusion_file_list import ExclusionFileListError class GetMakeVarsPhaseError(Exception): pass @@ -50,6 +51,22 @@ def __generate_suppression_list(out_file): # header for cppcheck supplist_file.write("*:*generated/compiler-def.h\n") + try: + exclusion_file = \ + "{}/docs/misra/exclude-list.json".format(settings.repo_dir) + exclusion_list = \ + exclusion_file_list.load_exclusion_file_list(exclusion_file) + except ExclusionFileListError as e: + raise CppcheckDepsPhaseError( + "Issue with reading file {}: {}" + .format(exclusion_file, e) + ) + + # Append excluded files to the suppression list, using * as error id + # to suppress every findings on that file + for path in exclusion_list: + supplist_file.write("*:{}\n".format(path)) + for entry in headers: filename = entry["file"] try: @@ -128,7 +145,7 @@ def generate_cppcheck_deps(): --relative-paths={} --inline-suppr --suppressions-list={}/suppression-list.txt - --suppress='unmatchedSuppression:*generated/compiler-def.h' + --suppress='unmatchedSuppression:*' --include={}/include/xen/config.h -DCPPCHECK """.format(settings.outdir, CPPCHECK_BUILD_DIR, settings.xen_dir, diff --git a/xen/scripts/xen_analysis/exclusion_file_list.py b/xen/scripts/xen_analysis/exclusion_file_list.py new file mode 100644 index 000000000000..4a47a90f5944 --- /dev/null +++ b/xen/scripts/xen_analysis/exclusion_file_list.py @@ -0,0 +1,79 @@ +#!/usr/bin/env python3 + +import os, glob, json +from . import settings + +class ExclusionFileListError(Exception): + pass + + +def __cppcheck_path_exclude_syntax(path): + # Prepending * to the relative path to match every path where the Xen + # codebase could be + path = "*" + path + + # Check if the path is to a folder without the wildcard at the end + if not (path.endswith(".c") or path.endswith(".h") or path.endswith("*")): + # The path is to a folder, if it doesn't have the final /, add it + if not path.endswith("/"): + path = path + "/" + # Since the path is a folder, add a wildcard to the end so that + # cppcheck will remove every issue related with this path + path = path + "*" + + return path + + +# Reads the exclusion file list and returns a list of relative path to be +# excluded. +def load_exclusion_file_list(input_file): + ret = [] + try: + with open(input_file, "rt") as handle: + content = json.load(handle) + entries = content['content'] + except json.JSONDecodeError as e: + raise ExclusionFileListError( + "JSON decoding error in file {}: {}".format(input_file, e) + ) + except KeyError: + raise ExclusionFileListError( + "Malformed JSON file: content field not found!" + ) + except Exception as e: + raise ExclusionFileListError( + "Can't open file {}: {}".format(input_file, e) + ) + + for entry in entries: + try: + path = entry['rel_path'] + except KeyError: + raise ExclusionFileListError( + "Malformed JSON entry: rel_path field not found!" + ) + abs_path = settings.xen_dir + "/" + path + check_path = [abs_path] + + # If the path contains wildcards, solve them + if '*' in abs_path: + check_path = glob.glob(abs_path) + + # Check that the path exists + for filepath_object in check_path: + if not os.path.exists(filepath_object): + raise ExclusionFileListError( + "Malformed path: {} refers to {} that does not exists" + .format(path, filepath_object) + ) + + if settings.analysis_tool == "cppcheck": + path = __cppcheck_path_exclude_syntax(path) + else: + raise ExclusionFileListError( + "Unimplemented for {}!".format(settings.analysis_tool) + ) + + ret.append(path) + + return ret -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 08:57:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 08:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495057.765304 (Exim 4.92) (envelope-from ) id 1pRr7Q-0006LU-Q4; Tue, 14 Feb 2023 08:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495057.765304; Tue, 14 Feb 2023 08:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7Q-0006LN-NS; Tue, 14 Feb 2023 08:56:56 +0000 Received: by outflank-mailman (input) for mailman id 495057; Tue, 14 Feb 2023 08:56:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7Q-00066D-1y for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 08:56:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 87da0b50-ac45-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 09:56:55 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B5E81BCB; Tue, 14 Feb 2023 00:57:37 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 67A0E3F703; Tue, 14 Feb 2023 00:56:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87da0b50-ac45-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu Subject: [PATCH 2/2] xen/misra: add entries to exclude-list.json Date: Tue, 14 Feb 2023 08:56:35 +0000 Message-Id: <20230214085635.3170962-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214085635.3170962-1-luca.fancellu@arm.com> References: <20230214085635.3170962-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add entries to the exclude-list.json for those files that need to be excluded from the analysis scan. Signed-off-by: Luca Fancellu Signed-off-by: Michal Orzel --- This list is originated from Michal's work here: https://patchwork.kernel.org/project/xen-devel/patch/20221116092032.4423-1-michal.orzel@amd.com/#25123099 the only files removed are the *arm/smmu* that, if I understand correctly, we would like to include in the scan. --- --- docs/misra/exclude-list.json | 207 ++++++++++++++++++++++++++++++++++- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json index 1fb0ac67747b..3a6dc0809af5 100644 --- a/docs/misra/exclude-list.json +++ b/docs/misra/exclude-list.json @@ -1,4 +1,209 @@ { "version": "1.0", - "content": [] + "content": [ + { + "rel_path": "arch/arm/arm64/cpufeature.c" + }, + { + "rel_path": "arch/arm/arm64/insn.c" + }, + { + "rel_path": "arch/arm/arm64/lib/find_next_bit.c" + }, + { + "rel_path": "arch/x86/acpi/boot.c" + }, + { + "rel_path": "arch/x86/acpi/cpu_idle.c" + }, + { + "rel_path": "arch/x86/acpi/cpufreq/cpufreq.c" + }, + { + "rel_path": "arch/x86/acpi/cpuidle_menu.c" + }, + { + "rel_path": "arch/x86/acpi/lib.c" + }, + { + "rel_path": "arch/x86/acpi/power.c" + }, + { + "rel_path": "arch/x86/cpu/amd.c" + }, + { + "rel_path": "arch/x86/cpu/centaur.c" + }, + { + "rel_path": "arch/x86/cpu/common.c" + }, + { + "rel_path": "arch/x86/cpu/hygon.c" + }, + { + "rel_path": "arch/x86/cpu/intel.c" + }, + { + "rel_path": "arch/x86/cpu/intel_cacheinfo.c" + }, + { + "rel_path": "arch/x86/cpu/mcheck/mce-apei.c" + }, + { + "rel_path": "arch/x86/cpu/mcheck/non-fatal.c" + }, + { + "rel_path": "arch/x86/cpu/mtrr/*" + }, + { + "rel_path": "arch/x86/cpu/mwait-idle.c" + }, + { + "rel_path": "arch/x86/delay.c" + }, + { + "rel_path": "arch/x86/dmi_scan.c" + }, + { + "rel_path": "arch/x86/domain.c" + }, + { + "rel_path": "arch/x86/genapic/*" + }, + { + "rel_path": "arch/x86/i387.c" + }, + { + "rel_path": "arch/x86/irq.c" + }, + { + "rel_path": "arch/x86/mpparse.c" + }, + { + "rel_path": "arch/x86/srat.c" + }, + { + "rel_path": "arch/x86/time.c" + }, + { + "rel_path": "arch/x86/traps.c" + }, + { + "rel_path": "arch/x86/usercopy.c" + }, + { + "rel_path": "arch/x86/x86_64/mmconf-fam10h.c" + }, + { + "rel_path": "common/bitmap.c" + }, + { + "rel_path": "common/bunzip2.c" + }, + { + "rel_path": "common/cpu.c" + }, + { + "rel_path": "common/earlycpio.c" + }, + { + "rel_path": "common/inflate.c" + }, + { + "rel_path": "common/libfdt/*" + }, + { + "rel_path": "common/lz4/decompress.c" + }, + { + "rel_path": "common/notifier.c" + }, + { + "rel_path": "common/radix-tree.c" + }, + { + "rel_path": "common/rcupdate.c" + }, + { + "rel_path": "common/softirq.c" + }, + { + "rel_path": "common/tasklet.c" + }, + { + "rel_path": "common/ubsan/ubsan.c" + }, + { + "rel_path": "common/un*.c" + }, + { + "rel_path": "common/vsprintf.c" + }, + { + "rel_path": "common/xz/*" + }, + { + "rel_path": "common/zstd/*" + }, + { + "rel_path": "crypto/rijndael.c" + }, + { + "rel_path": "crypto/vmac.c" + }, + { + "rel_path": "drivers/acpi/apei/*" + }, + { + "rel_path": "drivers/acpi/hwregs.c" + }, + { + "rel_path": "drivers/acpi/numa.c" + }, + { + "rel_path": "drivers/acpi/osl.c" + }, + { + "rel_path": "drivers/acpi/reboot.c" + }, + { + "rel_path": "drivers/acpi/tables.c" + }, + { + "rel_path": "drivers/acpi/tables/*" + }, + { + "rel_path": "drivers/acpi/utilities/*" + }, + { + "rel_path": "drivers/char/ehci-dbgp.c" + }, + { + "rel_path": "drivers/char/xhci-dbc.c" + }, + { + "rel_path": "drivers/cpufreq/*" + }, + { + "rel_path": "drivers/video/font_*" + }, + { + "rel_path": "lib/list-sort.c" + }, + { + "rel_path": "lib/mem*.c" + }, + { + "rel_path": "lib/rbtree.c" + }, + { + "rel_path": "lib/str*.c" + }, + { + "rel_path": "lib/xxhash32.c" + }, + { + "rel_path": "lib/xxhash64.c" + } + ] } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 08:57:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 08:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495056.765294 (Exim 4.92) (envelope-from ) id 1pRr7O-00066Q-J1; Tue, 14 Feb 2023 08:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495056.765294; Tue, 14 Feb 2023 08:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7O-00066J-GD; Tue, 14 Feb 2023 08:56:54 +0000 Received: by outflank-mailman (input) for mailman id 495056; Tue, 14 Feb 2023 08:56:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRr7O-00066D-2l for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 08:56:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 8616a93d-ac45-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 09:56:53 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A9931042; Tue, 14 Feb 2023 00:57:34 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52C813F703; Tue, 14 Feb 2023 00:56:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8616a93d-ac45-11ed-933c-83870f6b2ba8 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu Subject: [PATCH 0/2] xen/misra: create exclusion file list Date: Tue, 14 Feb 2023 08:56:33 +0000 Message-Id: <20230214085635.3170962-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This serie is introducing an exclusion list for the misra analysis, at the moment only cppcheck can benefit from it because it's the tool where we control every step and configuration. Exclude a file from the analysis is the last step we should do, but sometime it is unavoidable because we can't do direct changes to it to fix/deviate from findings. So we declare the file(s) here and we leave the burden of the misra compliance to the final user. Luca Fancellu (2): xen/cppcheck: add a way to exclude files from the scan xen/misra: add entries to exclude-list.json docs/misra/exclude-list.json | 209 ++++++++++++++++++ docs/misra/exclude-list.rst | 44 ++++ xen/scripts/xen_analysis/cppcheck_analysis.py | 21 +- .../xen_analysis/exclusion_file_list.py | 79 +++++++ 4 files changed, 351 insertions(+), 2 deletions(-) create mode 100644 docs/misra/exclude-list.json create mode 100644 docs/misra/exclude-list.rst create mode 100644 xen/scripts/xen_analysis/exclusion_file_list.py -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 09:52:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 09:52:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495080.765326 (Exim 4.92) (envelope-from ) id 1pRryu-0005vV-4m; Tue, 14 Feb 2023 09:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495080.765326; Tue, 14 Feb 2023 09:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRryu-0005vO-2D; Tue, 14 Feb 2023 09:52:12 +0000 Received: by outflank-mailman (input) for mailman id 495080; Tue, 14 Feb 2023 09:52:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRrys-0005vH-0z for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 09:52:10 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2074.outbound.protection.outlook.com [40.107.13.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3df3bcac-ac4d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 10:52:07 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8106.eurprd04.prod.outlook.com (2603:10a6:10:24b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 09:51:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 09:51:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df3bcac-ac4d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKPgDmxr3JcwFy2oMwj1JOMtn3GayE2zJrurM61g4yBQHPHGjsgPc7N5WWDc6saCpY4eOhr/waAiiu3CwBpUQQgSzqg6uwbddhIp0s2YLsgDTe0s4FyVDKGbGIB9hEtMN00FnKMPHwFxkOGM4kea80KOhFP4UBHXcfyEH5I5NFcc2FCEGRftsjA3iMjvTwTNKnmji9v8PQW1NGl6qIBbh1EBxflxJ88j4apU7qWfpAl+yjzQOuq3HaV9FvYt05Aa3MELcs1gadpOjbPQZpKpyO2Zx1ILWXAXN2TmmZ/gyL44oEKX3721OFbJv3a4zbAPQXNx1SfTCcAMdEaloWHAyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AZocWXyZtw3yVPEYBp1SF2PtD/fD8PSpNe7v3NRbbHM=; b=RXt85asNcjIuwysUjGxYtfgYo1wGm+gHeRW6HE6deInq0ol++rklwYQU0WqB0GdmqiRVfQYa4IVbHmW4/yquWySrfwBHOjZvzwgoSFQgXAac97/6upEKzq/bCbNX9RyJndBcgQWuxPcw5GJSr+FhGAD0vobmoaSOoPmHK81HKoBkvmwf6dZyndDtek6VVpcKVr/j0pV3UIRQ4ZUMbB1EOQ2qgpleyoM/ecnM88uTfD+KFw0VxVh5V6e9Ngzii3+5l/rvmmzv1++dd3Ly8Ta/ewRvMUIW+5KAMrW0ZMcbP4zTffcSXmKqkBXkPLHJW8CBEdhIWsgjSjMtY1V63Fz57w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AZocWXyZtw3yVPEYBp1SF2PtD/fD8PSpNe7v3NRbbHM=; b=mVyVu0HQLAQUauSmhoQl+spLB+SfCqk33Pa7dJhT7q+hZSScozSKthwh4eByEyrul2AiNtgb71Klbvz2HLK7E3S/rNzfAzvt93oMAz/aSMB7UOL6VRf9Dd6vAoqD05nCnFC+yKNPH/mAruiofYKXPtWe99awewfxO0oV5tsATdygkPkrZMfMApP4WAtFOpyGsD7uo5YXVSes7HDtXPkovGK+OmrGx2/9Ui1gYXFjqqYAHQ6PTU6z4JjLX0HBxhcg8c9QrOVVneV/QcHoule5MwiEbbzQPIl7GUITUaii1ghFiWmUTXwKWOiLtGPJtOrfcIYXk0nbInFNBvrMJoJQBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4d86325f-8706-98d1-c233-963fd42076fa@suse.com> Date: Tue, 14 Feb 2023 10:51:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/2] xen/cppcheck: add a way to exclude files from the scan Content-Language: en-US To: Luca Fancellu Cc: wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-2-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20230214085635.3170962-2-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1P18901CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:801::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8106:EE_ X-MS-Office365-Filtering-Correlation-Id: 7637d48c-08f0-4b67-7e13-08db0e7110d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FagKfigS9DpOYHHdnTwak8NgJprW/oswTgv+6tGCG9K2QwGxfcUAomXpg2XLjZ/cLdHvLa24NaaCeSreaiNimLPfdIYK1KxLzPQL3mtMkpQOZslqo/Oy1o7EV84XdGCgXEpxMHJe5S0AIXT5XNjwvzC890AjbVP4BBL+zUKjFF4An66eEvY0GZbHgAF0omzngeYvdH+PV6BPdAyro5QDb+H/J0RVTa14xr738PRM7i4HWYvQAvzgHHww1ib6A3xhab617RvRphdmrFI4RMYDkPLHdl2kZHzblkFKyY9W4+VS1O0M+/q0NqlNbTAis7xATN0URMPN3Lf8ZD18WP6ClFjqLU22b/w3lzW7BIgHLP1wKkd7SycC/MV+Q9cDpyB5ZWCJbzV4Pr1rRl5bIOcvIOwbxxJ8R/QfcvAPxgezJADSMZa/OQD3AGtI1y8AYyQ6p0NMuJDfPV1nXEUK/mwxnhFVuUuYlhyntSgLhzhCU5brIceYs4mK6YOeNXFc/hjeJiIJNEt8uuHQfITqQyNAyLiuZKRJbk2tLZB4Pg0nKeWSNbJbU2TOk7aFqM/x4NSco6FXAaAhSPxgqfdVld2o1yIlUHXPTFjeW8QJOpNL38Qj89yfxt3hwaNwJ52lMYluoqi69DePCbDMuiVGK214CjNelKBYz5XEex2a3/VZeY9t3JKc7FEUG3rHRtbZM3q/02JcONI7AgYO1exR3Y58Uxzdn5s0Tf6GU63w4S9iXydr1OpAzVTfUbUVwL/ewvuW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199018)(31686004)(66899018)(53546011)(26005)(6506007)(83380400001)(6486002)(2906002)(36756003)(38100700002)(54906003)(66476007)(66556008)(6916009)(8676002)(66946007)(4326008)(186003)(6512007)(2616005)(478600001)(6666004)(8936002)(316002)(86362001)(31696002)(5660300002)(41300700001)(7416002)(43043002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NW9MNHpWRUVTK2Eyc1lpYTZER2llYWk1aHlxVGxaNWlBTmlVQytsN0tTK1da?= =?utf-8?B?SXQ1VTBPUEVHajBremlkMERHVm8zZkZMamZ4M2piRHVST042cncyeUNndXZk?= =?utf-8?B?ZFVTOU9lbDdMRU5oanhDNVdIc0FIT1IxMnlkZUpOQ3YxcnZvK1RUWGtMWXRO?= =?utf-8?B?RTJWTTc2a1prRnpSdTNmSys0WVJMTHhmZjVCd01zMjlqckMyQTBkNktva29v?= =?utf-8?B?cFU2aXdabWZsblpNWUMxRlhuMjVRbXV2b1RBeXRta21scVFaay8xOEtaMSt2?= =?utf-8?B?cHZJb3Z1MUdURlFLZ1FoNkk3RmoyNCtaT0ZOZnNPVDFaZWJnY1d0bVhWL2tF?= =?utf-8?B?RWRCbllQOG5oYmVDb3FMd29IVEsva0ZUMnBURitDaExTQnprYlFoVEh1R2xy?= =?utf-8?B?TVBEY3NxWlBWbEk5UzRVRkc2RXpiTkw1aG9QZjNDWXRHb1pYVlAzMFdQb0dF?= =?utf-8?B?cGtVditwZlRLM3NoQnFsOWNNYm5lRndqdmh5cTJHbnBaM2w2MWFLSHFmeWhT?= =?utf-8?B?UjlsZnVaMTNEbmRMWlpkR2p0VVIyT0J2QTJ5SzA2SXhycjdPZW9rR1EyVFBn?= =?utf-8?B?ajJBQUJ0aDEvYVgxLzkwNVhsZkR0RTFXMjV0SUZxYW1sSVdUMjVqVXRYbFhm?= =?utf-8?B?NmFUUmQ5RjBJNXRCNVdKMDE1MlVYWVJWUlk1WmJDQ0dhRXVaZHI1SzJ2aW11?= =?utf-8?B?cU1hU1M5VEQ2RWQ3TjFGNkZMZTBFUXcxQVA0V3FiWEVjR01qZ0djaWpzM0RO?= =?utf-8?B?dDZ1Q0N4VkgyeU1ld2RzVm1vSzZzZEU5eUFWSTcyUEVZZzhuYnovd2ordnJV?= =?utf-8?B?ZjZFTlBvbEZOa0JlS29XdVhGZ2NQVzluUjBWRWlZdFB0UkNtVHEvS0pTSy8v?= =?utf-8?B?bzBwYmFjMGdFNDZxaXRTTzAzRWNjWUVRaVlhTDF6U3JtYkNrNE5ONE5CTmlG?= =?utf-8?B?ODhDUW5STVpMUSt3Rk1vTWVnN3FTMWdTUTdYSHZMb1B3TWY5SkFnMCswa3lI?= =?utf-8?B?MUk3cXZmOEg4ZW95R3JjMGc2aXltY1MycmdLQ3JtVTAxUkFzazdHYWFFd0RW?= =?utf-8?B?MFNpQUUzSE56c2lRRi92SldnSWZud1ZYeWExS1Y4U2JYSitTNHhQUytFZlZm?= =?utf-8?B?cmZrRVlKcE5vTE53TXh6bldkdEZaK3R1NUZQSlBidGI2Z2tydFR6ejJnZ3pz?= =?utf-8?B?ZW5WZ2JkZTMwVTFHZXFIM1JxemZ0WDNlQzI4SEQyMUJ3V0crY3RzNzdNYS9w?= =?utf-8?B?U2paVTZTUng5YXB4ZUx4YVEzMFNEZW16RHBXQ0ZaRDZXMDV1U3dDSlRZOVJO?= =?utf-8?B?YlBqNjcwSEFZZXF6b01DVzQ3QnZlclIrc0tsdnJkZjdEUDJJL0lkcVVUczhD?= =?utf-8?B?ZWNLMk1ockczRmpreDZTVDR2S1lYb3dKYm03anVyMHBkelNaQ2RRWk4vMmVz?= =?utf-8?B?NnFMRWFoNlo3UGxsYlh0RVdwN1o4eUpHNDdHa2V4SkliQ014RXgrR3Z5b0F5?= =?utf-8?B?LzRURURrWlRJSHhxaUJBa1hhU1ZoWnJJWkNVWjlHQkxJTHlDcUx5cTZPV1Rw?= =?utf-8?B?NUxjc2pLeVZUbHlLQ1I1cHNhL3JGVlFxOGFyVFhjQTdaSjVjRVg0SmloN09I?= =?utf-8?B?VGFEWGRtakxjUWlUaXhCNUxuNnY4MkQxZEhObXlHRGFIMjVtU0VGR01nYkVX?= =?utf-8?B?UDVzL0t0Vm1JazFvU1p5S2ovU1AzbGxhYlQwWUgxcVZwaUZBN2ZCQkZKN3po?= =?utf-8?B?cFZOVjRaWjVkditsZ0pDbnpYb1ZhVDJvWTE1VVRsMGpodnJiM21FV3QzRFho?= =?utf-8?B?VkxuY21mNHZJU2wwMXE0cXo3ZnRFTGhieC9IOENSWDFxVlI2VXMzSUVFL0d1?= =?utf-8?B?eEJJYUlyeGpIZWhvUXNROXlUN2pvWGZEVlp1UHFicnNTMlI3Y0VMRGlQdEdK?= =?utf-8?B?eE5WWlVnYkdENEFOd0pyakZUSm5qeDI4ZVBOSWNhejB2Vjl6VHgrdkFjZG5V?= =?utf-8?B?R1IrOTBaYXNqdVJiM3J2OXNyS3l2bFlwemtsV2hnek5FSjNqNUZBWlNtZTFJ?= =?utf-8?B?M0lIWnZtVW4zWFhiVUpEaHU5bGdiUnpjdGsycktZTUVhQjBqYzlIcUpka2xQ?= =?utf-8?Q?E6UDrWFufQa6InJokcje7F7sh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7637d48c-08f0-4b67-7e13-08db0e7110d2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 09:51:38.0943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wnEQostgJIO74e7GN6ALuJ2KD5rspNNkmdA8syB5RMStD6INeMKDxkmBy6gW1zEGlSTHspjrWc2jDHTEEVrPbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8106 On 14.02.2023 09:56, Luca Fancellu wrote: > Add a way to exclude files from the scan, in this way we can skip > some findings from the report on those files that Xen doesn't own. > > To do that, introduce the exclude-list.json file under docs/misra, > this file will be populated with relative path to the files/folder > to be excluded. > Introduce a new module, exclusion_file_list.py, to deal with the > exclusion list file and use the new module in cppcheck_analysis.py > to take a list of excluded paths to update the suppression list of > cppcheck. > Modified --suppress flag for cppcheck tool to remove > unmatchedSuppression findings for those external file that are > listed but for example not built for the current architecture. > > Add documentation for the file. > > Signed-off-by: Luca Fancellu > --- > docs/misra/exclude-list.json | 4 + > docs/misra/exclude-list.rst | 44 +++++++++++ > xen/scripts/xen_analysis/cppcheck_analysis.py | 21 ++++- > .../xen_analysis/exclusion_file_list.py | 79 +++++++++++++++++++ > 4 files changed, 146 insertions(+), 2 deletions(-) > create mode 100644 docs/misra/exclude-list.json > create mode 100644 docs/misra/exclude-list.rst > create mode 100644 xen/scripts/xen_analysis/exclusion_file_list.py As I think I have asked for before: Can new files please avoid underscores in their names, when dashes do quite fine? Or does Python have special restrictions? > --- a/xen/scripts/xen_analysis/cppcheck_analysis.py > +++ b/xen/scripts/xen_analysis/cppcheck_analysis.py > @@ -1,7 +1,8 @@ > #!/usr/bin/env python3 > > import os, re, shutil > -from . import settings, utils, cppcheck_report_utils > +from . import settings, utils, cppcheck_report_utils, exclusion_file_list > +from .exclusion_file_list import ExclusionFileListError > > class GetMakeVarsPhaseError(Exception): > pass > @@ -50,6 +51,22 @@ def __generate_suppression_list(out_file): > # header for cppcheck > supplist_file.write("*:*generated/compiler-def.h\n") > > + try: > + exclusion_file = \ > + "{}/docs/misra/exclude-list.json".format(settings.repo_dir) > + exclusion_list = \ > + exclusion_file_list.load_exclusion_file_list(exclusion_file) > + except ExclusionFileListError as e: > + raise CppcheckDepsPhaseError( > + "Issue with reading file {}: {}" > + .format(exclusion_file, e) > + ) My Python isn't very good, but isn't indentation one level too deep here? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 09:54:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 09:54:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495088.765338 (Exim 4.92) (envelope-from ) id 1pRs1C-0006XS-LA; Tue, 14 Feb 2023 09:54:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495088.765338; Tue, 14 Feb 2023 09:54:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs1C-0006XL-IU; Tue, 14 Feb 2023 09:54:34 +0000 Received: by outflank-mailman (input) for mailman id 495088; Tue, 14 Feb 2023 09:54:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs1C-0006XF-2F for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 09:54:34 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2058.outbound.protection.outlook.com [40.107.13.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94c3a3e8-ac4d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 10:54:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7719.eurprd04.prod.outlook.com (2603:10a6:20b:29a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 09:54:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 09:54:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c3a3e8-ac4d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmlwGEYg7jmD0S86TdNj3niTn/98VTNVNgBKOBsra2fS5WYjnzBOk3N22hH/6I8xmfEeQ/CVnkqiz3GVdMA4Vqy7neI3k1ks8SRCgVd6KqugFFINyvEg/byVvvK18dfK26+DB1SUKJJIC2pJxPCCTqKiPAAa0Hc8ys42w01GP6dr4VIjhSK01/vNyF9C7O0wj9Zer1xZbb/Pjar3HthJuNBz6B8k6ww5ooSQjz6FHkiQga8p71vct6RD5kUDvnFu2+mRhp+XKrlCjbczg/by2xwbbS6SUo9ogl4gbmVtlsawzSQmpZKa/GfFuAeg5LuYoqX3MmvaBKQYWi9GICKttQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BDPDy9oVSHVk9YQmfF2IW2uY0eWD8OytPNfXzBWjR1s=; b=ZXqIVGa5aNkkbnBJ0j5RW5cT1HCej94rc79IjAOjGzyidirtAJh94GUVGHKIeXlZfNMPVubcoB86bPRTz8OX8REk16Ld56XgIUsrtTOTIYrEf0Fwqu+Nsu3Hbh3tyzsQUla0Pmw59lU9dnyDtRzUNKJe5W2uAjZGc7B9JNM4uKjlUoE4MMDfjRAkD11zhrynJj2jZr1GWc/jULcN8yO7iq3YwULJkBgTVz4ekMGDn9YBQaPSjLTf/Rt62/RCLz8qk2z4fsXPU3//rOrHNzsefpDhYjWrlEL6kMru51gUnxpw9l3xQni1mm04gzG1CquIiFRCz0F2iZlANB6FCEnVJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BDPDy9oVSHVk9YQmfF2IW2uY0eWD8OytPNfXzBWjR1s=; b=oJ9oecmbg0S19Jle1OVyBLLmrAQlkJFsWsqXJixTRmVZcj168N84CvaPV8ZyiU1oQYswdfPRhWog6SCHvUvOfe0iXdebQZTbRr7bPEmIxX9ej/HrLXswiuDPyYJO/8S4YmC1yi48Bow4oeNlgtOygdKwlBKbBNxj7aX48AiZIM/tmS50PdKKhWB5Ykkgrzb5Hz5INhVar9/4xgIVYo8LpQNfBRiA3H2VrJJNPh37q9zYooP0pGQ5vcjPgwsS6WEdD0av3f0tGs5wLDbxAk6XJ2b0Xo7v5PIU8POz6F4IX2j3leJX3Pk43eqUOJqUXp/sdCxxz7dclrTpg2Zth2CzFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 14 Feb 2023 10:54:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Content-Language: en-US To: Luca Fancellu Cc: wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20230214085635.3170962-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7719:EE_ X-MS-Office365-Filtering-Correlation-Id: e3f5398c-ccad-4c7d-c5cb-08db0e716772 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Akv5o30/zWbO1GWb9qIuDJBeqIG4s0l2pwQ7jpFKhw4HHIC8TKDbvkQcQG9T7QWv6TmiZbVfiiZKe5KX+AAJkeopDWfwI3zQyKkGMddDDCU8WBs5SbBz5vq0RaA8WJgZ5E9gaeDxN1/3I1u9Lzqeb3QwUYlLKoNefJ3ZH8/DF9AkrDyarZL8pDaJ2n0GAzKYAYwtaHxXKj+rWexknFs8sqPV3Y/8FKBogeAwopzYu9hlXJN/59mMis1MBDSUcYO/Mlq69eBc2JanujCswv5Pp2oJ3jRtINQrdddSGsNB8Q55jrC3AWt6iIhwA5cI2ejrhB+UKq8FZ8ru9wZUOWWe4IKa9SXIV5YRzWvBkBRWmhXs+lW2uobFVLQaHpx8yx4fqTfLzA8+tu1g3Ks3Xj5V8FndwgXIrlRNRcaYpSpyi3EbcVdvCrEZcbTMqmBd7I2KA5X1aQL9sByz1iqLICc6H10UejoV/79mEg9wphBIRjWfj0hjUPa9tVnkGCqn2m8HpAgkQ4SiTyPoYCkSj/ycuJtsEJgCpd5rnmJ2Hynk/v5gxxx/xg7ndys0LRfjXBv5mU0xrWfqrP3XVxEAY0ubM3hZHDKzCAZ8Fpv7SHBpMspKO3hKANHJevXX9Hsw9CB1Bo6x/dUVyJ3lplBjav6kceAGbbTDlwPXCgyNj30dwSSoiUdTU139gXLrKZSktPjhT1LcwBaLAnCJzp69G6uJhv34wSjvYASW24lKGse/IJE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(8936002)(41300700001)(2906002)(31686004)(7416002)(5660300002)(38100700002)(66556008)(4326008)(8676002)(66476007)(66946007)(53546011)(54906003)(6916009)(36756003)(478600001)(31696002)(6486002)(6506007)(86362001)(6512007)(2616005)(26005)(186003)(316002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzJRT1hBa2poNFVYc0xvU3VlalBRK0YrOXk1RXNpY29rbFNIWmdscHVRWXVm?= =?utf-8?B?cWRWUE5hMWpac3ltdGo0RnFxa0tpemhwbk4wRjFjeUE5U2R2MVlnRW5pYXVS?= =?utf-8?B?TW16R1NlTVNwTUpXdkhpbTZsRURmRVo4c2MwWWEvOW5zUExKalQxUWI5dWF0?= =?utf-8?B?cHR3amUwdENhbUVRNWtPd2M5c2Vha2kzc1BiSU51ZW9HZkx6MzJHSmMzZjRP?= =?utf-8?B?VmI2V0g5M0FDdE94YVYyck1oalRLQkF4cUNLWGZrR1RmWFNhL3ltbjZqSTdv?= =?utf-8?B?OTltNVJwN3hSSlNYdk5EcUVPZHpIdWpsUFhlK29HYW9IRlhWdy9GWEErREE4?= =?utf-8?B?L0w2QlZlajgrRmNyMjZTdytFU3Q4MmhFSDNQZGRlTUxObDdwOXhJclVTTGN3?= =?utf-8?B?Zy8vWmhnV3hFTTVPVERJWmVTTUNIaHA1MGZBeVZRMm5KaFk0Z2N0d01tWXZi?= =?utf-8?B?bFZ2d3BYZ05DVlNzdkFZZEJmMkFZQ1FQMWFSdHFjTTBwdlJ6SXZ1MVV4RFV4?= =?utf-8?B?TDNxYnJFandjVjk1NUx5cmxDQVFPQkpKTjV1cU94RS85cngzZWIwRGc3eUJF?= =?utf-8?B?ek5FRlp0amF2Z1RnZ3c0NzhOYlVaaHltTVBTUTdZeHpkenhHd0d4aURNbWJt?= =?utf-8?B?ZmVuNXg1anlTMm15dThIVVU4K3RsKzFIeGZqVHBpeVNPV3pSMDFYY2V3OUts?= =?utf-8?B?dDVwRnpST1FzQjU3TlE3Mk02ak1oMlpMRk81VElONytyNWZ3MTNjdXd3Q1Vq?= =?utf-8?B?bmIrTGdDNzRucjl0TnMxcmNxZWJnZWhPS29kTnFRemJTRTYwL0IyMzNlZjZB?= =?utf-8?B?VCt5d09YVjg0R0ZBKzJ3SUtQa09XVndnWkhqYVNSZkhWTGUrYlBVWHB4S3I4?= =?utf-8?B?Y0tSU3lWUk9SM0VoZXdobjBKRGFPM2dBcmN5VEh4UlJIMXNHWkt6akhuKzA2?= =?utf-8?B?ajhSWS93YTlzb3pDdkFsdXZ6OVd5RFJhelBOamlKRFZ1MEZjQmpFYVdPSUtk?= =?utf-8?B?RzNpcUxJMmNrb2pmTEJkL1hVQ0F6aUc3RjBVUEt1ZGxmcGJtTFg3VmQ2SFFp?= =?utf-8?B?MWR1RU1JM3RxcUtENzhEbVoxYXRoZkhBbGdTdlIza29GMEs1UzBUanJZMmh0?= =?utf-8?B?MExaUXNnaDhraXVVY0xPSFlVRmNON3BkTWV5WS9yb0UwdExwbjRHbjFIRFd5?= =?utf-8?B?VVJJMEhSVFZXa3lCTkVCYXk0ckJIQ3Q2ZDBJY1VlbjIydUZsd3lweXVNK3dj?= =?utf-8?B?RXFRNWVXcGl6YXQ2TFpaZ3hoazV6UWF3ZXhRVCtyN0VkSXFRdE9MTU5YalNq?= =?utf-8?B?MlhoUEd2czNJWlovZXhNZTMxZFBUMmY3Mi9lRW5OQTdsWEdxMjcvOFNqZzUx?= =?utf-8?B?R3UzMzExWkUrandOcTdHYWVxNnlTSE0zdEVHaURvK2xDaWVVcy9lN3dGTG01?= =?utf-8?B?M2hhY0RELzNkL3B5UXpCRkxlVmJhZ2lDRENYYjhYR0M0NGxxM3ora095TkU1?= =?utf-8?B?Y2xVT2ZuM3VJYS8zN01HdThiMWlLenNiaVg0bUNOcFJNYVJwUVc1TXJyc1Jt?= =?utf-8?B?MHNSZ2Q0bmNRWWJ1TDdpbkU4TzFRZ0c3M1N5VDluaDlCcEFka296ZitVTGti?= =?utf-8?B?ZGppKy9aZEJJNWg3NitreGpSZTZOYkJSRktiMis3TEdNWmlIck5pVlJkRUFo?= =?utf-8?B?aCt6VjhDRXJPRHp5MzJKdzc1QkFobEFRZDY0SUFzbmZ2NHpYVVY0WmpXcGZE?= =?utf-8?B?NzN2bVV5WHA0K3FJQ2FObFdCam9qTkJkcnd1ZGtTSWhnRzNwd21TWjBCQzYr?= =?utf-8?B?TnE1MEswWEpkR25Ga0g1NWFuWFRFZGk2Sy9Mc3NXM2lrYWt6VDgzZjZ3QTY4?= =?utf-8?B?M01CaEF2bGtMRGROdTF2VitjaGt4ZDl1ZC9vT2czZ2tuSFcrRk51akJVVTZp?= =?utf-8?B?TlhLbTlOQXp3K0ZHSDlJamZCclZBNDdFNE11Q0lGamNuYWhWSk95SGJjZ25o?= =?utf-8?B?Z0tPZUlNQml0enZyWlJ1T1ZVZmlRamVITHhLM05EMStvUFd4L1RmcjMxRitQ?= =?utf-8?B?bkRUNWVOYmY5SFB6NUVXWnd6Tk05ZVZCRDVPQkpaVXpObkxId3duVkpoS1Ra?= =?utf-8?Q?22iyz+CAmXOV8ecqHtfC+dg86?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3f5398c-ccad-4c7d-c5cb-08db0e716772 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 09:54:03.5069 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uuumUztOxphGd+x70EfxU9rEjyFwQ+brEFCzXaDtK1PXCLRrLdfd/PCZVcFekgOeDtitlrWCZiuy9/2EMjnhMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7719 On 14.02.2023 09:56, Luca Fancellu wrote: > --- a/docs/misra/exclude-list.json > +++ b/docs/misra/exclude-list.json > @@ -1,4 +1,209 @@ > { > "version": "1.0", > - "content": [] > + "content": [ > + { > + "rel_path": "arch/arm/arm64/cpufeature.c" > + }, > + { > + "rel_path": "arch/arm/arm64/insn.c" > + }, > + { > + "rel_path": "arch/arm/arm64/lib/find_next_bit.c" > + }, > + { > + "rel_path": "arch/x86/acpi/boot.c" > + }, > + { > + "rel_path": "arch/x86/acpi/cpu_idle.c" > + }, > + { > + "rel_path": "arch/x86/acpi/cpufreq/cpufreq.c" > + }, > + { > + "rel_path": "arch/x86/acpi/cpuidle_menu.c" > + }, > + { > + "rel_path": "arch/x86/acpi/lib.c" > + }, > + { > + "rel_path": "arch/x86/acpi/power.c" > + }, > + { > + "rel_path": "arch/x86/cpu/amd.c" > + }, > + { > + "rel_path": "arch/x86/cpu/centaur.c" > + }, > + { > + "rel_path": "arch/x86/cpu/common.c" > + }, > + { > + "rel_path": "arch/x86/cpu/hygon.c" > + }, > + { > + "rel_path": "arch/x86/cpu/intel.c" > + }, > + { > + "rel_path": "arch/x86/cpu/intel_cacheinfo.c" > + }, > + { > + "rel_path": "arch/x86/cpu/mcheck/mce-apei.c" > + }, > + { > + "rel_path": "arch/x86/cpu/mcheck/non-fatal.c" > + }, > + { > + "rel_path": "arch/x86/cpu/mtrr/*" > + }, > + { > + "rel_path": "arch/x86/cpu/mwait-idle.c" > + }, > + { > + "rel_path": "arch/x86/delay.c" > + }, > + { > + "rel_path": "arch/x86/dmi_scan.c" > + }, > + { > + "rel_path": "arch/x86/domain.c" > + }, > + { > + "rel_path": "arch/x86/genapic/*" > + }, > + { > + "rel_path": "arch/x86/i387.c" > + }, > + { > + "rel_path": "arch/x86/irq.c" > + }, > + { > + "rel_path": "arch/x86/mpparse.c" > + }, > + { > + "rel_path": "arch/x86/srat.c" > + }, > + { > + "rel_path": "arch/x86/time.c" > + }, > + { > + "rel_path": "arch/x86/traps.c" > + }, > + { > + "rel_path": "arch/x86/usercopy.c" > + }, > + { > + "rel_path": "arch/x86/x86_64/mmconf-fam10h.c" > + }, > + { > + "rel_path": "common/bitmap.c" > + }, > + { > + "rel_path": "common/bunzip2.c" > + }, > + { > + "rel_path": "common/cpu.c" > + }, > + { > + "rel_path": "common/earlycpio.c" > + }, > + { > + "rel_path": "common/inflate.c" > + }, > + { > + "rel_path": "common/libfdt/*" > + }, > + { > + "rel_path": "common/lz4/decompress.c" > + }, > + { > + "rel_path": "common/notifier.c" > + }, > + { > + "rel_path": "common/radix-tree.c" > + }, > + { > + "rel_path": "common/rcupdate.c" > + }, > + { > + "rel_path": "common/softirq.c" > + }, > + { > + "rel_path": "common/tasklet.c" > + }, > + { > + "rel_path": "common/ubsan/ubsan.c" > + }, > + { > + "rel_path": "common/un*.c" > + }, > + { > + "rel_path": "common/vsprintf.c" > + }, > + { > + "rel_path": "common/xz/*" > + }, > + { > + "rel_path": "common/zstd/*" > + }, > + { > + "rel_path": "crypto/rijndael.c" > + }, > + { > + "rel_path": "crypto/vmac.c" > + }, > + { > + "rel_path": "drivers/acpi/apei/*" > + }, > + { > + "rel_path": "drivers/acpi/hwregs.c" > + }, > + { > + "rel_path": "drivers/acpi/numa.c" > + }, > + { > + "rel_path": "drivers/acpi/osl.c" > + }, > + { > + "rel_path": "drivers/acpi/reboot.c" > + }, > + { > + "rel_path": "drivers/acpi/tables.c" > + }, > + { > + "rel_path": "drivers/acpi/tables/*" > + }, > + { > + "rel_path": "drivers/acpi/utilities/*" > + }, > + { > + "rel_path": "drivers/char/ehci-dbgp.c" > + }, > + { > + "rel_path": "drivers/char/xhci-dbc.c" > + }, > + { > + "rel_path": "drivers/cpufreq/*" > + }, > + { > + "rel_path": "drivers/video/font_*" > + }, > + { > + "rel_path": "lib/list-sort.c" > + }, > + { > + "rel_path": "lib/mem*.c" > + }, > + { > + "rel_path": "lib/rbtree.c" > + }, > + { > + "rel_path": "lib/str*.c" > + }, > + { > + "rel_path": "lib/xxhash32.c" > + }, > + { > + "rel_path": "lib/xxhash64.c" > + } > + ] > } Patch 1's example has a "comment" field, which no entry makes use of. Without that, how does it become clear _why_ a particular file is to be excluded? The patch description here also doesn't provide any justification ... Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 09:56:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 09:56:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495094.765348 (Exim 4.92) (envelope-from ) id 1pRs36-00078t-W8; Tue, 14 Feb 2023 09:56:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495094.765348; Tue, 14 Feb 2023 09:56:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs36-00078m-TP; Tue, 14 Feb 2023 09:56:32 +0000 Received: by outflank-mailman (input) for mailman id 495094; Tue, 14 Feb 2023 09:56:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs35-00078g-Vu for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 09:56:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1b::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9a33e77-ac4d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 10:56:28 +0100 (CET) Received: from DBBPR09CA0018.eurprd09.prod.outlook.com (2603:10a6:10:c0::30) by PR3PR08MB5769.eurprd08.prod.outlook.com (2603:10a6:102:91::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Tue, 14 Feb 2023 09:56:26 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::d) by DBBPR09CA0018.outlook.office365.com (2603:10a6:10:c0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 09:56:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.10 via Frontend Transport; Tue, 14 Feb 2023 09:56:25 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Tue, 14 Feb 2023 09:56:25 +0000 Received: from 8b9d2537ff73.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3E004746-E40F-4A9F-A38D-F1DB895687B3.1; Tue, 14 Feb 2023 09:56:20 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b9d2537ff73.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Feb 2023 09:56:20 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com (2603:10a6:208:13c::21) by GV2PR08MB8271.eurprd08.prod.outlook.com (2603:10a6:150:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 09:56:18 +0000 Received: from AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab]) by AM0PR08MB4530.eurprd08.prod.outlook.com ([fe80::ee26:4b5e:4334:b7ab%3]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 09:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9a33e77-ac4d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/fQzjteEiTkhn2+cpSoHtQZJc5/cBvUUJ7nMFm4Hvf0=; b=VL7eJechbxU2dMvPARYMnDWsXYDniVHyuO9/oLr9jprp4oR0DU1Ba73jXUjv/+hpdQxPAX1J2RgNyyUCd+DWfNBDsgJ6+3rtNVlkwIhirosq3SWBbeI+q++7ZkhBvoS8A1JKarmQ2WCGVZnBLUcHLiiLK1aMxdlkaqw6vELjQx0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJ6/jNHpqZLplG3SE13qjVGMnatLO7g7724IKO7gD8fKAaxJM7YH9+PEPMnjcZ6okKckrYCzA85cCPY64v6wITiDgDVbiSm1JHWjoXqZ0UAIhLuZnqpHkVNnFdteHaeQy5nJRYUeIqdbdjcDDW+gEAHkk31aCBO/s6Tlv5g3+fgb7hIGElILUWFAOl/SQTLMt+Lq4gc5mp7UJI7mSUnG9ZKdQfM+91nc1cn8y2oDg2dZhfsE1T8WGv2h8wFxKhFWuYUlZkqZyWl7BV7Ud1FKXiGST11dY0UdvWo3jpNlkTHyninEypwNtMh/m26Vv9Wo2PZ8+Kw4S6J/aotdTpYd2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fQzjteEiTkhn2+cpSoHtQZJc5/cBvUUJ7nMFm4Hvf0=; b=LegI9zDYdQdikr+68Nu4c3Cfz2l9WkD1J5IdVuEDg+8zwK+3rrOgbSkzoPsoD3suucz0lu+iOnUjNF0towBf7kL0XFlIjcW4WR369TwSZvtO1KooXsesBqlSAgqs+EOmT1YmbFo9/PHXYyalrno5wEgllLHQPfGhIl6vqor4IRa9SBk1SIEg/Ss0Fd195s5vEvtLSIfKEffZNkeyTsK1vxePnFpj1h9/Ixyk7FmXrMou0fJ8GP+WhSENol0/yCSl3MTNyhOlo6KoPZSLVl0CghIXYpc7wJEFIO236tkkzvvV7Gq9P8UQRXTNYaaUIr5/sSJCMkDgUQjwAtbcwnOwDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/fQzjteEiTkhn2+cpSoHtQZJc5/cBvUUJ7nMFm4Hvf0=; b=VL7eJechbxU2dMvPARYMnDWsXYDniVHyuO9/oLr9jprp4oR0DU1Ba73jXUjv/+hpdQxPAX1J2RgNyyUCd+DWfNBDsgJ6+3rtNVlkwIhirosq3SWBbeI+q++7ZkhBvoS8A1JKarmQ2WCGVZnBLUcHLiiLK1aMxdlkaqw6vELjQx0= From: Penny Zheng To: Stewart Hildebrand , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Thread-Topic: [PATCH v1 01/13] xen/arm: re-arrange the static shared memory region Thread-Index: AQHY+J1fJT59o0hz5k65YJBzZn+QX67Ee7KAgAo99uA= Date: Tue, 14 Feb 2023 09:56:17 +0000 Message-ID: References: <20221115025235.1378931-1-Penny.Zheng@arm.com> <20221115025235.1378931-2-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8E856BD5C73E5649A4E5967F4DF198BC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM0PR08MB4530:EE_|GV2PR08MB8271:EE_|DBAEUR03FT057:EE_|PR3PR08MB5769:EE_ X-MS-Office365-Filtering-Correlation-Id: b5f9d3f4-afa2-4534-0c0b-08db0e71bc78 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: m9Zz62BpoZwlmmZOTa2+hKwElLHjRIFtY5uS0L7lbBfHDSepiKYdzervEggsqNLjlwSZrxOYd7s9UeJV60nVuy/A4Kt3CSQ7a1p7bbW8cFbnzFwV1qG1DjuLGzHmaLlOUYmSZzyZ2yinkMXubH2t4TCdiUTRLIcfyoOSn2DrGVb/u1cAJpUQ2XZfsYvoVrpJVwYrCIw3Z2ng5InT66HM3CCOQPipHSeUbzranVHunNiXLzz6xPuvfOBtjDPm8Tog8UjY/GXhTM+OuCTvSHfWlB63y/o/z0FMRanU6IZWFvJFiuoW+QqT7LfijXjPMh3RNH9xXZ1uSg9Wa9Md1N1jNGF0dARooobeaT4MA+qKeLwya8ZcJvEM+yb9UGkdJDnu1jftu8l7760d6TyrABxvcF1RTzEXVEmL2oYj2y4d0hnG7GSTeUPNyxmZy255Eh1E3m4MEUGko32e+1TqXoAAk5xCusPsCl7HHPdauAjiYhVRkCi23V9dwUiATWu2QXozkIbQXi7sd/diJX+8LYznfyvt4joQHAhqyAcsBaYNnRB0GOv4C4uWHAJ9CWRVLfqYHkDAIZV+KU9QO5Cg2bNgZue0EdP0vIZ9jHKT6eFdyF6qbaIXPJ+/BnSugsiYRddgjcRUUgEp35dim9EyB7aOiZ/gG1aDMr6a8pNaWV7NPwjPc4EMtYhhfwp9Ns0Nuu+b X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB4530.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(451199018)(83380400001)(54906003)(110136005)(76116006)(316002)(5660300002)(8936002)(52536014)(8676002)(66446008)(66946007)(41300700001)(4326008)(66476007)(64756008)(66556008)(6506007)(53546011)(9686003)(186003)(26005)(966005)(71200400001)(478600001)(38070700005)(55016003)(86362001)(33656002)(2906002)(122000001)(38100700002)(66899018)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8271 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 55f2ea14-af83-4c18-2ca9-08db0e71b769 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jFi9VyblO6vCJWx8NtEw2HXyZ68pa0rud8QWnRPXT/Jo26qwZZF5uZ+4OvzOrNxDgF0AWqEwPBwmUKWK82UkXhL10Kgenm+Uuc67d0Jm0cilYwlMMY+FP6BS2SeAc3M02SR4mOLeN5gmpirUHpCaFFnY0fAo9ucraNQarjSoizBDLvdh8Z+h5N2BLAMqiVA71kxXQk5jXqqZgPPS+U/OY5bOflI+wefpJb6yJs9SuC6q0ZVul9dO9yhl+NKo/VxUdE+X0qAn0F5g/xrzgILjiy4vnR67z2mdtZKHsQho2FDZAZLJhNQC+N0beytJw3KAhdp55A7y958AQKZCF9VQtCo6Y2VJp/xCT3NRlangEOS1cglWiaIQgsqtJmQxTwul63qSlghw6rfErtMRH5vyYLg/zXGZtQBZBgECYC9OiYZUE5jPF9+qnRi03wOU1gAZMtCzWK9/pUI95Lm/N0iUSMHd8RZ0O3NlrVfC/NMH5C5sd32bSuHFnCtQAjdyihdxWCW4h3NaW0ieSCSXako6aSrBHrOEhUrCyqz4jxfVyEMAu2kRjFcUHQZ6HGX8pdcyT/WzMoJoU7Y3Xc4ISLt31zlXnvD7qQvwmjHmotB5owa21Tg3Ys36uV0UNPFjudL/h5iMgj/ETO4F5BI2VtDK3fPOVYfPS0eyzFOCk63YlkoonA8ez9ddQpZjMYQSqi+8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199018)(36840700001)(40470700004)(46966006)(7696005)(33656002)(36860700001)(9686003)(966005)(2906002)(186003)(478600001)(53546011)(55016003)(26005)(6506007)(336012)(47076005)(40460700003)(83380400001)(107886003)(40480700001)(41300700001)(52536014)(316002)(70206006)(86362001)(8676002)(8936002)(70586007)(4326008)(81166007)(110136005)(82740400003)(66899018)(356005)(54906003)(5660300002)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 09:56:25.9134 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5f9d3f4-afa2-4534-0c0b-08db0e71bc78 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5769 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGV3YXJ0IEhpbGRlYnJhbmQg PHN0ZXdhcnQuaGlsZGVicmFuZEBhbWQuY29tPg0KPiBTZW50OiBXZWRuZXNkYXksIEZlYnJ1YXJ5 IDgsIDIwMjMgNDo1NSBBTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+ OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hl bkBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn PjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJl cnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+IDxWb2xvZHlteXJf QmFiY2h1a0BlcGFtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MSAwMS8xM10geGVuL2Fy bTogcmUtYXJyYW5nZSB0aGUgc3RhdGljIHNoYXJlZCBtZW1vcnkNCj4gcmVnaW9uDQo+IA0KPiBI aSBQZW5ueSwNCj4NCg0KSGksIFN0ZXdhcnQNCg0KU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNl LCBnb3Qgc2lkZXRyYWNrZWQgYnkgYSBmZXcgaW50ZXJuYWwgcHJvamVjdHMNCiAgDQo+IE9uIDEx LzE0LzIyIDIxOjUyLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiAuLi4NCj4gPiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL3NldHVwLmgNCj4gPiBiL3hlbi9hcmNoL2FybS9p bmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gaW5kZXggZmRiZjY4YWFkYy4uMmQ0YWUwZjAwYSAxMDA2 NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc2V0dXAuaA0KPiA+ICsrKyBi L3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zZXR1cC5oDQo+ID4gQEAgLTUwLDEwICs1MCw2IEBA IHN0cnVjdCBtZW1iYW5rIHsNCj4gPiAgICAgIHBhZGRyX3Qgc3RhcnQ7DQo+ID4gICAgICBwYWRk cl90IHNpemU7DQo+ID4gICAgICBlbnVtIG1lbWJhbmtfdHlwZSB0eXBlOw0KPiA+IC0jaWZkZWYg Q09ORklHX1NUQVRJQ19TSE0NCj4gPiAtICAgIGNoYXIgc2htX2lkW01BWF9TSE1fSURfTEVOR1RI XTsNCj4gPiAtICAgIHVuc2lnbmVkIGludCBucl9zaG1fYm9ycm93ZXJzOw0KPiA+IC0jZW5kaWYN Cj4gPiAgfTsNCj4gPg0KPiA+ICBzdHJ1Y3QgbWVtaW5mbyB7DQo+ID4gQEAgLTYxLDYgKzU3LDE3 IEBAIHN0cnVjdCBtZW1pbmZvIHsNCj4gPiAgICAgIHN0cnVjdCBtZW1iYW5rIGJhbmtbTlJfTUVN X0JBTktTXTsgIH07DQo+ID4NCj4gPiArc3RydWN0IHNobV9tZW1iYW5rIHsNCj4gPiArICAgIGNo YXIgc2htX2lkW01BWF9TSE1fSURfTEVOR1RIXTsNCj4gPiArICAgIHVuc2lnbmVkIGludCBucl9z aG1fYm9ycm93ZXJzOw0KPiA+ICsgICAgc3RydWN0IG1lbWJhbmsgKm1lbWJhbms7DQo+ID4gK307 DQo+ID4gKw0KPiA+ICtzdHJ1Y3Qgc2htX21lbWluZm8gew0KPiA+ICsgICAgdW5zaWduZWQgaW50 IG5yX2JhbmtzOw0KPiA+ICsgICAgc3RydWN0IHNobV9tZW1iYW5rIGJhbmtbTlJfTUVNX0JBTktT XTsgfTsNCj4gPiArDQo+ID4gIC8qDQo+ID4gICAqIFRoZSBkb21VIGZsYWcgaXMgc2V0IGZvciBr ZXJuZWxzIGFuZCByYW1kaXNrcyBvZiAieGVuLGRvbWFpbiIgbm9kZXMuDQo+ID4gICAqIFRoZSBw dXJwb3NlIG9mIHRoZSBkb21VIGZsYWcgaXMgdG8gYXZvaWQgZ2V0dGluZyBjb25mdXNlZCBpbiBA QA0KPiA+IC0xMDUsNiArMTEyLDcgQEAgc3RydWN0IGJvb3RpbmZvIHsNCj4gPiAgICAgIHN0cnVj dCBtZW1pbmZvIGFjcGk7DQo+ID4gICNlbmRpZg0KPiA+ICAgICAgYm9vbCBzdGF0aWNfaGVhcDsN Cj4gPiArICAgIHN0cnVjdCBzaG1fbWVtaW5mbyBzaG1fbWVtOw0KPiA+ICB9Ow0KPiA+DQo+ID4g IHN0cnVjdCBtYXBfcmFuZ2VfZGF0YQ0KPiANCj4gVGhlIHJlZHVjdGlvbiBpbiB0aGUgc2l6ZW9m IHN0cnVjdCBtZW1iYW5rIGlzIGEgd2VsY29tZSBpbXByb3ZlbWVudCwgaW4NCj4gbXkgb3Bpbmlv biwgYmVjYXVzZSBpdCBpcyBtdWx0aXBsaWVkIGJ5IE5SX01FTV9CQU5LUywgYW5kIElJUkMgd2Ug b25seQ0KPiBoYXZlIDMyayBvZiBib290IHN0YWNrIHRvIHBsYXkgd2l0aC4NCj4gDQo+IEJlZm9y ZSB0aGlzIHBhdGNoOg0KPiBzaXplb2Yoc3RydWN0IGtlcm5lbF9pbmZvKTogMjA2NDgNCj4gc2l6 ZW9mKHN0cnVjdCBtZW1pbmZvKTogMTAyNDgNCj4gc2l6ZW9mKHN0cnVjdCBzaG1fbWVtaW5mbyk6 IDEwMjQ4DQo+IA0KPiBXaGVuIGJ1aWxkaW5nIHdpdGggRVhUUkFfQ0ZMQUdTX1hFTl9DT1JFPSJX c3RhY2stdXNhZ2U9NDA5NiAtV25vLQ0KPiBlcnJvcj1zdGFjay11c2FnZT0iOg0KDQpMZWFybnQh IFRoeCENCg0KPiBhcmNoL2FybS9kb21haW5fYnVpbGQuYzogSW4gZnVuY3Rpb24g4oCYY29uc3Ry dWN0X2RvbVXigJk6DQo+IGFyY2gvYXJtL2RvbWFpbl9idWlsZC5jOjM3NDc6MTk6IHdhcm5pbmc6 IHN0YWNrIHVzYWdlIGlzIDIwNzIwIGJ5dGVzIFstDQo+IFdzdGFjay11c2FnZT1dDQo+ICAzNzQ3 IHwgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbVUoc3RydWN0IGRvbWFpbiAqZCwNCj4g ICAgICAgfCAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fg0KPiBhcmNoL2FybS9kb21h aW5fYnVpbGQuYzogSW4gZnVuY3Rpb24g4oCYY29uc3RydWN0X2RvbTDigJk6DQo+IGFyY2gvYXJt L2RvbWFpbl9idWlsZC5jOjM5Nzk6MTk6IHdhcm5pbmc6IHN0YWNrIHVzYWdlIGlzIDIwNjg4IGJ5 dGVzIFstDQo+IFdzdGFjay11c2FnZT1dDQo+ICAzOTc5IHwgc3RhdGljIGludCBfX2luaXQgY29u c3RydWN0X2RvbTAoc3RydWN0IGRvbWFpbiAqZCkNCj4gICAgICAgfCAgICAgICAgICAgICAgICAg ICBefn5+fn5+fn5+fn5+fg0KPiANCj4gDQo+IA0KPiBBZnRlciB0aGlzIHBhdGNoOg0KPiBzaXpl b2Yoc3RydWN0IGtlcm5lbF9pbmZvKTogMTQ1MDQNCj4gc2l6ZW9mKHN0cnVjdCBtZW1pbmZvKTog NjE1Mg0KPiBzaXplb2Yoc3RydWN0IHNobV9tZW1pbmZvKTogODIwMA0KPiANCj4gYXJjaC9hcm0v ZG9tYWluX2J1aWxkLmM6IEluIGZ1bmN0aW9uIOKAmGNvbnN0cnVjdF9kb21V4oCZOg0KPiBhcmNo L2FybS9kb21haW5fYnVpbGQuYzozNzU0OjE5OiB3YXJuaW5nOiBzdGFjayB1c2FnZSBpcyAxNDU3 NiBieXRlcyBbLQ0KPiBXc3RhY2stdXNhZ2U9XQ0KPiAgMzc1NCB8IHN0YXRpYyBpbnQgX19pbml0 IGNvbnN0cnVjdF9kb21VKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgIHwgICAgICAgICAgICAg ICAgICAgXn5+fn5+fn5+fn5+fn4NCj4gYXJjaC9hcm0vZG9tYWluX2J1aWxkLmM6IEluIGZ1bmN0 aW9uIOKAmGNvbnN0cnVjdF9kb20w4oCZOg0KPiBhcmNoL2FybS9kb21haW5fYnVpbGQuYzozOTg2 OjE5OiB3YXJuaW5nOiBzdGFjayB1c2FnZSBpcyAxNDU0NCBieXRlcyBbLQ0KPiBXc3RhY2stdXNh Z2U9XQ0KPiAgMzk4NiB8IHN0YXRpYyBpbnQgX19pbml0IGNvbnN0cnVjdF9kb20wKHN0cnVjdCBk b21haW4gKmQpDQo+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn4NCj4g DQo+IEEgbGF0ZXIgcGF0Y2ggaW4gdGhpcyBzZXJpZXMgd2lsbCBpbmNyZWFzZSBpdCBhZ2FpbiBz bGlnaHRseS4gTm90ZSB0aGF0IEknbSBub3QNCj4gZXhwZWN0aW5nIHRoaXMgc2VyaWVzIHRvIGFk ZHJlc3MgdGhlc2UgcGFydGljdWxhciB3YXJuaW5ncywgSSdtIG1lcmVseQ0KPiBwb2ludGluZyBv dXQgdGhlIChwb3NpdGl2ZSkgaW1wYWN0IG9mIHRoZSBjaGFuZ2UuDQoNCkkgYWdyZWVkIHRoYXQg TlJfTUVNX0JBTktTIGNvdWxkIGJlIGEgbGFyZ2UgbXVsdGlwbGllciwgYW5kIGlmIHdlIG1ha2UN CiJzdHJ1Y3Qgc2htX21lbWluZm8iIGxpa2UgInN0cnVjdCBtZW1pbmZvIiwgdG8gaGF2ZSBhIGFy cmF5IG9mIE5SX01FTV9CQU5LUw0KaXRlbXMsIGl0IHdpbGwgbWFrZSBYZW4gYmluYXJ5IGV4Y2Vl ZCAyME1CLi4uIFdlIGhhdmUgZGlzY3Vzc2VkIGl0IGhlcmVbMV0uDQoNCkhvd2V2ZXIsIEknbSBh ZnJhaWQgdGhhdCBkeW5hbWljIGFsbG9jYXRpb24gaXMgYWxzbyBub3QgYSBwcmVmZXJyZWQgb3B0 aW9uIGhlcmUsDQp3aGVyZSB0byBmcmVlIHRoZSBkYXRhIGNvdWxkIGJlIGEgcHJvYmxlbS4NClNv IGluIG5leHQgc2VyaWUsIHdoaWNoIHdpbGwgY29tZSB2ZXJ5IHNvb24sIEknbGwgaW50cm9kdWNl Og0KYGBgDQojZGVmaW5lIE5SX1NITV9CQU5LUyAxNg0KDQovKg0KICogQSBzdGF0aWMgc2hhcmVk IG1lbW9yeSBub2RlIGNvdWxkIGJlIGJhbmtlZCB3aXRoIGEgc3RhdGljYWxseQ0KICogY29uZmln dXJlZCBob3N0IG1lbW9yeSBiYW5rLCBvciBhIHNldCBvZiBhcmJpdHJhcnkgaG9zdCBtZW1vcnkN CiAqIGJhbmtzIGFsbG9jYXRlZCBmcm9tIGhlYXAuDQogKi8NCnN0cnVjdCBzaG1fbWVtaW5mbyB7 DQogICAgdW5zaWduZWQgaW50IG5yX2JhbmtzOw0KICAgIHN0cnVjdCBtZW1iYW5rIGJhbmtbTlJf U0hNX0JBTktTXTsNCiAgICBwYWRkcl90IHRvdF9zaXplOw0KfTsNCmBgYA0KVGFraW5nIHlvdXIg cHJldmlvdXMgaW5zdHJ1Y3Rpb25zLCBjb21waWxpbmcgd2l0aCAiRVhUUkFfQ0ZMQUdTX1hFTl9D T1JFPSItV3N0YWNrLXVzYWdlPTQwOTYgLVduby1lcnJvcj1zdGFjay11c2FnZT0iLA0KYm9vdCBz dGFjayB1c2FnZSBmb3IgImNvbnN0cnVjdF9kb21VIiBhbmQgIiBjb25zdHJ1Y3RfZG9tMCIgd2ls bCBiZSBsaWtlOg0KIg0KYXJjaC9hcm0vZG9tYWluX2J1aWxkLmM6IEluIGZ1bmN0aW9uIOKAmGNv bnN0cnVjdF9kb21V4oCZOg0KYXJjaC9hcm0vZG9tYWluX2J1aWxkLmM6NDEyNzoxOTogd2Fybmlu Zzogc3RhY2sgdXNhZ2UgaXMgMTY4MDAgYnl0ZXMgWy1Xc3RhY2stdXNhZ2U9XQ0KIDQxMjcgfCBz dGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tVShzdHJ1Y3QgZG9tYWluICpkLA0KICAgICAg fCAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fg0KYXJjaC9hcm0vZG9tYWluX2J1aWxk LmM6IEluIGZ1bmN0aW9uIOKAmGNvbnN0cnVjdF9kb20w4oCZOg0KYXJjaC9hcm0vZG9tYWluX2J1 aWxkLmM6NDM1OToxOTogd2FybmluZzogc3RhY2sgdXNhZ2UgaXMgMTY2NDAgYnl0ZXMgWy1Xc3Rh Y2stdXNhZ2U9XQ0KIDQzNTkgfCBzdGF0aWMgaW50IF9faW5pdCBjb25zdHJ1Y3RfZG9tMChzdHJ1 Y3QgZG9tYWluICpkKQ0KICAgICAgfCAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fg0K Ig0KWzFdIGh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2 ZWwvMjAyMy0wMS9tc2cwMDQ0OS5odG1sDQoNCkNoZWVycywNCg0KLS0tDQpQZW5ueSBaaGVuZw0K From xen-devel-bounces@lists.xenproject.org Tue Feb 14 10:03:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 10:03:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495103.765359 (Exim 4.92) (envelope-from ) id 1pRs9M-0000VA-Q0; Tue, 14 Feb 2023 10:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495103.765359; Tue, 14 Feb 2023 10:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs9M-0000V3-NG; Tue, 14 Feb 2023 10:03:00 +0000 Received: by outflank-mailman (input) for mailman id 495103; Tue, 14 Feb 2023 10:02:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRs9L-0000Ux-7V for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 10:02:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c150f698-ac4e-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 11:02:57 +0100 (CET) Received: from AM5PR0701CA0017.eurprd07.prod.outlook.com (2603:10a6:203:51::27) by AM9PR08MB6067.eurprd08.prod.outlook.com (2603:10a6:20b:287::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 10:02:27 +0000 Received: from AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::17) by AM5PR0701CA0017.outlook.office365.com (2603:10a6:203:51::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.9 via Frontend Transport; Tue, 14 Feb 2023 10:02:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT013.mail.protection.outlook.com (100.127.140.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 10:02:26 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Tue, 14 Feb 2023 10:02:26 +0000 Received: from dada6411ca7b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD08B0A1-3EB7-441F-8E2B-CC67B17C3536.1; Tue, 14 Feb 2023 10:02:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dada6411ca7b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Feb 2023 10:02:19 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GVXPR08MB7797.eurprd08.prod.outlook.com (2603:10a6:150:5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 10:02:14 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a%4]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 10:02:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c150f698-ac4e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IWHrjZzJLOijSsGjJVv30G49BiGBRquzjp/IqgRSwck=; b=mk2AZKmOcm3h7TfCiJbqO5Nd7iw06ed7u+6UwxSKZnUHJVpLliwR3GXjyZIhvnkqasNPxV21laoKjxrCb5yoaY0dMK6b49x7a+5TSojOdtX5KB5g2qFdT07CI/N7Sl+swMzYotIIzK6pB9xy/jdVUkTv34cfqzniwwP2+tuMEec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b1d8723a0712cd24 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxQw1KU0CEQgEUhsMYmdsvzSihGT6qrcc5gCJP8EssbDRNYTvVGKODU1Whr7XCxEydBwrXOHx/ylEvG2ijFpzNXysGdKH+noMV46RZFM1JHJYSbowSVOujbHNpQtWUFoGYW7+ki48cw7VmLBS3ht/yT/VPYufVwQJVb99HnwV6cBv4dcHfxbiQuBOg4n1kzEAl67ukApBvQ3hT0ekTc6gMoxoOin1M13GCYLFDuHlFhOCPRGJEkl83QTzmbQ/lAuKUP1FCQH6XnyL8B6Dvo/MDKJ52klY1jOmOID3XOj77cQyzkkgrOFKceuNhCkmpdUaaRjSItsTxydRA/9hTvfqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IWHrjZzJLOijSsGjJVv30G49BiGBRquzjp/IqgRSwck=; b=YY3eC8SWlaA2RH21JGzIGoGvsgIRFUuzwRJPSQaDUtsF1KR4PigE7EaSzGezjwN1Ooi/OIV1ZmAstVELIYajCV9CMhenDZF9UkWLcqUJ4yuYxLsn5TE945ZHleojOiFcAvg3bKLaSwg31UAU1A+tjGQjD8QDhZVGVfXQE2osGtW31ibkaFn44CgYgnPWax9MetPe0wNPsSrUL89I3TMKufyhNppPG8umjBOyyGL8ZYWX9KmqRo1WT76ZjZPO93S9sOnjtK5SXYA6GtpSGhFWyCORj4+d2yAumgOtiDt6E5MqxLQjWD02sRnBiSAA8JvlSqFfX8ounXVF2T9lbtChgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IWHrjZzJLOijSsGjJVv30G49BiGBRquzjp/IqgRSwck=; b=mk2AZKmOcm3h7TfCiJbqO5Nd7iw06ed7u+6UwxSKZnUHJVpLliwR3GXjyZIhvnkqasNPxV21laoKjxrCb5yoaY0dMK6b49x7a+5TSojOdtX5KB5g2qFdT07CI/N7Sl+swMzYotIIzK6pB9xy/jdVUkTv34cfqzniwwP2+tuMEec= From: Luca Fancellu To: Jan Beulich CC: Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/2] xen/cppcheck: add a way to exclude files from the scan Thread-Topic: [PATCH 1/2] xen/cppcheck: add a way to exclude files from the scan Thread-Index: AQHZQFJldh/RodYIGE6PF+KtzbPV1a7OMzSAgAAC6wA= Date: Tue, 14 Feb 2023 10:02:13 +0000 Message-ID: References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-2-luca.fancellu@arm.com> <4d86325f-8706-98d1-c233-963fd42076fa@suse.com> In-Reply-To: <4d86325f-8706-98d1-c233-963fd42076fa@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GVXPR08MB7797:EE_|AM7EUR03FT013:EE_|AM9PR08MB6067:EE_ X-MS-Office365-Filtering-Correlation-Id: 0132e4ab-16b2-4868-0a81-08db0e729399 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UVJXn495K/M8nTu2dbDvExx1e746KDTrNJWixYmLToxfOl1M7OUyUpjaLBu7PmZ8Yr4G++wyOleTZgoIUI18yleHqibG2WNKMYhwjsrjbHjFj4N0T2kteLgtCAx7lJ9lGtCym7PDpZ4qWJSCIbWepdMgj5akYmKm3SgqZtpA5StliaTdZc3AiWQi1fOFvigZlCVCjKpg2VS1zRg5hq93slularRa2rTJoawPwwTS82NqvO20aCxCJoLkonZS2RJtac3ZKE/9WINMwxesUVYTJJtG+wZUyoYgko7WqLja5iShOkvxXQQp3j9FgAiBXU+Sh7ZUIdng/Zvt/tIXDDtUDEvpvBPI6qXqt8PrkEmWNo4vaqUg6tmN8KPbDTsrb01qAh0RAvGMji2fpgBriIoKaBlmrfsG5LmMYHAwUmdxcZJtamwyp2smaLlN0FA4P/cEY0G28FqCbcoyfFRwdFYmlbIKSGltC4QzI2dp6z5aZ+/LPZFX0PIC36gpLzoTos/9i8Fg1hXTsxxC9gb+fGdlHAC+JYE5omqvKsf83O+niD9pTUBgwkaVlvwnLZnmAkhOqZIxFWCSeAPSz4AfCjd5nqYCP2ImFIlOIojxmMR9/6X0/oQF5VetOLIUiV6rdIzhmaHahvMna2lGzAZtmn0uaoSa+mNstsAoQlMdC5T4k3NjY7aGpBhUdj5kKf1rkuHfoX6ZJ9FGSO+siXKmuLOL32kSATLmmC9XYnDDkwFS5xflr1s+ZFkO+2GG1rfy57Bi X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199018)(66899018)(83380400001)(53546011)(6506007)(71200400001)(33656002)(36756003)(2906002)(38070700005)(38100700002)(54906003)(478600001)(4326008)(2616005)(8676002)(66476007)(66446008)(64756008)(6916009)(41300700001)(66556008)(6486002)(26005)(6512007)(186003)(66946007)(5660300002)(8936002)(122000001)(316002)(91956017)(86362001)(76116006)(43043002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <06F17D08E5EAD94891893ACAF49B812E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7797 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d511fe1a-2014-45ce-6784-08db0e728bc4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8ySuhFf/NIefLSkZyuWXcuMu9z1OptZM6dBsjxQwp1ceCF0NC+tRj728GqfA7ij+scjFuh3HUSK9YrTEKB/2wILQ8ZzgSxrlCPvYOiEftUCEwePg3EI6hKQtiRTxVrvY5LzheBDP0PNYkf7IphfSxGPOecVU3YtGMQnp93TEvIMbdC61XCl6yiEk2lPKYdWPZC4FFpNz6EEOIeAL2DAIsj8bxkviGPQkLmTrVGsxbFu/zz16QXLvI9YGli3fUS28lEew2t1QpGAsDOhKZEjif5fe+DU07HtF6zb6lYsjVCCv9zr4bXYQp6r6XLf5KoPZ6Ep62g+hKLkIwzGgEWECrhfOlKnLtNONVJ24L45NaEtiNDcr8Vc+6C+v1kD1u51z/6mQPgZp/RcHFqzKbH0qDZRnQv/AxHaJEIlA9HO7B0Sxmeb2jAbyQxgdnojRJG4bccCk2lTqZ5kh9mzl3JEPzVY/8PmBE/6VQklbVpB4OQO1o1YVxeNuJU2rjD6meFnBwmk3Wo0vwj/rWgSURwtInfkneTylfJH5ELZLSq9kFLVZYtbKP9XdADq8LC5mE7jlO5H/JnRBAiwQKUvavDLS6O2UUQsxU3rGb/Z9ZgnDBQcVxERxgzG5JheE93yWQtx9Y/ruVwsY6yNsrjZS94w2i1SgyRnYYNJNwos1uuYNuNYiRlsclgpl992UH+2QWkBsnClolaFgXF8+Ur6v4zdft2N3PCc2jJEbOIAdw1adlf8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199018)(40470700004)(36840700001)(46966006)(478600001)(356005)(33656002)(36756003)(40480700001)(40460700003)(82310400005)(86362001)(336012)(2616005)(316002)(83380400001)(54906003)(6506007)(53546011)(47076005)(6512007)(186003)(26005)(6486002)(8936002)(6862004)(66899018)(2906002)(5660300002)(82740400003)(36860700001)(70586007)(8676002)(70206006)(81166007)(4326008)(41300700001)(43043002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 10:02:26.7617 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0132e4ab-16b2-4868-0a81-08db0e729399 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6067 DQoNCj4gT24gMTQgRmViIDIwMjMsIGF0IDA5OjUxLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTQuMDIuMjAyMyAwOTo1NiwgTHVjYSBGYW5jZWxsdSB3 cm90ZToNCj4+IEFkZCBhIHdheSB0byBleGNsdWRlIGZpbGVzIGZyb20gdGhlIHNjYW4sIGluIHRo aXMgd2F5IHdlIGNhbiBza2lwDQo+PiBzb21lIGZpbmRpbmdzIGZyb20gdGhlIHJlcG9ydCBvbiB0 aG9zZSBmaWxlcyB0aGF0IFhlbiBkb2Vzbid0IG93bi4NCj4+IA0KPj4gVG8gZG8gdGhhdCwgaW50 cm9kdWNlIHRoZSBleGNsdWRlLWxpc3QuanNvbiBmaWxlIHVuZGVyIGRvY3MvbWlzcmEsDQo+PiB0 aGlzIGZpbGUgd2lsbCBiZSBwb3B1bGF0ZWQgd2l0aCByZWxhdGl2ZSBwYXRoIHRvIHRoZSBmaWxl cy9mb2xkZXINCj4+IHRvIGJlIGV4Y2x1ZGVkLg0KPj4gSW50cm9kdWNlIGEgbmV3IG1vZHVsZSwg ZXhjbHVzaW9uX2ZpbGVfbGlzdC5weSwgdG8gZGVhbCB3aXRoIHRoZQ0KPj4gZXhjbHVzaW9uIGxp c3QgZmlsZSBhbmQgdXNlIHRoZSBuZXcgbW9kdWxlIGluIGNwcGNoZWNrX2FuYWx5c2lzLnB5DQo+ PiB0byB0YWtlIGEgbGlzdCBvZiBleGNsdWRlZCBwYXRocyB0byB1cGRhdGUgdGhlIHN1cHByZXNz aW9uIGxpc3Qgb2YNCj4+IGNwcGNoZWNrLg0KPj4gTW9kaWZpZWQgLS1zdXBwcmVzcyBmbGFnIGZv ciBjcHBjaGVjayB0b29sIHRvIHJlbW92ZQ0KPj4gdW5tYXRjaGVkU3VwcHJlc3Npb24gZmluZGlu Z3MgZm9yIHRob3NlIGV4dGVybmFsIGZpbGUgdGhhdCBhcmUNCj4+IGxpc3RlZCBidXQgZm9yIGV4 YW1wbGUgbm90IGJ1aWx0IGZvciB0aGUgY3VycmVudCBhcmNoaXRlY3R1cmUuDQo+PiANCj4+IEFk ZCBkb2N1bWVudGF0aW9uIGZvciB0aGUgZmlsZS4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogTHVj YSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KPj4gLS0tDQo+PiBkb2NzL21pc3Jh L2V4Y2x1ZGUtbGlzdC5qc29uICAgICAgICAgICAgICAgICAgfCAgNCArDQo+PiBkb2NzL21pc3Jh L2V4Y2x1ZGUtbGlzdC5yc3QgICAgICAgICAgICAgICAgICAgfCA0NCArKysrKysrKysrKw0KPj4g eGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2NwcGNoZWNrX2FuYWx5c2lzLnB5IHwgMjEgKysrKy0N Cj4+IC4uLi94ZW5fYW5hbHlzaXMvZXhjbHVzaW9uX2ZpbGVfbGlzdC5weSAgICAgICB8IDc5ICsr KysrKysrKysrKysrKysrKysNCj4+IDQgZmlsZXMgY2hhbmdlZCwgMTQ2IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgZG9jcy9taXNyYS9leGNsdWRl LWxpc3QuanNvbg0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0IGRvY3MvbWlzcmEvZXhjbHVkZS1saXN0 LnJzdA0KPj4gY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9zY3JpcHRzL3hlbl9hbmFseXNpcy9leGNs dXNpb25fZmlsZV9saXN0LnB5DQo+IA0KPiBBcyBJIHRoaW5rIEkgaGF2ZSBhc2tlZCBmb3IgYmVm b3JlOiBDYW4gbmV3IGZpbGVzIHBsZWFzZSBhdm9pZCB1bmRlcnNjb3Jlcw0KPiBpbiB0aGVpciBu YW1lcywgd2hlbiBkYXNoZXMgZG8gcXVpdGUgZmluZT8gT3IgZG9lcyBQeXRob24gaGF2ZSBzcGVj aWFsDQo+IHJlc3RyaWN0aW9ucz8NCg0KRnJvbSB0aGUgcHl0aG9uIGNvZGluZyBzdHlsZToNCg0K TW9kdWxlcyBzaG91bGQgaGF2ZSBzaG9ydCwgYWxsLWxvd2VyY2FzZSBuYW1lcy4gVW5kZXJzY29y ZXMgY2FuIGJlIHVzZWQgaW4NCnRoZSBtb2R1bGUgbmFtZSBpZiBpdCBpbXByb3ZlcyByZWFkYWJp bGl0eS4gUHl0aG9uIHBhY2thZ2VzIHNob3VsZCBhbHNvIGhhdmUNCnNob3J0LCBhbGwtbG93ZXJj YXNlIG5hbWVzLCBhbHRob3VnaCB0aGUgdXNlIG9mIHVuZGVyc2NvcmVzIGlzIGRpc2NvdXJhZ2Vk Lg0KDQpJbiB0aGlzIGNhc2UgSSB0aGluayBpdCBpbXByb3ZlcyByZWFkYWJpbGl0eQ0KDQo+IA0K Pj4gLS0tIGEveGVuL3NjcmlwdHMveGVuX2FuYWx5c2lzL2NwcGNoZWNrX2FuYWx5c2lzLnB5DQo+ PiArKysgYi94ZW4vc2NyaXB0cy94ZW5fYW5hbHlzaXMvY3BwY2hlY2tfYW5hbHlzaXMucHkNCj4+ IEBAIC0xLDcgKzEsOCBAQA0KPj4gIyEvdXNyL2Jpbi9lbnYgcHl0aG9uMw0KPj4gDQo+PiBpbXBv cnQgb3MsIHJlLCBzaHV0aWwNCj4+IC1mcm9tIC4gaW1wb3J0IHNldHRpbmdzLCB1dGlscywgY3Bw Y2hlY2tfcmVwb3J0X3V0aWxzDQo+PiArZnJvbSAuIGltcG9ydCBzZXR0aW5ncywgdXRpbHMsIGNw cGNoZWNrX3JlcG9ydF91dGlscywgZXhjbHVzaW9uX2ZpbGVfbGlzdA0KPj4gK2Zyb20gLmV4Y2x1 c2lvbl9maWxlX2xpc3QgaW1wb3J0IEV4Y2x1c2lvbkZpbGVMaXN0RXJyb3INCj4+IA0KPj4gY2xh c3MgR2V0TWFrZVZhcnNQaGFzZUVycm9yKEV4Y2VwdGlvbik6DQo+PiAgICAgcGFzcw0KPj4gQEAg LTUwLDYgKzUxLDIyIEBAIGRlZiBfX2dlbmVyYXRlX3N1cHByZXNzaW9uX2xpc3Qob3V0X2ZpbGUp Og0KPj4gICAgICAgICAgICAgIyBoZWFkZXIgZm9yIGNwcGNoZWNrDQo+PiAgICAgICAgICAgICBz dXBwbGlzdF9maWxlLndyaXRlKCIqOipnZW5lcmF0ZWQvY29tcGlsZXItZGVmLmhcbiIpDQo+PiAN Cj4+ICsgICAgICAgICAgICB0cnk6DQo+PiArICAgICAgICAgICAgICAgIGV4Y2x1c2lvbl9maWxl ID0gXA0KPj4gKyAgICAgICAgICAgICAgICAgICAgInt9L2RvY3MvbWlzcmEvZXhjbHVkZS1saXN0 Lmpzb24iLmZvcm1hdChzZXR0aW5ncy5yZXBvX2RpcikNCj4+ICsgICAgICAgICAgICAgICAgZXhj bHVzaW9uX2xpc3QgPSBcDQo+PiArICAgICAgICAgICAgICAgICAgICBleGNsdXNpb25fZmlsZV9s aXN0LmxvYWRfZXhjbHVzaW9uX2ZpbGVfbGlzdChleGNsdXNpb25fZmlsZSkNCj4+ICsgICAgICAg ICAgICBleGNlcHQgRXhjbHVzaW9uRmlsZUxpc3RFcnJvciBhcyBlOg0KPj4gKyAgICAgICAgICAg ICAgICAgICAgcmFpc2UgQ3BwY2hlY2tEZXBzUGhhc2VFcnJvcigNCj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIklzc3VlIHdpdGggcmVhZGluZyBmaWxlIHt9OiB7fSINCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC5mb3JtYXQoZXhjbHVzaW9uX2ZpbGUsIGUpDQo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICApDQo+IA0KPiBNeSBQeXRob24gaXNuJ3QgdmVy eSBnb29kLCBidXQgaXNuJ3QgaW5kZW50YXRpb24gb25lIGxldmVsIHRvbyBkZWVwDQo+IGhlcmU/ DQoNCkdvb2QgY2F0Y2gsIEnigJlsbCBmaXggaXQNCg0KPiANCj4gSmFuDQoNCg0K From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:01:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495123.765371 (Exim 4.92) (envelope-from ) id 1pRt3z-0007of-5Z; Tue, 14 Feb 2023 11:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495123.765371; Tue, 14 Feb 2023 11:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRt3z-0007oY-2g; Tue, 14 Feb 2023 11:01:31 +0000 Received: by outflank-mailman (input) for mailman id 495123; Tue, 14 Feb 2023 11:01:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRt3x-0007oS-5a for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 11:01:29 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb088820-ac56-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 12:01:25 +0100 (CET) Received: from mail-bn8nam04lp2048.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 06:01:06 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6607.namprd03.prod.outlook.com (2603:10b6:510:b8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Tue, 14 Feb 2023 11:01:00 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 11:01:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb088820-ac56-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676372484; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=tCGr/F2k7dL9rhWqnARMiWr2ornNr0OqaAjkCBTUn9E=; b=hnxKKx67VTcjbkWYdymRxMAZxroRXBsGPoSLJccSr7jJUNpxnNXWv7pI 7Lflgkcz7S8bDhIF6XoXFpM67citxqeIyQGH0rC0dAMTwmlf7DtAxx7oD zsi4cSjSb97k6AcbynyAWSkFS+Y5DY+pmSQJsoqDzzb7vCsWRxeke9LYt o=; X-IronPort-RemoteIP: 104.47.74.48 X-IronPort-MID: 96349381 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ka5Mfa2kG63xU4gIIfbD5R9wkn2cJEfYwER7XKvMYLTBsI5bpzUGy 2AXX2zTOa3bZmT0Lt93Pd6yp05XsJHUxoRgG1BtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLF532 qcyOj42RA2BnLr16vXrG8ddv5F2RCXrFNt3VnBI6xj8Vapja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxovy6PnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzH2gBNNJROTQGvhCvAW+nm8pFj0vbWDin+uDjly5QpVFN BlBksYphe1onKCxdfH4Xha4qXrCuQQOVt54Gug2rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqW/62Yqj6aMiEPIWgPIyQDSGMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz Fi3QDMWgrwSiYsB0fW99FWf3za0/MCVHkgy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt 38B8ySD0N0z4Vi2vHTlaI0w8HuBu6nt3OH06bK3I6Qcyg== IronPort-HdrOrdr: A9a23:cynoGqGK1J6TlIDrpLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI= X-IronPort-AV: E=Sophos;i="5.97,296,1669093200"; d="scan'208";a="96349381" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azLyMzAWZ5Ihi1SQ6knrRnrc/rL9Jgiusb2+k6DDKkJq0Qa/BLzO2rJZgiQHB7gmReRrBIBXnIb89hgLA0LUsZyf9U1FqiIkvmL8Q9OYOqBVwDpcUzcYE5Oc8tf0Nvtiur17jJGAApqB7WT1pf4/YUSruIsuSYw3kcZsJh5onO5n3mphuALWUGbDU+fDCyZxwHje8cQJ0c3b3jVBo9K3A1cEqbg5aBOgB87jDGb07Rr08WNWJxjioZ7uALV2vfa3XmP8sfeugS0ttiFlLSbCBnwxaF2MqBhzMh/L/nxAmvNtJV6q5JDcP3OaH3XMIchvXQcqMrgfbQREszeaeuQRfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GSNyxqGBiyb6g1VId3hLyXSw+Uji2nTT/r5JNr3vM7s=; b=kAzBZlpAR2nxBXt6r1PO9ywMe6KwwmNNrxa1ohGxZTDl3u0K2m7xp2sRkczsDaoMyFEMpXAaCyZ5Pd6H2gPBO+h7yPl3LrBfye4Sq4k1We0twukTjIFsqoGsr7nAUn2HxaiDRm8guIGR2VUgV6/OmolmK0eR6z5w3yoxuin0/jomFaRqdTnmt0yfeS40CcPE+hqqqqqm/VsX38va2Bxy90jKxGUafOejvFkPBWfhP5Wg2Ibmw+Yq6Acoq6MW59nd2qYsUVGEC4lUlQ1/hxju2GdjF8okW+wf7pJWMS6TZ4tdE9GMTwjhDPdjzhWR3B5gY32UrQiZqa+qzGsnWe/Jhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GSNyxqGBiyb6g1VId3hLyXSw+Uji2nTT/r5JNr3vM7s=; b=t1SHCENrJGgW6flJuppXtIhMitgPn6SVKYJEbHLVvP9Lu9d8AKTcdUEpW8TLUQPbmfccDRdpVJNQ/gcahEEBLqKRILmhd5AYeWLI7Rn5CLH3oxGPjsJxBNa7pu77mDoBLTE9LC9dbeYSNlnqckbr33qxjbGjfUQihqXydfBqZ8c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 14 Feb 2023 11:00:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] automation: Add container and build jobs to run cppcheck analysis Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230213142312.11806-1-michal.orzel@amd.com> From: Andrew Cooper In-Reply-To: <20230213142312.11806-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0054.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6607:EE_ X-MS-Office365-Filtering-Correlation-Id: 6db3836d-f98b-4d28-189f-08db0e7ac168 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uCswYUNeceVZMLG9Zss3uBT94bFlIak9t6mKtxeOQKgJf+6ypyJ6dlbkjWzTKxd3bTOyoXtZFsEddndtRBiFkztbr+QgPNxpEtG+kG4rFfX0uGFQu0tzVT/6WxG04WNs3nnXc7xY8L9oKdWlbS3teX6oHeRPSmdutJxGWi+OrLbJOPB+7/+HcYcyrxqVRCOAAdtdPpN2+fva8XV/dlECyzSX988mujj6EkY52bmwHOMyQTAXfazAZscniaWAOMB+STJK6oU8ywmYp2yiemtlEC+UqdrSw6oPfw+goiPlKUiubM3kh6t6cGJdT9WsFfezuchTFvqdUunB+2fPizR2bXIHn+NI3YwANeHYo4JtlT5ycu2StL1V5Ihtl8YsPvETnyMkTUnOQwZuPWtl1bmEbkGOSpOD1nmvki2l9V+5RBn1k48VjpmzsIksa8G4/5wsPftiBXztFVEIqtFKVHBmb2Nn194mkRmLW4AO0ep4KZ26ro6Le5vNomcSubPXP62JNxMcGVTilj33+A8CeNHFn20A9HuPDmqTRYlWZCgo7u2KKHbbHWrprQC69tJUJBT+p0oFsj0NctHu0ay7z5L1NchHfBCghfPFU9ZGsuwWewCadfQ9EEl+JBnYmcKTUu+Lg3A/gIh9GlJcCQ9E5SSHq79ln8Kf8BzaPI7BCxA5AkRD6U0zf39A4JmZ1cZFYo2f0PbiaoyjZOdhLPG4ukLYrk79zpg1Er1gSZu5JZSs+1A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(136003)(366004)(376002)(346002)(451199018)(36756003)(966005)(38100700002)(316002)(2906002)(8936002)(5660300002)(8676002)(66946007)(66556008)(4326008)(66476007)(41300700001)(54906003)(2616005)(478600001)(31696002)(26005)(6486002)(186003)(6506007)(82960400001)(6666004)(31686004)(53546011)(6512007)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWF6SDc4SkpNZ1ZrTU1CZGZ4VisvRmZEL1E2MFZmc0phTXBDWVVDM3FPMGZM?= =?utf-8?B?VmFic01YWktzc2FETXplanp5OTFvZ01iTjdYeEZuYmxjbThqLzNCVFNzYjlD?= =?utf-8?B?NW53U1dyTk1icWMzZ2dOYWZ0bzdxM2RSeW9tS0Jnd1JDQVNyNTBtdmVUbUR6?= =?utf-8?B?QWx5ZFh5eldhY21kZVVIVGhWa3Q4Q1U5a21FWWhMcVhjSlZGcmZoU0JpV3gx?= =?utf-8?B?NzZ2LzJMbFJzZGZ3a0ZyWDBXaWozMUgxRFpXbmQ4dUV1emZaMnc3ZUh4dEVN?= =?utf-8?B?NmRGajNEZXJIUlBlYk02T1Y1YnhxV1BMSHA0eTlKSmNQcVo2ZFRuOUM4SlR1?= =?utf-8?B?cEY0LzhGZ0JlaGEwREY2ZlBWck9xT053cis2eEF1aFEyU2MxOG5TaUZCQWFZ?= =?utf-8?B?SHh0SGtHYTk5OE9BNWtzVFhmQjZkV0FQM3h1RWpMdmdLWUFUM3RORERhWHJH?= =?utf-8?B?Ujcxc29lUC9wWFkyUUoxcXFONVFsU0tmQU5sbmZZbDJ4NFkrWHZVWjM1d3lS?= =?utf-8?B?MnpTekVyc1lpcnFJTDBpL2xHSGVjd3c4YTdXN0F3b3RxNHptMlR4QjRSWW12?= =?utf-8?B?bERiWWN2bGpkd0ZUN3pRYi9SUkw5dHFFb1NCVjBpSnZ3b2dPRVNkTlYrMnNQ?= =?utf-8?B?b2RRVTEveXF3ZThKYU1XcWhEVmIxMnJwRGtvazZtM3ZQUzkxS0VNV2wzL2Zy?= =?utf-8?B?MTRFdFh5NkpoN2pTSDFGYmRlYTEvZUxnVlpPSHVOdHYrbmEwSzZNcnlVUVox?= =?utf-8?B?YVk5UGFkcEVGSWdkN1NOa1dibllianpaN1BDYTZVdzVEZHBYSVNEbEs5ZjUx?= =?utf-8?B?ZzF4UDQyUGpSa3NlYk5oWS9FVWpMNWNSV1hiSlNFU1liR1lQVEZWTi8zc1ox?= =?utf-8?B?eDliazdocFhzWjR1RWNIK1phMDJqM3B0dnRBTVBwcFM1eE1XaVQ3UkxFS0VF?= =?utf-8?B?RklyQllvSTNxL1daYS85eW1ZL0x5UkdyU3VZN0xseFNxR29vQ1UzU2tQSzNu?= =?utf-8?B?OWo4UGx1Mi9GdTBmVCtSeDd1bTNtOEM2NmhjNVVvWWl3MnpZSzhLMFV4RWky?= =?utf-8?B?b2Y2Si80QTlrWjZqSHBQZnYzZ2dLYWlSVlVGc0hBdmN4cWhhTGhlSjJrRHlK?= =?utf-8?B?eThQcnBzc2UvanhjanB4TjhoR2V0ZWYxWWhkZW9DYTRXWEQydGFvUFN5anZT?= =?utf-8?B?TDBtMVFEWk1GK3FXb1N5bjZzWWMwN2MvK0ZIRHM4UDNrQ1p1czBOUG81bnV1?= =?utf-8?B?U3lUeU1JeHp1emtqRVBXVWFITmNzQXdwS2FoN21TTDhrN3V3d2FiSVY1ZzRM?= =?utf-8?B?eTFZU25nTU1xVTA0MGFJdjZCKys4M0dCb0kwcENnaFZjRlY2SWJpRjdrMHNB?= =?utf-8?B?RHBjUE1mdm5Gbmw1ZFBlRlloc1dQa29yZVZWMHdxSXo0NU5vQWFhb1RWNDRW?= =?utf-8?B?SFJGV2NlT3MxdlAyREszWE1JSVR4aWt0M0s0SjdxTHh1S1pRbkMxYU5YRVRE?= =?utf-8?B?eU1JZE1DcXZzQm5HR1k5YnludGJhbEIwWi9KVzFwblhwbnJQRXF2ck9Wa2k4?= =?utf-8?B?WWpqM3dmQ2hTYUtCalBXMkoybUpKQmpCVGNROGxKY2gvcHlkYW15SUN1MHFQ?= =?utf-8?B?aG5EZkI0OVg3M1lQTzB4UUJ4a0pBWC8zc25FRW9Kclpla2NxTi94NERKdXI0?= =?utf-8?B?Mk1uTEpvWkl2YVJ5VVFtZW9LdzNCMHl1eHE0Q3d5TzhJRFIremVySjJrY3JZ?= =?utf-8?B?UldrenBNTHAxaTFQb0NOVm1rZUxwajczV3M4QVZweTA1Y1BIRzZsWG4vVDA3?= =?utf-8?B?eU0vbjRwalpla2hYNmwzV3ZHbGNSL05VdkJLL0xvOUQ2QnVjTEEybGRuZUg1?= =?utf-8?B?TWgvWUp6WUdWdHQ0WUZlR0s3dDIrSlEwVUZQMkV1YXNHRmUrVWUyamtMclUy?= =?utf-8?B?YzRhM3dhWEV1MmhRRDkwRzdsUU5kVytMWVBoT0t5K0FVVFQzVFdnYTNUdlhJ?= =?utf-8?B?YnNFeGZ4K2gzcUNkdUEyN3dQWXMrREhKTEVKaExybFpQSS9FREVXU1VDYXgy?= =?utf-8?B?RVZiRUV4djVhVXBaRzNTWVV1QVRuSUZKamlHbG4wdW9kM3FXVkgrMHBINENE?= =?utf-8?B?M2RQa2ljZ0NtS3M5K0tvaHAyL1VxcGxLQ3ZxY25YSCtXdHpCUHM0T3p0cmVz?= =?utf-8?B?cVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bAB91S4kLgoEJLXYvtxXxGmnokTH3WcSdEtE/5vXZco5ooZ0ga0QV1cUoFliziVpmQ6j68WaR9O5/GwXN6DVn6XY5ZG3N83uSk7qcBWYNF2tpP6tYPgD6nIu94t01iI+NPUt2zhokdYiKJeprHCncKQ/rvTSR2va/2nQr2KtGvFu0HR7pgY1id2P5ZhUBzLsoTykmtgP6qYNcVI/HH1cd9KkyJKqnlUgO7cKhc4JLCS+D88EQuyFy3wxeAyGgfBrmGB9EJbrEffHVr9CEOgQuqW1uZx1RXgcQQuU3swe593vWCkjGX3qhwpcplfjBOSjnYcGRAMFa/6ovP+X4Hf3vBmQ8psy5oE9ZqUEgrTjQ9YqXvvhVSK4L3zf9yyRrz17ukzIQuvFKDrJ7eUx1wJRLLfMo8qzD0LUMQYuUHjw0sS9tUdWDM9Q0m0ZdfVKUa+z097b+ge+5mEv9bcUrRqMGFURXZxNfThu+4KGO1GHD1+rPnOthoT+zrADDITDZtcydTqTZISTbuSr9w3YCFst6W2dp8WlPXzOJGS0kedSJppfrCTPZYOtqvY6zWYkBl7bWYpd42B1VjVKQL9xz7vtN3HsidF/RWufn1KQ6hYkfAuhL8eL1qbLJk3NJ27UDtZa+4+W7qZ6auJbYyHZu5/I1uh6++TFQShPk7VfoioGkZxtAxk6EZ+ntRbSsVseldHyPl4oildy9eCGwmwTfwpL60R9GtMR0o7ujosVQM3WejI3ssLCX0trPAOdXJtv/bb91GnsovrhbldwinLtDL/nJy1+sRdxYHwX036vQF9zDEBo/CFq1Ihm5tdQ5h0gwrSefjYx6WqUJNFF+7pvW4Z6Gz+MZXJkPuLWrU4va0kakn0= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6db3836d-f98b-4d28-189f-08db0e7ac168 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 11:01:00.0430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Zf+W2QjHnC0RBTDot58/tPyJoPpOxtx0SB44zB2mV6hjl6P8KSEUKzb1efIkIwrdcnpkD3PTHBtphQjPXDvFhDIQ7Xzvo0LoIWfZkZxLDM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6607 On 13/02/2023 2:23 pm, Michal Orzel wrote: > Add a debian container with cppcheck installation routine inside, > capable of performing cppcheck analysis on Xen-only build including > cross-builds for arm32 and arm64. > > Populate build jobs making use of that container to run cppcheck > analysis to produce a text report (xen-cppcheck.txt) containing the list > of all the findings. > > This patch does not aim at performing any sort of bisection. Cppcheck is > imperfect and for now, our goal is to at least be aware of its reports, > so that we can compare them with the ones produced by better tools and > to be able to see how these reports change as a result of further > infrastructure improvements (e.g. exception list, rules exclusion). > > Signed-off-by: Michal Orzel > --- > For those interested in, here is a sample pipeline: > https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 > --- > .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ > automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ > automation/scripts/build | 11 ++++- I'm afraid that I'm going to start pushing back on any more x86 jobs. We're already at several hours to get a run out of Gitlab CI, and that's assuming none of them hit networking issues, and outside of the typical European working day, when patchew is busy churning and not reporting the status back. Right now, there is vastly more ARM test resource than x86 resource, as evidence by the fact that you're never waiting more than a few minutes for the actually-ARM tests to complete, so adding more x86 cross compiles is compounding the problem. We need less x86 testing, or more x86 resource.  Probably both, because its now so long that even I'm not using it as a pre-push gate on all changes. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:17:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495129.765382 (Exim 4.92) (envelope-from ) id 1pRtIo-00017Y-Fy; Tue, 14 Feb 2023 11:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495129.765382; Tue, 14 Feb 2023 11:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtIo-00017R-CZ; Tue, 14 Feb 2023 11:16:50 +0000 Received: by outflank-mailman (input) for mailman id 495129; Tue, 14 Feb 2023 11:16:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtIn-00017G-6u; Tue, 14 Feb 2023 11:16:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtIn-00052s-4D; Tue, 14 Feb 2023 11:16:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtIm-0001Uj-NM; Tue, 14 Feb 2023 11:16:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRtIm-0007UT-Mw; Tue, 14 Feb 2023 11:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3xXsQZMAEgyVtJIXxW6Y6xEDE+5PNroAYH5/sGhhPB8=; b=O4m0LL7ZtslQaMcLcpq3PcNLMB UHkCr2M1RFTc9P8ZUKkA4iMltFX+1oQ+akm8uHaBEiVwpTns9tBPk6DAlY2Rsum06qmn8liXLlLsz vgDwnrlasycr620yC8GCqZFaiX6NpC3gWVGFLQuKt/MFn/q9BzYksukIFS6iJqTIRF9Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177229: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 X-Osstest-Versions-That: xen=f4f498d08d50259b9f25c274fd7b1e8ccf5693af From: osstest service owner Date: Tue, 14 Feb 2023 11:16:48 +0000 flight 177229 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177229/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 177171 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177171 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177171 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177171 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177171 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177171 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177171 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177171 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177171 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 baseline version: xen f4f498d08d50259b9f25c274fd7b1e8ccf5693af Last test of basis 177171 2023-02-13 12:37:06 Z 0 days Testing same since 177229 2023-02-14 01:42:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f4f498d08d..9b70bc6d96 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 -> master From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:28:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:28:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495146.765417 (Exim 4.92) (envelope-from ) id 1pRtTl-00038a-Uk; Tue, 14 Feb 2023 11:28:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495146.765417; Tue, 14 Feb 2023 11:28:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtTl-00038T-S0; Tue, 14 Feb 2023 11:28:09 +0000 Received: by outflank-mailman (input) for mailman id 495146; Tue, 14 Feb 2023 11:28:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtTk-00038N-R0 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 11:28:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5f41e37-ac5a-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 12:28:07 +0100 (CET) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 06:28:03 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by DS7PR03MB5527.namprd03.prod.outlook.com (2603:10b6:5:2cd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 11:28:01 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%7]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 11:28:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5f41e37-ac5a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676374087; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ShFv9QsQJY1x51FVPYPXi4rVP16k7PU+/005ZkL4UlE=; b=S4WplOhAqvh6chscBQ6h0tY83GjQt3KpGbMjMSOjYh70WPX48xiJdfsW 1wxm4u4MwhMFy0x5q6k3aS4DM9EJd4KtAh6iVlocmeDbLjCsv6Q7bkT7w x9h9OFxYsADePRp5TYfr/0nx4SOvB/ukzxRaH4hyyBo2Pj9obFVUHdzV2 8=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 96352269 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:E0cg56gyEWwyqMgvDgshUdLWX161vREKZh0ujC45NGQN5FlHY01je htvXz2GPv2ONmTyKNwnaom+pkNV7ZWHnNRkGQFlqyhgRSkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQWMygTSzvfutj175iDWPc2oZ4/Jo7CadZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1YbI5efTTLSlRtlyfv XmA+232DwsFPdib4TGE7mitlqnEmiaTtIc6RePjq6Qw3gz7Kmo7Cj5JdQqh4uGFug2CZc9bI BVX5hAwov1nnKCsZpynN/Gim1aBpQIGUsFNFcUz7QifzayS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSm7ISgTLGkNTSYBRBkC5Z/op4Rbph7IQ9xuFIa8i9TnHje2z z3ihC0mgLUXhMUI/6y+9ELAhXSgq/D0ohUd4wzWWiev6Fx/bYv8P4iwswGDvLBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4uVmS+G8B3h44RALU IronPort-HdrOrdr: A9a23:mBfvoKGaoZzozXmKpLqE0seALOsnbusQ8zAXPiFKOH9om6mj/P xG88526faZslkssRIb+exoWpPvfZq0z/cci+Qs1NyZPTUO1lHYS71K3M/PxCDhBj271sM179 YHT0GmMqyUMbGtt7ef3OASKadD/OW6 X-IronPort-AV: E=Sophos;i="5.97,296,1669093200"; d="scan'208";a="96352269" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN++LbqUfjTuKXBF1DtTlh0r+vfXnpWFyQhu5F8DKWXPQ1hR317gk9guoCeutsEj+m21nwfystmZuud4ROW5reirQZ+v+xJoxIIiHgLE57+xSElVMIHPKYVBB8tQrUcVPCD8iO7jWEd8758VnhP0wl2bA9WeKEsVEOlQ5Mu/GpYkmgfh3HSvRfGKDvpoyLBPJbtKiOCYS+gQRZyrj/FIu+KfwdbHfyL3RyAY/+CUXY7KN8O1yDamU0OQeqng0PHCyJynsFNCl5xRw5cNuNuq4arPpsKMKp8fu4z7ENWaEe1oaxNF+k56Uv/yBEmJgAQ6UTcD+213+y1GKTVAVboj3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShFv9QsQJY1x51FVPYPXi4rVP16k7PU+/005ZkL4UlE=; b=GvGSDy4L/5KbkOinerZ+1gPI+ZZzUl/n5bnwQqqztLGaDbdoduO09cB1aDwBqoxQ+UzknJ9+gs7b/0hkVde+45njI3aWpaUX/n4Vw4tQnqvz/2Hs8LS5+iqfe3rKeiHVyJC6uGO0H0FQv5LSgJgLWpgp3FEVNSWBbWatXAkz+RbypNuLu/BJUIHWFUm6vH2XtMftPIyVCGD+ilsCpa0WXybUROotmrMbkvHVo284nhvCZd7yThqB1vgbHeNUtY9Nm+FeluMMzYtNM/ntMSZzTXctf/a6Y28G/xWgJ97eQ4iV6pZxtCfAFSvKrNT7AsoW4yvtCMyUbFZ06GI/6Wm1YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShFv9QsQJY1x51FVPYPXi4rVP16k7PU+/005ZkL4UlE=; b=okB1n87rvQgeHXOih/ATTv0VPmdld2o0bDZIRhGkrNb9QlU9NBMC9n+0JcPr0DoTxOMISQ+a7VEAwQ2AUdzMk0T+k6+Vti1jHx0kb/IJ+MvF2W8FionAYFNGNi0obLBnOE4onqrJvn+jcfoPMZnAf7VeaDF2MQ9KCA9hXUNGeT4= From: Ross Lagerwall To: Mihails Strasuns , "xen-devel@lists.xenproject.org" CC: Raphael Ning , Bjoern Doebel , Martin Pohlack Subject: Re: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new subdirs Thread-Topic: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new subdirs Thread-Index: AQHZK+7hAAtdeJjC5UKkOXFz/lMuKq7OdpQl Date: Tue, 14 Feb 2023 11:28:01 +0000 Message-ID: References: <472bfbf92aba6d3409b2a101798f04a50c97f6e9.1673623880.git.mstrasun@amazon.com> In-Reply-To: <472bfbf92aba6d3409b2a101798f04a50c97f6e9.1673623880.git.mstrasun@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|DS7PR03MB5527:EE_ x-ms-office365-filtering-correlation-id: bbd4127f-921e-42e0-2115-08db0e7e87d7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PmX6fy9sGxDIs8a8ByQpHq+KVQOImxXYAbNCwcOT/t7/V3do74VdqljsyPo424tfg3pBG5wt7E9ue4+wQJZI0gMphG1q/i7oLuvAy7SCe4JOa25nE5PKzlDZhAQCBU9esOtQ3+i1uixc9zFNbzNT+EVXldsHn+XmPMoXTV76LSJX3Zlt2tXpeFrWUkct8kMGGbfKb0C+6ASkJ+ArsNHAxTk0pKjtOyBETtlueXWaTkUNYMHcoRDjv/zIr1D/aPwCzWCkwMrYxr+w0yCmeQzH2MhkMnLPd0raBbQXPqg5nEOlbIFKIGziA6kvJvVxX5jfY7fDI2n5gDpZy6VdwKeQC96dBk7XgbAyymvgshJfU/W9cE51FZd8sV0ia4ZcGenD8mZjx7HHp52UMNEXQxLdGyMaKsEUacLSkDGtT7eu/cj/LKl7R0RDVJODHUuwa37/EPQHbr0I1s0rN4RxhddjoeaJuvCIe/1MrJLhe85uV03O1GRrHzAXjohxskeMbL0GEd9YpUUpQebf4a6C/27Fqm8Xp3ucLZVLKLucesCRenmR6CKzIEEQECjfsET0V5pYmVMXbDdqn3T1BS7Zx/L3E57yNie1d3bVke5Q2kwe4DRgSn/p47SpfZpcWfIF7WjJLXGqCJe87WQmwDtbECpp6VadeesN6EUnlrXRf4MmxCSmvoIpoynMoQLTQXTRot49mk8+B+Is3dHe+otl3ssHzw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199018)(82960400001)(91956017)(66946007)(38100700002)(76116006)(66476007)(33656002)(5660300002)(478600001)(41300700001)(38070700005)(7696005)(55016003)(71200400001)(8936002)(4326008)(8676002)(66556008)(64756008)(52536014)(2906002)(110136005)(54906003)(66446008)(316002)(26005)(9686003)(86362001)(186003)(53546011)(122000001)(6506007)(44832011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zbJD5V2P1yfEW/XG5qQHJOpKz5ZTbKV8wo8ltpbPWnWFft/JRuFrMS+KaQ?= =?iso-8859-1?Q?94werIo28q6SrPrZseP9szJK8HLhzuKTP8mvcoBg88+VYIDGIHcyFJlkSd?= =?iso-8859-1?Q?nSkfrXzzOt0nE1UkhGhTBd1XG+SgT2ALl30X5QNlMs0nNRnv3BA5mczCC7?= =?iso-8859-1?Q?3F+CTj0uUxMFpCy4tT1PF2RuLsL9pEjknxT0y2L5a1mHUTTgG9Lkln2I2Z?= =?iso-8859-1?Q?tPhBAzRMSDjN4sNWYlpEV+pjbaP9xl0Flnp2NREtPWj1NfnL+urzYokm21?= =?iso-8859-1?Q?H/DlY6Ucd/lXBCF7VO9oiCmt2M+jnDHtnN6Sz/N3wm97PB23wECPe7kTK9?= =?iso-8859-1?Q?vAajvDeZSymt5bt33NAsCJExurGM2vrTsq5cl87upo3huJHb7GU/4cTzOl?= =?iso-8859-1?Q?BgQ0sMBWOT7Z9F7b6vTm9SHBnqoYiZ5Z5S0l4RrTcFuEyS+ee8LuUblGHh?= =?iso-8859-1?Q?gR/A0HmC28ZbgVkyFfYUdyD9QArfgluZBj1FqORvqqLBTe4I8smuE2+B7o?= =?iso-8859-1?Q?HrFkQDSxcMIONTtWXYNzOJquH9Z1Q3m0s4tff+vXomP5QAXE5IuP5bZ54A?= =?iso-8859-1?Q?snVo8s1wo6ABhV53cKSHU92gD22iVpnQ2Ug5q0BIUcVppu18YyzTN63YfF?= =?iso-8859-1?Q?g3ujisNXE/Rwe0+5VhzHoahc67kwcOeBWK/sz23SfLskXQrwBFrrlbPHPw?= =?iso-8859-1?Q?zrzoU21jII2hvw5Y+gFoTwv/yplqABGGXoCeHFZsS6oYh2e4HF01MzzQDR?= =?iso-8859-1?Q?KmozlSQ39S+7mUBiAyuVwmPL3caWBFrsj+MbTK2mZ8RYzLvGeIjCFOBFFQ?= =?iso-8859-1?Q?2jq9ubZ3bxrpyZp9xewdOXMsrLrYFlvB6FpIYJOAbV9iKJlb9lqdgIxUG2?= =?iso-8859-1?Q?SZjUJsuquOBDggJ78BXrwhq48Ur/u6FZVjvbT3VzuttsmFmgPR+YDUnGwz?= =?iso-8859-1?Q?ttNz6Crop3T9CCvfBH+PxeRA/11UWZEotsoh0MXHjzTg2lw0QPxKp5XFND?= =?iso-8859-1?Q?Rnl22X5CBAaida+xiRxvEU4/jfFjHSXqtFRDwS946McmfTMsSol2Wam3jF?= =?iso-8859-1?Q?kaSdNNyk4K+2MDUG2XR4di8NZ8vU8eXWnMsHZwlmQTUGqQGB3yaqiqOPAH?= =?iso-8859-1?Q?6CjtaJb+68oP7eUY1Iw+1LIT4r58TkUHUo47w2gVqvFQNKIahmbiOHk0gJ?= =?iso-8859-1?Q?rnQ9EQZ8aNXykYg4jzx1yWUG6g7U7JQdf4xaugPlpnUkGCQZWOxtPWNTLD?= =?iso-8859-1?Q?yQYg5EhD+HyjkLwp7Hgb1jh5pMhKsE7Z8YpMe2vwSDm6iI4sjrmzJ4UKay?= =?iso-8859-1?Q?gjKBquFz581VK6EQEqwFHUrgD75A+3tn8twto/JAx4sE9MQaSkzJZwf4Tz?= =?iso-8859-1?Q?7Ri2kUeSevnXmyzQ62uBCE7uYbeCZJFu1N6psJemlui60rUZ3XN6ICjLzE?= =?iso-8859-1?Q?LHuThhy5nz3JtUdAzjBrSSQ2plzN/ParJCU7wf+ckMOCm7Bb+U8BukqfQf?= =?iso-8859-1?Q?Gas8LS61rdnfFuBmun6UYCg7T7YXSHosFIzaucbvjZyUmexf7t6QR1+cYS?= =?iso-8859-1?Q?mzN3i7qlCOzdRUPKraqWHSoMi4cQ0tZplHbUuf2Yms9fxW1y6jhDCel9bk?= =?iso-8859-1?Q?FmQGRiO5NjJaDR5lAtOAO13qHAjvkloS1P?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GQQsYbpybGqbCVTKbnf0/QD7YCrR+qFjO7ghwVC1oNVc8k8HRRjMoqFNa+Jm5bIG70LrkMHEMydVGsSNkydoYgTlr258IZrALPwKLhXDV5cLyBACr169ilkHvOHW469iQmJuyWbAlMAdp7NT/Y6Qaq+hwZsB3j0a9QdOh2/dffCAo5IvDufyLS6pqdnWNnZmiX/27TIlUHeA2OQ0OYqmdMx/I1qNdQBjOO2EUf6jw1vfoDdj2bko3HbD9KTVnaIs0a1RDnGVINYMAgz2QpJrz+h3o08REFeeq/GD232VkzPPfBqftP8AuSkEj6NCZ9qo4gs8cGeWitwp5K2gSUCwbnXiLMsK2W3Akpi3phiqoJK6X6ZVQbXE4QJwZTH0j5wiqmeXQI+CleeWCsgYgfNWZgyWZCV3gUcsdpPHSN7BnstGoVW0czxlVq7ZB7Ucea28j29oz/PG9jXxmT8qS9i69/fsF4nDS2VOt2nH9WS8nttQKKDl0cPJIztEcMvcyo4WVhXb2Qa0cHkpwEKpKfV8eJmR3jPRMW4EIyY+jTKncSuKBQWYTQcltm+a0YDQZbZ2pEeivYSVL9lCT0P3jFHWkCssU9ZgziInmRPsN8ffomTibbsMVl/GIwrpNLPOf+FREAic25KulTvHrsRkU3scNi/lI0+2CHn04HeLO9OnuQ/ZRkCBWmME/SLrCg1F9hKa+exdNrTRVp0q29OZbMoKs3ZBdS2PyafO0TkK5mTaoXYUtcqH97VmmQzEQgEYl/cSV6WB/FcAZnBvU2qyMpIy2iPfHNuQhxTxpG2VMUI+o+VqMkdXIYlam+MWwEbM+Bm2ZaaZuTnCkVO71DxRXmL2iw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbd4127f-921e-42e0-2115-08db0e7e87d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 11:28:01.0435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +GBgGnpAj9QMoIPqkzjV91+qs4M/G6rG5/vcf4EhPCZDmWLPIVePMCTbEaMXoXTTue+O4uQRvOFStGFrvybOH29OyE8zWLAdhMcgnyXccHY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5527 > From: Xen-devel on behalf of Mih= ails Strasuns =0A= > Sent: Thursday, January 19, 2023 10:13 AM=0A= > To: xen-devel@lists.xenproject.org =0A= > Cc: mstrasun@amazon.com ; Raphael Ning ; Bjoern Doebel ; Martin Pohlack =0A= > Subject: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new s= ubdirs =0A= > =A0=0A= > From: Raphael Ning =0A= > =0A= > Fix a bug in create_patch() where cp, strip, etc. will fail if the new=0A= > object file introduced by the patch is located in a new subdirectory:=0A= > =0A= > =A0DEBUG: cp: cannot create regular file `output/xen/common/lu/lu.o': No = such file or directory=0A= > =A0DEBUG: strip: 'output/xen/common/lu/lu.o': No such file=0A= > =0A= > In this example, xen/common/lu/ does not exist in the original=0A= > (unpatched) Xen source tree. It needs to be created in output/ as well.= =0A= > =0A= > Signed-off-by: Raphael Ning =0A= > Reviewed-by: Bjoern Doebel =0A= > Reviewed-by: Martin Pohlack =0A= > ---=0A= > =A0livepatch-build | 1 +=0A= > =A01 file changed, 1 insertion(+)=0A= > =0A= > diff --git a/livepatch-build b/livepatch-build=0A= > index f7d6471..444daa9 100755=0A= > --- a/livepatch-build=0A= > +++ b/livepatch-build=0A= > @@ -232,6 +232,7 @@ function create_patch()=0A= > =A0=0A= > =A0=A0=A0=A0 NEW_FILES=3D$(comm -23 <(cd patched/xen && find . -type f -n= ame '*.o' | sort) <(cd original/xen && find . -type f -name '*.o' | sort))= =0A= > =A0=A0=A0=A0 for i in $NEW_FILES; do=0A= > +=A0=A0=A0=A0=A0=A0=A0 mkdir -p "output/$(dirname "$i")"=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 cp "patched/$i" "output/$i"=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 [[ $STRIP -eq 1 ]] && strip --strip-unneeded "ou= tput/$i"=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 CHANGED=3D1=0A= =0A= Reviewed-by: Ross Lagerwall = From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:32:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495153.765427 (Exim 4.92) (envelope-from ) id 1pRtXZ-0004jN-Eb; Tue, 14 Feb 2023 11:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495153.765427; Tue, 14 Feb 2023 11:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtXZ-0004jG-Bl; Tue, 14 Feb 2023 11:32:05 +0000 Received: by outflank-mailman (input) for mailman id 495153; Tue, 14 Feb 2023 11:32:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtXY-0004jA-Gz for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 11:32:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32424567-ac5b-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 12:32:03 +0100 (CET) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 06:31:52 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by DS7PR03MB5527.namprd03.prod.outlook.com (2603:10b6:5:2cd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 11:31:50 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%7]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 11:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32424567-ac5b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676374322; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fEX09fzVnZGqu5Ho97SVYzx65sIOveKJBv+xWIb5Trg=; b=Tp6tWOkEXTErEymuClzYSZd92fT6m3yn9RW/90g6dNjmHasK30hx1nCo XJaxXi2FKd+9D+Mv/bWDCbUhCxXcpL9ya5/SuGcuVMdM5VWrVVhJD2RBj xfJzHzKNO8xJTYxiEiaPHEfCC1GiMQPCVLwQo1/hTI4JIzpChRMEQ+nBa Y=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 96352702 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FHM6TatJBYLUliIfeS0qLXzNzufnVItfMUV32f8akzHdYApBsoF/q tZmKWuHaP+Camakedolb96y9U5X68fWmNE1SVNp+3g3H3gU+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWHyyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwA2wuPg+/veaKy6OadsttjM8IEpeoI9ZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIK9lt+iHK25mm6Co XnduWDwDRwAK9WbzRKO8262h/+JliT+MG4XPOzmraMw3wXJroAVIAwvFgK3iMmWsVyFAe4AM GIIxwUH9pFnoSRHSfG4BXVUukWsuwUAQdNLDusS4QSE2K3SpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRuoMDAVK24EagcNSAIX5N+lq4Y25jrDSdtpHaqdh9j8Czb2h TyHxAA7n7ITiccA1I2y+FnVhDTqqpWhc+IuzgDeX2bg5AUmYoegPtSs8QKCta4GK5uFRF6cu nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGgWyJtBWircRQLUX Q== IronPort-HdrOrdr: A9a23:+0nZa6sgaaD2cBxiPR4DBNSj7skDzdV00zEX/kB9WHVpmwKj9v xG+85rsyMc6QxhP03I/OrrBEDuex7hHPJOjbX5eI3SPzUPVgOTXf1fBMjZskDd8xSXzJ8j6U 4YSdkBNDSTNzhHZLfBkW2F+o0bsaC6GcmT7I+0854ud3AJV0gH1WhE422gYyhLrWd9a6bRPa Dsl/Zvln6PeWk3cs/+PXUMRe7Fzue77q7OUFopBwMH9ALLtj+j6Kf7Hx+Ety1uKA9n8PMN8X Xljwe83amos+i6xhjAk0ff4o9bgsGJ8KoyOOW8zuYUNxTxgUKTaINtV6bqhkFMnN2S X-IronPort-AV: E=Sophos;i="5.97,296,1669093200"; d="scan'208";a="96352702" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LOZYiR52uNQwiq2tEirwu9gy01ue7Q88XcG9qPKE2vYmlb1JDXuIMg8gjoKLD/v+JlE7dRTYLDQTUI2tUBapwSRJVyFSJZ2OwaGTwZv43F7iRp9UKuOPuQRjLgcaIeru0lI0Wa75vL+HWzFCK3UKDsxesjeGCA0vMDJTcdmcQsA3m26sCayX89Ol7m856PDqaqWsnrJHLA0hlv0M7JV1K+iad6LTMqxrs65YDTdJJDWpVeDvsmxSIzTLQK0rGzkpRJHaFrkCAXEqZ/FQnedWsUUhIqpoadZb2zH8MxFEqMRYvJ+VIN0jkXtwo2Y6rXr5x5PidsbSgW7yfejZTK8aGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fEX09fzVnZGqu5Ho97SVYzx65sIOveKJBv+xWIb5Trg=; b=D0WdWPCSZoIvRJXqvFwhexgqEu7LjCjQEhvV0Gbv06eBSyXj3Hov0vWqt0o750dn47hyJ4/r0zDEUjvgL+IoOqLE2nrntwB7vFYs5go7W283ba+1CW8vLmpKUXdXUhvTToxOlEaA1WsIV9iOfMdPHbALI6kOx9FVliQvenjn63GfdeLF11itZS8MDlpD1gzwMFTr6VqATY+EjiHRzoVvMdWE05BATmexdRnvII36gdlKalDhfmkEevbM3AVzvgTHDeu+fWx4q2yMLuCJdK1j26OKUEO3wAkzq3p1y0GG1qjt4wiV3wEsHZG7paY/ZSHkPITahqEpodhYf2FDW0pYVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fEX09fzVnZGqu5Ho97SVYzx65sIOveKJBv+xWIb5Trg=; b=TYjh2HnipNzoWMJTcLHUGLy5vTT3Qqg5Fn3WGpaK3z4Hk82yaksL6kCiu5L4xLqQVVvIEg4Mu0UTH5DaI/WCOYfi+VZk7qgSMViWXbEvZ+7AylMWabfOFSo5eimM2dmyQSICLgJAmJFtjjEaoz5L7eDhQuRzd1CbNFUs+o0vbtQ= From: Ross Lagerwall To: Mihails Strasuns , "xen-devel@lists.xenproject.org" CC: Raphael Ning , Bjoern Doebel , Martin Pohlack Subject: Re: [PATCH v1 3/4] livepatch-gcc: Ignore buildid.o Thread-Topic: [PATCH v1 3/4] livepatch-gcc: Ignore buildid.o Thread-Index: AQHZK+7vqwIB+XQ8EUuEjmznQnPAUa7Od5Ne Date: Tue, 14 Feb 2023 11:31:50 +0000 Message-ID: References: <477a6e0f0b0088c54f3f048bf2b4593eb4df18af.1673623880.git.mstrasun@amazon.com> In-Reply-To: <477a6e0f0b0088c54f3f048bf2b4593eb4df18af.1673623880.git.mstrasun@amazon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|DS7PR03MB5527:EE_ x-ms-office365-filtering-correlation-id: 4796c436-70ee-4f8f-9021-08db0e7f10ac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2LxasdsIP8mOst3hFDMZJQ0SaZAgA0DJ9PsTGKNuVRUfY99VoqzeHgg5bhUBdkv2ecueUfxtByzNKfDJasSKpao6m9Ek3WTSqPh3/Y6do3w9OonHfd/3WScWaGSr/SjDs+dWJyuPagnT/j9u36g0saVaBJfCYSbM7bgcz92PE2J7zgGq/NFg4JHRNeSwdWp6vnObXiPgzYUXDn/V5DmxCWS476tEc6Yysh88fU44N0QvT3+lL0R8C0gLufbqfcM1EU3KgdltOyaHDvPY3VqRQCSwnEwrrkSOAJ4yxRXNL9gVfgW5ICl600cW64haznlbV4UCeFJwJWuM+u5tx6HZOdwaCN05oeVH5GCuHkmLQbHfATL4jaIAUsypbMxbSbu/2jokCgi1uOeyamTt5sffPkHn2IuKDVUuHnwUgfkhboJ4hBysdvsoe6vGeT7lVlNHISXyCLxWskik84NFIJfCyGE6P9FQvVa1M4zZBAsOptC0+11tyfcjaO4LYp0xRVAvcRm20HZqgXeXePw+EgcIA5M6VhUBPhfA5azQo72wPGBEdjuYTt+L3EKZA/+KBdLZtZ1vrJyhlE+16Q+cdUt1MrLWWkh2nTE5MoE/A+pEabqpvMIyuHd0cmY8vGtviDawATsh+53+teKJQLkcDIsds6HsY/T1daSACEu6wp8ipt+9XSuoNkbYipqINDZsVVlj x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199018)(82960400001)(91956017)(66946007)(38100700002)(76116006)(66476007)(33656002)(5660300002)(478600001)(41300700001)(38070700005)(7696005)(55016003)(71200400001)(8936002)(4326008)(8676002)(66556008)(64756008)(52536014)(2906002)(110136005)(54906003)(66446008)(316002)(26005)(9686003)(86362001)(186003)(53546011)(122000001)(6506007)(44832011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3PKdQ5eHoRuj4QaPbYuxi8vb3xDpMR2ZVjXehk64ZaWBnRt6pbMW/E46a3?= =?iso-8859-1?Q?WHF+uVlXrEDcNbV6hsyiHIu8oud+/86Dnq798MKqQ1nnxtlefj0KP0m9BY?= =?iso-8859-1?Q?WJR15gdE6QpKNTcDf99Rv9du3M5wN667KF+OQsB016jBj5/mYIt4tSEc0+?= =?iso-8859-1?Q?d4lmtaTz0/jHQqXT0E6mUJGax/C0glL2JwY856O2/bSFIHcZvAoaR6dE35?= =?iso-8859-1?Q?X2T5fufDk97u85rmhBIZXF9iAKE49klBg7LAzVgqlCrJQ/zzYjiKvDN3WV?= =?iso-8859-1?Q?sH1lgYbZxyb/jvTCqaAAk11jKi+bqBH1KWu8ljKAOkRGFnRXn2u78JL7Oo?= =?iso-8859-1?Q?lkj5U2PpjQz3LbfK5UHmV7efmUnDouARPPEoOYfX4HQbguJoCa0HxqN4C0?= =?iso-8859-1?Q?7QKxBZSHoT+3oOjPM9g/qe1zK+nuLuG1CPvHqR3zBQdFkXbvvqGRlfMqTB?= =?iso-8859-1?Q?BxLieSY6+T1keCmU0Fc4ThVf6vdLmAX7ZUFriAtj+9eR+ku6K4jJoIZHNB?= =?iso-8859-1?Q?jtPoFNvGEKrQVIU4iMa4JD1gHMzOONdNdZ40CjNYWPBQc+oV4xZSmyqVfS?= =?iso-8859-1?Q?AJDVIpT1JVfXwF7QBjq+ltC+87OsSBCCCxRMCY7wjz5oxSZrkZiPWXVRwl?= =?iso-8859-1?Q?4A2HClG8FSAbQpj1IJOSQQlYHIh60spKkpNjdSWhvKgzl+ZPm7ZKRNiHiZ?= =?iso-8859-1?Q?obENT/GfQmpgdB3tDtnMW33L0jDjpOx48LYJH4gwkXyHrAC8WlJkVJA/Nl?= =?iso-8859-1?Q?9AjSHhdMVnA13R6asdwoRwH8PgRneN1vWu0tdy6ux0UoqJuThkLYfupL/H?= =?iso-8859-1?Q?1CfEYpSANv3b2vJxsMLflpHdSuYn+uBDDBxMUgIgZvFgdCL8AAwfIbPxSo?= =?iso-8859-1?Q?4Yz1apc4W1fozl6wMIJrlk6mrevCNpGmBCu8qOjMHnUzi2IXFgMwFl039C?= =?iso-8859-1?Q?4bzZCzqoMP3HCyKFmRhpnp1FBCDgjyfpEKAJ8qfXx/7bIpygxQjo03GVEW?= =?iso-8859-1?Q?nR5BcfH7zON2iA4ALqvIVfU2GlxBDnNfmNZ+dXDcSoKRHnwXNp1/xHJ0IS?= =?iso-8859-1?Q?indTQ+dLKlXib+3B3zXGFFP4WNccMWmqkZr1q9Hg5rkPGGq4WeD5ZP4xtK?= =?iso-8859-1?Q?eRCgoY7Z5wE3CnBHH6V3+YtOpg8+PZQYIDru0xMOLG9o7rhtJVEwo+IrN5?= =?iso-8859-1?Q?5yqIGDS1mTVTV+/VgMlvJMmVxRHeGnVqY8EeEKophNysw1SQPLUo2p2wau?= =?iso-8859-1?Q?r+wMISifl1hypnSExtZWayEOqztEzXGMw7PwSoPuce6vaPO+S2ETYzadK4?= =?iso-8859-1?Q?40oKFrKbru+mhQAKc31IA7BL0OFHO7UJBTEfHmonOy5i3WRk8rhBieo4Em?= =?iso-8859-1?Q?IFPXxMMlgjXrqwgR/4d4N7L5RCeZUzgs2O6TMHT8JPIcMquNkeaIuDYh3B?= =?iso-8859-1?Q?crJRGpBveTxTNWUYEeV50DN+NMoz5wKL3YwCOa+madGJf3jdYAwHLVehGb?= =?iso-8859-1?Q?R9mf3c2QEVwO0IxsQj1YiD1wVNRHK9mZUfTBWLg0rny3D8eJWUtNfCtAqL?= =?iso-8859-1?Q?o6oA0eWIgQ6P5HwBv9PwlAfVGkIE0WblGgvn7r279Rxr7owCNBvT+h7YC0?= =?iso-8859-1?Q?hC7aEVdfGnuyEhMCZsTVfTKYYXkhXPu9ay?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3W3WFI7RXTYtaYYXUShgKH9M2rk8kJYgNS0ND+k1LXjRe1dds/4V/c9IA2xFxS7F1f0zJTjgw3mr0qv/d78wlwkHprOGOoGBjt8WhWIES1nezny1DwvAcwCQ/xgNvDde0zusEnufm0hy1Ehl6cSfRIEVDkr15InHArN7QUc/VonOlP9JJ/E8h8FpcY2gG1av+V5ygwkyd1yLP9Qi8M6TsITzDLvu32tfekLZ28mshY5HGbw2TrqnhJufL1NkypzeKIoSQxxJkg3zE6rqz4Dq8UjgrVDQfSxthB8adDBKYNDUao/zFPr4uJ/ADcp/x6MjfI68akjZQ5JFXbydesNOZTv4sGTe4vDkP/H0FB9aU3R9xG5hvATMiRoNOnOPsj825KQxVjC3Qo7H0FxmAVWIXFq2l0G4zQcTOqufrmCfYPFPhseFkIff0TVp3FOlpKXHJKUrnVXRb7F33xtuuNSrr9aFYWahHp9705uiSu7MsViaxo3uPeaDw1M2WIUqhQYUUTAmF6elL6vOgejH2j+RB0kXKWbFcS8eQLVCEZ8u9Xr1tffDNJqcB6oi01U4t7XemL3rHGQkZXwHwKvDIww29h4vZBuG4UY1L9c73JzUMFZ3aR6GvJC5zGlHY2BDefideYoL0An9ltuKsTfSGg/MWdiIMkIZDlnlc2v89JYz1NMjPxiIWSPKzA9rkSfNk3C0p4AK5no40/mh6IqWbCEg0xV97NRlQq7V6HpUIf4N9F9W2z+kMXftiD6o5jSFsYC2VG47khiDI8Ij8kI+deNglhoP7bFg2rnbXKYtO4qDTd8UGXwXVmorIgCpn0VO+8JVBiH3DA6BYv00sJZLqDGgdg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4796c436-70ee-4f8f-9021-08db0e7f10ac X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 11:31:50.6124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CXamz07UJvtQP3kVTKHxsOEQVzxU6ZpnkI1mOPvyxnj1beIrBbI5JJ5BHCNorykwrtKwvCvJskw5BNEKNPEvzjjPG140hIti859JS/Ee5Jc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5527 > From: Xen-devel on behalf of Mih= ails Strasuns =0A= > Sent: Thursday, January 19, 2023 10:13 AM=0A= > To: xen-devel@lists.xenproject.org =0A= > Cc: mstrasun@amazon.com ; Raphael Ning ; Bjoern Doebel ; Martin Pohlack =0A= > Subject: [PATCH v1 3/4] livepatch-gcc: Ignore buildid.o =0A= > =A0=0A= > From: Raphael Ning =0A= > =0A= > Not all .o files generated by the Xen build need to be passed to=0A= > create-diff-object for analysis. The latest example is:=0A= > =0A= > =A0Run create-diff-object on xen/arch/x86/efi/buildid.o=0A= > =A0Open base=0A= > =A0/usr/libexec/livepatch-build-tools/create-diff-object: ERROR: buildid.= o: kpatch_create_section_list: 77: elf_getshdrnum=0A= > =0A= > This file is special, as it does not contain any sections. It is=0A= > generated by objcopy from a magic string of bytes (see Xen commit=0A= > eee5909e9d1e x86/EFI: use less crude a way of generating the build ID),= =0A= > which probably will never change. Therefore, livepatch-gcc should not=0A= > copy it to the output directory.=0A= > =0A= > Signed-off-by: Raphael Ning =0A= > Reviewed-by: Bjoern Doebel =0A= > Reviewed-by: Martin Pohlack =0A= > =0A= =0A= Reviewed-by: Ross Lagerwall = From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:46:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:46:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495161.765439 (Exim 4.92) (envelope-from ) id 1pRtks-0006RJ-KT; Tue, 14 Feb 2023 11:45:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495161.765439; Tue, 14 Feb 2023 11:45:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtks-0006RC-GT; Tue, 14 Feb 2023 11:45:50 +0000 Received: by outflank-mailman (input) for mailman id 495161; Tue, 14 Feb 2023 11:45:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtkq-0006R6-Tc for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 11:45:49 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20629.outbound.protection.outlook.com [2a01:111:f400:7e89::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1bce4362-ac5d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 12:45:43 +0100 (CET) Received: from BN8PR03CA0023.namprd03.prod.outlook.com (2603:10b6:408:94::36) by SA1PR12MB6704.namprd12.prod.outlook.com (2603:10b6:806:254::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Tue, 14 Feb 2023 11:45:38 +0000 Received: from BL02EPF0000EE3C.namprd05.prod.outlook.com (2603:10b6:408:94:cafe::73) by BN8PR03CA0023.outlook.office365.com (2603:10b6:408:94::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 11:45:38 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL02EPF0000EE3C.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.8 via Frontend Transport; Tue, 14 Feb 2023 11:45:37 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 05:45:37 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 05:45:36 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bce4362-ac5d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XtYbk6SKuPuNRGFYr3Eww207IX4Bx8LDR0lESJdO4BLpw3wkLwELjP31BWKDE969RM6RH/Xxh8G9n/fG1b9AzLhOenm4jHpJe2Fn2PA+iKd7lFKBH1vHqU4kbZA7uF2a23Bue7QMk2p1Wr1hjvKvhnZB24sGPW/qer5SCnNVcL9W62PUTRzXL+cRavhSMlC845KYmY3xLRsFHv+QW9c+RuugwLbHUYU+LW0D6Ulu4PaXcPrktty5ZEv9XnlvpZ6hYFvVG33LLSMcVj7o3sLwuOcIWTsAz6ct0ITV51obKnRQ1FsscN4hhto/M8iSVBsdVMpejDUsvpe3wp9zYKKWZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jYDc+mUefrW5wVVo1lGmP39AeBi87Kp9+9ZCKAA3JnM=; b=E5kYEutvtDjAyIMwqIB3FlHmlich9NCDQ6G3E+0X3Q4GiJMjS+H1OB7PaG4JheB2TLL9P31UQlWP7GZlsLeyeEDNGxVa/9Ce0q1UQ4CDTH5jdBa8721dBtI28Lh82mBTgmN1f5yYKAqyKZ9O/Y2PcGLB9I3gfy8uxbI7jR2eoJV878Vxhn/MzCkRtYQWAfoFoVSb/1eJVNBMmgvkwXD3VA4PzmCZrMkBMGO8uOVFuLSdWOX/UY2HsVjIig1tHBCYG381ZdWuGQo5BqsxZlAFu2IEC1tk8t5MnZAe7SgrL5U4RIs1TYp6Gz0kNaTubwaW7Rrp31Nn/jDqYGX7Guef9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jYDc+mUefrW5wVVo1lGmP39AeBi87Kp9+9ZCKAA3JnM=; b=12xxZlsMd+Rm53KOWDVwfXE7q1J+r069K94etKTqbXeq4D/UpS6nXgSnPYq92ZsjczybVwURxIZfT05wTKYTQWt50BLs494Yhew6w3bBgfSzv29vutGQ4VUkFPktH5eQqcRpplz4kO6bGbam3wUcwxqwcqZUFgGzPZIAEoXgWDE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Tue, 14 Feb 2023 12:45:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] automation: Add container and build jobs to run cppcheck analysis Content-Language: en-US To: Andrew Cooper , CC: Doug Goldstein , Stefano Stabellini References: <20230213142312.11806-1-michal.orzel@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0000EE3C:EE_|SA1PR12MB6704:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e146086-975c-4c52-dd71-08db0e80fdc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WApPMhugPnbn+Yw94iLDx4DBjZ/yN6ECMqZgdKTs6Nfx2rGULepnk+0dsQP52SV1rnXRLDvxuwhIMhm5eVEpn9+f/11itLMrTMEqBDicZMyDWTkVbhGmOz+ir30mX95ItsCujreoYi00PEkJYdTopjfBVVTA2TAVx5FRl329Equ2Ae6bpbQyg11ZLfaMNdNAobJ4TJgRp37uPZVdXy041r8/MGvJqU8EPkkbiRSLjve45M6p7QzAeH699/oC5rwSUltEzxNRbDznkSFxmkXWWHmpJXlNNdxoy/T51FoMjPQXK1YmhpPlk4cgNSlH8BRACQWIBYCgF6xI0U0FKkNz0jqqgAyPoRXvtwd8JnQiB5e8tnyvzDZYbBIfPKnulttZThwW06m0w3ooUiLG5vkRVv+OSdkHPLV2zs1lnESg9Bh2B1bdt4DInYjbWaHgtcMdUyddqKgzWPoJ9eM8USzluW7n1N9pZvauLgchpSDaA5boS7367RNz4+OYAwbe8pXYR72w7dZHc96YtDNC0bmw+ZBBJcULvOb+YVMpeDWLuIVGuBIYNQNSnw5GtGWFTn4YOdwZteTrZv1hqLwfn9loyR8hJjxq+vgXyVrexC1jQppVYeR5Fz38Kkwlmfp3NcAGQVPGerjGGQsNG+inhxOP6DKcPXxoBWHgMl6+bmQ49Npndqz5ZqZPdq0eKfVmvwALauZbNihcWSs3BBSJOTwl1PslfDH0EHGQ0zu3OP2HoXOxOF5GWOOtg1BFV2v0VG3+ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(5660300002)(41300700001)(44832011)(31686004)(2906002)(70586007)(4326008)(70206006)(8676002)(8936002)(54906003)(16576012)(110136005)(40480700001)(316002)(53546011)(26005)(966005)(36756003)(478600001)(186003)(40460700003)(2616005)(336012)(426003)(47076005)(36860700001)(82740400003)(81166007)(31696002)(356005)(86362001)(82310400005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 11:45:37.9056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e146086-975c-4c52-dd71-08db0e80fdc9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0000EE3C.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6704 Hi Andrew, On 14/02/2023 12:00, Andrew Cooper wrote: > > > On 13/02/2023 2:23 pm, Michal Orzel wrote: >> Add a debian container with cppcheck installation routine inside, >> capable of performing cppcheck analysis on Xen-only build including >> cross-builds for arm32 and arm64. >> >> Populate build jobs making use of that container to run cppcheck >> analysis to produce a text report (xen-cppcheck.txt) containing the list >> of all the findings. >> >> This patch does not aim at performing any sort of bisection. Cppcheck is >> imperfect and for now, our goal is to at least be aware of its reports, >> so that we can compare them with the ones produced by better tools and >> to be able to see how these reports change as a result of further >> infrastructure improvements (e.g. exception list, rules exclusion). >> >> Signed-off-by: Michal Orzel >> --- >> For those interested in, here is a sample pipeline: >> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 >> --- >> .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ >> automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ >> automation/scripts/build | 11 ++++- > > I'm afraid that I'm going to start pushing back on any more x86 jobs. > > We're already at several hours to get a run out of Gitlab CI, and that's > assuming none of them hit networking issues, and outside of the typical > European working day, when patchew is busy churning and not reporting > the status back. > > Right now, there is vastly more ARM test resource than x86 resource, as > evidence by the fact that you're never waiting more than a few minutes > for the actually-ARM tests to complete, so adding more x86 cross > compiles is compounding the problem. > > We need less x86 testing, or more x86 resource. Probably both, because > its now so long that even I'm not using it as a pre-push gate on all > changes. I'm aware of the problem you described. AFAICT there is nothing stopping us from switching completely the arm32 cross builds from x86 to arm64 container. It is just a matter of creating identical container to unstable-arm32-gcc e.g. unstable-arm64v8-arm32-gcc and using FROM arm64v8/debian:unstable. We need to keep the old container for backwards compatibility. This way, x86 runners will only do x86 stuff + riscv64. Are you aware of anything preventing us to do so? If not, I will push a prereq patch to switch the arm32 cross build to arm64. > > ~Andrew ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 14 11:58:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 11:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495171.765449 (Exim 4.92) (envelope-from ) id 1pRtx3-0008B7-Qa; Tue, 14 Feb 2023 11:58:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495171.765449; Tue, 14 Feb 2023 11:58:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtx3-0008B0-Nv; Tue, 14 Feb 2023 11:58:25 +0000 Received: by outflank-mailman (input) for mailman id 495171; Tue, 14 Feb 2023 11:58:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRtx2-0008Au-Vm for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 11:58:25 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0188c3d-ac5e-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 12:58:22 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 06:58:14 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB7097.namprd03.prod.outlook.com (2603:10b6:806:332::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 11:58:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 11:58:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0188c3d-ac5e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676375902; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=HaK3ePrXX9nflu6LYWWlGatVh+v1CVHg4ga9PW2+vkw=; b=G1h24s+OBFVbqcVv0Kldr7Ymx8p6q3acPeXISD4Pw2UAD9T2fAnbK/Uh 3HVw5MASBpEDul7eLAL0kPeP0AJg60GBa2egwZdVtkxr/b4ifep94SFzF QWIWyE6E+Z4uQj4wdWdyUgA5zWsAopPVW5udkew8/vt3HGUBXUtNFjXXi E=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 99382226 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:di8Frak8LKYWxJt2LCPCRVno5gxNJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdWDjTP6qMNGejc4sgbY218xkDuJCGyIJnHlE9+y80ESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fcqAyE8Uh+vvM6R/uqfGtlyit8eDuC+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDReborKQw3jV/wEQuCwVGFlScg8WaoVOmfvNhJ HcypgUh+P1aGEuDC4OVsweDiHuFtR4VX5xXCf837CmEz6aS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTi7IyQSIEcJbDUISgZD6N7myKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx74j/luYO3qS/uFrB0zSlo8GQShZvv1uGGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:XlAzJ63EBeQiXT/Wz9WATQqjBIgkLtp133Aq2lEZdPUCSL3+qy nIpoV56faUslYssR4b8uxoVJPrfZq+z/9ICOsqUotKBzOW3FdARbsKhbcKpQeMJ8SUzIBgPM lbH5SXp7fLfD5HZWqR2njbLz6AquP3lZyVuQ== X-IronPort-AV: E=Sophos;i="5.97,296,1669093200"; d="scan'208";a="99382226" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frWxiH/YVYZa2EZp8WF6dsYdDk+/g2nLn7UcbQpwT27EnM8+39SSg5XrlAuFPmVMM/rKnQwmulUfOAgMll+rhfEtnJpbEPwbrj9DF9G7MrvFZjSx43CHKKXrNtH8ayKDaCSNfUhOSCNR5M8kaydcCCoLh+gfauB7BouTmLweQGtF4qmaNeVbTLGQ+y4lUCY7bbIxmiujJaKfx7aWMwnspxN11P6DrScvpj3LrJboGxiOAP9etjVEL6YME3JheBWcpXW+2aHVhNu7jB6GO3UV64NCSb6XoMsyzqVNhzBJXGj2UpOUw9mv2Uq++tKBM06S+JAz52jYqNZjTbHLqmUJRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=spQBPUzJIPrxQeUq++zvMHshUrUUmFLw95ug0OZlx68=; b=QrQhyv0xagcqtmByfUXi02yE+QfiWoovRYYLNClHC0lO12ZH82UcYJ+H8XkrRkiDKNonQkGNk66WTwvnVyZw/QMeFhAmkvCPBIyg+Agf/D5ckhsbxYhHTYp9zYEl1Nv62eI2i6g/WcQwEQJlIipkzNtJj7cuKHdDVBxvLymUQhNnKgqwkrFN8raeI1QeuCVsjgxL8b/kgsPyvj0NEdJArofHDI/GpbIXeBS0aoBdu8E6WeBk66cD38kKdC901qm+BLFGEHP8Mmc3oibWAkDnIRFfm2qYG1lsN5bD3KRNbmx2KGuR5riuMTTTQ7xJbFMW3tgi/07PH7/nfAoiq3wbMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=spQBPUzJIPrxQeUq++zvMHshUrUUmFLw95ug0OZlx68=; b=ULvr2wESFgIZ+rXfLRi4D4CV5FU24kB8RgaXdo1wvK6RMyNOpdRS0gvWptSAIfzOtFER1VGbfqQ81izNSLQuifKj/3C8T7WEj7jgnB/OCILR9A5YDqI3G5meMIBw8zr6zehT2zrw2V5R21hH/KuFcDGElhRsVEuurokg1gnI6Pk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 14 Feb 2023 11:58:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] automation: Add container and build jobs to run cppcheck analysis Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230213142312.11806-1-michal.orzel@amd.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB7097:EE_ X-MS-Office365-Filtering-Correlation-Id: 09f869ab-923e-4464-9a6c-08db0e82bdb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AUDSPBTA9fNbkKaFlTDwZV2aH8JNINBOuHdwz1Oz8L7CbKnjZsVw3plpD20CXxIGHXIeQiiTABrDCCXiTcP7GtPWh0GaFk33H/fNxeWiOxH+7UGxVx/dFOC+75eRnuEiBN3HdXjUAX0N4r+rJSp0B3rRGBKGf8mUa615hv299g57GrNVAMvhjG+AZmVU5lSynV1RVyWMw++qJnhCPrlpRl8eKNw7tmmjVlIS4vkGQmafM6bTEOBruoaYlipqhsf3i0FasLYShxRwZbnHMaPJwTYCcWDuKzg1zPXJl9lSEY5JArIR4TUeHpJh6XUHo+wExaRFTietzeUBrqpDylf9rqPZ5pIYanvGW8bSU9RHpkKVsR9mhsHzDGeJkFaxWI1a+9aj4jtwh0ftU2LBD8fE4CPX+nb24hVZp47+oBMis46whj9waoSOc5GtG/ettd67GnOOBxnRcPF+lja74xsvc8va2DKSNhIQxHYPyZY5KnZ0w4ETE8gSv1/S9w0mgk679lQJnTmd+1TcnNhq5bsPW8+cBAttoRkRJw2tfIIBSY000+ewbqsBGKFg8L9lPMMsO2ovyITslNFyWLO3QS9h6mhC9xxikunktgPnzUju5JzKH4txgFth8YCavGqBv4I6Up/Z3gZA7C9R2GwZZe3GPkVfqT1u+O53qywjcx52ao6F1CUpQafhnsFN5KdFeaftchyWusWYnXYwKgzAEVWvKf2824qlQgOPJqr262do4aw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(451199018)(36756003)(82960400001)(86362001)(31696002)(8676002)(66556008)(6486002)(54906003)(316002)(66476007)(966005)(4326008)(66946007)(478600001)(2616005)(41300700001)(8936002)(5660300002)(2906002)(38100700002)(186003)(26005)(6512007)(6506007)(6666004)(53546011)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHpxeXdlaDJmL3VkL0JKRkNoMTN5TUc2Q2FOSW0rTnVOb2tibGFmcW83L09k?= =?utf-8?B?OExIdk9vdkU0bmZ0a05TSXB0NkNBd3h4eEQyYndnY3lEVjlPYXBHRXEwL3Rp?= =?utf-8?B?TDF2UTZ4Vllxa2lYTlFoU2l4WkNoT1hsTEpyRm52Y3lnc05jdU9vT0pxQUFj?= =?utf-8?B?TVkyTjZWNzRrV0xGQm9iS014ZmNLalV6aEk1Vjc4M05XVzBmUWZKT3FCbi90?= =?utf-8?B?V0ZyYWJPVWFRTWpQOEo1a3A0VlppOGNpQjljN2xmWDN1bzZUUjBudlBSc05p?= =?utf-8?B?VHB1YUxkSkFFa1lxdmZ2T0s4QWFnWnpyRm12OGFzQ1hxWmlZRXNpVHlFcEV1?= =?utf-8?B?SVNqMUxDTTdUeURqWlJXeTFId0JPemFabFVBTi94QzFjWExEUWRKVStKWGNO?= =?utf-8?B?eUVCZ29meWN5Q1Rhd2lVUDRHazZsUi8zYVJVK2x3UHlaaXdrN0grMTdGWGIy?= =?utf-8?B?bEwrcGpRcnZXSkE0YlhvSEZmNjRVdnU3VU1XVVFqNFdyN1dBOWVZdVB4M0dN?= =?utf-8?B?VnhZcXRyZlVNRXRwVEhkWGhNMU5YUm1tbTBKL2krUSttT2xtNnN3N3lwR2ZV?= =?utf-8?B?N1dSZ2pIcHF4UHIvREptdlVaSGZDK2s0WWowVDJ3UDcvMUpYUDNIb0FhK2hO?= =?utf-8?B?OC9IOTZHbCtuWGhxQ05jQkFsN2tqK05FbGtaTFJZR1FTTGZZQ1pFUTh5RFZD?= =?utf-8?B?V0tuMnVhL1pMd0k0bUM3QXBaRFNrRTRwQ21EQ3lJUnBnYWJDZGM2OVZzb3ky?= =?utf-8?B?cktXZzhvdThXVGxsNlRyMW9Vb0lSMzVOeDJuQzZVVGx6SmZzcVhBOCtjMm5K?= =?utf-8?B?RFhXVEF6NkdOVnQ0V09iL2JvZUlrMUEvcUY5dng2WnFGVXNZOUNWRDYramVF?= =?utf-8?B?ZWVmci95VkJiWTZlQnRrOW92b0pNUDRKUjhVVGxjcjhRdFYvV0ZTSWgwQlcx?= =?utf-8?B?NmVOM2swSWNFeFhZRy9selZZaDFXeG9JWE1YdklVY2c5RnRaK2J1MnNFT0hl?= =?utf-8?B?dDBrbHZ5WVVlTVd2U3ZIVG92b25VNkFncGJzd1VlNGdIYzlBUW83MlBwa1My?= =?utf-8?B?TFRscE5QZU8wcXlEZ1FEQUIyRlFhMmxYa0ZZQjcxb2Nhc1lDWG1qbEV6NDZi?= =?utf-8?B?cDBVUENGVW5EdXJCS250UjU2WXV5bFZlMmpDQW1tOVI3TTdaeTgvczloZG00?= =?utf-8?B?NDRvTmlOZEp2bjM3N0M1eFAyaXdyZStkeUptOXJ5M3JKNHBGSlloa1VWWFJU?= =?utf-8?B?dEpwVzBuSHE0RkJZemtjWHR5czZXUmpDeFdyNjBEQi9KU2gvRW9ibUhVK2Uy?= =?utf-8?B?ejJTeXgxZ2hFZ2VaVU43Mm9ncTVqcTlrdFJWK1Jhbjk5UHoxUFNIZm1TZjZ2?= =?utf-8?B?bmFySXVhdSt5WmlRdEh2SER3eFF3QVYzOUt4OGVYVlhSVFB4S001VFp0YmRN?= =?utf-8?B?RUdBVm9xbnhDY0pvTk1MRDFTL21qdk5iQ2svWjV1N09maElMbDd1Smh5M0ZJ?= =?utf-8?B?MFIwcWMzbll5ai9tZVZ2UzhETmVkUi9IVGttQkhEQk9xbzc4amlXbzJUUldB?= =?utf-8?B?V1R5OHd5dmVzcXl5Y2FvVzZnRXBab1hsYUVpNi9zVy9yNGRZS3pzUC9xWjZj?= =?utf-8?B?aXEzMWhNWjE5aTdyTnd3UE1Pc0VTRkI0WS8zemkydFIwbDJ3TmNia2FWcU1v?= =?utf-8?B?aHRHb2hOZExRSktKcDQ0MGphM2J3M01UdFJLOWFZMjJYNm1qTlp4K0c1WVY0?= =?utf-8?B?OE5FU1lTcVAxVW9SVXdSM3YzZGp2TUZyS2NjWldZTkQ0L2RFbDJnYjJhd2Yv?= =?utf-8?B?TG9BYjJ6UFh6UTlEaXVvdVRaKytCd01nWHgzaHVzQ0h0VWIxa1p5SW11VjIw?= =?utf-8?B?V2h4ZkIwNitjdE82dDlaRnZTWk5RNGk0WjRUTFh4WjZRV2QxVmo4WHdpK25s?= =?utf-8?B?aFprWkNHZFpPRVRNbGtNT1g1NlpQaFpndC9mc0FWVmkzZ2FVVnVJbmFaTURK?= =?utf-8?B?OXlNNEh5YjFtUU5lTUJQV25ta05oSkVlc0ZuT2tDd2lkVW1vYXcreFRONmZ0?= =?utf-8?B?QkNPNmVFOEFZV3FGYXltTmczaUdkbnd6ZG5LVUN0M0hvMW1yZFk1SmNSR2xE?= =?utf-8?B?Z1hURktiYjRpWWVzMTVBd2hCM2UwdlFnTTFiQ25RMFdhRjRqeXJLVFk4N2xn?= =?utf-8?B?UWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9n3QmBBcjDN79s5xBes5vlWpJvP+t1rYbeBntZD01G9/rOplBSXvSA0vEa0N63e+hnDzRDuPm2jGkbJA5scKSbcPAjsHaeXevzXsV1tAEaq8zSGp8NB40Yr5zL/Ks/hjISGNv2vmSq5vD7jMjSiCxVUjE04KYHBsbFVpqV5WUYR1eO02j6wrh13NM8bGvddCJrd/KHTr0ShZl+VWyb9FzWRmek567rzNIwvVaiEtDzrD9cINVi+RgxUGhGOkanGh7npDTPNauepcjCGcGwYW4RjDWTjMrWh2AKOycS2L3Y8PmjLJ8QjtvAwfNOSQjnGG7m1R3t2wAuXAfU+34tbXUlqfGGzEC1vitdA+ZV+bRgJJlFr4S+UQPqfFwrEFl+FoQg/b9jlVds5yLOFVpW0OPyPRN3dk+gEv1Jgkw4HT3/T8idqa21cuppNheCbViPqfdS2sf1mpNinzkkHq/Dgw/bDaC+vrn3Q8j2byxyA4RHcLigqNl9C/ffPqpwNaNDtJgqrT8ZqfSAhqVxoN3Yrnt/DEUP+jIaEVA92RCm6lyv5YtpJwJm/MQJ5WnQoREi5YL6QOz4BeTBpLnjGa56Vd5o5Qf+kckWJS2DljAE+f7BTCOiGkv1vDI9/RnKjNegghsbjZFRKw1ge2cFEr1MGsfmjYxW8yO/F6u2FOobbyF32cUnDbDrGxXmCBsDGMkWmGkgcwSAM9pbDD6qta4onOjtFCjkENXPInmYWFjX62rO8whhz49kiVs/HbBd0GFQD3tj5b7grxxHiIdvAzMtrHYDf8k5/SffX/iRIP2MWdIeUXsn0lP1lvTadR5R8vmnu0NseF1upkA5k93zHuWpbBmp8i65kh69ZqD5M7h0M33Cg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09f869ab-923e-4464-9a6c-08db0e82bdb9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 11:58:09.7308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0BxF18EoGd5II0/O5/d/VXmbDOh7TF0svO0jr5lkuCWlo9E6QcLmESv702r1QOEFtmqFePEGY/oUXjIc5mq0+jGws3MZZwdPLuQRGka6SXI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB7097 On 14/02/2023 11:45 am, Michal Orzel wrote: > Hi Andrew, > > On 14/02/2023 12:00, Andrew Cooper wrote: >> >> On 13/02/2023 2:23 pm, Michal Orzel wrote: >>> Add a debian container with cppcheck installation routine inside, >>> capable of performing cppcheck analysis on Xen-only build including >>> cross-builds for arm32 and arm64. >>> >>> Populate build jobs making use of that container to run cppcheck >>> analysis to produce a text report (xen-cppcheck.txt) containing the list >>> of all the findings. >>> >>> This patch does not aim at performing any sort of bisection. Cppcheck is >>> imperfect and for now, our goal is to at least be aware of its reports, >>> so that we can compare them with the ones produced by better tools and >>> to be able to see how these reports change as a result of further >>> infrastructure improvements (e.g. exception list, rules exclusion). >>> >>> Signed-off-by: Michal Orzel >>> --- >>> For those interested in, here is a sample pipeline: >>> https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/775769167 >>> --- >>> .../build/debian/unstable-cppcheck.dockerfile | 37 +++++++++++++++++ >>> automation/gitlab-ci/build.yaml | 40 +++++++++++++++++++ >>> automation/scripts/build | 11 ++++- >> I'm afraid that I'm going to start pushing back on any more x86 jobs. >> >> We're already at several hours to get a run out of Gitlab CI, and that's >> assuming none of them hit networking issues, and outside of the typical >> European working day, when patchew is busy churning and not reporting >> the status back. >> >> Right now, there is vastly more ARM test resource than x86 resource, as >> evidence by the fact that you're never waiting more than a few minutes >> for the actually-ARM tests to complete, so adding more x86 cross >> compiles is compounding the problem. >> >> We need less x86 testing, or more x86 resource. Probably both, because >> its now so long that even I'm not using it as a pre-push gate on all >> changes. > I'm aware of the problem you described. AFAICT there is nothing stopping us > from switching completely the arm32 cross builds from x86 to arm64 container. > It is just a matter of creating identical container to unstable-arm32-gcc > e.g. unstable-arm64v8-arm32-gcc and using FROM arm64v8/debian:unstable. > We need to keep the old container for backwards compatibility. > > This way, x86 runners will only do x86 stuff + riscv64. > > Are you aware of anything preventing us to do so? > If not, I will push a prereq patch to switch the arm32 cross build to arm64. No issues that I can see - I think that would be a good move in the short term.  And it's also something that should be backported to alleviate pressure there. On the x86 side, we also desperately need to prune some legacy things.  Guess I'll get around to that is some copious free never. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 14 13:02:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 13:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495190.765460 (Exim 4.92) (envelope-from ) id 1pRuwo-0008J2-Qf; Tue, 14 Feb 2023 13:02:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495190.765460; Tue, 14 Feb 2023 13:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRuwo-0008Iv-O3; Tue, 14 Feb 2023 13:02:14 +0000 Received: by outflank-mailman (input) for mailman id 495190; Tue, 14 Feb 2023 13:02:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRuwn-0008Il-Jk; Tue, 14 Feb 2023 13:02:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRuwn-0007X0-Gn; Tue, 14 Feb 2023 13:02:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRuwn-0005M5-6X; Tue, 14 Feb 2023 13:02:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRuwn-0003cF-67; Tue, 14 Feb 2023 13:02:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MDT53qtYZz0P3fy9lbZ5DTFCByLaPX8FYNvDX+JnHmc=; b=lS70gaqmyq41ofCW+5BEP9tgzd AYkZKDyMSq+eDYmgIvMO75BkSywA6QLAhrmnr2zP7pGrP1jSFceSzw/B87YYkbtZzE5Kdqemj8Zq7 U19e49q0F0Mdrrd5dPZ40EGdPQtR0TVtySGp6MQmmu2U/2R69mNZQGfUoZ9EUJfp6c3Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177242: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=c433c2434c0459df98ed3355ef615e341acd9009 X-Osstest-Versions-That: libvirt=092176e5ec2f45d3b56a9e131c5237c52712d804 From: osstest service owner Date: Tue, 14 Feb 2023 13:02:13 +0000 flight 177242 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/177242/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt c433c2434c0459df98ed3355ef615e341acd9009 baseline version: libvirt 092176e5ec2f45d3b56a9e131c5237c52712d804 Last test of basis 176926 2023-02-11 04:20:15 Z 3 days Testing same since 177242 2023-02-14 04:18:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Peter Krempa Piotr Drąg jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 092176e5ec..c433c2434c c433c2434c0459df98ed3355ef615e341acd9009 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:08:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:08:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495199.765471 (Exim 4.92) (envelope-from ) id 1pRwuw-0005Uj-Vm; Tue, 14 Feb 2023 15:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495199.765471; Tue, 14 Feb 2023 15:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRwuw-0005Uc-T5; Tue, 14 Feb 2023 15:08:26 +0000 Received: by outflank-mailman (input) for mailman id 495199; Tue, 14 Feb 2023 15:08:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRwuu-0005UW-Vj for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:08:25 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69e86ac7-ac79-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 16:08:20 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4CE1A5C00E9; Tue, 14 Feb 2023 10:08:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 14 Feb 2023 10:08:18 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Feb 2023 10:08:16 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69e86ac7-ac79-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1676387298; x= 1676473698; bh=elzZ43LKNtskgQb+dtRg8bbRNCKz8uQV13+HixszXXw=; b=N 110Tcn9D2Uj0Uv03GzqmQSFJnlv3ur3LQcVWbYZ/mMfCHfkioAgPnzJFgSsfHMEG ar/abhLEF8DAKi58gPlkJGAkfZ836ualJblNnaxznOLV6xi2vX3pDfHd6SBn2LD+ R3a2kLuaYyPjQuDOAjDEXSW9/dvJ02mCTkwbSM6Os7W7f3MDIgno9OKUlpRsZCBv u+bP0DeVmGTmgNruxUpdmHzpnA9t263x1MFY6fq+5UONkIZFkccl/E+eIzlV8s9l fZtidTL0kWZFg20AS36Bh7G6ogR6+7YhQt/tf0L9LjxAIL43Dfw9RG/plpB1wNvD g3knDshKS0JjwkPOQ7htA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676387298; x=1676473698; bh=elzZ43LKNtskgQb+dtRg8bbRNCKz 8uQV13+HixszXXw=; b=FF+oibrueivLy4Vkd4Ee9TmjKrL8N18HpPdXEv7Uyv6E a4PjO6MeUiO/Ugs/VmQ1XWYax50qok+pTJ4APDD3gcj/G0NY4rp3brpL2szW3Ncn fK3+8tpOavrIF0x6xOB++W02Kx7vDNi3Vsx5IzaF2fAPHRv36wrbkTY3UZiZcgfT 66zWouod/15ZlWMEM0Oy1xB5KzqyKcuPDE0rZWZFZWiG0PQgVI/CcY2iaZ7lj2C6 9Ok9ahKPAJL8VYOlxPd9gFLlw/+34ISbqdYtptwmoB18JIW2sQINQYuU2sx8vjbk r4lm16DPq+bQKnuHUdE2UT1yhf0/GoPGBbYEscOPVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeifedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Tue, 14 Feb 2023 10:08:14 -0500 From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] xen: speed up grant-table reclaim Message-ID: References: <20230207021033.1797-1-demi@invisiblethingslab.com> <5fdc17c1-4222-aea2-c1d1-be8b15b7f523@suse.com> <763838a9-acd5-b330-6165-6c288973d51c@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DbwWERBYmiTeYpZW" Content-Disposition: inline In-Reply-To: <763838a9-acd5-b330-6165-6c288973d51c@suse.com> --DbwWERBYmiTeYpZW Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Feb 2023 10:08:14 -0500 From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] xen: speed up grant-table reclaim On Tue, Feb 14, 2023 at 08:51:09AM +0100, Juergen Gross wrote: > On 13.02.23 22:01, Demi Marie Obenour wrote: > > On Mon, Feb 13, 2023 at 10:26:11AM +0100, Juergen Gross wrote: > > > On 07.02.23 03:10, Demi Marie Obenour wrote: > > > > When a grant entry is still in use by the remote domain, Linux must= put > > > > it on a deferred list. Normally, this list is very short, because > > > > the PV network and block protocols expect the backend to unmap the = grant > > > > first. However, Qubes OS's GUI protocol is subject to the constrai= nts > > > > of the X Window System, and as such winds up with the frontend unma= pping > > > > the window first. As a result, the list can grow very large, resul= ting > > > > in a massive memory leak and eventual VM freeze. > > > >=20 > > > > Fix this problem by bumping the number of entries that the VM will > > > > attempt to free at each iteration to 10000. This is an ugly hack t= hat > > > > may well make a denial of service easier, but for Qubes OS that is = less > > > > bad than the problem Qubes OS users are facing today. > > >=20 > > > > There really > > > > needs to be a way for a frontend to be notified when the backend has > > > > unmapped the grants. > > >=20 > > > Please remove this sentence from the commit message, or move it below= the > > > "---" marker. > >=20 > > Will fix in v2. > >=20 > > > There are still some flag bits unallocated in struct grant_entry_v1 or > > > struct grant_entry_header. You could suggest some patches for Xen to = use > > > one of the bits as a marker to get an event from the hypervisor if a > > > grant with such a bit set has been unmapped. > >=20 > > That is indeed a good idea. There are other problems with the grant > > interface as well, but those can be dealt with later. > >=20 > > > I have no idea, whether such an interface would be accepted by the > > > maintainers, though. > > >=20 > > > > Additionally, a module parameter is provided to > > > > allow tuning the reclaim speed. > > > >=20 > > > > The code previously used printk(KERN_DEBUG) whenever it had to defer > > > > reclaiming a page because the grant was still mapped. This resulte= d in > > > > a large volume of log messages that bothered users. Use pr_debug > > > > instead, which suppresses the messages by default. Developers can > > > > enable them using the dynamic debug mechanism. > > > >=20 > > > > Fixes: QubesOS/qubes-issues#7410 (memory leak) > > > > Fixes: QubesOS/qubes-issues#7359 (excessive logging) > > > > Fixes: 569ca5b3f94c ("xen/gnttab: add deferred freeing logic") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Demi Marie Obenour > > > > --- > > > > Anyone have suggestions for improving the grant mechanism? Argo is= n't > > > > a good option, as in the GUI protocol there are substantial perform= ance > > > > wins to be had by using true shared memory. Resending as I forgot = the > > > > Signed-off-by on the first submission. Sorry about that. > > > >=20 > > > > drivers/xen/grant-table.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > > > > index 5c83d41..2c2faa7 100644 > > > > --- a/drivers/xen/grant-table.c > > > > +++ b/drivers/xen/grant-table.c > > > > @@ -355,14 +355,20 @@ > > > > static void gnttab_handle_deferred(struct timer_list *); > > > > static DEFINE_TIMER(deferred_timer, gnttab_handle_deferred); > > > > +static atomic64_t deferred_count; > > > > +static atomic64_t leaked_count; > > > > +static unsigned int free_per_iteration =3D 10000; > > >=20 > > > As you are adding a kernel parameter to change this value, please set= the > > > default to a value not potentially causing any DoS problems. Qubes OS= can > > > still use a higher value then. > >=20 > > Do you have any suggestions? I don=E2=80=99t know if this is actually = a DoS > > concern anymore. Shrinking the interval between iterations would be. >=20 > Why don't you use today's value of 10 for the default? Will do. I now remember that the DoS concern is that the kernel could be made to use excess CPU trying and failing to reclaim memory. > > > > + > > > > static void gnttab_handle_deferred(struct timer_list *unused) > > > > { > > > > - unsigned int nr =3D 10; > > > > + unsigned int nr =3D READ_ONCE(free_per_iteration); > > >=20 > > > I don't see why you are needing READ_ONCE() here. > >=20 > > free_per_iteration can be concurrently modified via sysfs. >=20 > My remark was based on the wrong assumption that ignore_limit could be > dropped. Even if ignore_limit could not be dropped, READ_ONCE is still necessary to avoid a data race. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --DbwWERBYmiTeYpZW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmPro98ACgkQsoi1X/+c IsEScg//XbsDTP2xk1rqtM2Zbnp1eJEceVGpdrVFez4q3RFLWctIb9YSYiagJbQ5 R4zqEJ/PbwpciLBko88l/elC4UrdlJbKN/d4Fo6/nBVNQMVHbpYOgz5DSEQ0Njzs Y0k15KZ3yxBvJ18PdF6y+IE+fgCBfx64VqNZKdllFcM7YOOed3d5F/wn/AiaHhag lGbFfCphhR6jrRhry2GUauK+akrbJB7LPH/j1vA0Q1kjZTHA982Py2GWfFb/SaoC 9k6Diyrbeis9Wsu+qya39wHF4+UOExV2eaD6YYUBr2/6prikGe9f7lp/W9SrZi3V h9agm9hIvM8HTaIVi6pZuUNoSDik5/ws+g9DY0DurGeRkhjb4Vq5ctofXsBR/WmB BJWJYVs2whBRefrZDsNfsApvfvfj37PWwjMC8JE6uYtijglY6l2DsDfKYNjzTPPq UcMeCQczTxQFrBUCct1cMT00FeBQRms8gcYk4eBjpj9be7omcMcJORYFQ/ty0NXO Tm9imaZAqEJ0NmTkTYbe3zHYaiLUVi34e2QUyZBonM4An9DKPslOsFq2NhuBkltm fn48SvAm5T6239eFjfZKGZ4BZs2KbQb/6uqQbUkddGOZR46knHonUWoLo8QpjExj R3BGygcamJdqvlzDBD7swX7y5oDSAApKMPtM4DgaeNH92megoHA= =Yk/p -----END PGP SIGNATURE----- --DbwWERBYmiTeYpZW-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:37:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495207.765483 (Exim 4.92) (envelope-from ) id 1pRxMt-0000vA-9o; Tue, 14 Feb 2023 15:37:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495207.765483; Tue, 14 Feb 2023 15:37:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxMt-0000v3-5T; Tue, 14 Feb 2023 15:37:19 +0000 Received: by outflank-mailman (input) for mailman id 495207; Tue, 14 Feb 2023 15:37:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxMq-0000ux-Ng for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:37:18 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 743dda42-ac7d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 16:37:14 +0100 (CET) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pRxLi-009fnp-0h; Tue, 14 Feb 2023 15:36:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A87A4302E5D; Tue, 14 Feb 2023 12:22:17 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DC38A20B4E943; Tue, 14 Feb 2023 12:22:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 743dda42-ac7d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b7LTeIXXRhjHNZKLwP2eUBOvy8A+bNKHoN43DEwbShs=; b=ZJ60tcltd9tUxPXvvq0xlFyIL6 54nH3MAS0etSF71Vg31JUcBLXpBh0L+qyMjnH0cxJZnhy+fNVHyAzg6tUysiafwkXr6EGN1bBLvH8 EYt+sO5hnoq5doF2AgnlkNiLoWPL6qsbM1FtrRNneXwa9ml2PbJyjXR/IJ2cuIvmKzCrsRHcWDyHW pNejNvINpl6m6Rt/Z/UQdUP58lzgNnEq801+MLxXOmpukMds0dFq1ldemt3EOaEF2sESv/EOD4B5P 2whxU1KzDZJfq7oBespZomiCoXfkBFdsr7hb1C+wZ5VkYomLpJgiFCa2lMYkziYJc7yEVbHqvKP/D ysJjZYXQ==; Date: Tue, 14 Feb 2023 12:22:17 +0100 From: Peter Zijlstra To: Stephen Rothwell Cc: Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Xen Devel , Per Bilse , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: duplicate patches in the xen-tip tree Message-ID: References: <20230214124700.22f0a62e@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9N+tlQnp6RT7SrtH" Content-Disposition: inline In-Reply-To: <20230214124700.22f0a62e@canb.auug.org.au> --9N+tlQnp6RT7SrtH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 14, 2023 at 12:47:00PM +1100, Stephen Rothwell wrote: > Hi all, >=20 > The following commits are also in the tip tree as different commits > (but the same patches): >=20 > 415dab3c1796 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspac= e") > 336f560a8917 ("x86/xen: don't let xen_pv_play_dead() return") > f697cb00afa9 ("x86/xen: mark xen_pv_play_dead() as __noreturn") >=20 > These are commits >=20 > 859761e770f8 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspac= e") > 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return") > 1aff0d2658e5 ("x86/xen: mark xen_pv_play_dead() as __noreturn") >=20 > in the tip tree. This was intentional (dependencies) and the plan is to only offer the tip branch for merge after the Xen tree goes in. --9N+tlQnp6RT7SrtH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEv3OU3/byMaA0LqWJdkfhpEvA5LoFAmPrbuMACgkQdkfhpEvA 5Lq1xQ//X0sV6gQk3sHy5WQPnx4D4OcH0oiOyu9ytASjCEVL/wxNlB3TOAW9TV1e eWTTdx3NoTI8A2i3u8SEYzlGN6+p/jCJdIlfwyeRTpJ5l6f0U+xKN2LYc7yn7h34 faixh10wtlG//RzdJjVsOMkORjKiZuV7BYSViVNu9Trc5AhcpP53wevx5wk7VN9E wTM7wJM6r3/g3SGM7f5ZNB4rr0SnZGoNNcO9dEeBOPK5PR5iGSQJtPMSS/2lKk5i KQimr0N7jR6aRPzsN0+zAECnE0WW71N/4UCUZ5tGJIMZreCBhZTyXC+D+tTerxkM C53RaFq6zRx+wQVN7waVHLuboKKO5vaGYrt8gy9sVkaoo6sdtz94QuHldG6FCg4b 3APdN43UCd0vB2WX4yEmnAsgOY4AqkebEAcFyCEME+nEpA2zr/tjCXG7JfKqQNG8 Ujy84aM2mKs4fVmaPhunXCv9IxHLcyTriVsnmcYi+gn68913NsFVqHiAr4/Lf9dO QfCyAqWEcxxfoqiy8ebOumivjXNn8Mz5lSWD/oEJTI11rtzleRJLwrt7W9JE6gI3 HRZK1/x7Mc8kbQIvACqx4paxa0B/8+/67xruENgjv7EbUxjIoX7uYeIixfol7OMf eKgsJ25N7IvxWnSDUtXeHI5BvyKHX/4B/aVacyyDJHva4R5dHQA= =YOXl -----END PGP SIGNATURE----- --9N+tlQnp6RT7SrtH-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495213.765493 (Exim 4.92) (envelope-from ) id 1pRxOT-0001XL-JY; Tue, 14 Feb 2023 15:38:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495213.765493; Tue, 14 Feb 2023 15:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOT-0001XE-Gg; Tue, 14 Feb 2023 15:38:57 +0000 Received: by outflank-mailman (input) for mailman id 495213; Tue, 14 Feb 2023 15:38:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOR-0001Wn-H1 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:55 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af75abb3-ac7d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 16:38:54 +0100 (CET) Received: from BN8PR07CA0020.namprd07.prod.outlook.com (2603:10b6:408:ac::33) by PH7PR12MB7844.namprd12.prod.outlook.com (2603:10b6:510:27b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:38:50 +0000 Received: from BN8NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::3a) by BN8PR07CA0020.outlook.office365.com (2603:10b6:408:ac::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:50 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT016.mail.protection.outlook.com (10.13.176.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:50 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:49 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:48 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af75abb3-ac7d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l76iyEkYIughuGzCdunfHXJJDhYmt9tTpraRDyFf5LbzYUY/SJZI1CHz4aeDBthRZNhv8dx4TMJwipE7OcSaeotw4sH+U3P9RFr7XF6QkvxOKH5sDkklbDILiLO12HI0IowsUMUh0I/E99x2RvBpl1CZBilVv/kSXLzXT0HjXNhIK9mdBcvuXfKq6lEQEKxiTNiuY856XIxV+8LAFNzMlMXncrUZbXFVW89iVKJIZE6YaqVymxpSPgKLZhgQpELDknx+aI0lTN8TcJqs7gDGjKEONGQpo7TbzmEGjWBT1rTmNk2rIPrcsnB+Iq5G0vJLliAwes2uh8bsW2kUDHU0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b0EpUoqR8Ti6mMX8h1TX8yK7lQ2ly00UlOlPVf05D8M=; b=czo20orL9s8AmhbE3L5FxpS7UVgk0utDi8z3rbqWjdOMnfUj588cJrOC2LzqsmFe0pstcHGWsSilJFV7wPp7gEXflXZy2DWB9tzGhNx4QtL1UpCMg8gns6yzeZl1NAtoGlfPb4doK/76mEZdmpCy/U6zR2/HiyxkOSZ8bTQaQqBxrkhRoilz+jrqPwDJfUUcN1ZU6D3kzuIHbVmOvPTTN+PMU52H9UG8IrpeBAjXeBFkGF7UXfveBk6m2q649/fuzyD8V0uSL3cVEWFY0r0bvLBnYxDJIhR1MLzClk07dzpQCTMeQjIqcFCSEKGMniVukmf7V8r0cINDvFm8/XMB3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0EpUoqR8Ti6mMX8h1TX8yK7lQ2ly00UlOlPVf05D8M=; b=AcxtLSPSg+WzlrhYkiwSTxzJPIjZReHAzDdciY8sl8skDH7fXdLQ9qno7xkrDrQCUeC8FTM6V1E8h8yHqSPGXHGHerZ6b4Tcj5bExgsiuzil0YjSzapWkdtUQ7F7polm2DDz/HIoUlLt/4mAp0GPdyCZw6NXbrm3clQiCKLn26E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 3/5] automation: Add a static memory allocation test on arm32 Date: Tue, 14 Feb 2023 16:38:40 +0100 Message-ID: <20230214153842.15637-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214153842.15637-1-michal.orzel@amd.com> References: <20230214153842.15637-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT016:EE_|PH7PR12MB7844:EE_ X-MS-Office365-Filtering-Correlation-Id: a850e441-3bab-4253-0c6d-08db0ea191c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tAI1zthRDMO5RkWh29zxkBPijJagfdHvAcwxWx5N0EyRJmEs9bN32OB2oMswlzp5qWpdx7rjO1SE4gUpYJLc5N1Boh3EUTxgaWYWVv9posXW/6aPPgLfzq8t7acl3WBrixe36ikxNx6nfdbJ60vufY1mkvTBIbKxN4ZwuniU/WqYkVuSBzasnJQOvoc8uf2lB+D9zXsKQ/K4yP5ADizja/aMtrB+EDlEuLemdaYSaE7iYvscdHgp3tRnxzHtyUQEqhc/F+jYqK4jrDLald1QHOBUJRf8V6mUOcyEY+sFRZflHEKiKF9jB9lBGeepSAs/s+gauMxtTogjT8eNP7FtWknqhzM5d24wjEia1zSpuk4tsZztc+gv9/P1qITsHFc213QWU2ZVbV+BRXJWtIhi3q8SRKUdj9VNcnVGAEdURg3lAnBkEJLBOhzAKayhWmyBJX6jyXsj5JxpVdWKEjvARWY8N3DyPJww6EywOuczEfJsDTiNZ0nKW1nZEZn/v+HxqijREIbu7rS4r464MZxvydZbHkQgfZJ6b74ZBOuNSS2tevYlQMg5VgPltg1dp93hzu3yglP6wtF2L7wVGyhkyuCG8UTWAvlT1/+rJsxPL0KRDNat3SmHY1RNgh6crQxovFAjyIBMrHI0xqlRlaNO8TQmkJN7/uCm1X9vUGSorVByGJAAnxdR9yH67v2olZWLBHW0P3aQbnW5H6MznBxsFxJpW+x+uDKLK+vCWX5Aui9JmKi4OtTH+3os/EtmZCID X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(136003)(39860400002)(451199018)(40470700004)(46966006)(36840700001)(82310400005)(40460700003)(478600001)(966005)(6666004)(26005)(2616005)(40480700001)(1076003)(41300700001)(186003)(6916009)(70206006)(356005)(8676002)(70586007)(4326008)(316002)(8936002)(82740400003)(86362001)(47076005)(81166007)(83380400001)(426003)(36756003)(36860700001)(54906003)(5660300002)(44832011)(2906002)(336012)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:50.0616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a850e441-3bab-4253-0c6d-08db0ea191c1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7844 Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test static memory allocation feature. The test case itself is directly taken from dom0less arm64 testing. Populate build jobs to compile Xen with config options necessary to enable static memory feature. Populate test jobs passing "static-mem" as a test variant. The test configures domU with a static memory region (direct-mapped) and adds a check using /proc/iomem to determine the memory region marked as "System RAM". Signed-off-by: Michal Orzel --- Changes in v2: - take into account new container for arm32 cross builds - drop Rb as a result of code changes --- automation/gitlab-ci/build.yaml | 20 +++++++++++++++++++ automation/gitlab-ci/test.yaml | 16 +++++++++++++++ .../scripts/qemu-smoke-dom0less-arm32.sh | 17 ++++++++++++++++ 3 files changed, 53 insertions(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index f8e156e0a994..079e9b73f659 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig: HYPERVISOR_ONLY: y RANDCONFIG: y +debian-unstable-gcc-arm32-staticmem: + extends: .gcc-arm32-cross-build + variables: + CONTAINER: debian:unstable-arm64v8-arm32-gcc + HYPERVISOR_ONLY: y + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + +debian-unstable-gcc-arm32-debug-staticmem: + extends: .gcc-arm32-cross-build-debug + variables: + CONTAINER: debian:unstable-arm64v8-arm32-gcc + HYPERVISOR_ONLY: y + EXTRA_XEN_CONFIG: | + CONFIG_EXPERT=y + CONFIG_UNSUPPORTED=y + CONFIG_STATIC_MEMORY=y + # Arm builds debian-unstable-gcc-arm64: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 84ab1fee50a4..c2bcc5d4d3e5 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -226,6 +226,22 @@ qemu-smoke-dom0less-arm32-gcc-debug: - *arm32-test-needs - debian-unstable-gcc-arm32-debug +qemu-smoke-dom0less-arm32-gcc-staticmem: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-staticmem + +qemu-smoke-dom0less-arm32-gcc-debug-staticmem: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug-staticmem + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index e3f2b28f3f89..bd89a3f8b45e 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -20,6 +20,19 @@ echo \"${passed}\" " fi +if [[ "${test_variant}" == "static-mem" ]]; then + # Memory range that is statically allocated to domU1 + domu_base="0x50000000" + domu_size="0x20000000" + passed="${test_variant} test passed" + domU_check=" +mem_range=$(printf \"%08x-%08x\" ${domu_base} $(( ${domu_base} + ${domu_size} - 1 ))) +if grep -q -x \"\${mem_range} : System RAM\" /proc/iomem; then + echo \"${passed}\" +fi +" +fi + # dom0/domU rootfs # We are using the same rootfs for dom0 and domU. The only difference is # that for the former, we set explictly rdinit to /bin/sh, whereas for the @@ -72,6 +85,10 @@ BOOT_CMD="bootm" UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr"' > config +if [[ "${test_variant}" == "static-mem" ]]; then + echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495214.765500 (Exim 4.92) (envelope-from ) id 1pRxOT-0001ap-UF; Tue, 14 Feb 2023 15:38:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495214.765500; Tue, 14 Feb 2023 15:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOT-0001af-PW; Tue, 14 Feb 2023 15:38:57 +0000 Received: by outflank-mailman (input) for mailman id 495214; Tue, 14 Feb 2023 15:38:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOR-0001Wo-Va for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:55 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2061f.outbound.protection.outlook.com [2a01:111:f400:fe59::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad369242-ac7d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 16:38:51 +0100 (CET) Received: from BN7PR02CA0033.namprd02.prod.outlook.com (2603:10b6:408:20::46) by DM4PR12MB7717.namprd12.prod.outlook.com (2603:10b6:8:103::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:38:47 +0000 Received: from BN8NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:408:20:cafe::ef) by BN7PR02CA0033.outlook.office365.com (2603:10b6:408:20::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 15:38:47 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT086.mail.protection.outlook.com (10.13.176.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:47 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:47 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:46 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad369242-ac7d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ta12bThNphkHAZydVdUXkmkG+JwwTOkoadommGHiD09IgXjBBW1by0fzbhKxRCeNEDtkCe/f7JNLvSFvGLDfH7T2oKFPtvuUNWeJkvxVZ2MFPwMBdb5hqHXvaLGl2gAfE3AAQIDNbwqzqjGAqfEKJvsuJ3H82rJc7rWW6YoT6LbxBItvXAvxU0piVqIUDF42q6EIywqDUP3R46zBF5RsW6XNd/4D+UzJ2Av9OfvHsYPYhmxlVV82x5leqaV9pnd9CpLFubFHUwxUGUyR6t4RL6uqTYCPkLJ8m6nAi8xRrKQ5Dlr9PEJ1Ey18klw4/yG/vY+Y0iS3HJwhkRMkO6Myjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBMwFXs2iyyGl7+YYdai6PnoFQtpNzal7lo6WSR2gU0=; b=C0i1AqZgTIYFelYLmlb0yG/1xCQZiMtvuZilf4g8Zd0zSILEPRdhYXsF0ONkQr1vjUVi0KiewihkjGosS0ZvVLJfBiV3YSlsXbRFEpoJ+sY2FTioV0KoXund+QhKpWZUIcjKDJntQu6KaM6sm3jYv5UaotpVVE5df004+RmieZtZaBOlkWylnbZ08WbSA98V/tuCoTEDwe8m6NKcNr3z7/APqYsi9hpriWvGRPOT8TTe1HBM+s0iBgzTclyQODaKGGTjmawRYRwf6umjHhBtisDGtm6htN3BrWnm4KhopNIE37rSL+HAf9XGWcvATkrzPK9UvAHoxRQQI+p2HW5xJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBMwFXs2iyyGl7+YYdai6PnoFQtpNzal7lo6WSR2gU0=; b=vUMomFGwdZLrE0Y/RmFqvyrnm72ATArsasPi4an4hZDN6K9KzgciqVF4T6Up9Tsl7LtRpdy63ycgLMn4OniIB3RaXPmqYAlGontOi2iye7FNsxqdjjmxDqc6UHPVCPrvHwPdD1q2XMtMsk/BHJZJ7Ll6tpBn9OdOBhZ2crbtf7A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Subject: [PATCH v2 1/5] automation: Switch arm32 cross builds to run on arm64 Date: Tue, 14 Feb 2023 16:38:38 +0100 Message-ID: <20230214153842.15637-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214153842.15637-1-michal.orzel@amd.com> References: <20230214153842.15637-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT086:EE_|DM4PR12MB7717:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a065924-8f57-4207-fa46-08db0ea19043 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sYuq54mPUTnDagYjCATStV04epwf+GdG6DSKT3nWOfLnaIFhsVK+Hn++JIVwUyzU8Y4I1c/S4xGH4NHcPNO+7x5OsqPwWN6hH5l9G+mwBBXlRdiv3k9q/1VcR6/jwwUs/TuqpL706cobJILoDmL5FRTieacXzSMZEOVF00cYx+p7t7QSRV1qJqkmJ3TNbUjZ48DyE8FKwhy3v3UEokdSxjVnE0SX7ocehtCZWb91nQ91uQltJnlCzXuOcbtgB+YxW6dIaldVpbNvz/GqSL4mQaZ8jmYJi9gSCbHTgsHwJJWK8DSaBlpwJxCAYj4Pr2lPwW2l/JE6Zk71ncbXi9QHwnBCWCX0dSLufFw3e9LImuMhztff2FCAljvhZgSC8DdRHRQc/Tmr97l3nCglM+UKn7RVN/eW/JMpnjOWqu5v2PgU85OTp8LSP4zjHKPmVWQS/QFAAoqNAsH4Jo2GOl4GuTQNbG6hG9v+ItFPiz2vEV9vKCwD5S94Fkn3wXgjqDLcJ+eydkbxnY20v7Dn2f17Gkm11+94ymT/MGOt7XG8DhZANmmxy+AUAriSbF9WfalgtQ7FoC/GDcHn3Qxb7yPi2dKwoOknjA7E296EV3RTGkrU+tw7M8EH7U0fofBdFScgeA4eAPg2OGAT8iMqFHplLdtUx2glMf/UlQ0bHGhYcG9EjPOQiF09+c5N2e9P4b/8JZm4WikEL5gFo8wbdUWk7cF/ZuqPIfRQWg1/d7veuio= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199018)(46966006)(36840700001)(40470700004)(336012)(26005)(186003)(36756003)(82310400005)(2616005)(478600001)(86362001)(426003)(83380400001)(47076005)(1076003)(6666004)(54906003)(316002)(40480700001)(4326008)(41300700001)(36860700001)(8676002)(6916009)(8936002)(70586007)(5660300002)(70206006)(44832011)(2906002)(356005)(81166007)(40460700003)(82740400003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:47.5486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a065924-8f57-4207-fa46-08db0ea19043 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7717 Due to the limited x86 CI resources slowing down the whole pipeline, switch the arm32 cross builds to be executed on arm64 which is much more capable. For that, rename the existing debian container dockerfile from unstable-arm32-gcc to unstable-arm64v8-arm32-gcc and use arm64v8/debian:unstable as an image. Note, that we cannot use the same container name as we have to keep the backwards compatibility. Take the opportunity to remove extra empty line at the end of a file. Modify the tag of .arm32-cross-build-tmpl to arm64 and update the build jobs accordingly. Signed-off-by: Michal Orzel --- Changes in v2: - new patch For convenience and own testing, I built and pushed the new container to registry. --- ...ockerfile => unstable-arm64v8-arm32-gcc.dockerfile} | 3 +-- automation/gitlab-ci/build.yaml | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-) rename automation/build/debian/{unstable-arm32-gcc.dockerfile => unstable-arm64v8-arm32-gcc.dockerfile} (94%) diff --git a/automation/build/debian/unstable-arm32-gcc.dockerfile b/automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile similarity index 94% rename from automation/build/debian/unstable-arm32-gcc.dockerfile rename to automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile index b41a57f19729..11860425a6a2 100644 --- a/automation/build/debian/unstable-arm32-gcc.dockerfile +++ b/automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile @@ -1,4 +1,4 @@ -FROM debian:unstable +FROM arm64v8/debian:unstable LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" @@ -21,4 +21,3 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* - diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c7325d..f8e156e0a994 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -123,7 +123,7 @@ variables: XEN_TARGET_ARCH: arm32 tags: - - x86_64 + - arm64 .arm32-cross-build: extends: .arm32-cross-build-tmpl @@ -542,26 +542,26 @@ alpine-3.12-clang-debug: debian-unstable-gcc-arm32: extends: .gcc-arm32-cross-build variables: - CONTAINER: debian:unstable-arm32-gcc + CONTAINER: debian:unstable-arm64v8-arm32-gcc HYPERVISOR_ONLY: y debian-unstable-gcc-arm32-debug: extends: .gcc-arm32-cross-build-debug variables: - CONTAINER: debian:unstable-arm32-gcc + CONTAINER: debian:unstable-arm64v8-arm32-gcc HYPERVISOR_ONLY: y debian-unstable-gcc-arm32-randconfig: extends: .gcc-arm32-cross-build variables: - CONTAINER: debian:unstable-arm32-gcc + CONTAINER: debian:unstable-arm64v8-arm32-gcc HYPERVISOR_ONLY: y RANDCONFIG: y debian-unstable-gcc-arm32-debug-randconfig: extends: .gcc-arm32-cross-build-debug variables: - CONTAINER: debian:unstable-arm32-gcc + CONTAINER: debian:unstable-arm64v8-arm32-gcc HYPERVISOR_ONLY: y RANDCONFIG: y -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495215.765505 (Exim 4.92) (envelope-from ) id 1pRxOU-0001iM-8B; Tue, 14 Feb 2023 15:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495215.765505; Tue, 14 Feb 2023 15:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOU-0001hm-2C; Tue, 14 Feb 2023 15:38:58 +0000 Received: by outflank-mailman (input) for mailman id 495215; Tue, 14 Feb 2023 15:38:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOS-0001Wn-71 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:56 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20602.outbound.protection.outlook.com [2a01:111:f400:fe5a::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae3d67da-ac7d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 16:38:53 +0100 (CET) Received: from MW4PR03CA0320.namprd03.prod.outlook.com (2603:10b6:303:dd::25) by PH8PR12MB6914.namprd12.prod.outlook.com (2603:10b6:510:1cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Tue, 14 Feb 2023 15:38:47 +0000 Received: from CO1NAM11FT088.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::c6) by MW4PR03CA0320.outlook.office365.com (2603:10b6:303:dd::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 15:38:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT088.mail.protection.outlook.com (10.13.175.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.10 via Frontend Transport; Tue, 14 Feb 2023 15:38:46 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:45 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:44 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae3d67da-ac7d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TjgjpTEHlCqZJps126iT/LYemc31bd+qk+mIqjEQ663gUot1seDNVG8VZcN90EgRgwzhN9p1XsWZspqAiTyxIIv3CZypgOXKpEMaOjVCM52bt7Ro/kRWbRayThPhekgWuxGPdo07SRssJqf2ak7w9sN50tgctJrF8Xysn01FhBIyBhL69h4K5HCAwz8ka5LDpZ/76KmSGcvJkACba/qLvoEcF1mvzlGNJyzHpZTuIW9EaK9w7jdIOMMaBCiomM0sfkr9QHIlRimOie5O/r2b2yJuyL63DJgMAFrmhsgOsqwk/0+25GPJp2bqai5MAKxLhVC30dnbE2IbIbCtEFZywg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XI/+Q/H0hC3+0B3P5aQlm8k2GZbJADIABnvkZNJtFk=; b=WenY5yBxXoCz5G4VeWYHtQmGGisLCY9hXjUsJXXkvFKWg+sNID/oGulopaIzgglIdZ57HMX5pICo/kI7duYn35TooYHLaodITCsEUKsTxIIGyeZSLxs1qKU/Y95oWMAyG+Ce/2Hl7DlM4RBDIQQzHUtoujwspiU6lToaN4/YnveH2jbqi6Bjz+84cZUpMUao604ajGNWVO9y6z9USiPi7V+2oE2Dt3RTwFWagQecu5Zoh8wLHAwyB12kdZuUORA0Z5U6FzbsKo3aTig/ICUYN7Ns7QfDUNx9qBpkZRWVA4bExxmEaGWv+E890tgRQTrnUilg4Msm5v86RwsnIHCkqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+XI/+Q/H0hC3+0B3P5aQlm8k2GZbJADIABnvkZNJtFk=; b=w+hjcxgKuR8g5tT2iBSA6khlxyFbJHKLqfWpXlouE9jQwzQd5qwRJnGj490vrVokQxQdttSz3xqL1BXziIPDk9fG+ZoodShWimaePqgDTB0I1qcpE0NFKlguL6YRxxZ9tmDp/2Ugez26M4W9HgkilQKY6yBsh0m4Ec+eHkrsljE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 0/5] automation: dom0less arm32 testing Date: Tue, 14 Feb 2023 16:38:37 +0100 Message-ID: <20230214153842.15637-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT088:EE_|PH8PR12MB6914:EE_ X-MS-Office365-Filtering-Correlation-Id: dc6e551b-5cba-48bb-ea0c-08db0ea18fef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HKD7kY2zJjkmb76SCnZnjF8fE433fVYoAgMaNznaWNUZyXoO0TmRB6E/jvdcknjnTM0XrS3BXO1OnjmzFp2nSOuyNZ9pBYVFX6nShxqijgVDsgDzRJBsUW4BczeKAwj5/aV0pUcOemPlo4Y14Y4KgSpNCvGua9sE4FInIHXYC764q1eGuxUXEDjvITCHRxtVEAtt67YTmxxz4hkKJyPbeaU2j4INd6b6QggUBIpNta7xt9LKUHTPtSXNSHxqhibcpXi9d3TIeRalIi0iD3c9rok4rXiEZ9Un0gF9rOsRP7GcKd3dd6fOAT5NKIQrjcQAOfrJtefIfumSI+UOZ6snh31bZQWpHwKhnGxR+EL6RkK1wkX+OSn2woiOGzwueJ2E3YA9+4kz1yDqIEYvFn2iKa8bXlb2I0gcOTNd0a91CTKDfMN+jJKDKH89RTCyepIIkJH5Ags7wttnUknXv8v64Q/plIX9d3W9ENoVCs28rv9qvhDtBGM32IeEnhGdSEo5DvC6zTsp2WwgyWuFwcR/Xar3yLlcmuukWbzqvv1oNgPgzVGr1YzHsuWmE0PE03SRp1bjhYeWJF1iKwLJiHV1YYxJlcJ/00r46EZT2K5D0+C43SRr1eHOGUPuzul28LzV/0/pGlHE7ocmAW8/5XHGTUTJVe8mT1mM08MhO6LqugZ5UbEfcsK1gQdBsH1stWS56PQLFJDTd/QvUtNyWvUgLIEybGJIAX4br77937/RD7+RJDXkZmN+vLNn3SFe8oSF X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199018)(36840700001)(46966006)(40470700004)(316002)(54906003)(356005)(426003)(47076005)(5660300002)(8936002)(40480700001)(40460700003)(81166007)(82740400003)(41300700001)(2906002)(36756003)(8676002)(36860700001)(6666004)(70206006)(44832011)(82310400005)(83380400001)(86362001)(966005)(478600001)(26005)(6916009)(186003)(1076003)(70586007)(4326008)(2616005)(336012)(32563001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:46.9039 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc6e551b-5cba-48bb-ea0c-08db0ea18fef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT088.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6914 This patch series aims at improving the arm32 CI testing by introducing the dom0less-based tests. It creates a foundation for further test expansion. This is particularly important now, when OSSTEST arm32 stuff is down and we need to have at least some coverage in gitlab CI. Note: First patch is added to the series for convenience. It switches the arm32 cross builds to be executed on arm64 instead of x86, as the latter has a lot less resources resulting in slowing down the whole pipeline. CI pipeline performed on top of this series + cppcheck patch: https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/777181033 Michal Orzel (5): automation: Switch arm32 cross builds to run on arm64 automation: Add arm32 dom0less testing automation: Add a static memory allocation test on arm32 automation: Add a gzip compressed kernel image test on arm32 automation: Add a true dom0less test on arm32 ... => unstable-arm64v8-arm32-gcc.dockerfile} | 3 +- automation/gitlab-ci/build.yaml | 30 +++- automation/gitlab-ci/test.yaml | 64 ++++++++ .../scripts/qemu-smoke-dom0less-arm32.sh | 142 ++++++++++++++++++ 4 files changed, 232 insertions(+), 7 deletions(-) rename automation/build/debian/{unstable-arm32-gcc.dockerfile => unstable-arm64v8-arm32-gcc.dockerfile} (94%) create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495216.765513 (Exim 4.92) (envelope-from ) id 1pRxOU-0001un-Ns; Tue, 14 Feb 2023 15:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495216.765513; Tue, 14 Feb 2023 15:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOU-0001s6-KS; Tue, 14 Feb 2023 15:38:58 +0000 Received: by outflank-mailman (input) for mailman id 495216; Tue, 14 Feb 2023 15:38:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOS-0001Wo-LF for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:56 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20604.outbound.protection.outlook.com [2a01:111:f400:fe59::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ada5c1cc-ac7d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 16:38:51 +0100 (CET) Received: from BN0PR04CA0060.namprd04.prod.outlook.com (2603:10b6:408:e8::35) by CH0PR12MB8530.namprd12.prod.outlook.com (2603:10b6:610:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:38:49 +0000 Received: from BN8NAM11FT114.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e8:cafe::6c) by BN0PR04CA0060.outlook.office365.com (2603:10b6:408:e8::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:49 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT114.mail.protection.outlook.com (10.13.177.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 15:38:48 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:48 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:47 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ada5c1cc-ac7d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BF5LUlnLZeDKb1dPvjs9bGBH1HIAYaIW031oJAxemT+tLUngvPI1V4uil/vn9ghsVnE4BjfqTrY4xLSG5lvILXgtxk+ztagkdDmP/607RM+V8Y4YU2gfz7WPBDFoKru1/GGAECnJ5ibwPFXIqtRPiJCQz7VVol765d9jSAtiAFZ2O9H6CscYDsw9JIo6x+uC4QR/Fpv88DdUt6ah+uZ1ZUocOsEV9fbEgPFE2BXeeUsrKHe8LAjnR0V3WTpDK1NKKgkPIXg/A/hQTLTB/oO42NzKO+AbAYaTc7xjiVPQh2VWQwxV7YzgJ7fyuTf1ntEH/X7vJBYgCbIIDjcXHhBVIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TzwAM6S/ZDvUz+GhVuoZK+2MU6N8kVAHfsdpOWO3UmA=; b=XYvu+QaWaznZ85rCfYJ5T9WTFrx7GCtk+h2ZHlh+M78H2L4jVHeqeGAfqanusmbI3nuF0IvZYUjre4jxZyaRN3UILeMuwP3NLLzWWiqVaI063DkgAwIMxsNEEujC0ErjquAux+sNG22uIfso8mJ/4X19iQKDa7WqHFQTNBVG0V2gl96w2uwkC0nj8s4drfe0yuootf2s5wJxW/Kybsn+Mfirp9oTpEFfJGYLuZL1BZnOWfuHU3JLnadCzpPp9mzvoxzU0T6vCzGgxRBvcOU7n8QFpp9EzipnXf1YW7ua1Pw508nPAAQDIvtx7iVR/eaDcbc3o9w/75XXNPSf63sFeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TzwAM6S/ZDvUz+GhVuoZK+2MU6N8kVAHfsdpOWO3UmA=; b=btNP785clnkVLCGWypCHINfsJHVFsuqw0/7MgNYaFCo3PZZu/OBrCXAc2ON/PSrKxtm0TgYQ6rEleddmob+RGJ5UWyGhoT3dEEB/85rIF/yMtbsxXcHsYOFOcibGLVd1TvNK1KHJy4fXVqPes3i5EI5oOP7bCj+2BFgIOJFnbes= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 2/5] automation: Add arm32 dom0less testing Date: Tue, 14 Feb 2023 16:38:39 +0100 Message-ID: <20230214153842.15637-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214153842.15637-1-michal.orzel@amd.com> References: <20230214153842.15637-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT114:EE_|CH0PR12MB8530:EE_ X-MS-Office365-Filtering-Correlation-Id: 55d2efce-5a7a-4867-395a-08db0ea19100 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 36kciKjGiw4YZnxNNGTb6QFwXu88MwyAkFt5pd77bSi0hsynGQ/XhDilxS/s9O7fSZvPUtHooyeT9xN+n95I+0RfJM+YD5BYyP4XiY4SILLaXxw1G16MFPj9h453s85YD7tbnG/wUtIBscGi0pWIL1JI2DGPcjeMalO4ZKPiX9pdhrGw+Hzz1rq8EEkMoDVj8MiFJntNIMYfluF8BzIcOdJ3NnIsYETDD1Iw6E/Koq3wGMfr1EgJTJoIBewkX2so2MZ/77NZIhnMznDJkDoInc2PnAX+yVDzUztNr6GboItyp50kcxgVWocQbDfzRHG6Q5L5H9Zyc5/1lFpad8ZdK9Z74lzpqEujZQC9tJDYPESHdOD2LF43SMbUqdASdurXTjFvvFyUPuTnjtf5ued3DtKx684RcgWS2lnC4t+GVgXsnkWJkN4Dc2ZCecAY4n7MdcjFMMcou6FaN2BwZ11dQ/A2hGT2F7t4XYXxk92OBgh5Nlypvn0WOKQPexQRyQbdMoWzktvegZlKLttAdoufxFFjLBWN/xYMNOEOPZlM8ePoITu9uta9/b9/dpwNpVARgXjp7vvK9/mTsR9dxPpKyI1Tm4s1CSRpKSD3ilCw9sjkkU2nZEOdfX+hkwMwuSDfjrCHoSe7uCh/JEgfblfcemGrTbDoAx/Nm5eqUZc4MmB708NVGvYNBxZJn9BNzwCgpB0pJHJRiBfn7Ic2Sjrf6eXLFhhALst3IvLxu9cP/8JjB8mb4OOBCD1ToTAMIz5UE9gQOza+CPziTTCAW60GsehOAkShSN8qFxrRmBbscNGnpen8sRhO+Fu7Ikd/RmqbJaucFRqTlNE0qHjLByjjzA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199018)(40470700004)(36840700001)(46966006)(26005)(186003)(2616005)(6666004)(316002)(478600001)(336012)(966005)(70206006)(70586007)(8676002)(4326008)(54906003)(356005)(83380400001)(1076003)(5660300002)(36860700001)(8936002)(44832011)(41300700001)(82740400003)(2906002)(81166007)(6916009)(82310400005)(86362001)(36756003)(426003)(47076005)(40460700003)(40480700001)(32563001)(21314003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:48.7822 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55d2efce-5a7a-4867-395a-08db0ea19100 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT114.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8530 At the moment, we only perform a single arm32 test in our CI, checking whether dom0 boots successfully or not. This is mostly because we do not have any arm32 runners and we only execute a hypervisor only build. In order not to leave the arm32 testing in such a poor state, add a script qemu-smoke-dom0less-arm32.sh to start testing dom0less configuration, while keeping dom0 to make the test more interesting. The script is mostly based on the one used for dom0 arm32 testing as well as the one used for dom0less arm64 testing. We obtain Debian Bullseye kernel and Alpine Linux busybox-based rootfs. Depending on the test variant, we prepare a test case contained within domU_check variable, that will be executed as part of /init script from domU rootfs. Signed-off-by: Michal Orzel --- Changes in v2: - keep dom0 around by default to make tests more interesting --- automation/gitlab-ci/test.yaml | 16 +++ .../scripts/qemu-smoke-dom0less-arm32.sh | 99 +++++++++++++++++++ 2 files changed, 115 insertions(+) create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index ce543ef5c0ef..84ab1fee50a4 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -210,6 +210,22 @@ qemu-smoke-dom0-arm32-gcc-debug: - *arm32-test-needs - debian-unstable-gcc-arm32-debug +qemu-smoke-dom0less-arm32-gcc: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32 + +qemu-smoke-dom0less-arm32-gcc-debug: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh new file mode 100755 index 000000000000..e3f2b28f3f89 --- /dev/null +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -0,0 +1,99 @@ +#!/bin/bash + +set -ex + +test_variant=$1 + +# Prompt to grep for to check if dom0 booted successfully +dom0_prompt="^/ #" + +cd binaries +# Use the kernel from Debian +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +# Use a tiny initrd based on busybox from Alpine Linux +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz + +if [ -z "${test_variant}" ]; then + passed="generic test passed" + domU_check=" +echo \"${passed}\" +" +fi + +# dom0/domU rootfs +# We are using the same rootfs for dom0 and domU. The only difference is +# that for the former, we set explictly rdinit to /bin/sh, whereas for the +# latter we rely on using custom /init script with test case inside. +mkdir rootfs +cd rootfs +tar xvzf ../initrd.tar.gz +echo "#!/bin/sh + +mount -t proc proc /proc +mount -t sysfs sysfs /sys +mount -t devtmpfs devtmpfs /dev +${domU_check} +/bin/sh" > init +chmod +x init +find . | cpio -H newc -o | gzip > ../initrd.gz +cd .. + +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom +./qemu-system-arm \ + -machine virt \ + -machine virtualization=true \ + -smp 4 \ + -m 2048 \ + -serial stdio \ + -monitor none \ + -display none \ + -machine dumpdtb=virt.dtb + +# ImageBuilder +echo 'MEMORY_START="0x40000000" +MEMORY_END="0xC0000000" + +DEVICE_TREE="virt.dtb" +XEN="xen" +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" + +DOM0_KERNEL="vmlinuz" +DOM0_RAMDISK="initrd.gz" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" + +DOMU_KERNEL[0]="vmlinuz" +DOMU_RAMDISK[0]="initrd.gz" +DOMU_MEM[0]="512" +NUM_DOMUS=1 + +LOAD_CMD="tftpb" +BOOT_CMD="bootm" +UBOOT_SOURCE="boot.source" +UBOOT_SCRIPT="boot.scr"' > config + +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config + +# Run the test +rm -f smoke.serial +set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ +timeout -k 1 240 \ +./qemu-system-arm \ + -machine virt \ + -machine virtualization=true \ + -smp 4 \ + -m 2048 \ + -serial stdio \ + -monitor none \ + -display none \ + -no-reboot \ + -device virtio-net-pci,netdev=n0 \ + -netdev user,id=n0,tftp=./ \ + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial + +set -e +(grep -q "${dom0_prompt}" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 +exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495217.765523 (Exim 4.92) (envelope-from ) id 1pRxOV-00023n-BJ; Tue, 14 Feb 2023 15:38:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495217.765523; Tue, 14 Feb 2023 15:38:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOV-00021f-1Y; Tue, 14 Feb 2023 15:38:59 +0000 Received: by outflank-mailman (input) for mailman id 495217; Tue, 14 Feb 2023 15:38:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOT-0001Wn-73 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:57 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b07c23f2-ac7d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 16:38:55 +0100 (CET) Received: from BN0PR04CA0001.namprd04.prod.outlook.com (2603:10b6:408:ee::6) by CH2PR12MB4938.namprd12.prod.outlook.com (2603:10b6:610:34::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:38:51 +0000 Received: from BN8NAM11FT083.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ee:cafe::fe) by BN0PR04CA0001.outlook.office365.com (2603:10b6:408:ee::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:51 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT083.mail.protection.outlook.com (10.13.177.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:38:51 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:50 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:49 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b07c23f2-ac7d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZcH4xujC2G2v82cxAudHWpjXsFoRHAqdcXZ/oIv/aF/KHzqFk4Dc73AIibMKPPQ6FVM1XRiLM2y5hY05zNCIAV8lUWtuD/w9+0b2CD22nGFhVNH3UiI3JQSFEJKINFIHQrFQR96tEJKm2EWosfxl6kF0Ets/tnnCdOjX4pvIEjsfxRv9n0ydVLHb7qbA2P9Px8c1uxAbCpFt4Nrw6oR+B3LOnA/+aBmWFqB9JTJ0ZRylBpzKrn37CQ1jCy/hDXB3NbU5tn03q4PbcF8IOeu2Zi5EmcbX3DCYKGmur7ok79mM+oMpvv/5zFAOKh8FS0Ss8xSkKsOYcZOAjjpJuLtGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VrWoeY005CFD5W1azhm+V3ALraRSyeUKG95MNZECaF8=; b=RiCQypaykDEH8zyEUyUnCglaMHqZ/Au4gy6thrngoWiVzNld56Y9+NFDfc/IpIM6m0fAy8OsUv4Pc6WXJPIHCaco2/Z7QpNTde5r19KWGVp0m5nY9JrYlCakvbHDK2pfVB+s9MPKV30Vbee+uLDQCw+uCEbjvSE/ngdorz8cglu2Ez5mGrMrYjXNnXmQxZtf05zd0g+cPQfzJIK5j/6CHsCyHvlLCe2mVBp3b3Pb5kutn2UouwGo/7ISBIAmZYB577veNqXr71CeQ7VYJlstt+J/MdzQNUJvxKNWbxUkDcDJYz5NczZn9dzPpmLUhP8x7JEY2NjaVE3In9TnGa1r6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrWoeY005CFD5W1azhm+V3ALraRSyeUKG95MNZECaF8=; b=ZtRAuO9swxrvYVM3aXHxqCAMhaaXvjROM6vt6tN6Q/4YAIhx6mXuzMGB1wggcOsE1BnZYpduLAlCyXK6PJLUiTCh6uervCpoWOg3ZhVAYYQL7LcfEYZYh3vpv4+n6vnkE3MojAJh/EktrRgLK//2AJWgyvtf/7hmx5vJFvHuYKU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 4/5] automation: Add a gzip compressed kernel image test on arm32 Date: Tue, 14 Feb 2023 16:38:41 +0100 Message-ID: <20230214153842.15637-5-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214153842.15637-1-michal.orzel@amd.com> References: <20230214153842.15637-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT083:EE_|CH2PR12MB4938:EE_ X-MS-Office365-Filtering-Correlation-Id: ca799b3c-8d72-4548-8cc3-08db0ea1927d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: stVE1UCSS1wdeJf9uMFsK6dHh4qQNpqq4EWDgy1025opqGjI6rbH4aYnZ/UY57jI/nGzzXCNsUIp7TCteN2OXfyfEMHiDHY8YF/uQIFBAjva7q4fNHh7lbSpLEv/N1n3gc6aEazrhxw1tSoFsI0058zskyFlDovgoxRhICN18/4ss3fWz840QGAghWa4l0BKP+tvs4X2u04RrSbykLKUxS9aDQZBT/9nB+aYaEIHkrmVHuFw038jTHno0dZ8Yw+t//XUiJs9jfsGLjII37TAmbgN7z1otX269ESB2ui7QN2NIi0XoW2fHMHxdNJZFNI6l+2bdN0JNX3FVFo+NaNFxU1XpQcF7Br2oqUC3jD0goZRng644DmzaRvJAV3K/XLSXBQADDS+7bqAbMO0gP/tN+MTLN5fS1L275DSvMnpESU19F/VPgZxdNNN1///vLAntg87KpMUVjOImYCnBRYAQ/DERJaacUNaPchfkbdutsAfrt9r/qny8zVyEh6QDk3yXvbt+2P6twCDLKSCPyzAmeZetlo5c088vIbQK/Y7rjX0si7bfB4JMZW6n232VNNpo370+wGPVKlREpZ6ktikCnm1u05wKQNa2GkhCi7fpgByUZ3IMY017rHrP1pjOO7AeKLXnq6QdpMWD9FH02h15EydUeNt1pwHRq1ul6EY58lgIorEh+4mobvyb1ywqqJ4WHJLGqbJ4qazxg3Wsv127uOLeoBPUGAM4I+vjkBC1xE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199018)(36840700001)(46966006)(40470700004)(82740400003)(40460700003)(2906002)(478600001)(83380400001)(356005)(26005)(1076003)(186003)(6666004)(36756003)(966005)(5660300002)(41300700001)(44832011)(36860700001)(70586007)(70206006)(8936002)(6916009)(8676002)(4326008)(82310400005)(81166007)(86362001)(426003)(54906003)(40480700001)(336012)(47076005)(2616005)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:51.2969 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca799b3c-8d72-4548-8cc3-08db0ea1927d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT083.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4938 Xen supports booting gzip compressed kernels, therefore add a new test job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test booting a domU with a gzip compressed kernel image (in our case zImage). By passing "gzip" as a test variant, the test will call gzip command to compress kernel image and use it in ImageBuilder configuration for domU1. No need for a specific check to be executed from domU. Being able to see a test message from a boot log is sufficient to mark a test as passed. Signed-off-by: Michal Orzel --- Changes in v2: - take into account dom0 presence - drop Rb as a result of code changes --- automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ 2 files changed, 29 insertions(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index c2bcc5d4d3e5..be7a55d89708 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -242,6 +242,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-staticmem: - *arm32-test-needs - debian-unstable-gcc-arm32-debug-staticmem +qemu-smoke-dom0less-arm32-gcc-gzip: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32 + +qemu-smoke-dom0less-arm32-gcc-debug-gzip: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index bd89a3f8b45e..c2e331451d99 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -33,6 +33,15 @@ fi " fi +if [[ "${test_variant}" == "gzip" ]]; then + # Compress kernel image with gzip (keep unmodified one for dom0) + gzip -k vmlinuz + passed="${test_variant} test passed" + domU_check=" +echo \"${passed}\" +" +fi + # dom0/domU rootfs # We are using the same rootfs for dom0 and domU. The only difference is # that for the former, we set explictly rdinit to /bin/sh, whereas for the @@ -89,6 +98,10 @@ if [[ "${test_variant}" == "static-mem" ]]; then echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config fi +if [[ "${test_variant}" == "gzip" ]]; then + sed -i 's/DOMU_KERNEL\[0\]=.*/DOMU_KERNEL\[0\]="vmlinuz.gz"/' config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:39:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:39:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495218.765548 (Exim 4.92) (envelope-from ) id 1pRxOX-0002pq-OS; Tue, 14 Feb 2023 15:39:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495218.765548; Tue, 14 Feb 2023 15:39:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOX-0002ph-Kw; Tue, 14 Feb 2023 15:39:01 +0000 Received: by outflank-mailman (input) for mailman id 495218; Tue, 14 Feb 2023 15:39:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxOV-0001Wo-On for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:38:59 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061d.outbound.protection.outlook.com [2a01:111:f400:7eaa::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b14520fa-ac7d-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 16:38:57 +0100 (CET) Received: from MW3PR05CA0005.namprd05.prod.outlook.com (2603:10b6:303:2b::10) by CY8PR12MB8215.namprd12.prod.outlook.com (2603:10b6:930:77::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:38:53 +0000 Received: from CO1NAM11FT079.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::2b) by MW3PR05CA0005.outlook.office365.com (2603:10b6:303:2b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.10 via Frontend Transport; Tue, 14 Feb 2023 15:38:53 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT079.mail.protection.outlook.com (10.13.175.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 15:38:52 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:38:52 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:38:51 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b14520fa-ac7d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=StwK5pcufpLBofMygVg2MDnCQhDo+4pdgbkKKzFRFnbOHaOBxSBekcB/eo+qsGtvyRKpUMJ/ckBJNE0eizJg4MqPVGJptsvh1wsT5zA9nnJF5lKCDJF3RyBrX0UlXT1fyPxRn6DDYls609jdhXICH9BdBWFh3L3BJK71waXQtTsfdR1jf+xv0kIsEim9l0kdKNeDjvfqyEjnCTrEqYQP+n2+leTTzFXRRqurBwV8t0JOFq/LEzcwGS1GiFMjtqwbghJhTfWEUKE9qCtu8UvMLEe7vbWxicgQ2bNCyuW0wRaamlTMHYAoEKhV1k3f/rBmmbgtfbplvytJoEJwXGBfHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7oqGuHYhJRqwJMQYh2Owy78U87YkEB1pjFAaF5dtpc0=; b=GaQu2ioDGHFUv1YFe7i8gyUxbni0eJHjcC8MiiJvV+qixELpcDXIrb2K8KC7Vgjv8OHNFKqa/R11EtYonpDY7hOfBau/Gf2hWyqkvQAxb3S45zQ4r2JqpNs6es+osXrb20JKGHhiV/DeqmC3qMjYWRmZ8N2Wyjj/RgiDNZzlGgMKeTo40yXGEvQNoeOmLy9EIafu0bJkujnM3vxFJVGWHi4l0ONyiHHtvaMI6ZiRyTNBvg9LRW+jv7DaMZa7fy9m0O8jUUfKJ9wC8vRWL2Ztknh+QK1TZTM/OOjBF1ZMtWx7Q+e8DKrAHGlZDyOFPeg3YJVpVB5SaxGimiW4KQC8wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7oqGuHYhJRqwJMQYh2Owy78U87YkEB1pjFAaF5dtpc0=; b=PQa+i5iNcP2kPUrWumGqA11OxH0dt1VKgneHUKePgRvUhDypjVK/w7/LhS6WwRmkUOAFk096eP9zRuIp4WK1Pu9n14vfKbOTVTTo+c5d4LljmLpT2cvtwkhRMBn83RQCQThPMdcPO1c0EpHqJX0BVxz5c5E5r6YC7gmnoAilXWQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 5/5] automation: Add a true dom0less test on arm32 Date: Tue, 14 Feb 2023 16:38:42 +0100 Message-ID: <20230214153842.15637-6-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214153842.15637-1-michal.orzel@amd.com> References: <20230214153842.15637-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT079:EE_|CY8PR12MB8215:EE_ X-MS-Office365-Filtering-Correlation-Id: 676466e1-36a2-40a7-3a56-08db0ea19393 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jcxqjx9YDuwFBjGp/Xvv/nWISnZFFpVp+1Imnl7QcW6a19tSm/OSz9rXyq0nbcyPu1AoZM023tHAm8Al7TEGWqtPbSooDxr72RuNU0J1YbWBC/8PrXrEZPXBgpduMxQEOldq653Vx9Ip/2ZRe1UHKYe8zFRAkaynLY6BjblPFjItvQ3vvcLH0mW8q+XwaiFiud/CTnZc9BaxkwpmypY9v+MpyjfcNaojfB1nxM0V8gIiiJSVc23Nxm+PgIydKPcKeuKxLReUM9A4rLL68KSIdZax+zofeHZyfwl8btMzuexqfhaCLjud3UgXXEkQWkZx4875KfPpX2uqa3yls5yLczH1APzV8EDq7aNWln+kox/c398aYVRUJjmLvLT6kD+zvsG1mg7/Gq26S6iMBUlSbWjKIOFJnxfuEeM4ZkVnY27Y7r9RSAS4ZktwDgtVRt+vE0M+k8Umjbd8UTWoL8VXwR/kItDifUa3zIceFaWmeENHwqaGMLkVZ/209APtzO0EXUXwntTQL8KK2OVbthKHBON7MgVfcEUR9L39F/gLA/xfuCzK2EmhW7jUbw3M8+AfPSwQ2jeRGejsNH0YrOBdNum88NF0vbNFke4x/ygpRJUw9ArNqstCXpKrVHNTZEMBM5/AS16Dxzm8/AK9TJR/i/21eMGcm/+56RItwdLKNPJf8x8DV4RkWKCycO026r5rSeR5G+MFR3EDeswtMWC/EhBAqilyZrZ39fSd/ReRxfyn94bhzLy5eV1EtpnLXZsZ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199018)(46966006)(40470700004)(36840700001)(44832011)(6666004)(478600001)(2616005)(316002)(86362001)(82310400005)(54906003)(40460700003)(70206006)(2906002)(966005)(4326008)(8676002)(36860700001)(5660300002)(6916009)(41300700001)(36756003)(426003)(1076003)(26005)(186003)(336012)(47076005)(40480700001)(82740400003)(70586007)(8936002)(81166007)(356005)(32563001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:38:52.9917 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 676466e1-36a2-40a7-3a56-08db0ea19393 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT079.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8215 Add a new test job qemu-smoke-dom0less-arm32-gcc-without-dom0 in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test dom0less domU boot without dom0 (i.e. true dom0less configuration). By passing "without-dom0" as a test variant, the test will clear the dom0 prompt that we grep for as a last step and remove all the DOM0 related options in ImageBuilder configuration. Signed-off-by: Michal Orzel --- Changes in v2: - new patch created as a result of deciding to keep dom0 by default. We still need to test true dom0less configuration, hence added a new test. --- automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ 2 files changed, 29 insertions(+) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index be7a55d89708..c0b4a90e0d29 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -258,6 +258,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-gzip: - *arm32-test-needs - debian-unstable-gcc-arm32-debug +qemu-smoke-dom0less-arm32-gcc-without-dom0: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh without-dom0 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32 + +qemu-smoke-dom0less-arm32-gcc-debug-without-dom0: + extends: .qemu-arm32 + script: + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh without-dom0 2>&1 | tee ${LOGFILE} + needs: + - *arm32-test-needs + - debian-unstable-gcc-arm32-debug + qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 script: diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index c2e331451d99..cc91238f4222 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -42,6 +42,15 @@ echo \"${passed}\" " fi +if [[ "${test_variant}" == "without-dom0" ]]; then + # Clear dom0 prompt + dom0_prompt="" + passed="${test_variant} test passed" + domU_check=" +echo \"${passed}\" +" +fi + # dom0/domU rootfs # We are using the same rootfs for dom0 and domU. The only difference is # that for the former, we set explictly rdinit to /bin/sh, whereas for the @@ -102,6 +111,10 @@ if [[ "${test_variant}" == "gzip" ]]; then sed -i 's/DOMU_KERNEL\[0\]=.*/DOMU_KERNEL\[0\]="vmlinuz.gz"/' config fi +if [[ "${test_variant}" == "without-dom0" ]]; then + sed -i '/^DOM0/d' config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 15:50:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 15:50:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495253.765560 (Exim 4.92) (envelope-from ) id 1pRxZY-00076g-Pi; Tue, 14 Feb 2023 15:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495253.765560; Tue, 14 Feb 2023 15:50:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxZY-00076Z-MP; Tue, 14 Feb 2023 15:50:24 +0000 Received: by outflank-mailman (input) for mailman id 495253; Tue, 14 Feb 2023 15:50:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxPO-0001Wn-MX for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 15:39:54 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on20617.outbound.protection.outlook.com [2a01:111:f400:7e8d::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d28a18a6-ac7d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 16:39:53 +0100 (CET) Received: from MW4P223CA0010.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::15) by CY5PR12MB6648.namprd12.prod.outlook.com (2603:10b6:930:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 15:39:50 +0000 Received: from CO1NAM11FT113.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::ba) by MW4P223CA0010.outlook.office365.com (2603:10b6:303:80::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24 via Frontend Transport; Tue, 14 Feb 2023 15:39:50 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT113.mail.protection.outlook.com (10.13.174.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.26 via Frontend Transport; Tue, 14 Feb 2023 15:39:49 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 14 Feb 2023 09:39:48 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 14 Feb 2023 09:39:48 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d28a18a6-ac7d-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJ4ITEASRc/8Sb5R+HVd89wxpTlQRlZPDGASieTg4pAvNLMj/IflPLGdVXMYS/2W9Cj8LqUSk8OMeI7JhlWuLAk/VqMuPwGqkY4EwWKVPRH6F9nGGoIVVh2R5cG5h46frHEbJwcZ3kGI4cxBakBJ534vRvpCoP7hTsHM1+O1drEEd+ir6PxOayEu5f+BfeAVpCbfYyKMk8iOjxOsL3JvjdMqRPuvl202fS5/yZIJPVnJ8HfsMJUKr3MQoASVfGSXTyQ7NPoAmESwNIckdjb9XbILr1EBcPu9EkkKQ0DQ/2f5v93LfoYdOX1+XbV1EvIpOWn+K+cGOsRq7VsROQMASQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=idbIK0WFX/oj0rIMVRUxvERZADW8zVY79vH5sqj84xw=; b=BX+jdvDKpMNHg8B+rhZm/Xnd/qfeBkE0X0WN5NEUew5X16dd0t5PtgcG5fO0uxcWE5SK9cMPFVUNuOvuPPBtO+FExvbDb09CGFCWAOrcBdhQdRGHgCyGDEG6C0PJSH1woO9Vl3snDn1n9mmHQ/XHrla9X5ixywZSWovefKkxCagHV/iuC7kgHtJ6ZVvnWRhtuX4skBHzYco+6lPf0nJ7COsLay9H0VuIbj3XAPAMl623DMCG/bKYh1Mvpa4o2lrYWrAvdkKDnNAef2+B1mcLtfqPlCx9j6iKRH7ZaKZaaUT1vQhEeJwXW+TD6CxyVNtMHYlML5C8OxDH4B5c8azGSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idbIK0WFX/oj0rIMVRUxvERZADW8zVY79vH5sqj84xw=; b=JbVpWfvkGSCi6vRea/zKRZJrUzlMt3pBNhySJNeEfl7JuJEj/LI7cixC+IigXK8AH64V+bQtSFmezkb2GcFJrOSXoYGW5+BcUvXUN+ylwBQe300UIovyrVbGdU4XgDef22DzvQwxrWq+Ih8z+RUWoC16Nrvbw8cODmCHf7hs52A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v2] automation: Add container and build jobs to run cppcheck analysis Date: Tue, 14 Feb 2023 16:39:45 +0100 Message-ID: <20230214153945.15719-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT113:EE_|CY5PR12MB6648:EE_ X-MS-Office365-Filtering-Correlation-Id: 45139c04-b8b1-4825-b126-08db0ea1b582 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rlfI0F9CPqhka3XvK5wD17sVvsCwJP3/Vg24N3QBquwWLXhEdY83FCnqQu5RSZrIBNS7txoZ07Rz2P9ItNkIL29BvGom1lKIb8iyY19e3Q6MgHFhod7Lj36YaEXfAbzVGtz+BXUK/8usTfw26r/KTDLmDbrQ8Q0FWZuTzxbMT23D5z5Z5p/5s5yktC4ziDlhxg9OKId11Ks1V+Pig4ECKwRQq9XCSk0Kf8b0yqAltAX3UyEUkSGpirP25Kqd8/AwQ5pGDrzGpfpXZexNDnlHodjMt3mw372qFCIlFJn1oO+KsxFJbnidUWTVHN74FH2sGhtTWKHmeSJ+bj2187K19WxVFmZZkofeUh/3D3ohcvmEsXqgegJ+WGAY7hR/z2kn9/jFHk8S8/hjMJvnvwIP4fLImGQbLidGLdybhjNW3/Wnc/AphDKm+1p293fNlxXoGwahWmftOKRJNXkMOoVmZlnuzrRfs8svYd5dA49g5RVpWX48ghByCiLPu5zmppEEydGlqmAvwri3iSUqHSTYlowyMsF7Srw8C01K39oFXaG1Ys5m6zCd14dBAdHitFxLqqUP4AjtFViQtLxttr/U8o511w8eF29HSoM4KGc+E7YjrLat8e8XyGgcIxLnV8mtNgsf9a3MLP9UJDInRwguWEqy9RKbhNyd/Jl3DOOPH82I1Z4/rHuJXCSO4HDP4+oAAE0wb+WX7fU8T/D+EK4mKoqM/IM0a2hkZH2FAUlgDYhcu/W8QQybhswrCFIy/qB9NwpNvlNPlLoAFeRhXwaWRQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(396003)(346002)(451199018)(40470700004)(46966006)(36840700001)(8936002)(5660300002)(82310400005)(86362001)(41300700001)(356005)(40480700001)(36860700001)(36756003)(82740400003)(44832011)(81166007)(40460700003)(2906002)(1076003)(336012)(426003)(47076005)(6666004)(2616005)(478600001)(966005)(83380400001)(4326008)(54906003)(8676002)(6916009)(70206006)(70586007)(26005)(186003)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:39:49.9259 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45139c04-b8b1-4825-b126-08db0ea1b582 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT113.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6648 Add a debian container with cppcheck installation routine inside, capable of performing cppcheck analysis on Xen-only build including cross-builds for arm32 and x86_64. Populate build jobs making use of that container to run cppcheck analysis to produce a text report (xen-cppcheck.txt) containing the list of all the findings. This patch does not aim at performing any sort of bisection. Cppcheck is imperfect and for now, our goal is to at least be aware of its reports, so that we can compare them with the ones produced by better tools and to be able to see how these reports change as a result of further infrastructure improvements (e.g. exception list, rules exclusion). Signed-off-by: Michal Orzel --- Changes in v2: - use arm64 container instead of x86 to make pipeline faster - explicitly set HYPERVISOR_ONLY=y for cppcheck jobs For convenience and own testing, I built and pushed the new container to registry. CI pipeline including dom0less series: https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/777181033 --- .../build/debian/unstable-cppcheck.dockerfile | 37 ++++++++++++++++ automation/gitlab-ci/build.yaml | 43 +++++++++++++++++++ automation/scripts/build | 11 ++++- 3 files changed, 90 insertions(+), 1 deletion(-) create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile new file mode 100644 index 000000000000..54b99f87dfec --- /dev/null +++ b/automation/build/debian/unstable-cppcheck.dockerfile @@ -0,0 +1,37 @@ +FROM arm64v8/debian:unstable +LABEL maintainer.name="The Xen Project" \ + maintainer.email="xen-devel@lists.xenproject.org" + +ENV DEBIAN_FRONTEND=noninteractive +ENV CPPCHECK_VERSION=2.7 +ENV USER root + +RUN mkdir /build +WORKDIR /build + +# dependencies for cppcheck and Xen-only build/cross-build +RUN apt-get update && \ + apt-get --quiet --yes install \ + build-essential \ + curl \ + python-is-python3 \ + libpcre3-dev \ + flex \ + bison \ + gcc-arm-linux-gnueabihf \ + gcc-x86-64-linux-gnu + +# cppcheck release build (see cppcheck readme.md) +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ + cd cppcheck-"$CPPCHECK_VERSION" && \ + make install -j$(nproc) \ + MATCHCOMPILER=yes \ + FILESDIR=/usr/share/cppcheck \ + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" + +# clean +RUN apt-get autoremove -y && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* && \ + rm -rf cppcheck-"$CPPCHECK_VERSION"* "$CPPCHECK_VERSION".tar.gz diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 079e9b73f659..1441b7dbb6fa 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -7,6 +7,7 @@ paths: - binaries/ - xen-config + - xen-cppcheck.txt - '*.log' - '*/*.log' when: always @@ -199,6 +200,23 @@ variables: <<: *gcc +.x86-64-cross-build-tmpl: + <<: *build + variables: + XEN_TARGET_ARCH: x86_64 + tags: + - arm64 + +.x86-64-cross-build: + extends: .x86-64-cross-build-tmpl + variables: + debug: n + +.gcc-x86-64-cross-build: + extends: .x86-64-cross-build + variables: + <<: *gcc + # Jobs below this line archlinux-gcc: @@ -699,6 +717,31 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Cppcheck analysis jobs + +debian-unstable-gcc-cppcheck: + extends: .gcc-x86-64-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/x86_64-linux-gnu- + CPPCHECK: y + HYPERVISOR_ONLY: y + +debian-unstable-gcc-arm32-cppcheck: + extends: .gcc-arm32-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- + CPPCHECK: y + HYPERVISOR_ONLY: y + +debian-unstable-gcc-arm64-cppcheck: + extends: .gcc-arm64-build + variables: + CONTAINER: debian:unstable-cppcheck + CPPCHECK: y + HYPERVISOR_ONLY: y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/scripts/build b/automation/scripts/build index f2f5e55bc04f..7d1b19c4250d 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -38,7 +38,16 @@ cp xen/.config xen-config # Directory for the artefacts to be dumped into mkdir binaries -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then +if [[ "${CPPCHECK}" == "y" ]] && [[ "${HYPERVISOR_ONLY}" == "y" ]]; then + # Cppcheck analysis invokes Xen-only build. + # Known limitation: cppcheck generates inconsistent reports when running + # in parallel mode, therefore do not specify -j. + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra + + # Preserve artefacts + cp xen/xen binaries/xen + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then # Xen-only build make -j$(nproc) xen -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:10:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495262.765571 (Exim 4.92) (envelope-from ) id 1pRxsK-00018l-G2; Tue, 14 Feb 2023 16:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495262.765571; Tue, 14 Feb 2023 16:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxsK-00018d-DN; Tue, 14 Feb 2023 16:09:48 +0000 Received: by outflank-mailman (input) for mailman id 495262; Tue, 14 Feb 2023 16:09:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxsI-00018X-Tp for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:09:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1a::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fda1c285-ac81-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:09:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8355.eurprd04.prod.outlook.com (2603:10a6:20b:3b7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:09:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fda1c285-ac81-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jy6SqNzSeMQV5UA+VmbK7JrB/Zt0vwwOjDsQpmOIVklrgTFB1nBNNDy8J/fS2a0Rf7WEKwMXUVZsgcpYeqr0kAQmNRJgcBzcFqDzEDCrsJmUdW/H35XZrM7Bo9/dC/NAIuCoVlfDqKVMWT1HCHgoNeyXIhaS45/uAS3Tb4cd9MZC+hly1Jf2SU9XM0RkK35i3Ar71GjRUobnKTHvRHjfQ8yHcE6rJfZAK/Ni7RO4mtDb8+fzl4fdfBhbHe5/+AjaNVxZTxv8rgZAXQ6G0mvAfUMeIFInHOgI2lOJ9xAeCzbNlV5dMJtFfAV6mOy9zV+uJdGpZGBerdDuqx50vGPmfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xprwUPDQPzbG5hi8fYinkuvqBjSbr8pGUFSbo9sYTrA=; b=ih5uzeq/w5+2rGsGdPNkLSt95uVmllWI95ljRRzToRLCycr7I2oPOdG3xADucjunx/iZs8l6iggGqWWFJzjdKAHZVPQbeJ5HdA9nxedOQoX5nb1CbKWln93OYwaXlp7CRI4MKYGrmyWdL3E389Flgjhd27Y01nkV6XXcoUO+N5Y0sBKotnjwaR7VJTy3ezpFWZMoDC4Ic6lAEtW75nl9uJW8iLDNb/xpoftOu/FoYL2dSUd4nY/0YLHc7Jz6GCHC5g5gQ3wBLV5yzdzCc9fupgmlEeqCtdd4g0xa8lJRC/DYkzUG7gBu53NhT0YgDGH2nLz8rXbvgMKxx/q8ekVwGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xprwUPDQPzbG5hi8fYinkuvqBjSbr8pGUFSbo9sYTrA=; b=v9dj0zSplgzjyoRkp0uy8imYH02sdGE0LoFyX7YPS0ZmP7WxGG3BvVRbFTOAlp4wQlzrb2DHCaWOKjyh+nYpo52zJpzWGZL66JuPhec5T0MqHh2wSRGFU2QfvE+tLeCzXzpBONsPrkcuxQC+NS8w7uqc5DAS0u4E0kGwHSJ98IkBzNAAKIuIf93DX0+VXBzD7WPPd23eG5mlMjpP0zbT66gpJHxkRWTo0tVPvR/2e+mRUofUMoA6MNWBfbGCQg8XP/gKaSe2Id7jDTmW88TdHdunR9NOITvSMoIL5I0VGwq2F3JvPtRY8pNcyCwAuu6jq9iPP/iyz5GajhG/sXsnPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Date: Tue, 14 Feb 2023 17:09:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 From: Jan Beulich Subject: [PATCH v4 0/4 + v1 0/1] x86/spec-ctrl: IBPB improvements To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8355:EE_ X-MS-Office365-Filtering-Correlation-Id: cd04a135-7368-4549-f2d8-08db0ea5e066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qjOmW5gmJB3pmnZjDDC0kZqe3LD95Zh6nlabVOMwn3zRYRCWsI8Ws38IlENe9OsGwUS4qSp6jWubIgpnZUocg0a75nrzGge7fJ3+GWOCuwaqIGtddTGP3LgcuHRzem4FAgG+xoETFAE9fXaC8SWbD+HsnkoMXExy65ltaWQ7+ukbtCrC8NslSpTtLtzcogtDzhLmcDO9CgdkKDOoL2umKa3lzHoTSUlNgE+pBeajcUl4fuPMqqQskEkV0hAe6okR2IlbXVd9gIr3GJHEUK/j2nTu8Spa2XK43EvlGkxJz42TtF7i1JJOD7+1CrsFPBAgQPH30dUGj2TCRRkDbGUL6k2ESC+nMnHLH4ikKKS3ot046eOLbgVH8K0ilmBmYlKCNMxNVItQiGyL6YJXzGDcY9HLpVEhL/wj43LVvCZ88YZAFaEj+4c/zlG5khNN9yWSZ0WaXHcCrHLhpu/OBNK7vazM1GwXSg3hLNvOXLhEHSLM5VZAAYWCC8Fv63dEgZ+A4+uLftN5sYxteCxZmwzjLwVlM1NrcfJK84w+Mo9VyYbyZWySp4X8oGk83qWdCDfncYap5IenDLvXn4785stnVyTZmyqNAu0FL277fE/qjNni1RiHMxLYbSnG2z3PnLQW2iVM7OpIgJ1Tv6nxsqv6eyrSkh0CA/gIaVYMQkt7K/1RKbsmABMTUTC6t0GtfPUtsD0ZRY279I085TQFG5OpDbEMcM6gvScXghWQ1PtSKYY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199018)(6512007)(186003)(31686004)(4326008)(8676002)(66946007)(54906003)(316002)(31696002)(86362001)(36756003)(2616005)(26005)(6506007)(66556008)(83380400001)(38100700002)(478600001)(6916009)(41300700001)(66476007)(2906002)(6486002)(4744005)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUhLZ0hSblVsVjIxOWxabzVaQkJYTnplNW9Bc0p0ejkwVGxINElOTGFiNzVn?= =?utf-8?B?TVYrck1FZ0h4VUdDclBRMkRBZTltYVBRclVLRGRCL3dEV3lVYkFsQzFwRFN2?= =?utf-8?B?U0tWMlNWNE9mczRMZlVKWXRGWEovMzhVQnVXSFlqOVRPWW1RVEd6cWs1VFlO?= =?utf-8?B?UlNFenFUdVpCUXlqczBoZ2dDRFdtRUJ5eGFpNXlYQTJnRFdvTG9Dd1lTN0Mr?= =?utf-8?B?Z2tMbmRMakw5T3ZIUW45Tkp2RUpxNU1uMHFyRHlUbzRoUnh0ekpMQ1VlK0ZH?= =?utf-8?B?L2pvWE9nYU1xa3BCMUp1aStVancrTHN5d1RuS2NWbmJobXFuY0NKQVd3VjBi?= =?utf-8?B?c2JFa2tIcUp1Nk50SzBPUDc4ZDcvbnBVd2RSby9ZYmV4WldyOWZ0cnVkQU0r?= =?utf-8?B?aE8zZ1p1K2FmTDM3d2pMdllySHZKL2NtVVhHQnBGalJNUkQxWFBNT0d1TWVB?= =?utf-8?B?c0dtMlBURUovVko3SlhROUNGZ1VLYmsxa2lib1FLYW9sZkR4Z3lJcVh4R0ht?= =?utf-8?B?QmFITllRK2xnTGxvSkdhcmNrbW96NXFyZlF0SHdIcU04LzJ1TVBLK2FiZEEv?= =?utf-8?B?dWVrRDIyZW42MmdwZWtkVzl0ZHd4N0JnOUh0dzJBcUlOWWp2RjhKSVMrYXlH?= =?utf-8?B?SGc2bkt1amhlVnZLd2drZDlxbG55VFc4WW81aUJvcFUwa2ZOejNyelBRYWRq?= =?utf-8?B?TXkrU3JONlFaS1VNaUpJUlkzYWN3cDk1QWtjSjJ5Mksxd2MwUm0vanFDb3ph?= =?utf-8?B?SjV3VDVnb2IrWFJ4Q0RUY3FEeC9nVm9XaCtkK0V2V2hYSU4yN2RqRlNwN0Vv?= =?utf-8?B?MisrenJ3Q1NIdnFKMHc4YTdFNlNWVWVKWW1vMlNtSGE4TTQ0OHlJeUxIMklZ?= =?utf-8?B?amlBWXYzMklsOXJSSzFUNEgzNWNOdktEUURMMHZocG1BS2NOZU54N3hWeFdz?= =?utf-8?B?NjVzYlVjbW83N2crbUJrYStIVGVOQTUrb2FVdXRqUEZHRDU4SDhXb0RaU25v?= =?utf-8?B?dTRBeEFGaTJyOHJ2WFQ1Vk94eUpJRUcxbG50Z0Y4NzJ1b2ZKSVZTdDUvTVV4?= =?utf-8?B?akRtR0F4WEx6Myt0ZXJnaGFmTFVuU0ZEem9Xdk1VeHpNbUtUbytLRk9UOWw1?= =?utf-8?B?WFhUTEYvOWdSVjBkT1lWd2I1YmlZL3AxTVo4WHZwRUduTTFVTWtuRDRUUHdW?= =?utf-8?B?cGloSFIrWlRlNnZYVm40OENibDNFV2Z4TjJOSXFMYVNJYXBLdnVGd3MxL3Y3?= =?utf-8?B?WUc2bDlqREtkc3lCRXNrRlJGUS9WT3U0QWxlenpZSTZza2pVNHNrbTdzL2dm?= =?utf-8?B?RlFkTXI3RUl0M0VublFUVjJWSWhVaHpGVURGMms3dmNVU0p5dENWcGc3VVdv?= =?utf-8?B?RWRHYTV6aXA1K0tlOC9GVEl4eVJsejZidkhISWJBdnljcjVZZ2JDcGFsaDJZ?= =?utf-8?B?NmZyTE9NRDhDWWZUNGxUYXBWVFJ4emN0NjBvQkpDTkhBa25ZcmtjWWhoSGli?= =?utf-8?B?MlRiUVJQa2FZbFlORTFWQjk0TGc3T1V5dnhSS21mdlowdUJWaE45akJRWm01?= =?utf-8?B?MUZQY2lsUHF4NFVoZTVrVE0zU3oxY050d0w1ZXc4MkpDd3pmYkdrMTJPcjhw?= =?utf-8?B?RmRMRUk0WDM2N2lWczA1YlRaZGlySThyM0dsNGNSaVp4N3BBVzRSTWpXWXUr?= =?utf-8?B?bUhQMVdxV1YyOExxRVBFNzJhM2hlZ1R4YmZPeUowQ0FCb3N3S2F2anhWMFlK?= =?utf-8?B?dXBPazFaTm5EU3FyMlpKVGFGS1dldGZSWll6alA2NSt0eCtqVGluYmYxa1gx?= =?utf-8?B?Tmx2Zm4zNkRObnRTOFJTRkQ5d1k4QmNZLzZRNkNFc0tJc2tZQlF4Y2VJdmRs?= =?utf-8?B?SlJIU0kyU2pLZ1FsU0xvNmFzaHBDOUhFaXU0Sk5HV0xqT2tLelZLSEsyZ0hm?= =?utf-8?B?b0VmU1lKVUZoRG4wckhnSjlNQmN1dnMyNTZyVVV3dEJQVWlKKzZ3cmNidmJH?= =?utf-8?B?WG5nZng5ei9RSHViT05EN0xLU2JqVFdjMHRTcWI5M3dEQVdhSVFTZHppMS93?= =?utf-8?B?ZEV6K3ZpeFEwYURyQklWZjQ4WGRlWVVvQ25vSDFFWUpwbUNJVzdHWGpCbzVy?= =?utf-8?Q?1kNovxim0U4Olix+eViCOUX36?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd04a135-7368-4549-f2d8-08db0ea5e066 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:09:40.2949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sDxjJ2AYfAEUJdCOcL+CnninMMNpikB7VkjhnIUbjiIS1ADFzvo8uJRY2Rnwx4aIyxOgaLOFRbGtPSasMHRsPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8355 Versions of the two final patches were submitted standalone earlier on. The series here tries to carry out a suggestion from Andrew, which the two of us have been discussing. Then said previously posted patches are re-based on top, utilizing the new functionality. Xen: 1: spec-ctrl: add logic to issue IBPB on exit to guest 2: spec-ctrl: defer context-switch IBPB until guest entry 3: limit issuing of IBPB during context switch 4: PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Linux (new): 1: x86/Xen: make use of IBPB controlling VM assist Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:10:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:10:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495268.765582 (Exim 4.92) (envelope-from ) id 1pRxtI-0002T9-Pq; Tue, 14 Feb 2023 16:10:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495268.765582; Tue, 14 Feb 2023 16:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxtI-0002T2-Mv; Tue, 14 Feb 2023 16:10:48 +0000 Received: by outflank-mailman (input) for mailman id 495268; Tue, 14 Feb 2023 16:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxtG-0002M8-OA for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:10:46 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0c::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2331b82b-ac82-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:10:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7762.eurprd04.prod.outlook.com (2603:10a6:20b:241::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Tue, 14 Feb 2023 16:10:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:10:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2331b82b-ac82-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHKqHtymeg5pIoAYTaJzCv65oMHyTg50dbwr8+PBPq8W/Z+lrfeqrhF5GmRlX6FqQRuAHq7CGy9p8O7y0FKm2XlwLdd9zCuJt/36OPmJPfIi3G8P/M1Merpl83ix1WV1eixZ8baOJf1KseFIwSrnu7IYUGuEwlMr5Yj0elI90Sat0pU/Mwg/OIJ4RD5hJnqyCDlbGBYPNsjgpL64wcmApwFuSnvQGqq4LWIFRZBz6tKODMgHoJ/GrA53UImEGdwL2+6eo+KmZK/FR7uaKb6fCHRn9CExlfD09UcDwpD3jGi6mMQOFWzQ3wmT5z3aDNlFbEpf6k9LD1xrOSo/2V+cvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qINV3D+ZcJrc3TgcCf9Vkqn39yRf5xgMpf87ZeAdksY=; b=MBJdaUF5CZYxI1cBaZt1i0YaIFapmY8uXsZAnwbfpa+cyjDg+pBAtTB0gYaKWP3eR+HWOBVg+xKJkyWo4ZA9u23F2nfMck91v9fcFv0hhpL/1BLlLmjfBGCZhkYhg1X5KJ9E2CmmXQeGEHCm3AhBraAF+wERkFw7A0EXZQc1HtTKW/erCQpTEcqpNMy/Wcx/itIeyJJGmueqvpNaF9pgz7JF9yMR9Gn4Tvqtr8jeMeb22GvR9HDbLbFKtZ5+LUwXdNDrkePYkSgZgwr9nlTiXELER4coy7KJ2pKgpL01gfpMfDDNrILmdxAmyGOQ4QMCOM+i8rX9L6nrc/9wFV3oZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qINV3D+ZcJrc3TgcCf9Vkqn39yRf5xgMpf87ZeAdksY=; b=JIk6Q64r4XADHN0wkRm+eFGpcSC+ZN/c6EpNS0x3QtZr/+XwBL/cVBj8xV7nmY7EcXAQ/xoVkmWbnoaiqhqHyYVhWinxKAUxeI/kvwu34KrqSOtUr2T0F5VCk/kUnojPGIepbtTsHUIY3iFvY0yfu4r4TTYHG9S3BdKXsPm0++2rmMMKzfLf0qw+QnwxAurRNz6A1Dx7LwZWy0gEwfPNFqwPdVHIYBTT+jTbJe8MCQQHkeTMAJcxnOPlGOT/0LoTVFf8Yn4Nh1TB4zrQz4xI3mGSXeYwWGVQgun+EiwYCfpFZciG/xxaRtX+8k8CH8wPgaMwJqqFMKnK+EsbMNLMeg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <31da79de-bd6b-af95-793a-c16516992bc7@suse.com> Date: Tue, 14 Feb 2023 17:10:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: [PATCH v4 1/4] x86/spec-ctrl: add logic to issue IBPB on exit to guest Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> In-Reply-To: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7762:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f0435f9-ef97-44bb-2f03-08db0ea60687 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n86WPBjsffWLWWt3UNQYbrITvMKYI6KPsOnBeEVWiVhy83TzhLqiP7+G7loRTEqbQxSUJlkUO0FH+RhcGysigISHOzxKvD2FEPIlMxsnC1DjfIFixVzjQPYMehEA2zJBIZHelO1vLsRdapktmI+4paxUux0v5Hr6URpWiOvCpwOWOFm2m9S0j19I1yrjsde+T8qzMPuqTDjBYcD+X3YLHtg1TFnUB/ci8jBSeY+ClgUbnoizZ24ZngCFermN3mliMFZ64lgnK2qHgYm8GxUZqOy08fIsAuDPcIvZSYWB+eIFnjOAHG+LHHzOG4njLRIJLHfDHOkKipGO5kOT1+ZFDdDauS0HBm5sG+RaYdxssraGrTBcAKm9W2bY04ET96JIlMf8/dJWp1ZEIOzZ5V+hfPd2WgEwROqmLzHmQumHjboaQKyWYqkLZi8NQ1TxSZ8J5V7Y6es/a7zSdvD53qw+ABX4Z841F00hKxFSWVtiPT0S5CH87Y839JWZQ4/YSAgnETcrx1r7sSMdg+Coj05HwKR+ytuVC7dYIqToR37gEeJn3SVoFxxpKD8kXAEt+HkfinV7Bh6AtRPIa/UUnJ6/MxC1nHSRuvFMl9Q4rYnZkF36HLTraOwC1KBYrClDiB5bSZxN7cBZMji0FyvLAZi8Zy8ekdOgwLMw7uzT93gOp3ri9zjBSJBuvHltYc8221Azs9y55RyGAgel7HcLOZjjTdSkz2LlyvceNhQDUQT+GtQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199018)(478600001)(36756003)(38100700002)(66946007)(54906003)(66476007)(83380400001)(66556008)(6916009)(4326008)(8676002)(316002)(186003)(26005)(6506007)(5660300002)(6512007)(6486002)(41300700001)(8936002)(2616005)(31696002)(86362001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDJBTzdUMmV2d1I2a3d3V1UwcjhZdEtzQ1V6SUxyRGlLVVhPUjc4YVZmYTNF?= =?utf-8?B?ck9BRlV5RnB0TGpwQzdNQ1haS3NkOVh0VE9wVDVsZkpVNGZ5REY1a0tPV0dB?= =?utf-8?B?bTZvbXQ1Y21qTmRkSWFlOEFTekpBYktlbGhuSVl0aktxdFk4RUFMZENkaExk?= =?utf-8?B?ZzZncFhwQTFxa04xVVJvQWxKRmZsQXI1S0FITWFBdXIzV0xyRm5NZHFJT0Zw?= =?utf-8?B?VVczL2JsdGdTM1IvcUpPUVZKbXNYT3BGQ1ZENWxGRlBWd1hoTWEzV1U5ZS9V?= =?utf-8?B?R0lHUE8xSlh4bkFEY2FIUFBMSkFqSWpWeHNwdTl2Slk3aVJ5Q0JISnJORElW?= =?utf-8?B?V0VzREVJNVJDNExvdDNMNFFCZHJrRWpueDN1ZE1Pa3hIK1RFWXBETUc0K28y?= =?utf-8?B?bVpyVHVKcG9LOVRPRUFJa0hKcUlQYkhPdU1XTE01NDNXZ0l6dTcvTHkwSmZx?= =?utf-8?B?UXQ2R2hSVjEyeFhoK0NSR1dmZDlYYXMzbEk0aG9aelBLRm9xb0cxTlcrZEpI?= =?utf-8?B?STg5WDZ6dWtHSUJEMHBmbmxmM1dqdTh6YisvL3piQVJ3VnE2RDhCSld3SVJw?= =?utf-8?B?WjN3aWpiekFqRkU3elpJdnc5bEMxY2NFR2pEbG1GUGR5amt2eGZBUHh1cXk2?= =?utf-8?B?blZ3aVJsSkRiWkZYdThYaFdkZlNvblFwcWtJL0JscHczN0I1YXlCKzR5RzhY?= =?utf-8?B?S3A3Y00ySDloZU9rS1JTWHh4WXZVdEIvVWc0M2crNkZBZ0JyenFyVUNhZnB6?= =?utf-8?B?RWVnUUNEbGJFQnFvMDg0TE5DRDhRcHRYMU9sZEFOWjJoKzRzUjVKOTVkR3NJ?= =?utf-8?B?RjZOQ3BUWmhqNWk1SE1nMXltcHlaSVZFbVI3SGF4REIxVnVVUWptMWVCVXhT?= =?utf-8?B?RWVGTzMyTUdPem82Qm1Zd3JkcXZ2c1pVaWozYnpub3JSRXcxbHF1UitmMzUy?= =?utf-8?B?UVhmVUhSL3B2c2FSZzE4d2p1QkVvdkd0K0RRTjVhWkViUm8vMU1YM2s2cDZ2?= =?utf-8?B?ZTFNVmYwbEpsNVUwY2I2emhYYzFWUm52cUhaSTVsaUcrN2wyRE1adndZenVX?= =?utf-8?B?WXpjSUZWTW5vZmFCSEJtMDJpeE1PNkNiblA1RXVDR2Z2QjFKakZqeFRObjBH?= =?utf-8?B?QjBZbzh2RE9LV2JKVmthWmRDSmdQR3Zob0xDSVJmLzVpdmdIcXNWOXl2bE12?= =?utf-8?B?dXpmdk05VkhBVTVWeTRzbWVQVm9yYkdqYUM2VExmTlc5OG9zOHJXQ2NXOXkz?= =?utf-8?B?bTNqRnkwMkdKbXRjakZkTTdsVlpLdzlYSXNUbFM0SWlMWnpTc1RNT2tHZzdE?= =?utf-8?B?NTF2bXVVUi9udmdEb0pGaktkcDRNRGFUTEhUMkxyaitUSTdwZWtSS1l3NUk2?= =?utf-8?B?eW1KNDBPa1QycDYvekhxTTh3VHdYdGt1YjMrOUs3dENyWjlJb0lmR3pUd1FY?= =?utf-8?B?anFBVVpKbzJkNlNNU0hhaTFBOEJzamxJUGNlSlVpTkhzQkc4MjRjYlhIazNv?= =?utf-8?B?ZUQ2YXFuMUp1N0g1QWE4TTE2NlhpL1pTdWtrVWJxVnl6T3hCUm5sTTY0NUtW?= =?utf-8?B?SkE5U1ZvL2lmT3hJK1ZTL1VzNDZCaU53Sm5rUkVwdmswZUNIbnJWOGI3TzB0?= =?utf-8?B?eldadDRzQVB3Rll3dWs2NHpyeTFja25UY1dDTDVMUEN0ZzQ4NlArQ2x1UWV1?= =?utf-8?B?bWtUNUd4aWR1aXdtdk42SnVnQS8yUFVuSkZzdXJlMUxQZjVVajByZ2dyMnEr?= =?utf-8?B?dWFENitVeCt5RWZxY3ErcnRFTmtlZDcvRWtSa0RwNzA1VXNLNGFMYWlpU0Fo?= =?utf-8?B?MXJGVW1vNGRtMXo1Um83c0xDd3Q1aWJFTlNkU1A4dEZDWEt4dC9TNys3Mmxl?= =?utf-8?B?N2NranhKRW9NN0I3UjlmdEluRXBsbnJzUmFKaFgzeWthS0NzQWhMRk1KVXNP?= =?utf-8?B?VVE0SlJZOHp3NEx5Z0l4UjhQQW5Da0h4czN2UXJYSGtkY2ZJdGc0MUdRdFJY?= =?utf-8?B?RlR4SStRYTJtM29BMjFWbW45ZkpQR1A5Wm1LV2tvem53a3AyM1BEdnJzcVli?= =?utf-8?B?WVJ4Q016a0ZScjg2MWRDTFhweTBuaWlaWjArWlpCQ3N5SW9QcTdKenkyZkVQ?= =?utf-8?Q?cfAXrVtjEpyY8dbP7SzswKsvX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f0435f9-ef97-44bb-2f03-08db0ea60687 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:10:44.1346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HSR4vY6U+bycIlNrgNO352A+Mq3+4nIL9IdVRDSRhDvccPhRwgfZmBdSf5m8IPSC4k+3jqkfudCtOCeC3adbFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7762 In order to be able to defer the context switch IBPB to the last possible point, add logic to the exit-to-guest paths to issue the barrier there, including the "IBPB doesn't flush the RSB/RAS" workaround. Since alternatives, for now at least, can't nest, emit JMP to skip past both constructs where both are needed. This may be more efficient anyway, as the sequence of NOPs is pretty long. As with all other conditional blocks on exit-to-guest paths, no Spectre-v1 protections are necessary as execution will imminently be hitting a serialising event. Signed-off-by: Jan Beulich --- I have to admit that I'm not really certain about the placement of the IBPB wrt the MSR_SPEC_CTRL writes. For now I've simply used "opposite of entry". Since we're going to run out of SCF_* bits soon and since the new flag is meaningful only in struct cpu_info's spec_ctrl_flags, we could choose to widen that field to 16 bits right away and then use bit 8 (or higher) for the purpose here. --- v4: Alter parts of the description. Re-word a comment. Rename flag and feature identifiers. v3: New. --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -75,6 +75,12 @@ __UNLIKELY_END(nsvm_hap) .endm ALTERNATIVE "", svm_vmentry_spec_ctrl, X86_FEATURE_SC_MSR_HVM + ALTERNATIVE "jmp 2f", __stringify(DO_SPEC_CTRL_EXIT_IBPB disp=(2f-1f)), \ + X86_FEATURE_NEW_PRED_CTXT_HVM +1: + ALTERNATIVE "", DO_OVERWRITE_RSB, X86_BUG_IBPB_NO_RET +2: + pop %r15 pop %r14 pop %r13 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -86,7 +86,8 @@ UNLIKELY_END(realmode) jz .Lvmx_vmentry_restart /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ - /* SPEC_CTRL_EXIT_TO_VMX Req: %rsp=regs/cpuinfo Clob: */ + /* SPEC_CTRL_EXIT_TO_VMX Req: %rsp=regs/cpuinfo Clob: acd */ + ALTERNATIVE "", DO_SPEC_CTRL_EXIT_IBPB, X86_FEATURE_NEW_PRED_CTXT_HVM DO_SPEC_CTRL_COND_VERW mov VCPU_hvm_guest_cr2(%rbx),%rax --- a/xen/arch/x86/include/asm/cpufeatures.h +++ b/xen/arch/x86/include/asm/cpufeatures.h @@ -39,8 +39,10 @@ XEN_CPUFEATURE(XEN_LBR, X86_SY XEN_CPUFEATURE(SC_VERW_IDLE, X86_SYNTH(25)) /* VERW used by Xen for idle */ XEN_CPUFEATURE(XEN_SHSTK, X86_SYNTH(26)) /* Xen uses CET Shadow Stacks */ XEN_CPUFEATURE(XEN_IBT, X86_SYNTH(27)) /* Xen uses CET Indirect Branch Tracking */ -XEN_CPUFEATURE(IBPB_ENTRY_PV, X86_SYNTH(28)) /* MSR_PRED_CMD used by Xen for PV */ -XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen for HVM */ +XEN_CPUFEATURE(IBPB_ENTRY_PV, X86_SYNTH(28)) /* MSR_PRED_CMD used by Xen when entered from PV */ +XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /* MSR_PRED_CMD used by Xen when entered from HVM */ +XEN_CPUFEATURE(NEW_PRED_CTXT_PV, X86_SYNTH(30)) /* issue prediction barrier when exiting to PV */ +XEN_CPUFEATURE(NEW_PRED_CTXT_HVM, X86_SYNTH(31)) /* issue prediction barrier when exiting to HVM */ /* Bug words follow the synthetic words. */ #define X86_NR_BUG 1 --- a/xen/arch/x86/include/asm/current.h +++ b/xen/arch/x86/include/asm/current.h @@ -55,9 +55,13 @@ struct cpu_info { /* See asm/spec_ctrl_asm.h for usage. */ unsigned int shadow_spec_ctrl; + /* + * spec_ctrl_flags is accessed as a 32-bit entity in certain cases. Place + * it accordingly. + */ + uint8_t spec_ctrl_flags; uint8_t xen_spec_ctrl; uint8_t last_spec_ctrl; - uint8_t spec_ctrl_flags; /* * The following field controls copying of the L4 page table of 64-bit --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -36,6 +36,8 @@ #define SCF_verw (1 << 3) #define SCF_ist_ibpb (1 << 4) #define SCF_entry_ibpb (1 << 5) +#define SCF_new_pred_ctxt_bit 6 +#define SCF_new_pred_ctxt (1 << SCF_new_pred_ctxt_bit) /* * The IST paths (NMI/#MC) can interrupt any arbitrary context. Some --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -117,6 +117,27 @@ .L\@_done: .endm +.macro DO_SPEC_CTRL_EXIT_IBPB disp=0 +/* + * Requires %rsp=regs + * Clobbers %rax, %rcx, %rdx + * + * Conditionally issue IBPB if SCF_new_pred_ctxt is active. The macro + * invocation may be followed by X86_BUG_IBPB_NO_RET workaround code. The + * "disp" argument is to allow invocation sites to pass in the extra amount + * of code which needs skipping in case no action is necessary. + * + * The flag is a "one-shot" indicator, so it is being cleared at the same time. + */ + btrl $SCF_new_pred_ctxt_bit, CPUINFO_spec_ctrl_flags(%rsp) + jnc .L\@_skip + (\disp) + mov $MSR_PRED_CMD, %ecx + mov $PRED_CMD_IBPB, %eax + xor %edx, %edx + wrmsr +.L\@_skip: +.endm + .macro DO_OVERWRITE_RSB tmp=rax /* * Requires nothing @@ -272,6 +293,14 @@ #define SPEC_CTRL_EXIT_TO_PV \ ALTERNATIVE "", \ DO_SPEC_CTRL_EXIT_TO_GUEST, X86_FEATURE_SC_MSR_PV; \ + ALTERNATIVE __stringify(jmp PASTE(.Lscexitpv_done, __LINE__)), \ + __stringify(DO_SPEC_CTRL_EXIT_IBPB \ + disp=(PASTE(.Lscexitpv_done, __LINE__) - \ + PASTE(.Lscexitpv_rsb, __LINE__))), \ + X86_FEATURE_NEW_PRED_CTXT_PV; \ +PASTE(.Lscexitpv_rsb, __LINE__): \ + ALTERNATIVE "", DO_OVERWRITE_RSB, X86_BUG_IBPB_NO_RET; \ +PASTE(.Lscexitpv_done, __LINE__): \ DO_SPEC_CTRL_COND_VERW /* --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -156,7 +157,7 @@ ENTRY(compat_restore_all_guest) mov VCPUMSR_spec_ctrl_raw(%rax), %eax /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ - SPEC_CTRL_EXIT_TO_PV /* Req: a=spec_ctrl %rsp=regs/cpuinfo, Clob: cd */ + SPEC_CTRL_EXIT_TO_PV /* Req: a=spec_ctrl %rsp=regs/cpuinfo, Clob: acd */ RESTORE_ALL adj=8 compat=1 .Lft0: iretq --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -9,6 +9,7 @@ #include #include #include +#include #include #include @@ -187,7 +188,7 @@ restore_all_guest: mov %r15d, %eax /* WARNING! `ret`, `call *`, `jmp *` not safe beyond this point. */ - SPEC_CTRL_EXIT_TO_PV /* Req: a=spec_ctrl %rsp=regs/cpuinfo, Clob: cd */ + SPEC_CTRL_EXIT_TO_PV /* Req: a=spec_ctrl %rsp=regs/cpuinfo, Clob: acd */ RESTORE_ALL testw $TRAP_syscall,4(%rsp) From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:11:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:11:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495269.765593 (Exim 4.92) (envelope-from ) id 1pRxth-0002uK-38; Tue, 14 Feb 2023 16:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495269.765593; Tue, 14 Feb 2023 16:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxtg-0002uD-W6; Tue, 14 Feb 2023 16:11:12 +0000 Received: by outflank-mailman (input) for mailman id 495269; Tue, 14 Feb 2023 16:11:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxtf-0002sY-MV for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:11:11 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20627.outbound.protection.outlook.com [2a01:111:f400:fe13::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 316928c8-ac82-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:11:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6884.eurprd04.prod.outlook.com (2603:10a6:208:183::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:11:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:11:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 316928c8-ac82-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C99l2jMkVu9rzdHMOsHKmHwNS9BXezQ2iP6vvNFPn7+Ff87icPa6QXJJSf69OqINNj+HFCHRqE1pW5f6y1Podjz4FckXyBrTJrH6NQPBIXHt89JmRkuab+M2fJMTqspvodejXDQrv0Rk2Hzxaz6UWl6+/nC/sC2jdRZuJn3vNOwDHUOVa3NXULbrx+3ZBZ5mTA330aiuykWUL1VdDxEYEeWVqQW7J+BKWRGpeWIk4mU2x1NaWOwwDbwhFFwBl8a5qNWfgSWU4+Tps5YRP5wwwyvjNcoDIHI9aWCG/Ev1KQU4w1Tiw2X+AoH0s0pQDocvvpVmBsTipiROv3ICVra/9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d+/DUjrNApE1of8R+q9OMsOXlsFTj99u5P7jS1EbUzw=; b=HlzK3w2z8vDcWlMOVrr3ldmCB5ym69dXwYYUT00Q9Da+RmIC1lzD/YbrFA2lb5yI65+WT9Ohn/LSiffFGlLnr6r+LaJntmrAM/CrWlZlzSufNcK908kkERraUTybrM8koUyX5OTYolKXZxyOgUF9RQbXe9f8ANTGxgT0V3Gu6tcYwQCFsm9P6YWw+oRcTi1tydtGOUfAXLv+fxWL45fTBlV3rQWR7X1AqTXe4NZ+Ud4nOdIzZ1/GidrCBE18V3YGX7vyLUjQfOS7h0bPmVouYbVZEVfNZ/qjY+LHy4CI9nmerebukVq78HXUHW8uh9HRbDL4ZLHRd4FkOtqRiCThUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+/DUjrNApE1of8R+q9OMsOXlsFTj99u5P7jS1EbUzw=; b=mp379rXn8PAvUHg/0/2DNWWpDwNNxjCs8VFu5C9ewGCfl2xvKM91ZhuGzGwioznnlnmK+5ZAd7bc5XcPKkQZt42/61v2ZhD6ICwphB7Qvd0eh7JuAFKBXgmUa4Etf0O6O8e8a6afSqERds85Vk9b1g/n2uXW032z46hEvcMchvVuG3M9YUfKaDxHBasxJxN6Koqj161N/L3WCijP3qDIUY5AkcdWqCWN3/J4Mb9/kSOZK+zM0MX7+/vWhkQnZwO54xJ0i5HSKzmUszprnk0lAt2YvLuRorif8pmcAeLHHX4tVY5SJMU6oS6nuiF73s/HMEfIzjPDr76GrmL7W1/J0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83c2a504-bce4-d3e7-1d9a-76ac0ca17bab@suse.com> Date: Tue, 14 Feb 2023 17:11:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: [PATCH v4 2/4] x86/spec-ctrl: defer context-switch IBPB until guest entry Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> In-Reply-To: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6884:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d646964-26d3-445f-a041-08db0ea61462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tskmce7OGb43LH2g6WzEvYyOya1BIYP3xbYaiTLPk72ey6rs2j1yXUt0bcKOVtKSPNv8CYQJU1bQ0GFVTu5XXyZJf8SRH2yBiMNj86yI1tlFOvicEkgR1A2ZHTJ8EFgEpacGDab33LrxQmoDI0hjhgjeezlYRRP1k7oufuHDYmpyQ5zCyCklGn5CUSVWs2qFUAEWDeRxXe0TmRyKlESL7vxpVCpn0JOK+L5rsN3KNKzAJ601Nyfj2fuspOiU6YSU2uoGZhVgs1HmOUqtxjBmrNO859vXajhAZVjZeAJ8yOHkyMIwsNpuBSyxWUqk29ihuVO1iN+Q+BwvgbjCXZFP6Sa0d5ZTvg/tLzkb1uy66tHFxyCp6EdDVWdM112UtVuz7rqRILErt7dnaXjhdOn2M9zOGTBd7nv/xvO/U39Ag+04jW+oF2VEg+hsWTOFY/uwP5gHW1010FkEJmsa2hW1IYm9xIuO6Poo5qrUHh1Fz12PXfMI+Lx2i8oQjnwh0OgdWBFL7rAZr3vWKWy/x0oLtD033+8FBbrAJL15ugXfeIiF+wfzXkgS1ny3gLPFIE5mUHBhgMTkTSEFdwrer47mFgp3CbOXFDWuV+NK/2J6dyAq32VpSCAdTmNh4vpKzSHobQbd3XYG5lssxYfDRNt3WC7KgCl/VARjl9w0oVqGYvGWV+EomQ0aG8Lt35TzNehyCuUWjd4H2YIaOwbZq9UFJLwEChBBHFaC0hMgegIGulw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(39860400002)(396003)(346002)(136003)(451199018)(66476007)(66556008)(66946007)(6916009)(83380400001)(4326008)(31686004)(8676002)(41300700001)(316002)(8936002)(54906003)(36756003)(2906002)(5660300002)(26005)(31696002)(186003)(6486002)(478600001)(86362001)(6506007)(38100700002)(6512007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b25sVkF5ZDlOdmdhMUExaGNPNUZJdXhWYnFQaUZnbm5YNEoyU09pNmI2UzlE?= =?utf-8?B?ZGtuOHJVZWc5OGNxU2NLcS9CVHYxQ0tHblBNM1BMVUJRcmQrUSsxNFc5eGtu?= =?utf-8?B?WEZGWnBnRG43dmlMRmhWbXpqV2dIMUxrR1g1djV0dVEvTk5Vdk54TDJPaEVh?= =?utf-8?B?VFVUZEdJUU8wOEU2bWUwdHZMdDkrbTVjUSs5Zlkyak85a3FRbjd5cndEQWwx?= =?utf-8?B?SFNtV0hmSzg1M1h6emlxeWZkN2FPWTlCak0wT1BVWXJCYnZzUXhuaW4vVGkw?= =?utf-8?B?Zk1qNU9Ca2hRTEhpcDNSdC9qcnh5NzZ1MDc3Qmg2bkdDdGd3OThqazNBY3lx?= =?utf-8?B?WWg0N3MzaXd6VVB4VnFBVXBxYWhrTTZmQlBPeGROdnl2eXF2T2MrQUJUeTAv?= =?utf-8?B?aXdGTEYxWVM3aVFlMGtsWDFYalpaaFNob1lOYndmMlVkVkZ0Mld3VWcyK2Fw?= =?utf-8?B?RGIwUlhTYnA3c1FSWml6dGgvWENFMmNGUENrZFZXMWZyMnQzcEhhQ05NUVJj?= =?utf-8?B?OFJzSXFDMGI5MmIrY2RQR2haSFBXR1pCK3k0U2o4ek1JZmRSYzZQQ0JVV2Rx?= =?utf-8?B?SCtPbkt1YnJQa3JCaTNPWWpEM0VXNFJFRzVmL1pma0FHeWp1S3l0Y0sybFhR?= =?utf-8?B?YzRheXdEVUFFbDN4RXp0RWhXaGFxRklBRC9QTXRxYnVpZWNDd2NQdFFEaFpB?= =?utf-8?B?YzRwYWIyTFpBMm9EeHlUbEdrOHpjaDBKN2lVTHRjd3RJUGNZWEE0NFJINldw?= =?utf-8?B?akhkeGYyajA1SXdiRXlaSzZSWDlrbTJueFlzQUgwUG9helJFVmtuKzZIOG52?= =?utf-8?B?SzJJZW1sd0hMUDRjWXZCcDhzZjZhVDM1cWZRbVM1ZHhqMHpUSFFrOG1Ua0hO?= =?utf-8?B?a2QxNm5ISkd5SUtsYUJqWkRucEwxaStraWo3T3gydGdndndFRzdvMUNYaTNG?= =?utf-8?B?MWFVaUNuVFE1aHBpWnU0TmVtaC9QSk9Ga0FVSmtDVExjVk9TNnUvSkdLRlov?= =?utf-8?B?MjRtKys5ZHZYWnhaNUV5enNBS2xxL2hFMXNDRWs3WXV3L2d0c0pBb2VoSHF0?= =?utf-8?B?SUhVcVhaZncxNWVrS0lnakZFUjJPUzFpY2pmN1pCL0lDZmNOR0hVRTNYOUxX?= =?utf-8?B?elZGTjQzc0FBc251alYzRDlnUksveUJCMjFlNTJRWXNTb25kN2VwSFhnWE1r?= =?utf-8?B?dmpQcnJKUlB4c3E2R1JvWmNsczVtRWwrcFIraENOekFkYUxjSm5XMzZqN0Qw?= =?utf-8?B?NjVkV2MzYlRTSzIwNDMvR1ZSWjNiSWpsQ3JCRGJQQlFQNzRTN3ZaNGEwSkpT?= =?utf-8?B?Z0pscTA5dlA4cjVtd0svL0phYittNG11ZjJRQ042RlV1dE1xam1GVk1FRk9D?= =?utf-8?B?M1krM01xRHZMYWhqNFBPazJNR1Vzc3YwU1ZNTWw1UktRbjI5T1gvaE9yQ2Zx?= =?utf-8?B?ZlNqQWJYWmNwNFhhcGM0Q3RqZ1hpdEpJaHgzNUIvdHJ2NTVVbk9PZTNyRjAz?= =?utf-8?B?N3Iwc25WRS9FNHVWRXRoSE11Wnp2eGtYeGthUHBqalUyYWFjcm4wT2M2eWtX?= =?utf-8?B?UDlNaXVINWJnSFIxUStzNzFrTVNkM0VrSjB1WGFVdEVvYlJuTHZnb2hHOFU1?= =?utf-8?B?R1l4MmhVZkcxbDJkdmxGaGE0azdTdTBQSnprQUZNZTVxMC9MblpuVmlFWjZv?= =?utf-8?B?UnR0YmtUbXEwVXgwcVFFTXBFZjI1ekdzb1kvTEREZ0JDRzlxOEFyL0tWQmxt?= =?utf-8?B?Y2MvanY5QzFaRUFxdWxrRmpBVGRLZXdwNDNxZGVCSCtQelNhL2hWSVN0WHlO?= =?utf-8?B?b21vT0V6Ny9qWFZDbjlzNlpGQUxReVRCT3o3QjVVbG50cGVNbVlFMlNGdDh3?= =?utf-8?B?dTgrVWtDUVIrUEp4REVvOHhNbmwyNzRjSnUwVEpIZG1EdnczSWFWdFlXeVJn?= =?utf-8?B?QjBrckw4Q0drcmF1QWQwUWsyVlBSQTVtS3JBL2JGbXBZbVhtWG9XSTdEcVUz?= =?utf-8?B?aldvVVFxOThMYlhGV0pjcFlJZDNqS1ROaFBlZ1cwRHRSdXlLZUdpOFcrdGgy?= =?utf-8?B?eGo5NzQzZXRxZnhTL2VYUWJRcE4zcTJmVkdXQ2NQM3lzcG1sR0wzZktoSFFk?= =?utf-8?Q?W4uUW5EVMIB1wWlE8jp1aSQ6G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d646964-26d3-445f-a041-08db0ea61462 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:11:07.3987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bVEwUtcvQJBdxzOzEFyBX9jSj1PP7UJMXhJxLjaPxUEEG3WcdQ2eleMwQKzAwuqbeIqrTiAVmW5qOyeXGCc/LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6884 In order to avoid clobbering Xen's own predictions, defer the barrier as much as possible. Merely mark the CPU as needing a barrier issued the next time we're exiting to guest context. Suggested-by: Andrew Cooper Signed-off-by: Jan Beulich --- I couldn't find any sensible (central/unique) place where to move the comment which is being deleted alongside spec_ctrl_new_guest_context(). (If this patch is to survive in the first place, it was suggested to move to spect_ctrl_asm.h, next to the #define of the controlling bit.) --- v4: Re-base in particular over changes earlier in the series. v3: New. --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2038,7 +2038,7 @@ void context_switch(struct vcpu *prev, s */ if ( *last_id != next_id ) { - spec_ctrl_new_guest_context(); + info->spec_ctrl_flags |= SCF_new_pred_ctxt; *last_id = next_id; } } --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -67,28 +67,6 @@ void init_speculation_mitigations(void); void spec_ctrl_init_domain(struct domain *d); -/* - * Switch to a new guest prediction context. - * - * This flushes all indirect branch predictors (BTB, RSB/RAS), so guest code - * which has previously run on this CPU can't attack subsequent guest code. - * - * As this flushes the RSB/RAS, it destroys the predictions of the calling - * context. For best performace, arrange for this to be used when we're going - * to jump out of the current context, e.g. with reset_stack_and_jump(). - * - * For hardware which mis-implements IBPB, fix up by flushing the RSB/RAS - * manually. - */ -static always_inline void spec_ctrl_new_guest_context(void) -{ - wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); - - /* (ab)use alternative_input() to specify clobbers. */ - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, - : "rax", "rcx"); -} - extern int8_t opt_ibpb_ctxt_switch; extern bool opt_ssbd; extern int8_t opt_eager_fpu; --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -854,6 +854,11 @@ static void __init ibpb_calculations(voi */ if ( opt_ibpb_ctxt_switch == -1 ) opt_ibpb_ctxt_switch = !(opt_ibpb_entry_hvm && opt_ibpb_entry_pv); + if ( opt_ibpb_ctxt_switch ) + { + setup_force_cpu_cap(X86_FEATURE_NEW_PRED_CTXT_PV); + setup_force_cpu_cap(X86_FEATURE_NEW_PRED_CTXT_HVM); + } } /* Calculate whether this CPU is vulnerable to L1TF. */ From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:11:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:11:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495279.765604 (Exim 4.92) (envelope-from ) id 1pRxuD-0003Y5-G2; Tue, 14 Feb 2023 16:11:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495279.765604; Tue, 14 Feb 2023 16:11:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxuD-0003Xk-Bz; Tue, 14 Feb 2023 16:11:45 +0000 Received: by outflank-mailman (input) for mailman id 495279; Tue, 14 Feb 2023 16:11:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxuC-0002M8-0A for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:11:44 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20621.outbound.protection.outlook.com [2a01:111:f400:fe13::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45a4d807-ac82-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:11:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6884.eurprd04.prod.outlook.com (2603:10a6:208:183::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:11:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:11:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45a4d807-ac82-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT8SwaaxGaqOdIlo6G/KwBNB0XjHtaMZzaQ7Y8YSFx8+2OIGnW20U4hPu2lYEs2aNrQf+QsXu79BcYBDZiKs0wVJ5HtLRvk+uX6CNZcALA/OwXBRg07zybGO0r+dnrWhXaPvTeznw893ZrXyDTE5Lb2sam2qgQVnLXAPAl1THgtwLyBaG+ibjiYJAartW8tNSCf+h5R1TJ1unVdx0u5jLNIlwRtiBnX1D9jn8aqtEZsZRH3BuO+UREgP/TQJF4HwVpVeR4xfXWgVr5uqFSzTjvOueemsy610vhp3Pzwze6OQWz1XdKRzd3H1tvLbbMrxkF4DwZJt7tnpoieyRW1LwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VsxokRwRk6IFeqdM2G8OVgIpJfgzhXYhcx1m6t7JxXU=; b=hRv+o2iB3ts4eeUUw7Eujg5jTu3qRqL/O2p7jQPPLlFul8LTiQKXFyuBaG+tQlHbjEP3AK/rPoVhAnMbPhI+NQOOUZEAKyhb9PRu7RcR61dcFf0y/fooWqqcvDO18ttuGHUPq50z33xgxqq5kurCm2/8hC7Lkly9MI+hxFVUCbFzVYj1UrWvAv06j/SbZ40tm7b9WkGQzocFm0KkncMZ5wKjQoVg+71b7hRi8QZBfa1T3TZf03g0aZP3NppXEuQltDqPNz4XgfyA2kn/DUhRsge6XibOAKrYABJ1fnbTrYguCWHe3FlesOISNmJKpvWPmzW3XdPZYyBtP+ow6KalRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VsxokRwRk6IFeqdM2G8OVgIpJfgzhXYhcx1m6t7JxXU=; b=U7XvhegJ8GMO1QT2UKrJfS6i+eB4NSGwMoO1BHUvguONKcFeHs5Ic6KoNjfUsuRMKE7bBXd14KAY9t4hegeo293e1kXWcd4fM1z0s76I011xLKh9xSYtwHLmfHCKnfvp1TX5vmph7ERjJU/KrmTUAo3GCirbF7dKIh3+c0fVLpCymY+Xbb2hyF6XDZQpYz3uLgfIgnL4zGxXnGehrcuhVBl4jtNGczkwBBGeh/rohmSTwBnGeCBxU4qMrfRPZ50juVSMJ+h0zO528STOXQ23+LDtxsedJa5DKb/p5ufmp+paDBESCyIyPcjWXky4EP6ZzhuQmJaQfj/wYncdPocpew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29e2b527-16b8-e72d-f625-781aedf21bc4@suse.com> Date: Tue, 14 Feb 2023 17:11:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: [PATCH v4 3/4] x86: limit issuing of IBPB during context switch Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> In-Reply-To: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6884:EE_ X-MS-Office365-Filtering-Correlation-Id: 441e74e2-b448-4ad6-f2ec-08db0ea62913 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VqAyzyPwo07sJJyQli/aw7moJ+ZLsPQLdQDyk2II2UTRLq2wWLjs9Opf0No9cV+zhn+ftsKi7Tk+0BcqcD2HzlJbhdzMKYjqxfU59//ukDn77VLChp9o3qVErKd2fZ9W9RZe27UHo0g9NWB0lm2BYDAHnrA5iyuCp0eqB4gpE4Sy2bn0Z4O25gEi6oRbbnyuRP3eioy8gsXVbeBuh9yghg3ZyoRmcTZQhfmovuLjvWT53RogQHaaH1nlCHwGwEQmU0Cge7V2zCj0DpsyjaPcCFuWhOHWQo/22KFkngSmcRGoYEG6O6aAF8EmubcyKHDXCyE4yeGYvaWx+2bry+1chNzxY9MMuMNoRmdBTmV3TH9VvH92FWrW9VKB75spZj6yqamGZ5afO78hfa0TNpfaldY46wS+JSkbVE242Vt7M2qaxTXhDUTGpqlcWCSI0hGTOsO1SN8uUVsRNmRPdZ7HMHq151JMHlRPF3BBGDArUlIRBIAaVRlIEaNT3VERooHYSdEzSir15qNqsoSuMZw+F4Dwogs9qL6t469M4h4d8KAkqGEm69e52GGUXRVdgcH8SHBESyKcTzguaTyM+9MyiYOE3vcrUS5dcip9+HOoRjCNixjRp6LdvG/JZJSgq+P5GtuaKkQhMKxIrWz3mqdVEbatcoM/WCnUR4qXMdK1CG/wj+p0q7lWLNhoAuFyX/7zlSQxwYaGR73m2atO1ccT8kTXS1LbpMa6bmpQf0VhFH0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(39860400002)(396003)(346002)(136003)(451199018)(66476007)(66556008)(66946007)(6916009)(83380400001)(4326008)(31686004)(8676002)(41300700001)(316002)(8936002)(54906003)(36756003)(2906002)(5660300002)(26005)(31696002)(186003)(6486002)(478600001)(86362001)(6506007)(38100700002)(6512007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUsxQnFPRjMwL0lSdjUrQnl2SnR1Ym92djhPMmpVVWdNOEJVZVBzdFd0N3lQ?= =?utf-8?B?QS8vb3ZJd1ovK1RqNlZMSENobXJxN0U5ai9uNjZ2ejRUVUwwRmY1UUhJSm0w?= =?utf-8?B?c0lKeC9YaDAwWGo4WmU5dDY0Q0FtVGIzNDA0TTZlT0hxY1NVLzlvZ2hFK2tU?= =?utf-8?B?cFVXM2tnMGpIZkcvR3A1K3NDcGlyTGYxbjFhM1djam5TYkhQKzU2QWREZ29F?= =?utf-8?B?RSsyYWJaZlVtRld2RnlNUFBzZGZDSDNpK1hnSnpEdU1pZWtwODdQZTVmeEds?= =?utf-8?B?QmRpUTRHWVVtU0FzTzF0cG1vTW8wWEhySnZIaG5sWmhvd3ZTY0ErTWlLWGky?= =?utf-8?B?NTlKeWFEeGQ4Qkt1L2ViYUVaRUY3NVRDVWRHSVIvNllGZWt5TU5STW5pQ1dx?= =?utf-8?B?MEpPRWt1NVRUYnpZdm5tVThIMStHaWRwRWFjQXd5S3B2RUxJTFFXVUgybllD?= =?utf-8?B?VzhqTjY2Z21TWXcwczdkbjl6d0hsMXRNU0MzQmNlZk5GcXBrdnFPbUJZMHVY?= =?utf-8?B?RVd6Q1hxeGpBMjdzbHQ3bU9oZ1ZLbkF3SVNVSDBVNk5TTUVtcVVQRTBadno1?= =?utf-8?B?T0dSNGk0dDRBRVY4d3VhVXphZEg1YnprWnpMMkhFemdoVU8zOXdOZnlMbGVX?= =?utf-8?B?SWx6V01uSDM1Z3FDU3hLNHdmY1llVCtjTTM4endXUkpaaW9ja1NjMjBBMW1M?= =?utf-8?B?T25WQ1ZFRGczYUg5NjRRdFpVRXlpUHcxR2x1cTdXbDM1SVhvTlVmRUlMQUNL?= =?utf-8?B?Wk5qMlVuQXhqYzFCbXJPaDNvSHE1c2prNCt0VDgvWEkzNDFXb3JRUUZLNjEv?= =?utf-8?B?RHZGK0VuV0I5NTBKQ01URzhkbmpQMmd5Nm1BblpiQkVnSEVOZmhJRENpM0RI?= =?utf-8?B?K21HU2RzRmtUQmtTTDh1UW5raWg1YTYzaFFxeWpQeEJnT2pKM0tmMEhJOEUr?= =?utf-8?B?eXVZUVdsc3ZFRDViQmRTZ3o2T2svSkZtcUhNOGR2QjhzaVRVQUpzNkNRYkhW?= =?utf-8?B?QkY1SVhwVURxSzBoMWJSYkZ4MXBzSEVEZXZ4cW1RNHZmOTlJclJYVjg5T3d0?= =?utf-8?B?UzBXWnZPVjlHbmhkazd4c1R0SU9QVjlGcWlUbkc5NTIwRWZZd241ZjhkUHpv?= =?utf-8?B?c01ua21sRTU1clZwa0FMcFZzc2RMdEdSMXJocU1YUnVpbXJHN0IyNzlQeTJE?= =?utf-8?B?WTNRYk9GYmZ6WWptTURlYlZzNDc4bTJnbDRuZFNOVU1LdjMzaGovbGtyTWl0?= =?utf-8?B?Zm1Wd3lQK3o5VmliSDNERmZCMzlqQ0lTWmFGc2xzTDREK1NMRm4xRjRzYVVF?= =?utf-8?B?MWZWQWEyek5FclRBVUJyS2hMKzRISnlVa1JxK2dkOVk3NGVnYXd3RWtURUIx?= =?utf-8?B?TDNlNzlSQmJEYWNucW1aaWltV2R0amtITEtRRitvSTNiOFlQUEVZYmJTV1FV?= =?utf-8?B?Y05jU3NHWjZ3cVVjVWFuQjF5S21qWTA1bVdmeU9xSWM0eVJnb0dxU1ZZbmJU?= =?utf-8?B?Q2pNNU9iWXJSRngvSk8zaXM4L1lpRFV5YTVGVFV2aGxwM09Zdk82dUdsV1dt?= =?utf-8?B?RnY1N0hOc1FBeUcrUkoyVmJmM2Z6SlVzNTMyaUFKUGFVc1BBVnJUQnR3Ty90?= =?utf-8?B?dXJtS09ocXI1U2VFUjJMNVF4djM4S2FOdFF1V2s4MzloajlnS3RyOFN5Smc1?= =?utf-8?B?VzY3NUxXQjA0cDNoVW1QMlhBTmF5cFVoRWhINDJaRlk1ZDBKZkxuZC95RGxB?= =?utf-8?B?UzJtS3NDRUJXSW1VNmJRVWVZUEdCclcvK2pZMDk4QjVZa3JxcEpXaWg2Qkla?= =?utf-8?B?NmlOZll2LytQaVk1N2IyS3N4QkFYbFNxTWtZblVPSHB4L3lJc2VJdzZGNjE1?= =?utf-8?B?eUVPUTVZeGJ4dFhpakJTZWM3QXBDU21ZYkJCeXg3SmFWMGhYbWZMZEk5WWhI?= =?utf-8?B?eEZsR3pJbFlxR3JGY1VOanlUMnZLbnNZVFV2TzNUblZjL1YydGNoMzVqYWVi?= =?utf-8?B?enZkdThMQWQybG4yNVRxd0RpZlEvZnBzSUR6QldCalAvVWxMa2lOcy8zMERX?= =?utf-8?B?UVZLcGplWkFzMTIyTzhxclJ1akFaeHlPTzJJMC9BYTJqWmZ3MFpIR2RvdWxw?= =?utf-8?Q?3Nr04aSiZVmOa0FFlXn8p/7P/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 441e74e2-b448-4ad6-f2ec-08db0ea62913 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:11:42.1465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Alwjud9TwSgKoWatYLAs8MvH7BA1JUpP2babXVA/uSwGYMzvwgRUKF0Nr2dRxt7ZgBPlyW6vseW8J4KT1dI8Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6884 When the outgoing vCPU had IBPB issued and RSB overwritten upon entering Xen, then there's no need for a 2nd barrier during context switch. Note that SCF_entry_ibpb is always clear for the idle domain, so no explicit idle domain check is needed to augment the feature check (which is simply inapplicable to "idle"). Signed-off-by: Jan Beulich --- v4: Tighten the condition. v3: Fold into series. --- I think in principle we could limit the impact from finding the idle domain as "prevd", by having __context_switch() tell us what kind domain's vCPU was switched out (it could still be "idle", but in fewer cases). --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2005,17 +2005,26 @@ void context_switch(struct vcpu *prev, s } else { + unsigned int feat_sc_rsb = X86_FEATURE_SC_RSB_HVM; + __context_switch(); /* Re-enable interrupts before restoring state which may fault. */ local_irq_enable(); if ( is_pv_domain(nextd) ) + { load_segments(next); + feat_sc_rsb = X86_FEATURE_SC_RSB_PV; + } + ctxt_switch_levelling(next); - if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) ) + if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) && + (!(prevd->arch.spec_ctrl_flags & SCF_entry_ibpb) || + /* is_idle_domain(prevd) || */ + !boot_cpu_has(feat_sc_rsb)) ) { static DEFINE_PER_CPU(unsigned int, last); unsigned int *last_id = &this_cpu(last); From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:12:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495283.765615 (Exim 4.92) (envelope-from ) id 1pRxui-000489-PB; Tue, 14 Feb 2023 16:12:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495283.765615; Tue, 14 Feb 2023 16:12:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxui-000482-MJ; Tue, 14 Feb 2023 16:12:16 +0000 Received: by outflank-mailman (input) for mailman id 495283; Tue, 14 Feb 2023 16:12:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxuh-00047a-HJ for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:12:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7e1a::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57902e97-ac82-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:12:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6802.eurprd04.prod.outlook.com (2603:10a6:208:184::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:12:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:12:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57902e97-ac82-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbTV6KCWba1/xkE5SwMveZsXpKFdRmIfWVV5fihN92SKaucp6GS6eYC9Vse5qdutipfoDrj6JIWDUISxBV5P0o4lYmVQDtKiLTWK3PKfSSUbipe0iBPjyYRaben3/E8j5vAgknuB8nSDTyo2wy+PWheL9Oyqg6bmmhzu+Ir/mr79Pr7wkAEYdG52LelEfXOUoqca0hl91CeYQbgb1pXA0D36f/D0qXZCUT6R1HEx9LMYNiu5gYsTdoRM4oCMUib1jifT6AqCOxUTfPh2zbH+eGMUIzpc4jXk75byHpKf2SRsxB3s5+jk4zJfic6z4NHtFNB7N/aU1wtfBjaLG9XIpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ft+1MjxIGwj0woDLn2mSZmpetZATFnBGj51IVbzpCU8=; b=UEDQU7Rs29oAvn44b3icyDQ8RW/CV91enmVshkZYyncqsbaYGn3fc5WmVwhUCe2dm0b1bsRml/iCvTlpU1BxXL+ZYRAH2Z1V7nkHRPDS41MtbjMxwWHwJpt3fib4SjTs9RLEvn8fKNqZV9pSpc5sUWwIluxcFNcriCZ6M0YnhpCGYC2Iek0N1lDIiFwbQB0F6bswZaiujFSVxblc9vuj/DsGtfKhU8jWaLn8nYKMwV0ztho1NxOhSwPCfE9R52wvYVI6u+7m1wJTC6d251K8NAQRiS4kowCd2YAulpt9XMydpSRJJsFO3a1iAol/0vw6pLFx7VeFIZbzzksOxnZmhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ft+1MjxIGwj0woDLn2mSZmpetZATFnBGj51IVbzpCU8=; b=4gv63e1zH66qsFB7yleVVihSsrFA98MDy78+MK6wfS6V7JTM0cdWFGlWYYSPz0JCitec8AmeQnQBSfczYr3cpKG4hbk1A8sV0PkhNogJ2WuQ0mT89LH1f3eRzNWZZ7XDKgCY0+GTmL157cvbDeVn61rlX3pDKd2tRoFnE+zfyyGVQH+dp5XbS0q88I9KOr77f1hVLBaJsS43Ep0huilEXYa+AVkFxxBbj0yl6stskU7irUQ8D/I2xkQow26FnAL6KVnF7WXqHbtFxawsYgRH4rETNPpFebMFA8dNNwwSwmoq0Lz70H5ldgHVJQJ6QaemBzJafwTQL+rEJWnOJfNgvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2863b0a9-ca7c-3cce-104d-0b6685b0b383@suse.com> Date: Tue, 14 Feb 2023 17:12:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: [PATCH v4 4/4] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> In-Reply-To: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6802:EE_ X-MS-Office365-Filtering-Correlation-Id: 2176c0ae-0c2e-4a3d-d35b-08db0ea639d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tbGKjhmnIqOu372RLOhYa9HjsThRc1WYJAhwKWMSuevo5L8cRYpG7GjHwRP4Jqjffz1YNfGuqaiRFgg0WhblYzYNroOp4VH3464C8hz9UanJoYrSXX2DRnJp4By5bUVtvog3Y8OGZCSGpcU6OV2x1I2B1Z4VAIXwVKKJq18LrcAaC63LYd8XWY8cPVBqz42uIczxaB0zJizPepOArrH3uG3x8QDFHv6vsx3cgmWzjk0IJ8cDWX9iMz6ejHIWixwGCtmlcOETaQFnHs8+caQSKzh6gyNj3r78HmckuvQ4vaV11zvuLl/YDhWgq4DadJDEO2aHeI2YMOPOe0BAK69y15AZw3OEl/ABAs8wIwH4iLh3G0Wj1jTlh7NQxRvMEqS6Tt/GPgdw7yflrqaWZno6sJtFDPE2ogtY7BNItcjxL41kWd7n9VCtlm1OaDuFMJPq4gC+aRei+1T5tjw0o5CsI1ktBPfwFZ0t+fud5F/dh3A+Te9UPrzhp+n//6ejI5Zhs5Ohtgud9WLW7jdBYZxTklnM8g7P/6l08wwTuw0sugUXX0eV9jWyVDeoknXuR60zW0u5zt7/KLJseggX5KO3XaWT5yStRka8SbqmAwPH6sqtk5l2xxWA+oK8d3X+B12vhCYD8E6G2H9tnR+6efInLFTNdAJJgE2Y3ptcox7OviAwyOlKJfpW+wMAoASDW0RG9JldEXpLFeAqRPvQ7wqBXYbfHuKVdBj4RP+2N1fbhqQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199018)(31686004)(6486002)(316002)(54906003)(83380400001)(4326008)(478600001)(8676002)(66556008)(2616005)(6916009)(66476007)(66946007)(41300700001)(8936002)(5660300002)(2906002)(38100700002)(6506007)(6512007)(26005)(186003)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0RJN2VKTVpEYmd2d0l4a3VNSk1GU2JFR3plV2E3Y3Ivd3QrNk9yUWhha213?= =?utf-8?B?UEtHakRKaDlwa2hJSjExblN0OXdVdytRSzh6Y2FWL051b3VsVWp1Z1RlcDR5?= =?utf-8?B?TExUUVUwRUpyZVFsYlJCa0RXNmI4bnY2UGIrc0VMbGRRR2Nsd3BJaHY3d1Bl?= =?utf-8?B?VFgyOVFIYUJiQ0UzV2F5RlFYaUFuNWVyMnNsZ0VJVHR1KzlGdXU1R3ppWnND?= =?utf-8?B?OEVMdVdpRjV4Znk5VGhhd09aMm1hMmlmR1BIM2RvU0FYR0ZCZmg4V3FHWitH?= =?utf-8?B?Rm5IWEl1blFnbU4xaEVZUGc3QzdqNlJsM29ZL2U1N2txdEhLSkN0S2RTejIv?= =?utf-8?B?eGFBckN4TWM1aFBoc2FsdUFOSEozVzdTUWRyR0t0V2owQXhjQ1dTMVpUbTEr?= =?utf-8?B?dm1yb0hjOGtITWpmS3ExQ0paYkpZblpJZVFxRmpzd1dGYVRDajhmMnowUlhG?= =?utf-8?B?YVpSMzBnam51czJzRHozOWprN3Q1K3gvVTVTZHZHenpFVnM4cVI4Y1NyWTh3?= =?utf-8?B?QUxkWEpvak12ZTViRVZva2N6dnV3TTI4b3RvUHdSWDZRY2RxektJajlReVJP?= =?utf-8?B?ZkF0dkxSM1dEU0RCUnJyQnZnYlI1dEN1U092YUhmbGNaU3pQMEZNMUdwMWdK?= =?utf-8?B?OFI5UUo1U01ORHA4RWpSTXZKT1VNQnZjYXcvRkpMck9kYzZYelN1MWhZYzll?= =?utf-8?B?MnZ5UnN1NzMrYXJ1UEFBVTVYdXkwdUlXbWdSZzJBbkdLRHF0STVDRHpqK2pD?= =?utf-8?B?ZGpiY0pWM2ZjS0pLN2FmZG4xTzJrMXVMbzAySG1mTUFqaTViRlZTTFRqLzdQ?= =?utf-8?B?eDh0NVc4Tk5VeHFaVVRkQktYRXVNd1h5RSsyTCs3VTg2NEh5ZFZsbFAzbjkz?= =?utf-8?B?bzRvUXZqUnptQmNua2VEY0k2bmFXbzNzSUhnVVhZTW9hOXRqeHFQaDhrdE9j?= =?utf-8?B?c0hsdG5FeGNnZmZpUTZ4Y0VQQldWS1hQc3Q1NUs2SEQyUTVuMXlnZUlyWGpt?= =?utf-8?B?aEphOUs1L3NMSm9QY1orNDlidDRrYk5EdEs5YlIrcTkzMFJWdUdFZW13Y2FT?= =?utf-8?B?Rm9LVklUMmJlOTZLSG1zVHBYS2lJV0tyNDlXbTlyR0UveXBwaUNTbHZMZXRu?= =?utf-8?B?b0JPNkNEanpGWVcvaW1LSCsxbkxNWGVhMjAyYTRvdUMrclpwNDlUcDlKNUF6?= =?utf-8?B?cVB0S0FoMzdWWEs5Q3RhMGNLalNOaVV1eVpic3hOUS9obWVxNStBeklxUVV1?= =?utf-8?B?S09kMTFQVDYxZTFsUy9XNDVYdncxa3l2UUczSzB2R0hoTVNMUGpKYzVHYmli?= =?utf-8?B?aUxESDFBTHZsTWhoSEs0aDhHM3VHRitkZHg1OTBVcjRTdFFmL1lyOEpiMVdq?= =?utf-8?B?R3FqMXJpUE9MdnZsMlh4WGRuM3d0eUE3eHR1aDhoM2hxbFRpcEViNGRLeVFF?= =?utf-8?B?VHFxU2JIWEtnQ2lycjFuZ3lMYWo3WmVFb1liQlZTMzZNQUdrYUt3ZGZPcTdG?= =?utf-8?B?Sko4eXIraUt2ZmxONGdBNWhlcnlPQ3J0U2h6Wkhqck5rTjEzOWVMZlRmNGpN?= =?utf-8?B?ZFVJeG9XY0RIZkdQRWsrckdLRFRCT2hzbUp0SUN5U0pSalVwMkM3WmhrWHFx?= =?utf-8?B?cDJlcXU1MTd4VWxYUjg1Vit1SlNJUHl1OEUzQ2pYb3YzM3VoQU93NWNKZkRw?= =?utf-8?B?YWF3UUFWYXg4TjJZOWd2aHNQSjVyVm0zeGtSUnNyOFZUVnd1TlA2YTR5c1R1?= =?utf-8?B?R0FHMGxLcHFrZ0JuRzQrWlI2Y1NBT21mWnZRaVF2K3I2LzNFMUxobFYxSGZM?= =?utf-8?B?a0t3NmJBMzhyWUN1WTNsT1NmcEZLaFZCUisyYUR1S1F0UzRySUVoYTFPOHJC?= =?utf-8?B?NlJ1dDlpM0JaeTFNdnVsWGw5VG81S0IxQkJVb29XQkx5OEhDNFFYdkJ4WTlL?= =?utf-8?B?dzJLNVp2UytNNUhXL1R1ZWR2YmVpaStERkpMTjJ1Q0g0YW4zZWFMS3RrS29v?= =?utf-8?B?emVNckpjZE1JaCs5cUliN3Vyejl2bXFVYVhGYmFjR3VNMVVKTzljSElpMGc0?= =?utf-8?B?MnV3UUNCUXI3NUNKNC9vYTZsaE9nUUhWb0szVS85eU5uQTljVGVqQmtpT1No?= =?utf-8?Q?KzTdw4EfVSeNh6D5MdzJ3TyBx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2176c0ae-0c2e-4a3d-d35b-08db0ea639d4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:12:10.2072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oQaQ8gsgz5RRf3j7I2XFAY7RACKAwUPovBIQWh+TpPEJ1JJPdr0pjek1lvNXogV4o2y8YXT+G9KRaBHcKuchkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6802 Since both kernel and user mode run in ring 3, they run in the same "predictor mode". While the kernel could take care of this itself, doing so would be yet another item distinguishing PV from native. Additionally we're in a much better position to issue the barrier command, and we can save a #GP (for privileged instruction emulation) this way. To allow to recover performance, introduce a new VM assist allowing the guest kernel to suppress this barrier. Make availability of the assist dependent upon the command line control, such that kernels have a way to know whether their request actually took any effect. Note that because of its use in PV64_VM_ASSIST_MASK, the declaration of opt_ibpb_mode_switch can't live in asm/spec_ctrl.h. Signed-off-by: Jan Beulich --- Is the placement of the clearing of opt_ibpb_ctxt_switch correct in parse_spec_ctrl()? Shouldn't it live ahead of the "disable_common" label, as being about guest protection, not Xen's? Adding setting of the variable to the "pv" sub-case in parse_spec_ctrl() didn't seem quite right to me, considering that we default it to the opposite of opt_ibpb_entry_pv. --- v4: Correct the print_details() change. Re-base in particular over changes earlier in the series. v3: Leverage exit-IBPB. Introduce separate command line control. v2: Leverage entry-IBPB. Add VM assist. Re-base. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2320,8 +2320,8 @@ By default SSBD will be mitigated at run ### spec-ctrl (x86) > `= List of [ , xen=, {pv,hvm}=, > {msr-sc,rsb,md-clear,ibpb-entry}=|{pv,hvm}=, -> bti-thunk=retpoline|lfence|jmp, {ibrs,ibpb,ssbd,psfd, -> eager-fpu,l1d-flush,branch-harden,srb-lock, +> bti-thunk=retpoline|lfence|jmp, {ibrs,ibpb,ibpb-mode-switch, +> ssbd,psfd,eager-fpu,l1d-flush,branch-harden,srb-lock, > unpriv-mmio}= ]` Controls for speculative execution sidechannel mitigations. By default, Xen @@ -2403,7 +2403,10 @@ default. On hardware supporting IBPB (Indirect Branch Prediction Barrier), the `ibpb=` option can be used to force (the default) or prevent Xen from issuing branch -prediction barriers on vcpu context switches. +prediction barriers on vcpu context switches. On such hardware the +`ibpb-mode-switch` option can be used to control whether, by default, Xen +would issue branch prediction barriers when 64-bit PV guests switch from +user to kernel mode. If enabled, guest kernels can op out of this behavior. On all hardware, the `eager-fpu=` option can be used to force or prevent Xen from using fully eager FPU context switches. This is currently implemented as --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -742,6 +742,8 @@ static inline void pv_inject_sw_interrup pv_inject_event(&event); } +extern int8_t opt_ibpb_mode_switch; + #define PV32_VM_ASSIST_MASK ((1UL << VMASST_TYPE_4gb_segments) | \ (1UL << VMASST_TYPE_4gb_segments_notify) | \ (1UL << VMASST_TYPE_writable_pagetables) | \ @@ -753,7 +755,9 @@ static inline void pv_inject_sw_interrup * but we can't make such requests fail all of the sudden. */ #define PV64_VM_ASSIST_MASK (PV32_VM_ASSIST_MASK | \ - (1UL << VMASST_TYPE_m2p_strict)) + (1UL << VMASST_TYPE_m2p_strict) | \ + ((opt_ibpb_mode_switch + 0UL) << \ + VMASST_TYPE_mode_switch_no_ibpb)) #define HVM_VM_ASSIST_MASK (1UL << VMASST_TYPE_runstate_update_flag) #define arch_vm_assist_valid_mask(d) \ --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -455,6 +455,7 @@ static void _toggle_guest_pt(struct vcpu void toggle_guest_mode(struct vcpu *v) { const struct domain *d = v->domain; + struct cpu_info *cpu_info = get_cpu_info(); unsigned long gs_base; ASSERT(!is_pv_32bit_vcpu(v)); @@ -467,15 +468,21 @@ void toggle_guest_mode(struct vcpu *v) if ( v->arch.flags & TF_kernel_mode ) v->arch.pv.gs_base_kernel = gs_base; else + { v->arch.pv.gs_base_user = gs_base; + + if ( opt_ibpb_mode_switch && + !(d->arch.spec_ctrl_flags & SCF_entry_ibpb) && + !VM_ASSIST(d, mode_switch_no_ibpb) ) + cpu_info->spec_ctrl_flags |= SCF_new_pred_ctxt; + } + asm volatile ( "swapgs" ); _toggle_guest_pt(v); if ( d->arch.pv.xpti ) { - struct cpu_info *cpu_info = get_cpu_info(); - cpu_info->root_pgt_changed = true; cpu_info->pv_cr3 = __pa(this_cpu(root_pgt)) | (d->arch.pv.pcid ? get_pcid_bits(v, true) : 0); --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -60,6 +60,7 @@ bool __ro_after_init opt_ssbd; int8_t __initdata opt_psfd = -1; int8_t __ro_after_init opt_ibpb_ctxt_switch = -1; +int8_t __ro_after_init opt_ibpb_mode_switch = -1; int8_t __read_mostly opt_eager_fpu = -1; int8_t __read_mostly opt_l1d_flush = -1; static bool __initdata opt_branch_harden = true; @@ -111,6 +112,8 @@ static int __init cf_check parse_spec_ct if ( opt_pv_l1tf_domu < 0 ) opt_pv_l1tf_domu = 0; + opt_ibpb_mode_switch = 0; + if ( opt_tsx == -1 ) opt_tsx = -3; @@ -271,6 +274,8 @@ static int __init cf_check parse_spec_ct /* Misc settings. */ else if ( (val = parse_boolean("ibpb", s, ss)) >= 0 ) opt_ibpb_ctxt_switch = val; + else if ( (val = parse_boolean("ibpb-mode-switch", s, ss)) >= 0 ) + opt_ibpb_mode_switch = val; else if ( (val = parse_boolean("eager-fpu", s, ss)) >= 0 ) opt_eager_fpu = val; else if ( (val = parse_boolean("l1d-flush", s, ss)) >= 0 ) @@ -527,16 +532,18 @@ static void __init print_details(enum in #endif #ifdef CONFIG_PV - printk(" Support for PV VMs:%s%s%s%s%s%s\n", + printk(" Support for PV VMs:%s%s%s%s%s%s%s\n", (boot_cpu_has(X86_FEATURE_SC_MSR_PV) || boot_cpu_has(X86_FEATURE_SC_RSB_PV) || boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) || - opt_eager_fpu || opt_md_clear_pv) ? "" : " None", + opt_eager_fpu || opt_md_clear_pv || + opt_ibpb_mode_switch) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_PV) ? " MSR_SPEC_CTRL" : "", boot_cpu_has(X86_FEATURE_SC_RSB_PV) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", opt_md_clear_pv ? " MD_CLEAR" : "", - boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) ? " IBPB-entry" : ""); + boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) ? " IBPB-entry" : "", + opt_ibpb_mode_switch ? " IBPB-mode-switch" : ""); printk(" XPTI (64-bit PV only): Dom0 %s, DomU %s (with%s PCID)\n", opt_xpti_hwdom ? "enabled" : "disabled", @@ -804,7 +811,8 @@ static void __init ibpb_calculations(voi /* Check we have hardware IBPB support before using it... */ if ( !boot_cpu_has(X86_FEATURE_IBRSB) && !boot_cpu_has(X86_FEATURE_IBPB) ) { - opt_ibpb_entry_hvm = opt_ibpb_entry_pv = opt_ibpb_ctxt_switch = 0; + opt_ibpb_entry_hvm = opt_ibpb_entry_pv = 0; + opt_ibpb_mode_switch = opt_ibpb_ctxt_switch = 0; opt_ibpb_entry_dom0 = false; return; } @@ -859,6 +867,18 @@ static void __init ibpb_calculations(voi setup_force_cpu_cap(X86_FEATURE_NEW_PRED_CTXT_PV); setup_force_cpu_cap(X86_FEATURE_NEW_PRED_CTXT_HVM); } + +#ifdef CONFIG_PV + /* + * If we're using IBPB-on-entry to protect against PV guests, then + * there's no need to also issue IBPB on a guest user->kernel switch. + */ + if ( opt_ibpb_mode_switch == -1 ) + opt_ibpb_mode_switch = !opt_ibpb_entry_pv || + (!opt_ibpb_entry_dom0 && !opt_dom0_pvh); + if ( opt_ibpb_mode_switch ) + setup_force_cpu_cap(X86_FEATURE_NEW_PRED_CTXT_PV); +#endif } /* Calculate whether this CPU is vulnerable to L1TF. */ --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -554,6 +554,16 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); */ #define VMASST_TYPE_m2p_strict 32 +/* + * x86-64 guests: Suppress IBPB on guest-user to guest-kernel mode switch. + * + * By default (on affected and capable hardware) as a safety measure Xen, + * to cover for the fact that guest-kernel and guest-user modes are both + * running in ring 3 (and hence share prediction context), would issue a + * barrier for user->kernel mode switches of PV guests. + */ +#define VMASST_TYPE_mode_switch_no_ibpb 33 + #if __XEN_INTERFACE_VERSION__ < 0x00040600 #define MAX_VMASST_TYPE 3 #endif From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:13:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:13:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495292.765626 (Exim 4.92) (envelope-from ) id 1pRxw5-0004oL-5E; Tue, 14 Feb 2023 16:13:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495292.765626; Tue, 14 Feb 2023 16:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxw5-0004oE-1v; Tue, 14 Feb 2023 16:13:41 +0000 Received: by outflank-mailman (input) for mailman id 495292; Tue, 14 Feb 2023 16:13:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRxw4-0004nx-0J for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:13:40 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20622.outbound.protection.outlook.com [2a01:111:f400:fe12::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89d5379a-ac82-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:13:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6802.eurprd04.prod.outlook.com (2603:10a6:208:184::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:13:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:13:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89d5379a-ac82-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yktr3axx8Bo53bYH9AmnGi+1CSs9jE1AveqZoO1ztUCo4OdQcNvXoq/psQ71GkQhCFmP3dECvhjkNmA9RGIuZ4Hc1GIYrIwKCm3UZ9WCWkvqy7eTGEXiReSheJ8waR84T6rBTNX9QJEmOx0lgRLR1QiwmIJVHn85bReZDE1X9f7O0l3POK6iwr0oq9Hm8R/PJe5p2yaJPvLkmjFjIgtaT2lq4Kdi0ERayvSlPyDepocAVd/EjNEsQiUYVP7NWB7G0IIY4LFQ5Mc6QIFO0qLz9v47BoJ5BBcZ7ftFIelQKD6lt/U6SzCOzoudNWbQNfRKDvsfVX3y7jimCAEa/ogRPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VV1pzylMtiJbaf1DCMAdNM/POHYJ2+zwgryBLilgFJw=; b=di6OfBmhfou6ytaCxRPRqDG1ny8U88g8driL7OY2cY9NDjvINxJPMxIeYfMuO1e7jQNvnPCt1J7VvJFEplDErgxUSNJakbuqvC2PaVXXcmBi0gFIJlHfaNtZshfTa9/jg9sF8MbMkGxoWzxlKI0KkgRllxitm12/2HAdMlNGcspDCeWQBTcpLMyzodb3c9dJIj6f/cGTNz0w6+tKn2J8Choi1h/PIfektidsQEFPoP8hdVkiA0FHjEvsdv5vJ9/y+kcMklt10w1A2KC09dtV7Aeahm6P+KNcy+RoCGFoaF5GS4ToTtmQ5mTkfCGFYBFhoMrmIdVGSYlAaZhm53/uSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VV1pzylMtiJbaf1DCMAdNM/POHYJ2+zwgryBLilgFJw=; b=IsAHu7vwqnbaAPR8PWze+qTrR29Pw3RnVdDpgm6WIbJ26bKBf77iMiTZbe8Z+0eqDtdi9T22cH60/lR+GR40WkD3bLsLA7LfSfC3mSEVoFU66MtIEXWmB0rxRRrK35bfk7Biu3dAGIUl4NJQGofjpnpbQJ/CljJj0M189sLj3HCDqmXO7gDwi8tnYFZrkKzp9d9aqT1v4w/hb9RcWOBFuvPyI+g9N8Df/mGHoWF6pLeY0ijpSpsgw2XJbC57ShFsb0nt0tKKjMG4RYTpJSsti8NfyXmc3Y8uG6Kv3iCP/kwhdPtak6FMhz/WgvEfPd+tAMfY3YI4WZTFn0Y8/x7+jA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> Date: Tue, 14 Feb 2023 17:13:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: [PATCH] x86/Xen: make use of IBPB controlling VM assist Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Juergen Gross , Boris Ostrovsky References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> In-Reply-To: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0189.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6802:EE_ X-MS-Office365-Filtering-Correlation-Id: ec8b2aa5-6fb2-4b64-02e0-08db0ea66d0d X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 79THX79eiVsPKVw3HF8aN8G01+L1e91C7dgNBneXSsA+W4Z46XrSdIz11fG8xxBxfZl60+FpIlDmTvC0B95rmE2YP1doT5Pj7i2EFpvlmi2Law9+RxZRvYMjrK3m6IUNgXVhl7pIMn40A5Ts0fwfctiyoQPpbDYCFSjnMcvfohJ3IQ0T4AieAYHURp4NHOTmGWtoQvLDrM7PWkX83UNjBdxolrOud79O6EiGBRaIs3B+ovtAsLVtR8Lb9e3WZtK6IoOTaIcbI1qmtXN0o4LGAUmWFNQbPCPV3/zwb3C02BXj0bC42RUJYErCxDjjIaP1TyKhfqQoEIcVvgPVA04TSuQoZvltYv41MjwFUEw8ckBznxiGt240W2PZtw4T3xkUyH2d6xPb1LjxFLu7YhBDjxVLX2NSWx86xbpN8q0AN49yUKsisrQkYxLckK9UVWdlfNhyv61Dp88fKHngG9x+Z2J71UCXlMKG8V0XEk7k8XsKoE/e/DbD2XVsQ3k0PDymKXf5STNNofi36Eoacbg6Nr0Q6p3uno0SYax7WhH5Sz+EVBKYeT+N1yWOyoHjb2w1srjy4hTt12KIZJHVNtI3ssmncH8Oq4uijkLgJqEj57Z6N8ExYEUoLw5uGT/lx2fqQZcnQbZtk18xO7ICzPg5Y1OTurBwtULjodU+llTVKrOnG9cZb8mX6KCsTk6zwzWYxJYM1I/83x4VFaamqT99WXQlIXo7GK7T9OTAnoUcv74= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199018)(31686004)(6486002)(316002)(54906003)(83380400001)(4326008)(478600001)(8676002)(66556008)(2616005)(6916009)(66476007)(66946007)(41300700001)(8936002)(5660300002)(2906002)(38100700002)(6506007)(6512007)(26005)(186003)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0ZHNjk3amNNNVc0bHVZU3JKWlBlRzlVVUdFWjh0bGs5Wkd2dy9aZFF4OEk3?= =?utf-8?B?YnBDd0VMTGo3b2d2MkJKWVBLcWdhOUt4SHVBN1JSQ3NIOWtGVjhrQ1JqbkZi?= =?utf-8?B?cStmck1JOFczVXA0RmxEaVA3SHYrdTlFdnp3b1VpMXQ4cmFHS2VQR04rV2NW?= =?utf-8?B?RUpRNEJyYXBlTGRYTkIvNXBzcU5YUjFJVy91UEF3K3lOUWxvWVh2WnZWSjV4?= =?utf-8?B?U2tDdTZicUhkdHRiYUVycVFIbWVTK0xaS1dFNlFwL004UDlvK00xZjVQWjAr?= =?utf-8?B?NTJFRXRIRUhBSThvWEYxTXU0VkpXdTVXNUIvb0M5TE9zWk5HR0V4QkdKSXE3?= =?utf-8?B?VUIvbjREdEtFRUxDanZRWTN6enU1WTI1OTdMc1h6VFVsZW1nOFFrVlU0aXY2?= =?utf-8?B?L3dGR295bGZVYkRiMnFkQTRnRW9qaElOK3NldDR2SXZzaThKeXZxMTQyWm1w?= =?utf-8?B?ZWxzQ3dCbE94ZmtBdy9iaTRyLy9Cd1dlL3VLay9BUUVLZHlhNU55UW4wRVYw?= =?utf-8?B?eG5yd0p1SEJjOGY2T2JUS0xsWHdvWCtDY2twL3RNd28yeitsVDhmbUk2ZkxN?= =?utf-8?B?NnE0NkNYSENzRmMvQ2l1aHdSR0lhcEVzM0RIODRncmF4eXhhVUt2SWpNaVBN?= =?utf-8?B?NzIxQisxY1YyQnM5OHNrZDg3WEMyV1YwUDNnRE1xaklyM0tSK0sxVFVCbWNp?= =?utf-8?B?RHgyWVh2ME9BTWVUdzN5eXRJbTZlaHlxaWQyeC9qblhoRFBTUHdOMDdIeEhJ?= =?utf-8?B?YllUUGUvenpIeC90b3hKdWQ4OVlzZ0Vidno0VFEwMkhQUk1lTHpTRmpGeThI?= =?utf-8?B?d3pmb3l1ZXhHVlUyNjQxQXV1bURLaGk4UDQvL3F0MzJXeTB1UEFLdkhkQkxO?= =?utf-8?B?akRGb1F5NUd5T3FmN1RFM0NXK09nZ3RLR0JScGNhNUxZaDIyNWg3OVhOeHBN?= =?utf-8?B?MmdkQ3FEOW1hMDNMWFZoSXZyRVRrTE1VbjExK3Bsd3VzZ2RlSWpPckg0NWxE?= =?utf-8?B?bDlRZm5POWYvTmRzeHdWWldOY2UyZG9TZEdVc1NCdXRsVHR2SjY0SzJJMldu?= =?utf-8?B?UHU4TUVQS1RJMDJXNUtmL1E2YVgrVmFLRHBrRlhVYzBZYms5ODBYMGM1MWda?= =?utf-8?B?bVNxUU8vWXc0RXJQR2lldU5MK0N6T3JBQ3B1VmpEaXJRNGNyc2w2MWQ4T01y?= =?utf-8?B?SzU3SlB1UlB0b1U1MW9wUXNLQytoVEQ4dXRaVnNvUVlDOTBJcmJ2TlA4NGdU?= =?utf-8?B?cEZxS1BMQ3ZzNm5XZ1g1Y2drRFBRWVNqQmJ5T0l4N2l6dk1tZXp2OENSYVQ0?= =?utf-8?B?U3JGVU1VRWtObGVza2pyRjZrdm96aTdXTDZ5ZEVYRVNid1d2dy80bnFUcHBJ?= =?utf-8?B?cUFscjR4S1FQeUFXU0pVb1dNMzV3QlB6b25YQWpGYUF4RHIzWCtBM2wvSWs2?= =?utf-8?B?UDRDeFMvSlIvYTFOMmFIUUIyL2RROTF2eHNJT0VUK0tYc2xEUkZ0cmRRc1Ix?= =?utf-8?B?YmJhVUpKa1JkUUdUUDltQ1Zhalc2RFZPdGkwU1ZManJQTnJYMUcyUXRNZWFN?= =?utf-8?B?bm5iQjF0YzV3eVVvemozYllWSk5jOVNpcUpHMVN4MEVLbVpyMlJZelBsK2dB?= =?utf-8?B?ckt5bVhDYkk3dEhrNVdOcSt2UWYrcFA3WGxibkJ6bjNUMkJ3eE5UTmM4OFpN?= =?utf-8?B?cDhiOFVwK0JZSXBCcjRNRWpqZjVGdGQySWtYYVhNa0RESVZMRjE2YXQ0emcr?= =?utf-8?B?Vmtuanc4em5YWXRETWpMekdnbGVTQkF5L3NYUFkyeEFOSlFHWEQxaFpYR2NB?= =?utf-8?B?d2UxZmE3ZUk0R05JTXdpNDZhL1FKSFY4NytucXN3czJ5Z1ViODMzWUJRV0VU?= =?utf-8?B?RWo1T0o1UFA2d29JNzd6V2hReTBqRllDUnRnNEhXakQ5N0FsNVZQUWZJK1dH?= =?utf-8?B?OTNEQVd3UjM0MGoxVnZOOUVvOE5mU25rSFRsQUF5TGZGOURDMlVpU1B1MTls?= =?utf-8?B?ekxhUXArazdyNFFYRVllOUk0akNwMFZUUFVYeDBkaUJOcEQ5QS84Z1FBTXB3?= =?utf-8?B?clpQRlhlaUt4ekVvcktXUG9HRnRGVXZsWDA0OUg5aURYNnU2a21MT09iS01s?= =?utf-8?Q?Vnujn2Gyv+bTukpUf+MhBHfub?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec8b2aa5-6fb2-4b64-02e0-08db0ea66d0d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:13:36.2798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1KYVhP7Srnk0YZDEIWk+r/vrNuQ6YhxlE4IF5Er2t8XADsEcqhYA8Fa1DV0M9we8zsreMfsJ3SrWdI1h5Dj0BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6802 If this VM assist is available (to PV guests only), use it to - avoid issuing an IBPB ourselves upon entry from user mode (which the hypervisor would then have to emulate, as the MSR write traps), - suppress the IBPB in the hypervisor if we don't mean to have one issued. As there's no good place to have xen_vm_assist_ibpb() as an inline function, make it an init-only out-of-line one. While adjusting the Xen public header, drop the unused and no longer applicable MAX_VMASST_TYPE (instead of modifying its value). Signed-off-by: Jan Beulich --- a/arch/x86/include/asm/xen/hypervisor.h +++ b/arch/x86/include/asm/xen/hypervisor.h @@ -43,6 +43,8 @@ static inline uint32_t xen_cpuid_base(vo return hypervisor_cpuid_base("XenVMMXenVMM", 2); } +int xen_vm_assist_ibpb(bool enable); + struct pci_dev; #ifdef CONFIG_XEN_PV_DOM0 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -18,6 +18,8 @@ #include #include +#include + #include #include #include @@ -32,6 +34,7 @@ #include #include #include +#include #include #include "cpu.h" @@ -934,7 +937,8 @@ do_cmd_auto: break; case RETBLEED_MITIGATION_IBPB: - setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); + if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) + setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); mitigate_smt = true; break; --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -294,6 +294,17 @@ int xen_panic_handler_init(void) return 0; } +int __init xen_vm_assist_ibpb(bool enable) +{ + /* + * Note that the VM-assist is a disable, so a request to enable IBPB + * on our behalf needs to turn the functionality off (and vice versa). + */ + return HYPERVISOR_vm_assist(enable ? VMASST_CMD_disable + : VMASST_CMD_enable, + VMASST_TYPE_mode_switch_no_ibpb); +} + void xen_pin_vcpu(int cpu) { static bool disable_pinning; --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -940,6 +940,13 @@ static void __init xen_pvmmu_arch_setup( HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_pae_extended_cr3); + /* + * By default suppress the hypervisor issuing IBPB on our behalf. In + * the RETBLEED_MITIGATION_IBPB case the VM assist will be disengaged + * again in retbleed_select_mitigation(). + */ + xen_vm_assist_ibpb(false); + if (register_callback(CALLBACKTYPE_event, xen_asm_exc_xen_hypervisor_callback) || register_callback(CALLBACKTYPE_failsafe, xen_failsafe_callback)) --- a/include/xen/interface/xen.h +++ b/include/xen/interface/xen.h @@ -413,7 +413,15 @@ DEFINE_GUEST_HANDLE_STRUCT(mmuext_op); */ #define VMASST_TYPE_runstate_update_flag 5 -#define MAX_VMASST_TYPE 5 +/* + * x86-64 guests: Suppress IBPB on guest-user to guest-kernel mode switch. + * + * By default (on affected and capable hardware) as a safety measure Xen, + * to cover for the fact that guest-kernel and guest-user modes are both + * running in ring 3 (and hence share prediction context), would issue a + * barrier for user->kernel mode switches of PV guests. + */ +#define VMASST_TYPE_mode_switch_no_ibpb 33 #ifndef __ASSEMBLY__ From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:21:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:21:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495300.765637 (Exim 4.92) (envelope-from ) id 1pRy2w-0006fc-Vz; Tue, 14 Feb 2023 16:20:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495300.765637; Tue, 14 Feb 2023 16:20:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy2w-0006fV-T7; Tue, 14 Feb 2023 16:20:46 +0000 Received: by outflank-mailman (input) for mailman id 495300; Tue, 14 Feb 2023 16:20:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy2v-0006fP-79 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:20:45 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061e.outbound.protection.outlook.com [2a01:111:f400:fe13::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 872acae3-ac83-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:20:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9500.eurprd04.prod.outlook.com (2603:10a6:10:361::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:20:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:20:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 872acae3-ac83-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXefGrCB7BNWaeqL42vS6JhpPlxyErv/GObGPynku42beKzcZYFSIaaKjcnNPUF1QJaFlGGJ0OltgQy2xVKQvTeRyiAMykcq/d3pOPyjUVTikJJx+STJGqo5U5oewHLrFdmaWEliQ9HAAB/nhgm0iC7SBGUGupZBqLIXWKcBWmUS+RsMTirGg9MOTa/Jqv6UEOVotQQi4hEfrOFFeSt+XTqBnvW2MHWOWyX/f86QZHDp5muzK+ai44BOSWXyAiffqrPd58RIR6FZs7b9TlHnaEOD/GXCSTQPnhHBdQB58YvLpJtWR/cLOGSBAq7Ax1Hj8+yR5ILG66FVbarZbDjh3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgFuH1YLVG5t44UiYK5Dv3o3h6q79PMckx2pRN2Zo20=; b=aHBWS1qmatLZPSCAk35rrCjcVTkhTY5noL4HEMEG1UdHvd+AHOyeUjq3v8lAtygXKRr3TGHqBnfrzm5hhO7z5glNLc4DkgdCwMAwKes15wLrDr8+GNr4syeOI30rS7LIYHTZEpEDwByeJaszk8n81oD9OVNA4elM1Fc9UCFu7l9cC4g0sHBxfMRnDB/5NG2kUMJaC+7WfoPrMsPDH/abvKz1j3T0QmrYVrqieurXfKangzH7f5vBPu8bkWwIktASE0ZeJWB82EjZzU3SGQWlX/2n0/2HLfYGIP7RmM9r2qZhXgNwQRMDa2oDwhxfVQB70PX2RNFBefsjyDGXtgiE4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgFuH1YLVG5t44UiYK5Dv3o3h6q79PMckx2pRN2Zo20=; b=RVFfW3lp6yLXvIQGK/BQfxLCxc44ymfxuPas6waN25nGH92qpk4GI2rRKpoemVcuvU3bQ21Cx2nlxeXrn2LhzKL4fH1QYGTHfsP68pDzBhgOoTBhBPqsHNKhc751ggs56m7Iecr220CdZiotRDkkigFnlkMZ9DXDduxNmQXbIO6Ks1ODw+4JaJgxhRHgbw4+RvhB6GniFuJdZALEVmR3/7sjmmLmCqeaNcEboaLCAcK/j9zE40rGc2qcjD2Ye0DazK2O8+cs00SrcNz/2hZ2OJuRPpQdaYZHiyYSXZJ41oGImy6Du9VEcBoox3VTM8G10J3uV9mg4/iLPSe+q8+Mww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 14 Feb 2023 17:20:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 05/10] x86/traps: guard vmx specific functions with INTEL_VMX Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-6-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-6-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9500:EE_ X-MS-Office365-Filtering-Correlation-Id: f3714235-18e1-4a5b-2007-08db0ea76a88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: azv4aSsqNt3FuGLrltNDRs83eMxJwXR6YfCcmS0nPE/ofdODW9hq8rgXijqJeasFns+wFhW7ExlTMWrRI35uPIFaiwsveuA53nAw4yeSb42dYmLjKMRNLfDiT2CbIYYRcpgqnwKtAIrffYKyS0xEGhvmdaKhdE0JaOrCtFZZHHnTKscwaoU+bY9dQDMtPUc09B2IMSZL1Otbh9nOy79T2e+smqw0fbRKxtIDOmyvGC+DoJ2vYFd+4HQ6IE6B3/3bySfM5iC7w13ZZAlLD8H6+K+kLwZMsPmifAUU41fz54r+zFdO7Sz80DVbnTPdpP81sk2S7JS9DD3lg7T9cy2IFgw9u5MUI+uQuseBLHmXL57l/tC9jX1x1/QQpg5ORS+r4q0IGV/WF893v7MIq4wsiD4IuPA+DEUPBQrsup8k3URapLnIfIXegaz+yK/R2mvhU0Qs2Pa9CZ4WR14vg3YTPI4Sk35p6KVav1s/H37DSfwVZj1yzRNlg+RlbYk3YsjE1huA3fTJb7gKHYM66LvlL8z0dDmQtNUIB7YWxq0qneu80xl7rk6TFgBHbs3Xjc0//0qC51X+OqFRGXZR7Lj929nZQx72stgx2d5iMiEng6ZBzP5xt9BGIdEQZMEeP7oBUDqCB8c85C5BTKL7GqyBfRInVBSKhKg9goOvg02Mmnd8r9IOj3A8pPJHcVWBNMUySB29xoWoBaB2fRawPaIC/kBdOBzQoD6Sc7qAz4HRoUk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199018)(2906002)(86362001)(83380400001)(31696002)(2616005)(66946007)(26005)(38100700002)(66476007)(66556008)(54906003)(316002)(36756003)(4744005)(8936002)(8676002)(41300700001)(6916009)(5660300002)(4326008)(6506007)(6666004)(53546011)(6486002)(186003)(6512007)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmF5MExmaFhlTlF4aHg5RVR0NGNoNEZjajI4WDVMdzdWV3d6OWtleWtwNDcx?= =?utf-8?B?bW1oazFDelkxaHNXUS85ZTEvTGRuWEw3ZkhtUkxSNE4wQWZxNC90M3NVVEUv?= =?utf-8?B?RWMzMUpQYkdKbnNGOEJ3b0NjYmMrZnNDbzg2RG5DWmtwU2s1WHg5anhEK0R3?= =?utf-8?B?aEg5MGV2aTk5TEtyeXB5VEF6bWVxSHJOVUl3Mkk5V3lNT2RyY1FoNG4zRDQ5?= =?utf-8?B?cVVkcXJXUVQzNDZYWWdNeE94bzVVdzZzeURaSDVNOVlReDZRbjRRYUYrNEgr?= =?utf-8?B?UnZ3RGVwRy9QS3hqSEFoY2V1ak4waXhjejNFOURoL2U3VzZ4clptUFlBOEl5?= =?utf-8?B?V0NKdEFzSXp4ZUJPUGtOUWcrVFc3Wmxyd0dBRDVIRXdXMWNTcFVNQTkyOXVj?= =?utf-8?B?elhQWERLU2xXenR6eko3eGtSaHdUODVKQm5mQUlnQnNuYVI5Q0FtOFc2Z0Rv?= =?utf-8?B?OUJwV3dIYnk4VEhBbm9tajlUcERqTG5VRFBwckJJa1hqWnRtNTloUDFOS0ZH?= =?utf-8?B?Y014Vllrb1Yzdm04MGlweDBKWXB5ZXdPeXFjQkNDT3BzY1hDSFdvYlpBMS9D?= =?utf-8?B?NkVQbWJWSTcrN25DdWNKUHN4WVBURlV3VERJOFM0TDZjR0VvWHU4SFFvaGZH?= =?utf-8?B?anNQdEhDN2tRUkFWY0pralJaMjlGQjUxZHU5SDZqeWtRRDhUcnpteDZCUFF0?= =?utf-8?B?djNZc3FYbEljYitBQnZDd1NuQ0lvRCtJenZaNHpHZnJVUEtPYU5xNjZlaDRM?= =?utf-8?B?cjh1cVdVU1psbTBIRm9LUy9qMmJEdW80M0YrbzFKbHJFcDNQMVFzcmNveGdx?= =?utf-8?B?K0VTdkRraFUzbzlRbC9ZUHZ3SUdmbHVHblZjOGFlVm81OXpiYjJJK21pVVIx?= =?utf-8?B?SlVrclV5bFhqTUYvK1NISWliamJyZXNsaXJLR01hREtjZXZySE5iNjV2eTQr?= =?utf-8?B?bkJFVm5TZjJvRDUyNVoyUG1vUkI3Wm92QitNZEIvOVFBYit0YjA3SGV5V3Nz?= =?utf-8?B?M2FDV0JJanVaQmVvaXBQc3krSldyemtTb0xBbWViT1BDSUgrWExXa3BlSXEy?= =?utf-8?B?eS9XM1l3c1pKeWRSc1l6NE9FS1ZSYlQ1NHZQM0lkNEk0M3hwRnVKS2RqdzVo?= =?utf-8?B?a0ZtQ2dReGVINDZKUW4wOUlZWGFMbEJTT0loNXBJYmhJYWF5NjZFM1Q1b0Fj?= =?utf-8?B?aHdadU43N3JNY1FyYXBqQWhFZm5vSkFPTlBueUpBVmJKdVJUU3ZDT29oS0JW?= =?utf-8?B?b3R6dWJBMTRtRzdTeGZWOTBnKzJBeis4Zzd6MXVFSndFMlhxSlZjNXpwTEpU?= =?utf-8?B?bFpTYWdOZlM4UHllQ1AzK3NGd2ZCekRmd0tld0hTanJSMXprQ1hwRFErRldt?= =?utf-8?B?Yyt5dEsvM2pldFlsT1laMUFRNUVqZis3RmF5bEpCZFFCbVAwcWhmSjhUZmc2?= =?utf-8?B?K2lBYnBwdkV4LzBmZXEyN08vY3NMaFkzblk4ZzVvTUhzOUQvb1o3WWZ3RW5Q?= =?utf-8?B?UmlSRVRVOHRNbVlpQnRSM2pTTUMxaVFqZzlJaitCU3o4Q0lycWVKRVJLTWhq?= =?utf-8?B?QmlFcndUbDliZ0xkTTlRVlJmTjVuSVFIZC9aelh1MEtsc3dGOXFNUDh0SWlB?= =?utf-8?B?Yms4SkV1a1U1RkczL2wyTHcxNXFSRkN0Y0hLcFEwdVFCdlNuWHh2N3ZuMStx?= =?utf-8?B?QkFSTERuYXZyeUlUdGZmc29FZzFoYkJHT3oySHFpNzdjVk9OaExpSU1OQm92?= =?utf-8?B?L0pqQ3Z3U1JWRjVjQXk0cEJIWEhVdzFyZ1B4Y2NnTE0xMDEyZ2JPTWpnU0Z5?= =?utf-8?B?bFdUbFgxa3dlS1h0MzZLY3pDSUFVeUQ3VW5RTnRnNERtUmRsT2drcHRjaGk3?= =?utf-8?B?bkpsQS8yMmlXRW9SMjZGQ2svVVhBSEpaUXhmS0hZdGtWY0IzcVMxSGtYUEpB?= =?utf-8?B?MDMxZnVGYXJRMTlVVWZJbTdjVEE2Z0dqQ1UrQkxQTVYwNjIybFpzOHl0Mklt?= =?utf-8?B?QWU3WWVERm5FVUJ6VCs5Q3R1SElsc2VyMElLWEQ1azJvZDhhN3B6R0ppL0dp?= =?utf-8?B?d0NvYUFzcU9XYys3NHFpcEV2Tm1OeEw3V2pVV3p0cUFDSkxKRVU4Z0VyNFdO?= =?utf-8?Q?PvHmSdYKoMOY/Fsv1xxHGwL6i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3714235-18e1-4a5b-2007-08db0ea76a88 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:20:41.4877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VcfWIeHwT2k8XX5Sr8FhIY+AM/FKQbtXhXl8K3E/GYknBkCYGFM8CXpv6jHlQ58UQ5B3AXzZZ+uDOFAxPisusg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9500 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > The functions vmx_vmcs_enter() and vmx_vmcs_exit() are VT-x specific. > Guard their calls with INTEL_VMX. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou With whatever the final name of the Kconfig control is going to be Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:22:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:22:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495306.765648 (Exim 4.92) (envelope-from ) id 1pRy4N-0007Dk-A3; Tue, 14 Feb 2023 16:22:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495306.765648; Tue, 14 Feb 2023 16:22:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy4N-0007Dd-7H; Tue, 14 Feb 2023 16:22:15 +0000 Received: by outflank-mailman (input) for mailman id 495306; Tue, 14 Feb 2023 16:22:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy4L-0007DX-Qw for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:22:13 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc8cae3d-ac83-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:22:12 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso12022283wms.4 for ; Tue, 14 Feb 2023 08:22:12 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p21-20020a05600c359500b003db06224953sm19006178wmq.41.2023.02.14.08.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 08:22:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc8cae3d-ac83-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Prb4AaALdT2XU2+3Egzfh8fuIhJv7tm/Feh3tsqjveU=; b=SoeQgSkCDnta5T1uaRanb7qquLO+8aY9/YShejEIJP+v8pjrNBeqhLrpiE/IWIQZrA oYbnwqCOAPCNTu6j8fwtEjHpmIIHwAJPZ67v9GMKlVrz0p5QRF6zNseAnEGfXs3mdlt9 qR4O99KFiNoImvk+HSVLg+gWyraGLmBt77uOLcPkAP+tKsMc0ylDNBCQgezDHotxfjt0 qaqxIfuqCAF0LJ8FJU3EPSl2HnFWgS8jZl1oUeZjRFOKoh/wBMBg9aJWa0Ncz4GnxlFN rxcS3sed2+K2aqXSraXUEXNi9Xq3Ii4jveeUd810/PwXBHNv6+s1E28EOFQQmN7ejTMu 6zBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Prb4AaALdT2XU2+3Egzfh8fuIhJv7tm/Feh3tsqjveU=; b=bzyAC/oM4vLA36bN+9liaeDqy9V9S5zLO904lCIzAs6PBBSHBSpaux9U1IzH8rpFtC +TUugNMuXCgU+uPFI28NKOCq8NEo6HxdLM0AWpTh/GrxJyfjYaresFy/Wa444HpUVkkD rxX4Co3yyDm4BihmPkQJpyI3naSCThbYDnZlL//5xojfOHYTMqHjorBdItz5GNqNHpWb zxWnIzqiY47zyvXvCBb6X7PV2XlYjYKpGpkzfYtB+EurURrWIJxONoVuyCMCcaUpbsX0 AqB6lcMCJZYkWvUSCxeZ61sVpOwEIB+c9I6b09ZO/hQBHEmIMNa5BcuonOPJagmSNbt1 5G2g== X-Gm-Message-State: AO0yUKU/acQKG4Fh0gfUcuU3HMVqDgQlVOgjF4G7BXgnYLX7hVX4uqeN +axdwr1A+MCfAKfYSnuuoj8= X-Google-Smtp-Source: AK7set8gB1GTRkJBqfn/RzxFTAj3H3c7L6rxQyvrqeT98yDzlZOK060HQ0a5lDKrsHYsAmzXtER+tg== X-Received: by 2002:a05:600c:4d97:b0:3df:fbc7:5b1d with SMTP id v23-20020a05600c4d9700b003dffbc75b1dmr2317335wmp.2.1676391731750; Tue, 14 Feb 2023 08:22:11 -0800 (PST) Message-ID: <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 14 Feb 2023 18:22:09 +0200 In-Reply-To: <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGkgSmFuIQoKVGhhbmtzIGEgbG90IGZvciBzdGFydGluZyB0aGUgcmV2aWV3IG9mIHRoZSBwYXRj aCBzZXJpZXMhCgpPbiBNb24sIDIwMjMtMDItMTMgYXQgMTM6MjQgKzAxMDAsIEphbiBCZXVsaWNo IHdyb3RlOgo+IE9uIDAzLjAyLjIwMjMgMTg6MDUsIE9sZWtzaWkgS3Vyb2Noa28gd3JvdGU6Cj4g PiAtLS0gYS94ZW4vY29tbW9uL0tjb25maWcKPiA+ICsrKyBiL3hlbi9jb21tb24vS2NvbmZpZwo+ ID4gQEAgLTkyLDYgKzkyLDEyIEBAIGNvbmZpZyBTVEFUSUNfTUVNT1JZCj4gPiDCoAo+ID4gwqDC oMKgwqDCoMKgwqDCoMKgIElmIHVuc3VyZSwgc2F5IE4uCj4gPiDCoAo+ID4gK2NvbmZpZyBHRU5F UklDX0RPX0JVR19GUkFNRQo+ID4gK8KgwqDCoMKgwqDCoMKgYm9vbAo+ID4gK8KgwqDCoMKgwqDC oMKgaGVscAo+ID4gK8KgwqDCoMKgwqDCoMKgwqAgR2VuZXJpYyBkb19idWdfZnJhbWUoKSBmdW5j dGlvbiBpcyBuZWVkZWQgdG8gaGFuZGxlIHRoZQo+ID4gdHlwZSBvZiBidWcKPiA+ICvCoMKgwqDC oMKgwqDCoMKgIGZyYW1lIGFuZCBwcmludCBhbiBpbmZvcm1hdGlvbiBhYm91dCBpdC4KPiAKPiBH ZW5lcmFsbHkgaGVscCB0ZXh0IGZvciBwcm9tcHQtbGVzcyBmdW5jdGlvbnMgaXMgbm90IHZlcnkg dXNlZnVsLgo+IEFzc3VtaW5nCj4gaXQgaXMgcHV0IGhlcmUgdG8gaW5mb3JtIHBlb3BsZSBhY3R1 YWxseSByZWFkaW5nIHRoZSBzb3VyY2UgZmlsZSwgSSdtCj4gb2theQo+IGZvciBpdCB0byBiZSBs ZWZ0IGhlcmUsIGJ1dCBwbGVhc2UgYXQgbGVhc3QgZHJvcCB0aGUgc3RyYXkgImFuIi4gSQo+IGFs c28KPiB0aGluayB0aGlzIG1heSB3YW50IG1vdmluZyB1cCBpbiB0aGUgZmlsZSwgZS5nLiBhaGVh ZCBvZiBhbGwgdGhlCj4gSEFTXyoKPiBjb250cm9scyAod2hpY2gsIGFzIHlvdSB3aWxsIG5vdGlj ZSwgYWxsIGhhdmUgbm8gaGVscCB0ZXh0IGVpdGhlcikuCj4gUGx1cwo+IGZpbmFsbHkgaG93IGFi b3V0IHNob3J0ZXIgYW5kIG1vcmUgYXBwbGljYWJsZSBHRU5FUklDX0JVR19GUkFNRSAtCj4gYWZ0 ZXIKPiBhbGwgd2hhdCBiZWNvbWVzIGdlbmVyaWMgaXMgbW9yZSB0aGFuIGp1c3QgZG9fYnVnX2Zy YW1lKCk/ClRoYW5rcyBmb3IgdGhlIGNvbW1lbnRzLiBJIHdpbGwgdGFrZSB0aGVtIGludG8gYWNj b3VudC4KUmlnaHQgbm93IG9ubHkgZG9fYnVnX2ZyYW1lKCkgaXMgZXhwZWN0ZWQgdG8gYmUgZ2Vu ZXJpYy4KCj4gCj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi94ZW4vY29tbW9uL2J1Zy5jCj4g PiBAQCAtMCwwICsxLDg4IEBACj4gPiArI2luY2x1ZGUgPHhlbi9idWcuaD4KPiA+ICsjaW5jbHVk ZSA8eGVuL2Vycm5vLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ID4gKyNpbmNsdWRl IDx4ZW4va2VybmVsLmg+Cj4gCj4gUGxlYXNlIG9yZGVyIGhlYWRlcnMgYWxwaGFiZXRpY2FsbHkg dW5sZXNzIHRoZXJlJ3MgYW55dGhpbmcKPiBwcmV2ZW50aW5nCj4gdGhhdCBmcm9tIGJlaW5nIGRv bmUuClN1cmUsIHRoYW5rcy4KCj4gCj4gPiArI2luY2x1ZGUgPHhlbi9zdHJpbmcuaD4KPiA+ICsj aW5jbHVkZSA8eGVuL3ZpcnR1YWxfcmVnaW9uLmg+Cj4gPiArCj4gPiArI2luY2x1ZGUgPGFzbS9w cm9jZXNzb3IuaD4KPiA+ICsKPiA+ICtpbnQgZG9fYnVnX2ZyYW1lKGNvbnN0IHN0cnVjdCBjcHVf dXNlcl9yZWdzICpyZWdzLCB2YWRkcl90IHBjKQo+IAo+IEkga25vdyBBcm0gaXMgdXNpbmcgdmFk ZHJfdCBhbmQgUklTQy1WIG5vdyBhbHNvIGhhcyBpdCwgYnV0IGluIFVOSVgtCj4gbGlrZQo+IGVu dmlyb25tZW50cyB0aGF0J3MgcmVkdW5kYW50IHdpdGggInVuc2lnbmVkIGxvbmciLCBhbmQgaXQn cyBhbHNvCj4gcmVkdW5kYW50IHdpdGggQzk5J3MgdWludHB0cl90LiBIZW5jZSB3aGVuIHNlZWlu ZyB0aGUgdHlwZSBJIGFsd2F5cwo+IHdvbmRlciB3aGV0aGVyIGl0J3MgcmVhbGx5IGEgaG9zdCB2 aXJ0dWFsIGFkZHJlc3Mgd2hpY2ggaXMgbWVhbnQgKGFuZAo+IG5vdCBwZXJoYXBzIGEgZ3Vlc3Qg b25lLCB3aGljaCBpbiBwcmluY2lwbGUgY291bGQgZGlmZmVyIGZyb20gdGhlCj4gaG9zdAo+IG9u ZSBmb3IgY2VydGFpbiBndWVzdCB0eXBlcykuIEluIGFueSBldmVudCB0aGUgZXhpc3RlbmNlIG9m IHRoaXMgdHlwZQo+IHNob3VsZCBpbW8gbm90IGJlIGEgcHJlcmVxIHRvIHVzaW5nIHRoaXMgZ2Vu ZXJpYyBwaWVjZSBvZgo+IGluZnJhc3RydWN0dXJlLgo+IApJIGFtIE9LIHdpdGggY2hhbmdpbmcg dmFkZHJfdCB0byAndW5zaWduZWQgbG9uZycgYW5kIGFncmVlIHdpdGggeW91cgpwb2ludApzbyBp ZiBubyBvbmUgaXMgYWdhaW5zdCB0aGF0IEknbGwgY2hhbmdlIGl0LgoKPiA+ICt7Cj4gPiArwqDC oMKgIGNvbnN0IHN0cnVjdCBidWdfZnJhbWUgKmJ1ZyA9IE5VTEw7Cj4gPiArwqDCoMKgIGNvbnN0 IGNoYXIgKnByZWZpeCA9ICIiLCAqZmlsZW5hbWUsICpwcmVkaWNhdGU7Cj4gPiArwqDCoMKgIHVu c2lnbmVkIGxvbmcgZml4dXA7Cj4gPiArwqDCoMKgIGludCBpZCA9IC0xLCBsaW5lbm87Cj4gCj4g Rm9yIGJvdGggb2YgdGhlc2UgSSBxdWVzdGlvbiB0aGVtIG5lZWRpbmcgdG8gYmUgb2YgYSBzaWdu ZWQgdHlwZS4KSSB0b29rIHRoZSBjb2RlIGZyb20gQVJNIGJ1dCBpdCBsb29rcyBsaWtlIHRoZSB0 eXBlIG9mIGlkIGFuZCBsaW5lbm8KY2FuIGJlIGNoYW5nZWQgdG8gJ3Vuc2dpbmVkIGludCcuIFNv IEknbGwgdXBkYXRlIHRoZSBjb2RlCmNvcnJlc3BvbmRpbmdseS4KCj4gCj4gPiArwqDCoMKgIGNv bnN0IHN0cnVjdCB2aXJ0dWFsX3JlZ2lvbiAqcmVnaW9uOwo+ID4gKwo+ID4gK8KgwqDCoCByZWdp b24gPSBmaW5kX3RleHRfcmVnaW9uKHBjKTsKPiA+ICvCoMKgwqAgaWYgKCByZWdpb24gKQo+ID4g K8KgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZm9yICggaWQgPSAwOyBpZCA8IEJVR0ZSQU1F X05SOyBpZCsrICkKPiA+ICvCoMKgwqDCoMKgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBjb25zdCBzdHJ1Y3QgYnVnX2ZyYW1lICpiOwo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdW5zaWduZWQgaW50IGk7Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmb3Ig KCBpID0gMCwgYiA9IHJlZ2lvbi0+ZnJhbWVbaWRdLmJ1Z3M7Cj4gPiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBpIDwgcmVnaW9uLT5mcmFtZVtpZF0ubl9idWdzOyBiKyssIGkr KyApCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmICggKCh2YWRkcl90KWJ1Z19sb2MoYikpID09IHBjICkKPiAKPiBBZmFp Y3MgdGhpcyBpcyB0aGUgc29sZSB1c2Ugb2YgYnVnX2xvYygpLiBJZiBzbywgYmV0dGVyIGNoYW5n ZSB0aGUKPiBtYWNybwo+IHRvIGF2b2lkIHRoZSBuZWVkIGZvciBhIGNhc3QgaGVyZToKPiAKPiAj ZGVmaW5lIGJ1Z19sb2MoYikgKCh1bnNpZ25lZCBsb25nKShiKSArIChiKS0+bG9jX2Rpc3ApCj4g ClRoYW5rcyBmb3IgdGhlIHJlY29tbWVuZGF0aW9uLiBJdCBtYWtlcyBzZW5zZSB0byBjaGFuZ2Ug dGhlIG1hY3JvIHNvCkknbGwgdXBkYXRlIGl0IHRvby4KCj4gPiAtLS0gL2Rldi9udWxsCj4gPiAr KysgYi94ZW4vaW5jbHVkZS94ZW4vYnVnLmgKPiA+IEBAIC0wLDAgKzEsMTI3IEBACj4gPiArI2lm bmRlZiBfX1hFTl9CVUdfSF9fCj4gPiArI2RlZmluZSBfX1hFTl9CVUdfSF9fCj4gPiArCj4gPiAr I2RlZmluZSBCVUdfRElTUF9XSURUSMKgwqDCoCAyNAo+ID4gKyNkZWZpbmUgQlVHX0xJTkVfTE9f V0lEVEggKDMxIC0gQlVHX0RJU1BfV0lEVEgpCj4gPiArI2RlZmluZSBCVUdfTElORV9ISV9XSURU SCAoMzEgLSBCVUdfRElTUF9XSURUSCkKPiA+ICsKPiA+ICsjZGVmaW5lIEJVR0ZSQU1FX3J1bl9m biAwCj4gPiArI2RlZmluZSBCVUdGUkFNRV93YXJuwqDCoCAxCj4gPiArI2RlZmluZSBCVUdGUkFN RV9idWfCoMKgwqAgMgo+ID4gKyNkZWZpbmUgQlVHRlJBTUVfYXNzZXJ0IDMKPiA+ICsKPiA+ICsj ZGVmaW5lIEJVR0ZSQU1FX05SwqDCoMKgwqAgNAo+ID4gKwo+ID4gKyNpZm5kZWYgX19BU1NFTUJM WV9fCj4gPiArCj4gPiArI2luY2x1ZGUgPHhlbi9lcnJuby5oPgo+ID4gKyNpbmNsdWRlIDx4ZW4v c3RyaW5naWZ5Lmg+Cj4gPiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ID4gKyNpbmNsdWRlIDx4 ZW4vbGliLmg+Cj4gCj4gQWdhaW4gLSBwbGVhc2Ugc29ydCBoZWFkZXJzLgo+IAo+ID4gKyNpbmNs dWRlIDxhc20vYnVnLmg+Cj4gPiArCj4gPiArI2lmbmRlZiBCVUdfRlJBTUVfU1RVRkYKPiA+ICtz dHJ1Y3QgYnVnX2ZyYW1lIHsKPiAKPiBQbGVhc2UgY2FuIHdlIGhhdmUgYSBibGFuayBsaW5lIGJl dHdlZW4gdGhlIGFib3ZlIHR3byBvbmVzIGFuZCB0aGVuCj4gc2ltaWxhcmx5Cj4gYWhlYWQgb2Yg dGhlICNlbmRpZj8KU3VyZS4KCj4gCj4gPiArwqDCoMKgIHNpZ25lZCBpbnQgbG9jX2Rpc3A7wqDC oMKgIC8qIFJlbGF0aXZlIGFkZHJlc3MgdG8gdGhlIGJ1ZyBhZGRyZXNzCj4gPiAqLwo+ID4gK8Kg wqDCoCBzaWduZWQgaW50IGZpbGVfZGlzcDvCoMKgIC8qIFJlbGF0aXZlIGFkZHJlc3MgdG8gdGhl IGZpbGVuYW1lICovCj4gPiArwqDCoMKgIHNpZ25lZCBpbnQgbXNnX2Rpc3A7wqDCoMKgIC8qIFJl bGF0aXZlIGFkZHJlc3MgdG8gdGhlIHByZWRpY2F0ZQo+ID4gKGZvciBBU1NFUlQpICovCj4gPiAr wqDCoMKgIHVpbnQxNl90IGxpbmU7wqDCoMKgwqDCoMKgwqDCoMKgIC8qIExpbmUgbnVtYmVyICov Cj4gPiArwqDCoMKgIHVpbnQzMl90IHBhZDA6MTY7wqDCoMKgwqDCoMKgIC8qIFBhZGRpbmcgZm9y IDgtYnl0ZXMgYWxpZ24gKi8KPiAKPiBBbHJlYWR5IHRoZSBvcmlnaW5hbCBjb21tZW50IGluIEFy bSBjb2RlIGlzIHdyb25nOiBUaGUgcGFkZGluZwo+IGRvZXNuJ3QKPiBndWFyYW50ZWUgOC1ieXRl IGFsaWdubWVudDsgaXQgbWVyZWx5IGd1YXJhbnRlZXMgYSBtdWx0aXBsZSBvZiA4Cj4gYnl0ZXMK PiBzaXplLiBBaXVpIHRoZXJlJ3MgYWxzbyBubyBuZWVkIGZvciA4LWJ5dGUgYWxpZ25tZW50IGFu eXdoZXJlIGhlcmUKPiAoaW4KPiBmYWN0IHRoZXJlJ3MgIi5wMmFsaWduIDIiIGluIHRoZSBnZW5l cmF0b3IgbWFjcm9zKS4KPiAKPiBJIGFsc28gd29uZGVyIHdoeSB0aGlzIG5lZWRzIHRvIGJlIGEg bmFtZWQgYml0ZmllbGQ6IEVpdGhlciBtYWtlIGl0Cj4gcGxhaW4gdWludDE2X3QsIG9yIGlmIHlv dSB1c2UgYSBiaXRmaWVsZCwgdGhlbiBvbWl0IHRoZSBuYW1lLgo+IApJdCB3aWxsIGJldHRlciB0 byBjaGFuZ2UgaXQgdG8gJ3VpbnQxNl90JyBhcyBJIGRvbid0IHNlZSBhbnkgcmVhc29uIHRvCnVz ZSAndWludDMyX3QnIHdpdGggYml0ZmllbGQgaGVyZS4KSSdsbCBjaGVjayBpZiB3ZSBuZWVkIHRo ZSBhbGlnbm1lbnQuIElmIHRoZXJlICBpcyAnLnAyYWxpZ24gMicgd2UKcmVhbGx5IGRvbid0IG5l ZWQgaXQuCgo+ID4gK307Cj4gPiArCj4gPiArI2RlZmluZSBidWdfbG9jKGIpICgoY29uc3Qgdm9p ZCAqKShiKSArIChiKS0+bG9jX2Rpc3ApCj4gPiArI2RlZmluZSBidWdfZmlsZShiKSAoKGNvbnN0 IHZvaWQgKikoYikgKyAoYiktPmZpbGVfZGlzcCk7Cj4gPiArI2RlZmluZSBidWdfbGluZShiKSAo KGIpLT5saW5lKQo+ID4gKyNkZWZpbmUgYnVnX21zZyhiKSAoKGNvbnN0IGNoYXIgKikoYikgKyAo YiktPm1zZ19kaXNwKQo+ID4gKyNlbmRpZiAvKiBCVUdfRlJBTUVfU1RVRkYgKi8KPiA+ICsKPiA+ ICsjaWZuZGVmIEJVR19GUkFNRQo+ID4gKy8qIE1hbnkgdmVyc2lvbnMgb2YgR0NDIGRvZXNuJ3Qg c3VwcG9ydCB0aGUgYXNtICVjIHBhcmFtZXRlciB3aGljaAo+ID4gd291bGQKPiA+ICsgKiBiZSBw cmVmZXJhYmxlIHRvIHRoaXMgdW5wbGVhc2FudG5lc3MuIFdlIHVzZSBtZXJnZWFibGUgc3RyaW5n Cj4gPiArICogc2VjdGlvbnMgdG8gYXZvaWQgbXVsdGlwbGUgY29waWVzIG9mIHRoZSBzdHJpbmcg YXBwZWFyaW5nIGluCj4gPiB0aGUKPiA+ICsgKiBYZW4gaW1hZ2UuIEJVR0ZSQU1FX3J1bl9mbiBu ZWVkcyB0byBiZSBoYW5kbGVkIHNlcGFyYXRlbHkuCj4gPiArICovCj4gCj4gV2hlbiBnZW5lcmFs aXppbmcgdGhlIGxvZ2ljLCBJIHdvbmRlciBpbiBob3cgZmFyIHRoZSBjb21tZW50IGRvZXNuJ3QK PiB3YW50IHJlLXdvcmRpbmcgc29tZS4gRm9yIGV4YW1wbGUsIHdoaWxlIEFybSBwcmVmaXhlcyBj b25zdGFudCBpbnNuCj4gb3BlcmFuZHMgd2l0aCAjIChhbmQgeDg2IHVzZXMgJCksIHRoZXJlJ3Mg bm8gc3VjaCBwcmVmaXggaW4gUklTQy1WLgo+IEF0Cj4gd2hpY2ggcG9pbnQgdGhlcmUncyBubyBu ZWVkIHRvIHVzZSAlYyBpbiB0aGUgZmlyc3QgcGxhY2UuIChXaGljaCBpbgo+IHR1cm4gbWVhbnMg eDg2J2VzIG1vcmUgY29tcGFjdCByZXByZXNlbnRhdGlvbiBtYXkgYWxzbyBiZSB1c2FibGUKPiB0 aGVyZS4KPiBBbmQgeWV0IGluIHR1cm4gdGhlIHF1ZXN0aW9uIGFyaXNlcyB3aGV0aGVyIFJJU0Mt ViB3b3VsZG4ndCBiZXR0ZXIKPiBoYXZlCj4gaXRzIG93biBkZXJpdmF0aW9uIG9mIHRoZSBtYWNo aW5lcnksIHJhdGhlciB0aGFuIHRyeWluZyB0byBnZW5lcmFsaXplCj4gdGhpbmdzLiBSSVNDLVYn cyB3b3VsZCB0aGVuIGxpa2VseSBiZSBjbG9zZXIgdG8geDg2J2VzLCBqdXN0IHdpdGhvdXQKPiB0 aGUgdXNlIG9mICVjIG9uIGFzbSgpIG9wZXJhbmRzLiBXaGljaCBtaWdodCB0aGVuIHN1Z2dlc3Qg dG8gcmF0aGVyCj4gZ2VuZXJhbGl6ZSB4ODYnZXMgdmFyaWFudCBkb3duIHRoZSByb2FkLikKQVJN IHZlcnNpb24gaXMgbW9yZSBwb3J0YWJsZSBiZWNhdXNlIG9mIHRoZSAnJWMnIG1vZGlmaWVyIHdo aWNoIGlzIG5vdApwcmVzZW50IGV2ZXJ5d2hlcmUsIHNvIEkgZGVjaWRlZCB0byB1c2UgaXQgYXMg YSBnZW5lcmljIGltcGxlbWVudGF0aW9uLgpNb3Jlb3ZlciBJIGRvbid0IHNlZSBhbnkgcmVhc29u IHdoeSB3ZSBjYW4ndCBzd2l0Y2ggeDg2IGltcGxlbWVudGF0aW9uCnRvICdnZW5lcmljL0FSTScu CkFuZCBvbmUgbW9yZSB0aGluZyBpZiB5b3UgbG9vayBhdCBXQVJOL0JVRy9BU1NFUlRfRkFJTEVE L0JVR19GUkFNRQptYWNyb3MgaW1wbGVtZW50YXRpb24gdG8gdXNlIGl0IGluIGFzc2VtYmx5IGNv ZGUgdGhlIGltcGxlbWVudGF0aW9ucwphcmUgY2xvc2VyIHRvICdnZW5lcmljL0FSTScuCgo+IAo+ IEF0IHRoZSB2ZXJ5IGxlYXN0IHRoZSBjb21tZW50J3Mgc3R5bGUgd2FudHMgY29ycmVjdGluZywg YW5kIGluIHRoZQo+IGZpcnN0Cj4gc2VudGVuY2Ugcy9kb2Vzbid0L2Rvbid0Ly4gQWxzbyAlYyBp c24ndCBhIHBhcmFtZXRlciwgYnV0IGEgbW9kaWZpZXIuCj4gClRoYW5rcyEKCj4gPiArI2RlZmlu ZSBCVUdfRlJBTUUodHlwZSwgbGluZSwgZmlsZSwgaGFzX21zZywgbXNnKSBkbwo+ID4ge8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgIEJVSUxE X0JVR19PTigobGluZSkgPj4KPiA+IDE2KTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IFwKPiA+ICvCoMKgwqAgQlVJTERfQlVHX09OKCh0eXBlKSA+PQo+ID4gQlVHRlJBTUVfTlIpO8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBhc20KPiA+ICgiMToiQlVHX0lOU1RSIlxuIsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gCj4gTml0OiBTdHls ZSAobWlzc2luZyBibGFuayBhZnRlciBvcGVuaW5nIHBhcmVudGhlc2lzLCBhbmQgdGhlbiBhbHNv IGF0Cj4gdGhlCj4gZW5kIG9mIHRoZSBjb25zdHJ1Y3QgYWhlYWQgb2YgdGhlIGNsb3NpbmcgcGFy ZW50aGVzaXMpLgo+IApJJ2xsIGZpeCBpdC4KCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAiLnB1c2hz ZWN0aW9uIC5yb2RhdGEuc3RyLCBcImFNU1wiLCAlcHJvZ2JpdHMsCj4gPiAxXG4iwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICIyOlx0LmFzY2l6 ICIgX19zdHJpbmdpZnkoZmlsZSkKPiA+ICJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+IAo+IGZpbGUgaXMgYWx3YXlzIGEg c3RyaW5nIGxpdGVyYWw7IHJlYWxseSBpdCBhbHdheXMgaXMgX19GSUxFX18gaW4gdGhpcwo+IG5v bi14ODYgaW1wbGVtZW50YXRpb24uIFNvIGZpcnN0IHByZWZlcmVuY2Ugb3VnaHQgdG8gYmUgdG8g ZHJvcCB0aGUKPiBtYWNybyBwYXJhbWV0ZXIgYW5kIHVzZSBfX0ZJTEVfXyBoZXJlIChzYW1lIHRo ZW4gZm9yIGxpbmUgdnMKPiBfX0xJTkVfXykuCj4gWWV0IGV2ZW4gaWYgbm90IGRvbmUgbGlrZSB0 aGF0LCB0aGUgX19zdHJpbmdpZnkoKSBpcyBsYXJnZWx5IHVubmVlZGVkCj4gKHVubGVzcyB3ZSBl eHBlY3QgZmlsZSBuYW1lcyB0byBoYXZlIGUuZy4gYmFja3NsYXNoZXMgaW4gdGhlaXIgbmFtZXMp Cj4gYW5kIGxvb2tzIHNvbWV3aGF0IG9kZCBoZXJlLiBTbyBob3cgYWJvdXQKPiAKPiDCoMKgwqDC oMKgwqDCoMKgICIyOlx0LmFzY2l6IFwiIiBfX0ZJTEVfXyAiXCJcbiIKPiAKPiA/IEJ1dCB3YWl0 IC0gcGVla2luZyBhaGVhZCB0byB0aGUgeDg2IHBhdGNoIEkgbm90aWNlIHRoYXQgX19GSUxFX18K PiBhbmQKPiBfX0xJTkVfXyBuZWVkIHRvIHJlbWFpbiBhcmd1bWVudHMuIEJ1dCB0aGVuIHRoZSBz ZWNvbmQgcHJlZmVyZW5jZQo+IHdvdWxkCj4gc3RpbGwgYmUKPiAKPiDCoMKgwqDCoMKgwqDCoMKg ICIyOlx0LmFzY2l6IFwiIiBmaWxlICJcIlxuIgo+IAo+IGltby4gWWV0IG1heWJlIG90aGVycyBk aXNhZ3JlZSAuLi4KPiAKPiA+ICvCoMKgwqDCoMKgwqDCoMKgCj4gPiAiMzpcbiLCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+ IFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICIuaWYgIiAjaGFzX21zZwo+ID4gIlxuIsKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICJcdC5h c2NpeiAiICNtc2cKPiA+ICJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ ID4gK8KgwqDCoMKgwqDCoMKgwqAKPiA+ICIuZW5kaWZcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gPiArwqDCoMKgwqDCoMKg wqDCoAo+ID4gIi5wb3BzZWN0aW9uXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgCj4gPiBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAiLnB1c2hzZWN0aW9uIC5i dWdfZnJhbWVzLiIgX19zdHJpbmdpZnkodHlwZSkgIiwgXCJhXCIsCj4gPiAlcHJvZ2JpdHNcbiJc Cj4gPiArwqDCoMKgwqDCoMKgwqDCoAo+ID4gIjQ6XG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiBcCj4gPiArwqDCoMKg wqDCoMKgwqDCoCAiLnAyYWxpZ24KPiA+IDJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAiLmxvbmcgKDFiIC0K PiA+IDRiKVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8Kg wqDCoMKgwqDCoMKgwqAgIi5sb25nICgyYiAtCj4gPiA0YilcbiLCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgICIubG9uZyAoM2IgLQo+ ID4gNGIpXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDC oMKgwqDCoMKgwqDCoCAiLmh3b3JkICIgX19zdHJpbmdpZnkobGluZSkgIiwKPiA+IDBcbiLCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBcCj4gCj4gSG1tLCAuaHdvcmQuIEhvdyBnZW5lcmljIGlzIHN1cHBvcnQgZm9yIHRoYXQgaW4g YXNzZW1ibGVycz8gSSBub3RpY2UKPiBldmVuCj4gdmVyeSBvbGQgZ2FzIGhhcyBzdXBwb3J0IGZv ciBpdCwgYnV0IGFyY2hpdGVjdHVyZXMgbWF5IG5vdCBjb25zaWRlcgo+IGl0Cj4gdHdvIGJ5dGVz IHdpZGUuIChPbiB4ODYsIGZvciBleGFtcGxlLCBpdCdzIGJvZ3VzIHRvIGJlIHR3byBieXRlcywK PiBzaW5jZQo+IC53b3JkIGFsc28gcHJvZHVjZXMgMiBieXRlcyBvZiBkYXRhLiBBbmQgaW5kZWVk IE1JUFMgYW5kIE5EUzMyCj4gb3ZlcnJpZGUgaXQKPiBpbiBnYXMgdG8gcHJvZHVjZSAxIGJ5dGUg b2YgZGF0YSBvbmx5LCBhdCBsZWFzdCBpbiBjZXJ0YWluIGNhc2VzLikKPiBJJ2QKPiBsaWtlIHRv IHN1Z2dlc3QgdG8gdXNlIGEgZm91cnRoIC5sb25nIGhlcmUsIGFuZCB0byBkcm9wIHRoZSBwYWRk aW5nCj4gZmllbGQKPiBmcm9tIHN0cnVjdCBidWdfZnJhbWUgaW4gZXhjaGFuZ2UuCkNoYW5naW5n IC5od29yZCB0byAuaGFsZiBjYW4gbWFrZSB0aGUgY29kZSBtb3JlIHBvcnRhYmxlIGFuZCBnZW5l cmljLAphcyAuaGFsZiBpcyBhIG1vcmUgc3RhbmRhcmQgYW5kIHdpZGVseSBzdXBwb3J0ZWQgYXNz ZW1ibGVyIGRpcmVjdGl2ZQpmb3IgZGVjbGFyaW5nIDE2LWJpdCBkYXRhLiAKQnV0IHByb2JhYmx5 IHlvdSBhcmUgcmlnaHQgYW5kIGl0IHdpbGwgYmUgZWFzaWVyIHRvIGNoYW5nZSBpdCB0byAubG9u Zy4KCj4gCj4gRnVydGhlcm1vcmUsIG9uY2UgYXNzZW1ibHkgY29kZSBpcyBnZW5lcmFsaXplZCwg eW91IG5lZWQgdG8gcGF5Cj4gYXR0ZW50aW9uCj4gdG8gZm9ybWF0dGluZzogT25seSBsYWJlbHMg bWF5IHN0YXJ0IGF0IHRoZSBiZWdpbm5pbmcgb2YgYSBsaW5lOyBpbgo+IHBhcnRpY3VsYXIgZGly ZWN0aXZlcyBuZXZlciBzaG91bGQuCj4gCj4gPiArwqDCoMKgwqDCoMKgwqDCoAo+ID4gIi5wb3Bz ZWN0aW9uIik7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4g PiBcCj4gPiArfSB3aGlsZSAoMCkKPiAKPiBOaXQ6IFN0eWxlIChtaXNzaW5nIGJsYW5rcywgYW5k IHByZWZlcmFibHkgImZhbHNlIiBpbnN0ZWFkIG9mICIwIikuCj4gCj4gPiArI2VuZGlmIC8qIEJV R19GUkFNRSAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgcnVuX2luX2V4Y2VwdGlvbl9oYW5kbGVyCj4g PiArLyoKPiA+ICsgKiBHQ0Mgd2lsbCBub3QgYWxsb3cgdG8gdXNlICJpIsKgIHdoZW4gUElFIGlz IGVuYWJsZWQgKFhlbiBkb2Vzbid0Cj4gPiBzZXQgdGhlCj4gPiArICogZmxhZyBidXQgaW5zdGVh ZCByZWx5IG9uIHRoZSBkZWZhdWx0IHZhbHVlIGZyb20gdGhlIGNvbXBpbGVyKS4KPiA+IFNvIHRo ZQo+ID4gKyAqIGVhc2llc3Qgd2F5IHRvIGltcGxlbWVudCBydW5faW5fZXhjZXB0aW9uX2hhbmRs ZXIoKSBpcyB0byBwYXNzCj4gPiB0aGUgdG8KPiA+ICsgKiBiZSBjYWxsZWQgZnVuY3Rpb24gaW4g YSBmaXhlZCByZWdpc3Rlci4KPiA+ICsgKi8KPiA+ICsjZGVmaW5lwqAgcnVuX2luX2V4Y2VwdGlv bl9oYW5kbGVyKGZuKSBkbwo+ID4ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gCj4gTml0OiBKdXN0IG9uZSBibGFu ayBwbGVhc2UgYWZ0ZXIgI2RlZmluZSAoYW5kIG9uIHRoZSBmaXJzdCBjb21tZW50Cj4gbGluZQo+ IHRoZXJlJ3MgYWxzbyBhIGRvdWJsZSBibGFuayB3aGVyZSBvbmx5IG9uZSBzaG91bGQgYmUpLgo+ IAo+ID4gK8KgwqDCoCByZWdpc3RlciB2b2lkICpmbl8gYXNtKF9fc3RyaW5naWZ5KEJVR19GTl9S RUcpKSA9Cj4gPiAoZm4pO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiAKPiB4 ODYgbWFrZXMgc3VyZSAiZm4iIGlzIG9mIGNvcnJlY3QgdHlwZS4gQXJtIGRvZXNuJ3QsIHdoaWNo IGxpa2VseSBpcwo+IGEKPiBtaXN0YWtlLiBNYXkgSSBhc2sgdGhhdCB5b3UgdXNlIHRoZSBjb3Jy ZWN0IHR5cGUgaGVyZSAod2hpY2ggaXMgZXZlbgo+IGJldHRlciB0aGFuIHg4NidlcyBleHRyYSBj aGVja2luZyBjb25zdHJ1Y3QpOgo+IAo+IMKgwqDCoCByZWdpc3RlciB2b2lkICgqZm5fKShzdHJ1 Y3QgY3B1X3VzZXJfcmVncyAqKQo+IGFzbShfX3N0cmluZ2lmeShCVUdfRk5fUkVHKSkgPSAoZm4p Owo+IAp0aGUgdHlwZSBvZiAnZm4nIHNob3VsZCBiZSB1cGRhdGVkLiBJJ2xsIHRha2UgaW50byBh Y2NvdW50IGluIHRoZSBuZXh0CnZlcnNpb24gb2YgcGF0Y2guCgo+ID4gK8KgwqDCoCBhc20KPiA+ ICgiMToiQlVHX0lOU1RSIlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gPiBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVz LiIgX19zdHJpbmdpZnkoQlVHRlJBTUVfcnVuX2ZuKQo+ID4gIiwiwqDCoMKgwqDCoMKgIFwKPiA+ ICvCoMKgwqDCoMKgwqDCoMKgICLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXCJhXCIsCj4gPiAl JXByb2diaXRzXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoAo+ID4gIjI6XG4iwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gPiBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoCAiLnAyYWxpZ24KPiA+IDJcbiLCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDC oMKgwqDCoCAiLmxvbmcgKDFiIC0KPiA+IDJiKVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgwqAgIi5sb25nIDAsIDAsCj4gPiAwXG4i wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKg wqDCoMKgwqAgIi5wb3BzZWN0aW9uIiA6OiAiciIKPiA+IChmbl8pKTvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ICt9IHdoaWxlICgwKQo+ID4gKyNlbmRpZiAvKiBydW5faW5fZXhjZXB0aW9uX2hh bmRsZXIgKi8KPiA+ICsKPiA+ICsjaWZuZGVmIFdBUk4KPiA+ICsjZGVmaW5lIFdBUk4oKSBCVUdf RlJBTUUoQlVHRlJBTUVfd2FybiwgX19MSU5FX18sIF9fRklMRV9fLCAwLCAiIikKPiA+ICsjZW5k aWYgLyogV0FSTiAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgQlVHCj4gPiArI2RlZmluZSBCVUcoKSBk byB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgQlVHX0ZS QU1FKEJVR0ZSQU1FX2J1ZyzCoCBfX0xJTkVfXywgX19GSUxFX18sIDAsICIiKTvCoMKgwqDCoMKg wqDCoCBcCj4gPiArwqDCoMKgIHVucmVhY2hhYmxlKCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKPiA+ICt9IHdoaWxlICgwKQo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gKyNpZm5k ZWYgYXNzZXJ0X2ZhaWxlZAo+ID4gKyNkZWZpbmUgYXNzZXJ0X2ZhaWxlZChtc2cpIGRvIHvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ICvCoMKgwqAgQlVHX0ZSQU1FKEJVR0ZSQU1FX2Fzc2VydCwgX19MSU5FX18sIF9f RklMRV9fLCAxLCBtc2cpO8KgwqDCoMKgIFwKPiA+ICvCoMKgwqAgdW5yZWFjaGFibGUoKTvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK30gd2hpbGUgKDApCj4gPiArI2Vu ZGlmCj4gPiArCj4gPiArZXh0ZXJuIGNvbnN0IHN0cnVjdCBidWdfZnJhbWUgX19zdGFydF9idWdf ZnJhbWVzW10sCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBfX3N0b3BfYnVnX2ZyYW1lc18wW10sCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX3N0b3BfYnVn X2ZyYW1lc18xW10sCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBfX3N0b3BfYnVnX2ZyYW1lc18yW10sCj4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX3N0b3Bf YnVnX2ZyYW1lc18zW107Cj4gPiArCj4gPiArI2Vsc2UgLyogIV9fQVNTRU1CTFlfXyAqLwo+ID4g Kwo+ID4gKyNpZmRlZiBDT05GSUdfWDg2Cj4gPiArI2luY2x1ZGUgPGFzbS9idWcuaD4KPiA+ICsj ZW5kaWYKPiAKPiBXaHkgdGhpcyB4ODYgc3BlY2lhbD8gKFRvIGJlIHByZWNpc2U6IFdoeSBjYW4g dGhpcyBub3QgYmUgZG9uZQo+IHVuaWZvcm1seT8pCj4gCldlIGNhbiBsZWF2ZSBvbmx5ICcjaW5j bHVkZSA8YXNtL2J1Zy5oPicuIEkgaGFkIGFuIGlzc3VlIGR1cmluZyBtYWtpbmcKdGhlIGNvZGUg bW9yZSBnZW5lcmljLiBJIHJlbW92ZWQgaXQgYW5kIHJlLXJ1biB0ZXN0cyBhbmQgaXQgbG9va3Mg bGlrZQppdCBpcyBmaW5lIHRvIGdvIHcvbyAnI2lmZGVmLi4uJzoKaHR0cHM6Ly9naXRsYWIuY29t L3hlbi1wcm9qZWN0L3Blb3BsZS9vbGt1ci94ZW4vLS9waXBlbGluZXMvNzc3Mjg4MzM2Cgo+IEph bgp+IE9sZWtzaWkK From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:24:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495314.765658 (Exim 4.92) (envelope-from ) id 1pRy6g-0007rq-Tf; Tue, 14 Feb 2023 16:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495314.765658; Tue, 14 Feb 2023 16:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy6g-0007rj-R1; Tue, 14 Feb 2023 16:24:38 +0000 Received: by outflank-mailman (input) for mailman id 495314; Tue, 14 Feb 2023 16:24:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy6f-0007rZ-8E for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:24:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7e1b::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1205fd0c-ac84-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:24:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9500.eurprd04.prod.outlook.com (2603:10a6:10:361::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:24:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:24:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1205fd0c-ac84-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bK8wO85vX3OiJcv8Y8H+K0Av0UelnTUzs4EM6t4kjh4/tcqnQP1++RgfQL8cltMCPUfIaq4WtmCmqMhCAOL+nbsrZq+0xnw4bMO+Q5/f2SSUqhhYn1oWg1lF+cgZyKLFS/aJMOfnxuZ9VJwr8XlREAZAXmWApiwYoctPmLupasWBftdUdiWaiwYUxtoVlykq9caeO4x1+Z5DaCjrl7fVyXiGBeuPEK8onmLP9SE5IdKXrObuZAr9i5eggaTDe8F3dIqY1Lr4RZu1ydbbFvZEeTUdCbmFZsMkFz8ibhsEV2tsLZ1guG64VZxBlv7W5Ulv+rO276eNl35wToA7QNWG9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/VMByIgAGddLMYk9B61m9I9XeS8tV0u9U/ihcd92eI=; b=BGv3VEDtdvhfLNFqrgzivEGYMkHM/tpaC+fAZfXmaluNrKLbw0qMcbsQmZlFe0W7+lE7nZ1IP/BhZ3r3+WBs56GfRHiLPgG8BwspyQLuPJ1R3be5WhbvUCxSIV8kZkE08qdzVMqvFec0RL82DN7IEiFisvQqdFJwag9d4ooe/qRWFoFd1xtJiem/9dJvjk8vqpGsPvBuUshb9IRifpI2c8BDthcfIb+623oHSDZcoDShZXG4NWe2sFCdiPmle5ICjOa/vbn9aT64udi3pjvIcsxSnAt2dYzkEEGhOehpxi4t8Lsr/bQ4KetRM1QK4z8OjKvZMegY1gnMkXBfqo/UdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/VMByIgAGddLMYk9B61m9I9XeS8tV0u9U/ihcd92eI=; b=RQPn1dXKfFr3d+QDakUrQR/ccO3x1HujVZfE4g8PSpXx8mzlz5PB2vIoR7VY8NObI7SknWx9ZhBg7ketg8y3SZoBuUx89r79tflVK+SKRBui+vxOC31iWEyvusio6ErLXg6tHTM1RFhJiUDJtihARcx3Xdo7D6RPsEUZLi3oK6mH4Hzvb9C7zM2mWWPfvQ8z5sznvUYaeaIqT6MKLYpkd4YR/uNZtvfMOJUYCQPLxwWEH/sb1BsciUk1PBjwS+XO2mM3BCEyVedxiLbFd3f5oYeSMRbAgyLKHvdMzNsXELURLLx3xtLPechthukQ3cKwOeiKqHmt56fyEzvG1oVYPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f8ef895-48ec-ca39-f197-a83b9cd46469@suse.com> Date: Tue, 14 Feb 2023 17:24:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 06/10] x86/domain: guard svm specific functions with AMD_SVM Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-7-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-7-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9500:EE_ X-MS-Office365-Filtering-Correlation-Id: 55505d1c-1eb5-4a4b-da9c-08db0ea7f566 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kwG1lBOYeJubwjY/wAN5lXES3ADrTHzGKHDSNc1FsLM62/8uQHlJGumXzX4YmaytZUXFq9kz5eMsMaZtKTZR6KvbG1gGt6bjA00lXJ5x/sGdbuWcmLbe81EFdwdm3DYnMFT+JpGe1cqFf+Z3EJnGrYgso34e47ZHKbmxOewoxszGgCZiTy2YSn2PdfEMEPcC8GRsekPC+btI8FXI8v0eDxDPjHSJkPT4rll/2lykJIyPtqDTyADi8q+g6gCn6UZHzfPdEpfvvJDXe96Y+E9B0CrYUAgUwHLwuqdw/FazM0HaT0yrszQ4jcN5H53/jmpTH8cbWaN0iCwAKDt7ywAybsJ8/36zkddjJlxMtbFL6i+vzGvr0jOsn9E7B6fp1Zpj1d49sQc5p71tW2sh87eTlmk9lMliNijrWXniADaQqMq4rlf5SyuaXE6WPXDwp3dmYdd+3Q3jKgxD8GXe1gkwAkRR1xaixbijieM8FwfIRClcH2k2kIHqOC6YLyt3cvScTb4IXNebuH+ZF+S1YQ+8J/I++WBS4Nt2JrRlPMeMnZUoeEpoLJEgQrDeEhQZWm0Rx1Kp7ZgRRyf/Ys72doaffROeZ6HPz9QDGVtLeoBWTsMF9PHADXPJALS8piVYe+MVvKBBQ3ZtwmKCgvjqeN9rUzefHcVJ1+OIaygACtV1eiMQnLzlveyHE4I1fGZNw2jBGxE6j/FDna7mzIubIMm6apTVIdIBLmaUgu9kaeH2g4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199018)(2906002)(86362001)(83380400001)(31696002)(2616005)(66946007)(26005)(38100700002)(66476007)(66556008)(54906003)(316002)(36756003)(4744005)(8936002)(8676002)(41300700001)(6916009)(5660300002)(4326008)(6506007)(53546011)(6486002)(186003)(6512007)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDNMKzBUU2J4L3Y4U014TUpmZ3hQajRKaXd2RkFMalI4L1pVWFlnc0xyVDIw?= =?utf-8?B?dXNOWlBoanNWL3FIa0N0VTNHUlI0R2tJWFRESkdZNGlINkdmK2VRejE2Q3Rm?= =?utf-8?B?VlNwVkpBSVk2MWZZM0hLRnZWS0tFUlhpZ01Fcm0xWkdubytBNmtpRTY3ZTYr?= =?utf-8?B?TFNlcG13SzdpZmFtZmg1WlgxSjZVVUU0L2Fob2EyUXo0cmlIdEs3cFlXdmk1?= =?utf-8?B?TVRPZnp2OVcxL0JzU0Zmc0xkaU0rQmc0c3ZueHkyZnI3Smx0NEZQMXJLU2pQ?= =?utf-8?B?d3VOSFBjaGY1NUJFT3ZlSjhKL2JZZXlsdEZOZ1RQOERiSTRIQSsrYVNCbC90?= =?utf-8?B?WGw5N1lPTUtpUnAvRmZuRFl3a2NycVBqU3dCYlJNblNQUS82c3BpSnNIZjd3?= =?utf-8?B?SHNGYTA0RW53R0RnY0UyZGFzV3JvY3FNbm5XU00vNmgvNkc4bmk5VHdsV05w?= =?utf-8?B?Z1FoOFFrZTZ4NmJYTnhrQ2hhUmNFaTJlY1NoMlFEdmdFNS8xMmxKekd2aXAw?= =?utf-8?B?WGlic0VwUVprVTdRd0hNZlhEQS9IMy9kVlhURDJFRVZXN0xjUm5mK0xQMmVa?= =?utf-8?B?MndUSWJCUWZoa2dpdDlPVDBHQThRWCtQYnRSN1ZlQ0RIMlVJcUM4MFZoS0Vx?= =?utf-8?B?WkRIUitUZTBZaVlZRUc0Y2toL3VnNWpqckJlWWpIak9DdnJnMmJLNGRaSW03?= =?utf-8?B?Wk5jeXpFYlZvaFpkdmpkMk92T1d3b0FoUm5sZm5oZDROOXFER1V6VVl4dEJH?= =?utf-8?B?U3VOTXFwNVg5RFZheVZQeU9DdkZ0MUNta2EvMlNLVGNwbVNZbEg0UGtqN0pt?= =?utf-8?B?RlJpaHhHY0J1YXZIM09pcStQUzN6NWtBdDhVemlsQnNySjlTOGs5SG02RU42?= =?utf-8?B?eXNmOTNUNDBoL0U0bmpJbFcwa0pZKzJkYlROZlh2NThGdHV3cSttbnU4NVN4?= =?utf-8?B?UFdtbS9aakhKakVOUTlWejNxdmdCVHlMUVk3a0lUTzlEVHByTm00U3FkQTZV?= =?utf-8?B?Zy9JVnVVRzdmbzB6UHg4enBsNkdxZGdrVXFYL0w5Z3lPRWVKQ3JJbjRicUtG?= =?utf-8?B?alpwWGZZTVFWSzdobXlnb2ZSVlF1MlROVVdhNkpIeFZrVUo3K2FSd0hUZ0ta?= =?utf-8?B?Y0JCMWhpKzF1V081RHFNM3l5VTM4UkgrMmlReGRZYTVnWitCZzNYdnVqMU1k?= =?utf-8?B?cGtjdnFnckZCc2dJeWtlVGg0cEFhZ21mOVdoSnNKb0J3d285RVcyLy9QaTFS?= =?utf-8?B?ZExScFhnL2d2dFZOT2dsYWFvM2wySjNlalkzM1ViZFFPa2lIUGphajhZUFZC?= =?utf-8?B?RmxMNjZyUVZLZmNGQytFZk91RWg1cWVLdmpZVlN5T2hsa0pHRFR0aFlabDA2?= =?utf-8?B?bnNzR0VjaXkzcFhTbDQ0Y2QwcCs4aFVTSmpVcXFINzFRSWVDT285R0dCZFRL?= =?utf-8?B?dFdiVjl3QnlWWnFOUEV6R2lqT2FJR1lGTC9hN2o3UmRFZUdlcEJkajE2WkZV?= =?utf-8?B?ZDIrU0Y5dXo0YzZ4ZkRlL2phQ2FDQXBFMFIvcGxyZ0pNRjZmMnFMV0NVT1Av?= =?utf-8?B?NHk3aDNCaDZRcmhFTlF4ZytrQTlnbGFpK2JWQTdyeEIzbXNBamJDS29RcXRM?= =?utf-8?B?V20rUXhXRlV6U1gxRnphNXdyUVNIVHJTQksvaWcya09OZklGRlFLczFoa0Vh?= =?utf-8?B?a1Z4ZXp1U3ZGdlYyZ3YybHBGU2ZvRm0wcHN3Vys2eWxGVW1yb3NRV1pORUhM?= =?utf-8?B?dU1INnNON1krM3h6K0QzT1I2NjlrMkZGenJMeXh0dlpmdWRja0lpb0t1OXZW?= =?utf-8?B?aVRBYkI5MXNZd3d1UWpmb2pPbFFvOEdPSE5vNklDMTNPdUVHVXoxZjQ1QkFw?= =?utf-8?B?Tmw4bW85ZktFMks2UFhxdnRwRmZQdzRVcVN5NmxEVkJPYndPWGpMU3lpUndl?= =?utf-8?B?aXp4NkdjRDZmUGJGM2Z1SFQzVUVwaVA0RzF0S2YrY2VLcnVsMmpIY0hOUS9V?= =?utf-8?B?ODNLUnFBZWkxSXIzY2gvTkV0c2k1QUdyb1E3ZUVSZ1JodEZhWEtsVjQraG0x?= =?utf-8?B?Nm5XRFV6RVZndnlDV3diNFV3YVhmdG92aUZqUUsvSmlTalQzMGdaZnFEa2F4?= =?utf-8?Q?WCCWC0tTLHiY/S+/TG+Cp54jb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55505d1c-1eb5-4a4b-da9c-08db0ea7f566 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:24:34.6136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YjEGhtJx1FmptnXR34aL3ATJ+I0rFnL0tvNEStV4kOBpiGLLYhMK+dKOpljYfxnPBMFpuSqKu/mIPUGw5gZRfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9500 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > The functions svm_load_segs() and svm_load_segs_prefetch() are AMD-V specific > so guard their calls in common code with AMD_SVM. > > Since AMD_SVM depends on HVM, it can be used alone. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou With whatever the final name of the Kconfig control is going to be Acked-by: Jan Beulich Thinking about it, both here an in the earlier patch it may be worth considering to switch to use of IS_ENABLED() while making these adjustments. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:26:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495321.765670 (Exim 4.92) (envelope-from ) id 1pRy8n-0008ST-9Q; Tue, 14 Feb 2023 16:26:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495321.765670; Tue, 14 Feb 2023 16:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy8n-0008SM-6j; Tue, 14 Feb 2023 16:26:49 +0000 Received: by outflank-mailman (input) for mailman id 495321; Tue, 14 Feb 2023 16:26:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRy8m-0008SG-89 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:26:48 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060c.outbound.protection.outlook.com [2a01:111:f400:fe12::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f8886f8-ac84-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:26:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8863.eurprd04.prod.outlook.com (2603:10a6:102:20e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:26:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:26:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f8886f8-ac84-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j9ZNoU8YtLP9jBz+eWYhZB7pPDPFrt29GHr5qahvAYsBx6AxI8pGDynJHwXY2fqEJiSEYxRD4Y0DfBfVjQoQQggJOJY+gifFkGHsWHHrwSGgE9pU7DOC3NHIHIzaixO4+O1hGnXdl5GH4w2FLzWXrqyAw9Q3u6358xKs1L0Ik2lJC4qfb8zPu+argI81AhKowbU8Q+q/G+j5shR3kzINmf2saBwvMeekNhDfHk7W7uiYuis9WM9nPYNnIqE8CT1m0creWUJz2Ftz1g+LoC7rU0y7+ox90P3IG7tNCSrPLKE3NI4U5aHUHN7hM5plTcMLFszVDz7F8HUB7bWqK3Ldww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b66aqTjqh/1PpbplIZQRel44ESUn/N1mzY16kSlNPSE=; b=fotsj4c8rk/UVIzB8jKpnDt+zOC9KeUo/KOU1FUzepYLsoCAWl2V2VExdFeDvgyTwljsUhxti3+7fvQNgnd5q+vlU5KvZkI2AsvJR8EZiG40c4hKu5tIzpAzOzLbgQtugWnwvQb+5D2A4FuUrvrMkBCcAEBfDXqDmk61aCSZciEeW+23ZICbjGnmWvY1AWcTHSB6+O1DFWDXgvcWntjvMXAT2BndbAnspWBX6sQwewLnsskL+WO80lC4Hqfv7e7rVY4a39yOcz+4SV/lDSV0UIw1IqNRDJiXu8jaJzcwH1cclDfDthLHda1Tduc882oUPJHZigOxposoJOf6Q6vH4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b66aqTjqh/1PpbplIZQRel44ESUn/N1mzY16kSlNPSE=; b=2bkxKrcQa63ksd6gYg8Z7g8YqIGQAzSKH6GyuMU3p6AtXew190Z2nIiW3iTrBCorTc2d2kG+LqCfbxwbfO9LlF/NfOldi+Z5+tbizpWdTD7zzAeupdNktXhoQ/v5K/9WpmB6xd3SVp7zXpA3/Sbfs0j7HjI+2E1D2KPMDBGadCyX4ZLGSg/CjqwNevhICv/abjk6E6hSINaZ3SsMPg0fH1BPM6jzq6jwnuOGtY8LsDwLfPtEkAy8nZhUikm7JxiV5NyGDvEveCmgl2A+9JQZDXUFvuHc5KPIIqs9MgJYR+gRQpoWVoplwbXaIhHKivycPhKkJBRVmeBaUcKRa7CsEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 14 Feb 2023 17:26:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 07/10] x86/oprofile: guard svm specific symbols with AMD_SVM Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-8-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-8-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: b40b4a4d-beb6-4df1-08b4-08db0ea842a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gx+wcbZq2Dcuw+4ioKJQpzE+hfZOs6Pe0yQIcxI4rVoqUYhcyNphcD7qgh2DUmVO8r8rr59ICDiyc7JfhmItiCn3OFT9tXqkISo+k+sBwr9pGwuAwKWNHlOXTPXZde2ZBOWROmuT55mefHHbCawJ1OH08PV1GbZoaEXueeXZHI/NsDq1W8tSCOGXFvGLF8k0y8HJBzXUGmwFyAHBbVUlwVuDhEmwQMrfG+8Imi3oxZPC2XfGwBlnZ19deoE8UsiAxt8VxFIEpzY8E1WKl+LafhOTdLqkjpwc3dOvdNY7ICkc+UKUJQlGbWjgmlLJM//JpF/6BkWm4BA6rJ7AXcuYdW2xnxT+0mdi2kSFplH5hFW+3ekRd/Wxz9I/FLRRWPaaN2S+v5SI6evsX9nS7Xu5bWjEzmw44lvqJzCGC4fu1CXhujiVAKhqxAfOTxVNn+x8b/7epErc3/7uRi5o0fev3Tm4D53XK//2aLq1UpNcnfuN71853C2R493xuM+ZtflcxT2U7fLqn5XmSPiTowNG87QV719JfjESg4XLRnbE+nSKvCbGvD1bIBtCJKXnmD9YIGbVR1cDscB2X/hHEJ95uPWHM2FGt5VGS5plU42xtKUSJhqEklatlCC7JEm+UVk7o/4lMJgFGFYEdlThuJTJe7Xmo5+P3mqGKZYwVnWCJdduxUjbM38iVQidzZ1+XIvmyMQ4P8tMngynUpOBIXsEbQuu/r7jYx43Cqk3CUzQcCs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199018)(86362001)(31696002)(36756003)(8676002)(54906003)(316002)(66946007)(4326008)(2906002)(6486002)(478600001)(2616005)(66556008)(83380400001)(41300700001)(6916009)(4744005)(8936002)(5660300002)(66476007)(38100700002)(6506007)(26005)(53546011)(6512007)(186003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzMybXFlWDJZcUl1RTFrUXM3cVJEUVBWL2xsWFRhYll0dkd0QXlvVHV3NTRk?= =?utf-8?B?U054Q0QyblZ6R3NmcUUwZ1FlSTBQQ0kvTzhHUUFXRGxTcE93L2hNSnJJaE85?= =?utf-8?B?NWF4M21ZejlJaFRZSkROejcrWmFhSytvUVBsQ09PWjBQT2xMQUdjelNjVzAv?= =?utf-8?B?YjJXazdhOGY5b2V2ZlowR0Nyc2c4M290c3dKZGZzUWRZRGoyVUx0WVA3VE1B?= =?utf-8?B?TU5zdGJZeDRERWtxaFZLZXlPY2pLNmtwbEs5VkpSd1pKc0hEOVowUDZhTTUy?= =?utf-8?B?NU5id3R2aXhWVUdlVzNGQ1Y3Z1pYNU5oSndDd292VjZpd2F0ZFFKbnhuZTNv?= =?utf-8?B?cERGejh2VW9wL2prd3pJanh0YVZ3OHB3Q2xJZEJzMzl2Y2F6NlYxQUdya0JX?= =?utf-8?B?SEFid25ralA0UnVkU3lWcXJrTHZlOThLTlZISkdxYzFKem9NcVNWSmJ6UENv?= =?utf-8?B?YlArTXdOSExWeU9GR0hid0hZRCtCdmI4eXZZTHQ5V1diUEViUUkwMHRPT2Vn?= =?utf-8?B?YkZadlJ1VFEyZGJybktEZzFndi96MHBNQlFHanZpNGphUHZSaC81azdqdEpw?= =?utf-8?B?NmpKWXl4cUJvL1JqNUV5dTl4MkN2OWZZK2QxSGRzMTdVbDIzL0ZPa01XZWk0?= =?utf-8?B?b2hiSC8weEh4WjdpYTY0QUhkeFQxWjkyTU5wYmZiWDhBNFdYS05lQzc1T2NQ?= =?utf-8?B?eVJZSUl1SmRkOVdGbnhlK0ZaYlNqU3NMUDNZbVRNU3lNcVk4a3hWN0FqdmRC?= =?utf-8?B?dC9wRDM4alFiRlAxVU5VeHV3WFFWSEkyUzM0c0RFdUFSSWdOZEdpeGFhaGJV?= =?utf-8?B?RWVJc3FzNE1EdWlmNjZJdEwySjB0Rk9VYjVSa25WeUcxaS9uMmRDNXU2UmhX?= =?utf-8?B?elJTc1JlZXhVbXA1c1lDSjN4QkJtRlhpRm9WNU5XOExGZlNra0k1UmVpTG9G?= =?utf-8?B?RFNGRURLZTU1ZEs0VXUxL1B2aXZFQng3TktBR1BjOXV5VjduMHVOWXk2cWRx?= =?utf-8?B?Sm9JMjR2VTVPMXkvYnNoUnJrOGtlNnp3Z25TOVVpOUhQQ0w4WHRsK1ROKzhZ?= =?utf-8?B?THRVQ2ZRVC91UURPWDU1NnRmYlVkSWpQRjZVaWpHN0ppc2lDYk95Zlk0NDIv?= =?utf-8?B?clNxS3Nrcy9pbTU4cUlXK2lCS01kTHBNcVhCdkVWN3VwQitUZEZITDBYQzNy?= =?utf-8?B?aWI1NUJYTnQ4eEpDV1Y0dDVHYVVzUTJSRkNuQUsvNDM3TEZ5NFcyTmJFa2RX?= =?utf-8?B?TFJ4VkdwMmdTcDIvSjVCZVF6N3BWZERRNmo4RDV5TmdxNk5LcVFMRngxbWV6?= =?utf-8?B?bHdGZjNNTzFXdlFGS3l3aVUwZGFOTDVGU2RHb3k2a0toWmprOW9yZUNPMWd5?= =?utf-8?B?VUdoeElKVGF1YzAreGoya0l2SWFmRWNIaVFENEg3WFFibU5GeDlaMVdzR2Za?= =?utf-8?B?cDF5S1dRZm1jYUVxdExydzdmbGdDWlRVNUsxQ25xNmFLcXZqcEU2bXdCRjNo?= =?utf-8?B?T09ZME9ES0k3K1FJUXZhTnp4RmhIcFc3S0NYQ3J4ZXl2OUFUNGxtZlU3bi9C?= =?utf-8?B?L3htMDY4U093OEZIU0VpVjlUMnlXcisyc01zYTgxcmQraENYMXFnRkJaNmRz?= =?utf-8?B?MFdwcFlYUEpFU1VpZm0xQjJrQWdnMzNTaktKWlByQzUrRDdUY1JjOGpVTTVX?= =?utf-8?B?cUdaTlRjSXBJbmQ0VmZHSU1mMU5kWmR3TXZGWEVzZVhWdy9CQXBYMzZ2Tkto?= =?utf-8?B?cGNmNGpXTEJSeDVIbCtGL1dxdnhXTlBVaTBVbm9jRXl3MHVrNktZdWJwR2sv?= =?utf-8?B?Um5TUWlHYkhWZSs1V1VWVlg3cFFwWXl6THZpaXdzYzBJengvYmN2T3VXV00y?= =?utf-8?B?MXpqYUNtWHduR0hrbitsQUxxakM2Y3VWbDNMdlZMUUN4UjFZbHR5NEoxNFFV?= =?utf-8?B?VlZDVzZ1Z1N6NTJYMlZGQzRwaTBaUUw5UGpZaXBaYU5YVUdxa0ZUbHlFN3Qy?= =?utf-8?B?OUtyenhpRVE0azg1UWw1ZHNPM29IME93R2gzVVVoWEdEdW84aGdieE5BRVhR?= =?utf-8?B?OVBDMWhjaUMzVCsveDJqMWRjYlhjZmZEamQyQUdid2VIdFo1cVE0OE0vUm5j?= =?utf-8?Q?50LfRlo/Pscn17dv41LAkb+9Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b40b4a4d-beb6-4df1-08b4-08db0ea842a4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:26:44.0429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i4HGruQfZuI81kZMg4oWZKcmcEWL+5NnyUMKmPlurYM2s5YzFYZn6vlFZjzq+Nb8jOKLyBBVcth+KOv//GFUjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8863 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > The symbol svm_stgi_label is AMD-V specific so guard its usage in common code > with AMD_SVM. > > Since AMD_SVM depends on HVM, it can be used alone. > Also, use #ifdef instead of #if. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou With whatever the final name of the Kconfig control is going to be Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:28:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:28:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495326.765680 (Exim 4.92) (envelope-from ) id 1pRyA8-0000aW-Jc; Tue, 14 Feb 2023 16:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495326.765680; Tue, 14 Feb 2023 16:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyA8-0000aP-Gm; Tue, 14 Feb 2023 16:28:12 +0000 Received: by outflank-mailman (input) for mailman id 495326; Tue, 14 Feb 2023 16:28:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyA6-0000Zv-EX for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:28:10 +0000 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [2a00:1450:4864:20::42e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 917e1170-ac84-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:28:09 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id bu23so16244946wrb.8 for ; Tue, 14 Feb 2023 08:28:09 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id x1-20020adfffc1000000b002425be3c9e2sm13551199wrs.60.2023.02.14.08.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 08:28:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 917e1170-ac84-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UBkEiwCl6774X6U2cNYVFm41NA84KkS8Y4tNQdu50uc=; b=DFscOrDMorZFsVsEzkGWkoJK7EHVShMa1w6hNUt4OFjT8udIynQHIxkNDkHQDzjF5y EJ2hLZqWmu9wUsraID71bnu8S8Wjeukfn4kOcMEubn+GlZ1O6NS4176mikCMKvcqNats mFyzBOmuOS+0OafFXJQ4USdUEkmA2PDvn1a7w7aIKOmgb40AIXTsBPrD5vHEPUz8SG/R rHy8xMbUbZy+Gw/vauDrESdHIvClOT+TK6bDhrTknhpZHrdPUE+VbSWeJF5i8pOCIBod O0kpkpa+V43UOXeoR34YCehEGD/Qxi9fjw6TaFMNfPQFDRVAMW1AtWsHz3ZeDwlyI7OX aIBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UBkEiwCl6774X6U2cNYVFm41NA84KkS8Y4tNQdu50uc=; b=suLe/Ra9q+Ovi6jsp7I7O8LaIkDUDCPR/TEy6u0ow7fVSDATmONppRZ0Kdd4KJaJUC A8/6/v+RvUvE37uglY7KF+/EMDp7BMaIkZKprnkRceZeOxZvHxcHsGgI5HbVG08YYucp vvi8Wj6eTwJ/QvB0vrzEqQm+Cof/emXYR97rpS8CMAAOflZ7O0Nps8DOlfOgHgt92PMG tJOfoD6sK6QT+s2fn9dANlOOg6Wz3+NcvrqRpDnIScZi12Ad00A9dtEQiTnwhuvoNs8T HElDfGx8KPq54RqZh6teZoy6CgLBFKf/brab6YS3Rcay5v3FAGYEbfXVgfvlrUluANHu 8Llw== X-Gm-Message-State: AO0yUKVEn8uLc3pQRPr6gOR9Od5s7t92NCm78CIpbczc+eSota2vV03V NqBaIW+djrM7HcPPotIf46c= X-Google-Smtp-Source: AK7set/nBGsVJSHUPKcP/jgdSako3DV6IqQbf5NqQYw1sX78A9iylaDzaJe5KCJPk1wEQtcrUnJWrQ== X-Received: by 2002:a5d:46c3:0:b0:2c5:58fd:a965 with SMTP id g3-20020a5d46c3000000b002c558fda965mr2485095wrs.35.1676392089093; Tue, 14 Feb 2023 08:28:09 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 2/4] xen/arm: switch ARM to use generic implementation of bug.h From: Oleksii To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Date: Tue, 14 Feb 2023 18:28:07 +0200 In-Reply-To: <77deb11b-e460-ef70-9710-90b13c88b680@suse.com> References: <6c8b46f2f3326b833c73dbb86674ac5eb6ea45c8.1675441720.git.oleksii.kurochko@gmail.com> <77deb11b-e460-ef70-9710-90b13c88b680@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-13 at 14:02 +0100, Jan Beulich wrote: > On 03.02.2023 18:05, Oleksii Kurochko wrote: > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -18,6 +18,7 @@ config ARM > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select HAS_PDX > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select HAS_PMAP > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select IOMMU_FORCE_PT_S= HARE > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select GENERIC_DO_BUG_FRAME >=20 > Please maintain (largely?) alphabetic ordering here. Sure. I'll do that in the next version of the patch series. >=20 > Jan >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:37:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:37:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495350.765699 (Exim 4.92) (envelope-from ) id 1pRyIU-0002RS-GH; Tue, 14 Feb 2023 16:36:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495350.765699; Tue, 14 Feb 2023 16:36:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyIU-0002RL-Dh; Tue, 14 Feb 2023 16:36:50 +0000 Received: by outflank-mailman (input) for mailman id 495350; Tue, 14 Feb 2023 16:36:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyIT-0002RF-J1 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:36:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1b::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c693a1d7-ac85-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:36:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:36:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c693a1d7-ac85-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFOoAOHI6nRZtjwrRLa62i8f+D340Q9VkjfsM+/6wjmfFth3LYOJM6nk2QKR7k8c9HjUugFUGToZeG8DOkJEHvZyzwGj38VFm3t9ZCMPFhZAC84jPjT9JDn1YG66WmMvamULbVoY8P4mpY64OwKteEGPR6BytPkPwuqkODfobReJhHG6FngWi2riC55XyYXoHjlm2YVCuRr7Ia5Mpzcf84PUcDMMTswpsFk1yq9tLuOHgO5Drd0nQ0YHWsWFm2KlQgG8s9JVUeWkiwz6j89stcakk/v42WuRaE46ClZGkMAP5FP7Km47dWsu8xOn7VUiaRwZlYvnUPv8lrmqVbIvvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7wLZdtPbWHxYTlvWrqzkBQatYcECfedhQOcN11o8W/s=; b=c2CzqJF5yId+i0s0j2msyr8dJCRrTRH3d8aNGbxH8CNdtbDphzrrpM73IyL2Jq9CfK3PsSRsziGmQ8lvhQjTs6WnQqcv5IWnYM4vh0E+oaPSuR/P2U+V/1FRvANugSFxHO5FvLAsj9XFKwkFN8WyCRBRYOxdiUlMWrpnUkJ7yE8AXve4rCWCUUSvjRswTRCvgo29c47YdrwR2BZ4HmGhoN607rtEYCqn9JLeEepVpUBHxP1IJfX5VQ0Hd0SaAUIV6Kbh25kmU0DG1HWX3nLkQpqqMXp4v2ViKItiOd23JziEk/M8bA4kaPESprlStQ4y1hiDUGNK9RiZaGznAPDNoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7wLZdtPbWHxYTlvWrqzkBQatYcECfedhQOcN11o8W/s=; b=NjENAanRug+1DPl4QNriHv9FqXCNTMToh5VWtF7X8sSGV+qvgUAZUBlLA/J0rfizaGUwUti+p4rqY4RHcMK/Z0XRTtdCIwMhReqhr2ciiFHYKdLK3dipd1txP4oW4SNKn60IFhutqmPzn2uyPMNWMaBL1cgAdZKnsv1r+jplcMJtdPBvQqDCjK/5s+Az9TxwwLP/KjCRzsoW/9i8qcoO+BHgsHM8kHHfh7MKX48jOi3OHOIVqfckb0wYC7abMHcNwnmw5t9kTKokV/TP/TuGLw0L7eZ+yzC5Kkf8q6rd4aI+HIMcYrbTBuuosSoO3PVxN/CHGMb4ZjW/tsMzqfL6dA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ddf5aa2-8bb2-9831-fdc6-833bb4d259f7@suse.com> Date: Tue, 14 Feb 2023 17:36:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 08/10] x86: wire cpu_has_svm/vmx_* to false when svm/vmx not enabled Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-9-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-9-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 10af31ba-96df-42e9-b222-08db0ea9a9f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bCM+FWxNIaFbOaJYg5tRQ+54EfdG7Q4xrjWuVotmoDdBPZiaI/lxewJvg0tB4J+tChFejdBqJBoOQ6ZNnPErRsDdH0O7PKUIxpv15R4lK6uF4uIzCzHzi5Fix7Q/R+UEIrUCj0vS5lb6Lp3udGyVXXqss8VzbG17rI5hHHFmjbjhL1GS2hkG9AeHsEIzMM4rbnwqlVOz0Z3MmCpKOxLLvPMvZ2baSkEcW6FUPVFbrmTRtfzz35dJPOMgIPZZ+khWbU//txYTiXt8/ZsIx9X7+h0GvuvO2I7o/SfBqf5yOMFZhVPUTb+bbr7GLZXAhDU7rCQeOpQs35sA27XJu9sLmQNsNBGMhh12ZfQVYOmiXQCenj3MK3OZJMB2414c1Ou+rwE4BIP8u6QIeGaLKejs/DvJe8Oixu0nr4dd6dawQg1GPajKIRV9PGOGDJKyJmdsBFcT4O09Xkvb8mBI8kCDNDzKXp5ritDFSy6VL/jDM8LwnQTCQBH2FU8/gUufMZWSRMjvxjbNdPHC4JDAJPK+MeQYsg/5F45Uu8dvEvWkQ9WYFcSitlJX90zNnLVFRzvoDtO+lPzS12zLUbRJfDCgv1/EAobckRFUVUlPJ4WGPdEv8GQkWs39FpPhiYGVoZJRZuoZLKnSdRqfuuGRx4Qs0NJDwK6mwC/oVz1ZnU02Yfz+Rj8CSGdaSzW/zBDYy+gwRvtc2amHeay1rExtiDIEbaUO8dnhOidtCfTVvaN7qCY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(346002)(366004)(136003)(396003)(451199018)(66946007)(83380400001)(54906003)(316002)(4326008)(66556008)(66476007)(5660300002)(41300700001)(8936002)(8676002)(478600001)(2616005)(6916009)(53546011)(6512007)(26005)(186003)(6506007)(6486002)(36756003)(31696002)(2906002)(38100700002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkNhemJxL2JBU0swdHhSS2JwL1puZGREbEwxaGpPTUx3cHZpTTZhOThkMGpD?= =?utf-8?B?djVVM2hIdjdFZUlHQklleUJwZXFKRDFWTkRZOUVJREZ3VmlFN21GamVqeFhk?= =?utf-8?B?SGJwYmZLcFl2V1lPSGxkN1Z3SGdnQ0sxQm8wOERCTmRDWitDS3FScEo3d3B4?= =?utf-8?B?akQrTUY4cE1SWUhlS0t3TlVwT1M2aGRBMHN1UW0rZC9lV01ad0lnaUk3ekYy?= =?utf-8?B?VEJHQzJ6SzlmZ0FrdFcrZWlzTmRRZXE5U0p6MFA3QWpsUTNoWm8rYitoaUNn?= =?utf-8?B?VkJyM2FEVTV5WTNwT2tPbThWZk1WTXR0cDA4RjEwczNpcmJvbkZIbkppaGtQ?= =?utf-8?B?cTJBbXZWc0YzR1RqM3pJNW5CN0dZZjIwZEJvQVMxY00yK0xCaHlXQWxITERQ?= =?utf-8?B?THdFTjJjNnd1Y2UwVkU4YVpvYVFUQXFHSDJEdnZrRmhyak16NUZybmwzRnBw?= =?utf-8?B?Vnd1V3JKUFl5bW5FZ2FzVmVienRFSGJDd2ZkWXd4MVArV2RiZjNhVCs1UFdk?= =?utf-8?B?WHlFdnlxTFRCRCtlSUV0WnUxbmQ3c0NzdGdSQkRCS0JSM1NvMlpmWTlNY05K?= =?utf-8?B?Y2hBQkhYYUtlanVsUldmR1RYUmg5QWFlV25Vdk40VnVHSURWM2d3bGhDRmlo?= =?utf-8?B?WXRwZ0FoVDNtaDNVaDJRYnZVSmUyQ2VhV2ZKYUt3WkE3TlBqMGdmMFJBeVRa?= =?utf-8?B?UVIrTlBuR1NkUkh6MkNJOTc5amx1ZktmQnJST09oZWtLdVhiVENVL1U5NnNF?= =?utf-8?B?Y0paWlB6VGsvSE1OdzNTRzUvcUNQQjZQMlREOHhzaUQ1eGo0L0JkL1AvTHRT?= =?utf-8?B?QTJJbUNRWDN0NlBoODZkMGVWRjNKK29Uclp6S0tWYW5mUGRiRlA2TWplR2xC?= =?utf-8?B?TmNKcS9IS0Y3ZGh4TnE5a1M4dncvZGZOSy9HK0NVZXVJWUpNWEhTMHR6dlRD?= =?utf-8?B?RFBHSTgwN20xOEdNbHNmYUo1KzZwaVR0WFp1aDRyRjM2K3R0QlNwTDh3TGE1?= =?utf-8?B?VlNwY25qaXlIMUFSeHBNZ1A1cGRYMGZPNzkrc25oYjFmUUp3OWNaejEzUWVK?= =?utf-8?B?aGJTWVdMb1RCdklPVVF5cTNtcXMwK3ZWWFBEZGUwVm45M04xOGZ5dEFYc084?= =?utf-8?B?c29XSEVkd3JxL3RMNDZHdzFLMEUyZ3E0ZmZDRVpmdkRBUGx5RmVNSnN3ZkVs?= =?utf-8?B?ZFA5QTFSZ3pycHNnRVRHMlZMQm9iUVhGRDk1b3ZqMW53Wm9EZFVPaVFMaFZi?= =?utf-8?B?RWNHckhoblRiMy9wN1MxL0tGTTMvckVoRUJsZS9DRXpydVd1dXprS0tjSmFC?= =?utf-8?B?aDhyYy9wK1g2TXB0amVOQVBKQ0NEajVVSlZyZm1BS2hmR0FhS1dBK211UmJw?= =?utf-8?B?Vk5wVHV0TGhKa3pzZzRqRWxEMGp3N3orWHFYTy9VRUtuWE5IbUNONjh5UjA1?= =?utf-8?B?RzZxMDViSDRQVkVIc1dmUm9tZE43TmZLYUxMSzNURDhWdU1McTV6dW91MHVC?= =?utf-8?B?S0RUMjA1S2FEakF6MisrazlFMkM4NDFRTXAvSE1rWEw1cmFoTDhXM3Bta1pM?= =?utf-8?B?ajliTHFOQXV2L3hYOEt3WDJJVjJBRjhWL3l3VzZmZlhFL3BIbWljUlk1UjVT?= =?utf-8?B?WmFqSVZFUVVPWVhIU0d3aUViN2plZEZzbzdiRnlUekM4ZHdybGJ5SGdsbmtr?= =?utf-8?B?VTM2UWhNdTkrL2RiLzcwNHJ5Y08rMnV5d2M0eG5tWFVXQXRQRldXYk5BOVRw?= =?utf-8?B?WHNXNm9BV3YwQ1pEWTA3SkkrdHdlTVc0bVBHY2MrYmhXS0dlU01tK1pMdHpD?= =?utf-8?B?UnowNW1SZmJKWndsZ04wUzZvb0NiVkorcThqL1BnM0FOeFhmbTUyMXNNRjQv?= =?utf-8?B?RFo2Um5HOFpvdTFNL293K1I5aGdIQ1AyOXV0WHlUTlBBZzZqcGN5b3FSTnp2?= =?utf-8?B?MjdNKzBQWlNhNTNjRDBZQ2oxaXcxWitOTWY4K1VrQ1NKWGJTYjV3eWdxcnAw?= =?utf-8?B?ZjJJR1Rra013RzNoK215LzVmeEV2QnFuT2JneGFicDBkZnBueFhYMmhlZTBX?= =?utf-8?B?bUhreHFPWTlqQ1dHYTE1MW5ZYnhPSU93cFF4ZWV6STZ3Mk9kRFZGQWpjL3Fh?= =?utf-8?Q?zck2tvWpXS6U0KvMSTZwRfh6q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10af31ba-96df-42e9-b222-08db0ea9a9f5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:36:46.8176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TkCEiXij+4X7JVXMN/C29unxYb4bhGfUy66Hfs1klV0X29TtmSRJ8xJQ69IGUJdmIlWfIKiovBSdnlTY4A9zeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > To be able to use cpu_has_svm/vmx_* macros in common code without enclosing Both in the title and here the spelling you use made me first think that you talk about "cpu_has_svm". May I suggest you follow what we typically do and use "cpu_has_{svm,vmx}_*" instead in such a case? However, the title may want changing anyway: > --- a/xen/arch/x86/include/asm/hvm/svm/svm.h > +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h > @@ -80,6 +80,7 @@ extern u32 svm_feature_flags; > #define SVM_FEATURE_SSS 19 /* NPT Supervisor Shadow Stacks */ > #define SVM_FEATURE_SPEC_CTRL 20 /* MSR_SPEC_CTRL virtualisation */ > > +#ifdef CONFIG_AMD_SVM > #define cpu_has_svm_feature(f) (svm_feature_flags & (1u << (f))) Why don't you simply provide a 2nd form of this one macro, leaving all others alone? > --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > @@ -294,6 +294,7 @@ extern u64 vmx_ept_vpid_cap; > > #define VMX_TSC_MULTIPLIER_MAX 0xffffffffffffffffULL > > +#ifdef CONFIG_INTEL_VMX > #define cpu_has_wbinvd_exiting \ > (vmx_secondary_exec_control & SECONDARY_EXEC_WBINVD_EXITING) > #define cpu_has_vmx_virtualize_apic_accesses \ > @@ -352,6 +353,36 @@ extern u64 vmx_ept_vpid_cap; > (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) > #define cpu_has_vmx_notify_vm_exiting \ > (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) > +#else > +#define cpu_has_wbinvd_exiting false > +#define cpu_has_vmx_virtualize_apic_accesses false > +#define cpu_has_vmx_tpr_shadow false > +#define cpu_has_vmx_vnmi false > +#define cpu_has_vmx_msr_bitmap false > +#define cpu_has_vmx_secondary_exec_control false > +#define cpu_has_vmx_ept false > +#define cpu_has_vmx_dt_exiting false > +#define cpu_has_vmx_vpid false > +#define cpu_has_monitor_trap_flag false > +#define cpu_has_vmx_pat false > +#define cpu_has_vmx_efer false > +#define cpu_has_vmx_unrestricted_guest false > +#define vmx_unrestricted_guest(v) false > +#define cpu_has_vmx_ple false > +#define cpu_has_vmx_apic_reg_virt false > +#define cpu_has_vmx_virtual_intr_delivery false > +#define cpu_has_vmx_virtualize_x2apic_mode false > +#define cpu_has_vmx_posted_intr_processing false > +#define cpu_has_vmx_vmcs_shadowing false > +#define cpu_has_vmx_vmfunc false > +#define cpu_has_vmx_virt_exceptions false > +#define cpu_has_vmx_pml false > +#define cpu_has_vmx_mpx false > +#define cpu_has_vmx_xsaves false > +#define cpu_has_vmx_tsc_scaling false > +#define cpu_has_vmx_bus_lock_detection false > +#define cpu_has_vmx_notify_vm_exiting false > +#endif /* CONFIG_INTEL_VMX */ For VMX you first of all want to separate out vmx_unrestricted_guest(v). Maybe we can even get away without a 2nd form. Then I think it would be much neater a change if, like we have for SVM, a couple (three I think) helper macros were introduced, which then is all that needs providing a 2nd form for. (Both steps may want doing in separate, prereq patches.) > @@ -374,8 +405,12 @@ extern u64 vmx_ept_vpid_cap; > #define VMX_BASIC_DEFAULT1_ZERO (1ULL << 55) > > extern u64 vmx_basic_msr; > +#ifdef CONFIG_INTEL_VMX > #define cpu_has_vmx_ins_outs_instr_info \ > (!!(vmx_basic_msr & VMX_BASIC_INS_OUT_INFO)) > +#else > +#define cpu_has_vmx_ins_outs_instr_info false > +#endif /* CONFIG_INTEL_VMX */ I don't think you need an alternative here - it's used solely in VMX code. If one wanted to this could even be moved to vmcs.c. > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -289,6 +289,7 @@ typedef union cr_access_qual { > > extern uint8_t posted_intr_vector; > > +#ifdef CONFIG_INTEL_VMX > #define cpu_has_vmx_ept_exec_only_supported \ > (vmx_ept_vpid_cap & VMX_EPT_EXEC_ONLY_SUPPORTED) > > @@ -301,6 +302,17 @@ extern uint8_t posted_intr_vector; > #define cpu_has_vmx_ept_ad (vmx_ept_vpid_cap & VMX_EPT_AD_BIT) > #define cpu_has_vmx_ept_invept_single_context \ > (vmx_ept_vpid_cap & VMX_EPT_INVEPT_SINGLE_CONTEXT) > +#else > +#define cpu_has_vmx_ept_exec_only_supported false > + > +#define cpu_has_vmx_ept_wl4_supported false > +#define cpu_has_vmx_ept_mt_uc false > +#define cpu_has_vmx_ept_mt_wb false > +#define cpu_has_vmx_ept_2mb false > +#define cpu_has_vmx_ept_1gb false > +#define cpu_has_vmx_ept_ad false > +#define cpu_has_vmx_ept_invept_single_context false > +#endif /* CONFIG_INTEL_VMX */ Same suggestion for introducing a helper macro here, which would then also be usable ... > @@ -310,12 +322,18 @@ extern uint8_t posted_intr_vector; > #define INVEPT_SINGLE_CONTEXT 1 > #define INVEPT_ALL_CONTEXT 2 > > +#ifdef CONFIG_INTEL_VMX > #define cpu_has_vmx_vpid_invvpid_individual_addr \ > (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) > #define cpu_has_vmx_vpid_invvpid_single_context \ > (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT) > #define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ > (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) > +#else > +#define cpu_has_vmx_vpid_invvpid_individual_addr false > +#define cpu_has_vmx_vpid_invvpid_single_context false > +#define cpu_has_vmx_vpid_invvpid_single_context_retaining_global false > +#endif /* CONFIG_INTEL_VMX */ ... here. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:41:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495373.765719 (Exim 4.92) (envelope-from ) id 1pRyMy-0004Bz-BK; Tue, 14 Feb 2023 16:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495373.765719; Tue, 14 Feb 2023 16:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyMy-0004Bs-8J; Tue, 14 Feb 2023 16:41:28 +0000 Received: by outflank-mailman (input) for mailman id 495373; Tue, 14 Feb 2023 16:41:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyMx-0004Bh-03 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:41:27 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bcf5684-ac86-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:41:25 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id y1so16321069wru.2 for ; Tue, 14 Feb 2023 08:41:25 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id f5-20020adff445000000b002c53f5b13f9sm13280125wrp.0.2023.02.14.08.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 08:41:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bcf5684-ac86-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5djcSKT/Rs3aPHyeCmFl4MNhpags+8Pjabq1ljGUlMQ=; b=B/I/ZWN939Gh7m3AJcODPyyHXLaEBuYwmhcJcVEewnZgO5xcBG1x1+HxQhacFNkUBh jlRq9GVHR20BRKEZY3ji7YV71teZHPsb43S1y5hBj4j2chvW6FoxOX8KIF1iCzf/7jGF zX0B2qZBetsgHuTLkHSMNfi1pjvkI87mObMz6TysHWwfEwcVrVkqwP0ExprGTa4H6DNG FwIkZ1nObgvVu5uTxD7WcApYknrHFJLzBrnfymip8A88XZ4GxET+odG0BPURrqevOSbt LHX7E7WEenoNMscy2W81Vk2qIZDe91XONs57hhEroRAO8eTcpPfsVLpYp69ql5D6k8FQ hWcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5djcSKT/Rs3aPHyeCmFl4MNhpags+8Pjabq1ljGUlMQ=; b=AOFPUUnvzOeXM/LAk9tZUShkR9u+BfN7WdgYGWBkzOdJdJngWzExnNtXEVw2Qs3QVX DfGdaySYMQklwPeJIURp+8hlNZ411LKNxGJsJgXODA55U4jdNfw1bGCGQ9e2A9iJhnhx RfDo3ebzT6b9BFP4oX41m3tJ1HAlZK1MnV4GZ7iYYE6ozhwPURVyi3fUlRmmVnfHxUj5 qO0vpt42TwOHRqPttodEZb0+wZyLhH0JBVlTU+Q3RtGOGTAknFLp4hwuV4KXkRHFpdte cqQVtERmPhxZHU/HhqtKJrOMLCt5nmOj+S4Wgml+NQrZq5G2dzOo4xh6wC8Zb1FlotIJ k01g== X-Gm-Message-State: AO0yUKW1QfwZReGP3w7fZDI0Bu6RLGXEDZTbBU7uCuPfzqmEGg1GEKlp FCj7VuITgx3Q8l/F4pvccsY= X-Google-Smtp-Source: AK7set+jhx9wrOieIaTVbz2rn7VOqLClRhEDr3V1FUmfkaseyhZ30SNTi3ZovsmrdIIal34h25tkpQ== X-Received: by 2002:a5d:518b:0:b0:2c5:585e:334f with SMTP id k11-20020a5d518b000000b002c5585e334fmr2565201wrv.41.1676392884971; Tue, 14 Feb 2023 08:41:24 -0800 (PST) Message-ID: <84faf6f53ad8e5cf3e1c8b20afef1b660c5ae7e5.camel@gmail.com> Subject: Re: [PATCH v1 3/4] xen/x86: switch x86 to use generic implemetation of bug.h From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 14 Feb 2023 18:41:23 +0200 In-Reply-To: <3dc6cdd4-30fe-b66a-bce3-44e798576fc4@suse.com> References: <3dc6cdd4-30fe-b66a-bce3-44e798576fc4@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-13 at 14:10 +0100, Jan Beulich wrote: > On 03.02.2023 18:05, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko >=20 > Is there anything keeping x86 from also using the generic > do_bug_frame()? > If not, switching over would then likely mean no need for the new > Kconfig > control. >=20 Actually, it seems that it is possible to re-use bug_frame in x86 code too. Looking at lines 1188 - 1264 [1] they are mostly the same [2] except for updating of eip [3], processing of BUGFRAME_bug - was added debugger_trap_fatal [4] and multiple usages of fixup_exception_return() [5]. But all this stuff can be processed outside do_bug_frame() function... [1] https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86= /traps.c#L1188 [2] https://gitlab.com/xen-project/people/olkur/xen/-/blob/generic-bug-h/xen/co= mmon/bug.c#L10 [3]https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/= x86/traps.c#L1211 [4] https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86= /traps.c#L1244 [5] https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86= /traps.c#L1217 > Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:44:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:44:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495379.765729 (Exim 4.92) (envelope-from ) id 1pRyPZ-0004ld-Nq; Tue, 14 Feb 2023 16:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495379.765729; Tue, 14 Feb 2023 16:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyPZ-0004lW-LI; Tue, 14 Feb 2023 16:44:09 +0000 Received: by outflank-mailman (input) for mailman id 495379; Tue, 14 Feb 2023 16:44:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyPY-0004lQ-BF for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:44:08 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb8259b0-ac86-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:44:06 +0100 (CET) Received: by mail-wm1-x335.google.com with SMTP id f47-20020a05600c492f00b003dc584a7b7eso14108915wmp.3 for ; Tue, 14 Feb 2023 08:44:05 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id m23-20020a7bca57000000b003de8a1b06c0sm20662358wml.7.2023.02.14.08.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 08:44:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb8259b0-ac86-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IMpPHBh3R3g3y8/gU7zKudc6y8r/3JyW8gvF10nqUy8=; b=MdWMF0Gmqw71fx8shWoCJi8oiIXDP4xCCZRTorMAxLtHG8vy6nCQra976Mw3c7vn6L XLpefa/W1jhhfHno3jzritZ6S1y5/UHrq+ea2JiyLKXjfBPZX0gNA0gchHf3wrob/SIK /keViZitjtLzRfTaK8L4/xfddKCZD7LF2Y4otj8yXShunSt8PSr5BsOnCwooVQynvL1M PvWgrdkQ7Wq3a4EZmEWvecK/4NPBA2QyLknfscK2y990B+3Xva9CYx1yI70FC7Z4R5Vx PnhkrQNagudV96dWg9VOuDFRadcMEaQANatm9kZ5/Xi7z+UmVcjao5GXp4s10J1apI7D XVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IMpPHBh3R3g3y8/gU7zKudc6y8r/3JyW8gvF10nqUy8=; b=r4U4ZIaBgjw9KKuv4rc6GXSbNolnpi3G9MTzLaUfwUzOxeSVheW1cKoCDFS5AoDRCQ bzHOiBc26ZqxEMxxDD5ApQ3WwwSnpeL3oYHLX4AgAMfccxUXimlUTsp2g0Br3XhBJiMM NC507S3zuIOkzH6j851o4hY5Sm7IcuQk1sgeAcSYgACLr/plerl/KLD5vNajX7nhjZqz 3geO8pOPu7Nbprr/wnPNn80QbSM1V7Hh6ZfL5R2/zBH+E9vcvzW9lmRROHxEMypbztmO v3PEEVMaMKqkFjZgZo+FPwVaPy+ZLm/fNZgRuQpJhbGGvUWK1KruaAEE4yVircWE6CXr 4Vzg== X-Gm-Message-State: AO0yUKVjqPYygCzWAmqD8AuKw+Xkag6Ho90oN6V0ee8MjDVCOmeZXaYr 4Z+u1xE441RQn/oY/Cf1xO4= X-Google-Smtp-Source: AK7set9niPDnlTjED/fbIVOIZ48TSWwlen+UwNsoe6nShyBFVMQId86KwaTk7uceK9L85IdCP6tnvA== X-Received: by 2002:a05:600c:3318:b0:3dc:5823:d6c0 with SMTP id q24-20020a05600c331800b003dc5823d6c0mr2720387wmp.6.1676393045420; Tue, 14 Feb 2023 08:44:05 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 4/4] xen: change to From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 14 Feb 2023 18:44:03 +0200 In-Reply-To: References: <5a427934949e3b0cf6026c8ad6c62e37e5250ca7.1675441720.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-13 at 14:13 +0100, Jan Beulich wrote: > On 03.02.2023 18:05, Oleksii Kurochko wrote: > > Since the generic version of bug.h stuff was introduced it > > is necessary to rename all uses of to > >=20 > > Signed-off-by: Oleksii Kurochko >=20 > Doesn't this change need to come ahead of at least what currently is > patch 3? > Or else why do you say "necessary" (I take this to mean the build > otherwise > is broken)? If the build works after patch 3, the change here may > want to be > drop the unnecessary asm/bug.h includes instead. >=20 I'll double-check if the build works after patch 3 and fix the comment. Thanks for the comment. > Jan ~Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:46:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495385.765741 (Exim 4.92) (envelope-from ) id 1pRyS9-0005Pb-4B; Tue, 14 Feb 2023 16:46:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495385.765741; Tue, 14 Feb 2023 16:46:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyS9-0005PU-1N; Tue, 14 Feb 2023 16:46:49 +0000 Received: by outflank-mailman (input) for mailman id 495385; Tue, 14 Feb 2023 16:46:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyS7-0005OZ-27 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:46:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1a::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a9fc74f-ac87-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 17:46:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8990.eurprd04.prod.outlook.com (2603:10a6:102:20d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:46:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:46:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a9fc74f-ac87-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ii0KvDSsOTp2a2sBR2pNakvk/ovygZFXs+p4UKKBuyVzHvAdzkU2ZNuro0cGAVj5pm6tv3rmMAy0OZThl6B0xCpSIBp8c7yVKYgwWhSYZu8MV/l/V9gN7WYPTGsGRb6aZMFRChI/LH5Q5db0jCibX6VOCDc60FYr8CozwwuaLDTuzuGtDBiIsZT6t/8QLIE2eUmlOhfZAfHDYtIkaFmJ+txGSj8BgvtwJNmxGw3/GPpvzGWHlUq6p+c60Ir5EeYE3ePu27eVRxJdQ2NnARZMHP6Mbsgzm1tJjVBtWvKBmKngWdA9ZbjJZg72eeB1i1S19C6CTR8Ruhc1wBVNZgZZ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJe1hIToLj3KLLqgTrfdF5UHgVvY/k7bIj2OVJ5I2PA=; b=EibdsFCmEDTjeMLPLwQL8aRFaLf/i7MD1kWst4B4WyM6qZJxpej9LGutdIVZHMiQQKgxCjUCDtZunErT1C1DMhOWJ+oTnkMFzX/SnytLgwM3XqAieHs65u63kLvEaiE5W00Pdn6iCbt/jMoQ5ofHTSyMJ1nqEmMv9WyKsjn1TKV5N2ca07YWR3yYSaWlp0RuACq949wbDF2hB47MmWQ1OBnhsvwl2DiZNN749Wn5DObguPgJU+RsuNW9/PmV/LUDd/uJaDYF6hneA1IQtLcRI5g/yX88yPOCa/SFhTJpp8fswm7U/Q2ut13Ssse0ZQv/XFTvqFJzHiKSgLK9+vIumA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJe1hIToLj3KLLqgTrfdF5UHgVvY/k7bIj2OVJ5I2PA=; b=xgKWDo1oQgT+zwnYwDdP9vaY5U6z0rIEb92KFm1qflWOFbEKmqiLNciZGGps7Yl4B0IIjyRK4y2vb1jMrfKLERiw1Fo2bx0NY7kxwKqS5XEMj3TMsTUYS6N+0I1Hhoe4RMt+eM1czajLt/UsWBPEDFRXFoXS8h7xD/B9B8ojQvDcI55lSp70T4H5c0qTdcgItKHpaQIKs6fqfRQCm1GnfZjFvOkfx19r5bYNYUf5Cl3/UNDNrSRRubutg5xo3BpRdjsrgKoGqeynvjlbClFLxfNwnnezCOfJKTrYFCZ/8mPFAkVmyf7kdBss520l7sklwgQOe89qVkVrq+FQa/YNFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <883a4563-9a37-eb17-6e91-03216f336e99@suse.com> Date: Tue, 14 Feb 2023 17:46:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC 09/10] x86/ioreq: guard VIO_realmode_completion with INTEL_VMX Content-Language: en-US To: Xenia Ragiadakou Cc: Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-10-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230213145751.1047236-10-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8990:EE_ X-MS-Office365-Filtering-Correlation-Id: 21801024-76fc-4684-cfba-08db0eab0dd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cubs679a0WTg5QhgvT+xEXEnvaTHby36KU7OB2apDmg1qWUVZdiOwQUTpwYxGgizSNkkPifUb2rZPjaYHm7cvuIUJJ0T6wwJrg2M+wASt327Wuh67aXmQFT9ca7LxDsZyuG2TIZnd3UjYefWsTKoFovJ+ISuQPBXw2CIb+z6yCxDrlUjsEMXqXC/ZY9+jUlIOg/sl8//MVAosVUftyNrBGKabrdFyMoYnOPZn5wLyJo+VckPypriEZlK6hpi2RD1mJWlxJF2PLRQx/C6Cy0GoSQKDYgC00Eg77XFa8inkES7eIHRiu9FNdsEbR3c4AjMtwHc9E35+flqK7nRoxkfrlDzujpeHFSia3EEj1jpM65m334u2TnK9BVVCRYHYYtqH8NnmLygYOlnFRv1k/ensj2pXZvmeKRtwAyBIDwgvpl6+yWNSfDkH6ttjFt9NDDrwkEcVEyUsR+D/u2dq3jHlgW5/G+C0OKrQh6HGv69xMMeUSK/sGewovcNyhDDtOO7GZFFFKcWXdhoCqLEqdGBLfYK/JgSoRui8cSLVtLf7F34h+Rzw+FLqWBDDB8bIFg+DJROXMl4lT8iVHdjNsCYwt0rw5Vs2188aGBxo9o5AWOX5SUY+d3z07qxDqdiNF6VZDLOqsaCarI6i8LU3ECcZVpHbVqtTYJodjYQdzhsDCrsG+Zxch4tzeVRrIo26D6TShlS4e6a/UiZLaGSSwMTrL4rKHqG6ckDvuE+Z/qMcKI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199018)(86362001)(31696002)(36756003)(8676002)(54906003)(316002)(66946007)(4326008)(2906002)(6486002)(478600001)(2616005)(66556008)(6666004)(41300700001)(6916009)(8936002)(5660300002)(66476007)(38100700002)(6506007)(26005)(53546011)(6512007)(186003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUtmMkVoN2paQm9EOTc1VTNNUlBsdnJmclM4dGhOOU1pdDlBaFNTb2NOdXg4?= =?utf-8?B?RkRvY3JLU3FYdUF2c1NXUjRrTi9xVXFrMXB1ODhLaUpNTnlCQjhNZ3pFUTZV?= =?utf-8?B?Qk8xN3ZVSXR0bHljOFU1N3VnVHlmVFRTREVxUHhSTGl6TFlaelFLRlFTdlBP?= =?utf-8?B?eFluQXRaMUhybmRzMDZONFp3MHZ4Qy9NSWJNSHZ4aDViN1NmOWt0Mlcrc1FG?= =?utf-8?B?MFovMDBZck9tZWMrN2U2UURoNk1FNDZNWC9EeTlnaDJ0aWIvTDMvRk5IZ3Ny?= =?utf-8?B?R2xuNkRnbTF4aXczcDFzWnd6Y0hiMTJwY0ZzZ3ErVUZBZ3RLNmZFUklCZmdm?= =?utf-8?B?YUxMdk5POXh1Y2NKaVhWWEhlSmZwaXduN3BhdHl5UHgzUkFaSUo3c014em9n?= =?utf-8?B?Z3RQbWpJQjVvUE55NEZONk1rRnptQk9wK1lhVk8zVnVGUTNxcjdYSlpOYW15?= =?utf-8?B?YjhOU1BJeTZlZ05TRXlEeHdhU3pabi9WY21aSEtSbW5kaXVzcVc3b3BlZWVa?= =?utf-8?B?ZWc3QTRYQlhrU3UvM3NzZjRZakV0OXJDYTBYajk1V3Z5a2U2TWlJNE5mVlI4?= =?utf-8?B?cGRCWm1zOGdwWktLRlYwQlJjbnBOVUZNWG9DS3dNYXdhVHZEK1ZhOVFKUlk0?= =?utf-8?B?TVpGUGdhSkNXNmduRnFPb1VlN0xobU1PSmlmQkxmT3MvNTZYVmFPT25QdjRD?= =?utf-8?B?WHZSZDZva0xMbDZpa2NtS3hoZXZZaTJWYTN2cEtBL0ZpOTlnRmVHcTA0aVhq?= =?utf-8?B?TGNsYlRVTkFJbVJNK1BvUmtPZjlxK05JdWQzclpPN3JVb3BwK01VSERwZ2Qv?= =?utf-8?B?c0pCcDBhK3gvWG90S1VIMjlueEx1a3JaR2VKSzNFa1h2MVU1Uk4vbmQvSFlx?= =?utf-8?B?MzNqSTZMNGFjTWxUdW9MaXpNdTZ0MTlEM29raXdkRStNOFZtMFJuUGZ1R3ZX?= =?utf-8?B?ck0xa3dyQ2hDSjdZR1Y5VCtjbk5acXlyRE0wOHVxZ29yUjd6dGNGMGZxVDZv?= =?utf-8?B?enNLTmYvMlpySTZNdHVodkVLNkViTEphNWRxU1VKS0x1K1gyRnhPU2RrRThK?= =?utf-8?B?TmlvSkhlaFhPMkJ6ZW5rdUFPbHZXckNkWFpIenB5NURpQVB3QmhUWHREODRw?= =?utf-8?B?T2ZvL1EzY1hoL3kzRzlxQ0NER2lvV04rS2NHT3ROTDc0V3hhL01hOTdiMEN4?= =?utf-8?B?OHI3d2JYWjNxaitGZDlpTGRMM2FpVWhxenVLSmNXZDBmMlNyZFdWTUVNNHRz?= =?utf-8?B?VVpXN2xaVHNwRGIyOFh3VWNpVllnQkhDdTlzcmdOMHJVVFhLS1RjREpZdVJD?= =?utf-8?B?SEtDT3hGRUFSeitJVm94NXlPb0o0amxvVG8zVy91OC9rbktabkJOS3N3MStv?= =?utf-8?B?THZ4ZEUzaDVWTVhtMzIwZDdTYlgzc2szdUUvYWVsUTVVc2pVWWlybi85TUNQ?= =?utf-8?B?ejdYdkl4SXhJbys5WE5sWVRxdlVVWXI4elZOaWNTdnNJUEtvSVkxZDY5L0ZM?= =?utf-8?B?TlZXZmNESVZndW0rZzJqd1ZvQTUyZ1ZHWGZROGRxSVcxSGo3VGpOVThMTUVv?= =?utf-8?B?bldpOHVUM3FJSk83b3IxcE1MODViYm1ZK1kyQXB2TXJzY0NxWHhMQUcwWG9a?= =?utf-8?B?Q01RdXR6TERMMHVBcUZEbkpQWDlmNjdzTGFKQ1NiSnBLNHNDbCtIVVQyUndM?= =?utf-8?B?NmRKRGdaUHZidWRSNjFDWmN2RjVxOGFYajlERjI2VlhUblJVTnUvTlY3QUxG?= =?utf-8?B?MUE5R2tBRCtkYVl0c2NkdUIyWGhsVi9Tb0tmZ3l0SWExcC9GdmlSUHc2YnEz?= =?utf-8?B?K1prYUIzY3R0NkNRbkc3U3dmSWtTTzBjai9YTE56UThsWlNsbUFHZWJQWlhP?= =?utf-8?B?QTRhK1dEbGtVV3VNNE8razRRaFU1QzNhMlJ6N0dGeUE3amFGaG8rVnlCQnJr?= =?utf-8?B?MU1SQ3VuTks5cUNRaERnalI5cHpMSHBGLzFsNm9QNlZIL1ZUcnZ6RjNWZkU1?= =?utf-8?B?RzJZYlIwTUo4ai9EaGpLRTh0dXcyL2MzQStQUm9ieTJiYWpRa0E3Umg4Q0Zq?= =?utf-8?B?ZHJldFY4QUt1dVJucGUxU0tjcGlmQ1lzR09EVXJUUmtXOGVaQlExNS9nbTRK?= =?utf-8?Q?OG+L29CX1D6KzvNlOCHeZkYsR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21801024-76fc-4684-cfba-08db0eab0dd2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:46:43.8735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G6lVMKoeZZdwIJ1YgGph0jKugfUB6vKgySzomOgTfRjC7/MbQf9XIBpo7T+BhPPwkcCRqWuTCtRc1qTcMDbPRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8990 On 13.02.2023 15:57, Xenia Ragiadakou wrote: > VIO_realmode_completion is specific to vmx realmode, so guard the completion > handling code with INTEL_VMX. While it means slightly bigger a code change, personally I'd prefer if VIO_realmode_completion simply didn't exist as enumerator when !VMX. Besides ... > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -44,6 +44,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) > { > switch ( completion ) > { > +#ifdef CONFIG_INTEL_VMX > case VIO_realmode_completion: > { > struct hvm_emulate_ctxt ctxt; > @@ -54,6 +55,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) > > break; > } > +#endif ... this use there's exactly one further one which would need #ifdef-ing. I think that's tolerable. Thinking further (not necessarily for you to carry out) the x86 version is identical to Arm's when !VMX, so it would look better to me if the entire x86 function became conditional, the Arm one was dropped, and common/ioreq.c provided a fallback for the case where no arch one exists. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:53:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:53:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495392.765752 (Exim 4.92) (envelope-from ) id 1pRyY7-00077W-PQ; Tue, 14 Feb 2023 16:52:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495392.765752; Tue, 14 Feb 2023 16:52:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyY7-00077P-M3; Tue, 14 Feb 2023 16:52:59 +0000 Received: by outflank-mailman (input) for mailman id 495392; Tue, 14 Feb 2023 16:52:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyY7-00077J-6K for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:52:59 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06f9b3a4-ac88-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:52:55 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id hx15so41587872ejc.11 for ; Tue, 14 Feb 2023 08:52:55 -0800 (PST) Received: from [192.168.67.143] ([62.74.15.167]) by smtp.gmail.com with ESMTPSA id le3-20020a170907170300b0087be1055f83sm8434006ejc.206.2023.02.14.08.52.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 08:52:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06f9b3a4-ac88-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+auUcu4xd0KJc072de5A24JuTtsRCj3j5PFLESmXT+k=; b=QVHVQvipkuB7jmtW8DAug2GwtZ58YqlpssFt63fsJtrubR1YojPOgi+ewNkMOYlKyr VMQ8AvwYASPjTYF6SnwittveDaQRQX7V1y78RR3vIlZcXRJa1Xfv7Q22TvAUJ1IvuMdG r6ohemC6zyKnccURfohSfRJbIiOWFDhTO4X6KuwG2Yz3TKnDCWnpnj633MEU/8UUbLHE zkV/bc6Nv/+cwADDLV1D66MZQ5aCL38apbINUh5ZR34X0edfmh6kTG8STyEW2Jo3LWU7 rC7Yl8qo4SpIDIBm/4ZkmtgOD4WC4J+XLiyEcEUl9CfZsg1MhT8M7iLGRh+cUYXff7A+ Oy2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+auUcu4xd0KJc072de5A24JuTtsRCj3j5PFLESmXT+k=; b=cFRP7fwS0ODYpxN0sN4aeaoffw12Iwjzf4XNjvU6Azb10itJedeDktrwvpzh8fvH2E Ld6tje9HukLwI4EXoNqVhIVg4tceoGLQ1s3jEmfWjj6cSm2KGO3K0uvfVoprlEJlaQuY mJCcLgJDFLe8kjhuljEjAl4Qwzavo18dsS9KbdgsmCy1Ks/T2LkoIomZiVimIhQB5U4c bynk40tCuwXnluX3DxY/GVkhZvULYMkELnBfwtURybJyEak4MaHoKRaWHJ86SgvXlspb rcgQ33UExKFC0uRb/bAfZIGxoZBYXfXXbQyD9oeRSBvIOzT8t4ohYD+jeI8is1hw7UEG iIBA== X-Gm-Message-State: AO0yUKUvMjYyZg7bJf0E/5/lW17uQHtEYwayQOXA0zrVugcOopvzmJyM nH2/3IgKQM2D1R7FxW8xU8g= X-Google-Smtp-Source: AK7set/Mu6ZpugzeHDSvAPR6Kjf1QcWiOV7Zm4xGqpZmaBnGmGzR+FPpvSdlwuP7k3QV6yUsdy2eAA== X-Received: by 2002:a17:906:6015:b0:889:7781:f62e with SMTP id o21-20020a170906601500b008897781f62emr3462114ejj.22.1676393574685; Tue, 14 Feb 2023 08:52:54 -0800 (PST) Message-ID: Date: Tue, 14 Feb 2023 18:52:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC 08/10] x86: wire cpu_has_svm/vmx_* to false when svm/vmx not enabled Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-9-burzalodowa@gmail.com> <6ddf5aa2-8bb2-9831-fdc6-833bb4d259f7@suse.com> From: Xenia Ragiadakou In-Reply-To: <6ddf5aa2-8bb2-9831-fdc6-833bb4d259f7@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/23 18:36, Jan Beulich wrote: > On 13.02.2023 15:57, Xenia Ragiadakou wrote: >> To be able to use cpu_has_svm/vmx_* macros in common code without enclosing > > Both in the title and here the spelling you use made me first think that > you talk about "cpu_has_svm". May I suggest you follow what we typically > do and use "cpu_has_{svm,vmx}_*" instead in such a case? However, the > title may want changing anyway: Ok, I will use the conventional way from now on. > >> --- a/xen/arch/x86/include/asm/hvm/svm/svm.h >> +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h >> @@ -80,6 +80,7 @@ extern u32 svm_feature_flags; >> #define SVM_FEATURE_SSS 19 /* NPT Supervisor Shadow Stacks */ >> #define SVM_FEATURE_SPEC_CTRL 20 /* MSR_SPEC_CTRL virtualisation */ >> >> +#ifdef CONFIG_AMD_SVM >> #define cpu_has_svm_feature(f) (svm_feature_flags & (1u << (f))) > > Why don't you simply provide a 2nd form of this one macro, leaving all > others alone? You are right. That way there will be less changes. > >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >> @@ -294,6 +294,7 @@ extern u64 vmx_ept_vpid_cap; >> >> #define VMX_TSC_MULTIPLIER_MAX 0xffffffffffffffffULL >> >> +#ifdef CONFIG_INTEL_VMX >> #define cpu_has_wbinvd_exiting \ >> (vmx_secondary_exec_control & SECONDARY_EXEC_WBINVD_EXITING) >> #define cpu_has_vmx_virtualize_apic_accesses \ >> @@ -352,6 +353,36 @@ extern u64 vmx_ept_vpid_cap; >> (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) >> #define cpu_has_vmx_notify_vm_exiting \ >> (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) >> +#else >> +#define cpu_has_wbinvd_exiting false >> +#define cpu_has_vmx_virtualize_apic_accesses false >> +#define cpu_has_vmx_tpr_shadow false >> +#define cpu_has_vmx_vnmi false >> +#define cpu_has_vmx_msr_bitmap false >> +#define cpu_has_vmx_secondary_exec_control false >> +#define cpu_has_vmx_ept false >> +#define cpu_has_vmx_dt_exiting false >> +#define cpu_has_vmx_vpid false >> +#define cpu_has_monitor_trap_flag false >> +#define cpu_has_vmx_pat false >> +#define cpu_has_vmx_efer false >> +#define cpu_has_vmx_unrestricted_guest false >> +#define vmx_unrestricted_guest(v) false >> +#define cpu_has_vmx_ple false >> +#define cpu_has_vmx_apic_reg_virt false >> +#define cpu_has_vmx_virtual_intr_delivery false >> +#define cpu_has_vmx_virtualize_x2apic_mode false >> +#define cpu_has_vmx_posted_intr_processing false >> +#define cpu_has_vmx_vmcs_shadowing false >> +#define cpu_has_vmx_vmfunc false >> +#define cpu_has_vmx_virt_exceptions false >> +#define cpu_has_vmx_pml false >> +#define cpu_has_vmx_mpx false >> +#define cpu_has_vmx_xsaves false >> +#define cpu_has_vmx_tsc_scaling false >> +#define cpu_has_vmx_bus_lock_detection false >> +#define cpu_has_vmx_notify_vm_exiting false >> +#endif /* CONFIG_INTEL_VMX */ > > For VMX you first of all want to separate out vmx_unrestricted_guest(v). > Maybe we can even get away without a 2nd form. Then I think it would be > much neater a change if, like we have for SVM, a couple (three I think) > helper macros were introduced, which then is all that needs providing a > 2nd form for. (Both steps may want doing in separate, prereq patches.) Ok will do. > >> @@ -374,8 +405,12 @@ extern u64 vmx_ept_vpid_cap; >> #define VMX_BASIC_DEFAULT1_ZERO (1ULL << 55) >> >> extern u64 vmx_basic_msr; >> +#ifdef CONFIG_INTEL_VMX >> #define cpu_has_vmx_ins_outs_instr_info \ >> (!!(vmx_basic_msr & VMX_BASIC_INS_OUT_INFO)) >> +#else >> +#define cpu_has_vmx_ins_outs_instr_info false >> +#endif /* CONFIG_INTEL_VMX */ > > I don't think you need an alternative here - it's used solely in VMX > code. If one wanted to this could even be moved to vmcs.c. Ok. I ll take a closer look at this one. > >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> @@ -289,6 +289,7 @@ typedef union cr_access_qual { >> >> extern uint8_t posted_intr_vector; >> >> +#ifdef CONFIG_INTEL_VMX >> #define cpu_has_vmx_ept_exec_only_supported \ >> (vmx_ept_vpid_cap & VMX_EPT_EXEC_ONLY_SUPPORTED) >> >> @@ -301,6 +302,17 @@ extern uint8_t posted_intr_vector; >> #define cpu_has_vmx_ept_ad (vmx_ept_vpid_cap & VMX_EPT_AD_BIT) >> #define cpu_has_vmx_ept_invept_single_context \ >> (vmx_ept_vpid_cap & VMX_EPT_INVEPT_SINGLE_CONTEXT) >> +#else >> +#define cpu_has_vmx_ept_exec_only_supported false >> + >> +#define cpu_has_vmx_ept_wl4_supported false >> +#define cpu_has_vmx_ept_mt_uc false >> +#define cpu_has_vmx_ept_mt_wb false >> +#define cpu_has_vmx_ept_2mb false >> +#define cpu_has_vmx_ept_1gb false >> +#define cpu_has_vmx_ept_ad false >> +#define cpu_has_vmx_ept_invept_single_context false >> +#endif /* CONFIG_INTEL_VMX */ > > Same suggestion for introducing a helper macro here, which would then > also be usable ... > >> @@ -310,12 +322,18 @@ extern uint8_t posted_intr_vector; >> #define INVEPT_SINGLE_CONTEXT 1 >> #define INVEPT_ALL_CONTEXT 2 >> >> +#ifdef CONFIG_INTEL_VMX >> #define cpu_has_vmx_vpid_invvpid_individual_addr \ >> (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) >> #define cpu_has_vmx_vpid_invvpid_single_context \ >> (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT) >> #define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ >> (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) >> +#else >> +#define cpu_has_vmx_vpid_invvpid_individual_addr false >> +#define cpu_has_vmx_vpid_invvpid_single_context false >> +#define cpu_has_vmx_vpid_invvpid_single_context_retaining_global false >> +#endif /* CONFIG_INTEL_VMX */ > > ... here. Thanks. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 14 16:56:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 16:56:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495401.765763 (Exim 4.92) (envelope-from ) id 1pRybG-0007nZ-DW; Tue, 14 Feb 2023 16:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495401.765763; Tue, 14 Feb 2023 16:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRybG-0007nS-AX; Tue, 14 Feb 2023 16:56:14 +0000 Received: by outflank-mailman (input) for mailman id 495401; Tue, 14 Feb 2023 16:56:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRybE-0007nM-Ov for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 16:56:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062d.outbound.protection.outlook.com [2a01:111:f400:7d00::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 767fb51b-ac88-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 17:56:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8113.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 16:56:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 16:55:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 767fb51b-ac88-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ek6CRwTWag4BMm1OlFjejGEIdxKxmeUxF4JfNdjZWHwfG3ACDedPTcohphIxv3JsC+nfaLMqehr1xd/LdxfpfvD2wkyCEp4gpRonuyJ7WZZCnN0JNz6SrzX1ZFy3AVWXOLdEb8ofoZMpL8tOttMqsK+Cfe5AMecA9SqffxkLsNrkJS2ZMg9R3TY5ZBBKXpwIg/cAUs+NqCeEJSr0T1NO6fkhWwljvhv2qKc+zTwo8KjnHl3/F/okbKDW0LGRdi7ESHNONJsaDkI/p4AuLd1ec07z9p4x6Meo+uPC4Wzp0MhwY9DEG5CSMchZtZ5omt3B0DVQumhX8U+iRBsVrjdstA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zk8iQbzQEbnZJK2ZTkoi+kHm2g1qKl1Ss+iKSUroZSU=; b=XZcrJzSey2b1zbjfSyPiapzVfljxxu3VbpKlxAbl1hM8LVcjMW3gYzXIQVtY1tTUkFxZQ3i6Tj9KF/7jsjyjhJ5xx4TtkxFyOtwfMfYBKeU0ZxTQvgQ4/O4IZq4vvfn4pbznf4gWa+WGRZOAijNB2OVG73W2e9W0XljIEnVZQjT3ZuY9dvCZayBG5Va2gT5qiQlxuaGjOd/ZSDTnIAxEH9l+VCENdBnIiHE1vJXzgm/apsPOAdJrV2gUM9/j+WckS4i9UuinqZhLaUCElBfxYYshi26Bid7CX1J1hHNb3QmpxA/ctiZ71BQZZWopawQ4VXWjQyKlF1MjW+c2aBUQUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zk8iQbzQEbnZJK2ZTkoi+kHm2g1qKl1Ss+iKSUroZSU=; b=skj1vEkWyZC0RS8hN4PP5TiM8Ki4DEshPuXOLr+qoXz/CGLpcljw1cKya4Hz5RMtuI45sG/AugcoH8ovpqrxvTJ4my2cKQh0CJHoMZh81zTNWydRB1gT+3GKTCDTMKwlyNr7Z1U3Grljo8Mh44tujKzbKpEWyFnWp1MAuJFljQOoxnvrf3LZsvgqoq3ISH8jWEnKoqq1hRJ6gHxjVpBTn6PFotorSf18xaBznG6Ue4mpcuwsxWKQP40KESulUpRSBGZg6KXyLySIPvNUcfnsaO1Y1GfwUYCb4QcC1WfVUtcvyyyKSxHuin7K1p+twqYS9zFjxyCFJcwOOR7SRKW2dA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> Date: Tue, 14 Feb 2023 17:55:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> From: Jan Beulich In-Reply-To: <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0203.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8113:EE_ X-MS-Office365-Filtering-Correlation-Id: 0080ee65-2aa6-45dd-3188-08db0eac58ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rVwqbmnBmJj2PzXpHkf3bfxG9r95o8dLNldGc2uMjdPgEC2HEMT0Ab/BClzg+iz+1vZzuwKEL98abj3NWOJ4xsJuDMg/Q/1HsmBV6V+7JE2WtISXaeSwAiO7bRTNeZZ6lUW0+gB0s2ltagPx36aUjNt5gydU9Iwob+/07ufAa4HpMDVxJckoz4vxIinPbtvXxGcbRauSei5AQfwtt6/k6oxg/cH6DPnO+4XE0Gh7+U05AInFsVjLh3kP++mmV/q8z0xA5McC0Weabji5SEahdOsOjbi2I1sDlr2hlvNYCzSW4VbM2ckwcsDDWnfq6q8cO014DJ8jI7/aCsVqIHTkBxS3LR6pIcmYxtZON4+SPuJQOV/eHnyi5I4Xzz5pCyysXKSOSUYcUNnQOqdMzYXpIzOYUHl9wBRJzimC7GZaf76A4PHDO+3hSOmdhXEQwVu+sA4aP0iWI0eJMYXrRzT/y6Y4R57Qb2nBiC7Xuh1pF7dxtZKwa9NI+uFyiYwYCg1Zr+GCUD+mlBNCxqtnvw8Qy+gd6n8xPiCfZyVHRhdoSMDuGaxej6O6JcKD6M1oY9B3qYX1+MquAbMclJyINIyOmQrQ2UHAZsq6iIGFmp2EqrLqNXh+FtOY8vT5qv+pIMrki1tqjKpvNGRoQaCJgCjDa7Ckk7cvhwa8hPzoD68FHxl+oS9ha8lBhjubrDNfW36liNocBpxCYuViI+PcqZXzWGbgkw87h73Y7VyU0MhgSBXA1jc9KkSrcYX+PpHMQ98d X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199018)(6486002)(8936002)(478600001)(38100700002)(31686004)(6506007)(53546011)(26005)(6512007)(186003)(2616005)(316002)(6916009)(66556008)(8676002)(4326008)(66476007)(66946007)(54906003)(41300700001)(31696002)(83380400001)(36756003)(5660300002)(86362001)(2906002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmZyUHhaNEVYUndSMjJRd3lzLzJIeFp5eUNFNlJNeFkxUGVNTTFwQ2p0cEtl?= =?utf-8?B?ckRDUlEzZitJV1poR2JQdmpQemZuTGRxWFRPUlpBTmhZSVpzZDBnWEpySWVH?= =?utf-8?B?SFR2dzZGSGJkcWhzaGVib2J5QURwVGtrTTFkeUpGZXZmTnVIQjB5OGJDUGxJ?= =?utf-8?B?Q0plNVZ1TEV1alhoTkhMaFJHRXVWejRSOHI0SnNBV0twYThIMVdZRFZQRWN1?= =?utf-8?B?VUE2bnI2Y1FCVE5qMzhUb2VkL0haa2s5d3VXTWh3eXMxdWNtNXkyaU9FUzV1?= =?utf-8?B?VlQ3N3NVdTBSNGRTb3ZORG1iSVFzMnRmQ3FKSXNwT3ptK0Z4U0h0dDJqazZr?= =?utf-8?B?V01sVkU3V0VkNnhjRzRqM09Lb3Bza0lXejJIYlk2NzhMazQ0Tmw4R0FsbFdx?= =?utf-8?B?ZnhWZDlGeTd2RU95MnA2RFJTMWZJSVpNa0d6ZlNoTjVSZ0JndWtmMFZ3a295?= =?utf-8?B?V0RhdmtJamNrc2dqaS9NWnVIWXZKekVqVkxUR01tai9mWDN1OC9rS1p5cjJa?= =?utf-8?B?am0rdDZHT2Y2dnl6cFhOSkE1eTFrUkRFN3FNR1Z1UFZ4TERuUEtGS0U5R0Zw?= =?utf-8?B?eGRKc25SS3UwcU9lSTZLTWgxYlRxa2pLUE9IV2FYYkx0SWt3ZUFRMTlHSG1h?= =?utf-8?B?SHMycXpHUkhIMWZjbCtRYUJoMkZyaG54ZVpXZXdtcVVjS0F6N2o3UTdYN1Br?= =?utf-8?B?RU0zY1NLZjJDQU5RL2lXWnVXVktaVE5Uc2FEWlNVbGoxL0hHOTN3ajdyZGl6?= =?utf-8?B?dWV4RFVuUVRidXgvQmd5eFplMmNQcXNCMFdyZGduKzB0R0xyZ25lRVNOYXFN?= =?utf-8?B?dFZYdUJLc09Obm1JM3p2N1o3K2VFY1B3NzRiNUZWZ2loSFZBQWI1UGVsVHNs?= =?utf-8?B?SDdSUzE4M2FsN0xtRTFITzFoRTg3OUFPUHJra2hHL2dyOFdHTmJoWFl0Q0FP?= =?utf-8?B?Y0NxQ0JEeG1Cc2pNV0FmZlM1OU1vUU9Ba00vVERjaFNHUHhOQnJ4OVZKRGp0?= =?utf-8?B?WFNsdTRTbVZhOCtTSnJpcFYzcmhoWmRIY200eUY5WkxlOEhpTmZDeGN2c2c1?= =?utf-8?B?ei9XVzRkbVA4Vm1vamErK2NXU2xubW9CSUorYkhlU3pWY2s2MUJkY21TenF1?= =?utf-8?B?TmpoV0ZqdnN2V2NkKzl5TkNCcTdvci8wREZoRldXSk5TcGQ4cjMvTWE1Ymp4?= =?utf-8?B?RHp2ZGVmdG1Sb2FaQTV2c3hROEc3aUVzbmMwdGFoTTNQbDY0RHhhdHZuL0Uy?= =?utf-8?B?S3Z3M3VvMnVCTHNMSG1uUzZBclFZT2RLYTZTbmJidUZtN2hzYkNLSURnUEp1?= =?utf-8?B?UTNYbkxmQVZYYzY0ZWozZEhwbkJaclBKaWtzNnpwMERnVlZDTis0QVArWXNh?= =?utf-8?B?ODRhaXZORVNLdUt1T3kvUXJWYWpvRGo3UHMwTFpwOFY3bHRzYlp3bndlbUs2?= =?utf-8?B?MWVaSklvbTRBcTc4MDRwTXVGcFNQa0YxSmZGNS9EaStSWFB2WmRRYmVzRTk2?= =?utf-8?B?akUyUGdSRHk4QS9vZ2UwSDFiaThwLzJObXpFNzJralo4aTRveU1Za01zVHZr?= =?utf-8?B?bTB4NkNJWndYMy9PWmEySVdrYlpGVUFFZncyOEZRZFhmTEFNS2sxOTBXQXh2?= =?utf-8?B?VldGUXVHQktkb2M0MVY5N2FCdWZZWFd1Z2FOSTZiMkY1UDliOWFEd3ZjMmp1?= =?utf-8?B?THVOOEsxWFlTR1ZiMmlTa2hKSnhDTEx2dVhKQnc5c29VR21qU3FZYUxPRVRo?= =?utf-8?B?ZWtaWlJVanpVZ1R3MDVNUERPcWc2ZWpWSFNHWS9yUVpIUXk5TUVGdkd1cHFi?= =?utf-8?B?YXlMK1B0aDU0WmZRMkQ5NEtMdDN5OUFVVklJMjQ3TTlYc0hpQVphd3ZTcHdI?= =?utf-8?B?d0JKd2s3UWF4bGY5RDlGcWM0RWU3TTVQaVkydDNTZHBzZXc4ZW1EczdQcGRI?= =?utf-8?B?cEw0L1FlOWsva1N2VGE0S2laY2FNT1BRV3IxbGNqcDFDaTBtUU5OYTBlOTRz?= =?utf-8?B?dFVxcXVyWmdwMXBUcXFmR0lEN25DV0NxdWpTakQrRGEyckZQSHJ5NmpVRU16?= =?utf-8?B?bmN4TlJFSnVlNFRTdFB5U0lRNkNNQXRwMTJ6VFpJMTBYbHNWbjdKdXFzNk9n?= =?utf-8?Q?vKxRyEOxknSjY/ieuaUgKD1wK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0080ee65-2aa6-45dd-3188-08db0eac58ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 16:55:59.4166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sIAKkvvB6LqpLJXFXgFba8GGksikvPdRa6ZD4t3Sh7hQM/p8vEXJWzt9YccIvOqMXSp5+RBM5m5GoGrRJtC5Iw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8113 On 14.02.2023 17:22, Oleksii wrote: > On Mon, 2023-02-13 at 13:24 +0100, Jan Beulich wrote: >> On 03.02.2023 18:05, Oleksii Kurochko wrote: >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -92,6 +92,12 @@ config STATIC_MEMORY >>>   >>>           If unsure, say N. >>>   >>> +config GENERIC_DO_BUG_FRAME >>> +       bool >>> +       help >>> +         Generic do_bug_frame() function is needed to handle the >>> type of bug >>> +         frame and print an information about it. >> >> Generally help text for prompt-less functions is not very useful. >> Assuming >> it is put here to inform people actually reading the source file, I'm >> okay >> for it to be left here, but please at least drop the stray "an". I >> also >> think this may want moving up in the file, e.g. ahead of all the >> HAS_* >> controls (which, as you will notice, all have no help text either). >> Plus >> finally how about shorter and more applicable GENERIC_BUG_FRAME - >> after >> all what becomes generic is more than just do_bug_frame()? > Thanks for the comments. I will take them into account. > Right now only do_bug_frame() is expected to be generic. Hmm, do you mean to undo part of what you've done? I didn't think you would. Yet in what you've done so far, the struct an several macros are also generalized. Hence the "DO" in the name is too narrow from my pov. >>> --- /dev/null >>> +++ b/xen/include/xen/bug.h >>> @@ -0,0 +1,127 @@ >>> +#ifndef __XEN_BUG_H__ >>> +#define __XEN_BUG_H__ >>> + >>> +#define BUG_DISP_WIDTH    24 >>> +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>> +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >>> + >>> +#define BUGFRAME_run_fn 0 >>> +#define BUGFRAME_warn   1 >>> +#define BUGFRAME_bug    2 >>> +#define BUGFRAME_assert 3 >>> + >>> +#define BUGFRAME_NR     4 >>> + >>> +#ifndef __ASSEMBLY__ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >> >> Again - please sort headers. >> >>> +#include >>> + >>> +#ifndef BUG_FRAME_STUFF >>> +struct bug_frame { >> >> Please can we have a blank line between the above two ones and then >> similarly >> ahead of the #endif? > Sure. > >> >>> +    signed int loc_disp;    /* Relative address to the bug address >>> */ >>> +    signed int file_disp;   /* Relative address to the filename */ >>> +    signed int msg_disp;    /* Relative address to the predicate >>> (for ASSERT) */ >>> +    uint16_t line;          /* Line number */ >>> +    uint32_t pad0:16;       /* Padding for 8-bytes align */ >> >> Already the original comment in Arm code is wrong: The padding >> doesn't >> guarantee 8-byte alignment; it merely guarantees a multiple of 8 >> bytes >> size. Aiui there's also no need for 8-byte alignment anywhere here >> (in >> fact there's ".p2align 2" in the generator macros). >> >> I also wonder why this needs to be a named bitfield: Either make it >> plain uint16_t, or if you use a bitfield, then omit the name. >> > It will better to change it to 'uint16_t' as I don't see any reason to > use 'uint32_t' with bitfield here. > I'll check if we need the alignment. If there is '.p2align 2' we > really don't need it. See Julien's replies any my responses: FTAOD I did _not_ ask to remove the field. >>> +}; >>> + >>> +#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) >>> +#define bug_file(b) ((const void *)(b) + (b)->file_disp); >>> +#define bug_line(b) ((b)->line) >>> +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) >>> +#endif /* BUG_FRAME_STUFF */ >>> + >>> +#ifndef BUG_FRAME >>> +/* Many versions of GCC doesn't support the asm %c parameter which >>> would >>> + * be preferable to this unpleasantness. We use mergeable string >>> + * sections to avoid multiple copies of the string appearing in >>> the >>> + * Xen image. BUGFRAME_run_fn needs to be handled separately. >>> + */ >> >> When generalizing the logic, I wonder in how far the comment doesn't >> want re-wording some. For example, while Arm prefixes constant insn >> operands with # (and x86 uses $), there's no such prefix in RISC-V. >> At >> which point there's no need to use %c in the first place. (Which in >> turn means x86'es more compact representation may also be usable >> there. >> And yet in turn the question arises whether RISC-V wouldn't better >> have >> its own derivation of the machinery, rather than trying to generalize >> things. RISC-V's would then likely be closer to x86'es, just without >> the use of %c on asm() operands. Which might then suggest to rather >> generalize x86'es variant down the road.) > ARM version is more portable because of the '%c' modifier which is not > present everywhere, so I decided to use it as a generic implementation. > Moreover I don't see any reason why we can't switch x86 implementation > to 'generic/ARM'. That would increase data size on x86 for no gain, from all I can tell. >>> +         ".hword " __stringify(line) ", >>> 0\n"                                \ >> >> Hmm, .hword. How generic is support for that in assemblers? I notice >> even >> very old gas has support for it, but architectures may not consider >> it >> two bytes wide. (On x86, for example, it's bogus to be two bytes, >> since >> .word also produces 2 bytes of data. And indeed MIPS and NDS32 >> override it >> in gas to produce 1 byte of data only, at least in certain cases.) >> I'd >> like to suggest to use a fourth .long here, and to drop the padding >> field >> from struct bug_frame in exchange. > Changing .hword to .half can make the code more portable and generic, > as .half is a more standard and widely supported assembler directive > for declaring 16-bit data. And how is "half" better than "hword" in the mentioned respect? Half a word is still a byte on x86 (due to its 16-bit history). That said - from all I can tell by briefly looking at gas sources, there's no ".half" there. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 14 17:02:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 17:02:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495407.765774 (Exim 4.92) (envelope-from ) id 1pRyh8-00013X-2p; Tue, 14 Feb 2023 17:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495407.765774; Tue, 14 Feb 2023 17:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyh7-00013Q-W1; Tue, 14 Feb 2023 17:02:17 +0000 Received: by outflank-mailman (input) for mailman id 495407; Tue, 14 Feb 2023 17:02:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyh6-00013I-V1 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 17:02:17 +0000 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [2a00:1450:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 554f2201-ac89-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 18:02:16 +0100 (CET) Received: by mail-ej1-x629.google.com with SMTP id t24so1438712eji.4 for ; Tue, 14 Feb 2023 09:02:16 -0800 (PST) Received: from [192.168.67.143] ([62.74.15.167]) by smtp.gmail.com with ESMTPSA id d18-20020a1709063cf200b008af4dadd9c4sm7063362ejh.116.2023.02.14.09.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 09:02:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 554f2201-ac89-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f7GEHqKSndAUZtVxefE/h9zlnYXbz5OEgVN/13AtDoI=; b=IW3O4O6/BJNaaREsNPqEouEIvQ408IvA2Kzp61KJAaAvYWq6Y0PJcNioExlykBJEcA w3sJGshsmYXeHZ23iOJ05GANrXgR0Su8ZkgeuubkrmjMUkjxAqaA2ozFaSPYv0R5eEcB sYM1yyp/IYlwcQy1WdCPlt2dBLc0CXgSfK6OSwHM9s4gvH8jVOIBxdr2s39tBmNtMjv0 qe63iiTALOg0lTSz0RfhgV+DXF/matSsd+/RYCpzRRFq6TWByWZhHvcEvPyD6GJYQ/aO wySvINVMVAGlMZfusCusQ04avJDoKvWlkBLtVPwbsjravkD+VOcM/7uynVAVLVQKh0Gc wlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7GEHqKSndAUZtVxefE/h9zlnYXbz5OEgVN/13AtDoI=; b=4CDtSXcNSkSGZzK403NsjujXcSkXVvTWrBDyvhzrp6o2XfrlJZYt/FU1X4cC39jtNF egtSf2k7yimPE0Fyp7qvfRbIEiaHVl+mdhjxvMHcgaToSNipc3MZBpEoAhpw03oFaego louTreD4oK6WN8x/zyy3lFoEOxxEKTiALBdgCK78gWDUizLaQliJq0UH7D9gTPs5OMN3 hVzO5Szz8skSkaLBafoPtu5iv7dK9rISi5Te88W3tvv3EQy0XSYrb8l/vhCM/b3VeEvr iZj4LUu1ng0hsLT6umVLurqDwJHrw2jU8pxQLZc26kKsi9avh8MI35KOR8cXRcHBdjg7 /gbA== X-Gm-Message-State: AO0yUKWQUJpaLcrBAJaJ6ppjnW700RDMGQXpOx6loDV1ymX6sOkO7GIf Lf7jECknL7Nov9PDQGkYb8jZy+iojkA= X-Google-Smtp-Source: AK7set9lunnXYzVT33wfMZZaFN5sGiASecxoHt86UokuVuz2AEXKjxH/yf/xxInQzYKM34rzoBUWWw== X-Received: by 2002:a17:906:a3d8:b0:8a6:93a4:c892 with SMTP id ca24-20020a170906a3d800b008a693a4c892mr3459692ejb.44.1676394135801; Tue, 14 Feb 2023 09:02:15 -0800 (PST) Message-ID: <3f954ef8-eb62-a60c-1ecd-54f84c586057@gmail.com> Date: Tue, 14 Feb 2023 19:02:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC 09/10] x86/ioreq: guard VIO_realmode_completion with INTEL_VMX Content-Language: en-US To: Jan Beulich Cc: Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-10-burzalodowa@gmail.com> <883a4563-9a37-eb17-6e91-03216f336e99@suse.com> From: Xenia Ragiadakou In-Reply-To: <883a4563-9a37-eb17-6e91-03216f336e99@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/23 18:46, Jan Beulich wrote: > On 13.02.2023 15:57, Xenia Ragiadakou wrote: >> VIO_realmode_completion is specific to vmx realmode, so guard the completion >> handling code with INTEL_VMX. > > While it means slightly bigger a code change, personally I'd prefer if > VIO_realmode_completion simply didn't exist as enumerator when !VMX. > Besides ... > >> --- a/xen/arch/x86/hvm/ioreq.c >> +++ b/xen/arch/x86/hvm/ioreq.c >> @@ -44,6 +44,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) >> { >> switch ( completion ) >> { >> +#ifdef CONFIG_INTEL_VMX >> case VIO_realmode_completion: >> { >> struct hvm_emulate_ctxt ctxt; >> @@ -54,6 +55,7 @@ bool arch_vcpu_ioreq_completion(enum vio_completion completion) >> >> break; >> } >> +#endif > > ... this use there's exactly one further one which would need #ifdef-ing. > I think that's tolerable. Sure. I will fix it. > > Thinking further (not necessarily for you to carry out) the x86 version > is identical to Arm's when !VMX, so it would look better to me if the > entire x86 function became conditional, the Arm one was dropped, and > common/ioreq.c provided a fallback for the case where no arch one exists. It may look awkward to have arch_vcpu_ioreq_completion() in VMX guards in common ioreq code because the connection is not obvious immediately. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 14 17:03:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 17:03:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495414.765784 (Exim 4.92) (envelope-from ) id 1pRyiK-0001ad-Ct; Tue, 14 Feb 2023 17:03:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495414.765784; Tue, 14 Feb 2023 17:03:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyiK-0001aW-A4; Tue, 14 Feb 2023 17:03:32 +0000 Received: by outflank-mailman (input) for mailman id 495414; Tue, 14 Feb 2023 17:03:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyiI-0001aI-8P for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 17:03:30 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 805f7510-ac89-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 18:03:28 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id lf10so9846598ejc.5 for ; Tue, 14 Feb 2023 09:03:28 -0800 (PST) Received: from [192.168.67.143] ([62.74.15.167]) by smtp.gmail.com with ESMTPSA id b12-20020a170906038c00b0088f464ac276sm8391847eja.30.2023.02.14.09.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 09:03:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 805f7510-ac89-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wwTDOu/UKpaDwzmG/FhiUx684yLoVKwSEQAiFT8j9v0=; b=Ej5llmrtwEGFkGBi3L3juHBYTdt8ZXFP0Ic1lp4yUIjCtM8+V8jZV6AbZczjphshC/ /tq/yy1unpoAX7ilmxRMnZQF6EQJcKOuEMqDH/O2/KTR40Lmkl+3rPAiGCdrmejoESrg av1Ht7fdEeHBcp+lT+HIy2ZEpAgz4WWWTuFa2ZVm0AFHdbW4aZkGFcwMwlfHFObC0ewr u3rrXVHbUPC5XxOT0hC2ItqWbVQKkXgpAb9tDoK9mm5MSVil3Wv+L9UbNSd9m2oplELf AmjIKA1VEORsWtb3kh8B8p1CF2KKHj+dBB2h9WQ00oNe4PAVCA3gIooIcxmp+4grZiCi DfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wwTDOu/UKpaDwzmG/FhiUx684yLoVKwSEQAiFT8j9v0=; b=xHRJlTLZxVgNlVbko4kPQ2MUruXxUsrAKefsGK0wM1t0JoBUtdeWWI8gt23A/KnZj4 0vn6QubBKLGGV6uuw6jlYHZVCFHOwxjzF0SCuzSVHQ8CsiI/Nm3ltXvdFQXIZhlxfBqI JE5D6mj7o21sweDNsZczJIUaP1mUeXYAfPjB9Bh49f5d9s0ZIavfR/hOdSZpCeqw4x6V 32W5g8L9gskrxodMUmqx4JV0YEk4jd6Kj2yNVM4AA0Rlo5X6ZDNsQU/p4Tjwd8669xsU 2RQheNCUfSxD/ed9uHjfjtLyLWfd0+Vl0KfxizoTHQcYlCNQC9n+fhvEnG/30uxvjq40 liNQ== X-Gm-Message-State: AO0yUKX6QIoXFxE+7efhwEusJQuM6L6/o30usatJdCSpb34SC1aIItgq UAyBPFgr47Xyjbm7gRb1SV8AXpBL44I= X-Google-Smtp-Source: AK7set+TFg7/zQUrqm7WjAqPmoOyo/Gd75PVWxhHJLeE6xZHxOm1+dMPjiux/A5EluDfDu4jCW+qgg== X-Received: by 2002:a17:906:b35a:b0:8af:2ab2:1f99 with SMTP id cd26-20020a170906b35a00b008af2ab21f99mr4418139ejb.26.1676394207804; Tue, 14 Feb 2023 09:03:27 -0800 (PST) Message-ID: <6f938c45-d712-1683-6f32-a59c137031d6@gmail.com> Date: Tue, 14 Feb 2023 19:03:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC 06/10] x86/domain: guard svm specific functions with AMD_SVM Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-7-burzalodowa@gmail.com> <3f8ef895-48ec-ca39-f197-a83b9cd46469@suse.com> From: Xenia Ragiadakou In-Reply-To: <3f8ef895-48ec-ca39-f197-a83b9cd46469@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/23 18:24, Jan Beulich wrote: > On 13.02.2023 15:57, Xenia Ragiadakou wrote: >> The functions svm_load_segs() and svm_load_segs_prefetch() are AMD-V specific >> so guard their calls in common code with AMD_SVM. >> >> Since AMD_SVM depends on HVM, it can be used alone. >> >> No functional change intended. >> >> Signed-off-by: Xenia Ragiadakou > > With whatever the final name of the Kconfig control is going to be > Acked-by: Jan Beulich > > Thinking about it, both here an in the earlier patch it may be worth > considering to switch to use of IS_ENABLED() while making these > adjustments. Ok will do. Thanks. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 14 17:19:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 17:19:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495446.765808 (Exim 4.92) (envelope-from ) id 1pRyxK-0003mm-Ta; Tue, 14 Feb 2023 17:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495446.765808; Tue, 14 Feb 2023 17:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyxK-0003mf-QG; Tue, 14 Feb 2023 17:19:02 +0000 Received: by outflank-mailman (input) for mailman id 495446; Tue, 14 Feb 2023 17:19:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRyoi-0002JS-4F for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 17:10:08 +0000 Received: from outgoing2021.csail.mit.edu (outgoing2021.csail.mit.edu [128.30.2.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d4ad286-ac8a-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 18:10:06 +0100 (CET) Received: from c-24-17-218-140.hsd1.wa.comcast.net ([24.17.218.140] helo=srivatsab3MD6R.vmware.com) by outgoing2021.csail.mit.edu with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1pRyod-003ROd-5s; Tue, 14 Feb 2023 12:10:03 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d4ad286-ac8a-11ed-933c-83870f6b2ba8 Subject: Re: [PATCH] x86/hotplug: Remove incorrect comment about mwait_play_dead() To: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, peterz@infradead.org, hpa@zytor.com Cc: bp@alien8.de, dave.hansen@linux.intel.com, rafael.j.wysocki@intel.com, paulmck@kernel.org, jgross@suse.com, seanjc@google.com, thomas.lendacky@amd.com, linux-kernel@vger.kernel.org, imammedo@redhat.com, amakhalov@vmware.com, ganb@vmware.com, ankitja@vmware.com, bordoloih@vmware.com, keerthanak@vmware.com, blamoreaux@vmware.com, namit@vmware.com, wyes.karny@amd.com, lewis.carroll@amd.com, pv-drivers@vmware.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org References: <20230128003751.141317-1-srivatsa@csail.mit.edu> From: "Srivatsa S. Bhat" Message-ID: Date: Tue, 14 Feb 2023 09:09:58 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230128003751.141317-1-srivatsa@csail.mit.edu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 1/27/23 4:37 PM, Srivatsa S. Bhat wrote: > From: "Srivatsa S. Bhat (VMware)" > > The comment that says mwait_play_dead() returns only on failure is a > bit misleading because mwait_play_dead() could actually return for > valid reasons (such as mwait not being supported by the platform) that > do not indicate a failure of the CPU offline operation. So, remove the > comment. > > Suggested-by: Thomas Gleixner > Signed-off-by: Srivatsa S. Bhat (VMware) Gentle ping for review. Thank you! Regards, Srivatsa > --- > arch/x86/kernel/smpboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 55cad72715d9..9013bb28255a 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -1833,7 +1833,7 @@ void native_play_dead(void) > play_dead_common(); > tboot_shutdown(TB_SHUTDOWN_WFS); > > - mwait_play_dead(); /* Only returns on failure */ > + mwait_play_dead(); > if (cpuidle_play_dead()) > hlt_play_dead(); > } > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 17:28:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 17:28:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495464.765822 (Exim 4.92) (envelope-from ) id 1pRz6C-0005Si-UE; Tue, 14 Feb 2023 17:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495464.765822; Tue, 14 Feb 2023 17:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRz6C-0005Sb-RT; Tue, 14 Feb 2023 17:28:12 +0000 Received: by outflank-mailman (input) for mailman id 495464; Tue, 14 Feb 2023 17:28:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRz6B-0005SD-1E for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 17:28:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f14bc1ad-ac8c-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 18:28:08 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 12:28:04 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7243.namprd03.prod.outlook.com (2603:10b6:510:24a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 17:28:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 17:28:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f14bc1ad-ac8c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676395688; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=nTSXLQPpCPW6qbfpGYwlXvcD8cTUiR1Wpdsvt3uxnaI=; b=gMuEOIlkB9CCan7zkvXt7HG0TqQ5upEoBivqa3MzdXriosBWihWKgwIe Ci466A0pgRRAyL44AhfYt1UFDqZx2hQJpdPxEHbWv5Sx2NFgZCqcmHVYm 6F8kZxh2Xoooy/9AklvpDOlorhZDXRbpRweyDHX+onT+N2tU01srbSiUn M=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 97023797 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4r4xaK4+8J0wIMUkTjkslgxRtPTGchMFZxGqfqrLsTDasY5as4F+v mYbXD+Ba66DNzTzfYh/bIq39EoF78KGmNQySgRsri02Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 KAHCGtVXjW43cW96qK/dfdJ1+UJFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOWF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNNTOfjqa816LGV7kUpDwwRTnTjmNWoqBKhdP9FB Gc3ozV7+MDe82TuFLERRSaQpX+PvhcYHd1KAeA+wAiIxuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8pjqoNS8YBWQLfyMDQE0O5NyLiJookhvFQ9JnEai0pt74Azf9x 3aNtidWulkIpcsC1qH+91aYhTup/8DNVlRsvliRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg== IronPort-HdrOrdr: A9a23:uboUa63LmkLbfawr9nihzwqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.97,297,1669093200"; d="scan'208";a="97023797" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGhWJfmPZ/XvffMDnP96YMhyP2R5y0msgsXhXit+B1JEHYmvmVC/d+KfY87QZKX8MNbPXmFgT42AhkB4S/ld8FXNcC9kRko4C6yCh33FSsQSKd1CLf11+xdFc7c+w/oT9gDTtmeh0mzj8cvs1eMzM0S8uh3FZHyNv6DGoSWh4abY+ULAy4jja4on3r4Nyf57RowAKyoGjgZxmlDUh7hpsK7nt3YvCvcxJbf8eZofpekLs4lIGs3npIAWppphDJZQcGS8s7gT4a60EMoiYZKTVAIpahoLbsYE2iHOqqTqpPdPnmVRpjOQDWyzV93Tvqu/Vcmu0XaLJtm8VzdQH/XP3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aD4xoZDchmtQQmEqkMkMDcP4VQxFcxj/KCK0hPvM5Vg=; b=DCJUn/St9Dsa+rU5ot2GJh16euCNQGqBfU+gBGgWhv8L4hACXzY6j62OhFyDr62lAcolB4vPnF3Vt99BTZOJ+Ns14dLYN6R8WugQuRq8dUT76UVj4f+YztGFPFdFaXKGZxmJXDst59SCtUAuAQ/UTZrm8b1GVP4gLyXQi5GmJ0XZY1k/+QOL3E1P8m+S0wVveizgQ9JPoledq6P8n2Tozxm9t3gXcyY7Mx3LRx6v3wXOr/B81kNtNPfzpMDXIZxkQ9Vt/GJuLt4Yn+o4rXIMa/CW/6ZeTThqm0wtIstQmxwvkJ8CsIXrp7rDlkXHiPuGiPV69u9Qt7m281jNjl8uGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aD4xoZDchmtQQmEqkMkMDcP4VQxFcxj/KCK0hPvM5Vg=; b=npnkUS6e/TrAXd/e2RNT9yVJ6xJrasJm09I/aI0B3ZMmOPjEgBmgewPWpWJ4pWeF88HznsWqUzxTAHtr1ieBNIKzBiXZABntIRI/gpV3wbQfCIUibSiz5zRps053NKfxD1VjWapajS3ncQl2wMcavNDoUA/LTcCahHmEVSpfXrw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <59da3abf-7c56-7a46-03a3-b11537d0527b@citrix.com> Date: Tue, 14 Feb 2023 17:27:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] automation: Add container and build jobs to run cppcheck analysis Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230214153945.15719-1-michal.orzel@amd.com> From: Andrew Cooper In-Reply-To: <20230214153945.15719-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0254.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7243:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a6c13a7-e475-4d2b-0d26-08db0eb0d2f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /5XHLMkBppWa2nGNd5pJb9Z2liuc3AIRFj1jX+Oku4aitjOZpBIX0vEYkCVucpfNvDfGG+aNZYarYNHT0hO3UshHMqdVOPS+FC4mvMB4xQG103jviNdJyL62RE70tVarMKFQAZPEz6sRK7ZpAzrt3HvlNGBYxhoKRc8D2TaBt5FAfUBdUwv7vTq20rJURcPxjvqCrdwR0IQEK3YeRiexi36WRseROGl0Na+ZAq1s1HphOMZxoYTxWHiQE+iXOFd+56ff34oGz4ni3pqfpb0CtHTj+uaKZDEbjbmBGSGTeSRG4p4WPvPlVhsLnGr3ZqgzqdHEC/D/UMqriM1XWqmyTA1OW4XR9sSVYTBEASluQ7XlEfXh3Ld4uHzE4X8ZWH+LO18zFD5bOEUNSJX1vNPxra47UdwAqC5uMWj28kdU3h08rVuHLBXSTZfJh5aPpRrz64v4z/Uz/pe3V38F7WBbDs7/55D8VjZW1nBoSzdFDWZZ5I0TdR2XeB8cJ9fbuDAL5ZVWHFZb7yJ0zM4zKGvCdOReAfh6Pc2TPGJluv04ECgXnxOMeFuj0fZftm9JKDptbfpZ3atVWt9tZnkddXiDzYy/sXZvraHnjY53fzp6tevaj4hJUdAs5eZ4CUL+uEIMZi8+0vywQsmaBg1ZVpq/5aB4A363znQ+Va2IBrBRAeV9W3YoY60wgcoXOKyRYr9K7ZulpYgu2PvdxX1gTAPzRRXNvRLwltSdURaacVzfq2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(451199018)(31686004)(41300700001)(38100700002)(66476007)(66556008)(316002)(8676002)(6506007)(8936002)(5660300002)(4326008)(31696002)(86362001)(66946007)(36756003)(82960400001)(6666004)(6486002)(478600001)(53546011)(26005)(6512007)(186003)(2906002)(54906003)(83380400001)(966005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmF6VHlRemNEN003V1NuUGpKRW9HMnVJZlRqZ2ZBZlc1K1R2US9pOXdUNjFR?= =?utf-8?B?eCtUcVdndjF6bzUzdWxmbjU3VitNL1VRQ3Bnbm9oeDc3RjdHRWN1SHJzWmVj?= =?utf-8?B?Zi9YUnRpUGJPYWxreENraEo5bjZqeTFDQ2grOHphSHZneU9FZmd6NFc2WjMy?= =?utf-8?B?MzVZdVJuZFJDRm1YTVlXZUZzQmJyMUt0Vkp3Rkg5Q2pzQzBaSU1NOFJCR3Rz?= =?utf-8?B?ZzNGVzFIbDcxTTFpQ1hNUEhnVjBsQURkb2xZUmJCSHhOOWZnWisvb0pPa1ZF?= =?utf-8?B?Zit1MWVCNkE1R2tlVTc3YjZiNmNxMDEzWnZoWTVzdmkzSll4TjFZS0x3TXdo?= =?utf-8?B?cCs0V0hCUHNlZUNLcytST2NST255cnlJSmFXS2dNNlFSR0JHSG1JQWV6U3NG?= =?utf-8?B?c2R3QmM0Ym10dXNUM1VITkxLRWk4ZHlDRUg4R3VVMXZOZW1pcTdZbFF1cjhJ?= =?utf-8?B?YkR2aTNGeE5Rdk1BKzFTNnRhVUJIZUFGaXIwK29vUmd2alkrdlpKN0VWQitl?= =?utf-8?B?aC9CbWpGNXp2RXNGZ3NJaFFFTTAwRmhKWWdhQ1QyYllaaU0xUTZGdkRVMVBy?= =?utf-8?B?ODlZanRLaXJFSHBsQkRzVVp1YXBnaUdYbFF2UnlLNkJib3lBNks5V1JCUHRu?= =?utf-8?B?SXhROVVIOVluMzlWdjM0RWNWZ1FJcUFiNXB1cnFiT1BuVkV1Nlo1Z29HNW5C?= =?utf-8?B?NXVvaXpHVkxualJLZXNVeHdWeVBmeHpKWDZlYXNWdjlMdm1KekczczhvUXFy?= =?utf-8?B?dVNXakVYcDBUK2tUclM1aXRjZEtXOCs1cWNadzR6cU5uUGRaSDFRQXpvSHBw?= =?utf-8?B?RnZSeVpWdUxFcHYrZ3JsT1VTMWVhTXV3eW5IZVpyN2JXRlFPaktXcWd1UUpL?= =?utf-8?B?S3l5SmFWWG5leUtGNnpNSmMxZE5Db3NpVzBRUWg5NkpYK1l4K1pIOWYxbXdC?= =?utf-8?B?NnJBY2ZiWVk5T3pVWTQ4bmdncmRmYzhzdGpuRW05SnhSUWRYcVNHTnEzOVZy?= =?utf-8?B?N1h0Q2RHOWZXV0diU2hyYW91b3dCd2h0TDR6VHFFTUwrd2pOWDI3T1ZZRjhK?= =?utf-8?B?enFVbC9qR1VqbENIUkhLZkgvMVFvaEptZDFtNDY2MmYvbFBQeVN6cS9zUEpG?= =?utf-8?B?QjhjeDFPTWZVOHRtNnFLU2cxZ2xXWi9RbWx6MGtYdjRCU3NaY0pzclhodGZS?= =?utf-8?B?cnl2eEIydi9LV2lJUlN1RExDb2UzSVc4UlZzVUdrRGZTMGZpcVJnc3VQaks3?= =?utf-8?B?RFZicDNPdVdKT0VvUDRlN1VKWlNoOVY4dmxPRW9PZk5VOHdlbFJaUTA2OXo3?= =?utf-8?B?cFJEZXhnb2l3NzkrdTc2STR2RC9qd2pzUy9ETDl3TWVuRFRlU25xdGlVVXE1?= =?utf-8?B?aW5ZQ2dwNktoZG0zSkJwNUxZT0R0U3MzdnZUemJlekh3RnB2bjZvZUpwZzha?= =?utf-8?B?dlNIZVVROEFmb0g1VndqaXprWSt1VVZPbG1NTTJSSHRWT2pxaTREa1hhT2cz?= =?utf-8?B?b3ZSME5FN3N4b2Y3NUJQQ2RvV0FVU012OTZqOHF5aWY2SThsM2FlcFJhekxs?= =?utf-8?B?bmtsNHJud2dZa0l0Zm5tMUNGcXBlUHU0ODQxbDVWUlpSY2ExS1dqQm5BaURJ?= =?utf-8?B?QWMvL3BMd2Ywazh4NERmU0NmUWd5NFdiUlJpUGoxMjNVMHlNTGg1VDZLdFll?= =?utf-8?B?WlZvNDRJZ0tDYWRNR1Bia1JTSHdrbmFGa3ZmTjdLZHNoT0JNM0tIbWFWUzFK?= =?utf-8?B?M1VpSkM1cE80OFA3S2lHOVA5V2xLNG9SS01TQXBxV05WeFVBbzRsd3VQYm1z?= =?utf-8?B?ZW1KOEdFdmZGVGhVYTJtYkJHRDNOd2Zub01QallodVl1dUJsTHhxeHpUTC9D?= =?utf-8?B?T1k5bmVNQTdBMlRUL0pSbUtDWk5xdUJwZnB1U0htVTAwRVFXQmtTRmNPUnFY?= =?utf-8?B?cmpBSjY4VmY5b2hJQ3RMa3FYeDdDSTdGYUw3cDNSWjhucHMwMENteVdpcVVS?= =?utf-8?B?WnNWd2pTNUIxNkFPZlZhYW5qWEY4S3ppM1ZONjVNYUNzblQ0N21RY094dDJY?= =?utf-8?B?TWpBemRBcEhEblBjSTJuVGUzZ05pOGVNZFhGVkYzMVpON0Rtd1VHVEkzKzRJ?= =?utf-8?B?bnorMnVwNDlwdERNTFYwRTMrdjc1blBqZ0I5RWM0bGhtVEEwZ0trMEtjSEJ1?= =?utf-8?B?RHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oN0VFvydEe7icUWsTrAiW/Z6sVoGFfD/ZIOoy1ULHxBnNEKqf3FwIe3RSNH3GNO9BqFGcwAwyCJcU+0u41MioZuzel+oaQxxuzveikzSXCnu1KROpYp+vGeK5YQiovvUkyeDkdmpfR7orkbg2uGrdg+eYSnx4jTc+DkfqittyqDB5pHyOyfalr6bqpksD4nc/kRJpLhX2gal95VBF3b5xKw/adzo5V7ei/vnG2GiTQQNMtT5II6y+sQaobQa//sySTHASiqnNgBhuXzruXW0jJwqXOVHdq+bwXgoAUW60dz/9024l8efcLoyJJlmRFF8V+YKN930lHD73DA92U+TQXIOvaUYyZfWeSUH1UAVC2acTT/cORlEwpCWeKRbdZF++zHaOLDtScg9mq2NpUj1rY1JezU22W3Cff8sz/m/wP91xn4Rdwc00AGFkYsTR3pGcSHEW4FuVvRFaK83NfkT2Gb1yGvBTTsIoEHk4Wc/MrxW9Q0Bh+9+wjr5WzZF+NwaVLin1lwNS91TO2J7jWaAgdTsdYw5wIb+4+6R6Mm0pTzQCalOH8B+5pRXC+wAcSZFeu1asIMJvFxEY62+ly3uWcRLj7WKdKg8iQHY/rZV1GOVGicw9eS9KivNjIcYFT8GLy94uNkGkg7Dwtvni7yEl3rr1O5FjXcfK3t0WAOX2LxtoYtuJZ529PsHvX6mMgrcJtpixcVfrwhgSCSDeA28iR2a9bnsMqoWdjbKjgZAIMjZ7VjXd2DYwMi9aELoBqZXaeQQ9s849zGPOGr3jXaLsk6YLU07bLdjz8MdV9KWx6lbrjPezJRIaDLGFAsRTyec+ffRKY4RkGGjPCHAf9WrW3ubmJabqbJm8k5GCP/gT3A= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6c13a7-e475-4d2b-0d26-08db0eb0d2f4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:28:02.3361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fuf6p/aI0/uA2yIIdYwYQwuf70zJpNSkDus3oY1eLyGIJmbxVqGcg7oSBGQvYcZxSBrW4rCoUuBOx/VmcpqEfA4OwnIPOwMsVcHbCVwSDcs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7243 On 14/02/2023 3:39 pm, Michal Orzel wrote: > diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile > new file mode 100644 > index 000000000000..54b99f87dfec > --- /dev/null > +++ b/automation/build/debian/unstable-cppcheck.dockerfile > @@ -0,0 +1,37 @@ > +FROM arm64v8/debian:unstable > +LABEL maintainer.name="The Xen Project" \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV CPPCHECK_VERSION=2.7 > +ENV USER root > + > +RUN mkdir /build > +WORKDIR /build > + > +# dependencies for cppcheck and Xen-only build/cross-build > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + build-essential \ > + curl \ > + python-is-python3 \ > + libpcre3-dev \ > + flex \ > + bison \ > + gcc-arm-linux-gnueabihf \ > + gcc-x86-64-linux-gnu > + > +# cppcheck release build (see cppcheck readme.md) > +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ > + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ > + cd cppcheck-"$CPPCHECK_VERSION" && \ > + make install -j$(nproc) \ > + MATCHCOMPILER=yes \ > + FILESDIR=/usr/share/cppcheck \ > + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" I think you want to be using a mutli-FROM dockerfile here, otherwise you're including all the intermediate build artefacts in the final image. See debian/buster-gcc-ibt.dockerfile for an example. That said, I'm not sure we want to be making custom containers for every minor tweak we have on a build environment.  What's wrong with just putting CPPCHECK in the normal container? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 14 17:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 17:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495469.765833 (Exim 4.92) (envelope-from ) id 1pRzBi-00075u-Ir; Tue, 14 Feb 2023 17:33:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495469.765833; Tue, 14 Feb 2023 17:33:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRzBi-00075n-Fu; Tue, 14 Feb 2023 17:33:54 +0000 Received: by outflank-mailman (input) for mailman id 495469; Tue, 14 Feb 2023 17:33:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRzBg-00075h-TM for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 17:33:52 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be44dc8b-ac8d-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 18:33:51 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A2F95CE2169; Tue, 14 Feb 2023 17:33:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96EB8C433EF; Tue, 14 Feb 2023 17:33:41 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be44dc8b-ac8d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676396022; bh=4FxFdAzCF2rvXNmbuIkOoQ5OZXy8XSYFQtGAVovy1Eg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JP0V0DhQaMXMX5diqWB9FYcFPfgFx307Zlpee8DeH6KjUACB4belW1CkqYm7yqgTf bFncVUNSim8iIoYRjZFRGaot7sWGue7KY5LJhHy2sXbAHmd7N4KArl2ABL6NHALhSE W3UEGyhXP3QZ8zFam6htC10zB8Kk0+ivF3TWd5RvZc1w+aWOXJab0GnmRq6UwQEFI2 3OU3S6VX3ZJMnfr7NbuwSdDZxq2FlC92wIa3RilQ/p2tU7tXVDavs0M/dFrGmfyWMI u19tYzavnWiRWt2kQNBaO68/G/+TrDJLCw+MT1mmUyaQp5Gbv3uRXzlftwjgpkUf+x WngKf0Yd1ayqg== Date: Tue, 14 Feb 2023 09:33:20 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Michal Orzel , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2] automation: Add container and build jobs to run cppcheck analysis In-Reply-To: <59da3abf-7c56-7a46-03a3-b11537d0527b@citrix.com> Message-ID: References: <20230214153945.15719-1-michal.orzel@amd.com> <59da3abf-7c56-7a46-03a3-b11537d0527b@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-14625239-1676396022=:2025117" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-14625239-1676396022=:2025117 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 14 Feb 2023, Andrew Cooper wrote: > On 14/02/2023 3:39 pm, Michal Orzel wrote: > > diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile > > new file mode 100644 > > index 000000000000..54b99f87dfec > > --- /dev/null > > +++ b/automation/build/debian/unstable-cppcheck.dockerfile > > @@ -0,0 +1,37 @@ > > +FROM arm64v8/debian:unstable > > +LABEL maintainer.name="The Xen Project" \ > > + maintainer.email="xen-devel@lists.xenproject.org" > > + > > +ENV DEBIAN_FRONTEND=noninteractive > > +ENV CPPCHECK_VERSION=2.7 > > +ENV USER root > > + > > +RUN mkdir /build > > +WORKDIR /build > > + > > +# dependencies for cppcheck and Xen-only build/cross-build > > +RUN apt-get update && \ > > + apt-get --quiet --yes install \ > > + build-essential \ > > + curl \ > > + python-is-python3 \ > > + libpcre3-dev \ > > + flex \ > > + bison \ > > + gcc-arm-linux-gnueabihf \ > > + gcc-x86-64-linux-gnu > > + > > +# cppcheck release build (see cppcheck readme.md) > > +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ > > + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ > > + cd cppcheck-"$CPPCHECK_VERSION" && \ > > + make install -j$(nproc) \ > > + MATCHCOMPILER=yes \ > > + FILESDIR=/usr/share/cppcheck \ > > + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" > > I think you want to be using a mutli-FROM dockerfile here, otherwise > you're including all the intermediate build artefacts in the final image. > > See debian/buster-gcc-ibt.dockerfile for an example. > > That said, I'm not sure we want to be making custom containers for every > minor tweak we have on a build environment.  What's wrong with just > putting CPPCHECK in the normal container? cppcheck is not large but needs to be built from source (as part of the Dockerfile). So we thought it would be best to keep it separate from the regular containers. I don't foresee another case like cppcheck at the moment. Also by having it separate it is clearer that this container is "special". I think it would be preferable to keep it in its own separate container but it would be OK either way. --8323329-14625239-1676396022=:2025117-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 18:04:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 18:04:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495487.765873 (Exim 4.92) (envelope-from ) id 1pRzeS-0003E7-KD; Tue, 14 Feb 2023 18:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495487.765873; Tue, 14 Feb 2023 18:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRzeS-0003DP-FA; Tue, 14 Feb 2023 18:03:36 +0000 Received: by outflank-mailman (input) for mailman id 495487; Tue, 14 Feb 2023 18:03:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRzeR-0002pa-Bj for xen-devel@lists.xen.org; Tue, 14 Feb 2023 18:03:35 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e29bad6b-ac91-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 19:03:32 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pRze8-00074n-P6; Tue, 14 Feb 2023 18:03:16 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pRze8-0007sq-Ni; Tue, 14 Feb 2023 18:03:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e29bad6b-ac91-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=wOtcK6/0BSW7PzaouV1UXsUM6DO4roV3+RcOb5t2Yi8=; b=PXePhEeRJ19SZpuPldjuDayADI R9x62QaQAKgWTXEdyXoTyREMdEJk0ZRqjfbj+qiZT0+01Gb+b7MeWQpBCsveATfAjHH5II/ciZ5/W XBXbg+Fn7oX3clQYQyYvu9qTJ0omR5MLhkx5wj/+VGymvXv20GpAbsoTNVTkbOskY+zg=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 426 v1 (CVE-2022-27672) - x86: Cross-Thread Return Address Predictions Message-Id: Date: Tue, 14 Feb 2023 18:03:16 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-27672 / XSA-426 x86: Cross-Thread Return Address Predictions ISSUE DESCRIPTION ================= It has been discovered that on some AMD CPUs, the RAS (Return Address Stack, also called RAP - Return Address Predictor - in some AMD documentation, and RSB - Return Stack Buffer - in Intel terminology) is dynamically partitioned between non-idle threads. This allows an attacker to control speculative execution on the adjacent thread. For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1045 IMPACT ====== An attacker might be able to infer the contents of arbitrary host memory, including memory assigned to other guests. VULNERABLE SYSTEMS ================== Only AMD CPUs are known to be potentially vulnerable. CPUs from other hardware vendors are not believed to be impacted. Only the Zen1 and Zen2 microarchitectures are believed to be potentially vulnerable. Other microarchitectures are not believed to be vulnerable. Only configurations with SMT activate are potentially vulnerable. If SMT is disabled by the firmware, or at runtime with `smt=0` on Xen's command line, then the platform is not vulnerable. Xen 4.17 and later contains an optimisation, specifically: c/s afab477fba3b ("x86/spec-ctrl: Skip RSB overwriting when safe to do so") which in combination with disabling 32bit PV guests (either at compile time with CONFIG_PV32=n, or at runtime with `pv=no-32` on the command line) renders Xen vulnerable to attack from PV guests. Note: multiple downstreams are known to have backported this optimisation to older versions of Xen. Consult your software vendor documentation. MITIGATION ========== On otherwise-vulnerable configurations, the issue can be mitigated by booting Xen with `spec-ctrl=rsb`, which will override the aforementioned optimisation. Alternatively, SMT can be disabled either in the firmware, or by booting Xen with `smt=0`. Alternatively, if 32bit PV guests are only runtime disabled in Xen, this issue can also be mitigated by booting Xen with `pv=32` to enable support 32bit PV guests. It is not necessary for a 32bit PV guest to actually be running in order to mitigate the issue. RESOLUTION ========== Applying the attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa426.patch xen-unstable - Xen 4.17 $ sha256sum xsa426* 425b1d8931e02852afec9fe3d9f1d009f6d8a33c6387b2e8b3896f374732d470 xsa426.patch $ -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmPrzJoMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZiqsIALrisP3l7ImoKe49Bmb1blNYmUv6UjYGdVF9acc9 ++QYPLq4Mu+kJuIlgKnT21hj7BFczL4KSi8sVw/nLqU3x8R/ZJ6nxXLlCod6RqGw 4MYd6QmArx8a+hm3LC0288VEFVXFh0WTDA6PK15RkspiwcjsAZ4w7DA7cRk0FLP0 9KJMhSPOAj9wCDhvOckr7DnA+D6gOKjMH83NCL0rg6Xe8+Bv0qTVYe49FqAnbWwc 9RsYOKfRuZUci+Z+mALVRB97R7xvns5D9HnDvs55ADri506JWkxmdp1GvLtjezXV 3Zds6TOrr1i0RQGV9M6aouinrI+DQNrOFR8V6p98KYxAo+Y= =T8Uh -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa426.patch" Content-Disposition: attachment; filename="xsa426.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQ3Jvc3MtVGhy ZWFkIFJldHVybiBBZGRyZXNzIFByZWRpY3Rpb25zCgpUaGlzIGlzIFhTQS00 MjYgLyBDVkUtMjAyMi0yNzY3MgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENv b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQg YS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MgYi9kb2NzL21p c2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MKaW5kZXggOTIzOTEwZjU1M2M1 Li5hMmZmMzhjZGViZjIgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy94ZW4tY29t bWFuZC1saW5lLnBhbmRvYworKysgYi9kb2NzL21pc2MveGVuLWNvbW1hbmQt bGluZS5wYW5kb2MKQEAgLTIzNTUsNyArMjM1NSw3IEBAIGd1ZXN0cyB0byB1 c2UuCiAgIG9uIGVudHJ5IGFuZCBleGl0LiAgVGhlc2UgYmxvY2tzIGFyZSBu ZWNlc3NhcnkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgogICBndWVzdHMg YW5kIGlmIGRpc2FibGVkLCBndWVzdHMgd2lsbCBiZSB1bmFibGUgdG8gdXNl IElCUlMvU1RJQlAvU1NCRC9ldGMuCiAqIGByc2I9YCBvZmZlcnMgY29udHJv bCBvdmVyIHdoZXRoZXIgdG8gb3ZlcndyaXRlIHRoZSBSZXR1cm4gU3RhY2sg QnVmZmVyIC8KLSAgUmV0dXJuIEFkZHJlc3MgU3RhY2sgb24gZW50cnkgdG8g WGVuLgorICBSZXR1cm4gQWRkcmVzcyBTdGFjayBvbiBlbnRyeSB0byBYZW4g YW5kIG9uIGlkbGUuCiAqIGBtZC1jbGVhcj1gIG9mZmVycyBjb250cm9sIG92 ZXIgd2hldGhlciB0byB1c2UgVkVSVyB0byBmbHVzaAogICBtaWNyb2FyY2hp dGVjdHVyYWwgYnVmZmVycyBvbiBpZGxlIGFuZCBleGl0IGZyb20gWGVuLiAg Kk5vdGU6IEZvcgogICBjb21wYXRpYmlsaXR5IHdpdGggZGV2ZWxvcG1lbnQg dmVyc2lvbnMgb2YgdGhpcyBmaXgsIGBtZHM9YCBpcyBhbHNvIGFjY2VwdGVk CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVh dHVyZXMuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJl cy5oCmluZGV4IDg2NWYxMTA5ODY2ZC4uZGEwNTkzZGU4NTQyIDEwMDY0NAot LS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaAor KysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaApA QCAtMzUsNyArMzUsOCBAQCBYRU5fQ1BVRkVBVFVSRShTQ19SU0JfSFZNLCAg ICAgICAgWDg2X1NZTlRIKDE5KSkgLyogUlNCIG92ZXJ3cml0ZSBuZWVkZWQg Zm9yIEhWTQogWEVOX0NQVUZFQVRVUkUoWEVOX1NFTEZTTk9PUCwgICAgIFg4 Nl9TWU5USCgyMCkpIC8qIFNFTEZTTk9PUCBnZXRzIHVzZWQgYnkgWGVuIGl0 c2VsZiAqLwogWEVOX0NQVUZFQVRVUkUoU0NfTVNSX0lETEUsICAgICAgIFg4 Nl9TWU5USCgyMSkpIC8qIENsZWFyIE1TUl9TUEVDX0NUUkwgb24gaWRsZSAq LwogWEVOX0NQVUZFQVRVUkUoWEVOX0xCUiwgICAgICAgICAgIFg4Nl9TWU5U SCgyMikpIC8qIFhlbiB1c2VzIE1TUl9ERUJVR0NUTC5MQlIgKi8KLS8qIEJp dHMgMjMsMjQgdW51c2VkLiAqLworLyogQml0cyAyMyB1bnVzZWQuICovCitY RU5fQ1BVRkVBVFVSRShTQ19SU0JfSURMRSwgICAgICAgWDg2X1NZTlRIKDI0 KSkgLyogUlNCIG92ZXJ3cml0ZSBuZWVkZWQgZm9yIGlkbGUuICovCiBYRU5f Q1BVRkVBVFVSRShTQ19WRVJXX0lETEUsICAgICAgWDg2X1NZTlRIKDI1KSkg LyogVkVSVyB1c2VkIGJ5IFhlbiBmb3IgaWRsZSAqLwogWEVOX0NQVUZFQVRV UkUoWEVOX1NIU1RLLCAgICAgICAgIFg4Nl9TWU5USCgyNikpIC8qIFhlbiB1 c2VzIENFVCBTaGFkb3cgU3RhY2tzICovCiBYRU5fQ1BVRkVBVFVSRShYRU5f SUJULCAgICAgICAgICAgWDg2X1NZTlRIKDI3KSkgLyogWGVuIHVzZXMgQ0VU IEluZGlyZWN0IEJyYW5jaCBUcmFja2luZyAqLwpkaWZmIC0tZ2l0IGEveGVu L2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oIGIveGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCmluZGV4IDZhNzdjMzkzNzg0 NC4uMzkxOTczZWY2YTI4IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5j bHVkZS9hc20vc3BlY19jdHJsLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3NwZWNfY3RybC5oCkBAIC0xNTksNiArMTU5LDIxIEBAIHN0YXRp YyBhbHdheXNfaW5saW5lIHZvaWQgc3BlY19jdHJsX2VudGVyX2lkbGUoc3Ry dWN0IGNwdV9pbmZvICppbmZvKQogICAgICAqLwogICAgIGFsdGVybmF0aXZl X2lucHV0KCIiLCAidmVydyAlW3NlbF0iLCBYODZfRkVBVFVSRV9TQ19WRVJX X0lETEUsCiAgICAgICAgICAgICAgICAgICAgICAgW3NlbF0gIm0iIChpbmZv LT52ZXJ3X3NlbCkpOworCisgICAgLyoKKyAgICAgKiBDcm9zcy1UaHJlYWQg UmV0dXJuIEFkZHJlc3MgUHJlZGljdGlvbnM6CisgICAgICoKKyAgICAgKiBP biB2dWxuZXJhYmxlIHN5c3RlbXMsIHRoZSByZXR1cm4gcHJlZGljdGlvbnMg KFJTQi9SQVMpIGFyZSBzdGF0aWNhbGx5CisgICAgICogcGFydGl0aW9uZWQg YmV0d2VlbiBhY3RpdmUgdGhyZWFkcy4gIFdoZW4gZW50ZXJpbmcgaWRsZSwg b3VyIGVudHJpZXMKKyAgICAgKiBhcmUgcmUtcGFydGl0aW9uZWQgdG8gYWxs b3cgdGhlIG90aGVyIHRocmVhZHMgdG8gdXNlIHRoZW0uCisgICAgICoKKyAg ICAgKiBJbiBzb21lIGNhc2VzLCB3ZSBtaWdodCBzdGlsbCBoYXZlIGd1ZXN0 IGVudHJpZXMgaW4gdGhlIFJBUywgc28gZmx1c2gKKyAgICAgKiB0aGVtIGJl Zm9yZSBpbmplY3RpbmcgdGhlbSBzaWRld2F5cyB0byBvdXIgc2libGluZyB0 aHJlYWQuCisgICAgICoKKyAgICAgKiAoYWIpdXNlIGFsdGVybmF0aXZlX2lu cHV0KCkgdG8gc3BlY2lmeSBjbG9iYmVycy4KKyAgICAgKi8KKyAgICBhbHRl cm5hdGl2ZV9pbnB1dCgiIiwgIkRPX09WRVJXUklURV9SU0IiLCBYODZfRkVB VFVSRV9TQ19SU0JfSURMRSwKKyAgICAgICAgICAgICAgICAgICAgICA6ICJy YXgiLCAicmN4Iik7CiB9CiAKIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAq YCwgYGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBjYWxsLiAqLwpkaWZm IC0tZ2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gv eDg2L3NwZWNfY3RybC5jCmluZGV4IGEzMjBiODE5NDdjOC4uZTgwZTJhNWVk MWE5IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysr IGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMzI3LDEzICsxMzI3 LDM4IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlv bnModm9pZCkKICAgICAgKiAzKSBTb21lIENQVXMgaGF2ZSBSU0JzIHdoaWNo IGFyZSBub3QgZnVsbCB3aWR0aCwgd2hpY2ggYWxsb3cgdGhlCiAgICAgICog ICAgYXR0YWNrZXIncyBlbnRyaWVzIHRvIGFsaWFzIFhlbiBhZGRyZXNzZXMu CiAgICAgICoKKyAgICAgKiA0KSBTb21lIENQVXMgaGF2ZSBSU0JzIHdoaWNo IGFyZSByZS1wYXJ0aXRpb25lZCBiYXNlZCBvbiB0aHJlYWQKKyAgICAgKiAg ICBpZGxlbmVzcywgd2hpY2ggYWxsb3dzIGFuIGF0dGFja2VyIHRvIGluamVj dCBlbnRyaWVzIGludG8gdGhlIG90aGVyCisgICAgICogICAgdGhyZWFkLiAg V2Ugc3RpbGwgYWN0aXZlIHRoZSBvcHRpbWlzYXRpb24gaW4gdGhpcyBjYXNl LCBhbmQgbWl0aWdhdGUKKyAgICAgKiAgICBpbiB0aGUgaWRsZSBwYXRoIHdo aWNoIGhhcyBsb3dlciBvdmVyaGVhZC4KKyAgICAgKgogICAgICAqIEl0IGlz IHNhZmUgdG8gdHVybiBvZmYgUlNCIHN0dWZmaW5nIHdoZW4gWGVuIGlzIHVz aW5nIFNNRVAgaXRzZWxmLCBhbmQKICAgICAgKiAzMmJpdCBQViBndWVzdHMg YXJlIGRpc2FibGVkLCBhbmQgd2hlbiB0aGUgUlNCIGlzIGZ1bGwgd2lkdGgu CiAgICAgICovCiAgICAgQlVJTERfQlVHX09OKFJPX01QVF9WSVJUX1NUQVJU ICE9IFBNTDRfQUREUigyNTYpKTsKLSAgICBpZiAoIG9wdF9yc2JfcHYgPT0g LTEgJiYgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1hFTl9TTUVQKSAmJgot ICAgICAgICAgIW9wdF9wdjMyICYmIHJzYl9pc19mdWxsX3dpZHRoKCkgKQot ICAgICAgICBvcHRfcnNiX3B2ID0gMDsKKyAgICBpZiAoIG9wdF9yc2JfcHYg PT0gLTEgKQorICAgIHsKKyAgICAgICAgb3B0X3JzYl9wdiA9IChvcHRfcHYz MiB8fCAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1hFTl9TTUVQKSB8fAor ICAgICAgICAgICAgICAgICAgICAgICFyc2JfaXNfZnVsbF93aWR0aCgpKTsK KworICAgICAgICAvKgorICAgICAgICAgKiBDcm9zcy1UaHJlYWQgUmV0dXJu IEFkZHJlc3MgUHJlZGljdGlvbnMuCisgICAgICAgICAqCisgICAgICAgICAq IFZ1bG5lcmFibGUgc3lzdGVtcyBhcmUgWmVuMS9aZW4yIHVhcmNoLCB3aGlj aCBpcyBBTUQgRmFtMTcgLyBIeWdvbgorICAgICAgICAgKiBGYW0xOCwgd2hl biBTTVQgaXMgYWN0aXZlLgorICAgICAgICAgKgorICAgICAgICAgKiBUbyBt aXRpZ2F0ZSwgd2UgbXVzdCBmbHVzaCB0aGUgUlNCL1JBUy9SQVAgb25jZSBi ZXR3ZWVuIGVudGVyaW5nCisgICAgICAgICAqIFhlbiBhbmQgZ29pbmcgaWRs ZS4KKyAgICAgICAgICoKKyAgICAgICAgICogTW9zdCBjYXNlcyBmbHVzaCBv biBlbnRyeSB0byBYZW4gYW55d2F5LiAgVGhlIG9uZSBjYXNlIHdoZXJlIHdl CisgICAgICAgICAqIGRvbid0IGlzIHdoZW4gdXNpbmcgdGhlIFNNRVAgb3B0 aW1pc2F0aW9uIGZvciBQViBndWVzdHMuICBGbHVzaGluZworICAgICAgICAg KiBiZWZvcmUgZ29pbmcgaWRsZSBpcyBsZXNzIG92ZXJoZWFkIHRoYW4gZmx1 c2hpbmcgb24gUFYgZW50cnkuCisgICAgICAgICAqLworICAgICAgICBpZiAo ICFvcHRfcnNiX3B2ICYmIGh3X3NtdF9lbmFibGVkICYmCisgICAgICAgICAg ICAgKGJvb3RfY3B1X2RhdGEueDg2X3ZlbmRvciAmIChYODZfVkVORE9SX0FN RHxYODZfVkVORE9SX0hZR09OKSkgJiYKKyAgICAgICAgICAgICAoYm9vdF9j cHVfZGF0YS54ODYgPT0gMHgxNyB8fCBib290X2NwdV9kYXRhLng4NiA9PSAw eDE4KSApCisgICAgICAgICAgICBzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9G RUFUVVJFX1NDX1JTQl9JRExFKTsKKyAgICB9CiAKICAgICBpZiAoIG9wdF9y c2JfcHYgKQogICAgIHsK --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Feb 14 18:38:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 18:38:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495545.765893 (Exim 4.92) (envelope-from ) id 1pS0CJ-0000NI-Hw; Tue, 14 Feb 2023 18:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495545.765893; Tue, 14 Feb 2023 18:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0CJ-0000NB-F9; Tue, 14 Feb 2023 18:38:35 +0000 Received: by outflank-mailman (input) for mailman id 495545; Tue, 14 Feb 2023 18:38:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0CI-0000N5-Eg for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 18:38:34 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6c48bd5-ac96-11ed-93b5-47a8fe42b414; Tue, 14 Feb 2023 19:38:31 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EHwtgr013252; Tue, 14 Feb 2023 18:38:27 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np1ede6au-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 18:38:27 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31EIE3qw003694; Tue, 14 Feb 2023 18:38:27 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f6fy47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 18:38:26 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SA2PR10MB4779.namprd10.prod.outlook.com (2603:10b6:806:11f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.8; Tue, 14 Feb 2023 18:38:24 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6111.010; Tue, 14 Feb 2023 18:38:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6c48bd5-ac96-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=VxfMkuL4owkU/1PHBmBq6P1aEjB7Gmv1i2aLnNMdP8k=; b=hgYJwvdwiejRsvMeFr3I9sV+hKcYleyj6rciZKfkuLD2WBzq03hzSL6Ng4IpaDBsRDpV n4snJ8FzaMLx6t7Qng2eSmUoof7hCL6JvGey96VaU+/8ESZnWBloyjDNCbU4OTSCQ9Uf 1e1yaVPgAxH5Ll05n5Xvfry2WeD80/VzgJHNkkAKT2tA2pgnchfN0sH+WAo242fo6iBc +0BivzT+8+LZCy71kjwzEUgEh2AXnIwNmiJ9N6M1uG0r67uKDVM5f1oOmxenRXzzJ7XW GVQMfzLzbU/UGj37S5fGQ87eWHU0oYSMsBRu1LB44qDCqDwISObn6qb0ZUmw59iH2Bt2 mQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPxfdw/IQNrvvyffXPUrMS+qKmqrA0ZmxBQGzu5JOHX7nqYGfwkVPmoRmGWvjPZPiz5JQvib3YaEvrqOyMvVWigXLI43HfnJzOud71e72cgKhZYhZK3VfcxBVXH/KyiuYbXfktKxtT2R0QgawSxHN16469ag30eA49RcxtKY4JKCzWo7suy7HxERcMP86t0Vv54wtYrFt+YzEDBr6SuumsVcn5D2QtPIm6A/eoAkEiHCVZ35DyFxE1oisu1u3tHzAf/No/n8SfwGwGJ942PVRy1AZV1yHFDzmcWFlfrzM0I0ZKblMY4YPhV21KV1L5wZm09+eLg7wZHXLb8c1a/6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VxfMkuL4owkU/1PHBmBq6P1aEjB7Gmv1i2aLnNMdP8k=; b=E7pFJ42CBRkIO6PsagnsxQ4HTIt9tBjYCZ7BX01Ci0sJd/KRfEZZXwf3rMLlicyfGHcn8/BdmOU/AYO1xhBVOmt0BDJ5hbzinhzC5kiDw6C2sEXBWbH5JdO7Af0177b6HD06KaHhVkRkRUwmnZ4XWLf0Nv7+8mDbdWQAoqnX6epIvixN16x5j58aq1tGvH73qfOPknVwZCNRHSDr12cqWCCF8Hc2T/9/NrRh9WZbpmBe2pF5E5aQ5W4c73sFzGL6B/Txz5tGd/Fq9JAq1EiBL3hjlsGg8AxcZfZPwVWMns1O1QIF2QIHDvA3aobhUOHqJst96AKMoU/3i9VwD2xxQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VxfMkuL4owkU/1PHBmBq6P1aEjB7Gmv1i2aLnNMdP8k=; b=OKKWwFULRj8NBvHhby9zDE3Ek6wp4YD6A4QwxLMBqAMzrtLmab6oWPGI6Y3ByG9NL4ew0rxHk7xmBzV3+MStdrBTTeHMOXqEhREZC8wWUNaV562kh1MZCF8CYJsKjd3FjdWeSVy0mFfRDuL9zkV+sUHp/+mAlmE2h74ez3auVgk= Message-ID: <88b3c98c-4383-ffc7-6e1a-2f7f37f49555@oracle.com> Date: Tue, 14 Feb 2023 13:38:20 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 From: Boris Ostrovsky Subject: Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xenia Ragiadakou , Wei Liu , George Dunlap , Paul Durrant , xen-devel@lists.xenproject.org References: <20230213145751.1047236-1-burzalodowa@gmail.com> <20230213145751.1047236-2-burzalodowa@gmail.com> <5c3eb593-b63f-303f-dcd8-f5c319152635@gmail.com> <3cdfde6f-5af6-4044-f786-259c70e0ba69@suse.com> <5892e7d6-bd08-0f2f-4dcb-fa5b9123a2eb@oracle.com> <342bb651-b0f8-8cbe-53ef-e4a292446224@suse.com> Content-Language: en-US In-Reply-To: <342bb651-b0f8-8cbe-53ef-e4a292446224@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR05CA0044.namprd05.prod.outlook.com (2603:10b6:208:236::13) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|SA2PR10MB4779:EE_ X-MS-Office365-Filtering-Correlation-Id: 547f1424-86e8-46e1-0a83-08db0ebaa6a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Btbn5m+fCMWonTQvH0CFB4AlQ/ZJPS5dCL6QLbswxss9Tm21en1lRjtTn8WmMP4R15dx9A030N94hMcsKEoNeLCI3FgfaIlP5L/Azpkkwo3ZK7Ixv237Ch20UIEVjsPKTRlX4fxMYBC9h7XpP6d5c5MDcXH/AQsfvFiT9ZVfbEsdmEuRAPxO6xb3WbRRpMqtx6ZI9nXgExdjuEDczun73r8szXiIEYh8oBCjMQZHLpPc+9j/kBNwQn5nxnv6zi6bNx7AQO8cSB0wLB8wNo3xo0rUIkwwHyk910J2gbdwNY/CwvrmUPSDIKKPcMpTk9y4Fh/c7+PFLOmr4v0lxDSnWTydFpJXw6FnMngpBrIustXPdEvLvERE/eaVecl+fLvZF0ygpJ1Al0aFXmqxwtwYUh0bpyzMkJCvSQQStBWo3LTD3jMID8FqgTpk3WGROsyTsuySMyXjxIzL2abG4B5Y6lumsRSz1ocRKi6ghOtxD0kA+BqiJS7DAogqwemo6fdPFQi64aAL1d064VR4IGegq2x+YrSoUe0wiqRdeZf5alm4dLIelLTtsgeCn/8+4zn4LxDILGxQZgOPoEfpR0PnNh8hfvPv1uWvw+ENVp3EG+j6NKZHNr6owT9ocEoib79UrWBT+hm0DKuDwYiFIWD2FXSXBJCmWR5rk2TXbf8YQDomFNz6f/C0ZgxefHvK1khJajC0GIEVzk9obWjIsd5P4iI3yTIQijNtkBHn7Xi6vaI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(39860400002)(376002)(396003)(346002)(451199018)(31696002)(8676002)(4326008)(66556008)(83380400001)(66946007)(54906003)(6916009)(316002)(41300700001)(66476007)(6512007)(53546011)(26005)(31686004)(6506007)(186003)(44832011)(8936002)(36756003)(86362001)(5660300002)(478600001)(2906002)(38100700002)(2616005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V09Yd25BK0JFZWViNkRDYld3amk1dXZFc3FSV24wM2U2bGROdTdnSCtuMGdI?= =?utf-8?B?SHlkNVowOElyaEIyZDZMVUFqNjBPSkdUcHByYkxNNlYzR2ZjY296UnZvcDNN?= =?utf-8?B?QlFDcGxGb3hMSG1sYVo1aGthakRVRHhsSWt6VEUva3JQL2E0d1M1ZlFXR0lk?= =?utf-8?B?M040NXVmL1pjVEZ5QUNUNGRlZlhFajVMcUduYmQ0WldtMVZ6dm1saVVIS2xB?= =?utf-8?B?RGF6dlgzM3Jra1pmMHpCYjRUaWhXTTR3QTB2dzlFMG9IQ0tVTzYvcFI1WXVK?= =?utf-8?B?TFJ4cWpLNTYzLzZTTmhXU2srbW9CQkk4czRJQVBqVUUySUZQa21IT3VPOFQr?= =?utf-8?B?K0x0U0dkRmpsU1VEWHhLZmRjU3VYQ3Jvc3FsNXJ6SERaa1ZRUFd3RzQ3c29I?= =?utf-8?B?UTAvTE9TWGhkaTVyNzhLak0zcVl1RENIdHBndDkrVDZheEgrOTdQdnd1TmdY?= =?utf-8?B?dVF2NnNlS2lmRE5nejJHTWVCTFgyTllLeHRodE1qcmhka3MrQ1NNdnlSVTgv?= =?utf-8?B?eExidkJ4azN0bTQ3TWxvbzdNVjNBMlpJdDV6NUtxU3FLT051UkpHMWh2WDJD?= =?utf-8?B?Vm5aQTFxWTJYaEUwd1d5b3Z2M1pIZ09na0FpWndvNUxEWitDSU9XRjRqdzJI?= =?utf-8?B?MzRuUk1Ud2w5T21pNkxMdVJBV3Z1UzJwVkpCSm9tbTBZUnBXOXVsa0pBWmh3?= =?utf-8?B?V0swVkRLdlRIdWtIQzVvZlhNQ0Y4UHc5K3dEUmxFMDdYRXFTaCt1RHlLbEZP?= =?utf-8?B?ZkJFTzFZS3A4bGRYc1hZTWc0WkJLSjV1dVJWclQ2aGlwei8rZUlaZU1mbkk0?= =?utf-8?B?OUxLN2dUTVNtRFN6TENMa0g4SUJvd1ppY05COFZHS0dvK0wxNk1xclpuZEZ5?= =?utf-8?B?SXZkMEN2YVNmaWZuUWZPaXZuUjNHSGoyZGMwQTdSc1JGTVdpVkg5dlpxOXVw?= =?utf-8?B?WWRYbFpmMS9ESy80RnVGUWZUU1NwbnphUEZhNDhEaWJGNDdVL1J1NkxRbjZ1?= =?utf-8?B?ZHFxclNSbUx4dC91UzBVSFppV053a0N1L3FjMHJka0E2c1hOYUoyMXVJOEJN?= =?utf-8?B?dWRQYklkR244M0FmRzd4eWhmWjd6VUp6N2lBWGZyWS9oZUpwS3YyS0VWNjJj?= =?utf-8?B?RklmMjNjcnZBQUFzRndGTmViRFRBYzRqaVltQ3ZTZTFDZUQ3azVieDh5NVpK?= =?utf-8?B?a2ZGbG5Ub21VTjFIRlNTaDFRZ1hwWnJoV3ZIZUxjOVZyWml4bEM1TjRUVkpD?= =?utf-8?B?V0pRNFVUVENRWk1HUGVJMHFSWmpXcnVjMGNWNi9uOGp5SElzV2V0eWsvdWph?= =?utf-8?B?UVFIVFlldnRzRUZ3NjBQUi96YkV5MU5DalNxZHJFdnFKYzF5RnhudWNzZldh?= =?utf-8?B?NVRWNDA5bmZuUDFDUjNHVzMvVWhOS1d2UmZHaEY1QmhFMzcvcEwzS2I4R25w?= =?utf-8?B?QnB3ZXNOc3h1MHRVbStqZXdycklxV0V5L1VUekZ2SkdKSjNMVHMxblJMMzZT?= =?utf-8?B?bTJDUVJMZDJJYm5xaXpUclg5TVN5OUdIZTlJSTJQdXNtSGFFK0xrbmtaOXl4?= =?utf-8?B?dklsSHFSQkJsdXBCa0xpb3hGT01UckNiOTNNcmhLZk1OM0lpZUVieGhPYXB2?= =?utf-8?B?L3BZT2tMbUQvTG9UdHhmVVd5VEx1cktzZGNGODhvZ2JKTy9qZis1a2FxT0dl?= =?utf-8?B?TVQ1bUJuc01FQXJjcmMwYXVTejEvb3NVZ1lza1dkaTc3OGhLTFZhbzZ1R1dJ?= =?utf-8?B?M0M2Vjc1cmhIMkhJL3Y5VFJzOGZjandveTU2Z094RGZqSnhidms4ZVIwbDBk?= =?utf-8?B?bm45eDFLOFpWL1hXMFNBaytmRldYeUYrNE54RURGMzNReHVsK3A3UzQ0cVEr?= =?utf-8?B?Q29hUll0TTNWSThLL0UvbzBaWi92TDUvd09tWHRVVHUzc0E4VGtnQTF3RkQz?= =?utf-8?B?Zno4QVhCdHEwZ3ZUeHFUcG5LQ3RoSndVK3R2dUYxZXlxZ2tzVFMvcnI2aHVx?= =?utf-8?B?RGdROFgybVVBSWFCNEJpK0tLZmJ2V2wwdytkZ1daVE9ydVVKeWJ2N1pNKzl5?= =?utf-8?B?S0EzOUVtd3p6ejBvRHhIUFlmZXJCbjF4alRqWlNpckE0dVkraUlwVFdFM3Fs?= =?utf-8?B?OTVQcFByS1JMdFVySUs3aldEQ29TQkRrRDVBU2xZM0hOZ3Iyd2l6MExRWnZ0?= =?utf-8?B?YlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hk/DXZWElPC70y8ejIX+Bo+TamrpRwd2NYnpp64a5jk+0Kr2465GpC0QJ14ZnLl9xmbD+QCQaf8EEoxPDqJft7joGVUY3PupFjPPX5L9pCEPp3p/7sEPIpONB9BExtmPeLfb/kYNSsI4plPsCZB9CP1amkgse+MJdTlObFv7H8emIQkznQYqRddFHne0U9rp5s33B/wKWRoyG7KkPZq65+qW2c8fkTFexLGj6w3P+j2J0KHUqiYpAyzqFCiHpD5GBxRk9EysOIPq16piHpYlXEBXjb3QWbV9NuXw+2UZw4Q/3TV16IoiuUdjyYRZ+4Dc3weQCkjZt65xlbqEWC/1JyM1RveSbJGy1WCmm0MM3tNI2ZtdncqhfWjW+oU6grjGD3QH5K5ZjH7PELf+Bft8JOn09J6YRL29yiaeXuXlHxfp+QJEdMn9HLvWce77bZaKS7wSzJz9lRzH9ASYZKPg3/j61ArAnKuM1ogo788NwmyqT4+2af0mqxtoTlD4Kdd1sPQcECGJqmLhdDXS1mLxWen4a3+OhtlN8C2xfOnFRDjrLlsCRtyXwm6gJTJIQi4dzGzbTkykIIUIs5TndOZEAO8gxT4DZiooQ8DHFLniankVlasVbS+dQObeapCoWs1HbbtKMCrENkAWGjNqb8mSjG7ydz1QurftXth8XxVPPZB/F6TfJzv0ZFBaxwnCDZCO44+F2+nEsD5rDfPbrN5/Q0Mt1LTjg5J1YUtOKKfD0VvtlFUPsP+TnudjPHZ1g2p3LBNau4qG5+AnSLM3M/IfZUGq1raCc1JEJL5DS+c2fzhmK1fP6tNGbN9nWdCWtdxsP3fRVp4RKXV54J/0eKy3taojC1Ik6ykrla0PdGCej4r+3gMX+LSNb9OdF2BhA61j X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 547f1424-86e8-46e1-0a83-08db0ebaa6a9 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 18:38:22.8358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OCH09zrVNkZH2iX6MHBJVe5d70rIafCEfAbupADvKfgpIxJX18lPRiArhJQJIn/P+4dUmeIsIFzPaXTimP+0MWZZbwWK7mevMIgbrjFFG+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4779 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_13,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140161 X-Proofpoint-GUID: fIZQ5WFnycEKNkMsxOwNIZWrRreMfI6s X-Proofpoint-ORIG-GUID: fIZQ5WFnycEKNkMsxOwNIZWrRreMfI6s On 2/14/23 2:48 AM, Jan Beulich wrote: > On 13.02.2023 21:53, Boris Ostrovsky wrote: >> On 2/13/23 11:41 AM, Jan Beulich wrote: >>> On 13.02.2023 17:30, Xenia Ragiadakou wrote: >>>> On 2/13/23 17:11, Jan Beulich wrote: >>>>> On 13.02.2023 15:57, Xenia Ragiadakou wrote: >>>>>> --- a/xen/arch/x86/cpu/Makefile >>>>>> +++ b/xen/arch/x86/cpu/Makefile >>>>>> @@ -10,4 +10,6 @@ obj-y += intel.o >>>>>> obj-y += intel_cacheinfo.o >>>>>> obj-y += mwait-idle.o >>>>>> obj-y += shanghai.o >>>>>> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o >>>>>> +obj-y += vpmu.o >>>>>> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o >>>>>> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o >>>>> This code was moved from hvm/ to cpu/ for the specific reason of also >>>>> being used by PV guests. (Sadly the comments at the top weren't >>>>> corrected at that time.) >>>> Hmm, the init functions are prefixed with svm/vmx. >>>> Does vpmu depend on svm/vmx support? >>> There are interactions, but I don't think there's a dependency. You >>> may want to ask Boris (whom I have now added to Cc). >> MSR intercept bits need to be manipulated, which is SVM/VMX-specific. > But that's "interaction", not "dependency" aiui: The intercept bits aren't > relevant for PV guests, are they? Correct, they are not. All accesses to intercept bits are under is_hvm_vcpu(). So vpmu does not depend on presence of vmx/svm support. (And init routines shouldn't be prefixed with those) -boris From xen-devel-bounces@lists.xenproject.org Tue Feb 14 18:48:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 18:48:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495553.765904 (Exim 4.92) (envelope-from ) id 1pS0M4-0002BP-Gf; Tue, 14 Feb 2023 18:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495553.765904; Tue, 14 Feb 2023 18:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0M4-0002BI-DT; Tue, 14 Feb 2023 18:48:40 +0000 Received: by outflank-mailman (input) for mailman id 495553; Tue, 14 Feb 2023 18:48:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0M2-0002B8-VL; Tue, 14 Feb 2023 18:48:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0M2-0008GV-SH; Tue, 14 Feb 2023 18:48:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0M2-0002GZ-DO; Tue, 14 Feb 2023 18:48:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pS0M2-0003vo-Cv; Tue, 14 Feb 2023 18:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H6VNZJgx+rU/DlFDf9KP/tRkQ6F3TvKch74utrTj8Vw=; b=R8fEpLBPSUxMbQKOq57djqPt6O nCt/+iHtO8ruXOPEmvULo2oGjjpv/HUIr9NUk1T2rlDjIsq7Yx21b7+ZJn+ktdCxChJE9zs/sWpoi o9Ehjogn4/3Me6B4ZVrdwlkcBXQoOdh6ef0edlsgX9WTzNn9vdycqhWtGHFuhMZv4qBY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177271: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 X-Osstest-Versions-That: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 From: osstest service owner Date: Tue, 14 Feb 2023 18:48:38 +0000 flight 177271 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177271/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177229 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177229 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177229 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177229 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177229 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177229 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177229 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177229 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177229 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 baseline version: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 Last test of basis 177271 2023-02-14 11:20:41 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Feb 14 19:04:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 19:04:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495573.765915 (Exim 4.92) (envelope-from ) id 1pS0bd-00057M-0o; Tue, 14 Feb 2023 19:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495573.765915; Tue, 14 Feb 2023 19:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0bc-00057F-To; Tue, 14 Feb 2023 19:04:44 +0000 Received: by outflank-mailman (input) for mailman id 495573; Tue, 14 Feb 2023 19:04:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS0bb-000577-DO for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 19:04:43 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ff554c9-ac9a-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 20:04:42 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id lf10so10657197ejc.5 for ; Tue, 14 Feb 2023 11:04:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ff554c9-ac9a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=+PIpU7Z2jqm/15Iq1kV1McY54hb16Oom8P9IvSW0h1Q=; b=gCbaPSeHBbcVM6E4S7IM0m7UNhsdNhqaLPN7zgGSQHNrjFingah3lDlN7CBOoSCJsU e17D2oYmX/lvMq9dCqKy6uceED4TU0lDVtRhASwZ8H0qFjAUaSFJhY49LWrDyuPXz+yl PmnIpAyYSwhtJyT4RXEY5H9jlZ1REld42Ynzanp5KKyE6JosgnKfcKusiZYgvSFCP9af IXLuF5RQesa+Du5wWTfApmpGyjrp5a1A3RxwlvFljkiqBz5JmYutviyavK1mgOaOOePI u5D7CFVhVwZ6hoIFBpR6+oPFEVq0F7DRXYeckkZhOwljUjbPzdyU2vUT2baRc4nHgU2N henA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+PIpU7Z2jqm/15Iq1kV1McY54hb16Oom8P9IvSW0h1Q=; b=JVENwsnEMJ0sRyxPmfOTnDwcTdGewWt55SqC/730QJchzZhlRBmLGXvueJXg+mAhI1 ddzrq2DvGPiSsl9+SjbG00fZefsv5NMx5R+MDrL3D4RKaBbBu2pAJxgZromUMuobI17+ is3KSPr7QBiplux71cL8eWImrh/hPlnqA9dLTRRTcjnKRkiTvXb+ZfSpL+vESYWWgL+g 38mCroxxqGyQBNinnJXLL6jraSn+R0L15YZYn9xWFkB4/svIol+fVMgDjsnKDYpZr0wo q1RjvtUdN7QpKSZl1LyQXlYAWGwFe7DML+e/fzkjUzjWZZj6+fYRDiUE4vLkVR26JMsH /dtw== X-Gm-Message-State: AO0yUKU7HtJ6G1xgI+rQl+sg6+fyadopNb/ZMLJjD9KNsh+hb9/OAIGp iLxK0HsOMN5c/50UDuW9Ds0msFX+Ou1AG4neu4+ZSM5PqIs= X-Google-Smtp-Source: AK7set8Xx6IyiSP8d9Ahpa9XJbemIwzp5IqmpI1YDwtwUvUuXDk3v2NrWX3fyVrpcnbQictIpEGq6DhnVdYKmQicryY= X-Received: by 2002:a17:906:8591:b0:8af:43c6:10bb with SMTP id v17-20020a170906859100b008af43c610bbmr1682191ejx.14.1676401480942; Tue, 14 Feb 2023 11:04:40 -0800 (PST) MIME-Version: 1.0 From: Jason Andryuk Date: Tue, 14 Feb 2023 14:04:28 -0500 Message-ID: Subject: HWP and ACPI workarounds To: xen-devel Content-Type: text/plain; charset="UTF-8" Hi, Qubes recently incorporated my HWP patches, but there was a report of a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking up during boot when HWP is enabled. A user found a kernel bug that seems to be the same issue: https://bugzilla.kernel.org/show_bug.cgi?id=110941. That bug was fixed by Linux commit a21211672c9a ("ACPI / processor: Request native thermal interrupt handling via _OSC"). The commit message has a good summary of the issue and is included at the end of this message. The tl;dr is SMM crashes when it receives thermal interrupts, so Linux calls the ACPI _OSC method to take over interrupt handling. Today, Linux calls the _OSC method when boot_cpu_has(X86_FEATURE_HWP), but that is not exposed to the PV Dom0. As a test, the Qubes user was able to boot with the check expanded to `boot_cpu_has(X86_FEATURE_HWP) || xen_initial_domain()`. We need some way for Xen to indicate the presence and/or use of HWP to Dom0, and Dom0 needs to use that to call _OSC. My first idea is that Dom0 could query Xen's cpufreq driver. However, Xen exposes the cpufreq driver through the unstable sysctl ops, and using an unstable hypercall seems wrong for the kernel. Can we add something to an existing hypercall - maybe platform_op? Or do we need a new stable hypercall? Linux will perform the _OSC calls unilaterally upon seeing FEATURE_HWP and independent of actually using HWP via the intel_pstate driver. However, not using HWP may be an untested configuration in practice. The intel_pstate.c driver will not use HWP when FEATURE_HWP_EPP is not found. So we could potentially cheat and expose only HWP to Dom0. That should trigger the _OSC calls without letting Dom0 think it can use HWP. This is rather fragile though, so a more explicity method seems better. Roger's ACPI Processor patches that add xen_sanitize_pdc calls could be leveraged. On the Xen side, arch_acpi_set_pdc_bits() could be extended to set bit 12, which would then be passed to the evaluate _PDC call. _PDC is the older interface superseded by _OSC, but they can be wrappers around the same implementation. But if linux is just using _OSC, it seems more compatible to follow that implementation. Thoughts? Thanks, Jason commit a21211672c9a1d730a39aa65d4a5b3414700adfb Author: Srinivas Pandruvada Date: Wed Mar 23 21:07:39 2016 -0700 ACPI / processor: Request native thermal interrupt handling via _OSC There are several reports of freeze on enabling HWP (Hardware PStates) feature on Skylake-based systems by the Intel P-states driver. The root cause is identified as the HWP interrupts causing BIOS code to freeze. HWP interrupts use the thermal LVT which can be handled by Linux natively, but on the affected Skylake-based systems SMM will respond to it by default. This is a problem for several reasons: - On the affected systems the SMM thermal LVT handler is broken (it will crash when invoked) and a BIOS update is necessary to fix it. - With thermal interrupt handled in SMM we lose all of the reporting features of the arch/x86/kernel/cpu/mcheck/therm_throt driver. - Some thermal drivers like x86-package-temp depend on the thermal threshold interrupts signaled via the thermal LVT. - The HWP interrupts are useful for debugging and tuning performance (if the kernel can handle them). The native handling of thermal interrupts needs to be enabled because of that. This requires some way to tell SMM that the OS can handle thermal interrupts. That can be done by using _OSC/_PDC in processor scope very early during ACPI initialization. The meaning of _OSC/_PDC bit 12 in processor scope is whether or not the OS supports native handling of interrupts for Collaborative Processor Performance Control (CPPC) notifications. Since on HWP-capable systems CPPC is a firmware interface to HWP, setting this bit effectively tells the firmware that the OS will handle thermal interrupts natively going forward. For details on _OSC/_PDC refer to: http://www.intel.com/content/www/us/en/standards/processor-vendor-specific-acpi-specification.html To implement the _OSC/_PDC handshake as described, introduce a new function, acpi_early_processor_osc(), that walks the ACPI namespace looking for ACPI processor objects and invokes _OSC for them with bit 12 in the capabilities buffer set and terminates the namespace walk on the first success. Also modify intel_thermal_interrupt() to clear HWP status bits in the HWP_STATUS MSR to acknowledge HWP interrupts (which prevents them from firing continuously). From xen-devel-bounces@lists.xenproject.org Tue Feb 14 20:28:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 20:28:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495583.765926 (Exim 4.92) (envelope-from ) id 1pS1tm-0006gF-UZ; Tue, 14 Feb 2023 20:27:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495583.765926; Tue, 14 Feb 2023 20:27:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS1tm-0006g8-Qd; Tue, 14 Feb 2023 20:27:34 +0000 Received: by outflank-mailman (input) for mailman id 495583; Tue, 14 Feb 2023 20:27:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS1tm-0006fy-2r; Tue, 14 Feb 2023 20:27:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS1tm-0002Ho-15; Tue, 14 Feb 2023 20:27:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS1tl-0008Ic-Mh; Tue, 14 Feb 2023 20:27:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pS1tl-0007dS-MG; Tue, 14 Feb 2023 20:27:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HGhxXopJkl1g8J+0gDJ47RexkORqseL0o6UfN3XP7ZI=; b=ywQBh/Bsv8HIaprJWQTUfhuMZr VVqbFoisJvf5wgVeyiWd+McK2awqdWVZus33hZqMKxshJirMuQ8y2LX3yFHyeMNPXpdDsTLjpp7NX 4J6fydouOrkm8mRiXhReRIv7KGRxiyYtBMdGRvJNfopn7HiUzLVd3aQU3sqXzYIPd7uY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177305: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=63305e5392ec2d17b85e7996a97462744425db80 X-Osstest-Versions-That: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 From: osstest service owner Date: Tue, 14 Feb 2023 20:27:33 +0000 flight 177305 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177305/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 63305e5392ec2d17b85e7996a97462744425db80 baseline version: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 Last test of basis 177187 2023-02-13 16:01:58 Z 1 days Testing same since 177305 2023-02-14 19:03:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9b70bc6d96..63305e5392 63305e5392ec2d17b85e7996a97462744425db80 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 14 22:25:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 22:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495593.765937 (Exim 4.92) (envelope-from ) id 1pS3k0-0004NX-Dk; Tue, 14 Feb 2023 22:25:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495593.765937; Tue, 14 Feb 2023 22:25:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS3k0-0004NQ-AE; Tue, 14 Feb 2023 22:25:36 +0000 Received: by outflank-mailman (input) for mailman id 495593; Tue, 14 Feb 2023 22:25:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS3jz-0004NG-09 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 22:25:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e00cd9d-acb6-11ed-933c-83870f6b2ba8; Tue, 14 Feb 2023 23:25:33 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3AE4361937; Tue, 14 Feb 2023 22:25:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39FFAC433EF; Tue, 14 Feb 2023 22:25:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e00cd9d-acb6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676413530; bh=7NFfVDI72T27LvlvJp/EOq8RRDqEW1nSI1jeM0wJ26M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eIYDXIIIs2NRU33fK8C7rir3SXF4GY17v5fuHm8wrBTmd8SgFYCPKk1ZNYFdOXcMr chMdZSfAYrqx9RsZzYgGbVCd0XAqBppVlTlAEa9rHCqNniC2djmwjQ0qxHXvrNATwc xhOx5uERUDBlMmC/22hPuxpaV8IDU8SIo3iKBxyAvrxnjdCK050uuqNrjBG6Exl0BQ NOX78A3GSCGYsWMtPwmprEysbr9EivGBUzXOQ17N+HMv3cG2zalAO+FFnXWG/DKQwi XodnUNqOP1g7kjwHBv8XCcB1yfPSpucTGUS9Wx4yt/pqn4aczxopOZLYd2lMPscMVu 4bI4qN99Nk6dA== Date: Tue, 14 Feb 2023 14:25:27 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Luca Fancellu , wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json In-Reply-To: Message-ID: References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Jan Beulich wrote: > On 14.02.2023 09:56, Luca Fancellu wrote: > > --- a/docs/misra/exclude-list.json > > +++ b/docs/misra/exclude-list.json > > @@ -1,4 +1,209 @@ > > { > > "version": "1.0", > > - "content": [] > > + "content": [ > > + { > > + "rel_path": "arch/arm/arm64/cpufeature.c" > > + }, > > + { > > + "rel_path": "arch/arm/arm64/insn.c" > > + }, > > + { > > + "rel_path": "arch/arm/arm64/lib/find_next_bit.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/boot.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/cpu_idle.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/cpufreq/cpufreq.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/cpuidle_menu.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/lib.c" > > + }, > > + { > > + "rel_path": "arch/x86/acpi/power.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/amd.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/centaur.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/common.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/hygon.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/intel.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/intel_cacheinfo.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/mcheck/mce-apei.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/mcheck/non-fatal.c" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/mtrr/*" > > + }, > > + { > > + "rel_path": "arch/x86/cpu/mwait-idle.c" > > + }, > > + { > > + "rel_path": "arch/x86/delay.c" > > + }, > > + { > > + "rel_path": "arch/x86/dmi_scan.c" > > + }, > > + { > > + "rel_path": "arch/x86/domain.c" > > + }, > > + { > > + "rel_path": "arch/x86/genapic/*" > > + }, > > + { > > + "rel_path": "arch/x86/i387.c" > > + }, > > + { > > + "rel_path": "arch/x86/irq.c" > > + }, > > + { > > + "rel_path": "arch/x86/mpparse.c" > > + }, > > + { > > + "rel_path": "arch/x86/srat.c" > > + }, > > + { > > + "rel_path": "arch/x86/time.c" > > + }, > > + { > > + "rel_path": "arch/x86/traps.c" > > + }, > > + { > > + "rel_path": "arch/x86/usercopy.c" > > + }, > > + { > > + "rel_path": "arch/x86/x86_64/mmconf-fam10h.c" > > + }, > > + { > > + "rel_path": "common/bitmap.c" > > + }, > > + { > > + "rel_path": "common/bunzip2.c" > > + }, > > + { > > + "rel_path": "common/cpu.c" > > + }, > > + { > > + "rel_path": "common/earlycpio.c" > > + }, > > + { > > + "rel_path": "common/inflate.c" > > + }, > > + { > > + "rel_path": "common/libfdt/*" > > + }, > > + { > > + "rel_path": "common/lz4/decompress.c" > > + }, > > + { > > + "rel_path": "common/notifier.c" > > + }, > > + { > > + "rel_path": "common/radix-tree.c" > > + }, > > + { > > + "rel_path": "common/rcupdate.c" > > + }, > > + { > > + "rel_path": "common/softirq.c" > > + }, > > + { > > + "rel_path": "common/tasklet.c" > > + }, > > + { > > + "rel_path": "common/ubsan/ubsan.c" > > + }, > > + { > > + "rel_path": "common/un*.c" > > + }, > > + { > > + "rel_path": "common/vsprintf.c" > > + }, > > + { > > + "rel_path": "common/xz/*" > > + }, > > + { > > + "rel_path": "common/zstd/*" > > + }, > > + { > > + "rel_path": "crypto/rijndael.c" > > + }, > > + { > > + "rel_path": "crypto/vmac.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/apei/*" > > + }, > > + { > > + "rel_path": "drivers/acpi/hwregs.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/numa.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/osl.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/reboot.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/tables.c" > > + }, > > + { > > + "rel_path": "drivers/acpi/tables/*" > > + }, > > + { > > + "rel_path": "drivers/acpi/utilities/*" > > + }, > > + { > > + "rel_path": "drivers/char/ehci-dbgp.c" > > + }, > > + { > > + "rel_path": "drivers/char/xhci-dbc.c" > > + }, > > + { > > + "rel_path": "drivers/cpufreq/*" > > + }, > > + { > > + "rel_path": "drivers/video/font_*" > > + }, > > + { > > + "rel_path": "lib/list-sort.c" > > + }, > > + { > > + "rel_path": "lib/mem*.c" > > + }, > > + { > > + "rel_path": "lib/rbtree.c" > > + }, > > + { > > + "rel_path": "lib/str*.c" > > + }, > > + { > > + "rel_path": "lib/xxhash32.c" > > + }, > > + { > > + "rel_path": "lib/xxhash64.c" > > + } > > + ] > > } > > Patch 1's example has a "comment" field, which no entry makes use of. > Without that, how does it become clear _why_ a particular file is to > be excluded? The patch description here also doesn't provide any > justification ... It would be good to have a couple of pre-canned justifications as the reason for excluding one file could be different from the reason for excluding another file. Some of the reasons: - imported from Linux - too many false positives That said, we don't necessarily need to know the exact reason for excluding one file to be able to start scanning xen with cppcheck automatically. If someone wants to remove a file from the exclude list in the future they just need to show that cppcheck does a good job at scanning the file and we can handle the number of violations. I take that with this exclude list, not accounting for rule 20.7, cppcheck reports zero violations overall? From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:20:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:20:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495600.765948 (Exim 4.92) (envelope-from ) id 1pS4aZ-0002b5-8l; Tue, 14 Feb 2023 23:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495600.765948; Tue, 14 Feb 2023 23:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4aZ-0002ay-5s; Tue, 14 Feb 2023 23:19:55 +0000 Received: by outflank-mailman (input) for mailman id 495600; Tue, 14 Feb 2023 23:19:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4aY-0002aq-Eq for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:19:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10577463-acbe-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 00:19:51 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E829B6194D; Tue, 14 Feb 2023 23:19:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84322C433D2; Tue, 14 Feb 2023 23:19:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10577463-acbe-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676416781; bh=Mp62uhTPJWNACpVdBtbuSRreZI0BhK90COKIax8rGiA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=qkOO67MnJmuBxGKAh0fE+vlpj/W9+Solll4cZn463ijZYeOevcs8wpMwYBk73Exqr zq9dslcL9cf3Bw6o1EgZfkVOrwo3d9hpgSMnc+lc88HMMR3UTNs1G4rRpKGji8xZDM w016kRz7yJYa6iKjRAOY504PnoeS2Zva2QbWuyyde/OC/Qs1dukNngcvBH80lzs7gm GIFEQvD/WrTpxIGzTNxlmeRyV1qU9+bQSWB8r4VhgFjyu4xXwjdq3JywdMj1LnwBLs daOD5i8MnKMXj9uB9jKx5QqkBvggzqOX2Uev3Tl1ZKJv9X4Lw7Xluk1WuKhHi89ZFT iIsrgBwbRoYhw== Date: Tue, 14 Feb 2023 15:19:38 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , andrew.cooper3@citrix.com Subject: Re: [PATCH v2 1/5] automation: Switch arm32 cross builds to run on arm64 In-Reply-To: <20230214153842.15637-2-michal.orzel@amd.com> Message-ID: References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > Due to the limited x86 CI resources slowing down the whole pipeline, > switch the arm32 cross builds to be executed on arm64 which is much more > capable. For that, rename the existing debian container dockerfile > from unstable-arm32-gcc to unstable-arm64v8-arm32-gcc and use > arm64v8/debian:unstable as an image. Note, that we cannot use the same > container name as we have to keep the backwards compatibility. > Take the opportunity to remove extra empty line at the end of a file. > > Modify the tag of .arm32-cross-build-tmpl to arm64 and update the build > jobs accordingly. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - new patch > > For convenience and own testing, I built and pushed the new container > to registry. Thanks! > --- > ...ockerfile => unstable-arm64v8-arm32-gcc.dockerfile} | 3 +-- > automation/gitlab-ci/build.yaml | 10 +++++----- > 2 files changed, 6 insertions(+), 7 deletions(-) > rename automation/build/debian/{unstable-arm32-gcc.dockerfile => unstable-arm64v8-arm32-gcc.dockerfile} (94%) > > diff --git a/automation/build/debian/unstable-arm32-gcc.dockerfile b/automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile > similarity index 94% > rename from automation/build/debian/unstable-arm32-gcc.dockerfile > rename to automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile > index b41a57f19729..11860425a6a2 100644 > --- a/automation/build/debian/unstable-arm32-gcc.dockerfile > +++ b/automation/build/debian/unstable-arm64v8-arm32-gcc.dockerfile > @@ -1,4 +1,4 @@ > -FROM debian:unstable > +FROM arm64v8/debian:unstable > LABEL maintainer.name="The Xen Project" \ > maintainer.email="xen-devel@lists.xenproject.org" > > @@ -21,4 +21,3 @@ RUN apt-get update && \ > apt-get autoremove -y && \ > apt-get clean && \ > rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > - > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a053c5c7325d..f8e156e0a994 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -123,7 +123,7 @@ > variables: > XEN_TARGET_ARCH: arm32 > tags: > - - x86_64 > + - arm64 > > .arm32-cross-build: > extends: .arm32-cross-build-tmpl > @@ -542,26 +542,26 @@ alpine-3.12-clang-debug: > debian-unstable-gcc-arm32: > extends: .gcc-arm32-cross-build > variables: > - CONTAINER: debian:unstable-arm32-gcc > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > HYPERVISOR_ONLY: y > > debian-unstable-gcc-arm32-debug: > extends: .gcc-arm32-cross-build-debug > variables: > - CONTAINER: debian:unstable-arm32-gcc > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > HYPERVISOR_ONLY: y > > debian-unstable-gcc-arm32-randconfig: > extends: .gcc-arm32-cross-build > variables: > - CONTAINER: debian:unstable-arm32-gcc > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > HYPERVISOR_ONLY: y > RANDCONFIG: y > > debian-unstable-gcc-arm32-debug-randconfig: > extends: .gcc-arm32-cross-build-debug > variables: > - CONTAINER: debian:unstable-arm32-gcc > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > HYPERVISOR_ONLY: y > RANDCONFIG: y > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:21:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495605.765959 (Exim 4.92) (envelope-from ) id 1pS4bs-0003ya-JQ; Tue, 14 Feb 2023 23:21:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495605.765959; Tue, 14 Feb 2023 23:21:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4bs-0003yT-G0; Tue, 14 Feb 2023 23:21:16 +0000 Received: by outflank-mailman (input) for mailman id 495605; Tue, 14 Feb 2023 23:21:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4br-0003yL-Rx for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:21:15 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44ab93bb-acbe-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 00:21:13 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB10561927; Tue, 14 Feb 2023 23:21:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F596C433EF; Tue, 14 Feb 2023 23:21:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44ab93bb-acbe-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676416870; bh=0qqE7oiJV/VyZ7TSj9Pra0jyKRbtVA+Pd9pms+lpVMM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fRrQG7Xqqa3XU9mspn0ZN+h+2RR6hhaZwyROIfQjBd9zelEIRlxuglRflP7129R6m IbuFfz0bp4C/bmG4H70pzP2/+oF6uMMjF/8AG20VdnaHTeM7Pt4Gg/JZchdEugGf3p GXtWA1vKllnooh5J1biZCXOO97kW+Y5+Njh0iRIzlVtWMCFNC/RZB8amskBogLwpkz Buyr1t3rXmqNAUGc44vhaDwk27heG8MO2eHBXq4+PkhNJiErWn8Jr/xRmUtX99iQfr N/XvNrYYwk9qkGOVHxN2XWr7wmpxJnclBUtngJLG/sNhpQT/RJmUQoDE3eVJXyO+hM k+mOCA3MfGwQA== Date: Tue, 14 Feb 2023 15:21:08 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 2/5] automation: Add arm32 dom0less testing In-Reply-To: <20230214153842.15637-3-michal.orzel@amd.com> Message-ID: References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > At the moment, we only perform a single arm32 test in our CI, checking > whether dom0 boots successfully or not. This is mostly because we do not > have any arm32 runners and we only execute a hypervisor only build. > > In order not to leave the arm32 testing in such a poor state, add a > script qemu-smoke-dom0less-arm32.sh to start testing dom0less > configuration, while keeping dom0 to make the test more interesting. > > The script is mostly based on the one used for dom0 arm32 testing as well > as the one used for dom0less arm64 testing. We obtain Debian Bullseye > kernel and Alpine Linux busybox-based rootfs. Depending on the test > variant, we prepare a test case contained within domU_check variable, > that will be executed as part of /init script from domU rootfs. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - keep dom0 around by default to make tests more interesting > --- > automation/gitlab-ci/test.yaml | 16 +++ > .../scripts/qemu-smoke-dom0less-arm32.sh | 99 +++++++++++++++++++ > 2 files changed, 115 insertions(+) > create mode 100755 automation/scripts/qemu-smoke-dom0less-arm32.sh > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index ce543ef5c0ef..84ab1fee50a4 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -210,6 +210,22 @@ qemu-smoke-dom0-arm32-gcc-debug: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > > +qemu-smoke-dom0less-arm32-gcc: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32 > + > +qemu-smoke-dom0less-arm32-gcc-debug: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > new file mode 100755 > index 000000000000..e3f2b28f3f89 > --- /dev/null > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -0,0 +1,99 @@ > +#!/bin/bash > + > +set -ex > + > +test_variant=$1 > + > +# Prompt to grep for to check if dom0 booted successfully > +dom0_prompt="^/ #" > + > +cd binaries > +# Use the kernel from Debian > +curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz > +# Use a tiny initrd based on busybox from Alpine Linux > +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz > + > +if [ -z "${test_variant}" ]; then > + passed="generic test passed" > + domU_check=" > +echo \"${passed}\" > +" > +fi > + > +# dom0/domU rootfs > +# We are using the same rootfs for dom0 and domU. The only difference is > +# that for the former, we set explictly rdinit to /bin/sh, whereas for the > +# latter we rely on using custom /init script with test case inside. > +mkdir rootfs > +cd rootfs > +tar xvzf ../initrd.tar.gz > +echo "#!/bin/sh > + > +mount -t proc proc /proc > +mount -t sysfs sysfs /sys > +mount -t devtmpfs devtmpfs /dev > +${domU_check} > +/bin/sh" > init > +chmod +x init > +find . | cpio -H newc -o | gzip > ../initrd.gz > +cd .. > + > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > +./qemu-system-arm \ > + -machine virt \ > + -machine virtualization=true \ > + -smp 4 \ > + -m 2048 \ > + -serial stdio \ > + -monitor none \ > + -display none \ > + -machine dumpdtb=virt.dtb > + > +# ImageBuilder > +echo 'MEMORY_START="0x40000000" > +MEMORY_END="0xC0000000" > + > +DEVICE_TREE="virt.dtb" > +XEN="xen" > +XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" > + > +DOM0_KERNEL="vmlinuz" > +DOM0_RAMDISK="initrd.gz" > +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" > + > +DOMU_KERNEL[0]="vmlinuz" > +DOMU_RAMDISK[0]="initrd.gz" > +DOMU_MEM[0]="512" > +NUM_DOMUS=1 > + > +LOAD_CMD="tftpb" > +BOOT_CMD="bootm" > +UBOOT_SOURCE="boot.source" > +UBOOT_SCRIPT="boot.scr"' > config > + > +rm -rf imagebuilder > +git clone https://gitlab.com/ViryaOS/imagebuilder > +bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > + > +# Run the test > +rm -f smoke.serial > +set +e > +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ > +timeout -k 1 240 \ > +./qemu-system-arm \ > + -machine virt \ > + -machine virtualization=true \ > + -smp 4 \ > + -m 2048 \ > + -serial stdio \ > + -monitor none \ > + -display none \ > + -no-reboot \ > + -device virtio-net-pci,netdev=n0 \ > + -netdev user,id=n0,tftp=./ \ > + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial > + > +set -e > +(grep -q "${dom0_prompt}" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 > +exit 0 > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:22:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495613.765970 (Exim 4.92) (envelope-from ) id 1pS4cf-0004aF-18; Tue, 14 Feb 2023 23:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495613.765970; Tue, 14 Feb 2023 23:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4ce-0004a8-TZ; Tue, 14 Feb 2023 23:22:04 +0000 Received: by outflank-mailman (input) for mailman id 495613; Tue, 14 Feb 2023 23:22:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4cd-0003yL-3m for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:22:03 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62f160bb-acbe-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 00:22:02 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CF7E4B81E9A; Tue, 14 Feb 2023 23:22:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F11C8C433EF; Tue, 14 Feb 2023 23:21:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62f160bb-acbe-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676416920; bh=nPyJql4QNTJm7KNH0jPKRMdPZGiUK5xbF8Yei2iby6A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=qKDASw/JuWOQB20+Sm9bf+EE/W3HBCBzaHhXGfdqCjR+59qf6x5y1fXyjeRPJ+ACy RUVCndBai2V53rLbcTEE5KATKkRkFAqiiEghf724TYWFVQt9TKnltfSOg/48Sfqvu3 a3QWgs0kQKxtFQNgBUi2nEQBhonkeJMMBUc32LcxiSPVaQRntAfUpOIvz7xVuY6N4T p5ldcGwSd2V/eiXGDUAJtbNYpTg+kVYBusg9REgUxlRicH7PTc2NkXC1RVqdEKoePJ LWqjYQ6q0y11iInwGGo6015ZGGfqqSmGGzokqisrW6cwM2/TW9UDy43qw+vcXNTAGD 4Ej7O4wh7I08w== Date: Tue, 14 Feb 2023 15:21:58 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 3/5] automation: Add a static memory allocation test on arm32 In-Reply-To: <20230214153842.15637-4-michal.orzel@amd.com> Message-ID: References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-4-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug > and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh > script to test static memory allocation feature. The test case itself > is directly taken from dom0less arm64 testing. > > Populate build jobs to compile Xen with config options necessary to > enable static memory feature. Populate test jobs passing "static-mem" > as a test variant. The test configures domU with a static memory region > (direct-mapped) and adds a check using /proc/iomem to determine the > memory region marked as "System RAM". > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - take into account new container for arm32 cross builds > - drop Rb as a result of code changes > --- > automation/gitlab-ci/build.yaml | 20 +++++++++++++++++++ > automation/gitlab-ci/test.yaml | 16 +++++++++++++++ > .../scripts/qemu-smoke-dom0less-arm32.sh | 17 ++++++++++++++++ > 3 files changed, 53 insertions(+) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index f8e156e0a994..079e9b73f659 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig: > HYPERVISOR_ONLY: y > RANDCONFIG: y > > +debian-unstable-gcc-arm32-staticmem: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > + HYPERVISOR_ONLY: y > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > +debian-unstable-gcc-arm32-debug-staticmem: > + extends: .gcc-arm32-cross-build-debug > + variables: > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > + HYPERVISOR_ONLY: y > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y > + > # Arm builds > > debian-unstable-gcc-arm64: > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 84ab1fee50a4..c2bcc5d4d3e5 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -226,6 +226,22 @@ qemu-smoke-dom0less-arm32-gcc-debug: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > > +qemu-smoke-dom0less-arm32-gcc-staticmem: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-staticmem > + > +qemu-smoke-dom0less-arm32-gcc-debug-staticmem: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh static-mem 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug-staticmem > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > index e3f2b28f3f89..bd89a3f8b45e 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -20,6 +20,19 @@ echo \"${passed}\" > " > fi > > +if [[ "${test_variant}" == "static-mem" ]]; then > + # Memory range that is statically allocated to domU1 > + domu_base="0x50000000" > + domu_size="0x20000000" > + passed="${test_variant} test passed" > + domU_check=" > +mem_range=$(printf \"%08x-%08x\" ${domu_base} $(( ${domu_base} + ${domu_size} - 1 ))) > +if grep -q -x \"\${mem_range} : System RAM\" /proc/iomem; then > + echo \"${passed}\" > +fi > +" > +fi > + > # dom0/domU rootfs > # We are using the same rootfs for dom0 and domU. The only difference is > # that for the former, we set explictly rdinit to /bin/sh, whereas for the > @@ -72,6 +85,10 @@ BOOT_CMD="bootm" > UBOOT_SOURCE="boot.source" > UBOOT_SCRIPT="boot.scr"' > config > > +if [[ "${test_variant}" == "static-mem" ]]; then > + echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:22:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:22:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495617.765981 (Exim 4.92) (envelope-from ) id 1pS4d4-00054F-7a; Tue, 14 Feb 2023 23:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495617.765981; Tue, 14 Feb 2023 23:22:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4d4-000546-4m; Tue, 14 Feb 2023 23:22:30 +0000 Received: by outflank-mailman (input) for mailman id 495617; Tue, 14 Feb 2023 23:22:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4d2-0004UA-KQ for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:22:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70cbca1c-acbe-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 00:22:26 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EACF6194D; Tue, 14 Feb 2023 23:22:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E844BC433EF; Tue, 14 Feb 2023 23:22:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70cbca1c-acbe-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676416944; bh=QhDrj1PmCcmZPwKVipGefL51808RwRvE4NjD85r5vCs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NaZutr/vYWYzsl3FYUwKv2yk9A8leUKDCE7CgPi/nuvYROKcc8KuH01dDjCm2elXB GKHquDWs+rQO/rS8sFkfe64UR1x7+TX7eeNAUzkvjcfd0gcoJDAhUG0TU8VR4xCn8I m/i4c/I5z6neBWIlYvxFn8lF/KmhvGdxNOlOx7p5ITT/McPbwTBmE1tmbtAafO7ZfN f5OIod1FxLzpfp+OOc8sYwgh9ePWunJGmGEs5M3i+DmxBx3V1Yjji6GIi5N2YdqVa/ jBNJBMiCVuJHEiWwGH5PiKATNLcpWH4oy/PiwmFkHoVh6nxlD2M+KwyZilKUg2V21v JATpN3Uy3GLJw== Date: Tue, 14 Feb 2023 15:22:22 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 4/5] automation: Add a gzip compressed kernel image test on arm32 In-Reply-To: <20230214153842.15637-5-michal.orzel@amd.com> Message-ID: References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-5-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > Xen supports booting gzip compressed kernels, therefore add a new test > job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant > that will execute qemu-smoke-dom0less-arm32.sh script to test booting > a domU with a gzip compressed kernel image (in our case zImage). > > By passing "gzip" as a test variant, the test will call gzip command > to compress kernel image and use it in ImageBuilder configuration for > domU1. No need for a specific check to be executed from domU. Being able > to see a test message from a boot log is sufficient to mark a test as > passed. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - take into account dom0 presence > - drop Rb as a result of code changes > --- > automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ > automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index c2bcc5d4d3e5..be7a55d89708 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -242,6 +242,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-staticmem: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug-staticmem > > +qemu-smoke-dom0less-arm32-gcc-gzip: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32 > + > +qemu-smoke-dom0less-arm32-gcc-debug-gzip: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh gzip 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > index bd89a3f8b45e..c2e331451d99 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -33,6 +33,15 @@ fi > " > fi > > +if [[ "${test_variant}" == "gzip" ]]; then > + # Compress kernel image with gzip (keep unmodified one for dom0) > + gzip -k vmlinuz > + passed="${test_variant} test passed" > + domU_check=" > +echo \"${passed}\" > +" > +fi > + > # dom0/domU rootfs > # We are using the same rootfs for dom0 and domU. The only difference is > # that for the former, we set explictly rdinit to /bin/sh, whereas for the > @@ -89,6 +98,10 @@ if [[ "${test_variant}" == "static-mem" ]]; then > echo -e "\nDOMU_STATIC_MEM[0]=\"${domu_base} ${domu_size}\"" >> config > fi > > +if [[ "${test_variant}" == "gzip" ]]; then > + sed -i 's/DOMU_KERNEL\[0\]=.*/DOMU_KERNEL\[0\]="vmlinuz.gz"/' config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:23:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495625.765992 (Exim 4.92) (envelope-from ) id 1pS4dd-0005fs-H4; Tue, 14 Feb 2023 23:23:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495625.765992; Tue, 14 Feb 2023 23:23:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4dd-0005fl-Dx; Tue, 14 Feb 2023 23:23:05 +0000 Received: by outflank-mailman (input) for mailman id 495625; Tue, 14 Feb 2023 23:23:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4dc-0004UA-U0 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:23:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86c6f12c-acbe-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 00:23:03 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04AFB6194D; Tue, 14 Feb 2023 23:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2104C433D2; Tue, 14 Feb 2023 23:23:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86c6f12c-acbe-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676416981; bh=s6wk/3seb66+sZc+hM/vwsMrMJYnfsQI8s3Yjk4sFb8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kH1B8RF9MlXuJ4sokl9aI21q9OZYG+ZxzSQai4+cV80ZryVnUXswYYr3aHd+YJvQK bjWvlvgbdcZaUHmi06YSy1c2CFCj2bcfxRjgNTKj68mIA9O0HwWJEjqx6vSHaM8DhW zH/HRElqzxoViCIqNhokVzdTI2buzdCcq4kIPnaJkEvJpLwDlxNwgYb1BbYNqZH/p7 wolMVmaRHpZDZG3+55cprA/ctPTo2DeSus6JpEDZtKk6xUomOwdvEoCHbdU8LRWrOu SC24kjfubBFr39c/knBZupOSbHrw9k/c2x18MSF+ESAMN4aQw7EaqVYBjdR9RqUA8i FqVsHQrXb+a8g== Date: Tue, 14 Feb 2023 15:22:59 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 5/5] automation: Add a true dom0less test on arm32 In-Reply-To: <20230214153842.15637-6-michal.orzel@amd.com> Message-ID: References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-6-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > Add a new test job qemu-smoke-dom0less-arm32-gcc-without-dom0 in debug > and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh > script to test dom0less domU boot without dom0 (i.e. true dom0less > configuration). > > By passing "without-dom0" as a test variant, the test will clear the > dom0 prompt that we grep for as a last step and remove all the DOM0 > related options in ImageBuilder configuration. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - new patch created as a result of deciding to keep dom0 by default. We still > need to test true dom0less configuration, hence added a new test. > --- > automation/gitlab-ci/test.yaml | 16 ++++++++++++++++ > automation/scripts/qemu-smoke-dom0less-arm32.sh | 13 +++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index be7a55d89708..c0b4a90e0d29 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -258,6 +258,22 @@ qemu-smoke-dom0less-arm32-gcc-debug-gzip: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > > +qemu-smoke-dom0less-arm32-gcc-without-dom0: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh without-dom0 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32 > + > +qemu-smoke-dom0less-arm32-gcc-debug-without-dom0: > + extends: .qemu-arm32 > + script: > + - ./automation/scripts/qemu-smoke-dom0less-arm32.sh without-dom0 2>&1 | tee ${LOGFILE} > + needs: > + - *arm32-test-needs > + - debian-unstable-gcc-arm32-debug > + > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > script: > diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh > index c2e331451d99..cc91238f4222 100755 > --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh > @@ -42,6 +42,15 @@ echo \"${passed}\" > " > fi > > +if [[ "${test_variant}" == "without-dom0" ]]; then > + # Clear dom0 prompt > + dom0_prompt="" > + passed="${test_variant} test passed" > + domU_check=" > +echo \"${passed}\" > +" > +fi > + > # dom0/domU rootfs > # We are using the same rootfs for dom0 and domU. The only difference is > # that for the former, we set explictly rdinit to /bin/sh, whereas for the > @@ -102,6 +111,10 @@ if [[ "${test_variant}" == "gzip" ]]; then > sed -i 's/DOMU_KERNEL\[0\]=.*/DOMU_KERNEL\[0\]="vmlinuz.gz"/' config > fi > > +if [[ "${test_variant}" == "without-dom0" ]]; then > + sed -i '/^DOM0/d' config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:26:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:26:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495631.766003 (Exim 4.92) (envelope-from ) id 1pS4ga-0006PG-Vd; Tue, 14 Feb 2023 23:26:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495631.766003; Tue, 14 Feb 2023 23:26:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4ga-0006P9-Se; Tue, 14 Feb 2023 23:26:08 +0000 Received: by outflank-mailman (input) for mailman id 495631; Tue, 14 Feb 2023 23:26:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4gZ-0006P3-SF for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:26:07 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f36e302d-acbe-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 00:26:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 908CDCE22E1; Tue, 14 Feb 2023 23:26:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47CA7C433EF; Tue, 14 Feb 2023 23:26:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f36e302d-acbe-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676417161; bh=nUvcyiJlKmZkMgK5GqF5FKbuAwgp/PxaYQIA5L+m3is=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kXsZfIO6iEHL/5RZFreDBsH0xXbUXXx4Vs5o1FFqm1QKTprIcyFpMpJfatU0BkkLE WhNIxJUghrqdKHBE8TWZ7sruynGh1CsfPD1lGD1MGtYunYVITYMMzKuFWz2rtVHfi5 DeN8qO11N2/hgwQS7uxvl/uD+jiNf3l3VqytPHo0CZ7tX1GIk5c6S5lAymZdW9FT6T tlNft+MFhZ3FesFuGFs+ZDTImhULmuLAbXQD2N6OAP1nrQtetFkbh9Q5hXp+Q5G279 dSPSVjd9bFGUwc9lwSjWxA5clQhh4MgWVeZQKPYazRt2ae64l04YZUmdYMfCO6saLc cpeZlDz5Zv9gw== Date: Tue, 14 Feb 2023 15:25:59 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2] automation: Add container and build jobs to run cppcheck analysis In-Reply-To: <20230214153945.15719-1-michal.orzel@amd.com> Message-ID: References: <20230214153945.15719-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Michal Orzel wrote: > Add a debian container with cppcheck installation routine inside, > capable of performing cppcheck analysis on Xen-only build including > cross-builds for arm32 and x86_64. > > Populate build jobs making use of that container to run cppcheck > analysis to produce a text report (xen-cppcheck.txt) containing the list > of all the findings. > > This patch does not aim at performing any sort of bisection. Cppcheck is > imperfect and for now, our goal is to at least be aware of its reports, > so that we can compare them with the ones produced by better tools and > to be able to see how these reports change as a result of further > infrastructure improvements (e.g. exception list, rules exclusion). > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - use arm64 container instead of x86 to make pipeline faster > - explicitly set HYPERVISOR_ONLY=y for cppcheck jobs > > For convenience and own testing, I built and pushed the new container > to registry. CI pipeline including dom0less series: > https://gitlab.com/xen-project/people/morzel/xen-orzelmichal/-/pipelines/777181033 > --- > .../build/debian/unstable-cppcheck.dockerfile | 37 ++++++++++++++++ > automation/gitlab-ci/build.yaml | 43 +++++++++++++++++++ > automation/scripts/build | 11 ++++- > 3 files changed, 90 insertions(+), 1 deletion(-) > create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile > > diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile > new file mode 100644 > index 000000000000..54b99f87dfec > --- /dev/null > +++ b/automation/build/debian/unstable-cppcheck.dockerfile > @@ -0,0 +1,37 @@ > +FROM arm64v8/debian:unstable > +LABEL maintainer.name="The Xen Project" \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV CPPCHECK_VERSION=2.7 > +ENV USER root > + > +RUN mkdir /build > +WORKDIR /build > + > +# dependencies for cppcheck and Xen-only build/cross-build > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + build-essential \ > + curl \ > + python-is-python3 \ > + libpcre3-dev \ > + flex \ > + bison \ > + gcc-arm-linux-gnueabihf \ > + gcc-x86-64-linux-gnu > + > +# cppcheck release build (see cppcheck readme.md) > +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ > + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ > + cd cppcheck-"$CPPCHECK_VERSION" && \ > + make install -j$(nproc) \ > + MATCHCOMPILER=yes \ > + FILESDIR=/usr/share/cppcheck \ > + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" > + > +# clean > +RUN apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* && \ > + rm -rf cppcheck-"$CPPCHECK_VERSION"* "$CPPCHECK_VERSION".tar.gz > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 079e9b73f659..1441b7dbb6fa 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -7,6 +7,7 @@ > paths: > - binaries/ > - xen-config > + - xen-cppcheck.txt > - '*.log' > - '*/*.log' > when: always > @@ -199,6 +200,23 @@ > variables: > <<: *gcc > > +.x86-64-cross-build-tmpl: > + <<: *build > + variables: > + XEN_TARGET_ARCH: x86_64 > + tags: > + - arm64 > + > +.x86-64-cross-build: > + extends: .x86-64-cross-build-tmpl > + variables: > + debug: n > + > +.gcc-x86-64-cross-build: > + extends: .x86-64-cross-build > + variables: > + <<: *gcc > + > # Jobs below this line > > archlinux-gcc: > @@ -699,6 +717,31 @@ archlinux-current-gcc-riscv64-debug-randconfig: > EXTRA_FIXED_RANDCONFIG: > CONFIG_COVERAGE=n > > +# Cppcheck analysis jobs > + > +debian-unstable-gcc-cppcheck: > + extends: .gcc-x86-64-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/x86_64-linux-gnu- > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > +debian-unstable-gcc-arm32-cppcheck: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > +debian-unstable-gcc-arm64-cppcheck: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > ## Test artifacts common > > .test-jobs-artifact-common: > diff --git a/automation/scripts/build b/automation/scripts/build > index f2f5e55bc04f..7d1b19c4250d 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -38,7 +38,16 @@ cp xen/.config xen-config > # Directory for the artefacts to be dumped into > mkdir binaries > > -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > +if [[ "${CPPCHECK}" == "y" ]] && [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > + # Cppcheck analysis invokes Xen-only build. > + # Known limitation: cppcheck generates inconsistent reports when running > + # in parallel mode, therefore do not specify -j. > + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra > + > + # Preserve artefacts > + cp xen/xen binaries/xen > + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt > +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > # Xen-only build > make -j$(nproc) xen > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:39:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:39:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495639.766014 (Exim 4.92) (envelope-from ) id 1pS4tI-0008GV-4a; Tue, 14 Feb 2023 23:39:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495639.766014; Tue, 14 Feb 2023 23:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4tI-0008GO-1X; Tue, 14 Feb 2023 23:39:16 +0000 Received: by outflank-mailman (input) for mailman id 495639; Tue, 14 Feb 2023 23:39:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS4tG-0008Fx-DR for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:39:14 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c78406e9-acc0-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 00:39:11 +0100 (CET) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EKUNAC021206; Tue, 14 Feb 2023 23:38:46 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3nr8b2jhv2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Feb 2023 23:38:46 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AM9PR03MB6977.eurprd03.prod.outlook.com (2603:10a6:20b:2d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 23:38:42 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 23:38:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c78406e9-acc0-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtBQ0aZuK49I4t4i5AX9AtoBppeZ9LgOXW21Txzfn0fjJCnHj3mLtDKQ7sHe/K2AXUK8kadfsfbUrdHVLUoVNNKoRwcsV5TJ1w7Xt9Enm8GIv140fBgB+H4JYNSf8dD76RKPOxysttkrBJSzp2Y8Z4xFZ7WcbzeXZ4jXUcIx32eAWzpPC/7Chp/BftyR2hJXp5MTxdDJyQzvHXFRO3WD3rPm9IoU2+WelsAfpr2shF4+oWRNa8coVQHtBM8/dhfuLH+a4G3LeCPdn5EyTpEAic9g9a+kdnnGMNIvvHnf0X9KamR3knPcpLHagLGVFjnpQWwLY1wZWw+9OOFOeg8vYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SGv4HB7UbsPLmaPOZhI9GR/eHKTekYVXWtSt/9CNtTA=; b=obcTDvsfuPYj13W3WTZSFUxX3w3kXJxANXTriE4tOS2VNzoLR5YyM8UP2cAaHvQIrg62zDdVMX8F0E1T4/IAc3fYAXGv/omjnYJ2970AkuYIOMf6+3iVC2gTJfoXxDUCr0ubwOjTBe+KqkCKo3guKPZMoSmThzG3ACsp6BFQA1rJ3wesrKU0cRdoGzH7x3QJ5Q2UIuHbTIDB9eRYcGLZGc3ycfxYs6HKXD6skdd4fosHqiiZfdwMq3suGp0P65lCPPBGqQ6oMp4f4Nk+IyyUijNan6Itk3oPaCkqA9ey0ObYUhwGUxzjurSBkOiwwDwLdIf/Ae4wX9xhOBqPajEmCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGv4HB7UbsPLmaPOZhI9GR/eHKTekYVXWtSt/9CNtTA=; b=aU0fzNOwG5cNL+P7Eu5+82Atn1E5u9O5CzAKDXKfWlggEohKxFU9J/BfJOKKIvGQbC6hEJlgOGvoNq55UOWlilc6OfP4uzlAr8Cg28YM35S7CwLo77PvKe1sFi9bciNmwm1uquU8CdaI8pI6H0J9MOrkrDO/p+mtiaH6LjoAKaWmZqYa4iErkzZ8ub7DwN7enJ16AKWpYidO3PjhklnLCVxSsP9/cSlGDkCdIR2UHA0zK5P/8Q+9YtUMxznHf+zcxOUeIa85Izw+Z95IlS9S+ImnSYVI56Bp8ZAeHoc3+CVu6GSWOcHkqIzFWJi07ZL7uPvhz0jR2gk/FAnKuB3lLg== From: Volodymyr Babchuk To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Paul Durrant , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Kevin Tian , "Stewart.Hildebrand@amd.com" Subject: Re: [RFC PATCH 01/10] xen: pci: add per-domain pci list lock Thread-Topic: [RFC PATCH 01/10] xen: pci: add per-domain pci list lock Thread-Index: AQHYvUN+sHWq0w//vE+eH46Zd/aTJ66yPm0AgB3Z5oA= Date: Tue, 14 Feb 2023 23:38:41 +0000 Message-ID: <87cz6b3ji7.fsf@hp.mail-host-address-is-not-set> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-2-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AM9PR03MB6977:EE_ x-ms-office365-filtering-correlation-id: fd19b9b0-c039-43a0-5dfd-08db0ee49ae7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r7MZcFyFTOsJeQAKLc+OFOpdyRkOKR+HkHHz2VZhi+QweP306sFRUfPk4ajC9JA0uuepJWlUN4CiV+x/5X/ZkNolVLj6KCslTP1bMNoRY/ENWAFEF6KCKeHRC0vOhx0v4iypE18R7KwfLLbqeAFzAgsn5zj3ZfXEpEqw3puecPcPBRWaug+tigDTx2mtIA451U30tmP0G7bbjymagitO+RBS0a8wrDA/DJELL0RMNl0/hdhNqX73FfrkaLOh1t8Bbg5Lv+KxOSRyYBJzDc+rdZ6avphrJ2ORfpeU8nMNjkXExXeueUodQLXJF6CZdx/rEFkmDt3Bt21QF0YLtMLwhnIOaBvzC6wQcxJ7+lkSLcp0bdh3nq2wu29qaq8DfH06KMhiGG6TRfIrfjqyYTTpjE2Pvk89zv+xHADdt+u7HyDm35NBIbpHjiSGdc8oOBi7Dbb6giIdjPIE5iDjTv6dEu1ivHPXdp5Wklj+05XAzguly4gbHtvO4tCKzdapbAQ6gmAwG3zIcTN50SI/ttZBphRSazkqrZtI3nqDHExrSgGJHhKAJGwAVQ2Fq92pYhPBb/IzTUa1UhkQO09LujVviVepBtwVGyZbj8pqIhBUGHMn6ZVS9zaKf81EOhrZ9uKiE5I3vz6TXdWMjtjU3n71yFBhe0SnIusFxLuIndyjZrhlf+uOw2aku+N4YrYfXEkPlIpmCVyCquh0jOsar+2Mbg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199018)(186003)(6512007)(316002)(9686003)(26005)(6506007)(6486002)(76116006)(66946007)(66476007)(8676002)(66446008)(91956017)(6916009)(4326008)(478600001)(64756008)(83380400001)(66556008)(71200400001)(54906003)(55236004)(41300700001)(2906002)(8936002)(5660300002)(7416002)(122000001)(38100700002)(86362001)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?588yj3+4xo87Fan2lC0y6BDJBUxDXziNJfKWO/nBSaVQP4u/39YRARi+SS?= =?iso-8859-1?Q?gESd6cfXmPIv8HrnUc6rWf56oMqzXRVZzeXo6FE4AxLLqFwdDhJft4uidC?= =?iso-8859-1?Q?MBX+8y+YfNFvQIH/OOK3+hXKK4rPqMK9AzYyxLEEHUJhFBm36WZxJrAKji?= =?iso-8859-1?Q?0rh+RcX4vHQGdlXGNhZXfYyV3YdgBH7yggUiT5s5kPImUbAVEAGu28YX2u?= =?iso-8859-1?Q?QXMVgVG3OBaft2uWh7eA5i/Szta6Wvjw0rrBtu7p5SvQO5X4tC7dn2sdL3?= =?iso-8859-1?Q?VhW/LVRFDL5mOe+S8PBctFUvNep070BElWA3peAGvleL88g9bfisTiGD/N?= =?iso-8859-1?Q?yQ4BKHtoO0QZAbnZzzr2RrrwEeiT3MWD1da7YYYNhPTWes4UmlC+UnxH8i?= =?iso-8859-1?Q?I9Fk+isC3DP/nhuIokX9ucRXwcV9C+DSq18AkrEq24T0psIRd9U1X6Fj/x?= =?iso-8859-1?Q?iDGBtf+48Gb64ScCIoWB13mXEntM8jpFD0rboIQGdTl7dFZ52KFxXs8C2x?= =?iso-8859-1?Q?fhZZ9x1/6GiQ4J8uPSBQ3GPdw58L8KPHMi6deGcuAQ1VcdMY8H9Qf/s+oh?= =?iso-8859-1?Q?U36yLTAFy3Od5S8g5umO+96n9Ro6Jn4Hntk/5DPvB2spkbUFe1fFujsj0u?= =?iso-8859-1?Q?A7Tvcv6z5ZMQ0zg8uC3cau6mrvzMyRamH+ZLvJ3q73RCAoobHDaC1eoFgj?= =?iso-8859-1?Q?i0cYMN0hUxUBeOxysZb/M330l8ciPbijJcQLahyu6hSGgUiuRwM2MJQ8oF?= =?iso-8859-1?Q?XShp8VBGTjT5pmaJdnsduXdMDe8zrdVO98fy4grd7TUOIY5CWnNo0g8TuB?= =?iso-8859-1?Q?NMrBn8b1wGKazvTPiWw8OwIxeMdOe91ASjqlZN3BnyiwMvDAjx9oaC5dOg?= =?iso-8859-1?Q?HD1QvRodPWmWSPYCiOFY2IUZtZQAKAvGLFEMHrkHSTSYVGD7HyXnfH2si5?= =?iso-8859-1?Q?/EM2WXfmOoH6+VqOXCXct9NJTaenROB1780t839I5BKANeFNPRIkmUO/k2?= =?iso-8859-1?Q?nX4fVu2EsAJF6MQupjCwBFb/U4xgIljr57K+E654q+nCX4MPTPlqlsbwHO?= =?iso-8859-1?Q?HuHqwahYXYygD1j01zFfP9BkGJHl2y6/SxbKypXF/C017pMyAAmJacVG/7?= =?iso-8859-1?Q?msMH6R5Hdcdc6NITQDxs1I7CE8nU4hRm8YhsBP9QFFNTG5S50/J9/WjjGv?= =?iso-8859-1?Q?Cu3gDv+kQI6G5ALoHyF8ahEhvActHpna97xec/OZwFbdYfDy1DwE8gKNyr?= =?iso-8859-1?Q?jJgbR/YPLX13zBF4oqVr6r/Bi3/RqxkJryOvg+R7kN9ZDtUgz6kqDt8j08?= =?iso-8859-1?Q?xa2y1KmSzwJMZj5uh+BKU/5i/Fq+paW4ojO9JhomdRhAwgXqU7G/f9YNPu?= =?iso-8859-1?Q?+UjhFzqVoFq/naC2rSA/TOX6YfHrDU0ntcwY5U6Y6VxQrfS5ZtL63x4Ifq?= =?iso-8859-1?Q?9cO4lY32HnnxahAzM8vRN7k0r59UYUd7a4OQyIGVTDWde1QG9vkV+ZNMot?= =?iso-8859-1?Q?zeXgLdqE9N5pXOpyM45pgmgvL3nUWwVXndGxu0lfKaoM5YbByHVR8cFjIj?= =?iso-8859-1?Q?3TmoAt7/RlGtBu1NK7NpwFs8819N/EQEgTaaciCwYT5zQ9/hTaVrhV/JEo?= =?iso-8859-1?Q?M4NT8RS3In5JEsT2d6gHTOS2Oka2bXhfzPXvsW90e/E8CPhZC9ZIZ3Hg?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd19b9b0-c039-43a0-5dfd-08db0ee49ae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 23:38:41.6618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: juqhJB+k09Ha0ibgpZcrn2sfXY3Rc0kmcc7rg19luV0U5X+s4ESbVquOF6XxP9r0EdrkdusxOEkHGRsK3Byjk3wtcJkJTg0QE4UoO3PsY7c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6977 X-Proofpoint-GUID: 0vv8Tn8rfNtI9AkIeyGqPXGfdAsut9TL X-Proofpoint-ORIG-GUID: 0vv8Tn8rfNtI9AkIeyGqPXGfdAsut9TL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_15,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 clxscore=1011 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140203 Hello Stefano, Stefano Stabellini writes: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> domain->pdevs_lock protects access to domain->pdev_list. >> As this, it should be used when we are adding, removing on enumerating >> PCI devices assigned to a domain. >>=20 >> This enables more granular locking instead of one huge pcidevs_lock that >> locks entire PCI subsystem. Please note that pcidevs_lock() is still >> used, we are going to remove it in subsequent patches. >>=20 >> Signed-off-by: Volodymyr Babchuk > > I reviewed the patch, and made sure to pay extra attention to: Thank you for doing this. > - error paths > - missing locks > - lock ordering > - interruptions > Here is what I found: > > > 1) iommu.c:reassign_device_ownership and pci_amd_iommu.c:reassign_device > Both functions without any pdevs_lock locking do: > list_move(&pdev->domain_list, &target->pdev_list); > > It seems to be it would need pdevs_lock. Maybe we need to change > list_move into list_del (protected by the pdevs_lock of the old domain) > and list_add (protected by the pdev_lock of the new domain). Yes, I did as you suggested. But this leads to another potential issue. I'll describe it below, in deassign_device() part. [...] >> + spin_lock(&d->pdevs_lock); >> list_for_each_entry_safe ( pdev, tmp, &d->pdev_list, domain_list ) >> { >> bus =3D pdev->bus; >> devfn =3D pdev->devfn; >> ret =3D deassign_device(d, pdev->seg, bus, devfn) ?: ret; > > This causes pdevs_lock to be taken twice. deassign_device also takes a > pdevs_lock. Probably we need to change all the > spin_lock(&d->pdevs_lock) into spin_lock_recursive. You are right, I missed that deassign_device() causes iommu*_reassign_device() call. But there lies the issue: with recursive locks, reassign_device() will not be able to unlock source->pdevs_lock, but will try to take target->pdevs_lock also. This potentially might lead to deadlock, if another call to reassign_device() moves some other pdev in the opposite way at the same time. This is why I want to avoid recursive spinlocks if possible. So, I am thinking: why does IOMMU code move a pdev across domains in the first place? We are making IOMMU driver responsible of managing domain's pdevs, which does not look right, as this is the responsibility of pci.c I want to propose another approach: implement deassign_device() function in IOMMU drivers. Then, instead of calling to reassign_device() we might do the following: 1. deassign_device() 2. remove pdev from source->pdev_list 3. add pdef to target->pdev_list 4. assign_device() [...] >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 1cf629e7ec..0775228ba9 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -457,6 +457,7 @@ struct domain >> =20 >> #ifdef CONFIG_HAS_PCI >> struct list_head pdev_list; >> + spinlock_t pdevs_lock; > > I think it would be better called "pdev_lock" but OK either way As Jan pointed out, we are locking devices as in plural. On other hand, I c= an rename pdev_list to pdevs_lists to make this consistent. > > >> #endif >> =20 >> #ifdef CONFIG_HAS_PASSTHROUGH >> --=20 >> 2.36.1 >>=20 From xen-devel-bounces@lists.xenproject.org Tue Feb 14 23:53:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 14 Feb 2023 23:53:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495647.766025 (Exim 4.92) (envelope-from ) id 1pS57C-0002gR-Ed; Tue, 14 Feb 2023 23:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495647.766025; Tue, 14 Feb 2023 23:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS57C-0002gK-By; Tue, 14 Feb 2023 23:53:38 +0000 Received: by outflank-mailman (input) for mailman id 495647; Tue, 14 Feb 2023 23:53:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS57A-0002gA-76 for xen-devel@lists.xenproject.org; Tue, 14 Feb 2023 23:53:36 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c99080b9-acc2-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 00:53:34 +0100 (CET) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EL4f7u011874; Tue, 14 Feb 2023 23:53:31 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np2w9xwr4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 23:53:31 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31ELnVAU016845; Tue, 14 Feb 2023 23:53:29 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f6bh94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Feb 2023 23:53:29 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MW4PR10MB5883.namprd10.prod.outlook.com (2603:10b6:303:18f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.10; Tue, 14 Feb 2023 23:53:28 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6111.010; Tue, 14 Feb 2023 23:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c99080b9-acc2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=k/C632FvearAKr5zLZcpmc22IeiMcKenmPUIyo4mnxo=; b=DTSdlYUYMRjh37soRC3VqKW6o6tP4OCQ8/qiiTgDgyDPy5YnqQ3l1z4zpUlcsyZY3sgn JEmmcg/B+wAZ+ZHUhQv3tnGzacfZknJE+gsnn6wXzaMGb1Ch9bJKRFS1w6+ZoOksl6Hx W4mVnrn2hkd0Agd/SAmlw/MYvJrVDrBBUNEVKrkz1/LlNi8QcUhSY/bAiZc+JPplG9ai UWI5o4iLnBildzg9ht7rPv3TzSewhOejdSHhHXLyce5/EXq8oC8/+hj+FER8eFY+G0CT wWrrRRUNHxr7kZ24/EJm029FnvmRWNZgok624PveUnwKYyHoltxoJ2Lki36TfAk5xmgZ tA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jj6SQlFb0sQsAjQMUR5A/5mTtaLqQcpNymPASci34N7tUpUuu7CbrW29ba9y+6bMp+/ONt+iZhb4/vDO/TvNc20XlpOzlo/jT/JsCZfse0Md5IvgFztRgrMn/rbJY5peNVa/lP2ekhs3Ths6dOLoZX4t7a7VECTkreLHUa30ch/GHVQSC4TuCM/pQo5DB1lPGsVoaUk5NYhf9077+F2pAdPNcL5ojx7Cwhh06YhgXwl5tiF+eauDTBRIADCRHybhs+RnnTQE0tgCm1QcDa7QBBLJDUo/MamIH+FhpOLXpy0dFzE3wUdtolLy2C6+vrw+oyHU7BeAwkgZNq+2uHDHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k/C632FvearAKr5zLZcpmc22IeiMcKenmPUIyo4mnxo=; b=X13HGCPg9nk5DIuXhgwbxmk0bJhsWB0dyOifxaJntNIEIfnv2fMQ4/E17r0i0DrAlnhMVid3+IfQxalDhdThZq//QADlgvaQVZ6uVeXPQhAyxus50Bj46KAi6Aiw6rzgg69/BUOI/9Mana8ydWKZQdYQR06lnHdkTpk3tB5rOQgXAVge1dJoP2PmpQRBepYMiP5yXdbHxFsCHMKrzx7MehbaoOxB6OZdQTB8W9m/DsQFyZWG7A9o01oW6/z+lELdRtwFiTA3p9JhDcWteVSzjPOnXB3XVy9oWyxiZmv2Yq9PjOivq3qUaiIHZgCZJt9VnjMShm+jaI3t6cKqZNbgxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k/C632FvearAKr5zLZcpmc22IeiMcKenmPUIyo4mnxo=; b=f+MNmFBaW1b83Lr5bHMv2lB1w1nTmdS4336Kkdw97oy5Yfs2LB95wQEvWLQxpYzru8POxcPaJ3k6n6iaegKQRM3fYWqPASHvnk+vY03dPMf2plwnbNzxgWXfZoxnKL8DrDp4S+oRwsviuKiYrBpF2oQ5UaHZtSCdCCqFAnMo31k= Message-ID: Date: Tue, 14 Feb 2023 18:53:23 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Juergen Gross References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist In-Reply-To: <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9P223CA0026.NAMP223.PROD.OUTLOOK.COM (2603:10b6:806:26::31) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|MW4PR10MB5883:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d5fa955-ab8c-4272-845a-08db0ee6aa77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JBRZG+brj7Dvu1BFFx5Pv+BQoXTh2ulUhbNNPLsDSPULuD/07XJwaUgUCfffc4xicuTe8NOVOLlXntczxdKdc7mdN7N6oJCOC8M+nBuOjotEcHl+yFObCnDlycgMWJypIOM5Y7OuYtb5TsC4bL3GnMM6kXyfW81XTPiRoXjLoQb5zV+RkQvUSqOutI1iynSq7crv0IFKYX4oaApm2z8M5qZeloolMjd2cgA3vrWY2xpIoUX/7H0+7MiR/JfHBq+2pVPm7VDCxhHRuR9hNlok66mCSkBkzqqASuhXJJflihiHb8FjjUXIeyHUqWKEA5WVIMPxzWRa/CqI5l+wvg3EJ9KvYTo2J0/hIbAZgseSng0Y1Zd/EzG7eIlbsNzQcB2ewl7noAkjSpTOrCrwK8QdBXZcVf+ERu1yplpW9mKSEdJ7SZ8F2U6Z4trrEIIyLs9Gcyo6LqVj8knZSOqf8IlAa05q31FXL9Bck4uH859nzmMzSYcZjSUAA88UDwJDOENdn7pxECUO03dF8edTpjRDsJOuHdWGeO3mJZOTjAGBK+RFaUaBDLzdyTsjE63bcCHGX7kfj7MfZ2uY/mTrPhoY+fELU9XM0HC/o5aYaQqYY6c1TS6USldbvByI0An3CX7pVyZKSIu/Vxuem0zo0rC3GxHOJ9Xp7KUhqA3lFi56TE/30jVvTCjy1fU2RcC1mDnNDILiZ/Q3rDqkTIQTBFoEDDQg7u7HDdSHqgNO2Nboc8U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199018)(8936002)(31686004)(6506007)(36756003)(41300700001)(2906002)(38100700002)(31696002)(66946007)(86362001)(66476007)(8676002)(66556008)(5660300002)(6486002)(478600001)(2616005)(186003)(316002)(54906003)(4326008)(4744005)(6512007)(6666004)(110136005)(53546011)(44832011)(83380400001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVpZcGtIdXAxY3NickkwSDk5dzBCV3dOek1TZEIrb1diZ2xWQmRtanBHOHJY?= =?utf-8?B?dHo4ckIvd0VVUUV3bjRKZ2cyaVV1dVQyM2N0OXR3Z1hZdjNGTUNXOG1pZk5y?= =?utf-8?B?bTNBZHlaLzJMUUFtMWg0TFMvR3ZVck9GYnVLRUdoVEJXTldlVmFSbGk2U2lq?= =?utf-8?B?RmEvRXF4M3Z5SVlsU2FwOVp4MlNsMEt0L1BjNEkvUnkvbjlvS1B2MXJrdi9R?= =?utf-8?B?ZTZWbm0zbW1vakZzMStVZTZtN1VoNVliZ3RTWlhodkZGU0c2QTdDNlVRam42?= =?utf-8?B?VkM5Q0t2RGUvNUxaQ3lJR2QvSDBiandpaFhiTVM2SFlHQitYU3dXczJHaWF1?= =?utf-8?B?ZUFJSWRZSjNYeHp6eEZBOTN5cE8zbnRrK2MvdU01K1NMWERjNWJ0dzh2ZmRN?= =?utf-8?B?UlBOWnZvS3Nnc3F6bG05WWFuUTB0MVZBK3pwNU93aFJTa1phcHpPNm5HSytt?= =?utf-8?B?NWpidzZGd0VweFFFdmMyb09RbTFycDlrWEd0N0s1TlZPTEJId2lhRlBTeU5J?= =?utf-8?B?dGtFZ3BvUXhrNEVSTVFjdUR6a2xtZjN6OEhtTnZ3cENqMHhVakdjc2laczRt?= =?utf-8?B?aFl1dmQyaFhQZW1taW85ckEvVUhUVDdVdDF6V052ZGhrUmlISXRoY1MxT00r?= =?utf-8?B?ejNzaVZHM3Bzd2YxMnVNSFlCc2g4T3FyeHd3RTQwYzlkYkNUbTl5U2VtK2ZM?= =?utf-8?B?eHZBSXV3TTJ2bTJOTm45Y3I3ay9VbldhV2VKS2NralRLcGRoVzQ3dDdyTnZN?= =?utf-8?B?c3lNZ2RJRS9iVGNzYkNrenoyWEhjR3MyclBhTENPV1JkNDh2TnFzLzlxMWVZ?= =?utf-8?B?dlpqYWpzdDJ4OGYyVE9QRjluVWE0dmNWa2NVRXExZ0NFT2JNRXYyTldUMFNG?= =?utf-8?B?MzF1TWtDRk1hN2pIWCt2a3FUQnhiUEZyMEV3YytlcFhDMXYyRDJPMDlSR2xR?= =?utf-8?B?R211Qmk3S0p1b0EzeHMzaVNvWThTVTRobENxQlBUQ2JRMTk0bW02aElVWDlT?= =?utf-8?B?Z0tNdWx5OC8xbG1Bc1hxcFhKMERQTFU0SDRsaFhCRG5VOUEycHVIUUJmamFU?= =?utf-8?B?KzZkakc4WFEyTHczWERhQjBnTDAzK1NoSlk4b1pkQ3JFWitCQUszUmZBTnJx?= =?utf-8?B?NkNNY0VGZVVHczFCMndaSzkyN2gvTktQcElNQVN2TWdndXFXY3ExYXNYa244?= =?utf-8?B?NjcvSTJGUW5ZekpiVndFQUVacXpUamVXV1Nmc1RDelpTVy9Qb2dVMkxBL0dy?= =?utf-8?B?djd1SU51dkEwMFByMHdHUjVEYVk3MEp4OHZtL1JIdWdQeTR3QlR3bDVuYXZt?= =?utf-8?B?a1YyZ2lrdXNUN0pIUVFNYWYwV3pEMGhJNy9mazZwNDJkK05ndzk1MzFNZWhS?= =?utf-8?B?N0xNVXNEamxVbWFkU1hHN0tsblYwTEtzc3Z3SVlSVVFnNmlKWXJiZTAyK3hV?= =?utf-8?B?OFJyQVNmSUhjeU5VaEVYdHlaYVIvVG8xWDBzRUxDenNpaHJFMVBNaGNoanU2?= =?utf-8?B?WSt4azQ4dGZZWGhHdjRzV3RBMUpldThnMHRyN3pMTUFWNEpwZnNtZjl5MXhW?= =?utf-8?B?ZUhzc0tQWU91QWlWTEhJQktjZzA2V0s5QXQvTEFmNDZyZFU0WTY2SGZRMjkv?= =?utf-8?B?M1FCY2hOT1dTdGt0c2xJbE1ZSGNxVU1vbjdlVGJJZHFsTVQwUjBSeGN1dCtL?= =?utf-8?B?UUQrYzZ2d0dJczY2bmNQWlc4VXp1MlI3RkpMUlY1N3lXWnVJcHFkK3BCNlEw?= =?utf-8?B?Zk1RNjVEcFM0SW5OZ2lpNnFiMVBKOWNpNlJHeENxOWY2NzFqU0d6ZXc0STVp?= =?utf-8?B?NzhQTkFLVnliQmNabk84VHRsWXNYcnBBV3pUeHpaaWZaZlZZU2NNN0lCQXpC?= =?utf-8?B?Y2R5eWU3Yll3SWxHOHFhNFgyOFE1TTVuUjBWS2tHUkNnTlZ3TkdWSFQ3RFNM?= =?utf-8?B?dEhPcXRkd2l4MEVUTmZyQkM0bE1GSUhNR1puYVR2RTBaWDQ1TGNIaXYzZW5U?= =?utf-8?B?SmVuR1JLT0EyZFovZ2VEUkw0ZDV5UlArT3MwM2l5RlFaQ0x2VFh6UUl2Smpm?= =?utf-8?B?bTlnUllObkFmb1laRDQyUktqbWkyTFRwUmNTUlRBQWFpSm1ZdW9XUnBMUndV?= =?utf-8?B?NUtVZXFHR0U1VkVxNkVCSWZqQlhodU1MRVp3UmJwUmtCTFhRLzd2bGxkR0I0?= =?utf-8?B?b2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xpxe/vQ7jaCDZZQdGJcoJhs8iL1qUTL2QQuNy/e2C/L0Sz0lhav29W49XoIr9oDS6OrBSIn7rEf+8WE6MsBaj6V686IultG3mTTEGK4FlUlWFHe3EVoAq9eiBr3ciFb208jYEsedk1KSskMH5khh6zOe/l79Naxj2xHroULD4AQK6jushSowqgJTxuLPb0FOQ/2HFdyqi78Umst3+G140t+lcQT0KXKdfxvdon7KdrafGSRlaurnAuWxxlw3bRQbU9Klrc6lDPOxOiUnqO9tUdob/Hi4gE0lRata4X7Z0QMGoAJwSlkodMf4LEyFrN+N5CGUqf4IYa+OOwWTvV/7kiQNSyPm2iOq3rGwBEZqUlvLdr2Wq0Buo66ueZ1Tq4IdwbbY8tMo90iTzITZa8fCjZSPsfrr7vCgqLBBVsQXwUusZkmDgayjMuN+3T8Tdojw1BI0w4kzsdgwkfMo78ofM8Zm4IA5B9W9Y2RdAGOh3Z2ffWswLtE7XjCr4NIIPvRYdvmJe8+x9THuEeYAy0Ttyhz+QetPpM2eblpXE+7NOTQcvuginIATnt6SALID+UQ/AB+ph/JGDaCmLIDPvZhnGj3K4rTeqpQ7wpNjMUi+rwo5aGNb4m/liSf39pcvOe15Q5gLTZUA6nKNFbtFBiNhrIaB/G6vDz0ZQddCG0RoiFAKsyxGfwv2xs1sF4J8y2vf5fLfAIoT5UKfiDAcWqaHcfWDYcjsLvOYq2yTPtDCM4Jv7lgB5eQWZ4LfYzMOq8ztau5zjZvH4g2iMIWc+KGyOHEY4J69xSoWanXESfEY3TRCythlrhL8WhXkrcSLmbkAbLztLQmNlpKw5FjSPc3ldw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d5fa955-ab8c-4272-845a-08db0ee6aa77 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 23:53:26.9689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AQQUt99afjB5PmuVlhTB6UXAfVREVrG3y+wKUaKmQ8M0xtWB4bQbP/v7+lW8g9B02UBJHTmQEtzFPc3RKLzzdGkssJpt8+GeK0QLWmFloeA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5883 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_15,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=817 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140205 X-Proofpoint-GUID: -86vT3qp9Q-yQ9U1zB3SpVMieSDACmsk X-Proofpoint-ORIG-GUID: -86vT3qp9Q-yQ9U1zB3SpVMieSDACmsk On 2/14/23 11:13 AM, Jan Beulich wrote: > --- a/arch/x86/kernel/cpu/bugs.c > +++ b/arch/x86/kernel/cpu/bugs.c > @@ -18,6 +18,8 @@ > #include > #include > > +#include > + > #include > #include > #include > @@ -32,6 +34,7 @@ > #include > #include > #include > +#include > #include > > #include "cpu.h" > @@ -934,7 +937,8 @@ do_cmd_auto: > break; > > case RETBLEED_MITIGATION_IBPB: > - setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); > + if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) Is this going to compile without CONFIG_XEN? I also think these two conditions should be wrapped into something to limit exposure of non-Xen code to Xen-specific primitives. -boris > + setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); > mitigate_smt = true; > break; From xen-devel-bounces@lists.xenproject.org Wed Feb 15 00:08:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 00:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495653.766036 (Exim 4.92) (envelope-from ) id 1pS5LI-00057M-Gq; Wed, 15 Feb 2023 00:08:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495653.766036; Wed, 15 Feb 2023 00:08:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS5LI-00057F-DH; Wed, 15 Feb 2023 00:08:12 +0000 Received: by outflank-mailman (input) for mailman id 495653; Wed, 15 Feb 2023 00:08:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS5LG-000577-Ec for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 00:08:10 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1d3911a-acc4-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 01:08:06 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31EL3xuv016238; Wed, 15 Feb 2023 00:08:02 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np1t3evsb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 00:08:02 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31ELnUYH015156; Wed, 15 Feb 2023 00:08:01 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f6b9rp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 00:08:01 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DM6PR10MB4315.namprd10.prod.outlook.com (2603:10b6:5:219::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.10; Wed, 15 Feb 2023 00:07:53 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6111.010; Wed, 15 Feb 2023 00:07:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1d3911a-acc4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=YCYmNgxwj/GhlCG7BbHd6Wb7Rzaxaov6suppziMNPA0=; b=cu79GiArb0zW1Pzt86semmnRUYIcrLv6PhtcoYW+ijcetlrlH0bSg14mSUkBzqP5yRej ESt6JUIYdlD148EPKiwY2FIoFxisOB+ASpGUZvZpFTmRIAiw/fm86WhADKUu+3JAZ39d i8HI5yXsY1gVM4+JMLhxaE9ZZbQvHajDQKKDriLcAyIev/5NVlAa5cHKsFE2rMBWLudC jW00KA9+vIiUKqfLmj6VgW0l7xoCL06y21qWfe+K6TrZ3jQlTqF6xrcQtkoguFEW6Zpe HBVHHqVpuzPI0p++7/Mt9lqIMFsdIBhEiIKQvaxQylf58PWVhk5ju58SYfj7DkSEma2y bQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n++t09cH+hVPi8Lwr6qfRJeFFX4eYbArc43e1IPt2kBZLdLgqPVavQODwARJY9t7JBJmDT3rdxmNAUA5NDqWp2Ls2DQbQYDAHaum6DnuZqMOcBqV/0g2gPEz5MLSnIn+RHRdAbn2MjSmSqerkD35w3Cu4F9tgskdiOox2vhTUtqe7gy0usG1K7LegrEqKJpLPVhHzifQ4dcr0+Zu+1jy0Q3IU9OPCqkgkPJy8PMK8QB9UR/z/MUky4H2JvWGIzsSXNUB0obHAAqT6NsqgLNje7oUR8pjbF8fwadkHXzJBSnjafQCSggRcNLzht7EwYBrVSNQIIdm9Ferw4CNWEXznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YCYmNgxwj/GhlCG7BbHd6Wb7Rzaxaov6suppziMNPA0=; b=d3tkSW0A2p5+5/2lQa7RjfjKmiuH+CwUuqVSlnMEYuPhAv8g1mFvW3cHrtqMP/18RMg0kDmdGYHnZ2SgDNoEyQlTB+Pe4xppgfHKILYvO3VvJrwWPpWyE7bgvtGdfxCBmZH4bLJOjcPb6Fv173sgGcEB7JUGtCCUl8bIGhp/EkmWtQkUVu4L+EglO6z0bCNYgTx0k18BlFiZVLEzaMa4s0QpHcdxMiVkpRanQeANIRK2Wm8DKJ7D9muCGWYgqxzfgk2JL2ZjQeAwQ36uaxy+8ajgmy3HiJsyPDmRYV1c/0SyPhGzQ/cOhBBXCbBK2wy6n5IEDhYfQeC2i3OK1JmUew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YCYmNgxwj/GhlCG7BbHd6Wb7Rzaxaov6suppziMNPA0=; b=GTxIh39YeIzJKJh6faeHXRKJyUTumT+lK15CHhDKAac92EHnWUNjLjwmQ+jbncOm+ZFnGDsdB6vdRqpemquEfJsowsV2/4jSrJ85Wy+kdeKq3GctvVbb5rmlwR5vFVwx0WGpLHupy2ZeK82Vkg37jDxK5qw6C6GHpGiwAxROvww= Message-ID: <4e66865b-11ce-cbd1-d115-13e3743eed7b@oracle.com> Date: Tue, 14 Feb 2023 19:07:51 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist Content-Language: en-US From: Boris Ostrovsky To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Juergen Gross References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DM6PR08CA0026.namprd08.prod.outlook.com (2603:10b6:5:80::39) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|DM6PR10MB4315:EE_ X-MS-Office365-Filtering-Correlation-Id: ba3b74b3-af42-4a0b-426c-08db0ee8aefd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9UZVvqXIRMrdEh/XSGe4O5buzZF1H1DslrLrlLwYhVtbtKu7n/TC+T3mJOf0oTsViO0lubLOTyZ1ysOabvdmKLSmMaNAsObMaGkMUCY7eUuUarqZMropHIxzlC98bjgT3tRDEK10D0ZFjfeU9P+0nK80t8pFhEVopIlwgrtmc4AMqh7sThpp+vwOFOcaYBGMiJH/5HPFC1pdzEKcwvwQw46yB5z5kfnEluEy0+o88P5Q4aasvQ7ZsAkj0f7ENaTjB0cAhLiB8osQp30237bIMoxiSwoigZNS5/4c3luqCkAjAztxuXhZZkXfna4ruhBUzHQRp6a8MCybjcRB9ktVA5q7hv/wphxe9K+b7nW+JI71HkLwwOqn0a/UtWxwfPqJUe/91o2K8vYlg9qtNbFW9QI1jwSbqPa/gHRP3VuF/ZQ4BD1T8cK/XaVbAciWTDSWeAaKOe+RVyxwHj58wLS/4TyF3z42HMSZakyx0DBneOCHAfNFS0KCAReOY5bAKVSxgcrn0uFfMOcFEy/s2BkzwqGdcFNZwz87xFLr9SYlYhazCbYeWe8JLRHJodjoDXhMhXyjtD0Ph/5JBtLuDjKZDZrQjWPuJRHbkKN8KWDCdxbqGIszw0h2thT1P4q37sipIkNg785sUjc+BX1IZRQC0ZqWfxNrN1Q3pAxM2BYDuzW4U8Fd8uUoghLmM+LQDtCAdIaeTKir1Q0TG+hX3/bzNT1FjXfakFC5HzTs+wBVJIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(396003)(366004)(376002)(136003)(451199018)(2906002)(8676002)(4326008)(66946007)(66476007)(66556008)(186003)(110136005)(31696002)(86362001)(6506007)(26005)(316002)(54906003)(6512007)(41300700001)(31686004)(4744005)(44832011)(5660300002)(6486002)(478600001)(53546011)(8936002)(38100700002)(2616005)(36756003)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzQ4a0NZaEJ2NHBsaGZ2Y2hIVjQzWnpreEhBcUtBQU1tcTA2N2dESHFpVWpr?= =?utf-8?B?dHlWSzBaN3ZhOUNEb0pzc3AwaW1KS0hMVFJFVDM5YlBZd2NwZWxpU292cGhJ?= =?utf-8?B?Mi9wWGJYajNybThYVmZPSkI3MnFWcXBJMUtPMlZPcHp4RlhyOVdPT01zcFhH?= =?utf-8?B?clp5SnFTcjU2RTg0MUZla25qWVU0dGlJZlh1QXBERENiVVI4UjlRZ1dMWVBK?= =?utf-8?B?MEM3OGMvRkxUK2s1cDVXQWE2SzlyY2xRZjNLanRqcmtHcTA3M09IMS9HS0pZ?= =?utf-8?B?bGxkVk9LRUc2OHArelZaR1JJTjZ1b1l2NWxEdy9XdnU5aElhUUdhUW1RL21L?= =?utf-8?B?VkpDa2NzQkYwdWp5by9vTmV6Mk0vWGNHejJPenZudWlFUHdoSzcwckgzcWMz?= =?utf-8?B?VTVSMkNUK1gvRU1jUjlDMjgxTWhZMFU5M2Y0b2tRek1TYzR2S0swcWVYelhk?= =?utf-8?B?NzZYNmFWZHBreVo2RXN3WFVvcXV2bTlQSDF2aEZiSEtKbDRONHZuYW9XRGtW?= =?utf-8?B?WFB1am5MQWs1RXIxcmkzcU9Xd0ZEZFhNVklTeXU3ZHMrbitaREJ2bU1NNk5r?= =?utf-8?B?SmhhRHFsTVFVeEpRUXpsSkpTRVYrYUtTUUNOMkJ1dkVCYUxhdldyenRZYXNv?= =?utf-8?B?ZkltVW5pblpnWmdYY2xaR0lHZUdMM2dOVWh3R0ZMOUpDUEQ2RGVwakJsR0Vm?= =?utf-8?B?MmdTNHFTOGRick9nME9MRnkvMmI4MVFPOHBlMXk5MkQvNHNSKzNNY2dlNlFn?= =?utf-8?B?YngrYzhSbVRWV01CbGxKMGZRU3BrN1p4aWxrL3VsTlluWTFqbmRKSmIyWEpv?= =?utf-8?B?bTZGblVCRjgvZUJmaGkwNEFWUFZiU1NJWlFhTTdBb3ZJRHZFWklIdnNsaDEx?= =?utf-8?B?RHAyZTk5VVZzcjU0dFJSRzNOWUUwRjBYUTRkUGc3TGU3TzNJaWt5WHdCbmJn?= =?utf-8?B?Z3hsNldvR3FZbllBTEJhTzlOelloVE5FMDRTeU8zS1JOd2ZoZ2cyUTk3QmZz?= =?utf-8?B?MWk3VmlBTjY3d042UExndmI2bHc2OW9aNXJaSXIvbjVZTVZjZmZab0Z6WUFP?= =?utf-8?B?VlFRUGNtSklicVlvcmIrWWVzZE9BbUVrV2V2TkpQOXRKN3NkV3JGNVl2TllP?= =?utf-8?B?elpyUXBUMXFXU3J1cGZIUWdQTEpPY1RvTWFTdkhoOEYra1Z1SExRTjkxeEQ0?= =?utf-8?B?V1F0R1J2SDVCbkVRYXh2VzJnSmFwTUpDdXgyQ0NIWTZjdXhqRHRGRFFkVmly?= =?utf-8?B?NFpyQVo1Y2JzZVJ0dnFGL1NHRmEvcWVvMUpnK0FsMFgySkRWZ1R5cE9FSG01?= =?utf-8?B?aTRQa0owYko2RFQvbUxaZWczZmdKalF2VFpRZGw0SVlGS0xjTG16M0dwYlFJ?= =?utf-8?B?R09tZG50VnpXV1lvdTh1TW9yVzJCVkUyc1I5VmorN2ZXbmNEWFBTWWRsSzZn?= =?utf-8?B?blVwMFNzeWl1ZEFBb0VCQjFFazNQNXVXQytQNFgwQ1R5YTJBdm1uVFk0b2tO?= =?utf-8?B?TnNBVkpLYTBXUUZGWmJCMGdnZURxMExtNXpzTFFMSW43Yk1ha2Z1Vm9VcFdI?= =?utf-8?B?WE9JWi9tNEswL21qNVBpRzR1THdqQmhQN0Zlc3Nndld1NUx6SjdFbFMyeUl3?= =?utf-8?B?YmV6cUd4OXBobmQzZzhtQjVEQ2tSRDFjQ2Mxci9pMzBlT2Mrd1k4N1p0Q2Mv?= =?utf-8?B?eFlrRWJES0R3NWVCMjBHZW5lWm5PeXNkOGprVTR0WVM5OFlDdmpXV2JONHZE?= =?utf-8?B?WEZKZkVOdkhTeGZ5eVhnbDVZM2hXUUFSOU52V1k1L2dKVGY4cGY1Y1d2c2gy?= =?utf-8?B?d1NabkY0dnRnaWtVOC84TkxQN0NWWUZ1UmRyaUh6bTJjSmZ3d2tSbmdFTjVt?= =?utf-8?B?eEZqdVR1UXNVcWxialQwMXA0dXAxa05tQUJQeCtEUEdPM2Nac0VTd3FybUFM?= =?utf-8?B?SEoyb1lTRUpxTnRuVFNWQXdTWVFGM1MxVzBrR2ZyWXVQMVNhVlFrclhLT0FX?= =?utf-8?B?MFhFTzBTQXR5NXphY0N6WG8rRk4ydXd2MXRNLzBKUDd5OHlGczdnN1BlKzQy?= =?utf-8?B?RGdBSFgyTWNMYVQ0YlpsYmFSR1FDaVlMcGRqTTZ4cTdnWHNOLzFHOW9kc1Fl?= =?utf-8?B?cS9oa1VJQkg3RUMyZk5WZE1nVDhxK09GV2NkYzF3cGwwakN6UDZlT3NTTzdl?= =?utf-8?B?MXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kCZWLVQc67XuHNuOSoHwJWNeVD4FrxAS9QNpPndbhqdTP2EJ8PrpFYMEjOpo/CPK+UpBwBCbRWOskoi49ryQHkaFxhQmih3IW/EBQleDuP7hOSfK2Mq4TeZiDMJzW3cck66RHz8lzXABp2Z6ChErxDEI3aFEpUwcZF3wJMisMjW5NoNwR+3TDAgeyXkVHIVISXrsMt2+GSqVoPtPWLUURoKg2XbbOmUjBkCe+rTRZJZuC1t1UNolQgweQoVIH2yGGHg706SWqQFAHYMszy8maPgf2MVaedZHpNst2pnCdEKaJBBhFR4u7GY7Dj1E5jS9rPM1nzO/4vi7j+lIFrQXceWTsjnJ71VXuIPAZrRe/D1AVwgLcvYb/oGRHoEBMqR8+/AzIKWLePkdZAzA2Vv4ir7MuArmbNQ67nwVI576iVMtzFwYb4bduwurN49i6PelNdSlEzBzvCUMKDlFcBKmtOqqibY4SQPJP40/hwCjIiiHHBeeFFiZa235h46kU4UjP/6TmFlcydfRRJEWDKZEYS0NATGXl7m0phictKLaEUYpW5YTUgorOV9SNiiiS4f8zApAjRbMP6LJhzhLpRPlnvwVYgoh2iC00IBStZTnLjzBGFu1ZQD1u99R2GvFiLcWW85qxgxT/iCzxhiXnOKrLwf43Fi0ONrnsPP37jSZE1WgPQNXazLXSRo6OLU2n3DfRB9oldRAoX7ODx0MlAa/f259gtbbQh9Jr4bbPKtF3d+EB9y3VxEojMzRJT0o2sUQHe1u+VATRh0zbJUy4bEUEoyWLVV2TxUqetWKR6dSJMYyJ/svtiAde6neW5i2LuoEX6lsq2NwHlIK7CaA0ZsOrQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba3b74b3-af42-4a0b-426c-08db0ee8aefd X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 00:07:53.5185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n2AlFJGxBvvajawOPnTNYoGg8OVXuJ8XL1pnwvBQbd6odFSAySE50Tdebk/Twxi0AhuBgExcgFwMafvKYnwLzo4ix+SVixtVzPSw/BI9mC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4315 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-14_16,2023-02-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 malwarescore=0 mlxlogscore=806 bulkscore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302140208 X-Proofpoint-GUID: 2u2xahborChpUbtx01cORFIncsLD_PgC X-Proofpoint-ORIG-GUID: 2u2xahborChpUbtx01cORFIncsLD_PgC On 2/14/23 6:53 PM, Boris Ostrovsky wrote: > > On 2/14/23 11:13 AM, Jan Beulich wrote: > >> --- a/arch/x86/kernel/cpu/bugs.c >> +++ b/arch/x86/kernel/cpu/bugs.c >> @@ -18,6 +18,8 @@ >>   #include >>   #include >>   +#include >> + >>   #include >>   #include >>   #include >> @@ -32,6 +34,7 @@ >>   #include >>   #include >>   #include >> +#include >>   #include >>     #include "cpu.h" >> @@ -934,7 +937,8 @@ do_cmd_auto: >>           break; >>         case RETBLEED_MITIGATION_IBPB: >> -        setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); >> +        if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) > > > Is this going to compile without CONFIG_XEN? > > > I also think these two conditions should be wrapped into something to limit exposure of non-Xen code to Xen-specific primitives. > Oh, and this needs x86 maintainers. -boris From xen-devel-bounces@lists.xenproject.org Wed Feb 15 00:58:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 00:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495666.766046 (Exim 4.92) (envelope-from ) id 1pS67f-000322-7q; Wed, 15 Feb 2023 00:58:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495666.766046; Wed, 15 Feb 2023 00:58:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67f-00031v-5A; Wed, 15 Feb 2023 00:58:11 +0000 Received: by outflank-mailman (input) for mailman id 495666; Wed, 15 Feb 2023 00:58:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67e-00031p-K0 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 00:58:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce73e1e3-accb-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 01:58:07 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99F5061977; Wed, 15 Feb 2023 00:58:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6472DC433D2; Wed, 15 Feb 2023 00:58:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce73e1e3-accb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676422685; bh=M9v+Sl9WxzkeuAIOwj0pU9y97oaG3NE6VtqF22YIRJ8=; h=Date:From:To:cc:Subject:From; b=cc0NaZtyh72Ze1kR+wNFUNKEnYnU9tSOq2dwlbcisikKPFw8KvcGb47HF7FPWcnvp P4ItM+g18uUl0pEbfeCHn4joChoieAf4P9jmaeNi9pzXJKa26ME3lEGjoNbvMgQzVJ 0KQl+xVoh3HaFBvuN9rBCrLG62T7Tv2hKPMjinAiYK6uPWjDK6gCP4+7eKDjORFXol DREz1xe5bs7L2IxFDblGmmOvSrWeUldIPwEEDyB594GVO+t+OJLs+BxQpPFHFIDVoH 6nyvt9ICOPJbZSXQv866zbq7AWE5LnFTyk9BCiPLbshBfzMTNv8tOY5i5oZ2EC4QFn bW4vgsm9fhL2Q== Date: Tue, 14 Feb 2023 16:58:02 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com Subject: [PATCH 0/3] automation: add arm32 xl domU creation test Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This patch series add a domU creation test based on xl for arm32. To do that, it reuses the existing arm32 dom0 test, and also reuses the Yocto qemuarm build output. Pipeline (with reduced amount of jobs): https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/777780349 Cheers, Stefano Stefano Stabellini (3): automation: move yocto jobs to build stage automation: add binaries/ to artifacts for Yocto jobs automation: expand arm32 dom0 test adding xl domain creation automation/build/yocto/build-yocto.sh | 6 ++++ automation/gitlab-ci/build.yaml | 52 +++++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 46 +------------------------ automation/scripts/qemu-smoke-dom0-arm32.sh | 50 ++++++++++++++++++++------- 4 files changed, 97 insertions(+), 57 deletions(-) From xen-devel-bounces@lists.xenproject.org Wed Feb 15 00:58:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 00:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495667.766058 (Exim 4.92) (envelope-from ) id 1pS67o-0003Ji-Jg; Wed, 15 Feb 2023 00:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495667.766058; Wed, 15 Feb 2023 00:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67o-0003Jb-Fu; Wed, 15 Feb 2023 00:58:20 +0000 Received: by outflank-mailman (input) for mailman id 495667; Wed, 15 Feb 2023 00:58:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67n-00031p-4O for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 00:58:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d4b6d72c-accb-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 01:58:17 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B9046196F; Wed, 15 Feb 2023 00:58:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1C64C433EF; Wed, 15 Feb 2023 00:58:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4b6d72c-accb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676422695; bh=Tso1s+NNc0babg5gBaw2ZRssYgQb1dk1kR0QDs857oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h9sEomkJbhXuQA5ATZFvf47ocWOiT3f43NB5E/VOQL9pvF+Ycb4EMmDdsWd4WuiVk gEi+BNSiLbdORB2jE4vM8JBhAhv0HLnNxCX7HxWiD5voQVNZ4sdTeISEGlFiBQwOHf 11FAIcGRechRd5cbFMMBJrkovENNjM9fBxZQBN0YBGLyz4uG6KX6DONaWc2laomcf/ S4odQbxQrsM4+LGfkybjNIQRIELqr+xtlywEZbJfrQBJLbi7bQYZlXVKB7+6dzq4vn 1AI+BAY6JYiX7JTC8WDylNgt7mGlAvcPKb9/bV6Sqqgx7U6CVprscX8taFoyZ8+LnL HBN8RCpShtnfQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH 1/3] automation: move yocto jobs to build stage Date: Tue, 14 Feb 2023 16:58:09 -0800 Message-Id: <20230215005811.2126759-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini We are going to use artifacts produced by the Yocto builds in test jobs. Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 51 +++++++++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 45 ----------------------------- 2 files changed, 51 insertions(+), 45 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c732..f62cf21f45 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -199,6 +199,41 @@ variables: <<: *gcc +.yocto-test: + stage: build + image: registry.gitlab.com/xen-project/xen/${CONTAINER} + except: + - master + - smoke + - /^coverity-tested\/.*/ + - /^stable-.*/ + script: + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + variables: + YOCTO_VERSION: kirkstone + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} + artifacts: + paths: + - 'logs/*' + when: always + needs: [] + +.yocto-test-arm64: + extends: .yocto-test + variables: + YOCTO_HOST: arm64v8 + tags: + - arm64 + +# This is not used by any test job as we only run Yocto on arm based machines. +# Keep it here so that someone having x86 hardware can easily add jobs. +.yocto-test-x86-64: + extends: .yocto-test + variables: + YOCTO_HOST: amd64 + tags: + - x86_64 + # Jobs below this line archlinux-gcc: @@ -679,6 +714,22 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Yocto test jobs +yocto-qemuarm64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm64 + +yocto-qemuarm: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm + +yocto-qemux86-64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemux86-64 + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index ce543ef5c0..9570085a60 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -67,35 +67,6 @@ tags: - x86_64 -.yocto-test: - extends: .test-jobs-common - script: - - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} - variables: - YOCTO_VERSION: kirkstone - CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} - artifacts: - paths: - - 'logs/*' - when: always - needs: [] - -.yocto-test-arm64: - extends: .yocto-test - variables: - YOCTO_HOST: arm64v8 - tags: - - arm64 - -# This is not used by any test job as we only run Yocto on arm based machines. -# Keep it here so that someone having x86 hardware can easily add jobs. -.yocto-test-x86-64: - extends: .yocto-test - variables: - YOCTO_HOST: amd64 - tags: - - x86_64 - # Test jobs build-each-commit-gcc: extends: .test-jobs-common @@ -253,19 +224,3 @@ qemu-smoke-riscv64-gcc: - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} needs: - archlinux-current-gcc-riscv64-debug - -# Yocto test jobs -yocto-qemuarm64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm64 - -yocto-qemuarm: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm - -yocto-qemux86-64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemux86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 00:58:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 00:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495669.766073 (Exim 4.92) (envelope-from ) id 1pS67q-0003dM-5X; Wed, 15 Feb 2023 00:58:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495669.766073; Wed, 15 Feb 2023 00:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67p-0003ca-WB; Wed, 15 Feb 2023 00:58:21 +0000 Received: by outflank-mailman (input) for mailman id 495669; Wed, 15 Feb 2023 00:58:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67o-0003JV-VE for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 00:58:20 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d65b45c3-accb-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 01:58:19 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0AF81B81EA7; Wed, 15 Feb 2023 00:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01695C433A0; Wed, 15 Feb 2023 00:58:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d65b45c3-accb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676422697; bh=T5WSKBYQzVjhzysjUnGo4/jVHe9t0Ka2SdLf2aTZm00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fnFI1tB7BJHYp+pyQLmbq10Lq+vDJiCWpC8BBOLXpn+yfuUe3Ia7YNJ1x0Hp7pnTa WphNfy9yCmIxA0n6mejY+3WR0s+MaLSpYLyeFJOOq/d374btgAw1J1j2EuB9OO1Snx fjy2alZ2N2zwtt6kkXmBEAErI1df3znr2lqppqtfTvBg7dBrEGd4x9o8UTtDFnwiLN +gR/Dc/cwh4lDlHm7lmIhYF/MSlrfw6VWMzz2Sdql1cgu5jXBNVKFc0lmX4h4v1GqX ed5cRPfSnAHvaFA/kku3+Ao+ppVwlcwmOJz93YqpY9JN/r8aosOM8QuQnPPe4Zt0sl FZOb9LYK3v6/w== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH 3/3] automation: expand arm32 dom0 test adding xl domain creation Date: Tue, 14 Feb 2023 16:58:11 -0800 Message-Id: <20230215005811.2126759-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini As part of the arm32 dom0 test, also create a simple domU using xl. To do that, we need the toolstack installed in the dom0 rootfs. We switch to using the kernel and rootfs built by the Yocto arm32 job. Remove the PCI node from the host device tree: it is unused but causes a Linux hang at boot. Use xen-watchdog to trigger the domU creation for convience (/etc/local.d is not handled by rootfs.) Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/test.yaml | 1 + automation/scripts/qemu-smoke-dom0-arm32.sh | 50 ++++++++++++++++----- 2 files changed, 39 insertions(+), 12 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 9570085a60..7bfdd02e64 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -172,6 +172,7 @@ qemu-smoke-dom0-arm32-gcc: needs: - *arm32-test-needs - debian-unstable-gcc-arm32 + - yocto-qemuarm qemu-smoke-dom0-arm32-gcc-debug: extends: .qemu-arm32 diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f6..7a748bdf23 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -3,14 +3,37 @@ set -ex cd binaries -# Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz -# Use a tiny initrd based on busybox from Alpine Linux -curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz +mkdir rootfs +cd rootfs +tar xvf ../xen-image-minimal-qemuarm.tar.bz2 +mkdir -p ./root +echo "name=\"test\" +memory=400 +vcpus=1 +kernel=\"/root/zImage\" +ramdisk=\"/root/initrd.cpio.gz\" +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" +" > root/test.cfg +echo "#!/bin/bash + +xl list + +xl create -c /root/test.cfg + +" > ./root/xen.start +echo "bash /root/xen.start" >> ./etc/init.d/xen-watchdog + +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz mkdir rootfs cd rootfs tar xvzf ../initrd.tar.gz +find . | cpio -H newc -o | gzip > ../root/initrd.cpio.gz +cd .. +rm -rf rootfs +rm initrd.tar.gz + +cp ../zImage ./root find . | cpio -H newc -o | gzip > ../initrd.gz cd .. @@ -20,22 +43,25 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ -machine dumpdtb=virt.dtb +# XXX disable pci to avoid Linux hang +fdtput virt.dtb -p -t s /pcie@10000000 status disabled + # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt.dtb" -XEN="xen" -DOM0_KERNEL="vmlinuz" +XEN="xen-qemuarm" +DOM0_KERNEL="zImage" DOM0_RAMDISK="initrd.gz" -DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" -XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/sbin/init" +XEN_CMD="console=dtuart dom0_mem=1024M bootscrub=0" NUM_DOMUS=0 @@ -51,12 +77,12 @@ bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ -timeout -k 1 240 \ +timeout -k 1 720 \ ./qemu-system-arm \ -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 00:58:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 00:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495668.766069 (Exim 4.92) (envelope-from ) id 1pS67p-0003Zk-R1; Wed, 15 Feb 2023 00:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495668.766069; Wed, 15 Feb 2023 00:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67p-0003Zd-Nl; Wed, 15 Feb 2023 00:58:21 +0000 Received: by outflank-mailman (input) for mailman id 495668; Wed, 15 Feb 2023 00:58:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS67o-0003JV-JE for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 00:58:20 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d54c7813-accb-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 01:58:18 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4177161985; Wed, 15 Feb 2023 00:58:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08509C4339C; Wed, 15 Feb 2023 00:58:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d54c7813-accb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676422696; bh=B355pQ+xrgYs8p+di9bwo3QyG2cTAAdJVFDOYi9P610=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fEYTbW2msi7HLS15+v5NA8xSBQitLINtwfHrMbs82msPrP0fcU91QF8YzrOdwY2JT bDe1PH5f8nfHpzb1N4oYQX8E/f319qUoFPmOhaSY7XloQ3Gd7BdTjQ5+VhohCJCrAa jw0UzCfTMs2Kg0GV3jXATEPoMsCnyn/wEiEf3LtxZnr+6r/h2GfB8xY5QNUeVF/mjW 4t/HJ+IUIvoeTHSwzGA0asvi90/7sj7WjqipZNOT/M0Ic+lPm1i5YaangdvcozpI9v dLeUz5PmWxu+EPHkfNX+opsgl3kgr7FtxXsoDyvgPqrCpmZZbEx2LydYMY7rLAoeX7 WjgcWNiRpcj1A== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH 2/3] automation: add binaries/ to artifacts for Yocto jobs Date: Tue, 14 Feb 2023 16:58:10 -0800 Message-Id: <20230215005811.2126759-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Copy the build output of Yocto builds to binaries/ and export binaries/ among the jobs artifacts so that they can be reused by other jobs. Signed-off-by: Stefano Stabellini --- automation/build/yocto/build-yocto.sh | 6 ++++++ automation/gitlab-ci/build.yaml | 1 + 2 files changed, 7 insertions(+) diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh index 3601cebc3c..d0fcaacf06 100755 --- a/automation/build/yocto/build-yocto.sh +++ b/automation/build/yocto/build-yocto.sh @@ -166,6 +166,10 @@ function project_build() { source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" bitbake "${build_image}" || exit 1 + mkdir -p $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/zImage $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-qemuarm $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-image-minimal-qemuarm.tar.bz2 $OUTPUT ) || return 1 } @@ -238,6 +242,8 @@ Options: EOF } +OUTPUT=`pwd`/binaries + for OPTION in "$@" do case ${OPTION} in diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index f62cf21f45..d4a2aa9a5b 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -215,6 +215,7 @@ artifacts: paths: - 'logs/*' + - binaries/ when: always needs: [] -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 01:01:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 01:01:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495691.766091 (Exim 4.92) (envelope-from ) id 1pS6BA-0004jH-Jh; Wed, 15 Feb 2023 01:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495691.766091; Wed, 15 Feb 2023 01:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6BA-0004jA-GP; Wed, 15 Feb 2023 01:01:48 +0000 Received: by outflank-mailman (input) for mailman id 495691; Wed, 15 Feb 2023 01:01:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6B9-0004j3-8p for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 01:01:47 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51566245-accc-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 02:01:46 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52BA56198B; Wed, 15 Feb 2023 01:01:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1117CC433D2; Wed, 15 Feb 2023 01:01:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51566245-accc-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676422904; bh=/2D5rJbdcXEDBtCC9sr7IHGuk+m8p4LQ7U7CQHrMG08=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jUZuEOhSnzPoNwc7XzyqmJiGkYRPnorldxblTBhIu/BxYr19w9DfAAdaAP2cCea3P g2ffmXk169bLPAonpKh8CoM6ywIR+MBsWz6/rL+Qvsk5LbTMfe4wXJmzTSq8ndMSdh Gwowp5bTAz3RxrtxeKSxkYJuj/udxaP7UGE/GvJx5AYs7MqXxv2mOeVNAr/4vYN2oi BtjNE2BGpLqPHEuK6DrwbvNzuXWOxsHs6Qxs/2Cf4m+G+f06HsbrtL8g0mVnxoLDmI xZ60C/lkOjz9UhO5l4a4voh/HYWQ8DwmtS5wTtUmA6yAc3gG5XDnegdjcovFkCBxdh h4ZvHJalkBN7Q== Date: Tue, 14 Feb 2023 17:01:39 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: xen-devel@lists.xenproject.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: Re: [PATCH 2/3] automation: add binaries/ to artifacts for Yocto jobs In-Reply-To: <20230215005811.2126759-2-sstabellini@kernel.org> Message-ID: References: <20230215005811.2126759-2-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 14 Feb 2023, Stefano Stabellini wrote: > From: Stefano Stabellini > > Copy the build output of Yocto builds to binaries/ and export binaries/ > among the jobs artifacts so that they can be reused by other jobs. > > Signed-off-by: Stefano Stabellini > --- > automation/build/yocto/build-yocto.sh | 6 ++++++ > automation/gitlab-ci/build.yaml | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh > index 3601cebc3c..d0fcaacf06 100755 > --- a/automation/build/yocto/build-yocto.sh > +++ b/automation/build/yocto/build-yocto.sh > @@ -166,6 +166,10 @@ function project_build() { > source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" > > bitbake "${build_image}" || exit 1 > + mkdir -p $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/zImage $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-qemuarm $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-image-minimal-qemuarm.tar.bz2 $OUTPUT In this form this is a mistake as it only works for the arm32 Yocto job, while build-yocto.sh is common for all of them. We could either check if this is the arm32 job before copying, or move the copy to build.yaml. I'll fix this in the next version. > ) || return 1 > } > > @@ -238,6 +242,8 @@ Options: > EOF > } > > +OUTPUT=`pwd`/binaries > + > for OPTION in "$@" > do > case ${OPTION} in > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index f62cf21f45..d4a2aa9a5b 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -215,6 +215,7 @@ > artifacts: > paths: > - 'logs/*' > + - binaries/ > when: always > needs: [] > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Feb 15 01:07:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 01:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495696.766102 (Exim 4.92) (envelope-from ) id 1pS6GI-0005Lw-6Q; Wed, 15 Feb 2023 01:07:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495696.766102; Wed, 15 Feb 2023 01:07:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6GI-0005Lp-3T; Wed, 15 Feb 2023 01:07:06 +0000 Received: by outflank-mailman (input) for mailman id 495696; Wed, 15 Feb 2023 01:07:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6GH-0005Lf-4V; Wed, 15 Feb 2023 01:07:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6GH-0007ra-1M; Wed, 15 Feb 2023 01:07:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS6GG-0005r3-FL; Wed, 15 Feb 2023 01:07:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pS6GG-0002rR-Ce; Wed, 15 Feb 2023 01:07:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xyZVoMFM30DDFrausqm6gF9ACnhuzaiEngNyTPKcxec=; b=PY/+dajP90k0Ml2UTbte1zVeOc v29eoQpoc+MB8nfENmrDK4zmO1Fg3i7AKi5b/NQo33+G7SvF/euOOUtJQO98s+ZSKhVv0CMBgZ/CW QpZLVuglq3jbWxXNeS/RtFgBagwx+jnHeaQHVJ4bL/AywuQpe3EuabKezOoLG+FURyKw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177298: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e X-Osstest-Versions-That: linux=f6feea56f66d34259c4222fa02e8171c4f2673d1 From: osstest service owner Date: Wed, 15 Feb 2023 01:07:04 +0000 flight 177298 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177298/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177222 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177222 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177222 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177222 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177222 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e baseline version: linux f6feea56f66d34259c4222fa02e8171c4f2673d1 Last test of basis 177222 2023-02-14 00:11:11 Z 1 days Testing same since 177298 2023-02-14 17:43:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Paolo Bonzini Tom Lendacky jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git f6feea56f66d..82eac0c830b7 82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Feb 15 03:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 03:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495705.766113 (Exim 4.92) (envelope-from ) id 1pS8Xs-0006i7-Uc; Wed, 15 Feb 2023 03:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495705.766113; Wed, 15 Feb 2023 03:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS8Xs-0006hz-OR; Wed, 15 Feb 2023 03:33:24 +0000 Received: by outflank-mailman (input) for mailman id 495705; Wed, 15 Feb 2023 03:33:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS8Xr-0006hn-73; Wed, 15 Feb 2023 03:33:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS8Xr-0003Om-5G; Wed, 15 Feb 2023 03:33:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS8Xq-0006Wv-UE; Wed, 15 Feb 2023 03:33:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pS8Xq-0002ak-Ti; Wed, 15 Feb 2023 03:33:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1VHulUNQkQCGQ6mxrpE5MuJDNkBOdaAFtCQYdbJU9WE=; b=radzowW6KY5Qe0lamlzjn+jNs6 kmt9pHK/w+XHMs3VEkidJM+zO9B/el71vacM6G5zVMa0aVbo7cf/5ceohhTL0PF8DsU6ZBpOVbuBD 16JiYkLbg+3TTx4FhHjFU0KZqHMg/jsZfKQMvnzZq1oinwbls25r9c+ERWpD3hGt/hfs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177328: all pass - PUSHED X-Osstest-Versions-This: ovmf=1b5420e8071b4f9ba13136f19365542dfe66bf04 X-Osstest-Versions-That: ovmf=540522fec06b87bf11ad5624abe23b515f282d60 From: osstest service owner Date: Wed, 15 Feb 2023 03:33:22 +0000 flight 177328 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177328/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1b5420e8071b4f9ba13136f19365542dfe66bf04 baseline version: ovmf 540522fec06b87bf11ad5624abe23b515f282d60 Last test of basis 177239 2023-02-14 03:48:16 Z 0 days Testing same since 177328 2023-02-15 00:12:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dionna Glaze jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 540522fec0..1b5420e807 1b5420e8071b4f9ba13136f19365542dfe66bf04 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 04:52:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 04:52:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495713.766123 (Exim 4.92) (envelope-from ) id 1pS9m7-0008Lg-JV; Wed, 15 Feb 2023 04:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495713.766123; Wed, 15 Feb 2023 04:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS9m7-0008LZ-Ga; Wed, 15 Feb 2023 04:52:11 +0000 Received: by outflank-mailman (input) for mailman id 495713; Wed, 15 Feb 2023 04:52:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS9m6-0008LP-8j; Wed, 15 Feb 2023 04:52:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS9m6-00064A-5g; Wed, 15 Feb 2023 04:52:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pS9m5-0001YG-Qk; Wed, 15 Feb 2023 04:52:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pS9m5-0007vQ-QI; Wed, 15 Feb 2023 04:52:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U6zgZIKTg+Nss6tCkfdGimx+SJz8D+cs4k3TaiwEXI0=; b=B/10F+yQWwAYn6YsbqtHVlRLlO xOVyF3WgF77fEVGdWlovpr6A+q22JwV/5kCbEhibXjcyKT2L2KlUN04WsDrq6sPWv8O5TI2tKVOf1 PeBUKnUpIC1sIQHbmjC6I0W8He9sxpyUYOvbMWxHdFFEpW/j3yl0xn062uuMnMPl3MB4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 177300: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3685e754e6017c616769b28133286d06bf07b613 X-Osstest-Versions-That: xen=587823eca162d063027faf1826ec3544f0a06e78 From: osstest service owner Date: Wed, 15 Feb 2023 04:52:09 +0000 flight 177300 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/177300/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176804 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176804 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176804 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176804 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176804 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176804 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176804 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176804 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176804 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 3685e754e6017c616769b28133286d06bf07b613 baseline version: xen 587823eca162d063027faf1826ec3544f0a06e78 Last test of basis 176804 2023-02-10 01:58:49 Z 5 days Testing same since 177300 2023-02-14 18:07:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 587823eca1..3685e754e6 3685e754e6017c616769b28133286d06bf07b613 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 06:04:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 06:04:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495725.766139 (Exim 4.92) (envelope-from ) id 1pSAto-0000Wn-UD; Wed, 15 Feb 2023 06:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495725.766139; Wed, 15 Feb 2023 06:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSAto-0000Wg-Rb; Wed, 15 Feb 2023 06:04:12 +0000 Received: by outflank-mailman (input) for mailman id 495725; Wed, 15 Feb 2023 06:04:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSAtn-0000WW-6Z; Wed, 15 Feb 2023 06:04:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSAtn-0008AS-4e; Wed, 15 Feb 2023 06:04:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSAtm-00068C-RM; Wed, 15 Feb 2023 06:04:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSAtm-0002Vk-Qn; Wed, 15 Feb 2023 06:04:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qxgppFVlJxuRlP7qVWR0osHDDJbm2/uDEOc/JYiNqOA=; b=tfS+VeLStBMCQ7J8RbTw04RVA1 RIhLonjPGg10nzE3FrpR8UI6FMEBXEynKKS9aA8Zo/sC2czzrJ03YJKo3rPnEYPPYoyp1jv3kBxaC 3zlpO0PllTWmxWp+w6kKoISLn2UhiucROiJZ7MU8vokIqKgPwHMoDdY5dPhuA4kQMaek=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177343: all pass - PUSHED X-Osstest-Versions-This: ovmf=090642db7ac124c336da72e1954e1fb09e816fb0 X-Osstest-Versions-That: ovmf=1b5420e8071b4f9ba13136f19365542dfe66bf04 From: osstest service owner Date: Wed, 15 Feb 2023 06:04:10 +0000 flight 177343 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177343/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 090642db7ac124c336da72e1954e1fb09e816fb0 baseline version: ovmf 1b5420e8071b4f9ba13136f19365542dfe66bf04 Last test of basis 177328 2023-02-15 00:12:28 Z 0 days Testing same since 177343 2023-02-15 03:35:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang devel@edk2.groups.io Jeff Brasen Jiangang He Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 1b5420e807..090642db7a 090642db7ac124c336da72e1954e1fb09e816fb0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 08:03:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 08:03:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495746.766153 (Exim 4.92) (envelope-from ) id 1pSCkf-0007Dl-SY; Wed, 15 Feb 2023 08:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495746.766153; Wed, 15 Feb 2023 08:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSCkf-0007De-Po; Wed, 15 Feb 2023 08:02:53 +0000 Received: by outflank-mailman (input) for mailman id 495746; Wed, 15 Feb 2023 08:02:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSCke-0007DU-JN; Wed, 15 Feb 2023 08:02:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSCke-0003HD-Gb; Wed, 15 Feb 2023 08:02:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSCke-0001yh-4i; Wed, 15 Feb 2023 08:02:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSCke-00021o-4E; Wed, 15 Feb 2023 08:02:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CDtwL6ec7zRpyIo8m42dTuTgKlRN3he0o4CjB9sCd3k=; b=FnNKMJrhCRyIdWKzSQY4CyGH5L 6tpJNtv5b6+9zNmCdBGkUmvVZVVFCXTxZ8VcGerIQpT4jn/WkAUjGrXflUbeyxbhXj7vlZdzIMuX7 nV5p7m4QTjneKxR6p7GYkYjWHprm6r/aqapOIu2FelxpkwfWN+Dl925D/hkp1tH5+wlc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177356: all pass - PUSHED X-Osstest-Versions-This: ovmf=68c1bedbf297b57a336a2edc046f1f9874ba69fa X-Osstest-Versions-That: ovmf=090642db7ac124c336da72e1954e1fb09e816fb0 From: osstest service owner Date: Wed, 15 Feb 2023 08:02:52 +0000 flight 177356 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177356/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 68c1bedbf297b57a336a2edc046f1f9874ba69fa baseline version: ovmf 090642db7ac124c336da72e1954e1fb09e816fb0 Last test of basis 177343 2023-02-15 03:35:26 Z 0 days Testing same since 177356 2023-02-15 06:13:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Stuart Yoder jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 090642db7a..68c1bedbf2 68c1bedbf297b57a336a2edc046f1f9874ba69fa -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 08:25:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 08:25:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495757.766165 (Exim 4.92) (envelope-from ) id 1pSD6N-0001lX-Pl; Wed, 15 Feb 2023 08:25:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495757.766165; Wed, 15 Feb 2023 08:25:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSD6N-0001lQ-MZ; Wed, 15 Feb 2023 08:25:19 +0000 Received: by outflank-mailman (input) for mailman id 495757; Wed, 15 Feb 2023 08:25:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSD6M-0001lE-6M for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 08:25:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45ccda19-ad0a-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 09:25:16 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AA8B122445; Wed, 15 Feb 2023 08:25:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2027B134BA; Wed, 15 Feb 2023 08:25:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u0zoBeqW7GMwWgAAMHmgww (envelope-from ); Wed, 15 Feb 2023 08:25:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45ccda19-ad0a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676449514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MbmE1Wtf4VhJiNMsgNW161fRTJXwfvCu/qIcBv8rhJ8=; b=N8bAgZlT5CzJ4qtwDHxrh80O/TpQicMlmbvAmR5MFYug4BXTiRtAhWIQ4Up5xFv6aMohth KeKLVA9snMRhFie7NVOcNuQo+spizSEfoheLFsGLNVIw2tHo8yEQPKX0W3sW4y+mc/blxP k6GwMTgHbAKnQIuC8N90m5JKHYiohZc= Message-ID: <51a67208-3374-bbd9-69be-650d515c519f@suse.com> Date: Wed, 15 Feb 2023 09:25:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" Cc: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" References: <20230209072220.6836-1-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Cy0WWPGNbvl0tW06hginDkL7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Cy0WWPGNbvl0tW06hginDkL7 Content-Type: multipart/mixed; boundary="------------csYOMHbl1Sx3jSwy8ZxhWIsg"; protected-headers="v1" From: Juergen Gross To: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" Cc: "Ostrovsky, Boris" , "peterz@infradead.org" , "Torvalds, Linus" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Message-ID: <51a67208-3374-bbd9-69be-650d515c519f@suse.com> Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR References: <20230209072220.6836-1-jgross@suse.com> In-Reply-To: --------------csYOMHbl1Sx3jSwy8ZxhWIsg Content-Type: multipart/mixed; boundary="------------fgjKDAC69fRYEMdiwCrziqqt" --------------fgjKDAC69fRYEMdiwCrziqqt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDIuMjMgMTk6MjEsIEVkZ2Vjb21iZSwgUmljayBQIHdyb3RlOg0KPiBPbiBNb24s IDIwMjMtMDItMTMgYXQgMDc6MTIgKzAxMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pg0K Pj4gVGhhbmtzIGZvciB0aGUgcmVwb3J0Lg0KPj4NCj4+IEknbGwgaGF2ZSBhIGxvb2suIFBy b2JhYmx5IEknbGwgbmVlZCB0byByZS1hZGQgdGhlIGNoZWNrIGZvciBXQiBpbg0KPj4gcGF0 Y2ggNy4NCj4gDQo+IFN1cmUsIGxldCBtZSBrbm93IGlmIHlvdSBuZWVkIGFueSBtb3JlIGRl dGFpbHMgYWJvdXQgYnkgc2V0dXAuDQoNCkkgaGF2ZSByZXByb2R1Y2VkIHRoZSBpc3N1ZS4N Cg0KQWRkaW5nIGJhY2sgdGhlIHRlc3QgZm9yIFdCIHdpbGwgZml4IGl0LCBidXQgSSdtIG5v dCBzdXJlIHRoaXMgaXMgcmVhbGx5DQp3aGF0IEkgc2hvdWxkIGRvLg0KDQpUaGUgcHJvYmxl bSBhcmlzZXMgaW4gY2FzZSBhIGxhcmdlIG1hcHBpbmcgaXMgc3Bhbm5pbmcgbXVsdGlwbGUg TVRSUnMsDQpldmVuIGlmIHRoZXkgZGVmaW5lIHRoZSBzYW1lIGNhY2hpbmcgdHlwZSAodW5p Zm9ybSBpcyBzZXQgdG8gMCBpbiB0aGlzDQpjYXNlKS4NCg0KU28gdGhlIGJhc2ljIHF1ZXN0 aW9uIGZvciBtZSBpczogc2hvdWxkbid0IHRoZSBzZW1hbnRpY3Mgb2YgdW5pZm9ybSBiZQ0K YWRwYXRlZD8gVG9kYXkgaXQgbWVhbnMgInRoZSByYW5nZSBpcyBjb3ZlcmVkIGJ5IG9ubHkg b25lIE1UUlIgb3IgYnkNCm5vbmUiLiBMb29raW5nIGF0IHRoZSB1c2UgY2FzZXMgSSdtIHdv bmRlcmluZyB3aGV0aGVyIGl0IHNob3VsZG4ndCBiZQ0KInRoZSB3aG9sZSByYW5nZSBoYXMg dGhlIHNhbWUgY2FjaGluZyB0eXBlIi4NCg0KVGhvdWdodHM/DQoNCg0KSnVlcmdlbg0K --------------fgjKDAC69fRYEMdiwCrziqqt Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------fgjKDAC69fRYEMdiwCrziqqt-- --------------csYOMHbl1Sx3jSwy8ZxhWIsg-- --------------Cy0WWPGNbvl0tW06hginDkL7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPslukFAwAAAAAACgkQsN6d1ii/Ey/R hgf8CPaUEeIsGvhWfpmpcguxPSsjWCyiWLtx7t0ih4cAeHPW5vU/XF2PRT+03qGfHYkbo881k6ar cqov9iEr2bj5NpReSfCjr7ia6/V+24pUfr0MgT+oOWmG+G7FAYM4bp03YgFpqm7JdVe1j+DkL500 FNX5FbhXmnz3oARUOWhhNcx/8od4JygkktvDvroLtRLwkRbnNvclplLWOXu8bGOxquk2EBC7zzTf H/qjRx/38Um8Oe8S1ytJaS8+m6ioNzxCRv7YwuyDFHnsJMWScyjg0bLwcex6vbBRvG1SpObFpPBY tm/yIiJpZIcj/x1iYyzpgGvMvbHLaYkRplgePePxvg== =ufOE -----END PGP SIGNATURE----- --------------Cy0WWPGNbvl0tW06hginDkL7-- From xen-devel-bounces@lists.xenproject.org Wed Feb 15 08:31:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 08:31:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495762.766176 (Exim 4.92) (envelope-from ) id 1pSDCd-0003Qo-EZ; Wed, 15 Feb 2023 08:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495762.766176; Wed, 15 Feb 2023 08:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDCd-0003Qh-Ba; Wed, 15 Feb 2023 08:31:47 +0000 Received: by outflank-mailman (input) for mailman id 495762; Wed, 15 Feb 2023 08:31:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDCc-0003Qb-8c for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 08:31:46 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1a::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c7a04d9-ad0b-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 09:31:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9498.eurprd04.prod.outlook.com (2603:10a6:10:360::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 08:31:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 08:31:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c7a04d9-ad0b-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5VU1312sp8NrJIUl1riZ3dKLSr75d/JF3hQbW/O1k8MbrxLjBImGq0FD1hZeBW+2K3Z3DgsvGwHleopKEH/L21BnuHrh1ixWc+fMwYMfM4pL3O9MBsbSVLvy2xiEM5srytn827komVwL8B0XuduFXEbqrk9fnsMm6fkD0wBfH45x01tas3TzIXSIGgAHz1xicd8LqmwNK2hyLijAcsfkUvoHAajL4CFPm8+uSAnm/0qpw5IepU6dgrUV4O72YVjqGH5Ty84HAEm4cxZn0N5NIUfF7Z54dgbgRajn0KVb8XmxzCQINbVsjcK1mAQAGpO5bNy0snzRUhj/vwrXW8OWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KVIM5suLFeTH2CsLZFTDkv0CpL4BN3DjyXX8/2ikmEw=; b=V4IMvoOZmNmpg3qlet0sjSfGej5SvLnfknkZCvIGSaFb7vsvvvvX3LYozJBSfj7Rz5FWw9xETXPb2VrZWWDyqyjTYMKd/6vfss27Ii+ZKhkgGpO/tFCZbrECeM+fJmoes4A2Cyq4F3zvBiLbN4h6OwOgzU/Jt5vQXWDFyLOiq8VJmC15FBnVLy5uIxzd5tBtFbgOJGiJuQelN5zylOKGIBCNp0huAKA1CHGz8r/8+WGMlyF+BnBF0J6snjlKO6Aq/RbmDJfgvjbxCljKV1jgNgsLKU04NF2MdHxwRDH+b1bSMK/bhdRoULP8DElZArsRl2jTibNJCQ810NfymXmbhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KVIM5suLFeTH2CsLZFTDkv0CpL4BN3DjyXX8/2ikmEw=; b=dZAQaDfvgynf3ixjmf0MrIHL2y7w2h3jAQMEfkzBImyz8m30AkLA5hx+XV1mTE6WxWMTw0G/7HvW6u0ZzVa2rjwyHCru5rbtuHdEDQzqKgO8gJBcH2n6WO3vDprfzobimaW236iyHd0hYzluvuoAOklORi/nKF4jx/DcRvQmsu+t02kF+BuDN+Yd6SVlaJxcqxIuz9tvEa1qomL7KJqZeRxeHHva/oHJVDVVFTX8wftAPL7/YG2+TZJcgNRFFMPxwmtJpMsmZn9Oa9nZK7qo9Fy+Rfdqf72JMB45QI3/Hnr8yNAqAbQbucdZ6el37baBG0MsbXKT3bExu29sTUZc/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 09:31:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , Juergen Gross , "xen-devel@lists.xenproject.org" References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> <4e66865b-11ce-cbd1-d115-13e3743eed7b@oracle.com> From: Jan Beulich In-Reply-To: <4e66865b-11ce-cbd1-d115-13e3743eed7b@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9498:EE_ X-MS-Office365-Filtering-Correlation-Id: 41fdc847-27b8-407c-d9c5-08db0f2f0f3a X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9/B2tuWDAbTlEeZb1zaUkzZ8dfZ+96KkhFhmCDw9OM4RUcPJgEV9b+/AGyPamuUbIM1AfgAexERiWebQlGI9YYROaHgZG3lQxBfT+RsFGsYw+x7+T6sYYmABF+tTZ+qSgcIlF0XqJaI1JoUUbO11S8vsr/z8ema5DdXbd6zKleXjSm3aUNehYXpXGCgL2qzfnq+XHhnbjantIfZTXBDPzwkhbDEki+EvWD/pyCZOBx2HL+UD0qpA5EZs3jH2kR+pubETHGO2QWkyg4SISafaJvIpWFQv0t/j9GmmyF1wQxxjHw0VwgraKQ+9va8MlnHrlByX6phdW05ts6sLC4a+gRkruut+jRgNj8Vne4NuBfsnc5uqYn4oPTfGV+1f6mjORZLYYhi4naLkoJXYmD3B+dCOHDWA/tqG7sdPv1eGnrNmBtXAQVC22gfZC5HCTjHBeCctNLUqdGZTv5dgOJ6ej4lgeuDWZNsw9v7wNfCd0l9blMupF0GiIi9bJrd/X7vx8jZ+vys+qwnW9g3wanlNS0gDIKsPnfn5HziEEVQCKTDhdJ3Csx2yzqtZxc6eEcl1tmK4qPEwy5XS+JFIdH+sdYifOsjNakkn+quczI4uucIdwVs9xjUTAWWxwj2MdVPNaZpfWT45ROde4Fa6QlmwFlYtqy3XFYdmpeTL3xkKGYRCNqysW0Ki/Qwfj71WR1jvMODquFP7ooRQsRtMLt/04waESnRu9Jpv9Qf60X/ZcGo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199018)(8936002)(5660300002)(86362001)(8676002)(6916009)(66556008)(66476007)(4326008)(41300700001)(66946007)(54906003)(2616005)(316002)(2906002)(6486002)(36756003)(31686004)(6506007)(478600001)(186003)(26005)(6512007)(53546011)(38100700002)(31696002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEhjTUpGVG1BcW5sQmZvZmE5NTBQVGJ2SlJsRTM2Y2FXcTVYRm13d3lGWDlt?= =?utf-8?B?N2RkRmNUdS9YSUdvcEV5eWlaV2RObWExbWdldzF3YmU3UVhCWFRMOE9rYjlX?= =?utf-8?B?WDBrNitUV21YOVcya25SblVqaXpBQ3VWTzZjS1crVVpwZ1hEYkpCaVVVZ0pW?= =?utf-8?B?azY0RUpXaXd5R0xHaUlyUCtzUXV0RG13Z3BRT05aSlk4MkZzVzlGOGNnU0Vx?= =?utf-8?B?aHNCWFFCWFNrZHBmKzNNUldPeGVkZjhGS1E0cDZyeGRsMVJoSHJtYXhFK1RX?= =?utf-8?B?dEdJaTZ3SVFjcXpLRitvb2FSU1FsV09HV3loTUJESE13SGFmQ1VlMkU5Q1Q5?= =?utf-8?B?VWNvbGpnU0lkckwzelRUZ0ZlZG1oei9TK0w0UUlYQ3gwVDVWeU9nOUlmWEY2?= =?utf-8?B?RmVIOXl6MmovWkhGVFdXNFdPTVgydUNlWUFteFJtM3dvaTc5eC8zK00zQ1Vq?= =?utf-8?B?dzV5a1pqSGVUWnZUZ1NjUnpXY0duR3d2dzAxOFJKK0kvV1VFK3QrS3gyR00y?= =?utf-8?B?SGs2SVRLeW9IeFg3dXg0MkptVzN2Q0xiSXo1Q3hMSXZpdE1wSFdhUzJxcSt4?= =?utf-8?B?WFpoTUtCKzJaSjE1QUJYTkJoSzdUeU8vODdNWjhvOFMvajcrMmd4SFAxUWU4?= =?utf-8?B?TlBxeElZSk5OdXdsMDR1cVNTNEc5eTZPeStEdzNEYTJBeE1FUC94YXpIczcw?= =?utf-8?B?OGlVNjY0KzJmTk1PMXZ4WTRpNDFNc2hIQm5iQS9MK2d4RUE1UWljUVVKNzJ2?= =?utf-8?B?aGJsMDVtVUVhbkk4Z0RVN0lsTEZvREZVcGZ1RVovMzhTT2NmZmo0cncrRlBE?= =?utf-8?B?Q24vanNHUEcwYSt1bm00WXBvK0thOG5CVWFVVDlTdFFuTFl4SUNLdXd1YXFL?= =?utf-8?B?ZkNVOWtJVGo3bjJVUnB2MEZ3SW5kM1hMaWUrZWdGb1FvNXdBQ3Z5c0FNUmtL?= =?utf-8?B?ZW5oTkVPN25VWHhMQm5BUm1xc052WTZhNW45NStNcmQwYktpMVJ6UTRJK2hV?= =?utf-8?B?bENHRzRFeVR4OU5ia05lTkQ5T3IyK1ZsWVFpcFlCSjZPUFBOMmV6SHpuM0x5?= =?utf-8?B?Q1gwY0svbUFkQnY0OUFrTXlYUWJpdGpRVWhWYzAxRXF0QytIcStvWS9qOUFy?= =?utf-8?B?bHhYVjZBYUdkWnNvTFVQVHdhRzBPRmhKYjN1bUU0cXp4RHBOSVlkU2E0M0M0?= =?utf-8?B?THl4U3Jxa3NEa3FJUENkSTNMbjd2NUp2ZHdvMGJjMG9BZFh3L3FKejVIRERk?= =?utf-8?B?ZklncExnbVdNNXA1UzB1bWR5OWREZU1MVjQ3a1VRcytOYUlxQ2puY2swWStH?= =?utf-8?B?STZDMmJJaktFN2Y1TExyRnVIUHI1R1MyVG9CVmRpUUQ5OU1tZTh2dFBtd2Rp?= =?utf-8?B?Rmc5djBRYjU2SjRqRUdYVVlDaml2U25ITnZKaDE1M3dZMi90ODhtY0wvaG1I?= =?utf-8?B?b3lqVW92bXJvU1RlS0tSMzVlbEVVU0lkZ05oMEg0ajZjc1E2TFBZNFgrdXFm?= =?utf-8?B?SmV6bXE4RnhjQkF2Z2pLT2oyWjFKQnovRS9WazZMMDJNeWVscFU4MVFWWnVK?= =?utf-8?B?dUwvUGpDRGRTNXNrSkRrUHp4RVBCMmxBOU9QdXIwN2xob3gydHBXT2RnbmFJ?= =?utf-8?B?eDByeWJITWlSTCs5UGRuazRLaS96TjQ3ZUtDaUV1bGZhb0FoLzJPUG54NGtB?= =?utf-8?B?akdYbWxKaHBpcWg2L0Radis3eVJSSXFMWEt6WENOOUNHbGhyNlhaSXRCbVRi?= =?utf-8?B?eCtIU2VISG42bG1tTFlHZ1F1TkYwU2hQd2RuNm1jdGhjaHI4MjMwOE5ERktv?= =?utf-8?B?eGtIYTdCWEZGU0Fud1p0ekk2N1c4UWVJSy90MElMS0NVVHFRcHBPS2VnZ2RW?= =?utf-8?B?a1Fzc0toMXEvK3pDYm52ZjdyWGpFUHZVNW43Q0FlRTh1ZnhheTdJS3lma2Nl?= =?utf-8?B?WEdmdzIwbGJOakhncDNsNEJDR3ZlQkRSblpzenRTcDY4ejZoZjlHYTJOajFo?= =?utf-8?B?N05pQnZMQ0dPNHFoWVIvSkNURURYTlBwcmV5NTk4UlpHdVE3UnY2K1ExdnNl?= =?utf-8?B?MFlYS3U2QTQrejFwS2JCclJzUGxpeE1hQmFveDlxbW9xdlc1T1RhSElkTnFY?= =?utf-8?Q?7pPvMkw+yLotTfnXEOLtXPjUK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41fdc847-27b8-407c-d9c5-08db0f2f0f3a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 08:31:39.8170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S2dDS7QjrEusz0J6dyIRM1AxoTulEWeZKFMHHzir+qJej58l4WeJHD7vlhiSuPHD1EhM/xUoTTraA1g2quFZxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9498 On 15.02.2023 01:07, Boris Ostrovsky wrote: > > On 2/14/23 6:53 PM, Boris Ostrovsky wrote: >> >> On 2/14/23 11:13 AM, Jan Beulich wrote: >> >>> --- a/arch/x86/kernel/cpu/bugs.c >>> +++ b/arch/x86/kernel/cpu/bugs.c >>> @@ -18,6 +18,8 @@ >>>   #include >>>   #include >>>   +#include >>> + >>>   #include >>>   #include >>>   #include >>> @@ -32,6 +34,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>   #include >>>     #include "cpu.h" >>> @@ -934,7 +937,8 @@ do_cmd_auto: >>>           break; >>>         case RETBLEED_MITIGATION_IBPB: >>> -        setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); >>> +        if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) >> >> >> Is this going to compile without CONFIG_XEN? Yes. The declaration of xen_vm_assist_ibpb() is visible (satisfying the compiler) and DCE will eliminate the call to the function due to xen_pv_domain() being constant "false" in that case, avoiding any linking issues. The interesting case here really is building with XEN but without XEN_PV: That's why I needed to put the function in enlighten.c. This wouldn't be needed if xen_pv_domain() was also constant "false" in that case (just like xen_pvh_domain() is when !XEN_PVH). >> I also think these two conditions should be wrapped into something to limit exposure of non-Xen code to Xen-specific primitives. I would have done so, if I had any halfway sensible idea on how to go about doing so in this particular case. In the absence of that it looked okay-ish to me to reference Xen functions directly here. > Oh, and this needs x86 maintainers. Eventually yes. But I would prefer to sort the above question first (which I'm sure would have been raised by them, in perhaps more harsh a way), hence the initially limited exposure. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 08:56:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 08:56:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495767.766187 (Exim 4.92) (envelope-from ) id 1pSDaZ-0006L7-Ez; Wed, 15 Feb 2023 08:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495767.766187; Wed, 15 Feb 2023 08:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDaZ-0006L0-CB; Wed, 15 Feb 2023 08:56:31 +0000 Received: by outflank-mailman (input) for mailman id 495767; Wed, 15 Feb 2023 08:56:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDaX-0006Ku-Oy for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 08:56:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDaT-0004a7-At; Wed, 15 Feb 2023 08:56:25 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.85.33.158]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pSDaT-000749-3P; Wed, 15 Feb 2023 08:56:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ChXxNLgZrt8cs+YdRM5CSWoalFYptnizjkAY8RQ3toU=; b=F3XfCPN6Cu9I3f5gDQHabwHfhK wL9Nw4T/z92a5vFwsG/BM0tHYgM72w8aQ0tX8itpLeG4VUfpmaH3PIC2CaKfpH/4j2ikoZln+uxC+ h5J6IfhUvCgL2yO8DEHD6+/2h1SS+c1blyFegOBwNCY2QEv9BdnMxa3dd20+AUhG/N+A=; Message-ID: Date: Wed, 15 Feb 2023 08:56:22 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Content-Language: en-US To: Stefano Stabellini , Jan Beulich Cc: Luca Fancellu , wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 14/02/2023 22:25, Stefano Stabellini wrote: >> Patch 1's example has a "comment" field, which no entry makes use of. >> Without that, how does it become clear _why_ a particular file is to >> be excluded? The patch description here also doesn't provide any >> justification ... > > It would be good to have a couple of pre-canned justifications as the > reason for excluding one file could be different from the reason for > excluding another file. Some of the reasons: I think the reasons should be ambiguous. This is ... > - imported from Linux ... the case here but... This reason is pretty clear to me but... > - too many false positives ... not here. What is too many? > > > That said, we don't necessarily need to know the exact reason for > excluding one file to be able to start scanning xen with cppcheck > automatically. If someone wants to remove a file from the exclude list > in the future they just need to show that cppcheck does a good job at > scanning the file and we can handle the number of violations. I disagree. A good reasoning from the start will be helpful to decide when we can remove a file from the list. Furthermore, we need to set good example for any new file we want to exclude. Furthermore, if we exclude some files, then it will be difficult for the reviewers to know when they can be removed from the list. What if this is fine with CPPCheck but not EClair (or any other)? > > I take that with this exclude list, not accounting for rule 20.7, > cppcheck reports zero violations overall? So the goal right now is to have zero violations from the start? Shouldn't it instead be that we don't increase the number violations? If so, we would want a baseline including the files that have "too many violation". The advantage is it will be easier to reduce the violations in small chunk and the reviewer can confirm that a patch help. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 15 09:07:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 09:07:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495774.766198 (Exim 4.92) (envelope-from ) id 1pSDkh-0007zi-Cq; Wed, 15 Feb 2023 09:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495774.766198; Wed, 15 Feb 2023 09:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDkh-0007zb-A0; Wed, 15 Feb 2023 09:06:59 +0000 Received: by outflank-mailman (input) for mailman id 495774; Wed, 15 Feb 2023 09:06:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSDkg-0007zV-Jj for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 09:06:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7d00::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18eb7269-ad10-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 10:06:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8688.eurprd04.prod.outlook.com (2603:10a6:102:21f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 09:06:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 09:06:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18eb7269-ad10-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8urDbEM7dghsVBUxUYrsI1G19o6qoe8qZj9Er/2LChMLMc8be8Ir3/UMrKsMsKK8/m//e31XKnYt+AsFuOBxr9DmTuCPtHxM9c2HHhKa4IoGYORc7Qu2HtXhVAnoGVSDkB/g08meS9rUUBGLUTYarpHBIKldpAHT1Y7lKtVpteIugThf5jBFexI3Vt7Q0+EsR9GUL9IZSW/Jj3vk9nRf6U5WCob10IXPRmhyAQfoJxVOCs7kWqzHw/HoXgydm+LFrdISorE9uYN8iksh9iBwDZ6c30c2qGwGEhKLX2CpI/j/nUB3GxGHaoEWqQJw701VMw/XwbpbZ0N6Efso+evEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAMQHtUU+jC5CWIjD7TLCZeWF3JSpL7vegAHmsKnp38=; b=FjA3TKlrVuEvJ+vOGipnjw9tAkj4cZGkIjZfbMU08fWbnfcqNpwuWnQuHS5kO5oBpLkQ+QKCcnzaD+ilRUTwIDMRb7I928FZZlDAZsM6rYiyEtCBIXAeVb2ujU60N2t7K/1i4YGbOIUG5VXbnx17PUlJ6duIpVj8fY+MFvdqvNFf/+ODN/p0miWCK6EplzDYRYZMtB9i3RpvnVdvIBCOJwfcALUYJWeEJlQUdPvvVRvzj6djtSPWfEz33zwS+Pzt4r7swBicC/PoJ4vynuDOXF5NCZjc9UuGVig+SN8TYt78pzYBRY02fiIGDtEBtha8oAcuvuhv9eyKvQNggAWRZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uAMQHtUU+jC5CWIjD7TLCZeWF3JSpL7vegAHmsKnp38=; b=YyXJYLtS2+hVTa2vTeJU6+JFOBr7wZS9lTcU3MiCFTaQuTnnK19TqNuiNlIO35gW6CP3hub2CpFlZ703AzAxM0e0J2qCC9DcoAIsiSgQHdFCm5iBHm5ik2u9AkGjAhu8Rf3Zudt/LqI0nhdoQBJdpRj4wjHv0x9ux5iDt8T/xrbSuzKHW1jPbY4T0ROyDuMAUq5jrXU95Cdb642i3lOVUiFFbQ90A/+DZvgK6Cl6WO3Pyczko3L18aIDrAgtAD5y6DgeF953Qqxfv7QsESZaJQlS8/jKBBRBw/o7j+b8jrO7kSupG73LWeYpcFKdlOzFHv0+bb2t9+acNZE620alNQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <601d0ee8-3522-74b9-a6a3-9a5ac00c8093@suse.com> Date: Wed, 15 Feb 2023 10:06:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH 01/10] xen: pci: add per-domain pci list lock Content-Language: en-US To: Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , "Stewart.Hildebrand@amd.com" , Stefano Stabellini References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-2-volodymyr_babchuk@epam.com> <87cz6b3ji7.fsf@hp.mail-host-address-is-not-set> From: Jan Beulich In-Reply-To: <87cz6b3ji7.fsf@hp.mail-host-address-is-not-set> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8688:EE_ X-MS-Office365-Filtering-Correlation-Id: bbedd4a7-34da-4aa8-7c2b-08db0f33fb8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3lqrT/BHU6oDr1NZlZEmyErABJemSo+/xVYQoKMQFzGJ137puNw8KFA9t+ohnwvqTJDF29o5Syft4SdDGIyUijpc0bJZNX3E98Ltb0DhwsIouzhVM333+7c/tQCNWzmqeGM7kGTcJmACP5HxTztxR3+arVL45fwJK2WazAaoyRwuqW5R1YYYL9Dbn3BM5dP8fwrLNhDOzfwj/LClgDGsvlNjFZZTsSz1JHURXVBBdbRRE7nb9yZnDneKe1rH2h8rsfkErV1bdFAPG90c26AqqN5COnZnCEC5miIdazGgRKU+isuDkO8uEuBofjwL7DWu7+3xCK+T33WPOTODqsQ2vtSWWWSWuL4dzp+1SUzRZmdO05t8KE+R7ZQL3g7bU+PmuX5CYft3xQcvQ+iDhvdRMG5+5ryJ7u4NPGcu/gIc/7w7XO+UiV7isTOw1AgzL9iSlmwjvnCtHZeXqS9sQEnAXpPLbO8L6i3goCGTLERUQIJKhwak7o61tpDXiAX23o1ALXT0YstjauN6MnDC9UgHX2eVeqByWBVgX6oSccGGF2Uwrn8p5JMvt317m/mtOEmEEa70B7GhFn/8EpM1OmqKRMI3/8sJ9vUU/nVrjTF6CnLUC0EQfnU1N+99q/l4anluAUtfYeovvyZqqcPt/x6d4hOjqCYHw+kMuUlpEVU2Ig6Jjb2xaUj1a4Y26vaIyIkDGEb1fNs+mqzlU2O6LzSnxEqKPiuAmn4GMQnsFtLG3PI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199018)(31686004)(36756003)(86362001)(38100700002)(83380400001)(6486002)(2616005)(6512007)(53546011)(31696002)(6506007)(478600001)(26005)(186003)(66476007)(4326008)(8676002)(6916009)(41300700001)(66946007)(5660300002)(7416002)(54906003)(316002)(2906002)(66556008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFdZS2huZWM0S204WVd3RjcvYjMwbUZRSHpaYVdPenFXMWdnMk9uMTRwaU5q?= =?utf-8?B?Rm0vbkt2WGU5alkrcXNTc0dYMG5IYU44WU9QRmszU3RJN3kxRUp0OUVPQThl?= =?utf-8?B?Mi9IQjlLckxIOUN1VFY1aWxwSnFVNWtOdTROOE90RmlJSGlWTVRxWjJYNWNa?= =?utf-8?B?R0JOclFLMG5admRodlJuRkxtWlBDbW91N1ZJUURwdjJQMy9OcmFmdUYyaTM3?= =?utf-8?B?YXF0bTk2N1Qxdis1NVhOeGN3RmxLYkhaVzZ4a0Q3LytYbzgrcWVPVVkwa2Ry?= =?utf-8?B?MktNOFJNL09IVDJsWTFtVUMyc1duVHd5bWRlSGRXa2d5ajBIZzRDdDczRWEw?= =?utf-8?B?cHJXbVVncTFmSjBVRXJERDliaFJYejduNnh4NXc3Q3AzcVRNK245ODEyTisv?= =?utf-8?B?eDlvL1Z3YmdIV0JMclJ4MndwLytMcHloNGp3c2FmYmRtWVVFUVFQR3lHRnhy?= =?utf-8?B?VmsrL2FBTFRjRlZvTDhDVXMwSUFEQ2YrZDlQbk02Rkl1eHNNc0E2ckpmZ0Qr?= =?utf-8?B?dCs1MS9keE9OVndKbnNoN3lRRlVNUzRzU2JhMlFZN0h3eTBsSmwycGREbHo4?= =?utf-8?B?MlQvMTloaEVCWWt6VGpURzVHUTQ4WGk4aGdZTlNNTHR1QUFCdlFxU3FBYmtW?= =?utf-8?B?R1BUcXZlSlltZHlZMlBtdmw4OWc1a0hVaVdWWVUxYzhYVmovaDJDMHhSMEF2?= =?utf-8?B?ekt2aE9ydzJXZFUvK3djOFN0UTB3K012T0krNitpaXArZnR1Y0t2dU1UUUww?= =?utf-8?B?cGp6K1dpdXozVlpCL1AvZXJIMVBJUVB0aktZbDVMSzVKbHJSUEZYWFlMMTFN?= =?utf-8?B?Q2t5TnNRUnBDYVhCTjJoSGlrd1o1OE5mZk9zakNuVTcycVNvNS9MNTJZa2Rv?= =?utf-8?B?VDhTTTRrSERNbDBaU3FKUGdiemxndmNkbjVmOW91Y0duZkRkZW9VRGlaeVds?= =?utf-8?B?bm5LMml5ZDhaU2RWYjZRMVBlYVIvRDBXdUY2eHB2VWpraWoyT3k3TkREd2lq?= =?utf-8?B?bnZvb3RrV1RJbVV3TVl4ZGYwa3J4WTJKd1lNNVNxeG5DVzh6TE42SzM4MUNq?= =?utf-8?B?RkpseEs4NFd5bDdENzlRR3V4WlFyaWhURmN0YzdqYlNzd3ZEc014cEZuU1lz?= =?utf-8?B?MmVHNHpwTCtua1pWWCtvRGpDZS8ydDdDNktkN2g2L0VJQ0FScndCalE1NHpV?= =?utf-8?B?OTBNZFV6VVprTjREMHhDallRdWtvL2Z1NXJZbXordWFTRFdNWDBuMEJiVk1q?= =?utf-8?B?aUIvRFdTN2o1RWNoOGgwK1Ezeit2TjFiNUcyMWwrNWtvU3dLcDZSSGp1cG12?= =?utf-8?B?VE1hZ3FmWnZ0QVlyUGhvUko0S0hZeWIzQVdDQ3NxVlpsRkJDUFVDVzZnWFND?= =?utf-8?B?MTRWd29wa0x3d250Nlpla3g1WWNVcTVkeEh2RVJsZnFVcnBqNGI1QXhhNklG?= =?utf-8?B?YTJXc3JNNm9vYlBFYndReFJpa2Z1c0d6Y2NWWExVeTJYYlRjb25ZZFRWNGxF?= =?utf-8?B?dlBIUWhMdHdPTDVyWkdJZHphc2hveUgvK2ZNRUh3WFJPekNGZUkrUjJBQWEz?= =?utf-8?B?SEhoYnhiakRBWEZMRUtvWjArSDBjaTlMc0REY0FyZlRwNXV0dWtSeGc3NFF3?= =?utf-8?B?dHh2ZDhJZ2Zod2c3Vm10NU4zY2NJTzJ5bnkrNEw2UTVFUmgvWFVLRVh6bVkz?= =?utf-8?B?WWhyVFAzelhNWStWUlpVYlNzTCtxYnVUZzl0WE1wUzA3VHRmbkJxU0Q1SmV5?= =?utf-8?B?VW5jSlN4Y1ZNQVlFTE9SY3k4WDlkYk9xZExLVlB0R1oxTUhTQXdOcGFjU25P?= =?utf-8?B?dFZ4YzlvUGpIWGdJSWVIMTQ3K3hHdU9qOEtuZXEvZFBOKzRlUnk0NmNzRXpu?= =?utf-8?B?L1dHaDEzWHhpaVFqVTFOUGdhYmFHVWxzWEl3RTB4dE9SbmxGUnVKK2tDWHZq?= =?utf-8?B?Y05PTEFhVEZVSFZzY3N4K1JxWUFPc3dXdFZqdStKaFRmUWZyR3YvcTc1ektT?= =?utf-8?B?ZEFZSFFZQSt3NGY1RFBva2Q0L05Jd3VKajBpcG9CM1oybFg3MmVqNnFtbHox?= =?utf-8?B?eVhWajRKSHNsdmdVWmFCdFQ1dUdoK2lXcVV1Q1Q0dW9uZzlrSTlqUVV3K296?= =?utf-8?Q?RM/jUh9yZ2hF2oxDG9wmRyHUP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbedd4a7-34da-4aa8-7c2b-08db0f33fb8e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 09:06:54.3412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hLjMJW+NyUR2G0nBsj9ocidjH/Qt6lp1PP1hbHeXqzAj89wuHk8blADb8JqJB/HRW5z2UgdKBXAo9aA7kqSMAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8688 On 15.02.2023 00:38, Volodymyr Babchuk wrote: > Stefano Stabellini writes: >> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> 1) iommu.c:reassign_device_ownership and pci_amd_iommu.c:reassign_device >> Both functions without any pdevs_lock locking do: >> list_move(&pdev->domain_list, &target->pdev_list); >> >> It seems to be it would need pdevs_lock. Maybe we need to change >> list_move into list_del (protected by the pdevs_lock of the old domain) >> and list_add (protected by the pdev_lock of the new domain). > > Yes, I did as you suggested. But this leads to another potential > issue. I'll describe it below, in deassign_device() part. > > [...] > >>> + spin_lock(&d->pdevs_lock); >>> list_for_each_entry_safe ( pdev, tmp, &d->pdev_list, domain_list ) >>> { >>> bus = pdev->bus; >>> devfn = pdev->devfn; >>> ret = deassign_device(d, pdev->seg, bus, devfn) ?: ret; >> >> This causes pdevs_lock to be taken twice. deassign_device also takes a >> pdevs_lock. Probably we need to change all the >> spin_lock(&d->pdevs_lock) into spin_lock_recursive. > > You are right, I missed that deassign_device() causes > iommu*_reassign_device() call. But there lies the issue: with recursive > locks, reassign_device() will not be able to unlock source->pdevs_lock, > but will try to take target->pdevs_lock also. This potentially might > lead to deadlock, if another call to reassign_device() moves some other > pdev in the opposite way at the same time. This is why I want to avoid > recursive spinlocks if possible. > > So, I am thinking: why does IOMMU code move a pdev across domains in the > first place? We are making IOMMU driver responsible of managing domain's > pdevs, which does not look right, as this is the responsibility of pci.c The boundary between what is PCI and what is IOMMU is pretty fuzzy, I'm afraid. After all pass-through (with IOMMU) is all about PCI devices (on x86 at least). Despite the filename being pci.c, much what's there is actually IOMMU code. Specifically deassign_device() is the vendor- independent IOMMU part of the operation; moving that ... > I want to propose another approach: implement deassign_device() function > in IOMMU drivers. ... into vendor-specific code would mean code duplication, which ought to be avoided as much as possible. > Then, instead of calling to reassign_device() we might > do the following: > > 1. deassign_device() > 2. remove pdev from source->pdev_list > 3. add pdef to target->pdev_list > 4. assign_device() I'm not sure such ordering would end up correct. It may need to be 1. remove pdev from source->pdev_list 2. deassign_device() 3. assign_device() 4. add pdev to target->pdev_list (or back to source upon failure) which still may be troublesome: The present placement of the moving is, in particular, ensuring that ownership (expressed by pdev->domain) changes at the same time as list membership. With things properly locked it _may_ be okay to separate (in time) these two steps, but that'll require quite a bit of care (read: justification that it's correct/safe). And of course you could then also ask why it's low level driver code changing pdev->domain. I don't see how you would move that to generic code, as the field shouldn't be left stale for an extended period of time, nor can it sensibly be transiently set to e.g. NULL. Additionally deassign_device() is misnamed - it's really re-assigning the device (as you can see from it invoking hd->platform_ops->reassign_device()). You cannot split de-assign from assign: The device always should be assigned _somewhere_ (DOM_IO if nothing else; see XSA-400), except late enough during hot-unplug. But that would be taken care of by the alternative ordering above (combining 2 and 3 into a single step). Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 09:36:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 09:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495785.766209 (Exim 4.92) (envelope-from ) id 1pSECs-0003jT-R2; Wed, 15 Feb 2023 09:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495785.766209; Wed, 15 Feb 2023 09:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSECs-0003jM-Na; Wed, 15 Feb 2023 09:36:06 +0000 Received: by outflank-mailman (input) for mailman id 495785; Wed, 15 Feb 2023 09:36:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSECr-0003jC-ND; Wed, 15 Feb 2023 09:36:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSECr-0005Z4-Lw; Wed, 15 Feb 2023 09:36:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSECr-0004eN-CN; Wed, 15 Feb 2023 09:36:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSECr-0004Ca-Bp; Wed, 15 Feb 2023 09:36:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=47XZQja9Y/p6WpY0muWi5PJgE36eLitfJqtd8+jh/5M=; b=POcYQceARocIxjzezjUxTrpEfy ygj05hP2PRVNDOgTmy9g1CIMKn4aiVu7MOYLXCl6VtNRkpcI34omJiIzSbhE8gP7OQlA6A4osnAYL 9EnB/hvzn+98YFm5vntok1fAwOVhxrKnLCPG5vuul0z5YQFD5bLcxFHEf3OnSIq/qs/E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177365: all pass - PUSHED X-Osstest-Versions-This: ovmf=77d6772708541a2ddf093af79816dd1831581388 X-Osstest-Versions-That: ovmf=68c1bedbf297b57a336a2edc046f1f9874ba69fa From: osstest service owner Date: Wed, 15 Feb 2023 09:36:05 +0000 flight 177365 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177365/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 77d6772708541a2ddf093af79816dd1831581388 baseline version: ovmf 68c1bedbf297b57a336a2edc046f1f9874ba69fa Last test of basis 177356 2023-02-15 06:13:53 Z 0 days Testing same since 177365 2023-02-15 08:13:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: JunX1 Li lijun10x jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 68c1bedbf2..77d6772708 77d6772708541a2ddf093af79816dd1831581388 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 09:50:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 09:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495807.766228 (Exim 4.92) (envelope-from ) id 1pSEQz-0006eZ-6R; Wed, 15 Feb 2023 09:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495807.766228; Wed, 15 Feb 2023 09:50:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEQz-0006eS-2u; Wed, 15 Feb 2023 09:50:41 +0000 Received: by outflank-mailman (input) for mailman id 495807; Wed, 15 Feb 2023 09:50:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEQx-0006eM-Ro for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 09:50:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7e1a::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32e650b4-ad16-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 10:50:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7171.eurprd04.prod.outlook.com (2603:10a6:208:19c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 09:50:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 09:50:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32e650b4-ad16-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdhl2co/NCSjELnfPgyFZ/9hOT1Mgmtbi+46GOPK//CITGSe9SyGAS3vqHywM6eVvi5Tjv+7KTpx1ccERAYVnsNt0Ps4+uVSDTwLFhtA+0jPIvKf7P0YE7Fe8sr3bZF/u0rJ8qZSI9KVMxvMdlpCCfS4NYiSbcj0zs7Yi1rvGLfw0NSvMLhHDyQmZvHy+yexK215XxiSXMkPLeUuhlJK6cuqPuTDpChfLhBFdt9ZsNyfqttD1OxGGZXkuV1D5zfmL2pi03WuHNmxBL2583bgNCpfZNHpk/9XXBM6FRUGocw8DBdwJDa/MNFqVt9eFkW/TztQR1eVOJBy4J2GW6uMiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d030QJs/paEOjeVj5QqAFgq32VGncikkRdJnJ397mPs=; b=lC6MCsWW9X/nwBvOEzp+OJlKdZXimxN+4QHhhxBrSuhiE1mIxEJaeQge/3CTwN7GdyHfPmUA4GfRcVD4DObOMQu/H+6bzqzH/LDuCD0ienUeYSlozuhFzsT0fBMotvVuBJGbjFEdjStwxKUvjSjnwL26+YDWqRwxBpRKuSU3nNGHA7FuALkyfo4TR9sA+u7at6lONRxzY4NCEnvdPdsbLdPLmcAyPcLxlMN8UycGvaO/IAgcGygfjEVf9qG3VtbL93UF98bE/7bypEJilMc5EIhwoQMGOzaI+IB8XAM7GsLVlKekxvLj6NtgmCT3+FkNXdebZgGDuuwIyLCp8w8AZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d030QJs/paEOjeVj5QqAFgq32VGncikkRdJnJ397mPs=; b=ahL268a+0LIb+LapZdFyAwAQ7aNsCllupxYF++7tg54qIdprg+59iyvXPV0d8zoYEFbExqWm7CNhsb1mB0L+FBsocXloKzKB/Hp73M4SFVY2MiTU0FKfkqljhLJcbntZ8hU0q1un5l+mTnUGscdUWrRu4rVAdsS18N2ExqJ3Bm/etJmIlHVsQ31VMpG5NK1bHgHD6dKnlXy5+acl/Yl/PFxpudCrt5uP8DAwxWmeXaNdPVtJBhV3KWiPRskdOZ2kyzfbHzU37C6F6nEG2hq5CJNOkZXXXF5+kpxf6GeYHZXW2cd5gelGc88UXUmIxGJOKC/ut+iqOiaWAgxSMM3zCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2981ceec-030f-12cb-4b86-b7fc1bc928fd@suse.com> Date: Wed, 15 Feb 2023 10:50:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: HWP and ACPI workarounds Content-Language: en-US To: Jason Andryuk References: Cc: xen-devel From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7171:EE_ X-MS-Office365-Filtering-Correlation-Id: 2da5490b-0fcb-45ee-ffc5-08db0f3a153f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NO4UbZ3VM7WXLRMmgaDFDb+LES5ewCpHQw13xCtOHFrUg3N8FTgh2mOLTFeNJnBMNRV4pMkTyid9OFT0VTuwwqgcUGK8iEeNLE1tkmbnYhFH6saOsegNeDKARMte3xndJGs9ncb8+mvNW6YT6oGWc7Vu+wKmERExaJ5GsWDwVHlktdOrcb5OFHKnZok6+9d4TBgkl+13t+z4TtoZh1SflHf+1PP/W8IDiRy/lgRS8WXrM7Csj8G/fh6MDas6A/zFnidNWvBtyaq25QKbvrV7IN4luZDJmitliBvsjk+eEq6iueOOW9BXrEc1ENY4i1h23HF8z07dFNTwLUza+6kmlP6MvRv0YB/Fd53B5yqakDH6kCDc0FHb0g5miWCbFIw3ZfGgFWstHnfawLVKEeaTKOmY8S0oHqA4q/2yyfGaiZmduu58REjpGIUzmboay+XC8vxQ64Jr/lfrVUMuQ9Lfj/dg3iJigbe9g0cxvVOaIFLR0PFU6Ayf5L+yjxScAW8jKZTD3G18LXMVc5uQsN7JJ3Uzh93KtmhNcxAM48Nn4DwSUu745mb7pyTJ9SyFSe7Rnv0pxhCTbUyRKhqxD2JdIcc8OSKBFtgtDAtO02h/2RoOoB+JJSqLRtZfseVDn07Xc48rN3PHQbFHmb8pIa+6mpeM73jPatdM5G12AquDNUAyXHxM7d71d3xeTJmZW3OAL0M9uuPiFF5p7793U2Ja/Gvl7cOBJrVVlK0r53KtGjM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199018)(31686004)(83380400001)(6512007)(36756003)(2906002)(186003)(26005)(6506007)(478600001)(53546011)(31696002)(8936002)(6666004)(5660300002)(966005)(86362001)(41300700001)(6486002)(38100700002)(66946007)(2616005)(66476007)(66556008)(4326008)(6916009)(316002)(8676002)(3480700007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MThRNXpwczVwSWRBY2FrUWFlSHJ2ZmtPRUNWbnMwN2IvZDdDcllnaTc5cUFx?= =?utf-8?B?ZnE1T0RaVnowd2ZwSFRKWDhETHRYbys3aHdYcjNmRjY3VDFUTjJpd2R0anhW?= =?utf-8?B?K1duZ3lMUHl0cTZPOU9waUZrL0xsczRlUGUxMmY1S1Rsd3VHUGJvZ3R2dFMw?= =?utf-8?B?QXFuWXBVamRHVVphMzFkbDcwSkJmTkZUNC9WSDZ3NWF6WWdBT0NJQ2VYcENa?= =?utf-8?B?ZENaRlQrZFNsaEpZSnFZSDMwZVRPSFpmdk1EK3RPeWp2bXgyZzdONG9lL3c3?= =?utf-8?B?Tkx5K2Jhc05sMWVEOE03bERjbWtYYzlqRWorUGJpajRZSkpxTVJBY2lPUTNv?= =?utf-8?B?cWxORW45L3pUbW9iMFJKZ0FYZGk3emk3b01HeWwvYyt0clg3UTYyWGp2ZDda?= =?utf-8?B?WlYwcXgvc291YlJOalFRL1A0NFFkUmJnSG5vUnB3QmV3SHNlK0R5c002SEpZ?= =?utf-8?B?d2paQlRGbDVPU0FXQWJSRjlnL2VwbUhWYVRYNHJwRUcyMGZqTTIzcDB4QUxU?= =?utf-8?B?R3lwM3RMTU53SFB4L1Y2bnp6enRMRFd6UDdPb3dqWjR6RXBJK0JOc01xNG5T?= =?utf-8?B?MXVESlk3VGE1MVJHTHFjNHcwQTd6S3dKcU44ZHV1d0o1U0FKZ3JxdXI2QXJP?= =?utf-8?B?N0IvMjdZTHNyTUFmRlZETldNQk4yVWc4cDRSMFc2M0lZK280QlhaSXhCcXFS?= =?utf-8?B?YW5zd25LVk4rblJITG1ERDFUeitlR2NNYk9DOFVXOVEvbFZQTEhUc3JORmdp?= =?utf-8?B?TXpRL2hLWGhUdkhNT0gyY0l0WkpNZkg4dWJKZjJSbGtaUjVoVkNFOHdwWmk4?= =?utf-8?B?emJFcVRoNmhBYll4MjZYLzdURDZEZ0thaEJoV25PZUlEQU0yZkpFUWtjVXBI?= =?utf-8?B?b01iRldhTnRoVW5PTWIzQnBXMzhJZHpTR0I2OUdOcXdiSHNCVE83c1hoTmdS?= =?utf-8?B?TmJ1eDRZQ0NrdVlSK01QQ0ZqQ2dCYUluVDNmVE1ON0VseU1XVmRTenpxU3Nr?= =?utf-8?B?cnZmVnEzOS9BSmF4Sys0THNTMUJUQjFxSTRDL0Q1R0s1WWltRUwzQmsrc2Uw?= =?utf-8?B?WUxQTWM2cjRDYnAxZS9CdWtjaHMvQXlXdlB1cURNSTFxczlZSVhUNmFadERY?= =?utf-8?B?cDY3OU4yY25CM1hmbkFZM1NHWHUvL2ZOaTk1bEpBdi9SU08vWmdIN3JZZGpH?= =?utf-8?B?bDVnSUhsVnBDdHN1d2tSdHNTRVZvMHBCSi94RmlJZWtkTmExMGxQYWhuSVRL?= =?utf-8?B?dGVrV3ZPOU1pcjlhNmtkT08zMUI3c0d0N0YzczJNREo4U29ERkpjR25KN1RM?= =?utf-8?B?RnBHdlhkMDZUb1JyMnFlTldlM0J3S201UjN0M3h6eFVidENIMytEQlhnazlO?= =?utf-8?B?TSt3ZkZFNXNwMlR2Y21Deis2Ny9ZRElrVHkwKzluZS83YnBBdDlhT1BaMm1I?= =?utf-8?B?V0NMQVhkbTJuQTFsekMvN3VMQUpWdjNiekpWdHQ1MThITXN0ckNMbE8yNys3?= =?utf-8?B?VC9raFdkMWxVUlhGOHUxVFRMcnQvVDhDM0MvQ2J1eUpnM0Vqek9xWTF4SnU4?= =?utf-8?B?cTR6QVZCcVk4dWRaZ1prRWp1VU9ZZ3E4Q3hXaDZtUUU5a2YzYmJ4MC8zWjhH?= =?utf-8?B?dy9tQWJHcEx6UUVlQTRLRDFOM0hvYlNKYk42KzZ6cmtIdERhWnNJZ3pFaWpv?= =?utf-8?B?UkE0ZEplR0ovamlqcm5SNWdzaWtjQ0JYdjNXR3ZwZW1tL1VBWUNYc0pKUW54?= =?utf-8?B?clpPanhlU0xLQ2c4aUhkeHA2WDlCT3dOQzBWakJHQ1BlZ0xTTkh2N3FQTFQr?= =?utf-8?B?MTAvcmQ4eWV4T1Y1bXIrQlhMMGxGSGgyKzZZRStXZG5wSzRZa2w4bUcyNFlx?= =?utf-8?B?bnVONUJkMGs4bDNBMjFlT3dieEVaRGdkYkpjWDFJeGRVRXVxdzY1SGRvUERI?= =?utf-8?B?Q2k2UUMweTk4cXZIblI1a2Z3ajVLMnJTUU9tSnNheUk1cit6UXdGY3hMRG9n?= =?utf-8?B?Q0dmN1lJOTlWbzBpdFFVK0dRL3RTaVNlUnA1YXdJL2taWEJTU1ZWbTMvT3NE?= =?utf-8?B?VFdoTW4xYktXdGtUakJWSVJVV1RCUkxHWjJUcXVwUkpGTFdoN3pyWVRxUmZ5?= =?utf-8?Q?RZRsQZRCREpKozEe/qn7fVnCw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2da5490b-0fcb-45ee-ffc5-08db0f3a153f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 09:50:34.9748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jVCkw9xLjBn2MRwDKRJJlZPEw5RBvwSxMEy3CkFPY08DnunQdicJ1bGi7XTeqWY7TRDC8tRlHx+v4Fk/KCt8Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7171 On 14.02.2023 20:04, Jason Andryuk wrote: > Qubes recently incorporated my HWP patches, but there was a report of > a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking > up during boot when HWP is enabled. A user found a kernel bug that > seems to be the same issue: > https://bugzilla.kernel.org/show_bug.cgi?id=110941. > > That bug was fixed by Linux commit a21211672c9a ("ACPI / processor: > Request native thermal interrupt handling via _OSC"). The commit > message has a good summary of the issue and is included at the end of > this message. The tl;dr is SMM crashes when it receives thermal > interrupts, so Linux calls the ACPI _OSC method to take over interrupt > handling. > > Today, Linux calls the _OSC method when boot_cpu_has(X86_FEATURE_HWP), > but that is not exposed to the PV Dom0. As a test, the Qubes user was > able to boot with the check expanded to `boot_cpu_has(X86_FEATURE_HWP) > || xen_initial_domain()`. > > We need some way for Xen to indicate the presence and/or use of HWP to > Dom0, and Dom0 needs to use that to call _OSC. > > My first idea is that Dom0 could query Xen's cpufreq driver. However, > Xen exposes the cpufreq driver through the unstable sysctl ops, and > using an unstable hypercall seems wrong for the kernel. > > Can we add something to an existing hypercall - maybe platform_op? Or > do we need a new stable hypercall? > > Linux will perform the _OSC calls unilaterally upon seeing FEATURE_HWP > and independent of actually using HWP via the intel_pstate driver. > However, not using HWP may be an untested configuration in practice. > The intel_pstate.c driver will not use HWP when FEATURE_HWP_EPP is not > found. So we could potentially cheat and expose only HWP to Dom0. > That should trigger the _OSC calls without letting Dom0 think it can > use HWP. This is rather fragile though, so a more explicity method > seems better. I agree with the "fragile" aspect, but I'd also like to point out that no matter what features we expose in CPUID the driver should never try to take control when running under Xen (or perhaps more generally when running virtualized). > Roger's ACPI Processor patches that add xen_sanitize_pdc calls could > be leveraged. On the Xen side, arch_acpi_set_pdc_bits() could be > extended to set bit 12, which would then be passed to the evaluate > _PDC call. _PDC is the older interface superseded by _OSC, but they > can be wrappers around the same implementation. But if linux is just > using _OSC, it seems more compatible to follow that implementation. Using the _PDC bit would look quite reasonable to me. Yet what's unclear to me is whether by the last sentence you actually mean to indicate that you're not in favor of doing so (in which case more work in Xen would likely be needed to actually support enough of _OSC). What you don't touch at all is how you mean to surface the LVT based interrupt to Dom0; the cited commit messages looks to describe uses beyond the HWP driver, and it uses that as part of the justification to override the firmware choice. The LAPIC is hidden (PV) or properly disconnected from the physical one (PVH), plus Xen's MCE code (however broken it may be) makes use of it. Or is the plan to ignore all of that (at least for now) and limit things to the HWP driver's needs? Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 09:55:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 09:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495816.766238 (Exim 4.92) (envelope-from ) id 1pSEVS-0007HF-Qu; Wed, 15 Feb 2023 09:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495816.766238; Wed, 15 Feb 2023 09:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEVS-0007H8-NU; Wed, 15 Feb 2023 09:55:18 +0000 Received: by outflank-mailman (input) for mailman id 495816; Wed, 15 Feb 2023 09:55:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEVR-0007Gs-1C for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 09:55:17 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0603.outbound.protection.outlook.com [2a01:111:f400:fe0e::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8ae91dd-ad16-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 10:55:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7518.eurprd04.prod.outlook.com (2603:10a6:102:e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 09:55:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 09:55:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8ae91dd-ad16-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtXJ2mPCRzWj6bWU8xcsLrg1valq+mUr/uZCO47D6jSFXSVjOK06YD0mQv/Jo5egx+UtSJlbSKVg2fraV2l0f2oxGdVqWJuSiyRIUk38lqAmsuCLEtd84OCJnbaB8bDv+cLmGyLj1E/BllpPwWKS02L6lkoSDcd+1a5VfiiJM6X0igi4lemx96zaGDMuyEcWJsjkFyDJ94VQOUZ9S9do4IvDyuLAwump9YEDB+50nwFYlbEfhQqyx/pqcjTsMESOE0BmtKOh/Wh08hQ5LwcZ80HJieHj9ylC0r6wjgx+ICS44HC9nmFP6c193bz6tW6jAicr9Sd7V1u16xaTXuOjMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91Bht+PFAiL3+dnjnzHNZY9YouHjXxh9o1B48Sjr7tE=; b=Dw+baUHFfw0lzbNOb8qTwvXJURkQspxICj2KxmqdORq9oiwZF6PRN9RA0z3nXmJudwYKgeufLffemlCbgcYiOheqmfGLB21R5ABpbTDSewu5XFkVziLIdK6JBv5XBEDNs4Wmr+zW5t5Zx7jGWg6pQC+DEUIhqoul6mgbdYT6fH2cZ4xrBbROOPv9knCPDg22+FDng5Rpq2gOcSGVydestwUw0Xd4Rb9wobpbM+E7H9JH2jsD3KSLo7NEq1xuulVseYkv0emt9RLZY/Adq01Pl98QdF/IThhn621mhsaF/unq/J3vHG2VLfRjoIMbOnH4jokTsGmz60DVXEgLoLt94g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=91Bht+PFAiL3+dnjnzHNZY9YouHjXxh9o1B48Sjr7tE=; b=lpOc6HbiI5bIuy3Etq5eXXAG4//5as06QsSXsZkCl8lHc1OigFxYDo0SPCFX6kPGfec8dUJp47yEhTrRJW9YhoJ0VFqkkxZDMcp78Ly5u+8OPI7yA1tAPAQNlQIhpQTnbdwsuv3sCi6R7ggoyPO0/JXBd/EJVv0UkBcgiRTRUPdKEZiQy/jvwRmycKK8sWhxC+KOyo7PBe0NptmIHBeN5xR9F6dLtAirfsLek9+aUgt7wFlSEg+RmgK41k2LjopmEADt63+XO7xPDiRMGMhX8m8pMf5mzLDZ5jAFBE8PqEzvhMi3L9oJjOek7SW/Lp0dDaeQKt1Eo3Q6JmKjbietvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <220e39a2-9fc8-251e-9b9a-997469ab201b@suse.com> Date: Wed, 15 Feb 2023 10:55:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] build: Make FILE symbol paths consistent Content-Language: en-US To: Ross Lagerwall Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230213165539.3257260-1-ross.lagerwall@citrix.com> From: Jan Beulich In-Reply-To: <20230213165539.3257260-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7518:EE_ X-MS-Office365-Filtering-Correlation-Id: 5846f36e-b90c-42aa-ac35-08db0f3abba5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: usC1E6rDLcWzpfNsjW3vptHQUpVoNWWhGvANW985CPn2CPKYDQKgfJAYJgKHasCS+HpBHtIDXUK/iZ4FYww9CbRAY79nmxgxsyp4DYRw4zNi+wULA0p3Gv3C6Wokq4Q+SEp3lsDf58RFH+JQk0Ikl3huXpyJJxLsLUfIRwSgSDYfO2dU/ur3TK3M2kUA4tQXObkqWTFzA6+yLFyFrcDmwll9tGWJlIl1bHYT0SB3AvGDipVDnmOPVQCfCUBQDpq+XL9AwuIBpgysHrthcXQry7aAXlepUfHrhU1XK3zMTt3OLhHMjkdlftQvcGTfOiyPJzK9Y9SnrinReFRQnmt/g0aoWVVCTJ/CQHXg4y8/+L5LlL0CPcADOAnsFPTXcB0Qf42gK2KeXN+M+M/r4DboBNX+FRCu8VBbhg4vDt+zW0NtrB6m3gj74UVjBU0TiMi7BPWr8fgIevf/s4r/IbyB7Dlu1hdo8hH5eqcONC2yijx1m+vzVUqcar17eW2ILylVHTe17sI/4oc0WOx+jvIDCp9qyUVGJ0iN6bBQVfp4vyV8rGk7bLaYb6F59c2eh6KJ/LkHf8hoOh6nQNLheFmLARsVQIMfSy6uSNNKW71jaYsQSKDqm1HAQEF7wRwqaEAEjMCh5Kq9ysiMoO0u1saD4Wa/q/lMcXhTU+btFKwQyMPbYdvriPixb3nKalea3NqyGS8xwM0sbzp6Bkb202dGvmBhu/TmO4QAz0oTQ6sy5sw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(39860400002)(366004)(396003)(136003)(451199018)(478600001)(66946007)(38100700002)(66476007)(5660300002)(4326008)(2616005)(6486002)(36756003)(41300700001)(6916009)(66556008)(8936002)(8676002)(2906002)(54906003)(31696002)(316002)(26005)(186003)(31686004)(86362001)(6512007)(53546011)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE9PVXJzenJIUFdtSzUzQUFZVUJsOGFxN3BGMDVBWjVDQmw2Y3V1Vm9ZMktX?= =?utf-8?B?VDdPdjBCUE5mZGhHeTdBN2l0RHV3eEdUL3pmdmdsY1JsTG1EYk1Xc0lvTHph?= =?utf-8?B?UzFVUUFseWttU1grM1ZzNjdhOFYvcjhxTndUaDU1Mmp2UEdBbU1NaHJHNFhp?= =?utf-8?B?QmxOZ3Z5SHlzUUxDeGtBcFltQmVUa2VKSkp0RFdGRWw1SzlmR3FhdSsxVlJG?= =?utf-8?B?eUhMb3lvQy9hRlB4dVBkTEJpVFB3RzZWdnR2b09IdVVkdW5MOHlkRitiaUVm?= =?utf-8?B?VUJSUlRReVZxZWFwVW5OY1dQdnF2Ymt5dlY4elB0RTQxWnBlajNvYkZtZUV5?= =?utf-8?B?VWpLQTFmYXpPdXY5Z0ZGY29iWHpYemFCVXRoUjNNUVdQTDhONmNzQUZWVzRr?= =?utf-8?B?OXo5aTVKYXhlTUlyY1ZwcEo3L3B2OXVKc2taOTN3SkljUFlHcEM4Y2JJanM4?= =?utf-8?B?U3FPcXNOcGtFejNqbERuRENncW1zMkF1L3pKdmoxTDE1U0draXVKays4aGdZ?= =?utf-8?B?anhWbjNVTEtTK20yelYwYjJCVnZRQ0pzYXVMRlM3Yk0zL3FhMGpOektkRlBI?= =?utf-8?B?NTJHd3hBYnUzdkhycTVldGhNemRCWFlvUVZvU0xmc0Z5d2h6U0VYZEVzR2hH?= =?utf-8?B?TUdCTm9VNWpxNkpkUDhtNU5QdG50QlBseXBqNWtMRUlPa1dkaFJ0cnp3WUZl?= =?utf-8?B?bHVJa0R6TUV5QnJRZGJKQ0owbVdPUUg3US9peFN4Smh1Q0g3VU1xZlFKYml1?= =?utf-8?B?ZW9xV2d5U01Tdk1xUUFjdkVZbXZ5YVVuMEZFckFkMVZsaDQxQ0o3bERPTmdI?= =?utf-8?B?VFdOSFQ0RkhyTEdyY1Z5d3I4TWJzallZU2x4WFN6azl0TXpPUnArOXNZYXd5?= =?utf-8?B?NDdZQ0MrZkpJZCtZQ21HNnVKSHhTYlRQdURSMGZmbGtGNUFkNjd6K2dzTUtk?= =?utf-8?B?YS9ndmlEWU1VNHJoZU9leFNzS2w5YUw3NXNmS1dtSVdaSkg5UFVrOHY3T3gy?= =?utf-8?B?SUllZENHZzZxcXJrK1k1T1RydHZNMTJzQi9Sd1ZSQjJaZlpwSmZUcXdjNTFj?= =?utf-8?B?UnhPVG1vRHFxenhiSFVOanExNUV4dmdsMWZyMWp6Q29oQ0NaWTNCZ1NPS0Y1?= =?utf-8?B?ZWp0bkZoQVNyOUNoVXZvQUorYTdFaXo5OWNHWFczbDlFYTVocFo0ZHBJbVJu?= =?utf-8?B?Z0NkYTlsWXl0V041Q3ZPQlo4RTNzcVF0WkVxQ1dKL0ZDNDdXUkx5OUFjTERt?= =?utf-8?B?clFSS0VCNjBLWFpOa044TDBTVUwxRHNCYnhIcWVNWGJmaC9BczdtbW1kKzZ1?= =?utf-8?B?TWIrT1pNZG5GYjhSYWhmcnhTaXVPd3JCYTFmSEtYOE1rY0N6Q0hrbUxkQzlD?= =?utf-8?B?dGNZT0xpbVBsZjVSMFB0N0NpL3B3T2tEajNVRHpoa2dPbms4OUpNaU85YWxV?= =?utf-8?B?a1YvWGh4aHZYdVpUMktKamRiWWg1ejdqN1I0NnJ4b1R5NUlBWlh4VnR4ZEZw?= =?utf-8?B?NlZvaTZ2eE1ya2tZZzAwQjRsTi9pNDVjdkhYYkhPMXlUanpCV1p6WWJZK2Zq?= =?utf-8?B?SWU3NTM2M1RqcDQvaS9tMzNaUmxwOFR2K1dCd3ZmdGh2a2Qxb0xoOUpzNEJW?= =?utf-8?B?NjYxK0h4SDFqa2htYis0OVREQjAraXFtOEpzQ1VKTElBYm8xMmdibXFSU3NM?= =?utf-8?B?RmlqVlRWZnA5bzY5RyttYWN5ME04SHJuZWkvcTVkMHdHYjZ6NkZLbGJsNTZv?= =?utf-8?B?Wi90bFlJTTlyN3U4R3pZMUl6a3RZb09LOU4vWDNqZ2Q1QUZoYm9CL3A2eUQ0?= =?utf-8?B?d0NlQWV1NVBYb3NtSjJ5VEhWUEQwbWcvR0VQTitSQkM0dmJyYmRQZmh6WWpW?= =?utf-8?B?dzdwZnZCdDRmQjExR245cG55Ums0TzZrV2xoYStVcVhmM0tDRUxiK1RDendz?= =?utf-8?B?cXdtN0xha3ZpWTZtWWNEVi9VODI5MmRuQ1N2Uno4dUMyREozYzZnYzFKVmF6?= =?utf-8?B?RXk5L2lBU0xUN1ltbE9JZk5xOS9JMjQ2aThNVjZvOTZ1ejJ6NER3OXEyM1lQ?= =?utf-8?B?blBpK1UwcldCaStNOXRYcUFaQlQ5K2VHS0UwMmJBTDd1RHRPbVFrRExyN2x5?= =?utf-8?Q?8EF3cmcxcIP9hxnNLfwBaCjqV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5846f36e-b90c-42aa-ac35-08db0f3abba5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 09:55:13.5648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m2EdsgqVTbuvyo9aHAwKOv1av6FCyzmqDWDIQXERKs1mae4fvW55mqWecYJKRdJCxosGjm6lQM8zadUd21JdTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7518 On 13.02.2023 17:55, Ross Lagerwall wrote: > The FILE symbols in out-of-tree builds may be either a relative path to > the object dir or an absolute path depending on how the build is > invoked. Fix the paths for C files so that they are consistent with > in-tree builds - the path is relative to the "xen" directory (e.g. > common/irq.c). > > This fixes livepatch builds when the original Xen build was out-of-tree > since livepatch-build always does in-tree builds. Note that this doesn't > fix the behaviour for Clang < 6 which always embeds full paths. Is "fix" here actually correct? I.e. is there anything to fix in that case? It looks to me as if "always absolute paths" is as good as "always relative paths". In which case s/fix/alter/? > Fixes: 7115fa562fe7 ("build: adding out-of-tree support to the xen build") > Signed-off-by: Ross Lagerwall With the above clarified (a possible adjustment could be done while committing): Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 10:15:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 10:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495825.766249 (Exim 4.92) (envelope-from ) id 1pSEot-0001qG-Ee; Wed, 15 Feb 2023 10:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495825.766249; Wed, 15 Feb 2023 10:15:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEot-0001q9-Bu; Wed, 15 Feb 2023 10:15:23 +0000 Received: by outflank-mailman (input) for mailman id 495825; Wed, 15 Feb 2023 10:15:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSEos-0001pk-6k for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 10:15:22 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a4fcb1fd-ad19-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 11:15:18 +0100 (CET) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 05:15:12 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by MW5PR03MB6958.namprd03.prod.outlook.com (2603:10b6:303:1a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 10:15:10 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::acc3:67c:60ef:bf99%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 10:15:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4fcb1fd-ad19-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676456118; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FXTIAPOtl/XbORweWodUC/OPkWFve7kb1hadOq/CKq0=; b=O5m/EdZZvkJxXuenK7tl3QTjIotdZC6BPxwT9z/T4NCdfnvtqBztFdst I2uXzlFlFa3wNCCHs/2mswiSdx6jP22vRpMOnG4r7fSA3UftBmFfRS5rr qHfn3iEGOFJLc7G2gKbtI0zPuI9CInAidUlSgCSEYqeIxYqMf23fpk5Ut k=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 99538520 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uGgvP6CosHJRkxVW/+Liw5YqxClBgxIJ4kV8jS/XYbTApDIq1zUCx 2ZMW2zTMv+CYDf0fIgnPduz8RkH7cTVmINmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3ut7X1hx8 tYiJjFSVhev3eHswrCmVbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xruAA/zyQouFTpGMDSYcfMQcxak1yHr 2bC12/4HgsbJJqUzj/tHneE176SxnOmAtp6+LuQxu5V0EOznTUqOAAMRUr4k/q6jAngVIcKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS6hyJy6fSyxaUAC4DVDEpQMc9qMY8SDgu1 1mIt9DkHzpitPuSU3313qiQhSO/P24SN2BqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh TeQo0ADa647iMcK0+C+4grBijf1/JzRFFZpvUPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytaVUwXXYH80EdygmQ IronPort-HdrOrdr: A9a23:Ohibx666YQzrUnCiUQPXwMvXdLJyesId70hD6qkXc20wTiX4rb HKoBx4vSWftN91YhwdcL+7Sc69qB/nmqKdgrNhX4tKPjOHhILAFugLhrcKpQePJ8SUzJ8/6U 4PSclDIey1KWJa5PyX3DWF X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99538520" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T28iidTZYGtxgLxafa6hNg/IPvkbsmH6Kh5Ba0KZKM/1Kq2C8YLFgt4mgNRvPU446uveZ7XoCS5rWwfdqEfCdpnhna7kVUTSIQa0+ofzx1KzhHgMlNqObYsNyXXwHIfYw88twEqamrHYUwCYAj1JM4EbVGhn7CbdFGp5lb2Bdj4UC4Om1YGH2jhjkROxhU7zSQQPzjyyMMfiQ8KPxIXIZD788yni4gjPNc0rhko73z7EUXtqf3b4sOJ0sPjvHXwHI4OZVqMGJzgwG4Kxx6f28EBZytr8pwYKOCekiQv5jZ7svc6wTemC8StTKMNPRB0BE9V2mYRDu5QTpdBPJtw5NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FXTIAPOtl/XbORweWodUC/OPkWFve7kb1hadOq/CKq0=; b=M6GXZNLQYnznM344PYVf5NzKaphl1v3apSy8yD4HbSpXUcVAwBlQN17yyqtNmv080x/WrJ5H/IdKBD0ay5LDREHBG0dNO0dnpZjVRjb1KEkFqk1bLpJzcUhm1THsbAUIj0Ugk75AtslpkGB5dDPHmIYxFiAnKcngTx5atNWHIdC3hsOoUMUe6s3atPqgYtMDFc5x4sIYNHc7Uy2R0EXSkaE/OWP0e1mYKJydahEuoKVXNw4eTJED6royG5FzpD5x0/7dy6Zrovk46dw3PpLvdTg9+1qSEzlc38JoUauY/wq3o6epizIc9evFlVPV0JIdjvZVqJ9S+gg4vTpDRO8epA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FXTIAPOtl/XbORweWodUC/OPkWFve7kb1hadOq/CKq0=; b=CCDh6SiCzForREv7dETXpF3UFP526uNo8B4Q5OhMngb+CFzvJm/bv0kZx8EjQwWlbeq9HXfvQdQvVjq3slr6CR1eQYBm5aKqtgY875T259IsFtXGt5TCXh/smhkFOWwhoLe/zpvHA7s30ik3kiGyHh44V/HlOVnxjadUBAdkHr8= From: Ross Lagerwall To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] build: Make FILE symbol paths consistent Thread-Topic: [PATCH v2] build: Make FILE symbol paths consistent Thread-Index: AQHZP8wQAlEMPw7YZkelXrHFvRoSWK7Px5eAgAADTY8= Date: Wed, 15 Feb 2023 10:15:10 +0000 Message-ID: References: <20230213165539.3257260-1-ross.lagerwall@citrix.com> <220e39a2-9fc8-251e-9b9a-997469ab201b@suse.com> In-Reply-To: <220e39a2-9fc8-251e-9b9a-997469ab201b@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|MW5PR03MB6958:EE_ x-ms-office365-filtering-correlation-id: 76f24660-750f-4f94-6ad5-08db0f3d8515 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hHL3la2yaEWco40MSF6iOF8oOLFgq8Ryalkx47PqmKmSBzDChkuet63gosGya+bUB4nn1F7JmJS6u4+mjUX77/Jt/CxucAIi430jOmR9A4osS/fLlrQfRsFh7NQ9KgNO9jH1gDCn+/MZXXO9nTGdp1GrZ6YbZNWCH9N0+c2SoWPP3bPVvaXcDX+GZQPwyB2NYnbXSLK4qPHD1DytSfCOdfbvvxl/rw/gQ+qW4sM2C6cHwcHlH4372sEWocgP4gyTHWK4yoad5K8upfJWusmlTWc+KCre6JjhdbgGmE6Cj5NJlpU5WAZH7eZnMA/TrK5xAVmpuwMSIKrnOaleBMTguT8k3MLIWl7Bp61vQ5xG9G+6ns00h6kGB9hXK3Hww1ypzuwLno98GjY0sSh+uekrEsa39U/URcZXyZPn/W69l7aFCucES3QXN7bqVcyOg2gRG3peSG+Cs0up3vrJLNP5BkOUTbSi8ccGwtCBmtspGaeGdGkF6MQj2zMIBlZ8ykuMmoHKOufmW7jxl18GPkV09DBwFg0wXUWTpkgbzOgEzrfe6PBSlZxC9aO6grYGYVwVjmfJZxiHIiO3KlR7h6lJenFGRNmi8EP/+NTpVvSfYKnnHwJzcSD6PIVYNlhCqF+ihZX463cvZFVFphZ4UOxs71KsNNpa57yG58ukvHZlP0v+aaPjqviThpXPpxvjOQkIRHvTyVYxOJUgZxGgWTFioQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199018)(8936002)(52536014)(44832011)(41300700001)(5660300002)(2906002)(4326008)(478600001)(7696005)(66556008)(8676002)(6916009)(91956017)(64756008)(66446008)(66476007)(66946007)(316002)(76116006)(54906003)(82960400001)(122000001)(38100700002)(38070700005)(55016003)(53546011)(71200400001)(9686003)(33656002)(6506007)(186003)(26005)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?mJFwzOnDwQnfKJPCk2e5DmCSAu52iSHvwAxfeu7yUnFEidBP6jOX16eOXP?= =?iso-8859-1?Q?uMs6lSLEbHfa2FXqnS+fVVvGnTYy50oxIvitB6Mw/jT9FFArmZMSJnqclX?= =?iso-8859-1?Q?xCmAQ/rktYs6dtiKpB9osTwmD4gmNSRvBGyZj9hB3WwBwnrCIPjJIqBfRc?= =?iso-8859-1?Q?4XRMfN4I6Ao//vOjF2yrZACrPKi1+BG3XlXxBtpaa+tYRopgvGysOz/3y8?= =?iso-8859-1?Q?zpEWVARi17mMzAzTH0hPi8AP+Lfq7o0kz2ryWzu2dphXlKtmPotcfLe16x?= =?iso-8859-1?Q?YJd6/lKrVc1pqQThZC6upJdUjaPbzeNP+bCx1rkZyXcvBEBr7PpVvgXb0A?= =?iso-8859-1?Q?rtqFB0tiLGCHoCDOMAteQxzMxROB1AnZoZ8hIkKsgroeuJJppttqIl2DBO?= =?iso-8859-1?Q?LDljBvl9PMErQacsZqWlxjRjZd3tL/Rj2ZK3rT6464Zu8WkWOU2uORo+ji?= =?iso-8859-1?Q?+kvFpuPCzU2iNJuvWfyd/Hlt88Uj6ELYUJ5SZaPh4nepafrlHvZqjuBzAs?= =?iso-8859-1?Q?DdeB46CdB+WyYmeaBnwRXrT+cY/LhuGztk2NqP76UsCxD2REc7VNcRsM9J?= =?iso-8859-1?Q?Dg9oRRbHlcolxnWcuv0HLF6JX5V7IsuF3366pYUgz/xflzBR0nLX8HSd26?= =?iso-8859-1?Q?0LqnSDayHXyi9X7QyYkxMMFiVqtVGTTMSwMBnxPyvKr4Pk6OWxhxky4bdo?= =?iso-8859-1?Q?3VF4lgYNtyuvxVX/dmwS4xbo8S0kxyurupS1zm8Qff3RcYSFayie2zC7xt?= =?iso-8859-1?Q?r6uwMgU3lmAdaEvx0sLpVRUb5SUHksimB+btqBpXnsn+nhf7C/2jjThLj4?= =?iso-8859-1?Q?WQmRzektoAWvhQq5gphJzPsTT8nuqiq8sa1QAyqF8jNUT/ysihDefjtcr5?= =?iso-8859-1?Q?K95hKdgArfkNNyILX8Pu2omM79f25oLaJ+LVJwKYPyv217MOeHkbrF0eCr?= =?iso-8859-1?Q?Hqod1qPu9Zk3Bptvexqr934abUHlHaNDny/4ZuXcKEV1KsuFYosIqC0pqB?= =?iso-8859-1?Q?Rx/rBfyX8OZoujSbDhB02Us9e6UTakeMfiJCokPaRBk/3SzZ7JGlZiotnz?= =?iso-8859-1?Q?oSSCZ/WZbbW4HvKJz3afl/i6mljhFcVHT/ee+Dn5cFbGyIIPCcvcBx79Jc?= =?iso-8859-1?Q?MU1Hjq1kKiqL1hhYkMnqDENd90/h/uUFnyojD+tYrJuWnT7GMm/N2Mx5e3?= =?iso-8859-1?Q?fPAayh/ykPm80bqeT5xLJeCRFtoTVJV/xGgxzSEyzEZpldzZmrRyOVQhTx?= =?iso-8859-1?Q?8Ft4q1+AldxYhtyWUTaVtZs0KlD8gl449EO8kxF4FSNImMwb24QU2msqWa?= =?iso-8859-1?Q?0bG0fJ/R0jwkBrzPSvVHvy5lBb5bjPm02QE2NDs/XzYc/oUg9qydT5UXUv?= =?iso-8859-1?Q?XleUeXf6dqjhjtOXNjBIpICmrHnYtiGXxsbVeTMIUDTeldcj00EMntDYOs?= =?iso-8859-1?Q?GL8UbKKcJkAP5CfmzmPTNsyO6eAb6tvK0eUobSaZ6kEoM1ykOikb9M6Hcq?= =?iso-8859-1?Q?f+xY/0nr1HlNOOw9b5s3G1ns8BE3I0DNdCstB3oRcyrB3TwvlEO6B61dss?= =?iso-8859-1?Q?ooBK1x2AzZgZ0M/0q3Q4yJnlrQ3oFRLAQiaSpGFAcdAVns0qJE8vCXEEn8?= =?iso-8859-1?Q?6KmnDsORigkFtnD+vtEATVnnUoCeqt6KKh?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CZPS+e7XbpEpl2HoKjmKJ8budKBQMDsjteiALa6OHKulBis3mekTn4EfsV9+S1i3V+TNLzmyndNxppT3I3eNaKs7g08dzLnC8Nbsno5kYfJjU6Db48pP+6TlFalPAyoFGxjVH0TYP59AU+W56VUKsEwKvTSG0zmYZs2Tl3QkBr/9fykOhnwuq2m38qhlobfMCNCp/r4/GA6pRhGlx87mZpmIwRLiRNXnftB2spcibFkilettkZRM1fJ7jGZ2NrqEPTAeGIoAeQ2yqiLVsG4BQPEuLPkIWKxi6BXQq6NlWehxi7TdyEa2u9ZAfeRR7bHr6qqrygyLCiXhIGhDOhHP0kaT89PBv4w/mTXAFzUhzhYJo37xlWNQw2kxaQZpAXYs8+FAK6co8T1Jwei9vi9/L8O7uC0RtRuKG7EmqerAcXO1Mit7iK1+mawL7GDzmK0oqWAsFIKoxxVPBtAbo+W1Z7ALDf6X2G3PIL5kdcbCilGW46NeegDP+OaD0VOExWca8+JYvQtipO7a6g9JtK0JHbv5cjXlK3NfCtG7U0m0slyCKy5VCzCfg0jvcpFFFmY5c6ik3vlHv4fFO0dDEHisqKNQoSKUciAGMuIQLxKMN3XdSzx8DjxKlzMlPrIaHo3JKHkakl4NTUvccnXoldJyz6b9cWlms2z2a6x3xdkUXDOp+ihTZgCj5asvEHSCxmxf4Pc0lT2y5z/M3smJxCdA9bXxn/nCbnWwyZA8eg1Ka8TkbE4mFBDNHJmIt4xG7XPXXb/XLa/aKxn11dKbrkMlODFWkDNLKoui+a/WRIukWr0hS1Iui3Hsi37wFqu0QIRQPgPREGFjwBBM/AD2pt3HQ09+qAThkAbPH5dMurT9vWc= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76f24660-750f-4f94-6ad5-08db0f3d8515 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2023 10:15:10.3095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JjwUoL/+jXr1jWwUrKQmXPBt6jSUfLeSCQ9AU8X5X7ss3Nh1779eKHc6r9xhuc69vCZ0dWVUzqJOsPT5SFAbCHDL7xYJ8mbMvWykK7JoXc4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6958 > From: Jan Beulich =0A= > Sent: Wednesday, February 15, 2023 9:55 AM=0A= > To: Ross Lagerwall =0A= > Cc: Andrew Cooper ; George Dunlap ; Julien Grall ; Stefano Stabellini ; Wei Liu ; Anthony Perard ; xen-devel@lists.xenproject.org =0A= > Subject: Re: [PATCH v2] build: Make FILE symbol paths consistent =0A= > =A0=0A= > On 13.02.2023 17:55, Ross Lagerwall wrote:=0A= > > The FILE symbols in out-of-tree builds may be either a relative path to= =0A= > > the object dir or an absolute path depending on how the build is=0A= > > invoked. Fix the paths for C files so that they are consistent with=0A= > > in-tree builds - the path is relative to the "xen" directory (e.g.=0A= > > common/irq.c).=0A= > > =0A= > > This fixes livepatch builds when the original Xen build was out-of-tree= =0A= > > since livepatch-build always does in-tree builds. Note that this doesn'= t=0A= > > fix the behaviour for Clang < 6 which always embeds full paths.=0A= > =0A= > Is "fix" here actually correct? I.e. is there anything to fix in that=0A= > case? It looks to me as if "always absolute paths" is as good as=0A= > "always relative paths". In which case s/fix/alter/?=0A= > =0A= =0A= If embedding absolute paths, the livepatch-build process will fail to=0A= match symbols between the base xen-syms and the newly built, patched=0A= objects unless they are built with the source directory at the exact=0A= same path. So yes, I would consider this as not "fixed" for Clang < 6.=0A= =0A= Thanks,=0A= Ross= From xen-devel-bounces@lists.xenproject.org Wed Feb 15 10:27:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 10:27:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495835.766261 (Exim 4.92) (envelope-from ) id 1pSF0Z-0003ey-M3; Wed, 15 Feb 2023 10:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495835.766261; Wed, 15 Feb 2023 10:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF0Z-0003er-IY; Wed, 15 Feb 2023 10:27:27 +0000 Received: by outflank-mailman (input) for mailman id 495835; Wed, 15 Feb 2023 10:27:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF0Y-0003el-R5 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 10:27:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0c::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56710fa3-ad1b-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 11:27:24 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8237.eurprd04.prod.outlook.com (2603:10a6:102:1cc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 10:27:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 10:27:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56710fa3-ad1b-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8gR5uycbg06iBdVCrWEUcU/YmnU0nlEfOtqzd4yrjXuJvLiNhjlwleRRI51vmNZFOlzCskTsV14lhTUfgBZmpWqxhILjZiHPM8975NiFA0MLhrPaksYazeGovQ5RmmFA+q9kbBqD10oPaNsh6hh4TQNFybdQjV5Rh5XSrazL59+kBgj27V/5q3opcCeR4EDUeBDL5vKJ6T4+/xh8Cd2L2tCXXdfUYbuXprqce/vd22TwBv3ZJ/H/4XnG0ldF9VyS5iIKoRX2eXTxWSnwDuCJ3u42gcKfXUbKcTBFskb8Oy7oqJanSFo3V5NP1gEQkLrBAgDUeQXbep2Rt2QlEPnHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SERSB7BNRhjB/1xGr5c4n0jNpMuSxfs9lzAEyQg8tEk=; b=aSdudF8wNA3nEqH1p6ka9Bgrx1LXh1w4SFKsYPxj6Gj4hvGS8vyvRkA5qy+CduNKLVxnJg1G75cuCvWIoDdpRN26wCpPmpn0ix5o0Fns/gzcqQHSXAn8Z1p1HRLZtJY+qt7VVcG3sUX1hF+GDSEix7fewSTZDf5OFqLmU29lzqIRj9DS7qemLr1EDvoLDVP8wZ90y8+pPtnb9K2WFY5jah+r79dIHP0lVI1DP1liXgg7ePQZCoBmPpSpScGXy6OnjP3qoq5d7/qxnEZ6q1tlU66uwlAdKDifBVhuWeizGmf0sNCdzWkDOpn2OTNnTP/ySg29uSBOWC030Ssp/lHAHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SERSB7BNRhjB/1xGr5c4n0jNpMuSxfs9lzAEyQg8tEk=; b=RzPo014JyGmrnbhNp7AwGkalAB9CnckFfq5lqqukLCtt2hEnSUgxJUSyXrnJT5QVsiUerg8MQsjtqeLAftiA7/17SM6rKkfDhrRWC5aLdKkpkymDK/tqZZpYnfRNY7IWlI1fv6CpPS1r+BtGcO+W/EsIQGiBqvKs6pcmwHi2qw3KrvHf2kSphPV47X69HV6yo/SgNyZ2d0oZ1MskVka/Oq58FshK3QmXOanW4WVJvYHv1/VqnKhI0ZNbgpiM9jNV1qpKtTZWW6hO4mQtyHTMRzdT0olQxWQZ77+oaoRk2Yd/vKzi+WD7TbL258Aakh8Ayp5ldSjhEkRaREU9iSo/KQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 11:27:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> From: Jan Beulich In-Reply-To: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8237:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b146e12-eb69-453a-6e59-08db0f3f3935 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J6ySn4wCocenkMgXbQQqBdB+QvdAAWUbaFM8/QI1HQ/anRSmGJQOyvP/eJ6J7M1mNxG77hrRMyErwTt32qhGmQ8BdV7xcYqTyjzJyIjOd1Fb9LOeauK7Yb59EbeAjtixQVoxUyOPn7S0PJPkKUc+/19u8yhIexZOqrySpLM5HINkGhLpc+0LQY5BYeQOdPFk6S/ckzp4f1ju12o5kL/fm+cezbiqhYv6YxIt4IuL/UHjlPCI2KqroLf9CIa0YrYDOZLTeWxfVSqxQgBXMVnr+a7DDGGSFuc5PIKoSCfbPzINGvoFEvMI8ZRRYDllmtIDuzDWbbfawJGKYw7QbwJSmDplH8ksqT3PTqnuqHm1mk/7DZIFQ34975PW/2Uyg5LSdo6D+97xijzk1KvY3+N9frHqWGnkgsqB+Hr+Egdr+B6+aO8APPg9x/k58+9Hu9FiJllOe5BOAcjPsYIvHhmWBjMG8vbH7Wb84YhDwZXYC1EvjbmAZRdU2c6qX1r31kUbGmqd6vSKETfAaZmh81A+P4yOCOit0NWgRYXdHDZNOAMmTdogdgQX+DptQtP/ZqXybi1b+3HNE5XDmdLGFyQf7kDJdw1IiFTtnD+83ouGnMCd5MRkbI4n90Ny7jTK9zxX+A+5CQn3MmrPAgS5fRWmwjZ3seqnSoG9XpmaupQQtdIpgnRJesxF4kmlxa6+we+7tWawspotJgqW9SImoLNlsjI1RWCwWbmMhWbYdpAtiSo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199018)(31686004)(83380400001)(6512007)(36756003)(2906002)(186003)(26005)(6506007)(478600001)(53546011)(31696002)(8936002)(6666004)(5660300002)(86362001)(41300700001)(6486002)(38100700002)(66946007)(2616005)(66476007)(66556008)(4326008)(54906003)(6916009)(316002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjQ0STJ1WkhXVm5pNUk5dGRwMlM3TmpVczVldHhCdkFmcG4yaUU5RDJSMnor?= =?utf-8?B?RXdkRVNmMUFIamlGOTJZd0FURzl0KzJkcVJxZ3hBSjh4V0lTazNhbVNuSmg4?= =?utf-8?B?aHFKRUw3TG5qdWdIMWc4d3dYWHBzbEZkZE5ua0x3TVoxZFNwbEt1cnNzRFl3?= =?utf-8?B?ZE05YmtSTUdvYy9HL0Y1QTFhUVlaaVZ4dGl4WG01ZzR3QWdrTXRxN09aYjlL?= =?utf-8?B?c2hMQ3pUNStDYkN5V3hpa2FaUG9XWElRVXZIcWdVclhSUFJIeEVhclFaNjRa?= =?utf-8?B?VXlzdm9keldjeEFUMXZzYmZ5b25lajRxLyt5Z1FJZDZCWUprdGZJWmo0Mkhn?= =?utf-8?B?bnUzbnZIY01OTUR3SDZ6LzZZRURGOGN0WmtIUnM3WkI2MzBCRGthajBIL3Qw?= =?utf-8?B?SkdSdGN5YUZzcVJzZVVqUEJJVmdrTEtGRUdMWWprVzlrR3JKRkdHK2pRdHl1?= =?utf-8?B?UklwL2l1akFoYldFQ0dhVjREbTFLYWJLL2ZKWi81b2tGTWRSVGtTSlErRHpO?= =?utf-8?B?TkFpcnZpUjNLODdpRDNFUDVUMzM2SmliTEhtdHlaaEl5YnV3MWUxRm9mYzNu?= =?utf-8?B?N0NCSlp1N0d1cCtGTFgvZm94VDZZRVRGWEZnSjY1OS9kMnNrZEpUNHRFREJn?= =?utf-8?B?cmlUY0FFSGxHanBvelQ1aGpZaHpoSkNaUk5Qd1dvVkcxYW5EcWMzNG5GNkU0?= =?utf-8?B?WE1BOTRMVUUvaldpVFVsSVVRUGovYXRteWVCRzlVK0JGUi8ydTlqZ2xoTFVu?= =?utf-8?B?R1F5aEQ5QXNkQXkyNkRXc2ZRTjhVL2ZkMXkwdzRuVjNkTDI4cFhkVDVvNzQ4?= =?utf-8?B?Y3BtV29kZG5xb1VMeDdNR04rU3AwQVc2c3ZoL1RrWm1HbzIyblB2QXgxdU5M?= =?utf-8?B?RExhdW9VaTVJNEIwOTFMcnRuNGRrRFovcjNnbW44dktOeFpBWFUzVDRXSWw5?= =?utf-8?B?L01Ld2xaOEhVbDBUVGxuZFNqS2hGeXhpam1zcndBV29zcStSa2wwMXZYaWlv?= =?utf-8?B?QjFsNnRZY1I4RHJXaDJYdVdzSG9aK0Q1VzB3TFRlR0xzZkV3Slk0OHBocytP?= =?utf-8?B?T2tKTXczbGNnK1laUWE0LzdxUDVrL1JWWWY5VzdXWHhuRkZ6SmRoWnhwUTF3?= =?utf-8?B?MG5LNlNjWm1hWTBTZUYvTERkaEVmT1R2c0lIWFBham9XTDVPQm9jOEdPNDdz?= =?utf-8?B?bkNOSGk3S0s4RHBCenJYWThZdis4MWcrMFNDS2RPQ3Z2SnVQTG9CVTRMNU9P?= =?utf-8?B?Ky9FYjAzSEhiRTdCa1FhU0llc29XRTVJU0tEMjJDWm1BKyt3QkYwQzIyVktM?= =?utf-8?B?dUIwWHBKTVlndE5jd1c5RG1BSW44aFhrZytFNklTblhnVERQVk44RXRoZWlS?= =?utf-8?B?S0N3RnZmMFg4QmcrYU5VMUphMS9YYWZKSU90dm16UXpQTDEzcHNuMmhmMlk4?= =?utf-8?B?QmN2clhSTE5ZTlgvdUxpbW0wUngzZURoVXk0L0tUMUE0dnEwSndMbFBJR1FS?= =?utf-8?B?NzFNQVkzSzl6UjZiellQUkNHWUdVVHgvZjY2cnBhN0VoUnFmdVp4TDJIeEU1?= =?utf-8?B?cE5NUnhqelkvcDFLSmRIcmtXdFFqNWRONmdJNWprWEFXelJqZ0hLUndnZ3Vi?= =?utf-8?B?ZjIzZmc0ZWRMcDJFZStmRzBWNmVkb1VRNDQ3Qzl4encxWXFHcVlYWUY3VUlr?= =?utf-8?B?N050RlFTUEsraUptS3l3c09zMkl1U29BVDZSYUVTK2Y3eldEUmk5Q3h0NStr?= =?utf-8?B?aDVPUVhmWCtreGFjWFVTb3Urbm01Z0twVXBIa2dBY2w1WFc1VzVDeHlhQWdC?= =?utf-8?B?Nm9EWGd1TVBrWFFWQ2NVd2Jtc3psN21aWlZ6Rnl6Q0RXbUx2cy9aTlQvNWg4?= =?utf-8?B?c1M3QWM2bzBObmFtWXNiOHA3UU1qQnBWOCsyai9jc1l6TDRQNFlSMTdXZjRD?= =?utf-8?B?SUhJUVE3S0R1NzZTK0RtTHYwRDBRbTJYVlczU3BqYUptd0ZEeDR6WGhzaDNs?= =?utf-8?B?bXRwNk1udDQ0WXBBcENsZ05iVFJyeTl6NXU4d1B0ZzRlSjVhalFvdndsMkxF?= =?utf-8?B?b29iQWRMQzlPWXBRemhQdVZNVWR5cnRScFR3VWRWK04xRDdYOCt0TTFIOGR5?= =?utf-8?Q?wpr05rWYoW7+KNMOnNuqEQ4vv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b146e12-eb69-453a-6e59-08db0f3f3935 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 10:27:22.2091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ePCyLHgt+SbNHjcmUhfyZ/IDChpkv3VEELE7rS4c/+JeT9q710kQc3W+lI+E54JBZzqbx/WFrUb/MBfUBTg00g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8237 On 14.02.2023 06:07, Tamas K Lengyel wrote: > An assert failure has been observed at p2m-basic.c:173 when performing vm Please can you at least also name the function here? The line number is going to change, and when coming back to this change later, it'll be more troublesome to figure out which precise assertion was meant. Yes, ... > forking and then destroying the forked VM. The assert checks whether the > domain's shared pages counter is 0. ... you verbally describe it here, but still. > According to the patch that originally > added the assert (7bedbbb5c31) the p2m_teardown should only happen after > mem_sharing already relinquished all shared pages. > > In this patch we flip the order in which relinquish ops are called to avoid > tripping the assert. > > Signed-off-by: Tamas K Lengyel > --- > Note: it is unclear why this assert hasn't tripped in the past. It hasn't > been observed with 4.17-rc1 but it is in RELEASE-4.17.0 That's almost certainly a result of e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively"), which added calls to p2m_teardown() to hap_teardown(). If you agree, this wants recording in a Fixes: tag, as - being an XSA fix - that change has been backported to everywhere, and hence the issue now also exists everywhere. > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2310,6 +2310,32 @@ int domain_relinquish_resources(struct domain *d) > if ( ret ) > return ret; > > +#ifdef CONFIG_MEM_SHARING > + PROGRESS(shared): If we go with the re-ordering as you suggest, then please also move the enumerator near the top of the switch() body. Did you consider the alternative of adjusting the ASSERT() in question instead? It could reasonably become #ifdef CONFIG_MEM_SHARING ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || !atomic_read(&d->shr_pages)); #endif now, I think. That would be less intrusive a change (helpful for backporting), but there may be other (so far unnamed) benefits of pulling ahead the shared memory teardown. > + if ( is_hvm_domain(d) ) > + { > + /* If the domain has shared pages, relinquish them allowing > + * for preemption. */ Similarly, if the code is to be moved, please correct style here at this occasion. > + ret = relinquish_shared_pages(d); > + if ( ret ) > + return ret; While I can easily agree with the movement ahead of this being okay, ... > + /* > + * If the domain is forked, decrement the parent's pause count > + * and release the domain. > + */ > + if ( mem_sharing_is_fork(d) ) > + { > + struct domain *parent = d->parent; > + > + d->parent = NULL; > + domain_unpause(parent); > + put_domain(parent); > + } ... I can only trust you on being sure that moving ahead of this is okay, too. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 10:34:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 10:34:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495844.766276 (Exim 4.92) (envelope-from ) id 1pSF7R-0005ND-D9; Wed, 15 Feb 2023 10:34:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495844.766276; Wed, 15 Feb 2023 10:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF7R-0005N6-AC; Wed, 15 Feb 2023 10:34:33 +0000 Received: by outflank-mailman (input) for mailman id 495844; Wed, 15 Feb 2023 10:34:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF7Q-0005Mw-4Q; Wed, 15 Feb 2023 10:34:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF7Q-0006vr-2n; Wed, 15 Feb 2023 10:34:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSF7P-0006Lj-Ls; Wed, 15 Feb 2023 10:34:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSF7P-00018H-LO; Wed, 15 Feb 2023 10:34:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4chgrVEUnV7uIgSI2hBjrDzOPlZ9oJjSeGL4fIKc8gY=; b=xN0GHdFvn8RMLDIw1AaB7MkjP8 sp+V/xIdFptrABjJssGjwbohQxacODXcfDQIKX9mdIF33VLCiOUn4uAHh9cweMptla4lTazklI0jJ RhWbZhK4joa9sCcz9oecuOoF4N8Ji2teWYFJLjGW01XfManio+gBAzd4q77O5RsUvzYc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177312: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=63305e5392ec2d17b85e7996a97462744425db80 X-Osstest-Versions-That: xen=9b70bc6d9678142a40e6c1c6934a32c7a0966e38 From: osstest service owner Date: Wed, 15 Feb 2023 10:34:31 +0000 flight 177312 xen-unstable real [real] flight 177369 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177312/ http://logs.test-lab.xenproject.org/osstest/logs/177369/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail pass in 177369-retest test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 177369-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 177369 like 177271 test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 177369 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177271 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177271 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177271 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177271 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177271 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177271 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177271 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177271 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 63305e5392ec2d17b85e7996a97462744425db80 baseline version: xen 9b70bc6d9678142a40e6c1c6934a32c7a0966e38 Last test of basis 177271 2023-02-14 11:20:41 Z 0 days Testing same since 177312 2023-02-14 20:37:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9b70bc6d96..63305e5392 63305e5392ec2d17b85e7996a97462744425db80 -> master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 11:04:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 11:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495858.766286 (Exim 4.92) (envelope-from ) id 1pSFZm-000159-06; Wed, 15 Feb 2023 11:03:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495858.766286; Wed, 15 Feb 2023 11:03:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFZl-000152-TW; Wed, 15 Feb 2023 11:03:49 +0000 Received: by outflank-mailman (input) for mailman id 495858; Wed, 15 Feb 2023 11:03:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFZk-00014w-Ep for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 11:03:48 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2078.outbound.protection.outlook.com [40.107.13.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a85644f-ad20-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 12:03:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7790.eurprd04.prod.outlook.com (2603:10a6:102:cc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 11:03:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 11:03:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a85644f-ad20-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFco3KyyQRLQmTi3d6OvU4plBR5V/T2ZtWc9Ssgt24M4rf4yCmIIpLgMOmLKuFq+D0lUmmkTHICb1j0oJF46ZcmHPseXHGPCkoBOcFX+LbDhPkxB0Po6i7zL35keWS8ah0uqJjLqW2O+0+BAm9tslKGwi0PzpstYxcQ5vB+WS5IRkiDPJVLzD0rhbPV5XKkpc6GnZp7V6zd0G+4CfAdflY3XfCVEyhS9bXMhOOvzee49t4Bmz4szxYuNbeoe+kHRlr1ZPI6OJZhkELyIZ27P2vNfDPXOw9mHbIpqB6Yw4kmyYYybXXyQt72U5FcIezzhX7b3AaUi6odxUEHdRIIvzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Af/TppUQveJ+dDVFLzwK5u9KrW5Y/LaBTHeydlg9KeM=; b=GbOg2ZGs3sCu30jXLK3uH9uzeWZ212YsxhvUhxTOhHcmKa8Ogk0/4GzFkVZBtJSMosBZzvbJL6r+zxaRH5ZGeVoC3tUzzlIG/MUhqzLWpxMmZalExnvgcbcwXbIWFGFnzfadwnc2xshnEoirj6+HJufizda+ev7GWxtkoXnG6KRCKgGtuG04RiVodON+Ezcw3F10scJ+BBPmOLeuiVPqGZNCqnx/k3KmNejSUonV1/CxUe9z6eUErCwHOCQoJ/cHLMGj4rnt/V/76NJ8FTYEyOFfHlSTTORIRbJ089HH/t76XsN01sBlToRYouL+Yq7ISD2FYNxkwfFV2gD9liE0VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Af/TppUQveJ+dDVFLzwK5u9KrW5Y/LaBTHeydlg9KeM=; b=3+y1dKB+p1CVDADRXOZ910bXCDthKVq0lc/GFl5YM46AKEnPQWGiSDxBi2uQ2fsTMKwDHD4Koz79Wz8l+crX0JkwNtn/z5PpAEN6t1Ey2UjgmGS7rqO6nh8+1Ku71HWGB9L/wgXbafPBJBOY6OLtRdgZFq/CAtDBwzS2HJL1DnkHmVWpKfhXda21WPdUXDNRGCWEXHPu0jnh7ITj7U2ABA75ebPltKGFAcG3Bj0DVmyum3VGOkwjHWPmgswEovOTa1SmrdPwdiqpdWEzHDn0fGYKCY+UKW6LpYkkGtDqdYcnOTPS7I71HrTXBz7UgBn9vSqTKrWpZ5AMdOoIMkZXHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <06cea9ac-cafd-4437-6e3e-639651a77349@suse.com> Date: Wed, 15 Feb 2023 12:03:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/2] x86/mem_sharing: Add extra variable to track fork progress Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , xen-devel@lists.xenproject.org References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <348063358f2ded237334b3cec7498a36296fd408.1676351034.git.tamas@tklengyel.com> From: Jan Beulich In-Reply-To: <348063358f2ded237334b3cec7498a36296fd408.1676351034.git.tamas@tklengyel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7790:EE_ X-MS-Office365-Filtering-Correlation-Id: ab714d98-a3e1-476d-24a3-08db0f443cf2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jUrJc6qgFaztVPd4RQCegXD6MBpYSr5/l+wE7LOOzO+JTDewxduczUH/2tb8Twg5xBh70qrab2teE6RD66DHAwYqbxx4jYp3fHoT5uDUKJJqDKudX7nhPc0NjsNk9T9NRmStCpr3Xda+e6JSj5Ogz7P4e4mAFF4mSEd47PL1ApvzPyDcmR8ALiG2LlS/0+UklcIvz71qOVUcotDzkz72HxyCSdDBIUfgMkjyZm6tUzUzhLqwXOTqpgvOIYXeV23pH2oxny1Wf60jN1wAj5/fAJPhVJAuc/imbO1BgLhuXOg/EmRT+JemV7tKXCA29hjAkbStWlw8g0uoZ4JcYyeS3YJN73pDH+55ET+KtAzpOFU0mDC0xOPPcNFsxjoun79EjjrsP6NnDm/UCUv/z2/11MHwiTgTgHiAR3rtJFHUMx6kUBckASecMx04B8nWdrcWYpsbOvSPUVaaMArB1LAk1Kh3DisLBB2AjXtvvTenHM+nfR9mE4qhOam3X1+h5uDHef2ZvRkPBHPG6yXeSkiHArkq2z0NUY/PQQu2D4wZBa5Ezo4MJB+dshf/K+uchyKsQy/zEkg1LvjiNd+fRoNT6ix+QiTM8mi48DTgzA39WfwyvuIt5hVn09nqTxa1ccA1gWZMlpz1kBLQIjvCwF0bEoHM1wDKGW+Fqro65Mt18bWrTYRYlznHs/56b9oEqHtiPRu2IUb/fSB1oEzBsT3zscoZZYMmNzxuZv7wlLNNhP0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199018)(36756003)(86362001)(83380400001)(316002)(6506007)(6512007)(6666004)(6486002)(26005)(186003)(31686004)(53546011)(31696002)(54906003)(2906002)(478600001)(2616005)(8936002)(5660300002)(4326008)(6916009)(38100700002)(66946007)(66476007)(8676002)(41300700001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmJENFlWR1pPc3FWN1A3cVpTOXNMNFRUQW8zTTlPMmVEZDd1SndDYStKZmx2?= =?utf-8?B?MmdPSFVUeWRMM2JTTm4vT3MvNjBBU2dCMTFISnBtMzlDSXFWejZhWVJHRTk2?= =?utf-8?B?N25jeWNUYkV6bElxbHdjUVVZa0JLVVpPUnJEQXZ1ZWZoYWY3ZFltMVBZNjBC?= =?utf-8?B?TzBQVm1KQzh2R0w4bk1rSk43Mmx3TDNjRkwwVDFBcjBWeGx1dDQvRXZ4S3pB?= =?utf-8?B?citBWjF6WC8ydHgyS3JXakFyRHVlMVJ2eU5PZWUyejAwQ3U3akUvYTIxSGRP?= =?utf-8?B?azAzNFljdGlsbEJJT0M2NVBybzNjS2NSUDc4R0xmSFVCTVFjSVJqMU1uUlNs?= =?utf-8?B?VHJSZzZtWDRQS2xoUFkxSktjWHNxblBEc2luZVMwV3phK1UwTFBKUjgxWmFD?= =?utf-8?B?ak1lK2lLbzhMVWoyTm9qRk1DcDhvQ2NkY2lYTGg0WHVYdTI2UGJvQlVLWTF2?= =?utf-8?B?NmtWWjFxUFdNZ0JmZ3ZvRmgydzBhbVVuNkE1VU4vWGVFdWZNZTR1Ukl1b2VI?= =?utf-8?B?a3EwcjBNMXh1blVQUXhQNFcrMWIrMytPUHNsM05WL1ZTYjhRaGxXanFwbFVo?= =?utf-8?B?cVp1M2ZaK2NadlVMemlseHlzNnZnMFc2WjQvdWkxSjlyeUZnbzMwVVhCeGJM?= =?utf-8?B?YytSRUliZ1VrdkprS2xWUGpBanNhNGJiQmRzUk9tL3FOa3pIWi9ocHVmcXo0?= =?utf-8?B?K25LLzVVN2FwdjBrczN3TkhoM09xQWJMTFhOWTFwZDdDWGg0QkVocnVKSTJw?= =?utf-8?B?UEVYWS9yMWtoSU9yNEtWYU9YZjlWcHhUUXlTSnV5MVNXTlZFSVFoTVBjYTc5?= =?utf-8?B?aDI3dkNMN1dkZWpESTcrUU9PMXE0Q3NkVzBDY2hTZWdyS05lYUlwTWJDOGho?= =?utf-8?B?SytZcERLeHRmbzJ3VW5kZUVLSGIwYURvc1FrOTlXcTlwU3Iza3ZENys3eXlZ?= =?utf-8?B?VW1NdWU5cFhnb3ZneVZHa0R2WldRcElrdHRjcUM4WVFzTVYzekxLZWVxc0xv?= =?utf-8?B?UmhrWHRFZWk5K0FoVktKMnZFUWVQZUN3WUhndU9jZkpXa1VZaXJyZk9wMTRG?= =?utf-8?B?Z1hKL3dlRkFOamlld01ETndxTUZjMzUvQ1ZhZ0lzMFlwTi9GNng0NDVhL0ZY?= =?utf-8?B?OERyUk5LSXNSdjR5ZHhTbi9hd25LbCtZQy9DUk9Pa2J2aU43MXlpUDhMWmFT?= =?utf-8?B?enRCNkJnajMxK1BqUDlrZlpRejdEa2tGMndycHdtN3VDM3BzWkFlRlhXS21z?= =?utf-8?B?dVRWRWZCN0IxMkgxVlIrakZVME9mRzBDT3ZZVkNka0NrVlB1aDVRa0RMOFJn?= =?utf-8?B?SklKTmV1dVRKWWJoN0tJdjA1c2czT1hCVENxMWFpMktwbDQ0SGpJUGJlUDg1?= =?utf-8?B?ZkRCSUdTWXBsL1dkRVl1VFN3TWNkQTF3cDZMU01sTExzZXdaOVJ2UUlQOHU4?= =?utf-8?B?eDNBUGR5YmhNMDdWbEVlRkJxV3hKZ0JML3N1cUZ6eFdYdGFtWjByelFDTjZG?= =?utf-8?B?Z3pkQ0JUa0I4VzNhR2RiU0dxK3NNYXU0amJzeHZoWVg1NUVhYkwvbjlZbjVU?= =?utf-8?B?TzZ5UThqUTlLeFRzWnFpRzBDWlRheUJ0eHVGRzhpNFhiMnFuQXF0b3ZjZTBG?= =?utf-8?B?NDVNUDdjd3NUeVJsdnRNRmlHd1BKUTdSZkExdzJUT1EwWnQxekVMeW83MXdV?= =?utf-8?B?YVN1djRpUlVkVFlDTnhyOVkvMDBMQjc5VE9JSjg1ZDFpTXFKb3hnVHRSYTJ0?= =?utf-8?B?NjcvdzZEV3JCR0JFdGxwb2hqMlZRbGZhaUxGL2gxMHlSTUt5OGJFWjE1VFRt?= =?utf-8?B?WktyUCswRldDbGVENXRDZFJCTjN6NXhMZGp3U1RPalNXV21hakJpZWp6cVpQ?= =?utf-8?B?MWVwR05oRDNTbmxNTy96TVlKQ2dQZ3NiQkR5dzRwNk1rUFEwZytHd0xYQlZZ?= =?utf-8?B?cU1xSkNlSmVDWWkwZkx0UG5iOGdvVlNvV3FuRUpablIxSXpTR3lQUGpUdmlv?= =?utf-8?B?dTc3blRmVFU4STRjeXpOck5mT0g3MTRuMHdpQlh2c3ZnaHhXQkpIN3l3MXVM?= =?utf-8?B?K3dhM2tqY1g1cVljQ1RsbkdvL3g2SFN4L00wY3B0QTNVS0d4L0ZtZTJmYSts?= =?utf-8?Q?2extbgj3WTkIg8Mk4sCAJoFqr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab714d98-a3e1-476d-24a3-08db0f443cf2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:03:15.9158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hKSQ9rGvReMysz6WGp7RSe2ziP54GB8boLgWtRi22lJJM3t1XvAUKbD0SGY3arLztBxLvaCszDfbLAv9An2/+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7790 On 14.02.2023 06:07, Tamas K Lengyel wrote: > When VM forking is initiated a VM is not supposed to try to perform mem_sharing > yet as the fork process hasn't completed all required steps. However, the vCPU > bring-up paths trigger guest memory accesses that can lead to such premature > sharing ops. However, the gating check to see whether a VM is a fork is set > already (ie. the domain has a parent). I find this confusing, and I had to read the patch to understand what's meant. Since there are a total of three VMs involved here (the one driving the fork, the one being forked, and the new clone), "a VM" is insufficient. The sentence further reads as if that VM is performing sharing operations on itself, which according to my understanding is impossible. Furthermore "the vCPU bringup paths" is also not specific enough imo. The forked VM as well as the new clone are both paused if I'm not mistaken, so neither can be in the process of bringing up any vCPU-s. I assume you refer to bring_up_vcpus(), but I'm afraid I view this function as misnamed. vCPU-s are being _created_ there, not brought up. Furthermore there are no guest memory accesses from underneath bring_up_vcpus(), so with those accesses you may be referring to copy_settings() instead? Which in turn - I'm sorry for my ignorance - raises the question why (implicit) hypervisor side accesses to guest memory might trigger sharing: So far I was working from the assumption that it's only control tool requests which do. Otoh you talk of "sharing ops", which suggests it may indeed be requests coming from the control tool. Yet that's also what invoked the request to fork, so shouldn't it coordinate with itself and avoid issuing sharing ops prematurely? > --- a/xen/arch/x86/include/asm/hvm/domain.h > +++ b/xen/arch/x86/include/asm/hvm/domain.h > @@ -33,6 +33,14 @@ struct mem_sharing_domain > { > bool enabled, block_interrupts; > > + /* > + * We need to avoid trying to nominate pages for forking until the > + * fork operation is completely finished. As parts of fork creation > + * is restartable we mark here if the process started to skip the > + * non-restartable portion. > + */ > + bool fork_started; "non-restartable portion" reads incorrect to me: The issue there is with that portion being one-time initialization. I think this should also be said this way. Furthermore (nit) it wants to be either "parts" and "are" or "part" and "is", and I think a comma after "started" would help readability (or else it can be read as "the process started to skip "). Finally maybe better "... this flag indicates that ..." (in particular because we definitely do not mark here, but in fork()). > @@ -1905,7 +1906,7 @@ static int fork(struct domain *cd, struct domain *d) > *cd->arch.cpuid = *d->arch.cpuid; > *cd->arch.msr = *d->arch.msr; > cd->vmtrace_size = d->vmtrace_size; > - cd->parent = d; > + msd->fork_started = 1; "true" please (and "false" below). Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 11:20:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 11:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495864.766297 (Exim 4.92) (envelope-from ) id 1pSFpw-000415-EI; Wed, 15 Feb 2023 11:20:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495864.766297; Wed, 15 Feb 2023 11:20:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFpw-00040y-Bj; Wed, 15 Feb 2023 11:20:32 +0000 Received: by outflank-mailman (input) for mailman id 495864; Wed, 15 Feb 2023 11:20:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFpv-00040m-UQ for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 11:20:32 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0623.outbound.protection.outlook.com [2a01:111:f400:fe0c::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfeffa95-ad22-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 12:20:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8704.eurprd04.prod.outlook.com (2603:10a6:102:21f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 11:20:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 11:20:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfeffa95-ad22-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAnNdXpkwzhiBfFwlNTkOmY+kA2gMdIav+jSd5wYyveYgNF2P2M03pnGhARNBQ5c0oLFXOUXtckI61iVrabo7iUjVfrPn33+xgAPSrz6/HsaeOgfRG+ec23Y2+bRjfazWHGeeOeC8EsorGH2CeUnSF+OEbuwgxztBGvtQTC+gMcugw4/mjSx3bdvZrL28Gqc7T9Bk9xx9qoNsf0I7vLRpBrol2AwjpcmMy5FrL7ll/pRzoL9KRvFzXLxSoYli9ZUAonM37EmREWew6ZW3syGALMx/N+wQr8vUtnYaA70t4DoxDCdfF3ephsYzkr0+geW04XnDNMEEvinKeqIrxhDJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLQBwUo8pTsjmjnQXXWMkKlj6IoehQgr5Q98hhErjCQ=; b=PT1LZgkKf2XS1F6gFwvooCOIv72/n813ZnCbG6xqmQjJ+AMHJnn6OHFRe2tyvY+Ik8MbyMMi+JtXrlF2aT6FDWpbprC2vCX57F8LBFzZ/51WCMT46Kh9Qb+vJB3+uRXC+0T+fx4um2xbM+8OqVS34P7pZOMcvtyfJYSHW9lH5lxuMhrt+2DrUHv9MmNnpGxY14OVZVs1WygB1UA1deQVZkxFSHo4KR3xqTkiIEVZh9WNZ2fNvuQY/y27UcsNtLdG8+xG/LHNtWO3nkaYTq4jN8P4sGGLCFMkMZnqHVt8Kw6xlKuPWJG79sNj5wP9FWQ4BtaKvR3uAVHvbsf1jYH2Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLQBwUo8pTsjmjnQXXWMkKlj6IoehQgr5Q98hhErjCQ=; b=G2+cjToEyp6FpvJzCd3WqGfpMAZSFoNy18zd9J0bngt3EQhVKgQr3/leJRTmmyyK1gxeoIE8MRffBFgFnUvVv6qqEvhsZgAiw73SH5rTAvm2Qe/RitnVkJCpTQlp9ZyUr7H/syFyAtwtuyjBXTQeLJV8yk+LHRe5+VyNXksZ0WVzWmJnIjp268ITpJgmcOShvgxLeLx2ZUfMMRZXt4by5DLLlr+2z3btCACD+ajX91LQtZ1nOycah+vIc0tmT/IJqKBw20JEPhtjlY8OMQsw+56u2bfw9Dwjh08lAwisEMqmc/a5o2xcQcU2hqHIy43CouVZK5oT5yP/ghLn2o48xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 12:20:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH 04/10] xen: add reference counter support Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-5-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-5-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8704:EE_ X-MS-Office365-Filtering-Correlation-Id: 601ad46b-e70f-4f98-6d68-08db0f46a2c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dj+LUULEq9RsPbPEq9f0F2xFPsYkUGd2aHgFRgukgxjY7oHYsyLTR3d5LTdZ4C4h4myMY9KMoOPcT7o9QxOiCg8mczdz1wIEIah5ppLqQqTWQbrqlFZ4bDpgOlBxwJApJXQNy0AuCTQt9AaAkB2Czxpi0m713b8G9XgJ4oGaixA1cTnev5kRJq0FUFyYfwvC7zJkVZc39+9dS7pgfl5uFYJz0FcIEeLZLlcdoQlxCwAyRlFLMUYKcoH4muyshBChm841ICsTEcM5gyzTGqWmi/yu62gjSdIW9kcbCBrmDX8hylklMOjQtam/ZVjuJHm7u0euN5plRTFJUrteG7vXuFxN1VCbAibrNsEO1L5i5Lv6wKV1GljVGec00xiRRwp0GRFvU7U8kVpt21M7GOqhOJBF58fUoJU21ulquEOECkG4y+TkIZuKrVyMHdve3jf5MC3pPrMWjFQXrOqMsBz7UkJ72W7exb1jL1ZjLn3qExNm4Nr3KzRasECprFk+v5rO7PlVg9FnGtcPifxJ/+2Cfu3WjZSabUHzwUDe03kUcx7eOfanSZOy4CIPn3Q0G6LnOkNpPWU71MzK0ql1h3ydbkuuYrHqvfJ0nOP+SA7BbZ0g4Do1EngcjAp0gXHtH80MOhZiCkjK6RLT6AZrgdlDh2DGicDVCVFw4ASU1NcVd2j92eOcPuX3o9IoUDGBUHvWDkLZrXsn/aIt0HArVz0oyPfRiQNZotgcDnEN7DzY1TI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(39860400002)(376002)(396003)(346002)(451199018)(2906002)(186003)(2616005)(26005)(6512007)(53546011)(36756003)(6666004)(6486002)(478600001)(8676002)(31686004)(38100700002)(41300700001)(8936002)(31696002)(66476007)(86362001)(6916009)(66556008)(66946007)(4326008)(54906003)(316002)(66899018)(6506007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1RNd3VFc1VuOHBHSHBuMXNSNkJ6K0JRTmYwclA0UWVjRGFWOXh2SGRvRnFy?= =?utf-8?B?OHZCZzBvbHBibUg4NnJWREJnUU9pUjc5US9DK2tCSFdkVlY4RzBhWmpRMU51?= =?utf-8?B?bmlYQUFGM0txZ3BRYzRhOXhJWklJR1RwQWpMTnFOd29KZGFCcDczYU82WXp5?= =?utf-8?B?eW8raXFTdTFCYWFlb3JZSXVabTdZWGFBRU5nbVJBbks4RkxXd3dsSkJERklH?= =?utf-8?B?MDc5VDhyUTkzV3g3NGVwc2tzcWRWclFwVytKdXhERzhhV3lvMklpY1hSbFVT?= =?utf-8?B?dDl3bGJyUVFtUlhFTktuQktiZlAvSzkxdUUxOVN4dCs1TktoTTN4eFAvbnkz?= =?utf-8?B?dzJDMmRJc0tNUmdxSFRnYXlQd3BGL0lNY0VVMDlaN2tSWnFRNmJyUU1rWXQx?= =?utf-8?B?QTFUaS9jUEJMVTBJUUdTR1RlRGFhbnd0MHVib285OUEvclltNVBWUWlYY1Av?= =?utf-8?B?U0owZk5lcVJTSkFhTXA4SEZ0MXdsKzdVb1RKZ2tFUVUzUXN3RFlDd0pjek9C?= =?utf-8?B?dVQwQmdFekVGb1g2dmhvRkY1OVowVklDaTVoVnJFbnF3Q3V0SVk4U3FPZXVP?= =?utf-8?B?QXNSOUZIb1lrc2pZbDl6NnVlRC9hYmJCQVBzNm9TQXFSYUs0NVBhT1gvdWJO?= =?utf-8?B?eFhxeE1BSlBCQ04xTjFhL1BGMDFyQ3h3R3UwUjNoeFVzWTlTRjBvVEYrMTlG?= =?utf-8?B?dzNVbld6bWhtY3B4U3ZGejU0OVNIN1Fpb3cwbVQybFE5NW9uSXpPa3JKY3RR?= =?utf-8?B?RGJiOVRYMkszNktLdTFzenMvVHcyZjFtZUg2RnRkQ0JOVlRBSnhKcFZzYmJV?= =?utf-8?B?c0JDSys4Z1dsYXZNeFZQTmU4K0taa1RIL3ZYTllWQlZ3V2ZMK1B4ZXNOR0w3?= =?utf-8?B?c05EOHZmOHQvZmczTTc1K2k4ZlpBR3p6dERoNjlDMWUzUmF3MjlOZERPQW9U?= =?utf-8?B?V2VjUURlZHREQmJ1ME9lVmVQWWhNckY2b3ZpT0E4UnpXaDM4TE9TbWlPTnFj?= =?utf-8?B?aVRQWlAydkdLTUoyNCtQMDNLVWRoeGZicFhoV2xodFVYVFRqYWNqbHhxeDU0?= =?utf-8?B?eDd1OTNIQit6ckhQV2RpYmlPNHpnd0JtbU9qc3k2KzZqNXBsTW4zQ2ZyRnFY?= =?utf-8?B?ZElDZGt0S2xxMzhCOHlaSXNTREYzYUtBVUE3MzJzM0k2ZisxRE5rQmhsR0dI?= =?utf-8?B?SnBlRC8vM3R1Q1drMUxvTEluQ0V2TzU1SFJKUEdVTUlPVGRaam4zRlJvOXJQ?= =?utf-8?B?dzZpeGpZNDBYVFhoeGhrK3BaZ3NqS0hTczhVdG5sb3UxUnNmb1E1NUV0MzN4?= =?utf-8?B?cFRZMnQ0NDhZWFNOenF5OWppZVk2T2FySklmK1grNzBFbDFqNGF2YUwyVUh3?= =?utf-8?B?ZkdYODBXSmI5QUl6Q2htS2FyYm9GUTRmbkN0OFFnS0xWY2FTWFA4bVprZHRR?= =?utf-8?B?MkhHU1BOek5NaHlkYXM3cjhNRUplTGtTVmFtRlgrK3oyUW5CUFFBOWpLOW5G?= =?utf-8?B?ckhlUlBZVnV0U2wwRVd2NUFaektMVTRObCtFL3NtQkR4cG43MGtpTEt2cWVK?= =?utf-8?B?Y240QmJTSzZMb1JyaVM3ZHVOWURGRnpkeG93aEwwMmhWUFhBMVZNQk5Ba2x4?= =?utf-8?B?WmxFR0dmU0hVQ0Q1aENiTkFIbURPVEhSNmtnVVZ1UTJLVmZZZUhDdENYVVlG?= =?utf-8?B?TmZHWXh6dGdETGFOVmNlNjczaFV0ZE9tK3cxeC85TndBZ0pGNW40NGN1WTJB?= =?utf-8?B?dURHUVluQnBYejFRbDg1RENwemN0bSsxV3Ixcm8yTEpYUU9kdDIyU1ZkcXZX?= =?utf-8?B?NGU4Tkdzc1JqUHNKdlRRRE5HaWhpS1Rqb1RGanl4WXJKaWRqTGtaYnlIUjRs?= =?utf-8?B?Nk1TYTJhMzNmek8yL1IvUjlJSFF4Y1B3WFVaWkx1bm5zcUEvZGhWZC9kaldS?= =?utf-8?B?Sk1JcFUxd0U3NmdRTkd1S1pySS9XbWVOYTAyUW5IN2cwQWdCdGpYaW4yWXZY?= =?utf-8?B?MklzOER1bHB5ZzJ1WXVEL2hBNHo5OXlLMGE5LzJscHk1b0dHTElVRDJqNW5s?= =?utf-8?B?UzlTcytnbE9MZ3doNXJKL0xZc1ZwSDR1T3FmNWR1blNnUkdnYWdjV3dVN1Vt?= =?utf-8?Q?WKFNjkXXjQmZ8LcVBK49dv3Ry?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 601ad46b-e70f-4f98-6d68-08db0f46a2c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:20:25.7257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MIsasXu0py0g2qY4eHLHISsd7WzJg/LQIZ9yo1AZhS76oFhpvAz1gTqd4G6iJu4BFtNrVT8C5qH9BgJIGyEOXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8704 On 31.08.2022 16:10, Volodymyr Babchuk wrote: > --- /dev/null > +++ b/xen/include/xen/refcnt.h > @@ -0,0 +1,28 @@ > +#ifndef __XEN_REFCNT_H__ > +#define __XEN_REFCNT_H__ > + > +#include > + > +typedef atomic_t refcnt_t; Like Linux has it, I think this would better be a separate struct. At least in debug builds, i.e. it could certainly use typesafe.h if that ended up to be a good fit (which I'm not sure it would, so this is merely a thought). > +static inline void refcnt_init(refcnt_t *refcnt) > +{ > + atomic_set(refcnt, 1); > +} > + > +static inline void refcnt_get(refcnt_t *refcnt) > +{ > +#ifndef NDEBUG > + ASSERT(atomic_add_unless(refcnt, 1, 0) > 0); > +#else > + atomic_add_unless(refcnt, 1, 0); > +#endif > +} I think this wants doing without any #ifdef-ary, e.g. static inline void refcnt_get(refcnt_t *refcnt) { int ret = atomic_add_unless(refcnt, 1, 0); ASSERT(ret > 0); } I wonder though whether certain callers may not want to instead know whether a refcount was successfully obtained, i.e. whether instead of asserting here you don't want to return a boolean success indicator, which callers then would deal with (either by asserting or by suitably handling the case). See get_page() and page_get_owner_and_reference() for similar behavior we have (and use) already. > +static inline void refcnt_put(refcnt_t *refcnt, void (*destructor)(refcnt_t *refcnt)) > +{ > + if ( atomic_dec_and_test(refcnt) ) > + destructor(refcnt); > +} No assertion here as to the count being positive? Also the entire file wants to use Xen's space indentation, not hard tabs. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 11:28:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 11:28:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495871.766309 (Exim 4.92) (envelope-from ) id 1pSFx8-00050A-6g; Wed, 15 Feb 2023 11:27:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495871.766309; Wed, 15 Feb 2023 11:27:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFx8-000503-3T; Wed, 15 Feb 2023 11:27:58 +0000 Received: by outflank-mailman (input) for mailman id 495871; Wed, 15 Feb 2023 11:27:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSFx7-0004zx-IP for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 11:27:57 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062c.outbound.protection.outlook.com [2a01:111:f400:7eaf::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb2ac7af-ad23-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 12:27:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7363.eurprd04.prod.outlook.com (2603:10a6:20b:1c7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 11:27:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 11:27:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb2ac7af-ad23-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzmABHkc7jRkL8uK/xfg5j9Nalx0miVaoav38962gBhqedvgRC83/+Lt618UGMVRVI5apUY1SoeiWiYfl9vSd87SvBgj7fMhT4PFUzTsqZs4Uhp5F4J2W+brpQlO+2mf3y/z0tAC+9rscVhhBsoTbRihUm9jThBUEolxk7tgo3AipeC4kOuNn5iFVFyEfPqEovPSF5gOMSjH6b4mPN0DgOMNciP/SXZrRM9H2Age6x29tFNeBFOj3vBoRj8QbcjaH1pcp6XWWd9nqNTe7xIo9h6J43FM2QG9BVHqCxSOWDclkWSNTE8dSF2OOrwZiu6AsEo7XZuF6s0IY5QLqMrjZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q2S2Z4nHnnZXHuZpBETj8tDkAK/fJe7Xebpm35w1m4Q=; b=QaK7lUquOyk2fJBwyxAn5sWY/oYTvLlaAPgU9w8IFCE9r4NEuqhrmoP88iubPD17uvqoQUcKBOyb37Djaer92ol74AhLUYEPXDQoCm46pO/jQRlCyabNWtAaM8dsjM2H1tF8M+oN+3emK3gLeigrMosM/AcvOgv8ZXldk8/Jes3ICZXIkiSUyQOoG/+k3w8SQe4gWVOXhZwazPq2mjiRnkPDHilnKryod7XReNAJ0HUg/1WniEb+196KXFg2E625DR/eYQyLhNowVt/uM85ScCurZ1Ba7drDaYFA27d9ZJ6YCojmgotOlkcrMEjEr+AkjASr3Ib1HhQF6amBYvZX9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2S2Z4nHnnZXHuZpBETj8tDkAK/fJe7Xebpm35w1m4Q=; b=j97m5VMDKDOoa2TATWQd4y20tnTqfrN9hfw77nnN49bvqdARZjQpl0TGH5/64EKqy3F5VTRcSaf3F5WvH6dpeHuBikmEeFOUiRsu87040Duq1cburLJ7cYPM0F8+r+yKjoO8tN0Vpn3NYiZJnvDnjtCYhSYy5OQftfEMVJEV2877MNDPgbwoemC2gAUo+xD0pchbR5lEbQGjsGjQJ1q9DfI1b0ZQXkO3sPqahWiXXn4HilTMeuSkicnZaUysMCyQuReGFyLGTZMVqHyfrq51YSHMEuQea5ClEeIcEIjgnIzLJj7hHDuVjZr1p194jiBD/ETPO15ZPzyJYy5+zqW8eA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> Date: Wed, 15 Feb 2023 12:27:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Boris Ostrovsky From: Jan Beulich Subject: [PATCH] x86/Xen: drop leftover VM-assist uses Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7363:EE_ X-MS-Office365-Filtering-Correlation-Id: 965e6e28-9fd6-4d39-6fed-08db0f47ae57 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3I/qKrkoS2CBG+VKmKp11HjZwK5lNU7vSEm/tBIgeIKXAorUz0nlZNeBSmGPGYviU++CNV1Ska0Jv03GdJhPiyW5gkfcZoRHR/yPEwzVZ1BkiMTy/LaFYsiSqSvYPHt0EYrB0VcoDi9Dcx6KeVDPnHDiwlch+iW8GDfrlJuFy6o4Ll35FYMqYNwEnwOKjK4tM3SHtaRmZFYq8PSVyZohlWNQiajaFcuuUbubGLgj8WcRpsuMH3OJjo2LixUmXjrfOPJ5UzSac7ci1iQAlEVdaR90++C3nehaN9GKNgPnLWI/Ji12youjus1tJkYrcNuqxcNT/4OL0UzE6xOVUlPtM3vMAgOTiLhhdgkoDepPb0zBkIEQK7kzl8O95a7YZrBlCnaKdOe2LEQIcySkEiCXyPYbODctzSH85fYqecdhPH62Ef/hfR+3VrMy2CaSTyIr24oQh72+wiEmUk09KGWC+dXT3zQQ2cAyICA7F2d3CFurqVvizeOTtwzC1lTSEx5+ILXCCOIGfej3/L5RCAW18QF+masXp6V1BF+9F8EmE/28cEJ2eKpzk0cWKASk/0HYgBG/lnsCOdyR4IADmt6z5++Nlp7vVmJNlK0J7x+YppFhHz+DDovkTxEH9WgC5onscWPNKo3teJumhknwbC/lNTTfG4hC3fSfekcxac4cFvtm5pIGs9jIUWPGVSn0F+pd/6xokuNq4mHqOHFbVjqmZiAG04Z1nvpKnvhmwI1dn18= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199018)(8936002)(86362001)(31686004)(4744005)(31696002)(41300700001)(38100700002)(5660300002)(4326008)(2906002)(6916009)(8676002)(66556008)(66946007)(66476007)(316002)(54906003)(2616005)(478600001)(36756003)(6506007)(6486002)(6512007)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1B2TzdZd3ExbkxEOXcraVFRSkZ1R1hCQnNLMDJOcEpYb2szaFQvbVN1WVl3?= =?utf-8?B?NE9kUm9uR1M2dGRRcVplNjlxZTVQR1BXTVJvY0t4REUwQXVISERhWXpwMUhy?= =?utf-8?B?eXVjS05SYXdwc2c4RVFRVmZwa1dMeU5uQ3c1UXdPQ1lzREtyeHl5SEhpYzB0?= =?utf-8?B?UFk1QkpiaGYraFdsVWorYnRoa25KQlpMdmlWTnNPdG1hdkVvSEhtZ3YrRU03?= =?utf-8?B?QU9aQ0tTRW1qOTJmMWd4SldzSlV6ZnBlOTBqaVN6Zk5tdFYzOHk2MEorVHlO?= =?utf-8?B?dmRUNGdaWWRyQTNGbGtCbHBBQjA0cTQ4VkxlaTlNSkpwTStoemlXTnc2MGpy?= =?utf-8?B?eE53TUFOdUpzTTR2ZnowS1JlMnpaOU1ZMVhTdWY0SXdkbDRHVWJVVzVudHRB?= =?utf-8?B?QXZwQmowSmlEWGJuUjhuS2dLN04yaDNuc1EvblNtRFJsUVRqMlFrZ0V3R3p4?= =?utf-8?B?YlpNU2QwYUFuQTZxS2x1b1RvRG5KVVpzeHBZbThDRDJqZWUzQk1lZGhwY0Vx?= =?utf-8?B?a1lGZXRTSUJSd29mcm82OFRZQ3ovSjZsYVgxK2k3a21YdXl1YnBVV2xiWUd5?= =?utf-8?B?U1JYaFRtZ2xSR2I2aTdpTmNJb0xxcERQUlYydzFZNFdPVFJRRDlXZmZPeklp?= =?utf-8?B?cGlsd3BCZGwydUowRzJNZTJLRDUwclBvNU0rY0NaV1doUkhpVWxQODZJVGFv?= =?utf-8?B?R25KRFJ2VmpERXhNZ3VFMVdFTm1VSFU5aVFOZGtvYTkySU9qaXUyT2h5VVQ2?= =?utf-8?B?SThDai9BclM0b2xDc0ExVlMwNFRCQW4rZ04yVE80OTBmcDBRazVTOHBnNDNl?= =?utf-8?B?a0VOQ1lFdG1aWlNETzI0M2hBb3RvMDNuKzlvbDV2MCtQMUNURFMrdWErRy80?= =?utf-8?B?a0NHOW1oK1lVUUdaeUtnYkZCUjZpdWpSMjZKYi9lYkM2bFE2VUZOYmZYYXJy?= =?utf-8?B?MnVSYlk0bkU2ajV3SG5KQW14ZXJxUDFqc2xRSU5yRlRjYnJrYzAvMGNVUVU1?= =?utf-8?B?aXdWbmN5Y0VycHkvUkhKZHlCSmIwWHlpcUdWNVgzWFZmZzV2RWIrcjdRMDgv?= =?utf-8?B?RVdCby9tMUw4eXJwakxtMW85alE3bVJET2h1d0hoZ2FBQTFJQjFjTEVuQUdh?= =?utf-8?B?MmxJVnRtb0hpL2dJcGYyNU5JUU5SQ0xFNDdPYUxXUnBPVzY4dWN2VUN6VUVY?= =?utf-8?B?M2txTmtJa1VZSC9jVkp1dFRnYVpkUXR6UzdqcTh1V2Ixdk1vNThXZWhFRU5j?= =?utf-8?B?ZVR1MnhBNXowaGpFWVFwUlBUNlBIQ3l3eVZkeExiK0FPbmdrTEVwYjNiS0dx?= =?utf-8?B?bmQxdzIrY0EwZnBKVXd6Sjd2UXZ3Sm15YlRwNm1HalErbEhaeTYzb2Q4R3Rj?= =?utf-8?B?VERBYUtkaWRTbkJVcmtkYWNXMXNWbUdMcVV3RlROVjJKTDRlNTJiRGhnK1lq?= =?utf-8?B?UzZKMDBmSzA0S3EwRGprbHN2YWZUcSthMHNjT210REk2NW5MMjlUTE9wZ3A0?= =?utf-8?B?U2tydTNoV1VoZmx6SmRpMnd1YUd0aVpheGREcExVSVlMMk5kd0ttY2FTQWZQ?= =?utf-8?B?Nzl3YnY4RU9VMVVQdVNYbVlrNTRCNHpBMDIyUGV6V3FmTGZONkozVUZ1Q2s1?= =?utf-8?B?aW5aRWNLWDhyWXh5R3poZWhySW1WUFR0aXBCc0pWMjFyS0lGb1FCYnkya0Z0?= =?utf-8?B?TzN4bE9Ndm15UmhpTTFIOTVYbXFRR1NPbktqZDI1bE0zbDR4ZEZFc1luR05W?= =?utf-8?B?SjkxMEJOdTdtWElSMnJ0c2VFaEVTVWhFVjhIdHJHdHE4b0MrZi9IOEhPemNy?= =?utf-8?B?SHpJS3pEc0R3Mjg4azduM3EzOU1MRHh4eFZIWlp3aFVtWTF6ZFhiaVlnVDAz?= =?utf-8?B?OGdpeTdBclM5YW53OUc0bUdFNWozSnhHVlp0eThqQ3JLNXQ0MkxzSHVvMS81?= =?utf-8?B?eEVpZ1NZb3RZcHBpdWw5c0s0YmE2TDUxWitrSXd2eUhUWUs2S0R0V2Y0elV3?= =?utf-8?B?d3E3V1F2ZWhyTU5CQWVTMitsN25ZcHBCMmJUMm5kcm5iRHErWHY2RjFMZTlv?= =?utf-8?B?eVVOdUJmYUNUNnMxZ0FXaEhXTFlVSE1YeDA2UXptVWkxTDlCRkxwQmk1Q3Bq?= =?utf-8?Q?EcnhsX9U/kXGpjdXbjaoBCvQT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 965e6e28-9fd6-4d39-6fed-08db0f47ae57 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:27:54.6992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2wbCQyeLfp1f0kfNnMahbWB2rO3KbEPaNeCfG8vWLdtGgJBQhnghFwIINHtI48WhOgDdgSOZrFAUuT+q+YUSdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7363 Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant with the PAE_MODE ELF note anyway. Signed-off-by: Jan Beulich --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -934,12 +934,8 @@ void xen_enable_syscall(void) static void __init xen_pvmmu_arch_setup(void) { - HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments); HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_writable_pagetables); - HYPERVISOR_vm_assist(VMASST_CMD_enable, - VMASST_TYPE_pae_extended_cr3); - if (register_callback(CALLBACKTYPE_event, xen_asm_exc_xen_hypervisor_callback) || register_callback(CALLBACKTYPE_failsafe, xen_failsafe_callback)) From xen-devel-bounces@lists.xenproject.org Wed Feb 15 11:33:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 11:33:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495879.766320 (Exim 4.92) (envelope-from ) id 1pSG2c-0006jM-W2; Wed, 15 Feb 2023 11:33:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495879.766320; Wed, 15 Feb 2023 11:33:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSG2c-0006jF-T8; Wed, 15 Feb 2023 11:33:38 +0000 Received: by outflank-mailman (input) for mailman id 495879; Wed, 15 Feb 2023 11:33:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSG2b-0006j9-CH for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 11:33:37 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0c::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94acb731-ad24-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 12:33:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7523.eurprd04.prod.outlook.com (2603:10a6:20b:2d6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 11:33:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 11:33:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94acb731-ad24-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ev7ac47h2W1zrCO3SMqfSTI9BvTdy/NFZkQgqGBr+31BHEhaeHoNXqRcW5DH3XcnaxaiSf/kd2R4BmcMuuWjQVQYBeBrNIgKjUqim9hdsXLDc0xArHLd9M8z3lht6MHWY/FR7D703MSrZzdW/XK5CKQvEyAqXwQ5ec1NceOghFH6tiY6/Gcy6KEAposcT+M2PWFUrDy+b/fvtsjtZrAOLaQhvOLqe9HUTej3MA/VGv24ammDI6/opKYr0yKXw5DtqcHbDaLR0k46xJPZMxUNpeFk7jWWSMx+n8Hlje8IQ8ZN/Ch699VbdwHX08I9rkCEuh/kxs1CPs8f960LUG6Ytw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ir2XACLlXoYPNEU1byd6Ec5CzhHU+/fEwvRtqRixVnw=; b=k5oiRSs688fnToot2w08UhbtnEtrGzMfoz/BMuTolBleGBhpGapPy61GVmuAQ4Vwnfy/kgk8JrqhrU6Hwu9AYrDtilgjdyvnq5eG9kvftckhjPpWY+cceAZto3W6agm5YrCrSAkY9FiyXidKJUV0fu4ru3Nt3918GUcb0kwTOoYEcD7BPI7grKsdwZe107uqBUavA25AiWwlc1w03ktWRtZv4NLhApsAxrckZKa9iWpRPm+FLPHU1bi5/YS0VkDmebEJZl13o8Edp85SInVASX34mki3TYOzf3yZM8OJ8d7lKwkkqFElLosxAo0UlV8pHmPeGwqR7fr1AboLXfu6OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ir2XACLlXoYPNEU1byd6Ec5CzhHU+/fEwvRtqRixVnw=; b=TQ6Fq+Qd2phg1GXdZMmMrjjz2DTQj8A404q1PEe6j8FQfhEsKBIsx8B9+m1PZikW2UcgKYpo1WZ8GhXu6fSfco8n1lDTCn9aXzSumZmak7hj82510dsLI5C/VN49G9FTjYJKkkUTe/yNBJnVAA01gcxjG3jhgX8VAhqsQT74I89ep5pchIDr1ej6pENOvbm2YGWjF0GpQp484dpql+UQRHEfDfnOOKWlGaMioX7ByKVgt/SNdINJ8PkK4ro9lZnEA0Wvs20SS+pj5awd8p3Q/DHMP8JDEhOZUn+hX6WTVnnfr3JyPfSrLaj4dD7GrbQRMYQsU5Eql3efSFIoD8WQ/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 12:33:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen From: Jan Beulich Subject: [PATCH] x86/Xen: tidy xen-head.S Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7523:EE_ X-MS-Office365-Filtering-Correlation-Id: 658d4215-c68b-44f7-b46a-08db0f4877d6 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mcYNAxc93uvMGghRZJeNt/82X4fO5n7yWjNj8m+xl6HYJUkvLzZ7utG/XmPjoXgTh7ShN/ESiHYZhEar50s8C6WsLfVqSl9XrLIIrmMRW9cJ6ALLR7RaokJrhenufk9cM+Msevnm0QIL4eDGSpZrNZkbpvP1ODtOCMl/TqX4j6/d/aauwekmSoMG6iTv3ne55h2RjwUmLmZMpOiDYg7foxKPd2SvaJtu1qqjNrIOyjKBtbmEmrB5DtqzEZjye6+bGb+EsHkwCw7WGLG6/M1gTE+DedPJ84TFj4MaKhMWxCVPBXAKDwjS8BnVBgYcVHSu5SfmRDwQr/RDYjBdw5YEmhYQQEsguH5zJ+ttbUv/eeTktURSY9pSjfHYqIvYP3JPaeoCVpbBZkQHnAcTfHyLrlS9Q0W/30PPXZjhGbLT2tvlMwQcTyeF4RErdK28TFjcUFXVmgKmJik5CFmrAM1gUYJ/pPiS89baf/zJU6yMlkXN4hwF6WfWX0QsDAmntUlzQD4IgDEqGjY7m4mbbbs29aNq14zSlsAU3aZYSgXoIcBUB0+ZobvQtk+/NgHi5O5V3DibcCS7T0rccI8TeErF8XIaTSEQqAMg0Ief7Sd3Dr5QcyKKBDlwt2q3iShrVTs7XsIw1VgSHTmXwGjSrhY3RGi4Cf6h/e/62lHwtSswiUfYZkP2daVbB7ncm3oaOas4LOAl7281yEfGHYz5rlboF4bzlg8/8GFtTn7xgHBPTVs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(396003)(346002)(136003)(39860400002)(451199018)(2616005)(36756003)(31696002)(38100700002)(83380400001)(86362001)(31686004)(54906003)(316002)(41300700001)(8936002)(5660300002)(2906002)(66476007)(8676002)(6916009)(66946007)(66556008)(4326008)(186003)(6506007)(26005)(6486002)(6512007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N25zMTlFQ1d4UGdFMGhSME1aOVpkOUtaV2FYWURDNzFxUmpiNXdPRGlPeUFH?= =?utf-8?B?UnZLdlA5a0JQSmZCY2VCTzJKaHdEZncxdEVtb3lMU1lobk1YY0lxMHZkclhX?= =?utf-8?B?N2dpRlRMMHRwYk5LUUp5Q2RCK1JJTTMxdEp2MDdBWHk0Qm4xNUtlbW8zZnIv?= =?utf-8?B?NVJtYlUvUmwwaThPNlBqUnVNSG1Kd0xhTzFGL2pTSjh2OEZvQlVDWWFFbXVq?= =?utf-8?B?NjlRZ1Flb3JOb3ZBcFY1VzREQVR6UWQ2U0NHQ1hzd2VFWmduRkJoYi9VTkpD?= =?utf-8?B?S1BYaTF4SVl3dUdRRnFHOC9PSmdYS2EwdFZ0RTRsdmVUa0JzTmtDZ1Bzdndn?= =?utf-8?B?d09nU05ERFlTMDl1dDlxWDB4blJJeTZkRk1nOXdIT1dZcE5TK29HSHZzeEtV?= =?utf-8?B?YmRKQlFicXhLcE1ubHE0OXVpOGZnOGx3OVJQUHppbUFIT0ljdFl6V1FnNDc3?= =?utf-8?B?eFRlV3dxODJFd2ZvdXdHT2tZbC9tTkNPS1diSkgyQ2V4dXpTckNlbjlOUWVj?= =?utf-8?B?cWt0L3lmVVV6MTVmNVNhLzRmYkVXZzZGTm5wYlZLUDYxRGlWVHQvZnRpVDNW?= =?utf-8?B?WlpwY0NkK2NJeE04Vlc0bk00d2pYUmZsdnV1ZitpY3o3ZDNFOEFxNzdCbUZt?= =?utf-8?B?Z0tzTzlRZUUyeXBTYlhQOUhBQmo1cndrLzBYeGNGTVpHQXA5cjdtbXZHdXlW?= =?utf-8?B?T0hEdmpxV2l4Q214Z2FkbXZJNDlwbThYR0JYRDE2SEQwTmNsOHN0bDZlWG9Z?= =?utf-8?B?Q2tUK2xUNEhReGw0TXRnRnlWTVhveWVnV2lXOHBnWlphS3VncjBZRlVmL2E1?= =?utf-8?B?UEVpOGlOMndKaTNiZFJabjF2a24yUUUrdW56MTduSUJGSmxHOUg4bXE4ZGtM?= =?utf-8?B?RHlzWGs5aWNPcDFYVFlmRGZlU3BTOTQ0by9GZ0VTZmMvV3k2dWNEdDFyNk1n?= =?utf-8?B?K2lUcTBJQmtkcEkvR285dk9zNDA3K2RzTGVIYlExMzY0TzdkUmc5SU1BNS9v?= =?utf-8?B?WFRZZG11MEdITmpSampKVHFSWGRoOE1oZklET2RLRWo4MmVXM2g2UkNSZWE1?= =?utf-8?B?VWFRc2F4ZUNaY0hQdTk5MW4rZU5TVUloSkpWU3FtTXdrS1NEQkUwZWlIa3hK?= =?utf-8?B?Yi9WalF2c1NnMzN4dU1KcE4vZ1FqWkl0YlMxaytpdzlsb0xNdGZaOGVHU3A3?= =?utf-8?B?VWVhczk4aGwxS0pZUW0rMUhGZTFqcVQvOVhFY3QwdmFocVBVU3ZEL09SWUpZ?= =?utf-8?B?Y2doQnBoTFJSeXBZVVR0dmdvdzRlWnllanhJZ095aSt1K01ScHk2bUlwM2Y4?= =?utf-8?B?N0p3SzlrUzlOSHMwRGJLYU1sUEFBTkVObGJOZWVQODQzRVE2SjlZaWsrNndm?= =?utf-8?B?bk1PYzVTUWRFSklXSUhaNHZrcm4zZmdmRWNtdDNhUlhoVGdVRHlXclV3OFVX?= =?utf-8?B?MHZta1pjTm01bkxpR3ZBYUlEYUF3ZXpvVGJzeWpDK0VlOWgyMS9oNFc4aGNF?= =?utf-8?B?RysvUHZXQzNCQW4vckZFdFZmZ2NmUDVEK2RlN2JkK3lFaFpCOWhHVlEyUm1V?= =?utf-8?B?Nnh2L1R0eDUzOGE3WmNXSzNwZDNjcTVmUVQ0L0NRdUMvTkE2UFh0NWVVTlJI?= =?utf-8?B?WlBmazd6Q1BLZDBjQ0k1enFyeVp1TTd3cVl0cFh2ZXJWZzVlV0ZsRWFDVzV4?= =?utf-8?B?Q1Y0NHhJNThLSVI2bUZLQmJRSFFVY3liZFl1QWQxbS82OXJjTHVUcFcrSFRV?= =?utf-8?B?ajhpcnhnemJwaTNFMjQrNnFHSU1hRDRsS0kzL2pnZ0J5R3BjR2U0bGxQTmg2?= =?utf-8?B?QVJib0c5b29KQkNvbnoxaGsrNmg2U2lpZUF3VktTcVBMVnByc1JTZjBuelh4?= =?utf-8?B?NEM3bEJxTnJ4N0poU1ozQ05ERCtxaXdEYm04QkhnRjNmSU05Y1dIYzFFbXUw?= =?utf-8?B?YTRVKzNaYkMxYkUyaWE2MGU2TjN1aGp6dDhkNU1GajNHQnFuQzRMSWNLWVNS?= =?utf-8?B?RlJCaDUyT2xHUWVwNlc0b2xBQnBZUllLaHZSbTNaRFA1Sk9VYWRZNzNsY3pL?= =?utf-8?B?K2o0dG1SNmpRVGNYcVdDMDdieWMweVRnRmIrZ3IwdjdKcGNOZHk4WmpldlNw?= =?utf-8?Q?e0liiFR4yYqe/2qHkychdhHfa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 658d4215-c68b-44f7-b46a-08db0f4877d6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:33:32.6928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O+37LuIkflROcOt7nzssRe2cKnyEC4QEYaj0NRWnyUiv0QTa6xkAVXJi5fXWTLJfvPhGz5FolHwrBUnrT/6kuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7523 First of all drop 32-bit leftovers, including the inclusion of the file from head_32.S. Then further move PV-only ELF notes inside the XEN_PV conditional. Finally have the "supported features" note actually report reality: All three of the features are supported and/or applicable only in certain cases. Signed-off-by: Jan Beulich --- a/arch/x86/kernel/head_32.S +++ b/arch/x86/kernel/head_32.S @@ -524,8 +524,6 @@ __INITRODATA int_msg: .asciz "Unknown interrupt or fault at: %p %p %p\n" -#include "../../x86/xen/xen-head.S" - /* * The IDT and GDT 'descriptors' are a strange 48-bit object * only used by the lidt and lgdt instructions. They are not --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -83,27 +83,33 @@ SYM_CODE_END(asm_cpu_bringup_and_idle) ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS, .asciz "linux") ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION, .asciz "2.6") ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION, .asciz "xen-3.0") -#ifdef CONFIG_X86_32 - ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE, _ASM_PTR __PAGE_OFFSET) -#else ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE, _ASM_PTR __START_KERNEL_map) /* Map the p2m table to a 512GB-aligned user address. */ ELFNOTE(Xen, XEN_ELFNOTE_INIT_P2M, .quad (PUD_SIZE * PTRS_PER_PUD)) -#endif #ifdef CONFIG_XEN_PV ELFNOTE(Xen, XEN_ELFNOTE_ENTRY, _ASM_PTR startup_xen) + ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, .ascii "!writable_page_tables") + ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE, .asciz "yes") + ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, + .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) +# define FEATURES_PV (1 << XENFEAT_writable_page_tables) +#else +# define FEATURES_PV 0 +#endif +#ifdef CONFIG_XEN_PVH +# define FEATURES_PVH (1 << XENFEAT_linux_rsdp_unrestricted) +#else +# define FEATURES_PVH 0 +#endif +#ifdef CONFIG_XEN_DOM0 +# define FEATURES_DOM0 (1 << XENFEAT_dom0) +#else +# define FEATURES_DOM0 0 #endif ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR hypercall_page) - ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, - .ascii "!writable_page_tables|pae_pgdir_above_4gb") ELFNOTE(Xen, XEN_ELFNOTE_SUPPORTED_FEATURES, - .long (1 << XENFEAT_writable_page_tables) | \ - (1 << XENFEAT_dom0) | \ - (1 << XENFEAT_linux_rsdp_unrestricted)) - ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE, .asciz "yes") + .long FEATURES_PV | FEATURES_PVH | FEATURES_DOM0) ELFNOTE(Xen, XEN_ELFNOTE_LOADER, .asciz "generic") - ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, - .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1) ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN, .long 1) ELFNOTE(Xen, XEN_ELFNOTE_HV_START_LOW, _ASM_PTR __HYPERVISOR_VIRT_START) From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:02:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:02:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495903.766342 (Exim 4.92) (envelope-from ) id 1pSGUV-0003Ba-1c; Wed, 15 Feb 2023 12:02:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495903.766342; Wed, 15 Feb 2023 12:02:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUU-0003BT-Ue; Wed, 15 Feb 2023 12:02:26 +0000 Received: by outflank-mailman (input) for mailman id 495903; Wed, 15 Feb 2023 12:02:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUU-0002tE-0e for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:02:26 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97f057e2-ad28-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 13:02:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97f057e2-ad28-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676462540; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=MVgVSQoqoX6b1cwtMgdJCX74cqDIUgNuwrGwqbwsx9c=; b=CLwry3HxeXdRxXQZmiNn2q1bbSGI7YhMF9XgniiPpq9ybSJYIES/9D1h V13c+qleQ45uMzDv9xLtyBn0i/C5U48a0Md/uGC5uSuII6MCr2w0qSkmb CPwoQ6OrYrPYCnri1rIPCrW/OCGNItPq28RWLo6XVZEHywUYwFG46UEKM o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97048389 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ifiYd6LPPL29zLAdFE+R/pUlxSXFcZb7ZxGr2PjKsXjdYENS0DwAx 2sZUW+OOvvcZjakcoglPYvgph9V7J7Xz9IwQAJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVjPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5QLUxDq ewoJAoCSU++vM2J5+7rWs9V05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbGp0Jzh3I9 woq+UylIR8nF9+d7QaL92yWgcvEpB3mUaI7QejQGvlC3wTImz175ActfVCyu/W+h2a1UshTL EFS8S0rxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fHEjKw+0gL/QuxsN/GItfLKPm2g0 xaz+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJ1sldzBO hW7VeZtCHl7ZiPCgUhfPeqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/5hY sbKL5z9VyZAYUiC8NZQb71FuVPM7npjrV4/uLihl0j3uVZgTCD9pUg53KumMblisfLsTPT9+ NdDLcqaoyizo8WnChQ7BbU7dAhQRVBiXMCeliCiXrLbSuaQMD17WqC5LHJIU9ANopm5Yc+Up i7nABUClQGn7ZAFQC3TAk1ehHrUdc4XhRoG0eYEZz5EB1BLjV6T0Zoi IronPort-HdrOrdr: A9a23:+vVrA6OoKs5kC8BcTv2jsMiBIKoaSvp037BL7SxMoHluGaalfq +V7ZcmPGDP+U4ssR0b+OxoQZPwJ080lqQb3WByB8bBYOC8ghrNEGgK1+KLrgEIfReOk9K1vZ 0QFJSWY+efMbEVt6bHCFvSKadY/OW6 X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97048389" From: Anthony PERARD To: CC: Anthony PERARD , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 0/4] automation: Update containers to allow HTTPS access to xenbits Date: Wed, 15 Feb 2023 12:02:04 +0000 Message-ID: <20230215120208.35807-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v1 There is work in progress [1] to update urls in our repo to use https, but those https urls to xenbits don't work in our containers, due to an expired root certificate. So we need to update those containers. This series update the dockerfile where just rebuilding the container isn't enough. I've tested the new containers but didn't updated them yet. You can see the result in the following links (if you can access them). There are other containers been test which didn't need dockerfile update. https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/777474218 https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/778218868 Building randconfig on debian unstable seems to be an issue. [1] https://lore.kernel.org/xen-devel/75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com/ Cheers, Anthony PERARD (4): automation: Remove clang-8 from Debian unstable container automation: Ignore package authentification issue in Jessie container automation: Remove expired root certificates used to be used by let's encrypt automation: Add more aliases in containerize automation/build/centos/7.2.dockerfile | 5 +++++ automation/build/centos/7.dockerfile | 5 +++++ automation/build/debian/jessie-i386.dockerfile | 7 +++++++ automation/build/debian/jessie.dockerfile | 7 +++++++ automation/build/debian/unstable-llvm-8.list | 3 --- automation/build/debian/unstable.dockerfile | 12 ------------ automation/build/ubuntu/trusty.dockerfile | 5 +++++ automation/gitlab-ci/build.yaml | 10 ---------- automation/scripts/containerize | 3 +++ 9 files changed, 32 insertions(+), 25 deletions(-) delete mode 100644 automation/build/debian/unstable-llvm-8.list -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:02:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:02:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495902.766331 (Exim 4.92) (envelope-from ) id 1pSGUR-0002vh-Qd; Wed, 15 Feb 2023 12:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495902.766331; Wed, 15 Feb 2023 12:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUR-0002va-Mc; Wed, 15 Feb 2023 12:02:23 +0000 Received: by outflank-mailman (input) for mailman id 495902; Wed, 15 Feb 2023 12:02:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUQ-0002d9-L5 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:02:22 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98d2f2df-ad28-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:02:21 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98d2f2df-ad28-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676462540; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/vUeHriTwM3BI+2QtwE/fpQP34e1Nzdh1FIIl05etc8=; b=J4IDjLsUke/lWqjB3gfIFnP8o92FRD50FNO97HFmN/0XLe0QOfwr+Dbw 6heBDkwOFpmAhgQU70SIN8s27TCvwcIHA2V30ENXark2Z1zlEJkQQcFkh V5749cSss9cu1Dmm+odtLEV6rtHr8QZ6YB7GqIgY4hc+klFcfY8mV19NO M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97137984 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:7YfmxaxGpqvggbq2ozh6t+cZxirEfRIJ4+MujC+fZmUNrF6WrkUEx zYeDz2APv+KNGL8f9lyaYq+oB5SvJOHmNdjGwdtqiAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPK0T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KU1nr dFbEW4SVE+G2t+Sn5GDb/lcuf12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQKxx3H9 zKal4j/KkAWKoaW5jOlzkit2s7KrwzJeoAZToTto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYXUsBcFOAS4wiXxq3ZpQ2eAwAsVSVdYdYrsMs3Qz0C1 VKTmd7tQzt1v9WopWm1r+nO62noYG5McDFEPHVfJecY3zX9iK0a1j+Md4h8KvGw0+DRRhLI5 iC6kxFr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eIlcFg 2eJ42u9AaO/2lPwNcebhKrvY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ snAIJfyVydAWf4PIN+KqwE1i+dDKscWnz67eHwG507/jer2iIC9F9/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnC/zGLnFnhTdSJTLcmv+6RqmhurflIO9JcJV6WAntvMuuVNw8xoqws/1 i3lBRUCkgCi3iWvxMfjQikLVY4DlK1X9RoTVRHA937xgBDPva7HAH8jSqYK IronPort-HdrOrdr: A9a23:waCHuqMuh0iMt8BcTv2jsMiBIKoaSvp037BL7SxMoHluGaalfq +V7ZcmPGDP+U4ssR0b+OxoQZPwJ080lqQb3WByB8bBYOC8ghrNEGgK1+KLrgEIfReOk9K1vZ 0QFJSWY+efMbEVt6bHCFvSKadY/OW6 X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97137984" From: Anthony PERARD To: CC: Anthony PERARD , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container Date: Wed, 15 Feb 2023 12:02:05 +0000 Message-ID: <20230215120208.35807-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230215120208.35807-1-anthony.perard@citrix.com> References: <20230215120208.35807-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD --- Current container have: root@f3d1fc4f58c7:/build# clang --version clang version 8.0.1- (branches/release_80) root@113cb5730b2a:/build# clang-8 --version clang version 8.0.1- (branches/release_80) (built about 3years ago) --- automation/build/debian/unstable-llvm-8.list | 3 --- automation/build/debian/unstable.dockerfile | 12 ------------ automation/gitlab-ci/build.yaml | 10 ---------- 3 files changed, 25 deletions(-) delete mode 100644 automation/build/debian/unstable-llvm-8.list diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list deleted file mode 100644 index dc119fa0b4..0000000000 --- a/automation/build/debian/unstable-llvm-8.list +++ /dev/null @@ -1,3 +0,0 @@ -# Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/build/debian/unstable.dockerfile b/automation/build/debian/unstable.dockerfile index 9de766d596..b560337b7a 100644 --- a/automation/build/debian/unstable.dockerfile +++ b/automation/build/debian/unstable.dockerfile @@ -51,15 +51,3 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* - -RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|apt-key add - -COPY unstable-llvm-8.list /etc/apt/sources.list.d/ - -RUN apt-get update && \ - apt-get --quiet --yes install \ - clang-8 \ - lld-8 \ - && \ - apt-get autoremove -y && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c732..7d8af93653 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -339,16 +339,6 @@ debian-unstable-clang-debug: variables: CONTAINER: debian:unstable -debian-unstable-clang-8: - extends: .clang-8-x86-64-build - variables: - CONTAINER: debian:unstable - -debian-unstable-clang-8-debug: - extends: .clang-8-x86-64-build-debug - variables: - CONTAINER: debian:unstable - debian-unstable-gcc: extends: .gcc-x86-64-build variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:06:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495915.766352 (Exim 4.92) (envelope-from ) id 1pSGXw-0004Eq-Go; Wed, 15 Feb 2023 12:06:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495915.766352; Wed, 15 Feb 2023 12:06:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGXw-0004Ej-Dc; Wed, 15 Feb 2023 12:06:00 +0000 Received: by outflank-mailman (input) for mailman id 495915; Wed, 15 Feb 2023 12:05:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGXu-0004EW-IH for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:05:58 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a25c237-ad29-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 13:05:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF0B8207CB; Wed, 15 Feb 2023 12:05:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A362513483; Wed, 15 Feb 2023 12:05:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WsZ1JqPK7GMzQAAAMHmgww (envelope-from ); Wed, 15 Feb 2023 12:05:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a25c237-ad29-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676462755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s+PkheF8hQEAxpcHBI1ZjXUyvfAs5BV4HCkW3WFbchw=; b=fROjidXyVIz3tNvMQrJJtfPssV0ZyIcC8JlY4BoGSpiHtqTI6C+jXxFJJaH7pgEwvXkcgE YMrY4pL2tTHy4z3zvq7rwTOmmIhuSyxabFfvs123GIL7HeOdFIxoTto1X4TvSNCpJeyLPv m6H1Cob9fC4Zt9p13CpLMxgC7AnDzFE= Message-ID: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> Date: Wed, 15 Feb 2023 13:05:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: From: Juergen Gross Subject: Re: [PATCH] x86/Xen: tidy xen-head.S In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------A6ze7oXFmJ8UvlBIzAo2fkuT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------A6ze7oXFmJ8UvlBIzAo2fkuT Content-Type: multipart/mixed; boundary="------------UNETlYYd9cw7AK9x3o0HrBD0"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Message-ID: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> Subject: Re: [PATCH] x86/Xen: tidy xen-head.S References: In-Reply-To: --------------UNETlYYd9cw7AK9x3o0HrBD0 Content-Type: multipart/mixed; boundary="------------0Ad47DS10VbCi1CsS7DNCHik" --------------0Ad47DS10VbCi1CsS7DNCHik Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDIuMjMgMTI6MzMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBGaXJzdCBvZiBhbGwg ZHJvcCAzMi1iaXQgbGVmdG92ZXJzLCBpbmNsdWRpbmcgdGhlIGluY2x1c2lvbiBvZiB0aGUg ZmlsZQ0KPiBmcm9tIGhlYWRfMzIuUy4NCg0KSSBkb24ndCBzZWUgd2h5IHdlIHdvdWxkIHdh bnQgdG8gZHJvcCAzMi1iaXQgSFZNIGFuZCBQVkggc3VwcG9ydC4NCg0KPiBUaGVuIGZ1cnRo ZXIgbW92ZSBQVi1vbmx5IEVMRiBub3RlcyBpbnNpZGUgdGhlIFhFTl9QVg0KPiBjb25kaXRp b25hbC4gRmluYWxseSBoYXZlIHRoZSAic3VwcG9ydGVkIGZlYXR1cmVzIiBub3RlIGFjdHVh bGx5IHJlcG9ydA0KPiByZWFsaXR5OiBBbGwgdGhyZWUgb2YgdGhlIGZlYXR1cmVzIGFyZSBz dXBwb3J0ZWQgYW5kL29yIGFwcGxpY2FibGUgb25seQ0KPiBpbiBjZXJ0YWluIGNhc2VzLg0K PiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0K PiANCj4gLS0tIGEvYXJjaC94ODYva2VybmVsL2hlYWRfMzIuUw0KPiArKysgYi9hcmNoL3g4 Ni9rZXJuZWwvaGVhZF8zMi5TDQo+IEBAIC01MjQsOCArNTI0LDYgQEAgX19JTklUUk9EQVRB DQo+ICAgaW50X21zZzoNCj4gICAJLmFzY2l6ICJVbmtub3duIGludGVycnVwdCBvciBmYXVs dCBhdDogJXAgJXAgJXBcbiINCj4gICANCj4gLSNpbmNsdWRlICIuLi8uLi94ODYveGVuL3hl bi1oZWFkLlMiDQo+IC0NCg0KVGhpcyBpcyB3cm9uZyBmb3Igbm9uLVBWIGNhc2VzLg0KDQo+ ICAgLyoNCj4gICAgKiBUaGUgSURUIGFuZCBHRFQgJ2Rlc2NyaXB0b3JzJyBhcmUgYSBzdHJh bmdlIDQ4LWJpdCBvYmplY3QNCj4gICAgKiBvbmx5IHVzZWQgYnkgdGhlIGxpZHQgYW5kIGxn ZHQgaW5zdHJ1Y3Rpb25zLiBUaGV5IGFyZSBub3QNCj4gLS0tIGEvYXJjaC94ODYveGVuL3hl bi1oZWFkLlMNCj4gKysrIGIvYXJjaC94ODYveGVuL3hlbi1oZWFkLlMNCj4gQEAgLTgzLDI3 ICs4MywzMyBAQCBTWU1fQ09ERV9FTkQoYXNtX2NwdV9icmluZ3VwX2FuZF9pZGxlKQ0KPiAg IAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfR1VFU1RfT1MsICAgICAgIC5hc2NpeiAibGlu dXgiKQ0KPiAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfR1VFU1RfVkVSU0lPTiwgIC5h c2NpeiAiMi42IikNCj4gICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX1hFTl9WRVJTSU9O LCAgICAuYXNjaXogInhlbi0zLjAiKQ0KPiAtI2lmZGVmIENPTkZJR19YODZfMzINCj4gLQlF TEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfVklSVF9CQVNFLCAgICAgIF9BU01fUFRSIF9fUEFH RV9PRkZTRVQpDQo+IC0jZWxzZQ0KPiAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfVklS VF9CQVNFLCAgICAgIF9BU01fUFRSIF9fU1RBUlRfS0VSTkVMX21hcCkNCg0KVGhpcyB3aWxs IGJlIHdyb25nIGZvciAzMi1iaXQgZ3Vlc3RzIG5vdy4gSSdtIG5vdCBzdXJlIHRoZSB2YWx1 ZSBpcyByZWFsbHkNCnVzZWQgaW4gWGVuIGZvciBub24tUFYgZ3Vlc3RzLCB0aG91Z2guDQoN Cj4gICAJLyogTWFwIHRoZSBwMm0gdGFibGUgdG8gYSA1MTJHQi1hbGlnbmVkIHVzZXIgYWRk cmVzcy4gKi8NCj4gICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0lOSVRfUDJNLCAgICAg ICAucXVhZCAoUFVEX1NJWkUgKiBQVFJTX1BFUl9QVUQpKQ0KDQpNb3ZlIHRoaXMgdW5kZXIg dGhlIENPTkZJR19QViB1bWJyZWxsYT8NCg0KPiAtI2VuZGlmDQo+ICAgI2lmZGVmIENPTkZJ R19YRU5fUFYNCj4gICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0VOVFJZLCAgICAgICAg ICBfQVNNX1BUUiBzdGFydHVwX3hlbikNCj4gKwlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVf RkVBVFVSRVMsICAgICAgIC5hc2NpaSAiIXdyaXRhYmxlX3BhZ2VfdGFibGVzIikNCj4gKwlF TEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfUEFFX01PREUsICAgICAgIC5hc2NpeiAieWVzIikN Cj4gKwlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfTDFfTUZOX1ZBTElELA0KPiArCQkucXVh ZCBfUEFHRV9QUkVTRU5UOyAucXVhZCBfUEFHRV9QUkVTRU5UKQ0KPiArIyBkZWZpbmUgRkVB VFVSRVNfUFYgKDEgPDwgWEVORkVBVF93cml0YWJsZV9wYWdlX3RhYmxlcykNCj4gKyNlbHNl DQo+ICsjIGRlZmluZSBGRUFUVVJFU19QViAwDQo+ICsjZW5kaWYNCj4gKyNpZmRlZiBDT05G SUdfWEVOX1BWSA0KPiArIyBkZWZpbmUgRkVBVFVSRVNfUFZIICgxIDw8IFhFTkZFQVRfbGlu dXhfcnNkcF91bnJlc3RyaWN0ZWQpDQo+ICsjZWxzZQ0KPiArIyBkZWZpbmUgRkVBVFVSRVNf UFZIIDANCj4gKyNlbmRpZg0KPiArI2lmZGVmIENPTkZJR19YRU5fRE9NMA0KPiArIyBkZWZp bmUgRkVBVFVSRVNfRE9NMCAoMSA8PCBYRU5GRUFUX2RvbTApDQo+ICsjZWxzZQ0KPiArIyBk ZWZpbmUgRkVBVFVSRVNfRE9NMCAwDQo+ICAgI2VuZGlmDQo+ICAgCUVMRk5PVEUoWGVuLCBY RU5fRUxGTk9URV9IWVBFUkNBTExfUEFHRSwgX0FTTV9QVFIgaHlwZXJjYWxsX3BhZ2UpDQo+ IC0JRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0ZFQVRVUkVTLA0KPiAtCQkuYXNjaWkgIiF3 cml0YWJsZV9wYWdlX3RhYmxlc3xwYWVfcGdkaXJfYWJvdmVfNGdiIikNCj4gICAJRUxGTk9U RShYZW4sIFhFTl9FTEZOT1RFX1NVUFBPUlRFRF9GRUFUVVJFUywNCj4gLQkJLmxvbmcgKDEg PDwgWEVORkVBVF93cml0YWJsZV9wYWdlX3RhYmxlcykgfCAgICAgICBcDQo+IC0JCSAgICAg ICgxIDw8IFhFTkZFQVRfZG9tMCkgfCAgICAgICAgICAgICAgICAgICAgICAgXA0KPiAtCQkg ICAgICAoMSA8PCBYRU5GRUFUX2xpbnV4X3JzZHBfdW5yZXN0cmljdGVkKSkNCj4gLQlFTEZO T1RFKFhlbiwgWEVOX0VMRk5PVEVfUEFFX01PREUsICAgICAgIC5hc2NpeiAieWVzIikNCj4g KwkJLmxvbmcgRkVBVFVSRVNfUFYgfCBGRUFUVVJFU19QVkggfCBGRUFUVVJFU19ET00wKQ0K PiAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfTE9BREVSLCAgICAgICAgIC5hc2NpeiAi Z2VuZXJpYyIpDQo+IC0JRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0wxX01GTl9WQUxJRCwN Cj4gLQkJLnF1YWQgX1BBR0VfUFJFU0VOVDsgLnF1YWQgX1BBR0VfUFJFU0VOVCkNCj4gICAJ RUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX1NVU1BFTkRfQ0FOQ0VMLCAubG9uZyAxKQ0KPiAg IAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfTU9EX1NUQVJUX1BGTiwgIC5sb25nIDEpDQo+ ICAgCUVMRk5PVEUoWGVuLCBYRU5fRUxGTk9URV9IVl9TVEFSVF9MT1csICAgX0FTTV9QVFIg X19IWVBFUlZJU09SX1ZJUlRfU1RBUlQpDQoNCkFyZSBYRU5fRUxGTk9URV9NT0RfU1RBUlRf UEZOIGFuZCBYRU5fRUxGTk9URV9IVl9TVEFSVF9MT1cgcmVhbGx5IHJlbGV2YW50DQpmb3Ig dGhlIG5vbi1QViBjYXNlPyBJIGRvbid0IHRoaW5rIHNvIChpbiB0aGVvcnkgWEVOX0VMRk5P VEVfTU9EX1NUQVJUX1BGTg0KY291bGQgYmUgdXNlZCwgYnV0IHRoZSBtYWluIHJlYXNvbiBm b3IgaXRzIGludHJvZHVjdGlvbiB3YXMgUFYgZ3Vlc3RzIElJUkMpLg0KDQoNCkp1ZXJnZW4N Cg== --------------0Ad47DS10VbCi1CsS7DNCHik Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0Ad47DS10VbCi1CsS7DNCHik-- --------------UNETlYYd9cw7AK9x3o0HrBD0-- --------------A6ze7oXFmJ8UvlBIzAo2fkuT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPsyqMFAwAAAAAACgkQsN6d1ii/Ey/U 9ggAhYhEYbe1ICb1vnHfSL7mmdxhra/LZk1kUGcu8FCX7pf2SI6G4jUASsrG8GeoMfkaV2D/aLEs cU3vCC8L2tLN8ousZANidrjBah1sCwRdTe9AG8zv/bvSKZAnSaPIjnDb3nJAsfYxtHO1Kpc7K7HL 5S79TnvSCsaNaEb33W7SpVl4ikvEkA2r4jrxAzD1+C1eFE7vK4PwEYgl27Fb3lg21nP8jI2R9TXP Of6mCITbZmthRd7Rz8nUDyLqZF5UdlqQnf/JISDPzVYJp9CTm9Ctxu26PTvA4sDXoPmmmvkqR69m d+1ercmAOxP8ldACX3qseEFIp+QOfc7lUtYWciqZEQ== =/EaQ -----END PGP SIGNATURE----- --------------A6ze7oXFmJ8UvlBIzAo2fkuT-- From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:09:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495923.766369 (Exim 4.92) (envelope-from ) id 1pSGay-00056f-BF; Wed, 15 Feb 2023 12:09:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495923.766369; Wed, 15 Feb 2023 12:09:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGay-00055O-7Y; Wed, 15 Feb 2023 12:09:08 +0000 Received: by outflank-mailman (input) for mailman id 495923; Wed, 15 Feb 2023 12:09:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUd-0002d9-9T for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:02:35 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0da02ae-ad28-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:02:34 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0da02ae-ad28-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676462554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CDemkNMh65A0fuGjtYCs3q9uOqRjiot5Fwy4om7WfvI=; b=KbDbqfcLbCIubuR4r090CwnJENhilAihYhhFfcWR504AsEAFtQSvMdHd HlHT9xCsYOTkfteei91/UwBJ2/zV/Vvby1bVG1OMVv/8ObfvfhHVDpGue Eko+24uTh3HshdDqbHzRND2K0mWEr4NSeYGFnIfs8UEyub5WTSj7YwvgM Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95971160 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:Tz0wxKKqjeiC0VDzFE+R/pUlxSXFcZb7ZxGr2PjKsXjdYENSgWYOm mVNWGDUOfbZNmfzfItxPI2z8hsE68TQztdmGQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVjPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4mRjBS6 sY4OQwoQQKTi6WymK+Va8ZF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbGJQKxx/G/ goq+UzDRSxAK/yQ2wGG+1+1vvTugSXKY8UdQejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxastRcGV91dO+Yz8g2Kx+zf5APxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fGy59AvkSjvX+pGP7ylgprxQSze4 h+j+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJ1sldzBO hW7VeZtCHl7ZiPCgUhfPeqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/5hY sbKL5z9VyZAYUiC8NZQb71FuVPM7npjrV4/uLihl0j3uVZgTCD9pUg53KumMblisfLsTPT9+ NdDLcqaoyizo8WnChQ7BbU7dAhQRVBiXMCeliCiXrLbSuaQMD17WqC5LHJIU9ANopm5Yc+Up i7nABUClQGn7ZAFQC3TAk1ehHrUdc4XhRoG0eYEZD5EB1BLjV6T0Zoi IronPort-HdrOrdr: A9a23:mOtPrK41eFY8iWwL7QPXwbOBI+orL9Y04lQ7vn2ZhyYlFvBw9v re6MjzsCWe5gr5N0tBpTn+Atj+fZqxz/9ICOoqTMWftXfdyQmVxehZhOOJ/9SKIVycygcy79 YET0B0YOeAc2ST5azBjDVReLwbr+VuP8qT6Nv2/jNVaUVPVokl1gF+D2+gYzhLrMstP+tJKH JZjPA31AZJvB4sH7SG7wI+Lo/+juyOrovifRkFQzY/8WC1/EuVwY+/KQGcwhAdFxhSwbIumF K17zDR1+GYqvSmzR2Z8GfW4/1t6b3c4+oGPtWIls8WbhPzjQqyDb4RIoGqjXQOueSy71Rvqv ngyi1QRPhb2jfqZ2Sophmo4QX6zzo0zHfnxTaj8AHeiP28fis+F81Cwb1UaQHY7U1IhqAA7J 52 X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="95971160" From: Anthony PERARD To: CC: Anthony PERARD , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 4/4] automation: Add more aliases in containerize Date: Wed, 15 Feb 2023 12:02:08 +0000 Message-ID: <20230215120208.35807-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230215120208.35807-1-anthony.perard@citrix.com> References: <20230215120208.35807-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9e508918bf..9b1a302d05 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -33,9 +33,12 @@ case "_${CONTAINER}" in _fedora) CONTAINER="${BASE}/fedora:29";; _focal) CONTAINER="${BASE}/ubuntu:focal" ;; _jessie) CONTAINER="${BASE}/debian:jessie" ;; + _jessie-i386) CONTAINER="${BASE}/debian:jessie-i386" ;; _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; + _stretch-i386) CONTAINER="${BASE}/debian:stretch-i386" ;; _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; + _unstable-i386) CONTAINER="${BASE}/debian:unstable-i386" ;; _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:09:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:09:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495922.766363 (Exim 4.92) (envelope-from ) id 1pSGax-000515-UK; Wed, 15 Feb 2023 12:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495922.766363; Wed, 15 Feb 2023 12:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGax-00050y-RQ; Wed, 15 Feb 2023 12:09:07 +0000 Received: by outflank-mailman (input) for mailman id 495922; Wed, 15 Feb 2023 12:09:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUg-0002d9-A9 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:02:38 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a27f1be6-ad28-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:02:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a27f1be6-ad28-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676462556; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IenDCD+TXqlMxzZ7mL5x9hvul10g7klkJWhyIR23RNo=; b=ZUS98OAzysmPlnhokVDH4/ZqvkY8RctRZly72nr5kox8EsECo/Teglns T8nl+ezd5s9Y+4/hD4LJETlof5tyepqqvYjHM17+o2RPYZAGaJpPK6pxE 42h9ddl1lrSvqlAameFrw1VxztMhzhawi8hIfa3k0mSjOYsp5eH0VRrbL I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 99550725 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:CmlkTKmkNiXIi6jGITPgWGPo5gyuJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIYDzqBafjfNzfxe9F1YdvnpE4Ov5PSm9BnTQpq/CkwHyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QKGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 e48OW8OakG8vcCV8uykVORog/QcffC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfJ+ z+eoD6kav0cHMyz9DmGw1H2vc6MnA/FSo0UEpCS+dc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JbGvc27wylwaPO7wGUQGMDS1Zpc8c6vcU7QTgr0 F6hnN7zAzFr9rqPRhqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tpgDrX4lgFP+KtP/WK2/v3 T2OqRgB1oxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezO yc/WisLvve/2UdGi4ctO+pd7Ox0pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FLpj3XCdEU/U9nGDeqwIhPVkDnHhWKYT7H82T8vha+eDGOC79pUktbjNikdzVHIvb+V6Io r6zxuOByglFUf2WX8Uk2dd7ELz+FlBiXcqeg5UOJoa+zv9ORDlJ5wn5nelwJOSIXs19yo/1w 51KchMAlwCl3yeacl3ih7IKQOqHYKuTZEkTZUQEVWtEEVB8CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:it5cVaugjlEjrtnGAkHrLI4m7skDSdV00zEX/kB9WHVpmwKj5r mTdZUgpGfJYVMqMk3I9urwXZVoLUmsl6KdpLNhXotKPzOGhILLFvAH0WKK+VSJcBEWtNQ86U 4KSdkYNDSfNykdsS842mWF+hQbreVvPJrGuQ4W9RlQcT0= X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99550725" From: Anthony PERARD To: CC: Anthony PERARD , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 2/4] automation: Ignore package authentification issue in Jessie container Date: Wed, 15 Feb 2023 12:02:06 +0000 Message-ID: <20230215120208.35807-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230215120208.35807-1-anthony.perard@citrix.com> References: <20230215120208.35807-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain We can't easily install package on Debian Jessie anymore, the release keys seems to have expired without a way to get new ones. We have these warning: W: GPG error: http://deb.debian.org jessie-updates InRelease: The following signatures were invalid: KEYEXPIRED 1668891673 W: GPG error: http://deb.debian.org jessie Release: The following signatures were invalid: KEYEXPIRED 1668891673 So, from now on, ignore the warning and force the installation of packages that can't be authenticated. Signed-off-by: Anthony PERARD --- Or, we could just not test on Jessie anymore. --- automation/build/debian/jessie-i386.dockerfile | 2 ++ automation/build/debian/jessie.dockerfile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index 3f86d91f63..c617b6fbfb 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -13,6 +13,8 @@ ENTRYPOINT ["linux32"] # build depends RUN apt-get update && \ apt-get --quiet --yes install \ + # WARNING! Force installation to ignore expired release key + --force-yes \ build-essential \ zlib1g-dev \ libncurses5-dev \ diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 2f19adcad3..8918b26d75 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -11,6 +11,8 @@ WORKDIR /build # build depends RUN apt-get update && \ apt-get --quiet --yes install \ + # WARNING! Force installation to ignore expired release key + --force-yes \ build-essential \ zlib1g-dev \ libncurses5-dev \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:09:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495925.766386 (Exim 4.92) (envelope-from ) id 1pSGb4-0005gO-L7; Wed, 15 Feb 2023 12:09:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495925.766386; Wed, 15 Feb 2023 12:09:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGb4-0005gG-HT; Wed, 15 Feb 2023 12:09:14 +0000 Received: by outflank-mailman (input) for mailman id 495925; Wed, 15 Feb 2023 12:09:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGUh-0002d9-F0 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:02:39 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a42d2439-ad28-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:02:38 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a42d2439-ad28-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676462558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9wHKZykfWSUq/3k4JKcCvIqxoN2TE4/5/U+7meTLwCo=; b=D2Ear6LoM6CSGkmM0X13I28VizObGgCincD71eZTYGlXU+pmCGw6MVZX 4nqK+d+l235PSVL67NmTFPMyFsmTTc6tD9trBZRDNO/ISrNSd+XGq3gXX sYGwhiSgX0w48Mi5qgHq3RlDz/TMI9s0Z/9ar0/iyKPf7IChM7RxlJbhm 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 99550726 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:VNORwa6eaakAH5J93igsWwxRtBfHchMFZxGqfqrLsTDasY5as4F+v jBOXDqGPauINmTxKNlzPoi0pxwPsZ7QyYU1SgFl/HphHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 9gJdzMJPy+5pcGEnq2lR+1ptvtyFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxfF+ zqZpTqR7hcyEf+E4xyM6nWQpebNuXn6QYQwD7m936s/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9FZCeE95SmGw7DY5AvfDW8BJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bnDbeEdVnQZGPrP7HRy7uz jSPnBdvvuBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWWyC KMwkVkLjHO2AJdMRfUvC25WI5pC8EQYPY65Ps04l/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY MnEL539XChAWP43llJaotvxN5dxnkjSIkuJGPjGI+mPi+LCNBZ5t59bWLdxUgzJxPzd+1iEm zquH8CL1w9eQIXDjtr/qOYuwaQxBSFjX/je8pUHHtNv1yI6QAnN/deNm+J+E2Gk9owJ/tr1E oaVBhcHkgCl3yCccW1nqBlLMdvSYHq2llpjVQREALpi8ydLjVqHhEvHS6YKQA== IronPort-HdrOrdr: A9a23:p1uNsq+0eO/YHcYejrxuk+DnI+orL9Y04lQ7vn2ZhyYlC/Bw9v re5MjzsCWftN9/YgBEpTntAtjjfZqYz+8X3WBzB9aftWvdyQ+VxehZhOOI/9SjIU3DH4VmpM BdmsZFebvN5JtB4foSIjPULz/t+ra6GWmT69vj8w== X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99550726" From: Anthony PERARD To: CC: Anthony PERARD , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt Date: Wed, 15 Feb 2023 12:02:07 +0000 Message-ID: <20230215120208.35807-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230215120208.35807-1-anthony.perard@citrix.com> References: <20230215120208.35807-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain While the Let's Encrypt root certificate ISRG_Root_X1.crt is already present, openssl seems to still check for the root certificate DST_Root_CA_X3.crt which has expired. This prevent https connections. Removing DST_Root_CA_X3 fix the issue. centos: found the filter by looking for "DST Root" in `trust list`. Signed-off-by: Anthony PERARD --- automation/build/centos/7.2.dockerfile | 5 +++++ automation/build/centos/7.dockerfile | 5 +++++ automation/build/debian/jessie-i386.dockerfile | 5 +++++ automation/build/debian/jessie.dockerfile | 5 +++++ automation/build/ubuntu/trusty.dockerfile | 5 +++++ 5 files changed, 25 insertions(+) diff --git a/automation/build/centos/7.2.dockerfile b/automation/build/centos/7.2.dockerfile index 4baa097e31..27244fd002 100644 --- a/automation/build/centos/7.2.dockerfile +++ b/automation/build/centos/7.2.dockerfile @@ -50,3 +50,8 @@ RUN rpm --rebuilddb && \ bzip2 \ nasm \ && yum clean all + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN trust extract --filter=pkcs11:id=%c4%a7%b1%a4%7b%2c%71%fa%db%e1%4b%90%75%ff%c4%15%60%85%89%10\;type=cert --format=pem-bundle /etc/pki/ca-trust/source/blacklist/DST_Root_CA_X3.pem && \ + update-ca-trust diff --git a/automation/build/centos/7.dockerfile b/automation/build/centos/7.dockerfile index e688a4cece..b370068e3c 100644 --- a/automation/build/centos/7.dockerfile +++ b/automation/build/centos/7.dockerfile @@ -49,3 +49,8 @@ RUN yum -y install \ nasm \ && yum clean all && \ rm -rf /var/cache/yum + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN trust extract --filter=pkcs11:id=%c4%a7%b1%a4%7b%2c%71%fa%db%e1%4b%90%75%ff%c4%15%60%85%89%10\;type=cert --format=pem-bundle /etc/pki/ca-trust/source/blacklist/DST_Root_CA_X3.pem && \ + update-ca-trust diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index c617b6fbfb..84135230d0 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -51,3 +51,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i '/mozilla\/DST_Root_CA_X3\.crt/d' /etc/ca-certificates.conf && \ + update-ca-certificates diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 8918b26d75..d11dd48e17 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -50,3 +50,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i '/mozilla\/DST_Root_CA_X3\.crt/d' /etc/ca-certificates.conf && \ + update-ca-certificates diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile index b4b2f85e73..16d08ca931 100644 --- a/automation/build/ubuntu/trusty.dockerfile +++ b/automation/build/ubuntu/trusty.dockerfile @@ -49,3 +49,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i 's#mozilla/DST_Root_CA_X3\.crt#!\0#' /etc/ca-certificates.conf && \ + update-ca-certificates -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:27:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:27:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495943.766397 (Exim 4.92) (envelope-from ) id 1pSGsH-0000aC-4H; Wed, 15 Feb 2023 12:27:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495943.766397; Wed, 15 Feb 2023 12:27:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGsH-0000a4-09; Wed, 15 Feb 2023 12:27:01 +0000 Received: by outflank-mailman (input) for mailman id 495943; Wed, 15 Feb 2023 12:26:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGsE-0000Zw-Ne for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:26:59 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05e4a015-ad2c-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 13:26:55 +0100 (CET) Received: from mail-sn1nam02lp2048.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 07:26:49 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5804.namprd03.prod.outlook.com (2603:10b6:806:fb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 12:26:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 12:26:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05e4a015-ad2c-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676464015; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=jgYUi7Hk3CJQ0ktQHBIZxzZzjOJvCu6eXiRegYTW39k=; b=GzXcxONtmtXlUEllisU+uH19YLhgE+mmR7L+aA0p/IOQfDY7ZuL58tiO tUh6uRHK66NvPNwcAeokXOcJZuPMV23JA3VtxOMToMokkGg4T38TXVrI+ 6bw4vU2G+FJnW7A8NsrWP4bjIFBWAH9aNp9iGM9jGX3m6v7J7wEyVgHQl Y=; X-IronPort-RemoteIP: 104.47.57.48 X-IronPort-MID: 97543435 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zPRHqqC/NYyhbBVW/x7iw5YqxClBgxIJ4kV8jS/XYbTApDgg0zwHz mAbDGnTO62LYGvyfdB/aN+y8BxU6J7Rn4NgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw4eh0Wlhf6 PYhJxcOaiCDo7ztz62DY7w57igjBJGD0II3nFhFlWucNtB/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+uxrswA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE17CSwXinA996+LuQpt53g1qOn1YoM0c9W1awrvSZ20CfcocKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjVIctAhuec9TCYm0 VLPlNTsbRR0q6GcQ3+Z8raSrBuxNDITIGtEYjULJTbp+PHmqYA3ywnJF9BqFfbvisWvQW2gh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:PImGDqA9ewE3Ms7lHemP55DYdb4zR+YMi2TDGXoBMiC9Ffbo9f xG/c5rtiMc7Qx6ZJhOo6HnBEDtewK4yXcx2/hqAV7dZniehILYFvAH0WKK+VSJcE3DH6xmpN 9dmsBFaeEYZmIK6voSjjPIburIA+PqzElrv4rjJrtWIj2CE5sQkzuRwzz0LnFL X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97543435" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxSLXAWZ747Ya8PdyujZO1/z9bRtolJNjh+dAv/zl1wBJtKKY5YUNyetHGBtL1zOYXVZloD2NVmFwh70ebSiLKm5lTmvDt+9Y6lxTbtc9+0zr7Obqspe82auAEOSVquQ26f0h+iSbtIVoHnJIROPeIY2BEGTezzuAX+UIDQiok4r0jzmbdmsLSUZj5Jtug0GfqeQ1Tku1XGXtPNxQkLJs90caeEK0Vx7z71m8Faot+vsvj71Wxuoq2VH0943F4p0SnNyXylKLvpcnb3PEvwS1UsFd8+Dz2lGS8Q+eVZNTgPZsPPVBLsk9Kevh53qV3Dsz4jRVrwX6b/5PVjGYVFx/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0r6SsTliDfwd16tfleMFNbXaIkxjIfcGFrhBKGa3dYk=; b=kBMXn6G6LMrPWM57uDEeRyD/Otzjr6bM7Q4h3kI2QbvqSUPVnQk58qm7v8C5T7oRA7gp2WgK/18wUurovJJz4D24pbF1/oAm+/PtDaydR/BPkIXBJjs2CUDPT5r7cI5djS7yyriRe5h0P4NedmUuZcPwQt2PGVF3z9J1FloLsu5KkLuNn48GU4z7kwvdZ0E6GTOVmE7bKdZFSteZVyywPfeSHghGquzC4jaGA1t7oTcf2+v2imBiUjOa5qxQktByJFYz+h/FOvchiJKRa4h//AY7MgYsoj5dgjnX/fNpNmIl5EQ3ETYlb8Yo7rqqVpcS6x+0XYdZLMWiQYWMNsLbWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0r6SsTliDfwd16tfleMFNbXaIkxjIfcGFrhBKGa3dYk=; b=of48MUPdqU3qLA/pTHNy0zAtYTGaWHAAO0erxNIAeJRmM3epioM6HMj13qhgOVrAlSFuniMCSHriCr+de0QjcIKStjowpIbzCkGal1QD4Q3h/LLFldg2l6IQCz9CRugqY+mzmFNscrg+qTSiqbYkYaobeunj6XMuj+a1FOvVxaI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> Date: Wed, 15 Feb 2023 12:26:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-2-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230215120208.35807-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0022.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5804:EE_ X-MS-Office365-Filtering-Correlation-Id: d278e156-2134-49b9-f9ae-08db0f4fe6ff X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u7Lo9605WzYOI/LzONODUxR8tdHU9PjtfRPA+1HPOQG/DpY0pSvJX4bWScgHAGI6cqA1qroaykhTJi7TG4snHbb/3FnqX9CuOFDa3pPFKkVULNbXRpltyk6k4/zB+yWhpWXsC/+ADwxQ9qXnmTq+Ix4GFxxATLoKzoODnzgRF/jswc9Or3NePBBUxZWLvPUIFeRNHzd6qi5H/yL9qrRExLcMHkmnSONPx8jxTXSEbdf62Xuu+4tF4gcxQS/Vxb8utAF9JwGmOlumeBUARjwdic1whOpqhg6hgphGYShD5b+JPdS22lwrrPogPKN/4cXOW4cTAB5nlv8nZ/7ICHucZhO77joZQnBFfk4ywIr+LX/3jef+79N1N22tXEEd5npc2hj1BdxQFAQ5sOGHQ/qD0mI72B9k0VLjbpQMmD1KdYcPrZ/LUxUYoPsJJPcdpDCa5OsR27llwNJgRI361UX5/eNPWhJOEDrh6o/95WnqNV6u4QnRvkvnz3nAHmfY1Cr2ZMBDwMUSmpuREf9Ikdz0ZMAHHrsGnCsbmoxYH33Aq6+kuMKmD5GtRfmTjn7bFV8CiYr4v/g9et6wvf6Yi2QNk6E+T6YZV3Jv3CtuAKWP17KJQ27nDzD+obsh/5FvBFhj4g8nGLusgKmyu2+0KscuYY+ggyMtuhE3gAOqLZAf/MZjfsVmRG1tGbRJK/IRWOAhhSZOSzooHJJtgAt39e6rgryAy7vm7+2YJHoDbRLgqro= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199018)(41300700001)(31686004)(36756003)(4326008)(66946007)(66476007)(66556008)(8936002)(8676002)(316002)(5660300002)(6512007)(26005)(54906003)(83380400001)(186003)(82960400001)(966005)(86362001)(2906002)(478600001)(6486002)(31696002)(2616005)(53546011)(6506007)(6666004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmx2dmpCU3pBZjJ6K2ZMMzhob09HeXBmdkpnSitveXlVelFkRnJaZzhaTWJN?= =?utf-8?B?RjRnWGlzTTRhdnZaYXM4aTNTd2NsK2pHVDNJS3pZUWplVHJ4L1psZFRkZHh1?= =?utf-8?B?MFFUWjVKUFNPeHROd1ZPaW9SZk92S0x2Slh4am5vN2NNVVRSRHFlNnJaUVkw?= =?utf-8?B?TlNTaXBZMVZVa0x0TjBBbGExV2pGa0IxUldjV0I3MWkzSkJURmlDQ2VtdURQ?= =?utf-8?B?SEp4MFRoNkZBYTJVUFZGODh0MjBxNEJIVGFhOFdDVHc2a0dSLzVrZzBHTSt0?= =?utf-8?B?KzU0RExKUlQzaHRWNG8rVWZ4SnBLWjBFTm1ZWTVlWXo5QTdvUFNpNGFmM3Z5?= =?utf-8?B?dzNXaFBHQTJNckNyUnUzaTJweFlJOVNFMFJvNFhLdlpabzdwZm0ydkZUYVB0?= =?utf-8?B?TUhSdGgwTFJNc2Jlak02cE5SSXRLZkQwclpqSG9IWHpEUGh6bERTMXowaU8x?= =?utf-8?B?ZzV2b3V5NFRaZktUQWRDaXZidEloNkNDS2pwV3B2NWMreTg4ZlBtUFRocjhL?= =?utf-8?B?OHVKMHNXWHFQSGNCeFZJbDRUbUNHVmNHaFIzVFJpbjVDeUtIK0NveERjdkJV?= =?utf-8?B?T0ZuMFl1MzFYbHI1S1RNK3JnYjBNcHl3UXU0ZzVHd0k5NlZnUDdPSkZBbWFa?= =?utf-8?B?OWtKSGsrRUErMXp1dWE5SldnMmZmNWRia1BBcHdscExwYnAxWUhFYTh0ZlpR?= =?utf-8?B?UzBzOTRIbVZ6QlM1VThkaldCa3UwM0JKaFBIQ1NnbW9XYkFCVGcwcE9yVkNL?= =?utf-8?B?R0FTY081WWhUcktkdTIxbERxcmt1MUhhMmtEaDNCdGMxMkdXK2lmSHJNR0V1?= =?utf-8?B?RmpOVEhqbHFaQm13SGk1OWR4ZGNWQ3RNdUhpQkJ3TjhRWGFlZ29QSWhtSWEy?= =?utf-8?B?c1d3N1pmQzZwM0NIRGN2VmxNVXB6RllkNVprWml5MVRtWEt0bk15bHhrdTNt?= =?utf-8?B?OEtEdTJLeVI1Vm40Uk42Y1NhSVVON0ZRT0x5NzAwbVZ1WWlWSm9EUVptRitT?= =?utf-8?B?UlM0QitkVDl4OXQrUkZoNHJoVmh1T1VBV215L2pVZHYxbFljelpPd2NFMWNX?= =?utf-8?B?b3VQRCtvcm1oK0JzQUpKbmd1dWN1SHc1aCt4c1hxd3pyM3FuR0M5QXc5bUVr?= =?utf-8?B?SEpORVM3VllaSnJQRnFGWGExL1BMa2lsaXV5cmRlc3BPMTg4WjQwaXQrNlNv?= =?utf-8?B?Z0VhV3BMVGpkak10c0U5d2dKMGZmK3d3RDdRNk5Wa1k4RjM0c3dOdlVUcXpp?= =?utf-8?B?ZndzSlhxMWI0b1hUYzFEeEFqS3ZBcURkdkhGUkdSbWtaeHRXVUNNcTJ2NTRC?= =?utf-8?B?aWYwN2dRS3R2S3JiMnIzYThxamExZjIzcGg1K0FnUU9uM2xtL25wV3VUT1JV?= =?utf-8?B?TjlBZVk1c1BjRUo0MzRZRzh2T0lrTFlEcU5FM1c5NjVaTmhqUVZIckkxTHRJ?= =?utf-8?B?c1dNNy8rOU9hOU5GOEpkOHQrVHBXNmNndzJ6WFVJMk5RVE14QVMyT3d0NG5O?= =?utf-8?B?UklRSHhFQWxzMTVuNTY4VHc3ZDRRRll6R2pyNTBhalAwVHN3T0tOL0RYTnJJ?= =?utf-8?B?eVBWZzZTMkJGcHJvS0RQSk5JZkhYVXBiTWY0WS82ZVZEUmlDcWxHa1pmRW1u?= =?utf-8?B?TE1xaEFUMEh6K3I0SlhyY0pWOXBXNi9JYzB2ZExSaGcrbGRCOXlzc0VGbEF2?= =?utf-8?B?d0p5TDVsZkcrTVlUNkI5OC81VER4Yys5a1dDSUpQM3FITVJBNTBXSWZpdVUx?= =?utf-8?B?Z0kxMlNWczFUZWpNbmlDSmNuS2F5Ty9FM2M5RUlFNVJ6RVJGS2RES1RUQVI5?= =?utf-8?B?eGtpbHlrZ0JZT20xOWFBWkVTOEtYUmxrMzByYytqTnZhOGpWR2lSMU8rcmZQ?= =?utf-8?B?MnkrRkVZOXd0eVA1WXNraUwyTjBGbXlrcUhFUVpQU1J0am9UcmV5SjloUW8v?= =?utf-8?B?R2tQck9ERE93UUtKbnEvYUxCc0xpQXRvNlZwK3l4MTBrdCtYVm1MWnZXN1VU?= =?utf-8?B?cEo2WjdKOEtmQXZ5akJnZnVsbnUxa1lUakNCOXZNNTA5RlZUbkpVQTZRR2tW?= =?utf-8?B?UmplZkNXUGF1aTdNY3pYSnBlVlcvT01LelA2c1ZWRHBUZGxUS21uVnhIbldM?= =?utf-8?B?aFVBcWNyMmxuUE9GcUpFMHRWTzlmYzZOK3hDNGU1eG94NTREbER4YXgxMndD?= =?utf-8?B?b2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yAtlfvtSB/9sWPQxJvEMOEx3NTw/UWnbu7AxvpQk0OE4DUnwExEUEGyjKTS+YRjGw7HbXJDeph6Ri4aW7isjAV6MbJgvjw9vqWD3Ck2mbrK7BdcKbz9hAbdTO7+SfSF4jYbchLJ4oyq/G0LfUbHj5dy6xccL1V9deyAP1m3GiJPyW4zDv7gDf889uYqv0XXgxcWachUf32b8A/83RXMk8ukOEmz7Gokq/imU2o0F1pH0coIS2X0AJgoYmucFjvpsQbYdjSsQpH2CXlZxtxaNLI0mL4fvJ4IequLlBiHGJF9DJU2gkbM/3bWDoNYtx9+G+34zuPwh+tS9Gfks/d3hQUi/ky+GUfVjL8kyGBB6MDbeqC5yODbo/u7f/jsbZfdEkMrxSNtHQyLO4c0PahM1vxlvSVfFPPsntbowoYtqJowZKxpaLEQeETl2RoBvM+CfjdMdjpR4H7GZGoylHTfmDrZ9u/ZKLuIdOjTvrxtv4TxhjBIp66Syqurj56ccV93JbZ7ggHRBryVbYwUuQWEqjwUug3IPIbtvZ98Dp47y4uTvRoJympsyDhVj9+jkuY3xPWRxGFEGVF63Yw7FV5qAgWnaCPYaPnWU6GENb3pv+2iQMJHOWMYFfpQ1b6W5dwbR+WJs1qWgwwYwprUO+wnrTes88AhJvduVsH6v8tE6tu8uT1SC0jltGoJa4msqHz2ZU5N2C5RSmeJ227fjc6qY7oltJ6VtpyhEcHBwBz3fBJKIqAX+IckrIAMleFw+tTQSnoZoTh/swrm6sVtvM29ov9gRV+Oni8qrw/Fin5UdcfOYasxIfl+qZjzfee71ZMy8DSf1wrBqID2JA8TIMSjkKQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d278e156-2134-49b9-f9ae-08db0f4fe6ff X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 12:26:45.8862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: utP/i8eyP4RP4XuWZ3pBnuQRB5HoXOhHApXNiJ4AMNJAalmwkWwxg93Qilv/4swaem4GFWbiXM2u0kECPESn/mhjfgXfyxAJjOyl/8LKBRc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5804 On 15/02/2023 12:02 pm, Anthony PERARD wrote: > First, apt complain that it isn't the right way to add keys anymore, > but hopefully that's just a warning. > > Second, we can't install clang-8: > The following packages have unmet dependencies: > clang-8 : Depends: libstdc++-8-dev but it is not installable > Depends: libgcc-8-dev but it is not installable > Depends: libobjc-8-dev but it is not installable > Recommends: llvm-8-dev but it is not going to be installed > Recommends: libomp-8-dev but it is not going to be installed > libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable > E: Unable to correct problems, you have held broken packages. > > clang on Debian unstable is now version 14.0.6. > > Signed-off-by: Anthony PERARD Yeah that's because clang 8 is way obsolete, and http://apt.llvm.org only supports Clang 15 and later now. In hindsight, it was a mistake to take unstable-llvm-8.list in the first place. Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:29:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495948.766408 (Exim 4.92) (envelope-from ) id 1pSGuU-0001Ct-G3; Wed, 15 Feb 2023 12:29:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495948.766408; Wed, 15 Feb 2023 12:29:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGuU-0001Cm-D6; Wed, 15 Feb 2023 12:29:18 +0000 Received: by outflank-mailman (input) for mailman id 495948; Wed, 15 Feb 2023 12:29:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSGuS-0001Cd-TD for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:29:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ac2f6c2-ad2c-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:29:15 +0100 (CET) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 07:29:12 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5331.namprd03.prod.outlook.com (2603:10b6:a03:222::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 12:29:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 12:29:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ac2f6c2-ad2c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676464155; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ydKYQz6wsFiKk+yQbmMFbusFuaMJ4ekHXQDndb0vSoc=; b=Qqo7iT0XkTksO15ZKKs65LQ3quOaCRiHxbgofKkPLEYMxJNE3XV6y40f ALjcSCD4rAFVf3jTnpeiwmNL2Z9HnaQJr5qYIZUFl2fVEPVxwkA2eZyvV 1fntNvIUVqt4FEpRgHPZU1/FXrhT4gzvCVRkS8RBeoZmU8bvUiQ9C8S5W U=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 97543636 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2J7W0ayTSk2Ecl3kwHx6t+cBxyrEfRIJ4+MujC+fZmUNrF6WrkUCm GZOUD3QMq2NZGf3ed9+Odjj9U5TsMLTmodrQARo/CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPK0T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV1O7 fozCR4IVSCom7mK0vGfEedUoe12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQpuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqB99OT+PjqJaGhnXUyXc6LxYsemCRoKSZlk60YNNCc 2gLr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOv8YsSTsn/ lSAhd/uCHpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLnW0ophfGT9ImGqjqiNTwQGn02 2rT9HB4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CFsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:lMMHNqzJKhfb+w/iEikKKrPw1r1zdoMgy1knxilNoHxuH/BwWf rPoB17726RtN91YhsdcL+7V5VoLUmzyXcX2/h1AV7BZniEhILAFugLgbcKqweKJ8SUzJ8+6U 4PSclD4N2bNykGsS75ijPIb+rJFrO8gd+VbeS19QYScelzAZsQiDuQkmygYzZLrA8tP+teKL OsovBpihCHYnotYsGyFhA+LpL+T42iruOeXfYebSRXkDWzsQ== X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97543636" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCTqbNqb3LmUXQEDhDZpKTwCLGPTZsE0vweQjlhn1M1wnyXKEWJq2Vs1LNlf25aLgScYgwa6OYXz9qJioC1J7151DZt+ngmUdVGn6Ew4+T5BJoLUvptDTFVj9hBjYCfHA7D4V6TsnFhwCMN/CAdVZUP/W8S3ig2FeBLXSgmUdzvcrDrPhruIA/Xs0mYtVe2VyeA4HP7GnNS0Lvyka6FRgT+NAGKMCLUdzbCtzFlYyq0ajNHVMIjw+szslD0BH4txCGFCv/fqoaMon6E3s23XzDwN/MylakFDsXAa6xMzH8iz4NIyZlHzWjrAG0h/KnbaBKuIFA+byy0/cb8wCNurIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydKYQz6wsFiKk+yQbmMFbusFuaMJ4ekHXQDndb0vSoc=; b=UuxKQJsJKatwWRoNvtf2aultAR9H+2D+vlQDoRp7jln2TSyo/s/0a2VbOmNpbScLoJxzHd1fCG/UYnJ0bVj1ZXCREtK+pVntKXRQujX1t4B6boqzU1uIilGG7xTJQudrz2KL71sN7HCL8XTmxBeaS8w+LNxILn+wzBxmzDUgzV+DEHbZRuCyWOcLacTRWqJoXbGYyH0Ztxt8fhfHLbPTtPPwWxgpK25esMp41qX5CDoP7xPuWev9koehNO8RTwFAZ7C2M/d1EKIfEJWq5wMnXmDSmmplY2a5dByN7aczaKxE3rwNSdKiSc+9keNC+AX0vDWE1T/3i6Q7bLtRguwxKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydKYQz6wsFiKk+yQbmMFbusFuaMJ4ekHXQDndb0vSoc=; b=EwCyFT7RqVVwtXzHavy9Ff1ayg3Q+lhBTK2KFM4hLmlxNhrgjQHprvLEgyEqLVrgF88DmTvq1QrGxVAatrRZhPvMR9eD73I9TT+VqmeA+Z1XDtaRUSXrjAi4HpwNsqZzlZzlIBvClR00wX2HD5jRzYYuDgUifPM80D9hhj4UomM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <946678c1-1877-fa4a-42d8-b55bcdd1dcea@citrix.com> Date: Wed, 15 Feb 2023 12:29:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH 4/4] automation: Add more aliases in containerize Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-5-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230215120208.35807-5-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0116.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5331:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e18d6a4-eff6-446c-6fe6-08db0f503c78 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BR/CmUn3/dIPYZ5kqzTrVdtlt4+uwuV0NiUZu5O0+HKYnuvEYo1oxhXzSD40spYDgdEFvZJmTx19TjF0Xuv9tzFgwbkpc0RgWCeKeEeIPUZ+mEQu2HJLvVd4UoVzPIGxmwUfiTmSYLO71AVEYIuaGHM1yjTlXtaTgMM6p9NbjlqA6Nb7VExHaF2k05w25Lkr1rHXtSTmg60MDw1RDt6EMzdKvxdlTIdoktJjl3tAGDwCDM57KytD3YcdJWDT8EYXcmK1+g+HSmCvokdM5/Cod68STkX1af6W0ZBjiPF2eKJLsiMXvy0Ojj+B6pIogRlANPOqjb035AvRpiNQ4yI8vIL7Z0L3oDiU89Hx/e+ulUX72yWSXJBpynRsGcongYjmu+MSid1z/oG770SvdUPDbrWnaYF8eU3siiZ5PfJez4+gVER40NUU2nH0ESqN3IbCUTG7IEu168nFbJHM6gRWPiUn/Bn3KPMKOftCCAPt+mtz2XicbyQ2cKpyfqNUOdKp6hSeVnBJQ09Xsmb4mDv2gWcYja6ZeDKszzGSYtOFMhHiKhQPgAwQ0LnhSsK7qFGGwiHD9+DG+Yh4o8mTdOnik3/y3WjPzuCDzgusJAkAiipAoZT1NCpMXWo/0s9DogyCF9AMhEzaPrSHyqyGUNy1xPt6ZzL0ZIG/RF0kPBb+yloPvWDCcIDb20DfWNXen3jVBzaPpJC2EbgmcN6aaIm43vHVjYI+OSkCQ4ETdgwemIM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(451199018)(41300700001)(31686004)(36756003)(66946007)(4326008)(66556008)(66476007)(8936002)(8676002)(316002)(5660300002)(54906003)(6512007)(186003)(26005)(6666004)(86362001)(82960400001)(31696002)(478600001)(2906002)(6486002)(2616005)(558084003)(6506007)(53546011)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjlMZzNBcmlCeFdhSWFYUWg5REdtWlN0N052WlFjeEc0dEtIblBuamh3OG1m?= =?utf-8?B?cUFwN2lpdC9ETzg0b01wbEJVaGdJVkNXbHNXKzJ5T1pWdzRUbmxoMjZJZVhR?= =?utf-8?B?dmp3bVNHQXNxV1YzQVkwTVdlN0ZsdXhjcHBBQ3hEODY4Qzk1R3lTZ3F0WkFC?= =?utf-8?B?RzlIcjJ0V0hhUjcyNVhJMXRDZXdKVmlVT09FN2lYbTlKTTFGakJYU29YKzdK?= =?utf-8?B?VFJWcDV6ME1NaVkvNUowcVl5YzdmU2JzYStCTDIzRDUxTlJCNW1EMDhlTERm?= =?utf-8?B?c25xMHhQL3BzSExUSzlYTjRLdm9QRjJQa0FkQ3VHMFI4VWtIV1BiZGZYblM1?= =?utf-8?B?Q3h1KzRrM1JGOURROEhFd0NjTHp2WEtYbmx2ZFVYaWYrcWlDUURJSFR1MVRP?= =?utf-8?B?KzdtbERvSWRxNlFaYnJmRjdIVmtZekc3Tlo0NFB4UTVmSnJLRHAyZHkwSHVh?= =?utf-8?B?YUVYamRGdGlRSVg3cllIRXFHOUQyTVN4M3ROMEN1VG95N2R0WHFGOE0xSXMz?= =?utf-8?B?TWxWZFMxcU1keDNhRjhVL21sYXF4bjNFT3pDN3BoVjYxbVBHczBBTWpFRVBC?= =?utf-8?B?MVlaeTJGdHM0bmFUOWNBZEJkOHJpU1dqZ1NUQmR0K2crM2dUL2VSWSs4YUJT?= =?utf-8?B?SEduVnZWZ3I4ZVhjYU1wZFloQTZWUDBZNGdENFJrdFB3amZvalBXTTlCb2l6?= =?utf-8?B?M2tERGJ0anZ0eVBsVGE0aHladWFSVVFoTlRDVUcvRmpmNlR0NHk1VGY0MUxY?= =?utf-8?B?eEdBUEVVc1dVNEpraVZTdEk4M2MwNndMb0FoT1cxYTQyazFDajIvWkROV1g2?= =?utf-8?B?VjVVMys4MmVGU3BIWkgwRytid0pyeUpyS1FEUG95VVJ4enVJRVhFZlFIblBi?= =?utf-8?B?YkROVmp2Y1BuU0l6TG5mS3VYVW00d2cyaEZhYWcwdmU5dkw5TVNML2MrKzBy?= =?utf-8?B?WFlPTVYvTUJ4RnIxNkxZVmtielBPbU9MYTlQaU90UUlYcnd5UTZXTG16Yjh6?= =?utf-8?B?ZFhaa1c2dGo1OEl0TEhCeDJwaG9OcjNwUjFSdWVCYWVQd3VoRGZOZU14aktH?= =?utf-8?B?NkRRdm9SZGRTaHRtL0xEOGsvTHJYRE9XejBHbXZTZG5vcVE4ZkV6TGFpSTVR?= =?utf-8?B?OHpGMlZPOUJEY3pTZkdwZXlKcmZyN2JTbjAzQ29QeEtqd3FmdmxrL3I1a1pI?= =?utf-8?B?TTRwRUhGdWVxWTZPQlFXa3Y0OWxUMFNBcklxb2dLQm0zSm1RbENwV2d3Q28v?= =?utf-8?B?cEhUWmpoMjJGNjhIMXM0eGgwblFLQ2l4NzNKTWh3TnV1K0QvM2l5MkMxb2M4?= =?utf-8?B?a1VBZnJDckJTc0ozN05SSGFOdE5XWmkvYVplYUVhbXhKU0ZlUWV1b0hPc1pL?= =?utf-8?B?cmtYbVBVVWMxVjdKbXVKbnpiSGZBTTJtQWRYTWU1SVBoOXh4WUI2bFpMekNE?= =?utf-8?B?OXJPam5KWFR4c0JyaHF4aDJic1RtdW45RjI3b1BlaHNVbnp4M3R2azFOem5V?= =?utf-8?B?c0Z2MGQ4bFZ5ditkWXVFUmRJc3VjWThid0xUcTZaTlY3Z3c1OWltdkFyTndS?= =?utf-8?B?YWJIa04xM0srN1RwQ0dBSUNWaWVFcFhnL0ZKU1hkMEFpMVJkc3RkaDdGNys2?= =?utf-8?B?aGJaLzlOalBpRnFKdDB4MHhTT1kyRzlSQUFUcWpGd2xZM0lIcFdjRllITkFj?= =?utf-8?B?Z0w2NjZFZlRmTFp2QmNUODFScGRsbEtCNXRtRVhGY20zeldxais0dndYTDZY?= =?utf-8?B?Qjk3VkZ3MXAyTGdaanZXL3lJV3RBMDFRZ2Y2UWhBYXR4dGhIcVRMbWNmb2dN?= =?utf-8?B?YXBSKzUwbGpVNDJtblRjNUlZVUFIUHMxUSsrVUtjdGlON0c3Y2E2eDZqUE13?= =?utf-8?B?VGFYeWM5cmpuOHk4aFpTME5VMVpONnltZDJHTE9XQUFIZ0p4OWN3a3o1Yk9D?= =?utf-8?B?VitjV0o3ejQ1cGRIaWphdDZReXhiOGJPWXhKNEdHWEhlanNsMXZlQ3dlMnhF?= =?utf-8?B?bjBmOHBxUUFJTzZkOTN3MVhNV3pTU3d6OTdDcHNVcWlSN1RHcXpyOGNCdElv?= =?utf-8?B?NWtiRFpmQ1doS0c5OHhEcHJGQU9HVmJTY0U1cmQySG9uWVNHYUEwOXF0ZGhn?= =?utf-8?B?aXNjdFVQbENVbldOWHltQlNacCtYL0tDK2dlU21BVDJFOENhc3JwKzZGVjRF?= =?utf-8?B?ZHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ojKXYV86jKZ58Xrg4x93Ghqd/yZaiUp5hLkYgF6/px8bCiyjQpodHo/uehZfN2JwVrzAMQAlz5mycuxdAbJUmilBtV1OQjJuqYGAHU2VJ7dOLL4/RkZDj4s99xKcFavN796cM2RisoK5VLhs3SI9ynrn2LUS9zja+wc8gOtLNul0SRpGqZ5e4dqsZIpIEAakwLH/6VMRJ35nnMG5FUVZDQaG7wCcVOmZ4QQ4dpaQ+jX6ysPNMo2OqADBwGF/e0q2YNbDZhOXfjboOhIODKNoNJdAK9lDhVXYJKNsD04MEa0x8c3Unb2N4lQGQT2O2pqXIBU+3G1xB0KHWyaw0qrL7Y1jg2dusdjZeKU6/yCrVFiRP76muXrhmBsp3+AVzPEtzRXf4cwSHutbnBj3g+OgeebUBnrmINDHCgxKnT7EMKN3oa1jEG14xJ9DkUT7Qwn2HM5PvbsLlpod5VZE6vxRY9jmtDzyzEZsOTFIhSpuB7S+8rqyYicldCcktxtTrsCmk7TIBTmRlajIKtW2CY33W8oev+Vqw7a1vpF/dRfYY7dAqQfAq16nsbDzyexVDYBhWf+wRoMSvKhVPZdtlsApuvWshicsVfdhHP/L3XMQB5BcAtfB/9i2CzOUdvIMkEFZZH2zLkPaOkjsX92FDPdkJKNnSD3tQVHz5pQSsA+ErPwET6TFElxPIyRQboBt683LAwlxh8hODCMapdjmM11ZVwC7rzy8qFS0EgeN8h4gV4L6DiYSr0SPaDeEs8KeuhazZ/GfdKHuXeVxJ87ixO5TAgkQlTa7QFoKFaW0TPOGgcajOq5Gl0J7tOmfATwu8AMOPh0uAjgDk7gqsCjuMahN5A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e18d6a4-eff6-446c-6fe6-08db0f503c78 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 12:29:09.2195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Ys1BNkIFKBezrGwXqjix2Rvx5mqzsKRNn8rXtDC8StPu9XX2qrXghePPuXOMV9ehWj/d1RVGkXduUmnkmOU9QkmllCHAY1AhbpcuTPCrlE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5331 On 15/02/2023 12:02 pm, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:36:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495955.766419 (Exim 4.92) (envelope-from ) id 1pSH1m-0002xB-Br; Wed, 15 Feb 2023 12:36:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495955.766419; Wed, 15 Feb 2023 12:36:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH1m-0002x4-8R; Wed, 15 Feb 2023 12:36:50 +0000 Received: by outflank-mailman (input) for mailman id 495955; Wed, 15 Feb 2023 12:36:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH1l-0002ww-L8 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:36:49 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6784aceb-ad2d-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 13:36:46 +0100 (CET) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 07:36:38 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5331.namprd03.prod.outlook.com (2603:10b6:a03:222::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 12:36:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 12:36:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6784aceb-ad2d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676464606; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=wgz6eA7ewvfoLa3ktw+QAFC6Xoz+7XxObOEaIhKwdBs=; b=g1pe7G2KYmeFH+wZiMetRok3dAtkp2UF0/D3PvgF0WrkC4RmPuxWKYwY NJSfLnbGuZHt22Oh4Rim+CFt5sknDKd9aDiCfR7U1/JOlNsHhNvw6WzS3 YaAsNpWrjiqSR+kv6BCns3gtBtgxIc6pVBF3RQFkYg3Rjx+IBHIT21mU3 g=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 99554142 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:1rS7D6M9wbm3CXLvrR2TlsFynXyQoLVcMsEvi/4bfWQNrUpw0jMGy 2FMXz3UaP6MMWPwKNFxPYji/UxQ7JLXyYdiGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wFmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tctITp// NklET0uNA6Buv2K/qKUWMA506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eezH6mBNtOTtVU8NZTpluO/30wVCEocl/mht+1qEygC9R2f hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpY9U8uMg7bTcjz FOOkpXiAjkHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRt3jX4iIQ6jxaKRdE6Fqew14TxAWupn G7MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgPpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:yRE8267BJ8XZIdbwNAPXwNnXdLJyesId70hD6qkRc3Fom6mj/K qTdZsgpHzJYUkqKRMdcLy7VpVoIkmxyXcW2+ks1N6ZNWHbUQCTQ72Kg7GC/9ToIVyaytJg X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99554142" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TidWqDTk7Bnp5M7fXjijXTOiscw0Fd5ztILHUGrYzu77qm6EYlKqSasxAvaDiOPoeOE39TOrfj2FL+z+Hf7M7396Tkb5zWCFO7FBdy7FU8i+2jY660USIJLFHapOF++aHQF3qrk4KIrM96/5Gm4zcI6+0PitpiG/DL6DEIEil2GF+q7slNv44jC7jR97lPK2jOYFMBNlolp9ieNzi4h3Upr+B/7s3ki33bvJOUowR0AFncKxQX7JgHpTSCeYGMWcBb+J7diRNrEpIH9RIMm7ElS16PouoK4RNDYZQ4BXOcIjdiQN12dBTa0hpQkjCqryaDsN5bC2D0xpt/koCfpi3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fdSoV0etH00QUEh3gRB5Nk8NYqeA69HbB/2V4j5CNwM=; b=iM+LwfhYpiTC6VJBnzGb4gqFEbgugg4UfXvp9e36UCRUm4Ne2aGbWsrNQN2TnrWHFzJ4wF47VqupPJ0Icz30LpuGEc2AQe1W0IsS9uxZ3WcKJIcL6jzFYN3GHCdfTkHKxrFujm602KYFDOvuU4sWllx36oV9kgzZYv9FGzIP5bxnDowXFcc56Yfdaym2ZhDO7lsQi66dgSjKqGo0+KEEqszXHjD4RqdCYQuFCcfMHIZC99rA5i+sDGTE+KyE9Al+GTR/pzDvRwPFeuR9kilYUORPJOlzEPcMTbfsEMtOEqaZqvqd9PUk7zZlPMD3rxAuwsEFckNYoMkyqNAHnT/4jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fdSoV0etH00QUEh3gRB5Nk8NYqeA69HbB/2V4j5CNwM=; b=PbnPM3b5NQzROuxH9a5/e5nyEgwZnbEoJVQ+Fv3aRo/lvHD60OUatbTpKvjPWczpCawRsslJ+LHmNX4XQqWavkyvPH1rFV0i7/n5SYSWo3hvHNte/ok5QjFfYwd00rtz/3JESfSAZQzhgJDB+ghpc5J+oZG7IwoNt0oPDNsTCy8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <949bd6fb-a6b2-71bf-7eed-374939b54fb4@citrix.com> Date: Wed, 15 Feb 2023 12:36:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH 2/4] automation: Ignore package authentification issue in Jessie container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-3-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230215120208.35807-3-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5331:EE_ X-MS-Office365-Filtering-Correlation-Id: e6f6e45f-d6b5-453a-d563-08db0f5146cc X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x/aU2ZVkleheHlvkwdJYehX3XyIGYmDf93mz2phWvw/qfIboljFlWhn8bljXzGlwve6LpjcSe4oNsTi1CQYrZznAaEc/ba6JQTmqmTF9lCdaCSbQKXbGir1qYfYMZSmCjKYLIe52uHZLoWds3nPXP12Q57K1gYpqJcPpukD+FtVTPGRjF38kb2fAhszF4pkG+Oxhe/56zWuo//E+K5diDC0bJadNB9Q6N18xVq3WEEAqj42rPXnBVQdNL4CzmIrIL7pSTA84WCkmXPMvPIWNCS35ji63EefAqP5jhRB2S4oYSiMtuS6xjIRkb1Dlk8OZKs2QGN5i68a7URvJbmJPRBR5wpz9XxE5PPGox2WVNzrWc0UVaBSJ+smvD/EYruLNSxT+7o9qD3wTlFgDg0rIUo0ms6OPXrf4ssaGNA0HeNGW7fwvFa1IvsKcG7Zlz3q/WsSIfucb+mXxJmjUzD9/n1Cgp9lCf+R37kl+kwQZpuEf4mqOShQ3d82hHotS/Scz4dqOd1HpaCO17zCYjGYeY6ajScI0Vr3WoMmfMee8dqSJtPNI/mQboRcPfx0HpIVzu1/5lo7zTASWQZi14/MlTjtXArE+nFeJCVl+g1O0BExFEjz83dK1HHyq59RDMoGp2ro462pr7JahUlR4rPGAi4U+DDPuTl3Lgs76WGx3bURdkcG/osW7kHHwInF8Uo0MH476HHmhkA1+UvGPbCnsfSgV0yuDw7i2R5JAXtujNDQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(366004)(39860400002)(346002)(396003)(451199018)(41300700001)(31686004)(36756003)(66946007)(4326008)(66556008)(66476007)(8936002)(8676002)(316002)(5660300002)(54906003)(6512007)(186003)(26005)(83380400001)(6666004)(966005)(86362001)(82960400001)(31696002)(478600001)(2906002)(6486002)(2616005)(6506007)(53546011)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFVSeGU2UFdYQmhhTmlkTS9lRWxEZEZRcGlJY2kwczc1NlpjMVV3bTJNWFRh?= =?utf-8?B?MUZ4TXQvTit1aFRJS0tzakE5TWRtSDJLeXpETnVoODRiZ2Y4azlYWXRCLy9W?= =?utf-8?B?alFHN0tFbnBpSzE5YWZnRnpSNTNWaThSRWVaU3Bod2E4ZkNjdUU1MlVCck9M?= =?utf-8?B?QitwOFYxT21HUkFaajh3cGxWeVloWUpZVTlmRjNMRnZlcjBnWUxaa3gwdEJ6?= =?utf-8?B?RVZ5RjE0OTdZZFhiWjFiN0RjYkNYVXBKQnFkN08zUDdxSFpmTG1Jb3FYbjFM?= =?utf-8?B?ZUFnQUlRQjB2TU1LOThCZjVsOGFHMTRoZEJmNnYxU2twK0dVR1FrbTNYVkk1?= =?utf-8?B?Z24vVGpaZlNSbktqMVI4a3UzM3h4V1ZuQ25ISHdOUTZGWjhtYzRhTnFTSjU3?= =?utf-8?B?SzhMa1E4TjdIcW92R20yaVgvVWhXaDUrSXhiOUZpMlNVMVZPbTBBUUJQMGYv?= =?utf-8?B?VmlsWk03ZGpndWFoUGJtTVV2Vm5IV2JCWjVJbmFGZHJvWFRtaldxd25JK0pr?= =?utf-8?B?TVV4N0NvdkVNSTF1S3Z6MlJ5VGRpaDYzYkUycnB4Q3pjTXNiazdLUXZ0QkVq?= =?utf-8?B?aEcrU0U4WXMrd3pvU0E2SVFzWXZtUUFGYWtsd0JyMVpmRE9FVTF3WTdOaVRY?= =?utf-8?B?YXRxM2lJZ1lIR2hnR0dIWnRYTTB4aUNmSzhBL3pEWklGQ0ZYR2kvazZtNWNY?= =?utf-8?B?NjdhQkU2ODc3Z1Vwa2U1SFowbm45TzNZSEM5T3NQRjgyZnBmSThkYUUrdEFW?= =?utf-8?B?bDRoQ3dDTFFxV29keXdHNEJ4OTNYSDBYUUd4NEpXa2VBWURxamxtK3FTVDVi?= =?utf-8?B?ZjVyRVV5ZEVGKzFWRkUwNUlLR2RiS2wwOGEwemExanpQdmczbTFHbnZaaGJ4?= =?utf-8?B?eEdJS1BuanNqQ1BaNCs3VnFGYXBjMlUwVytDTmNuSWd4MGtRaldhL0MrdEtO?= =?utf-8?B?aUJWYnJUVGFnRVJ1OFp0OEVqZmZtWGZFS0Z1akJGekd5OTFIamFkQTkwT3RS?= =?utf-8?B?b3d3Q3hMSGZRTFRFdHdjR0hJUnRnUE1OZExRVVpMTGNqR2dSNm9xN0NTOGJl?= =?utf-8?B?OEdYOHVzR0pZUjVabkNTOXNpVkFUUHFGRThnYWh3aUpITG9ZU3puU0FnSnlI?= =?utf-8?B?TG9TaGVvbTZRejU1RXZxbTlvU3JPOVczSld0V1h6T05POFBJbStGZlU5ZlQ4?= =?utf-8?B?MnF6MVFBZWFrd3kzWnp4ZFJHTXpQVjBuUEwwNXd6ZW5FNmIxckhFdU4zTTBH?= =?utf-8?B?K3RhUlN2NzkvWGRvZHcvOHp3bUZGeEo2OHl1RlhPR3hLR2FJVGtKQndVWkxF?= =?utf-8?B?Q2M0bUtldVNVZklLaFJCKzNnaUYwamxSb3NWK21yWE4wdThkOFY5cTd4ZXgz?= =?utf-8?B?YXY4UkRpVE1YOWhMMVZ2TjZYZm1RN3lXd1F0MXhBZzZQUUR0ZVRzeFp3NlV1?= =?utf-8?B?aVVBOHVkYXFyT1hRWmNEeGJnbVpUUmRJejBJbG5ZTWdFSVozcmVBa2VYb2lK?= =?utf-8?B?TmdCVEVoT2NzT2p0dHM4ZnBtRlhIZUEwV3NtZ3l3QmM0dmMvekNLYm1jdS9C?= =?utf-8?B?ZHJVM2Y2VzB2cHE2eVloRVp5MVhGZkticmUrQzUyUUg5VjF1RDJPaEdVOWdH?= =?utf-8?B?WUFjUTI3R3c4VDF2bGNGUm9DNkNURm5HOFJsNVVlY0kyQjdQcWgrRlpQYVM1?= =?utf-8?B?YU5ZM3A0T2E2VUtsdWxnTkNvdkJUVWZ6NUh5OHVEdXh2dHRpVjVSeGFmTFJW?= =?utf-8?B?ZzRzK1pieVNPWnBuQVovcnQyTGdNczZYdFN1c2JPdnBJRWthSE8rWFZMakZ1?= =?utf-8?B?Mzg0R0tYQkRkZElxWWd1N3NhaEtZZVBnd2UvSXM0TTVScERiQUgzYmVURjhS?= =?utf-8?B?UitVcWtINTI5M3NPQ2k4cmMvTElrS2lwSjh6QmNvUUpiVDM2S1JNVnFCVXJ5?= =?utf-8?B?UmNidXRralUzQUphU284NDBIb291eEVHMS9JYm9tdkZ3V0ZPZGdYSFk0aU1l?= =?utf-8?B?Y09IWDJjZE5HdUVPTGE1dzdrK1llakRoS3NEb1hwTlJhVmFXYUd0TXZCVGor?= =?utf-8?B?cE1CQWR4eExGYm5jZG5FdlZUcHJuekdlN1lPUCtUL20xa01aUW5TeEV0b1ZY?= =?utf-8?B?cHRIcDJKV1UvcHg3SXBZeFcvaWFwWlFZOXBQaE1vMURrWll2dHdkZUNMYlFy?= =?utf-8?B?eUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NuQyrOYd6OCDegkEIN56ByT/jmDLfDzXP2YyfmtAwV8b1B+B4hPlycpd6ZO6vkJ7YoVEXUbQIkI/rW0JDbIa5BBO1oRBe5wIAtHbX2UPHxTDDRjIWuTNUWhGZQyOZWyogWFpLu3RutS3mOMdfAjZ9h8kPZaXDWYqSWD+JJb6BwRaacgFSTxBvnv+M/WKSCEu5Rhn08l2yynGUArhq4lkqR8sor0pE5f1q2Avxjzg2/3pDYnVLRl3ZbeBFVdqcYOxyNS8ukD+GnrXlCXwEKxbmIX2GLnmwS0UX+b8PWp3R3owNF2CnVG4geV+Ho5gHz05jO/OQZKU0EjX439hL4l/4S8vv/5EHPQRp9zdYfdry3M8Qne5/VW4BLRtk0kW/thzqcyDReGDAIsBQ5jU+ku2Jdp58jzwory2lwIF+6M7Gw1tUAdRmtIoRB7YbbkaFmCuWk1YTtLix9KbgBsYPEDCZdgzs27qUsBSjq3PYLqMphcXwOE3DQZDDPz6hU2s+XOUf4yZh8H44FNj9OximbZ/XtFdIVmEO94rKWfhglEAUlopUp95/wfXstmv0YpcTKg5vsvaYaLPBXt2W0Adhv7WDElkQikjZxpJclJBtm/Vias+9BrqGevwDmXsb8yXlOPLizxBgvssMNk0nJnKkFLhAPsiurvcq/wivyIKlvh3enrzg5dq2muO5CvcZQXgvI1Gaj3RAkBfLSySHUm/5hS+9u62dmdmngIAKayWcVyYaKrM+kOxtFHZDji3j94rR2vzQjsQv19P2X7rUmhpaCpSAPgQuqs6WzJxKBohxYtG+F3C+EBBluVDB7GLu1LEsoFFCKG/HA4GT0XE6i/sktfiVg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6f6e45f-d6b5-453a-d563-08db0f5146cc X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 12:36:36.0153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: diqEL67draGF7fKRffBLDhHv6VMjFPifzEwpgQqOdx/J1whOd8A283f9jxD5zYsjDzZITFjPV33jGUaD1MBU9T4UeIm9DuqrthOs4yGOKd8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5331 On 15/02/2023 12:02 pm, Anthony PERARD wrote: > We can't easily install package on Debian Jessie anymore, the release > keys seems to have expired without a way to get new ones. We have > these warning: > W: GPG error: http://deb.debian.org jessie-updates InRelease: The following signatures were invalid: KEYEXPIRED 1668891673 > W: GPG error: http://deb.debian.org jessie Release: The following signatures were invalid: KEYEXPIRED 1668891673 > > So, from now on, ignore the warning and force the installation of > packages that can't be authenticated. > > Signed-off-by: Anthony PERARD > --- > > Or, we could just not test on Jessie anymore. Jessie fell out of support in 2020, so its certainly not reasonable to be testing it any more. But on older branches, we do want to keep it around, so I guess we want to fix the containers to still be buildable... But is this really the best option?  Some googling suggests that all we need is a properly up-to-date debian-keyring package.  Are the jessie docker tags really shipping with a broken base package? ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:41:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495962.766429 (Exim 4.92) (envelope-from ) id 1pSH61-0004cU-Ts; Wed, 15 Feb 2023 12:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495962.766429; Wed, 15 Feb 2023 12:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH61-0004cN-R6; Wed, 15 Feb 2023 12:41:13 +0000 Received: by outflank-mailman (input) for mailman id 495962; Wed, 15 Feb 2023 12:41:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH60-0004cF-N0 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:41:12 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 061e2bda-ad2e-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 13:41:11 +0100 (CET) Received: from mail-bn1nam02lp2047.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 07:41:09 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6198.namprd03.prod.outlook.com (2603:10b6:208:31e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 12:41:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 12:41:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 061e2bda-ad2e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676464871; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sI8jbEICeYZu6GOkVGfYajbZ9IXXv9xrMwh9gy8nhtQ=; b=MwfxXTIErI0cVClt69qD6+oUzjeLG4apEF2Rk//s16OkO1MAykhFJw1T NNeb1oAvl/wf+bYDzvMQWUUVxJvPMdfIZfhHnn0OIbXVDwvSKANyJwYDw 2VIsZc3F4lfKyXzSNHGUR899us5crOMAlA0vr28AGE/ajjOSUgdQvAiX0 8=; X-IronPort-RemoteIP: 104.47.51.47 X-IronPort-MID: 99554478 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RodK/6wyC0TEctUN6nR6t+cAxyrEfRIJ4+MujC+fZmUNrF6WrkVVm mNODT+FOvyPMWL3KNt1aIyyoEwEv5GGzYNqSVBoriAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPK0T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXxc5 eU4JWAGUh+Sl/zn8Y+3a9JXqst2eaEHPKtH0p1h5RfwKK58BLrlGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjGVkFMZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKqBd9OSOLonhJsqGeX6UBNNCY/b1WQi76YgBGkYtBCL mVBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQtvdU6QjEC3 VaTk9TkQzdotdW9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHeTJobixvOSpNpFvezh9itQzXom WjW8245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 hDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:iBgh6as/I7v4xOY/LQDAhyEA7skDZ9V00zEX/kB9WHVpm62j+v xG+c5xvyMc5wxhO03I5urwWpVoLUmzyXcX2+Us1NWZPDUO0VHARL2KhrGM/9SPIUzDH+dmpM JdT5Q= X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99554478" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaMXQEY2tPsYf0jNqFfIAbZAUR72Ty9D8ZBDbFPT+TXHNhG71cPP6Z8d/0JDxBJCvgUWyCZkIVnCVtEGmkW/D0PJ2kDIgKr4EvQtHqt4wnugKwMTcCiWmiCSU+gbgn4p32iTdpnF+yxAR5+bRCdLaWmF2R5oXJv99swm9uvikAaQH00JWkMhCZlrp2SEEYH291amYlv08AYofr567Hb+FNVqCFXzMdvc6l5gKNfggvVTA5bX6IAvNACXif6mhJefwt3sR+fFyLwLA2FAP53a2dN8oL3oH5B3nIp81SkVKL6X9qKzgl2/07hlqe8YP/i4qznfupqE0jZslnetm50n0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T0BBgB+kCf7A2fKZRpLq7fGvnhr0SlfSLUYirAnAG8I=; b=CP/L/f3/oAVwIXcv8f5Dsds6LVwhucSALiJir/h5Oy/hyN365zF+6qhZh+rNXe/AdrXpRxThv8UvW6oFXuEiSqk9Wu2o6Exx7QSk6TU2UYN5YyErGAYl4+vtQnzmv1x/2a2QRxTyPUVLf+hgpKsx2T297XrbfiBNbmtgiugy1djamJqKrzSEcTx3m3hIAxF/Yl6IlVPC1H/UNy16qnesgX44BuJIUb7LYJbzs/AYmBBGuMTlGYLpcjywxI1d6Ru2tVzmy2L5s76KAty6mVwtp8TzvysavG7fqtueJ5Vc1Qh4mSVsaty6c2tK1fIOPwla6xsn/lQVM5UoJEE4n1izVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T0BBgB+kCf7A2fKZRpLq7fGvnhr0SlfSLUYirAnAG8I=; b=XSOqRNXMzb2rT4jVPeLr+Ja5TMMIARUjTC2kzEtws+DwaCS1kFiQtAb9r+tK+yyqpC8Fv1Rd6tQOn5Iesw2GEZFkAwejvc/1gzq9xHEC+jBFTzb0hZD6DfgYcW+3n0baPdcE2FGFwVHTHqihFpEi2oulk9sbWFh8E0JUdnY7QhI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3caee35d-3c0d-7e28-dc66-6f422568edad@citrix.com> Date: Wed, 15 Feb 2023 12:41:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-4-anthony.perard@citrix.com> From: Andrew Cooper In-Reply-To: <20230215120208.35807-4-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0091.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6198:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d6a826a-c229-4eab-b961-08db0f51e82f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0eqSagM6wGqo8udkK/qtnlWsS5zSNk8kWqkU8ap3AMK1c0AgvP3yUHjzzg8TwJ0gggDrLnrj1VV7BvPL/ZaQuSfxV1fAGnEu1kOTEWvUR7jAFrLfqjmD1B3nRfZLLb8qsWu4MgnNgrVl2esLsUgOADbvm5xWYQuKwicoqz7+otnceStv+fKVqcmvQ8uLEbcK02UbslXTPuePm9som17JIW5SnZwjm1ijspjSehwf5doeu1VSL8vyE73xDIfMJ1L01YLQYPjOGptGM0rsQ5bXKriA+yOJJh8cz5QyZzwyz9yZcjV+9/sZRdX92PzoXp+/N4Ljj0KhEtNllB9nC6PsHzPco+adQJVMh3aXdCsMOjijaU0KfPWsDGZL+R1OXeuKTPRPVhNKakYvrkjY7KEHB0gspmiksZSkIU2StbiSCQdBjjHr9Ema9GNVWErjbDrxhCYSpQuTEsQFJ190EOUht+z7o2gbYoh2ZMdOi1uCGpnDASC9nTL4gJEFALIshku6kuDfwUr24Ls9FmqNQnFfJtTbpampwPCYP6Ufva/q5qiSi94/EB++u7hbiQYzz2X/ZVrDCb5JhTp5Vj6eNB75o2d8HHe/bU2mWebuPacL8TyzNGiHv4Uvcn2XIioi5v9uhmWLaBeHROOJhk0fyTNUzvjhdAQ0ro8pP1T/tbLchHIfV5X87/Fy8Z7jaXZsyMNep8xdv4BVxU6Du6KLPBypJaZqcZkQVFkLFtc+XnqUOjw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(451199018)(6666004)(6486002)(53546011)(6506007)(83380400001)(6512007)(478600001)(2616005)(31686004)(316002)(4326008)(8676002)(38100700002)(41300700001)(5660300002)(8936002)(66476007)(66556008)(66946007)(2906002)(82960400001)(36756003)(31696002)(26005)(186003)(86362001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkM0Vk9mdGMxZmtXUGd3enRPQm9KQXRvZXdCUnF2TTB2eGo4bUxRQXpPZkU1?= =?utf-8?B?cGNDbzBNYlFFMUZKZjlZa21NR0h4bnd1NVNFNFdQeHVNVkpSVkJJYzdKTEdv?= =?utf-8?B?UGlDNGl0US84MEF6ek4zdVZNUEZwK25OOEgyWEFReHJ1ZEoveHVBaEcrd2dW?= =?utf-8?B?VWtDQXF3VGJZeVA4UmNFTzFhQXNHbkk0VzJwVkZIZlhoMENhZjRRVlhobFIy?= =?utf-8?B?R1ErOWoxN1oyNDBXb3BhOUxCL2RwRWczZGYzOGRLb2k3bnBoREl0THBhQUFp?= =?utf-8?B?U1Z6dUJSamdaM3F1RFcrWjZFRXVMK2tKVUlBUXh4NEtoVnZUZExvQjF0dE1n?= =?utf-8?B?cVhNaHVuYlduMmRyZHROWXI5ZXU4NGt5eGFVdCtSbEh2TzhZOVhtWmlJQ2JN?= =?utf-8?B?VG44bzc1QXZtSXRaRk5vSFpMdXliQmoxZDJLVFhqTEhqMFRpS3JicDRTNEdv?= =?utf-8?B?Mk5qOHkzWTRHNWlINURtK2FvcEJEOEt6eWphMVkxMXh0eFpKM1FFY2x2Q0t1?= =?utf-8?B?RUlGZWQ3U3k3bDhmVGl0NjZpUUtIc3FLZ29zUGdtbjBCTnpVRjFxME9Vc2tW?= =?utf-8?B?cjdHa2h4UGNXeUI5V2lmcWRidEEvT0JiL1A4aXZieGtSUDFpM1Z1NEljSkpt?= =?utf-8?B?TzU2ckF3MDV5VXNzV3VWQml6R1U3NmxTWVdneWZGZGRmZGdrdXR2cytRSHhy?= =?utf-8?B?K2tMaHZxazFsVHN0MWx0OTJiV3BNT3o5bHJGbk91Q3JaelFUQmxxTCtjZEF5?= =?utf-8?B?MGVEeks2OXZ2TGZqTXAveEhSdlRWMWJNSFg3Y2pKa3V5TmdCSVBqaW5qQlhH?= =?utf-8?B?UzZzaFhtTWJFRzlLYkdKUVA1OXdDZkwxbFE5MEZzS3B4bjFGMUxvc082a0Iz?= =?utf-8?B?cUxUN3p5V0xlc2FvZU0wREZlejZRa1FjR3lFYjRzS2xySSswT3FjUWdTWTlz?= =?utf-8?B?WnFQTDZyUDhjSjN4WkhBWTk5Q3UxVEJnR3RYS0VSb3l5STMzamlyeVpQQ21F?= =?utf-8?B?eVdZYnJBNnNBcFBuM3FCakpNTThsS1IyWFpIc0hBZTQ2UFRMWkozbWd1UzBB?= =?utf-8?B?NHp6aXBOYUxMaXg0OWF1MDJ6MVlLM0NaRUc0Um5jcDdEUHZlTzdOcGE3N1hu?= =?utf-8?B?VHgwZUxlcVgyYUZwRkNuTmtscmI5SHdhWGxhYlZZbXM5TWVMUG9OOUwzYjI1?= =?utf-8?B?MmI0NXNPY0RoczVnK2pTNHFBSHIzSmluVnRXUEZuaDRScjRyMjVBazRzR2lF?= =?utf-8?B?YVdZQTNjRGFUUUQ1dnBSUjJpUm93UEhmeEhxZkJ5ZWtQSHk1ZGF0ZS9mNE5E?= =?utf-8?B?SHQzQVhwaU5pUFpCcmg1a3hCRXdhV20vRUV1NzNxRFlISFkveUlEajBRWWww?= =?utf-8?B?aktqSEE3NWFtV1Y2aGJVdFlnOGhRRUhidSsvWDViakd5b1EwMVROWEZRbG5L?= =?utf-8?B?cE1nZFFZVTRUcERuVWFrczlFTTMzMWRUR0ZINkFKUW9PMVJWQ2lLQjNUSDR0?= =?utf-8?B?Nm5jeFdKUXcwR1FXajZqKzNDVUJKL3RCSTEzQzN6WWpIbGIrbDFtc1YwNlN6?= =?utf-8?B?NXF0Mk5zaWRYSWdFUEYwVXAxQ1UvUmFKSEVUbkcwalBwbU1ueWJCNjZNRnhs?= =?utf-8?B?VDcvYmFva1ErMlBTT1hHakNLdFNMSTdtaDZEVnMvQWxGQUZWdHdRYms1WVl5?= =?utf-8?B?aHo1N0MrWUVITDBQUW9naUJkTE9xY1pmcXFtVnVjZDZGNHRXZWkvbDJFV0Q1?= =?utf-8?B?b0NESlljRFE4cWdQZUNtakxhd2x3emtsSkJrMzZoaHV1Qmt6WnB2bk5ERDdU?= =?utf-8?B?L1BtYU84VU85cGo2ZmxyN0RGdTJuKzFzRThIYUlEbGxoMmh1TG91b1AvWGN0?= =?utf-8?B?VTlBZWdKZ0NxTytmS2MrVUI2QVlXc2hIejlUNlhidGR5Y1BseG10b1ZkZ1pN?= =?utf-8?B?bWFTUTE5VzJxWWlTTmp2bUltdENJWjhUTGZUNzZuWCtuUm1INkQrOG9wZ0JU?= =?utf-8?B?a3creTFxNVhBSk5WWC84cFRxRi9mRDJEOW96MndEeGpQWVRoVjlqZDNxMU9G?= =?utf-8?B?dFB2ZWN4dGNRdGNTSGp4aW5FejdNSkc3NGIwWW9RR3dDYkYvRDdScm1xSGVQ?= =?utf-8?B?eHhnRnFDc2V4Yk1iTjM2dHNUMGhtOGVmb2NkTDVhSXVyY2V5SjZ6WXVxNzAy?= =?utf-8?B?amc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TkgiAG+TnV28YRFstmN9ECKMMQDr85K1DTl0Nt8XnAkDybV8cUhp53EkqE+hC2bwpa7/CSiSUqFnDNAMGUzda/T3DKXKr3O6tOkuFGj8pw5ZIQsRxwC22I9629Z3/pLkoVHDsQwhU9E2PvECxBuYh5KoPImO4Z1pyIU90YcFe/sNSEHTANRLYlMiDRoUrCNalBHIAjOdBNW40zuH6bGZhS39jM1QNVXjcskHVV/MNO3rZBidLf7nn9nid7bSbXhEapcLml4/BCdgloiINBe5I+iMMrmwrVqjlp3XYBqiWKf5eiUa5kwioFBiPb69NaoWzzSWw2oF8hG4yyfEsbPZcnUpEE1r/20jfH9opLccSWJbNW52DmCpI+aoNRI527PPeMhOA2bqxca+v9mL4L3a78xLNrmB8ts0lzPxFSfYktPM3B3/M9Q5sTE7qebidC8Z0eI+8u9srNiOd4GbuK93NKtMbzgK7ratRUI9OJ2DgZdefjfEx0uDM1+4uyFdsM1PJUF5jLTN4rEtk+suPKM5aHXRbmruWftR7dnB/3MBvD/EeU6PlEMzkZ1qaupege4dcTcA3Ba/LZYOC4v2nqIp+g6+KEjC0UHD6pm9WxsdXwgLSYV4z1GZdVwf95zNppUgBxOPdxDW/mv9tcEY9+lViftpSuSwblJ0kHe33sWt8Othirh8K52lwlHYK4xa50Gjo4BeGhOHEYyMqnqL8raCFUcmjQWjI6EfyLoyb4GLQxCN9tq/NuEV0MpiRvyij/tIsyumGTLg08uaYOY4BXJ07iCef4ejIlboRoN9qKppSRCkxOfyhuKVixq80TVNmui7X4UvHZCX4uKTLdkz+9yaOA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d6a826a-c229-4eab-b961-08db0f51e82f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 12:41:06.7766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3hTgi/tTBMkBNhiiBvg2N2aCV2/mIoVUfG3HT2EyS8eiYbOuqGDOb5zeeMXA4qqEZrcrlca3dSFIx+HWK70fSjiBhaPhE90Qb/2pVJ90pok= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6198 On 15/02/2023 12:02 pm, Anthony PERARD wrote: > While the Let's Encrypt root certificate ISRG_Root_X1.crt is already > present, openssl seems to still check for the root certificate > DST_Root_CA_X3.crt which has expired. This prevent https connections. > > Removing DST_Root_CA_X3 fix the issue. > > centos: found the filter by looking for "DST Root" in `trust list`. > > Signed-off-by: Anthony PERARD > --- > automation/build/centos/7.2.dockerfile | 5 +++++ > automation/build/centos/7.dockerfile | 5 +++++ > automation/build/debian/jessie-i386.dockerfile | 5 +++++ > automation/build/debian/jessie.dockerfile | 5 +++++ > automation/build/ubuntu/trusty.dockerfile | 5 +++++ > 5 files changed, 25 insertions(+) > > diff --git a/automation/build/centos/7.2.dockerfile b/automation/build/centos/7.2.dockerfile > index 4baa097e31..27244fd002 100644 > --- a/automation/build/centos/7.2.dockerfile > +++ b/automation/build/centos/7.2.dockerfile > @@ -50,3 +50,8 @@ RUN rpm --rebuilddb && \ > bzip2 \ > nasm \ > && yum clean all > + > +# Remove expired certificate that Let's Encrypt certificates used to relie on. rely. And really (to all of these modifications)?  This seems outragously hacky to be deploying into production... Honestly, I think I'd prefer to drop all of these legacy versions... ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 12:43:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 12:43:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495967.766441 (Exim 4.92) (envelope-from ) id 1pSH7j-0005An-90; Wed, 15 Feb 2023 12:42:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495967.766441; Wed, 15 Feb 2023 12:42:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH7j-0005Ag-69; Wed, 15 Feb 2023 12:42:59 +0000 Received: by outflank-mailman (input) for mailman id 495967; Wed, 15 Feb 2023 12:42:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSH7h-0005Aa-8J for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 12:42:57 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062d.outbound.protection.outlook.com [2a01:111:f400:fe1f::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4435939d-ad2e-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 13:42:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8557.eurprd04.prod.outlook.com (2603:10a6:102:214::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 12:42:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 12:42:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4435939d-ad2e-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dsh7bksM21W7LCtR0Q5EpITxuZzzSXQFeZOkpQLfi/Pm8TGiHtfjfM/ySQWq918X72rG+hMrdhwW40royOsBF5OINWSadzr9L3/aan1YQtPK5qO45LLA86QukU8VuHRt2oBT4BAhL8btksOmiLXwm7QONm2cLnXg1uqcVNlCdMBDVvR5DtSpQVSncBFBer4LN7NwlvhD0ibYmTw+OF2U/YSpjt0K7J/EuLs4K9dJnIRXdMvihAkAzPcQ1/32vXU+0ZNu3XhSPijCw9DO/R7V1Pxzh3x+I25+GVK1H8LA3CM7tkq5fj1rK4/rwFacrqyzEqI6zyT462dRKR4uC72b7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GzgKugyULcfMWfiFKQIeuCMTvQaR8HlUPhzFny/tWps=; b=l87SvHgOa6HOMVjyCd6zhLuJFno22wOT515Nh93R1hnSshn6xQ24LeE6gGjYVgrB+ZlEarB7zkUgy/x1pWsUfbfleykZzEwHoJ5qmmcsM2p7hsl+hKZEoSFbYdQrrK8ts7HDzU0Wx9SdcCobUP1fvtRthhG59A2dwUURShxCIUjIPU7CoWRC+ljvUGdz3/lN/ln0qyhwQxWGHfLeKtYc/bW/sRQBPLnkRcFCth58diTVUtPRIY96XG7kzNBdWpuRFEGB3xYk+Y1kKGn+8sIcOHPPapte+x8vrhkkFS6ZraBHXinDfpoxWFibMk1DXyylXi1UyMKXoE+qMQdRR6BWRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzgKugyULcfMWfiFKQIeuCMTvQaR8HlUPhzFny/tWps=; b=qTeX/ZP4QeNUb9WBJFzgBvZOgpkb0yU719T8VauWKmeHB4ybJ+wMgGuZNLs3/irB4uJuSRIdwdgKGJCLzDPugdMR7o4vdAhhGsfAvDO1EBkr6x77Ae+VTbksFVWQK/3OTSD7SFSsqiBB28rHwwQJA/NacChtF5LRnjAX6O+DeLS2grWZd6vomSEFnnU/ceDGkVT0lS42Bx+0wKflrK0XquoigVKir3TXFVeAwmXNfRKNJ5qGyMtGuVnuXL5XHmJSrmjtVE7+lngzjKfeyQTb9r4SWkn816e9nj3mh1km5GlPMHT3pdDVdVzqQpYNPPudz5wdFksvBMsR60ukYlVuqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> Date: Wed, 15 Feb 2023 13:42:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/Xen: tidy xen-head.S Content-Language: en-US To: Juergen Gross Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> From: Jan Beulich In-Reply-To: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8557:EE_ X-MS-Office365-Filtering-Correlation-Id: 20f5d1ed-3733-4afd-2c83-08db0f5225db X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q4Swv2j4YNlptWhbebjbMYFXWSeKIW0OkbjGmep6cOshhIdkiTXueC5b9kGw78sesMW4d2gMb/4h5lTKt5dz5We6XG00fL7TRpZMwMtNdtaKFZDSr+tjfzufs/ypWhkJpXq1dfFAmw++GQXyN4cQimoOrh4SA/LsQrpt+6hKzRGhkkc26dT3ZoMpcepkg6FrrP2WrQCbzZLBmsYCQqQWUK0WbNHTjJw9x6+mrS9Dn9bvIdsFNrwTrLhfeaDTjPyW2b5wdzCTyYNLDTE1M2P/UPQpL/JyYGeI8OEX3/NEDcHTQvWVXoEpiFP6vFfWiT/IAyLR2ZszUZjkh5lUQecNchivb1s7sXeDx/hN6+WeWDz1xfWlraNMbceNxWZ1o7HMSZmPrCV9o4DI7pvtZordZaatfsmR+wFRurJybttzRdlsQSpVYetcBwmcIdegq0LjxUpvgP3VXC6bmCBWGiaGBtr3X+CUFms/BWJRAijKM7fzTCquUjjOiW6CTzR2If4PJPR7QVwlc2ba6X1HYs5g2pO9pLloO4OrTsV2mCi8iO+DLHl+F/8ZlD6wYSp2PdftISxzMF0jnP2UGO0egNkTnok5T1o8D3jIzMet5OCh3tGd3YxP+tsWY9gWRiCsWNCOo9tgq67bl9pOJUcDtMqAAJlOKdDVl8pVXbXHpfMTmsH/O4h9LrKEWlS1o2n1UEJF9eozr3AQW7ZIhQZLT5Gs6KsKVTW/LXe+p5FGfEJ4T0g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199018)(8936002)(6862004)(36756003)(41300700001)(5660300002)(2906002)(478600001)(6486002)(66476007)(4326008)(66556008)(6636002)(8676002)(66946007)(54906003)(316002)(37006003)(38100700002)(31686004)(2616005)(53546011)(6506007)(6512007)(186003)(26005)(86362001)(31696002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXBXUWxWYWg3WXBlTjd2VTg1MFRSUkZVMWNwZ003dEEvUUd5Z0RRS0FVYXo5?= =?utf-8?B?dDF1T2hIVFhVbTJkVGJqbGh3Ui9Jd295cVV4a2pkc0pqWS8wVTRROWU1a0ti?= =?utf-8?B?Mmt5alp4VlpadGd4WUdsSnNvdkVMWlYvQWxhSkxOUkNWRDMrSW9LUUhvYmFh?= =?utf-8?B?cGtKOThDNDM0NUZpdTZCQjJiZE5qeVRBY0JFdXpPZHR6UGJVV0NPZ0lyUy9W?= =?utf-8?B?YTg3UWxiVmltQVQ5bHRuSHg0UzJVeFcyWEtHQUpPQ1FaeWJjdTdIWW82Um16?= =?utf-8?B?QlZWcDgyZlM1NXpHYnJ1VEM4dlQ0Yll1S2J0M1Qxd0hJaTJQbmFpdVdWYzNm?= =?utf-8?B?dGFBVERUUHV3OXh6M1JoMi9UaG0rVitWbmRyM3RWVDJ1djF2Uko3OFBMUjE3?= =?utf-8?B?Vll1Um9FMEk3c0M4OTZibGdITXlEYzFadlhvQlBFTFpUbEFWLzA2bVppWHlk?= =?utf-8?B?VGpJRnFoano5cFlxbTFROFVYWWdEeHlieTUwTlFxeDZyK0dHeVdGb0xTS0E0?= =?utf-8?B?NnJjOGR3aGpIaEFnQ002V1V2U0lBQllmSjFNR1dGRktyVmIxbHNGalVtU2FO?= =?utf-8?B?bk8zcnRBNDMvNmc0OEFLZ0tUd1hsYmtoNEhKMU9aczVYYUpOT1NFZiswa0dI?= =?utf-8?B?dFFzSGxnL1czUGtGalJmcG9vMWpmZEhNbnljZllNNGZHcXQxUWx4aVM2WmlJ?= =?utf-8?B?QzU1bE1zcldTYkE2cGxEZ25XSlRtSlYzWldBMm5nS3VPVEZ1TUZ6a256OXRJ?= =?utf-8?B?ZGZKc0NxbjNSTk9PakJ3SldlaExrVk1LU3ZhN2FMK1prQWJXWVYybkZrU2pr?= =?utf-8?B?bjIzb1loSzJjbkdkSG9jRmlLRytFZUU5NmtYNVFtb1lWdWh6YjduRi9Kc3Rq?= =?utf-8?B?MFF1QkUxNElvSlArWGdJcTF6OEZZclBlV3N2WXZUemtOanAyUjNOUGV1Vmd3?= =?utf-8?B?ZnJNUEhlNXllTHQyYW0xMjA5ZldCM0poWjJDS0EwWERxQVFwL3hkTFlGTk80?= =?utf-8?B?MWRWZUJibDdBZUhWZUZLVXorc243Wk44ZFZMYkU0ZEx5U2FIYkVMeEcyWC9J?= =?utf-8?B?L2E2YTkrVkxpZHRqSjRsdTJvK2orMnp5cSsyQmZXeXdDT2w4US9KQTJKeGVW?= =?utf-8?B?dVNISkU4cXlqcnMzcU5TRCtKdkhPOEk5Qm1ZQy9qOW1aRWlIWnhpc21Nd29r?= =?utf-8?B?VjlKTzBjV1k4ay9RdGRtSXBvc0RJNXptbGRVajdoajBKNVdiVEJIMXBmTVJz?= =?utf-8?B?aEN0Vjc3eWJ2cG1jRkQxSGhCVytCSG9RcUE3bk9QVi9JV0lYMlFJaU1NLzhp?= =?utf-8?B?Z0ZzS25uSmRBM0NZL0xRaFUyNXpHYnNYOEx0cWdIeUI2WFNqRVR5dTBsNGVa?= =?utf-8?B?eUVRd09xMERmd1lCem1RdE9TdHFMMDZPR1hrT3NnVUpPSEk4dlNFSmo0Mnl2?= =?utf-8?B?OGFXZ1VkMUhYQlpPYy84SW1BZStCcGJpZnVMZUM5TWhVZVRwY2U5SjZtV2ZU?= =?utf-8?B?SFBocWJqSXFmdkg1OFJ4VjFVcm4vVk12NGY1UndEY1F6ZlRleTFRTUVkUVZJ?= =?utf-8?B?WDh2bHVVS21jK1RFY2VXczRPWURJMHFKMmVLWFlSYU1XUjc5Qk16T0d3OEJ1?= =?utf-8?B?NTZReW9uK1JTbDRPSm1UeFl4azVWZHkwS0liVitxdFFHOUhVajBIRGIzclp3?= =?utf-8?B?SS83MGVVVFcyK0ptd3hjb3N0OEpQSDF3VUdwdW1NODkzTVhhcStpTlZLY2VO?= =?utf-8?B?RWpZVGNiQ29jSVBZZ2xjSFJKL2lCK1BrNlJnc1Z1Q0VoSXJNYnlZQVAxTkJo?= =?utf-8?B?bkY1N3dnS3J0TWJMMVhweUFNK1lnUjNmTHdoRUpzTFhCN3VpVlY2SmN2Zkdt?= =?utf-8?B?MGNkVjJrS1VMNXQyMk9VcXM1enZsMVh3czc4M2VJTVdMbzB6RmdwTEhkeTYr?= =?utf-8?B?YjM1U3ZVUU9pRDF6emdoeWhpazg3eEs5Q04zbjhyOHIrUXNPZXF1bi91MVc3?= =?utf-8?B?NWh3VzZBV0IyNUZEUWFTVnM0Qk9tNThhT21KTEQ5S3cxSlZ5aHYzN1ZPSkk0?= =?utf-8?B?SktWODl6T0NhaENaZHNLUDdDeEY5NjZMaHNIVHdqTmlxTlIydWhPa1ZKSUdp?= =?utf-8?Q?ZIpVPigzJu3XbG4vQuZSvNcuG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f5d1ed-3733-4afd-2c83-08db0f5225db X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 12:42:50.3506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yNlzepQKemKMT8L8QhDgVRjEOXwAipkPIAH+Rw3HQSDEzS1nb//5ogyTVkl6y25JHzc2Xcnq/j6ZBVzc3HJJ9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8557 On 15.02.2023 13:05, Juergen Gross wrote: > On 15.02.23 12:33, Jan Beulich wrote: >> First of all drop 32-bit leftovers, including the inclusion of the file >> from head_32.S. > > I don't see why we would want to drop 32-bit HVM and PVH support. HVM doesn't use this, does it? But yes, the PVH aspect as well as ... >> --- a/arch/x86/kernel/head_32.S >> +++ b/arch/x86/kernel/head_32.S >> @@ -524,8 +524,6 @@ __INITRODATA >> int_msg: >> .asciz "Unknown interrupt or fault at: %p %p %p\n" >> >> -#include "../../x86/xen/xen-head.S" >> - > > This is wrong for non-PV cases. ... this and ... >> --- a/arch/x86/xen/xen-head.S >> +++ b/arch/x86/xen/xen-head.S >> @@ -83,27 +83,33 @@ SYM_CODE_END(asm_cpu_bringup_and_idle) >> ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS, .asciz "linux") >> ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION, .asciz "2.6") >> ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION, .asciz "xen-3.0") >> -#ifdef CONFIG_X86_32 >> - ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE, _ASM_PTR __PAGE_OFFSET) >> -#else >> ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE, _ASM_PTR __START_KERNEL_map) > > This will be wrong for 32-bit guests now. I'm not sure the value is really > used in Xen for non-PV guests, though. > >> /* Map the p2m table to a 512GB-aligned user address. */ >> ELFNOTE(Xen, XEN_ELFNOTE_INIT_P2M, .quad (PUD_SIZE * PTRS_PER_PUD)) > > Move this under the CONFIG_PV umbrella? ... these occurred to me over lunch (and I was hoping to be able to point out my mistake before getting feedback). I'll check whether VIRT_BASE can also be moved into the PV-only section. >> -#endif >> #ifdef CONFIG_XEN_PV >> ELFNOTE(Xen, XEN_ELFNOTE_ENTRY, _ASM_PTR startup_xen) >> + ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, .ascii "!writable_page_tables") >> + ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE, .asciz "yes") >> + ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >> + .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >> +# define FEATURES_PV (1 << XENFEAT_writable_page_tables) >> +#else >> +# define FEATURES_PV 0 >> +#endif >> +#ifdef CONFIG_XEN_PVH >> +# define FEATURES_PVH (1 << XENFEAT_linux_rsdp_unrestricted) >> +#else >> +# define FEATURES_PVH 0 >> +#endif >> +#ifdef CONFIG_XEN_DOM0 >> +# define FEATURES_DOM0 (1 << XENFEAT_dom0) >> +#else >> +# define FEATURES_DOM0 0 >> #endif >> ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR hypercall_page) >> - ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, >> - .ascii "!writable_page_tables|pae_pgdir_above_4gb") >> ELFNOTE(Xen, XEN_ELFNOTE_SUPPORTED_FEATURES, >> - .long (1 << XENFEAT_writable_page_tables) | \ >> - (1 << XENFEAT_dom0) | \ >> - (1 << XENFEAT_linux_rsdp_unrestricted)) >> - ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE, .asciz "yes") >> + .long FEATURES_PV | FEATURES_PVH | FEATURES_DOM0) >> ELFNOTE(Xen, XEN_ELFNOTE_LOADER, .asciz "generic") >> - ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >> - .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >> ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1) >> ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN, .long 1) >> ELFNOTE(Xen, XEN_ELFNOTE_HV_START_LOW, _ASM_PTR __HYPERVISOR_VIRT_START) > > Are XEN_ELFNOTE_MOD_START_PFN and XEN_ELFNOTE_HV_START_LOW really relevant > for the non-PV case? I don't think so (in theory XEN_ELFNOTE_MOD_START_PFN > could be used, but the main reason for its introduction was PV guests IIRC). I wasn't sufficiently certain for MOD_START_PFN, so I'd prefer to leave it untouched for now. HV_START_LOW might be 32-bit PV only really; I'll check and then maybe drop (or move). Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:12:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:12:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495976.766451 (Exim 4.92) (envelope-from ) id 1pSHa5-0000xO-Jz; Wed, 15 Feb 2023 13:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495976.766451; Wed, 15 Feb 2023 13:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHa5-0000xH-HF; Wed, 15 Feb 2023 13:12:17 +0000 Received: by outflank-mailman (input) for mailman id 495976; Wed, 15 Feb 2023 13:12:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHa4-0000xB-U7 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 13:12:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d8bc685-ad32-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 14:12:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 954683374C; Wed, 15 Feb 2023 13:12:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5DF77134BA; Wed, 15 Feb 2023 13:12:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yx+PFS7a7GNfYAAAMHmgww (envelope-from ); Wed, 15 Feb 2023 13:12:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d8bc685-ad32-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676466734; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WW3CkzIoCelqAvWGFEBSJwPtQA1X78KrOWrnQKdSl1w=; b=HQ9zfgh+LELNczxjQa1+NVz2u27oK/X8SCV+u66FjDR6N9u/q6YacaiI5B2jOhdGUnfvp3 JV2W7rpDIK8pqDNuIimNEfmaubEoSJEQeyzYngKhVJ5cb1QUvOFtyxZMOw2uxrVTbtFoTV seiesls3446mFQx7SBWzWD+EmpSc7S0= Message-ID: <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> Date: Wed, 15 Feb 2023 14:12:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Jan Beulich Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> From: Juergen Gross Subject: Re: [PATCH] x86/Xen: tidy xen-head.S In-Reply-To: <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------vh3ERJFV18yn0IIe9AePDRc0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------vh3ERJFV18yn0IIe9AePDRc0 Content-Type: multipart/mixed; boundary="------------uoqHR8xCxFteZmfr1QonQzwL"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" Message-ID: <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> Subject: Re: [PATCH] x86/Xen: tidy xen-head.S References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> In-Reply-To: <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> --------------uoqHR8xCxFteZmfr1QonQzwL Content-Type: multipart/mixed; boundary="------------eXg10UHi9wcLx5whCDmcesZG" --------------eXg10UHi9wcLx5whCDmcesZG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDIuMjMgMTM6NDIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxNS4wMi4yMDIz IDEzOjA1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTUuMDIuMjMgMTI6MzMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IEZpcnN0IG9mIGFsbCBkcm9wIDMyLWJpdCBsZWZ0b3Zl cnMsIGluY2x1ZGluZyB0aGUgaW5jbHVzaW9uIG9mIHRoZSBmaWxlDQo+Pj4gZnJvbSBoZWFk XzMyLlMuDQo+Pg0KPj4gSSBkb24ndCBzZWUgd2h5IHdlIHdvdWxkIHdhbnQgdG8gZHJvcCAz Mi1iaXQgSFZNIGFuZCBQVkggc3VwcG9ydC4NCj4gDQo+IEhWTSBkb2Vzbid0IHVzZSB0aGlz LCBkb2VzIGl0PyBCdXQgeWVzLCB0aGUgUFZIIGFzcGVjdCBhcyB3ZWxsIGFzIC4uLg0KDQpo eXBlcmNhbGxfcGFnZSBpcyBsb2NhdGVkIGluIHhlbi1oZWFkLlMuDQoNCj4gDQo+Pj4gLS0t IGEvYXJjaC94ODYva2VybmVsL2hlYWRfMzIuUw0KPj4+ICsrKyBiL2FyY2gveDg2L2tlcm5l bC9oZWFkXzMyLlMNCj4+PiBAQCAtNTI0LDggKzUyNCw2IEBAIF9fSU5JVFJPREFUQQ0KPj4+ ICAgIGludF9tc2c6DQo+Pj4gICAgCS5hc2NpeiAiVW5rbm93biBpbnRlcnJ1cHQgb3IgZmF1 bHQgYXQ6ICVwICVwICVwXG4iDQo+Pj4gICAgDQo+Pj4gLSNpbmNsdWRlICIuLi8uLi94ODYv eGVuL3hlbi1oZWFkLlMiDQo+Pj4gLQ0KPj4NCj4+IFRoaXMgaXMgd3JvbmcgZm9yIG5vbi1Q ViBjYXNlcy4NCj4gDQo+IC4uLiB0aGlzIGFuZCAuLi4NCj4gDQo+Pj4gLS0tIGEvYXJjaC94 ODYveGVuL3hlbi1oZWFkLlMNCj4+PiArKysgYi9hcmNoL3g4Ni94ZW4veGVuLWhlYWQuUw0K Pj4+IEBAIC04MywyNyArODMsMzMgQEAgU1lNX0NPREVfRU5EKGFzbV9jcHVfYnJpbmd1cF9h bmRfaWRsZSkNCj4+PiAgICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0dVRVNUX09TLCAg ICAgICAuYXNjaXogImxpbnV4IikNCj4+PiAgICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RF X0dVRVNUX1ZFUlNJT04sICAuYXNjaXogIjIuNiIpDQo+Pj4gICAgCUVMRk5PVEUoWGVuLCBY RU5fRUxGTk9URV9YRU5fVkVSU0lPTiwgICAgLmFzY2l6ICJ4ZW4tMy4wIikNCj4+PiAtI2lm ZGVmIENPTkZJR19YODZfMzINCj4+PiAtCUVMRk5PVEUoWGVuLCBYRU5fRUxGTk9URV9WSVJU X0JBU0UsICAgICAgX0FTTV9QVFIgX19QQUdFX09GRlNFVCkNCj4+PiAtI2Vsc2UNCj4+PiAg ICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX1ZJUlRfQkFTRSwgICAgICBfQVNNX1BUUiBf X1NUQVJUX0tFUk5FTF9tYXApDQo+Pg0KPj4gVGhpcyB3aWxsIGJlIHdyb25nIGZvciAzMi1i aXQgZ3Vlc3RzIG5vdy4gSSdtIG5vdCBzdXJlIHRoZSB2YWx1ZSBpcyByZWFsbHkNCj4+IHVz ZWQgaW4gWGVuIGZvciBub24tUFYgZ3Vlc3RzLCB0aG91Z2guDQo+Pg0KPj4+ICAgIAkvKiBN YXAgdGhlIHAybSB0YWJsZSB0byBhIDUxMkdCLWFsaWduZWQgdXNlciBhZGRyZXNzLiAqLw0K Pj4+ICAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfSU5JVF9QMk0sICAgICAgIC5xdWFk IChQVURfU0laRSAqIFBUUlNfUEVSX1BVRCkpDQo+Pg0KPj4gTW92ZSB0aGlzIHVuZGVyIHRo ZSBDT05GSUdfUFYgdW1icmVsbGE/DQo+IA0KPiAuLi4gdGhlc2Ugb2NjdXJyZWQgdG8gbWUg b3ZlciBsdW5jaCAoYW5kIEkgd2FzIGhvcGluZyB0byBiZSBhYmxlIHRvIHBvaW50DQo+IG91 dCBteSBtaXN0YWtlIGJlZm9yZSBnZXR0aW5nIGZlZWRiYWNrKS4gSSdsbCBjaGVjayB3aGV0 aGVyIFZJUlRfQkFTRSBjYW4NCj4gYWxzbyBiZSBtb3ZlZCBpbnRvIHRoZSBQVi1vbmx5IHNl Y3Rpb24uDQoNClRoYW5rcy4NCg0KPiANCj4+PiAtI2VuZGlmDQo+Pj4gICAgI2lmZGVmIENP TkZJR19YRU5fUFYNCj4+PiAgICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX0VOVFJZLCAg ICAgICAgICBfQVNNX1BUUiBzdGFydHVwX3hlbikNCj4+PiArCUVMRk5PVEUoWGVuLCBYRU5f RUxGTk9URV9GRUFUVVJFUywgICAgICAgLmFzY2lpICIhd3JpdGFibGVfcGFnZV90YWJsZXMi KQ0KPj4+ICsJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX1BBRV9NT0RFLCAgICAgICAuYXNj aXogInllcyIpDQo+Pj4gKwlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfTDFfTUZOX1ZBTElE LA0KPj4+ICsJCS5xdWFkIF9QQUdFX1BSRVNFTlQ7IC5xdWFkIF9QQUdFX1BSRVNFTlQpDQo+ Pj4gKyMgZGVmaW5lIEZFQVRVUkVTX1BWICgxIDw8IFhFTkZFQVRfd3JpdGFibGVfcGFnZV90 YWJsZXMpDQo+Pj4gKyNlbHNlDQo+Pj4gKyMgZGVmaW5lIEZFQVRVUkVTX1BWIDANCj4+PiAr I2VuZGlmDQo+Pj4gKyNpZmRlZiBDT05GSUdfWEVOX1BWSA0KPj4+ICsjIGRlZmluZSBGRUFU VVJFU19QVkggKDEgPDwgWEVORkVBVF9saW51eF9yc2RwX3VucmVzdHJpY3RlZCkNCj4+PiAr I2Vsc2UNCj4+PiArIyBkZWZpbmUgRkVBVFVSRVNfUFZIIDANCj4+PiArI2VuZGlmDQo+Pj4g KyNpZmRlZiBDT05GSUdfWEVOX0RPTTANCj4+PiArIyBkZWZpbmUgRkVBVFVSRVNfRE9NMCAo MSA8PCBYRU5GRUFUX2RvbTApDQo+Pj4gKyNlbHNlDQo+Pj4gKyMgZGVmaW5lIEZFQVRVUkVT X0RPTTAgMA0KPj4+ICAgICNlbmRpZg0KPj4+ICAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5P VEVfSFlQRVJDQUxMX1BBR0UsIF9BU01fUFRSIGh5cGVyY2FsbF9wYWdlKQ0KPj4+IC0JRUxG Tk9URShYZW4sIFhFTl9FTEZOT1RFX0ZFQVRVUkVTLA0KPj4+IC0JCS5hc2NpaSAiIXdyaXRh YmxlX3BhZ2VfdGFibGVzfHBhZV9wZ2Rpcl9hYm92ZV80Z2IiKQ0KPj4+ICAgIAlFTEZOT1RF KFhlbiwgWEVOX0VMRk5PVEVfU1VQUE9SVEVEX0ZFQVRVUkVTLA0KPj4+IC0JCS5sb25nICgx IDw8IFhFTkZFQVRfd3JpdGFibGVfcGFnZV90YWJsZXMpIHwgICAgICAgXA0KPj4+IC0JCSAg ICAgICgxIDw8IFhFTkZFQVRfZG9tMCkgfCAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4+ IC0JCSAgICAgICgxIDw8IFhFTkZFQVRfbGludXhfcnNkcF91bnJlc3RyaWN0ZWQpKQ0KPj4+ IC0JRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX1BBRV9NT0RFLCAgICAgICAuYXNjaXogInll cyIpDQo+Pj4gKwkJLmxvbmcgRkVBVFVSRVNfUFYgfCBGRUFUVVJFU19QVkggfCBGRUFUVVJF U19ET00wKQ0KPj4+ICAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVfTE9BREVSLCAgICAg ICAgIC5hc2NpeiAiZ2VuZXJpYyIpDQo+Pj4gLQlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVf TDFfTUZOX1ZBTElELA0KPj4+IC0JCS5xdWFkIF9QQUdFX1BSRVNFTlQ7IC5xdWFkIF9QQUdF X1BSRVNFTlQpDQo+Pj4gICAgCUVMRk5PVEUoWGVuLCBYRU5fRUxGTk9URV9TVVNQRU5EX0NB TkNFTCwgLmxvbmcgMSkNCj4+PiAgICAJRUxGTk9URShYZW4sIFhFTl9FTEZOT1RFX01PRF9T VEFSVF9QRk4sICAubG9uZyAxKQ0KPj4+ICAgIAlFTEZOT1RFKFhlbiwgWEVOX0VMRk5PVEVf SFZfU1RBUlRfTE9XLCAgIF9BU01fUFRSIF9fSFlQRVJWSVNPUl9WSVJUX1NUQVJUKQ0KPj4N Cj4+IEFyZSBYRU5fRUxGTk9URV9NT0RfU1RBUlRfUEZOIGFuZCBYRU5fRUxGTk9URV9IVl9T VEFSVF9MT1cgcmVhbGx5IHJlbGV2YW50DQo+PiBmb3IgdGhlIG5vbi1QViBjYXNlPyBJIGRv bid0IHRoaW5rIHNvIChpbiB0aGVvcnkgWEVOX0VMRk5PVEVfTU9EX1NUQVJUX1BGTg0KPj4g Y291bGQgYmUgdXNlZCwgYnV0IHRoZSBtYWluIHJlYXNvbiBmb3IgaXRzIGludHJvZHVjdGlv biB3YXMgUFYgZ3Vlc3RzIElJUkMpLg0KPiANCj4gSSB3YXNuJ3Qgc3VmZmljaWVudGx5IGNl cnRhaW4gZm9yIE1PRF9TVEFSVF9QRk4sIHNvIEknZCBwcmVmZXIgdG8gbGVhdmUgaXQNCj4g dW50b3VjaGVkIGZvciBub3cuIEhWX1NUQVJUX0xPVyBtaWdodCBiZSAzMi1iaXQgUFYgb25s eSByZWFsbHk7IEknbGwgY2hlY2sNCj4gYW5kIHRoZW4gbWF5YmUgZHJvcCAob3IgbW92ZSku DQoNCkZpbmUgd2l0aCBtZS4NCg0KDQpKdWVyZ2VuDQo= --------------eXg10UHi9wcLx5whCDmcesZG Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------eXg10UHi9wcLx5whCDmcesZG-- --------------uoqHR8xCxFteZmfr1QonQzwL-- --------------vh3ERJFV18yn0IIe9AePDRc0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPs2i0FAwAAAAAACgkQsN6d1ii/Ey89 HQf9FQtyCodybGNB/9pp/4ERNSQYa76jFrGFwbh3R7NNHrpLYF5HxQatDCQB06l+mM1SBB13XIXu F+G9NvE1hnf/3Um2AjzQtPUdjkf9dbh8TY2JvKKycdlPgtHKGAfEjWek7KewDUw0QR4xpLkllHN0 f8FPy5taI58tjoOqUsCde0WG0vhEFusNnlSa9J6c8ZBvIXROLKh2LACC7ED/EfOrIL0v5GztF3OD MkbAa3FIYBBY2Her6GtYJomYlxZYBOc+lvCoQYz5Ax7PSgnDL2CDPZ2xbUzQpHx92h1i9dgVs3IK ZEKr7aoW6dBUdPm3gNuuR7j+c473OCSNKEfV0Qy58w== =nzYt -----END PGP SIGNATURE----- --------------vh3ERJFV18yn0IIe9AePDRc0-- From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:25:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:25:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495982.766463 (Exim 4.92) (envelope-from ) id 1pSHn4-0002mZ-Pc; Wed, 15 Feb 2023 13:25:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495982.766463; Wed, 15 Feb 2023 13:25:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHn4-0002mS-Md; Wed, 15 Feb 2023 13:25:42 +0000 Received: by outflank-mailman (input) for mailman id 495982; Wed, 15 Feb 2023 13:25:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHn3-0002mM-An for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 13:25:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a440081-ad34-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 14:25:36 +0100 (CET) Received: from mail-mw2nam12lp2049.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 08:25:33 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5175.namprd03.prod.outlook.com (2603:10b6:610:a1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 13:25:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 13:25:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a440081-ad34-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676467536; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=GZZg7f+Ds8eA7h90zdUJ2z9W2h0pzBtjARPRyk3QaL0=; b=CaTp9evaNMiXtAoKi1w/FuSkz9ePdAIk+crGFeRwvs/26u1kgkzkWap4 zT1mzX0FuqmkewITJMfdiY4PI4Mc/w351DVTaKlBmLaU6oJJdnDWCMQRP pwRy6iBfX4XQNzdkxOW98mjGQxgdgZi3yAaafCIC0aN9Cj+CgF/f3KxaO w=; X-IronPort-RemoteIP: 104.47.66.49 X-IronPort-MID: 97147588 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZsuikKpAIxFzyTk/LhP4L8n9lk9eBmK1ZBIvgKrLsJaIsI4StFCzt garIBnVO/6OMWP9Lthyat/g9hsOuJ7WxoJkHAs4+30zRC9HopuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADkhcSuIneWE+pSiaO9mq99zMujxBapK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIu9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOznr6I13Q3DroAVIAEfaWSWs6PmsXCjWdJHa H5E9CEeobdnoSRHSfG4BXVUukWsvBEGXMFLO/Yn8wzLwa3Riy6bDGUZSj9KaPQ9qdQ7Azct0 zehldTzBCcpt6aJU3WD7bSFhTSoMCMRICkJYipsZRtVvfHgrZs1gxaJScxseIapgdnlMTXxx S2Wti84hqVVgcNj/6C6+1/AqyihqpjAUkg+4QC/dmi9xgp9ZYOjN8qk5DDz4f9eIcCZR1+as X4sn8mY8fBIDJeRmSjLS+IIdJm56vDAPDDCjFpHG5g66y/r63OlZZpX4jx1OAFuKMlsRNPyS ErauAcU4YAJOnKvNPVze9jpV5VsyrX8H9P4UPySdsBJfpV6aA6A+mdpeFKU2Gfu1kMrlMnTJ KumTCplNl5CYYwP8dZ8b7x1PWMDrszm+V7ueA== IronPort-HdrOrdr: A9a23:6uwwealru5tzy4gBI7Moe2uJVezpDfLk3DAbv31ZSRFFG/Fw9v re4cjzsCWetN9/Yh8dcLy7VZVoAkm9yXcN2/h2AV76ZniehILKFuBfBOnZskfd8kTFn4Y26U 4HSdkENDSaNzdHZKjBjDVQXOxQo+WvweSEieLf0Ht3XWhRGsRdB2AQMHfiLqTafngjOXN8Lu v62uNX4z6tY24eYMiYCmltZZmgm+H2 X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97147588" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwjoeyuZ7Xdt4HVkp+fFlgcuqPAOwvgO9yMf4I1xGnj62kfflVYfADOphrPkMEPJ/zZVdOd15TFA1MQ8hsj/Ik7qgJvjegvAfYK5k0dUepfu1CHBh4BmhXt3wcXJs8+Tm79L7HeXLg5BpU2xpAldxtpKFyrlDgO5DCrJ5UQIaluDFFSy0J8uSB+b3JbGyUe6erMJ/j5yHTsFNPDyk9K49pXi2kXO3fTEzbizb5L/FHQF5eui+y8iM6dJdztbaUUPL4zUwGXtt3jCG7lSLxyN+Pr72vaVo7L8Ei1re/bLz2voYMopHqhQBxtQrrGU+V4NeweoEoVvMpiVs6vK8ZNZBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GZZg7f+Ds8eA7h90zdUJ2z9W2h0pzBtjARPRyk3QaL0=; b=Le/e/s+ItMUxJH3Q4Tbd9mYjSwVX5bX7QhzhwUY0wiPWun9YGFj0yVpgKubx0Bw0IYq1vS4iKDCbKJ/4nzXFx9Ir3aSLywO1BSyn5scUTyfAE9qkdemY2z5AuveTgyIB3x4Nsqc74/gRDwx/HDlLwq51poi/LNAJlMsB3wZDqhcb66a34LTuZoKREnDqPzcde4wVwp+JCBhbjcn3Q8dhdHWitigzVxN+OM6ZZX19ne/2rJv+dxVLed93Wh6eD+xj6dUqhnrVkkgv4NZ0S0FQj62YS/ZL3wRQ3KTzosO4LFBIQ6r2RTyTjhOGSoRfS1zLBcdaLeD9FLWoAdL/Nov9ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZZg7f+Ds8eA7h90zdUJ2z9W2h0pzBtjARPRyk3QaL0=; b=hKw6KcOlDzST+sM5tJQ+QOJUoeUsd00GPPhKT3DxT05BquL9OC8yr0BY9qIKLeWTamC+ET/R76Fm6ZaDkdPiKk323s+3KHWk2ItLqbExtFlCgRcthX7cZKQ9prE/PGIpXR3zek1Hr+X9WesVdchYpmpQ0ylJdYrCSdksZk7HHMQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6b0b2163-a8fd-4eaa-2219-972c02aa6e49@citrix.com> Date: Wed, 15 Feb 2023 13:25:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] x86/Xen: tidy xen-head.S Content-Language: en-GB To: Juergen Gross , Jan Beulich Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> From: Andrew Cooper In-Reply-To: <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0394.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH2PR03MB5175:EE_ X-MS-Office365-Filtering-Correlation-Id: 67042ab8-ba85-41be-a142-08db0f581c62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dz9bKiTECnuOIBPwzIxRVENMl0PDYojVNK5Fyv3gdoDyFyFx2Cn5QmG/bSPyqaG7H/iyH2aHREL4h/iOGk2hLe6BYwoa690fPwEktI196H6DU/sVU9K8iT4QMouIajsC438aJtuJA3WsnCdKp47eScZZdgOnNAWhKJs4SLFMGO7kCLuFwkUJoZLgjVjFPd7+vX7TBHHHbVMgWXNfcCXvPnGOMPVrLple+9jlYfXlyOT2uSf1P4FBvm/bwL4B4RLQTtEJtP5Er9hl+a/yJ1q/iKi6N48WmlJoQ9fNMOg3Fi3n7giQm40SwBqsl4hy4ds2DduZHWnY/JQdfxwEks7pi1E1TA5fXwamazlnKlqyF/fuJaE/wQBTFMZjkoOkf8JUv7fLN/R3le+e0f56s48DKYzpBBh8TF6EZo9wM3PLKj3BMiBEhf2/ljjQY2eIC8UlGJD48OftuwI7h3UWiJXgRFEBzkRHf/kmXkvmnG8ykSeq84bSuQfKQwPeice25gdqAr5N5R5WS3KG3oNWHRdZg4wHHFlMw5TUApFhsw1S8c16K7l/TN3hHMjrlNwAplHZ22Q628FMG3SiAZQhXVQl1d1qd0UHTF2YNDHeirrf2DaKjuluzUaFmWThAWTSjhit6jVaj3z3OjtVRFH333w36hu8lUCEHSWO+KuCg+jiSwxB5G1y30IUSEv9ro50Zo4eSWiUkagRG9cU7sBWsLGfpuNGvBRpiO7ikdFSCj1iqrg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199018)(38100700002)(6486002)(8936002)(5660300002)(478600001)(41300700001)(82960400001)(36756003)(2906002)(26005)(6506007)(2616005)(6666004)(186003)(6512007)(31686004)(53546011)(316002)(86362001)(4326008)(66946007)(66476007)(83380400001)(66556008)(8676002)(54906003)(31696002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z005ZE05ZU9YVVRHbnIvcXBWbGlaU3prSVdKNVkrUWR2Z0pjWXhXb1pJWTZo?= =?utf-8?B?cHhBWTRKZUthQ3k3SGFWWWRDTmZQZWkzaTVpMTE3enBPOWFjTzBsTks3RkE3?= =?utf-8?B?NkFOSmZCbXcyMUFhM1FPRWowRkpYT24yL1kyaE5vcS9OY1RjU3RvcmloeW1N?= =?utf-8?B?ZHhoM3FMbHY2dUFUcEx5QkhOODNSUFNwWS9mK1EvMk1xYVN4VFJXaEx6RlpV?= =?utf-8?B?NjNIL0ExWTBmcjcxNU43aUIyakR3MHpwNXkwUXVaS1djZVRVcXQxWWNYbGRj?= =?utf-8?B?UU5ndHpldmpKQTl2ZmdDTmJtTW5UQ3d6TzljbUE3Y09XcXRGaHBKWmk5ZTIr?= =?utf-8?B?V1hyRjhYWW5uSDhPY09QaFVVdGNUUzhBNnJrK1BzZ0ZpNjZWMEpkR3hwNVUw?= =?utf-8?B?djQ0aS9qL0o1cUdlQ0tYb2F1M01yVmN4MmRESGoxNWQ3L3UvU29sb1dyekt3?= =?utf-8?B?eTFjMWtLSGNmRkl6Q3JLQ0NMREo1YUdHbmRYZ1kydHF4b3lPZ01kdXl6UFhQ?= =?utf-8?B?eXJwN1RLdS9CTXZkUDZWbnUzakFrREJXQkNTdnNzMmdORmlvU3lDc0ZValgv?= =?utf-8?B?WWFPSGRPQXo2OW5FekFURkYrSlVWdmdoV2ZGZ1FTRU1LSTMwOE1kYU1GV3NV?= =?utf-8?B?RG80M3JaNzg3TGRxa2xPYjVHY1RTT0FQbmdZeHlGSnl6RmR3UDIwZTZGRytB?= =?utf-8?B?NFdZbk9SdHB4ZWp4ZllCcEtyTUJzZmRaenF3WU5aSjJsbkNTLzdLUTh0TnNH?= =?utf-8?B?blJpRnNQWWpiTzdHcTRHNjRmQXJTckVxUlNxWnh6THRrWFVSZmppYjlVbFQ4?= =?utf-8?B?V1V6TDFlTXlwOEhqRUdiTGNUYmp1UkNYTlFGVHMzWlFERmZCNXpBRHdaK2pV?= =?utf-8?B?bE1sSjg5b0d4Z0czUEdmNlhuTXZzQ2t2eGE5enpETXBDazZMUVo1alNDUkZU?= =?utf-8?B?SDJKd2dnd3BsWHQ4bUFjVE04WmY1TzBDN3U3ZDE2c2hwNnFPV0dYL1Q3YmJL?= =?utf-8?B?Q3YwdkdFUjZZa0JCMSt3US9iWWNYVjUweGo4M0FCUW5Ld3dIa21mNkJwT1Uw?= =?utf-8?B?RHQ4T0RMSDFCUUMyKzdhOW0rcDlFamlJWnovMGdLWHJCVDBaQXp2ZzBXU0gw?= =?utf-8?B?ZXl6aDEveFpzU0gvdmFNZDk4dXBvN0xDSXVyejdKc0doK01iYkpCZGlJbnlH?= =?utf-8?B?NWxvT3c5eERQTFV3VlZkZm1XZUhpNm5NZWNxeXVoTUpGMmJISDNYclJMQ0VH?= =?utf-8?B?T3UvY3JaRXBUVEFoZHl2cWsrbVdZc0JwK0hrRlJCd21SejV2aHQrMENsd1BY?= =?utf-8?B?UUs2Vm9ld0JEcTdRb0tXckZSbFFRUWd6SHR5NGpDRm5DNERmQUVKTjNtcDFx?= =?utf-8?B?bWZaQWttR1RQUytTb2xja0xhdmR5dSt2NWhwdnV6QWNQTDBUYThSR0tIMkZK?= =?utf-8?B?NFhIQ2MvSlhMSlpjeFJCcEx3TmpYbFBKckw0ZG0rSlJCQThkS0YveVhRd2JT?= =?utf-8?B?MUdTbGVwT1Y1SEFKSWlsVk9hUnEyc3hPVVhBMlJzaTV0VjluejBjU1B0RFZ0?= =?utf-8?B?M0VkZ0MxYW1oNGZ2UDJBQVRBOFdFUlRxOWRtTGk3SjJUNUtPa3ZpdnJHRUFT?= =?utf-8?B?UDl3TDhpSDc2RC9BNFllQXBpTDF0djR2ZlhOa2JzL2xnM0taOVlyM0V5NUMr?= =?utf-8?B?TTBITk9QSDJsRWJpZVlJWjNvSnM4czVSN0lKbHQ3NStLQ2w2M25qVXlyRnRw?= =?utf-8?B?Y3J0LzZPNDlyd0V4Y2NQSU04UHpKc1NGa3BjV3VSN0VVNDd4YWFuKzd0OFY3?= =?utf-8?B?VEJyQ0ZLRmhTcTRiZjBSd3ZuMzgzVm42TVBRRk1WR09COHlZeFkrTFc0K2Jx?= =?utf-8?B?MlF1U3l4RFc5MHJvK3h6QTBZcVdDQ0dYUHg4cjE0MnZsalhoVzZBSkw3cDFp?= =?utf-8?B?cFpsTlNsZ3JvOWRQSmQxeVpqSUMyMVVoVTVpbng1eHFFMm53eTdKTTRpZTJk?= =?utf-8?B?NWdRWk11Q3ovN29zdzJOeEdBSFYxSFFXamROa0t6MHFkVnNzZURWbUYyak9F?= =?utf-8?B?OGlFcnVpQ1hHSk9vMjE0QzE2enZKT2N1S2tqZmFMVjhpRTVxbTA5dkowaG1K?= =?utf-8?B?aUtobGVEVW0vN09XVHlpaEpmSGNGNEc5MWZ2RS9zd0xWSlRqdFlJWVV0azd1?= =?utf-8?B?UUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?OFFKS3A0cStpQk5rTFFLM3pETmNkaW1BT01UbklYbHo3aUdYOHdXQmQzYjg0?= =?utf-8?B?b3hJa3B1RXNQUTdLVVRVdDdJR3VwTXIyS29LRlBSQVZOeWNFZUpuZVN6WU92?= =?utf-8?B?TXlnR3h2R1NKS0FxUDhseDRZdjBpOG4ySTRYSk5YTUs0anZrTm16YWNJN2J3?= =?utf-8?B?a2NTWGYrbzhUTTZBOXpGczloNEZUM3V0c2ppNUc3Vngvb0xsMm5hVFA3NGJG?= =?utf-8?B?R2g2K1kxTk9sdnpjblZrOUV1ekMzNTdZRzd4WVJzTmlOM0pTOS9uaGMrWkhK?= =?utf-8?B?aVNJQVY2SWFRaEZyNUNsTXlETVU2eERUdm53R1FEK0JnTk4rNGI4REQxMEdL?= =?utf-8?B?SXhxTEovK2xuSFFuNGVNOStIOFBrODc3d3BiV2xITGJtTXZwY0ZVUHVTdXpJ?= =?utf-8?B?TmJ3WThDM2k0MFptLzllclNYUlVZQVZvVHdPY1l1OFY4UldnalZNL05ybFR6?= =?utf-8?B?NCsvNGQzbllsWFVkZFRLTzlQZmNEM3oreEZKbHorUHlxUHdhdHJNdjJ6Z1BL?= =?utf-8?B?Mk9uZVo3SXNwbG56ZU9oR0RIZW9KNGdVK05vZ3ZrcWs0SWxTL0k5eXY3MERF?= =?utf-8?B?dyt4Q05FMFhXenRWcEd2enNCTEdIaW4welpPOWNuK2EwYW9pNVFtNDVkRHV1?= =?utf-8?B?OWxxYzdHWE9wYy9lUWNIL3h1cktmcC9PRnBxRjA5UEg3ZitkZVZqWWl4S2h1?= =?utf-8?B?NTZXT0ZBQUZyYXV0M2c2Z2F1M25mazIySzY5UHc1cm5DeFlrWFdtY2lhWGZN?= =?utf-8?B?MldTMmZxcFVDUkpZclYzVnhFak90MnllSXNNMERta3RyZHJBYnU4aUFidnkw?= =?utf-8?B?QktkR1Bwb0V3TXI1L3RUUU1Sa0x5WGQ0MDhSYnZHVHMyYnJsWWJxZVNDQWVn?= =?utf-8?B?S0hiRVM4bk9scmFHMFFqZGhCa1pwZzFCTzJZbnlGcU93VHJ2MDg4SG9oYTY3?= =?utf-8?B?aVBqRjE4NVJaTHpsdzBKN0EzTDNFOStHc3d5RFBidnFQbDRjVlc4UVZ3UG9t?= =?utf-8?B?MWVzcGxDdHdUMkQycnJmVkx5T2VPeTJvcmdia1J0Um96Mm5PQ1NaTzg3aUpv?= =?utf-8?B?b0tMbHdDTSs4WGo5S2hNRGM1Z1Q5NS8zZnFoMHdQNC9ZMmFXc01Bd3lKaTcr?= =?utf-8?B?d0lJZDViSGhCcnZ5SE1UckRzVjVCNGtPQk5EeE15SjBJYnVXdFZFZkF1K3I2?= =?utf-8?B?RndWYWFNTXpBVldDTnJyK281WDRsYmdkblhmeFJwRVBhdUpCWEdZUDhSaHdi?= =?utf-8?B?VXV5dXdkUGgvaUpWM0R6VjNhME1qaENJV1ZkZjJ0SCtUcDFXV2wrZDZLMUtT?= =?utf-8?Q?i5C+DL03xSCOxxx5FS4dqANvf+3gsHMgXK?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67042ab8-ba85-41be-a142-08db0f581c62 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:25:31.2227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: msge2i7v/ML9YCuxAjp2wf+yNIJDh8e3g46KxP90JJBUfUdY+bidKNB8+f1FYYUUC70hWoVBJE3uukShxothvM9c2kugjZKM6G0gHDyyNok= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5175 On 15/02/2023 1:12 pm, Juergen Gross wrote: > On 15.02.23 13:42, Jan Beulich wrote: >> On 15.02.2023 13:05, Juergen Gross wrote: >>> On 15.02.23 12:33, Jan Beulich wrote: >>>> First of all drop 32-bit leftovers, including the inclusion of the >>>> file >>>> from head_32.S. >>> >>> I don't see why we would want to drop 32-bit HVM and PVH support. >> >> HVM doesn't use this, does it? But yes, the PVH aspect as well as ... > > hypercall_page is located in xen-head.S. > >> >>>> --- a/arch/x86/kernel/head_32.S >>>> +++ b/arch/x86/kernel/head_32.S >>>> @@ -524,8 +524,6 @@ __INITRODATA >>>>    int_msg: >>>>        .asciz "Unknown interrupt or fault at: %p %p %p\n" >>>>    -#include "../../x86/xen/xen-head.S" >>>> - >>> >>> This is wrong for non-PV cases. >> >> ... this and ... >> >>>> --- a/arch/x86/xen/xen-head.S >>>> +++ b/arch/x86/xen/xen-head.S >>>> @@ -83,27 +83,33 @@ SYM_CODE_END(asm_cpu_bringup_and_idle) >>>>        ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS,       .asciz "linux") >>>>        ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION,  .asciz "2.6") >>>>        ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION,    .asciz "xen-3.0") >>>> -#ifdef CONFIG_X86_32 >>>> -    ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE,      _ASM_PTR __PAGE_OFFSET) >>>> -#else >>>>        ELFNOTE(Xen, XEN_ELFNOTE_VIRT_BASE,      _ASM_PTR >>>> __START_KERNEL_map) >>> >>> This will be wrong for 32-bit guests now. I'm not sure the value is >>> really >>> used in Xen for non-PV guests, though. >>> >>>>        /* Map the p2m table to a 512GB-aligned user address. */ >>>>        ELFNOTE(Xen, XEN_ELFNOTE_INIT_P2M,       .quad (PUD_SIZE * >>>> PTRS_PER_PUD)) >>> >>> Move this under the CONFIG_PV umbrella? >> >> ... these occurred to me over lunch (and I was hoping to be able to >> point >> out my mistake before getting feedback). I'll check whether VIRT_BASE >> can >> also be moved into the PV-only section. > > Thanks. > >> >>>> -#endif >>>>    #ifdef CONFIG_XEN_PV >>>>        ELFNOTE(Xen, XEN_ELFNOTE_ENTRY,          _ASM_PTR startup_xen) >>>> +    ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .ascii >>>> "!writable_page_tables") >>>> +    ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes") >>>> +    ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >>>> +        .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >>>> +# define FEATURES_PV (1 << XENFEAT_writable_page_tables) >>>> +#else >>>> +# define FEATURES_PV 0 >>>> +#endif >>>> +#ifdef CONFIG_XEN_PVH >>>> +# define FEATURES_PVH (1 << XENFEAT_linux_rsdp_unrestricted) >>>> +#else >>>> +# define FEATURES_PVH 0 >>>> +#endif >>>> +#ifdef CONFIG_XEN_DOM0 >>>> +# define FEATURES_DOM0 (1 << XENFEAT_dom0) >>>> +#else >>>> +# define FEATURES_DOM0 0 >>>>    #endif >>>>        ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR >>>> hypercall_page) >>>> -    ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, >>>> -        .ascii "!writable_page_tables|pae_pgdir_above_4gb") >>>>        ELFNOTE(Xen, XEN_ELFNOTE_SUPPORTED_FEATURES, >>>> -        .long (1 << XENFEAT_writable_page_tables) |       \ >>>> -              (1 << XENFEAT_dom0) |                       \ >>>> -              (1 << XENFEAT_linux_rsdp_unrestricted)) >>>> -    ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes") >>>> +        .long FEATURES_PV | FEATURES_PVH | FEATURES_DOM0) >>>>        ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic") >>>> -    ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >>>> -        .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >>>>        ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1) >>>>        ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN,  .long 1) >>>>        ELFNOTE(Xen, XEN_ELFNOTE_HV_START_LOW,   _ASM_PTR >>>> __HYPERVISOR_VIRT_START) >>> >>> Are XEN_ELFNOTE_MOD_START_PFN and XEN_ELFNOTE_HV_START_LOW really >>> relevant >>> for the non-PV case? I don't think so (in theory >>> XEN_ELFNOTE_MOD_START_PFN >>> could be used, but the main reason for its introduction was PV >>> guests IIRC). >> >> I wasn't sufficiently certain for MOD_START_PFN, so I'd prefer to >> leave it >> untouched for now. HV_START_LOW might be 32-bit PV only really; I'll >> check >> and then maybe drop (or move). > > Fine with me. HV_START_LOW is PV32 only.  It's the negotiation for the virtual address split with Xen, and was never implemented properly for PV64. MOD_START_PFN is PV only.  It's not applicable for HVM/PVH. For PVH guests, XEN_ELFNOTE_PHYS32_ENTRY really is the only necessary note, and that's what XTF uses. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:36:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495990.766473 (Exim 4.92) (envelope-from ) id 1pSHxO-0004ak-SK; Wed, 15 Feb 2023 13:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495990.766473; Wed, 15 Feb 2023 13:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHxO-0004ad-PL; Wed, 15 Feb 2023 13:36:22 +0000 Received: by outflank-mailman (input) for mailman id 495990; Wed, 15 Feb 2023 13:36:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSHxN-0004aW-F5 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 13:36:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062c.outbound.protection.outlook.com [2a01:111:f400:fe0e::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7dead5c-ad35-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 14:36:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8593.eurprd04.prod.outlook.com (2603:10a6:20b:424::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 13:36:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 13:36:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7dead5c-ad35-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bs8g873QF2R1b9J1euu4c9hQFMEvwpKXhYw2YlQliZc9yihJbdFgERkoeNc4bnPVycekNgBUPg/GnRsgF+nqmGeY88SSWasB8wfcs6ORuIkqAmHT87/CNgV77oxvIvChwp+RSFylkOaFz26XqkmfBRbfxY3VOT0wO6l7d/nGuGzBX32OUFbFNER9ZWi7vClXt612qBLohUoYH1zf33ZxvM9Owa1H8mWg5XlxiAFT6JicVNDPiaFnUFUyPJfkn0/Iq/LfPk645tEw4o119XEWYcyHmV4nppe6SMCw2buK2+ylX+ye7crOIdQmmcpl/7K9OJH/gPC1CEWn2UL7MndDdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d+KlP5qA89mRT2c22KFwY0e6UaOKuHAXpVAQZI0PIhA=; b=hizrpCi/GC+8cA1sRtwwqa7G/BJK3j/1jAanNQinX5G3QwMUwZbAExHu9y+APg+28LNrQ/yqCOYTMSar/ucA9LN1KGXg0QZ4JB4kFpfJTlZIRtxseRUbgXnlXORD0SANf92A1WGPo5Uv5Bfnw4BhAEvHXmltT2b496oHh3D4TxxPiLUZifad8OJeUeK+n8v5RVFomvG0q1/Rz3VlZHi5ZSXQ17jxQR+N3W3CN1XvDbIdu4ctEVYI9ZAtWjJu27x6ZPO+PqXL3YbOU/GimWxKebAUChmD4NqO2YDg1jq9twxNeGBbX0TnPE+AySMftIi3dO3hp164GWjspp5URqDO1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d+KlP5qA89mRT2c22KFwY0e6UaOKuHAXpVAQZI0PIhA=; b=yuvnkVDVQdEaffXBDwDbsFp0CYCtgfCAeMYetGvw64wdKddtvBSaqRMgaqHANkhxmLwP+2BZgyOmK3f0bSfnxU23OmSGldCLgDtzYjDqDegeZnnn4u/5EzY5ElmKtI12mTIbKXSf+qk0MUOtrKO5frn8YgLPijdEVp4IWBvGVwxGAyQc/R4Y+OD12cWIWs/ubragbEhJgYRkUxSaZ/Uuj+e/rqI9S480VVb+5KwxUN43rd9GDRN5f62rI9Gelgt7N8Bs1I5Tdv84qtRS47a/+4k68PokvVkg8DKBGCiR4sfI25IFuZk1FXS8T0uhUi74zlc8xc4EL2yhsL2aD01FjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 14:36:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/Xen: tidy xen-head.S Content-Language: en-US To: Andrew Cooper Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" , Juergen Gross References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> <6b0b2163-a8fd-4eaa-2219-972c02aa6e49@citrix.com> From: Jan Beulich In-Reply-To: <6b0b2163-a8fd-4eaa-2219-972c02aa6e49@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8593:EE_ X-MS-Office365-Filtering-Correlation-Id: a210d681-ce04-42f6-4668-08db0f599a89 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7VjvBdKiNlLZKRKibSN+y8NDlOCcsX2KxvEppGXvnzLJcPvdbtKDEittNrYOxMp5WHA4ziutPavKHxE8Uz+U38cYnijZ6gMD3rxXEQ5moxJbqOSQBMq6Ue139D0k9G0Bx8fAX+5xzVcdwURPHu6F0+UCRVKEutqJ7K7lBR1pMI7kGltNfbT1fQ5WxYz/SJycJCMuexsTVLY1MQvDmE2E1uIC/L1VrcbxvRRHzpzd6z9gas0Fxp4opKedGCCQLWP3kU3ds3E0NKm0OSgEn1kgzpJVENwKDfPhsKgoYyLJQS0QNf/KfJsDlNiqpBMRfyejitsvREeUTkS8DMuUydahZdvD8UTIZ76qI/KkUkkOY7vI2Dn2MWorrK70Jrtn5z/rHq4f2XQzoB3hZZyD2jckmssMdVIvbvCF+w67pn/BIMtlWIX5Tk8aTD/bDnbOvdCYjXpPU6oRGoddLPdh2rTmWl+V8D2/VnCBDAgtXWDYTmuZ6GUOFFF78XO5uzKCWit8lkWM3HxXVaf9TN/7fgivM5q2R5f7FP8YNTX+3yQL2hzoMuQ5fSWcBTrrFBpQ7x8TRLZQ4mD2WTu/AZLrzZYw3D+ecclFWB+G66pU4cKkNd4UQ0vDLMso128NDrIZ/6SqQpHps6jB1lVZhGE/8rkzFo7i8bbokVDsgqGWdLCGlZ5DnikJ1zFjYJWy7UMDR+wOpQMRDZoIbVSlu8R4sa84WnptHCmuU5N6Wmr8HRUv8rw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(346002)(366004)(39860400002)(376002)(451199018)(31686004)(36756003)(38100700002)(86362001)(6486002)(83380400001)(2616005)(53546011)(6512007)(31696002)(6506007)(107886003)(186003)(478600001)(26005)(66946007)(66476007)(66556008)(8676002)(4326008)(316002)(54906003)(5660300002)(2906002)(6916009)(41300700001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RS9vVlBOdTdRTkM3OFYyTTQ2NjJPc3NEcVlIcmpBWVhzeDY3Yldld2ZSL21C?= =?utf-8?B?RURMQnVVMi9zZjUrNmF4czBzektaV0U0a1QzaTlyQWpMS1Y1L001MjlaRTRM?= =?utf-8?B?RENhTkVxb1cydE5MZW45U09INFkzZWYrc1hRL3BCTFNnbmJZT2FTZ0cxZ3Nj?= =?utf-8?B?bWNLM1Aza2JXU3ErZTRXU0dud3h5ZE8vNmxLRjVXeTMzclNhd3NTbDgwdHFq?= =?utf-8?B?UWhTZUJjQjl5Mk8zZTg0T2wrdFdYcHRSRW1za2szaStXMFpUQjJMNnJhL2Ns?= =?utf-8?B?YkNWQVlhU2N4QXBFUGQvSkZtNFFPRFIzM1YrTThEQ3NXM1pnbXZaK0IxRE1I?= =?utf-8?B?cEh6M0c4UWpSMEtZTGxKRnY0ZVFDaG55amhoZmVmSm05WUFoSlVrQVN2VnAw?= =?utf-8?B?aXNNWjhPcnNxcHNXM0xmTE1HdDg3d3FqaEdEUXZPamxONjQrVVQ1V3dFbGtU?= =?utf-8?B?VHY4WWpKdklTcW1ManJiRkx1TjZpa0J4L1hTT3YrRjVSdU9lRVEzVUFvUnhI?= =?utf-8?B?cjNlVlIzLzdKTGs4S3VSNzdKMTlmSmp2cHZwYkFBSFp4K2ZpdkExak5mQ1pz?= =?utf-8?B?TkwzazFMRUM0RG5BNnljWTkwRTJhUkJmNGtVdFl5blQ2UmlyYXUzcXorUElt?= =?utf-8?B?bTVWQTNCWiswbUNOOEFnR252cFViOVJzcjEraDBMSHRPWE55VVROV0REL09q?= =?utf-8?B?RmQ4NE95QXd6MHI3VlNlYitGdnd2Q3UwSG5weUE1UzBRTFRzSC9ZYXVzR0Zw?= =?utf-8?B?NlZSOVlmUHpoc0pHK1FOV2dFdEFBT2lYV2g1M1ZaUFVGZ0NnVFhJMUhrVEIw?= =?utf-8?B?dWtyQ0Q2WlMvN1BzbkRra3EzZGFkVFJRaGhkWVNuZ3RYaUlyTG00YlIrVGpu?= =?utf-8?B?K0dka1dIcHRoSGtXSG1KMTM3S3UvSDdwVEs2amlTRGJUa0ozYnNLRm5sZlRL?= =?utf-8?B?ZlEyUmdWRERxWk53YkVWT1oyaEtaSWlVckdYUEFMV0E4QkRyZlRORFBadVZY?= =?utf-8?B?clpTYkNBZDlPNU16d3BmN0IvU1k3bkdDL3BjeGsxZVZZNzFiSThueVZVeWkz?= =?utf-8?B?WEpIWldVUG12VnlxNFJ0QTMxc3hOdHFFdVVrVVRXVWJkRndzYWptRGlGUitZ?= =?utf-8?B?aWFjcDUrUFFBcFQ5Tkg4TCtnblNnL1hYNnp6di9VRFZWUDRBZlIxUVdiRFZl?= =?utf-8?B?Y1pGU3hPenlldXBXVjNLZUc1REZocW4vdzhjdGxPYkhLcnREb1Z3SU1zNzRv?= =?utf-8?B?YkhvNHFTS3hpZHAvYWo3dk14LzI2SlREelZaQmcyUG1TRDEwNDMvNjd5YVZk?= =?utf-8?B?VjhBMzJMMnZ2S0J0ZnpyNnRTbUJPVmdqZkw0b092M1dzOWtGZ2J3V0lIekIr?= =?utf-8?B?REJpWFJzZlJ3TzlEakpBNEhwYVNrL2dLQXhnQ3VJT3Y5cEFyRXRTTExXY3Ax?= =?utf-8?B?WE52Nk9iSWxHTEZXcW9uVXBSL1NncW9lVVlrNzNmb0hJbStzTklMdVQ2VXVI?= =?utf-8?B?ZGI0S2NQQU94NEdjN08vK2ZwRWRHcHJuMGM5Z3hGbjlvc00zVThzSFdvMkdJ?= =?utf-8?B?WEtseTBSZk91d1owdHdCb0RFZHNQZENodkhTYTVxdC9odFlxcFpWNU9qOW1l?= =?utf-8?B?R1dQUkRsZ0JjajQrcGZ3SmRseFRCQmJHY1NaTUpJQnBtdDM5cW5kb2Y1MGNO?= =?utf-8?B?WUJRVklwRU81L2VRalAyTlNXQ2VZTk5iSUg2T0g4U0dSUitIdzgvbk1xTkxt?= =?utf-8?B?T3lsSjVxa3l6MnY5RWRaTEpCS056UjhoU3VxdlppWWczRXRJMlJHcG5vT0RN?= =?utf-8?B?Z1IxZlRCSU1FZERQYlkwZE94T1V0QUlaN1FadDlOdDFsSFFOT2dXVjRFaU4x?= =?utf-8?B?MjFJS0ZkMUtnaEEyWE9FczVzNDZlMEhIRmEvSHFMOGtzSVFlZVZwR3FjUm1o?= =?utf-8?B?RFRDMHoyeUxWNkJuSWphcHhvOEhIT2xkUnpFY0pZNFhXNnQ2NEVqV2hNVktY?= =?utf-8?B?dUVXWG9sTml0b3RqUmlFdjdGeWFRUVI1TW12WldEaVd2bFUrbG9FODM4NktI?= =?utf-8?B?SGNBMUlQRG5UL2pXMzB4aXRrZGRVU1VMR2lZdjhsNTFKcDN1MEwwbUtEY1g1?= =?utf-8?Q?sNTDKEf6hTwMq1zjj/Zp8YVyC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a210d681-ce04-42f6-4668-08db0f599a89 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:36:12.5531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4ex1ACWwI4yQn0wqvD0W2TcEf963iXl8O1rOyXca68TVwiplqIkO+aBC6U+Pj5JEtl/HCA6WWyhDojcVrOBSug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8593 On 15.02.2023 14:25, Andrew Cooper wrote: > On 15/02/2023 1:12 pm, Juergen Gross wrote: >> On 15.02.23 13:42, Jan Beulich wrote: >>> On 15.02.2023 13:05, Juergen Gross wrote: >>>> On 15.02.23 12:33, Jan Beulich wrote: >>>>> -#endif >>>>>    #ifdef CONFIG_XEN_PV >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_ENTRY,          _ASM_PTR startup_xen) >>>>> +    ELFNOTE(Xen, XEN_ELFNOTE_FEATURES,       .ascii >>>>> "!writable_page_tables") >>>>> +    ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes") >>>>> +    ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >>>>> +        .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >>>>> +# define FEATURES_PV (1 << XENFEAT_writable_page_tables) >>>>> +#else >>>>> +# define FEATURES_PV 0 >>>>> +#endif >>>>> +#ifdef CONFIG_XEN_PVH >>>>> +# define FEATURES_PVH (1 << XENFEAT_linux_rsdp_unrestricted) >>>>> +#else >>>>> +# define FEATURES_PVH 0 >>>>> +#endif >>>>> +#ifdef CONFIG_XEN_DOM0 >>>>> +# define FEATURES_DOM0 (1 << XENFEAT_dom0) >>>>> +#else >>>>> +# define FEATURES_DOM0 0 >>>>>    #endif >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_HYPERCALL_PAGE, _ASM_PTR >>>>> hypercall_page) >>>>> -    ELFNOTE(Xen, XEN_ELFNOTE_FEATURES, >>>>> -        .ascii "!writable_page_tables|pae_pgdir_above_4gb") >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_SUPPORTED_FEATURES, >>>>> -        .long (1 << XENFEAT_writable_page_tables) |       \ >>>>> -              (1 << XENFEAT_dom0) |                       \ >>>>> -              (1 << XENFEAT_linux_rsdp_unrestricted)) >>>>> -    ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "yes") >>>>> +        .long FEATURES_PV | FEATURES_PVH | FEATURES_DOM0) >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic") >>>>> -    ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >>>>> -        .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1) >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN,  .long 1) >>>>>        ELFNOTE(Xen, XEN_ELFNOTE_HV_START_LOW,   _ASM_PTR >>>>> __HYPERVISOR_VIRT_START) >>>> >>>> Are XEN_ELFNOTE_MOD_START_PFN and XEN_ELFNOTE_HV_START_LOW really >>>> relevant >>>> for the non-PV case? I don't think so (in theory >>>> XEN_ELFNOTE_MOD_START_PFN >>>> could be used, but the main reason for its introduction was PV >>>> guests IIRC). >>> >>> I wasn't sufficiently certain for MOD_START_PFN, so I'd prefer to >>> leave it >>> untouched for now. HV_START_LOW might be 32-bit PV only really; I'll >>> check >>> and then maybe drop (or move). >> >> Fine with me. > > HV_START_LOW is PV32 only.  It's the negotiation for the virtual address > split with Xen, and was never implemented properly for PV64. Not the least because there it would be the upper bound that could be moved down, not the lower one that's movable upwards for PV32. I suppose we'll get there once we have 5-level paging support and can shrink the hole needed for 4-level PV guests. > MOD_START_PFN is PV only.  It's not applicable for HVM/PVH. It isn't right now, yes. I continue to be uncertain and would prefer to leave it as is. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:51:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:51:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.495996.766485 (Exim 4.92) (envelope-from ) id 1pSIBt-0007Sd-5b; Wed, 15 Feb 2023 13:51:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 495996.766485; Wed, 15 Feb 2023 13:51:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSIBt-0007SW-2Z; Wed, 15 Feb 2023 13:51:21 +0000 Received: by outflank-mailman (input) for mailman id 495996; Wed, 15 Feb 2023 13:51:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSIBr-0007Ri-68 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 13:51:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf9e0c52-ad37-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 14:51:16 +0100 (CET) Received: from mail-sn1nam02lp2041.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 08:50:49 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6485.namprd03.prod.outlook.com (2603:10b6:a03:398::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 13:50:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 13:50:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf9e0c52-ad37-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676469076; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Nzr/E63CLkwbLbM8rRfPLLeICwFeRymXzxCY8Ltgq8g=; b=LrB+aO3yzze8dxIY+amxr6bLS9fnwP2wj3hssHzBCYCQHxcxseaRofCW KUu3C5eTFChkHrL+jNtPjBElZcompJVU2+zCD6F3aLHdVTagcgjypXaoT Zae5FeruyWmaA1CNqXugh881zFtU2vhr4Yhurr5/j61nyDZLAiIV/JgXP w=; X-IronPort-RemoteIP: 104.47.57.41 X-IronPort-MID: 97061230 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VvlooatDx4EQxrwlm22mM4NQiefnVPpfMUV32f8akzHdYApBsoF/q tZmKW6GMquLZGv3KtgiPtmw/UsA65KHxtJlHAdkrXg3QXlH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWHyiFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwGRNSPgivob6PmbOQUdVen/U4MNDLM9ZK0p1g5Wmx4fcOZ7nmG/+P3vkBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/6xabI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReLgqKcw2wX7Kmo7OQwNBXaioaiDhk+Ddoh4F GJO0BgVov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xDG8eTyUHb8c6rsgoXj87/ liTltjtCHpkt7j9YWLNqJ+XoCm0NCxTKnUNDQcYQg8Vy93ippwvlBXJT8YlHKPdptj0Hz736 yqHoCg3m/MYistj/6+j1VnDgj+q9t7FQ2Yd6gzJUySl5wViaYiNY42u9Eid7PBcIYLfRV6E1 FAUls7b4O0QAJWlkC2WXP5LDLyv/+yCMjDXnRhoBZZJ3zai4Xm4ZqhL/SpzYkxuN645lSTBZ UbSvUZK4sZVNX7yN6tvOdrtUoIt0LTqEsnjWrbMdN1Sb5NtdQiBuiZzeUqX2GOrm08p+U0iB aqmnQ+XJS5yIcxaIPCeHL11PWMDrszm+V7ueA== IronPort-HdrOrdr: A9a23:MR01W6nQevs04ZVeyn8CnMS6nQ/pDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="97061230" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EG0gpcQvntOpqcLXbc4Qz6pgJ6aB2GyiB2+QgJE2rBES21wAHtM3Iv5KAgMN3m+XxijJEZrKgnKMjphNRAd05YyD2V+nFtP/xP+AgD02nmrBG5GXTvzmkrOQ898ICNZkmrq6Zw3xvKPJOkFVta6KQ99Sz7WeU/13j7ruXi3QoUji6TIfcdwUHiA2uQiueVLcrL6cF30Z+BPvgZ97Aot+0cESxYAYC2ZERJFTcaQX0ZzmH1lC8PkT45KXRxPluoTzISFLrGkvo/dDtFdh2tULfIEtKbQJpyjkVyFOel00bmr4suIuMxVl1fhaTFHR1Z6PnWD7N8npqtDC0IH1OX/n7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nzr/E63CLkwbLbM8rRfPLLeICwFeRymXzxCY8Ltgq8g=; b=ZT/AeA81PLXdlX1lesLDOg1Bd4pJdooM4gVq5Y48ddoZkX0dIQQpxck8AlAlgKl7JWkSqWISzTKaYuCVNHCfHk7rtjvS8IqLsz1RvlbzhQqLInD1HIySCCeJtsiAf0VpclsGUAXfRaEZcLqTr7UkSqiyqJtU+2lpw99KFb0tQERAGrPTWjsuB8FbrouQSYMsQKJgCSQm9JcxS4mnUC0Uq0I/nIBxhU8VNYzE/v0UqYtK7B+AbX/rJlxYHEHn4RZ3eMepF0OakIZrMOwdF+7uFhhhWNHZHJqt8m8cQxvwculdZuixQERbLSMMZIO8QWb2O5SfLEzZUiHm4NRB9Isbtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nzr/E63CLkwbLbM8rRfPLLeICwFeRymXzxCY8Ltgq8g=; b=JU6owQLJ8Wc1S6ZYJSU5a5G8SpyQaA228rrR/v8g/PN5YLiQIFKx1myEGtb2UYETwbKvbhqjWiQjyIzlJCSQEC4OLo7lg1XQyLCRxMU4yAlaph2dUEI8ELl5dZexmXaSZ5P9qCu9M5Z903aZ5T6YwQxL/dOqgIeAwNDUErUu3tE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <8a4dbaf4-880b-5689-1232-11d7ce96b28c@citrix.com> Date: Wed, 15 Feb 2023 13:50:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/Xen: tidy xen-head.S Content-Language: en-GB To: Jan Beulich Cc: Boris Ostrovsky , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "xen-devel@lists.xenproject.org" , Juergen Gross References: <28bd8aec-cd41-7b5c-0f32-12c79595134d@suse.com> <7b0ddd99-4093-b72d-ba5c-ea145c0bf2f4@suse.com> <6abdc32d-5a18-20dc-a300-754f2b164fb7@suse.com> <6b0b2163-a8fd-4eaa-2219-972c02aa6e49@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0012.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::24) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6485:EE_ X-MS-Office365-Filtering-Correlation-Id: e471962e-97c7-4386-b84a-08db0f5ba324 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1z3a8BmZQ39BxbQBzhEu0eProCw0MFxI5/0WbwTQj4x2Jod0NBwLK8iTk/JTC8VKlgHmyLTViWPgCNYanzupeLvd+X/759J5yJ1ux6TlWIpi2fQVW+ugJFNwxi5K7a+X8D/tKAgYrKGb8WGvEvJAyyy5d+85CgAHoIII8QUQNI0QdfKepM9QLahBXccCDcKPoTuwZcd3fFe3KJ7pO4Bm2eFpFxS4GhFZkYaWI3wHpyBbGXXFvuNe/t41FKJwwvQQes2Rj0ttyAIjB8L3ioOAUmnQZ1kEaPtctRfFle+G2fUhjvHFO6X5kRSv25DjwPFop+CuUIC66nbnIj5iXkB0Go9LlVTsdoyPwo+D8eUAzhWyem++dEe7kcSZxucKhmDLdZnLlDXnTqWeSPgO3bcn+oycvOAVD1CWW5tNbP3AUoFFbylZGM5nJXUKGo2vs3Up0dNjKERIPycAJfR3sY6CeVrTYa6QU3Bny1dELDBiTcp5msq7uYEFSRuTMB+RDhGemO0eUHTJJjPdKOPOsx/PgJyYSXv4pOuqaebY4qncGAsSgdcNn2KeDpkXo58MgAnGWhbFsGikAA7p3HoqX5pQiantjCyEWLUtU5eO8MUfyl1D4i67xlnnTJ0IC+GCAQP0fZPcqjEOGCnh5w8de316/Qsay/+x7s8qI7lTumF5Mo/RWH3JDMLseKRMee/oBATAUf/MZbWNnEuNfw2bXQeihIOgyNiztTztrsWBzIYrEmU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199018)(36756003)(41300700001)(66946007)(31686004)(54906003)(38100700002)(5660300002)(8936002)(316002)(4326008)(8676002)(66556008)(6916009)(66476007)(4744005)(86362001)(478600001)(6486002)(6506007)(6666004)(2616005)(31696002)(82960400001)(26005)(186003)(2906002)(6512007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkVWN0MwQnJhN2l2bzhKVmxMN3N4eUdrOVVnN0lHZDE0TUZHTWRaZ1V5N0N2?= =?utf-8?B?L0FpRkppU1N3eW9vaDN1Z1FhY28zejdaSEdnL1lBVEV5akFIS1FtL0JDTGJZ?= =?utf-8?B?andqQ3ZvYVhtVFlObEh6RDI2aWtqc29Sa3BiREtVTXR6UnQ5UnNHVCtEY1J5?= =?utf-8?B?amhWWHpaVldDWFdmOWlzRHJHQXJoTUZNRzF5RDlhTGtSRTcxSFRtRmpISFR0?= =?utf-8?B?aTlsWGRsU1hQSnFHZjRGVmttMjZDMURmRko2a3BwMnNQUnZJSVBQMTRjdWNt?= =?utf-8?B?VVY2b0JvdjE1N2NXN3BGeEFjY1RIZmgvMldkVHpuMWxVVkpOQmwrZ0VQRUpY?= =?utf-8?B?MFJiMjQ5UENkaUVVK09mMU5TVWNDMEJPaXlDSVU0bFhKNzRzZHAyNmd6TnVi?= =?utf-8?B?L2cwSWxQdXExY0s2V2xPeWdmSG96Y3Y3V2lOZXdsbjFhRlB3T1E3cXBvbHZi?= =?utf-8?B?bUlzM0RoSVY5R2pJWmtwSXkxUXB0a1BEbGJOYzBZMVJ6U0o4MUgyQjk1Z1Fo?= =?utf-8?B?ZlQ4OCtVZkI1V1pwWVB6Zk1xUGV5RTBnMnp1eUk4QVhkK08rMkFycDZlY2o1?= =?utf-8?B?MmpjbURZbWFsdzNSQWNXMzhQWm4weUNlRWNMU2F2MktaR0UwOUFpU2JNRWRo?= =?utf-8?B?WXVTTzU5dkkrbnRZMFVMcW9IRmNkVTRrVTB4MDVtSWV1aC9jOGZZUHc3VElp?= =?utf-8?B?YzRjQVFBTm5NUEdsWFMwRHVPUnI1SWF0YU5Dand5MUNVcGxDSTI1eXo0SUQ3?= =?utf-8?B?Y1hPdlNnR1BFZ25raVpuaFIwTlRXaWJJRk5lNHlGbjVCdXN2c2FZTURwUzRk?= =?utf-8?B?Qy9abzZ2THEwWWlMQzAwQ04rb3V1VGV6NFN1bENXTm9tanF4UkZpUHRBWW42?= =?utf-8?B?bGVzbjVHM3ZRUStvdmxTVXFIbHJpa1FzQVh3UllLeEwvWUt6S0pNbVJnQlBy?= =?utf-8?B?MENnZk5Bem12L2dQME8xN0JDNFpnMGo3dTVVN3p4K3p3ZmYrRnNidGZXNERq?= =?utf-8?B?MG12cEt3SGVDYmRVU0VsVXZ5bjRQVklKcmI3Mjc5T3Q0SjZmVkg1N2x4UXA3?= =?utf-8?B?NDc3Y0pYRzlhQ1o4RWlBdGt4MkE3QUJyT2pHOTF2NDF2VDFZZG1WWGcrbHc0?= =?utf-8?B?M21IRXMvRkxMYitiUS85MU5Ld2VjeXRkZDNNck5QTnlVV2NtRnpVUGwvN21p?= =?utf-8?B?SitCZnRYTmNJYUZrTnI5THgxandoOWlqbEZpTUxmc01uRUVuRTN1SUZqc1dQ?= =?utf-8?B?Zmg5MTJDNTFRcURGVDZUT2kvTjJZTGc4TXpZTzNQZVR3NG5uRS9BNUFXSkhF?= =?utf-8?B?TGRtbzFlYmZjNEZQdXpmYmVzNm9nWGRqdzArbTJLMk5maDNCQklwZ2RoSTVQ?= =?utf-8?B?NUs3NVZDd010Ym42M2lKaktpb2tOT1hCOWlQejFqM3MyRXQwcS80Z3Znc2oz?= =?utf-8?B?S2NIcitpbU5FVVhzbGdVbW9aaGloZzA3YjRBVENRZElWVmRqdkxFc2lpbEdS?= =?utf-8?B?MG5WcUpnd1l3bGxSWGxlUkZUelJvS1M4QmlkYXFrV1FuSGxmU25wcmt2ZnFv?= =?utf-8?B?eVBhN2xZQlZyTkFQL05wVzN0LzFOeG1LcFgxN1RhWWVHUituUmNlU2pDNUpB?= =?utf-8?B?TmlNb0VoY3FwMm9VNFM2aDNaQytQVEdONElQK0RiQmg1NDdnM3ZwWTNNRVZl?= =?utf-8?B?TWV4TUhDY3pVZHIxcm1maFQ0elduUk5paW9aVi9QRjcyVHhXRUpIcVZlRHZG?= =?utf-8?B?SGtKWTZKcUJ2N29YWWEyVlN5VnJiWitmZ2NQQUZDb0tiMmZuVjRick5rd0Ji?= =?utf-8?B?OHU3a1UraXk3RFhyQndwdVFzT1kxSlp0U1p2RnZzcTRIdGQ4RmpHN2w0bGVy?= =?utf-8?B?enFtNTNENmJENzA1NGNwMzYxREhvbHdIZk9QUG9vZVpFZG0vWmMzL3kxMGpl?= =?utf-8?B?dDhuRk5taE9OVnY5WGwwM2JJeXlaM01ENklLL2ppaWYrWVlhcmxZUnFYK3pX?= =?utf-8?B?RFJMNVhqbkJXL1FxdVVVTXhORUtpOE4vWkk5SHVoZFNDVEpnNG1DVy9zR3Rs?= =?utf-8?B?SzB4MHRzZC9nak94bC9oKzFINUMwcHVwT3BFamR0UDNCNXBFYU9Tc0ZFNGd4?= =?utf-8?B?TklwTjZUeDF1MWxtdDNaU3diNlpyVTEwSlNVQno4UGdyNTFrV3pKVFNldkxQ?= =?utf-8?B?Ync9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RGF1TWlFRlovakRMbjR3bE1kNUNxM2REakg3RkloWlN6U3EyRWtoQmIxL2JR?= =?utf-8?B?bWIwK3d3WUlabnU2T1Y1ZVdBVXZkZzlwRXZnNDRzMGRqYXg0bm1vdVlsNng3?= =?utf-8?B?YTZmVU8zN0kzVzNDYTRYR29wSkRja29YU1hjRVdrMjVGeEZ0eW9FNGpKcmV1?= =?utf-8?B?VnBVY2E5UEd4dWNzeTgvWFVZL0hqN2dWMWVUd1AvaXFLRFNiVFhsZ1l4eFlI?= =?utf-8?B?MkpUaVdYWkpZY1RDVjRpcU43YWxUSWNiNk8rbVlpK0dwRldneE01clRML0Qv?= =?utf-8?B?N1JWN2JDOFBxeHVheHdoSWU1Ymwzakd2MFJsamxMVlpWVnZQUzBRaXRFZnNq?= =?utf-8?B?MXJzazI4czRYb043eE51V0RXQzlVR25hNThON1VydDZiN2J2YU5qV0t0Y1Bz?= =?utf-8?B?NGNkRWlCemtiVkFlZDdEck1rdE9JYk5lN3lBME83Z1RKS1MxTFp3YUVINjVr?= =?utf-8?B?bERNYmV1OUFvWHBxZ2pIWHdjRmppUkVQR0xTRnZXNXQ1ZlNaZVQrQ3FlTFBN?= =?utf-8?B?M200emN3NjhuQ0JMR25NTCtzMFNUek1hS0g4bld6cXVENWtNdTJRNDFKaWdX?= =?utf-8?B?R1Q3MFIyWUVqT3FLRlVUZzdqUytVdXJtYzNMYUZGOXlOTTh2a3Y3c0FlbmM5?= =?utf-8?B?a3p3NVpDU1RYdTMyWDA1OXRCSFhRL3dvZ3MySGdSU1dqOE04clZXVXhDbUxZ?= =?utf-8?B?ZjhoRmVxR1VjU3RHZVQ5UlJGcHNzSFlSMlA4ak9XZlFqSEkzMUZNaE5RaTVW?= =?utf-8?B?dnAvT2k0dmtZUEx2QVpDSjlucU4yS0d1d1dSTmhCYlkxZ2RUekE3QlpEbXZ2?= =?utf-8?B?enIycVFvQS9QZ1JsUERQTjNiSXZlc0JOc1B2d0FYWUd0SXNkdDRXcW1OeFhP?= =?utf-8?B?SWVYRWdUWTRJQXQ2eHhyYk8wSEJ5TUJONHlXbktZVkNDVVl1OGR2ZHdxTy85?= =?utf-8?B?TUxoMG5JZnAzZG1jSmVVZVBVdTlTd29oR2NNM0VDVnhNQ0lnaGM2R2hJTDFI?= =?utf-8?B?MGJyM0dUOVNQZHdibW1wR0x5ZEVpaEhHLzlnaVJVUGQwelB4WDljT2l5SFhW?= =?utf-8?B?Y2hST1JORUg3d3J6S2t6djdSb09KZ0ZwNEZXVTBZamhSdmM4bU5VR00zeFlR?= =?utf-8?B?QUF2Nm1Jd1FBNlZLMm13RUFUQTVCSzR2NjB3TmJLbWE4MFJCU1IxZDdsYnN5?= =?utf-8?B?QWpQRVlZWDYxSjVQdGRaL0JoaFBTQUJzUVpDbTlxQjU2ZTZDY3lscXRtRHJk?= =?utf-8?B?bmpPMDZ1bFJ2Q0E4ZlVEVXExRzNDZ3FoMDVxVy9IUXloUnBSREV4UHFUQ1hR?= =?utf-8?Q?uLD8KTux8FBmi11UWF4uVDJG+IBFi6/l9A?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e471962e-97c7-4386-b84a-08db0f5ba324 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:50:45.8933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cGxpEHwMzAu33gEJZ/5++bvN3+LSOt0QWDlpKa7lPKfml5+SDkUs1n/lq9+DLiU2SxbzhZ9QTUiGW+WWGoEb4PQj937xccPvAAF9cKhuafU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6485 On 15/02/2023 1:36 pm, Jan Beulich wrote: > On 15.02.2023 14:25, Andrew Cooper wrote: >> MOD_START_PFN is PV only.  It's not applicable for HVM/PVH. > It isn't right now, yes. I continue to be uncertain and would > prefer to leave it as is. Its the wrong address space to be applicable to HVM/PVH. Not to mention that HVM/PVH already have normal ways of passing the module list, so even if you fancied respecifying it to be usable in HVM/PVH, there would be no interest in anyone using it. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:52:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496000.766496 (Exim 4.92) (envelope-from ) id 1pSICN-0007w3-Gx; Wed, 15 Feb 2023 13:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496000.766496; Wed, 15 Feb 2023 13:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSICN-0007vu-Ck; Wed, 15 Feb 2023 13:51:51 +0000 Received: by outflank-mailman (input) for mailman id 496000; Wed, 15 Feb 2023 13:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSICL-0007Ri-5K for xen-devel@lists.xen.org; Wed, 15 Feb 2023 13:51:49 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1827390-ad37-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 14:51:46 +0100 (CET) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 08:51:32 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5626.namprd03.prod.outlook.com (2603:10b6:806:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Wed, 15 Feb 2023 13:51:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 13:51:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1827390-ad37-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676469106; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Lekop6wlNMZ1VX/CCK9nSztVmk+8oD4dkz1SjLd7arg=; b=gSDCFJwyTrD5EPXSChmxRk4cTUSgCd1ZjkG68frPPJL9GrVU0KkGsVzg 4HWdUAMQN6XS+yUJpWvFwtEe4aE4bmgOE6Te1YaSok9dqu5kTTpaS9MV2 WCQtRkxT7nFobnq5/ENWM7T5eh58rtattHXwpBKNbkQxcw1Wtn9SPlsFu M=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 95983107 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MmeLyqoHXMn6DHlpsx5YfgnR7nheBmIEZBIvgKrLsJaIsI4StFCzt garIBnQO6uCamL2ftknYNy/9EMAup6HyN9rGgZq/H1jHi5G9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAAjRS2vpuit/KLlZeJnpMczKczmGapK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpq6862wTLmQT/DjUkeke4q8GlgXewcMN/N HMW2Q4TsYwboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC25CSSROAPQls8ksTDBsy V6NnPvuHzVktLDTQnWYnop4thu3MCkRaGMHOykNSFJd58G5+dlsyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:J/98/a1Sb86++RKH5urGnAqjBLwkLtp133Aq2lEZdPU1SKClfq WV98jzuiWatN98Yh8dcLK7WJVoMEm8yXcd2+B4V9qftWLdyQiVxe9ZnO7f6gylNyri9vNMkY dMGpIObOEY1GIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="95983107" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxZgO4l+1Shv+egL//UR9Uy1rMb2PhRvkn5sQQL3kWKb2A/AjYOr97Zwor5ufPztCiQbf4oGwj96ray6um2Q9K90aW0FKdLKuu896IVHdnNjPqFui9/JmlbtcdTx7dNylwmSOGuPBu5R9RVCq5QFxtM/mqPvDH04J58aYcxB+oZN80tz1G0TdJbXAiEW2aLnI2ZOuQeQVe6YVJABHq3oYLk6Abdaz75PvIaYNc7gYaDwmCIf714lfQ39Q/KuWRSxTqiQ/a6IXXhDG64fZD8aaB/XYaxgkILor59qzvW2lqRrUui2DxEw2+RvdL2syLaW52ZPL0BN7zklu/BRfDPubQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lekop6wlNMZ1VX/CCK9nSztVmk+8oD4dkz1SjLd7arg=; b=lzaeA5zODViHFwH8bv9zPi/nB9U3A4G8tzatbIRLAhIKzsR5Jg9EtuBA6fAEAw+09r89Mp8jPiL1y5d+u4adWDwOwcKw0tNX4F6tgMy5wppuYltLI5Rb7TOZ4nNJMedVXKQkAsxOSbBrwqhHiN3PwRp/a2I0k6Z854RrS/MJfujIFrS7lcvR3cbQJUEVviWnvIS3SzAsyB3lHvjZQcmhK6juX+667b3K6eaVrqZmC7wMpl+itQqq1W5yf0tlhMEenufmfvQr4d8lRleMvjjbiHe5wIp6pHI38vMTzgwQoYVNyvdeLMGSLhtIwtp1KCE8ZaNMmu+eSmrQvl6j9Vmv4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lekop6wlNMZ1VX/CCK9nSztVmk+8oD4dkz1SjLd7arg=; b=tcO9BSD2q6q3gHv5bZXYk2Ijigx2Ikg1+vM1Ojts5DUm8uDbrgNmzHBVI5h1LEffVMKcFEjWBHu1uZU8fDBM0OTtl9Vvr4XKE31lIeXEZjXpdCSXudwWzxHx4RJKD82139mOfAR47OpQy/Wcd39giHCD2JirpeOq8/RR1GgN6OU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <11587db0-8e69-ccff-d020-e7501a61ac38@citrix.com> Date: Wed, 15 Feb 2023 13:51:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] create-diff-object: Handle missing secsym for debug sections Content-Language: en-GB To: Ross Lagerwall , xen-devel@lists.xen.org Cc: Konrad Rzeszutek Wilk , sergey.dyasli@citrix.com References: <20230208180457.800671-1-ross.lagerwall@citrix.com> In-Reply-To: <20230208180457.800671-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA0PR03MB5626:EE_ X-MS-Office365-Filtering-Correlation-Id: b9b6b2c6-c872-4690-ada3-08db0f5bbdd7 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iCAM4A/LIRKwtOQt99kA83AfjBKddnqldYa8gWova762TnO6qOrdWFoANy2E/Jk0y6SZiYfxrFvLs9DHHiOWit9bJZtP8AhuOK0JTypmFmk+laWWwD3fsqhSInFmUj39MoB5bDFY3jITDLz/V86dSY69N72qmrYElF2OMGfUrfJkGzq11Th36XGOpby89q0THN/fGXpc/+qkY8Vo+hMBZNFdPBYo5KvsU4LPI6TelpLiErsmcr5NxJU8C1moLU91pNnbQcgBDdwSvmnmZWCUcUVgVyCuqm2JVQWJlx+NGaO+h9GCy6DAXc46/5IBzUh3pctmv4zrgqrkIvhfYs5VEbUXL+HYhg/myHQq81LzDyPNPsv3OMqL9JTCVlnCYstdIedJCJ2Q7eoH1n8pA5hITZoegGIodjwE/Jn4EReu1dvifK13zuvL+lGXuhUDSZXPc2ci8f8wqMuFt2gUgJOkL61zw1yKuu6/2LEWJyCFD2Y2xcOvXlKPNUglnHkLF9DoBBw05l4OpwlfBmyfHyqmTOphhzkRcwA3pt5ywTGccoOusZPTdtllRtCTnhhoYquFPc1KaaMNPwzG4f4GA6GpSW/RyfyAeFX2g/v3wH0XHt3iF5+dMNXcoKFOVwyfW7cB60IaaRilsrieIREdG7F5UbKEOY533nF+tCiFVDkZsyT6HqvyilLR9ZzEh6dknJeLErS82Cxs+okVmqMc/XdH9uruKqUczwYh9E+gexNFS5M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199018)(4744005)(5660300002)(36756003)(2906002)(186003)(82960400001)(66476007)(53546011)(6512007)(26005)(2616005)(8936002)(8676002)(4326008)(38100700002)(316002)(66946007)(478600001)(31696002)(107886003)(6666004)(6506007)(41300700001)(86362001)(31686004)(6486002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkw5NEowYTJ3Qjc5MTZQWC9wUGpHd1RXb1NMZEVqSG44ZVdmQzZHTmNhOEJD?= =?utf-8?B?c1BOSklmSlA3ZHJ1OUV5TWhKblRmQllxZmxPeVdmVkJCbDRSV1FCeG5ra1dU?= =?utf-8?B?ZXUreUR2L21MZWczNjBzdGJZMFpZVFNaelc3YnhKQ2lnSEFQenlXSS8rVlZ4?= =?utf-8?B?MWFWU1BWVnlZTW9lNnpXZDgrY0YyaWJ3VUNjMThyRTJuWEhuSHgwTDhucVZW?= =?utf-8?B?dWFkdEJJMmI1Y0ljZnZEZldNbEtCSXA3RlQwL01PUGVhVVEwN2JDcFFIZGsv?= =?utf-8?B?TWpNRHhCNEUzb1pLR2tpV1VPeDFaSytPeDAvSUpwd0lhbSt3WnFyMWErcjNH?= =?utf-8?B?RnRaTXYwYmpsclA1bUNnYnpFQmNuU0JOQ0crVTBHbFVFbWtqL1Q5dWZnMFNl?= =?utf-8?B?QjMxYUt6OUVoWlZWZUsvckZRSGNzdFBoM0tXdTIvZ0JBdU9WbXUrYVljc3hw?= =?utf-8?B?QU9XdEpUTk9xNzVVek9xRmp0WWU4UU5FUDlNeFBrZ0NqVXBUOTFtVldLdDI2?= =?utf-8?B?aDNYSXA4ZVJFWmFBZ0NOaVZzOE8yODZaTkNJVVdoOXd5UVJZekI3TGNtUGI5?= =?utf-8?B?aWg5dTRobUhBWGJkSXNWWWtQOCtjUFpSNXRDL1dNcUxtRXU4OGppYlhtRmZx?= =?utf-8?B?TzI1VU9yclErQjJEVUF3VVJyS0NucnJLL0dnS0xGVzViUGVhL3R5Z1R0VGk0?= =?utf-8?B?UHF3UzFGMTBPQkg2akd5QjhWL0VsMk1CcTRCT0hvb2JZdmtQKzhobjhzcG1y?= =?utf-8?B?SmY2Q1FPbWQ1VTM4eEJBTDZlMTBnNEpOQldkRlpjSENNS2lTZWxXb0l6dnNm?= =?utf-8?B?MGg4NDgwdHJ5eGIxeGxmam1IWWt1RDFFK1lTWEl5T2k0QmNiLzl6eGx4bm85?= =?utf-8?B?SGY5b2hnOUJ3eWJkYzhSK01Gd00rV2hxS2xnSGpKb0FNa2VVSjkrVGxiZlNG?= =?utf-8?B?VVFGbzg5QXhkek9RS1UvYVV4b3BhTnVTenVVb3NBOVVRL0ZnSHRPMHNFOC90?= =?utf-8?B?RktpVHBpR1FtS0hHMWNORDBvZStFcEl2b3FKOWt4WkNxbnVtcUt2bEpFUGtR?= =?utf-8?B?cUZxTlhvMlpCVTJYQXFkWElidXBoLzl5UzNUTitQb1duWmU3eHZIK2N0blI4?= =?utf-8?B?RlZHRXdqOFE3Q0VqcXRLVU4wRmVpVVlxZEp4Z1VXOTlqdHJiV0dBYWYzaHJt?= =?utf-8?B?WlkxQUVsU0lQZWZLRVhvL1lCaklMVEpKelg1MEQraGRxWjJaTmt6dHJmb0Yv?= =?utf-8?B?UGo1akc1YU5oTmFaczhzMk83dWtMODFkT2c5dThBTGhpNFJueUM3Z2dGVFBt?= =?utf-8?B?ZlRiL0VSNm40ekJVTG9DZEdwd25JckUzYlJpUHVKV1BmOUM2Si9pZnZ6d0dW?= =?utf-8?B?L2VHWFRrcTRnb0taUnEyYWxjZ3VxM2twdmh6UnJOREQweFp5U0owc3U1OWlt?= =?utf-8?B?K1dNMUVzVkVSYU5LbWI3aXowV0J4MkN6UWxHZDVndG9yamNXbTBJV1FTOEwx?= =?utf-8?B?VXl2SzRzNFpZUzU3WElSYUw4RHgxYTgyUGhDajZwT1JRSFhuL0VNRGIrbm55?= =?utf-8?B?Yy9nT1MrdFVqNVByTklOcFcxa2NIMDlzaDI1L1R4NGpPczRKVm55bGJFRisx?= =?utf-8?B?VXNrc242cWN5Zm15RVY1OTNYUjhBZkxqTGxUNE9pTFVkdFFMVm5vSDJiZ2hj?= =?utf-8?B?dE56UWVRbmg2a2sweFcwbUpSSmxBdFdBWHpYTEV0YlZDSjFyQ0VDU1Q0SklX?= =?utf-8?B?S1NSdXVmOUZ0ZGVkd0pPYjRWR2d6QllPZHBPL3QrWm12T0EzV1hCTXRMbUFB?= =?utf-8?B?MVRBSURrK2NaQUJvOEFjSmlWSzFGME94ZWZqTnNHd2FERUU5SGNvYjJpMVdZ?= =?utf-8?B?dEJ3UTB2YVdqRHhOQXYrVDdYR0xmOERCdjZwdWw4REpjblM1V0JrZ284V0NB?= =?utf-8?B?L0ZteTQ4Lzlwajl3dmlucXpUSExkUEFqZi9OWW8xUi9qcUNoekx5THNNVklu?= =?utf-8?B?NnYvUGF5MXBGT0Q4bi9ROXpkOStUSGZxUENaSy84RFI0WG5nczUyOEdoU3FF?= =?utf-8?B?bHFyUzR1c1pHRTZZSDJQVkFjM3cwSzlGYnJwczVsY2FweVVnRkFJMHF6ZEVW?= =?utf-8?B?dEVMVWNaUUh6YWh1ZzgrZGhxYXBFR29BZHJqY0lIcDVjeGQ1bldvQjF0aThl?= =?utf-8?B?Rmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0t2PVc/anR1FXbCO758rrCvsYMUA7YVO3zbEqy7B+vOYQYJY/3gvydCBmC1FQazhvqLyaCzPNTIVWl9/EUdy/nrjbn/uYlPWKImEp0S2jbvPSuFDgFJPhgP6qXyC/JkTeMrfRUPz3z91jc9LM5FSNTQgTXDlyEiAnQy1G3IOEoBxgTIMekOd4HuxOjxdOV/C3Eh1Z3ttzZOHPdakqNA4+/sWFSC3ffN6WNC2tx4Zhy6LLIpOJtWEbcMgwjqlkR4nlzpIcYArPb8C6f3XlocYd30wwnPo8xsDJpfR5Xff9pv/E6T/q8UP5erQkez1RWqAr1OzznEe6Z6HFOBqH6tjceWiki1v9c34kN1Nd/U1a6Ldy+Eatr3zGVZ04XpmcoocYOQoPsUdNar5oa1fxAbdqx0HShdtmK+7m0u4r1rujHAUFXnSyNsMq+ad0XeI9w+6IiFXT7nsz3BJaglmp1lN43otozPOsbMDAI44xflY39cT+EiES3CA8NSl2M/2zUn/s2MGe/V/PeRzLLFwumLnY1RBfGsgbxgY5xaG4+romPHfLqcbvnKBR9udcJ5bJ3FhF2UTXH3KASurXIOb0KmQk4+wl0HFgFdHxZk224XHGJoRMEniHf0tjcE7i58L1F6w6az7nxnlkZgTu/aocO4+sZjWkr7a9dx0ihZ/jqFmfdjpeubQDTnLzx1Qfa+JZdD/WUb5pd3PdVD9zm9evlVnesTI+/xjSIMx/nT4lHY4Mvx07cIf9HesI5h0Qgdcjyt+iEg6c9zQcemlnCfpaLYt7liTPxhFbZh+RV4UMqKptvc= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9b6b2c6-c872-4690-ada3-08db0f5bbdd7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:51:30.9057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eL1/GdcPUJyA4YkxmCO60ZZzhFT2Ep39CcxLvYbzyot3OKnbpty0Kp4sDH1IkgqMOkDNc8N7D5ZHUnCzJqkUKyQQO3lWfHMb8R6rD8sz7HM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5626 On 08/02/2023 6:04 pm, Ross Lagerwall wrote: > Certain debug sections like ".debug_aranges" when built with GCC 11.2.1 > are missing section symbols (presumably because they're not needed). > Instead, of segfaulting, simply don't include them if they're missing. > > Signed-off-by: Ross Lagerwall Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 15 13:56:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 13:56:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496009.766506 (Exim 4.92) (envelope-from ) id 1pSIGo-0000JJ-6a; Wed, 15 Feb 2023 13:56:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496009.766506; Wed, 15 Feb 2023 13:56:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSIGo-0000JC-3t; Wed, 15 Feb 2023 13:56:26 +0000 Received: by outflank-mailman (input) for mailman id 496009; Wed, 15 Feb 2023 13:56:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSIGn-0000It-4z for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 13:56:25 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87095909-ad38-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 14:56:23 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 08:56:19 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5626.namprd03.prod.outlook.com (2603:10b6:806:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Wed, 15 Feb 2023 13:56:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 13:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87095909-ad38-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676469383; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=MeVFzpZy/LNP8iYP9g7DXTA8coJr3MPZzccw5aonJ9c=; b=bULCm1vhXumOVgAxOLoY/+mlLFypcfqgHsDR0DgUlhIlE+t+Zdju2dbW 0U0EUsAhcDAak78i/Dja1A7zJjDO8t8/oogiXSd2oXXOtzhdmXDz76jjF 2ChKperHnfBmUcB/dx2urbckmK8zYJxEGywQZQIVBTtwtnhvzYcnRJvVa Y=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 99563824 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DfFJYaBeLv+4ShVW/xniw5YqxClBgxIJ4kV8jS/XYbTApGkl1TMDy WVNXG+CO/uDYmP2fth/PN6x9kMCu5LSzd5lQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw491pDjt23 NIhGDUHfyyspMLmh7KiVbw57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTi7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6ewH2gCNhOfFG+3rlsjFPC1EUBNCI5U0GH/PboixbhRvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluaISEIKUcSaClCShEKi+QPu6k2hxPLC9xlQKi8i4SsHSmqm m7a6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHY1 JTYs6ByNNwzMKw= IronPort-HdrOrdr: A9a23:sTiMwa6mNL/OImhr3wPXwNnXdLJyesId70hD6qkRc3Fom6mj/K qTdZsgpHzJYUkqKRMdcLy7VpVoIkmxyXcW2+ks1N6ZNWHbUQCTQ72Kg7GC/9ToIVyaytJg X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="99563824" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLj4iyq0LBD4RAu+8LNFl4l7NjGEfJciWll92fhSEYJS4JuYKtH2vxAjT10XuWqitJKo2Zl5uS/0h/QCOY0jLr1cWjSgvdnVrV0fsbrP6RxcK0BxkyqtW/qLh+3AlCgTIW0JhbzFmeCu4VbSBuEr/nd7ZoALeHPxJz/Nm51nDX/OzpZYFAAqCmE28bfikFfxWzCqklzLhGYtXl9OdxAt5kA3RVXn7/gW6XkGYPnnDCIr02eJiOAob2l1V6D/LxjJdGzNE1Y4Z0MsJdPf1UVCV43zO37dq/jbvbf6hA1gZcsTzNOVIDyez25f/uC7AagDap4YsgJmKrWSwHsUgfVtbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MeVFzpZy/LNP8iYP9g7DXTA8coJr3MPZzccw5aonJ9c=; b=kkjPwK2srJvlvTuFuKyDUo+az1NbFqr5KH//yZSjnN9I7rcl+u5oVMSFTvYD/EFmAi2MDLzYaCSqEyZ20ymRSE/kaR0ttvLNozFMxye4/MF+Ov1pgYOO24uKjhd7lPTqRzYXa5u6ANgytN8P9NiibXpwxuvAnYU23vZeovxgizv8p5fHTM+yuymrtVfM3syFV9H00DkjNPOwvudRAOIwZcsc+9KkowgokHsO/cLZvh81Qp3HIL8SNa1WUlByo5VpPULrflKCcOqm4eycv5gziD1y5Z5ivzagmTTe1y5x8TkdI5kLugg6M5VWEmKA38FW5KemW8uAZmzSDf/QHQkNFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MeVFzpZy/LNP8iYP9g7DXTA8coJr3MPZzccw5aonJ9c=; b=vpXNqeu67RxEeMx3ACoTe2VfiFePWz6ubcA6sS9PTM7lQkFzRQulcPHj5BUn+CdTyAbJHDnHIDNiGaHAccDFCnDClpVAwaZuZpaqYXocd+T5miG/VNJbgHIgB+c3i8am+Ps6tydez/c5ByM2G9dcx+WqpxRDxqqq0Fg1/kg8dzY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7da2e181-8d2c-acf6-0662-36d028cd098b@citrix.com> Date: Wed, 15 Feb 2023 13:56:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Wei Liu , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0346.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA0PR03MB5626:EE_ X-MS-Office365-Filtering-Correlation-Id: ad16d59a-32d6-42a5-758a-08db0f5c68a2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MSHwg/OXjayxQ84Y8nTTNCKM96+/TXYg3pUHw+49JFhwD957+EDW9DtcWVBAIbmt7m0PyrW6mmi7hTcu+pxRf5wEmJCTL9BcjLKfIwpNrQqiKQDYQpVGejdPYVi2ksGGhDsCh/6HJ070dRAzXvu6czYfId/Eg4OUlC6ulCJwicACChgw8IR2vdRemb0QCOwAZUWwrwBmUTrr4FrAmyYDR1e00T2t4cKHmH7YZeoRTp91mETKYdsO2Xjg1QcDSZkhD/BkqeneQXHrQ8X9S6pwrzaL6qdk/TLAHYDI4taYmeICZkA/vULL7xERRa0TWoDTcRGSaR4pUuHcJQN9OLBiC83l2271BFc3BYhkBwTI7GhfgSVTV3KPwmLfzDBGSNhGrKCq0COPgL35m0w5ZvLae5AF/XyWibGVCl/j5o9MgllsI079mGuL2DQ15B637noV2PFzGAGfbQkfJil2zLc4mvXf3PIGCHSfw4IC5LfLsy1Vt2HK1DYQsK0h7/L2ML0l2zZESoE7m38l44cCI2jzBJYXQ5oi1jEBSFNXamTBGMu8Wl85kH8NEBVVP9N3MGDqsHp6oSK2+Ch8e+NomF/PzBnOztZMawivFy791GrZf7k9HWbW2GMAttUretCu19b2GAdAVCIBMtCSnnucxbCy38QgOP44Jadls90lsgAROgddvBljS0kxxBoVbwp5xYo+RQAt9fZgTU4JEPv+rkYIsMoX+9tcBMTs8yId/dhZkuA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199018)(4744005)(5660300002)(36756003)(2906002)(186003)(82960400001)(66476007)(53546011)(6512007)(26005)(2616005)(8936002)(8676002)(4326008)(38100700002)(54906003)(316002)(66946007)(478600001)(31696002)(6666004)(6506007)(41300700001)(86362001)(31686004)(6486002)(66556008)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUdHZnBPcTJxdkxwbE9GdWhEV3kwQzVLL3RuM0RSZ2NJQmhObXNDV2lEN01i?= =?utf-8?B?TEs3dUc5VUVsNVFpb2F5MnNiWFJESjVsQkp4Q3JlNlhvMWljTnVGNjlBT2Fn?= =?utf-8?B?UHV2aFF3a21FT3Nueng2Mm56VGhKVUZ1dFZmL0J4YlUxbm1Hc0xPMTlYTVhy?= =?utf-8?B?QXdKMllQeWNNd3lHS0M3bDZWMkcyTUF3bDhoYThqSTFaczA0a1FEMEd5WmZL?= =?utf-8?B?ejFZYncvdWlyVWdzMkttWW93OVpvMElxeWt2VWRMNElJSnNSajBVSkVhalFk?= =?utf-8?B?dTBvRDNQZGtncXFMNHdCRkgvWkI3WlRSOVZkR0V4alYvSnJ3L2dSRVZFQmRC?= =?utf-8?B?Q0hBbUJZOHBTYm5kRk9VSG1QbXZkM1dUQmFUM2l1dGRhVmlra0laWUVMaGRE?= =?utf-8?B?L1dsTnZpNGVjTWhJMTR3NEphcjNObW9BVGZtU1ZtYXd6OWpvTnM1U0tpUmpN?= =?utf-8?B?U3JHRUV1blhiU3ZvL0tNMDAvUUUzeEU5RXBJQjcyQ2REelJBaFFWTGdHK29r?= =?utf-8?B?clJiVXRCdC9NWXJUUlAyT2MzRHNudzVXZnQrb1Z5eVdUWTlLVmdyaml3b3hQ?= =?utf-8?B?M0ZZMm9OWWZGb1RDK3JybFR5TzVEVmY2TjJOV3pKMyt0RHN4TU00ajRadGtW?= =?utf-8?B?bTZuVmRUbUcydXhkblZLRmQ0L1phbXUrMGlCcnBnK0dFMURvUzRlcnFhSTkw?= =?utf-8?B?SUc1WU9oUERLTmNDeW1jdkg4MEo2SVNJTVgwb1VDb1d3dUxPNWJ4b0Nuc2lm?= =?utf-8?B?RTUydEwvQ0JESGxlaGRJRHRqYUxaVldjdlA2OXo0ZTNFWjJENXpXWTBpSVhT?= =?utf-8?B?L05CQmZHdFB6R1A2Nld6VTFvZVVOZ0NEVHVSS2lxU1kvcDlyNVorZWdoMVhq?= =?utf-8?B?eTZCNytFZGV2UnNiOGFSQnBmVU9mR2h5SWFaVUpBR3BQaFZSZUZ3bFQrVm9T?= =?utf-8?B?eENQTlB2NUlHdXdsWjdOKzhacTFhNTZoaHRsWG5VTmo2VVNRdjZjS1J2YnFO?= =?utf-8?B?WnRpbTNOcEpJTmJjSGJvbHR0TCtmUmZva2JhZ1NYQmFuVFlBVlB5K2MrVk01?= =?utf-8?B?ekwzSEtYQjBhdjkxcGhaa2ViZ1FFY25ucWk0TTlZcjhteWt3TUFPM24wUHFn?= =?utf-8?B?SU1xczBGTXZwUGgvSS9pdUk0SEhKYndyN29Oc2JLMEZEcUVGN3R1d2dzc3Vn?= =?utf-8?B?VnZSa2kyVUVSSENkL2h1dHoxMVp5dUpTOUJTN1pYNzJqOGFzcHpEQVArRTlM?= =?utf-8?B?MU1KOCtXUldmSm45R3lsTTJpbDFlakRDOFpwZkdaalRpS1VWOHRTVmQxZStz?= =?utf-8?B?ZnltMEJ2TVI2ZWVRSGxLTmZzY25pd2M1VmcxejlFYU53VkxKWDFOdnM2V2or?= =?utf-8?B?enFzdXBWNlNXN2NGdWxud3hBamEreDVkSHUxeDJOYUNrZWdkc3BBM09ZU0Iw?= =?utf-8?B?S1N6VVUxTHFjL0IyQnRtVTlKUnVvUmltR0pPRVJIZ0tsSENJK3BHbzl5R0or?= =?utf-8?B?T3VVYWZWWVB1OFMvZzVSZGt4NXlncDVYQ3JVUVpZTW9JWDIrQ1M4SmZMTmd5?= =?utf-8?B?cmt5NElQcExEZkdYclRXN25sdHFJVTdjaHYxZVVNRXN4QzYwbGZVYXRCTmtl?= =?utf-8?B?TmF1ckxUd1dVNHFQVUhsd0w3TFdPdGlka1RlZE1sUUZQdGJPZWFHOXF3cE1K?= =?utf-8?B?WWpFSFlvYkhCZmlCYytJNTdQOGdrNFNhbHNVWmczenN5SXVTMzdHb0pWaUJH?= =?utf-8?B?QVdvZ0JUYVZQL3QvRXV4Y3d0dnRGSDBJeDJCQXZLTEtRRGU0QzVUdmhvOEx5?= =?utf-8?B?YkFZaUFvMGRqV0FTU3JuWEh0dGJFNGs5ejYzN1N0RXpmU1hPSWNDVitSM0Ez?= =?utf-8?B?Mk1DbzhyTlFjZEd1a0F2MmVzenFBTlp5RENSMHBpc00xcXovSkNHdHBTNHBU?= =?utf-8?B?WlkyUW5aYXd6RHh2a0NEcHZ6Zm40U2RibzV3QkVCaEhmYlBRdlIzSGMwbWI4?= =?utf-8?B?cFd2ZjM1VE9HQmY5ZTNTekRJNFlsTFZiTFM4K1I2SDdCMTZYcU9wSk9SaUdX?= =?utf-8?B?bnBDRHBhWGgweVNyNmNvNnpyM29RcURPNnhkL2xNVmZFYjg4RjBJTVEwYUpn?= =?utf-8?B?UTFPVFYrbVhUSStBdW1XVE44d0pyYzRENUxaOXJJOU1MMjgvdVVKdFNYTFlt?= =?utf-8?B?SWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8D061VQVOdiAr5IVneO35NEROsYRSYhxZYtE23eV+etlB5jIxtdd8QCk16KcfrJl2S8gOQWCn3AdJrxu51SEIFjRA4OHeIX8+tBmtXD3keFdNNdico6cPysr+8E0rLIAA6GQv996LvV3P/srwmHifFlY1fRv6x+LJV5TfKe+h/WlvOn1fu9k5aWc24Cxv2c5HQxzzhNXV3Avg6ly2UkIf++UHBRnXmQ3DALFsODg62OIJipMd4SK7+IHpimBNgAUxxrxsLB5Ngaf1nVrKNHMeKQfHUBG+2yc5CF6XDu2k6V/yoXTnsbYR4j9ARe1kWBpNhFOJr7MriKbjWzKQ9eWG0w6zQAI6F/PJWd3YWGe1wLaFUNRBgNEH2tMuldt5PeT3CrSr2FA8dwF2Vcjq3ke483rYMj32mIG7ynJjcJRjhVv7Fl9jXAQdBbQTAspBIuns2anAjmxb/dGNkoH5yyabi4oVTdFbMkXPj1CutOxJErGGg7QpGvhGVJYNDisZOc5uNsTNtVpPNtHECam829EHj4y+CEfI6TnsUtQ0FAXoDAT2CFMup6DuqW2miv8HFyUy0LW7FfPH8NBoZRg2j23l5xlB8bgKXcPk71S2GnM5sbQ0+8WMhS3tX7Vqzq+5JkEuFnTqS43L3syJ5+d4M8ZAvKIfh8pVInt6kxcAQivowQTfyc1a823+v6z/wO8HBcPSjekwJM+dZsEFyDwt/AL950bXw0wZfsEtp1MA6UO4oKZZp7uBDxBGHEaQxIRdtKiRz39nBOqjj7+auE0k42Ta8grQS4PpRQnj1iFtPSKT5aKnvrGvgajwril5FISXhW+ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad16d59a-32d6-42a5-758a-08db0f5c68a2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 13:56:17.3223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YvD5NvJK0nPwY1s7OH3EWfjECqRMvSFg55xDuFWxNYQLoh+I95j+2mIM1Lehd6J7zMUSakgNJWprZsq1ltFcKxN5yX5dSbldVS3qXIsgP6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5626 On 09/02/2023 10:38 am, Jan Beulich wrote: > This is the only file left with a use of an __s type coming from > Linux. Since the file has been using an apparently random mix of all > three classes of fixed-width types (__{s,u}, {s,u}, and > {,u}int_t), consolidate this to use exclusively standard types. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 15 14:54:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 14:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496019.766523 (Exim 4.92) (envelope-from ) id 1pSJAp-0008UL-Go; Wed, 15 Feb 2023 14:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496019.766523; Wed, 15 Feb 2023 14:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJAp-0008UE-EA; Wed, 15 Feb 2023 14:54:19 +0000 Received: by outflank-mailman (input) for mailman id 496019; Wed, 15 Feb 2023 14:54:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJAo-0008U6-0r for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 14:54:18 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7d00::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d9a8b67-ad40-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 15:54:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9489.eurprd04.prod.outlook.com (2603:10a6:102:2c1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 14:54:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 14:54:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d9a8b67-ad40-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCHWvI6SPHmBM+QHw8gd8htG9zGzrYZy3hJa07Kw5PgoZCuzWsprkjqByrkN0YgRwwASG8WGF+fCEJpJFrA3DyvPy8tKpoz8jAw2kvq6DquMvwuIF3G6jK8snk1se3V3qzGNmUtorCgRQB80eWWLYNdbYgG2Bon+ddtjOIVsJAqZOy7HjziwONkBXBOpLlfF1xxIh0pOAlXtQMQM9e4eQk0o5sY5x1Gwr09dlNrcFVkvmuPWRTdPkeNxBPrw44AIxAtXP+l/3OTe4sjrZH2VBrjLC8FYgYw/t1bG/EWat3DQogzshHA/7PIg3T2FDx+4UK5LGcsbqZ4CWDKYNzujyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YGuwNLop/ql4FzbLLIEGIhrzXrHY2ndkGysncLs6Gr4=; b=bfXl6kL1bn66VmSwobQwUThJYlU5QShPXe80DpAzJC+VzLAx3h/YzY+gaPytoFS0yX2YZ7j+DFsjh9IKlN7ZFj87webg8ajflQHrCiao7ZGeoHGG0OeGVV9Zu15UgawzSN0qG4VzPwU8WyPhMohmObocKzCVpSsWH9RlSt9Ysv/BGE7lsGbGYxZItj09sHGTCeILFxI7UH/PtCiErhaJTHX2FJdxq7CLWNng6G1OJJYvWqb6URbsS0EtKqwqWEo3d41R4yYF1yjbXXlYOh6o8Fd/6MgotX0/2FyHzWgAb0K0edmyXfrjrRETohHinGfAwNChiaHkzK0bompl838wXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YGuwNLop/ql4FzbLLIEGIhrzXrHY2ndkGysncLs6Gr4=; b=X7SNHeRW08K/IztEJkwR5SPCznXurtTzGtc8O2b6ZIEI8ZR5pGESfuGLBugxbMxEzwKRdHnMCOHnu/LtrKqKmPFMXu2Nthpe0wjeji+9R/Y1f+k+7ppj53fNV2jHYfUtTM4uGIZWzHOvfOird7q3blWA0BUcYuos7cEtnONX8ry+N9YmmbaCXuDC7tuMX/hxXZuI/kQpO3zJ054FyDlS5CvqJ/2yzIRua6WgrzUsCfNQTT09kHGgjGYbyVK2+Fio0londh29tDQ6gd0LFgTWG/pJ363OQ2vWQR3GphUvrHUc+DttczNXYzmlBr5Aq9fgGvSQf468Ee+jiSpYyRQaPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <47ab9000-68f6-8925-d814-a3a955b7f6cc@suse.com> Date: Wed, 15 Feb 2023 15:54:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/PV32: restore PAE-extended-CR3 logic Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0209.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9489:EE_ X-MS-Office365-Filtering-Correlation-Id: 41ff7ecb-6600-4e50-b70b-08db0f648090 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bsk3jRPTKhs+c5u8IdElT0q1DYI98m1iGnvqZYjlCT8Dg6jQUWPCRa4M1BPj45uU5C8zrIg2hc9IDOZZA8LIJBshETyODH/bECYVOsomVBvkmKQBMBcbNFgHZGG1AJyhLKTek+77jwf/n1mDsHg02vMXNEhq9TJQSKeNagu7W1bwqUnl4aX1EHZtf8nCVdSUwG9yUFBYBDU0+QlNVl+GlEfrTWjnmhgta8vGsWhzfFKlt5C3W9fmhuEEiuIURo2ppoQ4QqgeeSgmI7ztpTWAJlc+CteSKKycUGlJrFYg2h7MJQwte4RABA5S5dKGEZuvOWq8mkAH4v6TF4zvttbAFmamTnR06vd9miwMWTZob60/OEdYXm0I50b94j+ePR/2Z0RVpnxGsYDRGf7g5gqAuAoM0kPdylT4vBkp8AbJ/tGxjSYzmnytLT8hjwGHhJyKzrKmXIeTmlaKEZi4fjZvs/OZCJmJ3+pM4KN4plyS+By52Ai9xqPqraGMQ+uKC6HaaJSNkUKU4lT13zxkBQARjqkRrYJfETT2HyEjYOMOP/xzK4HUquC9VE1woWo1Vqd2N8BSYHpmRsUnKwGa2Z2lGqRhOkf+I+KK9PbPv5yRJU9qCG6KdlXBS6jdzD9IgOGNVtumKKpgx631esQgtI+CIppSprlYo/gvoycaS/Yrc47z/15sib9pWLkdWl/IrpE9/y8VetvpPSEjDzVWvL8gkGrCdrIKiGaJ8W2bu7i6pjs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199018)(66899018)(83380400001)(54906003)(86362001)(31696002)(36756003)(26005)(186003)(6512007)(6506007)(2616005)(31686004)(66946007)(2906002)(5660300002)(8676002)(66476007)(4326008)(6916009)(66556008)(41300700001)(6486002)(478600001)(8936002)(38100700002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWN3alQxQnRFTWNvTXJRRURpSmc5dHhzaERtSlJ1Ti9TY0drc3ZWckFacElO?= =?utf-8?B?cG9JQ0hIaHkwTERFSGVWcjIzdDVIR1RjZ29FSVdxUlNBbkYwL2N1VGxLYkhT?= =?utf-8?B?bDdkM01VWFhmQ1QyZ3pZeWhIRTV6bEsyUnRwQ2VVQmRSY1JPTjF5dkhSWGF5?= =?utf-8?B?YlV2cnRtUHBOa2ljdnNpeGRpdXkwQ3ZHb1lhNlVZSTdVYnRpVkpNMU9lZ2Mx?= =?utf-8?B?V0diM3cyNG14QTgyaUZTWU4yenZKbnNqN2dxa2xUVmprVE9LZ1p0WEpzMUgx?= =?utf-8?B?VU1SQnBramUraU5TWEsyTHVhQmRrQjRyUnFrTkNiT05uSFhNRUxyMmJpR1Va?= =?utf-8?B?QThTbnRjZFJFTHpxLzgyakZlNk85UnNKb2JtSlJuNUFJSE5FdEJYRDdDV0tq?= =?utf-8?B?Sk42Rjd1NHZDdG03Qk5tUGhIeVJUSmRXbjVpVk1aWDE4YWlheXM1ZnR1bVNy?= =?utf-8?B?dzNYV3hnSFJMK01QZjVIZ3JyU2g5MDhpLzlpQ0psSUJpV05sajhGd1pyQ3VN?= =?utf-8?B?a2FTRWM0T29FQXJYR28rWTZIN3JYOHkvQXNaTWVlQlJ3cTlmUnAvR1NEb3RE?= =?utf-8?B?SEhPYTV1eDdWSTZ0cFQ1aU1YMmlJbnY1M1BSUFVLT0VZM3R3VFl6TmExUjd2?= =?utf-8?B?Tkh6VUcwU2lUZlpRSUZhZ3IrMVprdnlxaTIzMXZDc0lQNjExdU1DbFVHdHlh?= =?utf-8?B?RHBKR3JsMmVPeG1GNWZOVkEyVksrTlVPc2xiRDFsRUQzUkRSWjNmdHd1OEdz?= =?utf-8?B?dGdQUE1QRkNyNUdHSWZUUEt5elhZUUxaZXc3L2lSRjNKOXZJM1NhWlhzYlJM?= =?utf-8?B?clJUdDhDSGxiZnROWDVaQXYwVU5GMkRuTXM5WWFOL0p2aFZsQ3EySmg4TURz?= =?utf-8?B?eCtrTS84QkJtc2xYUFhvMEp2TWl0MUxObWx2K0c1T040cytodFgwbmRiTnNT?= =?utf-8?B?SkJuM2VLNVpQT3l3TVdXU1d0TEdmdjl3QWxTalh5c2Y1M2M2cnpuRm9aRkJ3?= =?utf-8?B?NFB3VVhJVlNXWUtYY3M2Qjc1MzJuTWlGcEJSSm1xeWJlUHR2cWZSUWsvZE1D?= =?utf-8?B?MnRJUlVjTnpLYkszUUVVRFg1VVp2YVlxbVB1alpraDRDVmpaeU9adTVzZ2po?= =?utf-8?B?LzhQNTluZUUxeU1OYXRwRGhJRjlUbmVmeFBMQXZmamk3Q0xyWHdNWDBROEJv?= =?utf-8?B?TW42NlBreGZaZGRvLzhsSXp1TkRGQWw1bEcyT3FONzVVTGRNMnJUU0hWZ281?= =?utf-8?B?dko3VWJqWVRQT2tHRjhnb1JmWWhldFJoUENnaFI5S1N5VTBleFVYS3Z2ZHdE?= =?utf-8?B?ZWIzRlIyTU15dzV1R1R4VXlvdVpUdUxoeG5BczdxVmJQUzVrZ2VWZG5qUnpY?= =?utf-8?B?c0UwcUFDR09EY2xDVFpkVTdTYUNMMGozanZiVGpUQklPV2JFVnBIK3FvMVhq?= =?utf-8?B?cDBuQ2VkTlVMWHJ5OG5qNW1qRUV0K0VlT1YyemVjRklSVi8wdWhxdTNOTUZI?= =?utf-8?B?azBuNEFhSHRoZVdDNUV6VDFVd25oVlZmNDFkbzdYNDYrS2tQUE1mQWJnZ0Ix?= =?utf-8?B?SDFEektDdXdLRk90SWcxS1MxSE9MSXZETU1iOGdJKzlEd0tNak9LN0hGQ3VS?= =?utf-8?B?TlVWQ2pQSEdGUE1Cd0Q3RDRKcWwrRUlZUmJHR05tVFFKWkp0YlF0a1JRYVdF?= =?utf-8?B?RHRMM3RHb1h2SzJXdUpYazFiWjhoWExrdGwyZW1BV1lJUDlRZHhHeGZKVGMr?= =?utf-8?B?T1BMTjM1RWdUdlpGYndVNTBqODNNUElhY1ZBRXFza2FaZlJjV1g4bERaN0JC?= =?utf-8?B?Z3MvRDJ2bzZYaDZaR1B6VXczTnQ4NmlCQ0FzOEdyRjNQb2RZMDVvQnBDSjln?= =?utf-8?B?UHRoWkE2eStaeFM5VDA4amZBYTkwN0kxVEtFQ1RvcjJkTnp0ZkQ5eGU0V05i?= =?utf-8?B?QW9NK1lKK1V0U3J6U2ZwQmFPbEl5TEM3MlZDbnd0VEJuL0dDM2QzcGJWL2xW?= =?utf-8?B?NjQ0OGFKTGNEQ2xKNjI3L0cwMEhOWUk5a2FMZkJlbzZIc0JBeHI2RDAyY2Zl?= =?utf-8?B?aWxLTDlYSTdkZWtHcU9vZE5rN1JocXFVZmp4bmNiU3RHUFN4cGh1T0c1cmMw?= =?utf-8?Q?RoUWgsfuBqa+krcuE0xi6nN/O?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41ff7ecb-6600-4e50-b70b-08db0f648090 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 14:54:13.2733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8fonOxPpJgfbBVcgTEhbvtZ0Tsa09VoFzQVkSRANZSP0SWC/+1ji6cTuUPNT9XXaQ80XA7arwcQ311EodttQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9489 While the PAE-extended-CR3 VM assist is a 32-bit only concept, it still applies to guests also when run on a 64-bit hypervisor: The "extended CR3" format has to be used there as well, to fit the address in the only 32-bit wide register there. As a result it was a mistake that the check was never enabled for that case, and was then mistakenly deleted in the course of removal of 32-bit-Xen code (218adf199e68 ["x86: We can assume CONFIG_PAGING_LEVELS==4"]). Similarly during Dom0 construction kernel awareness needs to be taken into account, and respective code was again mistakenly never enabled for 32-bit Dom0 when running on 64-bit Xen (and thus wrongly deleted by 5d1181a5ea5e ["xen: Remove x86_32 build target"]). At the same time restrict enabling of the assist for Dom0 to just the 32-bit case. Furthermore there's no need for an atomic update there. Signed-off-by: Jan Beulich --- I was uncertain whether to add a check to the CR3 guest read path, raising e.g. #GP(0) when the value read wouldn't fit but also may not be converted to "extended" format (overflow is possible there in principle because of the control tools "slack" in promote_l3_table()). In that context I was puzzled to find no check on the CR3 guest write path even in 4.2: A guest (bogusly) setting the PCD or PWT bits (or any of the low reserved ones) could observe anomalous behavior rather than plain failure. As to a Fixes: tag - it's pretty unclear which of the many original 32-on-64 changes to blame. I don't think the two cited commits should be referenced there, as they didn't break anything that wasn't already broken. --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1520,6 +1520,23 @@ static int promote_l3_table(struct page_ unsigned int partial_flags = page->partial_flags; l3_pgentry_t l3e = l3e_empty(); + /* + * PAE pgdirs above 4GB are unacceptable if a 32-bit guest does not + * understand the weird 'extended cr3' format for dealing with high-order + * address bits. We cut some slack for control tools (before vcpu0 is + * initialised). + */ + if ( is_pv_32bit_domain(d) && + unlikely(!VM_ASSIST(d, pae_extended_cr3)) && + mfn_x(l3mfn) >= 0x100000 && + d->vcpu[0] && d->vcpu[0]->is_initialised ) + { + gdprintk(XENLOG_WARNING, + "PAE pgd must be below 4GB (%#lx >= 0x100000)", + mfn_x(l3mfn)); + return -ERANGE; + } + pl3e = map_domain_page(l3mfn); /* --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -490,12 +490,12 @@ int __init dom0_construct_pv(struct doma nr_pages = dom0_compute_nr_pages(d, &parms, initrd_len); - if ( parms.pae == XEN_PAE_EXTCR3 ) - set_bit(VMASST_TYPE_pae_extended_cr3, &d->vm_assist); - #ifdef CONFIG_PV32 if ( elf_32bit(&elf) ) { + if ( parms.pae == XEN_PAE_EXTCR3 ) + __set_bit(VMASST_TYPE_pae_extended_cr3, &d->vm_assist); + if ( !pv_shim && (parms.virt_hv_start_low != UNSET_ADDR) ) { unsigned long value = ROUNDUP(parms.virt_hv_start_low, @@ -594,7 +594,10 @@ int __init dom0_construct_pv(struct doma vphysmap_start = parms.p2m_base; vphysmap_end = vphysmap_start + nr_pages * sizeof(unsigned long); } - page = alloc_domheap_pages(d, order, MEMF_no_scrub); + page = alloc_domheap_pages(d, order, + MEMF_no_scrub | + (VM_ASSIST(d, pae_extended_cr3) || + !compat ? 0 : MEMF_bits(32))); if ( page == NULL ) panic("Not enough RAM for domain 0 allocation\n"); alloc_spfn = mfn_x(page_to_mfn(page)); From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496025.766533 (Exim 4.92) (envelope-from ) id 1pSJLf-0001vU-H9; Wed, 15 Feb 2023 15:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496025.766533; Wed, 15 Feb 2023 15:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJLf-0001vN-EQ; Wed, 15 Feb 2023 15:05:31 +0000 Received: by outflank-mailman (input) for mailman id 496025; Wed, 15 Feb 2023 15:05:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJLd-0001vB-SM; Wed, 15 Feb 2023 15:05:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJLd-0004pd-Pi; Wed, 15 Feb 2023 15:05:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJLd-0001vu-GQ; Wed, 15 Feb 2023 15:05:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSJLd-0001aA-EZ; Wed, 15 Feb 2023 15:05:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GYf+jPL6Ip+IgmyKRinkuPl9fQ73LPATASMl9AUKV1U=; b=Q2w/ZDWbbtYayp3BJV0Wg7NtFN +rjhe4kkKcbj/GQ39VbZ6uiqCk9NxQGyOfzi/G6E1at9E+OhggkFExMDPAJg5RtGQYEUA2e3r2Xan qGarrdv6bXjCG+acpeW+/13UoIAjurqadDNx38zdaTbv6czkpXjCT2h4qFRiSQTS5Iqk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177386: all pass - PUSHED X-Osstest-Versions-This: ovmf=38da9606f77842cdcdc231210c0369a6180c51a0 X-Osstest-Versions-That: ovmf=77d6772708541a2ddf093af79816dd1831581388 From: osstest service owner Date: Wed, 15 Feb 2023 15:05:29 +0000 flight 177386 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177386/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 38da9606f77842cdcdc231210c0369a6180c51a0 baseline version: ovmf 77d6772708541a2ddf093af79816dd1831581388 Last test of basis 177365 2023-02-15 08:13:38 Z 0 days Testing same since 177386 2023-02-15 12:42:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Robert Phelps jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 77d6772708..38da9606f7 38da9606f77842cdcdc231210c0369a6180c51a0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:07:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:07:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496034.766545 (Exim 4.92) (envelope-from ) id 1pSJN5-0002Xy-Vk; Wed, 15 Feb 2023 15:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496034.766545; Wed, 15 Feb 2023 15:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJN5-0002Xr-SN; Wed, 15 Feb 2023 15:06:59 +0000 Received: by outflank-mailman (input) for mailman id 496034; Wed, 15 Feb 2023 15:06:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJN4-0002Xl-EF for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:06:58 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63100ae7-ad42-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:06:56 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id a2so19484583wrd.6 for ; Wed, 15 Feb 2023 07:06:56 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id k1-20020adff5c1000000b002bff574a250sm15976492wrp.2.2023.02.15.07.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 07:06:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63100ae7-ad42-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=AtSH9eWEOgCpl+Knmn9Kd3c6i7SdD7N3ygH83qgPUA4=; b=G4Oysiph0KX9V05uzym40LBdrCyvUhptxyfmUFE0kojxTw72Xhvw7cldkByRu8qJC/ 0fiSIrKp1lu2XsNfV7TGriYQygH+mLWypWu1M4rXzR9u4EUZaEeyyfJ7gkWPULsl58RD PLy1qlL9XbYRWrYb5mtMw1YGIv6zJhfPZc+8ADBy1y02m6klrpja2TrGPoTede5a972I eyoFCktvCTebIVk3lq7DoPrJ+os+1gr2Frrk0zbYw3HX+BwJipetpDp9STM7XeshFmAh 8FsokqPWbjn6nPsts2Jxv0/2XryFjltpn8ZWIbb575KWhZAWnTa/7ButO4MeqpEUn/GF 4Xrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AtSH9eWEOgCpl+Knmn9Kd3c6i7SdD7N3ygH83qgPUA4=; b=FD8LVrGC/OXIyXMpKEHAhV+JUwBdIQ7Bb0mkpUDrMMEixJ2kihAyXwLDUrjwc5j6fg 47R33SZQbl5pGuZWf0RsFv8NEYfeOWbYSqNAHD51NnhJY8grtDVW02NlG1YCA6GMmmeo TblArAYdPeOSVNSWx6OHniILT12LBJJ3QXLY0WWRltXv9EaiH0TQ/ZQpWIcp6hsn5yZK kC3Al3g0IcFXgT/L5AHvWJCihoUehVqxNEO5lvW0SlM6Sx88/+vqT8ro7ELxuOlRKww4 e3JKmTSFeaoBWMsKEwtlSMSAwToTq+Kt/9Vm/zbFKwgWrBJrq184Ys/gPMmEQiebUTkM Rr9w== X-Gm-Message-State: AO0yUKX4juL9Le1rUclUsPgHM2wU0PcktBlOpNCnAC881qAlGBR2GNTz /NuKi8o48AbQBpdFK76QfI0= X-Google-Smtp-Source: AK7set+bvrixUQuC6GMKfqD72yqrPnSSCEkknX/Kmn6B9fYcVHmi7Emft6mRw5l6binv0OIbuAg+zA== X-Received: by 2002:adf:f48d:0:b0:2c5:6173:72ae with SMTP id l13-20020adff48d000000b002c5617372aemr1900429wro.27.1676473615431; Wed, 15 Feb 2023 07:06:55 -0800 (PST) Message-ID: <94ee1afd206fb4c9808560d57a13cf59e721463c.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Wed, 15 Feb 2023 17:06:53 +0200 In-Reply-To: <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-02-14 at 17:55 +0100, Jan Beulich wrote: > On 14.02.2023 17:22, Oleksii wrote: > > On Mon, 2023-02-13 at 13:24 +0100, Jan Beulich wrote: > > > On 03.02.2023 18:05, Oleksii Kurochko wrote: > > > > --- a/xen/common/Kconfig > > > > +++ b/xen/common/Kconfig > > > > @@ -92,6 +92,12 @@ config STATIC_MEMORY > > > > =C2=A0 > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If unsure, s= ay N. > > > > =C2=A0 > > > > +config GENERIC_DO_BUG_FRAME > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Generic do_bug_fr= ame() function is needed to handle > > > > the > > > > type of bug > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 frame and print a= n information about it. > > >=20 > > > Generally help text for prompt-less functions is not very useful. > > > Assuming > > > it is put here to inform people actually reading the source file, > > > I'm > > > okay > > > for it to be left here, but please at least drop the stray "an". > > > I > > > also > > > think this may want moving up in the file, e.g. ahead of all the > > > HAS_* > > > controls (which, as you will notice, all have no help text > > > either). > > > Plus > > > finally how about shorter and more applicable GENERIC_BUG_FRAME - > > > after > > > all what becomes generic is more than just do_bug_frame()? > > Thanks for the comments. I will take them into account. > > Right now only do_bug_frame() is expected to be generic. >=20 > Hmm, do you mean to undo part of what you've done? I didn't think > you would. Yet in what you've done so far, the struct an several > macros are also generalized. Hence the "DO" in the name is too > narrow from my pov. >=20 No, I don't undo part of what I have done. I misunderstood your initial message. So yeah, I will remove "DO" I think it will be more correct. > > > > --- /dev/null > > > > +++ b/xen/include/xen/bug.h > > > > @@ -0,0 +1,127 @@ > > > > +#ifndef __XEN_BUG_H__ > > > > +#define __XEN_BUG_H__ > > > > + > > > > +#define BUG_DISP_WIDTH=C2=A0=C2=A0=C2=A0 24 > > > > +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > > > > +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > > > > + > > > > +#define BUGFRAME_run_fn 0 > > > > +#define BUGFRAME_warn=C2=A0=C2=A0 1 > > > > +#define BUGFRAME_bug=C2=A0=C2=A0=C2=A0 2 > > > > +#define BUGFRAME_assert 3 > > > > + > > > > +#define BUGFRAME_NR=C2=A0=C2=A0=C2=A0=C2=A0 4 > > > > + > > > > +#ifndef __ASSEMBLY__ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > >=20 > > > Again - please sort headers. > > >=20 > > > > +#include > > > > + > > > > +#ifndef BUG_FRAME_STUFF > > > > +struct bug_frame { > > >=20 > > > Please can we have a blank line between the above two ones and > > > then > > > similarly > > > ahead of the #endif? > > Sure. > >=20 > > >=20 > > > > +=C2=A0=C2=A0=C2=A0 signed int loc_disp;=C2=A0=C2=A0=C2=A0 /* Relat= ive address to the bug > > > > address > > > > */ > > > > +=C2=A0=C2=A0=C2=A0 signed int file_disp;=C2=A0=C2=A0 /* Relative a= ddress to the > > > > filename */ > > > > +=C2=A0=C2=A0=C2=A0 signed int msg_disp;=C2=A0=C2=A0=C2=A0 /* Relat= ive address to the > > > > predicate > > > > (for ASSERT) */ > > > > +=C2=A0=C2=A0=C2=A0 uint16_t line;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 /* Line number */ > > > > +=C2=A0=C2=A0=C2=A0 uint32_t pad0:16;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 /* Padding for 8-bytes align */ > > >=20 > > > Already the original comment in Arm code is wrong: The padding > > > doesn't > > > guarantee 8-byte alignment; it merely guarantees a multiple of 8 > > > bytes > > > size. Aiui there's also no need for 8-byte alignment anywhere > > > here > > > (in > > > fact there's ".p2align 2" in the generator macros). > > >=20 > > > I also wonder why this needs to be a named bitfield: Either make > > > it > > > plain uint16_t, or if you use a bitfield, then omit the name. > > >=20 > > It will better to change it to 'uint16_t' as I don't see any reason > > to > > use 'uint32_t' with bitfield here. > > I'll check if we need the alignment. If there=C2=A0 is '.p2align 2' we > > really don't need it. >=20 > See Julien's replies any my responses: FTAOD I did _not_ ask to > remove > the field. I didn't see his reply so I'll read it too. >=20 > > > > +}; > > > > + > > > > +#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > > > > +#define bug_file(b) ((const void *)(b) + (b)->file_disp); > > > > +#define bug_line(b) ((b)->line) > > > > +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) > > > > +#endif /* BUG_FRAME_STUFF */ > > > > + > > > > +#ifndef BUG_FRAME > > > > +/* Many versions of GCC doesn't support the asm %c parameter > > > > which > > > > would > > > > + * be preferable to this unpleasantness. We use mergeable > > > > string > > > > + * sections to avoid multiple copies of the string appearing > > > > in > > > > the > > > > + * Xen image. BUGFRAME_run_fn needs to be handled separately. > > > > + */ > > >=20 > > > When generalizing the logic, I wonder in how far the comment > > > doesn't > > > want re-wording some. For example, while Arm prefixes constant > > > insn > > > operands with # (and x86 uses $), there's no such prefix in RISC- > > > V. > > > At > > > which point there's no need to use %c in the first place. (Which > > > in > > > turn means x86'es more compact representation may also be usable > > > there. > > > And yet in turn the question arises whether RISC-V wouldn't > > > better > > > have > > > its own derivation of the machinery, rather than trying to > > > generalize > > > things. RISC-V's would then likely be closer to x86'es, just > > > without > > > the use of %c on asm() operands. Which might then suggest to > > > rather > > > generalize x86'es variant down the road.) > > ARM version is more portable because of the '%c' modifier which is > > not > > present everywhere, so I decided to use it as a generic > > implementation. > > Moreover I don't see any reason why we can't switch x86 > > implementation > > to 'generic/ARM'. >=20 > That would increase data size on x86 for no gain, from all I can > tell. You are right. It will increase data size. One more point regarding portability is that x86 uses an 'i' constraint modifier that GCC won't allow when PIE is enabled, so it doesn't look like the best option to use as generic. >=20 > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ".hword " __strin= gify(line) ", > > > > 0\n"=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > >=20 > > > Hmm, .hword. How generic is support for that in assemblers? I > > > notice > > > even > > > very old gas has support for it, but architectures may not > > > consider > > > it > > > two bytes wide. (On x86, for example, it's bogus to be two bytes, > > > since > > > .word also produces 2 bytes of data. And indeed MIPS and NDS32 > > > override it > > > in gas to produce 1 byte of data only, at least in certain > > > cases.) > > > I'd > > > like to suggest to use a fourth .long here, and to drop the > > > padding > > > field > > > from struct bug_frame in exchange. > > Changing .hword to .half can make the code more portable and > > generic, > > as .half is a more standard and widely supported assembler > > directive > > for declaring 16-bit data.=20 >=20 > And how is "half" better than "hword" in the mentioned respect? Half > a word is still a byte on x86 (due to its 16-bit history). >=20 > That said - from all I can tell by briefly looking at gas sources, > there's no ".half" there. Then, it will still be an issue. So then the best solution will be to change it to the type recommended before. >=20 > Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:08:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496040.766556 (Exim 4.92) (envelope-from ) id 1pSJOp-00037k-A0; Wed, 15 Feb 2023 15:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496040.766556; Wed, 15 Feb 2023 15:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJOp-00037d-7J; Wed, 15 Feb 2023 15:08:47 +0000 Received: by outflank-mailman (input) for mailman id 496040; Wed, 15 Feb 2023 15:08:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJOo-00037T-58 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:08:46 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061b.outbound.protection.outlook.com [2a01:111:f400:fe02::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a34ca140-ad42-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:08:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7317.eurprd04.prod.outlook.com (2603:10a6:10:1b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 15:08:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 15:08:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a34ca140-ad42-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJMEqDCtqsW88J+7nFgVp4KSkaSxp+opvhoOviUvwV1IpHY2uP8gwCOJYb6/ruQgFGhMMmfnRjm1Ha6JfVB8nZ3IxdYrvbPMo0GsiY+Bw4gr/syS5cU3ywr+omuDTZ5YtQ1p+mVHnWaicCQe6u7u7eOH1I4fB4PKf07vKom16pbGaK37boLWqgXk3PVEBTPLoCHxJYDvGvbQ2jC6fP06Hx8N8qqCX1i8SF83ukoClfM70A3bbgjmmGzbGTqfhww9hHsQm+aIrfQHA0xSqfwwlTQDKEDYOgscZP3Oyw73a61i4g0At5CunGRXb4bNow3pC19jAGKsjCh1wLrTS0Ho5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jyt9Zb2uyb7Ppza5owbKi9EJTd2x28VYqhSfL00cOqI=; b=NUxtHyuAi12RV/hRAA3vUFqsgjtcK6D0apSkq+eEZ5ptrpmTkbaIB5s63R6H3iJ+pSBU8wRQf3yRoHJa3r5lWLCru22cKONzyMhrIXHdSbQyVZ7COLf8nXaE2aZaD+3wdlb311Zpwp8gvnjtlUX3xDan19pjaI0TvlzaEE9y8UWK3iLaQ38Ir1V3khGcNAZ13PEPj/PmlMPA/xCE6Wp/YrYoUbD8VUwhBXahb8uYVRVFmErKURzfk8qpKchzlOHqSyXq6n8TYyjhLbzdYBt186ggOBEYjGU0uGMdoe7cg0+h0Ybk1QoaHH+TJKzNDmOdwhjlvojkBlGRB/VwBm3n5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jyt9Zb2uyb7Ppza5owbKi9EJTd2x28VYqhSfL00cOqI=; b=r9i1Mur7lgtTDcdFfn2/yU8aulFg26WbqIUTOyzKdEuN8VWo/G6yVXS+ySsdP06tPCFqEqefTk7BCmZFkzkUFD3i9KfOq53wjQEq+s1tQpqYEahV/NKY5bMHNnBSdV++IlXkWXc5HZTKn2ZAlgEQFyOVYE1iMmVBHRzCqH5Kv1CiMDEz4F3z+n8E/g7ndKBVOx7KJzRSRJ5pW+YjXp8y/FwrBRu0ge9zYjQL6Dnhf5hZHlHFV/9jPyHPVYWKL5SonmSoVIP3uvVP238aMQspiOZps8A4k+MhK58/PZVM0klcMcSHK+iTZpKDoOWiIrY9wKPdOi1FSQXHUgQSdscg4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 16:08:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] libelf: relax ELF_PADDR_OFFSET && !VIRT_BASE check for PVH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7317:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cd94585-647a-445b-c469-08db0f66863e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6zHFQTyspvI8qYT5WCpqTm56vLh0ePO9PKEFC1AKhH/9EK0nkM3qZJxkKEWD0C3JwTEVDQdzI4ZjI/mmmm25RM1leG9j6t4l2RCVy/bXb8MemJKu66GdjGjKuphc+/ZRi5Q7k9YVgylEXGWcxUzojNamUurDqGrxmQs5HYo/TAxJG7c6S2a61E7cwZN8OFlwK9t5eicKap1MX0uErjCVqc5VJqcxBQv/A1aYaP0jwWXQNJ0bh5NHgbr04eYiuj9L7mVg5TxELc9Ad1mfm+vEdzSLJ9ft6xRQ9wZoGqyjDBa1bdvExTi7ocWPWHblFK7hlx1EvM7PG8vYtWlxcrCY5+kZWv0b60wks3GZgdFDNC78zZyXgGGZnJpqV167S8qgsk4XU5BDVmo4Dg/7/IRECxefDjFUr5VHZe1spntzkkzghUmex3lb/H8RHWdN9gaRYik9RLPMB6sD3fT8yMibQdwhCXAi4rTVvJQpWgHilMAdgCLTuZ7yxU4a4JHAORockHE8O53O6qUtKk0hp9xe1SeO2h1DecVBQ0kxPbc/hbPo2TbuM/E4uOAQRoN2E1Lf2O5VAQJO30W7kSdVd5D5R/zu1yl8PRRioKShZ7zeSt3JM3NaaH5HUlYt955vql16dFK6r7MQia0Rz0OP89mDrSbDt2zBCYZpLf18NUrZqv2A0+eWNhqh61R1+Ex3CEayHh22s5XWdHCVS2U5opfTNlUmIhJfCYdI2w90eatOn0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39850400004)(346002)(136003)(376002)(451199018)(31696002)(6486002)(36756003)(316002)(54906003)(6916009)(66556008)(8676002)(66476007)(66946007)(4326008)(2906002)(8936002)(41300700001)(4744005)(5660300002)(38100700002)(26005)(6512007)(186003)(6506007)(2616005)(478600001)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1dyNWliUTlvWCtkTW93UDdpaWU4bTg2U2U1N2ZFTGZlWE91TWQ0aUpwOG51?= =?utf-8?B?VCtnLzNUK0FKVVdCK0x5VktBdVhxckNiQUVJM01pdGFNdTF0cTJ3MGxkdXRJ?= =?utf-8?B?UW1sZklHcndxYnhFUjhCam9FN041anRaZi9MdWdSTis2N2hLZWZjTXVyTjNN?= =?utf-8?B?bVJ0c0lXdjRFT1kvRnlPV1BYMnJaTml1YXpxSElMWnZRZ0xxQlVKdGR4ZEVn?= =?utf-8?B?Y01VVkhub2hPZ0d5dEFSV054WlZtbVN5Y0NncGQ3R3d5aVlaRFdHUmYxYWdN?= =?utf-8?B?Z2hFaGswcHBUVXViWjBBV3d2OEwway9nS0ZEMVlaUUJNYWoyc3F3QkVTWHB1?= =?utf-8?B?VmU0NEJXZjh5d0FiOHRBKzRNSTljS0RQU3FxNjBVYWo5TVpXOTlNSzBtZC80?= =?utf-8?B?bEc2c2lxc0U3OW90U2t0aFN1bC8ySnNWMDZMRzlmNmNXKzh0Z0RPV2JvZ2s1?= =?utf-8?B?dFNLTkR0M09Db3ZSZXZUaVdkVFV5MGo2Qm9lNVZCVW8xYTEwWUkrempWN3E3?= =?utf-8?B?Y3I0c3N4VUpWUDIvRnFQc1I1dExDYkhGUmZJdmE2dXg3RWtxRm1XV3QzWWFq?= =?utf-8?B?Mmg2eHhTWVFSYnoxOVN2dkFjcW5CVWlJT0dTVFhHZFFWTy91dkpBVUhHTXRI?= =?utf-8?B?akRpMzNDVnhRaGVlNnRlT3YyRm80NUg3eGt0cVkyZEJMZVoyalFwSjZvV1BZ?= =?utf-8?B?andZSm9HNnhvVnUxaktTa0Y5cVhSN1BLcU9HMm81dnBxL3UzVlhucWp3ZDNC?= =?utf-8?B?ZDJRVGd3WTdOU1o5RlErSEo5M1hvN3cyaHV4YjB1ZDk4ZG9xQ3ZRcFBpb3lu?= =?utf-8?B?dyt6MjZLdGtUVW1oWS90bzc1a2N4cTdQdHN4Zk4wWUx5RHkrUTJDVS9KT09G?= =?utf-8?B?OTl4SUhEMWdhQlRpM25KbGlNck8rV0ZuVU9waEZZUEhKa0FkNk9Ud2krRU9X?= =?utf-8?B?dU1zZ2xBSEdIeHRBd0orMGVUbFRzYnBnTjFmRzZuT2RCc3NjbmNzMFVKMjJY?= =?utf-8?B?SWk1K0tuR3l3b0Iyc0UzWkFNOENDVHpvb3FZY0hDRlhkKzRwbWJnd05yazVj?= =?utf-8?B?ZWppclVhS0tDMUFQamJaQUt0TTVVUUs3ME02TW9uSmQwcFhMMzFQRmtKeHVr?= =?utf-8?B?bjM1S0VJRUNiOERlWkdnVnAwQzRlUUpaelA4L1RxbHo3VGJEbnkzNG5BRHQz?= =?utf-8?B?dmdSOGNBU1lQM0F0Y3ZGdURHeFlubkVObmlzUFpZM1RoSTVjb01IWlB5eTlV?= =?utf-8?B?RS9od0VoZ1RxRkR5UlVrVVJMc09CNWY0TC9La1UyZ2dJcW1zUWxmYS9EaXpF?= =?utf-8?B?NXN0c1dQS0YraGtnVUN1Z0wyb2Y2c0k1REhPSGdialBwR09penJpa3hRblBX?= =?utf-8?B?L3RFb3h4UDk4d0lqSzlYMDZ3V3doS1Z1YmsvMnJyNHZWTHFJTlBtbXVkaC9D?= =?utf-8?B?eEhJWWtMaEQ5MUFCbHNsQWhPMExqbFp4czhqTjRiODQxY3p2WUt2enRLa1ZV?= =?utf-8?B?elUyVE9hblBLVEZJc1FHUmp4eFQ4YzRHZnJ3NjExWjBMekh3eiszOTBQK004?= =?utf-8?B?c0NEalJuR1JMaStCU1ZzQXJ3WVk2SVdpZnA0VGJSMTM4bzE4dVRoMjQ2MjMw?= =?utf-8?B?L1VPMFp6c05NQzMyYVlQM0V0ZUVXZUFPRHNhclRxMUNOeFl0TkRuTVRxaGow?= =?utf-8?B?T2tvUmJqRjlYei92bUhaN2dBS2dTeThBaGQ3L0VyMWpZQlhSRDNuNDB0bENE?= =?utf-8?B?QWozamV2WGxFZGJIMVBhWUZmeDFLRXlpbjJUQS9zcHBGM1hmd2tKTkt4Ui84?= =?utf-8?B?aXpSUWtPejYrY0RaZ0M1RkRRbTVQdzdTSTVWckVFT3J5R3JZVDI3dVprczRE?= =?utf-8?B?RzJjSlk3NklzbEhHWHVRTGJNcEdEdUFJSytFT1doeDBZaHFrUTZWUFpKaFZN?= =?utf-8?B?TWhRWTdRaDhNbDdOazNaTzg2YVhGc3d5SDFPa2w2ZnhvM2E3RXRkTlZqYnVk?= =?utf-8?B?a1NSSzhFK01pL2EzV0E1ZENWeDUvOG1FdlBSRlJ3RHJyd2VHVUdWNzNtUGpM?= =?utf-8?B?Sm53aTJRUlhlNVhmdmVlM2NlN0lZUVIvVkE2WW0xUWl2VE5uOERTaUEwakJL?= =?utf-8?Q?z1DqqPUdCElEdlsvxtbhLSx8v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cd94585-647a-445b-c469-08db0f66863e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:08:41.7960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Y4M/6o7aKlNzM3G/pFpOgTsGYBA9hk9PxPafP1kh9J6Ik6LykToBPMlPWyhhyukO2qVwBCak7xTXA9a8FvOzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7317 Both values are unconditionally overridden (to 0) in the "hvm" (i.e. PVH) case. There's therefore no reason to punish a PVH kernel for setting the former but not the latter. Fixes: 632cbaf1243e ("libelf: improve PVH elfnote parsing") Signed-off-by: Jan Beulich --- a/xen/common/libelf/libelf-dominfo.c +++ b/xen/common/libelf/libelf-dominfo.c @@ -419,7 +419,8 @@ static elf_errorstatus elf_xen_addr_calc uint64_t virt_offset; if ( (parms->elf_paddr_offset != UNSET_ADDR) && - (parms->virt_base == UNSET_ADDR) ) + (parms->virt_base == UNSET_ADDR) && + !hvm ) { elf_err(elf, "ERROR: ELF_PADDR_OFFSET set, VIRT_BASE unset\n"); return -1; From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:10:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496045.766567 (Exim 4.92) (envelope-from ) id 1pSJQb-0004ce-Ku; Wed, 15 Feb 2023 15:10:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496045.766567; Wed, 15 Feb 2023 15:10:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJQb-0004cX-I3; Wed, 15 Feb 2023 15:10:37 +0000 Received: by outflank-mailman (input) for mailman id 496045; Wed, 15 Feb 2023 15:10:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJQa-0004cR-QY for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:10:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0c::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5f301af-ad42-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 16:10:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7317.eurprd04.prod.outlook.com (2603:10a6:10:1b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 15:10:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 15:10:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5f301af-ad42-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HN9ImcLX8EccO0/mhj/fF3yySVnmRxNcfoAEpyw42OYtmRtk58r6Duc3U5LYAOPMzKIPiwHp/mctP52UEYZwbRT9QFX/xAoP73cXZnzUpMPBHRapz77VkB+2qVJvKN3Jf92+1j+ytqcWgpNCURmh73Sxz/uAbSFf2C+XCrPOb2W4tR1QXMAIiLu8yFdUWw6vUmkPJQBGkUv6ZWjNYh2MZckbsxeQPIAvUUFl5oMc1XAH9OFj4I5QH8F3WR18NEww0Ei3c/YtBlH0Ba4Xml+B+7G7X2BfByfBtR+C4l8z0/iEErfCmv6iFW8Mmwx1ueTIRu5Lur6vQUiOveNejBxwZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6by/01wQhc29qxO37JY8k+FM1lQfm499S2Toxg3O0o=; b=ey3Dv09UOpYEswUTzuVTGWc5WKRv1MM342mFekVOqN+6S0SU2kqBnYgLi3HzpL7ghISHmwp1zp5giUsrCRCOlFnTHBmQjw2LPFSRqJN8f7kZ+jri7bz+19g0PLyrsvdbxouUbRtAGa5a0L84w8jC7oFsfZYI9U4EWX9hvrRvFIjaTpySGl5RL5+UpM8QHDWwerCxH+fT8tu2vfVFwFt+sI7cUhPeEECLLQvR4aERLq/yXE0h2fYbNqHn/ZOz4JhQrOajOAd7LVZJDWmp+ZLqJfQRvwBfFWKWJobTQFLR5464OZiSkBkv2w3HN3055dO9vtrfSQwJupw4kr1KEzUrRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6by/01wQhc29qxO37JY8k+FM1lQfm499S2Toxg3O0o=; b=nKrGtzvB0BnvzOoL474ww8klEpBdJpoCTILuP9Y3PQ5DQZsb+dLwSzB7XZjs6f019gI3M03T7DN2zeEZEbqUkcl1cW4XKOvcLxspnBa7UXhCct/Ws/3viAogfLtXI0dIpKVQExQMfd7VGwoyxO6/wcA/ruyTq5bbIIB9ZlYy7wKFWSLqXX+xkBT/9TrTlTFUvdOFzm9bRzITgj9box8cZXbduhUI9cvnOp9C8vXeUxmXTQ+CGWnvtmI42fAHRoZOa19dFt+6l1nEHRZzjeNU9oP/PxJIWoPkuFYFpooFBe60sxd3sDcLnyjTVW7KPnEWynGzMCKqVIwWa2cYlYOA6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 16:10:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7317:EE_ X-MS-Office365-Filtering-Correlation-Id: e3d6513a-0fb1-470f-b2ef-08db0f66c963 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3tGGW/iUjuor6XnlNTP9tbJH4RE2OVU3gFN94VFZYGJhDfpm6nt0VZeZsCWxdlobB0i4413ASseWpykalggXCqfevSOqC9jKUAn03rorLEQjUvuX1KsnOkEL3EEMjXh17ky1wVdXsnp0epI3i9ct6ZqAs0gOH/jth8f9F3RPijOhI3IVCfP0VpendVQMY7fxhUCfzQqjs8HgqnJY5ArEJ1xb4KNq8S8vUrxYGypIRMPDKZdRVIxn0qR6LNv7e6tM56KPVzBvWFz7KfI862/CbEO1poWASnX7A4LHFAwwYGq0imz4dG2eFZKiaS/PoXduDb9iqfTU6JOf/S5Vn5fpeRkgjLZio66Bz6Vy2s62qdN1Buf36kXL0EGqxc81WEzQD2lEvgGxOpnNGAhUcyzuqOLNgMkpUOyrYbaH7JEshrIEcJlqCioj1OamfDlhgSYMWQdcgKt7EABYuTyCsfk/lju1QI4pUaDKllVqsrnWwtUPenzT8VkYoFGPxsk2RPf4gKjp13OOP/xjI8X7X3UR+LOrNjZ8TdJ3LaPHkwc1/HeHI2RtSKCgb0Jc9HzYhWR+EC4ssgB/GOu89O2pYKf/WxupBnnVqBxr3CQ+M5X08GyvtTTdWRF4tKyTD0sX+zxNiU/MuaIPWPfMmjXpzMKNnBt6SC4umPCQBSqdw8GL/ya/4LZ+wo3b7icgNF5RY4etyEla96Q3NIb5MguzeRYpQIiCS+tZdcjJhRAJcFp7jCA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39850400004)(346002)(136003)(376002)(451199018)(31696002)(6486002)(36756003)(316002)(54906003)(6916009)(66556008)(8676002)(66476007)(66946007)(4326008)(2906002)(8936002)(41300700001)(5660300002)(38100700002)(26005)(6512007)(186003)(6506007)(83380400001)(2616005)(478600001)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUN6Nnc4RXEwVUdPM0huTXJSUnMyeUplbjgwb0FYL2RMYXdkeks3cVhEc3Fw?= =?utf-8?B?ODQ1QlZ3K2lXMnFCRDhyU3drUE5OeXBhelR0c3AyekhITDduRTc1UmFuNGhv?= =?utf-8?B?dXZIaEVNdTZKZ29xeFZPWXJJVE81RDFsQ0ZqNE9UY0RHcjB0dXR1YkJJTlpC?= =?utf-8?B?ZE9vRjZMazdjL0tkTjNRUzQ2QUxQcWJDQk0rcncvbXZhZFhva2tBeFY4K2Vx?= =?utf-8?B?Q0h4M0RFdDR3bUp6eEVNZnRnb0dYMDg1OUlEalNPaHFueXNkTTJ2cU0rWUlv?= =?utf-8?B?TnZrRitaNGptMXpxaUo2SFJSMjRKZzRaV2s3VVVTTFcyVU5pdi9RdnhVcU16?= =?utf-8?B?aHJPcXFPUzdqU25vbGdHN1pvN0dDZ2hUaGFCK0RhTlRlMmlLWW9ZNXY2UnV1?= =?utf-8?B?U0FRa2xlbW1yd3d3dUZVcFc1UFlXaXBTcXVrRHRyaVo1Tm9PdmIydmhpTkQ0?= =?utf-8?B?aVFpeXA3LzRFT1lnWThQN0JULy9uNGFUVC91UGUxa2liOTllQmk3N1dqUHhX?= =?utf-8?B?d2lpaE43UVg2dEZ2WStTSDR4alE2VmVtZFJ0ZFRMdjVCaWM0RUVjbHFkN0NU?= =?utf-8?B?Zjl3WjNmYUx6OUR1KzRIRFM2REhlb0lQdGxTWVVqSEM1SlU3SXQ1cE5Jb2Fj?= =?utf-8?B?QmdUR0VDeThGS3hrL0dBenJDSXhXOHkyQU95Zm1RSkM2SU9YbjlQR2lMVFVJ?= =?utf-8?B?Z21mamhoUldzb0Urc3ZtNWVzakRDWm9FUStxbmhQK0w2QStvS2RrZjRvaGs2?= =?utf-8?B?WTZYZWlrek1wdDN5OGJqcXliYVQyZ2tjbk1KT2w2S3VVaXhxVUViMnZGbWEw?= =?utf-8?B?UkxQMTFhSnI2MGwreE5ybmcwYldIUWU4dnN0T1dXUndxbElqYmZ0R0FsaFRY?= =?utf-8?B?MGZOcTZ5NTJrMG1OZ0FSQ0hDdVpsVE53akpGY0tKTTY4OVp1M2ZHNE5SYkgw?= =?utf-8?B?dmhsbC8wQU50TFViR3d1d3JJQ090TjFVTUJwTHpCMmtoOWtsZXEwMWRRN2tG?= =?utf-8?B?UUhzenIzZ3p4RER1M3RLejJZbXZjbWppWDljbEZ5RXY4b1lyMmR5VG04TGs2?= =?utf-8?B?dWNlcG93TkFnTmFxNXFxYVFWeUhnOEorajNNeDhMZWpxN3FGUURxTFlWeFcz?= =?utf-8?B?alJWWlZDZTV6ZkJ3clhTZGhUNnZ2aG9VSTBTb2JZQWtUeklUc2l4dkZ5V3FU?= =?utf-8?B?QmY2ZDN1ZExqcFFjeE1NZ0ovbzMrUVNWSDhQOG8wZDZobklwUlFUWEM1bVps?= =?utf-8?B?MmxPOUQ3SURIZXR6QkxYQTVNeE1HN3hBL2trN0RBcFhiUytHWk5jK2MzL1FW?= =?utf-8?B?Y3pHZ2VINHJyOG5RM3JuWkVVMVRybTVHRVVVRlpBdHVIM1doSjA2WFlEd0w5?= =?utf-8?B?eG04RnFGV1RhbGhqQTNacDNya0dxUWpqY0VZM250SXBsa3YxbUk1Rnh4UDdM?= =?utf-8?B?bmJoeXdlNExJSUtDcWlFTHlqaVFyMFdZTkxDZG1kNG9DT3R2WlgyZWtUd1JZ?= =?utf-8?B?NHphaG96NzkrZk90U1hCdWlhenpVNWdDejB6U1IrTjNMWnJ5WmlGWDdMRWdB?= =?utf-8?B?VXpZZVQ5RHNxdUZ5R3ZGSExJNHNFSW1kTjk0anl3VDExb0l1QnRlWHhxYkhz?= =?utf-8?B?ZWxaclRubGFRdU43amNjRHRheVU4WXlUQytYWkk4MFhoNktqQ1hyZHdmc0pu?= =?utf-8?B?bmVSbXFiODA4Z3hoN2ZNQk9UVFRKU1lQZFV4dERoZ3hiYkRtNHp1WXpLTnZl?= =?utf-8?B?cytHSm1aQ2hObHhheHN1ckYzdkdZMlRYQnJUbmFTTmtQTHpJUEpaVkpYdVdt?= =?utf-8?B?UzFOK21Zb2ZqNnVvUVBIUHd5bC9acVhxYk1uYWJLbVpZUjlRV2lIdG9BSlZ1?= =?utf-8?B?Y2NrdEpiYkYvUU5MQXc2REFEVGNkZmNjN0VKYU5BTUtIcEdHTzM0ZlhNQXIw?= =?utf-8?B?SW9jTURNbUFMK09EYlVqcFZvZDU5ZnJ0TVZwdFc3akpRSlFwOFAxTVR5Yjhk?= =?utf-8?B?Vzg1QzdlOGhqTjg1cVQrblJxQytNK2FpYnZ4QlllTjExTVc0RlU1N09rRWRQ?= =?utf-8?B?VFh6bCtoWmEranJ4Y3ZnNFplWHptc0RQUTBRRXhMZjJvVFlNN3JrQ2hXRHB3?= =?utf-8?Q?v+ejLY8JqjIv8PL45VfoffYVt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3d6513a-0fb1-470f-b2ef-08db0f66c963 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:10:34.4923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lO7UWvoACaWYe0UW4yIncLDpNVnCErR9Dhzv1K6oWa0EpRsBKuiA3e3S12GTzyxrN9Aq9mVBwyAFsitB/ChRMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7317 Besides a printk() the main effect is slight corruption of the start info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended up as xen-3.0-x86_64p. Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") Signed-off-by: Jan Beulich --- RFC: While Linux works fine with the adjustment, I'm not entirely certain of external tools (kexec?) having grown a dependency. It may be worth noting that XenoLinux and its forward ports never had this ELF note in 64-bit kernels, so in principle it may be reasonable to expect that no such dependency exists anywhere. Prior to "x86/PV32: restore PAE-extended-CR3 logic" that (meaningless for 64-bit domains) VM-assist could also be enabled, based on the ELF note's value. I expect that change to go in first, at which point the description here is going to be correct. --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -459,8 +459,13 @@ int __init dom0_construct_pv(struct doma compat = is_pv_32bit_domain(d); if ( elf_64bit(&elf) && machine == EM_X86_64 ) + { compatible = true; + /* Zap meaningless setting which kernels may carry by mistake. */ + parms.pae = 0; + } + if ( elf_msb(&elf) ) compatible = false; From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:17:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:17:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496055.766578 (Exim 4.92) (envelope-from ) id 1pSJXD-0005Xi-FX; Wed, 15 Feb 2023 15:17:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496055.766578; Wed, 15 Feb 2023 15:17:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJXD-0005Xb-Bj; Wed, 15 Feb 2023 15:17:27 +0000 Received: by outflank-mailman (input) for mailman id 496055; Wed, 15 Feb 2023 15:17:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJXC-0005XV-HW for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:17:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0c::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9f582c3-ad43-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 16:17:25 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9711.eurprd04.prod.outlook.com (2603:10a6:102:26c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 15:17:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 15:17:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9f582c3-ad43-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cB8cY4cxCH3ztgZfdRcV2xfHQK+OdkJukr8zM4Mmu1dT6JKhIWlixIf/k57dP0KljtGIf10qBx46dOLKsPGgs3/5sDGO26t+nlRLpxC1S1whX6oN9dvXO5v8L/lQLyLDzNTBwMMMS4zcJxFTI+JJPTkeynrgMMIhwO6ofTPX/nPQ3LKfmpruUrOKTWeWpos6SmggyAIbbdgfeotFY+UPj304rmhs+mJGYgZnQQvHXSxWxYcFhgDBKr2P9eogID7g5cSJ1D4Uw0GpR11h1T4aNgC65Lne2BtZh5eRjarEki2uZfCW3SyUlLqbENpiCc7EbrjZUNxv6v2b1OugBFwlxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3A6NwPDaj/ZH+tXLqgrQMa08nilj5M/qa5o8lwHFz30=; b=TXD3gGQquR//7tNfpE/SlFu1iln1uLZX6ERE1Yyl+M+WVaalKhrL7xme1wZ/zO7CvbvlndixF+YtjQcB7obxbmmJg5EuKJreQ+sfcI/yQ0C8we4iKQt99anqEPdOqyil1hNr2aZYrU6uZuaI16bRDVAVlDCZOJq/7P4pQ5o4uLutjdW5matgJHxFH5veRvhw65gJL8mT3U8gNJU/hcWkQoL5LPC7I2asuZv4KJ1Vy6avo7ux3e+aQ/KVD4uZBFgymT4DCTwciWsz8oSbz9PipZWQQhadhCBVBvGXZHM51nOw/JCPo6skLGB7imQd7G0QzCttqe5KJZi31YStvD/yGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3A6NwPDaj/ZH+tXLqgrQMa08nilj5M/qa5o8lwHFz30=; b=K7KvUbUJI+1RuSLHQmSg4tZXEvKXxkJSN+F+89qbcByRC8UxVm6Wf+cen3cpNShvFfzJW893bFzEZ+fZtO8B38Hgq/vYe+iuH9rIJoXDJD0QTI9CmN0r62FqMwwy3iGfgYU2DyzX0BFpBNc2NTzj5KPASfve5nxw/ImImuhuC57Xve557bGRckojGDVXomW0Mfe/kyOC0BfoyBKOBnPEVA5Wp6uvjGvuAfFoUbRHwfgpZdJgBvTBkcvaCnqnuoaQ6hI8cswrnRzIpbQLVdwL1Qi646PqHGFBEeLyUc2gV5qb2+C8faWa2AgQP4iJGwcdlRJDTJoybpRotzLxj0gN9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2124d508-78ef-7f57-5bfd-56575bd4e21d@suse.com> Date: Wed, 15 Feb 2023 16:17:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] xen: credit2: respect credit2_runqueue=all when arranging runqueues Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Juergen Gross , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Dario Faggioli , xen-devel@lists.xenproject.org References: <20221003162158.2042-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20221003162158.2042-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9711:EE_ X-MS-Office365-Filtering-Correlation-Id: a92ba3a2-f1c0-40d4-6adc-08db0f67bd0b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hq5nlf2cJKud5DYzOzkQuArigaD9n6AjjfYv+nMwA7w1HmZOfySOJaS6SpbCCpSW37aqCXbWBVGPqZfgkwhwyGNnpvHE4XUEpY/3d0hq03D5AjCuOpenGJ3dDSIndl5GEZhuCtK1BARR1oDP6r8M48R/K8LzTMDOa1Su3xOjYFj4naQsl0U68MWWs3zOWLuvQe9sZp3Sfiz1S3xbtxqSqeb5f3D0ysMref/TFouV2qRqKifAWegReKcvZaw1V0qsGM1plHesdEWHFhbx3qSZKdC0SJm9xmphBdRUZ0xQ4QLu0Akf0C/TyR3aUMEevaw38W9vgIyvWTFkf8v1Mp5LIc/RNiIa7rHky1SUr1KYIembc3z0vQj2G5mC3HmIdPaPbn/dofKijWGq9TV7jRwBvMeQd0jKJQgfLsAc/cLR7o0H4+K09FDsuoBvLTqfWdnOEkeXBsQ8M9R490EzeSjPONTIYIdcqyyiRczjwyLTaFJD2RG7vJie0jJk0bQEXam+QvIKXPzVPcggnI2hjLE2/BI2tqf9b+E8meTh+15ik5n44eEIheuVi+nNDICo+utTh3TP/7pU1RodotQeRZIKeYSX7l84ziOjep9c7LPieTrzT9aA1iyXmzUc3KUrH11bhxXEM0Zb9dc35/ZekioqoHTJCHEdJ2B1S4IldZoXHsSXZKWbwZCnKtBl8vrdpTE0ooyP9OtfMZAVpmMTC20L8Rs83ut4XlSxlKNCmSx4axE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199018)(2906002)(186003)(2616005)(26005)(6512007)(478600001)(6506007)(5660300002)(31686004)(38100700002)(8936002)(53546011)(31696002)(86362001)(316002)(41300700001)(4326008)(8676002)(6916009)(6486002)(66556008)(36756003)(83380400001)(54906003)(66476007)(66946007)(66574015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmpzZHROTlVpbk80WXU4VjBCdGVuejgxVElZL3NTVDdEaWIzYjYyb1hWM3Ft?= =?utf-8?B?amtTd2l3TGVMV1BzWU1iQkowdTRpL0NjZ2ZjODM0WGlkSnp3VHBRRXRIUkk5?= =?utf-8?B?dUhpSkNhQUJ3RjYwT3hHRFdxOEpYNjlMQTFxN2FlOWJkdUl0NEE3K3NhbWsx?= =?utf-8?B?MHdQUTcyMzlwVkhxQzhsdGVpVCtNTDJreEI2Skc2dVRiWlQ3Ny9KWUFPQlpZ?= =?utf-8?B?L2NhY25tcHpEamhWK3pCMGlJMTNWVEJKSEM5NnBLZlJyckNmTmNUeTVHeVRo?= =?utf-8?B?L3NNZjk0MXo1cFpjN1Y1enhjQXVXUkQ0RzUrTWgyZ093OUlkeXVsRTQ2WW1J?= =?utf-8?B?QmY5c0NJT0JIWkdqbjNhcDIzM3V3OVkxU3FGSjl5bTFJMkYxaTJJcWFEMEND?= =?utf-8?B?bU5VMDdCSkxBUEVDSTNLaGl3azZHMXk4cUJVRzBzV1lCTWRsanNtcU5ydExx?= =?utf-8?B?dHVtRUJPclRGWm05RE4xRzhjYUMzYythNW45Nkh1OXBkaU5rNW04cnZNc2s2?= =?utf-8?B?cFRncDZJOS9BUEZLbElRRDJRdmd2WUlIdlJlU3hwWjhUdDNvVVU1aEJSdmpK?= =?utf-8?B?NXBiT1B2eU5rcFIvNkMzeWJQL3JPSEZFVHZQSmw0V3htMDhIajFXdzJCZ3pK?= =?utf-8?B?VURNV3Zyb2h4SktCRDBQUzVSN0IxVGIvTWRBN3lTWDhRY1FlMmgwNkU0eHpm?= =?utf-8?B?NE8rRDhHa1ZMWDJ4SXFKalZ3UnBnOEpnUnd5bVZtdjJrdDBpbzJTYTFGeFlw?= =?utf-8?B?OUxHcnBnekVCOXNCS1J0WUcvMm5KSERVMTFBSUhhUGkrU09UOTZjK0hwK1Jv?= =?utf-8?B?QVF5Y0VnendldFQwcUFaTmNiYUNDYUJ1MHhJODJQUXZWQjUxRlZZa2hkZUJq?= =?utf-8?B?QVdRR1Q2Q0pmMHZCb0xmVmtFaGgyd1o4NEdvK1EycExjQVRiaFIzZjA5MWRH?= =?utf-8?B?QUhackhzUjg3V0o5Z0dFWm40eVgxVzJIcmh2ZHRVOFdTS0t2SGxnMytvaDVZ?= =?utf-8?B?T1pnZ0lOYkRnSExwMG1yUHR1ZXB2RUZUQWlrdmpqQVVQb0psakRJUzFSY2N2?= =?utf-8?B?MDJzSTFoaU1FeEU4UDRzRFhnRGU3c2E1d1VHNkZaaDY3QVdESjh6WlBJcVNT?= =?utf-8?B?emVYLzBKSzVJRVlZaThjM0F1MjNCOEI0a1A3OXRPay80Yi9WTGt3aEJ6NkpN?= =?utf-8?B?ekd0VEdnM3I0MHRqWjNzNlBkYlQyay9YdmhpRU1kNndTRXdjMDYxMjh4MVJF?= =?utf-8?B?STVxNDRFb1IzR0NTQkUyUS85WU1hL2tpYlRTblNUeEZmbDBkTFlaeE1QNWhN?= =?utf-8?B?YVFlbGNjNStHNU5kazc2Rkh0ME5EUDZkZlhDVG80Nkwrc2tFQU9VN3NyVy9F?= =?utf-8?B?a252NEZzc21IZ2EvMUZITWZNZndsdHJkV3M2SXhKREd5S2NzYVc5WTgrajQx?= =?utf-8?B?azQ2ejV4ZEZRbkZSWmZMMzRnWmU2MW1JdkdJUG1wc1IvTjBsZ3VJYlFXSDV1?= =?utf-8?B?L0NtNEF6YkhhR2drVldiaER6eE40RWFBV2svQkhncHFycG5YbTlaVlM1RjZN?= =?utf-8?B?UWdnaVBZdng5VSs5RDRzYnJZMVpYRHJkaDFjNmFWcm9BSmY2cXEvZEQxcW9U?= =?utf-8?B?bHNHYnhxYklUWEFKTTVrTnpkL0g0azdMQURqTndLTzBLdnBPTVJ4MjNGeFhz?= =?utf-8?B?NGRmVk1qZVlRTTNvc3cwQkNXaVMxK3RMT3F2dDQ5aE9rbTlqM1RJM25xN3dE?= =?utf-8?B?SVByNC83SVJCZkJvTWFQWjBvMzRNUVViVTJsLzMvWDlxeElySk9BYndVMCtv?= =?utf-8?B?QjFYUTdGc3JTMUVSemphYUNJSU4vMVpjb2ZsK0d2QytYNTNRcnZrZVp1U1pw?= =?utf-8?B?SGdpNW9VM2tocldFSEFMdnMrcHlwWlZjQTZ3V0ordnpXbVNHVmtkd1BTZWpz?= =?utf-8?B?QXdjWnNCRjcvNW8vM28rWlVjNENzMW9qSmZSUkY3UzN6SjBocXNiYVJqQUhs?= =?utf-8?B?ZUNYdnVudDBPWVRsUG5pd2h6MWg0czk1ZDRXQmt4Mm5CYkV2NEJ1RGhQcjM5?= =?utf-8?B?UEdrVnJpWHFESkNBOE9IY3RPL3Y3NGxFZE9nS2VQemRNTDlSbzZPdkM4V09m?= =?utf-8?Q?1mv2mtUrColI9XFUVgNEZmMRy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a92ba3a2-f1c0-40d4-6adc-08db0f67bd0b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:17:23.2622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bo84/VyPijs5OezSh2OTY7Pe0DKKtWs9lcKRp8csfywmxs1OHmx4lNyAWWIdIcX5Gy0WIBvR3LOcyxK9wVzJCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9711 On 03.10.2022 18:21, Marek Marczykowski-Górecki wrote: > Documentation for credit2_runqueue=all says it should create one queue > for all pCPUs on the host. But since introduction > sched_credit2_max_cpus_runqueue, it actually created separate runqueue > per socket, even if the CPUs count is below > sched_credit2_max_cpus_runqueue. > > Adjust the condition to skip syblink check in case of > credit2_runqueue=all. > > Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a runqueue") > Signed-off-by: Marek Marczykowski-Górecki > Reviewed-by: Juergen Gross I've now committed this without maintainer ack. > Changes in v2: > - fix indentation I didn't go check v1, but ... > --- a/xen/common/sched/credit2.c > +++ b/xen/common/sched/credit2.c > @@ -996,9 +996,14 @@ cpu_add_to_runqueue(const struct scheduler *ops, unsigned int cpu) > * > * Otherwise, let's try to make sure that siblings stay in the > * same runqueue, pretty much under any cinrcumnstances. > + * > + * Furthermore, try to respect credit2_runqueue=all, as long as > + * max_cpus_runq isn't violated. > */ > - if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != SCHED_GRAN_cpu || > - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) ) > + if ( rqd->refcnt < max_cpus_runq && > + (ops->cpupool->gran != SCHED_GRAN_cpu || > + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) || > + opt_runqueue == OPT_RUNQUEUE_ALL) ) ... this still looked like too deep indentation to me. I've taken the liberty to adjust this while committing. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:21:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:21:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496060.766588 (Exim 4.92) (envelope-from ) id 1pSJb9-0007Ds-08; Wed, 15 Feb 2023 15:21:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496060.766588; Wed, 15 Feb 2023 15:21:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJb8-0007Dl-Sr; Wed, 15 Feb 2023 15:21:30 +0000 Received: by outflank-mailman (input) for mailman id 496060; Wed, 15 Feb 2023 15:21:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJb7-0007De-Ef for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:21:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68a458c3-ad44-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:21:26 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68a458c3-ad44-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676474486; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TB/1Xo9lBeklxsQghDUEHcgIbWPy9MCj1tt4y4S5kBE=; b=ca1Cf6KlM4JNDBToXHuEbPrazAzfcfC7Vmq++AwsLqE8skUJNLLcz5xP XzykMXeRl0CKOegqN3x08CROFSqRMKTbI40gLwXkPrcE4iREM/nzXYK6+ qgpdsUvDb1vbxn6e06K6VMD1Rqk/ZJbYW36MqxzCHdlEDW6uxHDs8081X g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 95997362 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:PEY9DK/Xsfc9u5DqNjQyDrUDnn6TJUtcMsCJ2f8bNWPcYEJGY0x3n 2cZWzuCaf6IZmehctAnYIW39hgP6JHRztNgSwNt/Cw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6kW5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklVq MQqEx4ibiqOmr242JPqRMpxtM8seZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0EwxfJ+ TmYpQwVBDkTM/jczwGXyUuLj+LKwCLHaokYKOCBo6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0RN54A+A8rgaXxcL84QmDAXMfZiVcc9Fgv8gzLQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9NjI6VxQqYgs/7sS8rpkS3xzsU+RoH/vg5jHqIg3Yz zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yT4FWyzyGskTKuMDiriUWWxC KM0kV052XOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8xOxXBjj63wRJ8y8nT3 Kt3l+72VR727ow9kVKLqxo1i+d3lkjSO0uNLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5TPb9q r5i2z+x40wHCoXWO3CHmbP/2HhWdRDX87iq8Z0IHgNCSyI6cFwc5wj5kON9Kt05xvQN/goKl 1nkMnJlJJPErSWvAW23hrpLMdsDgb4XQaoHABER IronPort-HdrOrdr: A9a23:uSIt76MoJHqOnsBcTgajsMiBIKoaSvp037BL7TEVdfUxSKfzqy nAppgmPGDP+UossR0b9uxoQZPwJk80lqQFg7X5X43DYOCOggLBEGgF1+XfKlbbak7DH4BmtJ tIQuxXLPXCK38/qe7bxU2CP/MJ8J293I2Jvo7lvgpQpDZRGsVdBldCZzpzyncGPjWu36BJbK Z0O/A3wQZIpU5nFfhSaRE+LpH+TtTw5e3bXSI= X-IronPort-AV: E=Sophos;i="5.97,299,1669093200"; d="scan'208";a="95997362" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Date: Wed, 15 Feb 2023 15:21:11 +0000 Message-ID: <20230215152111.51218-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Unfortunatly, --default-symver doesn't work on FreeBSD 12, with LLVM's LD. Instead, we will generate a temporary version-script. In order to allow regenerating the script, we'll have a different filename. In order to check if the content is up-to-date, we'll always generated it and compare. Reported-by: Andrew Cooper Fixes: 98d95437edb6 ("libs: Fix auto-generation of version-script for unstable libs") Signed-off-by: Anthony PERARD --- tools/libs/libs.mk | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index 0e4b5e0bd0..cab8e9704a 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -5,6 +5,7 @@ # MAJOR: major version of lib (Xen version if empty) # MINOR: minor version of lib (0 if empty) # version-script: Specify the name of a version script to the linker. +# (If empty, a temporary one for unstable library is created) LIBNAME := $(notdir $(CURDIR)) @@ -13,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile) endif MINOR ?= 0 +ifeq ($(origin version-script), undefined) +version-script := libxen$(LIBNAME).map.tmp +endif + CFLAGS += -Wmissing-prototypes CFLAGS += $(CFLAGS_xeninclude) CFLAGS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib))) @@ -72,6 +77,10 @@ headers.lst: FORCE @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp @$(call move-if-changed,$@.tmp,$@) +libxen$(LIBNAME).map.tmp: FORCE + echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp + $(call move-if-changed,.$@.tmp,$@) + lib$(LIB_FILE_NAME).a: $(OBJS-y) $(AR) rc $@ $^ @@ -81,7 +90,7 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) $(SYMLINK_SHLIB) $< $@ lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) $(version-script) - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,$(if $(version-script),--version-script=$(version-script),--default-symver) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,--version-script=$(version-script) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS) # If abi-dumper is available, write out the ABI analysis ifneq ($(ABI_DUMPER),) @@ -120,7 +129,7 @@ TAGS: clean:: rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) - rm -f headers.chk headers.lst + rm -f headers.chk headers.lst libxen*.map.tmp .PHONY: distclean distclean: clean -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:31:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496066.766600 (Exim 4.92) (envelope-from ) id 1pSJkG-0000NO-Sl; Wed, 15 Feb 2023 15:30:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496066.766600; Wed, 15 Feb 2023 15:30:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJkG-0000NH-OM; Wed, 15 Feb 2023 15:30:56 +0000 Received: by outflank-mailman (input) for mailman id 496066; Wed, 15 Feb 2023 15:30:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJkE-0000NB-ME for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:30:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7e1b::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b93d7709-ad45-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:30:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7584.eurprd04.prod.outlook.com (2603:10a6:102:ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 15:30:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 15:30:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b93d7709-ad45-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G+bJBoOae6PHeb/sivNiouEfZrXFht4cJLmigpHGIVtxM+4G/wE3oez9km/06DZA2pYGSk8stihVEx81xJwexHUt8BIEslW6ISReZBRBiblZIOApcSjOPQw2rSFOjD/ZnAQN1wNhSABLKp8i0DnEJUCMuok+I/YPwnWEr6Us6kS1la3A2FfJfG3Sc+e75ciIYl1RngLZmeJAJ4JLpuHLfFpbuy1MjOH3SmaXAR6DoO8BOXM2R6QR8bdvXMZgfLUaTw/rhlH4b6IUmnSAVfaijXHQ4E79sCBGVGcrSKahG5tNmFlXrI9gfGm3kVzfQverUe0T4NjtUjIcf9oetN9Gwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5E/eOlr4+msGuMlFNU60Z+RfH2+XGcrIuK0FW39cbHA=; b=PyVrIdhRiHfjf31JV6VtYPEPmFLnSWsB9bZGJLVae13w1eHm6/jvSsonLEw0ycvAUIP/8zyO6lV/rRa0MmhpsSf8Ur9I3S/q4FuvgROOVGX0YmR+WWk8ZPY432hZir7evzvAyEKAdvrldcHBqpF5pGy+ZW/rRrOTy2bfFBUkOQhqiciX3o8Z6zF6KwL+6LVSlF8uebr9sFwdDr1rMG9DlG2ARkUNIVcc8wtUcpvWphMSiJsqj/tsGX1jYLpBZE8HDUkCM3rJ0TPLivFJOa+BjmaEdTd7l1fyvhrtCXuF7pNw2dtGWcu5159uwcy+hQ5c1QQn4tHx1iCDru0MeqnsRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E/eOlr4+msGuMlFNU60Z+RfH2+XGcrIuK0FW39cbHA=; b=HpjseEOChpgqMn+zFbiPPyjd9JvQjqKSSnqBdGq/BvjQfOBAbb9UaQu+NwQeMhvgghLWxSt5Nrz58JkFpnmjjg27ApbFxR4fo7VJ5Md7R2K65tQrJAm4PVk2SsXKrgz/OAgIJSPE73BzbUGOc2vLRvBITj0adHS0zPW6cc0rxRe9PjI5kUeW422/2S3GcFqgFi12gP0kTMbvw2IDeTy93O4Na3H4KLibeDLUEiavEsm0xKXfSsurgb32zVWW0eVpim0DjH9qwI56gCNPRNkkeSNMU36BDrhzD0MvzPgUJoBgIOzlNAwbWlFyPzp13D4TwJn6xYPWn/eDSv58rus70w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 15 Feb 2023 16:30:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20230215152111.51218-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20230215152111.51218-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7584:EE_ X-MS-Office365-Filtering-Correlation-Id: e269693a-3d61-42b2-e6fe-08db0f699b46 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Avy44ceVgXZSTqW8AqE3mQQ2ObWqJvgwOcvrhqxxgyV7PJQsILXmyYlpovJKFFmVZTQrv0HPNtrP6MrfODzpTxfJAF1UULIxXzsXZY2gg114Kb3+9G5zQkL+ncvlWbRMB5KWx5NeUQHAmeghxbG3vh7k5lfz3syONidXJ+WTcQ0Y3py9nyPCdUIi52/6Ko8z3e492QqyoXe8DR1uknHVFW3ItlhRL8jWSlY7XzN787s7cWCumNiUemP4flyu47sCV/whlTU3MtEvNi8R9xTUjQAsbH6smN9hI+EWcthrPGrRovbjcpfrZc32EGACdwrd0Oz5BLClRgby64S9CdOhFg2JloYg0JzE+4wA4eAqqzg6SoNEnNW5RF7IZHyTOb3OMhHtvvir2p613aKAHGDXBPT0MjG4ImfIuPrU38kaHS7U+5cfVhsxQGu7YaznwikYHhEfivYL/7+0B2Rnb9B7jgILQj1i3knJimN7C8oEOTGMLyupQ4Z/V4Mx4Pg2Qi45EEGL3wTs0ckotilgOfM8MzgPDX2qRditlntb6AccDFh9bVbXm7RHwreN6XhXLEI8z+3Oz6rgNH5LtM8VEbyWCXTrvC3hnppSvoS3s1APOg00gyO80MAKHQAl87O10nG14qd25Owix2XMDRmEhp00Fw2zq+WRo0c5qX+vOlVEUVhfMgu0XvWA2Yq5PZjrvy7l7/nshrt4qP7oDqRgcMZAaHBev6YrUGTjF/q+z9AfC4o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199018)(53546011)(6506007)(54906003)(8676002)(86362001)(8936002)(41300700001)(478600001)(6486002)(38100700002)(66946007)(36756003)(2906002)(26005)(66476007)(66556008)(6916009)(186003)(6512007)(4326008)(31696002)(2616005)(31686004)(316002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0R0bmtKMmt4RHNEWEpYUnI4TkVMUWxkd3JnY2ZIQkVVTUdtU2o3QThPMkVB?= =?utf-8?B?V3p5M3VhZGpNZXpMMFMvcktZS0ZuYkU4bFh3d01Ka0xMNHA2Zm9DWCt6cTFx?= =?utf-8?B?RWNqWnAxeVllbDhMY3hiMDFwRXVvbGlhb25CbVl3TWg0ZEF0M1pMUTBXb3FF?= =?utf-8?B?Tkxjc29qT3BKUi91dWliRDN3cHNuZEgvZEs4ZTQ0UGZ0VjJzR0hTTFAyeGxP?= =?utf-8?B?R0lOT0NHYXMxOFZxaG0xUWtHZ2dWendDeVREM2J6MDQ5TlltMGl4TWtNSjNW?= =?utf-8?B?RGtmVlpWdmtxcGlodEtJeVJCNnFaVm1PUEoyUlFvRUYvTDYwR1Z4Qy9rVVY3?= =?utf-8?B?dnhtWW13VlByZkNjOE9TT1JuY21qeXI0NWtDOTFNS3kxejc0Z3JsYUNseWxv?= =?utf-8?B?dllDaU8zRVRIaTdmTTBNM0p4M04wMkV3Q3h2bWZiMVdPSDJMeW1tVk1vaDZQ?= =?utf-8?B?TFZkVWl3QkdvNzBwY2xMdXduelNIR0gwdWNueUpMcngvTEVZZUlmTm9TbEQ0?= =?utf-8?B?emRieFJVekgvSEhGem1IdTF2Zk9CTTJEWDF0QXRHejdVYkdFVS8za3NXR2ln?= =?utf-8?B?YW9jaklHSy9STHNRYXFiM1FJNzZ1bndWWG9STzlOSktwTlptRHNMcDNwOFhW?= =?utf-8?B?d21za2VEOUNpTzlmV1pOaHF1cGJmbTRRMFV6cHF3RzR4Y2lnL0FFWWR6ZmZm?= =?utf-8?B?dkpHd3Y0ZzVrYU8rTnRwOGlML2Q5dGQ4MlU2RWdTMDFxOUxlTzdhVW5iQTUv?= =?utf-8?B?Y3RZRXhmVHdCZEMzSEZSQldDMm9JaExCQllCQjRQSDBVKzVZV2drTVdpbmx0?= =?utf-8?B?TG4xTHVXbTdPYnoxdmRkRDJ2eUdmZEFYSWtvM3VHZTNVUEhHYjJZaDJiMW9h?= =?utf-8?B?VkNlS0hKeGR3TGtpVEtpbHFPN1FDZndYRmdzZU9LaWJ3a05WQjRqUGczL2dC?= =?utf-8?B?eE1WMFNLdkdmRlNiR1FtZWw1TG53SlAwUE1QTkxjT1l4S29NYjlkeVp6SElS?= =?utf-8?B?cG05UU9DQThqUFV2U1dSamVYa1Y0a2lPRkNVMXI1M095Tjk5L2RiN0hmbmU1?= =?utf-8?B?Mmk3ZUZad09icy9saTJsckxJMTN1SEIxVHNYSDhrWCsvSjl5RFpLL2dFdTlM?= =?utf-8?B?Rk1meGJWTHBqWVBrUjFJdGMrRm9ERkdxWlNjWi9XVjFTK3VKelN5akJ0cWJO?= =?utf-8?B?S0NZdFF4MHlJc05ob2JLMXNKSzFnbzJXbi9odGxOQ21NMjhtS0pTUmczd3o5?= =?utf-8?B?dFNhaU1vRFRrQWFRaEJwNHRTeDJJRTBwZjRUSGtUcG9PSlZLUWRHTldiV0Ry?= =?utf-8?B?RjdySThyNVpwMlVMTTJVR0hEK1VmS3crTFF2SWJwL293elFHdld2Uld4SVQ0?= =?utf-8?B?MDJHWWQ4OElFZlAwN2xxVm9kZVRnQzdGRlhoNXc3bDRTZDgvRmtWVlhGQmFD?= =?utf-8?B?S0JndkxIbGUyVHVQOHhaWk1nUlc2aFZ0QVpoSXR5RDB5ZkhOQk43c2ROTE4x?= =?utf-8?B?U2xwQTBTQnFBamRtT25lb1RESGxTelhFS2kzOW5xbGVTeGhudDgrNzRVVTlF?= =?utf-8?B?L0tuVkVzUU5jYXlIL3htRUFFNC9HVVo4S3cyTmdMcjdZMzdTejBvQWpheDJk?= =?utf-8?B?RVdqU0tPYkxTK1dpZ0JEU2RDaHVzU3hXR2Jod25xMEd2SFdVbnFTam5kWVJa?= =?utf-8?B?ZSthV01BdTcvd2RtVkkzQllSdUhGNFNXNWptRGFSSWorS3BVQ01RaVpTOWd1?= =?utf-8?B?L2tiYVZad3pRMXpDOHZNVm1sNW9SK3k3UktIU3BvcllYNVQ5YmtaYm1pUkFY?= =?utf-8?B?emtPaXFEdDFCQ0dXWUlwMEFVV1B6bUxSODRqRFQ1S1BCNGpQVncxNC9pQUdR?= =?utf-8?B?T0E4RGp0ek9tYW10QmhVeEVmbHZZK0hlS0pIaTNvTnBUeXJMUUhmcldSSlVt?= =?utf-8?B?Z3MxRHNGV1Q1OFZ6UmkxdmpSMlM5TDc2SW1xRjVmNUQ5S0JlajI3bnVBcTNM?= =?utf-8?B?cE1jcitaZW56a3l5VW5SMzlKSTl0NVNsL1ZqZy9uWjdZd0hSU05aS1ZPcHZ5?= =?utf-8?B?YzJoc1U3YWxncTJJb0xBQ0EzdldlbVBQM2NFM3ErZ2x2K3Q4Mm5TVm43M1da?= =?utf-8?Q?InAbv4pPiSqBi044nn8oyIQ7N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e269693a-3d61-42b2-e6fe-08db0f699b46 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:30:45.5873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f2U7K5yUUPrbLJr2nkUzNzmE8pT6Cg04Etgf/OcHFGHlKjesPvtDMxfRt362+Pzj51B2PfwFHbOOssf9IoiLCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7584 On 15.02.2023 16:21, Anthony PERARD wrote: > @@ -13,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile) > endif > MINOR ?= 0 > > +ifeq ($(origin version-script), undefined) > +version-script := libxen$(LIBNAME).map.tmp > +endif Such a use of $(origin ...) is pretty fragile. Maybe better use ?= ? > @@ -72,6 +77,10 @@ headers.lst: FORCE > @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp > @$(call move-if-changed,$@.tmp,$@) > > +libxen$(LIBNAME).map.tmp: FORCE > + echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp > + $(call move-if-changed,.$@.tmp,$@) Isn't this going to get in the way of your "build everything from root" effort, where $@ will include a path? Also do we really need .tmp.tmp files? > lib$(LIB_FILE_NAME).a: $(OBJS-y) Seeing this right adjacent in context - any reason you use libxen$(LIBNAME) and not the same lib$(LIB_FILE_NAME) for the base file name? > @@ -120,7 +129,7 @@ TAGS: > clean:: > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) > - rm -f headers.chk headers.lst > + rm -f headers.chk headers.lst libxen*.map.tmp If I hadn't checked, I'd have assumed that *.tmp are removed without being named explicitly. So yes, I see the need for the addition, but then I wonder why you don't also remove the .*.tmp.tmp file, which may be left around if the build is interrupted at exactly the "right" time. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:35:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:35:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496072.766611 (Exim 4.92) (envelope-from ) id 1pSJoA-00019D-BV; Wed, 15 Feb 2023 15:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496072.766611; Wed, 15 Feb 2023 15:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJoA-000196-8b; Wed, 15 Feb 2023 15:34:58 +0000 Received: by outflank-mailman (input) for mailman id 496072; Wed, 15 Feb 2023 15:34:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJo9-000190-7I for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:34:57 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bdc1b3d-ad46-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:34:55 +0100 (CET) Received: by mail-wm1-x332.google.com with SMTP id n33so7609893wms.0 for ; Wed, 15 Feb 2023 07:34:55 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id t14-20020a1c770e000000b003dfdeb57027sm2282207wmi.38.2023.02.15.07.34.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 15 Feb 2023 07:34:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bdc1b3d-ad46-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NKH73T8CoRDn773NUygCpVvIPtF8CVn6vI6nMM27j1I=; b=oWMZO8SDTBKsKLKV5arFKZkrAJOGtNpPBm7I7aWKb95hPiiIgSofZ2fkKU9tV1yKEk ezjXzyaIJvJZ7pt/cesNBdhWjhfCD6KYhuK3pUsvBFLzjuXN7TM3pj0Aj+NMo1rWX/D+ HjCANU6Wo6wCGW/Kv//t8t8RmH8XJ2EJBasw66r5j5wcdU9lsvUIE3mQU9Vp7JQA2sI5 +CUrsISj4deC6Zc/TrdvDLfz1UMTfaaVHV/WHx/zcqM5nvoBYV7XqNW0nYgniuMJfDdo OQ1fyZ5xzZ5uQqcPz6yGnEHfZanaWvSUEkKl05yMthFmyQCAbLDxwE1G6pJTej7KTPSv eo3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NKH73T8CoRDn773NUygCpVvIPtF8CVn6vI6nMM27j1I=; b=bDuFw9laJemdXTKvSpAWVmwE8FmFjJeHuY1+Ew2h2urz14ljGtGOos8cIL0uUyJXD1 F7oQhgihG+HfLzVO20ty6sdaYym5OttSNuZMAPODp2jPqyWCpB2f0yN+GEz0fXpUGonq ZbGML5IgqBOfBqSTFfjcPbhV6a6xG2bGgh/jHXAY10qJL+bjdQ++L3s+iN1MLAri+CI7 h1Ga4ZRw/yGtif5nk1QD8DQ2A5eys4lRF0j2uWMpQ7sBWlMedqhjbhdR/nm7hXstuLxP 59Rq0gu9gkXKe+Ly0lKvFx6IL2k+rVSiPdyjLVCJFWrRoXE3TEpAXkdB7k0VdKF75WCa d1cA== X-Gm-Message-State: AO0yUKXr8bZbrcNXGzRM1WI5h3XATVX2DfAW6+hgeyiFl3T6pjTKNE0D BRFaS34fY6XszKmscPQq/7J0Kg== X-Google-Smtp-Source: AK7set8VKr93YhBGymtNxoDV9uf+fr5u7KtD7OV4RU+JGE5FxHGGg56i8sDAFXLY5R0goR0ryEeC4g== X-Received: by 2002:a05:600c:5024:b0:3df:fcbd:3159 with SMTP id n36-20020a05600c502400b003dffcbd3159mr2107593wmr.3.1676475294684; Wed, 15 Feb 2023 07:34:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Anthony Perard , Paul Durrant , Stefano Stabellini , xen-devel@lists.xenproject.org, qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] accel/xen: Remove dead code Date: Wed, 15 Feb 2023 16:34:51 +0100 Message-Id: <20230215153451.30626-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unused since introduction in commit 04b0de0ee8 ("xen: factor out common functions"). Signed-off-by: Philippe Mathieu-Daudé --- accel/xen/xen-all.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 69aa7d018b..c1b697a8bd 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -23,16 +23,6 @@ #include "migration/global_state.h" #include "hw/boards.h" -//#define DEBUG_XEN - -#ifdef DEBUG_XEN -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, "xen: " fmt, ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) \ - do { } while (0) -#endif - bool xen_allowed; xc_interface *xen_xc; -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:39:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496082.766637 (Exim 4.92) (envelope-from ) id 1pSJsE-0002Oa-JG; Wed, 15 Feb 2023 15:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496082.766637; Wed, 15 Feb 2023 15:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsE-0002O8-DY; Wed, 15 Feb 2023 15:39:10 +0000 Received: by outflank-mailman (input) for mailman id 496082; Wed, 15 Feb 2023 15:39:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsC-00026q-Qx for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:39:08 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e24d7dbe-ad46-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 16:39:07 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso1843500wms.4 for ; Wed, 15 Feb 2023 07:39:07 -0800 (PST) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id t39-20020a05600c32a700b003e1e8d794e1sm2320560wmp.13.2023.02.15.07.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 07:39:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: e24d7dbe-ad46-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tibco.com; s=googleworkspace; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=M4M+2M3RbH+k66gVRO8WHDkieezAlEhOYoWMRNwzTYk=; b=TcgStnY4DauLjeByL1c2EvclpvdP7EOGcVtztARxrZ+6aNrQPFaggONLPhkrOJMd1s vBl9yrLI968WFwmTgd1NmiSQMpyVQeX95V8Qiccx5750b6b0WLae5DiPjmOS3zsnZ5qw e8qFXM0TDUUGqsnCthffMqic9RdHgRyLZLiFyz2RNPTyUXPKLJkU09f+YqGaAPuk0YlD a4JlIO0fFbZDCIbXWnFq3tHLPMd3PXgkmdSaDbcMgj964OuFGOIL0rap1yHNSAcReGFs rnoe4cl+WDFm5WZOGHKDu20lkSlYt3uK1TWx11BvAroMAmbG3K96+t7Gq0RMfWC8wNoX e6Jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=M4M+2M3RbH+k66gVRO8WHDkieezAlEhOYoWMRNwzTYk=; b=PobcozcfKWZ8dmqfTdzMZLr1zkaGkWFZrcTL0YJ9h1Y3WtK4UflWEU/Tv9l19OO9As jBH5xxj00N5lHOGdK2/H/GZ5lizGdm7cumpVQvLm8kEiGwpc7yCItfUMzWYuB+zsXspX 1QtOA481ZUw/bRTIv4A/2iJ0Z6K9H7ioL6Az8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M4M+2M3RbH+k66gVRO8WHDkieezAlEhOYoWMRNwzTYk=; b=aj4Mzl9OhV7My0rsoFdNd1ZwSrMRYPnITTFiPg3iQuMIRSEVgnTCaPnvRKK4bCrhlq q0nCDkKqguMGHQxPotUReFV3UpU6veMdOahvHIsapkYqUfDluVL93a0UbwpLSs5i4aOA 1Y9yXZXRm7iMk6LfjSCO0hymRNUy93EF5D5F+Tmz0ZGxIKxnxe9gBCRNxZObj9NLEy5s dlPwJHd/rP8S4RU4l49zZKkPXTu4JQaJ+NijsISkW+Nz0XGGlht3T9i+LUvUWJUXjJfy z1KTvIN8WLl4CEd923nv363ea65hAHoWSX/ghhkjikkiwhEP9/gh+ppbpAKa3czAd3nf 9aYg== X-Gm-Message-State: AO0yUKURVkr5PPG48aeUsIn+FyUduV1Nj95lzcdnGMAeG9Gfrk4MGoy5 9am/XqGKIY4riknFOSBVc4WFECATS2fqeK5rsRA= X-Google-Smtp-Source: AK7set8pz04VfBZp39oQ0Jaf/6oi3Iv2nVHpIOIlgz7EJad/TGWMiZwvW2Ob2lgMpGqLwr5SCTsTtA== X-Received: by 2002:a05:600c:1c2a:b0:3dc:5032:2895 with SMTP id j42-20020a05600c1c2a00b003dc50322895mr2851400wms.0.1676475547055; Wed, 15 Feb 2023 07:39:07 -0800 (PST) Sender: Sergey Dyasli From: Sergey Dyasli X-Google-Original-From: Sergey Dyasli To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Sergey Dyasli Subject: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread Date: Wed, 15 Feb 2023 15:38:46 +0000 Message-Id: <20230215153846.18582-3-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230215153846.18582-1-sergey.dyasli@citrix.com> References: <20230215153846.18582-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently late ucode loading is performed only on the first core of CPU siblings. But according to the latest recommendation from AMD, late ucode loading should happen on every logical thread/core. To achieve that, consider every logical cpu as "primary" when running on AMD cpus, i.e. skip cpu_sibling_mask checks. Signed-off-by: Sergey Dyasli --- v4: - new patch --- xen/arch/x86/cpu/microcode/core.c | 35 ++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index ba6e7b42c6..f720030761 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( (!ucode_in_nmi && cpu == primary) ) return 0; - if ( cpu == primary ) + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + /* load ucode on every logical thread/core */ ret = primary_thread_work(nmi_patch); else - ret = secondary_nmi_work(); + { + if ( cpu == primary ) + ret = primary_thread_work(nmi_patch); + else + ret = secondary_nmi_work(); + } this_cpu(loading_err) = ret; return 0; @@ -540,7 +546,6 @@ static int control_thread_fn(const struct microcode_patch *patch) static int cf_check do_microcode_update(void *patch) { unsigned int cpu = smp_processor_id(); - int ret; /* * The control thread set state to coordinate ucode loading. Primary @@ -548,13 +553,18 @@ static int cf_check do_microcode_update(void *patch) * the completion of the ucode loading process. */ if ( cpu == cpumask_first(&cpu_online_map) ) - ret = control_thread_fn(patch); - else if ( cpu == cpumask_first(this_cpu(cpu_sibling_mask)) ) - ret = primary_thread_fn(patch); - else - ret = secondary_thread_fn(); + return control_thread_fn(patch); - return ret; + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + /* load ucode on every logical thread/core */ + return primary_thread_fn(patch); + else + { + if ( cpu == cpumask_first(this_cpu(cpu_sibling_mask)) ) + return primary_thread_fn(patch); + else + return secondary_thread_fn(); + } } struct ucode_buf { @@ -642,8 +652,13 @@ static long cf_check microcode_update_helper(void *data) /* Calculate the number of online CPU core */ nr_cores = 0; for_each_online_cpu(cpu) - if ( cpu == cpumask_first(per_cpu(cpu_sibling_mask, cpu)) ) + { + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) + /* load ucode on every logical thread/core */ + nr_cores++; + else if ( cpu == cpumask_first(per_cpu(cpu_sibling_mask, cpu)) ) nr_cores++; + } printk(XENLOG_INFO "%u cores are to update their microcode\n", nr_cores); -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:39:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496081.766633 (Exim 4.92) (envelope-from ) id 1pSJsE-0002ME-7q; Wed, 15 Feb 2023 15:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496081.766633; Wed, 15 Feb 2023 15:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsE-0002M7-4y; Wed, 15 Feb 2023 15:39:10 +0000 Received: by outflank-mailman (input) for mailman id 496081; Wed, 15 Feb 2023 15:39:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsC-00026r-9u for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:39:08 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e17a86fe-ad46-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 16:39:06 +0100 (CET) Received: by mail-wm1-x331.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso1930653wms.0 for ; Wed, 15 Feb 2023 07:39:06 -0800 (PST) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id t39-20020a05600c32a700b003e1e8d794e1sm2320560wmp.13.2023.02.15.07.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 07:39:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: e17a86fe-ad46-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tibco.com; s=googleworkspace; t=1676475545; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=UbkQ0Tsofds3NIZpEYPN9Zfob+Z/kFBDvI+50cJgOTM=; b=cK7G53pbRRvYWG0NrH6g46H5ccChizmhf+OMIn3sDSOyZCdfYJN8UCPJ13I0/lXBje AiQL5SSJF6arfota0cupDCiFPtapupyZ8fDF6/ggY9oDZ5ObcEEC/AqmuGcv94zdYGpb JjrKTQz4XP1KDkCk0WVJWKH8kkoqkw8mtSJw9IpGTMqsdsUoNjrS8sVdSUZFDGV2zi/o HCS9SOw5Qk/KguErYSALh3J1tVi3FCdCD+Ca86P+fLR38NcboymTHnuzRSwg+ZA56TFn Qngu9KMqehCtaV9PHr/R2IScGLO1pdFNzjh/h8EB3I7Sp6IR5ySrR8hEeg4LwsxUqlN/ quiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1676475545; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=UbkQ0Tsofds3NIZpEYPN9Zfob+Z/kFBDvI+50cJgOTM=; b=LX9X0vR0PmfM/bT1+in8SkC60wnaEG2Y7WgXGD7J1E2oXB6A5GVIEYsUoAcX5KTGDZ nKZpyxF7hHX4hjhWZUOCUHLnTHaKySKEqdDRHWfHvGaG7CHoiV/eqwc0q3q6oPzBLuNw H9YwqrFbcfAGBxzwEEDslmLIQU9WVUbfCAnLs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676475545; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UbkQ0Tsofds3NIZpEYPN9Zfob+Z/kFBDvI+50cJgOTM=; b=a5PHaiPT1h6iahv75oTj7w3I5JnU7W/8qz+O4uBkWfELlpbNucvd3cRM78uWwyaE53 ySA9TpVVnf2jDKa/XFi917wi7OsdkOsD1jIy/f/7hzh2sQShx3qAsc/sE8dZEKC7ehhp aMS8/Gj+vtrFeBgafiHLJhhi97QY8lt/YAQkQRpGc1NdIJMFPyeGXiddtepQ5sSTV6Sl f73t5IWDMygRg9SoseMeurO37NZ14TgCmy27jzcB0U0yi9uTXTzwFsuusEhrP0+ub8Dq TJIsYaPytZV7oh3Mj/HePfpbAo9P2PXlQV+NcCxYidvfOfPGRhVL8SU9MTfCJC2/51aj GugQ== X-Gm-Message-State: AO0yUKXP80yMiKQphUdxiUv+HZ3GFJPy/xm11nSgqotZB7mrmPWRgXuy gc030PSNnQ9g2x11hOCGcu1O/Oxc4DHJdnaqk/g= X-Google-Smtp-Source: AK7set9n63sxpMrWJk0NbgvChXfNCvF8njnRiXbW8unE/b+ryxNYGg2yDTNOIdijgUByiHCz3WGybg== X-Received: by 2002:a05:600c:3c9e:b0:3dc:3b1a:5d2d with SMTP id bg30-20020a05600c3c9e00b003dc3b1a5d2dmr2671723wmb.0.1676475545615; Wed, 15 Feb 2023 07:39:05 -0800 (PST) Sender: Sergey Dyasli From: Sergey Dyasli X-Google-Original-From: Sergey Dyasli To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Sergey Dyasli Subject: [PATCH v4 0/2] x86/ucode/AMD: load ucode on every logical thread Date: Wed, 15 Feb 2023 15:38:44 +0000 Message-Id: <20230215153846.18582-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I've added a second patch to cover late loading as that should also happen on every cpu, according to AMD. Sergey Dyasli (2): x86/ucode/AMD: apply the patch early on every logical thread x86/ucode/AMD: late load the patch on every logical thread xen/arch/x86/cpu/microcode/amd.c | 11 +++-- xen/arch/x86/cpu/microcode/core.c | 61 +++++++++++++++++++--------- xen/arch/x86/cpu/microcode/intel.c | 10 +++-- xen/arch/x86/cpu/microcode/private.h | 3 +- 4 files changed, 59 insertions(+), 26 deletions(-) -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:39:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496080.766622 (Exim 4.92) (envelope-from ) id 1pSJsD-00027A-0m; Wed, 15 Feb 2023 15:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496080.766622; Wed, 15 Feb 2023 15:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsC-000272-UD; Wed, 15 Feb 2023 15:39:08 +0000 Received: by outflank-mailman (input) for mailman id 496080; Wed, 15 Feb 2023 15:39:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJsC-00026q-5q for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:39:08 +0000 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [2a00:1450:4864:20::342]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1ee0303-ad46-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 16:39:06 +0100 (CET) Received: by mail-wm1-x342.google.com with SMTP id f23-20020a05600c491700b003dff4480a17so2590207wmp.1 for ; Wed, 15 Feb 2023 07:39:06 -0800 (PST) Received: from localhost.localdomain ([185.25.65.68]) by smtp.gmail.com with ESMTPSA id t39-20020a05600c32a700b003e1e8d794e1sm2320560wmp.13.2023.02.15.07.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 07:39:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: e1ee0303-ad46-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tibco.com; s=googleworkspace; t=1676475546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=cCF7YQ2rzFnOkJ+6hEIhSfR1jz8bWsd0xTeyV2qti9Q=; b=Jitw+ycIKvBXCxMs+qV8TmQ5/Wol7x/hUUTq/vBnXDqPiGWJHKGxH+c+6aE2mMFggj z75Yl6BOv9whIx1KHTcLO6dEIset4Tnh+hGISvZ+bs+ONzahd1EenTzH6WEuxyBx5vC+ 9Pohk3etwZXeU1gQgSOoJ5jBK+Jd3/GiW5XFM2q9/UVps9zXOFFsO/hq4iTggARw/Nuz 8olLTwx69la7UKXjuVj9QvzNvQrJyiti8843rAgAVn5Dl6pPT/xSZHmjt0BI3AAPj/CG TQ66RKc2NXgZ/tsyZqm9E8KyUWiLkPyVwxOZ3JDb1C5tNEPe201pYG+KqK3PsuC6dwhm ERPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1676475546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=cCF7YQ2rzFnOkJ+6hEIhSfR1jz8bWsd0xTeyV2qti9Q=; b=ZK9BikwKL063GguHEASmfg6eioANLQqlmhVUpKCr12uwVFWLONfeDU6yIuNUXJXaZY viyiqZMePyQfp32ALHB5CTkuAIuZst4QcTPQAuh15lNe6gcJbM8bDILIkDYAX1Ibj4Td 1XyQmFcrdJaQV3PlFKDf2Tckhg1YGghR5Dl+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676475546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cCF7YQ2rzFnOkJ+6hEIhSfR1jz8bWsd0xTeyV2qti9Q=; b=2mdF/aFyeHLTaUZeEF7HIdO4Ee3+ELqA4peC4wAuzeJ2hP0QdhcFtllcqau+P7YuNF PLUOxyQhkczyQSITo/IbSN6Ruu3f8d5HQH53T4age9Ab25sf4YxfCLbLN/U4vlKkUCXV 3K0gDhpoaJ5E5G2Md+SGF/9lmFA3HD9kKNRrjoJILxFQwb2JiOgFI18fFKmb5FD+SYuD JFbZxRZGiHFw0nFCY9Lxi9iiwlJ9WfkUS0ByYWdIRDuIOBpiIdw/Wa47WsviQmiu2UcZ +ZtIDKdMYfvWORCptPiXvaolOKElRceV5dnMseKuA4azXTIagRwuDzIvIM2NzjMOC2Rz QVTQ== X-Gm-Message-State: AO0yUKWtvORiGnt2IfKBSIqo+Df1miFuq6VI2WHOJDJKLZdLukRoRhUD KDekpKpQxuTl8X3SDhNb9Y1fzDBEONddkYJIgjcvbw== X-Google-Smtp-Source: AK7set+QEJMz0NEDyJKcQbkfALFzaG6uV458vt43uQDK6dHRwepimf14GLSbXxyOBTYNJdXtRu5YtQ== X-Received: by 2002:a05:600c:3c96:b0:3df:f7ba:14f8 with SMTP id bg22-20020a05600c3c9600b003dff7ba14f8mr2576500wmb.1.1676475546287; Wed, 15 Feb 2023 07:39:06 -0800 (PST) Sender: Sergey Dyasli From: Sergey Dyasli X-Google-Original-From: Sergey Dyasli To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Sergey Dyasli Subject: [PATCH v4 1/2] x86/ucode/AMD: apply the patch early on every logical thread Date: Wed, 15 Feb 2023 15:38:45 +0000 Message-Id: <20230215153846.18582-2-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230215153846.18582-1-sergey.dyasli@citrix.com> References: <20230215153846.18582-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original issue has been reported on AMD Bulldozer-based CPUs where ucode loading loses the LWP feature bit in order to gain the IBPB bit. LWP disabling is per-SMT/CMT core modification and needs to happen on each sibling thread despite the shared microcode engine. Otherwise, logical CPUs will end up with different cpuid capabilities. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216211 Guests running under Xen happen to be not affected because of levelling logic for the feature masking/override MSRs which causes the LWP bit to fall out and hides the issue. The latest recommendation from AMD, after discussing this bug, is to load ucode on every logical CPU. In Linux kernel this issue has been addressed by e7ad18d1169c ("x86/microcode/AMD: Apply the patch early on every logical thread"). Follow the same approach in Xen. Introduce SAME_UCODE match result and use it for early AMD ucode loading. Take this opportunity and move opt_ucode_allow_same out of compare_revisions() to the relevant callers and also modify the warning message based on it. Intel's side of things is modified for consistency but provides no functional change. Signed-off-by: Sergey Dyasli --- v3 --> v4: - Coding style fixes - Removed goto - Removed the paragraph about late loading in the commit message v2 --> v3: - Moved opt_ucode_allow_same out of compare_revisions() and updated the commit message - Adjusted the warning message v1 --> v2: - Expanded the commit message with the levelling section - Adjusted comment for OLD_UCODE --- xen/arch/x86/cpu/microcode/amd.c | 11 ++++++++--- xen/arch/x86/cpu/microcode/core.c | 26 +++++++++++++++++--------- xen/arch/x86/cpu/microcode/intel.c | 10 +++++++--- xen/arch/x86/cpu/microcode/private.h | 3 ++- 4 files changed, 34 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c index 4b097187a0..a9a5557835 100644 --- a/xen/arch/x86/cpu/microcode/amd.c +++ b/xen/arch/x86/cpu/microcode/amd.c @@ -176,8 +176,8 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + return SAME_UCODE; return OLD_UCODE; } @@ -220,8 +220,13 @@ static int cf_check apply_microcode(const struct microcode_patch *patch) unsigned int cpu = smp_processor_id(); struct cpu_signature *sig = &per_cpu(cpu_sig, cpu); uint32_t rev, old_rev = sig->rev; + enum microcode_match_result result = microcode_fits(patch); - if ( microcode_fits(patch) != NEW_UCODE ) + /* + * Allow application of the same revision to pick up SMT-specific changes + * even if the revision of the other SMT thread is already up-to-date. + */ + if ( result != NEW_UCODE && result != SAME_UCODE ) return -EINVAL; if ( check_final_patch_levels(sig) ) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index d14754e222..ba6e7b42c6 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -612,17 +612,25 @@ static long cf_check microcode_update_helper(void *data) * that ucode revision. */ spin_lock(µcode_mutex); - if ( microcode_cache && - alternative_call(ucode_ops.compare_patch, - patch, microcode_cache) != NEW_UCODE ) + if ( microcode_cache ) { - spin_unlock(µcode_mutex); - printk(XENLOG_WARNING "microcode: couldn't find any newer revision " - "in the provided blob!\n"); - microcode_free_patch(patch); - ret = -ENOENT; + enum microcode_match_result result; - goto put; + result = alternative_call(ucode_ops.compare_patch, patch, + microcode_cache); + + if ( result != NEW_UCODE && + !(opt_ucode_allow_same && result == SAME_UCODE) ) + { + spin_unlock(µcode_mutex); + printk(XENLOG_WARNING + "microcode: couldn't find any newer%s revision in the provided blob!\n", + opt_ucode_allow_same ? " (or the same)" : ""); + microcode_free_patch(patch); + ret = -ENOENT; + + goto put; + } } spin_unlock(µcode_mutex); diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index f7fec4b4ed..8d4d6574aa 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -232,8 +232,8 @@ static enum microcode_match_result compare_revisions( if ( new_rev > old_rev ) return NEW_UCODE; - if ( opt_ucode_allow_same && new_rev == old_rev ) - return NEW_UCODE; + if ( new_rev == old_rev ) + return SAME_UCODE; /* * Treat pre-production as always applicable - anyone using pre-production @@ -290,8 +290,12 @@ static int cf_check apply_microcode(const struct microcode_patch *patch) unsigned int cpu = smp_processor_id(); struct cpu_signature *sig = &this_cpu(cpu_sig); uint32_t rev, old_rev = sig->rev; + enum microcode_match_result result; + + result = microcode_update_match(patch); - if ( microcode_update_match(patch) != NEW_UCODE ) + if ( result != NEW_UCODE && + !(opt_ucode_allow_same && result == SAME_UCODE) ) return -EINVAL; wbinvd(); diff --git a/xen/arch/x86/cpu/microcode/private.h b/xen/arch/x86/cpu/microcode/private.h index 73b095d5bf..626aeb4d08 100644 --- a/xen/arch/x86/cpu/microcode/private.h +++ b/xen/arch/x86/cpu/microcode/private.h @@ -6,7 +6,8 @@ extern bool opt_ucode_allow_same; enum microcode_match_result { - OLD_UCODE, /* signature matched, but revision id is older or equal */ + OLD_UCODE, /* signature matched, but revision id is older */ + SAME_UCODE, /* signature matched, but revision id is the same */ NEW_UCODE, /* signature matched, but revision id is newer */ MIS_UCODE, /* signature mismatched */ }; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:42:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:42:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496098.766654 (Exim 4.92) (envelope-from ) id 1pSJve-0004dc-3c; Wed, 15 Feb 2023 15:42:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496098.766654; Wed, 15 Feb 2023 15:42:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJve-0004dV-0p; Wed, 15 Feb 2023 15:42:42 +0000 Received: by outflank-mailman (input) for mailman id 496098; Wed, 15 Feb 2023 15:42:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJvd-0004dP-29 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 15:42:41 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e9d832e-ad47-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 16:42:37 +0100 (CET) Received: from mail-dm6nam10lp2105.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 10:42:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6485.namprd03.prod.outlook.com (2603:10b6:a03:398::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 15:42:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 15:42:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e9d832e-ad47-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676475757; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=tS7fSBCHK+Iq98OAd95KnNGRYrB9Css0C8bcJfQ9f3c=; b=OImJlacJ/jf3ntlsnAxyMndf4Zvt1VG9HFwFK+0K20/ZiLu72C9/9jYN 9day6xxsz9I3119HHN4jHe60IOLZxf8YeIcpAraNS2oA2qjDHrbqDTleL ZQofBYw4/3/HSREAdZd+kpVddytTqc86ZotokYvOXCxv4UcY8Cp7aNpl1 M=; X-IronPort-RemoteIP: 104.47.58.105 X-IronPort-MID: 97079184 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XeDjMqp4BtaR6cNedN3ICOSXXqxeBmI4ZBIvgKrLsJaIsI4StFCzt garIBmHOfyCYWSmfdlyb96z8k4AupKBm94wTQM+rC1kHy4bpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG4IdhnSisaW+bGcEtZUn+cELtDMPrpK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqaY10QTDmgT/DjUGaXSQ/ci123X5AeAHc m5I6jgerZALoRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9W9S32H8ayPhSivIiVTJmgHDRLoViMA6tjn5Y020BTGS487FLbv14WoXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:yKDIJKnl2l2o5HDoLr9lwcvnHH3pDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="97079184" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EEyjnmRWFsLjZiBZFcI1zKSBz18Y744JZWjsuTJvSH2zuT4r9jOmOccd4KXolVbuVi1HukS8vEXe/EzSsDlTF6PayUrc7DE0X2+qTyZE+qZUjNZ5QJKx+3zhOBoDpLpZQzNxDFndDbDShrbuPH5+eqfBF69GIUS4fQqxrzg1zw6ObCef1JN54ApHz0T4jZ9lUp7bGQ7fM1gloyJATetcEmIMm7+U1UHzRCp07E+UlYa4/E3lWp1xsK3sGrTA5T/dKjw3FjT4/OdZ3U5M6cQKasyQMy+Lsk0ZGjHerP816bnXckoy8tHLl049mLzpHZQmJScyQyCG76L7I5Prz73KBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mAVq2WUkPBmRVptWqO60GQ/LiRitT+Evk1FCbEYaE8Y=; b=eygpn8t8CYTi/V1GtkQ2XNTn3qZnm6uExI4AaHmGfZuvkVwo5OO3A6XabbJCwA2y54cBfZQZLlidBpUvJPHzMr6VRO6scbsKbjb1GBhROPzo8r1aPyh3L54/Vf6eXDMXi/7JbH92blS8PjLdKsRdtVzaHTcTNtlXqBIotKtC4tH5CffvZUf6Zie+Rxf5HLjreRfc3sF97iAAcRv2kAQr+L/Qx18A5VvPZhdqlaHq2LN+jinHmHVngTs/qeNcV0nZXxfc4AU16Q7NKu/BV/R8BV0oZ1b4G8OfotjZGhYetd61irWijDpNWxpT1W3IpjNzICtdq4LRhkLu/PrTethXFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mAVq2WUkPBmRVptWqO60GQ/LiRitT+Evk1FCbEYaE8Y=; b=DOv90YH0W5thFAuI/faFkWon9y91cCG9lq1dfkaFuxkLf82DRHpYId6mw2CBTjqPOnS2rSfrplUUoLQuOtqq1swXxFqXvEsyXTwrFaXoGw87MB9SI0dIC3OmaRYkmBYDo1wLBtgYCGRMRyWdyOvfs+LYQ6TCHNR3x/DzY8U5xDo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 15 Feb 2023 15:42:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Wei Liu , Juergen Gross References: <20230215152111.51218-1-anthony.perard@citrix.com> In-Reply-To: <20230215152111.51218-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6485:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cc8c0c4-3d99-4703-4b08-08db0f6b4078 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lIp3g9UWUlvJb0qFdMhn46eAQft4cSAnVjT5aKP8lrkFikX6oC/8nPq9gp4fiztmhz/Xj7ehhMn2xD7np5g2Ga+FAcyqFweVcLwBe4/vEW0uYMWpMIMnuGGyjXu57tIyTwMURkEIUWM8hIp+4KCkEZOHPjopoNtiJDFK+oZ9p5sUO1bhrBXgEl7/lMpJIwspCt0BuA7IjSpYE5ldhQv88m5teZkljOV3Oul3rsfHn8X9Zz/Y9zEty1KRsqipUQA5BdpKqNzZbnf8hqqQf8zQPyq1M8afNwS7v0LxYeClOrkSzxusqhoGfm1bCxLKHkHn5WJMpdTfp5GTTtxU9Qqe34M4CNmj6roXNlsNWGpS5fr9/lb7U5VOMilJB4lySOl2cMoFAT6fjWdhTBpKIaQHigxPDL0vF+tkoBGRK7SA/EpuIqS+DNR93asgmOBQHEhGVHFqkxSFJBEe3H3HOKMgN3E0vgTJwd4ZkZugxgzDEtaVCKrXHz/mpLHH0ip9afKymZ0sgG1hg8OtEE2g/PZ88yTLPEzHtsvpkRYJf6MK9NsmB/v13tAnBLFdse/SwPtV6+VtscgauKaq7SVvTBTnl6PyVNc8TJ7B/8KBJc0j3BJPrcgW6DwHe7AdY0Fhly1g1Vj+Q2SqS8f6pD1ySbUTBcgtVy7AmT2sdI+e26xzFkPMgYVfUFD+wrWlMqaGHrapirkQlhWRxDSTXPjASlnZK5JDeNcHDUFVcIgFYxKNoH0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199018)(36756003)(41300700001)(66946007)(31686004)(54906003)(38100700002)(5660300002)(8936002)(316002)(4326008)(8676002)(66556008)(66476007)(86362001)(478600001)(6486002)(6506007)(6666004)(2616005)(31696002)(82960400001)(26005)(186003)(2906002)(53546011)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzVVNlFQZGsyWVFMZUxsdEtwbGNOelhGQ2hPM3RjRzBucTRjWXZJZGlCRDNW?= =?utf-8?B?UlpSZkVvYkRzSWd5WWFRakROR3BjaERGWFdwbHprdGUrRjBlenRvRk16am1k?= =?utf-8?B?WW80aFNEaEhyQVdqRVg2eVh2ZFFCVVl5RDFjR1g5QTUyUHJKc3NtN3kybmJI?= =?utf-8?B?WVpjSWZ4NTJLUENzNFNnK1ViSEhJelhzaUxqY3ExNGpHY1RsNENVU0pudkNi?= =?utf-8?B?SHIyNXNRbFNmQVdEL0QzK3ZaZmcrY3o1eVl1QUZ1dEw1M0owT2VmTlQ3Qm0r?= =?utf-8?B?clRhNUdWUyt2STdGK3FxRC90VTlwbUQ5TzBJVUxsNjQ4MFg4VEVMM21jcWpP?= =?utf-8?B?TVlTK3ZiclgwV2pTelNzME5GNXJGbzI0Y3Fvd1I3NmFVek5aSC9PU1B0T3RH?= =?utf-8?B?TnVHTFU4NU9rdlRMbUhXTjBCQldZdFBMMXZZSU1FeUpXQ3ZNb0dtOTBwRVM0?= =?utf-8?B?K3dqK1A4TjgzUTIrNjdiUjNYa1BTUGRNZlVqMkJYb2Z6RWorbENSRGlnTS9I?= =?utf-8?B?M2ZKM0MwQURhM1BxQzZMbE0zdG5iU3h2bU5zTy8zSUhBNnFrUEJ6RzNsVmhn?= =?utf-8?B?MVJ2YWRIZEdXN3NHanRJRXovSVUxQmZwa1UvdTNEZm8yVTRvZGFnUExWak96?= =?utf-8?B?ekdzOFFraDVnOUdJRUMydkVOTXZGR1BqbUJvaW9IUGxwZWo3ZmQ3YmFCaGpU?= =?utf-8?B?c0l5djVZNmkzL2t5ZU1wYmNCQlMvblluRmJvdmpSVDZWcm9UZGNNbzNtVmU0?= =?utf-8?B?T2xkczhBbUdpTCtsTUx4SE1GaGVQWGtQcDhKQUlZSi83Um9LcHJxYjdOUHdO?= =?utf-8?B?cFdPMSt1a1BiZlUzUmJIeGg5UHZ3aElHb3QxTUo1ZTN6QzBVdUJCMU9hU0No?= =?utf-8?B?amhpQVZOcURRZmE5ZWhpeXNaMmZMWHg5MWFEZW82TElaOUNGeVNiR09nbGFJ?= =?utf-8?B?cE8yenZlamV5WjJsNDlhWXBOOEZ6bmVmeGpJRWlqQTZFZ0NaSEFtaS8rLzM2?= =?utf-8?B?TEsxYzZRMmliWjZGb3owUlFzU2M5QkR2TThlQ2hiTWJvbTVKVnRZYW1HUlhw?= =?utf-8?B?TDdwbmxhUWwxdW4xUFJaSWM0eXR2V0dyTXhCb3E2RlJIU0w2NTBMY3l4M0tu?= =?utf-8?B?aDRRQmV3alBCTGs5cGQrdXYwWFkvQmdlNjJXaUZxU1hrdHY3T1p5WTlmWTdM?= =?utf-8?B?UHU4blVtM1h4L1JHbGE5QVVFczJqRUlYakVKb2JvRzV4TFBQa2hJNUtrTDNi?= =?utf-8?B?UGF4Q2ljcXhDeVo5TWdqa3N2OTF6ckhaclErUUNvOEFmSStYY1BmTnJIeEo5?= =?utf-8?B?WEdPNFJJNDNtMGNjMEQrc0d0YUpwZytodXlQS2ZQeGJBNjB3TVN0NVpmNjhu?= =?utf-8?B?NktIQmdBZ2VUZzlWd0FnbHMvOUlFMjBidGRnd2NQWUwvdzVkdUVSYjB4TTI5?= =?utf-8?B?eWtwSFlReGRqbjdIVm1EcFpzWGVodjVOT3pYUSt3d2dOUjJEWGtGaWNNKzJj?= =?utf-8?B?ZEdVdGVzRDdDdWJPeVhwOUtWY3pPdG93M0dYa1BXeElydHhvUXhDRlg5M0Jn?= =?utf-8?B?VzU5YmFPSFlvaElqZnVvbytuSGRYOEFFSnJhOSs4ZUhhZHJGb09YVGxKcHRU?= =?utf-8?B?Nld0TzlRWS9vM3NzVFhVRmx4VXFCRVhIZDdsUFpLeEhsV1ZBVUNKbU1DVTdj?= =?utf-8?B?K1F6M0paQW93Ykt0YTQxQWExOFE2R3R3Z2ljaWh5bmg3T3ZQUCtrVmo3RHN3?= =?utf-8?B?dE1wZm1raVdxMGtTUWI3UHo3R2tQV0NVcTF3RzAxQmEyMWNRY2JYNU9jZ1lO?= =?utf-8?B?MjlPWDQ4QmRHalNvNHE1S3F4RkVDZU52NGtwaU02NXJ2T1Uwdi93N2NzR050?= =?utf-8?B?Wml1QXIxaG8ycUI3WVVPSlIwL1ByMHkybWM3SDFlZHRWa2JRYkJFNkhweWh2?= =?utf-8?B?OVFDN3hLczBPc0MzMDdzSTM4WGk4RFJZSkdsLzRncG90QTJJOElLeUNQNDkz?= =?utf-8?B?TWtFalhkN3l2T0IweW5LM0JCRXdMSTRNVlg3T1UwOGQ3RE5VT0dUZktVSkZE?= =?utf-8?B?WmQ2ZFdTdUtBTm1keCtZa09aV3BDNVcyV3V5a0hWTUkvTUpGRFZmS1ppWUNB?= =?utf-8?B?N1ZYNHQyV21xWUVSaXhlK3BDRlROYmpyOHFLcG5lektkNHFuWGpRVURZYVNj?= =?utf-8?B?T0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iYaMoHHW8Jnb5IEqeTMG5nF8knAXoY8XpIcvk/UZ8sGIWuj4l0MgWIMuUfOkZUNy63ShhiEk6TbQSsG7QVhmEjXch3xyrnUKxxiwvC32M1/F0mQ24R4TfTmd9EmU09KV5k7botI8u+sTwTHEMxvnj7C0fbhnu0rm7HBqLP1B7YTbBv7NMT96wXbaS9z1qMYbHL9qhYd2kcEJZSVoyFdqfr9oYKGWkhMuxAJthhaf3TAnkcFhFzGKd6DRYvAlWDyPi2hab+8RxR7HXIb4IiL2pb/0f+Grb6Nl7HlWMRV8innu3Jh3QqtkM+xVAIa+OKlmRJ4VNuYLOjIgw9NdWPcZpkD7kJb5cylMfYu0Yjw1FQoJbi0vP295xv+fOIF2fUMWWwz8eFI/xSsoTVdz6jZmfi3KuGypVfJukpSOE/l2gj4bcn6WhRFfzBUVS/X9RLzzFK6LkYItgPGgYgwvXCjS0x2hiW0K1Lh5b9btoT6HejKuUJbp5RuJ1BpztpUVMQtCHNKiD4QplwQr4LdKPxfpC+98U5jP+GHNoMCqXUhENot+S60Afzk0qml4HUdMlX6lwjL5U7ACsYdGWUxNHPAJrY0sxZ8u17ytcm/stNpaPZAapo0wvmyHyCgdOjWYMshtY3KIpldi+F+iY9afdICFhc+lsN/hWK++uBdNagbMiP8yWOKfILxZiXjfq4QmgLKJM68WS5jxhXFuHbjz/+nRSOWIGzVSC0yG1UZYW4LCnt/IioHwt4qpnToksmrWGQONCAUnY7qqxFuE7RLQL/0qOfOjgrXWLzUtq90M1/4jzt8vfCK4g3UiSLRIZ1hNbW4V X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cc8c0c4-3d99-4703-4b08-08db0f6b4078 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:42:32.3255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XUfDewIgShbCRRFowB3gEN5AZUaZa6T17RD2mrdxtNkJ7bjDAhm6bhUH3L77JM4+stbbc8apEBDQO8yKuItfqR4QuIrbAtqxrA2FsBpdRIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6485 On 15/02/2023 3:21 pm, Anthony PERARD wrote: > Unfortunatly, --default-symver doesn't work on FreeBSD 12, with LLVM's > LD. Instead, we will generate a temporary version-script. It was all builds, not just FreeBSD 12, and not really FreeBSD either. LLD simply doesn't understand the --default-symver. It's just that the FreeBSD builds are the only ones where we're using LLD.  All the gitlab clang tests are clang+binutils, not clang+llvm.  We ought to change this irrespective. > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index 0e4b5e0bd0..cab8e9704a 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -72,6 +77,10 @@ headers.lst: FORCE > @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp > @$(call move-if-changed,$@.tmp,$@) > > +libxen$(LIBNAME).map.tmp: FORCE > + echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp > + $(call move-if-changed,.$@.tmp,$@) It has come up in the past that using literally VERS_ is buggy, because anyone who copy&pastes too much of the canonical reference will end up making a compatible binary. Xen's stable libraries are buggy, and at some point we really do need to bump them all to 2.0 to fix this. VERS should be a library reference, so libxen$(LIBNAME) in our case.  I suggest we take this opportunity to fix the unstable libraries. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 15:45:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 15:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496105.766666 (Exim 4.92) (envelope-from ) id 1pSJyX-0005JY-KE; Wed, 15 Feb 2023 15:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496105.766666; Wed, 15 Feb 2023 15:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJyX-0005JR-HS; Wed, 15 Feb 2023 15:45:41 +0000 Received: by outflank-mailman (input) for mailman id 496105; Wed, 15 Feb 2023 15:45:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJyW-0005JF-7W; Wed, 15 Feb 2023 15:45:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJyV-00060B-W3; Wed, 15 Feb 2023 15:45:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSJyV-00031C-OM; Wed, 15 Feb 2023 15:45:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSJyV-0004EY-Ns; Wed, 15 Feb 2023 15:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sPJ0N4PIwIhOP5I0sRD4mD0QWN8rQ/sBSXdHmbVz2K8=; b=UinX01WjpVgC5JdKsHJH7V3cAz QZwBjZUXDWE8S9WhHFmpMzFdiyioWf+ej2imXY10cT8UvA3jKAEiv4Jgzh7JnX1s6VM1AHQmsHiSq M6WSCoWH0m2WzwWufUVLLgcsLa5k84LUwnukcHG5QdimLwQVMRkceoC+43dP92v+/kaE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177333: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=e1c04510f521e853019afeca2a5991a5ef8d6a5b X-Osstest-Versions-That: linux=82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e From: osstest service owner Date: Wed, 15 Feb 2023 15:45:39 +0000 flight 177333 linux-linus real [real] flight 177395 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177333/ http://logs.test-lab.xenproject.org/osstest/logs/177395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 177298 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177298 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177298 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177298 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177298 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177298 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux e1c04510f521e853019afeca2a5991a5ef8d6a5b baseline version: linux 82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e Last test of basis 177298 2023-02-14 17:43:56 Z 0 days Testing same since 177333 2023-02-15 01:14:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Manivannan Sadhasivam Rafael J. Wysocki Viresh Kumar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e1c04510f521e853019afeca2a5991a5ef8d6a5b Merge: 82eac0c830b7 6f098cde9df2 Author: Linus Torvalds Date: Tue Feb 14 09:38:33 2023 -0800 Merge tag 'pm-6.2-rc9' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm Pull power management fix from Rafael Wysocki: "Add a missing NULL pointer check to the cpufreq drver for Qualcomm platforms (Manivannan Sadhasivam)" * tag 'pm-6.2-rc9' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: cpufreq: qcom-hw: Add missing null pointer check commit 6f098cde9df2c86d60db727d6270272751943674 Author: Manivannan Sadhasivam Date: Tue Feb 14 15:11:15 2023 +0530 cpufreq: qcom-hw: Add missing null pointer check of_device_get_match_data() may return NULL, so add a check to prevent potential null pointer dereference. Issue reported by Qualcomm's internal static analysis tool. Fixes: 4f7961706c63 ("cpufreq: qcom-hw: Move soc_data to struct qcom_cpufreq") Signed-off-by: Manivannan Sadhasivam Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki From xen-devel-bounces@lists.xenproject.org Wed Feb 15 16:22:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 16:22:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496114.766676 (Exim 4.92) (envelope-from ) id 1pSKXY-0002nE-EH; Wed, 15 Feb 2023 16:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496114.766676; Wed, 15 Feb 2023 16:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKXY-0002n7-Bm; Wed, 15 Feb 2023 16:21:52 +0000 Received: by outflank-mailman (input) for mailman id 496114; Wed, 15 Feb 2023 16:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKXW-0002n1-Uu for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 16:21:51 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6f72dcd-ad4c-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 17:21:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6f72dcd-ad4c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676478108; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:content-transfer-encoding:in-reply-to; bh=6uwc1AQrOxLfk+9nw0OPLHBiC7hZ2w514oUfVGWijuw=; b=XCKNWlweEqhODHMHDx3KLNm4hL4Mx2xHsGsgUs2XsU+qFAUIqwfOmvrx WgSRVBD0+5OxGZllfLKF0l9fCz2k4+JDGd50IS2mD+2TN2hUSnqCSy479 EAzV77uzxJ6LuZLNUik3Zu61rXKYCyc391H0n7nR9NRIfpBntHSTEFLm7 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97578988 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ehFjWqnSIOx5XrhIqQtRlTno5gy4JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIfCD3Xb/aNN2L1KYoiaIm1/U8Ou5aEm9RgTAVsrCEzQiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eMGNh0dTkiJvuuz/a+na+tFhNgjLPC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfH+ z2WrjSpav0cHIWwwiOK+C6ev9DsnwjbQ7JRTLigrMc/1TV/wURMUUZLBDNXu8KRkVWiUthSL 0gV/CsGrqUo8kGvCN7nUHWQqWaJpBcGV/JMEucx70eGza+8yw2QHGQDQxZKYcYqs8JwTjsvv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iNht1FSVFI8lSfPryISvQlkc3 gxmsgAhmas+ne5T3Zyy+G3anxOuj5rVTg4Ms1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02wYHInU3y9i6F5dPl6h06So2GkpmO91sldTBM B6K4lM5CHO+0RKXgU5Lj2CZUZ9CIUvIT46NuhXogjxmOMAZmOivoklTiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymH9gnjKCG8qqlUT9uVZ7WJJzYe1dWLdpRrpkhJ5oXS2Pq 4oPXyd040s3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI/cFzN/8T5mOt7E6Q8xvQ9qws91 i3lMqOu4Aal1CKvxMTjQiwLVY4Dqr4u/S5qbHB1bQ7ANrpKSd/H0ZrzvqAfJdEPnNGPB9YuJ xXZU61s2shydwk= IronPort-HdrOrdr: A9a23:odaSdak4IFR6HcpZwlAI69Wcgq3pDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="97578988" Date: Wed, 15 Feb 2023 16:21:34 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 2/4] automation: Ignore package authentification issue in Jessie container Message-ID: Reply-To: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-3-anthony.perard@citrix.com> <949bd6fb-a6b2-71bf-7eed-374939b54fb4@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <949bd6fb-a6b2-71bf-7eed-374939b54fb4@citrix.com> On Wed, Feb 15, 2023 at 12:36:30PM +0000, Andrew Cooper wrote: > On 15/02/2023 12:02 pm, Anthony PERARD wrote: > > We can't easily install package on Debian Jessie anymore, the release > > keys seems to have expired without a way to get new ones. We have > > these warning: > > W: GPG error: http://deb.debian.org jessie-updates InRelease: The following signatures were invalid: KEYEXPIRED 1668891673 > > W: GPG error: http://deb.debian.org jessie Release: The following signatures were invalid: KEYEXPIRED 1668891673 > > > > So, from now on, ignore the warning and force the installation of > > packages that can't be authenticated. > > > > Signed-off-by: Anthony PERARD > > --- > > > > Or, we could just not test on Jessie anymore. > > Jessie fell out of support in 2020, so its certainly not reasonable to > be testing it any more. > > But on older branches, we do want to keep it around, so I guess we want > to fix the containers to still be buildable... > > But is this really the best option? Some googling suggests that all we > need is a properly up-to-date debian-keyring package. Are the jessie > docker tags really shipping with a broken base package? I did try to find a better solution that "--force-yes", I did find out about installaling the latest "debian-archive-keyring", but it is already up-to-date. Installing "debian-keyring" instead doesn't change the keys. But it looks like there's another way. We could use "debian/eol:jessie" as base image instead of "debian:jessie", and that works. I'll update the patch with that. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 16:29:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 16:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496120.766688 (Exim 4.92) (envelope-from ) id 1pSKeN-0003XD-6d; Wed, 15 Feb 2023 16:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496120.766688; Wed, 15 Feb 2023 16:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKeN-0003X6-35; Wed, 15 Feb 2023 16:28:55 +0000 Received: by outflank-mailman (input) for mailman id 496120; Wed, 15 Feb 2023 16:28:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKeL-0003SQ-6y for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 16:28:53 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d43bbac3-ad4d-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 17:28:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d43bbac3-ad4d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676478531; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=ueYuF6PuNsKhD9Fqrikn9VQj9pIuX1bNFBJHa7aHTCo=; b=XgetsisCbWRbjSKwkzYBKsLg6PBogoFhwI2tO4gOP9toV10qCFMONVQf HiPBeI9oWkfI/MO2g9hD2JFrHxszy1yACQP3PLgjsDP5oVD809ZlG0FBK dTJscrkiXl8xpNruxPcGovmtuEl91jrQIawrcuF4y+I+nqloY13n+VI9S I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96557526 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:qX82Da4Eajx7lvVOUKAPywxRtAHHchMFZxGqfqrLsTDasY5as4F+v jQfUWyPPfeKa2GgfNx/bd/l90sHuZaGyN82GQo4+S1mHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m0 uRBLQgnNhu5xPuI6p3lYdAv2M4hBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxjF+ z2bpTqR7hcyBOGa92GvrVSWnOr0gBj0W7kzGP6K+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9FZCeE95SmGw7DY5AvfDW8BJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIVqU7rqOpCm+ETQUJ2QFIyQDSGM4D8LL+d9pyEiVF5A6TfDz14eucd3t/ 9yUhA8m3rArp5YA7eaiw3ro3RmV5cbDTCdgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgarrUKzGLoC6T7wJs8w4iPIUOvCdkyfZlByCnWbKgwjQfLEEyMnTw 6uzf8e2Fmo9Aq961jewTOp1+eZ1mX5llDKNH8Ghn07PPV+iiJi9E+9t3LymNL1R0U95iF+Nr 4Y32zWilX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClMOJY3VMNeImelJU9U8z8xoehLgo inVtrlwlACu2hUq6GyiNhheVV8Ydccv8SNqYXV8ZT5FGRELOO6S0UvWTLNvFZFPyQCp5acco yUtEylYPslydw== IronPort-HdrOrdr: A9a23:KbfuzKp9VhDdgPNo6KNA9kcaV5rdeYIsimQD101hICG9Evb0qy lhppQmPH7P+VAssRQb8+xoV5PufZqxz/BICMwqTNWftWrdyQyVxeNZnOjfKlTbckWTygce79 YET0EXMrbN5DNB/KLHCWeDcurJwLO8gd+VbeW19QYScem9AZsQnjuQCWygYz1LrBEtP+tBKH IFjPA32gZJfx4sH7yGL0hAZcfvjfvRmqnrZBYXbiRXlDVn3VuTmcXH+wHz5GZlbw9y X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="96557526" Date: Wed, 15 Feb 2023 16:28:30 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container Message-ID: Reply-To: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-2-anthony.perard@citrix.com> <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> On Wed, Feb 15, 2023 at 12:26:40PM +0000, Andrew Cooper wrote: > On 15/02/2023 12:02 pm, Anthony PERARD wrote: > > First, apt complain that it isn't the right way to add keys anymore, > > but hopefully that's just a warning. > > > > Second, we can't install clang-8: > > The following packages have unmet dependencies: > > clang-8 : Depends: libstdc++-8-dev but it is not installable > > Depends: libgcc-8-dev but it is not installable > > Depends: libobjc-8-dev but it is not installable > > Recommends: llvm-8-dev but it is not going to be installed > > Recommends: libomp-8-dev but it is not going to be installed > > libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable > > E: Unable to correct problems, you have held broken packages. > > > > clang on Debian unstable is now version 14.0.6. > > > > Signed-off-by: Anthony PERARD > > Yeah that's because clang 8 is way obsolete, and http://apt.llvm.org > only supports Clang 15 and later now. > > In hindsight, it was a mistake to take unstable-llvm-8.list in the first > place. > > Acked-by: Andrew Cooper I just realize that this change is going to break gitlab testing in the staging-4* branches. So I guess this mean that we will have to backport this patch, or at least the gitlab-ci part. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 16:30:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 16:30:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496124.766699 (Exim 4.92) (envelope-from ) id 1pSKfX-0004sb-GN; Wed, 15 Feb 2023 16:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496124.766699; Wed, 15 Feb 2023 16:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKfX-0004sU-Ch; Wed, 15 Feb 2023 16:30:07 +0000 Received: by outflank-mailman (input) for mailman id 496124; Wed, 15 Feb 2023 16:30:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKfV-000424-1R for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 16:30:05 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-flk1.inumbo.com (Halon) with UTF8SMTPS id fee0f921-ad4d-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 17:30:02 +0100 (CET) Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by e5eb38c229f8 with SMTP id 63ed088816b764e6c16079a3 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Wed, 15 Feb 2023 16:30:00 GMT Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-4a263c4ddbaso284134887b3.0 for ; Wed, 15 Feb 2023 08:30:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: fee0f921-ad4d-11ed-93b5-47a8fe42b414 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676478600; x=1676485800; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=3JcYIJ8kGEXm/rsvXm1X6HA3jDavISFYmyXYUcjPfT4=; b=ScHiTyu9GBjWlplTh03VbVQrBJLDMsgYI3J0G0vXbXPGf1hYE0nCm0GOMots251q0d8KzAt5jb/H3OLUgdt8Rrh2CUiTOl+1ShdJL/vm+m4II444pegqnZOODuwDpqa4C1Cx7E8MgZ1bc37696U8Cg63tVuA3OI+UhSjPhiyazhNCXuOuN7cc4v1xjy3h9qQjqOyqGxeuN9vb6EIaSr/FqA8ypPLNkHVKmswih2Objfvspnp7w/d/hJpS78cXnA+xk4OaW4xpo7ZeDjgJji070mjFrP4iZ0cPFpP/ccU63uSWIDPSJ+jtjfSzKcA5PagRQh+updORphsRyLt+MG5Mg== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKWB3ujELtvVs205uPzb57iQYn+KMi1xrAJo1tyvicmU+zmiPvjU JFwb4YeYN8352eXiYjt7VVvYik348I5zZp/RpGA= X-Google-Smtp-Source: AK7set89sVM0olLvnKaVY/lw+VKsVKbVPgLIuD29KC28I2kv589Diabb9LoIFHMF9kYT40unnJSKA1YCnTQHhjDdjFs= X-Received: by 2002:a25:8e05:0:b0:88b:c82b:f90d with SMTP id p5-20020a258e05000000b0088bc82bf90dmr334143ybl.641.1676478600137; Wed, 15 Feb 2023 08:30:00 -0800 (PST) MIME-Version: 1.0 References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> In-Reply-To: From: Tamas K Lengyel Date: Wed, 15 Feb 2023 11:29:23 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000006f524c05f4bf979b" --0000000000006f524c05f4bf979b Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > > On 14.02.2023 06:07, Tamas K Lengyel wrote: > > An assert failure has been observed at p2m-basic.c:173 when performing vm > > Please can you at least also name the function here? The line number is > going to change, and when coming back to this change later, it'll be > more troublesome to figure out which precise assertion was meant. Yes, > ... > > > forking and then destroying the forked VM. The assert checks whether the > > domain's shared pages counter is 0. > > ... you verbally describe it here, but still. Sure. > > > According to the patch that originally > > added the assert (7bedbbb5c31) the p2m_teardown should only happen after > > mem_sharing already relinquished all shared pages. > > > > In this patch we flip the order in which relinquish ops are called to avoid > > tripping the assert. > > > > Signed-off-by: Tamas K Lengyel > > --- > > Note: it is unclear why this assert hasn't tripped in the past. It hasn't > > been observed with 4.17-rc1 but it is in RELEASE-4.17.0 > > That's almost certainly a result of e7aa55c0aab3 ("x86/p2m: free the paging > memory pool preemptively"), which added calls to p2m_teardown() to > hap_teardown(). If you agree, this wants recording in a Fixes: tag, as > - being an XSA fix - that change has been backported to everywhere, and > hence the issue now also exists everywhere. Ough.. In that case we'll need this patch backported too. Will add the Fixes: tag. > > > --- a/xen/arch/x86/domain.c > > +++ b/xen/arch/x86/domain.c > > @@ -2310,6 +2310,32 @@ int domain_relinquish_resources(struct domain *d) > > if ( ret ) > > return ret; > > > > +#ifdef CONFIG_MEM_SHARING > > + PROGRESS(shared): > > If we go with the re-ordering as you suggest, then please also move the > enumerator near the top of the switch() body. Sure. > > Did you consider the alternative of adjusting the ASSERT() in question > instead? It could reasonably become > > #ifdef CONFIG_MEM_SHARING > ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || !atomic_read(&d->shr_pages)); > #endif > > now, I think. That would be less intrusive a change (helpful for > backporting), but there may be other (so far unnamed) benefits of pulling > ahead the shared memory teardown. I have a hard time understanding this proposed ASSERT. > > > + if ( is_hvm_domain(d) ) > > + { > > + /* If the domain has shared pages, relinquish them allowing > > + * for preemption. */ > > Similarly, if the code is to be moved, please correct style here at this > occasion. Sure. > > > + ret = relinquish_shared_pages(d); > > + if ( ret ) > > + return ret; > > While I can easily agree with the movement ahead of this being okay, ... > > > + /* > > + * If the domain is forked, decrement the parent's pause count > > + * and release the domain. > > + */ > > + if ( mem_sharing_is_fork(d) ) > > + { > > + struct domain *parent = d->parent; > > + > > + d->parent = NULL; > > + domain_unpause(parent); > > + put_domain(parent); > > + } > > ... I can only trust you on being sure that moving ahead of this is > okay, too. That's fine, we are in the teardown of the fork so it doesn't matter where you are releasing the parent as long as its after the fork is unlinked from it. Thanks, Tamas --0000000000006f524c05f4bf979b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 14.02.2023 06:07, Tamas K Lengyel wrote:
> > An assert= failure has been observed at p2m-basic.c:173 when performing vm
>> Please can you at least also name the function here? The line number = is
> going to change, and when coming back to this change later, it&#= 39;ll be
> more troublesome to figure out which precise assertion was= meant. Yes,
> ...
>
> > forking and then destroying t= he forked VM. The assert checks whether the
> > domain's share= d pages counter is 0.
>
> ... you verbally describe it her= e, but still.

Sure.

>> > According to the patch that originally
> > added the a= ssert (7bedbbb5c31) the p2m_teardown should only happen after
> > = mem_sharing already relinquished all shared pages.
> >
> >= ; In this patch we flip the order in which relinquish ops are called to avo= id
> > tripping the assert.
> >
> > Signed-off-b= y: Tamas K Lengyel <tamas@tklengy= el.com>
> > ---
> > Note: it is unclear why this a= ssert hasn't tripped in the past. It hasn't
> > been obser= ved with 4.17-rc1 but it is in RELEASE-4.17.0
>
> That's al= most certainly a result of e7aa55c0aab3 ("x86/p2m: free the paging
= > memory pool preemptively"), which added calls to p2m_teardown() t= o
> hap_teardown(). If you agree, this wants recording in a Fixes: ta= g, as
> - being an XSA fix - that change has been backported to every= where, and
> hence the issue now also exists everywhere.

Ough.. In that case we'll need this patch backported = too. Will add the Fixes: tag.

>
> > ---= a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> &= gt; @@ -2310,6 +2310,32 @@ int domain_relinquish_resources(struct domain *d= )
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( ret )
> > = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ret;
> > > > +#ifdef CONFIG_MEM_SHARING
> > + =C2=A0 =C2=A0PROGRESS= (shared):
>
> If we go with the re-ordering as you suggest, the= n please also move the
> enumerator near the top of the switch()= body.

Sure.

>
> = Did you consider the alternative of adjusting the ASSERT() in question
&= gt; instead? It could reasonably become
>
> #ifdef CONFIG_MEM_S= HARING
> =C2=A0 =C2=A0 ASSERT(!p2m_is_hostp2m(p2m) || !remove_root ||= !atomic_read(&d->shr_pages));
> #endif
>
> now, I= think. That would be less intrusive a change (helpful for
> backport= ing), but there may be other (so far unnamed) benefits of pulling
&= gt; ahead the shared memory teardown.

I have a har= d time understanding this proposed ASSERT.

>
= > > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( is_hvm_domain(d) )
> >= + =C2=A0 =C2=A0 =C2=A0 =C2=A0{
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0/* If the domain has shared pages, relinquish them allowing> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * for preemption. */=
>
> Similarly, if the code is to be moved, please correct styl= e here at this
> occasion.

Sure.

>
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0ret =3D relinquish_shared_pages(d);
> > + =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0if ( ret )
> > + =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ret;
>
> While I can easi= ly agree with the movement ahead of this being okay, ...
>
> &g= t; + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*
> > + =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * If the domain is forked, decrement the pa= rent's pause count
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 * and release the domain.
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 */
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0i= f ( mem_sharing_is_fork(d) )
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0{
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0struct domain *parent =3D d->parent;
> > +
> > = + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0d->parent =3D N= ULL;
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= domain_unpause(parent);
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0put_domain(parent);
> > + =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0}
>
> ... I can only trust you on being su= re that moving ahead of this is
> okay, too.

That's fine, we are in the teardown of the fork so it doesn't= matter where you are releasing the parent as long as its after the fork is= unlinked from it.

Thanks,
Tamas
=
--0000000000006f524c05f4bf979b-- From xen-devel-bounces@lists.xenproject.org Wed Feb 15 16:31:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 16:31:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496130.766710 (Exim 4.92) (envelope-from ) id 1pSKgn-0005Ua-Uz; Wed, 15 Feb 2023 16:31:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496130.766710; Wed, 15 Feb 2023 16:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKgn-0005UT-S1; Wed, 15 Feb 2023 16:31:25 +0000 Received: by outflank-mailman (input) for mailman id 496130; Wed, 15 Feb 2023 16:31:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKgn-0005UL-2n for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 16:31:25 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e78a9ce-ad4e-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 17:31:23 +0100 (CET) Received: from mail-bn1nam02lp2043.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 11:31:19 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5718.namprd03.prod.outlook.com (2603:10b6:510:40::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 16:31:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 16:31:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e78a9ce-ad4e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676478683; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=RUzntasEA1IGP1I5xMu2oH6cT2IvxJ0KqgxR1n0lYRQ=; b=K1iBUFBNlCl37skH35S/JmzQPYKXPwabu2fQXolyhFC8u6VrCIDLfzvO blWoHaDHVG8tfCBmscS/aRShP2ZUEj9mNXQaSKrY6vst5Kiqd//LHEwG5 jNcN7Ylbmxs2U6fa2NIUGxFiYD4uTeXqVw7BhjasJ9Oe6JA9VOIFDYv7r 8=; X-IronPort-RemoteIP: 104.47.51.43 X-IronPort-MID: 97178812 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:X+Fe/a59TLdtOzHozOowNgxRtPHGchMFZxGqfqrLsTDasY5as4F+v jRKXm+GOfaPYzShctEiOY6+9RtVsZ7dz99jHVFurXwwHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4QeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my qZBMB8gNTO/od2w2IChEPNCi88KFZy+VG8fkikIITDxK98DGcqGaYOToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OlUoti9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCd1LS+3or6QCbFu73mMPOiI2ZFaHuPyEskKlAcxUc H4Kw397xUQ13AnxJjXnZDWxpmKEuRgNHcJdCeQg5CmCz6PV50CSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaMiEPIWgPTSQNVwcC7p/op4RbpgnUUt9pHaqxj9v0MTL92 TaHqG45nbp7sCIQ/6Cy/FSCiTT1oJHMFlQx/l+PAjnj6R5lbom4YYDu8ULc8ftLMIeeSB+Go WQAnM+dqusJCPlhiRCwfQnEJ5nxj97tDdEWqQUH80UJn9h1x0OeQA== IronPort-HdrOrdr: A9a23:ECAl7qtE1+z+xfgfzJByhi1P7skCpIMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhAo6HnBEDkex/hHPFOkO0s1NuZLWvbUQiTXeJfBOnZskTd8kTFn4Yzu8 ddmsBFeaXN5DNB/KHHCWeDYrMdKe28gduVbKrlvgRQZDAvT5slwxZyCw6dHEEzbA5aBaAhHJ 7ZwsZcvTKvdVkec8z+XxA+Lp3+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAuQ3k4aeIte2913bnph3uxqUTvOGk5spIBcSKhMRQAjLwijywbIAkYLGGtCBdmpDQ1L5/+u Osnz4Qe+BIr1/BdGC8phXgnyP61iw11nPkwViExVP+vM3QXlsBeoB8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVittilG/rRMZ4KUuZkRkIMYjgYJq3MUiFQJuYeE99RvBmfca+T xVfYnhDPU/SyLkU5mWhBgi/DWWZAVOIv63eDl+hiWr6UktoJlY9Tpo+CVNpAZxyHt6cegx29 j5 X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="97178812" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9ZuoKoJN4h2kx50bqMhccGZ0+Bx71ugx3AoFfKskELxHnwa7H7kgAUXTnp+q/ERwCqaItbGGXDMWFxhpiwQZt7FIFEVmIWDbToYjXIZE5GxYaV8xuPbQbr3Afngxx4ThOp4F/QsP7dPkx9fxOnSl2QFVgquwZgKXoFIkEAWzXPSmbchRbOGv6XraVl/X1MK5Gq8nIS5n7g0fzZqmBvK6VWiITH2/QP08PLC7EWBD7RE/zu6VWA7ixxX8bxDBE6nJ0gxvTWMsfJKEcuA+CTuK0HUWHB/hmzspkfdaEBU+e60kX2zEGrrLbvjxBhHBr/uJWw0XeONXR3AQjI5Nahq5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=POhkDcy4T0RVrI40NoLFwQ5a1pXR/V2ypSL+qpH5LK4=; b=JsaDqMUnRXrG3j00PIBi4H0Uj0MhbkbkqW/wwLLVzJR6GWHak3/c+K7td2j7o85tai6yewoPH4T9WeihZFnqWKM0ZpIoWMOF0qmeWiXBJpSqo0kh8jV+KlnYDcSH4pqYAFbfq9mGOaLK+R07cZmGc720lMbzPm/Pp7NdxTX7fb7JXpveHk9uy/XT0tzUfA2WE10dISn7uJ02j//XrmrLoL44bReB26s2iOsJlo2mMCV2t9NP/YxPu9Ol7XfrIblD354nDfewB5NbdaDpAs5XESajci2/vTxyjwZvgRGfdHnzxV0k4Mhx5Kzh/ppuWYhQM9KL25p3xcASBe5E/+vQgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POhkDcy4T0RVrI40NoLFwQ5a1pXR/V2ypSL+qpH5LK4=; b=WHl7UBFJQrB+k/bODtFerLWIt1IaxLIxMmVeHNIK0BeRCHIvYEbjmLib8cPG45Fv79a1D2zjApjB1iWZqYAds8mBSLFauQqRsD8gtqO94Ct6x55KqO1GZNY+C4xkoSrjep3tisO0kb14jur7dRYyiMEZWjkxZ9OFZQ8F7eUgLNI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6c455c45-18d3-584e-bc8a-a1d22a68fcd3@citrix.com> Date: Wed, 15 Feb 2023 16:31:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container Content-Language: en-GB To: anthony.perard@gmail.com Cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-2-anthony.perard@citrix.com> <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0340.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB5718:EE_ X-MS-Office365-Filtering-Correlation-Id: 651448b8-603a-4a6c-1a87-08db0f720fb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TPeYvsi0ApY/aeDMaKY7S09Yi6qBMW87zojBmJf5NDGyIhwaaH3oU7sAZTRH8COcd7Qe/MgMYaRi8h9N18e0/Xld/4tSGjt3fXozZXCYqti00A8IyvC3O8ygk63e9OhP0F6slvXShw6f0ybx8bXcEAv7d6b5yiLPfDnc6OI81o3yXI4sserNRuTOGn6BFpTwWTuW7A3x/9jw5qPp1QokZEb45e3vfAjjuBqlFWKSkM2Gu7Z6cK74Q6s2wg6sJjsT5OQkHyPDrTeNei2AMvPTmgVA72o3iBACJlvUIg1X7AuxcLIU4K2MRCdVz9EO+/Jb7V15Qxp+AL3s96B8K/UCiT4BW1psO3DYaz5PqIjmjf5e2Yj21HVp0iXOVP/6iWZtuxPkTWiAuV+jdsQYvqCmY5cOrUtDdksUA37XBE8hOWc4j6ZyUEd+jONPi1NUJ7T2vCbhw+YXJ8KMa7QW3oqFjSfC9Tl+LD0qcw/Aux2dEQVWiYy3mojRVtlz0Vbt7sSLyPPDlPWOL2sV0RPnDN0LhH4X1BbTEvCYpWnIDfe+uS5YfDnI7yAgg3BznGsqEq1ek3NxkoFMFC97a5YWacP3HLDE7o+dgpfUTbrCZBA3MgTUbjCrlck55ayFyF6jZMgPc/uFulXFZ4jASNuQr+NuNmqa3XPJAr4qvDAN2hFv/tqukIZ8nDfFYzm0iZKH83obtp1YD3mimEQPwApB2joqEIjEG9bfBF4j0WXIbQQTVmA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199018)(2616005)(966005)(6486002)(53546011)(478600001)(6512007)(83380400001)(26005)(6666004)(6506007)(186003)(86362001)(36756003)(31696002)(82960400001)(38100700002)(8936002)(66476007)(5660300002)(316002)(54906003)(6916009)(4326008)(41300700001)(8676002)(66946007)(2906002)(66556008)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUhEL0xVUGdmMGJEbGNtT2FTbXk4bGpwSmhRam11TGQ2NlZ1Y3FPdS9PbC9N?= =?utf-8?B?WERWWXdPRGVoMnFSLzJQUjNXQTZjOFpkS3dkMDZiWlgwZml4UDVlSWJpdnNj?= =?utf-8?B?RElEZFN0TmhrUTl3TktoYWtsc1VwRDJPVnA3RFRSRG9tQm9NNDNLWUpWS1hx?= =?utf-8?B?eWNSNDhtQTlVay96eGFFM1o2cUhNdHJSUmUxeHVXVWRUSFc2MjVWOG82S2Iz?= =?utf-8?B?N2U3OVBqa09QVExmUGdXcHUwczJYTXhYMUNFNjVaVmc3L1l3WWV2RWNMblVl?= =?utf-8?B?MlZRc2Y2OFpYUVcwQjRZZGZqNk1iYllWT0Y5MXJjTnNsNFZHU0RiS282Q0hH?= =?utf-8?B?eXREV2JRc1luYzlkNGt6LzhLZ2NHOTlQeE5YbE5LOXdkUzZ4ZlJOdnRZL3lY?= =?utf-8?B?VWlmTEIxRmxFbFh3L3g5NmlQTGYwRUROZGFkMUZsaGVtUFpQcS9kS1F2b0F3?= =?utf-8?B?ZWV1SmR3R2FoemZCOGpSbmhTWWxOTW9UZk5NNEI2RzFTTUJXN3pIWDdKeVQ4?= =?utf-8?B?M0J6azhUa0k2Sk9YVlZ5c3QyM3Q3c1dGWDltaWIzU0s1YUo2eXR3UjlGcExs?= =?utf-8?B?SCtsc3Q2ZG5BVGdFbEpUeEdSTWd1ZFJWa0paVXpuU2tOTUVPb0tIZG5xRVY4?= =?utf-8?B?K0hMV0Npd25LZXN6SVN5c0FMMFlJbzdhWU5kN0dIUThsKytXMG9xckZ2Mm5z?= =?utf-8?B?STRqTVdjVU1IMExzU2tFL3lSSEJpV1UvdEFVNTROK2NIQUpsWjlITW50RFdD?= =?utf-8?B?d1BEa2NVeXpBbitDR09pL3hMbmdSZms3VFJRSk9ueEdPaHpXd01tdVBPdGts?= =?utf-8?B?V1FWaVRGNCtWWXc0emtrZ3JwaGNGSCtxQnRsaXRjZkZWSlVYQ2I0Q1BKY2VX?= =?utf-8?B?ZTdQc1RzQys1Z2FpbVVxeUgwQjdybytRZk1nbHRKeFI5dlNTcXlCMmNsZEhK?= =?utf-8?B?VitqMXByL21WM0tPNXpZbmR3VnRpNm9GbUprR04zenhKdVhJeSt6blRnSjF0?= =?utf-8?B?akFBeG5CODdtRDhBVUk1TUY1WVBGNXEyajBWSDl1dTBZREg3cEJwZ0FwZXVx?= =?utf-8?B?Z0F1bVJPdTdRRkRYV2Q1ZVFyN0dCRU1BdncxUzFPUkdMSXBFU05Xc0tDUGc1?= =?utf-8?B?S1lhUFFKUEVxaGg3Zm9XeWNxRy9SVXpyVHlXeUFWY2RHOEFtbWNUbXNGRi9E?= =?utf-8?B?c3dCay91N0ZRSHorbGhwSFBWZ2x2K29MMHk5K2hpSEpacDBkM3pITFprcXF0?= =?utf-8?B?V3RzSnBObmFRT3R5N2NBdUFHOHdrZ29NZnJHRkEvOVZwVmE5ZjlMYVhVZHYy?= =?utf-8?B?YTJoaTFWSGFGQkpvSXF3dmRIVHgxcW15ZUFCdUxUZkZuQkIwVEdGdGtHR3ph?= =?utf-8?B?QThsc2UxZEUwVkpCdVl5cUFMSStDSnZVYkt6KzByZjc5dHF3cFhqdXc1K3Zv?= =?utf-8?B?dE5ITjJIVjZzVEU4dytnSTlxNE5oZWhkMVRheUxGVGc5NCthbENnMC9XbXc5?= =?utf-8?B?STJPdVR4NTIyNWpoQ29IcGUwNG5pK01ueElLSEwzUG1EZ1FpNkVJenlaVC9Z?= =?utf-8?B?aFMzVFpUdmZNK1dKM3haOExOTU40REQ0ZkJKOEtCeW1qOFNLcVpNQkhUQmV1?= =?utf-8?B?dFZQalduSy9ZTHBqRkJYRkRMRFFLU3A1TElsMS9vTEhYbmNxZHdTUlJ5aTZ1?= =?utf-8?B?NXJYSmxxQVErc3puY3NueHo0bHo4MFR2b1JRdWJmZkJyUk9xT3dITjRZc3VS?= =?utf-8?B?OFN0cnJnRjJmekIybDFkdGd2SmFxUDJ2Q2VJRlZyNlBWb2llMnVqZk1HNzQ4?= =?utf-8?B?MExlSjZkeWNVSnRLbjlrVStoVll3UjRWdXFURjZMZWgyMUZpSG5TTDErbmx3?= =?utf-8?B?VTRua0FxT3YxQmZwRUJjY3F2RVNoRUZXWUNqSm8rVzFuTGFSellla1JUMmtM?= =?utf-8?B?SUNzMmQybldyRUFSZ2hxSDUwdWNUUEhLOFJQNDdIU2IySXo2cW1yUWZPSUkx?= =?utf-8?B?NGhESSt5NXN4OVc1ZGZLTS9rNXIvcGxqMUJycXdnK0Z4ZFVkbGxyQUVEaUwz?= =?utf-8?B?UWxjQzNxbUt1UkhGUFd3em5lcGx5RjU0S3pFR0dNQ05XdW1vWTVmWm9VNnRI?= =?utf-8?B?OWNKazRlR3RydWdPdXVMRWE3dDlORHhSWUdROExNSjhKQXo1MnhyU1FRaXN3?= =?utf-8?B?Y2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XAWqxforIJOwpO6PdGq28IhmOrtGsFImmSWKL+mGUG9rQicbAtgwBmdVmj7caWNR97JqcW38f9PdAe7OL0axmyL67gciAcCE2rhDJgm8O8IUytEdSPJ6Woj5JlPd8cV+kXQEfm6c8MxiRbGDkrUiMxO3YHd0ywOJtXj/njoOtaFbMKy65JSlSrVVOnNac2v9CWRAl+BUcfRTjDfw4LOvk8BNimpb+z+AP5cLAiZtOgFSZvrgYveXTyctQ3SpEd6fK4HyyKlK49rmgpAgkyYeF3I+9OBa8DOOPJcGPs+8Hg8RU5YIfrIdDsJEHD4p0qpsVTlw4I+Axrma05oUMrD3OgqfyjVU1wBTRGdDlitqOsFGCYT2El9Ssdg76KdP69E9xz5ACzIS1pUQ96EIm7YjLsJ1zqTYcnzz63cbNDDA+CoSN2FcstEVgmGW61u/xa9XSzpIojmSRR3RCP7tkmiCkghaZN0+irW/eYZVqbbI6cshPECBhbLhmSW5xhEZ2ZQvwxG+UFTdqVQcbzu78HYLA1FSqz1eNa4bChnsSO9q5Le95xOnl3nLXcGETSY5u99MqDE9IJZ5LS7EzG3DGq9T8CHkThxaqTPJTHL7Cuqlth10Odw3m9OvTADv5Ie47NcOfEj+/jjgmvf6g7sw1cEvJcCM3JevNLkCx7AVr5Tv5w7+LXlamYOoJg0xZgnNEGmOa7TSm7DwfttBgU8mg0TlB7sCkp7flNkSwfNclfEjcT77Nvl27iIC6/try2EHVHsTWKnTlAyqKvvLV+HmJCbttOpCr/WFdkaUwjFy4OVvHCQe4OxZFKn8ig5z852T/kMnmATGGt1svnHXPOtPasn2uJizZX+2JeuNYBqMKioUADk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 651448b8-603a-4a6c-1a87-08db0f720fb9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 16:31:17.3003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sKl66go3D1TJo42jGKDrI2eFuVxhhkrnY4tKIEVMwJHGfl6tVUsz+Vu5JDe/iRsgIgfiZNmEIGWOiJHjaAwHP9s3xnaECOjB+Hr+PWZx91M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5718 On 15/02/2023 4:28 pm, Anthony PERARD wrote: > On Wed, Feb 15, 2023 at 12:26:40PM +0000, Andrew Cooper wrote: >> On 15/02/2023 12:02 pm, Anthony PERARD wrote: >>> First, apt complain that it isn't the right way to add keys anymore, >>> but hopefully that's just a warning. >>> >>> Second, we can't install clang-8: >>> The following packages have unmet dependencies: >>> clang-8 : Depends: libstdc++-8-dev but it is not installable >>> Depends: libgcc-8-dev but it is not installable >>> Depends: libobjc-8-dev but it is not installable >>> Recommends: llvm-8-dev but it is not going to be installed >>> Recommends: libomp-8-dev but it is not going to be installed >>> libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable >>> E: Unable to correct problems, you have held broken packages. >>> >>> clang on Debian unstable is now version 14.0.6. >>> >>> Signed-off-by: Anthony PERARD >> Yeah that's because clang 8 is way obsolete, and http://apt.llvm.org >> only supports Clang 15 and later now. >> >> In hindsight, it was a mistake to take unstable-llvm-8.list in the first >> place. >> >> Acked-by: Andrew Cooper > I just realize that this change is going to break gitlab testing in the > staging-4* branches. So I guess this mean that we will have to backport > this patch, or at least the gitlab-ci part. I don't think it will.  The currently cached container is still "good" for the older branches to use, but we ought to backport the change nevertheless. Given that the container is un(re)buildable anyway, we're not losing anything, I don't think. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 16:42:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 16:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496139.766721 (Exim 4.92) (envelope-from ) id 1pSKqw-0007S5-UR; Wed, 15 Feb 2023 16:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496139.766721; Wed, 15 Feb 2023 16:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKqw-0007Ry-RY; Wed, 15 Feb 2023 16:41:54 +0000 Received: by outflank-mailman (input) for mailman id 496139; Wed, 15 Feb 2023 16:41:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKqw-0007Rm-2g; Wed, 15 Feb 2023 16:41:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKqw-0007rU-0v; Wed, 15 Feb 2023 16:41:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSKqv-0004MW-P1; Wed, 15 Feb 2023 16:41:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSKqv-0008Ry-OW; Wed, 15 Feb 2023 16:41:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kHRRKaSgApDOTemJN74x3QU2CKQHjoMNRKOSH7ClOs8=; b=nbAQ2nsbxqwPrpXq19SwAnHI60 /wScoJf/e+2hm2Vb1tfNcZEu+7kFI7NiT5ipAcCk7wIo267tiCnX2Ntl8MUjhB41g/dSruaGSnUK4 0s3blQOXoTWGxBYSE5odET8coFiwhvVqqEQ4VYZu8Tzud1F/m5fleZEbweUP4vbaAKRw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177347: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=b61c66d1dea2525290b7fa1f41ba6958bc39d63c X-Osstest-Versions-That: libvirt=c433c2434c0459df98ed3355ef615e341acd9009 From: osstest service owner Date: Wed, 15 Feb 2023 16:41:53 +0000 flight 177347 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/177347/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt b61c66d1dea2525290b7fa1f41ba6958bc39d63c baseline version: libvirt c433c2434c0459df98ed3355ef615e341acd9009 Last test of basis 177242 2023-02-14 04:18:49 Z 1 days Testing same since 177347 2023-02-15 04:18:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git c433c2434c..b61c66d1de b61c66d1dea2525290b7fa1f41ba6958bc39d63c -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 15 17:03:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 17:03:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496148.766732 (Exim 4.92) (envelope-from ) id 1pSLBl-0002H4-LW; Wed, 15 Feb 2023 17:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496148.766732; Wed, 15 Feb 2023 17:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLBl-0002Gx-Ir; Wed, 15 Feb 2023 17:03:25 +0000 Received: by outflank-mailman (input) for mailman id 496148; Wed, 15 Feb 2023 17:03:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLBk-0002Gr-Fl for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 17:03:24 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-flk1.inumbo.com (Halon) with UTF8SMTPS id a6b5bf7d-ad52-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 18:03:22 +0100 (CET) Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by acd012ecd2cd with SMTP id 63ed1058b561427b11a36b7c (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Wed, 15 Feb 2023 17:03:20 GMT Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-52eb7a5275aso275866877b3.2 for ; Wed, 15 Feb 2023 09:03:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a6b5bf7d-ad52-11ed-93b5-47a8fe42b414 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676480600; x=1676487800; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=ejXJhI1pThHE4QtLK+ivTrF8YaMudOiofw7hrlyuj9w=; b=MaxD05eArIUa4iuig83tPXeF5Rbb3To70GAX7uFGnBo3DJMMIU688MtL33QHegKhHmi7ZYPt0sZc+yP2iutVdA2kZN9631vtDyUXDO9yArrnNN7qLVbaE9DlryHsW/YBRcQfEf8AbDlcLi7J/gvrScpujD+Nedp2PtvJHxV6qsMsg5TAcnWcBUK6kWe8HEcAa4zTFQQkimU0FNSR0D7R90q05CWS5YwT9YCJ4pdyZ6VAoUMThZuzJI5TBTwioo5gyufBKWhsNZOSjwHiTdsON1WQXvWI4YXcKh7pV6CwwNrWq8HP6IYAFAFjchpnyduaFEcaySm1I6EL/eGmT68BVw== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKUxO2IAtxrCgYjakj8nCeEvmFHsc07t88Kk/3GAAUz5+f20j+6g 6tmzYI3KevtewFnxBut16S8QHTNS2hTwx0L0a7E= X-Google-Smtp-Source: AK7set8xcFUTxMYWBNgm6JKRehaBjxBRrRmS3ZoNk//Ez3pZhDbzez59fqrI7JFxl3soas8RWIfcQZP8ZXxPAuEQfEg= X-Received: by 2002:a81:6188:0:b0:52e:cb6b:4637 with SMTP id v130-20020a816188000000b0052ecb6b4637mr298959ywb.123.1676480599747; Wed, 15 Feb 2023 09:03:19 -0800 (PST) MIME-Version: 1.0 References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <348063358f2ded237334b3cec7498a36296fd408.1676351034.git.tamas@tklengyel.com> <06cea9ac-cafd-4437-6e3e-639651a77349@suse.com> In-Reply-To: <06cea9ac-cafd-4437-6e3e-639651a77349@suse.com> From: Tamas K Lengyel Date: Wed, 15 Feb 2023 12:02:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] x86/mem_sharing: Add extra variable to track fork progress To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000009ef51905f4c00ef8" --0000000000009ef51905f4c00ef8 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 6:03 AM Jan Beulich wrote: > > On 14.02.2023 06:07, Tamas K Lengyel wrote: > > When VM forking is initiated a VM is not supposed to try to perform mem_sharing > > yet as the fork process hasn't completed all required steps. However, the vCPU > > bring-up paths trigger guest memory accesses that can lead to such premature > > sharing ops. However, the gating check to see whether a VM is a fork is set > > already (ie. the domain has a parent). > > I find this confusing, and I had to read the patch to understand what's > meant. Since there are a total of three VMs involved here (the one > driving the fork, the one being forked, and the new clone), "a VM" is > insufficient. The sentence further reads as if that VM is performing > sharing operations on itself, which according to my understanding is > impossible. > > Furthermore "the vCPU bringup paths" is also not specific enough imo. > The forked VM as well as the new clone are both paused if I'm not > mistaken, so neither can be in the process of bringing up any vCPU-s. > I assume you refer to bring_up_vcpus(), but I'm afraid I view this > function as misnamed. vCPU-s are being _created_ there, not brought up. > Furthermore there are no guest memory accesses from underneath > bring_up_vcpus(), so with those accesses you may be referring to > copy_settings() instead? Which in turn - I'm sorry for my ignorance - > raises the question why (implicit) hypervisor side accesses to guest > memory might trigger sharing: So far I was working from the assumption > that it's only control tool requests which do. Otoh you talk of > "sharing ops", which suggests it may indeed be requests coming from > the control tool. Yet that's also what invoked the request to fork, > so shouldn't it coordinate with itself and avoid issuing sharing ops > prematurely? I went back to double-check and here is the memory access during vcpu_create: (XEN) Xen call trace: (XEN) [] R mem_sharing.c#mem_sharing_gfn_alloc+0x5c/0x5e (XEN) [] F mem_sharing.c#add_to_physmap+0x175/0x233 (XEN) [] F mem_sharing_fork_page+0x4ee/0x51e (XEN) [] F p2m_get_gfn_type_access+0x119/0x1a7 (XEN) [] F hap.c#hap_update_paging_modes+0xbe/0x2ee (XEN) [] F vmx_create_vmcs+0x981/0xb71 (XEN) [] F vmx.c#vmx_vcpu_initialise+0x64/0x1a0 (XEN) [] F hvm_vcpu_initialise+0x97/0x19e (XEN) [] F arch_vcpu_create+0xf3/0x1db (XEN) [] F vcpu_create+0x211/0x35d (XEN) [] F mem_sharing_memop+0x16a9/0x1869 (XEN) [] F subarch_memory_op+0x298/0x2c4 (XEN) [] F arch_memory_op+0xa9f/0xaa4 (XEN) [] F do_memory_op+0x2150/0x2297 (XEN) [] F pv_do_multicall_call+0x22c/0x4c7 (XEN) [] F arch_do_multicall_call+0x23/0x2c (XEN) [] F do_multicall+0xd3/0x417 (XEN) [] F pv_hypercall+0xea/0x3a0 (XEN) [] F lstar_enter+0x122/0x130 Any time any page is requested in a fork that's not present it gets populated from the parent (if the parent has it). What I was worried about is nominate_page being called on the fork but I was mistaken, it was called on the parent before add_to_physmap is called on the fork - which is fine and the expected behavior. We can drop this patch, sorry for the noise. Tamas --0000000000009ef51905f4c00ef8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 15, 2023 at 6:03 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 14.02.2023 06:07, Tamas K Lengyel wrote:
> > When VM f= orking is initiated a VM is not supposed to try to perform mem_sharing
&= gt; > yet as the fork process hasn't completed all required steps. H= owever, the vCPU
> > bring-up paths trigger guest memory accesses = that can lead to such premature
> > sharing ops. However, the gati= ng check to see whether a VM is a fork is set
> > already (ie. the= domain has a parent).
>
> I find this confusing, and I had to = read the patch to understand what's
> meant. Since there are a to= tal of three VMs involved here (the one
> driving the fork, the one b= eing forked, and the new clone), "a VM" is
> insufficient. = The sentence further reads as if that VM is performing
> sharing oper= ations on itself, which according to my understanding is
> impossible= .
>
> Furthermore "the vCPU bringup paths" is also no= t specific enough imo.
> The forked VM as well as the new clone are b= oth paused if I'm not
> mistaken, so neither can be in the proces= s of bringing up any vCPU-s.
> I assume you refer to bring_up_vcpus()= , but I'm afraid I view this
> function as misnamed. vCPU-s are b= eing _created_ there, not brought up.
> Furthermore there are no gues= t memory accesses from underneath
> bring_up_vcpus(), so with those a= ccesses you may be referring to
> copy_settings() instead? Which in t= urn - I'm sorry for my ignorance -
> raises the question why (imp= licit) hypervisor side accesses to guest
> memory might trigger shari= ng: So far I was working from the assumption
> that it's only con= trol tool requests which do. Otoh you talk of
> "sharing ops&quo= t;, which suggests it may indeed be requests coming from
> the contro= l tool. Yet that's also what invoked the request to fork,
> so sh= ouldn't it coordinate with itself and avoid issuing sharing ops
> prematurely?

I went back to double-check and= here is the memory access during vcpu_create:

(XE= N) Xen call trace:
(XEN) =C2=A0 =C2=A0[<ffff82d0402ebf38>] R mem_s= haring.c#mem_sharing_gfn_alloc+0x5c/0x5e
(XEN) =C2=A0 =C2=A0[<ffff82d= 0402ecb12>] F mem_sharing.c#add_to_physmap+0x175/0x233
(XEN) =C2=A0 = =C2=A0[<ffff82d0402ee81d>] F mem_sharing_fork_page+0x4ee/0x51e
(XE= N) =C2=A0 =C2=A0[<ffff82d0402f244f>] F p2m_get_gfn_type_access+0x119/= 0x1a7
(XEN) =C2=A0 =C2=A0[<ffff82d0402e67ef>] F hap.c#hap_update_p= aging_modes+0xbe/0x2ee
(XEN) =C2=A0 =C2=A0[<ffff82d0402942a0>] F v= mx_create_vmcs+0x981/0xb71
(XEN) =C2=A0 =C2=A0[<ffff82d040298884>]= F vmx.c#vmx_vcpu_initialise+0x64/0x1a0
(XEN) =C2=A0 =C2=A0[<ffff82d0= 402acc59>] F hvm_vcpu_initialise+0x97/0x19e
(XEN) =C2=A0 =C2=A0[<f= fff82d0403168db>] F arch_vcpu_create+0xf3/0x1db
(XEN) =C2=A0 =C2=A0[&= lt;ffff82d040206c69>] F vcpu_create+0x211/0x35d
(XEN) =C2=A0 =C2=A0[&= lt;ffff82d0402f00b7>] F mem_sharing_memop+0x16a9/0x1869
(XEN) =C2=A0 = =C2=A0[<ffff82d0403317c5>] F subarch_memory_op+0x298/0x2c4
(XEN) = =C2=A0 =C2=A0[<ffff82d04032ca26>] F arch_memory_op+0xa9f/0xaa4
(XE= N) =C2=A0 =C2=A0[<ffff82d040221e66>] F do_memory_op+0x2150/0x2297
= (XEN) =C2=A0 =C2=A0[<ffff82d04030bcfb>] F pv_do_multicall_call+0x22c/= 0x4c7
(XEN) =C2=A0 =C2=A0[<ffff82d040319727>] F arch_do_multicall_= call+0x23/0x2c
(XEN) =C2=A0 =C2=A0[<ffff82d04022231f>] F do_multic= all+0xd3/0x417
(XEN) =C2=A0 =C2=A0[<ffff82d04030c0e4>] F pv_hyperc= all+0xea/0x3a0
(XEN) =C2=A0 =C2=A0[<ffff82d040201292>] F lstar_ent= er+0x122/0x130

Any time any page is requested in a= fork that's not present it gets populated from the parent (if the pare= nt has it). What I was worried about is nominate_page being called on the f= ork but I was mistaken, it was called on the parent before add_to_physmap i= s called on the fork - which is fine and the expected behavior.

We can drop this patch, sorry for the noise.
Tamas
--0000000000009ef51905f4c00ef8-- From xen-devel-bounces@lists.xenproject.org Wed Feb 15 17:08:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 17:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496156.766742 (Exim 4.92) (envelope-from ) id 1pSLGV-0002y7-AA; Wed, 15 Feb 2023 17:08:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496156.766742; Wed, 15 Feb 2023 17:08:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLGV-0002y0-7e; Wed, 15 Feb 2023 17:08:19 +0000 Received: by outflank-mailman (input) for mailman id 496156; Wed, 15 Feb 2023 17:08:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLGT-0002xu-RS for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 17:08:17 +0000 Received: from MTA-08-3.privateemail.com (mta-08-3.privateemail.com [198.54.127.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55e72334-ad53-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 18:08:16 +0100 (CET) Received: from mta-08.privateemail.com (localhost [127.0.0.1]) by mta-08.privateemail.com (Postfix) with ESMTP id 7108818000A1; Wed, 15 Feb 2023 12:08:14 -0500 (EST) Received: from localhost.localdomain (c-73-126-95-14.hsd1.ma.comcast.net [73.126.95.14]) by mta-08.privateemail.com (Postfix) with ESMTPA id 041A918000A0; Wed, 15 Feb 2023 12:08:06 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55e72334-ad53-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1676480894; bh=w68mtRdRllSdCaMn2vsvCBnT6Q4zJSnE9BFgcS4DrkY=; h=From:To:Cc:Subject:Date:From; b=lYfHmOk+bF1+8+b/5OEVqlCveopUzDzCDj4WdrwgpHxg11wLRMRYZSkNMxUBMm/DR ha1Cq6ucFTcUDi/pPDqnl3ueSjYIbonuPLqju0pqRxmJTENX/NCEenJlSWQ38d24E8 OfeomqOU6/tg/Nrt1EOiiXmTEb8IGkwyTbMya4UI9JTC/zSSH81i1PyCwGk7kXJij1 vKOzrJwQrIHtthcXLFkmqCLutOqAh+Al4Rc8lTe8hBiVjuBEMsqe4qGvjJHG/AvQSH khJlwkHVzRj6csFsbVfIM62CRNENApEA13XZn+iVv8IfvJZ4/iMLCRzgbALWgxhCdL rM1dDL79SkZSw== From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown Date: Wed, 15 Feb 2023 12:07:58 -0500 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP An assert failure has been observed in p2m_teardown when performing vm forking and then destroying the forked VM (p2m-basic.c:173). The assert checks whether the domain's shared pages counter is 0. According to the patch that originally added the assert (7bedbbb5c31) the p2m_teardown should only happen after mem_sharing already relinquished all shared pages. In this patch we flip the order in which relinquish ops are called to avoid tripping the assert. Signed-off-by: Tamas K Lengyel Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively") --- v2: comsetic fixes --- xen/arch/x86/domain.c | 56 ++++++++++++++++++++++--------------------- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index db3ebf062d..a42f03e8e5 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2289,9 +2289,9 @@ int domain_relinquish_resources(struct domain *d) enum { PROG_iommu_pagetables = 1, + PROG_shared, PROG_paging, PROG_vcpu_pagetables, - PROG_shared, PROG_xen, PROG_l4, PROG_l3, @@ -2310,6 +2310,34 @@ int domain_relinquish_resources(struct domain *d) if ( ret ) return ret; +#ifdef CONFIG_MEM_SHARING + PROGRESS(shared): + + if ( is_hvm_domain(d) ) + { + /* + * If the domain has shared pages, relinquish them allowing + * for preemption. + */ + ret = relinquish_shared_pages(d); + if ( ret ) + return ret; + + /* + * If the domain is forked, decrement the parent's pause count + * and release the domain. + */ + if ( mem_sharing_is_fork(d) ) + { + struct domain *parent = d->parent; + + d->parent = NULL; + domain_unpause(parent); + put_domain(parent); + } + } +#endif + PROGRESS(paging): /* Tear down paging-assistance stuff. */ @@ -2350,32 +2378,6 @@ int domain_relinquish_resources(struct domain *d) d->arch.auto_unmask = 0; } -#ifdef CONFIG_MEM_SHARING - PROGRESS(shared): - - if ( is_hvm_domain(d) ) - { - /* If the domain has shared pages, relinquish them allowing - * for preemption. */ - ret = relinquish_shared_pages(d); - if ( ret ) - return ret; - - /* - * If the domain is forked, decrement the parent's pause count - * and release the domain. - */ - if ( mem_sharing_is_fork(d) ) - { - struct domain *parent = d->parent; - - d->parent = NULL; - domain_unpause(parent); - put_domain(parent); - } - } -#endif - spin_lock(&d->page_alloc_lock); page_list_splice(&d->arch.relmem_list, &d->page_list); INIT_PAGE_LIST_HEAD(&d->arch.relmem_list); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 17:34:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 17:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496163.766753 (Exim 4.92) (envelope-from ) id 1pSLfJ-00077U-Aj; Wed, 15 Feb 2023 17:33:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496163.766753; Wed, 15 Feb 2023 17:33:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfJ-00077N-8F; Wed, 15 Feb 2023 17:33:57 +0000 Received: by outflank-mailman (input) for mailman id 496163; Wed, 15 Feb 2023 17:33:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfH-00077H-Hu for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 17:33:55 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea99a9b2-ad56-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 18:33:53 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id a2so19957749wrd.6 for ; Wed, 15 Feb 2023 09:33:53 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id c5-20020a5d4cc5000000b002c558869934sm8186388wrt.81.2023.02.15.09.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 09:33:52 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5E55E1FFB7; Wed, 15 Feb 2023 17:33:52 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea99a9b2-ad56-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=DcVGeHtYBRBwgzlnj8UOcf+La3RPbj1Pw6zmXVeuBcc=; b=TY7dQXLP+3LKCNRuwKAhQmsMNW6yqGfShnlxc5kciH5j7CHP+SAxHky6xXlncBZX8n BSRTzK10dxcoqsQWFT6WpcC4ts45JbA73YMYClqbr8qB8vQM4QPLTySoSrxejp0q3EhB OzQYrzzV8cm6EH9EIpXR4FgnxdfxrSN+XZs5wybmiFW4XepspjZZU46ghYGMF5Sc7jQ0 mFA/6gX52831D1p1t/G9uRZPGG8OyXYpv2TKYP6skVcjNd523BUCP9XAZgLNOqMnmvKq +va/iwCGtw5knvxrKiOY7JqgDep8sgKDqLp2xpItOUb7WFnF3Ad/zBZ7m2uDFP30urqx 4txQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DcVGeHtYBRBwgzlnj8UOcf+La3RPbj1Pw6zmXVeuBcc=; b=Hc+3GiHUGtuBFuSsKWYP73F+zkWtVQIPBlw/BWC/tdXNu7dOd5ed02zrCZVEp9FBwx 9xlAjHmtd4tvXFfX8TSNBe0/xJNvpDPfLnyyBn6qWBu9A3WcJc5AQIf+pAdBZ5ivnB2A rk9mITGg4xEgxnYdNUSm/ZCOX0XUPTKn+w/pO/P9AdSAoq7u+qJZm+iRhZvSxSbYCYZY ouVwP08RUtJdbiKtYD6GwpBDMRGckk1R0T3K0RGkyOP7yCbDAjuh/f1dNIc3Sr5metrk aw4X8nqmKgbZ3lZxJhvmn29ZKEZAf5f7iOPi+cfNFkZXBxi8K1LO7nRG7DuAuo8Z6cYA REOA== X-Gm-Message-State: AO0yUKWhVIyRwjBk0INEUccfj5pZoLEs++aXtJtT2CxS8LyvcMeYX2id jzJGVVqXM1zE3198hLJYBbx2cQ== X-Google-Smtp-Source: AK7set+YVSC2ETEfLUAdM7ZmVXyP2J/zSok3OF7fsnYAGSVBSonf4LmvlhvvVw86fx22TDcCI9+cNA== X-Received: by 2002:adf:ee92:0:b0:2c3:ed68:5600 with SMTP id b18-20020adfee92000000b002c3ed685600mr2446540wro.38.1676482433071; Wed, 15 Feb 2023 09:33:53 -0800 (PST) References: <20230215153451.30626-1-philmd@linaro.org> User-agent: mu4e 1.9.20; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Anthony Perard , Paul Durrant , Stefano Stabellini , xen-devel@lists.xenproject.org, qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH] accel/xen: Remove dead code Date: Wed, 15 Feb 2023 17:33:48 +0000 In-reply-to: <20230215153451.30626-1-philmd@linaro.org> Message-ID: <87sff696kf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Philippe Mathieu-Daud=C3=A9 writes: > Unused since introduction in commit 04b0de0ee8 > ("xen: factor out common functions"). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Wed Feb 15 17:34:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 17:34:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496165.766765 (Exim 4.92) (envelope-from ) id 1pSLfb-0007Pj-LA; Wed, 15 Feb 2023 17:34:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496165.766765; Wed, 15 Feb 2023 17:34:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfb-0007Pa-Fo; Wed, 15 Feb 2023 17:34:15 +0000 Received: by outflank-mailman (input) for mailman id 496165; Wed, 15 Feb 2023 17:34:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfa-0007PJ-WE; Wed, 15 Feb 2023 17:34:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfa-0000VK-To; Wed, 15 Feb 2023 17:34:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLfa-0007Pr-Ng; Wed, 15 Feb 2023 17:34:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSLfa-0003vA-N9; Wed, 15 Feb 2023 17:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AkQ+HwXrikur2pSgxTbo8lFITWOiNczEskMsYROGyLI=; b=NLxkGdDspM0Iy0LWeo6hXKYO8e k7eOP7hwydgdUPcWVkaRgpe0+8IY6mzM+z3bHZRS1oqr78PRd2FDD+WW3RKfAgiEXDR8LPSMvYxgi Bzut/zBuM/FSKr4+//hIEtvjzFueEiDRS/CeCOgVGyYsmwRj3d+gt2UBDBR8cdWBsqtM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177402: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 X-Osstest-Versions-That: xen=63305e5392ec2d17b85e7996a97462744425db80 From: osstest service owner Date: Wed, 15 Feb 2023 17:34:14 +0000 flight 177402 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177402/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 baseline version: xen 63305e5392ec2d17b85e7996a97462744425db80 Last test of basis 177305 2023-02-14 19:03:50 Z 0 days Testing same since 177402 2023-02-15 16:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marek Marczykowski-Górecki Ross Lagerwall jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 63305e5392..5b9bb91abb 5b9bb91abba7c983def3b4bef71ab08ad360a242 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Feb 15 17:42:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 17:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496176.766776 (Exim 4.92) (envelope-from ) id 1pSLnI-00010f-D9; Wed, 15 Feb 2023 17:42:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496176.766776; Wed, 15 Feb 2023 17:42:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLnI-00010Y-AC; Wed, 15 Feb 2023 17:42:12 +0000 Received: by outflank-mailman (input) for mailman id 496176; Wed, 15 Feb 2023 17:42:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSLnH-00010S-Cq for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 17:42:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 117fbb23-ad58-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 18:42:10 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 117fbb23-ad58-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676482929; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tddX/P7bh4gBa81Pab3djQYtgs+vkML5E48bQMNIgo4=; b=KPRhHgPwJKxvZEUXF12ZYcZuQ6jJXjWu3fSVGt9A1MdNdwDlrYdrttT2 I2DOkb9hc+S9i91jvLoLWmpGyL5+B5ZepRe5mZ4zpA4C6wfpexKOaOf5b vFxbcZrn+SC7ToMCN1o32I7JGdHwhzeqDg+1dvh1iuP32Lre1o1rzEDUD w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97189269 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:d2v3LaomwkzNuZiy9vW2D4zfMTteBmLfZRIvgKrLsJaIsI4StFCzt garIBmPOv3eN2Shf9wlYI+08E0OvJTVmNFhT1A++yBjHn8U95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADBTLQyJqvuu/LC+Q/Npj/o/MdLSEIxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jOZpjSoWE9LXDCZ4QGn8y2Mu8TUpnviU70JV6ed9b1b3VLGkwT/DzVJDADm8JFVkHWWWd1FL FcP0jEztqV0/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQNU+udU/XzACy l6DlNSvDjtq2JWXQ3+A8rafrRupJDMYa2QFYEcsUg8t89Tl5oYpgXryos1LSfDvyIevQHepn m7M9XJl71kOsSIV/6XlvkzNriu0mprMRxQw7zvLQ3mcwgwsMeZJeLeUwVTc6P9BKqOQQV+Ao GUIlqCi0QweMX2evHfTGbtQRdlF897AaWSB2gA3Q/HN4hz3oxaekZZsDCaSzauDGuINYnfXb UDaomu9D7cDbSLxPcebj29cYvnGLJQM9/y/DZg4jfIUOPCdkTNrGgk0PSZ8OEiz+HXAaYllZ f+mnT+EVB7285hPwjusXPs62rQ23C04zm67bcmlkEr8gOvAPi/PGe1t3L6yggYRtvvsTOL9q Ys3Cid3408HDL2Wjtf/r+b/0mzm3VBkXMur+qS7h8aIIxZ8GXFJNhMi6epJRmCRpIwMzr2g1 ijkCidlJK/X2SWvxfOiNioyN9sCnP9X8RoGAMDbFQzwgClzPNb/vft3mlleVeBPydGPBMVcF 5EtE/hsyNwWItgb01zxtaXAkbE= IronPort-HdrOrdr: A9a23:HuCMBaE4JoEA+vtGpLqE0seALOsnbusQ8zAXPhZKOHtom6uj5q OTdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bHYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIObuEZoTJB/KTHCKjTKadE/OW6 X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="97189269" Date: Wed, 15 Feb 2023 17:41:57 +0000 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , Wei Liu , "Juergen Gross" , Subject: Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Message-ID: References: <20230215152111.51218-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Feb 15, 2023 at 04:30:43PM +0100, Jan Beulich wrote: > On 15.02.2023 16:21, Anthony PERARD wrote: > > @@ -13,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile) > > endif > > MINOR ?= 0 > > > > +ifeq ($(origin version-script), undefined) > > +version-script := libxen$(LIBNAME).map.tmp > > +endif > > Such a use of $(origin ...) is pretty fragile. Maybe better use ?= ? I'm not sure why I used $(origin), I've written that more than 6 month ago, but this way of using it is actually described in the manual, when documenting ?= but with a = instead of := . So, maybe I wanted to have ?= but with immediate evaluation rather than deferred. Maybe I had issue with $(version-script) evaluating to different values. If that ok, I'd like to keep using these runes, since ?:= doesn't exist. > > @@ -72,6 +77,10 @@ headers.lst: FORCE > > @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp > > @$(call move-if-changed,$@.tmp,$@) > > > > +libxen$(LIBNAME).map.tmp: FORCE > > + echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp > > + $(call move-if-changed,.$@.tmp,$@) > > Isn't this going to get in the way of your "build everything from root" > effort, where $@ will include a path? Also do we really need .tmp.tmp > files? Good call, I'll replace that with $(@D)/.$(@F), that will be one less thing to deal with, Also, I guess just adding a dot to the filename would be enough, and we would have `mv .libxen.map.tmp libxen.map.tmp`, and no more .tmp.tmp files. > > lib$(LIB_FILE_NAME).a: $(OBJS-y) > > Seeing this right adjacent in context - any reason you use libxen$(LIBNAME) > and not the same lib$(LIB_FILE_NAME) for the base file name? That was the name used before, I guess it would be fine to rename. I just need to set $(version-script) later as $(LIB_FILE_NAME) would not be defined yet. > > @@ -120,7 +129,7 @@ TAGS: > > clean:: > > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) > > - rm -f headers.chk headers.lst > > + rm -f headers.chk headers.lst libxen*.map.tmp > > If I hadn't checked, I'd have assumed that *.tmp are removed without > being named explicitly. So yes, I see the need for the addition, but then > I wonder why you don't also remove the .*.tmp.tmp file, which may be left > around if the build is interrupted at exactly the "right" time. I forgot because $(move-if-changed) remove the temporary file. I'll clean the .*.tmp file. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Feb 15 18:00:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 18:00:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496182.766786 (Exim 4.92) (envelope-from ) id 1pSM4G-0002v0-RR; Wed, 15 Feb 2023 17:59:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496182.766786; Wed, 15 Feb 2023 17:59:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSM4G-0002ut-Or; Wed, 15 Feb 2023 17:59:44 +0000 Received: by outflank-mailman (input) for mailman id 496182; Wed, 15 Feb 2023 17:59:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSM4F-0002un-Mm for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 17:59:43 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86188aa2-ad5a-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 18:59:42 +0100 (CET) Received: by mail-wm1-x32e.google.com with SMTP id g6-20020a05600c310600b003e1f6dff952so2226305wmo.1 for ; Wed, 15 Feb 2023 09:59:42 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id c2-20020a05600c0a4200b003e1fb31fc2bsm3092426wmq.37.2023.02.15.09.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 09:59:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86188aa2-ad5a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kmhmw5XlwFTAKn7AkFVbDPLUolEeedjqlaORqi0uobg=; b=JErikuozksjKxYv9SmnZVbaJEJfO6UdsKS9PvA2Qu/sHHBiyaJByMnx3sAS5vNgWOL jisQdUwpD424QfbXmHzIHmqJNW5WX1YW1IJwk15iPj8yf7SnIYa2PJu2b5qeEqd7Ia4C qo2cGkkv0DDHUYEfvrshYjbY/QUA6SDRHhvg2GHOZwyh52g0hKSHs69wIwb4OZa6gglv ieOIOL48he7tE4iCledbQgOHMZ5K9/8wHH0aGPKJgwJqpuIfEF57uyRjX188rCB/4DCo CwWdQKXJ9qVxOcnS1f0y7qvAnPRehoEM0MPJGDjq9sOkSVrSARQdPgqxHgsX20PwcJfo 4fyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kmhmw5XlwFTAKn7AkFVbDPLUolEeedjqlaORqi0uobg=; b=3j9JR0I01DN3uGSpcXundGlhl8Obv3mvUJDkTJyhJ8WE44wFgqNIwGuzriBkNtQTf2 96d2zZMSEDtaLYBY34gaTf/YHtgM3TazpTqz2WejHY0II3rAVUG9W5cnhhWf7MFO7kf7 +/W2DtsdtiyY76ac22yPOlvUv0oGlaBNT8ffR2dqs0a4tbRXCv3JHPnp1LDwV4xdLf0w wmo71/sXSfwIwT0MzdyXXm3Ytj/HB7jn6Bk4zkNxlO2VvyV2bruO/wbWpATWiXr1eSid t92+SveivqWV9zBTegHRglIYl0xDPROldDUfK8XF9u3+G6VP1okcNt8mUwfcVT08tfZx XPUA== X-Gm-Message-State: AO0yUKUke+yIumoTRs8bR4HMSuMJwn+r0ou36kcQNB9oE64jsOhkX69J M1SpNUkAeqMg2dzh82hm+Uk= X-Google-Smtp-Source: AK7set/eWDqxEb62UHhSlvzJhCCkGiiJjFR+lBHb7nOKFGr30DovgFcPgtaRZgQyIXYoWMVJ9kSMTw== X-Received: by 2002:a05:600c:708:b0:3df:eecc:de2b with SMTP id i8-20020a05600c070800b003dfeeccde2bmr3311889wmn.11.1676483982217; Wed, 15 Feb 2023 09:59:42 -0800 (PST) Message-ID: <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Wed, 15 Feb 2023 19:59:40 +0200 In-Reply-To: <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hello Jan and community, I experimented and switched RISC-V to x86 implementation. All that I changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. Other things are the same as for x86. For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT will look like: #define _ASM_BUGFRAME_TEXT(second_frame) \ ".Lbug%=3D: ebreak\n" =20 ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" ".p2align 2\n" ".Lfrm%=3D:\n" ".long (.Lbug%=3D - .Lfrm%=3D) + %[bf_line_hi]\n" ".long (%[bf_ptr] - .Lfrm%=3D) + %[bf_line_lo]\n" ".if " #second_frame "\n" ".long 0, %[bf_msg] - .Lfrm%=3D\n" ".endif\n" ".popsection\n" The only thing I am worried about is: #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ [bf_type] "i" (type), ... because as I understand it can be an issue with 'i' modifier in case of PIE. I am not sure that Xen enables PIE somewhere but still... If it is not an issue then we can use x86 implementation as a generic one. Could you please share your thoughts about that? ~ Oleksii From xen-devel-bounces@lists.xenproject.org Wed Feb 15 18:08:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 18:08:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496188.766798 (Exim 4.92) (envelope-from ) id 1pSMCQ-0004k1-Mq; Wed, 15 Feb 2023 18:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496188.766798; Wed, 15 Feb 2023 18:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMCQ-0004ju-K4; Wed, 15 Feb 2023 18:08:10 +0000 Received: by outflank-mailman (input) for mailman id 496188; Wed, 15 Feb 2023 18:08:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMCP-0004jo-3s for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 18:08:09 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2bc2235-ad5b-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 19:08:07 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id bt8so18286598edb.12 for ; Wed, 15 Feb 2023 10:08:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2bc2235-ad5b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rfo9n75pz9SXUCjFvDYPZtqowRHklY7r4BP2Nl6nvF4=; b=QodiedvxfbKgwcnV+lCSYQLjL9wl+OkUgr1Pvx6Ag5wWrvHhpwIa193IymTz0G9jLA oK8E7ygD2HIpujqJo/+dLGpE93ZjWs7R8T5UvDx45aOsT2pdmB9aMi9CtMxEEZ3myNq5 Tl3vY+LNFjd6ltBTbLjdlvqb8lPN0gi1p67jFS87UfGoThM23c4JvSYwORaNHkIfnwuR kmHjIRUf90NuknaiB1CBNEBOAm1cshW0SRq5ip9nR50CRxirIGdGOUfTvsnHj71C/8rx 5fVDiPYbSI6tvxYRFs7WIlhAafZ0Om4lhAZpxwaJwnzIdmFjhCT8FfrVhMX3ts5WMefp dMLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rfo9n75pz9SXUCjFvDYPZtqowRHklY7r4BP2Nl6nvF4=; b=NssB5hsnyNfHe88yMMqfMENgRmr8mLpK7dCaWVhHF8lPCpi5/lsSxxKmEHT2/ExG+Z Pb3dFvNYiqIg/ScSGDT4gNI8OsgmqRB+JLo0NIb603EjJ/H9ouuYenSH307OCjR39wyh n/Dz0BUGiTPol58UpKuYheo1gmsoUR7LW6YLLw732FmSUqKzbfFbNWdAz3t1Yz+ch3BT fVE49z8ww5/AZ4UedqQXnzkKk+N4tLMvPvJfVtZ2Le0AwergKCC8Q2RRLbNgJP0GzPzf /zQSI0sJRgtnNhXzlqfFzJeh0IiW4N0W6RXrU+UL5XyLUyQ3IHsdpb8tx8nTVHGoXooU chGA== X-Gm-Message-State: AO0yUKWSKR2c0L8WGm8fF+GOQPQvhG52Vm9uz+MHLmGKBwiKbDWX8QxW y5rJIg8ChmyVHtsDwZrfyFFoPxGgnMH32w7uM1NA5iLiuFE= X-Google-Smtp-Source: AK7set8dYhSa0KghXhYcoO0WDY9BKyhyHVZQzSpdC0QKKpaoRiPUzzgo4BtIu6rbFf47E/kSg0k5VOjN9QriD4Rjt4k= X-Received: by 2002:a50:d717:0:b0:4ac:b6bc:87b7 with SMTP id t23-20020a50d717000000b004acb6bc87b7mr1630183edi.1.1676484486655; Wed, 15 Feb 2023 10:08:06 -0800 (PST) MIME-Version: 1.0 References: <2981ceec-030f-12cb-4b86-b7fc1bc928fd@suse.com> In-Reply-To: <2981ceec-030f-12cb-4b86-b7fc1bc928fd@suse.com> From: Jason Andryuk Date: Wed, 15 Feb 2023 13:07:54 -0500 Message-ID: Subject: Re: HWP and ACPI workarounds To: Jan Beulich Cc: xen-devel Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 4:50 AM Jan Beulich wrote: > > On 14.02.2023 20:04, Jason Andryuk wrote: > > Qubes recently incorporated my HWP patches, but there was a report of > > a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking > > up during boot when HWP is enabled. A user found a kernel bug that > > seems to be the same issue: > > https://bugzilla.kernel.org/show_bug.cgi?id=110941. > > > > That bug was fixed by Linux commit a21211672c9a ("ACPI / processor: > > Request native thermal interrupt handling via _OSC"). The commit > > message has a good summary of the issue and is included at the end of > > this message. The tl;dr is SMM crashes when it receives thermal > > interrupts, so Linux calls the ACPI _OSC method to take over interrupt > > handling. > > > > Today, Linux calls the _OSC method when boot_cpu_has(X86_FEATURE_HWP), > > but that is not exposed to the PV Dom0. As a test, the Qubes user was > > able to boot with the check expanded to `boot_cpu_has(X86_FEATURE_HWP) > > || xen_initial_domain()`. > > > > We need some way for Xen to indicate the presence and/or use of HWP to > > Dom0, and Dom0 needs to use that to call _OSC. > > > > My first idea is that Dom0 could query Xen's cpufreq driver. However, > > Xen exposes the cpufreq driver through the unstable sysctl ops, and > > using an unstable hypercall seems wrong for the kernel. > > > > Can we add something to an existing hypercall - maybe platform_op? Or > > do we need a new stable hypercall? > > > > Linux will perform the _OSC calls unilaterally upon seeing FEATURE_HWP > > and independent of actually using HWP via the intel_pstate driver. > > However, not using HWP may be an untested configuration in practice. > > The intel_pstate.c driver will not use HWP when FEATURE_HWP_EPP is not > > found. So we could potentially cheat and expose only HWP to Dom0. > > That should trigger the _OSC calls without letting Dom0 think it can > > use HWP. This is rather fragile though, so a more explicity method > > seems better. > > I agree with the "fragile" aspect, but I'd also like to point out that > no matter what features we expose in CPUID the driver should never try > to take control when running under Xen (or perhaps more generally when > running virtualized). The intel_pstate driver doesn't have any check for running virtualized. > > Roger's ACPI Processor patches that add xen_sanitize_pdc calls could > > be leveraged. On the Xen side, arch_acpi_set_pdc_bits() could be > > extended to set bit 12, which would then be passed to the evaluate > > _PDC call. _PDC is the older interface superseded by _OSC, but they > > can be wrappers around the same implementation. But if linux is just > > using _OSC, it seems more compatible to follow that implementation. > > Using the _PDC bit would look quite reasonable to me. Yet what's > unclear to me is whether by the last sentence you actually mean to > indicate that you're not in favor of doing so (in which case more work > in Xen would likely be needed to actually support enough of _OSC). I was trying to make a statement about mimicking others' behaviour. I haven't tested using _PDC vs. _OSC. The Intel ACPI Processor guidance defines the bits the same for the two methods, so either should work. It was more of a concern that while it "should" work, we don't know if we'll hit corner cases. Since Linux is running fine calling _OSC for this purpose, we know it's been tested. Having dom0 use _PDC is untested. I mention _PDC and _OSC being wrappers around the same implementation, but that isn't necessarily true. The Intel ACPI Processor guidance defines the bits the same way for the two methods, so it should work. But, again, it's untested. In the ACPI Processor thread, Rafael J. Wysocki wrote: "Sorry for joining late, but first off _PDC has been deprecated since ACPI 3.0 (2004) and it is not even present in ACPI 6.5 any more." Maybe _PDC is hanging around because operating systems are still using it. But that was another point making me question using _PDC. > What you don't touch at all is how you mean to surface the LVT based > interrupt to Dom0; the cited commit messages looks to describe uses > beyond the HWP driver, and it uses that as part of the justification > to override the firmware choice. The LAPIC is hidden (PV) or properly > disconnected from the physical one (PVH), plus Xen's MCE code (however > broken it may be) makes use of it. Or is the plan to ignore all of > that (at least for now) and limit things to the HWP driver's needs? I didn't intend to surface any interrupts, and I explicitly disable the HWP interrupt in the Xen driver. It is used by the processor to indicate when certain values like the guaranteed performance change, which isn't something I wanted to support. But the thermal interrupt is something else, and I haven't figured out how enabling HWP triggered whatever HWP or thermal interrupt which caused the original issue. I'll look at this stuff some more. After I sent my message, I was wondering about how Linux commit a21211672c9a adds code to clear the HWP status on thermal interrupt via an MSR write, which wouldn't work from dom0. But if those interrupts aren't making their way to dom0, that is fine and we can just have Xen handle it. Thanks for sharing your input. -Jason From xen-devel-bounces@lists.xenproject.org Wed Feb 15 18:16:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 18:16:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496195.766808 (Exim 4.92) (envelope-from ) id 1pSMJk-0006Zn-Kn; Wed, 15 Feb 2023 18:15:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496195.766808; Wed, 15 Feb 2023 18:15:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMJk-0006Zg-I1; Wed, 15 Feb 2023 18:15:44 +0000 Received: by outflank-mailman (input) for mailman id 496195; Wed, 15 Feb 2023 18:15:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMJi-0006Za-Pg for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 18:15:42 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c04313cc-ad5c-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 19:15:40 +0100 (CET) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 13:15:28 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6805.namprd03.prod.outlook.com (2603:10b6:303:164::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 18:15:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 18:15:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c04313cc-ad5c-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676484940; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=fcG3+MKF4j2xX8JhDiHsakixBb+dxaEZQhf/v6T3iek=; b=VeTThIM7mjYrr8xZm0zhMAH2hT1jQmZAivZC3eHlK9CVIzpzAYa6KZGW 3EEGFJvbEKWUr+VKJhZ2MldaRmR+Fp58FGdsjhAYJuWc5EACaEXCcwgEb HJpX9ffTNzAUXqrfq6WPGytwGzqkjDJbA6KNOCSsL4fd+dLjwLfj542fc 8=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 96025853 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:m+ebVK0sFauqzItCM/bD5Rtwkn2cJEfYwER7XKvMYLTBsI5bpzYBz TQcDG2BaamJZWr1ftEgaIWxphlX75fQzNIwSQc/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnOKgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfW2MSr tUhbxw3XzOqpMSpyeywUrVWmZF2RCXrFNt3VnBI6xj8VK9jareaBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6Kk1EZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKlANhPRODjnhJsqACS4U4dUicQaXGyvt6drWr9WtEHI lNBr0LCqoB3riRHVOLVVhukoHmCr1gEVsBZCeES5wSEy66S6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTi7IyQSIEcJbDUISgZD6N7myKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx74j/luYO3qS/uFvA2jSlo8GQShZvv1qKGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM= IronPort-HdrOrdr: A9a23:1voBh6p5CuRxSH2/t3Ig/WoaV5o6eYIsimQD101hICG9E/bo9P xG+c5xvyMc5wx9ZJheo6HjBEDtex/hHP1OgbX5X43NYOCOggLBEGgI1+rfKlPbdBEW/9QtsJ tdTw== X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="96025853" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OhYLawFfGyGkzHCman9Q8hxPzBhIHMQnKgZmMsBeRiDtnslmQFrd8RIXZdDbT5o+mmBN7knu7SH9iclTHgBCYkJ7/JEXpdAxoYZ/ejQHR3m0dzbRXeKvxMLXAQGBSHtYP7ZZ5CbIzqApqCXAEdnJ1aAvhDyGq9Fp9yGLMIskKETX7R0Tfj3Hz1sd4l/MjlwxTMNVyTqzc9WBYWRgVsxi0mxXj/3mTUQuX9gOU58QXy1BKWQuqmkPpMXEvafnWoDJecG7Lv0zgJk0lzv+gW25mjs828hk8uzsuvjgVh2XKNGdoF37tC4TjiDNVBWcRe1XSsbnvvAOZXdiaY1YOgQL4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SGml/FRtRXc79ISGXpgod5+2YxpDDwinJNAZJ/N96xw=; b=mgQa2EmKOB0CCWetA/nokzi+aWrDIkO51v1BveziyFSTsqPcBa3zf4FXm9bMeTzfWIJotUNkIs8inDIzkYcQwIJ5Wju95kiWI8cextSu4h5ZNYXPNHpw+p2V3AjkVHIKdLihyjNsgN7E+Q12G5O+pN30RmAeqEy25G2Aam6KlgjWFgsShPMo+3BgmpLJsRrbkxqfqCtz7DYPvdono+UA7sUhhMnfWS/P3zraEXPsGDl5SO8Va/pqVqDk0UI8s9oKsufQaGili1Yrx4Mmu2TpIr/w3NJRmWHuF8n/X6QR5CoLbVlu2UVgIPtSloc634PheAQImklHxRtHj5huym+kOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SGml/FRtRXc79ISGXpgod5+2YxpDDwinJNAZJ/N96xw=; b=IQYx9iooY7GhrfMQpjwaTGVyO5mP7zkB3Sc1cUbq8WMLPiYx8dMhdQnzFal1MXF2FjDS3OibXE1Mhs7DUlxYDXNuMgOuxtMSKyAegchftmLOePOdRS+CKDKaKkD47bramnD7f0fdUS2gn1qQgYfySyB2zc8dG+DAG+hqUDKriWE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1e8ec592-4a5b-4c74-5a0b-dbf3ea60b084@citrix.com> Date: Wed, 15 Feb 2023 18:15:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container Content-Language: en-GB From: Andrew Cooper To: anthony.perard@gmail.com Cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-2-anthony.perard@citrix.com> <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> <6c455c45-18d3-584e-bc8a-a1d22a68fcd3@citrix.com> In-Reply-To: <6c455c45-18d3-584e-bc8a-a1d22a68fcd3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0014.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO3PR03MB6805:EE_ X-MS-Office365-Filtering-Correlation-Id: e9dfc96d-c2a7-493d-bf44-08db0f809c5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ElFqkxVmbZlgstKQc9M0/CH3sGgUMMsmWSX2eTKROTWN6Y+wF0P+FOHqPCWewE+xrfzM84hvmec83IwKQCv9JBkF634SKUr8cwhM7EpVWZSH2j47L72P6AIC1zqMrg9u55SOFDRbcml+Ik0gaFS52ObMMK9I6sEmpN/GoSklLl6AQ43Xl4TZYsAqwPJCem6ndyVpLJxEeLW+19ekBmNVk3QnpeSmd9bn+KEfXOoqeqRFfFE61SUhBbqiXT2bMAB25KnF/pc0dENiSNg8OPojQcFruiFagEHB8TyuFi+PBouwFUjKInL9ZoYyGLsVPeONZG+q14VuRHZdp9GLc/aSRPNTwP2Qrhf5SFyRMe6vTvOJYpmn2WCFccZ44PHOrVk5ruxcrUGVU0v8H9ZNCrSmAm/0LMUQEib70Tv3KiVJpkWTSMZ1b0Y7udtKIKMTwBgGSpTIj+WsJV50ltaQn2w8QEMoA0x4Y9sNVngieCfzB8BfsOEIQE9UIyx1oLTXzK6bwx/QP1+5WWleJgyYQhwIHra4frFISeHVKjuCzsYEi5qPsPLOvdfYZYa2XjTNb2zrZzNqY2C6aPjBH1EDX9Qx8c9uEJa7pNLosKVXVZYCsZCrmuNbanXss40TTu/4pU5Ra4gdIAzdfEIqPxNuAbjR3JiYoaAYATAK8YBMx5h5hvCddp2KfrQ+abtbsbT+lLS4vuCEjCCj3olxBy2deDVn46cc2Q4qHTHuv9uoWMhuMjY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199018)(8936002)(41300700001)(36756003)(5660300002)(6512007)(26005)(186003)(53546011)(6506007)(966005)(6666004)(6486002)(478600001)(83380400001)(66476007)(66556008)(66946007)(4326008)(6916009)(8676002)(2616005)(54906003)(316002)(86362001)(31696002)(31686004)(38100700002)(2906002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWRHQ0VFdW96TUdRdTd5YnBPN0Y4czF4Y2pUYlNKRWc4cFpTMktQb3hKUGg0?= =?utf-8?B?R1o5cENEYjFnSlpQbEFBdVF5dVNBNS9vc3Z6L0thdTN2NUtzcldDKy9wMEJx?= =?utf-8?B?UlF1ZnZpbElXbTZpZnNua1d3K3F2R2NiSHZFWkpjS0F3cU15S3JicGZad3Jo?= =?utf-8?B?ZWtESEdNU2NadFRBczVnbjhDU2RwRlZzcEZFUDVBSFU0VElWVWxIbUREYk1o?= =?utf-8?B?WEh3RE54c1VjYkdxZVVXb25pR0U3TWViRWNHcm9EdTJiWE1SdzY2aXNURGpa?= =?utf-8?B?Z3p1RzRMYWd5bWhndHYvdGlHNWVVUmd0eTNGOUlwYTByTXpxM0tBdFNtV3pE?= =?utf-8?B?aC9LdXR5NU5ENnFSR1dqK2xIeEJ5eVdja0RRZGcrWkY4Vk4vRFQ0eXFmbVVW?= =?utf-8?B?WnI4SU94ZzJqMUZsMnROKzNnQ2N1bFlMR3FBSUtOTnNDSGlaUmIvc2NKbVVP?= =?utf-8?B?NU9pbllVTmY5MDIwTm84aTFUelZ1cWR2S1ZiT2hieDV5OGFtQ2JiNnNYMHhO?= =?utf-8?B?dGJpSXVFUnVUTkJMK3Yzckc0RTNnaFlQbXpRMDlUMDY0WEhtVDRvVnZ5emY2?= =?utf-8?B?R3Rmbm5SY0prVE1sQ1ZUNFJQWFlpMGhpS3diMDFybFJ4cXBjL1FMOG4xWjN6?= =?utf-8?B?Y2ZHMEFSTUY5eHJKdk1QOWVLRzgrQW42QzQ3ZEJ0NmUrcXc1eVd1a01xa0RP?= =?utf-8?B?enl2TGh2ZnZXZFhHT2N3c0lta0ZSNFYyRkpjZ3lCbGF0ZDR0dFNaRXpJWTEv?= =?utf-8?B?VWQyRnNxYWJ4Tll6RjBya2VlZzlCdGgzUm1Sd3MrckdQTk5LR01vS3MrWThs?= =?utf-8?B?RzI1NXlVcElHaWNIN3o4dzZCZVl5c0pVNENVWjV1RWoyV01JdFVybUMrOXVP?= =?utf-8?B?UHhPdmlyRHoxUmFQSGtFMTI1YVhURWt1R3lrYnA1UlRPV0RRRVA0UFpId3VG?= =?utf-8?B?OE16VDIrTzl4ZTNVNDZKcmlYTnR4bVRTamF4SFdlc0Rodm9mNlVqWVNhdnF1?= =?utf-8?B?UGtWK2cxSENHNW9vOXQzNWJacVU4a0tPVkpwNEdFWHFhc0k1SHlRWG0yVVVr?= =?utf-8?B?YTlxSXdqam12aWR3QU9kN3R0QVlKa2pwOERUb2RXWklTdmFYNmpRMnFOcXoy?= =?utf-8?B?SVFSVGlKTGtjK2dGQ25zSDRxaDl4dWV4YmhIbWpVblAyUDJOaktUa2lhZnNT?= =?utf-8?B?TXdJczdPc3l5eXY5THB1YktLSm5EYkVzcGVRcHJ4UjFvV3R2NGFlamVtdzBy?= =?utf-8?B?dzRYbWhOem4zTk1BQnFVUUMwR085MUs1RlV5a2xkbHFGenJSdTN6V2M5Z1pL?= =?utf-8?B?QWpwTUpWdVZsblN6Y3VtMm9JL29hdTVKeVZVYXRKNFNEeW1JNFNteEZLUm9s?= =?utf-8?B?YXF1Wm5PMmtCM1pWM3dsQVJiVzFDQk9Vb2FWa05ZN2t1ZVFrSS8xbDNuL3k5?= =?utf-8?B?YVhnWENmdy8zWWhKTGtub0U4b0VlMWVySG56Y0I1VzYzeTgzY3dyb1dES0pt?= =?utf-8?B?QUJxNWVwWTFZWmt3cFkyT1RsZ085SVdGeDFKRmxZMktkUmRObWtlWTVFcDJv?= =?utf-8?B?VHlMWWRPRnpISThhbHRlM2R5QU5tazBWdENxVXBlUXVWRS9ZenAxclJ2UnB1?= =?utf-8?B?aGM5Uno2L0MrQzMyK0hCZDhWbkhRWU5yUlZqTnJlWGNlQ3g0QnQzUTN6WVpK?= =?utf-8?B?RDY2Ykd0UVdvSlJ5WnZVQmd3ZzRyVlVsckUxTVNYSERZRmN0YU81VlJHVGlz?= =?utf-8?B?VGE2MnNQaTZ2VkQxejhZcnBpejBQQmRHZlNIUWUrVGgreUZrTmZyQ2p5QytB?= =?utf-8?B?cDB3SXNmOFhYbmRicnpJRjNub0dBWEZmYy9RQ1kvM0FRNnowaWNtTnZqajJY?= =?utf-8?B?R2gyd2k2cElyRmZUSWN6aXdtdXdEVEk4MThHeTc1NC9FUmpDS2ZMVW1qelZU?= =?utf-8?B?b203RzdUM21vL0kvZEV3QWwzVElxU2FER0FiMExKSXdtUzdkbi9ncEkxUTVR?= =?utf-8?B?Szc5M1BsdGtjL2poV0F1QlkyNmVqVTdpR0N4SUNTdU5ibTlOeWxmb3lIMGZ1?= =?utf-8?B?cUZYM3poYllZQkhlUXVnei9RV09WdmtHcGtsSUpaUi9CKzhyUTFmS3Y3WGVF?= =?utf-8?B?d1JYSmQwaG14Ri9rNHRHblFNb2tGckhwTWdyN3d5ZUlPYmRHcHZHS05WYmEv?= =?utf-8?B?c0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5fZ2ORjIiGBePLMwFNkzTJQlnkiDU6bGGzsMGZjsc/DF20kKF3PCdtPoH32SXuBFFXT0COQTrM/IS6gqHaCD9uYR4nHV4rgH+IlSWlNuNLJfvLk3P90OMnPfpsEBEWp3xGbgLu8/VpGsQisZvYoDuwvMypY1sm65sJBaPa5uJ+/He6tB8co4ub7hTUssHTUw1cp++AnWEH9ZsNDeVVPCW9Y7+PddEE+P1S97I7Z0ys9Z6AnBrE96MwzVfQlCba+fIELnDpWuMSBSGIAJutCLxEZ2apk3NiVQ2EtKWiPpygaxHoBCCZn0n0MtbGKdjQfqcQq/2bEPE01CfSM1rEDKjrb69ThyEfeCQkbGYWKB3bMV0OBeZcxvfRX/zWfuJUYsQZ793rNQ2FCHaq3pCOMvzjduD0VzH+sixm8grzfYVWAFSu0GFPjH4Ywpzet0rvCdJ2JpHEc/ADYWYiVgKakbB2SZed7VWJ3d1S5FXLmyAYdXPXPJAdQ5ffZFIlnX8CpgD8jN+eoINdxcxN3+6d0PjHtAs9D5aHXncGGKXwkTe99wjZbEiNdp8NYDOqREA0UHT/rWdWTL4WFQAkb16xj/l8hed5qsavb5TantTw5rg0f1fOi/6mvXs0i5Meik1qUolBRMuPBGb1vLFCD7Ngmdfte3oDYImUJWHA5gVnVkXRAOLQ/zG6eVAdSN0oGAdMmFmL7cImWbU6cTZD57576aBtYXr/+AFM0dzb4ldIgHLWAIhnQNoJ999Qps36Gss3rS0cNmwdiJ02gltPjDNWvmNofX5C911T3JNgybBnOCdBMWPAO185KQg7EeT5oa6J/KmzCvDgvnA4WHBSPGaJ+stbpHwZQlVAMydmJnbhjQXwY= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9dfc96d-c2a7-493d-bf44-08db0f809c5e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 18:15:25.9867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oy0TYI1kpSjpK6ljfqguU9pNkNNK7EDaof6jo+Qhffv+JH9OA2MxfjymCqQM1Oap9zdCKpwwhfeFSbBQjryoDPyMRIONJ+4IUTtJHdjdDe8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6805 On 15/02/2023 4:31 pm, Andrew Cooper wrote: > On 15/02/2023 4:28 pm, Anthony PERARD wrote: >> On Wed, Feb 15, 2023 at 12:26:40PM +0000, Andrew Cooper wrote: >>> On 15/02/2023 12:02 pm, Anthony PERARD wrote: >>>> First, apt complain that it isn't the right way to add keys anymore, >>>> but hopefully that's just a warning. >>>> >>>> Second, we can't install clang-8: >>>> The following packages have unmet dependencies: >>>> clang-8 : Depends: libstdc++-8-dev but it is not installable >>>> Depends: libgcc-8-dev but it is not installable >>>> Depends: libobjc-8-dev but it is not installable >>>> Recommends: llvm-8-dev but it is not going to be installed >>>> Recommends: libomp-8-dev but it is not going to be installed >>>> libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable >>>> E: Unable to correct problems, you have held broken packages. >>>> >>>> clang on Debian unstable is now version 14.0.6. >>>> >>>> Signed-off-by: Anthony PERARD >>> Yeah that's because clang 8 is way obsolete, and http://apt.llvm.org >>> only supports Clang 15 and later now. >>> >>> In hindsight, it was a mistake to take unstable-llvm-8.list in the first >>> place. >>> >>> Acked-by: Andrew Cooper >> I just realize that this change is going to break gitlab testing in the >> staging-4* branches. So I guess this mean that we will have to backport >> this patch, or at least the gitlab-ci part. > I don't think it will.  The currently cached container is still "good" > for the older branches to use, but we ought to backport the change > nevertheless. > > Given that the container is un(re)buildable anyway, we're not losing > anything, I don't think. Ah, so.  Applying just this patch won't break older trees. But applying this patch, and patch 3, then rebuilding the the debian unstable container will break older branches, because there will no longer be anything called clang-8 in the container. This demonstrates even more that referencing the compiler by exact version is a mistake.  As is using names like unstable. As I said up front when we added CI of this form, we were always going to retrofit some changes to all branches (including the security-only branches) to keep this working.  These chicken are coming back to roost. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 18:42:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 18:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496204.766820 (Exim 4.92) (envelope-from ) id 1pSMiw-0002Kt-Ox; Wed, 15 Feb 2023 18:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496204.766820; Wed, 15 Feb 2023 18:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMiw-0002Km-Lz; Wed, 15 Feb 2023 18:41:46 +0000 Received: by outflank-mailman (input) for mailman id 496204; Wed, 15 Feb 2023 18:41:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMiv-0002Kg-W5 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 18:41:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 634dd7cf-ad60-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 19:41:43 +0100 (CET) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 13:41:32 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5102.namprd03.prod.outlook.com (2603:10b6:208:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 18:41:30 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 18:41:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 634dd7cf-ad60-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676486503; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ol7eyFD/X4Fs+YOyqexcyQcOWhxJtNPY0mfFmbprnyI=; b=DWDZoTtsfLh7+BsR1+1YZuzJhhfRxR+x1zQDu6Yo9LXhnyUFC1LduSB+ NRixyBUvJB2XK1Bes8QsOOWkJaAcvwT/t00idYC+ObNh12C7VULmu8I5F kJqQEbs/Q184iqtyehKK2dTfKHa/xdcsPvWu3VPM92c5Tz9Kc+bHl9DLo M=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 96577186 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A3Nru6nDZRuSKNqsejSwFWPo5gyjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIeW26PPamOZTP8ctEjO4Wz9EkBsJODnIQwSlc6qno2EiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QKGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aAiATMwaEGevP2Nh7amb7k3oJ17cfC+aevzulk4pd3YJdAPZMmbBo/suppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1Q3ieC2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDSuDnqac63jV/wEQ4OSA7TV+EpcKYqUmnCpVQN FQF6gkx+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqWMMfZQ4M4t2mqodsiBvKF45nCPTs1oazHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:IzUTra3ZjOEutGF1712cBAqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="96577186" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUHRIqsUWaRrQQB7kn/VVrbFWxQS3X5Lh2eH2agAH+YlCMVCefNjwINNZM8HUIm+PQJnEo4YC6n0eKrYXr5cBQjY17talTULa0SRTebYTdJoqiqT+F9KpUDqhvc5fEDsQGfUQbS45HeWmNfg0NlqEX5FkkCdmrVZUswXSOgegb7aYWUvYcpP0PiB3heTtDdtauF6EOufRjq/06RwQF1zUC9zQEce4PKpKHL+vA3EbCgs0/V7+E3XEYWnhlWgutBIjXVjfjOMfEF4rDrsTYHmyVv9ZTvd6g5duGGypYjIrdYI8z9ET4sVDrhlQteR53GwA7lqKS8og4mK5RyT9Mx0Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lykSCFFb1jWk2L6ZixKPdzXlFh/amYP04xaYscp0+T4=; b=oZ+50zMa45iA2PCMuS4O1B/8Bip4ya4m/6XiV2+lldW4guByj0xc8Qpwju4SmwXgSBAhaGYhTzsa2Ql0y3QH8nbu7RrjLeOKaMQdxEivxeTVhkK9tW1pj4NxzXjNeIPzjMjI2AaSZwnkBT7joUJIJbJBpWJUy4hl3jS0nfkbqX0B8svN4K59GoofyHRA/G5JlI34BIFGAb1AICKkRalpqiU0Xel2t4EJ/fmiixF9DPjawj0NQGJjmeiwETJvELdmW4c+UUOZXjP8acuQt1eePHSxIJlksgsAzqKWIDiScLUOrFkYMKkm5HE+U3AriHj7+POr81gtMDBXewMDQ07LNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lykSCFFb1jWk2L6ZixKPdzXlFh/amYP04xaYscp0+T4=; b=aFWW4G2RyRh9tOp663X+oZYDMJbhMjvqIsoSF89OqwmVI4G2cZkTbkox8AFCD3xpNlKpda6ytZnrRoLOmF+UBfSUnzbCzfl0Swyzln82uszEpSjAW+tUnL01JaXu9cWsbw0ssWNcfMTBMsKDGKyndza1eKgHD2LBrl9ibmsqSSc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7c38a1dd-3ac7-f7f3-4a7e-a231f55e8f48@citrix.com> Date: Wed, 15 Feb 2023 18:41:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0302.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5102:EE_ X-MS-Office365-Filtering-Correlation-Id: fdcd2c6f-bfbc-4d20-4ac9-08db0f84410a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sjwo072QLgrYEzzlluLxFMDDo4RjztclBecnKAA9hDFgFlP1nSToTEz4Y+Sj8MQJfaJmZUdvN7uW68bEheHeUZZtQv7ivmIKss6+eNS3yNFDSH/5lhKob/IqrDkBPQY3/Y2hWw8d1hustcFzE9eVnpa/n4AOqw+X2uizImwhGcKMibyjsxnW5VLYhb9Tex3DAFYD3UvcdIYQhVKIlY9FGxdYBBWEYD7GuVn2NNeL5cJDKu+4QNFfW7omMW40A7P6J/QLy596nsOJYOvQ4lMhJT23XIVku3p0yJrGY3epmiLWhUvTxU70feYEQoEiNnxkoJCu03jpueKM81CkGOM51ON4nQ3P6RxBB6n44A5GECUGHIKDSRtN+EIHfBxY/kEapcH7JrDFIGMPfzJiFkO+5/gJlSHVykqD5CTGHd8mYESWb4r+doxkQtPPFGzfyJnfOYaCSJaNzaaO2VTLOCzUY67lJIpbFYC2TScqQ1bcZo7dsi3o20J+vCmcmLliN7wZMOqlYTUWWvcDhDD9T6Liyr9TzejCG0i+C85enFcd5HNKPda5QrGMGK9mu57+K1g/6912sSV3PYkGMO4y1R3Ogl6fcmFQJbM7ehrnnOO9IflmQmmsTmokpo3pmcdUCNi2uxPy47Dk1qIQesovj5yMfG7aDephFRgvNA86Sct/XbQV5VHqd+srg8VkIvfCNXY3plwYmGbtvHEisCN8RBEvDco/YawNdiWtBgMnWDZVPa4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(376002)(366004)(346002)(136003)(451199018)(478600001)(6666004)(2906002)(107886003)(53546011)(6512007)(6506007)(26005)(186003)(31686004)(82960400001)(2616005)(38100700002)(6486002)(36756003)(31696002)(86362001)(316002)(8936002)(5660300002)(54906003)(110136005)(66476007)(83380400001)(66556008)(41300700001)(66946007)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elRHbnhJQVZkVks2eWllR0tOajV2UllnZHVHVHdTNzJIZXhaZGYvanRHQk0z?= =?utf-8?B?dFpNeTlwY25IS09mWGpHK09jWGVlYi8zTHhqamlLYjVDQ0dXallpSlVFUE04?= =?utf-8?B?MWZleFR5TkxxL3IyeWZZM0QzWUtjNm5Xbm1CdEZyYlRkTW9vSTZHUXVMWElN?= =?utf-8?B?dzYzMVJvSGdsUFZMcS9jM1o3ZGh5WXNWQWpJY1dscm50Vmx2djdZWUYyaXRw?= =?utf-8?B?cnhDSDRiNmNIeThMcm9kby9UQnFZcGM5UVJ1ZXphMDJtWUoySHZVVkxoMUUy?= =?utf-8?B?UThEZkhDekFVT2RSMlA5R2tDV2xzbDNSYVdsMUtZbTNieGVCK28rcDBZcXMv?= =?utf-8?B?OFFwRnMveG42SWxCajdMMDh1bWJNcnAvUWZJL09JZldueFVQaWpjWUZ1ZCtY?= =?utf-8?B?VENENUVQVTl3em10SENDNXdDemRCMHdDbkxvdG92WlBtUTNmNWRLeXdTQVZM?= =?utf-8?B?RCt5S0hOREVTMmtha2lweXcrdnBQV05uaDYyMUJRbVRNdisrN3d4N1FXbWdi?= =?utf-8?B?RTg3Z0hnK2w2bnRlakx3QnRrekIrTlo1RVRiUStUeXY3a0ZtMkxXeUNST1Qv?= =?utf-8?B?amJvNUtnVTN3bHRSbkNoc1l5RjBXQlphTHBveUVTUkJ1T1JKcTVUY25IU29N?= =?utf-8?B?Q1BCOHA4d1ZQRW5Bekh1QTVxcFZDOGdhZDZOTWUzbWF4bEY1bnZFRXA5aVdz?= =?utf-8?B?NkNDUVdUOFFMY09PVGN1RktpWklpYUdnNVUwc1lPM2JvVVBMR2lNdzY5ZXpx?= =?utf-8?B?bEc0M2hTWjcxcFV6WTRKZTVVNHk3UXdIRCtNcE1veVRnMzZ3QWU3MjlJdVA1?= =?utf-8?B?YzFvRkcwVThiczlnK1VyU2FnN3oyS1BpUVFlRE5vRy9FU0FHQkNxUzlnWDB5?= =?utf-8?B?Y2xnQWdFVUpDR1pESGxpZUhNS0ZNSmN2ckJGM1NEMFd0bGVKSk9rdEhwU1kx?= =?utf-8?B?N3V6anJrMXppdi9sQ0U1YTdnRlNuWVVOVVZhRmhTY1h1KzFsZitDR3FQZldr?= =?utf-8?B?OElJWVZ3NzNIMjJBMVBhWENRKzRSeHl6NkxTa0FjYVVmQkVpd082TkhLMGxX?= =?utf-8?B?QlpodkRuenhkUjQ3SFZrVE5sVFI5K05zVzBLRkNQdGdTSm9oM3pVaDMrVVpE?= =?utf-8?B?eHVMWURHZHRWM083aWlPbW83MnRXL0lhQ2xxZUwrQ0JNVFFPMlErNjduQ2VU?= =?utf-8?B?bHkvUThGRytUL0JlRFhCT2dEckY2RlJCbVkwNGJoWlFmeU1CQUNXOUE1Y2NI?= =?utf-8?B?WCtWdmFNaVdVa3VXeUJqeGh5SlVYQlRFOWlOVllCQkR0Nm1HZ3VMWEwwNkxl?= =?utf-8?B?bzI5Z1FvdHd2eURocmZuSCtkN2tzeHB3TTFSV2ZqR0Y4SHpNM2dobW10SXVz?= =?utf-8?B?ZlhIRXA1NUlJZmF0QjNNbElJNXZZcXphbS9YejNhUGVKNEhhMm91V3RTcWh3?= =?utf-8?B?RGMvdUhIT2hzZ01RdWc4S1Z4bWRHNHJvK3hoTGN4WGtjTFBoTExyV1ZQcWhw?= =?utf-8?B?YUEwZXZsS1VGSjROYVdzbTgya3lKaXdFYTZGYlJrbmo1UlJjNXNaU3NuaVo1?= =?utf-8?B?ZnNVc3hBOTJCb0pDMGZhR24wSWtHY002YW1wK2N5S1RDOG1kL3BGb2wrNTJN?= =?utf-8?B?aFFYalExTU9CbGUwdi9mcDhENDZNbU9NN1gwWTZGOHhTMkxLWm1rRHdxaWxr?= =?utf-8?B?MEVMb1h6bEZHNTh6OEFWQy9LcjdrOWpJUnZpMHJVd25NU0hzWUV1ZGp2YU1i?= =?utf-8?B?bG9nTWVnUHBlbm1haUt0Nk5PbS85UFp3eVRUQ3NBWGNYWkN6eDlhWnk3UWIy?= =?utf-8?B?eGJ0RW5GaXVTU3Ixa2VnOW8yd2dOWWlDN0Q0aTdkQlhpL3RBMnJibjliWEtO?= =?utf-8?B?cEthYVB0YVplNVl0ZzVmYmVVUE1MVG05TkpvVVZqRzUvYWFFWGtBMDFJR21y?= =?utf-8?B?VVM0WHRZelZaNmwxM3ZBN2c1NmIzeFJzNkh1R0JCd2lMWlJLOUI3VXJNUTA3?= =?utf-8?B?d1kwZjFjdW83cFVrTFg3WWNJUEI1QlZObTFUZU5vMjFySlJNQlFXODB0c3Ns?= =?utf-8?B?QjI1eURqRzZjZTZSNW9iQlRGTWphMDdibkJMNmJxMmhWV2RrSjFPeUhFcTh6?= =?utf-8?B?bDg3TFJrV1R0UkwrUHFUZlQyYVltaWxORG1wSE44M05SdllQa1B6R29UaVBJ?= =?utf-8?B?bkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: V14UYorAi/OkFY6usS8DdH7nDlbTUvkEjb7X0zUAmtVNzDkSONyuupCHyfFWtwDAbzkFh3n4JZvYdh+aXIDWBqS9wHltSG73nuwGTX/YNfTebDhmnZcN+c367szMK59HzvU0yqlQZBMc06IYG9Nza5YaZvGFPzECmzyaV15wIQAdrtXEdZI9dehnoRj8J38WHU23MuVib9z4+gT5GNJzVqDbGXYg6NbDRHshUAjG0CU7zeF0R9xzdRHd3w69h1b2v/IgWm+248fzO3nSzz9OctZ6mmLY/OJmu52H2SlXdAnf2tkyHzN0jW4BkwaJgFfJ3kEcoqE+X0U/DgXC3QP1iH61M+O1vVOnD0bxkMJDgRiQvHj4B1uFpcOlHmjUVIIihNweq7f8VaiobcmRlfeW5uagxovmwFZ4MEo+eygPmZrIFrpTVsQcCT3NKih8PuIVeLne8cUWYQQK+84puVIXBnljNm+JAOK91uYsGM7iz/amEbCW6enraKoSk5vjVp2aazHsowtYKFUXxYj2oftst+taE6tdvQTm5TsOsyG1KfY6/mkgTp+CvEGAUanhRrTwlQH+Ftz8O+gcc3YBCpcofrCDypNnjZQ2YvVFox7I8FgXkaaecBAOl++dax06jUTz0h2hFXPqhMvSiaC3bALSIYc/j3lR77qpRGI3VAh3kKDrnWhC/NJNOFVpzpw1yKvTcvjCLnM3rIcYYhB0Z2gafXvstpdMhbAPp3+J1Im7mIbdP+lQokRbaZk36dSoNSx6ZMqjjRgsd58lZ46JxA67dTkA/VbMdhmmbZvZ9TYTi9PFDl1d18LTYQe/SFadE9E2 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdcd2c6f-bfbc-4d20-4ac9-08db0f84410a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 18:41:30.7318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QrsQGBaKeEWo/ELT2BsN0UD+/QXCBvTfqHJ5DG6T60Hv09t7zI4touvJLPpxS7MN/lMHsCLpAxc1PoR2U9wIG7457KYcqRTpnV/TjGn1NkI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5102 On 15/02/2023 3:10 pm, Jan Beulich wrote: > Besides a printk() the main effect is slight corruption of the start > info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended > up as xen-3.0-x86_64p. > > Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") > Signed-off-by: Jan Beulich > --- > RFC: While Linux works fine with the adjustment, I'm not entirely > certain of external tools (kexec?) having grown a dependency. Again, I wonder why you think regular kexec has any anything to do with this? Are you mixing it up with (legacy) pvgrub which does end up doing a kexec inside the context of a PV guest?  If so, it's MiniOS's support you need to care about, and I cant see any logic that even inspects the start_info->magic[] (either in MiniOS itself, or the pvgrub patches). Like plenty of other fields in the undocumented PV ABI, it's not interesting at all to software.  There's nothing I can see in it that you don't know at compile time. > It > may be worth noting that XenoLinux and its forward ports never had > this ELF note in 64-bit kernels, so in principle it may be > reasonable to expect that no such dependency exists anywhere. NetBSD sets PAE_MODE for 32bit and 64bit but, like everything else, doesn't appear to inspect start_info->magic[]. xen-3.0-x86_64p is obviously bogus.  I find it far more likely that noone has ever noticed this bug, than anyone gaining a dependency on it. Insert usual rant about the PV ABI being entirely undocumented... ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 18:55:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 18:55:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496210.766831 (Exim 4.92) (envelope-from ) id 1pSMvX-00048n-TM; Wed, 15 Feb 2023 18:54:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496210.766831; Wed, 15 Feb 2023 18:54:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMvX-00048g-QL; Wed, 15 Feb 2023 18:54:47 +0000 Received: by outflank-mailman (input) for mailman id 496210; Wed, 15 Feb 2023 18:54:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSMvW-00048a-Ka for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 18:54:46 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35343f4d-ad62-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 19:54:44 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 13:54:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5633.namprd03.prod.outlook.com (2603:10b6:208:292::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 18:54:37 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 18:54:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35343f4d-ad62-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676487284; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=XhA+FWabA9LtS20hnqX6OA9FcC9yOgKyCbXRh/vos0w=; b=ML/gjhiaMrITpUJnWWoeZfN8hdidSdXPiubOyFV7/+yikAQ3PCkxL9ws 0VHZs2Lr4vvB23qEApWOenns+iAgZ8+VVHuv7k9AUFKBNPYK/xCmTkt2e Ca1uqdV80KhDerxcs3JB995WUR6qeCZQXRSLRVME3WvkDkSgNkAkEKnOU c=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 97198435 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ExyTzaLqFeBsx/T+FE+Ri5UlxSXFcZb7ZxGr2PjKsXjdYENS0DdUx mYYCjuCbK6KN2HxLt51Pong8UMFsZXTm9ZgHgBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVjPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5vACZD5 +IzDwotbyu8rfya0pb8asZz05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHyiCdJOT+DQGvhCnWCB3HAsDxEvXFqqn9P6jB75VfN5J BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdBjXY0 z2M6i8kiN07h8MRy7+y+1yBhju2v4XIVSY8/ACRVWWghitzY4SvdoGz6VzW6P9GBImcR1iF+ nMDnqC25eQPFo2ElTbLTv8EGrqo/N6aPDaaillqd7Eq8DKr/HyvdJ5R+xlxIU5oNoAPfjqBS EPLogZQ+J97NWOnd7NqeJm2D9k2zK/mDpLuUfW8RsJHf5xZZAKBuiZ0aiatM3vFlUEtleQzP MmdeMP1V3ICU/04lHyxWvsX1qItymYm32TPSJvnzhOhl72DeHqSTrRDO1yLBgwk0J65TMzu2 443H6O3J993C4USvgG/HVYvEG03 IronPort-HdrOrdr: A9a23:qYWPCKnpQlkgoGTL7wkx2iktTSDpDfPjiWdD5ihNYBxZY6Wkfp +V7ZEmPE7P+VQssS8b6LO90fG7MADhHZ4c2/hrAV7QZniVhILIFvAj0WKG+UyFJ8SQzJ8j6U 4NSdkGNDS0NykLsS+Y2nj6Lz9D+qj4zEnAv463pB0BIW4FCsEQiHYeNu/YKDwGeOAsP+tCKH Po3Ls6m9PWQwVrUi3UPAh8Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzSIwxsEVDtL4LE6tU zIiRbw6KmPu+yyjka07R6X071m3P/ajvdTDs2FjcYYbh3qlwaTfYxkH5GSoTwvp+mryVAy1P 3BuQ0pMchf427YOku1vRzu8Q/91ytG0Q6h9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfFf9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmcca+a hVfYfhDcRtAAunhkPizzJSKRuXLy4O9yK9MxE/UwquomVrdT5CvhclLYck7wI9HdoGOu15Dq L/Q/tVvYALd9QRa61lAucHXI+YNkzhKCi8bl66EBDfD6cANGvKq5nrpJMPxM/vVqAp4fIJ6c X8uGkzjx9gR6srM7zf4LRbth/KW2mzRjLr14VX4IV4oKT1QP7xPTSEU01GqbrunxyxOLySZx +fAuMaPxbYFxqjJa9ZmwnlH5VCI3gXV8MY/t49RlKVu8rObonnrPbSfvrfLKfkVW9MYBK/Pl ITGDzoYMlQ5EGiXXH1xBDXRnP2Y0T6uZZ9CrLT8eQfwJUEcodMrg8Wg1Kk4dzjE0wNjoUmOE 9lZL/3mKKyome7uW7O8mVyIxJYSl1Y5b3xOkk67zPi83mEOorrl+/vMFy6hkH3USOXZ/mmZj Jimw== X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="97198435" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a2WDlKWFZDbM4O2ZeMGhurJ44FiTWRL/Fc4vUnX7jEODs7RAe5Hm33Zya1+6UvBLQjh4HmHmrMoyEm3Q8cOrR7WipXADK1Br+e+WfYRuKySm+YS5VSq6KjJ6aTIhr4YhPc+PmwczmcZm4cz/73xy1ER2AG2QWZnHVpSgdi1oND5zIWbOQJ0wXRcZGvJ9UdIPxEpLne7d90d4eOsEoknOpdAFCA5tZ+IH3Ds7syLqT7nXnkVWSqyA39qlQRi4Lz7wzcxtelQqpyaVfOqK0I5JGo7EOZmF3FhhVNUlqi4aXNlC5Wn9Ofo9bUW+bN6LHGpHjMosZDKxKqqDbZbsgNZpUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhA+FWabA9LtS20hnqX6OA9FcC9yOgKyCbXRh/vos0w=; b=TIB+VUkI2hqahYnFNktcSqER9pBGCloHJ04Thifkxs7jGZJYxQO5w57tvZIdfhYYetAmqGGD1HanTq1VWYABHhb3xY4OOpzjhzbSgv5cLjGgbKvEwTVNH/8/2Jz3q2qC88qUeOGU+sJ7Z+WhjIjxh+y7id9z9pJ1cq8OugtrjJ6fwV3UWFT4Xxf4BcQ1Rp+dtKQT58Ak4+8o6I4FnI7Ykq5YUZeUk0w76ewDu3cTajrMqAFeTyf19hTzHwznwmb+EhkyImJAmbfSokpfXDqKTbxTmjHLeUeDlR2ulJ4R/w46i6MjM+eV56BUjxRmIOtB4OmJADjuqekk0w3GR24BQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhA+FWabA9LtS20hnqX6OA9FcC9yOgKyCbXRh/vos0w=; b=kKwAAVYJiKCMSzYSsEbgr/kpyTaFmr/pqAdfLJhsIIkY2nH354h2UQOIxGi03aseccN5T62MrctLqqOrrof7iP6q2C2LjTE5NsYxGdc+fT3+BGXNVB3LIaIvstSgcbVsBfRt390wGsx6heTp7YRRKmNtmudmwVssR896vg0XPcY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7532fcc4-1e0f-7db6-9538-6dd3fc209521@citrix.com> Date: Wed, 15 Feb 2023 18:54:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 2/6] common: move standard C fixed width type declarations to common header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> In-Reply-To: <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0242.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5633:EE_ X-MS-Office365-Filtering-Correlation-Id: d93d1c7d-3244-4eb2-59f6-08db0f861552 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UlcBz7+MkHIXN1CJ7MH9tLDfYQlrAA0mtcWAIpmcls65NZCklILZtzGkrIlZBj55eMdu8qAW9yexvWnTCvoivDo+NSK6qzAu1qXW9Xn3B5Kpa11sqOLhFFawopPCReF3EgZj09T//Eg02Q7JZlC03OxXhGHN7nyctlkc1xTsxmI+XbQRPgl0g56vPEYAycP8mT0NpdH8rI6yObLSrUdbr+8ymvaxh6scECR9DknvdZAYWz4kNAwIyqf1dq9dN4bNdkBERRCNc90KdXWzwHrKiWKK5ycfwHQxgggfffyWYwRrbr05apkfYpL3D5gIU7tJdajcJksX207ZVnz6cyDwAt9x2nakbbGgtlmS2bLOQiprYn4+XGsL6wZvVfS8+EayeK4R049273w8jmlPXwAgGizuRKFrmNVcyvGuN5QjY3Ifo/lp5EOU244ZZ+NOKoTJ/Px1vgkGetdclYRJCwP/pPGd2Opi3ndiNBLXieH+2sSGoxhserLiH4cwFwCBZO/ClxVpTeuQ2juFBv+UxcRfKUMHqiisridm+oQ5nM54d4xOP6n1BKlr9nusou2VlNfrH/Iq1gDvSGjpJGN52lHV91XT6p1lxULKaAH2n4ekDP6QKI5xueXy9XZGycyPNLOOkTRGKn6Y1JVmnJUCXk6fhbshvHAmjqgFo1EdeCDykNlVMsHO5lXwHVQEpy8E00hHjtyKyAoddWD0KgFCPV8RAueJwS288UEn5rzMOApzu6I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(66476007)(66556008)(66946007)(4326008)(8676002)(110136005)(8936002)(54906003)(5660300002)(31686004)(316002)(41300700001)(7416002)(2906002)(6486002)(478600001)(6506007)(186003)(6512007)(2616005)(26005)(53546011)(36756003)(6666004)(38100700002)(86362001)(31696002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TERSQmk5KzQyUDBSQWRYejJSbHBsVmhDSDVtT0VGZGUydFBxSHM3akNLZStr?= =?utf-8?B?WkNDRU9yeXdQYVdSMjBDdkp1SUV5WXVUSlhHdFFyaFdzWjc4ZnNZd1ppZTBI?= =?utf-8?B?eFRpWmttemxRdHluSFBpV3k3YTQ3VTdoZ1JuYWRxaStCVGtzWDJGd2hCTHd2?= =?utf-8?B?TEt0eXdXdWVBYi9Ecmg3NE5QcVIxWmlPQm5URFgxSjA3T1Z0SlorWXRWbHdN?= =?utf-8?B?TmZxWmZIK3R4bzJULzE1K1NrN1QwR1BqajdlN1pjS3UxOHVhemRpb2lZVGtl?= =?utf-8?B?Tm84NkZWeGNqL0orMHRQd2gxdmUvT3ozd2xka085ZjBPc1ZDUnpuMmxoQ3Ay?= =?utf-8?B?RndIYWMxMEY4M0xBL0xlVDJpOTVHaFRhMlFHWWEvengxSWlLSzdZblFmYmd6?= =?utf-8?B?N2szbnlyQjVUWm9rRDdQTURjdTVNdTVCdk5TU3hsS3o2QklSRjY2VVpFNHRQ?= =?utf-8?B?d2U1NVAyMVcxL0hKMENUdVduTlRTSDJxNk1LR21QclhObTNNMjRqWkpOVFF4?= =?utf-8?B?NU83d3F2bThxaTF1WHNYaDhVc3B4ZDM2TU1ZaVlHT1BOZTRHQ2hqZjltamEw?= =?utf-8?B?QkNBK3V6QnE1QUJEWkFxYmhQbDA3bmR2T3VLckxkd3MraWdSRE56OTJoM0g1?= =?utf-8?B?a3lTL0VIZDFGQTRCUTdXZ1FqUVBZdDhFRHhZSEFtUHZ1VmhqMEh3WkJLcmI4?= =?utf-8?B?N016aldCdlNKT25wNmxMZWovYVJXa0ZhaFRQL3JsV2ZLL012U3ZPZTNIbGp0?= =?utf-8?B?V3A0QkxSMVJhdFBsYklCQjBwOVpHQmJDRlFEZTVjSGZUb0ZrMnluWXhKUlZ0?= =?utf-8?B?NjB4K040YmhGOTlXZHVPR0ZYbXNZM0VyK2I0SWNVa2FianhlTmh5V3lyZDQr?= =?utf-8?B?enlYZEtGY1hYQ3JFMjc3QUxjMlpCeUxIZ3IwcFFTOXovN3IzQ1VsNDA0N2xD?= =?utf-8?B?RDlwR2U3S2tQMnFqM0cxRDVXaGNtZUdhV05jU3ZiNko5elp0SWRkRlBJSjht?= =?utf-8?B?TmhhWklDSEw1eDVXWUNpNlRGMWU5bDBGbURSZUN0bmJySUk2eE5DU0E4aVd6?= =?utf-8?B?MFhOS3pZU1JIdHpHemZ0RkJwajZxUkN3aDBTSDR3cUl0MnZWNkVzY1RCMXZ1?= =?utf-8?B?ZVdvbGtLNDNGQmt4d243NU51VndFWWVtckNET2VWUFJ1VW8xUjk1WENXZHRO?= =?utf-8?B?dWFsVFo4b1ZBS2xVZGltTnVZWGVveFBOVDh5dDZMWTg4TllxTlB6TWxsUUxY?= =?utf-8?B?K0MvT3htS1Y5dFp1MEdrRGRrR2k4cGEyWU15QjgyUUN3aWZxQndCTlpuc2NT?= =?utf-8?B?anJLOEZWMlg3TU1QeHlDdS9rREk2cmZSZzZyd1ZjN2pZRG1HSGE1czFrUWps?= =?utf-8?B?clhKSy9xcmFWdHVjVUQzM0NaQTNJVVlkMTNoTG1RMGRZK25qZ0p3SEliTG14?= =?utf-8?B?cUJGQTZyUjI2TlFIek1jNjRyUmt1elNVczR0UDM3Y2lHbXBwTDlReVd5V0Fx?= =?utf-8?B?M1R6V1A0algrWlZ2ZkZVWVVoMi96QVVEZ0RoWjh1aWY2bmM0cFdQaUZXdEhP?= =?utf-8?B?eUk0Rm8vZEhkempkL0I0VnlDWmRNVWkvWUdNT3dvVllaWm5mMXluYTRpMkNQ?= =?utf-8?B?MXNwckpoRzNDOHdNQUt6SkVpRmxyNG9nSVA2SW5jNUI2Q3pqL1JQS0h2NVN5?= =?utf-8?B?UnZKSkZ2Rjk1MHV5U2VhRVhhSHFURS9Fb0J5RWZ6cHBLZ2p5RzZqdUQ4SFVo?= =?utf-8?B?L2QwL1lTYjRMY05MM0xnRkdyOHNmOW5aUkFQTHQ5N3lkZnpUdmtnZXJ1QzRI?= =?utf-8?B?WEJhNzRVRk1DZ0JoNjIveEc1WVVTSnlDMUJDL0dQTWFhaitTa0RKUVo5Q0py?= =?utf-8?B?L3BVamx3cTNZZXF5ZmFtOE5PZlROZ1lXOHJhZkhPNkVpMzZPa0ZtWThJSW9v?= =?utf-8?B?L2c2U282UysyY3ZuRmpiZ2JkY3lpZzIzSENlU1dNVE12d2M0MUVNSXhXNldP?= =?utf-8?B?MTh1dnhhc2dQN2t0ZEo0bVVtanhpYUFTMkFXbmdBOW0ySjNZWjBrb2E5Y3Bn?= =?utf-8?B?eXNlVE1TUUp4L29QdDhmQzZCWWo3ODBzQUdDN1k0RXVRT2c3cWtDaHlCTThn?= =?utf-8?B?VWRMd0VTdWV4WThzL1dpZGJZTXJqY1dKTGxMQ3RWWEU5OGt6TE5sb0owRTNo?= =?utf-8?B?bnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YkpDRUV3YUhadXVhTUcrOWtuWUh1UkxzRFNxREZuVUswRGxhajVrd01uZVVw?= =?utf-8?B?YlhhWkxTYzNaR0RydHZiZTBhSVYwajVCQmQzL2hsN052ZXYwY1BzV2tnejR0?= =?utf-8?B?T2dVcXdJZ1F5VTlCTzhFS0g0YjVFa3FWS2k5WkgzUld1Y0FUNlp2RmM1dEkw?= =?utf-8?B?YldvbHlRdFdmLzhjOFBoRkdzL05xNElHU3YzWWU3S0tub1YraWNDdTNudGpI?= =?utf-8?B?MTdsekhVR3FCSm81cTZEMXlTL2N6dHJjV2M1Qy9KYWszSmd6aUZFRmRmWXlK?= =?utf-8?B?b2kyQXVxUE0vQUd0VGoxaFEzd3JvQzZ5bDZ4MlFKQWtmamJraFhIYXBjemtC?= =?utf-8?B?VUpycTkrdXNRQUp4SE9JeTFlTERBb2piT0dWZ3hoV2d1S3YrdldLOVBFZ3pJ?= =?utf-8?B?Z3BmTnFzeG12VnF2SHdTemtXa2lHaUk5UE9SQ2ZERUgvVGMybWx6RDlmZnhH?= =?utf-8?B?T1pJS0xwNENQUDJOVlZBQ3cxTjBRd1laWk1PSmZNWDJ0SGtCNnR3RDltVlhi?= =?utf-8?B?UDErTGNNNWZBdnNpeVlwMWpNNUgvTHpzdFV4ZHp6d3A4Y3YwOUhDclpYT0sz?= =?utf-8?B?YkROLzNiOHNWSWl0LzQ0U3pBTVU0ZEVXQThWeGREL2Jib1kyWWtvSG11UUNO?= =?utf-8?B?NU9EaEtBcWYyWWVZUHJvdnd2QjM5VHZpZmUxcUMzbVd6ZVVad3N4b1lHalg5?= =?utf-8?B?eStoMXBJdmlub24ydHNSYUx5ZzVsOVFEMlFkUDFybjkzWXZYRXVXMDhucE9V?= =?utf-8?B?RjYzdXQ1NldER0Y3REpVTDE0ZmRtemhsb3BVVWZPWk5NR0ljR0JoUzEyd3oy?= =?utf-8?B?YVQwc0tJWkliblpzeDZGczg0Zk1LV0d2K3RmVlZBaVo2Q1RCYXNzWDFVWFB3?= =?utf-8?B?TGp1aUVENTJmQnVDRmg4WksrOURIb0F1ZlJObFFLVTBodElPSHg3OUx5NGRJ?= =?utf-8?B?MnlIeE5pbkNiOVBYUXY0b0xxT0ZQQXBpd2R5eXpyVmtNejBoSTVIVjVRR3RM?= =?utf-8?B?d2NXTWU1UVVOdmk5all3b0FpZ25QUGtaRVFOYkFxOXRCOVRGOWZtbkU5WWww?= =?utf-8?B?RmJ2RG0yaGZRa1gyZ3lRUFozMUo3M2tZZzVjV1hFdUxBbFVHdUEzc2RpMTEy?= =?utf-8?B?K2R4eHZPL2RSS3lEa003NnV2eU5PcnMvWWpKcko4OVNrZDJYOE5zUkcwYkZV?= =?utf-8?B?UEdSUXU0UHMzcmsrYndkZERaQWhpVk9EVDNMamwwY1JiNGpDaThHUjlmU1pB?= =?utf-8?B?SkkwN1pqZE81QkN3WG4yNTF6L01DWkcxb0ZUcjZnYnc5eDdheERHckVRUkND?= =?utf-8?Q?GDAe3znrJmdAg=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d93d1c7d-3244-4eb2-59f6-08db0f861552 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 18:54:37.1590 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OHgCbAqKthzlfkCoBOqz+nRS4xYtAE+JrBocIVSooryanPMpeTSHO6DoyHFnvQzbu6NQN/n1K6AaUnKl+RGdeIjYSbdvO/gbR/AO3HqoBxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5633 On 09/02/2023 10:38 am, Jan Beulich wrote: > Have these in one place, for all architectures to use. Also use the C99 > types as the "original" ones, and derive the Linux compatible ones > (which we're trying to phase out). For __s, seeing that no uses exist > anymore, move them to a new Linux compatibility header (as an act of > precaution - we don't have any uses of these types right now). > > Modern compilers supply __{,U}INT_TYPE__ - use those if available. > Otherwise fall back to using "mode" attributes, but this can be relied > upon only when bytes are 8 bits wide. Should there ever be a port to an > architecture not matching this, it would need to define the fixed width > types locally by some other means. These types were added in GCC 4.5.  It is 12 years old.  We even use a newer C standard than this compiler... At this point, it is an unreasonable burden to be continuing to support compilers this obsolete, not to mention that the mode attributes are unreadable to anyone who isn't a GCC developer and clearly unnecessary to begin with. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 15 19:11:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 19:11:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496218.766841 (Exim 4.92) (envelope-from ) id 1pSNBC-0007Dt-BB; Wed, 15 Feb 2023 19:10:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496218.766841; Wed, 15 Feb 2023 19:10:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSNBC-0007Dm-8U; Wed, 15 Feb 2023 19:10:58 +0000 Received: by outflank-mailman (input) for mailman id 496218; Wed, 15 Feb 2023 19:10:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSNBA-0007Dg-Uq for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 19:10:56 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78354da4-ad64-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 20:10:55 +0100 (CET) Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 14:10:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6738.namprd03.prod.outlook.com (2603:10b6:510:115::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 15 Feb 2023 19:10:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 19:10:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78354da4-ad64-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676488255; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=UVsfMk4SWV8HKTH4zxYbL27C1uUgbMhQkVtyZNQ9+Vc=; b=g6GYI/UCYEqTKhKS9Vg5Y9S4XZUszajEhwd1QEinyYJIQSv63Uq6b/s6 7d5cXkHXWA7PDoxcqx2GzukzZfMRJAwwt2ZUiI4cbWtFqBxy98KZgxRBu QqHDlDO/6ZIC9CBqKgK3ZTljQ0dPmfHOeU0H0dZxYL5qBPigj4+MjXPLq I=; X-IronPort-RemoteIP: 104.47.66.48 X-IronPort-MID: 96034143 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:goq+kKrHCOPkHA88ssns6Sp/UhNeBmLTZBIvgKrLsJaIsI4StFCzt garIBmAPPvbMGumc41yb4u2o04O6sKHnIdnSAE/qnw2HyIS85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADQTQS/Tl++q+YC6F7JPvMYuAPPIG6pK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIq9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzmrqU22QHIroAVIEQpX2OXp/WLtmudScpbc ms/pTEqgLdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ihDc6r6Uei4gMzarTwLzcqzelp5yMSxFv4AzSBzih9lkhON7jYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr327FF6KLFWyI3AxDGQ== IronPort-HdrOrdr: A9a23:nsxPj6O1QcBu2MBcT7T155DYdb4zR+YMi2TDGXoBMyC9Afbo7/ xG+85rpCMc6QxhJk3I/OruBEDuewK5yXdK2/hRAV7PZnibhILsFvAc0WMNqweQVhEX2IZmpO hdmoJFeZbN5WETt7e33OFTe+xQjuVviZrYz9s2rE0dKj2CCZsQijuRUTzrWnGeLTMubfFSef bshParvwDQCUj/LP7Le0XtcNKz5+Ej/6iWGCLuaSRXkzVmwQnYjoIT0nCjr2EjuvB0oIvKM1 Kqr+U03MWeW37S8G6U64Yb1eU0pPLRjuFbDMi7gsIJKjPq4zzYE7hJavm5pTgwluqm8z8R4a zxiiZlBd1670XLcniyugaF4XiV7B8er0X6wVuvm3HkusCRfkNJN+NxwbhBeh/u8UAnp91L0K VXtljpxKZqMQ== X-IronPort-AV: E=Sophos;i="5.97,300,1669093200"; d="scan'208";a="96034143" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OausjVY+oeR4B77d1jgRs912itxmVXd6Ys5E4NY7MUsf2eZfoLQjOYfJkqD9CUrB6vhH4eqBRMIQbByVDDNOTUBUmurtsJ3Pc3OpnGu75roMZmw97j3xscbVmcfJqDm69vgOKVkTF1y6KqRE8nGUaPSUI4P8l99lg9P72rsQcgy+7vaEA3SVZBjwIUwZYWgjdmFfmU45bIeo/OhlSrki/63im2mHxZyM2w7aP781vX7vbBLbRO+IooBv4CGeJ3YSFgtNWyXZgiapEUp8JYXHcSBW2c/TfAaIyjETD+266qH3/ADTfZuGsOyH0XbjL621/cyyiWFW8+PVvlBftjLoUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UVsfMk4SWV8HKTH4zxYbL27C1uUgbMhQkVtyZNQ9+Vc=; b=PQokcQBe5Hnb+26KFyDoO4BPJKCPFVxw+qtOMiz6kP+iPceUJg55P5kbcYqNonAr7iYu2LkL2zKHKCVOBF/vKJQKVAnqxzCAHluWOkXZ1qAMxLUWYWyuM99rDW0lv4TmY+LMWIQw/yuoCJIULYXNvaIyK67SzWbTSjRacfmQVJZi0EuwAqT/YyLvlA7XAVXsfGvDLijiJaNDFoUEIZ3x7lUFmn29T/gQcSDIYHhzanMpPTjgI0Zf6PZStFxE9J455ZybNvIs22DkqfOHqS4tc6QUrULtTIXhploTm2IVoiGvmuI3mhTg5QvsfM1CguL6+3kPny7hoxXNLQi8BHWPgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UVsfMk4SWV8HKTH4zxYbL27C1uUgbMhQkVtyZNQ9+Vc=; b=pa5mpigwloPFTkJEvKLKtNejb26Me4wFl6G/lzFZiLc9ZNR7RO+utV7I/jLZnDpxLHbdap2eLKHdHtfUM+Z1XQH1RNIscHWfn+0wIUPtp1NHYdl430qnF0FqzJvh6LR8wE14L3zw+s64mxPqG1oDTmC4dClFYTPKwSaDvfrhtSs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <13c62c91-c512-7677-c536-9391206e3185@citrix.com> Date: Wed, 15 Feb 2023 19:10:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 3/6] ACPI/CPER: use standard C types Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <68bb1c78-2b6c-4b8d-725d-f1d6a6c92dcb@suse.com> In-Reply-To: <68bb1c78-2b6c-4b8d-725d-f1d6a6c92dcb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::34) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6738:EE_ X-MS-Office365-Filtering-Correlation-Id: 73d562d1-8996-48ed-05ab-08db0f8857ab X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vq+cnWlXDcbGiMF3bwTDs9HCbA9rMD74UW3Y9e9RSVDoKACdr+KZabxyTGsc4pJFhXrHJc1ISLaAHp78lUfSSJDrwjUZpgEQK64SsIdbZMkkCAZEbQCtNr6L0aiyg7QyXmhvFuQzvNGK2Z6aSWlw09RPjvWmMa6hWWnMa7uCEWa8XqkxnD2v0Kpc9KtJhVDH3nWjJefq50S/rLkKQQai08IVWZhj9Rqv1y2g0gB/rCc+4b8vD5k/ZjVTb8ngSfM5wfzxpGwpnh3knoJy2XWAs6Z3r1Z5QZTilAbyi7JT0YxJFhYXFOug+n3Qie4kKbhyBNHe0V1149feIMVpQEaXkRXgHbL/e9gb57y8qTfGHIYTIrq4TEI7iJtushR2zK0uXh3aAWJpFO4RWmLd5nIhkEhIVv5cj+4RlYtL4XZm3grAbNSZcFfktwfSTUKjUdMjhIk3ruz7YPYuGfc7GYiu/CwIFgiMLFTvLEcfm0TUkPwD0YgvFa0z9BUTTX1SMeBeUOBZgvGAlypI6vqa2iBued4w94tbFydiLa9AqZwPlc5QAvzaxql0sWQYVzpi72Kmio3gzOcYqN/VktyrElLpSrVfzVrzmHgfimf6ENQP0I9zOMOAkLWe53Q7YZfdGJyIA1wP8XlyYqPeLgc98qe+V1JLA2wfbURjujzgAqsjIO1biiBHGU4BI83VnpXx7Qo+EP6MSBe+y4FHa0Ue791mObMr4vHosB/DkkLdMe+u+YE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(86362001)(6506007)(2616005)(478600001)(53546011)(6666004)(6486002)(31686004)(36756003)(186003)(110136005)(41300700001)(26005)(4326008)(8936002)(558084003)(54906003)(316002)(66946007)(66556008)(66476007)(8676002)(5660300002)(31696002)(6512007)(2906002)(38100700002)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHcyODZaS0xyRUFqeHIxTjk1T3FKR0hkdzlXbUR6d1NWU3czNHE0K292bnAz?= =?utf-8?B?cFV4bmxBQUJCdGZoS3M4ZnJLN0k3QXdGTWxoYUxGUnVCTkgrNlZwOWdMYkMy?= =?utf-8?B?d000aWZibVZib29sNXRVMFlmeVNJUnFyOGRFSUZxNGw0SE5jWVpWR2loME5q?= =?utf-8?B?cTUrR0pxKytTVHRKa0sxQXRzUE5XZUo2SEw5VVB1eVdVcGZrYWlFSFhkYkI2?= =?utf-8?B?K090bW9EVmJiL1ZYSnVDRHVUZFQ1TlpKcVY0WElSQm1oRE0zSm02T2RkczVa?= =?utf-8?B?WlgwTTlleCtQdkZiOXV4VWF4K3FPekhwUHdvamk4Q21WYS9UYkdQMjRQeFRo?= =?utf-8?B?VTY0b2pVKzlDNDY5L0xVaUlmU3o2K3FuaHVOa2x0ZnB1YjZtNG1Qa1lXdXdv?= =?utf-8?B?YUxHbjBEeHBOZjJldnpDTHhXVGUwWHQ3Z240VkFETmN2cVNHbGd3dTZiamFF?= =?utf-8?B?TEJkemRTUGgxVFdCdVJiMEpnb0U1OUNXdTBHZHVZZlE5dVRiNThDdi9aZ2hM?= =?utf-8?B?YVZPOU9MUThrNWsxVGRWOFJnQnVNaXQrWGpMdUFSRktlTkErMXcvOHY4eEFu?= =?utf-8?B?Ris5ak9LRTRsRmlTYTlyT2g1OENmcVBvYWpBMW5vRG52Q1QvV3FUenExVlZs?= =?utf-8?B?OHhWVnNGdlFNUTNOcHYySHRlQzBjZmFqcEFwcFZnVHRxYmxkM3lPb1pOUEJS?= =?utf-8?B?Mi9ZeDFmeUdjWjl2WDRXQk5ZRkRpa2xhdnFTeDZCRVBScFBldnFsTnJTNmtW?= =?utf-8?B?enJlS0RaKzQybEJwa0pIUHVFVTBxZXJIN0tjQVFOZFNERy9qcEtrNjVNTFI4?= =?utf-8?B?Qmp5K0ZFWDAyM1ZxMUJBTFM2V1N4QnNSK1dtRmh6WTNiVjE0Vk56dEdwaXd5?= =?utf-8?B?cDBRcjI4SWNSdzFhVlR2U0gyQU9BRmw2bVJmRmRKVkdHaTVhRGpWTitnYkgx?= =?utf-8?B?dmJyTzdHLzE2OTdMM1NYUFhNa29MYnFDSHpRMVpBT3Jma05wSXU0V2E0d0Qw?= =?utf-8?B?V014Z0Z1NXpKRis3QllYeDgrRGhYQldicDdTdS9XWlg5VFRXK2xpTWxmaE9B?= =?utf-8?B?ZkJIbGh2bHQzQVM5dkhsQ2ViUE83SktOT0EvRG8vczFSejlBSGR2cGdPeEhG?= =?utf-8?B?Wm02Z3dyR0N3TkxJVDI1TENPNU01d2NhYjBZWmQ0L2w3K1R0My93ZnpiRUQ2?= =?utf-8?B?WEtucUZrZGFmUUhDRVk3M2ZybS9PMWJ5QzNNSm1zWlRvVkZqd1dnVFdKbEI1?= =?utf-8?B?RG11U2RCN2psNUlsR1ZjT1RVK2NUcDJFZk9nbVFUU0lHM1VxZk5SWGlLV2Fv?= =?utf-8?B?K2RTZXNEa3JuU0QvWDdYMFU4THVFYVB1WUN4VTBTZksvdTNEWmVxZmdBQ3Ex?= =?utf-8?B?OUJsN1pHU1JDYUFNY240VVlzaFhvU2ZqNFhaK2VaR0pHaFdhUXVmQ04yUllp?= =?utf-8?B?N3JCTmVYRDNoRjZHSFRDZXg1S1N4OWR3c1dFQm1KMjVvdGlTT0tvTTJZMzVv?= =?utf-8?B?MHBRdnZIc29TZFh3enhkZ3M3aXhWdGMranZiM1cxMGJxbWJBUHRBdkxaU3RI?= =?utf-8?B?a01LVFg4YjIxRDA4RWpDWU8yT3NoaGtRQWVMWXFYM2dMN1lGZDQwMG8xdG00?= =?utf-8?B?QWpjb01PTXVsNEJtcHFNaEo2bzhLdkFQY2ZQSnVDdHVaMUdnbU1wblRZWlVo?= =?utf-8?B?aGpyRGw2Q2JQaU5TQ0U4VGtybXd1SnZQd3k2b2FWRXdSWk5pWVpoRnMyVlk0?= =?utf-8?B?SnpkSk15elYyUUhMdUZxc2QrYTk4MWhjOUY3NXJ6TlZZT0J5aDZUb09ZQkwz?= =?utf-8?B?OTVtVzRYWGJkRG4ra2tqUFdHYzFhNEM3RGNmWXZjMU9EeWRMb2lxNytOZ2NW?= =?utf-8?B?SHh6WjJnY2wvNzZqMndGNW95OFVOYW5rdTM4dWNSaTRpUXVJSm51d0YySEJ4?= =?utf-8?B?azNhVytmYTdZOTRRVjh4RGNTcS9XYi9SYk5OSlhkUEtncm9ZbGdEekt0Y2lH?= =?utf-8?B?eDdocmtRNXJqNExlMWsrdG4wVEdpbDkzVzMrREhoR21MUzIzdU5zdDlwMUow?= =?utf-8?B?Z3pxNTRyc3MvZnRHSGxZSmtuVm13eDY4TGZpYWdvTU9kbW1xMG10VmNQc2R3?= =?utf-8?B?MTUwMkVOTDQzSU1HRVUvQ2pVbnpmUlhiL3pUa3dNVWo3UEltWnhwT29oT3E2?= =?utf-8?B?dmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yIRYBZG7Cf4GJ1II8GLbImB77oKnU9vRi65htljqM5xqDGuq4DmpSXSwsgpseTDQzee5qiM/UX0tRAL+8YbRA8H6xG+jh9y6PkOl9FbkvZ2W9FneNf1W45piR+Rmav45EyHSu30lGtKH1VDucCTaJpvG37bv3g/CEN+qU7UZHxThZlV2dH5Vgj0mZ40hiDEie58ANy4HPsjscMHe6/I0fwtgeF+kmXzS+foAyqecyIYq9dywoo1Uf2J0hv1PNFdmG+Ef/znLTFOe1gg2ENZrbNOv6KNXdowP1WmLspwHRj7Oc6aRhmmgOJ3jIfcxUl6c/GrdJ/k0W9ETZMU9o768BUkqwrbXeCC1tI/pfWtLfIjoNubrX8Aii9uPwZ1A5Vz5U0I0Q9kVTo8zigYVyzwnRjXq8P8FRVbYs4Qq5naF3zA83ekuUf/UgLY+ed6JyG68TM2IMdSXieBhTBE3Bhs5j1aWarYnauMXhnEfGeBsuDNo6wUai4TNo9wIuQGW6/wrFm3NG+5JDC0fQQtHQQ89AgL+OIoQprpYh7P7kLUg/FkqvXx635IHINUC9T5VluwXB9YT0pzISL3sA3F5aKKhCHzrad08ZQ2kVWh0CBAajTWu1o1R+hiODfqHBOHjQkGigidKoP8SKpmR+LfcPWHFJOY6ZLsxYzDvL3C5HkhzITdlGh9suuOZOMBjya9XGFDecMUsyAl+ss1BIQZtkOy6NX9z2ccUEEV+g7H2V3DkGvV+cJOK20ky2hlVdMycEO6nZ2rJiC4thTqwIZublk7+G5oSBCB+q74mpWVzrwvHUDlte9OgLNI3OCpzy9HKQmjtvMUyodcfY2V55QL5d7ifq6oajuQ2fSxHkoVqJDbwM9M= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73d562d1-8996-48ed-05ab-08db0f8857ab X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 19:10:46.8539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gTkcVFmum4HW1e5nmAe8infQoTnWTmhBOpIbwmyiqNz2ICDEnOXQmZP9wxXTX9ajwynWrFxA1falWG7idMSHkKNCinyH0hcmt4z9akgCJNM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6738 On 09/02/2023 10:39 am, Jan Beulich wrote: > Consolidate cper.h to use exclusively standard types. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 15 20:26:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 20:26:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496227.766853 (Exim 4.92) (envelope-from ) id 1pSOM5-0008CY-PT; Wed, 15 Feb 2023 20:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496227.766853; Wed, 15 Feb 2023 20:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSOM5-0008CR-LU; Wed, 15 Feb 2023 20:26:17 +0000 Received: by outflank-mailman (input) for mailman id 496227; Wed, 15 Feb 2023 20:26:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSOM4-0008CK-8U for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 20:26:16 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe46fbce-ad6e-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 21:26:14 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id d40so24370488eda.8 for ; Wed, 15 Feb 2023 12:26:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe46fbce-ad6e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aLKQiduvbwcuWPjLhrIXf/wvw+QwAXw9ADazq8HX33Q=; b=Glcjv/lb9axEm8XF/JDrgZBfaUEBjp0C/9ECprCJgqcJptWBs0uYME0yCquVFLcJY1 y/YNlntbw4x9XxejpH+WE267zIuJmrq8enyKmhTYdGqanc39kqRHDOZjs3d1aEQ+Y4mC cvVW3zLzGXAlBdMDbtU1hczj3+vJo3R+pQ9naNaBZQcEr42XoJlrf+Z4juFHHvbmxTW7 3K7AejLuCfpjGyUNYTQE5LXQkMGhGgnGH+/h61iZZJQl82uJHRT8bYLudF2wj/XNp9l8 K0CLzjd7UZoNEoIMUFAtQO5UfZHLP6bWLbgkvuapD6FPqDih9UhrPIY8FYDhsOVzA5BP 3flw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aLKQiduvbwcuWPjLhrIXf/wvw+QwAXw9ADazq8HX33Q=; b=4VqSFIKVQsOJjmkjxFaAXWHLBwPvz5uzwmpkFiJwLFpNEHnQ8wX+mAB7XMzVWZHzyq +JGOpXv4ncNs6F8g6uTChblnqzeRbQeLNMFSa7k80KPb7+zjgrjUxePl0hEnuRsc6KQJ /3ifA7d50/Z6P4Dfkzqc0mGETEVG0a15+ATXsFNNbFPO2XlusfN+UebvTsuxz5Y2OYcs OEANIufcJ4Pe1TsJu/gJWVObZ2Ja8pkt9NVnFltyiV0GyUCVse2YAFwdCGWlaXUDvnpy /b3ne/6RbJR0hM7Q6xsBvHLjoh/JIOziJWBRcD23vonkvdqfxya0ZoGvdpG6JtfqY0eA qfVA== X-Gm-Message-State: AO0yUKWUn0cJugrR8bELUfKnnhj6pcx1q4MwtI6Uf8M8TAl9ff3ubkY8 YyAu8W8YA4w36Y40Zu/ma/3jTOxbyANsZLTjO4E= X-Google-Smtp-Source: AK7set8bxA8S/WcUsnsUYIDri1yCOs8sT9OjcO/2wEkdp1El4esm/Qk98LVbcXM4BEnRHkn6WWCkRJPG+ThHoh82vrs= X-Received: by 2002:a17:907:7ba3:b0:88d:ba79:4317 with SMTP id ne35-20020a1709077ba300b0088dba794317mr2843563ejc.7.1676492773874; Wed, 15 Feb 2023 12:26:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Wed, 15 Feb 2023 15:26:01 -0500 Message-ID: Subject: Re: [PATCH] libelf: relax ELF_PADDR_OFFSET && !VIRT_BASE check for PVH To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 10:09 AM Jan Beulich wrote: > > Both values are unconditionally overridden (to 0) in the "hvm" (i.e. > PVH) case. There's therefore no reason to punish a PVH kernel for > setting the former but not the latter. > > Fixes: 632cbaf1243e ("libelf: improve PVH elfnote parsing") > Signed-off-by: Jan Beulich Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Wed Feb 15 21:53:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 21:53:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496235.766864 (Exim 4.92) (envelope-from ) id 1pSPiV-0003A3-5t; Wed, 15 Feb 2023 21:53:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496235.766864; Wed, 15 Feb 2023 21:53:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPiV-00039w-1V; Wed, 15 Feb 2023 21:53:31 +0000 Received: by outflank-mailman (input) for mailman id 496235; Wed, 15 Feb 2023 21:53:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPiT-00039T-ES; Wed, 15 Feb 2023 21:53:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPiT-0006Y0-BG; Wed, 15 Feb 2023 21:53:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPiS-0003v5-Mv; Wed, 15 Feb 2023 21:53:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSPiS-0000cJ-MO; Wed, 15 Feb 2023 21:53:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u1XkrE/b5CO4DcMDOBXlR5rmks1ctwdeyTU1+u5QZKA=; b=cnqlJ88D+LkUQtWxAuPDALQyTR Ys6qmRKBWAwl3i+ypIMarvnxUDjxnE4R2/QZeorHUXRYpifnAlMsOPPstzkCdI4bRmT/JOE2hhmEw nRXjgXKmmIfNnUoeeijTJcci8opSYi7Oxznp4oazs0KdMJ9OifP/ggokBISFBK4FfpWM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177376: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-i386-freebsd10-i386:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=63305e5392ec2d17b85e7996a97462744425db80 X-Osstest-Versions-That: xen=63305e5392ec2d17b85e7996a97462744425db80 From: osstest service owner Date: Wed, 15 Feb 2023 21:53:28 +0000 flight 177376 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177376/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-raw 7 xen-install fail in 177312 pass in 177376 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail in 177312 pass in 177376 test-amd64-i386-freebsd10-i386 7 xen-install fail pass in 177312 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 177312 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177312 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177312 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177312 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177312 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177312 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177312 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177312 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177312 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 63305e5392ec2d17b85e7996a97462744425db80 baseline version: xen 63305e5392ec2d17b85e7996a97462744425db80 Last test of basis 177376 2023-02-15 10:37:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Feb 15 22:09:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 22:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496245.766875 (Exim 4.92) (envelope-from ) id 1pSPxn-0005RJ-Ku; Wed, 15 Feb 2023 22:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496245.766875; Wed, 15 Feb 2023 22:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPxn-0005RC-I5; Wed, 15 Feb 2023 22:09:19 +0000 Received: by outflank-mailman (input) for mailman id 496245; Wed, 15 Feb 2023 22:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPxm-0005R2-SW for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 22:09:18 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62d24937-ad7d-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 23:09:16 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C1E3B82374; Wed, 15 Feb 2023 22:09:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B12F7C433EF; Wed, 15 Feb 2023 22:09:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d24937-ad7d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676498954; bh=knuIhoDZUpESCednEs/ZWH3TXPZ5EU8rVUzhJNJg6Iw=; h=Date:From:To:cc:Subject:From; b=NILB23xEE4tdGkkz8mhfRDe35radJ2p47C1A7joAGmrvpZQ2h9Pf2/r902lFYZ5ag wQhU10qnSnDpy/RiKi60HSf+o6MAMd+a9zZpq9UAy2H5lDQH0iYH4ck5HLy8UYxosA 7eQgZPa3wdUhukYo1YpUtIM41tPh4Jq9AcdOok6OeLBcEIQdUfaCfQ08iLEe5dT/uF b8EqCu44M85GDqjoNKJgUh0iFYOYgSJrQzli8ydY7uX9dBj6Fh4FlmfAJQ4noDmfPg U6GP8WyovXx+Skc7kmh6A2FlzIY0E4ILGXpwl7Z3SjqnUb2IQKXlq5rcBckdft9qWL ukxIblDO7N5Mw== Date: Wed, 15 Feb 2023 14:09:12 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com Subject: [PATCH v2 0/3] automation: add arm32 xl domU creation test Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This patch series add a domU creation test based on xl for arm32. To do that, it reuses the existing arm32 dom0 test, and also reuses the Yocto qemuarm build output. Pipeline (with reduced amount of jobs): https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/779022452 Cheers, Stefano Stefano Stabellini (3): automation: move yocto jobs to build stage automation: add binaries/ to artifacts for Yocto arm32 job automation: expand arm32 dom0 test adding xl domain creation automation/build/yocto/build-yocto.sh | 9 +++++ automation/gitlab-ci/build.yaml | 52 +++++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 47 ++------------------------ automation/scripts/qemu-smoke-dom0-arm32.sh | 50 ++++++++++++++++++++------- 4 files changed, 101 insertions(+), 57 deletions(-) From xen-devel-bounces@lists.xenproject.org Wed Feb 15 22:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 22:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496246.766887 (Exim 4.92) (envelope-from ) id 1pSPy1-0005jo-Vs; Wed, 15 Feb 2023 22:09:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496246.766887; Wed, 15 Feb 2023 22:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPy1-0005jh-QS; Wed, 15 Feb 2023 22:09:33 +0000 Received: by outflank-mailman (input) for mailman id 496246; Wed, 15 Feb 2023 22:09:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPxz-0005R2-V0 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 22:09:32 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b015b85-ad7d-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 23:09:30 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 66D70B82374; Wed, 15 Feb 2023 22:09:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5793FC433D2; Wed, 15 Feb 2023 22:09:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b015b85-ad7d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676498968; bh=Tso1s+NNc0babg5gBaw2ZRssYgQb1dk1kR0QDs857oM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t7qWg+q6/llTe3MDd8dpsqgf2FSrMMv8Vy7IMJbUj4UO38xjlKFobYN2+bej+yfxT Ms1gfKCMJ0DCpI5hXDVXMqRRu74TVJhsr9y7OA/h+j6BLu6paBXkOOJTmDbypIVKTR cn1ObUNF9k8HX2MFhD04c9tsK+6ii5AeYngxcllvCPQDcCVVwP+metXoR286yzN5Mc wrbEJW01gFP0fKbevbGqryc6OUDjTjdhHjkRHCcTnkEOeVkJPUv7HIr06FbDKWm1hC X3YQ1aBz200X2EIe9bCkdoYDQvT7aAWbvGQOPjbmBN8eXqDIbZsrUpGIZlpbytXVcW 9n36s3uyDlpNQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v2 1/3] automation: move yocto jobs to build stage Date: Wed, 15 Feb 2023 14:09:23 -0800 Message-Id: <20230215220925.2313528-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini We are going to use artifacts produced by the Yocto builds in test jobs. Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 51 +++++++++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 45 ----------------------------- 2 files changed, 51 insertions(+), 45 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index a053c5c732..f62cf21f45 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -199,6 +199,41 @@ variables: <<: *gcc +.yocto-test: + stage: build + image: registry.gitlab.com/xen-project/xen/${CONTAINER} + except: + - master + - smoke + - /^coverity-tested\/.*/ + - /^stable-.*/ + script: + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + variables: + YOCTO_VERSION: kirkstone + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} + artifacts: + paths: + - 'logs/*' + when: always + needs: [] + +.yocto-test-arm64: + extends: .yocto-test + variables: + YOCTO_HOST: arm64v8 + tags: + - arm64 + +# This is not used by any test job as we only run Yocto on arm based machines. +# Keep it here so that someone having x86 hardware can easily add jobs. +.yocto-test-x86-64: + extends: .yocto-test + variables: + YOCTO_HOST: amd64 + tags: + - x86_64 + # Jobs below this line archlinux-gcc: @@ -679,6 +714,22 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Yocto test jobs +yocto-qemuarm64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm64 + +yocto-qemuarm: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm + +yocto-qemux86-64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemux86-64 + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index ce543ef5c0..9570085a60 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -67,35 +67,6 @@ tags: - x86_64 -.yocto-test: - extends: .test-jobs-common - script: - - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} - variables: - YOCTO_VERSION: kirkstone - CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} - artifacts: - paths: - - 'logs/*' - when: always - needs: [] - -.yocto-test-arm64: - extends: .yocto-test - variables: - YOCTO_HOST: arm64v8 - tags: - - arm64 - -# This is not used by any test job as we only run Yocto on arm based machines. -# Keep it here so that someone having x86 hardware can easily add jobs. -.yocto-test-x86-64: - extends: .yocto-test - variables: - YOCTO_HOST: amd64 - tags: - - x86_64 - # Test jobs build-each-commit-gcc: extends: .test-jobs-common @@ -253,19 +224,3 @@ qemu-smoke-riscv64-gcc: - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} needs: - archlinux-current-gcc-riscv64-debug - -# Yocto test jobs -yocto-qemuarm64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm64 - -yocto-qemuarm: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm - -yocto-qemux86-64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemux86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 22:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 22:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496247.766893 (Exim 4.92) (envelope-from ) id 1pSPy2-0005n0-B8; Wed, 15 Feb 2023 22:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496247.766893; Wed, 15 Feb 2023 22:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPy2-0005l0-1u; Wed, 15 Feb 2023 22:09:34 +0000 Received: by outflank-mailman (input) for mailman id 496247; Wed, 15 Feb 2023 22:09:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPy0-0005R2-V6 for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 22:09:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b6b6bc9-ad7d-11ed-93b5-47a8fe42b414; Wed, 15 Feb 2023 23:09:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A557261DBC; Wed, 15 Feb 2023 22:09:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60506C433EF; Wed, 15 Feb 2023 22:09:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b6b6bc9-ad7d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676498969; bh=ui6UKmuaYYAlo1er5w/0SLINIVnsRORvvWH0lIJWCiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X1s+AnGX233Zw4wwgqjkAbFic0eVhSFVv15ymDRIYLomBmWGCfIxkMAFRHE3zAH4z zkUgmRuNMoqjpO1wT0srojgHNhrBk47L/Itba66LArPtVkmsjDpCW1C1t8I+/iLs3U 8+wQ/PJDTG0jYJEbJHW0pSuQ2EDjBC8FYXtIL/F31mNRlyE8a+Z4wWjU2a14mOKw00 GinF7BkRL9cmE77WpMoWlJEvE2+ht0ya7eFkq1ZIkPnpSBXWyz3UxF7br8nme1Xt0r pQlq11lWDN/60rDkOr2vpXHrNe2RT4hvbZpDbnIwI6xhg/1DCzoOAVWNYQwVGpUXrG 8iH7RAjMcjlGQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v2 2/3] automation: add binaries/ to artifacts for Yocto arm32 job Date: Wed, 15 Feb 2023 14:09:24 -0800 Message-Id: <20230215220925.2313528-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Copy the build output of Yocto builds to binaries/ for the arm32 target, and export binaries/ among the jobs artifacts so that they can be reused by other jobs. Signed-off-by: Stefano Stabellini --- Changes in v2: - only copy binaries for the arm32 target --- automation/build/yocto/build-yocto.sh | 9 +++++++++ automation/gitlab-ci/build.yaml | 1 + 2 files changed, 10 insertions(+) diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh index 3601cebc3c..dd7065e5b2 100755 --- a/automation/build/yocto/build-yocto.sh +++ b/automation/build/yocto/build-yocto.sh @@ -166,6 +166,13 @@ function project_build() { source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" bitbake "${build_image}" || exit 1 + if [ $target = "qemuarm" ] + then + mkdir -p $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/zImage $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-qemuarm $OUTPUT + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-image-minimal-qemuarm.tar.bz2 $OUTPUT + fi ) || return 1 } @@ -238,6 +245,8 @@ Options: EOF } +OUTPUT=`pwd`/binaries + for OPTION in "$@" do case ${OPTION} in diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index f62cf21f45..d4a2aa9a5b 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -215,6 +215,7 @@ artifacts: paths: - 'logs/*' + - binaries/ when: always needs: [] -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 22:09:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 22:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496249.766899 (Exim 4.92) (envelope-from ) id 1pSPy2-0005uG-LB; Wed, 15 Feb 2023 22:09:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496249.766899; Wed, 15 Feb 2023 22:09:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPy2-0005sO-DW; Wed, 15 Feb 2023 22:09:34 +0000 Received: by outflank-mailman (input) for mailman id 496249; Wed, 15 Feb 2023 22:09:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSPy1-0005jC-Ls for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 22:09:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bc899ac-ad7d-11ed-933c-83870f6b2ba8; Wed, 15 Feb 2023 23:09:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F0DA61DD2; Wed, 15 Feb 2023 22:09:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E2CC4339E; Wed, 15 Feb 2023 22:09:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bc899ac-ad7d-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676498970; bh=Iamh2qBSbFn33h3UDYRg2ZRfP+A5EhnNlQK4iEJGSF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TvEdejUUpxdaxGd6/xhc8oQAkepOVQ5Of2rbPPW/X60e65XpSVclPHIZsVBDFCHpu LOxwRInw5kSdNcDQGjNqA3QgnrFwAUviXaCyywLVIYb7NSo39XdhQbWkKNzceI7RI/ kkiywDi7pXOHQZe9BIJUIe+cd5BBtJIjLEvBeegHnacZvzZt/CTKg/FBSYOVnjZI3I 4+lrrcE6LRJcJgKZVQLKnLU7jhjBoMjDyi6sAs2r5Eb/uZwJe2KA7FHBuft6luE0qv gCcYF5wAOwN5H11ymrMUBPZoSxzNB8xoup2Hv/OViT5bfwFtTZ5BsMvrA7U15MFUXp NaoqH3/9y8xEQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v2 3/3] automation: expand arm32 dom0 test adding xl domain creation Date: Wed, 15 Feb 2023 14:09:25 -0800 Message-Id: <20230215220925.2313528-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini As part of the arm32 dom0 test, also create a simple domU using xl. To do that, we need the toolstack installed in the dom0 rootfs. We switch to using the kernel and rootfs built by the Yocto arm32 job. Remove the PCI node from the host device tree: it is unused but causes a Linux hang at boot. Use xen-watchdog to trigger the domU creation for convience (/etc/local.d is not handled by rootfs.) Signed-off-by: Stefano Stabellini --- Changes in v2: - add yocto-qemuarm also to qemu-smoke-dom0-arm32-gcc-debug --- automation/gitlab-ci/test.yaml | 2 + automation/scripts/qemu-smoke-dom0-arm32.sh | 50 ++++++++++++++++----- 2 files changed, 40 insertions(+), 12 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 9570085a60..77bb1c362d 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -172,6 +172,7 @@ qemu-smoke-dom0-arm32-gcc: needs: - *arm32-test-needs - debian-unstable-gcc-arm32 + - yocto-qemuarm qemu-smoke-dom0-arm32-gcc-debug: extends: .qemu-arm32 @@ -180,6 +181,7 @@ qemu-smoke-dom0-arm32-gcc-debug: needs: - *arm32-test-needs - debian-unstable-gcc-arm32-debug + - yocto-qemuarm qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f6..7a748bdf23 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -3,14 +3,37 @@ set -ex cd binaries -# Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz -# Use a tiny initrd based on busybox from Alpine Linux -curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz +mkdir rootfs +cd rootfs +tar xvf ../xen-image-minimal-qemuarm.tar.bz2 +mkdir -p ./root +echo "name=\"test\" +memory=400 +vcpus=1 +kernel=\"/root/zImage\" +ramdisk=\"/root/initrd.cpio.gz\" +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" +" > root/test.cfg +echo "#!/bin/bash + +xl list + +xl create -c /root/test.cfg + +" > ./root/xen.start +echo "bash /root/xen.start" >> ./etc/init.d/xen-watchdog + +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz mkdir rootfs cd rootfs tar xvzf ../initrd.tar.gz +find . | cpio -H newc -o | gzip > ../root/initrd.cpio.gz +cd .. +rm -rf rootfs +rm initrd.tar.gz + +cp ../zImage ./root find . | cpio -H newc -o | gzip > ../initrd.gz cd .. @@ -20,22 +43,25 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ -machine dumpdtb=virt.dtb +# XXX disable pci to avoid Linux hang +fdtput virt.dtb -p -t s /pcie@10000000 status disabled + # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt.dtb" -XEN="xen" -DOM0_KERNEL="vmlinuz" +XEN="xen-qemuarm" +DOM0_KERNEL="zImage" DOM0_RAMDISK="initrd.gz" -DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" -XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/sbin/init" +XEN_CMD="console=dtuart dom0_mem=1024M bootscrub=0" NUM_DOMUS=0 @@ -51,12 +77,12 @@ bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ -timeout -k 1 240 \ +timeout -k 1 720 \ ./qemu-system-arm \ -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 15 23:23:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 23:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496268.766918 (Exim 4.92) (envelope-from ) id 1pSR6x-0000R6-R1; Wed, 15 Feb 2023 23:22:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496268.766918; Wed, 15 Feb 2023 23:22:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSR6x-0000Qz-OH; Wed, 15 Feb 2023 23:22:51 +0000 Received: by outflank-mailman (input) for mailman id 496268; Wed, 15 Feb 2023 23:22:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSR6w-0000Qt-JQ for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 23:22:50 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6dfe8ba-ad87-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 00:22:46 +0100 (CET) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31FMxIQs018871; Wed, 15 Feb 2023 23:22:44 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np2wa1t70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 23:22:43 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31FLPAZt016765; Wed, 15 Feb 2023 23:22:42 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f7uwn9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Feb 2023 23:22:42 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by PH0PR10MB4789.namprd10.prod.outlook.com (2603:10b6:510:3c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Wed, 15 Feb 2023 23:22:40 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6111.012; Wed, 15 Feb 2023 23:22:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6dfe8ba-ad87-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=x5cHxNRsBgzP/65saTGrGlD/j2smdlH/nz5C+5CED94=; b=vVO9h75kJdht+OtylOm/NPy6JZPsAiLO9krJg5WDKSAuXIcEqJ44T43TmGNNKGCuPC+y DYy2hiY3StO7N5sUzs3VwsldJWsVZsY940kaf+OtpUPpmAjCaA1gRjAoPro3562JUNdW U7Fox3iU4fVQsWQfQwVZ1yWW+ePQbVtwNVj9rK929UzczDNdUSdKzLoO8kLtu8dO7Ker YUHKMpf0M6K0RKfmAE6jNMjtxrz7RiZAhH753KGgf0goFw5YYxJhwjaOAj5zWdWu709Q DY3Ggjw8xe0xqeXk3wVEXXN5VydCQ5V8+4/KqMvK7x+B6I2AfPsi4Z75WQEUT++xpFKx qw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MlFLqBYgn6N7rysXSMfEeW366I8XcpuD2ZlsdfMH7S8vAGEkZ0V//eitTWJ/vjfC1hUm9VKNFWGVzIFbOMIh+/Qp2cHA90t2g/pr0+eVHd+BbbcpIyZpA1+tQRl43ej3nrf3eq7ZQiAU8Pd/JViP3y3GCw9E8G5Qe7yUtma1oauP0QFGKppX88uBKqFVWxzljd0MXTynhDCb/wIaRl8n2fHDmqcMJVwMkpnlDOzd8QaCWBHGBi/a00gdxDiwRKbCu0uqsyr7K0HcID2lVUow8lYXrlGsK4liUYCXzmYeIGYFc/lWclcZzQXX/UHcDYUAykEUhSKQmCXHPYUTtp0mww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5cHxNRsBgzP/65saTGrGlD/j2smdlH/nz5C+5CED94=; b=PIJhP5s8T4Xx9/F9l+GDt0MRdco9v2QAoJrboceL/PqVuH8wwdGEApB/ygfm10aEIV8fs4VRhEDDa5BEZWoWc4laqbZ7CVqWnvD3EqPnvJFE4pbgdO18b6PBgSBEK6BQHYg7+3OHvTwxP0As7C/Zso89MJD4BE9GGe9fXqPX4wN8fR6TfpmpRj+4IlxmR18FsyYJOA+SURyDOWYuZCplGHj5lZTRfAPGo/zc2t/XS2E+/Z06ah1tbpSPYYRXrKfIcBz6nfU50wJ8ZLMup4OJbTdBJ17lWfCrCqr91vKhIv4vdpvaJ6FO2U5FeIRtB3zmMS1g/nK1tSwqvWlukyub6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5cHxNRsBgzP/65saTGrGlD/j2smdlH/nz5C+5CED94=; b=cRXx7AS62x/LzBBh59zX7Tp1V15mPwiJhN+oHBxdYkORoi9oDW6y5Gh+d5Fd8Q8GWqEMZtw/xNBIzDRvyBmRsBXGt5GoNIH48hRa1ShCih0SbBRdqpvagkCEU/LJLSRuUM5Mmm6144ZBKcUetlaZmpRLu+TCIfP7BokYG4439PA= Message-ID: <64bc94a4-07f8-a065-7346-6d9f514bd690@oracle.com> Date: Wed, 15 Feb 2023 18:22:37 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , Juergen Gross , "xen-devel@lists.xenproject.org" References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> <4e66865b-11ce-cbd1-d115-13e3743eed7b@oracle.com> From: Boris Ostrovsky Subject: Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0446.namprd13.prod.outlook.com (2603:10b6:208:2c3::31) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|PH0PR10MB4789:EE_ X-MS-Office365-Filtering-Correlation-Id: d98c0f4e-7e37-4b2c-3171-08db0fab87ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vRIPTDtwjAbDAlYPWNU/7FCNUmvMMu0aQsoIRkyjI94N6bUG4Y8pwYDg7hKisX3zg/YO8JFiJXNKlcEYqtgK4H+AVZ4LZzaXHk8fUelMrEhHLH+yIg9/fHlQ+9i98AU1gTYJhPrfXx9Czjx6NBEaujGnv5uBk/KW8M/4boIw00vK0fnCdSvjwVAZMeraEJJO25Rap89BYxXq26PQV5QNwGSowiPUy41UApmETzTMjBNNtcSpqd7RNkmjgH3cpTXBjWQiPw98cSmUPR1I5i0EwFmKhJFPQ4ILXbS7n0mlYzVTfYsVJiuZIfmvuDJ+QR1wBHPaDdumIf/QAtkeZ6frmf1zLfPp8Yq1uK7JHB2OeBrmvVPAGmU2ZvBYb+rgBwSGTm99U94m3/NLYzwIDz9NNzz+S9mzmfVHhZdT1iXV49Ad2XWediVX0ry2HiyhCILo2/FA1PYqEZ2guIcEdy3l+7fZ6lmr/fOomgtCIiDmkmYSaGU7nR+7MunOSrh3UMywF8zvQ2HsgX6FX53rqGKBOI7BLk8DteYO+jUIvFva7MBv9HbXneJyOe9UIpfxGcRao5aYovloDjcVrQs1wRl93P5K6UNTuW0RScUDPqxP2Ry6f9x0lBDGns+2Jl60n5/Cvc8zrIA21E7olhyk5mr9j4ZE5tMraom40SNEBgU6NVHdjPJ/b3eLfANvN3tbKCHDAdvAfVn9/NHH5xkHv9B088aZsfgwt1FD6r8LEsr8EA4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199018)(36756003)(6486002)(478600001)(66476007)(38100700002)(2906002)(6506007)(8936002)(41300700001)(5660300002)(316002)(8676002)(6916009)(4326008)(66556008)(66946007)(54906003)(53546011)(31696002)(86362001)(2616005)(26005)(6512007)(186003)(83380400001)(44832011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3ZQdGdiVGRUWmJiWTRuOE1UR0lvM04wMkdmbnBkN0JzeE9iWFRFOVVEYkJo?= =?utf-8?B?bWFFZ1I1UFIyenVCSXFnQjd1dWlPcWJsaWpaL3lMWVBXbG1BM3dBL2VoTjg2?= =?utf-8?B?NDc3bWxpUHoyV003V1I2ZU13dnhNVUR2QjBZSGczeXhFZXJDbTNVZjRCOWVL?= =?utf-8?B?Y2dXb2dzTzgycGRhV0gyenFPRklQVW9WbEkwcWl3dHBvaE9qNDdCRXoralRC?= =?utf-8?B?UXF5LzJIWVBSNW8waHNnWFpKTStwNTZIQkdvdDRrWVpxcjZvN3Y4eHprRi9a?= =?utf-8?B?bks4MHpUY0hVUFo3NUxLVnRlSXYreldmOXF2RGFjTVVPTSs0NTh3RWJKdXVv?= =?utf-8?B?T1lLSTNhQjVnbFpJSlB6cnJUcnoycCtkdWhOVEF0aXpDS2d2UmJ2MFJxOENC?= =?utf-8?B?bUU3aHllbzBQY1B0cFNETERBdHJVdGFrSkdUeHhab2hmTHBRNEs4WGx0ZU1Z?= =?utf-8?B?emJKajdDaUp3MndtellId2MzQU5sWkNuVG1MSnRkUWtMeWNaZ2pEWWlOb0lN?= =?utf-8?B?QWRpTVZFeGtsK01CTnBlNGdmN1lOdkN1WXB0OVpnTTcwSkRRSkh4YTRKRFBp?= =?utf-8?B?c1J2dXNQVE1UUFFTWXAvbFpOWUUzNzZDdDdDQ1JLV3M2STBNUkVVbWdrZGZ5?= =?utf-8?B?ZmxwNVRramJPbXhQNkEwSU1HTE1wNzhTWGVyQ2ZZQXdaMnlDdHpBSDNHcEdq?= =?utf-8?B?MDZmTFJWcFFYakZCQWduZnFRV0F2b0FQNmZXU1pUcHI5eWtjRVFia3pBclhC?= =?utf-8?B?Y00yQ1dpTFp6Mm9ZalQrSkZZc1Y5WFJTRVo1VkRmaExicERyUHNsNjU4OFJq?= =?utf-8?B?V1hXRG51Mnh2K0cvOUtGMzhObDA0SktQeWFOTTlOZzY5em5HUldtdkdEdW0r?= =?utf-8?B?SWd3a3hoaE1zVTVQL2xYTlpoRGw5dml3RExoeVpDdUtyMmo1aEVXRHR6c2Ji?= =?utf-8?B?aVU5aVBjUXBldEFKZEhXc01IblU4UFh2VGZuaVVsd3FxYTA3bTBCL1NQeitj?= =?utf-8?B?cWh2S0R0T2ZaUTQzbjFoSDYzSy82MCs4MVY4ZDhXRWxyekMvU3VwVC90b2JY?= =?utf-8?B?dW5SVXV2a0xXQlNVb2pkelQxaTlaRkswNzhSeE83K1VsWkJFQ2lmMkU3dmNw?= =?utf-8?B?TGJxUzVoakIrbmQ0YjA3Y01ETzNVUWg1N1B4L3dwaTl0NnFGNW1sVU9sYUJT?= =?utf-8?B?aElxYU5yaVN3Z2ppRUZ6cS9WZ0NDdXRIS0hvOVhCdDdJOHl0Nm92byt3ekt5?= =?utf-8?B?SkVDeXZ6L3pMU3QyQlA5dEwyM1hQWlBzL2ZkWkNvN2VoRmx4MmI2emN4WWFh?= =?utf-8?B?VGY2cnE5UlJnTmZ2QStUazh4bHpURDFnbktRSUtnSXhnL09VbXNxVSttYTAy?= =?utf-8?B?akJpQmsyYWowQ3J4Lzl5Y1c0QXc2NU5SUEplVnRUNEpiczhvVUlFN3Z3Szlv?= =?utf-8?B?U3cxaThMNGlnd1VlZkhjSmp4S1JXS21jYXkxeG15ODFVblpvcno3N011Zk5G?= =?utf-8?B?MmtkejNvNGNKSzk0a2RBYityU0pIVExmSk8wRHducFlHMisxRDE3MWZnMG9O?= =?utf-8?B?R0N2NDd2MXlNNkhzTE1IRlNDUzNmY0gydDRpeno1SjRIeEVHdlZwblVzdW0x?= =?utf-8?B?QS9QUGQ0Z2xFeXZuL1hOS2dMaTc5M0VZdmlxaE5vUzFzZDArbmRrV3liZHB0?= =?utf-8?B?TGxzcXlIZ081RldoNW5wSGdkUFk5UUhNam12aThnK3dKTlhEeDNKWU1tOTlU?= =?utf-8?B?Q3VYU2MrMkRacVgyQnRzdEJXRy9PQ2hRb1dFblFVM2g3VmJ2dnBkcndMUGV5?= =?utf-8?B?MkR3RWZtTnRxdHE5NnY1b2dkNUtOUmVUNDAzUDZja1VrOEpmUW1JYmFOcTFT?= =?utf-8?B?ckNVc2NEOWFHRExKblc3TGhoS1RQKzl4S280dXNUMUJJMm5oTGRJNVZRNUZP?= =?utf-8?B?Q0l1YTJhWHBheC9wU2YzU3BidDg0SHFYTHIxYmxSWGZZSG9BeVBWcXpZbVFC?= =?utf-8?B?a2J2WDFuVy9FV1g4T01Xb1VHaFVHR1QvcExpRDRGSWNwUnRMMFlMaDQzRWJh?= =?utf-8?B?ZHg2OTU2Q0ZrT3YvOFBkNjVVdUpCKzZJeHdia1F5SHZ0WHp2T25LdTRialI5?= =?utf-8?B?U3JnSThicDkxbzlmMU8wUklxWUZOMUtFcXVnTmlHZFFRRWd6c1N5blNkdlRt?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tBvi8cXrVnn5JRWO/T42S1YanTP9v1T9KECtw2W7K9wzF14yoHwVeyJV2P5lIfG8kbYHzyRlpL3n0UUoHcfshQcAwC0xJYmZcnI6JP9Et35I5rvZQxJ8t3Ao5JTPx0kve+r8yXWgik6iqE1s1Fx1BA5whZc/k/80hKXeJdIOAeeL7UBfgCfQ4XDIItTUyycNymDQJjiP6SQfLkU4i7yvXV789GWLPBvUDkfWzZyaYbGZx4litTZ54G+mhlrY4iF0Q7i/w96wHFfgQzBFuA3Ns4LAht/6GSMiMHwD3k5wo3E91sK05Hpo30KcfmY4ec7tr0lPHN3HIMpWfKnSScMnrjhI3+/b47CNIbfR5VdgRBfIVyqz5y5gQAfXpGxrcTqvFnhJJc69/a4lWC4iGvjFvnipsLnLNfo/GcHFvUuZbGsjt2ipJZnjKQ/Nc2EKfrNhW1j9wbhjx4Ti1PT+DGftSY0+5aAEIQVWr4dYqkzNs93+ndlaZ4h2hrU3P4pseIakiTUR96Tjpy0gLQGa8O0A8ZCI28cxBhcI8G6BIhXj51ugTlTGzRLWQTlkCAdvB+5CBUAOvMdwZy07SPTDi0+HgIKLb7ybvpWl7wasWaNR6D9vUPcYC8AVWtkv3DmNSLDymiGyw7X2UgWEb2DndSFuOlWLdLl8GZCUJsMfR9EVfkS0bw0AtYpeOgdINOpjPMP0N+ljIVn0HA4ruzWiRvC0ZXfizNWqsjV+DDZHAYNwJUx46VxOTPhHpQW8N+QmYLaz9WDq1rBHZJiMSMBqGN7i42OpIOWjYuW/2fzRWq9lZhisMXHZ8E9U6doxVNyQzNWJmy/yk8KnASL89Z/isdr7Zw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d98c0f4e-7e37-4b2c-3171-08db0fab87ec X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 23:22:39.9002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: suHyOoBFfgD5cJ6raUozHvGl/50y30ek2O9lbpM7Suq3P2hK9UGNpqYydxc6AzDZrtwLoMrNwoa6327IVvziQfZg1qrrdRqusXA2J7qt+OM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4789 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-15_14,2023-02-15_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=735 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302150199 X-Proofpoint-GUID: Bu4dp5df7fYeA1FoJ-Qs3vltSHyeLKIA X-Proofpoint-ORIG-GUID: Bu4dp5df7fYeA1FoJ-Qs3vltSHyeLKIA On 2/15/23 3:31 AM, Jan Beulich wrote: > On 15.02.2023 01:07, Boris Ostrovsky wrote: >> On 2/14/23 6:53 PM, Boris Ostrovsky wrote: >>> On 2/14/23 11:13 AM, Jan Beulich wrote: >>> >>>> --- a/arch/x86/kernel/cpu/bugs.c >>>> +++ b/arch/x86/kernel/cpu/bugs.c >>>> @@ -18,6 +18,8 @@ >>>>   #include >>>>   #include >>>>   +#include >>>> + >>>>   #include >>>>   #include >>>>   #include >>>> @@ -32,6 +34,7 @@ >>>>   #include >>>>   #include >>>>   #include >>>> +#include >>>>   #include >>>>     #include "cpu.h" >>>> @@ -934,7 +937,8 @@ do_cmd_auto: >>>>           break; >>>>         case RETBLEED_MITIGATION_IBPB: >>>> -        setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); >>>> +        if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) >>> >>> Is this going to compile without CONFIG_XEN? > Yes. The declaration of xen_vm_assist_ibpb() is visible (satisfying > the compiler) and DCE will eliminate the call to the function due to > xen_pv_domain() being constant "false" in that case, avoiding any > linking issues. The interesting case here really is building with > XEN but without XEN_PV: That's why I needed to put the function in > enlighten.c. This wouldn't be needed if xen_pv_domain() was also > constant "false" in that case (just like xen_pvh_domain() is when > !XEN_PVH). > >>> I also think these two conditions should be wrapped into something to limit exposure of non-Xen code to Xen-specific primitives. > I would have done so, if I had any halfway sensible idea on how to > go about doing so in this particular case. In the absence of that it > looked okay-ish to me to reference Xen functions directly here. > >> Oh, and this needs x86 maintainers. > Eventually yes. But I would prefer to sort the above question first > (which I'm sure would have been raised by them, in perhaps more > harsh a way), hence the initially limited exposure. > I also think there is a bit of a disconnect between how the mitigation is reported in the log/sysfs (retbleed_mitigation is RETBLEED_MITIGATION_IBPB, so "Mitigation: IBPB") and, for example, lscpu (since X86_FEATURE_ENTRY_IBPB is not set anymore). -boris From xen-devel-bounces@lists.xenproject.org Wed Feb 15 23:29:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 23:29:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496275.766930 (Exim 4.92) (envelope-from ) id 1pSRD8-0001KJ-Jr; Wed, 15 Feb 2023 23:29:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496275.766930; Wed, 15 Feb 2023 23:29:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRD8-0001KC-Gj; Wed, 15 Feb 2023 23:29:14 +0000 Received: by outflank-mailman (input) for mailman id 496275; Wed, 15 Feb 2023 23:29:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRD6-0001JI-Mo for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 23:29:12 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c848daf-ad88-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 00:29:10 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id x40so616909lfu.12 for ; Wed, 15 Feb 2023 15:29:10 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id q10-20020ac2528a000000b004dc4c5149dasm22926lfm.301.2023.02.15.15.29.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 15:29:09 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id y25so632946lfa.9 for ; Wed, 15 Feb 2023 15:29:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c848daf-ad88-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Tabx9NVVhDi2NL80cED89hxZVqfHcpcD6w5gvEiG26Q=; b=Q8cRbK9bsfMvz1Nn6UBM35NtrHJymdIg7nZkemYtGgv/3Q3yDTJhJG+X81qDdYabIf xxrtKoM9CiUsnARz3yOk+5K7ZQQZ+AQV90O8Y3pMrOhGvrKc3sTzpKJ1yje35uhNEj4B uqqN3W2f/CoTRayN0vR+ZkTzIuArxuwqNE2BU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tabx9NVVhDi2NL80cED89hxZVqfHcpcD6w5gvEiG26Q=; b=XU50iB+JyBbpES8dXV83F34hEJ/C1NXcqhdyo7b9ZkxD9dOEwTjT4aIqs/4E36T0Rb 21o3t9wpYy/f/cDVM+A9Bj9mbOs3n/n2O1OyRn8FXIar/gT6N6qjNGKalfLrnft6014j 8LSFt2SOS3pTriZxMNP4+/3CCBU1jI2/HPUC1vzj2CAkOcU9xTW5aarVCCN0RBSeI8uR Npyuqh1knlnvNj3v7T2dovMpnZ7bBFKMGidrCwcvyWEeP+aRV8IVQQZ1vousdJI9H5gc 4HlyE6ol9hqWPOVET2CIjRpja7amPNCVe8wRPSuUr3PGFrFkect4qFAAhJb2gMNedDbY kFsA== X-Gm-Message-State: AO0yUKUjnP4ffDIBtAa6JACNa3ZmgytaVQJ0WwZYjNxvLyd2EIUEE4fj XS3a8S9o1Pa72YzdTQv1vBr9upeFigVgbShcI9axSw== X-Google-Smtp-Source: AK7set89f8Bp9QGNS/A8iUL3LnOjEb8PZfld30EuRubFOPr3iXhGUxmixx+WUbcwc0p2h7sA98KS3A== X-Received: by 2002:ac2:42c8:0:b0:4b6:e4c8:8a48 with SMTP id n8-20020ac242c8000000b004b6e4c88a48mr771339lfl.63.1676503749374; Wed, 15 Feb 2023 15:29:09 -0800 (PST) X-Received: by 2002:a50:99cf:0:b0:4ab:4994:e648 with SMTP id n15-20020a5099cf000000b004ab4994e648mr2049346edb.5.1676503372641; Wed, 15 Feb 2023 15:22:52 -0800 (PST) MIME-Version: 1.0 References: <20230209072220.6836-1-jgross@suse.com> <51a67208-3374-bbd9-69be-650d515c519f@suse.com> In-Reply-To: <51a67208-3374-bbd9-69be-650d515c519f@suse.com> From: Linus Torvalds Date: Wed, 15 Feb 2023 15:22:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR To: Juergen Gross Cc: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" , "Ostrovsky, Boris" , "peterz@infradead.org" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 12:25 AM Juergen Gross wrote: > > The problem arises in case a large mapping is spanning multiple MTRRs, > even if they define the same caching type (uniform is set to 0 in this > case). Oh, I think then you should fix uniform to be 1. IOW, we should not think "multiple MTRRs" means "non-uniform". Only "different actual memory types" should mean non-uniformity. If I remember correctly, there were good reasons to have overlapping MTRR's. In fact, you can generate a single MTRR that described a memory ttype that wasn't even contiguous if you had odd memory setups. Intel definitely defines how overlapping MTRR's work, and "same types overlaps" is documented as a real thing. Linus From xen-devel-bounces@lists.xenproject.org Wed Feb 15 23:49:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 15 Feb 2023 23:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496280.766941 (Exim 4.92) (envelope-from ) id 1pSRWu-0004RI-58; Wed, 15 Feb 2023 23:49:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496280.766941; Wed, 15 Feb 2023 23:49:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRWu-0004RA-2M; Wed, 15 Feb 2023 23:49:40 +0000 Received: by outflank-mailman (input) for mailman id 496280; Wed, 15 Feb 2023 23:49:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRWs-0004R3-Ig for xen-devel@lists.xenproject.org; Wed, 15 Feb 2023 23:49:38 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 676f3e47-ad8b-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 00:49:37 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4753EB8245D; Wed, 15 Feb 2023 23:49:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FF49C433EF; Wed, 15 Feb 2023 23:49:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 676f3e47-ad8b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676504975; bh=XudEG24Kl9MJslGx6RhMm3q1j1xJ91xr0LW7EAVmQ84=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nHWiqOtuxc3dW14qKKtY6FljMdAYd8z6x4HtgLIfwwnbLXhSH0Dkdt4Ku+nQvSLoZ bGtGVD/kmDvg2ARdlvteO78sQtRODCYsof9OHYBlzOSxkiIrIchAA4BX6cRr5PsOht t6YM1KKi03PjEzIH8eS4+hPEAIPaXY3JDzEMeg48O/gACjUAzvZUie7VkqqA44JMb7 P/0D6nplT/pQOCCK8bnK4hGc9yMSOWOgnGz/ViYAExiAS/dQBMEdHf8luMPmAhT/4+ XiZkHo3Q6SFQ29ya+jQ5rNSmrhn9DHvO1kHvWYYheNo8QN0smjEfySc7e4uMK9MLui bW+4CYQhSWzkg== Date: Wed, 15 Feb 2023 15:49:32 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Jan Beulich , Luca Fancellu , wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json In-Reply-To: Message-ID: References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Julien and all, Summarizing here on the list what I had with Julien and Bertrand this morning. On Wed, 15 Feb 2023, Julien Grall wrote: > Hi Stefano, > > On 14/02/2023 22:25, Stefano Stabellini wrote: > > > Patch 1's example has a "comment" field, which no entry makes use of. > > > Without that, how does it become clear _why_ a particular file is to > > > be excluded? The patch description here also doesn't provide any > > > justification ... > > > > It would be good to have a couple of pre-canned justifications as the > > reason for excluding one file could be different from the reason for > > excluding another file. Some of the reasons: > > I think the reasons should be ambiguous. This is ... > > > - imported from Linux > > ... the case here but... > > This reason is pretty clear to me but... > > > - too many false positives > > ... not here. What is too many? > > > That said, we don't necessarily need to know the exact reason for > > excluding one file to be able to start scanning xen with cppcheck > > automatically. If someone wants to remove a file from the exclude list > > in the future they just need to show that cppcheck does a good job at > > scanning the file and we can handle the number of violations. > > I disagree. A good reasoning from the start will be helpful to decide when we > can remove a file from the list. Furthermore, we need to set good example for > any new file we want to exclude. > > Furthermore, if we exclude some files, then it will be difficult for the > reviewers to know when they can be removed from the list. What if this is fine > with CPPCheck but not EClair (or any other)? Yes, the reason would help. In previous incarnations of this work, there was a request for detailed information on external files, such as: - where this file is coming from - if coming from Linux, which version of Linux - maintenance status - coding style But this is not what you are asking. You are only asking for a reason and "imported from Linux" would be good enough. Please correct me if I am wrong. If that is the case, I think it is doable. Most of these files would end up with "imported from Linux" as a reason. That would be fine. > > I take that with this exclude list, not accounting for rule 20.7, > > cppcheck reports zero violations overall? > > So the goal right now is to have zero violations from the start? Shouldn't it > instead be that we don't increase the number violations? > > If so, we would want a baseline including the files that have "too many > violation". The advantage is it will be easier to reduce the violations in > small chunk and the reviewer can confirm that a patch help. Yes, we want to be able to compared and see if a patch introduces new violations, but that's not easy to do with cppcheck and it would help a lot if we had a cleaner baseline with only few violations. Otherwise there is too much noise. To help make progress faster, I took a stab at writing an exclude-list.json with plausible reasons that should drastically reduce the number of violations reported by cppcheck, see below. With the below: - There are a total of only 18 violations on x86 (Once we ignore the unusedStructMember reports that look bogus. We should add unusedStructMember to the rules exclusion list.) - There are a total of only 12 violations on ARM64. - You can repro my findings, applying this series, updating docs/misra/exclude-list.json, and calling ./scripts/xen-analysis.py --cppcheck-bin=/local/repos/cppcheck/cppcheck --run-cppcheck -- CROSS_COMPILE="x86_64-linux-gnu-" XEN_TARGET_ARCH=x86_64 { "version": "1.0", "content": [ { "rel_path": "common/bunzip2.c", "comment" : "imported from Linux" }, { "rel_path": "common/libfdt/*", "comment" : "imported from Linux" }, { "rel_path": "common/livepatch_elf.c", "comment" : "not in scope initially as it generates many violations and it is not enabled in safety configurations" }, { "rel_path": "common/lzo.c", "comment" : "imported from Linux" }, { "rel_path": "common/symbols-dummy.c", "comment" : "MISRA is not relevant to this file" }, { "rel_path": "common/xz/*", "comment" : "imported from Linux" }, { "rel_path": "common/zstd/*", "comment" : "imported from Linux" }, { "rel_path": "common/unlz4.c", "comment" : "imported from Linux" }, { "rel_path": "common/unlzma.c", "comment" : "imported from Linux" }, { "rel_path": "common/unlzo.c", "comment" : "imported from Linux" }, { "rel_path": "common/version.c", "comment" : "cppcheck cannot understand the tricks with linker symbols" }, { "rel_path": "include/xen/lib.h", "comment" : "imported from Linux" }, { "rel_path": "include/xen/sort.h", "comment" : "imported from Linux" }, { "rel_path": "lib/list-sort.c", "comment" : "imported from Linux" }, { "rel_path": "lib/rbtree.c", "comment" : "imported from Linux" }, { "rel_path": "lib/xxhash32.c", "comment" : "imported from Linux" }, { "rel_path": "lib/xxhash64.c", "comment" : "imported from Linux" }, { "rel_path": "xsm/flask/*", "comment" : "not in scope initially as it generates many violations and it is not enabled in safety configurations" } ] } From xen-devel-bounces@lists.xenproject.org Thu Feb 16 00:07:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 00:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496286.766952 (Exim 4.92) (envelope-from ) id 1pSRnh-0007jc-En; Thu, 16 Feb 2023 00:07:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496286.766952; Thu, 16 Feb 2023 00:07:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRnh-0007jV-BV; Thu, 16 Feb 2023 00:07:01 +0000 Received: by outflank-mailman (input) for mailman id 496286; Thu, 16 Feb 2023 00:06:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRnf-0007jP-8l for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 00:06:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1e7ce79-ad8d-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 01:06:56 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A01C561589; Thu, 16 Feb 2023 00:06:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B9EFC433D2; Thu, 16 Feb 2023 00:06:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1e7ce79-ad8d-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676506013; bh=w7BuKMhDKY7mGJ2kGBUrPMqDaSm/Ii4hzKc4wooO//A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LIH43egt0Pc+86fkozBSFkHBlr7UfbWwf6v0BEsxgg0z76ZnvwimuR/tKnQa3oOgc bWGNuxevSn96sHUGJEFOCv4E7K2BnArVRCC9uqn6q7mGMRmsoHiuKKuohnWdIs4rg7 tU7aKBv61SzJ5zDyt+JM5sQto6oc4ZHtM0a7jjMTUmWr3TZksJ1rPzF5Ee57++4dg5 7UH7XaXBC17lb+Dis8K+KYY5bQRnAipBVzOoC4Y4X9T0CIwKUksPTorav6T2DiL08t BaW5lvWhnOhIMHT4ss0RaTz4LjboVxo/Xl0ctec7pA7GxwYulQhO5a6CNenQiP+6WD DdXyCWKkEV3lg== Date: Wed, 15 Feb 2023 16:06:51 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: anthony.perard@gmail.com, xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 1/4] automation: Remove clang-8 from Debian unstable container In-Reply-To: <1e8ec592-4a5b-4c74-5a0b-dbf3ea60b084@citrix.com> Message-ID: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-2-anthony.perard@citrix.com> <6fa7fa56-d30a-e66e-b46f-5e7daffeb487@citrix.com> <6c455c45-18d3-584e-bc8a-a1d22a68fcd3@citrix.com> <1e8ec592-4a5b-4c74-5a0b-dbf3ea60b084@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-329596572-1676506013=:2127160" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-329596572-1676506013=:2127160 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 15 Feb 2023, Andrew Cooper wrote: > On 15/02/2023 4:31 pm, Andrew Cooper wrote: > > On 15/02/2023 4:28 pm, Anthony PERARD wrote: > >> On Wed, Feb 15, 2023 at 12:26:40PM +0000, Andrew Cooper wrote: > >>> On 15/02/2023 12:02 pm, Anthony PERARD wrote: > >>>> First, apt complain that it isn't the right way to add keys anymore, > >>>> but hopefully that's just a warning. > >>>> > >>>> Second, we can't install clang-8: > >>>> The following packages have unmet dependencies: > >>>> clang-8 : Depends: libstdc++-8-dev but it is not installable > >>>> Depends: libgcc-8-dev but it is not installable > >>>> Depends: libobjc-8-dev but it is not installable > >>>> Recommends: llvm-8-dev but it is not going to be installed > >>>> Recommends: libomp-8-dev but it is not going to be installed > >>>> libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable > >>>> E: Unable to correct problems, you have held broken packages. > >>>> > >>>> clang on Debian unstable is now version 14.0.6. > >>>> > >>>> Signed-off-by: Anthony PERARD > >>> Yeah that's because clang 8 is way obsolete, and http://apt.llvm.org > >>> only supports Clang 15 and later now. > >>> > >>> In hindsight, it was a mistake to take unstable-llvm-8.list in the first > >>> place. > >>> > >>> Acked-by: Andrew Cooper > >> I just realize that this change is going to break gitlab testing in the > >> staging-4* branches. So I guess this mean that we will have to backport > >> this patch, or at least the gitlab-ci part. > > I don't think it will.  The currently cached container is still "good" > > for the older branches to use, but we ought to backport the change > > nevertheless. > > > > Given that the container is un(re)buildable anyway, we're not losing > > anything, I don't think. > > Ah, so.  Applying just this patch won't break older trees. > > But applying this patch, and patch 3, then rebuilding the the debian > unstable container will break older branches, because there will no > longer be anything called clang-8 in the container. > > This demonstrates even more that referencing the compiler by exact > version is a mistake.  As is using names like unstable. > > As I said up front when we added CI of this form, we were always going > to retrofit some changes to all branches (including the security-only > branches) to keep this working.  These chicken are coming back to roost. Yes. Like you said, I think we should backport this patch (or just the part of it affecting .gitlab*) to the stable trees. --8323329-329596572-1676506013=:2127160-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 00:15:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 00:15:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496291.766963 (Exim 4.92) (envelope-from ) id 1pSRvR-00012k-6n; Thu, 16 Feb 2023 00:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496291.766963; Thu, 16 Feb 2023 00:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRvR-00012d-3j; Thu, 16 Feb 2023 00:15:01 +0000 Received: by outflank-mailman (input) for mailman id 496291; Thu, 16 Feb 2023 00:14:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSRvP-00012X-Pb for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 00:14:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f18f9394-ad8e-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 01:14:57 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C56E61DEB; Thu, 16 Feb 2023 00:14:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A08BC433D2; Thu, 16 Feb 2023 00:14:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f18f9394-ad8e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676506495; bh=YL6UqIB+dkLUTsHgyQsFUs2HhAbjJocPWSrkbGVoHXc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZjokTIi0zExmlOTtuMfwIPmoZ53Z//8FCODVTL9+EUHVI7f8OP3r0piCgDxhPu8oD E2RLpypRuBfPnFXc5q1C/tGTa6cDrbd2RO26fsQUuMIC+zrEAoL5N1cX/Bp2QyG5Il AzesDPrS9pPzjWgXtQGFzUUAB6Sj87I124/EkCgzPaFlYfQpPEMxCftp/LCdMOqoHF AI7XRpluIERNQBUaMpIzSpxcqHNWJ0l+BKy4LswIDHYOFDgq7cNe5MSaH2HDKSGXeE 825AGepSrTV0TuAIwCUY0nyJ1gDRz3Dyi3tX/SVxKSbpJ7380q1QDD6z8aYFYRKHKP I+OUgwY+eok1w== Date: Wed, 15 Feb 2023 16:14:53 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Anthony PERARD , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt In-Reply-To: <3caee35d-3c0d-7e28-dc66-6f422568edad@citrix.com> Message-ID: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-4-anthony.perard@citrix.com> <3caee35d-3c0d-7e28-dc66-6f422568edad@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-652203529-1676506495=:2127160" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-652203529-1676506495=:2127160 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 15 Feb 2023, Andrew Cooper wrote: > On 15/02/2023 12:02 pm, Anthony PERARD wrote: > > While the Let's Encrypt root certificate ISRG_Root_X1.crt is already > > present, openssl seems to still check for the root certificate > > DST_Root_CA_X3.crt which has expired. This prevent https connections. > > > > Removing DST_Root_CA_X3 fix the issue. > > > > centos: found the filter by looking for "DST Root" in `trust list`. > > > > Signed-off-by: Anthony PERARD > > --- > > automation/build/centos/7.2.dockerfile | 5 +++++ > > automation/build/centos/7.dockerfile | 5 +++++ > > automation/build/debian/jessie-i386.dockerfile | 5 +++++ > > automation/build/debian/jessie.dockerfile | 5 +++++ > > automation/build/ubuntu/trusty.dockerfile | 5 +++++ > > 5 files changed, 25 insertions(+) > > > > diff --git a/automation/build/centos/7.2.dockerfile b/automation/build/centos/7.2.dockerfile > > index 4baa097e31..27244fd002 100644 > > --- a/automation/build/centos/7.2.dockerfile > > +++ b/automation/build/centos/7.2.dockerfile > > @@ -50,3 +50,8 @@ RUN rpm --rebuilddb && \ > > bzip2 \ > > nasm \ > > && yum clean all > > + > > +# Remove expired certificate that Let's Encrypt certificates used to relie on. > > rely. > > And really (to all of these modifications)?  This seems outragously > hacky to be deploying into production... > > Honestly, I think I'd prefer to drop all of these legacy versions... Good timing! It just so happens that we need to shave some of the old container tests as we have too many build tests on x86 :-) I would remove Jessie as it reached EOL years ago. Do we really need both Centos 7 and 7.2? If not, we could remove 7. That leaves us with Trusty and Centos 7.2 among these. I would be tempted to keep Trusty and add the sed hack of this patch to make it work. For Centos 7.2, the hack looks even worse. Would it solve the problem to upgrade to the latest Centos 7.x subrelease? Is there really no other way to solve the problem? --8323329-652203529-1676506495=:2127160-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 00:52:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 00:52:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496299.766974 (Exim 4.92) (envelope-from ) id 1pSSVQ-0006Qw-4h; Thu, 16 Feb 2023 00:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496299.766974; Thu, 16 Feb 2023 00:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSVQ-0006Qp-25; Thu, 16 Feb 2023 00:52:12 +0000 Received: by outflank-mailman (input) for mailman id 496299; Thu, 16 Feb 2023 00:52:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSVO-0006Qd-Rc; Thu, 16 Feb 2023 00:52:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSVO-0002pk-Q6; Thu, 16 Feb 2023 00:52:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSVO-0002ER-Ip; Thu, 16 Feb 2023 00:52:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSSVO-0000v6-IJ; Thu, 16 Feb 2023 00:52:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gblqZ2RZcHjz/Gn2xxhjzWPvrBsIhcuQXUl/HOydXvQ=; b=AubW6+urLbjzq918nOeP94IUtW 6c5yDHFn0nCQ/YOUflEYL6O3WuiTDtu9qcKllwoP8o2C+fTM1vpzdgbHnRa7vrhFhold97mroJZzw HuWZWOSDEPoefQF4oa8tPflF2tnw5N2AfkJwIr/0QivkdlIFVIyBKAXwWowdLVzDqqms=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177433: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=91c45cfbab5d9878c0a7021f762988a688d5e91d X-Osstest-Versions-That: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 From: osstest service owner Date: Thu, 16 Feb 2023 00:52:10 +0000 flight 177433 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177433/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 91c45cfbab5d9878c0a7021f762988a688d5e91d baseline version: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 Last test of basis 177402 2023-02-15 16:00:28 Z 0 days Testing same since 177433 2023-02-15 23:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5b9bb91abb..91c45cfbab 91c45cfbab5d9878c0a7021f762988a688d5e91d -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 16 01:11:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 01:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496308.766984 (Exim 4.92) (envelope-from ) id 1pSSny-0007qU-SA; Thu, 16 Feb 2023 01:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496308.766984; Thu, 16 Feb 2023 01:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSny-0007qN-P6; Thu, 16 Feb 2023 01:11:22 +0000 Received: by outflank-mailman (input) for mailman id 496308; Thu, 16 Feb 2023 01:11:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSnx-0007qF-F5 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 01:11:21 +0000 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d02a8c93-ad96-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 02:11:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d02a8c93-ad96-11ed-93b5-47a8fe42b414 From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1676509875; bh=m6ujeRpdfOK/ExLf0oC3JKdeaOfOHj5ANo4y+Xyc7GY=; h=From:Date:Subject:To:Cc:From; b=gSkPlaVUEK8XCxDKTPzpUqjl9Sj0DEdap9GrK1j86v07YTpvTLLdwcKxIujqhkWB+ XgYRtg03IY4LSvnmAhX3Qaz4hjJpbsjxnynrgHkvSOBxHfJDU27yrdWGRUUJ5JRsRz Lnvj6RvH7X9KBpZJ6xcf5rigeR7QEen4I31aShSU= Date: Thu, 16 Feb 2023 01:10:59 +0000 Subject: [PATCH] xen: sysfs: make kobj_type structure constant MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20230216-kobj_type-xen-v1-1-742423de7d71@weissschuh.net> X-B4-Tracking: v=1; b=H4sIAKKC7WMC/x2NXQrCQAwGr1LybCBdf0CvIiK7208bLWnZVamU3 t3g4wwMs1BFUVQ6NQsVfLTqaA7tpqHcR7uDtXOmIGEroT3wc0yP6+s7gWcYd0cJe5GcdgB5k2I FpxIt917ZexhcTgU3nf+T82VdfzDVeXV0AAAA To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1676509873; l=995; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=m6ujeRpdfOK/ExLf0oC3JKdeaOfOHj5ANo4y+Xyc7GY=; b=BSGS1rU5dMp0UG5XucdetX/M4JSycNQ6bQiZOMnjBqP9UUfa2dOu+1rbACy/WpsfD/SxzWpCb DiLmvhDGWHKDZlz1T5Tt4NbRLtZoQNjF1h3XY5tKryMcADg00hd0MNh X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definition to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/xen/sys-hypervisor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index fcb0792f090e..ef62acb354a7 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -594,7 +594,7 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; -static struct kobj_type hyp_sysfs_kobj_type = { +static const struct kobj_type hyp_sysfs_kobj_type = { .sysfs_ops = &hyp_sysfs_ops, }; --- base-commit: 033c40a89f55525139fd5b6342281b09b97d05bf change-id: 20230216-kobj_type-xen-d902500cb4ee Best regards, -- Thomas Weißschuh From xen-devel-bounces@lists.xenproject.org Thu Feb 16 01:19:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 01:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496314.766996 (Exim 4.92) (envelope-from ) id 1pSSvm-000098-L8; Thu, 16 Feb 2023 01:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496314.766996; Thu, 16 Feb 2023 01:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSvm-000091-IG; Thu, 16 Feb 2023 01:19:26 +0000 Received: by outflank-mailman (input) for mailman id 496314; Thu, 16 Feb 2023 01:19:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSSvl-00008v-1j for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 01:19:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0482365-ad97-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 02:19:22 +0100 (CET) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 20:19:18 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH8PR03MB7174.namprd03.prod.outlook.com (2603:10b6:510:259::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 01:19:15 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 01:19:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0482365-ad97-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676510362; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JCuDo7Jh//tAOXQ9beUGsKZVsGpjRnl9red+BJrkUyc=; b=EfNdXpg1oPSrbwcDldTg5Lf6bDHMq5b2rZpZNJqeIFByzChTrCMKFlXG 8qrrXTl0xynF413G2B/yIlWwCpp95mf7zPd8UmD7+jD5xMcmxmmuIMtPo u3oB7WHRX88+sLJQj9xmfVBx7Y6G17MklTpol15Pf4kh+vq6vI/ld3SZj 4=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 97148516 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:S6I6UKrj1QQMncTasoqrQjTMC2NeBmLUZBIvgKrLsJaIsI4StFCzt garIBmPPq3Ya2L8Ldx/aIrk901U7MPdx4U2GQM6pXswFykbpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG40ahCDvsS5/L7lYbU0qtY6IorSYrpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWOEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqac20ADKmAT/DjUyDHm3jKm9yXe4Ad1iD 0so9hYOhKoboRnDot7VGkfQTGS/lhsdUNpZF6s98hOAzoLd5grfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESMcN2MFaAcPRBEJ5NSlq4Y25jrUVcpqGqOxitzzGBnzz iqMoSx4gK8c5fPnzI2+9FHDxj6p+J7AS1dv4h2NBz3+qARkeISieoqkr0DB6upNJ5qYSV/Hu 2UYn8+Z76YFCpTleDGxfdjh1YqBv56tWAAwS3Y2d3X931xBI0KeQL0= IronPort-HdrOrdr: A9a23:hngX2q+aUd+br/Tz4z5uk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.97,301,1669093200"; d="scan'208";a="97148516" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/8zBYgf20zx7wK2ZYfeJ8agf8Ce0hV9oEpbg0/XrevFTW1TW2UfKhpcvbIHeRxTW46GMwN7x9uWg0Intn6ZVljvN2fHt1tYrSpNSE+Mi4Ihfe1gt4Us3SMq82obLvfuTFfUYy9CGfqsM54E5JRDlCjmfK81B5IdCM2QhfBsOBnjs1zisUv5Sjq1eJ4COxoYYzEmu8942QjQm2gsHABr+kTs8nUrU2wOFKmZ5vUnjf5WHkAyeH8DEMfctMqAGBfKAzOASXTr0hgWRgcB4Ewk/NM99IDAdmPLbJKnvIledOpm5NcE1LOWEbE0Geg5QdEZ6J+oLj0ShZYeGL2OPye6Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Js1GesCnGjYso5HBqdg8LKv+7LiWNm3CiZn2vEHvEVc=; b=mbNG26RF024hgPhdmsEh7y5FH/SapXOpTUoh8bcsA097WBiJjTtfoTFW150D39cbmtWUgRA8fpMkKq9Ukq0w9bmjJov7gs8itY7yYnnJdBucJOTs+A9swZk0k9GhsF0kv3R5f1XDjvFhyKhaeBGbDDF0JtVdUYBNGQlrSHYjT0xSsfyfg8uexeSvaOF+hupRA/mjt8ZB+oUTtJsHtu04QeY8kFsk4+lq+CXS9OK2eSwVpT3TcTCD+bjNng8kC54R7uC0aDwNzzm/WFI+nI/hQQA6mimBjqtjoDQloFCdDja0vruNndAWxp8OD3S6zQWkeM2kLLoRQ2swW08EiwSx4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Js1GesCnGjYso5HBqdg8LKv+7LiWNm3CiZn2vEHvEVc=; b=GE05aEU/KQz20BWmlzZ3dK3h+817FL5KoVEPOj9hKszbdYmNBY/QSlpPFJkkjNKYkBFy0a8TfgeO3jQGiMQaF7ewYyQPNKWm1vDD79q6W9atygnECih32BzTd/BCdCaVMdU1tEJuoIFH+kwqACtNos3VAeSPybAMuHfTl8AXaas= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <88342cde-16ec-5451-cd4e-e6669927af0a@citrix.com> Date: Thu, 16 Feb 2023 01:19:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 3/5] automation: Add a static memory allocation test on arm32 Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230214153842.15637-1-michal.orzel@amd.com> <20230214153842.15637-4-michal.orzel@amd.com> From: Andrew Cooper In-Reply-To: <20230214153842.15637-4-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0135.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH8PR03MB7174:EE_ X-MS-Office365-Filtering-Correlation-Id: 52472e18-9eb0-4377-1b02-08db0fbbd12a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SPp/GTAtJu4fy0dvlLgQq21bZOBB07wCEel+zZBfLSH/einb8jR2/bxc4hL9W5m5KgE2C+9jDJjKKC9+aoDdAYSH8xnw8zMQmafsE2zyuj8ux8hV9O2R1iPMIKaCRQzRH7KfjTS3YeKywz3iRUvJZizNHRCYQ5yl+l159AQ5S5gKmJkB83wm+BzXK+zMUL6o9QDF43Vr+xbeikw4Z5lW3eS1tAJF4VDQPY/e4vWfB03/zKe9aqhhbo1+reZz8W6m6uO0Kyh5UyacqOryOCILAFmSvYw6h+iiH1cFt+Nymgct56Tp7shqc5ST9Yo/2/pUP9lDno8a6hb+WDmZWmwfWASKC/POlS8WtpN/p+bGHEUhYZo1p+KiGIgv6USEr5r3ntHIAmZ7UBXW0L/bGCjzG49AIpvXzDJAyvLm3U9sFr9k+bqQ3rmjddgRyDPOzy2sLAzLS6MKC7C+SpVW/Sehi8PF3wFDOru4OxTVXstBYmYxSGFmbdXl90zEFc8sC68s4RN73Qepx8Plb4ElEW4lCWCsPbszo3zMy+2nRYK1VoOyEO/PygfgCAl9/BkSjAaZg7kSYYXmKDv2VlMKBmkX6miPC5HZAXXBUDlFRZW8vadC+Ctq7snqEdORRhc842aaNLMcQ5dNfVBun54Z5AzKCixKKcy6yOfKJIddmIDywrpkNuHPVJERUFJ8lJZuzOerYb8TpLuzFJxl6UlCZSbh05YEvfzoE9CkmOn3kG8XQ/0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(451199018)(86362001)(31696002)(54906003)(38100700002)(83380400001)(66476007)(4326008)(82960400001)(478600001)(31686004)(2616005)(6512007)(26005)(53546011)(6666004)(6506007)(6486002)(66946007)(8676002)(41300700001)(5660300002)(8936002)(316002)(186003)(36756003)(2906002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlgwRVZWdWE3MkVWeVlTYzY3TDJkWEVEUlVHOFFXTFVDY0R2Rk1tbWkxTGxn?= =?utf-8?B?UVpMMUpOVk5INVp6c21rdGhkNmE1NU5TUkw4cGpZVlVkRVpVbWpvWjFsN2Fr?= =?utf-8?B?bURGNkxVUG5NdkNaZG9DRFhIZGx5ckZIQkVLNUgva2UwTEsxSlFmTUkyQ2tC?= =?utf-8?B?SzdzWXBFNUFHSENPaUVERzJVZmhLOWhSZ2JRMDM5MjFKZ0paYXppeXJLVm0v?= =?utf-8?B?QzRPS0JuUzNLUDdnMkNaaUZaZlVYSnJuL1pCOEpJZU9pUzVmZUM5UGZBRWZn?= =?utf-8?B?NkpqM2lmdjA3RjRZRktVSGZtS0g0ZVplVlZ0UTh3eE0vaks2NUhkOFNzdVFm?= =?utf-8?B?SWJWZDUwV0I3c0RlNmhhUXVhVUMwbHpnRllCeWRaOHRTbWZpdDFSY0dTR0c4?= =?utf-8?B?ZEdhZ3ZhUXVnSGs2Z1FWSytnV1ZnRXkwUC9nT1B4bDk3dFcyNllXS1ArRW1n?= =?utf-8?B?Lzl3dlNYZEZvNVF5NVM5dis5K1c1UDUrRHBHM1ZyWVVaazlFVlNhdWdaVGtz?= =?utf-8?B?VjBhMEVDZzdJWnZwaC8yUTB6dytuKzZxOHR5a0cvUmNYNnpuRnV0RU5nODV2?= =?utf-8?B?citGQyt6UnFvVkhCcnhaTHVZc25yaVhXYmpGWU5CZlRLWHMvanEyQm5takg1?= =?utf-8?B?OFJTSStCZmxpVERDNlpnS0ZEU05aZExQRDJXa0JOcytlM0xPRitic0ZXRDlZ?= =?utf-8?B?VExSeTRnS0hLNFZTeDZjMUlCeUhpWVl1Zy9mUVFJNm12RnMySm5tMk5yYkls?= =?utf-8?B?cDVZRmNSZXRYcjBoWlMxVUpjSDJPRGovRXZDMFNZNHVqT2x6K3F5d3VrYnVv?= =?utf-8?B?NUJJUkVvSStWRVR4dGY1Q2RRM1g3ZWlGcms2TDNKbzFSeHBRVzIzdHNxbWk4?= =?utf-8?B?VlZBeEFPSTJGUDBFN3JtTmFuZXdIR3Jvd3dQc2d5ejdsY0hvTTY5cERPUlE0?= =?utf-8?B?b1o2MFVQZ1ZtR0VpVzZDNHVvRHE3enhHcW9OVXdGS01NNENmVCtNdHF4aUJt?= =?utf-8?B?amkzVG1FYmJkNnpJQTc0d2FGdVp2N2tvb3p5OGJJbDVjaGp1dHNmdEIwSEl3?= =?utf-8?B?ZnBJRDdpN0pTSlpsYUdIQ1NOdmVUNm55NU8zc3V2M24yUzFMY0xVUUhiNlRQ?= =?utf-8?B?bC9IK3hlcURWNGprWHRPdUhDSlNoVWJtWTR4VFd6WUJNWEZqeXVYSklLdzY3?= =?utf-8?B?cGtzM2U0NHNKNXhkbmcvUDlKay9MMHdGUTZvRnpscUpIdGZvTVRvSGJ3cjcx?= =?utf-8?B?Q015KzNTMVNOa3hpRWVqWENvemV5bXM0ME1lWlczNFhtUkp3dEg3bkdhUjFT?= =?utf-8?B?Q0hjN2VualRFdlc3RTVJSUJQR0hDUExJUW1ncGZ1N2xhYkY5b28wUVg0UlV0?= =?utf-8?B?dTBrYXRKZWhwNVpNd3Z1eFRxakpUczVXUnZsU3pTK0F1bmthckx0cXpVNCtK?= =?utf-8?B?ajRKZEFLVk8zbFRYemRNU1NzZ1NRdm5mdFNGVmVXVjJJcmRMeDN4bTNwc2dP?= =?utf-8?B?UVlDUkRMa3RycTZhYTNOZWFtckRCRUYwZ3NKZEdwT2FKQW1Qc1ZPOFRlSDN2?= =?utf-8?B?d2drMTNxZ2lUaDlNT2IyL1RZRXd4Mzd6c3FmVzJpaFk0SHlhSEExb0t5STBX?= =?utf-8?B?eWhDc0dhZ2N5SWpGUUlpTGhoSVdkVmFFZ3F4U1djcmFFVCtpbjhVd1AvOWhB?= =?utf-8?B?YTI0cDNQT0FXQ1NiKzNSOTA4eEdRRFhwTmFSZTZTbnBkMEozOGttT24wcVZh?= =?utf-8?B?TE45L2wvTTkraHl1blRrdGdVaWcwaWlQQkF0MnRvdWk5V0VIMVA2V1U1Nitm?= =?utf-8?B?NVB3LzJBTSt0Zjk0UHBNMThnSXFSRUd1ZDNtYWFNekxrR0g1Wms2OUdKYWVk?= =?utf-8?B?MS9xSTFpcWh0T05SbkNlbHNqZHZyWGFjbWtjaFlvSzZvbTJVUXl6TWZrRHJT?= =?utf-8?B?UTF0MG9ocitDSXpWOUxaWUd6cFQyNnNpS3h3SnZxNlNUYlB0eTNpOU9zeFlw?= =?utf-8?B?aXZRN1UyM1dueVZzcEd4UUM5OTBDVkp1WnNPU3JwQnE5Q0dha3kvWFh1Y3gr?= =?utf-8?B?OTBvcXltcjNycHRFOThLNHo1dkdYd1Z2WlNvVFI5cmFrdUh3ZWhZUTN0Slkz?= =?utf-8?B?bW45N1JKK3FZRCtYK1NWa1AzekhMVU9DRDVzWXlBVVpTZjhtaGpwa1BaeFRE?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pOAOaR6KuVt9GDRre74NxYka3lbzzaktrNsYfUF8tATjXZaxKN++KsBDSZijBE+7luVkbP1OEHCPvA1DT5KffvB+xP28jCC/wgOLzB/vmsgb+kguit9NnvoFaYy1P1trezpN4khr5QPW8oNVK88s43ggddm0rJCpNe6JkrEkMct48Z5o1AZXAozMd0OrfZoAKTMMAqCdUq4XekBWv9FJznmbIY4Q8n9wGDuWoxXWg/nLIU6Qui+pnta4OcE2B6Y7PyWLfuxbTsHEW30YigcsfQrFmi8fcNn+OifUkgJJY7/qhdM5aa3VUgc+KBXFdhU5afKsUbm5wmKfb7CPd7lunv/J51u6xz7dL0zYkOwX8VNsgkvxa7Qy1b8of2nyTmmi58vWdRnA03VWlPmW4pMq+HM5+JoxDt/hNXEOohucYzQJPrLYoElAp1o923GRdrVZGyNXNhZZWxbIhO22Oh0Ezw6Jx10Hlz4uoBUvIIrmDJ9cd2AsjI9BuAsBGf1VNcm5A3MpfJpJxqoJNa2/1pXuI4joGaZlMFROSY77lVfydP6DaL73nVjKGGjqDbCu0TYo7aqnCw5wQOydzfuv/SGaNx3YtE0xOjj4I8iidJhoyKY8hWsLQkyE2S/Tj/xA3w6xrtg+AiMPR8hMGPyfxPO2rll8swr7qNhsWEI/4xkjFOwkGZvQS64MtPECTvr0O/dWYpJtEMAuWw/IdkJptUhpdQsLk27jkOZeYHkeCjHdlQX9gdGpF4FqiE18qnXVx6vctwztt8tc7IYaCge9k+DXftYJwKs47q0PexchIC9asarNPLvWwlkcX/XqbbpdVh6Xxa7ym1RQp2bSfdqreGJPmj34TQL1jG5QH/FBC5qWQg8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52472e18-9eb0-4377-1b02-08db0fbbd12a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 01:19:14.8992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0tZwjEZxsNA8l5SM3ZNBu8scU0xufyqwI6bNG+xFJ0ZwqpY834N/aDB9NXXWgqhy4/UMt84JKG8sO/IkZv7EwK+ftSb4CC0QA04W10cMEDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7174 On 14/02/2023 3:38 pm, Michal Orzel wrote: > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index f8e156e0a994..079e9b73f659 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig: > HYPERVISOR_ONLY: y > RANDCONFIG: y > > +debian-unstable-gcc-arm32-staticmem: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-arm64v8-arm32-gcc > + HYPERVISOR_ONLY: y > + EXTRA_XEN_CONFIG: | > + CONFIG_EXPERT=y > + CONFIG_UNSUPPORTED=y > + CONFIG_STATIC_MEMORY=y This is absurd.  Either 1) static mem is important enough to warrant testing.  By adding it to CI, you have caused the maintainers to accept the responsibility of fixing bugs found in it, making it by definition supported, or 2) it is not important enough to warrant testing, at which point it's not ok to be using XenProject's limited testing resource like this, and it's not ok to be a blocking test. There is no such thing as an unsupported feature running in CI.  It is a complete contradiction in terms. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 02:56:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 02:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496322.767007 (Exim 4.92) (envelope-from ) id 1pSURO-0004xK-Ky; Thu, 16 Feb 2023 02:56:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496322.767007; Thu, 16 Feb 2023 02:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSURO-0004xC-Ek; Thu, 16 Feb 2023 02:56:10 +0000 Received: by outflank-mailman (input) for mailman id 496322; Thu, 16 Feb 2023 02:56:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSURN-0004x2-O7; Thu, 16 Feb 2023 02:56:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSURN-0004O1-L9; Thu, 16 Feb 2023 02:56:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSURN-00085k-7t; Thu, 16 Feb 2023 02:56:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSURN-0007uS-7M; Thu, 16 Feb 2023 02:56:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MTQcYFLJeF7hzwUC1DkZ333ChteQvjZRAydVFcNSWag=; b=VXWylUKN4dKyfN0LlFnh8eQp8H zBAm/WNb0EYxArmBnxyFKmNwgG2NbJeKbQc5otdkumI1D9s9JrNHy/1OxJPgikeLDx3uSe7WXpuXg +ZWcvgJnasrCyTf6L7fwZHlPcWbojSpWtXX+H6rhJ0AqRtSp9w+dNi3cBRT0tBN01UB4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177400: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=e1c04510f521e853019afeca2a5991a5ef8d6a5b X-Osstest-Versions-That: linux=82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e From: osstest service owner Date: Thu, 16 Feb 2023 02:56:09 +0000 flight 177400 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177400/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177298 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177298 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177298 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177298 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177298 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux e1c04510f521e853019afeca2a5991a5ef8d6a5b baseline version: linux 82eac0c830b7d917bd2a8806eb6ed21ef1e0f84e Last test of basis 177298 2023-02-14 17:43:56 Z 1 days Testing same since 177333 2023-02-15 01:14:13 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Manivannan Sadhasivam Rafael J. Wysocki Viresh Kumar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 82eac0c830b7..e1c04510f521 e1c04510f521e853019afeca2a5991a5ef8d6a5b -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Feb 16 03:28:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 03:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496332.767017 (Exim 4.92) (envelope-from ) id 1pSUw3-00018B-3n; Thu, 16 Feb 2023 03:27:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496332.767017; Thu, 16 Feb 2023 03:27:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSUw3-000184-1G; Thu, 16 Feb 2023 03:27:51 +0000 Received: by outflank-mailman (input) for mailman id 496332; Thu, 16 Feb 2023 03:27:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSUw1-00017u-Rv; Thu, 16 Feb 2023 03:27:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSUw1-00055c-NB; Thu, 16 Feb 2023 03:27:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSUw1-0000wT-9K; Thu, 16 Feb 2023 03:27:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSUw1-00027b-8q; Thu, 16 Feb 2023 03:27:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p4mnLrv0+EFifjwZZoPeYoMxIUWhSil7eDxdWuS2aVc=; b=cHcfXXFJl/TD7EXT9RZPOn0do8 fxwilNVVSR5XMN/3S5oKqKUXM7TF5e9uMkq+Qc13WX38cyyXa+y1Js9DDgzvSaw2A8mjdw6p5ucGL Aw+EGOqe5MBvxU6RJORr7zSeEs3Jbe54j68KzfE1I+B6zzWJ9YNBKwJ9Y0GF2UL0QqMU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 177405: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:heisenbug xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d4e286db89d80c862b4a24bf971dd71008c8b53e X-Osstest-Versions-That: xen=1b6acdeeb2323c53d841356da50440e274e7bf9a From: osstest service owner Date: Thu, 16 Feb 2023 03:27:49 +0000 flight 177405 xen-4.16-testing real [real] flight 177446 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177405/ http://logs.test-lab.xenproject.org/osstest/logs/177446/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 177446-retest test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail pass in 177446-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail in 177446 like 176835 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176835 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176835 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176835 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176835 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176835 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176835 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176835 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176835 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d4e286db89d80c862b4a24bf971dd71008c8b53e baseline version: xen 1b6acdeeb2323c53d841356da50440e274e7bf9a Last test of basis 176835 2023-02-10 08:18:57 Z 5 days Testing same since 177405 2023-02-15 16:37:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1b6acdeeb2..d4e286db89 d4e286db89d80c862b4a24bf971dd71008c8b53e -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Thu Feb 16 04:19:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 04:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496342.767032 (Exim 4.92) (envelope-from ) id 1pSVjf-0000BE-49; Thu, 16 Feb 2023 04:19:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496342.767032; Thu, 16 Feb 2023 04:19:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSVjf-0000B6-1Q; Thu, 16 Feb 2023 04:19:07 +0000 Received: by outflank-mailman (input) for mailman id 496342; Thu, 16 Feb 2023 04:19:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSVjd-0000B0-2F for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 04:19:05 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 094c7942-adb1-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 05:19:01 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 20:18:58 -0800 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 15 Feb 2023 20:18:58 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 15 Feb 2023 20:18:57 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Feb 2023 20:18:57 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 15 Feb 2023 20:18:57 -0800 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by CY8PR11MB7780.namprd11.prod.outlook.com (2603:10b6:930:78::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 04:18:55 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::6a8d:b95:e1b5:d79d%8]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 04:18:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 094c7942-adb1-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676521142; x=1708057142; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PYDfitEMywGBaLzakjBxcuWr21VGCwKT4RaKfk9/m60=; b=O2jjS892gDwtI4iURZqY5P2x3RIBZ5pLZlCy8QLhkxWGrOd9Xj2f6Idt bFaFKNJRK85UzJ0KsHflJA9YKVOtntbRnpxGjrehmDKi/z0A7Tt5efq90 i50XKhpDGQst1ABQu1ll/zfQeR8Rpr2wwdtvqdMGG0eZBsDZASqoRciXH gP7CSOVQW/NDzmmpi7wYB8bMYFMAz7/iUu4fVXGccxG5pQAslcKoSn6fK 0FfUMqb2wFBi8AJ8Z2JjDAQZHEk2B2IEPEpxS/nmxZL7T66Duy+QkdyqI PyyD7pzr2kcdOjwMS1TWCRgrI91OZKQmsFs5qDw8ru2fHyPhGRzz4ZHpL A==; X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="315293999" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="315293999" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10622"; a="793884039" X-IronPort-AV: E=Sophos;i="5.97,301,1669104000"; d="scan'208";a="793884039" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThAIFuW1HZ6YCFSNob9nDUzHrjDCTEnIVZvTGJx+KojSp9nR5kfZJ21RJ/N250a7veY9v/A4U4XmGNuvVjZAIJgY3hyG0o/AZ4sZNLEw7hRHB6Ki4RTXw0+87i03wp4XoqJqB8efS6iGea6GWD3XhXYVMib+NLi6hAjODOBVFJw9+At1maBGBgwQu4di1/j4zRjVef1VtIgd6v6hDuNJbllVwS0U27k8VLeWnr7TcLrLTs4rMCJea0/l2zyVA4xW/AGBBbdQPa3SP3PAIWRxBsjWe3sGyzjxpi8ykl/e1ghjaaErBaJypdItmJX8W+ebVeMGLWjjFgjJ8Y1+jZb1Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PYDfitEMywGBaLzakjBxcuWr21VGCwKT4RaKfk9/m60=; b=Ye1dbIgLQWCb66/lvaQwZt5sY81erq3LVC9qrYznDuhheC61/0QmGeDAydHHLhKHmvaFbSvpgojC/G3JT4Nr7vr5iYD8sdJLSR95srOGEqxl8VTHvlvmrvOwIV+yUCbv4Y1q5jGs1f9hdS8Eew1wVuXnJAMbPjAPr3PJn/Az0ywSX5UuJExE9ejF3t0/7N/xD91fH/5cbwv6MZqsEAXDdQTn+5ywdF4IOlDY9stZyRnb1xF344u1+8SCSYv07qitOTilTJyoE+8droXFmrIKZU+e7KZWqMEE8m28wPTeMxQqDtbiYZyuDnejQpyppqrmbddv5QOdaN3NlZ2OtnjZpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: "Beulich, Jan" , "andrew.cooper3@citrix.com" , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , Wei Liu , "Nakajima, Jun" Subject: RE: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Thread-Topic: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Thread-Index: AQHZP6FixcPovaFRKk6HAi1Mi8oY2a7Q/Cog Date: Thu, 16 Feb 2023 04:18:55 +0000 Message-ID: References: <20230213115017.902037-1-burzalodowa@gmail.com> In-Reply-To: <20230213115017.902037-1-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5276:EE_|CY8PR11MB7780:EE_ x-ms-office365-filtering-correlation-id: ac2d166e-9d56-4855-c82f-08db0fd4eaf6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WY7kO272tbsFQuZJilfYeAjBGElAJH6HQ4BSnB4HGZbDJ1vWwiMVBmmfr+hqs+bsYadc2dzdG7n4tB7HMsbHQKGRxfYJHmyrBrNxLzXfZHmEPATx24qCO4mA54rKYlIQD0+wMDdTT8sA1w9GC7rTqc6J7MTQZMUwDxIaSb5hp/vqQuJ58wgD1BmgYyTxjaSCuGcKrPQj/HGI0KnuS8NgFexrm8GqQUGUVH/WWVc/rTnl5EACywHiLxUabEKNaK3SBMHALsbx4aUO7ZCwcXKtBXl8lT2l9XTuTJvesKn3/uow9KpaQlybj5xsrlxAuLQKm62PWiUqTuZU8qOsF7+Xcp0SKvFNpko1flZDd9aFMjrL2cerI8EsbkwfrKTK3cTcWbjZqU+ppXb/wYXDuibKqRcAMWhaj/9NU4arfKWJit9CHhPTxfRDpblY1flTPaDMfJPGVv1Azpzlkow2akPIwKTPlD4n/DQeGf6hRKJNuxRFE+57pSWYi8GNoeujUWxpUM2Ky0Niw9sHGizJVuxqFQSmncRD8/H0g0HwrXO64A2wgFpN+YFpAt//d7w0zoCCS9iQXVKRnmzrPWb9ByJXBHWNMj9aWN9CjAJHgAxy+QeVkT/IyDuRZYXo48AYxdjFQFVuv8YRAfWg+JSFQ69iVdBU4I1/dcam9lpIvMZMmZL5aoWuusdqGeXFTqmoqzmm6E2faZPO2xxgMqJfYSIeAw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(136003)(376002)(366004)(396003)(451199018)(186003)(6506007)(5660300002)(52536014)(26005)(41300700001)(9686003)(107886003)(122000001)(86362001)(38070700005)(82960400001)(33656002)(38100700002)(8936002)(55016003)(4744005)(2906002)(83380400001)(71200400001)(110136005)(7696005)(316002)(54906003)(478600001)(8676002)(4326008)(64756008)(66476007)(66556008)(66446008)(66946007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dFVFSHNra0VLZmV6b2VZSkdGbldHYzlHRzRQY3crNkZoamd0WHkyUjBTcVhm?= =?utf-8?B?UFZ4K3Y3MVBVQ1I2WUdRSHJDMjZCSTZoRVk2ZkQzSXVDMjhhbnlpZndlZ1Vv?= =?utf-8?B?WkNaQ3NUTXJEUWtBSjVXSEpYcXNsK08vR0JjYUtTYlZxNG5ydlNxWXNyNVli?= =?utf-8?B?a1FXcFFhYXlYWGdyQ2IreXlELzRHS0x2R3dXTmVqbzd4SkFreit6bmlaUXVm?= =?utf-8?B?a2Q0cHdadlRZT0dqWWJ4VnRuTS9JSmxwWGtrL21aeGorMXBDS3N0NDJ4Nlhv?= =?utf-8?B?U0E2NmwxTVYzVDROSmplZWtSVkd4WWUzN0ZWVHhBMWQvQlpZWnl3NDhvempz?= =?utf-8?B?MU1SZkFOemhzakV4andUTXNHNnEzZEFVYkE2MXFLVmJUR0hIV093K0RRRzBH?= =?utf-8?B?UHJtVTRncUZhcEdOYUVuZVk5TWNQRnRxbEU1azMxcUkzLzJaanNGZmtSSHNl?= =?utf-8?B?eHl2NGxVbW9GU2dYazhvUTFiMlZyZGhIczBXZGNzSVlaaWhPMHJFY09KZzJo?= =?utf-8?B?eVhtaEY1emhxTXQvMjJ5aFRRTTZpR1djZlJEaVRydjZJRURFYXY0a3JSNjY0?= =?utf-8?B?RUh3VjJaU01BUEtxYU9TU2xmZFJpdlZtS20xUDdpZEdSTTlsbERQSldpRjlI?= =?utf-8?B?UVFjb3FiNTFCUW84ZmhpZ25lWTBwRHVJQW1KVXVySTBpUm1LVjNoOWZnTWdZ?= =?utf-8?B?Y0JpZnY0Q0g4cXI5RnJyQ3N4eDZKWk11M1FJVXNEeGFNUVVUWkxUVHRERmNQ?= =?utf-8?B?aHRLekY0RHpscGRxR1dNa3psWWRwWGhscWdaY2xibVNRWTh4NExUS2ZDT2VQ?= =?utf-8?B?TmluQ1FDcFhHUnREU1plZFQ3bjVuZS9DdTAvQU5GNEJOUmlhZDEzMkJnbDIv?= =?utf-8?B?ci9XWWtLT1NnaEh6cmtoc1ppczV0cmcvbmdvY2ZSY0prRDV0Rkx1c1A5aHky?= =?utf-8?B?MnFGZDY5UEZOQmY3QWcrVGZxMUpIdTRKMEFBVDNUYWI2NWZuZ2Y2aU1SdURI?= =?utf-8?B?WEJ5WTFxR083K0ZxY29jNGN2MEpHK0hrZml1em0wbm1ZaHhkWFlhTXd0bXlG?= =?utf-8?B?cjJSeW0vczM3WnFMU1JNdkQ3VlkzbU8xS1Q4ZGoxZmFDRSsvbjl1bHJwNjIv?= =?utf-8?B?bGp2cEp3MDdRQ1JZb1BLR0xma2Zkc3JPQjFyR0hQc2NkSXpVclVzNkxEemll?= =?utf-8?B?SXdoQSs1Vy96UlJzYk5IU21aSE51eVMya3VEd2ZYeDNteG1LR0luaVVOQWdE?= =?utf-8?B?QllLOXF1Y0E4aERRNGo0OVF0TzlUbHh3cEZPREhuclRwenhtcmlkcTRVSGkv?= =?utf-8?B?K3dML1ZGL2crcURwZy8zTnJKZzdMVjlrRTkveXhQVG81YWpjak9IbVFXR3FT?= =?utf-8?B?enR1b2U0RlFQZ2NhS1lVc2pkNENKeHcvbXJ6N01qSGtZZjZxcWNXMUJNUkdD?= =?utf-8?B?UDFEVHl3SUF3QVdhK1FqeFUwamlOZXdXWGROQTRBWjBhQlFmRFpkRkVBTTJT?= =?utf-8?B?R2taMVVTS1RTQ2xCNmFFbUlueXFvNzFhNmF3Tkc1SllVbFRtK3M4enZhd3pk?= =?utf-8?B?bVdJZEUyVEM4YXBnMUdOVUpzUHFOOTg4RmtieVJMNHJsL3FBUXhJRzRubnAr?= =?utf-8?B?VVhiOE5iNk5uZFB2YmVTN0FDQlNsdHhjaUdNMHR4MWF6OUFzcEQ0OElUeHpy?= =?utf-8?B?c05vRHdKMnpiNXljWHJRblRXRlNWNVoxeXhHdzhpU0ZLajhWS0JqZExNdEsr?= =?utf-8?B?SlBScWpkcHhBdlJtdk9hcDFSbWxVMU52MXNiUkJFOFR6NXpqblF1RmpmOFl4?= =?utf-8?B?ZVpna0U0a2p6TTh0ck5lUVhnejZsT0szeG56YnpML3pacEYzK0ZjbG9DNEpl?= =?utf-8?B?cjVJK3M2dTlZYWRmdlppWWpyeTNNOW96c0xyZWVYWGdKZklYNlJ2T04xZElx?= =?utf-8?B?eWg0TXRsWWhIcFYxc2tHbDhiUnB5bStZZU80bVQ2d1lvNjlBYTk3a0tvbUZZ?= =?utf-8?B?NEY5WGNzWE5kWTBiVTFsTytSQ2s3M2VaKzJZUW1oNjBSWDk5dXQvVnl4UUNr?= =?utf-8?B?ZjNiaUhsd2F1UGJiSXdBdFkzRjBGUTlDVXJyYS9OL3liOVVzZ3RQN20ySy9l?= =?utf-8?Q?5N1m3jeEowQsYczECu8KvVDLh?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac2d166e-9d56-4855-c82f-08db0fd4eaf6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 04:18:55.1956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1R8fdEPRWLwV8BO83OJd1/ForBxOSst34awm35u3ejiIa3xknYoLK7dhNkgFX2wKZuc1c8e+xxKXyo7uUwvQkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7780 X-OriginatorOrg: intel.com PiBGcm9tOiBYZW5pYSBSYWdpYWRha291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+DQo+IFNlbnQ6 IE1vbmRheSwgRmVicnVhcnkgMTMsIDIwMjMgNzo1MCBQTQ0KPiANCj4gQVBJQyB2aXJ0dWFsaXph dGlvbiBzdXBwb3J0IGlzIGN1cnJlbnRseSBpbXBsZW1lbnRlZCBvbmx5IGZvciBJbnRlbCBWVC14 Lg0KPiBUbyBhaWQgZnV0dXJlIHdvcmsgb24gc2VwYXJhdGluZyBBTUQtViBmcm9tIEludGVsIFZU LXggY29kZSwgaW5zdGVhZCBvZg0KPiBjYWxsaW5nIGRpcmVjdGx5IHZteF92bGFwaWNfbXNyX2No YW5nZWQoKSBmcm9tIGNvbW1vbiBodm0gY29kZSwgYWRkIGENCj4gc3R1Yg0KPiB0byB0aGUgaHZt X2Z1bmN0aW9uX3RhYmxlLCBuYW1lZCB1cGRhdGVfdmxhcGljX21vZGUsIGFuZCBjcmVhdGUgYQ0K PiB3cmFwcGVyDQo+IGZ1bmN0aW9uLCBjYWxsZWQgaHZtX3ZsYXBpY19tb2RlKCksIHRvIGJlIHVz ZWQgYnkgY29tbW9uIGh2bSBjb2RlLg0KPiANCj4gQWZ0ZXIgdGhlIGNoYW5nZSBhYm92ZSwgZG8g bm90IGluY2x1ZGUgaGVhZGVyIGFzbS9odm0vdm14L3ZteC5oIGFzIGl0IGlzDQo+IG5vdCByZXF1 aXJlZCBhbnltb3JlIGFuZCByZXNvbHZlIHN1YnNlcXVlbnQgYnVpbGQgZXJyb3JzIGZvciBpbXBs aWNpdA0KPiBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbnMg4oCYVFJBQ0VfMl9MT05HXzNE4oCZIGFu ZCDigJhUUkNfUEFSX0xPTkfigJkgYnkNCj4gaW5jbHVkaW5nDQo+IG1pc3NpbmcgYXNtL2h2bS90 cmFjZS5oIGhlYWRlci4NCj4gDQo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29t Pg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Feb 16 05:36:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 05:36:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496350.767044 (Exim 4.92) (envelope-from ) id 1pSWvh-0002P7-RH; Thu, 16 Feb 2023 05:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496350.767044; Thu, 16 Feb 2023 05:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSWvh-0002P0-Oc; Thu, 16 Feb 2023 05:35:37 +0000 Received: by outflank-mailman (input) for mailman id 496350; Thu, 16 Feb 2023 05:35:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSWvg-0002Ou-CH for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 05:35:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id baf0be26-adbb-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 06:35:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 483481FF61; Thu, 16 Feb 2023 05:35:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4F2C13A26; Thu, 16 Feb 2023 05:35:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NcHCJqPA7WMyTgAAMHmgww (envelope-from ); Thu, 16 Feb 2023 05:35:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: baf0be26-adbb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676525732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G6KVzt/M6du488H+frf1ioxhNrIj4VV3NUSS1K7UwVg=; b=KUic2fQWikvwmcsRqXcn210CqLceiRP5MGg9IGqK3SvyqR46B3+F7ApGsKYLZp3VAzgDL6 EsGJQZRJ190JAYs/iZtDZVeVCxX0fhx7U8RS80kKa/2vjSyU8u5XgttRebskf6Y3bcJbZu BQFCnMoxHVBxtdgR52hkpuA4r8+O5zE= Message-ID: Date: Thu, 16 Feb 2023 06:35:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Linus Torvalds Cc: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" , "Ostrovsky, Boris" , "peterz@infradead.org" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" References: <20230209072220.6836-1-jgross@suse.com> <51a67208-3374-bbd9-69be-650d515c519f@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YKwwJCQbPzGtuJPV0v0m0ee8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YKwwJCQbPzGtuJPV0v0m0ee8 Content-Type: multipart/mixed; boundary="------------DmHZP3C4bBUlqODfBhke002u"; protected-headers="v1" From: Juergen Gross To: Linus Torvalds Cc: "Edgecombe, Rick P" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" , "Ostrovsky, Boris" , "peterz@infradead.org" , "tglx@linutronix.de" , "kys@microsoft.com" , "dave.hansen@linux.intel.com" , "lists@nerdbynature.de" , "hpa@zytor.com" , "mingo@redhat.com" , "wei.liu@kernel.org" , "Lutomirski, Andy" , "bp@alien8.de" , "Cui, Dexuan" , "mikelley@microsoft.com" , "haiyangz@microsoft.com" , "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR References: <20230209072220.6836-1-jgross@suse.com> <51a67208-3374-bbd9-69be-650d515c519f@suse.com> In-Reply-To: --------------DmHZP3C4bBUlqODfBhke002u Content-Type: multipart/mixed; boundary="------------gm608TjOsxg4CvHzaDMSqB0Y" --------------gm608TjOsxg4CvHzaDMSqB0Y Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTYuMDIuMjMgMDA6MjIsIExpbnVzIFRvcnZhbGRzIHdyb3RlOg0KPiBPbiBXZWQsIEZl YiAxNSwgMjAyMyBhdCAxMjoyNSBBTSBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ IHdyb3RlOg0KPj4NCj4+IFRoZSBwcm9ibGVtIGFyaXNlcyBpbiBjYXNlIGEgbGFyZ2UgbWFw cGluZyBpcyBzcGFubmluZyBtdWx0aXBsZSBNVFJScywNCj4+IGV2ZW4gaWYgdGhleSBkZWZp bmUgdGhlIHNhbWUgY2FjaGluZyB0eXBlICh1bmlmb3JtIGlzIHNldCB0byAwIGluIHRoaXMN Cj4+IGNhc2UpLg0KPiANCj4gT2gsIEkgdGhpbmsgdGhlbiB5b3Ugc2hvdWxkIGZpeCB1bmlm b3JtIHRvIGJlIDEuDQo+IA0KPiBJT1csIHdlIHNob3VsZCBub3QgdGhpbmsgIm11bHRpcGxl IE1UUlJzIiBtZWFucyAibm9uLXVuaWZvcm0iLiBPbmx5DQo+ICJkaWZmZXJlbnQgYWN0dWFs IG1lbW9yeSB0eXBlcyIgc2hvdWxkIG1lYW4gbm9uLXVuaWZvcm1pdHkuDQoNClRoYW5rcyBm b3IgY29uZmlybWF0aW9uLiBJIGNvbXBsZXRlbHkgYWdyZWUuDQoNCj4gSWYgSSByZW1lbWJl ciBjb3JyZWN0bHksIHRoZXJlIHdlcmUgZ29vZCByZWFzb25zIHRvIGhhdmUgb3ZlcmxhcHBp bmcNCj4gTVRSUidzLiBJbiBmYWN0LCB5b3UgY2FuIGdlbmVyYXRlIGEgc2luZ2xlIE1UUlIg dGhhdCBkZXNjcmliZWQgYQ0KPiBtZW1vcnkgdHR5cGUgdGhhdCB3YXNuJ3QgZXZlbiBjb250 aWd1b3VzIGlmIHlvdSBoYWQgb2RkIG1lbW9yeSBzZXR1cHMuDQo+IA0KPiBJbnRlbCBkZWZp bml0ZWx5IGRlZmluZXMgaG93IG92ZXJsYXBwaW5nIE1UUlIncyB3b3JrLCBhbmQgInNhbWUg dHlwZXMNCj4gb3ZlcmxhcHMiIGlzIGRvY3VtZW50ZWQgYXMgYSByZWFsIHRoaW5nLg0KDQpZ ZXMuIEFuZCBpdCBpcyBoYW5kbGVkIHdyb25nIGluIGN1cnJlbnQgY29kZS4NCg0KSGFuZGxp bmcgaXQgY29ycmVjdGx5IHdpbGwgcmVxdWlyZSBxdWl0ZSBzb21lIHJld29ya2luZyBvZiB0 aGUgY29kZSwNCndoaWNoIEkndmUgYWxyZWFkeSBzdGFydGVkIHRvIHdvcmsgb24uIEkgd2ls bCBkZWZlciB0aGUgcHVkX3NldF9odWdlKCkvDQpwbWRfc2V0X2h1Z2UoKSBtb2RpZnlpbmcg cGF0Y2ggdG8gYWZ0ZXIgdGhpcyByZXdvcmsuDQoNCg0KSnVlcmdlbg0K --------------gm608TjOsxg4CvHzaDMSqB0Y Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------gm608TjOsxg4CvHzaDMSqB0Y-- --------------DmHZP3C4bBUlqODfBhke002u-- --------------YKwwJCQbPzGtuJPV0v0m0ee8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPtwKMFAwAAAAAACgkQsN6d1ii/Ey9u Swf+O1os54HshD4sOldY+rYmr6S3inwHW4nfOwo1eFXH0e7c7tFQ3NOtwdYtHBvBMCYImcPreoh+ 6k0TQg94jQZB+5H2vqQs5xPtc0QNEgMGzSfSO0aLxvkLxDzHX0NgRR3hcXxoRQDNr79RbC4GE0F6 PLz8JScT6Pcnf3TE9ozBfc1gRc5wkvanpcn93mvhlGeo/sWJ3k5gyL+zzSGzEDyeMInk+BT91za4 BR9F/JGLFn1D9RTkc7ZgCv304PSTjoc9fYgXuuFkVv3iZKqskcHKI+BU9ZrHiPHHkwihv7kx735Z nTOD+WQ4k5wc5I77gy0vk4mIDcpoWp5LMCQARYS5Og== =ykA5 -----END PGP SIGNATURE----- --------------YKwwJCQbPzGtuJPV0v0m0ee8-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 07:27:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 07:27:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496357.767054 (Exim 4.92) (envelope-from ) id 1pSYfA-0008Mj-UQ; Thu, 16 Feb 2023 07:26:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496357.767054; Thu, 16 Feb 2023 07:26:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYfA-0008Mc-Rj; Thu, 16 Feb 2023 07:26:40 +0000 Received: by outflank-mailman (input) for mailman id 496357; Thu, 16 Feb 2023 07:26:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYf9-0008MW-LF for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 07:26:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f6d37ac-adcb-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 08:26:37 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 06BB422090; Thu, 16 Feb 2023 07:26:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D6E0B139B5; Thu, 16 Feb 2023 07:26:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BsLUMqza7WM3cgAAMHmgww (envelope-from ); Thu, 16 Feb 2023 07:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f6d37ac-adcb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676532397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1zScftEK3EXkswhkKNpcMda8aevEmPfU50wzYJsnE3A=; b=o01Lj4kjm8/3Yx/BKzfflMl6vqOuOZKqM8FPuXQSa/R+p65K9p638QMWAkB/K/CCvUetWH wXUygf6JXUCWvD4y+DeNae52FTDJE7a45MbnJhMpGcanT8maaJ+tL8j7Ujq0PRXzLQ8aHA tUgJLdTsykkVgjCc2eX3cic69m0aRGQ= Message-ID: Date: Thu, 16 Feb 2023 08:26:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] x86/Xen: drop leftover VM-assist uses Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky References: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> From: Juergen Gross In-Reply-To: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Xo1aTUBgkx4a9n87pD5cHrsv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Xo1aTUBgkx4a9n87pD5cHrsv Content-Type: multipart/mixed; boundary="------------PktKn5r160l5ZbZeE0CZDL0v"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Boris Ostrovsky Message-ID: Subject: Re: [PATCH] x86/Xen: drop leftover VM-assist uses References: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> In-Reply-To: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> --------------PktKn5r160l5ZbZeE0CZDL0v Content-Type: multipart/mixed; boundary="------------wU0h1ubPlvfGPRM4LLv9iYB0" --------------wU0h1ubPlvfGPRM4LLv9iYB0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDIuMjMgMTI6MjcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBCb3RoIHRoZSA0R2It c2VnbWVudHMgYW5kIHRoZSBQQUUtZXh0ZW5kZWQtQ1IzIG9uZSBhcmUgYXBwbGljYWJsZSB0 bw0KPiAzMi1iaXQgZ3Vlc3RzIG9ubHkuIFRoZSBQQUUtZXh0ZW5kZWQtQ1IzIHVzZSwgZnVy dGhlcm1vcmUsIHdhcyByZWR1bmRhbnQNCj4gd2l0aCB0aGUgUEFFX01PREUgRUxGIG5vdGUg YW55d2F5Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t Pg0KDQoNCkp1ZXJnZW4NCg0K --------------wU0h1ubPlvfGPRM4LLv9iYB0 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------wU0h1ubPlvfGPRM4LLv9iYB0-- --------------PktKn5r160l5ZbZeE0CZDL0v-- --------------Xo1aTUBgkx4a9n87pD5cHrsv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPt2qwFAwAAAAAACgkQsN6d1ii/Ey/G 0Qf/ZNPjBmIIFM91BmSQ8nOcNEFYx5z15598uqefpW9faZqxJLfjg6EjpgVrDuOXBlEpZ87VnpZB LkPhSGC896Ep7UDkkR8OLuzkFwUbaFR8/3bYKtHJ195KY5eUTlvtunWI1p3FUyCfP7rH92wFcnbi L/0iKg0ipwopJK0W7s06oH5zUzHW3fBDSiFyrv7ctj8QDOjfXwTa1wFhpCT9stjp6Q97IKbj2ujv pdPfDIebwaYyI918U3qnHIHEdZl/czfAkjsNpPhw+a/tS9JGcwYe32FaAsSMir2s7K9LEKQsZMSj sUJLAfd1DjpFnNBxtY1h7lVxUOZeiyEMxkqXoYp1rw== =5mZz -----END PGP SIGNATURE----- --------------Xo1aTUBgkx4a9n87pD5cHrsv-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 07:31:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 07:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496363.767066 (Exim 4.92) (envelope-from ) id 1pSYk4-0001Ut-Hr; Thu, 16 Feb 2023 07:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496363.767066; Thu, 16 Feb 2023 07:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYk4-0001Um-Dw; Thu, 16 Feb 2023 07:31:44 +0000 Received: by outflank-mailman (input) for mailman id 496363; Thu, 16 Feb 2023 07:31:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYk2-0001Uc-J6 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 07:31:42 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20624.outbound.protection.outlook.com [2a01:111:f400:fe1a::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3fb42bd-adcb-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 08:31:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7064.eurprd04.prod.outlook.com (2603:10a6:20b:118::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 07:31:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 07:31:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3fb42bd-adcb-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGEWzQKziyK9Cao/KXPfVRdveZhJ3K/BSO54ZMGUldvMW4i5VKhW/Wnn08oJU09HXeojBKsI70j4G7O5/UlsuOz7ZMqXjzBcdLnVpPZh0WBpqhwz71Gcfp9MhHzyo1NUBA8iyuhMv2RSHkwL095dHxZFVrWvNeS+aoxm5CFx3gJqsKd0cvAjiQtROz2PF6CvtmWiBTDp8ELpFbxF/T78fp/idzj+lINByGwyf9TNO/dmaBhQ1mThRWLXPYaun+PuitkHE93cBv1ZOpAUYu9hynVtKzAFmc7L9IJ2v9hPeH/5AX0tGgLAw5e79LoGOHLhNhtUoPJP8WSk7WnBR3bw7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kFDPlnES46gaFrh3KpECNd/9vUfZejEdyF0UyGGB9KU=; b=QzXtOtIepZIcbLLKJYGbikZjw7fQ5cHASrufseNNhaAnlS09Jw11WBI2MD/nxlWZYIrmDU88MEOzyMovLNN05qiJaAYSwCQ+owYiawgtE3T3brln4UGx67rDb6UkcoIlg638Vj5xCkCqx4y5yjnr4FaylHKABRqaB2Md4XnbB+p925xrlnr25wZY0KfP938z8RKxZnsayjxSuuypAj3eSLz6yhJ+Wcckb4wNHAduvC5f1gA2wSG58u3sgzToT7RK5DQKqmrhZwMZDzkCxdm7Hl6E0W4yadDtznzJZWCpwtk3eZKeIbpr6Ti3PMSrebNBcBGfWXH9qBCKcfSeavM6XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kFDPlnES46gaFrh3KpECNd/9vUfZejEdyF0UyGGB9KU=; b=iqoZvxxDw91rnsGDfrZ573gD2x5yadL42tBLZldoZuu6Lpl5ehade5OUPijBj+jr8DCpxwb7P9CWbtK4YOaQBzTitZVmTOQFT6TBFfe7cP2Coic5Lzd0ta4INp+3o7128E73NQyg3vr25HgXb7n6weaCmnbXg3loPCXHxksGmGLQZeMWvsefkUofI/Sm2W7e4mX0xcnonq08jZvt8awzu164z+wd5sog57qtQjqGsTVKspyF1JzdreuuiBnpVtNc7XEcTHwKvBqn15Cfi5kUmtVyf0cO0Z6NqRhhzyx6Hu07YCU4sWTTmhgr7oo12I0QirMt0mZKwcpCArRWRvuwYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> Date: Thu, 16 Feb 2023 08:31:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> From: Jan Beulich In-Reply-To: <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0022.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7064:EE_ X-MS-Office365-Filtering-Correlation-Id: fd1e4a1c-b136-48c5-f720-08db0fefd6b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U5ZM/w6P6LtqFl+zXuXFIYptJ2i56X4FOzVddeOFtO5SqgDdz6FWzNl1pyKlFuzdL4xvqz0XLHx4q3AGE6vRAGSg3eQ6rIMMqnpi+IJrDRb3P/XLb21sdxmrk+hyM07MYkuDe13eBvvuXtJo5/xtzcphBRKTd18w8lOHQDeaS5S54S4Erqj/lQPSOIjXEsRrO7uTnJ/wA44f3i9JvZg0Pe+Ugc2SW1kv+imZU2Ac6iFHLPbY/CIKDQc3NewWrlR1Epjfg585iFJlJLLSwpmNql988E4ZzW0GBxJqYcqXW0Z1+lHc5Ilef7E0lnQCifEdRwiAzZdCe7rirEd0uGRqXIlcq6CNET1YRxQtiKrjh2Oyoms6XigHVtTO4+YTIrqaMV9qgDp1syqUAZNBHf+43cJpn34IDaV/8QCgiAhdFEs9Tgt+nO8GRFJLaZJA4T66SF1zNvscuevk3OhLxPjeAh8grxKkykxJNwFW1WhJW53nYL+gp0Al4yUuCIJv125wGgo8myGZxit2REXwZZHdhQ0p76QUNhzjpCjxHJ5XQkSzKYgjTiUgUFHBfz3AKNvPTE5dEeSX1U5RYDSmZcUlUH8lyr2lzC7p644QnvUe2wkW7XXhczPqeXegtXXzNnWafhZpWayxdUKDKLlKMMZxLrEDqTxmIyglVBUD06qJkmlFXqd/uBK5gScS9TrSlGrCYJLRTWDgaDcAgRhpmubg0cMSTlCdRVcvjzfn+qk0wKMyuYeLV6H69JEqSDE9uZ9P X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(346002)(396003)(136003)(39850400004)(451199018)(36756003)(5660300002)(86362001)(6666004)(478600001)(2616005)(6486002)(6506007)(26005)(6512007)(186003)(53546011)(8676002)(66476007)(4326008)(6916009)(8936002)(41300700001)(31696002)(66946007)(54906003)(316002)(66556008)(38100700002)(2906002)(31686004)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUZYSVFOblI3b1M1K1dsYVRvUUsxQ05obFdRdi8zQVhITWlYcGlBWjNlT3N0?= =?utf-8?B?VzFYS0RXeXFiNDQ4cjRmRzQ3WWRjdDhBQnRJVHRwajlqTC9DU2g2Q1IwNUx3?= =?utf-8?B?anFoK0kySXc2ck5RSnRhM2V1bkd2WkU2djZEQXFYTUdOd3o1SFNJQTNQZjRK?= =?utf-8?B?YnhhbnZhZVp0YUxSZUU0MEZNb2VydS8vL2plS1NoUUNSM3lDU3RoYWc0VmZ0?= =?utf-8?B?dmF2cFUyeUZZcysxcDFXMXc1d0JwK3dNSWQwWnN2amFqeGZ2SDZ2a0l6VnZp?= =?utf-8?B?V1FaSUxXMUhSNVdUd0NKQlYvRlBkbTlBcTNXVWpBOG1wV1JFbjJVVlVKR3pX?= =?utf-8?B?amgyK2o2SUZESU5uRTloYzNpVjdpay9GRFlacndzRXBLazJVdnVNRldwR1Ro?= =?utf-8?B?OVdxQm5nOUR2a2tMa2JsM2hUcHZhamFrc2FXdXovN05QTTNWMW82QTVJRHh2?= =?utf-8?B?aUlzNGxXKzdmVDVhQmxTNXQ1RC95TkxZZ2hhbnRoQnJYMllRcGFDY0FzMXZx?= =?utf-8?B?b0gzQ3NGaGxqSE5QU0M3bWhIbUhrcHM3NmNSSlhBZnpyRG1wNFVENG1wb0VB?= =?utf-8?B?ZnZjSE1qL3BicGIrV3ptdVhWTXNZVlNaZUp4cG13SmZLbDNQaHVoSU10WnFp?= =?utf-8?B?SkJMZGdhOVkxZkx0d1hqaHZsMFZNb0ZxLzBHSy9zMTErbGxQMXFkRk9sSTBl?= =?utf-8?B?YVJUS29HbFJtM1FXQ0NJZlozcHJCWTNreFlVTjJMeXFiVWNwSkV3eUZvNmNu?= =?utf-8?B?ZXZzKy8yd0F3S2JQWFZ3OGFCM0F1cUFrOGM1ZnlsOXIxa3ZjbmkyZGs1eWRV?= =?utf-8?B?WG9rcGx0bnI2S3NHRlpqb2c0WDVkZnJQR1NzSHFmVXRXOS9xVnNXMGxYYU90?= =?utf-8?B?blFtZUhBM1RncVF5OHRGVUxxL0JkYzRhcjNFQ0FLY3RBSFRuMHZKYm1uelh3?= =?utf-8?B?di9XcVEyWE9NdjhuS05Lc2dLMThuZ3pGWktRakhIdWMxZEJ3NXFWODZodjhw?= =?utf-8?B?L3Z2ZHR2UUt0TDhxSVFUVGJzRG9VUVRubnAwODhDZDdJUDFRK28yVTBaZUhZ?= =?utf-8?B?L2QxMmkzZkoxZEVWL0RGcHgvTThmWXRocE5HZk9qalUvR3pHQVE3VXl2Ry9U?= =?utf-8?B?Ty81UHY3dnpjdk9FOWRTcnBUdlE2MmRGVW5mL3lUS0VBa2c3NmpSTXhlczlw?= =?utf-8?B?REF0UU1jVGwwbGFpeE02T1J6VittWGlsRzJHU2hrdG1mTkd3ZG85SUVhVjRD?= =?utf-8?B?eHVKTkpXZ2hIZGdaR2YxbWJsNGtYNFRDK2hQeUNMQ1NjdDBvMkVzdkhaT1Zp?= =?utf-8?B?VHpHMkpwc3NMVHlEcm1WRXJpdGNCalh2cXljcCt0aytvVUE1U3pzUXJiWmZO?= =?utf-8?B?NmxNd1ZqRm0zYWhxS2hUdkliL0hETXpjYnFYWmpldlVPRnNyQlJXaFZJZG84?= =?utf-8?B?cW90NDB2a0svS1M4OXNJUW5pdUkwWXNBYkZQUXJDY2pHOHEzSlhJSjl1bWlN?= =?utf-8?B?QVpqdWlFNDcrdVdRaEM4YlpTc2VlWGtNM0c0S0svUzltS3JiWG1peCtvL3hr?= =?utf-8?B?YnYwc05Bd3crdDRkcW8wR0p5VzUyU1VBdHgzUWZZaVNPeDA2b1dZTzdJZkgz?= =?utf-8?B?VDVZNVFkdTV2WFZxVk1VMVl1R2NVdnZ0cTl3d1B3Z0FFYXkrRHMzVUVQWmpv?= =?utf-8?B?Rjc0aGdvOUxrY0grZEIyNjg3OXRiYzZuMnNGNldTemVTaHV6cWMydTh6ZXNG?= =?utf-8?B?RGxuVlJwS1lCUXl1dW9kR1dGNFJ3MmFXdDhwMUR5N0xvTm1ROEljczkxZkN6?= =?utf-8?B?aUs3d2ZDRWZuNy9JbEpWMk93cit0UUI0TmJpMzZuZjJXdFk0MW5LNWt1VUNJ?= =?utf-8?B?dkt4QS9oZzVUREk0V2dkTmtRdVUrZVVMWk11QWs3M3QyQTlwTURQbEZiZDMv?= =?utf-8?B?R1RZa2VKVkVmUFdBTWViOUVqQ2xtdHdPTi9velBleXJaMkFmSENpdEdUYTZC?= =?utf-8?B?bXM5UDVMdXkzMWFyWFQvNkVnRm5UVlJoTk8xaVZZeGhkajQ0Uk9jUUhxV0xM?= =?utf-8?B?Vzk5ZXpBaW8vWGdXNGZpZktGMkpQb1VFNlhJMHNaVE8zQjg2TEo3WDc4TnY4?= =?utf-8?Q?2cI9ChTC0wADXU8YpivjQXA2m?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd1e4a1c-b136-48c5-f720-08db0fefd6b2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 07:31:37.9054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OClVvmj2IOhzyW0knYH4mtKdZ8qTejIddpKid/ZPYqtqQZnGrWERgbHzxU+a60aioUdzZv5zc0tvNJ6ZP/gQ8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7064 On 15.02.2023 18:59, Oleksii wrote: > Hello Jan and community, > > I experimented and switched RISC-V to x86 implementation. All that I > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. Other > things are the same as for x86. > > For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT will > look like: > > #define _ASM_BUGFRAME_TEXT(second_frame) \ > ".Lbug%=: ebreak\n" > ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" > ".p2align 2\n" > ".Lfrm%=:\n" > ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n" > ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n" > ".if " #second_frame "\n" > ".long 0, %[bf_msg] - .Lfrm%=\n" > ".endif\n" > ".popsection\n" I expect this could be further abstracted such that only the actual instruction is arch-specific. > The only thing I am worried about is: > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > [bf_type] "i" (type), ... > because as I understand it can be an issue with 'i' modifier in case of > PIE. I am not sure that Xen enables PIE somewhere but still... > If it is not an issue then we can use x86 implementation as a generic > one. "i" is not generally an issue with PIE, it only is when the value is the address of a symbol. Here "type" is a constant in all cases. (Or else how would you express an immediate operand of an instruction in an asm()?) Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 07:34:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 07:34:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496371.767077 (Exim 4.92) (envelope-from ) id 1pSYmM-0002B6-1t; Thu, 16 Feb 2023 07:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496371.767077; Thu, 16 Feb 2023 07:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYmL-0002Az-V3; Thu, 16 Feb 2023 07:34:05 +0000 Received: by outflank-mailman (input) for mailman id 496371; Thu, 16 Feb 2023 07:34:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYmL-0002As-0P for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 07:34:05 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7d00::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49794f36-adcc-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 08:34:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8478.eurprd04.prod.outlook.com (2603:10a6:10:2c4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 07:34:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 07:34:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49794f36-adcc-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AigqFAste5auGoBLTLMlQrd/CedhmpofERdWwt1/GP2MPIQ265f0V4VemObCNrqanx1KugI0AyPANtceNR8DRU9JCHZlPYDkQvPNsLNUmLPFJREYl1XoX3YIHrG0lnoXHee0ewgBH+NH2Cjab1pecKriJ8u5NS0zOVbOx46pua/MdPo1hx9COqFZbN3OwNcpp7Xt05OzQdmSj9F1w7DeGRgEWm6WmQhZ15fFBlwSa50dOcaeKnJI7B4vHu1QnWi5o/Vl5drliOWXztkCqLDMr2eNGQQejJY50iA8KB5X26zgo6umCTnEDYTSVYGreV5oUECmNmccn2iryw76bQ/PfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mxVugtNFBv+GmnwLxjqQuyTIKhA0dnnQwC4QdF3NBqs=; b=CtWvApDB/oa9jLWv7BlCjaupT62WDG0cf5KRl3VWxjVHUKaB6ik/PFm3/700Nwcu3Ay0Rndw+JUvcMQHw2T6l6JxXPm2qN6A2v3GDa7FOHy/ducbRgE9S/wG1Wvw0AJ4ZWLzKtM57YNEDymg+EJWsXiO9nJRAC/55d5xY7HRV+1ihck17yg8bsaswybMgF40kXSw8HN6Ttp2h7daN0+esSBJ+WMrsD3HRrRYCpujOi2LwEni8eu062GyMfIxUHjzynMIVylM/xzTNZd84GPrklP0I/SPDhpscjy7lWg0lbA7t07cmZnfM/wpb+T0U60FjQIMEEBTrUPvaRhmWf8fHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mxVugtNFBv+GmnwLxjqQuyTIKhA0dnnQwC4QdF3NBqs=; b=SQUleQWfDyFfDDZ6IA/6qYQqavxK8UEMGAUZs4Sy14LzB+QD28h2gCVC+nIvItJiB6nhf+IotVfRCBnrizA2aylQ72fFiB6deuoDGWTsleGndpsS6p2iXi9SiYElTi4V9M50sR0PV5Ys26IJjc/vwdbTdIzjiZkekCM5QuLiQM2EiGhGGQ+Ts19vingI6+LQo6KfF8kbB2lZ1kAwzg3CERLHmEgy+HRQE41g0HpGv1VWMocSSh2IjK4D/mBarAlZspps00Jv32VR1tNJmteUUhV7PJWvyFDHPLNviWn/3f9Ls/rubK2ASG1ThUMJWyYkPdtHgrDHit424pZxvW+ZwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <68ad588b-7b6d-4378-b38a-b760b8c3adce@suse.com> Date: Thu, 16 Feb 2023 08:33:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/Xen: make use of IBPB controlling VM assist Content-Language: en-US To: Boris Ostrovsky Cc: Andrew Cooper , Juergen Gross , "xen-devel@lists.xenproject.org" References: <06591b64-2f05-a4cc-a2f3-a74c3c4a76d6@suse.com> <51ae9cad-3644-02cb-9cc7-28229987487d@suse.com> <4e66865b-11ce-cbd1-d115-13e3743eed7b@oracle.com> <64bc94a4-07f8-a065-7346-6d9f514bd690@oracle.com> From: Jan Beulich In-Reply-To: <64bc94a4-07f8-a065-7346-6d9f514bd690@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8478:EE_ X-MS-Office365-Filtering-Correlation-Id: 18aa5843-6339-4a25-d036-08db0ff02be8 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oTrzbh9MbwAnrRPPFuksO1+FeJpw8g1d32N4S0EY5PSYzPnLPmZmjnrnI6Q3eevw3ok9/qFs7NEO7KGadTZuQV9yODM2P7WaRTCUsZWRud0dY8DfEpSP7sguPZG5VvsXqMtCFvxXSKJjJBYvJK3Xu2lUy08w24hdHKOOfW00icTmDUcPB59QdHhSJ3WEx+atfSj2WdhF30hD9tahvK683tnEcymhZ/T5bKht6fRidX4onhL9L8okOHg62nkws5J5QUy2p5d5aUXWdUfTzJKWHC3sfKUhhythOS+TspygLLPawUYMTGFlr356Sp9EGSl6MbOO1eKrheEzs5A1ctybIl8nnF0s+231E6a/oUGPpcgt2sCKG/UdeHrohT7n4bCogiyLAyEy0cbhU/oFL4T3X3UIm05DICLlymJRS4s4itde4fVbZUbxRYMwMPpjgdkT+Nl96/QeZ5Jb5UDnn1t/lT5fL0GiM4DWes+9g54Rv0u+jkcmnzyZqU5W5UZBSjGnbGeCXPVY4HYbfkbJRoXjWB88lz0JTY3QbLxZh8iBUc8AjwMWd1aPzxY8CbMx5RbsVGDIwYpz1Ng9vjs+WH7tRKFXxAmwaAQIfAu4EfKaEF3GloAZ+LiDAlP0jUz49OZCjuuhPaWgrDhduAZFYa2GfXSTS4xlZqAn2k7llbXUunTRp53nIIWq7QbjMVM9l7Gf6TpNrcYgODYhgX+YQU7q1I8KvCoy/Jxg3/gezG8qjPw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(136003)(39860400002)(376002)(366004)(451199018)(316002)(83380400001)(2616005)(36756003)(54906003)(66476007)(66556008)(66946007)(31686004)(186003)(6666004)(6512007)(6506007)(478600001)(26005)(31696002)(53546011)(6486002)(2906002)(86362001)(5660300002)(41300700001)(6916009)(8676002)(4326008)(8936002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WThIUGVjcUd0ZEtNQ1pnY0NYb2tHWW93VytnM3gxL1ppb3ZjRHFQdFhQclow?= =?utf-8?B?V1hacE1ZZ1hIZTExOUp6M2I2R1RsZFpQdysrZUorYXJpVGQ2UHpsNmhzLy9Z?= =?utf-8?B?QmErU3RkUFFSUEVzRGVCalNyWFhmMER0bnJRYi9SaU9mazQzdTUydmN2T0Qv?= =?utf-8?B?c05WQ2YvMDdoNHBTTkJrSXExbEFnbDQ2dWNZNy91Yzd4NmxzYU4wN0tzWmNZ?= =?utf-8?B?bEFhZEQzZ01lRUZYUWw4aVZQRzZ0TU5aMmtBdVpCMVdsZWpObk1BN25ydWFG?= =?utf-8?B?MzFYUnpnNy9hVmoxRUNEaTEzeXhwYjRkajZJSXprZzdtbitRZ0xBZEJWKys0?= =?utf-8?B?MktwUkZHYWVZVUJMSHRHRWNyVmV6NUNRcHZxdzJ2TGlVdEJXcFlTS1VhNE5p?= =?utf-8?B?ZHlSTThTQXd0T21tOXpDM0NmRWk3eXA4RzhUVlBXM2J4bFlsUXltZmorWGVh?= =?utf-8?B?ZEhsaE1KbytoSDZBTVlpMGNsZmRsaVl2MUFXL3d3aGhkd2I1clQ0MzZkc1pP?= =?utf-8?B?TVFjVlY5bFFRWEpuUW9aNVo2ZS9XRWlLS2hZc25ya1pvK0V3NCtnMHo4cG5o?= =?utf-8?B?UTlDQXYwZEU4TGYzQXV1MXlhK0VvUnl4VTlDQ0pBbFE2cXdRM1NuWkdidG45?= =?utf-8?B?cFBuNXJpZDc2RHJWVDVTM3lEUlYyVW93NzRBVkZSODlvNGpWRXo0bjhZSTRW?= =?utf-8?B?NXIwbXNCVm9RemtzTHlUWk5HTUk4aHhsY2o0TGQ2ZjBITXlISUJPK0E3bE1S?= =?utf-8?B?eEZmN1llZnVSNVgrM20rQUlCaTVKTjhHSlkrZ1pNUWliUmhyZXlBaDEwSXcy?= =?utf-8?B?RlFMb0xTbVMvMUJQK0FTSWR0RmZUV0NtQkEyN2QzQ0FQL0x5NS9wT28zSXFQ?= =?utf-8?B?M2Z6bGU0Ti9wL25iZmNrQm1mdGc4VFprd1J0dTF4anRNQ1RyODc1bC9EYTI3?= =?utf-8?B?Sm9YNmxTR1hIelAvdUxpQ3ZoZjZ6NDlPaElZc3V1b3ZIQUc3dWN2Mmt2Q2pI?= =?utf-8?B?WlA1TU55THNEcnl5SXNjTnFOWlZZMGF5Y2psdVQ0QUhPNWNZTlRIMVNBYWZQ?= =?utf-8?B?TS9SVkNhUEt1R245Ym4yV0xGNTNhblFNdm9LVFlReGRtbDl0VElwSUIxNk1E?= =?utf-8?B?cjZMRWFUSDUzUFFNUjdHQ0RWQ1doVk5rK3dRcmk0U0hSUE9vSWRZUkszNnVq?= =?utf-8?B?M21VaTIyeE1GbmpmZGMzVzduZDE5b1NLSWZpc1cyZUZWM2g0SDJJcnZjMkNk?= =?utf-8?B?QXFxb1NvODhoVFVCZXh3N2txYWFSQVNadW1uUVlGRHhtU3RVc1c5RmFWdjNt?= =?utf-8?B?SGdSSWFXQjJidzY0eUdKNVQxNitEakNTVTB0R0lqVk9Ec0dIdWZCNUNpOG9G?= =?utf-8?B?TkFNSUxRSnMxcWVDcllWTjZvQ3N0QmdiNFBsOGN1SXJJWXNmOEQ1UlVuUUc0?= =?utf-8?B?N04vWU9jQTZMUlI0NVJ1MDlvZkt6UkdVQWU3ck9qZ2ovTUd2Q2twYUlmakhC?= =?utf-8?B?SU5EaUV3V2N3WitvNE53V25XbkJuOUFvamVEWXl5VlRzS2cyMnlsdncvcG5G?= =?utf-8?B?eDZxeTNTVm5LTnRBVm84YUNyTHBxUmVnTTlKS0h4R3BkWVZMVDJSTXZGalBZ?= =?utf-8?B?eDhxcFEyK0t1SlpnY3VlMkxGamwrVWtDUGpGMEJmeWkzdWsvMFJQYmFLMXVx?= =?utf-8?B?R2VDVFpjSVRGZnR6bnV6UWJlTmczeGREWlVLb1JiUm9SenlLbVdoaUs4RmlD?= =?utf-8?B?MmhidkFwTm9pOXdLR1owWjExZHo2bkxERzVvaC9sOUl2ckI1cVovTHphbHd3?= =?utf-8?B?ck9XencrOUdwK2YwV1MxVTBOdE93QmsyRWhBZDlGUmNuQzMwWHdjL01iYVB2?= =?utf-8?B?Nis3VlV2d3drdlF1U0pVbk1ZWWZaL0xUTXo2UUxWOW1SbjlhRlpIQ3h5SWFH?= =?utf-8?B?K0Nkb0kyclN1cXhKWGJZR010VkY3cElDZkM2NEpvTUJGNXhWbkhWdERwMm5L?= =?utf-8?B?Ly80c0x4RU9KMmN4aHdtYlBqeElDVWdZRlY1QnVpN3VteGRoeEZzZXJpYTJy?= =?utf-8?B?M0tvc0d0YWhaeWUyVjhDbEJPNVJyeVExb1FKMDJRYkRwWW9XN2IwOEh3NXd2?= =?utf-8?Q?2zNkKctGXw5wE/0ZM9entSVxl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18aa5843-6339-4a25-d036-08db0ff02be8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 07:34:00.8958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2+O5SX0MQTCnQTneSmC1tfT503gwYZ1jLavjJdAAEMOQjQaJKECABvj05NatY5josEWRw+jy4OkQJ4l+QRdb1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8478 On 16.02.2023 00:22, Boris Ostrovsky wrote: > > On 2/15/23 3:31 AM, Jan Beulich wrote: >> On 15.02.2023 01:07, Boris Ostrovsky wrote: >>> On 2/14/23 6:53 PM, Boris Ostrovsky wrote: >>>> On 2/14/23 11:13 AM, Jan Beulich wrote: >>>> >>>>> --- a/arch/x86/kernel/cpu/bugs.c >>>>> +++ b/arch/x86/kernel/cpu/bugs.c >>>>> @@ -18,6 +18,8 @@ >>>>>   #include >>>>>   #include >>>>>   +#include >>>>> + >>>>>   #include >>>>>   #include >>>>>   #include >>>>> @@ -32,6 +34,7 @@ >>>>>   #include >>>>>   #include >>>>>   #include >>>>> +#include >>>>>   #include >>>>>     #include "cpu.h" >>>>> @@ -934,7 +937,8 @@ do_cmd_auto: >>>>>           break; >>>>>         case RETBLEED_MITIGATION_IBPB: >>>>> -        setup_force_cpu_cap(X86_FEATURE_ENTRY_IBPB); >>>>> +        if (!xen_pv_domain() || xen_vm_assist_ibpb(true)) >>>> >>>> Is this going to compile without CONFIG_XEN? >> Yes. The declaration of xen_vm_assist_ibpb() is visible (satisfying >> the compiler) and DCE will eliminate the call to the function due to >> xen_pv_domain() being constant "false" in that case, avoiding any >> linking issues. The interesting case here really is building with >> XEN but without XEN_PV: That's why I needed to put the function in >> enlighten.c. This wouldn't be needed if xen_pv_domain() was also >> constant "false" in that case (just like xen_pvh_domain() is when >> !XEN_PVH). >> >>>> I also think these two conditions should be wrapped into something to limit exposure of non-Xen code to Xen-specific primitives. >> I would have done so, if I had any halfway sensible idea on how to >> go about doing so in this particular case. In the absence of that it >> looked okay-ish to me to reference Xen functions directly here. >> >>> Oh, and this needs x86 maintainers. >> Eventually yes. But I would prefer to sort the above question first >> (which I'm sure would have been raised by them, in perhaps more >> harsh a way), hence the initially limited exposure. >> > > I also think there is a bit of a disconnect between how the mitigation is reported in the log/sysfs (retbleed_mitigation is RETBLEED_MITIGATION_IBPB, so "Mitigation: IBPB") and, for example, lscpu (since X86_FEATURE_ENTRY_IBPB is not set anymore). Initially I too was worried about this, but ENTRY_IBPB is not exposed, as per the empty double quotes in #define X86_FEATURE_ENTRY_IBPB (11*32+10) /* "" Issue an IBPB on kernel entry */ Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 07:38:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 07:38:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496377.767088 (Exim 4.92) (envelope-from ) id 1pSYqe-0002yH-Ln; Thu, 16 Feb 2023 07:38:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496377.767088; Thu, 16 Feb 2023 07:38:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYqe-0002yA-Hw; Thu, 16 Feb 2023 07:38:32 +0000 Received: by outflank-mailman (input) for mailman id 496377; Thu, 16 Feb 2023 07:38:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYqd-0002y2-3V for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 07:38:31 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0608.outbound.protection.outlook.com [2a01:111:f400:fe0e::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e81e7628-adcc-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 08:38:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 07:38:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 07:38:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e81e7628-adcc-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwstdrUvo7r++bCM5QWdq6Nsq+WZekmJvURFlkV69Mg+CMNjk1a6z71ezSBa2p2eGGgr2yOTpNcmg322u1w+RHwSWCclDDWR/jr3FZOR6IUEu4qpzNjw4xwA0Xc+VYaEOum4QPeldrrV/9Lja6F/JOijpeL++mV2jg/z1ncuUy8FpoH1/tP08LHoCQ8flHR/XZvOEeWb73eS7do4xNvbvDGw1a5qk/JDNWkP6KdvJx8ijbsaBXCNqQW4ZDV+oTltVNvwYU9ODvvkk5y7GaFZjqPYEO0W6Q8Xb8UxgKCTQmG8wCPsj22ukkjtHWHtZVHQDuuGpuAdNp94SwgkPR+oxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vdSvawLur9z3uii9VAf5jczLSIvMRa54vGxeZ+hKdcw=; b=n4e0D2wGoHs2syCpZFN5boF/OjCc6Oof5fM3Jg3s1n2rNJjNN8HIS7jlsGJPl7P5tvATXZTHaTOM9WbyTYUAW0us7O6FFndyyc0AEGijWTjJFC4AvZAJyhgc8zET1DPzVc78IWVZ0WOc88L63qUokaL1Pi1/45YschX1iAiD2AC4Tyya52FukxMkvf3jPfAtnAHOzToxgMuYkdCGikiyMNTe0Hzz/qxFgCaTt/aRnfoScAHUK7RNpZgyoqoZGeJmXO8DW7gSvEP7XVKYLSY87Ttgjx/StIEwywhgnGhMDzVb5kSdmLpPAvf8n33DP3rNhRXAEEwjzMDKCSmhvIiIwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vdSvawLur9z3uii9VAf5jczLSIvMRa54vGxeZ+hKdcw=; b=3HLvjBYt2uiSWayITwLBd+45D9uwsIo5dEwtgn8ivH+nLWfMLqSP0YDzWE7UdTnFI/Hl68K9hKpKFOmGkOGoG/OwAP+lolXZy16Lda4QNBfffWVOWJz5CMedx+n1gvr/Kx5FdlGSLnFZVuuY8BZsu8X6EWV5NsHfSTBN3+kbtfd5lEeKCv1H/g/SX3JsOAdHID1MBiOgRTvdRff77CNtr2jrdkOFfE8+3r9wNCjDq47J3Ckng+bg+Uo+eyzxFrXhMJuAqn4wb11j1auZ/lQKYE8AndWjPoOEugIW8LL5LqCVdcDhlvHjX97APmqLvg6eD9BKZgZFMNE95q4V1ekWag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f53fc54-626a-5e42-471d-b4679eaf54ed@suse.com> Date: Thu, 16 Feb 2023 08:38:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0 Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <7c38a1dd-3ac7-f7f3-4a7e-a231f55e8f48@citrix.com> From: Jan Beulich In-Reply-To: <7c38a1dd-3ac7-f7f3-4a7e-a231f55e8f48@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: 50348c71-02b8-41e1-9335-08db0ff0cad6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yEjjuZbNg9v0D6ikaSPsyEjSt0yOeJuucMCAr3n59L5QpuxcNpRFFazvP5ALNn2DIuMigWBOcnCaHMzV0XXry7ITaPlb2buGxOHLmqA0KiK2P7jt5vDiqiB25lbiPCWFwLmkvVNxdSeKM3O1hKnigbTT9X7i43fZVRZFr2oBrYSzpPYG+q9lqbToCjobkGSY0Ir8ufDksa5lkbGJQic42+6M3XB91pDC6I6PM1Qzt+oXHhyqz4LP+RmcElD1pO7hD35l9JFExVZ1qA2LJP4FIPwoSUvCDFO+s0zBYL8IVeTOSVlHbjwdvZw1RRpULuwZ6UBej13v6WH7ZQKOEimEqXIji/XFKDPhYpLOxr0k14ZdaxulVRE1IRChSALLO1RJ/is9aXZihMaF4bl3Uj2Oljb4weeZBCOa8MEz/cgny3UwhszVgtBaB+1Mej4REkJ9mcMQwJqOw+Hu+NwODTz8bsi9jyw/26+90CEs544pIiobbcfSZ+udGzMGvbJpF36uLDi3Bauh+fgIkaSaSjUuG4522V+iItCyGqxEuATPA1vlreyd+8QjvHM4nml0AFtZRSctp5fBHmAq8cwjbx4N3gOUXeHrypGik8OQ3+Fg5YQwBY6VTe4l0QFoR4+rQr0ZI5XDAMjoq0/Aht/Utp28NDRK1ONUzijpAp9Z21bTreqvnGXSXHxW6jJjSbk8vGXg7wtM0oWirQDf0WSXuKt5YB2eWs3+31gQA6g77PMnsx0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199018)(83380400001)(478600001)(54906003)(316002)(36756003)(2906002)(31696002)(86362001)(38100700002)(4326008)(6916009)(8936002)(66946007)(66476007)(66556008)(8676002)(5660300002)(41300700001)(6506007)(186003)(31686004)(6486002)(26005)(6512007)(2616005)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDBQTFMvTXJyaTZaQlQ0azZ0NnUxNVY5ZGdQeXhVQitTWTlqdmcvVUVibER6?= =?utf-8?B?Q0VtMHc5TVpqL1lQR2p2cjRpMmI1d1o1WnhXbm51SUhwS3FpR083anlUbGZ0?= =?utf-8?B?MUY4RWxZTW5VTEw4Y2xzY2RwRVhlaE1qRFBPenQzQTVQamUyUHRJbnJhamw3?= =?utf-8?B?aTVCa3daQmN5VVJRRExHRkowL0pZSkdVOUMwNXN5OWVHaTVBaFBmL3cvanFJ?= =?utf-8?B?VTN0QWtXUFlGQmt0c0tCallSUXprMUtuN3AxSjJhWE94QmVpSkQwWGZFdTl3?= =?utf-8?B?OWgvekh4T1NlR2tiUERHQTF6Q1hvaVVJRmpsZG1WMVF0MHhPTUNKUDBrTVNy?= =?utf-8?B?RXdFT21say9JZmxlYUVqZ0ZmL1FLZDNBdDZqVDhUdnpOUHFxOFVQaVlwZVdp?= =?utf-8?B?c3ZObE9UYU5LcDFnQzhldlp4NStodnJ6UHcwRDNteWhXblJqT1hiMEh1WVRQ?= =?utf-8?B?ODBnYllEN21pRm13Z0tFWG5WSTVlOVBSRFprcFQrRldSTEhhQXQxQW9peWJ0?= =?utf-8?B?ZXpDK0VSOEZPZldWTGhUbjF3eUFraTNzSE9DQm1vNmdnT2dBcjB1K0tVRUVD?= =?utf-8?B?bCtkVGFtS1BaZ0NpcjQwSGZ6K2hVNC9kUldQQ2ZhSVc3cW5ObU9SNktVMzBR?= =?utf-8?B?OU5sR0daQkF1WHpucmVQUWpSYm5YL2ZsMXhMRjlWRjR3dUl2Nk81ckZkeUJS?= =?utf-8?B?ejJERTFHcHJ4UXE3Tzkrb0J4bklWOURsSFJZSklhMWMyT1V1ZVlpdGpqbGww?= =?utf-8?B?akl0aDJ5bmY1NE4vSmM3VDhZaWRqcFIwaTdnZ2pmWE9EVWk0L3I4YzRzSUNj?= =?utf-8?B?aVZRUGpIM05RZUR1QkNZc2dOTzdtL214RHFvVWJpSXZkQXNraHVwQ09MTXVH?= =?utf-8?B?WkZWdXp1bEcxaVdTZXJPN3JSdURPWXgwd2dmVndTTC9PcUVjRCtaTFRBVjVO?= =?utf-8?B?aDZ5M2tTSEZlbUx6d1dzdGs5dTVWZ0RJSU5jTExtMGpDT2VHMVhJcE9wWTU5?= =?utf-8?B?Qm1KR1QvTDlvVExlcEEwMklBWloycnkrbHE4NG1LM3ZtRmhmMG5MWlBVNEpU?= =?utf-8?B?c1dHNWZrRjdIK1RMQ3pZZWc3L1FUL3B5THNRdFdJNzJ5VGp5UlFocVRYQk83?= =?utf-8?B?eDJkbDBma3ZGY2NhT09SVlNXL1FiMEpDTGlLMEl1ZVl1djY0S2V3WkNoL3Qy?= =?utf-8?B?emlpYzF4d3krYjRjL1l6NHdjd1Vac24zMmw0ZHdCdVczR1duUEJSdXJ3T2pU?= =?utf-8?B?ZG9ZVE1tcm9rWmJHWVFGRkhrWUkxSmFKNXh6dnMyR2VyY1QzbUtCRUYvR3lG?= =?utf-8?B?RXFhWUZtS3hDSFV3cjBreWdpYnNuR1dmNzg1cUdSTSszVWlIM1FuMEZxcnVt?= =?utf-8?B?R0Y1UEpnT3VybDJLaFpEWS9ZSWttbTMrdFgzVlNhak4zaDJ1bXhuOGJlOUsw?= =?utf-8?B?aTZuYXNaYWZha1NrcUF0ZVppbTI5ZXpVNEpCbU9XLzJaZnUxSVEyeUk2MGVU?= =?utf-8?B?VmpUNXFHUGZla1IyTWs1aWpubWN3UC9ubkhtdWp6SGJ4MnlkT2F4cVlEYVkr?= =?utf-8?B?ZTJxWWd1Y0QwaUZGWm52VWFlZmNhckF3TTBUY2dSYmppNStPcDNONm5VNEpM?= =?utf-8?B?MlNnWG80NEs2VjF3QmVmb3BJYnZ1d0ZBRUQ1bFA0UWpqVlhsaG9abnFBRStS?= =?utf-8?B?STBGbVFhK1RtUFFwMCtjVnYwYzhnRTBkZmhNWTZaMXA4L2p1MzhOMFNuaTlM?= =?utf-8?B?Y1k5b3lFT3EvcUpOd1hQMEtySUpudkFDQ2Jockg2UXBrNHAxcXhzK1FHVzV0?= =?utf-8?B?NkJ6RmxGWUxGRkJMMUpINWo1RXNlck5LWDZhZ3hVdFZ1VEQ4YUxuaU1Ha3lH?= =?utf-8?B?eGUwMWdlSkZVUEVtT2N5NUJYNEVSdllLQllXZnJ3TUZJbE1kalQ4WTdBV1FG?= =?utf-8?B?WjJ3ZHo1NTZMSFZYb3ZGbXBwaU9vbFVKNTdUdmtUYytleTYyQXJ4K2NPMkd2?= =?utf-8?B?enpKV3NXMlpmRmdKK2xGWS9wVmo2Wjh3NVViVUtoSnRyOXhrMEI4WWxEblBH?= =?utf-8?B?TDJ0S25xaUYwM21UR01UZVY0cHpiL1ArU2FNd0Rxa25BZ0pnOGN1MldDd3h1?= =?utf-8?Q?hRGM/OyDa5FTez8YImeqMlbRP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50348c71-02b8-41e1-9335-08db0ff0cad6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 07:38:27.4247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YYYD9s11xgJjH7IPhh8N1aAzvqz0gnnD5Op9uKfJZnoGhnUGfCSqPk2WAa26uKgXKi4x37iNJwjoggt+Ey/y+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 On 15.02.2023 19:41, Andrew Cooper wrote: > On 15/02/2023 3:10 pm, Jan Beulich wrote: >> Besides a printk() the main effect is slight corruption of the start >> info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended >> up as xen-3.0-x86_64p. >> >> Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder") >> Signed-off-by: Jan Beulich >> --- >> RFC: While Linux works fine with the adjustment, I'm not entirely >> certain of external tools (kexec?) having grown a dependency. > > Again, I wonder why you think regular kexec has any anything to do with > this? > > Are you mixing it up with (legacy) pvgrub which does end up doing a > kexec inside the context of a PV guest?  If so, it's MiniOS's support > you need to care about, and I cant see any logic that even inspects the > start_info->magic[] (either in MiniOS itself, or the pvgrub patches). I guess I really was thinking of something like "crash" instead, mixing things up that way. > Like plenty of other fields in the undocumented PV ABI, it's not > interesting at all to software.  There's nothing I can see in it that > you don't know at compile time. > >> It >> may be worth noting that XenoLinux and its forward ports never had >> this ELF note in 64-bit kernels, so in principle it may be >> reasonable to expect that no such dependency exists anywhere. > > NetBSD sets PAE_MODE for 32bit and 64bit but, like everything else, > doesn't appear to inspect start_info->magic[]. I.e. the same as (so far) upstream Linux. > xen-3.0-x86_64p is obviously bogus.  I find it far more likely that > noone has ever noticed this bug, than anyone gaining a dependency on it. Which kind of reads like an ack, except there wasn't any ... Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 07:48:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 07:48:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496383.767099 (Exim 4.92) (envelope-from ) id 1pSYzp-0004ni-Hp; Thu, 16 Feb 2023 07:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496383.767099; Thu, 16 Feb 2023 07:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYzp-0004nb-Ep; Thu, 16 Feb 2023 07:48:01 +0000 Received: by outflank-mailman (input) for mailman id 496383; Thu, 16 Feb 2023 07:48:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSYzn-0004nV-Vo for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 07:47:59 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0631.outbound.protection.outlook.com [2a01:111:f400:fe1f::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3b22dd62-adce-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 08:47:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9445.eurprd04.prod.outlook.com (2603:10a6:102:2b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 16 Feb 2023 07:47:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 07:47:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b22dd62-adce-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UpzxgHhzDda3ViUNKmamf4hGOoEY4U/9mMuOo9HJgsRAHYrhMazuyXjRwDIshkvCCGCE1b8uNhmA3oZosPQRhAo6ypu7SDrwh5cui2WjIUagqeYwgiThHf8ehZEZhzKuysisB9XShNR25eG/QRgUGcGRyVqzquvkapj/rwPMH/rWCUXr9fiiT+De+kXDdikH+BIgEhPynmbZ708DD/7YUgyh3ai6MLcogPP5+iJog76DBpYvYCoI5oCIKl/SLxhZe7unYsTmC8vJdFMh9KowjHwzOdDPx3RDjCvh0K7xJZUc5DG40e3P6PfjxxPBHhGEZfR8okToVKITzfU2cOHT6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v8ETtXwk3IN3tu3mdPSVaAcbxc+S7agoQVu+6VvmJRs=; b=ZPXqCuTSm5rwu1vl+Z/CEDmo6903TRZiBXY1VcHX5qvmoBHkOTK+yTq6uUAZUO/p4aRjvjsxAdE/NNDSKqt55A+KJDCed+LAgYu14SRPAo8TMrMB5A/+drGyIjihVAk9fhllcsJm+mFOFcONwoAb8R/yoBsEm1Dwi8hu0/DnoWMyDXXTheCKtPphSeHiSwHkb5fOHIY0McnenJXPCJa+0wK/AXgX9YqFshmpM+90k2a/qKVwlizfJ39MAJRFkxXESJcsaPDzbzoak2FRYaT6VJ8k/Q5UKnqchD9em+u3htN7iIYvd0BqtVgxULUIrNIX5+Yeneak4d4GENUdgk8OjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v8ETtXwk3IN3tu3mdPSVaAcbxc+S7agoQVu+6VvmJRs=; b=qr9CzsN7E77s25Jp64crqgwpXjGZJA+RXxJSMUXHD9/vg1gGZ4+ykn8XGPZ376H9WPAhfey205da2p5gc+O3OpYIGTdumBsP4DPnVLonEI12fbtW9ePOZwQwu+tT5NUGX6T6stZEgoHUJJEmszv4gZcIfC1RvPEs5kek5eSgqfjQijZoxoRFhOA/VagwURR07z5/9V4vA13NezG2+CCrJv55UGFdfGcQv2/sZKvyiCSGvZTX3OqnkwqeTkblC7zKykpLRHadKs0WkH0xbn6iw3/6ltrBOvoEoNZOOqFS2mtrspqJ98HaBetEVboQz0gee0/x7hzX5mfO8R3H5Irvng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 16 Feb 2023 08:47:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/6] common: move standard C fixed width type declarations to common header Content-Language: en-US To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Paul Durrant References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <862a1076-4be6-79ac-4243-7d690a2f88ca@suse.com> <7532fcc4-1e0f-7db6-9538-6dd3fc209521@citrix.com> From: Jan Beulich In-Reply-To: <7532fcc4-1e0f-7db6-9538-6dd3fc209521@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9445:EE_ X-MS-Office365-Filtering-Correlation-Id: 37bb13d2-6c27-4575-592a-08db0ff21d21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1MxiS50X4ZK6+0Hmfe4avZXOv6To3XPNiyrgBIcYrIcxtDaGV0gxfdvXebxuNdFXz/WIUUYhdIu0ZQq5d4CrmeL9UzOD8OMfVio14aj5srA3KAt520GpyOzh9IdusA3ohqt/9ovyLsgbgidSsKIB25fpsl8eYrQE3W1CQtIDwpu93UB+EXP1/Bj8Jqti/p1ps9cLcd6cW9tlARQXZ3m5BrRYgWsV81HbGVcOJRM19ygfPJ8mF/xytftB2KNgluDIF1XFPDFZiDON/WzCuq7Fx8zss0JVhpBeH7vFhM6Mhvtsc5/1j/IRenWBNMlxYdQM4MqVyUIAEVdqyiyUkDeM5Xfu06xv8IstrxH/RRjSwt7sml2qXDKXe3iw52VbNM5oEBYPjfr0+km65tUic8gxbEbgZop8TdpneSyOgv9ic1H9GMcKGO/LOL825m7v5jovVVcPqXRIUdYWj///TsnRusxIR9DwZecMWapdqFvGkbbcJhzX+/uZCkUs0uhOANI3zJOJcomg5AV8IGQclWngehvVzR2a3w6Q51t3d9nGkncH4maWXJ/mqS2SjGw+9LjSlXeuS6KjqlAtPrRzlREsD4BzPuPAeD0sqkZ+Q4ZRbMxZ7JzgUIqh2ITLXqIGgK1cCzXTPva8tuR+QsYmXkeRnRsmCH0+DsZNH+Y+4KPGQYcgvN1BEhY+ofDROl6h4hiP/6ZrSROStgJq4Lg1aB7EORMkxsU2Mk5eb6TLdWm5sHc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(346002)(396003)(366004)(136003)(451199018)(2906002)(31696002)(36756003)(86362001)(7416002)(26005)(8936002)(2616005)(186003)(5660300002)(6506007)(6486002)(53546011)(31686004)(478600001)(6666004)(41300700001)(38100700002)(66476007)(66556008)(6512007)(4326008)(66946007)(83380400001)(54906003)(8676002)(316002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjQrUlZuSG1pRnJkc2Zlb2ZXZWRxVXhSbXc5Vy9Pdm56RnRsVytzSHV2ZXJx?= =?utf-8?B?M2RLdXJ1NXVWa3NDK2NDVjV3b1V4aWN4V2Z3RDB6amMvYklWS0owd3gyUEhu?= =?utf-8?B?Uy9LQXBUbm90VFV0cEp1SThQWjdqSm05bWxVR0hQRCtlNmtGT09UY21DOHhz?= =?utf-8?B?Vyt5YThHdExueWhLYjMxbUQrS2VuRUJra1FVOTVZT3gzdHUvQVJwVmt2U3I5?= =?utf-8?B?NDZ1TmFUWkMvaUFOMThFMkhWZHlBbHc3dUpCTEZ6cVF4QzlpU2oxblRsNm5H?= =?utf-8?B?d2V4Rkx5UEtYS3NpZ0p3d0NEZUFlTS9pMFlNcTdVUjEwMWoxZHJUWFlhY1Yx?= =?utf-8?B?aGNpaHV0clg3TU15c2Y5bCtNZFpYZFl3VXl1WElQT2c4MFZrR2JVTHlNcFBC?= =?utf-8?B?K3B4QTRDQXpBRW5Sd2FOVVpTdFBndU1sUEtWVlhkbmJzUzRIazEwMFZRL2xX?= =?utf-8?B?RldnVkNiRi9FYkZRT00yL1EwSW5PTHdITnZBQjJVWGpKTmJJOFFvc1dUVWdi?= =?utf-8?B?MFlQNE9YOCtjMVpEcllkVDVvQnVFb2FnRERQY0pHWGV6aVVPRVJyK1dZUjYy?= =?utf-8?B?UHJ1NDkwUFJBenlzMmoydjRzK0pIQkdBWi9vZEJrdlJnVVdacTBmUFQvWHZu?= =?utf-8?B?Qyt4WXliRjhjNFlTaWtsUFNKZFAvc0piQTF4dGtTVHZ1ZU8yUHd1c01VaXdI?= =?utf-8?B?cU1NMk5BenlhNDkrdXlmWkduU3Nhc1NKN0twaDZtTTNwTVF1bGlzZUYyVFNr?= =?utf-8?B?NUZGVUZtUlV1a2hGS0tvdmhySU1VOThRUVpnZU9sUXd4N3pvcTRYVUNxcEhh?= =?utf-8?B?bHBBWjRYN0ZRRFhTRTR5a01LMWV4SGJwM1A0Wm1lZHBYUDd6QkJ1Z21VajRo?= =?utf-8?B?b081YVRJV3pnMUdWMkh2MVF1YzNoSmQ0eTkvNU5hcUZ2T0dVTElQWk42SUh0?= =?utf-8?B?WEJSY21iY1JKN3FuV3NBdjZCMFNicWNRYzZhRU90RHhZOXZHeVJhUldDcEVF?= =?utf-8?B?QVRYajNDS3c4YnRhdURVSWU3aVF5OUdEemNZRmkvTFhLWkFCSnBvelcyaFRu?= =?utf-8?B?ZG1nU3lGRSsxanVhMjA5TDR1eDhFRSs5RHVSaitTNGFPV1lQelJvbWpqYjBQ?= =?utf-8?B?N3lYbk5MSjNIdFlNYlJPTWZhUXI1ZEQveDJmbjd6ZUZRUVlQRnFMQVkxN1JF?= =?utf-8?B?RVBCZkVGUjJ1Q1lSd2JFYmNDRzJIWFBjMUVMMXNuWVQrNVYxc1M1VElEekxi?= =?utf-8?B?N0pFOCtBczh3cGYzSlRZNEtUbldWZ3N2cXZjc0F1WnZqc3dOSzViUHdlV0g4?= =?utf-8?B?VjFWQmUrRU5iMHl5TUJJSmwxME9veEdtSHlFemx5eCs4dXBjT2JtanBURUNs?= =?utf-8?B?cjVFRFBsUVVRWXg1U0h5Mk1iNVg5aXhXdUtRb2lqVkh6OHNNSFhrTkV3Z2Js?= =?utf-8?B?T1ZKZE83eXNrQlRyeXpyVGVlS2p4c1FWMHN5OElWd0Fiek1HSklSL21JY3kw?= =?utf-8?B?Mjg5N1puaHVpbHRhUHM1eit1cnhaYWJXaStPSS9wRVdDVGcwWlZKcFpyL29q?= =?utf-8?B?cTdsekkzS1FFN2xLVzFENTBTaHFKS1ZWSEhURy9uMTNzK1hQazF4cnRydnVx?= =?utf-8?B?ZjIxVDVLZHJSa3VEaHRLZm9oZFRsRXUvUFduV25ZRUlRd3RIa21pSkNxWE1a?= =?utf-8?B?SlA1elJ1c3llczJkQzJuc0tSM0xGTnJldEQ4UTJ4OHIyQWNNTEhBS2EzbkIw?= =?utf-8?B?RDFtbHBCd2Vnb1BmbDM2MHZvVVAwNEpYTFJReGgzMmdtb0tjeTdqaHk5STlI?= =?utf-8?B?WFZvdVREV3B4Slo4RjJmUUdvblFJbTZCbVNINHlHczkzMmE5SlJicURnSnJP?= =?utf-8?B?UEp5VDBsWTVzOTd5T2ZvRzc3K2pvSnJWV1dXc0NVYkFrQkJ0eUFYWFJCL3Zn?= =?utf-8?B?bE1pMS9TYjRpbGMyTVozdkozSEE4Y05TdjNMSnRSNDlFLzUwNkVEZG83NVph?= =?utf-8?B?MDdiZ1crdE5zSjZoOWhseVFWWTBGL3NEa01PRVh2WDUySkViTC9GcmpFUEly?= =?utf-8?B?SXIwOHhNUEVOSWhUMitWN0x3YnBndDl2eWxNcHBvUTJtN3JiVWhhOUJBNXpx?= =?utf-8?Q?WwfxOJJMdRENCr7gCnwkODDLu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37bb13d2-6c27-4575-592a-08db0ff21d21 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 07:47:55.0627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GkT4B2x+bAtYgzt6RaIS87uNEFEZmrJi7eCi0mt1mHsdUZ8pdoalCkzy8Y9GSVrnoTuGHmjMwfenbMGkwDZETw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9445 On 15.02.2023 19:54, Andrew Cooper wrote: > On 09/02/2023 10:38 am, Jan Beulich wrote: >> Have these in one place, for all architectures to use. Also use the C99 >> types as the "original" ones, and derive the Linux compatible ones >> (which we're trying to phase out). For __s, seeing that no uses exist >> anymore, move them to a new Linux compatibility header (as an act of >> precaution - we don't have any uses of these types right now). >> >> Modern compilers supply __{,U}INT_TYPE__ - use those if available. >> Otherwise fall back to using "mode" attributes, but this can be relied >> upon only when bytes are 8 bits wide. Should there ever be a port to an >> architecture not matching this, it would need to define the fixed width >> types locally by some other means. > > These types were added in GCC 4.5.  It is 12 years old.  We even use a > newer C standard than this compiler... A newer C standard? We're using C99, don't we? And Xen, at this point, continues to build fine with gcc 4.3. Furthermore I for one didn't check when Clang gained support for these pre-defs ... > At this point, it is an unreasonable burden to be continuing to support > compilers this obsolete, not to mention that the mode attributes are > unreadable to anyone who isn't a GCC developer and clearly unnecessary > to begin with. I disagree about the rant regarding mode attributes, but that's secondary. What I'm really unhappy about is for this work to grow a dependency on the long-standing question of what to update our tool chain baseline to. This has been discussed many times, but there was never a concrete proposal on a policy that we could use not only now, but also going forward. As it stands I can't help the impression that this is going to remain unresolved for an extended period of time. But there not being an appropriate solution to that other issue shouldn't block the work here. Once that one is resolved (and provided it's then acceptable also on the Clang side), we could easily drop the mode attribute fallbacks again. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 08:11:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 08:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496394.767110 (Exim 4.92) (envelope-from ) id 1pSZMX-0001HF-VN; Thu, 16 Feb 2023 08:11:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496394.767110; Thu, 16 Feb 2023 08:11:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZMX-0001H8-RU; Thu, 16 Feb 2023 08:11:29 +0000 Received: by outflank-mailman (input) for mailman id 496394; Thu, 16 Feb 2023 08:11:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZMW-0001H2-PV for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 08:11:28 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0620.outbound.protection.outlook.com [2a01:111:f400:fe1f::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8285f098-add1-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 09:11:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8030.eurprd04.prod.outlook.com (2603:10a6:102:cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 08:11:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 08:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8285f098-add1-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGpU4pi/d1hRWtFjYwmOo4OFyiPe6KvTEJZ1qdspZqAvm1wcSJdFrOC2qx8Zn1fbLGyL3ZTXgWts+lTu/qdn9M01/T1bwJgmuaYO25A9IxuzEPfIXZ4T8E+yl7DIw662fX+4iv4nAWf7FD9WAtyg9FwCel5z9nxjGxEWIRDeTcEs7gl4Qx5HFsjnIWTCDH7l/xmgxUAKMR9pTsZCQaZkEzPLrL3pUag0GmvMNocNgGfqZ67U2W9gC7ZDdS99jPObMP10S5GyksHiqU00UdE9j+ORTK9YXl9HNPpldBxrFoSC7EoQhfmPl+z33BzAl3nPvg65SHIIciMah/WxRzKDTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3yXqgqX4yIGOYHYwEaB9Le7yDcnV8ZNjBxa1s0lOlJY=; b=Xii9d0Ht8lcNgzmezXkFDTOumPF2weVgKmyqXrK+PDFrenp2zLWkkVOGsFGviuws7I4Ibp8TluquNjVRLem6n1iymkx+i/3FkRe5wfUUPXLIt8RLRyRZaDrO6fsJr0xvU1yh89d7ZRct5DLSXW/G7GS7gSZPBWgGMDVyM9M8OfzVD8IZ46INfm3+Bt7gZCM/54ZEbyISSc4gMKbh2SfaORNmrelkXGUBAH45rkcswsVggJ7MPbciPNrq+dXYdtWotRWMb0FfmO48nB2jGgReLmiuYISDATQG4S2lrl3ibx+xr6q/awYv5TMmiR9jV8uq3M2pSxBXxBrFEdFJ4J9KlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3yXqgqX4yIGOYHYwEaB9Le7yDcnV8ZNjBxa1s0lOlJY=; b=ikH0bsBrUZRi1f87jmKMam8yfyKLmb5E3aFkYBD3n67wC1vVP0nmqPLL6wr6fiGwmlGkhPexE2eVx+q2AU2nyFWamPhLUmZFMxV7KyCAkIdHl5KkEuWfU+ZF7v5fOfFGTLBcbp4NRrL/K3XtnNeMqRO+7+XVhSZgq6U18Q91KHq64UaMGx694RCSGFRbpTK5e1A9AR4mtucCwAStNFikMSZIFhG6BF/6XPnn29BrWyTawqCFyuS35To6ApGfsFURtzXqqkuH1SDlSXEQdlcFoezTrSz8ySsTdjaMj9qby3yE3s7J/lqUhjqMghmhzzI5biJeAtInS4f9xoaq+PtwFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <12b26fbf-922d-3289-121f-f570365b1d9f@suse.com> Date: Thu, 16 Feb 2023 09:11:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , Wei Liu , Juergen Gross , xen-devel@lists.xenproject.org References: <20230215152111.51218-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8030:EE_ X-MS-Office365-Filtering-Correlation-Id: 2747de8f-7270-4c67-d7c3-08db0ff564f3 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lRjPDSYmGNMBdZkMSk79Cufh2C3eaHj3bbIKF2PftyawI5dwacEdGGqU2BdW+TSuTuEzbDk0baD1XaFpXV8clMIU7BaTDVi/52LgXSPS5opygF3StQQCIrELIiEPWJpptmjVJjYsJwjdY12wF8Mo6cccQDMjtmwy7uK4nVPBegOPOwMb1WwhlAiMGAGkTsmKkU8utYWMgDM3AgvHkGJWL1nTm0S2KClmmJDis9xXWEAwTUlW4ABJUF34+yIW/w1/WaQeUgW1DDQz0bib3gQSX4w8diF8WBWLxuH8P8aR2+dNuM8yacOMuYT4gPv9d7f755iQfXIUB61wl/AAGftn/oywFl4hMQSsr7Xyovqx2F8k7YdLNfhSL7FI3DTcT70f+Ol/6CQP/CkJgvDatcTjhLZIlF4Uapc5SCVamP3HIyNPYvv4lkW+ZeQsCJm+jWKhiHOf6Dyvq+bs4OYBG6eg2cdVXv4aCtE27CMh1vGy3BBd03tuLjncgeLyfaFCKInyMLIYT51zz+qc3XhlUUrJH+YkCA+rkoh4oqJPJvlOdI3qenwchFBQDjx/qYpz7JDJpmBvqWngA2BvxPh9Bjf+aTdXEpjtA+Dd2csfeW2G4uEsalKAlG80Ysp9wbaY7CTMlI5/LO/+3PXhmgKzwYDeAbxRrBaNJfoyJVoQKQGOUyvDkEeM9b5a1pcg+BlUBxw5Tpr/p5bJ72KQMpE/9ujLAreJ0YlaRbW42YpOAZSjhTk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(376002)(39860400002)(366004)(396003)(451199018)(316002)(66946007)(53546011)(66556008)(41300700001)(66476007)(66899018)(6506007)(186003)(26005)(6512007)(31686004)(8676002)(6916009)(5660300002)(8936002)(54906003)(4326008)(6666004)(478600001)(6486002)(36756003)(2616005)(31696002)(2906002)(86362001)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVAyVm9IMEtuOGlsYUFqZUtRblpZT0Q4M3paaVYzR05IZGt1VXJwTWVHSzlk?= =?utf-8?B?Y25CUFJQMmQ3V3R4b3EwZVl6ZGpFNS9vYnovdWMwMFRMT2IrSEFqSXJzTUdX?= =?utf-8?B?Qzc1V1dsQXR3a3dxZ09VaXhpT01DQWFPKy83TlhPeUdTbEN3NTlvZWc3RXlx?= =?utf-8?B?ZTNUUzNuVmNER1dKMkltU0pCblRPc3F3NDgyTkZzQWhQdDJUSE1qbFNodE1a?= =?utf-8?B?YU51WGRmNjEyUXludTBKK3VMUHFVUTBHamVvUEVMWDhvblNhcVBOS1QvYUtN?= =?utf-8?B?Tnc3dUJZYlZZT2FacCtxK2QrNEE2NlByNFREL2trTUdmZ3VaVDBsakt0Yjhs?= =?utf-8?B?NUFQNjd0S0tHOXpYdDdGQngwcldYTEg3aFByZ1AvRG5jdXFEdUQwdk80bGxH?= =?utf-8?B?VEZ5cUQrcTJ1alg0NUtJeUlneHFzNVdLeExiWFBnNklEaHR5cWFtVXQwUTJw?= =?utf-8?B?UFVUSG9oUVBaaENhbktZbUNxWU9jYnJ3SGgyRHd2MTdrR0prYk44cmNETmdj?= =?utf-8?B?Z0RpbmwrcW5OMlhmaWZvREF3bUo1OEt5K2hLV1cvNjVaRytwTHRDYmVpaEVk?= =?utf-8?B?TTNTSWFTa3duZURZd01CRGZPK09PRGlJSE5zeHpZTkVZOVgvSU1XSVZpY0p1?= =?utf-8?B?NUtBOUltcVhVQ011dk84dzFYVVVqbi9vV3gyVEVQN3h6ays5ck1wWStPTC9V?= =?utf-8?B?RTNES3RMWHh5YUxXSndLeHZvLy9pSUpHOHlFeGZoRkJaTVk4TkJnNitEWG9i?= =?utf-8?B?SW9TZEZ0UCtQNmNoS3lDNzRrQm91dFdHdjM3Z1U2cjQwWG5yVzFEZzJhZ2RO?= =?utf-8?B?ZWZxTXJNY1BTZktHRkxPTDhuUGpjRE1LSk9VcFJsM01NY3JIQVdtdzhwUmt3?= =?utf-8?B?VFI4OC9qYnFPMVJwZ091M1BYb1dNLzAxb1B5cTlmWFpCMVJjMmJTbGV2bnIw?= =?utf-8?B?SWd0VmlPbTYxYlIzUkFVaWdwc1k3RFhwMVdqV2J0STVjMWVyaWtIZU5tajhQ?= =?utf-8?B?WExGTDQxQmRsR3phTVVOVVF2cGdhRTNHb0VrRWVKMXI4eXBiVXZoRUZ2bTRy?= =?utf-8?B?REVKZ3BoNXNMN2krcGtmSlFDcWxkeHkwKzQ3bk9QS05vMFpCdHY5NEsvanVv?= =?utf-8?B?ZEl1S21HakpFcE9HUDBzRlMxLyt2NlFiSjc2OWVVR0oxdUFFODBGV0U3Vmw5?= =?utf-8?B?QzFDamErSkFMMXpKVGlsYUdUYlFpRlh0dFBxRDhiM1I1eFFpcUhzcDNVRHVW?= =?utf-8?B?WmxDODhpSVREUzZqVGdqcE9NMWN0cGNSdHF6ZWJrWkRiSzhRSFJHdXU1czZG?= =?utf-8?B?SGE5bzNiUXl0bnAxa3BSVWhZQTBBQlhsSklPWlRDRWQ2dzRiTng0MGZXZVRa?= =?utf-8?B?c0p1amFzWGtGTkJIRmUvLzRuZ3B3Z05Pb0owUXVpdXd6SGp4NllqV25MVmYy?= =?utf-8?B?WDRHVHB2czUrWXhNeE1ienQzV0h0d2dMMWNjNGZpYk9YV2J3TFE1dEJORno3?= =?utf-8?B?QlkyenlCK0dFaVRMTXhxc01IYjFjSFZZb2d2TGtUanliYWRUcVVFMWtWR2c5?= =?utf-8?B?V0pyOVJBdFpYNVhBcmpRLzBZa3RIWXdYZ1VpbUk1SFNDTUllMkhJSStDQTls?= =?utf-8?B?KzRwL0NtOFhSdXM4REE1aTEydFFqSmdVUmRTanp4N2hqZlJLc1dWQUFQaE5p?= =?utf-8?B?L0VBb3M5VHRDckpHK0JyRkYvTFNGRlo3dWFWRTZpOHBZVU8xTW8vU3JMMkRM?= =?utf-8?B?aFZUaFZKRXFYS2RxQTZoUCtocXkrTWZoc1V3djd1TmJTdFQ0Ym0yS1kyL1g1?= =?utf-8?B?S0ZJV3VjcEZGRzFzR1l5TEF1aktURVp6NnFzN0o4dTl4aEwxM3haSWxWRlpV?= =?utf-8?B?ZVl4YllNSys3VnlIU01rUDMxaGhsSFFtYThrY1B3bWkxN2dHNi9vWWNGNjJn?= =?utf-8?B?L2VzdDRDd3dyNnFsSWdPSTYyUDYwQ29kMmZFclBWWGg0RkxCWEFhZTBIME9s?= =?utf-8?B?Mlg1MkJhd3U5bUhENnN6Nk1lTHI5WFNNWk1TQ3ltZTRRVkJpeElZQzdpQXhE?= =?utf-8?B?Y054V0Vha2drV2UxYmR2RllTSlArNk83NWhuMFloUlNJUWN5dnZoYTBCR1BY?= =?utf-8?Q?6DwFvW2ix+2B/PPqdodjBlg7V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2747de8f-7270-4c67-d7c3-08db0ff564f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 08:11:23.9882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8svDhPx4C6wO/bv+ios2WMdnSj/mahtZ3NyckYFnSNs63JbC8t6l5w/wKZg+N+UT4dKafi1YRlAcrCQlC0Rs8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8030 On 15.02.2023 18:41, Anthony PERARD wrote: > On Wed, Feb 15, 2023 at 04:30:43PM +0100, Jan Beulich wrote: >> On 15.02.2023 16:21, Anthony PERARD wrote: >>> @@ -13,6 +14,10 @@ MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile) >>> endif >>> MINOR ?= 0 >>> >>> +ifeq ($(origin version-script), undefined) >>> +version-script := libxen$(LIBNAME).map.tmp >>> +endif >> >> Such a use of $(origin ...) is pretty fragile. Maybe better use ?= ? > > I'm not sure why I used $(origin), I've written that more than 6 month > ago, but this way of using it is actually described in the manual, when > documenting ?= but with a = instead of := . > So, maybe I wanted to have ?= but with immediate evaluation rather than > deferred. Maybe I had issue with $(version-script) evaluating to > different values. What's wrong with using deferred evaluation for this macro? $(LIBNAME) (and $(LIB_FILE_NAME)) don't vary over time, do they? Plus ... >>> lib$(LIB_FILE_NAME).a: $(OBJS-y) >> >> Seeing this right adjacent in context - any reason you use libxen$(LIBNAME) >> and not the same lib$(LIB_FILE_NAME) for the base file name? > > That was the name used before, I guess it would be fine to rename. I > just need to set $(version-script) later as $(LIB_FILE_NAME) would not > be defined yet. ... you'd likely deal with that issue as well, unless there's a "too early" use of $(version-script) somewhere. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 08:12:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 08:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496396.767121 (Exim 4.92) (envelope-from ) id 1pSZN3-0001hp-7V; Thu, 16 Feb 2023 08:12:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496396.767121; Thu, 16 Feb 2023 08:12:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZN3-0001hb-4a; Thu, 16 Feb 2023 08:12:01 +0000 Received: by outflank-mailman (input) for mailman id 496396; Thu, 16 Feb 2023 08:12:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZN2-0001hG-9h; Thu, 16 Feb 2023 08:12:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZN2-0004fw-7l; Thu, 16 Feb 2023 08:12:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZN2-0004v1-1X; Thu, 16 Feb 2023 08:12:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSZN2-00054u-18; Thu, 16 Feb 2023 08:12:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ojaqbMVu/yZOF4GpVxcN73f0lyn9rCk+sWD06phwPQg=; b=DYMedpzGlAWidgGLobycm6nS70 0QEbqmqbzQ/NpjPK7Oo/F/ZCd04NQOsMzLq5bIV8/FeEqlqdQeVCH5PMpRtRrLxpmOpbun5WDJ3Ab 1I4trB1cE5Q5cK6qfPI++zhLNJUSkAnhBK15ggxMBaTtd8Hb/ufZMbcVJP0UlyrixAlI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177466: all pass - PUSHED X-Osstest-Versions-This: ovmf=5c551d6d912967ada3084033acea8acf37256043 X-Osstest-Versions-That: ovmf=38da9606f77842cdcdc231210c0369a6180c51a0 From: osstest service owner Date: Thu, 16 Feb 2023 08:12:00 +0000 flight 177466 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177466/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5c551d6d912967ada3084033acea8acf37256043 baseline version: ovmf 38da9606f77842cdcdc231210c0369a6180c51a0 Last test of basis 177386 2023-02-15 12:42:35 Z 0 days Testing same since 177466 2023-02-16 06:12:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Ard Biesheuvel Jiewen Yao Ray Ni Sunil V L jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 38da9606f7..5c551d6d91 5c551d6d912967ada3084033acea8acf37256043 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 16 08:19:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 08:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496408.767132 (Exim 4.92) (envelope-from ) id 1pSZUK-0002ov-1u; Thu, 16 Feb 2023 08:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496408.767132; Thu, 16 Feb 2023 08:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZUJ-0002oo-VL; Thu, 16 Feb 2023 08:19:31 +0000 Received: by outflank-mailman (input) for mailman id 496408; Thu, 16 Feb 2023 08:19:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZUI-0002oi-Ny for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 08:19:30 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061a.outbound.protection.outlook.com [2a01:111:f400:fe0c::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a2325ce7-add2-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 09:19:29 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6865.eurprd04.prod.outlook.com (2603:10a6:208:181::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 08:19:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 08:19:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2325ce7-add2-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CkfQJiNuFbRUn0lX5s+lDOYdjitcIzX/d3iBtZpnCLBXaz/BPDUBZIx0CdUecUMsSgKkrV1HPkuI5tWlOEt7MRt6aFtDc0oTyOwk8HjvU6WIxdhSrnrkG2CykKBmFJZYN2fAydTqfOvEJKcY4gnmOL0BKgcdyRDilrdLRgp2vRwSZ6iWesFnwDKnKnpUXPucV/5gvFLZkU+ZB8hH9DM+IPIr18T7ykye2HfSKn/EIbPwLSjhVqBtgjCh9Zg3xjKSh073F/k3jav+C/dqZNbfk4xestTSa5CYQHoshhUHT0CCw/MzgZEnkZxiCLYabzjjhBhwY+0bzcd50SRxsSdrXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8raGTr4cPQ3xqEcVtwLlyww1rc4+7cK41BCWp5RU16Q=; b=DII7gydDcZRLhwCqH0mBPtqCdrBpekm5Fwqc66Zfu8GH0ri3DTa7gEX9beQNTnzDdWdp6HKTC+6fZjFdL0x62kZxfg5GGgGCkVspJuxmxiBs4pk7Rhpm/pathVz9812ajC75R7Iwrt4XKPn4x7jDLQQmEb78diVJEdxwe1Rszp9OKf4UY6RJkgCNzkerAryWRKNqBGLvko46KhL7PrYCABlENwAB4XhhIKMfY7qVdma6cbyBOpt9Sm0EwJzWwNahEZQlxGYX4GSf1YN8mdbZSSYKq/YGtDXcdOfY7oCGetgn8JsjE+dV6LsKnfJnto70W7I6Xc5/X+Ds+vGRxJWDeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8raGTr4cPQ3xqEcVtwLlyww1rc4+7cK41BCWp5RU16Q=; b=RchW6vV+UeZyF4nblTSWNFxv0qF0XyFnUIANUQ5JSQbSzJdgFXSUvs4IZnvD5QTdxaP6/uRJDqVmDrrfS6j+guXAIYptgnk/LgFoCj6saTBz2q43R6V+CMwZOI0VsWFOp/txkekSlpX8GOg7voPfEOHE2UKDGW0Fl1lLNssCgIIMz8NG8AJ6Zsbd67bAK5ywMyBU8o7XLSlVYH7O8ZpjBpiE0+MEcDIuaCxassGU822WROOkK6yz/6QoGTNfjujvnQquJmMF8MbrgLcptChLMZEc1VuFDUB+HJo/v1HmVhPtZ0kgahN8HTPLL00rW+X8Txc4/0ONqHtkCwVNYmdMWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> Date: Thu, 16 Feb 2023 09:19:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Content-Language: en-US To: Stefano Stabellini Cc: Luca Fancellu , wei.chen@arm.com, bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6865:EE_ X-MS-Office365-Filtering-Correlation-Id: 94c2c761-9070-430a-47a1-08db0ff6851d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4bNWYH5E//4qrkbXVno6VbKES36AKu1RtMaYzWhZvAKPF16EHNYHQSGCgz6LBq/0QyJ1Zq3gYKvEUCJg0Z1JqK2R2ApQxR4nm1TIg7wvw/2CKX9AamipgLtW9KeUk9a3emVUhNfLmeCn6DV5ZOzIk5v1dPm+QjHRK/sBeFKQqvRGtix+K3dFv+0rT+sEcl253yA/hytui3SmIOZgs+SBpcXNXLm6kOaWt+6HW0BpExq1phI2hKJ5614DQs3PiobcY2rGnB6xKiYZjavqZYRYv9sbolWTqSdYc71LOrE+r0gfP/QIbeXWOsHDVe8/QGlj6kJzq9vv8UYiiatQd8+5NTCozS5QFvJACZqSE/7xxnbkjjRkX269gObEOwMI5PPg4Wr/OQZ67SRzNm/KPBB6jFjJRPmIcaVUXvvIgshizQYeCTcaWz1MtpknlRIwSIxlpVfsliBT2o99KFj9x8ttHttKkeZcownZOSnu3qbfNTLFXhFt3abptSatMdvMPVfwnB6XhQWTI7SpGlG506K/V62bWLPhJ5AFV6K2rVk5BE+DtcdXHQMxIEijgfoVvIpZkBZBkLbomQ5GfyHxYlnknsYyPZXUlmvKNCoJq/jVLOGw2HxxcSk2JCPxSPVS45VBqpkyj7g7MSq97ewAlGgP89g/GPEdDNopY05k41rNSHSMMatJH0dqcgj0fggEpLKdXGbrVDGwhohAiayqoFwGnlrLkPRVJ7zKeh54as3336U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(136003)(366004)(396003)(376002)(451199018)(66899018)(31686004)(36756003)(31696002)(86362001)(66476007)(2906002)(4326008)(8676002)(6916009)(8936002)(41300700001)(66946007)(66556008)(5660300002)(7416002)(38100700002)(478600001)(6486002)(54906003)(316002)(6506007)(83380400001)(2616005)(6512007)(53546011)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWlDaXFQaU45bDlsRC8zV2dKV1MyVytoVDJFTnFZY2pMMzZqa0pxL0U4dTR5?= =?utf-8?B?a0pjVmNUN0czTXVPdkJhY2JpSDExQ21zQzFYd28ySmlRR09pUkxXbUxPWmYy?= =?utf-8?B?Y1NVblpwOW5Xd0hXSThXQWlML2s2VHRlcW1uNlZhaStHNm9JTy9SZ2lRaWNP?= =?utf-8?B?djkzd0M3UkFncEpvSCtxUXR4VU01RWd6OE5HNnFMdDdyZ05lV1lHWXk3MXZt?= =?utf-8?B?RDkremh1UVVJUjNTU3poMGRuSDd5WDZYeTg1Y2FTK3VSOUQ5WTFqUFNBUWxV?= =?utf-8?B?T2NDNWp0MVBOL1MvTVpHRDFLcmRRYy9rQU44dkhJSWl1c2xuZ3ZWWFNQK1FL?= =?utf-8?B?T0xnNjR5bS92bU03OWc1UHpDVFJ2WlNrQWs3aU9UWEdVblFYMkpSc1VjV3ZR?= =?utf-8?B?TStOS0xrTktqSThwRUVDOTI3Zy9BOEZvNXNTVnM4TXhMR2o0RW15aWpteHFa?= =?utf-8?B?NjhrdDFyT3p0UFcyckFqYnQ3aXdWKzZ5RzJsSU1obUtkL1U3MEl0ZGRuOEtT?= =?utf-8?B?SUR1REg0aUJMa3BQTU5FRUlMa1VlKzByQlJRcjNhSXE2QmxyM1c1SGF3MTZF?= =?utf-8?B?TnlGdnZIS0lDeW1yVUw5elZkZEZ2L3dlbjRzQlNKTW10ZlcvRkdvUm1DUlMv?= =?utf-8?B?Tjlob09JOUI2dC9ZckszVXhWbnUxQUZ6M0dNM2p5NVFzaU1seU9WUDExZVp2?= =?utf-8?B?ZHcwVmc5VGgraE9mQ0xXclVxbjFaMkRRYWRXRHNHM3pGMm96eVFXYUF6YllB?= =?utf-8?B?RlBkUy8zUDFqMThTdU9ndmc3SWZqeHhvZXZuRTFQMERCYU9uNDNHaVh1ejIw?= =?utf-8?B?UkQwRFpFb3JZY04xWDFpVno2Qk5rdHVYUVFVOEU0OWMwY1ozOXNwTW9uZVh4?= =?utf-8?B?UVpndzRaNFdTWXloZndpWTlWRHB6VzVmaGZtSDRMNWdIVVl5V0RYZkJYcERz?= =?utf-8?B?dXh3UTNnRGtOaDNCbldSVnFNZ0VnZThHcWh4bWFjWVpKQ09WaDRNQUl5K1Bl?= =?utf-8?B?OWswOUVnZzQ1QmUzZUt6dmpxRVByTDFXWitTdWZyK2hqSWpWYUFUWDR0bFlF?= =?utf-8?B?YTdQeDA5TU5LUDhNK2tiQXBwcWt0UTB2Y01BR05RV0JtUEEwTTMvemswNGJG?= =?utf-8?B?RytvWW1BS2xWckdveEdUQy9pUW1NM004a2xjelVRSFJ0ZEJBZC9FcGlzUkxK?= =?utf-8?B?VGk1M0NvSVNCaWU1VzBWK2o5N29VaGxpbUlGRDgwQk02MlpPY3kwRGkxNk90?= =?utf-8?B?cXcrNndIMVJGTXo4UjQ5VDh5RG10ZWZKaXpxRDlWdkM2a0NDVVJia3YyVHU5?= =?utf-8?B?U3JiTkxXRDIxRkZpVGR4YzFrSmFuMEJITXQ2RWh6T096WFJuaUJKVElGV2Fr?= =?utf-8?B?OUJmQ0djRFFiUUlnT1Y1WTRYTXAxOXR4cEJ2ZjRCa2VlNzVSNnNLbjNNN1dF?= =?utf-8?B?RGFPcjNxeFBGRDZXbG94bkg2TmErTmtKNXJaZElXT1A0OGJadFNyZ09NQ05W?= =?utf-8?B?OHZOcjdoWGdLTjZhdzFDd3F3cmJvZzFlc3RhUmcwTkNHbi8vR3BRRW1VNEhi?= =?utf-8?B?ZWJpZXI3R3pPTXJrN0tzNnUyZzFQd1BocnJJSytoYXhhZGZzTnZJdEcwRXd4?= =?utf-8?B?SXVoWDNwTlNVV2hPM3BaK25xNDJhcWc4cTBpZjJZWlg2MkJ4TmNvUVJtVzc4?= =?utf-8?B?dWJGMjVyUUJZZFRxdm5tM04rWnVUSXFxbDhBbWd4bGxSSFhLRFF2MzhYRkV2?= =?utf-8?B?US8yWHF3YUdLNUdyL2VCMzZ1dWlXSmp4NzUwTS9td1V0R0srakxDNEpwRU8z?= =?utf-8?B?U0doSWRUd2o4cWdEWE9xZWFVT2k2MmZQb0NPZ3QwZkxrOE5kT1FVYzFMcVBF?= =?utf-8?B?UjY4SE9CU28yMmFMMDBHRTdkbUZrSlJ6OURvb09UNHZXZ1RoSzFVVlE5ZDdV?= =?utf-8?B?RDRUTEt0Q1VTbjNVekhBcmo4L253NDVPbXVWZ3pIQ3hSYUwzdXJzdlROYWkx?= =?utf-8?B?aUFWT2FJZlFmWFF2ZjR4akVzRDE1b0xFNmNYTlVrQzdtb1lISWJLWkNQSlI0?= =?utf-8?B?OWw5SXdwaGp2TW04MFNUSUJHMGNsbHNibXlwREtlK1AxdldFdjAwaE50YjNs?= =?utf-8?Q?5WrsPXKs0MopjVhJSwdCHvLj2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94c2c761-9070-430a-47a1-08db0ff6851d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 08:19:27.4592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9h92Mua3/pUnciKLwg7RwF+PrtF7vv/q9mv4GOjD8UUlMaibWXwoJVlla1IXjW7jvcem7EUE7/P7hT6xAlwr7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6865 On 16.02.2023 00:49, Stefano Stabellini wrote: > On Wed, 15 Feb 2023, Julien Grall wrote: >> On 14/02/2023 22:25, Stefano Stabellini wrote: >>>> Patch 1's example has a "comment" field, which no entry makes use of. >>>> Without that, how does it become clear _why_ a particular file is to >>>> be excluded? The patch description here also doesn't provide any >>>> justification ... >>> >>> It would be good to have a couple of pre-canned justifications as the >>> reason for excluding one file could be different from the reason for >>> excluding another file. Some of the reasons: >> >> I think the reasons should be ambiguous. This is ... >> >>> - imported from Linux >> >> ... the case here but... >> >> This reason is pretty clear to me but... >> >>> - too many false positives >> >> ... not here. What is too many? >> >>> That said, we don't necessarily need to know the exact reason for >>> excluding one file to be able to start scanning xen with cppcheck >>> automatically. If someone wants to remove a file from the exclude list >>> in the future they just need to show that cppcheck does a good job at >>> scanning the file and we can handle the number of violations. >> >> I disagree. A good reasoning from the start will be helpful to decide when we >> can remove a file from the list. Furthermore, we need to set good example for >> any new file we want to exclude. >> >> Furthermore, if we exclude some files, then it will be difficult for the >> reviewers to know when they can be removed from the list. What if this is fine >> with CPPCheck but not EClair (or any other)? > > Yes, the reason would help. In previous incarnations of this work, there > was a request for detailed information on external files, such as: > - where this file is coming from > - if coming from Linux, which version of Linux > - maintenance status > - coding style > > But this is not what you are asking. You are only asking for a reason > and "imported from Linux" would be good enough. Please correct me if I > am wrong. I guess you mean s/would/could/. Personally I find "imported from Linux" as an entirely unacceptable justification: Why would the origin of a file matter on whether it has violations? Dealing with the violations may be more cumbersome (because preferably the adjustments would go to the original files first). Yet not dealing with them - especially if there are many - reduces the benefit of the work we do quite a bit, because it may leave much more work for downstreams to do to actually be able to do any certification. That may go to the extent of questioning why we would bother dealing with a few dozen violations if hundreds remain but are hidden. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 08:32:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 08:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496413.767143 (Exim 4.92) (envelope-from ) id 1pSZgN-0005TJ-5k; Thu, 16 Feb 2023 08:31:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496413.767143; Thu, 16 Feb 2023 08:31:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZgN-0005TC-2L; Thu, 16 Feb 2023 08:31:59 +0000 Received: by outflank-mailman (input) for mailman id 496413; Thu, 16 Feb 2023 08:31:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSZgL-0005T4-J9 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 08:31:57 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2049.outbound.protection.outlook.com [40.107.13.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ef2318f-add4-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 09:31:55 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8755.eurprd04.prod.outlook.com (2603:10a6:20b:42e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 08:31:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 08:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ef2318f-add4-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gs51snOTBasR00t+ejmxsUeaYNnAlJ1GqArdy6itrFW6ujEm4+y+tIZ+DeofpjSIeyYdiB3HkmnskDXnnLgfL8qRWzCNqdGGMgxoJlgD4OmuwxTdQ95mrwfahjtFDUfy9KcXE6Vq0UuT+5O36aXXfvl5Y4l7OsAXRZnFk51W+K9rBRQBIKk6dMrfcgoMAshQUTV2yMVMi5jYFQgiLU8HzSjAbxDWkCGg/Pp2+dHv+UgsOaPuZkklifk9EuMiZVQmRlImhLPt72fizlNg+Xszus9V3WwgCDPwV7WQUPN6yQY//r/uJmR5wojkDVHhQm9hHGScF+tXVdtVweBPdlJJYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IxwyBi/6+06GlqNrP1Mmqf7cL5IXjJEd77QWsj/4MYY=; b=Fq5tH6d/Q1c1jV+srS2LRdirrfqoFW9k03ou+jIIo+TwUJFpot+K17v/G4tKwodQlJ0T1LDGzmPX1PpoYuPJ0SZRKyl01L33hVYW4mGlNcGGK160l6vPddgJxW5OS+TcswKO96Og79Ep8bRfBnslMJMUA/k6XbUA+TporZetWQdWBoFO3DZ/olk0iSyvr9qGnaCYVAU0aMa+lwes6d7WUf8viam9w6aXQgZohakdQ7xjSa226g3d0kWU/amk0seVL/VRYTcX9vVFUORv8z2MrAyJ8FyHxra+ppyFuD83/sh8Dj24kMz4Ml77e24GLGt/KWSt5FHSN6wLbWOmpahJ3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IxwyBi/6+06GlqNrP1Mmqf7cL5IXjJEd77QWsj/4MYY=; b=mYeGWLS5os4Sh7dhKW0urF033eQTrbwuVowiaxB/GDSMcazFFSsXEHMW9hMuhazHx367Yup3du12MVMD/xsAfNV/3VIqdzkf3Rt0LSNmMlxt7lwEwkdbZuxZAgvQjUO4qL+3Jh3lTNyBSNbNbmXEaZkEPnTcELFmUmN3FtThmrFq6CTieFGPTv5n3F7MmCU+kf4pa83T7yUiHzRqHJMnEYgRvqenDnpnDarudtlG6xFF+d7FEpgMPmQNIJSMvAASkoT4m+AUoIH0msg8H1++DuJ1nXg8CKiiOut1VqFqLc7OCYFMw9Rd+xn3Iul3yCdERakBIH/1OSFxJ/pczXePWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> Date: Thu, 16 Feb 2023 09:31:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8755:EE_ X-MS-Office365-Filtering-Correlation-Id: bb5e8cc5-0c91-4d31-92ae-08db0ff8318a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hQJhM4IElnEkSXfixeOF3RA9bEaoz1rDbcn0wL25m7ZLrKnqWWv+OJCsAH8uakJTJT3kxrK3eokY6mvi89rsf7Gvf/VKDTQGLgLmLfGBDZxyYw/fQzu+TPWl9EsUjLn5OlGG34ijYO8db3fASfE8Epzjmp00MwaPAlmBAUF4516Yc6fFHkqXU8hPLacvSFl7X2fkTNYuQ5ARwvFQPbqvCAmbglYxDW0L47UlKdxpTZPbw+on9WIu5N++hE+gyVSRku5L/CKKdXHz5SKNQFu7bZt+TTKLIgTmhulYmXFntoQ9FyYBAPfzPs9U3RIgXLEtBCIM4yLPhoaoP4WaugzZ5lrvhqn/EDNlb92AvPkHjx2RwLiHyqJWGL/gqmirNTjX6vtdDuTX/RRJMRgUkSRqnorXt35FmtkAta96QWX6LRwiOdkgE+/K83qZRM6q1hcuiUSlmEDnLxVkh8RaImPFIo11+F/+Q9BgHOe02SwFVksfnKxfV6LJmHsNmN3arfDA9mUXsFYe04dngXl5ThSzZZ9gAKdj9UjlsNqM8m4yA74tW9+NvYOsHBBs3JoHzkzqyb0p4ldAf3+8VwB0kYuEF8Tte3X/xK5E3R9ANCcpwhp+mM+ym/HCvnepwe5c+rafybXkQiqG7BkJJ9MG82m33BRKRcEYHDIw6Jp5n1xyf6d/Xw+y+hyrdNJ4YRwd32rF8PYkYO4WN8ejl7mLN7U67N5pWKzMF3YjQds/7cd1ol0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199018)(2906002)(36756003)(6486002)(38100700002)(6512007)(186003)(26005)(2616005)(83380400001)(66556008)(6916009)(8676002)(4326008)(316002)(66476007)(66946007)(8936002)(5660300002)(54906003)(41300700001)(53546011)(478600001)(6506007)(31686004)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmVDQWYrNCsrM01NVHJ6VytoRGovdGhGUW5oRU50UnUralg3QzlGSkxMOUhD?= =?utf-8?B?RGJ1QnQwWEtoSmg4SjU5Q0FPSTkveGhKQ1YwSFJMTFlYYzBSUnFDamF6TWFW?= =?utf-8?B?MDZsYkJDQU9xYVVZNzAwdVNzU3p2U1BpajNNR1dYVG96UW5VaG5seEt1cWpy?= =?utf-8?B?V2s4Z1NONzFQNW1JYXFEVW9QVXlpODRIbERNaEl2d1pzM1pxZTV6bWYyVlEz?= =?utf-8?B?VDJOMDJDWU1xUGtaWm1DVlBTNmZOQk1CTWhDTEdxaXFjcVhsVHNGT3lWeS9z?= =?utf-8?B?Vysxem9xUmJZbmRWdndYKzFsU3ZUWFAyNnJ2TUVwUk5WZ1JQV1QzQ2F6Yk9z?= =?utf-8?B?RDZYUi9LUVNaQ256MjQyUmhJSCt1VHZzbkgrZkJPZlY1MUt4cmtYa1lWMTB5?= =?utf-8?B?NXBueWszK050bXpQWHJ0QUExVVE2Rnlmem9qZ2xLaVFCeUhpZ0lRQ1h6MVNx?= =?utf-8?B?SUU4aWROcktURy9iOVppZDBCelk1UVpMaUZWYlJRRzh3SzhySllBeGlCQ1Bo?= =?utf-8?B?UHZCSGNmQTZKQ29YZ1NwWlhqMTI1TFNXa242SE5TSmc4MjNwZVlydTcyUEZK?= =?utf-8?B?Wm4yVzB5UTVqQVBETHc4eHdOYmpyRnFDU0Z0SmR2a1A4YXN2Rk1TWXVoU01U?= =?utf-8?B?d2FMY2g2ejdPQ093TzlXa2RBMnlmWndCM1BuN0g2U2VIQW1vR2UzWDY1cGhn?= =?utf-8?B?bzlGdG5ZTW1OenNUU3V6cGxtTG1RMEthQklTbkpxaFJvNHNzRnJiSjBaTEpw?= =?utf-8?B?WXhNdGRKV0xGcE40aTVEN3k0ckhKd2NST3l1OVVsVkg1WkNQVUE0N0EyMlFj?= =?utf-8?B?YjVLMlZpTytLaWN6VlVNUXVyRlcrZTJPMHUwR1BVWElZcjVNMlVJOHNqaHp5?= =?utf-8?B?MXovSzJkS1luRnBibHdrTFdMOFZwK3p6RWZBeHdjY2Q1ZFRrSWJmNVRvbDJr?= =?utf-8?B?UmFBQmpmdmZKWWdDYUtxV0o5MmpGeDNoK1Q3QlpPY0lsVDVWL1I4QWd5SVFn?= =?utf-8?B?K1d3QXF5b0pWYjJscVFTZmNJQnFubFQ1Yy84WVJ6YnZ3c0lYMUUwZ0lyN0Y4?= =?utf-8?B?d2hkempOSHp3eDNIcWtmOXlkZmpGMjBCZmZqMkhFeXhJWUdKQ2Q5SHJweUZz?= =?utf-8?B?Q3U0Y28zTlFRTWN3V1hJdmdqbEg5T2p6S3dyam5pMFJiTE8wZnA1RnZVN3JX?= =?utf-8?B?WTYwVzNrZ0IrMmdHNGVPU2kxd1RqaGR2V1dqQkk1MnlqRG1pcWRXczJjU0Fm?= =?utf-8?B?Z2JmSU5ueER1UFk0VytFOVBscnViQzNWWjJIbklvNzFsUFFJbWwvWGZaaVYr?= =?utf-8?B?Qzh1YW1HSTNZNnUzT1JwTTJEN3A5VFdkYVV5dVI0c0pNcndGZ0g1SFJxNEFM?= =?utf-8?B?YzJ5cUNLZm9pRGdETnFsUWpwcm9vekRhTGV6Y2lDUWtPSlIwUmhOY0ptbWcx?= =?utf-8?B?cFBnTVRqMnBwTnFlbGJMWGlObWQ1djRxZ3lTa0tud294WkpKOFpXRDl2SGJQ?= =?utf-8?B?YzZKQ0hKeG5PT25WNGJxT043Tms4SGZIRUNtb1hNd3pSMW0xbVAzQUh1dUFM?= =?utf-8?B?ODhqS2VUTkZIUE5Zc2xWbnRwL1hQcElwMHlVZUdPdE1LRFVsdE5RRk94MEc0?= =?utf-8?B?aHYwNnlPb0V6Slk4QnZ4STIyVDlqZ0R5cHFrcVNmRWFQZXB2MzdOa3RlUUNI?= =?utf-8?B?U3RLbkRWQ2JFb1BxbGhvK0g1OGRRaUNpWGVzWk9BUG96QU92QzJteFdtTllC?= =?utf-8?B?Q3preWdRbXBLbVUreFJXdWpMSHRLQld2emY4dEZQck9HbE8vbXpxYzJLZlMy?= =?utf-8?B?aEcxNUQzalVMWkhDQ0ZLZWJ2NmI5Q1NmeUxwcmNLU2dCUmpobGtMenZuWFhP?= =?utf-8?B?UU5ZN1p6MFVaMngvV29KVXViL3J2TVFrakg4MUZsaXB1cUk0Zlhqazl6c1dv?= =?utf-8?B?bkFWbWtCcFRJcjhEN1U5dFVqcUZHSm9mTTN4Q3Mwc2UzSWZYMHNHVTVVVVJI?= =?utf-8?B?aTZaajYyajBnTzBnc1lIN3lTTzVZZHZHbFlxcUFyNkpJTXp5Ukp1TlNIeGYv?= =?utf-8?B?bTFkR1drMjNjVTZNdTlNZ0xPYUNQdmt5QzNrZ3RXbVUzNktUSFR4ZXFmR05h?= =?utf-8?Q?Oj9bnCLFonK4SluV0Tml6NoNn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb5e8cc5-0c91-4d31-92ae-08db0ff8318a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 08:31:26.2246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QwIv5/i/nOf9yxLHBze98YFkFvmhooQjpel/ySEZagSHT5kz/SHsvthvkDLbaIM66qEFbCdDdM79kP73z868zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8755 On 15.02.2023 17:29, Tamas K Lengyel wrote: > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: >> Did you consider the alternative of adjusting the ASSERT() in question >> instead? It could reasonably become >> >> #ifdef CONFIG_MEM_SHARING >> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || > !atomic_read(&d->shr_pages)); >> #endif >> >> now, I think. That would be less intrusive a change (helpful for >> backporting), but there may be other (so far unnamed) benefits of pulling >> ahead the shared memory teardown. > > I have a hard time understanding this proposed ASSERT. It accounts for the various ways p2m_teardown() can (now) be called, limiting the actual check for no remaining shared pages to the last of all these invocations (on the host p2m with remove_root=true). Maybe /* Limit the check to the final invocation. */ if ( p2m_is_hostp2m(p2m) && remove_root ) ASSERT(!atomic_read(&d->shr_pages)); would make this easier to follow? Another option might be to move the assertion to paging_final_teardown(), ahead of that specific call to p2m_teardown(). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 09:21:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 09:21:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496421.767154 (Exim 4.92) (envelope-from ) id 1pSaRW-0003zJ-Nb; Thu, 16 Feb 2023 09:20:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496421.767154; Thu, 16 Feb 2023 09:20:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSaRW-0003zC-Kl; Thu, 16 Feb 2023 09:20:42 +0000 Received: by outflank-mailman (input) for mailman id 496421; Thu, 16 Feb 2023 09:20:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSaRU-0003z6-Fc for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 09:20:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7e1b::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d02f2fa-addb-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 10:20:38 +0100 (CET) Received: from AM7PR03CA0014.eurprd03.prod.outlook.com (2603:10a6:20b:130::24) by DU0PR08MB7908.eurprd08.prod.outlook.com (2603:10a6:10:3b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 09:20:27 +0000 Received: from AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::c) by AM7PR03CA0014.outlook.office365.com (2603:10a6:20b:130::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26 via Frontend Transport; Thu, 16 Feb 2023 09:20:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT045.mail.protection.outlook.com (100.127.140.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13 via Frontend Transport; Thu, 16 Feb 2023 09:20:27 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Thu, 16 Feb 2023 09:20:26 +0000 Received: from b3d908137580.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B97F67D-92AD-4891-9A8B-64EFFC963F27.1; Thu, 16 Feb 2023 09:20:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3d908137580.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Feb 2023 09:20:17 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV1PR08MB7875.eurprd08.prod.outlook.com (2603:10a6:150:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 09:20:13 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a%4]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 09:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d02f2fa-addb-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnhWRuafTNaHNjZqxffw9Lv0d5D75v7WU31Pbpn25sE=; b=2RD80xLpjbRGTEkW40gmQqnumijqUT7/FYU0Clhze6Y6QInWWasRNu6+cx7YqBlgrVUAWtQULELQpQFI9sgnJu1hqXZRM0fyWZpiNslHg0DGHQIl2cQpQYI97Dvg9U6AcHKF6uNs7JqrcZDImFsfdexFaATBDYjCULnPmQA/fTE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ac422f61d12b0dee X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yjjwesb91FDqxEqFNtG1E0kXHu8qvLFL1MyHoRXyfsSM4eBTlAsd2tZG45iTlauprSqyBz8GY55KpvpzWE1r2V6u4Ao5wRW6NapGUGiKWU0EuwRN3co+y3P7RlsdpDvxOjVrNBBODw4SZG6Uru57Kl8LYrh3S36xsk9vuIjQnpRtpSjXJ/Yv6hahDDK+2JkvgLi69l2QGMHLreBRtHKnECs4J0Q4U+mmk2thiNUyr9McNlYvQeA5/gnA0IfV4dfQkGX0rhLNTB7NqoWmKFdFlppCSZmziscsuvZ+6E8PKWxtpwzRrVwqG/xUQ3tMfazkA5Dm2CEyy6JXLXdP9x4snQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BnhWRuafTNaHNjZqxffw9Lv0d5D75v7WU31Pbpn25sE=; b=DrfiSLFH3RE1Tm1poJxn5UJ27C61lLOmon5x1GbC+OqaIFZFw6ic9B/0ApCfyA9NOEDV9NAlXAvTf0sG7eAlcgfIp9QPpYEFudAfkBpXFyr1gSf0KUwaKZJ2qH5l8IfQE0TkYkAc1m7HmnimZ5sw9jmVnLNu4jKOWd0dQxxbMvnkVIyak+2xgpFyFzGiDaX+f3sh1tAgSB124ewN7xGeAC4UvLz6dT4CIsg1rd9y0+2dSsoUiD5/j8ZjZzEfgTdO8WHe4xl26gc73qyRY/m/JC813CfJ4YRyAiBT8romlFRcZzROt7emyugegJhUQ6MZ2OE1LafP6kcvkAitSm77BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BnhWRuafTNaHNjZqxffw9Lv0d5D75v7WU31Pbpn25sE=; b=2RD80xLpjbRGTEkW40gmQqnumijqUT7/FYU0Clhze6Y6QInWWasRNu6+cx7YqBlgrVUAWtQULELQpQFI9sgnJu1hqXZRM0fyWZpiNslHg0DGHQIl2cQpQYI97Dvg9U6AcHKF6uNs7JqrcZDImFsfdexFaATBDYjCULnPmQA/fTE= From: Luca Fancellu To: Jan Beulich CC: Stefano Stabellini , Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Thread-Topic: [PATCH 2/2] xen/misra: add entries to exclude-list.json Thread-Index: AQHZQFJXk2XcVjdJnEaLn2MagKXua67OM+KAgADR84CAALBGAIAA+Y0AgACOdYCAABDwAA== Date: Thu, 16 Feb 2023 09:20:13 +0000 Message-ID: <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> In-Reply-To: <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV1PR08MB7875:EE_|AM7EUR03FT045:EE_|DU0PR08MB7908:EE_ X-MS-Office365-Filtering-Correlation-Id: 9dc9c407-681c-4755-5d85-08db0fff0aab x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aAmGlPtOV0uZRltIDKVuY+mLY83eFCtuKSypL5gTiVJrvwCCElzsgFYdy+J/N8rEfQcB9EnSyftNNNLluA4Lo1G0hZ435ktyfDsqRRW7Yy+qm4ywn3M61veuGhMSBac0acwJbLZYw8T2rK8e5LhXPGJMWERK+w58SunMB6/N9RkeXUSAfwAYkT8VWDwcA+XRUCdRgYjZ002BvQaLmJqCXx3b/VJiyjmAzpxJpfP5xDvM0hAHDo9kvzTTkerQvCEE4Cl/31l1F2bOUkTW9Z2jNrMY+O3WNONeGNqU6v+Msp2RVa/7u5m0ezIAtYABWiTQf6KmlECqH2myscAhOk+nAkMZ5wmkhL2hbZyjxfQeyXPKxOVSDQ2Br56evTQSJErulngOX//WnO+DxQ1gVxfWb71hj0rmLR9n9A5csEYV13ZPlHMZ534EhYSK//KIQsMFD5BT1p3Hqqs/v1MJ8IOSBmO9BkrY37vivZ2+g+GWkKZrXgE7TEj4WJr+WZu7Z3wJhxE+3moJs9IPsvZsPSRI7KQ6q/2rdIyHbb/6lcrFA35FMaT/zSAGRJ3d8w0kcvK+Rllci4QhBFitsvXnO2BjQB0BIDStEnJd/fZ1SQoNU0u9SVUNtH3E0atdf1jxC7ppazAZIsNG5uASdo79cyIL0sWB7OXaLkrRHH7gy0DY5gxvSQQnlIGeqO41YlKLz3SlCGBTi/rd1ZRFnfyYs5L8FsJImjrDYRP/r2pAklFy9Is= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(136003)(376002)(366004)(451199018)(86362001)(38070700005)(122000001)(38100700002)(33656002)(36756003)(5660300002)(4326008)(8936002)(8676002)(66446008)(64756008)(66556008)(2906002)(91956017)(6916009)(76116006)(66476007)(66946007)(2616005)(26005)(186003)(53546011)(6512007)(83380400001)(71200400001)(54906003)(316002)(41300700001)(478600001)(6486002)(6506007)(66899018)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <60018143620AA34AA7A5B65F9A6FF732@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7875 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 466a5930-24e3-41ba-6554-08db0fff0243 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qSPQugFU6J5LAPttizN+YTeZI+uZQPZo165H12SM/DxvtOCwPRblcIlfvA1P4T7Qj5QtdoLQUHQsKHzCkk3Jt5JGwoEi3irqzjsu1LUcRR39q4SVqf+qhHSEFL300lJXymvXY1WItH15QuKY+K2bqY0vvdBI6tS3869jek4Tdg/3vXLhXdR91zeaeKqqyFJ0A0mD4oyqtZx9QJtl9yMM5DVd259crwSIrUHrZeOYCnfTQCJVNtGsGfIyVvrO47f4zSqPNiX4kw3uuwissY77MzLsOvXFj/VaBCvN015mrIEDas0ph4Vs28nbFr98lvHG5Qd2ZOPBbqL+2+oGnA25Zs1TwlR7FSJWZJiqVtA9T4K43dEz67vJCBQreGZDqJ4zcZ08+MdbUd1AIt7mmatnPsoCxa8bGdbKHVmBPLgSq83koUEgN9L7lsbS9hZ9oj+7vjBsp3gUmobng0TXYusx7hzjiTfjlZMlH+VP4Ri0AqvQCeOx5tokyaSQWV7YAjNmEY57qOPETuIg869UmFv3t1bXdSyE8xPuh2SBSKQz2LVnRgf9BPagHYeczW/rFioR+UB7aPKqx7rgTHIZIkRQlCephMUkVmpqDgSy3ssQPaMCQVhRgIs1yZvv9OsK/Ls+10r+FdM49heaSQOsFtrpRf4qs9gAmg3Zy8AJmLJoZi7dVn2gMnvW88V/JFEam4Tv+Iykz4xkpxx3RHs86m+FLQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199018)(40470700004)(36840700001)(46966006)(66899018)(40460700003)(81166007)(4326008)(316002)(6862004)(8676002)(70586007)(70206006)(5660300002)(8936002)(41300700001)(33656002)(86362001)(356005)(36756003)(36860700001)(82740400003)(26005)(6506007)(53546011)(54906003)(186003)(47076005)(2906002)(40480700001)(82310400005)(6512007)(478600001)(6486002)(83380400001)(2616005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 09:20:27.2355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc9c407-681c-4755-5d85-08db0fff0aab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7908 DQoNCj4gT24gMTYgRmViIDIwMjMsIGF0IDA4OjE5LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTYuMDIuMjAyMyAwMDo0OSwgU3RlZmFubyBTdGFiZWxs aW5pIHdyb3RlOg0KPj4gT24gV2VkLCAxNSBGZWIgMjAyMywgSnVsaWVuIEdyYWxsIHdyb3RlOg0K Pj4+IE9uIDE0LzAyLzIwMjMgMjI6MjUsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4+Pj4+ IFBhdGNoIDEncyBleGFtcGxlIGhhcyBhICJjb21tZW50IiBmaWVsZCwgd2hpY2ggbm8gZW50cnkg bWFrZXMgdXNlIG9mLg0KPj4+Pj4gV2l0aG91dCB0aGF0LCBob3cgZG9lcyBpdCBiZWNvbWUgY2xl YXIgX3doeV8gYSBwYXJ0aWN1bGFyIGZpbGUgaXMgdG8NCj4+Pj4+IGJlIGV4Y2x1ZGVkPyBUaGUg cGF0Y2ggZGVzY3JpcHRpb24gaGVyZSBhbHNvIGRvZXNuJ3QgcHJvdmlkZSBhbnkNCj4+Pj4+IGp1 c3RpZmljYXRpb24gLi4uDQo+Pj4+IA0KPj4+PiBJdCB3b3VsZCBiZSBnb29kIHRvIGhhdmUgYSBj b3VwbGUgb2YgcHJlLWNhbm5lZCBqdXN0aWZpY2F0aW9ucyBhcyB0aGUNCj4+Pj4gcmVhc29uIGZv ciBleGNsdWRpbmcgb25lIGZpbGUgY291bGQgYmUgZGlmZmVyZW50IGZyb20gdGhlIHJlYXNvbiBm b3INCj4+Pj4gZXhjbHVkaW5nIGFub3RoZXIgZmlsZS4gU29tZSBvZiB0aGUgcmVhc29uczoNCj4+ PiANCj4+PiBJIHRoaW5rIHRoZSByZWFzb25zIHNob3VsZCBiZSBhbWJpZ3VvdXMuIFRoaXMgaXMg Li4uDQo+Pj4gDQo+Pj4+IC0gaW1wb3J0ZWQgZnJvbSBMaW51eA0KPj4+IA0KPj4+IC4uLiB0aGUg Y2FzZSBoZXJlIGJ1dC4uLg0KPj4+IA0KPj4+IFRoaXMgcmVhc29uIGlzIHByZXR0eSBjbGVhciB0 byBtZSBidXQuLi4NCj4+PiANCj4+Pj4gLSB0b28gbWFueSBmYWxzZSBwb3NpdGl2ZXMNCj4+PiAN Cj4+PiAuLi4gbm90IGhlcmUuIFdoYXQgaXMgdG9vIG1hbnk/DQo+Pj4gDQo+Pj4+IFRoYXQgc2Fp ZCwgd2UgZG9uJ3QgbmVjZXNzYXJpbHkgbmVlZCB0byBrbm93IHRoZSBleGFjdCByZWFzb24gZm9y DQo+Pj4+IGV4Y2x1ZGluZyBvbmUgZmlsZSB0byBiZSBhYmxlIHRvIHN0YXJ0IHNjYW5uaW5nIHhl biB3aXRoIGNwcGNoZWNrDQo+Pj4+IGF1dG9tYXRpY2FsbHkuIElmIHNvbWVvbmUgd2FudHMgdG8g cmVtb3ZlIGEgZmlsZSBmcm9tIHRoZSBleGNsdWRlIGxpc3QNCj4+Pj4gaW4gdGhlIGZ1dHVyZSB0 aGV5IGp1c3QgbmVlZCB0byBzaG93IHRoYXQgY3BwY2hlY2sgZG9lcyBhIGdvb2Qgam9iIGF0DQo+ Pj4+IHNjYW5uaW5nIHRoZSBmaWxlIGFuZCB3ZSBjYW4gaGFuZGxlIHRoZSBudW1iZXIgb2Ygdmlv bGF0aW9ucy4NCj4+PiANCj4+PiBJIGRpc2FncmVlLiBBIGdvb2QgcmVhc29uaW5nIGZyb20gdGhl IHN0YXJ0IHdpbGwgYmUgaGVscGZ1bCB0byBkZWNpZGUgd2hlbiB3ZQ0KPj4+IGNhbiByZW1vdmUg YSBmaWxlIGZyb20gdGhlIGxpc3QuIEZ1cnRoZXJtb3JlLCB3ZSBuZWVkIHRvIHNldCBnb29kIGV4 YW1wbGUgZm9yDQo+Pj4gYW55IG5ldyBmaWxlIHdlIHdhbnQgdG8gZXhjbHVkZS4NCj4+PiANCj4+ PiBGdXJ0aGVybW9yZSwgaWYgd2UgZXhjbHVkZSBzb21lIGZpbGVzLCB0aGVuIGl0IHdpbGwgYmUg ZGlmZmljdWx0IGZvciB0aGUNCj4+PiByZXZpZXdlcnMgdG8ga25vdyB3aGVuIHRoZXkgY2FuIGJl IHJlbW92ZWQgZnJvbSB0aGUgbGlzdC4gV2hhdCBpZiB0aGlzIGlzIGZpbmUNCj4+PiB3aXRoIENQ UENoZWNrIGJ1dCBub3QgRUNsYWlyIChvciBhbnkgb3RoZXIpPw0KPj4gDQo+PiBZZXMsIHRoZSBy ZWFzb24gd291bGQgaGVscC4gSW4gcHJldmlvdXMgaW5jYXJuYXRpb25zIG9mIHRoaXMgd29yaywg dGhlcmUNCj4+IHdhcyBhIHJlcXVlc3QgZm9yIGRldGFpbGVkIGluZm9ybWF0aW9uIG9uIGV4dGVy bmFsIGZpbGVzLCBzdWNoIGFzOg0KPj4gLSB3aGVyZSB0aGlzIGZpbGUgaXMgY29taW5nIGZyb20N Cj4+IC0gaWYgY29taW5nIGZyb20gTGludXgsIHdoaWNoIHZlcnNpb24gb2YgTGludXgNCj4+IC0g bWFpbnRlbmFuY2Ugc3RhdHVzDQo+PiAtIGNvZGluZyBzdHlsZQ0KPj4gDQo+PiBCdXQgdGhpcyBp cyBub3Qgd2hhdCB5b3UgYXJlIGFza2luZy4gWW91IGFyZSBvbmx5IGFza2luZyBmb3IgYSByZWFz b24NCj4+IGFuZCAiaW1wb3J0ZWQgZnJvbSBMaW51eCIgd291bGQgYmUgZ29vZCBlbm91Z2guIFBs ZWFzZSBjb3JyZWN0IG1lIGlmIEkNCj4+IGFtIHdyb25nLg0KPiANCj4gSSBndWVzcyB5b3UgbWVh biBzL3dvdWxkL2NvdWxkLy4gUGVyc29uYWxseSBJIGZpbmQgImltcG9ydGVkIGZyb20gTGludXgi DQo+IGFzIGFuIGVudGlyZWx5IHVuYWNjZXB0YWJsZSBqdXN0aWZpY2F0aW9uOiBXaHkgd291bGQg dGhlIG9yaWdpbiBvZiBhIGZpbGUNCj4gbWF0dGVyIG9uIHdoZXRoZXIgaXQgaGFzIHZpb2xhdGlv bnM/IERlYWxpbmcgd2l0aCB0aGUgdmlvbGF0aW9ucyBtYXkgYmUNCj4gbW9yZSBjdW1iZXJzb21l IChiZWNhdXNlIHByZWZlcmFibHkgdGhlIGFkanVzdG1lbnRzIHdvdWxkIGdvIHRvIHRoZQ0KPiBv cmlnaW5hbCBmaWxlcyBmaXJzdCkuIFlldCBub3QgZGVhbGluZyB3aXRoIHRoZW0gLSBlc3BlY2lh bGx5IGlmIHRoZXJlDQo+IGFyZSBtYW55IC0gcmVkdWNlcyB0aGUgYmVuZWZpdCBvZiB0aGUgd29y ayB3ZSBkbyBxdWl0ZSBhIGJpdCwgYmVjYXVzZSBpdA0KPiBtYXkgbGVhdmUgbXVjaCBtb3JlIHdv cmsgZm9yIGRvd25zdHJlYW1zIHRvIGRvIHRvIGFjdHVhbGx5IGJlIGFibGUgdG8gZG8NCj4gYW55 IGNlcnRpZmljYXRpb24uIFRoYXQgbWF5IGdvIHRvIHRoZSBleHRlbnQgb2YgcXVlc3Rpb25pbmcg d2h5IHdlIHdvdWxkDQo+IGJvdGhlciBkZWFsaW5nIHdpdGggYSBmZXcgZG96ZW4gdmlvbGF0aW9u cyBpZiBodW5kcmVkcyByZW1haW4gYnV0IGFyZQ0KPiBoaWRkZW4uDQoNCkhpIEphbiwNCg0KbXkg cGVyc29uYWwgb3BpbmlvbiBpcyB0aGF0IHdlIGNhbuKAmXQgaGFuZGxlIHRoZW0gZm9yIGZpbGVz IHRoYXQgbmVlZHMgdG8gYmUga2VwdA0KaW4gc3luYyBmcm9tIGFuIGV4dGVybmFsIHNvdXJjZSwg YmVjYXVzZSB3ZSBjYW7igJl0IGp1c3RpZnkgZmluZGluZ3Mgb3IgdGFnIGZhbHNlDQpwb3NpdGl2 ZXMsIGlmIHdlIGFyZSBsdWNreSB3ZSBtaWdodCBmaXggdGhlIG5vbiBjb21wbGlhbmNlcyBidXQg ZXZlbiBpbiB0aGF0IGNhc2UNCnRoZXJlIG1pZ2h0IGJlIHRpbWVzIHdoZW4gdGhlIGZpeCBnb2Vz IHRocm91Z2ggYW5kIGNhc2VzIHdoZXJlIHRoZSBmaXggaXMgb2JqZWN0ZWQNCmJ5IHRoZSBtYWlu dGFpbmVycyBqdXN0IGJlY2F1c2UgdGhlaXIgcHJvamVjdCBpcyBub3QgZm9sbG93aW5nIHRoZSBN SVNSQSBzdGFuZGFyZC4NCg0KT24gb3VyIHNpZGUsIHdoYXQgd2UgY2FuIGRvIGlzIHRyYWNrIHRo ZXNlIGZpbGVzIGFuZCBmcm9tIHRpbWUgdG8gdGltZSBjaGVjayB0aGF0DQp0aGV5IGFyZSBzdGls bCBlbGlnaWJsZSB0byBiYWNrcG9ydCwgYmVjYXVzZSB3aGVuIHRoZXkgYXJlIG5vdCBhbnltb3Jl IHdlIGNvdWxkDQpqdXN0IHBvcnQgdGhlbSB0byBYZW4gY29kaW5nIHN0eWxlIGFuZCBzdGFydCBk b2luZyBkaXJlY3QgY2hhbmdlcy4NCg0KDQpAU3RlZmFuby9AQmVydHJhbmQvQEp1bGllbiB0aGFu a3MgZm9yIHlvdXIgZWZmb3J0IG9uIHRoZSBsaXN0LCB5ZXN0ZXJkYXkgbW9ybmluZw0KSeKAmXZl IGFsc28gaGFkIGEgbG9vayBvbiB0aGUgTWljaGFs4oCZcyBmaWxlIGxpc3QgYW5kIEnigJl2ZSB0 cmFja2VkIGRvd24gdGhlIG9yaWdpbiwgaGVyZQ0KbXkgZmluZGluZ3MsIG1heWJlIHdlIGNvdWxk IG1lcmdlIHlvdXIgbGlzdCB3aXRoIG1pbmU/DQoNCg0Kew0KICAgICJ2ZXJzaW9uIjogIjEuMCIs DQogICAgImNvbnRlbnQiOiBbDQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJh cmNoL2FybS9hcm02NC9jcHVmZWF0dXJlLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1w b3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJl bF9wYXRoIjogImFyY2gvYXJtL2FybTY0L2luc24uYyIsDQogICAgICAgICAgICAiY29tbWVudCI6 ICJJbXBvcnRlZCBvbiBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAg InJlbF9wYXRoIjogImFyY2gvYXJtL2FybTY0L2xpYi9maW5kX25leHRfYml0LmMiLA0KICAgICAg ICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAg ICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gveDg2L2FjcGkvYm9vdC5jIiwNCiAg ICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQog ICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9hY3BpL2NwdV9pZGxl LmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAg ICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gveDg2L2FjcGkv Y3B1ZnJlcS9jcHVmcmVxLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJv bSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjog ImFyY2gveDg2L2FjcGkvY3B1aWRsZV9tZW51LmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAi SW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAg InJlbF9wYXRoIjogImFyY2gveDg2L2FjcGkvbGliLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQi OiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAg ICAgInJlbF9wYXRoIjogImFyY2gveDg2L2NwdS9hbWQuYyIsDQogICAgICAgICAgICAiY29tbWVu dCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAg ICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L2NlbnRhdXIuYyIsDQogICAgICAgICAgICAi Y29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQog ICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L2NvbW1vbi5jIiwNCiAgICAgICAg ICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQogICAgICAg IHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9jcHUvaHlnb24uYyIsDQogICAg ICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAg ICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L2ludGVsLmMiLA0K ICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwN CiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gveDg2L2NwdS9pbnRlbF9j YWNoZWluZm8uYyIsDQogICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4 Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94 ODYvY3B1L21jaGVjay9ub24tZmF0YWwuYyIsDQogICAgICAgICAgICAiY29tbWVudCI6ICJJbXBv cnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAgICAgICAicmVs X3BhdGgiOiAiYXJjaC94ODYvY3B1L210cnIvKiIsDQogICAgICAgICAgICAiY29tbWVudCI6ICJJ bXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAgICAgICAi cmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L213YWl0LWlkbGUuYyIsDQogICAgICAgICAgICAiY29t bWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAg ICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvZGVsYXkuYyIsDQogICAgICAgICAgICAiY29t bWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAg ICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvZG1pX3NjYW4uYyIsDQogICAgICAgICAgICAi Y29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQog ICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvbXBwYXJzZS5jIiwNCiAgICAgICAgICAg ICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQogICAgICAgIHsN CiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9zcmF0LmMiLA0KICAgICAgICAgICAg ImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0K ICAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gveDg2L3RpbWUuYyIsDQogICAgICAgICAgICAi Y29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQog ICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYveDg2XzY0L21tY29uZi1mYW0xMGguYyIs DQogICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9 LA0KICAgICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL2JpdG1hcC5jIiwN CiAgICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0s DQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJjb21tb24vYnVuemlwMi5jIiwN CiAgICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0s DQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJjb21tb24vZWFybHljcGlvLmMi LA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAg fSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImNvbW1vbi9pbmZsYXRlLmMi LA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAg fSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImNvbW1vbi9saWJmZHQvKiIs DQogICAgICAgICAgICAiY29tbWVudCI6ICJFeHRlcm5hbCBsaWJyYXJ5Ig0KICAgICAgICB9LA0K ICAgICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL2x6NC9kZWNvbXByZXNz LmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAg ICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImNvbW1vbi9yYWRpeC10 cmVlLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAg ICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImNvbW1vbi91YnNh bi91YnNhbi5jIiwNCiAgICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgi DQogICAgICAgIH0sDQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJjb21tb24v dW4qLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQiOiAidW5sejQuYyBpbXBsZW1lbnRhdGlvbiBi eSBZYW5uIENvbGxldCwgdGhlIG90aGVycyB1biogYXJlIGZyb20gTGludXgiDQogICAgICAgIH0s DQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJjb21tb24veHovKiIsDQogICAg ICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAg ICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL3pzdGQvKiIsDQogICAgICAg ICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAg ICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAiY3J5cHRvLyoiLA0KICAgICAgICAgICAgImNv bW1lbnQiOiAiT3JpZ2luIGlzIGV4dGVybmFsIGFuZCBkb2N1bWVudGVkIGluIGNyeXB0by9SRUFE TUUuc291cmNlIg0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgi OiAiZHJpdmVycy9hY3BpL2FwZWkvKiIsDQogICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRl ZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAgICAgICAgICAicmVsX3Bh dGgiOiAiZHJpdmVycy9hY3BpL2h3cmVncy5jIiwNCiAgICAgICAgICAgICJjb21tZW50IjogIklt cG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQogICAgICAgIHsNCiAgICAgICAgICAgICJy ZWxfcGF0aCI6ICJkcml2ZXJzL2FjcGkvbnVtYS5jIiwNCiAgICAgICAgICAgICJjb21tZW50Ijog IkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQogICAgICAgIHsNCiAgICAgICAgICAg ICJyZWxfcGF0aCI6ICJkcml2ZXJzL2FjcGkvb3NsLmMiLA0KICAgICAgICAgICAgImNvbW1lbnQi OiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAgICAgICAgew0KICAgICAgICAg ICAgInJlbF9wYXRoIjogImRyaXZlcnMvYWNwaS90YWJsZXMuYyIsDQogICAgICAgICAgICAiY29t bWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAgICAgICB7DQogICAg ICAgICAgICAicmVsX3BhdGgiOiAiZHJpdmVycy9hY3BpL3RhYmxlcy8qIiwNCiAgICAgICAgICAg ICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0sDQogICAgICAgIHsN CiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJkcml2ZXJzL2FjcGkvdXRpbGl0aWVzLyoiLA0KICAg ICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwNCiAg ICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImRyaXZlcnMvdmlkZW8vZm9udF8qIiwN CiAgICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgiDQogICAgICAgIH0s DQogICAgICAgIHsNCiAgICAgICAgICAgICJyZWxfcGF0aCI6ICJsaWIvbGlzdC1zb3J0LmMiLA0K ICAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCINCiAgICAgICAgfSwN CiAgICAgICAgew0KICAgICAgICAgICAgInJlbF9wYXRoIjogImxpYi9yYnRyZWUuYyIsDQogICAg ICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9LA0KICAg ICAgICB7DQogICAgICAgICAgICAicmVsX3BhdGgiOiAibGliL3h4aGFzaCouYyIsDQogICAgICAg ICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4Ig0KICAgICAgICB9DQogICAgXQ0K fQ0KDQoNCkNoZWVycywNCkx1Y2ENCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Feb 16 10:23:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 10:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496431.767173 (Exim 4.92) (envelope-from ) id 1pSbPZ-0003pW-C8; Thu, 16 Feb 2023 10:22:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496431.767173; Thu, 16 Feb 2023 10:22:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbPZ-0003pP-7X; Thu, 16 Feb 2023 10:22:45 +0000 Received: by outflank-mailman (input) for mailman id 496431; Thu, 16 Feb 2023 10:22:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbPY-0003pF-HA; Thu, 16 Feb 2023 10:22:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbPY-000859-FW; Thu, 16 Feb 2023 10:22:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbPX-0007pS-S0; Thu, 16 Feb 2023 10:22:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSbPX-0005fK-RW; Thu, 16 Feb 2023 10:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7pl0F5ahGR6GKGQLkORnIQxi5y92L0sJ7Iq4djqbmZE=; b=e7BQKup93RhLiMI/4G0gFM4RA+ MBLc6bwLeCEVn/RgEoIWsEpip82Y9m3m7ffFAyhbmNPlPIpeI6m14u/bp5dNYPlw/7iJbB8fP1Op6 SSnHMQQv3AM83kUrw2auubTJa9E620oTtGJeVPSHIQaJ3aYkToeDHC6spIuUQ8372cEE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177428: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 X-Osstest-Versions-That: xen=63305e5392ec2d17b85e7996a97462744425db80 From: osstest service owner Date: Thu, 16 Feb 2023 10:22:43 +0000 flight 177428 xen-unstable real [real] flight 177479 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177428/ http://logs.test-lab.xenproject.org/osstest/logs/177479/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-examine 6 xen-install fail pass in 177479-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 177479-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177376 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177376 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177376 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177376 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177376 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177376 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177376 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177376 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177376 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 baseline version: xen 63305e5392ec2d17b85e7996a97462744425db80 Last test of basis 177376 2023-02-15 10:37:05 Z 0 days Testing same since 177428 2023-02-15 22:10:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Marek Marczykowski-Górecki Ross Lagerwall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 63305e5392..5b9bb91abb 5b9bb91abba7c983def3b4bef71ab08ad360a242 -> master From xen-devel-bounces@lists.xenproject.org Thu Feb 16 10:28:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 10:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496442.767184 (Exim 4.92) (envelope-from ) id 1pSbVI-0004XW-4f; Thu, 16 Feb 2023 10:28:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496442.767184; Thu, 16 Feb 2023 10:28:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbVI-0004XP-1M; Thu, 16 Feb 2023 10:28:40 +0000 Received: by outflank-mailman (input) for mailman id 496442; Thu, 16 Feb 2023 10:28:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbVH-0004XJ-8i for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 10:28:39 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a8fc8585-ade4-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 11:28:33 +0100 (CET) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 05:28:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5324.namprd03.prod.outlook.com (2603:10b6:5:24c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 10:28:19 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 10:28:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8fc8585-ade4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676543316; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=yiI2Kucsks847goh5T5akqX2bULqCPtorSMgdvmdX8A=; b=hWdqYMoh5CGFp2lesI1qAh9bjLC1PWARtgBMfMJbqlAEhErV6jGoIxSF WfOiIS34tNd9AtMsJmmlfQ8jWMK9T+8Bpr9Wj5dS9Wk9DbO43IPkim/O+ 7P4r+WGEahTOskWVmh7ycvHxmDhFhIUWukwRE4G56CncgBxX2kANAefAM I=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 97199844 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:x7zsU6DFBrnbRhVW/8Hiw5YqxClBgxIJ4kV8jS/XYbTApDtwhTUHm zBLD23QbK7eZ2TwLtojat/i9EgPvMDXmNBrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw28lFAn8V9 NUkNnMxNjaDm+Dm76zhc7w57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDe7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QxHKqCN5OfFG+3s5Usgyu+U8vMUMPflu0ocO5l0ygYd0Kf iT4/QJr98De7neDRMTnTRS8p3KDoRc0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJv5hDajziNT2EDPxx jmirS4iirFVhskOv4248E7GhXSwp5HPZg8z+gjTGGmi62tEiJWNYoWp7R3Q6q9GJYPAF12Z5 iFbxI6Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBP RW7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:Or4UYa5OfNgrlqM2vQPXwMzXdLJyesId70hD6qkXc20zTiX4rb HLoB1/73TJYVkqNE3I9eruBEDjex3hHO9OgbX5VI3KNGOKhILCFuBfBOXZsl/dMhy72ulB1b pxN4hSYeeAaGSSVPyKgzWFLw== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97199844" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KvUp4B39VChGe5voUsUIcASDxZIewLFHm9s99rz2bhl0XgqFta42D6D42lMAw1TQGOuilvVWTGWNWnnB5fQ3ofl+RgLPieanYkE5Ncm0KP31iaVVcVR4fywaN1Bg89xa8A3ytLkpcrhUuipjwCge49DIn/HSSOT2AlFn4FdoaCWkL/vHRo5hdSxd86ThvmnqmoDLemeKq6yF/apEGnzQrwJUiUZxqpUKRD437Q9S+9expffJQyQDHQT4J4ac8mVBdzP5qfgjTlAItt+O4i6hJbms4kuoYh++XjHl5gzFpxR4bfpfVrqSUN6y5X/QRaxavtw0FEpog+/RDkjOrAW9cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fv4TB/grq4QMcivVPhYF6xvG2OLyJXSh7ZjYzZ4hUho=; b=MuPtFTKzlfzkgyjZEgjMCquKE771l8jaz+R3yOUbRnkoWfyj/R8KXuTnoms5EOLI0KXzsagJ7uOvg+cWH+KgBAIqQmfoScnlfGK7TQ6gyfURSSU5/e8U+5EqfbY9BXgzi2OwaflAgIRXcWnRGm97F53uAimcVxKzBVkOFW7vAE5PRl7rIZ5EIwZn+iOZwFEleL2Z9EOmO16m0771ZIQDtjlMYema6Lqk0oxFbqYf5Cdu8+qezFf88n8b1GAWX/5W03Gf+jQjH1QP8pI/gIlrtLCPv93eSPLCxBVxtJ0pu9XCmr5eVMBequ8V00JaVUJiq9DNwokePE8AbFCx0e8fzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fv4TB/grq4QMcivVPhYF6xvG2OLyJXSh7ZjYzZ4hUho=; b=s3LwilLyJYmeMUVcTy220UHAy5UYf4WzaUpuLtWqzXD+c+Hstzw3HR6NxFmejNw+cqHDX3rjCQ0mLlFoZOxOyIPFtDboFtcGMQrRcv6/ZVsOOWh6wc6ftsF2Xq+S45O/6cmYVW6Sl2pLdN2HNaPIZ3V9IQ9mJSJb1IClpAEdv+o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 16 Feb 2023 10:28:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230213115017.902037-1-burzalodowa@gmail.com> In-Reply-To: <20230213115017.902037-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0125.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5324:EE_ X-MS-Office365-Filtering-Correlation-Id: 4022cf82-2dba-4d23-2e1a-08db1008859a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JsVKuBSgKy93ij5/pBhEVzj+pdoaVux0W3UHAXgbUmHxUsPyxE+6JT3bqaYqxpB0pvQamrWoQguvhPq5kHSCdxuBfpsmPCCaIvJWa1umk785iwBMLvpbc9NceifP+s40yi50mrvzPgoYJTwVWg2/ypGCmBQ9FMu3DhmGyUJxXOB73/XkfzEgV+vwx9fXC6d7NV9UjQFQRyE6JQWk/+vGqh4XZurNLWK9qXVx+R2CgQqX65fZ3ImCdVHwNvSc5vS/QGQaKlHh1BPSMtRdnAeM0p2o/MObVAl0erUJSUNJtn4GRzyenT6dloX6L6zzUnUsXqlH/34Ce8P4gM6gcnvj4W8fw1pMG6lZ0vJ2U0qXgI00nYMsAdkpz+31lybLageCiHsqJL8/mMHwkbMOfPRUDd0PKgW5lvRgxDcjRf9JF8c++CgDTvXn3Hn0o4KR52lVVzxumLyvdA/NYhkoCCAPyIMSuJv7nSHnVokwIQlLAqVYywLaQh59+I9aXEzXO97E5A9cegroGAQbdu8wMaJlV1q/Rb2t8dPCXHxYyrGjUJSNHpDk6IvWYgNT/oN3OwP0Arqgt7ZR5ObptcJNFcf0t8t19RRvFakZih+P7f7BHyde6clKr2evpQDik2ROrQiBIVHopH78dO28fpoRn9paCLbPfiLQt7yTNb6QO+202y0I8+gST63QESabgwAGmQaj25aGZJMDnkG8pQ01MTTFSTDF3dW3wQxvXJC2GKGg/iw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(366004)(346002)(451199018)(8936002)(41300700001)(5660300002)(6486002)(478600001)(4326008)(66946007)(66476007)(8676002)(66556008)(54906003)(316002)(2906002)(36756003)(83380400001)(2616005)(82960400001)(38100700002)(31696002)(6512007)(6506007)(186003)(26005)(6666004)(53546011)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXpoYlZYcThPWnA3N2s0TS9Ta3J3S2xGQ0xqazZwdDJDbXNGdld3MHBCQk41?= =?utf-8?B?a2Vnd3hkSUNQUjdacGdvdE1YU2JscVFZVUoyK1V0WENGYUdzbEk0a3c0OVp5?= =?utf-8?B?SDI4RHVxNVYxcHZUZ2d0NFVGb3h6anN1bGZNRXdGWUZid2pIRlZUMzJXVlZX?= =?utf-8?B?ZDVIL1dmak9yTXpmTXIzajF2U3AvcEpCVWtEY0N1N2MyR0x3VU14RW1RWDB6?= =?utf-8?B?TUFxbHEvM3RNNytNOFNRazBNYUNJN3VlWklGc2FWOFFGY1lUamZ3L0dyOGdE?= =?utf-8?B?RldMcVJYdXQ1SGFzMjdSYWRWYXdYU0xoUmlYS0g2Z0x5Mnhma2tOR05TNzVy?= =?utf-8?B?OGdUQittb0FrU3Q5bXFnYXhCL3hzUi9zNnZSSVYzUUxVQ0xGQlNnZzhQWlFy?= =?utf-8?B?QlNXd3UwZFJKdzErTG5pa2pVTVIvay91K3BEMHpNV0VlYjNZSUtCWkE0WGFR?= =?utf-8?B?VWI3ejVjcWlXTnZ0c2dCSkZYVW1HcVM3cDRVUmZQMEFjL0RCem9kbjYrMG9m?= =?utf-8?B?ckpGZ0lQQi9yeVZOOFo2SzNYQi9Ock1YazVDcjNUc0x0ZWczUFBTeStSL2hT?= =?utf-8?B?TVhlSHRBcy93RjJsWll3SDBJK1JMYTh3bGlZWmN2YU10c3dLejI3R3FaU095?= =?utf-8?B?Uk5CTkx3WlA3QUpmcnNRMDRrVzNZUHRlQks0bktGVjBBQkpmaGlSakMxQWY1?= =?utf-8?B?ZVlMQnNSQkwzMlQyaVhUVG16OGVLL3d2ZVl2TUFhdGhEWk56RFNuaFozVlhv?= =?utf-8?B?ZFpHYmsrUjNTTVp3WWh4aE5VTHFlYkhTZ1JTSm1QQVhPZm9lb29kNHVDcktE?= =?utf-8?B?VHZFV2E0QUtncXh2WllZKzJtelhRRm1nQ3ZkRkFlbG9jWWowcmpPcklHak11?= =?utf-8?B?R3BjWVp1a2R6MDBrSTRaeXd5b3N0QmQzWXRwYittanRnWmZzWEtWNjBiY2hS?= =?utf-8?B?SW1ZQkxpZ1J3S3pTZUx5M1Z4MnUyMXdoZGpvUFdBcStOZjRFTDN2eHErZ1h0?= =?utf-8?B?SU9aRi9xck5mN1dTRGRCcFNYSmxrVGVHL2ZZOTJVdXRHNEt4bDRQZ0xLM0d3?= =?utf-8?B?UFlLKzY4OFpLVTcrSitWNHlWTWt0UHFXbWxDamY3dGdXemwxREpzZGtQdEUr?= =?utf-8?B?RG9rTU1ZbzIwM09pL0ZCVFRDaUJnZjJCSEN4T2Izd2pDZm95NUVaZXg1bDJC?= =?utf-8?B?ck9IWEQvTStHSUhlZ3VZUVNTMFB6Q3NsTnJhMDhrbGd5OU9pVCtRZ1hLUFVT?= =?utf-8?B?Z0gwRGVSOUVnZDlyN2swYWJYckZ1TXorOElHUUtPT2JodmVyNUk5KzdqSFFv?= =?utf-8?B?bkpDaE9QdldEZTRNWEpISTBESmpMYzVQNW5uT1FhQmhlWDVzRHpjcWpPYVdB?= =?utf-8?B?Rm4xcVZZSW5kSURMU1UzeXBwTUZGR0NKbkJuUUdGM3JFZm40L3BuY1JML2V5?= =?utf-8?B?V1luMmk0d3lqd2R1SWx0RXN6dnVjMmhaT09hcUFVd1BURHBXNW1pU3hwc01T?= =?utf-8?B?em5wc3pkdnVRMDVSeUJ5aktHTldBTW4wK1NmSFBwb2twVS8wTUdUYmR2NEhm?= =?utf-8?B?UEZUV3V4RmtFYlZ5YytFRCtoaDB1eGswWnY5QTM3aHU2L3JwN0xVOGdNQzRN?= =?utf-8?B?N2x0WEc0U0lwNnRxUHZicVQwbWxsZThLamxlVGs1YkY2SjRqamhlK2czbmRj?= =?utf-8?B?ZDdwYUd5SWZ1RHl0NkpMcS8vN2NnVUNVaGg5dklWdjZyNHhzN1NRWEtQb1hn?= =?utf-8?B?VEUwY3M1OFRQTXJtTmtBUXpvK1AxQUxYVlhaZEs0QmJWai9FQ1VRaUZkcU5a?= =?utf-8?B?Mmx0VjJtODFpTmcxLzZMR2owQllCdURzdmhxbkxOblRXOWVad0J3SlBpalZL?= =?utf-8?B?bFROZ3BLZDViVnRwdWRKM0FIS1N1bm1Bc0xRRVN3eDY1L0lMek1lZFpSSWs3?= =?utf-8?B?eUVBaDJaa2hsY2J0M2hsN010eFZIdW1UdjhJWGVDT1FEeW12VjhMdmo2bFFq?= =?utf-8?B?cUx2aUp4VzNXSGJOVEtTVENyQkpnd0ZYVnY3UEZMYVQ2Q2gyRUJLWTh6S2hH?= =?utf-8?B?bVo0VlFEV25ZZXo1TVBsWVZHQTkzUE1rb25XVjlDZGh0SzczYzBhSXc2MEJ2?= =?utf-8?B?QXJMVS9tYjJrbU9id0VISVk3WkxnZEZ0RHdLQ0JvYWQ5Vkx4N3UwT1dhUDhi?= =?utf-8?B?Rmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3bUNhN5lIAa0qQwe+1DUHXI1GdzbmaajwTuQRoE6QA2Fw5j7+MM/69On++1jE2nrAb9Hs+94y6L8BPkVdCVZBCeKWRLDiftj72R5YNU7AgNHPn/QwlcDRYNkX0Zpa7k7V9xCKZaGT3Df7ZzqeCGlo0Vw8JabYfayNACgelqe4vf3PfBJT2lMvhXBNiPE/fZpMbSJ8KM/u1i4zHueVIGM/FLMhNMzmvVVYeEzfnxg4jltOoPvALQYNTzuxdWU8dMFXABtwiZXmqW5rRXO5B70QJGb5ejce6FrW9IO2dTC4RGWOA42RaIlzRa0TJv+vy20iivKPzWMGogByBn1aHgkz+dZ0D/z0qWn2DlOuZBBu4dgPPZVqxBXiCbUizOzlF/W8VlRqiWRSCAWgBDMce5dQMVU7yXavK/EwlftjeEa6gbYl8IqM5Dt8SDlJvXq2KmhDe6nIozVj2yYbDZhYn0ZIDuIkrw5/bkSA2gmOz1UiFPRuxv3Y5rhTh9nlL5bdPAiAfZy805DZSgiT5Em6bm+lFua4lgpQHLU/p75YosM4ial+38/KpylET9W9Mg2Gbua9zrM9BMB3cIWwc2M7vQ3GzRg13K6TYfcYfvX5o+aoBNEOoabyNIAYsPi0UfkQfwL+cxUKP3Nx1S+eLmTi08OsfjdQhx+jXMyKc5O9qd6vfB5LJaTSbTEK1IIwLHDpNr4ZRvoJFoPbPmYSwDsSj3d4b/DjMTByBZKI8zLMyJdoCMPquYHvgEiG5RaI4vDfcsctrEy9ttqmAZc9D4UCjiaX63lSdfd/GkH9UstJSSyT67WfEU9QmzMc06NK2Ft01qvf9HUWAqAdQ56p2Ij3ZA/NU2q0ShX8LtRxqYoch43WIi9/HW8uJI7+u4h4EbppsfC X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4022cf82-2dba-4d23-2e1a-08db1008859a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:28:19.3907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GxwUnhTyctDzwDLv24lfqL4Ag64aUl44WdtAZz6dIwdKHHc/2nE1RbqKm59vtSbY1CI0eEgfR0VmRXbssXLi237NOOOiUXQtK1FE0M5lp48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5324 On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: > diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > index 234da4a7f4..97d6b810ec 100644 > --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h > @@ -85,7 +85,7 @@ typedef enum { > void vmx_asm_vmexit_handler(struct cpu_user_regs); > void vmx_intr_assist(void); > void noreturn cf_check vmx_do_resume(void); > -void vmx_vlapic_msr_changed(struct vcpu *v); > +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); Hi, I see this patch has been committed, but this public declaration should deleted, and vmx_vlapic_msr_changed() made static now that it's only referenced in vmx.c. It needs a forward declaration in vmx.c because of its position relative to the vmx_function_table, but that's fine - we've got plenty of other examples like this. Could I talk you into doing an incremental fix? Alternatively, we could get better cleanup by forward declaring just {vmx,svm}_function_table, then moving the tables to the very bottom of {vmx,svm}.c at which point we can drop all the forward declarations. Oh top of that, I suspect we have other public function definitions which can turn static, if you happen to spot any while doing this. Thanks, ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 10:44:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 10:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496447.767194 (Exim 4.92) (envelope-from ) id 1pSbkU-0007YB-GA; Thu, 16 Feb 2023 10:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496447.767194; Thu, 16 Feb 2023 10:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbkU-0007Y4-DS; Thu, 16 Feb 2023 10:44:22 +0000 Received: by outflank-mailman (input) for mailman id 496447; Thu, 16 Feb 2023 10:44:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbkT-0007Xy-LR for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 10:44:21 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de91dda0-ade6-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 11:44:20 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id a3so4144634ejb.3 for ; Thu, 16 Feb 2023 02:44:20 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id p18-20020a17090635d200b0087fa83790d8sm662395ejb.13.2023.02.16.02.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 02:44:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de91dda0-ade6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=wtLbpAkl0FZNX7sDs9cC+7OG5ZtljGI1XymIM3vizGk=; b=BQ152kqBUZq/BOQR66E6r9rNMMtGsM9DKGCUDzsdr/ukOKyhDIIgyN/2zKb/AbfUM2 18vjmJ1I14s/79k88f+chAq5HmyyUPvs0vU/NJGACxwl17N7a9pYqIel7exABucpfJmv OHYoqVCQi6d7KvsGJg47oY4+CFwkXlJ4lAL7jHQKO3uvAmM+A8XPWPxVlSxn91kk58h/ HJwiK7Ju3VF+w3x0M+9mlchzxa6GRbUlKT+NxeDAmkZBtb5U9Ja91FtXVE7cgUJFrBeS aPs258Ut5v1eteXNpNi2zoU0tNhYtv0GuqPtXvnYoLV4Vxbn51NMB4MZaHXx1SHguAuq MFnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wtLbpAkl0FZNX7sDs9cC+7OG5ZtljGI1XymIM3vizGk=; b=xkmgQzGprR2dy6oB39AhtVpxNRPUbcVMg+zZfHnl5W+73wO1OXvw7+tliSzLQ4PLo8 aGe0BKSQ2/BUE3e54JReiim7xuvkJWy6njtcOQzfCAbU+vbytcFJvXOL2sgNC7ltzqeu NLCJA4XHTfKhZMUBq16YFXnNXfX65IihTUxwPNCvGn7oWq7t569UHbjcP2UHwsWa6FgG xi1qlch02eFQwe9fIkm3LwAOJFBUi1VHkVhmq7Ond09fdHlQAt+PaR0c4UB5zNm5tu3v U7AAlWlIolxoNUfMMhYnZDnvHgP77fxobz40wm4h4IFXRP8zRhRELXivppOBto47pSUJ eV2g== X-Gm-Message-State: AO0yUKWpK7EYxgMxcUuPB1ZFf/vb8HMAT/FPN3+oHfGjZF2e8toxbV1O vnXZE9es5Hwj5OgaYzZWq0E= X-Google-Smtp-Source: AK7set8mJdlQZVkG741pLh6R6beqXt+NLTrKOTHbT0CwH2ABef0cQ3n3Wwjq24EI3Y1NgCEbuaodpQ== X-Received: by 2002:a17:907:584:b0:8b1:304e:589e with SMTP id vw4-20020a170907058400b008b1304e589emr4231420ejb.53.1676544260285; Thu, 16 Feb 2023 02:44:20 -0800 (PST) Message-ID: <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Thu, 16 Feb 2023 12:44:18 +0200 In-Reply-To: <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > On 15.02.2023 18:59, Oleksii wrote: > > Hello Jan and community, > >=20 > > I experimented and switched RISC-V to x86 implementation. All that > > I > > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. > > Other > > things are the same as for x86. > >=20 > > For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT > > will > > look like: > >=20 > > #define _ASM_BUGFRAME_TEXT(second_frame) \ > > =C2=A0=C2=A0=C2=A0 ".Lbug%=3D: ebreak\n"=C2=A0=C2=A0=20 > > =C2=A0=C2=A0=C2=A0 ".pushsection .bug_frames.%[bf_type], \"a\", @progbi= ts\n" > > =C2=A0=C2=A0=C2=A0 ".p2align 2\n" > > =C2=A0=C2=A0=C2=A0 ".Lfrm%=3D:\n" > > =C2=A0=C2=A0=C2=A0 ".long (.Lbug%=3D - .Lfrm%=3D) + %[bf_line_hi]\n" > > =C2=A0=C2=A0=C2=A0 ".long (%[bf_ptr] - .Lfrm%=3D) + %[bf_line_lo]\n" > > =C2=A0=C2=A0=C2=A0 ".if " #second_frame "\n" > > =C2=A0=C2=A0=C2=A0 ".long 0, %[bf_msg] - .Lfrm%=3D\n" > > =C2=A0=C2=A0=C2=A0 ".endif\n" > > =C2=A0=C2=A0=C2=A0 ".popsection\n" >=20 > I expect this could be further abstracted such that only the actual > instruction is arch-specific. Generally, the only thing that can't be abstracted ( as you mentioned is an instruction ). So we can make additional defines: =C2=A0 1. #define MODIFIER "" or "c" (depends on architecture) and use it = =C2=A0 the following way: =C2=A0 =C2=A0".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", @progbi= ts\n" =C2=A0 =C2=A0... =C2=A0 2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in the following way: =C2=A0 =C2=A0".Lbug%=3D: "BUG_ISNTR"\n" =C2=A0 =C2=A0... Except for these defines which should be specified for each architecture all other code will be the same for all architectures. But as I understand with modifier 'c' can be issues that not all compilers support but for ARM and =C2=A0x86 before immediate is present punctuation # or $ which are removed by modifier 'c'. And I am wondering what other ways to remove punctuation before immediate exist. Do you think we should consider that as an issue? >=20 > > The only thing I am worried about is: > >=20 > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > > =C2=A0 [bf_type] "i" (type), ... > > because as I understand it can be an issue with 'i' modifier in > > case of > > PIE. I am not sure that Xen enables PIE somewhere but still... > > If it is not an issue then we can use x86 implementation as a > > generic > > one. >=20 > "i" is not generally an issue with PIE, it only is when the value is > the > address of a symbol. Here "type" is a constant in all cases. (Or else > how would you express an immediate operand of an instruction in an > asm()?) Hmm. I don't know other ways to express an immediate operand except 'i'. It looks like type, line, msg are always 'constants'=C2=A0 ( they possibly can be passed without 'i' and used directly inside asm(): ... ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ ... ) but the issue will be with 'ptr' for which we have to use 'i'. And I am not sure about all 'constants'. For example, I think that it can be an issue with 'line' =3D '((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). >=20 > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Feb 16 10:49:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 10:49:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496453.767206 (Exim 4.92) (envelope-from ) id 1pSbp6-0008NH-24; Thu, 16 Feb 2023 10:49:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496453.767206; Thu, 16 Feb 2023 10:49:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbp5-0008NA-VN; Thu, 16 Feb 2023 10:49:07 +0000 Received: by outflank-mailman (input) for mailman id 496453; Thu, 16 Feb 2023 10:49:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbp5-0008M6-0H for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 10:49:07 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86f83e5d-ade7-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 11:49:04 +0100 (CET) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 05:49:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5743.namprd03.prod.outlook.com (2603:10b6:a03:2d1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 10:48:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 10:48:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86f83e5d-ade7-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676544544; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=WXk6Uur3p3AJ4j14EfUFnYdVKCbXYla0NYaz1xwPtFQ=; b=cItaGQVUw4gLSlZEcEfE/hgJI6JbVtqOB5Uxpy84ow4w4lnwiuFnClbl ocUF+rXOKmIVvVz4Mj4jH/wcZsV78a0cs9c45xOuM/4tnvfuxT76PqSLP fXW4xu4KzT07xC+Zdl2Kj00tiTP1aIxknVpxosTx7xyDjsbfS/qUJ6dzN s=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 97289149 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:pKaLKKgbVdVHP4Fll3ULIFlMX161jhEKZh0ujC45NGQN5FlHY01je htvCDuEPavfZ2D8KY8kaY6z8U0B6pOEmIAwSwRvrys2EiIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaAzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQbGBpTUzGbt9ukxfXqVtBM3Z8ELOTSadZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGyaLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReLipq8z3Az7Kmo7LE1PRWCakNCClRS+ecJRB BA69hZ2sv1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xAWwJTSVAaZolqdUxTjwp0 XeGmtroAXpkt7j9YXCA8raZqxuiNC5TKnUNDQcfVhcM6dTnpIA1jzrMQ8xlHarzicf6cRnvx xiaoS54gK8c5eYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPA1LTAxfNJLYLcQlzfu nEBwpGa9LpXUsnLkzGRSuIQGr3v/+yCLDDXnV9oGd8m6iip/HmgO4tX5VmSOXtUDyrNQhexC Ge7hO+bzMQ70KeCBUOvX7+MNg== IronPort-HdrOrdr: A9a23:r2VtRaiOK+esZ0OfEa7EiLVCvHBQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU= X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97289149" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fgMsw6pv6ggkG5VZAUnHRc7JjkB45gN8gtuBL7gHqTG9ko5Ciqs3vAlu2OEVWyk1xVauTym4gvG/RhtOSobltZrm0wX34VL0QSa53xqFzekjcpKtA7CMkAeC7J7iK8ZEF7aAZWy2xvwbqWafF3UK03toiidmlu9fxIL4Lvutk+bsMxhAZc5GJM0STJ7fsBbLo2e8t9pROnJlc+ROCh4yN6vQjJUzO/NUGkTluIk+XA8g+bHYMQ0ARNsBMovqMOYJLkzLvYulWqIFhp2RyuuePRN25NSCveEIOcSiZp1KPjEAWNnMgSHvRtPwmf6tTo6GCGBfACT31mlfKwzjXdL4wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qACx1sSZULQN2eFk3PB9pvE75HPEj9a8g9ahs0ba3sE=; b=bT1T5FvvUmuzSCKm/Vh4ysmlSSOqqtvnyENx81M4cPu6tFRA3y54L5t7ISBRrgzgbgiyt2vRYDNPNTMRbCRz9h3lA7YggTFnSYDDrCu5X8dXY4IwZ+ZFOfs8LHUQ7hcnR+Lq9yTPkoHYVuFfbUIZnVCsO6qaghPLltNVXADULW5tvjyg/WUaIGTl9sp13Gi6rRbwzL/fOUmI84wE3nO+aJSwaCs0iuBN/ZVfkzP/mOK17oQlOeeU8XA738hLZX/eCDS22TUxcYKUT0kzvO9RNZxaMsA3z2kOs21DENQI7Zd59aQQts0uJqSiTCKhXGL2xI04H0d5CYMnp+44IQdIVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qACx1sSZULQN2eFk3PB9pvE75HPEj9a8g9ahs0ba3sE=; b=P2CenKQLk+96462o89uaZLTfco581aMS8eicluYaUxXqyvPEeHmlNXbVrCLR8cuKvD8kz22/xzmc28M/HiYjmNxYX8R2CMreDGjIOxCZwB8Rf2bwCOfEZapR7vAZH3PazOkK9BmXQ08yoRfIztfEAvVeTlWKWfvF+JPx/QWqFYw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <068340c3-2a2f-4bd0-20e9-f1dd6fe4bc2b@citrix.com> Date: Thu, 16 Feb 2023 10:48:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-GB To: Jan Beulich , Oleksii Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> In-Reply-To: <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0626.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5743:EE_ X-MS-Office365-Filtering-Correlation-Id: bdf8ebe2-3aeb-4673-6932-08db100b68a5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BmNYVA5Frr6l7z57KjHS/5XyolL/39p90V7ddIBOWOKqIFa6xkPg/QC3A8HRjx7PSaV55319EfBdNmTtBT9G6GtXJtlISfoViyTz+LHD3x5VFYfhO5KXoy2FRZVlGETy//xUz+cSueclkCzbZsfoCeMrOzRk9/ushAmGzy2OD2K6yxPYx4CaVVcmsX1DI3ZArSY8SY6fVMRoOkjWEidWKUdYUaygMbn9hZ05k4FMEY4seLpS+zYnoCmPdaOmGjpMTDI6W5MbqXuAf482QwkRDHumQrePxWRYQhInl+OFuZ2VXuYUgW6Uyepw3slnQ/br7i7nRxu7jQbvyXvU7oiynu0rPzNRaC/ECLVRTGaVHGSjzp7Oc0ipMNizDkxUxhaUuCaX4ONc3r5ubuIkMOYpwWobg7H8UEMRiTexD65M0++DlchdNIvG84x6IZmctW3jFmZu6DE0oUiP7PA9SwTxC+Ucl/KuuaWGAyJbPlaK0ilNWd7lrkzpoE2mhEjuLst3x4BWO+smuVMRp/ysCfstYGn/DERDf7zpgnK85K4O33dS5O1F7OsEcJVgoUZ/TEXGiuRhrHd6zlcKCxiJIIFtRBiUIkEGQcNSHG6nY3lXqXmpF+pnHEE5d4+ZxwbTXF3nr1AWumvUEp3XSlgEMCpB6ERF2yQtKApmE1hI8Lc/2/ADWe/jWdkBq1AVzuOeRaaD9sKn46JcfpPVVNn3UszvYDB90biCJMoQDCfUU4WZgaudhtRD4QkdNK8avemOn6eZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199018)(31686004)(31696002)(36756003)(86362001)(2906002)(5660300002)(8936002)(82960400001)(38100700002)(4326008)(8676002)(66946007)(66556008)(66476007)(110136005)(54906003)(6486002)(6512007)(186003)(26005)(41300700001)(53546011)(6506007)(478600001)(2616005)(316002)(6666004)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWE5dzdEbEhEMVFmWjNjdUlCZGFqZkVlR0ZEQTV2UEcrY053QTVwTkRPbGNj?= =?utf-8?B?Mkg5S1I3NkdzRitSTlFpcnZxWTFIVENPdGVWazBISGs5ZEpkZXE5YWdySzRT?= =?utf-8?B?bXhaQWRsRjdCSzUxZlJmeHFkTUhuMkJOKzFUM0MzYWxCOG83MzZzeDZiU3Fo?= =?utf-8?B?N3J5anRySHVnMFJtS0diZ3k2cXV2OCtsSlIxemlFR3RtVERJVys4R1FQOVEy?= =?utf-8?B?UkdjcFMwenllMExOU1ZCSGZlSUM5TTVOME5ZcE95RUFQK20xUDZBdjZpRzFV?= =?utf-8?B?ZXFobzRxRVBKRlFEV1g5UFh5YVVVZmVRZENuMUhzbFk5aElvVG9BOU1GS2pB?= =?utf-8?B?aHVkRFVwVFJwaEZUZVV1SkU5d2xINExvaHhveXpNVzdDSEVIUEpxQnN2ckhn?= =?utf-8?B?WU9nR295M0VDSmtsaHVQcnoxVkl0NmhqNDNuVEw4VWhzVnQ5NXF1OGFOMndJ?= =?utf-8?B?dmZGbTdGMUJ0bnB0Zng5S1NDNkc0aUNlRFdqWkhldEFpcGhjNENHcWZReU9n?= =?utf-8?B?d1licGlrMS9iQ3F5RDhvUUdEcHdSRzhXak9KeTNGMlZNYitNNklpYTV6STZP?= =?utf-8?B?UGU2elVYOVZnWmFWL3Nvb1RCZC9sK0VOV0hlOHROb25ia1g5RjhyakdRZkw5?= =?utf-8?B?MmttQ2JCMFVuUkkxTGIzTlF2ckwxYXZTZE90Q09maDdHdU1lUkx3VFo3Tkxa?= =?utf-8?B?aWZITmJDTmhTVjA4cENrenAzaDQ5TmR2cjdOdTRsVno1RTJZS3VHbnkvZ2NH?= =?utf-8?B?NVlvckFSOHlOQTV4Y2xPckF2by9odjk3aGg3c3ZwMHA3TXlJSjR1R1RJaWlU?= =?utf-8?B?Zmljdjc0UG53blhSa3ZCaFRxN05GWHZoNnVXNmRjb2tsWHNhK2YyMjJMQWhn?= =?utf-8?B?REYraHN5TTNuZ1JWdEpnbWkzMUZiNmlYaGtSbGVXV1A3VGxpSVNpMkE3QlVo?= =?utf-8?B?V2hqeFJDTVVDbGlzYWh5WEt5RzlyTWl6MWM1Vm9CN1NOOGI2VkFlUjJtYzNE?= =?utf-8?B?RzBudktkOUJ5bEZlOU0wUFFBVGxOWGkxWTJEQWYwODNyUFVTVnpvUERCd084?= =?utf-8?B?UEFyMm5yWGF3OEJVc0dOTUhzaDRBWG5UMmRZYmRQTXBFMEZ4VyttYU1TbTJn?= =?utf-8?B?dnUxOHFvYWdtVll2MUJjNVBhQ3ROcXpRcGt3L3RHL3dxRjBEKy9oVG5xMmlH?= =?utf-8?B?Rjd5c2g2Zys1eXMySFdpZDVVamhvRmtHdGV4TWVaZFNVY0toMzIvR2E1SDEr?= =?utf-8?B?UTVPU3JVc1pJOUpOT0JaaU5xRVR3c2pFZGNra1ZQYjMyYlEyYTJONXgrclN0?= =?utf-8?B?bDRobCtsajB6elJ0Z0dOS2lqZjhGamxOdjVQWUx3U28vOEFDalF0Y0NGZ1FX?= =?utf-8?B?OXlWV3d1RG8yeTc4cE5JWStOV3krYXVqTzFkemFNT3VlendyQWduZlAvK09O?= =?utf-8?B?ZmVreVgvSHdldnFGOVJoNTBCUkJBcWphTmVHRVR3MHZLZ0lSNEJPdzlhYVZa?= =?utf-8?B?VHFRMDF4a0xYSnZ6a2I0MjU0VVg4SE1vTmRZcFdVWWJFanVSWWpBQnBRQWtE?= =?utf-8?B?bk1IWFNheFZZQW0yQ01Wb050eERUYmxweHlPKzJHcGFSbmJCMGVXZ0lNMURR?= =?utf-8?B?T2tLZFN4Z2p2cDFSc016TG1EbDFqM3BkT1VxZnFjWDE4RzNSc09aRjBDcW9N?= =?utf-8?B?c2hHL1hGWGNHY1RhUGtreUdScVY5SDNHU2VCTm44VlkxSzRXVStCUzJKM3Zs?= =?utf-8?B?YU9BR2VJblJkUC8wR3plWWptVHQxQkY1WHpSUndkUzlwQ1NudmRGOElsSWV1?= =?utf-8?B?K2Q4OW1LcnBhY2xFVHd1T3FJcktINWtFeWRqNjEzaW00S3psMjFlaEZkblVw?= =?utf-8?B?NUpaL3AwK0wwaW9UVXY5UmRLalBTQVpMRGluemplYnRSazZ0SU0wUEtQWGJa?= =?utf-8?B?aXQvOTBaVlRNL1hTeUhlcFJDY0ZUUFNHeUdWWWR5QmNLci9hWmM1SWZzZEpy?= =?utf-8?B?N0U4OFdvUUV5bENIZVpUSitvOG9qU2lnUHI1c01WcW9pYS9TaFh0YnRMQ3oy?= =?utf-8?B?U0xtc1FVTE96Ny9LN2xLZU5IOXp5QnhXYXQ0VkQ1amJsa3ZPQkFJYlFacWlZ?= =?utf-8?B?Q0NvcVk4STdsQjJXUjVWSWtrMmF2ZmIxdGVGMnBxMFh6TTViODZaVFNLUWJU?= =?utf-8?B?cmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: lTYIfUjohZG8TOG8xOXAPDxvFIyGKDjPiCWnFPtc3X8QEMyRVW6wsdsaE04QcoWtNOSoQsKdcEq8zxtk5kmFUlYKnKBzeDR2yhsJq7uBh0lNrz0OgWvbliEWRyynKqDtUSW2pXCgzR2TaJ4WhaX4/l3xfNd/KMhrCNHfd6vIC3nKgewcohILfYubrgFSqY5fEHMYtYCS9n952vI1wApyc81RDfrwBEKSlKY/bEIpsI1+RVg/RtwVFyvKPO8mlYGcPozKCVJ7YDq/clpR+d9am6LIm0lGZRP9s75UdgG2+IEH0VjmD3qSqzg7Vm6GbKOEobc3LcelBFg1Ekv2ZCqkS5qMXl1U2qwZy5pmb6qoji/yjiWTKil80INcAbDyRo+kjA3vpFxJLYoS/YLxN4ZRB63TG4OE4MMtQwlQdY6YEhi2bNORb0HlmezKyhNkEbn3bG+6aNvqyKuVCEu6yPR6uhlOBSdZjHcIFNFTwREy5B+y7enZIrzpitA7x1kDk6yill8lsSryDaGuwMoVXdtJKSxhExBzFEyfTzDdrRFci6domSe0l74HuCGvLe38zIN4LwhAN99nP7aEvPLC5BTt3DSEuQL9nfPBdHlpZDmZvEHXfPTYWCdT9tOrkudmvt5L13InkchRUDRtVyZqbe6B3w41auMX9Q/oanq7feYxvlstyMa+18TZZCIaMcytSI8/ZdnrHOG8ohRbJOe0QXe16lUmK9nXAao8hff83Qo4hWnwwC6iEf6AnMEklmDd3JgmC7Hl15RTILOzW+2RqUE09+7NDAlQ22FjmpS3C8ftiIrGyMsZ2IzNCzVAVdFiQ5MZF7Mat3WzcGW0cgWO+DcHUGKHfhoNg2dsxe00BApbwp059bHKnBzWLfLzdMguNMxw X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdf8ebe2-3aeb-4673-6932-08db100b68a5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:48:59.2224 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7v6dm0WTkT1OQ3XwP57SpTaPg7bal+wSMgn7RkojAw+dHntVudW63DxjnZjXNB4DbhDRwNFTP1jIbFih8tWpIwF4Q4M53FTv6plYeGMVbuo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5743 On 16/02/2023 7:31 am, Jan Beulich wrote: > On 15.02.2023 18:59, Oleksii wrote: >> Hello Jan and community, >> >> I experimented and switched RISC-V to x86 implementation. All that I >> changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. Other >> things are the same as for x86. >> >> For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT will >> look like: >> >> #define _ASM_BUGFRAME_TEXT(second_frame) \ >> ".Lbug%=: ebreak\n" >> ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" >> ".p2align 2\n" >> ".Lfrm%=:\n" >> ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n" >> ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n" >> ".if " #second_frame "\n" >> ".long 0, %[bf_msg] - .Lfrm%=\n" >> ".endif\n" >> ".popsection\n" > I expect this could be further abstracted such that only the actual > instruction is arch-specific. > >> The only thing I am worried about is: >> >> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >> [bf_type] "i" (type), ... >> because as I understand it can be an issue with 'i' modifier in case of >> PIE. I am not sure that Xen enables PIE somewhere but still... >> If it is not an issue then we can use x86 implementation as a generic >> one. > "i" is not generally an issue with PIE, it only is when the value is the > address of a symbol. Here "type" is a constant in all cases. (Or else > how would you express an immediate operand of an instruction in an > asm()?) At a guess, the problem isn't type.  It's the line number, which ends up in a relocation. That said, I'm not sure an architecture could reasonably function without a generic 4-byte PC-relative relocation... ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 10:55:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 10:55:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496461.767216 (Exim 4.92) (envelope-from ) id 1pSbvG-0001bz-Rm; Thu, 16 Feb 2023 10:55:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496461.767216; Thu, 16 Feb 2023 10:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbvG-0001bs-Ox; Thu, 16 Feb 2023 10:55:30 +0000 Received: by outflank-mailman (input) for mailman id 496461; Thu, 16 Feb 2023 10:55:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSbvF-0001bh-65 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 10:55:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a6748ad-ade8-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 11:55:26 +0100 (CET) Received: from mail-bn1nam02lp2046.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 05:55:20 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6597.namprd03.prod.outlook.com (2603:10b6:a03:393::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 16 Feb 2023 10:55:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 10:55:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a6748ad-ade8-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676544926; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=N+iHjd6KFr7RqVN+nCMWPs244jBPxgcJ9fO+4MoGuZ4=; b=QHpOQo5Gn6yL9+/vyRSwtcTdWh9Q3eU+6KwvVDRNJr5mut0V2UEZYBpW Hmos6+K/2sDozfL3W/JQNRn8levRCCagtJYv4AqPT7BBvqo1jNXtrzenr jMWpUHfH+JlC0szoDhFuMNC/CiU0Ts8kr13OkYm5m6oiuQf0onGjevmGl g=; X-IronPort-RemoteIP: 104.47.51.46 X-IronPort-MID: 96127770 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UFdd4KnCE1Z7VQshbxWgo7no5gyiJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZDGHUM6uCN2r0e9t0O4S/9kwC78CAx9BrGgY4+Cg3HiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QGGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fUgERASdSDYvumRh4mSTeVNjNY+Msa+aevzulk4pd3YJdAPZMiZBo/svJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVU3jOaF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMTefnqaEy6LGV7nACDzhJRWC2ndSksleFdfMEN FA0+TV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zpptg1hxeXFNJ7Svbp0JvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzt56s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:v3Us+a3cvDFzfutnJK0JIQqjBLwkLtp133Aq2lEZdPU1SKClfq WV98jzuiWatN98Yh8dcLK7WJVoMEm8yXcd2+B4V9qftWLdyQiVxe9ZnO7f6gylNyri9vNMkY dMGpIObOEY1GIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="96127770" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kmdvx09Z+EJ1w9Nhgm4t5/cLAJk4dhugBCYzzF+UnvxsTn50rEkdnGb3QfANpnRlHCZhdlhoXs55Rf3TLDNMKtjE76QEdtbE4xerYVuRJsWe6SBNEuA9bTpFm3cT5dAsRdoADawLm+pUj1M8E0YuPuFxt9YtC4MWHpDRovitOIt8LUw1qlMfalga1v9RjLvbjuQfxc4beoDNlpJJ0c8aQQRGSB9TJFIyPB45t1aqNw89v0eajvDKFEDAX7lJjnVuHvDcUisiGlLdwdPBln1bKo/6gj4pzzMfTMHJiKvu2jKE7zi7HUI+zfZIeHBfqYqWH8/t21DtImCDqViDGaPsyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s4nfn4Vekhn3GCdG0vdvtts/f3miz2wH6PD7FEmBKK8=; b=B2FT5RETGbwXGfnA1V3oVN+Pv28uWnfHPUyAeHwy8t9R5xE0lXBAINjyPESNKTiwccT2wXUC2poqKWJ7OZYjbVsFzR6OHJJmxM/cQzXWSvyt7CiBuIf3xvf6ProeBWaSOp+adZLMcH1o1C5q/KltfJgTzbueMZkwiuiBPk3ahIK8nSFUJGYrQwhosqbP17/Hf295RCMl7dBO+7+ttIfbMLQ4Z7Hgl/l/D2YzJf/cgDKmN/p9ubyX4qSQOdXz0VyBpE4a/wSwr62z3FSoitmK28G7ngpTfLUas1nascsLDvPQx5meUVCGNfDiMnjOOcDw53OUxqv0BqxyYR6wHZqpLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4nfn4Vekhn3GCdG0vdvtts/f3miz2wH6PD7FEmBKK8=; b=QEaRGKWTlgt66cnWFTXc+wclkiytGYRlyNUoBJQmJXMOFeB4W5ooOAfXHWtb+xMgWOQ6FwhDFaI1sfp0SOG1sOF6l1JEaDfS9P2l+/pLbtvNvk8oOLwq8JclfnX2yXz8S0VeizL5bWw5qCZnifYRG+GCHciy/x8c2PuBih8pxl8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 16 Feb 2023 10:55:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <9f375055-eff2-010b-c904-e4122b834777@suse.com> Content-Language: en-GB In-Reply-To: <9f375055-eff2-010b-c904-e4122b834777@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6597:EE_ X-MS-Office365-Filtering-Correlation-Id: baa239b3-945a-4ad2-c112-08db100c49fd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eAc4hHu+25cUITjZBb41gAczXjKSoAuC6C7cYoOczdyLkDXeI6BAGvYdDZtZjsqV4Q080aGK76ZKUCG/0n+K2jSg4LeDCp9OeF7q3GKKWSCxnYdH2wCgxrBchKD/2Qu/fdbl0nwOQi0bbzxlBc8ATZfJ7oWgr5+zzMtZb5SnaKntafFtjZYptBUdLWA38IImxlXxHm3oqiufwxsLO9r8EjpodpDvi3J4cyiUk5dg2rGFbQ3Ein6cAsrNPHifUK/o6BuGf9mzElIEYcbDkX4rQZK1vfaP8acElS3KaTLpjZCkudoH89ia1LWhzQ2bs6ygtTTX5ljWuwAU61uM+YSxoPYjFgWtPi3R9Pq+AtWSCH4Tm2W0fhfRDnegxcBja4JD+OErZZQdeefcqIiBXM7yiFKfIIIOpTBsi1i0KJpFt5naklW2fnb2VyP5I0KyQsAPQ6EUmxG++amjFcMcODu+RL8Clxw09KY2k0l+wRt6djz+s3Q7tZDOiAb2OyQxQJBtnhuZKNeijrNWmK81AVlnXlfNcfjS0+JU+OB7pv82iV0E4LpcOgcKozuIMZacuIGRbRdey/NKGQ3+W0JzySA/SIWxA2iQl4H4XSe2qcUi+aReZ6xV4Tqf1DYjK71e8Q0hofX1uHG3Icx/lupAyYLZgVUauBQghCpG7BwlzRJcwKgLMKomvVWdmHN4pH2+JZi9x0u3oQ8/CF61GZ7xkD95mPluJ1xqmZJJkfBbvjx99OM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(376002)(346002)(136003)(366004)(451199018)(36756003)(66556008)(186003)(6506007)(86362001)(6512007)(6666004)(107886003)(2616005)(478600001)(8676002)(41300700001)(2906002)(8936002)(5660300002)(83380400001)(53546011)(54906003)(4326008)(110136005)(82960400001)(66946007)(316002)(38100700002)(6486002)(26005)(66476007)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VQUHNzUnYxZ3AraVMwKytJWUc5ZEpGMnM4SFltWWFPMXVta0hxUW1sN0t2?= =?utf-8?B?MmE2alpWMUtSTkxZbW9keVd4dHpUMWlLYktvQW5oTk1EUHFxQmt3SGFVRitR?= =?utf-8?B?RVEzOVM3M2UrZk5yanRPNUFJVXBUV0lMaDB5NC90b1ZwckltMjErMkwrYUQ0?= =?utf-8?B?TjRQVnJ2Rm8wamd6TnhQQW5XWG1ZMjBrYldna3JmRlZmUXFuMk9DdVhjZVZm?= =?utf-8?B?SmVFcmJQTGtlQ25OOVJ4UFBrSHVJQUlvQW5Qd0VTU1BoNGZCdkc5dW84aStU?= =?utf-8?B?aEQ2K3MxQjFNSkI3VUJPaXRVd0NqYWJkbDhqWXdqTklMYUJncFllQjlNWkZp?= =?utf-8?B?NXE1Zy8yb3hqVjlKTTVic0p4OFRMV2Q0amFaS2dxcVYyc0JYbjFqUUVET0NS?= =?utf-8?B?K1pyV3l6SWFhaDBBM2VBSklPTkJ4NmpYVGZ0SzRGaldXM29SM1YxdXQ5RkZ1?= =?utf-8?B?NjBGVHZ3QlJ0U2p2bVVrMiszMUUzNjc0MDU4aGplUmkyRUJWM3BMRm95RU85?= =?utf-8?B?TnV2K2s2VC8rZ0NUeTJBbHh2YTRYellCY1pQZDBKbHV6UkVmQnRCSlIrWFh1?= =?utf-8?B?UVpUTVRTRnJTUUFLWjVhT1R2Ry9FbStYRlp1cWg0bVhDNTMvcTV4YVFOaWsr?= =?utf-8?B?cy9qclVpaXE1UEVVSkpRYS90ZUtGQmQzNzRZOGE2N0JKS29LV0Y3UTFXSDIv?= =?utf-8?B?eXJqVDh5MHRLSUJQeDZrRG44UWZZVXZpN1d5OXRHSW94SGlTMEhTNHhrQzlN?= =?utf-8?B?bG92R29PWlliR0grNyt5KzdxK1RGK2xwQTlJU0RRZTFYR0pKenU2U2Z4SXY2?= =?utf-8?B?alkwTmRFcmpzdWE0NlRNZ1R3cjBnMWo3a2tmTWZaUmFNd0pYOUlaVldlSVNR?= =?utf-8?B?MmlCbFpKSmZ4QzFEbThKQS91cGJzSmhCY0p5VkY2dkUxMWNGY0xOWWdQeGNv?= =?utf-8?B?QXZZNlBnVU5xT2hMWHI2RnR0eFhaOG4vdnZBOCtBT25QYWRhMFlNUmdwNDE5?= =?utf-8?B?OUNCNU1DYmswUmJRTk12UkR5ZnRYbWlJU0dScjFZSCtHbjVidzF3RzdiS2x2?= =?utf-8?B?WXNrU0x5N2dQcDNFTzhxUFQyRnpiRmFCTEdnS3dQeFd4S0ZqQWwzT2lLWmly?= =?utf-8?B?aWV6TlI3cGFMSm14NGJxM2JRM2VyemlyMEZCOXorZ0FZSXlIZUFBNGFPaWVw?= =?utf-8?B?MFYxRllVNlRuWmdTb0lQcVhsUGlEUXEybElXZ3FtMTlHN0UwTFBHMjJzbEsx?= =?utf-8?B?WWxPUXNiVnM3SUZRSi9SWFd6dlZpYzNUQ0pNNzNQRjh1SjR5VlRsZElGbGo2?= =?utf-8?B?cUlzbmhleHcwd0ZvVzRMZytVUm1xY3ZPSHVsdGdhRGc1NXdTZVJNSklHQXNm?= =?utf-8?B?N1ZFMERyYW94bzc1MWhTUldGMGV3c0tmSkFwZ0pySnVpdjY5OXFPQVhNa0NM?= =?utf-8?B?TlMzc2hHM1UyK3dKb3YxQ0RiTWRtcTFqYTZ6RzJ3LzZtUThGbEJGMFRwL09Y?= =?utf-8?B?WW95Q0t2TXVHTXpNRVRDRjM3VjEwb0UrYk9JRnVGRUxpY0U5a1JzTUFKaEYy?= =?utf-8?B?QklIdmtseXlyMkhwb25pd0VsOFhPVHhZU2doT2xWQ2VDY28xYkdKUG5HeWZ6?= =?utf-8?B?UWN2UHo1WDVOZUNmZEgzOWVZUVZhb0Y0V25mak9UVG0rZ1FhVmpyVlNrN09C?= =?utf-8?B?cUR3Q0JZSjNUc2JpQUR2bUJMUlUzTGE4bHA4SUFhbkR0K2ZIcTdqY0hyNWsr?= =?utf-8?B?Wmd0UitkMzlrNzVQbW1RY0xteGRXdzZyOUJCaG1aajRQcjk5MGxQUzNUa1Nw?= =?utf-8?B?TnRlaEZxRmZJWm1DaGs4ckVjTzZ3QlZNUEhxbEh0N1lBNlY0OUlSQlQwb2sw?= =?utf-8?B?b05tRlF1RWtuNUYrL29iclZJK0svOWs2dEtCc2x2TnZ4dXpGQnkzSkg0UWRk?= =?utf-8?B?L1VXalRjQUFmWHFDZ2Y1NGVpRzJqOHRoVEpKWFo4TUxUakVNa1JWV2NnZUUy?= =?utf-8?B?M2ZrdVRZUHB2VmVHL1hQTjRZYW1XcDBqYzZDSHhvbEszeFJRaks0Ykp1aHkr?= =?utf-8?B?WUxDMDdtNlhBME1MakU2emhuSFJYOWMrT0N2K1NLYjF0VjUyL2hHV25rdUky?= =?utf-8?B?a3NBb2Vxbmp4N2pFam40YjdLRWJkSStEb0tpUjBTKzJMWW55WEdDTElvSzQx?= =?utf-8?B?V0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pOgsiZJs+uUPbuimjsy6gRA+bVWJWniUSs/mQXydMU19n/D34QP/NFix8xQyKbvx79eaYLJbl4dafQJKAIoutRrMaO2f5SqysdJwkVFzveRcSJR4eL7YvetAwHVHiDDJIHjhg1t5mZfH8B3XVt1IKks2jNCY4fjyLKXMy29MU6hmOIEY2dnZnFWQFNVTf3ZU/dmMfq7h3I5fx/cBF8Ij1JXOwCzB6hxPTkUK9KSBQ6iv2l+QJbDSRHzpktG9YlvEQvq1uDDBOGRHAindVhNoQ9HhrlT201HxXvn+RveeJ9pTKjVtEWPL6U2fNOJYP9X2AAyIbBW9Btgjml5JirsEMS1NdrajE+7RjA+CY+Z/UBg7ZMNSW893B25g85wWmkDZWZOuWrt6lzKNBfDPp4bZnFc/uzq71E79cXNbEYLoQkKOm3PxuULpJr/uTExuzupwHcFQw+BDXO1y6fjHdrqP53s0U3Id4yQHXrA2HGMXcRQgWlrATwp7TXWLu916mFxWHgghOetUybRKzi9yY0LvG3GuqsM+QydoriZPFPBYWZiX9F4dPtDSShdWc7u99t8JxIZzvx1nbAGSN3KW/Nsc4LtxFHNAPFs17bcfPAmyv/g2CO9s7LDccJW5zrRgFrzeFwBUAk6/vhEwHyQF4ffUIdxnSoQk+VN9d4E+qjbqfL+JpeKJ5MxXemYxgIkSP3lEnAwT79jhPw91dEj8K9RU9KFCMJySqp4TVor+LprPVXGh6AK0gB4I3iK2NECKElTM3zEP6TlRGOPUFAraLcjZ7aEdRwj046TZB28Zyj6y9nfLJT12Oas3lUO2RDGaoa1KbsL8zJKVtau9acFoDGXI8g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: baa239b3-945a-4ad2-c112-08db100c49fd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:55:17.4294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: teUPW9ETI6ED7yp/suWy6OIHrAhIqEGdHaQM2NyXnfjssspq0viyLoUR0SjnKm7mCp+bL+GCQ8v6vg0VDRjV3D9ecQpZYQwGev1Mp+1keOs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6597 On 09/02/2023 10:39 am, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change > indentation style to Xen's there at the same time (the file already had > a mix of styles). > > No functional change intended. > > Signed-off-by: Jan Beulich So I suppose Acked-by: Andrew Cooper because this is an improvement on the status quo, but I have quite a few requests. > --- > For most (all?) of the single bit I was on the edge of switching them to > bool - thoughts? Yes. > > --- a/xen/arch/x86/include/asm/msi.h > +++ b/xen/arch/x86/include/asm/msi.h > @@ -66,15 +66,15 @@ struct msi_info { > }; > > struct msi_msg { > - union { > - u64 address; /* message address */ > - struct { > - u32 address_lo; /* message address low 32 bits */ > - u32 address_hi; /* message address high 32 bits */ > - }; > - }; > - u32 data; /* 16 bits of msi message data */ > - u32 dest32; /* used when Interrupt Remapping with EIM is enabled */ > + union { > + uint64_t address; /* message address */ > + struct { > + uint32_t address_lo; /* message address low 32 bits */ > + uint32_t address_hi; /* message address high 32 bits */ > + }; > + }; > + uint32_t data; /* 16 bits of msi message data */ > + uint32_t dest32; /* used when Interrupt Remapping with EIM is enabled */ The 16 is actively wrong for data, but honestly it's only this dest32 comment which has any value whatsoever (when it has been de-Intel'd). I'd correct dest32 to reference the AMD too, and delete the rest. > }; > > struct irq_desc; > @@ -94,35 +94,35 @@ extern int pci_restore_msi_state(struct > extern int pci_reset_msix_state(struct pci_dev *pdev); > > struct msi_desc { > - struct msi_attrib { > - __u8 type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ > - __u8 pos; /* Location of the MSI capability */ > - __u8 maskbit : 1; /* mask/pending bit supported ? */ > - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ > - __u8 host_masked : 1; > - __u8 guest_masked : 1; > - __u16 entry_nr; /* specific enabled entry */ > - } msi_attrib; > - > - bool irte_initialized; > - uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ > - const struct pi_desc *pi_desc; /* pointer to posted descriptor */ > - > - struct list_head list; > - > - union { > - void __iomem *mask_base;/* va for the entry in mask table */ > - struct { > - unsigned int nvec;/* number of vectors */ > - unsigned int mpos;/* location of mask register */ > - } msi; > - unsigned int hpet_id; /* HPET (dev is NULL) */ > - }; > - struct pci_dev *dev; > - int irq; > - int remap_index; /* index in interrupt remapping table */ > + struct msi_attrib { > + uint8_t type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ > + uint8_t pos; /* Location of the MSI capability */ > + uint8_t maskbit : 1; /* mask/pending bit supported ? */ > + uint8_t is_64 : 1; /* Address size: 0=32bit 1=64bit */ > + uint8_t host_masked : 1; > + uint8_t guest_masked : 1; > + uint16_t entry_nr; /* specific enabled entry */ entry_nr wants to move up to between pos and maskbit, and then we shrink the total structure by 8 bytes (I think). > + } msi_attrib; > + > + bool irte_initialized; > + uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ > + const struct pi_desc *pi_desc; /* pointer to posted descriptor */ > + > + struct list_head list; > + > + union { > + void __iomem *mask_base; /* va for the entry in mask table */ > + struct { > + unsigned int nvec; /* number of vectors */ > + unsigned int mpos; /* location of mask register */ > + } msi; > + unsigned int hpet_id; /* HPET (dev is NULL) */ > + }; > + struct pci_dev *dev; > + int irq; > + int remap_index; /* index in interrupt remapping table */ > > - struct msi_msg msg; /* Last set MSI message */ > + struct msi_msg msg; /* Last set MSI message */ > }; > > /* > @@ -180,48 +180,48 @@ int msi_free_irq(struct msi_desc *entry) > > struct __packed msg_data { > #if defined(__LITTLE_ENDIAN_BITFIELD) There's no such thing as a big endian x86 bitfield.  Just delete this ifdefary to simplify the result. Additionally, the structure doesn't need to be packed - its a single uint32_t's worth of bitfield. Finally, can we drop the reserved fields and leave them as anonymous bitfields? > - __u32 vector : 8; > - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ > - __u32 reserved_1 : 3; > - __u32 level : 1; /* 0: deassert | 1: assert */ > - __u32 trigger : 1; /* 0: edge | 1: level */ > - __u32 reserved_2 : 16; > + uint32_t vector : 8; > + uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ > + uint32_t reserved_1 : 3; > + uint32_t level : 1; /* 0: deassert | 1: assert */ > + uint32_t trigger : 1; /* 0: edge | 1: level */ > + uint32_t reserved_2 : 16; > #elif defined(__BIG_ENDIAN_BITFIELD) > - __u32 reserved_2 : 16; > - __u32 trigger : 1; /* 0: edge | 1: level */ > - __u32 level : 1; /* 0: deassert | 1: assert */ > - __u32 reserved_1 : 3; > - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ > - __u32 vector : 8; > + uint32_t reserved_2 : 16; > + uint32_t trigger : 1; /* 0: edge | 1: level */ > + uint32_t level : 1; /* 0: deassert | 1: assert */ > + uint32_t reserved_1 : 3; > + uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ > + uint32_t vector : 8; > #else > #error "Bitfield endianness not defined! Check your byteorder.h" > #endif > }; > > struct __packed msg_address { > - union { > - struct { > + union { > + struct { > #if defined(__LITTLE_ENDIAN_BITFIELD) Same here for ifdefary and packed. > - __u32 reserved_1 : 2; > - __u32 dest_mode : 1; /*0:physic | 1:logic */ > - __u32 redirection_hint: 1; /*0: dedicated CPU > - 1: lowest priority */ > - __u32 reserved_2 : 4; > - __u32 dest_id : 24; /* Destination ID */ > + uint32_t reserved_1 : 2; > + uint32_t dest_mode : 1; /* 0:phys | 1:logic */ > + uint32_t redirection_hint : 1; /* 0: dedicated CPU > + 1: lowest priority */ > + uint32_t reserved_2 : 4; > + uint32_t dest_id : 24; /* Destination ID */ Considering that these fields are stale (its missing the remappable bit for one), I do have to question if we actually use them correctly in code... But that's not something for this patch. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 11:13:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 11:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496468.767228 (Exim 4.92) (envelope-from ) id 1pScCh-0004h6-DA; Thu, 16 Feb 2023 11:13:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496468.767228; Thu, 16 Feb 2023 11:13:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScCh-0004gz-8v; Thu, 16 Feb 2023 11:13:31 +0000 Received: by outflank-mailman (input) for mailman id 496468; Thu, 16 Feb 2023 11:13:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScCg-0004gt-LS for xen-devel@lists.xen.org; Thu, 16 Feb 2023 11:13:30 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f06ea350-adea-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 12:13:29 +0100 (CET) Received: by mail-pj1-x102d.google.com with SMTP id fu4-20020a17090ad18400b002341fadc370so5472120pjb.1 for ; Thu, 16 Feb 2023 03:13:29 -0800 (PST) Received: from localhost ([122.172.83.155]) by smtp.gmail.com with ESMTPSA id u11-20020a6540cb000000b004fbd27c4715sm984377pgp.42.2023.02.16.03.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 03:13:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f06ea350-adea-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=CRIAf2mxIcjkfWTde+v4O2KiUQlo/kXew0HUnA36GBU=; b=eRn1NGliAAfLn+SKyhZxpWV50Bi6dqmOViFM1ayotJjK621018/G+8hISPkt/rh/9t a+E6E55rq6DR1wYKvk/KiGR0sq912dnOmCmzXpGD0GoFuzjuSBnX9p3BiS01EwFi+jx3 xRjDKAXBudqhoJ4AomuOGFLW5uM7qMexiSCpiiHXdDOnBvNODH4oADPJQGkcxcQ4ud10 PaCxG2ZO1KEQDTVg4TKV0aZMQ++UsY2gupVjW8vhRqnXK60jHNjxJJYtrz+CkNJlTzsF 0zLgKe6z3OWVOrzrBIH4+d6pN/K0f+kQ/NTue+gKgD6GlR7wm/HO2LErngp7cTnitWcX Tqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CRIAf2mxIcjkfWTde+v4O2KiUQlo/kXew0HUnA36GBU=; b=CrPIP+Txsh2gEgyXxIWXafBtmBp+uWonvRwHzl2kWcEEI0X/Z4X2VTuxCMEWJiu28j iM9UlLY3g9xSrUxOAtQ2XQ7JChlLHrUkuji3GuBd6e5JFJIYwyCUMJH2xQqMxthgMFNF yVB0I4VgzXzPAqVG+pO8XZflwHwdZuIIS2N+s8V9wQqPxI2+CrekzCCH99+cyhapa85t 7Hc5UZlbEwcC/9/DVH5mzedUVcqFsOsNAuCuOcQEASP16RYfwTFlu+Aollp4bh56bZiw usSwi0nZk2v/3Ap7GZvYHDBZtCxkbMUTsQ8t7VjP6cMoDHs1uVxTUzumOFd/lR43LKfi l9KQ== X-Gm-Message-State: AO0yUKXwRXc9ov0tVm0jXB+mprS7ekZf7JnBLCt4HCdvBGrVSJBu3KWC /lW46C1jFOTLqxAa+5nU+NFodA== X-Google-Smtp-Source: AK7set80hh4BuqDCLmIFAQbj2QNNGohaQSZfOwF+EAwzxNCx2453l5aOt4lc7oVKh11dNEFa6h5TbQ== X-Received: by 2002:a05:6a20:430e:b0:c5:d784:a20b with SMTP id h14-20020a056a20430e00b000c5d784a20bmr6006741pzk.29.1676546007896; Thu, 16 Feb 2023 03:13:27 -0800 (PST) Date: Thu, 16 Feb 2023 16:43:25 +0530 From: Viresh Kumar To: Oleksandr Tyshchenko Cc: Stratos Mailing List , Alex =?utf-8?Q?Benn=C3=A9e?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org Subject: [Discussion] Xen grants and access permissions Message-ID: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Oleksandr, As you already know, I am looking at how we can integrate the Xen grants work in our implementation of Rust based Xen vhost frontend [1]. The hypervisor independent vhost-user backends [2] talk to xen-vhost-frontend using the standard vhost-user protocol [3]. Every memory region that the backends get access to are sent to it by the frontend as memory region descriptors, which contain only address and size information and lack any permission flags. I noticed that with Xen grants, there are strict memory access restrictions, where a memory region may be marked READ only and we can't map it as RW anymore, trying that just fails. Because the standard vhost-user protocol doesn't have any permission flags, the vhost libraries (in Rust) can't do anything else but try to map everything as RW. I am wondering how do I proceed on this as I am very much stuck here. -- viresh [1] https://github.com/vireshk/xen-vhost-frontend [2] https://github.com/rust-vmm/vhost-device [3] https://qemu.readthedocs.io/en/latest/interop/vhost-user.html [4] https://qemu.readthedocs.io/en/latest/interop/vhost-user.html#memory-regions-description From xen-devel-bounces@lists.xenproject.org Thu Feb 16 11:35:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 11:35:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496475.767239 (Exim 4.92) (envelope-from ) id 1pScXi-0007oD-0e; Thu, 16 Feb 2023 11:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496475.767239; Thu, 16 Feb 2023 11:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScXh-0007o6-Tn; Thu, 16 Feb 2023 11:35:13 +0000 Received: by outflank-mailman (input) for mailman id 496475; Thu, 16 Feb 2023 11:35:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScXg-0007me-Ru for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 11:35:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f47672f5-aded-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 12:35:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f47672f5-aded-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676547309; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bPG+IKs3jCl4f6bGnU79qKb+PyDR4NqGoTeP9Duf/6o=; b=JRTMg73g24ncbUXqvhPVxDeQNwHfnBZbJC7ARd+0X+VdaLHhg8Qo2I1V H9Y6Xb8qjZtP+eVYuXit0N7JudKx/JJQf/RLik3NZ+kkxeqt9zJgKNI2w PgGy9goszQCUkY8iNG126TfoyaBxLebZvISk1Gs9klm69NPuHEHiiAgGd 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97293965 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:a4/akq2AMfM5cUdic/bD5eRxkn2cJEfYwER7XKvMYLTBsI5bp2RTn WpJC2nUM67ZazSnLtolOdjk8B8O7ZfXmIVrSwpqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnO6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfOUNP3 uxfDSw2fBXeofDn3ZKgU7Jor5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFJoPzx3J+ D+uE2LRWA4iDfa1xCe8qWOprdbvs37jaKEQLejtnhJtqALKnTFCYPEMbnOguuWwgEO6X9NZK mQX9zAooKx081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQNcvrsMxSBQh3 0WFmN6vDjtq2JWcUX+H/62YhS+zMyMSa2QFYEc5oRAtuoe55ttp11SWE4glSfTu5jHoJd3u6 wiorQMuwJAPttwOioOprE3nmCv3orGcG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl CNawpbDtYjiGbnIzXXQG7tVQNlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM Cc/Ve68jaK/3UdGj4ctP+pd6Oxwl8AM8OgJsdiFBueimrArKGe6ENhGPCZ8JVzFnkk2ir0YM pyGa8uqBntyIf05k2TqF7lFi+V6n3FWKYbvqXfTlUnP7FZjTCTNFedt3KWmMIjVE59oUC2Kq o0CZqNmOj1UUfHkYzm/zGLgBQliEJTPPriv85Y/XrfacmJb9JQJV6e5LUUJJ9Y0wMy4V47go hmAZ6Ov4Aan2SyccVzXNS4LhXGGdc8XkE/X9BcEZT6As0XPq671vM/zq7NfkWEbydFe IronPort-HdrOrdr: A9a23:Fq/oyqs9eQYUX5Q7AMYdrhxM7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97293965" Date: Thu, 16 Feb 2023 11:34:43 +0000 From: Anthony PERARD To: Stefano Stabellini CC: Andrew Cooper , , Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt Message-ID: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-4-anthony.perard@citrix.com> <3caee35d-3c0d-7e28-dc66-6f422568edad@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Feb 15, 2023 at 04:14:53PM -0800, Stefano Stabellini wrote: > On Wed, 15 Feb 2023, Andrew Cooper wrote: > > Honestly, I think I'd prefer to drop all of these legacy versions... > > Good timing! It just so happens that we need to shave some of the old > container tests as we have too many build tests on x86 :-) > > I would remove Jessie as it reached EOL years ago. Do we really need > both Centos 7 and 7.2? If not, we could remove 7. Actually, 7.2 is older than 7, so I would remove 7.2. (7 would be 7.x so latest 7 which is 7.9.) > That leaves us with Trusty and Centos 7.2 among these. I would be > tempted to keep Trusty and add the sed hack of this patch to make it > work. For Centos 7.2, the hack looks even worse. Would it solve the > problem to upgrade to the latest Centos 7.x subrelease? Is there really > no other way to solve the problem? So for centos7, the blacklist of the expired root certificate isn't needed if we simply run `yum update` which for some reason is missing from the dockerfile... Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 16 11:37:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 11:37:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496481.767250 (Exim 4.92) (envelope-from ) id 1pScZJ-0008Lo-Ap; Thu, 16 Feb 2023 11:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496481.767250; Thu, 16 Feb 2023 11:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScZJ-0008Lh-80; Thu, 16 Feb 2023 11:36:53 +0000 Received: by outflank-mailman (input) for mailman id 496481; Thu, 16 Feb 2023 11:36:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pScZI-0008LV-7a for xen-devel@lists.xen.org; Thu, 16 Feb 2023 11:36:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 310d00b5-adee-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 12:36:47 +0100 (CET) Received: from mail-sn1nam02lp2044.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 06:36:43 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH8PR03MB7173.namprd03.prod.outlook.com (2603:10b6:510:258::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 11:36:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 11:36:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 310d00b5-adee-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676547409; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=dbij6wud+VIMPRG/4dhS69e7R62YJAqGrWpkgWI4CTk=; b=EWD3V7TFmev0U4gHybb3dKbt3Y3h+H3B9+9qvPcvFfYLINss2nNo74Ng ILpeyhG1OfZRAx3s+3NpNW0ysa1dLvx+/nkNxu/eDDHiLz9or3t6D4OSK 7TQPp3EpXTU3t7xYSPb5UDZQkYMbv0YKXYK5QYk2GnHCyERJn36xfZf7Q s=; X-IronPort-RemoteIP: 104.47.57.44 X-IronPort-MID: 96132332 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iGVfnqKhj/t0GkzxFE+RS5QlxSXFcZb7ZxGr2PjKsXjdYENS3mFSy GJOWmGAa/zeamOmc992aYm38koFv5bXzoNiGwBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c57W0MT/ 6U1dAkOQRbZ3tiw6YKgSMlz05FLwMnDZOvzu1lG5BSBV7MdZ8mGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTSPpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eew3qgAtlJTtVU8NZjhVGRzzUCIyQRRECUq/qko3O/Usp2f hl8Fi0G6PJaGFaQZsf8RRCjoDiHoxsVQfJUEusz8gbLzbDbiy6eAmUHVSJQc9wOu8o/RDhs3 ViM9/vyGSZmrLqODH6Q6J+TtXa2ODMJNikGZCkNVwxD5MPsyKk6ih/fCNxuFqi4g/XxGDf52 TfMqzIx750WhNIL1qimu0jAgiitq4LhSg8z7x/QGGW/4WtReo+jbIGu9R7U8PdcMIGFZl2Au nEenI6Z9u9mJYGAkmmBTfsAGJmt5u2ZK3vMjFgpGIMunwlB4FamdIFUpSp4fUFgN55efSezO BOP/wRM+JVUIX2mK7dtZJ68ANgryq6mEsn5UvfTbZxFZZ0ZmBK7wRyCrHW4hwjF+HXAW4ljU XtHWa5A1UonNJk= IronPort-HdrOrdr: A9a23:K97zaKOWxi+Oh8BcTvujsMiBIKoaSvp037BL7SxMoHluGfBw+P rAoB1273HJYVQqOE3I6OrgBEDoexq1n/NICOIqTNSftWfdyQyVxahZnOnf6gylNyri9vNMkY dMGpIObuEY1GIK6PoSNjPId+od/A== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="96132332" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDeDOg6BIKI0X++IsNY+ApvEzcsK8yrX5g6K9DwKXSeQ66Fg1aHcx+nvB41/NLqZcnWHNPCt31RhGt5d9zp2ZzKc92iyaeCdM762lTM9aI4AbbO1mPtO4+7+hO89fCIz7R6O8PPti+NKNNIusoyXlhSBTwU3KzK1V2cqPSDHtr9oZj9sP0p2XppkKRu2geUAC8Qa7l86+SQjQjPEg284ft+D6oiZv3HQn76CQo16gOm1agno9BzukZIzud1rDb+6cZM0pJ09/e4r7krrbEsvd2aCzloe2m/jcF93TDEWkYYejsSCQPgRH8cMTjr22o4wCodM4YL8NeOwNxWOcVRlHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dbij6wud+VIMPRG/4dhS69e7R62YJAqGrWpkgWI4CTk=; b=fnWaozxLzkrobOHXfY1oqWWR4cpClFQN6/gH6rLbVtTz7Hco05ccLhUX3vpnsBLp83Mu/Yf380qagkt8vpFBRPANezgmMg46R5t2D+DwitCyIrDHqpLQMvYeGypEtJ2goJR6h8YNeuO4uLJ1dztbhZw1UOhyFjZPm81mP6EgVSs84Yk6ilHBQNxjBJK+Z58i2V6wKKnY8SseEttabdBrxDfTOnAi174iDtvdAhAyH7lcl9QNqAAIkZ2neF4HgQaTUm0EqH9EzxTlvkHThqS2PxJh7jn90WxYNE+V1BATkYIMxROFNq0gkJ5wBVqRShX2k1axvOSsnbuJQWd+ByClNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dbij6wud+VIMPRG/4dhS69e7R62YJAqGrWpkgWI4CTk=; b=hGl0KNUvCQsvN84AlUuLF5hVqnVO0bJjk2fzBc2kNEL7zZqa5AhJy0m0MlNkIVyxuwMmqhdxrRneIBsw59AwaZreYCAZhmET94c0YwMyUW/v5ChBU8LFZvvL/thg2Ma/VS3Hsxzm5A24id+VteYiJrw576aFeGYDyfq8X+Ch+gc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> Date: Thu, 16 Feb 2023 11:36:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [Discussion] Xen grants and access permissions Content-Language: en-GB To: Viresh Kumar , Oleksandr Tyshchenko Cc: Stratos Mailing List , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org References: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> From: Andrew Cooper In-Reply-To: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0517.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH8PR03MB7173:EE_ X-MS-Office365-Filtering-Correlation-Id: cefa2d12-198d-42f5-c0c0-08db101212aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZF+3YLJjF0YLf+xtKV34FQzQtaTiKJ3KkdbDSFLQ0U0RxegwHM6fg2wi9T0HrxESaVkPDpXA3EyeEKb9kX7g2c9KX4T5hzOWpDxKViduz54dzgkr0hxzr36WEbQto7sDKAS5gvKu6fkWAXqGO8oiI1EPt/3wCrklv8TcGXN74x0sqAh8sEVIWhO7C64ktefFUWS9sAroV7+dxnf0eRKfFKuIDkmLH2IV5todMCvupyPNu5zuUdaKGt7Wl/J4XdV6F/oLBpEityZ9ZVmigexDpg+0M7LybGxSKUXOrzdNXzfhw2VeSHO39ErMzNDE0U+93i72kPgUiSLEOOVJabv4Zi3D0mdPNMTw3AdIcsoOQ5a/csgmnhvhTQybfFXMTCuiaj0PzKva+UH/mINIC8416fNKrxPls3Z2K/YMi1IKc14JJS90p8s6PXSMhYeyF//WDGK184MgalnB7wqSQRlAdhf9WhN8PUlBr3BCB7fo7wGUszR0h8MPqJLc8Zvc/lNeR8VXaH9Iv9xSTSQEvFjzvENQfl2rvpNSBeHq8XPyj8IzeU1Kr/8vmfKMtP2pLjggSfkDx7dqqep9/zda/BklGRE14pSOfJ4Bplhv0UIEnlO6GBB+K68vuGRbLjx+t1WqxL5fk6DS2HyITgbWHuUPevU3+NSEWBNA2dBSLRjou3n/e6HAF2qVs8fHT2Ieqv6qxlkM2W5xWy5cW/Bg3mAfdOjqYoFsYTxyaoapIYqqkUI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199018)(31686004)(41300700001)(38100700002)(36756003)(82960400001)(2616005)(83380400001)(478600001)(6486002)(5660300002)(8936002)(53546011)(86362001)(6506007)(110136005)(186003)(31696002)(6666004)(26005)(2906002)(66476007)(4326008)(66946007)(66556008)(8676002)(6512007)(316002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzRPR1BGMllXcDc3WHp1dmxZZWdsQ3FrZ1A1ekIzRTR4Qlp2enRpUTdKRWor?= =?utf-8?B?SkFoN0MyaHdHZlEza3ZqbU95SFU4SkQ1dllJZXBlVmlDejVHb0FwQWZhcWZ5?= =?utf-8?B?K2NKUXlCZHZDQWFtSWpENG11REhmS2FQbXRVRkltRTdwTEdoSjcrRllCMlhU?= =?utf-8?B?SnZwQjZ5eXU3cjh0dDZMdjFlT0lDRVpTVUpmZnBYS0pIOEF5bzMrZWRtVUZ1?= =?utf-8?B?bXFNMmRhNGhVTkFMZ01uUWpwR2ZSZ0V2MFJBWUN6RTRkT2tOWjlBbGVXdnRv?= =?utf-8?B?Q1NERmRSUGd6VWlUb2NPSVJWWDNPUkZrV1pSQ1Jrd1hVbmtpVGRSZVZKUjVX?= =?utf-8?B?MWZ6ZXlwOWJuODRzcU5nZjZzUDREbElRMUtSa0pRT2poTjBKT2I0dm9HQnBS?= =?utf-8?B?SnpWTUFoV1BRV2J0QmQzQklMRWFGdGFZNk14ZWQ3QXBmSlBxQzRNeGVjeURw?= =?utf-8?B?U2twMUdNOG1sbng1Zmt1RkpFeWxWd3FNU2xjMXVjamtiVDdnZWJ2YWRxOVBI?= =?utf-8?B?eno3WkVDaHE5UEtLc25zU3JRLzlMdlFKYmxvVmc5QVo4MVh1RVE5Sk5WSXpJ?= =?utf-8?B?MWxBMysvRmlSRno0UHdsQ2JPVUVSZTZkaHRON21rSGZhanJHZlo4SVVyQTlL?= =?utf-8?B?YWUrNkJ3TS9Gd2hLYy9XOXI0MUJFZCtaMnl2NlNORlBxUUQrMmp5SkVjWWRm?= =?utf-8?B?MDlOcEQ1NXhJYVo4RkVPN0lDK0FTeGIrR1Niek4wS0lzYVdOMEk1ZmZCLytv?= =?utf-8?B?c0R6L1VnS2hhV0U5QTNqM1VnY1ljbXVIekcySEJSVkJVM2xUcVVxNGNvcWpj?= =?utf-8?B?Qmg4Vm5HYVZhYVlBeC9sMkt4S2lMQjI5ZUdUeml2SU52SmNkZTNQRlZQLzVB?= =?utf-8?B?K1BLbHhwNlF2WVZJdGkyV2lacit4M3QzcW1nYXZob2t1cnhvRXZEV1J1M2I4?= =?utf-8?B?Yys3SHBZM2t5Z0xqWjhXRFdBd0VUWFIrYzJmM2RtMkNTdVRuM0xVMGlrQmh5?= =?utf-8?B?bjJRMEttRTUrVDVDdkZlVjVYaS9FeGpvakJZcHJMeTNQWTRnWGM3VDVGMk1k?= =?utf-8?B?OXJjUXFRVmplUTEvczk3bDRza01ZYm1yakZGZXpMUFhrNTZCcTBLM0k1YVRR?= =?utf-8?B?L0d6emozWUdzQTV6OVp6RzI3M0VqREhMWkNNRE5RRXBKYk4zK041TCthNmFa?= =?utf-8?B?SXh3Uzl4OVhuamRNS0E5ZWhaTFdEYTlmSWh0OVNFbDZ1U2xnYVYvTWdyUG03?= =?utf-8?B?M0pOSVNJaGoxaTI1OTBQcWVXQ0pZZEY3VEt2SURuSU1pN3R4L2QwdndrL1Fw?= =?utf-8?B?NU9pbjlKN0ZYaytmYU41Qjl4SDhmVTJ3VFVwRkU4aCt5VyszSUdCYVIveUc2?= =?utf-8?B?eGM2Umo3ZXMrdncxMmNWS1FFVFF6MCthOGp1TjBpbVpOR0hqRXhaNDFwUDdw?= =?utf-8?B?aThSb0VOMWNac0c0aFMrRUZ6UWlic0s3dHV5NWRNKzRzcmNSQ2doRjF3RUZl?= =?utf-8?B?UVFUbXNPK3RWU1dvT2owTFcxN3ZINFo2bG4yYjRlWmhZWjZpYUN0T0h5bUpr?= =?utf-8?B?WCt6RXpqKzlRZUlpdEswYmdzQUZmcXVDa0JGL3N0SnNzaVVicEdKYlh3S2VV?= =?utf-8?B?QWFwRE5zVkt2N2ZEOTczWVdFM2tzTks4S0tLVk1QZm8zNFVoSEp4bk5TV1Mw?= =?utf-8?B?ZXBIMWtHK2M1OHBaYUVKRGdNdHJ3NkRDVDljY2cyNU5KbktHM0Y2WVMwTjhs?= =?utf-8?B?cm5pOWkxOGdlUjErcFhBMm9ibXV5ZWluaVhWWTdQeG5oclRzQ2RsMDhuVDBD?= =?utf-8?B?M2M2ZlY3NGhZUXBUMFFGc0FWMnFvWDROSGNBbEk5RnVIcjhJMHF6b01SMFU0?= =?utf-8?B?TjBFY2NSaVNNL1hYakxWMzBsRXFVQWx2M0hlU3pDbHZvWnl2ZytXVjhPenZU?= =?utf-8?B?V3NVMHpEVHFyQ25TaXBlZUFEYWNTT0MxdkJKU01HS0w3dXFJUEdVSTZ1K2dz?= =?utf-8?B?Z0x2ZU9oUDA0b3VpMTdBSytjanJCYXJYRDJuOU1ITG9XZGxIbThJN1J4QXBu?= =?utf-8?B?M05sSGFSTlIreVBpVVl4QlJycG1YMlZRbUFKdGJ2NHlleEpmR3VFQU5BOUJ6?= =?utf-8?B?cW5KVEI1d2h6UWpVcS85ajJnWXJ4SEpDVVNtRmxqUVIwWnpvdm40M1QvVkI1?= =?utf-8?B?SVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mkQnCM2yV/tXDYvGfBhICyb+dgVmNy4GDDY7EG2bqPejiNOSCmyuv3mlQjnqvrf0wGhzPraGHM0RNmlSnOEdfbvtq0EiRctzMYbhKYtrX3wmT3ioKyHtFHHUoA3UY2QgGc12/hI99mMZmyXS8Eyz4WYdRO6XIOOLcoIuwj8xwtrUT56D0BbLYCOZmE31ebg6TE0fd6Wzpbe/cVlOrSlN/93/S62xv5XPcoITmX8F/h0mU9ECUPyqhtLwmDa7FZW/As/HITAqRy6yRDxqJqaSK+/tug/TdWW8H/j8OP8skW5235FhdMSKraV9ydd6YR/0oG4Ai0bmOTCK3k6h/3CGB0VlN3+Y6c4GWqPT9emfhU5NAsBTFPvwPFmELxLJA+CZZd8RQvT/+m+DusmXwsadTRspdVtnqRMFd0tKO1EciqCUnSZ6xJzU2FtMXr06/3ypN/9UBG1V5/ZW2Ch9LeGOJg8Jhm0FsUAxhpq2w3YB6qqXjHsD7hm8ZIcfdyVK1XE9nGxbrQw6zujMwaYq+vDjyq+ueVyTrVkky7kRvB9xE97I4dM0kb1oMd7DjeY00l/Ud4vPTAdlDDt7axBI8GGNXnEPpyPDhc/N0C3KrQav44BJ8JB1E5FsIdUk+Ey5/EnnC8If7twm3x+Ou/Fjb9oenjl2dhiD+TEanLOgRnzEY9gYMayevKo0gBH99pNVH8PnudckEZHpzUd8odJpPE9BDhILeB5K/mGqVmw4VEN+Az20HDrFSIIZflk9tQbgUmsNnGiDYvcWs8WdJNp/p41rPgnzgNnsMeoYinH4n60Q4Bu3/nNptakI6XT/o2duME3vvx3nK+ZKpqrzSd/ZSFGTcdU/YI2L2XSkUv5X2q5gBXzV6W458kSc/1yY37pLk0FI X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cefa2d12-198d-42f5-c0c0-08db101212aa X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 11:36:41.4349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jwqepL9QfFpN8urNtJS4//wo0hTxlOb62vI7dPDTvqpmrkp6UWad3IUxDjxgS2jSFCuSexjN8SlOoNlUW8x+GdCiIk31rbeotNgUND0BxDM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7173 On 16/02/2023 11:13 am, Viresh Kumar wrote: > Hi Oleksandr, > > As you already know, I am looking at how we can integrate the Xen > grants work in our implementation of Rust based Xen vhost frontend [1]. > > The hypervisor independent vhost-user backends [2] talk to > xen-vhost-frontend using the standard vhost-user protocol [3]. Every > memory region that the backends get access to are sent to it by the > frontend as memory region descriptors, which contain only address and > size information and lack any permission flags. > > I noticed that with Xen grants, there are strict memory access > restrictions, where a memory region may be marked READ only and we > can't map it as RW anymore, trying that just fails. Because the > standard vhost-user protocol doesn't have any permission flags, the > vhost libraries (in Rust) can't do anything else but try to map > everything as RW. > > I am wondering how do I proceed on this as I am very much stuck here. > (unhelpful comment) This is what happens when people try to reinvent the wheel a little more square than it was before. If the guest grants the page read-only, then you can only map it read only.  Anything else is a violation of the security model. So either you need to adjust the guest to always grant read/write, or you need to teach virtio that read only is actually a real concept. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:09:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496501.767264 (Exim 4.92) (envelope-from ) id 1pSd4i-0004oW-6S; Thu, 16 Feb 2023 12:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496501.767264; Thu, 16 Feb 2023 12:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd4i-0004oP-3n; Thu, 16 Feb 2023 12:09:20 +0000 Received: by outflank-mailman (input) for mailman id 496501; Thu, 16 Feb 2023 12:09:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd4h-0004oJ-DL for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:09:19 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcaf001f-adf2-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 13:09:18 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id fi26so2466867edb.7 for ; Thu, 16 Feb 2023 04:09:17 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id q11-20020a50c34b000000b004ad601533a3sm422926edb.55.2023.02.16.04.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 04:09:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcaf001f-adf2-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+rvTnCnzqJRXWG+D4rl2CsOR2V/ZtCHf/A1dqqj8plo=; b=L9Pu5+mI4tcSLNl/KOdfMvszFa3LlfteKQAXEXu8B7tXtTtwHR1EqvS3BJ+qC6iabW BZGbHx6svsY7b3xKJ/8bCUPf4Rm0wK72qtptpenZHY90InKyhfxK/qFnOmTxU0dPibbw 4t3lFtQj0KIAPlMIhUyFyJo5j2w40s26/dBlFOLqJ02ze7x9CtrxtJfy3W6rwK04FHYa DQ7m4eq1DQJEaAUC1oKFmch/r34W0Lg1GHgg2RgWg3suD3rxKnnbzFrkA2IEY2X4cXuc FYn2TkaccK/I97/7Qo1fZQ6KiPjYlLSmc1fHJ+fPHwrGaEDqBYX41hQuV/lcqv9bBw8K mprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+rvTnCnzqJRXWG+D4rl2CsOR2V/ZtCHf/A1dqqj8plo=; b=Nn5MUrKMpl7P3VIPi3nDQ+QcXR3M3BlQIM1I3NhF4H/jQ0x7xfiNUjDA6sIcvTkIZQ +TWf6Q+1DdsxrKW9HSMJtS+p+j7ku1AQVeIFT9FmRnsSxNK08v3AXnht934HjfZFjqEO 1V22dOhIuYk2//u6gGkwN/nDtNqvR+DiEJ+CpsfFcCn5Mv7KZ19GHYt8kRN5CgU27vl7 /DzSw+XAT98NJ/L0hDS0/Se/Z1g9gH3ue0jWBGpPKWEMnjctRBnPrP5ew8uTpdBaKOvk kw6KIy1WYQCa4yIOGrzN0w3W/AGLyyHcnDpiKXyJC9a6pbVmXzYNoQa3wtpz9K2ArnwA y1Kg== X-Gm-Message-State: AO0yUKVqTMkRag+wIkZlovjpl3yLOYUvMI8fOhcxybepGBaRijUaoRJR 6fi/47Jagcj9uiXsO28vL0s= X-Google-Smtp-Source: AK7set8nueUGXDC51e26JARy7S/yKY6hE9GZL7VAiXMEoxm1SK/V4M1YnLEyvh91Oz2VMuvka/5Hvg== X-Received: by 2002:a05:6402:2c9:b0:4a2:4a89:2331 with SMTP id b9-20020a05640202c900b004a24a892331mr6222426edx.29.1676549357342; Thu, 16 Feb 2023 04:09:17 -0800 (PST) Message-ID: <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Thu, 16 Feb 2023 14:09:14 +0200 In-Reply-To: <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > > On 15.02.2023 18:59, Oleksii wrote: > > > Hello Jan and community, > > >=20 > > > I experimented and switched RISC-V to x86 implementation. All > > > that > > > I > > > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. > > > Other > > > things are the same as for x86. > > >=20 > > > For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT > > > will > > > look like: > > >=20 > > > #define _ASM_BUGFRAME_TEXT(second_frame) \ > > > =C2=A0=C2=A0=C2=A0 ".Lbug%=3D: ebreak\n"=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 ".pushsection .bug_frames.%[bf_type], \"a\", @prog= bits\n" > > > =C2=A0=C2=A0=C2=A0 ".p2align 2\n" > > > =C2=A0=C2=A0=C2=A0 ".Lfrm%=3D:\n" > > > =C2=A0=C2=A0=C2=A0 ".long (.Lbug%=3D - .Lfrm%=3D) + %[bf_line_hi]\n" > > > =C2=A0=C2=A0=C2=A0 ".long (%[bf_ptr] - .Lfrm%=3D) + %[bf_line_lo]\n" > > > =C2=A0=C2=A0=C2=A0 ".if " #second_frame "\n" > > > =C2=A0=C2=A0=C2=A0 ".long 0, %[bf_msg] - .Lfrm%=3D\n" > > > =C2=A0=C2=A0=C2=A0 ".endif\n" > > > =C2=A0=C2=A0=C2=A0 ".popsection\n" > >=20 > > I expect this could be further abstracted such that only the actual > > instruction is arch-specific. > Generally, the only thing that can't be abstracted ( as you mentioned > is an instruction ). >=20 > So we can make additional defines: > =C2=A0 1. #define MODIFIER "" or "c" (depends on architecture) and use it > =C2=A0 > the following way: > =C2=A0 =C2=A0".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", > @progbits\n" > =C2=A0 =C2=A0... > =C2=A0 2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in the > following way: > =C2=A0 =C2=A0".Lbug%=3D: "BUG_ISNTR"\n" > =C2=A0 =C2=A0... > Except for these defines which should be specified for each > architecture > all other code will be the same for all architectures. >=20 > But as I understand with modifier 'c' can be issues that not all > compilers support but for ARM and =C2=A0x86 before immediate is present > punctuation # or $ which are removed by modifier 'c'. And I am > wondering what other ways to remove punctuation before immediate > exist. >=20 > Do you think we should consider that as an issue? >=20 > >=20 > > > The only thing I am worried about is: > > >=20 > > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > > > =C2=A0 [bf_type] "i" (type), ... > > > because as I understand it can be an issue with 'i' modifier in > > > case of > > > PIE. I am not sure that Xen enables PIE somewhere but still... > > > If it is not an issue then we can use x86 implementation as a > > > generic > > > one. > >=20 > > "i" is not generally an issue with PIE, it only is when the value > > is > > the > > address of a symbol. Here "type" is a constant in all cases. (Or > > else > > how would you express an immediate operand of an instruction in an > > asm()?) > Hmm. I don't know other ways to express an immediate operand except > 'i'. >=20 > It looks like type, line, msg are always 'constants'=C2=A0 > ( > they possibly can be passed without 'i' and used directly inside > asm(): > =C2=A0=C2=A0 ... > =C2=A0=C2=A0 ".pushsection .bug_frames." __stringify(type) ", \"a\", > %progbits\n"\ > =C2=A0=C2=A0 ... > ) but the issue will be with 'ptr' for which we have to use 'i'. >=20 > And I am not sure about all 'constants'. For example, I think that it > can be an issue with 'line' =3D '((line & ((1 << BUG_LINE_LO_WIDTH) - > 1)) > << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). >=20 I think we can avoid 'i' by using 'r' + some kind of mov instruction to write a register value to memory. The code below is pseudo-code: #define _ASM_BUGFRAME_TEXT(second_frame) =C2=A0... "loc_disp:\n" " .long 0x0" "mov [loc_disp], some_register" ... And the we have to define mov for each architecture. \ > >=20 > > Jan >=20 > ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:13:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:13:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496508.767276 (Exim 4.92) (envelope-from ) id 1pSd8X-0006DP-OE; Thu, 16 Feb 2023 12:13:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496508.767276; Thu, 16 Feb 2023 12:13:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd8X-0006DI-LY; Thu, 16 Feb 2023 12:13:17 +0000 Received: by outflank-mailman (input) for mailman id 496508; Thu, 16 Feb 2023 12:13:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd8W-0006DA-5u for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:13:16 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47dd7826-adf3-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 13:13:13 +0100 (CET) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 07:13:04 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5083.namprd03.prod.outlook.com (2603:10b6:5:1e3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 12:13:00 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 12:12:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47dd7826-adf3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676549592; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=PXAHdz+75uBzY9Um+pTU8leXVzzVkK+0toYES2GeopI=; b=DaiKYO/8IYIO8gEODpx3XNrsZsEK3KUp9OGMxVh9Wwr2MxDJ45Y+G50W F77tyWU3aIzrA0A5zGjS197jA4xBqsZzMOrYtqubQf2jyRFd5w8E8qxEn AqB3mHn45QwVudea3+LJi8ZQtHz6XUOWh9uir8WZyOxpKOvoebXLa5w9G Y=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 99715687 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hnCBJ6xgDwyfSgc+vPZ6t+cVxyrEfRIJ4+MujC+fZmUNrF6WrkVRn DZKWj3XO/bbZmX9fdEjYIi+8hgG6sfTydIxSVBrqSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPK4T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KTBX2 M4aChtRUh+Oif2Sy7OjVOx3v9t2eaEHPKtH0p1h5RfwKK9/BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCd1LSePoqZaGhnWR3jctCU1MfGHrmtiwtxSUcsABF RULr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A79y9pog210vLVow6T/HzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:dx6RuamYbLRs97zFyCLpKXAFslPpDfNpimdD5ihNYBxZY6Wkfq GV7YEmPHrP41gssR4b+exoR5PwPU80maQV3WBzB8bQYOCZghrLEGgK1+KLqQEIcBeOldK1u5 0QFpSXA7XLfCdHZa6R2mWF+71L+ra6GG/Dv4rj5kYodCUvT5xJqz5+DAPzKDwFeOGFb6BJaq Z1IqB81kqdkbF8VLXLOpB/ZZmmm/T70Kj+ZAIABVoO8RDmt0LQ1JfKVyKA2wsYUXdl3bcm/A H+4nHEz5Tmiei/1hjfk0ja65g+oqqH9vJzQPaUj9QTKHHLlAGlf+1aKtu/lQFwmvir9FEp1O Ptjn4bTrxOwkKURHixvRzunzPtyykj8FjrzVPwuwqZneXJAAgiDtZHh8ZnfgDC60wm1esMqp 524w== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="99715687" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuUfi296dqqMMhs3k/Bdi/4BZXhDRTWKKmNylRjsn1ruE5w1geMhX6QxSNoLy1jT7EuKZf/yiSCfwDictNcq/nn2DdiARwtxc0eOb1irRoh5H7Tao0euxA5u9jfndr8eUoXYvL/tcBFugdY1eOEolDBM9e+NnkzmLlM6s9aI5MOMcDJrwXricqyQKPRp3aHUUOwePlwgwJZGmWc954a9UhcgzvZ4a11oC3gRsp373InY2YjhN1c275abOsFbZZN5p2zHaCyAQZf23cizCrUhfOq9deMKLZUXknguv/EflrJuDxhycBeRtLg+nxDIbmCvI0KQABMbQel+y/uRsEuDgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vK+IrBghED0m39s9V+gFp2OIx7T+4ggTO8MTQyYNMn8=; b=FBc2PvkwQHaXtpM+IirSq+OApujjktseZ6M0ol75Let8e0TlC1STJCm7ikEobxcpjZyVxRppMoZpnZLWYyS5PmAHzrw81QsKCOdQm+4vNrRatcN2bBaY7EDAB+T+1I98yyQeZuYI0GB50dXkjCyYg0DsZtxwOIXfv5gMgAhUKr04Nsyng1m05dLz6sXliQVFiWfNz0kB8aXsFY6Vz2VWptLErtTN5ldkN6eWbectGYxxo78teCONFI0HCuIgsWvLSdoAbChQGAaByeslBazl2X/CLkPU51AsVjV62/Wb/JZXTZyRXd/BUqFs3y1ZqiLW+JyvsjVkyl6YV2VOY6Z0IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vK+IrBghED0m39s9V+gFp2OIx7T+4ggTO8MTQyYNMn8=; b=DWMpccu/NH70GI+ZjorQOBpg6BrNUagDt97PMG1wHM4NgUP4gkxWKSYU6YwuEZxegOH5JZQJQligauBJ1e1MSeyowG/zo1xm4+4cg+otE2mC+AfpG+NGTGR4axFRspWaycZxDW5yQpAVCpFqf+QWgNzIutTxCGWnVlgC1PhFm3c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6249643a-ca00-442f-4310-c4fd62db8c74@citrix.com> Date: Thu, 16 Feb 2023 12:12:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 5/6] x86: use standard C types in struct cpuinfo_x86 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <969e851e-5674-9aa5-b00f-4fe4d4cf8e5e@suse.com> In-Reply-To: <969e851e-5674-9aa5-b00f-4fe4d4cf8e5e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0038.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5083:EE_ X-MS-Office365-Filtering-Correlation-Id: f4a56e95-2b31-4c92-6e40-08db1017247b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NYVy0iXVbQBzIa+k/u8V6+8bRgUkPf7O+PbB/6s/BmVWUsYN9p/7yeM1CSm+hAHhjmfVnjlCeS2Sqa9pXD4RJaCLRm3l+eIKx+pPGWfRqlbIGNTcjsttcS2g+SEUptzuhgGVzcJzk0/Io5Y6XZBwpp/xoZtpTVLt6vkFwZU7sD8fA7RxMIy7umjtRgTcdKwGyto/R7b4M5Ko+4ExBUKXuzsNKjTVuPXqxpfBI4pcq5Xhu/Y1tKDh4kiiYr0A+sP+HuG5qaqqIRWSeaniMg8BNfLVc5v9nVg0rNN5BeOTUauvgeM6j30SfwnJuwNNd1waqN67QGWBfmcTOu1+a0PuN1XEFYyYxxNaAwI2y7OKBMCXGi/g8qJMyOFsbHEqN8rSWs+XvkwnqIzBLry3asqAECbZAZvHU7H1VkgWmDXuZbmRFQl+AoZZij8+OYzBvkOs58CDknRSG7V/eAea3vF1d47CLH3KXNkt8/EO3Tq3prioXPVRz99gClX6LJMVCDFeU+/nOSms4BftXtx2LPJg+bnpuCL3/pABXdE6jRNswlqEWYB5ugQ5khTeAbltqDNWTjAQ0gbfzF7IPMfeX8McYvS5z9CjSTfIs18enn9jP9xC2t+gxmKiVYBGcEO9hc5SATY44+iyL0AJhePQYcUO0eQXFxK+jMPGFBdjBl9gzpHrpMerVWFV4mzKRWFv+5/Mfi3e8QjXiEdDZ/EsxW8PckDejICyTZWwQIbhmqD1tXg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(451199018)(86362001)(8936002)(31686004)(31696002)(38100700002)(41300700001)(5660300002)(82960400001)(8676002)(66476007)(2906002)(66556008)(66946007)(4326008)(316002)(83380400001)(6486002)(2616005)(478600001)(110136005)(54906003)(36756003)(107886003)(53546011)(6666004)(6506007)(186003)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUJ3YkJDMVVJWm5Hd3dVUjROVFZ1NHQ2bVZ2NXljUzV1Q3VwUFQvdVJqTURP?= =?utf-8?B?NzVLMFZ0K3JIcFRXMnExK0xSaGNGSGVua1J5MWg1a0lLWWNXTnJxYVMzMWpr?= =?utf-8?B?YlUwYTlJUzZOdVUxQk1XTjhwa3JIMTNWLytXbEs5SXJmeHkwU3JVc1FDakxH?= =?utf-8?B?WnY5eDFyQUw4a2Q5ZURrNWdrT01BN2NUS3JMYXRxZWVKV3lLZ0RqcjcrTUFy?= =?utf-8?B?b1dKdTlpSDB5K3JsNnBMTktOVUtVWWhBTGpSVjdLZjdyT1pST1k3MWNuM212?= =?utf-8?B?b1dqc212R3RYenBvbGZ1OUxrV3FzM3NobnB4OFB2c2loMXIrM3NIMGhka3hr?= =?utf-8?B?SXRwNHJGeWs2U003eUM5NHpyU0VtaWhOUEc2cCtBSmZrZURPSzVUV3E2alVI?= =?utf-8?B?WHArVFZVUGZjQTVNMENGNGprQm5sc2VrVW1GVDFvVFRYd2lQUk1OZlV0L2lG?= =?utf-8?B?NU5IaUp5V0hYU05MR1pOczdzVTB1cnVvSnBsaG1IRml6UEtsUWhaR2dDMEpo?= =?utf-8?B?bUx3RXZiUGo0dGRhdHloRTF2N0txZ0dDQmNqeDNPRmFWR1JndnNldW9JN1Er?= =?utf-8?B?QXBPR1hROGU3djV3NXdOQkdmSHRTR3FNT0xwdnpsdm42ZVBCVEhPTGNKTitt?= =?utf-8?B?Nkg1UW9HVmJseVNLVVV6TVU5N0wvbkFJWENrelY3RmdSdHQ0SzJXbE9oSU9q?= =?utf-8?B?T2dtZ09BbVlkN2hibWFTY2laaHhLeG1wNGtGVVk2OUh3N0xrckV6QkJubjhv?= =?utf-8?B?Q21pVWFXY1JGWjRmd1NQQlFhTS9XZHJ6SHlWZTRJemp4SVc1UlgyU0l4TWVT?= =?utf-8?B?VXlHd3NCOTU3dHJOK09wa0lsOEQyeXdyTTZWK3d4eGg1USt1UmVLaFNGbk9L?= =?utf-8?B?RlVGWE9qNlU4L2Q3R0owSlM5MDRpQ281VG1HckdaZFNSenFKM2FyMmtzZnkz?= =?utf-8?B?SDVVelJlMWVIbmpMY2tENWNodkc4cW9KQkVEUm8xTVJJTEJIMndyZThHRHBU?= =?utf-8?B?NGxzUnpFUklyZyt3Y25veDJCM1I0c2Z4QWxGT1c5ZzFwVkRyK0c0eXFJUkx1?= =?utf-8?B?bEczQnpRR1lGSGpEMDBFeG9kQXBjMnpQMEpTV0h4aGxJclBpSG05dkZrUW5s?= =?utf-8?B?dGxmcitINWpYQ2VHRzNGT2prYkRSNXpOdGgvbldVYXhyeXJlWHUxZ01UQjFS?= =?utf-8?B?WjhQZWh1eGc5eFB4VU9KbDl4K0VaNDROWmw4cWpoUlRGV3E2cElhcDNJV1RD?= =?utf-8?B?TzJZTGQxVGt4NUd1TTV5dFRsa0VOUVJyZEdVS2pYczJwVGllL3QxaXBpTElT?= =?utf-8?B?dXJzem4zaUVpYnlrOFJpV1BISDczdkZTN2pMZy9ybk1SY0Q3a1NNeUFhQ0Jj?= =?utf-8?B?RWlkWEN1M2gvS0RqV2pMNEp3UEc1L0VqV1VIa3ZhS1V6YW9uVXVObkkxQTJv?= =?utf-8?B?RVhYZmNkaEJzeXl0M1VlRDhaYitFQ2lLQ2lmTitOS1BmUTdXQStnKzdTODBP?= =?utf-8?B?TG43Q1R0MmlTVGpiYVA2T2diSlVoUXlrSEdXbm4zQ0FYRmhYTGZxb1Rmbmt3?= =?utf-8?B?NVdrVnY1bHdzTURTTlpVejh2VUVzMTFYQzZYU1hDVVJ4UDhleUtva3ZKWmN5?= =?utf-8?B?dFBPS1FTcnQxMjMvaUJZd1NPU2tVT0lUNWdWeTZGR2JUMTVqcTlSc2Zod1M5?= =?utf-8?B?b2dOMG12UnhWeXM3T1diaGpCc0xuWVVnL3JzZzloUHAvYjlLMzZacWVoRHA2?= =?utf-8?B?TzFOSDhUT1pURkJzdEZqaWx1c1Rnd1c3VXNTWnFRRkcvVmpldDVXM1hSUzU3?= =?utf-8?B?Z21PbFVLaVZSRThMTUFCbXU5QXpoQVNBUldjMVd5TnN3dlI3N1JtT0JVY0dW?= =?utf-8?B?M3JvemdIUTM2dVBsTDFnOHRocGhuMEd2cm96WHNKNUFwQzlDanBSQU42TWwr?= =?utf-8?B?MCtPU09HTzVRYVhHTTIxZVNGWmp6WXllRHZHUTkrdUlGeGc0TVdiNlBDWWJh?= =?utf-8?B?OTc2eWFnUE1FUkxjZEJvWlg0dlh6TjltYVl2dWV0Uk9EOFN6WnlGTTFvRm5j?= =?utf-8?B?QjMyZEhKa3k4TzdHZmdPbEF2QU5oV2hOaXI4Yk40Wm5vK2tNeXJCSVpHclpK?= =?utf-8?B?bkFHcllsV2RnbjBsNlRqV0x3SlI0SGptQWpMY0czSmkwdWFTRzBTdzZxaEJi?= =?utf-8?B?S1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BVNYOVXGXHruqjxpnJ9B4jrg/pVIcoNKu1Qcd3ABMYcu6p8NoLZ2FKszuES+DTJ68HSSBvByGUphRMK17UpRafZy+jLmQ3yeuVqzNO9nKYGSiOTgx6buu+qJj1sp0bnNQ/fuHqT47UA8VsW+gN2khSJ9I6NdT5ZS/Nro8uWnAV3iaN2RXjm4Ba0jpz6c3D6A8eAWDyU5EdrwLobf5tyaTcTaTXK7wmeo8dEWvJAniAe0pYIZJPUQMb6xZJB1JJvvCWEvuuhlFvRQnrcQPg+vvUH7DD7TsBQf0ia1evkW4zPlJWdbV17AZ86QVpTf7A5w1K9O/uDOxEaKHFGcLzzTlj/eoSkD56y03z///DxHrMnnZNI5+TmL60pIwivKOTd2lP7iY4MYXE5rMvTOMra+62wWOfko2PQan0YH/PBLOmWKIMryYRh4YQ6asjpttuKN3OAsDhuADGbHKul46E5uS70wqJutLNpUWNUJq89esJbhBhL4KyxcuGdU7dVa42NeWLqT7QTMIQE3Y9Jc3m7gBouY5oh/QjhhFoWgDjoMm74eNXwfhoT7nd/P2JqWe8dDRIWbzXs+C+q4kH+YXanCCz2OZtiQRmv77/hPn0YhhUExIcYWkDop3vkblkac9spdiAZY1rb6l9ICm/n08Fq1CxcogEGAksrWniTkjJrd2ssA+46iIfYLqSZCdG2HLvmByQ2KrqcQkGzM5+7bkuxBm2bbVebSUNiG+ErE6KRvCvvucImIx06QA/FQT2vaJ9P3h5GDlrmjR5umm+gp/7PxVAInLS+kOYBTAnpwxLc2JZ7BHeygUPewOVsM6NsopmBtuzIIMUneFpUzKnHb9vKrrQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4a56e95-2b31-4c92-6e40-08db1017247b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 12:12:58.8074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GDDpjXY1AvGXeN5rMI9nx6Tnqse/VNEpojD3t6niEe32lJ5rYwpiCrdsmNMaGGET+2my+XQtWMHqlgHNLDsUEyLvVmPiBxwDivHJl90Dh/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5083 On 09/02/2023 10:42 am, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change oprofile > code (apparently trying to mirror those types) at the same time. Where > sensible actually drop local variables. > > No functional change intended. > > Signed-off-by: Jan Beulich > --- > Much like x86_capability[] already doesn't use a fixed width type, most > if not all of the other fields touched here probably also shouldn't. I > wasn't sure though whether switching might be controversial for some of > them ... x86_capability isn't an inherently 32bit structure.  It's a bitmap, and all of Xen's bitmap operations take unsigned int *. Most other things in this structure don't need to have specific widths IMO, but there is huge quantity of junk here. > --- a/xen/arch/x86/include/asm/processor.h > +++ b/xen/arch/x86/include/asm/processor.h > @@ -119,24 +119,24 @@ struct x86_cpu_id { > }; > > struct cpuinfo_x86 { > - __u8 x86; /* CPU family */ > - __u8 x86_vendor; /* CPU vendor */ > - __u8 x86_model; > - __u8 x86_mask; > + uint8_t x86; /* CPU family */ > + uint8_t x86_vendor; /* CPU vendor */ > + uint8_t x86_model; > + uint8_t x86_mask; These specific names always irritated me.  They should be vendor, family, model, stepping and probably in that order.  The x86 prefix is entirely redundant. > int cpuid_level; /* Maximum supported CPUID level, -1=no CPUID */ There's no such thing a "no CPUID" cpu for Xen any more. > - __u32 extended_cpuid_level; /* Maximum supported CPUID extended level */ > + uint32_t extended_cpuid_level; /* Maximum supported CPUID extended level */ This does need to be this wide, but I really regret the name being this wide... > unsigned int x86_capability[NCAPINTS]; > char x86_vendor_id[16]; > char x86_model_id[64]; These arrays should be 12 and 48 respectively, but the vendor id is redundant with the vendor field. Furthermore, we do some non-trivial string rearranging of the string, and (seeing as you rejected my patch to print it on boot) only ever gets used to hand to dom0 in a machine check. > int x86_cache_size; /* in KB - valid for CPUS which support this call */ > int x86_cache_alignment; /* In bytes */ The only interesting thing I can see about this field is that the Netburst quirk is wrong.  double-pumped IO was a firmware setting because it was a tradeoff and different workloads favoured different settings. > - __u32 x86_max_cores; /* cpuid returned max cores value */ > - __u32 booted_cores; /* number of cores as seen by OS */ > - __u32 x86_num_siblings; /* cpuid logical cpus per chip value */ > - __u32 apicid; > - __u32 phys_proc_id; /* package ID of each logical CPU */ > - __u32 cpu_core_id; /* core ID of each logical CPU*/ > - __u32 compute_unit_id; /* AMD compute unit ID of each logical CPU */ > + uint32_t x86_max_cores; /* cpuid returned max cores value */ > + uint32_t booted_cores; /* number of cores as seen by OS */ > + uint32_t x86_num_siblings; /* cpuid logical cpus per chip value */ > + uint32_t apicid; > + uint32_t phys_proc_id; /* package ID of each logical CPU */ > + uint32_t cpu_core_id; /* core ID of each logical CPU */ > + uint32_t compute_unit_id; /* AMD compute unit ID of each logical CPU */ There's lots of redundancy here, and half of these fields can be derived directly from the 32bit APIC ID. For the purpose of the type cleanup, Acked-by: Andrew Cooper . ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:13:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:13:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496511.767287 (Exim 4.92) (envelope-from ) id 1pSd8r-0006dN-0B; Thu, 16 Feb 2023 12:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496511.767287; Thu, 16 Feb 2023 12:13:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd8q-0006dE-TX; Thu, 16 Feb 2023 12:13:36 +0000 Received: by outflank-mailman (input) for mailman id 496511; Thu, 16 Feb 2023 12:13:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd8p-0006DA-9O for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:13:35 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 542ec3a4-adf3-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 13:13:33 +0100 (CET) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 07:13:30 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6631.namprd03.prod.outlook.com (2603:10b6:a03:388::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Thu, 16 Feb 2023 12:13:28 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 12:13:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 542ec3a4-adf3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676549613; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=EcgJg4ohxsJipzERZ6H6TlFGFN9j1ZxJcbz2J/dJTxk=; b=cdDvNXhoP4jxDdAtmf/mADUXR7UpR19D00Gvj8wFR6tL31zAoAcfYdsv jG2L2n0J50rr84W2Bo+86oA/Bi00aOsDcHwYF3F5HsJHqQBV+IdGjZf0W 0lDGTMo7vy6kJtI5vMayXG8ubp1fOQOzH0sZXiWCPqJbYfBK4AJQ+r5c9 A=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 99715705 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:w3cRzqroOcv9KBbxswHl3stApbNeBmLSZBIvgKrLsJaIsI4StFCzt garIBnUMv2MYmKkKN8iaNux8EoOsJ7WmIBjTFdvrX1gFyga9JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzidNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGkOXxqqgLOw+bemU9ZF3N8EEu/3MZxK7xmMzRmBZRonabbqZvyToPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeeraYWJEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpp6Ez3QLLmwT/DjUWCnf4+9CQmHWXRupvO 0VE3CUx9JItoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hTGvPSkYK0cSaClCShEKi/H4u506hB/LStdlEYa2g8fzFDW2x CqFxAAhg50DgMhN0L+0lW0rmBqpr5nNCwIwuAPeWzv86hsjPdH5IYu19VLc8PBMap6DSUWMt 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz0k5J/Vei8OA1DGXo= IronPort-HdrOrdr: A9a23:cfJqTK0AKavKuSz8QtjRKQqjBa9xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtj4fZquz+8T3WB3B8beYOCGghrTEGgG1+ffKlLbak7DH4JmpM Jdmu1FeabN5DtB/LjHCWuDc+rIqePvmM7IuQ6d9QYUcegDUdAe0+4TMHf+LqQZfnghOXN0Lu v/2iIRzADQBUj/I/7LTkXsGIP41q/2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbfyJTzawk+W 3llRW8wqm4qfm0xjLVymeWtv1t6Zfc4+oGIPbJptkeKz3qhArtTIN9W4eatDRwjPCz5E0smN zspQ5lG8ho8Xvecky8vBOo8Qj91zQF7WPk1Daj8DbeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4vrHzJltXv3vxhUBnvf8YjnRZX4dbQLhNrbYH9EcQNJsbBir15K0uDe ErJsDB4/R9d0+cchnizyJS6e3pek52MgaNQ0AEtMDQ+z9KnEphx09d/8AblmdozuNLd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeE6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSSAtAzWu4NjDqVCy/jBrOKBC1zGdLluqbrvnxwnOLyZZx 7pU6gmRMMKLgPVaPJ0NkPFKt9vwEIlIb4oU+YAKiOzS/3wW/3XX8zgAYDuzenWYH8Zc1K6JE c/dx7OA+gFxnyXexbD8W3ssjXWCwPCwa4= X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="99715705" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWaQ2+XQotgTMaLY1MJYNn5q+41POqLZIUjOlf/yQd+uF0+5cXCwTcFec4goqpVMfpcF41z7btUg55RvwBMjpX/r/rQ14gt8ZcmbxAN64JRiRgakb9jYG17JFjArMkOQeiNgFdaLg1EcLNT010TTuFFtsl9I+7TlL0908cxdbHVoNLg3DdYzOTydHxTJQ17Hj5HKg1U1OWF0OSvUiF5g0lvWdTDfNTBOSPo8JvBZaaY37aqREC1JkiZrMftce9zThXBt8qGna3WWGAvjgYkQuKqwgsckmtLJLOpbhQHkSTmFg+IiU59r9H2dECC5Js6XuPxqiob2306xmz7FRhGPRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EcgJg4ohxsJipzERZ6H6TlFGFN9j1ZxJcbz2J/dJTxk=; b=jDe8skYhrF5zHY9bho9SHyLpYhlhRi9lmXKjkvV3KGTD6QXuNrq/McW6ibeel6EtDdyhwWkUVn5kXmN/xWJ8jO+qIvc4PSlukOO/Abr8MxMo51Xfcvl8xHDW9IYT7a4XFrgHSPFA2AGQSyTkayudkqCetfxVIwqTn+siBLh2yQygdyYaF4eEOIpDvBZIp+cqw3HSqOdH9KvR7qqGbsl6z9Y587HVEBETg0MmiAyrBAvqXMOrUA1dU9UYeiBuEZLucuP8fEjb4u79LSRTvZkqig/w4iMKTBg9Oa0oWNdWQFLOhNic2Gdr5c4XzFAFrx3R5c+06KwTRcBBCpYpjyEfBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EcgJg4ohxsJipzERZ6H6TlFGFN9j1ZxJcbz2J/dJTxk=; b=S3P8LegeMFRtZO8OGdFFTKcpBX0RZFZE/0lMFROPw9Zp01zxWBWTpo5tBo/OPRIDl7qbJy5VxUPbT/IcH0bAvgzsbyK8Lv7JxNOBFWrX2Jh5lTUKBA8GtNLBUWs44K10T3ds3gYSWt+m/4/uS8YDIR4DSfUok0/9Sidw+s9Tcg4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1f822b07-4520-7ba4-859f-a87bce3b247d@citrix.com> Date: Thu, 16 Feb 2023 12:13:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 6/6] common: __u8 is history Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <9e3c6641-1ab8-83ae-724d-a85af8e9ec17@suse.com> In-Reply-To: <9e3c6641-1ab8-83ae-724d-a85af8e9ec17@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0053.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6631:EE_ X-MS-Office365-Filtering-Correlation-Id: fd5cdc2d-452b-45b0-5169-08db101735ac X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 041ciDyeekBkDrQcNUDn3C4VU/lCeHeZAAmzQEMkXv7FCd7xlHpvvhiNihVzbpmVrHTvPcyLUuiVNGs6+2hU65uGiPSlEv5aqnGdRGRJzsLLVU4CZZWmHYL/DBAIRBTA47hD+rOxznDgXDAsPKH7nO+hnXTduUJbNQPXtQUya55fggW6erYujD9pikGt1KiwfzcyCXLmPFFf+76g4kVsl+FObWjV5uqk6H5gcAnuQf3sPKqz3iu8676etCUfi7TUxhTIPZw6l1LmrzpiIKYo1bxeIc6MuDv33p7negEFwvbCX4QQ4fXxpLgegPBR6L9mn2i3LkMUp+4LgXociSRylGnjJuApc8uLRGPhNgBPbR41kQBJl56kb+76rxjnpgBPoi7BEv8Y2cOgEEwt6io5fiUaby7m5oi8LeE8SAnTGAKBLxNtTJuTAxb2DIxE+PXpVbLK5CGFw+n8pf4K7d4D1tPS2JXy7j0pr6bW7l4NHjd0sV/VEDnP3VlfZTfRVc0Fg16uQJu7TG26bvkUTBRd0cnk6uTZS81/wo32c+qHgjRKj1UwqqozL1hiAq3KqNF7bS2IMVSoSX5I4DQJ3AyFAuwtK9QXvvtTYqxpassIGRyBwtq/AJrP6s36YT4YmSW6gIvd03SE49yfoaqSgtTDP2NXYSCPCSuAmOWVcl3VlXusLSjQDTz3RtQRB+ijlipguZ9QQbV8QfD1MYNGpyLmYUczQrDagwyquBbMVBllIfA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199018)(31686004)(6486002)(86362001)(31696002)(36756003)(8676002)(66476007)(66556008)(8936002)(82960400001)(41300700001)(5660300002)(66946007)(38100700002)(4326008)(110136005)(54906003)(316002)(558084003)(478600001)(2616005)(26005)(186003)(53546011)(2906002)(6666004)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXRNYkdJc2ZUMmUyMXpsL2JnR1kvTkxHZElWYi9JOE1jVDAxcjZrdmNJa1Zy?= =?utf-8?B?bE0rRXozQUgyRm51NGwvTXFITG5wMXFpcVFCeGZoWERCSnhKOVZpSVREK0ti?= =?utf-8?B?TkFuY25BZThQeDY0ZjVGT2U1RDFpNVZMZldMTXI2aGpFcCtiZ2F5eWNkU2hO?= =?utf-8?B?YjVnVmY4eDhmb0NDbVhxNUdtL2FkYlFLT21lZElLaDZDQ2UvcmxqMjZkdGdB?= =?utf-8?B?NTE0aUN6NUE3Smx6dDlLbjFEaEhSZUNIbVpQT0JwSW8zc0FaL1dDS0x0RjNo?= =?utf-8?B?QXJRaVNaVUYrNWp6NUp1LzBsd3lsZEtYT2E4Qyt3cjQxeVZUeU5TSGJQTGRF?= =?utf-8?B?MzJrQit6YVNtU3dralRBd3dtWTdONU5rSWFtcFlITDR3Z1cvNXlZWTBaWXRo?= =?utf-8?B?am5qeXJ3T0tQWmF3aWJZK0FuWG1YYWd2bFdVclc3Y3k1aHN5RFVsU2E4TUJV?= =?utf-8?B?VUtZMUlacVFqWElveW1zSldoVVc5ZWtoN0tpUm1FVmJGY3EvTzhGamJiQWtn?= =?utf-8?B?cjRseEVyNWd0Wlp5U0NOYmxON3l6SThwTXcwMkM5TS83Vi9JTVFId0FxbmEz?= =?utf-8?B?VnJpUkt1UzlpMEtnNlJyak43S242M3BTYnVGUU1TbFZacS9sdGNLbCtjZnBJ?= =?utf-8?B?WGRWdXBqK3pZU1lZVFRTRkN2QVF0dTUwOEF1UnlKWkdzdzdGNGR6WG1pbG9y?= =?utf-8?B?R01RZ1dmSktSTVl3dTFPeWZtbGdoQXhlUndLeWR6SjZIVm9Qc0NxOFBmdEF6?= =?utf-8?B?WDNENXNUaVNjbXJLZExEV3NFb25pV096UTY3TFBXMW0xeU5hSGZycVhOcDlX?= =?utf-8?B?dHdvNjFUcEd2Ny85N3ROMTkxWXNzR2lEdWNINVhlQW15c1hpYUR5MTVxMjZz?= =?utf-8?B?NHNwQ2NGSUdkYnUxQzU4aFVxRmNNQWlqVUkvR2VSSVY1Z2FjeEUyWFErMm1w?= =?utf-8?B?dFVad0VESnBESDR3M213ODZNWjFHcXFVU0MrK0Jua0hqQjN2MWpwbmdzb2hp?= =?utf-8?B?MTQ1dU9xUmJMN1dQSTREWHlGbUpmYVFobVJJL2tydU1vK3ZHUWFXSE1FOXAv?= =?utf-8?B?TVVlVTlGZEQrMVRnREtUVWw5U1dHMi96N0tWMTN2ZGdwTFJKazdFK2VnWjdN?= =?utf-8?B?R0dSOHFYeENZZXlETjlnQzZrdFVEb0dxUmhERjBUT3hDcHMyc09tWk9FLzAw?= =?utf-8?B?aFViakRJYVV4UTF6OTVRMmtJbWNIejFQbmh5aDRBckt1VjhPK2ZQVjVnRW5r?= =?utf-8?B?dW9WdU8wZVB5aEE0L2kxZzBSS2VMbmRWMzhGemkvMm1zQ2NxanRFVmxpeEdz?= =?utf-8?B?ZktIV1d0SGlMd0cxTU5jUHZjM1Y2MGltZHhKRllKZURRblcwdDFCL0lsZ2hu?= =?utf-8?B?QWtuSHFLUEZpT2lKQ0xtQ0pTTXJ6SWY3MmxtRHJmNVVVSWtkM0dVb1VxbTkv?= =?utf-8?B?eWdVY01iUlB1bm9ZQzdPSE96bmV2UWE0MFlkUlNyQlYvVkpaK2pXQTgxRzNR?= =?utf-8?B?RE8vWmdWTERFTVdqYWh4NHpHODUvVzlzVnZwSTlnVHJXYnF2ME5EUmFLMjlh?= =?utf-8?B?VVRIQTlBRlZHZzlIKzRmV3pJZkNMZjVuM0p0cm84WnFzQit4WkowcmxuSXdk?= =?utf-8?B?WFZYQnVsUytObG5iNXVUd1c4enQvVWMvekhNNzZnNzBCUkhpSUZYOW5JaE0x?= =?utf-8?B?U21mb08rdFhaTnNWK0QxNGNkQVhneXpHNmlMVkROQitLZW9POW1WVjdQcTJr?= =?utf-8?B?RFZPNm9VY2NRZ3pjc2NKd0M0WkdIRE9OT2hFenZhVUxmZXdQWTBHdnNXT3lH?= =?utf-8?B?UjNRVUZVbXZZTTU1SUtETkxyakU1Y0VZYjZUbjZQeFliOFIzM3VLTDgwWXBt?= =?utf-8?B?NUpmcFZjZnFFczNzSDlObzNJWWk2cXVtcHRYMHB0K1FIamRhTllNOGxlYTZX?= =?utf-8?B?Z3lIUW9wU0ltTS9LU1Z2Y0JHV2tReU1tdDFudTRxckxTQmRNN2lqd2g3b2Iy?= =?utf-8?B?azNML3NqV1FHSUc4b05yQzIrbnVhZm5keU9xaDJDQm9NYWVDZ1N6SGZEVWg1?= =?utf-8?B?S2ZnVEdvYnVYQ1RvYnFmZGl3d3hLeG9ZYmRPbjNkNnM5c0VyQ3dzWWVNTDhJ?= =?utf-8?B?TisySWFtTHRKdUkyMHU1UTVEZ09uZWpRNGVUaTJxQ3BlenhkM09jWC9YWHlp?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YKiHPtovBv8+/NqX4SLcCuDo9+hk9cA0h0MYVRL/aj620PLLBc31F8hHX7EsYVrm3qIjS9M+yJTS4ycow6LhWigbTFs2DOUtmRNVC5DiefsKsy0MrkCTiDb/1oVH7E1/pE+zPySHXx5oYdMapOx0XHeIN+jejVTerao0LiPsvIaohrHMDUbMNW6Ff0i6w3r3M4RvvI+PpnJWUX289FQ6Kh/prl5+cWjcPiSIWtAiMOtrGQY6wKGYmbqcY1XJjMHy0Dh8Koo2m7C5CB+bS2l/cP8GFQfs2gcYouU4ywMtFWEemrNuOAC/YXmHbLxXRyZRFgx1NyKv+/KdiSUFX4+da8BeojQ2pffoUnZzGlnO6hLychmKyc37b7cWjrhBVk6JOeevEZ0WpQPu5k9wHC0O+lMz1ce7IlcCicP1KcDg3gDgg3sYjH7JxZfcG0MUIDGNkcgtwJU63/0P+c8PlGqznwqT0jNH2E3RumYrjRsXTUf88L/eTSettsIwqnqsidaQCoF/6a7ZFiEeF4KyvCFkhkLvrTmcAO7fMLIaZ0SW/Lwz1+8PeesRv7q3zzeBE9mIydhn913d6dqLotfpFz5zE6v5DUQvgxkHF/z+gw2AgZe9dAmXhEwUYPAZNe2chsZ7FFvgUFf6aYF/XChCwEsZxcCDtAaTgLqDp8lFMF6AbALt+pL4E1za/d7xVR9RR3L0mhx3gwofwkqS7+yT43psUcnmVaDxedJ1B6e/0/LXFb6yeYmspPn87fP7IoIrTfmm9wLYTuH0ozac36XFsJgpdV/gTMw3oSQTQKc7prCLn6hhWTAPJX6MNqx3hTMtkSMFKPfqz8PV9xglP40BOr+hZsVrYM32Je1+jbY1SPxiCFE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd5cdc2d-452b-45b0-5169-08db101735ac X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 12:13:27.9303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LQ2qHzeuxsoV3pw0DAq/6ai+O2FlCxeM/UjRarH3aap1glXr+qkv7dSxFdueb/A2soZGWy89xcGJZWhjf0+hGpYvvqCYJMuJuvTQHvgelbQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6631 On 09/02/2023 10:43 am, Jan Beulich wrote: > With the last uses gone, move the type to linux-compat.h. > > No functional change intended. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:15:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:15:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496519.767298 (Exim 4.92) (envelope-from ) id 1pSd9z-0007NS-GB; Thu, 16 Feb 2023 12:14:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496519.767298; Thu, 16 Feb 2023 12:14:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd9z-0007NL-DM; Thu, 16 Feb 2023 12:14:47 +0000 Received: by outflank-mailman (input) for mailman id 496519; Thu, 16 Feb 2023 12:14:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd9x-0007N5-HY; Thu, 16 Feb 2023 12:14:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd9x-0002DQ-Fo; Thu, 16 Feb 2023 12:14:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSd9x-0002mK-2I; Thu, 16 Feb 2023 12:14:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSd9x-0002Ge-1u; Thu, 16 Feb 2023 12:14:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ShC3gDiIfUsLaDa/FNttdwBAkUrH4O8yBxflAIM+PKA=; b=0odltROJ02rHsuEPT1lLHneuyQ Ls+UDg7nVNOWWtwXsavqMUmOzg/I7+rWHf5/5VzT7fZ0UePx03WKeIxWRfpTaWLVBgoyaIxPARJej arj9D3fXlQazod/ifwIyR/HUeUepWXA+TAjHWa1bjw4ROU5bahMqygaxNH9HkCcsB3lI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177483: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2e52dcc853a7183784cd9bdfb1e78ff366035209 X-Osstest-Versions-That: xen=91c45cfbab5d9878c0a7021f762988a688d5e91d From: osstest service owner Date: Thu, 16 Feb 2023 12:14:45 +0000 flight 177483 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177483/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 2e52dcc853a7183784cd9bdfb1e78ff366035209 baseline version: xen 91c45cfbab5d9878c0a7021f762988a688d5e91d Last test of basis 177433 2023-02-15 23:00:26 Z 0 days Testing same since 177483 2023-02-16 10:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 91c45cfbab..2e52dcc853 2e52dcc853a7183784cd9bdfb1e78ff366035209 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:20:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:20:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496527.767308 (Exim 4.92) (envelope-from ) id 1pSdFH-0000hf-4F; Thu, 16 Feb 2023 12:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496527.767308; Thu, 16 Feb 2023 12:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdFH-0000hY-1C; Thu, 16 Feb 2023 12:20:15 +0000 Received: by outflank-mailman (input) for mailman id 496527; Thu, 16 Feb 2023 12:20:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdFF-0000gg-LP for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:20:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41a9423c-adf4-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 13:20:11 +0100 (CET) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 07:20:00 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6631.namprd03.prod.outlook.com (2603:10b6:a03:388::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Thu, 16 Feb 2023 12:19:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 12:19:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41a9423c-adf4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676550011; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=hYtL4K5tER5uSOo4YgzLbAjvFm8f2+ZgpAXv4CgdhPU=; b=iMTFwbieV5iaL4jm0aoJWUWXD7KDuUxcnRmR2vBEKCaW6ZWm+rTTMSV/ 26GWYc1/lRTtdm9TV7qUR7kJL4+ZVoP9+evy/FJ9HxKs+jLi6OKWz1BMo fi1+isL2Z3FK5qXp7wEjZFmvfuu76vWD4Os0B5oAF2v3eD/81koe+xkQc k=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 97298405 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:q7i3V6igVTMhEyGbXnPtWUGUX161iREKZh0ujC45NGQN5FlHY01je htvWWCFaaqLYjD0co0lb4jkoE0C7ZfVyoRiTgNupCk8Hi0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaAzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQZEDxTYjqH2N6TzZvnQflhnONyDML0adZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1a7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReLip6422AD7Kmo7JwwPaleyh8aFqkOUYt0FB 3wk9icPhP1nnKCsZpynN/Gim1aDuhMfQNtRVe4n8gaGyqnTywmcD2kACDVGbbQOtsU7WDgr3 V+hhM7yCHpkt7j9YXCA8raZqxuiNC5TKnUNDQcfVhcM6dTnpIA1jzrMQ8xlHarzicf6cRnvx xiaoS54gK8c5eYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPA1LTAxfNJLYLcRF/eu nEBwpCa9LpXVcrLkzGRSuIQGr3v/+yCLDDXnV9oGd8m6iip/HmgO4tX5VmSOXtUDyrNQhexC Ge7hO+bzMUKVJd2Rcebu76MNvk= IronPort-HdrOrdr: A9a23:gtnofqrt4wXnCY4NncRoCqgaV5s2LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwOE80hqQFhrX5Wo3SITUO2VHYVr2KiLGP/9SOIVycygcw79 YET0E6MqyKMbEYt7eF3ODbKbYdKbC8mcjH5Ns2jU0dNT2CA5sQkDuRYTzrdnGeKjM2Y6bRWK DshPau8FGbCAgqh4mAdzE4t6+pnay4qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFx9f3Ls49m DBsgrhooGuqeuyxBPw33Laq80+oqqs9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbknyPgzDEtwXn/zkLwuwqvneXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o4GgbWAhqmOE5V4Z1cIDhX1WVoUTLJdXsIwk5UtQVLMNBjjz5owLGP RnSOvc+PFVW1WHaG2xhBgl/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgPcSm38RnahNPKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBGB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT9Yd3U8LAd23FFgMy4eFKyWhfzDGzG0vHQ7cn3O/erGM paY/ltcrjexWiHI/c84+SxYegVFZAkarxnhj8KYSP+niv1EPybigX6SoekGFO/K0dsZkrPRl 0+YRPUGOJsqmiWZ16QummlZ5qqQD2xwa5N X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97298405" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LmHdjPfMJVunWS+FgFJlOIyF1zcv61h289kQ3ljWM6cTSrmSQX2MzKRgmslIyIUE8lnQ1SN1JoLWE5VPB4XTsymU+fXYcblel2FatXf1Ge0DNEXTe3jwcN+OROFXShqPkPjYA5fUyN9qVXbf+sCAVxuD2PVSbrPTXfVta4g4b0N1m0j3WwgLkwwsizLSiAa+NQd8lfBq1ql5iUk42oSVz7fVIH+oAJ5InZ4XfV/IFpATE5kMAywsKHBhHmRdz97RWQLlU12asIUPXGA2YZii6t+c7QpS5ZoKf69egjpumd+ZvWkMyZoOdQrHifEwABy4GoG8F17KEkiib/sYh6fr5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hgAmLBkoc20PeqCsSaEZQhbpKrbVF7tlsH6wabjW/jc=; b=Mag/tEL3Pgfo102CV9PbjOCpcuyHeBoY3dSrf+GpBRaHRsYCivAUOFz7zCfvQcaiEDTxcmrUnBdok6i6U/k1jBJrNWoBmE0OmT1cB5wQfCKbo7t5gXJSbKhv5/T8xWyTASNVtNn2BCuJYAyB3+1JiJmru0TZ9oQdlI/R1srvAI9+u1Vd5q5oK7tNJ/YuQU5mcbENqSUwKjmKA4DQJdkAEWVDrWMlIYCPh7h8UIjmDpumfM6vW3KfnoTlxVuLlTwcP3QRx8PyijtBoD22BLL+MOFbrKtyJLjjLBLd3CJMEUtIHMjshsKDBQ2TFPH7IXTgJuUCTdQDuCE+xbqbrDemQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hgAmLBkoc20PeqCsSaEZQhbpKrbVF7tlsH6wabjW/jc=; b=Ws9IweX73qP1FyN47CtruUVqCxfGqA8Dd/5xzJWY/9G4YqHGRBpIgR94Uyw0U2diOeB/BgyTMA0uksjgo5iQZLc3eZ8+Y7+xM+ndsFMT/Jl3RI7Mt1Rn2BzSBBLHXSIfAGhO5UsskxzC4/DQrQQUDHlg+d7ImvpCcyY4eB70k0s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <4c52d703-dd7c-b316-5e37-38c9aa705725@citrix.com> Date: Thu, 16 Feb 2023 12:19:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-GB To: Oleksii , Jan Beulich Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> In-Reply-To: <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0374.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6631:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f41c02e-4039-4613-7b2f-08db10181e4a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7vm8PSUYPfqvpGRN2gB/c6sURKuPptPENBmMgopka8J8CN08Yi/niOTa+IaaQXIbCjwO+6cuwqA/kLpnqGHCILSBDe4H5YKTyKH2WE3bODqbSAa4nnPgfp6qzYSWC7iGwGE4t8FZha4MsgsKWvzc9iJOwuT/sTtnF3HX2Bw8au5hW3eV89IAA3uwGbAdcNOXryp2Vu3WfAcM62VQyT+M6KzOBXpfH5PEYJbZ7Wjuqarn0yQjhbGENubeH0HG9Ewe6QipIqK4IGCqKvAnqd8q7eDdC7jVhSpjDbNkwdUgkyWoedIQPcSNsHMetQiehvy3x+OPkESJcHw3fW3vMi7vMxVqfeQxU89j+7Mwx9cuiZzR5/Rj55Ryr0MWXMghyHsTfTp26L1JgwiqvowJJvq+vPdSeempFilQdo02c4uzpF2vF4ERU/5EXtEBFNmiqb4FXAa75D6MmUNp5QpYdWVIE9qM7crX1uiog6QhhDh1mQ2IAGhjBW3WrlKp9cuI3nUW7ncdUOCbKAujez6Tw7TpRitm0gdLNcZdN/a1MX74ZtQO5I7l5IVyxXTQo9+LZ7QxTRVTqEsiPSY8DLLtoqO2Cj6TedXdVHcGoDeyrVvDG0JjIBwW2gAaoH8wDBnoQiGZNrDM+kPvRhK+doRFkilvpJH4isVb2GmIIze2/PrwFk4u/KKL4DJgoyJL9Cq6iNVrBmDwQW6zfenX/S2GH+gy9LVO4wevElnmaAzZCcF1AtNMs1TFua/Yl/sTgyO4VUcL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199018)(54906003)(316002)(186003)(53546011)(2906002)(26005)(6512007)(6506007)(6666004)(478600001)(2616005)(110136005)(8676002)(31686004)(31696002)(36756003)(6486002)(86362001)(66946007)(38100700002)(4326008)(8936002)(82960400001)(66476007)(66556008)(41300700001)(5660300002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmZMUUkyS29naXNRVDhpUWlaajVNZXdJeE9mR0lNQmdUQzlDSEFQRWRTOUhB?= =?utf-8?B?bmJxZTg4N1BVQU1JbDNNSnU1TVZIbnBaZnI2NkltTE8wcW1KY2hxSHp6WCtu?= =?utf-8?B?dnN4Ry9FOEVQUjJLZ3VBd1FseGFUUExmR2lBTzIwNlRKbTJvMG5xVnJJQ3ov?= =?utf-8?B?QzhEWWd3ZERSb05FZ0JVbnV0c094ZXNpSzZLY0VDRFFLZ3haTnY0ZlJ5TmVD?= =?utf-8?B?cHpWZjlPc0pMVndBYVg3TTVzaE9BQkNJbXh0aDg0WXRnNk4vS2ZpNTdSeENE?= =?utf-8?B?RnpPcno3SW5CZkRQUWxSd2d4WWp6Szc0ME9TRm8xclVnL3VJNllkekRGWnBR?= =?utf-8?B?TWNvY0RkL3dNZW9zenlhMC9vTk5sMElPZlNDZ3NqVHdlN0FPRWxrQ24rMEgr?= =?utf-8?B?SlRldkhncFhMc3VDSXIvSUQ1ZGp5VGdBSUU2YnF5a0I2UzZsb2d3V0VMVmZt?= =?utf-8?B?d2Zua011NE0zdHVvU2YxU0VYTm5wM0JIYnl3anFiMVlpMllIQndNU1pRUjZi?= =?utf-8?B?Y0toQ1N0c2JZTVZUOHpPQ2pvM1pQRWpiR2dUUDdzTkV4WXVxTVJHV2UrOVRU?= =?utf-8?B?V2E4L2loVVRhanRuREIwUXRXdDNnOHdZdm45a2hhb1AvRWNSTmJQOURybzFI?= =?utf-8?B?OEU4RlE1ckwwZlFOZjZISHRrbFZSZDVVUjk2Q3lyM21GRUswWEM2anVxdFhD?= =?utf-8?B?UEpLNFROQ0ovcy8xaGF6T0t4Ry80RFN6UzVyejlVOEJxSnNNeDFWd1h2UFAz?= =?utf-8?B?NVltdVdycDRYUEN6UVJkL2ZpRGlhRTQ4L3NpTzlFT1BTMDRFWGNuZXV1b1k5?= =?utf-8?B?NEZid2pWT3NaeXc0OGpHTU9WQkwxNlZnQTZGR09HNXZtZjJyZUZiaCtuWWcy?= =?utf-8?B?dGIzQVRiN2lhTVNhUkdHekNzb1dUUFh5aGJUYWo1RjFzOUM0VzBxRnJtL0ts?= =?utf-8?B?eGxGcnQ0c3ZZbC93amJ6a2tkeE1LWUZsLy9jVFhGbW5LeU5PRnh3ZEhPV0NP?= =?utf-8?B?TlFVT3EyNkY2bjBuVnk5KzZYWXQweExyYWR0VVFyQnl1d0huK0xTMGhVcnFh?= =?utf-8?B?eG1iNmJJWmRzZGpSeEhmMUJ0ZHp3bmhXc0RVMnRPVDVDeHdlcXRoS0gxd0ow?= =?utf-8?B?eGhmd2xpU21iKzRNMTNBNEtYQVJRc2EyU3N3QmVpMFpoamNnQU5mdTJRQkRp?= =?utf-8?B?UWZJNm93Y3hpY0RsZFhoakpwNVR1dUhFUGo5ckVJaS91SEczMTNVZDNXT1Qz?= =?utf-8?B?R2JnakNUSWJtWlpWeG84a0V2ZVdHTlpxbWdCZnA2RFYxVEVQRWJ2cENTOWxB?= =?utf-8?B?Z0pvUGNmOG5UbG0vY0x2QXdaMThPMWZJcG9FYTJ0TGZQY0dnWXVOdVRLbWVa?= =?utf-8?B?VDlaVmZma3RQaHlDZUdnUXRCZ21OMTdaWXAxV21zd1lsUVA1OW5ieGh0SXVw?= =?utf-8?B?NHlVbkg2azVBc1Jnck1DNVlvN3VXMUpSSk9oTUZMN3hMQi8vWTJuMnhKdXhY?= =?utf-8?B?Q296NjdRcGRQWWtKeWl4VGFYWXJIOGUxQWVFaUpnT0cyRVBwbUROTkhBb05r?= =?utf-8?B?ZUE1R3hwNlpCei9HZklNbWJrU2hIekNSdXhieHhtUVpOZTV3V1Q1Wmx2RGJW?= =?utf-8?B?QkxsSFFIYmhILzlnWWc4aGk5V01RcEFhTm0ydm41RVRnRnJkUWEyV1ROVzd6?= =?utf-8?B?RFNtRi9qN3dkS1NyeVFsaWRHNVBwa0duNmV5L2plQkRFazQyQjJ4QzYxdkxC?= =?utf-8?B?OUdHUnRjelVtWlhEUCtpMzdUazY4WTlUcUlxbnZ2cjB4QVRUL1RzQjdXQ2w3?= =?utf-8?B?dFMxeHBmTEN5TlppdHRRVkJVNUpCTE9TM3pPQ25BS3J6S0NDUmkvdW9Xb0ho?= =?utf-8?B?UzZMTHdOQkdtaVQ2WUcxQVoxVXRFVHBydDg2eTAwRXhiNUV4V2Y1V1RDNkZw?= =?utf-8?B?cnZyeGtvTjlkb2N3TDNYK2RGcWRIZXIzbjBaNmtpTmRFSnFRVnNtcGhNc0w4?= =?utf-8?B?dDVVTEFrV3drdS9MY0lLK09JRTZmNUgvTStzbmoxN1JPeUhRTzB4SXQ5VXNp?= =?utf-8?B?amg1YytOM2pxUlhlbG56SWpHdU56UjI4dk1LMUI3a0IxNFpSdFNJSkU3S2sz?= =?utf-8?B?TzNaMDEwekhPak9BdjFucTF0Q1hINGZTVjNaSDlOL28wN0ordXErYmQweUNW?= =?utf-8?B?UUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UIv0XCcaQQK22d4z4vsJ8M7FvUIDCi3EmwVRMEtBcmOtU8rerZ9XuixOJtnMFYp5V01e6a6P4uXXHhEo8L6FhqNMgf7NUdYKI3+YCTCMvkxg8zVsQRyo8K95YrFuQJhvIq68uKQ7Pz2O0iAjwsR1ejQD4GlLGOwLAdkYkRDJpJlOv+x+7AkJoGr6GCemUJ2io/bjfIl8A9uHxZlxWVrIdEDpISewaVANy7eQoJKHqWkZFcsNAAuWDu6Rj5q4inqaBw7ckouWAwilFyDeDgWpKjN4xJr0PdpR8a/QBEf3xdG5iqSE5HxMfa9wfbRus3gHxOCe9ZACeebm+K9YBdfXj947bkBsJPk/+OrwIRqGr6AUPbq0XVB15EkYzlV/JNQpB+PBDnFFo6eHEosyoaTsgHc4Lwd8XnO36Zg9tjeZu4WsFbJF2Mg+NM+H4N4oqCo/iBiZfVt9MgQ3G7+dZT1exc+hdSbp3dq0Q5GNcugAjlhfDnB0YwDeRQCaQ78S0HHZAnRz3BEsVtsOeOyFNCTcZZdOgGgPwvTMX4pbVpp6UW7pGsy7ndXI3v8LjntHfwM1tdmZqgsX5SNHuCMNZuNq/ExaeVsC3t4Q9pFwpVjvFF8BLYiN0hehZUhdgm/LHrV2ZucEm/83p5ufOV+nHsliwK6ApT1gxWglFCfZfgNKqXgaAfQba0zH4X4Oyi4GCArnezIsIISmnZjSpMHwO+dpnha5JA9IgEjOwE1rS6TlnYSMA95njZ8pgeeAAgCO++ytsl3NP5HBAqC8H6sMzaSvuFvgBfp/xrgxPkT5wTQNeCsHblxKTWldRcMFBV66LczB4Yi2WbJkkc4YEwBQH29yiiXDjeQIi1ZlRZuo+NWDgvpNnfv8si2LdBNEb0IIDRsF X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f41c02e-4039-4613-7b2f-08db10181e4a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 12:19:58.0576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mOb92SIwvYc1F7tEqc6B3YtWqEPd13dZG5jBN4mvW5lcochlalNwvsjlMeWSFtY8FDi6CzlndHA7/7MJz5Qrl6Kj5xCpPOnOgg4VnkqtoWM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6631 On 16/02/2023 12:09 pm, Oleksii wrote: > On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: >> On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: >>> On 15.02.2023 18:59, Oleksii wrote: >>>> Hello Jan and community, >>>> >>>> I experimented and switched RISC-V to x86 implementation. All >>>> that >>>> I >>>> changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. >>>> Other >>>> things are the same as for x86. >>>> >>>> For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT >>>> will >>>> look like: >>>> >>>> #define _ASM_BUGFRAME_TEXT(second_frame) \ >>>>     ".Lbug%=: ebreak\n"   >>>>     ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" >>>>     ".p2align 2\n" >>>>     ".Lfrm%=:\n" >>>>     ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n" >>>>     ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n" >>>>     ".if " #second_frame "\n" >>>>     ".long 0, %[bf_msg] - .Lfrm%=\n" >>>>     ".endif\n" >>>>     ".popsection\n" >>> I expect this could be further abstracted such that only the actual >>> instruction is arch-specific. >> Generally, the only thing that can't be abstracted ( as you mentioned >> is an instruction ). >> >> So we can make additional defines: >>   1. #define MODIFIER "" or "c" (depends on architecture) and use it >>   >> the following way: >>    ".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", >> @progbits\n" >>    ... >>   2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in the >> following way: >>    ".Lbug%=: "BUG_ISNTR"\n" >>    ... >> Except for these defines which should be specified for each >> architecture >> all other code will be the same for all architectures. >> >> But as I understand with modifier 'c' can be issues that not all >> compilers support but for ARM and  x86 before immediate is present >> punctuation # or $ which are removed by modifier 'c'. And I am >> wondering what other ways to remove punctuation before immediate >> exist. >> >> Do you think we should consider that as an issue? >> >>>> The only thing I am worried about is: >>>> >>>> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >>>>   [bf_type] "i" (type), ... >>>> because as I understand it can be an issue with 'i' modifier in >>>> case of >>>> PIE. I am not sure that Xen enables PIE somewhere but still... >>>> If it is not an issue then we can use x86 implementation as a >>>> generic >>>> one. >>> "i" is not generally an issue with PIE, it only is when the value >>> is >>> the >>> address of a symbol. Here "type" is a constant in all cases. (Or >>> else >>> how would you express an immediate operand of an instruction in an >>> asm()?) >> Hmm. I don't know other ways to express an immediate operand except >> 'i'. >> >> It looks like type, line, msg are always 'constants'  >> ( >> they possibly can be passed without 'i' and used directly inside >> asm(): >>    ... >>    ".pushsection .bug_frames." __stringify(type) ", \"a\", >> %progbits\n"\ >>    ... >> ) but the issue will be with 'ptr' for which we have to use 'i'. >> >> And I am not sure about all 'constants'. For example, I think that it >> can be an issue with 'line' = '((line & ((1 << BUG_LINE_LO_WIDTH) - >> 1)) >> << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). >> > I think we can avoid 'i' by using 'r' + some kind of mov instruction to > write a register value to memory. The code below is pseudo-code: > #define _ASM_BUGFRAME_TEXT(second_frame) >  ... > "loc_disp:\n" > " .long 0x0" > "mov [loc_disp], some_register" > ... > And the we have to define mov for each architecture. No, you really cannot.  This is the asm equivalent of writing something like this: static struct bugframe __section(.bug_frames.1) foo = {     .loc = insn - &foo + LINE_LO,     .msg = "bug string" - &foo + LINE_HI, }; It is a data structure, not executable code. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:21:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496533.767320 (Exim 4.92) (envelope-from ) id 1pSdGJ-0001Eu-Ce; Thu, 16 Feb 2023 12:21:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496533.767320; Thu, 16 Feb 2023 12:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdGJ-0001En-9w; Thu, 16 Feb 2023 12:21:19 +0000 Received: by outflank-mailman (input) for mailman id 496533; Thu, 16 Feb 2023 12:21:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdGH-0000gg-8H for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:21:17 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6927fd43-adf4-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 13:21:16 +0100 (CET) Received: by mail-ej1-x62b.google.com with SMTP id dr8so4613299ejc.12 for ; Thu, 16 Feb 2023 04:21:16 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id v26-20020a1709060b5a00b008b1787ce722sm108280ejg.152.2023.02.16.04.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 04:21:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6927fd43-adf4-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=qQ+N3XSh7XdbndtvKyxOAdYibvxb9PAQGUDOIH38+Fg=; b=PKfpwFFgQ9lmq+q0cdO94lgia+EVD+hGSdVWZIbCUlZ8uHMQkWANjEE/mQgQkit0Of Bw8G1Vwjlu9ZkXZ1dGLqhqJBh5zRKGZmD+wsUy2xuhzSXG8g6UEvOh5ioPb3Vs+L8DzH PLS31Ckkxw5ztHqeI6z0HrxUZ+rNSRSQ6XGpRV7mX+KMPx46Yhqh//lqNT9PkwzSdELk rEznts53Hkohkk9WMHL1a9+kibbMhP5UHo0xuPYKdHF8DVTLmODXk86dSIMjVi3XdDrw rHxoysFF/ai++1pUCBMXpXu9rYhotoOUYrRGead995uZ7ILV3qma1cqY+r3zgYwM77id FsRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qQ+N3XSh7XdbndtvKyxOAdYibvxb9PAQGUDOIH38+Fg=; b=Fm13QXWOykKxMxle7vV3XWnzLvgrOoC9WZwNdMkmmMhJBzoWxgTgUdFW5bF7cXaVZA jKuAGy3p3AUXNLqdQ4AMw0V7Aib3D5WZmYb99NpaSDsnSckfk78ghP1JAeDSxYJExoNS epbsOX/3DIMKpjiWpA6x5zP9QpQLvNrVOa4jSpKvD3ZdrCuejCOu1w39mNjbwYZzsrvK Ltok5v7rimAXCmpkwHIc7la/gx/nmge9vyRmKQ8IkFR8kymQ59Adj+UGar+9Yg+1WJVZ v53+CzFLq0PtAQ2/nb+rYzz+IKcf07m8gIved2zV3LcQr0C60MaXUFnFA944jUMnw+1B 9q6w== X-Gm-Message-State: AO0yUKUV8TmYHYiefKsf7Z2z1M2svMNA5bW6vld3z4x3aBZz5u7WmQPu aXpEJjBxJOebKacpcmhXOCU= X-Google-Smtp-Source: AK7set/reMxc2x6GBmXO1ZFaJyEMO7ZkMvvaH2/xgOX99VKEqph87auk4/8sq1yGreDsZXQS9x9JYA== X-Received: by 2002:a17:906:c2cf:b0:8b1:fc:b1b0 with SMTP id ch15-20020a170906c2cf00b008b100fcb1b0mr5361970ejb.44.1676550076328; Thu, 16 Feb 2023 04:21:16 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Andrew Cooper , Jan Beulich Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Thu, 16 Feb 2023 14:21:14 +0200 In-Reply-To: <068340c3-2a2f-4bd0-20e9-f1dd6fe4bc2b@citrix.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <068340c3-2a2f-4bd0-20e9-f1dd6fe4bc2b@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Thu, 2023-02-16 at 10:48 +0000, Andrew Cooper wrote: > On 16/02/2023 7:31 am, Jan Beulich wrote: > > On 15.02.2023 18:59, Oleksii wrote: > > > Hello Jan and community, > > >=20 > > > I experimented and switched RISC-V to x86 implementation. All > > > that I > > > changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. > > > Other > > > things are the same as for x86. > > >=20 > > > For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT > > > will > > > look like: > > >=20 > > > #define _ASM_BUGFRAME_TEXT(second_frame) \ > > > =C2=A0=C2=A0=C2=A0 ".Lbug%=3D: ebreak\n"=C2=A0=C2=A0=20 > > > =C2=A0=C2=A0=C2=A0 ".pushsection .bug_frames.%[bf_type], \"a\", @prog= bits\n" > > > =C2=A0=C2=A0=C2=A0 ".p2align 2\n" > > > =C2=A0=C2=A0=C2=A0 ".Lfrm%=3D:\n" > > > =C2=A0=C2=A0=C2=A0 ".long (.Lbug%=3D - .Lfrm%=3D) + %[bf_line_hi]\n" > > > =C2=A0=C2=A0=C2=A0 ".long (%[bf_ptr] - .Lfrm%=3D) + %[bf_line_lo]\n" > > > =C2=A0=C2=A0=C2=A0 ".if " #second_frame "\n" > > > =C2=A0=C2=A0=C2=A0 ".long 0, %[bf_msg] - .Lfrm%=3D\n" > > > =C2=A0=C2=A0=C2=A0 ".endif\n" > > > =C2=A0=C2=A0=C2=A0 ".popsection\n" > > I expect this could be further abstracted such that only the actual > > instruction is arch-specific. > >=20 > > > The only thing I am worried about is: > > >=20 > > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > > > =C2=A0 [bf_type] "i" (type), ... > > > because as I understand it can be an issue with 'i' modifier in > > > case of > > > PIE. I am not sure that Xen enables PIE somewhere but still... > > > If it is not an issue then we can use x86 implementation as a > > > generic > > > one. > > "i" is not generally an issue with PIE, it only is when the value > > is the > > address of a symbol. Here "type" is a constant in all cases. (Or > > else > > how would you express an immediate operand of an instruction in an > > asm()?) >=20 > At a guess, the problem isn't type.=C2=A0 It's the line number, which end= s > up > in a relocation. Sure. I missed that. >=20 > That said, I'm not sure an architecture could reasonably function > without a generic 4-byte PC-relative relocation... >=20 > ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 12:23:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 12:23:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496540.767331 (Exim 4.92) (envelope-from ) id 1pSdI9-0001uI-PA; Thu, 16 Feb 2023 12:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496540.767331; Thu, 16 Feb 2023 12:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdI9-0001uB-MS; Thu, 16 Feb 2023 12:23:13 +0000 Received: by outflank-mailman (input) for mailman id 496540; Thu, 16 Feb 2023 12:23:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSdI8-0001u3-PJ for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 12:23:12 +0000 Received: from rs227.mailgun.us (rs227.mailgun.us [209.61.151.227]) by se1-gles-sth1.inumbo.com (Halon) with UTF8SMTPS id acf0f5fd-adf4-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 13:23:11 +0100 (CET) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by acd012ecd2cd with SMTP id 63ee202cb561427b110a86d6 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 16 Feb 2023 12:23:08 GMT Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-52ee632329dso22164227b3.6 for ; Thu, 16 Feb 2023 04:23:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: acf0f5fd-adf4-11ed-933c-83870f6b2ba8 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676550189; x=1676557389; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=JkPN7yyeI8i3SiX0ZEYMPz/TaBdo9LUgHo8oQhyfgz0=; b=aqAxCfDWYozfbD2e9Y+HI0yP8FRFzPqxA1WDHzeTa6fAZlVgDOn89nKcUkXPPTW3SDAGRFWVAHwt0bYQ7EGbeezPB8bdUobSdB8uG/pKHJCS+H8pgKwtt4UeomHptfwC3HGSNPPKquVi61oHj8BL901z8RSLdDYfdBeIwlTa30znJhucMgRLxoS98XlD+zgLhLHhF2LzItXF5KbhnxsKfkzST5229p8t1hAZe5V06m+c3LidiYARjbILyqWADZlcIbFSBFvBqboDIq0xLJdcJrZgyuxVMm/NPRRkrU0pI1EnrseaqketqL8aNH+XF4TZXLK3QtS5TIIusbL7Bi4FRA== X-Mailgun-Sending-Ip: 209.61.151.227 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKWfsD14qk+gtWlsuMecKDTobjd3EEAMb6g3pwZQzHYWvW/Sy6LO jN7fyL9Q9ukT1JLlWoPy+aDEA+oQwz5u6UoZ+hU= X-Google-Smtp-Source: AK7set/w0U1+3FzacuxJcSoZlJAgm3ntM/UR6VDvV1lWGeFbnXsWv5zMqTn3tNnrrOgbVJjZqbK3sXRzzujSK2IezpE= X-Received: by 2002:a81:4f0b:0:b0:509:bd6:4d4b with SMTP id d11-20020a814f0b000000b005090bd64d4bmr547388ywb.282.1676550188368; Thu, 16 Feb 2023 04:23:08 -0800 (PST) MIME-Version: 1.0 References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> In-Reply-To: <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> From: Tamas K Lengyel Date: Thu, 16 Feb 2023 07:22:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000006d0a0905f4d04210" --0000000000006d0a0905f4d04210 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > > On 15.02.2023 17:29, Tamas K Lengyel wrote: > > On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > >> Did you consider the alternative of adjusting the ASSERT() in question > >> instead? It could reasonably become > >> > >> #ifdef CONFIG_MEM_SHARING > >> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || > > !atomic_read(&d->shr_pages)); > >> #endif > >> > >> now, I think. That would be less intrusive a change (helpful for > >> backporting), but there may be other (so far unnamed) benefits of pulling > >> ahead the shared memory teardown. > > > > I have a hard time understanding this proposed ASSERT. > > It accounts for the various ways p2m_teardown() can (now) be called, > limiting the actual check for no remaining shared pages to the last > of all these invocations (on the host p2m with remove_root=true). > > Maybe > > /* Limit the check to the final invocation. */ > if ( p2m_is_hostp2m(p2m) && remove_root ) > ASSERT(!atomic_read(&d->shr_pages)); > > would make this easier to follow? Another option might be to move > the assertion to paging_final_teardown(), ahead of that specific call > to p2m_teardown(). AFAICT d->shr_pages would still be more then 0 when this is called before sharing is torn down so the rearrangement is necessary even if we do this assert only on the final invocation. I did a printk in place of this assert without the rearrangement and afaict it was always != 0. Tamas --0000000000006d0a0905f4d04210 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 15.02.2023 17:29, Tamas K Lengyel wrote:
> > On Wed, F= eb 15, 2023 at 5:27 AM Jan Beulich <jbeulich@suse.com> wrote:
> >> Did you consider the alt= ernative of adjusting the ASSERT() in question
> >> instead? It= could reasonably become
> >>
> >> #ifdef CONFIG_ME= M_SHARING
> >> =C2=A0 =C2=A0 ASSERT(!p2m_is_hostp2m(p2m) || !re= move_root ||
> > !atomic_read(&d->shr_pages));
> >= > #endif
> >>
> >> now, I think. That would be l= ess intrusive a change (helpful for
> >> backporting), but ther= e may be other (so far unnamed) benefits of pulling
> >> ahead = the shared memory teardown.
> >
> > I have a hard time un= derstanding this proposed ASSERT.
>
> It accounts for the vario= us ways p2m_teardown() can (now) be called,
> limiting the actual che= ck for no remaining shared pages to the last
> of all these invocatio= ns (on the host p2m with remove_root=3Dtrue).
>
> Maybe
>=
> =C2=A0 =C2=A0 /* Limit the check to the final invocation. */
&g= t; =C2=A0 =C2=A0 if ( p2m_is_hostp2m(p2m) && remove_root )
> = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ASSERT(!atomic_read(&d->shr_pages));
= >
> would make this easier to follow? Another option might be to m= ove
> the assertion to paging_final_teardown(), ahead of that specifi= c call
> to p2m_teardown().

AFAICT d->shr_p= ages would still be more then 0 when this is called before sharing is torn = down so the rearrangement is necessary even if we do this assert only on th= e final invocation. I did a printk in place of this assert without the rear= rangement and afaict it was always !=3D 0.

Ta= mas
--0000000000006d0a0905f4d04210-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 13:37:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 13:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496548.767341 (Exim 4.92) (envelope-from ) id 1pSeRd-00036Q-CP; Thu, 16 Feb 2023 13:37:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496548.767341; Thu, 16 Feb 2023 13:37:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeRd-00036J-9m; Thu, 16 Feb 2023 13:37:05 +0000 Received: by outflank-mailman (input) for mailman id 496548; Thu, 16 Feb 2023 13:37:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeRc-00036D-9n for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 13:37:04 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fddbf613-adfe-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 14:37:01 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id fi26so2820495edb.7 for ; Thu, 16 Feb 2023 05:37:01 -0800 (PST) Received: from [192.168.1.93] (adsl-89.109.242.225.tellas.gr. [109.242.225.89]) by smtp.gmail.com with ESMTPSA id i2-20020a170906850200b0087873afb1b4sm832557ejx.41.2023.02.16.05.36.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 05:37:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fddbf613-adfe-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=56Ah5tkV1nMq9hsMYCcEBUOF7S4X8K0Vn6aCDXSfJkg=; b=eRgpBGTjQjPW+stwcE/9IfPlb8D5+C8dn+S6Ds1SD77pNSFzLFqZtYc/p+ArtFg+cd kgUrhYo3HEY4T6KKL7v33Y5DaW4otYN92qkwcTJ4/xLMhGtsZtIRHa1W6N0PawSVqkpH rp8H+ZQ5D2x15IU0JW5tgBcU1zNID8Bj4TXBpAUrX+wiz3fBciRL4ANy5qlgOENSZgF8 UstsZaNZmIxIML9gaUXUKpmQkRKDtmxxXjBeg2+Ze25UkpO9pBiA/Z1kjq0t9/jz76sS jxCdnoJVPvZZVJ+MQxEmmUhCAzi05vZLsHgf5efpAQg+b3dIloaZ3iXscxCSNWKKPVdw aiqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=56Ah5tkV1nMq9hsMYCcEBUOF7S4X8K0Vn6aCDXSfJkg=; b=lozvTIdYKymoIlPScxazUqiGdbKRCJS4UPm6xj6mg5pHWCoYMidhjLIAMApfWzmYJy gRkWvo6T3GrHZa7qY4HvOxfBHpZjjAunU/xxn5m/7gOkVNO1bSo8h9APYsPC1zExmpM5 mTHfulRqbTWd/7wfuVoSpnCZnxTZrtqQosW02Lev8FG32uDQBRA2R6Ov+WmJzXmmu9XZ phcDtV/4AQnQrrMMm3FhcZxdDSQL/1bEX8LdW35t3Z3HEay31TYwZEyvd9G7vm2CB+61 Ca/cFnSzHJmHoljCVsvSakJopWpWQNdwM/VF5ZaW8DG9PyXpL6L9Wcth2LpxBW22wpES Eeyw== X-Gm-Message-State: AO0yUKWcKWaZXySbOgTTzfNEA2zhVZwbwMJeNnZvEwWd59BNV950nO/C t0FYS5lEBiT0rzBGxecbzuM= X-Google-Smtp-Source: AK7set9pIDudcGGtDg23U6mhqY9mwbkG78skfnRmw3xuFO6b9pmlwtzolAJ64Ayj/8q095wHHMaYew== X-Received: by 2002:a17:906:1014:b0:8b1:756c:1a30 with SMTP id 20-20020a170906101400b008b1756c1a30mr1014513ejm.59.1676554620618; Thu, 16 Feb 2023 05:37:00 -0800 (PST) Message-ID: <91601284-d648-39bc-2c8f-8e739a44a038@gmail.com> Date: Thu, 16 Feb 2023 15:36:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230213115017.902037-1-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, On 2/16/23 12:28, Andrew Cooper wrote: > On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: >> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> index 234da4a7f4..97d6b810ec 100644 >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >> @@ -85,7 +85,7 @@ typedef enum { >> void vmx_asm_vmexit_handler(struct cpu_user_regs); >> void vmx_intr_assist(void); >> void noreturn cf_check vmx_do_resume(void); >> -void vmx_vlapic_msr_changed(struct vcpu *v); >> +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); > > Hi, > > I see this patch has been committed, but this public declaration should > deleted, and vmx_vlapic_msr_changed() made static now that it's only > referenced in vmx.c. It is also used in vmcs.c > > It needs a forward declaration in vmx.c because of its position relative > to the vmx_function_table, but that's fine - we've got plenty of other > examples like this. > > Could I talk you into doing an incremental fix? > > Alternatively, we could get better cleanup by forward declaring just > {vmx,svm}_function_table, then moving the tables to the very bottom of > {vmx,svm}.c at which point we can drop all the forward declarations. > > Oh top of that, I suspect we have other public function definitions > which can turn static, if you happen to spot any while doing this. Sure I could try to cleanup {svm,vmx}.c and the corresponding headers. > > Thanks, > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Feb 16 13:42:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 13:42:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496554.767353 (Exim 4.92) (envelope-from ) id 1pSeWK-0004qU-08; Thu, 16 Feb 2023 13:41:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496554.767353; Thu, 16 Feb 2023 13:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeWJ-0004qN-Ss; Thu, 16 Feb 2023 13:41:55 +0000 Received: by outflank-mailman (input) for mailman id 496554; Thu, 16 Feb 2023 13:41:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeWI-0004qD-C9 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 13:41:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa8bdbd0-adff-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 14:41:52 +0100 (CET) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 08:41:49 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5568.namprd03.prod.outlook.com (2603:10b6:a03:288::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 13:41:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 13:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa8bdbd0-adff-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676554912; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=xullL6mmEq5Zh1V0uDrUXzaBP0z22BEXpyXiGPSkOKw=; b=JSq1ZKBi4GmwqWbIY3JR5n00fO706ghwb0wnJ+BgQCUfIt8YnI1l1crT 6AhaKynrrZ5JDdLWEOh8yP3X7qXh2aodHIR36OYdj/9vYJ2MArJcLUECb sr9AiGOT+My+Eulm6e4bMT3imroQNnb+4TNEnaWQUgGA+K6uG8O+6JuBc o=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 97221700 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:J8vxuK8PQlF66Hf+I2LEDrUDaX+TJUtcMsCJ2f8bNWPcYEJGY0x3y zEXD2yBPPmOZzamc991Pt+yoEwDvpLXnd5jTQFvqC08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6kV5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklNz sAJBBcQTyrEgvvmkKq/Rs0838k8eZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCd1ITuTnrqYCbFu76zFJVwEHbXKBrKf+rE2BHOttD 3ZP0397xUQ13AnxJjXnZDWyvWSWtxobV91PGsU17QiMzuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8rzm/JCwUJm8qfjIfQE0O5NyLiJ43pgLCSJBkCqHdpt/oH3f2y jODrik7jp0Si9IG0+Ow+lWvqzGhuJnPCBI07wP/X2S54wc/b4mgD7FE8nDe5PdEaYqcEF+Iu SFcn9DEtbhXS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysLjHOPFBNGtZNKXr8= IronPort-HdrOrdr: A9a23:Dk7Z4aDrX5r6q8rlHemE55DYdb4zR+YMi2QD/Ep6ICYlCfBwWf re5cjztCWE8Ar5PUtLpTnuAtjkfZqxz+8W3WBVB8bAYOCEggqVxeNZnO/fKlTbckWUygce78 ddmsNFebrN5DZB/KDHCcqDf+rIAuPrzEllv4jjJr5WIz1XVw== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97221700" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuKfsn9+3IphsrzVm1t4xlZQr6lD5THRNqr8cAzxjaekPNnJ2pOmcJNGKFuJ1eX5YsaIVMXhWhtw56Odx2Iw+KelInWpE21sgBFoM7svHRbAPp9x81tCaXjRdRW1WsVvpdsUrezThth9hFw1SFdKRAHsg45yDXYCiIRI9NX8uBZbeqcvnxwB4TONXGn2/JlasR3yU4XLA2H2N7XUmMhCkXJ1QFhsFef4IYGAy6eo2ifuyX0Ehg6wxsPWFwoTGvS/2kJZWkK8cmEnGunJ8+KTscTs44c9fh5u4FxQCZAUdqd+0u9/y19nPut9cLjUZeL+O4h7Npcb1G3mF2gn4JT1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xullL6mmEq5Zh1V0uDrUXzaBP0z22BEXpyXiGPSkOKw=; b=BBTkPhh5hpzh0Hbcft0YG+cWBZNIaeHrORJsgpIUCaR44iXCfx1zqVIj6iATQj4Gl3Azoj34BP1EgU/Vt5Xn7x0jT/GVpM6KRmSUBR8SyXk6tnMY2tJ9iQXrmUeMbLD8jJj72Z8ocMQ5kX8rDKZ4Ol1Xw5y31SgnjTMjTTn3wtcPkj+Z1v3SM79NAwzY1PsnOhGUO8yowXSK86Bu/xbIPq7yuIQ5UieZjAN5TuGQeKZmR8uq0hpgn1HkswiagGCAqLgIUceAews1s9pcBxXZbo0orFP9hID4FbuQS3f0ypyyH+g2HmUy3nfK8HXyZPxZ/n1re9SUMPBIpnjA/cKsYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xullL6mmEq5Zh1V0uDrUXzaBP0z22BEXpyXiGPSkOKw=; b=sUOm8xkhTFt31RoDiTtrionf348jZnoXWB++EA9UvvWxVV0afKvXvwvHwyPvB90dtgCDXy4x83OXhUbayHMLpRVRy/OJNrPAdIHOBLm4z3H0u24sN+ALtH+Csv1vlix1IFNfT42z4MIlgSNOf3kD2aZ2kqh6buAsOnmAzye/jB0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <71f28ef4-ad44-dc9b-705e-528bf239b162@citrix.com> Date: Thu, 16 Feb 2023 13:41:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230213115017.902037-1-burzalodowa@gmail.com> <91601284-d648-39bc-2c8f-8e739a44a038@gmail.com> In-Reply-To: <91601284-d648-39bc-2c8f-8e739a44a038@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0569.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::9) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5568:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d9a70bb-6fa1-4f26-0927-08db10238b66 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W4heQS+dQOTIhH90dBf0al3b3wGPzvPQygx+sVNT4FDb7YuryGwU06+Y6afpKFpWFkNt1AS6iYUgUwXcBLFH8pEzUsEkwHLf5qIndKPwVQpG0aU9sZdIb8ILH1sc/3OTStkdlN3D/LHZPgQqAYhk74yq4NOnrosYLKiUGcXYZ6GUstITWEa/b1iMnCsiKyX0yK8de1WbVTDhR7Kc1POhx5tyLF+CK+6+IXpS2V30Zd3ysYKqQkCkWHq9s6U4G+Q4TUGKu9f72LtcyUHJyy2QyJnzSQeVcEQIygRU5ezLTvZ/AIJTJytKHwrUcDNYYcRxgxCd1vw9pPQyFPD4ovMTxUx24rum4MJbtbckwxTSDDztRJZ3kh2MEKBGW/UgiY9hlEKBOsqg+BD8ZwrqEQIZ+cbr2Cv+xsVo7TJZKZu15w/46Y4eEYftpBTf/QFD92F+JtcXCjH5D8k06yk/pwispynTQHDQuV526YpifqCIEEZ0jBDhCHs9udkRFSbZfgHPCFq5SmokhOfMjPPfIjcnfn6NEkJcf7ny2430rGv+drKAqEaZpByLOrz53CVqXFLb1g/1uf4k6Df0pU1WxCwx9HSTEcrk4VPSsUjxUWOv5Ljwgb+Jt9lUsll8mny8eliMGnZd8VZHd6afn+tg5Ym2booqUhbb1vT9vM5A4M/W4rIjzheGEFcX7wGUK1RSDpQijzJx4rVivFieaQXE7arBXrS613A7L2J/WsszzN5WUnY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(376002)(366004)(136003)(451199018)(36756003)(2906002)(83380400001)(86362001)(31696002)(2616005)(82960400001)(38100700002)(66556008)(8676002)(66476007)(66946007)(54906003)(316002)(8936002)(4326008)(5660300002)(41300700001)(6506007)(6666004)(6512007)(53546011)(26005)(186003)(478600001)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVEyVVd4cXRQMTdkV043WWh2aFdqZWNxd0VDSjgxT041SHRkSml3YTMvQXk5?= =?utf-8?B?QU9TNnhOZFJxdWtDT2pDV29UZm1iMHNJUHdaU1EwK1hzbkZEMGFveDlvekxJ?= =?utf-8?B?WTVEdDJpZmNQOUdXWm9YQTNVTytlSVhnTmpZN0pWNWRxNTlVOVVYb3FGWmJ3?= =?utf-8?B?VExwYnpZbnFzV0ZCeTFsd2l3dnA1MHU5c1E4NzhNdXZwV1NkSnVBbnpUMXVS?= =?utf-8?B?aGszVEVNb3YycEJ0ZnoyVCs5ME9wcWU4Ri80eDloaklaSk50SmtjMXdickVE?= =?utf-8?B?dk8vMHNkUTd2aHhCcG9LdGJDN3V4OUxCM0NtT2pxR1AxbXg2UDlXaFRHbVRq?= =?utf-8?B?R3hGMlRWOWlHL3Q5Tko3YkRvVjJ4M3pZdTkyNFhpS1hMYXpveWQxNnBHdmJs?= =?utf-8?B?TGRDemUxZEtSKzNHUDdXVzRNSFptQ2ZHK3F3b2xUL2RjaU1MNkVodktCYnVF?= =?utf-8?B?cHpTWDN3aHpxbHJmSS93M3p6V21iS1ZHSFJkVkxYTTdIVndVSkp3MzFiSnp3?= =?utf-8?B?cnZwblhPQ0tabGovdm1Sd1pYc3Vlb25mbnJ3emM4THRPd2pPcVVMUk4zTDRi?= =?utf-8?B?MVRBQ0hGNW56QU9PcS9mR3RuT2hwYkVDcFZlS3J0UEdrbTVXbnVINzJacWFQ?= =?utf-8?B?UldjQTM3OUhtQVU3bTQwN0JEMm0zbmZWZVBIdE5GeWVMOGJEcVlyYkR6UHl2?= =?utf-8?B?anJwa2xwMG16RmZheFh1Ly9oZkxKaDY3V3ppa0g4OVFGTVJrY0M5V2hpZjFW?= =?utf-8?B?MTU3NU9kTk1yN3YyNEpaTXBUNDZ2SWdtL1ZEeUlZTEVXNkdMVXRTWXlWcXdO?= =?utf-8?B?MW9KWmdCWkRRcWZwTGdMY2RZWkJvWXJwWkE4WStVazFiMHJpNFRYbUJjQmYw?= =?utf-8?B?V3IzWS9IMDdueWhYTFFOSUgzQ2dsQkRPSWZVSG8zMm9ZOFp0aStHMEhpblhH?= =?utf-8?B?MHh0MmlzOVQzZy96djhWU2M4R0w0aW9jZEMvSFFEWkswODFVZFpwSFlQZzBG?= =?utf-8?B?bzdycG5laXVJMkhCQTQ0ejNVb2pBMDVNdWpqM3ArNWozcytFL0V0N2FVTldq?= =?utf-8?B?OXIvWHFYaXdMOUsxVW1wTUZ3dWt5QkxGLzlEWjlNTS9yKzRvYkV3SmVMWG1O?= =?utf-8?B?ZWJ4R21idXhFYm13dS9qRENjOXFrcUN0NDlEc1NudXdtdW5QYkt4RUtVbWk5?= =?utf-8?B?MHk4N25jMEM4aW9vV0xCZkFUMDNabENEM20zS2J5RCtNVXhEbFZJNUFtNCtQ?= =?utf-8?B?c21lTzNkQWUvSkhCSGF2NmsvbmMwR3MwNG9YcjExU0Q0UUx6ZWRZN3JseTVD?= =?utf-8?B?Q055bU1hbS9hNmVzVCtraUtsMjRIa0VzQjdkaHA1U0t0TUpzWFlFb1VwcWVk?= =?utf-8?B?b2xGYmNmV3lnNXN6YmwwNXV6SzlYOWltL1hOcGh4NFJRbldsVStrRithZGtx?= =?utf-8?B?NFJYbUJlKzFubmVybkRnYlRKVDVyczR1elpNMTA3dDlYWXFCVGdrKzByMk05?= =?utf-8?B?UHZFNTlVQ2toMjd6N1dIdzhkckNOR1lrRGN5Yytucitla1lHQXpIRjdTZDA5?= =?utf-8?B?cDZETlcxTU5vZENIb2ZtMnUwUUZINTNHT2pKdUo4TVBISThzcmVEWmkyM3Ay?= =?utf-8?B?NE1Cbi9keWd2NFlGY3Q4TEFVUXZnUTJCblRMK3NSWXVYU0YvZTd0RFIzell6?= =?utf-8?B?akNFQmdXVlV3TForYzlzbEtkZmJNRWh4SW84b2lRd3ZlN1E4eW5pU0FNZCtS?= =?utf-8?B?R2pGbkZ2dGhBTGJtT2dlRElZWll0T2pjODcyMHE2UVFOa0FzWkJ0THRIRmVK?= =?utf-8?B?RElybE5LTWhKalpzRDJUOVEwNHkwZVl5dnVZUlB4ckNCZkk5VjRKNGg3eFYr?= =?utf-8?B?Vy9mNW5scjZncUNUZUtSczFlOEJ3UGVrdUZSWkFieHFUbVJNek4rSytrVlh4?= =?utf-8?B?ZDZnb1ZYQ1dPeTBzandVSTFEc09rYXlrUFBUT2ZoNnBkUys1T2NySWt0KzAx?= =?utf-8?B?bG04TjZTTWtrc0lsbVpIcHdtbGRWQkJTTDBSSjVSVEJGWnBXb05vN1dVSTFu?= =?utf-8?B?VVVMTVdldS8zeHBaK29hMERMbUR1WXVGb3hiRmVGblQweWIyU2VzWXRVOGJ2?= =?utf-8?B?eW9US1UzNytCalRaSndPOElNeHF6c2pmbFFsYUsyUTk3c1lnYVlWekdnaTkz?= =?utf-8?B?T2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: a0YHHjqxWj17M3+t9lwCstDGxoc+h1kozQEz85QIpAnH3K9cR+Y3lhvqFNX65sVXrt/z+LiED5yszneggST/32BQBQmzM5UkO2i/+QSW1qc+OEahVe4ndwF063jiHErGmbpbOyc6SlQHL//qOEgXpb7s8+imA+PFkSkMFS6BWBDbioFfZOtlqH6mSjWEBZPLE9TX+sG1IAjjFxN8Fl5xgb6dOItkFX43Ba95Kx3M6UweFRmSUyAiP5V8P1OVNm5mH+u1FiqR08UVOAP9kyvFMowRr/JxPgegrB7Bh7nm37R0999EkCeQs/7idY2xM5U5AuxcPfxY8ZGkN9rLGRJq5fnZzBQ7fw4YNqP8cQ+2A9S51B/86H9wf1R86xGAXGezFsO9SburKOTQhfWDXJa34HE4A2I6t3rMTmABDGGMmq+Nco7NNnxxo2At1i2f+Ukw+WEIp8KO0SQ1lPss0nTjXKmVZW0ScLf4gejGBdiQewumSWvjCea6+SBEe79R2Vh26G0scys64rWuyRSgdoEm5RFluoeVcsosEZsIOUoUTcrdvlUcB5kv83C/zO3Y+93ZWs+YVK7cWFAg43c6/esni0sB5Y88H6Uk3Xy3QzLS6UPE8CEzonj3mq9EpGk5Lud68CPnuhxCa3iedEoxb86a4g5c8lzmNNX9KUduaBHPs4WZqIiKi4AvV+ra3qJCZvWIbD6J5+7PzLeiGXsoUJ4jKjpXViBFFhxPH1OQv7jlVgUqvU8l+8FEbd7Zu7GfZCFjZR+GqA2ijbQ47gRph1X3MO7w8bESUDimsfjsfhoqZE3hmnJ0F3SBhuNUTefHqM7V2Grv3sfAp1JhLvzd4lIj0Vlo8LXOuHxkEEBNyswaA1KVsK04GkvI6+X1EukFFD5g X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d9a70bb-6fa1-4f26-0927-08db10238b66 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:41:45.4645 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v+XQmkouldZHng/gY8iVCQY+GfFr7y5svLm/Mq6ixNRTncF+uRIAzozeUYPfrnNSh5YDDtBvdGKW6zRYPeiet7Tvlom22u3zY5oYW2DZhL4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5568 On 16/02/2023 1:36 pm, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/16/23 12:28, Andrew Cooper wrote: >> On 13/02/2023 11:50 am, Xenia Ragiadakou wrote: >>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> index 234da4a7f4..97d6b810ec 100644 >>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h >>> @@ -85,7 +85,7 @@ typedef enum { >>>   void vmx_asm_vmexit_handler(struct cpu_user_regs); >>>   void vmx_intr_assist(void); >>>   void noreturn cf_check vmx_do_resume(void); >>> -void vmx_vlapic_msr_changed(struct vcpu *v); >>> +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); >> >> Hi, >> >> I see this patch has been committed, but this public declaration should >> deleted, and vmx_vlapic_msr_changed() made static now that it's only >> referenced in vmx.c. > > It is also used in vmcs.c Oh, so it is.  It just doesn't show up on the patch diff. That use likely won't survive fixing the Intel APIC-V logic, but I guess we're stuck with it for now. Sorry for the noise. > >> >> It needs a forward declaration in vmx.c because of its position relative >> to the vmx_function_table, but that's fine - we've got plenty of other >> examples like this. >> >> Could I talk you into doing an incremental fix? >> >> Alternatively, we could get better cleanup by forward declaring just >> {vmx,svm}_function_table, then moving the tables to the very bottom of >> {vmx,svm}.c at which point we can drop all the forward declarations. >> >> Oh top of that, I suspect we have other public function definitions >> which can turn static, if you happen to spot any while doing this. > > Sure I could try to cleanup {svm,vmx}.c and the corresponding headers. Thankyou. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 13:46:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 13:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496559.767363 (Exim 4.92) (envelope-from ) id 1pSeb2-0005Tk-HX; Thu, 16 Feb 2023 13:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496559.767363; Thu, 16 Feb 2023 13:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeb2-0005Td-Eq; Thu, 16 Feb 2023 13:46:48 +0000 Received: by outflank-mailman (input) for mailman id 496559; Thu, 16 Feb 2023 13:46:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSeb1-0005TX-3K for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 13:46:47 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5780a8be-ae00-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 14:46:43 +0100 (CET) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 08:46:39 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB4915.namprd03.prod.outlook.com (2603:10b6:408:dc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 13:46:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 13:46:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5780a8be-ae00-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676555203; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=TqSFKR6plrOR3JPb0HVLbPB4cYzROpFEU0sUW0jyloQ=; b=LvxYIebD6LZSTfa23iTWqQvjii+/9vot8ASVQJezB109P9OJbSxPJOjT maOi9BUyw1pgV/LHFy+uj31JvPvfWFex3q3u0bg9LUSC4BmvUKkWkVQbK fCxi5XnsP+0DEiuvBsZPOdeQAVedTySJqXxoW+CZ4GSzCZR600B58dSAe Q=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 97222236 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yl3X2qLTNW/AZT0kFE+RHJQlxSXFcZb7ZxGr2PjKsXjdYENS0z0Hx zYWXTyEafiMNDHzco1yPNiyph4O78TcnINgSFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c59W35c9 aU/BgsVQTXbjuOY++2/dOBz05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLkWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHyhAthIT+PQGvhCsnmt53EjVUQtCkb4mt3jjE/5QNkPJ BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXRmia7ay8ti6pNG4eKmpqTSUDVwoepd74vJs0kAnMX/5kCqe+itCzEjb1q w1mtwA7jrQXyMsUjaOy+Amfhyr2/8CUCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnwjxpZGFUwWWJSIqQ= IronPort-HdrOrdr: A9a23:pG9btqlelCmsVzNO+ePPdI015xXpDfI93DAbv31ZSRFFG/Fw9v rCoB1/73SftN9/YgBCpTn+AtjjfZqxz/BICOoqUYtKPjOHhILAFugL0WKI+VLd8kPFl9K13J 0QFpRDNA== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97222236" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWe2jEb/I/kRLUd146hXLaHdPbDpkA6J3IzYqozgFEQ7WM6E/E5wpB/WZm4XAOhdAZ/0d4USfI/DhfQ+XktpDUnyW3h6Shyfqy0knKeMg3H7K04s1pcJcik5atZBc2u/tUNfKHqSaH82svuc02155hmbms1GYW1qzDf2q5XjLXCQ1rMPUGSqcBw/syKKd4/IWRrfAsV7L1haQnppfgU3thsP587i85H5Z5Z2Y8MFJlu2CnWJNfe78M8/CCXpXkFb98b+H3ehA7w10PxcGtftfw5LAPVp4An8qE55D6aGU485LizGo0Re1aHlcHgE8QPoqry5kq2ObZDU+VLskTucPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/CYXEnbNwvj9nzCZ5CA4+V4KudfCULd9RHunL4tA9U=; b=AUIdx6O5N/zba4AQ44X953LoSEJLW52URzosBnWeP9Wy/qIoz3LIhbonou1XMjt4ey4JRHakNdhuNcl/C0Q+G/2sIoZdH2qUPVByjgsr9SAMKSf4kkNWxeDqbDqomJJqbKpvdoHPuyT2LvP6s3OodOHI1twuVo4UVtLa3jmHYPfjei+Q/2DEYWFd76RfbtefgbqNSGSmO8tbtSiIC8QFx77NaopObF29huG3VOhrZmJGcDGRUQYtCJbCN5bFcpJbMgY6LncF2VTCv+F/TlT7vgmYwNBnDcemJMCN4WNxZ87FRYNu3oMDE6AVzfwvB/TRCDqNvD9Vk6sPrNQBgDjpdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/CYXEnbNwvj9nzCZ5CA4+V4KudfCULd9RHunL4tA9U=; b=P/C/u97bq61tidBO5jFfGW2Ym/i1cIv0CGjcofhsfFBrLF2yGuIQw5bWirnv75yJLhIP5p4dIH/A/at19GO86imZcjwEgQjsFBcC3D/fxn3FFHR1BbIadGEQ95KPFV4/CPKuhX+YQ/ZQz0ymQstnTK8zlIBow4OBMrL9ShGyhTc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <08b5c198-1ec1-ea72-5200-c0b842f7d589@citrix.com> Date: Thu, 16 Feb 2023 13:46:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] x86/Xen: drop leftover VM-assist uses Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Boris Ostrovsky References: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> From: Andrew Cooper In-Reply-To: <215515af-cfb9-3237-03ba-3312e3fa0d34@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0117.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN8PR03MB4915:EE_ X-MS-Office365-Filtering-Correlation-Id: 74a12b22-6573-4ebf-d7bd-08db1024378c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y2/olQ98JklnOYijAefMNqG3dx8s1KJ/y8lLjgPJewsgEsGPwKmlWZQTRvxVKsLuXqhrxBQLPg7U6SNfTAYCt441f+7uLIoqw/CheCJUMyKqKP47C4Fv86KEJYZ7jGNXEMZ3dIUP8/YBb5Te8tRGo8s3JCDh2HnpamuYXXbraMnFRX5z7XWVusvLJNu7p+rLGjU0fhLSdm4gwZH4a/fxD0qxUfl+Uyx1bP8y7bGLwj1Zfi1gjP6evoeg5YeOgmlqh1AtaDZeLILS4Xgm2lvfQ/wedFZ1Jtap96d05KDzMC98kB+8Ab98oa6ymeG9QLc+tt8YdDUnUw6yFxUHIYvIiMwF7fu+5FFoKmfNKVEImiFgGnJlcEaRUnks/KHVPHkOrkMWs1oX65zQ3CmPwmjXZFjG2twvdOlb+GD496s948pFiUZLDmbAkMRtz3o0QsQH1lrBFrwLqFXSg8ILzrpT2t4OXUp/6N0Li46MoMZKEWf8IOxfRLswnlSWm70wfcp0v35FxCVeaf/K4Qf1Blb4XAFn/AEArfrFzNN3E9LdE66wVautyX/61LpkJLHTpm651ovpS61N6RNIqTxv4hUw3gBvdOJ8MOD/cG7T7/rVFKmJtnCBK21VPeJyB8byUby6pxytDReo6gvgCLqTFnLfVjdn8FVE8i0dpctn3nozpeYUO2ICrqD4UGn4WKdQ3qJ4yAP9v72C0eYP++XMbSXTHgvuzEdeQXnu2DJRWYIRaxk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(83380400001)(86362001)(82960400001)(31696002)(38100700002)(6486002)(36756003)(478600001)(6512007)(6666004)(26005)(2616005)(186003)(6506007)(53546011)(66476007)(8676002)(66946007)(4326008)(2906002)(8936002)(66556008)(4744005)(5660300002)(41300700001)(31686004)(54906003)(110136005)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlA2aUNlbC9mN1RSUXJmQURvTy9ZOG82YVkremlBaDlIbVlhMjJwV0JxQ0hu?= =?utf-8?B?dTVpZm5PbzZRSEI4bjFMaGRJOC9tWk04QmZyWVBJSGtqWnJxM3BPVUlxaGZo?= =?utf-8?B?ditpanMzRUlaVGU2VEZZNzgzeUNqUFB6WHd3VVdqUVAwMUpXT1I5UEhKcXhH?= =?utf-8?B?Nk9IbEJ1d3NaL1RJd0dtdFV1WVRFSkZlT2tscm1pNm5USG92bjRWcHRoeDA1?= =?utf-8?B?TDIxRHVJODRvSUcydG94b2IyS0FGYXA5MlFLN0JUL1pQbjl1S1VRdFppUzMz?= =?utf-8?B?bHUzNm5nTERKeTZhM3BDQzF3clg5WUVoTXV2UTF1bDZzSTlkK1UxRnlVdFE4?= =?utf-8?B?VXM0c2JtUHpRVkpvOHBEakp3UmZ5a0twMnlzRUd5dlpPUHF6QStxL3dXVnBX?= =?utf-8?B?L3ZadjFWTFc5SS9SSTI1c1UxajRjd21JaG5CcXRRZnV3RllvV3hEQVBNc0kv?= =?utf-8?B?TTM1QTVXMGcrRm82RFpnWk9YaDl4MnJzNmo4OUlRMW1ZUmtvcVcxRkZ1MTRR?= =?utf-8?B?OEZ0MzVqeGVrbkREbEZ6cWttR0JET1FGZlpFSVZtSDBycU01eis3aXRGeWZ1?= =?utf-8?B?RjZaZXhsZXFTVENhM1B5OUdBb2twTVhrT3drbDVvYUlBbi9ld25uam52Rytx?= =?utf-8?B?NlpmOWEyYUl3WU1MOGpFTnRUL0RDT2ZZem1XNU5hVEcxcjZSZjFmTERjZlhJ?= =?utf-8?B?NW00a1hmeDcyWmJ0aFMvbGhuVHk4N2VWaERiUU8rT1d5cU9xYXQ2M29TTlRu?= =?utf-8?B?QkppeFU0NTlqaEM3SFYvRUxudC9QRjNzbUliVGpFOTdvZVBnOTRUOW9TZkV1?= =?utf-8?B?SVNDTjg1UEZoSko2UjlOUmU5c0QxZlExaVVPTzVkS0ZTcGJIbDFYOGY0VGxM?= =?utf-8?B?N0FnZy9YUzIrZVAzenlwOEtWLzRzYllNZDRTVHRhTkY5dTZTU3pWdmRpOTBS?= =?utf-8?B?ZW1nUGZqKy9MQjk2YjFKb3NjUXZVN0crK1BVd1NmWjZKUG55Szk4V3VsdXMy?= =?utf-8?B?Y2ZGSUt4a3F3M0s1clZSNTE4bmNkZ2dyY3ZNVlh2d010NkYrdkhLYmdXaDYw?= =?utf-8?B?aENRU0hDM1JRQzZzdWNHWDVMdm5sVXpQQWRqSHBsZElYTWZFRUhOSnQxZDV4?= =?utf-8?B?MXlDVWtQL00vZkxneFZsQVVWRk14Sk12ejg5OGY2TENUNFJKdHR2MnlmakRq?= =?utf-8?B?Z2NGNWlrMVVYR25Za2Q1eUF4NEZxNlFneGxrSGE4ZjZsekdTeXVvOGVSSlhM?= =?utf-8?B?bDVtUzdGa3lzbmRkNFZTQWkvbEJpUHNJMHZheGlhUnJ0RjJqVEgxVWxQWDk1?= =?utf-8?B?Yk1kSk5RWG1KNkROTjh6VFFva3V3T1ZEZGVMWUZneWZtNEZYM25wTHZENVlp?= =?utf-8?B?bEdlWUcwYlYrbDhXU0RjK0FCaHlCTFVWd3Q5ckRzMndCb0NXQjlhT2VqT25p?= =?utf-8?B?dDN2akd5R2hONXlHMlNhYkw1QTRlb1lsUnd3eFdYekZ3aGxpMDIyenRHcjQw?= =?utf-8?B?YUVIb3dLVVJDUXNHZENyb2kyRXhuT2pWSzF2NjJOSE4zTkxqb1Y4d21NUVZQ?= =?utf-8?B?YVhTK3JCd1FwLzlVbXVaVk1FdE5sdElZYlJmMlFuQVVxYVlXUk1JRUJUYjJm?= =?utf-8?B?YnpwQThFT09lbG9HRVF1M1lpelRaNlg1b3dob3pUeXlrZkJMbDBEWjVaWGF0?= =?utf-8?B?Tjd6OUx0SlZiV2FTVFBLT1JPUnJsaHgvY1FoVlFOYUR1NTVmYWNMekV4QjBl?= =?utf-8?B?YksySTdQWm9mRVdHcDBmc2RVMjVXbEFkc3IvOXVaZlR5ZXppclY0anJWZGto?= =?utf-8?B?Zy9yalhLYnJWTmNiRnAraXlwMnhta1V6TnlwZnVNL1YrYTVJVjJvU0c0ZWdv?= =?utf-8?B?ZU91THk3emt1SmJOek0rT0VNVW9LM2YxUTRQb213MGcwbjNrUXBnL1BSR1lm?= =?utf-8?B?T01FbGNyRXlsbjdOa3hyZXVtN04yQVhhRCtPdFE5aGs1WU9CWXoxbzZWWHNz?= =?utf-8?B?L2I3YmpES1ZOSXB0clNCWFN5dTY4QmQzSEtKaXdyeTE2eGpzeGhFMXZkODhQ?= =?utf-8?B?MFlBR2JNL1lRdGI3bXcrZHY5WEZLcTFFWDM5WE5mRjlmUDZabGMyT3VJRUR0?= =?utf-8?B?OHRUWjQ5VUtUV052RW95c1pwUFJqSFI5aEZua0xkdEh5WUFTWlJYS0RFMGtB?= =?utf-8?B?VFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: A71Eos/RtpOPff8UlU/UJSwvcvUBWdxPIAFChCsQ4XCKMmEkWUNsd+WmDAOiavU84XNaQsg05Ut+k/WqW/hQ65O3vilqwPfY8HBmA4Bc9EbIKy/y/xR1w/KVz/XRannq7ZAm7oIgIi/YC+rSOcBVdZtgkVFCkmTjvsa0EfA0vGegpa5P1DaRloAWaipraSVTslk7X73KeZxwLrDrN31rBkwx1kpti/rH6EAqQyB+xfx4e2/0oTQmNN70LpviVfFjkGxCmWU375aJ3mQeDCwEFLSudFKKywtwXY5PrLEPpVZqLYATXj1weXRf04tyLzFBN91+cjNwiy3BmRvnxknyLga4xeVlEmAQD0uove6pjChZ1pb43AeHAKL9VEKLNhurvHqA0fv1BKv++RgDtfov0MYbnP0okzjDdCChnWxkin+EcgxDET73ZTrT83H2EANBfONFznqrLlNcECpan+iHaC0o7SXvdcwX1OrBM4CikVhM+0p3UZRqYmfzADSdDTOVoXIcoQLzb0530mq+hGrpPPXpxm+UD/o8Upfcp3K11YTzwg4qE3PInnj0sOniqYY7fkXYQeeebPZag5UaJr4B5wYBQNyXmdAyKT62zRT1n/DNjht6YPRRheSNLwYtta7QSI9Hj5kl8JenU5z3wWqo3xHQz2atafBqgbZlJ/k7MM39kTrySRz9AQaDAVDnWjxPaFXWXmVrNjI07fGDdR19g6WGtZUbWGUC0xljzfd5qU/+Wh4peJmF/W/kNZZrnwAkY3ZqEjc7+qEZYiZ05IVBV+u+11budrDWhVVk+kJM7Jh6m+CM1kKuP8s5+rcWHfmHKePNk2ox29KIfWF4pqrfKQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74a12b22-6573-4ebf-d7bd-08db1024378c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:46:34.3338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J148fRP3mdhKA2S4EfzLxai3K54T72qE3ylpo5q9mwJDKwSRSDmzIVl+KHr/8WzXi9hUF/9+zNQXHbU4kCweplK6rM40ma9hX7gr9PBjUWU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4915 On 15/02/2023 11:27 am, Jan Beulich wrote: > Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to > 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant > with the PAE_MODE ELF note anyway. > > Signed-off-by: Jan Beulich > > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -934,12 +934,8 @@ void xen_enable_syscall(void) > > static void __init xen_pvmmu_arch_setup(void) > { > - HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments); > HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_writable_pagetables); I find it disappointing that a PV guest which states a hard dependency on writeable pagetables in its elfnotes doesn't have this activated automatically. The PV API/ABI truly is an undesigned mess. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:10:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:10:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496566.767374 (Exim 4.92) (envelope-from ) id 1pSexx-0001WN-HG; Thu, 16 Feb 2023 14:10:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496566.767374; Thu, 16 Feb 2023 14:10:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSexx-0001WG-Eg; Thu, 16 Feb 2023 14:10:29 +0000 Received: by outflank-mailman (input) for mailman id 496566; Thu, 16 Feb 2023 14:10:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSexw-0001W8-V7 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:10:28 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a747e650-ae03-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 15:10:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a747e650-ae03-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676556625; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=INVBs69BMsEB8kgIYMnuRjPYRAGZgriwJOHjHpb11Qk=; b=DlTaLE1r0IO4oJWK0q92i+t0PET8Q5sW8Y5MVA/SR+ZGSDegLLtQwkxS V1r+11GSk/9rOo8dRzOqeOXBHe/t5fToXOrnKp5wG0CMbKfFwRylhHLbI 40geBy3x3ZoGOhVPy8Vy7XVb3R012BIQTpBszzqK/yYN+MBAHdyGJZK3g I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96698536 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:2YlQRK+m2nVhjyn1z+NZDrUDoX6TJUtcMsCJ2f8bNWPcYEJGY0x3z GQYX2uBO/bcYjGjcopzb9nlpk8P6JSDz95lSgts/Hg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6kV5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklN/ +EWOmktVSuuuLu5woCfacdenZoaeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0EwBjJ9 j+doQwVBDkeK4W1xhe17kmJh9+Wr3OicroQMoOBo6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC/ l2GhdTyHhR0raaYD3ma89+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZtVpDaCn1/3OIhzPm j+IngwdqYcI0/degs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ5Wu9B7cJZhNGiJObhKrgY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ snHIZj0VyxLUPUPIN+KqwA1i+JD+8zD7TmLGcCTI+qPj9Jym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQEKWQGOqdR7BQlTfRAG6WXe95Q/mhirflA3RwnMypb5ndscRmCSt/4OzLqWp y/mBBQwJZiWrSSvFDhmo0tLMNvHNauTZ1pgYUTA4X7AN6AfXLuS IronPort-HdrOrdr: A9a23:fepyCaNNqf+SMcBcT4T155DYdb4zR+YMi2TDtnoBPCC9F/by+f xG88566faKskdsZJhNo7G90cq7MADhHOBOkOss1N6ZNWGNhILCFvAA0WKN+UyEJ8X0ntQtqp uJG8JFZOEZZjJB4voTL2ODfuoI8Z2/1OSNuM+b9nFqSGhRGtNdB8USMHfkLqWzLjM2dabQ0f Cnl7t6TkGbCBAqR/X+PGABQ+/A4/XTjfvdEGc7Li9i0hCKkTSrrJXnEx2Uty1uLg9n8PMZ6G 3YlA68wa2mv5iAu3jh/l6W1Y1ShNzijv1cA8CW4/JlTAnEu0KTfYF8XL/HhhAZydvfkGoCoZ 33uhI9OMY20X/LYW2vhhPo12DboU0Twk6n80acnXzg5fP0Xyg7Dc0pv/MiTifk X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="96698536" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Andrew Cooper , Wei Liu , Juergen Gross Subject: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Date: Thu, 16 Feb 2023 14:10:07 +0000 Message-ID: <20230216141007.21827-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Unfortunatly, --default-symver doesn't work with LLVM's LD, LLD. Instead, we will generate a temporary version-script. In order to allow regenerating the script, we'll have a different filename. In order to check if the content is up-to-date, we'll always generated it and compare. Reported-by: Andrew Cooper Fixes: 98d95437edb6 ("libs: Fix auto-generation of version-script for unstable libs") Signed-off-by: Anthony PERARD --- Notes: v2: - Replace "VERS" by "lib$(LIB_FILE_NAME)" in the new .map file. - Set version-script to lib$(LIB_FILE_NAME).map.tmp, like the filename used by the library binaries. (instead of libxen$(LIBNAME).map.tmp) - Write temporary file in the same directory as the target (in case the target is in a different directory) - remove temporary file generated by the new rule, in case it isn't removed by move-if-changed.. - use ?= to set version-script, this mean that version-script has now a deferred expansion instead of immediate, hoping nothing break. CC: Jan Beulich tools/libs/libs.mk | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk index 0e4b5e0bd0..ffb6c9f064 100644 --- a/tools/libs/libs.mk +++ b/tools/libs/libs.mk @@ -5,6 +5,7 @@ # MAJOR: major version of lib (Xen version if empty) # MINOR: minor version of lib (0 if empty) # version-script: Specify the name of a version script to the linker. +# (If empty, a temporary one for unstable library is created) LIBNAME := $(notdir $(CURDIR)) @@ -27,6 +28,8 @@ ifneq ($(nosharedlibs),y) TARGETS += lib$(LIB_FILE_NAME).so endif +version-script ?= lib$(LIB_FILE_NAME).map.tmp + PKG_CONFIG ?= $(LIB_FILE_NAME).pc PKG_CONFIG_NAME ?= Xen$(LIBNAME) PKG_CONFIG_DESC ?= The $(PKG_CONFIG_NAME) library for Xen hypervisor @@ -72,6 +75,10 @@ headers.lst: FORCE @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp @$(call move-if-changed,$@.tmp,$@) +lib$(LIB_FILE_NAME).map.tmp: FORCE + echo 'lib$(LIB_FILE_NAME)_$(MAJOR).$(MINOR) { global: *; };' >$(@D)/.$(@F) + $(call move-if-changed,$(@D)/.$(@F),$@) + lib$(LIB_FILE_NAME).a: $(OBJS-y) $(AR) rc $@ $^ @@ -81,7 +88,7 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) $(SYMLINK_SHLIB) $< $@ lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) $(version-script) - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,$(if $(version-script),--version-script=$(version-script),--default-symver) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) -Wl,--version-script=$(version-script) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS) # If abi-dumper is available, write out the ABI analysis ifneq ($(ABI_DUMPER),) @@ -120,7 +127,7 @@ TAGS: clean:: rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) - rm -f headers.chk headers.lst + rm -f headers.chk headers.lst lib*.map.tmp .*.tmp .PHONY: distclean distclean: clean -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:16:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496572.767386 (Exim 4.92) (envelope-from ) id 1pSf3Y-0002AA-6U; Thu, 16 Feb 2023 14:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496572.767386; Thu, 16 Feb 2023 14:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSf3Y-0002A3-2F; Thu, 16 Feb 2023 14:16:16 +0000 Received: by outflank-mailman (input) for mailman id 496572; Thu, 16 Feb 2023 14:16:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSf3W-00029x-OF for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:16:14 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20602.outbound.protection.outlook.com [2a01:111:f400:fe1a::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76614f7c-ae04-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 15:16:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8921.eurprd04.prod.outlook.com (2603:10a6:20b:408::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 14:16:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 14:16:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76614f7c-ae04-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfqcKCU6GRdXoSB3/xHVfYHzuBbENkMgjvromwG7VjHNwo3AWPHBM0e/nRZoFlHF6h+mmNmc0086PLUZycpUaxTDQPWrg99JMVgp3yIOKfH3bN1bm4bTUwwlBd4AG1QqT7gKE3xlk5RkVtUaIiqyDVv5mqJo8oenNEGnYpaRFw1ILDcCCiIgLVU9Lp3bWvfkXMTgyNsLeyKXAvgOSM2HwK8cY6cN8uWhibQ0omekRAagEkH13R/HErr68oYJIIqdOaQbs0oo6m18iC+6b/LVbliurUSdXxBCH010XxAszPt59j4/+ywAWB6hF1p1eNfSVAJo08vIzs1aGCTrO5+HXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UbxQXv0w8dlb73VGKlLjMTS/1U966hOR+jk6TwplR4I=; b=MLABkSw3WAn0Vpkq+IzlFJ658qLyT3AAMxytMgrv9K6dK5qY5EgMMx1R6bjoNmctipd4VwF3qiOxhh9XKWdMLyGN6zT28AgQKFKv6VKiPOXhnnrCfg00skMaL0QV6/UtDyQebHZq88vqO0gklPpma2Bq83DMnu2JepEzc81e9L+Ir9JbEoAk7S7DFBX5XzxsMEBvQKojflQuLJGQAw1ewuKrMCFRCgdVCPTwVLZs0RhfcXObtsTxgGjzxI6VG3t5cKnZ7xXdwDMPJyXmcakgg3dP1cdWGzWOaEiPf013B95CZvSMpnAa1TP4n8/9DUW+nRgAX/sbXJGdz/VAScutTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UbxQXv0w8dlb73VGKlLjMTS/1U966hOR+jk6TwplR4I=; b=r0/VTYPphDoW3no97L8fD250Whik7WGDcrGOP/rEy4yyAtSBL9q9Ocx4dLsd94vplI0l0c2v9/pAAeH6f2tfcp5rJ7vd07TT0MU1WiaX5L/jUdJHnGEZ1agIi1n/nqnm/wJvzgyWDM36OU+/LILh54P37eKf3CquLroIhe5A3IKX5i+E1YTIZJ69BSA5Q2NOC/lSkkrQYMeJzBezMvpcnouRoZ7Dz1sKunSt1daEnSVKIH6wCHOq4PFXremmOwjK9Kp9jIxFc3/ylx3TRKMqydqI7AgqiPLu0b0iZaT5FmNL1HGHJVurJlQbuftXEm2N91cNzrudeSloILLfmZ9iXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e160b28-ba80-c2bb-fa2a-5d5411c7d22d@suse.com> Date: Thu, 16 Feb 2023 15:16:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <9f375055-eff2-010b-c904-e4122b834777@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0199.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a7e8ecd-bff4-44a1-5669-08db102857ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /DEE0uZ4+qqpqvhf85LMK7qX04mgwhmry5m7k+GFz56agoGm7wiV5plL73DUSDDJaP4jo5GRzEKUdRi7jy31DUY+1O0FKjWZ6rqsxf+mQqZ9bMG7yL8EfaFNFlXJtD3q9rsRhYPY6fEyIqOQy/os/ThzBup1l3ZiIFAMQsYuRiKnqW4DC3ENK0TCZnt3c1sCC9wJzUEhOIeuT4ofjOylmlE/+cEKRwly1NwLIZyaUMf34CbyxuzyApaKWUr8p6YmNnG8mXmbloCTnbwO4So4GZHs80lTxKczQZ6mRePwafdMiUk+EzuSdiq76KdiHYaPJeKUspOh+5t7bznOsmwgktWuHJPlTV9qxJSnSELkioBJwzp/rlMtsa+DrjD40J+Q7GbunqYFxDaS5iM49KDbv00C0vMeKdYAdEtfMaUHIhtTsP63WsWYjVsGfOIi8lebT1Fdfffb1nO4Z/zflxriwXALdRnDxQSE3cBEmbNbk+H1cV+ULTc3Ok0qJncub98UElItt9oZvOc7yKUTb5d4E3R2fITUIbzY/RK5Y45bfhC0h2gk9Eps9ypO6f8fO5SCuNuQQFSjGx6vAuc1xfQOA0DDnhFkIRZXTjH4C3AHqouo/S3cJMUuje32Vrunfv0UQEco4+2xPqKknHKk7+HTaQCUI6BHhvkYKcnLAPi1MTYiq0GblAF3yfPdBAJw1z4CYBnuoL7p01nTaJMSyh7GiHiVQ89ipdonY8evBXhmChw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(136003)(396003)(376002)(451199018)(2906002)(31686004)(83380400001)(5660300002)(36756003)(31696002)(8936002)(41300700001)(4326008)(66476007)(6916009)(8676002)(66946007)(86362001)(66556008)(54906003)(316002)(38100700002)(53546011)(6506007)(26005)(2616005)(186003)(6512007)(6486002)(6666004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0djLzJCeUlIUEpWSkZJL3k1ZVR3aWJPN2lTdW45d3Nob2FTajFGa1RvTDhS?= =?utf-8?B?OTF2Yi9nUHc4Q21qaDVoU2xOcFF4ZTdoV2VzdGZqcjhCMXZEVEV0RVpIdWYy?= =?utf-8?B?OE1BRHBqRWNXdGowdjlEUEtIZmhRUVlFOEVYSjZTL3BmWi9xa2tGT0VIazZY?= =?utf-8?B?NHVWNXJjVzBIQTRGZ2VsVnExb3ZqaHlIT2RlZHh5bkhQUlgrOTliemV0MmxG?= =?utf-8?B?MGI1dmdINU44VVd4L0UycFNEeHNQUEF2V0ZUNTRNRElhc0lCdnZVdTJnejJa?= =?utf-8?B?UmJSdE9vVGZkYm8wUjQvSlMrY3VhTGoybXhISVRVZWhPbFlEMHl2dkZ0QjJS?= =?utf-8?B?Ty94R2JNSThjbXFla1N0VENubUVUU3V3VDFndFBjTzlaa3NpcjlBajRGbVNH?= =?utf-8?B?QmtqdkNrVzR6bks3dzViMTdRM0k1NDNuNzdmTmM1WU1oWWpnaW1tRDFsMkZB?= =?utf-8?B?WUNwK0JwQUYxMVgrVXJ0QnR6eVJXdjh1YXZvbUY3Ukh0QlZxNWZvY3FOM1ZI?= =?utf-8?B?c1c5Y2RQWG4zZ1o5RnhPc2M1aFFTWS8rK3VGZm45T1ZqdlkzUFhHV1JObS9h?= =?utf-8?B?aXVHbnJGV2ptZHVobHJoLzJwZHVRbSs2RVBIa2dweTVSTVpwT0MwcHV6c2dT?= =?utf-8?B?dlk0M245Sk14bGRRR0NpRjZCNjF4cUh0RlFQTXVKcGJETEVVRXFxSUo5RzhU?= =?utf-8?B?Nm1JQUFpc2F6dEFuU0c0Rzd6VUJKQm1BbGZxekdaUHR3M3ROUVIrc1gveHpX?= =?utf-8?B?WDJ1dGZROE1PTVJLWE0wQmd4VVNjNUNnMjEwaHB6UzhKSVQ4QmorTVRIQlh2?= =?utf-8?B?bmtRQm10RmM1aVBGdHJTRzJhd1RwSkhxdGhqNkxOUjl3V0JLWFhHZ2ZSelov?= =?utf-8?B?VDdmc0FOQXJJcHFoVDdOd0FOdTFlSkRGK0dZWHl4NnJPYjNNWE5XUFllWUN3?= =?utf-8?B?L2tIUFBKM3hQK1JNV1AzSXQ2ZTN3YzdTUFhQMXd5b3U4ZFlMU0RTS2Q3MGlP?= =?utf-8?B?c3dxWDZZanFVQUJZNHozUDk2S3U2QTJsek1CaTRySVFWd01oSUVtSHdPMjI0?= =?utf-8?B?ejJYdFZDb1hYb2Q4Ri94NmJZdUtmN25xQzVzTHpzVGtXekVNRU8wV0FRWEVi?= =?utf-8?B?UXNrMjdwTGNsWlgycGFVdkNEU3JNanNwems1Mmh2bU1sTmNaUTNRbnk1bWM4?= =?utf-8?B?T0NYdklpWHFrcjkvUjBPOTE3RDFUZDU0aUhOTEJDK3g2RU5tWGQ2K1RrNTU2?= =?utf-8?B?Nnd0TU9Xeld4Uk9NM1pESWNRc3ZPY096RWFVVHVWMGpPczY1WkdiSUtBYm5I?= =?utf-8?B?YzVUaklPa2FxejdwQk0yL3NQV284NHJWS2gvcWZIU0xtbklad0R0aGp2bW04?= =?utf-8?B?dk9jSGJUYlNmQ2VLU1ZPL1BCTU5nTElnQWtpRVk5aHBmbGpoU0k1K1hoMXIx?= =?utf-8?B?VjErdHRzN3hQVzViUEErYS9icXJDQTBVSmY4WHIxLzNtKzVJSkxNRmVlK3NG?= =?utf-8?B?dmx6Y1hBdEVGQVlkYkVXSWVOQVhiT1hvN2NROVhrMm51Z3RNU01ZdE1FNExK?= =?utf-8?B?SmVRMVNSZUdxazRyOWl1Yjc5dWlPM01FLzFPMEo5dGJIaDBzOElZSmM2QnQ4?= =?utf-8?B?Wi83eHhoMGRtaGZ2THVqNDFrL3hUTFhVMGVMaEYyQWhTVURnNlhuQ2FRaWZa?= =?utf-8?B?YmVQeXdCZWJaUmZ0V2xtZFpFZmxYNVB0QUZyTUZDODBVajB0ZzdiVnN2djIv?= =?utf-8?B?N0ZOUGtQL0lEL1ExcElubFNQNjRSWGwvQ04yd3ZWRUZHSkx1UHBRQUxHUGEx?= =?utf-8?B?bXF0RGZJd29Jb2RBQXpmSEdQTzNJYkhCL084OEVnQkZEemNwZHhhNWJSODEr?= =?utf-8?B?SmczZkZWRG9CZUpMcERkRi9KbXltVGtDNjBLQnpISmk1VjNoZzdUeGQ3ZHRN?= =?utf-8?B?Qm9qVzd3OEtpV1RJL04xN2JZTVEvdzVvbFlXbXFYL1N5c3BLWEdxQXROendU?= =?utf-8?B?OXR2U2ptaU92NkpzOXd2QXIzYXdiWXR6enBYOVI4VFRIMzNndDRJbUVnQTdH?= =?utf-8?B?cHcxODBYUzhDTVdoc3hOZysrc1dnOXRudVVrajVuR0FvUFZCdEwyTXRqR21u?= =?utf-8?Q?vUbge1OYIpF8xNEPT3+YXYmkh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a7e8ecd-bff4-44a1-5669-08db102857ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:16:06.1205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b+iE3hmCkjVPc/pqhQWvmpn4mrb2SC3fY3ZPzwd8UQVF310KZPWmwx/WVydUFElAfZgPFNF5ZaiRkNwiermabw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8921 On 16.02.2023 11:55, Andrew Cooper wrote: > On 09/02/2023 10:39 am, Jan Beulich wrote: >> Consolidate this to use exclusively standard types, and change >> indentation style to Xen's there at the same time (the file already had >> a mix of styles). >> >> No functional change intended. >> >> Signed-off-by: Jan Beulich > > So I suppose Acked-by: Andrew Cooper because > this is an improvement on the status quo, but I have quite a few requests. Thanks. I'll be happy to carry out some of them (but the sheer amount makes it so I'd rather not apply the A-b to the result). It's always difficult to judge how much "while doing this" is going to be acceptable ... >> --- a/xen/arch/x86/include/asm/msi.h >> +++ b/xen/arch/x86/include/asm/msi.h >> @@ -66,15 +66,15 @@ struct msi_info { >> }; >> >> struct msi_msg { >> - union { >> - u64 address; /* message address */ >> - struct { >> - u32 address_lo; /* message address low 32 bits */ >> - u32 address_hi; /* message address high 32 bits */ >> - }; >> - }; >> - u32 data; /* 16 bits of msi message data */ >> - u32 dest32; /* used when Interrupt Remapping with EIM is enabled */ >> + union { >> + uint64_t address; /* message address */ >> + struct { >> + uint32_t address_lo; /* message address low 32 bits */ >> + uint32_t address_hi; /* message address high 32 bits */ >> + }; >> + }; >> + uint32_t data; /* 16 bits of msi message data */ >> + uint32_t dest32; /* used when Interrupt Remapping with EIM is enabled */ > > The 16 is actively wrong for data, It it? The upper 16 bits aren't used, are they? > but honestly it's only this dest32 > comment which has any value whatsoever (when it has been de-Intel'd). > > I'd correct dest32 to reference the AMD too, and delete the rest. I guess I'll simply drop "with EIM". >> @@ -94,35 +94,35 @@ extern int pci_restore_msi_state(struct >> extern int pci_reset_msix_state(struct pci_dev *pdev); >> >> struct msi_desc { >> - struct msi_attrib { >> - __u8 type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ >> - __u8 pos; /* Location of the MSI capability */ >> - __u8 maskbit : 1; /* mask/pending bit supported ? */ >> - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ >> - __u8 host_masked : 1; >> - __u8 guest_masked : 1; >> - __u16 entry_nr; /* specific enabled entry */ >> - } msi_attrib; >> - >> - bool irte_initialized; >> - uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ >> - const struct pi_desc *pi_desc; /* pointer to posted descriptor */ >> - >> - struct list_head list; >> - >> - union { >> - void __iomem *mask_base;/* va for the entry in mask table */ >> - struct { >> - unsigned int nvec;/* number of vectors */ >> - unsigned int mpos;/* location of mask register */ >> - } msi; >> - unsigned int hpet_id; /* HPET (dev is NULL) */ >> - }; >> - struct pci_dev *dev; >> - int irq; >> - int remap_index; /* index in interrupt remapping table */ >> + struct msi_attrib { >> + uint8_t type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ >> + uint8_t pos; /* Location of the MSI capability */ >> + uint8_t maskbit : 1; /* mask/pending bit supported ? */ >> + uint8_t is_64 : 1; /* Address size: 0=32bit 1=64bit */ >> + uint8_t host_masked : 1; >> + uint8_t guest_masked : 1; >> + uint16_t entry_nr; /* specific enabled entry */ > > entry_nr wants to move up to between pos and maskbit, and then we shrink > the total structure by 8 bytes (I think). The struct is 6 bytes now and will be 6 bytes with the adjustment you suggest. Plus I'd prefer to not do any re-ordering in this patch. >> @@ -180,48 +180,48 @@ int msi_free_irq(struct msi_desc *entry) >> >> struct __packed msg_data { >> #if defined(__LITTLE_ENDIAN_BITFIELD) > > There's no such thing as a big endian x86 bitfield.  Just delete this > ifdefary to simplify the result. Will do. > Additionally, the structure doesn't need to be packed - its a single > uint32_t's worth of bitfield. Like with re-ordering I would prefer to not touch entirely unrelated aspects. I'll see if I can motivate myself to make a separate follow-on change. > Finally, can we drop the reserved fields and leave them as anonymous > bitfields? Perhaps - I can give that a try, hoping that we don't access them anywhere by their name (even if just to e.g. zero them). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:27:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:27:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496578.767397 (Exim 4.92) (envelope-from ) id 1pSfE1-00040g-5p; Thu, 16 Feb 2023 14:27:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496578.767397; Thu, 16 Feb 2023 14:27:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfE1-00040Z-23; Thu, 16 Feb 2023 14:27:05 +0000 Received: by outflank-mailman (input) for mailman id 496578; Thu, 16 Feb 2023 14:27:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfDz-00040R-Hb for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:27:03 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061b.outbound.protection.outlook.com [2a01:111:f400:fe1f::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa7c8197-ae05-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 15:27:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9351.eurprd04.prod.outlook.com (2603:10a6:102:2b6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18; Thu, 16 Feb 2023 14:26:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 14:26:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa7c8197-ae05-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/v6FfiI/7FrdVXBAVsCHaajCCQOeT+O6o8FmZAU+DfhxcKzHkbiwCuShwnlhxrNb8p+OxtYeZfCbTJFmoVx2C/VJqbzRaZzj6riqZ25cCClW95oOb6z07dhxybX1LDpXcdXxDYBeToMyjymfvmKs3DRY2KH+6h4lEDk+WFNP2wOd12COWNSScM9C2d5yKQhRBTZiQG8XkuD+aXoag3TMUCnkU/JsHEboWqw3e/CWXhPJxFGqTBfjf6BOoTA725ixUe2mbXSb6KjWIrMFQzyo79FizHragqQowS090UatZ40jaYlUUzvSrlKAIE5M8nlB133QAPNADilRbQ3prTXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hjaZms3aw/Ub8Y3/Qm89xtSAbiAlHv+A21nsdu3cXV8=; b=FyP2QevatNxyGUSMMBc8q3E3ZkLUyMKouzLgj7N0qKvknSMsaFgqmLakKaXFhPqewSOeWdUm4RzfT/nFEhDBEqp3hHORf2Cty7y7K9XwEcl8HaNSmeC0BJpw4Q6jIHhKgNxKD4NAlgPuPiaG+NkfUrJLCl8N8nbK6zJwONr8occJBQdZDvfFF4VKLWxFN1kbQspaZZ5JmbszYgGKZicaxlccyJTAbMCfWxLyUbCPYtZXlDFdz/W3anW+waBvK7rxw/Bo7ahYtQ1Jp/ArVancqzsuDbpPfp4czhH6IPLzSor22LGDJPDSa1+6Dp915jSRWxUXvmJd2xe/LgyaKA9Guw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hjaZms3aw/Ub8Y3/Qm89xtSAbiAlHv+A21nsdu3cXV8=; b=DTDl57fTEVDMCxKBGLXpVtvxdzaLPy5Hx39lwe680a3nvrenC7X4MQSlr0vrfs9ncPRmd6ZkgyOnV9+OcHxkxOmWmRucm0PryrkapzWPmTkStM7Uj3IVCBuhuNxVTyodefj7X90twzKDoYgS2jwriWSYPQs4WMfgEdzI6rxsspSZepm4xgSP0l/9Ejp0J+Qy8cEKBhS5SXtP7IqXj+qVzjRbyxeupHqR3yegfDMNf53BGEy+qR9vynU+N4gDeP48G+Ee94ujrKW+q/fXjYRKwXGg1PopI40aKnOPoiALswZnwPjUAofne1boJX+VV1wSqZTwvu9TleWkIhBsGIoZ6w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <000badbf-cd94-76b6-1f60-faa720a5407f@suse.com> Date: Thu, 16 Feb 2023 15:26:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9351:EE_ X-MS-Office365-Filtering-Correlation-Id: acbaf292-915a-467b-bb20-08db1029dd59 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +2aEXn9lQw7dTb7vn8UXJz4rbVPHeJEuz1qzDmcfg2qHuipi7bb+s/2iGzBwb41ouvtlqOzVBgVzK+X0mx9lnpvTKIgYlSS/HDawn3L8kzh6/y35mOHKNfI8ank36gPHUOvkMR36J2eyUueTfuQRcPKhbyjcFTxOVw4VPsiWhuXqJPs1pG29RGd6HRhPKXHtxBug6HuKD2t70u3tNU39gtKZFY44VWnP6D6fgSfsKFzJaQzb4WcLkCSZVqMOXK9MD5Kdbb0FKbIZES5q/h3D8dDn3WfL7+vIsqJWpcpeGfzIgsjDqJ6HUWfThEU9NWjZFFzMmYzbf4gE4cF+FiR455b4u7usACV5pZssA6ZcrTy9P9xPnqp9N8TTS7G33n/NoaIOoA2W7v481Iahe/G/34Gh+fwE3Qq706X7j36DhJe0EQQB+IS5mA51wdP57ocyBdWE7PvyOMGJc7d3oOorpfp7dvlZefbZVcgIAaeWu6vby4F+4hGczb9hHLMY0JYRsutv8htqeiM3L/lYX5soCaqXtsNvRpo7K8T1MLdV/tvCHyyWWsB3RAlKGvSheJw5BWki8Oo3iPSHUjNKPGtcenreySQDbaLqCi4YvppccDYLjw98+iJxc8ZWjwY5Y4aJrwb84q1WFq1cmfpNB5QPf5lTMDViSwWD5AJZzTDgyIOAEjJkhgrvNhUbCFCMKuOW2AZ0iq2dWh3BEdzWkXyCeNCxHpl++yVdCDZmILxTEQc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199018)(478600001)(186003)(8676002)(31696002)(86362001)(38100700002)(2906002)(83380400001)(66476007)(4326008)(6916009)(2616005)(66556008)(41300700001)(6512007)(66946007)(36756003)(26005)(6506007)(53546011)(5660300002)(8936002)(31686004)(54906003)(316002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnRLZVl5enl6alExaDA0REJZQlNiVFNFZzBpQkpmZDRQMDBRNGhCenhMcUoz?= =?utf-8?B?TWc0UzVOWW5DTzE0VG9ER2EvSXYrRzBZS1k0Z0d3SUxhRVFnNWpadXhCR0dH?= =?utf-8?B?YWVKOFpNU05PWHlEY0JJMUFPYnBsOXJRWmp0MUYxTFAzU25MZWxkK3hZNXFu?= =?utf-8?B?a0hQbkxLMFpuUGFGR09QVm5NZTlIUmhTcW1ZSlkvN0lWQzRmODVjRFFjLzZj?= =?utf-8?B?dE44Qzc3ZkM2c1NCdnRoZ0d0Nm51ZFo5VE5SRm8zRmZ5N2owSUtNMmtPSDQr?= =?utf-8?B?V3I1OXVtVS9qSXQxTjFqS0xFd1RnVW5ndE9QOG5qL05CMzBXditGT2dvMlRu?= =?utf-8?B?Z2NraUVsa0M1cy9RM2xDZGtOTUg3aUI5UE40d3FzSWUvRFU5ZFZPMmJaMFhG?= =?utf-8?B?VHFpUG9aK3ZLWGd6VkMzUjllSFZqcmJGWU92WWJheVhCR3NCU0lBME5NSWZW?= =?utf-8?B?RSsvS29HUHFlb3YyMGl3REM3Wmd5N3JDbERHZEVkTkFranpSR25wYUQrY0hN?= =?utf-8?B?UEpndVBTb1dEYmdkVVNDckxGYU44OGJkSXU2WnJXSGhyVHdsNlpTd3JjRUVy?= =?utf-8?B?eHA0UGxOZEMrLzJNWnoydnlQYjU3T2ZqaE9xcEs5cFZtREZNc3VBTTFvMm16?= =?utf-8?B?WUovdU44T2NYUjhYVWtXQnBDNmZiQmZaTVl0eDhTbXNhVDFqdnZGRHpITUl5?= =?utf-8?B?V1lxMEFuRzFOaFYvd1c5Qlp0Y2M2bDFVVENCRTR5Q2NWczJUWGxicXNzNFk3?= =?utf-8?B?R3VHTXBnY0pRVlN5M1RoRWs1MzFrYkpEMTkvRFdUYVhNMWRZZGhVekw1SVNW?= =?utf-8?B?ajluMzY5U3A0MHY3VzlTdkh0dTY3N3ZjUVhlZUxmc2ZiR1hLY2lRbHJ2QUU0?= =?utf-8?B?S3hKZk5wSWljYU1ISXhpVVgxRkE2NmpjRnYvME56bHU5YzVYLzFMTHZMRXZs?= =?utf-8?B?Y2ZEQ0VsbnNFY1FSQWhEL0FhTTRHRlVvc2NLanVySGVNUDRSZCtZZVI0RGhJ?= =?utf-8?B?Y0VIZ2hsLzVCOUIyam8wTGVFdmFIcWliTmlMY25ZUmdtczJCanlHSmwrK3Ji?= =?utf-8?B?RFNKSFBKc29lNmErcEV3bkJudmg5SCsydFlnOVZrekpxSHFHaTc0TXc5d0tX?= =?utf-8?B?dVJKd0FlYUxkdDdMMVcvQVlWQkhySlNDcFdCSjhCRTFtdjdoRFhwT0ZYRGpF?= =?utf-8?B?bHlIQmc1VUpMVG91ODRiSm8vTFB4NFcxSFZka2pxSTUwSmdoZGg0T1JHSFA5?= =?utf-8?B?cEZhUFJQOFdzWk1kN3lRSVNkRU5uU09nK1Jyb2UrVkR6S2Q0VlRKS25tUm5t?= =?utf-8?B?R0c3T1NhVGtCNEI2TWlJZzlYTTRPSUtzV0dDOE1TTlBsdWFRMlRqOUR3RTVp?= =?utf-8?B?dUR4YlNWZk11YTgzeTFhVVE1N25ESm9xZzBndUtDcWZ2Wk12SngvUTdXS2Zt?= =?utf-8?B?RUdvUDR4enpXMkd1Z2pxNjVMNWttQ1lKWm9KZ3NGa3hBcGJ4YUQzNzJ1MzJJ?= =?utf-8?B?S1BoRHYxdk9VRENCZHpvUndjOXVYbmszR01GYUlRbUlaY2t6R05UelNrYVpk?= =?utf-8?B?eDVzYmFJRjFuOTNMUVdtOW5EY2E1Vm1oTndBWjkvQSt6L0U3T00yTGZtYlpp?= =?utf-8?B?cUdqc2ZpZmJlKzk2dkg1U1dxM0lrYUlOLzBEbE9uUS9CTVNGTFN1NVZuSzli?= =?utf-8?B?R1U0bWlSV2dnRW11SWs0elZWZmhPWHVlVmVQSC9hWVlFY01uWnVrazJlakdW?= =?utf-8?B?OFE5MEVsQnl6Qm5SZzV0NmF5dFpydjJsZTI5U2dKckhsdUsrekltMzhVY2xm?= =?utf-8?B?d0ZUWmRzNlNVb0JHcCtUWXB5b1FQN3JJcHZoTE43YlRmYnl5VmwyNEJIdW85?= =?utf-8?B?SnBkbnIvREVNcXg3TzB4NlFNdk1DbU9WM3QxVUFoKzVSYXJ0RzJzeDdxQzkw?= =?utf-8?B?ZUN4VDVnZ1R2bGVWT21MMUtaRHJkU0dTdTBRYUR3bnVxQnNRQ09xM3ZCek45?= =?utf-8?B?RXZtekh5MEMxbElHQXdJOElVYXZkd1ZGZkI0ZmFqZTFNVkFyVVhKYUI1RUZ4?= =?utf-8?B?ellzTENHUWh4bFZBajZ5ZkVOOEdtbERFa3g4dTkwQTR2UEQwenYxTTNjcEg4?= =?utf-8?Q?XVsZ/bvDYz1tSUuuxw9VoJC49?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: acbaf292-915a-467b-bb20-08db1029dd59 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:26:59.8593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zTs120t1Y0Lx1LUA8glIby4ZQiLfPspqFcjNemyfi5+xvWINq3pBHnjBh80FsjBqr6UWrMnoqAm0iJc0rvJKhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9351 On 16.02.2023 13:22, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: >> >> On 15.02.2023 17:29, Tamas K Lengyel wrote: >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: >>>> Did you consider the alternative of adjusting the ASSERT() in question >>>> instead? It could reasonably become >>>> >>>> #ifdef CONFIG_MEM_SHARING >>>> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || >>> !atomic_read(&d->shr_pages)); >>>> #endif >>>> >>>> now, I think. That would be less intrusive a change (helpful for >>>> backporting), but there may be other (so far unnamed) benefits of > pulling >>>> ahead the shared memory teardown. >>> >>> I have a hard time understanding this proposed ASSERT. >> >> It accounts for the various ways p2m_teardown() can (now) be called, >> limiting the actual check for no remaining shared pages to the last >> of all these invocations (on the host p2m with remove_root=true). >> >> Maybe >> >> /* Limit the check to the final invocation. */ >> if ( p2m_is_hostp2m(p2m) && remove_root ) >> ASSERT(!atomic_read(&d->shr_pages)); >> >> would make this easier to follow? Another option might be to move >> the assertion to paging_final_teardown(), ahead of that specific call >> to p2m_teardown(). > > AFAICT d->shr_pages would still be more then 0 when this is called before > sharing is torn down so the rearrangement is necessary even if we do this > assert only on the final invocation. I did a printk in place of this assert > without the rearrangement and afaict it was always != 0. Was your printk() in an if() as above? paging_final_teardown() runs really late during cleanup (when we're about to free struct domain), so I would be somewhat concerned if by that time the count was still non-zero. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:49:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496589.767408 (Exim 4.92) (envelope-from ) id 1pSfZK-0007EK-3F; Thu, 16 Feb 2023 14:49:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496589.767408; Thu, 16 Feb 2023 14:49:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfZK-0007ED-07; Thu, 16 Feb 2023 14:49:06 +0000 Received: by outflank-mailman (input) for mailman id 496589; Thu, 16 Feb 2023 14:49:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfZH-0007E7-Me for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:49:04 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bb40a5e-ae09-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 15:49:00 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso4435493wms.0 for ; Thu, 16 Feb 2023 06:48:59 -0800 (PST) Received: from horizon (lfbn-gre-1-210-185.w90-112.abo.wanadoo.fr. [90.112.171.185]) by smtp.gmail.com with ESMTPSA id a4-20020a05600c348400b003df5be8987esm5631000wmq.20.2023.02.16.06.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 06:48:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bb40a5e-ae09-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pbcwOI6QCFT+xxiW7wlkzeD2YXX+nd7ZaVAqHfsbFuM=; b=dOe0xofmqlFsYGTxOMJ75iMCNOkHaUr+dWd3EKnk6nZL8kc7SQxYPBdIIz6Pq2BTBu LE02eOS7KmNJ0gecNTYjPF0Xr5SjB9v9qX+obuVu+RyhMWzBZGtWuonmEih/XRmGvR3X mKX3b63sNH43NbPbN5pO+HxMq2+0LTeMfcGqJLLkf9lvI2mkRvpfIXbCur2pPlBoU8t7 L8zMdsd1+OZ05BZD7qhyxX8TcFQlqI2uDNRGs0z7TJaHfARyb2vtEctLhAe4nU5gt6DR FUcM8Z86eE2PfDzYQAVymNDL+Htj//doLxzs041qu9XWlgj2vkjG3korSkCi1OlwSKBr bvFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pbcwOI6QCFT+xxiW7wlkzeD2YXX+nd7ZaVAqHfsbFuM=; b=8K/U4pS3Zvf0nOw1c0Pnf5DvHB4Ok2/q+ocSFL/3vs+ty4zSGNZ+sU+9cYq1VZ11TO nJfX9rX/8REneYsTGbslijQbuDIrsUDyfUlIbLucOQKI9zaOsZDwqQU3C0uCpwRaUuZm ySMhYmgF6a5nG/GowdPHQ7bme0s6mKl+M9hGlnfK4dA8t73EQPi8NuwtoKo1GWmZjMAD 9u0AUbXvA2IAvXD1HtNW/jNd8g7Nx0Qmi1hePoIhGRKAs+l5fsg/yxDcyo6hQHXhf10x rRnu2IpBi+BndP8l2wPt1N7vfJz6nCObNrOONQPI6PJ4aZr15BM/64E85pb+fKwdWlF/ hzFw== X-Gm-Message-State: AO0yUKX0qGha0/p5HkwbU79fcYegNG7O/U88caaeFmb7nPskRHU2FQJG zGc9WwLmEQVai8jkYaH78qA= X-Google-Smtp-Source: AK7set9vqTDmx23r4clfb/ixU6dBGVMEAyKwi5DBQBPXCkwuNbvHV1BPOxRJV6vQ9ynZlcTBL1D7rQ== X-Received: by 2002:a05:600c:180a:b0:3df:e41f:8396 with SMTP id n10-20020a05600c180a00b003dfe41f8396mr5045161wmp.37.1676558938671; Thu, 16 Feb 2023 06:48:58 -0800 (PST) Date: Thu, 16 Feb 2023 15:48:56 +0100 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Message-ID: <20230216144856.GA2137216@horizon> References: <283a8095-3046-3324-3e8a-8671dc1ee8e7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <283a8095-3046-3324-3e8a-8671dc1ee8e7@suse.com> Hello Jan and thanks for your comments. I addressed most of the them but I've still some questions. Please find my questions below: On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > This commit proposes a new mechanism to query the RUNSTATE_running counter for > > a given vcpu from a dom0 userspace application. This commit proposes to expose > > that counter by using the acquire_resource interface. The current mechanism > > relies on the XEN_DOMCTL_getvcpuinfo and holds a single global domctl_lock for > > the entire hypercall; and iterate over every vcpu in the system for every > > update thus impacting operations that share that lock. > > > > This commit proposes to expose vcpu RUNSTATE_running via the > > xenforeignmemory interface thus preventing to issue the hypercall and holding > > the lock. For that purpose, a new resource type named stats_table is added. The > > first frame of this resource stores per-vcpu counters. The frame has one entry > > of type struct vcpu_stats per vcpu. The allocation of this frame only happens > > if the resource is requested. The frame is released after the domain is > > destroyed. > > > > Note that the updating of this counter is in a hot path, thus, in this commit, > > copying only happens if it is specifically required. > > > > Note that the exposed structure is extensible in two ways. First, the structure > > vcpu_stats can be extended with new per-vcpu counters while it fits in a frame. > > I'm afraid I don't see how this is "extensible". I would recommend that > you outline for yourself how a change would look like to actually add > such a 2nd counter. While doing that keep in mind that whatever changes > you make may not break existing consumers. > > It's also not clear what you mean with "fits in a frame": struct > shared_vcpustatspage is a container for an array with a single element. > I may guess (looking at just the public interface) that this really is > meant to be a flexible array (and hence should be marked as such - see > other uses of XEN_FLEX_ARRAY_DIM in the public headers). Yet if that's > the case, then a single page already won't suffice for a domain with > sufficiently many vCPU-s. > I taclked this by using "d->max_vcpus" to calculate the number of required frames to allocate for a given guest. Also, I added a new type-specific resource named XENMEM_resource_stats_table_id_vcpustats to host per-vcpu counters. I completely forgot the "id" in the previous series. > > Second, new frames can be added in case new counters are required. > > Are you talking of "new counters" here which aren't "new per-vcpu > counters"? Or else what's the difference from the 1st way? Yes, I was talking about that sort of counters. In the next series, that sort of counters could be added by adding a new type-specific resource id. > > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -741,6 +741,8 @@ void hvm_domain_relinquish_resources(struct domain *d) > > > > ioreq_server_destroy_all(d); > > > > + stats_free_vcpu_mfn(d); > > How come this lives here? Surely this new feature should be not only > guest-type independent, but also arch-agnostic? Clearly you putting > the new data in struct domain (and not struct arch_domain or yet > deeper in the hierarchy) indicates you may have been meaning to make > it so. > The whole feature shall to be guest-type independent and also arch-agnostic. Would it be better to put it at xen/common/domain.c:domain_kill()? > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct domain *d) > > return nr; > > } > > > > +unsigned int stats_table_max_frames(const struct domain *d) > > +{ > > + /* One frame per 512 vcpus. */ > > + return 1; > > +} > > As alluded to earlier already - 1 isn't going to be suitable for > arbitrary size domains. (Yes, HVM domains are presently limited to > 128 vCPU-s, but as per above this shouldn't be a HVM-only feature.) > I am going to use "d->max_vcpus" to calculate the number of required frames for per-vcpu counters for a given guest. > > @@ -1162,6 +1171,88 @@ static int acquire_vmtrace_buf( > > return nr_frames; > > } > > > > +void stats_free_vcpu_mfn(struct domain * d) > > +{ > > + struct page_info *pg = d->vcpustats_page.pg; > > + > > + if ( !pg ) > > + return; > > + > > + d->vcpustats_page.pg = NULL; > > + > > + if ( d->vcpustats_page.va ) > > + unmap_domain_page_global(d->vcpustats_page.va); > > + > > + d->vcpustats_page.va = NULL; > > We ought to gain UNMAP_DOMAIN_PAGE_GLOBAL() for purposes like this one, > paralleling UNMAP_DOMAIN_PAGE(). > I do not understand this comment. Could you elaborate it? > > + put_page_alloc_ref(pg); > > + put_page_and_type(pg); > > +} > > + > > +static int stats_vcpu_alloc_mfn(struct domain *d) > > +{ > > + struct page_info *pg; > > + > > + pg = alloc_domheap_page(d, MEMF_no_refcount); > > + > > + if ( !pg ) > > + return -ENOMEM; > > + > > + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { > > Style: Brace placement (more elsewhere). > > > + put_page_alloc_ref(pg); > > This is not allowed when what you may put is the last reference. > See other examples we have in the tree. > I do not understand this comment. Could you point me to an example? I used ioreq_server_alloc_mfn() as example but it may not be a good example. > > + return -ENODATA; > > + } > > + > > + d->vcpustats_page.va = __map_domain_page_global(pg); > > + if ( !d->vcpustats_page.va ) > > + goto fail; > > + > > + d->vcpustats_page.pg = pg; > > + clear_page(d->vcpustats_page.va); > > I guess this should happen before you globally announce the > address. > If I understand correctly, I should invoke clear_page() before I assign the address to "d->vcpustats_page.va". Am I right? > > + return 1; > > Functions returning -errno on error want to return 0 on success, > unless e.g. multiple success indicators are needed. > > > +fail: > > Style: Label indentation. > > > + put_page_alloc_ref(pg); > > + put_page_and_type(pg); > > + > > + return -ENOMEM; > > +} > > + > > +static int acquire_stats_table(struct domain *d, > > + unsigned int id, > > + unsigned int frame, > > + unsigned int nr_frames, > > + xen_pfn_t mfn_list[]) > > Style: Indentation. > > > +{ > > + mfn_t mfn; > > + int rc; > > + unsigned int i; > > + > > + if ( !d ) > > + return -ENOENT; > > + > > + for ( i = 0; i < nr_frames; i++ ) > > + { > > + switch ( i ) > > + { > > + case XENMEM_resource_stats_frame_vcpustats: > > Isn't this supposed to be indexed by "id" (which presently you ignore > altogether, which can't be right)? I forgot the "id". I added a new type-specific resource id in the next series. > > > --- a/xen/common/sched/core.c > > +++ b/xen/common/sched/core.c > > @@ -264,6 +264,8 @@ static inline void vcpu_runstate_change( > > { > > s_time_t delta; > > struct sched_unit *unit = v->sched_unit; > > + shared_vcpustatspage_t * vcpustats_va; > > Style: Stray blank (more elsewhere). > > > @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( > > } > > > > v->runstate.state = new_state; > > + > > + vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va; > > There should be no need for a cast here. > > > + if ( vcpustats_va ) > > + { > > + vcpustats_va->vcpu_info[v->vcpu_id].version = > > Style: Hard tab. > > > + version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version); > > + smp_wmb(); > > + memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time, > > + &v->runstate.time[RUNSTATE_running], > > + sizeof(v->runstate.time[RUNSTATE_running])); > > Why memcpy() and not a plain assignment? > > > + smp_wmb(); > > + vcpustats_va->vcpu_info[v->vcpu_id].version = > > + version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version); > > + } > > Overall latching &vcpustats_va->vcpu_info[v->vcpu_id] into a helper > variable would likely help readability quite a bit. > > > --- a/xen/include/public/vcpu.h > > +++ b/xen/include/public/vcpu.h > > @@ -235,6 +235,22 @@ struct vcpu_register_time_memory_area { > > typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t; > > DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t); > > > > +struct vcpu_stats{ > > Style: Missing blank. > > > + /* If the least-significant bit of the version number is set then an update > > Style: Comment layout. > Thanks for the comments regarding style. Matias From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:53:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:53:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496596.767419 (Exim 4.92) (envelope-from ) id 1pSfdk-0000Yw-La; Thu, 16 Feb 2023 14:53:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496596.767419; Thu, 16 Feb 2023 14:53:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfdk-0000Yp-Ij; Thu, 16 Feb 2023 14:53:40 +0000 Received: by outflank-mailman (input) for mailman id 496596; Thu, 16 Feb 2023 14:53:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfdj-0000YQ-FG for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:53:39 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20631.outbound.protection.outlook.com [2a01:111:f400:7eaf::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b12b7ef2-ae09-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 15:53:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 14:53:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 14:53:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b12b7ef2-ae09-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GbDl79AugHjKy5Kz5RtykojN0LA7JSzRRTk/XU3Knnf3SA8CLPkb0KAozb8jd6B9otnzY+Emmuk1yZlePPZSeJD+M2vG2E9jzdQn46qjAC8/lnyfUxhKvoLD8ztaWLsbSak5ea1fsR2lLIvAQ2gvpu+3pEXBGcQu0LFA1nVysLJzjNBTdglVIVRdZ1ywB2NW+Y2NfjtPEADvaHcj4vtiV+Sh/5RoJbeCJsMKuAPy8CzleR5NYVERdOAZ4NL4ko6tWJkWnhmF7kQlw3+9XiX7CjtUaOkrQEM4LJ6FakWK8Rxghu4hT+BzCdGUhfQ9Jjj8WUpEkKptPme0b4VYvH1LMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JDs2O3VVhyh85GlUhnqv5pwjP1qkQcmxOEnS2XD9Ny4=; b=Kz8OYpv3KlR1WPfC+WJ0+iDd/6os/wuGYb6chjzIqgjowml0cH+frLrqrE+Y597VIVRb7KoJyVvhotJFxlT8QzI6ye7OkTBD/P33H0D+v3k6PAUMjldDRqmEtrkOElQ/bMw3b/P+4ILnstCRS8QIAkPZaecrh8mNybMMJ4A1bGM5tOZk5J7Bp3F0HGqoM0tta3jiA0+0d8EHPbovwTol4P5Rma+MPdDgTHc1DNyD30IfUchnvbleSvDSDvv+a+Fyk3G/2UyS8igNQZqNdkwZI8ajTta2hYJQTchwmUncAnEgz8N+05PjMrU2jvEqnWt7afblzwKV9oq9Ib73jWEMCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JDs2O3VVhyh85GlUhnqv5pwjP1qkQcmxOEnS2XD9Ny4=; b=JLn7xrwa2tj1/YPev2TStv0BY7RqwEoj3zFtihxYV7Xy19NmZBojuhZrPFRig7rr3y6nJU43VYfHVllDXTjpnulWyv0YoQbJfH0+1OikmBFWD4hunt9mwAhBPkNrh9ciOCZuCA3EaYO23XD228qJ5AMAv82i5EX6CBpPY9bEOPbvm73dHSl0Ww9RvBDx/3SeSB+tghe/o9KXfUcIbYA+LkEicfxhk6vnuI0W4mknFOuuhDoarn001i2dRJ/8a2Jk90IQd6xOLklQ+YSPnNQf4GBszoMnHYbVwt3UFyDIAvdNUUy+D83H+7lZWRxMjpaZIxsD213ZvrfjIX9fpYAK2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7b6ee39f-debf-dbdc-5f09-9fc0444070a2@suse.com> Date: Thu, 16 Feb 2023 15:53:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Oleksii References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <068340c3-2a2f-4bd0-20e9-f1dd6fe4bc2b@citrix.com> From: Jan Beulich In-Reply-To: <068340c3-2a2f-4bd0-20e9-f1dd6fe4bc2b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8609:EE_ X-MS-Office365-Filtering-Correlation-Id: 9743e613-f741-47a0-fb27-08db102d94a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zz+Ump6nbHVP38DTwGfX1lmjekqDZM9qgPS2sg6RjfMANQyTZ2Ds4uahuecDuI3EguOssPfhj9rH6TydwCFH+XjNsjsP4e5MGK9HP9ny3x5PwJ2K1HYK2PVSReFKdlmk5us9iP6H7xCq03htOzRQBnDJZFcxeXQSjsBtCNOMz8Le9DsoMLgql//8WrIlBa2nhK0GvJ6BLLs6Deg1F4KPAGl+aSmcTammqy8f67Vr9nDLTx1YjyAN7MCBFuXWi98XCldrm8Pi2+4pBboiaQyJjJpWYhSdgVyyEL11XyKantRlzBsUmTs/Yfn3uRJ2+YV87Pt2sL1XQnmmYTthVcSWAfJQT6USBu+ro9B+hYo6U/nBz8Jb8vvSNF3KfAFBvRHq4/04c+jth1oBy6QWRLpqGfnhCAVhtrL8sSRryQ6VT7M0DfC2aWxMcFNo2FqrpjahSqDAO4nH743VtGm2+dAvestS0/9BSkHRiAWl1/rcwHthGuxp9ZHtpvoV9kvB0fD0P66vBwkRvttXBakB+ftjbJ2h4P7js9Uz56kK/yRj3AhBYaBmgxRXoY+I/iqQgY5SNLuRltlZOPvQFLyxIY4AYCej9zdtrzO8r6n3W4w6NY5pYh1P003kE+p1pl/moQ5r3k9Xtr0LF/8CSMmZ2bgZAFNsEX7KQDcSwAK8z9Sq8FTbe0sLGT9WJcYnvEeFydv1VjL3ltKI7kWJU27biz+jHB9PA7VziPor6RrwGJTgnLNwIO7ND4XEf4uOlhdkaAfu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199018)(66946007)(316002)(53546011)(66556008)(41300700001)(26005)(186003)(6506007)(6512007)(66476007)(54906003)(8936002)(5660300002)(6916009)(4326008)(8676002)(31686004)(6486002)(478600001)(36756003)(2616005)(31696002)(2906002)(86362001)(38100700002)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGtDNlBkMFhiV1JMenB5YXZJc1RtOVVIWWtJbjRNTkYzYnF4clNlTEZsc0FM?= =?utf-8?B?TTZVT0xJYmxzVlZrYW9vTisyQUU3R2pXcERqNzRPSWdFTFRuOW9mSGNBWEFz?= =?utf-8?B?MFNaYnZOeGtUeUs4QUh6dFBnVXRBbGMyeERIdU5VcEUzQUJuOTNScnJsb0oy?= =?utf-8?B?WjllWVloWGdGdGcxOFRlbFFYZWRCTy9ENnpuOU1oLzdqcXBMcDBvNTFvc3Qy?= =?utf-8?B?WGcySnpRSlZ5aTRGQW5VUSt5cWtUL1hhdUFJMnJPeHVCdFFCUGdxdFJoQkVL?= =?utf-8?B?MTg4eDRzTWMvcXdoR1I5ZGNZcG5iNHczdnBSOUFhbUFlUE9rdmplbWtPMkhi?= =?utf-8?B?M042MVh0Z011L3FIWkY2Vm00NU5EYVczQytjWnVGTmJBanRYMWhsMXB3S3RI?= =?utf-8?B?bExtMVF1S09jSVhwWFI1QktmWDY1MWJvc3lYL01oVmRiMyttNzEwblQ1T1BB?= =?utf-8?B?UXA0MnpqTndzcVJicDd0MDcwNU1HWjBjUGVUQldrZXRUVUZsZ2R5SWIzTUVP?= =?utf-8?B?c0JYN0ZxSC90dUNYT1NlYkQreTJHcU81RXpLQXJMZ1hwTjhrcjBwZ3BQTmh4?= =?utf-8?B?OHZYeExGOG1HZjI2d2R5RTZsUk9oZi9YUklkOEFOVzFXazNvWUZDc1haaVFD?= =?utf-8?B?MGxmVTFEcjJEZkZGT0pkQy9iQ29DQjVJcVpnYjlBc3ZiRUJ2a2VPVURwcGdv?= =?utf-8?B?MEtUQ2xGTFRKNlp2UVhHSzdMSGgvbGc4cFA0MnhPWXhsZjRqN21yUU1FS1dS?= =?utf-8?B?bFVHd0VmVlQvK2g5eVRERE8xanFrNTdqczdWZHNsZ0UyYWMwZXRHRUNKTTJ4?= =?utf-8?B?anJWbmswODFFZ1dOZ1VxUHRVbmhKY0pFemk3bVdCV2kvUjF3c0VtQVdRR0M4?= =?utf-8?B?TmZEa1FLbzF3UjlKMmFpSTNINmhoOGQ4VS9OV0hHK0w5dHQ4cElDV1dldDRC?= =?utf-8?B?YmNIdXRUSGlVSlBWbWJ6bGNHcW56ZmQ5M2hHVGt1Rk0xeGRPL0JYUWFJSGZr?= =?utf-8?B?Q2l4THFMZzhwa1p6eDdVMmpNeFFjempNdlkxa0ZSYUZBdDNFaWtqcWxaS3Ni?= =?utf-8?B?Y0NUV0RYUjJ4L0hXL3JBdlYvN1I5UG5kTTRXNjdSeThVVFJoTm00VkZvcnFC?= =?utf-8?B?RmZ6NGp6djRZbFJQcStBZzdTbTJIbFdPODRzRkRyWTBxTUlBdDkzajZsa2t5?= =?utf-8?B?Mkp2cGNlRWllUzNjQU9kRGZGb0VVZUhaWjZmeVBuWmt0UFJ5dzg5RFhRZFRa?= =?utf-8?B?Nlc3bFEyMW9KQmZhNThSV252RUdkL0JHUnMzd3NWU21YNUh2Y3dRNEM0ZnlS?= =?utf-8?B?Ui9lSlFqS0lNTTROakxualJOOU9UbDJZbGF0RllZL0xQdFZNdkVOUENuMDFi?= =?utf-8?B?bnpHL1g1S2oxUk9IUEFvSCtoYzRqYUhXWi9hZUxXcEVZNy9lbmFpaForS2pj?= =?utf-8?B?M3o4UGpyaUdVNHQ3TktJeTBOZDV0Z3BMUDI3SWNlT0daQ1hBbnBaNEVCRkJN?= =?utf-8?B?OHUrcEpTVmNwVnNVMmx1UlVDRnhGckp1NEI4aHEvMGtlZXBhaHh0RlkrdjJV?= =?utf-8?B?VTBFa0lnd2VmeVFuSGtMNUR6aUJaUktQMjZUQnpNZTkrZTVKeVZHdW50djNG?= =?utf-8?B?ZldudndYMnRReWx4REVCZ1c3MGdLdlRhK2ZlcEZzUUEyWXB4eEI1UkdpaGk4?= =?utf-8?B?SlN2c3VMOUtwRDh1VlRVbVc5MkVRVXNkN1M2RWxvakY3MEk0K2V4NThoL290?= =?utf-8?B?NEZ5WDlzbTFiQ1VMaWR1Q1V0M01SSjg3TnRSUnNUcVlYbVFTbEo1a3ZvU1RI?= =?utf-8?B?VDU2dlNINUNFbGZlWXJGc1pRbC9vT2VNSTNKUFRxY1huZ1J6aDY3U2ttcysy?= =?utf-8?B?V1MrUjgvZk5vYlpqSlhNZklLZWtVdlpvYStnY09OYzJnK0w2U1NydXd1Szl0?= =?utf-8?B?SUFDU1V6NkNMbzdGaEozVlg5OFd2NGZrdGVhMGlVQTA5TEhsaHZHbitkWnhk?= =?utf-8?B?VUxJMDY2Q1NIemRQdWMxNmFReTNKTGd2Y09xUnE0RWQrTlUvOERBUFhXcnow?= =?utf-8?B?NGZoSzVFZCt1d0JoNTlDUjM4M2creW4zcWFGdXFPaGFGWFBvUFFJbVR4Z2Fz?= =?utf-8?Q?zxxOQRcSopd6OUKzyqEp7b2Bg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9743e613-f741-47a0-fb27-08db102d94a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:53:35.8213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pi0eEZdNFMAhfIQGcxZ2wnOIye4gbTqxmUMv4O9Ga5Vjc9ht2VTAgzjwWF9OBGCQh+ISWHtwt5ShV1DHB+Otsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8609 On 16.02.2023 11:48, Andrew Cooper wrote: > On 16/02/2023 7:31 am, Jan Beulich wrote: >> On 15.02.2023 18:59, Oleksii wrote: >>> Hello Jan and community, >>> >>> I experimented and switched RISC-V to x86 implementation. All that I >>> changed in x86 implementation for RISC-V was _ASM_BUGFRAME_TEXT. Other >>> things are the same as for x86. >>> >>> For RISC-V it is fine to skip '%c' modifier so _ASM_BUGFRAME_TEXT will >>> look like: >>> >>> #define _ASM_BUGFRAME_TEXT(second_frame) \ >>> ".Lbug%=: ebreak\n" >>> ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" >>> ".p2align 2\n" >>> ".Lfrm%=:\n" >>> ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n" >>> ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n" >>> ".if " #second_frame "\n" >>> ".long 0, %[bf_msg] - .Lfrm%=\n" >>> ".endif\n" >>> ".popsection\n" >> I expect this could be further abstracted such that only the actual >> instruction is arch-specific. >> >>> The only thing I am worried about is: >>> >>> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >>> [bf_type] "i" (type), ... >>> because as I understand it can be an issue with 'i' modifier in case of >>> PIE. I am not sure that Xen enables PIE somewhere but still... >>> If it is not an issue then we can use x86 implementation as a generic >>> one. >> "i" is not generally an issue with PIE, it only is when the value is the >> address of a symbol. Here "type" is a constant in all cases. (Or else >> how would you express an immediate operand of an instruction in an >> asm()?) > > At a guess, the problem isn't type.  It's the line number, which ends up > in a relocation. Why would that be a problem? If there's a relocation in the first place (not because of the line number, but because of the other part of the expression), then it would only alter the addend of that relocation. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 14:56:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 14:56:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496601.767430 (Exim 4.92) (envelope-from ) id 1pSfg4-00019g-36; Thu, 16 Feb 2023 14:56:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496601.767430; Thu, 16 Feb 2023 14:56:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfg3-00019Z-W4; Thu, 16 Feb 2023 14:56:03 +0000 Received: by outflank-mailman (input) for mailman id 496601; Thu, 16 Feb 2023 14:56:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfg2-00019T-Jr for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 14:56:02 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:7eaf::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06c76fb5-ae0a-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 15:56:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8609.eurprd04.prod.outlook.com (2603:10a6:20b:424::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 14:55:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 14:55:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06c76fb5-ae0a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MwDq2hjqYDyk1MiFppVbfNi29k1dan5AHlpT7Xrk/cyJ4s0I2VIMAs0Y1JUJoxmPHi7/ygcalgGKYw2BAXurbi/kRD+s8Z3mRoFTdq1qA6tMHWQwVUr7EeJUIBxlozvEXX6U4WtLP0VldpWaQlR/EVa0Bhz4sQWu0Y7xmWodm2Tyvdq84wz252EgK6Htjyhx4xG6Ku4n+cWsvBtu9NJOYX8q0V0BmeICfuISUD+FF6hwSX84NgTVRWNOjPsyqxWJtHvaVcQOFin/83m2KCF4CtnnVF/KT8ESXTxItwVx8xYMz1xoSIKMilX10FBWkVpmVmsgCYxVRpIaW/MvMJNYlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k+idfS9v1qLA8l3q1lWtl+G91cvYeHNlTIRrzXeMpvs=; b=X9S+eKdSFJhdnO434SrHGaIgvXJYH6LVAlkwMFGOaThgzdvMBAnaHX8SV8VaKfED2+ymDtQU3fJFfXHL95vczQRKMN+19qXQ5LiEXeaayf7QGlCFD8TvDQTO1gB/dGbty8NWO6T2jKL7mRRniBAng58eZgwa/SMGbYvXPTIpbHdu7nxhiiRcz1wp7KIz3lpy9f9CCgfXDF0e05LkNkcTqCgaKPHip11C0f4Bo4ggXfGFlx/SQOgxLMbX68XXRBv7NZFMTQuhv0de64IgvcLVx1uEQtlS0joBoEVcP2kdIti6YTNe+zlv1bmP7DpHvw87VNBb7zI4GjPrKO4YYDHOqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+idfS9v1qLA8l3q1lWtl+G91cvYeHNlTIRrzXeMpvs=; b=UI12e1JoRwbYexwfwlTT5aAgyBNtWEDkmt7DLmKQQCxb1SduyfJ+VDiTMonz8P1h6tzWdnidBbO6WepJD8LemOqJM4kLTPH+GTbHm8TFMgbby6aWdsT89ABiGG5g/SoghIL+mv4tPMA/RG6ANzvfbQZcCSgwXOSNCwQUntRZVCVBNY8SzVKoMjSccLRqn/DCTAqs6UKY3PVUweKANPJ5aco2QV8DWajFOIHGEY2ud3pohT4ITVQNlvuaBA9SNTxEHeKp8JDTgYRrPXt7QaUufbZ4h1QTBLPWAsBPuCZQJCGarJzslB5pRmELWrDNCubm5zklY1AKfWDoSbeHR4KFnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 16 Feb 2023 15:55:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> From: Jan Beulich In-Reply-To: <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8609:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ce41bb2-6f8a-482d-c686-08db102dea03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2AP67Sk/2RYZiMopBU0eGEv+3hDPS8qlFbPbHOGj/3IDw/FJSlGrw6UAtg8JsGFdiGhyFBpusILO+9I1jQ8oYfB0ItR9kk4d+BkrXhbILjQGKGC4Fg/BbEOkUYFLEVXapxMODsgoFHt5efO+qVl02gP1j0jg3hDsZXDrafu/rX1uQyOMCcdp4K/LlG1UwUwLPWkf2T9c2xYwzvwMzCv+EHIKWx/Q6tcqlRt1ay1hhVJWVehPwxWgOZm4bCXe0BsgRudjV8BiFpT25omHNanaZbYlu7tIVU++dZl1PIopkIqT/pMeOFk9pdHHLLOJZUuWdmJExKH/5YqhnawOGrkvkldrFXtancn2MfH9ET0AmXTsJsnu3ZL1TDJPe7mNhXCyZPzHo214WAPB0dCGW8F1VZdEoZrb3wTS5GSueWotj9Jj3kJsXuwKf8hHxGocgPFfzDsijVmGi6RHVNeJ5p7pT7ecdnLO7wLvuO04EnvESfVkOScD8aAgZRZyZBv0DypFnNDQUdGCyM9zjy6Ak9LvuSBTc+7mSu7LWvnOrt5LkiWU05pZqCwmxFIPUyrsQ/4BeIA57Sc8b38tSzr7DvVyonfbOojr808xj5g8xN/kPuWy3HiGYiQ/5oc0A/NHcnG+PRyVScMTPq8TTaDnUVcziuN+ydZbGwtjg+EFBTj81h9RWZZBZn38COlvuiGM6VOcv/iUH3WIOXAy+/M/3DaVTzznQ9I9tTQ9xsqG9y6s7z3knsbeFMPsuGb3o/2cx9i X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199018)(66946007)(316002)(53546011)(66556008)(41300700001)(26005)(186003)(6506007)(6512007)(66476007)(54906003)(8936002)(5660300002)(6916009)(4326008)(8676002)(31686004)(6486002)(478600001)(36756003)(2616005)(31696002)(2906002)(86362001)(38100700002)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0QxV1hFSVZkRkRWdGdqa3JqbjNJWHRLOE9sZ0hQZzNvenVUNjhLT0tGdW9J?= =?utf-8?B?a2RWcnFvT3VSTC9WV0RLR1JqbjJYeVVqd2RLbnZwTmJTYkt3MjlBZzY5MEpG?= =?utf-8?B?N0kxL1NVaTQ1M0g4L25hSUllK3BBeHFCRnhCRmFnVVJkZHFDdW9talJWS1Nn?= =?utf-8?B?ZFk3QnZHZWpqV2s3Zk5WZ3lJUlRKLzY5dmZFaklaRGM1QVgrZ29aUTQrV2dn?= =?utf-8?B?ckMzUmEzTjVBRG5FYkhhbHJkQ1NYV0xhbDF2SU01cUMrSmIrd1VMVTFLWVlZ?= =?utf-8?B?L0VlTHVBKzhQRU5pY3dYZ2NSUnpCV3lDNUVKaTRTN1YyOER6cDZIRlNQN0tx?= =?utf-8?B?bUNDVTd0bDdFaWxOVnUvNm9OMVljbzJicGNEQXAyNS82Mjc2eUgrZ2tobFhn?= =?utf-8?B?REY2ZjJFbkFPOUNHdXlOL0Y2c3lqUHBkdlJodzFISmVpS1A4bTUvbldtRGR4?= =?utf-8?B?R2RVT3I3czQ3VjRiLzVRVVBrTk8zVndOZTdueXQ1alBaR3E4aUtJdVMwdGNL?= =?utf-8?B?MmRBUWY1M1NseStGaTBmVktFamVuMnNtYmtEd1Uzd1NVQVN0dk9LQjRSL2JI?= =?utf-8?B?U3pubmZmV2VKZjJseElWSUxaSzRNN0xDN2pkN3RmeVhpeHNLNFZtcG4vVDZD?= =?utf-8?B?MXYzZmJINkpzaEd3OG9sYjF1VWp3dnJoTXBhVUs1RFJEcWhWZkZPd3RzcTc2?= =?utf-8?B?bEpkb1AwdFVHODN6ZExqMkJwbTBNWTFPT0U0a00zM0NPTE8rWnQrL1VFWGQ3?= =?utf-8?B?SkVxaVB1Q2FlNXViaE4rK01uY29FbE42UnlkaStIdWs1dE1hMFhUWjJsSWNk?= =?utf-8?B?Ym9za25sMXJreExTUTE5VWZnbUVZcDNIR2k2UGxwUWU3a01SNjE2MjBGektq?= =?utf-8?B?UktTWGdPSlBBbW90Yms5NVVjREZacGJ3UCt0RHpKeDBLSnlzejVqVmpnVVZk?= =?utf-8?B?emJzMnRnZTFUN3pmTVdmRXBLQkRzVzZBbU5WSlB0MjQ5UVZRdXZSSjR3bzg0?= =?utf-8?B?QTJFZGpYV0ZHY2hqNUtFR3Iva2xpa0RZeVNPdFpRYlhQUjhFeEIva0g2ZnVS?= =?utf-8?B?aGltVTlSdCtnVWZnc3RYcTIremlGK1BvQWhZUVVVSk13VTB5SjlQLzlXc3c5?= =?utf-8?B?bm1rSHB6bkhuQnJySEZYTUtOQVF0bDF5UlJBbXVELy9YK2xleURWT0duaWtp?= =?utf-8?B?U1FZZGYrVmNmSmZ0T1o2OFd4aXl6Vm9IY2FTdUFmT1cycGtaR0ppVlA4RWNZ?= =?utf-8?B?UStoMXJLVjBJa1Q0YkFORTh0cnlmTytKWEdLZ21CWWZDQ1VGUFBobWM5NFQ1?= =?utf-8?B?N25tV0ZRR0VwbHFSWTJuRlQvWVNEUU1pYVZodWtYQ1I3WW5BejhJV2E4SHFu?= =?utf-8?B?NGlpaTltQlA2bU94YkxkR3FNVHczOGlnTWxjWnZxdExQczNRRlpTcVNKQmlN?= =?utf-8?B?c0ZSNy9waTdURUZ0bnZGR0FlLy93a1ZFaTJVNkhCNkcwc0RpM3hqTit4NVZ5?= =?utf-8?B?ejBBQXhNUjl4RUkxUWpWM1luenJwL005V1IvTzVtUXBOQmk1TlM2M3plT3gx?= =?utf-8?B?clhPVWNSSVhzY3BmUkhHOHFLZnpSTmFvTE1UWjRHdFptSXBoK0VPaFJ4c3kv?= =?utf-8?B?ZHdha0Q1dXZObDdZbFI1OU9NQng1SncyNzFiT2FkK0RZQVIrNnM2Y0J6c2ht?= =?utf-8?B?VXM1Z1liT0daNlFvU1MzOXNiZ2tPZWFxQ1doczU3aFo3WXVuY2hvMDZhTFl0?= =?utf-8?B?ekliVHZ4V0V4dlJzRkZWNnpXR1Q0NlRLY3hxSmhiRXBveTRRTVVCVUlJV2RU?= =?utf-8?B?UHpMUDBwb0ZoV2JxS0hoQXBDaEhkWUFhcElIUGg0UThSSlo0VFRWZ0czR0J0?= =?utf-8?B?cDZnakcxcG1DYURXMmZPVmxBVFVSV1F6SmhGM1oxNnNlejVKSkJyZ25ZckF3?= =?utf-8?B?WG51MWI5Szc1YXNaMmpMTmJLS3dJcUVWcXc1eEZGa3FFRVg5ZGxWbE9SM2Zq?= =?utf-8?B?Um9ML1BkeWJ0eDd4dnk2VVdSVUphREtPL0NHcExYaG1nZlZ0bjR1UDB1VlNn?= =?utf-8?B?RDVmSTBxNUhJa0VnZXJoRHdmNUQyeU1pSUNBVVV4azJmTWNRTTNkL2V4VWt2?= =?utf-8?Q?2aYK4q1vHRC2k2lUB7TIJEABO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce41bb2-6f8a-482d-c686-08db102dea03 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:55:59.0933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YyvSCubF3q0ukTWx/YrU4Fb3Vkf/8IQWcUfRVhmf8P03Sr5j09GmysOgF3t03pvtPNAu2KDjcMn76Q+Q3A0cKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8609 On 16.02.2023 11:44, Oleksii wrote: > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: >> On 15.02.2023 18:59, Oleksii wrote: >>> The only thing I am worried about is: >>> >>> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >>>   [bf_type] "i" (type), ... >>> because as I understand it can be an issue with 'i' modifier in >>> case of >>> PIE. I am not sure that Xen enables PIE somewhere but still... >>> If it is not an issue then we can use x86 implementation as a >>> generic >>> one. >> >> "i" is not generally an issue with PIE, it only is when the value is >> the >> address of a symbol. Here "type" is a constant in all cases. (Or else >> how would you express an immediate operand of an instruction in an >> asm()?) > Hmm. I don't know other ways to express an immediate operand except > 'i'. > > It looks like type, line, msg are always 'constants'  > ( > they possibly can be passed without 'i' and used directly inside asm(): > ... > ".pushsection .bug_frames." __stringify(type) ", \"a\", > %progbits\n"\ > ... > ) but the issue will be with 'ptr' for which we have to use 'i'. > > And I am not sure about all 'constants'. For example, I think that it > can be an issue with 'line' = '((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) > << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). Not matter how complex an expression, the compiler will evaluate it to a plain number if it's a constant expression. The only think to worry about with "i" is, as said, is the value supplied is the address of some symbol (or an expression involving such). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:07:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:07:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496610.767441 (Exim 4.92) (envelope-from ) id 1pSfrJ-00037M-8R; Thu, 16 Feb 2023 15:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496610.767441; Thu, 16 Feb 2023 15:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfrJ-00037F-5E; Thu, 16 Feb 2023 15:07:41 +0000 Received: by outflank-mailman (input) for mailman id 496610; Thu, 16 Feb 2023 15:07:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfrI-00036q-1X for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:07:40 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a65e4f04-ae0b-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:07:38 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id r2so2146711wrv.7 for ; Thu, 16 Feb 2023 07:07:38 -0800 (PST) Received: from horizon (lfbn-gre-1-210-185.w90-112.abo.wanadoo.fr. [90.112.171.185]) by smtp.gmail.com with ESMTPSA id f3-20020adffcc3000000b002c559626a50sm1639991wrs.13.2023.02.16.07.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 07:07:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a65e4f04-ae0b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ANFFwi9DGJyiK5BAiCUNxp6zn6Ko4Szul0X7on6YAZo=; b=DM5w8qrm3c8AfxTjYH+3XETsQzdV+AkYtVOztBbLeQRxib1OX+ZBHIcqRIveSJ7eW0 LBUKm+qoN3XeAlyZxfLZ7D7cOaeJR78FMbxVranWbJbhsMQaL+I2EMpvsvwdurqOXPYa s7uihutXrtx/8lfldAnv7U+y02oWlhW+bx2p4KDSh3pa4MhbRDxuHrp0F8qhLn+z4XAm ZZfKKT2l40j2EJvlIOVGdlN/Mesayv1DSTYaDe0O/bWV/7bpJOLToyTz64tM1jpv/guU 8TknH9bHIOwEwrwgqhFedOEmJhmYFzEW9XOKW2q+KuznbvAGpJzdatqQJqwffimSdHFc kcQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ANFFwi9DGJyiK5BAiCUNxp6zn6Ko4Szul0X7on6YAZo=; b=O6uchdk+sA7Qhqoj6PmZzVb6lAmb5HVScrIV7glniMENXBuiW0pgq0pASPSDfIJR7i Nrm5DkRicLTUtIVPUnp1QlGrRTSrbR8Ib0D5bT07iHyMATxPQ7gLmlrbpSFFlfWYLLyb V04/4TGTMge2njGaDx58GlcLYGurGYg16FOdx8KxzAhw7pVw1vyrqC+CBw1zBpoNE3nT UY0/OoT6foXmt2ebGRfAu1mybByp5xWKC4sO4pQYIfPoQ4b7821wr1FRvDruLIhCHJPl JYqtETD0r6gRAXlNTjpANJSMos7XNHe+amlizaMnGFu1rR4xX4oHtwj0CKXCXCOvWSU0 10ew== X-Gm-Message-State: AO0yUKUyYyn74xBE3p3N9rGzCrcpmjKFJiXx+aeukfIb+n20Uq6cwC36 lnlnxQyf7Uij4eqH5ceI4+8= X-Google-Smtp-Source: AK7set9biJ33haA8caNkAWuGrSF7RrR3SwpGtODKlwQ6P/7YoxZyMjIX2lImPCCB1uL9xEIsmfLV7g== X-Received: by 2002:a05:6000:43:b0:2c5:561e:808e with SMTP id k3-20020a056000004300b002c5561e808emr4834240wrx.12.1676560057177; Thu, 16 Feb 2023 07:07:37 -0800 (PST) Date: Thu, 16 Feb 2023 16:07:34 +0100 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Message-ID: <20230216150734.GB2137216@horizon> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > > --- a/xen/common/memory.c > > +++ b/xen/common/memory.c > > @@ -1078,6 +1078,12 @@ unsigned int ioreq_server_max_frames(const struct domain *d) > > return nr; > > } > > > > +unsigned int stats_table_max_frames(const struct domain *d) > > +{ > > + /* One frame per 512 vcpus. */ > > + return 1; > > +} > > Beyond my earlier comment (and irrespective of this needing changing > anyway): I guess this "512" was not updated to match the now larger > size of struct vcpu_stats? In the next series, I am calculating the number of frames by: nr = DIV_ROUND_UP(d->max_vcpus * sizeof(struct vcpu_stats), PAGE_SIZE); > > > +static int stats_vcpu_alloc_mfn(struct domain *d) > > +{ > > + struct page_info *pg; > > + > > + pg = alloc_domheap_page(d, MEMF_no_refcount); > > The ioreq and vmtrace resources are also allocated this way, but they're > HVM-specific. The one here being supposed to be VM-type independent, I'm > afraid such pages will be accessible by an "owning" PV domain (it'll > need to guess the MFN, but that's no excuse). > > > + if ( !pg ) > > + return -ENOMEM; > > + > > + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { > > + put_page_alloc_ref(pg); > > + return -ENODATA; > > + } > > + > > + d->vcpustats_page.va = __map_domain_page_global(pg); > > + if ( !d->vcpustats_page.va ) > > + goto fail; > > + > > + d->vcpustats_page.pg = pg; > > + clear_page(d->vcpustats_page.va); > > Beyond my earlier comment: I think that by the time the surrounding > hypercall returns the page ought to contain valid data. Otherwise I > see no way for the consumer to know from which point on the data is > going to be valid. > > > @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( > > } > > > > v->runstate.state = new_state; > > + > > + vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va; > > + if ( vcpustats_va ) > > + { > > + vcpustats_va->vcpu_info[v->vcpu_id].version = > > + version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version); > > + smp_wmb(); > > + memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time, > > + &v->runstate.time[RUNSTATE_running], > > + sizeof(v->runstate.time[RUNSTATE_running])); > > + smp_wmb(); > > + vcpustats_va->vcpu_info[v->vcpu_id].version = > > + version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version); > > + } > > A further aspect to consider here is cache line ping-pong. I think the > per-vCPU elements of the array want to be big enough to not share a > cache line. The interface being generic this presents some challenge > in determining what the supposed size is to be. However, taking into > account the extensibility question, maybe the route to take is to > simply settle on a power-of-2 value somewhere between x86'es and Arm's > cache line sizes and the pretty common page size of 4k, e.g. 512 bytes > or 1k? > I do not now how to address this. I was thinking to align each vcpu_stats instance to a multiple of the cache-line. I would pick up the first multiple that is bigger to the size of the vcpu_stats structure. For example, currently the structure is 16 bytes so I would align each instance in a frame to 64 bytes. Would it make sense? > > --- a/xen/include/public/vcpu.h > > +++ b/xen/include/public/vcpu.h > > @@ -235,6 +235,22 @@ struct vcpu_register_time_memory_area { > > typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t; > > DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t); > > > > +struct vcpu_stats{ > > + /* If the least-significant bit of the version number is set then an update > > + * is in progress and the guest must wait to read a consistent set of values > > + * This mechanism is similar to Linux's seqlock. > > + */ > > + uint32_t version; > > + uint32_t pad0; > > + uint64_t runstate_running_time; > > +}; > > + > > +struct shared_vcpustatspage { > > + struct vcpu_stats vcpu_info[1]; > > +}; > > + > > +typedef struct shared_vcpustatspage shared_vcpustatspage_t; > > For new additions please avoid further name space issues: All types > and alike want to be prefixed by "xen_". > Should I name it "xen_shared_vcpustatspage_t" instead? Matias From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:10:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:10:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496616.767452 (Exim 4.92) (envelope-from ) id 1pSftp-0004qd-Jl; Thu, 16 Feb 2023 15:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496616.767452; Thu, 16 Feb 2023 15:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSftp-0004qW-H1; Thu, 16 Feb 2023 15:10:17 +0000 Received: by outflank-mailman (input) for mailman id 496616; Thu, 16 Feb 2023 15:10:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSftn-0004qO-UZ for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:10:16 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060f.outbound.protection.outlook.com [2a01:111:f400:fe16::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 032cfbec-ae0c-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:10:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9376.eurprd04.prod.outlook.com (2603:10a6:102:2b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 15:10:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 15:10:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 032cfbec-ae0c-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMxAKk8eIaoITgXRSITXPURn777shLwDdi340fuukL0O7pnAUcfWbtfHCUNJ8o3FgdnT11BUqtlrt9VzpA5ahzx0uhqnkyNI2U1+0cW8pOwlTzR1fgL68dO8TSPtyHac0SsuscWAowcI5lKyt5xcmHHLktIhk1HK2MsN8ygv+gHQzF1iQlOrtxfDP7Wdj5iYxp47+MAswVQYn1eOgupSw4cCq675cfuho20qhYHNq+Lww1YsS40U0JZxyP7TyQUVmO0KIirXmeWMQmb7Did5FesSFORdtIkxEwcaBavESJ+J+NGOCadad0bcp5hRcQ4ZVCeSuXNeVyrizHRlSp4GGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8zktC+YTutI+6oJLdvcWE3CfjXCaj18oHFnrK2D7iI=; b=TAIuH6O63EWoq/DbrVRkgQeik2ZAyb4PzSUKH8mPnSp2T90Ox/g0YYD5M20tXw73oc4KobGTs8FrRxGedZVyWE+iwxJwJFbqEFFxvvwfcLNbAVxeU2QRJ4focwZZp3XtJTGjySA3ab/T6lCEkuWF3RpzeYeuG/NdPJqdI2aZXWBRyRnKgBcP1mk9JO+n+VcNPKMkMV35L52SWrI6ScYzk4ffAlqg7RZ2BHaf1qmFq97Kb6qvhWoN0Tv+W7Lp2fCCms9STKLD2FL/6ykHyFYAMwfHUgHhhpqKddQrsfITcLTWN3ZWf1dkd4hOolDUfqOUQYPjgkMJLx5j/FKv3Ff3Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y8zktC+YTutI+6oJLdvcWE3CfjXCaj18oHFnrK2D7iI=; b=MimMdpEztWPVNY9WXOSAXhuUdtbEM6aDGBOCfWcEGOe8LrZKZQRjm0Uk02+nQpyN2XwCS6dBXbhfK4RYqNELldVpAkDEWurwqKCjVm1OUYSmS1fy7iUJuPpke27mtX1jM/ci1d85JyM6dpRu9BO0L3gH4m3747l4/+ZSzSDua8Wt0P/0blzjvonRv4YeZgJQ1kwITgwha3B7W4dQ8mmWdYBcjbXh1McN95oG5+wH+/TG3VX+LvTq21fQuGfV+tNdsw8BmSs4PVVJvabffK9F5FydpMnWesCbmaY0LUBYI9YXbVkQmZy0HnNtqTP4GeoOGtWLvlt3+N4BPX1F3RZzBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 16 Feb 2023 16:10:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org References: <283a8095-3046-3324-3e8a-8671dc1ee8e7@suse.com> <20230216144856.GA2137216@horizon> From: Jan Beulich In-Reply-To: <20230216144856.GA2137216@horizon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9376:EE_ X-MS-Office365-Filtering-Correlation-Id: c05d4a6d-4d75-4feb-7391-08db102fe592 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMvD5LW8n9cqut69TIg+cfa2uzk4bg0GRmWfOEI6AIF25pio92lYCrTmAxOvBEC8v9+Newkx5c88J0wHIa7Cb4gKiYrrd68z52ZxHFvbkHNbAx2Xxe2JEgmhUEfIJ9j61oDy7hq4Dme61uY4lzNvhO8gZuGjF28V0/5OteITW8kgbADTb/z1/UzyPjBgmPFAnwk3IW/kWe5WBHXfSBz57GrVGb2UJFzulLs8SedmK7wYjSWbGCqoq4f0ErijxeQHROl6vIlqXmmc3oK5q0/SyM6XA9JM3WObHItwonWx6xKPE9ASnjlf0n60rBENfY8cB45WJUjkG1rxoxTMahXg1LAlvNFoiGGU9fkOT3TZ2UTNzh+xS4+hNAEwDQQ1eoNpCzRwX9B9ggmbAJ4KZaznvN13PRflCn7MbyX/AiIxA9VelMKCnL8+ZWAh/nlrN91pV4aRwOx9kJ6q1qUKVAynhjCxUMkvzIno6VZ/fVDp5TFKUdbDRGarL7XSuSp46rI1ji8QWMauSz86R909Va0DP3vsjC04b79YAhXzbL4ihpl6vHh2tQnphXxcpVcKuqCZgQ9AyZ7qOyzjjeBJajI/PkkidQXocVIjyVTG1wwJ0htfT5NfNx61ul5EfGbaRlUdM/r/6WSDy7Wib0gOT6L0Mt727HqrDw7P80vXL9HeaO79FDx3hXTssBiG3G1i6+QMOKCyYHkiZ9owXaYiJ8VNIIhdzzj186+P6RmR4w37K08= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199018)(38100700002)(186003)(31696002)(36756003)(8676002)(41300700001)(86362001)(5660300002)(2906002)(4326008)(316002)(66476007)(6916009)(66556008)(54906003)(8936002)(66946007)(6486002)(83380400001)(478600001)(53546011)(31686004)(26005)(6506007)(6512007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTZySjg1YllyRiszYjl3Zm0yVmdTUlNQWFFmTHpSY0YvS3JYbFRkVGtYMG11?= =?utf-8?B?dDJOc3pvSGkzWldEVlJqWHhNd0FrRXpFRk0xWjVweE5YM0hTOHN0ZFNpNytU?= =?utf-8?B?TksrVXlPa2ZTbGViTEdidkp6Z0ViODdVQUMwSHZVVDJSZVRteEJuemJ3Vm84?= =?utf-8?B?QWxVNlJRZXI4NWUxdVdHcmhQbHZCN2szOVRRU3BwY3hBYlpnS1p5bFNMM2lj?= =?utf-8?B?KzVadEYvMEtVY1g4djZIVkJOK3dJWldxcS9BMStMNXlhczRpT1RwbzIzZ1My?= =?utf-8?B?amhTUldEQmdwaG1BZXJKNk93UW1FNUVQaFFMTzl6M0tWeko4elJzLzFMZTg0?= =?utf-8?B?eUM0NnBGRXQrZFlVaTJ5VkpjSk9hTnpaSmxpcjIvV1paa204dEZjdC8zbjRi?= =?utf-8?B?N2VIY0FzQXlUcWNDeVk2QW1yNkNKVHByZ1VxTVFRcW9yenBjVDcrLzBUc1U5?= =?utf-8?B?WXg3dzlGL0E0ODdkb0xBTjVlbmFRczVUeDN0bnU5cFAxMHlXdFliRXovbDZU?= =?utf-8?B?bGJjZDlTUytDNE1yVS9HZC9hNS8xRkZxRXJiOTR3Qk5Cc2FJbFpsdEszM29z?= =?utf-8?B?RThUbHM4KzltSmhzbklzc3FpV1J6TUl2VTg3YWY0VUZrckFRUU5TaDRHbkN5?= =?utf-8?B?bDhSQXNtRkFkL09oMTZ1YW9vN09uZ3BvVUFRL2JRUjVtMEQ0SlBKZXVySlF2?= =?utf-8?B?K3NZK0QzMzQxQjZBUC9kYm8zNll0VmZ1R0djYXdyNHh3dFVMeXhTNlBrZURo?= =?utf-8?B?TWU5b1dvNU1NQ2ZaejlrbG82RStTMkNTZ2VTV1M5MlRMeGdYak1Fa2I4ZEVm?= =?utf-8?B?V2dSbzUwWUc2OU9Zeng5VDVlVjVyNUd3U2dBdGJIYWU1V2k4d1pKbmNscnlP?= =?utf-8?B?dy9UaXRUempQS3pIVktKSjNTZnZab1A2RDI5bGVITmNqQ1hpS1RRT3oxWmJx?= =?utf-8?B?NVFiTStJZXdQTjIxSHJTVEJSLzlJRy9xOVhlMzk3SUdGaGtmTjhoWFVWYlNI?= =?utf-8?B?SkRqUTFNbmc4Q2d2WDJuL2t6SGF3U3dlcWoxd2hPSWZMRjVlVlhVdUJNOUgv?= =?utf-8?B?RU5GZ3ZJc0FDN3pJRmNsUk1zVEQyYVo5SCtCY08rdTJUcyt2NlA5UlFxTlMy?= =?utf-8?B?M3hCeGZEa3lsTmZPMm9rZGdXWnpaMmZiNUJhNWcrTS9RSE9PRWFsVGMwMHgv?= =?utf-8?B?S3hKL1JORmtaMWN4M3pTK0YwMFh3TEhaamZWNDd3SXM2am92U2NLQVFYdjQ3?= =?utf-8?B?dExrMFNXTm96WlNTRFJsZXZmZDJCOVlHeUVoZmJLODFpWkF2Z0ZuM0ovUGtV?= =?utf-8?B?aWNNQ1BjYkdKMDNEbzhsYkhTOWczakRnTk05V2Z6OG5tTW9sSHhIWmpmOHVU?= =?utf-8?B?aHgydHlKSmtwS2VxS2gxQlR5SjJjamJoRzNBSFgvUjRWVVJkbWVXSmtGUStN?= =?utf-8?B?OHMzNVZFR0FBaHdaN0pLK3dkWmtSNU5YWGdKNVNKUDJ0Qll6bHdKQ1JqVEtH?= =?utf-8?B?YXNCYTFaenFLZVVqQkd6RG9vUExuWlZvUkd5RGVkV0x3OUUxV3p2WFlNQWJ2?= =?utf-8?B?Z1pPTkY2c09KTE9INE5rcldZNmZ4V3VDRWtqZHBUeUVOOURuOU05K3F5T0pw?= =?utf-8?B?UzNqZ0RKRlRGMGdUMEg3dzRVeVlHdng4SWZVbWZ3anBNQ3dtejFvRlExTEJU?= =?utf-8?B?a2xMNmlUV0hGQlZKcGJGTUFKUlZpcjRUY0pqMnVGekMvazhmMVl6cEcwSVN2?= =?utf-8?B?ck00ekY0dXdaMEZnN1ptTDdjdkJjbWE5dWFCdG5YUG9acDFvblptZG1qOENl?= =?utf-8?B?eTVCY2NxUHMydXVUdWpTeGs5MThpR3lsajltVVFRcUtSQVJpbmlMUUdabi9u?= =?utf-8?B?RDJNSTZJL2ZhQ3RaSW9Wa1ZCQzRYenBHdmx3dGVQbXZmcHhXNFp0eFpPVGsw?= =?utf-8?B?TDNUT002bnc0T2oxMSttb0NPV3dZWGdkdlM4QU5Qb1ByamVFR0JZeTJJMGpp?= =?utf-8?B?Q3lJT0RKUkRYNjUyMmpsODlqVTF1OWpPR1l5eCs0dVNpN0tTWDM3U2hHbHdU?= =?utf-8?B?cU85MzhpWW9LRmJlRlB1U1plVE9ETFEwUUx3RU5UWE9sV0s1Y2FYTGFaQjBF?= =?utf-8?Q?osP6RSt7FXwxdTdznMf4uop8K?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c05d4a6d-4d75-4feb-7391-08db102fe592 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 15:10:10.6332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tkF1usALW9JHexge3svsQUai9dcRNtXXpB1HAfqwYEDtA59kr8OxWo248LYT6buo3m8rpse9/demvvuJbRQGOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9376 On 16.02.2023 15:48, Matias Ezequiel Vara Larsen wrote: > On Tue, Dec 13, 2022 at 06:02:55PM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> This commit proposes a new mechanism to query the RUNSTATE_running counter for >>> a given vcpu from a dom0 userspace application. This commit proposes to expose >>> that counter by using the acquire_resource interface. The current mechanism >>> relies on the XEN_DOMCTL_getvcpuinfo and holds a single global domctl_lock for >>> the entire hypercall; and iterate over every vcpu in the system for every >>> update thus impacting operations that share that lock. >>> >>> This commit proposes to expose vcpu RUNSTATE_running via the >>> xenforeignmemory interface thus preventing to issue the hypercall and holding >>> the lock. For that purpose, a new resource type named stats_table is added. The >>> first frame of this resource stores per-vcpu counters. The frame has one entry >>> of type struct vcpu_stats per vcpu. The allocation of this frame only happens >>> if the resource is requested. The frame is released after the domain is >>> destroyed. >>> >>> Note that the updating of this counter is in a hot path, thus, in this commit, >>> copying only happens if it is specifically required. >>> >>> Note that the exposed structure is extensible in two ways. First, the structure >>> vcpu_stats can be extended with new per-vcpu counters while it fits in a frame. >> >> I'm afraid I don't see how this is "extensible". I would recommend that >> you outline for yourself how a change would look like to actually add >> such a 2nd counter. While doing that keep in mind that whatever changes >> you make may not break existing consumers. >> >> It's also not clear what you mean with "fits in a frame": struct >> shared_vcpustatspage is a container for an array with a single element. >> I may guess (looking at just the public interface) that this really is >> meant to be a flexible array (and hence should be marked as such - see >> other uses of XEN_FLEX_ARRAY_DIM in the public headers). Yet if that's >> the case, then a single page already won't suffice for a domain with >> sufficiently many vCPU-s. >> > > I taclked this by using "d->max_vcpus" to calculate the number of required frames > to allocate for a given guest. Also, I added a new type-specific resource named > XENMEM_resource_stats_table_id_vcpustats to host per-vcpu counters. I > completely forgot the "id" in the previous series. May I suggest that before you submit a new version of your patches, you make yourself (and then perhaps submit for commenting) a layout of the data structures you want to introduce, including how they interact and what "granularity" (global, per-domain, per-vCPU, per-pCPU, or alike) they are. While doing that, as previously suggested, put yourself in the position of someone later wanting to add another counter. With the initial logic there, such an extension should then end up being pretty mechanical, or else the arrangement likely needs further adjustment. >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -741,6 +741,8 @@ void hvm_domain_relinquish_resources(struct domain *d) >>> >>> ioreq_server_destroy_all(d); >>> >>> + stats_free_vcpu_mfn(d); >> >> How come this lives here? Surely this new feature should be not only >> guest-type independent, but also arch-agnostic? Clearly you putting >> the new data in struct domain (and not struct arch_domain or yet >> deeper in the hierarchy) indicates you may have been meaning to make >> it so. >> > > The whole feature shall to be guest-type independent and also arch-agnostic. > Would it be better to put it at xen/common/domain.c:domain_kill()? Likely, and the earlier this is (safely) possible, the better. >>> @@ -1162,6 +1171,88 @@ static int acquire_vmtrace_buf( >>> return nr_frames; >>> } >>> >>> +void stats_free_vcpu_mfn(struct domain * d) >>> +{ >>> + struct page_info *pg = d->vcpustats_page.pg; >>> + >>> + if ( !pg ) >>> + return; >>> + >>> + d->vcpustats_page.pg = NULL; >>> + >>> + if ( d->vcpustats_page.va ) >>> + unmap_domain_page_global(d->vcpustats_page.va); >>> + >>> + d->vcpustats_page.va = NULL; >> >> We ought to gain UNMAP_DOMAIN_PAGE_GLOBAL() for purposes like this one, >> paralleling UNMAP_DOMAIN_PAGE(). >> > > I do not understand this comment. Could you elaborate it? The last four lines of code would better be collapsed to a single one, using the mentioned yet-to-be-introduced construct. I assume you did look up UNMAP_DOMAIN_PAGE() to spot its difference from unmap_domain_page()? >>> +static int stats_vcpu_alloc_mfn(struct domain *d) >>> +{ >>> + struct page_info *pg; >>> + >>> + pg = alloc_domheap_page(d, MEMF_no_refcount); >>> + >>> + if ( !pg ) >>> + return -ENOMEM; >>> + >>> + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { >> >> Style: Brace placement (more elsewhere). >> >>> + put_page_alloc_ref(pg); >> >> This is not allowed when what you may put is the last reference. >> See other examples we have in the tree. >> > > I do not understand this comment. Could you point me to an example? I used > ioreq_server_alloc_mfn() as example but it may not be a good example. That's an okay example; what's not okay is that you altered what is done there. There is a reason that the other function doesn't use put_page_alloc_ref() like you do. And I would assume you've looked up put_page_alloc_ref() and found the comment there that explains things. >>> + return -ENODATA; >>> + } >>> + >>> + d->vcpustats_page.va = __map_domain_page_global(pg); >>> + if ( !d->vcpustats_page.va ) >>> + goto fail; >>> + >>> + d->vcpustats_page.pg = pg; >>> + clear_page(d->vcpustats_page.va); >> >> I guess this should happen before you globally announce the >> address. >> > > If I understand correctly, I should invoke clear_page() before I assign the > address to "d->vcpustats_page.va". Am I right? Yes. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:11:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:11:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496620.767462 (Exim 4.92) (envelope-from ) id 1pSful-0005O8-Tb; Thu, 16 Feb 2023 15:11:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496620.767462; Thu, 16 Feb 2023 15:11:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSful-0005O1-QY; Thu, 16 Feb 2023 15:11:15 +0000 Received: by outflank-mailman (input) for mailman id 496620; Thu, 16 Feb 2023 15:11:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfuk-0005Ms-SJ for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:11:15 +0000 Received: from rs227.mailgun.us (rs227.mailgun.us [209.61.151.227]) by se1-gles-flk1.inumbo.com (Halon) with UTF8SMTPS id 2561a5a4-ae0c-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:11:11 +0100 (CET) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by 1b35c470b1bf with SMTP id 63ee478db73c8700b7f308a0 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 16 Feb 2023 15:11:09 GMT Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-530b9a0a789so28350257b3.13 for ; Thu, 16 Feb 2023 07:11:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 2561a5a4-ae0c-11ed-93b5-47a8fe42b414 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676560269; x=1676567469; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=FKVuTGQ3B8oxZrxnnEeLotaCE3qjOVR1G5a49QRLZDA=; b=33GI9LoJsE/v4LQWhjLHQ5q5wAPtB5ovlGZgLQvVUSa4gmVfgKNu533h/c2+/PZMWBzmXrdPzrcSajBY9dlFShEqhgeW/1qVfB6+B+FAZDKk6E37u7TMdKErc2AQQERCXojaVUMUCg3i0vE7hizGLrw4tk/SgFipX1vg5aARfkKjana4NHdfj5sTUXOUnQFRH31S4hpkQEcVQrxvB8t+toy6C/EKRlLikE/jYm5pi2D6PZbGKnzVGa1TWM+KAGjKXi72CapCRb7VPo/oqyxo8HxvCbu/JOcX6imFYN1UULCk0cKy4bl3M1/u4092lWxNfDQqhbzX7gxBPkMDYkq6XA== X-Mailgun-Sending-Ip: 209.61.151.227 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKWTG21vIMiMOkAQXkPcuXw6uM+lcVmJodzHP7GqwzpAk5nn021N GbZRSOJoiyo0kQPH9VRMSqNj9gZv/N1HGLNuk1Q= X-Google-Smtp-Source: AK7set/s2Q8m75pGnKyEEPG7DyZ9J+Oa+z5h32WY7TkB5KyVA9KENx6o59dAseVlIxvMu7m29HUaDBkwKczkjXv7BBo= X-Received: by 2002:a0d:ea4c:0:b0:4fe:5d55:368 with SMTP id t73-20020a0dea4c000000b004fe5d550368mr773620ywe.407.1676560268723; Thu, 16 Feb 2023 07:11:08 -0800 (PST) MIME-Version: 1.0 References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> <000badbf-cd94-76b6-1f60-faa720a5407f@suse.com> In-Reply-To: <000badbf-cd94-76b6-1f60-faa720a5407f@suse.com> From: Tamas K Lengyel Date: Thu, 16 Feb 2023 10:10:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000430cb305f4d29b60" --000000000000430cb305f4d29b60 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > > On 16.02.2023 13:22, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > >> > >> On 15.02.2023 17:29, Tamas K Lengyel wrote: > >>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > >>>> Did you consider the alternative of adjusting the ASSERT() in question > >>>> instead? It could reasonably become > >>>> > >>>> #ifdef CONFIG_MEM_SHARING > >>>> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || > >>> !atomic_read(&d->shr_pages)); > >>>> #endif > >>>> > >>>> now, I think. That would be less intrusive a change (helpful for > >>>> backporting), but there may be other (so far unnamed) benefits of > > pulling > >>>> ahead the shared memory teardown. > >>> > >>> I have a hard time understanding this proposed ASSERT. > >> > >> It accounts for the various ways p2m_teardown() can (now) be called, > >> limiting the actual check for no remaining shared pages to the last > >> of all these invocations (on the host p2m with remove_root=true). > >> > >> Maybe > >> > >> /* Limit the check to the final invocation. */ > >> if ( p2m_is_hostp2m(p2m) && remove_root ) > >> ASSERT(!atomic_read(&d->shr_pages)); > >> > >> would make this easier to follow? Another option might be to move > >> the assertion to paging_final_teardown(), ahead of that specific call > >> to p2m_teardown(). > > > > AFAICT d->shr_pages would still be more then 0 when this is called before > > sharing is torn down so the rearrangement is necessary even if we do this > > assert only on the final invocation. I did a printk in place of this assert > > without the rearrangement and afaict it was always != 0. > > Was your printk() in an if() as above? paging_final_teardown() runs really > late during cleanup (when we're about to free struct domain), so I would > be somewhat concerned if by that time the count was still non-zero. Just replaced the assert with a printk. Without calling relinquish shared pages I don't find it odd that the count is non-zero, it only gets decremented when you do call relinquish. Once the order is corrected it is zero. Tamas --000000000000430cb305f4d29b60 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 16.02.2023 13:22, Tamas K Lengyel wrote:
> > On Thu, F= eb 16, 2023 at 3:31 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 15.0= 2.2023 17:29, Tamas K Lengyel wrote:
> >>> On Wed, Feb 15, 2= 023 at 5:27 AM Jan Beulich <jbeulic= h@suse.com> wrote:
> >>>> Did you consider the alt= ernative of adjusting the ASSERT() in question
> >>>> ins= tead? It could reasonably become
> >>>>
> >>&= gt;> #ifdef CONFIG_MEM_SHARING
> >>>> =C2=A0 =C2=A0 AS= SERT(!p2m_is_hostp2m(p2m) || !remove_root ||
> >>> !atomic_r= ead(&d->shr_pages));
> >>>> #endif
> >>= ;>>
> >>>> now, I think. That would be less intrusi= ve a change (helpful for
> >>>> backporting), but there m= ay be other (so far unnamed) benefits of
> > pulling
> >&= gt;>> ahead the shared memory teardown.
> >>>
> = >>> I have a hard time understanding this proposed ASSERT.
>= >>
> >> It accounts for the various ways p2m_teardown() = can (now) be called,
> >> limiting the actual check for no rema= ining shared pages to the last
> >> of all these invocations (o= n the host p2m with remove_root=3Dtrue).
> >>
> >> = Maybe
> >>
> >> =C2=A0 =C2=A0 /* Limit the check to= the final invocation. */
> >> =C2=A0 =C2=A0 if ( p2m_is_hostp2= m(p2m) && remove_root )
> >> =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ASSERT(!atomic_read(&d->shr_pages));
> >>
> &g= t;> would make this easier to follow? Another option might be to move> >> the assertion to paging_final_teardown(), ahead of that spec= ific call
> >> to p2m_teardown().
> >
> > AFA= ICT d->shr_pages would still be more then 0 when this is called before> > sharing is torn down so the rearrangement is necessary even if = we do this
> > assert only on the final invocation. I did a printk= in place of this assert
> > without the rearrangement and afaict = it was always !=3D 0.
>
> Was your printk() in an if() as above= ? paging_final_teardown() runs really
> late during cleanup (when we&= #39;re about to free struct domain), so I would
> be somewhat concern= ed if by that time the count was still non-zero.

Jus= t replaced the assert with a printk. Without calling relinquish shared page= s I don't find it odd that the count is non-zero, it only gets decremen= ted when you do call relinquish. Once the order is corrected it is zero.

Tamas
--000000000000430cb305f4d29b60-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:15:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:15:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496629.767474 (Exim 4.92) (envelope-from ) id 1pSfz2-00066q-KJ; Thu, 16 Feb 2023 15:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496629.767474; Thu, 16 Feb 2023 15:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfz2-00066j-G3; Thu, 16 Feb 2023 15:15:40 +0000 Received: by outflank-mailman (input) for mailman id 496629; Thu, 16 Feb 2023 15:15:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSfz1-00066d-N4 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:15:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7d00::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c41e528c-ae0c-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:15:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7749.eurprd04.prod.outlook.com (2603:10a6:20b:2a9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 15:15:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 15:15:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c41e528c-ae0c-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sqt018hGQNdhZnOgWp0uuqQ8GHGJvA/2Q+vWcZ8joyBxhcj62kGFCf4s8jytBaMZwFiJd/LI7uJ2XTQLkFFOd3TZf7bz+xbbVwjZjISUJzTp3eVaYXuoAPfB869gAopUMDCX+kzNhmW+J5rp1uhMXV43SqZh2HU5XEXuRR7m4Taqj29d6LfJ87VvHid7Bj0pd/RbnngIh+cUxjsNFhWbIh6xHLgEgrZfeLxfkTJDpzUE0TecY8viGDzW2Ay87+yw+qvhO97zaIxP6bdTYkRqpFpGHnkLl5L5Gx6eB8Kx6WikyeBdhezQLtWZd4pekbiqgOawzho70eDMnW137GMFTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hGT+yRH7i5ZbGzCexLdhZ+NAB8BYdENkuC3u4Hrk6RI=; b=KIsZjaFDt1hTNXh7LjQSk3NR4GC+moOARrwQr9vpM10Wp+k/Phn33pSiikSoZPxc1XMAIRM3a7uE/aXc1yu5hj7rau/Q55iNRVhLyqm0u9dglU/M6z7VM+ULw/iyj2CGG9Molxo3Et7K5VRLzEpG3O3hXIAKR8kOvhICnN2tjMCgc4FgIrvepzikWsjSIZRQy9hkyeKarswesyAUXsIhClhY4HyGN3u15TuWlbft13aJswGqxW09DcqV73B27WA/z2IdHlKz7lDCxOYEI8Leqxuoi/1ugxLdaRoUukWylvXyQkelD9/soQqw94eeov5g/sPfg7uAHB0BZDUJDBLiHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hGT+yRH7i5ZbGzCexLdhZ+NAB8BYdENkuC3u4Hrk6RI=; b=iaNG4m4SUI8XtWYBlpXiFgioeZai9/HoiFVTbQhRww7D9QMYjI4cS1hwJjgPBgXJGhGtY8I0PmuVIJPPdVVBcwtfclmcElWMks6FJguaeqO9kfkgUmVfaGrijpgQ4QnJ7IgvVDPDTrU4XIQ+aPu2HbxEKYEqAdnCB/FLnagTVMxLcKlap+FE0dRW68XnAZWZ/bmoUOlzFvwUZGJybDVAl+PQ1eTOooJfnax97T3s1Dm7hiSC+yJNMx2KjqWOzgKy9tQvMCRvYyqV0ptJwVL2hBH/qpM7e1K/4uSJHDN6QNZu9Ib36tVJuZnQ6jNouA7b99M03ud1MIFZaXe5bbGAHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 16 Feb 2023 16:15:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org References: <20230216150734.GB2137216@horizon> From: Jan Beulich In-Reply-To: <20230216150734.GB2137216@horizon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7749:EE_ X-MS-Office365-Filtering-Correlation-Id: dc31dcb8-0f29-4a3d-f94f-08db1030a4c4 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hl5SCqTSaYaMW5kEve2Qu8mw6prM88rPJysNMY0fhOO2duDrLZvwOSJqP9rz64tLO0y6jS20biKDI7W0APu1rAwXVQ8qRjQfAgwyToI2R1d+DknGIYb2heppl8QjDf3y5mWXeTXL6zUBUKqeqAJkzwP/OekQJ8W7WDNaDLM60fYU89jEktVo5h45ICQHkrjCbOePcESbcDQ7b65494jxztU/7xwM3tSTn1deDBNaPFfbGdfd3yELjsNWgGs1ffIpNZ6lVkMps9IzqTjQZwCxBC+DumCTafNynADhTty1MPUFfABeQYV6mMKIk8yACNsM+pmyvBoda6d4jfUshSXbMMFFOC9RAtznRDoOaAYJhSt3Q6zmy42C5xY2Hj30bGgN65RW/uo17pQJwk6/sHVAkFZNsp4K7Oz3dV5Ki+dYX3ATyH27jJtzbs/JKDa0FJfv2lzJujCQYJP6jbJUfFN0IFAR2gVD7QUxbkTG/aatZES7+QHGqNEqrhtavSqEZp3TURwrhuznLax2+GZd1hgRqSsgqGi8Wg/3yU0rCXh1io0Nu2F8SKCHs5SsppCgOPg1Mvvceww28cz7nQGLv8RbqbCX6UXPKvAdWuJuBpAxfW1ZbNYeuNsSTxxasemZyLCiWGE6JucJrSqfkdTJG6nXwkqS6HNh0kKkR3OUIfg/N9yLT/rLt/Q9OkbCRDSUK2DFYbyLrH2CKsDIiBkSvjrZSFOzWNmqqGWPlxkZGY5crvU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199018)(6486002)(478600001)(83380400001)(31696002)(86362001)(38100700002)(186003)(26005)(6512007)(2616005)(6506007)(53546011)(8936002)(36756003)(41300700001)(2906002)(5660300002)(31686004)(4326008)(6916009)(66946007)(8676002)(66476007)(316002)(54906003)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2hCUnlNMEFqbU1Vajc1WTNOUVphRUl0M2dWVXl5MHNERzMrMm9VdjJuQVpm?= =?utf-8?B?UGNCTVVGZk1FL29WaXIzMzVNc1FkeTdBaGdOK1ZLSS91RXVwTk9FRnN4ZjBF?= =?utf-8?B?OUZuTnU5TXQyOTJzTUZRVnYwaTQreWtlTnNLOVM4M05ZUjlobDI1VXpXY05X?= =?utf-8?B?S2cyTWt3RmxNUnd5UkJaVjB6eWpBWU9wMWxVREVjaVg0ZzVGNG44TlJxbmpz?= =?utf-8?B?bUxEK2g2eG8xRDJmUDNtckwydUFCSHp1MGd4KzVOSUthV1BsTzVVM2h1TDRt?= =?utf-8?B?NkxBaEFxd1FFdjNEV2EvdEVLS0x4Y1ByTUZPTmU3c0EwVnJheldNTk1KN2VY?= =?utf-8?B?OTg5NWc0b2ZUVkxPM0N6akkxWHdENjdwbi9hcUtpSE1laVcxaDhlejJMbFU2?= =?utf-8?B?YVZxc015aXhtT1ZEZ0FCQTR6UFZKNFA0RmtlZCtCbXRINzBIQVY1Y2g1anV2?= =?utf-8?B?VXJHTnFTazR1V1A0VTVoejNMS2RpUnVHRHFocllEb3JaZFExYzV4dzJZZCs4?= =?utf-8?B?Z2pMQnMxWWtVN3dlSXJ4aVdNV3pkdUFXTmxTdjN3RHZtc3JTV1Q2eDd6ZWc4?= =?utf-8?B?Q1JKcHlSbld3VTFrakEwR0I0blFTTVhyUGtpS0QxR2l2ek5Yc1ZJd2pveVBN?= =?utf-8?B?THU1bWVvV2Q5NzFtK2xiL2RBdXVQRmFUYXRIcjZmU1d1TmFnaytZSVd5dVBz?= =?utf-8?B?SmE3TmxQOTE2SFdzakc2Zlp3YnpybXNoTlRsOVVwSExmZzdqWHEzakJGK3Rm?= =?utf-8?B?R2xoWmtNSmFGUE4wd1JLK2VmODFVTUF6eFJIc1E5TXpWR0g2ZE8yS0xIWTE2?= =?utf-8?B?QUhoeDNKcUxKQWxjZ3R3ekd6MHRlZUlST1U5dUlrV010eWRweVh5Y1ErQUJu?= =?utf-8?B?eTZXNjFUbVAyR25WR1ZvT2JJV1cvNjJVWUFpdzgzUWRhbFNMT2lmcDdmZkRL?= =?utf-8?B?UEEzQjhONVNIOVV1TjgxbzRUMG0vM21lNEhHMzIvMytXVVJhYnlkc0owRzNJ?= =?utf-8?B?c2FSREErT01udlZhelNUQmFDRjc0Nmg4VkJ6bnIrL21OMWppczZCK3poSk8w?= =?utf-8?B?VGxiem14NFBHV1ZHK2F3ZnBKbUdiSHRiOW80YWtabngwWS9pbW80ck1xUnFo?= =?utf-8?B?ZVpyTVM0dEJZMldTQzhQTzFVMGlFS1VMbVBnc2lwTmxuOTduMnY5NER0MlYx?= =?utf-8?B?aTFSSGdzb2xsN29jZXdaY0QyejRQZm44cU4yd2JnWDBWVE4zdWJNTUhLUFJ0?= =?utf-8?B?ZlRnbXFkTUdkT0djWkhML1hQSk1hQTFGU2VENG5DN25rUzc4bFF6bjNOTmhI?= =?utf-8?B?TEZSeGN2RnFCL00zSXBUWG1qYWVhQjR5UjQzMkNwVGhoeGUybXFGKytvSjAy?= =?utf-8?B?QXpsTlN4Qkd0YTBDb3c3VkRybHEzQkhoMDJlZ0xWYmsvU0N3Zmp6YmtMVElD?= =?utf-8?B?WEtjQlRVNXJLQVVQbE1BUFlmWkFBYU5aMUt5aktVOC9aNjYxbisyeDdMQVgw?= =?utf-8?B?eHhySlRNbWh6WnRYTnJ2d0hqMlh4L3hmSGt1VGJXdlZGV0JwL2hBbkZSbUI1?= =?utf-8?B?VXR0dDlxY1JkRkZNYXFuVDI1K25UNlpjWmtpeWxpOFBYWG52dkNlWWViQzRv?= =?utf-8?B?dndhTlUyaEZpenQ3SFNTdUhyMWM4UURDTkNZaWhGWkZ2S1FNS0JUQU5CR2Ry?= =?utf-8?B?YmtHSm9LV0tQQ00rL2J2VU5MbUJJbTRpUE0wTk1OVzUvOUpJUDFQZVpaZERW?= =?utf-8?B?a0djcmpTUUZvTHp0NVBlbGIwS3hwQ1lQeVl6RDZObDF5clVhL0hpcjhDNVc3?= =?utf-8?B?NDN0LzhQeEdIT1V1OFQ2RUtBWXFZalRub2ZkNTkwOGFMMkRBMHQ1RVVOeG82?= =?utf-8?B?bDA5U0E1NGNIb09qaGRxVkhjbXpPMXRCM2dTTUFabmt4ZDB3OGpwSENXdi9k?= =?utf-8?B?ajJyV1FBazJ1c2hnOWJ5aUFIZGNVdnAvRzhtZ1V0OHFtSmQyRmhjMmtBK2tv?= =?utf-8?B?OUJuZS9HRmQzUFY4ZEYwSWN0cEx6YUpLU3orVyt2SHJBempXNi9tanFpSWV1?= =?utf-8?B?M1FMZk50enB3WUlOYXd1TDJTOUcyQ3FvV2t0elJ6d0RUZjcwT0pJWXNUTlAv?= =?utf-8?Q?K+m/SC9QapY5iviRbCr2csHOM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc31dcb8-0f29-4a3d-f94f-08db1030a4c4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 15:15:31.3466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OM/d5TZEUXFdQfoTnMszbY7TIbRWw13E6iDezsmGfnp1dGEkOLYUmmM70J6uQDQrrss3ttaLxSaujHcA4tM2WQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7749 On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>> @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( >>> } >>> >>> v->runstate.state = new_state; >>> + >>> + vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va; >>> + if ( vcpustats_va ) >>> + { >>> + vcpustats_va->vcpu_info[v->vcpu_id].version = >>> + version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version); >>> + smp_wmb(); >>> + memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time, >>> + &v->runstate.time[RUNSTATE_running], >>> + sizeof(v->runstate.time[RUNSTATE_running])); >>> + smp_wmb(); >>> + vcpustats_va->vcpu_info[v->vcpu_id].version = >>> + version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version); >>> + } >> >> A further aspect to consider here is cache line ping-pong. I think the >> per-vCPU elements of the array want to be big enough to not share a >> cache line. The interface being generic this presents some challenge >> in determining what the supposed size is to be. However, taking into >> account the extensibility question, maybe the route to take is to >> simply settle on a power-of-2 value somewhere between x86'es and Arm's >> cache line sizes and the pretty common page size of 4k, e.g. 512 bytes >> or 1k? >> > > I do not now how to address this. I was thinking to align each vcpu_stats > instance to a multiple of the cache-line. I would pick up the first multiple > that is bigger to the size of the vcpu_stats structure. For example, currently > the structure is 16 bytes so I would align each instance in a frame to 64 > bytes. Would it make sense? Well, 64 may be an option, but I gave higher numbers for a reason. One thing I don't know is what common cache line sizes are on Arm or e.g. RISC-V. >>> --- a/xen/include/public/vcpu.h >>> +++ b/xen/include/public/vcpu.h >>> @@ -235,6 +235,22 @@ struct vcpu_register_time_memory_area { >>> typedef struct vcpu_register_time_memory_area vcpu_register_time_memory_area_t; >>> DEFINE_XEN_GUEST_HANDLE(vcpu_register_time_memory_area_t); >>> >>> +struct vcpu_stats{ >>> + /* If the least-significant bit of the version number is set then an update >>> + * is in progress and the guest must wait to read a consistent set of values >>> + * This mechanism is similar to Linux's seqlock. >>> + */ >>> + uint32_t version; >>> + uint32_t pad0; >>> + uint64_t runstate_running_time; >>> +}; >>> + >>> +struct shared_vcpustatspage { >>> + struct vcpu_stats vcpu_info[1]; >>> +}; >>> + >>> +typedef struct shared_vcpustatspage shared_vcpustatspage_t; >> >> For new additions please avoid further name space issues: All types >> and alike want to be prefixed by "xen_". > > Should I name it "xen_shared_vcpustatspage_t" instead? Yes, that would fulfill the name space requirements. It's getting longish, so you may want to think about abbreviating it some. For example, I'm not sure the "page" in the name is really necessary. Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:21:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496634.767484 (Exim 4.92) (envelope-from ) id 1pSg4i-0007uI-6c; Thu, 16 Feb 2023 15:21:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496634.767484; Thu, 16 Feb 2023 15:21:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg4i-0007uB-41; Thu, 16 Feb 2023 15:21:32 +0000 Received: by outflank-mailman (input) for mailman id 496634; Thu, 16 Feb 2023 15:21:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg4h-0007u1-6s; Thu, 16 Feb 2023 15:21:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg4h-0006og-3A; Thu, 16 Feb 2023 15:21:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg4g-00044j-LW; Thu, 16 Feb 2023 15:21:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSg4g-0007mx-LA; Thu, 16 Feb 2023 15:21:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r7dt5t/7pNzBoTXvEJvUJsAffgWhKwtTaAyau9rJqHg=; b=rQaZBqRRrR7nA+FQ9v2eWvE0Eb HFzFjIepYXFNxwN17p3y+sH7yVIcnsHT3+wrAFOt+eAymv4uhyDrH8UC1lbPADvks9hw8OV9+Rgz7 0GeQSDWKZrannmYjBK96gmZkqsrhNv/vOMx33v7XwkTy26lIBqAuq8snSyTOeYE+xk/c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177451: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=033c40a89f55525139fd5b6342281b09b97d05bf X-Osstest-Versions-That: linux=e1c04510f521e853019afeca2a5991a5ef8d6a5b From: osstest service owner Date: Thu, 16 Feb 2023 15:21:30 +0000 flight 177451 linux-linus real [real] flight 177502 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177451/ http://logs.test-lab.xenproject.org/osstest/logs/177502/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 22 guest-start.2 fail pass in 177502-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177400 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177400 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177400 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177400 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177400 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 033c40a89f55525139fd5b6342281b09b97d05bf baseline version: linux e1c04510f521e853019afeca2a5991a5ef8d6a5b Last test of basis 177400 2023-02-15 15:49:45 Z 0 days Testing same since 177451 2023-02-16 02:59:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chuck Lever Jeff Layton John Johansen Linus Torvalds Steven Rostedt (Google) jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git e1c04510f521..033c40a89f55 033c40a89f55525139fd5b6342281b09b97d05bf -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:24:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:24:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496642.767496 (Exim 4.92) (envelope-from ) id 1pSg7I-0008Td-LE; Thu, 16 Feb 2023 15:24:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496642.767496; Thu, 16 Feb 2023 15:24:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg7I-0008TW-IQ; Thu, 16 Feb 2023 15:24:12 +0000 Received: by outflank-mailman (input) for mailman id 496642; Thu, 16 Feb 2023 15:24:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSg7H-0008TO-CA for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:24:11 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061e.outbound.protection.outlook.com [2a01:111:f400:fe02::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f53c3fc8-ae0d-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:24:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8039.eurprd04.prod.outlook.com (2603:10a6:20b:2a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 15:24:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 15:24:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f53c3fc8-ae0d-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UeOK4/idlVLvpzCrC14Br1PDH2741/UqtTci3n4Ko0bUTRh1r8OetRZ8FjHRB1lMsusRMtmfALworsdCb0PQl+gwh/SmOEW9OdPhf97O57uruXUtvuTBmJSCw9HIlKWPQIRA/DYbwGLAk/PzEQ9qzMQXS5IxRqgOZ0cLkX7ce6gix1nWmGUrju0XTxx1qVxbAaEXZgYHOQSwI2mZe5tg7Wqy8Dr8VfIi15UeDNjEu4ia8svN5VEASrJFH0Lh4G/snp1jXbnZH5AwmYrvcTmF4pqsXNj5herEqb/I5x+148Fu/E9YIIzFiGBUfq1RBDjX/ZoJHKQVzkFy2O0jp5OGHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g0qGdofkEYviOrkdZJUD/InP9VYRxbIlSPYOpuigEHo=; b=ip9h0/DxuyGJES9uWtTzcrlYlr4m/pj9oFI7JAeGVO6pgiJSv2tc6nsKkBtq/Uii8uhmG58hHf76qbUMlw1AzVVM0zYkSIbhrJYwPpz0LwpC4s8ppFfHxZwwV7ee7GTXPZbLeysKldhpYzLQsuHfuwlD+SLz2HoFyFdsoa2mtwQUVpBQmNac4fSd0f4GOFdKyETJ9/H94muvbe4L11dbF3lO7u42wvyfdwYDIfqJkjk8bybgMe9BHO3nbgt6ugT1XSRfmgfeD8Gzu2wzfVNlxObhdYsoSEBpcM6DBAA9rhQk2RptuhcHPCFqc8X+9vsHIvmAeSETaaVu2uX7qg11EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0qGdofkEYviOrkdZJUD/InP9VYRxbIlSPYOpuigEHo=; b=Bb8DSXHVzAF+AawW+xGDEwpzQZyrshbT+fd1KYJUjmF6JWHLGM55m4kACPUz0763XNSNHISa82P6GZBHpBXBy0o4pgnGD/E0mh0MUUtW2FdU9O/PXhDz6qKDrNLR1g5xeOgP5IysDU3X1jW70aVwSPWtNeYDd+nMjF0P25E/YqdmBBlsS/oF4krlZKF2GLJrbRURrIb2MVmjLQ5vboKONNde2BnT7HYAJDg2oHiRQatlckZBVCGgWWKLFKAEsDAyfPD6d3DDTVHRnEh0FhLKhVImfcXDqWPK9GdlmzHq+WmwylNkoXwIUnossYuLg+E3M60NmjR4qHK2k+EqWpypUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7db3740b-c483-c400-2800-2af85e697de6@suse.com> Date: Thu, 16 Feb 2023 16:24:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> <000badbf-cd94-76b6-1f60-faa720a5407f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8039:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c20e5ae-d444-41ce-fa5f-08db1031d8a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oHIQppzlPe0Y6zbLd0aMxUmF2CcYgWiLHad8fJxqZEIBmfr3JsbLF3givRiLh+rL37pqn0XfphEsF/IdM9waPODp8mWl9OQEv1pEEnEdWesvOlZ/ra9RgAmKbh9w21YLrKLD5xR4/SQkjdCzYM7b/5zXtEaD1s8unf4BOXgRQore9dOsq2uK6/vwN/Ibr1DtGLPobN4Ma4IzuoLGIi1j/DRcZie446WmS28aYwvhBtbjnagHM/hYKmU1khUWsrpQ/tToPtO2W4uN4+7UvclTe4SI2g4JylihQljCn6frn4Yfd2bdfteCUz5A5n78ZR7ptS6HBfUTxlpUXjX/tk0R3ZpmxfkLRijyY+mcsXMso74Tt5eX2JcNcWRBAS/85qxa1xJbNOGdE5KZwQycbRVPnFaxiyOoYeaVUQjDCJllRCekIqbJQIjOOzBl4hwWv0Wgw63xy/nrrE0W0yCZ82RPNFrNATxLSmMTFOtyPDF9e5rmYABVBTwrQ/C+I1lTT/MZ1T3akaNC1GPVmLaCrRX6E/XMuwNgEJDkmFojW6yVXs4b37+eNanj55QonNpLn5mXgCKKc5dB/SOHiJe+b1Lr0roZD4uFXcG4vkABVkbbDAE1DD1Hw3G70XcHBZauTmJTkpql3B4aOEEjYlXaUTVamEH+gRVtAdTIb7Mg0AUVP/Pcv3clTdIUDeOHYLbVRvRMDUJ74am+0mAZtPRwTT6P0CWrgJaoGFaqM2MdWkAyar4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199018)(5660300002)(86362001)(2616005)(6666004)(66476007)(36756003)(6916009)(66556008)(478600001)(54906003)(316002)(4326008)(6486002)(66946007)(8936002)(26005)(31696002)(6512007)(8676002)(41300700001)(53546011)(6506007)(186003)(38100700002)(2906002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkQyQ3VHelJBWUtZRjZvZ2Q5UW5CZmVQOWFaN3dQK2FJSVpVUU5Tck1GcEc0?= =?utf-8?B?L1l1LzYraHpMN1VIckNlQnVxeWMyTkhmM0xOSlhmY0tYVW5tRzB0N1BHYSs3?= =?utf-8?B?Tld5V24xNXpDc0lqb0t0OFFMZVFSWWRTZ2R5dFRzM2t5ZEFZdmlqSloxTitM?= =?utf-8?B?MTdPQUZxVmlrMFdRQU16Zi9ZSGZZLzVEcy9Pc3J4OVprSW1FQ2t3UUl0WjVR?= =?utf-8?B?Vm0rbktVQmZUV1V0bFZtdG03ZEdTaEF2MzRna1FFak5nSjFJeHYzRGJySkgz?= =?utf-8?B?MTYvRkVZeDA1ckZNRnd1eDVQb2lVZzgvVXVQNFN2NGtOeis2UEQ3KzJNdWRW?= =?utf-8?B?STMvWXJPeTdTdkVwMWprUmF4dFpuaUtuL2JxSWY5b21TZHoyY0xHelExV1cy?= =?utf-8?B?SUVLRm15dTNwSG1scUlsQzMyMXY5anV3aTNRSkVwUVBsY1pXRDcycmJxWExC?= =?utf-8?B?aE1JTXk0SzVWN1owKzJqWUZydnpGZ0hZYzE5c0xLZE1KYWZndWdLR3FaZUVD?= =?utf-8?B?blZnQlRPRHBHYTZXT1hVK1Vxd21ZdXJPK0FkRXhxdmRmVnpiR2hPd0pzU2l5?= =?utf-8?B?ZngzOHdwaVpUZlBhNGhUWTVLcXY0d29qMHVwY3VuN0V6clV6S1VocjZrS0Z0?= =?utf-8?B?QmZLSk1wdUxnRnY0V0ZtbXYzUzNQMUtSSTJoZnBvb0F5RlRQZEhVdGpKVk1o?= =?utf-8?B?dzVLL3JpNW40d0VrTFY1SS9Ld2dEZTJ0Nnh2c0l2U2tzSDZ0cXZMZkk4SXZn?= =?utf-8?B?Ri9VUzV0TkZNNzM3OThsZjBSRjJNVGx1YkpIZmFRbmdDakt0K29RVlBpL05R?= =?utf-8?B?RkhERmRYSjZRMFh6N1ZEb0RRZVc2Vkhlbm5YQS9TazNsSU1WaUN0dTZURG5z?= =?utf-8?B?WjhGeWdzUEtzZVZoS21RWDVvZFhqN2Y2VXdFN3Vtelo0U2NvMkxsNDdDN282?= =?utf-8?B?SUtNMjloQVNHV1hGaFgwS0tTeTNrZkViOHllT1RjNUVlV0UvSzdTYkdxVExQ?= =?utf-8?B?VDI1TU42dXNCNUZIZ1JxbFI1S1dxYitwaUdXVy9laFlMUVF0S0I0RHdZRE54?= =?utf-8?B?U1JhN2NWenVEc1F0d0lGS0ZoL3lBYUVFdEpxY2JHQytZOEQvaVdCZzFYTFRp?= =?utf-8?B?Q0UvVE9DVW82ZGR2dXJIQmZzREt0YnFSaG5raWpwVGJVMTVhRlB3dXlaK2Nk?= =?utf-8?B?N2hrR0lQV1B2WS83dy90elJxT2F1VHE5d2RlRnF1M1dYRDBMZWdIdkZiQ3F4?= =?utf-8?B?d1M5SWRzdHoxSXg4bVMyMHZjaDBUaUFrbUs4Z29IeVU2SDMydWg3WDRXV1k3?= =?utf-8?B?SFUwdW9PQ1pybDBpaGlZOUsyMDRqUEFteUxoYkJqd1ZHbmdqWGpOcVh3clFy?= =?utf-8?B?S0ZBM1k0UzVzMjNjN2VVS1RrVm5rQUY1S3VyQzFYSytZRjFGd3drb1F3aFlo?= =?utf-8?B?ZDRSNHVhU2xiNTVJL3lGcC84ak9nKzA1amxwUVJMVVZJZUZxaVJSQjBsVWtj?= =?utf-8?B?cHNXaTlaYXFEczRKU29HbUNRK0d1MmtBTUNyR1ZVWmxaV0VEL0t2aTBETHhM?= =?utf-8?B?RE1DbHBOUUhhSnY2TkNpSnlOQ2E2aXhNRWNHTGs3ZDAwdXZRTDJFRS9QQlVt?= =?utf-8?B?RVgwNkNiQ1ZBS3hHVm1EUU45QWhLeGo3TWViUU5vd09RV081eWdZWSt1aGZr?= =?utf-8?B?N1o2T0ZvQWcvYmhQTjN1ZkU4empmd2xNT1Fic3NmSC9oeXNXeTZ6OWw3WFVu?= =?utf-8?B?T1J4ZysxUElENXg4MEJhWXI0bUtob1BUejJFV2R5WTQxUFVBaUx0bm5hOTZO?= =?utf-8?B?WkROSFluSkg0em0wWnAwbXhJMzZGY1IyTW9oRUJIRmVxVk8vRk1aNlJ1YnFm?= =?utf-8?B?dWFNOVk5c0JyTXdNWjhwZUF5cy94dlJCMkMxR000a2s2NVQwLzdQMVJoa3FV?= =?utf-8?B?NlFxd0hRQjZUbWw0K0FnUU9tZ0d4cm1jaUhpNUV2ZWdDdTVubGhnd25BY2xV?= =?utf-8?B?RytlbW1SVHpuQ3NRRXdXVDEyS3VtdXh0bkJSQUJlNEZaS0UxNlBLaGYxL2h2?= =?utf-8?B?SjUxcTlmOTF1Mk5WKzltdzZndy9oc29wU05mUWhBcFdJVjZrVk1jUXpUSE83?= =?utf-8?Q?A03+lSDhLzBAq7kr9b7x8XLa9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c20e5ae-d444-41ce-fa5f-08db1031d8a9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 15:24:07.8767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xz8Xc8cogkt3ajUKdkIm+hS/syvVQKOe2ssJvokPcHyl4OWRdvGws/EoBr5t8BNAhZutfDunLuo3dNInN1gISQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8039 On 16.02.2023 16:10, Tamas K Lengyel wrote: > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: >> >> On 16.02.2023 13:22, Tamas K Lengyel wrote: >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: >>>> >>>> On 15.02.2023 17:29, Tamas K Lengyel wrote: >>>>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: >>>>>> Did you consider the alternative of adjusting the ASSERT() in > question >>>>>> instead? It could reasonably become >>>>>> >>>>>> #ifdef CONFIG_MEM_SHARING >>>>>> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || >>>>> !atomic_read(&d->shr_pages)); >>>>>> #endif >>>>>> >>>>>> now, I think. That would be less intrusive a change (helpful for >>>>>> backporting), but there may be other (so far unnamed) benefits of >>> pulling >>>>>> ahead the shared memory teardown. >>>>> >>>>> I have a hard time understanding this proposed ASSERT. >>>> >>>> It accounts for the various ways p2m_teardown() can (now) be called, >>>> limiting the actual check for no remaining shared pages to the last >>>> of all these invocations (on the host p2m with remove_root=true). >>>> >>>> Maybe >>>> >>>> /* Limit the check to the final invocation. */ >>>> if ( p2m_is_hostp2m(p2m) && remove_root ) >>>> ASSERT(!atomic_read(&d->shr_pages)); >>>> >>>> would make this easier to follow? Another option might be to move >>>> the assertion to paging_final_teardown(), ahead of that specific call >>>> to p2m_teardown(). >>> >>> AFAICT d->shr_pages would still be more then 0 when this is called > before >>> sharing is torn down so the rearrangement is necessary even if we do > this >>> assert only on the final invocation. I did a printk in place of this > assert >>> without the rearrangement and afaict it was always != 0. >> >> Was your printk() in an if() as above? paging_final_teardown() runs really >> late during cleanup (when we're about to free struct domain), so I would >> be somewhat concerned if by that time the count was still non-zero. > > Just replaced the assert with a printk. Without calling relinquish shared > pages I don't find it odd that the count is non-zero, it only gets > decremented when you do call relinquish. Once the order is corrected it is > zero. I may be getting you wrong, but it feels like you're still talking about early invocations of p2m_teardown() (from underneath domain_kill()) when I'm talking about the final one. No matter what ordering inside domain_relinquish_resources() (called from domain_kill()), the freeing will have happened by the time that process completes. Which is before the (typically last) last domain ref would be put (near the end of domain_kill()), and hence before the domain freeing process might be invoked (which is where paging_final_teardown() gets involved; see {,arch_}domain_destroy()). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 15:36:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 15:36:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496651.767506 (Exim 4.92) (envelope-from ) id 1pSgIh-00021g-QI; Thu, 16 Feb 2023 15:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496651.767506; Thu, 16 Feb 2023 15:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSgIh-00021Y-N2; Thu, 16 Feb 2023 15:35:59 +0000 Received: by outflank-mailman (input) for mailman id 496651; Thu, 16 Feb 2023 15:35:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSgIg-00021S-8F for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 15:35:58 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-flk1.inumbo.com (Halon) with UTF8SMTPS id 9a1c11c7-ae0f-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 16:35:56 +0100 (CET) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by 80c484450f39 with SMTP id 63ee4d5ad517d2c7935668cd (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 16 Feb 2023 15:35:54 GMT Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5339759be1cso16111847b3.3 for ; Thu, 16 Feb 2023 07:35:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 9a1c11c7-ae0f-11ed-93b5-47a8fe42b414 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676561754; x=1676568954; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=1ksMJvvUpptf39sCjE5sumEYtEDIJBykOx4KUuxxZxI=; b=y0JQgr9fbwXzZOz+damhuj6F122gILyn4GN2zICUNbiVYOvaYzyYHP4ycBzjJwbI6agwVHX8eWPTJsgfeON0UlHxuhbRFyYITCTzt80G93fiqXxT25vHjcSOJGwjAo/5Z3MbknQTFD0sCQk4pxSmreSFLz1qCN0HvkZPQ1N7Qww9Tk1MEagtIw3Rl9EgQx6orbyImr+HVJdX+1ZoTp1t8NzpppCkeeZroF/oSaEVXr8ZhXVRuStiuG+bcOzlO7d7a1abAN18sqRQhFYQpaVsRdqJTsF/kT0wKT8pPHKgAQjXZLNk/DJDrkzD5bEK+H4Mbjw3dg4dIsvFhVQ9t/btdw== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKWjeEaGpQ9ySllH1KSqNtEzAk9khuGag5Jh6eQA5dZjRYu2V42t DXR3Wlqyh5G48ef4U3tzdEUwIii+uMjPCrZGZqk= X-Google-Smtp-Source: AK7set8L1uUKAQEKGzugjRec+uw9smfiaZ9WtSoLjAHgNxee3T7H89BVgl1QqvCpg+rfNl45gf5CTtiw+x7ERgWmVkU= X-Received: by 2002:a81:4f0b:0:b0:509:bd6:4d4b with SMTP id d11-20020a814f0b000000b005090bd64d4bmr617936ywb.282.1676561753822; Thu, 16 Feb 2023 07:35:53 -0800 (PST) MIME-Version: 1.0 References: <3af8dbf3134b48f6bbc8f917e5fecaf8daee1c3d.1676351034.git.tamas@tklengyel.com> <25bc4c74-f36e-2969-2b7c-c5acd115ebaf@suse.com> <000badbf-cd94-76b6-1f60-faa720a5407f@suse.com> <7db3740b-c483-c400-2800-2af85e697de6@suse.com> In-Reply-To: <7db3740b-c483-c400-2800-2af85e697de6@suse.com> From: Tamas K Lengyel Date: Thu, 16 Feb 2023 10:35:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000c7de8405f4d2f34c" --000000000000c7de8405f4d2f34c Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023 at 10:24 AM Jan Beulich wrote: > > On 16.02.2023 16:10, Tamas K Lengyel wrote: > > On Thu, Feb 16, 2023 at 9:27 AM Jan Beulich wrote: > >> > >> On 16.02.2023 13:22, Tamas K Lengyel wrote: > >>> On Thu, Feb 16, 2023 at 3:31 AM Jan Beulich wrote: > >>>> > >>>> On 15.02.2023 17:29, Tamas K Lengyel wrote: > >>>>> On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich wrote: > >>>>>> Did you consider the alternative of adjusting the ASSERT() in > > question > >>>>>> instead? It could reasonably become > >>>>>> > >>>>>> #ifdef CONFIG_MEM_SHARING > >>>>>> ASSERT(!p2m_is_hostp2m(p2m) || !remove_root || > >>>>> !atomic_read(&d->shr_pages)); > >>>>>> #endif > >>>>>> > >>>>>> now, I think. That would be less intrusive a change (helpful for > >>>>>> backporting), but there may be other (so far unnamed) benefits of > >>> pulling > >>>>>> ahead the shared memory teardown. > >>>>> > >>>>> I have a hard time understanding this proposed ASSERT. > >>>> > >>>> It accounts for the various ways p2m_teardown() can (now) be called, > >>>> limiting the actual check for no remaining shared pages to the last > >>>> of all these invocations (on the host p2m with remove_root=true). > >>>> > >>>> Maybe > >>>> > >>>> /* Limit the check to the final invocation. */ > >>>> if ( p2m_is_hostp2m(p2m) && remove_root ) > >>>> ASSERT(!atomic_read(&d->shr_pages)); > >>>> > >>>> would make this easier to follow? Another option might be to move > >>>> the assertion to paging_final_teardown(), ahead of that specific call > >>>> to p2m_teardown(). > >>> > >>> AFAICT d->shr_pages would still be more then 0 when this is called > > before > >>> sharing is torn down so the rearrangement is necessary even if we do > > this > >>> assert only on the final invocation. I did a printk in place of this > > assert > >>> without the rearrangement and afaict it was always != 0. > >> > >> Was your printk() in an if() as above? paging_final_teardown() runs really > >> late during cleanup (when we're about to free struct domain), so I would > >> be somewhat concerned if by that time the count was still non-zero. > > > > Just replaced the assert with a printk. Without calling relinquish shared > > pages I don't find it odd that the count is non-zero, it only gets > > decremented when you do call relinquish. Once the order is corrected it is > > zero. > > I may be getting you wrong, but it feels like you're still talking about > early invocations of p2m_teardown() (from underneath domain_kill()) when > I'm talking about the final one. No matter what ordering inside > domain_relinquish_resources() (called from domain_kill()), the freeing > will have happened by the time that process completes. Which is before > the (typically last) last domain ref would be put (near the end of > domain_kill()), and hence before the domain freeing process might be > invoked (which is where paging_final_teardown() gets involved; see > {,arch_}domain_destroy()). I don't recall seeing a count with 0 before I reordered things but the output on the serial may also have been truncated due to it printing a ton of lines very quickly, so it could be the last one was zero just didn't make it to my screen. Tamas --000000000000c7de8405f4d2f34c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Feb 16, 2023 at 10:24 AM Jan Beulich <<= a href=3D"mailto:jbeulich@suse.com">jbeulich@suse.com> wrote:
>= ;
> On 16.02.2023 16:10, Tamas K Lengyel wrote:
> > On Thu, = Feb 16, 2023 at 9:27 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 16.= 02.2023 13:22, Tamas K Lengyel wrote:
> >>> On Thu, Feb 16, = 2023 at 3:31 AM Jan Beulich <jbeuli= ch@suse.com> wrote:
> >>>>
> >>>>= ; On 15.02.2023 17:29, Tamas K Lengyel wrote:
> >>>>> = On Wed, Feb 15, 2023 at 5:27 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>>>>>= Did you consider the alternative of adjusting the ASSERT() in
> >= question
> >>>>>> instead? It could reasonably bec= ome
> >>>>>>
> >>>>>> #ifde= f CONFIG_MEM_SHARING
> >>>>>> =C2=A0 =C2=A0 ASSERT(= !p2m_is_hostp2m(p2m) || !remove_root ||
> >>>>> !atomi= c_read(&d->shr_pages));
> >>>>>> #endif
&= gt; >>>>>>
> >>>>>> now, I think.= That would be less intrusive a change (helpful for
> >>>>= ;>> backporting), but there may be other (so far unnamed) benefits of=
> >>> pulling
> >>>>>> ahead the sh= ared memory teardown.
> >>>>>
> >>>>= > I have a hard time understanding this proposed ASSERT.
> >>= ;>>
> >>>> It accounts for the various ways p2m_tea= rdown() can (now) be called,
> >>>> limiting the actual c= heck for no remaining shared pages to the last
> >>>> of = all these invocations (on the host p2m with remove_root=3Dtrue).
> &g= t;>>>
> >>>> Maybe
> >>>>
&= gt; >>>> =C2=A0 =C2=A0 /* Limit the check to the final invocati= on. */
> >>>> =C2=A0 =C2=A0 if ( p2m_is_hostp2m(p2m) &= ;& remove_root )
> >>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 A= SSERT(!atomic_read(&d->shr_pages));
> >>>>
>= >>>> would make this easier to follow? Another option might be= to move
> >>>> the assertion to paging_final_teardown(),= ahead of that specific call
> >>>> to p2m_teardown().> >>>
> >>> AFAICT d->shr_pages would still = be more then 0 when this is called
> > before
> >>>= sharing is torn down so the rearrangement is necessary even if we do
&g= t; > this
> >>> assert only on the final invocation. I di= d a printk in place of this
> > assert
> >>> withou= t the rearrangement and afaict it was always !=3D 0.
> >>
&g= t; >> Was your printk() in an if() as above? paging_final_teardown() = runs really
> >> late during cleanup (when we're about to f= ree struct domain), so I would
> >> be somewhat concerned if by= that time the count was still non-zero.
> >
> > Just rep= laced the assert with a printk. Without calling relinquish shared
> &= gt; pages I don't find it odd that the count is non-zero, it only gets<= br>> > decremented when you do call relinquish. Once the order is cor= rected it is
> > zero.
>
> I may be getting you wrong,= but it feels like you're still talking about
> early invocations= of p2m_teardown() (from underneath domain_kill()) when
> I'm tal= king about the final one. No matter what ordering inside
> domain_rel= inquish_resources() (called from domain_kill()), the freeing
> will h= ave happened by the time that process completes. Which is before
> th= e (typically last) last domain ref would be put (near the end of
> do= main_kill()), and hence before the domain freeing process might be
> = invoked (which is where paging_final_teardown() gets involved; see
> = {,arch_}domain_destroy()).

I don't recall seeing= a count with 0 before I reordered things but the output on the serial may = also have been truncated due to it printing a ton of lines very quickly, so= it could be the last one was zero just didn't make it to my screen.

Tamas
--000000000000c7de8405f4d2f34c-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 16:41:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 16:41:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496659.767518 (Exim 4.92) (envelope-from ) id 1pShJj-0003Y6-If; Thu, 16 Feb 2023 16:41:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496659.767518; Thu, 16 Feb 2023 16:41:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShJj-0003Xz-Fb; Thu, 16 Feb 2023 16:41:07 +0000 Received: by outflank-mailman (input) for mailman id 496659; Thu, 16 Feb 2023 16:41:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShJi-0003Xn-Ob; Thu, 16 Feb 2023 16:41:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShJi-0000nU-Lj; Thu, 16 Feb 2023 16:41:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShJi-00068M-BM; Thu, 16 Feb 2023 16:41:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pShJi-00082s-B0; Thu, 16 Feb 2023 16:41:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y9uuKoZKkg1YA3/R+/eSVR0QcmUIygk2pWfTPRgzgtI=; b=bCs9kvVRyCvLcjvf7mb6wPaRdq CMPjVJYWh7Ufz/qa/1dYX+y9MmKj68nTs3xivcd6wiXyOInuC9ALqbHMWxpuwNChPFw9Vj87X8Nbj V8crzLB3A0ZuOhjlQWEGYBEEK30Nj0bHXDH2BebK2DqvMWJEoA9YK55zH2YgnWMOfwdY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177457: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug libvirt:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=598a73335d70b4ef70b84f9730d708c116f88b15 X-Osstest-Versions-That: libvirt=b61c66d1dea2525290b7fa1f41ba6958bc39d63c From: osstest service owner Date: Thu, 16 Feb 2023 16:41:06 +0000 flight 177457 libvirt real [real] flight 177511 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177457/ http://logs.test-lab.xenproject.org/osstest/logs/177511/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 177511 pass in 177457 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 177511-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 598a73335d70b4ef70b84f9730d708c116f88b15 baseline version: libvirt b61c66d1dea2525290b7fa1f41ba6958bc39d63c Last test of basis 177347 2023-02-15 04:18:50 Z 1 days Testing same since 177457 2023-02-16 04:21:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git b61c66d1de..598a73335d 598a73335d70b4ef70b84f9730d708c116f88b15 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 16 16:50:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 16:50:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496668.767529 (Exim 4.92) (envelope-from ) id 1pShSn-0005ea-El; Thu, 16 Feb 2023 16:50:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496668.767529; Thu, 16 Feb 2023 16:50:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShSn-0005eT-Bl; Thu, 16 Feb 2023 16:50:29 +0000 Received: by outflank-mailman (input) for mailman id 496668; Thu, 16 Feb 2023 16:50:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShSl-0005eN-L0 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 16:50:27 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01e72962-ae1a-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 17:50:25 +0100 (CET) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 11:50:18 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS0PR03MB7180.namprd03.prod.outlook.com (2603:10b6:8:123::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 16:50:16 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 16:50:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01e72962-ae1a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676566225; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=e2ObegPTjHSCG5jLL4a43ZZAs1J2Xuh1rhwpTevabnY=; b=cgcXVsIF+sii/TCq9BZe4QE3FQp78vrF2c1hHeVOo72gp0aqcSWMmFV4 543rWXLkV2iTUjDGMRtsDk/bireRRN7mwXL24Ic94U+rrpsuunHDVtnLB mTX6ZnK2UxG1KtBxlpwMz660Xa6phaQtU+ragMgCEejLEZ2jB6E4wbQm7 k=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 96181204 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8yaseqPWQnHRPvHvrR2YlsFynXyQoLVcMsEvi/4bfWQNrUon0DEFy DEZWjzXPPeCN2LzeN8ka9zj9E1Q6pHczdMwHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0u1eAmVF6 LsGFBciXgu7gcGnmJW/TdA506zPLOGzVG8ekldJ6GiASNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxujeKpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eew3qrAdhKSNVU8NZPrAe5wGlPVic3UGmwnenjjE2QZMxmf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaESoaN2gZfgcfUBAIpdLkpekOYgnnS99iFOu5i4PzEDSpm jSS9nFh3vMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:xMTP+q5dFMbBoSXXJwPXwVWBI+orL9Y04lQ7vn2ZFiYlF/Bwxv re/sjziyWE6wr5AEtQ6Oxo/ZPwNE80hqQFkbX5XI3CYOCCggCVxe5ZnPbfKlHbakvDH6tmpN ldmstFeZDN5DpB/LrHCWCDer5LrbfmgcTY4tsy100DcegpUdAe0+4QMHfbLqQcfng/OXNNLu vn2iMxnUvaRZ14VLXDOlA1G8LEqtH3ipSjRRIdHRYo5Cmi5AnYp4LSIlyz2BoTbi1I+Kwl+2 TeiQD1j5/T/c1T/iWsl1M7oq4m3ucIBbN4dYaxo/lQDg+pphejZYxnVbHHlDcpoNu34FJvq9 XIqwdIBbU715uEFFvYnTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzY5B+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3NAiFXtuYck99R/Bmdoa+a hVfZrhDc9tAAunhqXizzRSKN/FZAVEIv7JeDlPy52oO/4/pgE786JS/r1top46zuNLd3Gfj9 60d5iApIs+DPP+JZgNdtvpYfHHTlAlEii8d1571zzcZeo604Wkke++3Fxy3pDyRHUh9upHpK j8 X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="96181204" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQet9aJlIWz93tWfFNS4We/GuizQdK6yZRLeC3QoYTs6fLOdgSNZjcmRVKzNfIvkLlw5Md+xZmdcZp1tkA2VUt8LkcDU7w2Fo3k44cEutiHFyLpLAR8YPapsNP014n2CcfgYDkv7L0WnV8hf4ox0oCvndKWa8/Kqdg7tjX3xe7BAkVKVqUQUTVLlJc55D3nZHEg85iv0hE1vGYuVzRPHVfkF1fCd4TRGrdKVImMqS/8//UGVR7T7p5dsoe61FxpeCKa6YFNs3ZIlB+LiAYfDKbW6vOZNwSihLjf6r7jam3OTOCSveC0F0PngiIru8xp4sJYAzRZVVGahOqAVFQhyuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I6Rgp5WB5Ov+0lj1fuYZcthuAm5izW7/bTYaO1OAFVg=; b=kFxvCxekYYzNrWRW+qKjcQ2oqaBQS3TvLHntly71q0mykqeuN6i+msyvLxZvI4+Z5soK7huKzJIcxLnvA7/nv6tAgyUsENIO7kTizGqlp5LzqwFlJq2DEteOqgta4ORC6lss/h7DODc1xlx1xDx72xXbQlSDqMXrHMt/XeISO6rmve2A9m4LwHqPbNDsG/VTOQMCq5J7xbd+d6EfmjcCkqD1Mn4s1pT4TKqDh1ZkQ8d73jCE26Oxe9IEJGjVduqDGfgxjWcAuD+dT7VorGC/JdrQD/QEXQp8gIalKUweoxZb1KkjqwJEcE4Z5b7DrU6C9TDuuZZYwK57ucGDUUVeKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I6Rgp5WB5Ov+0lj1fuYZcthuAm5izW7/bTYaO1OAFVg=; b=gixr8up93EArZz2TFUDK516qMDHtpw3oB6dNPDTqMFqRg90Yh9CQ8wz0ybpWQ+e7iA23Dy8HiMh7v3OK9qwHDYIFNqCdFVjwfgmTvvQK24JJ919/7dJki6TodTqtNZsM4EaNZeI8gpgvd+ebW8oL77tAULF07Z5ZDHGm1z0+Bds= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 16 Feb 2023 16:50:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Jan Beulich , Wei Liu , Juergen Gross References: <20230216141007.21827-1-anthony.perard@citrix.com> In-Reply-To: <20230216141007.21827-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0087.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::27) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS0PR03MB7180:EE_ X-MS-Office365-Filtering-Correlation-Id: d738c525-5158-4c54-385b-08db103de126 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVUqdN5l7kPVjgGBcMplg8q+eeQoK6HqXD/ptzoWc1YZ0A43IhvNACSrnKGQuOVKUS9591Tfeyllll0rClZ9sytSigVFH+G12C8HtiZPLcDYR4jiWtb96hde0jJgifJ93HQ/VRj0++u2dwF9ERi0Tm7OauyY1nEeTPlWqn30E4TcZ50Yc9lfHS+0lOFSbiJfCKDJ30iXSEidUarcuxd42Z03FSs8ZFS7me8B+4T8oI6q8XElHERPuBSYjKyowXI6k91oSsWK5asskMSL3hXBvQfs74XRgb5rFpqrUmGnKWWWhJpzhnot7UI/G/SpEfVfYDcKx/1u2Hf4qR2F/afA2WpTb6yp7iik+d4aanZibipBqIIRZd67kPJHrZN7YnDifmUHqTZwBFwtjAfE4wfPlNtzZ4Ju1bLqQshUcucyGoRv/XyPAw0aW+nrzq2L1Q3qOEbMBxPx3fmLfbeFM2/N2EtLOz3UD9ol2d/BlMXhRcQ3gMZwEt3wZV3tgw6CJ9BVQGtEICaE9D0b2azd9pQSu8XcfYGmvgWMywjtI2upFVrGvzaJAGd12RkhXtyYAhFp37DFocJC+Sx8XpkNsVITfGwY59egYswJwZconzhblYaPsnrrwwWJvpnAJVO9yBkjMteJqegSOSqJhMLOcAYOsX4b4gBCRwhdvaWMhEMvIR73pEuB3L8LTa1aTHlDypTbQbrIy6NGdVfjEYAlVE+CQjv/IbtrjR9sy8q9J4Pb9Zk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(451199018)(31686004)(2616005)(38100700002)(82960400001)(36756003)(4744005)(2906002)(6666004)(186003)(6512007)(31696002)(86362001)(26005)(53546011)(6506007)(478600001)(6486002)(8936002)(5660300002)(41300700001)(4326008)(66476007)(66556008)(54906003)(316002)(8676002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHAwdTQ2YWxvMzhZTnlKN043UHFjMmZaMTIwWnJ2OTl4SS9jMXprV2EvU3RJ?= =?utf-8?B?MFcvOU5QaXhCWE4xU2JKQ2VzRE11V1cxYndUb21qTDUvV2NvZ2NlUDFDWVFF?= =?utf-8?B?U3lIQUJxUWdMcmZsa25NaUovVGVzVHRUWnlqbkJPakExc3daN1pMYkd1Nmla?= =?utf-8?B?ZHdpemFML2dhaCsrQ3IvR1BOMHZ3WCthVWZaTE5KSnoyUmw4N0lqU1hoUEw2?= =?utf-8?B?OUFzK0RrK1Y5NTZ3RUUvSGNpVktTRjdndC9TY0RxK2ZHaGlqdENsQkVEMDhC?= =?utf-8?B?Sm4vejJmdHRMYm9zdnFaVVRqMDN3Uld1RlFJUmV3RW05L2lLREI1R0duTU03?= =?utf-8?B?eWsycU9oVDNWaC9nWkdSOUJKQzU4NGVweThPdHdyYjdvaDh4TCtEUWM5V01h?= =?utf-8?B?ZFhiaE9EejNjMS9zTnJ2K25JaGJQNWd1bmRDY1pFdjJ1RVhDeEZNQytKYlBz?= =?utf-8?B?b3NqWWRpYzdsYnFPMDgzbkh2RmFLU2RpODVmTGdLODI4b05QS0VWaVc0SnBT?= =?utf-8?B?Z0ZGbTRsRTF1eU4rSmdRVVNoM2dWdkdDRWdpRjlyYmJEWm56c2h6NmdsQi9I?= =?utf-8?B?ZUVJTUdaL2kyeXJOVDBxNWxhNVhhOWp5ZmNtZ1JFT1RtRDhXcGJNYmlkUGxn?= =?utf-8?B?M0puYnJwZVNYQkpPMVVOWUNZbE9EKzUwQkxwZkY4Sk83KzVIOU9nenBoSHBO?= =?utf-8?B?ZjRtbURwU01mcEM4eStZaEszQkxzVlN4V0NyNjhCdUVNUnJjSGxXVkJ2QU5u?= =?utf-8?B?QyttTlpueWMvWDB0NjU5TmpXR3dQZGdob1UxNUxYOW1tRTEwUldtdEtibk5n?= =?utf-8?B?RXdKRVBvMFFtSjhZSHRLaFdmcjdSZ1FhOTlZWTBGaXMwOHNXSmxDMG1RS2cw?= =?utf-8?B?TmtienFOS2tMZVlCc0hmOWJDNDlkR2wxSFpyYmpSdm5PdmZJUEhHR090RmJF?= =?utf-8?B?aVUzdWpYbGpTZlJsMjBMOG5LTEMxaGN6elpjNk1xOVJEak4vOGdtekdiQVpU?= =?utf-8?B?QVkvTG9KMmF1VE9rNWtacFJtalQ2RFlheDRGUDRLaG1rK2swdjE4Sm9BN0Fm?= =?utf-8?B?K05nZHZGU1hxYVV0cnhSUHNRQTdYZXJ3cSt0dTV1T3J5dDlYV1ZNZXNHZXFW?= =?utf-8?B?OGtHM0ZmNFZBMXhVUm5MNldmN2RYR2Q4NTFIUVU5R0owNGRjbloxejNqakxj?= =?utf-8?B?QWZMeXNiS2lxUVF1Zi9qcDBHcm1YUE51V2hPTWQ1S0hCVm5RaDd3aERaV0xn?= =?utf-8?B?c0k2NXhZRmU4SWtQSFdjcGtBK0N4YXBKWStnaEFRMkRVSHM1NzROY3VsQnI0?= =?utf-8?B?OTJnSmV3N0FuN3dFMW1SZHVKY2QvTHQxZHhOdzlBOUt5WTlwVTZlajkxQ2NV?= =?utf-8?B?dVZ0V29IZ09mQ2JUQTZ2S2pCT1BOL2FTaVJPU2p1dHhxMDNHRGc5VXZDa1du?= =?utf-8?B?cGtsYk5QQzFLMXNic2lTREt2MUpFeVJReEFmb0ZXak9FYnpWL3JwR29BQ2ho?= =?utf-8?B?S1hhZlNOc0lPOGFjL0RvcE02cFZrc2w3ZmVuY25qRzhlUm1ENnkwR3k0VWJn?= =?utf-8?B?MjFDK0h5cFZaQlRZVmJBWFdTRUFrdms3aFJwaGtuTzhlc0J5NE5HeDZUVVBU?= =?utf-8?B?UzY5WEcwenFuSk0zWGd5cndic00wTHNvNFkyckFaUXVOTUJWTHBXVGRWV3kv?= =?utf-8?B?Q0xkMXhWOWE2NWM0dGNDTndsakhSaVVhaWljc3UwWXpQS0ZGZDhBQ1JMb1Fu?= =?utf-8?B?cENueS92U201MTZoUVNudmhydkJiRFp2cjNRdG4zUjk0Z2pCanVMUFlHMUVy?= =?utf-8?B?ejA4MlEvcW4raEY3TTNVTXlLRFBPKzR1cHRNemtDa2hDUVoxUG92dDFjSkNG?= =?utf-8?B?ck1NUm9qN216UnhZTC9xZXY4cHU5MkNiblR2TWpKLzRUay9CTVFuT25sV2F6?= =?utf-8?B?clVCUVVkWVlteTdoNy9Zc0NFaVp4aER2NlVmRTRvL2syTFB0Sk5Wa2dZSmRN?= =?utf-8?B?QlIvMXdxNnhNTnQ2UUF5WloxNGUwSXM5YXJEbnpNL2VLTjNHRnFWekJURVU5?= =?utf-8?B?aUdkN3RUWklwZWF3ZmZQN2tGK0tsdkZ0QUFTb0FMdTlYbU51dVVPSGVWaXVP?= =?utf-8?B?VS9NWk1nc1EyUFJodHlXZXdOV3V4bE9QbWRsYmhxcGh3UHF0NmZhYkdaUXEr?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QXdIGRFwtHOJQizlhmgUJt+lINOk+U0oIC+LSRfYDffI7yJNTbu5AorUYxiYe7nhK78SSgCk4VXJgLD0LfNDY/Wt7OXymVwHnrxDElVc7lwgQqJBxNzcYCpxHR+1WpAiZ3Z/mT/Uw0duWkdfqezmeT9LyHEknoXYkWjdk7r650DrrfFMsd2BWMfbVNZYogb9xtJHc7SrIyvCEjgJBiVS7kUj2bw4421tKbQmD7Ig4fVEOFiF/RNSI4qhX34/piTB0lJf54+3JLhMcWzL4DiNLltY+7E8QY2YAF8+z5aGCTusnyhNSYajXEtPIoQBiJXmJMmpsNUEfHw5GhZNoRrzQ462OQNtnIXa1wCm64vklwsuHYnqJ07KEbttd2DbQPlcST2Stt/B+8y7e7LFkwLvM+mB7YfUqMD3g468Cfs9eaoFxh2GevNZQL04lE0lGJuA1zF53m/1lnulqv9zkRLLfxJU+37RjM8jZaZWyEWTZqdukRRkMhs/9X0IdWH5oAmxItyH7yp2AkQa2ZgShgfK8ZMqS/yq4Dsj2jQY8XMMUPGslMsk53WuKO/gHnR/mfae93x3Q/J11wP8hpiQcZ9YKbq03/vinI0HnUkmVxTR7+XpCipgmAv0rY99Ri9QTXAelcN5dIDMf9bHfrU+Zv8G+hDEyPf99jUQzVS1RufQ0hzCv8k5J6Z3H8HVhvD46Z4yh7p/0RjCJGUvI0KxnC0ngl5elQwGda9zuQVC6+IWZY7Z12x4QwwZAWej4+J9w9qoPD22sHup1eWJ3Tv1PLphTbcNpXY90DWMlZaVJOVBPaqLNsHT7+4FUTFf8HDihHhY X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d738c525-5158-4c54-385b-08db103de126 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 16:50:16.4484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tNfMvML3tgsvSVyZBj/Ag2ZDs2Q5EV4pP7JXeD8xG++nPoVgbzsh7n6ipdRNcQUTLJ2d35JNR7DaG2tT8XpQG1QKv1Y45bm3HxzolXbOb9U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR03MB7180 On 16/02/2023 2:10 pm, Anthony PERARD wrote: > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index 0e4b5e0bd0..ffb6c9f064 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -120,7 +127,7 @@ TAGS: > clean:: > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) > - rm -f headers.chk headers.lst > + rm -f headers.chk headers.lst lib*.map.tmp .*.tmp Doesn't *.tmp cover lib*.map.tmp ? Also the subject still needs a FreeBSD->LLVM fix. Both can be fixed on commit. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 16:54:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 16:54:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496677.767540 (Exim 4.92) (envelope-from ) id 1pShWZ-0006K8-37; Thu, 16 Feb 2023 16:54:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496677.767540; Thu, 16 Feb 2023 16:54:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShWZ-0006K1-01; Thu, 16 Feb 2023 16:54:23 +0000 Received: by outflank-mailman (input) for mailman id 496677; Thu, 16 Feb 2023 16:54:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShWX-0006Jv-Qc for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 16:54:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e0634d6-ae1a-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 17:54:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 16:54:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 16:54:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e0634d6-ae1a-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ft1YGPBrDdPni4AxLiuhn3/WeK3x18ND0GgAlViWtyLJ3MKIuO9aOOToPBaZvxe74aAxTh6maY7vYF9ytDlrZx9nUWjvKph7IJIJ9u4yTE1LZQN/cOa9D2ysTwYG0HNNM9zTVaThnHpGLKZJu4wjewQY/qwu8zW/BpanQixXFAB+cfsZV+iYmfQ0b0RVP0vy+wsCCl8ppvvFpimQ3awwkbP8dppM2kkhiAZJyuCIlj2HY7DJudwFm0wTSmNT7Hs0KCnjEUnwqxroztLXMwb7MUGbd8V8i8vpiRaMoYwJA7bAoyWeL0AcwZOCHoaifE+yUQ6ZeUoI4fBBvY5iHWjg6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LCLsLa+Vl9xWn1eps/SOOfDbga9BWYmePRLGGMrYXso=; b=dm5ILsSJXRRFU934+XgRkiAwx5FjWmMjNeed6q4XKQjVlqEzgWG1NLcT5jx9+SXeImRoN4khBOTL25PmXsG/WbEof82A3kBbMdpbJkGcJxSXF2uPbCjbgI1et+HINHHJzYna8CYeTqiiYP7hYIFZcNczt10ZNTeVeaHubST5ApGa6H8zrBpLWlIl/SLwtJ4pjgZWwMD/KmQSsHTdJLPJ0ysPTm9RhjhfP82UlvJ+F8GPnLBofq+tigKKuUH38fcCA2MypvqYJDr+MxedDzeN3sh5LTe7dSNpT4BA3OQ6wyxo8m14KLQiN6eonKrL80WVCtu508GgX9w0NfNuzoAaow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LCLsLa+Vl9xWn1eps/SOOfDbga9BWYmePRLGGMrYXso=; b=fP6owUyv/P5v0hpCfGQ2JAQvC6MUmqCWtvMMqIwPfeVW8EJn44Jwm0Yb4AcS78kY19EvChZg7nJK90teEUvbvewdAGLgfamG+dzW5QeqGuQdi601YjM4DyWqqfzgeQiiW8tbBcIrgEWTJ2ztCCuNXaIya28TlUA/p2d7snRuRfPG6OV8CNlH4OmhuvuDBZwZ4RaD9op7Hu8aHtaNnKqEcAA3sTqVvW0i/gTGX7FAv5NucliBINBzdq8bJuHfrCfov01D+MT1/oMFaapJy1yO5xfj/TfOv2HIBjcmc7EIee1cHDRTE5rIS6Vv2JN2Jlr/XJVvR0EFWvz7QvGEd3FY/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2f1ba096-d51e-00e6-1038-db01008c90b7@suse.com> Date: Thu, 16 Feb 2023 17:54:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Juergen Gross , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230216141007.21827-1-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: a6cd544c-fdd0-4f7d-44a7-08db103e7101 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F9sad5kMcp2ignKSljVnrWTQj+jTP0INwiYFxhOVOBwZHNdOMlIybdwas64kVJkT4p9HQMkEgWzaqWfSknmLJyv8nSAiziOlb6EZXOuLN/L0/LyNJ7h6G3v3zhjufihLQD9GibKE1hWbhgfTeMmveSvzasY6PQrz/q2lR5MhTkRm67lvXOsVuOAZoxSRvg41AWUSEK1VTbyUVkzhXzdkYBAlkUCnX5fAvyhtGnYHtKcgmG7KFvLfE09Dx0Szlb08BjiOaj+5Y0BhboEGC4PJbl6AX7Y1LQZDQaruU4UZQoXbPLyZpFL+XcelndJkAiaB4aZZkISJatrp5ObsCyfL644hgaXjJsxAtY/DOF9r5N5V5BiQ/sk9ZEdnoUmD1e0PYiGxTISFisLs4mLwlvgP2t2p91zXB6GTgPDK+6R7acSlCIbP73vicJ/VrXtdj4Cl8QsjzA5dB5eQwrRqgRw0UvcxEFTcZnWIuvYlxRBv+2MVE80JeD/iTvFoCoBHl3LVGbkCd/igbt60XZItleX1T50mY3Tyn7RW9UXUBWelsnMR/LzwVflu05bejvZwr6OoHt/fokJDObWIVaWbS10AJ31IVz6+Xw5QeucIsWQaZh3qDUW6ThUXr6e7PoeUL3qoVt00apm7Nwk90KZJF3MLruXApMVD/eH9+PYqbAyW/2WInu9hR2GcCKQ8WgntDy+lDSzU1OKeRlcPwYSjaWms8ko6LoG0z9PQO2yPYD71Y5Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(376002)(366004)(136003)(39850400004)(451199018)(53546011)(478600001)(6486002)(31686004)(6506007)(6512007)(186003)(26005)(2906002)(2616005)(316002)(54906003)(38100700002)(36756003)(66476007)(66556008)(66946007)(6916009)(4326008)(31696002)(86362001)(41300700001)(8936002)(4744005)(8676002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmFnNmVHN1VZZGtEd2lDUzhqTGt3cVNHWmYzMENvZ2dYVmNSZjBrQlVLMGZz?= =?utf-8?B?ZTFvcTQ5SlFkYXZKTXJRc05lNTVhejFzaEtIbS9qSHNxVkRtLzB1dDFCdEs2?= =?utf-8?B?RXhiQ3FNVE5Sc1pRbk5FOWR0eFhnZ3hYdHZNU1BrK2dTcU5nUlFVQkM2VCtI?= =?utf-8?B?bzlZQmJaRjRScnYremIyc1JXMkVlbndaaWM2NUxMWnRlZHNkUzVUQmdIUnVE?= =?utf-8?B?NlQ0NUsvVHhNRWpQMmNWQytseEFEMGdKcTcxVHJwUExPSUJHdjVQRlhScHRy?= =?utf-8?B?ZUlPQkpkY0Nra0MvWDBMYzl5WFUvMXBDK3pWOW9xMjJTUStoLzV4ZkU3TDNk?= =?utf-8?B?MDBIQ2Eydld6dGEyZ3VpQjNXR0Y2WUVhNkRaeWo2RHpBVDc4YWw5SnlEaC80?= =?utf-8?B?OXFkNzJWZG13cVFSaVJMMVREZThFM3pONFhjWDF1bVAxUHYweFpZTlk5UUVo?= =?utf-8?B?VWI1bzRYb1ZnT0xHYm1OZGRZRm11NXhSQ241YWYvcFZ2S0pqcmxiM3Q4bHRS?= =?utf-8?B?eWlTU2lqQ2RYYW8xOVBMNEV5TWRwTWNEZTc0aXVEZGtGSy9QYTNsSGJXVkdZ?= =?utf-8?B?K2lSQXJYcktYN3hYOGE1SEJGb3dRa0xOQWg1Uk1pejFkOFFsNUYydXV6c2dT?= =?utf-8?B?NFUrbSs4MFBOd2pvSGx6VDNBNHhZcUVZQjZNektUWVNtUnl6anVmTnJ2cnZw?= =?utf-8?B?Zmc4ZXZRc2JkQXZHWVdzYWUvYjBUK2pYd29LV2c5ZFpHZkxFTG5rclNBVWFI?= =?utf-8?B?ay9jdWdld0llYkU3SWNOQ282TC9udUlWZmd2NXRvNHB0SXdiQUxBbzRrWHBO?= =?utf-8?B?SVdaSXRjVzJEWGlVS01odWc3dmdoZEpBdjZNcmN0YnhBMVl2Q3hRcDNRRlZq?= =?utf-8?B?V29HenRnL05oVEZ0bWlzV3RlWmlIOUYyZjhwbnhISXFEckhDRHlMSWhRbHND?= =?utf-8?B?a1NxTTQ3dnNWNE9KRVY1Y2Q3QW12QmlhWFJhMnRaNVd6TnR1aFBySHFwZXZZ?= =?utf-8?B?T0hpUVNCQ2FMUEpYV2N3WjJFZ1cxeUR6cHh2T1liazVMNmI4REIvYi9QNHlx?= =?utf-8?B?TndsWm5tU1U3Ly9ZN1B0b3gzSnNhWDNUMytNaEJXM1lQS3FQYUdlbW41QnRx?= =?utf-8?B?YS9sa09ZaHNuZmJmZWVFelFlQitYZGlzb0pzeGR5QkZnT2hrSXlDa0hqaS95?= =?utf-8?B?ZmV3MmtEMTd4QnFyekxOQ2plSzU4QW1jUklBVHcrcjNWc0dTSEh1Q0hwdnVr?= =?utf-8?B?a25SaHZLTENHbk4yWEd6ZCtnMDEyM0pyVjVWVG1ka2U3RGZSM0JYQUpLR1Bi?= =?utf-8?B?eDFSb21NUnpxWXR5YVBLc2VOZkNXTVZHZTBDRVFib0I3eStJcUtqbmxlNHlq?= =?utf-8?B?Y2JVWUswclhUQ281RktLZnBaTVZZNlJYK2htcTdIU00zazl1eElXeUIySTF6?= =?utf-8?B?Wk55SWNMM2xHSEFUcEZ3a1hGR1RSbjdjN2t4LzJzcnUyaG5BUUk5VW5kUDZI?= =?utf-8?B?UFFBdGRybkJaMitXWU9KdXA5MFVRZjNsY2x5WXFFMVBrWGZ5NTlwNFpjZFVv?= =?utf-8?B?RVRzZVhRZlRFajBlUjVzNEhzdFk5YWMxNGd3b1lsS3N1Z1pITmcyL25QdGFD?= =?utf-8?B?UUxCdkszOVZLcXhMNzlKMHdudTI4YXVZT0IrR3c2dFpyS0x5Z1gzckFQeGdW?= =?utf-8?B?blFnUHRyTE5GQmgzRHErS3NobE9tREpETmpiMDMzd21KSVdFSDJYcmRLOFFS?= =?utf-8?B?MlAxYnRJL0htL2xyaEFlTkxvSFlkOXFkYkN6ZEdwKzczTVBOQVlxU1B4QWdI?= =?utf-8?B?NGVHOTNONFJtNmd1blpCZ3dabXJnb2s2UG9yZ0Q3RzR4N0dIQVJPYnpOQUlD?= =?utf-8?B?d0NRSkNtYVVsMncvbEJGRFduSVczMGUwcEw4emE5WDdZWis3dGZSOU82V3pL?= =?utf-8?B?M3RPVTF2ZVhJa2xrK3V4SjVvd2xka1dmZlIyR1J2MkxqNHJ2Q2RNdGtoUVBX?= =?utf-8?B?MHJnQnI3WkhFVWVPRkpoVjBFaXQ5REluVzV2QXFhZk5QWXY0bmJhU2tYOW5H?= =?utf-8?B?Rm1uQjBoT1JiYnF2bmxTRExkNzFhdUpXbFBKK3VYYVdOb2RycUFBQm5FTzlD?= =?utf-8?Q?9SyVSHkfqX4jmzb8TKJec6sXq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6cd544c-fdd0-4f7d-44a7-08db103e7101 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 16:54:17.5013 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JUJ7LCvtKIDgAFvsQzgj/ienhwcKO5fwZuqr67FQCWgOwb9zinle3CYTp0a+gY13jmge5qlvbZIqcE1jNXW7Vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 On 16.02.2023 17:50, Andrew Cooper wrote: > On 16/02/2023 2:10 pm, Anthony PERARD wrote: >> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk >> index 0e4b5e0bd0..ffb6c9f064 100644 >> --- a/tools/libs/libs.mk >> +++ b/tools/libs/libs.mk >> @@ -120,7 +127,7 @@ TAGS: >> clean:: >> rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) >> rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) >> - rm -f headers.chk headers.lst >> + rm -f headers.chk headers.lst lib*.map.tmp .*.tmp > > Doesn't *.tmp cover lib*.map.tmp ? It's .*.tmp, not *.tmp (but I agree the leading dot is easy to mistake). Jan From xen-devel-bounces@lists.xenproject.org Thu Feb 16 16:55:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 16:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496683.767551 (Exim 4.92) (envelope-from ) id 1pShXs-0006uY-Cu; Thu, 16 Feb 2023 16:55:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496683.767551; Thu, 16 Feb 2023 16:55:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShXs-0006uR-A3; Thu, 16 Feb 2023 16:55:44 +0000 Received: by outflank-mailman (input) for mailman id 496683; Thu, 16 Feb 2023 16:55:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShXr-0006uL-AA for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 16:55:43 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be1224c0-ae1a-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 17:55:41 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1224c0-ae1a-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676566541; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=peLqcPhOHzbL3yJ5ZAfpVvZr9eOT+PLTqpxYT+hcofg=; b=AxxIydf/L/oVlCgUNw8WYx0gGLUhZHBIzUn4601myQgxIk5FRDAT8NGT DQNmhvsn4BaWFMyfLnZulHOdhJpj5awwqzZzULwC8fTtVbqAiHOA9ws5I uM91IVDjIjokiWBUfdVugG3bvlUk3pbX9LbC10fQ5GBjp8Ikwn0hMljQL Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97257848 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:dNqqr62OZB3iXmpk//bD5eBxkn2cJEfYwER7XKvMYLTBsI5bp2YDz 2cfDTjXOazeNDP1LdAjO9jjph4OvJXRm9RlTVc5pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnO6gR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfP08X6 6FbERM3VgmJl+iI3vW9cLRumZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFJoPwxnI+ jKuE2LRLkEGN+GfxAC8tSyilNHtugL9SIIOLejtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QW9TAptrMa71GwQ5/2WBjQiHecswQVQdZ4D+ww4wbLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi+QPu6lq0EiJFIw6Vvfo0JusQ2qYL y22QDYWuZtKk5NI7oaBxUnNkziSuN/PdFM3+VCCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQQ3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS B+C4FgBjHO/0ZbDUEOWX25TI552pUQDPY6/PhwxUjapSskZSeN/1HsyDXN8Jki0+KTWrYkxO I2AbeGnBmsABKJswVKeHrlCj+N7mHhknzKKFPgXKihLNpLEORaopUotagPSPojVEovayOkqz zqvH5TTkEgOOAEPSiLW7ZQSPTg3wYsTXPjLRzhsXrfbeGJOQThxY8I9NJt9I+SJaYwJzLaXl px8M2cEoGfCaYrvc17QNy46NuixBv6SbxsTZEQRALph4FB7Ca7H0UvVX8BfkWUPnAC78cNJc g== IronPort-HdrOrdr: A9a23:EeGj3a19urX79bl4FlYewAqjBS9yeYIsimQD101hICG9Lfbo8v xGzc5rtyMc1gxhO03IwerwSZVohEmsgKKdkrNhTYtKPTOGhILMFupfBOTZskDd8kHFh4hgPO JbAtZD4b7LfBVHZKTBkXWF+r8bqbHsnc7J9IOuqEuBVTsEV0gj1XYHNu/yKDw2eOAsP+tAKH Po3Ls8m9PWQwVtUi3UPAh9Y8Hz4/fMmZ7afxhDIxI88gGBgROEgYSKXCSw71M1VT5C/KklyH PCmQDi/Kmv2svLhCM041Wjr6i+1eGRjOeqy6S3+4IoAwSprjztSJVqWrWEsjxwiOaz6GwymN 2JmBskN9Qb0QKZQongyyGA5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHof 129lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjR9o+a87bXzHAb0cYb NT5YDnla1rmGqhHijkV7xUsYGRtndaJGbxfqFNgL3YomlrdLYQ9Tpa+CVVpAZyyHsHcegy2w wfWp4Y0Y2mfvVmL56VTN1xM/dfKla9BS4kY1jiZmgO4sk8SjnwQ2me2sR82AjtQu1Q8HIbou W0bG9l X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97257848" Date: Thu, 16 Feb 2023 16:55:34 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Jan Beulich , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Message-ID: References: <20230216141007.21827-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, Feb 16, 2023 at 04:50:09PM +0000, Andrew Cooper wrote: > On 16/02/2023 2:10 pm, Anthony PERARD wrote: > > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > > index 0e4b5e0bd0..ffb6c9f064 100644 > > --- a/tools/libs/libs.mk > > +++ b/tools/libs/libs.mk > > @@ -120,7 +127,7 @@ TAGS: > > clean:: > > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) > > - rm -f headers.chk headers.lst > > + rm -f headers.chk headers.lst lib*.map.tmp .*.tmp > > Doesn't *.tmp cover lib*.map.tmp ? There is no "*.tmp" on this command line, but there is ".*.tmp". > Also the subject still needs a FreeBSD->LLVM fix. Sounds good. > Both can be fixed on commit. If you only fix the subject, then that's fine by me. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Feb 16 16:57:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 16:57:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496689.767562 (Exim 4.92) (envelope-from ) id 1pShYz-0007Sn-PO; Thu, 16 Feb 2023 16:56:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496689.767562; Thu, 16 Feb 2023 16:56:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShYz-0007Sg-Kt; Thu, 16 Feb 2023 16:56:53 +0000 Received: by outflank-mailman (input) for mailman id 496689; Thu, 16 Feb 2023 16:56:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pShYy-0007SW-LX for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 16:56:52 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6bc843a-ae1a-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 17:56:49 +0100 (CET) Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 11:56:46 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6498.namprd03.prod.outlook.com (2603:10b6:806:1c5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Thu, 16 Feb 2023 16:56:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 16:56:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6bc843a-ae1a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676566609; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ScEPtJroA15XXAqG9cKWaidweZkIAsE8GbMwa1H4gXo=; b=CF260E5X5AvZbgY6hoU7FbP1OVK1aoRDKrujACiP5cDtjQIQkbGbqssc 1T2pHG91V0WJRcL3Aa6ZuVqCudeDIqP9fIs4MVSrEQKh9Jb81XSZpxumK xJMD/HMwdbKdzvZ0L3k9Snzw0mkBR/xxVVM8AOF2WZSDAmIw5NaRTZGzh 8=; X-IronPort-RemoteIP: 104.47.70.104 X-IronPort-MID: 97343669 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:IVaX4qOCrRUGCc7vrR2YlsFynXyQoLVcMsEvi/4bfWQNrUol1mYCx jQdWzrSPv2KM2v0ftpwPN+yp09SvsKHy9QyHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rgqUXFN6 9sDEjQMdTeioeeIxeLkasA506zPLOGzVG8ekldJ6GiBSNwAHtXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vJxujCPpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewninA9xMRdVU8NZL2VeZ6WhNVyYYD1e3paS1q3+xA/dAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaESoaN2gZfgcfUBAIpdLkpekOYgnnS99iFOu/iILzEDSpm zSS9nFm2/MUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:pwxuFqy5NV+GFnEF8iInKrPwAb1zdoMgy1knxilNoH1uA7alfq WV954mPHDP5Ar5J0tQ/OxoVJPsfZqkz+8Q3WBJB8bEYOCEghrSEGgd1+XfKlTbckXDH4hmpN 9dmsBFeaTN5DNB4voSjjPYLz42qOP3k5xA/d2/856bd3AJV0lXhT0JbDqmLg== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97343669" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eN9pEIulKzxWTMT1H7+WlI0Bv4zI/ZbXdNh0L9DIuj1DtJwIHasBA+bAH2QfWekF9Ora7s2YHqhqmoZbSRy0X/rWtlTg5PcXrlHmSAXmsu70sBNfvP6vmY07mPCH5nR0obedp5XEiQx9TqEeQOrlU16vyxgUUHk4/Jqv3IT0qPfY0Z0IHeI44QGpc/UcTdjPqwJp3qoyOoDcYOinrhiUf1+q20e/vgCC30RwJy57qKn7HBOG73Ltrlb5V3h3r087vvZmNWr/tuf5AgktGG7wDd5M0zapz1pbV0nx1G4YfhATdQ8Cq8D0N/fcW3ucwAFAaYOyKx+FpfPZseirsRNnfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NNQ/RajlO/Rq7MWST7tRnT05ATiIScW/sbRdvrcAsvU=; b=JCf98jyNQcSK1POvWYd5Gpp64WsX9XekIBV6V6+MrHj4Mue9bjohb8eP/sH7Grdtj1NuBbGxgKXL+gMBbpmBf35XCZwFKXtxywoQfn6J6XVkWeT2Y96SlV8H6VB/v3WnWKzFPv/0EZ4jOpLzFWBCKx9WeducmEz3r4DzEgyoW3DYnFVSROWpJZB5XSYuuz0aqXIu518jMyauMcrebmX7wiBMPyZJr+AHG322dhjsS0VNw+kRReG8rhOKtHsX9zJb2oCVbkB9qEVk5ZzolBuIU/cOvW8Ep3wQxNXa268eQRX5Q+C9BDpoRLTiQkx6ZeZuS/SGea2ZhPJYhOK+aV28Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNQ/RajlO/Rq7MWST7tRnT05ATiIScW/sbRdvrcAsvU=; b=OxB0l2nZJ8VLThglKMxhj0A/+mOEtlUVExWoJpMny/6AXtz1cf/eCovf+yqKsBX6Fqkm496Y2ciNOz9wG34zFepAgJgh62xmF3IyJsonWv7ao8XXLNs/q8XgfhaA4qRCSRtKxL2rNk00XYWhqi24zYxmORNo8cLk42+dpEbHTkI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <45c3f466-7983-734d-b810-57852bb18b73@citrix.com> Date: Thu, 16 Feb 2023 16:56:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2] libs: Fix unstable libs build on FreeBSD, auto-generate version-script Content-Language: en-GB To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu , Juergen Gross References: <20230216141007.21827-1-anthony.perard@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0364.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6498:EE_ X-MS-Office365-Filtering-Correlation-Id: c90aed2d-47a1-4857-16a4-08db103ec781 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JGAKnSvEToNF4alZBDhZpLD2sK7Md542npR/CI88SShV/hyKyMRluTeq/SmBISamH8iHpaOl9+g4qtAPBwT96ewjkUKBFbwz/iF0rL5mPXuezup5FJa5Q7xnnW6A7rLXA0MDUaaLmgCKGTt4LnQbIkEewuRnzjvdkiA1MZtWm0c2U1IpaucovyFMem/AhegExusgEW3gdQyOxJTJEh1kCYS4rNOUhtxiuVlO730udk0rBv3SYgjBFyx6WTuHrsnmWSzjuorTFHOvdl4xe/sQK+RZNw4V1f1uexPzEs4G9Fr9KXg9Bi2YPbxZ6cZFrr2L3xMPoyd/I/am/Rf4/OIKRUd0S/C7ymTtgQ85+73un2LhdJ6ErXJbyl29DN95ubDsPHQTS/uZWDgDl961QIcpKgvLm8VmCoRzyv4KLbyiCkPRolPu8gaj17W+9AmX1uE8u95fndqYymb3cCykhPPpYJJT5iHtdyXvLYR9rQfvoNOMbA8/QkAVQRlVVe+imGEaoDF0d4fFHD0gr1RgZ1cO5u3IOVCPJRY41m3Qq+Rx53jsuKy0jHEPOgZ+jUr/qe65DxMSK3eRN6aZ9MqFOiTCHhs+HJ+cLvPypnu6j1qUT4pb6qpn2ON8IXLm9F83shKy51wHUsK5pMicD6lHQvY1llBcAe/Zti2ozb9lbGGcM+gnMte1d4TOixau4YpLkle/SpW883rodfh+wS1KDyDNpvYp+rs7nIwu7E9P1c9lLRs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(451199018)(86362001)(38100700002)(31696002)(82960400001)(6636002)(36756003)(4326008)(66556008)(66476007)(66946007)(41300700001)(54906003)(37006003)(316002)(8676002)(5660300002)(4744005)(6862004)(8936002)(2906002)(2616005)(478600001)(6486002)(6512007)(186003)(6506007)(6666004)(26005)(53546011)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUpxMVZIby9aZ2QxTzhyak8rNy9sdEdVRGNiTHdHWTRDM0ZPNVFCRWgvRldG?= =?utf-8?B?UGJDV3oxN0ZJKy96OVJrZ3V0SitkZWtvTlFUdGgyQlZzS0FvUjhVWW9KMmNT?= =?utf-8?B?MHE1dXJoWjlWZmx4SWVmM3BXWEZBS1Y2OUx5UWRlOStJUlkwUEZUZS9XSWts?= =?utf-8?B?WklKcDF3N3JhQWxVUlhUR0I3VCtpZGlWYmpvWEtLM3E3TXNtSlREY3RiTTV2?= =?utf-8?B?N1JFTGRmVk4rOW5zZzdDRmtrdk5ZOTl3bnc3RnBLK04yL1VQSHBLc1pCSzl3?= =?utf-8?B?QlBRY0NBWXphcDQ1bm9EN0d2U2RpNEs5Z05DNTJNdHlWNmtVTER1M1QrcTJF?= =?utf-8?B?dFNuT0RGUjZDMzFVamFmaGZVODJGdE1aRnhwU0RJbkJHOVlkUVg0cGZSQ0tX?= =?utf-8?B?d2pGbVVKYU5BSFhTV0pXbjQ4czk3RFBTWnJxK2xPNlhNQVgxd0QxSlJiK2pt?= =?utf-8?B?UG9qSG1CVXRwQ0lzK2dEOWVnSEVoWXB4NjNVWjRScmV2VEV6aTJQekFsN3RF?= =?utf-8?B?VUNrbytDdWI5WEd5dEdOaWRaTERiTW9hb05yTklEaU9jN0RrSVNKNzJmV3hp?= =?utf-8?B?QjYxNUVaS0lmRGZwajFCc2VjaTNId2ExcTB3QkVSL1hKYTE0ZGtMVGRHNXdy?= =?utf-8?B?eG9oKzYrSXZSWE1yMDE5bEdzSi8xOFFOZmxWN1FORTJ1ZXFXVzN6Q2NpMW9M?= =?utf-8?B?Z3BycU1EcVRXU0cxRUFQbUVnenF3R21kSGlyVEFWalU4UmZLVFBEQXNseEpZ?= =?utf-8?B?SDA5dENURmY1QXNiVnlUSHBSMHRuNGdIK1Uwb1UyeUcrMWR1QVk5a3piaU5o?= =?utf-8?B?SVhHbGhhZ2dpOG52bCtOMzZ0OUFlK3FqV0V5T3cvYnFyTm1EbkJhZSt3Rys4?= =?utf-8?B?VWtISWtvU1R0WU9adE8yLzJTTkwvb1lLRXRtWHJtS2MzMlArMmkyTVNXL0Iw?= =?utf-8?B?Y2NndEljUzVUMkkyck5RV29wNFFyVW14MS9QTDNYSENUUVI5dzhlVFlnaUhL?= =?utf-8?B?Z3Zxa2NlVmFPYjI4dDI3aXdRMnNJeTUzNTcrM1FIOHk0QlFOTzFlWFllTTAw?= =?utf-8?B?VzZTdnhsYm9lVmF3SU92QXRvZHRJbG1aKzF5cmtGVzU4WXp1N1M4ZGhGamJU?= =?utf-8?B?SFVlQkhWYWZqeTE1c1pndjFSNVZJWnh0eUh6b2JobVNFZkw0RG9hdXZUK3lF?= =?utf-8?B?MC9xVU5EWGVpOS8rc0Mvd2tSOU54NmFuSlRKQnZBcDBUMXBjRGRMQ3ZndlBJ?= =?utf-8?B?YTdVYWtrQXlCaUJXMmtKb3VPZEI4cXhvRWJmS3RSbmNKdTFVTUdTcXBBOWo4?= =?utf-8?B?OHB2SUxtVGgvT0JLZmllV2dJTU5oVUJzakh5dDNOR0F1azBtOFRkcHdwQktC?= =?utf-8?B?OVF3QW9uSW16MWdzS3ZPV3RiaGxpbzNWQlpucFU1VlRRNTA3dXozeEVmU0N2?= =?utf-8?B?dkV5Tlk1MnEwTkg3M0RXTDJJN2p3QVpKSzB1UDBzWk9OcnZncXFjMnJuSzlq?= =?utf-8?B?Ti80K2YrM0tKNVM5TkZpWUNNU2EzbUVzQXV0OHM4dHErOTAreGV6SytIVU1G?= =?utf-8?B?Z2c4NUdvZmh3ZDB6SURqREc1d0lMMU9UR3E1cUNYU2d6RHhmTklteEExUnI2?= =?utf-8?B?NElGQnVSNlRreTQvUkdtQ0lLQm5TL2sxVEFlKzEwblB2bXJKSUt1c2V0NERD?= =?utf-8?B?Rks0TGEzUUJnSkkrbTU4ZEhtalpxcjROZ2VuTlZsdzlIamZZZHRiZm5IT0Rp?= =?utf-8?B?dE03dDdVNjJSUWpWWXk4M3hOOTZSVjlGOEh6UGEyc0JPZE9wdVJOVTFiSDl1?= =?utf-8?B?Y1QxaXpCdDZIWnZwRlY1SUNOVm9TVXpuV3dBL2NIazFDdlFHSEZwTjNzOWpv?= =?utf-8?B?TUJ3dG1IdGR2ZHpHeDFlTXIybEZxdHRXZlBuSGp3cGZQejRNcjY3cGVVQlZN?= =?utf-8?B?SXIzcG41T1U5Z3I2aUtZMWd3YUIzSXZmd05KR1lySUcybWtYSFhtN2tKY0Ji?= =?utf-8?B?eTlzRTlYNWNFa2hWQlcrKzM3TUdabzNoZlVmUnVTWW5Eemh2Y2ZwNVhBWmNR?= =?utf-8?B?RVZSZE91ak9ZbHV0c3QyR2l6eVJ2UXQ5a3dQb0hISkRobzFDNHUxaFgwa3I5?= =?utf-8?B?cVliMFlQU0V1VExIRGRHOFZmeGJEc3pGSGNwOS9lS0MxeGNXMkVBYUNBUFN3?= =?utf-8?B?Y2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Af11IRT525OzRwlT6e2VPm/1wfmJLIe0gUCw1LlLcs4K8xPrwb3TMX95/8pPWnOaMSIrd1XGq8okvy+Cfmp/+qxe8IQD4EiRiO3/J5PoaEvA8QyCNola9GIha/2SyO50uhBwyumFI3Y2OBBsDEYhs2qx3fCTxLtSKprovOJxNw1pandT40uz+c7PYCVh8M5ao37o+0F0zLTKwnviAIblklIJXundjVNgVdwbVwmfimZXctRHswuzoJpRKLA51B9g/KUcXa/WL121KhVm7ALLSLKwdVZ9AcuYKEyNe+s3kFEneab4TjVFryguKrNJX/EVEF2JsY5HVp53f4dM9UuYI5rq07/GNjMEF8j2poSKvSyfe7AfME3ot14yRybtd5ogNbthUEb6NtH7ovJ2Zv7ykaCiFzjt6eXOy4xwFVs3gwt121KYb/1wk+1PpaYG80sL+AEOtF26UQQQ5ahYREJQp3h0MFj1f0GnX2TE38hD3tJHugjgoWwoFpT7HyoASBIjsR61g0UvbekVtGlrvRLIQcN/H3nfFaqw7cYeNqX0QpuLGCfDo63ZKmjYr9t9E/YAUD59MfHlh+Wg92B+ozOOdGJbK0TFO59vi2baykUoWHHesW0qcpzGdkWr0PcLl58+WSM2pL4Na2i1kDazIsf6LgDH7iT4az9232+E7Pmd5qgGClkbl1t5FqgIpKs9p2Co0MWy/Es2CjypttkofdrPzGSfV9pNm3NIhiQlaiHsaGp2HHv9iXqxYeZse6HXsQ5PgZ3s/zg3KjUwOBFIBKu6YjW21Evcobm5h/TSKDbvRaqB2fFxdiWL4ecb4cdIsdC2 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c90aed2d-47a1-4857-16a4-08db103ec781 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 16:56:42.6699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gRZm/FvSOzsqJDFUCHfDCjhjFxqLXr7iXLgp8NddgivkwAqcq4GOAuxhNlC0QGYRUd148Gi0Es+NiUjJ0vTvV7O08Ka9uDFhQczVySSuBV8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6498 On 16/02/2023 4:55 pm, Anthony PERARD wrote: > On Thu, Feb 16, 2023 at 04:50:09PM +0000, Andrew Cooper wrote: >> On 16/02/2023 2:10 pm, Anthony PERARD wrote: >>> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk >>> index 0e4b5e0bd0..ffb6c9f064 100644 >>> --- a/tools/libs/libs.mk >>> +++ b/tools/libs/libs.mk >>> @@ -120,7 +127,7 @@ TAGS: >>> clean:: >>> rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) >>> rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR) >>> - rm -f headers.chk headers.lst >>> + rm -f headers.chk headers.lst lib*.map.tmp .*.tmp >> Doesn't *.tmp cover lib*.map.tmp ? > There is no "*.tmp" on this command line, but there is ".*.tmp". Oh, of course.  I'm blind.  Sorry. > >> Also the subject still needs a FreeBSD->LLVM fix. > Sounds good. > >> Both can be fixed on commit. > If you only fix the subject, then that's fine by me. Sure.  (Although I will throw this through CircleCI first...) ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 17:45:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 17:45:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496697.767576 (Exim 4.92) (envelope-from ) id 1pSiJf-00069X-AI; Thu, 16 Feb 2023 17:45:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496697.767576; Thu, 16 Feb 2023 17:45:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSiJf-00069Q-7T; Thu, 16 Feb 2023 17:45:07 +0000 Received: by outflank-mailman (input) for mailman id 496697; Thu, 16 Feb 2023 17:45:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSiJd-000698-6o for xen-devel@lists.xen.org; Thu, 16 Feb 2023 17:45:05 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a09a86c2-ae21-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 18:45:00 +0100 (CET) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSiJN-0002Kh-7g; Thu, 16 Feb 2023 17:44:49 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSiJN-0000j3-5f; Thu, 16 Feb 2023 17:44:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a09a86c2-ae21-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=gVlMyknwYbBFxIAmk6bJKXG1nRp1hzFYvzTLkEeKQVY=; b=c86dFYsX4HBbPeHKMzANDywfKG o07r6j+cAueqldgLBeuGWLT6XrZIhDjGT+XE8UJHD2lDp2vAcQ1PQ7ws2f/8TiyWVbZAG1bFYnt+k KLrHet9v00P7NMlWarSEN0v9JR4m/uuKahWTI/Gl3WxuqAodVh4dD1YnsulpfO+RRjKE=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 426 v2 (CVE-2022-27672) - x86: Cross-Thread Return Address Predictions Message-Id: Date: Thu, 16 Feb 2023 17:44:49 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-27672 / XSA-426 version 2 x86: Cross-Thread Return Address Predictions UPDATES IN VERSION 2 ==================== Xen 4.16 is vulnerable too. The previous analysis of impacted versions was incorrect. The same patch is applicable to Xen 4.16, and the staging-4.16 branch has already had the backport applied. ISSUE DESCRIPTION ================= It has been discovered that on some AMD CPUs, the RAS (Return Address Stack, also called RAP - Return Address Predictor - in some AMD documentation, and RSB - Return Stack Buffer - in Intel terminology) is dynamically partitioned between non-idle threads. This allows an attacker to control speculative execution on the adjacent thread. For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1045 IMPACT ====== An attacker might be able to infer the contents of arbitrary host memory, including memory assigned to other guests. VULNERABLE SYSTEMS ================== Only AMD CPUs are known to be potentially vulnerable. CPUs from other hardware vendors are not believed to be impacted. Only the Zen1 and Zen2 microarchitectures are believed to be potentially vulnerable. Other microarchitectures are not believed to be vulnerable. Only configurations with SMT activate are potentially vulnerable. If SMT is disabled by the firmware, or at runtime with `smt=0` on Xen's command line, then the platform is not vulnerable. Xen 4.16 and later contains an optimisation, specifically: c/s afab477fba3b ("x86/spec-ctrl: Skip RSB overwriting when safe to do so") which in combination with disabling 32bit PV guests (either at compile time with CONFIG_PV32=n, or at runtime with `pv=no-32` on the command line) renders Xen vulnerable to attack from PV guests. Note: multiple downstreams are known to have backported this optimisation to older versions of Xen. Consult your software vendor documentation. MITIGATION ========== On otherwise-vulnerable configurations, the issue can be mitigated by booting Xen with `spec-ctrl=rsb`, which will override the aforementioned optimisation. Alternatively, SMT can be disabled either in the firmware, or by booting Xen with `smt=0`. Alternatively, if 32bit PV guests are only runtime disabled in Xen, this issue can also be mitigated by booting Xen with `pv=32` to enable support 32bit PV guests. It is not necessary for a 32bit PV guest to actually be running in order to mitigate the issue. RESOLUTION ========== Applying the attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa426.patch xen-unstable - Xen 4.16 $ sha256sum xsa426* 425b1d8931e02852afec9fe3d9f1d009f6d8a33c6387b2e8b3896f374732d470 xsa426.patch $ -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmPuawUMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZW1UIAJ6tjOwbjPJigbSVVfyr5FRnIIYjzVBqkhL5ufvc TQY6ZoPsEEkXzx+jJeVa3NveiegqNvIdK26exlp7n2NrrWCRWlrdGlp+/83TWfUA gwxBzERTVBmi67+9razBYKzxKAwXO2zOHsvgSB2aCX43K+e9SvlKMny8Wp9j0Z99 SRGxzZ8D4I7kKnMMpQIGvp/rt5+k+Q2oxXmNHnIsnCGshF+Y+zK7VwlSEpFYE1ga 78XWYULa1qOEbaj+xsPtf9mMIiWfViwKkX7ZT/EPFBbFxGHSK/aeiQmWdNcFGI3D 6L7vfJIo1Xsw26ozja+C+m3cFPhNSYJDRj92oCKmLPl8iII= =hFGs -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa426.patch" Content-Disposition: attachment; filename="xsa426.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQ3Jvc3MtVGhy ZWFkIFJldHVybiBBZGRyZXNzIFByZWRpY3Rpb25zCgpUaGlzIGlzIFhTQS00 MjYgLyBDVkUtMjAyMi0yNzY3MgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENv b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6 IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KCmRpZmYgLS1naXQg YS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MgYi9kb2NzL21p c2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MKaW5kZXggOTIzOTEwZjU1M2M1 Li5hMmZmMzhjZGViZjIgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlzYy94ZW4tY29t bWFuZC1saW5lLnBhbmRvYworKysgYi9kb2NzL21pc2MveGVuLWNvbW1hbmQt bGluZS5wYW5kb2MKQEAgLTIzNTUsNyArMjM1NSw3IEBAIGd1ZXN0cyB0byB1 c2UuCiAgIG9uIGVudHJ5IGFuZCBleGl0LiAgVGhlc2UgYmxvY2tzIGFyZSBu ZWNlc3NhcnkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgogICBndWVzdHMg YW5kIGlmIGRpc2FibGVkLCBndWVzdHMgd2lsbCBiZSB1bmFibGUgdG8gdXNl IElCUlMvU1RJQlAvU1NCRC9ldGMuCiAqIGByc2I9YCBvZmZlcnMgY29udHJv bCBvdmVyIHdoZXRoZXIgdG8gb3ZlcndyaXRlIHRoZSBSZXR1cm4gU3RhY2sg QnVmZmVyIC8KLSAgUmV0dXJuIEFkZHJlc3MgU3RhY2sgb24gZW50cnkgdG8g WGVuLgorICBSZXR1cm4gQWRkcmVzcyBTdGFjayBvbiBlbnRyeSB0byBYZW4g YW5kIG9uIGlkbGUuCiAqIGBtZC1jbGVhcj1gIG9mZmVycyBjb250cm9sIG92 ZXIgd2hldGhlciB0byB1c2UgVkVSVyB0byBmbHVzaAogICBtaWNyb2FyY2hp dGVjdHVyYWwgYnVmZmVycyBvbiBpZGxlIGFuZCBleGl0IGZyb20gWGVuLiAg Kk5vdGU6IEZvcgogICBjb21wYXRpYmlsaXR5IHdpdGggZGV2ZWxvcG1lbnQg dmVyc2lvbnMgb2YgdGhpcyBmaXgsIGBtZHM9YCBpcyBhbHNvIGFjY2VwdGVk CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVh dHVyZXMuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJl cy5oCmluZGV4IDg2NWYxMTA5ODY2ZC4uZGEwNTkzZGU4NTQyIDEwMDY0NAot LS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaAor KysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY3B1ZmVhdHVyZXMuaApA QCAtMzUsNyArMzUsOCBAQCBYRU5fQ1BVRkVBVFVSRShTQ19SU0JfSFZNLCAg ICAgICAgWDg2X1NZTlRIKDE5KSkgLyogUlNCIG92ZXJ3cml0ZSBuZWVkZWQg Zm9yIEhWTQogWEVOX0NQVUZFQVRVUkUoWEVOX1NFTEZTTk9PUCwgICAgIFg4 Nl9TWU5USCgyMCkpIC8qIFNFTEZTTk9PUCBnZXRzIHVzZWQgYnkgWGVuIGl0 c2VsZiAqLwogWEVOX0NQVUZFQVRVUkUoU0NfTVNSX0lETEUsICAgICAgIFg4 Nl9TWU5USCgyMSkpIC8qIENsZWFyIE1TUl9TUEVDX0NUUkwgb24gaWRsZSAq LwogWEVOX0NQVUZFQVRVUkUoWEVOX0xCUiwgICAgICAgICAgIFg4Nl9TWU5U SCgyMikpIC8qIFhlbiB1c2VzIE1TUl9ERUJVR0NUTC5MQlIgKi8KLS8qIEJp dHMgMjMsMjQgdW51c2VkLiAqLworLyogQml0cyAyMyB1bnVzZWQuICovCitY RU5fQ1BVRkVBVFVSRShTQ19SU0JfSURMRSwgICAgICAgWDg2X1NZTlRIKDI0 KSkgLyogUlNCIG92ZXJ3cml0ZSBuZWVkZWQgZm9yIGlkbGUuICovCiBYRU5f Q1BVRkVBVFVSRShTQ19WRVJXX0lETEUsICAgICAgWDg2X1NZTlRIKDI1KSkg LyogVkVSVyB1c2VkIGJ5IFhlbiBmb3IgaWRsZSAqLwogWEVOX0NQVUZFQVRV UkUoWEVOX1NIU1RLLCAgICAgICAgIFg4Nl9TWU5USCgyNikpIC8qIFhlbiB1 c2VzIENFVCBTaGFkb3cgU3RhY2tzICovCiBYRU5fQ1BVRkVBVFVSRShYRU5f SUJULCAgICAgICAgICAgWDg2X1NZTlRIKDI3KSkgLyogWGVuIHVzZXMgQ0VU IEluZGlyZWN0IEJyYW5jaCBUcmFja2luZyAqLwpkaWZmIC0tZ2l0IGEveGVu L2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oIGIveGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCmluZGV4IDZhNzdjMzkzNzg0 NC4uMzkxOTczZWY2YTI4IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvaW5j bHVkZS9hc20vc3BlY19jdHJsLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3NwZWNfY3RybC5oCkBAIC0xNTksNiArMTU5LDIxIEBAIHN0YXRp YyBhbHdheXNfaW5saW5lIHZvaWQgc3BlY19jdHJsX2VudGVyX2lkbGUoc3Ry dWN0IGNwdV9pbmZvICppbmZvKQogICAgICAqLwogICAgIGFsdGVybmF0aXZl X2lucHV0KCIiLCAidmVydyAlW3NlbF0iLCBYODZfRkVBVFVSRV9TQ19WRVJX X0lETEUsCiAgICAgICAgICAgICAgICAgICAgICAgW3NlbF0gIm0iIChpbmZv LT52ZXJ3X3NlbCkpOworCisgICAgLyoKKyAgICAgKiBDcm9zcy1UaHJlYWQg UmV0dXJuIEFkZHJlc3MgUHJlZGljdGlvbnM6CisgICAgICoKKyAgICAgKiBP biB2dWxuZXJhYmxlIHN5c3RlbXMsIHRoZSByZXR1cm4gcHJlZGljdGlvbnMg KFJTQi9SQVMpIGFyZSBzdGF0aWNhbGx5CisgICAgICogcGFydGl0aW9uZWQg YmV0d2VlbiBhY3RpdmUgdGhyZWFkcy4gIFdoZW4gZW50ZXJpbmcgaWRsZSwg b3VyIGVudHJpZXMKKyAgICAgKiBhcmUgcmUtcGFydGl0aW9uZWQgdG8gYWxs b3cgdGhlIG90aGVyIHRocmVhZHMgdG8gdXNlIHRoZW0uCisgICAgICoKKyAg ICAgKiBJbiBzb21lIGNhc2VzLCB3ZSBtaWdodCBzdGlsbCBoYXZlIGd1ZXN0 IGVudHJpZXMgaW4gdGhlIFJBUywgc28gZmx1c2gKKyAgICAgKiB0aGVtIGJl Zm9yZSBpbmplY3RpbmcgdGhlbSBzaWRld2F5cyB0byBvdXIgc2libGluZyB0 aHJlYWQuCisgICAgICoKKyAgICAgKiAoYWIpdXNlIGFsdGVybmF0aXZlX2lu cHV0KCkgdG8gc3BlY2lmeSBjbG9iYmVycy4KKyAgICAgKi8KKyAgICBhbHRl cm5hdGl2ZV9pbnB1dCgiIiwgIkRPX09WRVJXUklURV9SU0IiLCBYODZfRkVB VFVSRV9TQ19SU0JfSURMRSwKKyAgICAgICAgICAgICAgICAgICAgICA6ICJy YXgiLCAicmN4Iik7CiB9CiAKIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAq YCwgYGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBjYWxsLiAqLwpkaWZm IC0tZ2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gv eDg2L3NwZWNfY3RybC5jCmluZGV4IGEzMjBiODE5NDdjOC4uZTgwZTJhNWVk MWE5IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysr IGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMzI3LDEzICsxMzI3 LDM4IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlv bnModm9pZCkKICAgICAgKiAzKSBTb21lIENQVXMgaGF2ZSBSU0JzIHdoaWNo IGFyZSBub3QgZnVsbCB3aWR0aCwgd2hpY2ggYWxsb3cgdGhlCiAgICAgICog ICAgYXR0YWNrZXIncyBlbnRyaWVzIHRvIGFsaWFzIFhlbiBhZGRyZXNzZXMu CiAgICAgICoKKyAgICAgKiA0KSBTb21lIENQVXMgaGF2ZSBSU0JzIHdoaWNo IGFyZSByZS1wYXJ0aXRpb25lZCBiYXNlZCBvbiB0aHJlYWQKKyAgICAgKiAg ICBpZGxlbmVzcywgd2hpY2ggYWxsb3dzIGFuIGF0dGFja2VyIHRvIGluamVj dCBlbnRyaWVzIGludG8gdGhlIG90aGVyCisgICAgICogICAgdGhyZWFkLiAg V2Ugc3RpbGwgYWN0aXZlIHRoZSBvcHRpbWlzYXRpb24gaW4gdGhpcyBjYXNl LCBhbmQgbWl0aWdhdGUKKyAgICAgKiAgICBpbiB0aGUgaWRsZSBwYXRoIHdo aWNoIGhhcyBsb3dlciBvdmVyaGVhZC4KKyAgICAgKgogICAgICAqIEl0IGlz IHNhZmUgdG8gdHVybiBvZmYgUlNCIHN0dWZmaW5nIHdoZW4gWGVuIGlzIHVz aW5nIFNNRVAgaXRzZWxmLCBhbmQKICAgICAgKiAzMmJpdCBQViBndWVzdHMg YXJlIGRpc2FibGVkLCBhbmQgd2hlbiB0aGUgUlNCIGlzIGZ1bGwgd2lkdGgu CiAgICAgICovCiAgICAgQlVJTERfQlVHX09OKFJPX01QVF9WSVJUX1NUQVJU ICE9IFBNTDRfQUREUigyNTYpKTsKLSAgICBpZiAoIG9wdF9yc2JfcHYgPT0g LTEgJiYgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1hFTl9TTUVQKSAmJgot ICAgICAgICAgIW9wdF9wdjMyICYmIHJzYl9pc19mdWxsX3dpZHRoKCkgKQot ICAgICAgICBvcHRfcnNiX3B2ID0gMDsKKyAgICBpZiAoIG9wdF9yc2JfcHYg PT0gLTEgKQorICAgIHsKKyAgICAgICAgb3B0X3JzYl9wdiA9IChvcHRfcHYz MiB8fCAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1hFTl9TTUVQKSB8fAor ICAgICAgICAgICAgICAgICAgICAgICFyc2JfaXNfZnVsbF93aWR0aCgpKTsK KworICAgICAgICAvKgorICAgICAgICAgKiBDcm9zcy1UaHJlYWQgUmV0dXJu IEFkZHJlc3MgUHJlZGljdGlvbnMuCisgICAgICAgICAqCisgICAgICAgICAq IFZ1bG5lcmFibGUgc3lzdGVtcyBhcmUgWmVuMS9aZW4yIHVhcmNoLCB3aGlj aCBpcyBBTUQgRmFtMTcgLyBIeWdvbgorICAgICAgICAgKiBGYW0xOCwgd2hl biBTTVQgaXMgYWN0aXZlLgorICAgICAgICAgKgorICAgICAgICAgKiBUbyBt aXRpZ2F0ZSwgd2UgbXVzdCBmbHVzaCB0aGUgUlNCL1JBUy9SQVAgb25jZSBi ZXR3ZWVuIGVudGVyaW5nCisgICAgICAgICAqIFhlbiBhbmQgZ29pbmcgaWRs ZS4KKyAgICAgICAgICoKKyAgICAgICAgICogTW9zdCBjYXNlcyBmbHVzaCBv biBlbnRyeSB0byBYZW4gYW55d2F5LiAgVGhlIG9uZSBjYXNlIHdoZXJlIHdl CisgICAgICAgICAqIGRvbid0IGlzIHdoZW4gdXNpbmcgdGhlIFNNRVAgb3B0 aW1pc2F0aW9uIGZvciBQViBndWVzdHMuICBGbHVzaGluZworICAgICAgICAg KiBiZWZvcmUgZ29pbmcgaWRsZSBpcyBsZXNzIG92ZXJoZWFkIHRoYW4gZmx1 c2hpbmcgb24gUFYgZW50cnkuCisgICAgICAgICAqLworICAgICAgICBpZiAo ICFvcHRfcnNiX3B2ICYmIGh3X3NtdF9lbmFibGVkICYmCisgICAgICAgICAg ICAgKGJvb3RfY3B1X2RhdGEueDg2X3ZlbmRvciAmIChYODZfVkVORE9SX0FN RHxYODZfVkVORE9SX0hZR09OKSkgJiYKKyAgICAgICAgICAgICAoYm9vdF9j cHVfZGF0YS54ODYgPT0gMHgxNyB8fCBib290X2NwdV9kYXRhLng4NiA9PSAw eDE4KSApCisgICAgICAgICAgICBzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9G RUFUVVJFX1NDX1JTQl9JRExFKTsKKyAgICB9CiAKICAgICBpZiAoIG9wdF9y c2JfcHYgKQogICAgIHsK --=separator-- From xen-devel-bounces@lists.xenproject.org Thu Feb 16 19:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 19:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496755.767617 (Exim 4.92) (envelope-from ) id 1pSjkP-0003eP-V2; Thu, 16 Feb 2023 19:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496755.767617; Thu, 16 Feb 2023 19:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSjkP-0003eI-RR; Thu, 16 Feb 2023 19:16:49 +0000 Received: by outflank-mailman (input) for mailman id 496755; Thu, 16 Feb 2023 19:16:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSjkO-0003eB-C6 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 19:16:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 706e92c0-ae2e-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 20:16:43 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 14:16:15 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5377.namprd03.prod.outlook.com (2603:10b6:208:285::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 19:16:09 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 19:16:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 706e92c0-ae2e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676575003; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=R/1xp1D2RB3JIdTjg5eKgdNTLhUlMQoOwPRpo3SD9+c=; b=Rz5+uXlG3QaI3zaG3ha1Ql2VD+YD1XjASvUlKEPMuctuEnjKbJxCuyR4 P/ZB+aWyK7LMAMSbAP3yOMfEl8T2LLWaBI9GHffFWaaxL6PglkaxrAVac P9QFFsdmO9nEqgXbTqovLu4Z1sJKSHBvAApEhCfGvwcqolGQOxM9atGHX 4=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 97278691 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uZYs9aku6GU7OscOqlGvdWXo5gysJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWC2+Gbv7cNmb3e413PYngoR8HvJ7Rm9IyT1RqqX09QiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QGGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 axBLyJXRyDavMaZ3ryVc7Ez35s9Bsa+aevzulk4pd3YJdAPZMmaBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3iea9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDS+fnpqA72TV/wEQXKwMkCEOWg8CHl0/9Uv8GI VAayxQH+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mqodjiBvKF49nCPTs0I2zHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa0eRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:QRUCnqsoSCU8WWPnYxgLPKYU7skCa4Aji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MArhHO1OkO4s1NCZLXTbUQqTXftfBO7ZrwEIdBeOldK1uZ 0QFpSWTeeAdmSS7vyKnjVQcexB/DDvysnB64bjJjVWPHlXgslbnnhE422gYylLrWd9dPwE/d anl6h6T23KQwVqUi33PAhMYwCFzOe75q7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3di0Kov6m /Mli3+/+GGv+ugwhHR+mfP59AO8eGRhudrNYipsIw4Oz/sggGnaMBIXKCDhik8pKWC+Usni9 7FpjYnJoBW52nKdm+4jBPx003L0Soo6VXl1ViE6EGT7PDRdXYfMY5slIhZehzW5w4Ju8x96r tC2ya8u4BMBR3NsSzh75yQPisa3HackD4Hq6o+nnZfWYwRZPt4qpEexlpcFNMlEDjh4I4qPe FyBIX35epQc3mdc3fF11Mfi+CEbzAWJFOrU0ICssua33x/m2149VIRwIglknIJ5PsGOu55zt WBFp4tuKBFT8cQY644LvwGW9GLBmvERg+JGH6OIHz8fZt3e07lmtrS2vEY9euqcJsHwN8Zg5 LaSm5VsmY0ZgbHFdCO5ptW6RrAKV/NHAgF8vsupaSRh4eMAYYCaUa4ORQTeoqb0rsi6/TgKr WO0Mk8OY6lEYPscbw5qzEWFaMib0X2a/dlyerTa2j+0/4jFbeaxtAzUMyjUoYFQgxUE1/XMz 8kYAXZAvlmwwSCZkLY6SKhLk8FPHaPsq5NLA== X-IronPort-AV: E=Sophos;i="5.97,302,1669093200"; d="scan'208";a="97278691" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/NXhttVcoskLkIFbVIQA5disUpr8YHp6IfOHjO95W1aOoLgj16JDtKowCfZAiU+Mr18/5igDZobIOES9ilF3xAQkHDsbbnzafD0kDqGVjFFkyyYqjIoCSVBGsMEfYSUVrKJoefbtyNFq4XgM9+tQ89EsY79UiaFeXJoFpgUF17HN+SfI+EM7CJ/yhXVembj1z+8hzntYSmSv6P3YK0YoPnQzB3xRfadFXv6yOi/VfUT4yfytcs+v2bEYRwUdlDRvl79ySmb5GMSFIAwjl53Q+RFeiZEHZuxYUBrRxdwm2rPx14Vth11PeKztxFX8muWDAJ4ZxvOzaSIlf5fIof+Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcuN25BzXiIPNxzbrQUOhWcdNGeIF9a4jM1EDS0Yz2M=; b=KnJNyWcpJCwaWwzgX3FVi81Becd2UUMx29giXGS2/A27C3RcSQ+ZYMEMNOaKfFFZDQ4nLyJcDPh8yL99GAj19XjY2sN5Qwmmwm189eN87vnzVe1IiMjZuszQRZYXCzywuzxkU72QwExr+JL3cqqP7JIGBVSHvNMD7uFGKliP3nRYM/oGk/yVe2b/uw8v7b+74v2qCmS9ykKz7EdjWzGiZdbNk8ef2Nz830cFOzIWcxkF6atwT/QKndQpvD9dDVOqFmWavuc8cm+t89s5wwC4ZkZkmhq1AW65qGuUVDuTXu5ARUbF6be3qJZ5eB4OjQfozMQEGd5ya7/HEYJkdc2iWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcuN25BzXiIPNxzbrQUOhWcdNGeIF9a4jM1EDS0Yz2M=; b=YYzJ/IYFzEIee2h/y8DP0tLc0d12HD2c02naU+PEYgJs9KYa49hUdQMVdxc7cZcAL2gVSlpkiN6L55rT0yfN5VvbTRcgPitKcBASEfF9UsxUoTSOOjHwg4q8Ptpt3/M0OsKAeNeCPIZsZP7yWOp5QNzhmoVUX7wal9QNvXEFvcU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <2d68b595-f49a-884c-de1c-12b34a9c11bf@citrix.com> Date: Thu, 16 Feb 2023 19:16:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 4/6] x86/MSI: use standard C types in structures/unions Content-Language: en-GB To: Jan Beulich Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <9f375055-eff2-010b-c904-e4122b834777@suse.com> <7e160b28-ba80-c2bb-fa2a-5d5411c7d22d@suse.com> In-Reply-To: <7e160b28-ba80-c2bb-fa2a-5d5411c7d22d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0419.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5377:EE_ X-MS-Office365-Filtering-Correlation-Id: 626c0028-af9e-4ff8-527c-08db105241bd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OeZPyj9CEAKVbKYn3n71p26724CVrmPtfwvVVFEj6aPJcXFFd6OPtXtmK552K2fHdLm7SKE/NKYjto9yW/8qWXsrhrIoM5FvfqSII2nNObOgpVRU5Jy8QAYlaio19oiUUZgQ/SaCjpXwPaG6oL7XlVagHwPdKoZ5bjAEpR60FARZWs9fEhskpzzXYCOUAHms/YeiE6OXev+GJ/DM4ByZEo4bCne2EySbq7FRiDFpaLnDOTbkQuIE0+PWQ8La8h0Q76vcMZYL7MUqBM/wPCDnLpyOyKKJ+05gwONZWqOLICzqtPqwRKW3myuQFaqmhd7adidUHsk2zXyCZfoBBN7xi5TJZXVuTNKaVxhUhgYeeMbAZAjSDCFCQPWlK8nLzg5jYnGth2UHBS/Qqm0PxkQi0OfKTetYZri55b7IDGUyIFspywypOcVHMpqtcmv+wYnQvI669+POhxZigIQxDv/QzYm60wyCiE4U2RHzLCrXwNGMwYpP05U5IPeisvA06EIIRGLgCZ5pTDU/xG3e/1iaSEcfZdI+MetWv3OpMdDNLJmrry+3YzoRviMQ+7ESWU7W2seRt1l/gbp45SIN0YVQgc+PHRDGH0h3xicsAJFhF+EsP2c0QSw4wO4JZMBkzun04XdGdgF5Uvowb5kLt0q7YIF0XciOCVo0dlOJsW3CPNpb2bK3X2VVFWkgMpTgpMGMHgx6jA/m2lekJN3KILpfOWlWYgVGVS9VMkEm2wzcvKc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199018)(5660300002)(36756003)(83380400001)(31686004)(6486002)(478600001)(2616005)(53546011)(26005)(6506007)(6512007)(186003)(6666004)(4326008)(66556008)(66476007)(6916009)(8676002)(82960400001)(66946007)(31696002)(8936002)(41300700001)(86362001)(54906003)(38100700002)(316002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0VrYkNOSmJDamMzL2g2SlZoTDliejRidXdodjY0cTkwbnJvUDlzUVdUUDQ2?= =?utf-8?B?TmZITWZ5WnVGOVNJSnhTVmlTd21PTjV3NXZ5cHZMNlJqejBwaEJOTmdrbW92?= =?utf-8?B?RGNYbVVPcTRzWHlrY3RsaGZybVNLbXBRdFhTWDdMNWRZcEpWbmJEMjFhL2tG?= =?utf-8?B?YVkrcEd2ZTVxNlhwaWJGRWNQbms1M3J3OW1qdy85WWNPaFlQYVRXOXhaRUsr?= =?utf-8?B?YTJFcENKMGY4a3Z5b0k1RlNSY3Q4YVZmUjYyaDJKSmFWQ1ZDUjdxc1loMUpL?= =?utf-8?B?MDF3NlBWTFFmR0dCQk1rUStBOG5oeGYxMUZsSHBSQkx3cU5qb21kV05BWmll?= =?utf-8?B?OEszS0pvazZlaFRTeEkwTWdFMHhmVmNURnRaWEpVcDQvM3J6U3BhTTNDN0lS?= =?utf-8?B?eUduQmNvcGx1NnRROTYwNHVoYWIzOXdYbVplZ2dmTEJsM1l5YnhCb1Bpdldp?= =?utf-8?B?dkgzY2t2NjltNkMwVkorbm41Vy9FaG5IOG9lbWdmZnUxZkVQNm5ZelF5REhN?= =?utf-8?B?Nm53b1BpVnRKYjQ0MU9SQTMxUjNCb1ZkSm5iWHJQVWhiVjFpZ2VibitGeW9u?= =?utf-8?B?SlYxWFhtZWxGdngwaitIR1hkSWxrd2RYYk03Vm1kcEw3bCt3WEhDU2RndjVY?= =?utf-8?B?UEEzL1ZwSGYxTXZJZDRuWjRmaWlJbkhXZmtwVGdRSTNLbE5BTnY2eWh4REpH?= =?utf-8?B?bVludTMra0ZUcEVnTGV6dUtDbTNUNUpZQmVsUnAzbGpuOXRYWGZaS2E2aEZy?= =?utf-8?B?MG42dCtTMU9sR05MS3U3N1BQTFdLSWRSZkJ3TU1SSTNWdStxZ2pDNGtIeVlU?= =?utf-8?B?ZU5GT1Vwczk4SGNTbkZWOHR1KzVFVnM5K001bUtGN1BFdHp2bGRIdUlOd1E1?= =?utf-8?B?OUxaL1JjcUExVGFpSGtZVzluRW1XRDFWbTlPTlZaa0RHb2kxQlRrV1ZjcXpP?= =?utf-8?B?ODlwd0ZvMlNBZ2xrbWRrVkNlWVkxQUtrajFDK1VCK1VyM0RyMG5jWHhrbzhD?= =?utf-8?B?ZytKZExjQXZaeXdqQ3RBSVI3RXJKa2J5bkdVRjQrcThPaUZqandqSWVaWXFL?= =?utf-8?B?ZWFtd2xSa2l1bmlSN2c0ZGp5SkZiU2VWUDJTM3ZZallhTjFxNXlvOHkyL1Ix?= =?utf-8?B?V05uUGJURDRrSW1Gbnp5Sm9Na2puZmZYTWE4L2dYdWR6VXlidVlpVklMSzZN?= =?utf-8?B?N2EwOURtZE9ZcXFMQ2VWUjh4ckV0WWhwMlRhcmxXR2pnTXBlcmdIRHJFRXRr?= =?utf-8?B?V0F2K2NxQ3RFMk1MMmRMRUVjUHhJaUVKTjJJWmtOdW1CdGxzOWJBYWhHcHRl?= =?utf-8?B?RXdoeVQ2TEZVS1NCbEU1aXl2M3U0Rjd3dTZvMzE1QTR0TTNPSG83SG5BWkNp?= =?utf-8?B?eitkSUdVMjdla1RTQVdIN1ZxcmRGa3RBL3ZzYjhMNm15UXZiNmhsMGlUbUk2?= =?utf-8?B?R2RIRzNwTzFWemx0U3FWZi9jQzczNVN0NjRKWlVlYXArOVF5bjl2aWFWRHVK?= =?utf-8?B?dDdLNmNUY0pPenN4QjdNWXlKT29BbGZiVTlPckRaSVdkK1I0ZXg0d3o1bG1K?= =?utf-8?B?UElkOExHZ3FFc3k2RC83dVh3dTZhYWZ4MzBiOFBLdzJxblhCNlBUeGpubDBB?= =?utf-8?B?UytTL2NodFFMd3BablNkaHZ3V3liN0MyclhWV0pIWUpDZGE2OWVEdWdZOXNH?= =?utf-8?B?Y3VSY0FMNjkzWFhLaUJ5WTQ4Sk05RVErSWJrNU5kZ3NmTkFOeUtUSk4zZXE4?= =?utf-8?B?SDBMTDY3SWhtSEY2aWJ1YWVlQlN1VnYrckZYY0c4NjZQM2Z1K3hMeUdzTDZK?= =?utf-8?B?c0lLMW5hR2s1Z1QybHVxUVhxVjVyMkxtSTB2SkVtY25QcXk5Tk1OeVB2clV6?= =?utf-8?B?T1pKN0ZWdDM1SVltK2JQZ29QRTRKRWVXR0FTNWRIcmxxTVViM3VqY3dHK3BC?= =?utf-8?B?NEQ0c3ZHejlIajFOR2lXYi91dnRTVkh2a2pwOHhwMExUZFE4VzFKM2RQM1JN?= =?utf-8?B?MzVqVmdDdVptdG0yYzZCUnZJRFl3MWVHYzRjTFBlNGlKZTFWeHZPSW5aV2t1?= =?utf-8?B?R1ZQM2xPa00xaWplMTVrcVdEL3NmM1MyaTdGbmN3SFZ4YWRRTWordi9JQ3E2?= =?utf-8?B?VjVjdGJQV21iVXFRNVU4MDJvRUR4enFuQmdxUHJLeGV2OVpHNnUyT0ZBKzk3?= =?utf-8?B?QWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tZjM91Ma/MIH+LkZOg6tYQlpCq6EsULNHHkGfDAXb9oCxkvuotUxIWqZv1GFo+IrFDRzhJcHzPL4RK/IiW77/eTf7NBw3jblHeFUu/5vt4IoRcSpewXjSRb1tC+V+aEE1Bv9UJHei2S4u1BcIikE8YScBc1vHLrTbWNiX0l9tpHYCUM4nFEjLFVMGWvi5Gt1oVzT7lMl17Feqc28W43EvHBJFsd6lbx4pd4HXFeteFqGoMxMqSwnWIN8jnTOWQBMZqpIU+DZybxvshRUaWged7PNvaajgETqPn7GWaJus2ksVkMXmPShreBx43VPfzzaLgYz0zMyTia6nUiFJI37KklYCj6clGWvwOlWBR0hbUJux+6CwivRBj0zJ7nMawTCimKY2T7mU0H5B066XXGlhu7plGxI++474bu5oCoTyDMTA9ZMxQwMFOYUCJ0gqcS6daJ/sgTM9/rGsucr7jcYr0qLhSlUGnb8rGwqqJe+6iN/bYV0I5WH4BiVHdp0UNrEKLmVYVXNUo6Mq78VG9DJith5EkzU6/OzqlxrEYqLYngj3K7dkUOVuVWSFhUg0bALHfCF0UVG3vgkCfEurkhdCwM/UZmEPDQ8N/ib2jmDcCg85XgmCfXioz7+HaJ/HMYB2nu1hfHDyttYOftwpQ1O9TOcgUulLytjL+jCqNKVOTV4by5e2RVNS+SWgmmorjG3DEN8Opp26I+wP16dSHCSOqUpKvgzg6oGW9IjOb4Kktg9+iJlSFyV9CqDHqnoAzKGWjy29s4ezRCzT2iHC90gXJd377DVOeNRctSUplFUFqAZhkhicEHWzwznxsaCig3i X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 626c0028-af9e-4ff8-527c-08db105241bd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 19:16:08.7939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k41drYvXr1cqoPK8lAUvnuFCMBV35rBWVOSOUUmscrNtTqMab8o6rdQu/6WT6Edp06pP/KCCsqComhbfxytFgFPG1LMphhyLkcxu049kflU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5377 On 16/02/2023 2:16 pm, Jan Beulich wrote: > On 16.02.2023 11:55, Andrew Cooper wrote: >> On 09/02/2023 10:39 am, Jan Beulich wrote: >>> Consolidate this to use exclusively standard types, and change >>> indentation style to Xen's there at the same time (the file already had >>> a mix of styles). >>> >>> No functional change intended. >>> >>> Signed-off-by: Jan Beulich >> So I suppose Acked-by: Andrew Cooper because >> this is an improvement on the status quo, but I have quite a few requests. > Thanks. I'll be happy to carry out some of them (but the sheer amount makes > it so I'd rather not apply the A-b to the result). It's always difficult to > judge how much "while doing this" is going to be acceptable ... Everything I've suggested is minimal enough IMO. > >>> --- a/xen/arch/x86/include/asm/msi.h >>> +++ b/xen/arch/x86/include/asm/msi.h >>> @@ -66,15 +66,15 @@ struct msi_info { >>> }; >>> >>> struct msi_msg { >>> - union { >>> - u64 address; /* message address */ >>> - struct { >>> - u32 address_lo; /* message address low 32 bits */ >>> - u32 address_hi; /* message address high 32 bits */ >>> - }; >>> - }; >>> - u32 data; /* 16 bits of msi message data */ >>> - u32 dest32; /* used when Interrupt Remapping with EIM is enabled */ >>> + union { >>> + uint64_t address; /* message address */ >>> + struct { >>> + uint32_t address_lo; /* message address low 32 bits */ >>> + uint32_t address_hi; /* message address high 32 bits */ >>> + }; >>> + }; >>> + uint32_t data; /* 16 bits of msi message data */ >>> + uint32_t dest32; /* used when Interrupt Remapping with EIM is enabled */ >> The 16 is actively wrong for data, > It it? The upper 16 bits aren't used, are they? Well... I've just found that my local PCI reference doesn't actually match the spec when it comes to stating the width of the message field.  Guess I need to stop using this reference. But the rules given would require this to turn into uint16_t as that's the specified size of the register...  But that will probably require a separate patch. > >> but honestly it's only this dest32 >> comment which has any value whatsoever (when it has been de-Intel'd). >> >> I'd correct dest32 to reference the AMD too, and delete the rest. > I guess I'll simply drop "with EIM". Yeah, probably the easiest adjustment.  AMD is more complicated anyway IIRC. >>> @@ -94,35 +94,35 @@ extern int pci_restore_msi_state(struct >>> extern int pci_reset_msix_state(struct pci_dev *pdev); >>> >>> struct msi_desc { >>> - struct msi_attrib { >>> - __u8 type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ >>> - __u8 pos; /* Location of the MSI capability */ >>> - __u8 maskbit : 1; /* mask/pending bit supported ? */ >>> - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ >>> - __u8 host_masked : 1; >>> - __u8 guest_masked : 1; >>> - __u16 entry_nr; /* specific enabled entry */ >>> - } msi_attrib; >>> - >>> - bool irte_initialized; >>> - uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ >>> - const struct pi_desc *pi_desc; /* pointer to posted descriptor */ >>> - >>> - struct list_head list; >>> - >>> - union { >>> - void __iomem *mask_base;/* va for the entry in mask table */ >>> - struct { >>> - unsigned int nvec;/* number of vectors */ >>> - unsigned int mpos;/* location of mask register */ >>> - } msi; >>> - unsigned int hpet_id; /* HPET (dev is NULL) */ >>> - }; >>> - struct pci_dev *dev; >>> - int irq; >>> - int remap_index; /* index in interrupt remapping table */ >>> + struct msi_attrib { >>> + uint8_t type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ >>> + uint8_t pos; /* Location of the MSI capability */ >>> + uint8_t maskbit : 1; /* mask/pending bit supported ? */ >>> + uint8_t is_64 : 1; /* Address size: 0=32bit 1=64bit */ >>> + uint8_t host_masked : 1; >>> + uint8_t guest_masked : 1; >>> + uint16_t entry_nr; /* specific enabled entry */ >> entry_nr wants to move up to between pos and maskbit, and then we shrink >> the total structure by 8 bytes (I think). > The struct is 6 bytes now and will be 6 bytes with the adjustment you > suggest. Plus I'd prefer to not do any re-ordering in this patch. Ah, so I see what went wrong.  Right now, we've got: 8b type 8b pos 4b the bitfields 12b padding 16b entry_nr and rearranging it moves the padding to the end but doesn't drop it, because overall the structure has 16b alignment because of the uint16_t If it were packed, then the following byte fields would shuffle up into the padding, and there would ba knockon effect. But don't worry seeing as it doesn't make a difference. > >> Additionally, the structure doesn't need to be packed - its a single >> uint32_t's worth of bitfield. > Like with re-ordering I would prefer to not touch entirely unrelated > aspects. I'll see if I can motivate myself to make a separate follow-on > change. Personally I'd consider dropping some __packed as sufficiently relevant to this change to be included, but fine. > >> Finally, can we drop the reserved fields and leave them as anonymous >> bitfields? > Perhaps - I can give that a try, hoping that we don't access them > anywhere by their name (even if just to e.g. zero them). Well, its easy to try right now.  And if not, then it needs a different patch anyway. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 20:19:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 20:19:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496762.767628 (Exim 4.92) (envelope-from ) id 1pSkj8-00047S-Go; Thu, 16 Feb 2023 20:19:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496762.767628; Thu, 16 Feb 2023 20:19:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSkj8-00047L-Dq; Thu, 16 Feb 2023 20:19:34 +0000 Received: by outflank-mailman (input) for mailman id 496762; Thu, 16 Feb 2023 20:19:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSkj7-00047F-9w for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 20:19:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37ceebbb-ae37-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 21:19:31 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A824860A65; Thu, 16 Feb 2023 20:19:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59B0AC433EF; Thu, 16 Feb 2023 20:19:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37ceebbb-ae37-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676578769; bh=/HZzX5hr2UbDlWa/3ukIpeC1yF9wshB6pHDI/yCYZM4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jyfTG9mv9DjtTvPTgAx2U0N3ghb8vX/hRQCke4cG/ZtWCzsiogCJ/mmpT9KcZagy/ 3faQdebwYHhN89Y1uYDEmKBzkUAWaS0WMA3e1SychkVnpFyIrEdzV6yxZIAUDw9/nq HCULGeCMDlplgxeVboOz2JeKAh4LEsi11GX6HfyYiFZFJwFCF+FNVxf0Le2G1Dj/gV GrGiU8VHa+Gfuam06dJ2t887ducc3kp24acz/+0bh4Wboxh/SL84teY+RHQmfdv7vU LzLDntLi9dO0VZzAwk5oDka95LyZ39mK+c7zLE73MRHMpqzwciIltqJ0xo6FZWKSbR Z93Pv0fTBUbgQ== Date: Thu, 16 Feb 2023 12:19:26 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Anthony PERARD cc: Stefano Stabellini , Andrew Cooper , xen-devel@lists.xenproject.org, Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation: Remove expired root certificates used to be used by let's encrypt In-Reply-To: Message-ID: References: <20230215120208.35807-1-anthony.perard@citrix.com> <20230215120208.35807-4-anthony.perard@citrix.com> <3caee35d-3c0d-7e28-dc66-6f422568edad@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 16 Feb 2023, Anthony PERARD wrote: > On Wed, Feb 15, 2023 at 04:14:53PM -0800, Stefano Stabellini wrote: > > On Wed, 15 Feb 2023, Andrew Cooper wrote: > > > Honestly, I think I'd prefer to drop all of these legacy versions... > > > > Good timing! It just so happens that we need to shave some of the old > > container tests as we have too many build tests on x86 :-) > > > > I would remove Jessie as it reached EOL years ago. Do we really need > > both Centos 7 and 7.2? If not, we could remove 7. > > Actually, 7.2 is older than 7, so I would remove 7.2. (7 would be 7.x so > latest 7 which is 7.9.) Sounds good > > That leaves us with Trusty and Centos 7.2 among these. I would be > > tempted to keep Trusty and add the sed hack of this patch to make it > > work. For Centos 7.2, the hack looks even worse. Would it solve the > > problem to upgrade to the latest Centos 7.x subrelease? Is there really > > no other way to solve the problem? > > So for centos7, the blacklist of the expired root certificate isn't > needed if we simply run `yum update` which for some reason is missing > from the dockerfile... That's much better! From xen-devel-bounces@lists.xenproject.org Thu Feb 16 20:44:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 20:44:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496768.767638 (Exim 4.92) (envelope-from ) id 1pSl75-0008D4-FT; Thu, 16 Feb 2023 20:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496768.767638; Thu, 16 Feb 2023 20:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSl75-0008Cx-Ck; Thu, 16 Feb 2023 20:44:19 +0000 Received: by outflank-mailman (input) for mailman id 496768; Thu, 16 Feb 2023 20:44:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSl73-0008Cr-DT for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 20:44:17 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acda162c-ae3a-11ed-93b5-47a8fe42b414; Thu, 16 Feb 2023 21:44:15 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id t16so7564945edd.10 for ; Thu, 16 Feb 2023 12:44:15 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id l26-20020a170906a41a00b0088991314edesm1229531ejz.7.2023.02.16.12.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 12:44:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acda162c-ae3a-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=MTlmbdwgPwCwyv2ctKWgD4JM7LkeG14BYSM0zgf92vE=; b=UcSCCM4DFG9i1RTrgF76JeDtjSAt49FLuchlMjCbrg3CFlaPseT21prDZHvGDH2OvP YdmS2t6tO7JVI+gI8zankFmCieZQiTgkgZeNdUSPlbV1cB1sSmo5Pps1qhRBFAtUijec fKY7oSHHNcwdcJKJvvs5WF5BOSWz2/cIGLrt6GNNBCXvWrP41pu6bVtlrCbGUEPXvOyT ABVIUUdq4D9ZQehVjK1YXWYqiGoXHTvqvPQgOnoVdHg5RWGbpHGLpIlLMd9bAKGghv4K yeRrgaDCFWEHqDq3/zUD8TLFk+mpEd+0V+qskR3O4yz8pNhrXH6G36umgfjgTQ6I0iHp jTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MTlmbdwgPwCwyv2ctKWgD4JM7LkeG14BYSM0zgf92vE=; b=BZIgOa3r+NjuRmsktDbTHQUfsweY82xSw3Bc4pOJkVjKheMVeu73MQvOMUXu8WInip 2MoHpF3FHb8YtB+y/wcfXlvQeVjI3SxTj0FT5du/iIphLcqNoaWipdnXQywsPW+GsRCh XIu6duXQsoJdvV2yOQiHccoYbRZWjYxOUrQxM+xWrnk7sonM3zGDdv2FJzI1p2CR1xYE Nxh+xnlwVg7X3fyeEkOaRpdHJByXfXKRIZDOw55jMpbyg4Gi9KjxRd2TlcYQWzJk00CS r9fqa8OQGSKmISIGEp728lpA5DtsrZUk73RsLgUOXy0nb9VFe/nh/wLcRwYo+Z34TzI8 3bag== X-Gm-Message-State: AO0yUKXnl1usw2TUNxKSghCbfybH6C+N3W74N8q6Wb0gDqc59uhcZOrx TZUev5maGvshpk1Vj860XA4= X-Google-Smtp-Source: AK7set+e5hkyH8/oXipt0xcwehIUcgrKl08m64ExV6ssh4dfGJz2hgwJNcm6AuXxH2qTb1L9BYGsQQ== X-Received: by 2002:a17:907:174d:b0:880:3129:d84a with SMTP id lf13-20020a170907174d00b008803129d84amr7392342ejc.60.1676580254347; Thu, 16 Feb 2023 12:44:14 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Andrew Cooper , Jan Beulich Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Thu, 16 Feb 2023 22:44:12 +0200 In-Reply-To: <4c52d703-dd7c-b316-5e37-38c9aa705725@citrix.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> <4c52d703-dd7c-b316-5e37-38c9aa705725@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Thu, 2023-02-16 at 12:19 +0000, Andrew Cooper wrote: > On 16/02/2023 12:09 pm, Oleksii wrote: > > On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: > > > On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: > > > > On 15.02.2023 18:59, Oleksii wrote: > > > > > Hello Jan and community, > > > > >=20 > > > > > I experimented and switched RISC-V to x86 implementation. All > > > > > that > > > > > I > > > > > changed in x86 implementation for RISC-V was > > > > > _ASM_BUGFRAME_TEXT. > > > > > Other > > > > > things are the same as for x86. > > > > >=20 > > > > > For RISC-V it is fine to skip '%c' modifier so > > > > > _ASM_BUGFRAME_TEXT > > > > > will > > > > > look like: > > > > >=20 > > > > > #define _ASM_BUGFRAME_TEXT(second_frame) \ > > > > > =C2=A0=C2=A0=C2=A0 ".Lbug%=3D: ebreak\n"=C2=A0=C2=A0=20 > > > > > =C2=A0=C2=A0=C2=A0 ".pushsection .bug_frames.%[bf_type], \"a\", @= progbits\n" > > > > > =C2=A0=C2=A0=C2=A0 ".p2align 2\n" > > > > > =C2=A0=C2=A0=C2=A0 ".Lfrm%=3D:\n" > > > > > =C2=A0=C2=A0=C2=A0 ".long (.Lbug%=3D - .Lfrm%=3D) + %[bf_line_hi]= \n" > > > > > =C2=A0=C2=A0=C2=A0 ".long (%[bf_ptr] - .Lfrm%=3D) + %[bf_line_lo]= \n" > > > > > =C2=A0=C2=A0=C2=A0 ".if " #second_frame "\n" > > > > > =C2=A0=C2=A0=C2=A0 ".long 0, %[bf_msg] - .Lfrm%=3D\n" > > > > > =C2=A0=C2=A0=C2=A0 ".endif\n" > > > > > =C2=A0=C2=A0=C2=A0 ".popsection\n" > > > > I expect this could be further abstracted such that only the > > > > actual > > > > instruction is arch-specific. > > > Generally, the only thing that can't be abstracted ( as you > > > mentioned > > > is an instruction ). > > >=20 > > > So we can make additional defines: > > > =C2=A0 1. #define MODIFIER "" or "c" (depends on architecture) and us= e > > > it > > > =C2=A0 > > > the following way: > > > =C2=A0 =C2=A0".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", > > > @progbits\n" > > > =C2=A0 =C2=A0... > > > =C2=A0 2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in th= e > > > following way: > > > =C2=A0 =C2=A0".Lbug%=3D: "BUG_ISNTR"\n" > > > =C2=A0 =C2=A0... > > > Except for these defines which should be specified for each > > > architecture > > > all other code will be the same for all architectures. > > >=20 > > > But as I understand with modifier 'c' can be issues that not all > > > compilers support but for ARM and =C2=A0x86 before immediate is > > > present > > > punctuation # or $ which are removed by modifier 'c'. And I am > > > wondering what other ways to remove punctuation before immediate > > > exist. > > >=20 > > > Do you think we should consider that as an issue? > > >=20 > > > > > The only thing I am worried about is: > > > > >=20 > > > > > #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > > > > > =C2=A0 [bf_type] "i" (type), ... > > > > > because as I understand it can be an issue with 'i' modifier > > > > > in > > > > > case of > > > > > PIE. I am not sure that Xen enables PIE somewhere but > > > > > still... > > > > > If it is not an issue then we can use x86 implementation as a > > > > > generic > > > > > one. > > > > "i" is not generally an issue with PIE, it only is when the > > > > value > > > > is > > > > the > > > > address of a symbol. Here "type" is a constant in all cases. > > > > (Or > > > > else > > > > how would you express an immediate operand of an instruction in > > > > an > > > > asm()?) > > > Hmm. I don't know other ways to express an immediate operand > > > except > > > 'i'. > > >=20 > > > It looks like type, line, msg are always 'constants'=C2=A0 > > > ( > > > they possibly can be passed without 'i' and used directly inside > > > asm(): > > > =C2=A0=C2=A0 ... > > > =C2=A0=C2=A0 ".pushsection .bug_frames." __stringify(type) ", \"a\", > > > %progbits\n"\ > > > =C2=A0=C2=A0 ... > > > ) but the issue will be with 'ptr' for which we have to use 'i'. > > >=20 > > > And I am not sure about all 'constants'. For example, I think > > > that it > > > can be an issue with 'line' =3D '((line & ((1 << BUG_LINE_LO_WIDTH) > > > - > > > 1)) > > > << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). > > >=20 > > I think we can avoid 'i' by using 'r' + some kind of mov > > instruction to > > write a register value to memory. The code below is pseudo-code: > > #define _ASM_BUGFRAME_TEXT(second_frame) > > =C2=A0=C2=A0 =C2=A0... > > =C2=A0=C2=A0=C2=A0 "loc_disp:\n" > > =C2=A0=C2=A0=C2=A0 "=C2=A0=C2=A0=C2=A0 .long 0x0" > > =C2=A0=C2=A0=C2=A0 "mov [loc_disp], some_register" > > =C2=A0=C2=A0=C2=A0 ... > > And the we have to define mov for each architecture. >=20 > No, you really cannot.=C2=A0 This is the asm equivalent of writing > something > like this: >=20 > static struct bugframe __section(.bug_frames.1) foo =3D { > =C2=A0=C2=A0=C2=A0 .loc =3D insn - &foo + LINE_LO, > =C2=A0=C2=A0=C2=A0 .msg =3D "bug string" - &foo + LINE_HI, > }; >=20 > It is a data structure, not executable code. Thanks for the clarification. What about mainly using C for BUG_FRAME and only allocating bug_frame sections in assembly? Please look at POC below: #include #include #define BUG_DISP_WIDTH 24 #define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) #define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) struct bug_frame { signed int loc_disp:BUG_DISP_WIDTH; unsigned int line_hi:BUG_LINE_HI_WIDTH; signed int ptr_disp:BUG_DISP_WIDTH; unsigned int line_lo:BUG_LINE_LO_WIDTH; signed int msg_disp[]; }; #define bug_loc(b) ((const void *)(b) + (b)->loc_disp) #define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) #define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ BUG_LINE_LO_WIDTH) + \ (((b)->line_lo + ((b)->ptr_disp < 0)) & =20 \ ((1 << BUG_LINE_LO_WIDTH) - 1))) #define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) #define ALLOCATE_BF_SECTION(has_msg) do { \ asm (".pushsection bug_frames \n" =20 \ ".long 0, 0 \n" =20 \ ".if " #has_msg "\n" =20 \ "\t.long 0 \n" =20 \ "\t.long 0 \n" =20 \ ".endif\n" =20 \ ".popsection" ); =20 \ } while (0) #define MERGE_(a,b) a##b #define UNIQUE_BUG_INSTR_LABEL(a) MERGE_(unique_name_, a) #define BUG_FRAME(type, line, file, has_msg, msg) do { =20 \ unsigned int line_lo =3D (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH); =20 \ unsigned int line_hi =3D ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) << BUG_DISP_WIDTH); =20 \ ALLOCATE_BF_SECTION(1); =20 \ *(signed int *)(&bug_frames) =3D (unsigned long) &&UNIQUE_BUG_INSTR_LABEL(line) - (unsigned long)&bug_frames + line_lo; \ *((signed int *)(&bug_frames) + 1) =3D (unsigned long)file - (unsigned long)&bug_frames + line_hi; =20 \ bug_var.msg_disp[1] =3D (signed int)((unsigned long)#msg - (unsigned long)&bug_frames); =20 \ UNIQUE_BUG_INSTR_LABEL(line): =20 \ asm volatile ("nop"); =20 } while (0) extern char bug_frames[]; static struct bug_frame bug_var __attribute__((section("bug_frames"))); int main() { BUG_FRAME(1, __LINE__, __FILE__, 1, "TEST"); printf("bug_loc: %p\n", bug_loc(&bug_var)); printf("bug_ptr: 0x%x\n", bug_ptr(&bug_var)); printf("__FILE__: %s\n", (char *)bug_ptr(&bug_var)); printf("bug_line: %d\n", bug_line(&bug_var)); printf("msg: %s\n", bug_msg(&bug_var)); BUG_FRAME(1, __LINE__, __FILE__, 1, "NEW TEST"); printf("bug_loc: %p\n", bug_loc(&bug_var)); printf("bug_ptr: 0x%x\n", bug_ptr(&bug_var)); printf("__FILE__: %s\n", (char *)bug_ptr(&bug_var)); printf("bug_line: %d\n", bug_line(&bug_var)); printf("msg: %s\n", bug_msg(&bug_var)); return 0; } Do you think it makes any sense? In this case, all BUG_FRAME can be re- used among all architectures, and only bug instructions should be changed. >=20 > ~Andrew ~ Oleksii From xen-devel-bounces@lists.xenproject.org Thu Feb 16 21:10:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 21:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496775.767650 (Exim 4.92) (envelope-from ) id 1pSlWS-0004Mp-LT; Thu, 16 Feb 2023 21:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496775.767650; Thu, 16 Feb 2023 21:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSlWS-0004Mi-HZ; Thu, 16 Feb 2023 21:10:32 +0000 Received: by outflank-mailman (input) for mailman id 496775; Thu, 16 Feb 2023 21:10:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSlWR-0004MY-Cz; Thu, 16 Feb 2023 21:10:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSlWR-0007PV-AN; Thu, 16 Feb 2023 21:10:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSlWR-0004kz-3G; Thu, 16 Feb 2023 21:10:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSlWR-0004mG-2s; Thu, 16 Feb 2023 21:10:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RAOTKbEtLNrbJ85gdq8jUxN31Nr1re8hXGaaoRcPAWY=; b=f3EwpS5H1Wg02OeQtnGSyF55+U 5DMAS+2Q/VphxORiBJfbiNi/McN5JMymhnRJjpf72jafdow/bCY6MWrwJ0PXgUhTwBDYTq5fYxr21 RrqXHDLx3o5n+pJR5+aTjfYdxdWQPKMONZ6bIzi4vH66h7eKbefZWeJ0tkYJadG9fnW8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 177524: all pass - PUSHED X-Osstest-Versions-This: ovmf=02fcfdce1e5ce86f1951191883e7e30de5aa08be X-Osstest-Versions-That: ovmf=5c551d6d912967ada3084033acea8acf37256043 From: osstest service owner Date: Thu, 16 Feb 2023 21:10:31 +0000 flight 177524 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/177524/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 02fcfdce1e5ce86f1951191883e7e30de5aa08be baseline version: ovmf 5c551d6d912967ada3084033acea8acf37256043 Last test of basis 177466 2023-02-16 06:12:19 Z 0 days Testing same since 177524 2023-02-16 19:12:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Joey Vagedes Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5c551d6d91..02fcfdce1e 02fcfdce1e5ce86f1951191883e7e30de5aa08be -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Feb 16 21:45:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 21:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496782.767661 (Exim 4.92) (envelope-from ) id 1pSm3g-0000Sk-9s; Thu, 16 Feb 2023 21:44:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496782.767661; Thu, 16 Feb 2023 21:44:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSm3g-0000Sd-6U; Thu, 16 Feb 2023 21:44:52 +0000 Received: by outflank-mailman (input) for mailman id 496782; Thu, 16 Feb 2023 21:44:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSm3e-0000ST-TC; Thu, 16 Feb 2023 21:44:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSm3e-00086o-Or; Thu, 16 Feb 2023 21:44:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSm3e-0006Nz-Fz; Thu, 16 Feb 2023 21:44:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSm3e-0005Ui-FT; Thu, 16 Feb 2023 21:44:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ADJUb7utb6wDUFNq+YtOIlIbnoFjOTrz/45S0B1G4f8=; b=mBFNeZ91QIYdVixZtOPhNiVQl1 LXA3gqzwjgWUMwnJdjlX2RllLjTuZUQUhQuXUZ38NkuSnRojidnz/ThydCmC8Yd8waChCHUNEAQg6 5QhCHuQQ8wGfFRH2C/tIeoCYJ10M5S6uPbNrnC+1kWfQNeP+cPocG6fnYIQOjEJDZppM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177485: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-livepatch::broken:regression xen-unstable:test-amd64-amd64-livepatch:host-install(5):broken:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=91c45cfbab5d9878c0a7021f762988a688d5e91d X-Osstest-Versions-That: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 From: osstest service owner Date: Thu, 16 Feb 2023 21:44:50 +0000 flight 177485 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177485/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-livepatch broken test-amd64-amd64-livepatch 5 host-install(5) broken REGR. vs. 177428 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 177428 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 177428 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 177428 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 177428 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177428 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 91c45cfbab5d9878c0a7021f762988a688d5e91d baseline version: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 Last test of basis 177428 2023-02-15 22:10:26 Z 0 days Testing same since 177485 2023-02-16 10:25:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch broken test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-livepatch broken broken-step test-amd64-amd64-livepatch host-install(5) Not pushing. ------------------------------------------------------------ commit 91c45cfbab5d9878c0a7021f762988a688d5e91d Author: Michal Orzel Date: Mon Feb 6 14:05:28 2023 +0100 xen/arm: Print return code from domain_create and construct_dom{0,U} on panic This might be helpful in providing additional debugging information (in most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the code to include printing return code in panic message. In create_dom0, move the call to alloc_dom0_vcpu0() to a separate condition and call a meaningful panic message. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini commit 768e405feabe58effbba75e5b1f782d678119c60 Author: Michal Orzel Date: Tue Feb 14 16:38:42 2023 +0100 automation: Add a true dom0less test on arm32 Add a new test job qemu-smoke-dom0less-arm32-gcc-without-dom0 in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test dom0less domU boot without dom0 (i.e. true dom0less configuration). By passing "without-dom0" as a test variant, the test will clear the dom0 prompt that we grep for as a last step and remove all the DOM0 related options in ImageBuilder configuration. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit d28b226244abcb4b32e07de52df96b6b1686a240 Author: Michal Orzel Date: Tue Feb 14 16:38:41 2023 +0100 automation: Add a gzip compressed kernel image test on arm32 Xen supports booting gzip compressed kernels, therefore add a new test job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test booting a domU with a gzip compressed kernel image (in our case zImage). By passing "gzip" as a test variant, the test will call gzip command to compress kernel image and use it in ImageBuilder configuration for domU1. No need for a specific check to be executed from domU. Being able to see a test message from a boot log is sufficient to mark a test as passed. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit a6ce51ac3de8267ed4e2e7f2e1cf93d51c6d797a Author: Michal Orzel Date: Tue Feb 14 16:38:40 2023 +0100 automation: Add a static memory allocation test on arm32 Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test static memory allocation feature. The test case itself is directly taken from dom0less arm64 testing. Populate build jobs to compile Xen with config options necessary to enable static memory feature. Populate test jobs passing "static-mem" as a test variant. The test configures domU with a static memory region (direct-mapped) and adds a check using /proc/iomem to determine the memory region marked as "System RAM". Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit 42ea8ddab8e003d272e897abec0b89270a90a9b0 Author: Michal Orzel Date: Tue Feb 14 16:38:39 2023 +0100 automation: Add arm32 dom0less testing At the moment, we only perform a single arm32 test in our CI, checking whether dom0 boots successfully or not. This is mostly because we do not have any arm32 runners and we only execute a hypervisor only build. In order not to leave the arm32 testing in such a poor state, add a script qemu-smoke-dom0less-arm32.sh to start testing dom0less configuration, while keeping dom0 to make the test more interesting. The script is mostly based on the one used for dom0 arm32 testing as well as the one used for dom0less arm64 testing. We obtain Debian Bullseye kernel and Alpine Linux busybox-based rootfs. Depending on the test variant, we prepare a test case contained within domU_check variable, that will be executed as part of /init script from domU rootfs. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit a35fccc8df93de7154dba87db6e7bcf391e9d51c Author: Michal Orzel Date: Tue Feb 14 16:38:38 2023 +0100 automation: Switch arm32 cross builds to run on arm64 Due to the limited x86 CI resources slowing down the whole pipeline, switch the arm32 cross builds to be executed on arm64 which is much more capable. For that, rename the existing debian container dockerfile from unstable-arm32-gcc to unstable-arm64v8-arm32-gcc and use arm64v8/debian:unstable as an image. Note, that we cannot use the same container name as we have to keep the backwards compatibility. Take the opportunity to remove extra empty line at the end of a file. Modify the tag of .arm32-cross-build-tmpl to arm64 and update the build jobs accordingly. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 16 22:33:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 22:33:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496791.767671 (Exim 4.92) (envelope-from ) id 1pSmol-0007h9-0Y; Thu, 16 Feb 2023 22:33:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496791.767671; Thu, 16 Feb 2023 22:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSmok-0007h2-UB; Thu, 16 Feb 2023 22:33:30 +0000 Received: by outflank-mailman (input) for mailman id 496791; Thu, 16 Feb 2023 22:33:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSmok-0007gu-4G for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 22:33:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSmoj-0000hW-Nz; Thu, 16 Feb 2023 22:33:29 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pSmoj-0007a8-IU; Thu, 16 Feb 2023 22:33:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=8KOqu+hsOPhy8ulYKnML01YNS9evV4nnF+ZF1pw+LSY=; b=1kLmKDZWgE88ZDNGbp0z2zRMB9 V2Cgp100waCev2F0/y0aesjPiS5uaRi43dTmjhsXsw52OVn8j31et2zF36ggWHVgAcBa9RuwtxXIW RnWtz91qVXKxvoMNattxiE8pQcvcEn+htvoDxzboHiyKeZ8/0wuOZUFkESeOtl7zaxJM=; Message-ID: <085d7520-8b13-ef9e-1c39-55c0062777df@xen.org> Date: Thu, 16 Feb 2023 22:33:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, jgrall@amazon.com, stefano.stabellini@amd.com References: <20230213124438.14836-1-ayan.kumar.halder@amd.com> <20230213124438.14836-3-ayan.kumar.halder@amd.com> From: Julien Grall Subject: Re: [XEN v6 2/2] xen/arm: domain_build: Use pfn start and end address for rangeset_{xxx}_range() In-Reply-To: <20230213124438.14836-3-ayan.kumar.halder@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ayan, The title is a bit strange to read as a 'pfn' is not an address. So how about: xen/arm: domain_build: Track unallocated pages using the frame number On 13/02/2023 12:44, Ayan Kumar Halder wrote: > rangeset_{xxx}_range() functions are invoked with 'start' and 'size' as > arguments which are either 'uint64_t' or 'paddr_t'. However, the function > accepts 'unsigned long' for 'start' and 'size'. 'unsigned long' is 32 bits for > ARM_32. Thus, there is an implicit downcasting from 'uint64_t'/'paddr_t' to > 'unsigned long' when invoking rangeset_{xxx}_range(). > > However, it may seem there is a possibility of lose of data due to truncation. > > In reality, 'start' and 'size' are always page aligned. And ARM_32 currently > supports 40 bits as the width of physical address. > So if the addresses are page aligned, the last 12 bits contain zeroes. > Thus, we could instead pass page frame number which will contain 28 bits (40-12 > on Arm_32) and this can be represented using 'unsigned long'. > > On Arm_64, this change will not induce any adverse side effect as the width of > physical address is 48 bits. Thus, the width of 'pfn' (ie 48 - 12 = 36) can be Technically, this will an MFN rather than PFN (Yes, I now the macro is called PFN_DOWN() but this is a generic name). > represented using 'unsigned long' (which is 64 bits wide). > > Signed-off-by: Ayan Kumar Halder > --- > > Changes from - > > v1 - v5 - NA (New patch introduced in v6). > > xen/arch/arm/domain_build.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index a798e0b256..6a8c7206ae 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1566,7 +1566,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, > { > start = bootinfo.mem.bank[i].start; > end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size; > - res = rangeset_add_range(unalloc_mem, start, end - 1); > + res = rangeset_add_range(unalloc_mem, PFN_DOWN(start), > + PFN_DOWN(end - 1)); > if ( res ) > { > printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1580,7 +1581,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, > { > start = assign_mem->bank[i].start; > end = assign_mem->bank[i].start + assign_mem->bank[i].size; > - res = rangeset_remove_range(unalloc_mem, start, end - 1); > + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), > + PFN_DOWN(end - 1)); > if ( res ) > { > printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1595,7 +1597,8 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, > start = bootinfo.reserved_mem.bank[i].start; > end = bootinfo.reserved_mem.bank[i].start + > bootinfo.reserved_mem.bank[i].size; > - res = rangeset_remove_range(unalloc_mem, start, end - 1); > + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), > + PFN_DOWN(end - 1)); > if ( res ) > { > printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1607,7 +1610,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, > /* Remove grant table region */ > start = kinfo->gnttab_start; > end = kinfo->gnttab_start + kinfo->gnttab_size; > - res = rangeset_remove_range(unalloc_mem, start, end - 1); > + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end - 1)); > if ( res ) > { > printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1617,7 +1620,7 @@ static int __init find_unallocated_memory(const struct kernel_info *kinfo, > > start = 0; > end = (1ULL << p2m_ipa_bits) - 1; > - res = rangeset_report_ranges(unalloc_mem, start, end, > + res = rangeset_report_ranges(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end), > add_ext_regions, ext_regions); I believe you also need to modify add_ext_regions() because the existing code expect an address and we will now provide a frame number. > if ( res ) > ext_regions->nr_banks = 0; > @@ -1639,7 +1642,7 @@ static int __init handle_pci_range(const struct dt_device_node *dev, > > start = addr & PAGE_MASK; > end = PAGE_ALIGN(addr + len); > - res = rangeset_remove_range(mem_holes, start, end - 1); > + res = rangeset_remove_range(mem_holes, PFN_DOWN(start),PFN_DOWN(end - 1)); Coding style: missing space after "," > if ( res ) > { > printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1677,7 +1680,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > /* Start with maximum possible addressable physical memory range */ > start = 0; > end = (1ULL << p2m_ipa_bits) - 1; > - res = rangeset_add_range(mem_holes, start, end); > + res = rangeset_add_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); > if ( res ) > { > printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1708,7 +1711,8 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > > start = addr & PAGE_MASK; > end = PAGE_ALIGN(addr + size); > - res = rangeset_remove_range(mem_holes, start, end - 1); > + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), > + PFN_DOWN(end - 1)); > if ( res ) > { > printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", > @@ -1735,7 +1739,7 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, > > start = 0; > end = (1ULL << p2m_ipa_bits) - 1; > - res = rangeset_report_ranges(mem_holes, start, end, > + res = rangeset_report_ranges(mem_holes, PFN_DOWN(start), PFN_DOWN(end), > add_ext_regions, ext_regions); > if ( res ) > ext_regions->nr_banks = 0; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Feb 16 22:45:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 22:45:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496796.767683 (Exim 4.92) (envelope-from ) id 1pSmzp-0001Dx-1R; Thu, 16 Feb 2023 22:44:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496796.767683; Thu, 16 Feb 2023 22:44:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSmzo-0001Dq-Uv; Thu, 16 Feb 2023 22:44:56 +0000 Received: by outflank-mailman (input) for mailman id 496796; Thu, 16 Feb 2023 22:44:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSmzn-0001Dk-K2 for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 22:44:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8665bb97-ae4b-11ed-933c-83870f6b2ba8; Thu, 16 Feb 2023 23:44:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8665bb97-ae4b-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676587494; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5wFYiOBU0GpxB4acq8/DH18FL7nCMj0GPbvlxjoYnYs=; b=L1eWrIR5LlqOhbHZNsmrE32d/K2UrnjGv+8F2ctEg4oV5NuL0TylnFq6 boe+dxEf8DtVhBui+cYSzMd6F9+gwIKfXpT90PoT+615WzFeItCatpp+1 CgnRuXXqwPbHaFA3+jSAq9K0JkgjAmzMxrEOoiWMzlQ+LnFwx8xVQ1pFs Q=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96773486 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:q1ugcqsxWb8Wb/ptzXLu+ZaVQufnVEBeMUV32f8akzHdYApBsoF/q tZmKWnUPq6PYGSmc40jao7noRwFvZ+HztdjTlBkpHhmFiJE+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWHySFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOj8xN06yof6M/a/kdapCpZh5IeTSM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 zyZoD+lUk9y2Nq3ywierTWDmfLzoxi4WcVMFZmS+d1RnwjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O88Q5RyJy6HUyx2EHWVCRTlEAPQ5sOcmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEsXwQ5uofShp0Jsw+QcZVNM/Lvg/DMFmSlq 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgPZ1 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGsiTKuKGpxeEdMMX KM0kVoIjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwOhDNgDqxyBh3yvFX1 XKnnSGEVytyNEia5GDuG7d1PUEDmEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPrsnekhy P4Gb5Hi40wGAIXDjtz/rdZ7waYicSJqWvgbaqV/Koa+H+aRMDh7UqWBmOp8K90NcmY8vr6gw 0xRk3RwkDLX7UAr4y3QApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:V/qj+6O5Ki9hNcBcTgOjsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+sjzsCWftN9/Yh4dcLy7VpVoBEmsl6KdgrNhWotKPjOW21dARbsKheffKn/bakjDH4Zmvp uIGJIObOEYY2IasS77ijPIb+rJwrO8gd+VbTG19QYSceloAZsQnjuQEmygYzRLrJEtP+tFKH KbjPA33wZJKRwsH7+G7mBuZZm4m+H2 X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="96773486" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen: Remove the use of K&R functions Date: Thu, 16 Feb 2023 22:44:38 +0000 Message-ID: <20230216224438.705395-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Clang-15 (as seen in the FreeBSD 14 tests) complains: arch/x86/time.c:1364:20: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] s_time_t get_s_time() ^ void The error message is a bit confusing but appears to new as part of -Wdeprecated-non-prototype which is part of supporting C2x which formally removes K&R syntax. Either way, fix the offending functions. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu These are all the examples found in a default build of Xen. I'm still finding toolstack violations. --- xen/arch/x86/time.c | 2 +- xen/drivers/passthrough/iommu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c index 782b11c8a97b..4e44a43cc5e8 100644 --- a/xen/arch/x86/time.c +++ b/xen/arch/x86/time.c @@ -1361,7 +1361,7 @@ s_time_t get_s_time_fixed(u64 at_tsc) return t->stamp.local_stime + scale_delta(delta, &t->tsc_scale); } -s_time_t get_s_time() +s_time_t get_s_time(void) { return get_s_time_fixed(0); } diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 921b71e81904..0e187f6ae33c 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -606,7 +606,7 @@ int __init iommu_setup(void) return rc; } -int iommu_suspend() +int iommu_suspend(void) { if ( iommu_enabled ) return iommu_call(iommu_get_ops(), suspend); @@ -614,7 +614,7 @@ int iommu_suspend() return 0; } -void iommu_resume() +void iommu_resume(void) { if ( iommu_enabled ) iommu_vcall(iommu_get_ops(), resume); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Feb 16 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496802.767694 (Exim 4.92) (envelope-from ) id 1pSnHG-0004NZ-I1; Thu, 16 Feb 2023 23:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496802.767694; Thu, 16 Feb 2023 23:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnHG-0004NS-EU; Thu, 16 Feb 2023 23:02:58 +0000 Received: by outflank-mailman (input) for mailman id 496802; Thu, 16 Feb 2023 23:02:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnHE-0004NM-6u for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 23:02:56 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09fe5f1e-ae4e-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 00:02:54 +0100 (CET) Received: from mail-co1nam11lp2173.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 18:02:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6961.namprd03.prod.outlook.com (2603:10b6:a03:381::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 23:02:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 23:02:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09fe5f1e-ae4e-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676588574; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=k6HeOQ0vXGpC1e7qr7oAkG/9iFUfuMAEnjAf9y0Pj1I=; b=fGQQB19+lGznoRjDgYia9m36I4jFAJ/VAjzaMuj/MwXqhoiLJKKqTeli camCN9Xybsyl6DP+wtqa7BCFVOTjaCa+8PdMNBwjTnncpEGI40nmN3mbV WnBGlprgmVxBs/pLm5fvaBnZDCAg00xytCLDbcLp6iXMV6t4ZR3WM31kk 0=; X-IronPort-RemoteIP: 104.47.56.173 X-IronPort-MID: 97390886 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A8K2SqBr9ADQ3xVW/wTiw5YqxClBgxIJ4kV8jS/XYbTApD8jgmYOm 2NLXGDUPqqLMGLxed9waIXi905X68XUnNZlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4ARlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5+B7Lz5P+ echdTUXZTqZpNDpmLO4Vbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDO7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QxnKjCNJMfFG+3qR30R7MnFQ3MhdVdHSwmcnml3GEBPsKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZjQtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoPSlID6ty6+YUr1EuQFZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPtfABYTzhRqYELukcw== IronPort-HdrOrdr: A9a23:221ylq3H0t9cCyengDZqRgqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="97390886" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEHY+Hds1F79GJRjKS9jYPv5+DxN5ukm8kVqbzjbs6qXT7sbbAA+9wV6dAehIDI5H7sIM8gvVgFAdI/NcyjJ+sni5YRN5F2w2J9H97P23ZrV+bCTo/QsNG59DpklGAwEEjxU4Xg1dvSFRAaDs4iPn1oZy/71EXymb30IgW5r9avNGxMAhp3PeWkDxqvL+rQJV9WWBElkm2PibXa8M0elNl9YtwN7vPSv5irKLO17Sd+84ZWvD7dsq23BjPdpVUGthN3T7LFSaqUVM5bkY5cU+ZJV5YSHNVqJBbOn9mF6gytCFwIujAtNgl/zfjw66cwycqOAD6wNR0aBNcgVU/G6BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhOe6FXKu+Cni5AEKMew4GNelTLHcuzr1v3BhAjYkzs=; b=Dn+r1oNRBYV2AZyearqzC661ZTJg/fbqkTv4qft6PhE71ySSFdsFoP7yLYzmuRuL2u5/wQKklYpteL9wTIruBuEsaSDgLkzOA8Ls5O9FidjHkE8r4wQvAYB2mtO8+vkF3UcJVEvfCPHg9k0v6N6S+QjaNhUlSQz1fSNNtNqgcqHjI5O2+ipOzvoT/iBbTbWbwLwkKNlL7B0E635NaeVU+x46ukpATwxS1GY29ka3dVTyzsjfa1fixPXCIxM97vKl+5hi5/hI86JhYmDi7ioItkD9KTXcnd1V7Sr+/+klcb43KqiZdC9cS3ZGSTff+qomorZApPtnTX08uBZoBAIDlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PhOe6FXKu+Cni5AEKMew4GNelTLHcuzr1v3BhAjYkzs=; b=wZ79U9Gla4eZTaLZMxiV1pi9uqaRPCjVwn/mtW3gPZU4g+4dK8R+xBbXyoIeFBFLbVAjJzPTCRRwKR/UZqACNGN698uP49DZzw8OqfAk7o9azN0WCrjtPn/aN4kzt0pjn2a9DNFUZnnxzBlvnft/8ng2LJuGJfs9akFOQuEBw6Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 16 Feb 2023 23:02:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] xen: Remove the use of K&R functions Content-Language: en-GB To: Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230216224438.705395-1-andrew.cooper3@citrix.com> In-Reply-To: <20230216224438.705395-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0193.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6961:EE_ X-MS-Office365-Filtering-Correlation-Id: d8fef562-cf68-4399-4421-08db1071e4d3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wQKerjfXTU+pX09EpXTBPHXeEHR8tPSkV3udtlN+WF2vcGp6cWmB8keUVsAWtlMg99X39VaRHZJGb1aPz9qTp0E3dcqYeMyw9P/jUMqpPq2vLEfZJz6xFtX6xD6+Yx0m5KU0crVkdk7MfLKw7CVhJX5Oq64L9DeV4bk3KevkUCeitGjxesseM91x1exmP4oXq93YMA2F6iyxdbA4TiK4V0jIpFDdfwnDpjpN0KRlqsV9nI4oq9JeGJOCHRPq2WLmRGFdhVTCCiMuJKL/vLK+ExIau1YPdD7cYgb5TCa9q0SLWJ7lhy6jWMq964WXvtF2MYetyEpzhDv9mvb3Sgt4Coz2sNJ3QujvNL1a7rgRe2Wko6KayzhykwYURy3VVovSfZ9QmpbnWA+esdsOmtEncrEx+RM7yBG/CVAFe9a7CwiA0tMDqYxS7nPHMrfNpz4fDeuLinz+b8bYVKJwEijf6umv4ldQV7SDKnOSJtQk0RGxxJFSgRiN4Ar0s6jNZ0VMTdeLve8Cjt3IrukCap8wV5OYbGJ872IUUQJu80cwXpzLUMQ+Hu7ov+yK/Em4sg8XSPejOprvS6x3ZeUEWqIB/bG5SDzmr8jAomYR6+cy8cUROyyA1vJ+QfrvM7PkE6QpUPj+lsXUHAzRrOQs0qbtuJHmZ1rCUjHrNQehqvJ9BnRe/t6e8w3cWBK+KVpJ3UmyExIfwpBoDRYR6WajztGJHZUElu3Np/DDMm9TM2lrivM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(451199018)(82960400001)(478600001)(66946007)(38100700002)(4326008)(66476007)(6666004)(6486002)(2616005)(36756003)(41300700001)(6916009)(8676002)(8936002)(5660300002)(66556008)(2906002)(83380400001)(31696002)(316002)(54906003)(31686004)(26005)(186003)(6512007)(86362001)(53546011)(6506007)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1cwWVZ6NkZqUS9uQisrU2JLbkRjNGlRV0FvUUVOSVJZNDJzTitZOWdrNFdY?= =?utf-8?B?RU92T0tBM1A1ejFuZHlCancwbUZKYktzaFdQcFpvaUp1bDYxV200N0NxRFJH?= =?utf-8?B?WUVJaFp3dThsMzhWMEJ6ZTZJbW9JVVRJQmdwRk95Sll3WWlPVGZqaGVBRmtu?= =?utf-8?B?Q09zaFFlT1NSQkxuVUxzb3B5blBzN25qWUJDdERtZkJKakx2YTFrUC9CNE0z?= =?utf-8?B?REZMV283VXBzSVF0YWh1MEdBbUwwaHVHRTBHdGduK1ZaSFRkM1d1VzFybWRD?= =?utf-8?B?TGhCUmtrQzR2MUp3bHRBSnJ2YzBSSjdxOVJPd1lPenNMVTFiZ21xYmdsK2Zo?= =?utf-8?B?RUxKYlJIMlJDNld2TWgyaHd0RGhLeUdnU01jZXlpMFplTU9NcnJjRnFhYmdk?= =?utf-8?B?STdNMityM0V0ellxbTlSd3d6Qnl2VE5yV2tuVXVtOS81OGg3dS9sNGkvMkVs?= =?utf-8?B?cUd0TFFGVmc0Rk9MdXRybWFpZnpzRXRKQ2dmdW9NZTZDN1p0azhtQWU4YTlq?= =?utf-8?B?U2tOWkZCV3d0QUwwZlJVNW1IcUp6dkYxaVN4c202M3JwVGp4WVlxcWk5OHNM?= =?utf-8?B?c0FLcVRjWlNOWm10VDdlN1FTc2JGVVVrdTJNbUsvNjNibHRCYXAwVlBEckE2?= =?utf-8?B?bEo1d3FLYUlOVlNPcEEwcW4vTnUyWmh0NW1SYTNtK2JaME44eGZObzFScVgw?= =?utf-8?B?cDJsTUhMQSs2UnRzVlJCZnpIYjM0YWNuUGJlbTNRN0gxa1RZL1VBM3R4VGh4?= =?utf-8?B?dkt5U3p0a0RydjlwU1dScGIyWWZTYTlRNklycWxKRXYyL0cvVi9SR3hEY3dT?= =?utf-8?B?Y3NNMGZuSW44NFhmU2tWeE1YMExiN1g1V0hwM2xmV29xM0pBbGl6aUVYeHdU?= =?utf-8?B?dFlkTUEycmpOSnRMZ1F4OVA3R2JNbUdVWlFiWW9lNkI5NjFjR1ZDL0JoYUtr?= =?utf-8?B?MzRwemR3R3NkVmNNNHA4VXVKZDNhUmlWdFIyZjlWcUpqWjRabjBGY2xjZEIz?= =?utf-8?B?ekkrRzIvMWtpTGp5MFRaVjYyVFB0MHRseklIOS9UR0hCb0E1RzZMMlAwRjZL?= =?utf-8?B?a1hGVHVrbjFLV3M2WTcycFlIbWZxUGZpaWNDYjAwdTFUZlFaa0ppY2c5OTJ0?= =?utf-8?B?QWlyMHA1bHhLRzVQVVdjajBGdnpNaHpuN0psa0l2dUlNK2xLSjlwNjFxQ0NB?= =?utf-8?B?TzZubzc4aFBuYVJENTdUV2NCUkVTYUQ5amMwMUJ6SVNaR2twd0dnK1BhQTU1?= =?utf-8?B?SXpqWXE2K25NT1JtaE9vRStzVlVwUkZqRnlYazNUZFpRUmpQU3ZpdlU5eHVs?= =?utf-8?B?ZDBrSVdsUnFxam9jNXNPcDVlUG45aFZ4MVdBc0VpdVBYUGZvZWJKdzNQaE41?= =?utf-8?B?c1NPSnVYVkFXSmcxM2M0TGtHK05pdTQwaDAvekFrdGpVSVljWnp2NUJqNnRG?= =?utf-8?B?YTdJeW8wMjZCdnE2SjFJVm9lenFadS80bDlxQVF4dnNaN3FUSDhvTlZIUEJI?= =?utf-8?B?a1FBeVF3dHhlcVJpVVdQdmlGYzlHU2xoS0NXa3NQdVdldjgvekJKbVhYMHR0?= =?utf-8?B?YVZoc3VtNWt6MjlWcXFMOUR2K0lhWTZJdkJ5MWxyWUNGcGxlblZYODk3SEc3?= =?utf-8?B?cVo4SmY2dkZVOVA4RzJsTXpTbXp3T3M2UUZ3bkk2bHl3c3NJaUd0THowNVZD?= =?utf-8?B?ZUd5NEZLRjg0QWVScy9UZk9reGNvWFZ2R2ZRa2VuTVQyQnlwcFZDUnpmMHJH?= =?utf-8?B?Qk90SzdHRG9MeHZoM2xJOEJlZVJyUHV0dzQwbW8vYmg5eUJFRklBc0JUZHhV?= =?utf-8?B?TzBYQzF5T053Ymkwc2F0UkVzUUswRW0yYitCZEI3Mmg5NEpPdVVmbmxab2FB?= =?utf-8?B?Q2xydStEdkNZblpUVm01U1RPWlpLcGRKUVU1TENKNE5qT0JLMUJrSXd1WDlZ?= =?utf-8?B?c2FhZ1VhbTM1Um44N1NRR29IS21vQkF6WmVoRnBMNTJiN2t4M1ZudVNhYjJN?= =?utf-8?B?L3U0cjF5cGZZK2t4SmpIMlNreVQ4MGVxcVlJQjNEZFZwbkFRSnk1Y1YrM2ho?= =?utf-8?B?SXRzdWVQS3VqUC80MXRMdDlWMzNOK0V5RGQ1cElNdUp4VWY3TjRiQmFGcm9l?= =?utf-8?B?ZGRHU0hNRm91RHpOZ2YrRDZwV2tSanMzYW41M2FrS3BQMGFKZHQyamhxTzc2?= =?utf-8?B?eUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DprOqILDj44bIJpVVGIkETB2pT+3AZp2k1dl7DEXQD4fGeGOG2oOhbVu98PSeDyDT4odAN3mo11XMRzVwbtUESp4zHaMLSMmgcsxokhOCnwlDJ0fKDTAA52mLuIRUkODsUAPtbWNTR/fvaNaV7g3FWzWOeXw19htEk3D/nVKKJeuJofwx8uso2ePz9sOfaUKMHfzoXlRWcsiT/W4lFyhRHHGj8yUGPQUhBV6SK4qWbApaknOWaZhvOlyhkXD7kBqCz+u4+BMnDXinADOzg9UBKK8VELH3hy/uA/OspIDzTELDRFpgBdsC2dJfMaAWuzSNncKG+IVHhR0hmpEbxZpJTsiGFAWlQYdVQyjfPxHpxNBT3dkidmLaJW9z8zoiiWq5HcxNW1/wfdhUasINn+vK8fFfzonCur+dpxQC3rnZnKNNxStpC4dt7HvZX3EKTTOq3rtoE0RZvdOMnDpd7qRg91jmiXVBeh2xmiXhX5HI1V3jMJqT7/LmI7sftDnS1ms18jaWKokRJlcucZY3tBhm6kp0uVAj0MONuAJmbWcnNOEsxy/ahM3T13A0lzJgU6MgRe6hy6E+nFZEmbGIzN3LHDzteO/cY0uT8fmV/h+nSP+qIzsdjuBqnjkTyd9wmnGQnYWbYqwkuD9US5PrJle9rzbFxEdqjekcMKtTzRWTcS+BjxL1pxxzVVemOp3H4rEXLfo56ZdDix4oAreilKbZZNqjLWK1f7E5ymGtx/eHMOyGgsFAfZ6T8Us1fwp6F3uaSSWaXRTO5thRci6NwkzG0sAV0TNKTUtgDZ8R0k4scVI/qFEYwG+SsSRy1k7HFg9r4q5+/pIP5pXZnkiwzKaOw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8fef562-cf68-4399-4421-08db1071e4d3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 23:02:36.2425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w6ikZ7oPVZn4EBpsOWeXOwlpnPRWjyzpMS554GYiGt2Dye4SJKa1Ijp2W9AaVCfBk55mKW6ig0z1cijwuP1K95R4iO9PvdsaAtTQ5jhEbiM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6961 On 16/02/2023 10:44 pm, Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > arch/x86/time.c:1364:20: error: a function declaration without a > prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > s_time_t get_s_time() > ^ > void > > The error message is a bit confusing but appears to new as part of > -Wdeprecated-non-prototype which is part of supporting C2x which formally > removes K&R syntax. > > Either way, fix the offending functions. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > These are all the examples found in a default build of Xen. I'm still finding > toolstack violations. Apparently not.  int cf_check vmx_cpu_up() too. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Feb 16 23:14:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 23:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496808.767705 (Exim 4.92) (envelope-from ) id 1pSnSA-0006EF-IS; Thu, 16 Feb 2023 23:14:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496808.767705; Thu, 16 Feb 2023 23:14:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnSA-0006E8-EF; Thu, 16 Feb 2023 23:14:14 +0000 Received: by outflank-mailman (input) for mailman id 496808; Thu, 16 Feb 2023 23:14:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnS9-0006Dy-4K; Thu, 16 Feb 2023 23:14:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnS9-0001k5-2B; Thu, 16 Feb 2023 23:14:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnS8-0002Eq-M0; Thu, 16 Feb 2023 23:14:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSnS8-00008s-LT; Thu, 16 Feb 2023 23:14:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zYWXm0QX7uhIxXr+ZdElzjClZHI3j8c/GWZbMDLt27I=; b=RpBx8Zr5oHpKsiPlG1pZK0G6bH DGDxho/LmewOi4iWcVbFNBVOknCkhWHvGtocEz7kdfSRT8N6FbYV28LhuIs1I13Iq/FQfez8kqU5D x1rE66k5sNGak4Xc5hm6ucqC3FZATMpv2T2Xo7aNBv0w94LcPb/Aa39YVqn0FfZPjbtQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177537: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=720944ea26014a1830f9b44bda13b79e8e7d753b X-Osstest-Versions-That: xen=2e52dcc853a7183784cd9bdfb1e78ff366035209 From: osstest service owner Date: Thu, 16 Feb 2023 23:14:12 +0000 flight 177537 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177537/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 720944ea26014a1830f9b44bda13b79e8e7d753b baseline version: xen 2e52dcc853a7183784cd9bdfb1e78ff366035209 Last test of basis 177483 2023-02-16 10:00:26 Z 0 days Testing same since 177537 2023-02-16 22:02:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Henry Wang #Arm Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2e52dcc853..720944ea26 720944ea26014a1830f9b44bda13b79e8e7d753b -> smoke From xen-devel-bounces@lists.xenproject.org Thu Feb 16 23:16:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 23:16:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496817.767715 (Exim 4.92) (envelope-from ) id 1pSnUe-0006tj-3V; Thu, 16 Feb 2023 23:16:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496817.767715; Thu, 16 Feb 2023 23:16:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnUe-0006tc-0R; Thu, 16 Feb 2023 23:16:48 +0000 Received: by outflank-mailman (input) for mailman id 496817; Thu, 16 Feb 2023 23:16:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnUc-0006tS-Qd for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 23:16:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa20d0cf-ae4f-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 00:16:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa20d0cf-ae4f-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676589405; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=H3lBBbl40VP9Y4SFvw+2TEMNR/UniBXF4GbXvpS7rGY=; b=D44e4XdA1a5aCqpCCn4lOtTyZ12Xau8wk+jEIhKAD9B1z3zuStgLZumk zwsTqd2XilBN9KUh26djE3UAQswdptRYcsCteHKy9H6Bv2Vxfnju6a6NU IrQWXCiJd1H81GzlW7uym+n7AkpJZYN8Ug4DYyAXxD84uP4Fom3oqxPrB w=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96776548 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6kIueanxRXgzzRGxyLx2zgPo5gy+JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdUT2APPyJYjH1eot2Otu3pk8HsZCGxtU1GwBurXsyFSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QGGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eM8DHMBKRSEu/qd0ey1S+BJxcolL+C+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthfG+ T2Yojipav0cHJ+E4yjcz1CVvKjewzLUcpsoT+ao8OE/1TV/wURMUUZLBDNXu8KRkVWiUthSL 0gV/CsGrqUo8kGvCN7nUHWQglSJoxodUNp4CPAh5UeGza+8ywSEAmkJSBZRZdpgs9U5LRQ10 neZktWvAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nczp4OPfr1JuvQ2i2m m3U6nFk3N3/kPLnyY2k2XSEj3WooaTRZR9r6ATeeyGr6ABQMdvNi5OT1XDX6vNJLYC8R1aHv WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFoSbLQGxG3N1pyK6F2O4gcCShX kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNDKy8gjlmOMIZmOq7EMZGPBf44owVuBJw+ZzTw L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2MG82klUj/geHFNBZ5rIvp13PUM4gEAF6s+l2Jo 76zyePUo/mgbAEOSnaOqtNCRbz7BXM6GYr3u6Rqmh2re2Jb9JUaI6aJm9sJItU195m5Y8+Up hlRrGcEkgug7ZAGQC3WAk1ehETHBsYk/S9hZHxxVbtqslB6CbuSAG4kX8NfVdEaGCZLl5aYk 9Ftlx28P8ly IronPort-HdrOrdr: A9a23:qOcPBqGEe+8DYbaapLqE1ceALOsnbusQ8zAX/mt6Q3VuA6ulfq eV8MjztCWatN91YhodcL+7VpVoLUm8yXcW2/hzAV7SZmnbUQKTRekJgLcKqAeQeREWmNQtsZ tIQuxTD8DxEEg/reuS2njfLz/4+qjjzJyV X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="96776548" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , George Dunlap , "Jan Beulich" , Stefano Stabellini , "Wei Liu" , Julien Grall Subject: [PATCH] tools: Remove the use of K&R functions Date: Thu, 16 Feb 2023 23:16:36 +0000 Message-ID: <20230216231636.714006-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Clang-15 (as seen in the FreeBSD 14 tests) complains: xg_main.c:1248 error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] xg_init() ^ void The error message is a bit confusing but appears to new as part of -Wdeprecated-non-prototype which is part of supporting C2x which formally removes K&R syntax. Either way, fix the offending functions. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- tools/debugger/gdbsx/xg/xg_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c index 4576c762af0c..580fe237b20e 100644 --- a/tools/debugger/gdbsx/xg/xg_main.c +++ b/tools/debugger/gdbsx/xg/xg_main.c @@ -121,7 +121,7 @@ xgprt(const char *fn, const char *fmt, ...) * -1 failure, errno set. */ int -xg_init() +xg_init(void) { int flags, saved_errno; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Feb 16 23:18:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 16 Feb 2023 23:18:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496822.767727 (Exim 4.92) (envelope-from ) id 1pSnVw-0007S8-EQ; Thu, 16 Feb 2023 23:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496822.767727; Thu, 16 Feb 2023 23:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnVw-0007S1-9z; Thu, 16 Feb 2023 23:18:08 +0000 Received: by outflank-mailman (input) for mailman id 496822; Thu, 16 Feb 2023 23:18:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSnVv-0007Rv-Ca for xen-devel@lists.xenproject.org; Thu, 16 Feb 2023 23:18:07 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29690b1a-ae50-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 00:18:05 +0100 (CET) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Feb 2023 18:17:58 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5061.namprd03.prod.outlook.com (2603:10b6:a03:1f1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Thu, 16 Feb 2023 23:17:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Thu, 16 Feb 2023 23:17:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29690b1a-ae50-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676589485; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=oPZ+skCAQtcDLKyYS9kuxx/ORCORHxOUWc/buW43KkQ=; b=Wc7oISHbL4/mHZ4jBrxsx7Qhv+nop15jIVky5lIaTxv7RPrdrV3mUAnd 3rhSMnpCRecBgrp8QvZmF2O1NtjvtGiNVXGMuj+Z5odsv6n9S/tc6Wcxi j3YKaFx7d8F+HlEe9H0gbiBWr9VCtfUFLtf28HuhZH07nJ6WCzQct1ZWB 4=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 96228750 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YLUCQa5cLrKTuUEiA88CpAxRtBrGchMFZxGqfqrLsTDasY5as4F+v jFMUDzUPfyPazf8ct1yPYzg8B4Bv8eAmNJgSVZu+S40Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4geF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz vUEBwBRaTO5uriY3q34dPVQvu8OI5y+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOKF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMTufoqaMy6LGV7jwyGTZVVkOjmPywjF6FcdIEM WsRxgN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcUbzE30 l6Cn/vyGCdi9raSTBq16bO8vT60fy8PIgc/iTQsSAIE55zppt41hxeWFtJ7Svft1JvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5 IronPort-HdrOrdr: A9a23:zeeRCq7S1SMh1VtIQAPXwD7XdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsyMc7Qx6ZJhOo7+90cW7L080sKQFg7X5Xo3SOzUO2lHYT72KhLGKq1Hd8m/Fh4tgPM 9bGJSWY+eAaWSS4/ya3OG5eexQv+Vu8sqT9JnjJ6EGd3AaV0lihT0JejpyCidNNXB77QJSLu vg2iJAzQDQAUg/X4CAKVQuefPMnNHPnIKOW297O/Z2gDP+9g9B8dTBYmKl4is= X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="96228750" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxUHMiE0DjCwFF2401odZKcMSVxnZsIBdN2pDAkaN39ZPd5YJRpi7QFL+7QBclV0Ahes18vZDuGIk4GUot2D5A5x2/k/y9ErjJmKuiNnEdjv8SGtHiM9fE+Nv1ql0E2SrXq/hjRiHtbzvxLsA1t1yGAkvo1R/9lmDNMG9iAV8EJd+7dU/0tlki4MRJkA07p6qV4jeLVIJii9VIKfRrkJl9pkNPUctGnNFsm0y1QouFAICR/rtF1yr/9Y34c8zlG72idibAzEF0R77eIOVIkxHCIOlneKIKhLrqvyDG64fb7k6jeUJGZ30ERGqf61nP9OLZn6woH0CTb2W0hStwXmow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf25VlnnNv1fszSb5sncly0SRB1jltSI/r7xw4S63+A=; b=kjbEuFGsWayn11SXWq6LjNRPFvlcTkKE0gLxAdZwXaGI2hP0sThqzZN1SktcNV8E+J8fg3vZ8sLOl90Rmhlig57rErzq/daNO5PZdO+Jv7nTEcCof8TvrTOcbLpLqx+NWa4eJDl7zTuIFyuRe2j1D1UBuSrejFvt7cRr2yOTJFXzEl8VlDf2buFcC+ea6qqmVibdHWmMWCeOCCXFVP+CIvzckCkOCTmkoxiZquuvEaVUTf02M6aryLh7qpjU4SAN3aXmmjLhxNfeGpX1Y5ceWfOkgRyUf+BZyAiXAxDZGoqWE9wBsqYP9Lm+xeqGfdse/IGBTkcGRK1Frq/fmZKi8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xf25VlnnNv1fszSb5sncly0SRB1jltSI/r7xw4S63+A=; b=rLhEmU4kKcc13xO2VtebiXVItxtPfv4zQNCLhpQgyOP5uVg9e/WX+dxhmERlTmb6QHBP7Wph3/+L3LnoXsULIW/4kFUF/ArpDV9VRYsfz9s6K5dficae4KAU05t+/UTJ83ULMLeohkJrVNS+GuFYm8NZDUdZrTuVMYa5IO6Pk8A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <65cd4fae-f6ad-1a2b-043f-665cb3903576@citrix.com> Date: Thu, 16 Feb 2023 23:17:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen: Remove the use of K&R functions Content-Language: en-GB From: Andrew Cooper To: Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230216224438.705395-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0028.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5061:EE_ X-MS-Office365-Filtering-Correlation-Id: 66300160-2077-47b7-8d68-08db10740942 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mwFUBOsd86wsF3507EmuzPebbrM9T4tfx0v4/3PtA2/dKcxyHQbSwQwLDrc232MtyFb7/WO7FJRd5LnJL6ESCgzQ1M7Yi8I8t7Chw2Ig5GnWmCtdD/aRAaObRhxRPdy2EwXwlu1mHLuSh4GSHr15UhiQlnM9v5FrYfov1hqML7DRALGxEk1+XytP8YZ0iI0QtsmalBOsQihMzOtQA/JQP4whZxy+4dwIrvveLDT8H84hhnG+cP4QRFZowI2YvjaHu/Ah1ZzkvIrqKB3aeiBa0jL4RR0iLy3hEy1azvgOALviLeFzCEhfr8m2WkmKuWdOarU9FSlclqAm8lcsReHjboz3h1TB0/CRbIlpemCxCXD0iOz4+bCjZMZkjUfYLnyU1vxJIO64HCKr1ASszUK/9kJdGIbyv+/OrQTZIpvasoVrdnq7VnlfKu470AsKcao2JY0blFl1t8WBN6I+cMrWGUbqciH6gSMgvXdQn4oSArvzTXctNHMNNHEugiNxub7Xxg/6EVVzIa5Qj51Fmz8PI468gyGaW5UfvWnBma74bUFt51rlLEU0tScHhkUNPoZSyW3uJkCUQR8/8y5hK7uRUBODJSTau6de5n6rCkh9ps2ZMZQedhpOEx1kdBjQqIKuDT/RJLLxYwpoh4xAoJf05bNRSFZ42eTm+QCSFUUQ7WiJNzihAHkjR4d5RZ9DumI54Wkxq62aDG+ed5gUWwBPL4lyM83aVitieoQCInyHp7w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(451199018)(31696002)(54906003)(86362001)(8936002)(5660300002)(316002)(41300700001)(66946007)(66556008)(4326008)(36756003)(6916009)(8676002)(66476007)(478600001)(26005)(53546011)(6506007)(2906002)(2616005)(186003)(6486002)(6666004)(82960400001)(83380400001)(6512007)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG43QWZFWXRpelIyb2hSQVFKb2dOMHJTMXYvaVJ2cko1UHRzWUxEK2JRTk1n?= =?utf-8?B?bDBiSGkzUm9HUFNYUWNNOS95R250TVVFREhHZ1pORFVZOEpNVVNESTZVaFAr?= =?utf-8?B?ZWUycEtaTDBvV2p0bGx5ZndveEJCL2lUbzJjV3FSdmRXL0JtR3BIRWdiVm1D?= =?utf-8?B?VUZHb1l2Yzd1VmhXbVZkTUhqUm4wdTZhdTdITnQ2WTZPTUNvVExJcGkrQTQv?= =?utf-8?B?cHZ5d2hUTGZjaFNKdzM3KzIxWnlsRUFjN0pWUWdqZ2w5c2FnRGl3bWFMVE8r?= =?utf-8?B?cDdrZzdadVFWMUtUN2NCT2pPbXNEOGhSMTlLeWJRaXhZZEpUV0pLSjVGUW8y?= =?utf-8?B?UW9DNWFSd0RBQ3ZvZkdudzcydWlHVjJtbE1sSHNzcWJ5TnFsRy9vaHBiVDg4?= =?utf-8?B?eDZ2eWRhU1Nhb0crVkEvMU0wQ3NlakRjSEVYSmVaQmtVMWZYZFdZZGhCNGZW?= =?utf-8?B?RXVyaE1LNHZUSUM3VFFySWFRSEwzei9HTnJiSkF3SFJUbjE3UVFBK09lUEhz?= =?utf-8?B?L01Dc1lKcTJJV1Z0TkdHYUZXdnJzMW5jMFNWd3F2cWJmZWVmOEZRcDU1R01Y?= =?utf-8?B?SUpKOEg3MHNjVnRaUEplbzBwUjV6c3B6UloyUDFWbE8vQUptL1hwS1JWRXUv?= =?utf-8?B?VWlMR2NSOG12aXgrNi9JaUc3eTI1T01rK3BrcXVydktRdm5CY0hBbzJCUDR6?= =?utf-8?B?c3g5VytLaXlvS2pGa2cxM1crRUFienBCbHZiQjdHUlhDQjJlQkpBWUQvbG5P?= =?utf-8?B?SWpIZWxTSCs5dmY5N1RORVYxNzVkamoxR0VGbjQ3ZmtxSXVNM1lHQWxMUE4x?= =?utf-8?B?SW1seHR6N01IV3dhcUdteWxKRHZxQzVWZWJ2SFVEdzE2L1pQYjE5NnJBTHFx?= =?utf-8?B?NmFVT0tvOTZCaDJUZWkwa3FKbnBFbU5nQjhwNklVcWJaeXZObis3bHo3cGJx?= =?utf-8?B?NUxwL0Z5bDgvQW84eXBDMDBveTczYk5RK3IyczdEeGhldlNEN2toOXBvMWND?= =?utf-8?B?dHc3SlVUUVRkRXlwSVlBRUpUbHpveE1DQi9tVWtuMWNVQTN2Z3c2eDNNWEdQ?= =?utf-8?B?YVM3bWZYY051VXJMZkpjYndsQUd0c2MzR09qN1hJSiswcFJEb3NJQm5YTWtV?= =?utf-8?B?Z3dNRGFHYlVMWXNmNzhtZkNMdkFMdW9lUUtsS0hzaFZJWHF4c0E3T2RIMjc3?= =?utf-8?B?aWExNVlTL2ZZVUk1b2w2UUlLcWVQbkd3cmdXUlJMWUU3QXZuYWZNbFpFT0sx?= =?utf-8?B?QkJYaURVOEVDN25FRXF3YkZ4ekpKTThhK0ZHRnRwQTN3RXZ2RERxNUw1MWli?= =?utf-8?B?ZHpmSXM5amFWSVNML0hSOGQ0cVduNlk3U3FEUnFRTGcyK2hQZ01ZSWdhZnF2?= =?utf-8?B?N29xQ0xGak9rK2NESXNXV2RHRWttd0NXT1N6NDliOFltSk9QRFdheVRlTk15?= =?utf-8?B?V280Q0w1N09ROHh2ckFvN3RQWDNoR1lxL3U3QWtmVFVROHFpY2hpTmNKbkVm?= =?utf-8?B?ZENHTk5FVXlSZ3hYS3RGNTEwYmg4MGIza1BlWFFpN3kwNUJBWWRNT3VBTUtV?= =?utf-8?B?WkhIK1FvOFUyRUNrOGczQndNaitrS0c5Mk1mU0g2MFQwTTYrREt2bVYxVEFo?= =?utf-8?B?cTY1aDU0UFhXSVYwc0Q4WVVYSCsvVnBkYW1PM2szUUhVS0Fsd0I3QXNVcXZ0?= =?utf-8?B?ZEdrQS92YlBTd0RZQytvL0lrd1UvVS85OEs1U2F1d1lMTXU3TXQ3aDBaTmUr?= =?utf-8?B?SHJmODY3SnlQV053YWEyZlBkS0h1V0pnQStRQXBydGVNM2xRck5zeEtJTUZ5?= =?utf-8?B?UVNsSE9qWGp2SUxmMGtNdEZtOXV2a0cwRXFRVG5QeGFPTTVwMi9lTm50aFdS?= =?utf-8?B?dE9hWldCclJDSkN0bllQK2R1TFYyQXVpVkxkTjU5eHNWQTkyS1YvU01pS2M1?= =?utf-8?B?aytNL0QvS0JJL0YrbFZScEJLOGZCZEFKWTZnRklnWjN6YWhPUjZXV29hVkZn?= =?utf-8?B?cGIyT3FwL01RYWtMY3dxUk9rTnRwUFBrVi9jeS9HZEpUczBTZWk5aDBwQkxr?= =?utf-8?B?LzlmYThxUzNCNHNPRGZhK3JNbHFsV3ZMQVBNZ01Xd3pYNVU1b1dLWlNvWUhv?= =?utf-8?B?ZWt2TG1GZnR1elRWMjVtNlZ3amFqSXBMOEx6SWYrc0hPZ1NQVnRhNXhIL0JT?= =?utf-8?B?cEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7nqFkCkloRCDXKP7BbNJkMRng6U+zO0Gvdfe7G9ALbHQmZIpQ9zjRYeSrOROIT0yd68hw/uz/AgX9FZG+Pu/6umBeo8GP9/RHptRoKlddMB3Sf5nL1CzIVQw/TGj1qWfgiKm17xDb/ScxoO2pf+k0hcdsmy3vXgG+Ffxk0SPeL0jRlWrGhiCkk4zTXNnb+VcXm2PD9F5rQwcWnSBtDLNzYj49GC8Go1paECUqc9fd/7a52XyD5rHX1b+2UHUHy3L5qXrUy0dFyKUu2bZ1CJ1RWwHYBMgxRA4nsEZ3XT9rbCPWb+6Y1+Nt6fiPBC8GaihSy6PnKjsqfSU0bzxuLzBQ5JgVFuUF152RFfqfsNdqOwUNGdf0xU+1Igo6mZoSpUfWEJUnK+1EM52xBZeTW/JmWc9FZ6QhdJFCFO01RgM89ckbJ4Htvc2Y4gcVSZvSh0rhMTXlboM7+uVC5FBCerpmZKa+ZS00oqJXqYNo3TgZvJJkDl5NdxkvMmpn6rnYTkiX+IhMZ10zk1K0Ferb08ZCNvXDao3oXzx7v4MvRk4uCkC5iCy4iwYg12/vWLMIjbCevOFY3yTK6oDDvfzZg/iqTEd0NB2xfjlObsUIzGrxPzA91VInRkOdsor6/m1kw12Vsl6v5kZY5L6I3MrWlKHThjD3E1LuWfmQ9pwle5omgTx2UwSNZJeykIVLDbLbwXnCMx4ue9eHPbGMTwPOsjMynPdgE6lalCK7nGFOKair/cuSkhCjpDA8uJOWqudUnFE6oEUO2ygn4hkCyZ2bzGY2GY049iQguPjTi7qVTBm+LoOSScpYhiIRN0ThCnw9lL5vnPP+4pxK4mwDsEA3sVUhg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66300160-2077-47b7-8d68-08db10740942 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 23:17:56.3008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: giHAq7XxV1ewKjFPyxpu/Ww2qFtlBdW29npDULPyP4ZzauXysojUFiwXLy2Vg3lm/kyARo8wlHQqNC6RpGKTka7jRyrjrD1jMRRxYhjfL60= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5061 On 16/02/2023 11:02 pm, Andrew Cooper wrote: > On 16/02/2023 10:44 pm, Andrew Cooper wrote: >> Clang-15 (as seen in the FreeBSD 14 tests) complains: >> >> arch/x86/time.c:1364:20: error: a function declaration without a >> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] >> s_time_t get_s_time() >> ^ >> void >> >> The error message is a bit confusing but appears to new as part of >> -Wdeprecated-non-prototype which is part of supporting C2x which formally >> removes K&R syntax. >> >> Either way, fix the offending functions. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> >> These are all the examples found in a default build of Xen. I'm still finding >> toolstack violations. > Apparently not.  int cf_check vmx_cpu_up() too. Ok, finally got a clean Clang-15 build.  I've folded this hunk into the patch: diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 09edbd23b399..e1c268789e7e 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -781,7 +781,7 @@ static int _vmx_cpu_up(bool bsp)      return 0;  }   -int cf_check vmx_cpu_up() +int cf_check vmx_cpu_up(void)  {      return _vmx_cpu_up(false);  } but am not intending to send a v2 given how trivial it is. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 17 00:20:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 00:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496828.767738 (Exim 4.92) (envelope-from ) id 1pSoTR-0008DD-4I; Fri, 17 Feb 2023 00:19:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496828.767738; Fri, 17 Feb 2023 00:19:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSoTR-0008D6-1l; Fri, 17 Feb 2023 00:19:37 +0000 Received: by outflank-mailman (input) for mailman id 496828; Fri, 17 Feb 2023 00:19:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSoTP-0008Af-Dx for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 00:19:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf611a63-ae58-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 01:19:33 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf611a63-ae58-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676593173; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=c1MpPmImsROOv47GTA2v+z6JFWIRXg8PJdk+O+CI6mo=; b=hO/gH5Fp+hkeOLWmj93slUE4GwHlVEzsH0SE0CcPTcrwB72kx7PScMeC cqwUTtwKbDT4NPS6fHVnyS6XwysZFYXHCIZrW4Pv46SZtCc2+si7JSd1h C3fTD+ReWr8yF3y0o30xSvNFa3Fk/DM8GGzBGD169VHa48cwWTy9OJ2EL c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97307914 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:Xc43UKqzZS3SLF/eYWbwpdE6a25eBmIOZRIvgKrLsJaIsI4StFCzt garIBmDOv3fZTP8LtkjO9+19x8B6JSEzNJiGldlqXxhRiwX9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzidNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAA9TQRWku7Pu+oCYQ/VmgOlgJ+r7AbpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jOZpDymU0hGXDCZ4TC9yyLvh87Tpw7YRNoTJuOJp6VRumTGkwT/DzVJDADm8JFVkHWWRNZ3O 0ESvC00osAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTRbzNzEnNBrtCDsR8ppFoP2hf7lJAill lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3Hb5 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AhkkeC+F0e5eI1cFh XM/XisIvfdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxHOgj+3zBB8yvpvU Xt+TSpLJSxHYZmLMRLsH7tNuVPV7n5WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vdyDg5B +13bpPQoz0GCb2WX8Ui2dJLRbz8BSRhVM+eRg0+XrLrHzeK70l6W6SBnOl4K9ENcmY8vr6gw 0xRk3RwkDLX7UAr4y3TMBiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:pHxEva413kcCFQcwvwPXwMbXdLJyesId70hD6qhwISY1TiX+rb HJoB17726StN9/YgBCpTntAsa9qBDnhPpICOsqTNWftWDd0QPCRuwP0WKL+UyYJ8SUzI5gPM lbHZSWcOeAaGRHsQ== X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="97307914" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH RFC] xen: Work around Clang-IAS macro expansion bug. Date: Fri, 17 Feb 2023 00:19:14 +0000 Message-ID: <20230217001914.762929-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit https://github.com/llvm/llvm-project/issues/60792 RFC. I very much dislike this patch, but it does work for me. Why the parameter name of foo? Turns out I found a different Clang-IAS bug/misfeature when trying to name the parameter uniq. In file included from arch/x86/asm-macros.c:3: ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] .L\@\uniq\()fill_rsb_loop: ^ It appears you can't have any macro parameters beginning with a u. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/spec_ctrl.h | 4 ++-- xen/arch/x86/include/asm/spec_ctrl_asm.h | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index 3cf8a7d304d4..cd727be7c689 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); /* (ab)use alternative_input() to specify clobbers. */ - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, + alternative_input("", "DO_OVERWRITE_RSB foo=%=", X86_BUG_IBPB_NO_RET, : "rax", "rcx"); } @@ -172,7 +172,7 @@ static always_inline void spec_ctrl_enter_idle(struct cpu_info *info) * * (ab)use alternative_input() to specify clobbers. */ - alternative_input("", "DO_OVERWRITE_RSB", X86_FEATURE_SC_RSB_IDLE, + alternative_input("", "DO_OVERWRITE_RSB foo=%=", X86_FEATURE_SC_RSB_IDLE, : "rax", "rcx"); } diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532b..06455c5663bb 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -117,7 +117,7 @@ .L\@_done: .endm -.macro DO_OVERWRITE_RSB tmp=rax +.macro DO_OVERWRITE_RSB tmp=rax foo= /* * Requires nothing * Clobbers \tmp (%rax by default), %rcx @@ -136,27 +136,27 @@ mov $16, %ecx /* 16 iterations, two calls per loop */ mov %rsp, %\tmp /* Store the current %rsp */ -.L\@_fill_rsb_loop: +.L\@\foo\()fill_rsb_loop: .irp n, 1, 2 /* Unrolled twice. */ - call .L\@_insert_rsb_entry_\n /* Create an RSB entry. */ + call .L\@\foo\()insert_rsb_entry_\n /* Create an RSB entry. */ int3 /* Halt rogue speculation. */ -.L\@_insert_rsb_entry_\n: +.L\@\foo\()insert_rsb_entry_\n: .endr sub $1, %ecx - jnz .L\@_fill_rsb_loop + jnz .L\@\foo\()fill_rsb_loop mov %\tmp, %rsp /* Restore old %rsp */ #ifdef CONFIG_XEN_SHSTK mov $1, %ecx rdsspd %ecx cmp $1, %ecx - je .L\@_shstk_done + je .L\@\foo\()shstk_done mov $64, %ecx /* 64 * 4 bytes, given incsspd */ incsspd %ecx /* Restore old SSP */ -.L\@_shstk_done: +.L\@\foo\()shstk_done: #endif .endm -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 01:21:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 01:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496833.767749 (Exim 4.92) (envelope-from ) id 1pSpQn-0007GE-MB; Fri, 17 Feb 2023 01:20:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496833.767749; Fri, 17 Feb 2023 01:20:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpQn-0007G7-JI; Fri, 17 Feb 2023 01:20:57 +0000 Received: by outflank-mailman (input) for mailman id 496833; Fri, 17 Feb 2023 01:20:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpQl-0007G1-TS for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 01:20:56 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50605a11-ae61-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 02:20:51 +0100 (CET) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31GHnX1g007014; Fri, 17 Feb 2023 01:20:35 GMT Received: from eur02-vi1-obe.outbound.protection.outlook.com (mail-vi1eur02lp2042.outbound.protection.outlook.com [104.47.11.42]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3nss7rhwq5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 01:20:34 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by DB4PR03MB9385.eurprd03.prod.outlook.com (2603:10a6:10:3fb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 01:20:31 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6086.026; Fri, 17 Feb 2023 01:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50605a11-ae61-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ROjgkqMMmuin4U/ptMVaxKP2RzZ/RAjPrFYHnc2pacIgf2CgDmyg7AkYKbxS3YBjBLxuDxO6O0COSS8km4xkmKPpGBCSFobcGBQK9e8lesU53ORfLJ+/zHZTH+jWU20DeR+gEXPAyndl9CVEiaGr513DRroOCF2q34LqVotTTsqenZl95pKlLu8wHPhhUJ6xvA4GStqKHWFauvGPOJxwI9c6uda4SwAVkR8nxaLknPS2k6kQaarR7X92Lw7JwEH4Ii/Zb4CjFXNUxyOFUjEat0CowubZLo4ETEfAzD7p7QlRnWEONJlo/z6PeGImBhMgnYWge2wnEn4xb2dNuz+fbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3fNDbS5wRCEYx1LoxfhMr/zCSSmLAzvIcCA6XdVAClM=; b=Bmo9T5NuvtQ5x1xcuYWHugkoxaFNhl1BSq+hM2ziJdZ8nP/kgzPouEkW9DuPQl3aV0DnljjFdNc0NF1reSf9/TWSsin4mlxF1qy9W/TkCsFPt0ZVBhSwFhGjnAyyHLBlDfgiWR1QpEyST1oweZqFWPTtpEXx4Y0ho9KextV3XowRVx2heq68Yo9kDM7jHvX6P1ktf27hQm9zkvSPgnuRYgttjYFcyuYcKkupCZHOmJ86v+5m8FHu2zn7s2CcGpK1z8bbfw+wnAaBa+hRQpdBkJeqAOyWi7vi41ZC6omSJfSMz7yo5tkne7oiI2oeGL+YxhG25xoa4CIRv126Jnzj8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3fNDbS5wRCEYx1LoxfhMr/zCSSmLAzvIcCA6XdVAClM=; b=L7aOeKm1VewhVjGp38OQovltpUqvxDlYPBT+SzQ/JJxZJXGe+xsEaf9a/LIKJuXq8CEJlYlm9OWYnqYyX3PO1UxtpBc/Pwu1+K5Qgp//FbDforMFE2S4gdgyo2REL6uIa1Nfhju/YeuE4YDvL6yBzTNko8j72P8x3FUGHKDxZdtMGKnvQ+TqkmlPPZhFZZqABJuoPHdZHasDRve9U6rDFghVfqIyavYUqk2lm+KpowyD6a9rQzx8yswKSOCqZ/vYE/yRtAdroHH3Ahv1/F+671w9DKcScXKePP1przUhBZeLN1k7x4OEZScX3R64nn7uI4Dmhj5DtXTP+kJ36l1JzA== From: Volodymyr Babchuk To: Jan Beulich CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , Paul Durrant , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Kevin Tian Subject: Re: [RFC PATCH 03/10] xen: pci: introduce ats_list_lock Thread-Topic: [RFC PATCH 03/10] xen: pci: introduce ats_list_lock Thread-Index: AQHYvUN+A/bxwqt+90CvUR3e9vnmcK6ySQOAgACK4gCAIIy7AA== Date: Fri, 17 Feb 2023 01:20:30 +0000 Message-ID: <875yc12ile.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-4-volodymyr_babchuk@epam.com> <97112cd2-d16e-6c9d-7c3d-a3fe5ab76125@suse.com> In-Reply-To: <97112cd2-d16e-6c9d-7c3d-a3fe5ab76125@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|DB4PR03MB9385:EE_ x-ms-office365-filtering-correlation-id: 94b137c0-9ab7-43a9-ec90-08db1085290f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 79nyELwLJ2uKX5NHHzI4X6R28cYLoGAOtdEM4lDDgscdpz0UtGq6in/Q6UHYpB8mWRK253lU++dopbn/BvYljRon6S2MhmxcEXJS4RyfGgQccOIb+NmwcOnNgZWpXRXB55ANU0uP/UYcT69gJsYa/SoMpmLPlALK4GxjTQDZoPN2vXeSZ99R215ciAc3nGnXGCjAK4XPoOwBGT5lm4CxkbSiJrDpmn8nm/1tBHQ5CD3Y5+kD1XQsYPfKwxKY4uj0ISKrS2BLWvp3ljG8fGpScQgQ76XXqFSqI2sTu9S+aDfSZlCFQaxPXX/ACMVZ7teYt2sgx77rRMo+QcYmKAl8VDCOPGOrgsdxZck85URpSzFD1er0jJzGwlfevAmQ/I3NTLXUN0Ox1jCfM9I3ItqKoPJg3SOhSXGEojJHl/5vuQ6eymDCcyQc6oHruavRlZ8jH+ykB69+uF4PAGdQUVNxeS8E+zOH7WGmg6wN/szRQlGDNEDKIuIZ73Qz3OFnscHE3XXCnJ76EYC/SI+BiLBD9j4baidwJPj3IswZrkK/oAVjARgA5P3C0He83myfN8mq2K56/bO+Tbf0jGAc0LO3vMVwbDc+AMrrG/1Y7ZB78YMHMdFwRYnJNv9iVxiaiBBVKozXVjRPAAuRvdab8tglnFc7fcTzzo4PuM4uLaFrjo1BTnlCztL+yzFG78ProksFHoH5iz3BSZIUP7lfcm1Aqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199018)(71200400001)(36756003)(41300700001)(6512007)(6486002)(64756008)(66446008)(6916009)(8676002)(4326008)(66476007)(38100700002)(66556008)(76116006)(5660300002)(2906002)(66946007)(122000001)(186003)(2616005)(6506007)(55236004)(26005)(53546011)(478600001)(8936002)(91956017)(83380400001)(38070700005)(316002)(86362001)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dUw2Cv04+uaRdaVP7NLn6ymi4j07Kjgj3Vd00RFtk0x9s2Sf0lCWmIcq4t?= =?iso-8859-1?Q?y8bDIhK17bSnBTA/9FxC47YwlPt3SJGgm6ZkBZMy0yQoCoKIDVjj1TNvw8?= =?iso-8859-1?Q?MM+SihPx/6jruYbX7+R+8Z6od3z8dIlVgXmXI9EzE0/dHUwtyvu/jvRR9g?= =?iso-8859-1?Q?//rn0+yuE0QjSzsjE5MW2GGx9ESBWonkjFZfEtwqM4r1HgoUErd76JYnyw?= =?iso-8859-1?Q?IL/A1Fuw6qiLZx545HxGIUjhPyaeUbcmvRJaFs/EEGvqD2y8tEZ+twi9fb?= =?iso-8859-1?Q?ojvUdNUfL6lvMcn5MrQecKCEiMnfGUeGhtwK/7YCjpWOaXvsvLC8kXrlqe?= =?iso-8859-1?Q?Ob4nn9R+M8DJJ5zfNzABZCeb6iJcrO6wejV/Ks+MVlA/Ms6u/2q2Zvrhmc?= =?iso-8859-1?Q?tm5IpXjeYGR6zM9YzllXJh6zh87yt68dZkMLGPMA3S8CHGFa2gmsNpSY6Z?= =?iso-8859-1?Q?/VGihS8SWoDj6WQ3UyIwRtjC4sQU/szB6MBjyDckeRlYkJ8sgjdzIzL/O0?= =?iso-8859-1?Q?cC6e++foDOpy5XmrVRq4ArP8jDs2GYi9cYGpyum/8tdqtbFAypXKgEV5aQ?= =?iso-8859-1?Q?FSvH2lFfVS//Ht6ewsbCdhYvs2+qZrneLbI5d6y1xKf9XdOnwFZuFGIQfA?= =?iso-8859-1?Q?u3r9zvZXkXyEIx/N2xCfq7MutqqZsvp0sAYKZfeneUxst1Ooqk3FM7ttTK?= =?iso-8859-1?Q?hF8BporQo9QdfWePuf1fDt6V9XgqbcdbXP0xYPYIOK3v4Prce4ef6P5+8q?= =?iso-8859-1?Q?c7+6iLpx/4yBZrFMm4Wuq+NvywhPzhX/kHjwnJIIID8iefp9+6qmJQiWx+?= =?iso-8859-1?Q?nryW9O3oH4L3ullr0lYlArd0AfD881D5aG7+bfgsdHG3lDAb+/k3Q6qS/O?= =?iso-8859-1?Q?9FbcktxfPR/x52g66E7rQ1YGd4D5Y9U+qmriPSZ+3wNNNpbcGbhCH7BEZV?= =?iso-8859-1?Q?4NsGJ2UgwIhACvi9igd3gkCBhmNdRufxNwjh0RDFeZ+Z5+pAt/dWo7dTIO?= =?iso-8859-1?Q?bQNX6NWhYSbiAXkTkHF3sJNUprsaNAkokqdnVLp8DiYBngi7u+/620tTug?= =?iso-8859-1?Q?s+khAH+Hed7AJ9XQDxxzdF5Bht+R9JZPqZEbEPt5O0gcTmrwyrELlAgoqi?= =?iso-8859-1?Q?Txqsb/RA9T/DaBzwrt8zuBsIJGvT1iXcod9n6paoBlQRgcz3tPlfqgncOs?= =?iso-8859-1?Q?klxTtTP+LZsP4+JNGSIuCWflZ1Ujfzd+yvLOCnC5G9QOc8wAFVanVBUkCB?= =?iso-8859-1?Q?jaoqakyUELAY3oUKIFqNxyoDEJYp6QqgsOAcS6Lq0qA1pisAAdQG5q8Aeb?= =?iso-8859-1?Q?1asyzp/HyjMebh45lfHsxeZLuCFQ+ZvMk9RxCSlqBouiFovkiJ4JazjzoT?= =?iso-8859-1?Q?lH1qT5JOH3rnLHqPWeMOIthIu7tW3PQpdlO7eojfQ6ME/3kYjdMdVrxGqP?= =?iso-8859-1?Q?M/WZosLKOfpFQCxBje2UGwLv8CapmCJW+0pR9o+Wa1gJRB0nrOuLuLqpFE?= =?iso-8859-1?Q?arYXKMOSBqMmsBQ9kdQpd2Yd/jlvjpS2Mre7WudvNh5hJA4mUJNvbwIBII?= =?iso-8859-1?Q?nPPTkavNh+WnjD7Eed6KrLryHfIgAxBoH/eQelL02NFBYHSleN7ihkfr0r?= =?iso-8859-1?Q?PVl3GE+w1X52/M3XMVxl6DMH0G3LxcwcWOa8eaAGnmc9zpS9cUbE2QjA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94b137c0-9ab7-43a9-ec90-08db1085290f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 01:20:30.8505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g7yPZ2S9nhn5klxY7oEpGwe178OlKdAv9ONLtZndMByR7K83igqqn8a+2UubbFiD2bHglgpNid49Xv5Vk1rMPmcLeUswVnC1ZSOx5dAEm/M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR03MB9385 X-Proofpoint-GUID: 92E7aAKq8DAW04lZ_IjYa5hWLerFnOnY X-Proofpoint-ORIG-GUID: 92E7aAKq8DAW04lZ_IjYa5hWLerFnOnY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-16_18,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=740 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170009 Hello Jan, Jan Beulich writes: > On 27.01.2023 00:56, Stefano Stabellini wrote: >> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -1641,6 +1641,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain = *d, struct pci_dev *pdev) >>> { >>> pcidevs_lock(); >>> =20 >>> + /* iommu->ats_list_lock is taken by the caller of this function */ >>=20 >> This is a locking inversion. In all other places we take pcidevs_lock >> first, then ats_list_lock lock. For instance look at >> xen/drivers/passthrough/pci.c:deassign_device that is called with >> pcidevs_locked and then calls iommu_call(... reassign_device ...) which >> ends up taking ats_list_lock. >>=20 >> This is the only exception. I think we need to move the >> spin_lock(ats_list_lock) from qinval.c to here. > > First question here is what the lock is meant to protect: Just the list, > or also the ATS state change (i.e. serializing enable and disable against > one another). In the latter case the lock also wants naming differently. My intention was to protect list only. But I believe you are right and we should protect the whole state. I'll rename the lock to ats_lock. > Second question is who is to acquire the lock. Why isn't this done _in_ > {en,dis}able_ats_device() themselves? That would then allow to further > reduce the locked range, because at least the pci_find_ext_capability() > call and the final logging can occur without the lock held. You are right, I'll extended {en,dis}able_ats_device() API to pass pointer to the lock. From xen-devel-bounces@lists.xenproject.org Fri Feb 17 01:36:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 01:36:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496840.767760 (Exim 4.92) (envelope-from ) id 1pSpfx-0000s8-7C; Fri, 17 Feb 2023 01:36:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496840.767760; Fri, 17 Feb 2023 01:36:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpfx-0000s0-2H; Fri, 17 Feb 2023 01:36:37 +0000 Received: by outflank-mailman (input) for mailman id 496840; Fri, 17 Feb 2023 01:36:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpfv-0000rq-Es; Fri, 17 Feb 2023 01:36:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpfv-0003iC-Bo; Fri, 17 Feb 2023 01:36:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpfv-0001Q1-3q; Fri, 17 Feb 2023 01:36:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSpfv-0004l8-3N; Fri, 17 Feb 2023 01:36:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=amZiLPRYVsS60MVv9TU76pVqwiRCSwRNxLzauxFt7uk=; b=kyG2XGec6OSgshmnWltLuoShAb 7rFbEWnBK5yhGmzOSEN/n8hXlDGcxYHwCM2RVm76suhD0Jq76C656XA9nFMeQXcJAm9UVRImHS80i bWsO4IaY36V1Y7PFwVlN1fZwr1Kxxv1u8G+uNN+cfYf8LdEuTlBCdgFnkwOXB6ApR8Ok=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177547: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f5c1a6374aae8be471b895a43359dcff355577f5 X-Osstest-Versions-That: xen=720944ea26014a1830f9b44bda13b79e8e7d753b From: osstest service owner Date: Fri, 17 Feb 2023 01:36:35 +0000 flight 177547 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177547/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f5c1a6374aae8be471b895a43359dcff355577f5 baseline version: xen 720944ea26014a1830f9b44bda13b79e8e7d753b Last test of basis 177537 2023-02-16 22:02:03 Z 0 days Testing same since 177547 2023-02-17 00:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 720944ea26..f5c1a6374a f5c1a6374aae8be471b895a43359dcff355577f5 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 17 01:44:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 01:44:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496847.767770 (Exim 4.92) (envelope-from ) id 1pSpnl-0002g9-0Y; Fri, 17 Feb 2023 01:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496847.767770; Fri, 17 Feb 2023 01:44:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpnk-0002g2-Sx; Fri, 17 Feb 2023 01:44:40 +0000 Received: by outflank-mailman (input) for mailman id 496847; Fri, 17 Feb 2023 01:44:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpnj-0002fw-Gi for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 01:44:39 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1d60f24-ae64-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 02:44:36 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFC356121C; Fri, 17 Feb 2023 01:44:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2172C433EF; Fri, 17 Feb 2023 01:44:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1d60f24-ae64-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676598274; bh=jNbP4ze/LrQTflJf7iMEzaIWcLa/1ZQtcOw4CSYj9QA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=nshHbjX3+ONWZGuksRQBb2dCcvjcs5BSupNL1P8A363T4qvs9znyVNuz2Ut/k0N4K UcBoAvP/xhos1YPhz1TlhnWIInDVQjFe4HcNuwbwcR6Tw3XYYIPwhqvttgQlekI9Tg /1Gz4veh+HakLEgbi+NGwUjstBa9Bal5sHr8j4+OFa0g5U7sMVEqtJO+d38uPEpIUR 4W+/t01spb9oAofu4duFVJt7AT2gXXbX6YITL8jKy4cH1pAbVAEOb0iF9wHL6lOUET KGIzHKkngzgVvcC3y+WUpEo5jVOCA5T9d+zCRCZTtIYmWxRphtBYqQe2Kf/4S6Wa8s syQXoOaZQbpiQ== Date: Thu, 16 Feb 2023 17:44:31 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Jan Beulich , Stefano Stabellini , Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json In-Reply-To: <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> Message-ID: References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1773774438-1676597724=:2127160" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1773774438-1676597724=:2127160 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 16 Feb 2023, Luca Fancellu wrote: > > On 16 Feb 2023, at 08:19, Jan Beulich wrote: > > On 16.02.2023 00:49, Stefano Stabellini wrote: > >> On Wed, 15 Feb 2023, Julien Grall wrote: > >>> On 14/02/2023 22:25, Stefano Stabellini wrote: > >>>>> Patch 1's example has a "comment" field, which no entry makes use of. > >>>>> Without that, how does it become clear _why_ a particular file is to > >>>>> be excluded? The patch description here also doesn't provide any > >>>>> justification ... > >>>> > >>>> It would be good to have a couple of pre-canned justifications as the > >>>> reason for excluding one file could be different from the reason for > >>>> excluding another file. Some of the reasons: > >>> > >>> I think the reasons should be ambiguous. This is ... > >>> > >>>> - imported from Linux > >>> > >>> ... the case here but... > >>> > >>> This reason is pretty clear to me but... > >>> > >>>> - too many false positives > >>> > >>> ... not here. What is too many? > >>> > >>>> That said, we don't necessarily need to know the exact reason for > >>>> excluding one file to be able to start scanning xen with cppcheck > >>>> automatically. If someone wants to remove a file from the exclude list > >>>> in the future they just need to show that cppcheck does a good job at > >>>> scanning the file and we can handle the number of violations. > >>> > >>> I disagree. A good reasoning from the start will be helpful to decide when we > >>> can remove a file from the list. Furthermore, we need to set good example for > >>> any new file we want to exclude. > >>> > >>> Furthermore, if we exclude some files, then it will be difficult for the > >>> reviewers to know when they can be removed from the list. What if this is fine > >>> with CPPCheck but not EClair (or any other)? > >> > >> Yes, the reason would help. In previous incarnations of this work, there > >> was a request for detailed information on external files, such as: > >> - where this file is coming from > >> - if coming from Linux, which version of Linux > >> - maintenance status > >> - coding style > >> > >> But this is not what you are asking. You are only asking for a reason > >> and "imported from Linux" would be good enough. Please correct me if I > >> am wrong. > > > > I guess you mean s/would/could/. Personally I find "imported from Linux" > > as an entirely unacceptable justification: Why would the origin of a file > > matter on whether it has violations? Dealing with the violations may be > > more cumbersome (because preferably the adjustments would go to the > > original files first). Yet not dealing with them - especially if there > > are many - reduces the benefit of the work we do quite a bit, because it > > may leave much more work for downstreams to do to actually be able to do > > any certification. That may go to the extent of questioning why we would > > bother dealing with a few dozen violations if hundreds remain but are > > hidden. Yes, we need to figure out a way to deal with these files. However, at the moment they are getting in the way of easier low hanging fruits. One "easy" low hanging fruit is to use cppcheck to scan new patches for new MISRA violations. That would give immediate benefits to the community. It is not easy to "diff" results with cppcheck and in any case it would help a lot if we had a cleaner baseline because it would make it far easier to read the results and make sense of them. The goal of this exclusion list is to give us that: a cleaner baseline so that we can make progress faster on low hanging fruits. This list is not meant to be fixed and stay unchanged for a long time. In fact, it could even live under automation/ as part of the gitlab-ci test that triggers cppcheck, if we prefer. > Hi Jan, > > my personal opinion is that we can’t handle them for files that needs to be kept > in sync from an external source, because we can’t justify findings or tag false > positives, if we are lucky we might fix the non compliances but even in that case > there might be times when the fix goes through and cases where the fix is objected > by the maintainers just because their project is not following the MISRA standard. > > On our side, what we can do is track these files and from time to time check that > they are still eligible to backport, because when they are not anymore we could > just port them to Xen coding style and start doing direct changes. > > > @Stefano/@Bertrand/@Julien thanks for your effort on the list, yesterday morning > I’ve also had a look on the Michal’s file list and I’ve tracked down the origin, here > my findings, maybe we could merge your list with mine? Yes to merge the two lists, but I think we should keep only items that we actually need for the sake of having a cleaner baseline. So I would only add things we need today to reduce the noise on cppcheck results (excluding 20.7 and also excluding unusedStructMember which I think we should probably stop scanning with cppcheck altogether). --8323329-1773774438-1676597724=:2127160-- From xen-devel-bounces@lists.xenproject.org Fri Feb 17 01:57:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 01:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496854.767783 (Exim 4.92) (envelope-from ) id 1pSpzV-0004a1-3z; Fri, 17 Feb 2023 01:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496854.767783; Fri, 17 Feb 2023 01:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpzU-0004Zu-VJ; Fri, 17 Feb 2023 01:56:48 +0000 Received: by outflank-mailman (input) for mailman id 496854; Fri, 17 Feb 2023 01:56:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSpzS-0004ZY-Tj for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 01:56:46 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52ca481f-ae66-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 02:56:43 +0100 (CET) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31GK53kf017780; Fri, 17 Feb 2023 01:56:32 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3nsp88ay20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 01:56:31 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AM7PR03MB6152.eurprd03.prod.outlook.com (2603:10a6:20b:134::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 01:56:27 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6086.026; Fri, 17 Feb 2023 01:56:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52ca481f-ae66-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSKbjKV7K1KFrbQ5RuailHgytiOr1QesUoS1oPk2RauXuyicmmdfIVDdWYzOgG//kHVPG5bKE0eLyHZkHigev5xmpIkkdN9eKuA9USFkksvhPQUrR6f7v192rT3CjYdWdT5rGF2lNKxL4L/6jrK1zqkaC4BWzc6JS/j4XJe9wTqA6fl1kgpdUqs0HnYlEe0vyYhvd2bj1EuVu1ZMKr8SUVNPQz5Azz5XuKTtcNtcceagxfE0h0YKgqzPazinFhocbKgB//TBsX7U4nQ2M64Ygl6ZNd5Dh3duY5IcgnqLmbXTPwo5IzT4FQtYfxD1xkMDme9vFd5iaieQ5FrtHEexGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d2y/DrUVa0c11NRh59r0tbNS03ypDf2k1REZaYaAuKM=; b=d/xEBuepJ1fkSPVtz9wkfPINLO3HsG1tAMFoqRosyUQKBKAtFTfZi6YmDQ3NYa+QGEOhtVhpIvpeITmYZxCvo3s8iMqJdCzk2XJ6JgwsiYe1mtrU4H0UncvaYgPA5XFTvxiIdQiooaGxpmn4OfYLtFCHAtWnxtaH3Ulw73fQibh1D5k90+OZFRmhB/KjzM513xF3h7lWR1jw1F7Hesd2yEyJuiOCej9ynBc7D3JK4gG6xQB9QpYUS1avsDWjDoHYf8M4+Z0Rf7uJGGwyJbx5xBvLFXHzjyjaO8on60hDY/8V132mpPPGDw+zaHWJfVdebXSR69kkQbQvVUL5dZ4WaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d2y/DrUVa0c11NRh59r0tbNS03ypDf2k1REZaYaAuKM=; b=Q/O3vwIprh4I+PZhY06k0sDA8fSkoFFlJRRol2m70JApf3ycvpdcpkL7+Pu8dJAB8Pj6/aGmqEtQuz9W7LpQoLDH2Xeji797U2s5shve079AhscsORxX+fMer4wws9ROUfqotrSBjblLiG6vIx5CClTWDVLgOkKHYGatRj2RXGiZ5cQ8rWEDfMq1gpbIR9M6vo72YLyBIgBB9mCJbKgR5MxxPoHwb9Dxa0tbqudzFZLsTicmCGKjKivX1faIFaYlcn5WPRxz2PhA3EvSnjp0rnMeqXNx5jMuBhTOAnEUM0FY5tp6FE/RCIaZGJTUVtkFBDU82SFgJ80Urue4SUTWZA== From: Volodymyr Babchuk To: Jan Beulich CC: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 04/10] xen: add reference counter support Thread-Topic: [RFC PATCH 04/10] xen: add reference counter support Thread-Index: AQHYvUN+XE3jlJIvEkq5uMVpvnNlQq7Q5HaAgAKFNIA= Date: Fri, 17 Feb 2023 01:56:26 +0000 Message-ID: <87sff512d2.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-5-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AM7PR03MB6152:EE_ x-ms-office365-filtering-correlation-id: e0e187a9-7370-4c5a-ee8c-08db108a2df5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gyc9XjsQWHnO0YyX3pKbDPmTU830cls2qYhByTWdTcECB7XcMAtmV2k67ICY2OoJtulpfEXd765KuPMwXBGlhT2+jzP0ZBPqagg1Av4iVORc8pG9JbhBcmksdAtor4ndFDVjq+pRtB+beM6XxSI9JX4e/WxGa9d0njgZqhNeSQFHuW5Ju5+XWDzplEefK1FPYbpWTh5sl4nqJKTN/YJDijYfTH/YLt4XmHVPAOnnq21T76LlrTrtZKDsRD+Lv9hcuQUouHdVswQlHXYA/RXHxVvMsC9iFF1J2Q4C6WRbpHCYkZUBW+wTYJD5EWOqmsNL2YylzxQhIzkeW7WYbjkrTSFysq2sQpQeQQLIe1Dyly++jZmq/pMO4Xmr1UfUm3AT9gIAd1KH51agSht+G9cPF3ozfTXN3NgmGGHaemgKu3MQ8SeSZp94SG2dn+5AlOdVtayTTA4+9wJWJJG1M/KE8rmrDbQm2/MJHrfuKhAlFPLVqRYo6hzImgtl0z3R0O7EoBGm0i2uvWCCiT7R9DN8JbGGJfxlPGVXpsuI6Q1yA0h6jbbTu1+W5LpkbaxZgjiQcObfWUAenq23vTflL+IDs4z1IuXc4XIbNR81LH0a0+Kub45kOt6os3R/PRZ2AP+FePujmb7ekC0rthN5Yf4GfPSbahdpXHD37ZkbXyZbDajN5U4JWxrxVBd5XS9s4Qllb8VCWwHFx9wGRaFINYUumA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(451199018)(54906003)(478600001)(2616005)(71200400001)(6486002)(55236004)(6512007)(53546011)(6506007)(26005)(186003)(36756003)(38100700002)(41300700001)(5660300002)(86362001)(38070700005)(8936002)(316002)(66476007)(8676002)(6916009)(66946007)(91956017)(66556008)(122000001)(66899018)(2906002)(66446008)(64756008)(76116006)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?WM4RTZVP8tghxnWKL+r3vB804cENtd05gHiWxJ5ZKh//MAI48sKYTxXRGB?= =?iso-8859-1?Q?3MJBW9N/ZiiKpDRn8Z8qgL3aVzmCBBv/elYGpaS8CVd3rWNOY4cRu5D/ea?= =?iso-8859-1?Q?SwT+Vm9VRu+sShbObwhT5xxFV7Eeaz7MVDfuSqClJV8FPWPUbScQJ6FQvA?= =?iso-8859-1?Q?KP9YAAWjB+2xpgnwuEOVPGC/azzBpUmkojbhmJ6gTnWZHGgIgaHGf1dOLR?= =?iso-8859-1?Q?cyhuA0Dxa70VrCF+0J5I5uUYq26R/ol02D3VJy7vdAUAEwBn91DIZ1dkbe?= =?iso-8859-1?Q?srn1iqq9bBjlkEEFLXp71rDAdlnM3gQAqzKmGJ6fa4owI1oFHozD7J3Gxx?= =?iso-8859-1?Q?AZhss670OjQMH2VAAMaQ+v3aJW+LrAw4Q1daTnmHGJARf34uZEzZQZN0XT?= =?iso-8859-1?Q?eOA8/zEeBT/YOb2TWZIYKej9/9cq1lI2zy07c+hOzucMRh+pvIYs9Cg3sV?= =?iso-8859-1?Q?al6cVQzXOzBVJIM/F1e4pMXo5pHYplD0Jb+E0/XoHFtsBK0Uog32su+QzP?= =?iso-8859-1?Q?e3k4pmMnPttYO9C4nhnoo4wZzbGiVo8gZBhD7rW6uWvrECL0XGYehSdHz8?= =?iso-8859-1?Q?2ejIzdiV07xCnPhZPY3+4AAzn7qePUF/zJB2vcddqgIjRoLSdGVkQ0iIoK?= =?iso-8859-1?Q?N6EirxhRRdoO6KiuAnqNLOFXTtlV/4H6ZQ4oh2fJDvOyzXdhVvvjMOYJq/?= =?iso-8859-1?Q?OAll7jwg1dX81730Vb/DG6ZGg8bWS7c1vrkFoHEm3eMk2gMLbPXOcEtFV8?= =?iso-8859-1?Q?wzDZ/1cLWDZyXAdHh55KZjCf30bHZFo2HkXQR1KLaogAwm2mUh/AQwm/2/?= =?iso-8859-1?Q?nnL1HfX1mMkJz60gA/+k1gfhwCeSnLZW43w4n7ihjwuWD9Jf0Qw/5bkLT0?= =?iso-8859-1?Q?XiKdrLvzjlLMNWGugfrc5JdJcKIJXGcYw4crpq3nURFlVO60PWsU6Icsd2?= =?iso-8859-1?Q?Qt6kEXdSbBrDqxtqeyxQZwufIeZwgx7LjWc1HqjiZud3+3cwiXWkNqn4XD?= =?iso-8859-1?Q?MxfQMW82c37uvjjJZYPYdNAWr3ZLUNU4vLAwE9oMJw5dOTIVvO/APFbFgd?= =?iso-8859-1?Q?MMQ+WHB/pcZ+ojVscoZ7KB8nFuC8iBiOdkXB6HMGjy61qlroUP+ZnrtUOr?= =?iso-8859-1?Q?4ZbohX+1cRU6LeNOREO9xMkWYvedDSXS+bdkr8rYvrlyW+69uN6BqpEAsl?= =?iso-8859-1?Q?VAevAhIm75SLTWYQpWMwXDWJj1rj/sxwjpKjYDAsIOF/94a7sU1yo3kLgl?= =?iso-8859-1?Q?q7V0xvWsv9R8bkRTG+fonyp6wZqsldZZzpCn1GZf/nW8ZmlhXhlMMw4pzE?= =?iso-8859-1?Q?y3cWrHaXdQjFKdQl4bH7ixoPL6ZPx+0+8ubW/d8CvFPQyhjnPReTJKVqsU?= =?iso-8859-1?Q?7asDirbJYO/dmVmYv7Snql4G05wMWYCI+RCAivmrKDBcQvmC4FaL3j0jrT?= =?iso-8859-1?Q?NunJf3ZHferdmrr5J78gHwBUKIMh+s3MU6Hwg7sPcQ/9E0L/1rGdMEUTwB?= =?iso-8859-1?Q?M9bwHUolLOPSeeTvvFQ+NsNHlaFIeHw3Jwe1MyDtJJc8nrD//xmzpoYp3X?= =?iso-8859-1?Q?DxQtAGFZy4Rfiw0d47zoinjvYF0PKUa03NCJeNXLDX54/nSYHHERFcx8bj?= =?iso-8859-1?Q?QZUSOknntPo8yY3qcB4RDCNyl6+PTKrVBBZr+QwTw8Jr77c7SbmGe2TA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0e187a9-7370-4c5a-ee8c-08db108a2df5 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 01:56:26.5524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EQbeppY0eziokrvnjxfy/0xGfKd44IRZGsviRaGvkH83rLCeLXuaShuE69AWhZTMM8uEjJ0lJ2X9NScXavRAsAvyEs3BIQ+xyI2uB0sV0jY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6152 X-Proofpoint-ORIG-GUID: r1gPpwhf77Ri8Lypnsn-Rf6fO_2r1alb X-Proofpoint-GUID: r1gPpwhf77Ri8Lypnsn-Rf6fO_2r1alb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-16_18,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170015 Hello Jan, Jan Beulich writes: > On 31.08.2022 16:10, Volodymyr Babchuk wrote: >> --- /dev/null >> +++ b/xen/include/xen/refcnt.h >> @@ -0,0 +1,28 @@ >> +#ifndef __XEN_REFCNT_H__ >> +#define __XEN_REFCNT_H__ >> + >> +#include >> + >> +typedef atomic_t refcnt_t; > > Like Linux has it, I think this would better be a separate struct. At > least in debug builds, i.e. it could certainly use typesafe.h if that > ended up to be a good fit (which I'm not sure it would, so this is > merely a thought). Sadly, TYPE_SAFE does not support pointers. e.g I can't get pointer to an encapsulated value which is also passed as a pointer. I can expand TYPE_SAFE with $FOO_x_ptr(): static inline _type *_name##_x_ptr(_name##_t *n) { &return n->_name; } or make custom encapsulation in refcnt.h. Which one you prefer? >> +static inline void refcnt_init(refcnt_t *refcnt) >> +{ >> + atomic_set(refcnt, 1); >> +} >> + >> +static inline void refcnt_get(refcnt_t *refcnt) >> +{ >> +#ifndef NDEBUG >> + ASSERT(atomic_add_unless(refcnt, 1, 0) > 0); >> +#else >> + atomic_add_unless(refcnt, 1, 0); >> +#endif >> +} > I think this wants doing without any #ifdef-ary, e.g. > > static inline void refcnt_get(refcnt_t *refcnt) > { > int ret =3D atomic_add_unless(refcnt, 1, 0); > > ASSERT(ret > 0); > } > Thanks, did as you suggested. I was afraid that compiler would complain about unused ret in non-debug builds. > I wonder though whether certain callers may not want to instead know > whether a refcount was successfully obtained, i.e. whether instead of > asserting here you don't want to return a boolean success indicator, > which callers then would deal with (either by asserting or by suitably > handling the case). See get_page() and page_get_owner_and_reference() > for similar behavior we have (and use) already. For now there are no such callers, so I don't want to implement unused functionality. But, if you prefer this way, I'll do this. [...] From xen-devel-bounces@lists.xenproject.org Fri Feb 17 06:06:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 06:06:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496864.767793 (Exim 4.92) (envelope-from ) id 1pStsr-0005DJ-Mx; Fri, 17 Feb 2023 06:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496864.767793; Fri, 17 Feb 2023 06:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pStsr-0005DC-Jv; Fri, 17 Feb 2023 06:06:13 +0000 Received: by outflank-mailman (input) for mailman id 496864; Fri, 17 Feb 2023 06:06:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pStsq-0005D2-4O; Fri, 17 Feb 2023 06:06:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pStsq-0002Mo-1Q; Fri, 17 Feb 2023 06:06:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pStsp-0002rO-L7; Fri, 17 Feb 2023 06:06:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pStsp-00034I-Ke; Fri, 17 Feb 2023 06:06:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5cm4PoOnQ7dD2RU1tBLoYCVQQPgnVbMikqJibHP7JXI=; b=QIEPT9rM2CFJ0GNKRXm+Tp8/Tp 4ScbSiZYOmvePKC2sIkDMdfbVlD4UVxlhrzGbVfZp45XQkwBRp2dA0H2+6UCNO6iHhqU8EfI7wCZW K6qXqgWbs35/gRZlRgxx9wMVnowipEvtAQ9uGmyKuSjX9fFls8wys7WEXzPeKqQFFRqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177531: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=3ac88fa4605ec98e545fb3ad0154f575fda2de5f X-Osstest-Versions-That: linux=033c40a89f55525139fd5b6342281b09b97d05bf From: osstest service owner Date: Fri, 17 Feb 2023 06:06:11 +0000 flight 177531 linux-linus real [real] flight 177568 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177531/ http://logs.test-lab.xenproject.org/osstest/logs/177568/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 177568-retest test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 177568-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177451 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177451 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177451 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177451 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177451 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 3ac88fa4605ec98e545fb3ad0154f575fda2de5f baseline version: linux 033c40a89f55525139fd5b6342281b09b97d05bf Last test of basis 177451 2023-02-16 02:59:06 Z 1 days Testing same since 177531 2023-02-16 20:42:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Stein Andy Shevchenko Andy Shevchenko Bartosz Golaszewski Chandan Kumar Rout (A Contingent Worker at Intel) Christoph Hellwig Corinna Vinschen Cristian Ciocaltea Daniel Wagner David S. Miller Eelco Chaudron Eric Dumazet Felix Riemann Guillaume Nault Guolin Yang Gurucharan G (A Contingent worker at Intel) Hangyu Hua Hector Martin Herbert Xu Hyunwoo Kim Ido Schimmel Irvin Cote Jakub Kicinski Jamal Hadi Salim Jamie Bainbridge Janne Grunau Jason Xing Jens Axboe Jesse Brandeburg Johannes Zink Jon Maloy Kuniyuki Iwashima Larysa Zaremba Linus Torvalds Linus Walleij Maciej Fijalkowski Mark Brown Mateusz Palczewski Michael Chan Michael Kelley Michal Wilczynski Miko Larsson Miroslav Lichvar Natalia Petrova Paolo Abeni Pedro Tammela Peng Li Pietro Borrello Raag Jadav Rafal Romanowski Rafał Miłecki Ronak Doshi Siddharth Vadapalli Simon Horman Tony Nguyen Tung Nguyen Vignesh Raghavendra Werner Sembach Xin Long Yinjun Zhang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 033c40a89f55..3ac88fa4605e 3ac88fa4605ec98e545fb3ad0154f575fda2de5f -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Feb 17 07:12:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 07:12:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496876.767804 (Exim 4.92) (envelope-from ) id 1pSuv6-0006Uv-SK; Fri, 17 Feb 2023 07:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496876.767804; Fri, 17 Feb 2023 07:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSuv6-0006Uo-Oy; Fri, 17 Feb 2023 07:12:36 +0000 Received: by outflank-mailman (input) for mailman id 496876; Fri, 17 Feb 2023 07:12:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSuv4-0006Ui-LS for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 07:12:35 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20604.outbound.protection.outlook.com [2a01:111:f400:7d00::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71cfd1c2-ae92-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 08:12:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7101.eurprd04.prod.outlook.com (2603:10a6:800:12e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Fri, 17 Feb 2023 07:12:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 07:12:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71cfd1c2-ae92-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBwEhsp5MkIRDmbIq3q0VxCyU+rx8qb6/esxJl7rK9khnXMaArBgy1kkL5p4Zi3bM82NSXsNhmY+Gt5xICkjOIm0WRDYokhpTN7wrYs8xrTfGIJ8FkZkB85TkDhxTfefloRJQdoFrhNXnShffR3GeZ2ZU4eFBxdS7uSmrhLGYSLanTboRDqtHNMNVtnRZfpB/DFISvocUlvQqdCUjAHZ8ipHEqCVIQ6D0PWGcIYjG49/Kra1oAb5+XpMgSDq5/1FCr3QBHVYQHPQMDCDm+OUglM49qtqFhXm9fAy10Iz4XRXAjnCzcA3pdClxFr0avfd6fNEsygEtOkZaUCxPfj8XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1EOdD2wBr2TeTeg9Y1qoWwpjV8hyLFsLt3tEhEorEiY=; b=cp3Yl54P7Dy/BV9INBOzXK5CmiK0uwXfgM2rloSP8e6BVfwQ/aXCKZYaesMe1jRskqzEqcrqTUhDvkMjYjnHnj7BAGxt6l4qYUUAiDfNu/mVwkhs0h7Ey8wr8mpGn7csdKlact4g7JGqDpxReMDRpbTln82M8bLYwgheHB3+jgIDGLw0mkD9W5hLKE9b40i+2KGgW/KQHqekkQWuA3lwn5IV+zPFxUjSU8481qQm0t7IY3TO20rvY61rgzFfQjAkNuVL9lIf8+PK0Z3H7rA+Rw7z0CtIYMWMFgkIg4cNZbGJvldBXexvAncp2aNDSEITSkDBVdQ24RFlnN9c7leBmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1EOdD2wBr2TeTeg9Y1qoWwpjV8hyLFsLt3tEhEorEiY=; b=5pfLy1IJ/QdJOBVMgORYHfDkxc8ryDPy/1eXjK6T5fghfqG9UOzoYfoxO9Z7/eJVn+qoOgw3xefopmwnlD6zOFPjFOUkA1mxUL6xjM8Oz7aa1m+Y8UDTWHJQmWng011Y0ceXvlJm8Uln27o9PyBB2eK4cWSs8fFGZFa0iweFly67XpMm9GY3Q1Rirj2oc7+m8FnfZOT4C7fAepRwfDHJ8qI/kJo0oyrRqd2jc439UZMjCdBIsrntLmTmxL5OeFpFjfGyGtc0LQv9nTqkqZTAVhAKccYR6a8YbPJozGGFdwtPm1Nzi/iOfCxXRfKhHumRSJPWbkRjaT2jGu2r7hbOkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20191ac6-3c1c-8c9f-39ed-308bc22d5b3f@suse.com> Date: Fri, 17 Feb 2023 08:12:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> <4c52d703-dd7c-b316-5e37-38c9aa705725@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7101:EE_ X-MS-Office365-Filtering-Correlation-Id: 521de334-f422-4d40-a6af-08db10b653ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A1wDP5BpHTf+czUltgzZuycRKcFevKL8dDLtlniAaJSkCVnmxVS2xukECFd33e0Ke7sU+bTzj7q1aFQRK5lQvb8c5uXd1wd6X9KQNUMlPk1l7WBlWzOdjg2SP2bmS73nEcjj1KPFjs0M7to7epbLjYlytm6Sx3aI1jG42sik6Iy4YYi0wZbzI0N0bpBwsSO5qQgYgMJa28L4iI2FsJNFdDAzrjdXgMnw+awusAnYy/7EofQDAdGJSEkynkEPFcb0ra/fX1NPTDHNSFeZBdbYwtZUHZlS+zh1lsVhkWwsoJ7blsQ3JqCaicjihaoE3AZYMFeU3gYroAednOn/uh9GbrkyxgmJ3LiMMqpuom4DQIzPmEapoJIJYabUeBmeHeH0c0ivNZvmok0ozLkZHGmG8NxWuYbPR1idDYcxC3aHMR9egPZg9px7FLEATZX18CI0GkkfXk5RD/jlilH6Oq7D19Xx50/BXdbANxvA7dRZVyvyvJJXAghz0Avk3JKBsqHbkF0VkWvCiGxXsCSFFerOxMPmwLEZFT1sVvFsuEoGNfSe6P5tKD9CDJxmeLmfleX0wiClMP66CtD+8YXNE/ENZwkLtftiRi11juwWPp5WWLeHAcvFDHH6sQmPTO9LwT96++AktZRd5c0swGfhYqhxa8w9plr3ZtuP6frn+EYut7ctuEav0fAGd+RmsN0cpacu/9GjOn0nPLnOdUV0yzx1I3scfhSl6WMxgUTXvJE5rxq2c/Gf9kMdKaIyPwemNltj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(39850400004)(136003)(376002)(366004)(451199018)(41300700001)(31686004)(5660300002)(54906003)(66946007)(66476007)(6916009)(66556008)(8936002)(316002)(4326008)(2906002)(8676002)(478600001)(6486002)(186003)(2616005)(6506007)(26005)(6666004)(53546011)(6512007)(36756003)(38100700002)(31696002)(86362001)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUNMa3lRSGNsQjZPbXRvK3ZTWEJyUnlOc0VWY2FQU1RYT09lM0lHZ25TcExW?= =?utf-8?B?ZlRLWVRtYWsrSU9UbnVrOWR6TzZkVVZKdkpHMUQ3TmV3cWdrcTNSb2RkRFBS?= =?utf-8?B?ZG8yS2Irc2ZEWGtiV0ZmdGdsdExEM3NaRTd2RDNCNnNwVks1cHNjeTMyQTlt?= =?utf-8?B?YW5jMEo4aTdkWHMycmxXWDZiSDZGeHRKS0NRMjVoSmhpRHM5ZkNDbEl2UjRt?= =?utf-8?B?N0o0RkV4cEdibVlYUXFsM0JkMC9OVTBPY2RtbnphdkRiWEZHZ0hsSUM5NERS?= =?utf-8?B?aTU0NHBrWDNrcThaaTZXUWlRSElxNGFBUEVpR29qSnBTeUQ1YUEyajBxME56?= =?utf-8?B?eWR3RkVkRXJkUWhqWitvQTFZMy9aazgzME1jMEIrRFU2Wk1DUTk2WjZFNEo3?= =?utf-8?B?SmZ2a2VMS3YrV3l2Ym1hSER5NGpRbmZJL0t4OTBOTnI2NEdQK1pWZUxCOWxX?= =?utf-8?B?aWtEMXhnSXdlbzNLaHpEbVozaTUwNmlBUGlUeiszNm8yQ3cxZ0FINUIwSGdG?= =?utf-8?B?Ynl3djBoZEdZMXYyNW01SzJTWmxzS2tRQ0RjNGtZMXlzUHNJckxzMXFTT2R2?= =?utf-8?B?WmVlWmJlcFI3aVMxMFF3bTkwdVp3c2NrNmVGQW1hc0dXRDNscTBlUEs2VGU4?= =?utf-8?B?Wm5zRGc2eXRUR2hqRDhHaGxyMWh3K2hqck9rMXNTenh6dzhYWFF6dFdqV2ts?= =?utf-8?B?YUJscmVaejJiSmNPOWdXQmVGSitFZ0FtUEtIdnpDdWdBbEsyWDVCV1lsaGVP?= =?utf-8?B?dUxFU3FiUXQwTCswREtTcEMvakpUWXJPYStGajhkZy85OFhpRUR5TDBOMUVK?= =?utf-8?B?WnRWOERwMXNFZXljMUFYMnZ6Y2E0KzlTcVNEd2svaG54djAwUmpsdnA1WTZa?= =?utf-8?B?YzdBU0Fkcjg1Kzc1MEQ5cWtJbmhzT0NpdHFvMnU4UG9qRkhFd09YdXRuU0hE?= =?utf-8?B?RXFhUmJ0OHh5NCs0ZjNHcGVHK1dhdER2VTVoZlN4U2hsb3hSTXVzb0NMSlZ1?= =?utf-8?B?UWMwZi83S3JHRFdCOUM2WnVkV1pmT0d4ODJNZDA0OG1jSmZoUFdsd2ovY1Fv?= =?utf-8?B?U2hBOHVjYVdmblExYy8zbWtiQ3lGdTU1cFY0QzQwYnhQejlRVFNsV3VSNEFi?= =?utf-8?B?cGwyTk56c1FQOU1YTk5XeTlFVUxGSk9KT2RBQ3RaOFhMYlNJT3BCSFBIQ05r?= =?utf-8?B?UGduaWNCSVFQeVBGNW1ldXJhSXI3d3JsU3NqSEdSZk1reVp4T0JiSkQvNStH?= =?utf-8?B?M21rZEpUbndFd0RuOW83VkpkdWxTMU4vTVF5MWtETzNPa0hiVGhTcE5Pc3JW?= =?utf-8?B?SWhkeWRhZWNyWW9UNzJWaVQwd05ueHlNa3REVUZwVHVjdndzYi9iczBMU1JR?= =?utf-8?B?cVNUVHYvaDZlNldwMTcrT1dCTTZlczBpNWsxaWlON3BkSllOTms4UUtiS2Iz?= =?utf-8?B?Y29lQy93a0hqVTVaMU82WXR6UHNmMnVBaGFOdzlUMUtxcFY2QnQvYS9aSUFT?= =?utf-8?B?YmJ2SGJBOFZKaFR2QkM5QXhvUGJwcjE3YUVLdXNEZU96SjVhbXhKWjR6d3lj?= =?utf-8?B?VmhqMDVBNng4N3d2SWl2RnlqSkd3SmNkYjkvMDhIMHUrSkRjU0Y5Zjdpeits?= =?utf-8?B?TktIbWNta2liL09lNFhMUmg4cm9KdDlHTmNWdjY2WTUxdHNreE1uN0VzaHJD?= =?utf-8?B?anVUSE80Q3dHWmNEQUxRK1BSVzdrRTgzWHFoSWY3ZDhRVGZvdUpjNGtLTHQ2?= =?utf-8?B?eTRPL2VpanVuemIzRWkzdDVOcXhtd1lTQ2VLMG54TFZPWlVvOUo5Z3F3MzdV?= =?utf-8?B?ZUVwQ3UydFR4UFNSeC9oNlpKRUw2SUdBR0Y0NC9Ta0dqV2djZmdETTJWS3VJ?= =?utf-8?B?ckFDZ1lFQTRUVDMzNzZlczlPNWhnWVVRWjAwdzc3NEYyWUpyamE4NFJUN09t?= =?utf-8?B?Y0c4ZFVxb0ZybTkwZFBodmc0eTR5UDgxUVFxcS9FK3M2NWdNc05kblh6NGtS?= =?utf-8?B?SGJUSUFRNkMwRFJhQjBWdEpvQ3JrMHBIMlRFMmR6T243cnNzdGxmQXVYam9X?= =?utf-8?B?YnFrK1VCeE8zdFZub3RPV29VaTRDUlpGMXpuWHdhRXJ4cGM1emxIT1pEWVk4?= =?utf-8?Q?oURR9sgQiJjgdESS+LUi6ffdc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 521de334-f422-4d40-a6af-08db10b653ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 07:12:29.0879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: COYM+vopr50Uo6Ux47KF6s8YT/DjYi4Lwq4oL7Eehcfp0kcUeitXcvZjaOw2q9l1s9ZvLF7oVyGMCgnNVmNOmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7101 On 16.02.2023 21:44, Oleksii wrote: > On Thu, 2023-02-16 at 12:19 +0000, Andrew Cooper wrote: >> On 16/02/2023 12:09 pm, Oleksii wrote: >>> On Thu, 2023-02-16 at 12:44 +0200, Oleksii wrote: >>>> On Thu, 2023-02-16 at 08:31 +0100, Jan Beulich wrote: >>>>> On 15.02.2023 18:59, Oleksii wrote: >>>>>> Hello Jan and community, >>>>>> >>>>>> I experimented and switched RISC-V to x86 implementation. All >>>>>> that >>>>>> I >>>>>> changed in x86 implementation for RISC-V was >>>>>> _ASM_BUGFRAME_TEXT. >>>>>> Other >>>>>> things are the same as for x86. >>>>>> >>>>>> For RISC-V it is fine to skip '%c' modifier so >>>>>> _ASM_BUGFRAME_TEXT >>>>>> will >>>>>> look like: >>>>>> >>>>>> #define _ASM_BUGFRAME_TEXT(second_frame) \ >>>>>>     ".Lbug%=: ebreak\n"   >>>>>>     ".pushsection .bug_frames.%[bf_type], \"a\", @progbits\n" >>>>>>     ".p2align 2\n" >>>>>>     ".Lfrm%=:\n" >>>>>>     ".long (.Lbug%= - .Lfrm%=) + %[bf_line_hi]\n" >>>>>>     ".long (%[bf_ptr] - .Lfrm%=) + %[bf_line_lo]\n" >>>>>>     ".if " #second_frame "\n" >>>>>>     ".long 0, %[bf_msg] - .Lfrm%=\n" >>>>>>     ".endif\n" >>>>>>     ".popsection\n" >>>>> I expect this could be further abstracted such that only the >>>>> actual >>>>> instruction is arch-specific. >>>> Generally, the only thing that can't be abstracted ( as you >>>> mentioned >>>> is an instruction ). >>>> >>>> So we can make additional defines: >>>>   1. #define MODIFIER "" or "c" (depends on architecture) and use >>>> it >>>>   >>>> the following way: >>>>    ".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", >>>> @progbits\n" >>>>    ... >>>>   2. #define BUG_INSTR "ebreak" | "ud2" | "..." and use it in the >>>> following way: >>>>    ".Lbug%=: "BUG_ISNTR"\n" >>>>    ... >>>> Except for these defines which should be specified for each >>>> architecture >>>> all other code will be the same for all architectures. >>>> >>>> But as I understand with modifier 'c' can be issues that not all >>>> compilers support but for ARM and  x86 before immediate is >>>> present >>>> punctuation # or $ which are removed by modifier 'c'. And I am >>>> wondering what other ways to remove punctuation before immediate >>>> exist. >>>> >>>> Do you think we should consider that as an issue? >>>> >>>>>> The only thing I am worried about is: >>>>>> >>>>>> #define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ >>>>>>   [bf_type] "i" (type), ... >>>>>> because as I understand it can be an issue with 'i' modifier >>>>>> in >>>>>> case of >>>>>> PIE. I am not sure that Xen enables PIE somewhere but >>>>>> still... >>>>>> If it is not an issue then we can use x86 implementation as a >>>>>> generic >>>>>> one. >>>>> "i" is not generally an issue with PIE, it only is when the >>>>> value >>>>> is >>>>> the >>>>> address of a symbol. Here "type" is a constant in all cases. >>>>> (Or >>>>> else >>>>> how would you express an immediate operand of an instruction in >>>>> an >>>>> asm()?) >>>> Hmm. I don't know other ways to express an immediate operand >>>> except >>>> 'i'. >>>> >>>> It looks like type, line, msg are always 'constants'  >>>> ( >>>> they possibly can be passed without 'i' and used directly inside >>>> asm(): >>>>    ... >>>>    ".pushsection .bug_frames." __stringify(type) ", \"a\", >>>> %progbits\n"\ >>>>    ... >>>> ) but the issue will be with 'ptr' for which we have to use 'i'. >>>> >>>> And I am not sure about all 'constants'. For example, I think >>>> that it >>>> can be an issue with 'line' = '((line & ((1 << BUG_LINE_LO_WIDTH) >>>> - >>>> 1)) >>>> << BUG_DISP_WIDTH)' if we will use that directly inside asm(...). >>>> >>> I think we can avoid 'i' by using 'r' + some kind of mov >>> instruction to >>> write a register value to memory. The code below is pseudo-code: >>> #define _ASM_BUGFRAME_TEXT(second_frame) >>>     ... >>>     "loc_disp:\n" >>>     "    .long 0x0" >>>     "mov [loc_disp], some_register" >>>     ... >>> And the we have to define mov for each architecture. >> >> No, you really cannot.  This is the asm equivalent of writing >> something >> like this: >> >> static struct bugframe __section(.bug_frames.1) foo = { >>     .loc = insn - &foo + LINE_LO, >>     .msg = "bug string" - &foo + LINE_HI, >> }; >> >> It is a data structure, not executable code. > Thanks for the clarification. > > What about mainly using C for BUG_FRAME and only allocating bug_frame > sections in assembly? > > Please look at POC below: That's still using statements (assignments), not initializers. We expect the table to be populated at build time, and we expect it to be read-only at runtime. Plus your approach once again increases overall size (just that this time you add code, not data). Jan > #include > #include > > #define BUG_DISP_WIDTH 24 > #define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > #define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > > struct bug_frame { > signed int loc_disp:BUG_DISP_WIDTH; > unsigned int line_hi:BUG_LINE_HI_WIDTH; > signed int ptr_disp:BUG_DISP_WIDTH; > unsigned int line_lo:BUG_LINE_LO_WIDTH; > signed int msg_disp[]; > }; > > #define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > #define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) > #define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ > ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ > BUG_LINE_LO_WIDTH) + \ > (((b)->line_lo + ((b)->ptr_disp < 0)) & > \ > ((1 << BUG_LINE_LO_WIDTH) - 1))) > #define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) > > #define ALLOCATE_BF_SECTION(has_msg) do { \ > asm (".pushsection bug_frames \n" > \ > ".long 0, 0 \n" > \ > ".if " #has_msg "\n" > \ > "\t.long 0 \n" > \ > "\t.long 0 \n" > \ > ".endif\n" > \ > ".popsection" ); > \ > } while (0) > > #define MERGE_(a,b) a##b > #define UNIQUE_BUG_INSTR_LABEL(a) MERGE_(unique_name_, a) > > #define BUG_FRAME(type, line, file, has_msg, msg) do { > \ > unsigned int line_lo = (((line) >> BUG_LINE_LO_WIDTH) << > BUG_DISP_WIDTH); > \ > unsigned int line_hi = ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) << > BUG_DISP_WIDTH); > \ > ALLOCATE_BF_SECTION(1); > \ > *(signed int *)(&bug_frames) = (unsigned long) > &&UNIQUE_BUG_INSTR_LABEL(line) - (unsigned long)&bug_frames + line_lo; > \ > *((signed int *)(&bug_frames) + 1) = (unsigned long)file - > (unsigned long)&bug_frames + line_hi; > \ > bug_var.msg_disp[1] = (signed int)((unsigned long)#msg - (unsigned > long)&bug_frames); > \ > UNIQUE_BUG_INSTR_LABEL(line): > \ > asm volatile ("nop"); > } while (0) > > extern char bug_frames[]; > > static struct bug_frame bug_var __attribute__((section("bug_frames"))); > > int main() { > BUG_FRAME(1, __LINE__, __FILE__, 1, "TEST"); > > printf("bug_loc: %p\n", bug_loc(&bug_var)); > printf("bug_ptr: 0x%x\n", bug_ptr(&bug_var)); > printf("__FILE__: %s\n", (char *)bug_ptr(&bug_var)); > printf("bug_line: %d\n", bug_line(&bug_var)); > printf("msg: %s\n", bug_msg(&bug_var)); > > BUG_FRAME(1, __LINE__, __FILE__, 1, "NEW TEST"); > > printf("bug_loc: %p\n", bug_loc(&bug_var)); > printf("bug_ptr: 0x%x\n", bug_ptr(&bug_var)); > printf("__FILE__: %s\n", (char *)bug_ptr(&bug_var)); > printf("bug_line: %d\n", bug_line(&bug_var)); > printf("msg: %s\n", bug_msg(&bug_var)); > > return 0; > } > > Do you think it makes any sense? In this case, all BUG_FRAME can be re- > used among all architectures, and only bug instructions should be > changed. > >> >> ~Andrew > ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Feb 17 07:15:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 07:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496881.767814 (Exim 4.92) (envelope-from ) id 1pSuyB-00075K-9b; Fri, 17 Feb 2023 07:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496881.767814; Fri, 17 Feb 2023 07:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSuyB-00075D-6t; Fri, 17 Feb 2023 07:15:47 +0000 Received: by outflank-mailman (input) for mailman id 496881; Fri, 17 Feb 2023 07:15:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSuy9-000757-9I for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 07:15:45 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20617.outbound.protection.outlook.com [2a01:111:f400:fe16::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2866646-ae92-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 08:15:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7356.eurprd04.prod.outlook.com (2603:10a6:102:8d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.14; Fri, 17 Feb 2023 07:15:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 07:15:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2866646-ae92-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNuGkbyhqsJNGFZJAhGTc9rqKPl/zpYTrP2j7CD+XhzcTok2p73B6K5oK6fm5YgB2ImZGSKhuOT4v932Ek2UgLIjsqP+LOE4ilRemZndvwPjo0WU/qVdIcShflDURFoxRoVU8nzAbCc70JMOUXflyqRpqrFWntum7oZ2kZ72coLEB1JhUmX8LgJdI9AvPepisvwwpwlKkpxbMKqJ1zdeBne+tULfbonIK78J3qsUWkjb7bf2iOC1yMp/ARW7J39lKCzUJgZTRS2kAJyWZavu1+QruJkhMhrYBQ9l7td0JwyqhTvdBQmV2jJ34+RTCZivjZrnx5CmzIL7hZhkQ4QmkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5qd0OgP0V0UZhanYfKU6Nl5IoQZcuoL71qjJ3ABuoLY=; b=nNGVtdhOFgTX+aIIpH5QO3/cLWPcMPkz9UMVIpNnoI/XvfbXKrldJ1gtag/U+RjbazdzaPngrndx38sDzXCFpzNpkQuglKodCM4hDzA2uyj1gn7HdFS5DBzV9wRwMvQg/iQin9lRV9ia7O6JYHcORqTNgjfNy4UMTB6lh+rziVt+8J1UNk7+d/2YOtZo1DvqDyruH/KmWCq3WF0EEzwyx3oPUBcbnKvKziprLvnjPcvF6W0HsXSmAmyXhax2jvsaING9dtLZmnqkELddZm8QuCJR8nM/3VxV7kJ7J8IptxYmnwr5GjbbCJzpxf92HLNH/u1KItTc67jaujV3MesCxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5qd0OgP0V0UZhanYfKU6Nl5IoQZcuoL71qjJ3ABuoLY=; b=mY4Lwp3CMk2qUoA2OUEbRQ9LpI+hBOHMIpDNjJmUy+yhhYVgBdY/IwLTGG8zpfDqQputQt9THoHJZnospW0F35bW+RJAjXCNgg6mvlohlfkGzU8meBnqFx+iGoOl1TSg1oCXJKaEs8KV6eKREZo+WYX0Eu1Jfx8ykZa7QYm/SCKty2/dJnG8nUATwBPebIGi/iQlO4L3i7LnWSwtKGAXtxoedE65gDpAzwgBsK0LREKC5EaMJ7wYy4tqFgCG0nr1pMTIUrfxJ/0vRdJmupIW8dZlxmUjKVol82jhls+8R0NCvv9qssfNb+1hOIpS/rsAXl6Hol9eUpIb7COmdLrqAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 17 Feb 2023 08:15:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Content-Language: en-US To: Stefano Stabellini , Luca Fancellu Cc: Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7356:EE_ X-MS-Office365-Filtering-Correlation-Id: 98145a6d-9a3c-4299-1218-08db10b6c583 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2tHgn2ucp36aU6tqeNuxt/GnZnzoRCghl/WDZFYSghM7ZcVrYc3VnswydxVV7mE1pAQDvJ+R5pMTtUJHtcW4Xcifh8oY6nJiDmYhKbZsvN065x4tXMGPqBzJkvW+lje6ithIy2Ulj5p5gZmcYonIWig+PX9GoKVKeB8ajXfOlRF24XdD7vEKx1vF5nSmnxR3pbxIGrRl1zWzzqwAegrIImTspJdXblUhPNd1bL+ey1lMAWERIoI5q2SOJWmzOFUZ2Lb1cxeweQoXe8VFngLX2+hUKUsCsJuIjmz1ikpb+rTJZ1NM11n6SAeS3tj0esxBN3IvpJOAPP4KZaVHouKZ21yRmzzszlAAfl5ItF4Z3J4R+Xz4wEs0i81EkME/FuutI5r7g6pzeFANfAbDIU26K2C9l5kNeHKKaKC0khN2vjmwXmDl43mS8p8crIPv2g2tZFLCad3xF2j9li46M1L8Z4ipyZG/9CIQImur3XU5956+CSY5yVpRxDAkUwO1z0dUGUEFsY2WyjzlGxwAPu54YAyjTS/G1L+hiyOBYcdzROa0ih519r6FiE0TK86b91qTtJ9LykHsMTrgKUgP1QdJZIRq1j8CboFGZLP1/2D5qV3QQjq+BF4ptX1WcNaB7N8bbA/9upx2n/nSmuAuj1z0GglVooroS1b3BA2ulrK0jF4XiPOJnXZEPDTfCwF6Ub3VbgFuhRs1V3dpN774pcZzFdUY4g2avxW0hSCKCh8bx0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199018)(66899018)(36756003)(4326008)(8936002)(2906002)(66476007)(66946007)(8676002)(66556008)(6506007)(7416002)(5660300002)(86362001)(38100700002)(31696002)(478600001)(6486002)(54906003)(31686004)(316002)(110136005)(83380400001)(41300700001)(186003)(2616005)(26005)(6512007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEUvYmFGZDRTTFFIYitZMExobXRUU042SHJ2R3ZvRW5qeVI5Zk9FTWhRQTJv?= =?utf-8?B?V1BoZXYvcndxQlJualJnTENZMHpDeTBMWjErVm8rNThiZ3E3akJVSUpQanBh?= =?utf-8?B?YmpFZ0N0RS9VcUU2U01hY0NoRXNEbWVvbHZmazNvbDQzVkZlUkxtMTd6Q3Nn?= =?utf-8?B?Y042QWJNbVlLalN0YWovT0N6ZVI3OHd6SWl1MHRadTJqSVhsbWQ4Nk4wS1Rl?= =?utf-8?B?eHVYWkhjdFhQYkFadUdZc1E5WDJIS01KVWJYMGdtNXNsVUI5U1dUcTRISUZ2?= =?utf-8?B?Mkh4WjFkU24xZkFGN2Y3eVl3dFJFVWIwb2NsSHlRaXYxOHQ3VTB5YXZ3NzFV?= =?utf-8?B?Z3BBNnlEdmI4SEFvZlJZSnhvZnJJVk5aYVJBckJQZjlBejZVZEl6TnAveGZ2?= =?utf-8?B?NG1pWVpDRms3VEkyV1QzbkNzMjUydEF1akozQjJaSGRJRTB3eWR2WlpvcCt0?= =?utf-8?B?d1I5cDYvRStxQTZEbkR4UExmYUsyR3dZRlVxOFJQR2FWQm5WSDdlQitybS9E?= =?utf-8?B?NnE2TjdsRWJPeUVaZ1RUUW80bzdBYStSbUFEdDVacE1SMVYwRlFmNEg3a25v?= =?utf-8?B?bjlqc1N2WVJmSUdFYkRrN0pBRW9qMjdvbnJjMmhKQ0ZLOGVEcTRBaTJIVWVX?= =?utf-8?B?TnQ4VTRJQ1IrWUI3Y29jdjlESGQxUnJHM2ozSGZzVUU2VFFZUTQrK2FuRHV3?= =?utf-8?B?a1lTVjZTTGpodG8zZzY4dVhicVkxRktyWkhWR1Ztdi9iRXd4MDBGQmJUK3Zx?= =?utf-8?B?R3NVL0tXV0xrTWdwTzFjWFN5SmdZRGtSY0xXRTM5b25iVEplcFBnV2pCclZP?= =?utf-8?B?VzRVSlY1V3dYS2JaaFJyUm5ESGRvVlIraTNKcVJxYVB4bmdPWGcyOUt4Zmg1?= =?utf-8?B?T1F6OEd1TlpoVHFaRy82SWF2U3ZsYkdpd1UrWktDZmxOLzVQbkhMZnBmTUwv?= =?utf-8?B?c25ESWptSS9SRzlyNnZBcldNOWhzdy9weGt0T1ZJOEZnV1pJM2J5ZG13MkJv?= =?utf-8?B?ZE5uTXhkSUhpUm5ZeGFoK3lCK3k0S0dyZEtRU3hiQnlKNi9FUldpYkNTVFhj?= =?utf-8?B?MnVjd0ExUy81NWNjZC93bFBhMW15VzNhQkowRlBXbDc3ZDdNQlNkbnA3ZGVQ?= =?utf-8?B?NitHTTFyb3pXTUhBN3lHSnZaNVd1R3h1SG1WalFKc2xpdW80QjZaOW95eHdG?= =?utf-8?B?Tlg5M0swNzF3bXhCRlFkM1U5U2FaaDIrM3ZOajJTKzJ0dEVLSTVqZi9WQ2hv?= =?utf-8?B?Ky9iRGp0aHlqaE5IYXo4UUJkSlhNd01NRHVrSzczSUZqdHEzekZGZExjeW1l?= =?utf-8?B?bFhQZktnK1NKcjkxRGttcjFxci8rZlBSWXlLOTYwTlZIT3pmQ1RsZVN3eXhq?= =?utf-8?B?WVRsbm1Mc2pwcVo5SHg2VFdDOThlS2dVSU5JSU9kYWlPY3hTN1dLci9uTkdY?= =?utf-8?B?ZVJWbVQ0ZVRmdmtQa1l1YytRZDZQaUx2NWwwbFIrOFJHN0M4KzVrR2xLQnFo?= =?utf-8?B?OWZGZjVadkprNnVKRkVIRVFkZmtIVzV1S3YvQ0R0cEdMZHNqcjRZem1MbC9B?= =?utf-8?B?eitMNUlJWXBCM2UrTjJTc2dSWW5Tc1hyNXZpdU93MGNSVXFZVk0yTURLVHow?= =?utf-8?B?K0cwcnhiNmgxZU9UTXcyRVhwWE9KTWVDdEVlc0FZNFU1R2ZFV0ovenY0eDhI?= =?utf-8?B?ZVdSdDlkekhOM1RmS1JiZGlzeWs0Y050SVZiVDFZWnpaZk9UaFM5TEl2MFpH?= =?utf-8?B?TUlxUy9zSFdjTjlrR2JpREozRTdRYUN5NjFZbG1ZTm8rV1hFYks4bVZNSURx?= =?utf-8?B?aHJKNEpkSHMvK2xVUFc2TFp5WHpscThIS015UTdhUDB1WVlEaE81NE8ra2ls?= =?utf-8?B?S0ZMblBGdDgrR1ZwREhaMW9kMUZTNFNzV09tM3I2V1NuTit4N2ZVWE02Q2F5?= =?utf-8?B?UDNMK0w5L1RUblk2eFBMa3ZaRnc5UmRRTDlNMUl1UU5CQmk2d05EVkRXOXZH?= =?utf-8?B?L21WZmxOVnZRVXZsOFJnNXdOM09NR05TY2wzWjBkWnRydG9ld3c3UlZhZnVH?= =?utf-8?B?RE81NjZiK3g4NWR2TzBiWHoyOXJxREwyVXZ5MHU0N0xEVW9uQU1mclZ1ZGU0?= =?utf-8?Q?jTgeCTql+bmSUCm2oXRMQxeEb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98145a6d-9a3c-4299-1218-08db10b6c583 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 07:15:38.8569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uZA9Busv95SoEd+lLzV4bKXCRVZys0WG256pO32cZZuUtNRJziubjFRJy6R7uCN7oxKYe2tTlIPtsES2CvwIsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7356 On 17.02.2023 02:44, Stefano Stabellini wrote: > On Thu, 16 Feb 2023, Luca Fancellu wrote: >>> On 16 Feb 2023, at 08:19, Jan Beulich wrote: >>> On 16.02.2023 00:49, Stefano Stabellini wrote: >>>> On Wed, 15 Feb 2023, Julien Grall wrote: >>>>> On 14/02/2023 22:25, Stefano Stabellini wrote: >>>>>>> Patch 1's example has a "comment" field, which no entry makes use of. >>>>>>> Without that, how does it become clear _why_ a particular file is to >>>>>>> be excluded? The patch description here also doesn't provide any >>>>>>> justification ... >>>>>> >>>>>> It would be good to have a couple of pre-canned justifications as the >>>>>> reason for excluding one file could be different from the reason for >>>>>> excluding another file. Some of the reasons: >>>>> >>>>> I think the reasons should be ambiguous. This is ... >>>>> >>>>>> - imported from Linux >>>>> >>>>> ... the case here but... >>>>> >>>>> This reason is pretty clear to me but... >>>>> >>>>>> - too many false positives >>>>> >>>>> ... not here. What is too many? >>>>> >>>>>> That said, we don't necessarily need to know the exact reason for >>>>>> excluding one file to be able to start scanning xen with cppcheck >>>>>> automatically. If someone wants to remove a file from the exclude list >>>>>> in the future they just need to show that cppcheck does a good job at >>>>>> scanning the file and we can handle the number of violations. >>>>> >>>>> I disagree. A good reasoning from the start will be helpful to decide when we >>>>> can remove a file from the list. Furthermore, we need to set good example for >>>>> any new file we want to exclude. >>>>> >>>>> Furthermore, if we exclude some files, then it will be difficult for the >>>>> reviewers to know when they can be removed from the list. What if this is fine >>>>> with CPPCheck but not EClair (or any other)? >>>> >>>> Yes, the reason would help. In previous incarnations of this work, there >>>> was a request for detailed information on external files, such as: >>>> - where this file is coming from >>>> - if coming from Linux, which version of Linux >>>> - maintenance status >>>> - coding style >>>> >>>> But this is not what you are asking. You are only asking for a reason >>>> and "imported from Linux" would be good enough. Please correct me if I >>>> am wrong. >>> >>> I guess you mean s/would/could/. Personally I find "imported from Linux" >>> as an entirely unacceptable justification: Why would the origin of a file >>> matter on whether it has violations? Dealing with the violations may be >>> more cumbersome (because preferably the adjustments would go to the >>> original files first). Yet not dealing with them - especially if there >>> are many - reduces the benefit of the work we do quite a bit, because it >>> may leave much more work for downstreams to do to actually be able to do >>> any certification. That may go to the extent of questioning why we would >>> bother dealing with a few dozen violations if hundreds remain but are >>> hidden. > > Yes, we need to figure out a way to deal with these files. However, at > the moment they are getting in the way of easier low hanging fruits. > > One "easy" low hanging fruit is to use cppcheck to scan new patches for > new MISRA violations. That would give immediate benefits to the > community. It is not easy to "diff" results with cppcheck and in any > case it would help a lot if we had a cleaner baseline because it would > make it far easier to read the results and make sense of them. > > The goal of this exclusion list is to give us that: a cleaner baseline > so that we can make progress faster on low hanging fruits. This list is > not meant to be fixed and stay unchanged for a long time. In fact, it > could even live under automation/ as part of the gitlab-ci test that > triggers cppcheck, if we prefer. Okay, that sounds reasonable to me as an intermediate goal. But then description of the change and justifications should also state so imo (for the latter e.g. "from Linux, ignore for now"). Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 07:29:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 07:29:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496891.767826 (Exim 4.92) (envelope-from ) id 1pSvBB-000105-KX; Fri, 17 Feb 2023 07:29:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496891.767826; Fri, 17 Feb 2023 07:29:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvBB-0000zy-Hr; Fri, 17 Feb 2023 07:29:13 +0000 Received: by outflank-mailman (input) for mailman id 496891; Fri, 17 Feb 2023 07:29:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvBA-0000zs-KF for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 07:29:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7d00::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5a4717d-ae94-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 08:29:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8780.eurprd04.prod.outlook.com (2603:10a6:20b:40b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 07:29:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 07:29:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5a4717d-ae94-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAVIGJmDJCIyGngK+KAS+UZCyciUdSwk28TqPJfRaagE5gvVoasmxLDJoD6dG0tYZDZqSUeH7wAtSI7fdR5pGqjmmlYCqHenrTBg3hoAGYf7WuGGh/CFhepIwChPvR91U9ej0ZOwrT6DD6WDyWolrhPpuzSO3sY+xEea3dSUH5Co9fI4h6U0abBvNhZ4EdAuaalSVDvltoBmZE/hH8LnDA1396FwxW+CBzlKl1Xy7Qh69/JtJN3Wc0GndOWqbcbj67Rac+aqTgxHFZOTYbyh3kgtq1eA3XQtGxnzVyCHl7SMJ5jK3vaOVQIKMAVa0LQ2pQ0A/NZP400VPk+pduF22Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBqs4R9eKENvrHqWiCYRWjtxO1AdlHPNBVD2Vuf3rUg=; b=S4X3s/xm/guLlsQRPY1tjaVnfQcS9ILVhx3ilx7jBA147V0GDEO29wSPFIccu/W9lsInqhCWdJfnFrUXUQvozLQG7O5NNSkJzuJhZ2HrbNL2wMpa7m45Ng3ViYE690QYm9DqLEtyc+I916rYRJYccvL5iVLYhXf0e+eWfssbPR9HYIYV5bQKyLweMB9frDLOnsVaHN1J7kFijZw+TtlzOpXQcci3dgBVtBr/LAC7Ge/NN+Uv+Nf3pteoI7DAe9tozPQ5Oa1XhUrSBlWHND3fo1zIpQDuSIAfN2Md6t2MUrFKja+KJow6vdOZ0HFlNSSvL1v9+2zWkFa/7vuOSuTK1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBqs4R9eKENvrHqWiCYRWjtxO1AdlHPNBVD2Vuf3rUg=; b=vSKzDwVE10LNcC635YGzCzEaS/70VYbxSI9Bwfyf8KSV+pHoOkzhbFvbNr39o3Ff8DvPY6t6FFFudwY1PyMxzJezcUixbvyfx3tsF56P8ckvqNNO64zYBC6D7Y16CAkWw9L0f9LQ453K7ewW0N2LAlh4CBE+yb69pkJ8WN9A+maj4QrEBIkgPwRsOkRRVZMgGZXSl6UvJVEX7u8IPVk/wi8pKlUHNp2Zu/ErXB17rtgcR3jFcvtvekntpeQ1YCv43W2U65iRzKnKYsuSnoKGC5zdFeQeKWD4VxpZpC7Rmrs055UMxo9kP7RfqngCtwCYqkcpSyg2QCAgRDzp6tIZOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7ab0e5bb-f974-50f3-63dc-7c7a83df5425@suse.com> Date: Fri, 17 Feb 2023 08:29:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] xen: Remove the use of K&R functions Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230216224438.705395-1-andrew.cooper3@citrix.com> <65cd4fae-f6ad-1a2b-043f-665cb3903576@citrix.com> From: Jan Beulich In-Reply-To: <65cd4fae-f6ad-1a2b-043f-665cb3903576@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8780:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bb734db-724c-42ee-1c50-08db10b8a883 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vx2szvvpl0FYWBABKYbOAEKzU0YahAuz9HXByf5zVAypuwsupLp1Pv5bS6beG+MtigQmVYeDz1zW9AWcO8iXuPQn/k4mb1w5L1NsAufymEPnwfsa5xLU748gUps0BoK71I9XjcetuTNfU7onh1ixoraXjVZ2vPsYp+DJ0okeBnF9kQXze6r5tEw5Jsq2ml27Lm10bIkYFYSQ2zRR/TdLNkcj2bAIdMdxCJSdvy3t3BfCEADPmC4LZNETuXmCZJoViJ3Wi8/wJvf/JVA0940uTlTekkyjr2Xsw3j9p73NDZR5qOEhBKeek6SwiQBu5l+W3ayKzntxcb5Ku2NaxmSxHPd2OlbrHqqhtcdoQhwPKAI5hV/w0sjhI0nsHt/obv1T7ER7oxZiuXiepo44Aj0q+p4suqa3oRBigODjVqvc1N8Cy1hQC7TQqF5qGUVgGTejytQFzoCuGUI1Lpu+TstfI3ncat3AyUt5+8qKLt+kYiqTderc1gaDtwLz/TAmuBOsuja63VGtgNQWk7SFM9ZLMldNEgdugZIFejpKZ01cyOF39/kjSfkqV3Rb3bWVLwLxqAy8yWJYgsP5Pyl2juMtAt+XE1z7uDEreGdY/wIW0DyQlNRqzAg9MwIZfcx0jMWnsbLLHukDXJwdoDeNn/B19WVDfDzUn6ugCOCHtbI1HNdYOWbu8W5YWjhzafojcjHOtXHKhQ3y3YWMt9P7OmXQKoAgfPAdR61lVZjKlr3GmDA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(376002)(366004)(39860400002)(136003)(451199018)(5660300002)(66556008)(8936002)(54906003)(316002)(478600001)(6916009)(2906002)(4326008)(8676002)(66476007)(66946007)(41300700001)(36756003)(2616005)(38100700002)(83380400001)(31696002)(6506007)(6486002)(6512007)(186003)(26005)(53546011)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZXRWQ0S1J6Nk5JY01IZ3Jka3h3UmorY2F6ZHArbmF1MWNJbkF3S2p1enB3?= =?utf-8?B?YkNVMFdaZlZaTzJvWFZaaFFFemQwQnJ6aUE3UVFqR2pabUlaNFZJWTZQNnpu?= =?utf-8?B?bjJUeTdDQ0NmRVB6T1VwQS80VDBzWi9TSGU1RHora0pQYVZOUnVXV3ZZUDJi?= =?utf-8?B?V0RHNjNxclJPQ1VJbVdOTHpPcXlEb05TNVYxRzMyUkRHV1lZS3NxajBXUUpl?= =?utf-8?B?SlcwOVJFdXN2Nm80RTZabFdXNmhUQ1RpYXo1L0ZoUjdBRTFVMTE0Z1FZYmRH?= =?utf-8?B?WnRCdEI3VWpzeEZXQlpla2FHNnhrRHRDZ0xkVG1QbmRQQUJFTVRKQm4xQVZ2?= =?utf-8?B?WWlWVmRackswV2psa1pBQzR0OUJ2QVI1MmhLTWpDaGRZRDY2Rk1Cc0xVTmtw?= =?utf-8?B?S2tyejRja2hRRkZTKzVZOE9GS1JJeEtVM1JSTkpUMXhFandMeFhoYjNFNWJk?= =?utf-8?B?YVU2alBEeXhyUlVzUVV6MEZMWk9ha1FLcGVZNFJsb2xLVnZEK2hjRGR3WklD?= =?utf-8?B?eHVQSWo3Y1lVMXl1YW1jOTdBK0JYZ2U2UUJvVTQwS0F4OFlrRk5JU3BGd1RL?= =?utf-8?B?ZiszZEFaUnRER3ZMYlVKOVl4ZUx2YVFONXNHVWswNG82aTBUT3FpbCtUUXhZ?= =?utf-8?B?YmdWSUZtWHVQc0VGMUhyaDZXdUxsaksrT1Qrb3pFUzVIUGw1TzByUGZ3ajdQ?= =?utf-8?B?Zk9xL2xncmZPZXI4dkUvRm1VN0pvRnRuby8rT2h6S1ZWVHBsNDR4aWNzQndQ?= =?utf-8?B?UHpjc0lLb09PVXpEZkJLcjJXQmVzR3JoWjdMajBSVGd1a1BubkFiOVZTNVRm?= =?utf-8?B?WUZLYmI0S2w0MlBSSkMyRVpLWHJvRXZnd1Jjajhaejl3em4ybVRaV3l4YVU4?= =?utf-8?B?aW1xQWpKckZ2cFpwNHJDMjNHa2lrRlArVzRPT2N2eUpweFRwcDhKa2c4YVFN?= =?utf-8?B?QjZDYnlxWG50Zmg0RFR1VUxpZHdtYjQ3cWV5TEE2WXBMZWhYa2RMdjN1QWFP?= =?utf-8?B?eGRoQmNqSFF2ditXOHN1MmpzQmJsZDc1VGhzWnlvb00zK1Rwdlk4YUFMbXFw?= =?utf-8?B?NTJPcy9uUE8vc2ZnZTBmWTRQc2ExZCtJN0oveVRJbEtIcW5VNVlMTDFYTTlT?= =?utf-8?B?R1Bpekc0RFNOQ1BoYTJPdXJaTnAyVHJVbENpMnBiZCsyMlRoblZrNlBDWGY2?= =?utf-8?B?aWFTdmJJTmZhUExWN21sWGhwbW5FbHVxNm5TekxQNjd6KzBNcnN0c0kwM09n?= =?utf-8?B?MFJreHZYUzBmNGIrVlk2NWZjUXY4dTc4TE9vNXFXM2NwTDBrM3NzYjUrZUZh?= =?utf-8?B?WGN1Z2pzNG9PbnFMc2ZITjFNVG1KQ2ZXb09yS3lLMVN6Y3oxeWhWYjg4Q2lY?= =?utf-8?B?UUdoeGNWUEVudktnblQraW1DR3NjU2F2VUtZdmtRbzY5VU5BWlJITHNqM0hr?= =?utf-8?B?R29KdTNjeE9mZUpOM1BScGRRU1ZRWmduSmhPRUFyeGdHZkhwa29JQng4ZDVK?= =?utf-8?B?QVB2UnJsNzlKK090eUdiU08raUZURzBkZUN3Rko1TU5QdTdxMzI2bHdzVzZh?= =?utf-8?B?a2xPMmpleURja2lJRUlEMGFDOTE4cHZuZER6UVRqb0hZeWlaZkdwMHkrbWlU?= =?utf-8?B?dkFmNkFIcTlQM3hXdFhBKytUYmMxb2tBYXFWd0tqN3crWjNwNVJodER0T0Nn?= =?utf-8?B?RE96NThZZW9sa2FyL0c0Sk9uZktwMUJDNzhnQnJDcTBHMkx3b2pNaTlIOVJj?= =?utf-8?B?MTFFUmFjYXUvWmgzU1Yva0dFczE3SlFHYjNWLzBOWjlpRUk4aXdHZVpzYjd2?= =?utf-8?B?bnZZNXV4YithcmRjcFhsQ3JOYldYRDA2SDF3eVIvWlVUQVdqK1p1UGMwRFRP?= =?utf-8?B?MmxvMk5iQ2dKNGtSWFU2RWZMa3NsNmxBTW1XNUwwSXF0WTJxeEJZeWdFaVR3?= =?utf-8?B?OHdGZkdKaGdyVmh6aFdKc1E0ZUdVNWovcUFmNWFYSGJObE0vdlMyNUZOU2o3?= =?utf-8?B?cTY4emoyZ1ZjM1JGdmdTV2phOFdpQ3VwTU11UHkvOTVVbjFGRTc3cEJMTVhF?= =?utf-8?B?a2ZmMys0TzhnVGNBQU1tMWEwZzZCYy8yZUlrbExaMXR4N1Q1TnJMbW9MVHJJ?= =?utf-8?Q?PdgR++gEAKUAzWve6AmAdcfd3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb734db-724c-42ee-1c50-08db10b8a883 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 07:29:09.2123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mKR5/TD0C7jbJdLcPKTN51iUX1T4Tq3bdgDE2MBvfy0Y0xnkpQG9Gd7UrTOrQDgq2g01oOXzYG8Sl8nwJIUQ9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8780 On 17.02.2023 00:17, Andrew Cooper wrote: > On 16/02/2023 11:02 pm, Andrew Cooper wrote: >> On 16/02/2023 10:44 pm, Andrew Cooper wrote: >>> Clang-15 (as seen in the FreeBSD 14 tests) complains: >>> >>> arch/x86/time.c:1364:20: error: a function declaration without a >>> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] >>> s_time_t get_s_time() >>> ^ >>> void >>> >>> The error message is a bit confusing but appears to new as part of >>> -Wdeprecated-non-prototype which is part of supporting C2x which formally >>> removes K&R syntax. >>> >>> Either way, fix the offending functions. >>> >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: Roger Pau Monné >>> CC: Wei Liu >>> >>> These are all the examples found in a default build of Xen. I'm still finding >>> toolstack violations. >> Apparently not.  int cf_check vmx_cpu_up() too. > > Ok, finally got a clean Clang-15 build.  I've folded this hunk into the > patch: > > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index 09edbd23b399..e1c268789e7e 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -781,7 +781,7 @@ static int _vmx_cpu_up(bool bsp) >      return 0; >  } >   > -int cf_check vmx_cpu_up() > +int cf_check vmx_cpu_up(void) >  { >      return _vmx_cpu_up(false); >  } > > > but am not intending to send a v2 given how trivial it is. Sure. Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 07:39:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 07:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496897.767837 (Exim 4.92) (envelope-from ) id 1pSvL8-0002rx-JZ; Fri, 17 Feb 2023 07:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496897.767837; Fri, 17 Feb 2023 07:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvL8-0002rq-G6; Fri, 17 Feb 2023 07:39:30 +0000 Received: by outflank-mailman (input) for mailman id 496897; Fri, 17 Feb 2023 07:39:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvL7-0002rk-F5 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 07:39:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0611.outbound.protection.outlook.com [2a01:111:f400:fe0e::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3537239e-ae96-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 08:39:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9644.eurprd04.prod.outlook.com (2603:10a6:102:242::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Fri, 17 Feb 2023 07:39:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 07:39:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3537239e-ae96-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ml9aIFRZw3pTJL2NrhAduroM9qMr1COUdOvdJJ+1SpLi2ZKYdcozSZjE1A/PO21tuiyGhZ2lVMmBotyA1Fc3IK5huJcs91xdUttj+RO/c4lqzFCIblg0gFtji7HP/CLSAMyr/Ku6MGfVsOQLccObjNmxIsJtRaW27SoZTnumSwa/SxCiHlBmcU1LAuCJNbuPlJRBE/V6MrX9qM+7emR7QyQHxWKH2URPc9+BiH8UkOl8To5zOzCBMVrYHzGJnCbV5VsBVgkGmLYQAMzG7Tpwvw7f/Dqc1T7XIkqG8RvKEfuSY6ybmAdlX29nBPkGH3iuzGpj+wjQOAXI1mydOnHaVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vbg/P1bEEq+4IDR//iZ/hp61aCx0MKgYlmu4RpC9bWw=; b=hxs3irqWbna6ToMewCDB+xp+eSnxylP7+6eBMRJNzZc54hW4pK+l9J9vlohNnILb7uad4iTeTTTgSgLq1tOKcB3ujCZI5rvK1PskoLIo4gPz+EA0Cx0SProLsJVzQOPIERZ3Z8zHTzmkHe4wcyvTwYSXg5QWuhgZlzi3X9KBgzUZIq3lRjG6rzd/Z3P3cEDEwsUzqkdQPrjpXzO+cOibb3fefmwJeE2Xjy/tu33cr6wgsUOEdZQr31ZEU9Uv2uO/KqSvxCqKeHRCv6YS++t262NIW4QgZgjelN7IzWaDsrelLcpeiG6YpbJ9WiA05UTp0kk34mC1cTy9uclY3othjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vbg/P1bEEq+4IDR//iZ/hp61aCx0MKgYlmu4RpC9bWw=; b=DzPbMIhZ4Z3jT9906CHETVYl7jvts6iv1AG3t4GjFL60wcUcZyqnbSM+0uXrUXUTJOqdHeaqo8PmTuubiCHBuPi/5PtYLaevC8A1agi5Oh//t/28lQgR4Dj7n1r6yGh5f4F1ExWa0zwxgmc+UUZnCjBvAdL0o3229rvGhVIAyObMFfTu+QYf77O0YxdyDlvZUM4kBTeqRo0dlc1JGM7vGsVjR3/jfb0sF4h3JWAIWblcC3uUzJTyyMNifE4I9xLlIbJVybTKNP9A7Uqpu38RbhZedBTHjF2qltFGrPvR1d9UttUTbGg7e9HBGQSmnYi3tyVBoVxF3vYEb2ziyeczuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <92e8645c-d0d3-ea1c-1e69-04fc98a1bafe@suse.com> Date: Fri, 17 Feb 2023 08:39:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH 03/10] xen: pci: introduce ats_list_lock Content-Language: en-US To: Volodymyr Babchuk Cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-4-volodymyr_babchuk@epam.com> <97112cd2-d16e-6c9d-7c3d-a3fe5ab76125@suse.com> <875yc12ile.fsf@epam.com> From: Jan Beulich In-Reply-To: <875yc12ile.fsf@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9644:EE_ X-MS-Office365-Filtering-Correlation-Id: 63370a3a-94e5-4d17-983e-08db10ba186f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iR+jh17ON0gq+GNvjfXq1xC5s1O0Rg43CpeVMpPJjajcGRGjXENUF3mpoiC9G3K/XHDua68TBNq1MhKsynoUaadfzsmmJeDUCgRQmpfKmnC1jVE8umR8JEdUMAPX8usovY7MKNvvnqLBWFhwIJC5/AtBb01aGkWq3BIRCh5Va75e5GGhwJgOhxUGGvAYvj26jWVNZ9qZZlG7ZtFGnBiMhywqcBeScLvfCPw9n2WDjHF/OiD3CCBfwtCe67lVTHQYOEz/bAhYgewXan/1BvAua5XAtetqV0MCjsrWFsRuRzQXK0unbjFZOUJMpaXMAQtKYWbl1eXJeJYs4nwK8Hw049j8YmdWR94ZtxLkGWdTfYG/Ol753+UdIkox30jXmiHGTkQ6VcaU/5FYRnG8/mRRQlfzTtmyzIwxxPMs5UlklBqtFkuzPBUxVOxB3P00LtPwVUkxs6huPF7P2yX7E42JMbSLqdn7WNvCIyz3ffL0Hv/FWnkrbi+0z9NmUSATk4GHDE7UDbqkCJ56ioTokAd5CT0LhVxCR2FkEqvnJX2YooGFdymkfDXuGW1qdVoh7pflLjMZOuQRe5OJMRCw4J399fHl0kzt8kuXGf9XJu41m2SO6zB2hatL7FhaBTTUa41R7BXHZpgZf3GuO1/lh0X/WhcUKFmFQQ9MXDugQinosn0xIKmJtcu5MCJmBph+4Z+HuDK9EhWeUpuwWlYEkmDJzl9PUiqJ5U346II5udBk8no= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(39860400002)(376002)(396003)(136003)(451199018)(86362001)(36756003)(31696002)(31686004)(316002)(83380400001)(66476007)(6666004)(6506007)(6486002)(54906003)(66556008)(186003)(53546011)(6512007)(2616005)(26005)(478600001)(66946007)(38100700002)(8936002)(5660300002)(4326008)(8676002)(41300700001)(6916009)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUdManlWRHRBY1pjM3ZzYngxMzVFZUVZNWtHdjZ4OXdUUmVBWjdWN1pHRi93?= =?utf-8?B?Y056WlRxLy8wSmtHeXE5c1E4cWN2MDM1Z3JWWjhWWnRad04wWHlkaWN3OEFX?= =?utf-8?B?Rk9uSndpTzhtZVorTUUrOE9hbm0yd2wydVdkU2FOQlA4OWlFTGVVMzNpVHIv?= =?utf-8?B?SEFRSWZ0MjBpTFZDZmtxWlAxbXlIV0t4L2lUVFJvRlRUSlpwbjNKUDhkS2Js?= =?utf-8?B?S3c2bkhFaDhyTktkY0Q1cHZ1R216aUNJWkxxazFNaE9XdFplZkpEakdlcXhp?= =?utf-8?B?cEJqb0FDaEd3RktPc1RITzI4Y2RnTHBXcDNheEttYXNPeVpzK0gwVmY5S2JQ?= =?utf-8?B?MEJ3clQ4eFljLzNYbHc5RzhXN1Rramo3K1VsRlN3c1NSUzhsckd6bGZUaFhW?= =?utf-8?B?MVNldFFpN0VjZ2dhU2xuY21hK0ZTdXBHZURHYWxXdFBwK0tVemtHTXh2ZTlD?= =?utf-8?B?YktTL044aXlSWlFNTDJDL0t3dHJ3ekorS1VqMk5uWE5QQWdtb2c3T0tYRkY0?= =?utf-8?B?T0p6MlRpL2pLWDF6K0JUMmNhd0RxSE40UU9ISmRSdksxTlNaQmZ0QlhieTBz?= =?utf-8?B?L043ZTcvd2NWZFhGeWdkdlpSM21uT3IycU4rTXZsM0d4Y3AxMUt3MEx3Ui81?= =?utf-8?B?VUZJK1pBSFpQUzJBWkJsaVUwL21DamFpQU5XRFFKOFJmRjJuK2NuQXZwdE5S?= =?utf-8?B?UjBzdlY3WHBvMkoycWJpNVp5VHp0UGYvMWR1ZUp1N2gyZXpOUjFIa244SnRV?= =?utf-8?B?eElkL1BQN2lUTU11SVBnNnJpM0RIZWFLMFlpYWdVamlnY1pxUGU5UXk5YkUz?= =?utf-8?B?UGdiSG5GandkeFFQVWVpLzczNzlBbDNaTXdaYm1OS2tqNHNqajA1UnRxWDBR?= =?utf-8?B?QTE3UVc3SmI2UVNxaUNaSDhuYnhncHcwL2ppT0V1OTdpU2JVK0VQWjUyd0lh?= =?utf-8?B?L01INXNFYm1tUm1LclBVcDRaL2EwaktrR1JSTjNUMFVYR0NKdlh6cVRWZngv?= =?utf-8?B?bGsyMFdXU2I4dUVwdTlMNmphSktvSzRFbko1MkZMeFhvSjR0ajVyODlMTlhL?= =?utf-8?B?ZmZlT2kzUlcwQ25BMjRCVjZPMmFCZEZQWmczUUF3b0FNVXVuakw3TEtSNVQv?= =?utf-8?B?Zm9QQTErWnVhUnFodENnU25JUnFZRWl2OUFqSHdSV3FVOG4wTjNHaWgwdVBE?= =?utf-8?B?Rkx6dzJXeEVFcFBrM2t1b2FxZy8rVHdJSUx0ZGI5cUd6b1k3UGxVQ1dUTjNY?= =?utf-8?B?c2xzZzFvdEsvVlZSL0NSZEFJT0d5anhKQy9tZFZFcGxGZnFkY0N0VlJBN1RM?= =?utf-8?B?emVZQzZRN21lRS9FZG5wRlJadTZaYjNPdXFnRDdTMHp5U1IxbS85eWc2akdu?= =?utf-8?B?bDFxWDhUdGJDWEIvdysvNjQ2OFliQmF3TTdsVmRVdjRmSVR2cDNrL0tkWjA2?= =?utf-8?B?UVVRRjQ1NnJOQzdKM2NWcm1FbTEvS0hnMmRYTlJBRnlJTlZtazhncVRWM081?= =?utf-8?B?MFZXdE81bU5CRk41QjBoL1FhbTRZb3EvdkR6YTVlUzIwMllrcjB5MGhZRVJ1?= =?utf-8?B?aE1VZzhuRHp6NGhuWFhvc0F6dWttdFN0dGhlSE90MlJJbXVhNzR2RnQrNGZu?= =?utf-8?B?SGg0R3F2bUdxaVpmS1Z3YURBMVdLbjZuR2p6SUVlczRRU3hpVURiWDhMSEVw?= =?utf-8?B?Y3hmNDZaR2UzbTZrWi9Ja05pa3U0MFRuNE00clEwaXR0VHpwSjk5OGNKcndj?= =?utf-8?B?RUFxK05HNnNBWkYrYzcxdGRmWldmMXNMQmRyYWFERXJlVlNOb3lPVjNIYWtZ?= =?utf-8?B?b2p5ZXM2WkxtVlljU1dESmVnRkN1cjVQNzZKekNEb1FPb1RlRlNCZnQyT1RY?= =?utf-8?B?RG5BV1pqVzM4YTAvbnkzOVNlMFdSRC9saFFqTWJFNFNKeDRITUtwZmpGaWJ5?= =?utf-8?B?ZkUyenMvQXF2WXViQzE5NXNROHlVSGZzTXEzUnJFakpURDRJK3JrUnUwRWln?= =?utf-8?B?T0tnYys0b0NycDQwQk95eVZYcXg3WFRVb21RNEtkSFpRcHZNNWtpVmhkcjFP?= =?utf-8?B?NXJWOTJIUW9FVnFHT3FheUlxVEt1NGNaK1oxWW5QN3FXNXBzRnh5L0pnbHAx?= =?utf-8?Q?JOIJD9ZB3duAiKKuF8UuRx56G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63370a3a-94e5-4d17-983e-08db10ba186f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 07:39:26.4860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bQg/Gwe3vUfd5PgPfWVBxaJ5i7O2dL4Nj4iZJA/KSud3se6MzjWD+B16+9Dr/91nq+3KpLnk60UBUnZrXmb9Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9644 On 17.02.2023 02:20, Volodymyr Babchuk wrote: > Jan Beulich writes: >> On 27.01.2023 00:56, Stefano Stabellini wrote: >>> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >>>> --- a/xen/drivers/passthrough/pci.c >>>> +++ b/xen/drivers/passthrough/pci.c >>>> @@ -1641,6 +1641,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev) >>>> { >>>> pcidevs_lock(); >>>> >>>> + /* iommu->ats_list_lock is taken by the caller of this function */ >>> >>> This is a locking inversion. In all other places we take pcidevs_lock >>> first, then ats_list_lock lock. For instance look at >>> xen/drivers/passthrough/pci.c:deassign_device that is called with >>> pcidevs_locked and then calls iommu_call(... reassign_device ...) which >>> ends up taking ats_list_lock. >>> >>> This is the only exception. I think we need to move the >>> spin_lock(ats_list_lock) from qinval.c to here. >> >> First question here is what the lock is meant to protect: Just the list, >> or also the ATS state change (i.e. serializing enable and disable against >> one another). In the latter case the lock also wants naming differently. > > My intention was to protect list only. But I believe you are right and > we should protect the whole state. I'll rename the lock to ats_lock. > >> Second question is who is to acquire the lock. Why isn't this done _in_ >> {en,dis}able_ats_device() themselves? That would then allow to further >> reduce the locked range, because at least the pci_find_ext_capability() >> call and the final logging can occur without the lock held. > > You are right, I'll extended {en,dis}able_ats_device() API to pass > pointer to the lock. Hmm, that'll make for an odd interface. I was wondering in the past already why we don't have a backref from the PCI dev to its controlling IOMMU (might be ambiguous and hence better left unset for bridges, especially host ones, but I think ATS is being fiddled with only for leaf devices; would need double checking of course). Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 07:53:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 07:53:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496902.767848 (Exim 4.92) (envelope-from ) id 1pSvYQ-0005bB-Pb; Fri, 17 Feb 2023 07:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496902.767848; Fri, 17 Feb 2023 07:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvYQ-0005b4-My; Fri, 17 Feb 2023 07:53:14 +0000 Received: by outflank-mailman (input) for mailman id 496902; Fri, 17 Feb 2023 07:53:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSvYP-0005av-0V for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 07:53:13 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061e.outbound.protection.outlook.com [2a01:111:f400:fe13::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1fd11e3c-ae98-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 08:53:11 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8603.eurprd04.prod.outlook.com (2603:10a6:20b:43a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Fri, 17 Feb 2023 07:53:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 07:53:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fd11e3c-ae98-11ed-933c-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQoOhhLbqxEwsD5/5NX3ZNGUuFBUs5ZyXrgME132Vs1Zk0KBh0LmI2f6wPFSRS3VsrkaPz3ro1n7jyXA/wJ8lMkmDhP2z0K5CMdV7uLafzQkyZDDm6gvVQqYFxS/fx86zge4bewObfQa1OT4e7rbGWGufOxm6yt3A/zjYP2K7qOpX7Ho24beIRUelm2jwVLtsZH6nCEkgs+uKy9ti04efcUh/YElCVtuvRrAKmZZH3AOEq1Xyn/pGwsf/zpvJJKxg/Z7AfKvXblYsAFFHUnyaur9iScF7B4aquPP7XtcNkdtpHQ+6xKj+0n1wABA7jzq+G0wayrnzi+2IgnbYikiTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arogZoH9g4HsyoAMGee3yi/Weu0VkkttF4C+Sr9ylgs=; b=mYu0aT5tI+hVs9Frs8HjEv6n6I9F8rz/RaoLU2sCFFMJiTWX6VqgrSLBm2nDlu6rZjLHUa7XugxXxvoBpKiu2SgXIzkYFKxLEpbboGmN/JtKhcdIBD5tL0uPjp4hfKXFE980nZlov/lJ+PH4oNJkmdsyV7XEVkYEkFeoltx4UtmDveHgMMOqf3TNiZvlpUevPB+uXPcvNEa1DGV6aZyFCdApfYq0Bbh5Oa3FxYpmM+EqJDpOOnhjPEuDmM3jUDzZpeVSN6Jr++iOV2aPrWdu6P8e4p6I1XYO+4Vl0wL9exTla1GjowoDjsjbyl8m+WWRECvzXsyO+AXgeR9Ta6b0CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=arogZoH9g4HsyoAMGee3yi/Weu0VkkttF4C+Sr9ylgs=; b=ipBQFZ4kH2hiuMUMHCrplkumDzzsH0c3YGSWZnvXrujHnuFx6OOkDmoTy2xuI31nuI1VUumh0tc36VrB9w05ZdEYPkmKArenGdNWZa5kRvPiBEWndBOojM2OcE/sUFX0h2/KPd6gL9PBsw8DOqKXnPcCShP7b+VsWn9Sny1XLBRCfetZ2G6aKQQjGREy3lhUV6u+9q65HVMCMOinXwQRlwQobcK3W5wsz/YuQxWFhsQ5xzfg/gLXTI7xqFT2EOe7cVZPy49RXGPiky9hD3Z6UvuXwSuu+hNpZ1KoMyPqs/1yu/x3maKDZiFYAkbCF6i2i+k77mEdBByWo3UmxT6wQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0bbbb1c7-bc05-a28e-6573-6bfc5bb0ad28@suse.com> Date: Fri, 17 Feb 2023 08:53:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH 04/10] xen: add reference counter support Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-5-volodymyr_babchuk@epam.com> <87sff512d2.fsf@epam.com> From: Jan Beulich In-Reply-To: <87sff512d2.fsf@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8603:EE_ X-MS-Office365-Filtering-Correlation-Id: cb5bcbcb-2dc9-4482-abd8-08db10bc030d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7+qQC3QfyrthFBnT2qyCxQxLBDcsLcr7U5BLa13GJpxdFo1IfRo+uhermYw0B8LV8MIj9s7VvCLpzqpL0LajwMHdGrF4wRi3pzMgN5wzuxF/Hnu3DsE9ORoO+r4XnS+gDrhRFslV2LSko9nbC/khMzf5tOAJwQ5/pP+jybbf5d72tRpg5z9g307vkOVSBaW8GX7qy4TmurI5UKRLaq/m6r+let7oikC27oHhteHIWD21WtjUCpcFbQWwXetBgyvAgFwjdy3E38YBKrCIkzOFkbTQ0tdByuR+KkJcXite5oIbnn9/Tl8yDX/YAIJTIMURBgkLk3lKbpJ2xdfNJp6IG+rZLDnMUSPNNAlhcekqjXl/6Or0aDqfdvyNcw0j20dWUJNi3vqXpz2LtG5sdnT+f+UCf54fpJgbvKrzlvTeuXODQmvLkx7rInNPTmbI4BmP/XKu6sg6ssnNUghDpM2pyWZ9HnyEGzcgWlZDIeL5RqhSWD3NjeXg8uesi2JsRkc/pZry1B06HMubkHVI3Zb6tatAhZLgPTZbQW4eps2epyhbqXu5wOSUDIyb3pVdUMDmlpz38Tsu+veGRUPpZhcHi/8QH+mxz8LE38WYy980xw/K0crXU0WDCM70yFjbVMZNmBiqrZhTsYQjsP7DAyKB4mxnEQjH7UczqIqvR/iixQ4j/9l6zYuzQTHtEyVYqrL8k4rMLP4zwCyZHXYnw63hh8vVVCUo0caZMd7fIDbAGPw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199018)(66899018)(31686004)(36756003)(6916009)(66476007)(8676002)(2906002)(8936002)(66946007)(66556008)(5660300002)(4326008)(38100700002)(86362001)(31696002)(6506007)(478600001)(6486002)(316002)(54906003)(41300700001)(83380400001)(26005)(186003)(53546011)(6512007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1B0cjF5ckd4clN6SlpjUGthSTdUTFlIU0VvY3lhRmh5czhFQlNmdjZZNm12?= =?utf-8?B?NFp4d3A2UGYzM20zZitwQnlxUjkvbjMvVjhmaWxBNW40NEc5UEp6Ni9ZUU5n?= =?utf-8?B?aGgyRElndTdhVXo4OVFNRkJxWWpFNU1HcExQMnc4a2lNQkJPVnR6Ri9uUHls?= =?utf-8?B?OWUxY0x0UjBBZ1NTbEdmRUMwU3lCQnQrZU5DNmszR3YveFNmQlFsMVRZbHN4?= =?utf-8?B?R2twMHdtbk1STW5YZ2dzUy9QclZzSDlMSndJekpkMWdubHU4eWFLN3JlVi8y?= =?utf-8?B?ZDAyeEQ4bGpaOHhRSlUyaVBhbWRmU29xM2VQZjJhUVN6dDBTTUxyMXBwTnAw?= =?utf-8?B?RHV1K1NpekhEcXdkeWdWWTgwRlZ6K0h4R1Q3K3p4TXlUMDhOdkhWQmZZOTcw?= =?utf-8?B?QzE3YkVzVmVzZW14M055Ukx6NFlqaTVjZ3FSaFlVSjlaQ2RjNnF4VVJQZHcz?= =?utf-8?B?NmU2MnpyZ2tscXNYYzhQcWNPQXJYWEVQMEtQUTRTMmFNbXVNZExkZDRYb3lo?= =?utf-8?B?VG0rV0JtSGpLRGl4Q1RHNWdVbjdCdnAzeTlDdEFyMlN3WFNiY1R5QmtLcjhY?= =?utf-8?B?bjRtN3hBQUlqQ3kwVEtMelh3NElzRVBLOXFYOTNtNDFPcmk0MmRzWkduNGZX?= =?utf-8?B?SWR2UkZyaDVGV3ZBcEZkMHE2THZrVjkzcW10VW9EMHdSRmdmS3l2UStRa0pR?= =?utf-8?B?QjJJclZsUmNCdFlDbnZ5R1cyMlBLRTZsMHdpVUM3VC9PbXVrWXNGWlltaWpq?= =?utf-8?B?Y1NyR1QrMWZ1V0lZUTk0NTdyMXNqQ1dDU1p5eWJzWWVDVGt2c3A1Ly8yVFFQ?= =?utf-8?B?b2ErcUl4NnBzdGxBZjlzekQyT2pITzFTSm1xV0w5VG53TitBMHdpc0E2aytn?= =?utf-8?B?czYzS1dodE5pUy83VFVXSi9WOHNnWmd1RytUT2x4UDFpampNTlJFODNaWWUw?= =?utf-8?B?KzFOOTRtTVpSWWhEVThQaVhERFVwT3JCK0dVMGFURkFva3kvcFEwdThYMVd0?= =?utf-8?B?RGNJTW1VZVpDMXZiN0xxME5lYUVCWDFxZUhlQlJ4bjY3VURLeGE5S1ZZRHZD?= =?utf-8?B?MCtsVVFOY05VUURxOUxXbkh3Y0dHdWl0VXBKMlh1R012cFViMVZiTmVoUFZM?= =?utf-8?B?WXFFL0w5OXBLMGcrdHB4Nmp5b0xGTWlCMzJNYkRZa2FoaFZkcWZQdEliN3Bh?= =?utf-8?B?SzQ1MXF6c2o1S2lSb1BVVjBuVFd3QVRaL2NYVFJ6RGFuTmgwdTBFT01SeFYx?= =?utf-8?B?T05hRG5zRlBLeHVvenhqK2FTSExMWUtML1REU3lWSU1wRi9keFdzTlQ5VjBN?= =?utf-8?B?cnRyK2hlYWo5cDdVNkk2bGJGZUJLVzR6V1N6ak1CZnNzWXg4bUIrREExRGFX?= =?utf-8?B?ZHp6eTVpdXlmajZCeE9YZnA3RDBIbFhvam9zMUEweE5ORk4ybytremxPL0pz?= =?utf-8?B?dkpSY09rc09VZVZJcVpNT3lrMEFCNkZ5RDIxNndneDJUVVZPVC9sbmQyREU5?= =?utf-8?B?MTRqSnp5UGJSTjNXUUM5UFkxVXRTK1ppeTRVdlZTZDRqdWVudVhXdDN2VS9o?= =?utf-8?B?dzBjNysweFdSYkZpUDl0STJBN0NsYXhoWDljblBOOEhHRW9nTWpqTE9EVEZk?= =?utf-8?B?bkIybXdPU01mZDl5NmI3UzR6VlJGN3hNaE1yV2pQcUlkNDRBTThEWEg1L0VR?= =?utf-8?B?ci9Ua3lKVXhtaWh4N2Z2ZmREa0FuYWY4OE5HSW54U1ZtcDY5N0VqRnlqWjFM?= =?utf-8?B?OGV2K0dHZVpDUGlVMlJGZnY5dXlJdSs2S2xOTTVBeWc4QTlLbXV0aERCN0Z4?= =?utf-8?B?aVNWQkVjU1czeklONElhbCs0WHdTenlpR2hoOHFSZUxCMEhmYjh5YUNNVi9C?= =?utf-8?B?QmVHTllDQytDYXkrU2tCam9jZ0Z6UHZlcjJVY1VuaEJ2N3BaajRiV1lTSDZ1?= =?utf-8?B?RXcrVFlMMWE1a2ZYL1ZRYTcwU2x4SXpDd0FOT3FJa1dENUg0TFJ6a0hFMlNh?= =?utf-8?B?ZjBrb2o1THBWVEtEbUdPNzFXbDFyNFBiSEhuRFQrVk1vcjZTVDZ6MlFWTG5s?= =?utf-8?B?dVVMK3EvV3JvOHd0clowOUM3Y1VxaGVZNktsdTJuTXRZbzVxaDB4djBWZFdL?= =?utf-8?Q?y+6uMberU7DUqcE1/7s9Au3z7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb5bcbcb-2dc9-4482-abd8-08db10bc030d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 07:53:09.5430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JRK2VoNMGoOF+7Los39vLiARyLuVuIX/XjI3w3SpVgOGMahsAGURCl+o0YO+hUkhMLlc2reD0+N5vT5yfTmgHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8603 On 17.02.2023 02:56, Volodymyr Babchuk wrote: > Jan Beulich writes: >> On 31.08.2022 16:10, Volodymyr Babchuk wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/refcnt.h >>> @@ -0,0 +1,28 @@ >>> +#ifndef __XEN_REFCNT_H__ >>> +#define __XEN_REFCNT_H__ >>> + >>> +#include >>> + >>> +typedef atomic_t refcnt_t; >> >> Like Linux has it, I think this would better be a separate struct. At >> least in debug builds, i.e. it could certainly use typesafe.h if that >> ended up to be a good fit (which I'm not sure it would, so this is >> merely a thought). > > Sadly, TYPE_SAFE does not support pointers. e.g I can't get pointer to > an encapsulated value which is also passed as a pointer. I can expand > TYPE_SAFE with $FOO_x_ptr(): > > static inline _type *_name##_x_ptr(_name##_t *n) { &return n->_name; } > > or make custom encapsulation in refcnt.h. Which one you prefer? First of all, as said - typesafe.h may not be a good fit. And then the helper you suggest looks to be UB if the passed in pointer was to an array rather than a singular object, so having something like that in a very generic piece of infrastructure is inappropriate anyway. >>> +static inline void refcnt_init(refcnt_t *refcnt) >>> +{ >>> + atomic_set(refcnt, 1); >>> +} >>> + >>> +static inline void refcnt_get(refcnt_t *refcnt) >>> +{ >>> +#ifndef NDEBUG >>> + ASSERT(atomic_add_unless(refcnt, 1, 0) > 0); >>> +#else >>> + atomic_add_unless(refcnt, 1, 0); >>> +#endif >>> +} > >> I think this wants doing without any #ifdef-ary, e.g. >> >> static inline void refcnt_get(refcnt_t *refcnt) >> { >> int ret = atomic_add_unless(refcnt, 1, 0); >> >> ASSERT(ret > 0); >> } >> > > Thanks, did as you suggested. I was afraid that compiler would complain > about unused ret in non-debug builds. > >> I wonder though whether certain callers may not want to instead know >> whether a refcount was successfully obtained, i.e. whether instead of >> asserting here you don't want to return a boolean success indicator, >> which callers then would deal with (either by asserting or by suitably >> handling the case). See get_page() and page_get_owner_and_reference() >> for similar behavior we have (and use) already. > > For now there are no such callers, so I don't want to implement unused > functionality. But, if you prefer this way, I'll do this. Well, I can see your point about unused functionality. That needs to be weighed against this being a pretty basic piece of infrastructure, which may want using elsewhere as well. Such re-use would then better not trigger touching all the code which already uses it (in principle the domain ref counting might be able to re-use it, for example, but there's that DOMAIN_DESTROYED special case which may require it to continue to have a custom implementation). What you may want to do is check Linux'es equivalent. Depending on how close ours is going to be, using the same naming may also want considering. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 08:50:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 08:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496943.767859 (Exim 4.92) (envelope-from ) id 1pSwRb-0006At-IL; Fri, 17 Feb 2023 08:50:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496943.767859; Fri, 17 Feb 2023 08:50:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSwRb-0006Am-Ff; Fri, 17 Feb 2023 08:50:15 +0000 Received: by outflank-mailman (input) for mailman id 496943; Fri, 17 Feb 2023 08:50:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSwRZ-00069B-Uf for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 08:50:14 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15c59004-aea0-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 09:50:10 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id z12-20020a1c4c0c000000b003e21e018039so1891501wmf.3 for ; Fri, 17 Feb 2023 00:50:10 -0800 (PST) Received: from horizon ([2a01:e0a:257:8c60:48e5:bfa:d652:b8ef]) by smtp.gmail.com with ESMTPSA id y25-20020a1c4b19000000b003dc4480df80sm823505wma.34.2023.02.17.00.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 00:50:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15c59004-aea0-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lCCwBRNqqs/M5Re28DTWANd2CatfKwKXtqWOyXxwKZc=; b=dcI55P8uip1UPstL013tnzWwN6Tj6tbuOoYf/a8N9zjG5MjYcdDyUA8NQE5/RxbjI9 /R+dMH6VGl1Ao1NAcxIraglXj4hJ3V/RUpgZgmIRCSwCPSjXXLix/5V9FXlSkx8XsrHX z+FK5MUeWp/2ba2GWZLOpZcKF9WwIIr57qCGs/Fm54uhGDUmcFyoG7uUVR6rzLPyZ791 yFJim5Ody+phEQoh+nqFKETQCGtAfTpUhb8cSfxXhnD304rRkgfLhBTnmlIZEIdTzBhh nT9H+HzJ3vXU/57smgTLWuzaxwHwXGyJJRBo+sfHjLy+DJv5qHzGYTf08pbzN28SA4Ek rVbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lCCwBRNqqs/M5Re28DTWANd2CatfKwKXtqWOyXxwKZc=; b=d0L4O1JW4gs69m496xIhQ/STbC2H+qXSRWWlDJZbpyXYwBWaGOVMoHNWg7NNi/hTEp D8w73G7ofo6zdDDwKznxZXHYTWMaQo0H4pyDU5HhE7I+rz8dyH+uCl3Lj9wo0ZW+ydtO ditArnwaQHe2r4oHsJbrml39sHieppZ4WdT4rHwvQdetQljI6iPjja/uzy1mMS5CUI0M jhZgqyfvSDvCD0XOVgz7mbPJm+jdrqp25KN3ZlsG7q04DjhM7WRH2UULXd4PaRov/jmf lOF6QjkCpWltRCq5MpUukIWpigx/XAjGPAZx5TPa0BQ8BQoyyKdUNL6/29rSU4oTE1Q9 Zq4Q== X-Gm-Message-State: AO0yUKW+PiEFlZwJKTKpdTDgRui9bJoY43AkRgZc/2Oxm/MWFiU+I2Lo EiC0V1sJ1vX2feENuNZSs1A= X-Google-Smtp-Source: AK7set+wooYgtmvapjXT4J9l1D33IqAfXE85gxNoIe4OxLQ+pOsQ+LK6qfIdD7aznHR7IolIzz5xjw== X-Received: by 2002:a05:600c:5006:b0:3e1:f8af:963f with SMTP id n6-20020a05600c500600b003e1f8af963fmr624811wmr.3.1676623809581; Fri, 17 Feb 2023 00:50:09 -0800 (PST) Date: Fri, 17 Feb 2023 09:50:06 +0100 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Message-ID: <20230217085006.GA2281468@horizon> References: <3aa736d3-b833-0c6c-2a41-71cc4b953aae@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3aa736d3-b833-0c6c-2a41-71cc4b953aae@suse.com> On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > On 14.12.2022 08:29, Jan Beulich wrote: > > On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >> +static int stats_vcpu_alloc_mfn(struct domain *d) > >> +{ > >> + struct page_info *pg; > >> + > >> + pg = alloc_domheap_page(d, MEMF_no_refcount); > > > > The ioreq and vmtrace resources are also allocated this way, but they're > > HVM-specific. The one here being supposed to be VM-type independent, I'm > > afraid such pages will be accessible by an "owning" PV domain (it'll > > need to guess the MFN, but that's no excuse). > > Which might be tolerable if it then can't write to the page. That would > require "locking" the page r/o (from guest pov), which ought to be > possible by leveraging a variant of what share_xen_page_with_guest() > does: It marks pages PGT_none with a single type ref. This would mean > ... > > >> + if ( !pg ) > >> + return -ENOMEM; > >> + > >> + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { > > ... using PGT_none here. Afaict this _should_ work, but we have no > precedent of doing so in the tree, and I may be overlooking something > which prevents that from working. > I do not fully understand this. I checked share_xen_page_with_guest() and I think you're talking about doing something like this for each allocated page to set them ro from a pv guest pov: pg->u.inuse.type_info = PGT_none; pg->u.inuse.type_info |= PGT_validated | 1; page_set_owner(page, d); // not sure if this is needed Then, I should use PGT_none instead of PGT_writable_page in get_page_and_type(). Am I right? Matias From xen-devel-bounces@lists.xenproject.org Fri Feb 17 08:58:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 08:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496948.767870 (Exim 4.92) (envelope-from ) id 1pSwYy-0006ob-BO; Fri, 17 Feb 2023 08:57:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496948.767870; Fri, 17 Feb 2023 08:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSwYy-0006oU-8D; Fri, 17 Feb 2023 08:57:52 +0000 Received: by outflank-mailman (input) for mailman id 496948; Fri, 17 Feb 2023 08:57:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSwYw-0006o5-Ox for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 08:57:50 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0616.outbound.protection.outlook.com [2a01:111:f400:fe0c::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26dbabc0-aea1-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 09:57:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9556.eurprd04.prod.outlook.com (2603:10a6:10:304::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Fri, 17 Feb 2023 08:57:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 08:57:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26dbabc0-aea1-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KuDX9lBAIrtbnsa58RQ83HJH8C6R69hPRi3wpcVxhfMOdHjgKPoQY8pTdGkssTxYEUZU/cLdF5bbFNHlNOSqK0Q5WtTH7P8X2zN+KfiBSaMnBMjrr6NeUE9IuMN1DrARVXDh8VK8Bf0Sa2MmoLT6lrqsn3OaX9WMjJJ7+fd2G5wO21fHA5A9dJtiPRkJxk3Q0VBBzjkBPiuqjTuIb7ftUzGJHqa7/szhSdR7/xGGuHdCy7NU1M1c4BDCzj22snUEMPQZ32025zQ5OBio+2KmfW7oEdWuMDzs1ohPgB50j5fBEAUzk3jkq1OEDUG2HCXcEFbIgdWfvt9hVOdGfDPV8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mwoR/UPX9x/FK3UXbiXBuRvvhf393KNzvKkZK4rY6yw=; b=E1mT5tSlFlSNZsGgwjKLxn2bGhw6aLPmu/4ew6scQ56WGLeX1hmi7WHg8AmutUF4upPL9bssXnIiKtPwJ12FU4LfFXI2/epksNGOQDjl5Yh9Hru5xA5Q9nLBIpS+QPxip1UJbbYvGHR9XyrRRNtUmmmr6PrT55md06JcGlv16WpHqrENnspUfRKgIf9CMfJFwahrMYA934AcUI7MazRJd6K4SgERSzrrUMy0w8+0+9e9vQxix18kszuut9JXYtf3Vs56gorwKqkEQ0PDj90SVBj+w58U21HJexZLQ4wrutT4eOSntCvIZT0/FP4VtLh8BqTuWi1oeJghyn0UcVXkOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwoR/UPX9x/FK3UXbiXBuRvvhf393KNzvKkZK4rY6yw=; b=ba/Iqr6mjMJ5eVwCHcj4VYY5hXEdgubtpNE9m83+6V2PNRnBdp5wx3W9RhfHADusQzyrLmg617S+ohzMI904fJYhYEy7xbdJs9Shhl3rMos5eQLu2ofas5/F1aEbdTD4TvkMZxOZcgAM1rRiioARYYGvi3vWfrLMKj8YLrc3tcz5LdZaoyRyrqtWqYLSfeI/X4YCwxzVbDrgjdKeohJ0lvTx4a38w388nS+VBrScG2BasihxMgQ3PT5GFtCxwBOTJbrHh8IopFwV0VoHxI3QEGwzqkNkHELzoZUibM9e4b35kNAS+gjgguUM7JO0aPT+OlD3pKM0rXLP4oWT48Ko9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e79d20d-0922-565a-e46d-e3366c0bcfb4@suse.com> Date: Fri, 17 Feb 2023 09:57:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org References: <3aa736d3-b833-0c6c-2a41-71cc4b953aae@suse.com> <20230217085006.GA2281468@horizon> From: Jan Beulich In-Reply-To: <20230217085006.GA2281468@horizon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9556:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fd3b942-cc38-436e-f7b1-08db10c509c4 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U8uuXyceVSfdS/09h5Vx166Qas8KPPqYZO474x7twbGT7s6TTfXjoMb0NDDVNx5nMVru7UuHvZvNFxwssiIqELY2SU6f2svH67X174xvbdZH5/0yf2aE2CfTVxc3zceLBkC6O/C12iWY53qwVtXRs4gHQRPKHFtcrs/Bd6fruzz/T+tz9IVFTOFd/kmGow3EwQ1/Esp9T9CGSOi1fRYOtWqk91poFp1Jyu3IUgouZBqkj8lEgxs7CLnh/tY4SZ6/ve0eiq9VDErhEZI1OH+4/ydomKYVnalbpipu0cUUOxZNN8VwunyFfwBotZJsY/sPl54ASgAW0qfD5A31pizcFakNeBsOSVV6FItC0ub4KG+dOVAlFefFTfk3Ga8yHUjGNG+fZx1M1Lc4Rch/gPGJlyYiEkz1mEan4okjWC9fFWBYs399lKqLKSpKBkhdSIDBollNLmREY8UOQYznSvTYtO9mCop2mW5tERd5oGHHITH4lcFkrB4PyTOOBd25qcg7mhWmBkpFlYiYCDDKlcGGATeyXTgZB1CRKdiFTXErEzuoMItOXFH2qIbZjo7YBOXDbOHChK1jYIZkcwdfY6dp3fuQlObn6IT2DDXHTY0nVDn0xhLp8VHdwRkIx0z56UGFA5koSIPqH9o1Ij41sMUb2rF6ooMXokIITNqOb0/pq/iLWPTrkkVEPAhDSvzOgY30r3MP5exXwwkuvNBJCOtnoLVRqE+lg4840BiKQfR4K9Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199018)(31686004)(6916009)(66556008)(86362001)(54906003)(6486002)(31696002)(41300700001)(5660300002)(66946007)(8936002)(66476007)(8676002)(36756003)(6506007)(2906002)(6512007)(316002)(26005)(53546011)(186003)(478600001)(4326008)(6666004)(2616005)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkpqS0ExSFV3RjBMa2VMVEkzUDRhUTIwYW12dCtFb05ZNnA5a3g4ZzVtb0NQ?= =?utf-8?B?T1VEeDJoSHJSUStmY01kWnVNSjFYYXZtRkY2UkxReTB1L0xZOWNOb0dJSVJW?= =?utf-8?B?b2dEQWVkRVdrcGVnUGo5NDhUN00xcUwyVU80TVdDdmMwZFRQc0kwQ3BzNXll?= =?utf-8?B?eTBQMXV6ck5NV2NXSXFpY2NNc0tSN0hkbWNqL3hpVGR1TWJkeGVLcHVQN1dw?= =?utf-8?B?ZHNHQXBNRGVrZHFNVk1HMXZmcUhrVlgyU1VFNzkzd2dmSkY1ZXh2R0hkN2lz?= =?utf-8?B?Wjduc0xPa2ZYcndqWUpuVDA1MHhIc1lQK3g0MDd5alh5YUFRSU43czhlRURm?= =?utf-8?B?NmVhWG9odzhjV3RvYlZUZU1qdWZwL2NZSkpsRUsybWxHV1Z3ZEpXN0lGa21X?= =?utf-8?B?anNjY2hwZ3BGOXN5NGpMY2x2eEh4UWtVKzVqQXU3akcyNXBFVW52MjU0SlEw?= =?utf-8?B?RVpSK0F0ZUczZUdyQU5qeEE3UnlvSEk4NTk2cEV5aE80cjVxcUxSZnhYckVz?= =?utf-8?B?N0FZQ2ZuNGg2N3QwWXc3cFp3TkczMzhMK3BuSGFrR25WSlJzcWEvQ3haQWJv?= =?utf-8?B?akZhNkpxdklabjU5UkN0UmRTRTZvTG1Fam8xZnpyN3puSjYveWwzdTBnUU9o?= =?utf-8?B?cHBaMVlSdlJjZ1ZIUEthMnBURDgrM21UQmUzOGJ4dmk0WHc0cWl3a2hOWHF1?= =?utf-8?B?MGNlYzZSUUtXMGhmblhpbHVVVFpibGJBMitUQnBMQWJhKzBkT3pjOG9XdXdm?= =?utf-8?B?YVJ4aXJuSFVId0R4bm5MYWl5TEE2MTZhNThwYjBkaDcwZ21qWXV5enpTOVgw?= =?utf-8?B?L3d2d3pSeUpoZjlneHFnYzRURDcrVUxhTUxnSVJCRjdBMEM2RksrMDgyU21o?= =?utf-8?B?NVhZRXJOeGM1SEtqQlU3T1RvblJFWTBxZElTcHlkL3NtcDRDSG45dU1XOGRq?= =?utf-8?B?M3VsQ1JUV1QrSHFmSDJKcVg2bDI1TExZQUk3dXNnYjBBUzNXclZSV2xNTCsy?= =?utf-8?B?bHJqdzE2eGRZSHFsU2xQVzdBNkhLbFBGRTJiL0tUc014dSt0a21rWWcweTdh?= =?utf-8?B?N0luaFdSbXI0bXphTFczWmhXRUFoTGxadUh5L0E4R2FzYXR1RkhacWEwaHZO?= =?utf-8?B?K2Q2NFhQT0JXSDdqVEtiM2RvbEhWZ2FiY0lpeklqeitQaVprbEJ2OUtSMndN?= =?utf-8?B?SFArUDQrWlo4ZGxLM3VqZlNndU1iSmtOUldRZ3RscHRGMFJrUVhEa21IMGFF?= =?utf-8?B?ZUl5YWpkOVJDVWl5MHNGU3lvSGdHTHc2V0d4YktmZTlyMGJ0NCtxNHhyWm10?= =?utf-8?B?VlhVTlBCN1FEY1ZIWTN4MjFRa2tjOSs1SVJRRGNnNHkraXpPd1EwdGdqMGdm?= =?utf-8?B?VGR5em1YRzNKRDFZZFFCdjFGZlA1UFVtZG5vZS9XOG1CbllJczZCSTFvU2Jq?= =?utf-8?B?UjdUSHB1RHVvVitON2RoZU5aQi82VVpqV1Y2WWJGUEd5Z2UvOHp2d2FyVDMy?= =?utf-8?B?d1JmcERjNGFKVjN0QjNiWFJjOTJvL1huWXBJcCs1MFk4RWZsU2xaTFhOM0JP?= =?utf-8?B?eGM3eWlBRW0zOWQ5R2R2SWdPTnV4ZE1UQWJrdmRhZ0dsdnBvN1RneFVtN3h1?= =?utf-8?B?MzBhYXJrZjdSY3djYTRPbDhRUlZLOWgybTlCZ1ROTG1VSmd1NStkbk43TWhU?= =?utf-8?B?Sm1uWWx1VHNwV0ZyVW0vZk1vODMrUUFCSk5UTTBaK0ZPUW9jRWNFZldiK1Ey?= =?utf-8?B?NlBHa0thcm13b1J0SXY0bTVxRUdaZTNkSnFMTDBBdnp2dkM1NzhrOEh1b1VB?= =?utf-8?B?cnF5dlJBanl5ZWlGcjFOQllwOGoxTUtJYjFoSnU1a3d2WDR5bXJ4ZnFTaFdh?= =?utf-8?B?QXNtWW5Ia1RkbjlzMWhhYXhXdjFEQ2FSWmx0L2ZLZVJlQzByOSs0V1FhSmF1?= =?utf-8?B?VkN1aVVhdTZVOFY0cnRjNmlzN0loNFgxN25EaDFYck95QXF3SFlvRVd3eXJJ?= =?utf-8?B?RHVvdXN0eG1LcGJxWFg3NitzRlNKaHp3QmJmZHY4M1BiUnZ1dGJSZEZ0RnN4?= =?utf-8?B?U3VwZlhlMzh5bUplN3RIN2drSWR0ZkptdnBRRmo3ZGhIOXhaOUVkdzBnd2Ev?= =?utf-8?Q?HgzKVR4D+qAqan/FkpgkKB/ct?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fd3b942-cc38-436e-f7b1-08db10c509c4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 08:57:46.2812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HeS34tWMUhg20jOjI049pPC8QdBnJspFoB618VJjgy0cNh/RAr+GWA9OTxfIrO6ipX5Ugj9UOUmUE/eChxCONw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9556 On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: >> On 14.12.2022 08:29, Jan Beulich wrote: >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>>> +static int stats_vcpu_alloc_mfn(struct domain *d) >>>> +{ >>>> + struct page_info *pg; >>>> + >>>> + pg = alloc_domheap_page(d, MEMF_no_refcount); >>> >>> The ioreq and vmtrace resources are also allocated this way, but they're >>> HVM-specific. The one here being supposed to be VM-type independent, I'm >>> afraid such pages will be accessible by an "owning" PV domain (it'll >>> need to guess the MFN, but that's no excuse). >> >> Which might be tolerable if it then can't write to the page. That would >> require "locking" the page r/o (from guest pov), which ought to be >> possible by leveraging a variant of what share_xen_page_with_guest() >> does: It marks pages PGT_none with a single type ref. This would mean >> ... >> >>>> + if ( !pg ) >>>> + return -ENOMEM; >>>> + >>>> + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { >> >> ... using PGT_none here. Afaict this _should_ work, but we have no >> precedent of doing so in the tree, and I may be overlooking something >> which prevents that from working. >> > > I do not fully understand this. I checked share_xen_page_with_guest() and I > think you're talking about doing something like this for each allocated page to > set them ro from a pv guest pov: > > pg->u.inuse.type_info = PGT_none; > pg->u.inuse.type_info |= PGT_validated | 1; > page_set_owner(page, d); // not sure if this is needed > > Then, I should use PGT_none instead of PGT_writable_page in > get_page_and_type(). Am I right? No, if at all possible you should avoid open-coding anything. As said, simply passing PGT_none to get_page_and_type() ought to work (again, as said, unless I'm overlooking something). share_xen_page_with_guest() can do what it does because the page isn't owned yet. For a page with owner you may not fiddle with type_info in such an open-coded manner. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 09:30:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 09:30:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496961.767880 (Exim 4.92) (envelope-from ) id 1pSx3y-0003Bi-QA; Fri, 17 Feb 2023 09:29:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496961.767880; Fri, 17 Feb 2023 09:29:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSx3y-0003Bb-NC; Fri, 17 Feb 2023 09:29:54 +0000 Received: by outflank-mailman (input) for mailman id 496961; Fri, 17 Feb 2023 09:29:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSx3x-0003BV-Ce for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 09:29:53 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a108df7f-aea5-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 10:29:51 +0100 (CET) Received: by mail-wr1-x433.google.com with SMTP id bv17so202392wrb.9 for ; Fri, 17 Feb 2023 01:29:51 -0800 (PST) Received: from horizon ([2a01:e0a:257:8c60:48e5:bfa:d652:b8ef]) by smtp.gmail.com with ESMTPSA id p18-20020adff212000000b002c556f36116sm3568249wro.66.2023.02.17.01.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 01:29:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a108df7f-aea5-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+CnKws38SoFG+Iotr9LZzcs87sjR8KjZPOY+NQBrX5Q=; b=c2brh7P3GaxVTfzbvAHnLy5qVmEgEAahhvPnkhR1I1KqZsWrKgSAETHxunhLeM86j+ fTUmLwp9fgMNHckRunUtNeMIV0CAF/AHvzYZ/SrkO3RqApW8MlAvSWGprb8iqlGSg67B lfU59rTnlBuY8j68dAPDnnPPYmgp7yxaW7NazfGF9WZlWtHzeq89F5YsCt18bkLrkimN S5uIb5zyJQVrM217rcoO9VLDPZdusvAG7OPqJaSOZxWFvAuXAz4gHPTPd5wuu2t4FJPI s+R/hKGtx6ylypCIxPeEgaxh3CbnbRMicPVcjpjC4YGV6JihXvu+5jvaJhJVlqD70TCZ dJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+CnKws38SoFG+Iotr9LZzcs87sjR8KjZPOY+NQBrX5Q=; b=a9Cv66eK0+bmU3dQInqhGx5dCBFYzdALRiwEg45domptnBUmEhKwAhZsIQG3d5I2cV PpY0UUQxW5tSLRfFkFaIqPwPUM6zta4szBXRHwMcsiBNULSc8/BvzGbTBsxpX/BDQL8g QbRbY/V2AkPCATNGKlBoTq4s6QEFCM705xGYEUcV7IYbCqZpkIn7jQ9IzPdMLBajdvIp P86BXIqj33E7bzaF9SEOSKjo49JYs39YFbFoJ7Z4YwWlMb69dipIja7rFQoRU+wkWNrm 2f/OOHqbelGVUs+AssR7KzMpd8N1u8OhF0tsufuaCMVq7voeW3UA+A7C7lVUhNmK1R6u Pwgg== X-Gm-Message-State: AO0yUKU98JEUUYRmIG8kKlOAy2tRQmKnf3Bv/lXMokn+lA9rWelQj6gv KzmC2RhlFL/73foqxC/QIZI= X-Google-Smtp-Source: AK7set+um+cetIzM97JyQniiJF2RYPDbslxv7L0ofhOwyfSNYSPjsP1EU8fgGcSfPpYIq7OFbrH0YA== X-Received: by 2002:a5d:50c2:0:b0:2c5:55a1:4b2 with SMTP id f2-20020a5d50c2000000b002c555a104b2mr6363433wrt.49.1676626190960; Fri, 17 Feb 2023 01:29:50 -0800 (PST) Date: Fri, 17 Feb 2023 10:29:48 +0100 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Message-ID: <20230217092948.GA2282871@horizon> References: <3aa736d3-b833-0c6c-2a41-71cc4b953aae@suse.com> <20230217085006.GA2281468@horizon> <7e79d20d-0922-565a-e46d-e3366c0bcfb4@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e79d20d-0922-565a-e46d-e3366c0bcfb4@suse.com> On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: > On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: > > On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: > >> On 14.12.2022 08:29, Jan Beulich wrote: > >>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >>>> +static int stats_vcpu_alloc_mfn(struct domain *d) > >>>> +{ > >>>> + struct page_info *pg; > >>>> + > >>>> + pg = alloc_domheap_page(d, MEMF_no_refcount); > >>> > >>> The ioreq and vmtrace resources are also allocated this way, but they're > >>> HVM-specific. The one here being supposed to be VM-type independent, I'm > >>> afraid such pages will be accessible by an "owning" PV domain (it'll > >>> need to guess the MFN, but that's no excuse). > >> > >> Which might be tolerable if it then can't write to the page. That would > >> require "locking" the page r/o (from guest pov), which ought to be > >> possible by leveraging a variant of what share_xen_page_with_guest() > >> does: It marks pages PGT_none with a single type ref. This would mean > >> ... > >> > >>>> + if ( !pg ) > >>>> + return -ENOMEM; > >>>> + > >>>> + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { > >> > >> ... using PGT_none here. Afaict this _should_ work, but we have no > >> precedent of doing so in the tree, and I may be overlooking something > >> which prevents that from working. > >> > > > > I do not fully understand this. I checked share_xen_page_with_guest() and I > > think you're talking about doing something like this for each allocated page to > > set them ro from a pv guest pov: > > > > pg->u.inuse.type_info = PGT_none; > > pg->u.inuse.type_info |= PGT_validated | 1; > > page_set_owner(page, d); // not sure if this is needed > > > > Then, I should use PGT_none instead of PGT_writable_page in > > get_page_and_type(). Am I right? > > No, if at all possible you should avoid open-coding anything. As said, > simply passing PGT_none to get_page_and_type() ought to work (again, as > said, unless I'm overlooking something). share_xen_page_with_guest() > can do what it does because the page isn't owned yet. For a page with > owner you may not fiddle with type_info in such an open-coded manner. > Thanks. I got the following bug when passing PGT_none: (XEN) Bad type in validate_page 0 t=0000000000000001 c=8040000000000002 (XEN) Xen BUG at mm.c:2643 I did not investigate yet why this has happened. Matias From xen-devel-bounces@lists.xenproject.org Fri Feb 17 09:33:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 09:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496967.767891 (Exim 4.92) (envelope-from ) id 1pSx7G-0004a7-8U; Fri, 17 Feb 2023 09:33:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496967.767891; Fri, 17 Feb 2023 09:33:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSx7G-0004a0-5n; Fri, 17 Feb 2023 09:33:18 +0000 Received: by outflank-mailman (input) for mailman id 496967; Fri, 17 Feb 2023 09:33:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSx7F-0004Zs-Lp for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 09:33:17 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1afc4c8d-aea6-11ed-933c-83870f6b2ba8; Fri, 17 Feb 2023 10:33:16 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id dn12so9716630edb.5 for ; Fri, 17 Feb 2023 01:33:16 -0800 (PST) Received: from [192.168.8.199] (46.204.109.85.nat.umts.dynamic.t-mobile.pl. [46.204.109.85]) by smtp.gmail.com with ESMTPSA id kd18-20020a17090798d200b008b2aba5fb22sm575691ejc.206.2023.02.17.01.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 01:33:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1afc4c8d-aea6-11ed-933c-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=J+ZWzgE4k+iIxWqerA+804Hq5BAplfKspQnnTnzNng8=; b=P10Q1yAY9ADcyRIL53LGVQmXW6inZpWsin8El+AuEclUvukEHBpsXBH9OJxKl3Oqt5 j41CLgCo++tXU1lXriyM2SypAbtwHEakv/kOEhL99AaZia/1Vt0XPYIaGW9COmsp0Mpn BSSzuMx01jFWBiUfHWRvhh20EOq0GoZKm7tMilmCxD5ATGtdTaSrvUfSvAH6Hm+SbeEv +c0Xr+6Q8ozyEoOR6QhyY/AMJdhIhuEQBNA+X0nkTKsQKk33CZIirH5DOM5FR91Mt7qo d7ezAD1mJUjZzSto5HTJAanyl2GwEXFt26dNoCFCzz71t7Lu8u5ezpeLJVOFpiIZQTOo L2Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=J+ZWzgE4k+iIxWqerA+804Hq5BAplfKspQnnTnzNng8=; b=Hi6Svtnduk3EDRsOsu42qOHtBmue2bsiqGOUOlg1nfkPFKn6xdbXboeOo4KXqiGl6Z cN6gvQRBRrW9yukTu/wChQMq4RUi7XlPMW8i3E3cpHeZWJhc5eBAjrb7IrUDxKKaWEpe 2tOXc67Li+usbpe+5551prd1FQpSeVXMJuTdEpbqvja7let/bWI5HVWK8ZGJfrbsWsSB Vii3RqFz60Sb8N/XkeV6Y4Uu8EhsE1mNT5sCyzbhJXdjkJ9pw/wHf++0bIcky7SXu2vF jPlMk3KfjIL8zg9huaASMIq3a+q/b0naSlXdGKc8RER2l4mtQkx2ANGoj3+egEN2oOVA 1rsg== X-Gm-Message-State: AO0yUKXM+MX+qxVPuYU3argPuSboxPeJaQ+Jc3nOIq2gilWM+vJSCxcE gw8mHXChLnE0S9oebBs7RVI= X-Google-Smtp-Source: AK7set8eI/o4k/DxLMX++XIGYMUZrTS0pJe9MF2r3DtFuvcdzbtKJnBgdIYn8zOoNN/6zUkX0qXr0w== X-Received: by 2002:a17:906:4910:b0:8b1:7de0:c854 with SMTP id b16-20020a170906491000b008b17de0c854mr2531324ejq.41.1676626395616; Fri, 17 Feb 2023 01:33:15 -0800 (PST) Message-ID: <75a018704e212c043370269d10e4b4a45146e9b3.camel@gmail.com> Subject: Re: [PATCH v1 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper Date: Fri, 17 Feb 2023 11:33:13 +0200 In-Reply-To: <20191ac6-3c1c-8c9f-39ed-308bc22d5b3f@suse.com> References: <8adf4aeff96750982e3d670cb3aed11553d546d5.1675441720.git.oleksii.kurochko@gmail.com> <199fa5a6-ca31-091e-88e0-cae9efde307b@suse.com> <81fd6cf5ff59acf6ca8b66e093630e5accc45198.camel@gmail.com> <9cf03b23-586b-92e1-c0b1-578f3eadd2ad@suse.com> <00abbda808239ab74cb6c954b33e34380ac4e41e.camel@gmail.com> <5f6d7b8e-907b-d3eb-335c-8d4a77edf526@suse.com> <413b6d1439a31e24719321494971cc165bd6942c.camel@gmail.com> <29623e829602d0a7861785b8f0a47d6905ac89c4.camel@gmail.com> <4c52d703-dd7c-b316-5e37-38c9aa705725@citrix.com> <20191ac6-3c1c-8c9f-39ed-308bc22d5b3f@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 T24gRnJpLCAyMDIzLTAyLTE3IGF0IDA4OjEyICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAxNi4wMi4yMDIzIDIxOjQ0LCBPbGVrc2lpIHdyb3RlOgo+ID4gT24gVGh1LCAyMDIzLTAyLTE2 IGF0IDEyOjE5ICswMDAwLCBBbmRyZXcgQ29vcGVyIHdyb3RlOgo+ID4gPiBPbiAxNi8wMi8yMDIz IDEyOjA5IHBtLCBPbGVrc2lpIHdyb3RlOgo+ID4gPiA+IE9uIFRodSwgMjAyMy0wMi0xNiBhdCAx Mjo0NCArMDIwMCwgT2xla3NpaSB3cm90ZToKPiA+ID4gPiA+IE9uIFRodSwgMjAyMy0wMi0xNiBh dCAwODozMSArMDEwMCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIDE1LjAyLjIw MjMgMTg6NTksIE9sZWtzaWkgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gSGVsbG8gSmFuIGFuZCBjb21t dW5pdHksCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gSSBleHBlcmltZW50ZWQgYW5kIHN3 aXRjaGVkIFJJU0MtViB0byB4ODYgaW1wbGVtZW50YXRpb24uCj4gPiA+ID4gPiA+ID4gQWxsCj4g PiA+ID4gPiA+ID4gdGhhdAo+ID4gPiA+ID4gPiA+IEkKPiA+ID4gPiA+ID4gPiBjaGFuZ2VkIGlu IHg4NiBpbXBsZW1lbnRhdGlvbiBmb3IgUklTQy1WIHdhcwo+ID4gPiA+ID4gPiA+IF9BU01fQlVH RlJBTUVfVEVYVC4KPiA+ID4gPiA+ID4gPiBPdGhlcgo+ID4gPiA+ID4gPiA+IHRoaW5ncyBhcmUg dGhlIHNhbWUgYXMgZm9yIHg4Ni4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBGb3IgUklT Qy1WIGl0IGlzIGZpbmUgdG8gc2tpcCAnJWMnIG1vZGlmaWVyIHNvCj4gPiA+ID4gPiA+ID4gX0FT TV9CVUdGUkFNRV9URVhUCj4gPiA+ID4gPiA+ID4gd2lsbAo+ID4gPiA+ID4gPiA+IGxvb2sgbGlr ZToKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAjZGVmaW5lIF9BU01fQlVHRlJBTUVfVEVY VChzZWNvbmRfZnJhbWUpIFwKPiA+ID4gPiA+ID4gPiDCoMKgwqAgIi5MYnVnJT06IGVicmVha1xu IsKgwqAgCj4gPiA+ID4gPiA+ID4gwqDCoMKgICIucHVzaHNlY3Rpb24gLmJ1Z19mcmFtZXMuJVti Zl90eXBlXSwgXCJhXCIsCj4gPiA+ID4gPiA+ID4gQHByb2diaXRzXG4iCj4gPiA+ID4gPiA+ID4g wqDCoMKgICIucDJhbGlnbiAyXG4iCj4gPiA+ID4gPiA+ID4gwqDCoMKgICIuTGZybSU9OlxuIgo+ ID4gPiA+ID4gPiA+IMKgwqDCoCAiLmxvbmcgKC5MYnVnJT0gLSAuTGZybSU9KSArICVbYmZfbGlu ZV9oaV1cbiIKPiA+ID4gPiA+ID4gPiDCoMKgwqAgIi5sb25nICglW2JmX3B0cl0gLSAuTGZybSU9 KSArICVbYmZfbGluZV9sb11cbiIKPiA+ID4gPiA+ID4gPiDCoMKgwqAgIi5pZiAiICNzZWNvbmRf ZnJhbWUgIlxuIgo+ID4gPiA+ID4gPiA+IMKgwqDCoCAiLmxvbmcgMCwgJVtiZl9tc2ddIC0gLkxm cm0lPVxuIgo+ID4gPiA+ID4gPiA+IMKgwqDCoCAiLmVuZGlmXG4iCj4gPiA+ID4gPiA+ID4gwqDC oMKgICIucG9wc2VjdGlvblxuIgo+ID4gPiA+ID4gPiBJIGV4cGVjdCB0aGlzIGNvdWxkIGJlIGZ1 cnRoZXIgYWJzdHJhY3RlZCBzdWNoIHRoYXQgb25seQo+ID4gPiA+ID4gPiB0aGUKPiA+ID4gPiA+ ID4gYWN0dWFsCj4gPiA+ID4gPiA+IGluc3RydWN0aW9uIGlzIGFyY2gtc3BlY2lmaWMuCj4gPiA+ ID4gPiBHZW5lcmFsbHksIHRoZSBvbmx5IHRoaW5nIHRoYXQgY2FuJ3QgYmUgYWJzdHJhY3RlZCAo IGFzIHlvdQo+ID4gPiA+ID4gbWVudGlvbmVkCj4gPiA+ID4gPiBpcyBhbiBpbnN0cnVjdGlvbiAp Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBTbyB3ZSBjYW4gbWFrZSBhZGRpdGlvbmFsIGRlZmluZXM6 Cj4gPiA+ID4gPiDCoCAxLiAjZGVmaW5lIE1PRElGSUVSICIiIG9yICJjIiAoZGVwZW5kcyBvbiBh cmNoaXRlY3R1cmUpIGFuZAo+ID4gPiA+ID4gdXNlCj4gPiA+ID4gPiBpdAo+ID4gPiA+ID4gwqAK PiA+ID4gPiA+IHRoZSBmb2xsb3dpbmcgd2F5Ogo+ID4gPiA+ID4gwqAgwqAiLnB1c2hzZWN0aW9u IC5idWdfZnJhbWVzLiUiTU9ESUZJRVIiW2JmX3R5cGVdLCBcImFcIiwKPiA+ID4gPiA+IEBwcm9n Yml0c1xuIgo+ID4gPiA+ID4gwqAgwqAuLi4KPiA+ID4gPiA+IMKgIDIuICNkZWZpbmUgQlVHX0lO U1RSICJlYnJlYWsiIHwgInVkMiIgfCAiLi4uIiBhbmQgdXNlIGl0IGluCj4gPiA+ID4gPiB0aGUK PiA+ID4gPiA+IGZvbGxvd2luZyB3YXk6Cj4gPiA+ID4gPiDCoCDCoCIuTGJ1ZyU9OiAiQlVHX0lT TlRSIlxuIgo+ID4gPiA+ID4gwqAgwqAuLi4KPiA+ID4gPiA+IEV4Y2VwdCBmb3IgdGhlc2UgZGVm aW5lcyB3aGljaCBzaG91bGQgYmUgc3BlY2lmaWVkIGZvciBlYWNoCj4gPiA+ID4gPiBhcmNoaXRl Y3R1cmUKPiA+ID4gPiA+IGFsbCBvdGhlciBjb2RlIHdpbGwgYmUgdGhlIHNhbWUgZm9yIGFsbCBh cmNoaXRlY3R1cmVzLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBCdXQgYXMgSSB1bmRlcnN0YW5kIHdp dGggbW9kaWZpZXIgJ2MnIGNhbiBiZSBpc3N1ZXMgdGhhdCBub3QKPiA+ID4gPiA+IGFsbAo+ID4g PiA+ID4gY29tcGlsZXJzIHN1cHBvcnQgYnV0IGZvciBBUk0gYW5kIMKgeDg2IGJlZm9yZSBpbW1l ZGlhdGUgaXMKPiA+ID4gPiA+IHByZXNlbnQKPiA+ID4gPiA+IHB1bmN0dWF0aW9uICMgb3IgJCB3 aGljaCBhcmUgcmVtb3ZlZCBieSBtb2RpZmllciAnYycuIEFuZCBJCj4gPiA+ID4gPiBhbQo+ID4g PiA+ID4gd29uZGVyaW5nIHdoYXQgb3RoZXIgd2F5cyB0byByZW1vdmUgcHVuY3R1YXRpb24gYmVm b3JlCj4gPiA+ID4gPiBpbW1lZGlhdGUKPiA+ID4gPiA+IGV4aXN0Lgo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBEbyB5b3UgdGhpbmsgd2Ugc2hvdWxkIGNvbnNpZGVyIHRoYXQgYXMgYW4gaXNzdWU/Cj4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBUaGUgb25seSB0aGluZyBJIGFtIHdvcnJpZWQgYWJvdXQg aXM6Cj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gI2RlZmluZSBfQVNNX0JVR0ZSQU1FX0lO Rk8odHlwZSwgbGluZSwgcHRyLCBtc2cpIFwKPiA+ID4gPiA+ID4gPiDCoCBbYmZfdHlwZV0gImki ICh0eXBlKSwgLi4uCj4gPiA+ID4gPiA+ID4gYmVjYXVzZSBhcyBJIHVuZGVyc3RhbmQgaXQgY2Fu IGJlIGFuIGlzc3VlIHdpdGggJ2knCj4gPiA+ID4gPiA+ID4gbW9kaWZpZXIKPiA+ID4gPiA+ID4g PiBpbgo+ID4gPiA+ID4gPiA+IGNhc2Ugb2YKPiA+ID4gPiA+ID4gPiBQSUUuIEkgYW0gbm90IHN1 cmUgdGhhdCBYZW4gZW5hYmxlcyBQSUUgc29tZXdoZXJlIGJ1dAo+ID4gPiA+ID4gPiA+IHN0aWxs Li4uCj4gPiA+ID4gPiA+ID4gSWYgaXQgaXMgbm90IGFuIGlzc3VlIHRoZW4gd2UgY2FuIHVzZSB4 ODYgaW1wbGVtZW50YXRpb24KPiA+ID4gPiA+ID4gPiBhcyBhCj4gPiA+ID4gPiA+ID4gZ2VuZXJp Ywo+ID4gPiA+ID4gPiA+IG9uZS4KPiA+ID4gPiA+ID4gImkiIGlzIG5vdCBnZW5lcmFsbHkgYW4g aXNzdWUgd2l0aCBQSUUsIGl0IG9ubHkgaXMgd2hlbiB0aGUKPiA+ID4gPiA+ID4gdmFsdWUKPiA+ ID4gPiA+ID4gaXMKPiA+ID4gPiA+ID4gdGhlCj4gPiA+ID4gPiA+IGFkZHJlc3Mgb2YgYSBzeW1i b2wuIEhlcmUgInR5cGUiIGlzIGEgY29uc3RhbnQgaW4gYWxsCj4gPiA+ID4gPiA+IGNhc2VzLgo+ ID4gPiA+ID4gPiAoT3IKPiA+ID4gPiA+ID4gZWxzZQo+ID4gPiA+ID4gPiBob3cgd291bGQgeW91 IGV4cHJlc3MgYW4gaW1tZWRpYXRlIG9wZXJhbmQgb2YgYW4KPiA+ID4gPiA+ID4gaW5zdHJ1Y3Rp b24gaW4KPiA+ID4gPiA+ID4gYW4KPiA+ID4gPiA+ID4gYXNtKCk/KQo+ID4gPiA+ID4gSG1tLiBJ IGRvbid0IGtub3cgb3RoZXIgd2F5cyB0byBleHByZXNzIGFuIGltbWVkaWF0ZSBvcGVyYW5kCj4g PiA+ID4gPiBleGNlcHQKPiA+ID4gPiA+ICdpJy4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gSXQgbG9v a3MgbGlrZSB0eXBlLCBsaW5lLCBtc2cgYXJlIGFsd2F5cyAnY29uc3RhbnRzJ8KgCj4gPiA+ID4g PiAoCj4gPiA+ID4gPiB0aGV5IHBvc3NpYmx5IGNhbiBiZSBwYXNzZWQgd2l0aG91dCAnaScgYW5k IHVzZWQgZGlyZWN0bHkKPiA+ID4gPiA+IGluc2lkZQo+ID4gPiA+ID4gYXNtKCk6Cj4gPiA+ID4g PiDCoMKgIC4uLgo+ID4gPiA+ID4gwqDCoCAiLnB1c2hzZWN0aW9uIC5idWdfZnJhbWVzLiIgX19z dHJpbmdpZnkodHlwZSkgIiwgXCJhXCIsCj4gPiA+ID4gPiAlcHJvZ2JpdHNcbiJcCj4gPiA+ID4g PiDCoMKgIC4uLgo+ID4gPiA+ID4gKSBidXQgdGhlIGlzc3VlIHdpbGwgYmUgd2l0aCAncHRyJyBm b3Igd2hpY2ggd2UgaGF2ZSB0byB1c2UKPiA+ID4gPiA+ICdpJy4KPiA+ID4gPiA+IAo+ID4gPiA+ ID4gQW5kIEkgYW0gbm90IHN1cmUgYWJvdXQgYWxsICdjb25zdGFudHMnLiBGb3IgZXhhbXBsZSwg SSB0aGluawo+ID4gPiA+ID4gdGhhdCBpdAo+ID4gPiA+ID4gY2FuIGJlIGFuIGlzc3VlIHdpdGgg J2xpbmUnID0gJygobGluZSAmICgoMSA8PAo+ID4gPiA+ID4gQlVHX0xJTkVfTE9fV0lEVEgpCj4g PiA+ID4gPiAtCj4gPiA+ID4gPiAxKSkKPiA+ID4gPiA+IDw8IEJVR19ESVNQX1dJRFRIKScgaWYg d2Ugd2lsbCB1c2UgdGhhdCBkaXJlY3RseSBpbnNpZGUKPiA+ID4gPiA+IGFzbSguLi4pLgo+ID4g PiA+ID4gCj4gPiA+ID4gSSB0aGluayB3ZSBjYW4gYXZvaWQgJ2knIGJ5IHVzaW5nICdyJyArIHNv bWUga2luZCBvZiBtb3YKPiA+ID4gPiBpbnN0cnVjdGlvbiB0bwo+ID4gPiA+IHdyaXRlIGEgcmVn aXN0ZXIgdmFsdWUgdG8gbWVtb3J5LiBUaGUgY29kZSBiZWxvdyBpcyBwc2V1ZG8tCj4gPiA+ID4g Y29kZToKPiA+ID4gPiAjZGVmaW5lIF9BU01fQlVHRlJBTUVfVEVYVChzZWNvbmRfZnJhbWUpCj4g PiA+ID4gwqDCoCDCoC4uLgo+ID4gPiA+IMKgwqDCoCAibG9jX2Rpc3A6XG4iCj4gPiA+ID4gwqDC oMKgICLCoMKgwqAgLmxvbmcgMHgwIgo+ID4gPiA+IMKgwqDCoCAibW92IFtsb2NfZGlzcF0sIHNv bWVfcmVnaXN0ZXIiCj4gPiA+ID4gwqDCoMKgIC4uLgo+ID4gPiA+IEFuZCB0aGUgd2UgaGF2ZSB0 byBkZWZpbmUgbW92IGZvciBlYWNoIGFyY2hpdGVjdHVyZS4KPiA+ID4gCj4gPiA+IE5vLCB5b3Ug cmVhbGx5IGNhbm5vdC7CoCBUaGlzIGlzIHRoZSBhc20gZXF1aXZhbGVudCBvZiB3cml0aW5nCj4g PiA+IHNvbWV0aGluZwo+ID4gPiBsaWtlIHRoaXM6Cj4gPiA+IAo+ID4gPiBzdGF0aWMgc3RydWN0 IGJ1Z2ZyYW1lIF9fc2VjdGlvbiguYnVnX2ZyYW1lcy4xKSBmb28gPSB7Cj4gPiA+IMKgwqDCoCAu bG9jID0gaW5zbiAtICZmb28gKyBMSU5FX0xPLAo+ID4gPiDCoMKgwqAgLm1zZyA9ICJidWcgc3Ry aW5nIiAtICZmb28gKyBMSU5FX0hJLAo+ID4gPiB9Owo+ID4gPiAKPiA+ID4gSXQgaXMgYSBkYXRh IHN0cnVjdHVyZSwgbm90IGV4ZWN1dGFibGUgY29kZS4KPiA+IFRoYW5rcyBmb3IgdGhlIGNsYXJp ZmljYXRpb24uCj4gPiAKPiA+IFdoYXQgYWJvdXQgbWFpbmx5IHVzaW5nIEMgZm9yIEJVR19GUkFN RSBhbmQgb25seSBhbGxvY2F0aW5nCj4gPiBidWdfZnJhbWUKPiA+IHNlY3Rpb25zIGluIGFzc2Vt Ymx5Pwo+ID4gCj4gPiBQbGVhc2UgbG9vayBhdCBQT0MgYmVsb3c6Cj4gCj4gVGhhdCdzIHN0aWxs IHVzaW5nIHN0YXRlbWVudHMgKGFzc2lnbm1lbnRzKSwgbm90IGluaXRpYWxpemVycy4gV2UKPiBl eHBlY3QKPiB0aGUgdGFibGUgdG8gYmUgcG9wdWxhdGVkIGF0IGJ1aWxkIHRpbWUsIGFuZCB3ZSBl eHBlY3QgaXQgdG8gYmUgcmVhZC0KPiBvbmx5Cj4gYXQgcnVudGltZS4gUGx1cyB5b3VyIGFwcHJv YWNoIG9uY2UgYWdhaW4gaW5jcmVhc2VzIG92ZXJhbGwgc2l6ZQo+IChqdXN0Cj4gdGhhdCB0aGlz IHRpbWUgeW91IGFkZCBjb2RlLCBub3QgZGF0YSkuCklmIHdlIGhhdmUgc3VjaCByZXF1aXJlbWVu dHMgdGhlbiB0aGUgYmVzdCBvcHRpb24gaXMgdG8gdXNlIGFzIGEKZ2VuZXJpYyBpbXBsZW1lbnRh dGlvbiB0aGUgaW1wbGVtZW50YXRpb24gcHJvdmlkZWQgYnkgeDg2ICggYXMgSQptZW50aW9uZWQg YmVmb3JlLCBpdCBtYWlubHkgY2FuIGJlIHJlLXVzZWQgZm9yIFJJU0MtViApIGFuZCBsZWF2ZSBB Uk0KaW1wbGVtZW50YXRpb24gbW9zdGx5IGFzIGlzICggZXhjZXB0IGZvciBzb21lIG1pbm9yIGNo YW5nZXMgKS4KPiAKPiBKYW4KPiAKPiA+ICNpbmNsdWRlIDxzdGRpby5oPgo+ID4gI2luY2x1ZGUg PHN0ZGludC5oPgo+ID4gCj4gPiAjZGVmaW5lIEJVR19ESVNQX1dJRFRIwqDCoMKgIDI0Cj4gPiAj ZGVmaW5lIEJVR19MSU5FX0xPX1dJRFRIICgzMSAtIEJVR19ESVNQX1dJRFRIKQo+ID4gI2RlZmlu ZSBCVUdfTElORV9ISV9XSURUSCAoMzEgLSBCVUdfRElTUF9XSURUSCkKPiA+IAo+ID4gc3RydWN0 IGJ1Z19mcmFtZSB7Cj4gPiDCoMKgwqAgc2lnbmVkIGludCBsb2NfZGlzcDpCVUdfRElTUF9XSURU SDsKPiA+IMKgwqDCoCB1bnNpZ25lZCBpbnQgbGluZV9oaTpCVUdfTElORV9ISV9XSURUSDsKPiA+ IMKgwqDCoCBzaWduZWQgaW50IHB0cl9kaXNwOkJVR19ESVNQX1dJRFRIOwo+ID4gwqDCoMKgIHVu c2lnbmVkIGludCBsaW5lX2xvOkJVR19MSU5FX0xPX1dJRFRIOwo+ID4gwqDCoMKgIHNpZ25lZCBp bnQgbXNnX2Rpc3BbXTsKPiA+IH07Cj4gPiAKPiA+ICNkZWZpbmUgYnVnX2xvYyhiKSAoKGNvbnN0 IHZvaWQgKikoYikgKyAoYiktPmxvY19kaXNwKQo+ID4gI2RlZmluZSBidWdfcHRyKGIpICgoY29u c3Qgdm9pZCAqKShiKSArIChiKS0+cHRyX2Rpc3ApCj4gPiAjZGVmaW5lIGJ1Z19saW5lKGIpICgo KCgoYiktPmxpbmVfaGkgKyAoKGIpLT5sb2NfZGlzcCA8IDApKSAmIFwKPiA+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoMSA8PCBCVUdfTElORV9ISV9XSURU SCkgLSAxKSkgPDwgXAo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIEJVR19MSU5FX0xPX1dJRFRIKSArIFwKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKCgoYiktPmxpbmVfbG8gKyAoKGIpLT5wdHJfZGlzcCA8IDApKQo+ID4g JsKgwqDCoMKgwqDCoMKgwqDCoCAKPiA+IFwKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoKDEgPDwgQlVHX0xJTkVfTE9fV0lEVEgpIC0gMSkpKQo+ID4gI2Rl ZmluZSBidWdfbXNnKGIpICgoY29uc3QgY2hhciAqKShiKSArIChiKS0+bXNnX2Rpc3BbMV0pCj4g PiAKPiA+ICNkZWZpbmUgQUxMT0NBVEVfQkZfU0VDVElPTihoYXNfbXNnKSBkbwo+ID4ge8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiDC oMKgwqAgYXNtICgiLnB1c2hzZWN0aW9uIGJ1Z19mcmFtZXPCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgCj4gPiBcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgCj4gPiBc Cj4gPiDCoMKgwqDCoMKgwqDCoMKgICIubG9uZyAwLCAwCj4gPiBcbiLCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgCj4gPiBcCj4gPiDCoMKgwqDCoMKgwqDCoCAiLmlmICIgI2hhc19t c2cKPiA+ICJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIAo+ID4gXAo+ID4gwqDCoMKgwqDC oMKgwqDCoCAiXHQubG9uZyAwCj4gPiBcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAKPiA+IFwKPiA+IMKgwqDCoMKgwqDCoMKgwqAgIlx0LmxvbmcgMAo+ID4gXG4iwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgCj4gPiBcCj4gPiDCoMKgwqDCoMKgwqDCoMKg Cj4gPiAiLmVuZGlmXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAKPiA+IFwKPiA+IMKgwqDCoMKgwqDCoMKgwqAgIi5wb3BzZWN0aW9uIgo+ID4gKTvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIAo+ID4gXAo+ID4gfSB3aGlsZSAoMCkKPiA+IAo+ID4g I2RlZmluZSBNRVJHRV8oYSxiKcKgIGEjI2IKPiA+ICNkZWZpbmUgVU5JUVVFX0JVR19JTlNUUl9M QUJFTChhKSBNRVJHRV8odW5pcXVlX25hbWVfLCBhKQo+ID4gCj4gPiAjZGVmaW5lIEJVR19GUkFN RSh0eXBlLCBsaW5lLCBmaWxlLCBoYXNfbXNnLCBtc2cpIGRvCj4gPiB7wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIAo+ID4gXAo+ID4gwqDCoMKgIHVuc2lnbmVkIGludCBsaW5lX2xvID0g KCgobGluZSkgPj4gQlVHX0xJTkVfTE9fV0lEVEgpIDw8Cj4gPiBCVUdfRElTUF9XSURUSCk7wqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKgIAo+ID4g XAo+ID4gwqDCoMKgIHVuc2lnbmVkIGludCBsaW5lX2hpID0gKChsaW5lICYgKCgxIDw8IEJVR19M SU5FX0xPX1dJRFRIKSAtIDEpKQo+ID4gPDwKPiA+IEJVR19ESVNQX1dJRFRIKTvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqAgCj4gPiBcCj4gPiDC oMKgwqAKPiA+IEFMTE9DQVRFX0JGX1NFQ1RJT04oMSk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIAo+ID4gXAo+ID4gwqDCoMKgICooc2lnbmVkIGludCAqKSgmYnVnX2ZyYW1lcykgPSAodW5z aWduZWQgbG9uZykKPiA+ICYmVU5JUVVFX0JVR19JTlNUUl9MQUJFTChsaW5lKSAtICh1bnNpZ25l ZCBsb25nKSZidWdfZnJhbWVzICsKPiA+IGxpbmVfbG87Cj4gPiBcCj4gPiDCoMKgwqAgKigoc2ln bmVkIGludCAqKSgmYnVnX2ZyYW1lcykgKyAxKSA9ICh1bnNpZ25lZCBsb25nKWZpbGUgLQo+ID4g KHVuc2lnbmVkIGxvbmcpJmJ1Z19mcmFtZXMgK8KgCj4gPiBsaW5lX2hpO8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIAo+ID4gXAo+ ID4gwqDCoMKgIGJ1Z192YXIubXNnX2Rpc3BbMV0gPSAoc2lnbmVkIGludCkoKHVuc2lnbmVkIGxv bmcpI21zZyAtCj4gPiAodW5zaWduZWQKPiA+IGxvbmcpJmJ1Z19mcmFtZXMpO8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKgIAo+ID4gXAo+ID4gwqDCoMKg Cj4gPiBVTklRVUVfQlVHX0lOU1RSX0xBQkVMKGxpbmUpOsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAKPiA+IFwK PiA+IMKgwqDCoMKgwqDCoMKgIGFzbSB2b2xhdGlsZQo+ID4gKCJub3AiKTvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAKPiA+IH0gd2hpbGUgKDApCj4gPiAKPiA+IGV4dGVybiBjaGFyIGJ1Z19mcmFt ZXNbXTsKPiA+IAo+ID4gc3RhdGljIHN0cnVjdCBidWdfZnJhbWUgYnVnX3Zhcgo+ID4gX19hdHRy aWJ1dGVfXygoc2VjdGlvbigiYnVnX2ZyYW1lcyIpKSk7Cj4gPiAKPiA+IGludCBtYWluKCkgewo+ ID4gwqDCoMKgIEJVR19GUkFNRSgxLCBfX0xJTkVfXywgX19GSUxFX18sIDEsICJURVNUIik7Cj4g PiAKPiA+IMKgwqDCoCBwcmludGYoImJ1Z19sb2M6ICVwXG4iLCBidWdfbG9jKCZidWdfdmFyKSk7 Cj4gPiDCoMKgwqAgcHJpbnRmKCJidWdfcHRyOiAweCV4XG4iLCBidWdfcHRyKCZidWdfdmFyKSk7 Cj4gPiDCoMKgwqAgcHJpbnRmKCJfX0ZJTEVfXzogJXNcbiIsIChjaGFyICopYnVnX3B0cigmYnVn X3ZhcikpOwo+ID4gwqDCoMKgIHByaW50ZigiYnVnX2xpbmU6ICVkXG4iLCBidWdfbGluZSgmYnVn X3ZhcikpOwo+ID4gwqDCoMKgIHByaW50ZigibXNnOiAlc1xuIiwgYnVnX21zZygmYnVnX3Zhcikp Owo+ID4gCj4gPiDCoMKgwqAgQlVHX0ZSQU1FKDEsIF9fTElORV9fLCBfX0ZJTEVfXywgMSwgIk5F VyBURVNUIik7Cj4gPiAKPiA+IMKgwqDCoCBwcmludGYoImJ1Z19sb2M6ICVwXG4iLCBidWdfbG9j KCZidWdfdmFyKSk7Cj4gPiDCoMKgwqAgcHJpbnRmKCJidWdfcHRyOiAweCV4XG4iLCBidWdfcHRy KCZidWdfdmFyKSk7Cj4gPiDCoMKgwqAgcHJpbnRmKCJfX0ZJTEVfXzogJXNcbiIsIChjaGFyICop YnVnX3B0cigmYnVnX3ZhcikpOwo+ID4gwqDCoMKgIHByaW50ZigiYnVnX2xpbmU6ICVkXG4iLCBi dWdfbGluZSgmYnVnX3ZhcikpOwo+ID4gwqDCoMKgIHByaW50ZigibXNnOiAlc1xuIiwgYnVnX21z ZygmYnVnX3ZhcikpOwo+ID4gCj4gPiDCoMKgwqAgcmV0dXJuIDA7Cj4gPiB9Cj4gPiAKPiA+IERv IHlvdSB0aGluayBpdCBtYWtlcyBhbnkgc2Vuc2U/IEluIHRoaXMgY2FzZSwgYWxsIEJVR19GUkFN RSBjYW4gYmUKPiA+IHJlLQo+ID4gdXNlZCBhbW9uZyBhbGwgYXJjaGl0ZWN0dXJlcywgYW5kIG9u bHkgYnVnIGluc3RydWN0aW9ucyBzaG91bGQgYmUKPiA+IGNoYW5nZWQuCj4gPiAKPiA+ID4gCj4g PiA+IH5BbmRyZXcKPiA+IH4gT2xla3NpaQo+IAoK From xen-devel-bounces@lists.xenproject.org Fri Feb 17 09:50:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 09:50:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496975.767903 (Exim 4.92) (envelope-from ) id 1pSxNU-0007Qt-RL; Fri, 17 Feb 2023 09:50:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496975.767903; Fri, 17 Feb 2023 09:50:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSxNU-0007QN-MS; Fri, 17 Feb 2023 09:50:04 +0000 Received: by outflank-mailman (input) for mailman id 496975; Fri, 17 Feb 2023 09:50:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSxNT-0007Gt-ST; Fri, 17 Feb 2023 09:50:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSxNT-0007x8-Oq; Fri, 17 Feb 2023 09:50:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSxNT-0002wk-Fy; Fri, 17 Feb 2023 09:50:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pSxNT-000191-FX; Fri, 17 Feb 2023 09:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x0NJCwoL1LC4J1fTDTopDzwIfBSqe+f8D6Hb3IXW9ws=; b=lBl5JDXPSqr9AFl884jystRMVO da5Xs1eS88knA5/3co2ABCMzJbYDmcb7XQ9S27ZZaSEVl3YIh0o5rQju9GJBCm9XiVjfRlyGzak15 QZw4aV38ky3FE3mHPv38gbPpJ5Wc5LtxHpGJXHCewuQ8LgcRUIvFIEkZDZXSYbiZV4MM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177538: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qcow2:guest-start.2:fail:regression xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=2e52dcc853a7183784cd9bdfb1e78ff366035209 X-Osstest-Versions-That: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 From: osstest service owner Date: Fri, 17 Feb 2023 09:50:03 +0000 flight 177538 xen-unstable real [real] flight 177584 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177538/ http://logs.test-lab.xenproject.org/osstest/logs/177584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 22 guest-start.2 fail REGR. vs. 177428 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 177584 pass in 177538 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 177584-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177428 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 2e52dcc853a7183784cd9bdfb1e78ff366035209 baseline version: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 Last test of basis 177428 2023-02-15 22:10:26 Z 1 days Failing since 177485 2023-02-16 10:25:30 Z 0 days 2 attempts Testing same since 177538 2023-02-16 22:08:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Michal Orzel Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 2e52dcc853a7183784cd9bdfb1e78ff366035209 Author: Xenia Ragiadakou Date: Thu Feb 16 10:15:35 2023 +0100 x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback APIC virtualization support is currently implemented only for Intel VT-x. To aid future work on separating AMD-V from Intel VT-x code, instead of calling directly vmx_vlapic_msr_changed() from common hvm code, add a stub to the hvm_function_table, named update_vlapic_mode, and create a wrapper function, called hvm_vlapic_mode(), to be used by common hvm code. After the change above, do not include header asm/hvm/vmx/vmx.h as it is not required anymore and resolve subsequent build errors for implicit declaration of functions ‘TRACE_2_LONG_3D’ and ‘TRC_PAR_LONG’ by including missing asm/hvm/trace.h header. No functional change intended. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian commit 727bf4cd0751782d100603a076f0e66f218cc3b8 Author: Jan Beulich Date: Thu Feb 16 10:14:49 2023 +0100 ACPI/CPER: use standard C types Consolidate cper.h to use exclusively standard types. No functional change intended. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 91c45cfbab5d9878c0a7021f762988a688d5e91d Author: Michal Orzel Date: Mon Feb 6 14:05:28 2023 +0100 xen/arm: Print return code from domain_create and construct_dom{0,U} on panic This might be helpful in providing additional debugging information (in most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the code to include printing return code in panic message. In create_dom0, move the call to alloc_dom0_vcpu0() to a separate condition and call a meaningful panic message. Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini commit 768e405feabe58effbba75e5b1f782d678119c60 Author: Michal Orzel Date: Tue Feb 14 16:38:42 2023 +0100 automation: Add a true dom0less test on arm32 Add a new test job qemu-smoke-dom0less-arm32-gcc-without-dom0 in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test dom0less domU boot without dom0 (i.e. true dom0less configuration). By passing "without-dom0" as a test variant, the test will clear the dom0 prompt that we grep for as a last step and remove all the DOM0 related options in ImageBuilder configuration. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit d28b226244abcb4b32e07de52df96b6b1686a240 Author: Michal Orzel Date: Tue Feb 14 16:38:41 2023 +0100 automation: Add a gzip compressed kernel image test on arm32 Xen supports booting gzip compressed kernels, therefore add a new test job qemu-smoke-dom0less-arm32-gcc-gzip in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test booting a domU with a gzip compressed kernel image (in our case zImage). By passing "gzip" as a test variant, the test will call gzip command to compress kernel image and use it in ImageBuilder configuration for domU1. No need for a specific check to be executed from domU. Being able to see a test message from a boot log is sufficient to mark a test as passed. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit a6ce51ac3de8267ed4e2e7f2e1cf93d51c6d797a Author: Michal Orzel Date: Tue Feb 14 16:38:40 2023 +0100 automation: Add a static memory allocation test on arm32 Add a new test job qemu-smoke-dom0less-arm32-gcc-staticmem in debug and non-debug variant that will execute qemu-smoke-dom0less-arm32.sh script to test static memory allocation feature. The test case itself is directly taken from dom0less arm64 testing. Populate build jobs to compile Xen with config options necessary to enable static memory feature. Populate test jobs passing "static-mem" as a test variant. The test configures domU with a static memory region (direct-mapped) and adds a check using /proc/iomem to determine the memory region marked as "System RAM". Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit 42ea8ddab8e003d272e897abec0b89270a90a9b0 Author: Michal Orzel Date: Tue Feb 14 16:38:39 2023 +0100 automation: Add arm32 dom0less testing At the moment, we only perform a single arm32 test in our CI, checking whether dom0 boots successfully or not. This is mostly because we do not have any arm32 runners and we only execute a hypervisor only build. In order not to leave the arm32 testing in such a poor state, add a script qemu-smoke-dom0less-arm32.sh to start testing dom0less configuration, while keeping dom0 to make the test more interesting. The script is mostly based on the one used for dom0 arm32 testing as well as the one used for dom0less arm64 testing. We obtain Debian Bullseye kernel and Alpine Linux busybox-based rootfs. Depending on the test variant, we prepare a test case contained within domU_check variable, that will be executed as part of /init script from domU rootfs. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit a35fccc8df93de7154dba87db6e7bcf391e9d51c Author: Michal Orzel Date: Tue Feb 14 16:38:38 2023 +0100 automation: Switch arm32 cross builds to run on arm64 Due to the limited x86 CI resources slowing down the whole pipeline, switch the arm32 cross builds to be executed on arm64 which is much more capable. For that, rename the existing debian container dockerfile from unstable-arm32-gcc to unstable-arm64v8-arm32-gcc and use arm64v8/debian:unstable as an image. Note, that we cannot use the same container name as we have to keep the backwards compatibility. Take the opportunity to remove extra empty line at the end of a file. Modify the tag of .arm32-cross-build-tmpl to arm64 and update the build jobs accordingly. Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Feb 17 10:32:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 10:32:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496990.767917 (Exim 4.92) (envelope-from ) id 1pSy2A-0005Hg-2r; Fri, 17 Feb 2023 10:32:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496990.767917; Fri, 17 Feb 2023 10:32:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSy29-0005HZ-VK; Fri, 17 Feb 2023 10:32:05 +0000 Received: by outflank-mailman (input) for mailman id 496990; Fri, 17 Feb 2023 10:32:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSy29-0005HT-2q for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 10:32:05 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f90c803-aeae-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 11:32:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f90c803-aeae-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676629921; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0jeOrVtcwdhfCtoBJS7aO6anVTkScd2Z7HWOwKPjLHA=; b=fD4c//gM0Uw3rlNLlCFxHP+3QY0cg/DsUWPo0Hy/gS8svhewDFBLMsaK xtR4HPyIPBz1XoJ2/w2hugQ+zlUwRlrx5dAQFvp7EFA0JjwwSQY1n+kja HOFAlE24glJhmPOiRWAL/HH/tUrIJFnfIsZmfqM3rcaBFegNkJfBEs6yy Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97366394 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:yMIMY6ONPfINIZzvrR1ul8FynXyQoLVcMsEvi/4bfWQNrUohhTEHn TNKD2GGPfaOYzf2Lt8nO4m+pB4D65/Ty4VmTwto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wNmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sBbWEdt8 NMoEjMcLQ2Ghf+8wpGhbsA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUo3VHpsLxRfEz o7A12f8JB1CLe2v82K6qCu8ouj9oSyqG7tHQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFamlBMBX9tbE8Uh9RqAjKHT5m6xHXMYRzRMbNgnss4eRjEw0 FKN2dTzClRHr7m9WX+bsLCOoluaOzURLGIETT8JS00C+daLiIgrgwjGVNpLDK+/hdqzEjb1q w1mtwBn2e9V15RSkfzmoxae2WnESoX1ohAdwCmOeEGgwTNDZ5/meomq9FLZzuxkBdPMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1HsyDaJz9zq3+KTJrU3YE c7CGftA9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLFulYbwHSNrBit/PsTODpH zF3bZbi9vmieLemPnm/HXA7czjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/F/SU9UNokihrc+Rp ivVchYBmDLCaYjvdV3ihoZLNOm+Av6SbBsTYUQRALpf8yNyO9j2vPxBLspfkHtO3LUL8MOYh sItI62oasmjgByek9jBRfERdLBfSSk= IronPort-HdrOrdr: A9a23:eTwP6qgsePl44WPQnaVXdo3WM3BQXuUji2hC6mlwRA09TyVXrb HWoB17726NtN91YhsdcL+7Scy9qB/nhPxICMwqTNSftWrd2VdATrsSibcKqgeIc0bDH6xmtZ uIGJIOb+EYY2IK6/oSIzPVLz/j+rS6GWyT6ts2Bk0CcT1X X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="97366394" Date: Fri, 17 Feb 2023 10:31:50 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall Subject: Re: [PATCH] tools: Remove the use of K&R functions Message-ID: References: <20230216231636.714006-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230216231636.714006-1-andrew.cooper3@citrix.com> On Thu, Feb 16, 2023 at 11:16:36PM +0000, Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > xg_main.c:1248 error: a function declaration without a > prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] > xg_init() > ^ > void > > The error message is a bit confusing but appears to new as part of > -Wdeprecated-non-prototype which is part of supporting C2x which formally > removes K&R syntax. > > Either way, fix the offending functions. > > Signed-off-by: Andrew Cooper Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 17 10:38:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 10:38:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.496999.767928 (Exim 4.92) (envelope-from ) id 1pSy82-0005zr-Tk; Fri, 17 Feb 2023 10:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 496999.767928; Fri, 17 Feb 2023 10:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSy82-0005zk-Py; Fri, 17 Feb 2023 10:38:10 +0000 Received: by outflank-mailman (input) for mailman id 496999; Fri, 17 Feb 2023 10:38:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSy81-0005ze-2z for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 10:38:09 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28e1f44c-aeaf-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 11:38:06 +0100 (CET) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Feb 2023 05:38:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5480.namprd03.prod.outlook.com (2603:10b6:5:2d1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Fri, 17 Feb 2023 10:37:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Fri, 17 Feb 2023 10:37:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28e1f44c-aeaf-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676630286; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=x5NxroGGI8Keq7tP8qcB3vZgI8nQYVvg3WrvcPA3Cn8=; b=AYzbFIYLJwWWV5EmRk3NHZ3lWHYz8NOLQbuFnzavgUZHK7nS1nglEowM UoyUVclfSUFKwDegWJ53qZLgvwF5JWMMwMgs4FSL8K++xrk43xAZCne74 US1sOWMWWp2zf6PjbqDYfuoSWf56cVQFSYr4tQIb38qehJMb8Dn8nQPjS 8=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 99872934 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23://cwO6i7XeU0oKT1YdjWu3LCX161QhEKZh0ujC45NGQN5FlHY01je htvWmqEP/zYM2D9copzPY/npx9QusOExoBlGgpkrHxmFSsb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaBzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQnJysWShWhmNnq76vrQao3t9oBKfjkadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGyarI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RezoqaQ72wH7Kmo7FyEpfkC88aKAuxCndtx0B U82/DACsv1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebR4A2 0KNntjpLSdyq7DTQnWYnp+LqRuiNC5TKnUNDRLoViMA6tjn5Y020BTGS485FLbv14KvXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:WjOt0q6OQQaki13LLgPXwPXXdLJyesId70hD6qkRc203TiX8ra uTdZsgtCMc5Ax+ZJhCo7+90cu7MBbhHPdOiOF6UNuftWHdyQmVxepZjbcKrQeQfRHWx6pw0r phbrg7KPCYNykCsS6wiDPId+rIGeP3l5yVuQ== X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="99872934" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGrPnsLjUE4X7wDSpLkOc3vMbMNcclQXJW2Be7TnLeXl0Q6L1HzsfRRU6Z2/bg5TJjMCR+N+56mKyX1U7vvOWgYwYKdx1eeunGKfvpVbMJNOVMppC+goNWKUtPIXceicQDUsrvki7puE5mXhY18RUSd6rCuTrpGN+iQLenFfCFsicCcT64TBKkdt15rplf6GgaIqAuQCLt+SRmwB9z+vT88FQxb7t2zOA+M3M/pndJUcvYwOOxG7EWQkKn9JHEpb0Iy2sOc6pr8O1rSV/XsPOojOXYWpHStKL9XGztVqyXZ5CtP5uJksGW0H35onv+HtXms1ZbtmAbgnf4krknIajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxNENVWF8iIo6WjdZsWWx3T8vnzZOKV0t+7laPKuVoo=; b=HwOkLmkQlecLt0MdHvUpUicc/jE4mVrIm+em1KIQeYacEOsuMp5zluoxfO/ng6BoUD6MMltRbNkfw+i8dp83zdV2pT4LL0a0fgonu5WjCPYikJwchW9mH+Q3B0QIW2msUz3CpQBeToICP4Y2IRrg6vpwSao0CqfE4nIiFiAyXF6No3Sb9h9jmS6Hb8vJ8QCZ0JAmG7ytgpJk5YCQ6q2JsWf8SSZM2mlEfaveOsPqYkvm4LBMpZVbspTNZ9wWXvwj4zohIspX3EQt7Obxp7ukahej78y00li2V6+zuwaxX2pWKUC0DMe5b7qqAWGDtdMd21M4nQA192pIz2vSupGL5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxNENVWF8iIo6WjdZsWWx3T8vnzZOKV0t+7laPKuVoo=; b=uC/wp6zBNjt+fbmjLhpckP3qASFaklPZXPo+9rU2bFW8SkQj+LkVFy3xPsdLvAoz3j4pN+j/mCT31ati8VomxaxmtjrSkR62s48zVQwldC0S6W3Fl9ZmSFUC54yPED/iYgXggS7RYXKWXV01T1RVZPLNc9a2RS879iy0pmHfRX0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7c062574-4c00-e0e2-cd65-d37dbdb91122@citrix.com> Date: Fri, 17 Feb 2023 10:37:53 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH RFC] xen: Work around Clang-IAS macro expansion bug. Content-Language: en-GB To: Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217001914.762929-1-andrew.cooper3@citrix.com> In-Reply-To: <20230217001914.762929-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0164.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5480:EE_ X-MS-Office365-Filtering-Correlation-Id: faa66a92-cb4c-4c92-c7eb-08db10d30967 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ckBHTbePXlNpqv81e6ctccanV8dGFM58y7PAD5lNQzamaQuVko+thnDqH09dwkepKfCPKEQJkW4tyNWRNpM4xc7h3IM+st53FAtRGfoTDTUQkn74P9IPLcitihWCs2W43UG2OqggaMvPbxthzL3KrkByxsP7MMya+FVuggHMsI8RMEkZlEvgn88nhKUp7i0p0G4i6xpGUL959l9pOKDLmbGxfgCZQ7jOiVQPAEtamTZG+mS/2svnbr730AAkJUGp+RZKIc7ZKtbJvyK5SzFTRCnPDrc6O8csuJ3XGU3aojbNTgvWZgEHEVDwZFEsuOdGJ7XvVv6werl/zzlKUTYENEwZ0GXfTS9OtCV1sw2UHyGnd8S028H9ZEdW/RSMOVArDbN/aS3QUad1Dh99AqxiUFy7S/BlC5PrH/zUoINsONae0sBLX5J8dkzjiepiiD/ItAeW707eDqTS8MIOjsJGpO2xzzW7CdbctLPt31ZSUIn1A0WO2/Qv1aniitPDMIunGcNYLUxyz7mG7fgf3Yj99hGrK0LI2IbkxxN+m2rL3LpBeF7nRRU/213UWbq0zsQ+KfnLXHE2cLtQD7ktOy/mx6mE7tJCqB9ECj0LNN6pXB1NdMvokp8hKWx9/yo4jiQO8PcwziGq2AsdlyaNVL6Pdqzqn2d1lmK8QRatfzxjwSWqqsyCrHmhpsoffJUf+9LP/2+MRiiHjGmvHlpfwUxhHvJ1hMssWIxK3bhnFYpAdAU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(451199018)(41300700001)(6916009)(66476007)(66946007)(8676002)(66556008)(316002)(4326008)(8936002)(5660300002)(6666004)(2616005)(53546011)(6512007)(6506007)(186003)(26005)(478600001)(54906003)(6486002)(966005)(4744005)(36756003)(31696002)(86362001)(2906002)(82960400001)(38100700002)(66899018)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVOSTNoemZRSEV5WGJjdnF4YlFKdURSWFNZVGxnMTViY1A4T2pVTGwvR0hP?= =?utf-8?B?TE53OE1XYWhsdk5Odnd0b2dxbkZzK3ZSY21FOUpTNzBsWFlISkQxV1QrTmxm?= =?utf-8?B?aEdxdWhaSGtsZ25zQ2hWSThiRkNlMkxLNURDdUlpTkVhWUFmN28yMk1wb3dz?= =?utf-8?B?djdscFhoblpORUU1ankwcHo4QWVVRG8yUkY2Z2NBV204aHkrc0d2NWVkTlc4?= =?utf-8?B?T3R3RWlSWVltL1dwd3RTQlNPYzRidTR3OTVWbzAxRXNqYnZHa0YzajdzRGtR?= =?utf-8?B?T1NPa3I3VzJHSXhiejUxa2dqS1N0WDUxbkF1MGtFb3ZpM2p1VUtCRERrSHB1?= =?utf-8?B?MEFPRUNNYk9OS3d3dzBZaE9VZkp2Vlh6VWo1cS96TXhZRFV0azR5QWNFVlRO?= =?utf-8?B?VVpkano4NEVHQW80L290VHRkazdQeVVjcGVvM3BQZTdaZVdBZHhRR2FSUDRo?= =?utf-8?B?b1dNOGk1NVFzTWlIS0Q2eUpvVmxjV1BZbytVTzRBWldSb0pWcmJoZjFaVkw4?= =?utf-8?B?cXYxc3Z6OFBoY1JkWEJXb3VSZi9DOERsUXoxa0s1OGdLN2JXaGs0QUZKeVdP?= =?utf-8?B?YjVMTFJTZHhtYW9SVUM2VjNLMDBQbStLRXdxWEo0cGpTeHFmVm1scUdLTzVh?= =?utf-8?B?UVpYYm1BSWJiQVZlakhsSkdIbHhyTWUrL2U5dXRMNDQ5RUY3Q0E0SWlDSlFH?= =?utf-8?B?R0diZ3l4YXg2QVdxNVgzaFZFVkhBMi90VEtmVUM3RmszWVRkbGdnZFR4S2M4?= =?utf-8?B?WlVZenRIOXZseTJxZ3ZUWTVlZ2pkK3diZUZ6R1pidjEybmpBa2lsL0NtSUlE?= =?utf-8?B?ZHppaDdmYWREOTEzZFg3QVVMa2ZiMGVKRmY3cHpRUXhvSi9LR1l2cXBaYlg5?= =?utf-8?B?S1RiMEI1Q1kyWEpnWjYxcG8rYysxQnY0UUtOVDNPbXdyUjhqN3AyYXI2V2FN?= =?utf-8?B?Q3lqWUEvbkNMN3Y5RXhieTlNOXprNzNKN2wwc3FvWGZuS25ITkhLZXFPMmRk?= =?utf-8?B?YVhlQmE1VVVyOGtPZzJjK3NySHF0L2RwNlhIV2hCT3FtU21jZHlydFZWYy9V?= =?utf-8?B?ZGdlS0I1S2pOb3FNQUUxRnppNWhuN1JGVTBuTUZObE9aYXBrQ1hwRnZlK1pk?= =?utf-8?B?aDJPOWdOQ0ExeXZRRm5YYjVsTEtRcDRtTGZIakxDSmFqb204OG90c3pNbjFD?= =?utf-8?B?eTJrY29DRy9YVDBXRWh3cEY1KzNBZ2czSmxMWVVYR3ZzUUFFN1g0TW5wWmhs?= =?utf-8?B?TGt4eFRDbWVmNWt4NFBDenRhdlhwZmJtaURycjRJZnpqYXVKWGFGWkxSckVq?= =?utf-8?B?UExCdDY1bXlJWllJb25GeWdrUURwYzhHU1N3WkJ0RjZPMlVLZ0c4N0JQdmtC?= =?utf-8?B?TkE0YWJPOVorR1lmaEw0YnVJTm5aQWV0R0JUZjM0bytKVDJBVk10bmY5Vm9x?= =?utf-8?B?MVAvbXpveGgxUGpFNzdrTCtEd3pnODlLdTZISXhiOW11bjNPVzhlbUdpY0NS?= =?utf-8?B?bHpBVTl2aThHeEdVQkk1Q0dvMTV4TGZVZENMN0FXSnNDYm1BL2c0clRxVFNt?= =?utf-8?B?dVRHZmxGRHNGRHFlditLVGh2MGdXeVJ6UG9HL2VJWUNTbldnc0RhNzVobG5i?= =?utf-8?B?UlJMMWZSV2sxTURjaFpBUXlRRDhlcVJhTTc5YlBNZkRlUm10ZFZyVU9YcDdM?= =?utf-8?B?N1MxMUNHTFc3S3hTWDRXMmpTRjBJR1hmd3h3cFdwT0RRS0NCOWhTckYzdHBt?= =?utf-8?B?TC80VDR1Qk5zTC83M3JGaTYxd3pxSVMzU2c5dDU1TVZYR1k2eEtjTXNla29Y?= =?utf-8?B?MXpOemo4a3NhZnVEWnpNTE96WXRmOHdRUGo1aWdHRlh5enZYUkZMK3FsT1Rp?= =?utf-8?B?YWhzVnVxdU5sSlg4M2FBZ0RGU0ZVK0pxU01oeWl0dndkTExrM1hRMVE0Vmt6?= =?utf-8?B?aGhPRFh5ZjdOam5XNC9TRTZuWndZYmpjMHhiUFdVZnlQUGg2QStZWWhFTDRn?= =?utf-8?B?djVaUVNRYUw4cGtHRWlwYk5hL09pNkRsWXhQc05ES3FIZ3l4NkROMnpQdnhy?= =?utf-8?B?S3h4TDFUdnY4MmRENkk2MjlHOVhpN0FDZHI1RSt6aURjSGR6WUR1RDFKb1p6?= =?utf-8?B?N0U4UFMrRnhvNHdtak1nK3d3MVdmbmw5NWU4SUg4MmUvVXJ6OGIwOVorME5D?= =?utf-8?B?alE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZwictesZvUdJMCJYDm+GfNTj0Db3es4KtqhoyPjNhOAhtes1SnBg2aEkeDsZWHU0jXFPTFpb+iyJvBsYp5uoToF1XJyZjuJ6pYTTv4IPk2EcFdwjFJPaZliFi+3gVcE/iiuafCAIV7J72u/v9uhNF0hu1+oBxTBDwixF77d39Kw8YvLzyU6vlFIxlygN4BfH2IQw6qV1KOdZ/ou7xmMl0HUbf0ZmPIjpV5K9Nenyg+RxsAtQ+M2MTX5ztW4q96zPH5yxtZmRm1n1GTLiFqhukOvTV0VmopkchxR/6m7MUfdJOu3V45fhd0EK9bw6HLmzbEKBCq5A8w0dMujqur0zS+PxMuwMPTBB27Amdd5MfEw1Dr2Tpbgrju8hJ2TEnT5gj0F2+DzLgpiRXUDdLgi62sMLll/sm5wjOwMqkyZeWMmxKVnutGHBuge4TlNlfk61MU5gGEvVHVxIuIP0QR5FcdX6qAnyT9AZTNe1M0a3ZqDwrcZSM6wivOdQCqkBDgAXYh7DwB+1Btyu4Mr6eRF1miAFdbn/X9QcRQJj3BlleEN6H+q8YafAADxiFtTqEGoZdyfeqMJCsJnGgoXauiMGvcflSwA5DH8ZHCQ22P+dpXhNGDLiOswsj2L1mZ9sdEMQ4lW8my7nmRF3cpMO7jFX5w9qal7m4bpc38LY7dIZj3/M0tCo8ib7j51uA+7bUcxi0GG7Pxi6Jl2EEW54LAxO8K1REKErNWmrTie3VZaEomGbj/QxobtVlAuTHSW9OaOlTefSGviKMh08Su2u2Agq/cRAwOLvSgnIBuivrjuK56a6BoF6UB/NY4njc2ZHfgSuTPQCQ9ut5KGIC3sX0y0gPA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: faa66a92-cb4c-4c92-c7eb-08db10d30967 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 10:37:58.7653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hyj+kOAVL3sQCbJsfwbg/dBep9u4g68gY1JytDgzIFkHWCGn3S408u4nwF+7+rMfozGJzJhIsMfRBQ54vmbIWlS8Al0LoBoNuw77Z2qacYY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5480 On 17/02/2023 12:19 am, Andrew Cooper wrote: > https://github.com/llvm/llvm-project/issues/60792 > > RFC. I very much dislike this patch, but it does work for me. > > Why the parameter name of foo? Turns out I found a different Clang-IAS > bug/misfeature when trying to name the parameter uniq. > > In file included from arch/x86/asm-macros.c:3: > ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] > .L\@\uniq\()fill_rsb_loop: > ^ > > It appears you can't have any macro parameters beginning with a u. It's worth saying that I can't repro this in more simple setups, so it likely specific to some of the gymnastics we do in asm-macros.c Also, I was hoping to try and sort out the macro such that it had .macro ... uniq=\@ reducing the internal complexity, but I couldn't find any form of that that GAS was happy with.  Suggestions welcome. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 17 11:11:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 11:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497019.767942 (Exim 4.92) (envelope-from ) id 1pSydm-0003IU-Fk; Fri, 17 Feb 2023 11:10:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497019.767942; Fri, 17 Feb 2023 11:10:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSydm-0003IN-D0; Fri, 17 Feb 2023 11:10:58 +0000 Received: by outflank-mailman (input) for mailman id 497019; Fri, 17 Feb 2023 11:10:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSydk-0003IH-TA for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 11:10:57 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be417966-aeb3-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 12:10:53 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id x4so982316lfq.2 for ; Fri, 17 Feb 2023 03:10:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be417966-aeb3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wpmpZLoUmhLRqdF+ixXFaxKZLHqcK6OTa0Ulfvt8tLo=; b=dkiWKNaeR6WLYVwIT6gqimJcgci6RB0U8ynBKLbo9jrGSCpcAybwRUwjpxUc2vWeBE EADMIHcU1iWVqMWdR8Tsedq5IezBvJ+j2G5aU4IWdie+z/hVWOZ6uPC2xdOraptWEaUC DbpQVNo2F+Wg+xB1aaOssZyIao8aeNJVMI44k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wpmpZLoUmhLRqdF+ixXFaxKZLHqcK6OTa0Ulfvt8tLo=; b=WHPIzZhAYLXjZzHkA46DOuM5h/gD82WS/YsWO95EKxSuCC7vtLDLE8MDfinC8UK5LM rjo2h+9SgxVkSgNLDH6rsE10+hIJTmj2nbDDl7N3Rh6BKI//NStfn8dFD/uDtZp3fEvT A+eEf4FvltPXipYHoWpm5ow+7XIP+545mrEAmJTauwHyIP73gi2Vva/j4f4zwGu3JTQp hckdzqEchF4QK9Z0JxFLMG7TFNIuBvkbPuCYie6w6SMbiEqoMtc89YVwq58qvn0Wq0kF +F/kO7bROKudCeEyou7DVsT8qy5xUlg1yjZP2Cn6I1fecrj+9xI75dN5owZF7JuGxrF9 Ai6g== X-Gm-Message-State: AO0yUKWVCcEZl4jQmNBTVAimc2ijYCZCTjiMAJvZeqKY8ISOr5ur5PZx OPC4PuWozAX8aaSw/HGwWKrOnWYvaikTHKcWxFXqSw== X-Google-Smtp-Source: AK7set/hsKn/wYSbufDtnW2LPTdQy7w9+nVRkW6tBhepuuk/F95t8MBGs8FUT6k+BWeanlgp/EyH7BKDURmd4COmHzU= X-Received: by 2002:a19:ac01:0:b0:4db:3ab7:79ca with SMTP id g1-20020a19ac01000000b004db3ab779camr318306lfc.8.1676632252798; Fri, 17 Feb 2023 03:10:52 -0800 (PST) MIME-Version: 1.0 References: <20230216231636.714006-1-andrew.cooper3@citrix.com> In-Reply-To: <20230216231636.714006-1-andrew.cooper3@citrix.com> From: George Dunlap Date: Fri, 17 Feb 2023 11:10:41 +0000 Message-ID: Subject: Re: [PATCH] tools: Remove the use of K&R functions To: Andrew Cooper Cc: Xen-devel , Anthony PERARD , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Content-Type: multipart/alternative; boundary="000000000000d8ec8105f4e35d3c" --000000000000d8ec8105f4e35d3c Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper wrote: > Clang-15 (as seen in the FreeBSD 14 tests) complains: > > xg_main.c:1248 error: a function declaration without a > prototype is deprecated in all versions of C > [-Werror,-Wstrict-prototypes] > xg_init() > ^ > void > > The error message is a bit confusing but appears to new as part of > -Wdeprecated-non-prototype which is part of supporting C2x which formally > removes K&R syntax. > > Either way, fix the offending functions. > Nit: This says "functions" (plural), but I only see one function being modified in this patch? Doesn't matter too much but might save an archaeologist some confusion if someone were to fix this up on check-in. :-) -George --000000000000d8ec8105f4e35d3c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Feb 16, 2023 at 11:16 PM Andr= ew Cooper <andrew.cooper3@c= itrix.com> wrote:
Clang-15 (as seen in the FreeBSD 14 tests) complains:

=C2=A0 xg_main.c:1248 error: a function declaration without a
=C2=A0 prototype is deprecated in all versions of C [-Werror,-Wstrict-proto= types]
=C2=A0 xg_init()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 void

The error message is a bit confusing but appears to new as part of
-Wdeprecated-non-prototype which is part of supporting C2x which formally removes K&R syntax.

Either way, fix the offending functions.

Nit: This says "functions" (plural), but I only see one functio= n being modified in this patch?

Doesn't matter= too much but might save an archaeologist some confusion if someone were to= fix this up on check-in. :-)

=C2=A0-George
<= /div>
--000000000000d8ec8105f4e35d3c-- From xen-devel-bounces@lists.xenproject.org Fri Feb 17 11:13:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 11:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497025.767954 (Exim 4.92) (envelope-from ) id 1pSyfh-0003qw-SJ; Fri, 17 Feb 2023 11:12:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497025.767954; Fri, 17 Feb 2023 11:12:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSyfh-0003qp-OZ; Fri, 17 Feb 2023 11:12:57 +0000 Received: by outflank-mailman (input) for mailman id 497025; Fri, 17 Feb 2023 11:12:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSyfg-0003qi-IS for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 11:12:56 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05569297-aeb4-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 12:12:54 +0100 (CET) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 17 Feb 2023 06:12:49 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6990.namprd03.prod.outlook.com (2603:10b6:303:1b9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 11:12:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6086.024; Fri, 17 Feb 2023 11:12:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05569297-aeb4-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676632374; h=message-id:date:from:subject:to:cc:references: in-reply-to:mime-version; bh=gKJYXNh7M0FtffvLLmo9tqFjQPvGHUA3fef9zCMyXKc=; b=KOHx2LGwvqs3Zut+4nLX/WUX/XkKyxxOkF34R4Raf2+kmLP1DuwZRcQE eDYJQGcxlgPsLwvz/bwHT6dfNGbNbTochsKYj4r3AVBmxAi99Xs9r22uX D9nsZNgAy/WbyUPEOW4A/3HOwvdShhvIUG/Wr8T03XDV53zJGYw65kO1+ 8=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 96845219 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xI6trK74p4KTQcyor+T+iQxRtNXGchMFZxGqfqrLsTDasY5as4F+v jdLCj+BMvfbYWL2fdl0OYy38U5UusOGxoUySFQ/qSo0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 M5DEjcGNxe5h/OG+5iDT/RtjOUaI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+CF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMROHlrKc76LGV7kk8UScPSgqrm8aaqG2VYI15N kow9gN7+MDe82TuFLERRSaQr3ODpBERHdZNFekz8CmGzq3J70CSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaGwIYMGsDbi8sVhYe7p/op4RbpgnUUt9pHaqxj9v0MTL92 TaHqG45nbp7pdEP/7W2+xbAmT3EjprUSg844C3HU2Tj6Rl2DLNJfKSt4FnfqPpFcoCQSwDbu GBewpfGqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:YkNqWq04kqULmW3N7dN8oQqjBGAkLtp133Aq2lEZdPUCSL3lqy mLpoVh6faSskdoZJhAo6H4BEDkexnhHPFOkOos1NuZPDUO/VHYSb2KjrGSpQEIeReOlNK1jp 0QCZSWYeeYZTNHZITBkW2F+r0bsb66Gc6T5Nv2/jNEURxtcK146hcRMHfnLqS0fmV77FgCea Z0KvApm9NoQxoqUvg= X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208,217";a="96845219" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRDBG1ObGV/YFl/O9ivrmaiCUVyYL4aLkMogbgw1OHfU2kLJElEIQolKyk5NgjIV62iXtaNZv0sSkqvzLVNjOyP1NrR8SWCAm/ZFCkaa+lEVgg81Y1CCwncm2478FC84qs3LoZIxUUxB1s9L6ISENFvSIQ4xUl4/5zfVofAsEMmFH8Zhd6WBZ1xUCN2N4Ntqp/ZZOpcl86ViCpvDdC4UAMvgEQV3UT6Nz4ogKjdMmHNzq8HZKDssOuh+D2qzkNVLti9v4RaDSBtyl2F1EVEi9L/5cR7+nJud+eJuvMKWofb3iuvPhe4s9CPaFq+0gXtk0UBXU/IMnIG2LnApsc3vpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qptmatrl1jrfmwiJYqpMfXHZ3BDToA7+rN/yVyHhoTM=; b=jrvYnH2tLZ9f4bSEkpFUEwLnlZDw/HwgNg08Rsib186ZjShOLi0t8VrmVjJYSFUK0qQVHKUwD795eXFv37c2oimKUlg5qd/9cPkCm/6UHtEvel4CQ3TABEfg/Fazr1YIZllWa72IMKEKb59zJEm3cz1g3qx+Vk6mSSse78jbBhvY5e+WCqqgn24Bkdv97mLXy62btm8BcCgHl34H47XghbbgN/L4lOaoy+XGG6BiUqD6DvHcQxQErkrps1Pr2nmmyqj9xeFOs4NLd47tkAIYQ7WVf+ZjM9o2LOM9mQUbiWkIqrtPz1O3T+PTGS2lxYMVcKbH0DKoKk3h3M3AEhtdhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qptmatrl1jrfmwiJYqpMfXHZ3BDToA7+rN/yVyHhoTM=; b=jQrrxin/msMRW+ksdzqj5e86kS6LuqiRBoWjvhLDjKq08TzVsTutaG/hQbkjwLT05tMPeB7QgKDlDYQkrqcSOdCJpdvp1ZxO79R0XDiR8URtzrTBFrfmKJipnlGg3jtN3H7xyxXgJFLOik71RQsJmv8xe6qAr6HEsoxAVGuT1Ss= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Content-Type: multipart/alternative; boundary="------------LqKo3VsnUwEadxeTZXot0vMz" Message-ID: Date: Fri, 17 Feb 2023 11:12:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] tools: Remove the use of K&R functions Content-Language: en-GB To: George Dunlap Cc: Xen-devel , Anthony PERARD , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20230216231636.714006-1-andrew.cooper3@citrix.com> In-Reply-To: X-ClientProxiedBy: LO2P265CA0296.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6990:EE_ X-MS-Office365-Filtering-Correlation-Id: e233a8e5-82a9-49e3-a810-08db10d7e693 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bBM0Ujn429JT1kcEL5ICt+rpjCihyU3sMSYnGJUnsBd4s5sHe8qinWWVSGOk/tUdQriiXg0CK3+JeuPtwWfh5DWx+NvDdhjgoY64x6Rf8M3PZyl72O5X2AuP1RBj7duqNtXksXYJUK++Gam6AxYWatb3se+xVtCjN824hpBiTzcA0/nAFycJ3QCt1Nm1E3h9SMBmCfcSs33QHyH9hBlyH6ZOYAccboCaniZgcnZ4kR6Gz/NUDtcwBaJ6/ZyoQC+eGONSHQlKBo+eVoh/oO6pOFPRSZLFO9IvLEQPuqgEn7gsBaRsqx6UdIOc1sFbCXl1DxcG2jc0iMx7UwlAf/6ea5NkoCAJD2XnExyIOcCE6nofxDTC7kf0LPj5mSi7eZyPugg+5VLQCgbhZLyGv0WwjJvHD8vBNFZonuepEZbz8iStUxV+/RDO0zVq2tG0Y0DoNGlb7F3dmxcu1NJsx535kKsSEun4yTTnVZpeDceT8eCiEBH6PYO35oZvGfDvu2NMpweJH05nHH9P9iw9sN4+85q6qo2z+Y7uwGpXUoO4T3Ry93O7As+iSlqHrOVM4885YtXJMWwPyWL+E7UWhnOMGsbitLMtZXP1ZPw/Yc84ZzpV/o2h0qgpYuUjmRBLWuXB+Vaewr5vxvRVcdY41a0z55IvVm0RMdTzQQWLm5cBTRxe/cxUN3qh/9RiV8gINovYDWEJ9Zfq7V6XLcOiHCj27sIUF1Obd6On6HqD3OIw4oo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(451199018)(83380400001)(2616005)(36756003)(82960400001)(86362001)(6486002)(478600001)(2906002)(31696002)(6916009)(31686004)(4326008)(316002)(41300700001)(66556008)(66946007)(66476007)(8676002)(54906003)(5660300002)(8936002)(26005)(33964004)(186003)(38100700002)(53546011)(6666004)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckd5WWx0RkVKMlFPaVROQUozcXd2YUgzWlJJV1NQUnBvSkRBaDVuWU05SmFT?= =?utf-8?B?UzJPVGEycnVKMkJDTnMyc29EQW1Tcm5QY002TEh1K1NWdWtoelN1NkNTNDA5?= =?utf-8?B?ZElVZzZTQUtqRU1VcFVCbnlKMHh2ZE1WMCtObU9udjdDUUQvRnplWC9BczdF?= =?utf-8?B?OEVIWjlHdzZrZ2p6bzJ2WE53RXVUWDBqR2ZBMkswMmxNZXFKNWFpVkFRcGtS?= =?utf-8?B?aVFGbFFwbFBMc05ZbHMvYWpkU3hTVXMzWFBHY2VEa014TGFZZHdBQ25SVzlZ?= =?utf-8?B?TTREc3dVVVljWEZIdFcvMGh4L1BibGFjb2NuNEw5ZTRWYmtKR3k3bzN3ZUs3?= =?utf-8?B?R2E3aHVNRGlIdlFMN2dDbW9YaU5IZ0c1dUpZUC93ektDMUpvK3VkcTVvSFdt?= =?utf-8?B?UjhUb1I4d1lTdjV3MkJENUxMZjdNMmc1UlNIS01jSmhpRm1IZWFJakJxcGlC?= =?utf-8?B?Vyt5SVFQOVZNSGM3cXJSV0MvUnJvT1lVbDI4UmVGcTlycXpBOHV0ZG0ya2tj?= =?utf-8?B?ME9BNjhrM21VNjZBcVljaWJzc0MwYXF1ckxNWDJaQUJ4YXgwbmlhZzlCMkJ0?= =?utf-8?B?VmxKMGJZYTVRMWwrNUFpU2ZLclQ0R0ZldWdjTkpOZ3RBVU9QVkZicGxibXVV?= =?utf-8?B?RmpRcXZ6MVJxZ3F2MW10Rkp3QjF1bUVvVi9YVjRPbm5iQktldVZGS0k5WjBF?= =?utf-8?B?Ly9tbUNPRnR6OFNVZHN0YWJSbTBBTm83VDZZZDdyTUdSL2tNNGdJOHlIRnFj?= =?utf-8?B?Zml0T0ZqWUpXZG52cndjZmlVOXVMbEppTGFPcE8waHcrbXpBY3VDZk5mM1dB?= =?utf-8?B?NFpib0phZHp5TFRob3JmZkdyNUVFdFdndVpNVlRpeXczam9WRS9VblRQazI0?= =?utf-8?B?WStpQ1hKQ0x5U2xLcXBoNWpkTisxZEI1SGNjeDdOejFWMm5uOWV0Qmk1WER2?= =?utf-8?B?cE1JVy9aYmttWm5md2xoY2szRGVMNWNxZlBDTVc3MERodWpOUHJPTVJKQ1ZI?= =?utf-8?B?Vmx6SUpBb0ZmbDlDamNSQmFMcUQyUmsvRUdGM0JtSVllM3gwMlFjeVR6eDdW?= =?utf-8?B?cE4xd0Q4TTF0RVdmNzVGSWttYVdDc0VINlJDU2N6a1dEUnduc3ZQanlieGRY?= =?utf-8?B?eHBQbytqRHUrbjVjTko5SGthTGNSdDhFU2d4NUFhZkVXTjY5ZS9rTlJSWGJB?= =?utf-8?B?c2ZXNjdVcisrTVRHR0M3Mm9YZ21Hc3VWTlhud2F2ZU5TMkIybDRMWGZmeVhD?= =?utf-8?B?MVN5a0RZUnY3cERWdlBCSmlUNkdEUFZ3R29zZXBuTCs0SkxCelMwOEdEaWJU?= =?utf-8?B?VlFZNTAzL1V3SFNReWZaZXhQRC81Q3htMXA5K1FYWVFPSHc2bkFrMWdobHVQ?= =?utf-8?B?dy9LMGQrdUxUNVB2L1VpZzRERFdGMHorcnhzMkVVdk9CYnZPQmxBcE1nOWh5?= =?utf-8?B?ZHp3bDdObk9SbHJhK1ZwR3U3RWRUV3QvVTdsTUNmeVVQcnE4UjhYNncxeEd2?= =?utf-8?B?SnhZMUt6L1ZXVENEaGhwV2JNc2xVblNWL1dmYy9VR3pHMVFSaHNscm9kL3NI?= =?utf-8?B?dzJnbng0ZDhoeERnZHo4c2h3Um5zbHA2MnhxZDIzYjZZT1R4SnRuaHhQaXhj?= =?utf-8?B?TWwwYllLdHI5STRJTG1RSjR1VllaVHFSQ1lZRS9jemtLbHNHNU1KRysrWW9M?= =?utf-8?B?T3pNT3VZT3M3MzVnYkxXSkRub2VCalk4YTVxcDNTK0UyK211M0QwYnc3Qi9J?= =?utf-8?B?WHVaTXg2dzRPRk1USm9na09WWGl1aTdpeDNjWkYrTGovVGt4UE5iVkZsR3I5?= =?utf-8?B?WG5rODhpVHhlSmpmTW5JKzdSaXBtRXoxTFkvWUFEdkVpMkFvRitlNHQ2WDJV?= =?utf-8?B?d0JibFpiaG16c3NLakFEUE1lSFlvYXN2WnlhZmxqcGtwNU1sZCt6K0JNa2kz?= =?utf-8?B?Wi9nOFV3QWVDK0FnYjVGcWdhQnhqS0xQclBtUW9FMlNFSTZ3YmcwbjVuWVZo?= =?utf-8?B?UlhFQWI2eEpqYWp6SUVEM1dXcnpEMWNrQ1o3Z3lxWGhXSjlvZk0zNHFhS29I?= =?utf-8?B?RndrZ0ZKRTY0eU8xdDRjR09XOERrUEFZWkpVcERuUlZ1MWFaNnVTeGRWSmpr?= =?utf-8?B?blpxZU5iQzE3VDV1RWRhdE4rbEs3SmVwaUprY091dTBiTnBMN3YzVjZYcTRL?= =?utf-8?B?QUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +9Ti5bl9H+rhdOOBFEIH4WowUGwNihdJ+YqAWOQqJpccrqC9IPtW2G/IVz2YyDje9dVjZTf4kTMr+mnheW9o10+MdGoZFg4tGTKXLNYAdd0qYT5ERpf2LLU6ys7bO5e1o1ffU3jxD/NtdsWOlMbCXRj+h+ZBgzZ84qHrYFV+fFBU1ojko6FntCQNf/pd7cWWQ5Sr44qT74CdfROj6hRKejpUds3wuSxukpSiu8Pq050KAKEPZexlhK3fHSq4RYuQ9nFqdKnlazokBrh1LoIeOlgHBuJ7pJwkkZh2CUBk/d9922IN8t0fdz3KC9rMEtNWu0GOZqRVX159sEjnOWVly873UMS1lgQss2e0eA8p8HSNT7Jx/H6J1Pd5eKx4QGpANumVS2G+x8dPV0MQdLsfjWFbrQQXJE/yk71fDzn25cwE7iO59jj2jjvZ2/IByqYiwDOG9S4TIE7NBLxynuPPgOsUDfmVbRE96RoLTIIbZp5iwp+kyRCt1nYcnjGOPyVAJeXPwtecyZktWjLFoVXP2pok2EMqVDBK2A3fbs5pdCZAKgcUSz7bpza0MNt+GEzNpMGvL0p5IbxJnWenGPJgJfjfXZ86F0RBHaq1dnnbPa0u94sqKPETZZmzHrpNUu12VNwe2xs/j+F5+eMp3ZzTvYBr3KkGbANyiEHjscE3+A+r1nuNIbNwlQc58G5DsjmfM7dRJnAR2NeDlthl+vQQpW04OM8EILqslCLGseF6vnFFh7UbjDSLq/IzPxNyWWQrDkZ2GoXHfiHnWl8KKjFPssr/5sjSAnnZCy/XCeaq/wyd8Re3ar78p4eok8yngRcVv4i+hExXhuZ78kHo5Lg9viRypbhVaaN/o/2U8WIhcyej0y8TbJ6C7zG/mHhaJodJ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e233a8e5-82a9-49e3-a810-08db10d7e693 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 11:12:47.8162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +7VbjwQfTBDggLwb9/okr+tw5sSdrKEjiXaivTB6km81P151oz2oJqYFB3awyD7AV+AdDukiJrvZz1AyBBnQArhZW8kfTUKsmmJNiBNBbAA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6990 --------------LqKo3VsnUwEadxeTZXot0vMz Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 17/02/2023 11:10 am, George Dunlap wrote: > > > On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper > wrote: > > Clang-15 (as seen in the FreeBSD 14 tests) complains: > >   xg_main.c:1248 error: a function declaration without a >   prototype is deprecated in all versions of C > [-Werror,-Wstrict-prototypes] >   xg_init() >          ^ >           void > > The error message is a bit confusing but appears to new as part of > -Wdeprecated-non-prototype which is part of supporting C2x which > formally > removes K&R syntax. > > Either way, fix the offending functions. > > > Nit: This says "functions" (plural), but I only see one function being > modified in this patch? > > Doesn't matter too much but might save an archaeologist some confusion > if someone were to fix this up on check-in. :-) Yeah, I pre-emptively wrote the commit message as tools-wide.  Given 4 in Xen, I was expecting to find more than 1 in tools. I fixed it up on commit. ~Andrew --------------LqKo3VsnUwEadxeTZXot0vMz Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 17/02/2023 11:10 am, George Dunlap wrote:


On Thu, Feb 16, 2023 at 11:16 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
Clang-15 (as seen in the FreeBSD 14 tests) complains:

  xg_main.c:1248 error: a function declaration without a
  prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
  xg_init()
         ^
          void

The error message is a bit confusing but appears to new as part of
-Wdeprecated-non-prototype which is part of supporting C2x which formally
removes K&R syntax.

Either way, fix the offending functions.

Nit: This says "functions" (plural), but I only see one function being modified in this patch?

Doesn't matter too much but might save an archaeologist some confusion if someone were to fix this up on check-in. :-)

Yeah, I pre-emptively wrote the commit message as tools-wide.  Given 4 in Xen, I was expecting to find more than 1 in tools.

I fixed it up on commit.

~Andrew
--------------LqKo3VsnUwEadxeTZXot0vMz-- From xen-devel-bounces@lists.xenproject.org Fri Feb 17 11:37:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 11:37:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497035.767968 (Exim 4.92) (envelope-from ) id 1pSz2w-00079X-W4; Fri, 17 Feb 2023 11:36:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497035.767968; Fri, 17 Feb 2023 11:36:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSz2w-00079Q-RS; Fri, 17 Feb 2023 11:36:58 +0000 Received: by outflank-mailman (input) for mailman id 497035; Fri, 17 Feb 2023 11:36:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSz2v-00079K-Bk for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 11:36:57 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f3bf4cf-aeb7-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 12:36:53 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f3bf4cf-aeb7-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676633813; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NwPIiULrKwhyaclK8T6rOCmB+y/Ja6tg00AxBjFjpWo=; b=Q4NgCdjH5cJJFG5AvaIUYtJxFD8AHLuPBgP+Yt7c3X7JyIsFx1F+wdrq cIgz+lGXOBXRNjxWdSvQq3aIfUuRY9+ezTl/AemkgkajuQT0bZRGI+lSo 0sUKeDayztsVdTITdg8bYMWIRl3Bx99elJmzJ0CkGLYJj4LpkBxyV5s21 k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97463005 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:HsdU5a1/KpYhETgfK/bD5fRxkn2cJEfYwER7XKvMYLTBsI5bpzNRm GcdWGDSP/qPZ2f9fNtzOo7i90IEsJDWy9FjHgJupC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnOqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAjkRz fEEFwA0NAmkm+if8r6pc+Nrv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFJoJwB3A/ j+uE2LRAyhFM+ykzwq+2W+sn+DrnH+hZ7w0C+jtnhJtqALKnTFCYPEMbnO+oPK5g0r4XMhNJ kg88y8i66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bjUqQdtt/L56M1MTSBTvZ8 TyYlSI5vuBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW1C KMwkVkLjHO2AJdNRfYuC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzv9iZ s3HKZb3ViZy5UFbIN2eHbp17FPW7npmmTO7qW7TkXxLLoZylFbKEOxYYTNin8gy7b+eoRW9z jqsH5Li9vmra8WnOnO/2ddKfTg3wY0TWcieRzp/KrTSfWKL2QgJV5fs/F/WU9U8wf0Fx7+Yp SjVt40x4AOXuEAr4D6iMhhLAI4Dl74mxZ7nFUTA5WqV5kU= IronPort-HdrOrdr: A9a23:ZLduJa4JVvsqcShgrQPXwHPXdLJyesId70hD6qm+c20gTiX4rb HmoB1/726S+VAssR4b6KC90cW7MAHhHP1OkPQs1NWZLXjbUQKTRekSjvqBslnd8kvFh5FgPI hbAtZD4bbLfCtHZKjBkXyF+1hJ+rK6GHzBv5a6815dCSxndq1r8gFjKiveK1ZxTgVdH5Y1fa DskfautFGbE0j/rf7LfkXtndKz3uEjWKiWGyLvBXUchTVm2gnF1FcyKWnir2sju2sk+9gfGW +vqWLEDqPJiZCGIhu27Q/uxqUTld6k0MtGDMuQhsJQJDPrhAOlDb4RLYG/gA== X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="97463005" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Stefano Stabellini , Anthony PERARD , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Michal Orzel Subject: [PATCH] cirrus: Update FreeBSD to 13.1 Date: Fri, 17 Feb 2023 11:36:47 +0000 Message-ID: <20230217113647.776733-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Also print the compiler version before starting. It's not easy to find otherwise, and does change from time to time. Signed-off-by: Andrew Cooper --- CC: Stefano Stabellini CC: Anthony PERARD CC: Roger Pau Monné CC: Michal Orzel Example run: https://cirrus-ci.com/task/6205638091472896 but that branch also contains the RFC fix for the Clang-IAS macro expansion bug, which isn't in staging yet. --- .cirrus.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index c38333e73633..b133afb74057 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -10,6 +10,7 @@ freebsd_template: &FREEBSD_TEMPLATE libxml2 glib git build_script: + - cc --version - ./configure --with-system-seabios=/usr/local/share/seabios/bios.bin - gmake -j`sysctl -n hw.ncpu` clang=y @@ -22,7 +23,7 @@ task: task: name: 'FreeBSD 13' freebsd_instance: - image_family: freebsd-13-0 + image_family: freebsd-13-1 << : *FREEBSD_TEMPLATE task: -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 11:57:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 11:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497042.767981 (Exim 4.92) (envelope-from ) id 1pSzMe-0001sx-IB; Fri, 17 Feb 2023 11:57:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497042.767981; Fri, 17 Feb 2023 11:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSzMe-0001sq-FX; Fri, 17 Feb 2023 11:57:20 +0000 Received: by outflank-mailman (input) for mailman id 497042; Fri, 17 Feb 2023 11:57:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSzMd-0001sk-NS for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 11:57:19 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37e46ecf-aeba-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 12:57:16 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37e46ecf-aeba-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676635036; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g9lDf4mNfOvzmTcMYT5rjiRPCYosLbX5qyH+2hE2iVg=; b=YUuF23PvSIUGpK7/1AUg9Kgit8on5ZKqv80JPFYFrKiExTCXm4FIExVH xpGDCvOg2VqyggYUtvJsJWzocB55us5lNzyOgrApSee1/j3qnl1vKUzXL eOLvov2AeehB6vXh2C/dhLISO/oIqjQ5g3PQDvFtQVUOjvDL62fWE3ByM 0=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 99881645 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ppCMN6kC95mlRHhEHXnUgB7o5gyyJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdWDuCMvqNYWajKYtzbtuw8hkFv5fQmoBiSwc4qSg8FSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QCGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eMHJyERSzKxu8aVwaijQ+hLrMAnHNa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfJ9 jKfoTikav0cHOem6hif/n+JuvDOzT64SqlREqTo0PE/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OczRDcq3 1vPmMn7CDhHubiZD3ma89+8pCu/IyEPIUceZCUPSk0O5NyLnW0opkuRFJA5Svfz14CrX2iqm FhmsRTSmZ0MksEay4CZz2zjoDO2vpHIaSQx4jXICzfNAhxCWKapYImh6F7+5PlGLZqEQlTpg EXoi/Ry/8hVU8jTyXXlrPElWejwuq3baGG0bUtHRcFJyti7x5K0kWm8ChlaLVwhDMsLcCSBj KT76VIIv8870JdHgMZKj2ON5yYCl/SI+TfNDKq8gj9yjn9ZLVbvwc2WTRTMt10BaWB1+U3FB b+VcNy3EVERArl9wTy9So81iOF0mH1hnz+LFcugn3xLNIZyg1bPFN843KamNLhlvMtoXi2Lm zqgCyd640oGC7CvCsUm2YUSMUoLPRAG6WPe8qRqmhq4ClM+QgkJUqaBqY7NjqQ5x8y5YM+Up CDiMqKZoXKj7UD6xfKiMyk9MeO+BcYk9BrW/0UEZD6V5pTqWq73hI93Snf9VeN4nAC/5ZaYl 8U4Rvg= IronPort-HdrOrdr: A9a23:3aDTkK4PvLIuIavD2gPXwMjXdLJyesId70hD6qhwISY6TiW9rb HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM FdmsNFaeEYY2IUsfrH X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="99881645" Date: Fri, 17 Feb 2023 11:56:49 +0000 From: Anthony PERARD To: Andrew Cooper CC: Xen-devel , Stefano Stabellini , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Michal Orzel Subject: Re: [PATCH] cirrus: Update FreeBSD to 13.1 Message-ID: References: <20230217113647.776733-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230217113647.776733-1-andrew.cooper3@citrix.com> On Fri, Feb 17, 2023 at 11:36:47AM +0000, Andrew Cooper wrote: > Also print the compiler version before starting. It's not easy to find > otherwise, and does change from time to time. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 17 12:22:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 12:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497072.767993 (Exim 4.92) (envelope-from ) id 1pSzku-0006dy-4U; Fri, 17 Feb 2023 12:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497072.767993; Fri, 17 Feb 2023 12:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSzku-0006dr-1J; Fri, 17 Feb 2023 12:22:24 +0000 Received: by outflank-mailman (input) for mailman id 497072; Fri, 17 Feb 2023 12:22:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pSzks-0006dl-64 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 12:22:22 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b7bc8775-aebd-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 13:22:18 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7bc8775-aebd-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676636538; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=v/Z10Nzrk4M4mUynfU62eVEu+jUOB6oerTObnDnAw5U=; b=DUJS/Bf3QZcSjbRO07AWJsGWJtr2m3q4L6ugtuxpNvJOySSi0O/2ETjn ookJc6XewHSWzb5G95JKnozOx3WEzj/pDDr4astzk38xvzb6luBUGHH6s Mh/+oJqk5i1lNL2ZuusiQ2jFQDQRm9YFPmQAxT3PxKIaLKfx52m+A7Oi/ 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96302008 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:BbQ3pamZlmSazE+NAxe916vo5gyXJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJKX2+Ba/jbZTOhc4p/Ooi1o08HsJ+DyN9gQAQ5ri1nRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5QCGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cM/b2sifAuYu+Hs8bG3GupljM4qdsa+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthfG/ Tqcpzypav0cHMCQ9geL/Uqzv8LegwfQWdJKRZjh+vE/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JyOeAn7ACGyoLP/h2UQGMDS1Zpd9gOpMIwAzsw2 Te0c8jBXGI19ufPEDTEq+nS9GnpUcQIEYMcTRAjClAq8cL4nIJpvxHDHtVqGqS81NKgTFkc3 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPn6gKvFmSx28zaK7onAMFh 2eK4GtsCGd7ZifCUEOOS9vZ5z4W5abhD8/5cfvfc8BDZJN8HCfeon4wOBHKgzi9yxN8+U3aB Xt8WZzxZUv29Iw9lGbmLwvj+eFDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGZinchghJ5oVD79q o4FX+PTkkU3bQELSnWPmWLlBQxQfCdT6FGfg5A/S9Nv1SI/QT94W66Jkeh4E2Gn9owM/tr1E riGchcw4DLCabfvc21mtlgLhGvTYKtC IronPort-HdrOrdr: A9a23:50adT6+7yJxv7PNTNoxuk+BjI+orL9Y04lQ7vn2ZhyY1TiX+rb HJoB17726StN91YhsdcL+7VZVoLUmxyXcx2/hzAV9NNDOWxFdAb7sSkLcL+lXbalLDH5dmpN ldmspFaOEYfGIK6foSuzPIaurIqePvmMuVbKXlvhVQpGdRBJ2IhD0JbzpzfHcZeOBuP+tJKL OsouRGuhu9cjAtYsygAH5tZZm4m/T70LznfD8bDFod5AOPlDOl76OSKWni4j4uFx1O3JY/+i z/nwb4/6WutOz+4hLQzGPI9f1t6avc4+oGKsyQq9Qfbg/hjQulf+1aKsW/gAw= X-IronPort-AV: E=Sophos;i="5.97,304,1669093200"; d="scan'208";a="96302008" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v1] xen: Work around Clang-IAS macro expansion bug Date: Fri, 17 Feb 2023 12:22:03 +0000 Message-ID: <20230217122203.790737-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230217001914.762929-1-andrew.cooper3@citrix.com> References: <20230217001914.762929-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit https://github.com/llvm/llvm-project/issues/60792 It turns out that Clang-IAS does not expand \@ uniquely in a translaition unit, and the XSA-426 change tickles this bug: :4:1: error: invalid symbol redefinition .L1_fill_rsb_loop: ^ make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mux %= in too, which Clang does seem to expand properly. Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu v1 (vs RFC): * Rename \foo to \x, reorder WRT \@ to avoid needing \() too. I originally tried a parameter named uniq but this found a different Clang-IAS bug: In file included from arch/x86/asm-macros.c:3: ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] .L\@\uniq\()fill_rsb_loop: ^ It appears that Clang is looking for unicode escapes before completing parameter substitution. But the macro didn't originate from a context where a unicode escape was even applicable to begin with. The consequence is that you can't use macro prameters beginning with a u. --- xen/arch/x86/include/asm/spec_ctrl.h | 4 ++-- xen/arch/x86/include/asm/spec_ctrl_asm.h | 18 +++++++++++------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/include/asm/spec_ctrl.h b/xen/arch/x86/include/asm/spec_ctrl.h index 3cf8a7d304d4..ddb2247fcb0a 100644 --- a/xen/arch/x86/include/asm/spec_ctrl.h +++ b/xen/arch/x86/include/asm/spec_ctrl.h @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); /* (ab)use alternative_input() to specify clobbers. */ - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_BUG_IBPB_NO_RET, : "rax", "rcx"); } @@ -172,7 +172,7 @@ static always_inline void spec_ctrl_enter_idle(struct cpu_info *info) * * (ab)use alternative_input() to specify clobbers. */ - alternative_input("", "DO_OVERWRITE_RSB", X86_FEATURE_SC_RSB_IDLE, + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_FEATURE_SC_RSB_IDLE, : "rax", "rcx"); } diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532b..1220f219f695 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -117,11 +117,15 @@ .L\@_done: .endm -.macro DO_OVERWRITE_RSB tmp=rax +.macro DO_OVERWRITE_RSB tmp=rax x= /* * Requires nothing * Clobbers \tmp (%rax by default), %rcx * + * x= is an optional parameter to work around + * https://github.com/llvm/llvm-project/issues/60792 where Clang-IAS doesn't + * expand \@ uniquely, and is intended for muxing %= in too. + * * Requires 256 bytes of {,shadow}stack space, but %rsp/SSP has no net * change. Based on Google's performance numbers, the loop is unrolled to 16 * iterations and two calls per iteration. @@ -136,27 +140,27 @@ mov $16, %ecx /* 16 iterations, two calls per loop */ mov %rsp, %\tmp /* Store the current %rsp */ -.L\@_fill_rsb_loop: +.L\x\@_fill_rsb_loop: .irp n, 1, 2 /* Unrolled twice. */ - call .L\@_insert_rsb_entry_\n /* Create an RSB entry. */ + call .L\x\@_insert_rsb_entry_\n /* Create an RSB entry. */ int3 /* Halt rogue speculation. */ -.L\@_insert_rsb_entry_\n: +.L\x\@_insert_rsb_entry_\n: .endr sub $1, %ecx - jnz .L\@_fill_rsb_loop + jnz .L\x\@_fill_rsb_loop mov %\tmp, %rsp /* Restore old %rsp */ #ifdef CONFIG_XEN_SHSTK mov $1, %ecx rdsspd %ecx cmp $1, %ecx - je .L\@_shstk_done + je .L\x\@_shstk_done mov $64, %ecx /* 64 * 4 bytes, given incsspd */ incsspd %ecx /* Restore old SSP */ -.L\@_shstk_done: +.L\x\@_shstk_done: #endif .endm -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 13:32:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 13:32:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497108.768010 (Exim 4.92) (envelope-from ) id 1pT0qk-0007yl-B1; Fri, 17 Feb 2023 13:32:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497108.768010; Fri, 17 Feb 2023 13:32:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT0qk-0007ye-7i; Fri, 17 Feb 2023 13:32:30 +0000 Received: by outflank-mailman (input) for mailman id 497108; Fri, 17 Feb 2023 13:32:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT0qj-0007yU-Ex; Fri, 17 Feb 2023 13:32:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT0qj-0004Wi-Bv; Fri, 17 Feb 2023 13:32:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT0qj-0004mq-6A; Fri, 17 Feb 2023 13:32:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pT0qj-0004HM-5j; Fri, 17 Feb 2023 13:32:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WzOFNBQTiikysguBMpAnvJw9MVBtlHquKREKeybVQJ0=; b=v2x/bNtKtGbMv3ldJuG+l2lzGD /gcnC1y7o9AeSIYwtU9HrJHBLcLaUAvtX20O27gRB07HZ9ncyEx6KY339rXulLqRSqffDZ0rXm+dZ DNH8RVlQWjVgGYGkRNtzCeAVRV9erk/i6WjqeT41q1CezWZ8xqjXFTFAxofWWrnAvuwk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177565: regressions - trouble: fail/pass/starved X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression libvirt:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=15e5eb8a7684992d1a885038d28781462a727bf2 X-Osstest-Versions-That: libvirt=598a73335d70b4ef70b84f9730d708c116f88b15 From: osstest service owner Date: Fri, 17 Feb 2023 13:32:29 +0000 flight 177565 libvirt real [real] flight 177606 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177565/ http://logs.test-lab.xenproject.org/osstest/logs/177606/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 177457 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 177457 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 15e5eb8a7684992d1a885038d28781462a727bf2 baseline version: libvirt 598a73335d70b4ef70b84f9730d708c116f88b15 Last test of basis 177457 2023-02-16 04:21:50 Z 1 days Testing same since 177565 2023-02-17 04:20:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 15e5eb8a7684992d1a885038d28781462a727bf2 Author: Michal Privoznik Date: Wed Feb 15 15:52:21 2023 +0100 qemu_extdevice: Add a comment into qemuExtDevicesSetupCgroup() The way setting up CGroups for external helpers work, is: qemuExtDevicesHasDevice() is called first to determine whether there is a helper process running, the CGroup controller is created and then qemuExtDevicesSetupCgroup() is called to place helpers into the CGroup. But when one reads just qemuExtDevicesSetupCgroup() it's easy to miss this hidden logic. Therefore, add a warning at the beginning of the function. Signed-off-by: Michal Privoznik Reviewed-by: Laine Stump From xen-devel-bounces@lists.xenproject.org Fri Feb 17 14:07:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 14:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497125.768023 (Exim 4.92) (envelope-from ) id 1pT1On-00049W-4I; Fri, 17 Feb 2023 14:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497125.768023; Fri, 17 Feb 2023 14:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1On-00049P-1a; Fri, 17 Feb 2023 14:07:41 +0000 Received: by outflank-mailman (input) for mailman id 497125; Fri, 17 Feb 2023 14:07:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1Om-00049F-4g; Fri, 17 Feb 2023 14:07:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1Om-0005Op-1s; Fri, 17 Feb 2023 14:07:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1Ol-0006Un-Ki; Fri, 17 Feb 2023 14:07:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pT1Ol-0003zf-KD; Fri, 17 Feb 2023 14:07:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8qEcL/5lT03p7lYYZyLEfqeSSUHEd2K4jzHI4XluZ/0=; b=1kzJi3cdUbO8yFPI4we9YZDMaZ wRQ3RTv2I8icTk2Bh5cLDm4Ipw1LFT8ynjjCwsGTywt8+x0j9Uv1nzZuIeR6tp5o3FEd9GkIK3R9F GOWatB5VX74R9LTfNy7KH0riXHGMuIXcmMc+veqqISta+mlQeqmhB2TreubEeBUEO+KE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177603: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd X-Osstest-Versions-That: xen=f5c1a6374aae8be471b895a43359dcff355577f5 From: osstest service owner Date: Fri, 17 Feb 2023 14:07:39 +0000 flight 177603 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177603/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd baseline version: xen f5c1a6374aae8be471b895a43359dcff355577f5 Last test of basis 177547 2023-02-17 00:01:55 Z 0 days Testing same since 177603 2023-02-17 12:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f5c1a6374a..e2312e41f0 e2312e41f05c0f2e3b714710bd2551a3cd74cedd -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 17 14:11:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 14:11:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497133.768035 (Exim 4.92) (envelope-from ) id 1pT1S2-0005tq-M1; Fri, 17 Feb 2023 14:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497133.768035; Fri, 17 Feb 2023 14:11:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1S2-0005tj-HT; Fri, 17 Feb 2023 14:11:02 +0000 Received: by outflank-mailman (input) for mailman id 497133; Fri, 17 Feb 2023 14:11:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1S1-0005tb-4v for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 14:11:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1a::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6fc2642-aecc-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 15:10:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7905.eurprd04.prod.outlook.com (2603:10a6:20b:235::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Fri, 17 Feb 2023 14:10:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 14:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6fc2642-aecc-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTl1yy0h0HXMqKfG1spQWrLL1XB8S76JR/gV53NLU2T0xuvccNPF8XoNonmHhGpABZbHExo0c6Uonncn+XCblq+a6EmupcnjVD1Fv47NEWsWWtBONiBldi5QRvfwS9T9tL29E4aNmzqXc1c5eVNxUZIiwUqcQRfAB4GVbLt78jLT+HjedTZe+7N9vitm2+U+coVN5/LwIdvED0NBYFXxdDvY8gvCVOasBwINcLTCAHIG0XFHilzsBhaOt0H3nqOg4/MLW++L8wjwtqpHx5CCA7WkZ5l6MagJB+LQcgsO9UlRIc4oydfVpDwzPKoAedkb+ohPbbR+0qMgnCmQqFC+ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I8N9ZuO1bWoIoIf1JAd9rHc0q/9QQQjWX6y9ZSEOl2U=; b=DhJGfgvOdFLvydxfG2pLEqqvLJTEjSaF3YlqqOAbUrOpVcmNsWhrFjA0+1hbrdG/VyAnif/57Gr39cQvUkd73KgLLHWcW5PLNpfxkUu+XI28gc8cPd0+TQ6qu9XMvV9t2Wu8WYGKs1wUE0YHBvX3rFhZQxWgxDHpyqDeATzQEFPnVhMqdwYcC/Ywd8NtLhgejYwyX3rrIIsRFxuD70YANLIA758U3jFNpYYuD97+56eVL98wAt+Pwov42Il3VS/1kinxO06OjCIB9UKTlb/KHN5DC2FILh8sNiNtVKodp1DkpQ6grOMIOjdbLB8lH4oEm6za9hnDkxKwKttI6GoO3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I8N9ZuO1bWoIoIf1JAd9rHc0q/9QQQjWX6y9ZSEOl2U=; b=bs05I9dwloJah1nZgz14KN1YMm9h2igzIgv9TJQfGR27e3h5QQ7VYKJETrn3Zk3T5RL8GXGi3A+dU0GUxCNZNVWi3h1nudFyk3zjxY0CVW4CLIW7poosvcv2+to0ru019MFS+LfoM+nz5x5Bkr9juzlxcgjoqZ9C6MU1y6owvsAkKg7xkq9PNiKh/GbTXBcrNm971g9/C56hU3wJNUds4vKnQalehrjoPdKPRq8Si2MlKSwanbZ2xkkZEbH6cU7ZLDrYbRJd+Kke9gn2QlP1NvdgQnIyLAV9LKHh/jcJdSA3oJYXl+c07lwoixMaAj0cD7UTmosqasr6iO0G3lIDoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9864e936-5c77-a790-e36c-766d5359cd83@suse.com> Date: Fri, 17 Feb 2023 15:10:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org References: <3aa736d3-b833-0c6c-2a41-71cc4b953aae@suse.com> <20230217085006.GA2281468@horizon> <7e79d20d-0922-565a-e46d-e3366c0bcfb4@suse.com> <20230217092948.GA2282871@horizon> From: Jan Beulich In-Reply-To: <20230217092948.GA2282871@horizon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7905:EE_ X-MS-Office365-Filtering-Correlation-Id: 57caef0f-037c-4654-dd93-08db10f0c8e9 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pXm4m0MuvLK8NxhcISd1XtzlM5jNMSCiFrCnnJF6njPKwdNAx2kjloGeK8n+TpJUZcHjs8D2ZQwepppaDi+HD5WiPq7MIW0P2tcst88psCM2/twRKBvtJT9w1QnEC7xCRp3qVo+X+ChnXH7U+ELlwDjxfhwXZf9CK/WquiKwiBNGsbpewtZxs7dkNhukfZqIJC4/RhBpC58VrXlcWuzn93rWQC4RuSTPWEb3sbm4YuJSUohK05Vf/Dn13GGhQbSr6+Sm7mZfOFW1z/lwYqwuodZIXMwgi7D6xNnj5eXFWbTNe1or1jYeo33ehfRuQ28jPiLJSukOZiCme7SvwjxL2C8V/u91EB5CuN/4WKszFL7L6H89pUlzsHsXNFe4AhWppKOcGGhIbf2oYcrSt9b5uGYiffG93YFZ1c3eWJT4VRPipPQrmNmy9R1vFckKWfCPaFcsTrcV2RsCvpzjNqZF5l4T5d+iyfUyFq7FOdeZ6141/u67KQ/dDMC2uMpTbjUjrW1wj2mLSD4rMLit82n8PpfPi9u1oli23j+tpviKDC3WJ5LWlSYertWwJ1e/LnzM9bJ65aijhYbEwc7OINUtnqAh92dJ6u7uTagOWlwSQS1daCSqG2CZOggyCBZ4gDd8K3KqQEotg0F8yH1BGOni32UrE5Kc3wCCBjDfaWdn5iX0wnLsqc9SjP3LddQWVIb/vckhvMh3T+Vc5f8DvcK3lTRkjipBgj2znTghW3h/WiY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199018)(8936002)(86362001)(31696002)(31686004)(38100700002)(41300700001)(5660300002)(66556008)(6916009)(66476007)(2906002)(66946007)(8676002)(4326008)(316002)(54906003)(2616005)(478600001)(83380400001)(36756003)(6486002)(53546011)(6512007)(6506007)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0VuZGxoNndHNUZPYm9xRHdjbkdTWGFGTEpIc21HaWNOb2t5bitINnBpSmh1?= =?utf-8?B?NURLMGNkWGt5WGNaTkJJSFZ3TDNXUTNmWTErS3RXd3RWMFdMV0w1dTBHMm1P?= =?utf-8?B?UmRpMmVhdFBLOUF4ckt1eTlvMDRTQ2xVbTVXdGoxS1VDNUVoSFNTV1VjaVk1?= =?utf-8?B?V25hZHk1ZWNScUd5dFFMcGZFREM3ME03UkR0Q2ZJYVZUSm90SUhvQnJxQnd6?= =?utf-8?B?enlWUFZRcm1ERmpSTzFjWGJXK29BejN2OENlVDF0Y1dEVnhlMjREbWxZMDFQ?= =?utf-8?B?QWpIRmNhYkVYUHNUcVhUaWVjTHp5QTRCYzN3T1dYdjh0c0Fib0w4a3VFQVdr?= =?utf-8?B?KzA1ZVMzSXpSWGRjZFV2SHV2d1c2MEhyeHhLTnMyTEk0YmRocDVpVmxQbzFs?= =?utf-8?B?T3ZCV2p6OFNELzk5MUhmRmcrdjFrMnlML2dSUWpJczlWSDFGdENWTzlLTTJE?= =?utf-8?B?VHAvL2V6dmNOL3RoeEFuLzlWRFRuaE1lYzFPRCthcWpzbkNhQkVrTkVjT25x?= =?utf-8?B?R3lURm9IVEFFc2s5dGgvaG9zUnlWb1g5eGVPandZMXlGaWhxNkxNb3pNaTVD?= =?utf-8?B?bi8rWmlFQ3BWV2o3TDR5VEJQRGxKYVovMWM2SVBCL0dka1dxU0dMWm4yMkVw?= =?utf-8?B?cm9rODltVGtmQ1RHSnVFd3MvL1NCUEY3cHk2NW54YmlVcEJ5alFhRzRsSkVl?= =?utf-8?B?dFVRRnRjcUdLdDlIelZjVlBrT2VwRzNZQlVlWm9ERmorR1dSRk5WUmdMZVVj?= =?utf-8?B?aDRQTGdwdVIxZEowVVhmNThKdEh5SHM4WDJvUyt1ci9yU0pLUkZkWnM3cEpp?= =?utf-8?B?QWRxSnZkZDlKck5jUmRieitvM1pTamFabVAwalo3bllsTlpZTDNvMXdhSzAx?= =?utf-8?B?bE4yR0VsNXBkSFAyM1RGTFQvUlgwN213MjFDUFUxOUg3empqNW0zMWhIUU9G?= =?utf-8?B?QWluSWJLMlhRRHJ1Z1BDRnVaWUdzSHQxZ3RqdUxPWVY2bUJ2bGNiL1hYaWZB?= =?utf-8?B?U1B0ZWcyL3BndHkzU1FaMGZWUkl2OTdNU1djKzFWVXJsa2hCZXhtY3Rvangv?= =?utf-8?B?UW1vNENYenBRdWI1UVNoNkdKN1NlRWlZMVpLeDZZWlkrdU8xYnNrWHgvNUx1?= =?utf-8?B?LytSQTQ5RGppUkJaaHFpNUEyWUJOclozVkc5S09CUEh6OENJNmQyTW5Ub0Vq?= =?utf-8?B?OHpqaDJzN2NXYkhsTDhhMVB5OXdjM2UrWlpmejlWbFJhRkdSZnlJWXoxRWxD?= =?utf-8?B?Uko1SHFTZWhEcGRwTVR5WDNDVGVXQlMvNWUxdTNnai91RFpIRWlqdURISi9I?= =?utf-8?B?MnlGZDZVVVNXS2lWendEZ1RTSUxwc3JVenJZWHFEUzFnRFNmdUxMUXNrVWlq?= =?utf-8?B?WEFDS3Q0ZGY0TzFKdWk4ZGV0bWl4QldHNEdpb2h0aVgxU0FoYzN3ZDl3c3Zy?= =?utf-8?B?NS8zVzBaUnFsWHQ5RVpOc25lL2I5eSt3Q0FwdmU0VklSRG5uM09jM0FqZHQ5?= =?utf-8?B?eVJ0c0dUczlPQ2JwSkhKaEhtaTFyWlRUU0ZYWUlnWkFMS2RIZGw0anlqWmR1?= =?utf-8?B?U2hlczVmb3M1bmY5QTRRUHhRV29IanQ0czhVbmJyem1RUlo3eGRTajRtZFQ2?= =?utf-8?B?aFVoMmJ6R0pUQ2FZalphWXNDRmR4TEdkVjlrMFFpV3JaaWVPQjBoSmRoYkxE?= =?utf-8?B?VnAvbUVIeTU0cFVQeVNBQUVabEMxeW1iTml6WUQ5c294OTNqQUFzZ0dMd3FM?= =?utf-8?B?L0RzRjNpam5aY2FNQllVM3Q4VzJJS0ZIVGFFa1dWeWJEeDJkYlNESUFldWJI?= =?utf-8?B?aUFqRGlycGh2SDFOcnFEdGxaR1hyMUd2ZlhwYzRrVFd6TkFOVUlDdWhETnRV?= =?utf-8?B?MHNKYUt3bEd0c1JaSlBuaUZLYSt4bm5ma3dvU0pKM3paR3NJZUN1VzU1Rmww?= =?utf-8?B?MmxSVjBEKytYdVhPZEM1KzdxeUl1VWxHQm1zVFVlcGRGVmZFbVNIaGtRNkZW?= =?utf-8?B?STBEUjZhZ0FIZEFsT2xGczhOb00xY0UwbFFCZWVpcWVCV3Z6WlJvU2IxNTVZ?= =?utf-8?B?SXVXdkoxK3hMdXoyUndiZS9ZU3VKSjc3VFpueXlrRXNkVzNXUjVJQzFqczFr?= =?utf-8?Q?vwIkLB+6MT4W7Hdn1Petl8WHs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57caef0f-037c-4654-dd93-08db10f0c8e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:10:55.8428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C+yeDXB9y6GL7SByVStfdPxWsOUgReBJV/bJVqX1KL7m1rbjOyDUyw6Zxzk8/Kwd592aAVd211nxyscVi/Y2Hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7905 On 17.02.2023 10:29, Matias Ezequiel Vara Larsen wrote: > On Fri, Feb 17, 2023 at 09:57:43AM +0100, Jan Beulich wrote: >> On 17.02.2023 09:50, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:56:57AM +0100, Jan Beulich wrote: >>>> On 14.12.2022 08:29, Jan Beulich wrote: >>>>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>>>>> +static int stats_vcpu_alloc_mfn(struct domain *d) >>>>>> +{ >>>>>> + struct page_info *pg; >>>>>> + >>>>>> + pg = alloc_domheap_page(d, MEMF_no_refcount); >>>>> >>>>> The ioreq and vmtrace resources are also allocated this way, but they're >>>>> HVM-specific. The one here being supposed to be VM-type independent, I'm >>>>> afraid such pages will be accessible by an "owning" PV domain (it'll >>>>> need to guess the MFN, but that's no excuse). >>>> >>>> Which might be tolerable if it then can't write to the page. That would >>>> require "locking" the page r/o (from guest pov), which ought to be >>>> possible by leveraging a variant of what share_xen_page_with_guest() >>>> does: It marks pages PGT_none with a single type ref. This would mean >>>> ... >>>> >>>>>> + if ( !pg ) >>>>>> + return -ENOMEM; >>>>>> + >>>>>> + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { >>>> >>>> ... using PGT_none here. Afaict this _should_ work, but we have no >>>> precedent of doing so in the tree, and I may be overlooking something >>>> which prevents that from working. >>>> >>> >>> I do not fully understand this. I checked share_xen_page_with_guest() and I >>> think you're talking about doing something like this for each allocated page to >>> set them ro from a pv guest pov: >>> >>> pg->u.inuse.type_info = PGT_none; >>> pg->u.inuse.type_info |= PGT_validated | 1; >>> page_set_owner(page, d); // not sure if this is needed >>> >>> Then, I should use PGT_none instead of PGT_writable_page in >>> get_page_and_type(). Am I right? >> >> No, if at all possible you should avoid open-coding anything. As said, >> simply passing PGT_none to get_page_and_type() ought to work (again, as >> said, unless I'm overlooking something). share_xen_page_with_guest() >> can do what it does because the page isn't owned yet. For a page with >> owner you may not fiddle with type_info in such an open-coded manner. >> > > Thanks. I got the following bug when passing PGT_none: > > (XEN) Bad type in validate_page 0 t=0000000000000001 c=8040000000000002 > (XEN) Xen BUG at mm.c:2643 The caller of the function needs to avoid the call not only for writable and shared pages, but also for this new case of PGT_none. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 17 14:39:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 14:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497156.768049 (Exim 4.92) (envelope-from ) id 1pT1tF-00018u-2n; Fri, 17 Feb 2023 14:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497156.768049; Fri, 17 Feb 2023 14:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1tE-00018n-Vq; Fri, 17 Feb 2023 14:39:08 +0000 Received: by outflank-mailman (input) for mailman id 497156; Fri, 17 Feb 2023 14:39:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT1tC-00017k-Oo for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 14:39:07 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20627.outbound.protection.outlook.com [2a01:111:f400:fe5b::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d09551dc-aed0-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 15:39:01 +0100 (CET) Received: from MW4PR03CA0219.namprd03.prod.outlook.com (2603:10b6:303:b9::14) by SA0PR12MB4526.namprd12.prod.outlook.com (2603:10b6:806:98::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 14:38:55 +0000 Received: from CO1PEPF00001A60.namprd05.prod.outlook.com (2603:10b6:303:b9:cafe::6b) by MW4PR03CA0219.outlook.office365.com (2603:10b6:303:b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15 via Frontend Transport; Fri, 17 Feb 2023 14:38:55 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF00001A60.mail.protection.outlook.com (10.167.241.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.14 via Frontend Transport; Fri, 17 Feb 2023 14:38:54 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 17 Feb 2023 08:38:54 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 17 Feb 2023 06:38:53 -0800 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 17 Feb 2023 08:38:52 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d09551dc-aed0-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L6Tfko+r6zuPsi+eyp9eoGe3BLjmPx62ahqy7JJ9ep4t1Q7Afef6t2FSRNS3XeWUqW/OwO7YRoAKApUjGUi+RPf4ck/RI6hyBRcBzCCkZuZ6Dn1RE7ADuRpLEb2dLY1UObq7vt3tzYPbnsWTC7sMvgxotMiJI7kxRDfAihhdzrTnfTmslFqIuqL1VHARmDgjVOdr7qKRG3UcHLEApgcy62pyXrpR/vUu5JXNu7rpVDMC4iWilKBGzYSrnM+qj0X3o3LvBbQDnkFiyhcC6P2rNWcFKOG1xgZ0/NSifO10m8Wu+ysKZ3u9h13fapYQo7g3Og3dB/jAZBuH2n2uSFnsKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WkcymSTxu+rjyKU0dIeVGw2xSwLbSLtaBIpnYYT5Mu4=; b=IH4ksxQzpdTKylPTxU1DBjdOZq49Db6FXU2hXhlAR+wR5ZWEd6+twayyNo7v7l7GL07JL7LqOHFDEiAfMaI8F1lkbovwmaLZoQJbxYLi3A8u0iBOwkKx7UqyPfNs+1tsJoGI9GxoyEPUxh69JQGZFoMtqFUz44EH4ARih21mOZ9DK9ZxweWzIEJ4U2Idx5OVXtyU8MeDk2sSaHt3ZaRdiDZenarPQxzFH8JZof995d6L72NobHFFZS1VaRAbGz1EcFxh6jatj4tqZkymkhST37k9+C8k9mNJVhIYY4BQV8bTfBjt4lFKjgNFdFYOd1NdWY2IT95IHHrGJbjmfWOLPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkcymSTxu+rjyKU0dIeVGw2xSwLbSLtaBIpnYYT5Mu4=; b=ykUMegJ3SmalGLTGunC0afZiCZ1SxLPwKrjjslQe2i6VhjVMqul4HFXeXcMxHYQWvi9SpPZx+RmPbCQ2rJ/GNz+z+xg0X/JhY0U3ivJ+H1NwsbcMpVKCWCy/Y+QsDn6WtfGGi3BTJYyF/uWZ4v+g5glHd3x876fy2i+rReEyEoA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <38326d5e-18fa-767e-5581-6bd8408e332d@amd.com> Date: Fri, 17 Feb 2023 15:38:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 1/3] automation: move yocto jobs to build stage To: Stefano Stabellini , CC: , Stefano Stabellini References: <20230215220925.2313528-1-sstabellini@kernel.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230215220925.2313528-1-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00001A60:EE_|SA0PR12MB4526:EE_ X-MS-Office365-Filtering-Correlation-Id: d1efed36-b1a6-4a7c-8053-08db10f4b23e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pH4iwp58j7Hg5ld5n3UNGCLVIxQyQCrDSPkHqQ6Goz0iZbcBl7riJAdZ9eYPxNuTAHaJWl5xbnuGifgA8kb6M49uzeSWnfJ/yL7CXa0ZL5AgKlI1d7Rk2fSZ00fxGhWoY9DvnKg9Fgdmr8U4R9wcQ1f1a+B5rFXymsFXMtsGAkPGA5hsGGmKGABnRVPW/gSsbGEZihvMbiTZL31Ao4Dpn0nfqawYt9Lrx+5zyak529a3uCC9Xe86VCqhHSO+naCEjKJ+nGCOdvlAFsTCyMrIHiIjlguVFUvJGF0pRvuGViYuX1CcfKsAR/8H7Trt1Ad/ylFD8bTi9iGibyyLjFSomzi+DYlq9GeOgSk4JygiJBt8ayqUCV6QWopaKDBZn1Azbuz7vEY2VSbiRCnJuYzP0PJe2lJxRcJeCZZ7NnI+r5gwPjNRBiWRtW8tyxqy3oV6PoT4DMpuHBnHxAJSe8+jpDUuulgFZnhRAxsA3lbClrlhkV8Ex9L0/vykr8nCp3H5wr9tbRQ5vZuMehHZRPsBL7lmEKWg74ZCW7XX0n7eXkrALdjY7f635prwviEo+gk6JWUxFLdUiIjBfG2AvzN4f7BPN31bzQrgBhq60vG+oQTtW3+g/2xqzFWTYugglV/hKZqbAjpaATU6qzr1Kc+f+Sf0jNJI7P5DDKVtx8iMDu0fxBXagbGetDsqUw7Irv6tv787kKP1/uT9bOI0yY2hPV195tG+DNBg72UMPppwQq8E2Q4i1mfr8A98Yk4/tXWoXup2OQ03TG+6EtbS6DPixg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(346002)(396003)(451199018)(36840700001)(40470700004)(46966006)(31686004)(36756003)(4326008)(70206006)(2906002)(8676002)(70586007)(8936002)(44832011)(5660300002)(356005)(82740400003)(86362001)(36860700001)(31696002)(81166007)(41300700001)(110136005)(54906003)(316002)(16576012)(40480700001)(478600001)(82310400005)(47076005)(426003)(83380400001)(336012)(2616005)(53546011)(26005)(40460700003)(186003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:38:54.9843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1efed36-b1a6-4a7c-8053-08db10f4b23e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A60.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4526 Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > We are going to use artifacts produced by the Yocto builds in test jobs. > > Signed-off-by: Stefano Stabellini > --- > automation/gitlab-ci/build.yaml | 51 +++++++++++++++++++++++++++++++++ > automation/gitlab-ci/test.yaml | 45 ----------------------------- > 2 files changed, 51 insertions(+), 45 deletions(-) > > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index a053c5c732..f62cf21f45 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -199,6 +199,41 @@ > variables: > <<: *gcc > > +.yocto-test: > + stage: build > + image: registry.gitlab.com/xen-project/xen/${CONTAINER} > + except: > + - master > + - smoke > + - /^coverity-tested\/.*/ > + - /^stable-.*/ stage, image and except are the same as in &build template. You could just use <<: *build to reuse them. Specifying script here would overwrite the build script and we do not care about artifacts paths (i.e. if it is not produced by a job, there will be just a warning which is already the case for some jobs). Anyway, this is just a suggestion to save some lines, so with or without: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 17 14:47:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 14:47:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497162.768060 (Exim 4.92) (envelope-from ) id 1pT20r-0002cR-Rx; Fri, 17 Feb 2023 14:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497162.768060; Fri, 17 Feb 2023 14:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT20r-0002cK-OL; Fri, 17 Feb 2023 14:47:01 +0000 Received: by outflank-mailman (input) for mailman id 497162; Fri, 17 Feb 2023 14:47:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT20q-0002cE-Cv for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 14:47:00 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20603.outbound.protection.outlook.com [2a01:111:f400:7eb2::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed34f6fd-aed1-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 15:46:58 +0100 (CET) Received: from CY5PR04CA0021.namprd04.prod.outlook.com (2603:10b6:930:1e::12) by MW3PR12MB4361.namprd12.prod.outlook.com (2603:10b6:303:5a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 14:46:54 +0000 Received: from CY4PEPF0000C968.namprd02.prod.outlook.com (2603:10b6:930:1e:cafe::9c) by CY5PR04CA0021.outlook.office365.com (2603:10b6:930:1e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15 via Frontend Transport; Fri, 17 Feb 2023 14:46:54 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C968.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.14 via Frontend Transport; Fri, 17 Feb 2023 14:46:54 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 17 Feb 2023 08:46:53 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 17 Feb 2023 08:46:52 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed34f6fd-aed1-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gfhsoWpKvEboWqECjruTy8m85zmOXKRHc2IRsWMUujvFwPXm+csuZfYxKDhwdESzQ8Xe+FiBP+QcQjepqZvfnAvdk9nj9n62SwVVs2i8ykZQI0c2L8xfcbZNVcPG9fAvE5UD7en1puploTLMEiJLuu6SZr7qZ4ITTcQlMygFCAddjAHh7PjwaNzXHhnFRLt6hmaugnQyeTBWgn9TH5Zf3ogUkEb9Hveh5jqJCc/fB4ICGOL8wY/GijGplBcTF8gnN3k/m6WUqbGGEYlwwMDKcXKwPAiez/b342uSZjuz63JdZ+yy4679wx8IJPSvAqDmOxVDh2aac4pVfAxnCmhk8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H8hmDbJmugK6z8TMm0u57Ez5RlvuXnspBHOmFJYuiCM=; b=UzuGX795v/PKO5CFDT6LSi8dlIuzfk9EZBgLA7s58rqSj2BaW6kN+QcE5s5dEH7XEJyDhGGFAKJZeexCS4JocS/h0weuHDKYka1X34S3q4+hpSvweW6FQ50ii6TV7Y87z3Aa7Wi309cFiV9LKiONGj821a1NVMvTCUkNkGPiAecGclsTgnjaOvRfMmtd//DV0cVbi1DoR/bQfkmL40134qbXJleO3l3RynmWEIwom73zyvOvgDY/QD+hiW0K14lM1rtdoQ0xmMnPLUsyvn8Djtn0Tup2agsbLDEZAbyF+BGge+rR9ONv6uj/rEB/yaqSsHIQv/yMg3vwHOuiJHr3jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H8hmDbJmugK6z8TMm0u57Ez5RlvuXnspBHOmFJYuiCM=; b=mKMwZ3LhVOCRwTSyTMFjMsqSo3Lufi4ggxdsnm5mwovT89biy78Da4d/vVf+Ru8/Ud+z2vxGPIeSUFpm3xy9Va18/nb7u9Yz9ufOFM/vH4zdq8lojJ5okT9TvqBUxFihra6+FNr8De1zh5jIbP5kPQvW+Kl5X81/QG6n8P8zARM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <1efb8c6c-e3d6-8815-4feb-fadc6a18842a@amd.com> Date: Fri, 17 Feb 2023 15:46:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 2/3] automation: add binaries/ to artifacts for Yocto arm32 job Content-Language: en-US To: Stefano Stabellini , CC: , Stefano Stabellini References: <20230215220925.2313528-2-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230215220925.2313528-2-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C968:EE_|MW3PR12MB4361:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9e480f-88b0-4b44-c4cd-08db10f5cfef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eIepxSs0F3hann0EN5yvcUU83Vl3svW4da1kuOx0WLM7e5g/6UH3ORL/bM2Wpo7pahRIP0EfOrC+zKEcaB6vVGHHZ6+NqhtVhMZlPoOAiNFMSCdLg3Oh/SrtvqQwoP/qfDsb1JPLZ7dqGpKfLPHPQdVErdIGcQctRNytYjoUyIAuKAskUHGN5C4FPDzf+w2tAmumg7sP/kpHuJ8giPDdwylAEXLRoUvuQhB+QMNUCT0FKopAnb4tW2mQk1Dd9m9PIoDVqPMPfCsE5riDc1bSiT+SoNdtAfpriHZOoq8jQfZLgZTdeif0MgUxdovAfRTxjJe4LcDNr8Ava4Nm2aK7DPzpE56EjmNiOfXMo9jQ1W/UBjsVwZt3Oqi+YUtYF4b/ptr58uRprqjs1rXyuYyDnv7eGYUMsJzIdqpOnEJyD4QLRfPxmTl8QZTX5NmSy5XN+dy+EDRmlziiJMQ4WRsvkcUKOvY2UcmG2dCvyTlHVLdm1pxfaK+HUi/9dqa91oO3YztTkOKjcVLZ5cD62PsIOQOGeBhBtQV4q1AzeWYpbQCdAwZ62ZpEP2kYK6p/SMp20IOC/JIVTosrqvK1sEKmS3WOS4k+tLZc+CRQvYr9HLxiH6mNjCYYETio8AngAJUNQwvTZ+3U5opREgpNTEaJzCPPTD34wrc35UxOE7nAnUc0ji9Lt1xG+6Y1xD5dGNtwdwwKYtAahK/WvwL77noRY9ylvHbQ2tp6qOHI8i5BASxZE+IJf3q0ubWAfVrmdDnVpIfCIcUstxXf7ymsJ/L8WQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199018)(40470700004)(36840700001)(46966006)(31686004)(36756003)(86362001)(31696002)(356005)(2906002)(5660300002)(44832011)(8936002)(82740400003)(81166007)(36860700001)(4326008)(70206006)(8676002)(54906003)(110136005)(41300700001)(478600001)(40480700001)(26005)(186003)(53546011)(70586007)(40460700003)(82310400005)(2616005)(16576012)(316002)(6666004)(426003)(47076005)(336012)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:46:54.3436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9e480f-88b0-4b44-c4cd-08db10f5cfef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C968.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4361 Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > Copy the build output of Yocto builds to binaries/ for the arm32 target, > and export binaries/ among the jobs artifacts so that they can be reused > by other jobs. > > Signed-off-by: Stefano Stabellini > --- > Changes in v2: > - only copy binaries for the arm32 target > --- > automation/build/yocto/build-yocto.sh | 9 +++++++++ > automation/gitlab-ci/build.yaml | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh > index 3601cebc3c..dd7065e5b2 100755 > --- a/automation/build/yocto/build-yocto.sh > +++ b/automation/build/yocto/build-yocto.sh > @@ -166,6 +166,13 @@ function project_build() { > source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" > > bitbake "${build_image}" || exit 1 > + if [ $target = "qemuarm" ] > + then > + mkdir -p $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/zImage $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-qemuarm $OUTPUT > + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-image-minimal-qemuarm.tar.bz2 $OUTPUT > + fi I think it would be cleaner and more helpful especially for those using the yocto jobs locally to add a new parameter to build-yocto.sh (set by default to n) to copy the build output to a directory (e.g. binaries) instead of hardcoding it only for qemuarm. > ) || return 1 > } > > @@ -238,6 +245,8 @@ Options: > EOF > } > > +OUTPUT=`pwd`/binaries NIT: seems like all the variables in this script storing a directory path have a "DIR" suffix, so it should be OUTPUTDIR. Also, why not to define it at the top of the file? ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 17 15:07:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 15:07:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497180.768071 (Exim 4.92) (envelope-from ) id 1pT2Kh-0005l4-Io; Fri, 17 Feb 2023 15:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497180.768071; Fri, 17 Feb 2023 15:07:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT2Kh-0005kx-FU; Fri, 17 Feb 2023 15:07:31 +0000 Received: by outflank-mailman (input) for mailman id 497180; Fri, 17 Feb 2023 15:07:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT2Kg-0005kr-SH for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 15:07:30 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20613.outbound.protection.outlook.com [2a01:111:f400:7eab::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cacb8624-aed4-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 16:07:29 +0100 (CET) Received: from BN9PR03CA0641.namprd03.prod.outlook.com (2603:10b6:408:13b::16) by MW3PR12MB4458.namprd12.prod.outlook.com (2603:10b6:303:5d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 15:07:25 +0000 Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13b:cafe::39) by BN9PR03CA0641.outlook.office365.com (2603:10b6:408:13b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13 via Frontend Transport; Fri, 17 Feb 2023 15:07:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6111.17 via Frontend Transport; Fri, 17 Feb 2023 15:07:24 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 17 Feb 2023 09:07:24 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 17 Feb 2023 09:07:23 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cacb8624-aed4-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ik7CmFyl2bnfcyqb1wcNi2DNYyiryl87ZdcbMfzjCqlsujK7XCWOMRvAzSyu8o2ZBJLqLFFFzORHnYKE4LB+sg/uEKGAYer1Gx1Qfl4Ep0bsyBDQla8iIahd2avWCdO+r3ruAosRtuyGt+1d10S/Vezf8FhDAqqo5mu8E54VAq3tWReH7wC/tq/QLKkezKjbb891RpiUkXMVbC+qdAb3jfWsv7wChwYJhwDKtRTX60m6OxYlJIKdDpgoxIVVSnMsVD9KQXfcyhu2v0MyY05DNzeza92t2CiiLN4kt3sL+MsoBIJL9j7B7HeNeTzA5Wz+9h2juH/FK0VwMn6d+iqssA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jRyO2MHh+DbXteudkWsMRH33LpmXKYv4cQpLQ9NGpTc=; b=oTLfuue1xquO5/m82RbEAKcv4knX2EyDv8o3oCOf5WaRyp1qcS/yro5Mb1p+5Ai3ZRcee2CX/24QHuj+a5P22qGiCEvRED8wQt9q9A2cMp5N5qwcgGdweluOjkq/HV9dc4s/xCebCrKq0GvXOmorQ9HRtlNdRfA7fIOTIq5vfVNduRnPm8OcECLBhD/hHTQcHnEF4VbdAYD2W0f2m1ksYudnLX5YrHxh9mJRCw5iYr4iR0VQxT3u7kqf/XUWulEM+XF5/u2QXniPprRfJEN/GRy+nvqxr9fMVpLcFj1lQJRrjUcA7D1T4KAOOaA+RNj5OVLa6bB6rFpRFVHMjAbpyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jRyO2MHh+DbXteudkWsMRH33LpmXKYv4cQpLQ9NGpTc=; b=pPCqcjoVyP2+Dpb0knxnedkiXpjyOQv1r3l2heoURQrXldo6hnbPKpqWOJv0C+aSW2MUbcBQROe6EJvafM7DUmrCW2msE+NexifH+8HWzBvi4j3OiSaSIsm0HUYcmAIKTvQI85J+Dyn5tCtpgZ9UPUM10phC7vJWJREsigWeS4o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <3628a55d-908d-e943-4808-b40f7330ae67@amd.com> Date: Fri, 17 Feb 2023 16:07:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 3/3] automation: expand arm32 dom0 test adding xl domain creation Content-Language: en-US To: Stefano Stabellini , CC: , Stefano Stabellini References: <20230215220925.2313528-3-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230215220925.2313528-3-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT065:EE_|MW3PR12MB4458:EE_ X-MS-Office365-Filtering-Correlation-Id: 4caa8607-a0d7-4cc7-31ea-08db10f8ad5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6jWiNP2qqDnIOQbtCswI05mhMYYBcqVmuXzW3BlsRkEnjmOs6V40gKFYGZ1gMRqzCgPgLCt3sihVUW6WnsCd7eR8jcLsh9zfpCiSP5mZQo9jsX2Xr93vRha1L8KrOXiPGJZLV2eZSXP5kh1c6AF9qYRuGZBleH/cIbp+93lpAqgsCmPKgRx8U3loE0c6tuAveTad67QvAvYW/tjb8P6a2I3x7rimhw32WzUbuu4EdC5Z2hKCiv3vrUcvCtnQeme4vqNhZoOYG42suJk00n88/e0auGBJyOR29LjMz+jM2v5WpyhbOaf0HuK5m+J/q3Wckh7i9n94yMGfEUaIuuaZgYEuwL8TG3v/j7W1jKTd9vbT39e9SDgzvjbs4J0ic0KxR8yIWM/8Y9+UUlU8/ezNPBc8n1rZGjA05fcUH+4FdokeguCKSQLa5Vbtm4dX4nyLnfXaOCJo1j7EthpSDRUHyAp285IbYpX53WMELR8Oh6PsJySf0hP414WZRsKchfN/VnCFNdvMJDhWgHSH+cujHjqthKDxWsiRRRaXNcLJEFyKK/LBe/wqUTuIP/EEGMOkV+8KGDFLlEL2uf2gY+0Y+0CuzhyWQXw9jo1QNgUk8btQB2JQLoo7i3BhUNQVM6XlzlN5OhxH7r5nRjL1KIAU8sjoCmk+izH1oEfJ+NTt8czFXeLINrIMSsXnCRBPXmGCnByTFcTYVcIOZ8bkaA+ElTRe7svtegKDzCmAWM0FA9ygFwc1pKvLNuwiy+FL+Uz0AjHAbTvJjZID9zf/hWADYJTFBup9AB++8d4PmdLx7gBsX0+T9cODk8+zsX4pH+EnuLTBsjHCdsNfoHl1MtXKNZJSRPxt+oceXb10tUhXc8U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199018)(40470700004)(36840700001)(46966006)(83380400001)(82740400003)(81166007)(36860700001)(82310400005)(31696002)(86362001)(356005)(36756003)(8936002)(5660300002)(44832011)(2906002)(40480700001)(53546011)(186003)(40460700003)(2616005)(426003)(336012)(47076005)(316002)(16576012)(70586007)(26005)(70206006)(8676002)(110136005)(4326008)(966005)(54906003)(41300700001)(478600001)(31686004)(1910800001)(21314003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 15:07:24.9219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4caa8607-a0d7-4cc7-31ea-08db10f8ad5f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4458 Hi Stefano, On 15/02/2023 23:09, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > As part of the arm32 dom0 test, also create a simple domU using xl. To > do that, we need the toolstack installed in the dom0 rootfs. We switch > to using the kernel and rootfs built by the Yocto arm32 job. FWICS, you also use xen produced by the yocto build. This is why... > > Remove the PCI node from the host device tree: it is unused but causes a > Linux hang at boot. > > Use xen-watchdog to trigger the domU creation for convience > (/etc/local.d is not handled by rootfs.) > > Signed-off-by: Stefano Stabellini > --- > Changes in v2: > - add yocto-qemuarm also to qemu-smoke-dom0-arm32-gcc-debug > --- > automation/gitlab-ci/test.yaml | 2 + > automation/scripts/qemu-smoke-dom0-arm32.sh | 50 ++++++++++++++++----- > 2 files changed, 40 insertions(+), 12 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 9570085a60..77bb1c362d 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -172,6 +172,7 @@ qemu-smoke-dom0-arm32-gcc: > needs: > - *arm32-test-needs > - debian-unstable-gcc-arm32 > + - yocto-qemuarm > > qemu-smoke-dom0-arm32-gcc-debug: > extends: .qemu-arm32 > @@ -180,6 +181,7 @@ qemu-smoke-dom0-arm32-gcc-debug: > needs: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > + - yocto-qemuarm ... I think there is no need for debian-unstable-gcc-arm32 which was here to provide just a xen binary. Also, with your change, it does not make sense to keep debug and non-debug versions of this job as it does not apply to Yocto builds. > > qemu-alpine-x86_64-gcc: > extends: .qemu-x86-64 > diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh > index 98e4d481f6..7a748bdf23 100755 > --- a/automation/scripts/qemu-smoke-dom0-arm32.sh > +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh > @@ -3,14 +3,37 @@ > set -ex > > cd binaries > -# Use the kernel from Debian > -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz > -# Use a tiny initrd based on busybox from Alpine Linux > -curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz > > +mkdir rootfs > +cd rootfs > +tar xvf ../xen-image-minimal-qemuarm.tar.bz2 > +mkdir -p ./root > +echo "name=\"test\" > +memory=400 > +vcpus=1 > +kernel=\"/root/zImage\" > +ramdisk=\"/root/initrd.cpio.gz\" > +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" > +" > root/test.cfg > +echo "#!/bin/bash > + > +xl list > + > +xl create -c /root/test.cfg > + > +" > ./root/xen.start > +echo "bash /root/xen.start" >> ./etc/init.d/xen-watchdog > + > +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz > mkdir rootfs > cd rootfs > tar xvzf ../initrd.tar.gz > +find . | cpio -H newc -o | gzip > ../root/initrd.cpio.gz > +cd .. > +rm -rf rootfs > +rm initrd.tar.gz > + > +cp ../zImage ./root > find . | cpio -H newc -o | gzip > ../initrd.gz > cd .. > > @@ -20,22 +43,25 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > -machine virt \ > -machine virtualization=true \ > -smp 4 \ > - -m 1024 \ > + -m 2048 \ > -serial stdio \ > -monitor none \ > -display none \ > -machine dumpdtb=virt.dtb > > +# XXX disable pci to avoid Linux hang > +fdtput virt.dtb -p -t s /pcie@10000000 status disabled > + > # ImageBuilder > echo 'MEMORY_START="0x40000000" > -MEMORY_END="0x80000000" > +MEMORY_END="0xC0000000" > > DEVICE_TREE="virt.dtb" > -XEN="xen" > -DOM0_KERNEL="vmlinuz" > +XEN="xen-qemuarm" > +DOM0_KERNEL="zImage" > DOM0_RAMDISK="initrd.gz" > -DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" > -XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" > +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/sbin/init" > +XEN_CMD="console=dtuart dom0_mem=1024M bootscrub=0" > With the introduction of dom0, I think it makes sense to grep for both dom0 prompt and domU prompt just like we do for arm64. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 17 15:15:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 15:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497191.768081 (Exim 4.92) (envelope-from ) id 1pT2SH-0007ek-FG; Fri, 17 Feb 2023 15:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497191.768081; Fri, 17 Feb 2023 15:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT2SH-0007ed-CV; Fri, 17 Feb 2023 15:15:21 +0000 Received: by outflank-mailman (input) for mailman id 497191; Fri, 17 Feb 2023 15:15:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT2SF-0007eW-S5 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 15:15:20 +0000 Received: from mail134-25.atl141.mandrillapp.com (mail134-25.atl141.mandrillapp.com [198.2.134.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1b8a5cf-aed5-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 16:15:16 +0100 (CET) Received: from pmta10.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail134-25.atl141.mandrillapp.com (Mailchimp) with ESMTP id 4PJFjv04Q5z4f3p0r for ; Fri, 17 Feb 2023 15:15:15 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id d53d8d41b6744d3fab9d754094dfa19b; Fri, 17 Feb 2023 15:15:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1b8a5cf-aed5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1676646915; x=1676704515; i=marc.ungeschikts@vates.fr; bh=OytXSUFJPDlxoWoxKxQRAadSAd1RNV+59v90xNYnEQc=; h=From:Subject:To:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:CC:Date:Subject:From; b=NAofd7kHyqnrUTX2CGDMTeeh6xgEyEoUZ8+0o0hCgC5xpVPVcMZNb/XPTcQjm2URm rxXmyycjMgqYejpPZtbYLyeu8et7+tcuhlC1splSVUi44HN/2m+L5lp3YO576GmNpY WVyOed4X1TiJ0aMHV+VYVcbGT1YwgXKQghaStndc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1676646914; h=From : Subject : To : Message-Id : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=OytXSUFJPDlxoWoxKxQRAadSAd1RNV+59v90xNYnEQc=; b=nmpiMXWUqAxalF3LZnXyW2poTsH08wdmrn7I+9wjbniIq2jbS/3R8qnlTuE219qOhWi6hw 7O8WGWpXrZYghdsnGezmYeKGMj+LUSozcYkjG7D1oY2Dxsn1cFfO4w4+ZWaSmueDz+WDyORh N5jx8ts+gBtehCZs9WAkBTgnPJ3/w= From: Marc Ungeschikts Subject: =?utf-8?Q?RE=C2=A0:=20Weekly=20meeting=20-=20Xen=20Gitlab=20Issues=20Review?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 48e5b86a-aec2-49cd-9e7e-fb489512856c X-Bm-Transport-Timestamp: 1676646913380 To: xen-devel@lists.xenproject.org Message-Id: <20230217151513.5052A145A51@mail2.vates.fr> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.d53d8d41b6744d3fab9d754094dfa19b X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230217:md Date: Fri, 17 Feb 2023 15:15:14 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-3KpOo7cLpH8IvQepXDgk5A" --_av-3KpOo7cLpH8IvQepXDgk5A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =F0=9F=93=9D 2023-02-17 Report minutes Xen Gitlab Issues review mee= ting: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ For next Week 2023-02-24 : https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*vendredi 3 f=C3=A9vrier 2023 16:55 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*RE : Weekly meeting - Xen Gitlab Issues Review =F0=9F=93=9D Report minutes of today's Xen Gitlab Issues review meet= ing: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/ For next week: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*lundi 30 janvier 2023 10:56 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*Weekly meeting - Xen Gitlab Issues Review Hi everydody, last Friday, during the Backlog Review meeting, we decided to schedule a weekly meeting *every Friday-14:00(UTC)* to talk about Xen Gitlab issues (discussion, grooming, triage,...) *Jitsi Room*: https://meet.jit.si/XenIssuesReview You are all welcome, specially developers and maintainers. * Marc Ungeschikts | Vates Project Manager* *Mobile: 0613302401* *XCP-ng & Xen Orchestra - *Vates solutions *w:* vates.fr | xcp-ng.org | xen-orchestra.com --_av-3KpOo7cLpH8IvQepXDgk5A Content-Type: multipart/related; boundary="_av-sQ_BtxO6VDP641vQIRyqBQ" --_av-sQ_BtxO6VDP641vQIRyqBQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

=F0=9F=93=9D 2023-02-17 Report minutes Xen Gitlab I= ssues review meeting: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q= 31w5HLOx/


For next Week 2023-02-24 : https://crypt= pad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/

Marc Ungeschikts (Vates)

 

De : <= /b>Marc Ungeschikts
= Envoy=C3=A9 le :vendredi 3 f=C3=A9vrier 2023 16:55
=C3=80&nb= sp;: xen-devel@lists.= xenproject.org
Objet :RE : Weekly meeting - Xen Git= lab Issues Review

 

=F0=9F=93= =9D Report minutes of today's Xen Gitlab Issues review me= eting: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/

 

For next week: https:= //cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/

 

 

Marc Ungeschikts (Vates)

 

De : = Marc Ungeschikts
Envoy=C3=A9 le :lundi 30 janvier 2023 10:56
=C3=80 : <= /b>xen-devel@lists.xenpro= ject.org
Objet :Weekly meeting - Xen Gitlab Issues Revie= w

 

Hi everydody,= last Friday, during the Backlog Review meeting, we decided to schedule a w= eekly meeting every Friday-14:00(UTC) to talk about = Xen Gitlab= issues(discussion, groom= ing, triage,...)
 Jitsi Room= : https://meet= .jit.si/XenIssuesReview


You are all w= elcome, specially developers and maintainers.
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solution= s
w: vates.fr | xcp-ng.org | xen-or= chestra.com
3D""
3D"" --_av-sQ_BtxO6VDP641vQIRyqBQ Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline iVBORw0KGgoAAAANSUhEUgAAAK4AAACfCAYAAABgKuLmAAAm4XpUWHRSYXcg cHJvZmlsZSB0eXBlIGV4aWYAAHjatZxpkmSpcoX/swotgXlYDuBgph1o+foO kVmva2jZa8lU1VWZFRlxL+DuZ3C47c5//ed1/8GvEYZ3ubReR62eX3nkESff dP/5Nd/fwef39+el8/Wz8PPrbtyvH0ReSnxNn3/2+vX+79fDjwt8vky+K3+5 UN9fP1g//2Dkr+v3Xy70daOkEUW+se8RfV0oxc8PwtcF5mdavo7e/jqF9TW1 r89/loE/Tn/dHYdeK+vzs1//nRurZ4X7pBhPCsnzd0pfA0j6E12afFP5O6YU 30vvlc7fIcWvkbAgf1qnH7+4rbsaav7jm36Kyo/vfonWGV9r9Gu0cvx6S/pl keuPr3983YXy56i8pf/LnXP/+i7+/ProMX5G9Mvqv8W/1u+bM7OYubLU9WtS 31N83/E+wpF16+4YWvWNP4VLtPd78LuT1ZtUML/94vcOI0TCdUMOFma44byv O2yGmONxsfFNjDum92JPLY64iVtIWb/DjS2NZMQxpv3CnlP8MZbwbjv8du9u nTtb4K0xcLHwkuAf/nb/9AP3qhRC0FoS+vCJb4xabIahyOlv3kZEwv1a1PIW +Pv3r78U10QEi1ZZJTJY2PW5xCrhX0iQXqATbyx8/dRgaPZ1AZaIWxcGExIR IGohlVCDbzG2EFjIToAmQ48px0UEQinRGGTMKVVi06NuzUdaeG+NJfKy43XA jEgUKq4Rm5Emwcq5kD8td3JollRyKaWWVnoZZdZUcy211lYFirOlll0rrbbW ehtt9tRzL7321nsffY44EqBZRh1t9DHGnNxzcuXJpydvmHPFlVZexa262upr rLlJn5132XW33ffY06IlAz+sWrNuw+YJh1Q6+ZRTTzv9jDMvqXaTu/mWW2+7 /Y47f0TtK6y//f4HUQtfUYsvUnpj+xE1Xm3t+xJBcFIUMwIWXQ5EvCkEJHRU zHwPOUdFTjHzA8RLJTLIophZUMSIYD4hlhu+Y+fiJ6KK3P8pbq7ln+IW/7eR cwrdP4zc73H7U9RMNLRfxD5VqEX1ierj56fP2KfI7revTjNvjRUI8HbqXrdv xdvlv139mjVY7qcXSmjvnE4bo8XF2Po+56wzNhTXorNcILFSOrVFGe7A9LnF NK3KmL3OuveqQXFodY9uQGIfkzocZ0Cv8/S0/XDHjzVuYJly3SeNUl+5pphZ wnA2ydC5/Gms3vWbhUrjhH59OqOcMI3qtTTNBUi/7wWM2upzkzUk28nDkwib peRNfVeuOYkcWVEWoyHtrJzdejkdFUJybDcy60sGdOZf9xzr7tVPLgZWA7un pRuJQj8ELu92/SHFjDBxrTEZXWplj7tcjiRQ4D5UgmkAhMlaKocx7HLjJAQl 9VJOmYvI1pLi7gW+inX1OEsjy85pbl7+BXiFxSL5wj8LObqCTULGAjEO1rnn wFVOKo0ViBEtRMFsS6GXmk+2c1ybjIVsz7WWXfhA8jt3VrhNhlQHFGQzHX4e ZjUS/aSpW55k96xiSA/L0ABTG6msQIjyQvgR07amtR6O1VNaM4TSYvixPq0R Q0zGHM3yu8WsA54kRg4as3LTaiSL7RbO1PULaxupwhzbYriRYgtjo35KhXsz eTLrqYUs3Zv5Uj9uz7vJCkpxmU+FYDZbKIZUQN6Qx76gQSdpxs0I0VlJRj9O 7kq+ESja3fKmRM4l+FVE0ts+FR0WSvOdwJ05zt61BMqn8P6sb3KROvzDV/d3 P+ArI2aAo+Vl5PoF2pjz7GUZf3ZpixEAFndYSd5ZbHu3g7q4hXRf5cRrYeUM qhAAgn8LRDbvzMHbmoHwGtULYwdAYuUWNffgiHnbCcCpfiRIgpvCkk0IC5MC djESpKS45mPpSOM23fU0tA24Vcoq2cCj0ljOvraFsVoKBygJaezT7LbGZftN dsqezHCWvfxRvjLwPQjcpNiJ0J7AyDk1jNJCzGVITzWSgMQPdw6GulgkQwyR PLycbZGTzOSmaicBIevmmMO8w92FvlpzFWp5VIubWS9KCtSKB4IrI5L2fs9F nXrrZyYwoTAR4MoD3iFQ9WE4BCJzWaQh6bqbNaqMer0l2WAGm8iV2QLVEU05 xLhPBy9yIFFLPZpF4JaOpSX5gfmRbh8xqzJnaCWBCZV/8zFKB73YMCswBIgc y5lb8Y+xGtzVUlzH7eZBm7JT2tQxeQBjWa2HdbwR7iqwwRi5Ax/oGWNGK+qe 4ChoR2neDKzG5YI/lfWf5Sq+eofFAEN11Bs1ukG6OOPRrM5B5RbgASIjWTpk OS4/7cPyJPyeRG7xxA0MrlJmznPtjQFsZfrT4csNvEYSgjFwXVYXSjA+yNio PXHFudRaXBQjl5IZYI2qRqLAHq7YrYLgc3cIm5QmkKx0hUJUfavDYmQVP9zm JnFBSPcKas+sFIaCFuIkGFkcdqvkk5HNKz9p3jdTj3B6k468jPV4gAOoLQR6 Znj9dooOfjjiNIqBP/bFpQav+Pm+93/z1f32A+gH4Ukq1JOgssPStw3Jwfyn whyQiGpvyfDNS6Ch2WTRLdsKR4+3mp04YMjSSbs4Ka8hCaw4g4Z8CJHEihCJ Qt1INC0iFkMfTMhRY/MuJnzJbjyHl3Bi8XoX1gP6jZrwECpaqwrtKA1WhUEb vL+mJAjyaTsqdiC1oqgFLO+oPZUQtE3ZiZt46xqinw2tJt6VVRKFNIROU7G2 8cD+uLoo2YFCGIb4AfP6nO1Ax8BvTJXc6wYHpKbvblGt7ZA6tcB4pKuQGMze 3DWMV52icGOw7aiwmrLukCtzCh9JP8ogGQxb6pOFYPm9naWRAVeSXqf0K8U3 iCsY6nKfVW/KAhNgp4IRtc7LgA/xKtQF9YegPNVSrHyu8SKpXtwDcEgEyqIe 9uNXBIJW1b9kgs9IZ2iHeW3kQkbropKAJ+IY4KZMAiC0CBdsM1rjSowX7fnU BzIuAohIyQbYIQ1hi0l2AyJA4eKGAAGhYLnCEaQ4FEJBb4vNIWgYRPKKu8om wWngQLKnFA6ITpUjdsXB6Yqtqb0pcRML3M8FVwuQBrIIgASuO/V19R+RQoyg 0akfOB+/la7ZZml5F682FBXw5jsy10Hz2QgSq9tJbCKU14K20MOpUR2dSuk7 XH1EQ5/Q/RVmiwFQ28dmb5J+YNlAId7Hrghw6NI/lkZ6/DtfixlubSy3rQAE udThFyrPp3Q8UoSlHcd4A3oe1YyER6rHhQIuZGEn6nBDUQZy45VGdSREAR6J BapWqnTiWU7D45jaIEgVrdtl+CdU2ADjeUVeyw4fWDs+n1SSO6jHLc24Qfk6 FqxNjlNVLXnk32DJK1oYyQuKAHukDjA8MAPoGeCXOidbNwRJmkGfUAicRf3o dnJESUKZ+k8d82Faki0rSGitzzVwC/sywE61wVitOxZ4oyqhn0SUIAwQDnc0 QAHAjgxgTRa5jtZjhan0+qXUScl+SRR0xOGaLgEhr6GAEQifCt8jI0P0flJk ngQQHWWxJFtH6zLe4tX3qipkxL8oxkFSTAqWQ9kcALxJBMaSVfckL1kzfTGP ifK3UPbob0IC65JJwCjv405ze8cIPD4EYAC9kK8suFJW/pRy0GXhfOCIT7CC Yy6KuU4KH7GLx9hG9clqOIwliQmeLtQw+W31bhCJoXX4dEaWmTVgqEVYB/YA Z6AnSh0J6GMhqTBUq1IiCMBja9cDTUEHU7MghUBUqTmsgkHYT1QDi4hHJAGQ vTEkvuYkj5V2yehsNAkLFAwEmRNjsQX4oSL3A54OjbcQa7gh3tQRAbFQ3qTG 9lsgenApESnmgB+jGKAkcAbtjZ6BLzHCAN6BmpBCcwSiTQIrTZFOqaNWD+gH DuaKo+x2p7N7UVpeFKGhBRyTbkj+XgkzxsK/GDp/GCJmA1RA5EdWTi2wSg4R NKY27t4SaKgqUtTjkRYpl0UAOxEk4Phc3M5ZCV1MwTI1ZMNDNDIuiJTAsoCI IGNmarfyXvlRrB0431hcFPcqCETCeNOtuGUuBm2thX5BmB0YGECmGOSy/85+ v68Lw4p5Yf2O76iggwZOMD1qRTl1JbDD83WIURg6S5PB1QaMI94lfMBYCX44 2cslSY61K/6naDCuBY6TkDywKdIAJKZo0eFEGQ6R7BURjryANggvspKA9UEy IyhYXMQ1ohBEgRzJu1wzMgq9TzGSkMOEQWTERMPAsbAQlA7q9+UX6IFF24ls BluJt+QVLoscQKHhQQnG1IQdeOszYoOy2RDpwNvqDhQWVjo3y0gguMEQToho ZJtxV+JUKOw4kCDUKF44uowWRMDkhiGW9qDExF19nxmBm2tCIPVgUBcCt8uS zLlQWih3ro3iAHgzVhQM52OsCT/Ez6IN+WHHQCw0PDWIcztNmrPydkqJIhJ7 YgrxMxdyRwaPUzHHeeM8wIvbgqwimabmNZ4b6s7PsJJD8ckXiEshRXQPVp2A dRYiV3WXnDy/YTNPqjgASLmAs9gx8jExJEAUEGhwA4DP2mK8WN9B3cIyov/G RRaGyQW0RCXeaPCLiwloClz+JSlQORQvNQqg14TyQFpPBA0IBuGRKig0hY2c mym7NVJsSKfI20gBTNWD4y9oHZVgQEa4INaBYbTMbTqItzCcBulQJLiNlNwH fEFJ7Gc4H6kUYUIYAlEzkFn5brIfTbdAIuXRAIqPyK2Qm9hww8dRIgnp2ja4 UyWu0IHrUDuIFwgLJ4Ptq6fLE+A9D9mHlInPZmCU0KRSLI14uziWBdAQn0PS 5IjlQUMhVHfWssaGbS/6GzLinixuxloP6PYCc4/Gr3yQw7zjGLH2IBGrsaXK KOYOJEGRh0msAS+q0plegcRZNwQNkSBdq4WI2kNmOO02NRINR0tCJzCIZV9k PwUInB2P7CUCFKotNQeh4N0lTTe1g7a+CRoAtR3FRI01WIc0Gr2jeFkhxBWu EQoCwLpnkkudJNQ6OI7p4q8h9Sr7nkhlVsNRkGgttKIZ3MuNMGUJ6WuMOIA9 3bxQOG4AFoAC+NXOeZ5g7CfOUPOM1pHxH/3V/w4m40SAqB1rPe8plGBuaAem i+CeRNTIK0cJTYUlHwQhSQ50Y/AoRji5W2bs0MVFOIBGhHKA+SsI7QZVFlHD i3RqsTksFmOlPvAdkXStYcJ82BByMQYSrNaGYasIGQo43ZZVyVXMBWMEQKKX 68sh/AE1UlId8ELfDK1FDCPrFpkJH5sUASwEBsBTSPuQZeD2JrS2YahANTFV 11dQq1rtWFhWbYUnUkORrggIYnQoVplspLCxL/29CFKkco8ujBrAXxyHNAas mIZym8TPZig66mdGqQA0a2pVPr0QZ8gy+MDMcH0kKAqg4DqYUVtgdvKoctBT zVNwgJzSTJFt2Fo8LbxV1RGs6k8EFU6mHGHfirzLwBI4hKpy6jUuxhGylGC9 KH302FNwWtygpUC78FG01lI3ed7LMnbKcUrhCR+gBzfxH5qSqbHNZxF6XVm2 qGx1eOS7jFXrSZtF8v94P0TTaZTQZVA9YGMlIvAp8J7QSXR4tdU7q2oSJAOX h5jSh8kyMqJUgfRIpC2xEGojxyEN5IubFZ84iXeEp9XO1FrbyqqrCDyk68FX YEwdAZAtlWcRDnx8yGN0cJKV9w7MuaoyqRRxlzQPQILqgehKUNMG9G5kE5AP SVR5YGMF8VsgyJYPiLfgRRAH2I09qV34HSETRaymlkhDYvFFu5hhJUA5xtrk 1DtUAHKR1vV5TbV9UOVzHaCWyr3Q7dj26YUaVNn/fcPlfnohyLfhFagX5Bwq 69ELyR4gl9s2KvBOuSVMh3wCmv+1JvZMz/dDBd4aa/xAnSJE4oC461G3evlj 1jjJf6z6IH+xikLGim9eQ9uEbZhrYBgCg7RJmHojSXANmK0Ku3p7TgJjLd6H 1Ej4HUuPBAxUJR0hogL7UmYsNl4ablQXrcqO1NI2iYeO56LIeaRUVa8nT5BB 9hFpjNEbZCQKSY3xJlvsbIbYnjNCi6NDQFJCPZVNGWinvJN6CKR9R0/h1kS0 Er8YaDW2N8KQFPausAo4yIDNmCQ3ghZUIK9kvckR9D2wF1Di0COvRxRxU2NQ zc+k3l4lwcq6rsULUWGWo5SfkR/oMNxAr0n7PkQnq1OKwmVlgW+GAhYgpyBu xMDBc0nBZMclcBlUGWasCH1UJ0gSbp7UlED8seLYCcww9R+Upw+PYBKApG2U YvLpOioc2JLBWTcAH1tdcQQ/YWuRIp0kNuDdwUG5r7f5xDxx6gk9S1HUFRrY 6IKOUeCUcScJfoMpKFuo72ovK4YQqUSkCQlPfjGbpL2HQaYhliCMpZ2GQ5Y6 lhjYR6p5eAiUQnyrpQDqkFP3IFNRM/ACYY/DTGZmdDzF7p4yQlCpFQ4jY2pw ayjb+LZSKytzyAybS1s4B505IcY91KuBEwFIct7uoZBQN4CTIaMPueuGZ/mo 5whtUNdloSNImaBtUAwLfN1RXyhkBDWwzFi7NBtRB5kRW9pNBRDMaRPvU+65 pf5P2it/LfbVULWvCYrI1/bDSqQ92CajeVrVvugFGZFHmbXqFQ5Gj7PMRBaQ RmcsVD946d3OR0UMQrxtR5wbpAS0gqirk7QocPDtykVi4utOkCE2Mowzj0dx TmQBybS40BWBQfpgJ1pD+yiwONhHul3BpxQWV8JaET/lpNcqErTI2jV5/w4Q uartko6/yIFvhDmUSlj19WJR0WrIs9Rkt1o0VLB62JAg2B8W2hOdbDBMcHVB MoxUO942t4eb4OKpVl2QImC2FZZWYyyomcEPXjc7elQhxgeZEMHE7ZL21du1 myVqsHOYFxg0IoQQP9R4er0W8iOJ0OJuW0PC9sWtPlqhNFnW46gjZrcZT8eo Qj1F2nDlcnBh2jBgGIFJYg+RX1fdeXmdzkxmNJjEUOZlNtcRktSwr9ryPt2Q EqDIwKYgw+L0alDBT0kVTWaC+7vfpcxGiwUyb6nHv7bLGw+HMtM2b/u0WFGj QAFy+YBfSELlBqZ9HFOLjvIoSwiGTzyIi6RdsX2dUBobL8k3UQ6oNSCLqio7 yVdgqNDUiMaKlg/YaOC3GrBP0EdCg1UqDlaCjpp6HIhwFE/QnimevXtJPRAc FYdnI/B4CGzb8VQ9ohGoqjDSYiqVG2hbfrhYtTnpXzhNHrYQUpQiA99cs8L7 UTsGUoJTWyjaxIckVsBP5nfYqWMx8P1UCDAGtKyFoJi1AkMF5whVJg3F1OzH +XkIlNWO+Af4lAVFpvQ7lyQYes/BweCcNijuXmDn7b5AIMSHrK3AQcfzR6/0 yyzr1g5qRGTierT3BU5CX0Cdo+jxORtSUwMfQgNjKobiG1uq/x93VX98df7f fOP/z4XQrKyQQe24MASGuL9bQst6ZDlvWoAz5SIRTf2zMAAzYFIR92qkqpWF VcLeC6BY66kyjHh93532mfldIDxpvxi4FgrAi/77EwLqgQF0acSOBLAV8a6F N5BSaD+kYdJxBKkRtPqtHbjHaSbuRjUBABkfGwgtMgLO9/XsMUgo8VLxfQ2x LsiXIl4M7+PUw4xxC6j35rMYn/vzvXQraoK5XB2JIR1JUvRSBdxwtQlzTKI6 rx2XEnFDCCYk1YaE0WPYT4EkN3y5LF4Hc3NX7xHEu1jv65EuU3vTOsvjSn0H TeTqAfqo4zddR4d8ax4PAUYh7aDfO+4AsaI2DMoEC2vdhnAh4wZwW1xSK5DR MYpf1lAnaj4z67+PmjBCL0YxHCijtusiwhmKxxvKgejzBHVzOXwnqgFwWSh7 BgXnqJrRWVvdfaH2jbkkUMUvHKRwSy6SKUXs5lIcYGSS5vdJ/Wm0o32G5ub3 2H4fmv91cJtcAuFFnB7c53MFAQ1krG5O27m1fgXi9AKxkYdSZ9BqeTs12LjX isZNI68Qs0AIvJyLyoSgwm9tYI7JhC3KEhgHtbPByXwYDByIsJfbswVc6+wW CYOivdQS9ApjlSu1GFbxUv4IuJs17iniVpS4vQ2QT4QGCU6ENfxsgDkMTrlU MQb0aSwdGaNWA1YUAvubvVxkHJUGqOOAQt7kDk5c7RJAq01UA7qfq09yMLhG NDN1NZP29PuldqeteWPVdjJWMlydNJQ0FpVh/UhezJjISBvjOjekNj/h10kP yWOsH6uHGMaisgQNAeELYQ77Y3XebjIAoqNA2BsEEIFicXXcB99vmOVV1TNI F3ZBUuaKsjlSAVtNY+0s4pyRgQSyjXEE32iaDglFirYbFHbx/RdLAkuetpg0 fiYGdCRrq+0rhdNQce0oXnBwgG5ginN5h5zmJhIduV+TEyZqI6ohEQ5Wh2Ed dcQKLk0t3ZKQ3QDOEjX1Vv3FgUBZpjNRI1MJB60dUP6wok6ZHJgT+Yvqw4lR +ls722h9fF7QDmel0iNqg4zUDFjsxji6OggHl41fUwdVR0ZC6aQGJIp+EiID c0ZVNrVEESpk/2Itr3aRieVQMxoTUkSXMm/uuY/8zAlFofPhgixEltqB1xBS hJJ6azqigp5JF62PHmf28qP5deR4xYHyx9SOydJsQy2UygLwxhGokbMl83LD 6peFYfSGBYBRMKM2Vq7aeqEcC4Ids3TV6H6ZTuBwFPgJmJlvQHxisuCC8bbb 9/DaVB0Zrtbukc5ewQJqjjowt7HWE2hEENi9KKqqTRrZ0hVxZUJF7Pc6W0Lr 6Him2nZZh1/iOwGjVXSBkWBGn6QkSwGZpO4/yhY00XYNCffGCiSkDMChgs8A +yqGHRxSg9/OTk7aBi80BIdGXiL+qHDmiuNbG76ksMhOLR+ufhMaGVQsKsoO uESzsZpm4+33+23etBPGL92UpcDCBWU3mNzVtUcbbb1AWeaedbwGB77RqEO9 bjjYRaEXF21SVQxmzBKoc9uwDWt4DiIO2QCJgAng/y6gLZndN+UYcBJN5zDI I+BK4hL3bzgOcsKrWYnuy20NbCXYRrCKtoPgLTweinn7VXVDzBO5qfM8YzgS GsOoYyZFB6LgBKCIdDdDbWBzQPLwPDf8XNQZTSA3L/SJzZj8UA3esZf7CLOD bdPB3D8roqr9Udm3pZ0M+MNQj8MbzN4wFxcnvJyaq0wy6+Rjxv9g8KunsifW FA/BmIz4Q4TzpIOgzV1nNxEtpWG3prQzAyzDeeqEPMLzok1b40YHiY+kx6NX Qsi15Wcg6aWhg5yI4FGOfCx1wlC1SiM64lyLjpBpgzm8bT7tg8TedCIRmFrv VCDABIri+JZ6+OqdtBhuQrlrR+dYd4h7yLcEHSTd6GhVPUU6dIIdc32W6JB5 KhBQChiVcNkrUXTW0ntoIBD46+5YF/jBqlPOSAbgAT4qmExybiIQKSivwwUZ /wSzUCtXA4euhU4VUCaWKTjA4mR1sK8xsL2eqhusynk9owPwogPTQWZ1vGPQ CcDdIU7eFhg6NYOmKur5o7goq463YDhXx1gM/MIaa8fXIxp0/C9REs9HRX6r NwThJWEAljiJ7xw0Cp00xG1TPwfFAHLpKQl/dI6YcL8tacPiwHEnJ4zPq8/4 OrxendSGhXHEEMEAmHudF8bQaopKMfgPfTl0Bkgf2TqdnpG+Jplzs863JTFj WAcI6w6ppJ0SxHyGjHVqGL4qwiF4DZgD2YAGzF0lsOgwon/1oAjIfjC2nRxX Uzg40jKMoX8sIicHpP5Xwt+9k3VeUT1oAcHgVoePMRSNFGZ6W1GA3/S47L11 GnRfaYqExmG5UtKR8gdlVGsj/4GloazLDAj6YbaxemTdODqkuxMG0M0MFqu2 SIwTtWfqBRAJrwUyzopVrl6HjRpRIEKv8wE2wKWrHgTJAPsEtfNo0/hFAC3A Dd6esVEb2lssgzlSYHCgR4Uj+6oIXk6vMo5oBiji8XGQxLWqr6oqyaYjZxVR ON5OiLW+0HpDMafgxI2FSIOSeppGbSkdgQw6NlGhbAxreMeaO9WMpNGZ0QAJ AcctHnUVECpqEIfLaMT8XQeug69wUQvomoa9cGkfpRy0HgSo2gdeRY3apOkO omIKNkoI4Djqj4mLQH6IMenmOg+FRHRfm1YXkiTN/nZHC1WDBtisLtLLr0Ta a/9rCWYBA234LrUukVZd54x76L7qyaG+Gf+R1D0oCqAJB6LKRyVoPxysQanO gXyJ0seGzZIgSO9MDzGjng0loxNuL46eGh1oOu1yIowBpV58IwA2H4ztuhje ojhcifs2ryOIhqeaLOEcOquBqx3ECqbhR+BMzWhHKf6zVmaE2rHWUUuSCWDG HWXtCZMDSU0BHX+N8EBWGwpNzdB6DFldWk2qFykdMgs80UEFPV4RElS6VnAL o1d03EQa0MAc9YmpRcJraHxyBeGIEGZygQVbr5BAjl+XwWkd3mkcTd7rMFrL VZ6yaN80KuSAdWuJggb+NCOdVLMpYmJASKikkqZEdDbD5DtAiKhUnV+7EcA1 LItsaBfd7N/h9AZxdHinvTsl9RPPtNvMReU+agY/jhQbRB8h7SW1PseQgYC/ QcYI4arJJ6+UcZADR5CRdlHaDv9AxWR1RcVi0XMPUl590KTm45MAY/WlE8Y1 Te0Jo5W0CbVsoF7xjy0Z1oWrl/IFaTDeB9ISiPRGQ3VM1vo+VMQ6Bgz3BelR cU5OJQ17khIVgoZBXQ1j/vgp4jJMx60PAg0FopFXHSSHvX/BUfcTkJazovrr ADeVeXwt1BdXguOTpChFKoG+u55+MnRgkmMrrIK5ObAAynVZaBKRUbfzJrKO L0qRv8znzWYPqQ+qAk5d2u7FVq2rJ1h0ejXorNzU0SOdxUchfNr2k4T34zW3 oZyQ/3U379/9dDdEiNSIHnlBA189VVR1RgM8itPrgRLteQ30DTaEbNE5Edwe 0TAdTAe+HrqC76yfd6QsBMfoyHc+CBSqs7LUISAD9pT3bu1PuLAAhKLTVwlU Oq69XUDyyriYWlIr6qDYVOcB8CezqqaFatDO7tQzEg2hijCLIyxLrFXW6VY1 NKtcjI7HnWY68IPa1uPDUYVXtUcjh4cy0qnTI+Ir/etRC1Dp+0Cn037hMZ3H BWh6fudXoQ2DjZAgEABGtqFetSGQZPt1bkb9IeEaK7tX0IFFlL8ekEG/qpmv apOOkAJfcELSqalS9QSOdm6pTuqaCUfspajcK+6EHVGfdR7yneE22SB8xL8y qGJeH5PgpNsnhYoO0vDm9jmAMtunb4Oiso8XyThe7S/r5HlSH2ZVrPJRSwQx KfV+f7qX7pTePljXoYwE1zqv1rYe22lBp+fOmDGKei7CVU/qaIOx+dfVwG1o r1znqV+3cSMATMdaqEamtq72unb13evgWJL1U/97+Pf4VxVibz0uhmYkJUER zAq6O8hg6/kHaGLrFKueWwHM/e46fagng8DrY6anGfaV4FDL8zA+dC6qwN+q xpT8MchedXwKh39c0JNoF87ziMrxtcJ/WV/yoSFu4LQGsthmHjAy6by1PYfW 06FrH7MjrlsgtbxBuLpQ1YXa94Xi8xAe5sWLBsKuh7tC8Tr7dpCNkJ2O/Ban 58Z+D3R+GdF+itJVH4zqgEYoJ27WdTRCJ4sA5ekgXC9/iO3QU9wqzS6JjKFH FCDRCxoFhAgvcXw0dZd0EpbYlxqwhjrjMrHrkyqbpdg7mzY1h+/xa1PqGNZF zxOyKKbVxfLrUbKLdiHZHy7BVEkPntSHuwnB8g0QQ8ckGqrkarfyqeyLtAJN sMNaXD2F0CAK7VagxKEj70LQI5RepwcwzGLtGrInq/bRc80jk/aoBPQs5I7O CP6CmTfFrtPwwDmSTeN0fx7oH8fZPuP8HA75daSSfnok1mIEzScJl7yIcckV Yt/6x6v9SIsf+RXV+s/Wi/inJu+yTvvoZKwOMGRI8Wh3HJcHStX/cYFr1Olt nVsPlLjTg+AYvPQNEXt9rfBn1GGzolx+NsGDrqPNdj1yMdfrISRIXgF3wi0d dQnv2EGbOYK0oANiE7/3+R8ElKwjOkYt6fzJ1rFFCAiunF0n8UH105x6u/2d s6CueC8aZWLowSdqyy/R6aDGk/oeOvgdYNzp/5L48QOFTl2ydzud290hYIn1 UDbqdH5qoiblpU72j6ND5qHgS1Fs1D1LGEkhYgOLpLXD3GCQThoWSBHmRymq laltPcjToi549PRbVAcpyhz0jiGfgUigglie5CKUixIbb1cQw6fI7qXnPYcU NCUStU/lwxZSEr4aV44WMWnLrg5FA8iIdxfWMp20g5HnV3+PNfru7wVpGSbX 1HUrUpZVR9JT1qF9eHRR2k197eFsjIYi9NrllvhHNlxtwUG5V8dZcfWsfHzN voSEfE8x1iZnhvOyZ9DWTlf7/QxnUjMIh4iIZL5JZ1dJEGgCOga3buO1Tm1V PYnbSSevTTu15hIXJufV0QLS9ThxgVWv/tcEEF97nRLtRkxZS/8auuTMfhpC F23Ub1ZTOWtnlDjqqOd7qIvKQ4aOT6niuD+F8Kb5Cpzw4z4/Wxlo3vg6pNpy YbV0cMnFsHgbUqYundrX8TcdhD9BnZC3Al/X/1z9c23/dfWmq+M8qCLtZcNw aBltgOgJwaRBH1YTL+vzeyQiqxdWt9ScpZOzMr8h8VLX/75BveU+HHX1lqEh CFG4lpCG2p0ZMLE0vp7mJXVhx04IR2N9vY6XHD07YnpuRKSxigNXq8zX2xH+ vmrQFnkXk34vw4hSNDuCpkl2IOg5Gj1lgfE8A3PiekNB6Fk+VgJHTnVsMbSa Fd+XlXq1PpYdibF1SalsH/qa5VOy+SLYS9HxFfWlNtUBs+p8BUyCDvRBZk9t MSipvP8XRg7azQhJj1kyzLNg213PdTCeTlJTE72mlMZ77GzrkRXBjXb71ipd 55a2Glx6diuj9H1epWHCxJuqvUr4jzr1yKKES1xYftMeI4HzehSydmEette/ p41SVtWwGClRy9pe1lnzBMAyIrTJ0mGLIypX6Lok8ce4EDxdtr3LAgXaTBp6 4Kd1oq4d/2PKkFrRR11PAp7wykec4aGTqFVO611svYfQ9NTppzxIO6FMHDJk /bwD8Se497gOfF3L0YYBWBBkipUwOuZetBuvDa5P1akzrII4uF21OLWptgZO 6TidysQmyAlcM+0X6lQQmhEIkGBtepZ963jC1tEZkinO9lkJPTvyulkarvtY AkYshwUpH4nHV0B6qF3PFyQ9w9yE0jonpHOJeuzWH6G8nod4hd0cNbY//SPU ivS52PKsqh/DhTZQhbdKLSMr9RzK0D4j2ZIMnNl6eNSTqdXpiT+CgEfpLHuT avpEuuAFlKY6Y+kTSLBAfjSf9uY/R7DexlQNldie5ChkcdeM7+i72nY23H8D uWZ05wi91FUAAAGEaUNDUElDQyBwcm9maWxlAAB4nH2RPUjDQBzFX1O1IhUH C4o4ZKhOFqSKOGoVilAh1AqtOphc+iE0aUhSXBwF14KDH4tVBxdnXR1cBUHw A8TRyUnRRUr8X1JoEePBcT/e3XvcvQOEeplpVsc4oOm2mU4mxGxuRQy9ogsD iCCEuMwsY1aSUvAdX/cI8PUuxrP8z/05etW8xYCASDzDDNMmXiee2rQNzvvE EVaSVeJz4jGTLkj8yHXF4zfORZcFnhkxM+k54gixWGxjpY1ZydSIJ4mjqqZT vpD1WOW8xVkrV1nznvyF4by+vMR1msNIYgGLkCBCQRUbKMNGjFadFAtp2k/4 +Idcv0QuhVwbYOSYRwUaZNcP/ge/u7UKE3EvKZwAOl8c52MECO0CjZrjfB87 TuMECD4DV3rLX6kD05+k11pa9Ajo2wYurluasgdc7gCDT4Zsyq4UpCkUCsD7 GX1TDui/BXpWvd6a+zh9ADLUVeoGODgERouUvebz7u723v490+zvB3gHcqkl oKXxAAAN/WlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPD94cGFja2V0IGJl Z2luPSLvu78iIGlkPSJXNU0wTXBDZWhpSHpyZVN6TlRjemtjOWQiPz4KPHg6 eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1Q IENvcmUgNC40LjAtRXhpdjIiPgogPHJkZjpSREYgeG1sbnM6cmRmPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4KICA8 cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgeG1sbnM6eG1wTU09 Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iCiAgICB4bWxuczpz dEV2dD0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL3NUeXBlL1Jlc291 cmNlRXZlbnQjIgogICAgeG1sbnM6ZGM9Imh0dHA6Ly9wdXJsLm9yZy9kYy9l bGVtZW50cy8xLjEvIgogICAgeG1sbnM6R0lNUD0iaHR0cDovL3d3dy5naW1w Lm9yZy94bXAvIgogICAgeG1sbnM6dGlmZj0iaHR0cDovL25zLmFkb2JlLmNv bS90aWZmLzEuMC8iCiAgICB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5j b20veGFwLzEuMC8iCiAgIHhtcE1NOkRvY3VtZW50SUQ9ImdpbXA6ZG9jaWQ6 Z2ltcDo5NmE3ZjI0MS1lMjNjLTRiMWEtOTdjZS1kNmU2NjliOTk4ZTIiCiAg IHhtcE1NOkluc3RhbmNlSUQ9InhtcC5paWQ6MGNlZmJjNjYtNjFiMy00ZDZk LWExYzgtMTg5M2QwNWFjOTg5IgogICB4bXBNTTpPcmlnaW5hbERvY3VtZW50 SUQ9InhtcC5kaWQ6NDIyZDdlNTItOGE2Ny00NmExLWI5MjYtNTJiOGEzMGIx OGIwIgogICBkYzpGb3JtYXQ9ImltYWdlL3BuZyIKICAgR0lNUDpBUEk9IjIu MCIKICAgR0lNUDpQbGF0Zm9ybT0iTGludXgiCiAgIEdJTVA6VGltZVN0YW1w PSIxNjU2MDE0ODk0NDU0Mjg5IgogICBHSU1QOlZlcnNpb249IjIuMTAuMzAi CiAgIHRpZmY6T3JpZW50YXRpb249IjEiCiAgIHhtcDpDcmVhdG9yVG9vbD0i R0lNUCAyLjEwIj4KICAgPHhtcE1NOkhpc3Rvcnk+CiAgICA8cmRmOlNlcT4K ICAgICA8cmRmOmxpCiAgICAgIHN0RXZ0OmFjdGlvbj0ic2F2ZWQiCiAgICAg IHN0RXZ0OmNoYW5nZWQ9Ii8iCiAgICAgIHN0RXZ0Omluc3RhbmNlSUQ9Inht cC5paWQ6YTY0MGI4MmMtMDg0My00MjYwLTk3NmMtYTg1ZjA3MDc5ZjcwIgog ICAgICBzdEV2dDpzb2Z0d2FyZUFnZW50PSJHaW1wIDIuMTAgKExpbnV4KSIK ICAgICAgc3RFdnQ6d2hlbj0iMjAyMi0wNC0yOVQxMzoyMzo1NCswMjowMCIv PgogICAgIDxyZGY6bGkKICAgICAgc3RFdnQ6YWN0aW9uPSJzYXZlZCIKICAg ICAgc3RFdnQ6Y2hhbmdlZD0iLyIKICAgICAgc3RFdnQ6aW5zdGFuY2VJRD0i eG1wLmlpZDozYTUyMDNkNS04NGRiLTQzNDMtOWZhYy03NjFmZDZmZmFhYjgi CiAgICAgIHN0RXZ0OnNvZnR3YXJlQWdlbnQ9IkdpbXAgMi4xMCAoTGludXgp IgogICAgICBzdEV2dDp3aGVuPSIyMDIyLTA2LTIzVDIyOjA4OjE0KzAyOjAw Ii8+CiAgICA8L3JkZjpTZXE+CiAgIDwveG1wTU06SGlzdG9yeT4KICA8L3Jk ZjpEZXNjcmlwdGlvbj4KIDwvcmRmOlJERj4KPC94OnhtcG1ldGE+CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAg ICAgICAgICAgICAgICAgICAKPD94cGFja2V0IGVuZD0idyI/PlmiVpAAAAAG YktHRADwAKIAftw2PhcAAAAJcEhZcwAALiMAAC4jAXilP3YAAAAHdElNRQfm BhcUCA56CWQaAAAgAElEQVR42ux9Z5gkV3X2e+6tqk4Td3d2epN2tUlhJRSQ QEKABpFE/ggm2SAMxmBbtjA2/uwPJ2wwGNs8BBuDbTAyOdnYGIEtECMhhISQ YIXianOc2Z3diR2r7j3fj3sqdO/M7Ehik9TneXq3p7u6uvrWe8894T3nEjry mOWnT79UFdaUledrUoFPBADWAgzYRoio3rTR2CQfuW/UPuPgdu6M2GMX6gzB I5MvAuqiN7+8N9/f1Uta94C5xzbCZQCWE/MSUqoLzAFZVrAccWRqNoomOTIj 1vIBT6uDNjTTptqYmtkxOnHR5ntqnVHtAPe4yAcA9aprX3O231N6ktJ6E0Ab CLyWmc8gYFApBTADlsHWAswgZsAwYC3YMmAsODKwYVSHtXs4srvYmK22GT1g a817p3cdvOein9871hntDnAfs4x95DeWB+XBl0S18MW1feMbibEUhD4AgAXA DGYGCVhhOXkNNn7YBMDuISCOH5FpIjKH2JgDpt78cWOy+vWoEd1y/o/ujDp3 oAPcBcn0z79O/uKlJZ6aXG12bX0bwuYvAeiv7DgYmJkagWXAmMEWABxQs6CN wcqMFKjt/xsHYjY2AbH73xgY2zC18CFTb36Cm9G3olrz0Dk/vqvZuTsd4M4q tT3f61G54tNA9FoeP/wqs3NLCcagfmgS9f3jIM4CFSBmB073T6phGQDbDHjb tW1sPlhQon3NUSBGZGEb4RbbjK63jehbY7f85L7LEHa0cAe4Tr4P0OUjt7xA 5XK/CqWv4kp1UfTQPUCjhqjWRGXHKLhpkNW2DsDynMkBVQCdALXNdKDY/s2Y DWwtyLADa6yBI3kexQA2sI3oAW5G/9mcqn7irLt+uqsD2ycwcOt7vqOY9BqV L/wx+cGLoPQAIkPhQ/eCx8cAZtT2HUHzyLSAVAZMNC/Hmje2d5E1F6zYuQCx PE+ctVbTIQYtotgeNmDDgDUpkCMLhKZpm9HOqFr/a2v4c9GRmfDcrQ89YUNr +gkJ2t3f7qEg9xKVy3+afP/ZINUFIjIj+2EO7AGshak00Dg04bReLC3gjac9 y1NuUwecqoW246ntfOCMCiH3lI5WK5qIFmtPX03Aucr3HvytpUsP//3IKHeA +0QA7Y5vbaRC/t0IgveS5y0FiKAItlJFtO0hoFEDW0ZjbApmun70CZgyiJsN gTHwSMwKyiA9A0aOj6UW0B6FYzpqUfSUUptI0ZUKmH7TpHrgk80p0zEVHqdS ve/LSnV1PY3y+Q/C858KpRVIAUoDDITbt8Ls3ApSCrYRorL9oFu6E13q7AVi yuCWW7VwxmEjMR1iBy0xGVqiD3GEIXXYkHHYkvdixy1yNm9sPnAzGjfN8PP1 w5U/O3fLA0c6wD3JwibSbK0GW5+NLbCNjA2bDQ6bhqPQchRZNpEtrjlrQctk 9YEv+6pQeBHlCx8nzyuz0gTScMBVsJUaGrffArIWpBTqByfRHJvODBCJkkyX f7KZEUwiDXL9MTiRcdjaw2aZBEUK3NjObQ2XJeCNDDhiUGQcsCMLNE1omtE3 o0b4e8pXu9bdcfcTwnTwTrULMmFjEVuzni0vh4lK1kTEJiKOIsCaBlszzdZM sAkPTz949xSHYQXM1Z4nXTbrclm99/NFlcu9SeVzH4BW3dmVGaI8w507wI0m oBWstQgnKslSziCQ876S5Z8TwLZaDUycrPMxnlODFanZEL+usrpDOa1MBCiV 2gwxyBWBtQLYgKHSL2b4CniF76mSZf59APd2NO4Jlqg6vQTAZTCmLwYsoojY RMaayMJEPhujOQVzncNwkk1z3IbRITbRyOJnvHAyNQ8+X9CFwrWUy70bnt8L JaYBacTPbb2J6i03A40aSGuYWhO1fUdafKv5BooZIMqALLZtmVvBl9W0nIn5 xq+bWTSvbYvtGuPeiyMNJmM6GAbl9O3N6fp163545487wD1B0jh4gMjXl7C1 Z7GJFKLIMts9BGxja2esiRgmUjYMCxw2+zkKl9owLLOJijARWRMZNlEdUTRm w+jhXF80mh/w30aF4l+S9rqgtQNt/CD3f3PvftTvuhPEBqQ1wqkqmmMzqe16 1GAd7Zy1BA1sm/0bZ9CQPncWRzZpkUkNcxa8DDbGxXqtgDR+L5S/TQpgHXgM ojubk9W3nXnrnT/rmAonxK5tehzaIluj2Rpma7eTUncWVp8Vth06PrX5tgNs 7QMwkeJmY4BNuMZG0UpEUcma6EzYaD1pfR4F/luIkBPPqQ1qTqWaI0fAjRBQ nNqnQkkEEZjIEWbiMxBnIJzGcuNvOEr7QlQy24y1EM+KTMRBUaqBKY6JMUgp MDsnEZ4CIoBgwR5l7Q2AGTay5HcFTwl68h/ceeVT3r7m5h9v7wD3OItt1tlG IWCMYhM12PK+nk2XhLMd23PB0xJdBuAAgAOj//VZn61ZbqNwdXFQvTS3uPBG Isq1hKJa9KN7bmZmwGEIaAcAHXiIFDkPPrED2j5Oqf3bEpeNTYckOpaJAVNG UyukSQvKfI2iVr3ODsCkyH0LE6Al2MYK7AGAkRMy2DAsA7rgP5eZ37v1souu XX/7T490gHscpbj6rGjq53dU2BogipS19hF5x4MvfUMIYFf17n9eqoq5FytP dR29zvNRhhKDYKMISkLa5Cn4/UUXVbAupcs0Wyx3lvPNYnsxZ4E9WzzXARNW JgQh0bgOsCxuoYA30bAWBAX24vnrZoM1FirnQxf81+RQOnQj8M7nOnQ/rkSd UhGFWvWgqVUiU6/6tl7pfcSx2js/PkC++jPy6KzUPIhVIKcevizDYED39jiz MjJgE4EjA5UPECzpBnn66Ngrs3ATRCPDgpH+zVnGWBwBludHWcYUTx52c4FE 9SqAldPApMhpYqXccy1/a3ccKeVWC3m4cxEo5yld8N941vOe9pbHo8Y9pYDL YWO/rVWnTK0amGqlPPrNzwcL/ez4v/+5B/BvkadelLC42jJaRyk+ZgTLlwF+ DhxGCXhhDXQxQH55H4LFJaiCB/KUA1qW6WWt8HIFfAkrjJNH1gim9vgZ0tBZ elnueCKn6V14jEQLKwE2pWBVAGnKAFdWCN+DCrw+rxhct+s5l118/8aN1AHu cZJFV1wd2Ub9XlurwNSqK2zYGFjoZ/0l3c9Xvn6HI7s4NDHzLIt5JjEAhtff i/yTNsGGkQNvaMCRAUcRQIygv4TCikXIr+hHfkU/gmX9CAZ64C8qwesrQHcF 8IoBdM6HCjyQryWRHpNonOfPcTQgq30zThqJicCKkjgxqRSryGpgUqlJodwB DrwO1GzZTTRfQ+W8c3Uh+N2uM5eUOjbu8XTSarVdNmruYWPWsok27f3sRw6u fMN14Xyfmfzvv1iuct4fgdADy26pzWhVZLQftdu7xCiesxGILGp33gmERixG 9zkLgDwNnfOAonJLM1HCMcjGGBJeQRLGlZBW5GxPjgw4NOBGCNuMYKoNl/iw 6bUloeBsAE4ULospQYpdEoKNHJwlO5D7Lq3Er2RoBK82kfnOtisv+cK6m3/C HeAeBym//E3R3s999CdsomUcmY0cRTsBbJnr+MOffZf2unJvIOJLnBtunbPC FiS2KLNuATC1k2ICH8WLNsFbsgi1n26GnZ4Em2YmicCwrKEYYM/ZlaQAaOXA SgJaUuJXCdJiGyFW8vH5LCdEdI4MTK0JU2nAzFQRzdQltSuJB2KXvYudNY41 NLtMGqwYxNYBWJGjRSoCPC+2PAK/K/eeqBF+F8BoB7jHS+vWa4c5MvewNU+x xlyx7UPvPrLune+btZDQX1TaCMIbAeQSMncc0FcshYtWNJQAxrLEbV1CF2CQ VsiduQrByuUIRw8hGhmFnZ4G12tAWAfCJtiGQDNyqWGtQUwg0oCWeC9ZsCzj 1OIJphExzsRsiQHyPZCn4ZXywJIesImBXIep1GBrTZhq08WaORMyY7lyFcfW 4siDcpPVMpSvwYEnsQhenesr/h6AP3g8APeUNdh3fPQ9RRs1n8/GnAFjdrAx 393w7g9VW0yEb/yxTznv3bpU+DOVCwDfB3nuAc8HPA+kPEDLQ2lAe+CWtK9y z4lApNyQKPc/hyG4EYKbTQhXQlKwkctagUHW2cQEYX+5WDQoioCoCYQNcLPu PgvKmDApo6w98ZFlidlmCFMPHZCnazCTVXBkMsWYklXLknUiC10K4PcUHYss ioBmBNsItzanar+0+pu3/qwD3OMoD3/gXQNszP+BMUU25ic2Mnec875/TOqu xr/yByu9ntLdqpgfoMAD+YGA1nP/ax+kNaB9uJSvgFd5gFIOwEqlXpBSmWVe ZZIPqjUR0ZIZQyvN0XJS/ZDSFg240QDqVXB1GlyZBlcmgXpVQmwSTrOcOHDc UuLj+Ak2isDNCNFkBeGRGdh6U0p9suAFYCzIU8gN9gChTZxNbhhj6s0PTNy7 /z2bfn5/2AHucZSH/vTajWzM89gazZG5ka19YNPf/SsDwOTX//B9urv4R5Tz iQK/ReOS5wlgZ9G6ygMrBVKO2ug0MBBTHSlejikT8CeAWbUl0lqdojTjlbFr M5oxKWM3wjlo1MEzU+DpCfDMBNCog8M6OGwCRiaAkfhwzMmNARoahNM1B+Bq A7YRyXnTmrf8qkXuPKERu9nA1sKfR9Xmq1Z99aYtHRv3eCYlKpWtUKqPjbkC xj7LGtMEsPXwP//mMqXptWBLR3NdnZYisgBZMImjJsTw2CYErLMZrQWRcl67 smCbAShJViqpfKC20FqWdBOHstLXKE4oAGAoB17tJgrl84CfA/UtdsCqVYDq DOzMJLgyBcxMgK2rTI/TvkkGzdPwe4vwSjmYSgPRVBXRZBW21kiiDCyZwGxZ kcrx+RSZK3a87BnbzvzPH5y2GbVTvnTnH370M/7NS590iKOwyCZayZFZ/mtn rR9dvGnJy1TOfwV52leeLPOkkqWf4r/lQXFgNKMhCRLgByVJqzRcRq00B8qE uxJiubx+lPZFi2kRg7m9Lo3bExGeD8oXobp6QaV+UM8iUL4AGGcvE7ddV3zN noZXyMEr5qACDxxGYGuhSzmoQCe8oCTRYblP+frLH7pnW9gB7nGUj9+x2fzG xecesM1oKYxZpjXO6FrV/Xqd99c7G1biq0olYak4ch+HqwAl2ah2AGa8/hha TKm2nM26mqWSkaid7hh/dyuYqf08NJsmJ5DWYD8AFbug+5aAuvqE+hhJ6CtT jZEkLBR0zoPXlQdpBXgaKtCZ0qPkWlc2p6r/+eH7dx7oAPc4yz/+5L7oN87f uIejqKzz6ik67w353UFR5XxQFrixxo0B2wJeJGGjJKqfZNFUGxYpA+A58EuU wSQfrXUFnDQLIz3W+URHfwFTWyElKVCQg+pdBOruA5QHshZswgT0JMmU2KzQ +QC6qwjl+RLL5qzWJQDVD/1s6/90gHsC5BObH2q+/bz1I7m+4GkEfpYJDfnd OajAl4ySSp0rSvP7FCcDkvwpzfL/LG5rsiRTK7E8k5WjozTzLDbwUeDN2MDy eUosZEoATekMSTW254FK3VClXqhc0dn1Yf1oCgQBKshBFQsg7WK5HEWp4if0 vW5L/dP/1JiMOsA9AfIXb7lC5RcVXmItPzmsNhHVQ/jdeSjfazUXlErDWImN mzUP6JEHVtiRZx3uCG053xatfrSKbbOFidqOEB1MbYVqbXZ3ch6tnT1c6gEK 3UDYAKIo07OBQYEPFQRuRfI8kOc57oS1IEU6WNXzgw/fs/207IzjnXYXnNNd 5HuXeqUcZkam0RyvYGr7QfSsL8Pv1s4OJAkjkcRBYR14LYNhj4Zqu8mb7dih tDtPrAI5Trva1AyJqxYSnZkloGcKexTJNcQvKYl6xH4jAVaBlAWzAhQjtYA5 5T+wc7gckTwPpT1QsRt2/BB4bASoVR2NR2vAc+X35DOU2M5mega2Wiv6/T1P N8w/auzewsrzTX7FWu4A9zgJG7uYPD7Xy2t0repFZf8UGocmMcWM7vXL4fd7 SdM5F+aKg/tGaCyUhMISZRnnYpXYiUoSCETp/6QkR6tS+1ecvZTdZVu1aYsT lzEbIARxJba1UCIpS9Zjm8SQKWPJZvluBBbwimmwuAyUemCOHALGD4GUA2pM u4yvxOvuhvG8HFTXUOWhzbfrXK5mrZ2sHdg1rTx/mrQ3HSxaajrA/QXJyJ++ kmy1cb7KeQEsw8/76DqjHzN7J9A4NAUbWXSftRK5xb2upFy0LZEFWwLYIOvX J0kCBZCSrBepjEWhWioSQKJR4wSFOhrAiPmwMZOrxXrgpM6MbOoTAgAsuetw vLS2OHEavyXWLcVChEjAy04L5wvQS5eDu3qByjQQ1Y6uygBDI09EXtkcPniW GlxWBxETUZ1J1UipSnPy8GGl/f1Q6pBX7LId4D6WZMRMhWDNxV5vIUmRenkf 3WuWYGr7ITSPTGPyvl3oPXcNckt6QUYIKCZmTikwmTT5QNwKYEmUOWXHDszK 1X7F3j8RA5bSpEQM7qTVAWcAzWn4jdEaKFZZ8Aq0bEpddCnoWfxFHWvgNJjr XvdSzjoDVCwBQQnUqMPOjIG4hpTX7swOCuu56P6fPOQtecFegAYYWAqgZIEu ApYyaKNSQcU0ajtIeztJ6xqRsh3gPkKhyBDXG5tsvQnKec4UsAwv56F34zJM bT2IxuFpTPxsG3rOX4vC4CLJiMXsKSN+i3GVtko7jaycxkvWZPk74RwoSstq SIl2zfQHI5VoXmTrx5iOtpvjyshY8yYJihjAbrJRsrirWYMdaVxCZ173Ms9Z EjAeSPvgyjioNikmkgb5AFvbT4e2e91nXbQFwJbK9vsVrOmDCcsglC3QA3Av cXARSJ1FpLYx824AE0TEHeAuUKofvRHF33nuRlttQHcX0nZFiqE9B97pXR6q e49g4qdbYM45E12ry0k4LE6Zoi3k77DHwlXgFFxKA2SkYLLdUROerEo5sQzl eoslwITUoVHatSaxh9MHIcMFV7H1qqSDjqSiMwBuddg4S6dw3GMwCB7IKHFG A6BrMeDlgMo4UJ8Rh832kfUWxectrT3XAjgC4Eh9ZPeDMKafQWUAZwC82ILP I/JXEaktzLydiE5aKE2d6mCtj+wmU68pZu454/ChjWxoma00HLWPWUpiXIBd eRo9Z5ZRWj0A2wgxde82TG7ZA9NoCgHFpMebTG9aeR3WZB629WEMEEUJQSb5 XKY0B2zSjjNx07qWjuUp26u9lCcFc1pjxkpJuY6W+jJKqJiucFI75yumZyr5 W7KJ8IQdJ6Ew5EugnqWgYj/geyBf++Tp/u/NEhPMl8+wuaUrDoP5frb2BxyF P+dmI+Sw2cvWXAjgHGb2Ohq3TQ7f8i3f6+3LcxQus1FztQqC/nD8cDcA31Zq sPUmKPBBSgBnlHOstEbP2mWA1qjsHMX0vdthGyF6zl4Dr5AXe9ZzlQJJVEol /RJIcRKidT27MrRHZIokk9dj8nhWEzvSOif9QFKOr1DGEo3M1JYuTmzgWJGn kQ1SGnEfBafHZdlvSWcwCNqNhfFSsyK2bQFQrH2nx4BGtGj1W1/o4Z9vmJW3 ECwpM4CZcGLsHhuFoQI/Ccw+PP9cUmoMrq9FB7h7PvN3XbqrZ9A2aitto7Ay mpnMgygkoolo/15CFDEzw0xWoUt5p1mMY3WRNQ4QWqPnzGXQ+RymH96HmQd2 IqrU0XveOgS9Pc7WZRcPTcrPFYOUdpW6BJAWABpOQ2TZzBuzA6tSmWVfpd1p SDmQsZgolh0IkwqJ1AZmUm3ZOk4dPpuaGe7w2AZWAkorZkWbzeuyFK02MWXj wl0AaSiV6+49R2kA8xJu/L4l3Dw8+qC19gyydoli9qG9VTZsjio/sE9Y4G75 y+uKKpc/N6rW1kB7i0l7PkAVADtJe7t1d+/YzA1fOIejkEEa5vAU7KJuKK0d aA07+qJQGYkIpWWLofM5TN63A7U9I4iqdfRdsBGFgcWAjp0rKdmKPW4BYtJu KY7f8izghQLX6+BmE5TLg/J5cdxUxplL7WsYAbXKkH2Yjo7/zpZhE83rSnWk T69SaTwXypUlJXRKlZCGkigC0kY87u8CYFA0hYVlUIPFg7Y+sntGWX/AMoM8 308Zd08g4N71yueRLuY93du1KZqaebIu2S4QMYFnCPgZaW+LLhQrpjIdBj2L edfbn+trYwmKwI0Q0dgk/HzgMk1khP1lQWQcMJRCYVEP9JPPxpHNWxEensDh 2+5B30Vno7RyEPDS+C10ppkHuYJKluLHuEmH075WogiM6MgRmIlxhwat4JWX Q/f1Sz1bHCZTqQdGkoY2nPYlUxkvjV34LO3B0BZPSIIMEus1ovFZzAatUnOA /JaohQO1zoBYIO55HuuFZf4rW+/N22ZjKVtLyu3vNkpK8xMKuHe8aEhxZFay MU+31foqMAwIh0F0P4Cfr/nNP6ke9aHIGBibcGjDg5PQfV1Aj4YiI0ATEDMl jeGCUh5LLjkbE/fvQn3/IRz50WZE561H9/rV0PmcgNJhkiV+y1IUxsSiGeNq WwJHDYSjo7DTk5msmkK0fx9UoQgKgrRwkjNxWbKpJo4N3JYoBGUa6FFbq9NM nzIid26F1N5uy7ARuwhJkiaG16px43N52ir/2DCY3HxbzkbhJYrQBWay4P1k ov358hlPHODePnSZ5mrjEpP3LwNRD1ueAeFuAPec+8FPjc8Zx52oTHOOmIzk 90Mg3D+OIJ+DVQpkLEAuO8baOltWu2Xa830sOm8tprqLmHloN6bueRjhZBW9 m9Yh6OlKa9BYpYWMkgJ2HRstQBqm0UQ4sh92ZsaxupQSLe+0oJ2cgF4y4Mrg W2K/3NqNJsmypbxdjsNlSrWnupJgbxrG4zQC0RYqAynAatczV6d8iTRtnIJc 53I1v6s0r406fsf3ejiKLmRqrLVsFTGPKvDdhdVnVZ8wUYVbNp1P0Uz9WSrn XUqEAMxjIHybiHZf8Kl/nzcuSFqFkF4DiBzXwEzMIDo0Bb/cLzHPuDRHHDUY uUOA0ho9Zy6HXypgYvPDqO3ch2hyGr0XnIVieUmijuLtnYhbkw62XkNz3z7Y atWV0iglpB6VEHpsZQZ60aKjQJlUWyT9wVRiw7JQL51il++nTOOR2Gywadw5 3RSFUs5DvKsPeTKRbBpliM0FnfkbDPJ0FRqzAvfQ/35Vkx9ssGFzkwL3Wdfg abtS6q7i+vOnnlgJCLYXcZMutYhyxDwBa79JRHsu+Y/vHnPJMX1do/rIhE28 64jBHCHcNwZVykP36gSsTrM4jetuvnFaUGkUBxfBu/xJGN/8MMIjUzh822aE 561H95krHbdXmoiwZUdUIYat1dDYsxdcr2dirKKNlYDRWlfNa0wCPBaqolva M8mNtgyaOy4u1HTZvcQkQIZUzi29+49uGKk0iL2M2REbHpyGzrImSRhNHL73 wURh7PviPyjy/EAFuaUcRReBaEDmzIxi3AOih7ufdPlJL/k5ocAdPnNjF4f2 AlguANrA8j0M7HnK8B0LspOoUpuC5SqMKba0V66FaO4YQbB+JXR3UZwXkwEs UuaxmAFBdwGLLz4bkw/vQW33CCbufgDhVBW9Z62B310UXDGYCaYyjXDvPtha VSqD40SAaOM4ARD3YoiipFVTmiLmNns21pay1EtLUbKZqg1QUrnAnNbJtdQx cFsimAiSz209JGMmIILQHS0oFxze8Kf/YHZ/6oMead3PJhokpddzFC2XfOA4 gD0A7ut/+gsmTpUo1InVuIZ7mE0vrCIwmhzZQ0+/e/OCjXuaqVkGdhBjietF ALDnNv2wk1U0tx9AsHY5dHdJbpLcPM7cPEq3dPLyAfrOWYOgtwuT9+9A5aHt CCen0XvOWhTKSwBiRGMTiA4cADcbzg6OTYOEtG7FPnbFmSzZtaTal9itDnEo DUga1aUZCE4IO6wy5TxCoYwrLDiJCLTt5scZaJKX2LwsHc2zh1A8gyOANU+b ah07Pvae820YrlTAEhD1WgqhgEMgPMxEexpTM2OrXvvrpxRX94QClw1HZGHY 9ZLNwdCiR3YCZgAPwfClSHxsm9h4dmIGzW37E/DGFbGsKWmRy4pb9iRTWqFr 1VJ43UVM/HwrmiNjODI1g9KG1SiUcrCHD8vSLyaBirNaUspOSl6XaIcx7hED VykJswmIFSXhsKOcNQGw40BQ6nMlnF+VDAOhrchSCA+kc+67rDOLkkN00sAM 1kaIqlWEU9Nh9cDoJjZRFwiaQREYuwG6j5U+gCiqD77iLaccpfHEa1zGEWbe SeABZtLQ6sKb1569B0Q7rtz2wLFnNBNg7T2OdB0bacq11xQNbMen0XxoN4K1 K6D6ul2TEKSUAdKZ1rmWJdevke/rweJLzsXkfdtR33sQ48N3odKVQ/eKRfAK OZehk33QXBIh5g64PgxxNIAj2Vw6abEYmwQqWfIpm2WLaZCU6ZZDShJznKmf UxmHk9JO57GpwORqy5SW3mgaMBGsNa59aqOOaHoG0cw0bK3mtHdopqNqbYKN GQeww4IeVkqNn3HN756SYD1pwH3W/q3R95etu5UtdRPzuYBdykq9jBTfdvP6 s++/cuuD0/N93uYDpnrzTmoaZw9qm4Z5JIwFTbDTNTTu3wlvxQD0kj5nOgSU tP+MebbQygFJAyALbS26l/SARw+hVm+iPlWDma6juGoRCv1daYdyss4WTXqP 2dSMEIJO0kshBmQmRew0asbGNZlSdZJMWmJFxHTJjA17VK2RVPAqH6bRhKnX YWo12FoFplqFqVRgmw0Qu4mqcwWofA4Atk/v3Ptl02ju3vjuD51WRZMnpQXT 95et6wFwKRRdTory0NQkrQ5Aq/tJ0z3PfOC+OQG8+wUXroGxPwZhAFq5BsaZ Dt0JoUU7WqIq5qC6S9CLeqB6SlCFAijnWjOBXeWrrTZgp2Zgq1Vwo+k27as2 MbN/EmG1AeVr5Ad60LW8HzoXuMWBFjYAACAASURBVEgFpWwtQuqs6cUDCDZu yPR3oJYGzNmWpMjasi2vZ96LqZMJ+SYO+QE2jGCqNZhKFabWAIcM2wydgxiG ieZXngevuwdeVze8gtSoKQrZmo/lNz3393AayknrHfb9Zes0QMtBeCYpWgOP fNKKyVMNeGoHaXU/ebSbfN0gX0Xkeeby4dt599UXLoYxnwXzCxzVT2VayTuw ZvdNgFauylUKB0kraYCXlrFztl2SjhvguQbJ0yNTaIxX3X4RpQA9Zw4g6CpA aS39aSk5DykFPbAUwYb1rYBUWQBniDbZluM0W6k8JfYxRxGiag1RtYpopoJo esZ1kYwpFX4Oygsc1VFp6FIXgr5+B9hiwX2XS9O6lcHYKRs235rf9OyvdID7 aEG8Yv0qUnQ+NK0irfrJUyV4isjXNeWrA+TrfeTrEQq8qXxem77m9LXUDN/l Uv8OmKwFQPHeCEQOpKJ9Y1AmGlll3lMZjSjAJa0S6mF1oobqwWmYegTyFEor +lEc6IHO+SkoBZB66VLkNm5odb5UpkGJoqTJM0tTvJSfa2EjA9towDQaMLWG 06bVKrjZTDQ3KQXyPei8W/J1Vw+83n54XT3wu7rhlbqgfD9pPcpxv2B2HGTX TMTuCyvTl5cuuHpPB7iPNc57xsZuaCqTokHy1HJ4qky+WqwCrSnQlgK/pgJv qqjt2XkTvlUp5EiRUGMpaTCXhJPYiK8Ta2OVaGPKAjUBcgbEif1KIAWEDYPq oRnUj1QArRD0FVEq9yHfV0z6OTAAtXgJ/HVrXWdEk5LWbRRJO/1I3pPWn6GB DSPYZhMcNh1BPjMRSBFUEEB3d8Pr6oIuFaG7itCFAnQuD10swF+0FCqXd90k kwaASJoAMrfv0G4BE30rWPf0F+M0lVOKjzu0e8s0gOmb1529FZbzsJyD5SJH djmDliuOBi3z4kbOa2hShxRhpdIeyHcNL5QfPzTI90Gedg9p0USedtmpRLPS 0VNYgArpnRtHHXylUFgH1KbrmNz8AJpHKogqDVSKubRNLgOq+zD03jHJvkma ldM0MmSXSHdeSlYAUgoUBPAX9cLr6YLuKsHv6oJXKkDl8/I7PChPqhxiTV7s AgW5tEslZ6riJWyX7V/ivo/YRvgiTmM5JSsgrtz2IAOoyWPiBxddcICY7wYz gaGbTP19pjlAxv4ye55m4wG+LLWc8lFVzJpSGgh8IPBBfgDlyw45nvTLFQ2X dHSMCxez8VN57i8l5JcuwfjmB1DfvR/N8UrGPiZopUHVmpgqGqw1yNdQMglU PgddLMArFqCLBac5i3nnNOVybS2ksi2lkFybc7oAeD5UroCE6xXveJlllVG6 fatLO1uwwQFrzXc6wD3O8oyfbs5uEGYAjO55yaWf5cPVl4LRFwOPfQ34ngOp 74F9B1Yb+KDAAwUBOPBhfR8UOACTp8WRa3XYjuqpgLR5niagf8MqTHOI6t5R mHrkqt89heKKJShu2gAVBK4tlO9DBb5bCYKg1d4las2mxRuryH4kJCQZNrFp Y1OWmKegC6WY/wG0tFHN0BaTymVytq17+4sqCKY7wD0Zxvmqvlt4qnYP18Nn xuVg1Ixca/lGmEQZWMjcnN2hUWvA11JsmLFvdVqU2AoupFqZKFl2CznAW9mP 6lgFjYkabNOgcWQahcggN9CVmANJijjuRB6H0qAc9VGlapLjY1m1lANxhpRD WkEVSm67AGtTk4dtS+untFNPTNIgEHicib9hGrXTupW+Pl0v/EN3bjfvuGDN jD1SfSURWnrcU0t3xex+uEiNUes2HoGxbiMS49rNI4qAMBInKkpTuFLpy9ak LfEBaE3Ideeh8x6iaghTa6IxOY2w3oDfU3ImQmLfZri0nCmOjCmU8ZoS794e X2uyH7B7UeWL0F09LaZAAk7O7AecCarFf7O1/83G/Gth3TNrHeCeJHn7isFd 0Ux4lTnSWJX2MUhvcKJogKSbdwKGJGXMKcvMWnBoYBoGptqEqYsGR6YSlzOf SzrDEPy8j6A37wiESiGcmELtwBgoF0DnA+d8MbcCMbPrTgIym6F5Z/cEjr8r l4fX15+QZ+bKrbc4nXG9mbVTUa3x4fyZV9yB01y803rWDXTVTGQ+HI03nhzt reeooKALChQoaF+BAg0VKChfupbDAFaWabaJA2aMgY0sTCOCqUWw9QgxQZs0 Qffk4C8qwe/JZ4g2Cqw4Q75R8JRCz7I+2CVLUBufRmP0CCZ+ch9qK5aia80K FJb0O7ILK+ETuMoJZDgJ2XKflO/gbCFVKMLr6XPfHfdjiHuXcXsTXm7Rxszg +sTUgfv++pPTNwLBc4Hm6XzvT/uNibe87PKBaNvYv/C+6kuTpVM8fPIJ5JEL l+WU2w9BkhEMcrFUw8nOOGzRatNm9tBVnkawrAtBXzHT+Ty2mymJCZPvIzhn A6irhOrBI5h+eA9sowlVLKCwfAA968+AVypKdYRqidei5bVMJk0pqHwe3pIB UC7naJIUGwFtfX+pNfOWtEY1trnzhps/t+dX37+bBnr/F8AdVx3abk9bpXW6 A/djD+2t/s75a+pcbV6Fui0l4GW4ComIXQ6/bmBqBqZqYGoRTCWCrRlw0+0p xnHD5vYVl1MurK00oUsBlG6rxM1uJmIMqKcHXm83gp4u5JcuggkNzEwVzcMT qI2MAbLZCGXolmCb9iKLTZt4c5QggL94idulJ7aTk7BfVg1lgy+ZPdgIgDGf ffBPPvYJnmluBGEdgJHrq+NjHeCeRHn3bz9vW2PHofU83rgw6cGZ2RAa3L64 tFYSUNZxi6P1LQ2eKXHa2Vj4pVwG3PHewKlzRYEP1dvlSDe+j+LSRdClAjgy CCdnUN93EM3pGSjPh8r5LusnoE3sYDm3yufhDQxA5fMttiu1zJg0htvSjze2 +a3dwlH0tt0f++oWNCIPwBkAzrym1L/7+ur41Ol4zwmPE3n4FU87I9py6Aa7 p7qplSKY+aUxOVujdfsnTUmrT7e5dDYEhpYlmHyNwooeeKWglTij0nAZFYsI LjgHqpDLxIYVTDNC/fAEZrbvQzRThcoFyJWXoLR6OfJL+jMpZve/7umGv3QA FOTld7SxxmKnsn0Xobjw0iF3mg1fx6H5bG71M6KbBtaWALwcwFkAtgH4j6sO bZ/sAPdk2rtXX/qc6KGxb/CRZgnZJnLZkFGchdJJ+vMo8EK4Dy3HxzFUBfiL Cigs6ZIYcab+LGObBudthF68SEg86W5AIIIJI8zsOYjKrv1gY6ByAfLlJeje sBp+VxHwPHh9vfCXLgX5Hlo2giDV+nd7x5tMlx0iGLb286bZvDa/5llJwuGm gbWLAPwqgH4AwwBuvurQ9tMqrqsfT8C97qK1+8HW2Knm0xGxbp2eWV5C2y46 oKT0uyX+Ge+G094aiQFd8DO75WTf42QjaW9xb2a5To9TWiG/qAe5gX5YY2Gq dTTHxlHbdxBMQLBsKfIryiBf4WhDti3cNVcozPVZ2myb0bX5Nc8ayR5xfXW8 dk2p/wiAcwGsArD7+ur4eAe4J0k+ev/u6LqL1z1oTbQaU81zwS196Y/aLK/1 ZWpxspKAvXQXz8b02TB0zoP2VGrnirOWJD9qDVBvN1QuSE8qAI7juDoXoDDQ B18akphGA83KNMJaDdZa6MCHzgetAVmeJU47K355Dxvz9tzqoZ/O9vY1pf4p AAUAawEMXFPqf+D66vhpo3UfV6ZCYu++9LLV4cNjX7L7ak+N98BLQlvZJTW2 eQkZjkImjKTJTW2NdGMRiYL5fXnk+gqOxK4yfcJUthqiD/65awHPS7ZsJZWp cohplL4Pb3ARjCJMPrQDtV17HaGnvw/FNavQs2Et/O5uHL0vG6V2b8tmajTO lt8WVutfL539gjlDXjcNrC0DeDWAATEXvtsB7skG7yuv2Bj+fOTf7Wj93KxS TR2uzHNFGcpfZlhiuzUGL6UtRVWgUBjscjRDIbS3OmsK5GvotavgLR9ICeoZ GiM8Dd3bhdwZg1DFHECupq16cByTP38IzUOHwcZCFQvo2rgePRvWwSvmQdpD a1tzuVb39xQYf2Ii+4n82uccM8lw08Da5wO4AsAEgM9ddWj7wY6pcBLlnetX HuFA/QhhdBnXTRktMfl5NtDLOnNx909u3x2SwJahfZWYC9QWz4VUHXC1Dirm HTNMlnnSCrqrAH/5YgTLF4kD5sJqpBSCniK6Vq+Av6gfzAwzNY3qjl2o7NoD YwzI86DjDQkJ2VDcNJj/xkT8kfy65y4oM3ZNqb8GYBOAbgAz15T6d11fHe8A 92TJR7bsxR+/4YrR5tjM3WDzZK5Gy1oC8nR0PDcFL9DCfYj9nbb9OthaeHk/ w1nIOGixNCOgUgOKeahCDrqvBL/ch2BpP3RXrpX3kLGFSRGC3m4Uly9FbnAA qlBAc+wwarv2oLp3P5pTFfn+HKTb4gyAP42a9iOF9c9fcDr3mlL/DIDzAPTJ VN12fXW82QHuSZS/veUBvPuFF+83im9GM7qYq9EKJC0PqSVJQUeBN8OyijNo 3KZ1DaA95TJpQGtbUM7MkjACGjUEq5YgWD0IHVdN2CzZBhnyDSeZOVIEv6uI wuASlM5cBVXIIzx0BI3Rg6jvO4DKnv2I6o2KtfjjmYMTn7rjkl+qf+4RjNH1 1XFcU+o/B8ASAD6AB6+vjp/yXF3CE0S2XX3JoBmb+ajZPfNS27D5JGLQFv6C JCCo3ZlL+hu4piIuSUHw8hqF/rw4ZM7WJU+KMD0FlfNAOSH55H34mzYgWLcK qpRPS3B0WiKUlOTEpUUtSQkNgBDVm5jeuReVnXvRGB07MLNz7Lbp23Y9wJVw Oxib4Xp9VUCoXXVwOx/DxtUA3iphMQbw6asObd/eAe4pJHtfdXlfuG/qOnOg cq0day6xyoGXhRye7BopiYW4gXhL+liliQhogDyFfF8OftFH3OeBPAUEGsrP RBmIQNrtA6xXLIW/cTW88mKokpSOJ7vmqKQaI67MyBJ6EgArbcJ68zu7v3Hz p/b98TeZBoI1cBvsEYBJALsB7AVwEG4LqMmrDm1vtIG2COBiAFcByImp8Omr Dm3f0QHuKSb7fv25+fDBg8/kidp77c7KpWziPRkgtEJhESaZMAdQViTWQxxW EAWpCbrLR7Ck4BIGnk7Da0l1sTDHVCZ0FnjwBpdAryrDX1WG6iqkIE22hFIt FcdJtQbpcfaCD8HPfyq35oUHbiqv82F4EYAyXCp3A4CSTLWq2L9VABV5biSG uxjAoIAWcDvofOmqQ9vHOsA9FTXvm5+jzP6JMlea77K7Jt/Ik1E/DChJ+WbS xUnzOdVmF6us2aDgDxagu4LEXEhitNn4bty4JC4N0uSqkQs5eKtXwD9zOVRP t9sGy0tAmikvUg1o/x7ki+8C0W25DS9vSRjctHQtgeEDyANYDeAc+b+AlKWR vffx/bcC6Buh6KdXjW7jDnBPYal84To19oUfPdfunXwnjzeeyhNRLyxad30k auUraMwKXspp+INFqECnnIWYeKPRymeINXEyMTK1ZINL4K9eDjXQD10qgAp5 kO8beP6DCILPcan/44UNL1kwo+umgbU+gGUAlosp0ScaNo5mNwGMArjnqkPb 93YSEKeRHPi/r+xr3rXzRXam+Toeqz6PRxp+mmnLgFcBRzHPVFopoUoa/qI8 KNAtO0Qm5kJG06avq8z5UzYb5XPQ5QF4a1c9EKw740tU6vpa/uI33v+L+L03 DazNifZlEDWuOrjttCOUd4ArMva3b6bqj7cuhu892R6uvs3uPPICHqkFrj3M HODNpoYVQB5BFTX8/pyzd7OtneL2ULEJojMApqwNTAxPR7Sof6saGPgEafVt b9PZu3pfdF2zc5c6wJ1TRt/7RgoPVQLS+qxo3+E3m4dHrsZEY4Aj20PVyGtJ YChKCTnCayCPoHIKXl8OKqdaTQTp8sjZFLMmKZVX0+QHk7S49261fPCz3hkr v2PGJ2uLf+NvTOeudID7iOXI1/6yv/K9u59p9h6+gierm9A0a2HsGXy4UsRk oxW8RIBPIA8gX8HrDaAK4lwRUq2qFVDMMbTeC0/vpEJ+K/UWf6RXL7958Tv+ fktn1DvA/YXKwY++Y3Hjvp0reaK6DL5eg2a4kWcaa2CilVxtLEY+txTVRhGa FGmX+lWeangF7zAF3gQU7UHg7abA3wZjtqCQO6CXLdnvv/iZ+3oveUtHs3aA e/xl/N//Sjfu2RZEe8Z8rtV8O1HRKOQ1pisq0azWAgD7pcBQITDkqwg9pVAt H2gO/MEnw84odqQjHelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQj HelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQjHelIRzry2OW4FksO D5bVPN9hh0ZH+GScc3iwTMf47bzQaxseLB+PHsM82zXIdavHeu6h0RG7wN8W f58H1xyvC67P2BSIDsqGwo/qPj5W8Y4jaPMAPgy3l1a7GACfA3DDIzpneVkJ zB+D60Q4283+RwA3L+BUlwG4fB7w7gLwtQX8xhyATx+HcawA+CiAn7W9fg2A 5+GxNeSeGh4sv3dodGTXMe7dagBXA3gJgIvgGuel21YyjwO4C8B/DQ+WbwRw YGh0pHnaA1ekBLery2ySf6TABfOzAfwKXOfsdpkG8EcL1Nh/LgCYS3YND5Zv Gxod2X+M02n5fb/ocZyUidMO3Ivl+x4LcMcA/INMztnGZy3c5n1vgWuWN5cU 4BrpvQTAdgCfGB4sf2ZodOTQiQCuOo7nbgL4+jzvnz88WF7/CM/5ynlu2o1w /V2PJRfB7XkwnywG8MIFXtPxaBiX3U16Ia//Is6N4cHyebJqvfsYoG2XtQDe B+CTw4Pllac1cMWOuh/AfXMcshTA0x+B6bEcwCXzXPNXZbIcS64WYB5rpXjO 8GC58ERxdoYHy4MA/hLAcx6l7+MDeCmAjw4PlntOZ40LAPsA/HCO93oAXC52 4kLkcnEQZpOHAfzsWE6H3JxnIO3APZ/TejFcY+STMYbH02k+yjEV8+n5AP7P PL/HOWXO/p7PdHougF+Rc56eNu7Q6EhleLD8QwCvFaC2y5MBrITbxXs+wHkA njaHowcAt8kkOZZslO9ciKwDcMnwYHnz0OjIXH29DID/Fm3DswBkBYAL5/js NgAPzOOcPdKN8u6Ea9B8LNBOiA3dri3fNs/nDosTeq9M+mcCeAWA4izHdsHt zv4fCzTdTknnDKJx980B3PMBrB8eLG8/Rkhl2TxmwgyAW4dGR6aPAf4AwBDc tkgLXY1eCuArcrPnsuPfNs/nXwng7+ewM28A8Bdz/CaeBVzHko8B+J8F2uQT s9j0F88zOT8K4P1DoyOhjOXXANQAvHkOn+MyUUinL3CHRke2DQ+Wfwa3qUb7 TQoAPBtu6/nGPKc5U5yqucyR2xZwKT0CpNmkMYf58Gy5ARNz/DaeSzPKUjk1 j4NUHRod+UVuEjI5NDryaLczXTZHpCYG+v/EoJXfPT48WP4C3G49g3Pgas3w YPmuhcaMT0WNGztOL5cQWLu8BMD75wLu8GDZFyeue45BvW9odGQhLeYvBHDB HO99GsCvzXLz8gBeI0vk41n0McyLFbO8fheA/zfHSqrEKT9uiYkTBdzvybJx 5izvnSWAGp7js3kAL5tnqf76Aq/hrXO8flCW8wvFAWyX1w0Plj94LFPkNJfR Y4D6ncOD5fuHRkcezGjdaTGjToqcKOBOi7H+zjlm9GvmAe66eeyvIwC+tYBQ z5kAnjXH2/8DYD+Ab8wB3BUSQvvqaRDSOmY0Yg5f4hBcEmHDHPfnMgBfGx4s fxzAF+V+mpOR6j1R4bDsYH0ZQDTHIVcPD5a753jvl+aZYN+Yx47MyivnWNIs gG/LOX4AYLZtwwPMnf07leQ88fbne1wyR2y6KYCcT+tuEgfwHgDvhQtlLjtO XI1TA7giWwH8eI73Fosj1K5BcuLZz+U0fOlYs354sNwF4AUCwHZ5CMDPxYHY KSGl2cboQskqncryPlm15nt8Hi5N265YIgD/BuDuBeBlJYD/C+C7cr53DQ+W L5WQ5eMSuDNwMc/ZpCjgapfL4TZHnk3uxtxx0KxcKnb0bMvoT2WJBIARmViz xWxXArjycWDLRvO8t0MAudANqAtifr0PwJfg0r1nPe6AK8yh2+cIH2kAF8yS 534hZg9yQ2zbY8VuPYlILJ9jIt0yNDpSzZgzt4i9N5uD+MzhwfKix6t3JqvO TeJv3A639y8vEENr4ZhrNw4Pll9+IswHdYLH54F5QkvrsuEqAcllmD2+OA6X dGgc4/uWwsUaZ9O2YwC+3/ba7QD2zHGuZ8BR/U5noWOBd2h05CdwfIXflWjQ yALPrWV1/EcALzne4FUneFaPALgDwGw7ziwR5yG2RS+QmTyb3ANH4DmWh71e wN8uDMdt2NJ2fdNys2ZbUpcBuPJE23KPUCn88BiPuwDUF3CfKkOjI/8kjvE1 4ozdfgxTI5ZBONromsdDOCwr/wsX7B+Y5b0r4XidYxICm22JDwH8eAFcWQ9z Jz2MRDlmky8DuG6OsXk9gH9e4A080fJBGdtj2biHH4GimQDwv8OD5WHRpBsB /LIAumceDX6BaN2/F8fvcQHcH8pyPBtwLxOwRrI0zzYwk1hYTr57njDWYQDf meO9ewFsnkNTPxku9XzrKQjcIwuYzI/FP9k/PFg+IPfvQ3DZzhdi7lTxCwF8 8nhN8hMO3KHRkVBIGhfOYqoU4IL9/425ubq7sTBuwksAlOd47z/FOcMc2vgL cwBXwVUGnIrAfdQyXF7mg7k8h6JgAKNDoyNNcWBDAA8MD5bfKtGEZ83xuXPx 2Co1TinnLJavzGNrvVpMhtnI3hbAfw2NjtTmvRFnrCYAb5xnKfvqHGGvOLrw XczNCLvqRLH8T6B0i4n01VkeX5ptEkuJzn/Po1GXHE98nSzg7p3Fo4/lfMye GgZchucLxzx7o3GpzPjZgLsZwEPHSFyMYO4U9GIAL35cwZa5LhGTp8zyuAyO Tz3Xij2XcpjE44BkM5uD9RUAL5ojrHLmXMpUTIVjyQsxN+n8pgU4KFMSXXjZ LDemCOD5w4Pl64+l+U+wLJLypmOJBXA4S1MUrTkszudsyu2Vw4Pl7wO4YWh0 pCJRmzXi/M5lDjw416p22gJ3aHTEDg+W7xAQnvEIPvplzB5Ky4bB5ivPmQJw W5x0mOf6zPBg+W65vvbYLcmqcB5mTxGfLLlOPP5jyQSAP0Rr1UkIx1V4FWZP jS+FY9B9e3iwvANpFcSl82jcb2FhNYCnlcaNl+ObAbxhgcfvAXDHAojJ52Fu 3u02uDTvQuRe0RqzJR3WAnjq8GD57nnKek60XLjA48bQxm0eGh3h4cHybXCk pbkiMUvhYrp2ASbmVgDfPl6hsJNp42JodGQSjpFVX+BHbsYxSkGElPPMORw7 A2Dz0OjItgVe39Q810dijvSdjhbtbLbn0OjIEQAfAPCTY9imx8LMtGjn+4/n j1AneRDvWKDNWodL8U4c47heuErV2aSGBXB32+QGzB02u/IRmjmnvAyNjvwU wNvh4uThozjFGFyM95+O90p0soF7HxbG8NorID+WXArgSfMM6o2P8Po2z6M5 igB+6VGWYc/X/2w+ITz20vV5zzE0OnIXXCebd8CliBcSGYgE7G8B8Fcnwmn1 TvIMN8OD5X+CY4z58xz6EIjuPYaZQBJJuH6Owb5DzJNH6kR+SGxjmsP8mG9J 3gbHc7WzvPeTR7lCFfHYAvvTcJUj8/3uEbkvXxVF8Hy4FPxaAIuQlrnvgOMw fBuOPzJxoqoiCCdZFtA5EVhg98RjnIsfZXfIR33OX/T1LHCs8IsYy3m+lzKT 71GPa0c60pGOdKQjHelIRzrSkY50pCMd6UhHOtKRjnTk8S3UGYKOPBaRquc+ KHV46MD+E5aI8DIXkIOr4rwIjrd6B4CDx5MsIe2RngzH2pqY57gyXIn0UwA8 9bHmwuW3FuF6ytpf0G/Jwe0dMX66ZJKGB8sb4Squ/+bR7JYjGbWXAfhtWPt2 OBroY72mM+B2T/rAfFtaeXJwNxy5+GVwvIECHBHkT4cHy9+V5xpaN2BML4Aw ZsJnvrBXNPjk0OgIDy9bTrC2AKI6mLsBqKHRkfamcmcA+ASAa4YHy3cB8KFU E9b2A2gMjY7MDJeXebJN1DMBvAdAODxYjs/bBaAuBZgFue4JSGv7odGRppBg egFEQ6Mj0zLYr5XBed7wYHmfHG/h0pjxcxvv2yU9ehWImkMjB1i0TC+AytDo SEx7fBVcO6JLhwfLR+AI2SZzjpyMTwNAfP25+Jjh8jIN5l4AtfaJKb8hB6Xq sLZXXp4UHm3LuGcA1QsgglIVWFuQ87K81wdH8u6D69n2D5nP9QAJ7XQ2YHUL biaFyxEXru6T/dFivm6XTGIjr3fL39FweRmBuQDH+ssDyEHriaH9+1i+/2oA H2/DFgBMxb+R5I3Xy418J4i+LwP4DqQbtJ0LR7LwATwVjqjxKTi+agGOef9s Od+tAK4HUQjm98NtLHIFHGv+63CN6iL53nPh9vN6k1zYs+U7LhEAfgRuP4TP wxGZbwXw+wB+A66n68UA/lpu0lvlmB/IwO6EK+a7RlYRgiNKPwxHvXsaXB+C 98BVqhblRj4omvPw0OjIl6Ujy9Uyyf4VrlvLtXCdd8bk2rbJOZ8j3/ERuLKk zUOjI/8hv/UaOJ7w9aIk7pLf+8+iLH4HjsQyKWP07cyNWya/eULGEnDNqON9 5DwAnwXwXzLOvwxHjKnLeGwA8Fcyad4k3zsNx3x7hUy6MRmrIRmrHwC4Pgvg 4cHyi+V4wJFqPgXXTuD1cO32r5HvXwbXjOVOGY83y98/gev4GME1DblLvq8f wI/gejecAeCbcM0Ot8Ix1a6S7/whgE8OjY5UlcyyV8P1Zht5LAAABqlJREFU 0bpxaORANDQ6clgGOA9XLLcObu+rQG7QDBxZuCxf8DoZyE+K1n4NmEtwNLcN cDtM3i6TYy7a4SoAvwdHFv9rGYA/guPR/hBuQ7mvyOu/Jtf8kMzkv8pcWwjg twSsa+B6YX1NburvC8h/CNfG6Xq4yoohAU6fAP4ypK37SSbuFQKUj8P1zP0b uL6674fr3nKbgOEzMjmubvutl8r3lOA4w++S756Qm9kHtyfEjwH89fBgOdsT uEdAcbaM5VbRklfLZx+AI4EPyHe8C65m7tNwZf7Xyji9EK7E5wa4nT0vFpBp uPqxV8tnPgHXmvV1cSul4cHyYri2TLfJuL1IxqQsz7sEYL8s3/0ZuU8fkM98 Uu7F6wRXr5fnXxWF9lbBS0LegavUfp0A+pMyad40PFimmEvah6PLsadkxg7I zbsHjiB8C4C/E4A8Ha7i9Udw3NotctFPF018BK6c/HY4el8Vs7dljwFyH4Bv Do2O/FDAtlau4QHRSrfAUQlnBKx/I8vSMnl+swx8XJ7TkKXrQgHJtXC7NW6T a7ldNIoF8CMQXSugtjiaGhmfZwOADw6Njtws2vpv4cqQtsu1/ihjr7efI/7b yCT7SwHl+QKGg0ib+V02y/34N1l1viTn+qRcx+dl6V8Pt13TdwF8BkTfk1Vi XFayF8n5PyOrzafkmj1RQHfClSxtg+MuXyaAhBx3CK6DpoLr7HgnWisqrIzp fwoYbxXz4IsyWW6QyReIQvq3odGRG+Dq3T4DVysYV5X0yiT8X7me+2VSPx9I ieQPAtjQtufYWjlJvMFeDek+DVUBblE04JNktr5G1H7cZypE2lExks/PF8mY RFpg15zlhnPmuCPiOMa/oS72Tw1puc0eAH8mN+YPAfwBWjfbsJn/DwyNHDDy nNBaNBjvHRzvZ+uKLbVuCmCnM9eXPWeWY5xv+z3xTkOBPK6W8XuVKIltbZO6 nvmNkTwqmbEyojkDub7m0MgBztwryL2qZZp7VDP3tARXr/dquBZL8X0MM8B9 L1x711+RlWbTLBNzKvP7K3I/4r9n5BqVHFsRezqSz/lIucZK/r5Iruc18trt EIeJZeadB+DPhwfLTx0eLL9ILvLHSLsrXgLg9cOD5U1idyyVyMOtcsJvy2NV 22Adr5BbfN4xGZy3SPPl18qyDLG/3gjXxv/34DbcO0eAVoIreJytQ/ceAE8b HizHG55cLQP9M1mZfn14sHw2jHmr2LPL5abk4NqRFgV4Vw4Pls8ZHiw/DbN3 xoGM734B0OfEJDobR3dJXMg4hnLPXgjXu+si+f0DAvRb5fUXDw+Wnyz3sU9A f5N8xw2Z+9jMALsgy/k4gN8W5XEFHhmpPfsbCgDeMDxYfsrwYPnZYgrdn1n5 p2QCB2Lz3ij271hW4/5UbJ+nidr+sCz7fyQgJFkWLhFj+w2yzG2VZWqLLA1f kxt4Y0bbRpnZWEFr55N42TdyfCWjVUN5j2UAq5llaSZznu1iR70IwL/LcnOP DPiorCZfkCXyftEYPxAQflhmdDXW0hIe+7RMhv+QSMEd8v6E2M9PlvNdB+Bf BHxxR8S/kwjI+5FutP0O+b5qRvMY+b4pAL8JV8N2qzgtX0brVrLZcUL7OTLv N+Umf09Mp8/IdT8k4/lV0VgfFafwiEywUCbNw/Kbvy7A+Z84HDo0OjIjy/Z1 goUV8tsa8t2xhs0Wl9ba/q7LayzPd8q1/Ivcxw9ncBOKP7EbrmXW12X8/2to dIRbt8ZctlzB2mUApmVAIcb5r4nH/OsxqOSHZMMk/fIDk5DXcHmZD6IoDkwP l5d5AOzQyAELAMPLVxCs9UjriI0hENTQgQMu4rBsmQJDATAgIjCroZEDLpQC aBCZbMB7uLwsB+ZeaH0I1moALEt/HC8uktaHrnQhFyTnAQwICgzEx8tnAgCL oNRhABbMyJzPB9AHosmhkQPNzDXE57RDIwfscHlZAOZ+AEegFIMZ0NrAGA9K RRL+yQby+0E0PTRyoKWyWM7rAYiGRg64UCNz+reMI7SKhvbt45tXriIOw0UA 6iCqtnx2+QqCMYtBVBHQKQBmaORA/Lk+AdbkbPFoCU8uhivTaQyvWKlgjIJS BtZqEHjogIzTsuWejJvc0+VOOzuM3Sq4+qFo3/Gh0REeXrGSsuMjwYMuAB6U mojv+TGXHwHuW8Xof8sCKm070pFjYWqlOPS/OjQ68t3HlDmbR1iWLfP/x0DD k0lGwYgCX6AjJE8o7eAQU+oy0vJkklEwokpcRuiIwR9yp9wBBiwyY5u0u3MA AAAASUVORK5CYII= --_av-sQ_BtxO6VDP641vQIRyqBQ-- --_av-3KpOo7cLpH8IvQepXDgk5A-- From xen-devel-bounces@lists.xenproject.org Fri Feb 17 17:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 17:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497215.768124 (Exim 4.92) (envelope-from ) id 1pT4qf-0003Lz-0X; Fri, 17 Feb 2023 17:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497215.768124; Fri, 17 Feb 2023 17:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qe-0003Ls-Sc; Fri, 17 Feb 2023 17:48:40 +0000 Received: by outflank-mailman (input) for mailman id 497215; Fri, 17 Feb 2023 17:48:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qd-0002rh-0E for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 17:48:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e7c8e8c-aeeb-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 18:48:37 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e7c8e8c-aeeb-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676656117; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p5sxvZxuV8RUOamp6LgQhbUMlW7vsrfgFydE9dC8HYM=; b=btB9RcRxg60efDRlyKVErHhgzTCGlP5BFc44jbBG8mHrOjYVvvHdHR52 oiAnBt6QGpNd7FA3tD/2l0KL2K6DwfXmAa1QA/tthZUlQr6IzMWqNOYhK Q+GKCuOnpSATlsHRShyd1JWs4AyvJgIFRsO0O5J9MFIqfPqZTfD9Ha8rN I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96897981 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:yAfCsqKg0l3I1J+gFE+Rx5UlxSXFcZb7ZxGr2PjKsXjdYENS02FWn 2EeCmuDPq7bN2L9KYglbd+1phlS7cCAz9Q3HQJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c54Dl1q7 fBIdwsdcw6h2e2xg+ybWNFj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TbG5UEwRfI/ woq+Uz0P0snG/m61QbYyWLymPHMhirkAYkdQejQGvlC3wTImz175ActfUS/iem0jAi5Qd03A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52ml6IDZ/gKYDWgsVSNaZZots8peeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwAaIlMmfSNUEjAV/sfB/o40zUzvXO5sRfvdYsLOJRn8x DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zt64oEWqPcrWWU JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9aFoSLLkWN4umsWyKJV3iEsIGaBX aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YuKlLYpn02NRXLjwgBdXTAdollZ P+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtaTOzghQCxPrc+m39q o8PX/ZmPj0DCIUSlAGLq99MRb3LRFBnba3LRzt/LbLSfFM2QDt6VJc8A9oJIuRYokicrc+Ql lnVZ6OS4AGXaaHvQelSVk1eVQ== IronPort-HdrOrdr: A9a23:mm60zqFOjei4Jq6+pLqE18eALOsnbusQ8zAXPo5KOGVom62j5r iTdZEgvyMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U 4PSdkZNDQyNzRHZATBjTVQ3+xO/DBPys6Vuds= X-IronPort-AV: E=Sophos;i="5.97,306,1669093200"; d="scan'208";a="96897981" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/3] x86/kexec: Drop compatibility_mode_far Date: Fri, 17 Feb 2023 17:48:12 +0000 Message-ID: <20230217174814.1006961-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230217174814.1006961-1-andrew.cooper3@citrix.com> References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ljmp is (famously?) incompatible between Intel and AMD CPUs, and while we're using one of the compatible forms, we've got a good stack and lret is the far more common way of doing this. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/x86_64/kexec_reloc.S | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S index f4842025eb56..035164e96f38 100644 --- a/xen/arch/x86/x86_64/kexec_reloc.S +++ b/xen/arch/x86/x86_64/kexec_reloc.S @@ -86,12 +86,11 @@ ENTRY(kexec_reloc) movq %rax, (compat_mode_gdt_desc + 2)(%rip) lgdt compat_mode_gdt_desc(%rip) - /* Relocate compatibility mode entry point address. */ - leal compatibility_mode(%rip), %eax - movl %eax, compatibility_mode_far(%rip) - /* Enter compatibility mode. */ - ljmp *compatibility_mode_far(%rip) + lea compatibility_mode(%rip), %rax + push $0x10 + push %rax + lretq relocate_pages: /* %rdi - indirection page maddr */ @@ -171,13 +170,6 @@ compatibility_mode: ud2 .align 4 -compatibility_mode_far: - .long 0x00000000 /* set in call_32_bit above */ - .word 0x0010 - - .type compatibility_mode_far, @object - .size compatibility_mode_far, . - compatibility_mode_far - compat_mode_gdt_desc: .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 .quad 0x0000000000000000 /* set in call_32_bit above */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 17:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 17:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497213.768102 (Exim 4.92) (envelope-from ) id 1pT4qd-0002s6-E1; Fri, 17 Feb 2023 17:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497213.768102; Fri, 17 Feb 2023 17:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qd-0002rz-AR; Fri, 17 Feb 2023 17:48:39 +0000 Received: by outflank-mailman (input) for mailman id 497213; Fri, 17 Feb 2023 17:48:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qc-0002rh-E7 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 17:48:38 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c015a78-aeeb-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 18:48:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c015a78-aeeb-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676656115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pQkR+t2gNbGqRxj7fNmsb+K2rgz5dHlSLHWFbF6Ydbw=; b=B9EhBZtg13lP1HYjlI50/jpjSxhHBocxQpB5dq62keTMAI01I89nJ23y tPd6OHMGd5jx0+ZPOYT/fBQYKkS0XDOjcWvTWn1DUZCEfg/p4BQe6zDsb n2WBckDPE3PTBLyit56nYuQWKvJFDi+Tks7gS8CD9kvprcaNeFEeBM3ud 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96897979 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6pGO3a9+L3jit0PR2HqfDrUDln6TJUtcMsCJ2f8bNWPcYEJGY0x3n GsYXGuDMqmLNzfxct53b4u//E5U6JXUn941GgBs/yE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6kU5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklB+ sA8MDxdMSuTmvyUnr28CbdMlPwseZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0EwBbJ+ TOZrgwVBDkrLNbGwn2I4kj3l7H9pBPaZN4CGu2Bo6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0efBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0cNahMgVQdVvOLzvZ8R0B3IDYhDApa624id9S7L/ xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuFyJAzvNAhdRIdf8Otf2sQSzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF5yLJ9w4DNJWfh0B3iM4ldjBO Ra7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHYonwxPxLIjzu2wCDAdJ3T3 r/BLK6R4YsyU/w7nFJauc9DuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimN4gEAFe/iFyNq b53bpLaoyizpcWiOkE7B6ZPdwFVRZX6bLiqw/FqmhmreVY3RjhxU6WKntvMueVNxsxoqwsBx VnlMmcw9bY1rSevxdmiApy7VI7SYA== IronPort-HdrOrdr: A9a23:1N5Kzao2CEnA+oDbgt0Dg3oaV5oUeYIsimQD101hICG9vPbo7v xG/c5rrSMc7Qx6ZJhOo6HkBEDtewK/yXcx2/hzAV7AZmjbUQmTXeVfBOLZqlWKJ8S9zI5gPM xbAs9D4bPLfD5HZAXBjDVQ0exM/DBKys+VbC7loUtQcQ== X-IronPort-AV: E=Sophos;i="5.97,306,1669093200"; d="scan'208";a="96897979" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] x86/kexec: Annotate functions with ELF metadata Date: Fri, 17 Feb 2023 17:48:14 +0000 Message-ID: <20230217174814.1006961-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230217174814.1006961-1-andrew.cooper3@citrix.com> References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit All of kexec_reloc(), relocate_pages() and compatibility_mode() are function-like. Annotate them appropriately. Furthermore, move the data into a different cacheline from the code, so the relocation of compat_mode_gdt_desc doesn't trigger self-modifying safety logic in the pipeline. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/x86_64/kexec_reloc.S | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S index a81f64146190..c7fc11fa5868 100644 --- a/xen/arch/x86/x86_64/kexec_reloc.S +++ b/xen/arch/x86/x86_64/kexec_reloc.S @@ -13,6 +13,7 @@ .file __FILE__ +#include #include #include @@ -90,7 +91,10 @@ ENTRY(kexec_reloc) push %rax lretq -relocate_pages: + .type kexec_reloc, @function + .size kexec_reloc, . - kexec_reloc + +ENTRY(relocate_pages) /* %rdi - indirection page maddr */ pushq %rbx @@ -137,9 +141,12 @@ relocate_pages: popq %rbx ret + .type relocate_pages, @function + .size relocate_pages, . - relocate_pages + .code32 -compatibility_mode: +ENTRY(compatibility_mode) /* Setup some sane segments. */ movl $0x0008, %eax movl %eax, %ds @@ -167,7 +174,14 @@ compatibility_mode: call *%ebp ud2 - .align 4 + .type compatibility_mode, @function + .size compatibility_mode, . - compatibility_mode + + /* + * Ensure data is in a different cache line to code. + */ + .align SMP_CACHE_BYTES, 0 + compat_mode_gdt_desc: .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 .quad . - kexec_reloc /* Relocated before use */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 17:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 17:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497216.768135 (Exim 4.92) (envelope-from ) id 1pT4qh-0003cF-73; Fri, 17 Feb 2023 17:48:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497216.768135; Fri, 17 Feb 2023 17:48:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qh-0003c6-3Z; Fri, 17 Feb 2023 17:48:43 +0000 Received: by outflank-mailman (input) for mailman id 497216; Fri, 17 Feb 2023 17:48:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qf-0003GN-6L for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 17:48:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c263dcb-aeeb-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 18:48:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c263dcb-aeeb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676656116; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ti3YGuh5AB+DkoIjcnY6SodZUoUvn3qg2dzkSWt0iaU=; b=FVizbSmtPmHUn/RrywOSt0iHNUvIE6H5Xho4rvNw79p4tqr24AkAMuvQ XnBXukdiOjh0TGyQKsxxx3U7f4g773w3+O+2aawqt6AyAC1jhJPTGXq+j c7NqMZjBP+Uv0DO9snd0oP2ZRbYjRbWdJG1MKwH1wK/npCTatVAB/dY9C s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97511809 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:tUaVdqh8VgjMdx6kNb1JOkzLX161cRAKZh0ujC45NGQN5FlHY01je htvW2uFP/bZYmf9LYskaYS+800AvJODnIU1Ggc//ihhHngb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaBzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQlJw8EXB2Kgd6JnoicZvEwneo6Ac7CadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J+ T+fpjShU3n2MvS18ACr0Fyul9Xkw37GddINKpKV2P1T1Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Mcc39QWMwar8+BuCCy4PSTspQMMinN87Q3otz FDhoj/yLWUx6vvPEyvbr+rK62roYkD5MFPuewc5QjQM0dTqpr0M0CjoYs4/C4Cso9rcTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4um0WyKRBaJxsldrVj Kj74Fo52XOrFCH2BZKbmqroYyjQ8YDuFM7+StffZcdUb556eWevpX8xOxPPhTy1wBN3wcnT3 Kt3lu72UB4n5VlPlmLqF4/xL5d1rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRtcu5TPHu2 48HbaOikkwPONASlwGLqeb/23hWdylkbX03wuQLHtO+zv1OQz1wVaaBmel6JOSIXc19z4/1w 510YWcAoHKXuJENAVzaApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:tDamwa/G6BXc/XPLPXNuk+HRdr1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYW4qKQwdcdDpAtjkfZquz+8I3WBxB8bpYOCCggWVxe5ZnPLfKlHbak7DH6tmpN 1dmstFeZDN5DpB/L7HCWCDer5KqrjmzEnrv5ak854Ed3AyV0gK1XYcNu/vKDwReOAwP+tfKH Pz3LskmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzI39QWUijusybjiVzyVxA0XXT9jyaortT GtqX232oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuQFNzn2jQ6sRYJ5H5mPpio8ru2D4Esj1P PMvxAjFcJu7G65RBD4nTLdny3blBo+4X7rzlGVxVH5p9bieT48A81dwapEbxrw8SMbzZ9B+Z MO+1jcm4tcDBvGkii4zcPPTQtWmk29pmdnufIPjkZYTZAVZNZq3M0iFQJuYdc99RDBmcIa+d pVfYThDTFtABenhkXizypSKRqXLzMO91m9Mw4/U4euokdrdThCvjUlLYok7y89HdsGOuh5zv WBPaJymL5USMgKKap7GecaWMOyTnfAWBTWLQupUB3a/Yw8SgXwQqTMkcMIzfDvfIZNwIo5mZ zHXl8dvWkue1j2AcnL2JFQ6BjCTGi0QDyok6hlltNEk6y5QKCuPTyISVgoncflq/IDAtfDU/ L2PJ5NGffsIWbnBI4M1QzjXJtZL2UYTaQuy54GckPLptiOJpzht+TdfvqWLL3xESw8Ume6GX cHVCibHrQ10qlqYA6MvPH8YQKeRqWkx+MBLEHzxZlh9LQw X-IronPort-AV: E=Sophos;i="5.97,306,1669093200"; d="scan'208";a="97511809" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/3] x86/kexec: Simplify the relocation of compat_mode_gdt_desc Date: Fri, 17 Feb 2023 17:48:13 +0000 Message-ID: <20230217174814.1006961-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230217174814.1006961-1-andrew.cooper3@citrix.com> References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Assemble the GDT base relative to kexec_reloc, and simply add the identity map base address to relocate. Adjust a stale comment, and drop the unused matching label. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/x86_64/kexec_reloc.S | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/x86_64/kexec_reloc.S b/xen/arch/x86/x86_64/kexec_reloc.S index 035164e96f38..a81f64146190 100644 --- a/xen/arch/x86/x86_64/kexec_reloc.S +++ b/xen/arch/x86/x86_64/kexec_reloc.S @@ -72,7 +72,6 @@ ENTRY(kexec_reloc) testq $KEXEC_RELOC_FLAG_COMPAT, %r8 jnz .L_call_32_bit -.L_call_64_bit: /* Call the image entry point. This should never return. */ callq *%rbp ud2 @@ -81,9 +80,8 @@ ENTRY(kexec_reloc) /* Setup IDT. */ lidt compat_mode_idt(%rip) - /* Load compat GDT. */ - leaq compat_mode_gdt(%rip), %rax - movq %rax, (compat_mode_gdt_desc + 2)(%rip) + /* Relocate and load compat GDT. */ + add %rdi, 2 + compat_mode_gdt_desc(%rip) lgdt compat_mode_gdt_desc(%rip) /* Enter compatibility mode. */ @@ -172,7 +170,7 @@ compatibility_mode: .align 4 compat_mode_gdt_desc: .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 - .quad 0x0000000000000000 /* set in call_32_bit above */ + .quad . - kexec_reloc /* Relocated before use */ .type compat_mode_gdt_desc, @object .size compat_mode_gdt_desc, . - compat_mode_gdt_desc -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 17:49:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 17:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497214.768107 (Exim 4.92) (envelope-from ) id 1pT4qd-0002vY-NZ; Fri, 17 Feb 2023 17:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497214.768107; Fri, 17 Feb 2023 17:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qd-0002uk-I5; Fri, 17 Feb 2023 17:48:39 +0000 Received: by outflank-mailman (input) for mailman id 497214; Fri, 17 Feb 2023 17:48:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT4qc-0002rh-PM for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 17:48:38 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4de634fe-aeeb-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 18:48:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4de634fe-aeeb-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676656116; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Qi06rQ6jIxtATArya/6ZWUCfIXvC0M1kM2wXHuTfZm8=; b=KFDp12A0PDNUozG82O31zc3jgFG3qPfReVh4232JAT3n/hKmS8PDdrmf tnPMwQtRZeajHZAVYqkVIJtkrZVcxPyUzjzRNmv6pgypYS/QVy5ttMXIH UvcDk7RXPNYF1SZ/vKgx4erGkW5y+4Cua2VvmWuVdg+vfMikY1950ZqX+ g=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96897980 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6xXvmqMZY0Fo7SzvrR3Ul8FynXyQoLVcMsEvi/4bfWQNrUoh1mMEy WEXC2jQMquKMDD8f9wiaY61pB9Vv8LQn95gGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wNmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0ul4PUVW+ axHEyAQcDLdiOX1npKpcuY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLoXmuuyi2a5WDpfsF+P/oI84nTJzRw327/oWDbQUo3UFZQKzxbAz o7A1zroPSA2BPyA9QSUoiOcp8LumwH3e51HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyNuV3x6nU4oiBpZ9MakNc6FWMRx kKXvY3mAn8xkK+tRifInluLlg+aNS8QJG4EQCYLSwoZ/tXuyL0OYgLzosVLS/Ds0ICscd3k6 3XT9XVl2e1P5SIe///jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg JTms5LChAztJcvX/MBofAnqNOjwj8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN5l0Mu8UPZCvxNv8fj2eN5yMCl/WIKDgYfqqMMoomjmZZKmdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf0P8dZCfM9EieVD7nlnlQvuqWXTk0zPPUy2OCTEFt/o8TKmMogE0U9ziF6Jo ogGZ5PQkEo3vS+XSnC/zLP/5GsidRATba0aYeQMHgJfCmKKwF0cNsI= IronPort-HdrOrdr: A9a23:Njs2vq600z9ODk9ErgPXwPfXdLJyesId70hD6qm+c20tTiX4rb HXoB1/73XJYVkqKRQdcLy7Scu9qDbnhP1ICOoqXItKPjOW3FdARbsKheDfKn/bexEWndQtsp uIHZIObuEYzmIXsS852mSF+hobr+VvOZrHudvj X-IronPort-AV: E=Sophos;i="5.97,306,1669093200"; d="scan'208";a="96897980" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper Subject: [PATCH 0/3] x86/kexec: ASM improvements Date: Fri, 17 Feb 2023 17:48:11 +0000 Message-ID: <20230217174814.1006961-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Mostly to get ELF metadata, but some other easy improvements too. Andrew Cooper (3): x86/kexec: Drop compatibility_mode_far x86/kexec: Simplify the relocation of compat_mode_gdt_desc x86/kexec: Annotate functions with ELF metadata xen/arch/x86/x86_64/kexec_reloc.S | 40 +++++++++++++++++-------------- 1 file changed, 22 insertions(+), 18 deletions(-) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:24:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:24:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497242.768146 (Exim 4.92) (envelope-from ) id 1pT5Oq-0001rj-0N; Fri, 17 Feb 2023 18:24:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497242.768146; Fri, 17 Feb 2023 18:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5Op-0001rc-Tc; Fri, 17 Feb 2023 18:23:59 +0000 Received: by outflank-mailman (input) for mailman id 497242; Fri, 17 Feb 2023 18:23:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5Oo-0001rS-Rj; Fri, 17 Feb 2023 18:23:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5Oo-0003eX-OV; Fri, 17 Feb 2023 18:23:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5Oo-00058f-Bc; Fri, 17 Feb 2023 18:23:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pT5Oo-0006SS-B8; Fri, 17 Feb 2023 18:23:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SW91+TBGmCJiZyWcbx3pAp58R26pIts5TITUumRP5Eg=; b=pljHNlNfSWc3tNTZUq8oAbaqym uAhbvIZJJOiLOF1goL6j4sNzR1JbjIvZ8HWNLne8n6QFAvti8pbxwaRbtFf1h69jcFUC6jNdPPa2C CfMfVcr6Oa9wp/JwIMLZM25uRvbcMrFhl49iW74ZpA/Ai/7oC0N7r/hbq1Y9YCNmayAo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177574: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=ec35307e18ba8174e2a3f701956059f6a36f22fb X-Osstest-Versions-That: linux=3ac88fa4605ec98e545fb3ad0154f575fda2de5f From: osstest service owner Date: Fri, 17 Feb 2023 18:23:58 +0000 flight 177574 linux-linus real [real] flight 177631 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177574/ http://logs.test-lab.xenproject.org/osstest/logs/177631/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 177531 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177531 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail like 177531 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux ec35307e18ba8174e2a3f701956059f6a36f22fb baseline version: linux 3ac88fa4605ec98e545fb3ad0154f575fda2de5f Last test of basis 177531 2023-02-16 20:42:54 Z 0 days Testing same since 177574 2023-02-17 06:09:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Dave Airlie Dave Stevenson Dom Cobley Greg Kroah-Hartman Jack Xiao Jani Nikula Jim Cromie Jocelyn Falempe Leo Li Linus Torvalds Matt Roper Maxime Ripard Mikhail Gavrilov Miko Larsson Rodrigo Vivi Takashi Iwai Thomas Zimmermann Ville Syrjälä Zack Rusin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 398 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:48:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:48:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497254.768157 (Exim 4.92) (envelope-from ) id 1pT5mX-000551-36; Fri, 17 Feb 2023 18:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497254.768157; Fri, 17 Feb 2023 18:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mX-00054u-07; Fri, 17 Feb 2023 18:48:29 +0000 Received: by outflank-mailman (input) for mailman id 497254; Fri, 17 Feb 2023 18:48:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mW-00054o-30 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:48:28 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa05025d-aef3-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 19:48:27 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id i28so7288556eda.8 for ; Fri, 17 Feb 2023 10:48:27 -0800 (PST) Received: from uni.router.wind (adsl-65.109.242.225.tellas.gr. [109.242.225.65]) by smtp.googlemail.com with ESMTPSA id z61-20020a509e43000000b004ad03b18ae3sm2641585ede.62.2023.02.17.10.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:48:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa05025d-aef3-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FVwarZtmkTXGqh8KcAnLXaGi6zlKgoAyKXggXaH/kQs=; b=IXC1sb+KpSnBZdP+KAmUvcYLIau52gdcdkuTeorOy1MR6/VwEdW7rA8Bcu3kbRnuu0 sqywVbmdnv96zabWvwKM2HzW5PrpYzRGPsGrGvvYnp/8KVzvPi+bcNEzJGKdV5E8QquM Afell5y76NRkqlrQtu9RQf8w40yvUlfLsMVjBvBvANhVjRqv1iRYcXikKExGIVRffPpE f9NQMbF3mbp8ROtl+8d6yqM5ulnY6VPBri4aYsOo13w3XFg415g3DTrl7q/m5x7EsGA8 bycI+AFNnoS95GzGNmPZf3uwsqdgjGXxnXu8tQpY2Ai4zdfp2YW4ua574fHlQ7bYEgUp rRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FVwarZtmkTXGqh8KcAnLXaGi6zlKgoAyKXggXaH/kQs=; b=eISvtcTGIOB6atvOLXeVKdjS4w5z2XL25ueBAltd//mm5LmNhHsX3LT3C1OZSTe4Tn 7v/JX4Ir4oImFiQwbhk9nrAJvHxVzLQMSHbW7XAzHHzQCi7Tg4uMl9GOIolZwj57V432 P5L/4UG8LTbi3F1HZjojGWxjxgjeFjo/fWdVO/lbwRalr2d65/joB7grT85VwoKfGCuD +4nVXE4KzxkGkOQsAifWeQc15p/PrZBl1+JoFMXwwKcSKIrVKI2qPEETusz6vSN7me3E /p3tjs+B949KxH2gPPgBeZ17A82SCRfiXQGN/8x6rchn2eUtVlUUcBa50dVSCYsqEF/a RUFg== X-Gm-Message-State: AO0yUKWeDyP12t87cAgYHGfIcEwYzJIMHYjf+TNoRLyIl9s2KQY5V2of foFCk3Rpd547YL2yURZRqhQBgQUtXew= X-Google-Smtp-Source: AK7set8v2ApEerbiU2tweJkxUJaAeNGQEOeULXNiHvvEvGcJ7DVKvT7Y2L4iqw85RJTWy0kUJwCDvQ== X-Received: by 2002:a05:6402:2997:b0:4ac:d90e:92b with SMTP id eq23-20020a056402299700b004acd90e092bmr6616302edb.10.1676659706516; Fri, 17 Feb 2023 10:48:26 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 0/4] x86/hvm: {svm,vmx}.{c,h} cleanup Date: Fri, 17 Feb 2023 20:48:10 +0200 Message-Id: <20230217184814.1243046-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series attempts a cleanup of files {svm,vmx}.{c,h} by removing redundant headers and sorting the rest, removing forward declarations for static functions, reducing the scope of declarations and definitions, removing redundant new lines and trailing spaces etc Xenia Ragiadakou (4): x86/svm: cleanup svm.c x86/svm: cleanup svm.h x86/vmx: cleanup vmx.c x86/vmx: cleanup vmx.h xen/arch/x86/hvm/svm/svm.c | 163 +- xen/arch/x86/hvm/svm/vmcb.c | 3 + xen/arch/x86/hvm/vmx/vmcs.c | 43 + xen/arch/x86/hvm/vmx/vmx.c | 6053 ++++++++++++------------ xen/arch/x86/include/asm/hvm/svm/svm.h | 13 +- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 194 +- 6 files changed, 3210 insertions(+), 3259 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:48:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:48:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497255.768168 (Exim 4.92) (envelope-from ) id 1pT5ma-0005KJ-Ab; Fri, 17 Feb 2023 18:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497255.768168; Fri, 17 Feb 2023 18:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5ma-0005KA-7r; Fri, 17 Feb 2023 18:48:32 +0000 Received: by outflank-mailman (input) for mailman id 497255; Fri, 17 Feb 2023 18:48:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mZ-0005Js-E5 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:48:31 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab3448b7-aef3-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 19:48:29 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id co2so7296675edb.13 for ; Fri, 17 Feb 2023 10:48:29 -0800 (PST) Received: from uni.router.wind (adsl-65.109.242.225.tellas.gr. [109.242.225.65]) by smtp.googlemail.com with ESMTPSA id z61-20020a509e43000000b004ad03b18ae3sm2641585ede.62.2023.02.17.10.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:48:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab3448b7-aef3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aiK93wK0Vk/CzELNOerHhZzhGVV4JcKuWrkYZRhU+Sk=; b=Swhy9igNy82jEuV9AgsPcpPGLxsc6vaT419aaYKw+Y65ZnWjth5Zs32X9ng96F4RJQ DljEbpZB+d63LjdTxxn0Ig6I/hTTs02EnfJdLEeX5okFuR1dVhF3FFJETM473S858H/q nEMNWKg1lQZ7yHjH3Ueq+efUlr4vlQMR21q7iI2Kqht6c8wjNUHlVscsrP0KlT4G0L8L +71Loj/vK5lEHFPAA/CkIkFQmTSvQdaVQJHU58ueQVWpwnIKrIe2VVF046+RECeVWB8f egGgYbhpqetWV35o/L4sjn8zy+MgPsyI2uSkcHfozqYIKNMTpUG/nZkE9Pc8WaqxXIod KMdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aiK93wK0Vk/CzELNOerHhZzhGVV4JcKuWrkYZRhU+Sk=; b=gtv3yIvz/g3Ec5yRBI2sigqUw7nh3Te+F0VTdd5ARyW5JkwUKbo4jUOIcA7vYOfElE yVWA2m3oMRnfm2O3y0fONQL5Z4utTUP+zvqEZuclJGdLB02EJ3yNzdaNLZvsXDCAf6I6 vAqmhd5F2cw5imaeW9i97dto6+UAutKQB9xuAKi4fXzqGVPI26hWEmS3cWb8IjLE6iIx sGVezzk3vtDHWztcb2/nnc7N5m1ixeOnyekHk6J6dDO66oYDk2uCHOZqt3rYslI69llM hR4bGeykvl+1xkPE4lPc2QqboK6FBRkYJA2HUqvkQYHdTCNs9Udu6uHiSxbtwjj5LUon 1XyQ== X-Gm-Message-State: AO0yUKXUWb7UoRSalU+2McRpAlJLgehMnoU/dshqf+HUG2Z2ytGxOKwA 3+4gQWSHHDvJkVNG9eJ1B4giyT4+Jak= X-Google-Smtp-Source: AK7set9tHyLTP7F3E1Fg9wYSRvNXb7eAPB1EEWHPS/QpvjAAmGWf0G6FV4wsGUtK87SzGDvSOqQABw== X-Received: by 2002:a05:6402:10d2:b0:4ad:316:b4d9 with SMTP id p18-20020a05640210d200b004ad0316b4d9mr1750264edu.15.1676659708615; Fri, 17 Feb 2023 10:48:28 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/4] x86/svm: cleanup svm.c Date: Fri, 17 Feb 2023 20:48:11 +0200 Message-Id: <20230217184814.1243046-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230217184814.1243046-1-burzalodowa@gmail.com> References: <20230217184814.1243046-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs.h because none of the declarations and macro definitions in them is used. Sort alphabetically the rest of the headers. Remove the forward declaration of svm_function_table and place start_svm() after the svm_function_table's definition. Replace double new lines with one. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/svm/svm.c | 159 +++++++++++++++++-------------------- 1 file changed, 72 insertions(+), 87 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index fa73257203..f0bc72c313 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -16,60 +16,47 @@ * this program; If not, see . */ +#include #include +#include #include #include -#include #include -#include -#include -#include -#include +#include #include -#include -#include -#include -#include -#include -#include -#include -#include #include +#include +#include +#include #include -#include -#include -#include +#include #include #include -#include #include -#include +#include +#include +#include #include -#include -#include #include -#include -#include #include -#include -#include -#include -#include -#include +#include +#include +#include #include -#include -#include -#include -#include +#include +#include #include -#include +#include +#include +#include +#include +#include +#include void noreturn svm_asm_do_resume(void); u32 svm_feature_flags; -static struct hvm_function_table svm_function_table; - /* * Physical addresses of the Host State Area (for hardware) and vmcb (for Xen) * which contains Xen's fs/gs/tr/ldtr and GSBASE/STAR/SYSENTER state when in @@ -505,7 +492,6 @@ static int svm_vmcb_restore(struct vcpu *v, struct hvm_hw_cpu *c) return 0; } - static void svm_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) { struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; @@ -517,7 +503,6 @@ static void svm_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) data->msr_syscall_mask = vmcb->sfmask; } - static void svm_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) { struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; @@ -1649,57 +1634,6 @@ static int cf_check svm_cpu_up(void) return _svm_cpu_up(false); } -const struct hvm_function_table * __init start_svm(void) -{ - bool_t printed = 0; - - svm_host_osvw_reset(); - - if ( _svm_cpu_up(true) ) - { - printk("SVM: failed to initialise.\n"); - return NULL; - } - - setup_vmcb_dump(); - - if ( boot_cpu_data.extended_cpuid_level >= 0x8000000a ) - svm_feature_flags = cpuid_edx(0x8000000a); - - printk("SVM: Supported advanced features:\n"); - - /* DecodeAssists fast paths assume nextrip is valid for fast rIP update. */ - if ( !cpu_has_svm_nrips ) - __clear_bit(SVM_FEATURE_DECODEASSISTS, &svm_feature_flags); - - if ( cpu_has_tsc_ratio ) - svm_function_table.tsc_scaling.ratio_frac_bits = 32; - -#define P(p,s) if ( p ) { printk(" - %s\n", s); printed = 1; } - P(cpu_has_svm_npt, "Nested Page Tables (NPT)"); - P(cpu_has_svm_lbrv, "Last Branch Record (LBR) Virtualisation"); - P(cpu_has_svm_nrips, "Next-RIP Saved on #VMEXIT"); - P(cpu_has_svm_cleanbits, "VMCB Clean Bits"); - P(cpu_has_svm_decode, "DecodeAssists"); - P(cpu_has_svm_vloadsave, "Virtual VMLOAD/VMSAVE"); - P(cpu_has_svm_vgif, "Virtual GIF"); - P(cpu_has_pause_filter, "Pause-Intercept Filter"); - P(cpu_has_pause_thresh, "Pause-Intercept Filter Threshold"); - P(cpu_has_tsc_ratio, "TSC Rate MSR"); - P(cpu_has_svm_sss, "NPT Supervisor Shadow Stack"); - P(cpu_has_svm_spec_ctrl, "MSR_SPEC_CTRL virtualisation"); -#undef P - - if ( !printed ) - printk(" - none\n"); - - svm_function_table.hap_supported = !!cpu_has_svm_npt; - svm_function_table.hap_capabilities = HVM_HAP_SUPERPAGE_2MB | - (cpu_has_page1gb ? HVM_HAP_SUPERPAGE_1GB : 0); - - return &svm_function_table; -} - static void svm_do_nested_pgfault(struct vcpu *v, struct cpu_user_regs *regs, uint64_t pfec, paddr_t gpa) { @@ -2598,6 +2532,57 @@ static struct hvm_function_table __initdata_cf_clobber svm_function_table = { }, }; +const struct hvm_function_table * __init start_svm(void) +{ + bool_t printed = 0; + + svm_host_osvw_reset(); + + if ( _svm_cpu_up(true) ) + { + printk("SVM: failed to initialise.\n"); + return NULL; + } + + setup_vmcb_dump(); + + if ( boot_cpu_data.extended_cpuid_level >= 0x8000000a ) + svm_feature_flags = cpuid_edx(0x8000000a); + + printk("SVM: Supported advanced features:\n"); + + /* DecodeAssists fast paths assume nextrip is valid for fast rIP update. */ + if ( !cpu_has_svm_nrips ) + __clear_bit(SVM_FEATURE_DECODEASSISTS, &svm_feature_flags); + + if ( cpu_has_tsc_ratio ) + svm_function_table.tsc_scaling.ratio_frac_bits = 32; + +#define P(p,s) if ( p ) { printk(" - %s\n", s); printed = 1; } + P(cpu_has_svm_npt, "Nested Page Tables (NPT)"); + P(cpu_has_svm_lbrv, "Last Branch Record (LBR) Virtualisation"); + P(cpu_has_svm_nrips, "Next-RIP Saved on #VMEXIT"); + P(cpu_has_svm_cleanbits, "VMCB Clean Bits"); + P(cpu_has_svm_decode, "DecodeAssists"); + P(cpu_has_svm_vloadsave, "Virtual VMLOAD/VMSAVE"); + P(cpu_has_svm_vgif, "Virtual GIF"); + P(cpu_has_pause_filter, "Pause-Intercept Filter"); + P(cpu_has_pause_thresh, "Pause-Intercept Filter Threshold"); + P(cpu_has_tsc_ratio, "TSC Rate MSR"); + P(cpu_has_svm_sss, "NPT Supervisor Shadow Stack"); + P(cpu_has_svm_spec_ctrl, "MSR_SPEC_CTRL virtualisation"); +#undef P + + if ( !printed ) + printk(" - none\n"); + + svm_function_table.hap_supported = !!cpu_has_svm_npt; + svm_function_table.hap_capabilities = HVM_HAP_SUPERPAGE_2MB | + (cpu_has_page1gb ? HVM_HAP_SUPERPAGE_1GB : 0); + + return &svm_function_table; +} + void svm_vmexit_handler(struct cpu_user_regs *regs) { uint64_t exit_reason; -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:48:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:48:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497256.768179 (Exim 4.92) (envelope-from ) id 1pT5mc-0005ax-I5; Fri, 17 Feb 2023 18:48:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497256.768179; Fri, 17 Feb 2023 18:48:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mc-0005al-Eh; Fri, 17 Feb 2023 18:48:34 +0000 Received: by outflank-mailman (input) for mailman id 497256; Fri, 17 Feb 2023 18:48:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5ma-0005Js-Re for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:48:32 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac6a99ed-aef3-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 19:48:31 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id h14so8050672edz.10 for ; Fri, 17 Feb 2023 10:48:31 -0800 (PST) Received: from uni.router.wind (adsl-65.109.242.225.tellas.gr. [109.242.225.65]) by smtp.googlemail.com with ESMTPSA id z61-20020a509e43000000b004ad03b18ae3sm2641585ede.62.2023.02.17.10.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:48:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac6a99ed-aef3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Djk/78DDpP+8CW5w/ow3EWkMxANCkYy8Nj+VhfuGuV0=; b=JnuEVHWyjYlmG1Cad2vXXTaRQLYYmbLcqzodb5jQRczSQpX9QwwLUBZZHsL927LQ68 fXLn7l0IvOThqO2r8UAJbnXQRlU3qRuzc4bFvFbJG1svZe09wcSNnbkdNE2NMNgDEtEq ZLxiIjhKpcHo3ebWLEUDKAro4ych0UJqpiU6JW64OLv2rqkgUvrAIcUTZzef+K7qZce0 KxQNLqQyQauCEjlbRMRjHgsLKnlxpQDWcXM7PuxaVIJFYhWEgAljbIaRVoAiol5/sB/2 9DYxmjnpkcTLGnTJLravCMPeaGbbCJTXK2PoLHZBV1v+/ZH7/1tvbVn7Se3dSH4NF7ku Lu7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djk/78DDpP+8CW5w/ow3EWkMxANCkYy8Nj+VhfuGuV0=; b=i3rd0xSm6aE8jvKQc0w2QyBlrkCHl0xvZOw7+RllEOoF/D29EUTfUc3+KsjXSpxdZ4 0xCH/zQz7ban1FXuC44RVQ8GG9j7kiJhjepH94Muy4Ku48qs28Le+z83s+Zpvw8WMUJX pFFEBVs+v2RheYXgQkgDNoWGglKkIDISuw05/CnvrGPsg7ykjef1nameURZ8gwyjpck+ bPALWbyzi/ixekzHbM5A6ZOMWhvv63ZXcZENIuBQCvN6bHDPu5H2c4lQc0PTPWcnxC+7 KY5mzdUxkuzXlM0eQmOKvbOMzRVCfowsWJfi2xGZV1E0SJxdtxt640PaSgMToPC2LJ58 yMpA== X-Gm-Message-State: AO0yUKUwA/BSDaj4t+rIuG0cQLtVVNt9Qa2mFqeaoL93WSZNPegJOYuZ 6dBt9/N/ojiCcf2OEbZTIzP0U77kCkk= X-Google-Smtp-Source: AK7set/U013G0DNq0T8SasvqUD6wh9RUcm5fU9EqzvrKn/pheoI8MCst3mPDFpfExMuaj07v1qtIKw== X-Received: by 2002:a05:6402:492:b0:4a2:4ed3:c151 with SMTP id k18-20020a056402049200b004a24ed3c151mr1743182edv.39.1676659710632; Fri, 17 Feb 2023 10:48:30 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/4] x86/svm: cleanup svm.h Date: Fri, 17 Feb 2023 20:48:12 +0200 Message-Id: <20230217184814.1243046-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230217184814.1243046-1-burzalodowa@gmail.com> References: <20230217184814.1243046-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the forward declaration of struct vcpu because it is not used. Move the forward declaration of struct cpu_user_regs just above the function that needs it (to remind that it will need to be removed along with the function). Move the definitions of NPT_PFEC_with_gla and NPT_PFEC_in_gpt in svm.c because they are used only in this file. Move the definitions of SVM_PAUSE{FILTER,THRESH}_INIT in vmcb.c because they are used only in this file. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/svm/svm.c | 6 ++++++ xen/arch/x86/hvm/svm/vmcb.c | 3 +++ xen/arch/x86/include/asm/hvm/svm/svm.h | 13 +------------ 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index f0bc72c313..620c0d2e67 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1634,6 +1634,12 @@ static int cf_check svm_cpu_up(void) return _svm_cpu_up(false); } +/* EXITINFO1 fields on NPT faults */ +#define _NPT_PFEC_with_gla 32 +#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) +#define _NPT_PFEC_in_gpt 33 +#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) + static void svm_do_nested_pgfault(struct vcpu *v, struct cpu_user_regs *regs, uint64_t pfec, paddr_t gpa) { diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e3..151a04b60d 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -30,6 +30,9 @@ #include #include +#define SVM_PAUSEFILTER_INIT 4000 +#define SVM_PAUSETHRESH_INIT 1000 + struct vmcb_struct *alloc_vmcb(void) { struct vmcb_struct *vmcb; diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59..2cd9cea4a0 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -45,10 +45,8 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) "a" (linear), "c" (asid)); } -struct cpu_user_regs; -struct vcpu; - unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); +struct cpu_user_regs; void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); /* @@ -96,17 +94,8 @@ extern u32 svm_feature_flags; #define cpu_has_svm_sss cpu_has_svm_feature(SVM_FEATURE_SSS) #define cpu_has_svm_spec_ctrl cpu_has_svm_feature(SVM_FEATURE_SPEC_CTRL) -#define SVM_PAUSEFILTER_INIT 4000 -#define SVM_PAUSETHRESH_INIT 1000 - /* TSC rate */ #define DEFAULT_TSC_RATIO 0x0000000100000000ULL #define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL -/* EXITINFO1 fields on NPT faults */ -#define _NPT_PFEC_with_gla 32 -#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) -#define _NPT_PFEC_in_gpt 33 -#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) - #endif /* __ASM_X86_HVM_SVM_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:48:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:48:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497257.768190 (Exim 4.92) (envelope-from ) id 1pT5mi-0005w7-RP; Fri, 17 Feb 2023 18:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497257.768190; Fri, 17 Feb 2023 18:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mi-0005w0-Nd; Fri, 17 Feb 2023 18:48:40 +0000 Received: by outflank-mailman (input) for mailman id 497257; Fri, 17 Feb 2023 18:48:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mg-00054o-8v for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:48:38 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aec33c5a-aef3-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 19:48:35 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id eg30so7566679edb.7 for ; Fri, 17 Feb 2023 10:48:35 -0800 (PST) Received: from uni.router.wind (adsl-65.109.242.225.tellas.gr. [109.242.225.65]) by smtp.googlemail.com with ESMTPSA id z61-20020a509e43000000b004ad03b18ae3sm2641585ede.62.2023.02.17.10.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:48:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aec33c5a-aef3-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zwpnNdLF03Qvt4ru2IS4FhVpf+3W2MPfD26oPHMc8BU=; b=kzD6k/sLHlVIg/YTl6AbRdSEzfFZX9bqqHFaA+7OJjoUjpEGAKUIeJg+8S6o88cDPJ 2x+pDXSG3n+a5rlnS9p0sTMJhs1It2bGNIciKtbArH4iIKSZhmW330uGvSmzoTp6iRqL dczSA1CooKINyUUB97mKnWSCJxzg9NIfyek1LlcKxEHt+XM4dfo9CptMC4kowJg9q41p PrIJ0vw3/DA4eoDZlDU31WkI+8ZgMkBseHKir/hibXcuY/xjcKwAAwuaFREGWobPWNtS TuIQlwzwLQq0IuQ+/sHb8Dxerw+9y56s52fVz5ZRN1CRU9SYVk29RlRztQz1MgAtkoHb qj8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zwpnNdLF03Qvt4ru2IS4FhVpf+3W2MPfD26oPHMc8BU=; b=NE9gQnFDZ5+ySTd1SZiTvkgEpKni5NF9KhBCBAlF1zXX1Ry3ZbptKEcVbcYmkcjVkZ v+Za+7aZk7KzA7Wgwvrym47wdMviwigS0ERv6dwfdlxMlXNXMeoO8rsMG2g+96L6eXi/ vo2w9dCwm+yct+qd+Xf3b6jode/YW5K5L9Tf18wMQPQL8AFAA5btyQMtSdyeNCNizH8K jjBpbs7UaMkPGb7vBwimNewMNVyNn+jb/hqGbdQ9LamHH5z2M4Ca+uxQMJfVI3IFj6KY hmYGRXr2NqMkw/5TCLR+RrvSsntKJAgXMaT8dvZZLRYgVoQEd7xV3aGI+LyhfSaMYLBJ T2rQ== X-Gm-Message-State: AO0yUKU2HqBOgM8MEa4yYc5Nihw/RB2R4Mt5sZkLPI7vQMsJGSzBdi9W ePq5LhEq7XbQ8MYV3V+Ggu1JJngYrmM= X-Google-Smtp-Source: AK7set+47OKSq70fzhQs3f6eyl9T6ME5IWD+PDDdaWod+KmL6CJUcR0xzOI44f3d4Ma4BLb/9tQ2qQ== X-Received: by 2002:a05:6402:2997:b0:4ab:1681:b99e with SMTP id eq23-20020a056402299700b004ab1681b99emr6153129edb.4.1676659713222; Fri, 17 Feb 2023 10:48:33 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/4] x86/vmx: cleanup vmx.c Date: Fri, 17 Feb 2023 20:48:13 +0200 Message-Id: <20230217184814.1243046-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230217184814.1243046-1-burzalodowa@gmail.com> References: <20230217184814.1243046-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/hvm/vpic.h asm/hvm/vpt.h asm/io.h asm/mce.h asm/mem_sharing.h asm/regs.h public/arch-x86/cpuid.h public/hvm/save.h because none of the declarations and macro definitions in them is used. Sort alphabetically the rest of the headers. Rearrange the code to replace all forward declarations with the function definitions. Replace double new lines with one. Reduce scope of nvmx_enqueue_n2_exceptions() to static because it is used only in this file. Move vmx_update_debug_state() in vmcs.c because it is used only in this file and limit its scope to this file by declaring it static and removing its declaration from vmx.h. Take the opportunity to remove all trailing spaces in vmx.c. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/vmx/vmcs.c | 12 + xen/arch/x86/hvm/vmx/vmx.c | 5844 ++++++++++++------------ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 - 3 files changed, 2913 insertions(+), 2944 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index e1c268789e..c46bb55f05 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1864,6 +1864,18 @@ void vmx_vmentry_failure(void) domain_crash(curr->domain); } +static void vmx_update_debug_state(struct vcpu *v) +{ + if ( v->arch.hvm.debug_state_latch ) + v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + else + v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + + vmx_vmcs_enter(v); + vmx_update_exception_bitmap(v); + vmx_vmcs_exit(v); +} + void noreturn vmx_asm_do_vmentry(void); void cf_check vmx_do_resume(void) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0ec33bcc18..d02ad01b9b 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -15,130 +15,236 @@ * this program; If not, see . */ +#include #include +#include #include +#include #include #include -#include +#include #include -#include #include -#include -#include -#include -#include -#include -#include -#include +#include +#include +#include #include -#include +#include +#include #include -#include -#include -#include +#include #include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include #include -#include -#include -#include #include -#include -#include -#include +#include +#include +#include +#include +#include +#include #include +#include +#include #include -#include +#include +#include +#include +#include +#include static bool_t __initdata opt_force_ept; boolean_param("force-ept", opt_force_ept); -static void cf_check vmx_ctxt_switch_from(struct vcpu *v); -static void cf_check vmx_ctxt_switch_to(struct vcpu *v); +void vmx_update_cpu_exec_control(struct vcpu *v) +{ + if ( nestedhvm_vcpu_in_guestmode(v) ) + nvmx_update_exec_control(v, v->arch.hvm.vmx.exec_control); + else + __vmwrite(CPU_BASED_VM_EXEC_CONTROL, v->arch.hvm.vmx.exec_control); +} -static int vmx_alloc_vlapic_mapping(struct domain *d); -static void vmx_free_vlapic_mapping(struct domain *d); -static void vmx_install_vlapic_mapping(struct vcpu *v); -static void cf_check vmx_update_guest_cr( - struct vcpu *v, unsigned int cr, unsigned int flags); -static void cf_check vmx_update_guest_efer(struct vcpu *v); -static void cf_check vmx_wbinvd_intercept(void); -static void cf_check vmx_fpu_dirty_intercept(void); -static int cf_check vmx_msr_read_intercept( - unsigned int msr, uint64_t *msr_content); -static int cf_check vmx_msr_write_intercept( - unsigned int msr, uint64_t msr_content); -static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear); +void vmx_update_secondary_exec_control(struct vcpu *v) +{ + if ( nestedhvm_vcpu_in_guestmode(v) ) + nvmx_update_secondary_exec_control(v, + v->arch.hvm.vmx.secondary_exec_control); + else + __vmwrite(SECONDARY_VM_EXEC_CONTROL, + v->arch.hvm.vmx.secondary_exec_control); +} -/* Values for domain's ->arch.hvm_domain.pi_ops.flags. */ -#define PI_CSW_FROM (1u << 0) -#define PI_CSW_TO (1u << 1) +void vmx_update_exception_bitmap(struct vcpu *v) +{ + u32 bitmap = unlikely(v->arch.hvm.vmx.vmx_realmode) + ? 0xffffffffu : v->arch.hvm.vmx.exception_bitmap; -struct vmx_pi_blocking_vcpu { - struct list_head list; - spinlock_t lock; -}; + if ( nestedhvm_vcpu_in_guestmode(v) ) + nvmx_update_exception_bitmap(v, bitmap); + else + __vmwrite(EXCEPTION_BITMAP, bitmap); +} + +static void vmx_fpu_enter(struct vcpu *v) +{ + vcpu_restore_fpu_lazy(v); + v->arch.hvm.vmx.exception_bitmap &= ~(1u << TRAP_no_device); + vmx_update_exception_bitmap(v); + v->arch.hvm.vmx.host_cr0 &= ~X86_CR0_TS; + __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0); +} + +static void cf_check vmx_fpu_leave(struct vcpu *v) +{ + ASSERT(!v->fpu_dirtied); + ASSERT(read_cr0() & X86_CR0_TS); + + if ( !(v->arch.hvm.vmx.host_cr0 & X86_CR0_TS) ) + { + v->arch.hvm.vmx.host_cr0 |= X86_CR0_TS; + __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0); + } + + /* + * If the guest does not have TS enabled then we must cause and handle an + * exception on first use of the FPU. If the guest *does* have TS enabled + * then this is not necessary: no FPU activity can occur until the guest + * clears CR0.TS, and we will initialise the FPU when that happens. + */ + if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) ) + { + v->arch.hvm.hw_cr[0] |= X86_CR0_TS; + __vmwrite(GUEST_CR0, v->arch.hvm.hw_cr[0]); + v->arch.hvm.vmx.exception_bitmap |= (1u << TRAP_no_device); + vmx_update_exception_bitmap(v); + } +} /* - * We maintain a per-CPU linked-list of vCPUs, so in PI wakeup - * handler we can find which vCPU should be woken up. + * To avoid MSR save/restore at every VM exit/entry time, we restore + * the x86_64 specific MSRs at domain switch time. Since these MSRs + * are not modified once set for para domains, we don't save them, + * but simply reset them to values set in percpu_traps_init(). */ -static DEFINE_PER_CPU(struct vmx_pi_blocking_vcpu, vmx_pi_blocking); +static void vmx_restore_host_msrs(void) +{ + /* No PV guests? No need to restore host SYSCALL infrastructure. */ + if ( !IS_ENABLED(CONFIG_PV) ) + return; -uint8_t __read_mostly posted_intr_vector; -static uint8_t __read_mostly pi_wakeup_vector; + /* Relies on the SYSCALL trampoline being at the start of the stubs. */ + wrmsrl(MSR_STAR, XEN_MSR_STAR); + wrmsrl(MSR_LSTAR, this_cpu(stubs.addr)); + wrmsrl(MSR_SYSCALL_MASK, XEN_SYSCALL_MASK); +} -void vmx_pi_per_cpu_init(unsigned int cpu) +static void vmx_save_guest_msrs(struct vcpu *v) { - INIT_LIST_HEAD(&per_cpu(vmx_pi_blocking, cpu).list); - spin_lock_init(&per_cpu(vmx_pi_blocking, cpu).lock); + const struct cpuid_policy *cp = v->domain->arch.cpuid; + struct vcpu_msrs *msrs = v->arch.msrs; + + /* + * We cannot cache SHADOW_GS_BASE while the VCPU runs, as it can + * be updated at any time via SWAPGS, which we cannot trap. + */ + v->arch.hvm.vmx.shadow_gs = read_gs_shadow(); + + if ( v->arch.hvm.vmx.ipt_active ) + { + rdmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); + rdmsrl(MSR_RTIT_STATUS, msrs->rtit.status); + } + + if ( cp->feat.pks ) + msrs->pkrs = rdpkrs_and_cache(); } -static void cf_check vmx_vcpu_block(struct vcpu *v) +static void vmx_restore_guest_msrs(struct vcpu *v) { - unsigned long flags; - unsigned int dest; - spinlock_t *old_lock; - spinlock_t *pi_blocking_list_lock = - &per_cpu(vmx_pi_blocking, v->processor).lock; - struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; + const struct cpuid_policy *cp = v->domain->arch.cpuid; + const struct vcpu_msrs *msrs = v->arch.msrs; - spin_lock_irqsave(pi_blocking_list_lock, flags); - old_lock = cmpxchg(&v->arch.hvm.vmx.pi_blocking.lock, NULL, - pi_blocking_list_lock); + write_gs_shadow(v->arch.hvm.vmx.shadow_gs); + wrmsrl(MSR_STAR, v->arch.hvm.vmx.star); + wrmsrl(MSR_LSTAR, v->arch.hvm.vmx.lstar); + wrmsrl(MSR_SYSCALL_MASK, v->arch.hvm.vmx.sfmask); - /* - * 'v->arch.hvm.vmx.pi_blocking.lock' should be NULL before - * being assigned to a new value, since the vCPU is currently - * running and it cannot be on any blocking list. - */ - ASSERT(old_lock == NULL); + if ( cpu_has_msr_tsc_aux ) + wrmsr_tsc_aux(msrs->tsc_aux); - list_add_tail(&v->arch.hvm.vmx.pi_blocking.list, - &per_cpu(vmx_pi_blocking, v->processor).list); - spin_unlock_irqrestore(pi_blocking_list_lock, flags); + if ( v->arch.hvm.vmx.ipt_active ) + { + wrmsrl(MSR_RTIT_OUTPUT_BASE, page_to_maddr(v->vmtrace.pg)); + wrmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); + wrmsrl(MSR_RTIT_STATUS, msrs->rtit.status); + } - ASSERT(!pi_test_sn(pi_desc)); + if ( cp->feat.pks ) + wrpkrs(msrs->pkrs); +} - dest = cpu_physical_id(v->processor); +static void vmx_save_dr(struct vcpu *v) +{ + if ( !v->arch.hvm.flag_dr_dirty ) + return; - ASSERT(pi_desc->ndst == - (x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK))); + /* Clear the DR dirty flag and re-enable intercepts for DR accesses. */ + v->arch.hvm.flag_dr_dirty = 0; + v->arch.hvm.vmx.exec_control |= CPU_BASED_MOV_DR_EXITING; + vmx_update_cpu_exec_control(v); - write_atomic(&pi_desc->nv, pi_wakeup_vector); + v->arch.dr[0] = read_debugreg(0); + v->arch.dr[1] = read_debugreg(1); + v->arch.dr[2] = read_debugreg(2); + v->arch.dr[3] = read_debugreg(3); + v->arch.dr6 = read_debugreg(6); + /* DR7 must be saved as it is used by vmx_restore_dr(). */ + __vmread(GUEST_DR7, &v->arch.dr7); +} + +static void __restore_debug_registers(struct vcpu *v) +{ + if ( v->arch.hvm.flag_dr_dirty ) + return; + + v->arch.hvm.flag_dr_dirty = 1; + + write_debugreg(0, v->arch.dr[0]); + write_debugreg(1, v->arch.dr[1]); + write_debugreg(2, v->arch.dr[2]); + write_debugreg(3, v->arch.dr[3]); + write_debugreg(6, v->arch.dr6); + /* DR7 is loaded from the VMCS. */ +} + +/* + * DR7 is saved and restored on every vmexit. Other debug registers only + * need to be restored if their value is going to affect execution -- i.e., + * if one of the breakpoints is enabled. So mask out all bits that don't + * enable some breakpoint functionality. + */ +static void vmx_restore_dr(struct vcpu *v) +{ + /* NB. __vmread() is not usable here, so we cannot read from the VMCS. */ + if ( unlikely(v->arch.dr7 & DR7_ACTIVE_MASK) ) + __restore_debug_registers(v); } +/* Values for domain's ->arch.hvm_domain.pi_ops.flags. */ +#define PI_CSW_FROM (1u << 0) +#define PI_CSW_TO (1u << 1) + +struct vmx_pi_blocking_vcpu { + struct list_head list; + spinlock_t lock; +}; + +/* + * We maintain a per-CPU linked-list of vCPUs, so in PI wakeup + * handler we can find which vCPU should be woken up. + */ +static DEFINE_PER_CPU(struct vmx_pi_blocking_vcpu, vmx_pi_blocking); + static void vmx_pi_switch_from(struct vcpu *v) { struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; @@ -160,3561 +266,3424 @@ static void vmx_pi_switch_to(struct vcpu *v) pi_clear_sn(pi_desc); } -static void vmx_pi_unblock_vcpu(struct vcpu *v) +static void cf_check vmx_ctxt_switch_from(struct vcpu *v) { - unsigned long flags; - spinlock_t *pi_blocking_list_lock; - struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; - /* - * Set 'NV' field back to posted_intr_vector, so the - * Posted-Interrupts can be delivered to the vCPU when - * it is running in non-root mode. + * Return early if trying to do a context switch without VMX enabled, + * this can happen when the hypervisor shuts down with HVM guests + * still running. */ - write_atomic(&pi_desc->nv, posted_intr_vector); - - pi_blocking_list_lock = v->arch.hvm.vmx.pi_blocking.lock; - - /* Prevent the compiler from eliminating the local variable.*/ - smp_rmb(); - - /* The vCPU is not on any blocking list. */ - if ( pi_blocking_list_lock == NULL ) + if ( unlikely(!this_cpu(vmxon)) ) return; - spin_lock_irqsave(pi_blocking_list_lock, flags); - - /* - * v->arch.hvm.vmx.pi_blocking.lock == NULL here means the vCPU - * was removed from the blocking list while we are acquiring the lock. - */ - if ( v->arch.hvm.vmx.pi_blocking.lock != NULL ) + if ( !v->is_running ) { - ASSERT(v->arch.hvm.vmx.pi_blocking.lock == pi_blocking_list_lock); - list_del(&v->arch.hvm.vmx.pi_blocking.list); - v->arch.hvm.vmx.pi_blocking.lock = NULL; + /* + * When this vCPU isn't marked as running anymore, a remote pCPU's + * attempt to pause us (from vmx_vmcs_enter()) won't have a reason + * to spin in vcpu_sleep_sync(), and hence that pCPU might have taken + * away the VMCS from us. As we're running with interrupts disabled, + * we also can't call vmx_vmcs_enter(). + */ + vmx_vmcs_reload(v); } - spin_unlock_irqrestore(pi_blocking_list_lock, flags); + if ( !v->arch.fully_eager_fpu ) + vmx_fpu_leave(v); + vmx_save_guest_msrs(v); + vmx_restore_host_msrs(); + vmx_save_dr(v); + + if ( v->domain->arch.hvm.pi_ops.flags & PI_CSW_FROM ) + vmx_pi_switch_from(v); } -static void vmx_pi_do_resume(struct vcpu *v) +static void cf_check vmx_ctxt_switch_to(struct vcpu *v) { - ASSERT(!test_bit(_VPF_blocked, &v->pause_flags)); + vmx_restore_guest_msrs(v); + vmx_restore_dr(v); - vmx_pi_unblock_vcpu(v); + if ( v->domain->arch.hvm.pi_ops.flags & PI_CSW_TO ) + vmx_pi_switch_to(v); } -void vmx_pi_desc_fixup(unsigned int cpu) +static int vmx_alloc_vlapic_mapping(struct domain *d) { - unsigned int new_cpu, dest; - unsigned long flags; - struct vmx_vcpu *vmx, *tmp; - spinlock_t *new_lock, *old_lock = &per_cpu(vmx_pi_blocking, cpu).lock; - struct list_head *blocked_vcpus = &per_cpu(vmx_pi_blocking, cpu).list; + struct page_info *pg; + mfn_t mfn; - if ( !iommu_intpost ) - return; + if ( !has_vlapic(d) || !cpu_has_vmx_virtualize_apic_accesses ) + return 0; - /* - * We are in the context of CPU_DEAD or CPU_UP_CANCELED notification, - * and it is impossible for a second CPU go down in parallel. So we - * can safely acquire the old cpu's lock and then acquire the new_cpu's - * lock after that. - */ - spin_lock_irqsave(old_lock, flags); + pg = alloc_domheap_page(d, MEMF_no_refcount); + if ( !pg ) + return -ENOMEM; - list_for_each_entry_safe(vmx, tmp, blocked_vcpus, pi_blocking.list) + if ( !get_page_and_type(pg, d, PGT_writable_page) ) { /* - * Suppress notification or we may miss an interrupt when the - * target cpu is dying. - */ - pi_set_sn(&vmx->pi_desc); - - /* - * Check whether a notification is pending before doing the - * movement, if that is the case we need to wake up it directly - * other than moving it to the new cpu's list. + * The domain can't possibly know about this page yet, so failure + * here is a clear indication of something fishy going on. */ - if ( pi_test_on(&vmx->pi_desc) ) - { - list_del(&vmx->pi_blocking.list); - vmx->pi_blocking.lock = NULL; - vcpu_unblock(container_of(vmx, struct vcpu, arch.hvm.vmx)); - } - else - { - /* - * We need to find an online cpu as the NDST of the PI descriptor, it - * doesn't matter whether it is within the cpupool of the domain or - * not. As long as it is online, the vCPU will be woken up once the - * notification event arrives. - */ - new_cpu = cpumask_any(&cpu_online_map); - new_lock = &per_cpu(vmx_pi_blocking, new_cpu).lock; - - spin_lock(new_lock); + domain_crash(d); + return -ENODATA; + } - ASSERT(vmx->pi_blocking.lock == old_lock); + mfn = page_to_mfn(pg); + clear_domain_page(mfn); + d->arch.hvm.vmx.apic_access_mfn = mfn; - dest = cpu_physical_id(new_cpu); - write_atomic(&vmx->pi_desc.ndst, - x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK)); + return 0; +} - list_move(&vmx->pi_blocking.list, - &per_cpu(vmx_pi_blocking, new_cpu).list); - vmx->pi_blocking.lock = new_lock; +static void vmx_free_vlapic_mapping(struct domain *d) +{ + mfn_t mfn = d->arch.hvm.vmx.apic_access_mfn; - spin_unlock(new_lock); - } + d->arch.hvm.vmx.apic_access_mfn = _mfn(0); + if ( !mfn_eq(mfn, _mfn(0)) ) + { + struct page_info *pg = mfn_to_page(mfn); - pi_clear_sn(&vmx->pi_desc); + put_page_alloc_ref(pg); + put_page_and_type(pg); } - - spin_unlock_irqrestore(old_lock, flags); } -/* - * To handle posted interrupts correctly, we need to set the following - * state: - * - * * The PI notification vector (NV) - * * The PI notification destination processor (NDST) - * * The PI "suppress notification" bit (SN) - * * The vcpu pi "blocked" list - * - * VMX implements the runstate transitions as the following: - * - * A: ... -> running - * - SN = 0 - * - NDST = v->processor - * If a VM is currently running, we want the PI delivered to the guest vcpu - * on the proper pcpu. - * - * B: running -> ... - * - SN = 1 - * - * C: ... -> blocked - * - SN = 0 - * - NV = pi_wakeup_vector - * - Add vcpu to blocked list - * If the vm is blocked, we want the PI delivered to Xen so that it can - * wake it up. - * - * D: ... -> vmentry - * - SN = 0 - * - NV = posted_intr_vector - * - Take vcpu off blocked list - * - * If the VM is currently either preempted or offline (i.e., not running - * because of some reason other than blocking waiting for an interrupt), - * there's nothing Xen can do -- we want the interrupt pending bit set in - * the guest, but we don't want to bother Xen with an interrupt (SN clear). - * - * There's a brief window of time between vmx_intr_assist() and checking - * softirqs where if an interrupt comes in it may be lost; so we need Xen - * to get an interrupt and raise a softirq so that it will go through the - * vmx_intr_assist() path again (SN clear, NV = posted_interrupt). - */ - -/* This function is called when pcidevs_lock is held */ -void vmx_pi_hooks_assign(struct domain *d) +static void vmx_install_vlapic_mapping(struct vcpu *v) { - struct vcpu *v; + mfn_t apic_access_mfn = v->domain->arch.hvm.vmx.apic_access_mfn; + paddr_t virt_page_ma, apic_page_ma; - if ( !iommu_intpost || !is_hvm_domain(d) ) + if ( mfn_eq(apic_access_mfn, _mfn(0)) ) return; - ASSERT(!d->arch.hvm.pi_ops.vcpu_block); - - /* - * We carefully handle the timing here: - * - Install the context switch first - * - Then set the NDST field - * - Install the block and resume hooks in the end - * - * This can make sure the PI (especially the NDST feild) is - * in proper state when we call vmx_vcpu_block(). - */ - d->arch.hvm.pi_ops.flags = PI_CSW_FROM | PI_CSW_TO; - - for_each_vcpu ( d, v ) - { - unsigned int dest = cpu_physical_id(v->processor); - struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; + ASSERT(cpu_has_vmx_virtualize_apic_accesses); - /* - * We don't need to update NDST if vmx_pi_switch_to() - * has already got called. - */ - (void)cmpxchg(&pi_desc->ndst, APIC_INVALID_DEST, - x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK)); - } + virt_page_ma = page_to_maddr(vcpu_vlapic(v)->regs_page); + apic_page_ma = mfn_to_maddr(apic_access_mfn); - d->arch.hvm.pi_ops.vcpu_block = vmx_vcpu_block; + vmx_vmcs_enter(v); + __vmwrite(VIRTUAL_APIC_PAGE_ADDR, virt_page_ma); + __vmwrite(APIC_ACCESS_ADDR, apic_page_ma); + vmx_vmcs_exit(v); } -/* This function is called when pcidevs_lock is held */ -void vmx_pi_hooks_deassign(struct domain *d) +void cf_check vmx_vlapic_msr_changed(struct vcpu *v) { - struct vcpu *v; + int virtualize_x2apic_mode; + struct vlapic *vlapic = vcpu_vlapic(v); + unsigned int msr; - if ( !iommu_intpost || !is_hvm_domain(d) ) + virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt || + cpu_has_vmx_virtual_intr_delivery) && + cpu_has_vmx_virtualize_x2apic_mode ); + + if ( !cpu_has_vmx_virtualize_apic_accesses && + !virtualize_x2apic_mode ) return; - ASSERT(d->arch.hvm.pi_ops.vcpu_block); + vmx_vmcs_enter(v); + v->arch.hvm.vmx.secondary_exec_control &= + ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE); + if ( !vlapic_hw_disabled(vlapic) && + (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) + { + if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) + { + v->arch.hvm.vmx.secondary_exec_control |= + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; + if ( cpu_has_vmx_apic_reg_virt ) + { + for ( msr = MSR_X2APIC_FIRST; + msr <= MSR_X2APIC_LAST; msr++ ) + vmx_clear_msr_intercept(v, msr, VMX_MSR_R); - /* - * Pausing the domain can make sure the vCPUs are not - * running and hence not calling the hooks simultaneously - * when deassigning the PI hooks and removing the vCPU - * from the blocking list. - */ - ASSERT(current->domain != d); - domain_pause(d); - - /* - * Note that we don't set 'd->arch.hvm.pi_ops.switch_to' to NULL - * here. If we deassign the hooks while the vCPU is runnable in the - * runqueue with 'SN' set, all the future notification event will be - * suppressed since vmx_deliver_posted_intr() also use 'SN' bit - * as the suppression flag. Preserving the 'switch_to' hook function can - * clear the 'SN' bit when the vCPU becomes running next time. After - * that, No matter which status(runnable, running or block) the vCPU is in, - * the 'SN' bit will keep clear for the 'switch_from' hook function that set - * the 'SN' bit has been removed. At that time, the 'switch_to' hook function - * is also useless. Considering the function doesn't do harm to the whole - * system, leave it here until we find a clean solution to deassign the - * 'switch_to' hook function. - */ - d->arch.hvm.pi_ops.vcpu_block = NULL; - d->arch.hvm.pi_ops.flags = PI_CSW_TO; - - for_each_vcpu ( d, v ) - vmx_pi_unblock_vcpu(v); - - domain_unpause(d); -} - -/* - * This function is used to update the IRTE for posted-interrupt - * when guest changes MSI/MSI-X information. - */ -static int cf_check vmx_pi_update_irte(const struct vcpu *v, - const struct pirq *pirq, uint8_t gvec) -{ - const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; - struct irq_desc *desc; - struct msi_desc *msi_desc; - int rc; - - desc = pirq_spin_lock_irq_desc(pirq, NULL); - if ( !desc ) - return -EINVAL; - - msi_desc = desc->msi_desc; - if ( !msi_desc ) - { - rc = -ENODEV; - goto unlock_out; - } - msi_desc->pi_desc = pi_desc; - msi_desc->gvec = gvec; - - spin_unlock_irq(&desc->lock); - - ASSERT(pcidevs_locked()); - - return iommu_update_ire_from_msi(msi_desc, &msi_desc->msg); - - unlock_out: - spin_unlock_irq(&desc->lock); - - return rc; -} - -static const struct lbr_info { - u32 base, count; -} p4_lbr[] = { - { MSR_P4_LER_FROM_LIP, 1 }, - { MSR_P4_LER_TO_LIP, 1 }, - { MSR_P4_LASTBRANCH_TOS, 1 }, - { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, c2_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_C2_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, nh_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_NHL_LBR_SELECT, 1 }, - { MSR_NHL_LASTBRANCH_TOS, 1 }, - { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, sk_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_NHL_LBR_SELECT, 1 }, - { MSR_NHL_LASTBRANCH_TOS, 1 }, - { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH }, - { MSR_SKL_LASTBRANCH_0_TO_IP, NUM_MSR_SKL_LASTBRANCH }, - { MSR_SKL_LASTBRANCH_0_INFO, NUM_MSR_SKL_LASTBRANCH }, - { 0, 0 } -}, at_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_C2_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, sm_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_SM_LBR_SELECT, 1 }, - { MSR_SM_LASTBRANCH_TOS, 1 }, - { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}, gm_lbr[] = { - { MSR_IA32_LASTINTFROMIP, 1 }, - { MSR_IA32_LASTINTTOIP, 1 }, - { MSR_SM_LBR_SELECT, 1 }, - { MSR_SM_LASTBRANCH_TOS, 1 }, - { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, - { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, - { 0, 0 } -}; -static const struct lbr_info *__ro_after_init model_specific_lbr; - -static const struct lbr_info *__init get_model_specific_lbr(void) -{ - switch ( boot_cpu_data.x86 ) - { - case 6: - switch ( boot_cpu_data.x86_model ) - { - /* Core2 Duo */ - case 0x0f: - /* Enhanced Core */ - case 0x17: - /* Xeon 7400 */ - case 0x1d: - return c2_lbr; - /* Nehalem */ - case 0x1a: case 0x1e: case 0x1f: case 0x2e: - /* Westmere */ - case 0x25: case 0x2c: case 0x2f: - /* Sandy Bridge */ - case 0x2a: case 0x2d: - /* Ivy Bridge */ - case 0x3a: case 0x3e: - /* Haswell */ - case 0x3c: case 0x3f: case 0x45: case 0x46: - /* Broadwell */ - case 0x3d: case 0x47: case 0x4f: case 0x56: - return nh_lbr; - /* Skylake */ - case 0x4e: case 0x5e: - /* Xeon Scalable */ - case 0x55: - /* Cannon Lake */ - case 0x66: - /* Goldmont Plus */ - case 0x7a: - /* Ice Lake */ - case 0x6a: case 0x6c: case 0x7d: case 0x7e: - /* Tiger Lake */ - case 0x8c: case 0x8d: - /* Tremont */ - case 0x86: - /* Kaby Lake */ - case 0x8e: case 0x9e: - /* Comet Lake */ - case 0xa5: case 0xa6: - return sk_lbr; - /* Atom */ - case 0x1c: case 0x26: case 0x27: case 0x35: case 0x36: - return at_lbr; - /* Silvermont */ - case 0x37: case 0x4a: case 0x4d: case 0x5a: case 0x5d: - /* Xeon Phi Knights Landing */ - case 0x57: - /* Xeon Phi Knights Mill */ - case 0x85: - /* Airmont */ - case 0x4c: - return sm_lbr; - /* Goldmont */ - case 0x5c: case 0x5f: - return gm_lbr; - } - break; - - case 15: - switch ( boot_cpu_data.x86_model ) - { - /* Pentium4/Xeon with em64t */ - case 3: case 4: case 6: - return p4_lbr; + vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); + } + if ( cpu_has_vmx_virtual_intr_delivery ) + { + vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, VMX_MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, VMX_MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); + } } - break; + else + v->arch.hvm.vmx.secondary_exec_control |= + SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; } + if ( !(v->arch.hvm.vmx.secondary_exec_control & + SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) + for ( msr = MSR_X2APIC_FIRST; + msr <= MSR_X2APIC_LAST; msr++ ) + vmx_set_msr_intercept(v, msr, VMX_MSR_RW); - return NULL; -} - -static int cf_check vmx_domain_initialise(struct domain *d) -{ - static const struct arch_csw csw = { - .from = vmx_ctxt_switch_from, - .to = vmx_ctxt_switch_to, - .tail = vmx_do_resume, - }; - int rc; - - d->arch.ctxt_switch = &csw; - - /* - * Work around CVE-2018-12207? The hardware domain is already permitted - * to reboot the system, so doesn't need mitigating against DoS's. - */ - d->arch.hvm.vmx.exec_sp = is_hardware_domain(d) || opt_ept_exec_sp; - - if ( (rc = vmx_alloc_vlapic_mapping(d)) != 0 ) - return rc; - - return 0; -} - -static void cf_check vmx_domain_relinquish_resources(struct domain *d) -{ - vmx_free_vlapic_mapping(d); -} - -static void cf_check domain_creation_finished(struct domain *d) -{ - gfn_t gfn = gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE); - mfn_t apic_access_mfn = d->arch.hvm.vmx.apic_access_mfn; - bool ipat; - - if ( mfn_eq(apic_access_mfn, _mfn(0)) ) - return; - - ASSERT(epte_get_entry_emt(d, gfn, apic_access_mfn, 0, &ipat, - p2m_mmio_direct) == X86_MT_WB); - ASSERT(ipat); - - if ( set_mmio_p2m_entry(d, gfn, apic_access_mfn, PAGE_ORDER_4K) ) - domain_crash(d); + vmx_update_secondary_exec_control(v); + vmx_vmcs_exit(v); } -static void vmx_init_ipt(struct vcpu *v) +static void vmx_load_pdptrs(struct vcpu *v) { - unsigned int size = v->domain->vmtrace_size; + uint32_t cr3 = v->arch.hvm.guest_cr[3]; + const uint64_t *guest_pdptes; + struct page_info *page; + p2m_type_t p2mt; - if ( !size ) + /* EPT needs to load PDPTRS into VMCS for PAE. */ + if ( !hvm_pae_enabled(v) || hvm_long_mode_active(v) ) return; - /* Checked by domain creation logic. */ - ASSERT(v->vmtrace.pg); - ASSERT(size >= PAGE_SIZE && (size & (size - 1)) == 0); - - v->arch.msrs->rtit.output_limit = size - 1; -} - -static int cf_check vmx_vcpu_initialise(struct vcpu *v) -{ - int rc; - - spin_lock_init(&v->arch.hvm.vmx.vmcs_lock); - - INIT_LIST_HEAD(&v->arch.hvm.vmx.pi_blocking.list); - - vcpu_2_nvmx(v).vmxon_region_pa = INVALID_PADDR; - - if ( (rc = vmx_create_vmcs(v)) != 0 ) + page = get_page_from_gfn(v->domain, cr3 >> PAGE_SHIFT, &p2mt, P2M_ALLOC); + if ( !page ) { - dprintk(XENLOG_WARNING, - "Failed to create VMCS for vcpu %d: err=%d.\n", - v->vcpu_id, rc); - return rc; + /* Ideally you don't want to crash but rather go into a wait + * queue, but this is the wrong place. We're holding at least + * the paging lock */ + gdprintk(XENLOG_ERR, + "Bad cr3 on load pdptrs gfn %"PRIx32" type %d\n", + cr3 >> PAGE_SHIFT, (int) p2mt); + domain_crash(v->domain); + return; } + guest_pdptes = __map_domain_page(page) + (cr3 & ~(PAGE_MASK | 0x1f)); + /* - * It's rare but still possible that domain has already been in log-dirty - * mode when vcpu is being created (commented by Tim), in which case we - * should enable PML for this vcpu if PML has been enabled for the domain, - * and failure to enable results in failure of creating this vcpu. - * - * Note even there's no vcpu created for the domain, vmx_domain_enable_pml - * will return successful in which case vmx_domain_pml_enabled will also - * return true. And even this is the first vcpu to be created with - * vmx_domain_pml_enabled being true, failure of enabling PML still results - * in failure of creating vcpu, to avoid complicated logic to revert PML - * style EPT table to non-PML style EPT table. + * We do not check the PDPTRs for validity. The CPU will do this during + * vm entry, and we can handle the failure there and crash the guest. + * The only thing we could do better here is #GP instead. */ - if ( vmx_domain_pml_enabled(v->domain) ) - { - if ( (rc = vmx_vcpu_enable_pml(v)) != 0 ) - { - dprintk(XENLOG_ERR, "%pv: Failed to enable PML.\n", v); - vmx_destroy_vmcs(v); - return rc; - } - } - vmx_install_vlapic_mapping(v); - vmx_init_ipt(v); - - return 0; -} + vmx_vmcs_enter(v); -static void cf_check vmx_vcpu_destroy(struct vcpu *v) -{ - /* - * There are cases that domain still remains in log-dirty mode when it is - * about to be destroyed (ex, user types 'xl destroy '), in which case - * we should disable PML manually here. Note that vmx_vcpu_destroy is called - * prior to vmx_domain_destroy so we need to disable PML for each vcpu - * separately here. - */ - vmx_vcpu_disable_pml(v); - vmx_destroy_vmcs(v); - passive_domain_destroy(v); -} + __vmwrite(GUEST_PDPTE(0), guest_pdptes[0]); + __vmwrite(GUEST_PDPTE(1), guest_pdptes[1]); + __vmwrite(GUEST_PDPTE(2), guest_pdptes[2]); + __vmwrite(GUEST_PDPTE(3), guest_pdptes[3]); -/* - * To avoid MSR save/restore at every VM exit/entry time, we restore - * the x86_64 specific MSRs at domain switch time. Since these MSRs - * are not modified once set for para domains, we don't save them, - * but simply reset them to values set in percpu_traps_init(). - */ -static void vmx_restore_host_msrs(void) -{ - /* No PV guests? No need to restore host SYSCALL infrastructure. */ - if ( !IS_ENABLED(CONFIG_PV) ) - return; + vmx_vmcs_exit(v); - /* Relies on the SYSCALL trampoline being at the start of the stubs. */ - wrmsrl(MSR_STAR, XEN_MSR_STAR); - wrmsrl(MSR_LSTAR, this_cpu(stubs.addr)); - wrmsrl(MSR_SYSCALL_MASK, XEN_SYSCALL_MASK); + unmap_domain_page(guest_pdptes); + put_page(page); + return; } -static void vmx_save_guest_msrs(struct vcpu *v) +static void cf_check vmx_update_guest_cr( + struct vcpu *v, unsigned int cr, unsigned int flags) { - const struct cpuid_policy *cp = v->domain->arch.cpuid; - struct vcpu_msrs *msrs = v->arch.msrs; - - /* - * We cannot cache SHADOW_GS_BASE while the VCPU runs, as it can - * be updated at any time via SWAPGS, which we cannot trap. - */ - v->arch.hvm.vmx.shadow_gs = read_gs_shadow(); + vmx_vmcs_enter(v); - if ( v->arch.hvm.vmx.ipt_active ) + switch ( cr ) { - rdmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); - rdmsrl(MSR_RTIT_STATUS, msrs->rtit.status); - } + case 0: + { + bool realmode; + unsigned long hw_cr0_mask = X86_CR0_NE; - if ( cp->feat.pks ) - msrs->pkrs = rdpkrs_and_cache(); -} + if ( !vmx_unrestricted_guest(v) ) + hw_cr0_mask |= X86_CR0_PG | X86_CR0_PE; -static void vmx_restore_guest_msrs(struct vcpu *v) -{ - const struct cpuid_policy *cp = v->domain->arch.cpuid; - const struct vcpu_msrs *msrs = v->arch.msrs; + if ( paging_mode_shadow(v->domain) ) + hw_cr0_mask |= X86_CR0_WP; - write_gs_shadow(v->arch.hvm.vmx.shadow_gs); - wrmsrl(MSR_STAR, v->arch.hvm.vmx.star); - wrmsrl(MSR_LSTAR, v->arch.hvm.vmx.lstar); - wrmsrl(MSR_SYSCALL_MASK, v->arch.hvm.vmx.sfmask); + if ( paging_mode_hap(v->domain) ) + { + /* Manage GUEST_CR3 when CR0.PE=0. */ + uint32_t old_ctls = v->arch.hvm.vmx.exec_control; + uint32_t cr3_ctls = (CPU_BASED_CR3_LOAD_EXITING | + CPU_BASED_CR3_STORE_EXITING); - if ( cpu_has_msr_tsc_aux ) - wrmsr_tsc_aux(msrs->tsc_aux); + v->arch.hvm.vmx.exec_control &= ~cr3_ctls; + if ( !hvm_paging_enabled(v) && !vmx_unrestricted_guest(v) ) + v->arch.hvm.vmx.exec_control |= cr3_ctls; - if ( v->arch.hvm.vmx.ipt_active ) - { - wrmsrl(MSR_RTIT_OUTPUT_BASE, page_to_maddr(v->vmtrace.pg)); - wrmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask); - wrmsrl(MSR_RTIT_STATUS, msrs->rtit.status); - } + /* Trap CR3 updates if CR3 memory events are enabled. */ + if ( v->domain->arch.monitor.write_ctrlreg_enabled & + monitor_ctrlreg_bitmask(VM_EVENT_X86_CR3) ) + v->arch.hvm.vmx.exec_control |= CPU_BASED_CR3_LOAD_EXITING; - if ( cp->feat.pks ) - wrpkrs(msrs->pkrs); -} + if ( old_ctls != v->arch.hvm.vmx.exec_control ) + vmx_update_cpu_exec_control(v); + } -void vmx_update_cpu_exec_control(struct vcpu *v) -{ - if ( nestedhvm_vcpu_in_guestmode(v) ) - nvmx_update_exec_control(v, v->arch.hvm.vmx.exec_control); - else - __vmwrite(CPU_BASED_VM_EXEC_CONTROL, v->arch.hvm.vmx.exec_control); -} + if ( !nestedhvm_vcpu_in_guestmode(v) ) + __vmwrite(CR0_READ_SHADOW, v->arch.hvm.guest_cr[0]); + else + nvmx_set_cr_read_shadow(v, 0); -void vmx_update_secondary_exec_control(struct vcpu *v) -{ - if ( nestedhvm_vcpu_in_guestmode(v) ) - nvmx_update_secondary_exec_control(v, - v->arch.hvm.vmx.secondary_exec_control); - else - __vmwrite(SECONDARY_VM_EXEC_CONTROL, - v->arch.hvm.vmx.secondary_exec_control); -} + if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) ) + { + if ( v != current ) + { + if ( !v->arch.fully_eager_fpu ) + hw_cr0_mask |= X86_CR0_TS; + } + else if ( v->arch.hvm.hw_cr[0] & X86_CR0_TS ) + vmx_fpu_enter(v); + } -void vmx_update_exception_bitmap(struct vcpu *v) -{ - u32 bitmap = unlikely(v->arch.hvm.vmx.vmx_realmode) - ? 0xffffffffu : v->arch.hvm.vmx.exception_bitmap; + realmode = !(v->arch.hvm.guest_cr[0] & X86_CR0_PE); - if ( nestedhvm_vcpu_in_guestmode(v) ) - nvmx_update_exception_bitmap(v, bitmap); - else - __vmwrite(EXCEPTION_BITMAP, bitmap); -} + if ( !vmx_unrestricted_guest(v) && + (realmode != v->arch.hvm.vmx.vmx_realmode) ) + { + enum x86_segment s; + struct segment_register reg[x86_seg_tr + 1]; -static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) -{ - const struct cpuid_policy *cp = v->domain->arch.cpuid; - int rc = 0; + BUILD_BUG_ON(x86_seg_tr != x86_seg_gs + 1); - if ( opt_hvm_fep || - (v->domain->arch.cpuid->x86_vendor != boot_cpu_data.x86_vendor) ) - v->arch.hvm.vmx.exception_bitmap |= (1U << TRAP_invalid_op); - else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_invalid_op); + /* Entering or leaving real mode: adjust the segment registers. + * Need to read them all either way, as realmode reads can update + * the saved values we'll use when returning to prot mode. */ + for ( s = 0; s < ARRAY_SIZE(reg); s++ ) + hvm_get_segment_register(v, s, ®[s]); + v->arch.hvm.vmx.vmx_realmode = realmode; - vmx_vmcs_enter(v); - vmx_update_exception_bitmap(v); + if ( realmode ) + { + for ( s = 0; s < ARRAY_SIZE(reg); s++ ) + hvm_set_segment_register(v, s, ®[s]); + } + else + { + for ( s = 0; s < ARRAY_SIZE(reg); s++ ) + if ( !(v->arch.hvm.vmx.vm86_segment_mask & (1<arch.hvm.vmx.vm86_saved_seg[s]); + } - /* - * We can safely pass MSR_SPEC_CTRL through to the guest, even if STIBP - * isn't enumerated in hardware, as SPEC_CTRL_STIBP is ignored. - */ - if ( cp->feat.ibrsb ) - { - vmx_clear_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); + vmx_update_exception_bitmap(v); + } - rc = vmx_add_guest_msr(v, MSR_SPEC_CTRL, 0); - if ( rc ) - goto out; + v->arch.hvm.hw_cr[0] = + v->arch.hvm.guest_cr[0] | hw_cr0_mask; + __vmwrite(GUEST_CR0, v->arch.hvm.hw_cr[0]); } - else - { - vmx_set_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); + /* Fallthrough: Changing CR0 can change some bits in real CR4. */ + case 4: + v->arch.hvm.hw_cr[4] = HVM_CR4_HOST_MASK; + if ( paging_mode_hap(v->domain) ) + v->arch.hvm.hw_cr[4] &= ~X86_CR4_PAE; - rc = vmx_del_msr(v, MSR_SPEC_CTRL, VMX_MSR_GUEST); - if ( rc && rc != -ESRCH ) - goto out; - rc = 0; /* Tolerate -ESRCH */ - } + if ( !nestedhvm_vcpu_in_guestmode(v) ) + __vmwrite(CR4_READ_SHADOW, v->arch.hvm.guest_cr[4]); + else + nvmx_set_cr_read_shadow(v, 4); - /* MSR_PRED_CMD is safe to pass through if the guest knows about it. */ - if ( cp->feat.ibrsb || cp->extd.ibpb ) - vmx_clear_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); - else - vmx_set_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); + v->arch.hvm.hw_cr[4] |= v->arch.hvm.guest_cr[4]; + if ( v->arch.hvm.vmx.vmx_realmode ) + v->arch.hvm.hw_cr[4] |= X86_CR4_VME; - /* MSR_FLUSH_CMD is safe to pass through if the guest knows about it. */ - if ( cp->feat.l1d_flush ) - vmx_clear_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); - else - vmx_set_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + if ( !hvm_paging_enabled(v) ) + { + /* + * When the guest thinks paging is disabled, Xen may need to hide + * the effects of running with CR0.PG actually enabled. There are + * two subtly complicated cases. + */ - if ( cp->feat.pks ) - vmx_clear_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); - else - vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + if ( paging_mode_hap(v->domain) ) + { + /* + * On hardware lacking the Unrestricted Guest feature (or with + * it disabled in the VMCS), we may not enter the guest with + * CR0.PG actually disabled. When EPT is enabled, we run with + * guest paging settings, but with CR3 pointing at + * HVM_PARAM_IDENT_PT which is a 32bit pagetable using 4M + * superpages. Override the guests paging settings to match. + */ + v->arch.hvm.hw_cr[4] |= X86_CR4_PSE; + v->arch.hvm.hw_cr[4] &= ~X86_CR4_PAE; + } - out: - vmx_vmcs_exit(v); + /* + * Without CR0.PG, all memory accesses are user mode, so + * _PAGE_USER must be set in the pagetables for guest userspace to + * function. This in turn trips up guest supervisor mode if + * SMEP/SMAP are left active in context. They wouldn't have any + * effect if paging was actually disabled, so hide them behind the + * back of the guest. + */ + v->arch.hvm.hw_cr[4] &= ~(X86_CR4_SMEP | X86_CR4_SMAP); + } - if ( rc ) - { - printk(XENLOG_G_ERR "%pv MSR list error: %d", v, rc); - domain_crash(v->domain); - } -} + __vmwrite(GUEST_CR4, v->arch.hvm.hw_cr[4]); -int cf_check vmx_guest_x86_mode(struct vcpu *v) -{ - unsigned long cs_ar_bytes; + /* + * Shadow path has not been optimized because it requires + * unconditionally trapping more CR4 bits, at which point the + * performance benefit of doing this is quite dubious. + */ + if ( paging_mode_hap(v->domain) ) + { + /* + * Update CR4 host mask to only trap when the guest tries to set + * bits that are controlled by the hypervisor. + */ + v->arch.hvm.vmx.cr4_host_mask = + (HVM_CR4_HOST_MASK | X86_CR4_PKE | + ~hvm_cr4_guest_valid_bits(v->domain)); - if ( unlikely(!(v->arch.hvm.guest_cr[0] & X86_CR0_PE)) ) - return 0; - if ( unlikely(guest_cpu_user_regs()->eflags & X86_EFLAGS_VM) ) - return 1; - __vmread(GUEST_CS_AR_BYTES, &cs_ar_bytes); - if ( hvm_long_mode_active(v) && - likely(cs_ar_bytes & X86_SEG_AR_CS_LM_ACTIVE) ) - return 8; - return (likely(cs_ar_bytes & X86_SEG_AR_DEF_OP_SIZE) ? 4 : 2); -} + v->arch.hvm.vmx.cr4_host_mask |= v->arch.hvm.vmx.vmx_realmode ? + X86_CR4_VME : 0; + v->arch.hvm.vmx.cr4_host_mask |= !hvm_paging_enabled(v) ? + (X86_CR4_PSE | X86_CR4_SMEP | + X86_CR4_SMAP) + : 0; + if ( v->domain->arch.monitor.write_ctrlreg_enabled & + monitor_ctrlreg_bitmask(VM_EVENT_X86_CR4) ) + v->arch.hvm.vmx.cr4_host_mask |= + ~v->domain->arch.monitor.write_ctrlreg_mask[VM_EVENT_X86_CR4]; -static void vmx_save_dr(struct vcpu *v) -{ - if ( !v->arch.hvm.flag_dr_dirty ) - return; + if ( nestedhvm_vcpu_in_guestmode(v) ) + /* Add the nested host mask to get the more restrictive one. */ + v->arch.hvm.vmx.cr4_host_mask |= get_vvmcs(v, + CR4_GUEST_HOST_MASK); - /* Clear the DR dirty flag and re-enable intercepts for DR accesses. */ - v->arch.hvm.flag_dr_dirty = 0; - v->arch.hvm.vmx.exec_control |= CPU_BASED_MOV_DR_EXITING; - vmx_update_cpu_exec_control(v); + __vmwrite(CR4_GUEST_HOST_MASK, v->arch.hvm.vmx.cr4_host_mask); + } - v->arch.dr[0] = read_debugreg(0); - v->arch.dr[1] = read_debugreg(1); - v->arch.dr[2] = read_debugreg(2); - v->arch.dr[3] = read_debugreg(3); - v->arch.dr6 = read_debugreg(6); - /* DR7 must be saved as it is used by vmx_restore_dr(). */ - __vmread(GUEST_DR7, &v->arch.dr7); -} + break; + + case 2: + /* CR2 is updated in exit stub. */ + break; + + case 3: + if ( paging_mode_hap(v->domain) ) + { + if ( !hvm_paging_enabled(v) && !vmx_unrestricted_guest(v) ) + v->arch.hvm.hw_cr[3] = + v->domain->arch.hvm.params[HVM_PARAM_IDENT_PT]; + vmx_load_pdptrs(v); + } -static void __restore_debug_registers(struct vcpu *v) -{ - if ( v->arch.hvm.flag_dr_dirty ) - return; + __vmwrite(GUEST_CR3, v->arch.hvm.hw_cr[3]); - v->arch.hvm.flag_dr_dirty = 1; + if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) ) + hvm_asid_flush_vcpu(v); + break; - write_debugreg(0, v->arch.dr[0]); - write_debugreg(1, v->arch.dr[1]); - write_debugreg(2, v->arch.dr[2]); - write_debugreg(3, v->arch.dr[3]); - write_debugreg(6, v->arch.dr6); - /* DR7 is loaded from the VMCS. */ -} + default: + BUG(); + } -/* - * DR7 is saved and restored on every vmexit. Other debug registers only - * need to be restored if their value is going to affect execution -- i.e., - * if one of the breakpoints is enabled. So mask out all bits that don't - * enable some breakpoint functionality. - */ -static void vmx_restore_dr(struct vcpu *v) -{ - /* NB. __vmread() is not usable here, so we cannot read from the VMCS. */ - if ( unlikely(v->arch.dr7 & DR7_ACTIVE_MASK) ) - __restore_debug_registers(v); + vmx_vmcs_exit(v); } -static void vmx_vmcs_save(struct vcpu *v, struct hvm_hw_cpu *c) +static void cf_check vmx_update_guest_efer(struct vcpu *v) { - unsigned long ev; - - vmx_vmcs_enter(v); + unsigned long entry_ctls, guest_efer = v->arch.hvm.guest_efer, + xen_efer = read_efer(); - __vmread(GUEST_SYSENTER_CS, &c->sysenter_cs); - __vmread(GUEST_SYSENTER_ESP, &c->sysenter_esp); - __vmread(GUEST_SYSENTER_EIP, &c->sysenter_eip); + if ( paging_mode_shadow(v->domain) ) + { + /* + * When using shadow pagetables, EFER.NX is a Xen-owned bit and is not + * under guest control. + */ + guest_efer &= ~EFER_NXE; + guest_efer |= xen_efer & EFER_NXE; + } - __vmread(VM_ENTRY_INTR_INFO, &ev); - if ( (ev & INTR_INFO_VALID_MASK) && - hvm_event_needs_reinjection(MASK_EXTR(ev, INTR_INFO_INTR_TYPE_MASK), - ev & INTR_INFO_VECTOR_MASK) ) + if ( !vmx_unrestricted_guest(v) ) { - c->pending_event = ev; - __vmread(VM_ENTRY_EXCEPTION_ERROR_CODE, &ev); - c->error_code = ev; + /* + * When Unrestricted Guest is not enabled in the VMCS, hardware does + * not tolerate the LME and LMA settings being different. As writes + * to CR0 are intercepted, it is safe to leave LME clear at this + * point, and fix up both LME and LMA when CR0.PG is set. + * + * Furthermore, when using shadow pagetables (subsumed by the + * Unrestricted Guest check), CR0.PG is a Xen-owned bit, and remains + * set even when the guest has logically disabled paging. LMA was + * calculated using the guest CR0.PG setting, but LME needs clearing + * to avoid interacting with Xen's CR0.PG setting. + */ + if ( !(guest_efer & EFER_LMA) ) + guest_efer &= ~EFER_LME; } - vmx_vmcs_exit(v); -} + vmx_vmcs_enter(v); -static int vmx_restore_cr0_cr3( - struct vcpu *v, unsigned long cr0, unsigned long cr3) -{ - struct page_info *page = NULL; + /* + * The intended guest running mode is derived from VM_ENTRY_IA32E_MODE, + * which (architecturally) is the guest's LMA setting. + */ + __vmread(VM_ENTRY_CONTROLS, &entry_ctls); - if ( paging_mode_shadow(v->domain) ) + entry_ctls &= ~VM_ENTRY_IA32E_MODE; + if ( guest_efer & EFER_LMA ) + entry_ctls |= VM_ENTRY_IA32E_MODE; + + __vmwrite(VM_ENTRY_CONTROLS, entry_ctls); + + /* We expect to use EFER loading in the common case, but... */ + if ( likely(cpu_has_vmx_efer) ) + __vmwrite(GUEST_EFER, guest_efer); + + /* ... on Gen1 VT-x hardware, we have to use MSR load/save lists instead. */ + else { - if ( cr0 & X86_CR0_PG ) + /* + * When the guests choice of EFER matches Xen's, remove the load/save + * list entries. It is unnecessary overhead, especially as this is + * expected to be the common case for 64bit guests. + */ + if ( guest_efer == xen_efer ) { - page = get_page_from_gfn(v->domain, cr3 >> PAGE_SHIFT, - NULL, P2M_ALLOC); - if ( !page ) - { - gdprintk(XENLOG_ERR, "Invalid CR3 value=%#lx\n", cr3); - return -EINVAL; - } + vmx_del_msr(v, MSR_EFER, VMX_MSR_HOST); + vmx_del_msr(v, MSR_EFER, VMX_MSR_GUEST_LOADONLY); + } + else + { + vmx_add_msr(v, MSR_EFER, xen_efer, VMX_MSR_HOST); + vmx_add_msr(v, MSR_EFER, guest_efer, VMX_MSR_GUEST_LOADONLY); } + } - if ( hvm_paging_enabled(v) ) - put_page(pagetable_get_page(v->arch.guest_table)); + vmx_vmcs_exit(v); - v->arch.guest_table = - page ? pagetable_from_page(page) : pagetable_null(); - } + /* + * If the guests virtualised view of MSR_EFER matches the value loaded + * into hardware, clear the read intercept to avoid unnecessary VMExits. + */ + if ( guest_efer == v->arch.hvm.guest_efer ) + vmx_clear_msr_intercept(v, MSR_EFER, VMX_MSR_R); + else + vmx_set_msr_intercept(v, MSR_EFER, VMX_MSR_R); +} - v->arch.hvm.guest_cr[0] = cr0 | X86_CR0_ET; - v->arch.hvm.guest_cr[3] = cr3; +static void cf_check vmx_wbinvd_intercept(void) +{ + if ( !cache_flush_permitted(current->domain) || iommu_snoop ) + return; - return 0; + if ( cpu_has_wbinvd_exiting ) + flush_all(FLUSH_CACHE); + else + wbinvd(); } -static int vmx_vmcs_restore(struct vcpu *v, struct hvm_hw_cpu *c) +static void cf_check vmx_fpu_dirty_intercept(void) { - int rc; + struct vcpu *curr = current; - if ( c->pending_valid ) + vmx_fpu_enter(curr); + + /* Disable TS in guest CR0 unless the guest wants the exception too. */ + if ( !(curr->arch.hvm.guest_cr[0] & X86_CR0_TS) ) { - if ( (c->pending_type == 1) || (c->pending_type > 6) || - (c->pending_reserved != 0) ) + curr->arch.hvm.hw_cr[0] &= ~X86_CR0_TS; + __vmwrite(GUEST_CR0, curr->arch.hvm.hw_cr[0]); + } +} + +static const struct lbr_info { + u32 base, count; +} p4_lbr[] = { + { MSR_P4_LER_FROM_LIP, 1 }, + { MSR_P4_LER_TO_LIP, 1 }, + { MSR_P4_LASTBRANCH_TOS, 1 }, + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, c2_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_C2_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_C2_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, nh_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_NHL_LBR_SELECT, 1 }, + { MSR_NHL_LASTBRANCH_TOS, 1 }, + { MSR_P4_LASTBRANCH_0_FROM_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { MSR_P4_LASTBRANCH_0_TO_LIP, NUM_MSR_P4_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, sk_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_NHL_LBR_SELECT, 1 }, + { MSR_NHL_LASTBRANCH_TOS, 1 }, + { MSR_SKL_LASTBRANCH_0_FROM_IP, NUM_MSR_SKL_LASTBRANCH }, + { MSR_SKL_LASTBRANCH_0_TO_IP, NUM_MSR_SKL_LASTBRANCH }, + { MSR_SKL_LASTBRANCH_0_INFO, NUM_MSR_SKL_LASTBRANCH }, + { 0, 0 } +}, at_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_C2_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, sm_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_SM_LBR_SELECT, 1 }, + { MSR_SM_LASTBRANCH_TOS, 1 }, + { MSR_C2_LASTBRANCH_0_FROM_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { MSR_C2_LASTBRANCH_0_TO_IP, NUM_MSR_ATOM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}, gm_lbr[] = { + { MSR_IA32_LASTINTFROMIP, 1 }, + { MSR_IA32_LASTINTTOIP, 1 }, + { MSR_SM_LBR_SELECT, 1 }, + { MSR_SM_LASTBRANCH_TOS, 1 }, + { MSR_GM_LASTBRANCH_0_FROM_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, + { MSR_GM_LASTBRANCH_0_TO_IP, NUM_MSR_GM_LASTBRANCH_FROM_TO }, + { 0, 0 } +}; +static const struct lbr_info *__ro_after_init model_specific_lbr; + +static const struct lbr_info *__init get_model_specific_lbr(void) +{ + switch ( boot_cpu_data.x86 ) + { + case 6: + switch ( boot_cpu_data.x86_model ) { - dprintk(XENLOG_ERR, "%pv: Invalid pending event %#"PRIx32"\n", - v, c->pending_event); - return -EINVAL; + /* Core2 Duo */ + case 0x0f: + /* Enhanced Core */ + case 0x17: + /* Xeon 7400 */ + case 0x1d: + return c2_lbr; + /* Nehalem */ + case 0x1a: case 0x1e: case 0x1f: case 0x2e: + /* Westmere */ + case 0x25: case 0x2c: case 0x2f: + /* Sandy Bridge */ + case 0x2a: case 0x2d: + /* Ivy Bridge */ + case 0x3a: case 0x3e: + /* Haswell */ + case 0x3c: case 0x3f: case 0x45: case 0x46: + /* Broadwell */ + case 0x3d: case 0x47: case 0x4f: case 0x56: + return nh_lbr; + /* Skylake */ + case 0x4e: case 0x5e: + /* Xeon Scalable */ + case 0x55: + /* Cannon Lake */ + case 0x66: + /* Goldmont Plus */ + case 0x7a: + /* Ice Lake */ + case 0x6a: case 0x6c: case 0x7d: case 0x7e: + /* Tiger Lake */ + case 0x8c: case 0x8d: + /* Tremont */ + case 0x86: + /* Kaby Lake */ + case 0x8e: case 0x9e: + /* Comet Lake */ + case 0xa5: case 0xa6: + return sk_lbr; + /* Atom */ + case 0x1c: case 0x26: case 0x27: case 0x35: case 0x36: + return at_lbr; + /* Silvermont */ + case 0x37: case 0x4a: case 0x4d: case 0x5a: case 0x5d: + /* Xeon Phi Knights Landing */ + case 0x57: + /* Xeon Phi Knights Mill */ + case 0x85: + /* Airmont */ + case 0x4c: + return sm_lbr; + /* Goldmont */ + case 0x5c: case 0x5f: + return gm_lbr; } + break; - if ( c->pending_error_valid && - c->error_code != (uint16_t)c->error_code ) + case 15: + switch ( boot_cpu_data.x86_model ) { - dprintk(XENLOG_ERR, "%pv: Invalid error code %#"PRIx32"\n", - v, c->error_code); - return -EINVAL; + /* Pentium4/Xeon with em64t */ + case 3: case 4: case 6: + return p4_lbr; } + break; } - rc = vmx_restore_cr0_cr3(v, c->cr0, c->cr3); - if ( rc ) - return rc; - - vmx_vmcs_enter(v); - - v->arch.hvm.guest_cr[4] = c->cr4; - vmx_update_guest_cr(v, 0, 0); - vmx_update_guest_cr(v, 4, 0); - - v->arch.hvm.guest_efer = c->msr_efer; - vmx_update_guest_efer(v); - - __vmwrite(GUEST_SYSENTER_CS, c->sysenter_cs); - __vmwrite(GUEST_SYSENTER_ESP, c->sysenter_esp); - __vmwrite(GUEST_SYSENTER_EIP, c->sysenter_eip); - - __vmwrite(GUEST_DR7, c->dr7); - - if ( c->pending_valid && - hvm_event_needs_reinjection(c->pending_type, c->pending_vector) ) - { - gdprintk(XENLOG_INFO, "Re-injecting %#"PRIx32", %#"PRIx32"\n", - c->pending_event, c->error_code); - __vmwrite(VM_ENTRY_INTR_INFO, c->pending_event); - __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, c->error_code); - } - else - { - __vmwrite(VM_ENTRY_INTR_INFO, 0); - __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, 0); - } - vmx_vmcs_exit(v); - - paging_update_paging_modes(v); - - return 0; -} - -static void vmx_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) -{ - data->shadow_gs = v->arch.hvm.vmx.shadow_gs; - data->msr_lstar = v->arch.hvm.vmx.lstar; - data->msr_star = v->arch.hvm.vmx.star; - data->msr_cstar = v->arch.hvm.vmx.cstar; - data->msr_syscall_mask = v->arch.hvm.vmx.sfmask; + return NULL; } -static void vmx_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) +static int is_last_branch_msr(u32 ecx) { - v->arch.hvm.vmx.shadow_gs = data->shadow_gs; - v->arch.hvm.vmx.star = data->msr_star; - v->arch.hvm.vmx.lstar = data->msr_lstar; - v->arch.hvm.vmx.cstar = data->msr_cstar; - v->arch.hvm.vmx.sfmask = data->msr_syscall_mask; -} + const struct lbr_info *lbr = model_specific_lbr; + if ( lbr == NULL ) + return 0; -static void cf_check vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt) -{ - if ( v == current ) - vmx_save_guest_msrs(v); + for ( ; lbr->count; lbr++ ) + if ( (ecx >= lbr->base) && (ecx < (lbr->base + lbr->count)) ) + return 1; - vmx_save_cpu_state(v, ctxt); - vmx_vmcs_save(v, ctxt); + return 0; } -static int cf_check vmx_load_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt) +enum { - /* Not currently safe to use in current context. */ - ASSERT(v != current); - - vmx_load_cpu_state(v, ctxt); + LBR_FORMAT_32 = 0x0, /* 32-bit record format */ + LBR_FORMAT_LIP = 0x1, /* 64-bit LIP record format */ + LBR_FORMAT_EIP = 0x2, /* 64-bit EIP record format */ + LBR_FORMAT_EIP_FLAGS = 0x3, /* 64-bit EIP, Flags */ + LBR_FORMAT_EIP_FLAGS_TSX = 0x4, /* 64-bit EIP, Flags, TSX */ + LBR_FORMAT_EIP_FLAGS_TSX_INFO = 0x5, /* 64-bit EIP, Flags, TSX, LBR_INFO */ + LBR_FORMAT_EIP_FLAGS_CYCLES = 0x6, /* 64-bit EIP, Flags, Cycles */ + LBR_FORMAT_LIP_FLAGS_TSX_INFO = 0x7, /* 64-bit LIP, Flags, TSX, LBR_INFO */ +}; - if ( vmx_vmcs_restore(v, ctxt) ) - { - gdprintk(XENLOG_ERR, "vmx_vmcs restore failed!\n"); - domain_crash(v->domain); - return -EINVAL; - } +#define LBR_FROM_SIGNEXT_2MSB ((1ULL << 59) | (1ULL << 60)) - return 0; -} +#define LBR_MSRS_INSERTED (1u << 0) +#define LBR_FIXUP_TSX (1u << 1) +#define LBR_FIXUP_LER_TO (1u << 2) +#define LBR_FIXUP_MASK (LBR_FIXUP_TSX | LBR_FIXUP_LER_TO) -static void vmx_fpu_enter(struct vcpu *v) -{ - vcpu_restore_fpu_lazy(v); - v->arch.hvm.vmx.exception_bitmap &= ~(1u << TRAP_no_device); - vmx_update_exception_bitmap(v); - v->arch.hvm.vmx.host_cr0 &= ~X86_CR0_TS; - __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0); -} +static bool __read_mostly lbr_tsx_fixup_needed; +static bool __read_mostly ler_to_fixup_needed; -static void cf_check vmx_fpu_leave(struct vcpu *v) +static void __init lbr_tsx_fixup_check(void) { - ASSERT(!v->fpu_dirtied); - ASSERT(read_cr0() & X86_CR0_TS); - - if ( !(v->arch.hvm.vmx.host_cr0 & X86_CR0_TS) ) - { - v->arch.hvm.vmx.host_cr0 |= X86_CR0_TS; - __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0); - } + uint64_t caps; + uint32_t lbr_format; /* - * If the guest does not have TS enabled then we must cause and handle an - * exception on first use of the FPU. If the guest *does* have TS enabled - * then this is not necessary: no FPU activity can occur until the guest - * clears CR0.TS, and we will initialise the FPU when that happens. + * Haswell erratum HSM182 et al, Broadwell erratum BDM127 et al: + * + * On processors that do not support Intel Transactional Synchronization + * Extensions (Intel TSX) (CPUID.07H.EBX bits 4 and 11 are both zero), + * writes to MSR_LASTBRANCH_x_FROM_IP (MSR 680H to 68FH) may #GP unless + * bits[62:61] are equal to bit[47]. + * + * Software should sign extend the MSRs. + * + * Experimentally, MSR_LER_FROM_LIP (1DDH) is similarly impacted, so is + * fixed up as well. */ - if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) ) + if ( cpu_has_hle || cpu_has_rtm || + boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || + boot_cpu_data.x86 != 6 ) + return; + + switch ( boot_cpu_data.x86_model ) { - v->arch.hvm.hw_cr[0] |= X86_CR0_TS; - __vmwrite(GUEST_CR0, v->arch.hvm.hw_cr[0]); - v->arch.hvm.vmx.exception_bitmap |= (1u << TRAP_no_device); - vmx_update_exception_bitmap(v); + case 0x3c: /* HSM182, HSD172 - 4th gen Core */ + case 0x3f: /* HSE117 - Xeon E5 v3 */ + case 0x45: /* HSM182 - 4th gen Core */ + case 0x46: /* HSM182, HSD172 - 4th gen Core (GT3) */ + case 0x3d: /* BDM127 - 5th gen Core */ + case 0x47: /* BDD117 - 5th gen Core (GT3) + BDW117 - Xeon E3-1200 v4 */ + case 0x4f: /* BDF85 - Xeon E5-2600 v4 + BDH75 - Core-i7 for LGA2011-v3 Socket + BDX88 - Xeon E7-x800 v4 */ + case 0x56: /* BDE105 - Xeon D-1500 */ + break; + default: + return; } -} -static void cf_check vmx_ctxt_switch_from(struct vcpu *v) -{ /* - * Return early if trying to do a context switch without VMX enabled, - * this can happen when the hypervisor shuts down with HVM guests - * still running. + * Fixup is needed only when TSX support is disabled and the address + * format of LBR includes TSX bits 61:62 */ - if ( unlikely(!this_cpu(vmxon)) ) + if ( !cpu_has_pdcm ) return; - if ( !v->is_running ) - { - /* - * When this vCPU isn't marked as running anymore, a remote pCPU's - * attempt to pause us (from vmx_vmcs_enter()) won't have a reason - * to spin in vcpu_sleep_sync(), and hence that pCPU might have taken - * away the VMCS from us. As we're running with interrupts disabled, - * we also can't call vmx_vmcs_enter(). - */ - vmx_vmcs_reload(v); - } - - if ( !v->arch.fully_eager_fpu ) - vmx_fpu_leave(v); - vmx_save_guest_msrs(v); - vmx_restore_host_msrs(); - vmx_save_dr(v); - - if ( v->domain->arch.hvm.pi_ops.flags & PI_CSW_FROM ) - vmx_pi_switch_from(v); -} - -static void cf_check vmx_ctxt_switch_to(struct vcpu *v) -{ - vmx_restore_guest_msrs(v); - vmx_restore_dr(v); + rdmsrl(MSR_IA32_PERF_CAPABILITIES, caps); + lbr_format = caps & MSR_IA32_PERF_CAP_LBR_FORMAT; - if ( v->domain->arch.hvm.pi_ops.flags & PI_CSW_TO ) - vmx_pi_switch_to(v); + if ( lbr_format == LBR_FORMAT_EIP_FLAGS_TSX ) + lbr_tsx_fixup_needed = true; } - -unsigned int vmx_get_cpl(void) +static void __init ler_to_fixup_check(void) { - unsigned long attr; - - __vmread(GUEST_SS_AR_BYTES, &attr); + /* + * Broadwell erratum BDF93 et al: + * + * Reads from MSR_LER_TO_LIP (MSR 1DEH) may return values for bits[63:61] + * that are not equal to bit[47]. Attempting to context switch this value + * may cause a #GP. Software should sign extend the MSR. + */ + if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || + boot_cpu_data.x86 != 6 ) + return; - return (attr >> 5) & 3; + switch ( boot_cpu_data.x86_model ) + { + case 0x3d: /* BDM131 - 5th gen Core */ + case 0x47: /* BDD??? - 5th gen Core (H-Processor line) + BDW120 - Xeon E3-1200 v4 */ + case 0x4f: /* BDF93 - Xeon E5-2600 v4 + BDH80 - Core-i7 for LGA2011-v3 Socket + BDX93 - Xeon E7-x800 v4 */ + case 0x56: /* BDE??? - Xeon D-1500 */ + ler_to_fixup_needed = true; + break; + } } -static unsigned int cf_check _vmx_get_cpl(struct vcpu *v) +static int cf_check vmx_msr_read_intercept( + unsigned int msr, uint64_t *msr_content) { - unsigned int cpl; + struct vcpu *curr = current; + uint64_t tmp; - vmx_vmcs_enter(v); - cpl = vmx_get_cpl(); - vmx_vmcs_exit(v); + HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); - return cpl; -} + switch ( msr ) + { + case MSR_IA32_SYSENTER_CS: + __vmread(GUEST_SYSENTER_CS, msr_content); + break; + case MSR_IA32_SYSENTER_ESP: + __vmread(GUEST_SYSENTER_ESP, msr_content); + break; + case MSR_IA32_SYSENTER_EIP: + __vmread(GUEST_SYSENTER_EIP, msr_content); + break; -/* - * SDM Vol 3: VM Entries > Checks on Guest Segment Registers: - * - * We can only enter virtual 8086 mode if all of CS, SS, DS, ES, FS and GS are - * 16bit ring-3 data segments. On hardware lacking the unrestricted_guest - * feature, Xen fakes up real mode using vm86 mode. The guest thinks it's got - * ring-0 segments, so we need to fudge things. We store the ring-3 version - * in the VMCS to avoid lots of shuffling on vmenter and vmexit, and translate - * in these accessors. - */ -#define rm_cs_attr 0x9b -#define rm_ds_attr 0x93 -#define vm86_ds_attr 0xf3 -#define vm86_tr_attr 0x8b + case MSR_FS_BASE: + __vmread(GUEST_FS_BASE, msr_content); + break; -static void cf_check vmx_get_segment_register( - struct vcpu *v, enum x86_segment seg, struct segment_register *reg) -{ - unsigned long attr = 0, sel = 0, limit; - unsigned int tmp_seg; + case MSR_GS_BASE: + __vmread(GUEST_GS_BASE, msr_content); + break; - /* - * We may get here in the context of dump_execstate(), which may have - * interrupted context switching between setting "current" and - * vmx_do_resume() reaching the end of vmx_load_vmcs(). That would make - * all the VMREADs below fail if we don't bail right away. - */ - if ( unlikely(!vmx_vmcs_try_enter(v)) ) - { - static bool_t warned; + case MSR_SHADOW_GS_BASE: + *msr_content = read_gs_shadow(); + break; - if ( !warned ) - { - warned = 1; - printk(XENLOG_WARNING "Segment register inaccessible for %pv\n" - "(If you see this outside of debugging activity," - " please report to xen-devel@lists.xenproject.org)\n", - v); - } - memset(reg, 0, sizeof(*reg)); - return; - } + case MSR_STAR: + *msr_content = curr->arch.hvm.vmx.star; + break; - /* - * Xen's x86_seg_* enumeration *almost* matches the VMCS encoding order. - * - * tr and ldtr are reversed, and other areas of code rely on this, so we - * can't just re-enumerate. - */ - BUILD_BUG_ON(x86_seg_tr != 6); - BUILD_BUG_ON(x86_seg_ldtr != 7); - BUILD_BUG_ON(x86_seg_gdtr != 8); - BUILD_BUG_ON(x86_seg_idtr != 9); - switch ( tmp_seg = seg ) - { - case x86_seg_tr: - case x86_seg_ldtr: - tmp_seg ^= 1; /* Flip tr and ldtr so GUEST_SEG_*() works. */ - fallthrough; + case MSR_LSTAR: + *msr_content = curr->arch.hvm.vmx.lstar; + break; - case x86_seg_es ... x86_seg_gs: - __vmread(GUEST_SEG_SELECTOR(tmp_seg), &sel); - __vmread(GUEST_SEG_AR_BYTES(tmp_seg), &attr); - fallthrough; + case MSR_CSTAR: + *msr_content = curr->arch.hvm.vmx.cstar; + break; - case x86_seg_gdtr: - case x86_seg_idtr: - __vmread(GUEST_SEG_LIMIT(tmp_seg), &limit); - __vmread(GUEST_SEG_BASE(tmp_seg), ®->base); + case MSR_SYSCALL_MASK: + *msr_content = curr->arch.hvm.vmx.sfmask; break; - default: - BUG(); - return; - } + case MSR_IA32_DEBUGCTLMSR: + __vmread(GUEST_IA32_DEBUGCTL, msr_content); + break; - vmx_vmcs_exit(v); + case MSR_IA32_VMX_BASIC...MSR_IA32_VMX_VMFUNC: + if ( !nvmx_msr_read_intercept(msr, msr_content) ) + goto gp_fault; + break; + case MSR_IA32_MISC_ENABLE: + rdmsrl(MSR_IA32_MISC_ENABLE, *msr_content); + /* Debug Trace Store is not supported. */ + *msr_content |= MSR_IA32_MISC_ENABLE_BTS_UNAVAIL | + MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL; + /* Perhaps vpmu will change some bits. */ + /* FALLTHROUGH */ + case MSR_P6_PERFCTR(0)...MSR_P6_PERFCTR(7): + case MSR_P6_EVNTSEL(0)...MSR_P6_EVNTSEL(3): + case MSR_CORE_PERF_FIXED_CTR0...MSR_CORE_PERF_FIXED_CTR2: + case MSR_CORE_PERF_FIXED_CTR_CTRL...MSR_CORE_PERF_GLOBAL_OVF_CTRL: + case MSR_IA32_PEBS_ENABLE: + case MSR_IA32_DS_AREA: + if ( vpmu_do_rdmsr(msr, msr_content) ) + goto gp_fault; + break; - reg->sel = sel; - reg->limit = limit; + default: + if ( passive_domain_do_rdmsr(msr, msr_content) ) + goto done; - /* - * Fold VT-x representation into Xen's representation. The Present bit is - * unconditionally set to the inverse of unusable. - */ - reg->attr = - (!(attr & (1u << 16)) << 7) | (attr & 0x7f) | ((attr >> 4) & 0xf00); + if ( vmx_read_guest_msr(curr, msr, msr_content) == 0 ) + break; - /* Adjust for virtual 8086 mode */ - if ( v->arch.hvm.vmx.vmx_realmode && seg <= x86_seg_tr - && !(v->arch.hvm.vmx.vm86_segment_mask & (1u << seg)) ) - { - struct segment_register *sreg = &v->arch.hvm.vmx.vm86_saved_seg[seg]; - if ( seg == x86_seg_tr ) - *reg = *sreg; - else if ( reg->base != sreg->base || seg == x86_seg_ss ) + if ( is_last_branch_msr(msr) ) { - /* If the guest's reloaded the segment, remember the new version. - * We can't tell if the guest reloaded the segment with another - * one that has the same base. By default we assume it hasn't, - * since we don't want to lose big-real-mode segment attributes, - * but for SS we assume it has: the Ubuntu graphical bootloader - * does this and gets badly confused if we leave the old SS in - * place. */ - reg->attr = (seg == x86_seg_cs ? rm_cs_attr : rm_ds_attr); - *sreg = *reg; + *msr_content = 0; + break; } - else + + if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) { - /* Always give realmode guests a selector that matches the base - * but keep the attr and limit from before */ - *reg = *sreg; - reg->sel = reg->base >> 4; + *msr_content = 0; + break; } + + gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); + goto gp_fault; } + +done: + HVM_DBG_LOG(DBG_LEVEL_MSR, "returns: ecx=%#x, msr_value=%#"PRIx64, + msr, *msr_content); + return X86EMUL_OKAY; + +gp_fault: + return X86EMUL_EXCEPTION; } -static void cf_check vmx_set_segment_register( - struct vcpu *v, enum x86_segment seg, struct segment_register *reg) +static int cf_check vmx_msr_write_intercept( + unsigned int msr, uint64_t msr_content) { - uint32_t attr, sel, limit; - uint64_t base; + struct vcpu *v = current; + const struct cpuid_policy *cp = v->domain->arch.cpuid; - sel = reg->sel; - attr = reg->attr; - limit = reg->limit; - base = reg->base; + HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x, msr_value=%#"PRIx64, msr, msr_content); - /* Adjust CS/SS/DS/ES/FS/GS/TR for virtual 8086 mode */ - if ( v->arch.hvm.vmx.vmx_realmode && seg <= x86_seg_tr ) + switch ( msr ) { - /* Remember the proper contents */ - v->arch.hvm.vmx.vm86_saved_seg[seg] = *reg; - - if ( seg == x86_seg_tr ) - { - const struct domain *d = v->domain; - uint64_t val = d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED]; + uint64_t rsvd, tmp; - if ( val ) - { - sel = 0; - attr = vm86_tr_attr; - limit = ((val & ~VM86_TSS_UPDATED) >> 32) - 1; - base = (uint32_t)val; - if ( val & VM86_TSS_UPDATED ) - { - hvm_prepare_vm86_tss(v, base, limit); - cmpxchg(&d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED], - val, val & ~VM86_TSS_UPDATED); - } - v->arch.hvm.vmx.vm86_segment_mask &= ~(1u << seg); - } - else - v->arch.hvm.vmx.vm86_segment_mask |= (1u << seg); - } - else - { - /* Try to fake it out as a 16bit data segment. This could - * cause confusion for the guest if it reads the selector, - * but otherwise we have to emulate if *any* segment hasn't - * been reloaded. */ - if ( base < 0x100000 && !(base & 0xf) && limit >= 0xffff && reg->p ) - { - sel = base >> 4; - attr = vm86_ds_attr; - limit = 0xffff; - v->arch.hvm.vmx.vm86_segment_mask &= ~(1u << seg); - } - else - v->arch.hvm.vmx.vm86_segment_mask |= (1u << seg); - } - } + case MSR_IA32_SYSENTER_CS: + __vmwrite(GUEST_SYSENTER_CS, msr_content); + break; + case MSR_IA32_SYSENTER_ESP: + if ( !is_canonical_address(msr_content) ) + goto gp_fault; + __vmwrite(GUEST_SYSENTER_ESP, msr_content); + break; + case MSR_IA32_SYSENTER_EIP: + if ( !is_canonical_address(msr_content) ) + goto gp_fault; + __vmwrite(GUEST_SYSENTER_EIP, msr_content); + break; - /* - * Unfold Xen representation into VT-x representation. The unusable bit - * is unconditionally set to the inverse of present. - */ - attr = (!(attr & (1u << 7)) << 16) | ((attr & 0xf00) << 4) | (attr & 0xff); + case MSR_FS_BASE: + case MSR_GS_BASE: + case MSR_SHADOW_GS_BASE: + if ( !is_canonical_address(msr_content) ) + goto gp_fault; - vmx_vmcs_enter(v); + if ( msr == MSR_FS_BASE ) + __vmwrite(GUEST_FS_BASE, msr_content); + else if ( msr == MSR_GS_BASE ) + __vmwrite(GUEST_GS_BASE, msr_content); + else + write_gs_shadow(msr_content); - switch ( seg ) - { - case x86_seg_tr: - case x86_seg_ldtr: - seg ^= 1; /* Flip tr and ldtr so GUEST_SEG_*() works. */ - fallthrough; + break; - case x86_seg_es ... x86_seg_gs: - __vmwrite(GUEST_SEG_SELECTOR(seg), sel); - __vmwrite(GUEST_SEG_AR_BYTES(seg), attr); - fallthrough; + case MSR_STAR: + v->arch.hvm.vmx.star = msr_content; + wrmsrl(MSR_STAR, msr_content); + break; - case x86_seg_gdtr: - case x86_seg_idtr: - __vmwrite(GUEST_SEG_LIMIT(seg), limit); - __vmwrite(GUEST_SEG_BASE(seg), base); + case MSR_LSTAR: + if ( !is_canonical_address(msr_content) ) + goto gp_fault; + v->arch.hvm.vmx.lstar = msr_content; + wrmsrl(MSR_LSTAR, msr_content); break; - default: - BUG(); - } + case MSR_CSTAR: + if ( !is_canonical_address(msr_content) ) + goto gp_fault; + v->arch.hvm.vmx.cstar = msr_content; + break; - vmx_vmcs_exit(v); -} + case MSR_SYSCALL_MASK: + v->arch.hvm.vmx.sfmask = msr_content; + wrmsrl(MSR_SYSCALL_MASK, msr_content); + break; -static int cf_check vmx_set_guest_pat(struct vcpu *v, u64 gpat) -{ - if ( !paging_mode_hap(v->domain) || - unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) ) - return 0; + case MSR_IA32_DEBUGCTLMSR: + rsvd = ~(IA32_DEBUGCTLMSR_LBR | IA32_DEBUGCTLMSR_BTF); - vmx_vmcs_enter(v); - __vmwrite(GUEST_PAT, gpat); - vmx_vmcs_exit(v); - return 1; -} + /* TODO: Wire vPMU settings properly through the CPUID policy */ + if ( vpmu_is_set(vcpu_vpmu(v), VPMU_CPU_HAS_BTS) ) + { + rsvd &= ~(IA32_DEBUGCTLMSR_TR | IA32_DEBUGCTLMSR_BTS | + IA32_DEBUGCTLMSR_BTINT); -static int cf_check vmx_get_guest_pat(struct vcpu *v, u64 *gpat) -{ - if ( !paging_mode_hap(v->domain) || - unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) ) - return 0; + if ( cpu_has(¤t_cpu_data, X86_FEATURE_DSCPL) ) + rsvd &= ~(IA32_DEBUGCTLMSR_BTS_OFF_OS | + IA32_DEBUGCTLMSR_BTS_OFF_USR); + } - vmx_vmcs_enter(v); - __vmread(GUEST_PAT, gpat); - vmx_vmcs_exit(v); - return 1; -} + if ( cp->feat.rtm ) + rsvd &= ~IA32_DEBUGCTLMSR_RTM; + + if ( msr_content & rsvd ) + goto gp_fault; -static void cf_check vmx_handle_cd(struct vcpu *v, unsigned long value) -{ - if ( !paging_mode_hap(v->domain) ) - { /* - * For shadow, 'load IA32_PAT' VM-entry control is 0, so it cannot - * set guest memory type as UC via IA32_PAT. Xen drop all shadows - * so that any new ones would be created on demand. + * The Arch LBR spec (new in Ice Lake) states that CPUs with no + * model-specific LBRs implement MSR_DBG_CTL.LBR by discarding writes + * and always returning 0. + * + * Use this property in all cases where we don't know any + * model-specific LBR information, as it matches real hardware + * behaviour on post-Ice Lake systems. */ - hvm_shadow_handle_cd(v, value); - } - else - { - u64 *pat = &v->arch.hvm.pat_cr; + if ( !model_specific_lbr ) + msr_content &= ~IA32_DEBUGCTLMSR_LBR; - if ( value & X86_CR0_CD ) + /* + * When a guest first enables LBR, arrange to save and restore the LBR + * MSRs and allow the guest direct access. + * + * Hitting -ENOSPC with the guest load/save list is definitely a + * hypervisor bug, whereas -ENOMEM for allocating the load/save list + * is simply unlucky (and shouldn't occur with sensible management by + * the toolstack). + * + * Either way, there is nothing we can do right now to recover, and + * the guest won't execute correctly either. Simply crash the domain + * to make the failure obvious. + */ + if ( !(v->arch.hvm.vmx.lbr_flags & LBR_MSRS_INSERTED) && + (msr_content & IA32_DEBUGCTLMSR_LBR) ) { - /* - * For EPT, set guest IA32_PAT fields as UC so that guest - * memory type are all UC. - */ - u64 uc_pat = - ((uint64_t)X86_MT_UC) | /* PAT0 */ - ((uint64_t)X86_MT_UC << 8) | /* PAT1 */ - ((uint64_t)X86_MT_UC << 16) | /* PAT2 */ - ((uint64_t)X86_MT_UC << 24) | /* PAT3 */ - ((uint64_t)X86_MT_UC << 32) | /* PAT4 */ - ((uint64_t)X86_MT_UC << 40) | /* PAT5 */ - ((uint64_t)X86_MT_UC << 48) | /* PAT6 */ - ((uint64_t)X86_MT_UC << 56); /* PAT7 */ + const struct lbr_info *lbr = model_specific_lbr; - vmx_get_guest_pat(v, pat); - vmx_set_guest_pat(v, uc_pat); - vmx_set_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + for ( ; lbr->count; lbr++ ) + { + unsigned int i; - wbinvd(); /* flush possibly polluted cache */ - hvm_asid_flush_vcpu(v); /* invalidate memory type cached in TLB */ - v->arch.hvm.cache_mode = NO_FILL_CACHE_MODE; - } - else - { - v->arch.hvm.cache_mode = NORMAL_CACHE_MODE; - vmx_set_guest_pat(v, *pat); - if ( !is_iommu_enabled(v->domain) || iommu_snoop ) - vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); - hvm_asid_flush_vcpu(v); /* no need to flush cache */ + for ( i = 0; i < lbr->count; i++ ) + { + int rc = vmx_add_guest_msr(v, lbr->base + i, 0); + + if ( unlikely(rc) ) + { + gprintk(XENLOG_ERR, + "Guest load/save list error %d\n", rc); + domain_crash(v->domain); + return X86EMUL_OKAY; + } + + vmx_clear_msr_intercept(v, lbr->base + i, VMX_MSR_RW); + } + } + + v->arch.hvm.vmx.lbr_flags |= LBR_MSRS_INSERTED; + if ( lbr_tsx_fixup_needed ) + v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_TSX; + if ( ler_to_fixup_needed ) + v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_LER_TO; } - } -} -static void cf_check vmx_setup_tsc_scaling(struct vcpu *v) -{ - if ( v->domain->arch.vtsc ) - return; + __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); + break; - vmx_vmcs_enter(v); - __vmwrite(TSC_MULTIPLIER, hvm_tsc_scaling_ratio(v->domain)); - vmx_vmcs_exit(v); -} + case MSR_IA32_MISC_ENABLE: + /* + * Silently drop writes that don't change the reported value: At least + * some Windows guests will expect to be able to write to MISC_ENABLE + * with the same value that's been read from it. + */ + if ( vmx_msr_read_intercept(msr, &tmp) != X86EMUL_OKAY || + tmp != msr_content ) + goto gp_fault; + break; -static void cf_check vmx_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc) -{ - vmx_vmcs_enter(v); + case MSR_P6_PERFCTR(0)...MSR_P6_PERFCTR(7): + case MSR_P6_EVNTSEL(0)...MSR_P6_EVNTSEL(7): + case MSR_CORE_PERF_FIXED_CTR0...MSR_CORE_PERF_FIXED_CTR2: + case MSR_CORE_PERF_FIXED_CTR_CTRL...MSR_CORE_PERF_GLOBAL_OVF_CTRL: + case MSR_IA32_PEBS_ENABLE: + case MSR_IA32_DS_AREA: + if ( vpmu_do_wrmsr(msr, msr_content) ) + goto gp_fault; + break; - if ( nestedhvm_vcpu_in_guestmode(v) ) - offset += nvmx_get_tsc_offset(v); + default: + if ( passive_domain_do_wrmsr(msr, msr_content) ) + return X86EMUL_OKAY; - __vmwrite(TSC_OFFSET, offset); - vmx_vmcs_exit(v); + if ( vmx_write_guest_msr(v, msr, msr_content) == 0 || + is_last_branch_msr(msr) ) + break; + + if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) + break; + + gdprintk(XENLOG_WARNING, + "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", + msr, msr_content); + goto gp_fault; + } + + return X86EMUL_OKAY; + +gp_fault: + return X86EMUL_EXCEPTION; } -static void cf_check vmx_set_rdtsc_exiting(struct vcpu *v, bool enable) +static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear) { - vmx_vmcs_enter(v); - v->arch.hvm.vmx.exec_control &= ~CPU_BASED_RDTSC_EXITING; - if ( enable ) - v->arch.hvm.vmx.exec_control |= CPU_BASED_RDTSC_EXITING; - vmx_update_cpu_exec_control(v); - vmx_vmcs_exit(v); + if ( cpu_has_vmx_vpid ) + vpid_sync_vcpu_gva(v, linear); } -static void cf_check vmx_set_descriptor_access_exiting( - struct vcpu *v, bool enable) -{ - if ( enable ) - v->arch.hvm.vmx.secondary_exec_control |= - SECONDARY_EXEC_DESCRIPTOR_TABLE_EXITING; - else - v->arch.hvm.vmx.secondary_exec_control &= - ~SECONDARY_EXEC_DESCRIPTOR_TABLE_EXITING; +uint8_t __read_mostly posted_intr_vector; +static uint8_t __read_mostly pi_wakeup_vector; - vmx_vmcs_enter(v); - vmx_update_secondary_exec_control(v); - vmx_vmcs_exit(v); +void vmx_pi_per_cpu_init(unsigned int cpu) +{ + INIT_LIST_HEAD(&per_cpu(vmx_pi_blocking, cpu).list); + spin_lock_init(&per_cpu(vmx_pi_blocking, cpu).lock); } -static void cf_check vmx_init_hypercall_page(void *p) +static void cf_check vmx_vcpu_block(struct vcpu *v) { - unsigned int i; + unsigned long flags; + unsigned int dest; + spinlock_t *old_lock; + spinlock_t *pi_blocking_list_lock = + &per_cpu(vmx_pi_blocking, v->processor).lock; + struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; - for ( i = 0; i < (PAGE_SIZE / 32); i++, p += 32 ) - { - if ( unlikely(i == __HYPERVISOR_iret) ) - { - /* HYPERVISOR_iret isn't supported */ - *(u16 *)p = 0x0b0f; /* ud2 */ + spin_lock_irqsave(pi_blocking_list_lock, flags); + old_lock = cmpxchg(&v->arch.hvm.vmx.pi_blocking.lock, NULL, + pi_blocking_list_lock); - continue; - } + /* + * 'v->arch.hvm.vmx.pi_blocking.lock' should be NULL before + * being assigned to a new value, since the vCPU is currently + * running and it cannot be on any blocking list. + */ + ASSERT(old_lock == NULL); - *(u8 *)(p + 0) = 0xb8; /* mov imm32, %eax */ - *(u32 *)(p + 1) = i; - *(u8 *)(p + 5) = 0x0f; /* vmcall */ - *(u8 *)(p + 6) = 0x01; - *(u8 *)(p + 7) = 0xc1; - *(u8 *)(p + 8) = 0xc3; /* ret */ - } -} + list_add_tail(&v->arch.hvm.vmx.pi_blocking.list, + &per_cpu(vmx_pi_blocking, v->processor).list); + spin_unlock_irqrestore(pi_blocking_list_lock, flags); -static unsigned int cf_check vmx_get_interrupt_shadow(struct vcpu *v) -{ - unsigned long intr_shadow; + ASSERT(!pi_test_sn(pi_desc)); - __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); + dest = cpu_physical_id(v->processor); - return intr_shadow; -} + ASSERT(pi_desc->ndst == + (x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK))); -static void cf_check vmx_set_interrupt_shadow( - struct vcpu *v, unsigned int intr_shadow) -{ - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow); + write_atomic(&pi_desc->nv, pi_wakeup_vector); } -static void cf_check vmx_get_nonreg_state(struct vcpu *v, - struct hvm_vcpu_nonreg_state *nrs) +static void vmx_pi_unblock_vcpu(struct vcpu *v) { - vmx_vmcs_enter(v); + unsigned long flags; + spinlock_t *pi_blocking_list_lock; + struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; - __vmread(GUEST_ACTIVITY_STATE, &nrs->vmx.activity_state); - __vmread(GUEST_INTERRUPTIBILITY_INFO, &nrs->vmx.interruptibility_info); - __vmread(GUEST_PENDING_DBG_EXCEPTIONS, &nrs->vmx.pending_dbg); + /* + * Set 'NV' field back to posted_intr_vector, so the + * Posted-Interrupts can be delivered to the vCPU when + * it is running in non-root mode. + */ + write_atomic(&pi_desc->nv, posted_intr_vector); - if ( cpu_has_vmx_virtual_intr_delivery ) - __vmread(GUEST_INTR_STATUS, &nrs->vmx.interrupt_status); + pi_blocking_list_lock = v->arch.hvm.vmx.pi_blocking.lock; - vmx_vmcs_exit(v); -} + /* Prevent the compiler from eliminating the local variable.*/ + smp_rmb(); -static void cf_check vmx_set_nonreg_state(struct vcpu *v, - struct hvm_vcpu_nonreg_state *nrs) -{ - vmx_vmcs_enter(v); + /* The vCPU is not on any blocking list. */ + if ( pi_blocking_list_lock == NULL ) + return; - __vmwrite(GUEST_ACTIVITY_STATE, nrs->vmx.activity_state); - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, nrs->vmx.interruptibility_info); - __vmwrite(GUEST_PENDING_DBG_EXCEPTIONS, nrs->vmx.pending_dbg); + spin_lock_irqsave(pi_blocking_list_lock, flags); - if ( cpu_has_vmx_virtual_intr_delivery ) - __vmwrite(GUEST_INTR_STATUS, nrs->vmx.interrupt_status); + /* + * v->arch.hvm.vmx.pi_blocking.lock == NULL here means the vCPU + * was removed from the blocking list while we are acquiring the lock. + */ + if ( v->arch.hvm.vmx.pi_blocking.lock != NULL ) + { + ASSERT(v->arch.hvm.vmx.pi_blocking.lock == pi_blocking_list_lock); + list_del(&v->arch.hvm.vmx.pi_blocking.list); + v->arch.hvm.vmx.pi_blocking.lock = NULL; + } - vmx_vmcs_exit(v); + spin_unlock_irqrestore(pi_blocking_list_lock, flags); } -static void vmx_load_pdptrs(struct vcpu *v) +static void vmx_pi_do_resume(struct vcpu *v) { - uint32_t cr3 = v->arch.hvm.guest_cr[3]; - const uint64_t *guest_pdptes; - struct page_info *page; - p2m_type_t p2mt; + ASSERT(!test_bit(_VPF_blocked, &v->pause_flags)); - /* EPT needs to load PDPTRS into VMCS for PAE. */ - if ( !hvm_pae_enabled(v) || hvm_long_mode_active(v) ) - return; + vmx_pi_unblock_vcpu(v); +} - page = get_page_from_gfn(v->domain, cr3 >> PAGE_SHIFT, &p2mt, P2M_ALLOC); - if ( !page ) - { - /* Ideally you don't want to crash but rather go into a wait - * queue, but this is the wrong place. We're holding at least - * the paging lock */ - gdprintk(XENLOG_ERR, - "Bad cr3 on load pdptrs gfn %"PRIx32" type %d\n", - cr3 >> PAGE_SHIFT, (int) p2mt); - domain_crash(v->domain); - return; - } +void vmx_pi_desc_fixup(unsigned int cpu) +{ + unsigned int new_cpu, dest; + unsigned long flags; + struct vmx_vcpu *vmx, *tmp; + spinlock_t *new_lock, *old_lock = &per_cpu(vmx_pi_blocking, cpu).lock; + struct list_head *blocked_vcpus = &per_cpu(vmx_pi_blocking, cpu).list; - guest_pdptes = __map_domain_page(page) + (cr3 & ~(PAGE_MASK | 0x1f)); + if ( !iommu_intpost ) + return; /* - * We do not check the PDPTRs for validity. The CPU will do this during - * vm entry, and we can handle the failure there and crash the guest. - * The only thing we could do better here is #GP instead. + * We are in the context of CPU_DEAD or CPU_UP_CANCELED notification, + * and it is impossible for a second CPU go down in parallel. So we + * can safely acquire the old cpu's lock and then acquire the new_cpu's + * lock after that. */ + spin_lock_irqsave(old_lock, flags); - vmx_vmcs_enter(v); + list_for_each_entry_safe(vmx, tmp, blocked_vcpus, pi_blocking.list) + { + /* + * Suppress notification or we may miss an interrupt when the + * target cpu is dying. + */ + pi_set_sn(&vmx->pi_desc); - __vmwrite(GUEST_PDPTE(0), guest_pdptes[0]); - __vmwrite(GUEST_PDPTE(1), guest_pdptes[1]); - __vmwrite(GUEST_PDPTE(2), guest_pdptes[2]); - __vmwrite(GUEST_PDPTE(3), guest_pdptes[3]); + /* + * Check whether a notification is pending before doing the + * movement, if that is the case we need to wake up it directly + * other than moving it to the new cpu's list. + */ + if ( pi_test_on(&vmx->pi_desc) ) + { + list_del(&vmx->pi_blocking.list); + vmx->pi_blocking.lock = NULL; + vcpu_unblock(container_of(vmx, struct vcpu, arch.hvm.vmx)); + } + else + { + /* + * We need to find an online cpu as the NDST of the PI descriptor, it + * doesn't matter whether it is within the cpupool of the domain or + * not. As long as it is online, the vCPU will be woken up once the + * notification event arrives. + */ + new_cpu = cpumask_any(&cpu_online_map); + new_lock = &per_cpu(vmx_pi_blocking, new_cpu).lock; - vmx_vmcs_exit(v); + spin_lock(new_lock); - unmap_domain_page(guest_pdptes); - put_page(page); - return; -} + ASSERT(vmx->pi_blocking.lock == old_lock); -static void cf_check vmx_update_host_cr3(struct vcpu *v) -{ - vmx_vmcs_enter(v); - __vmwrite(HOST_CR3, v->arch.cr3); - vmx_vmcs_exit(v); -} + dest = cpu_physical_id(new_cpu); + write_atomic(&vmx->pi_desc.ndst, + x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK)); -void vmx_update_debug_state(struct vcpu *v) -{ - if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; - else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + list_move(&vmx->pi_blocking.list, + &per_cpu(vmx_pi_blocking, new_cpu).list); + vmx->pi_blocking.lock = new_lock; - vmx_vmcs_enter(v); - vmx_update_exception_bitmap(v); - vmx_vmcs_exit(v); + spin_unlock(new_lock); + } + + pi_clear_sn(&vmx->pi_desc); + } + + spin_unlock_irqrestore(old_lock, flags); } -static void cf_check vmx_update_guest_cr( - struct vcpu *v, unsigned int cr, unsigned int flags) +/* + * To handle posted interrupts correctly, we need to set the following + * state: + * + * * The PI notification vector (NV) + * * The PI notification destination processor (NDST) + * * The PI "suppress notification" bit (SN) + * * The vcpu pi "blocked" list + * + * VMX implements the runstate transitions as the following: + * + * A: ... -> running + * - SN = 0 + * - NDST = v->processor + * If a VM is currently running, we want the PI delivered to the guest vcpu + * on the proper pcpu. + * + * B: running -> ... + * - SN = 1 + * + * C: ... -> blocked + * - SN = 0 + * - NV = pi_wakeup_vector + * - Add vcpu to blocked list + * If the vm is blocked, we want the PI delivered to Xen so that it can + * wake it up. + * + * D: ... -> vmentry + * - SN = 0 + * - NV = posted_intr_vector + * - Take vcpu off blocked list + * + * If the VM is currently either preempted or offline (i.e., not running + * because of some reason other than blocking waiting for an interrupt), + * there's nothing Xen can do -- we want the interrupt pending bit set in + * the guest, but we don't want to bother Xen with an interrupt (SN clear). + * + * There's a brief window of time between vmx_intr_assist() and checking + * softirqs where if an interrupt comes in it may be lost; so we need Xen + * to get an interrupt and raise a softirq so that it will go through the + * vmx_intr_assist() path again (SN clear, NV = posted_interrupt). + */ + +/* This function is called when pcidevs_lock is held */ +void vmx_pi_hooks_assign(struct domain *d) { - vmx_vmcs_enter(v); + struct vcpu *v; - switch ( cr ) - { - case 0: - { - bool realmode; - unsigned long hw_cr0_mask = X86_CR0_NE; + if ( !iommu_intpost || !is_hvm_domain(d) ) + return; - if ( !vmx_unrestricted_guest(v) ) - hw_cr0_mask |= X86_CR0_PG | X86_CR0_PE; + ASSERT(!d->arch.hvm.pi_ops.vcpu_block); - if ( paging_mode_shadow(v->domain) ) - hw_cr0_mask |= X86_CR0_WP; + /* + * We carefully handle the timing here: + * - Install the context switch first + * - Then set the NDST field + * - Install the block and resume hooks in the end + * + * This can make sure the PI (especially the NDST feild) is + * in proper state when we call vmx_vcpu_block(). + */ + d->arch.hvm.pi_ops.flags = PI_CSW_FROM | PI_CSW_TO; - if ( paging_mode_hap(v->domain) ) - { - /* Manage GUEST_CR3 when CR0.PE=0. */ - uint32_t old_ctls = v->arch.hvm.vmx.exec_control; - uint32_t cr3_ctls = (CPU_BASED_CR3_LOAD_EXITING | - CPU_BASED_CR3_STORE_EXITING); + for_each_vcpu ( d, v ) + { + unsigned int dest = cpu_physical_id(v->processor); + struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; - v->arch.hvm.vmx.exec_control &= ~cr3_ctls; - if ( !hvm_paging_enabled(v) && !vmx_unrestricted_guest(v) ) - v->arch.hvm.vmx.exec_control |= cr3_ctls; + /* + * We don't need to update NDST if vmx_pi_switch_to() + * has already got called. + */ + (void)cmpxchg(&pi_desc->ndst, APIC_INVALID_DEST, + x2apic_enabled ? dest : MASK_INSR(dest, PI_xAPIC_NDST_MASK)); + } - /* Trap CR3 updates if CR3 memory events are enabled. */ - if ( v->domain->arch.monitor.write_ctrlreg_enabled & - monitor_ctrlreg_bitmask(VM_EVENT_X86_CR3) ) - v->arch.hvm.vmx.exec_control |= CPU_BASED_CR3_LOAD_EXITING; + d->arch.hvm.pi_ops.vcpu_block = vmx_vcpu_block; +} - if ( old_ctls != v->arch.hvm.vmx.exec_control ) - vmx_update_cpu_exec_control(v); - } +/* This function is called when pcidevs_lock is held */ +void vmx_pi_hooks_deassign(struct domain *d) +{ + struct vcpu *v; - if ( !nestedhvm_vcpu_in_guestmode(v) ) - __vmwrite(CR0_READ_SHADOW, v->arch.hvm.guest_cr[0]); - else - nvmx_set_cr_read_shadow(v, 0); + if ( !iommu_intpost || !is_hvm_domain(d) ) + return; - if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_TS) ) - { - if ( v != current ) - { - if ( !v->arch.fully_eager_fpu ) - hw_cr0_mask |= X86_CR0_TS; - } - else if ( v->arch.hvm.hw_cr[0] & X86_CR0_TS ) - vmx_fpu_enter(v); - } + ASSERT(d->arch.hvm.pi_ops.vcpu_block); - realmode = !(v->arch.hvm.guest_cr[0] & X86_CR0_PE); + /* + * Pausing the domain can make sure the vCPUs are not + * running and hence not calling the hooks simultaneously + * when deassigning the PI hooks and removing the vCPU + * from the blocking list. + */ + ASSERT(current->domain != d); + domain_pause(d); - if ( !vmx_unrestricted_guest(v) && - (realmode != v->arch.hvm.vmx.vmx_realmode) ) - { - enum x86_segment s; - struct segment_register reg[x86_seg_tr + 1]; + /* + * Note that we don't set 'd->arch.hvm.pi_ops.switch_to' to NULL + * here. If we deassign the hooks while the vCPU is runnable in the + * runqueue with 'SN' set, all the future notification event will be + * suppressed since vmx_deliver_posted_intr() also use 'SN' bit + * as the suppression flag. Preserving the 'switch_to' hook function can + * clear the 'SN' bit when the vCPU becomes running next time. After + * that, No matter which status(runnable, running or block) the vCPU is in, + * the 'SN' bit will keep clear for the 'switch_from' hook function that set + * the 'SN' bit has been removed. At that time, the 'switch_to' hook function + * is also useless. Considering the function doesn't do harm to the whole + * system, leave it here until we find a clean solution to deassign the + * 'switch_to' hook function. + */ + d->arch.hvm.pi_ops.vcpu_block = NULL; + d->arch.hvm.pi_ops.flags = PI_CSW_TO; - BUILD_BUG_ON(x86_seg_tr != x86_seg_gs + 1); + for_each_vcpu ( d, v ) + vmx_pi_unblock_vcpu(v); - /* Entering or leaving real mode: adjust the segment registers. - * Need to read them all either way, as realmode reads can update - * the saved values we'll use when returning to prot mode. */ - for ( s = 0; s < ARRAY_SIZE(reg); s++ ) - hvm_get_segment_register(v, s, ®[s]); - v->arch.hvm.vmx.vmx_realmode = realmode; + domain_unpause(d); +} - if ( realmode ) - { - for ( s = 0; s < ARRAY_SIZE(reg); s++ ) - hvm_set_segment_register(v, s, ®[s]); - } - else - { - for ( s = 0; s < ARRAY_SIZE(reg); s++ ) - if ( !(v->arch.hvm.vmx.vm86_segment_mask & (1<arch.hvm.vmx.vm86_saved_seg[s]); - } +/* + * This function is used to update the IRTE for posted-interrupt + * when guest changes MSI/MSI-X information. + */ +static int cf_check vmx_pi_update_irte(const struct vcpu *v, + const struct pirq *pirq, uint8_t gvec) +{ + const struct pi_desc *pi_desc = v ? &v->arch.hvm.vmx.pi_desc : NULL; + struct irq_desc *desc; + struct msi_desc *msi_desc; + int rc; - vmx_update_exception_bitmap(v); - } + desc = pirq_spin_lock_irq_desc(pirq, NULL); + if ( !desc ) + return -EINVAL; - v->arch.hvm.hw_cr[0] = - v->arch.hvm.guest_cr[0] | hw_cr0_mask; - __vmwrite(GUEST_CR0, v->arch.hvm.hw_cr[0]); + msi_desc = desc->msi_desc; + if ( !msi_desc ) + { + rc = -ENODEV; + goto unlock_out; } - /* Fallthrough: Changing CR0 can change some bits in real CR4. */ - case 4: - v->arch.hvm.hw_cr[4] = HVM_CR4_HOST_MASK; - if ( paging_mode_hap(v->domain) ) - v->arch.hvm.hw_cr[4] &= ~X86_CR4_PAE; - - if ( !nestedhvm_vcpu_in_guestmode(v) ) - __vmwrite(CR4_READ_SHADOW, v->arch.hvm.guest_cr[4]); - else - nvmx_set_cr_read_shadow(v, 4); - - v->arch.hvm.hw_cr[4] |= v->arch.hvm.guest_cr[4]; - if ( v->arch.hvm.vmx.vmx_realmode ) - v->arch.hvm.hw_cr[4] |= X86_CR4_VME; + msi_desc->pi_desc = pi_desc; + msi_desc->gvec = gvec; - if ( !hvm_paging_enabled(v) ) - { - /* - * When the guest thinks paging is disabled, Xen may need to hide - * the effects of running with CR0.PG actually enabled. There are - * two subtly complicated cases. - */ + spin_unlock_irq(&desc->lock); - if ( paging_mode_hap(v->domain) ) - { - /* - * On hardware lacking the Unrestricted Guest feature (or with - * it disabled in the VMCS), we may not enter the guest with - * CR0.PG actually disabled. When EPT is enabled, we run with - * guest paging settings, but with CR3 pointing at - * HVM_PARAM_IDENT_PT which is a 32bit pagetable using 4M - * superpages. Override the guests paging settings to match. - */ - v->arch.hvm.hw_cr[4] |= X86_CR4_PSE; - v->arch.hvm.hw_cr[4] &= ~X86_CR4_PAE; - } + ASSERT(pcidevs_locked()); - /* - * Without CR0.PG, all memory accesses are user mode, so - * _PAGE_USER must be set in the pagetables for guest userspace to - * function. This in turn trips up guest supervisor mode if - * SMEP/SMAP are left active in context. They wouldn't have any - * effect if paging was actually disabled, so hide them behind the - * back of the guest. - */ - v->arch.hvm.hw_cr[4] &= ~(X86_CR4_SMEP | X86_CR4_SMAP); - } + return iommu_update_ire_from_msi(msi_desc, &msi_desc->msg); - __vmwrite(GUEST_CR4, v->arch.hvm.hw_cr[4]); + unlock_out: + spin_unlock_irq(&desc->lock); - /* - * Shadow path has not been optimized because it requires - * unconditionally trapping more CR4 bits, at which point the - * performance benefit of doing this is quite dubious. - */ - if ( paging_mode_hap(v->domain) ) - { - /* - * Update CR4 host mask to only trap when the guest tries to set - * bits that are controlled by the hypervisor. - */ - v->arch.hvm.vmx.cr4_host_mask = - (HVM_CR4_HOST_MASK | X86_CR4_PKE | - ~hvm_cr4_guest_valid_bits(v->domain)); + return rc; +} - v->arch.hvm.vmx.cr4_host_mask |= v->arch.hvm.vmx.vmx_realmode ? - X86_CR4_VME : 0; - v->arch.hvm.vmx.cr4_host_mask |= !hvm_paging_enabled(v) ? - (X86_CR4_PSE | X86_CR4_SMEP | - X86_CR4_SMAP) - : 0; - if ( v->domain->arch.monitor.write_ctrlreg_enabled & - monitor_ctrlreg_bitmask(VM_EVENT_X86_CR4) ) - v->arch.hvm.vmx.cr4_host_mask |= - ~v->domain->arch.monitor.write_ctrlreg_mask[VM_EVENT_X86_CR4]; +static int cf_check vmx_domain_initialise(struct domain *d) +{ + static const struct arch_csw csw = { + .from = vmx_ctxt_switch_from, + .to = vmx_ctxt_switch_to, + .tail = vmx_do_resume, + }; + int rc; - if ( nestedhvm_vcpu_in_guestmode(v) ) - /* Add the nested host mask to get the more restrictive one. */ - v->arch.hvm.vmx.cr4_host_mask |= get_vvmcs(v, - CR4_GUEST_HOST_MASK); + d->arch.ctxt_switch = &csw; - __vmwrite(CR4_GUEST_HOST_MASK, v->arch.hvm.vmx.cr4_host_mask); - } + /* + * Work around CVE-2018-12207? The hardware domain is already permitted + * to reboot the system, so doesn't need mitigating against DoS's. + */ + d->arch.hvm.vmx.exec_sp = is_hardware_domain(d) || opt_ept_exec_sp; - break; + if ( (rc = vmx_alloc_vlapic_mapping(d)) != 0 ) + return rc; - case 2: - /* CR2 is updated in exit stub. */ - break; + return 0; +} - case 3: - if ( paging_mode_hap(v->domain) ) - { - if ( !hvm_paging_enabled(v) && !vmx_unrestricted_guest(v) ) - v->arch.hvm.hw_cr[3] = - v->domain->arch.hvm.params[HVM_PARAM_IDENT_PT]; - vmx_load_pdptrs(v); - } +static void cf_check vmx_domain_relinquish_resources(struct domain *d) +{ + vmx_free_vlapic_mapping(d); +} - __vmwrite(GUEST_CR3, v->arch.hvm.hw_cr[3]); +static void cf_check domain_creation_finished(struct domain *d) +{ + gfn_t gfn = gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE); + mfn_t apic_access_mfn = d->arch.hvm.vmx.apic_access_mfn; + bool ipat; - if ( !(flags & HVM_UPDATE_GUEST_CR3_NOFLUSH) ) - hvm_asid_flush_vcpu(v); - break; + if ( mfn_eq(apic_access_mfn, _mfn(0)) ) + return; - default: - BUG(); - } + ASSERT(epte_get_entry_emt(d, gfn, apic_access_mfn, 0, &ipat, + p2m_mmio_direct) == X86_MT_WB); + ASSERT(ipat); - vmx_vmcs_exit(v); + if ( set_mmio_p2m_entry(d, gfn, apic_access_mfn, PAGE_ORDER_4K) ) + domain_crash(d); } -static void cf_check vmx_update_guest_efer(struct vcpu *v) +static void vmx_init_ipt(struct vcpu *v) { - unsigned long entry_ctls, guest_efer = v->arch.hvm.guest_efer, - xen_efer = read_efer(); + unsigned int size = v->domain->vmtrace_size; - if ( paging_mode_shadow(v->domain) ) - { - /* - * When using shadow pagetables, EFER.NX is a Xen-owned bit and is not - * under guest control. - */ - guest_efer &= ~EFER_NXE; - guest_efer |= xen_efer & EFER_NXE; - } + if ( !size ) + return; - if ( !vmx_unrestricted_guest(v) ) - { - /* - * When Unrestricted Guest is not enabled in the VMCS, hardware does - * not tolerate the LME and LMA settings being different. As writes - * to CR0 are intercepted, it is safe to leave LME clear at this - * point, and fix up both LME and LMA when CR0.PG is set. - * - * Furthermore, when using shadow pagetables (subsumed by the - * Unrestricted Guest check), CR0.PG is a Xen-owned bit, and remains - * set even when the guest has logically disabled paging. LMA was - * calculated using the guest CR0.PG setting, but LME needs clearing - * to avoid interacting with Xen's CR0.PG setting. - */ - if ( !(guest_efer & EFER_LMA) ) - guest_efer &= ~EFER_LME; - } + /* Checked by domain creation logic. */ + ASSERT(v->vmtrace.pg); + ASSERT(size >= PAGE_SIZE && (size & (size - 1)) == 0); - vmx_vmcs_enter(v); + v->arch.msrs->rtit.output_limit = size - 1; +} - /* - * The intended guest running mode is derived from VM_ENTRY_IA32E_MODE, - * which (architecturally) is the guest's LMA setting. - */ - __vmread(VM_ENTRY_CONTROLS, &entry_ctls); +static int cf_check vmx_vcpu_initialise(struct vcpu *v) +{ + int rc; - entry_ctls &= ~VM_ENTRY_IA32E_MODE; - if ( guest_efer & EFER_LMA ) - entry_ctls |= VM_ENTRY_IA32E_MODE; + spin_lock_init(&v->arch.hvm.vmx.vmcs_lock); - __vmwrite(VM_ENTRY_CONTROLS, entry_ctls); + INIT_LIST_HEAD(&v->arch.hvm.vmx.pi_blocking.list); - /* We expect to use EFER loading in the common case, but... */ - if ( likely(cpu_has_vmx_efer) ) - __vmwrite(GUEST_EFER, guest_efer); + vcpu_2_nvmx(v).vmxon_region_pa = INVALID_PADDR; - /* ... on Gen1 VT-x hardware, we have to use MSR load/save lists instead. */ - else + if ( (rc = vmx_create_vmcs(v)) != 0 ) { - /* - * When the guests choice of EFER matches Xen's, remove the load/save - * list entries. It is unnecessary overhead, especially as this is - * expected to be the common case for 64bit guests. - */ - if ( guest_efer == xen_efer ) - { - vmx_del_msr(v, MSR_EFER, VMX_MSR_HOST); - vmx_del_msr(v, MSR_EFER, VMX_MSR_GUEST_LOADONLY); - } - else + dprintk(XENLOG_WARNING, + "Failed to create VMCS for vcpu %d: err=%d.\n", + v->vcpu_id, rc); + return rc; + } + + /* + * It's rare but still possible that domain has already been in log-dirty + * mode when vcpu is being created (commented by Tim), in which case we + * should enable PML for this vcpu if PML has been enabled for the domain, + * and failure to enable results in failure of creating this vcpu. + * + * Note even there's no vcpu created for the domain, vmx_domain_enable_pml + * will return successful in which case vmx_domain_pml_enabled will also + * return true. And even this is the first vcpu to be created with + * vmx_domain_pml_enabled being true, failure of enabling PML still results + * in failure of creating vcpu, to avoid complicated logic to revert PML + * style EPT table to non-PML style EPT table. + */ + if ( vmx_domain_pml_enabled(v->domain) ) + { + if ( (rc = vmx_vcpu_enable_pml(v)) != 0 ) { - vmx_add_msr(v, MSR_EFER, xen_efer, VMX_MSR_HOST); - vmx_add_msr(v, MSR_EFER, guest_efer, VMX_MSR_GUEST_LOADONLY); + dprintk(XENLOG_ERR, "%pv: Failed to enable PML.\n", v); + vmx_destroy_vmcs(v); + return rc; } } - vmx_vmcs_exit(v); + vmx_install_vlapic_mapping(v); + vmx_init_ipt(v); + + return 0; +} +static void cf_check vmx_vcpu_destroy(struct vcpu *v) +{ /* - * If the guests virtualised view of MSR_EFER matches the value loaded - * into hardware, clear the read intercept to avoid unnecessary VMExits. + * There are cases that domain still remains in log-dirty mode when it is + * about to be destroyed (ex, user types 'xl destroy '), in which case + * we should disable PML manually here. Note that vmx_vcpu_destroy is called + * prior to vmx_domain_destroy so we need to disable PML for each vcpu + * separately here. */ - if ( guest_efer == v->arch.hvm.guest_efer ) - vmx_clear_msr_intercept(v, MSR_EFER, VMX_MSR_R); - else - vmx_set_msr_intercept(v, MSR_EFER, VMX_MSR_R); + vmx_vcpu_disable_pml(v); + vmx_destroy_vmcs(v); + passive_domain_destroy(v); } -void nvmx_enqueue_n2_exceptions(struct vcpu *v, - unsigned long intr_fields, int error_code, uint8_t source) +static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) { - struct nestedvmx *nvmx = &vcpu_2_nvmx(v); + const struct cpuid_policy *cp = v->domain->arch.cpuid; + int rc = 0; - if ( !(nvmx->intr.intr_info & INTR_INFO_VALID_MASK) ) { - /* enqueue the exception till the VMCS switch back to L1 */ - nvmx->intr.intr_info = intr_fields; - nvmx->intr.error_code = error_code; - nvmx->intr.source = source; - vcpu_nestedhvm(v).nv_vmexit_pending = 1; - return; - } + if ( opt_hvm_fep || + (v->domain->arch.cpuid->x86_vendor != boot_cpu_data.x86_vendor) ) + v->arch.hvm.vmx.exception_bitmap |= (1U << TRAP_invalid_op); else - gdprintk(XENLOG_ERR, "Double Fault on Nested Guest: exception %lx %x" - "on %lx %x\n", intr_fields, error_code, - nvmx->intr.intr_info, nvmx->intr.error_code); -} - -static int cf_check nvmx_vmexit_event( - struct vcpu *v, const struct x86_event *event) -{ - nvmx_enqueue_n2_exceptions(v, event->vector, event->error_code, - hvm_intsrc_none); - return NESTEDHVM_VMEXIT_DONE; -} + v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_invalid_op); -static void __vmx_inject_exception(int trap, int type, int error_code) -{ - unsigned long intr_fields; - struct vcpu *curr = current; + vmx_vmcs_enter(v); + vmx_update_exception_bitmap(v); /* - * NB. Callers do not need to worry about clearing STI/MOV-SS blocking: - * "If the VM entry is injecting, there is no blocking by STI or by - * MOV SS following the VM entry, regardless of the contents of the - * interruptibility-state field [in the guest-state area before the - * VM entry]", PRM Vol. 3, 22.6.1 (Interruptibility State). + * We can safely pass MSR_SPEC_CTRL through to the guest, even if STIBP + * isn't enumerated in hardware, as SPEC_CTRL_STIBP is ignored. */ + if ( cp->feat.ibrsb ) + { + vmx_clear_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); - intr_fields = INTR_INFO_VALID_MASK | - MASK_INSR(type, INTR_INFO_INTR_TYPE_MASK) | - MASK_INSR(trap, INTR_INFO_VECTOR_MASK); - if ( error_code != X86_EVENT_NO_EC ) + rc = vmx_add_guest_msr(v, MSR_SPEC_CTRL, 0); + if ( rc ) + goto out; + } + else { - ASSERT(error_code == (uint16_t)error_code); - __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, error_code); - intr_fields |= INTR_INFO_DELIVER_CODE_MASK; + vmx_set_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); + + rc = vmx_del_msr(v, MSR_SPEC_CTRL, VMX_MSR_GUEST); + if ( rc && rc != -ESRCH ) + goto out; + rc = 0; /* Tolerate -ESRCH */ + } + + /* MSR_PRED_CMD is safe to pass through if the guest knows about it. */ + if ( cp->feat.ibrsb || cp->extd.ibpb ) + vmx_clear_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); + else + vmx_set_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); + + /* MSR_FLUSH_CMD is safe to pass through if the guest knows about it. */ + if ( cp->feat.l1d_flush ) + vmx_clear_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + else + vmx_set_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + + if ( cp->feat.pks ) + vmx_clear_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + else + vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + + out: + vmx_vmcs_exit(v); + + if ( rc ) + { + printk(XENLOG_G_ERR "%pv MSR list error: %d", v, rc); + domain_crash(v->domain); } +} - __vmwrite(VM_ENTRY_INTR_INFO, intr_fields); +int cf_check vmx_guest_x86_mode(struct vcpu *v) +{ + unsigned long cs_ar_bytes; - /* Can't inject exceptions in virtual 8086 mode because they would - * use the protected-mode IDT. Emulate at the next vmenter instead. */ - if ( curr->arch.hvm.vmx.vmx_realmode ) - curr->arch.hvm.vmx.vmx_emulate = 1; + if ( unlikely(!(v->arch.hvm.guest_cr[0] & X86_CR0_PE)) ) + return 0; + if ( unlikely(guest_cpu_user_regs()->eflags & X86_EFLAGS_VM) ) + return 1; + __vmread(GUEST_CS_AR_BYTES, &cs_ar_bytes); + if ( hvm_long_mode_active(v) && + likely(cs_ar_bytes & X86_SEG_AR_CS_LM_ACTIVE) ) + return 8; + return (likely(cs_ar_bytes & X86_SEG_AR_DEF_OP_SIZE) ? 4 : 2); } -void vmx_inject_extint(int trap, uint8_t source) +static void vmx_vmcs_save(struct vcpu *v, struct hvm_hw_cpu *c) { - struct vcpu *v = current; - u32 pin_based_cntrl; + unsigned long ev; - if ( nestedhvm_vcpu_in_guestmode(v) ) { - pin_based_cntrl = get_vvmcs(v, PIN_BASED_VM_EXEC_CONTROL); - if ( pin_based_cntrl & PIN_BASED_EXT_INTR_MASK ) { - nvmx_enqueue_n2_exceptions (v, - INTR_INFO_VALID_MASK | - MASK_INSR(X86_EVENTTYPE_EXT_INTR, INTR_INFO_INTR_TYPE_MASK) | - MASK_INSR(trap, INTR_INFO_VECTOR_MASK), - X86_EVENT_NO_EC, source); - return; - } + vmx_vmcs_enter(v); + + __vmread(GUEST_SYSENTER_CS, &c->sysenter_cs); + __vmread(GUEST_SYSENTER_ESP, &c->sysenter_esp); + __vmread(GUEST_SYSENTER_EIP, &c->sysenter_eip); + + __vmread(VM_ENTRY_INTR_INFO, &ev); + if ( (ev & INTR_INFO_VALID_MASK) && + hvm_event_needs_reinjection(MASK_EXTR(ev, INTR_INFO_INTR_TYPE_MASK), + ev & INTR_INFO_VECTOR_MASK) ) + { + c->pending_event = ev; + __vmread(VM_ENTRY_EXCEPTION_ERROR_CODE, &ev); + c->error_code = ev; } - __vmx_inject_exception(trap, X86_EVENTTYPE_EXT_INTR, - X86_EVENT_NO_EC); + + vmx_vmcs_exit(v); } -void vmx_inject_nmi(void) +static int vmx_restore_cr0_cr3( + struct vcpu *v, unsigned long cr0, unsigned long cr3) { - struct vcpu *v = current; - u32 pin_based_cntrl; + struct page_info *page = NULL; - if ( nestedhvm_vcpu_in_guestmode(v) ) { - pin_based_cntrl = get_vvmcs(v, PIN_BASED_VM_EXEC_CONTROL); - if ( pin_based_cntrl & PIN_BASED_NMI_EXITING ) { - nvmx_enqueue_n2_exceptions (v, - INTR_INFO_VALID_MASK | - MASK_INSR(X86_EVENTTYPE_NMI, INTR_INFO_INTR_TYPE_MASK) | - MASK_INSR(TRAP_nmi, INTR_INFO_VECTOR_MASK), - X86_EVENT_NO_EC, hvm_intsrc_nmi); - return; + if ( paging_mode_shadow(v->domain) ) + { + if ( cr0 & X86_CR0_PG ) + { + page = get_page_from_gfn(v->domain, cr3 >> PAGE_SHIFT, + NULL, P2M_ALLOC); + if ( !page ) + { + gdprintk(XENLOG_ERR, "Invalid CR3 value=%#lx\n", cr3); + return -EINVAL; + } } + + if ( hvm_paging_enabled(v) ) + put_page(pagetable_get_page(v->arch.guest_table)); + + v->arch.guest_table = + page ? pagetable_from_page(page) : pagetable_null(); } - __vmx_inject_exception(2, X86_EVENTTYPE_NMI, - X86_EVENT_NO_EC); + + v->arch.hvm.guest_cr[0] = cr0 | X86_CR0_ET; + v->arch.hvm.guest_cr[3] = cr3; + + return 0; } -/* - * Generate a virtual event in the guest. - * NOTES: - * - INT 3 (CC) and INTO (CE) are X86_EVENTTYPE_SW_EXCEPTION; - * - INT nn (CD nn) is X86_EVENTTYPE_SW_INTERRUPT; - * - #DB is X86_EVENTTYPE_HW_EXCEPTION, except when generated by - * opcode 0xf1 (which is X86_EVENTTYPE_PRI_SW_EXCEPTION) - */ -static void cf_check vmx_inject_event(const struct x86_event *event) +static int vmx_vmcs_restore(struct vcpu *v, struct hvm_hw_cpu *c) { - unsigned long intr_info; - struct vcpu *curr = current; - struct x86_event _event = *event; + int rc; - switch ( _event.vector | -(_event.type == X86_EVENTTYPE_SW_INTERRUPT) ) + if ( c->pending_valid ) { - case TRAP_debug: - if ( guest_cpu_user_regs()->eflags & X86_EFLAGS_TF ) + if ( (c->pending_type == 1) || (c->pending_type > 6) || + (c->pending_reserved != 0) ) { - __restore_debug_registers(curr); - write_debugreg(6, read_debugreg(6) | DR_STEP); + dprintk(XENLOG_ERR, "%pv: Invalid pending event %#"PRIx32"\n", + v, c->pending_event); + return -EINVAL; } - if ( !nestedhvm_vcpu_in_guestmode(curr) || - !nvmx_intercepts_exception(curr, TRAP_debug, _event.error_code) ) - { - unsigned long val; - __vmread(GUEST_DR7, &val); - __vmwrite(GUEST_DR7, val & ~DR_GENERAL_DETECT); - __vmread(GUEST_IA32_DEBUGCTL, &val); - __vmwrite(GUEST_IA32_DEBUGCTL, val & ~IA32_DEBUGCTLMSR_LBR); - } - if ( cpu_has_monitor_trap_flag ) - break; - /* fall through */ - case TRAP_int3: - if ( curr->domain->debugger_attached ) + if ( c->pending_error_valid && + c->error_code != (uint16_t)c->error_code ) { - /* Debug/Int3: Trap to debugger. */ - domain_pause_for_debugger(); - return; + dprintk(XENLOG_ERR, "%pv: Invalid error code %#"PRIx32"\n", + v, c->error_code); + return -EINVAL; } - break; - - case TRAP_page_fault: - ASSERT(_event.type == X86_EVENTTYPE_HW_EXCEPTION); - curr->arch.hvm.guest_cr[2] = _event.cr2; - break; } - if ( nestedhvm_vcpu_in_guestmode(curr) ) - intr_info = vcpu_2_nvmx(curr).intr.intr_info; - else - __vmread(VM_ENTRY_INTR_INFO, &intr_info); + rc = vmx_restore_cr0_cr3(v, c->cr0, c->cr3); + if ( rc ) + return rc; - if ( unlikely(intr_info & INTR_INFO_VALID_MASK) && - (MASK_EXTR(intr_info, INTR_INFO_INTR_TYPE_MASK) == - X86_EVENTTYPE_HW_EXCEPTION) ) - { - _event.vector = hvm_combine_hw_exceptions( - (uint8_t)intr_info, _event.vector); - if ( _event.vector == TRAP_double_fault ) - _event.error_code = 0; - } + vmx_vmcs_enter(v); - if ( _event.type >= X86_EVENTTYPE_SW_INTERRUPT ) - __vmwrite(VM_ENTRY_INSTRUCTION_LEN, _event.insn_len); + v->arch.hvm.guest_cr[4] = c->cr4; + vmx_update_guest_cr(v, 0, 0); + vmx_update_guest_cr(v, 4, 0); - if ( nestedhvm_vcpu_in_guestmode(curr) && - nvmx_intercepts_exception(curr, _event.vector, _event.error_code) ) + v->arch.hvm.guest_efer = c->msr_efer; + vmx_update_guest_efer(v); + + __vmwrite(GUEST_SYSENTER_CS, c->sysenter_cs); + __vmwrite(GUEST_SYSENTER_ESP, c->sysenter_esp); + __vmwrite(GUEST_SYSENTER_EIP, c->sysenter_eip); + + __vmwrite(GUEST_DR7, c->dr7); + + if ( c->pending_valid && + hvm_event_needs_reinjection(c->pending_type, c->pending_vector) ) { - nvmx_enqueue_n2_exceptions (curr, - INTR_INFO_VALID_MASK | - MASK_INSR(_event.type, INTR_INFO_INTR_TYPE_MASK) | - MASK_INSR(_event.vector, INTR_INFO_VECTOR_MASK), - _event.error_code, hvm_intsrc_none); - return; + gdprintk(XENLOG_INFO, "Re-injecting %#"PRIx32", %#"PRIx32"\n", + c->pending_event, c->error_code); + __vmwrite(VM_ENTRY_INTR_INFO, c->pending_event); + __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, c->error_code); } else - __vmx_inject_exception(_event.vector, _event.type, _event.error_code); + { + __vmwrite(VM_ENTRY_INTR_INFO, 0); + __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, 0); + } + vmx_vmcs_exit(v); - if ( (_event.vector == TRAP_page_fault) && - (_event.type == X86_EVENTTYPE_HW_EXCEPTION) ) - HVMTRACE_LONG_2D(PF_INJECT, _event.error_code, - TRC_PAR_LONG(curr->arch.hvm.guest_cr[2])); - else - HVMTRACE_2D(INJ_EXC, _event.vector, _event.error_code); + paging_update_paging_modes(v); + + return 0; } -static bool cf_check vmx_event_pending(const struct vcpu *v) +static void vmx_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) { - unsigned long intr_info; - - ASSERT(v == current); - __vmread(VM_ENTRY_INTR_INFO, &intr_info); - - return intr_info & INTR_INFO_VALID_MASK; + data->shadow_gs = v->arch.hvm.vmx.shadow_gs; + data->msr_lstar = v->arch.hvm.vmx.lstar; + data->msr_star = v->arch.hvm.vmx.star; + data->msr_cstar = v->arch.hvm.vmx.cstar; + data->msr_syscall_mask = v->arch.hvm.vmx.sfmask; } -static void cf_check vmx_set_info_guest(struct vcpu *v) +static void vmx_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data) { - unsigned long intr_shadow; - - vmx_vmcs_enter(v); - - __vmwrite(GUEST_DR7, v->arch.dr7); - - /* - * If the interruptibility-state field indicates blocking by STI, - * setting the TF flag in the EFLAGS may cause VM entry to fail - * and crash the guest. See SDM 3B 22.3.1.5. - * Resetting the VMX_INTR_SHADOW_STI flag looks hackish but - * to set the GUEST_PENDING_DBG_EXCEPTIONS.BS here incurs - * immediately vmexit and hence make no progress. - */ - __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); - if ( v->domain->debugger_attached && - (v->arch.user_regs.eflags & X86_EFLAGS_TF) && - (intr_shadow & VMX_INTR_SHADOW_STI) ) - { - intr_shadow &= ~VMX_INTR_SHADOW_STI; - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow); - } - - vmx_vmcs_exit(v); + v->arch.hvm.vmx.shadow_gs = data->shadow_gs; + v->arch.hvm.vmx.star = data->msr_star; + v->arch.hvm.vmx.lstar = data->msr_lstar; + v->arch.hvm.vmx.cstar = data->msr_cstar; + v->arch.hvm.vmx.sfmask = data->msr_syscall_mask; } -static void cf_check vmx_update_eoi_exit_bitmap( - struct vcpu *v, uint8_t vector, bool set) +static void cf_check vmx_save_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt) { - if ( set ) - vmx_set_eoi_exit_bitmap(v, vector); - else - vmx_clear_eoi_exit_bitmap(v, vector); + if ( v == current ) + vmx_save_guest_msrs(v); + + vmx_save_cpu_state(v, ctxt); + vmx_vmcs_save(v, ctxt); } -static u8 set_svi(int isr) +static int cf_check vmx_load_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt) { - unsigned long status; - u8 old; + /* Not currently safe to use in current context. */ + ASSERT(v != current); - if ( isr < 0 ) - isr = 0; + vmx_load_cpu_state(v, ctxt); - __vmread(GUEST_INTR_STATUS, &status); - old = status >> VMX_GUEST_INTR_STATUS_SVI_OFFSET; - if ( isr != old ) + if ( vmx_vmcs_restore(v, ctxt) ) { - status &= VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK; - status |= isr << VMX_GUEST_INTR_STATUS_SVI_OFFSET; - __vmwrite(GUEST_INTR_STATUS, status); + gdprintk(XENLOG_ERR, "vmx_vmcs restore failed!\n"); + domain_crash(v->domain); + return -EINVAL; } - return old; + return 0; } -static void cf_check vmx_process_isr(int isr, struct vcpu *v) +unsigned int vmx_get_cpl(void) { - unsigned int i; - const struct vlapic *vlapic = vcpu_vlapic(v); - - vmx_vmcs_enter(v); - - set_svi(isr); - - /* - * Theoretically, only level triggered interrupts can have their - * corresponding bits set in the eoi exit bitmap. That is, the bits - * set in the eoi exit bitmap should also be set in TMR. But a periodic - * timer interrupt does not follow the rule: it is edge triggered, but - * requires its corresponding bit be set in the eoi exit bitmap. So we - * should not construct the eoi exit bitmap based on TMR. - * Here we will construct the eoi exit bitmap via (IRR | ISR). This - * means that EOIs to the interrupts that are set in the IRR or ISR will - * cause VM exits after restoring, regardless of the trigger modes. It - * is acceptable because the subsequent interrupts will set up the eoi - * bitmap correctly. - */ - for ( i = 0x10; i < X86_NR_VECTORS; ++i ) - if ( vlapic_test_vector(i, &vlapic->regs->data[APIC_IRR]) || - vlapic_test_vector(i, &vlapic->regs->data[APIC_ISR]) ) - set_bit(i, v->arch.hvm.vmx.eoi_exit_bitmap); + unsigned long attr; - for ( i = 0; i < ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap); ++i ) - __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]); + __vmread(GUEST_SS_AR_BYTES, &attr); - vmx_vmcs_exit(v); + return (attr >> 5) & 3; } -static void __vmx_deliver_posted_interrupt(struct vcpu *v) +static unsigned int cf_check _vmx_get_cpl(struct vcpu *v) { - bool_t running = v->is_running; + unsigned int cpl; - vcpu_unblock(v); - /* - * Just like vcpu_kick(), nothing is needed for the following two cases: - * 1. The target vCPU is not running, meaning it is blocked or runnable. - * 2. The target vCPU is the current vCPU and we're in non-interrupt - * context. - */ - if ( running && (in_irq() || (v != current)) ) - { - /* - * Note: Only two cases will reach here: - * 1. The target vCPU is running on other pCPU. - * 2. The target vCPU is the current vCPU. - * - * Note2: Don't worry the v->processor may change. The vCPU being - * moved to another processor is guaranteed to sync PIR to vIRR, - * due to the involved scheduling cycle. - */ - unsigned int cpu = v->processor; + vmx_vmcs_enter(v); + cpl = vmx_get_cpl(); + vmx_vmcs_exit(v); - /* - * For case 1, we send an IPI to the pCPU. When an IPI arrives, the - * target vCPU maybe is running in non-root mode, running in root - * mode, runnable or blocked. If the target vCPU is running in - * non-root mode, the hardware will sync PIR to vIRR for - * 'posted_intr_vector' is special to the pCPU. If the target vCPU is - * running in root-mode, the interrupt handler starts to run. - * Considering an IPI may arrive in the window between the call to - * vmx_intr_assist() and interrupts getting disabled, the interrupt - * handler should raise a softirq to ensure events will be delivered - * in time. If the target vCPU is runnable, it will sync PIR to - * vIRR next time it is chose to run. In this case, a IPI and a - * softirq is sent to a wrong vCPU which will not have any adverse - * effect. If the target vCPU is blocked, since vcpu_block() checks - * whether there is an event to be delivered through - * local_events_need_delivery() just after blocking, the vCPU must - * have synced PIR to vIRR. Similarly, there is a IPI and a softirq - * sent to a wrong vCPU. - */ - if ( cpu != smp_processor_id() ) - send_IPI_mask(cpumask_of(cpu), posted_intr_vector); - /* - * For case 2, raising a softirq ensures PIR will be synced to vIRR. - * As any softirq will do, as an optimization we only raise one if - * none is pending already. - */ - else if ( !softirq_pending(cpu) ) - raise_softirq(VCPU_KICK_SOFTIRQ); - } + return cpl; } -static void cf_check vmx_deliver_posted_intr(struct vcpu *v, u8 vector) -{ - struct pi_desc old, new, prev; +/* + * SDM Vol 3: VM Entries > Checks on Guest Segment Registers: + * + * We can only enter virtual 8086 mode if all of CS, SS, DS, ES, FS and GS are + * 16bit ring-3 data segments. On hardware lacking the unrestricted_guest + * feature, Xen fakes up real mode using vm86 mode. The guest thinks it's got + * ring-0 segments, so we need to fudge things. We store the ring-3 version + * in the VMCS to avoid lots of shuffling on vmenter and vmexit, and translate + * in these accessors. + */ +#define rm_cs_attr 0x9b +#define rm_ds_attr 0x93 +#define vm86_ds_attr 0xf3 +#define vm86_tr_attr 0x8b - if ( pi_test_and_set_pir(vector, &v->arch.hvm.vmx.pi_desc) ) - return; +static void cf_check vmx_get_segment_register( + struct vcpu *v, enum x86_segment seg, struct segment_register *reg) +{ + unsigned long attr = 0, sel = 0, limit; + unsigned int tmp_seg; - if ( unlikely(v->arch.hvm.vmx.eoi_exitmap_changed) ) + /* + * We may get here in the context of dump_execstate(), which may have + * interrupted context switching between setting "current" and + * vmx_do_resume() reaching the end of vmx_load_vmcs(). That would make + * all the VMREADs below fail if we don't bail right away. + */ + if ( unlikely(!vmx_vmcs_try_enter(v)) ) { - /* - * If EOI exitbitmap needs to changed or notification vector - * can't be allocated, interrupt will not be injected till - * VMEntry as it used to be. - */ - pi_set_on(&v->arch.hvm.vmx.pi_desc); - vcpu_kick(v); - return; - } - - prev.control = v->arch.hvm.vmx.pi_desc.control; + static bool_t warned; - do { - /* - * Currently, we don't support urgent interrupt, all - * interrupts are recognized as non-urgent interrupt, - * Besides that, if 'ON' is already set, no need to - * send posted-interrupts notification event as well, - * according to hardware behavior. - */ - if ( pi_test_sn(&prev) || pi_test_on(&prev) ) + if ( !warned ) { - vcpu_kick(v); - return; + warned = 1; + printk(XENLOG_WARNING "Segment register inaccessible for %pv\n" + "(If you see this outside of debugging activity," + " please report to xen-devel@lists.xenproject.org)\n", + v); } + memset(reg, 0, sizeof(*reg)); + return; + } - old.control = v->arch.hvm.vmx.pi_desc.control & - ~((1 << POSTED_INTR_ON) | (1 << POSTED_INTR_SN)); - new.control = v->arch.hvm.vmx.pi_desc.control | - (1 << POSTED_INTR_ON); - - prev.control = cmpxchg(&v->arch.hvm.vmx.pi_desc.control, - old.control, new.control); - } while ( prev.control != old.control ); + /* + * Xen's x86_seg_* enumeration *almost* matches the VMCS encoding order. + * + * tr and ldtr are reversed, and other areas of code rely on this, so we + * can't just re-enumerate. + */ + BUILD_BUG_ON(x86_seg_tr != 6); + BUILD_BUG_ON(x86_seg_ldtr != 7); + BUILD_BUG_ON(x86_seg_gdtr != 8); + BUILD_BUG_ON(x86_seg_idtr != 9); + switch ( tmp_seg = seg ) + { + case x86_seg_tr: + case x86_seg_ldtr: + tmp_seg ^= 1; /* Flip tr and ldtr so GUEST_SEG_*() works. */ + fallthrough; - __vmx_deliver_posted_interrupt(v); -} + case x86_seg_es ... x86_seg_gs: + __vmread(GUEST_SEG_SELECTOR(tmp_seg), &sel); + __vmread(GUEST_SEG_AR_BYTES(tmp_seg), &attr); + fallthrough; -static void cf_check vmx_sync_pir_to_irr(struct vcpu *v) -{ - struct vlapic *vlapic = vcpu_vlapic(v); - unsigned int group, i; - DECLARE_BITMAP(pending_intr, X86_NR_VECTORS); + case x86_seg_gdtr: + case x86_seg_idtr: + __vmread(GUEST_SEG_LIMIT(tmp_seg), &limit); + __vmread(GUEST_SEG_BASE(tmp_seg), ®->base); + break; - if ( !pi_test_and_clear_on(&v->arch.hvm.vmx.pi_desc) ) + default: + BUG(); return; + } - for ( group = 0; group < ARRAY_SIZE(pending_intr); group++ ) - pending_intr[group] = pi_get_pir(&v->arch.hvm.vmx.pi_desc, group); + vmx_vmcs_exit(v); - for_each_set_bit(i, pending_intr, X86_NR_VECTORS) - vlapic_set_vector(i, &vlapic->regs->data[APIC_IRR]); -} + reg->sel = sel; + reg->limit = limit; -static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) -{ - return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); + /* + * Fold VT-x representation into Xen's representation. The Present bit is + * unconditionally set to the inverse of unusable. + */ + reg->attr = + (!(attr & (1u << 16)) << 7) | (attr & 0x7f) | ((attr >> 4) & 0xf00); + + /* Adjust for virtual 8086 mode */ + if ( v->arch.hvm.vmx.vmx_realmode && seg <= x86_seg_tr + && !(v->arch.hvm.vmx.vm86_segment_mask & (1u << seg)) ) + { + struct segment_register *sreg = &v->arch.hvm.vmx.vm86_saved_seg[seg]; + if ( seg == x86_seg_tr ) + *reg = *sreg; + else if ( reg->base != sreg->base || seg == x86_seg_ss ) + { + /* If the guest's reloaded the segment, remember the new version. + * We can't tell if the guest reloaded the segment with another + * one that has the same base. By default we assume it hasn't, + * since we don't want to lose big-real-mode segment attributes, + * but for SS we assume it has: the Ubuntu graphical bootloader + * does this and gets badly confused if we leave the old SS in + * place. */ + reg->attr = (seg == x86_seg_cs ? rm_cs_attr : rm_ds_attr); + *sreg = *reg; + } + else + { + /* Always give realmode guests a selector that matches the base + * but keep the attr and limit from before */ + *reg = *sreg; + reg->sel = reg->base >> 4; + } + } } -static void cf_check vmx_handle_eoi(uint8_t vector, int isr) +static void cf_check vmx_set_segment_register( + struct vcpu *v, enum x86_segment seg, struct segment_register *reg) { - uint8_t old_svi = set_svi(isr); - static bool warned; - - if ( vector != old_svi && !test_and_set_bool(warned) ) - printk(XENLOG_WARNING "EOI for %02x but SVI=%02x\n", vector, old_svi); -} + uint32_t attr, sel, limit; + uint64_t base; -static void cf_check vmx_enable_msr_interception(struct domain *d, uint32_t msr) -{ - struct vcpu *v; + sel = reg->sel; + attr = reg->attr; + limit = reg->limit; + base = reg->base; - for_each_vcpu ( d, v ) - vmx_set_msr_intercept(v, msr, VMX_MSR_W); -} + /* Adjust CS/SS/DS/ES/FS/GS/TR for virtual 8086 mode */ + if ( v->arch.hvm.vmx.vmx_realmode && seg <= x86_seg_tr ) + { + /* Remember the proper contents */ + v->arch.hvm.vmx.vm86_saved_seg[seg] = *reg; -static void cf_check vmx_vcpu_update_eptp(struct vcpu *v) -{ - struct domain *d = v->domain; - struct p2m_domain *p2m = NULL; - struct ept_data *ept; + if ( seg == x86_seg_tr ) + { + const struct domain *d = v->domain; + uint64_t val = d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED]; - if ( altp2m_active(d) ) - p2m = p2m_get_altp2m(v); - if ( !p2m ) - p2m = p2m_get_hostp2m(d); + if ( val ) + { + sel = 0; + attr = vm86_tr_attr; + limit = ((val & ~VM86_TSS_UPDATED) >> 32) - 1; + base = (uint32_t)val; + if ( val & VM86_TSS_UPDATED ) + { + hvm_prepare_vm86_tss(v, base, limit); + cmpxchg(&d->arch.hvm.params[HVM_PARAM_VM86_TSS_SIZED], + val, val & ~VM86_TSS_UPDATED); + } + v->arch.hvm.vmx.vm86_segment_mask &= ~(1u << seg); + } + else + v->arch.hvm.vmx.vm86_segment_mask |= (1u << seg); + } + else + { + /* Try to fake it out as a 16bit data segment. This could + * cause confusion for the guest if it reads the selector, + * but otherwise we have to emulate if *any* segment hasn't + * been reloaded. */ + if ( base < 0x100000 && !(base & 0xf) && limit >= 0xffff && reg->p ) + { + sel = base >> 4; + attr = vm86_ds_attr; + limit = 0xffff; + v->arch.hvm.vmx.vm86_segment_mask &= ~(1u << seg); + } + else + v->arch.hvm.vmx.vm86_segment_mask |= (1u << seg); + } + } - ept = &p2m->ept; - ept->mfn = pagetable_get_pfn(p2m_get_pagetable(p2m)); + /* + * Unfold Xen representation into VT-x representation. The unusable bit + * is unconditionally set to the inverse of present. + */ + attr = (!(attr & (1u << 7)) << 16) | ((attr & 0xf00) << 4) | (attr & 0xff); vmx_vmcs_enter(v); - __vmwrite(EPT_POINTER, ept->eptp); + switch ( seg ) + { + case x86_seg_tr: + case x86_seg_ldtr: + seg ^= 1; /* Flip tr and ldtr so GUEST_SEG_*() works. */ + fallthrough; - if ( v->arch.hvm.vmx.secondary_exec_control & - SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS ) - __vmwrite(EPTP_INDEX, vcpu_altp2m(v).p2midx); + case x86_seg_es ... x86_seg_gs: + __vmwrite(GUEST_SEG_SELECTOR(seg), sel); + __vmwrite(GUEST_SEG_AR_BYTES(seg), attr); + fallthrough; + + case x86_seg_gdtr: + case x86_seg_idtr: + __vmwrite(GUEST_SEG_LIMIT(seg), limit); + __vmwrite(GUEST_SEG_BASE(seg), base); + break; + + default: + BUG(); + } vmx_vmcs_exit(v); } -static void cf_check vmx_vcpu_update_vmfunc_ve(struct vcpu *v) +static int cf_check vmx_set_guest_pat(struct vcpu *v, u64 gpat) { - struct domain *d = v->domain; - u32 mask = SECONDARY_EXEC_ENABLE_VM_FUNCTIONS; + if ( !paging_mode_hap(v->domain) || + unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) ) + return 0; - if ( !cpu_has_vmx_vmfunc ) - return; + vmx_vmcs_enter(v); + __vmwrite(GUEST_PAT, gpat); + vmx_vmcs_exit(v); + return 1; +} - if ( cpu_has_vmx_virt_exceptions ) - mask |= SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS; +static int cf_check vmx_get_guest_pat(struct vcpu *v, u64 *gpat) +{ + if ( !paging_mode_hap(v->domain) || + unlikely(v->arch.hvm.cache_mode == NO_FILL_CACHE_MODE) ) + return 0; vmx_vmcs_enter(v); + __vmread(GUEST_PAT, gpat); + vmx_vmcs_exit(v); + return 1; +} - if ( !d->is_dying && altp2m_active(d) ) +static void cf_check vmx_handle_cd(struct vcpu *v, unsigned long value) +{ + if ( !paging_mode_hap(v->domain) ) { - v->arch.hvm.vmx.secondary_exec_control |= mask; - __vmwrite(VM_FUNCTION_CONTROL, VMX_VMFUNC_EPTP_SWITCHING); - __vmwrite(EPTP_LIST_ADDR, virt_to_maddr(d->arch.altp2m_visible_eptp)); + /* + * For shadow, 'load IA32_PAT' VM-entry control is 0, so it cannot + * set guest memory type as UC via IA32_PAT. Xen drop all shadows + * so that any new ones would be created on demand. + */ + hvm_shadow_handle_cd(v, value); + } + else + { + u64 *pat = &v->arch.hvm.pat_cr; - if ( cpu_has_vmx_virt_exceptions ) + if ( value & X86_CR0_CD ) { - const struct page_info *pg = vcpu_altp2m(v).veinfo_pg; + /* + * For EPT, set guest IA32_PAT fields as UC so that guest + * memory type are all UC. + */ + u64 uc_pat = + ((uint64_t)X86_MT_UC) | /* PAT0 */ + ((uint64_t)X86_MT_UC << 8) | /* PAT1 */ + ((uint64_t)X86_MT_UC << 16) | /* PAT2 */ + ((uint64_t)X86_MT_UC << 24) | /* PAT3 */ + ((uint64_t)X86_MT_UC << 32) | /* PAT4 */ + ((uint64_t)X86_MT_UC << 40) | /* PAT5 */ + ((uint64_t)X86_MT_UC << 48) | /* PAT6 */ + ((uint64_t)X86_MT_UC << 56); /* PAT7 */ - if ( pg ) - { - __vmwrite(VIRT_EXCEPTION_INFO, page_to_maddr(pg)); - /* - * Make sure we have an up-to-date EPTP_INDEX when - * setting SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS. - */ - __vmwrite(EPTP_INDEX, vcpu_altp2m(v).p2midx); - } - else - v->arch.hvm.vmx.secondary_exec_control &= - ~SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS; + vmx_get_guest_pat(v, pat); + vmx_set_guest_pat(v, uc_pat); + vmx_set_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + + wbinvd(); /* flush possibly polluted cache */ + hvm_asid_flush_vcpu(v); /* invalidate memory type cached in TLB */ + v->arch.hvm.cache_mode = NO_FILL_CACHE_MODE; + } + else + { + v->arch.hvm.cache_mode = NORMAL_CACHE_MODE; + vmx_set_guest_pat(v, *pat); + if ( !is_iommu_enabled(v->domain) || iommu_snoop ) + vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + hvm_asid_flush_vcpu(v); /* no need to flush cache */ } } - else - v->arch.hvm.vmx.secondary_exec_control &= ~mask; - - vmx_update_secondary_exec_control(v); - vmx_vmcs_exit(v); } -static int cf_check vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs) +static void cf_check vmx_setup_tsc_scaling(struct vcpu *v) { - int rc = X86EMUL_EXCEPTION; - struct vcpu *curr = current; - - if ( !cpu_has_vmx_vmfunc && altp2m_active(curr->domain) && - regs->eax == 0 && - p2m_switch_vcpu_altp2m_by_id(curr, regs->ecx) ) - rc = X86EMUL_OKAY; + if ( v->domain->arch.vtsc ) + return; - return rc; + vmx_vmcs_enter(v); + __vmwrite(TSC_MULTIPLIER, hvm_tsc_scaling_ratio(v->domain)); + vmx_vmcs_exit(v); } -static bool cf_check vmx_vcpu_emulate_ve(struct vcpu *v) +static void cf_check vmx_set_tsc_offset(struct vcpu *v, u64 offset, u64 at_tsc) { - const struct page_info *pg = vcpu_altp2m(v).veinfo_pg; - ve_info_t *veinfo; - bool rc = false; - - if ( !pg ) - return rc; - - veinfo = __map_domain_page(pg); + vmx_vmcs_enter(v); - if ( veinfo->semaphore != 0 ) - goto out; + if ( nestedhvm_vcpu_in_guestmode(v) ) + offset += nvmx_get_tsc_offset(v); - rc = true; - veinfo->exit_reason = EXIT_REASON_EPT_VIOLATION; - veinfo->semaphore = ~0; - veinfo->eptp_index = vcpu_altp2m(v).p2midx; + __vmwrite(TSC_OFFSET, offset); + vmx_vmcs_exit(v); +} +static void cf_check vmx_set_rdtsc_exiting(struct vcpu *v, bool enable) +{ vmx_vmcs_enter(v); - __vmread(EXIT_QUALIFICATION, &veinfo->exit_qualification); - __vmread(GUEST_LINEAR_ADDRESS, &veinfo->gla); - __vmread(GUEST_PHYSICAL_ADDRESS, &veinfo->gpa); + v->arch.hvm.vmx.exec_control &= ~CPU_BASED_RDTSC_EXITING; + if ( enable ) + v->arch.hvm.vmx.exec_control |= CPU_BASED_RDTSC_EXITING; + vmx_update_cpu_exec_control(v); vmx_vmcs_exit(v); - - hvm_inject_hw_exception(TRAP_virtualisation, - X86_EVENT_NO_EC); - - out: - unmap_domain_page(veinfo); - - if ( rc ) - paging_mark_dirty(v->domain, page_to_mfn(pg)); - - return rc; } -static bool cf_check vmx_get_pending_event( - struct vcpu *v, struct x86_event *info) +static void cf_check vmx_set_descriptor_access_exiting( + struct vcpu *v, bool enable) { - unsigned long intr_info, error_code; + if ( enable ) + v->arch.hvm.vmx.secondary_exec_control |= + SECONDARY_EXEC_DESCRIPTOR_TABLE_EXITING; + else + v->arch.hvm.vmx.secondary_exec_control &= + ~SECONDARY_EXEC_DESCRIPTOR_TABLE_EXITING; vmx_vmcs_enter(v); - __vmread(VM_ENTRY_INTR_INFO, &intr_info); - __vmread(VM_ENTRY_EXCEPTION_ERROR_CODE, &error_code); + vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); +} - if ( !(intr_info & INTR_INFO_VALID_MASK) ) - return false; +static void cf_check vmx_init_hypercall_page(void *p) +{ + unsigned int i; - info->vector = MASK_EXTR(intr_info, INTR_INFO_VECTOR_MASK); - info->type = MASK_EXTR(intr_info, INTR_INFO_INTR_TYPE_MASK); - info->error_code = error_code; + for ( i = 0; i < (PAGE_SIZE / 32); i++, p += 32 ) + { + if ( unlikely(i == __HYPERVISOR_iret) ) + { + /* HYPERVISOR_iret isn't supported */ + *(u16 *)p = 0x0b0f; /* ud2 */ - return true; + continue; + } + + *(u8 *)(p + 0) = 0xb8; /* mov imm32, %eax */ + *(u32 *)(p + 1) = i; + *(u8 *)(p + 5) = 0x0f; /* vmcall */ + *(u8 *)(p + 6) = 0x01; + *(u8 *)(p + 7) = 0xc1; + *(u8 *)(p + 8) = 0xc3; /* ret */ + } } -/* - * We only let vmtrace agents see and modify a subset of bits in MSR_RTIT_CTL. - * These all pertain to data-emitted into the trace buffer(s). Must not - * include controls pertaining to the structure/position of the trace - * buffer(s). - */ -#define RTIT_CTL_MASK \ - (RTIT_CTL_TRACE_EN | RTIT_CTL_OS | RTIT_CTL_USR | RTIT_CTL_TSC_EN | \ - RTIT_CTL_DIS_RETC | RTIT_CTL_BRANCH_EN) +static unsigned int cf_check vmx_get_interrupt_shadow(struct vcpu *v) +{ + unsigned long intr_shadow; -/* - * Status bits restricted to the first-gen subset (i.e. no further CPUID - * requirements.) - */ -#define RTIT_STATUS_MASK \ - (RTIT_STATUS_FILTER_EN | RTIT_STATUS_CONTEXT_EN | RTIT_STATUS_TRIGGER_EN | \ - RTIT_STATUS_ERROR | RTIT_STATUS_STOPPED) + __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); -static int cf_check vmtrace_get_option( - struct vcpu *v, uint64_t key, uint64_t *output) + return intr_shadow; +} + +static void cf_check vmx_set_interrupt_shadow( + struct vcpu *v, unsigned int intr_shadow) { - const struct vcpu_msrs *msrs = v->arch.msrs; + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow); +} - switch ( key ) - { - case MSR_RTIT_CTL: - *output = msrs->rtit.ctl & RTIT_CTL_MASK; - break; +static void cf_check vmx_get_nonreg_state(struct vcpu *v, + struct hvm_vcpu_nonreg_state *nrs) +{ + vmx_vmcs_enter(v); - case MSR_RTIT_STATUS: - *output = msrs->rtit.status & RTIT_STATUS_MASK; - break; + __vmread(GUEST_ACTIVITY_STATE, &nrs->vmx.activity_state); + __vmread(GUEST_INTERRUPTIBILITY_INFO, &nrs->vmx.interruptibility_info); + __vmread(GUEST_PENDING_DBG_EXCEPTIONS, &nrs->vmx.pending_dbg); - default: - *output = 0; - return -EINVAL; - } - return 0; + if ( cpu_has_vmx_virtual_intr_delivery ) + __vmread(GUEST_INTR_STATUS, &nrs->vmx.interrupt_status); + + vmx_vmcs_exit(v); } -static int cf_check vmtrace_set_option( - struct vcpu *v, uint64_t key, uint64_t value) +static void cf_check vmx_set_nonreg_state(struct vcpu *v, + struct hvm_vcpu_nonreg_state *nrs) { - struct vcpu_msrs *msrs = v->arch.msrs; - bool new_en, old_en = msrs->rtit.ctl & RTIT_CTL_TRACE_EN; - - switch ( key ) - { - case MSR_RTIT_CTL: - if ( value & ~RTIT_CTL_MASK ) - return -EINVAL; + vmx_vmcs_enter(v); - msrs->rtit.ctl &= ~RTIT_CTL_MASK; - msrs->rtit.ctl |= (value & RTIT_CTL_MASK); - break; + __vmwrite(GUEST_ACTIVITY_STATE, nrs->vmx.activity_state); + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, nrs->vmx.interruptibility_info); + __vmwrite(GUEST_PENDING_DBG_EXCEPTIONS, nrs->vmx.pending_dbg); - case MSR_RTIT_STATUS: - if ( value & ~RTIT_STATUS_MASK ) - return -EINVAL; + if ( cpu_has_vmx_virtual_intr_delivery ) + __vmwrite(GUEST_INTR_STATUS, nrs->vmx.interrupt_status); - msrs->rtit.status &= ~RTIT_STATUS_MASK; - msrs->rtit.status |= (value & RTIT_STATUS_MASK); - break; + vmx_vmcs_exit(v); +} - default: - return -EINVAL; - } +static void cf_check vmx_update_host_cr3(struct vcpu *v) +{ + vmx_vmcs_enter(v); + __vmwrite(HOST_CR3, v->arch.cr3); + vmx_vmcs_exit(v); +} - new_en = msrs->rtit.ctl & RTIT_CTL_TRACE_EN; +static void nvmx_enqueue_n2_exceptions(struct vcpu *v, + unsigned long intr_fields, int error_code, uint8_t source) +{ + struct nestedvmx *nvmx = &vcpu_2_nvmx(v); - /* ctl.trace_en changed => update MSR load/save lists appropriately. */ - if ( !old_en && new_en ) - { - if ( vmx_add_guest_msr(v, MSR_RTIT_CTL, msrs->rtit.ctl) || - vmx_add_host_load_msr(v, MSR_RTIT_CTL, 0) ) - { - /* - * The only failure cases here are failing the - * singleton-per-domain memory allocation, or exceeding the space - * in the allocation. We could unwind in principle, but there is - * nothing userspace can usefully do to continue using this VM. - */ - domain_crash(v->domain); - return -ENXIO; - } - } - else if ( old_en && !new_en ) - { - vmx_del_msr(v, MSR_RTIT_CTL, VMX_MSR_GUEST); - vmx_del_msr(v, MSR_RTIT_CTL, VMX_MSR_HOST); + if ( !(nvmx->intr.intr_info & INTR_INFO_VALID_MASK) ) { + /* enqueue the exception till the VMCS switch back to L1 */ + nvmx->intr.intr_info = intr_fields; + nvmx->intr.error_code = error_code; + nvmx->intr.source = source; + vcpu_nestedhvm(v).nv_vmexit_pending = 1; + return; } + else + gdprintk(XENLOG_ERR, "Double Fault on Nested Guest: exception %lx %x" + "on %lx %x\n", intr_fields, error_code, + nvmx->intr.intr_info, nvmx->intr.error_code); +} - return 0; +static int cf_check nvmx_vmexit_event( + struct vcpu *v, const struct x86_event *event) +{ + nvmx_enqueue_n2_exceptions(v, event->vector, event->error_code, + hvm_intsrc_none); + return NESTEDHVM_VMEXIT_DONE; } -static int cf_check vmtrace_control(struct vcpu *v, bool enable, bool reset) +static void __vmx_inject_exception(int trap, int type, int error_code) { - struct vcpu_msrs *msrs = v->arch.msrs; - uint64_t new_ctl; - int rc; + unsigned long intr_fields; + struct vcpu *curr = current; /* - * Absolutely nothing good will come of Xen's and userspace's idea of - * whether ipt is enabled getting out of sync. + * NB. Callers do not need to worry about clearing STI/MOV-SS blocking: + * "If the VM entry is injecting, there is no blocking by STI or by + * MOV SS following the VM entry, regardless of the contents of the + * interruptibility-state field [in the guest-state area before the + * VM entry]", PRM Vol. 3, 22.6.1 (Interruptibility State). */ - if ( v->arch.hvm.vmx.ipt_active == enable ) - return -EINVAL; - if ( reset ) + intr_fields = INTR_INFO_VALID_MASK | + MASK_INSR(type, INTR_INFO_INTR_TYPE_MASK) | + MASK_INSR(trap, INTR_INFO_VECTOR_MASK); + if ( error_code != X86_EVENT_NO_EC ) { - msrs->rtit.status = 0; - msrs->rtit.output_offset = 0; + ASSERT(error_code == (uint16_t)error_code); + __vmwrite(VM_ENTRY_EXCEPTION_ERROR_CODE, error_code); + intr_fields |= INTR_INFO_DELIVER_CODE_MASK; } - new_ctl = msrs->rtit.ctl & ~RTIT_CTL_TRACE_EN; - if ( enable ) - new_ctl |= RTIT_CTL_TRACE_EN; - - rc = vmtrace_set_option(v, MSR_RTIT_CTL, new_ctl); - if ( rc ) - return rc; - - v->arch.hvm.vmx.ipt_active = enable; + __vmwrite(VM_ENTRY_INTR_INFO, intr_fields); - return 0; + /* Can't inject exceptions in virtual 8086 mode because they would + * use the protected-mode IDT. Emulate at the next vmenter instead. */ + if ( curr->arch.hvm.vmx.vmx_realmode ) + curr->arch.hvm.vmx.vmx_emulate = 1; } -static int cf_check vmtrace_output_position(struct vcpu *v, uint64_t *pos) +void vmx_inject_extint(int trap, uint8_t source) { - *pos = v->arch.msrs->rtit.output_offset; - return v->arch.hvm.vmx.ipt_active; + struct vcpu *v = current; + u32 pin_based_cntrl; + + if ( nestedhvm_vcpu_in_guestmode(v) ) { + pin_based_cntrl = get_vvmcs(v, PIN_BASED_VM_EXEC_CONTROL); + if ( pin_based_cntrl & PIN_BASED_EXT_INTR_MASK ) { + nvmx_enqueue_n2_exceptions (v, + INTR_INFO_VALID_MASK | + MASK_INSR(X86_EVENTTYPE_EXT_INTR, INTR_INFO_INTR_TYPE_MASK) | + MASK_INSR(trap, INTR_INFO_VECTOR_MASK), + X86_EVENT_NO_EC, source); + return; + } + } + __vmx_inject_exception(trap, X86_EVENTTYPE_EXT_INTR, + X86_EVENT_NO_EC); } -static int cf_check vmtrace_reset(struct vcpu *v) +void vmx_inject_nmi(void) { - if ( !v->arch.hvm.vmx.ipt_active ) - return -EINVAL; + struct vcpu *v = current; + u32 pin_based_cntrl; - v->arch.msrs->rtit.output_offset = 0; - v->arch.msrs->rtit.status = 0; - return 0; + if ( nestedhvm_vcpu_in_guestmode(v) ) { + pin_based_cntrl = get_vvmcs(v, PIN_BASED_VM_EXEC_CONTROL); + if ( pin_based_cntrl & PIN_BASED_NMI_EXITING ) { + nvmx_enqueue_n2_exceptions (v, + INTR_INFO_VALID_MASK | + MASK_INSR(X86_EVENTTYPE_NMI, INTR_INFO_INTR_TYPE_MASK) | + MASK_INSR(TRAP_nmi, INTR_INFO_VECTOR_MASK), + X86_EVENT_NO_EC, hvm_intsrc_nmi); + return; + } + } + __vmx_inject_exception(2, X86_EVENTTYPE_NMI, + X86_EVENT_NO_EC); } -static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) +/* + * Generate a virtual event in the guest. + * NOTES: + * - INT 3 (CC) and INTO (CE) are X86_EVENTTYPE_SW_EXCEPTION; + * - INT nn (CD nn) is X86_EVENTTYPE_SW_INTERRUPT; + * - #DB is X86_EVENTTYPE_HW_EXCEPTION, except when generated by + * opcode 0xf1 (which is X86_EVENTTYPE_PRI_SW_EXCEPTION) + */ +static void cf_check vmx_inject_event(const struct x86_event *event) { - const struct vcpu *curr = current; - struct domain *d = v->domain; - const struct vcpu_msrs *msrs = v->arch.msrs; - uint64_t val = 0; - int rc; + unsigned long intr_info; + struct vcpu *curr = current; + struct x86_event _event = *event; - /* Logic which doesn't require remote VMCS acquisition. */ - switch ( reg ) + switch ( _event.vector | -(_event.type == X86_EVENTTYPE_SW_INTERRUPT) ) { - case MSR_SPEC_CTRL: - rc = vmx_read_guest_msr(v, reg, &val); - if ( rc ) + case TRAP_debug: + if ( guest_cpu_user_regs()->eflags & X86_EFLAGS_TF ) { - printk(XENLOG_G_ERR "%s(%pv, 0x%08x) MSR list error: %d\n", - __func__, v, reg, rc); - domain_crash(d); + __restore_debug_registers(curr); + write_debugreg(6, read_debugreg(6) | DR_STEP); } - return val; + if ( !nestedhvm_vcpu_in_guestmode(curr) || + !nvmx_intercepts_exception(curr, TRAP_debug, _event.error_code) ) + { + unsigned long val; - case MSR_PKRS: - return (v == curr) ? rdpkrs() : msrs->pkrs; + __vmread(GUEST_DR7, &val); + __vmwrite(GUEST_DR7, val & ~DR_GENERAL_DETECT); + __vmread(GUEST_IA32_DEBUGCTL, &val); + __vmwrite(GUEST_IA32_DEBUGCTL, val & ~IA32_DEBUGCTLMSR_LBR); + } + if ( cpu_has_monitor_trap_flag ) + break; + /* fall through */ + case TRAP_int3: + if ( curr->domain->debugger_attached ) + { + /* Debug/Int3: Trap to debugger. */ + domain_pause_for_debugger(); + return; + } + break; - case MSR_SHADOW_GS_BASE: - if ( v != curr ) - return v->arch.hvm.vmx.shadow_gs; - rdmsrl(MSR_SHADOW_GS_BASE, val); - return val; + case TRAP_page_fault: + ASSERT(_event.type == X86_EVENTTYPE_HW_EXCEPTION); + curr->arch.hvm.guest_cr[2] = _event.cr2; + break; } - /* Logic which maybe requires remote VMCS acquisition. */ - vmx_vmcs_enter(v); - switch ( reg ) + if ( nestedhvm_vcpu_in_guestmode(curr) ) + intr_info = vcpu_2_nvmx(curr).intr.intr_info; + else + __vmread(VM_ENTRY_INTR_INFO, &intr_info); + + if ( unlikely(intr_info & INTR_INFO_VALID_MASK) && + (MASK_EXTR(intr_info, INTR_INFO_INTR_TYPE_MASK) == + X86_EVENTTYPE_HW_EXCEPTION) ) { - case MSR_IA32_BNDCFGS: - __vmread(GUEST_BNDCFGS, &val); - break; + _event.vector = hvm_combine_hw_exceptions( + (uint8_t)intr_info, _event.vector); + if ( _event.vector == TRAP_double_fault ) + _event.error_code = 0; + } - default: - printk(XENLOG_G_ERR "%s(%pv, 0x%08x) Bad register\n", - __func__, v, reg); - domain_crash(d); - break; + if ( _event.type >= X86_EVENTTYPE_SW_INTERRUPT ) + __vmwrite(VM_ENTRY_INSTRUCTION_LEN, _event.insn_len); + + if ( nestedhvm_vcpu_in_guestmode(curr) && + nvmx_intercepts_exception(curr, _event.vector, _event.error_code) ) + { + nvmx_enqueue_n2_exceptions (curr, + INTR_INFO_VALID_MASK | + MASK_INSR(_event.type, INTR_INFO_INTR_TYPE_MASK) | + MASK_INSR(_event.vector, INTR_INFO_VECTOR_MASK), + _event.error_code, hvm_intsrc_none); + return; } - vmx_vmcs_exit(v); + else + __vmx_inject_exception(_event.vector, _event.type, _event.error_code); - return val; + if ( (_event.vector == TRAP_page_fault) && + (_event.type == X86_EVENTTYPE_HW_EXCEPTION) ) + HVMTRACE_LONG_2D(PF_INJECT, _event.error_code, + TRC_PAR_LONG(curr->arch.hvm.guest_cr[2])); + else + HVMTRACE_2D(INJ_EXC, _event.vector, _event.error_code); } -static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) +static bool cf_check vmx_event_pending(const struct vcpu *v) { - const struct vcpu *curr = current; - struct vcpu_msrs *msrs = v->arch.msrs; - struct domain *d = v->domain; - int rc; + unsigned long intr_info; - /* Logic which doesn't require remote VMCS acquisition. */ - switch ( reg ) - { - case MSR_SPEC_CTRL: - rc = vmx_write_guest_msr(v, reg, val); - if ( rc ) - { - printk(XENLOG_G_ERR "%s(%pv, 0x%08x) MSR list error: %d\n", - __func__, v, reg, rc); - domain_crash(d); - } - return; + ASSERT(v == current); + __vmread(VM_ENTRY_INTR_INFO, &intr_info); - case MSR_PKRS: - msrs->pkrs = val; - if ( v == curr ) - wrpkrs(val); - return; - } + return intr_info & INTR_INFO_VALID_MASK; +} + +static void cf_check vmx_set_info_guest(struct vcpu *v) +{ + unsigned long intr_shadow; - /* Logic which maybe requires remote VMCS acquisition. */ vmx_vmcs_enter(v); - switch ( reg ) - { - case MSR_IA32_BNDCFGS: - __vmwrite(GUEST_BNDCFGS, val); - break; - default: - printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\n", - __func__, v, reg, val); - domain_crash(d); + __vmwrite(GUEST_DR7, v->arch.dr7); + + /* + * If the interruptibility-state field indicates blocking by STI, + * setting the TF flag in the EFLAGS may cause VM entry to fail + * and crash the guest. See SDM 3B 22.3.1.5. + * Resetting the VMX_INTR_SHADOW_STI flag looks hackish but + * to set the GUEST_PENDING_DBG_EXCEPTIONS.BS here incurs + * immediately vmexit and hence make no progress. + */ + __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); + if ( v->domain->debugger_attached && + (v->arch.user_regs.eflags & X86_EFLAGS_TF) && + (intr_shadow & VMX_INTR_SHADOW_STI) ) + { + intr_shadow &= ~VMX_INTR_SHADOW_STI; + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, intr_shadow); } + vmx_vmcs_exit(v); } -static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { - .name = "VMX", - .cpu_up_prepare = vmx_cpu_up_prepare, - .cpu_dead = vmx_cpu_dead, - .domain_initialise = vmx_domain_initialise, - .domain_relinquish_resources = vmx_domain_relinquish_resources, - .domain_creation_finished = domain_creation_finished, - .vcpu_initialise = vmx_vcpu_initialise, - .vcpu_destroy = vmx_vcpu_destroy, - .save_cpu_ctxt = vmx_save_vmcs_ctxt, - .load_cpu_ctxt = vmx_load_vmcs_ctxt, - .get_interrupt_shadow = vmx_get_interrupt_shadow, - .set_interrupt_shadow = vmx_set_interrupt_shadow, - .get_nonreg_state = vmx_get_nonreg_state, - .set_nonreg_state = vmx_set_nonreg_state, - .guest_x86_mode = vmx_guest_x86_mode, - .get_cpl = _vmx_get_cpl, - .get_segment_register = vmx_get_segment_register, - .set_segment_register = vmx_set_segment_register, - .update_host_cr3 = vmx_update_host_cr3, - .update_guest_cr = vmx_update_guest_cr, - .update_guest_efer = vmx_update_guest_efer, - .cpuid_policy_changed = vmx_cpuid_policy_changed, - .fpu_leave = vmx_fpu_leave, - .set_guest_pat = vmx_set_guest_pat, - .get_guest_pat = vmx_get_guest_pat, - .set_tsc_offset = vmx_set_tsc_offset, - .inject_event = vmx_inject_event, - .init_hypercall_page = vmx_init_hypercall_page, - .event_pending = vmx_event_pending, - .get_pending_event = vmx_get_pending_event, - .invlpg = vmx_invlpg, - .cpu_up = vmx_cpu_up, - .cpu_down = vmx_cpu_down, - .wbinvd_intercept = vmx_wbinvd_intercept, - .fpu_dirty_intercept = vmx_fpu_dirty_intercept, - .msr_read_intercept = vmx_msr_read_intercept, - .msr_write_intercept = vmx_msr_write_intercept, - .handle_cd = vmx_handle_cd, - .set_info_guest = vmx_set_info_guest, - .set_rdtsc_exiting = vmx_set_rdtsc_exiting, - .nhvm_vcpu_initialise = nvmx_vcpu_initialise, - .nhvm_vcpu_destroy = nvmx_vcpu_destroy, - .nhvm_vcpu_reset = nvmx_vcpu_reset, - .nhvm_vcpu_p2m_base = nvmx_vcpu_eptp_base, - .nhvm_vmcx_hap_enabled = nvmx_ept_enabled, - .nhvm_vmcx_guest_intercepts_event = nvmx_intercepts_exception, - .nhvm_vcpu_vmexit_event = nvmx_vmexit_event, - .nhvm_intr_blocked = nvmx_intr_blocked, - .nhvm_domain_relinquish_resources = nvmx_domain_relinquish_resources, - .update_vlapic_mode = vmx_vlapic_msr_changed, - .nhvm_hap_walk_L1_p2m = nvmx_hap_walk_L1_p2m, - .enable_msr_interception = vmx_enable_msr_interception, - .altp2m_vcpu_update_p2m = vmx_vcpu_update_eptp, - .altp2m_vcpu_update_vmfunc_ve = vmx_vcpu_update_vmfunc_ve, - .altp2m_vcpu_emulate_ve = vmx_vcpu_emulate_ve, - .altp2m_vcpu_emulate_vmfunc = vmx_vcpu_emulate_vmfunc, - .vmtrace_control = vmtrace_control, - .vmtrace_output_position = vmtrace_output_position, - .vmtrace_set_option = vmtrace_set_option, - .vmtrace_get_option = vmtrace_get_option, - .vmtrace_reset = vmtrace_reset, - - .get_reg = vmx_get_reg, - .set_reg = vmx_set_reg, - - .tsc_scaling = { - .max_ratio = VMX_TSC_MULTIPLIER_MAX, - }, -}; - -/* Handle VT-d posted-interrupt when VCPU is blocked. */ -static void cf_check pi_wakeup_interrupt(struct cpu_user_regs *regs) +static void cf_check vmx_update_eoi_exit_bitmap( + struct vcpu *v, uint8_t vector, bool set) { - struct vmx_vcpu *vmx, *tmp; - spinlock_t *lock = &per_cpu(vmx_pi_blocking, smp_processor_id()).lock; - struct list_head *blocked_vcpus = - &per_cpu(vmx_pi_blocking, smp_processor_id()).list; + if ( set ) + vmx_set_eoi_exit_bitmap(v, vector); + else + vmx_clear_eoi_exit_bitmap(v, vector); +} - ack_APIC_irq(); - this_cpu(irq_count)++; +static u8 set_svi(int isr) +{ + unsigned long status; + u8 old; - spin_lock(lock); + if ( isr < 0 ) + isr = 0; - /* - * XXX: The length of the list depends on how many vCPU is current - * blocked on this specific pCPU. This may hurt the interrupt latency - * if the list grows to too many entries. - */ - list_for_each_entry_safe(vmx, tmp, blocked_vcpus, pi_blocking.list) + __vmread(GUEST_INTR_STATUS, &status); + old = status >> VMX_GUEST_INTR_STATUS_SVI_OFFSET; + if ( isr != old ) { - if ( pi_test_on(&vmx->pi_desc) ) - { - list_del(&vmx->pi_blocking.list); - ASSERT(vmx->pi_blocking.lock == lock); - vmx->pi_blocking.lock = NULL; - vcpu_unblock(container_of(vmx, struct vcpu, arch.hvm.vmx)); - } + status &= VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK; + status |= isr << VMX_GUEST_INTR_STATUS_SVI_OFFSET; + __vmwrite(GUEST_INTR_STATUS, status); } - spin_unlock(lock); + return old; } -/* Handle VT-d posted-interrupt when VCPU is running. */ -static void cf_check pi_notification_interrupt(struct cpu_user_regs *regs) +static void cf_check vmx_process_isr(int isr, struct vcpu *v) { - ack_APIC_irq(); - this_cpu(irq_count)++; - - /* - * We get here when a vCPU is running in root-mode (such as via hypercall, - * or any other reasons which can result in VM-Exit), and before vCPU is - * back to non-root, external interrupts from an assigned device happen - * and a notification event is delivered to this logical CPU. - * - * we need to set VCPU_KICK_SOFTIRQ for the current cpu, just like - * __vmx_deliver_posted_interrupt(). So the pending interrupt in PIRR will - * be synced to vIRR before VM-Exit in time. - * - * Please refer to the following code fragments from - * xen/arch/x86/hvm/vmx/entry.S: - * - * .Lvmx_do_vmentry - * - * ...... - * - * point 1 - * - * cli - * cmp %ecx,(%rdx,%rax,1) - * jnz .Lvmx_process_softirqs - * - * ...... - * - * je .Lvmx_launch - * - * ...... - * - * .Lvmx_process_softirqs: - * sti - * call do_softirq - * jmp .Lvmx_do_vmentry - * - * If VT-d engine issues a notification event at point 1 above, it cannot - * be delivered to the guest during this VM-entry without raising the - * softirq in this notification handler. - */ - raise_softirq(VCPU_KICK_SOFTIRQ); -} + unsigned int i; + const struct vlapic *vlapic = vcpu_vlapic(v); -static void __init lbr_tsx_fixup_check(void); -static void __init ler_to_fixup_check(void); + vmx_vmcs_enter(v); -/* - * Calculate whether the CPU is vulnerable to Instruction Fetch page - * size-change MCEs. - */ -static bool __init has_if_pschange_mc(void) -{ - uint64_t caps = 0; + set_svi(isr); /* - * If we are virtualised, there is nothing we can do. Our EPT tables are - * shadowed by our hypervisor, and not walked by hardware. + * Theoretically, only level triggered interrupts can have their + * corresponding bits set in the eoi exit bitmap. That is, the bits + * set in the eoi exit bitmap should also be set in TMR. But a periodic + * timer interrupt does not follow the rule: it is edge triggered, but + * requires its corresponding bit be set in the eoi exit bitmap. So we + * should not construct the eoi exit bitmap based on TMR. + * Here we will construct the eoi exit bitmap via (IRR | ISR). This + * means that EOIs to the interrupts that are set in the IRR or ISR will + * cause VM exits after restoring, regardless of the trigger modes. It + * is acceptable because the subsequent interrupts will set up the eoi + * bitmap correctly. */ - if ( cpu_has_hypervisor ) - return false; + for ( i = 0x10; i < X86_NR_VECTORS; ++i ) + if ( vlapic_test_vector(i, &vlapic->regs->data[APIC_IRR]) || + vlapic_test_vector(i, &vlapic->regs->data[APIC_ISR]) ) + set_bit(i, v->arch.hvm.vmx.eoi_exit_bitmap); - if ( cpu_has_arch_caps ) - rdmsrl(MSR_ARCH_CAPABILITIES, caps); + for ( i = 0; i < ARRAY_SIZE(v->arch.hvm.vmx.eoi_exit_bitmap); ++i ) + __vmwrite(EOI_EXIT_BITMAP(i), v->arch.hvm.vmx.eoi_exit_bitmap[i]); - if ( caps & ARCH_CAPS_IF_PSCHANGE_MC_NO ) - return false; + vmx_vmcs_exit(v); +} + +static void __vmx_deliver_posted_interrupt(struct vcpu *v) +{ + bool_t running = v->is_running; + vcpu_unblock(v); /* - * IF_PSCHANGE_MC is only known to affect Intel Family 6 processors at - * this time. + * Just like vcpu_kick(), nothing is needed for the following two cases: + * 1. The target vCPU is not running, meaning it is blocked or runnable. + * 2. The target vCPU is the current vCPU and we're in non-interrupt + * context. */ - if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || - boot_cpu_data.x86 != 6 ) - return false; - - switch ( boot_cpu_data.x86_model ) + if ( running && (in_irq() || (v != current)) ) { /* - * Core processors since at least Nehalem are vulnerable. + * Note: Only two cases will reach here: + * 1. The target vCPU is running on other pCPU. + * 2. The target vCPU is the current vCPU. + * + * Note2: Don't worry the v->processor may change. The vCPU being + * moved to another processor is guaranteed to sync PIR to vIRR, + * due to the involved scheduling cycle. */ - case 0x1f: /* Auburndale / Havendale */ - case 0x1e: /* Nehalem */ - case 0x1a: /* Nehalem EP */ - case 0x2e: /* Nehalem EX */ - case 0x25: /* Westmere */ - case 0x2c: /* Westmere EP */ - case 0x2f: /* Westmere EX */ - case 0x2a: /* SandyBridge */ - case 0x2d: /* SandyBridge EP/EX */ - case 0x3a: /* IvyBridge */ - case 0x3e: /* IvyBridge EP/EX */ - case 0x3c: /* Haswell */ - case 0x3f: /* Haswell EX/EP */ - case 0x45: /* Haswell D */ - case 0x46: /* Haswell H */ - case 0x3d: /* Broadwell */ - case 0x47: /* Broadwell H */ - case 0x4f: /* Broadwell EP/EX */ - case 0x56: /* Broadwell D */ - case 0x4e: /* Skylake M */ - case 0x5e: /* Skylake D */ - case 0x55: /* Skylake-X / Cascade Lake */ - case 0x7d: /* Ice Lake */ - case 0x7e: /* Ice Lake */ - case 0x8e: /* Kaby / Coffee / Whiskey Lake M */ - case 0x9e: /* Kaby / Coffee / Whiskey Lake D */ - case 0xa5: /* Comet Lake H/S */ - case 0xa6: /* Comet Lake U */ - return true; + unsigned int cpu = v->processor; /* - * Atom processors are not vulnerable. + * For case 1, we send an IPI to the pCPU. When an IPI arrives, the + * target vCPU maybe is running in non-root mode, running in root + * mode, runnable or blocked. If the target vCPU is running in + * non-root mode, the hardware will sync PIR to vIRR for + * 'posted_intr_vector' is special to the pCPU. If the target vCPU is + * running in root-mode, the interrupt handler starts to run. + * Considering an IPI may arrive in the window between the call to + * vmx_intr_assist() and interrupts getting disabled, the interrupt + * handler should raise a softirq to ensure events will be delivered + * in time. If the target vCPU is runnable, it will sync PIR to + * vIRR next time it is chose to run. In this case, a IPI and a + * softirq is sent to a wrong vCPU which will not have any adverse + * effect. If the target vCPU is blocked, since vcpu_block() checks + * whether there is an event to be delivered through + * local_events_need_delivery() just after blocking, the vCPU must + * have synced PIR to vIRR. Similarly, there is a IPI and a softirq + * sent to a wrong vCPU. */ - case 0x1c: /* Pineview */ - case 0x26: /* Lincroft */ - case 0x27: /* Penwell */ - case 0x35: /* Cloverview */ - case 0x36: /* Cedarview */ - case 0x37: /* Baytrail / Valleyview (Silvermont) */ - case 0x4d: /* Avaton / Rangely (Silvermont) */ - case 0x4c: /* Cherrytrail / Brasswell */ - case 0x4a: /* Merrifield */ - case 0x5a: /* Moorefield */ - case 0x5c: /* Goldmont */ - case 0x5d: /* SoFIA 3G Granite/ES2.1 */ - case 0x65: /* SoFIA LTE AOSP */ - case 0x5f: /* Denverton */ - case 0x6e: /* Cougar Mountain */ - case 0x75: /* Lightning Mountain */ - case 0x7a: /* Gemini Lake */ - case 0x86: /* Jacobsville */ - + if ( cpu != smp_processor_id() ) + send_IPI_mask(cpumask_of(cpu), posted_intr_vector); /* - * Knights processors are not vulnerable. + * For case 2, raising a softirq ensures PIR will be synced to vIRR. + * As any softirq will do, as an optimization we only raise one if + * none is pending already. */ - case 0x57: /* Knights Landing */ - case 0x85: /* Knights Mill */ - return false; - - default: - printk("Unrecognised CPU model %#x - assuming vulnerable to IF_PSCHANGE_MC\n", - boot_cpu_data.x86_model); - return true; + else if ( !softirq_pending(cpu) ) + raise_softirq(VCPU_KICK_SOFTIRQ); } } -const struct hvm_function_table * __init start_vmx(void) +static void cf_check vmx_deliver_posted_intr(struct vcpu *v, u8 vector) { - set_in_cr4(X86_CR4_VMXE); + struct pi_desc old, new, prev; - if ( vmx_vmcs_init() ) + if ( pi_test_and_set_pir(vector, &v->arch.hvm.vmx.pi_desc) ) + return; + + if ( unlikely(v->arch.hvm.vmx.eoi_exitmap_changed) ) { - printk("VMX: failed to initialise.\n"); - return NULL; + /* + * If EOI exitbitmap needs to changed or notification vector + * can't be allocated, interrupt will not be injected till + * VMEntry as it used to be. + */ + pi_set_on(&v->arch.hvm.vmx.pi_desc); + vcpu_kick(v); + return; } - vmx_function_table.singlestep_supported = cpu_has_monitor_trap_flag; + prev.control = v->arch.hvm.vmx.pi_desc.control; + + do { + /* + * Currently, we don't support urgent interrupt, all + * interrupts are recognized as non-urgent interrupt, + * Besides that, if 'ON' is already set, no need to + * send posted-interrupts notification event as well, + * according to hardware behavior. + */ + if ( pi_test_sn(&prev) || pi_test_on(&prev) ) + { + vcpu_kick(v); + return; + } + + old.control = v->arch.hvm.vmx.pi_desc.control & + ~((1 << POSTED_INTR_ON) | (1 << POSTED_INTR_SN)); + new.control = v->arch.hvm.vmx.pi_desc.control | + (1 << POSTED_INTR_ON); + + prev.control = cmpxchg(&v->arch.hvm.vmx.pi_desc.control, + old.control, new.control); + } while ( prev.control != old.control ); + + __vmx_deliver_posted_interrupt(v); +} - if ( cpu_has_vmx_dt_exiting ) - vmx_function_table.set_descriptor_access_exiting = - vmx_set_descriptor_access_exiting; +static void cf_check vmx_sync_pir_to_irr(struct vcpu *v) +{ + struct vlapic *vlapic = vcpu_vlapic(v); + unsigned int group, i; + DECLARE_BITMAP(pending_intr, X86_NR_VECTORS); - /* - * Do not enable EPT when (!cpu_has_vmx_pat), to prevent security hole - * (refer to https://xenbits.xen.org/xsa/advisory-60.html). - */ - if ( cpu_has_vmx_ept && (cpu_has_vmx_pat || opt_force_ept) ) - { - bool cpu_has_bug_pschange_mc = has_if_pschange_mc(); + if ( !pi_test_and_clear_on(&v->arch.hvm.vmx.pi_desc) ) + return; - if ( opt_ept_exec_sp == -1 ) - { - /* Default to non-executable superpages on vulnerable hardware. */ - opt_ept_exec_sp = !cpu_has_bug_pschange_mc; + for ( group = 0; group < ARRAY_SIZE(pending_intr); group++ ) + pending_intr[group] = pi_get_pir(&v->arch.hvm.vmx.pi_desc, group); - if ( cpu_has_bug_pschange_mc ) - printk("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n"); - } + for_each_set_bit(i, pending_intr, X86_NR_VECTORS) + vlapic_set_vector(i, &vlapic->regs->data[APIC_IRR]); +} - vmx_function_table.hap_supported = 1; - vmx_function_table.altp2m_supported = 1; +static bool cf_check vmx_test_pir(const struct vcpu *v, uint8_t vec) +{ + return pi_test_pir(vec, &v->arch.hvm.vmx.pi_desc); +} - vmx_function_table.hap_capabilities = 0; +static void cf_check vmx_handle_eoi(uint8_t vector, int isr) +{ + uint8_t old_svi = set_svi(isr); + static bool warned; - if ( cpu_has_vmx_ept_2mb ) - vmx_function_table.hap_capabilities |= HVM_HAP_SUPERPAGE_2MB; - if ( cpu_has_vmx_ept_1gb ) - vmx_function_table.hap_capabilities |= HVM_HAP_SUPERPAGE_1GB; + if ( vector != old_svi && !test_and_set_bool(warned) ) + printk(XENLOG_WARNING "EOI for %02x but SVI=%02x\n", vector, old_svi); +} - setup_ept_dump(); - } +static void cf_check vmx_enable_msr_interception(struct domain *d, uint32_t msr) +{ + struct vcpu *v; - if ( cpu_has_vmx_virtual_intr_delivery ) - { - vmx_function_table.update_eoi_exit_bitmap = vmx_update_eoi_exit_bitmap; - vmx_function_table.process_isr = vmx_process_isr; - vmx_function_table.handle_eoi = vmx_handle_eoi; - vmx_function_table.virtual_intr_delivery_enabled = true; - } + for_each_vcpu ( d, v ) + vmx_set_msr_intercept(v, msr, VMX_MSR_W); +} - if ( cpu_has_vmx_posted_intr_processing ) - { - alloc_direct_apic_vector(&posted_intr_vector, pi_notification_interrupt); - if ( iommu_intpost ) - { - alloc_direct_apic_vector(&pi_wakeup_vector, pi_wakeup_interrupt); +static void cf_check vmx_vcpu_update_eptp(struct vcpu *v) +{ + struct domain *d = v->domain; + struct p2m_domain *p2m = NULL; + struct ept_data *ept; - vmx_function_table.pi_update_irte = vmx_pi_update_irte; - } + if ( altp2m_active(d) ) + p2m = p2m_get_altp2m(v); + if ( !p2m ) + p2m = p2m_get_hostp2m(d); - vmx_function_table.deliver_posted_intr = vmx_deliver_posted_intr; - vmx_function_table.sync_pir_to_irr = vmx_sync_pir_to_irr; - vmx_function_table.test_pir = vmx_test_pir; - } + ept = &p2m->ept; + ept->mfn = pagetable_get_pfn(p2m_get_pagetable(p2m)); - if ( cpu_has_vmx_tsc_scaling ) - { - vmx_function_table.tsc_scaling.ratio_frac_bits = 48; - vmx_function_table.tsc_scaling.setup = vmx_setup_tsc_scaling; - } + vmx_vmcs_enter(v); - model_specific_lbr = get_model_specific_lbr(); - lbr_tsx_fixup_check(); - ler_to_fixup_check(); + __vmwrite(EPT_POINTER, ept->eptp); - return &vmx_function_table; + if ( v->arch.hvm.vmx.secondary_exec_control & + SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS ) + __vmwrite(EPTP_INDEX, vcpu_altp2m(v).p2midx); + + vmx_vmcs_exit(v); } -/* - * Not all cases receive valid value in the VM-exit instruction length field. - * Callers must know what they're doing! - */ -static int get_instruction_length(void) +static void cf_check vmx_vcpu_update_vmfunc_ve(struct vcpu *v) { - unsigned long len; + struct domain *d = v->domain; + u32 mask = SECONDARY_EXEC_ENABLE_VM_FUNCTIONS; - __vmread(VM_EXIT_INSTRUCTION_LEN, &len); /* Safe: callers audited */ - BUG_ON((len < 1) || (len > MAX_INST_LEN)); - return len; -} + if ( !cpu_has_vmx_vmfunc ) + return; -void update_guest_eip(void) -{ - struct cpu_user_regs *regs = guest_cpu_user_regs(); - unsigned long x; + if ( cpu_has_vmx_virt_exceptions ) + mask |= SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS; - regs->rip += get_instruction_length(); /* Safe: callers audited */ - regs->eflags &= ~X86_EFLAGS_RF; + vmx_vmcs_enter(v); - __vmread(GUEST_INTERRUPTIBILITY_INFO, &x); - if ( x & (VMX_INTR_SHADOW_STI | VMX_INTR_SHADOW_MOV_SS) ) + if ( !d->is_dying && altp2m_active(d) ) { - x &= ~(VMX_INTR_SHADOW_STI | VMX_INTR_SHADOW_MOV_SS); - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, x); + v->arch.hvm.vmx.secondary_exec_control |= mask; + __vmwrite(VM_FUNCTION_CONTROL, VMX_VMFUNC_EPTP_SWITCHING); + __vmwrite(EPTP_LIST_ADDR, virt_to_maddr(d->arch.altp2m_visible_eptp)); + + if ( cpu_has_vmx_virt_exceptions ) + { + const struct page_info *pg = vcpu_altp2m(v).veinfo_pg; + + if ( pg ) + { + __vmwrite(VIRT_EXCEPTION_INFO, page_to_maddr(pg)); + /* + * Make sure we have an up-to-date EPTP_INDEX when + * setting SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS. + */ + __vmwrite(EPTP_INDEX, vcpu_altp2m(v).p2midx); + } + else + v->arch.hvm.vmx.secondary_exec_control &= + ~SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS; + } } + else + v->arch.hvm.vmx.secondary_exec_control &= ~mask; - if ( regs->eflags & X86_EFLAGS_TF ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + vmx_update_secondary_exec_control(v); + vmx_vmcs_exit(v); } -static void cf_check vmx_fpu_dirty_intercept(void) +static int cf_check vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs) { + int rc = X86EMUL_EXCEPTION; struct vcpu *curr = current; - vmx_fpu_enter(curr); + if ( !cpu_has_vmx_vmfunc && altp2m_active(curr->domain) && + regs->eax == 0 && + p2m_switch_vcpu_altp2m_by_id(curr, regs->ecx) ) + rc = X86EMUL_OKAY; - /* Disable TS in guest CR0 unless the guest wants the exception too. */ - if ( !(curr->arch.hvm.guest_cr[0] & X86_CR0_TS) ) - { - curr->arch.hvm.hw_cr[0] &= ~X86_CR0_TS; - __vmwrite(GUEST_CR0, curr->arch.hvm.hw_cr[0]); - } + return rc; } -static void vmx_dr_access(unsigned long exit_qualification, - struct cpu_user_regs *regs) +static bool cf_check vmx_vcpu_emulate_ve(struct vcpu *v) { - struct vcpu *v = current; + const struct page_info *pg = vcpu_altp2m(v).veinfo_pg; + ve_info_t *veinfo; + bool rc = false; - HVMTRACE_0D(DR_WRITE); + if ( !pg ) + return rc; - if ( !v->arch.hvm.flag_dr_dirty ) - __restore_debug_registers(v); + veinfo = __map_domain_page(pg); - /* Allow guest direct access to DR registers */ - v->arch.hvm.vmx.exec_control &= ~CPU_BASED_MOV_DR_EXITING; - vmx_update_cpu_exec_control(v); -} + if ( veinfo->semaphore != 0 ) + goto out; -static void vmx_invlpg_intercept(unsigned long linear) -{ - HVMTRACE_LONG_2D(INVLPG, /*invlpga=*/ 0, TRC_PAR_LONG(linear)); - paging_invlpg(current, linear); -} + rc = true; + veinfo->exit_reason = EXIT_REASON_EPT_VIOLATION; + veinfo->semaphore = ~0; + veinfo->eptp_index = vcpu_altp2m(v).p2midx; -static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear) -{ - if ( cpu_has_vmx_vpid ) - vpid_sync_vcpu_gva(v, linear); -} + vmx_vmcs_enter(v); + __vmread(EXIT_QUALIFICATION, &veinfo->exit_qualification); + __vmread(GUEST_LINEAR_ADDRESS, &veinfo->gla); + __vmread(GUEST_PHYSICAL_ADDRESS, &veinfo->gpa); + vmx_vmcs_exit(v); -static int vmx_vmfunc_intercept(struct cpu_user_regs *regs) -{ - /* - * This handler is a placeholder for future where Xen may - * want to handle VMFUNC exits and resume a domain normally without - * injecting a #UD to the guest - for example, in a VT-nested - * scenario where Xen may want to lazily shadow the alternate - * EPTP list. - */ - gdprintk(XENLOG_ERR, "Failed guest VMFUNC execution\n"); - return X86EMUL_EXCEPTION; + hvm_inject_hw_exception(TRAP_virtualisation, + X86_EVENT_NO_EC); + + out: + unmap_domain_page(veinfo); + + if ( rc ) + paging_mark_dirty(v->domain, page_to_mfn(pg)); + + return rc; } -static int vmx_cr_access(cr_access_qual_t qual) +static bool cf_check vmx_get_pending_event( + struct vcpu *v, struct x86_event *info) { - struct vcpu *curr = current; + unsigned long intr_info, error_code; - switch ( qual.access_type ) - { - case VMX_CR_ACCESS_TYPE_MOV_TO_CR: - return hvm_mov_to_cr(qual.cr, qual.gpr); + vmx_vmcs_enter(v); + __vmread(VM_ENTRY_INTR_INFO, &intr_info); + __vmread(VM_ENTRY_EXCEPTION_ERROR_CODE, &error_code); + vmx_vmcs_exit(v); - case VMX_CR_ACCESS_TYPE_MOV_FROM_CR: - return hvm_mov_from_cr(qual.cr, qual.gpr); + if ( !(intr_info & INTR_INFO_VALID_MASK) ) + return false; + + info->vector = MASK_EXTR(intr_info, INTR_INFO_VECTOR_MASK); + info->type = MASK_EXTR(intr_info, INTR_INFO_INTR_TYPE_MASK); + info->error_code = error_code; - case VMX_CR_ACCESS_TYPE_CLTS: - { - unsigned long old = curr->arch.hvm.guest_cr[0]; - unsigned long value = old & ~X86_CR0_TS; + return true; +} - /* - * Special case unlikely to be interesting to a - * VM_EVENT_FLAG_DENY-capable application, so the hvm_monitor_crX() - * return value is ignored for now. - */ - hvm_monitor_crX(CR0, value, old); - curr->arch.hvm.guest_cr[0] = value; - vmx_update_guest_cr(curr, 0, 0); - HVMTRACE_0D(CLTS); - break; - } +/* + * We only let vmtrace agents see and modify a subset of bits in MSR_RTIT_CTL. + * These all pertain to data-emitted into the trace buffer(s). Must not + * include controls pertaining to the structure/position of the trace + * buffer(s). + */ +#define RTIT_CTL_MASK \ + (RTIT_CTL_TRACE_EN | RTIT_CTL_OS | RTIT_CTL_USR | RTIT_CTL_TSC_EN | \ + RTIT_CTL_DIS_RETC | RTIT_CTL_BRANCH_EN) - case VMX_CR_ACCESS_TYPE_LMSW: - { - unsigned long value = curr->arch.hvm.guest_cr[0]; - int rc; +/* + * Status bits restricted to the first-gen subset (i.e. no further CPUID + * requirements.) + */ +#define RTIT_STATUS_MASK \ + (RTIT_STATUS_FILTER_EN | RTIT_STATUS_CONTEXT_EN | RTIT_STATUS_TRIGGER_EN | \ + RTIT_STATUS_ERROR | RTIT_STATUS_STOPPED) - /* LMSW can (1) set PE; (2) set or clear MP, EM, and TS. */ - value = (value & ~(X86_CR0_MP|X86_CR0_EM|X86_CR0_TS)) | - (qual.lmsw_data & - (X86_CR0_PE|X86_CR0_MP|X86_CR0_EM|X86_CR0_TS)); - HVMTRACE_LONG_1D(LMSW, value); +static int cf_check vmtrace_get_option( + struct vcpu *v, uint64_t key, uint64_t *output) +{ + const struct vcpu_msrs *msrs = v->arch.msrs; - if ( (rc = hvm_set_cr0(value, true)) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + switch ( key ) + { + case MSR_RTIT_CTL: + *output = msrs->rtit.ctl & RTIT_CTL_MASK; + break; - return rc; - } + case MSR_RTIT_STATUS: + *output = msrs->rtit.status & RTIT_STATUS_MASK; + break; default: - ASSERT_UNREACHABLE(); - return X86EMUL_UNHANDLEABLE; + *output = 0; + return -EINVAL; } - - return X86EMUL_OKAY; + return 0; } -enum +static int cf_check vmtrace_set_option( + struct vcpu *v, uint64_t key, uint64_t value) { - LBR_FORMAT_32 = 0x0, /* 32-bit record format */ - LBR_FORMAT_LIP = 0x1, /* 64-bit LIP record format */ - LBR_FORMAT_EIP = 0x2, /* 64-bit EIP record format */ - LBR_FORMAT_EIP_FLAGS = 0x3, /* 64-bit EIP, Flags */ - LBR_FORMAT_EIP_FLAGS_TSX = 0x4, /* 64-bit EIP, Flags, TSX */ - LBR_FORMAT_EIP_FLAGS_TSX_INFO = 0x5, /* 64-bit EIP, Flags, TSX, LBR_INFO */ - LBR_FORMAT_EIP_FLAGS_CYCLES = 0x6, /* 64-bit EIP, Flags, Cycles */ - LBR_FORMAT_LIP_FLAGS_TSX_INFO = 0x7, /* 64-bit LIP, Flags, TSX, LBR_INFO */ -}; - -#define LBR_FROM_SIGNEXT_2MSB ((1ULL << 59) | (1ULL << 60)) - -#define LBR_MSRS_INSERTED (1u << 0) -#define LBR_FIXUP_TSX (1u << 1) -#define LBR_FIXUP_LER_TO (1u << 2) -#define LBR_FIXUP_MASK (LBR_FIXUP_TSX | LBR_FIXUP_LER_TO) + struct vcpu_msrs *msrs = v->arch.msrs; + bool new_en, old_en = msrs->rtit.ctl & RTIT_CTL_TRACE_EN; -static bool __read_mostly lbr_tsx_fixup_needed; -static bool __read_mostly ler_to_fixup_needed; + switch ( key ) + { + case MSR_RTIT_CTL: + if ( value & ~RTIT_CTL_MASK ) + return -EINVAL; -static void __init lbr_tsx_fixup_check(void) -{ - uint64_t caps; - uint32_t lbr_format; + msrs->rtit.ctl &= ~RTIT_CTL_MASK; + msrs->rtit.ctl |= (value & RTIT_CTL_MASK); + break; - /* - * Haswell erratum HSM182 et al, Broadwell erratum BDM127 et al: - * - * On processors that do not support Intel Transactional Synchronization - * Extensions (Intel TSX) (CPUID.07H.EBX bits 4 and 11 are both zero), - * writes to MSR_LASTBRANCH_x_FROM_IP (MSR 680H to 68FH) may #GP unless - * bits[62:61] are equal to bit[47]. - * - * Software should sign extend the MSRs. - * - * Experimentally, MSR_LER_FROM_LIP (1DDH) is similarly impacted, so is - * fixed up as well. - */ - if ( cpu_has_hle || cpu_has_rtm || - boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || - boot_cpu_data.x86 != 6 ) - return; + case MSR_RTIT_STATUS: + if ( value & ~RTIT_STATUS_MASK ) + return -EINVAL; - switch ( boot_cpu_data.x86_model ) - { - case 0x3c: /* HSM182, HSD172 - 4th gen Core */ - case 0x3f: /* HSE117 - Xeon E5 v3 */ - case 0x45: /* HSM182 - 4th gen Core */ - case 0x46: /* HSM182, HSD172 - 4th gen Core (GT3) */ - case 0x3d: /* BDM127 - 5th gen Core */ - case 0x47: /* BDD117 - 5th gen Core (GT3) - BDW117 - Xeon E3-1200 v4 */ - case 0x4f: /* BDF85 - Xeon E5-2600 v4 - BDH75 - Core-i7 for LGA2011-v3 Socket - BDX88 - Xeon E7-x800 v4 */ - case 0x56: /* BDE105 - Xeon D-1500 */ + msrs->rtit.status &= ~RTIT_STATUS_MASK; + msrs->rtit.status |= (value & RTIT_STATUS_MASK); break; + default: - return; + return -EINVAL; } - /* - * Fixup is needed only when TSX support is disabled and the address - * format of LBR includes TSX bits 61:62 - */ - if ( !cpu_has_pdcm ) - return; + new_en = msrs->rtit.ctl & RTIT_CTL_TRACE_EN; - rdmsrl(MSR_IA32_PERF_CAPABILITIES, caps); - lbr_format = caps & MSR_IA32_PERF_CAP_LBR_FORMAT; + /* ctl.trace_en changed => update MSR load/save lists appropriately. */ + if ( !old_en && new_en ) + { + if ( vmx_add_guest_msr(v, MSR_RTIT_CTL, msrs->rtit.ctl) || + vmx_add_host_load_msr(v, MSR_RTIT_CTL, 0) ) + { + /* + * The only failure cases here are failing the + * singleton-per-domain memory allocation, or exceeding the space + * in the allocation. We could unwind in principle, but there is + * nothing userspace can usefully do to continue using this VM. + */ + domain_crash(v->domain); + return -ENXIO; + } + } + else if ( old_en && !new_en ) + { + vmx_del_msr(v, MSR_RTIT_CTL, VMX_MSR_GUEST); + vmx_del_msr(v, MSR_RTIT_CTL, VMX_MSR_HOST); + } - if ( lbr_format == LBR_FORMAT_EIP_FLAGS_TSX ) - lbr_tsx_fixup_needed = true; + return 0; } -static void __init ler_to_fixup_check(void) +static int cf_check vmtrace_control(struct vcpu *v, bool enable, bool reset) { + struct vcpu_msrs *msrs = v->arch.msrs; + uint64_t new_ctl; + int rc; + /* - * Broadwell erratum BDF93 et al: - * - * Reads from MSR_LER_TO_LIP (MSR 1DEH) may return values for bits[63:61] - * that are not equal to bit[47]. Attempting to context switch this value - * may cause a #GP. Software should sign extend the MSR. + * Absolutely nothing good will come of Xen's and userspace's idea of + * whether ipt is enabled getting out of sync. */ - if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || - boot_cpu_data.x86 != 6 ) - return; + if ( v->arch.hvm.vmx.ipt_active == enable ) + return -EINVAL; - switch ( boot_cpu_data.x86_model ) + if ( reset ) { - case 0x3d: /* BDM131 - 5th gen Core */ - case 0x47: /* BDD??? - 5th gen Core (H-Processor line) - BDW120 - Xeon E3-1200 v4 */ - case 0x4f: /* BDF93 - Xeon E5-2600 v4 - BDH80 - Core-i7 for LGA2011-v3 Socket - BDX93 - Xeon E7-x800 v4 */ - case 0x56: /* BDE??? - Xeon D-1500 */ - ler_to_fixup_needed = true; - break; + msrs->rtit.status = 0; + msrs->rtit.output_offset = 0; } -} -static int is_last_branch_msr(u32 ecx) -{ - const struct lbr_info *lbr = model_specific_lbr; + new_ctl = msrs->rtit.ctl & ~RTIT_CTL_TRACE_EN; + if ( enable ) + new_ctl |= RTIT_CTL_TRACE_EN; - if ( lbr == NULL ) - return 0; + rc = vmtrace_set_option(v, MSR_RTIT_CTL, new_ctl); + if ( rc ) + return rc; - for ( ; lbr->count; lbr++ ) - if ( (ecx >= lbr->base) && (ecx < (lbr->base + lbr->count)) ) - return 1; + v->arch.hvm.vmx.ipt_active = enable; return 0; } -static int cf_check vmx_msr_read_intercept( - unsigned int msr, uint64_t *msr_content) +static int cf_check vmtrace_output_position(struct vcpu *v, uint64_t *pos) { - struct vcpu *curr = current; - uint64_t tmp; + *pos = v->arch.msrs->rtit.output_offset; + return v->arch.hvm.vmx.ipt_active; +} - HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x", msr); +static int cf_check vmtrace_reset(struct vcpu *v) +{ + if ( !v->arch.hvm.vmx.ipt_active ) + return -EINVAL; - switch ( msr ) - { - case MSR_IA32_SYSENTER_CS: - __vmread(GUEST_SYSENTER_CS, msr_content); - break; - case MSR_IA32_SYSENTER_ESP: - __vmread(GUEST_SYSENTER_ESP, msr_content); - break; - case MSR_IA32_SYSENTER_EIP: - __vmread(GUEST_SYSENTER_EIP, msr_content); - break; + v->arch.msrs->rtit.output_offset = 0; + v->arch.msrs->rtit.status = 0; + return 0; +} - case MSR_FS_BASE: - __vmread(GUEST_FS_BASE, msr_content); - break; +static uint64_t cf_check vmx_get_reg(struct vcpu *v, unsigned int reg) +{ + const struct vcpu *curr = current; + struct domain *d = v->domain; + const struct vcpu_msrs *msrs = v->arch.msrs; + uint64_t val = 0; + int rc; - case MSR_GS_BASE: - __vmread(GUEST_GS_BASE, msr_content); - break; + /* Logic which doesn't require remote VMCS acquisition. */ + switch ( reg ) + { + case MSR_SPEC_CTRL: + rc = vmx_read_guest_msr(v, reg, &val); + if ( rc ) + { + printk(XENLOG_G_ERR "%s(%pv, 0x%08x) MSR list error: %d\n", + __func__, v, reg, rc); + domain_crash(d); + } + return val; + + case MSR_PKRS: + return (v == curr) ? rdpkrs() : msrs->pkrs; case MSR_SHADOW_GS_BASE: - *msr_content = read_gs_shadow(); - break; + if ( v != curr ) + return v->arch.hvm.vmx.shadow_gs; + rdmsrl(MSR_SHADOW_GS_BASE, val); + return val; + } - case MSR_STAR: - *msr_content = curr->arch.hvm.vmx.star; + /* Logic which maybe requires remote VMCS acquisition. */ + vmx_vmcs_enter(v); + switch ( reg ) + { + case MSR_IA32_BNDCFGS: + __vmread(GUEST_BNDCFGS, &val); break; - case MSR_LSTAR: - *msr_content = curr->arch.hvm.vmx.lstar; + default: + printk(XENLOG_G_ERR "%s(%pv, 0x%08x) Bad register\n", + __func__, v, reg); + domain_crash(d); break; + } + vmx_vmcs_exit(v); - case MSR_CSTAR: - *msr_content = curr->arch.hvm.vmx.cstar; - break; + return val; +} - case MSR_SYSCALL_MASK: - *msr_content = curr->arch.hvm.vmx.sfmask; - break; +static void cf_check vmx_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) +{ + const struct vcpu *curr = current; + struct vcpu_msrs *msrs = v->arch.msrs; + struct domain *d = v->domain; + int rc; - case MSR_IA32_DEBUGCTLMSR: - __vmread(GUEST_IA32_DEBUGCTL, msr_content); - break; + /* Logic which doesn't require remote VMCS acquisition. */ + switch ( reg ) + { + case MSR_SPEC_CTRL: + rc = vmx_write_guest_msr(v, reg, val); + if ( rc ) + { + printk(XENLOG_G_ERR "%s(%pv, 0x%08x) MSR list error: %d\n", + __func__, v, reg, rc); + domain_crash(d); + } + return; - case MSR_IA32_VMX_BASIC...MSR_IA32_VMX_VMFUNC: - if ( !nvmx_msr_read_intercept(msr, msr_content) ) - goto gp_fault; - break; - case MSR_IA32_MISC_ENABLE: - rdmsrl(MSR_IA32_MISC_ENABLE, *msr_content); - /* Debug Trace Store is not supported. */ - *msr_content |= MSR_IA32_MISC_ENABLE_BTS_UNAVAIL | - MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL; - /* Perhaps vpmu will change some bits. */ - /* FALLTHROUGH */ - case MSR_P6_PERFCTR(0)...MSR_P6_PERFCTR(7): - case MSR_P6_EVNTSEL(0)...MSR_P6_EVNTSEL(3): - case MSR_CORE_PERF_FIXED_CTR0...MSR_CORE_PERF_FIXED_CTR2: - case MSR_CORE_PERF_FIXED_CTR_CTRL...MSR_CORE_PERF_GLOBAL_OVF_CTRL: - case MSR_IA32_PEBS_ENABLE: - case MSR_IA32_DS_AREA: - if ( vpmu_do_rdmsr(msr, msr_content) ) - goto gp_fault; + case MSR_PKRS: + msrs->pkrs = val; + if ( v == curr ) + wrpkrs(val); + return; + } + + /* Logic which maybe requires remote VMCS acquisition. */ + vmx_vmcs_enter(v); + switch ( reg ) + { + case MSR_IA32_BNDCFGS: + __vmwrite(GUEST_BNDCFGS, val); break; default: - if ( passive_domain_do_rdmsr(msr, msr_content) ) - goto done; + printk(XENLOG_G_ERR "%s(%pv, 0x%08x, 0x%016"PRIx64") Bad register\n", + __func__, v, reg, val); + domain_crash(d); + } + vmx_vmcs_exit(v); +} - if ( vmx_read_guest_msr(curr, msr, msr_content) == 0 ) - break; +/* Handle VT-d posted-interrupt when VCPU is blocked. */ +static void cf_check pi_wakeup_interrupt(struct cpu_user_regs *regs) +{ + struct vmx_vcpu *vmx, *tmp; + spinlock_t *lock = &per_cpu(vmx_pi_blocking, smp_processor_id()).lock; + struct list_head *blocked_vcpus = + &per_cpu(vmx_pi_blocking, smp_processor_id()).list; - if ( is_last_branch_msr(msr) ) - { - *msr_content = 0; - break; - } + ack_APIC_irq(); + this_cpu(irq_count)++; - if ( curr->domain->arch.msr_relaxed && !rdmsr_safe(msr, tmp) ) + spin_lock(lock); + + /* + * XXX: The length of the list depends on how many vCPU is current + * blocked on this specific pCPU. This may hurt the interrupt latency + * if the list grows to too many entries. + */ + list_for_each_entry_safe(vmx, tmp, blocked_vcpus, pi_blocking.list) + { + if ( pi_test_on(&vmx->pi_desc) ) { - *msr_content = 0; - break; + list_del(&vmx->pi_blocking.list); + ASSERT(vmx->pi_blocking.lock == lock); + vmx->pi_blocking.lock = NULL; + vcpu_unblock(container_of(vmx, struct vcpu, arch.hvm.vmx)); } - - gdprintk(XENLOG_WARNING, "RDMSR 0x%08x unimplemented\n", msr); - goto gp_fault; } -done: - HVM_DBG_LOG(DBG_LEVEL_MSR, "returns: ecx=%#x, msr_value=%#"PRIx64, - msr, *msr_content); - return X86EMUL_OKAY; + spin_unlock(lock); +} -gp_fault: - return X86EMUL_EXCEPTION; +/* Handle VT-d posted-interrupt when VCPU is running. */ +static void cf_check pi_notification_interrupt(struct cpu_user_regs *regs) +{ + ack_APIC_irq(); + this_cpu(irq_count)++; + + /* + * We get here when a vCPU is running in root-mode (such as via hypercall, + * or any other reasons which can result in VM-Exit), and before vCPU is + * back to non-root, external interrupts from an assigned device happen + * and a notification event is delivered to this logical CPU. + * + * we need to set VCPU_KICK_SOFTIRQ for the current cpu, just like + * __vmx_deliver_posted_interrupt(). So the pending interrupt in PIRR will + * be synced to vIRR before VM-Exit in time. + * + * Please refer to the following code fragments from + * xen/arch/x86/hvm/vmx/entry.S: + * + * .Lvmx_do_vmentry + * + * ...... + * + * point 1 + * + * cli + * cmp %ecx,(%rdx,%rax,1) + * jnz .Lvmx_process_softirqs + * + * ...... + * + * je .Lvmx_launch + * + * ...... + * + * .Lvmx_process_softirqs: + * sti + * call do_softirq + * jmp .Lvmx_do_vmentry + * + * If VT-d engine issues a notification event at point 1 above, it cannot + * be delivered to the guest during this VM-entry without raising the + * softirq in this notification handler. + */ + raise_softirq(VCPU_KICK_SOFTIRQ); } -static int vmx_alloc_vlapic_mapping(struct domain *d) +/* + * Calculate whether the CPU is vulnerable to Instruction Fetch page + * size-change MCEs. + */ +static bool __init has_if_pschange_mc(void) { - struct page_info *pg; - mfn_t mfn; + uint64_t caps = 0; - if ( !has_vlapic(d) || !cpu_has_vmx_virtualize_apic_accesses ) - return 0; + /* + * If we are virtualised, there is nothing we can do. Our EPT tables are + * shadowed by our hypervisor, and not walked by hardware. + */ + if ( cpu_has_hypervisor ) + return false; - pg = alloc_domheap_page(d, MEMF_no_refcount); - if ( !pg ) - return -ENOMEM; + if ( cpu_has_arch_caps ) + rdmsrl(MSR_ARCH_CAPABILITIES, caps); + + if ( caps & ARCH_CAPS_IF_PSCHANGE_MC_NO ) + return false; + + /* + * IF_PSCHANGE_MC is only known to affect Intel Family 6 processors at + * this time. + */ + if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL || + boot_cpu_data.x86 != 6 ) + return false; + + switch ( boot_cpu_data.x86_model ) + { + /* + * Core processors since at least Nehalem are vulnerable. + */ + case 0x1f: /* Auburndale / Havendale */ + case 0x1e: /* Nehalem */ + case 0x1a: /* Nehalem EP */ + case 0x2e: /* Nehalem EX */ + case 0x25: /* Westmere */ + case 0x2c: /* Westmere EP */ + case 0x2f: /* Westmere EX */ + case 0x2a: /* SandyBridge */ + case 0x2d: /* SandyBridge EP/EX */ + case 0x3a: /* IvyBridge */ + case 0x3e: /* IvyBridge EP/EX */ + case 0x3c: /* Haswell */ + case 0x3f: /* Haswell EX/EP */ + case 0x45: /* Haswell D */ + case 0x46: /* Haswell H */ + case 0x3d: /* Broadwell */ + case 0x47: /* Broadwell H */ + case 0x4f: /* Broadwell EP/EX */ + case 0x56: /* Broadwell D */ + case 0x4e: /* Skylake M */ + case 0x5e: /* Skylake D */ + case 0x55: /* Skylake-X / Cascade Lake */ + case 0x7d: /* Ice Lake */ + case 0x7e: /* Ice Lake */ + case 0x8e: /* Kaby / Coffee / Whiskey Lake M */ + case 0x9e: /* Kaby / Coffee / Whiskey Lake D */ + case 0xa5: /* Comet Lake H/S */ + case 0xa6: /* Comet Lake U */ + return true; - if ( !get_page_and_type(pg, d, PGT_writable_page) ) - { /* - * The domain can't possibly know about this page yet, so failure - * here is a clear indication of something fishy going on. + * Atom processors are not vulnerable. */ - domain_crash(d); - return -ENODATA; - } - - mfn = page_to_mfn(pg); - clear_domain_page(mfn); - d->arch.hvm.vmx.apic_access_mfn = mfn; - - return 0; -} - -static void vmx_free_vlapic_mapping(struct domain *d) -{ - mfn_t mfn = d->arch.hvm.vmx.apic_access_mfn; + case 0x1c: /* Pineview */ + case 0x26: /* Lincroft */ + case 0x27: /* Penwell */ + case 0x35: /* Cloverview */ + case 0x36: /* Cedarview */ + case 0x37: /* Baytrail / Valleyview (Silvermont) */ + case 0x4d: /* Avaton / Rangely (Silvermont) */ + case 0x4c: /* Cherrytrail / Brasswell */ + case 0x4a: /* Merrifield */ + case 0x5a: /* Moorefield */ + case 0x5c: /* Goldmont */ + case 0x5d: /* SoFIA 3G Granite/ES2.1 */ + case 0x65: /* SoFIA LTE AOSP */ + case 0x5f: /* Denverton */ + case 0x6e: /* Cougar Mountain */ + case 0x75: /* Lightning Mountain */ + case 0x7a: /* Gemini Lake */ + case 0x86: /* Jacobsville */ - d->arch.hvm.vmx.apic_access_mfn = _mfn(0); - if ( !mfn_eq(mfn, _mfn(0)) ) - { - struct page_info *pg = mfn_to_page(mfn); + /* + * Knights processors are not vulnerable. + */ + case 0x57: /* Knights Landing */ + case 0x85: /* Knights Mill */ + return false; - put_page_alloc_ref(pg); - put_page_and_type(pg); + default: + printk("Unrecognised CPU model %#x - assuming vulnerable to IF_PSCHANGE_MC\n", + boot_cpu_data.x86_model); + return true; } } -static void vmx_install_vlapic_mapping(struct vcpu *v) -{ - mfn_t apic_access_mfn = v->domain->arch.hvm.vmx.apic_access_mfn; - paddr_t virt_page_ma, apic_page_ma; - - if ( mfn_eq(apic_access_mfn, _mfn(0)) ) - return; - - ASSERT(cpu_has_vmx_virtualize_apic_accesses); +static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { + .name = "VMX", + .cpu_up_prepare = vmx_cpu_up_prepare, + .cpu_dead = vmx_cpu_dead, + .domain_initialise = vmx_domain_initialise, + .domain_relinquish_resources = vmx_domain_relinquish_resources, + .domain_creation_finished = domain_creation_finished, + .vcpu_initialise = vmx_vcpu_initialise, + .vcpu_destroy = vmx_vcpu_destroy, + .save_cpu_ctxt = vmx_save_vmcs_ctxt, + .load_cpu_ctxt = vmx_load_vmcs_ctxt, + .get_interrupt_shadow = vmx_get_interrupt_shadow, + .set_interrupt_shadow = vmx_set_interrupt_shadow, + .get_nonreg_state = vmx_get_nonreg_state, + .set_nonreg_state = vmx_set_nonreg_state, + .guest_x86_mode = vmx_guest_x86_mode, + .get_cpl = _vmx_get_cpl, + .get_segment_register = vmx_get_segment_register, + .set_segment_register = vmx_set_segment_register, + .update_host_cr3 = vmx_update_host_cr3, + .update_guest_cr = vmx_update_guest_cr, + .update_guest_efer = vmx_update_guest_efer, + .cpuid_policy_changed = vmx_cpuid_policy_changed, + .fpu_leave = vmx_fpu_leave, + .set_guest_pat = vmx_set_guest_pat, + .get_guest_pat = vmx_get_guest_pat, + .set_tsc_offset = vmx_set_tsc_offset, + .inject_event = vmx_inject_event, + .init_hypercall_page = vmx_init_hypercall_page, + .event_pending = vmx_event_pending, + .get_pending_event = vmx_get_pending_event, + .invlpg = vmx_invlpg, + .cpu_up = vmx_cpu_up, + .cpu_down = vmx_cpu_down, + .wbinvd_intercept = vmx_wbinvd_intercept, + .fpu_dirty_intercept = vmx_fpu_dirty_intercept, + .msr_read_intercept = vmx_msr_read_intercept, + .msr_write_intercept = vmx_msr_write_intercept, + .handle_cd = vmx_handle_cd, + .set_info_guest = vmx_set_info_guest, + .set_rdtsc_exiting = vmx_set_rdtsc_exiting, + .nhvm_vcpu_initialise = nvmx_vcpu_initialise, + .nhvm_vcpu_destroy = nvmx_vcpu_destroy, + .nhvm_vcpu_reset = nvmx_vcpu_reset, + .nhvm_vcpu_p2m_base = nvmx_vcpu_eptp_base, + .nhvm_vmcx_hap_enabled = nvmx_ept_enabled, + .nhvm_vmcx_guest_intercepts_event = nvmx_intercepts_exception, + .nhvm_vcpu_vmexit_event = nvmx_vmexit_event, + .nhvm_intr_blocked = nvmx_intr_blocked, + .nhvm_domain_relinquish_resources = nvmx_domain_relinquish_resources, + .update_vlapic_mode = vmx_vlapic_msr_changed, + .nhvm_hap_walk_L1_p2m = nvmx_hap_walk_L1_p2m, + .enable_msr_interception = vmx_enable_msr_interception, + .altp2m_vcpu_update_p2m = vmx_vcpu_update_eptp, + .altp2m_vcpu_update_vmfunc_ve = vmx_vcpu_update_vmfunc_ve, + .altp2m_vcpu_emulate_ve = vmx_vcpu_emulate_ve, + .altp2m_vcpu_emulate_vmfunc = vmx_vcpu_emulate_vmfunc, + .vmtrace_control = vmtrace_control, + .vmtrace_output_position = vmtrace_output_position, + .vmtrace_set_option = vmtrace_set_option, + .vmtrace_get_option = vmtrace_get_option, + .vmtrace_reset = vmtrace_reset, - virt_page_ma = page_to_maddr(vcpu_vlapic(v)->regs_page); - apic_page_ma = mfn_to_maddr(apic_access_mfn); + .get_reg = vmx_get_reg, + .set_reg = vmx_set_reg, - vmx_vmcs_enter(v); - __vmwrite(VIRTUAL_APIC_PAGE_ADDR, virt_page_ma); - __vmwrite(APIC_ACCESS_ADDR, apic_page_ma); - vmx_vmcs_exit(v); -} + .tsc_scaling = { + .max_ratio = VMX_TSC_MULTIPLIER_MAX, + }, +}; -void cf_check vmx_vlapic_msr_changed(struct vcpu *v) +const struct hvm_function_table * __init start_vmx(void) { - int virtualize_x2apic_mode; - struct vlapic *vlapic = vcpu_vlapic(v); - unsigned int msr; + set_in_cr4(X86_CR4_VMXE); - virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery) && - cpu_has_vmx_virtualize_x2apic_mode ); + if ( vmx_vmcs_init() ) + { + printk("VMX: failed to initialise.\n"); + return NULL; + } - if ( !cpu_has_vmx_virtualize_apic_accesses && - !virtualize_x2apic_mode ) - return; + vmx_function_table.singlestep_supported = cpu_has_monitor_trap_flag; - vmx_vmcs_enter(v); - v->arch.hvm.vmx.secondary_exec_control &= - ~(SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES | - SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE); - if ( !vlapic_hw_disabled(vlapic) && - (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) + if ( cpu_has_vmx_dt_exiting ) + vmx_function_table.set_descriptor_access_exiting = + vmx_set_descriptor_access_exiting; + + /* + * Do not enable EPT when (!cpu_has_vmx_pat), to prevent security hole + * (refer to https://xenbits.xen.org/xsa/advisory-60.html). + */ + if ( cpu_has_vmx_ept && (cpu_has_vmx_pat || opt_force_ept) ) { - if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) + bool cpu_has_bug_pschange_mc = has_if_pschange_mc(); + + if ( opt_ept_exec_sp == -1 ) { - v->arch.hvm.vmx.secondary_exec_control |= - SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; - if ( cpu_has_vmx_apic_reg_virt ) - { - for ( msr = MSR_X2APIC_FIRST; - msr <= MSR_X2APIC_LAST; msr++ ) - vmx_clear_msr_intercept(v, msr, VMX_MSR_R); + /* Default to non-executable superpages on vulnerable hardware. */ + opt_ept_exec_sp = !cpu_has_bug_pschange_mc; - vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); - } - if ( cpu_has_vmx_virtual_intr_delivery ) - { - vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); - } + if ( cpu_has_bug_pschange_mc ) + printk("VMX: Disabling executable EPT superpages due to CVE-2018-12207\n"); } - else - v->arch.hvm.vmx.secondary_exec_control |= - SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; - } - if ( !(v->arch.hvm.vmx.secondary_exec_control & - SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) - for ( msr = MSR_X2APIC_FIRST; - msr <= MSR_X2APIC_LAST; msr++ ) - vmx_set_msr_intercept(v, msr, VMX_MSR_RW); - vmx_update_secondary_exec_control(v); - vmx_vmcs_exit(v); -} + vmx_function_table.hap_supported = 1; + vmx_function_table.altp2m_supported = 1; -static int cf_check vmx_msr_write_intercept( - unsigned int msr, uint64_t msr_content) -{ - struct vcpu *v = current; - const struct cpuid_policy *cp = v->domain->arch.cpuid; + vmx_function_table.hap_capabilities = 0; - HVM_DBG_LOG(DBG_LEVEL_MSR, "ecx=%#x, msr_value=%#"PRIx64, msr, msr_content); + if ( cpu_has_vmx_ept_2mb ) + vmx_function_table.hap_capabilities |= HVM_HAP_SUPERPAGE_2MB; + if ( cpu_has_vmx_ept_1gb ) + vmx_function_table.hap_capabilities |= HVM_HAP_SUPERPAGE_1GB; - switch ( msr ) - { - uint64_t rsvd, tmp; + setup_ept_dump(); + } - case MSR_IA32_SYSENTER_CS: - __vmwrite(GUEST_SYSENTER_CS, msr_content); - break; - case MSR_IA32_SYSENTER_ESP: - if ( !is_canonical_address(msr_content) ) - goto gp_fault; - __vmwrite(GUEST_SYSENTER_ESP, msr_content); - break; - case MSR_IA32_SYSENTER_EIP: - if ( !is_canonical_address(msr_content) ) - goto gp_fault; - __vmwrite(GUEST_SYSENTER_EIP, msr_content); - break; + if ( cpu_has_vmx_virtual_intr_delivery ) + { + vmx_function_table.update_eoi_exit_bitmap = vmx_update_eoi_exit_bitmap; + vmx_function_table.process_isr = vmx_process_isr; + vmx_function_table.handle_eoi = vmx_handle_eoi; + vmx_function_table.virtual_intr_delivery_enabled = true; + } - case MSR_FS_BASE: - case MSR_GS_BASE: - case MSR_SHADOW_GS_BASE: - if ( !is_canonical_address(msr_content) ) - goto gp_fault; + if ( cpu_has_vmx_posted_intr_processing ) + { + alloc_direct_apic_vector(&posted_intr_vector, pi_notification_interrupt); + if ( iommu_intpost ) + { + alloc_direct_apic_vector(&pi_wakeup_vector, pi_wakeup_interrupt); - if ( msr == MSR_FS_BASE ) - __vmwrite(GUEST_FS_BASE, msr_content); - else if ( msr == MSR_GS_BASE ) - __vmwrite(GUEST_GS_BASE, msr_content); - else - write_gs_shadow(msr_content); + vmx_function_table.pi_update_irte = vmx_pi_update_irte; + } - break; + vmx_function_table.deliver_posted_intr = vmx_deliver_posted_intr; + vmx_function_table.sync_pir_to_irr = vmx_sync_pir_to_irr; + vmx_function_table.test_pir = vmx_test_pir; + } - case MSR_STAR: - v->arch.hvm.vmx.star = msr_content; - wrmsrl(MSR_STAR, msr_content); - break; + if ( cpu_has_vmx_tsc_scaling ) + { + vmx_function_table.tsc_scaling.ratio_frac_bits = 48; + vmx_function_table.tsc_scaling.setup = vmx_setup_tsc_scaling; + } - case MSR_LSTAR: - if ( !is_canonical_address(msr_content) ) - goto gp_fault; - v->arch.hvm.vmx.lstar = msr_content; - wrmsrl(MSR_LSTAR, msr_content); - break; + model_specific_lbr = get_model_specific_lbr(); + lbr_tsx_fixup_check(); + ler_to_fixup_check(); - case MSR_CSTAR: - if ( !is_canonical_address(msr_content) ) - goto gp_fault; - v->arch.hvm.vmx.cstar = msr_content; - break; + return &vmx_function_table; +} - case MSR_SYSCALL_MASK: - v->arch.hvm.vmx.sfmask = msr_content; - wrmsrl(MSR_SYSCALL_MASK, msr_content); - break; +/* + * Not all cases receive valid value in the VM-exit instruction length field. + * Callers must know what they're doing! + */ +static int get_instruction_length(void) +{ + unsigned long len; - case MSR_IA32_DEBUGCTLMSR: - rsvd = ~(IA32_DEBUGCTLMSR_LBR | IA32_DEBUGCTLMSR_BTF); + __vmread(VM_EXIT_INSTRUCTION_LEN, &len); /* Safe: callers audited */ + BUG_ON((len < 1) || (len > MAX_INST_LEN)); + return len; +} - /* TODO: Wire vPMU settings properly through the CPUID policy */ - if ( vpmu_is_set(vcpu_vpmu(v), VPMU_CPU_HAS_BTS) ) - { - rsvd &= ~(IA32_DEBUGCTLMSR_TR | IA32_DEBUGCTLMSR_BTS | - IA32_DEBUGCTLMSR_BTINT); +void update_guest_eip(void) +{ + struct cpu_user_regs *regs = guest_cpu_user_regs(); + unsigned long x; - if ( cpu_has(¤t_cpu_data, X86_FEATURE_DSCPL) ) - rsvd &= ~(IA32_DEBUGCTLMSR_BTS_OFF_OS | - IA32_DEBUGCTLMSR_BTS_OFF_USR); - } + regs->rip += get_instruction_length(); /* Safe: callers audited */ + regs->eflags &= ~X86_EFLAGS_RF; - if ( cp->feat.rtm ) - rsvd &= ~IA32_DEBUGCTLMSR_RTM; + __vmread(GUEST_INTERRUPTIBILITY_INFO, &x); + if ( x & (VMX_INTR_SHADOW_STI | VMX_INTR_SHADOW_MOV_SS) ) + { + x &= ~(VMX_INTR_SHADOW_STI | VMX_INTR_SHADOW_MOV_SS); + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, x); + } - if ( msr_content & rsvd ) - goto gp_fault; + if ( regs->eflags & X86_EFLAGS_TF ) + hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); +} - /* - * The Arch LBR spec (new in Ice Lake) states that CPUs with no - * model-specific LBRs implement MSR_DBG_CTL.LBR by discarding writes - * and always returning 0. - * - * Use this property in all cases where we don't know any - * model-specific LBR information, as it matches real hardware - * behaviour on post-Ice Lake systems. - */ - if ( !model_specific_lbr ) - msr_content &= ~IA32_DEBUGCTLMSR_LBR; +static void vmx_dr_access(unsigned long exit_qualification, + struct cpu_user_regs *regs) +{ + struct vcpu *v = current; - /* - * When a guest first enables LBR, arrange to save and restore the LBR - * MSRs and allow the guest direct access. - * - * Hitting -ENOSPC with the guest load/save list is definitely a - * hypervisor bug, whereas -ENOMEM for allocating the load/save list - * is simply unlucky (and shouldn't occur with sensible management by - * the toolstack). - * - * Either way, there is nothing we can do right now to recover, and - * the guest won't execute correctly either. Simply crash the domain - * to make the failure obvious. - */ - if ( !(v->arch.hvm.vmx.lbr_flags & LBR_MSRS_INSERTED) && - (msr_content & IA32_DEBUGCTLMSR_LBR) ) - { - const struct lbr_info *lbr = model_specific_lbr; + HVMTRACE_0D(DR_WRITE); - for ( ; lbr->count; lbr++ ) - { - unsigned int i; + if ( !v->arch.hvm.flag_dr_dirty ) + __restore_debug_registers(v); - for ( i = 0; i < lbr->count; i++ ) - { - int rc = vmx_add_guest_msr(v, lbr->base + i, 0); + /* Allow guest direct access to DR registers */ + v->arch.hvm.vmx.exec_control &= ~CPU_BASED_MOV_DR_EXITING; + vmx_update_cpu_exec_control(v); +} - if ( unlikely(rc) ) - { - gprintk(XENLOG_ERR, - "Guest load/save list error %d\n", rc); - domain_crash(v->domain); - return X86EMUL_OKAY; - } +static void vmx_invlpg_intercept(unsigned long linear) +{ + HVMTRACE_LONG_2D(INVLPG, /*invlpga=*/ 0, TRC_PAR_LONG(linear)); + paging_invlpg(current, linear); +} - vmx_clear_msr_intercept(v, lbr->base + i, VMX_MSR_RW); - } - } +static int vmx_vmfunc_intercept(struct cpu_user_regs *regs) +{ + /* + * This handler is a placeholder for future where Xen may + * want to handle VMFUNC exits and resume a domain normally without + * injecting a #UD to the guest - for example, in a VT-nested + * scenario where Xen may want to lazily shadow the alternate + * EPTP list. + */ + gdprintk(XENLOG_ERR, "Failed guest VMFUNC execution\n"); + return X86EMUL_EXCEPTION; +} - v->arch.hvm.vmx.lbr_flags |= LBR_MSRS_INSERTED; - if ( lbr_tsx_fixup_needed ) - v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_TSX; - if ( ler_to_fixup_needed ) - v->arch.hvm.vmx.lbr_flags |= LBR_FIXUP_LER_TO; - } +static int vmx_cr_access(cr_access_qual_t qual) +{ + struct vcpu *curr = current; - __vmwrite(GUEST_IA32_DEBUGCTL, msr_content); - break; + switch ( qual.access_type ) + { + case VMX_CR_ACCESS_TYPE_MOV_TO_CR: + return hvm_mov_to_cr(qual.cr, qual.gpr); + + case VMX_CR_ACCESS_TYPE_MOV_FROM_CR: + return hvm_mov_from_cr(qual.cr, qual.gpr); + + case VMX_CR_ACCESS_TYPE_CLTS: + { + unsigned long old = curr->arch.hvm.guest_cr[0]; + unsigned long value = old & ~X86_CR0_TS; - case MSR_IA32_MISC_ENABLE: /* - * Silently drop writes that don't change the reported value: At least - * some Windows guests will expect to be able to write to MISC_ENABLE - * with the same value that's been read from it. + * Special case unlikely to be interesting to a + * VM_EVENT_FLAG_DENY-capable application, so the hvm_monitor_crX() + * return value is ignored for now. */ - if ( vmx_msr_read_intercept(msr, &tmp) != X86EMUL_OKAY || - tmp != msr_content ) - goto gp_fault; + hvm_monitor_crX(CR0, value, old); + curr->arch.hvm.guest_cr[0] = value; + vmx_update_guest_cr(curr, 0, 0); + HVMTRACE_0D(CLTS); break; + } - case MSR_P6_PERFCTR(0)...MSR_P6_PERFCTR(7): - case MSR_P6_EVNTSEL(0)...MSR_P6_EVNTSEL(7): - case MSR_CORE_PERF_FIXED_CTR0...MSR_CORE_PERF_FIXED_CTR2: - case MSR_CORE_PERF_FIXED_CTR_CTRL...MSR_CORE_PERF_GLOBAL_OVF_CTRL: - case MSR_IA32_PEBS_ENABLE: - case MSR_IA32_DS_AREA: - if ( vpmu_do_wrmsr(msr, msr_content) ) - goto gp_fault; - break; + case VMX_CR_ACCESS_TYPE_LMSW: + { + unsigned long value = curr->arch.hvm.guest_cr[0]; + int rc; - default: - if ( passive_domain_do_wrmsr(msr, msr_content) ) - return X86EMUL_OKAY; + /* LMSW can (1) set PE; (2) set or clear MP, EM, and TS. */ + value = (value & ~(X86_CR0_MP|X86_CR0_EM|X86_CR0_TS)) | + (qual.lmsw_data & + (X86_CR0_PE|X86_CR0_MP|X86_CR0_EM|X86_CR0_TS)); + HVMTRACE_LONG_1D(LMSW, value); - if ( vmx_write_guest_msr(v, msr, msr_content) == 0 || - is_last_branch_msr(msr) ) - break; + if ( (rc = hvm_set_cr0(value, true)) == X86EMUL_EXCEPTION ) + hvm_inject_hw_exception(TRAP_gp_fault, 0); - if ( v->domain->arch.msr_relaxed && !rdmsr_safe(msr, msr_content) ) - break; + return rc; + } - gdprintk(XENLOG_WARNING, - "WRMSR 0x%08x val 0x%016"PRIx64" unimplemented\n", - msr, msr_content); - goto gp_fault; + default: + ASSERT_UNREACHABLE(); + return X86EMUL_UNHANDLEABLE; } return X86EMUL_OKAY; - -gp_fault: - return X86EMUL_EXCEPTION; } static void vmx_do_extint(struct cpu_user_regs *regs) @@ -3731,17 +3700,6 @@ static void vmx_do_extint(struct cpu_user_regs *regs) do_IRQ(regs); } -static void cf_check vmx_wbinvd_intercept(void) -{ - if ( !cache_flush_permitted(current->domain) || iommu_snoop ) - return; - - if ( cpu_has_wbinvd_exiting ) - flush_all(FLUSH_CACHE); - else - wbinvd(); -} - static void ept_handle_violation(ept_qual_t q, paddr_t gpa) { unsigned long gla, gfn = gpa >> PAGE_SHIFT; @@ -4193,8 +4151,8 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) { case EXIT_REASON_EXCEPTION_NMI: if ( vector != TRAP_page_fault - && vector != TRAP_nmi - && vector != TRAP_machine_check ) + && vector != TRAP_nmi + && vector != TRAP_machine_check ) { default: perfc_incr(realmode_exits); diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 97d6b810ec..5c748d5b09 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -89,7 +89,6 @@ void cf_check vmx_vlapic_msr_changed(struct vcpu *v); struct hvm_emulate_ctxt; void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt); void vmx_realmode(struct cpu_user_regs *regs); -void vmx_update_debug_state(struct vcpu *v); void vmx_update_exception_bitmap(struct vcpu *v); void vmx_update_cpu_exec_control(struct vcpu *v); void vmx_update_secondary_exec_control(struct vcpu *v); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:48:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497258.768199 (Exim 4.92) (envelope-from ) id 1pT5mj-00066Q-Hw; Fri, 17 Feb 2023 18:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497258.768199; Fri, 17 Feb 2023 18:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mj-00065U-AY; Fri, 17 Feb 2023 18:48:41 +0000 Received: by outflank-mailman (input) for mailman id 497258; Fri, 17 Feb 2023 18:48:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5mh-0005Js-T1 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:48:40 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0528209-aef3-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 19:48:37 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id g29so2886341eda.5 for ; Fri, 17 Feb 2023 10:48:37 -0800 (PST) Received: from uni.router.wind (adsl-65.109.242.225.tellas.gr. [109.242.225.65]) by smtp.googlemail.com with ESMTPSA id z61-20020a509e43000000b004ad03b18ae3sm2641585ede.62.2023.02.17.10.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:48:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0528209-aef3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vmN2USvrN1K54LlFANjHxHXDe4FU6hMjam29RFhTkrI=; b=Q4rE8RNmecwb1UKXu4brc0nEgQHPSEBhwgpYJ63H3TBgZB05WtEY8djILUkcLh3F4j hYftS8WIaID35dgLYvmLS/XSvj7qEOlGgk7hWKLRP6++cTHfwMF+CKdiQjPXrAI+RlYo KvCuO6VYtOCdlgxmkZU7y0VyGq0oWVkz40T9Iv1Ne87eqZGZZ+zxlkHvDBL8wmr2kjmB sEdwNA9AjutDr9uo3SaKpRpmP1g4inK9DynBYs08DJV+d8o5OaEinvQk8Wu+m50Lzi4f PBGjk8mJTC1nNmpWJT9uzvWbL1WG+dxCUk1vY+c+g90NFT/WWadjPV6gneWpdcCWFj6P S5Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vmN2USvrN1K54LlFANjHxHXDe4FU6hMjam29RFhTkrI=; b=NUCPdHx+lFwZWxoPEYiNBYxrOM1/ipGXHINxjg4gGren/JFmteNfGw6696QQ5SKHzx GKSKnA5PXAtk54ygHsCQ8qZufMXgGhulCQfRv7YzViFbkaFqwKBJCE3ZPqfB76t7/s0L HZBYcBRdoKOafcoP504gskDQ7TeM1GeQd6X09fwJcH1EcJlKuAjdqIzxF81LzPPHCjOF AZE5CGl+E1mZnsDVHqmnRVvCU/6yjkVTRK1Vdbi/FPGJa7W6A2a1PItt4hTeOAvlf60H vr30xcbwhOX8zheWSPFm1DZfz0FCNNHDWLCd5DQziOoJQq5PRwPnRWxoYYoqZk34gcVI NmPg== X-Gm-Message-State: AO0yUKV0V3Yuv/4qws+DjI0XDWh5ZsvsWfhkk1E5Fp5iA7KA1nQSsIUt BReYysAsBk6/kiNh2l6dZPgV71C2YKA= X-Google-Smtp-Source: AK7set+c6uRy9FDIC/+PTu5e6DqjDc15EfYzl1hvke7wcPEhaTIGnGlg+IoN6Q6cu24gtvLJBzR8MA== X-Received: by 2002:aa7:d513:0:b0:4aa:a9c7:4224 with SMTP id y19-20020aa7d513000000b004aaa9c74224mr2082197edq.30.1676659717028; Fri, 17 Feb 2023 10:48:37 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 4/4] x86/vmx: cleanup vmx.h Date: Fri, 17 Feb 2023 20:48:14 +0200 Message-Id: <20230217184814.1243046-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230217184814.1243046-1-burzalodowa@gmail.com> References: <20230217184814.1243046-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/i387.h asm/hvm/trace.h asm/processor.h asm/regs.h because none of the declarations and macro definitions in them is used in this file. Sort alphabetically the rest of the headers. Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy(). Move the definition of GAS_VMX_OP just above the functions that use it and undefine it after its usage. Move in vmcs.c the definitions of: ept_sync_all() __vmxoff() __vmxon() because they are used only in this file. Take the opportunity to remove a trailing white space. Move in vmx.c the definitions of: pi_test_and_set_pir() pi_test_pir() pi_test_and_set_on() pi_set_on() pi_test_and_clear_on() pi_test_on() pi_get_pir() pi_test_sn() pi_set_sn() pi_clear_sn() vpid_sync_vcpu_gva() because they are used only in this file. Move in vmx.c the declarations of: ve_info_t ept_qual_t idt_or_gdt_instr_info_t ldt_or_tr_instr_info_t because they are used only in this file. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/hvm/vmx/vmcs.c | 31 ++++ xen/arch/x86/hvm/vmx/vmx.c | 141 ++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 193 ++----------------------- 3 files changed, 182 insertions(+), 183 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index c46bb55f05..a4de21d5dc 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -691,6 +691,37 @@ void cf_check vmx_cpu_dead(unsigned int cpu) vmx_pi_desc_fixup(cpu); } +static inline void __vmxoff(void) +{ + asm volatile ( + VMXOFF_OPCODE + : : : "memory" ); +} + +static inline int __vmxon(u64 addr) +{ + int rc; + + asm volatile ( + "1: " VMXON_OPCODE MODRM_EAX_06 "\n" + " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ + "2:\n" + ".section .fixup,\"ax\"\n" + "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ + ".previous\n" + _ASM_EXTABLE(1b, 3b) + : "=q" (rc) + : "0" (0), "a" (&addr) + : "memory"); + + return rc; +} + +static inline void ept_sync_all(void) +{ + __invept(INVEPT_ALL_CONTEXT, 0); +} + static int _vmx_cpu_up(bool bsp) { u32 eax, edx; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index d02ad01b9b..4eade64fd6 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include @@ -245,6 +246,58 @@ struct vmx_pi_blocking_vcpu { */ static DEFINE_PER_CPU(struct vmx_pi_blocking_vcpu, vmx_pi_blocking); +#define POSTED_INTR_ON 0 +#define POSTED_INTR_SN 1 +static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) +{ + return test_and_set_bit(vector, pi_desc->pir); +} + +static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) +{ + return test_bit(vector, pi_desc->pir); +} + +static inline int pi_test_and_set_on(struct pi_desc *pi_desc) +{ + return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline void pi_set_on(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) +{ + return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_on(struct pi_desc *pi_desc) +{ + return pi_desc->on; +} + +static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) +{ + return xchg(&pi_desc->pir[group], 0); +} + +static inline int pi_test_sn(struct pi_desc *pi_desc) +{ + return pi_desc->sn; +} + +static inline void pi_set_sn(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_SN, &pi_desc->control); +} + +static inline void pi_clear_sn(struct pi_desc *pi_desc) +{ + clear_bit(POSTED_INTR_SN, &pi_desc->control); +} + static void vmx_pi_switch_from(struct vcpu *v) { struct pi_desc *pi_desc = &v->arch.hvm.vmx.pi_desc; @@ -1329,6 +1382,30 @@ gp_fault: return X86EMUL_EXCEPTION; } +static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) +{ + int type = INVVPID_INDIVIDUAL_ADDR; + + /* + * If individual address invalidation is not supported, we escalate to + * use single context invalidation. + */ + if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) + goto execute_invvpid; + + type = INVVPID_SINGLE_CONTEXT; + + /* + * If single context invalidation is not supported, we escalate to + * use all context invalidation. + */ + if ( !cpu_has_vmx_vpid_invvpid_single_context ) + type = INVVPID_ALL_CONTEXT; + +execute_invvpid: + __invvpid(type, v->arch.hvm.n1asid.asid, (u64)gva); +} + static void cf_check vmx_invlpg(struct vcpu *v, unsigned long linear) { if ( cpu_has_vmx_vpid ) @@ -2941,6 +3018,16 @@ static int cf_check vmx_vcpu_emulate_vmfunc(const struct cpu_user_regs *regs) return rc; } +/* #VE information page */ +typedef struct { + u32 exit_reason; + u32 semaphore; + u64 exit_qualification; + u64 gla; + u64 gpa; + u16 eptp_index; +} ve_info_t; + static bool cf_check vmx_vcpu_emulate_ve(struct vcpu *v) { const struct page_info *pg = vcpu_altp2m(v).veinfo_pg; @@ -3700,6 +3787,18 @@ static void vmx_do_extint(struct cpu_user_regs *regs) do_IRQ(regs); } +/* EPT violation qualifications definitions */ +typedef union ept_qual { + unsigned long raw; + struct { + bool read:1, write:1, fetch:1, + eff_read:1, eff_write:1, eff_exec:1, /* eff_user_exec */:1, + gla_valid:1, + gla_fault:1; /* Valid iff gla_valid. */ + unsigned long /* pad */:55; + }; +} __transparent__ ept_qual_t; + static void ept_handle_violation(ept_qual_t q, paddr_t gpa) { unsigned long gla, gfn = gpa >> PAGE_SHIFT; @@ -3956,6 +4055,48 @@ static void vmx_handle_xrstors(void) domain_crash(current->domain); } +/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ +typedef union idt_or_gdt_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :5, /* bits 6:2 - Undefined */ + addr_size :3, /* bits 9:7 - Address size */ + :1, /* bit 10 - Cleared to 0 */ + operand_size :1, /* bit 11 - Operand size */ + :3, /* bits 14:12 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 30:63 - Undefined */ + }; +} idt_or_gdt_instr_info_t; + +/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ +typedef union ldt_or_tr_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :1, /* bit 2 - Undefined */ + reg1 :4, /* bits 6:3 - Reg1 */ + addr_size :3, /* bits 9:7 - Address size */ + mem_reg :1, /* bit 10 - Mem/Reg */ + :4, /* bits 14:11 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 31:63 - Undefined */ + }; +} ldt_or_tr_instr_info_t; + static void vmx_handle_descriptor_access(uint32_t exit_reason) { uint64_t instr_info; diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 5c748d5b09..2520be0824 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -19,14 +19,10 @@ #define __ASM_X86_HVM_VMX_VMX_H__ #include -#include -#include #include -#include -#include -#include -#include #include +#include +#include extern int8_t opt_ept_exec_sp; @@ -93,58 +89,6 @@ void vmx_update_exception_bitmap(struct vcpu *v); void vmx_update_cpu_exec_control(struct vcpu *v); void vmx_update_secondary_exec_control(struct vcpu *v); -#define POSTED_INTR_ON 0 -#define POSTED_INTR_SN 1 -static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) -{ - return test_and_set_bit(vector, pi_desc->pir); -} - -static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) -{ - return test_bit(vector, pi_desc->pir); -} - -static inline int pi_test_and_set_on(struct pi_desc *pi_desc) -{ - return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline void pi_set_on(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) -{ - return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_on(struct pi_desc *pi_desc) -{ - return pi_desc->on; -} - -static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) -{ - return xchg(&pi_desc->pir[group], 0); -} - -static inline int pi_test_sn(struct pi_desc *pi_desc) -{ - return pi_desc->sn; -} - -static inline void pi_set_sn(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_SN, &pi_desc->control); -} - -static inline void pi_clear_sn(struct pi_desc *pi_desc) -{ - clear_bit(POSTED_INTR_SN, &pi_desc->control); -} - /* * Exit Reasons */ @@ -321,12 +265,6 @@ extern uint8_t posted_intr_vector; #define INVVPID_ALL_CONTEXT 2 #define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 -#ifdef HAVE_AS_VMX -# define GAS_VMX_OP(yes, no) yes -#else -# define GAS_VMX_OP(yes, no) no -#endif - static always_inline void __vmptrld(u64 addr) { asm volatile ( @@ -416,6 +354,12 @@ static always_inline void __vmwrite(unsigned long field, unsigned long value) ); } +#ifdef HAVE_AS_VMX +# define GAS_VMX_OP(yes, no) yes +#else +# define GAS_VMX_OP(yes, no) no +#endif + static inline enum vmx_insn_errno vmread_safe(unsigned long field, unsigned long *value) { @@ -462,6 +406,8 @@ static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, return ret; } +#undef GAS_VMX_OP + static always_inline void __invept(unsigned long type, uint64_t eptp) { struct { @@ -527,68 +473,13 @@ static always_inline void __invvpid(unsigned long type, u16 vpid, u64 gva) : "memory" ); } -static inline void ept_sync_all(void) -{ - __invept(INVEPT_ALL_CONTEXT, 0); -} - void ept_sync_domain(struct p2m_domain *p2m); -static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) -{ - int type = INVVPID_INDIVIDUAL_ADDR; - - /* - * If individual address invalidation is not supported, we escalate to - * use single context invalidation. - */ - if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) - goto execute_invvpid; - - type = INVVPID_SINGLE_CONTEXT; - - /* - * If single context invalidation is not supported, we escalate to - * use all context invalidation. - */ - if ( !cpu_has_vmx_vpid_invvpid_single_context ) - type = INVVPID_ALL_CONTEXT; - -execute_invvpid: - __invvpid(type, v->arch.hvm.n1asid.asid, (u64)gva); -} - static inline void vpid_sync_all(void) { __invvpid(INVVPID_ALL_CONTEXT, 0, 0); } -static inline void __vmxoff(void) -{ - asm volatile ( - VMXOFF_OPCODE - : : : "memory" ); -} - -static inline int __vmxon(u64 addr) -{ - int rc; - - asm volatile ( - "1: " VMXON_OPCODE MODRM_EAX_06 "\n" - " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ - "2:\n" - ".section .fixup,\"ax\"\n" - "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ - ".previous\n" - _ASM_EXTABLE(1b, 3b) - : "=q" (rc) - : "0" (0), "a" (&addr) - : "memory"); - - return rc; -} - int cf_check vmx_guest_x86_mode(struct vcpu *v); unsigned int vmx_get_cpl(void); @@ -620,71 +511,7 @@ static inline void vmx_pi_hooks_deassign(struct domain *d) {} #define APIC_INVALID_DEST 0xffffffff -/* EPT violation qualifications definitions */ -typedef union ept_qual { - unsigned long raw; - struct { - bool read:1, write:1, fetch:1, - eff_read:1, eff_write:1, eff_exec:1, /* eff_user_exec */:1, - gla_valid:1, - gla_fault:1; /* Valid iff gla_valid. */ - unsigned long /* pad */:55; - }; -} __transparent__ ept_qual_t; - #define EPT_L4_PAGETABLE_SHIFT 39 #define EPT_PAGETABLE_ENTRIES 512 -/* #VE information page */ -typedef struct { - u32 exit_reason; - u32 semaphore; - u64 exit_qualification; - u64 gla; - u64 gpa; - u16 eptp_index; -} ve_info_t; - -/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ -typedef union idt_or_gdt_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :5, /* bits 6:2 - Undefined */ - addr_size :3, /* bits 9:7 - Address size */ - :1, /* bit 10 - Cleared to 0 */ - operand_size :1, /* bit 11 - Operand size */ - :3, /* bits 14:12 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 30:63 - Undefined */ - }; -} idt_or_gdt_instr_info_t; - -/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ -typedef union ldt_or_tr_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :1, /* bit 2 - Undefined */ - reg1 :4, /* bits 6:3 - Reg1 */ - addr_size :3, /* bits 9:7 - Address size */ - mem_reg :1, /* bit 10 - Mem/Reg */ - :4, /* bits 14:11 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 31:63 - Undefined */ - }; -} ldt_or_tr_instr_info_t; - #endif /* __ASM_X86_HVM_VMX_VMX_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 17 18:49:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 18:49:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497275.768211 (Exim 4.92) (envelope-from ) id 1pT5nF-0007ef-OM; Fri, 17 Feb 2023 18:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497275.768211; Fri, 17 Feb 2023 18:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5nF-0007eY-LW; Fri, 17 Feb 2023 18:49:13 +0000 Received: by outflank-mailman (input) for mailman id 497275; Fri, 17 Feb 2023 18:49:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5nE-0007cl-7e for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 18:49:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT5nD-0004Do-GX; Fri, 17 Feb 2023 18:49:11 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.15.164]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pT5nD-0005lg-9n; Fri, 17 Feb 2023 18:49:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mGcksg/Z3kagHKEP9xzmsv2srfnFAf+Y1ev/9n/ba/8=; b=Ofr4+Ad6MASI54ggFnpQYul3JJ hlKruEjQNa8Tfvqs0QeuSBjR7L4i/34LncLWyTlSP/6ZkhmAlSHgr81UdBY3q+OtbcxU/Ux2dzHBM h0z/w0HwsBTCetgVE+sWKHc8yUgrT0XUqbA7jNP99X84Y1YTEquZTD/ug8xbF/+KXwLw=; Message-ID: Date: Fri, 17 Feb 2023 18:49:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 02/13] tools/xenstore: manage per-transaction domain accounting data in an array Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-3-jgross@suse.com> From: Julien Grall In-Reply-To: <20230120100028.11142-3-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: > In order to prepare keeping accounting data in an array instead of > using independent fields, switch the struct changed_domain accounting > data to that scheme, for now only using an array with one element. > > In order to be able to extend this scheme add the needed indexing enum > to xenstored_domain.h. > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 17 19:30:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 19:30:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497295.768223 (Exim 4.92) (envelope-from ) id 1pT6QX-0005a0-Sm; Fri, 17 Feb 2023 19:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497295.768223; Fri, 17 Feb 2023 19:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT6QX-0005Zt-Pj; Fri, 17 Feb 2023 19:29:49 +0000 Received: by outflank-mailman (input) for mailman id 497295; Fri, 17 Feb 2023 19:29:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT6QW-0005Zn-45 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 19:29:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT6QV-0005A6-0q; Fri, 17 Feb 2023 19:29:47 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.15.164]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pT6QU-0007cR-RG; Fri, 17 Feb 2023 19:29:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=i2jD0nviNmnS5w8ORbhjWBFuiTG1wbef0yAhsi/PkYc=; b=RRviXq0od5O3IXpnlshSd5Y4qx WZcYpsMiQ62AJCAsiu4VB2qDmbQAPGlj+7Sw5nb5M1Jr6TYWt7vfdViz/lU2IDgANTc91sLEACRdC aZjQ3ZHRWmaGcZJGBG9Zf+DAQOydHYV8KKmcHIULIj/IunzayO7Sr1utuTSXr/n2YL2c=; Message-ID: <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> Date: Fri, 17 Feb 2023 19:29:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 03/13] tools/xenstore: introduce accounting data array for per-domain values Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-4-jgross@suse.com> From: Julien Grall In-Reply-To: <20230120100028.11142-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: > Introduce the scheme of an accounting data array for per-domain > accounting data and use it initially for the number of nodes owned by > a domain. > > Make the accounting data type to be unsigned int, as no data is allowed > to be negative at any time. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_domain.c | 71 ++++++++++++++++++------------- > tools/xenstore/xenstored_domain.h | 5 ++- > 2 files changed, 45 insertions(+), 31 deletions(-) > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index 44e72937fa..f459c5aabb 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -69,8 +69,8 @@ struct domain > /* Has domain been officially introduced? */ > bool introduced; > > - /* number of entry from this domain in the store */ > - int nbentry; > + /* Accounting data for this domain. */ > + unsigned int acc[ACC_N]; > > /* Amount of memory allocated for this domain. */ > int memory; > @@ -246,7 +246,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, > > if (keep_orphans) { > set_tdb_key(node->name, &key); > - domain->nbentry--; > + domain_nbentry_dec(NULL, domain->domid); > node->perms.p[0].id = priv_domid; > node->acc.memory = 0; > domain_nbentry_inc(NULL, priv_domid); > @@ -270,7 +270,7 @@ static int domain_tree_remove_sub(const void *ctx, struct connection *conn, > ret = WALK_TREE_SKIP_CHILDREN; > } > > - return domain->nbentry > 0 ? ret : WALK_TREE_SUCCESS_STOP; > + return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; > } > > static void domain_tree_remove(struct domain *domain) > @@ -278,7 +278,7 @@ static void domain_tree_remove(struct domain *domain) > int ret; > struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; > > - if (domain->nbentry > 0) { > + if (domain->acc[ACC_NODES]) { > ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); > if (ret == WALK_TREE_ERROR_STOP) > syslog(LOG_ERR, > @@ -437,7 +437,7 @@ int domain_get_quota(const void *ctx, struct connection *conn, > resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ > if (!resp) return ENOMEM > > - ent(nodes, d->nbentry); > + ent(nodes, d->acc[ACC_NODES]); > ent(watches, d->nbwatch); > ent(transactions, ta); > ent(outstanding, d->nboutstanding); > @@ -1047,8 +1047,28 @@ int domain_adjust_node_perms(struct node *node) > return 0; > } > > -static int domain_nbentry_add(struct connection *conn, unsigned int domid, > - int add, bool no_dom_alloc) > +static int domain_acc_add_chk(struct domain *d, enum accitem what, int add, > + unsigned int domid) You are passing the domid but this doesn't seem to be used within the function. Also, from just reading at this prototype, it is not clear to me whether 'domid' is meant to correspond to the one of 'd'. The name is also a bit confusing because below you have a function call domain_acc_add() that will update "d->acc[what]" so I would expect this function to also update it after a sanity get. I would suggest to rename it to domain_acc_get_chk() or similar (see below for some context). > +{ > + assert(what < ARRAY_SIZE(d->acc)); > + > + if ((add < 0 && -add > d->acc[what]) || > + (d->acc[what] + add) > INT_MAX) { NIT: Even if I know that 'add' will unlikely be INT_MAX, it would be better to use '(INT_MAX - d->acc[what]) < add)'. So there is no overflow possible. > + /* > + * In a transaction when a node is being added/removed AND the > + * same node has been added/removed outside the transaction in > + * parallel, the resulting value will be wrong. This is no > + * problem, as the transaction will fail due to the resulting > + * conflict. > + */ > + return (add < 0) ? 0 : INT_MAX; > + } > + > + return d->acc[what] + add; > +} > + > +static int domain_acc_add(struct connection *conn, unsigned int domid, > + enum accitem what, int add, bool no_dom_alloc) > { > struct domain *d; > struct list_head *head; > @@ -1071,56 +1091,49 @@ static int domain_nbentry_add(struct connection *conn, unsigned int domid, > } > } > > - if (conn && conn->transaction) { > + if (conn && conn->transaction && what < ACC_TR_N) { Do you have a use case where 'what' is >= ACC_TR_N and you want to modify d->acc? > head = transaction_get_changed_domains(conn->transaction); > - ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, > + ret = acc_add_changed_dom(conn->transaction, head, what, > add, domid); > if (errno) { > fail_transaction(conn->transaction); > return -1; > } > - /* > - * In a transaction when a node is being added/removed AND the > - * same node has been added/removed outside the transaction in > - * parallel, the resulting number of nodes will be wrong. This > - * is no problem, as the transaction will fail due to the > - * resulting conflict. > - * In the node remove case the resulting number can be even > - * negative, which should be avoided. > - */ > - return max(d->nbentry + ret, 0); > + return domain_acc_add_chk(d, what, ret, domid); I was going to ask here why we are updating d->acc[what]. However the function is not doing what I was expecting from the name. You are only returning the number of entries adjusted. > } > > - d->nbentry += add; > + d->acc[what] = domain_acc_add_chk(d, what, add, domid); > > - return d->nbentry; > + return d->acc[what]; > } > > int domain_nbentry_inc(struct connection *conn, unsigned int domid) > { > - return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; > + return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) > + ? errno : 0; > } > > int domain_nbentry_dec(struct connection *conn, unsigned int domid) > { > - return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; > + return (domain_acc_add(conn, domid, ACC_NODES, -1, true) < 0) > + ? errno : 0; > } > > int domain_nbentry_fix(unsigned int domid, int num, bool update) > { > int ret; > > - ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); > + ret = domain_acc_add(NULL, domid, ACC_NODES, update ? num : 0, update); > if (ret < 0 || update) > return ret; > > return domid_is_unprivileged(domid) ? ret + num : 0; > } > > -int domain_nbentry(struct connection *conn) > +unsigned int domain_nbentry(struct connection *conn) > { > return domain_is_unprivileged(conn) > - ? domain_nbentry_add(conn, conn->id, 0, true) : 0; > + ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; > } > > static bool domain_chk_quota(struct domain *domain, int mem) > @@ -1597,7 +1610,7 @@ static int domain_check_acc_init_sub(const void *k, void *v, void *arg) > * If everything is correct incrementing the value for each node will > * result in dom->nodes being 0 at the end. > */ > - dom->nodes = -d->nbentry; > + dom->nodes = -d->acc[ACC_NODES]; > > if (!hashtable_insert(domains, &dom->domid, dom)) { > talloc_free(dom); > @@ -1652,7 +1665,7 @@ static int domain_check_acc_cb(const void *k, void *v, void *arg) > if (!d) > return 0; > > - d->nbentry += dom->nodes; > + d->acc[ACC_NODES] += dom->nodes; > > return 0; > } > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index 6a2b76a85b..8259c114b0 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -21,7 +21,8 @@ > > enum accitem { > ACC_NODES, > - ACC_TR_N /* Number of elements per transaction and domain. */ > + ACC_TR_N, /* Number of elements per transaction and domain. */ The churn here could have been avoided if you add a "," even for the edn element and properly indented the comment in the original patch. Also, was the comment indented to be updated to remove "and domain"? > + ACC_N = ACC_TR_N /* Number of elements per domain. */ > }; > > void handle_event(void); > @@ -72,7 +73,7 @@ int domain_alloc_permrefs(struct node_perms *perms); > int domain_nbentry_inc(struct connection *conn, unsigned int domid); > int domain_nbentry_dec(struct connection *conn, unsigned int domid); > int domain_nbentry_fix(unsigned int domid, int num, bool update); > -int domain_nbentry(struct connection *conn); > +unsigned int domain_nbentry(struct connection *conn); > int domain_memory_add(unsigned int domid, int mem, bool no_quota_check); > > /* Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 17 21:36:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 21:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497310.768248 (Exim 4.92) (envelope-from ) id 1pT8OP-0005tk-8G; Fri, 17 Feb 2023 21:35:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497310.768248; Fri, 17 Feb 2023 21:35:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OP-0005td-4U; Fri, 17 Feb 2023 21:35:45 +0000 Received: by outflank-mailman (input) for mailman id 497310; Fri, 17 Feb 2023 21:35:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OO-0005eU-1D for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 21:35:44 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 076df585-af0b-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 22:35:43 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 22D26320089C; Fri, 17 Feb 2023 16:35:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 17 Feb 2023 16:35:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 16:35:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 076df585-af0b-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676669740; x=1676756140; bh=+fUifg3+9Sx5Ngno/T4jBLJLFOiv4d2p9UY Hj/k/F/0=; b=bI/SwuuTCUFWbqFIswklDhSzM3zSdBkjB0Mo/eFk6Ez4o4nN0II xkNxRSbnIQfa1YFUwGMc+oJV+SwwImEiRqBb45/ouMh7RNOrL4K/jm4GrNWuGKAZ 33D4aVoVlmZClGkPF/DX7rFov9ZxjnqnDoOb+bnaC3dTCZAE67e28cACo0A6HvqR taL3/KfXN8x3ENmjWVLwwM3/8YrglAe4lcHsyoYt/qL8uBfnxtoblq6Hwk6sT9PZ fjQa2AMJ+QgO6+0+Z/v4E/kWwMkbu5hwvJgxYsVH1xXauHzRiBiKojKbsQncURFz 9JZj6/O9nU+FpqyLpAk3HiLUtrAcxI9a0Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676669740; x=1676756140; bh=+fUifg3+9Sx5N gno/T4jBLJLFOiv4d2p9UYHj/k/F/0=; b=RP+EdWsDxv0ErGF+W7B4uXt4wW78w H8yJ8xKAubPGvOjRbe5r67qBeFgM11JH5dT4EA4x42OTV/Nx4A3/wE5DeUs9zzCt txnWxYZBbN/Q0OtU75gyrrYpJqqQGM3XiILqyewYjNzVp6555L2BjkuyqdnS0EXS X/edlzbmm5I9V/PPTyseN9G9GUFPNCp5ZjpU6y9n7JqlMaxtJ4ruZotTt+NX2WMj yifrYFGhM/eyQ4mAGXG1FJhrHKYIakUkMIX6FCD6QLxNsluDz3f5GuzJVgGjweUw oM5kFg/Yc4PIDKGXpTbBG7zSDRrEkogP43sEEiuHQgdAHPOgWO5Rabwkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeeugfffieehhfffleekheffleej ueetiefhiedujeegueffhfehuefgkefhieffieenucffohhmrghinhepgigvnhdrohhrgh dpgigvnhhprhhojhgvtghtrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsg drtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH v3 1/4] Use HTTPS for all xenbits.xen.org Git repos Date: Fri, 17 Feb 2023 16:35:24 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports for all xenbits.xen.org Git repositories. It was generated with the following shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk | 18 +++++------------- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- scripts/get_maintainer.pl | 2 +- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..75f1975e5e78af44d36c2372cba6e89b425267a5 100644 --- a/Config.mk +++ b/Config.mk @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/git-http/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc index d38e4ce074b399946aecdaedb4cb6fe5b8043b66..a94fb57eb568e85a25c93bf6a988f123d4e48443 100644 --- a/docs/misc/livepatch.pandoc +++ b/docs/misc/livepatch.pandoc @@ -993,7 +993,7 @@ The design of that is not discussed in this design. This is implemented in a seperate tool which lives in a seperate GIT repo. -Currently it resides at git://xenbits.xen.org/livepatch-build-tools.git +Currently it resides at https://xenbits.xen.org/git-http/livepatch-build-tools.git ### Exception tables and symbol tables growth diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index 8f80d61d2f1aa9e63da9b1e61b77a67c826efe6f..7826419dad563a3b70c3c97fc4c0fb5339bd58e9 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -271,7 +271,7 @@ Hi all, Xen X.Y rcZ is tagged. You can check that out from xen.git: -git://xenbits.xen.org/xen.git X.Y.0-rcZ +https://xenbits.xen.org/git-http/xen.git X.Y.0-rcZ For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/X.Y.0-rcZ/xen-X.Y.0-rcZ.tar.gz diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..cf629cdf3c44e4abe67214378c49a3a9d858d9b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/git-http/xen.git\n"); $printed_novcs = 1; } return 0; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Feb 17 21:36:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 21:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497309.768237 (Exim 4.92) (envelope-from ) id 1pT8ON-0005eh-Vs; Fri, 17 Feb 2023 21:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497309.768237; Fri, 17 Feb 2023 21:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8ON-0005ea-T2; Fri, 17 Feb 2023 21:35:43 +0000 Received: by outflank-mailman (input) for mailman id 497309; Fri, 17 Feb 2023 21:35:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OM-0005eU-W5 for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 21:35:43 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04bf2d19-af0b-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 22:35:40 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 994BB320030E; Fri, 17 Feb 2023 16:35:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 17 Feb 2023 16:35:36 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 16:35:33 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04bf2d19-af0b-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676669735; x=1676756135; bh=MGcjZgooPU4cVCfzNgS6jrb+K4sHboY2z/T xtj3xkoY=; b=pYTtTqGzCSSjtkBq5troOdPs5ICo/HLZhre4QvsnyVg3UNt9VJl TxyGNf3LrWJrTHmDPHyJDp/7Itur51flu4DhvPHJNYLV3hxzqt/cU5zMcbLV7qQr ciBxQhYUFIcFJ2oVQd1bBt30g+5xeW/Zv2rJx1QYfqap/kbDU/4EtEPSrzuFJct3 GU3fqhQkwVtTwzbBy2HzYYIQ7Aev/CbE6QEJGUPos8i4KFt/f0q7M0i0sewJuuMZ ss/4R6Gv9UXdWE/mok96Yjqnoq+IkiwhCjdIXu534lSfewnDssKnB4KtFNG/C5lz JRrnKfPCbo5J1ybeVuPCDzw+ajH4/m+hIpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676669735; x=1676756135; bh=MGcjZgooPU4cV CfzNgS6jrb+K4sHboY2z/Txtj3xkoY=; b=GD0wAo35BMrhGIqt1CgQ7SGEETen8 h2zXF8DLWhkjeJ5afeiIr1KNKMi2hzraQJdAzzJn58z47zLpqXbYm+R39/i1sXTB zHMn8xmT5hfvaveOC9qe+5NESrAzWicPv5MwS+LR2hQbv4DYn3q6RQGct0QECnxF XIj563E++3xv2yjk8h5xyO2zMDhsgIo1MyS3a4jTiROnAHdTKqrXCJZEnScI97db wkIPF4rX+LsIu2WXQaDnbIDrn5b8kkNUbZt5ankv2OJr2HwPIy48Xq2CHCTBu4e6 MEBxj1F+HghKabJAULH+L4G8IqnurLIagS1zP86usOmk9ANf2BdxHnsmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefffffffeegvefftdeifeeiveeu gffhheetjedvhfetveekkeefkedvgeekffelgeenucffohhmrghinhepgigvnhdrohhrgh dprhhiphhouhhthhihphgvrhhtrhgrnhhsphhorhhttghonhhfihhgrdhmkhenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Samuel Thibault , Anthony PERARD , Doug Goldstein Subject: [PATCH v3 0/4] Stop using insecure transports Date: Fri, 17 Feb 2023 16:35:23 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Changes since v2: - Drop patches 5 and 6, which changed links not used by automated tools. These patches are the least urgent and hardest to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (4): Use HTTPS for all xenbits.xen.org Git repos Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http:// with https:// Rip out HyperTransport Config.mk | 20 ++++------- README | 4 +-- automation/build/centos/CentOS-7.2.repo | 8 ++--- automation/build/debian/stretch-llvm-8.list | 4 +-- automation/build/debian/unstable-llvm-8.list | 4 +-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 24 ++++++++----- stubdom/configure.ac | 24 ++++++++----- tools/firmware/etherboot/Makefile | 6 +--- xen/include/xen/pci_regs.h | 37 -------------------- 13 files changed, 51 insertions(+), 88 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Feb 17 21:36:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 21:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497311.768259 (Exim 4.92) (envelope-from ) id 1pT8OT-0006B7-FN; Fri, 17 Feb 2023 21:35:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497311.768259; Fri, 17 Feb 2023 21:35:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OT-0006B0-Bs; Fri, 17 Feb 2023 21:35:49 +0000 Received: by outflank-mailman (input) for mailman id 497311; Fri, 17 Feb 2023 21:35:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OR-0005eU-QN for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 21:35:48 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09929037-af0b-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 22:35:46 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B4231320090D; Fri, 17 Feb 2023 16:35:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 17 Feb 2023 16:35:45 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 16:35:43 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09929037-af0b-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676669744; x=1676756144; bh=7H05pNS9CTfuyobI73U4y0lxpnA2i8YdcBl f5sTJHn4=; b=flOUQEejh+KLmQBb4L1wyRYOqhM8u6sPfbsgzYurCA6zdU1bTm3 7F0RtO/e79xzRMF7QhcDM/mxLdHbbbEvbjyRY7fAaZwTqp/WnwtkuKpMPpsDCqFE WEwUzDvFKJOvJ4JnBbyQNLgOrcUtbk9kM43eN2g21DYQRL72vSEZqiWrO7ueR5/+ DSwGImmyDM/M9N3wntRn0ufjFnaG7Yv+pvfcrPu2tMc4CclfMktO1bmxyzpKl4O+ +EDdcvT+haJeOE4r51rjl3w2pM1B1LVwyZV3nSSUTsknUfEdmzns8YtP5FYus2ir yuTJeIgIewU6o0RLCR1EWsQpgCQeanh+Bdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676669744; x=1676756144; bh=7H05pNS9CTfuy obI73U4y0lxpnA2i8YdcBlf5sTJHn4=; b=Ba0ANo2Pc7QXLvvsjYq05SpmKiK3W QQDwW+tANHJ7ubU+K3f83766rLuNR9v46eq2PfjbJ+8m3Ta0GNWS/i6SrMPLzMHW kw5gLf7uppPRBb+q+1aTu4TXAQ5U1Ip0wDK5ZtcRUraVQmvLal6zjcjd5WLpj2P+ zIErgEStIoEyM/6pPwoCilRKPcIaOptsdB4gk8+HIBblLKuLJgSLzarfgtlhf+1J iMMj6MMNtsTl0D4gKBEOz7qP4SJIMQBBWp2l50+1gisgmuWoGhijJ1rQP/pWurBw fFsxqXnb3/lShx5YptqK6gfrgGHWAzLdYfksZkiAb6pXHQ5Pwlk0CZQFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeduveeuudegudduuefftedujeek ffekgeekudfhiefhiedvudejfeejtdeitdevueenucffohhmrghinhepiihlihgsrdhnvg htpdigvghnrdhorhhgpdhkvghrnhgvlhdrohhrghdprhgvughhrghtrdgtohhmpdhsohhu rhgtvgifrghrvgdrohhrghdpghhnuhdrohhrghdpihhnrhhirgdrfhhrpdhgmhhplhhisg drohhrghdpphholhgrrhhsshhlrdhorhhgpdgsvghrlhhiohhsrdguvgdpihhpgigvrdho rhhgpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgt ohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// Date: Fri, 17 Feb 2023 16:35:25 -0500 Message-Id: <0aaad173b15304e2ab00749b4e5ad79c6e111589.1676668923.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Some URLs returned 301 or 302 redirects, so I replaced them with the URLs that were redirected to. I also found that the old zlib used in the I/O emulator stubdomain can no longer be obtained from https://www.zlib.net and that the TPM emulator and PolarSSL (used by the vTPM and vTPM manager stubdomains) can no longer be obtained from their respective original URLs. Therefore, configure will now error out instead of trying to download them. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- stubdom/configure | 24 +++++++++++++++--------- stubdom/configure.ac | 24 +++++++++++++++--------- tools/firmware/etherboot/Makefile | 6 +----- 4 files changed, 32 insertions(+), 24 deletions(-) diff --git a/Config.mk b/Config.mk index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..e40aca9afd0de2c5074978d654d4e78f4f63e3d2 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : ZLIB_URL=\$\(XEN_EXTFILES_URL\) else - ZLIB_URL="http://www.zlib.net" + ZLIB_URL="https://www.zlib.net" fi fi @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://mirrors.edge.kernel.org/pub/software/utils/pciutils" fi fi @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sourceware.org/ftp/newlib" fi fi @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3607,7 +3607,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://gmplib.org/download/gmp/archive" fi fi @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" = "x"; then : if test "x$extfiles" = "xy"; then : POLARSSL_URL=\$\(XEN_EXTFILES_URL\) else - POLARSSL_URL="http://polarssl.org/code/releases" + POLARSSL_URL="https://polarssl.org/code/releases" fi fi @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" = "x"; then : if test "x$extfiles" = "xy"; then : TPMEMU_URL=\$\(XEN_EXTFILES_URL\) else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" + TPMEMU_URL="https://download.berlios.de/tpm-emulator" fi fi @@ -3669,6 +3669,12 @@ vtpmmgr="n" fi +if test "x$vtpm" != xn || test "x$vtpmmgr" != xn || test "x$ioemu" != xn; then + if test "x$extfiles" != xy; then + as_fn_error $? "Sources needed for the vTPM, vTPM manager, and IO emulator stubdomains are no longer at their original URLs" "$LINENO" 5 + fi +fi + #Conditionally enable these stubdoms based on the presense of dependencies if test "x$vtpm" = "xy" || test "x$vtpm" = "x"; then : diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..d27f2bc1f17140ab41a687e1e8faaa66e2b4483b 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,19 +55,25 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://mirrors.edge.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gmp/archive]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/code/releases]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://download.berlios.de/tpm-emulator]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) +if test "x$vtpm" != xn || test "x$vtpmmgr" != xn || test "x$ioemu" != xn; then + if test "x$extfiles" != xy; then + AC_MSG_ERROR([Sources needed for the vTPM, vTPM manager, and IO emulator stubdomains are no longer at their original URLs]) + fi +fi + #Conditionally enable these stubdoms based on the presense of dependencies AX_STUBDOM_CONDITIONAL_FINISH([vtpm-stubdom], [vtpm]) AX_STUBDOM_CONDITIONAL_FINISH([vtpmmgr-stubdom], [vtpmmgr]) diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..6ab9e5bc6b4cc750f2e802128fbc71e9150397b1 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -4,11 +4,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk include Config -ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git -else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git -endif +IPXE_GIT_URL ?= https://github.com/ipxe/ipxe.git # put an updated tar.gz on xenbits after changes to this variable IPXE_GIT_TAG := 3c040ad387099483102708bb1839110bc788cefb -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Feb 17 21:36:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 21:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497312.768270 (Exim 4.92) (envelope-from ) id 1pT8OY-0006V6-Nk; Fri, 17 Feb 2023 21:35:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497312.768270; Fri, 17 Feb 2023 21:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OY-0006Ux-KZ; Fri, 17 Feb 2023 21:35:54 +0000 Received: by outflank-mailman (input) for mailman id 497312; Fri, 17 Feb 2023 21:35:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8OW-0006Se-Pq for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 21:35:52 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b6f53a6-af0b-11ed-93b5-47a8fe42b414; Fri, 17 Feb 2023 22:35:50 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E75C7320089C; Fri, 17 Feb 2023 16:35:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 17 Feb 2023 16:35:48 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 16:35:46 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b6f53a6-af0b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676669747; x=1676756147; bh=x1U4BNcj9Zecyq6U+qye/Zm4u8N3JEG92kP 6XRxNw5M=; b=EuxNTi/WJ2evETCOCnkyHZhhBD0GadXH9uWRmgjPhdLHGUkv/Z5 Mb+F/VcW8VvXF/AhUiQaGtXYtTEoCSU1x+/hBBJvmPtX1zRrqrSvz682GvojzWgl ACYx9MboiAT489YllvUncTdLgXbpKTOw/KDZbFRahxhYHuqui9CVeqiwvP3bPr++ UJhZiRoLKBuVoNTzMx0FakLzoCoOVue8OAXa7uz7P7PDDi4+B34lzlJinbPXRDLL QKPm4U/QPughND35egun7eEBrfnScBzEmvl758HVBe2H4AApDR8UWy8TYiWgPQoE v1UHrbklpCfifoq0P3vIAUpBi/125UbzSVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676669747; x=1676756147; bh=x1U4BNcj9Zecy q6U+qye/Zm4u8N3JEG92kP6XRxNw5M=; b=rESrJyygVPh4xQWZRYa7i9FIQysje mMg2ZrCXAJ4erSPAZSInLg52d6QXckImWDRMV7xzaX/kYQ6rrg9kTcmrlrjkJw0c WDj4Zd91rVmMxemvhnO+5uQ3vkaWjp0uMIVDM/WdSKZehGU5LrUfA0UAUN8EM1nL KHk7v23YDocNk5IdJPTivjzr88zzD1atLjlzgNA2dwDV6oVkXSv/G0ZhmfALGwOq 5yBQSL85C2YRJBoXvD/hrQhmHBSejLxqIwi/rlTvWWdgtpyHy91HO6uNIIAc/UyF Bn5v8w8jGuSNjaAjxwnXNlQvPI+tW5PwBWjGzUCBE0J++qeGL174uLSdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetudeuheegueejgeduieffffev leetleejveduieelffeitefggeffieetvdekueenucffohhmrghinhepphihthhhohhnrd horhhgpdhinhhtvghlrdgtohhmpdgtvghnthhoshdrohhrghdplhhlvhhmrdhorhhgpdgu vggsihgrnhdrohhrghdprghlphhinhgvlhhinhhugidrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghl vghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: [PATCH v3 3/4] Automation and CI: Replace git:// and http:// with https:// Date: Fri, 17 Feb 2023 16:35:26 -0500 Message-Id: <5063d50f393401b302018451c223b2a7d5c6c5c7.1676668923.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie Obenour --- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo index 4da27faeb5fa863fd4e140cbeaad308b9a543b86..8e37da1a03f839c486eb9bd0af46716cfb9086e0 100644 --- a/automation/build/centos/CentOS-7.2.repo +++ b/automation/build/centos/CentOS-7.2.repo @@ -6,28 +6,28 @@ [base] name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #released updates [updates] name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/updates/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that may be useful [extras] name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/extras/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that extend functionality of existing packages [centosplus] name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/centosplus/$basearch/ gpgcheck=1 gpgcheck=1 enabled=0 diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list index dc119fa0b4df1bd6e742c42776710abcd6deaa86..1db1598997429d7a14d3fcd8f0f8152aa6d40b8a 100644 --- a/automation/build/debian/unstable-llvm-8.list +++ b/automation/build/debian/unstable-llvm-8.list @@ -1,3 +1,3 @@ # Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb https://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb-src https://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..950ad3a0daa63d66fc8647c0a390ff59c2f22b1a 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://ftp.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Feb 17 21:36:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 21:36:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497316.768281 (Exim 4.92) (envelope-from ) id 1pT8Oe-0006rk-5p; Fri, 17 Feb 2023 21:36:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497316.768281; Fri, 17 Feb 2023 21:36:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8Oe-0006rZ-2a; Fri, 17 Feb 2023 21:36:00 +0000 Received: by outflank-mailman (input) for mailman id 497316; Fri, 17 Feb 2023 21:35:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT8Od-0005eU-5l for xen-devel@lists.xenproject.org; Fri, 17 Feb 2023 21:35:59 +0000 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1062e39a-af0b-11ed-933d-83870f6b2ba8; Fri, 17 Feb 2023 22:35:58 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4C775320025E; Fri, 17 Feb 2023 16:35:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 17 Feb 2023 16:35:56 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 16:35:54 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1062e39a-af0b-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676669755; x=1676756155; bh=cPvNK4bRedLwQjVJg5m10GmXqhwI307WgJ3 tNvm6++Q=; b=A/Zl1nTSSt/7E1c/+8eNIh2CNPS+3KLcHJ+PjBKQTyf43ODkiRY f45PLWkE7sscQG+I6Opblp5v1Z7gtoEciM9wXxGuMsUv6Nv3MopPwfeYA14ZeJjx CMyQuesyBMrrAZhw2GdiobvQNL00BUOAE/NAeX/kmz7ESMTbykK+dL46WKIvbbFG 6EKaLUOEdpfLunsa25TuFJAoODWgLcMF/N24JuYiHhyzVydxqNqkTJE36udUZoFN xfHO5dX/+lq99ZRPz5kfY//DiN4pV8JlAr4RBsfRoVvmieCf+1gBkg43w/8XIjLW NxwqfQKiISzQafv/qXMjCwwrtj+pkDyGXRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676669755; x=1676756155; bh=cPvNK4bRedLwQ jVJg5m10GmXqhwI307WgJ3tNvm6++Q=; b=thGHifTuQfzp913urqV1jXIrG3gYB qSyuXjGCsrxn39EsWgIxtqhpZqmf8JH7as1AFdMzO99mMfzGmb1mEEuENPfBDp+B 8UXhNMCcMywYK5sNr/DBkR3CC6nVLlW2MICS0tQhdFRnOPegamIbUqpRhVfAZnZG ZYZNx6ukWisuvQVoNpfjjOuiXZ0jb7G8lFMdoUVe0qB/ZD/7bq6q+wyx2GnWzIrZ bGvueZnHaAIw75Ot4nO/eAbLvjg4ONIltw2QC6MsB4fLB8Jvg8wmV+TFkHb4Fmi+ Gxl855ediJdcieGG45O0P8Pqng79VCNtrGMQnAFWo6Ke2sEUVUAlEdNBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvtdettefgheduueeiudevleev udeifefguefgvdffudeugfdugfetueetveetheenucffohhmrghinhephhihphgvrhhtrh grnhhsphhorhhtrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 4/4] Rip out HyperTransport Date: Fri, 17 Feb 2023 16:35:27 -0500 Message-Id: <9c5befd1718b546be410e33999e77be91f5cfc59.1676668923.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It is not used and the website is gone. Signed-off-by: Demi Marie Obenour --- xen/include/xen/pci_regs.h | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index a90aff1712bafc6ed87296858803d16c253e7b53..2b37fe2a464345877faa99a9dce695998910b6bf 100644 --- a/xen/include/xen/pci_regs.h +++ b/xen/include/xen/pci_regs.h @@ -12,11 +12,6 @@ * PCI Local Bus Specification * PCI to PCI Bridge Specification * PCI System Design Guide - * - * For hypertransport information, please consult the following manuals - * from http://www.hypertransport.org - * - * The Hypertransport I/O Link Specification */ #ifndef LINUX_PCI_REGS_H @@ -529,38 +524,6 @@ #define PCI_VNDR_HEADER_REV(x) (((x) >> 16) & 0xf) #define PCI_VNDR_HEADER_LEN(x) (((x) >> 20) & 0xfff) -/* - * Hypertransport sub capability types - * - * Unfortunately there are both 3 bit and 5 bit capability types defined - * in the HT spec, catering for that is a little messy. You probably don't - * want to use these directly, just use pci_find_ht_capability() and it - * will do the right thing for you. - */ -#define HT_3BIT_CAP_MASK 0xE0 -#define HT_CAPTYPE_SLAVE 0x00 /* Slave/Primary link configuration */ -#define HT_CAPTYPE_HOST 0x20 /* Host/Secondary link configuration */ - -#define HT_5BIT_CAP_MASK 0xF8 -#define HT_CAPTYPE_IRQ 0x80 /* IRQ Configuration */ -#define HT_CAPTYPE_REMAPPING_40 0xA0 /* 40 bit address remapping */ -#define HT_CAPTYPE_REMAPPING_64 0xA2 /* 64 bit address remapping */ -#define HT_CAPTYPE_UNITID_CLUMP 0x90 /* Unit ID clumping */ -#define HT_CAPTYPE_EXTCONF 0x98 /* Extended Configuration Space Access */ -#define HT_CAPTYPE_MSI_MAPPING 0xA8 /* MSI Mapping Capability */ -#define HT_MSI_FLAGS 0x02 /* Offset to flags */ -#define HT_MSI_FLAGS_ENABLE 0x1 /* Mapping enable */ -#define HT_MSI_FLAGS_FIXED 0x2 /* Fixed mapping only */ -#define HT_MSI_FIXED_ADDR 0x00000000FEE00000ULL /* Fixed addr */ -#define HT_MSI_ADDR_LO 0x04 /* Offset to low addr bits */ -#define HT_MSI_ADDR_LO_MASK 0xFFF00000 /* Low address bit mask */ -#define HT_MSI_ADDR_HI 0x08 /* Offset to high addr bits */ -#define HT_CAPTYPE_DIRECT_ROUTE 0xB0 /* Direct routing configuration */ -#define HT_CAPTYPE_VCSET 0xB8 /* Virtual Channel configuration */ -#define HT_CAPTYPE_ERROR_RETRY 0xC0 /* Retry on error configuration */ -#define HT_CAPTYPE_GEN3 0xD0 /* Generation 3 hypertransport configuration */ -#define HT_CAPTYPE_PM 0xE0 /* Hypertransport powermanagement configuration */ - /* Access Control Service */ #define PCI_ACS_CAP 0x04 /* ACS Capability Register */ #define PCI_ACS_SV 0x01 /* Source Validation */ -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Feb 17 23:18:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 17 Feb 2023 23:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497352.768292 (Exim 4.92) (envelope-from ) id 1pT9zu-0004Ya-OX; Fri, 17 Feb 2023 23:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497352.768292; Fri, 17 Feb 2023 23:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT9zu-0004YT-KI; Fri, 17 Feb 2023 23:18:34 +0000 Received: by outflank-mailman (input) for mailman id 497352; Fri, 17 Feb 2023 23:18:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT9zt-0004YJ-3A; Fri, 17 Feb 2023 23:18:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT9zt-0002lb-09; Fri, 17 Feb 2023 23:18:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pT9zs-0006uj-Dg; Fri, 17 Feb 2023 23:18:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pT9zs-0006Ab-DF; Fri, 17 Feb 2023 23:18:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nUiAB5GI7/g73vD9XVZxzkOmAZ4PBmpAg/N6EvUpA1I=; b=hYWoIvRbuFF/L0d3ojBxcSsfPo PvoiJl6MsxCSHYeeYJ0HWIMZ2Gtg3zBjiZ5X+xQuP8PG4HWbdXp30dQaIHWZu5YI0ERetJAHeWK50 je8D7PPxCyfcdfKRgc+kTf77kuf3Vm3xDRPKcpK3MyXJwnaFUuoHQCqTQmCkm2hhhou0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177591: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=f5c1a6374aae8be471b895a43359dcff355577f5 X-Osstest-Versions-That: xen=5b9bb91abba7c983def3b4bef71ab08ad360a242 From: osstest service owner Date: Fri, 17 Feb 2023 23:18:32 +0000 flight 177591 xen-unstable real [real] flight 177653 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177591/ http://logs.test-lab.xenproject.org/osstest/logs/177653/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 177653-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177428 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177428 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177428 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177428 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen f5c1a6374aae8be471b895a43359dcff355577f5 baseline version: xen 5b9bb91abba7c983def3b4bef71ab08ad360a242 Last test of basis 177428 2023-02-15 22:10:26 Z 2 days Failing since 177485 2023-02-16 10:25:30 Z 1 days 3 attempts Testing same since 177591 2023-02-17 09:52:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Henry Wang #Arm Jan Beulich Julien Grall Michal Orzel Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5b9bb91abb..f5c1a6374a f5c1a6374aae8be471b895a43359dcff355577f5 -> master From xen-devel-bounces@lists.xenproject.org Sat Feb 18 00:08:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 00:08:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497382.768347 (Exim 4.92) (envelope-from ) id 1pTAlV-00049x-Mx; Sat, 18 Feb 2023 00:07:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497382.768347; Sat, 18 Feb 2023 00:07:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlV-00049q-Ir; Sat, 18 Feb 2023 00:07:45 +0000 Received: by outflank-mailman (input) for mailman id 497382; Sat, 18 Feb 2023 00:07:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlT-00049k-FT for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 00:07:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41e6a6f7-af20-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 01:07:40 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 506D66209D; Sat, 18 Feb 2023 00:07:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CCEAC433D2; Sat, 18 Feb 2023 00:07:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41e6a6f7-af20-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676678858; bh=dtcsD15OQKDU2cBT/fXtKtZyqSxl6TGj3qAeIGgxHN8=; h=Date:From:To:cc:Subject:From; b=GVy6S6kkEGUxjG6EraPkou7JAqRi86/SmwXr/F16gq2TxPk5PN0URDaqVAxGPsQB4 FhhZKboi6PgF1KzgTowwgFgrfOIbwo/LacuA0mQCkEpwS4fgdoQmD6tXJQ+EuagMar WsA/tyFs2U486GTNkDqKboQqUvSTO6ivBdJv6Dk1+3N4Z51GImLMs+q0w9zjEMVaPr FhCo4YqjxbWI/+YBzuSx85+x0/mqUPlUDnj5P4FT4mxqzn5K8ocfLMHsXy1WR9cIP+ cMq0oZna8miXKwyZNAsALS4Zmh+vO0zMSvtWgqYkuj7RhqKQ6g0ZYy5N9yxGQhkBsH jL4jGmmdVc5NQ== Date: Fri, 17 Feb 2023 16:07:36 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: xen-devel@lists.xenproject.org cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com Subject: [PATCH v3 0/3] automation: add arm32 xl domU creation test Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This patch series add a domU creation test based on xl for arm32. To do that, it reuses the existing arm32 dom0 test, and also reuses the Yocto qemuarm build output. Pipeline (with reduced amount of jobs): https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/781740574 Cheers, Stefano Stefano Stabellini (3): automation: move yocto jobs to build stage automation: add binaries/ to artifacts for Yocto arm32 job automation: expand arm32 dom0 test adding xl domain creation automation/build/yocto/build-yocto.sh | 16 +++++++++ automation/gitlab-ci/build.yaml | 53 +++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 56 ++--------------------------- automation/scripts/qemu-smoke-dom0-arm32.sh | 52 ++++++++++++++++++++------- 4 files changed, 110 insertions(+), 67 deletions(-) From xen-devel-bounces@lists.xenproject.org Sat Feb 18 00:08:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 00:08:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497383.768357 (Exim 4.92) (envelope-from ) id 1pTAlf-0004Rh-30; Sat, 18 Feb 2023 00:07:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497383.768357; Sat, 18 Feb 2023 00:07:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlf-0004RY-04; Sat, 18 Feb 2023 00:07:55 +0000 Received: by outflank-mailman (input) for mailman id 497383; Sat, 18 Feb 2023 00:07:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAle-00049k-9V for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 00:07:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48f14359-af20-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 01:07:52 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 502FE62027; Sat, 18 Feb 2023 00:07:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F26F5C433D2; Sat, 18 Feb 2023 00:07:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48f14359-af20-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676678870; bh=eUlQ2APESts0KA52L+gW/CObn9jC9xSw37MuWYocq/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S/6bIW8WuMo6WZuj+xNOII5k/p1taF2QhZ9oyCU1Hvf880dbJMlgouSWHR1+Lc7c2 T85c6lClqNHXHmV/ViHl6Flg0+eTy5lukFV81JO5Rj6GPE2Q0vC6T1SzddAx1P7ZS0 H+Q1r9Z4AdwKsM0PX+3KxtTGbaAAv2zdYpUwiX1HqHqeSd3NCthBu4gbrxYEFQeJOl Ok2joly/5PzlcIbYPju7dfY4J4NkPAqfqabjJnmoB/DQS6IOU8BxSEoudcYLj6nASM ifWzwXA4kQK0BW8AavDtXYwAvgg2gUVZJLO8KCPpw/nOBthvwhNviO+E4EkGT8jDPs 5EzRZjmghAxYA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v3 1/3] automation: move yocto jobs to build stage Date: Fri, 17 Feb 2023 16:07:45 -0800 Message-Id: <20230218000747.2965719-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini We are going to use artifacts produced by the Yocto builds in test jobs. Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel --- automation/gitlab-ci/build.yaml | 51 +++++++++++++++++++++++++++++++++ automation/gitlab-ci/test.yaml | 45 ----------------------------- 2 files changed, 51 insertions(+), 45 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 079e9b73f6..b6ae1c663b 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -199,6 +199,41 @@ variables: <<: *gcc +.yocto-test: + stage: build + image: registry.gitlab.com/xen-project/xen/${CONTAINER} + except: + - master + - smoke + - /^coverity-tested\/.*/ + - /^stable-.*/ + script: + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + variables: + YOCTO_VERSION: kirkstone + CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} + artifacts: + paths: + - 'logs/*' + when: always + needs: [] + +.yocto-test-arm64: + extends: .yocto-test + variables: + YOCTO_HOST: arm64v8 + tags: + - arm64 + +# This is not used by any test job as we only run Yocto on arm based machines. +# Keep it here so that someone having x86 hardware can easily add jobs. +.yocto-test-x86-64: + extends: .yocto-test + variables: + YOCTO_HOST: amd64 + tags: + - x86_64 + # Jobs below this line archlinux-gcc: @@ -699,6 +734,22 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Yocto test jobs +yocto-qemuarm64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm64 + +yocto-qemuarm: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemuarm + +yocto-qemux86-64: + extends: .yocto-test-arm64 + variables: + YOCTO_BOARD: qemux86-64 + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index c0b4a90e0d..00273b21c8 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -67,35 +67,6 @@ tags: - x86_64 -.yocto-test: - extends: .test-jobs-common - script: - - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} - variables: - YOCTO_VERSION: kirkstone - CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} - artifacts: - paths: - - 'logs/*' - when: always - needs: [] - -.yocto-test-arm64: - extends: .yocto-test - variables: - YOCTO_HOST: arm64v8 - tags: - - arm64 - -# This is not used by any test job as we only run Yocto on arm based machines. -# Keep it here so that someone having x86 hardware can easily add jobs. -.yocto-test-x86-64: - extends: .yocto-test - variables: - YOCTO_HOST: amd64 - tags: - - x86_64 - # Test jobs build-each-commit-gcc: extends: .test-jobs-common @@ -317,19 +288,3 @@ qemu-smoke-riscv64-gcc: - ./automation/scripts/qemu-smoke-riscv64.sh 2>&1 | tee ${LOGFILE} needs: - archlinux-current-gcc-riscv64-debug - -# Yocto test jobs -yocto-qemuarm64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm64 - -yocto-qemuarm: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemuarm - -yocto-qemux86-64: - extends: .yocto-test-arm64 - variables: - YOCTO_BOARD: qemux86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Feb 18 00:08:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 00:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497384.768369 (Exim 4.92) (envelope-from ) id 1pTAlh-0004i6-C3; Sat, 18 Feb 2023 00:07:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497384.768369; Sat, 18 Feb 2023 00:07:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlh-0004hu-9A; Sat, 18 Feb 2023 00:07:57 +0000 Received: by outflank-mailman (input) for mailman id 497384; Sat, 18 Feb 2023 00:07:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlf-00049k-Qe for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 00:07:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 498b7b5f-af20-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 01:07:53 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5395D6209D; Sat, 18 Feb 2023 00:07:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1560DC4339C; Sat, 18 Feb 2023 00:07:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 498b7b5f-af20-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676678871; bh=ReIRkrUsD0aUe+sTs/xO/eCMbv89yibMdXJjNiWEuAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQAS7xGmEushY27lNqqHLEenfNcDuYaKE+/0N40gzg7jRPHhPRb9MtotVPHL3bu/D px9xCTX686rQk/SkR0+UWcTL6a12fxpTvOiejKVQGS1DydYxEbUdf/mubzDnlK3dKH FZ39joQ6KWFt3Zns8SrXTmRO3kQ+fVvaSc4aN9Sl38culfDEVbPmEFHfS17ZNRASgt CTHlF6hYob4UIEmF8u7x2OZjE1x7Cc056A034k1D5NcwxeQoGDY34p4/8eBi0AHv7K lH2TvmDcHEdnII1FyPmu/AJ2a1DOKVxIyAV1c9eIsV03057wsILS30RrtxnawIkpMw YASyorI4o+/GA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v3 2/3] automation: add binaries/ to artifacts for Yocto arm32 job Date: Fri, 17 Feb 2023 16:07:46 -0800 Message-Id: <20230218000747.2965719-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Copy the build output of Yocto builds to binaries/ for the arm32 target, and export binaries/ among the jobs artifacts so that they can be reused by other jobs. Signed-off-by: Stefano Stabellini --- Changes in v2: - add --copy-output so that whether the binaries get copied or not is user selectable - rename OUTPUT to OUTPUTDIR and move it up in the file --- automation/build/yocto/build-yocto.sh | 16 ++++++++++++++++ automation/gitlab-ci/build.yaml | 4 +++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh index 3601cebc3c..93ce81ce82 100755 --- a/automation/build/yocto/build-yocto.sh +++ b/automation/build/yocto/build-yocto.sh @@ -18,6 +18,7 @@ CACHEDIR="$HOME/yocto-cache" LOGDIR="$HOME/logs" XENDIR="$HOME/xen" BUILDDIR="$HOME/build" +OUTPUTDIR=`pwd`/binaries # what yocto bsp we support TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" @@ -31,6 +32,7 @@ do_build="y" do_run="y" do_localsrc="n" do_dump="n" +do_copy="n" build_result=0 # layers to include in the project @@ -166,6 +168,16 @@ function project_build() { source "${YOCTODIR}/poky/oe-init-build-env" "${destdir}" bitbake "${build_image}" || exit 1 + if [ $do_copy = "y" ] + then + if [ $target = "qemuarm" ] + then + mkdir -p $OUTPUTDIR + cp $BUILDDIR/tmp/deploy/images/qemuarm/zImage $OUTPUTDIR + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-qemuarm $OUTPUTDIR + cp $BUILDDIR/tmp/deploy/images/qemuarm/xen-image-minimal-qemuarm.tar.bz2 $OUTPUTDIR + fi + fi ) || return 1 } @@ -235,6 +247,7 @@ Options: Default: ${CACHEDIR} --layer-dir=DIR directory containing the checkout of yocto layers Default: ${YOCTODIR} + --copy-output Copy output binaries to binaries/ EOF } @@ -290,6 +303,9 @@ do --layer-dir=*) YOCTODIR="${OPTION#*=}" ;; + --copy-output) + do_copy="y" + ;; --*) echo "Invalid option ${OPTION}" help diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index b6ae1c663b..d731642785 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -208,13 +208,14 @@ - /^coverity-tested\/.*/ - /^stable-.*/ script: - - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} + - ./automation/build/yocto/build-yocto.sh -v --log-dir=./logs --xen-dir=`pwd` ${YOCTO_BOARD} ${YOCTO_OUTPUT} variables: YOCTO_VERSION: kirkstone CONTAINER: yocto:${YOCTO_VERSION}-${YOCTO_BOARD}-${YOCTO_HOST} artifacts: paths: - 'logs/*' + - binaries/ when: always needs: [] @@ -744,6 +745,7 @@ yocto-qemuarm: extends: .yocto-test-arm64 variables: YOCTO_BOARD: qemuarm + YOCTO_OUTPUT: --copy-output yocto-qemux86-64: extends: .yocto-test-arm64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Feb 18 00:08:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 00:08:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497385.768380 (Exim 4.92) (envelope-from ) id 1pTAli-0004yH-JI; Sat, 18 Feb 2023 00:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497385.768380; Sat, 18 Feb 2023 00:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAli-0004y7-GT; Sat, 18 Feb 2023 00:07:58 +0000 Received: by outflank-mailman (input) for mailman id 497385; Sat, 18 Feb 2023 00:07:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTAlg-0004hK-IB for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 00:07:56 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a684696-af20-11ed-933d-83870f6b2ba8; Sat, 18 Feb 2023 01:07:54 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D48AB81F9C; Sat, 18 Feb 2023 00:07:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A1FC4339B; Sat, 18 Feb 2023 00:07:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a684696-af20-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676678872; bh=rUrGZbmK5uUfTRLHvZznH/0nYIsKj1VaIsQqXSJ4KcE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fdXfXs0hIdsyOK/tzub8r8b40+y1tj/20arJhlZdrXRSh4aSGvc/hzZIcWuwvcNjS EOUAT8mB9eQ9G+erZQA1ahtN0+SDK88M0+B5DPNqlYtvz6PyTa7ah36onBZbi0lQ7R tBeLKAfNpcK6IHtGeOiioj0Q3Ec4pTiKSghSEoRJZYWWXpKNgJKaOC+CpoLNjNk5l2 OGhr6zd2hIu8g3JubpRzVblukLM2drJlIaYLNOjdkTy3rLWJvEkJe/0r3c+ySUIZd/ kzhwZ7Wh8SzCRjwwWNwIk5KGl3nFrFMuc+hCrVNB9kmSwifmiMYKz+N6Ex3lDrAhMt wqC7AmYezZ4iQ== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, cardoe@cardoe.com, michal.orzel@amd.com, Stefano Stabellini Subject: [PATCH v3 3/3] automation: expand arm32 dom0 test adding xl domain creation Date: Fri, 17 Feb 2023 16:07:47 -0800 Message-Id: <20230218000747.2965719-3-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini As part of the arm32 dom0 test, also create a simple domU using xl. To do that, we need the toolstack installed in the dom0 rootfs. We switch to using the kernel and rootfs built by the Yocto arm32 job. Remove the PCI node from the host device tree: it is unused but causes a Linux hang at boot. Use xen-watchdog to trigger the domU creation for convience (/etc/local.d is not handled by rootfs.) Signed-off-by: Stefano Stabellini --- Changes in v2: - remove unsued debian-unstable-gcc-arm32 dependency for qemu-smoke-dom0-arm32-gcc - remove job qemu-smoke-dom0-arm32-gcc-debug as it doesn't make sense anymore - grep for both dom0 and domU prompts in qemu-smoke-dom0-arm32.sh --- automation/gitlab-ci/test.yaml | 11 +---- automation/scripts/qemu-smoke-dom0-arm32.sh | 52 +++++++++++++++------ 2 files changed, 41 insertions(+), 22 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 00273b21c8..6d09c97702 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -171,15 +171,7 @@ qemu-smoke-dom0-arm32-gcc: - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE} needs: - *arm32-test-needs - - debian-unstable-gcc-arm32 - -qemu-smoke-dom0-arm32-gcc-debug: - extends: .qemu-arm32 - script: - - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE} - needs: - - *arm32-test-needs - - debian-unstable-gcc-arm32-debug + - yocto-qemuarm qemu-smoke-dom0less-arm32-gcc: extends: .qemu-arm32 @@ -244,6 +236,7 @@ qemu-smoke-dom0less-arm32-gcc-debug-without-dom0: needs: - *arm32-test-needs - debian-unstable-gcc-arm32-debug + - yocto-qemuarm qemu-alpine-x86_64-gcc: extends: .qemu-x86-64 diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f6..2c80df089f 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -3,14 +3,37 @@ set -ex cd binaries -# Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz -# Use a tiny initrd based on busybox from Alpine Linux -curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz +mkdir rootfs +cd rootfs +tar xvf ../xen-image-minimal-qemuarm.tar.bz2 +mkdir -p ./root +echo "name=\"test\" +memory=400 +vcpus=1 +kernel=\"/root/zImage\" +ramdisk=\"/root/initrd.cpio.gz\" +extra=\"console=hvc0 root=/dev/ram0 rdinit=/bin/sh\" +" > root/test.cfg +echo "#!/bin/bash + +xl list + +xl create -c /root/test.cfg + +" > ./root/xen.start +echo "bash /root/xen.start" >> ./etc/init.d/xen-watchdog + +curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz mkdir rootfs cd rootfs tar xvzf ../initrd.tar.gz +find . | cpio -H newc -o | gzip > ../root/initrd.cpio.gz +cd .. +rm -rf rootfs +rm initrd.tar.gz + +cp ../zImage ./root find . | cpio -H newc -o | gzip > ../initrd.gz cd .. @@ -20,22 +43,25 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ -machine dumpdtb=virt.dtb +# XXX disable pci to avoid Linux hang +fdtput virt.dtb -p -t s /pcie@10000000 status disabled + # ImageBuilder echo 'MEMORY_START="0x40000000" -MEMORY_END="0x80000000" +MEMORY_END="0xC0000000" DEVICE_TREE="virt.dtb" -XEN="xen" -DOM0_KERNEL="vmlinuz" +XEN="xen-qemuarm" +DOM0_KERNEL="zImage" DOM0_RAMDISK="initrd.gz" -DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/bin/sh" -XEN_CMD="console=dtuart dom0_mem=512M bootscrub=0" +DOM0_CMD="console=hvc0 earlyprintk clk_ignore_unused root=/dev/ram0 rdinit=/sbin/init" +XEN_CMD="console=dtuart dom0_mem=1024M bootscrub=0" NUM_DOMUS=0 @@ -51,12 +77,12 @@ bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config rm -f smoke.serial set +e echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ -timeout -k 1 240 \ +timeout -k 1 720 \ ./qemu-system-arm \ -machine virt \ -machine virtualization=true \ -smp 4 \ - -m 1024 \ + -m 2048 \ -serial stdio \ -monitor none \ -display none \ @@ -66,5 +92,5 @@ timeout -k 1 240 \ -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial set -e -(grep -q "^/ #" smoke.serial) || exit 1 +(grep -q "Domain-0" smoke.serial && grep -q "^/ #" smoke.serial) || exit 1 exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Feb 18 04:30:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 04:30:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497429.768391 (Exim 4.92) (envelope-from ) id 1pTErg-0005sL-DG; Sat, 18 Feb 2023 04:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497429.768391; Sat, 18 Feb 2023 04:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTErg-0005sE-9K; Sat, 18 Feb 2023 04:30:24 +0000 Received: by outflank-mailman (input) for mailman id 497429; Sat, 18 Feb 2023 04:30:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTErf-0005s2-Ir; Sat, 18 Feb 2023 04:30:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTErf-0000Xh-En; Sat, 18 Feb 2023 04:30:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTErf-0004EX-6I; Sat, 18 Feb 2023 04:30:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTErf-0006jE-5p; Sat, 18 Feb 2023 04:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KlGO96BAaW74aQVrhaLfwZ37fkXgAqDy2joUf7zy1mM=; b=N7NNkrpAydjkzVzcX7q2RFfIog 8h8A/VpsB7JVW72ahax+cyeYgvhq15RoYYRaL0DMMSXletuwjbdsHfWL1AMDZQamUxHut0gi9u6N5 WxLTSGCXYfvsVHjYBIGf1L87+H5zeX27rc1fDIH4RVvJLx4PtZ8TZTWUI8TlDekZwfK4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177638: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:debian-hvm-install/l1/l2:fail:heisenbug linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=ec35307e18ba8174e2a3f701956059f6a36f22fb X-Osstest-Versions-That: linux=3ac88fa4605ec98e545fb3ad0154f575fda2de5f From: osstest service owner Date: Sat, 18 Feb 2023 04:30:23 +0000 flight 177638 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail REGR. vs. 177531 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-nested-intel 20 debian-hvm-install/l1/l2 fail pass in 177574 Tests which did not succeed, but are not blocking: test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail in 177574 like 177531 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177531 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux ec35307e18ba8174e2a3f701956059f6a36f22fb baseline version: linux 3ac88fa4605ec98e545fb3ad0154f575fda2de5f Last test of basis 177531 2023-02-16 20:42:54 Z 1 days Testing same since 177574 2023-02-17 06:09:56 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Dave Airlie Dave Stevenson Dom Cobley Greg Kroah-Hartman Jack Xiao Jani Nikula Jim Cromie Jocelyn Falempe Leo Li Linus Torvalds Matt Roper Maxime Ripard Mikhail Gavrilov Miko Larsson Rodrigo Vivi Takashi Iwai Thomas Zimmermann Ville Syrjälä Zack Rusin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 398 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 18 08:46:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 08:46:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497461.768401 (Exim 4.92) (envelope-from ) id 1pTIqo-0005Np-HN; Sat, 18 Feb 2023 08:45:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497461.768401; Sat, 18 Feb 2023 08:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTIqo-0005Ni-Ei; Sat, 18 Feb 2023 08:45:46 +0000 Received: by outflank-mailman (input) for mailman id 497461; Sat, 18 Feb 2023 08:45:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTIqn-0005Nc-2g for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 08:45:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0eb3a76-af68-11ed-933d-83870f6b2ba8; Sat, 18 Feb 2023 09:45:43 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A00B421DCE; Sat, 18 Feb 2023 08:45:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71DCC134BA; Sat, 18 Feb 2023 08:45:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XyfHGTaQ8GOQeQAAMHmgww (envelope-from ); Sat, 18 Feb 2023 08:45:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0eb3a76-af68-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676709942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/AM7lDOg+R9kS69a7Vh5ZjVbAdMxKs6asZt00ye7K3Y=; b=eDF6Asy21+jDFD6GrlGr/LD7dgwZt4U4yKcaOKPmg8ede093+EiCLtEk8LJ5h6b97YIUTo havD96Pc3Vso0e9wHOFU7TNVTrWQWAptZ/9nS5RxTuaU8fBaNJ317LTZZpcfmmR9lCP35j 6tUZc0dOuRrqpdUkIvmbN00cgfIoDT8= Message-ID: Date: Sat, 18 Feb 2023 09:45:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen: sysfs: make kobj_type structure constant Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20230216-kobj_type-xen-v1-1-742423de7d71@weissschuh.net> From: Juergen Gross In-Reply-To: <20230216-kobj_type-xen-v1-1-742423de7d71@weissschuh.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MmQQrjQJT0gWYRfJIYOrtzJl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MmQQrjQJT0gWYRfJIYOrtzJl Content-Type: multipart/mixed; boundary="------------TBM4MKgme1ejF5raTXbMT4kX"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] xen: sysfs: make kobj_type structure constant References: <20230216-kobj_type-xen-v1-1-742423de7d71@weissschuh.net> In-Reply-To: <20230216-kobj_type-xen-v1-1-742423de7d71@weissschuh.net> --------------TBM4MKgme1ejF5raTXbMT4kX Content-Type: multipart/mixed; boundary="------------moL9X0pvK81uoCMSFz1yfGiw" --------------moL9X0pvK81uoCMSFz1yfGiw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTYuMDIuMjMgMDI6MTAsIFRob21hcyBXZWnDn3NjaHVoIHdyb3RlOg0KPiBTaW5jZSBj b21taXQgZWU2ZDNkZDRlZDQ4ICgiZHJpdmVyIGNvcmU6IG1ha2Uga29ial90eXBlIGNvbnN0 YW50LiIpDQo+IHRoZSBkcml2ZXIgY29yZSBhbGxvd3MgdGhlIHVzYWdlIG9mIGNvbnN0IHN0 cnVjdCBrb2JqX3R5cGUuDQo+IA0KPiBUYWtlIGFkdmFudGFnZSBvZiB0aGlzIHRvIGNvbnN0 aWZ5IHRoZSBzdHJ1Y3R1cmUgZGVmaW5pdGlvbiB0byBwcmV2ZW50DQo+IG1vZGlmaWNhdGlv biBhdCBydW50aW1lLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVGhvbWFzIFdlacOfc2NodWgg PGxpbnV4QHdlaXNzc2NodWgubmV0Pg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------moL9X0pvK81uoCMSFz1yfGiw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------moL9X0pvK81uoCMSFz1yfGiw-- --------------TBM4MKgme1ejF5raTXbMT4kX-- --------------MmQQrjQJT0gWYRfJIYOrtzJl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPwkDUFAwAAAAAACgkQsN6d1ii/Ey/y lQf/fyO7A0Z0KDCFSdV1ijk0nwr5JoV62G8k7lqQK+P1UrxcVCfbyaTHpvBfqusWxIAqVAai5vpW rodyoqa0Gf7UkvipLiDx+DNFOwxiQ8QBIGuvo4XoI+N2jo2s/Dua3Onoccao2+hntZZF1ncO3Pm/ ITXOrGyIbFm11pZSRGr2AhFnKDk6WK2e8D2jrAQwoTW90xYKWlJDEoUNBp5+hN95fbXkVPswTzxQ csnUHrKp5TDt/a5Y+bdzd2pnRQVSp7ECs27Zx1TiEIoY7EcXGQ0S6w2ng4leByJH6B9jidUdR0vU GuK0axjhfdHXOx2+dXALojk/GmcEgFwx5Y79d88J6w== =n0/L -----END PGP SIGNATURE----- --------------MmQQrjQJT0gWYRfJIYOrtzJl-- From xen-devel-bounces@lists.xenproject.org Sat Feb 18 10:32:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 10:32:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497479.768413 (Exim 4.92) (envelope-from ) id 1pTKVU-00033I-3r; Sat, 18 Feb 2023 10:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497479.768413; Sat, 18 Feb 2023 10:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTKVU-00033B-08; Sat, 18 Feb 2023 10:31:52 +0000 Received: by outflank-mailman (input) for mailman id 497479; Sat, 18 Feb 2023 10:31:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTKVS-000331-2L; Sat, 18 Feb 2023 10:31:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTKVS-0001vc-0A; Sat, 18 Feb 2023 10:31:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTKVR-0008AQ-Ls; Sat, 18 Feb 2023 10:31:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTKVR-0001cX-LP; Sat, 18 Feb 2023 10:31:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q+PW8pzKoZl4ngAS/WaNJ+1WwoYNuIXfsIUkemgN0oc=; b=rLkDc56lJYrQbYBdBO8VZWUriL 9ugY8o6Y6wccn4z0DRfwcUwcQhT2RIZVdLaosnH3zFaPiBtLaEDtqaQMwZ3uVuftS0hBADw6i69tU kIn47s2Ofc2UhpUgxLOtrpdtgKKO48GcBWJww7+prDBGen2J8ZcHf/z7vnuXBqN24VjY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177659: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd X-Osstest-Versions-That: xen=f5c1a6374aae8be471b895a43359dcff355577f5 From: osstest service owner Date: Sat, 18 Feb 2023 10:31:49 +0000 flight 177659 xen-unstable real [real] flight 177701 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177659/ http://logs.test-lab.xenproject.org/osstest/logs/177701/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 177701-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177591 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177591 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177591 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177591 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177591 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177591 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177591 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177591 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177591 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd baseline version: xen f5c1a6374aae8be471b895a43359dcff355577f5 Last test of basis 177591 2023-02-17 09:52:18 Z 1 days Testing same since 177659 2023-02-17 23:39:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f5c1a6374a..e2312e41f0 e2312e41f05c0f2e3b714710bd2551a3cd74cedd -> master From xen-devel-bounces@lists.xenproject.org Sat Feb 18 12:07:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 12:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497500.768432 (Exim 4.92) (envelope-from ) id 1pTLzN-0006ji-Cu; Sat, 18 Feb 2023 12:06:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497500.768432; Sat, 18 Feb 2023 12:06:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTLzN-0006jb-A0; Sat, 18 Feb 2023 12:06:49 +0000 Received: by outflank-mailman (input) for mailman id 497500; Sat, 18 Feb 2023 12:06:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTLzM-0006jR-85; Sat, 18 Feb 2023 12:06:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTLzM-000438-60; Sat, 18 Feb 2023 12:06:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTLzL-00026T-Sm; Sat, 18 Feb 2023 12:06:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTLzL-0008B5-SA; Sat, 18 Feb 2023 12:06:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oRdAhQoxCrlBDqsD1CtLJSXTGZx6D0cLXXE6idxnQ8g=; b=Zy/mUJLuoBUcsHGbwtBSlNsWnE kXYFFCJUPlkd+R2t26NFeI+ga1NQGn2FN76LjnqeV1io1D98DDGvwz45MCpl258hZafl0QzD4qgd4 vLp5CtK//bW4sMbLimNSI5EA6g65gfLkZVJs6YoVo04r1ZlYRoMHgQMVX6sXBouTFEQs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177679: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=15e5eb8a7684992d1a885038d28781462a727bf2 X-Osstest-Versions-That: libvirt=598a73335d70b4ef70b84f9730d708c116f88b15 From: osstest service owner Date: Sat, 18 Feb 2023 12:06:47 +0000 flight 177679 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/177679/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 15e5eb8a7684992d1a885038d28781462a727bf2 baseline version: libvirt 598a73335d70b4ef70b84f9730d708c116f88b15 Last test of basis 177457 2023-02-16 04:21:50 Z 2 days Testing same since 177565 2023-02-17 04:20:12 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 598a73335d..15e5eb8a76 15e5eb8a7684992d1a885038d28781462a727bf2 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Feb 18 14:10:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 14:10:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497510.768443 (Exim 4.92) (envelope-from ) id 1pTNv5-0006d9-0b; Sat, 18 Feb 2023 14:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497510.768443; Sat, 18 Feb 2023 14:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTNv4-0006d2-TU; Sat, 18 Feb 2023 14:10:30 +0000 Received: by outflank-mailman (input) for mailman id 497510; Sat, 18 Feb 2023 14:10:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTNv3-0006cw-At for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 14:10:29 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc2f12f8-af95-11ed-933d-83870f6b2ba8; Sat, 18 Feb 2023 15:10:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1E13E5C00EC; Sat, 18 Feb 2023 09:10:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 18 Feb 2023 09:10:23 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 09:10:20 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc2f12f8-af95-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676729423; x= 1676815823; bh=bYW63VThDJjBqSX/sZZ5Stao8GLxy1vBG3E4+EFwiCA=; b=k 6uglbGHr57kEUOi2JOi64M2FWa7twr0KzzPG9XojQmYBBMQCtmGS13CEvGqHApdA kpLixxh8NwX8BopwOgDQxJ9GCrw/QUX7QwDXxaDPzatVECQxzY9LZ0aXzK+zehp/ OS0OjhcQEp4mbJar2fN5q0v6Hzd4DAOGQBjdx7L8623DZvuHIIXUNzEomUFNWoKB kAbEnzCAdDSC4NUtqvSuosg4ewHWlA35eKkVjYU1lWCVhOsnTO+THV8Cy9kWiBqW swswMN/u06gH3qND8JMVFwMWfgUQQ4CaR8Af+DfxWV5bWYpHGewqu1/HmtFqO/tp m+faHU5nmZVw5rEqY0feg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676729423; x=1676815823; bh=bYW63VThDJjBqSX/sZZ5Stao8GLx y1vBG3E4+EFwiCA=; b=KCnNmZ5CQsoVd173iyQHkwBDDTY2wN6TeDGcdqzQ58u5 j9Ht95jk2ItlsgEeTVdUg+mUMUk3CtCfl1NHG3YUucR3AKzMuWWiKVEaIKwSEyT9 KLLXLiGWqUrwxwy6yjrgAYFcjjIqPfMiIiZmzNU3DbnHGF6wUSgL4BGcOyh6oWf6 MUUDDmKvfLspx8kmX4efi3UdLRI6gSHOn43/NWuLbmL7PcvhTkQXbWr/Sc+1FGdP 1XQrUD9yOXgc7UTpB0ewE69uFUw572V8sGrUCz4us4b1ShbyiBcwWW0hEzXWqEvd SPg7GYcQdMxlGgZHEqtXJQ0Ib/9y/LYqT8hdHTGVlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejuddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepveej gfetuefhhedvheejgedtteegveeujeefgfejheeitedvvdfhfffgtdelvefgnecuffhomh grihhnpehgihhtlhgrsgdrtghomhdpgigvnhdrohhrghdpiihlihgsrdhnvghtpdgsuhht thhhvghnihguohhnthhthhhinhhkthhhrghtshgtohhrrhgvtghtrghpphhrohgrtghhrd hithdpkhgvrhhnvghlrdhorhhgpdhrvgguhhgrthdrtghomhdpshhouhhrtggvfigrrhgv rdhorhhgpdhgnhhurdhorhhgpdhinhhrihgrrdhfrhdpghhmphhlihgsrdhorhhgpdhpoh hlrghrshhslhdrohhrghdpsggvrhhlihhoshdruggvpdhiphigvgdrohhrghdpghhithhh uhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sat, 18 Feb 2023 15:10:16 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// Message-ID: References: <0aaad173b15304e2ab00749b4e5ad79c6e111589.1676668923.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lSEMJVqM7h4dPmkm" Content-Disposition: inline In-Reply-To: <0aaad173b15304e2ab00749b4e5ad79c6e111589.1676668923.git.demi@invisiblethingslab.com> --lSEMJVqM7h4dPmkm Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 18 Feb 2023 15:10:16 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// On Fri, Feb 17, 2023 at 04:35:25PM -0500, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. >=20 > This patch enforces the use of secure transports in the build system. > Some URLs returned 301 or 302 redirects, so I replaced them with the > URLs that were redirected to.=20 https://gitlab.com/xen-project/patchew/xen/-/pipelines/781679811 I'm a bit confused about debian build errors: ERROR: The certificate of 'xenbits.xen.org' is not trusted. ERROR: The certificate of 'xenbits.xen.org' has expired. Is clock on gitlab runners (way) off? > I also found that the old zlib used in > the I/O emulator stubdomain can no longer be obtained from > https://www.zlib.net and that the TPM emulator and PolarSSL (used by the > vTPM and vTPM manager stubdomains) can no longer be obtained from their > respective original URLs. Therefore, configure will now error out > instead of trying to download them. First of all, such change definitely wants a separate patch, de-supporting some configurations do not belong to "Replace git:// and http:// with https://" patch. But then, I don't think that's correct approach. It is a bug to be fixes, instead of breaking it even more. configure script already supports Xen's mirror, and I think it's even enabled by default (see --enable-extfiles), and also supports providing alternative download location (via env variables). So it seems your change here in fact breaks something that was working before... > Signed-off-by: Demi Marie Obenour > --- > Config.mk | 2 +- > stubdom/configure | 24 +++++++++++++++--------- > stubdom/configure.ac | 24 +++++++++++++++--------- > tools/firmware/etherboot/Makefile | 6 +----- > 4 files changed, 32 insertions(+), 24 deletions(-) >=20 > diff --git a/Config.mk b/Config.mk > index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320eaba= da6073004eb22ee 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=3D $(foreach i, $(APPEND_INCLUDES), -= I$(i)) > EMBEDDED_EXTRA_CFLAGS :=3D -fno-pie -fno-stack-protector -fno-stack-prot= ector-all > EMBEDDED_EXTRA_CFLAGS +=3D -fno-exceptions -fno-asynchronous-unwind-tabl= es > =20 > -XEN_EXTFILES_URL ?=3D http://xenbits.xen.org/xen-extfiles > +XEN_EXTFILES_URL ?=3D https://xenbits.xen.org/xen-extfiles > # All the files at that location were downloaded from elsewhere on > # the internet. The original download URL is preserved as a comment > # near the place in the Xen Makefiles where the file is used. > diff --git a/stubdom/configure b/stubdom/configure > index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..e40aca9afd0de2c5074978d65= 4d4e78f4f63e3d2 100755 > --- a/stubdom/configure > +++ b/stubdom/configure > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > ZLIB_URL=3D\$\(XEN_EXTFILES_URL\) > else > - ZLIB_URL=3D"http://www.zlib.net" > + ZLIB_URL=3D"https://www.zlib.net" > fi > =20 > fi > @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > LIBPCI_URL=3D\$\(XEN_EXTFILES_URL\) > else > - LIBPCI_URL=3D"http://www.kernel.org/pub/software/utils/pciutils" > + LIBPCI_URL=3D"https://mirrors.edge.kernel.org/pub/software/utils/pciut= ils" > fi > =20 > fi > @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > NEWLIB_URL=3D\$\(XEN_EXTFILES_URL\) > else > - NEWLIB_URL=3D"ftp://sources.redhat.com/pub/newlib" > + NEWLIB_URL=3D"https://sourceware.org/ftp/newlib" > fi > =20 > fi > @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > LWIP_URL=3D\$\(XEN_EXTFILES_URL\) > else > - LWIP_URL=3D"http://download.savannah.gnu.org/releases/lwip" > + LWIP_URL=3D"https://download.savannah.gnu.org/releases/lwip" > fi > =20 > fi > @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > GRUB_URL=3D\$\(XEN_EXTFILES_URL\) > else > - GRUB_URL=3D"http://alpha.gnu.org/gnu/grub" > + GRUB_URL=3D"https://alpha.gnu.org/gnu/grub" > fi > =20 > fi > @@ -3607,7 +3607,7 @@ GRUB_VERSION=3D"0.97" > =20 > if test "x$OCAML_URL" =3D "x"; then : > =20 > - OCAML_URL=3D"http://caml.inria.fr/pub/distrib/ocaml-4.02" > + OCAML_URL=3D"https://caml.inria.fr/pub/distrib/ocaml-4.02" > =20 > fi > OCAML_VERSION=3D"4.02.0" > @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > GMP_URL=3D\$\(XEN_EXTFILES_URL\) > else > - GMP_URL=3D"ftp://ftp.gmplib.org/pub/gmp-4.3.2" > + GMP_URL=3D"https://gmplib.org/download/gmp/archive" > fi > =20 > fi > @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > POLARSSL_URL=3D\$\(XEN_EXTFILES_URL\) > else > - POLARSSL_URL=3D"http://polarssl.org/code/releases" > + POLARSSL_URL=3D"https://polarssl.org/code/releases" > fi > =20 > fi > @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" =3D "x"; then : > if test "x$extfiles" =3D "xy"; then : > TPMEMU_URL=3D\$\(XEN_EXTFILES_URL\) > else > - TPMEMU_URL=3D"http://download.berlios.de/tpm-emulator" > + TPMEMU_URL=3D"https://download.berlios.de/tpm-emulator" > fi > =20 > fi > @@ -3669,6 +3669,12 @@ vtpmmgr=3D"n" > fi > =20 > =20 > +if test "x$vtpm" !=3D xn || test "x$vtpmmgr" !=3D xn || test "x$ioemu" != =3D xn; then > + if test "x$extfiles" !=3D xy; then > + as_fn_error $? "Sources needed for the vTPM, vTPM manager, and I= O emulator stubdomains are no longer at their original URLs" "$LINENO" 5 > + fi > +fi > + > #Conditionally enable these stubdoms based on the presense of dependenci= es > =20 > if test "x$vtpm" =3D "xy" || test "x$vtpm" =3D "x"; then : > diff --git a/stubdom/configure.ac b/stubdom/configure.ac > index e20d99edac0da88098f4806333edde9f31dbc1a7..d27f2bc1f17140ab41a687e1e= 8faaa66e2b4483b 100644 > --- a/stubdom/configure.ac > +++ b/stubdom/configure.ac > @@ -55,19 +55,25 @@ AC_PROG_INSTALL > AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) > =20 > # Stubdom libraries version and url setup > -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) > -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/s= oftware/utils/pciutils]) > -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/p= ub/newlib]) > -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.or= g/releases/lwip]) > -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) > -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/p= ub/distrib/ocaml-4.02]) > -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4= =2E3.2]) > -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/cod= e/releases]) > -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://downlo= ad.berlios.de/tpm-emulator]) > +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) > +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://mirrors.edge.kernel= =2Eorg/pub/software/utils/pciutils]) > +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp= /newlib]) > +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.o= rg/releases/lwip]) > +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) > +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/= pub/distrib/ocaml-4.02]) > +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gm= p/archive]) > +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/co= de/releases]) > +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://downl= oad.berlios.de/tpm-emulator]) > =20 > #These stubdoms should be enabled if the dependent one is > AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) > =20 > +if test "x$vtpm" !=3D xn || test "x$vtpmmgr" !=3D xn || test "x$ioemu" != =3D xn; then > + if test "x$extfiles" !=3D xy; then > + AC_MSG_ERROR([Sources needed for the vTPM, vTPM manager, and IO = emulator stubdomains are no longer at their original URLs]) > + fi > +fi > + > #Conditionally enable these stubdoms based on the presense of dependenci= es > AX_STUBDOM_CONDITIONAL_FINISH([vtpm-stubdom], [vtpm]) > AX_STUBDOM_CONDITIONAL_FINISH([vtpmmgr-stubdom], [vtpmmgr]) > diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot= /Makefile > index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..6ab9e5bc6b4cc750f2e802128= fbc71e9150397b1 100644 > --- a/tools/firmware/etherboot/Makefile > +++ b/tools/firmware/etherboot/Makefile > @@ -4,11 +4,7 @@ XEN_ROOT =3D $(CURDIR)/../../.. > include $(XEN_ROOT)/tools/Rules.mk > include Config > =20 > -ifeq ($(GIT_HTTP),y) > -IPXE_GIT_URL ?=3D http://git.ipxe.org/ipxe.git > -else > -IPXE_GIT_URL ?=3D git://git.ipxe.org/ipxe.git > -endif > +IPXE_GIT_URL ?=3D https://github.com/ipxe/ipxe.git > =20 > # put an updated tar.gz on xenbits after changes to this variable > IPXE_GIT_TAG :=3D 3c040ad387099483102708bb1839110bc788cefb > --=20 > Sincerely, > Demi Marie Obenour (she/her/hers) > Invisible Things Lab >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --lSEMJVqM7h4dPmkm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPw3EkACgkQ24/THMrX 1ywmAQf/ZtCKCGEwcAMkGqDqjkRA9Nc3HXneMSN/uuJuSybqX7VNqTSIZvzmtS3z 5p4ItJJhRd0IuLjwFmmgs5Dxkpm7A20/07o+uwdN+F2RNBQbX4Q8zPiZlBzDNB/a grZqGzE++d5jYjtR1BAwxHlNw1Mq43h9OAlLMKluQ1nVlH2RwpPw/uhyltTsrhdZ OJZ42BkiAXaR6BxnOhawooHLICxK2BIQgr7jy7DUX/oX3pB92rBpb7JTNcQKRHQG m5W+E0VIfLvSgUwMfYcEbj4BLXLaiYzNFEHIFmy8tEINYn2L/iprvD619eF49W0f 8mkKWO6F1aWPNak33mNzAVmUNgJBXg== =12Qs -----END PGP SIGNATURE----- --lSEMJVqM7h4dPmkm-- From xen-devel-bounces@lists.xenproject.org Sat Feb 18 14:23:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 14:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497517.768454 (Exim 4.92) (envelope-from ) id 1pTO78-0008Ri-39; Sat, 18 Feb 2023 14:22:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497517.768454; Sat, 18 Feb 2023 14:22:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTO78-0008Rb-08; Sat, 18 Feb 2023 14:22:58 +0000 Received: by outflank-mailman (input) for mailman id 497517; Sat, 18 Feb 2023 14:22:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTO77-0008RT-7q for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 14:22:57 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc41816c-af97-11ed-933d-83870f6b2ba8; Sat, 18 Feb 2023 15:22:55 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DB9EA5C00A3; Sat, 18 Feb 2023 09:22:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 18 Feb 2023 09:22:54 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 09:22:52 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc41816c-af97-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676730174; x= 1676816574; bh=jIUrOpa3mTKTqLf+OHYv7VD89ekuX74rxxpc12Aeg+w=; b=K fPm1qDAWxcmInIXkmiGafYBmYtb1RwKRZyTG5npF9oGdGkKCJi6InWG/R5YwXE00 DLNjVholjDXYPfwISyBgnl6BuLp5CAlx+5LLnoWX4UYWB4cSKFWjbQqyJGk51402 Zx98OSIyugQ1gXbm9Jw04osgRoZ+/uNqJOK6zrL5gHVQIiIov+Vx4Ed7lb/wQEl7 /zl1VR58gk/9ihSCMHQ+PiwX//821q9E+Q3HYoD3Yb9u32dBrFHL2DV1QU6bPyC5 /Us2+a/ak+j8fDsPFlKl6oBHT9mgZxJtDkV66RS7FxJ/LmAlahciBaF/rHHhkRj5 LYNnK3PzEecY7t8Gmheyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676730174; x=1676816574; bh=jIUrOpa3mTKTqLf+OHYv7VD89eku X74rxxpc12Aeg+w=; b=TmFmZTI0K2hzvd78uJZp8diiZc6y8Dds0kWsM0TFL3BT 0Lb+hmFOFdsoOqsIziqfrRQzXgwKVBEm9mJqXVKwUCth5AXVVZR+oGAiIBNvD9y/ PzLOb0E1ddxLtqn1ehMihpTuwUEkA0USr4PZ0r+kfTDq+rwtx036N1l13cqAG8li 3Rf7vezDbU3QtaSW1fDb2zzC20/Y0DSqHdVcj7WF5PAntdLKKlXs8n0/u2jXEz6M 2EG/89kWLAIIO8XiZUtcs8ROjpS6uhhddgBi/2GOObRHztwYdAQ+ecDnYbQahHUQ A68ZIwqbZQ8DJsbU73S7EYhcJRyr9nimY/ATvUmXXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejuddgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepveej gfetuefhhedvheejgedtteegveeujeefgfejheeitedvvdfhfffgtdelvefgnecuffhomh grihhnpehgihhtlhgrsgdrtghomhdpgigvnhdrohhrghdpiihlihgsrdhnvghtpdgsuhht thhhvghnihguohhnthhthhhinhhkthhhrghtshgtohhrrhgvtghtrghpphhrohgrtghhrd hithdpkhgvrhhnvghlrdhorhhgpdhrvgguhhgrthdrtghomhdpshhouhhrtggvfigrrhgv rdhorhhgpdhgnhhurdhorhhgpdhinhhrihgrrdhfrhdpghhmphhlihgsrdhorhhgpdhpoh hlrghrshhslhdrohhrghdpsggvrhhlihhoshdruggvpdhiphigvgdrohhrghdpghhithhh uhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sat, 18 Feb 2023 15:22:49 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// Message-ID: References: <0aaad173b15304e2ab00749b4e5ad79c6e111589.1676668923.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TtN/mjQ/xqvD/yEL" Content-Disposition: inline In-Reply-To: --TtN/mjQ/xqvD/yEL Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 18 Feb 2023 15:22:49 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: Re: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// On Sat, Feb 18, 2023 at 03:10:16PM +0100, Marek Marczykowski-G=C3=B3recki w= rote: > On Fri, Feb 17, 2023 at 04:35:25PM -0500, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > >=20 > > This patch enforces the use of secure transports in the build system. > > Some URLs returned 301 or 302 redirects, so I replaced them with the > > URLs that were redirected to.=20 >=20 > https://gitlab.com/xen-project/patchew/xen/-/pipelines/781679811 >=20 > I'm a bit confused about debian build errors: >=20 > ERROR: The certificate of 'xenbits.xen.org' is not trusted. > ERROR: The certificate of 'xenbits.xen.org' has expired. >=20 > Is clock on gitlab runners (way) off? >=20 > > I also found that the old zlib used in > > the I/O emulator stubdomain can no longer be obtained from > > https://www.zlib.net and that the TPM emulator and PolarSSL (used by the > > vTPM and vTPM manager stubdomains) can no longer be obtained from their > > respective original URLs. Therefore, configure will now error out > > instead of trying to download them. >=20 > First of all, such change definitely wants a separate patch, > de-supporting some configurations do not belong to "Replace git:// and > http:// with https://" patch. But then, I don't think that's correct > approach. It is a bug to be fixes, instead of breaking it even more. > configure script already supports Xen's mirror, and I think it's even > enabled by default (see --enable-extfiles), and also supports providing > alternative download location (via env variables). So it seems your > change here in fact breaks something that was working before... Ah, you do take --enable-extfiles into account. But still alternative URL can be provided by env variable. > > Signed-off-by: Demi Marie Obenour > > --- > > Config.mk | 2 +- > > stubdom/configure | 24 +++++++++++++++--------- > > stubdom/configure.ac | 24 +++++++++++++++--------- > > tools/firmware/etherboot/Makefile | 6 +----- > > 4 files changed, 32 insertions(+), 24 deletions(-) > >=20 > > diff --git a/Config.mk b/Config.mk > > index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320ea= bada6073004eb22ee 100644 > > --- a/Config.mk > > +++ b/Config.mk > > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=3D $(foreach i, $(APPEND_INCLUDES),= -I$(i)) > > EMBEDDED_EXTRA_CFLAGS :=3D -fno-pie -fno-stack-protector -fno-stack-pr= otector-all > > EMBEDDED_EXTRA_CFLAGS +=3D -fno-exceptions -fno-asynchronous-unwind-ta= bles > > =20 > > -XEN_EXTFILES_URL ?=3D http://xenbits.xen.org/xen-extfiles > > +XEN_EXTFILES_URL ?=3D https://xenbits.xen.org/xen-extfiles > > # All the files at that location were downloaded from elsewhere on > > # the internet. The original download URL is preserved as a comment > > # near the place in the Xen Makefiles where the file is used. > > diff --git a/stubdom/configure b/stubdom/configure > > index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..e40aca9afd0de2c5074978d= 654d4e78f4f63e3d2 100755 > > --- a/stubdom/configure > > +++ b/stubdom/configure > > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > ZLIB_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - ZLIB_URL=3D"http://www.zlib.net" > > + ZLIB_URL=3D"https://www.zlib.net" > > fi > > =20 > > fi > > @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > LIBPCI_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - LIBPCI_URL=3D"http://www.kernel.org/pub/software/utils/pciutils" > > + LIBPCI_URL=3D"https://mirrors.edge.kernel.org/pub/software/utils/pci= utils" > > fi > > =20 > > fi > > @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > NEWLIB_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - NEWLIB_URL=3D"ftp://sources.redhat.com/pub/newlib" > > + NEWLIB_URL=3D"https://sourceware.org/ftp/newlib" > > fi > > =20 > > fi > > @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > LWIP_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - LWIP_URL=3D"http://download.savannah.gnu.org/releases/lwip" > > + LWIP_URL=3D"https://download.savannah.gnu.org/releases/lwip" > > fi > > =20 > > fi > > @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > GRUB_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - GRUB_URL=3D"http://alpha.gnu.org/gnu/grub" > > + GRUB_URL=3D"https://alpha.gnu.org/gnu/grub" > > fi > > =20 > > fi > > @@ -3607,7 +3607,7 @@ GRUB_VERSION=3D"0.97" > > =20 > > if test "x$OCAML_URL" =3D "x"; then : > > =20 > > - OCAML_URL=3D"http://caml.inria.fr/pub/distrib/ocaml-4.02" > > + OCAML_URL=3D"https://caml.inria.fr/pub/distrib/ocaml-4.02" > > =20 > > fi > > OCAML_VERSION=3D"4.02.0" > > @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > GMP_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - GMP_URL=3D"ftp://ftp.gmplib.org/pub/gmp-4.3.2" > > + GMP_URL=3D"https://gmplib.org/download/gmp/archive" > > fi > > =20 > > fi > > @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > POLARSSL_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - POLARSSL_URL=3D"http://polarssl.org/code/releases" > > + POLARSSL_URL=3D"https://polarssl.org/code/releases" > > fi > > =20 > > fi > > @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > TPMEMU_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - TPMEMU_URL=3D"http://download.berlios.de/tpm-emulator" > > + TPMEMU_URL=3D"https://download.berlios.de/tpm-emulator" > > fi > > =20 > > fi > > @@ -3669,6 +3669,12 @@ vtpmmgr=3D"n" > > fi > > =20 > > =20 > > +if test "x$vtpm" !=3D xn || test "x$vtpmmgr" !=3D xn || test "x$ioemu"= !=3D xn; then > > + if test "x$extfiles" !=3D xy; then > > + as_fn_error $? "Sources needed for the vTPM, vTPM manager, and= IO emulator stubdomains are no longer at their original URLs" "$LINENO" 5 > > + fi > > +fi > > + > > #Conditionally enable these stubdoms based on the presense of dependen= cies > > =20 > > if test "x$vtpm" =3D "xy" || test "x$vtpm" =3D "x"; then : > > diff --git a/stubdom/configure.ac b/stubdom/configure.ac > > index e20d99edac0da88098f4806333edde9f31dbc1a7..d27f2bc1f17140ab41a687e= 1e8faaa66e2b4483b 100644 > > --- a/stubdom/configure.ac > > +++ b/stubdom/configure.ac > > @@ -55,19 +55,25 @@ AC_PROG_INSTALL > > AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) > > =20 > > # Stubdom libraries version and url setup > > -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) > > -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub= /software/utils/pciutils]) > > -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com= /pub/newlib]) > > -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.= org/releases/lwip]) > > -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) > > -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr= /pub/distrib/ocaml-4.02]) > > -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp= -4.3.2]) > > -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/c= ode/releases]) > > -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://down= load.berlios.de/tpm-emulator]) > > +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) > > +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://mirrors.edge.kern= el.org/pub/software/utils/pciutils]) > > +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/f= tp/newlib]) > > +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu= =2Eorg/releases/lwip]) > > +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub= ]) > > +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.f= r/pub/distrib/ocaml-4.02]) > > +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/= gmp/archive]) > > +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/= code/releases]) > > +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://dow= nload.berlios.de/tpm-emulator]) > > =20 > > #These stubdoms should be enabled if the dependent one is > > AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) > > =20 > > +if test "x$vtpm" !=3D xn || test "x$vtpmmgr" !=3D xn || test "x$ioemu"= !=3D xn; then > > + if test "x$extfiles" !=3D xy; then > > + AC_MSG_ERROR([Sources needed for the vTPM, vTPM manager, and I= O emulator stubdomains are no longer at their original URLs]) > > + fi > > +fi > > + > > #Conditionally enable these stubdoms based on the presense of dependen= cies > > AX_STUBDOM_CONDITIONAL_FINISH([vtpm-stubdom], [vtpm]) > > AX_STUBDOM_CONDITIONAL_FINISH([vtpmmgr-stubdom], [vtpmmgr]) > > diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherbo= ot/Makefile > > index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..6ab9e5bc6b4cc750f2e8021= 28fbc71e9150397b1 100644 > > --- a/tools/firmware/etherboot/Makefile > > +++ b/tools/firmware/etherboot/Makefile > > @@ -4,11 +4,7 @@ XEN_ROOT =3D $(CURDIR)/../../.. > > include $(XEN_ROOT)/tools/Rules.mk > > include Config > > =20 > > -ifeq ($(GIT_HTTP),y) > > -IPXE_GIT_URL ?=3D http://git.ipxe.org/ipxe.git > > -else > > -IPXE_GIT_URL ?=3D git://git.ipxe.org/ipxe.git > > -endif > > +IPXE_GIT_URL ?=3D https://github.com/ipxe/ipxe.git > > =20 > > # put an updated tar.gz on xenbits after changes to this variable > > IPXE_GIT_TAG :=3D 3c040ad387099483102708bb1839110bc788cefb > > --=20 > > Sincerely, > > Demi Marie Obenour (she/her/hers) > > Invisible Things Lab > >=20 >=20 > --=20 > Best Regards, > Marek Marczykowski-G=C3=B3recki > Invisible Things Lab --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --TtN/mjQ/xqvD/yEL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmPw3zoACgkQ24/THMrX 1ywOrQf+KZW8q9kUmb+qn5adJtN4cJp4Y5hhbJEKypFxhRLSlidUJv6hcsJfweS1 cuBMxECXwc9KgGFkfogtBTkk116miQDIG/PfAArKqPsFSPuNm6txlbOJ0e24prhD InpAnHvGIHSrfZpMvhSzCHJUugtsOgcPIDYRxO1EAjkkjMxOfTJniYqPd59yl6kQ Fe/1Y5sYVzeB/vFtPExMQIZFqSYnOlXVebZqRKZkVMA+S/GdD5ZWoyrN26RAd2YM dG/QthFYNkgc2r3azit32OTiFMOY7IijbaTtEkLJYsvKEHbQd8gr+di3fCo1vVin uQC4GjJCqWMrW4Gt86+IRHG3jtRGrw== =dyzd -----END PGP SIGNATURE----- --TtN/mjQ/xqvD/yEL-- From xen-devel-bounces@lists.xenproject.org Sat Feb 18 15:57:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 15:57:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497537.768464 (Exim 4.92) (envelope-from ) id 1pTPaI-0003UB-3n; Sat, 18 Feb 2023 15:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497537.768464; Sat, 18 Feb 2023 15:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTPaI-0003U4-0x; Sat, 18 Feb 2023 15:57:10 +0000 Received: by outflank-mailman (input) for mailman id 497537; Sat, 18 Feb 2023 15:57:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTPaG-0003Tu-Gm; Sat, 18 Feb 2023 15:57:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTPaG-0000rW-EJ; Sat, 18 Feb 2023 15:57:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTPaG-0005Le-13; Sat, 18 Feb 2023 15:57:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTPaG-0005p2-0Y; Sat, 18 Feb 2023 15:57:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NrIgjE9bT95ifx4po+D3Sklh7zKTzC0FztgIzIPvgcI=; b=AzxfbLv4XRDR/ObTNJ5ereGiA4 MJqrgpobaGz8+WPixojCCxi7wH/x1nDZzjaD8sAFFrlqqYNGb4Dnt7MXaOyx3gh9grC1AxKE6URkg p/x78TjwpKaiiZuk/K6cRVugSLpbZYHh/iYzwW2nAGp1G3ghFWoYncKQow6rbPVWSPMA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177681: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=38f8ccde04a3fa317b51b05e63c3cb57e1641931 X-Osstest-Versions-That: linux=3ac88fa4605ec98e545fb3ad0154f575fda2de5f From: osstest service owner Date: Sat, 18 Feb 2023 15:57:08 +0000 flight 177681 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177681/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177531 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177531 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177531 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 38f8ccde04a3fa317b51b05e63c3cb57e1641931 baseline version: linux 3ac88fa4605ec98e545fb3ad0154f575fda2de5f Last test of basis 177531 2023-02-16 20:42:54 Z 1 days Failing since 177574 2023-02-17 06:09:56 Z 1 days 3 attempts Testing same since 177681 2023-02-18 04:33:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Andrew Morton Andy Chi Anna Schumaker Bartosz Golaszewski Benjamin Gray Bill Metzenthen Bo Liu Cezary Rojewski Damien Le Moal Dave Airlie Dave Stevenson David Hildenbrand Dom Cobley Geraldo Nascimento Greg Kroah-Hartman Heiner Kallweit Hugh Dickins Ingo Molnar Jack Xiao Jani Nikula Jim Cromie Jocelyn Falempe Kailang Yang Leo Li Linus Torvalds Linux Kernel Functional Testing Mark Brown Matt Roper Maxime Ripard Mengchi Cheng Michael Ellerman Mike Kravetz Mikhail Gavrilov Miko Larsson Muchun Song Munehisa Kamata Naresh Kamboju Nick Bowler Patrick McLean Paul Cercueil Peter Ujfalusi Peter Xu Peter Zijlstra (Intel) Peter Zijlstra Pierre-Louis Bossart Qian Yingjin Rander Wang Randy Dunlap Rodrigo Vivi Ryusuke Konishi Simon Gaiser Suren Baghdasaryan Takashi Iwai Thomas Zimmermann Trond Myklebust Ulf Hansson Ville Syrjälä Waiman Long Yang Yingliang Zach O'Keefe Zack Rusin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 3ac88fa4605e..38f8ccde04a3 38f8ccde04a3fa317b51b05e63c3cb57e1641931 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Feb 18 19:12:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 19:12:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497592.768475 (Exim 4.92) (envelope-from ) id 1pTScP-000412-NA; Sat, 18 Feb 2023 19:11:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497592.768475; Sat, 18 Feb 2023 19:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTScP-00040v-KT; Sat, 18 Feb 2023 19:11:33 +0000 Received: by outflank-mailman (input) for mailman id 497592; Sat, 18 Feb 2023 19:11:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTScO-00040p-D6 for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 19:11:32 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a30f619-afc0-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 20:11:28 +0100 (CET) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Feb 2023 14:11:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6003.namprd03.prod.outlook.com (2603:10b6:610:e2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Sat, 18 Feb 2023 19:11:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.018; Sat, 18 Feb 2023 19:11:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a30f619-afc0-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676747488; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=m09+sChu/taZUOwz2kPHBDHeILoObsTC4zhwBIs44tU=; b=L7GBKKb7u/InhaVIQdyg1EFbWVw+qFJYeqqBoX3mX+H/s1xTz+z68kzb cxB17mcAATnYaDSkQVfLB9euCHcLyxA8ye8FA7WrDIdQmDgTAOHltcRnR IdcUGNsTtul30nn3HqGOvr+UNfEi4BHbCtg5X6UGqTNzkHT5BCjpZk+Cm M=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 96987709 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2/VUEaylWn50udoS7Op6t+eZxyrEfRIJ4+MujC+fZmUNrF6WrkVSz zYXUGmBM6yKZWegf4pxPYXk8xkOvsLQmtI1TgY5+CAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkPKAT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXNFt sIICjURVRy4m+z156OCFbIxr+12eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMquFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqBtNCS+Lgp5aGhnWil05LBjpVS2CDoNaa20WBdtsAI H0Lr39GQa8asRbDosPGdxixunuNpBMfc9tWDewh6QuJx7bU4gCWHWwNRHhKb9lOnMM7QD0C1 1mXnsjoDzhirL2UT32G8r6e6zi1PEA9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q xiIpiUjg7QYjeYQyr62u1vAhlqEpIXNTwMzzhXaWCSi9AwRTJW+e4Wi5Fzf7PBBBIWUVF+Mu D4Dgcf2xP8KJYGAkmqKWuplNKqg4uuINHvAgV9lFoQl6xyg/WXmeZFX5nd5PkgBDyofUTrgY UuWtQYP4pZWZSGudfUuPNn3DNk2x6/9E9ijTurTctdFfpl2ckmA4T1qYkmTmWvqlSDAjJ0CB HtSSu70ZV5yNEit5GPeqzs1uVPz+h0D+A== IronPort-HdrOrdr: A9a23:Af1ocq1Fzne6/W7YRYmHzAqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td X-IronPort-AV: E=Sophos;i="5.97,309,1669093200"; d="scan'208";a="96987709" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CTXtSui4P4Jvi6nUQdK80DAWH1TSS6XbMkOgL2pHIY4P8fNQTQdOavZQQgzDO9sED2VCBCecrecibqNw1YtKYDri5uAhn4TyFuiTTkjT/hKQ35Th2VPXnxxKRBkoY6AYtWfDJcGeifoEtZs7qwA7+bFAGfPudTPjRInWaBOXB373l1zmVQ+N6xtRCy20sz3vBoq4fGybXE50ZiRO3hhwFzaM6GYov5doios1o2ql1/bXtnQjjlmYdS3gEEqkHP0B0nNeL7JRFWHJRbe0q2CM93TkMJ2yj8icLWqIkIutWwTTkIqRPSW5c3dpHSXHwqUVOa3uuJfr6TgMUDkxSrF5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ay9h2B4DVwja92DdxSojl+PwNUsZERM2YxWBKBJ4DAE=; b=S9Z5iyKaqaWxYh7XsC6ze/rhzkPVhmnMMx+5PNN60VcFfiUWJcQpCYJjMeHVj8bx/HWXG0Ac6qiS/N/ZEKDZaR21imTQKa6KUt68lncbCYx5rm4ZozdTIRUw1ykeiw7dQ8NXZxUG5/DCPyDE9nCNvj6/CA5VwfgceD2un3M3DcuUtgRSnYwqQRBaU83gr80yVArrOn854HTb8NkNhFDYYjqqFCN0Wt/K6AS2uXv4xKqTSlUspUkpuN3egnJ/jzUihU2/ypxWFNhMAZ4BBemt2rJYyWe4v9OoB75bINMq8lLDxIzMo2zVnRGs0N7u/rJTzAdUdN4fmfAMfsJtQ7FpTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ay9h2B4DVwja92DdxSojl+PwNUsZERM2YxWBKBJ4DAE=; b=iIDpfHAAebM3sAyDVQLULLpsnQtjv+Byx4W+XYol1Xdmq1Ld8/Ynea4HEXFR+3BKV9j5Y2NoML4m3/T3/fqP5ls3IPJGf4I6m5nCv4Uh3Hp1YwSm1bgfjw6naJu57GmNIBDGi7zeDxDuOEahrIlmDX1YYCbdZGPFjlLRKj3NwMo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <656b29ae-e64b-29b8-0a3f-f02c5432b87b@citrix.com> Date: Sat, 18 Feb 2023 19:11:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 2/4] Build system: Replace git:// and http:// with https:// Content-Language: en-GB To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Demi Marie Obenour Cc: xen-devel@lists.xenproject.org, George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD References: <0aaad173b15304e2ab00749b4e5ad79c6e111589.1676668923.git.demi@invisiblethingslab.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0444.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6003:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c16c9e7-6759-4e69-657b-08db11e3e90c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d8BsKfwPwo1GKSy78aiyH+/vLj9DoTABOgekDiqX6ooOT4zK1Jl+DoBIWnMtNInXEsgd5ACwFlAMqC2vQHj6J/ni7QXzw/4uKXGWv9Z1hg2h/A+OPKt3wyuuomswwV6kfs4G7cNglfDiEu3yKT8rg4otVm7r8D32FhFv8AgWcOZcjPzBb/zhxUldkJsKbHOp8LSC79cT06DhJkKhEhdJZTBdR/GZRLdm5gu5UDogFE4k4Fp1Su6Q3d4EshYn2YosicM8T/icoH+fyDI4jUohFQpi+lRgWAuNHN0xG0BMHgxmPvdOIgYFNzmtftU3dDeQwPo75lRXf6nFuZQ+5UjuXPGmuJDko9jbR3UfJsnu1Nu0quz2oOrPl2z5vL9RpHLyphChOh0FL8L5HiGjbnHsKdBonAePedGqIPvECpi7fYIYFnvc2FOsdRPBJUvWPeRUyoI9dq9VUp7h5qSvst+0hlHF9BAxTZP5u5QhouLnPHN9husUNph90RLkJgG/XX0N8kNm7d39AQLpNsktyowzkliRYwc0srQs0vSz8H3pvjPkSUaJUFqR93WWumewNCdBQsQfMHNLMTanPKfI3VQfWcj2pFTOFcaXaJ6Ct1el9QGEVHgo3W88mQXIUzwB2l1gnyCFGFygmKnFMoCdvEbBnJy7gptZTr5tWDbmwcnUVfL3owlaBhCAzSW9fiIjhEQXV4wBE4dPVJrMU9vU8mlDZ6SfL/mFpINVTwhC+vdj+5tR4kVsqJQJsr1DrmEkGfqdMjlzgZsLiOjFC95q/woKkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199018)(53546011)(6486002)(478600001)(26005)(6506007)(31686004)(186003)(6512007)(2906002)(2616005)(966005)(66574015)(6666004)(107886003)(83380400001)(110136005)(54906003)(82960400001)(316002)(66946007)(66476007)(38100700002)(36756003)(66556008)(4326008)(8936002)(31696002)(41300700001)(86362001)(8676002)(4744005)(7416002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmJucXMva0RUeVF3ME5GcXJidk5TWE5yOXFqTEtrL0JjYnk3NWZuUHlHVlBo?= =?utf-8?B?Nmk3MVBXRG5EY3VNbHpGbXdvdDR6ckxaOW1uY29zcjdjUlAva0lzMTIzbUZJ?= =?utf-8?B?allsd0l6K05wY3Z2UmJSc2wrd1BrMXFEZlFoTFZYSW1CRXNlbHRiazRBa2RR?= =?utf-8?B?RmcvK0E3N0tXU0ZLQ0IySU81Z0xyTEczQ1cyemk5UnF0Rzd1M1k5alVMbmtI?= =?utf-8?B?MGhMVU1FN0l5a2twZU4zbkFzcUovYTZYVVg3aVh0SldIQjU5dnBpZ096c2xo?= =?utf-8?B?QTg5dGdtWEhJYmNRckdpRmVRYU41cThGOGlOWEpKWmd6SHBaOWIrSFd4d01H?= =?utf-8?B?QzdraDREejV1b2lIUjBKZjArWDNuWXdaelZLZVVUY05PeHVmamM1WXJXMENz?= =?utf-8?B?cmZKT2RRQnV2aEpiQUVneUJrMmkyMUJUTTJnd2pFZDBBV01TSUZnNkd5ZFFp?= =?utf-8?B?VnRUNkt5WURRUkpoSEQvblplRGtIU2V3U0JvZjl1cm5HUzd4MmREamtuRDAz?= =?utf-8?B?b2RuL0crSE5mSDNNQWRMZ0lieUxwMjU0OUNIVVE4Wnk5bUFEVnBJY016dElU?= =?utf-8?B?WE45cGZQbVVxQTRBcUEwN1lETk92UEFJTUFITkZSQ245UEFLUk1JcVNQQVhy?= =?utf-8?B?SnR0Zjh3Sm9pbElXUnRPWU1XTFlKbFZ5SVQ3T3VzNDNoTUFqVTZFODFQNjRQ?= =?utf-8?B?eXJnY2VXclE0TU54ejVyc3Z6T0VXNTRrdFhTbURoMjJldE9pcldrWTBuTzJJ?= =?utf-8?B?Rml6c0JMbzVPYWtITGgyWndQaFo3NXlmRUpVL1lRaVhCSlBVQWtaUEdZUThU?= =?utf-8?B?NGU0TEFpUkZPM2tDWjh3aFgwNTR0S0d0UURmVnU3TlNwTmZ1cExIVXJ2Uk5O?= =?utf-8?B?TERJV2gvTUxESTl3VzN6QUxveHhiUTRWcUNwU1JoTGU3anRJZjhzQVlMbjVp?= =?utf-8?B?UWNvc3pnQTdXVTRTdlZqdXdrR2greVBoRzc3MzlkYldha05BcTdWd1hhb0RE?= =?utf-8?B?TE9KU3RnVkR6OXJmMlRDVGpNTjZkM0lOL1NTSldOMXpLb0VDQUM1aDJQNHhN?= =?utf-8?B?OVpzekFLcnlMYUtJQlFaRGk3YytpeGNuNmhyNU92Mm05ZmtYNGk5N3Z2WlBR?= =?utf-8?B?UEZnS01PT2FDa0h5aUZNUVo1UkhrVEw0L29sY2RZWFg2Q25IdkJXTUl5NHRa?= =?utf-8?B?UXFnV1lUZGhoZ1JGMlQyVmcwek5KTEhnRU1rTzhEbk94em82OVFIMG4zZThx?= =?utf-8?B?SWJ2SjlpcVhzdE1UWFdBUmk2cWUvMzNNSm51U3dsNFhRby8zd2NPSkNUNlVJ?= =?utf-8?B?NStSdERrUGRJWlk1WUYwNWttaFcyL2t2aitJOU5ZYWZxQ3g5cXptRlIvVkY0?= =?utf-8?B?SjhFbXNRMXc5WEN1ajhtaU1uem9adXhrRjNtL1dLRjhtWW85NjhvaUZiazNj?= =?utf-8?B?VCtYTVFyMWdnTWV2UWdPN1hqUXQ5SHJ5VVVMendsSlQ4dlVrY3BQOExzbGhK?= =?utf-8?B?ejFma0psRnVjOWFLQkNkS1g3RzdBV3ZNQVcvNWRrSDNRdzdHUzloNnFKWHJR?= =?utf-8?B?bmo2UmdmRlJsb2hYUDFpS3dNUFdNTmNFRlBlQzJ3OUNnTVh3dGR2VlNaWUFm?= =?utf-8?B?c2hleEZjWXl6NE0xRDhHWnFiSk9vTEZiVnhtYmVLa0dscHlPbnpRR1piWldv?= =?utf-8?B?a3RORDZjY2hQOGtUYUlhY0tvcnREWDVRT0gzdTlXanRITFIySldiUllvSEE2?= =?utf-8?B?ejVMcjU3WVg2NWxvV3VVTkFRdWpWYVB6dnhEM29FVWlSbk9hV25xeUJRWnUw?= =?utf-8?B?QjBwQk5WdmlQbTdnMHhkSGV5VDFJRXZnb1NDYndocVBvNzNNNjdXaFFNbE9Z?= =?utf-8?B?TGVZVytXditUWklyY1ZabmFpWUo0Y1U3SW0yL250T0ZHcGVpVENSNkZ2RkpY?= =?utf-8?B?S2s1TS8rSjZVTmg0dExGNm81d0hNTDlpYXhRbzJEY1lMWDR3Y0hXVnVUbGp4?= =?utf-8?B?ZHhISnphaHdDOTlOZlFUOW1vVnhMSnFZQmRsWDNMeDBTY0VoNHJNbk9PUnNE?= =?utf-8?B?SXV6RjlEckRFc0c5Zk4xUnpnTFdBSUdSRDFzeS9Cd1gzQk5HVngwUHdYa2du?= =?utf-8?B?RDZLK2t6b1dwUmdpQlA2M1FZcmNOWGNTcWg4TldwWDk0L1VORzJyVUNDWUh2?= =?utf-8?B?aHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ODhYUHcrdjJrbWg1WGxIVDlqak4vNkJKblJORjJHdkZFTlNiUkhCUnFJYWYr?= =?utf-8?B?bU5heVpQRVJtYnlqYjlwYWpjSUJpMThGNnNpSkkyckRDSW04d2cvQ3Z3Y2Np?= =?utf-8?B?ZGJieldKOWRVNlRoUERMRUlrbUQ3elpobTl1NXBEbVVaa0ZNTnFweUZkRU1B?= =?utf-8?B?RkZBUzNTeUtzMWs2VjlteENZUC9LbTBOMitma3BscVBTZ09BQnU2aXdFQi8x?= =?utf-8?B?ZGhCL2lwREVNajZEM2J1S0hrL3l2MVFmNFZ4K2d1OWtPQm1Ecm5XRWZUTnN5?= =?utf-8?B?dUZrT0VxYU5GeTNjNVJpakZLcUowcFFwK3lwSWdNME5zdVhMaUlybG9pZ0E3?= =?utf-8?B?U09waDdheE10a0xRSzZCQkJITTZ3aHFpNFBLMHJEU1c4TWtxK3J6YXVyV1Yv?= =?utf-8?B?bWUwMmpKUVdLK2lXMUtWOFN3bTAyMUtEcDJxeU8wZU9iSCtsRHF6VDU3WUxS?= =?utf-8?B?OFV6am5xVUpVeFI1NWhIZjZpeTZuYkc0VTRFcENwajhmL2pVT3QrcGVDazNE?= =?utf-8?B?dmF6cU5WREhZNlVSNVhXVUQ2V3NWZHErNjlUb0MwTXE3dHR0RHk4dEl5NGtS?= =?utf-8?B?dkozQ0NIOWtHVG9aSDdqbEFGZi9DK2gzbmJJQVlWU1hEQXF0NFcyQmw2Vnc4?= =?utf-8?B?aGdjNGQybVdhdEJvenNtcm92NER6Z3BCQk1zZUl4djdBV3h4RmdmMHVrR2Nk?= =?utf-8?B?S1VmRnZHUEIrQlZDcEtqc0VoSERRRHFET3AwRDljeGVDRTRTTENCVWpJVGRT?= =?utf-8?B?cXZhbUhVTUJraUFQQlR2SVI2TTNma1ZtVmJvUDQ4NUZtZ1c4cFhMYkI2dU94?= =?utf-8?B?eE15RkJvU1FEcFcvSmN2eG9jNktYbnJYNTJvV1JRYVBLci9RS1dvNGErRXo5?= =?utf-8?B?QVdqUmxCVjFyOXNWWU1NYXIveityTnBFNkNuQm5oakJ2THhJUmM0NWZaWUcy?= =?utf-8?B?N05SejNkSyt1V0lhRUFlNHRidVpDcWc4VXhJUXJFNVI3UkVKY3F6RStsdE9q?= =?utf-8?B?dmg0UHBoUzUvVVZCb0F5dEdRNm9IVTdVOHZaUXFkMmVkZUIxZE5aSU8xcndi?= =?utf-8?B?a0JSeHRQTmRBS3V4MkVWY211d0hTUXFPVG9Ed0ZRazk4dzBUdGUvbjRFSW9t?= =?utf-8?B?aEY3TitWTTNUblFnS3RPNHVJZUxTdS9mZ21qSVBUMWhpKzQvZ3Q3WjIxUUw0?= =?utf-8?B?MnVjam1yQXFxWmlrL2NvS1gvUnY2NmJRWmhxZDFaQ05zK2JFYTdlTy9rSzJJ?= =?utf-8?Q?q0mehrXE6qYa0qi?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c16c9e7-6759-4e69-657b-08db11e3e90c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2023 19:11:17.1802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: El76cS4Ny6+KqDBIA6LaLvVfVw++PvOhyh9e3X/W4VYzfRK3y7QVPMXv4fuUJdQCXT7AE8h0ITtlG2WQePXsoHIdpG6t6xdm40LDdxCSsvA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6003 On 18/02/2023 2:10 pm, Marek Marczykowski-Górecki wrote: > On Fri, Feb 17, 2023 at 04:35:25PM -0500, Demi Marie Obenour wrote: >> Obtaining code over an insecure transport is a terrible idea for >> blatently obvious reasons. Even for non-executable data, insecure >> transports are considered deprecated. >> >> This patch enforces the use of secure transports in the build system. >> Some URLs returned 301 or 302 redirects, so I replaced them with the >> URLs that were redirected to. > https://gitlab.com/xen-project/patchew/xen/-/pipelines/781679811 > > I'm a bit confused about debian build errors: > > ERROR: The certificate of 'xenbits.xen.org' is not trusted. > ERROR: The certificate of 'xenbits.xen.org' has expired. > > Is clock on gitlab runners (way) off? https://lore.kernel.org/xen-devel/20230215120208.35807-1-anthony.perard@citrix.com/T/#u ~Andrew From xen-devel-bounces@lists.xenproject.org Sat Feb 18 21:16:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 21:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497603.768498 (Exim 4.92) (envelope-from ) id 1pTUZA-0002ue-VM; Sat, 18 Feb 2023 21:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497603.768498; Sat, 18 Feb 2023 21:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUZA-0002uX-SZ; Sat, 18 Feb 2023 21:16:20 +0000 Received: by outflank-mailman (input) for mailman id 497603; Sat, 18 Feb 2023 21:16:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUZ9-0002f0-52 for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 21:16:19 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a4bf1c5-afd1-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 22:16:15 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2023 13:16:07 -0800 Received: from adityava-mobl1.amr.corp.intel.com (HELO rpedgeco-desk.amr.corp.intel.com) ([10.209.80.223]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2023 13:16:06 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a4bf1c5-afd1-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676754975; x=1708290975; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rxj9czymX7gUlnvqos5jD1E4th0P80n6KyIsd1wZY38=; b=hlgtzTai6nIj4QoJjUaYeTjJp5vGil6tK0Jk31MVVmtCQGoMsCvVrsij GmammUIFWeTgb5StkualkrNiaC7juN9kX1xFhB/Rvi/IN+d9vcZSerroW TWWI9MXhX/NYa9LvaXexGRHLgMpzDBeH88ZAM+XHi4n8gywWpfFLVGggW cEU+fjOv43W6rEquCiBLKI0gfNVn6a0jDwgLUWDj03qwQKbpIf83KP/Z3 bgKpEUsVEaor8JhqmHzjozmJvQNpuTBac6MKR7Nxw6mJcN1YX9XYJlBHy 0UJ/W3BF/WR1zna0iVTzW7Wj0dfOxF64xntiphTlDEmgJvFtc0zv2TMsM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="418427359" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="418427359" X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="664241634" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="664241634" From: Rick Edgecombe To: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Date: Sat, 18 Feb 2023 13:14:05 -0800 Message-Id: <20230218211433.26859-14-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230218211433.26859-1-rick.p.edgecombe@intel.com> References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The x86 Control-flow Enforcement Technology (CET) feature includes a new type of memory called shadow stack. This shadow stack memory has some unusual properties, which requires some core mm changes to function properly. One of these unusual properties is that shadow stack memory is writable, but only in limited ways. These limits are applied via a specific PTE bit combination. Nevertheless, the memory is writable, and core mm code will need to apply the writable permissions in the typical paths that call pte_mkwrite(). In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting that they are special shadow stack flavor of writable memory. So make pte_mkwrite() take a VMA, so that the x86 implementation of it can know to create regular writable memory or shadow stack memory. Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). No functional change. Cc: linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-alpha@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-csky@vger.kernel.org Cc: linux-hexagon@vger.kernel.org Cc: linux-ia64@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-m68k@lists.linux-m68k.org Cc: Michal Simek Cc: Dinh Nguyen Cc: linux-mips@vger.kernel.org Cc: openrisc@lists.librecores.org Cc: linux-parisc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: sparclinux@vger.kernel.org Cc: linux-um@lists.infradead.org Cc: xen-devel@lists.xenproject.org Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Tested-by: Pengfei Xu Suggested-by: David Hildenbrand Signed-off-by: Rick Edgecombe --- Hi Non-x86 Arch’s, x86 has a feature that allows for the creation of a special type of writable memory (shadow stack) that is only writable in limited specific ways. Previously, changes were proposed to core MM code to teach it to decide when to create normally writable memory or the special shadow stack writable memory, but David Hildenbrand suggested[0] to change pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be moved into x86 code. Since pXX_mkwrite() is defined in every arch, it requires some tree-wide changes. So that is why you are seeing some patches out of a big x86 series pop up in your arch mailing list. There is no functional change. After this refactor, the shadow stack series goes on to use the arch helpers to push shadow stack memory details inside arch/x86. Testing was just 0-day build testing. Hopefully that is enough context. Thanks! [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com/#t v6: - New patch --- Documentation/mm/arch_pgtable_helpers.rst | 9 ++++++--- arch/alpha/include/asm/pgtable.h | 6 +++++- arch/arc/include/asm/hugepage.h | 2 +- arch/arc/include/asm/pgtable-bits-arcv2.h | 7 ++++++- arch/arm/include/asm/pgtable-3level.h | 7 ++++++- arch/arm/include/asm/pgtable.h | 2 +- arch/arm64/include/asm/pgtable.h | 4 ++-- arch/csky/include/asm/pgtable.h | 2 +- arch/hexagon/include/asm/pgtable.h | 2 +- arch/ia64/include/asm/pgtable.h | 2 +- arch/loongarch/include/asm/pgtable.h | 4 ++-- arch/m68k/include/asm/mcf_pgtable.h | 2 +- arch/m68k/include/asm/motorola_pgtable.h | 6 +++++- arch/m68k/include/asm/sun3_pgtable.h | 6 +++++- arch/microblaze/include/asm/pgtable.h | 2 +- arch/mips/include/asm/pgtable.h | 6 +++--- arch/nios2/include/asm/pgtable.h | 2 +- arch/openrisc/include/asm/pgtable.h | 2 +- arch/parisc/include/asm/pgtable.h | 6 +++++- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/book3s/64/pgtable.h | 4 ++-- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pte-8xx.h | 2 +- arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 6 +++--- arch/s390/include/asm/hugetlb.h | 4 ++-- arch/s390/include/asm/pgtable.h | 4 ++-- arch/sh/include/asm/pgtable_32.h | 10 ++++++++-- arch/sparc/include/asm/pgtable_32.h | 2 +- arch/sparc/include/asm/pgtable_64.h | 6 +++--- arch/um/include/asm/pgtable.h | 2 +- arch/x86/include/asm/pgtable.h | 6 ++++-- arch/xtensa/include/asm/pgtable.h | 2 +- include/asm-generic/hugetlb.h | 4 ++-- include/linux/mm.h | 2 +- mm/debug_vm_pgtable.c | 16 ++++++++-------- mm/huge_memory.c | 6 +++--- mm/hugetlb.c | 4 ++-- mm/memory.c | 4 ++-- mm/migrate_device.c | 2 +- mm/mprotect.c | 2 +- mm/userfaultfd.c | 2 +- 42 files changed, 106 insertions(+), 69 deletions(-) diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst index fd2a19df884e..f119d16915d4 100644 --- a/Documentation/mm/arch_pgtable_helpers.rst +++ b/Documentation/mm/arch_pgtable_helpers.rst @@ -48,7 +48,8 @@ PTE Page Table Helpers +---------------------------+--------------------------------------------------+ | pte_mkclean | Creates a clean PTE | +---------------------------+--------------------------------------------------+ -| pte_mkwrite | Creates a writable PTE | +| pte_mkwrite | Creates a writable PTE of the type specified by | +| | the VMA. | +---------------------------+--------------------------------------------------+ | pte_wrprotect | Creates a write protected PTE | +---------------------------+--------------------------------------------------+ @@ -120,7 +121,8 @@ PMD Page Table Helpers +---------------------------+--------------------------------------------------+ | pmd_mkclean | Creates a clean PMD | +---------------------------+--------------------------------------------------+ -| pmd_mkwrite | Creates a writable PMD | +| pmd_mkwrite | Creates a writable PMD of the type specified by | +| | the VMA. | +---------------------------+--------------------------------------------------+ | pmd_wrprotect | Creates a write protected PMD | +---------------------------+--------------------------------------------------+ @@ -224,7 +226,8 @@ HugeTLB Page Table Helpers +---------------------------+--------------------------------------------------+ | huge_pte_mkdirty | Creates a dirty HugeTLB | +---------------------------+--------------------------------------------------+ -| huge_pte_mkwrite | Creates a writable HugeTLB | +| huge_pte_mkwrite | Creates a writable HugeTLB of the type specified | +| | by the VMA. | +---------------------------+--------------------------------------------------+ | huge_pte_wrprotect | Creates a write protected HugeTLB | +---------------------------+--------------------------------------------------+ diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h index 9e45f6735d5d..39da4baa4f2d 100644 --- a/arch/alpha/include/asm/pgtable.h +++ b/arch/alpha/include/asm/pgtable.h @@ -253,9 +253,13 @@ extern inline int pte_young(pte_t pte) { return pte_val(pte) & _PAGE_ACCESSED; extern inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) |= _PAGE_FOW; return pte; } extern inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~(__DIRTY_BITS); return pte; } extern inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~(__ACCESS_BITS); return pte; } -extern inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) &= ~_PAGE_FOW; return pte; } extern inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= __DIRTY_BITS; return pte; } extern inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= __ACCESS_BITS; return pte; } +extern inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) &= ~_PAGE_FOW; + return pte; +} /* * The smp_rmb() in the following functions are required to order the load of diff --git a/arch/arc/include/asm/hugepage.h b/arch/arc/include/asm/hugepage.h index 5001b796fb8d..223a96967188 100644 --- a/arch/arc/include/asm/hugepage.h +++ b/arch/arc/include/asm/hugepage.h @@ -21,7 +21,7 @@ static inline pmd_t pte_pmd(pte_t pte) } #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) diff --git a/arch/arc/include/asm/pgtable-bits-arcv2.h b/arch/arc/include/asm/pgtable-bits-arcv2.h index 515e82db519f..cbbbcbd0a780 100644 --- a/arch/arc/include/asm/pgtable-bits-arcv2.h +++ b/arch/arc/include/asm/pgtable-bits-arcv2.h @@ -84,7 +84,6 @@ PTE_BIT_FUNC(mknotpresent, &= ~(_PAGE_PRESENT)); PTE_BIT_FUNC(wrprotect, &= ~(_PAGE_WRITE)); -PTE_BIT_FUNC(mkwrite, |= (_PAGE_WRITE)); PTE_BIT_FUNC(mkclean, &= ~(_PAGE_DIRTY)); PTE_BIT_FUNC(mkdirty, |= (_PAGE_DIRTY)); PTE_BIT_FUNC(mkold, &= ~(_PAGE_ACCESSED)); @@ -92,6 +91,12 @@ PTE_BIT_FUNC(mkyoung, |= (_PAGE_ACCESSED)); PTE_BIT_FUNC(mkspecial, |= (_PAGE_SPECIAL)); PTE_BIT_FUNC(mkhuge, |= (_PAGE_HW_SZ)); +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= (_PAGE_WRITE); + return pte; +} + static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) { return __pte((pte_val(pte) & _PAGE_CHG_MASK) | pgprot_val(newprot)); diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h index eabe72ff7381..c25024455445 100644 --- a/arch/arm/include/asm/pgtable-3level.h +++ b/arch/arm/include/asm/pgtable-3level.h @@ -199,11 +199,16 @@ static inline pmd_t pmd_##fn(pmd_t pmd) { pmd_val(pmd) op; return pmd; } PMD_BIT_FUNC(wrprotect, |= L_PMD_SECT_RDONLY); PMD_BIT_FUNC(mkold, &= ~PMD_SECT_AF); -PMD_BIT_FUNC(mkwrite, &= ~L_PMD_SECT_RDONLY); PMD_BIT_FUNC(mkdirty, |= L_PMD_SECT_DIRTY); PMD_BIT_FUNC(mkclean, &= ~L_PMD_SECT_DIRTY); PMD_BIT_FUNC(mkyoung, |= PMD_SECT_AF); +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) +{ + pmd_val(pmd) |= L_PMD_SECT_RDONLY; + return pmd; +} + #define pmd_mkhuge(pmd) (__pmd(pmd_val(pmd) & ~PMD_TABLE_BIT)) #define pmd_pfn(pmd) (((pmd_val(pmd) & PMD_MASK) & PHYS_MASK) >> PAGE_SHIFT) diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h index f049072b2e85..dcefac6b1edc 100644 --- a/arch/arm/include/asm/pgtable.h +++ b/arch/arm/include/asm/pgtable.h @@ -227,7 +227,7 @@ static inline pte_t pte_wrprotect(pte_t pte) return set_pte_bit(pte, __pgprot(L_PTE_RDONLY)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return clear_pte_bit(pte, __pgprot(L_PTE_RDONLY)); } diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index ed555f947697..67748142eb8c 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -187,7 +187,7 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -489,7 +489,7 @@ static inline int pmd_trans_huge(pmd_t pmd) #define pmd_cont(pmd) pte_cont(pmd_pte(pmd)) #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) diff --git a/arch/csky/include/asm/pgtable.h b/arch/csky/include/asm/pgtable.h index 77bc6caff2d2..559bed7c9cd0 100644 --- a/arch/csky/include/asm/pgtable.h +++ b/arch/csky/include/asm/pgtable.h @@ -176,7 +176,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h index f7048c18b6f9..8a317f41e04f 100644 --- a/arch/hexagon/include/asm/pgtable.h +++ b/arch/hexagon/include/asm/pgtable.h @@ -297,7 +297,7 @@ static inline pte_t pte_wrprotect(pte_t pte) } /* pte_mkwrite - mark page as writable */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/ia64/include/asm/pgtable.h b/arch/ia64/include/asm/pgtable.h index 01517a5e6778..70724658ddee 100644 --- a/arch/ia64/include/asm/pgtable.h +++ b/arch/ia64/include/asm/pgtable.h @@ -265,7 +265,7 @@ ia64_phys_addr_valid (unsigned long addr) * access rights: */ #define pte_wrprotect(pte) (__pte(pte_val(pte) & ~_PAGE_AR_RW)) -#define pte_mkwrite(pte) (__pte(pte_val(pte) | _PAGE_AR_RW)) +#define pte_mkwrite(pte, vma) (__pte(pte_val(pte) | _PAGE_AR_RW)) #define pte_mkold(pte) (__pte(pte_val(pte) & ~_PAGE_A)) #define pte_mkyoung(pte) (__pte(pte_val(pte) | _PAGE_A)) #define pte_mkclean(pte) (__pte(pte_val(pte) & ~_PAGE_D)) diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h index 7a34e900d8c1..8cc4292357aa 100644 --- a/arch/loongarch/include/asm/pgtable.h +++ b/arch/loongarch/include/asm/pgtable.h @@ -360,7 +360,7 @@ static inline pte_t pte_mkdirty(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) @@ -460,7 +460,7 @@ static inline int pmd_write(pmd_t pmd) return !!(pmd_val(pmd) & _PAGE_WRITE); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pmd_val(pmd) |= _PAGE_WRITE; if (pmd_val(pmd) & _PAGE_MODIFIED) diff --git a/arch/m68k/include/asm/mcf_pgtable.h b/arch/m68k/include/asm/mcf_pgtable.h index b619b22823f8..ea1531b60645 100644 --- a/arch/m68k/include/asm/mcf_pgtable.h +++ b/arch/m68k/include/asm/mcf_pgtable.h @@ -208,7 +208,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= CF_PAGE_WRITABLE; return pte; diff --git a/arch/m68k/include/asm/motorola_pgtable.h b/arch/m68k/include/asm/motorola_pgtable.h index 7ac3d64c6b33..58daa34902a0 100644 --- a/arch/m68k/include/asm/motorola_pgtable.h +++ b/arch/m68k/include/asm/motorola_pgtable.h @@ -152,7 +152,6 @@ static inline int pte_young(pte_t pte) { return pte_val(pte) & _PAGE_ACCESSED; static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) |= _PAGE_RONLY; return pte; } static inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~_PAGE_DIRTY; return pte; } static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~_PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) &= ~_PAGE_RONLY; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } static inline pte_t pte_mknocache(pte_t pte) @@ -165,6 +164,11 @@ static inline pte_t pte_mkcache(pte_t pte) pte_val(pte) = (pte_val(pte) & _CACHEMASK040) | m68k_supervisor_cachemode; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) &= ~_PAGE_RONLY; + return pte; +} #define swapper_pg_dir kernel_pg_dir extern pgd_t kernel_pg_dir[128]; diff --git a/arch/m68k/include/asm/sun3_pgtable.h b/arch/m68k/include/asm/sun3_pgtable.h index 90d57e537eb1..89ce30bff5a1 100644 --- a/arch/m68k/include/asm/sun3_pgtable.h +++ b/arch/m68k/include/asm/sun3_pgtable.h @@ -140,10 +140,14 @@ static inline int pte_young(pte_t pte) { return pte_val(pte) & SUN3_PAGE_ACCESS static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_WRITEABLE; return pte; } static inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_MODIFIED; return pte; } static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) |= SUN3_PAGE_WRITEABLE; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= SUN3_PAGE_MODIFIED; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= SUN3_PAGE_ACCESSED; return pte; } static inline pte_t pte_mknocache(pte_t pte) { pte_val(pte) |= SUN3_PAGE_NOCACHE; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= SUN3_PAGE_WRITEABLE; + return pte; +} // use this version when caches work... //static inline pte_t pte_mkcache(pte_t pte) { pte_val(pte) &= SUN3_PAGE_NOCACHE; return pte; } // until then, use: diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h index 42f5988e998b..7a696c2e326c 100644 --- a/arch/microblaze/include/asm/pgtable.h +++ b/arch/microblaze/include/asm/pgtable.h @@ -263,7 +263,7 @@ static inline pte_t pte_mkread(pte_t pte) \ { pte_val(pte) |= _PAGE_USER; return pte; } static inline pte_t pte_mkexec(pte_t pte) \ { pte_val(pte) |= _PAGE_USER | _PAGE_EXEC; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) \ +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) \ { pte_val(pte) |= _PAGE_RW; return pte; } static inline pte_t pte_mkdirty(pte_t pte) \ { pte_val(pte) |= _PAGE_DIRTY; return pte; } diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h index a68c0b01d8cd..e92232739bb8 100644 --- a/arch/mips/include/asm/pgtable.h +++ b/arch/mips/include/asm/pgtable.h @@ -309,7 +309,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte.pte_low |= _PAGE_WRITE; if (pte.pte_low & _PAGE_MODIFIED) { @@ -364,7 +364,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) @@ -591,7 +591,7 @@ static inline pmd_t pmd_wrprotect(pmd_t pmd) return pmd; } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pmd_val(pmd) |= _PAGE_WRITE; if (pmd_val(pmd) & _PAGE_MODIFIED) diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h index ab793bc517f5..20cbf857099a 100644 --- a/arch/nios2/include/asm/pgtable.h +++ b/arch/nios2/include/asm/pgtable.h @@ -129,7 +129,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/openrisc/include/asm/pgtable.h b/arch/openrisc/include/asm/pgtable.h index 6477c17b3062..7d1d0a3936eb 100644 --- a/arch/openrisc/include/asm/pgtable.h +++ b/arch/openrisc/include/asm/pgtable.h @@ -247,7 +247,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/parisc/include/asm/pgtable.h b/arch/parisc/include/asm/pgtable.h index ea357430aafe..9e4344a976a7 100644 --- a/arch/parisc/include/asm/pgtable.h +++ b/arch/parisc/include/asm/pgtable.h @@ -328,8 +328,12 @@ static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~_PAGE_ACCESSED; retu static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) &= ~_PAGE_WRITE; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) |= _PAGE_WRITE; return pte; } static inline pte_t pte_mkspecial(pte_t pte) { pte_val(pte) |= _PAGE_SPECIAL; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= _PAGE_WRITE; + return pte; +} /* * Huge pte definitions. diff --git a/arch/powerpc/include/asm/book3s/32/pgtable.h b/arch/powerpc/include/asm/book3s/32/pgtable.h index 75823f39e042..fc4b3a55482b 100644 --- a/arch/powerpc/include/asm/book3s/32/pgtable.h +++ b/arch/powerpc/include/asm/book3s/32/pgtable.h @@ -471,7 +471,7 @@ static inline pte_t pte_mkpte(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index cb4c67bf45d7..4bfa37cbf5d0 100644 --- a/arch/powerpc/include/asm/book3s/64/pgtable.h +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h @@ -600,7 +600,7 @@ static inline pte_t pte_mkexec(pte_t pte) return __pte_raw(pte_raw(pte) | cpu_to_be64(_PAGE_EXEC)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { /* * write implies read, hence set both @@ -1072,7 +1072,7 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #ifdef CONFIG_HAVE_ARCH_SOFT_DIRTY #define pmd_soft_dirty(pmd) pte_soft_dirty(pmd_pte(pmd)) diff --git a/arch/powerpc/include/asm/nohash/32/pgtable.h b/arch/powerpc/include/asm/nohash/32/pgtable.h index 70edad44dff6..20ce92108f6c 100644 --- a/arch/powerpc/include/asm/nohash/32/pgtable.h +++ b/arch/powerpc/include/asm/nohash/32/pgtable.h @@ -171,7 +171,7 @@ void unmap_kernel_page(unsigned long va); do { pte_update(mm, addr, ptep, ~0, 0, 0); } while (0) #ifndef pte_mkwrite -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/powerpc/include/asm/nohash/32/pte-8xx.h b/arch/powerpc/include/asm/nohash/32/pte-8xx.h index 1a89ebdc3acc..f32450eb270a 100644 --- a/arch/powerpc/include/asm/nohash/32/pte-8xx.h +++ b/arch/powerpc/include/asm/nohash/32/pte-8xx.h @@ -101,7 +101,7 @@ static inline int pte_write(pte_t pte) #define pte_write pte_write -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) & ~_PAGE_RO); } diff --git a/arch/powerpc/include/asm/nohash/64/pgtable.h b/arch/powerpc/include/asm/nohash/64/pgtable.h index 879e9a6e5a87..526868817df0 100644 --- a/arch/powerpc/include/asm/nohash/64/pgtable.h +++ b/arch/powerpc/include/asm/nohash/64/pgtable.h @@ -85,7 +85,7 @@ #ifndef __ASSEMBLY__ /* pte_clear moved to later in this file */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index 3e01f4f3ab08..7eb7dd558319 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -338,7 +338,7 @@ static inline pte_t pte_wrprotect(pte_t pte) /* static inline pte_t pte_mkread(pte_t pte) */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_WRITE); } @@ -624,9 +624,9 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return pte_pmd(pte_mkyoung(pmd_pte(pmd))); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { - return pte_pmd(pte_mkwrite(pmd_pte(pmd))); + return pte_pmd(pte_mkwrite(pmd_pte(pmd), vma)); } static inline pmd_t pmd_wrprotect(pmd_t pmd) diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h index ccdbccfde148..558f7eef9c4d 100644 --- a/arch/s390/include/asm/hugetlb.h +++ b/arch/s390/include/asm/hugetlb.h @@ -102,9 +102,9 @@ static inline int huge_pte_dirty(pte_t pte) return pte_dirty(pte); } -static inline pte_t huge_pte_mkwrite(pte_t pte) +static inline pte_t huge_pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { - return pte_mkwrite(pte); + return pte_mkwrite(pte, vma); } static inline pte_t huge_pte_mkdirty(pte_t pte) diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index c48a447d1432..edf290429050 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -999,7 +999,7 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -1433,7 +1433,7 @@ static inline pmd_t pmd_mkwrite_kernel(pmd_t pmd) return pmd; } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { return pmd_mkwrite_kernel(pmd); } diff --git a/arch/sh/include/asm/pgtable_32.h b/arch/sh/include/asm/pgtable_32.h index d0240decacca..3ddf7e13c6aa 100644 --- a/arch/sh/include/asm/pgtable_32.h +++ b/arch/sh/include/asm/pgtable_32.h @@ -351,6 +351,12 @@ static inline void set_pte(pte_t *ptep, pte_t pte) #define PTE_BIT_FUNC(h,fn,op) \ static inline pte_t pte_##fn(pte_t pte) { pte.pte_##h op; return pte; } +#define PTE_BIT_FUNC_VMA(h,fn,op) \ +static inline pte_t pte_##fn(pte_t pte, struct vm_area_struct *vma) \ +{ \ + pte.pte_##h op; \ + return pte; \ +} #ifdef CONFIG_X2TLB /* @@ -359,11 +365,11 @@ static inline pte_t pte_##fn(pte_t pte) { pte.pte_##h op; return pte; } * kernel permissions), we attempt to couple them a bit more sanely here. */ PTE_BIT_FUNC(high, wrprotect, &= ~(_PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE)); -PTE_BIT_FUNC(high, mkwrite, |= _PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE); +PTE_BIT_FUNC_VMA(high, mkwrite, |= _PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE); PTE_BIT_FUNC(high, mkhuge, |= _PAGE_SZHUGE); #else PTE_BIT_FUNC(low, wrprotect, &= ~_PAGE_RW); -PTE_BIT_FUNC(low, mkwrite, |= _PAGE_RW); +PTE_BIT_FUNC_VMA(low, mkwrite, |= _PAGE_RW); PTE_BIT_FUNC(low, mkhuge, |= _PAGE_SZHUGE); #endif diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h index 5acc05b572e6..ba829881c904 100644 --- a/arch/sparc/include/asm/pgtable_32.h +++ b/arch/sparc/include/asm/pgtable_32.h @@ -241,7 +241,7 @@ static inline pte_t pte_mkold(pte_t pte) return __pte(pte_val(pte) & ~SRMMU_REF); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | SRMMU_WRITE); } diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 3bc9736bddb1..71df58562138 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -463,7 +463,7 @@ static inline pte_t pte_mkclean(pte_t pte) return __pte(val); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { unsigned long val = pte_val(pte), mask; @@ -753,11 +753,11 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return __pmd(pte_val(pte)); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pte_t pte = __pte(pmd_val(pmd)); - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); return __pmd(pte_val(pte)); } diff --git a/arch/um/include/asm/pgtable.h b/arch/um/include/asm/pgtable.h index 4e3052f2671a..0f9554ab6b6f 100644 --- a/arch/um/include/asm/pgtable.h +++ b/arch/um/include/asm/pgtable.h @@ -204,7 +204,7 @@ static inline pte_t pte_mkyoung(pte_t pte) return(pte); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { if (unlikely(pte_get_bits(pte, _PAGE_RW))) return pte; diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 4f9fddcff2b9..2b423d697490 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -369,7 +369,9 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte_set_flags(pte, _PAGE_RW); } -static inline pte_t pte_mkwrite(pte_t pte) +struct vm_area_struct; + +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -470,7 +472,7 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return pmd_set_flags(pmd, _PAGE_ACCESSED); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { return pmd_set_flags(pmd, _PAGE_RW); } diff --git a/arch/xtensa/include/asm/pgtable.h b/arch/xtensa/include/asm/pgtable.h index 5b5484d707b2..13f05b0d38a3 100644 --- a/arch/xtensa/include/asm/pgtable.h +++ b/arch/xtensa/include/asm/pgtable.h @@ -258,7 +258,7 @@ static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITABLE; return pte; } #define pgprot_noncached(prot) \ diff --git a/include/asm-generic/hugetlb.h b/include/asm-generic/hugetlb.h index a57d667addd2..45e8c4a98cf4 100644 --- a/include/asm-generic/hugetlb.h +++ b/include/asm-generic/hugetlb.h @@ -20,9 +20,9 @@ static inline unsigned long huge_pte_dirty(pte_t pte) return pte_dirty(pte); } -static inline pte_t huge_pte_mkwrite(pte_t pte) +static inline pte_t huge_pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { - return pte_mkwrite(pte); + return pte_mkwrite(pte, vma); } static inline pte_t huge_pte_mkdirty(pte_t pte) diff --git a/include/linux/mm.h b/include/linux/mm.h index 7afc86d50442..4650e2580d60 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1102,7 +1102,7 @@ void free_compound_page(struct page *page); static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) { if (likely(vma->vm_flags & VM_WRITE)) - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); return pte; } diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index c631ade3f1d2..ee7d6fc36128 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -107,10 +107,10 @@ static void __init pte_basic_tests(struct pgtable_debug_args *args, int idx) WARN_ON(!pte_same(pte, pte)); WARN_ON(!pte_young(pte_mkyoung(pte_mkold(pte)))); WARN_ON(!pte_dirty(pte_mkdirty(pte_mkclean(pte)))); - WARN_ON(!pte_write(pte_mkwrite(pte_wrprotect(pte)))); + WARN_ON(!pte_write(pte_mkwrite(pte_wrprotect(pte), args->vma))); WARN_ON(pte_young(pte_mkold(pte_mkyoung(pte)))); WARN_ON(pte_dirty(pte_mkclean(pte_mkdirty(pte)))); - WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte)))); + WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte, args->vma)))); WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte)))); WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte)))); } @@ -151,7 +151,7 @@ static void __init pte_advanced_tests(struct pgtable_debug_args *args) pte = pte_mkclean(pte); set_pte_at(args->mm, args->vaddr, args->ptep, pte); flush_dcache_page(page); - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, args->vma); pte = pte_mkdirty(pte); ptep_set_access_flags(args->vma, args->vaddr, args->ptep, pte, 1); pte = ptep_get(args->ptep); @@ -197,10 +197,10 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx) WARN_ON(!pmd_same(pmd, pmd)); WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd)))); WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd)))); - WARN_ON(!pmd_write(pmd_mkwrite(pmd_wrprotect(pmd)))); + WARN_ON(!pmd_write(pmd_mkwrite(pmd_wrprotect(pmd), args->vma))); WARN_ON(pmd_young(pmd_mkold(pmd_mkyoung(pmd)))); WARN_ON(pmd_dirty(pmd_mkclean(pmd_mkdirty(pmd)))); - WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd)))); + WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd, args->vma)))); WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd)))); WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd)))); /* @@ -251,7 +251,7 @@ static void __init pmd_advanced_tests(struct pgtable_debug_args *args) pmd = pmd_mkclean(pmd); set_pmd_at(args->mm, vaddr, args->pmdp, pmd); flush_dcache_page(page); - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, args->vma); pmd = pmd_mkdirty(pmd); pmdp_set_access_flags(args->vma, vaddr, args->pmdp, pmd, 1); pmd = READ_ONCE(*args->pmdp); @@ -903,8 +903,8 @@ static void __init hugetlb_basic_tests(struct pgtable_debug_args *args) pte = mk_huge_pte(page, args->page_prot); WARN_ON(!huge_pte_dirty(huge_pte_mkdirty(pte))); - WARN_ON(!huge_pte_write(huge_pte_mkwrite(huge_pte_wrprotect(pte)))); - WARN_ON(huge_pte_write(huge_pte_wrprotect(huge_pte_mkwrite(pte)))); + WARN_ON(!huge_pte_write(huge_pte_mkwrite(huge_pte_wrprotect(pte), args->vma))); + WARN_ON(huge_pte_write(huge_pte_wrprotect(huge_pte_mkwrite(pte, args->vma)))); #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB pte = pfn_pte(args->fixed_pmd_pfn, args->page_prot); diff --git a/mm/huge_memory.c b/mm/huge_memory.c index abe6cfd92ffa..a216129e6a7c 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -554,7 +554,7 @@ __setup("transparent_hugepage=", setup_transparent_hugepage); pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { if (likely(vma->vm_flags & VM_WRITE)) - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, vma); return pmd; } @@ -1587,7 +1587,7 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) pmd = pmd_modify(oldpmd, vma->vm_page_prot); pmd = pmd_mkyoung(pmd); if (writable) - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, vma); set_pmd_at(vma->vm_mm, haddr, vmf->pmd, pmd); update_mmu_cache_pmd(vma, vmf->address, vmf->pmd); spin_unlock(vmf->ptl); @@ -1935,7 +1935,7 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, /* See change_pte_range(). */ if ((cp_flags & MM_CP_TRY_CHANGE_WRITABLE) && !pmd_write(entry) && can_change_pmd_writable(vma, addr, entry)) - entry = pmd_mkwrite(entry); + entry = pmd_mkwrite(entry, vma); ret = HPAGE_PMD_NR; set_pmd_at(mm, addr, pmd, entry); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bdbfeb6fb393..0f5cf9a3cdb7 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4898,7 +4898,7 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page, if (writable) { entry = huge_pte_mkwrite(huge_pte_mkdirty(mk_huge_pte(page, - vma->vm_page_prot))); + vma->vm_page_prot)), vma); } else { entry = huge_pte_wrprotect(mk_huge_pte(page, vma->vm_page_prot)); @@ -4914,7 +4914,7 @@ static void set_huge_ptep_writable(struct vm_area_struct *vma, { pte_t entry; - entry = huge_pte_mkwrite(huge_pte_mkdirty(huge_ptep_get(ptep))); + entry = huge_pte_mkwrite(huge_pte_mkdirty(huge_ptep_get(ptep)), vma); if (huge_ptep_set_access_flags(vma, address, ptep, entry, 1)) update_mmu_cache(vma, address, ptep); } diff --git a/mm/memory.c b/mm/memory.c index 3e836fecd035..6ad031d5cfb0 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4089,7 +4089,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) entry = mk_pte(page, vma->vm_page_prot); entry = pte_sw_mkyoung(entry); if (vma->vm_flags & VM_WRITE) - entry = pte_mkwrite(pte_mkdirty(entry)); + entry = pte_mkwrite(pte_mkdirty(entry), vma); vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, &vmf->ptl); @@ -4777,7 +4777,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) pte = pte_modify(old_pte, vma->vm_page_prot); pte = pte_mkyoung(pte); if (writable) - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); ptep_modify_prot_commit(vma, vmf->address, vmf->pte, old_pte, pte); update_mmu_cache(vma, vmf->address, vmf->pte); pte_unmap_unlock(vmf->pte, vmf->ptl); diff --git a/mm/migrate_device.c b/mm/migrate_device.c index 721b2365dbca..0d2c97f6d561 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -646,7 +646,7 @@ static void migrate_vma_insert_page(struct migrate_vma *migrate, } entry = mk_pte(page, vma->vm_page_prot); if (vma->vm_flags & VM_WRITE) - entry = pte_mkwrite(pte_mkdirty(entry)); + entry = pte_mkwrite(pte_mkdirty(entry), vma); } ptep = pte_offset_map_lock(mm, pmdp, addr, &ptl); diff --git a/mm/mprotect.c b/mm/mprotect.c index 61cf60015a8b..2a70d16ec556 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -200,7 +200,7 @@ static unsigned long change_pte_range(struct mmu_gather *tlb, if ((cp_flags & MM_CP_TRY_CHANGE_WRITABLE) && !pte_write(ptent) && can_change_pte_writable(vma, addr, ptent)) - ptent = pte_mkwrite(ptent); + ptent = pte_mkwrite(ptent, vma); ptep_modify_prot_commit(vma, addr, pte, oldpte, ptent); if (pte_needs_flush(oldpte, ptent)) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 0499907b6f1a..c3bcc6fcf27b 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -85,7 +85,7 @@ int mfill_atomic_install_pte(struct mm_struct *dst_mm, pmd_t *dst_pmd, } if (writable) - _dst_pte = pte_mkwrite(_dst_pte); + _dst_pte = pte_mkwrite(_dst_pte, dst_vma); else /* * We need this to make sure write bit removed; as mk_pte() -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Feb 18 21:16:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 21:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497602.768487 (Exim 4.92) (envelope-from ) id 1pTUZ7-0002fX-Mr; Sat, 18 Feb 2023 21:16:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497602.768487; Sat, 18 Feb 2023 21:16:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUZ7-0002fQ-K1; Sat, 18 Feb 2023 21:16:17 +0000 Received: by outflank-mailman (input) for mailman id 497602; Sat, 18 Feb 2023 21:16:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUZ5-0002f0-SU for xen-devel@lists.xenproject.org; Sat, 18 Feb 2023 21:16:16 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75961e30-afd1-11ed-93b5-47a8fe42b414; Sat, 18 Feb 2023 22:16:10 +0100 (CET) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2023 13:16:06 -0800 Received: from adityava-mobl1.amr.corp.intel.com (HELO rpedgeco-desk.amr.corp.intel.com) ([10.209.80.223]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2023 13:16:04 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75961e30-afd1-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676754970; x=1708290970; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YUfVMdqaIDo5eYQ52v6BzSjW4FAE7LTxtjQ5YsNs8EI=; b=EQDrcmvYNFv5ua8tFyNx8N0HCu9at5b8484ixSyXKMbe3b2b86hDQ0WQ 7d32u6LSabnUaZNXu+YOJMPbes6BZTWIfC+lSifg+HNhNRaqrgNI1tYm9 dcj4Q+8qJrkLNCEhDtBa/PTqfXe6zCOiUaRgSVL3OjSYT+jVFqBdC19KA FjndBsUlKAmt5tx2olEgmLx/CQnOOlDTptcwuvacpELqJajURcMLTHE42 kpZmjJ3JCV1/3k7dKTl9Ea6mByuc/1tSrEWerWPQ80sGdE43TFfc24ygi SCM1g2V/kRulWkKYLiJ59m6BOD0v0CVFPHcyjYk001krRc89NHrwB46Ui Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="418427328" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="418427328" X-IronPort-AV: E=McAfee;i="6500,9779,10625"; a="664241624" X-IronPort-AV: E=Sophos;i="5.97,309,1669104000"; d="scan'208";a="664241624" From: Rick Edgecombe To: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v6 11/41] mm: Introduce pte_mkwrite_kernel() Date: Sat, 18 Feb 2023 13:14:03 -0800 Message-Id: <20230218211433.26859-12-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230218211433.26859-1-rick.p.edgecombe@intel.com> References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The x86 Control-flow Enforcement Technology (CET) feature includes a new type of memory called shadow stack. This shadow stack memory has some unusual properties, which requires some core mm changes to function properly. One of these changes is to allow for pte_mkwrite() to create different types of writable memory (the existing conventionally writable type and also the new shadow stack type). Future patches will convert pte_mkwrite() to take a VMA in order to facilitate this, however there are places in the kernel where pte_mkwrite() is called outside of the context of a VMA. These are for kernel memory. So create a new variant called pte_mkwrite_kernel() and switch the kernel users over to it. Have pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches will introduce changes to make pte_mkwrite() take a VMA. Only do this for architectures that need it because they call pte_mkwrite() in arch code without an associated VMA. Since it will only currently be used in arch code, so do not include it in arch_pgtable_helpers.rst. Cc: linux-doc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: xen-devel@lists.xenproject.org Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Tested-by: Pengfei Xu Suggested-by: David Hildenbrand Signed-off-by: Rick Edgecombe --- Hi Non-x86 Arch’s, x86 has a feature that allows for the creation of a special type of writable memory (shadow stack) that is only writable in limited specific ways. Previously, changes were proposed to core MM code to teach it to decide when to create normally writable memory or the special shadow stack writable memory, but David Hildenbrand suggested[0] to change pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be moved into x86 code. Since pXX_mkwrite() is defined in every arch, it requires some tree-wide changes. So that is why you are seeing some patches out of a big x86 series pop up in your arch mailing list. There is no functional change. After this refactor, the shadow stack series goes on to use the arch helpers to push shadow stack memory details inside arch/x86. Testing was just 0-day build testing. Hopefully that is enough context. Thanks! [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com/#t v6: - New patch --- arch/arm64/include/asm/pgtable.h | 7 ++++++- arch/arm64/mm/trans_pgd.c | 4 ++-- arch/s390/include/asm/pgtable.h | 7 ++++++- arch/s390/mm/pageattr.c | 2 +- arch/x86/include/asm/pgtable.h | 7 ++++++- arch/x86/xen/mmu_pv.c | 2 +- 6 files changed, 22 insertions(+), 7 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 65e78999c75d..ed555f947697 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -180,13 +180,18 @@ static inline pmd_t set_pmd_bit(pmd_t pmd, pgprot_t prot) return pmd; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { pte = set_pte_bit(pte, __pgprot(PTE_WRITE)); pte = clear_pte_bit(pte, __pgprot(PTE_RDONLY)); return pte; } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkclean(pte_t pte) { pte = clear_pte_bit(pte, __pgprot(PTE_DIRTY)); diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c index 4ea2eefbc053..5c07e68d80ea 100644 --- a/arch/arm64/mm/trans_pgd.c +++ b/arch/arm64/mm/trans_pgd.c @@ -40,7 +40,7 @@ static void _copy_pte(pte_t *dst_ptep, pte_t *src_ptep, unsigned long addr) * read only (code, rodata). Clear the RDONLY bit from * the temporary mappings we use during restore. */ - set_pte(dst_ptep, pte_mkwrite(pte)); + set_pte(dst_ptep, pte_mkwrite_kernel(pte)); } else if (debug_pagealloc_enabled() && !pte_none(pte)) { /* * debug_pagealloc will removed the PTE_VALID bit if @@ -53,7 +53,7 @@ static void _copy_pte(pte_t *dst_ptep, pte_t *src_ptep, unsigned long addr) */ BUG_ON(!pfn_valid(pte_pfn(pte))); - set_pte(dst_ptep, pte_mkpresent(pte_mkwrite(pte))); + set_pte(dst_ptep, pte_mkpresent(pte_mkwrite_kernel(pte))); } } diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index b26cbf1c533c..29522418b5f4 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -991,7 +991,7 @@ static inline pte_t pte_wrprotect(pte_t pte) return set_pte_bit(pte, __pgprot(_PAGE_PROTECT)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { pte = set_pte_bit(pte, __pgprot(_PAGE_WRITE)); if (pte_val(pte) & _PAGE_DIRTY) @@ -999,6 +999,11 @@ static inline pte_t pte_mkwrite(pte_t pte) return pte; } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkclean(pte_t pte) { pte = clear_pte_bit(pte, __pgprot(_PAGE_DIRTY)); diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c index 85195c18b2e8..4ee5fe5caa23 100644 --- a/arch/s390/mm/pageattr.c +++ b/arch/s390/mm/pageattr.c @@ -96,7 +96,7 @@ static int walk_pte_level(pmd_t *pmdp, unsigned long addr, unsigned long end, if (flags & SET_MEMORY_RO) new = pte_wrprotect(new); else if (flags & SET_MEMORY_RW) - new = pte_mkwrite(pte_mkdirty(new)); + new = pte_mkwrite_kernel(pte_mkdirty(new)); if (flags & SET_MEMORY_NX) new = set_pte_bit(new, __pgprot(_PAGE_NOEXEC)); else if (flags & SET_MEMORY_X) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index b39f16c0d507..4f9fddcff2b9 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -364,11 +364,16 @@ static inline pte_t pte_mkyoung(pte_t pte) return pte_set_flags(pte, _PAGE_ACCESSED); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { return pte_set_flags(pte, _PAGE_RW); } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkhuge(pte_t pte) { return pte_set_flags(pte, _PAGE_PSE); diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index ee29fb558f2e..a23f04243c19 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -150,7 +150,7 @@ void make_lowmem_page_readwrite(void *vaddr) if (pte == NULL) return; /* vaddr missing */ - ptev = pte_mkwrite(*pte); + ptev = pte_mkwrite_kernel(*pte); if (HYPERVISOR_update_va_mapping(address, ptev, 0)) BUG(); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Sat Feb 18 21:20:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 18 Feb 2023 21:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497616.768509 (Exim 4.92) (envelope-from ) id 1pTUd8-0004xS-PF; Sat, 18 Feb 2023 21:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497616.768509; Sat, 18 Feb 2023 21:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUd8-0004xL-KR; Sat, 18 Feb 2023 21:20:26 +0000 Received: by outflank-mailman (input) for mailman id 497616; Sat, 18 Feb 2023 21:20:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUd7-0004x8-Oj; Sat, 18 Feb 2023 21:20:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUd7-0000TH-My; Sat, 18 Feb 2023 21:20:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTUd7-0006fF-Ex; Sat, 18 Feb 2023 21:20:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTUd7-0001QV-ES; Sat, 18 Feb 2023 21:20:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+z52KWFVhoa5dtegC6Hb2sd6hYe9u7Nzn3SNkgNMMcI=; b=6EGM/G6GzNuijvJUL1zJaiYHPY EdOslfCQZGL92I81Zz0RUkoQvudNEBDn23jPugCeI0mE0ZB2BLXpwvr8rahPA1NhgJX/LvtbmkoZ8 hOXd5sS+lbvEjyGW1oESZeNMkrw83QiRZNgG4Wvz5lRNK4IX9mPJI4JlqIbFhW8Ta3tw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177707: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd X-Osstest-Versions-That: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd From: osstest service owner Date: Sat, 18 Feb 2023 21:20:25 +0000 flight 177707 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177707/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 177659 pass in 177707 test-arm64-arm64-libvirt-xsm 8 xen-boot fail pass in 177659 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 177659 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 177659 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177659 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177659 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177659 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177659 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177659 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177659 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177659 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177659 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177659 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd baseline version: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd Last test of basis 177707 2023-02-18 10:34:06 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Feb 19 02:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 02:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497654.768541 (Exim 4.92) (envelope-from ) id 1pTZmU-00031p-Na; Sun, 19 Feb 2023 02:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497654.768541; Sun, 19 Feb 2023 02:50:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmU-00031g-K9; Sun, 19 Feb 2023 02:50:26 +0000 Received: by outflank-mailman (input) for mailman id 497654; Sun, 19 Feb 2023 02:50:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmT-0002li-LU for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 02:50:25 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 252d0f3c-b000-11ed-93b5-47a8fe42b414; Sun, 19 Feb 2023 03:50:22 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id A53FB3200583; Sat, 18 Feb 2023 21:50:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 18 Feb 2023 21:50:18 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 21:50:15 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 252d0f3c-b000-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676775017; x=1676861417; bh=+fUifg3+9Sx5Ngno/T4jBLJLFOiv4d2p9UY Hj/k/F/0=; b=TfR/aOp2aVlCdkZUazTk0r14QyQkxybV9277sXvzmNGUSFOUsxR 6XI938akoGyBXIRDBZB6YCs4Xl+d3wPq6GOzV6LD6jVvdIBv5fq23qZzIdf689hv ZxDl59Dvsof5VyZbBFJhJUSVdKNVjNNb5bXyqMIMPdj66i+T5rdUhZ9D+ROie+Wm Nc7VtSrzVQT9WQ1c4u9wKbukvbs/HeAWfnuxfAxRu4aiDrU1SI8/y2RsHA8yT0my 5wrQ4svb/1Xnu5PDvFH0CmZJY2ptWiZI+rT43TLAYFNxhz4E9yd7ZWHNdlCLsVk0 yvUdSa8EB9Vnrrx5cATVhNMpspSSN9bpZaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676775017; x=1676861417; bh=+fUifg3+9Sx5N gno/T4jBLJLFOiv4d2p9UYHj/k/F/0=; b=QTAAJMt9lbOncEBb8aHoSh4T+ZiMZ qpRzkOX7piAX0G2MX94k78Jky9lv1KErqjXgCWknn4zzjQDaQrUGBDfoDhiS96Qt fbs1BZs7gxT1cHrvEJH2KuzqKVhJa3jefRssB7OoL5+9zIuMNql9F/i5jPYQg2Tc YGPX4z19ajqjiCBpHY0SItBu6dptj4LEYVNX4HBgyxnCdNLnNP7Aq5BdgfdUQwQD o8PFZ+fGXLamp8bFS1j/h+7fwGOThPnjUYqnvlfRQlQ2yZaOk0njkGpiE4Wqxv2i vBGJjHdSQwYpfVnurwQRveb+T6YqW1wmL//Q7EAvTmBTndrHDOZYG43EQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejvddggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuefgffeihefhffelkeehffeljeeu teeihfeiudejgeeufffhheeugfekhfeiffeinecuffhomhgrihhnpeigvghnrdhorhhgpd igvghnphhrohhjvggtthdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH v4 1/3] Use HTTPS for all xenbits.xen.org Git repos Date: Sat, 18 Feb 2023 21:46:13 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports for all xenbits.xen.org Git repositories. It was generated with the following shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk | 18 +++++------------- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- scripts/get_maintainer.pl | 2 +- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..75f1975e5e78af44d36c2372cba6e89b425267a5 100644 --- a/Config.mk +++ b/Config.mk @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/git-http/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc index d38e4ce074b399946aecdaedb4cb6fe5b8043b66..a94fb57eb568e85a25c93bf6a988f123d4e48443 100644 --- a/docs/misc/livepatch.pandoc +++ b/docs/misc/livepatch.pandoc @@ -993,7 +993,7 @@ The design of that is not discussed in this design. This is implemented in a seperate tool which lives in a seperate GIT repo. -Currently it resides at git://xenbits.xen.org/livepatch-build-tools.git +Currently it resides at https://xenbits.xen.org/git-http/livepatch-build-tools.git ### Exception tables and symbol tables growth diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index 8f80d61d2f1aa9e63da9b1e61b77a67c826efe6f..7826419dad563a3b70c3c97fc4c0fb5339bd58e9 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -271,7 +271,7 @@ Hi all, Xen X.Y rcZ is tagged. You can check that out from xen.git: -git://xenbits.xen.org/xen.git X.Y.0-rcZ +https://xenbits.xen.org/git-http/xen.git X.Y.0-rcZ For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/X.Y.0-rcZ/xen-X.Y.0-rcZ.tar.gz diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..cf629cdf3c44e4abe67214378c49a3a9d858d9b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/git-http/xen.git\n"); $printed_novcs = 1; } return 0; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sun Feb 19 02:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 02:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497652.768520 (Exim 4.92) (envelope-from ) id 1pTZmO-0002WO-3r; Sun, 19 Feb 2023 02:50:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497652.768520; Sun, 19 Feb 2023 02:50:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmN-0002WG-V2; Sun, 19 Feb 2023 02:50:19 +0000 Received: by outflank-mailman (input) for mailman id 497652; Sun, 19 Feb 2023 02:50:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmM-0002Vk-Cb for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 02:50:18 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22412452-b000-11ed-933d-83870f6b2ba8; Sun, 19 Feb 2023 03:50:16 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8BCAF32004AE; Sat, 18 Feb 2023 21:50:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 18 Feb 2023 21:50:12 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 21:50:08 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22412452-b000-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676775011; x=1676861411; bh=Jd5MY4VF+HfxIL9l1Qbaez8l8BHoBek9uNF wPZ67yiU=; b=QKQ/J0vQkX9MbHGacr4wEPdWAr5xl/9SNjvecRhMzMdM96RZxg8 6CQYia4YHkA0l991Y+WrZyF+3Ek9IBUAmDqojZYjpyAsQTip6VzvNLSo4umvV66x uO3xh6O9Nqi8RnGkdebJkCDSrLYXi+UkEl3cr3Ocec5X79fV9e8oGu7FnSStnMGS b3bR1y9k5/KxKeSlZcJmxRTRkvmXzftizxjFkBdghphttYjWEUTeInl+Dhuer882 Sc9vFK412HkxgwlD+TafJqJtfm/j4FnWMx8Y5m4wKYOSwQGAX/i+wgSNDx/TyMZW /LLVo3vobkZbDcf3oAE16u6GDU6vEgwATjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676775011; x=1676861411; bh=Jd5MY4VF+HfxI L9l1Qbaez8l8BHoBek9uNFwPZ67yiU=; b=DbZN6PnltLkBRh47q6kh75A3JytDW cWI9a0pEjFlKzmMTVoHlD9dMOlnlkSIifswQfcrtZLPkxX13wN5GBSY2bzXhMbOh qRn7tayFQ82UC7cSL8DgJVdbmPjsOQYv6ZqJFgp47azsAfJeyTUZ5G+EAG+Fha53 b7NA/pNZIjVAGJ81leMBb4mE56HR1IGfPGGwe12+UcFsieuHbP0fUdhU9gNsLOzA UwcBj5yIQzh3Vwip6K3P0h2ONLJwgtl204PlJH65CuJ1UEucgVQtOt8YejjtZEZo nP3/a7hlJIz2zAC2jS7Km6JDUqbP/gm/UMauXS8c1u6v839wXA+RnwJ6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejvddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptefhhfdtkefhkefgjeduffehuedt gfduveejiedvffdvgeevledttdegvefhueegnecuffhomhgrihhnpeigvghnrdhorhhgpd gtohhnfhhighdrmhhknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Samuel Thibault , Anthony PERARD , Doug Goldstein Subject: [PATCH v4 0/3] Stop using insecure transports Date: Sat, 18 Feb 2023 21:46:12 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Changes since v3: - Drop patch 4, which is an unrelated removal of unused code. - Do not fail with an error if one tries to build the I/O emulator, vTPM, or vTPM manager stubdomains and passes --enable-extfiles. The user may have provided alternate download URLs via environment variables. Changes since v2: - Drop patches 5 and 6, which changed links not used by automated tools. These patches are the least urgent and hardest to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (3): Use HTTPS for all xenbits.xen.org Git repos Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http:// with https:// Config.mk | 20 ++++++-------------- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- scripts/get_maintainer.pl | 2 +- stubdom/configure | 18 +++++++++--------- stubdom/configure.ac | 18 +++++++++--------- tools/firmware/etherboot/Makefile | 6 +----- 12 files changed, 39 insertions(+), 51 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sun Feb 19 02:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 02:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497653.768531 (Exim 4.92) (envelope-from ) id 1pTZmT-0002ls-Ad; Sun, 19 Feb 2023 02:50:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497653.768531; Sun, 19 Feb 2023 02:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmT-0002lj-7I; Sun, 19 Feb 2023 02:50:25 +0000 Received: by outflank-mailman (input) for mailman id 497653; Sun, 19 Feb 2023 02:50:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmS-0002Vk-CG for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 02:50:24 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 27430005-b000-11ed-933d-83870f6b2ba8; Sun, 19 Feb 2023 03:50:23 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 34FC232005B5; Sat, 18 Feb 2023 21:50:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 18 Feb 2023 21:50:22 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 21:50:19 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27430005-b000-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676775020; x=1676861420; bh=9rmTWwkAVzEYzOXaR0GBy2XpALP9AHIvcss Mrr/PkeE=; b=bTFcGZHZ4Sr9PUuwJZeNKl758bpRqknew5TpGmNoe9WCQc5xhyT JRRhfuAgB3Rn8VckkjdmjHB5tiWgKJhX+NokutiYqmC/616B8Mt9sAuiJuTpVLom qIeVVRWL8BoaNpc/geDtzFmsi+K2KzWl28xCX673Jr7XCArck9l7mau57Vk1w54R OluLPyyYsE/oOJftzYgX0hc6GgTf5MqPb9P3D9fog5AEzuadNt3K9JNLTh9Y3Ifh hNPmXtYMRZgGpWcRSmGbNHA2zbD/1ZwYyl7rdiGfIudTZCQEjEQW3vIECyBhIL5B sAz6Xdc2V14H3hK+rlYfBmup49VylKwWPIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676775020; x=1676861420; bh=9rmTWwkAVzEYz OXaR0GBy2XpALP9AHIvcssMrr/PkeE=; b=BiuPB42ujBU92ITaBR+XKK8S1uadh JBiGy7D6BAlXUWeGJQ8bvviKZLJN3/Rxq7MioPawEDBgQCqAYvsxrSMQj9DNMsmb 6ou5KGMMTeVaN5BpHcfovgueP9KHJXvZKi3hvfTP28ytyUKVW8VaiYKhroslM00/ ohP47pyRJUdSczzBF4eyjd49m6ugm5opeytHkp/XaXMsTSCqepH1NsaDgDwmyi33 ZhVJ06/SsvqH6cpY7jElexo3DJek4gb9eDFuuCFChtW20Nl5qHmzG43Z8Knu7PjO oe9OGoE5F6mss5Y0dxxIhTpyNkGda4ngMkTYN+XzazCxbrHiuomsYt2bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejvddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdettdevhfevgfekuedvkeehledt veeikedtgfdtlefhheefkedtteekueeluddtnecuffhomhgrihhnpeigvghnrdhorhhgpd iilhhisgdrnhgvthdpkhgvrhhnvghlrdhorhhgpdhrvgguhhgrthdrtghomhdpshhouhhr tggvfigrrhgvrdhorhhgpdhgnhhurdhorhhgpdhinhhrihgrrdhfrhdpghhmphhlihgsrd horhhgpdhpohhlrghrshhslhdrohhrghdpsggvrhhlihhoshdruggvpdhiphigvgdrohhr ghdpghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD Subject: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// Date: Sat, 18 Feb 2023 21:46:14 -0500 Message-Id: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Some URLs returned 301 or 302 redirects, so I replaced them with the URLs that were redirected to. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- stubdom/configure | 18 +++++++++--------- stubdom/configure.ac | 18 +++++++++--------- tools/firmware/etherboot/Makefile | 6 +----- 4 files changed, 20 insertions(+), 24 deletions(-) diff --git a/Config.mk b/Config.mk index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..c717d315c75a596850b94e59c72c5d5f010f8888 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : ZLIB_URL=\$\(XEN_EXTFILES_URL\) else - ZLIB_URL="http://www.zlib.net" + ZLIB_URL="https://www.zlib.net" fi fi @@ -3550,7 +3550,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://mirrors.edge.kernel.org/pub/software/utils/pciutils" fi fi @@ -3565,7 +3565,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sourceware.org/ftp/newlib" fi fi @@ -3580,7 +3580,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3595,7 +3595,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3607,7 +3607,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3621,7 +3621,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://gmplib.org/download/gmp/archive" fi fi @@ -3636,7 +3636,7 @@ if test "x$POLARSSL_URL" = "x"; then : if test "x$extfiles" = "xy"; then : POLARSSL_URL=\$\(XEN_EXTFILES_URL\) else - POLARSSL_URL="http://polarssl.org/code/releases" + POLARSSL_URL="https://polarssl.org/code/releases" fi fi @@ -3651,7 +3651,7 @@ if test "x$TPMEMU_URL" = "x"; then : if test "x$extfiles" = "xy"; then : TPMEMU_URL=\$\(XEN_EXTFILES_URL\) else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" + TPMEMU_URL="https://download.berlios.de/tpm-emulator" fi fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..ab52e00293bee033db9ff7133efd34daa5944c8d 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,15 +55,15 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [https://www.zlib.net]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://mirrors.edge.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gmp/archive]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [https://polarssl.org/code/releases]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [https://download.berlios.de/tpm-emulator]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..6ab9e5bc6b4cc750f2e802128fbc71e9150397b1 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -4,11 +4,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk include Config -ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git -else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git -endif +IPXE_GIT_URL ?= https://github.com/ipxe/ipxe.git # put an updated tar.gz on xenbits after changes to this variable IPXE_GIT_TAG := 3c040ad387099483102708bb1839110bc788cefb -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sun Feb 19 02:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 02:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497655.768553 (Exim 4.92) (envelope-from ) id 1pTZmY-0003KN-0u; Sun, 19 Feb 2023 02:50:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497655.768553; Sun, 19 Feb 2023 02:50:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmX-0003KE-TW; Sun, 19 Feb 2023 02:50:29 +0000 Received: by outflank-mailman (input) for mailman id 497655; Sun, 19 Feb 2023 02:50:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTZmW-0002Vk-B1 for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 02:50:28 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29919810-b000-11ed-933d-83870f6b2ba8; Sun, 19 Feb 2023 03:50:27 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 27CBE3200583; Sat, 18 Feb 2023 21:50:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 18 Feb 2023 21:50:25 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Feb 2023 21:50:23 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29919810-b000-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676775024; x=1676861424; bh=x1U4BNcj9Zecyq6U+qye/Zm4u8N3JEG92kP 6XRxNw5M=; b=hyEmewljALJ6TecsrhfSuyupXf0mwhAyzyA2sNRKSkT17UL5nMK po6gDn2Xys532BqHGimKCsiwfiXV0ATqV13gTO4hcvdKVKeT+6fPlEXqXGVBW0gX pzg3fcug5r+XVDsobOHKw2pIJtux5p37N44I84m8rXMnKqGEaN+dC9S/2ZPu2G+r psS1lnBCs7nf9u8CMHE6JpgFDsRwvyTsPPf4mKoFG7JBMcKZjrIs9ecHOgIiIAJc y1RZ6Ov0ermw69a7Ushk0r/RGihAYD1U8lS+LWXTILAw1woe+47Xz4A4lH7jG/ni olJi0drxdFCgEZkB1/9htfPL+bL4Rt0k57g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1676775024; x=1676861424; bh=x1U4BNcj9Zecy q6U+qye/Zm4u8N3JEG92kP6XRxNw5M=; b=Ce/iG8l5PGkiL2aDxsYWvD9Lf47va rVHfT5CgeMYrT/cpn0qL68HbgfvsB7BzVhFXUhwmXB2KYl5oG2tcJmX01CPNhi12 3i6RlEqNxPOiXwDsyUuNrnu5gfseZ94hwEeJ/nKjxD3ONvk1o20Afb6Q0eO1Sm02 kgqcT2DREBEbGhnf54ViBD34gOIOgke3BjHYEv4hQ2r6rOR8oVdzlGz/PtCBRSc+ OJ6F6HKMwUukRgg/6823ySM1beD4D5vymJgLyp4dTAjNSegeavIJ5WbLePpykEQH 5CbpcqlRStAGIed/cnh5K9AipXKDvuzTB+XDNX2NI+rGcy+0W3iuFlMtw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejvddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteduueehgeeujeegudeiffffveel teeljeevudeileffieetgfegffeitedvkeeunecuffhomhgrihhnpehphihthhhonhdroh hrghdpihhnthgvlhdrtghomhdptggvnhhtohhsrdhorhhgpdhllhhvmhdrohhrghdpuggv sghirghnrdhorhhgpdgrlhhpihhnvghlihhnuhigrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgv thhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: [PATCH v4 3/3] Automation and CI: Replace git:// and http:// with https:// Date: Sat, 18 Feb 2023 21:46:15 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie Obenour --- README | 4 ++-- automation/build/centos/CentOS-7.2.repo | 8 ++++---- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/build/debian/unstable-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo index 4da27faeb5fa863fd4e140cbeaad308b9a543b86..8e37da1a03f839c486eb9bd0af46716cfb9086e0 100644 --- a/automation/build/centos/CentOS-7.2.repo +++ b/automation/build/centos/CentOS-7.2.repo @@ -6,28 +6,28 @@ [base] name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #released updates [updates] name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/updates/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that may be useful [extras] name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/extras/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 #additional packages that extend functionality of existing packages [centosplus] name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ +baseurl=https://vault.centos.org/7.2.1511/centosplus/$basearch/ gpgcheck=1 gpgcheck=1 enabled=0 diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list index dc119fa0b4df1bd6e742c42776710abcd6deaa86..1db1598997429d7a14d3fcd8f0f8152aa6d40b8a 100644 --- a/automation/build/debian/unstable-llvm-8.list +++ b/automation/build/debian/unstable-llvm-8.list @@ -1,3 +1,3 @@ # Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb https://apt.llvm.org/unstable/ llvm-toolchain-8 main +deb-src https://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..950ad3a0daa63d66fc8647c0a390ff59c2f22b1a 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://ftp.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sun Feb 19 04:44:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 04:44:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497685.768563 (Exim 4.92) (envelope-from ) id 1pTbYO-0001JE-J5; Sun, 19 Feb 2023 04:44:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497685.768563; Sun, 19 Feb 2023 04:44:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTbYO-0001J7-GL; Sun, 19 Feb 2023 04:44:00 +0000 Received: by outflank-mailman (input) for mailman id 497685; Sun, 19 Feb 2023 04:43:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTbYM-0001Ix-TO; Sun, 19 Feb 2023 04:43:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTbYM-0003OX-Mk; Sun, 19 Feb 2023 04:43:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTbYM-0004rn-9N; Sun, 19 Feb 2023 04:43:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTbYM-0003JH-8w; Sun, 19 Feb 2023 04:43:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=to0tQk6xsdm6H8vr1LQn9hkjDu9BbZoBUoEGMJWzheY=; b=vwLexJ4gTmNv6caay3ChK7uJUs 8DTxsCtH/Ta07iyJ/VdNBrUfqzJjPyr7DyktKcga9610o+cNeqIk50T014eI8m++K4pfoR+x32y/m vyX0Hp+Xzm5xD6ezcnaRO3ORgmdnXR3+VmRw1gmMqaIvUn0Rfsoq5Omq4mmF8dMTN9Tk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177745: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5e725d112e1a54c2611d5dffd124a79415d0f0de X-Osstest-Versions-That: linux=38f8ccde04a3fa317b51b05e63c3cb57e1641931 From: osstest service owner Date: Sun, 19 Feb 2023 04:43:58 +0000 flight 177745 linux-linus real [real] flight 177777 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177745/ http://logs.test-lab.xenproject.org/osstest/logs/177777/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 177777-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177681 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177681 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177681 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177681 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177681 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5e725d112e1a54c2611d5dffd124a79415d0f0de baseline version: linux 38f8ccde04a3fa317b51b05e63c3cb57e1641931 Last test of basis 177681 2023-02-18 04:33:31 Z 1 days Testing same since 177745 2023-02-18 19:43:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christoph Hellwig Greg Kroah-Hartman Janne Grunau Jens Axboe Keith Busch Linus Torvalds Mark Rutland Paolo Bonzini Sean Christopherson Will Deacon Xingyuan Mo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 38f8ccde04a3..5e725d112e1a 5e725d112e1a54c2611d5dffd124a79415d0f0de -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Feb 19 05:34:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 05:34:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497700.768575 (Exim 4.92) (envelope-from ) id 1pTcKK-00088k-Ej; Sun, 19 Feb 2023 05:33:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497700.768575; Sun, 19 Feb 2023 05:33:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTcKK-00088d-Bm; Sun, 19 Feb 2023 05:33:32 +0000 Received: by outflank-mailman (input) for mailman id 497700; Sun, 19 Feb 2023 05:33:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTcKI-00088X-Ni for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 05:33:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efc38b89-b016-11ed-93b5-47a8fe42b414; Sun, 19 Feb 2023 06:33:28 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 52189205B9; Sun, 19 Feb 2023 05:33:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28EE9139D3; Sun, 19 Feb 2023 05:33:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6O+aCKe08WMDVAAAMHmgww (envelope-from ); Sun, 19 Feb 2023 05:33:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efc38b89-b016-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676784807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=832f7y/DEQYVNUWLP48lxy1p/M35cveOY0myYlavc1w=; b=upN1/SCIPXlb6jyI32YIG7qFUWroZV28TAjKX8jrvE9zckezEYa3l3FXqDepsPlucEVfKS TL0lBYsQ4RYmu0bTmjgGRPNsith4+Rmygwdlj2bg4s1jCWL5rOy2sXASDdZinwE7Q6fT3h Fq3tTX2JhVkBspHc8eL5HSbx6v+mmJk= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v6.3-rc1 Date: Sun, 19 Feb 2023 06:33:26 +0100 Message-Id: <20230219053326.4980-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.3-rc1-tag xen: branch for v6.3-rc1 It contains the following patches: - A patch to help deprecating the /proc/xen files by making the related information available via sysfs. - 2 patches for making the Xen variants of play_dead "noreturn". - A patch to support a shared Xen platform interrupt. - Several small cleanups and fixes. Thanks. Juergen Documentation/ABI/stable/sysfs-hypervisor-xen | 13 +++++ arch/x86/xen/setup.c | 4 -- arch/x86/xen/smp.h | 2 + arch/x86/xen/smp_pv.c | 17 ++----- arch/x86/xen/time.c | 38 +++++++++++++- arch/x86/xen/xen-head.S | 7 +++ drivers/xen/events/events_base.c | 9 ++-- drivers/xen/grant-dma-iommu.c | 11 ++++- drivers/xen/platform-pci.c | 5 +- drivers/xen/pvcalls-back.c | 3 +- drivers/xen/sys-hypervisor.c | 71 +++++++++++++++++++++++++-- drivers/xen/xen-front-pgdir-shbuf.c | 2 +- include/xen/events.h | 2 +- tools/objtool/check.c | 1 + 14 files changed, 151 insertions(+), 34 deletions(-) David Woodhouse (1): xen: Allow platform PCI interrupt to be shared Gustavo A. R. Silva (1): xen: Replace one-element array with flexible-array member Jan Beulich (1): x86/Xen: drop leftover VM-assist uses Juergen Gross (2): x86/xen: don't let xen_pv_play_dead() return x86/xen: mark xen_pv_play_dead() as __noreturn Krister Johansen (1): x86/xen/time: prefer tsc as clocksource when it is invariant Oleksandr Tyshchenko (1): xen/grant-dma-iommu: Implement a dummy probe_device() callback Per Bilse (1): drivers/xen/hypervisor: Expose Xen SIF flags to userspace Thomas Weißschuh (1): xen: sysfs: make kobj_type structure constant Volodymyr Babchuk (1): xen/pvcalls-back: fix permanently masked event channel From xen-devel-bounces@lists.xenproject.org Sun Feb 19 09:29:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 09:29:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497721.768586 (Exim 4.92) (envelope-from ) id 1pTg0F-0003Ib-DN; Sun, 19 Feb 2023 09:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497721.768586; Sun, 19 Feb 2023 09:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTg0F-0003IU-9U; Sun, 19 Feb 2023 09:29:03 +0000 Received: by outflank-mailman (input) for mailman id 497721; Sun, 19 Feb 2023 09:29:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTg0D-0003IK-GI; Sun, 19 Feb 2023 09:29:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTg0D-00028e-DU; Sun, 19 Feb 2023 09:29:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTg0C-0002ug-Tf; Sun, 19 Feb 2023 09:29:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTg0C-0005QO-TC; Sun, 19 Feb 2023 09:29:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Tj8rUUIXB8Wj0TpjC88cJEW6CBAy5RM3IWRJ9UjzG1E=; b=pJFP8eFNq7TqHOhVMJqz8c+ORx Pbyw9Ff+BbsrIK2KX+/mmtrdYMYTp3R5yqJt4dp18b2cNE7sMhxm1oJfL07xprctooPfflZ9Kv4Gf 6FzVT0Jg8XhNjGiBpJCVOOmhfDxAFbC5r0oikdR1YYXuQ1D+G9FE0cnQz6RwMj2JfXtI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177770: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd X-Osstest-Versions-That: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd From: osstest service owner Date: Sun, 19 Feb 2023 09:29:00 +0000 flight 177770 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177770/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-xsm 8 xen-boot fail in 177707 pass in 177770 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail pass in 177707 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 177707 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 177707 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 177707 test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 177707 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 177707 like 177659 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177707 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177707 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177707 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177707 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177707 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177707 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177707 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177707 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd baseline version: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd Last test of basis 177770 2023-02-19 01:54:11 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Feb 19 14:56:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 14:56:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497786.768597 (Exim 4.92) (envelope-from ) id 1pTl6n-0000KC-Ic; Sun, 19 Feb 2023 14:56:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497786.768597; Sun, 19 Feb 2023 14:56:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTl6n-0000K5-G3; Sun, 19 Feb 2023 14:56:09 +0000 Received: by outflank-mailman (input) for mailman id 497786; Sun, 19 Feb 2023 14:56:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTl6m-0000Jv-FT; Sun, 19 Feb 2023 14:56:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTl6m-00012U-Di; Sun, 19 Feb 2023 14:56:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTl6m-0001uL-3o; Sun, 19 Feb 2023 14:56:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTl6m-0004BA-3J; Sun, 19 Feb 2023 14:56:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NvBb7XeFE5QdKCsHDYDh+4NbWEf8GhWfREu3s1sDe+I=; b=JQi4fRE5fXf//UFBQFsM8P+JHL LwWe9uZ3kKwB2YUe0zBcVu1T39iSLG8EkONbUU7/Q02brlIWwgtlBqtCYkhx/gXyc7HYYBB5ns37N 4pN8nWWP0gJb7jQL9J9B1jLPQJe7Ep/32aUW9AA1wFclQY0kktMOG0sASZ6t/1FAefZE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177784: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=925cf0457d7e62ce08878ffb789189ac08ca8677 X-Osstest-Versions-That: linux=5e725d112e1a54c2611d5dffd124a79415d0f0de From: osstest service owner Date: Sun, 19 Feb 2023 14:56:08 +0000 flight 177784 linux-linus real [real] flight 177822 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/177784/ http://logs.test-lab.xenproject.org/osstest/logs/177822/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qcow2 19 guest-start/debian.repeat fail pass in 177822-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177745 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177745 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177745 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177745 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177745 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 925cf0457d7e62ce08878ffb789189ac08ca8677 baseline version: linux 5e725d112e1a54c2611d5dffd124a79415d0f0de Last test of basis 177745 2023-02-18 19:43:58 Z 0 days Testing same since 177784 2023-02-19 04:47:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Borislav Petkov (AMD) Christian Kujau John Stultz Juergen Gross Linus Torvalds Reinette Chatre Thomas Gleixner jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 5e725d112e1a..925cf0457d7e 925cf0457d7e62ce08878ffb789189ac08ca8677 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Feb 19 16:45:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 16:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497823.768608 (Exim 4.92) (envelope-from ) id 1pTmoI-0005Yu-Gv; Sun, 19 Feb 2023 16:45:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497823.768608; Sun, 19 Feb 2023 16:45:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTmoI-0005Yn-EF; Sun, 19 Feb 2023 16:45:10 +0000 Received: by outflank-mailman (input) for mailman id 497823; Sun, 19 Feb 2023 16:45:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTmoH-0005Yh-7x for xen-devel@lists.xen.org; Sun, 19 Feb 2023 16:45:09 +0000 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [2607:f8b0:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3937095-b074-11ed-933d-83870f6b2ba8; Sun, 19 Feb 2023 17:45:07 +0100 (CET) Received: by mail-pf1-x433.google.com with SMTP id 7so363632pfo.13 for ; Sun, 19 Feb 2023 08:45:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3937095-b074-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qa3hU/3iylBoeEP41sC20sjI+3hQfarin5DO/1FfQyw=; b=PPzSeB1Yt1kdP2xe2OpLBp6ITs43VvIhGyrbgJ7T2sudxd8SETEqx7WfSLQtp1Vrn9 CwBLi6uM5S/UzzmCmKtRFjx/mxOFLrsa5qsH83SBh15mAavNVJDWCmwTdKIufORL//Qe xrT0ucQkG33HhL7Xhom6S7tcOOH0KqLBrXVv54AolJTFVgaO1NIqzYQJMKt+Xw5nsgoB 26Hq7F75axdzGlukDTlKQM5fMCFEnDLDwTpUh6OTyX5nXtY+7/L13hUpXYiHAtoGCeNf Qu/XAdOo5MJZYgsfylT9J9bhdAX/EIyeLKnH8PkTLPdS1JTZcyTGSXHZNakq7OY7qsl+ ULrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qa3hU/3iylBoeEP41sC20sjI+3hQfarin5DO/1FfQyw=; b=rj+i5I98uNEphzULtRY9gn8u9L8rk1hhvF1QgtgEJObr9g++/KPKBGC/0uTqgcK8jZ 0HEgsNJIZZMJ8oqwrUq8B6OQ9KvTAu8q3S5xuO/tV0hmdc9hfKILalddOdtxzI2lN9RH DmCW4TKsiYpszboh+mYibiP6lAqgeNjY0H+4u5+pgLEIfsQinTsciIORfme+oW0uni12 DJTjBfkfu4ja2GSEt8uoZC6cXGcUeG855fUwdTEUN8Vau8Ehh3f8vCw2ZvJxRzsayoyN PRpxjxi1Hsuovzr3A24GBcg+MuX4HE+1Dz2OKaxcYTeyaTNVLwBiMrGL2A9n8o0PpK9w 91mw== X-Gm-Message-State: AO0yUKWKUr25uaTFcNjPvnoYvmuDR7c24609WbpC40Am/2ds8NEMpKQy XlqQ0YmF+q3I+oTUAlMrQqsi5Dus7RQYjXjOkHA= X-Google-Smtp-Source: AK7set/0XzGrwYs4lhic2U5pNKJQuKg+zuohvY2a9qJBjGD9mzDZkUyx9YQpdNczrgyMrXtnTq3TbB/K8i5GMMnaGGw= X-Received: by 2002:aa7:9284:0:b0:5a9:b96f:d039 with SMTP id j4-20020aa79284000000b005a9b96fd039mr47451pfa.41.1676825105481; Sun, 19 Feb 2023 08:45:05 -0800 (PST) MIME-Version: 1.0 References: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> In-Reply-To: <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> From: Oleksandr Tyshchenko Date: Sun, 19 Feb 2023 18:44:54 +0200 Message-ID: Subject: Re: [Discussion] Xen grants and access permissions To: Viresh Kumar Cc: Andrew Cooper , Stratos Mailing List , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org, Juergen Gross Content-Type: multipart/alternative; boundary="000000000000c3442005f51044d2" --000000000000c3442005f51044d2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Viresh. [CCed J=C3=BCrgen who might have some thoughts] [Sorry for the possible format issues] On Thu, Feb 16, 2023 at 1:36 PM Andrew Cooper wrote: > On 16/02/2023 11:13 am, Viresh Kumar wrote: > > Hi Oleksandr, > > > > As you already know, I am looking at how we can integrate the Xen > > grants work in our implementation of Rust based Xen vhost frontend [1]. > > > > The hypervisor independent vhost-user backends [2] talk to > > xen-vhost-frontend using the standard vhost-user protocol [3]. Every > > memory region that the backends get access to are sent to it by the > > frontend as memory region descriptors, which contain only address and > > size information and lack any permission flags. > > > > I noticed that with Xen grants, there are strict memory access > > restrictions, where a memory region may be marked READ only and we > > can't map it as RW anymore, trying that just fails. Because the > > standard vhost-user protocol doesn't have any permission flags, the > > vhost libraries (in Rust) can't do anything else but try to map > > everything as RW. > > > > I am wondering how do I proceed on this as I am very much stuck here. > > > > (unhelpful comment) This is what happens when people try to reinvent the > wheel a little more square than it was before. > > If the guest grants the page read-only, then you can only map it read > only. Anything else is a violation of the security model. > > So either you need to adjust the guest to always grant read/write, or > you need to teach virtio that read only is actually a real concept. > > ~Andrew > Below are my thoughts which might be wrong. I see the problem, but cannot add anything else to what Andrew has already said. If the frontend maps a page as RO then a backend (device) should map it with the same attribute and perform only read access to it. Restricted memory access using Xen grants is a kind of SW IOMMU, no more no less, so I assume the very same problem would take place if we would implement a virtio-iommu for Xen... Let's assume that we cannot modify a guest to map *everything* as RW. But although the permission flags are not communicated explicitly in classic case, the backend usually knows how a particular frontend page is supposed to be mapped (at least I didn't face any permission related issues when using Xen grants either with standalone virtio-disk backend or Qemu based backends using J=C3=BCrgen's PoC): 1. The virtqueues are mapped as RW (because it is supposed to be written by both ends) 2. The payload I/O buffer's (virtio ring descriptors) fortunately have a flag field, so it is always known whether they are WO or RO 3. The indirect descriptor is mapped as RO (because it contains a list of other descriptors, so nothing to be written there) So I am wondering can this standard vhost-user protocol be extended to pass some additional information for a memory region? If and only if that standard vhost-user protocol cannot be extended to communicate required information for a memory region *and* there is a need to use Xen grants for virtio (so it is completely unclear what that memory region actually represents and how it should be mapped) one (crazy?) idea could be to try to map everything as RW and fallback to RO if the mapping attempt fails. Or, perhaps, as an alternative, to map as RW only those pages which are going to be modified, anything else map as RO. Although I am not quite sure whether it would be a good idea. --=20 Regards, Oleksandr Tyshchenko --000000000000c3442005f51044d2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Viresh.

[CCed J=C3=BCrgen wh= o might have some thoughts]
[Sorry for the possible format is= sues]

On Thu, Feb 16, 2023 at 1:36 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
=
On 16/02/2023 11:13 am, V= iresh Kumar wrote:
> Hi Oleksandr,
>
> As you already know, I am looking at how we can integrate the Xen
> grants work in our implementation of Rust based Xen vhost frontend [1]= .
>
> The hypervisor independent vhost-user backends [2] talk to
> xen-vhost-frontend using the standard vhost-user protocol [3]. Every > memory region that the backends get access to are sent to it by the > frontend as memory region descriptors, which contain only address and<= br> > size information and lack any permission flags.
>
> I noticed that with Xen grants, there are strict memory access
> restrictions, where a memory region may be marked READ only and we
> can't map it as RW anymore, trying that just fails. Because the > standard vhost-user protocol doesn't have any permission flags, th= e
> vhost libraries (in Rust) can't do anything else but try to map > everything as RW.
>
> I am wondering how do I proceed on this as I am very much stuck here.<= br> >

(unhelpful comment) This is what happens when people try to reinvent the wheel a little more square than it was before.

If the guest grants the page read-only, then you can only map it read
only.=C2=A0 Anything else is a violation of the security model.

So either you need to adjust the guest to always grant read/write, or
you need to teach virtio that read only is actually a real concept.

~Andrew
=C2=A0

Below are my t= houghts which might be wrong.

I see the problem, but cannot add anyt= hing else to what Andrew has already said. If the frontend maps a page as R= O then a backend (device) should
map it with the same attribute and per= form only read access to it. Restricted memory access using Xen grants is a= kind of SW IOMMU,=C2=A0
no more no less,=C2=A0so I assume the ve= ry same problem would take place if we would implement a virtio-iommu for X= en...

Let's assume that we cannot modify a guest to map *everyth= ing* as RW. But although the permission flags are not communicated explicit= ly in classic case,
the backend usually knows how a particular fr= ontend page is supposed to be mapped
(at least I didn't face = any permission related issues when using Xen grants either with standalone = virtio-disk backend or Qemu based backends using J=C3=BCrgen's PoC):
1. The virtqueues are mapped as RW (because it is supposed to be writt= en by both ends)
2. The payload I/O buffer's (virtio ring descriptor= s) fortunately have a flag field, so it is always known whether they are WO= or RO
3. The indirect descriptor is mapped as RO (because it contains a= list of other descriptors, so nothing to be written there)

So I am = wondering can this standard vhost-user protocol be extended to pass some ad= ditional information for a memory region?

If and only if that stand= ard vhost-user protocol cannot be extended to communicate required informat= ion for a memory region *and*=C2=A0
there is a need to use Xen gr= ants for virtio (so it is completely unclear what that memory region actual= ly represents and how it should be mapped)
one (crazy?) idea coul= d be to try to map everything as RW and fallback to RO if the mapping attem= pt fails. Or, perhaps, as an alternative,
to map as RW only those= pages which are going to be modified, anything else map as RO. Although I = am not quite sure whether it would be a good idea.



--
=
Regards,

Oleksandr Tyshchenko
--000000000000c3442005f51044d2-- From xen-devel-bounces@lists.xenproject.org Sun Feb 19 18:42:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 18:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497844.768618 (Exim 4.92) (envelope-from ) id 1pTod8-0002jq-TS; Sun, 19 Feb 2023 18:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497844.768618; Sun, 19 Feb 2023 18:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTod8-0002jj-Qs; Sun, 19 Feb 2023 18:41:46 +0000 Received: by outflank-mailman (input) for mailman id 497844; Sun, 19 Feb 2023 18:41:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTod7-0002jd-Cv for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 18:41:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTocu-0006tk-8d; Sun, 19 Feb 2023 18:41:32 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pTocu-0000ZX-22; Sun, 19 Feb 2023 18:41:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Z8UcSn7i8fdkVwIl3VVl4Lo2sCT5mIAKrC2iJlQ5a5U=; b=lGU/6HpLeY5VOs/L7gVTIXUXlQ RoxhcOXAGnwYhIVczw6Afd0Id89UKWY/aTOCxHKwGaj1gnrZOmqNq9s245Y3oXAHVgJaqGOe5HwnD Rq84hyxYNzYXnON0rtB9pb5BMcCaf5t2fiG31t7NvGNKEJJP7aIGtVp9M3e5cVKK9mrc=; Message-ID: <8e2d3064-c7c3-4a3c-2f11-a04a68662447@xen.org> Date: Sun, 19 Feb 2023 18:41:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 0/6] xen/x86: Use SPDX (take 1) Content-Language: en-US To: Jan Beulich Cc: demi@invisiblethingslab.com, Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , xen-devel@lists.xenproject.org References: <20230209230020.52695-1-julien@xen.org> <34dd6673-a8b2-977c-adfd-928418cb5435@suse.com> From: Julien Grall In-Reply-To: <34dd6673-a8b2-977c-adfd-928418cb5435@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 13/02/2023 09:27, Jan Beulich wrote: > On 10.02.2023 00:00, Julien Grall wrote: >> This is a first attempt to replace all the full license text with >> SPX tag in xen/arch/x86/. For now, this is only covering files with GPL 2.0 >> and 3 different patterns. > > For clarification - the three patterns mentioned here are the three slightly > differently formatted/spelled versions of effectively the same text, not ... Correct. > >> I have used the script below to remove the full license and add >> an SPDX tag. The script is based on the work from Anthony [1] >> >> 42sh> cat replace_license.py >> #! /usr/bin/python3 >> ## We are opening/writing to files using the binary mode to avoid >> ## python interpreting the content (reading ./drivers/video/font_8x14.c >> ## will throw some encoding error otherwise). >> >> import sys >> >> if len(sys.argv) < 4: >> print("./replace_license [debug]") >> exit(1) >> >> licence_file = sys.argv[1] >> spdx = str.encode(sys.argv[2]) >> file = sys.argv[3] >> # HACK: enable debug if there is a 4th argument >> debug = len(sys.argv) == 5 >> >> with open(licence_file, 'rb') as f: >> licence = f.read() >> >> licence_spdx = b"/* SPDX-License-Identifier: " + spdx + b" */\n" >> >> print(f"reading {file}") >> with open(file, 'rb') as f: >> whole_file = f.read() >> >> try: >> licence_loc = whole_file.index(licence) >> except ValueError: >> print("licence not found. Ignoring") >> exit(0) >> >> # Replace one the below pattern with nothing >> ## Pattern 1 >> # * >> # * >> whole_file = whole_file.replace(licence + b' *\n', b'') >> >> ## Pattern 2 >> # * >> # * >> whole_file = whole_file.replace(b' *\n' + licence, b'') >> >> ## Pattern 3 >> # /* >> # * >> # */ >> whole_file = whole_file.replace(b'/*\n' + licence + b' */\n', b'') >> >> ## Pattern 4 >> # * >> # * >> whole_file = whole_file.replace(b' * \n' + licence, b'') > > ... referring to the (really four) patterns here? > >> Julien Grall (6): >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 2) >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 3) >> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 3) > > With the one further adjustment you did spot yourself: > Acked-by: Jan Beulich Thanks! The series is mostly mechanical change. So I am not sure whether I should wait for all the maintainers to ack before committing (it has been already a week). Any thoughts? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 19 18:45:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 18:45:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497853.768630 (Exim 4.92) (envelope-from ) id 1pTogq-0003OJ-IK; Sun, 19 Feb 2023 18:45:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497853.768630; Sun, 19 Feb 2023 18:45:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTogq-0003OC-F5; Sun, 19 Feb 2023 18:45:36 +0000 Received: by outflank-mailman (input) for mailman id 497853; Sun, 19 Feb 2023 18:45:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTogp-0003O6-KV for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 18:45:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTogn-0006zD-VA; Sun, 19 Feb 2023 18:45:33 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pTogn-0000ns-QO; Sun, 19 Feb 2023 18:45:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=V0oDH/Yq3gpCHs/8/f/FTGzeSPkLlYuB4NNPvGTFmQA=; b=dL11qbP97jyryiCGIqhiVmvdS6 SDvwLQbg7Ziixse6o0e+X1fFPb+OK+2+V8NzaDZhseMp2L1AAvToc7+CJijWITMGpJfABRfxiUO6U e+UMIGpUOA5WTNV0GLh8H5uz4NNoEwb7wJIhfkYBP3fd3YD0OOOkOganI9V7laN79diI=; Message-ID: Date: Sun, 19 Feb 2023 18:45:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/4] docs/process: branching-checklist: Reword the section about Config.mk Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230209172820.56292-1-julien@xen.org> <20230209172820.56292-2-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/02/2023 01:57, Henry Wang wrote: > Hi Julien, Hi Henry, > >> -----Original Message----- >> Subject: [PATCH v2 1/4] docs/process: branching-checklist: Reword the >> section about Config.mk >> >> From: Julien Grall >> >> Since at least Xen 4.12, the revision for external trees don't contain >> the word "unstable". So explicitely list the *_REVISION variables that > > A small typo that can be fixed on commit: s/explicitely/explicitly > >> need to be updated as part of the branching process. >> >> Signed-off-by: Julien Grall > > Change looks good, thanks for updating the doc :) > > Reviewed-by: Henry Wang Thanks! I fixed the typo and committed the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 19 20:39:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 20:39:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497864.768641 (Exim 4.92) (envelope-from ) id 1pTqSJ-0007sz-HA; Sun, 19 Feb 2023 20:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497864.768641; Sun, 19 Feb 2023 20:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqSJ-0007ss-E7; Sun, 19 Feb 2023 20:38:43 +0000 Received: by outflank-mailman (input) for mailman id 497864; Sun, 19 Feb 2023 20:38:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqSI-0007sk-AJ for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 20:38:42 +0000 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [2607:f8b0:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 62f054b9-b095-11ed-93b5-47a8fe42b414; Sun, 19 Feb 2023 21:38:38 +0100 (CET) Received: by mail-pg1-x529.google.com with SMTP id 8so324096pge.10 for ; Sun, 19 Feb 2023 12:38:38 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id p21-20020aa78615000000b005afda1496c6sm2648912pfn.31.2023.02.19.12.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 12:38:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62f054b9-b095-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=cNhE2FASeH5o8yi0ZLyiaK0kUF7pA0USqp0ltHH/0Fo=; b=TJUJ1J2ArJiZ+C52sbA4rJUl5jkwfEU0A4lmboDWRNDWEfBXuFPkUHzTEyJZAm+S4p Wge2lQiBs7TGtXwWkE0b1xhZw6outUBXabRYNKQBImrjMsw8dd8fr8oWOeq3BFAQBjtb 8uo983lQimMC+dk9fekE1rNd+VY9r+8q/tjI4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cNhE2FASeH5o8yi0ZLyiaK0kUF7pA0USqp0ltHH/0Fo=; b=zB+BCXio0dedt9PKMkMxnOZRkuX4yMsaepoG4kbWclP2Plori7XZcJNP0gO9pV57+k FJE/d18Xc5ICmMH/FF9Js9MopRO+JZ2tyMNOy4KJV+5XpXJ9NSixbFo1ntzdKehrFe1H +Kkcp8lwIimPBjndh3C9xX61cFyaCv+gQBcelFm/Vu08z/P1+dIKp4sA//BePf1UIDRJ iNvN1Jv1ZoceAOnI7aPD8uzMHjsw6FkZ+r7uCDC0WG99CGoefK774YcBds+vR32CpxP1 NDNoaonnxFAllRY3SctlUZ8B1zSMo+fUF4MxUk6ID3bF5kPnK8uU/dQdEivPRYZ7/QH5 WVTg== X-Gm-Message-State: AO0yUKU56+66c7HMhG8mruWHojTWDajFIsQcMw6fj3g1jjSSu8IbTEpg euXMvHQ0m4EW5rLO0u5YlLdOSg== X-Google-Smtp-Source: AK7set/XVAl5klPqjExLu4JTPo0Bl98f24f9lS+8n7DA1eEGRV2Dh4JhkKn00B8IKrJYG+VivvI0vw== X-Received: by 2002:a62:1a57:0:b0:58d:d546:8012 with SMTP id a84-20020a621a57000000b0058dd5468012mr769767pfa.0.1676839116854; Sun, 19 Feb 2023 12:38:36 -0800 (PST) Message-ID: <63f288cc.a70a0220.5558c.3c92@mx.google.com> X-Google-Original-Message-ID: <202302191237.@keescook> Date: Sun, 19 Feb 2023 12:38:35 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 11/41] mm: Introduce pte_mkwrite_kernel() References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-12-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-12-rick.p.edgecombe@intel.com> On Sat, Feb 18, 2023 at 01:14:03PM -0800, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these changes is to allow for pte_mkwrite() to create different > types of writable memory (the existing conventionally writable type and > also the new shadow stack type). Future patches will convert pte_mkwrite() > to take a VMA in order to facilitate this, however there are places in the > kernel where pte_mkwrite() is called outside of the context of a VMA. > These are for kernel memory. So create a new variant called > pte_mkwrite_kernel() and switch the kernel users over to it. Have > pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches > will introduce changes to make pte_mkwrite() take a VMA. > > Only do this for architectures that need it because they call pte_mkwrite() > in arch code without an associated VMA. Since it will only currently be > used in arch code, so do not include it in arch_pgtable_helpers.rst. > > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe I think it's a little weird that it's the only PTE helper taking a vma, but it does seem like the right approach. Reviewed-by: Kees Cook -- Kees Cook From xen-devel-bounces@lists.xenproject.org Sun Feb 19 20:40:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 20:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497870.768652 (Exim 4.92) (envelope-from ) id 1pTqTZ-00009K-RX; Sun, 19 Feb 2023 20:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497870.768652; Sun, 19 Feb 2023 20:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqTZ-00009D-OY; Sun, 19 Feb 2023 20:40:01 +0000 Received: by outflank-mailman (input) for mailman id 497870; Sun, 19 Feb 2023 20:40:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqTZ-000093-1i; Sun, 19 Feb 2023 20:40:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqTY-0001Hl-VS; Sun, 19 Feb 2023 20:40:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqTY-00014L-It; Sun, 19 Feb 2023 20:40:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTqTY-0003Ts-IU; Sun, 19 Feb 2023 20:40:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hPk8Irvtxc5EsB+b1XvfeNVdO9H8WwpA4YnmjGP97bU=; b=ogE4UDM9Qy5oNH3E20RPeUCxyu tHOYj208Qh83z3+b2hmY45oWUCM44D49taEJv3o1b6vDbhNScBVWqR+MtMrywaSlemEHadZQC0uwg ynpNPjGpPFLsiX8/HP7PYumkDxNceCGV4T8eB5e3dWkm2yTKuq//Fdbmwuxim/lu1aVY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 177843: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac X-Osstest-Versions-That: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd From: osstest service owner Date: Sun, 19 Feb 2023 20:40:00 +0000 flight 177843 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/177843/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac baseline version: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd Last test of basis 177603 2023-02-17 12:01:55 Z 2 days Testing same since 177843 2023-02-19 19:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap George Dunlap Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e2312e41f0..406cea1970 406cea1970535cd7b9d6bcf09bc164ef9bb64bac -> smoke From xen-devel-bounces@lists.xenproject.org Sun Feb 19 20:41:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 20:41:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497878.768663 (Exim 4.92) (envelope-from ) id 1pTqUP-0001Xo-7b; Sun, 19 Feb 2023 20:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497878.768663; Sun, 19 Feb 2023 20:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqUP-0001Xh-3J; Sun, 19 Feb 2023 20:40:53 +0000 Received: by outflank-mailman (input) for mailman id 497878; Sun, 19 Feb 2023 20:40:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTqUO-0001Rh-8L for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 20:40:52 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1c0b390-b095-11ed-93b5-47a8fe42b414; Sun, 19 Feb 2023 21:40:50 +0100 (CET) Received: by mail-pj1-x102a.google.com with SMTP id x23so1239195pje.2 for ; Sun, 19 Feb 2023 12:40:50 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 17-20020a170902c21100b00199190b00efsm6372235pll.97.2023.02.19.12.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 12:40:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1c0b390-b095-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lqAwlutC29lMR1tf1e4XOcfdxhypv9zb0T2DcQuJ+3c=; b=XSbexFaS+Tm+Fh9bIb5+7TsH8cXc/OyRJvw9NZqY53ctg5O6XlonIQ+mSxQEFs9syE lUVQj3khdSe3Fc3LpOxcyIdBOEkgeUJK3z40Fm415uv701QNzTtbevYXP5ioH+guMWrP r7f7SjRms7JvKdWdxLsJL7avrtKIOQCRDQ1xE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lqAwlutC29lMR1tf1e4XOcfdxhypv9zb0T2DcQuJ+3c=; b=MX5K0PgC7y0TGYHfc/+X19AjIv2VoJ2Z3ePEHXgSeY5tKXyqd9sSS759qEjUm5L4/N mE21phOSZ6/vUXk3mhq65EEFP1Q2CYrmje+5nfVx0ru2qu1xurZsYCDU7J6yGObdhEBZ Hu4FjLR/9XNTrrvMTBbhNz4ufhR6TvNKIwLAmzJJGYWtuWzYju5P4UPeUr/e4akUsUcW OO+w+D5+7zddGJ9aGjOyW5078P+hBwscYdqHwXdR+UHDYc6hiOTjATmU9KZzBvKqZ84U aNuOo129lj1b/7cP9eKyGIQbOeDauUVpilut9gqzsC/voeK792RS9pBxr/VTskFnLnw9 KjeA== X-Gm-Message-State: AO0yUKU49mDxPJEztcc9fPSefSzrXJodYbTv4YfnQH/LkT0sEB65a46M ic/Lh6t/vdsJM4OPc9UzhvJPGQ== X-Google-Smtp-Source: AK7set8cjnk+CNzhzKm/hjA5DP1TH7rqpGSr8BvS/qmpfvVklVJ20vp+KwvbQWrpg9WzBslEVX8M9Q== X-Received: by 2002:a17:902:d4c8:b0:199:30a6:376c with SMTP id o8-20020a170902d4c800b0019930a6376cmr2895713plg.68.1676839248964; Sun, 19 Feb 2023 12:40:48 -0800 (PST) Message-ID: <63f28950.170a0220.3759b.b525@mx.google.com> X-Google-Original-Message-ID: <202302191240.@keescook> Date: Sun, 19 Feb 2023 12:40:47 -0800 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230218211433.26859-14-rick.p.edgecombe@intel.com> On Sat, Feb 18, 2023 at 01:14:05PM -0800, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these unusual properties is that shadow stack memory is writable, > but only in limited ways. These limits are applied via a specific PTE > bit combination. Nevertheless, the memory is writable, and core mm code > will need to apply the writable permissions in the typical paths that > call pte_mkwrite(). > > In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting > that they are special shadow stack flavor of writable memory. So make > pte_mkwrite() take a VMA, so that the x86 implementation of it can know to > create regular writable memory or shadow stack memory. > > Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). > > No functional change. > > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-alpha@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-csky@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: loongarch@lists.linux.dev > Cc: linux-m68k@lists.linux-m68k.org > Cc: Michal Simek > Cc: Dinh Nguyen > Cc: linux-mips@vger.kernel.org > Cc: openrisc@lists.librecores.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe I'm not an arch maintainer, but it looks like a correct tree-wide refactor. Reviewed-by: Kees Cook -- Kees Cook From xen-devel-bounces@lists.xenproject.org Sun Feb 19 22:36:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 19 Feb 2023 22:36:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497891.768674 (Exim 4.92) (envelope-from ) id 1pTsHg-0006Sd-Gf; Sun, 19 Feb 2023 22:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497891.768674; Sun, 19 Feb 2023 22:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTsHg-0006SW-DN; Sun, 19 Feb 2023 22:35:52 +0000 Received: by outflank-mailman (input) for mailman id 497891; Sun, 19 Feb 2023 22:35:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTsHe-0006SO-P6 for xen-devel@lists.xenproject.org; Sun, 19 Feb 2023 22:35:51 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfe93de1-b0a5-11ed-93b5-47a8fe42b414; Sun, 19 Feb 2023 23:35:47 +0100 (CET) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31JIKx79013592; Sun, 19 Feb 2023 22:34:40 GMT Received: from eur01-he1-obe.outbound.protection.outlook.com (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3ntkv5qvk0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 19 Feb 2023 22:34:40 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6384.eurprd03.prod.outlook.com (2603:10a6:800:193::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Sun, 19 Feb 2023 22:34:36 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6111.018; Sun, 19 Feb 2023 22:34:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfe93de1-b0a5-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MzLtdryCH5c9s0HtHWgwUvptzynmMKnvnSrU0UYZ6i2j33/+b/XQOxfPhC9pT0OyPtWFNfH/ww6XIIY5eZhiEjzKx2lwSC188zu2RjZnzHWNHeYk1Vm9997WSWUUkmPm+1AYNNtrZp7yp4n1RvDHbNLcyMxujcf17Pqk57JwlGnliT2QvxCY1oAPP7IvZsPUGc/yYX9MpoICa1R9wtlgIo91OaLwWuv78nrACLi7thrZ+k7XytuR2u8msCkfEk7q8E1h1leslzzJpoZ8gzh1DQWpNYjREGplH5/e/Aw4eaDwMbsQLaxuJPnWD1r4QvWBOQNtJVgTy+UwmJsRwpUKmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJJTLYqy5XrjbcUncr8iEEgcJMinHUQfO4vbC4nZR24=; b=FzZTAiD1ArOGc2UXz5M7RuAZ3F0vu/etp997MbsTdDUMcizUPoCmShDnAp2mV5vj6Exbw9itoQWspWUPKNkQcoHy0eW4XWEpIeM29v+LlyX0GRWXks8m9g/uEsRlJVCDraahkrYUxvNC3oewEp6pBp9dqQ4I/J4M3dtR2dKglb8noAc6DI5lk3luoHOEgXB6uhqSCmPmQZ2JpzgTkJac5gJcEQk+b5b7MxmtTWMebOnZmLEQKcAfE4zk6Hbb/l3rlxZKNGLGYP5gjtq657144AF8oCJtWb7o9QUcTCdfRZ4SIppLovlb9OxNRPWmW0h/blwc7N8Ibe30ErWAM224YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJJTLYqy5XrjbcUncr8iEEgcJMinHUQfO4vbC4nZR24=; b=lXvREBQkCU3tSQDefff8JJx2ZDQ/IXAd7V/BSubadEvmS8s67SBFjEIJRGoCmnqjmY+l5WAqQnMHxNWQC+zM5sAZOAfo2MTAdvH4JbjZJsGB6qKqNdff7W94VZpP6ivCSLSQQ5mc3bTcOzWIPNEN5iT8lNeGHXb0g0kEb9soaQ2bFnpytmZLdst3eNnREJb30wyA3PmFYNo080eOkFbZnPVlWeqEoWvUsVi/RcWZWxu22ulhDCNJpu9yF63TuEBDOV2ZCCDuGI0uYDW+ugNo2y+87Ei7ArXm6AxvJ1T92EzQG9XOowAGUn0GImQUKWoCDJVoxnR4k/bBj+i5Ymsteg== From: Volodymyr Babchuk To: Jan Beulich CC: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 04/10] xen: add reference counter support Thread-Topic: [RFC PATCH 04/10] xen: add reference counter support Thread-Index: AQHYvUN+XE3jlJIvEkq5uMVpvnNlQq7Q5HaAgAKFNICAAGWNgIAEDL2A Date: Sun, 19 Feb 2023 22:34:35 +0000 Message-ID: <87lekt1dz9.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-5-volodymyr_babchuk@epam.com> <87sff512d2.fsf@epam.com> <0bbbb1c7-bc05-a28e-6573-6bfc5bb0ad28@suse.com> In-Reply-To: <0bbbb1c7-bc05-a28e-6573-6bfc5bb0ad28@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|VI1PR03MB6384:EE_ x-ms-office365-filtering-correlation-id: d882e4c4-1262-4fec-3abe-08db12c97aa4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pur7K7SkUXpmFy3dMwmV8F09+PLNTGktJbwdhrX6KgN/vBcBwpS8gDT4SOGOPDWxXeCA8wsmWtygDj2E1E3jwqhj1eqNVErBDlX+lsIpdq7g3MHEMWnI5GwKLMdpFAi0GsCgV8Vrq4ApwKNU0Eu3RxKFFgo6Af+L7bYTjjqnYU1tv7cmq+l/1+B8E9JY3ZGJ9Jh49QzAkJmMwJbZQiPT/JdY5VmVOvAP96U1Qg8jQL3ycHu/3kf8tNOOyte2f3RmDL5qjbLoiipVNnf61xpILVo7Bs8R08UXYhMG8J3f3AgmC0zgyQHd9I4t6qLhmFAwb9ENZDx5Xn0Y71SSglOfUoZn2ZPpRW+RzW35PoJkBzZ/GbtM03PaLxTvQliSd8kXwQSXrSgJ0GJ2ZVbxD3im1XC1XtBAslR0ciRh6+/LEACXn/4RLXV6P0QuJ+H4XdOPu8vYyFWc+CRurD0ZCs2uSX+YvCyKDujz7hM73ffgDHznUVer0LDuN5O19KSLTGKYwVdlaWd2jB4AoD1lH16+5fB9K87iawuJ3ZTJeTJSbxRfdl8Nd3ILsDDWZsYrGokl4kYelFPVbetIxoWTkHzhKi0+BOnK4jZmnGT/f3cbQVSRBWYj6RUgcqalRagQgg63nxZNMM6aaqjrLakPV+bw76eTQQWR6coC3SD+awTfejIE02YXJFpfC5XgvpDLN7OvfkGjiOAQFYCGIZXHfWGkZg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199018)(83380400001)(64756008)(66446008)(66476007)(66556008)(91956017)(66946007)(76116006)(316002)(8936002)(5660300002)(6916009)(8676002)(2616005)(41300700001)(54906003)(4326008)(53546011)(55236004)(26005)(186003)(478600001)(6486002)(71200400001)(6512007)(6506007)(38070700005)(36756003)(86362001)(2906002)(38100700002)(122000001)(66899018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HuVdZ/HcrSg8vzBHGqYhmyuPdMsN08wepQo7rCmyF8UjNtYlUhELy5aGnb?= =?iso-8859-1?Q?3cr/jmUfJjEWGXc69Hk5WNSlZfeZl4h46Okolv1QOGk0f3aZQV62QhzqA0?= =?iso-8859-1?Q?zQz2qSdaiuRkRn3Pgdj/omY1ULdTFMGw604vTBorylFFgBfIAgVzVobYNv?= =?iso-8859-1?Q?Sva8ovKRmQDq9imgRjR22jY972EPijIq2Pt1R8FwJUWnlZWxYMNNdinxB2?= =?iso-8859-1?Q?B7LkhK8KJkLXSyR2doRDnDKT1z1Jveq2SfmaiVa6hur7qL3wPSeP4PceMM?= =?iso-8859-1?Q?HeEpNa6GUYcvLt/p7vK7hAKAggBKcUUqqpLLhjFpaeYUCq7RUuWXd9m1zW?= =?iso-8859-1?Q?Dkr3AFAzhKfE2QSY80DXgwOiSz174O8ndzFlURo0w0j2ELBi8Cy36V0JCx?= =?iso-8859-1?Q?04dg61NrKUf4Xeop/0gnHFdkYFJQaJbXKtHco5MULPf+ef/YCJSfFk9KCi?= =?iso-8859-1?Q?eC1vH7uaaPndILRK0nnWOWAzgt1UHp1sSTW8i4vrvjxAGRiagx96y0n/up?= =?iso-8859-1?Q?/cLBexgyuZ/E3XfaaXNPO1EdkJaCXt2AgD8qoyGHWjH/Qg7TiPwXxZ/lwq?= =?iso-8859-1?Q?xMuTils2+ZTOGOAceNaMk4SRr1akYYHoVIuMeEPSSsy4CSqmmn1HDMR104?= =?iso-8859-1?Q?d0TY474YMVC133mYgRt46ah/rCb62dWQX81626wUt/zAEwSjqAE6jwWT+8?= =?iso-8859-1?Q?a0oycFXDJVWmnJoVE9IAPWR59ninK4m4KzUP3B/9u74dgWyBP8y1mXP888?= =?iso-8859-1?Q?tMIhanNGrV0xTAWkZ8E+wnVVby7gSCNFPsHssM1EBV+5yb6N3PBk+aKyW2?= =?iso-8859-1?Q?QpPLb2Htx4BhrKpFFYG/C+7QpagqffZ9Iu+P+j2qkpv3w/1k7WLeuHmNTR?= =?iso-8859-1?Q?ssm99uqpglDIh2/rdZEaD4BORDSHxiC1JlCM8KXRNip7agtZQRaHNO/UQl?= =?iso-8859-1?Q?HPjju9JkE35/BJgJvLuTfjM72YAPfeqi15EwHsg+dKh9Scn+WzzYb7iZXa?= =?iso-8859-1?Q?DYkgJ+XAqKwUOwWMeOyhZOyvH7nBQZWhv3XzMtqaeNLm2JS2EV4/WZoIDX?= =?iso-8859-1?Q?8mjh6aglWvFaJJvEg8qLIFQ6WBAZXJjoVaYKQprJ4HyEPQw2oA62EePSWj?= =?iso-8859-1?Q?miJSAUq9qwE3s/5olb3+HkHaixVtsI2djBSZjx8kG6whgrhyhtCgrso/oV?= =?iso-8859-1?Q?wrb9I6+ThSvOK/YSrNvRsNMaANz2VkwaUoNHzN2A6pPTlfRV5J4xnlFCff?= =?iso-8859-1?Q?tSd7+WCq3kimeuqs2WXpmyKFRUmubbR5QuShIKwE27xMfHqdFB5KtvWMt/?= =?iso-8859-1?Q?5bX8b7f+o32TGRFUrypTi3QJL5GnelTbifB+EpREqWe4TyhelLkNxgndfk?= =?iso-8859-1?Q?5abhLeqAm/DnfkCnVHuZVSR6ZcjQa8PnEjVGd38mVUPqR1oaFYPHu8YdfZ?= =?iso-8859-1?Q?cQEitfO/RhMOonGhWIUMxS+2T9hzEV8C6NgwBuhvbsf5EVGvDpZYLCj7Q6?= =?iso-8859-1?Q?041cQ6smT8DUiK/5NWssIT/xN0nIj3O2wDOXo12EZDBMociluaJs0Dp8pw?= =?iso-8859-1?Q?I7PvSp4a//myzOjPIC42K/tdKem5MOOTalKoxImqPY1CpLCrv2q3S7nnxK?= =?iso-8859-1?Q?UPXqUd98OGLAc7cje80Yjg/T90+YZA/9FqDHPD6HcM2NYQfabvR8UmzA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d882e4c4-1262-4fec-3abe-08db12c97aa4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2023 22:34:35.7898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zoCu2B0riJgKADTVoMwPVBBYmnNzRMIRR0glBzObyIyjqxl8sIGRUZIr3b7qabUZ3h1eX6fPaBZCLlI1tbbjmevQCrzQ56kavMZx9pdwuGw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6384 X-Proofpoint-GUID: Bzsnx803eKDnIu7YSN_z49y8StIcPYkB X-Proofpoint-ORIG-GUID: Bzsnx803eKDnIu7YSN_z49y8StIcPYkB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-19_14,2023-02-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302190215 Hi Jan, Jan Beulich writes: > On 17.02.2023 02:56, Volodymyr Babchuk wrote: >> Jan Beulich writes: >>> On 31.08.2022 16:10, Volodymyr Babchuk wrote: >>>> --- /dev/null >>>> +++ b/xen/include/xen/refcnt.h >>>> @@ -0,0 +1,28 @@ >>>> +#ifndef __XEN_REFCNT_H__ >>>> +#define __XEN_REFCNT_H__ >>>> + >>>> +#include >>>> + >>>> +typedef atomic_t refcnt_t; >>> >>> Like Linux has it, I think this would better be a separate struct. At >>> least in debug builds, i.e. it could certainly use typesafe.h if that >>> ended up to be a good fit (which I'm not sure it would, so this is >>> merely a thought). >>=20 >> Sadly, TYPE_SAFE does not support pointers. e.g I can't get pointer to >> an encapsulated value which is also passed as a pointer. I can expand >> TYPE_SAFE with $FOO_x_ptr(): >>=20 >> static inline _type *_name##_x_ptr(_name##_t *n) { &return n->_name;= } >>=20 >> or make custom encapsulation in refcnt.h. Which one you prefer? > > First of all, as said - typesafe.h may not be a good fit. And then the > helper you suggest looks to be UB if the passed in pointer was to an > array rather than a singular object, so having something like that in > a very generic piece of infrastructure is inappropriate anyway. Okay, no problem. I'll use a separate struct. Also, I played a bit with compiler outputs. Looks like there is no additional overhead in reading single value from a struct. So I don't think that we need an additional non-debug implementation for this type. >>>> +static inline void refcnt_init(refcnt_t *refcnt) >>>> +{ >>>> + atomic_set(refcnt, 1); >>>> +} >>>> + >>>> +static inline void refcnt_get(refcnt_t *refcnt) >>>> +{ >>>> +#ifndef NDEBUG >>>> + ASSERT(atomic_add_unless(refcnt, 1, 0) > 0); >>>> +#else >>>> + atomic_add_unless(refcnt, 1, 0); >>>> +#endif >>>> +} >>=20 >>> I think this wants doing without any #ifdef-ary, e.g. >>> >>> static inline void refcnt_get(refcnt_t *refcnt) >>> { >>> int ret =3D atomic_add_unless(refcnt, 1, 0); >>> >>> ASSERT(ret > 0); >>> } >>> >>=20 >> Thanks, did as you suggested. I was afraid that compiler would complain >> about unused ret in non-debug builds. >>=20 >>> I wonder though whether certain callers may not want to instead know >>> whether a refcount was successfully obtained, i.e. whether instead of >>> asserting here you don't want to return a boolean success indicator, >>> which callers then would deal with (either by asserting or by suitably >>> handling the case). See get_page() and page_get_owner_and_reference() >>> for similar behavior we have (and use) already. >>=20 >> For now there are no such callers, so I don't want to implement unused >> functionality. But, if you prefer this way, I'll do this. > > Well, I can see your point about unused functionality. That needs to be > weighed against this being a pretty basic piece of infrastructure, which > may want using elsewhere as well. Such re-use would then better not > trigger touching all the code which already uses it (in principle the > domain ref counting might be able to re-use it, for example, but there's > that DOMAIN_DESTROYED special case which may require it to continue to > have a custom implementation). > > What you may want to do is check Linux'es equivalent. Depending on how > close ours is going to be, using the same naming may also want considerin= g. I wrote my implementation from scratch to avoid any potential licensing issues. But, looking at Linux implementation: There are two abstractions: struct refcount and struct kref. Struct refcount is like atomic_t but with saturation to avoid wrapping. Struct kref is built on top of struct refcount. It is tailored to handle reference counted objects by having ability to call release() function when refcounter reaches zero. Both kref_get() and refcount_inc() functions return void. My implementation has no separation on this two types - ref counter with saturation and kernel object reference counter. My implementation does only latter thing. It is a good idea to add saturation and I will do this in the next patch version. As for details on function prototypes and type names - I'll do as you say. If you want refcnt_put() to return bool - no problem. If you want this functionality renamed or aligned with Linux's one - just tell me. From my point of view, right now we have minimal implementation that covers all available use cases and can be easily expended in the future to cover new use cases. For use cases I can see PCI, cpupool and maybe couple of ARM IOMMU drivers. All others: - get_domain() uses that DOMAIN_DESTROYED special case you mentioned - {get,put}_page* does not use atomic_t all and rely on direct cmpxchg() call for some reason. - OP-TEE code is happy with atomics due to complex logic - {get,put}_cpu_var and put_gfn does not use ref counting at all= From xen-devel-bounces@lists.xenproject.org Mon Feb 20 00:42:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 00:42:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497910.768684 (Exim 4.92) (envelope-from ) id 1pTuFu-0005Nk-9k; Mon, 20 Feb 2023 00:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497910.768684; Mon, 20 Feb 2023 00:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTuFu-0005Nd-7C; Mon, 20 Feb 2023 00:42:10 +0000 Received: by outflank-mailman (input) for mailman id 497910; Mon, 20 Feb 2023 00:42:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTuFs-0005NX-GC for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 00:42:09 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6434a12c-b0b7-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 01:42:04 +0100 (CET) Received: from pps.filterd (m0174683.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 31J505nY014692; Mon, 20 Feb 2023 00:41:50 GMT Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3ntppmqgyq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 00:41:49 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by PAXPR03MB8276.eurprd03.prod.outlook.com (2603:10a6:102:23f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Mon, 20 Feb 2023 00:41:46 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6111.018; Mon, 20 Feb 2023 00:41:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6434a12c-b0b7-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MVjh/qpFqJTahQpIxXgqgSrZqraK63YVC7FaCr3aa/dq/xVtMjkLq/EJlAXHty3ksYOLYk7iL9Tsgwr8HLmBrucNbIDqyyw+Gp2a5rZtaXq0IKr1uhRcKg908SIhAEybhSZeRzhcNr556D1SIMqvku1uJgGayfpLI9BY/byQGX5IkLc/71aSciLbm+2qwbgIeEJu95T7YR8JLiyJjXyerXaGyBjEuoN5s74wBeNYMbpaOWqukRdX9cgzn2BDrtQkBAhRzFvJ7upU2xjvdFFTPkPsjy/vauVD/9d1kRqaMpeLjIW2CBiDYrlltMppn7+ZMrJC8shHHMbm4l9WHWq9lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bm/x4gMFk9mespj5XNY7cCddxNQ9zxoscHnKGXOrl2I=; b=DqBZXuuw9X6Oj7oZI/48qlJgPsyvG/L4UReX+QdCdaPu2GSQW2MHmu4hO6dcAU2Fnpr/PkHIzig/12H6PQyUAWNq2iyQWMy42E70LXQqrUvJ+iO3IT5O5u5gxQzM3vycuRllaRSZBOyKJn3gpMg65V4Ry84Cr9TyG+E+DgW5TLC4RH9GtWj0pRyK3GE6S2JEjRWhXhnSpx/cF1XUGh/Dz78juwWRHW1b6+/OwbG8pAs/C9RVgQSVK/D3B4t1Haq9B6xt65xMC/e7CcVl4zAd4K/p2mH+UrBv5i+ao3jwsJKGM4ZAqjIAkT6ZciMwy1NoCJPgLI1LM35+IXunPM7Oqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bm/x4gMFk9mespj5XNY7cCddxNQ9zxoscHnKGXOrl2I=; b=IyCErNKC6x6JhYk6jlyivkIV7BzYOwMcexoZk80V0gLShiaizqfoFR1i5ZiEmYdEK51EnMhMCTh1K96OV92wfhOdpjvUI+hC4PZn9w+dpjkRbbv4fptYAlcLeiZW/l5m5QEiyqP86k4ZNtNsi4MV05xmWzYb59SZuSY7pVFflNqiA9Renn6EAuho29aeJ38EInTkhIX4uL2aU7eVB31n14J7ltnl1xdlgdczpKLLFZwExpqtl1r4B+/yI7a10rHXyC36N6vM81DG8YKkrRnUWimcEEDxlycqLFhDwJaYSY+1RfWBNVpIgo/eMZNps1Tl41mACq0OX+vlaDBeVnCRzg== From: Volodymyr Babchuk To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Kevin Tian , Jan Beulich , Paul Durrant , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [RFC PATCH 09/10] [RFC only] xen: iommu: remove last pcidevs_lock() calls in iommu Thread-Topic: [RFC PATCH 09/10] [RFC only] xen: iommu: remove last pcidevs_lock() calls in iommu Thread-Index: AQHYvUOAlPa0wkGiakOWSGDBM2amAa6z93GAgCQS54A= Date: Mon, 20 Feb 2023 00:41:46 +0000 Message-ID: <87edql183b.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-10-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|PAXPR03MB8276:EE_ x-ms-office365-filtering-correlation-id: 3b54ce26-d1ee-450f-2b19-08db12db3ea2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /H1dKnp/4P8KwVb9U3MIwmz8YuzzpAy1Yr44/ri9l5jztDJaH/aHPH1SJzodqX2hZHyWLawPebPG5frN1DSqDhLHq3gmQqtyoj0Dsc6jZm/xICay+WzXTOKas2UQnz6qsPa+y7nj/lEuYK9qCbAgxPR3uaywEg2/UznbdWJIy6zTsY8XaD3/6tYaxF8uqL4wDv5x9Zxmx/A3NIzURIz8Hy+g3XzOCaQ78mtMWow//rod8bnRWMfw1F2elSwKS1AvDprcJsZULQkZIgZsf01wNmGYxH839RYYMQF7r1kNJ666QfY1+6I8sf2yZm9SdwceoUsrdT2pR1Bn6qauCY5gTGoPD5oUarYY+XpurndVNXmfShNO0PWKSLuK6N+mAnHrEfXaAnqoClUBTTTKtLieOrZCN7OUGvRU52HLVS1Rtc8rF57IXc5XnAA7JH70IwaOmbQxmdsX4nfcc1/8hbTYZd/8XOnOkUC+ilmLscFXtIskLLkmUv5VjTv8N4ebODutQFfPGJDusUMgw5asJvbB3xCvTiU//7IaHxgJqGmorfxdSXD4gn3+01HxcbiJxgntUpib4CRVuJqeeb8/R1vKZBLSrP3ZDipaWx793JpsNdR3MVAkdbksJ6EJQnrq5cJ5dvDB30Rs4Ug5KUQ9eBv3SQ5e2Cm+lq1VgBnL+VJNOHKVUYHLmrTENZ3HKeF54wf3oXawmG21L1RY/T+v4QlPlw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(451199018)(41300700001)(2906002)(38070700005)(6506007)(36756003)(4326008)(5660300002)(8936002)(316002)(55236004)(91956017)(6916009)(86362001)(54906003)(66556008)(6486002)(64756008)(478600001)(71200400001)(76116006)(66476007)(66946007)(8676002)(66446008)(122000001)(38100700002)(186003)(26005)(6512007)(2616005)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?fYt4tnP+koUKtli7oilb2HhpEZs9GTTQF62pNf8+T29KrxphpMnIs7Cjsf?= =?iso-8859-1?Q?1yM8i+r05RmZoGU5xn9Ytxr2R3vjesz5Odzos2wyNmKtJvVBrwORiIlhsh?= =?iso-8859-1?Q?urCKku4dWwkQBSj881DWNCnOE+WmvWd8NxwmGSh37kFXaOHynSumKsbgoT?= =?iso-8859-1?Q?Xpnb3Xjfat23JFRA4xx61LdmCRMWqIF9Wfz9ZPeMkbFhH9WisrEbB2G/HZ?= =?iso-8859-1?Q?yb6FX8iAztiVFZ4Jjn64e4F8HpEmPf1j99fSpRIfHGhWu9Fby2pPbnXiV+?= =?iso-8859-1?Q?Fh9GPzMKvnNAHWpZDOJxoYiMmJhMK3Ca/excxnRp6ZOfOs9lMHQ9F5jlea?= =?iso-8859-1?Q?rlAvvoc+Cz3+Bo9pfz2ej8zZNnH9CdMazXT8Ej4vH61m05TsFMeDynhH4O?= =?iso-8859-1?Q?fMjBTZdbUkG74lmINFb4PFrOD4S9zy+48QqrUnM7OmqndRrdcp5vR9bMNE?= =?iso-8859-1?Q?DDDs5XMejG9/2swHy/cfYn6D0hvNtZXeAwqQIUwFpsYUNSIyer0pYk7nEF?= =?iso-8859-1?Q?5t7S7TJFoxmV2ajOvRd697HOLNBuVc+HT0aUP8hCV+q/DnsPr1NcK4lo4S?= =?iso-8859-1?Q?z7pavBAhoiUkCDoZdxIw5SiL1xD/7F7jZxRHj7zTr2vLLCKss01Sx4qU42?= =?iso-8859-1?Q?0B5J/GdgIFs6rcpg51IJ6klKF0TSOYikI7PGVIbNs+io2j/93BXhr9DhRG?= =?iso-8859-1?Q?ttegQZZG8SLz+ZVvayA+mgWxy0GjVbh7x1CVG7H11YMqWiBRU+YYYMZyOT?= =?iso-8859-1?Q?vBksRYhGmvncvk6pWvpoF5XX3Avp/EOJPWd2VDeW6dxhXUezvQPhH1NuQ5?= =?iso-8859-1?Q?c9LmCCfpkguIm7MqqQnQnn9gziSAEksP4EKyzejxSKkWgYw3EA0H5owbPO?= =?iso-8859-1?Q?aUHl+2aomt13UgWF1sH8isYMaHbpxd9Ono7NxvJMilcYVz85jht2PNv8KE?= =?iso-8859-1?Q?moO5zjpmPS1Z+lLRJkJBknUUEPp/CThTI6XKJFnUtUZQSOjTxO4ZS+qkec?= =?iso-8859-1?Q?tcxRFukp/YIXvNm0D1fbRw9Tly61Ec/cY01LbmlVQtMhDBclp2xn9tKWLl?= =?iso-8859-1?Q?ss1EIDmFUlMeuSCzhErbNLolabr44/P8/YaM5lIuJztQvN2z+1chmlY7pd?= =?iso-8859-1?Q?LoJ0Yb1Jc8JGWdUNxzyFqVK6dlHQemHOIyEnnqMZ0bcFq3EpHK7l/O5uEq?= =?iso-8859-1?Q?OIEHZbgMUCqsOXR3NMA6CPpUUodLQGa+4MSUkzcA76N8e3/Bz7Sprm719/?= =?iso-8859-1?Q?JB3y387hRwa25pvfcQkkjS/XcxtehAl3MOTLJCMt1fctZJdf4DWG+O8Zmx?= =?iso-8859-1?Q?Ljo4eo1IdU1rg0k7djHkGEaUES30A7tG1wTVuYLKcw/B8KRLZygZPWVaik?= =?iso-8859-1?Q?oc3N63A0fGSrC6bzg2A5954BNP/JscHUxpjE3/zgl8Vo5XUCes4BeC8NmV?= =?iso-8859-1?Q?lV8m0MJfUk9L7FpucyDhUmcWzevapohEGqmG2yCmh9MfX++rNCU/gdoECK?= =?iso-8859-1?Q?sb9XO8y3Td0bwGHYSDlv1biQ3lKwXFma6zh6OaROaluP2Oc8aFkhAXvevz?= =?iso-8859-1?Q?KHqvdlUanecjIRh8uFXbmE1IHk609aPBdWy93rVmMtWKRmVsQdP0GfrIDK?= =?iso-8859-1?Q?i+DzmkQOYD2oPbOYa4UkxaIRFmy73uxTORg7R4ExzmZ6jK3Y7m4UXkEw?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b54ce26-d1ee-450f-2b19-08db12db3ea2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 00:41:46.0541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pB7zQLE6g2ObiVMhQYc7oI+y5NxAA7umRaMjd9FlaqCOKyPPlVniN5wuRtoxxSZUFRf1jaSqAT8OxyVlVGIDA+Eblv8s5MurUfOjuzf433o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8276 X-Proofpoint-ORIG-GUID: 3CBTkM29f9pi-DIAanTOl-sfzVnavuRR X-Proofpoint-GUID: 3CBTkM29f9pi-DIAanTOl-sfzVnavuRR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-19_15,2023-02-17_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200004 Hi Stefano, Stefano Stabellini writes: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> There are number of cases where pcidevs_lock() is used to protect >> something that is not related to PCI devices per se. >>=20 >> Probably pcidev_lock in these places should be replaced with some >> other lock. >>=20 >> This patch is not intended to be merged and is present only to discuss >> this use of pcidevs_lock() >>=20 >> Signed-off-by: Volodymyr Babchuk > > I wonder if we are being too ambitious: is it necessary to get rid of > pcidevs_lock completely, without replacing all its occurrences with > something else? > > Because it would be a lot easier to only replace pcidevs_lock with > pdev->lock, replacing the global lock with a per-device lock. That alone > would be a major improvement and would be far easier to verify its > correctness. This is the aim of this patch series. We can't just replace pcidevs_lock with pdev->lock, because pcidevs_lock() locks not only PCI devices, but a PCI subsystem as a whole. As I wrote on the cover letter, I identified list of things that pcidevs_lock protect and tried to create separate locks for them. > > While this patch and the previous patch together remove all occurrences > of pcidevs_lock without adding pdev->lock, which is difficult to prove > correct. Previous patch removes occurrences of pcidevs_lock() in places which are already protected with new locks. Sometimes, this is d->pdevs_lock, sometimes it is sufficient to call pcidev_get() to increase refcounter, in other cases we need to call pdev_lock(pdev), ... And goal of this patch is to discuss pieces which left. As you can see, there is no pointer to pdev to lock, this code does not traverse d->pdev_list, etc. So it is not immediately obvious what exactly those ASSERTs should protect. Maybe, they were added by mistake and are not needed, actually. Maybe I missing some nuance of x86 IOMMU workings. I really need maintainer's advice there. > > >> --- >> xen/drivers/passthrough/vtd/intremap.c | 2 -- >> xen/drivers/passthrough/vtd/iommu.c | 5 ----- >> xen/drivers/passthrough/x86/iommu.c | 5 ----- >> 3 files changed, 12 deletions(-) >>=20 >> diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passth= rough/vtd/intremap.c >> index 1512e4866b..44e3b72f91 100644 >> --- a/xen/drivers/passthrough/vtd/intremap.c >> +++ b/xen/drivers/passthrough/vtd/intremap.c >> @@ -893,8 +893,6 @@ int pi_update_irte(const struct pi_desc *pi_desc, co= nst struct pirq *pirq, >> =20 >> spin_unlock_irq(&desc->lock); >> =20 >> - ASSERT(pcidevs_locked()); >> - >> return msi_msg_write_remap_rte(msi_desc, &msi_desc->msg); >> =20 >> unlock_out: >> diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrou= gh/vtd/iommu.c >> index 87868188b7..9d258d154d 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -127,8 +127,6 @@ static int context_set_domain_id(struct context_entr= y *context, >> { >> unsigned int i; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( domid_mapping(iommu) ) >> { >> unsigned int nr_dom =3D cap_ndoms(iommu->cap); >> @@ -1882,7 +1880,6 @@ int domain_context_unmap_one( >> int iommu_domid, rc, ret; >> bool_t flush_dev_iotlb; >> =20 >> - ASSERT(pcidevs_locked()); >> spin_lock(&iommu->lock); >> =20 >> maddr =3D bus_to_context_maddr(iommu, bus); >> @@ -2601,7 +2598,6 @@ static void __hwdom_init setup_hwdom_rmrr(struct d= omain *d) >> u16 bdf; >> int ret, i; >> =20 >> - pcidevs_lock(); >> for_each_rmrr_device ( rmrr, bdf, i ) >> { >> /* >> @@ -2616,7 +2612,6 @@ static void __hwdom_init setup_hwdom_rmrr(struct d= omain *d) >> dprintk(XENLOG_ERR VTDPREFIX, >> "IOMMU: mapping reserved region failed\n"); >> } >> - pcidevs_unlock(); >> } >> =20 >> static struct iommu_state { >> diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrou= gh/x86/iommu.c >> index f671b0f2bb..4e94ad15df 100644 >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -207,7 +207,6 @@ int iommu_identity_mapping(struct domain *d, p2m_acc= ess_t p2ma, >> struct identity_map *map; >> struct domain_iommu *hd =3D dom_iommu(d); >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(base < end); >> =20 >> /* >> @@ -479,8 +478,6 @@ domid_t iommu_alloc_domid(unsigned long *map) >> static unsigned int start; >> unsigned int idx =3D find_next_zero_bit(map, UINT16_MAX - DOMID_MAS= K, start); >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( idx >=3D UINT16_MAX - DOMID_MASK ) >> idx =3D find_first_zero_bit(map, UINT16_MAX - DOMID_MASK); >> if ( idx >=3D UINT16_MAX - DOMID_MASK ) >> @@ -495,8 +492,6 @@ domid_t iommu_alloc_domid(unsigned long *map) >> =20 >> void iommu_free_domid(domid_t domid, unsigned long *map) >> { >> - ASSERT(pcidevs_locked()); >> - >> if ( domid =3D=3D DOMID_INVALID ) >> return; >> =20 >> --=20 >> 2.36.1 >>=20 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 01:01:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 01:01:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497918.768697 (Exim 4.92) (envelope-from ) id 1pTuYM-0002mL-Td; Mon, 20 Feb 2023 01:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497918.768697; Mon, 20 Feb 2023 01:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTuYM-0002lV-OX; Mon, 20 Feb 2023 01:01:14 +0000 Received: by outflank-mailman (input) for mailman id 497918; Mon, 20 Feb 2023 01:01:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTuYK-0001lb-RX for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 01:01:14 +0000 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0850e58e-b0ba-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 02:01:00 +0100 (CET) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PKkcZ5RDfz4x81; Mon, 20 Feb 2023 12:00:46 +1100 (AEDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0850e58e-b0ba-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1676854853; bh=F/BA55hncJJcUXKiAlKImZaWKF9J7v8lLnKr9dq21p4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XslnKyUEjBPQ1U1pxlZfaOackH5Uc53v2LGKi4H/fZCzwS12mRxSKUo5Y0d1NKeZn awyroz/jmv/ppUpYp1TDhtbm3Xr2UbxbQ7SLm7HpIZR367un5O+1m6RO8MFNGLc4tN bOsgsJ/QSRuN9qLOaQNEAnGHLCgJYRh2AmA+hh1/q0GxiYmMbgWuXckkgvhyXESi3z pkyDk+R2FxF/Bbq8WxwITYwB8LWISeRkdVED0wYKG14B7OppQx/VBH6ejWIfX4nrhf +DPFJJxnIwj6xY4eD5/CyK6ZQt6qJeWIa8XOq0dKk/I3y+LAhnFdM5gYPtu4P26I4l sm8Hu7By7kuYg== From: Michael Ellerman To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA In-Reply-To: <20230218211433.26859-14-rick.p.edgecombe@intel.com> References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> Date: Mon, 20 Feb 2023 12:00:46 +1100 Message-ID: <875ybxywu9.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rick Edgecombe writes: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. ... > --- > Hi Non-x86 Arch=E2=80=99s, > > x86 has a feature that allows for the creation of a special type of > writable memory (shadow stack) that is only writable in limited specific > ways. Previously, changes were proposed to core MM code to teach it to > decide when to create normally writable memory or the special shadow stack > writable memory, but David Hildenbrand suggested[0] to change > pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be > moved into x86 code. > > Since pXX_mkwrite() is defined in every arch, it requires some tree-wide > changes. So that is why you are seeing some patches out of a big x86 > series pop up in your arch mailing list. There is no functional change. > After this refactor, the shadow stack series goes on to use the arch > helpers to push shadow stack memory details inside arch/x86. ... > --- > Documentation/mm/arch_pgtable_helpers.rst | 9 ++++++--- > arch/alpha/include/asm/pgtable.h | 6 +++++- > arch/arc/include/asm/hugepage.h | 2 +- > arch/arc/include/asm/pgtable-bits-arcv2.h | 7 ++++++- > arch/arm/include/asm/pgtable-3level.h | 7 ++++++- > arch/arm/include/asm/pgtable.h | 2 +- > arch/arm64/include/asm/pgtable.h | 4 ++-- > arch/csky/include/asm/pgtable.h | 2 +- > arch/hexagon/include/asm/pgtable.h | 2 +- > arch/ia64/include/asm/pgtable.h | 2 +- > arch/loongarch/include/asm/pgtable.h | 4 ++-- > arch/m68k/include/asm/mcf_pgtable.h | 2 +- > arch/m68k/include/asm/motorola_pgtable.h | 6 +++++- > arch/m68k/include/asm/sun3_pgtable.h | 6 +++++- > arch/microblaze/include/asm/pgtable.h | 2 +- > arch/mips/include/asm/pgtable.h | 6 +++--- > arch/nios2/include/asm/pgtable.h | 2 +- > arch/openrisc/include/asm/pgtable.h | 2 +- > arch/parisc/include/asm/pgtable.h | 6 +++++- > arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- > arch/powerpc/include/asm/book3s/64/pgtable.h | 4 ++-- > arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- > arch/powerpc/include/asm/nohash/32/pte-8xx.h | 2 +- > arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- Looks like you discovered the joys of ppc's at-least 5 different MMU implementations, sorry :) Acked-by: Michael Ellerman (powerpc) cheers From xen-devel-bounces@lists.xenproject.org Mon Feb 20 04:15:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 04:15:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497935.768723 (Exim 4.92) (envelope-from ) id 1pTxZn-0003za-Vz; Mon, 20 Feb 2023 04:14:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497935.768723; Mon, 20 Feb 2023 04:14:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTxZn-0003zS-RI; Mon, 20 Feb 2023 04:14:55 +0000 Received: by outflank-mailman (input) for mailman id 497935; Mon, 20 Feb 2023 04:14:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTxZl-0003zH-Om; Mon, 20 Feb 2023 04:14:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTxZl-0003Zr-ND; Mon, 20 Feb 2023 04:14:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTxZl-000563-BR; Mon, 20 Feb 2023 04:14:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pTxZl-0004Uy-Ay; Mon, 20 Feb 2023 04:14:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ra3nhu9gvuPzZEGKGzzUyxZRfliSOfx3NAT5FLWYmFs=; b=5CL6uc+u5oXuZiWGhdt8KH/DGm lU/04uKNDV/ol/5Eb2msf76Qwz13NMMFKLcYl+daoGlnrfz7qYZKSMOMxhcrOP9aNtwbK4YgiJ94G VCzetw52addwR+0C6eyC0leI05YvwNXUGdxh7L7rI5n50OmOCzZuzoj40Hs9DnhuCQOg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177852: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac X-Osstest-Versions-That: xen=e2312e41f05c0f2e3b714710bd2551a3cd74cedd From: osstest service owner Date: Mon, 20 Feb 2023 04:14:53 +0000 flight 177852 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177852/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177707 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 177770 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 177770 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177770 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177770 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177770 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177770 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177770 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177770 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177770 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177770 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac baseline version: xen e2312e41f05c0f2e3b714710bd2551a3cd74cedd Last test of basis 177770 2023-02-19 01:54:11 Z 1 days Testing same since 177852 2023-02-19 21:08:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap George Dunlap Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e2312e41f0..406cea1970 406cea1970535cd7b9d6bcf09bc164ef9bb64bac -> master From xen-devel-bounces@lists.xenproject.org Mon Feb 20 06:14:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 06:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497947.768734 (Exim 4.92) (envelope-from ) id 1pTzR5-0001YN-LB; Mon, 20 Feb 2023 06:14:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497947.768734; Mon, 20 Feb 2023 06:14:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTzR5-0001YG-I7; Mon, 20 Feb 2023 06:14:03 +0000 Received: by outflank-mailman (input) for mailman id 497947; Mon, 20 Feb 2023 06:14:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pTzR3-0001YA-Lk for xen-devel@lists.xen.org; Mon, 20 Feb 2023 06:14:01 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c23f34dc-b0e5-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 07:13:58 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C00155BD7F; Mon, 20 Feb 2023 06:13:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B0EF139DB; Mon, 20 Feb 2023 06:13:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r4y4G6QP82NAKwAAMHmgww (envelope-from ); Mon, 20 Feb 2023 06:13:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c23f34dc-b0e5-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676873636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xkMgfOTP9yBloM5dxz1wd1szOdeiuzALKlIV98yQwHc=; b=jBrf6JHPSFjXCU9DUNW8NdNZLhDx2z932ySAqAaL0Y9uJzU65ftNlg/s7CnFU0krvRIHSi kXE5QR/p2HUrkqbKhrWiYOjjt2cRM6UvnnbZKiM2JKgAgSFseW/ZYlcGenOJcQk9y1cv4T D9Y4wqGaaV/aXXy9VCSHaoXCRdbFWGg= Message-ID: Date: Mon, 20 Feb 2023 07:13:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Oleksandr Tyshchenko , Viresh Kumar Cc: Andrew Cooper , Stratos Mailing List , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org References: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> From: Juergen Gross Subject: Re: [Discussion] Xen grants and access permissions In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------fMz21R42LAA62UadcKYtrAah" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------fMz21R42LAA62UadcKYtrAah Content-Type: multipart/mixed; boundary="------------RESWvexSu3UmUpJ9nSGqwgrf"; protected-headers="v1" From: Juergen Gross To: Oleksandr Tyshchenko , Viresh Kumar Cc: Andrew Cooper , Stratos Mailing List , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org Message-ID: Subject: Re: [Discussion] Xen grants and access permissions References: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> In-Reply-To: --------------RESWvexSu3UmUpJ9nSGqwgrf Content-Type: multipart/mixed; boundary="------------3Gy1iyF38CUoAEuuIs9Qkisz" --------------3Gy1iyF38CUoAEuuIs9Qkisz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTkuMDIuMjMgMTc6NDQsIE9sZWtzYW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPiBIZWxs byBWaXJlc2guDQo+IA0KPiBbQ0NlZCBKw7xyZ2VuIHdobyBtaWdodCBoYXZlIHNvbWUgdGhv dWdodHNdDQo+IFtTb3JyeSBmb3IgdGhlIHBvc3NpYmxlIGZvcm1hdCBpc3N1ZXNdDQo+IA0K PiBPbiBUaHUsIEZlYiAxNiwgMjAyMyBhdCAxOjM2IFBNIEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20gDQo+IDxtYWlsdG86YW5kcmV3LmNvb3BlcjNAY2l0cml4 LmNvbT4+IHdyb3RlOg0KPiANCj4gICAgIE9uIDE2LzAyLzIwMjMgMTE6MTMgYW0sIFZpcmVz aCBLdW1hciB3cm90ZToNCj4gICAgICA+IEhpIE9sZWtzYW5kciwNCj4gICAgICA+DQo+ICAg ICAgPiBBcyB5b3UgYWxyZWFkeSBrbm93LCBJIGFtIGxvb2tpbmcgYXQgaG93IHdlIGNhbiBp bnRlZ3JhdGUgdGhlIFhlbg0KPiAgICAgID4gZ3JhbnRzIHdvcmsgaW4gb3VyIGltcGxlbWVu dGF0aW9uIG9mIFJ1c3QgYmFzZWQgWGVuIHZob3N0IGZyb250ZW5kIFsxXS4NCj4gICAgICA+ DQo+ICAgICAgPiBUaGUgaHlwZXJ2aXNvciBpbmRlcGVuZGVudCB2aG9zdC11c2VyIGJhY2tl bmRzIFsyXSB0YWxrIHRvDQo+ICAgICAgPiB4ZW4tdmhvc3QtZnJvbnRlbmQgdXNpbmcgdGhl IHN0YW5kYXJkIHZob3N0LXVzZXIgcHJvdG9jb2wgWzNdLiBFdmVyeQ0KPiAgICAgID4gbWVt b3J5IHJlZ2lvbiB0aGF0IHRoZSBiYWNrZW5kcyBnZXQgYWNjZXNzIHRvIGFyZSBzZW50IHRv IGl0IGJ5IHRoZQ0KPiAgICAgID4gZnJvbnRlbmQgYXMgbWVtb3J5IHJlZ2lvbiBkZXNjcmlw dG9ycywgd2hpY2ggY29udGFpbiBvbmx5IGFkZHJlc3MgYW5kDQo+ICAgICAgPiBzaXplIGlu Zm9ybWF0aW9uIGFuZCBsYWNrIGFueSBwZXJtaXNzaW9uIGZsYWdzLg0KDQpUaGVyZSBhcmUg bm8gcGVybWlzc2lvbiBmbGFncyBpbiBYZW4gUFYgZGV2aWNlIHByb3RvY29scyBlaXRoZXIu IFRoZSBraW5kIG9mIGENCm1hcHBpbmcgKFJPIG9yIFJXKSBpbiB0aGUgYmFja2VuZCBpcyBz ZWxlY3RlZCB2aWEgdGhlIEkvTyBvcGVyYXRpb246IGluIGNhc2UgaXQNCmlzIGEgd3JpdGUg dHlwZSBvcGVyYXRpb24gKGd1ZXN0IHdyaXRpbmcgZGF0YSB0byBhIGRldmljZSksIHRoZSBy ZWxhdGVkIGdyYW50cw0KYXJlIG1hcHBlciBhcyBSTyBpbiB0aGUgYmFja2VuZCwgaW4gYWxs IG90aGVyIGNhc2VzIHRoZXkgYXJlIG1hcHBlZCBhcyBSVy4NCg0KVGhlIHNhbWUgYXBwbGll cyB0byBncmFudGVkIHBhZ2VzIGZvciB2aXJ0aW86IHRoZSBmcm9udGVuZCBzaWRlIHdpbGwg Z3JhbnQgdGhlDQpwYWdlIGFzIFJPIGluIGNhc2UgdGhlIEkvTyBvcGVyYXRpb24gaXMgZmxh Z2dlZCBhcyAiRE1BX1RPX0RFVklDRSIsIGFuZCBhcyBSVw0KaW4gYWxsIG90aGVyIGNhc2Vz LiBUaGUgYmFja2VuZCBzaG91bGQgYWx3YXlzIGtub3csIHdoaWNoIGRpcmVjdGlvbiB0aGUg ZGF0YSBpcw0KZmxvd2luZywgc28gaXQgc2hvdWxkIGJlIGFibGUgdG8gZG8gdGhlIG1hcHBp bmcgd2l0aCB0aGUgY29ycmVjdCBhY2Nlc3MgbW9kZS4NCg0KDQpKdWVyZ2VuDQo= --------------3Gy1iyF38CUoAEuuIs9Qkisz Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------3Gy1iyF38CUoAEuuIs9Qkisz-- --------------RESWvexSu3UmUpJ9nSGqwgrf-- --------------fMz21R42LAA62UadcKYtrAah Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzD6QFAwAAAAAACgkQsN6d1ii/Ey/8 TQf+PNnXoQMtjxI+2nexCsiEfSLrjCX4B++4uq/3UsuUSMipeR3CcPyP6P4LZfmSpMLXHmqP6Khx 2tCWh717BLFgjWiqcOlhOQz78IZU7bmUMIaU2nxERq680EL/PFUsllkRQSKisg+Zf3xPkH8bjgn/ rYKIrhOUR8qZZ/zt7G3b1PlWpjcETLvfZrePOq65YUVwJg4D1a+2E1DAq92UYg2M+blzSlzYtMqa ryP2secwWcWvdClINZOQI7oGj/SkoEjWcAWLuoRHnP1fUfZWtHvLMhNhmYrtH0pQ+1oGiB/wAlHT k/zCZqaVKxa6m7YmsqzoCygRWwvKmej33aUZibihRQ== =XcWA -----END PGP SIGNATURE----- --------------fMz21R42LAA62UadcKYtrAah-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 07:41:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 07:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497956.768745 (Exim 4.92) (envelope-from ) id 1pU0nQ-0004WQ-RK; Mon, 20 Feb 2023 07:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497956.768745; Mon, 20 Feb 2023 07:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU0nQ-0004WJ-NL; Mon, 20 Feb 2023 07:41:12 +0000 Received: by outflank-mailman (input) for mailman id 497956; Mon, 20 Feb 2023 07:41:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU0nP-0004W9-Gd; Mon, 20 Feb 2023 07:41:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU0nP-0000Zz-Cq; Mon, 20 Feb 2023 07:41:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU0nP-0005Rw-0X; Mon, 20 Feb 2023 07:41:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pU0nP-0001uo-01; Mon, 20 Feb 2023 07:41:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nHZvpnQ+jMVAINe+1KQy2HvH+0QoafzhrX9PZt9mNWY=; b=kLlruY2X2UQBPe5s7MCW5zXVV/ QvH1ei1C0jujDtVhZnZADd47eO9AjfCmHBXiHrA6m6kTUFQr7TboWFwBNrL1qNG9jAZkJd/ksmaYe +Mz/xFIdvyq8OY4sOw4IGQ9SEYpy3sitXgQDx3emIZ2Dg/UOLP6F6LUfOU4PBMoP/CYg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177860: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-rtds:guest-saverestore.2:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=c9c3395d5e3dcc6daee66c6908354d47bf98cb0c X-Osstest-Versions-That: linux=925cf0457d7e62ce08878ffb789189ac08ca8677 From: osstest service owner Date: Mon, 20 Feb 2023 07:41:11 +0000 flight 177860 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177860/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 19 guest-saverestore.2 fail REGR. vs. 177784 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177784 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177784 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177784 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177784 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177784 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux c9c3395d5e3dcc6daee66c6908354d47bf98cb0c baseline version: linux 925cf0457d7e62ce08878ffb789189ac08ca8677 Last test of basis 177784 2023-02-19 04:47:09 Z 1 days Testing same since 177860 2023-02-19 22:42:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 925cf0457d7e..c9c3395d5e3d c9c3395d5e3dcc6daee66c6908354d47bf98cb0c -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Feb 20 09:27:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 09:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497990.768755 (Exim 4.92) (envelope-from ) id 1pU2S1-00009Y-2C; Mon, 20 Feb 2023 09:27:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497990.768755; Mon, 20 Feb 2023 09:27:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU2S0-00008i-Vq; Mon, 20 Feb 2023 09:27:12 +0000 Received: by outflank-mailman (input) for mailman id 497990; Mon, 20 Feb 2023 09:27:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU2Rz-00008c-L8 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 09:27:11 +0000 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [2a00:1450:4864:20::32d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bff641ec-b100-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 10:27:10 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id m14-20020a7bce0e000000b003e00c739ce4so334987wmc.5 for ; Mon, 20 Feb 2023 01:27:09 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id u7-20020a05600c19c700b003e21f20b646sm444874wmq.21.2023.02.20.01.27.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Feb 2023 01:27:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bff641ec-b100-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KRDbs92uM4wmUdpecuxlJKfatamZgZMyKqKMjmX0LIw=; b=jPvZIkZcJ8gdAWV6qG3DbOFkszZjapiPscRaT92GuJHw+ovKDvG9kUyHKo9D2MHTVV raiVn4M2EwZ2B4NjUqG1ZuCY9iLC0ihJeicw/1HJAz+CbXzvYRNVL5l+kydqQMUc2Ake Xe9XLnI536EEZgsdSJ8Mr0obkQSJWVZaSibCgGaicnYAd5VzuQYaL8/OsCEFwEZ5zJo8 ki31tNEq+MHoKOEfajMsI4lhEkYyhEc0r60lGAMjzpE5se8h1ZYyKTtAaR//uwUtyd9I jrMtEdMeA961uwHmvrl/kNvxu6bxLwQUeHlu0VzUppBQNsnTyKzV93PjayPXDsuVNO7y aQPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KRDbs92uM4wmUdpecuxlJKfatamZgZMyKqKMjmX0LIw=; b=v6lBAhwzPj5SlIMp/uRyyN823qFtcQea6eHMWL+0T7J8/fAqlDIq4JW/23ED9jjE/x prcD/DMEOPZmhjTrXtzW3EorUd/8O5UfBERKZbJRtt9rc/c8cauRwLDryv2B6QVCUcOo HA+Rc6rPxWUQApjd4svpekJavcocnW1BofVgkdRXexs8WzjQy6YDJxkTGtmJMpNAsPep 12tKlXCnbMYDLPGJrm7SZi1sJYFiWp6E0FxV7u5OfQlnRZ+Q7S2Lj8tihnKMvNFWu5Sd WgnyKWwvZPiTKbwZYgSRmWentwYrV2LUiVpWBqcBTOz6yFfmmAFNfJ/LnzF5qdzwoG8v XTVA== X-Gm-Message-State: AO0yUKWI9BhVUhY4trairWDvrcuxbMWIWtPR5WkfeDNq7qmRhteeESk4 1P8n+BAbSW13bl0y7Ca7wD6NyA== X-Google-Smtp-Source: AK7set8pl9Ml+zJvhVflawVpr8e/yIoq8lc6l2m+q97iXgNCuiYJuKy8Rs0FokEMSm/SgpQt4ZrBew== X-Received: by 2002:a05:600c:198e:b0:3e2:1f00:bff7 with SMTP id t14-20020a05600c198e00b003e21f00bff7mr325096wmq.12.1676885229384; Mon, 20 Feb 2023 01:27:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum Subject: [PATCH] hw/i386/xen: Remove unused 'hw/ide.h' include from header Date: Mon, 20 Feb 2023 10:27:07 +0100 Message-Id: <20230220092707.22584-1-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen_platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 66e6de31a6..3795a203d4 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" -#include "hw/ide.h" #include "hw/ide/pci.h" #include "hw/pci/pci.h" #include "hw/xen/xen_common.h" -- 2.38.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 09:47:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 09:47:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.497998.768767 (Exim 4.92) (envelope-from ) id 1pU2ku-0002y1-Mu; Mon, 20 Feb 2023 09:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 497998.768767; Mon, 20 Feb 2023 09:46:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU2ku-0002xu-KA; Mon, 20 Feb 2023 09:46:44 +0000 Received: by outflank-mailman (input) for mailman id 497998; Mon, 20 Feb 2023 09:46:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU2ks-0002xo-PR for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 09:46:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU2ks-0003qv-0X; Mon, 20 Feb 2023 09:46:42 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.98.51]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pU2kr-0005C7-NM; Mon, 20 Feb 2023 09:46:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AoNy+bhsopCqt3Qqp24OGW0eFfiCNk/ARze0y4mqBCE=; b=1XsVwyxGz9qU7kwgvaUiPH+CJn Ik9gD9cnyM5gh89zMkzH/B35UCT4ANZqTPqK/azQhI5hisL41pEApsx9bzOARBCdreX0xpCV2awxe JrYL+MlM3ArUyjhcvhk4hzXSJTZt261AOLvEntdyJO34h7oX+pqx4AKf+iTiaCu7CvZg=; Message-ID: <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> Date: Mon, 20 Feb 2023 09:46:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> From: Julien Grall In-Reply-To: <20230120100028.11142-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: > The accounting for the number of nodes of a domain in an active > transaction is not working correctly, as it allows to create arbitrary > number of nodes. The transaction will finally fail due to exceeding > the number of nodes quota, but before closing the transaction an > unprivileged guest could cause Xenstore to use a lot of memory. I know I said I would delay my decision on this patch. However, I was still expecting the commit message to be updated based on our previous discussion. Also thinking more about it, "The transaction will finally fail due to exceeding the number of nodes quota" may not be true for a couple of reasons: 1) The transaction may removed a node afterwards. 2) A node may have been removed outside of the transaction. In both situation, the transaction will still be committed. This will now be prevented by this patch. While I understand, they may be edge cases, this is also true for what you are aiming to solve. So I am still not convinced about the benefits of this patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:05:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:05:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498010.768788 (Exim 4.92) (envelope-from ) id 1pU3ya-0004EO-I7; Mon, 20 Feb 2023 11:04:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498010.768788; Mon, 20 Feb 2023 11:04:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU3ya-0004EG-FW; Mon, 20 Feb 2023 11:04:56 +0000 Received: by outflank-mailman (input) for mailman id 498010; Mon, 20 Feb 2023 11:04:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU3yZ-0003zE-1P for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:04:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 66206be3-b10e-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 12:04:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8827320005; Mon, 20 Feb 2023 11:04:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6300F134BA; Mon, 20 Feb 2023 11:04:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dax9FtNT82NBPAAAMHmgww (envelope-from ); Mon, 20 Feb 2023 11:04:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66206be3-b10e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676891091; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F9/ZiE99IXAL27UTSrwjYZjIXy2MJesLf5yBAuf1/1s=; b=tuha3FVxmEx0Qe2IlORAXY3rEvNaGMSy7hQ0LauaBcWEELdWlNKuKORjm2a5PcFu3G8JBn zhH16AfDxPOnnP822msRWjxnTRuX0IPYpBb3pcsB4MmQ9Qk6pC+WurzH7himY78JOitXCt tyFSj89SZl6Wyz/YRfwYW9dQ0FNyWtA= Message-ID: Date: Mon, 20 Feb 2023 12:04:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------m0BE5fzngLLxza0vgqFxdubl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------m0BE5fzngLLxza0vgqFxdubl Content-Type: multipart/mixed; boundary="------------06BB4I4vDQMn8HcuKC07CLyu"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> In-Reply-To: <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> --------------06BB4I4vDQMn8HcuKC07CLyu Content-Type: multipart/mixed; boundary="------------dUTlRdcje0VlHKvOLc8n9bAA" --------------dUTlRdcje0VlHKvOLc8n9bAA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMTA6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBU aGUgYWNjb3VudGluZyBmb3IgdGhlIG51bWJlciBvZiBub2RlcyBvZiBhIGRvbWFpbiBpbiBh biBhY3RpdmUNCj4+IHRyYW5zYWN0aW9uIGlzIG5vdCB3b3JraW5nIGNvcnJlY3RseSwgYXMg aXQgYWxsb3dzIHRvIGNyZWF0ZSBhcmJpdHJhcnkNCj4+IG51bWJlciBvZiBub2Rlcy4gVGhl IHRyYW5zYWN0aW9uIHdpbGwgZmluYWxseSBmYWlsIGR1ZSB0byBleGNlZWRpbmcNCj4+IHRo ZSBudW1iZXIgb2Ygbm9kZXMgcXVvdGEsIGJ1dCBiZWZvcmUgY2xvc2luZyB0aGUgdHJhbnNh Y3Rpb24gYW4NCj4+IHVucHJpdmlsZWdlZCBndWVzdCBjb3VsZCBjYXVzZSBYZW5zdG9yZSB0 byB1c2UgYSBsb3Qgb2YgbWVtb3J5Lg0KPiANCj4gSSBrbm93IEkgc2FpZCBJIHdvdWxkIGRl bGF5IG15IGRlY2lzaW9uIG9uIHRoaXMgcGF0Y2guIEhvd2V2ZXIsIEkgd2FzIHN0aWxsIA0K PiBleHBlY3RpbmcgdGhlIGNvbW1pdCBtZXNzYWdlIHRvIGJlIHVwZGF0ZWQgYmFzZWQgb24g b3VyIHByZXZpb3VzIGRpc2N1c3Npb24uDQoNCkFzIHNhaWQgYmVmb3JlLCBJIHdhcyB3YWl0 aW5nIG9uIHRoZSBzZXR0bGVtZW50IG9mIG91ciBkaXNjdXNzaW9uIGJlZm9yZQ0KZG9pbmcg dGhlIHVwZGF0ZS4NCg0KPiBBbHNvIHRoaW5raW5nIG1vcmUgYWJvdXQgaXQsICJUaGUgdHJh bnNhY3Rpb24gd2lsbCBmaW5hbGx5IGZhaWwgZHVlIHRvIGV4Y2VlZGluZyANCj4gdGhlIG51 bWJlciBvZiBub2RlcyBxdW90YSIgbWF5IG5vdCBiZSB0cnVlIGZvciBhIGNvdXBsZSBvZiBy ZWFzb25zOg0KPiAgwqAgMSkgVGhlIHRyYW5zYWN0aW9uIG1heSByZW1vdmVkIGEgbm9kZSBh ZnRlcndhcmRzLg0KDQpZZXMsIGFuZD8gSnVzdCBiZWNhdXNlIGl0IGlzIGEgdHJhbnNhY3Rp b24sIHRoaXMgaXMgc3RpbGwgYSB2aW9sYXRpb24gb2YNCnRoZSBxdW90YS4gRXZlbiBvdXRz aWRlIGEgdHJhbnNhY3Rpb24geW91IGNvdWxkIHVzZSB0aGUgc2FtZSByZWFzb25pbmcsDQpi dXQgeW91IGRvbid0ICh3aGljaCBpcyBjb3JyZWN0LCBvZiBjb3Vyc2UpLg0KDQpJbiBjYXNl IHlvdSBuZXZlciBmaW5pc2ggdGhlIHRyYW5zYWN0aW9uLCB5b3UgYXJlIG93bmVyIG9mIG1v cmUgdGhhbg0KYWxsb3dlZCBub2Rlcy4NCg0KPiAgwqAgMikgQSBub2RlIG1heSBoYXZlIGJl ZW4gcmVtb3ZlZCBvdXRzaWRlIG9mIHRoZSB0cmFuc2FjdGlvbi4NCg0KSWYgdGhlIHJlbW92 ZWQgbm9kZSBoYXNuJ3QgYmVlbiB0b3VjaGVkIGJ5IHRoZSB0cmFuc2FjdGlvbiwgaXQgd2ls bCBiZQ0KYWNjb3VudGVkIGZvciBjb3JyZWN0bHkuIElmIGl0IGhhcyBiZWVuIHRvdWNoZWQs IHRoZSB0cmFuc2FjdGlvbiB3aWxsDQpmYWlsIGFueXdheS4NCg0KPiBJbiBib3RoIHNpdHVh dGlvbiwgdGhlIHRyYW5zYWN0aW9uIHdpbGwgc3RpbGwgYmUgY29tbWl0dGVkLiBUaGlzIHdp bGwgbm93IGJlIA0KPiBwcmV2ZW50ZWQgYnkgdGhpcyBwYXRjaC4NCg0KQXMgc2FpZCBhYm92 ZSwgb25seSBpbiB0aGUgZmlyc3QgY2FzZS4NCg0KPiBXaGlsZSBJIHVuZGVyc3RhbmQsIHRo ZXkgbWF5IGJlIGVkZ2UgY2FzZXMsIHRoaXMgaXMgYWxzbyB0cnVlIGZvciB3aGF0IHlvdSBh cmUgDQo+IGFpbWluZyB0byBzb2x2ZS4gU28gSSBhbSBzdGlsbCBub3QgY29udmluY2VkIGFi b3V0IHRoZSBiZW5lZml0cyBvZiB0aGlzIHBhdGNoLg0KDQoNCkp1ZXJnZW4NCg0K --------------dUTlRdcje0VlHKvOLc8n9bAA Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dUTlRdcje0VlHKvOLc8n9bAA-- --------------06BB4I4vDQMn8HcuKC07CLyu-- --------------m0BE5fzngLLxza0vgqFxdubl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzU9IFAwAAAAAACgkQsN6d1ii/Ey91 oQf+NY2d7F8BDg48JlJiuFADAdAFhsV3j8YOg/syntf4cRX+lrlVr+S1xACzXNTsgjQzg7onV3ux wiLnVfz216A8NUyX3wG5SOMwL9xZQrDr9zh2UjA8ZFfCilin1v8a8CqQELL5OIlSiYCZHE/hJ/jo jQZOc3PNmEqlKyB0KBKrjctF0myoPSHpGjalBHjWFlyqjgdNol1Wvz6xpxtTEYj/3BUTr7cg96fQ rPQkUNpyBKs7O3ikhsk2P7bZV1pywKDLcwXguvARgVL/YwIW6/nr3D64F1p+eR7Pa8FnRz3Gp0jv E/iqe3VduQlH6pPAXTruMGTk78rUSPltmkqrcr0AyQ== =US7E -----END PGP SIGNATURE----- --------------m0BE5fzngLLxza0vgqFxdubl-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:05:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:05:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498009.768778 (Exim 4.92) (envelope-from ) id 1pU3yZ-0003zQ-Bt; Mon, 20 Feb 2023 11:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498009.768778; Mon, 20 Feb 2023 11:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU3yZ-0003zJ-8C; Mon, 20 Feb 2023 11:04:55 +0000 Received: by outflank-mailman (input) for mailman id 498009; Mon, 20 Feb 2023 11:04:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU3yX-0003z8-KZ for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:04:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 649649bb-b10e-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 12:04:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 649649bb-b10e-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676891091; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CsFq8b5LCrQLYxvppMCMp85XRubt/i7qyf+titO7ukI=; b=E5h4JVWAjqM74n7vtk8UOtf4eKb/DyconX+yJo7NUZFbsIZ1Hrb4RFNA jA3fOmho6e1jYC6Q2xbEbQdaBw6PUHjh0h+XN1rOIvp5Lpiox3fkymGdz vfbQNt2k3cwXCxG65RhsO+UqKK0GV4ZDDaReA+Flxo4Pfx+vUQIMWyuN2 w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97643589 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:64mog69H/U+67uo2Fko3DrUDqX6TJUtcMsCJ2f8bNWPcYEJGY0x3n DMaCm+DP66JY2f9fdtzOom1/U1QuseGzdVrSAc5+CE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oT5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklux OI/BHchUSrdxMWN6ZCdZssruM08eZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0EwRjE/ T+WrgwVBDlBL8TGwxvUzkuHudbUnA2kYrtJBv6Ro6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0efBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC/ lyOmcngCXpwsbmWYXWH/7yQoHW5Pi19EIMZTXZaF01fuYCl+dxtyEuVFb6PDZJZkPXVKC/X7 3emkxJgxJIopOwt+4f8w1nY1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4 SFsd9y2qblXUMrTzHDlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCH17ZiTCgUxfOdjZ5yEWIU/ITI2NaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN JGQfK6EVChFV/Q8lWTtGrhFitfHIxzSIkuJGPjGI+mPi+LCNBZ5t59YWLdxUgzJxPzd+1iEm zquH8CL1w9eQIXDjtr/qOYuwaQxBSFjX/je8pUHHtNv1yI6QAnN/deNm+J+E2Gk9owJ/tr1E oaVABEBmAev2iGWcG1nqBlLMdvSYHq2llpjVQREALpi8yF7CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:wtnDIKPPUD6ZdMBcTs2jsMiBIKoaSvp037Eqv3oedfUzSL3+qy nOpoV+6faaslYssR0b9exoW5PwJE80l6QFgrX5VI3KNGKN1VdARLsSi7cKqAeAJ8SRzIFgPN 9bAspDNOE= X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97643589" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH] x86/asm: ELF metadata for simple cases Date: Mon, 20 Feb 2023 11:04:39 +0000 Message-ID: <20230220110439.1518972-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is generally good practice, and necessary for livepatch binary diffing to work. With this, livepatching of the SVM entry path works. The only complication is with svm_stgi_label which is only used by oprofile to guestimate (not completely correctly) when an NMI hit guest context. Livepatching of VMX is still an open question, because the logic doesn't form anything remotely resembling functions. Both code fragments jump into each other so need to be updated in tandem. Also, both code fragment entries need trampolines in the case that patching actually occurs. For now, just treat it as a single function. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall --- xen/arch/x86/clear_page.S | 3 +++ xen/arch/x86/copy_page.S | 3 +++ xen/arch/x86/hvm/svm/entry.S | 3 +++ xen/arch/x86/hvm/vmx/entry.S | 3 +++ 4 files changed, 12 insertions(+) diff --git a/xen/arch/x86/clear_page.S b/xen/arch/x86/clear_page.S index d9d524c79ecd..5b5622cc526f 100644 --- a/xen/arch/x86/clear_page.S +++ b/xen/arch/x86/clear_page.S @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2) sfence ret + + .type clear_page_sse2, @function + .size clear_page_sse2, . - clear_page_sse2 diff --git a/xen/arch/x86/copy_page.S b/xen/arch/x86/copy_page.S index 2da81126c5fa..ddb6e0ebbb6e 100644 --- a/xen/arch/x86/copy_page.S +++ b/xen/arch/x86/copy_page.S @@ -41,3 +41,6 @@ ENTRY(copy_page_sse2) sfence ret + + .type copy_page_sse2, @function + .size copy_page_sse2, . - copy_page_sse2 diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 981cd82e7c0b..9e3dab768027 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -142,3 +142,6 @@ GLOBAL(svm_stgi_label) sti call do_softirq jmp .Lsvm_do_resume + + .type svm_asm_do_resume, @function + .size svm_asm_do_resume, . - svm_asm_do_resume diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index 5f5de45a1309..e3f60d5a82f7 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -150,3 +150,6 @@ ENTRY(vmx_asm_do_vmentry) sti call do_softirq jmp .Lvmx_do_vmentry + + .type vmx_asm_vmexit_handler, @function + .size vmx_asm_vmexit_handler, . - vmx_asm_vmexit_handler -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498020.768800 (Exim 4.92) (envelope-from ) id 1pU4Ab-0006F5-Me; Mon, 20 Feb 2023 11:17:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498020.768800; Mon, 20 Feb 2023 11:17:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4Ab-0006Ey-Ih; Mon, 20 Feb 2023 11:17:21 +0000 Received: by outflank-mailman (input) for mailman id 498020; Mon, 20 Feb 2023 11:17:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4AZ-0006Eq-Ti for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:17:20 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21d0684e-b110-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 12:17:17 +0100 (CET) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-384-23Gxb1RVNbyAdCViX9xqDw-1; Mon, 20 Feb 2023 06:17:14 -0500 Received: by mail-wr1-f70.google.com with SMTP id g6-20020adfa486000000b002c55ef1ec94so96239wrb.0 for ; Mon, 20 Feb 2023 03:17:14 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id c128-20020a1c3586000000b003e21558ee9dsm331492wma.2.2023.02.20.03.17.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 03:17:12 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21d0684e-b110-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676891836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4EQNfPCKlm/dnqlucYMgfhMhQeV8s6OOHLtd2gYWnSc=; b=bCt5/hFMgVueFQtlt9TrsPeAUpka+6urNnoT9ydQj5eb4cOYqaUEs/HKI887XEIYC5l1n9 mCZlR94CzlcmUnHOXOrcBw8ln3H2qCCwo69HhHR/2W4ny7riYBKCQHs6X9u7Xw9O6z58E6 kE0TJdVdItM8HQ8k30dLuJuq0KHbTYI= X-MC-Unique: 23Gxb1RVNbyAdCViX9xqDw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4EQNfPCKlm/dnqlucYMgfhMhQeV8s6OOHLtd2gYWnSc=; b=hIW92pqbJ4frvvhW6uMH9qGm6prMO/bDvAGNvlAS4LRXgXfMiXgiDyACIXN9/lpCOa n5PbAS/572vY9P2p5Y8iwOjlOgMNyDYsazUg8Ny8/8HhNzAIma7UAXTJO+dd+KbVg6x2 b69bPTYUK71klI5Fqa98mqUPri/GNzO81H1kmUYau2shqvQ4CBrBQTHIa4mX2s0tYfCZ zM9lfn2NFlG0nG4B6Nkw8HTAbWYNzQvWo6pdfIuSWuGWgjc6kUwlOSvVIgH3XbOGpNX+ 9pVdI261I7BIVjhM1QnW4ryYm6QUm+6kTBND1tjRPkXD4iXhFsppG3UDyocDqSXI0Aq1 ziaw== X-Gm-Message-State: AO0yUKWdGT5U9eCrUK/BW4zXwVsUkX1HvJIYQ91M7vOv2Y3PW2kYa8+g C6qRONQIfXmVqPgrTltU9TDg2beMx0KFTVjg4b8cXkulAFJg+sWtoT6n2wsMpLnlfWZgliyoQYw Y41PWhT5DzJ0vOnE4ASQ5PP/6rME= X-Received: by 2002:a05:600c:4d89:b0:3e0:1a9:b1e0 with SMTP id v9-20020a05600c4d8900b003e001a9b1e0mr578806wmp.25.1676891833534; Mon, 20 Feb 2023 03:17:13 -0800 (PST) X-Google-Smtp-Source: AK7set8S0E2hPJcQfDWwVBHJ827trXEDgyAecAtZgO3tsbPQgMPJ2pfBI07ijKz0qUw/7N5br62ouQ== X-Received: by 2002:a05:600c:4d89:b0:3e0:1a9:b1e0 with SMTP id v9-20020a05600c4d8900b003e001a9b1e0mr578749wmp.25.1676891833134; Mon, 20 Feb 2023 03:17:13 -0800 (PST) Message-ID: Date: Mon, 20 Feb 2023 12:17:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 11/41] mm: Introduce pte_mkwrite_kernel() To: Kees Cook , Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-12-rick.p.edgecombe@intel.com> <63f288cc.a70a0220.5558c.3c92@mx.google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <63f288cc.a70a0220.5558c.3c92@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.02.23 21:38, Kees Cook wrote: > On Sat, Feb 18, 2023 at 01:14:03PM -0800, Rick Edgecombe wrote: >> The x86 Control-flow Enforcement Technology (CET) feature includes a new >> type of memory called shadow stack. This shadow stack memory has some >> unusual properties, which requires some core mm changes to function >> properly. >> >> One of these changes is to allow for pte_mkwrite() to create different >> types of writable memory (the existing conventionally writable type and >> also the new shadow stack type). Future patches will convert pte_mkwrite() >> to take a VMA in order to facilitate this, however there are places in the >> kernel where pte_mkwrite() is called outside of the context of a VMA. >> These are for kernel memory. So create a new variant called >> pte_mkwrite_kernel() and switch the kernel users over to it. Have >> pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches >> will introduce changes to make pte_mkwrite() take a VMA. >> >> Only do this for architectures that need it because they call pte_mkwrite() >> in arch code without an associated VMA. Since it will only currently be >> used in arch code, so do not include it in arch_pgtable_helpers.rst. >> >> Cc: linux-doc@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-s390@vger.kernel.org >> Cc: xen-devel@lists.xenproject.org >> Cc: linux-arch@vger.kernel.org >> Cc: linux-mm@kvack.org >> Tested-by: Pengfei Xu >> Suggested-by: David Hildenbrand >> Signed-off-by: Rick Edgecombe > > I think it's a little weird that it's the only PTE helper taking a vma, > but it does seem like the right approach. Right. We could pass the vm flags instead, but not sure if that really improves the situation. So unless someone has a better idea, this LGTM. -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:19:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498028.768811 (Exim 4.92) (envelope-from ) id 1pU4D3-0006xr-2T; Mon, 20 Feb 2023 11:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498028.768811; Mon, 20 Feb 2023 11:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4D2-0006xk-V0; Mon, 20 Feb 2023 11:19:52 +0000 Received: by outflank-mailman (input) for mailman id 498028; Mon, 20 Feb 2023 11:19:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4D2-0006xe-8K for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:19:52 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d472a48-b110-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 12:19:51 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-59-fQcdAjn9PaiHiwn9PynL9g-1; Mon, 20 Feb 2023 06:19:46 -0500 Received: by mail-wm1-f69.google.com with SMTP id bg22-20020a05600c3c9600b003e209b61ebbso396854wmb.3 for ; Mon, 20 Feb 2023 03:19:46 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id z5-20020a5d6405000000b002c5534db60bsm713917wru.71.2023.02.20.03.19.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 03:19:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d472a48-b110-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676891989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Y0d/vI0Qp2mhR9IQ+0FEQIh8Qkf0r9E2FFAh9KN8Lg=; b=FPw99/XYfI9dw0GAndEKb/PzBONw4VcW8WwH3a15hqlI5RQ9zE+fZNTys4MFEJGSNk8oCh L2dO6sty/H+scfmI8o7vV0hnrzN5iMRss4pdjnEVTy6hoqAni7Sy8kwPkbd443LghbLoJc Srl1rvGqC8+VDgmhwPyRDg6V+neQgvA= X-MC-Unique: fQcdAjn9PaiHiwn9PynL9g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Y0d/vI0Qp2mhR9IQ+0FEQIh8Qkf0r9E2FFAh9KN8Lg=; b=2cTb07fOrqSq7N06uppcSRc2L23FcH1TjCvExF0O3blmB84HbzC5du/kq/x6f4VnGP tKdtoYEmD79+y6nXM3iA/C/w13B1ggJXz+JmcG/xwCeXSiMFRDg/ScsXZzovvJasClXo OgiMldKlYqWt2ScG79UdzyF15rDo6kNvO1lQ4WS9tKM0AD8xx1TsIzpIpGE542vgfHev p37IFbal26DcEWvqP+sSV6I6rKPG88yLe3er78PPIQ3ZcPRxPv9dnOJeRG5ma1YJYKIN 1lwL4sMPJeDuFRUmfEVwbwZHXjYREIQOyBhBeizdMUrA6QjYGDzYBe/iNyt3qI4fcvLQ oTSg== X-Gm-Message-State: AO0yUKU8ew75Q58N/8Uf9PXrcfhqjSjx/TGCHZqKeWVSEG/6UmG0mJ/T Ntx/M3h8JS3mEZ89znJZdPjJW2ZksV49TI75PvDgQTQHQe6OhXXV6AxrUCbs0FAr53j3Vs/HcLK PGK1vFLFh3PxcepsKMIx2+yzDz0E= X-Received: by 2002:a05:600c:13c3:b0:3e0:39:ec9d with SMTP id e3-20020a05600c13c300b003e00039ec9dmr667653wmg.23.1676891985217; Mon, 20 Feb 2023 03:19:45 -0800 (PST) X-Google-Smtp-Source: AK7set8gwoTHdOCWEVucXLZ1cWaezJA5lkFoQjhOhQbs8nj/fdafmDMVp3INR4+sjGhG9kWSgEqR2w== X-Received: by 2002:a05:600c:13c3:b0:3e0:39:ec9d with SMTP id e3-20020a05600c13c300b003e00039ec9dmr667628wmg.23.1676891984832; Mon, 20 Feb 2023 03:19:44 -0800 (PST) Message-ID: <77f5e061-080b-f9f0-25f7-bbbe721b5e2e@redhat.com> Date: Mon, 20 Feb 2023 12:19:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 11/41] mm: Introduce pte_mkwrite_kernel() To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-12-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230218211433.26859-12-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18.02.23 22:14, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these changes is to allow for pte_mkwrite() to create different > types of writable memory (the existing conventionally writable type and > also the new shadow stack type). Future patches will convert pte_mkwrite() > to take a VMA in order to facilitate this, however there are places in the > kernel where pte_mkwrite() is called outside of the context of a VMA. > These are for kernel memory. So create a new variant called > pte_mkwrite_kernel() and switch the kernel users over to it. Have > pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches > will introduce changes to make pte_mkwrite() take a VMA. > > Only do this for architectures that need it because they call pte_mkwrite() > in arch code without an associated VMA. Since it will only currently be > used in arch code, so do not include it in arch_pgtable_helpers.rst. > > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe > Acked-by: David Hildenbrand Do we also have to care about pmd_mkwrite() ? -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:20:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498032.768821 (Exim 4.92) (envelope-from ) id 1pU4DV-0008I7-E9; Mon, 20 Feb 2023 11:20:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498032.768821; Mon, 20 Feb 2023 11:20:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4DV-0008I0-BF; Mon, 20 Feb 2023 11:20:21 +0000 Received: by outflank-mailman (input) for mailman id 498032; Mon, 20 Feb 2023 11:20:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4DT-0006xe-Qr for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:20:20 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e5de171-b110-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 12:20:18 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 334F821FBE; Mon, 20 Feb 2023 11:20:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0B104134BA; Mon, 20 Feb 2023 11:20:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4y1UAXJX82MGRQAAMHmgww (envelope-from ); Mon, 20 Feb 2023 11:20:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e5de171-b110-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676892018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BkbQ7xs9hBHhrCIFLTqNdeC+iLFNu71Wtou1kVPsvBc=; b=g0Lm6CzibLxmDZkiPBnntgtF8ZLDowqmyg+C+uTgrZoruiYJEoxXSEQrJuo39Xc+oDGHIx 6tj7LdHHLkZ/lI3w18q11f3RckWWr8e55qNgnfwMi9MrJAA1lkV5/VPy2GQp9oGW86yKU7 /OOkUJbNQPAZviVIAB/S5V9vNVkD5vo= Message-ID: <93762544-5866-1a6f-1d64-b5fa4286feb3@suse.com> Date: Mon, 20 Feb 2023 12:20:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-4-jgross@suse.com> <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 03/13] tools/xenstore: introduce accounting data array for per-domain values In-Reply-To: <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RjwjnrO8Q1IPCodt90PRuk0x" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RjwjnrO8Q1IPCodt90PRuk0x Content-Type: multipart/mixed; boundary="------------otswQTh47IyLSj9TWUbG4D18"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <93762544-5866-1a6f-1d64-b5fa4286feb3@suse.com> Subject: Re: [PATCH v2 03/13] tools/xenstore: introduce accounting data array for per-domain values References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-4-jgross@suse.com> <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> In-Reply-To: <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> --------------otswQTh47IyLSj9TWUbG4D18 Content-Type: multipart/mixed; boundary="------------83PErUtvdrEtw4NkmzlEuJ10" --------------83PErUtvdrEtw4NkmzlEuJ10 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDIuMjMgMjA6MjksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnRyb2R1Y2UgdGhlIHNjaGVtZSBvZiBhbiBhY2NvdW50aW5nIGRhdGEgYXJyYXkgZm9yIHBl ci1kb21haW4NCj4+IGFjY291bnRpbmcgZGF0YSBhbmQgdXNlIGl0IGluaXRpYWxseSBmb3Ig dGhlIG51bWJlciBvZiBub2RlcyBvd25lZCBieQ0KPj4gYSBkb21haW4uDQo+Pg0KPj4gTWFr ZSB0aGUgYWNjb3VudGluZyBkYXRhIHR5cGUgdG8gYmUgdW5zaWduZWQgaW50LCBhcyBubyBk YXRhIGlzIGFsbG93ZWQNCj4+IHRvIGJlIG5lZ2F0aXZlIGF0IGFueSB0aW1lLg0KPj4NCj4+ IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0t LQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIHwgNzEgKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2RvbWFpbi5oIHzCoCA1ICsrLQ0KPj4gwqAgMiBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNl cnRpb25zKCspLCAzMSBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMv eGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jIA0KPj4gYi90b29scy94ZW5zdG9yZS94ZW5z dG9yZWRfZG9tYWluLmMNCj4+IGluZGV4IDQ0ZTcyOTM3ZmEuLmY0NTljNWFhYmIgMTAwNjQ0 DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4+ICsrKyBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYw0KPj4gQEAgLTY5LDggKzY5LDgg QEAgc3RydWN0IGRvbWFpbg0KPj4gwqDCoMKgwqDCoCAvKiBIYXMgZG9tYWluIGJlZW4gb2Zm aWNpYWxseSBpbnRyb2R1Y2VkPyAqLw0KPj4gwqDCoMKgwqDCoCBib29sIGludHJvZHVjZWQ7 DQo+PiAtwqDCoMKgIC8qIG51bWJlciBvZiBlbnRyeSBmcm9tIHRoaXMgZG9tYWluIGluIHRo ZSBzdG9yZSAqLw0KPj4gLcKgwqDCoCBpbnQgbmJlbnRyeTsNCj4+ICvCoMKgwqAgLyogQWNj b3VudGluZyBkYXRhIGZvciB0aGlzIGRvbWFpbi4gKi8NCj4+ICvCoMKgwqAgdW5zaWduZWQg aW50IGFjY1tBQ0NfTl07DQo+PiDCoMKgwqDCoMKgIC8qIEFtb3VudCBvZiBtZW1vcnkgYWxs b2NhdGVkIGZvciB0aGlzIGRvbWFpbi4gKi8NCj4+IMKgwqDCoMKgwqAgaW50IG1lbW9yeTsN Cj4+IEBAIC0yNDYsNyArMjQ2LDcgQEAgc3RhdGljIGludCBkb21haW5fdHJlZV9yZW1vdmVf c3ViKGNvbnN0IHZvaWQgKmN0eCwgc3RydWN0IA0KPj4gY29ubmVjdGlvbiAqY29ubiwNCj4+ IMKgwqDCoMKgwqAgaWYgKGtlZXBfb3JwaGFucykgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg IHNldF90ZGJfa2V5KG5vZGUtPm5hbWUsICZrZXkpOw0KPj4gLcKgwqDCoMKgwqDCoMKgIGRv bWFpbi0+bmJlbnRyeS0tOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGRvbWFpbl9uYmVudHJ5X2Rl YyhOVUxMLCBkb21haW4tPmRvbWlkKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBub2RlLT5w ZXJtcy5wWzBdLmlkID0gcHJpdl9kb21pZDsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBub2Rl LT5hY2MubWVtb3J5ID0gMDsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBkb21haW5fbmJlbnRy eV9pbmMoTlVMTCwgcHJpdl9kb21pZCk7DQo+PiBAQCAtMjcwLDcgKzI3MCw3IEBAIHN0YXRp YyBpbnQgZG9tYWluX3RyZWVfcmVtb3ZlX3N1Yihjb25zdCB2b2lkICpjdHgsIHN0cnVjdCAN Cj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0ID0gV0FM S19UUkVFX1NLSVBfQ0hJTERSRU47DQo+PiDCoMKgwqDCoMKgIH0NCj4+IC3CoMKgwqAgcmV0 dXJuIGRvbWFpbi0+bmJlbnRyeSA+IDAgPyByZXQgOiBXQUxLX1RSRUVfU1VDQ0VTU19TVE9Q Ow0KPj4gK8KgwqDCoCByZXR1cm4gZG9tYWluLT5hY2NbQUNDX05PREVTXSA/IHJldCA6IFdB TEtfVFJFRV9TVUNDRVNTX1NUT1A7DQo+PiDCoCB9DQo+PiDCoCBzdGF0aWMgdm9pZCBkb21h aW5fdHJlZV9yZW1vdmUoc3RydWN0IGRvbWFpbiAqZG9tYWluKQ0KPj4gQEAgLTI3OCw3ICsy NzgsNyBAQCBzdGF0aWMgdm9pZCBkb21haW5fdHJlZV9yZW1vdmUoc3RydWN0IGRvbWFpbiAq ZG9tYWluKQ0KPj4gwqDCoMKgwqDCoCBpbnQgcmV0Ow0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3Qg d2Fsa19mdW5jcyB3YWxrZnVuY3MgPSB7IC5lbnRlciA9IGRvbWFpbl90cmVlX3JlbW92ZV9z dWIgfTsNCj4+IC3CoMKgwqAgaWYgKGRvbWFpbi0+bmJlbnRyeSA+IDApIHsNCj4+ICvCoMKg wqAgaWYgKGRvbWFpbi0+YWNjW0FDQ19OT0RFU10pIHsNCj4+IMKgwqDCoMKgwqDCoMKgwqDC oCByZXQgPSB3YWxrX25vZGVfdHJlZShkb21haW4sIE5VTEwsICIvIiwgJndhbGtmdW5jcywg ZG9tYWluKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAocmV0ID09IFdBTEtfVFJFRV9F UlJPUl9TVE9QKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3lzbG9nKExPR19F UlIsDQo+PiBAQCAtNDM3LDcgKzQzNyw3IEBAIGludCBkb21haW5fZ2V0X3F1b3RhKGNvbnN0 IHZvaWQgKmN0eCwgc3RydWN0IGNvbm5lY3Rpb24gDQo+PiAqY29ubiwNCj4+IMKgwqDCoMKg wqAgcmVzcCA9IHRhbGxvY19hc3ByaW50Zl9hcHBlbmQocmVzcCwgIiUtMTZzOiAlOGRcbiIs ICN0LCBlKTsgXA0KPj4gwqDCoMKgwqDCoCBpZiAoIXJlc3ApIHJldHVybiBFTk9NRU0NCj4+ IC3CoMKgwqAgZW50KG5vZGVzLCBkLT5uYmVudHJ5KTsNCj4+ICvCoMKgwqAgZW50KG5vZGVz LCBkLT5hY2NbQUNDX05PREVTXSk7DQo+PiDCoMKgwqDCoMKgIGVudCh3YXRjaGVzLCBkLT5u YndhdGNoKTsNCj4+IMKgwqDCoMKgwqAgZW50KHRyYW5zYWN0aW9ucywgdGEpOw0KPj4gwqDC oMKgwqDCoCBlbnQob3V0c3RhbmRpbmcsIGQtPm5ib3V0c3RhbmRpbmcpOw0KPj4gQEAgLTEw NDcsOCArMTA0NywyOCBAQCBpbnQgZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKHN0cnVjdCBu b2RlICpub2RlKQ0KPj4gwqDCoMKgwqDCoCByZXR1cm4gMDsNCj4+IMKgIH0NCj4+IC1zdGF0 aWMgaW50IGRvbWFpbl9uYmVudHJ5X2FkZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdW5z aWduZWQgaW50IGRvbWlkLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgaW50IGFkZCwgYm9vbCBub19kb21fYWxsb2MpDQo+PiArc3RhdGljIGludCBkb21haW5f YWNjX2FkZF9jaGsoc3RydWN0IGRvbWFpbiAqZCwgZW51bSBhY2NpdGVtIHdoYXQsIGludCBh ZGQsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBp bnQgZG9taWQpDQo+IA0KPiBZb3UgYXJlIHBhc3NpbmcgdGhlIGRvbWlkIGJ1dCB0aGlzIGRv ZXNuJ3Qgc2VlbSB0byBiZSB1c2VkIHdpdGhpbiB0aGUgZnVuY3Rpb24uDQoNClRoYXQgd2Fz IGFkZGVkIGluIG9yZGVyIHRvIGF2b2lkIG1vcmUgY29kZSBjaHVybiBpbiBhIGxhdGVyIHBh dGNoLCB3aGljaCBpcw0KbWFraW5nIHVzZSBvZiBkb21pZC4NCg0KPiBBbHNvLCBmcm9tIGp1 c3QgcmVhZGluZyBhdCB0aGlzIHByb3RvdHlwZSwgaXQgaXMgbm90IGNsZWFyIHRvIG1lIHdo ZXRoZXIgJ2RvbWlkJyANCj4gaXMgbWVhbnQgdG8gY29ycmVzcG9uZCB0byB0aGUgb25lIG9m ICdkJy4NCg0KSXQgaXMgY29ycmVzcG9uZGluZyB0byAnZCcsIHNvIEkgdGhpbmsgSSBjYW4g cmVtb3ZlIHRoZSBkb21pZCBwYXJhbWV0ZXIgd2l0aG91dA0KcHJvYmxlbSAoSSB0aGluayBJ IGhhZCBpdCB0aGlzIHdheSBiZWNhdXNlIGQgY291bGQgYmUgTlVMTCBpbiBteSBpbml0aWFs DQp2ZXJzaW9uLCB3aGljaCBjaGFuZ2VkIGFmdGVyd2FyZHMgLSBJJ20gbm90IHN1cmUgYWJv dXQgdGhlIGhpc3RvcnksIHRob3VnaCkuDQoNCj4gVGhlIG5hbWUgaXMgYWxzbyBhIGJpdCBj b25mdXNpbmcgYmVjYXVzZSBiZWxvdyB5b3UgaGF2ZSBhIGZ1bmN0aW9uIGNhbGwgDQo+IGRv bWFpbl9hY2NfYWRkKCkgdGhhdCB3aWxsIHVwZGF0ZSAiZC0+YWNjW3doYXRdIiBzbyBJIHdv dWxkIGV4cGVjdCB0aGlzIGZ1bmN0aW9uIA0KPiB0byBhbHNvIHVwZGF0ZSBpdCBhZnRlciBh IHNhbml0eSBnZXQuDQo+IA0KPiBJIHdvdWxkIHN1Z2dlc3QgdG8gcmVuYW1lIGl0IHRvIGRv bWFpbl9hY2NfZ2V0X2NoaygpIG9yIHNpbWlsYXIgKHNlZSBiZWxvdyBmb3IgDQo+IHNvbWUg Y29udGV4dCkuDQoNCkkgY291bGQgZG8gdGhhdCwgYnV0IGNoZWNrIGlzIGRvbmUgYmFzZWQg b24gdGhlIGN1cnJlbnQgdmFsdWUgcGx1cyBhbiAiYWRkIg0KdmFsdWUsIGhlbmNlIHRoZSBj dXJyZW50IG5hbWUuIFdvdWxkIGRvbWFpbl9hY2NfYWRkX3ZhbGlkKCkgYmUgYSBiZXR0ZXIN Cm5hbWU/DQoNCj4gDQo+PiArew0KPj4gK8KgwqDCoCBhc3NlcnQod2hhdCA8IEFSUkFZX1NJ WkUoZC0+YWNjKSk7DQo+PiArDQo+PiArwqDCoMKgIGlmICgoYWRkIDwgMCAmJiAtYWRkID4g ZC0+YWNjW3doYXRdKSB8fA0KPj4gK8KgwqDCoMKgwqDCoMKgIChkLT5hY2Nbd2hhdF0gKyBh ZGQpID4gSU5UX01BWCkgew0KPiANCj4gTklUOiBFdmVuIGlmIEkga25vdyB0aGF0ICdhZGQn IHdpbGwgdW5saWtlbHkgYmUgSU5UX01BWCwgaXQgd291bGQgYmUgYmV0dGVyIHRvIA0KPiB1 c2UgJyhJTlRfTUFYIC0gZC0+YWNjW3doYXRdKSA8IGFkZCknLiBTbyB0aGVyZSBpcyBubyBv dmVyZmxvdyBwb3NzaWJsZS4NCg0KT2theS4NCg0KPiANCj4+ICvCoMKgwqDCoMKgwqDCoCAv Kg0KPj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBJbiBhIHRyYW5zYWN0aW9uIHdoZW4gYSBub2Rl IGlzIGJlaW5nIGFkZGVkL3JlbW92ZWQgQU5EIHRoZQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqAg KiBzYW1lIG5vZGUgaGFzIGJlZW4gYWRkZWQvcmVtb3ZlZCBvdXRzaWRlIHRoZSB0cmFuc2Fj dGlvbiBpbg0KPj4gK8KgwqDCoMKgwqDCoMKgwqAgKiBwYXJhbGxlbCwgdGhlIHJlc3VsdGlu ZyB2YWx1ZSB3aWxsIGJlIHdyb25nLiBUaGlzIGlzIG5vDQo+PiArwqDCoMKgwqDCoMKgwqDC oCAqIHByb2JsZW0sIGFzIHRoZSB0cmFuc2FjdGlvbiB3aWxsIGZhaWwgZHVlIHRvIHRoZSBy ZXN1bHRpbmcNCj4+ICvCoMKgwqDCoMKgwqDCoMKgICogY29uZmxpY3QuDQo+PiArwqDCoMKg wqDCoMKgwqDCoCAqLw0KPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAoYWRkIDwgMCkgPyAw IDogSU5UX01BWDsNCj4+ICvCoMKgwqAgfQ0KPj4gKw0KPj4gK8KgwqDCoCByZXR1cm4gZC0+ YWNjW3doYXRdICsgYWRkOw0KPj4gK30NCj4+ICsNCj4+ICtzdGF0aWMgaW50IGRvbWFpbl9h Y2NfYWRkKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1bnNpZ25lZCBpbnQgZG9taWQsDQo+ PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW51bSBhY2NpdGVtIHdoYXQsIGludCBh ZGQsIGJvb2wgbm9fZG9tX2FsbG9jKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3Qg ZG9tYWluICpkOw0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkOw0KPj4g QEAgLTEwNzEsNTYgKzEwOTEsNDkgQEAgc3RhdGljIGludCBkb21haW5fbmJlbnRyeV9hZGQo c3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIA0KPj4gdW5zaWduZWQgaW50IGRvbWlkLA0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+IMKgwqDCoMKgwqAgfQ0KPj4gLcKgwqDCoCBpZiAo Y29ubiAmJiBjb25uLT50cmFuc2FjdGlvbikgew0KPj4gK8KgwqDCoCBpZiAoY29ubiAmJiBj b25uLT50cmFuc2FjdGlvbiAmJiB3aGF0IDwgQUNDX1RSX04pIHsNCj4gDQo+IERvIHlvdSBo YXZlIGEgdXNlIGNhc2Ugd2hlcmUgJ3doYXQnIGlzID49IEFDQ19UUl9OIGFuZCB5b3Ugd2Fu dCB0byBtb2RpZnkgZC0+YWNjPw0KDQpZZXMsIHBsZWFzZSBzZWUgcGF0Y2ggNy4NCg0KPiAN Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBoZWFkID0gdHJhbnNhY3Rpb25fZ2V0X2NoYW5nZWRf ZG9tYWlucyhjb25uLT50cmFuc2FjdGlvbik7DQo+PiAtwqDCoMKgwqDCoMKgwqAgcmV0ID0g YWNjX2FkZF9jaGFuZ2VkX2RvbShjb25uLT50cmFuc2FjdGlvbiwgaGVhZCwgQUNDX05PREVT LA0KPj4gK8KgwqDCoMKgwqDCoMKgIHJldCA9IGFjY19hZGRfY2hhbmdlZF9kb20oY29ubi0+ dHJhbnNhY3Rpb24sIGhlYWQsIHdoYXQsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFkZCwgZG9taWQpOw0KPj4gwqDCoMKgwqDCoMKgwqDC oMKgIGlmIChlcnJubykgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmFpbF90 cmFuc2FjdGlvbihjb25uLT50cmFuc2FjdGlvbik7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCByZXR1cm4gLTE7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgfQ0KPj4gLcKgwqDC oMKgwqDCoMKgIC8qDQo+PiAtwqDCoMKgwqDCoMKgwqDCoCAqIEluIGEgdHJhbnNhY3Rpb24g d2hlbiBhIG5vZGUgaXMgYmVpbmcgYWRkZWQvcmVtb3ZlZCBBTkQgdGhlDQo+PiAtwqDCoMKg wqDCoMKgwqDCoCAqIHNhbWUgbm9kZSBoYXMgYmVlbiBhZGRlZC9yZW1vdmVkIG91dHNpZGUg dGhlIHRyYW5zYWN0aW9uIGluDQo+PiAtwqDCoMKgwqDCoMKgwqDCoCAqIHBhcmFsbGVsLCB0 aGUgcmVzdWx0aW5nIG51bWJlciBvZiBub2RlcyB3aWxsIGJlIHdyb25nLiBUaGlzDQo+PiAt wqDCoMKgwqDCoMKgwqDCoCAqIGlzIG5vIHByb2JsZW0sIGFzIHRoZSB0cmFuc2FjdGlvbiB3 aWxsIGZhaWwgZHVlIHRvIHRoZQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqAgKiByZXN1bHRpbmcg Y29uZmxpY3QuDQo+PiAtwqDCoMKgwqDCoMKgwqDCoCAqIEluIHRoZSBub2RlIHJlbW92ZSBj YXNlIHRoZSByZXN1bHRpbmcgbnVtYmVyIGNhbiBiZSBldmVuDQo+PiAtwqDCoMKgwqDCoMKg wqDCoCAqIG5lZ2F0aXZlLCB3aGljaCBzaG91bGQgYmUgYXZvaWRlZC4NCj4+IC3CoMKgwqDC oMKgwqDCoMKgICovDQo+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIG1heChkLT5uYmVudHJ5 ICsgcmV0LCAwKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZG9tYWluX2FjY19hZGRf Y2hrKGQsIHdoYXQsIHJldCwgZG9taWQpOw0KPiANCj4gSSB3YXMgZ29pbmcgdG8gYXNrIGhl cmUgd2h5IHdlIGFyZSB1cGRhdGluZyBkLT5hY2Nbd2hhdF0uIEhvd2V2ZXIgdGhlIGZ1bmN0 aW9uIA0KPiBpcyBub3QgZG9pbmcgd2hhdCBJIHdhcyBleHBlY3RpbmcgZnJvbSB0aGUgbmFt ZS4gWW91IGFyZSBvbmx5IHJldHVybmluZyB0aGUgDQo+IG51bWJlciBvZiBlbnRyaWVzIGFk anVzdGVkLg0KDQpIdWg/DQoNCkluIHRoZSB0cmFuc2FjdGlvbiBjYXNlIGFjY19hZGRfY2hh bmdlZF9kb20oKSBpcyB1cGRhdGluZyB0aGUgdmFsdWUgaW4gdGhlDQpjaGFuZ2VkX2RvbWFp biBkYXRhIG9mIHRoZSB0cmFuc2FjdGlvbiwgd2hpbGUgaW4gdGhlIG5vbi10cmFuc2FjdGlv biBjYXNlIC4uLg0KDQo+IA0KPj4gwqDCoMKgwqDCoCB9DQo+PiAtwqDCoMKgIGQtPm5iZW50 cnkgKz0gYWRkOw0KPj4gK8KgwqDCoCBkLT5hY2Nbd2hhdF0gPSBkb21haW5fYWNjX2FkZF9j aGsoZCwgd2hhdCwgYWRkLCBkb21pZCk7DQo+PiAtwqDCoMKgIHJldHVybiBkLT5uYmVudHJ5 Ow0KPj4gK8KgwqDCoCByZXR1cm4gZC0+YWNjW3doYXRdOw0KDQouLi4gdGhlIGRvbWFpbiBk YXRhIGlzIHVwZGF0ZWQgaGVyZS4NCg0KPj4gwqAgfQ0KPj4gwqAgaW50IGRvbWFpbl9uYmVu dHJ5X2luYyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdW5zaWduZWQgaW50IGRvbWlkKQ0K Pj4gwqAgew0KPj4gLcKgwqDCoCByZXR1cm4gKGRvbWFpbl9uYmVudHJ5X2FkZChjb25uLCBk b21pZCwgMSwgZmFsc2UpIDwgMCkgPyBlcnJubyA6IDA7DQo+PiArwqDCoMKgIHJldHVybiAo ZG9tYWluX2FjY19hZGQoY29ubiwgZG9taWQsIEFDQ19OT0RFUywgMSwgZmFsc2UpIDwgMCkN Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoCA/IGVycm5vIDogMDsNCj4+IMKgIH0NCj4+IMKg IGludCBkb21haW5fbmJlbnRyeV9kZWMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIHVuc2ln bmVkIGludCBkb21pZCkNCj4+IMKgIHsNCj4+IC3CoMKgwqAgcmV0dXJuIChkb21haW5fbmJl bnRyeV9hZGQoY29ubiwgZG9taWQsIC0xLCB0cnVlKSA8IDApID8gZXJybm8gOiAwOw0KPj4g K8KgwqDCoCByZXR1cm4gKGRvbWFpbl9hY2NfYWRkKGNvbm4sIGRvbWlkLCBBQ0NfTk9ERVMs IC0xLCB0cnVlKSA8IDApDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqAgPyBlcnJubyA6IDA7 DQo+PiDCoCB9DQo+PiDCoCBpbnQgZG9tYWluX25iZW50cnlfZml4KHVuc2lnbmVkIGludCBk b21pZCwgaW50IG51bSwgYm9vbCB1cGRhdGUpDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIGlu dCByZXQ7DQo+PiAtwqDCoMKgIHJldCA9IGRvbWFpbl9uYmVudHJ5X2FkZChOVUxMLCBkb21p ZCwgdXBkYXRlID8gbnVtIDogMCwgdXBkYXRlKTsNCj4+ICvCoMKgwqAgcmV0ID0gZG9tYWlu X2FjY19hZGQoTlVMTCwgZG9taWQsIEFDQ19OT0RFUywgdXBkYXRlID8gbnVtIDogMCwgdXBk YXRlKTsNCj4+IMKgwqDCoMKgwqAgaWYgKHJldCA8IDAgfHwgdXBkYXRlKQ0KPj4gwqDCoMKg wqDCoMKgwqDCoMKgIHJldHVybiByZXQ7DQo+PiDCoMKgwqDCoMKgIHJldHVybiBkb21pZF9p c191bnByaXZpbGVnZWQoZG9taWQpID8gcmV0ICsgbnVtIDogMDsNCj4+IMKgIH0NCj4+IC1p bnQgZG9tYWluX25iZW50cnkoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pDQo+PiArdW5zaWdu ZWQgaW50IGRvbWFpbl9uYmVudHJ5KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQ0KPj4gwqAg ew0KPj4gwqDCoMKgwqDCoCByZXR1cm4gZG9tYWluX2lzX3VucHJpdmlsZWdlZChjb25uKQ0K Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgID8gZG9tYWluX25iZW50cnlfYWRkKGNvbm4sIGNv bm4tPmlkLCAwLCB0cnVlKSA6IDA7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqAgPyBkb21h aW5fYWNjX2FkZChjb25uLCBjb25uLT5pZCwgQUNDX05PREVTLCAwLCB0cnVlKSA6IDA7DQo+ PiDCoCB9DQo+PiDCoCBzdGF0aWMgYm9vbCBkb21haW5fY2hrX3F1b3RhKHN0cnVjdCBkb21h aW4gKmRvbWFpbiwgaW50IG1lbSkNCj4+IEBAIC0xNTk3LDcgKzE2MTAsNyBAQCBzdGF0aWMg aW50IGRvbWFpbl9jaGVja19hY2NfaW5pdF9zdWIoY29uc3Qgdm9pZCAqaywgdm9pZCANCj4+ ICp2LCB2b2lkICphcmcpDQo+PiDCoMKgwqDCoMKgwqAgKiBJZiBldmVyeXRoaW5nIGlzIGNv cnJlY3QgaW5jcmVtZW50aW5nIHRoZSB2YWx1ZSBmb3IgZWFjaCBub2RlIHdpbGwNCj4+IMKg wqDCoMKgwqDCoCAqIHJlc3VsdCBpbiBkb20tPm5vZGVzIGJlaW5nIDAgYXQgdGhlIGVuZC4N Cj4+IMKgwqDCoMKgwqDCoCAqLw0KPj4gLcKgwqDCoCBkb20tPm5vZGVzID0gLWQtPm5iZW50 cnk7DQo+PiArwqDCoMKgIGRvbS0+bm9kZXMgPSAtZC0+YWNjW0FDQ19OT0RFU107DQo+PiDC oMKgwqDCoMKgIGlmICghaGFzaHRhYmxlX2luc2VydChkb21haW5zLCAmZG9tLT5kb21pZCwg ZG9tKSkgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHRhbGxvY19mcmVlKGRvbSk7DQo+PiBA QCAtMTY1Miw3ICsxNjY1LDcgQEAgc3RhdGljIGludCBkb21haW5fY2hlY2tfYWNjX2NiKGNv bnN0IHZvaWQgKmssIHZvaWQgKnYsIA0KPj4gdm9pZCAqYXJnKQ0KPj4gwqDCoMKgwqDCoCBp ZiAoIWQpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiAtwqDCoMKgIGQt Pm5iZW50cnkgKz0gZG9tLT5ub2RlczsNCj4+ICvCoMKgwqAgZC0+YWNjW0FDQ19OT0RFU10g Kz0gZG9tLT5ub2RlczsNCj4+IMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiDCoCB9DQo+PiBk aWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5oIA0KPj4gYi90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgNCj4+IGluZGV4IDZhMmI3NmE4NWIu LjgyNTljMTE0YjAgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaA0K Pj4gQEAgLTIxLDcgKzIxLDggQEANCj4+IMKgIGVudW0gYWNjaXRlbSB7DQo+PiDCoMKgwqDC oMKgIEFDQ19OT0RFUywNCj4+IC3CoMKgwqAgQUNDX1RSX07CoMKgwqAgLyogTnVtYmVyIG9m IGVsZW1lbnRzIHBlciB0cmFuc2FjdGlvbiBhbmQgZG9tYWluLiAqLw0KPj4gK8KgwqDCoCBB Q0NfVFJfTizCoMKgwqDCoMKgwqDCoCAvKiBOdW1iZXIgb2YgZWxlbWVudHMgcGVyIHRyYW5z YWN0aW9uIGFuZCBkb21haW4uICovDQo+IA0KPiBUaGUgY2h1cm4gaGVyZSBjb3VsZCBoYXZl IGJlZW4gYXZvaWRlZCBpZiB5b3UgYWRkIGEgIiwiIGV2ZW4gZm9yIHRoZSBlZG4gZWxlbWVu dCANCj4gYW5kIHByb3Blcmx5IGluZGVudGVkIHRoZSBjb21tZW50IGluIHRoZSBvcmlnaW5h bCBwYXRjaC4NCg0KT2theS4NCg0KPiANCj4gQWxzbywgd2FzIHRoZSBjb21tZW50IGluZGVu dGVkIHRvIGJlIHVwZGF0ZWQgdG8gcmVtb3ZlICJhbmQgZG9tYWluIj8NCg0KTm8sIHRoZSBu ZXcgaW5kZW50YXRpb24gd2FzIG1lYW50IHRvIGtlZXAgdGhlIGNvbW1lbnQgc3RhcnQgYWxp Z25lZCB3aXRoDQp0aGUgb25lIG9mIHRoZSBmb2xsb3dpbmcgbGluZS4NCg0KPiANCj4gDQo+ PiArwqDCoMKgIEFDQ19OID0gQUNDX1RSX04gLyogTnVtYmVyIG9mIGVsZW1lbnRzIHBlciBk b21haW4uICovDQoNCg0KSnVlcmdlbg0KDQo= --------------83PErUtvdrEtw4NkmzlEuJ10 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------83PErUtvdrEtw4NkmzlEuJ10-- --------------otswQTh47IyLSj9TWUbG4D18-- --------------RjwjnrO8Q1IPCodt90PRuk0x Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzV3EFAwAAAAAACgkQsN6d1ii/Ey8D YQf+LAB/0IruZ33YDGZOJiKJleztD9nOFG6c0QpLRzW0OEReMy/N2YAuKhEaW7JTC4AIxAiDKJGJ hwJpK20nbMmBLh2b2D3fYdImOJQL3NxPQN1OXJGG50+RyNUb/9bKFobZalaKSDofBiNJKEyCNsAL 2AElmWg/9WJsE2Jz/9ED2fH+NNC5raol2ChFv/So5gLFX7sD8ilIPkKLr+Ssa23ZZZqO8+CXOkWG pZp90kbzgU2t4sDrZDQYRlotlkXDBmK9cifU9n9Pdxq8q+z4rGSno9Fdad8Bg2R7swppl/eqap67 vHqhY+TPDXuUAYbpe/iF+97mpXQ+E0IsPBj5EzH71g== =IegM -----END PGP SIGNATURE----- --------------RjwjnrO8Q1IPCodt90PRuk0x-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:23:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:23:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498042.768834 (Exim 4.92) (envelope-from ) id 1pU4Gg-0000bj-Uu; Mon, 20 Feb 2023 11:23:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498042.768834; Mon, 20 Feb 2023 11:23:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4Gg-0000bc-QB; Mon, 20 Feb 2023 11:23:38 +0000 Received: by outflank-mailman (input) for mailman id 498042; Mon, 20 Feb 2023 11:23:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4Gf-0000bW-Op for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:23:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 033678b7-b111-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 12:23:35 +0100 (CET) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-433-qnWH611TO2SV0T7JDtHNpA-1; Mon, 20 Feb 2023 06:23:33 -0500 Received: by mail-wr1-f72.google.com with SMTP id r3-20020a5d6c63000000b002bff57fc7fcso226402wrz.19 for ; Mon, 20 Feb 2023 03:23:32 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id u13-20020a5d434d000000b002c55ec7f661sm154441wrr.5.2023.02.20.03.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 03:23:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 033678b7-b111-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676892214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JGvEUYyDyInAU1qTOkUUwH1+5Pn5/FfAg09zLJh1EcU=; b=LJ4z/ydlreQO2yAtfBGq5VjJCLgp297eaAHVbIuZOwUBIi2Z0QExyTv6nd/ARNoqMqdjn1 /zMysMRY0+wYzE6vrOvE/OCyAU5zz2zZy4+k6HBeuFrxSJpfHYMdYB4k5d6NnCqUnBPAwg e5+N+BoK+DPErZpuJFnQdtZCGVRIc3E= X-MC-Unique: qnWH611TO2SV0T7JDtHNpA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JGvEUYyDyInAU1qTOkUUwH1+5Pn5/FfAg09zLJh1EcU=; b=oegvsEGqHltWpK6Y2TqKTad6FcqsGkSTlgmXXy8koh+P2eGHkfJkQIdRXQVK4HGVVC 3/OeUAlsS4g9TgxjXAS5ez/CVK0qqkabx0E6nrmeQjpN9Ms5RMTxRCmh+SrFy7KeGezo AeruYErZC4DcURitDuHotaMv90DYZ+GAfyNYq9azt52y8Ss7GsuVzUksbSRnuphS9NO7 Kn8pzKQgd7SYX0Yds+pSn/RCT7U8JtQn3BfnhjL64wIONTRdFlK3W0edTUNsAh8yrvpn acHZubZh+peigCSnr+dSorbhmfKEXHq2Ivb89cou+joHqZLC2ycg/MExoujim3i2M0YY dvzg== X-Gm-Message-State: AO0yUKUT843AaoTZa4kJrymXIEX+ZLyNMLXZecEZJNsblRtTXjPuVQ6K j47Ms2Fq3ibXQw/4VKYwM21w2iiSNNX4yiyEOI6xTD/QU6CUX/+6kRQXCxUxaK0o37HtMvaEjGR tb0c3Ua44WMcOYvtSODX3gMfmPAQ= X-Received: by 2002:adf:e889:0:b0:2bf:ae19:d8e4 with SMTP id d9-20020adfe889000000b002bfae19d8e4mr1431228wrm.16.1676892211953; Mon, 20 Feb 2023 03:23:31 -0800 (PST) X-Google-Smtp-Source: AK7set8MwtYqrZBvXsoQ9yPZN/bwu32QfvZtBFBM6ley7E2vAkMmUmM+SZmaWRHMAwPacrP/Dgjyyg== X-Received: by 2002:adf:e889:0:b0:2bf:ae19:d8e4 with SMTP id d9-20020adfe889000000b002bfae19d8e4mr1431211wrm.16.1676892211619; Mon, 20 Feb 2023 03:23:31 -0800 (PST) Message-ID: Date: Mon, 20 Feb 2023 12:23:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230218211433.26859-14-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18.02.23 22:14, Rick Edgecombe wrote: > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these unusual properties is that shadow stack memory is writable, > but only in limited ways. These limits are applied via a specific PTE > bit combination. Nevertheless, the memory is writable, and core mm code > will need to apply the writable permissions in the typical paths that > call pte_mkwrite(). > > In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting > that they are special shadow stack flavor of writable memory. So make > pte_mkwrite() take a VMA, so that the x86 implementation of it can know to > create regular writable memory or shadow stack memory. > > Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). > > No functional change. > > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-alpha@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-csky@vger.kernel.org > Cc: linux-hexagon@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: loongarch@lists.linux.dev > Cc: linux-m68k@lists.linux-m68k.org > Cc: Michal Simek > Cc: Dinh Nguyen > Cc: linux-mips@vger.kernel.org > Cc: openrisc@lists.librecores.org > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-um@lists.infradead.org > Cc: xen-devel@lists.xenproject.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Tested-by: Pengfei Xu > Suggested-by: David Hildenbrand > Signed-off-by: Rick Edgecombe > > --- > Hi Non-x86 Arch’s, > > x86 has a feature that allows for the creation of a special type of > writable memory (shadow stack) that is only writable in limited specific > ways. Previously, changes were proposed to core MM code to teach it to > decide when to create normally writable memory or the special shadow stack > writable memory, but David Hildenbrand suggested[0] to change > pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be > moved into x86 code. > > Since pXX_mkwrite() is defined in every arch, it requires some tree-wide > changes. So that is why you are seeing some patches out of a big x86 > series pop up in your arch mailing list. There is no functional change. > After this refactor, the shadow stack series goes on to use the arch > helpers to push shadow stack memory details inside arch/x86. > > Testing was just 0-day build testing. > > Hopefully that is enough context. Thanks! > > [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com/#t > > v6: > - New patch > --- > Documentation/mm/arch_pgtable_helpers.rst | 9 ++++++--- > arch/alpha/include/asm/pgtable.h | 6 +++++- > arch/arc/include/asm/hugepage.h | 2 +- > arch/arc/include/asm/pgtable-bits-arcv2.h | 7 ++++++- > arch/arm/include/asm/pgtable-3level.h | 7 ++++++- > arch/arm/include/asm/pgtable.h | 2 +- > arch/arm64/include/asm/pgtable.h | 4 ++-- > arch/csky/include/asm/pgtable.h | 2 +- > arch/hexagon/include/asm/pgtable.h | 2 +- > arch/ia64/include/asm/pgtable.h | 2 +- > arch/loongarch/include/asm/pgtable.h | 4 ++-- > arch/m68k/include/asm/mcf_pgtable.h | 2 +- > arch/m68k/include/asm/motorola_pgtable.h | 6 +++++- > arch/m68k/include/asm/sun3_pgtable.h | 6 +++++- > arch/microblaze/include/asm/pgtable.h | 2 +- > arch/mips/include/asm/pgtable.h | 6 +++--- > arch/nios2/include/asm/pgtable.h | 2 +- > arch/openrisc/include/asm/pgtable.h | 2 +- > arch/parisc/include/asm/pgtable.h | 6 +++++- > arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- > arch/powerpc/include/asm/book3s/64/pgtable.h | 4 ++-- > arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- > arch/powerpc/include/asm/nohash/32/pte-8xx.h | 2 +- > arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- > arch/riscv/include/asm/pgtable.h | 6 +++--- > arch/s390/include/asm/hugetlb.h | 4 ++-- > arch/s390/include/asm/pgtable.h | 4 ++-- > arch/sh/include/asm/pgtable_32.h | 10 ++++++++-- > arch/sparc/include/asm/pgtable_32.h | 2 +- > arch/sparc/include/asm/pgtable_64.h | 6 +++--- > arch/um/include/asm/pgtable.h | 2 +- > arch/x86/include/asm/pgtable.h | 6 ++++-- > arch/xtensa/include/asm/pgtable.h | 2 +- > include/asm-generic/hugetlb.h | 4 ++-- > include/linux/mm.h | 2 +- > mm/debug_vm_pgtable.c | 16 ++++++++-------- > mm/huge_memory.c | 6 +++--- > mm/hugetlb.c | 4 ++-- > mm/memory.c | 4 ++-- > mm/migrate_device.c | 2 +- > mm/mprotect.c | 2 +- > mm/userfaultfd.c | 2 +- > 42 files changed, 106 insertions(+), 69 deletions(-) That looks painful but IMHO worth it :) Acked-by: David Hildenbrand -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Mon Feb 20 11:51:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 11:51:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498053.768844 (Exim 4.92) (envelope-from ) id 1pU4hM-0004Xx-7M; Mon, 20 Feb 2023 11:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498053.768844; Mon, 20 Feb 2023 11:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4hM-0004Xq-3k; Mon, 20 Feb 2023 11:51:12 +0000 Received: by outflank-mailman (input) for mailman id 498053; Mon, 20 Feb 2023 11:51:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4hK-0004Xk-9n for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 11:51:10 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db38e165-b114-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 12:51:07 +0100 (CET) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Feb 2023 06:51:04 -0500 Received: from DM6PR03MB5372.namprd03.prod.outlook.com (2603:10b6:5:24f::15) by PH7PR03MB6941.namprd03.prod.outlook.com (2603:10b6:510:156::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 11:51:01 +0000 Received: from DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::29f6:a062:e2ad:9478]) by DM6PR03MB5372.namprd03.prod.outlook.com ([fe80::29f6:a062:e2ad:9478%7]) with mapi id 15.20.6111.019; Mon, 20 Feb 2023 11:51:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db38e165-b114-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676893867; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ob9odbpqZHG9JA0edO2cGNMgzUBhXePDeMGOpIHsSj8=; b=hkNrlaxShbj+kca5MlrDBRot8CCU3C/ol66dyIR5z25t6ii5NxTRo9w3 liSUOIxnHgwD6S9Ol1Ih5KFBHC3WbJrhp76DDVTyBG2bJ8v1sA9HoEzv/ ImzgzF9BWDzjLXkai38kA33E0nIXaa3rNidi1HFRhra4eSypz/eV2jUoo g=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 97739208 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:52cwTqrzL22Gg5+0yX22YnGNgq1eBmIiZBIvgKrLsJaIsI4StFCzt garIBnSbvneMzD0KogjaIu18koA7Zbdz4NlSVNupS0xEn8QpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSFNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAB4KURrEqMCQ+ZCqG/Ux29UEKPb6LpxK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWPEjCJbZw9ckKwv GXd5CL9Cx4XLsOWzT6t+XOwnO7f2yj8Xer+EZXpqaEx0QfLlgT/DjUXbXKh+fiHknWDfIl1F GY3ww8HjZktoRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC9 HWEgtfoDjxHq6CORDSW8bL8hSy2ETgYKykFfyBsZQgC5cPqrMcsjxbMZtF5GaWxg5v+HjSY/ tyRhC03hrFWgctV0ay+pArDm2j1+cKPSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOjBCyqtWNEEvWNSIg== IronPort-HdrOrdr: A9a23:R6eFnKssOzXLDNBxkySQjF0h7skDTNV00zEX/kB9WHVpm5qj5q eTdZMgpHzJYVcqOE3I9urqBEDtexnhHP1OgLX5X43MYOC8ghrNEGgK1+KL/9SHIUDDH4Vmu5 uIHZITNDVeZ2IK6/oTTGODYrQdKHjsytHMudvj X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97739208" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WifHBWIoJ3Ky1qHBoDEvJgV/sHXM14oj2++F6Mrk2zx79PDywC0qHS6KhhIcm4cKamVjpiJ0UDwXt5nGpYBxPJRrzia8jvuNbcI4FLLYUKEO0pNwXv+UosUXm60C0yicq18Z2dcbkq7lUsQQemBc7LBp4+mcWQmG4lFZL6No62nbIBqPivFnOkztdRTfGmW34kGiy89HE+Gme7b0gv8hTswgcvVjNPnUPd2lQczgmGcHtsY28rCKngWfByK2C5vCMH3sy/sakPOxOe6OWPZWBu3tehgzR+kJcVYOOTgdxXhGVtujwyOcWvllYucgkveE34KecwEATRq0NDTZ3miFug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ob9odbpqZHG9JA0edO2cGNMgzUBhXePDeMGOpIHsSj8=; b=fuaQVzsyGnN9gTMYSNwHwc6VssutjtwG7XFPmG+mRvFSSoxiPkFxauLqTii3MehTgFyR+q2UznvMDKTS4n/MG+zeAALLOSW/GW/dzusBqkE42fmKNrK9WO1WMNjuUy9iBybU0T1OaKiYsfN+BqIhvhjzzPu6VQNg/vPtJjnTFTUeTaKPxW4Wnf90CVqkzy7mm5vnv2IQW74gXaz7Moc49A2bCpRGn8Z7zERImBhEOR4TQ7gmyENEqqad1d7gPOpOacEKhBFcYXVOU9IL1BUVxAkXSLvB0wlFVSJcHwY8bJunzDOImBt5X9K6PQPYLUld2AMLXvbLa51wkaud6qgEfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ob9odbpqZHG9JA0edO2cGNMgzUBhXePDeMGOpIHsSj8=; b=d21eS4cdoZUC3pgOetPYG68GMelbnhlkpnHtCeDe0Uyuzm4YguRHbdTkEfozc0siUo4SrX9ZctqARg79dhsUGDJei9YQ/Y9gkcG1GJa1ol8AJJW38TvAA1OkE8Toi2lH0ibhOuKCEUuVk42tIOh14SYM0NDs9mTqJ3XY6bXC1fY= From: Ross Lagerwall To: Andrew Cooper , Xen-devel CC: Jan Beulich , Roger Pau Monne , Wei Liu , Konrad Rzeszutek Wilk Subject: Re: [PATCH] x86/asm: ELF metadata for simple cases Thread-Topic: [PATCH] x86/asm: ELF metadata for simple cases Thread-Index: AQHZRRswUrrjJOPJkEyhnDj36yzKjK7Xt08b Date: Mon, 20 Feb 2023 11:51:01 +0000 Message-ID: References: <20230220110439.1518972-1-andrew.cooper3@citrix.com> In-Reply-To: <20230220110439.1518972-1-andrew.cooper3@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR03MB5372:EE_|PH7PR03MB6941:EE_ x-ms-office365-filtering-correlation-id: e87b19dc-bc90-4df7-364e-08db1338bd26 x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ytFlv72KbEUG/WR1qZZAMaZPQMgZWpHhURGzJC8qaaeqKHUe3liSYUP9LwnpelVWVuU0g2eiK4oh1flSO3RvXu1dqwvvi1UsOLad/Voqrr55fD/zy7KgiW+2a65zI/4EUISNlyaSavndOaWkYZ2xxHvpUQquc/cxTPT+D/Ikf3I4KvorSdnX0+Dbe3c0Vqc5YtEoDaBOt2KujtbKlSHqpPTWs4UZ55lwjdjrVDWF/UhdaHq1dvSd7th/TuFC3fGUqo4XUfipWIZS9m/StkqXMAA0UDjayuxa0QZfuIEHk6AifY2q8Y/OF+NsZDMqfRDInDcUjKjnW3/ZLPYXAtNVW1ykyJdKNHUXMB7+YTW1ufjcO4jb34SPg3M3AfxXHCxAywSXYVqc/dImM2E8KwthNRF7FK43TArjBi07lDy/3a9RNtVK+9V61K5c1FpYcyyCR3mr9Ur17mDATnEfNn7Dji4QmYBHeaQKAjX982zNvIgpr8Amatr65nBkmWuhelHmvzX4A9t6uFEnfx2V8C0y6nuzNOwlE8K1TnhWgQe+x9vLHJEfj2h2TJeyxA4eUqICiVYv6xCOZIRc6DuxBVx8AQDlUMloMLDnPoms1LIZjhHvS9cohVrhb0i83v4Sn7p4kkYM4gmdIaSj9CnQvN31XoyTriJ6bQc7x0VY9s3BCsRZeU83pzKH8g0x/16RCfW/fYiuYAlSBK48ICEUt8raqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR03MB5372.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199018)(83380400001)(86362001)(38100700002)(8936002)(5660300002)(122000001)(2906002)(110136005)(38070700005)(55016003)(33656002)(82960400001)(53546011)(7696005)(8676002)(6506007)(478600001)(66446008)(76116006)(66556008)(91956017)(71200400001)(44832011)(52536014)(66476007)(66946007)(64756008)(4326008)(54906003)(186003)(41300700001)(26005)(9686003)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6PZ46aknnG0ChImgfE0mn0EuqvSq7AHc5MqfZUc7CnMv+W6cir/UDCd7FK?= =?iso-8859-1?Q?dH7byE2lElvjsxaaObujjPyDzDF4IUNWuMhHS6yZer+lOzg2+ah2tSR1+1?= =?iso-8859-1?Q?pLmaPnAQdp+QfYLeSiZQ8OwpOvFfKjzm6UY28S2sylxiIs/ITzwfaRH0Hj?= =?iso-8859-1?Q?HOv6AUpFLVzw17GyCK62XycW0nanGQKTF8Ws2DWhmcdmtjZd5jorQJQFcP?= =?iso-8859-1?Q?7W+jSsa9Kfvow4Uu//N7dPcIpmQGphYLxVA7dk/+FL4cc8GMGT17tBB0oR?= =?iso-8859-1?Q?DozV5oeFGe5ytU8kql+cBHMVqE4lXGOMEu62V3j8vMk1UJaduCDuXCRJQj?= =?iso-8859-1?Q?yFg/p6Xuw/Uuov5Ye/Cz3V8BhsntI8gQaIGdqD1o4N0ZzN8nxJryJlpqfS?= =?iso-8859-1?Q?HaOTIYW6E2bY6n+0dJDDuMD41OizMIeYjUlST0dXZnmsirS1O9HWsHQeJI?= =?iso-8859-1?Q?mbsy6QigHW5LV3H9MBh/CaKrPtQYVwNcITTI+kqFVQpjGcKBF1SvteBxMx?= =?iso-8859-1?Q?/b45Z7ZAGpF4tJd6I09+BgaKVszQLcLwrrouRweczrrs+Urjk4XgWFhopz?= =?iso-8859-1?Q?694g+ScCyb7ILFxnqGLYbM0yGlUJKZ3lM8mAOylJd8eY5/j5lCIMa7ItH6?= =?iso-8859-1?Q?/EBBNdJ/gknrUS67QGvRIa3X9S4UgqWJUhoJzIt/JgihfgWXTyOZ898PPp?= =?iso-8859-1?Q?0mhaemXVeUpKp9bX7sfnuEQVEgY9+9pDkO/KqZ3JOhEyMpN1qeaUc+llxl?= =?iso-8859-1?Q?BwQxYkqtEynZD2ZG7hMYkK2IrRY6yBNMgr0oYI31S+QBM/HpSKrTPO5cCL?= =?iso-8859-1?Q?MWqm3n4ZDi5lKuojvFMI5KmC05TABcUoZlostdLCMTP1lssC2xiTEGd7Ky?= =?iso-8859-1?Q?dKGZO/7SFuwVQCtKpBX+NBUt+NlAmbQGgCmsm0VRwuz8mWLIgc1OWUSkco?= =?iso-8859-1?Q?Dg0ZeTomV/ZjbOA+9hfWW6UdEKO5YyKVfUQXIez6E6yc2rWM/E5p1cdArz?= =?iso-8859-1?Q?8hqSi/ZnvOtWNR+8nEVb0c2uhO/YFCHQe2UVHncpIaIca3y7mnHV5HVi5T?= =?iso-8859-1?Q?UX9yDA4uGRS5ZNIWkdKKowxbvsmoScEuKPcpiyiM7lYO8WTGZfioKB0Czt?= =?iso-8859-1?Q?BBbXLVLdQc5R6FtVbEHcPPOviXi8ywmetdG7Iz5Y05mDAJHbw6Ex3fSBm7?= =?iso-8859-1?Q?jFU8yz6D/a+PB05F/Mh1NN8FOboocACHLEIMChhaYU0vTwBnkeL4JAf2fS?= =?iso-8859-1?Q?g40CFUxjSSWS1BhAOwlYgtV4+slw89n+vvizmJh4TjQjAa81aj0bpC1PoA?= =?iso-8859-1?Q?vW0Iy/H49kduzwWi6ANbFsmT8nlZfE+vX7F0sau0G4kohw2pns9O1S6Mmz?= =?iso-8859-1?Q?Cj69SnqJ7YXYHhj9YWAs9JASUa4vN27aAa6zwANxbtKW13VC11IGWf44DJ?= =?iso-8859-1?Q?C9u6nF8K/XUqtNk/fRVTAzs2zhkfnBrbHLjGOFM+l2n9pX7/7FSlyw360f?= =?iso-8859-1?Q?U651Z0w2lKoc25KSB05X4/o+HY3j2esZY8Uae+57CAvO2ivSaByRKI2l9d?= =?iso-8859-1?Q?foOVNVNoJWJHBU3I3H+OYubJtkaoZUps6jZrtK4ShXoctMIQBC7cKxsGNl?= =?iso-8859-1?Q?U8ZF2uYys/eIxDa5KU0HrR2ezZFgOR/xJM?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vTWJasMIK+UeZ/rY8fClWY5gE2H7XorwPQwxAHUWLnksbWX/zYa1tq601tk/r6nk6J/ZYW0dBihtbopgPu60ljWNWzIR1+cEzRFf7aMsRl3G3ET1hOMk09qadixeG3pM8nV/vM7S2PIZ6tzLGKiFVHwyBnuPyPmuIcihK/sm4hIjoCvyL6naCYAaU1bTYvwEbA7IeLzbFjesjRb9EPJsPvEuM2kitrVm13JPQIOmp0SykAMwQHeW23dTjL2hyfrbx375hni/B4g9MTqaU9NcNF2wNnfqm7vc8hfVIkdBLjAPrHZqrNKgzbIU7vAoK1OY+Ith9ISpG9okcFJtwqAeeaWpfZa3Dww9Igcf6Vg1dqOdrdCbeMnjVNDwECmwcVvFf53IahyQKa1BlOzaXjVeN4RC/sI4eJXluHeTb+Vuhb4VAZHZLewASaItzx92/nZ8l3P2D/eHRn+sc9Bysh0wRhqD7KzlvUwSrjuZuNZI6y3V7RVzuBeiQYtX03aEE6ckFHLSOUoCq9MAC7huIygSzfnfR4DTEcT7XcTLonMgw2rfaLKyIZruxgb3cKZBbtTk828jm+IjrcdFb+jIH5u1OL6mXe0B/NDC19pYL/BsPsIEQnCryQBNlD5NpufxUyLx9ydIeFQL46DXGyKwttKa6wQaSvDvZSn0RGi1dhUVfTwQDvLeqYP0Vxnqvp22uv3m4feNDX6YEa3k4J1g0OBkolpfVXl26/mUvYNRuMc5hnQAfqOXUzx6bsuPypcfwmKXdXnVE6+uK5kNxPAfx3FqFYKea2i0eybGz2AaIdk0wq3ch3bt+3YrUL7kaWVnjRqOaU5sWJ163v4HroC4XuZ26XBOMVwbvX1SSCsfCkSYZcM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5372.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87b19dc-bc90-4df7-364e-08db1338bd26 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 11:51:01.5238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BaQMXSed2gzPqs5PT/KLfH26MXK7O2jlq3euSWVXkrq+WEY2CKEdbFDtXMZbPwBqAyordchd47nfxk1hn/B9PanDan4JLaVyGrWsmoAT9SQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB6941 > From: Andrew Cooper =0A= > Sent: Monday, February 20, 2023 11:04 AM=0A= > To: Xen-devel =0A= > Cc: Andrew Cooper ; Jan Beulich ; Roger Pau Monne ; Wei Liu ; Konrad= Rzeszutek Wilk ; Ross Lagerwall =0A= > Subject: [PATCH] x86/asm: ELF metadata for simple cases =0A= > =A0=0A= > This is generally good practice, and necessary for livepatch binary diffi= ng to=0A= > work.=0A= > =0A= > With this, livepatching of the SVM entry path works.=A0 The only complica= tion is=0A= > with svm_stgi_label which is only used by oprofile to guestimate (not=0A= > completely correctly) when an NMI hit guest context.=0A= > =0A= > Livepatching of VMX is still an open question, because the logic doesn't = form=0A= > anything remotely resembling functions.=A0 Both code fragments jump into = each=0A= > other so need to be updated in tandem.=A0 Also, both code fragment entrie= s need=0A= > trampolines in the case that patching actually occurs.=A0 For now, just t= reat it=0A= > as a single function.=0A= =0A= If it is treated as two functions and both functions are always included in= =0A= the live patch, would that work?=0A= =0A= > =0A= > Signed-off-by: Andrew Cooper =0A= > ---=0A= > CC: Jan Beulich =0A= > CC: Roger Pau Monn=E9 =0A= > CC: Wei Liu =0A= > CC: Konrad Rzeszutek Wilk =0A= > CC: Ross Lagerwall =0A= > ---=0A= > =A0xen/arch/x86/clear_page.S=A0=A0=A0 | 3 +++=0A= > =A0xen/arch/x86/copy_page.S=A0=A0=A0=A0 | 3 +++=0A= > =A0xen/arch/x86/hvm/svm/entry.S | 3 +++=0A= > =A0xen/arch/x86/hvm/vmx/entry.S | 3 +++=0A= > =A04 files changed, 12 insertions(+)=0A= > =0A= > diff --git a/xen/arch/x86/clear_page.S b/xen/arch/x86/clear_page.S=0A= > index d9d524c79ecd..5b5622cc526f 100644=0A= > --- a/xen/arch/x86/clear_page.S=0A= > +++ b/xen/arch/x86/clear_page.S=0A= > @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2)=0A= > =A0=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 sfence=0A= > =A0=A0=A0=A0=A0=A0=A0=A0 ret=0A= > +=0A= > +=A0=A0=A0=A0=A0=A0=A0 .type clear_page_sse2, @function=0A= > +=A0=A0=A0=A0=A0=A0=A0 .size clear_page_sse2, . - clear_page_sse2=0A= =0A= Would it be worth wrapping this pattern in a macro?=0A= =0A= Ross= From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:00:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:00:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498062.768854 (Exim 4.92) (envelope-from ) id 1pU4qP-0006Jb-9r; Mon, 20 Feb 2023 12:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498062.768854; Mon, 20 Feb 2023 12:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qP-0006JU-7F; Mon, 20 Feb 2023 12:00:33 +0000 Received: by outflank-mailman (input) for mailman id 498062; Mon, 20 Feb 2023 12:00:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qO-0006JO-1D for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:00:32 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 289347f1-b116-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 13:00:29 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 289347f1-b116-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676894429; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Yj+dJsOYesHuHvPclsO5KxRo4OfXGvABLY3cfH2A2n4=; b=JrpJVJzhM44Fv0WHClHvTUYaq6XDdE2lzlNaQ0aX0NeHColx4jQiO9v8 PrqR8KZdgz7M27LfJOl12YFqY3zJPZEwOZ4ZIeNy5+JLnttTSn6gkJcyX FYXc3j9H8lvY2ZbQu27HJWXGLm87PV62UbVg9bLFNZRZVGcQcHnv1nPRR w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97740134 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:t++ppKgVpVIYYWgFQ6d/A9CIX161SRAKZh0ujC45NGQN5FlHY01je htvXziAbq3YMGOgeIonPYXk9UoBvpHRy9ZkSQFuqiljEi8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWGzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQjKHcVVVeSndm6xYmQZMY2rMAocPvCadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XWjtUsl+K44Ew5HDe1ldZ27nxKtvFPNeNQK25m27J+ T2apz2iXnn2MvSm+32BsVyB3tX1mC/ne4wMCprj8s5D1Qj7Kms7V0RNCArTTeOCol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJ4Mcc39QWMwar8+BuCCy4PSTspQMMinN87Q3otz FDht9DuAyZmvPuKSHae3rCOpDi2NG4eKmpqWMMfZVJbuZ+5+th110+RCI85S8ZZk+EZBxnLw 3eSl28vnY4fiPUg+Yrh11TM3wCF882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4 iFaxpH2APQmSMjUyXfTGLll8KSBva7tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj KM+VGpsCH5v0JmCN/Afj2GZUZ5CIU3c+TPND6m8Uza2SsItHDJrBQk3DaJq40jjkVI3jYY0M oqBfMCnAB4yUPo4kmrtHrlGjOBznUjSIF8/orihknyaPUe2PibJGd/pznPTBgzG0E90iFqMq IsOXyd74x5eTPf/ckHqHX07dDg3wYwALcmu8aR/L7fTSjeK7Ul9U5c9N5t9Id0690mU/8+Ul kyAtrhwkgSm1SCXdlnbMxiOqtrHBP5CkJ7yBgR0VX7A5pTpSd31hEvDX/PbpYUaydE= IronPort-HdrOrdr: A9a23:80dKzalRPaauh40nvAqaPSzbiQjpDfIi3DAbv31ZSRFFG/Fw9v rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK d8Y+xfJbTLfDxHZB/BkWuFL+o= X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97740134" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH 2/3] x86/entry: Rework the exception entrypoints Date: Mon, 20 Feb 2023 11:59:55 +0000 Message-ID: <20230220115956.1522728-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220115956.1522728-1-andrew.cooper3@citrix.com> References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This fixes two issues preventing livepatching. First, that #PF and NMI fall through into other functions, and second to add ELF metadata. Use a macro to generate the entrypoints programatically, rather than opencoding them all. Switch to using the architectural short names. Remove the DECLARE_TRAP_HANDLER{,_CONST}() infrastructure. Only NMI/#MC are referenced externally (and NMI will cease to be soon, as part of adding FRED support). Move the entrypoint declarations into the respective traps.c where they're used, rather than keeping them visible across ~all of Xen. Drop the long-stale comment at the top of init_idt_traps(). It's mostly discussing a 32bit Xen. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Konrad Rzeszutek Wilk CC: Ross Lagerwall --- xen/arch/x86/include/asm/processor.h | 34 +------ xen/arch/x86/pv/traps.c | 2 + xen/arch/x86/traps.c | 70 ++++++++----- xen/arch/x86/x86_64/entry.S | 147 +++++++++------------------ 4 files changed, 95 insertions(+), 158 deletions(-) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index b95d2483212a..8725e0df11e9 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -476,38 +476,8 @@ extern void mtrr_bp_init(void); void mcheck_init(struct cpuinfo_x86 *c, bool_t bsp); -#define DECLARE_TRAP_HANDLER(_name) \ - void _name(void); \ - void do_ ## _name(struct cpu_user_regs *regs) -#define DECLARE_TRAP_HANDLER_CONST(_name) \ - void _name(void); \ - void do_ ## _name(const struct cpu_user_regs *regs) - -DECLARE_TRAP_HANDLER(divide_error); -DECLARE_TRAP_HANDLER(debug); -DECLARE_TRAP_HANDLER_CONST(nmi); -DECLARE_TRAP_HANDLER(int3); -DECLARE_TRAP_HANDLER(overflow); -DECLARE_TRAP_HANDLER(bounds); -DECLARE_TRAP_HANDLER(invalid_op); -DECLARE_TRAP_HANDLER(device_not_available); -DECLARE_TRAP_HANDLER(double_fault); -DECLARE_TRAP_HANDLER(invalid_TSS); -DECLARE_TRAP_HANDLER(segment_not_present); -DECLARE_TRAP_HANDLER(stack_segment); -DECLARE_TRAP_HANDLER(general_protection); -DECLARE_TRAP_HANDLER(page_fault); -DECLARE_TRAP_HANDLER(early_page_fault); -DECLARE_TRAP_HANDLER(coprocessor_error); -DECLARE_TRAP_HANDLER(simd_coprocessor_error); -DECLARE_TRAP_HANDLER_CONST(machine_check); -DECLARE_TRAP_HANDLER(alignment_check); -DECLARE_TRAP_HANDLER(entry_CP); - -DECLARE_TRAP_HANDLER(entry_int82); - -#undef DECLARE_TRAP_HANDLER_CONST -#undef DECLARE_TRAP_HANDLER +void do_nmi(const struct cpu_user_regs *regs); +void do_machine_check(const struct cpu_user_regs *regs); void trap_nop(void); diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 97fe54b5ee5a..21f4860f7832 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -144,6 +144,8 @@ static void cf_check nmi_softirq(void) *v_ptr = NULL; } +void entry_int82(void); + void __init pv_trap_init(void) { #ifdef CONFIG_PV32 diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 7fb0c54f884e..bfd335777177 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -2184,35 +2184,49 @@ void percpu_traps_init(void) wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); } +/* Exception entries */ +void entry_DE(void); +void entry_DB(void); +void entry_NMI(void); +void entry_BP(void); +void entry_OF(void); +void entry_BR(void); +void entry_UD(void); +void entry_NM(void); +void entry_DF(void); +void entry_TS(void); +void entry_NP(void); +void entry_SS(void); +void entry_GP(void); +void early_page_fault(void); +void entry_PF(void); +void entry_MF(void); +void entry_AC(void); +void entry_MC(void); +void entry_XM(void); +void entry_CP(void); + void __init init_idt_traps(void) { - /* - * Note that interrupt gates are always used, rather than trap gates. We - * must have interrupts disabled until DS/ES/FS/GS are saved because the - * first activation must have the "bad" value(s) for these registers and - * we may lose them if another activation is installed before they are - * saved. The page-fault handler also needs interrupts disabled until %cr2 - * has been read and saved on the stack. - */ - set_intr_gate(TRAP_divide_error,÷_error); - set_intr_gate(TRAP_debug,&debug); - set_intr_gate(TRAP_nmi,&nmi); - set_swint_gate(TRAP_int3,&int3); /* usable from all privileges */ - set_swint_gate(TRAP_overflow,&overflow); /* usable from all privileges */ - set_intr_gate(TRAP_bounds,&bounds); - set_intr_gate(TRAP_invalid_op,&invalid_op); - set_intr_gate(TRAP_no_device,&device_not_available); - set_intr_gate(TRAP_double_fault,&double_fault); - set_intr_gate(TRAP_invalid_tss,&invalid_TSS); - set_intr_gate(TRAP_no_segment,&segment_not_present); - set_intr_gate(TRAP_stack_error,&stack_segment); - set_intr_gate(TRAP_gp_fault,&general_protection); - set_intr_gate(TRAP_page_fault,&early_page_fault); - set_intr_gate(TRAP_copro_error,&coprocessor_error); - set_intr_gate(TRAP_alignment_check,&alignment_check); - set_intr_gate(TRAP_machine_check,&machine_check); - set_intr_gate(TRAP_simd_error,&simd_coprocessor_error); - set_intr_gate(X86_EXC_CP, entry_CP); + set_intr_gate (X86_EXC_DE, entry_DE); + set_intr_gate (X86_EXC_DB, entry_DB); + set_intr_gate (X86_EXC_NMI, entry_NMI); + set_swint_gate(X86_EXC_BP, entry_BP); + set_swint_gate(X86_EXC_OF, entry_OF); + set_intr_gate (X86_EXC_BR, entry_BR); + set_intr_gate (X86_EXC_UD, entry_UD); + set_intr_gate (X86_EXC_NM, entry_NM); + set_intr_gate (X86_EXC_DF, entry_DF); + set_intr_gate (X86_EXC_TS, entry_TS); + set_intr_gate (X86_EXC_NP, entry_NP); + set_intr_gate (X86_EXC_SS, entry_SS); + set_intr_gate (X86_EXC_GP, entry_GP); + set_intr_gate (X86_EXC_PF, early_page_fault); + set_intr_gate (X86_EXC_MF, entry_MF); + set_intr_gate (X86_EXC_AC, entry_AC); + set_intr_gate (X86_EXC_MC, entry_MC); + set_intr_gate (X86_EXC_XM, entry_XM); + set_intr_gate (X86_EXC_CP, entry_CP); /* Specify dedicated interrupt stacks for NMI, #DF, and #MC. */ enable_each_ist(idt_table); @@ -2231,7 +2245,7 @@ void __init trap_init(void) unsigned int vector; /* Replace early pagefault with real pagefault handler. */ - set_intr_gate(TRAP_page_fault, &page_fault); + set_intr_gate(X86_EXC_PF, entry_PF); pv_trap_init(); diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S index ae012851819a..6d7c15ce4371 100644 --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -142,6 +142,50 @@ process_trap: .section .text.entry, "ax", @progbits +.macro IDT_ENTRY vec label handler +ENTRY(\label) + ENDBR64 + .if ((1 << \vec) & X86_EXC_HAVE_EC) == 0 + push $0 + .endif + movl $\vec, 4(%rsp) + jmp \handler + + .type \label, @function + .size \label, . - \label +.endm + +.macro ENTRY vec label + IDT_ENTRY \vec \label handle_exception +.endm +.macro ENTRY_IST vec label + IDT_ENTRY \vec \label handle_ist_exception +.endm + + +ENTRY X86_EXC_DE entry_DE /* 00 Divide Error */ +ENTRY_IST X86_EXC_DB entry_DB /* 01 Debug Exception */ +ENTRY_IST X86_EXC_NMI entry_NMI /* 02 Non-Maskable Interrupt */ +ENTRY X86_EXC_BP entry_BP /* 03 Breakpoint (int3) */ +ENTRY X86_EXC_OF entry_OF /* 04 Overflow (into) */ +ENTRY X86_EXC_BR entry_BR /* 05 Bound Range */ +ENTRY X86_EXC_UD entry_UD /* 06 Undefined Opcode */ +ENTRY X86_EXC_NM entry_NM /* 07 No Maths (Device Not Present) */ +/* _IST X86_EXC_DF entry_DF 08 Double Fault - Handled specially */ +/* X86_EXC_CSO entry_CSO 09 Coprocessor Segment Override - Autogen */ +ENTRY X86_EXC_TS entry_TS /* 10 Invalid TSS */ +ENTRY X86_EXC_NP entry_NP /* 11 Segment Not Present */ +ENTRY X86_EXC_SS entry_SS /* 12 Stack Segment Fault */ +ENTRY X86_EXC_GP entry_GP /* 13 General Protection Fault */ +ENTRY X86_EXC_PF entry_PF /* 14 Page Fault */ +/* X86_EXC_SPV entry_SPV 15 PIC Spurious Interrupt Vector - Autogen */ +ENTRY X86_EXC_MF entry_MF /* 16 Maths Fault (x87 FPU) */ +ENTRY X86_EXC_AC entry_AC /* 17 Alignment Check */ +ENTRY_IST X86_EXC_MC entry_MC /* 18 Machine Check */ +ENTRY X86_EXC_XM entry_XM /* 19 SIMD Maths Fault */ +/* X86_EXC_VE entry_VE 20 Virtualisation Exception - Not implemented */ +ENTRY X86_EXC_CP entry_CP /* 21 Control-flow Protection */ + /* %rbx: struct vcpu, interrupts disabled */ restore_all_guest: ASSERT_INTERRUPTS_DISABLED @@ -707,9 +751,6 @@ ENTRY(common_interrupt) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) jmp ret_from_intr -ENTRY(page_fault) - ENDBR64 - movl $TRAP_page_fault,4(%rsp) /* No special register assumptions. */ GLOBAL(handle_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP @@ -882,91 +923,7 @@ FATAL_exception_with_ints_disabled: call fatal_trap BUG /* fatal_trap() shouldn't return. */ -ENTRY(divide_error) - ENDBR64 - pushq $0 - movl $TRAP_divide_error,4(%rsp) - jmp handle_exception - -ENTRY(coprocessor_error) - ENDBR64 - pushq $0 - movl $TRAP_copro_error,4(%rsp) - jmp handle_exception - -ENTRY(simd_coprocessor_error) - ENDBR64 - pushq $0 - movl $TRAP_simd_error,4(%rsp) - jmp handle_exception - -ENTRY(device_not_available) - ENDBR64 - pushq $0 - movl $TRAP_no_device,4(%rsp) - jmp handle_exception - -ENTRY(debug) - ENDBR64 - pushq $0 - movl $TRAP_debug,4(%rsp) - jmp handle_ist_exception - -ENTRY(int3) - ENDBR64 - pushq $0 - movl $TRAP_int3,4(%rsp) - jmp handle_exception - -ENTRY(overflow) - ENDBR64 - pushq $0 - movl $TRAP_overflow,4(%rsp) - jmp handle_exception - -ENTRY(bounds) - ENDBR64 - pushq $0 - movl $TRAP_bounds,4(%rsp) - jmp handle_exception - -ENTRY(invalid_op) - ENDBR64 - pushq $0 - movl $TRAP_invalid_op,4(%rsp) - jmp handle_exception - -ENTRY(invalid_TSS) - ENDBR64 - movl $TRAP_invalid_tss,4(%rsp) - jmp handle_exception - -ENTRY(segment_not_present) - ENDBR64 - movl $TRAP_no_segment,4(%rsp) - jmp handle_exception - -ENTRY(stack_segment) - ENDBR64 - movl $TRAP_stack_error,4(%rsp) - jmp handle_exception - -ENTRY(general_protection) - ENDBR64 - movl $TRAP_gp_fault,4(%rsp) - jmp handle_exception - -ENTRY(alignment_check) - ENDBR64 - movl $TRAP_alignment_check,4(%rsp) - jmp handle_exception - -ENTRY(entry_CP) - ENDBR64 - movl $X86_EXC_CP, 4(%rsp) - jmp handle_exception - -ENTRY(double_fault) +ENTRY(entry_DF) ENDBR64 movl $TRAP_double_fault,4(%rsp) /* Set AC to reduce chance of further SMAP faults */ @@ -991,10 +948,10 @@ ENTRY(double_fault) call do_double_fault BUG /* do_double_fault() shouldn't return. */ -ENTRY(nmi) - ENDBR64 - pushq $0 - movl $TRAP_nmi,4(%rsp) + .type entry_DF, @function + .size entry_DF, . - entry_DF + + handle_ist_exception: ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL @@ -1120,12 +1077,6 @@ handle_ist_exception: jmp restore_all_xen #endif -ENTRY(machine_check) - ENDBR64 - pushq $0 - movl $TRAP_machine_check,4(%rsp) - jmp handle_ist_exception - /* No op trap handler. Required for kexec crash path. */ GLOBAL(trap_nop) ENDBR64 -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:00:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498063.768866 (Exim 4.92) (envelope-from ) id 1pU4qV-0006aM-HS; Mon, 20 Feb 2023 12:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498063.768866; Mon, 20 Feb 2023 12:00:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qV-0006aF-Dt; Mon, 20 Feb 2023 12:00:39 +0000 Received: by outflank-mailman (input) for mailman id 498063; Mon, 20 Feb 2023 12:00:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qT-0006JO-Ri for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:00:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d523350-b116-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 13:00:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d523350-b116-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676894435; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CuckuLGlYKJxYlRnLE4X2ClIoS5C7A3C2knFbaiWOW4=; b=I1ls6fJwyCXMUvnrdps2youp9hwjMi7XcAurTY3JDXENQAXvKjmrVHsE 4b0ZfMUo0Q2lbK+3Utv4sqgUyuYcORHdFSieeoeyAZtwhdSZ2eK9nYo30 LPlWA9NWosSxzdQeiZFgdkKRCdot0sDdA63/MS7XoNyq7NNzGs2f7mzhb I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97740140 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:9WDwjK9/6Vw9QrbGi8gUDrUDqX6TJUtcMsCJ2f8bNWPcYEJGY0x3n WYZD26GO/qKYmryftx/YI+2oBhV75XWnINiHQE9qSA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oT5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl19 bsAE3ccdCuPgtmd7p3hYO1n2vYKeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0EwRnE/ juapwwVBDkeFMa/yAu+7k6KudflsyildaUZSZCRo6sCbFq7mTVIVUx+uUGAifq+jFS3V5RAK kgX0i00pKM2+QqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTXZaF01fuYCl+dxtyEuVFb6PDZJZkPXOGXbo+ HebthMygo44o+FR/aGwoWLu1mfESofyciY54QDeX2SA5wx/ZZK4a4HA1WU3/cqsP67CEADf4 SFsd9y2qblXUMrTzHDlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCH17ZiTCgUxfOdjZ5yEWIU/ITI2NaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN JGQfK6EVChFV/Q8lWTtGrhFitfHIxzSIkuJGPjGI+mPi+LCNBZ5t59YWLdxUgzJxPzd+1iEm zquH8CL1w9eQIXDjtr/qOYuwaQxBSFjX/je8pUHHtNv1yI6QAnN/deNm+J+E2Gk9owJ/tr1E oaVABEBmAev2iGWcG1nqBlLMdvSYHq2llpjVQREALpi8yJyCWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:mKKLmaOhmDjekMBcTs+jsMiBIKoaSvp037BL7SxMoHluGfBw+P rAoB1273HJYVQqOE3I6OrgBEDoexq1n/NICOIqTNSftWfdyQ6VBbAnwYz+wyDxXw3Sn9QtsZ uIqpIOauHNMQ== X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97740140" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH 0/3] x86/entry: Cleanup and livepatch support Date: Mon, 20 Feb 2023 11:59:53 +0000 Message-ID: <20230220115956.1522728-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The main patch here is patch 2, to support livepatching. Patch 3 is just cleanup. Andrew Cooper (3): x86/traps: Move do_general_protection() earlier x86/entry: Rework the exception entrypoints x86/treewide: Drop the TRAP_* legacy names xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpuid.c | 6 +- xen/arch/x86/crash.c | 6 +- xen/arch/x86/domain.c | 2 +- xen/arch/x86/extable.c | 8 +- xen/arch/x86/hvm/emulate.c | 17 +- xen/arch/x86/hvm/hvm.c | 61 +++--- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 32 +-- xen/arch/x86/hvm/svm/svm.c | 76 ++++---- xen/arch/x86/hvm/svm/vmcb.c | 4 +- xen/arch/x86/hvm/vm_event.c | 10 +- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/realmode.c | 16 +- xen/arch/x86/hvm/vmx/vmcs.c | 4 +- xen/arch/x86/hvm/vmx/vmx.c | 79 ++++---- xen/arch/x86/hvm/vmx/vvmx.c | 28 +-- xen/arch/x86/include/asm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 8 +- xen/arch/x86/include/asm/processor.h | 78 +------- xen/arch/x86/include/asm/x86-defns.h | 2 + xen/arch/x86/machine_kexec.c | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 10 +- xen/arch/x86/pv/callback.c | 6 +- xen/arch/x86/pv/emul-gate-op.c | 34 ++-- xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 14 +- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 4 +- xen/arch/x86/pv/traps.c | 12 +- xen/arch/x86/traps.c | 257 +++++++++++++------------ xen/arch/x86/x86_64/compat/entry.S | 12 +- xen/arch/x86/x86_64/entry.S | 167 ++++++---------- xen/arch/x86/x86_emulate.c | 10 +- xen/arch/x86/x86_emulate/x86_emulate.h | 4 +- 41 files changed, 449 insertions(+), 544 deletions(-) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:00:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:00:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498064.768877 (Exim 4.92) (envelope-from ) id 1pU4qX-0006rD-RB; Mon, 20 Feb 2023 12:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498064.768877; Mon, 20 Feb 2023 12:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qX-0006r6-Mq; Mon, 20 Feb 2023 12:00:41 +0000 Received: by outflank-mailman (input) for mailman id 498064; Mon, 20 Feb 2023 12:00:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qV-0006Ge-UM for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:00:40 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2aa2420d-b116-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 13:00:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aa2420d-b116-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676894435; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jFWfK3//BYlWrrP//RiyQIsCqar6JnZuHMmFCsiAJGE=; b=ex7M+X4pfy/Idn89icTojoR5/kzg4Euf2TTfO2kzNhTVJrjcYhl6zzN2 diZeQR+LR9MyHT/GL7UX6a82qiYhr/oardMnrl7yt0aELBSvcH62H5rMq KdzRDpiUFwe/RChuQ0Xyyq67v9aiFizvg8F+zXjBZZvfE1YrF8hXZD9LH Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97740136 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:4kpdIqri00h0wwY77eYKn05GppheBmIJZRIvgKrLsJaIsI4StFCzt garIBmDbPmMZ2bxKopxaNiw9U9XuMDSnNBlHAtrqns0ES1G+ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSFNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAsNKQi4wPOs+76+ccJCqZ4JKMK3DqpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jOZoDihW0pEXDCZ4Squ02/8tNDepAzyf6AMHayp/9FQpGTGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8UYwgyQzqvf4y6CG3MJCDVGbbQOq8seVTEsk FiTkLvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTAFpMHY55AptR7Kdf1NP/SfitapKxill lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3Hb5 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8Ahkkey+F0e5eI1cFh XM/XisIvfdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxHOjzu0zhNxzvlkU Xt+TSpLJSxHYZmLMRLsH7tNuVPV7n1WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vdyDg5B +13bpPQoz0GCb2WX8Ui2dJLRbz8BSRhVM+eRg0+XrLrHzeK70l7VaaBnON+J90890mX/8+Rl kyAtoZj4AKXrRX6xc+iMCALhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:/Upi7K7LTKZpyaVQiAPXwMbXdLJyesId70hD6qkRc3Bom6mj/P xG88516faZslgssRMb+exoSZPgfZq0z/cci+Qs1NyZLWrbUQWTXeRfxLqn7zr8GzDvss5xvJ 0QF5SW0eeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97740136" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] x86/treewide: Drop the TRAP_* legacy names Date: Mon, 20 Feb 2023 11:59:56 +0000 Message-ID: <20230220115956.1522728-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220115956.1522728-1-andrew.cooper3@citrix.com> References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit We have two naming schemes for exceptions - X86_EXC_?? which use the archtiectural abbreviations, and TRAP_* which is a mix of terminology and nonstandard abbrevations. Switch to X86_EXC_* uniformly. No funcational change, confirmed by diffing the disassembly. Only 7 binary changes, and they're all __LINE__ being passed into printk(). Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu This is a bit of a large patch, but its treewide cleanup and splitting it up by major subsystem doesn't make it easier to review. Diffing the disassmebly is by far the easiest way to confirm no functional change. --- xen/arch/x86/cpu/mcheck/vmce.c | 2 +- xen/arch/x86/cpuid.c | 6 +- xen/arch/x86/crash.c | 6 +- xen/arch/x86/domain.c | 2 +- xen/arch/x86/extable.c | 8 +-- xen/arch/x86/hvm/emulate.c | 17 +++--- xen/arch/x86/hvm/hvm.c | 61 ++++++++++---------- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/svm/emulate.c | 2 +- xen/arch/x86/hvm/svm/intr.c | 2 +- xen/arch/x86/hvm/svm/nestedsvm.c | 32 +++++------ xen/arch/x86/hvm/svm/svm.c | 76 ++++++++++++------------- xen/arch/x86/hvm/svm/vmcb.c | 4 +- xen/arch/x86/hvm/vm_event.c | 10 ++-- xen/arch/x86/hvm/vmx/intr.c | 2 +- xen/arch/x86/hvm/vmx/realmode.c | 16 +++--- xen/arch/x86/hvm/vmx/vmcs.c | 4 +- xen/arch/x86/hvm/vmx/vmx.c | 79 +++++++++++++------------- xen/arch/x86/hvm/vmx/vvmx.c | 28 ++++----- xen/arch/x86/include/asm/domain.h | 2 +- xen/arch/x86/include/asm/hvm/hvm.h | 8 +-- xen/arch/x86/include/asm/processor.h | 44 +++----------- xen/arch/x86/include/asm/x86-defns.h | 2 + xen/arch/x86/machine_kexec.c | 2 +- xen/arch/x86/mm.c | 2 +- xen/arch/x86/mm/mem_access.c | 2 +- xen/arch/x86/mm/shadow/hvm.c | 2 +- xen/arch/x86/mm/shadow/multi.c | 10 ++-- xen/arch/x86/pv/callback.c | 6 +- xen/arch/x86/pv/emul-gate-op.c | 34 +++++------ xen/arch/x86/pv/emul-inv-op.c | 2 +- xen/arch/x86/pv/emul-priv-op.c | 14 ++--- xen/arch/x86/pv/emulate.c | 2 +- xen/arch/x86/pv/iret.c | 2 +- xen/arch/x86/pv/ro-page-fault.c | 4 +- xen/arch/x86/pv/traps.c | 10 ++-- xen/arch/x86/traps.c | 34 +++++------ xen/arch/x86/x86_64/compat/entry.S | 12 ++-- xen/arch/x86/x86_64/entry.S | 20 +++---- xen/arch/x86/x86_emulate.c | 10 ++-- xen/arch/x86/x86_emulate/x86_emulate.h | 4 +- 41 files changed, 278 insertions(+), 309 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/vmce.c b/xen/arch/x86/cpu/mcheck/vmce.c index af30811afd44..6f1a7e4de013 100644 --- a/xen/arch/x86/cpu/mcheck/vmce.c +++ b/xen/arch/x86/cpu/mcheck/vmce.c @@ -414,7 +414,7 @@ int inject_vmce(struct domain *d, int vcpu) continue; if ( (is_hvm_domain(d) || - pv_trap_callback_registered(v, TRAP_machine_check)) && + pv_trap_callback_registered(v, X86_EXC_MC)) && !test_and_set_bool(v->arch.mce_pending) ) { mce_printk(MCE_VERBOSE, "MCE: inject vMCE to %pv\n", v); diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index b22725c492e7..49d401216ed3 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -1040,7 +1040,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, /* OSXSAVE clear in policy. Fast-forward CR4 back in. */ if ( (v->arch.pv.ctrlreg[4] & X86_CR4_OSXSAVE) || (p->basic.xsave && - regs->entry_vector == TRAP_invalid_op && + regs->entry_vector == X86_EXC_UD && guest_kernel_mode(v, regs) && (read_cr4() & X86_CR4_OSXSAVE)) ) res->c |= cpufeat_mask(X86_FEATURE_OSXSAVE); @@ -1076,7 +1076,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, * emulated CPUID from a faulted CPUID by whether a #UD or #GP * fault is currently being serviced. Yuck... */ - if ( cpu_has_monitor && regs->entry_vector == TRAP_gp_fault ) + if ( cpu_has_monitor && regs->entry_vector == X86_EXC_GP ) res->c |= cpufeat_mask(X86_FEATURE_MONITOR); /* @@ -1101,7 +1101,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, regs = guest_cpu_user_regs(); if ( is_pv_domain(d) && is_hardware_domain(d) && guest_kernel_mode(v, regs) && cpu_has_monitor && - regs->entry_vector == TRAP_gp_fault ) + regs->entry_vector == X86_EXC_GP ) *res = raw_cpuid_policy.basic.raw[5]; break; diff --git a/xen/arch/x86/crash.c b/xen/arch/x86/crash.c index 7850f0af2473..a789416ca3ae 100644 --- a/xen/arch/x86/crash.c +++ b/xen/arch/x86/crash.c @@ -60,7 +60,7 @@ static int noreturn cf_check do_nmi_crash( * This update is safe from a security point of view, as this * pcpu is never going to try to sysret back to a PV vcpu. */ - set_ist(&idt_tables[cpu][TRAP_machine_check], IST_NONE); + set_ist(&idt_tables[cpu][X86_EXC_MC], IST_NONE); kexec_crash_save_cpu(); __stop_this_cpu(); @@ -130,9 +130,9 @@ static void nmi_shootdown_cpus(void) * Disable IST for MCEs to avoid stack corruption race conditions, and * change the NMI handler to a nop to avoid deviation from this codepath. */ - _set_gate_lower(&idt_tables[cpu][TRAP_nmi], + _set_gate_lower(&idt_tables[cpu][X86_EXC_NMI], SYS_DESC_irq_gate, 0, &trap_nop); - set_ist(&idt_tables[cpu][TRAP_machine_check], IST_NONE); + set_ist(&idt_tables[cpu][X86_EXC_MC], IST_NONE); set_nmi_callback(do_nmi_crash); smp_send_nmi_allbutself(); diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index db3ebf062dab..d56920b733df 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -112,7 +112,7 @@ void play_dead(void) local_irq_disable(); /* Change the NMI handler to a nop (see comment below). */ - _set_gate_lower(&idt_tables[cpu][TRAP_nmi], SYS_DESC_irq_gate, 0, + _set_gate_lower(&idt_tables[cpu][X86_EXC_NMI], SYS_DESC_irq_gate, 0, &trap_nop); /* diff --git a/xen/arch/x86/extable.c b/xen/arch/x86/extable.c index 4913c4a6dd5d..5253ae41434b 100644 --- a/xen/arch/x86/extable.c +++ b/xen/arch/x86/extable.c @@ -135,15 +135,15 @@ static int __init cf_check stub_selftest(void) } tests[] __initconst = { #define endbr64 0xf3, 0x0f, 0x1e, 0xfa { .opc = { endbr64, 0x0f, 0xb9, 0xc3, 0xc3 }, /* ud1 */ - .res.fields.trapnr = TRAP_invalid_op }, + .res.fields.trapnr = X86_EXC_UD }, { .opc = { endbr64, 0x90, 0x02, 0x00, 0xc3 }, /* nop; add (%rax),%al */ .rax = 0x0123456789abcdef, - .res.fields.trapnr = TRAP_gp_fault }, + .res.fields.trapnr = X86_EXC_GP }, { .opc = { endbr64, 0x02, 0x04, 0x04, 0xc3 }, /* add (%rsp,%rax),%al */ .rax = 0xfedcba9876543210, - .res.fields.trapnr = TRAP_stack_error }, + .res.fields.trapnr = X86_EXC_SS }, { .opc = { endbr64, 0xcc, 0xc3, 0xc3, 0xc3 }, /* int3 */ - .res.fields.trapnr = TRAP_int3 }, + .res.fields.trapnr = X86_EXC_BP }, #undef endbr64 }; unsigned long addr = this_cpu(stubs.addr) + STUB_BUF_SIZE / 2; diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 95364deb1996..adb3b084b3b7 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -910,9 +910,8 @@ static int hvmemul_virtual_to_linear( * determine the kind of exception (#GP or #TS) in that case. */ if ( is_x86_user_segment(seg) ) - x86_emul_hw_exception((seg == x86_seg_ss) - ? TRAP_stack_error - : TRAP_gp_fault, 0, &hvmemul_ctxt->ctxt); + x86_emul_hw_exception((seg == x86_seg_ss) ? X86_EXC_SS : X86_EXC_GP, + 0, &hvmemul_ctxt->ctxt); return X86EMUL_EXCEPTION; } @@ -2227,7 +2226,7 @@ static int cf_check hvmemul_write_cr( } if ( rc == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return rc; } @@ -2263,7 +2262,7 @@ static int cf_check hvmemul_read_msr( int rc = hvm_msr_read_intercept(reg, val); if ( rc == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return rc; } @@ -2276,7 +2275,7 @@ static int cf_check hvmemul_write_msr( int rc = hvm_msr_write_intercept(reg, val, true); if ( rc == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return rc; } @@ -2530,7 +2529,7 @@ static int cf_check hvmemul_tlb_op( paging_invlpg(current, addr); else { - x86_emul_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC, ctxt); + x86_emul_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC, ctxt); rc = X86EMUL_EXCEPTION; } break; @@ -2548,7 +2547,7 @@ static int cf_check hvmemul_vmfunc( return X86EMUL_UNHANDLEABLE; rc = alternative_call(hvm_funcs.altp2m_vcpu_emulate_vmfunc, ctxt->regs); if ( rc == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC, ctxt); + x86_emul_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC, ctxt); return rc; } @@ -2676,7 +2675,7 @@ static int _hvm_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt, } if ( hvmemul_ctxt->ctxt.retire.singlestep ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); new_intr_shadow = hvmemul_ctxt->intr_shadow; diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5c1e64189600..bab0ed5d2d6a 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -256,25 +256,25 @@ int hvm_event_needs_reinjection(uint8_t type, uint8_t vector) uint8_t hvm_combine_hw_exceptions(uint8_t vec1, uint8_t vec2) { const unsigned int contributory_exceptions = - (1 << TRAP_divide_error) | - (1 << TRAP_invalid_tss) | - (1 << TRAP_no_segment) | - (1 << TRAP_stack_error) | - (1 << TRAP_gp_fault); + (1 << X86_EXC_DE) | + (1 << X86_EXC_TS) | + (1 << X86_EXC_NP) | + (1 << X86_EXC_SS) | + (1 << X86_EXC_GP); const unsigned int page_faults = - (1 << TRAP_page_fault) | - (1 << TRAP_virtualisation); + (1 << X86_EXC_PF) | + (1 << X86_EXC_VE); /* Exception during double-fault delivery always causes a triple fault. */ - if ( vec1 == TRAP_double_fault ) + if ( vec1 == X86_EXC_DF ) { hvm_triple_fault(); - return TRAP_double_fault; /* dummy return */ + return X86_EXC_DF; /* dummy return */ } /* Exception during page-fault delivery always causes a double fault. */ if ( (1u << vec1) & page_faults ) - return TRAP_double_fault; + return X86_EXC_DF; /* Discard the first exception if it's benign or if we now have a #PF. */ if ( !((1u << vec1) & contributory_exceptions) || @@ -282,7 +282,7 @@ uint8_t hvm_combine_hw_exceptions(uint8_t vec1, uint8_t vec2) return vec2; /* Cannot combine the exceptions: double fault. */ - return TRAP_double_fault; + return X86_EXC_DF; } void hvm_set_rdtsc_exiting(struct domain *d, bool_t enable) @@ -1700,7 +1700,7 @@ void hvm_inject_event(const struct x86_event *event) struct vcpu *curr = current; const uint8_t vector = event->vector; const bool has_ec = ((event->type == X86_EVENTTYPE_HW_EXCEPTION) && - (vector < 32) && ((TRAP_HAVE_EC & (1u << vector)))); + (vector < 32) && ((X86_EXC_HAVE_EC & (1u << vector)))); ASSERT(vector == event->vector); /* Confirm no truncation. */ if ( has_ec ) @@ -1782,7 +1782,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, return -1; case NESTEDHVM_PAGEFAULT_MMIO: if ( !handle_mmio() ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return 1; case NESTEDHVM_PAGEFAULT_L0_ERROR: /* gpa is now translated to l1 guest address, update gfn. */ @@ -1799,7 +1799,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, if ( !nestedhvm_vcpu_in_guestmode(curr) && hvm_mmio_internal(gpa) ) { if ( !handle_mmio_with_translation(gla, gpa >> PAGE_SHIFT, npfec) ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = 1; goto out; } @@ -1926,7 +1926,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla, (p2m_is_discard_write(p2mt) || (p2mt == p2m_ioreq_server))) ) { if ( !handle_mmio_with_translation(gla, gpa >> PAGE_SHIFT, npfec) ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = 1; goto out_put_gfn; } @@ -2034,7 +2034,7 @@ int hvm_handle_xsetbv(u32 index, u64 new_bv) rc = x86emul_write_xcr(index, new_bv, NULL); if ( rc != X86EMUL_OKAY ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return rc; } @@ -2167,7 +2167,7 @@ int hvm_mov_to_cr(unsigned int cr, unsigned int gpr) } if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return rc; @@ -2817,7 +2817,7 @@ static int task_switch_load_seg( seg_desc_t *pdesc = NULL, desc; u8 dpl, rpl; bool_t writable; - int fault_type = TRAP_invalid_tss; + int fault_type = X86_EXC_TS; struct vcpu *v = current; if ( eflags & X86_EFLAGS_VM ) @@ -2910,8 +2910,7 @@ static int task_switch_load_seg( /* Segment present in memory? */ if ( !(desc.b & _SEGMENT_P) ) { - fault_type = (seg != x86_seg_ss) ? TRAP_no_segment - : TRAP_stack_error; + fault_type = (seg != x86_seg_ss) ? X86_EXC_NP : X86_EXC_SS; goto fault; } } while ( !(desc.b & 0x100) && /* Ensure Accessed flag is set */ @@ -3008,9 +3007,9 @@ void hvm_task_switch( if ( ((tss_sel & 0xfff8) + 7) > gdt.limit ) { - hvm_inject_hw_exception((taskswitch_reason == TSW_iret) ? - TRAP_invalid_tss : TRAP_gp_fault, - tss_sel & 0xfff8); + hvm_inject_hw_exception( + (taskswitch_reason == TSW_iret) ? X86_EXC_TS : X86_EXC_GP, + tss_sel & 0xfff8); goto out; } @@ -3037,20 +3036,20 @@ void hvm_task_switch( if ( tr.type != ((taskswitch_reason == TSW_iret) ? 0xb : 0x9) ) { hvm_inject_hw_exception( - (taskswitch_reason == TSW_iret) ? TRAP_invalid_tss : TRAP_gp_fault, + (taskswitch_reason == TSW_iret) ? X86_EXC_TS : X86_EXC_GP, tss_sel & 0xfff8); goto out; } if ( !tr.p ) { - hvm_inject_hw_exception(TRAP_no_segment, tss_sel & 0xfff8); + hvm_inject_hw_exception(X86_EXC_NP, tss_sel & 0xfff8); goto out; } if ( tr.limit < (sizeof(tss)-1) ) { - hvm_inject_hw_exception(TRAP_invalid_tss, tss_sel & 0xfff8); + hvm_inject_hw_exception(X86_EXC_TS, tss_sel & 0xfff8); goto out; } @@ -3119,7 +3118,7 @@ void hvm_task_switch( rc = hvm_set_cr3(tss.cr3, false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) goto out; @@ -3203,7 +3202,7 @@ void hvm_task_switch( } if ( (tss.trace & 1) && !exn_raised ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); out: hvm_unmap_entry(optss_desc); @@ -3478,7 +3477,7 @@ int hvm_vmexit_cpuid(struct cpu_user_regs *regs, unsigned int inst_len) if ( curr->arch.msrs->misc_features_enables.cpuid_faulting && hvm_get_cpl(curr) > 0 ) { - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return 1; /* Don't advance the guest IP! */ } @@ -3855,7 +3854,7 @@ void hvm_ud_intercept(struct cpu_user_regs *regs) if ( !should_emulate ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -3863,7 +3862,7 @@ void hvm_ud_intercept(struct cpu_user_regs *regs) { case X86EMUL_UNHANDLEABLE: case X86EMUL_UNIMPLEMENTED: - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; case X86EMUL_EXCEPTION: hvm_inject_event(&ctxt.ctxt.event); diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 5ae209d3b6b3..ae2feebd79e4 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -78,7 +78,7 @@ bool hvm_emulate_one_insn(hvm_emulate_validate_t *validate, const char *descr) case X86EMUL_UNRECOGNIZED: hvm_dump_emulation_state(XENLOG_G_WARNING, descr, &ctxt, rc); - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; case X86EMUL_EXCEPTION: diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883cf..4661cde44968 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -112,7 +112,7 @@ unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc) hvm_dump_emulation_state(XENLOG_G_WARNING, "SVM Insn len", &ctxt, X86EMUL_UNHANDLEABLE); - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return 0; } diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 9525f3559392..5aa723979c88 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -47,7 +47,7 @@ static void svm_inject_nmi(struct vcpu *v) event.raw = 0; event.v = true; event.type = X86_EVENTTYPE_NMI; - event.vector = TRAP_nmi; + event.vector = X86_EXC_NMI; ASSERT(!vmcb->event_inj.v); vmcb->event_inj = event; diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 9f5f35f16aff..1d7fe493cffc 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -194,7 +194,7 @@ static uint64_t nestedsvm_fpu_vmentry(uint64_t n1cr0, * Sync FPU state with l2 guest. */ vcr0 |= X86_CR0_TS; - n2vmcb->_exception_intercepts |= (1U << TRAP_no_device); + n2vmcb->_exception_intercepts |= (1U << X86_EXC_NM); } else if ( !(vcr0 & X86_CR0_TS) && (n2vmcb->_cr0 & X86_CR0_TS) ) { @@ -203,7 +203,7 @@ static uint64_t nestedsvm_fpu_vmentry(uint64_t n1cr0, * Sync FPU state with l2 guest. */ vcr0 &= ~X86_CR0_TS; - n2vmcb->_exception_intercepts &= ~(1U << TRAP_no_device); + n2vmcb->_exception_intercepts &= ~(1U << X86_EXC_NM); } return vcr0; @@ -219,7 +219,7 @@ static void nestedsvm_fpu_vmexit(struct vmcb_struct *n1vmcb, * Sync FPU state with l1 guest. */ n1vmcb->_cr0 |= X86_CR0_TS; - n1vmcb->_exception_intercepts |= (1U << TRAP_no_device); + n1vmcb->_exception_intercepts |= (1U << X86_EXC_NM); } else if ( !(n1cr0 & X86_CR0_TS) && (n1vmcb->_cr0 & X86_CR0_TS) ) { @@ -228,7 +228,7 @@ static void nestedsvm_fpu_vmexit(struct vmcb_struct *n1vmcb, * Sync FPU state with l1 guest. */ n1vmcb->_cr0 &= ~X86_CR0_TS; - n1vmcb->_exception_intercepts &= ~(1U << TRAP_no_device); + n1vmcb->_exception_intercepts &= ~(1U << X86_EXC_NM); } } @@ -283,7 +283,7 @@ static int nsvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs) v->arch.hvm.guest_efer = n1vmcb->_efer; rc = hvm_set_efer(n1vmcb->_efer); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_efer failed, rc: %u\n", rc); @@ -291,7 +291,7 @@ static int nsvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs) v->arch.hvm.guest_cr[4] = n1vmcb->_cr4; rc = hvm_set_cr4(n1vmcb->_cr4, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr4 failed, rc: %u\n", rc); @@ -302,7 +302,7 @@ static int nsvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs) n1vmcb->rflags &= ~X86_EFLAGS_VM; rc = hvm_set_cr0(n1vmcb->_cr0 | X86_CR0_PE, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr0 failed, rc: %u\n", rc); svm->ns_cr0 = v->arch.hvm.guest_cr[0]; @@ -335,7 +335,7 @@ static int nsvm_vcpu_hostrestore(struct vcpu *v, struct cpu_user_regs *regs) } rc = hvm_set_cr3(n1vmcb->_cr3, false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr3 failed, rc: %u\n", rc); @@ -557,7 +557,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) v->arch.hvm.guest_efer = ns_vmcb->_efer; rc = hvm_set_efer(ns_vmcb->_efer); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_efer failed, rc: %u\n", rc); @@ -565,7 +565,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) v->arch.hvm.guest_cr[4] = ns_vmcb->_cr4; rc = hvm_set_cr4(ns_vmcb->_cr4, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr4 failed, rc: %u\n", rc); @@ -575,7 +575,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) v->arch.hvm.guest_cr[0] = ns_vmcb->_cr0; rc = hvm_set_cr0(cr0, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr0 failed, rc: %u\n", rc); @@ -594,7 +594,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) /* hvm_set_cr3() below sets v->arch.hvm.guest_cr[3] for us. */ rc = hvm_set_cr3(ns_vmcb->_cr3, false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr3 failed, rc: %u\n", rc); } @@ -610,7 +610,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) /* hvm_set_cr3() below sets v->arch.hvm.guest_cr[3] for us. */ rc = hvm_set_cr3(ns_vmcb->_cr3, false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); if ( rc != X86EMUL_OKAY ) gdprintk(XENLOG_ERR, "hvm_set_cr3 failed, rc: %u\n", rc); } @@ -788,7 +788,7 @@ nsvm_vcpu_vmrun(struct vcpu *v, struct cpu_user_regs *regs) default: gdprintk(XENLOG_ERR, "nsvm_vcpu_vmentry failed, injecting #UD\n"); - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); /* Must happen after hvm_inject_hw_exception or it doesn't work right. */ nv->nv_vmswitch_in_progress = 0; return 1; @@ -1579,7 +1579,7 @@ void svm_vmexit_do_stgi(struct cpu_user_regs *regs, struct vcpu *v) */ if ( !nestedhvm_enabled(v->domain) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -1600,7 +1600,7 @@ void svm_vmexit_do_clgi(struct cpu_user_regs *regs, struct vcpu *v) if ( !nsvm_efer_svm_enabled(v) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index fa7325720328..a9903c36bdda 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -91,7 +91,7 @@ static DEFINE_SPINLOCK(osvw_lock); static void svm_crash_or_fault(struct vcpu *v) { if ( vmcb_get_cpl(v->arch.hvm.svm.vmcb) ) - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); else domain_crash(v->domain); } @@ -118,7 +118,7 @@ void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len) curr->arch.hvm.svm.vmcb->int_stat.intr_shadow = 0; if ( regs->eflags & X86_EFLAGS_TF ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); } static void cf_check svm_cpu_down(void) @@ -133,7 +133,7 @@ static void svm_fpu_enter(struct vcpu *v) vcpu_restore_fpu_lazy(v); vmcb_set_exception_intercepts( n1vmcb, - vmcb_get_exception_intercepts(n1vmcb) & ~(1U << TRAP_no_device)); + vmcb_get_exception_intercepts(n1vmcb) & ~(1U << X86_EXC_NM)); } static void cf_check svm_fpu_leave(struct vcpu *v) @@ -153,7 +153,7 @@ static void cf_check svm_fpu_leave(struct vcpu *v) { vmcb_set_exception_intercepts( n1vmcb, - vmcb_get_exception_intercepts(n1vmcb) | (1U << TRAP_no_device)); + vmcb_get_exception_intercepts(n1vmcb) | (1U << X86_EXC_NM)); vmcb_set_cr0(n1vmcb, vmcb_get_cr0(n1vmcb) | X86_CR0_TS); } } @@ -601,9 +601,9 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) if ( opt_hvm_fep || (v->domain->arch.cpuid->x86_vendor != boot_cpu_data.x86_vendor) ) - bitmap |= (1U << TRAP_invalid_op); + bitmap |= (1U << X86_EXC_UD); else - bitmap &= ~(1U << TRAP_invalid_op); + bitmap &= ~(1U << X86_EXC_UD); vmcb_set_exception_intercepts(vmcb, bitmap); @@ -1039,8 +1039,8 @@ static void noreturn cf_check svm_do_resume(void) v->arch.hvm.debug_state_latch = debug_state; vmcb_set_exception_intercepts( - vmcb, debug_state ? (intercepts | (1U << TRAP_int3)) - : (intercepts & ~(1U << TRAP_int3))); + vmcb, debug_state ? (intercepts | (1U << X86_EXC_BP)) + : (intercepts & ~(1U << X86_EXC_BP))); } if ( v->arch.hvm.svm.launch_core != smp_processor_id() ) @@ -1227,7 +1227,7 @@ static void svm_emul_swint_injection(struct x86_event *event) const struct vmcb_struct *vmcb = curr->arch.hvm.svm.vmcb; const struct cpu_user_regs *regs = guest_cpu_user_regs(); unsigned int trap = event->vector, type = event->type; - unsigned int fault = TRAP_gp_fault, ec = 0; + unsigned int fault = X86_EXC_GP, ec = 0; pagefault_info_t pfinfo; struct segment_register cs, idtr; unsigned int idte_size, idte_offset; @@ -1273,7 +1273,7 @@ static void svm_emul_swint_injection(struct x86_event *event) { if ( rc == HVMTRANS_bad_linear_to_gfn ) { - fault = TRAP_page_fault; + fault = X86_EXC_PF; ec = pfinfo.ec; event->cr2 = pfinfo.linear; } @@ -1309,7 +1309,7 @@ static void svm_emul_swint_injection(struct x86_event *event) /* Is this entry present? */ if ( !(idte.b & (1u << 15)) ) { - fault = TRAP_no_segment; + fault = X86_EXC_NP; goto raise_exception; } @@ -1350,14 +1350,14 @@ static void cf_check svm_inject_event(const struct x86_event *event) switch ( _event.vector | -(_event.type == X86_EVENTTYPE_SW_INTERRUPT) ) { - case TRAP_debug: + case X86_EXC_DB: if ( regs->eflags & X86_EFLAGS_TF ) { __restore_debug_registers(vmcb, curr); vmcb_set_dr6(vmcb, vmcb_get_dr6(vmcb) | DR_STEP); } /* fall through */ - case TRAP_int3: + case X86_EXC_BP: if ( curr->domain->debugger_attached ) { /* Debug/Int3: Trap to debugger. */ @@ -1366,7 +1366,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) } break; - case TRAP_page_fault: + case X86_EXC_PF: ASSERT(_event.type == X86_EVENTTYPE_HW_EXCEPTION); curr->arch.hvm.guest_cr[2] = _event.cr2; vmcb_set_cr2(vmcb, _event.cr2); @@ -1377,7 +1377,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) { _event.vector = hvm_combine_hw_exceptions( eventinj.vector, _event.vector); - if ( _event.vector == TRAP_double_fault ) + if ( _event.vector == X86_EXC_DF ) _event.error_code = 0; } @@ -1450,7 +1450,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) ASSERT(!eventinj.ev || eventinj.ec == (uint16_t)eventinj.ec); vmcb->event_inj = eventinj; - if ( _event.vector == TRAP_page_fault && + if ( _event.vector == X86_EXC_PF && _event.type == X86_EVENTTYPE_HW_EXCEPTION ) HVMTRACE_LONG_2D(PF_INJECT, _event.error_code, TRC_PAR_LONG(_event.cr2)); @@ -1785,7 +1785,7 @@ static void cf_check svm_fpu_dirty_intercept(void) { /* Check if l1 guest must make FPU ready for the l2 guest */ if ( v->arch.hvm.guest_cr[0] & X86_CR0_TS ) - hvm_inject_hw_exception(TRAP_no_device, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_NM, X86_EVENT_NO_EC); else vmcb_set_cr0(n1vmcb, vmcb_get_cr0(n1vmcb) & ~X86_CR0_TS); return; @@ -2229,7 +2229,7 @@ static void svm_do_msr_access(struct cpu_user_regs *regs) if ( rc == X86EMUL_OKAY ) __update_guest_eip(regs, inst_len); else if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); } static void svm_vmexit_do_hlt(struct vmcb_struct *vmcb, @@ -2252,7 +2252,7 @@ static void svm_vmexit_do_rdtsc(struct cpu_user_regs *regs, bool rdtscp) if ( rdtscp && !currd->arch.cpuid->extd.rdtscp ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -2290,14 +2290,14 @@ svm_vmexit_do_vmrun(struct cpu_user_regs *regs, { if ( !nsvm_efer_svm_enabled(v) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } if ( !nestedsvm_vmcb_map(v, vmcbaddr) ) { gdprintk(XENLOG_ERR, "VMRUN: mapping vmcb failed, injecting #GP\n"); - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return; } @@ -2343,7 +2343,7 @@ svm_vmexit_do_vmload(struct vmcb_struct *vmcb, if ( !nsvm_efer_svm_enabled(v) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -2352,7 +2352,7 @@ svm_vmexit_do_vmload(struct vmcb_struct *vmcb, { gdprintk(XENLOG_ERR, "VMLOAD: mapping failed, injecting #GP\n"); - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return; } @@ -2378,7 +2378,7 @@ svm_vmexit_do_vmsave(struct vmcb_struct *vmcb, if ( !nsvm_efer_svm_enabled(v) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -2387,7 +2387,7 @@ svm_vmexit_do_vmsave(struct vmcb_struct *vmcb, { gdprintk(XENLOG_ERR, "VMSAVE: mapping vmcb failed, injecting #GP\n"); - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return; } @@ -2777,7 +2777,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) if ( rc < 0 ) goto unexpected_exit_type; if ( !rc ) - hvm_inject_exception(TRAP_debug, + hvm_inject_exception(X86_EXC_DB, trap_type, insn_len, X86_EVENT_NO_EC); } else @@ -2794,7 +2794,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) { /* AMD Vol2, 15.11: INT3, INTO, BOUND intercepts do not update RIP. */ __update_guest_eip(regs, insn_len); - current->arch.gdbsx_vcpu_event = TRAP_int3; + current->arch.gdbsx_vcpu_event = X86_EXC_BP; domain_pause_for_debugger(); } else @@ -2806,7 +2806,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) if ( rc < 0 ) goto unexpected_exit_type; if ( !rc ) - hvm_inject_exception(TRAP_int3, + hvm_inject_exception(X86_EXC_BP, X86_EVENTTYPE_SW_EXCEPTION, insn_len, X86_EVENT_NO_EC); } @@ -2847,8 +2847,8 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) } case VMEXIT_EXCEPTION_AC: - HVMTRACE_1D(TRAP, TRAP_alignment_check); - hvm_inject_hw_exception(TRAP_alignment_check, vmcb->exitinfo1); + HVMTRACE_1D(TRAP, X86_EXC_AC); + hvm_inject_hw_exception(X86_EXC_AC, vmcb->exitinfo1); break; case VMEXIT_EXCEPTION_UD: @@ -2901,8 +2901,8 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) * semantics. */ case X86_EVENTTYPE_HW_EXCEPTION: - if ( vmcb->exit_int_info.vector == TRAP_int3 || - vmcb->exit_int_info.vector == TRAP_overflow ) + if ( vmcb->exit_int_info.vector == X86_EXC_BP || + vmcb->exit_int_info.vector == X86_EXC_OF ) break; /* Fallthrough */ case X86_EVENTTYPE_EXT_INTR: @@ -2958,7 +2958,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) __update_guest_eip(regs, vmcb->exitinfo2 - vmcb->rip); } else if ( !hvm_emulate_one_insn(x86_insn_is_portio, "port I/O") ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; case VMEXIT_CR0_READ ... VMEXIT_CR15_READ: @@ -2966,7 +2966,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) if ( cpu_has_svm_decode && (vmcb->exitinfo1 & (1ULL << 63)) ) svm_vmexit_do_cr_access(vmcb, regs); else if ( !hvm_emulate_one_insn(x86_insn_is_cr_access, "CR access") ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; case VMEXIT_INVLPG: @@ -2976,13 +2976,13 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) __update_guest_eip(regs, vmcb->nextrip - vmcb->rip); } else if ( !hvm_emulate_one_insn(is_invlpg, "invlpg") ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; case VMEXIT_INVLPGA: if ( !nsvm_efer_svm_enabled(v) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; } if ( (insn_len = svm_get_insn_len(v, INSTR_INVLPGA)) == 0 ) @@ -3023,7 +3023,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) case VMEXIT_MWAIT: case VMEXIT_SKINIT: case VMEXIT_RDPRU: - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; case VMEXIT_VMRUN: @@ -3044,7 +3044,7 @@ void svm_vmexit_handler(struct cpu_user_regs *regs) case VMEXIT_XSETBV: if ( vmcb_get_cpl(vmcb) ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); else if ( (insn_len = svm_get_insn_len(v, INSTR_XSETBV)) && hvm_handle_xsetbv(regs->ecx, msr_fold(regs)) == X86EMUL_OKAY ) __update_guest_eip(regs, insn_len); diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e387..ba06acf2ee99 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -140,7 +140,7 @@ static int construct_vmcb(struct vcpu *v) vmcb->_exception_intercepts = HVM_TRAP_MASK | - (v->arch.fully_eager_fpu ? 0 : (1U << TRAP_no_device)); + (v->arch.fully_eager_fpu ? 0 : (1U << X86_EXC_NM)); if ( paging_mode_hap(v->domain) ) { @@ -164,7 +164,7 @@ static int construct_vmcb(struct vcpu *v) } else { - vmcb->_exception_intercepts |= (1U << TRAP_page_fault); + vmcb->_exception_intercepts |= (1U << X86_EXC_PF); } if ( cpu_has_pause_filter ) diff --git a/xen/arch/x86/hvm/vm_event.c b/xen/arch/x86/hvm/vm_event.c index 19aac19bc354..3b064bcfade5 100644 --- a/xen/arch/x86/hvm/vm_event.c +++ b/xen/arch/x86/hvm/vm_event.c @@ -87,7 +87,7 @@ void hvm_vm_event_do_resume(struct vcpu *v) VM_EVENT_FLAG_SET_EMUL_INSN_DATA ) kind = EMUL_KIND_SET_CONTEXT_INSN; - hvm_emulate_one_vm_event(kind, TRAP_invalid_op, + hvm_emulate_one_vm_event(kind, X86_EXC_UD, X86_EVENT_NO_EC); v->arch.vm_event->emulate_flags = 0; @@ -96,7 +96,7 @@ void hvm_vm_event_do_resume(struct vcpu *v) if ( unlikely(w->do_write.cr0) ) { if ( hvm_set_cr0(w->cr0, false) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); w->do_write.cr0 = 0; } @@ -104,7 +104,7 @@ void hvm_vm_event_do_resume(struct vcpu *v) if ( unlikely(w->do_write.cr4) ) { if ( hvm_set_cr4(w->cr4, false) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); w->do_write.cr4 = 0; } @@ -112,7 +112,7 @@ void hvm_vm_event_do_resume(struct vcpu *v) if ( unlikely(w->do_write.cr3) ) { if ( hvm_set_cr3(w->cr3, w->cr3_noflush, false) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); w->do_write.cr3 = 0; } @@ -121,7 +121,7 @@ void hvm_vm_event_do_resume(struct vcpu *v) { if ( hvm_msr_write_intercept(w->msr, w->value, false) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); w->do_write.msr = 0; } diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e25..87fb537b7c05 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -328,7 +328,7 @@ void vmx_intr_assist(void) } else if ( intack.source == hvm_intsrc_mce ) { - hvm_inject_hw_exception(TRAP_machine_check, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_MC, X86_EVENT_NO_EC); } else if ( cpu_has_vmx_virtual_intr_delivery && intack.source != hvm_intsrc_pic && diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c index 4ac93e081015..ff44ddcfa627 100644 --- a/xen/arch/x86/hvm/vmx/realmode.c +++ b/xen/arch/x86/hvm/vmx/realmode.c @@ -48,21 +48,21 @@ static void realmode_deliver_exception( if ( insn_len != 0 ) { insn_len = 0; - vector = TRAP_gp_fault; + vector = X86_EXC_GP; goto again; } /* Exception or hardware interrupt. */ switch ( vector ) { - case TRAP_double_fault: + case X86_EXC_DF: hvm_triple_fault(); return; - case TRAP_gp_fault: - vector = TRAP_double_fault; + case X86_EXC_GP: + vector = X86_EXC_DF; goto again; default: - vector = TRAP_gp_fault; + vector = X86_EXC_GP; goto again; } } @@ -116,14 +116,14 @@ void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt) if ( curr->arch.hvm.guest_cr[0] & X86_CR0_PE ) goto fail; - realmode_deliver_exception(TRAP_invalid_op, 0, hvmemul_ctxt); + realmode_deliver_exception(X86_EXC_UD, 0, hvmemul_ctxt); } if ( rc == X86EMUL_EXCEPTION ) { if ( unlikely(curr->domain->debugger_attached) && - ((hvmemul_ctxt->ctxt.event.vector == TRAP_debug) || - (hvmemul_ctxt->ctxt.event.vector == TRAP_int3)) ) + ((hvmemul_ctxt->ctxt.event.vector == X86_EXC_DB) || + (hvmemul_ctxt->ctxt.event.vector == X86_EXC_BP)) ) { domain_pause_for_debugger(); } diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index e1c268789e7e..dbf7d3bef6a9 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1293,8 +1293,8 @@ static int construct_vmcs(struct vcpu *v) __vmwrite(VMCS_LINK_POINTER, ~0UL); v->arch.hvm.vmx.exception_bitmap = HVM_TRAP_MASK - | (paging_mode_hap(d) ? 0 : (1U << TRAP_page_fault)) - | (v->arch.fully_eager_fpu ? 0 : (1U << TRAP_no_device)); + | (paging_mode_hap(d) ? 0 : (1U << X86_EXC_PF)) + | (v->arch.fully_eager_fpu ? 0 : (1U << X86_EXC_NM)); if ( cpu_has_vmx_notify_vm_exiting ) __vmwrite(NOTIFY_WINDOW, vm_notify_window); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0ec33bcc184b..7f1ccc2b4c68 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -789,9 +789,9 @@ static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) if ( opt_hvm_fep || (v->domain->arch.cpuid->x86_vendor != boot_cpu_data.x86_vendor) ) - v->arch.hvm.vmx.exception_bitmap |= (1U << TRAP_invalid_op); + v->arch.hvm.vmx.exception_bitmap |= (1U << X86_EXC_UD); else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_invalid_op); + v->arch.hvm.vmx.exception_bitmap &= ~(1U << X86_EXC_UD); vmx_vmcs_enter(v); vmx_update_exception_bitmap(v); @@ -1071,7 +1071,7 @@ static int cf_check vmx_load_vmcs_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt) static void vmx_fpu_enter(struct vcpu *v) { vcpu_restore_fpu_lazy(v); - v->arch.hvm.vmx.exception_bitmap &= ~(1u << TRAP_no_device); + v->arch.hvm.vmx.exception_bitmap &= ~(1u << X86_EXC_NM); vmx_update_exception_bitmap(v); v->arch.hvm.vmx.host_cr0 &= ~X86_CR0_TS; __vmwrite(HOST_CR0, v->arch.hvm.vmx.host_cr0); @@ -1098,7 +1098,7 @@ static void cf_check vmx_fpu_leave(struct vcpu *v) { v->arch.hvm.hw_cr[0] |= X86_CR0_TS; __vmwrite(GUEST_CR0, v->arch.hvm.hw_cr[0]); - v->arch.hvm.vmx.exception_bitmap |= (1u << TRAP_no_device); + v->arch.hvm.vmx.exception_bitmap |= (1u << X86_EXC_NM); vmx_update_exception_bitmap(v); } } @@ -1616,9 +1616,9 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) void vmx_update_debug_state(struct vcpu *v) { if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + v->arch.hvm.vmx.exception_bitmap |= 1U << X86_EXC_BP; else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + v->arch.hvm.vmx.exception_bitmap &= ~(1U << X86_EXC_BP); vmx_vmcs_enter(v); vmx_update_exception_bitmap(v); @@ -2000,7 +2000,7 @@ void vmx_inject_nmi(void) nvmx_enqueue_n2_exceptions (v, INTR_INFO_VALID_MASK | MASK_INSR(X86_EVENTTYPE_NMI, INTR_INFO_INTR_TYPE_MASK) | - MASK_INSR(TRAP_nmi, INTR_INFO_VECTOR_MASK), + MASK_INSR(X86_EXC_NMI, INTR_INFO_VECTOR_MASK), X86_EVENT_NO_EC, hvm_intsrc_nmi); return; } @@ -2025,14 +2025,14 @@ static void cf_check vmx_inject_event(const struct x86_event *event) switch ( _event.vector | -(_event.type == X86_EVENTTYPE_SW_INTERRUPT) ) { - case TRAP_debug: + case X86_EXC_DB: if ( guest_cpu_user_regs()->eflags & X86_EFLAGS_TF ) { __restore_debug_registers(curr); write_debugreg(6, read_debugreg(6) | DR_STEP); } if ( !nestedhvm_vcpu_in_guestmode(curr) || - !nvmx_intercepts_exception(curr, TRAP_debug, _event.error_code) ) + !nvmx_intercepts_exception(curr, X86_EXC_DB, _event.error_code) ) { unsigned long val; @@ -2044,7 +2044,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) if ( cpu_has_monitor_trap_flag ) break; /* fall through */ - case TRAP_int3: + case X86_EXC_BP: if ( curr->domain->debugger_attached ) { /* Debug/Int3: Trap to debugger. */ @@ -2053,7 +2053,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) } break; - case TRAP_page_fault: + case X86_EXC_PF: ASSERT(_event.type == X86_EVENTTYPE_HW_EXCEPTION); curr->arch.hvm.guest_cr[2] = _event.cr2; break; @@ -2070,7 +2070,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) { _event.vector = hvm_combine_hw_exceptions( (uint8_t)intr_info, _event.vector); - if ( _event.vector == TRAP_double_fault ) + if ( _event.vector == X86_EXC_DF ) _event.error_code = 0; } @@ -2090,7 +2090,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) else __vmx_inject_exception(_event.vector, _event.type, _event.error_code); - if ( (_event.vector == TRAP_page_fault) && + if ( (_event.vector == X86_EXC_PF) && (_event.type == X86_EVENTTYPE_HW_EXCEPTION) ) HVMTRACE_LONG_2D(PF_INJECT, _event.error_code, TRC_PAR_LONG(curr->arch.hvm.guest_cr[2])); @@ -2445,7 +2445,7 @@ static bool cf_check vmx_vcpu_emulate_ve(struct vcpu *v) __vmread(GUEST_PHYSICAL_ADDRESS, &veinfo->gpa); vmx_vmcs_exit(v); - hvm_inject_hw_exception(TRAP_virtualisation, + hvm_inject_hw_exception(X86_EXC_VE, X86_EVENT_NO_EC); out: @@ -3077,7 +3077,7 @@ void update_guest_eip(void) } if ( regs->eflags & X86_EFLAGS_TF ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); } static void cf_check vmx_fpu_dirty_intercept(void) @@ -3175,7 +3175,7 @@ static int vmx_cr_access(cr_access_qual_t qual) HVMTRACE_LONG_1D(LMSW, value); if ( (rc = hvm_set_cr0(value, true)) == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return rc; } @@ -4093,9 +4093,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) __vmread(VM_EXIT_INTR_INFO, &intr_info); BUG_ON(!(intr_info & INTR_INFO_VALID_MASK)); vector = intr_info & INTR_INFO_VECTOR_MASK; - if ( vector == TRAP_machine_check ) + if ( vector == X86_EXC_MC ) do_machine_check(regs); - if ( (vector == TRAP_nmi) && + if ( (vector == X86_EXC_NMI) && ((intr_info & INTR_INFO_INTR_TYPE_MASK) == MASK_INSR(X86_EVENTTYPE_NMI, INTR_INFO_INTR_TYPE_MASK)) ) { @@ -4192,9 +4192,8 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) switch ( exit_reason ) { case EXIT_REASON_EXCEPTION_NMI: - if ( vector != TRAP_page_fault - && vector != TRAP_nmi - && vector != TRAP_machine_check ) + if ( vector != X86_EXC_PF && vector != X86_EXC_NMI && + vector != X86_EXC_MC ) { default: perfc_incr(realmode_exits); @@ -4243,14 +4242,14 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) */ if ( unlikely(intr_info & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && !(idtv_info & INTR_INFO_VALID_MASK) && - (vector != TRAP_double_fault) ) + (vector != X86_EXC_DF) ) undo_nmis_unblocked_by_iret(); perfc_incra(cause_vector, vector); switch ( vector ) { - case TRAP_debug: + case X86_EXC_DB: /* * Updates DR6 where debugger can peek (See 3B 23.2.1, * Table 23-1, "Exit Qualification for Debug Exceptions"). @@ -4317,7 +4316,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) else domain_pause_for_debugger(); break; - case TRAP_int3: + case X86_EXC_BP: HVMTRACE_1D(TRAP, vector); if ( !v->domain->debugger_attached ) { @@ -4338,15 +4337,15 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) else { update_guest_eip(); /* Safe: INT3 */ - v->arch.gdbsx_vcpu_event = TRAP_int3; + v->arch.gdbsx_vcpu_event = X86_EXC_BP; domain_pause_for_debugger(); } break; - case TRAP_no_device: + case X86_EXC_NM: HVMTRACE_1D(TRAP, vector); vmx_fpu_dirty_intercept(); break; - case TRAP_page_fault: + case X86_EXC_PF: __vmread(EXIT_QUALIFICATION, &exit_qualification); __vmread(VM_EXIT_INTR_ERROR_CODE, &ecode); regs->error_code = ecode; @@ -4371,22 +4370,22 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) hvm_inject_page_fault(regs->error_code, exit_qualification); break; - case TRAP_alignment_check: + case X86_EXC_AC: HVMTRACE_1D(TRAP, vector); vmx_propagate_intr(intr_info); break; - case TRAP_nmi: + case X86_EXC_NMI: if ( MASK_EXTR(intr_info, INTR_INFO_INTR_TYPE_MASK) != X86_EVENTTYPE_NMI ) goto exit_and_crash; HVMTRACE_0D(NMI); /* Already handled above. */ break; - case TRAP_machine_check: + case X86_EXC_MC: HVMTRACE_0D(MCE); /* Already handled above. */ break; - case TRAP_invalid_op: + case X86_EXC_UD: HVMTRACE_1D(TRAP, vector); hvm_ud_intercept(regs); break; @@ -4467,7 +4466,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) case EXIT_REASON_RDTSCP: if ( !currd->arch.cpuid->extd.rdtscp ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; } @@ -4508,7 +4507,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) break; case X86EMUL_EXCEPTION: - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; } break; @@ -4522,7 +4521,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) break; case X86EMUL_EXCEPTION: - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; } break; @@ -4544,7 +4543,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) case EXIT_REASON_VMFUNC: if ( vmx_vmfunc_intercept(regs) != X86EMUL_OKAY ) - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); else update_guest_eip(); break; @@ -4558,7 +4557,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) * as far as vmexit. */ WARN_ON(exit_reason == EXIT_REASON_GETSEC); - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); break; case EXIT_REASON_TPR_BELOW_THRESHOLD: @@ -4566,7 +4565,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) case EXIT_REASON_APIC_ACCESS: if ( !vmx_handle_eoi_write() && !handle_mmio() ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); break; case EXIT_REASON_EOI_INDUCED: @@ -4583,7 +4582,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) { /* INS, OUTS */ if ( !hvm_emulate_one_insn(x86_insn_is_portio, "port I/O") ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); } else { @@ -4714,7 +4713,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) gprintk(XENLOG_ERR, "Unexpected vmexit: reason %lu\n", exit_reason); if ( vmx_get_cpl() ) - hvm_inject_hw_exception(TRAP_invalid_op, + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); else domain_crash(v->domain); @@ -4745,7 +4744,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) { __vmread(VM_ENTRY_INTR_INFO, &intr_info); if ( !(intr_info & INTR_INFO_VALID_MASK) ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); /* Need to fix rIP nevertheless. */ if ( mode == 8 ) regs->rip = (long)(regs->rip << (64 - VADDR_BITS)) >> diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb0736..27221fdb733b 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -474,7 +474,7 @@ static int decode_vmx_inst(struct cpu_user_regs *regs, return X86EMUL_OKAY; gp_fault: - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return X86EMUL_EXCEPTION; } @@ -526,7 +526,7 @@ bool cf_check nvmx_intercepts_exception( exception_bitmap = get_vvmcs(v, EXCEPTION_BITMAP); r = exception_bitmap & (1 << vector) ? 1: 0; - if ( vector == TRAP_page_fault ) + if ( vector == X86_EXC_PF ) { pfec_match = get_vvmcs(v, PAGE_FAULT_ERROR_CODE_MATCH); pfec_mask = get_vvmcs(v, PAGE_FAULT_ERROR_CODE_MASK); @@ -1100,15 +1100,15 @@ static void load_shadow_guest_state(struct vcpu *v) rc = hvm_set_cr4(get_vvmcs(v, GUEST_CR4), true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = hvm_set_cr0(get_vvmcs(v, GUEST_CR0), true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = hvm_set_cr3(get_vvmcs(v, GUEST_CR3), false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); control = get_vvmcs(v, VM_ENTRY_CONTROLS); if ( control & VM_ENTRY_LOAD_GUEST_PAT ) @@ -1118,7 +1118,7 @@ static void load_shadow_guest_state(struct vcpu *v) rc = hvm_msr_write_intercept(MSR_CORE_PERF_GLOBAL_CTRL, get_vvmcs(v, GUEST_PERF_GLOBAL_CTRL), false); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); } hvm_set_tsc_offset(v, v->arch.hvm.cache_tsc_offset, 0); @@ -1314,15 +1314,15 @@ static void load_vvmcs_host_state(struct vcpu *v) rc = hvm_set_cr4(get_vvmcs(v, HOST_CR4), true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = hvm_set_cr0(get_vvmcs(v, HOST_CR0), true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); rc = hvm_set_cr3(get_vvmcs(v, HOST_CR3), false, true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); control = get_vvmcs(v, VM_EXIT_CONTROLS); if ( control & VM_EXIT_LOAD_HOST_PAT ) @@ -1332,7 +1332,7 @@ static void load_vvmcs_host_state(struct vcpu *v) rc = hvm_msr_write_intercept(MSR_CORE_PERF_GLOBAL_CTRL, get_vvmcs(v, HOST_PERF_GLOBAL_CTRL), true); if ( rc == X86EMUL_EXCEPTION ) - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); } hvm_set_tsc_offset(v, v->arch.hvm.cache_tsc_offset, 0); @@ -2083,13 +2083,13 @@ int nvmx_handle_vmx_insn(struct cpu_user_regs *regs, unsigned int exit_reason) (vmx_guest_x86_mode(curr) < (hvm_long_mode_active(curr) ? 8 : 2)) || (exit_reason != EXIT_REASON_VMXON && !nvmx_vcpu_in_vmx(curr)) ) { - hvm_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return X86EMUL_EXCEPTION; } if ( vmx_get_cpl() > 0 ) { - hvm_inject_hw_exception(TRAP_gp_fault, 0); + hvm_inject_hw_exception(X86_EXC_GP, 0); return X86EMUL_EXCEPTION; } @@ -2464,12 +2464,12 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs, * decided by L0 and L1 exception bitmap, if the vetor is set by * both, L0 has priority on #PF and #NM, L1 has priority on others */ - if ( vector == TRAP_page_fault ) + if ( vector == X86_EXC_PF ) { if ( paging_mode_hap(v->domain) ) nvcpu->nv_vmexit_pending = 1; } - else if ( vector == TRAP_no_device ) + else if ( vector == X86_EXC_NM ) { if ( v->fpu_dirtied ) nvcpu->nv_vmexit_pending = 1; diff --git a/xen/arch/x86/include/asm/domain.h b/xen/arch/x86/include/asm/domain.h index b5354c367750..296a1ee79127 100644 --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -722,7 +722,7 @@ static inline void pv_inject_hw_exception(unsigned int vector, int errcode) static inline void pv_inject_page_fault(int errcode, unsigned long cr2) { const struct x86_event event = { - .vector = TRAP_page_fault, + .vector = X86_EXC_PF, .type = X86_EVENTTYPE_HW_EXCEPTION, .error_code = errcode, .cr2 = cr2, diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 43d3fc249887..258e0a1f2931 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -540,7 +540,7 @@ static inline void hvm_inject_hw_exception(unsigned int vector, int errcode) static inline void hvm_inject_page_fault(int errcode, unsigned long cr2) { struct x86_event event = { - .vector = TRAP_page_fault, + .vector = X86_EXC_PF, .type = X86_EVENTTYPE_HW_EXCEPTION, .error_code = errcode, .cr2 = cr2, @@ -564,9 +564,9 @@ static inline void hvm_invlpg(struct vcpu *v, unsigned long linear) (X86_CR4_VMXE | X86_CR4_PAE | X86_CR4_MCE)) /* These exceptions must always be intercepted. */ -#define HVM_TRAP_MASK ((1U << TRAP_debug) | \ - (1U << TRAP_alignment_check) | \ - (1U << TRAP_machine_check)) +#define HVM_TRAP_MASK ((1U << X86_EXC_DB) | \ + (1U << X86_EXC_AC) | \ + (1U << X86_EXC_MC)) /* Called in boot/resume paths. Must cope with no HVM support. */ static inline int hvm_cpu_up(void) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 8725e0df11e9..2095d9a4e28d 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -17,34 +17,6 @@ #include #include -/* - * Trap/fault mnemonics. - */ -#define TRAP_divide_error 0 -#define TRAP_debug 1 -#define TRAP_nmi 2 -#define TRAP_int3 3 -#define TRAP_overflow 4 -#define TRAP_bounds 5 -#define TRAP_invalid_op 6 -#define TRAP_no_device 7 -#define TRAP_double_fault 8 -#define TRAP_copro_seg 9 -#define TRAP_invalid_tss 10 -#define TRAP_no_segment 11 -#define TRAP_stack_error 12 -#define TRAP_gp_fault 13 -#define TRAP_page_fault 14 -#define TRAP_spurious_int 15 -#define TRAP_copro_error 16 -#define TRAP_alignment_check 17 -#define TRAP_machine_check 18 -#define TRAP_simd_error 19 -#define TRAP_virtualisation 20 -#define TRAP_nr 32 - -#define TRAP_HAVE_EC X86_EXC_HAVE_EC - /* Set for entry via SYSCALL. Informs return code to use SYSRETQ not IRETQ. */ /* NB. Same as VGCF_in_syscall. No bits in common with any other TRAP_ defn. */ #define TRAP_syscall 256 @@ -431,18 +403,18 @@ static inline void set_ist(idt_entry_t *idt, unsigned int ist) static inline void enable_each_ist(idt_entry_t *idt) { - set_ist(&idt[TRAP_double_fault], IST_DF); - set_ist(&idt[TRAP_nmi], IST_NMI); - set_ist(&idt[TRAP_machine_check], IST_MCE); - set_ist(&idt[TRAP_debug], IST_DB); + set_ist(&idt[X86_EXC_DF], IST_DF); + set_ist(&idt[X86_EXC_NMI], IST_NMI); + set_ist(&idt[X86_EXC_MC], IST_MCE); + set_ist(&idt[X86_EXC_DB], IST_DB); } static inline void disable_each_ist(idt_entry_t *idt) { - set_ist(&idt[TRAP_double_fault], IST_NONE); - set_ist(&idt[TRAP_nmi], IST_NONE); - set_ist(&idt[TRAP_machine_check], IST_NONE); - set_ist(&idt[TRAP_debug], IST_NONE); + set_ist(&idt[X86_EXC_DF], IST_NONE); + set_ist(&idt[X86_EXC_NMI], IST_NONE); + set_ist(&idt[X86_EXC_MC], IST_NONE); + set_ist(&idt[X86_EXC_DB], IST_NONE); } #define IDT_ENTRIES 256 diff --git a/xen/arch/x86/include/asm/x86-defns.h b/xen/arch/x86/include/asm/x86-defns.h index fe1caba6f819..e350227e57eb 100644 --- a/xen/arch/x86/include/asm/x86-defns.h +++ b/xen/arch/x86/include/asm/x86-defns.h @@ -147,6 +147,8 @@ #define X86_EXC_VC 29 /* VMM Communication */ #define X86_EXC_SX 30 /* Security Exception */ +#define X86_EXC_NUM 32 /* 32 reserved vectors */ + /* Bitmap of exceptions which have error codes. */ #define X86_EXC_HAVE_EC \ ((1u << X86_EXC_DF) | (1u << X86_EXC_TS) | (1u << X86_EXC_NP) | \ diff --git a/xen/arch/x86/machine_kexec.c b/xen/arch/x86/machine_kexec.c index 1dd0c9aad802..d50772ad6ca3 100644 --- a/xen/arch/x86/machine_kexec.c +++ b/xen/arch/x86/machine_kexec.c @@ -170,7 +170,7 @@ void machine_kexec(struct kexec_image *image) { if ( idt_tables[i] == NULL ) continue; - _update_gate_addr_lower(&idt_tables[i][TRAP_machine_check], &trap_nop); + _update_gate_addr_lower(&idt_tables[i][X86_EXC_MC], &trap_nop); } /* Reset CPUID masking and faulting to the host's default. */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0fe14faa5fa7..8e6d000950f8 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1232,7 +1232,7 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner) gprintk(XENLOG_WARNING, "Attempt to implicitly unmap %pd's grant PTE %" PRIpte "\n", l1e_owner, l1e_get_intpte(l1e)); - pv_inject_hw_exception(TRAP_gp_fault, 0); + pv_inject_hw_exception(X86_EXC_GP, 0); } #endif diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index f3aed9fcc966..676d92297368 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -219,7 +219,7 @@ bool p2m_mem_access_check(paddr_t gpa, unsigned long gla, npfec.kind == npfec_kind_in_gpt ) { v->arch.vm_event->send_event = true; - hvm_emulate_one_vm_event(EMUL_KIND_NORMAL, TRAP_invalid_op, X86_EVENT_NO_EC); + hvm_emulate_one_vm_event(EMUL_KIND_NORMAL, X86_EXC_UD, X86_EVENT_NO_EC); v->arch.vm_event->send_event = false; return true; diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c index 88c3c16322f2..1bc24e41ba12 100644 --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -98,7 +98,7 @@ static int hvm_translate_virtual_addr( */ if ( is_x86_user_segment(seg) ) x86_emul_hw_exception( - (seg == x86_seg_ss) ? TRAP_stack_error : TRAP_gp_fault, + (seg == x86_seg_ss) ? X86_EXC_SS : X86_EXC_GP, 0, &sh_ctxt->ctxt); return X86EMUL_EXCEPTION; } diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c index 5f3e175bbe03..252fede87d7f 100644 --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -2745,9 +2745,9 @@ static int cf_check sh_page_fault( * stream under Xen's feet. */ if ( emul_ctxt.ctxt.event.type == X86_EVENTTYPE_HW_EXCEPTION && - ((emul_ctxt.ctxt.event.vector == TRAP_page_fault) || - (((emul_ctxt.ctxt.event.vector == TRAP_gp_fault) || - (emul_ctxt.ctxt.event.vector == TRAP_stack_error)) && + ((emul_ctxt.ctxt.event.vector == X86_EXC_PF) || + (((emul_ctxt.ctxt.event.vector == X86_EXC_GP) || + (emul_ctxt.ctxt.event.vector == X86_EXC_SS)) && emul_ctxt.ctxt.event.error_code == 0)) ) hvm_inject_event(&emul_ctxt.ctxt.event); else @@ -2809,7 +2809,7 @@ static int cf_check sh_page_fault( #endif if ( emul_ctxt.ctxt.retire.singlestep ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); #if GUEST_PAGING_LEVELS == 3 /* PAE guest */ /* @@ -2850,7 +2850,7 @@ static int cf_check sh_page_fault( TRACE_SHADOW_PATH_FLAG(TRCE_SFLAG_EMULATION_LAST_FAILED); if ( emul_ctxt.ctxt.retire.singlestep ) - hvm_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + hvm_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); break; /* Don't emulate again if we failed! */ } diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c index 067ee3b795d0..ca3bc30e91ba 100644 --- a/xen/arch/x86/pv/callback.c +++ b/xen/arch/x86/pv/callback.c @@ -29,12 +29,12 @@ static int register_guest_nmi_callback(unsigned long address) { struct vcpu *curr = current; struct domain *d = curr->domain; - struct trap_info *t = &curr->arch.pv.trap_ctxt[TRAP_nmi]; + struct trap_info *t = &curr->arch.pv.trap_ctxt[X86_EXC_NMI]; if ( !is_canonical_address(address) ) return -EINVAL; - t->vector = TRAP_nmi; + t->vector = X86_EXC_NMI; t->flags = 0; t->cs = (is_pv_32bit_domain(d) ? FLAT_COMPAT_KERNEL_CS : FLAT_KERNEL_CS); @@ -54,7 +54,7 @@ static int register_guest_nmi_callback(unsigned long address) static void unregister_guest_nmi_callback(void) { struct vcpu *curr = current; - struct trap_info *t = &curr->arch.pv.trap_ctxt[TRAP_nmi]; + struct trap_info *t = &curr->arch.pv.trap_ctxt[X86_EXC_NMI]; memset(t, 0, sizeof(*t)); } diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c index 758a20ad9df4..9524982e7d2d 100644 --- a/xen/arch/x86/pv/emul-gate-op.c +++ b/xen/arch/x86/pv/emul-gate-op.c @@ -185,12 +185,12 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) (((ar >> 13) & 3) < (regs->cs & 3)) || ((ar & _SEGMENT_TYPE) != 0xc00) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } if ( !(ar & _SEGMENT_P) ) { - pv_inject_hw_exception(TRAP_no_segment, regs->error_code); + pv_inject_hw_exception(X86_EXC_NP, regs->error_code); return; } dpl = (ar >> 13) & 3; @@ -206,7 +206,7 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) !(ar & _SEGMENT_P) || !(ar & _SEGMENT_CODE) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } @@ -219,7 +219,7 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) if ( PTR_ERR(state) == -X86EMUL_EXCEPTION ) pv_inject_event(&ctxt.ctxt.event); else - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } @@ -268,7 +268,7 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) (opnd_sel & ~3) != regs->error_code || dpl < (opnd_sel & 3) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } @@ -279,17 +279,17 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) ((ar >> 13) & 3) > (regs->cs & 3) : ((ar >> 13) & 3) != (regs->cs & 3)) ) { - pv_inject_hw_exception(TRAP_gp_fault, sel); + pv_inject_hw_exception(X86_EXC_GP, sel); return; } if ( !(ar & _SEGMENT_P) ) { - pv_inject_hw_exception(TRAP_no_segment, sel); + pv_inject_hw_exception(X86_EXC_NP, sel); return; } if ( off > limit ) { - pv_inject_hw_exception(TRAP_gp_fault, 0); + pv_inject_hw_exception(X86_EXC_GP, 0); return; } @@ -316,7 +316,7 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) /* Inner stack known only for kernel ring. */ if ( (sel & 3) != GUEST_KERNEL_RPL(v->domain) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } esp = v->arch.pv.kernel_sp; @@ -328,19 +328,19 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) (ar & _SEGMENT_CODE) || !(ar & _SEGMENT_WR) ) { - pv_inject_hw_exception(TRAP_invalid_tss, ss & ~3); + pv_inject_hw_exception(X86_EXC_TS, ss & ~3); return; } if ( !(ar & _SEGMENT_P) || !check_stack_limit(ar, limit, esp, (4 + nparm) * 4) ) { - pv_inject_hw_exception(TRAP_stack_error, ss & ~3); + pv_inject_hw_exception(X86_EXC_SS, ss & ~3); return; } stkp = (unsigned int *)(unsigned long)((unsigned int)base + esp); if ( !compat_access_ok(stkp - 4 - nparm, 16 + nparm * 4) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } push(regs->ss); @@ -356,12 +356,12 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) (ar & _SEGMENT_CODE) || !(ar & _SEGMENT_WR) || !check_stack_limit(ar, limit, esp + nparm * 4, nparm * 4) ) - return pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + return pv_inject_hw_exception(X86_EXC_GP, regs->error_code); ustkp = (unsigned int *)(unsigned long) ((unsigned int)base + regs->esp + nparm * 4); if ( !compat_access_ok(ustkp - nparm, 0 + nparm * 4) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } do @@ -387,18 +387,18 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs) if ( !pv_emul_read_descriptor(ss, v, &base, &limit, &ar, 0) || ((ar >> 13) & 3) != (sel & 3) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } if ( !check_stack_limit(ar, limit, esp, 2 * 4) ) { - pv_inject_hw_exception(TRAP_stack_error, 0); + pv_inject_hw_exception(X86_EXC_SS, 0); return; } stkp = (unsigned int *)(unsigned long)((unsigned int)base + esp); if ( !compat_access_ok(stkp - 2, 2 * 4) ) { - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; } } diff --git a/xen/arch/x86/pv/emul-inv-op.c b/xen/arch/x86/pv/emul-inv-op.c index 2c07eed9a092..32eb34e1a291 100644 --- a/xen/arch/x86/pv/emul-inv-op.c +++ b/xen/arch/x86/pv/emul-inv-op.c @@ -57,7 +57,7 @@ static int emulate_forced_invalid_op(struct cpu_user_regs *regs) !guest_kernel_mode(current, regs) ) { regs->rip = eip; - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return EXCRET_fault_fixed; } diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c index 5da00e24e4ff..5ef8c184ed66 100644 --- a/xen/arch/x86/pv/emul-priv-op.c +++ b/xen/arch/x86/pv/emul-priv-op.c @@ -609,8 +609,7 @@ static int pv_emul_virt_to_linear(unsigned long base, unsigned long offset, rc = X86EMUL_EXCEPTION; if ( unlikely(rc == X86EMUL_EXCEPTION) ) - x86_emul_hw_exception(seg != x86_seg_ss ? TRAP_gp_fault - : TRAP_stack_error, + x86_emul_hw_exception(seg != x86_seg_ss ? X86_EXC_GP : X86_EXC_SS, 0, ctxt); return rc; @@ -645,7 +644,7 @@ static int cf_check rep_ins( (sreg.type & (_SEGMENT_CODE >> 8)) || !(sreg.type & (_SEGMENT_WR >> 8)) ) { - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return X86EMUL_EXCEPTION; } @@ -711,8 +710,7 @@ static int cf_check rep_outs( ((sreg.type & (_SEGMENT_CODE >> 8)) && !(sreg.type & (_SEGMENT_WR >> 8))) ) { - x86_emul_hw_exception(seg != x86_seg_ss ? TRAP_gp_fault - : TRAP_stack_error, + x86_emul_hw_exception(seg != x86_seg_ss ? X86_EXC_GP : X86_EXC_SS, 0, ctxt); return X86EMUL_EXCEPTION; } @@ -893,7 +891,7 @@ static int cf_check read_msr( if ( (ret = guest_rdmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) { if ( ret == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); goto done; } @@ -1041,7 +1039,7 @@ static int cf_check write_msr( if ( (ret = guest_wrmsr(curr, reg, val)) != X86EMUL_UNHANDLEABLE ) { if ( ret == X86EMUL_EXCEPTION ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return ret; } @@ -1376,7 +1374,7 @@ int pv_emulate_privileged_op(struct cpu_user_regs *regs) { curr->arch.dr6 |= ctxt.bpmatch | DR_STATUS_RESERVED_ONE; if ( !(curr->arch.pv.trap_bounce.flags & TBF_EXCEPTION) ) - pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); } /* fall through */ case X86EMUL_RETRY: diff --git a/xen/arch/x86/pv/emulate.c b/xen/arch/x86/pv/emulate.c index 0a7907ec5e84..2eff77c577e5 100644 --- a/xen/arch/x86/pv/emulate.c +++ b/xen/arch/x86/pv/emulate.c @@ -86,7 +86,7 @@ void pv_emul_instruction_done(struct cpu_user_regs *regs, unsigned long rip) if ( regs->eflags & X86_EFLAGS_TF ) { current->arch.dr6 |= DR_STEP | DR_STATUS_RESERVED_ONE; - pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); } } diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c index 316a23e77eb7..d3a1fb2c685b 100644 --- a/xen/arch/x86/pv/iret.c +++ b/xen/arch/x86/pv/iret.c @@ -186,7 +186,7 @@ int compat_iret(void) regs->esp = ksp; regs->ss = v->arch.pv.kernel_ss; - ti = &v->arch.pv.trap_ctxt[TRAP_gp_fault]; + ti = &v->arch.pv.trap_ctxt[X86_EXC_GP]; if ( TI_GET_IF(ti) ) eflags &= ~X86_EFLAGS_IF; regs->eflags &= ~(X86_EFLAGS_VM|X86_EFLAGS_RF| diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index 5963f5ee2d51..d1fdbff0e909 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -390,7 +390,7 @@ int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs) * or a guest playing with the instruction stream under Xen's feet. */ if ( ctxt.event.type == X86_EVENTTYPE_HW_EXCEPTION && - ctxt.event.vector == TRAP_page_fault ) + ctxt.event.vector == X86_EXC_PF ) pv_inject_event(&ctxt.event); else gdprintk(XENLOG_WARNING, @@ -400,7 +400,7 @@ int pv_ro_page_fault(unsigned long addr, struct cpu_user_regs *regs) /* Fallthrough */ case X86EMUL_OKAY: if ( ctxt.retire.singlestep ) - pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); /* Fallthrough */ case X86EMUL_RETRY: diff --git a/xen/arch/x86/pv/traps.c b/xen/arch/x86/pv/traps.c index 21f4860f7832..e3e030a5051b 100644 --- a/xen/arch/x86/pv/traps.c +++ b/xen/arch/x86/pv/traps.c @@ -43,7 +43,7 @@ void pv_inject_event(const struct x86_event *event) if ( event->type == X86_EVENTTYPE_HW_EXCEPTION ) { ASSERT(vector < 32); - use_error_code = TRAP_HAVE_EC & (1u << vector); + use_error_code = X86_EXC_HAVE_EC & (1u << vector); } else { @@ -63,7 +63,7 @@ void pv_inject_event(const struct x86_event *event) tb->eip = ti->address; if ( event->type == X86_EVENTTYPE_HW_EXCEPTION && - vector == TRAP_page_fault ) + vector == X86_EXC_PF ) { curr->arch.pv.ctrlreg[2] = event->cr2; arch_set_cr2(curr, event->cr2); @@ -93,7 +93,7 @@ void pv_inject_event(const struct x86_event *event) "Unhandled: vec %u, %s[%04x]\n", vector, vector_name(vector), error_code); - if ( vector == TRAP_page_fault ) + if ( vector == X86_EXC_PF ) show_page_walk(event->cr2); } } @@ -107,7 +107,7 @@ bool set_guest_machinecheck_trapbounce(void) struct vcpu *curr = current; struct trap_bounce *tb = &curr->arch.pv.trap_bounce; - pv_inject_hw_exception(TRAP_machine_check, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_MC, X86_EVENT_NO_EC); tb->flags &= ~TBF_EXCEPTION; /* not needed for MCE delivery path */ return !null_trap_bounce(curr, tb); @@ -122,7 +122,7 @@ bool set_guest_nmi_trapbounce(void) struct vcpu *curr = current; struct trap_bounce *tb = &curr->arch.pv.trap_bounce; - pv_inject_hw_exception(TRAP_nmi, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_NMI, X86_EVENT_NO_EC); tb->flags &= ~TBF_EXCEPTION; /* not needed for NMI delivery path */ return !null_trap_bounce(curr, tb); diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index bfd335777177..25a0c666cc14 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -805,7 +805,7 @@ void fatal_trap(const struct cpu_user_regs *regs, bool show_remote) show_execution_state(regs); - if ( trapnr == TRAP_page_fault ) + if ( trapnr == X86_EXC_PF ) show_page_walk(read_cr2()); if ( show_remote ) @@ -944,7 +944,7 @@ void do_trap(struct cpu_user_regs *regs) if ( guest_mode(regs) ) { pv_inject_hw_exception(trapnr, - (TRAP_HAVE_EC & (1u << trapnr)) + (X86_EXC_HAVE_EC & (1u << trapnr)) ? regs->error_code : X86_EVENT_NO_EC); return; } @@ -1176,7 +1176,7 @@ void do_invalid_op(struct cpu_user_regs *regs) if ( likely(guest_mode(regs)) ) { if ( pv_emulate_invalid_op(regs) ) - pv_inject_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC); return; } @@ -1241,7 +1241,7 @@ void do_invalid_op(struct cpu_user_regs *regs) case BUGFRAME_bug: printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + if ( debugger_trap_fatal(X86_EXC_UD, regs) ) return; show_execution_state(regs); @@ -1256,7 +1256,7 @@ void do_invalid_op(struct cpu_user_regs *regs) printk("Assertion '%s' failed at %s%s:%d\n", predicate, prefix, filename, lineno); - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + if ( debugger_trap_fatal(X86_EXC_UD, regs) ) return; show_execution_state(regs); @@ -1268,11 +1268,11 @@ void do_invalid_op(struct cpu_user_regs *regs) if ( likely(extable_fixup(regs, true)) ) return; - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + if ( debugger_trap_fatal(X86_EXC_UD, regs) ) return; show_execution_state(regs); - panic("FATAL TRAP: vector = %d (invalid opcode)\n", TRAP_invalid_op); + panic("FATAL TRAP: vector = %d (invalid opcode)\n", X86_EXC_UD); } void do_int3(struct cpu_user_regs *regs) @@ -1284,7 +1284,7 @@ void do_int3(struct cpu_user_regs *regs) if ( likely(extable_fixup(regs, true)) ) return; - if ( !debugger_trap_fatal(TRAP_int3, regs) ) + if ( !debugger_trap_fatal(X86_EXC_BP, regs) ) printk(XENLOG_DEBUG "Hit embedded breakpoint at %p [%ps]\n", _p(regs->rip), _p(regs->rip)); @@ -1293,12 +1293,12 @@ void do_int3(struct cpu_user_regs *regs) if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached ) { - curr->arch.gdbsx_vcpu_event = TRAP_int3; + curr->arch.gdbsx_vcpu_event = X86_EXC_BP; domain_pause_for_debugger(); return; } - pv_inject_hw_exception(TRAP_int3, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_BP, X86_EVENT_NO_EC); } void do_general_protection(struct cpu_user_regs *regs) @@ -1363,7 +1363,7 @@ void do_general_protection(struct cpu_user_regs *regs) } /* Pass on GPF as is. */ - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + pv_inject_hw_exception(X86_EXC_GP, regs->error_code); return; #endif @@ -1372,7 +1372,7 @@ void do_general_protection(struct cpu_user_regs *regs) return; hardware_gp: - if ( debugger_trap_fatal(TRAP_gp_fault, regs) ) + if ( debugger_trap_fatal(X86_EXC_GP, regs) ) return; show_execution_state(regs); @@ -1410,7 +1410,7 @@ static int handle_ldt_mapping_fault(unsigned int offset, { uint16_t ec = (offset & ~(X86_XEC_EXT | X86_XEC_IDT)) | X86_XEC_TI; - pv_inject_hw_exception(TRAP_gp_fault, ec); + pv_inject_hw_exception(X86_EXC_GP, ec); } else /* else pass the #PF back, with adjusted %cr2. */ @@ -1698,7 +1698,7 @@ void do_page_fault(struct cpu_user_regs *regs) } fatal: - if ( debugger_trap_fatal(TRAP_page_fault, regs) ) + if ( debugger_trap_fatal(X86_EXC_PF, regs) ) return; show_execution_state(regs); @@ -1945,7 +1945,7 @@ void do_device_not_available(struct cpu_user_regs *regs) if ( curr->arch.pv.ctrlreg[0] & X86_CR0_TS ) { - pv_inject_hw_exception(TRAP_no_device, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_NM, X86_EVENT_NO_EC); curr->arch.pv.ctrlreg[0] &= ~X86_CR0_TS; } else @@ -2009,7 +2009,7 @@ void do_debug(struct cpu_user_regs *regs) return; } #endif - if ( !debugger_trap_fatal(TRAP_debug, regs) ) + if ( !debugger_trap_fatal(X86_EXC_DB, regs) ) { WARN(); regs->eflags &= ~X86_EFLAGS_TF; @@ -2077,7 +2077,7 @@ void do_debug(struct cpu_user_regs *regs) return; } - pv_inject_hw_exception(TRAP_debug, X86_EVENT_NO_EC); + pv_inject_hw_exception(X86_EXC_DB, X86_EVENT_NO_EC); } void do_entry_CP(struct cpu_user_regs *regs) diff --git a/xen/arch/x86/x86_64/compat/entry.S b/xen/arch/x86/x86_64/compat/entry.S index b86d38d1c50d..bd5abd8040bd 100644 --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -208,13 +208,13 @@ ENTRY(compat_syscall) leal (,%rcx,TBF_INTERRUPT),%ecx UNLIKELY_START(z, compat_syscall_gpf) movq VCPU_trap_ctxt(%rbx),%rdi - movl $TRAP_gp_fault,UREGS_entry_vector(%rsp) + movl $X86_EXC_GP, UREGS_entry_vector(%rsp) subl $2,UREGS_rip(%rsp) /* %r12 is still zero at this point. */ mov %r12d, TRAPBOUNCE_error_code(%rdx) - movl TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_eip(%rdi),%eax - movzwl TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_cs(%rdi),%esi - testb $4,TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_flags(%rdi) + movl X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_eip(%rdi),%eax + movzwl X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_cs(%rdi),%esi + testb $4, X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_flags(%rdi) setnz %cl leal TBF_EXCEPTION|TBF_EXCEPTION_ERRCODE(,%rcx,TBF_INTERRUPT),%ecx UNLIKELY_END(compat_syscall_gpf) @@ -226,9 +226,9 @@ UNLIKELY_END(compat_syscall_gpf) ENTRY(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx - cmpb $TRAP_gp_fault,UREGS_entry_vector(%rsp) + cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp) movzwl VCPU_sysenter_sel(%rbx),%eax - movzwl TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_cs(%rcx),%ecx + movzwl X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_cs(%rcx),%ecx cmovel %ecx,%eax testl $~3,%eax movl $FLAT_COMPAT_USER_SS,UREGS_ss(%rsp) diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S index 6d7c15ce4371..16acd01c6087 100644 --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -413,10 +413,10 @@ UNLIKELY_END(sysenter_nt_set) leal (,%rcx,TBF_INTERRUPT),%ecx UNLIKELY_START(z, sysenter_gpf) movq VCPU_trap_ctxt(%rbx),%rsi - movl $TRAP_gp_fault,UREGS_entry_vector(%rsp) + movl $X86_EXC_GP, UREGS_entry_vector(%rsp) movl %eax,TRAPBOUNCE_error_code(%rdx) - movq TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_eip(%rsi),%rax - testb $4,TRAP_gp_fault * TRAPINFO_sizeof + TRAPINFO_flags(%rsi) + movq X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_eip(%rsi),%rax + testb $4, X86_EXC_GP * TRAPINFO_sizeof + TRAPINFO_flags(%rsi) setnz %cl leal TBF_EXCEPTION|TBF_EXCEPTION_ERRCODE(,%rcx,TBF_INTERRUPT),%ecx UNLIKELY_END(sysenter_gpf) @@ -507,7 +507,7 @@ int80_slow_path: * IDT entry with DPL==0. */ movl $((0x80 << 3) | X86_XEC_IDT),UREGS_error_code(%rsp) - movl $TRAP_gp_fault,UREGS_entry_vector(%rsp) + movl $X86_EXC_GP, UREGS_entry_vector(%rsp) /* A GPF wouldn't have incremented the instruction pointer. */ subq $2,UREGS_rip(%rsp) /* @@ -693,7 +693,7 @@ ret_from_intr: .section .init.text, "ax", @progbits ENTRY(early_page_fault) ENDBR64 - movl $TRAP_page_fault, 4(%rsp) + movl $X86_EXC_PF, 4(%rsp) SAVE_ALL movq %rsp, %rdi call do_early_page_fault @@ -808,13 +808,13 @@ handle_exception_saved: jnz .Lcr4_pv32_done /* * The below effectively is - * if ( regs->entry_vector == TRAP_page_fault && + * if ( regs->entry_vector == X86_EXC_PF && * (regs->error_code & PFEC_page_present) && * !(regs->error_code & ~(PFEC_write_access|PFEC_insn_fetch)) ) * goto compat_test_all_events; */ mov $PFEC_page_present,%al - cmpb $TRAP_page_fault,UREGS_entry_vector(%rsp) + cmpb $X86_EXC_PF, UREGS_entry_vector(%rsp) jne .Lcr4_pv32_done xor UREGS_error_code(%rsp),%eax test $~(PFEC_write_access|PFEC_insn_fetch),%eax @@ -925,7 +925,7 @@ FATAL_exception_with_ints_disabled: ENTRY(entry_DF) ENDBR64 - movl $TRAP_double_fault,4(%rsp) + movl $X86_EXC_DF, 4(%rsp) /* Set AC to reduce chance of further SMAP faults */ ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP SAVE_ALL @@ -1047,7 +1047,7 @@ handle_ist_exception: .L_ist_dispatch_done: mov %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) - cmpb $TRAP_nmi,UREGS_entry_vector(%rsp) + cmpb $X86_EXC_NMI, UREGS_entry_vector(%rsp) jne ret_from_intr /* We want to get straight to the IRET on the NMI exit path. */ @@ -1118,7 +1118,7 @@ autogen_stubs: /* Automatically generated stubs. */ /* Reserved exceptions, heading towards do_unhandled_trap(). */ .elseif vec == X86_EXC_CSO || vec == X86_EXC_SPV || \ - vec == X86_EXC_VE || (vec > X86_EXC_CP && vec < TRAP_nr) + vec == X86_EXC_VE || (vec > X86_EXC_CP && vec < X86_EXC_NUM) 1: ENDBR64 diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c index 8c7d18521807..9a502e04d68f 100644 --- a/xen/arch/x86/x86_emulate.c +++ b/xen/arch/x86/x86_emulate.c @@ -78,7 +78,7 @@ int cf_check x86emul_read_xcr( break; /* fall through */ default: - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return X86EMUL_EXCEPTION; } @@ -99,7 +99,7 @@ int cf_check x86emul_write_xcr( default: gp_fault: if ( ctxt ) - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return X86EMUL_EXCEPTION; } @@ -146,7 +146,7 @@ int cf_check x86emul_read_dr( ud_fault: default: if ( ctxt ) - x86_emul_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC, ctxt); + x86_emul_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC, ctxt); return X86EMUL_EXCEPTION; } @@ -168,11 +168,11 @@ int cf_check x86emul_write_dr( return X86EMUL_OKAY; case -ENODEV: - x86_emul_hw_exception(TRAP_invalid_op, X86_EVENT_NO_EC, ctxt); + x86_emul_hw_exception(X86_EXC_UD, X86_EVENT_NO_EC, ctxt); return X86EMUL_EXCEPTION; default: - x86_emul_hw_exception(TRAP_gp_fault, 0, ctxt); + x86_emul_hw_exception(X86_EXC_GP, 0, ctxt); return X86EMUL_EXCEPTION; } } diff --git a/xen/arch/x86/x86_emulate/x86_emulate.h b/xen/arch/x86/x86_emulate/x86_emulate.h index bb7af967ffee..9644a9847950 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.h +++ b/xen/arch/x86/x86_emulate/x86_emulate.h @@ -90,7 +90,7 @@ struct x86_event { uint8_t type; /* X86_EVENTTYPE_* */ uint8_t insn_len; /* Instruction length */ int32_t error_code; /* X86_EVENT_NO_EC if n/a */ - unsigned long cr2; /* Only for TRAP_page_fault h/w exception */ + unsigned long cr2; /* Only for X86_EXC_PF h/w exception */ }; /* @@ -835,7 +835,7 @@ static inline void x86_emul_pagefault( { ASSERT(!ctxt->event_pending); - ctxt->event.vector = 14; /* TRAP_page_fault */ + ctxt->event.vector = X86_EXC_PF; ctxt->event.type = X86_EVENTTYPE_HW_EXCEPTION; ctxt->event.error_code = error_code; ctxt->event.cr2 = cr2; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:00:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:00:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498065.768884 (Exim 4.92) (envelope-from ) id 1pU4qY-0006yX-Bt; Mon, 20 Feb 2023 12:00:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498065.768884; Mon, 20 Feb 2023 12:00:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qY-0006yA-77; Mon, 20 Feb 2023 12:00:42 +0000 Received: by outflank-mailman (input) for mailman id 498065; Mon, 20 Feb 2023 12:00:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4qX-0006Ge-Hq for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:00:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d6bc0d5-b116-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 13:00:40 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d6bc0d5-b116-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676894440; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1KephbvI42w6sMGYmeXsDxkv8u+mNIwoxSbywXjjdiA=; b=eq97NWmOoK411XLkeGqBS1n8drJaukjcGHb8EpE1LyyZuG+6r1ZVLHBl IW4kr4RSaIks94JBQGSJGEH5o34Qprhz0tRv3jHTCz3F+G/z7ba37oAlb Xqje9cVXYc+hq0QpJ+hjZIoGygERSm4zg87pUME1Ryepy1qpT7SJG4ETO s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97740141 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:NJtP2Ks6zMHbJa3uk/Y09WNwxOfnVEdeMUV32f8akzHdYApBsoF/q tZmKW2BPauKZmL0eN4lOYni9R8Hu8XUmt4xHQU6/iwwQX4Q+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEzyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwEzBKdivElviNzLeAYcdD3O4nJ5XZFdZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 z2ZozygXkhy2Nq32WCv3163nrf1nn2mUds1H5SXzaFlnwjGroAUIEJPDgbqyRWjsWahX/pPJ kpS/TAhxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkouQyNFadcmnNQrXjFs3 ViM9+4FHhQ27ufTEyjEsO7J83XrY3N9wXI+iTEsdgtC++KksZsIghf0ZfhMSoSxhYHHMGSlq 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgPZ1 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGshTKuKGpxeEdMMX KM0kVoIjKK/xFPwMcdKj3uZUqzGN5TIG9X/TezzZdFTeJV3fwLv1HgwOhDAhDmzyxVzyfpX1 XKnnSGEVytyNEia5GDuG7d1PUEDm0jSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPrsnekhy P4Gb5Hi40wGAIXDjtz/rdZ7waYicSJqWvgbaqV/Koa+H+aRMDt/Uq+Mkex9KtUNcmY8vr6gw 0xRk3RwkDLX7UAr4y3QOhiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:swJ7baC/749xoQTlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="97740141" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/3] x86/traps: Move do_general_protection() earlier Date: Mon, 20 Feb 2023 11:59:54 +0000 Message-ID: <20230220115956.1522728-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220115956.1522728-1-andrew.cooper3@citrix.com> References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... in order to clean up the declarations without needing to forward declare it for handle_gdt_ldt_mapping_fault() No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/traps.c | 157 +++++++++++++++++++++---------------------- 1 file changed, 78 insertions(+), 79 deletions(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8fa..7fb0c54f884e 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1301,6 +1301,84 @@ void do_int3(struct cpu_user_regs *regs) pv_inject_hw_exception(TRAP_int3, X86_EVENT_NO_EC); } +void do_general_protection(struct cpu_user_regs *regs) +{ +#ifdef CONFIG_PV + struct vcpu *v = current; +#endif + + if ( regs->error_code & X86_XEC_EXT ) + goto hardware_gp; + + if ( !guest_mode(regs) ) + goto gp_in_kernel; + +#ifdef CONFIG_PV + /* + * Cunning trick to allow arbitrary "INT n" handling. + * + * We set DPL == 0 on all vectors in the IDT. This prevents any INT + * instruction from trapping to the appropriate vector, when that might not + * be expected by Xen or the guest OS. For example, that entry might be for + * a fault handler (unlike traps, faults don't increment EIP), or might + * expect an error code on the stack (which a software trap never + * provides), or might be a hardware interrupt handler that doesn't like + * being called spuriously. + * + * Instead, a GPF occurs with the faulting IDT vector in the error code. + * Bit 1 is set to indicate that an IDT entry caused the fault. Bit 0 is + * clear (which got already checked above) to indicate that it's a software + * fault, not a hardware one. + * + * NOTE: Vectors 3 and 4 are dealt with from their own handler. This is + * okay because they can only be triggered by an explicit DPL-checked + * instruction. The DPL specified by the guest OS for these vectors is NOT + * CHECKED!! + */ + if ( regs->error_code & X86_XEC_IDT ) + { + /* This fault must be due to instruction. */ + uint8_t vector = regs->error_code >> 3; + const struct trap_info *ti = &v->arch.pv.trap_ctxt[vector]; + + if ( permit_softint(TI_GET_DPL(ti), v, regs) ) + { + regs->rip += 2; + pv_inject_sw_interrupt(vector); + return; + } + } + else if ( is_pv_32bit_vcpu(v) && regs->error_code ) + { + pv_emulate_gate_op(regs); + return; + } + + /* Emulate some simple privileged and I/O instructions. */ + if ( (regs->error_code == 0) && + pv_emulate_privileged_op(regs) ) + { + trace_trap_one_addr(TRC_PV_EMULATE_PRIVOP, regs->rip); + return; + } + + /* Pass on GPF as is. */ + pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); + return; +#endif + + gp_in_kernel: + if ( likely(extable_fixup(regs, true)) ) + return; + + hardware_gp: + if ( debugger_trap_fatal(TRAP_gp_fault, regs) ) + return; + + show_execution_state(regs); + panic("GENERAL PROTECTION FAULT\n[error_code=%04x]\n", regs->error_code); +} + #ifdef CONFIG_PV static int handle_ldt_mapping_fault(unsigned int offset, struct cpu_user_regs *regs) @@ -1666,85 +1744,6 @@ void __init do_early_page_fault(struct cpu_user_regs *regs) } } -void do_general_protection(struct cpu_user_regs *regs) -{ -#ifdef CONFIG_PV - struct vcpu *v = current; -#endif - - if ( regs->error_code & X86_XEC_EXT ) - goto hardware_gp; - - if ( !guest_mode(regs) ) - goto gp_in_kernel; - -#ifdef CONFIG_PV - /* - * Cunning trick to allow arbitrary "INT n" handling. - * - * We set DPL == 0 on all vectors in the IDT. This prevents any INT - * instruction from trapping to the appropriate vector, when that might not - * be expected by Xen or the guest OS. For example, that entry might be for - * a fault handler (unlike traps, faults don't increment EIP), or might - * expect an error code on the stack (which a software trap never - * provides), or might be a hardware interrupt handler that doesn't like - * being called spuriously. - * - * Instead, a GPF occurs with the faulting IDT vector in the error code. - * Bit 1 is set to indicate that an IDT entry caused the fault. Bit 0 is - * clear (which got already checked above) to indicate that it's a software - * fault, not a hardware one. - * - * NOTE: Vectors 3 and 4 are dealt with from their own handler. This is - * okay because they can only be triggered by an explicit DPL-checked - * instruction. The DPL specified by the guest OS for these vectors is NOT - * CHECKED!! - */ - if ( regs->error_code & X86_XEC_IDT ) - { - /* This fault must be due to instruction. */ - uint8_t vector = regs->error_code >> 3; - const struct trap_info *ti = &v->arch.pv.trap_ctxt[vector]; - - if ( permit_softint(TI_GET_DPL(ti), v, regs) ) - { - regs->rip += 2; - pv_inject_sw_interrupt(vector); - return; - } - } - else if ( is_pv_32bit_vcpu(v) && regs->error_code ) - { - pv_emulate_gate_op(regs); - return; - } - - /* Emulate some simple privileged and I/O instructions. */ - if ( (regs->error_code == 0) && - pv_emulate_privileged_op(regs) ) - { - trace_trap_one_addr(TRC_PV_EMULATE_PRIVOP, regs->rip); - return; - } - - /* Pass on GPF as is. */ - pv_inject_hw_exception(TRAP_gp_fault, regs->error_code); - return; -#endif - - gp_in_kernel: - - if ( likely(extable_fixup(regs, true)) ) - return; - - hardware_gp: - if ( debugger_trap_fatal(TRAP_gp_fault, regs) ) - return; - - show_execution_state(regs); - panic("GENERAL PROTECTION FAULT\n[error_code=%04x]\n", regs->error_code); -} - static bool pci_serr_cont; static bool pci_serr_nmicont(void) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:07:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:07:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498087.768899 (Exim 4.92) (envelope-from ) id 1pU4wv-0000GY-32; Mon, 20 Feb 2023 12:07:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498087.768899; Mon, 20 Feb 2023 12:07:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4wv-0000GR-0K; Mon, 20 Feb 2023 12:07:17 +0000 Received: by outflank-mailman (input) for mailman id 498087; Mon, 20 Feb 2023 12:07:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4wt-0000GL-C4 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:07:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU4ws-0006zh-EX; Mon, 20 Feb 2023 12:07:14 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.98.51]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pU4ws-0002te-6t; Mon, 20 Feb 2023 12:07:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=zcrL1e44/8H+/+yQs6pkKueOKtpkPX/DtFV1euHA7YY=; b=eU+/7jrpfRH0atBAKPMaJxDg0G mr9EZ8fK3+KD1s7/OY1iniptXvlG5+OMvM+v/+WMm4Nk2nhFcpo7ARzXkPfweGihjIT/ZwWAuUpB6 ga99A4JfyKr5gDYLthKhANc1IOaM8jeAkN6YFafnE+lG7kAa0tgcXoO19RCEcFkuKttU=; Message-ID: Date: Mon, 20 Feb 2023 12:07:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 20/02/2023 11:04, Juergen Gross wrote: > On 20.02.23 10:46, Julien Grall wrote: >> Hi Juergen, >> >> On 20/01/2023 10:00, Juergen Gross wrote: >>> The accounting for the number of nodes of a domain in an active >>> transaction is not working correctly, as it allows to create arbitrary >>> number of nodes. The transaction will finally fail due to exceeding >>> the number of nodes quota, but before closing the transaction an >>> unprivileged guest could cause Xenstore to use a lot of memory. >> >> I know I said I would delay my decision on this patch. However, I was >> still expecting the commit message to be updated based on our previous >> discussion. > > As said before, I was waiting on the settlement of our discussion before > doing the update. This is not a very good practice to resend a patch without recording the disagreement because new reviewers may not be aware of the disagreement and this could end up to be committed by mistake... > >> Also thinking more about it, "The transaction will finally fail due to >> exceeding the number of nodes quota" may not be true for a couple of >> reasons: >>    1) The transaction may removed a node afterwards. > > Yes, and? Just because it is a transaction, this is still a violation of > the quota. Even outside a transaction you could use the same reasoning, > but you don't (which is correct, of course). I can understand your point. However, to me, the goal of the transaction is to commit everything in one go at the end. So the violations in the middle should not matter. Furthermore, I would expect a transaction to work on a snapshot of the system. So it feels really strange to me that we are constantly checking the quota with the updated values rather than the initial one. > > In case you never finish the transaction, you are owner of more than > allowed nodes. How so? The nodes would not be committed so you don't really own them. We also have quotas to limit the number of nodes accessed in a transaction. > >>    2) A node may have been removed outside of the transaction. > > If the removed node hasn't been touched by the transaction, it will be > accounted for correctly. It depends on when the node was removed. If it is removed *after* the quota was hit then your transaction will fail. > If it has been touched, the transaction will > fail anyway. So the transaction will fail to commit because there is a conflict. So the client is expected to retry it. We should not expected the client to retry for error like quota. So the overall behavior is changed. > >> In both situation, the transaction will still be committed. This will >> now be prevented by this patch. > > As said above, only in the first case. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:13:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:13:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498093.768910 (Exim 4.92) (envelope-from ) id 1pU52l-0001uc-OV; Mon, 20 Feb 2023 12:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498093.768910; Mon, 20 Feb 2023 12:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU52l-0001uV-Kk; Mon, 20 Feb 2023 12:13:19 +0000 Received: by outflank-mailman (input) for mailman id 498093; Mon, 20 Feb 2023 12:13:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU52k-0001uP-Dr for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 12:13:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU52j-0007FV-9x; Mon, 20 Feb 2023 12:13:17 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.98.51]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pU52j-0003GA-3e; Mon, 20 Feb 2023 12:13:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7lEgd9C51hwuThcIkVS9y28InKnSd8GF7fpDqYIlPeY=; b=jwWXAXA5n030PP8arOMSUvnjZL 3pizgg1NubKSPHnX1Gae/aVJrYBFW4UIz6Yr5KT8zvfYLXHUPgVA0Z7jhG71lSf72Ex/LE1uaxhjX NIQ0AKTtiU00j+WZGNJc+foA0Wk5daPZqsvoeA7ZkxGY4J8nMaQBPWXTNMFa1QaN0eqU=; Message-ID: Date: Mon, 20 Feb 2023 12:13:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 03/13] tools/xenstore: introduce accounting data array for per-domain values Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-4-jgross@suse.com> <56e5bed5-baaf-9ff0-fe93-122c77ce3c5a@xen.org> <93762544-5866-1a6f-1d64-b5fa4286feb3@suse.com> From: Julien Grall In-Reply-To: <93762544-5866-1a6f-1d64-b5fa4286feb3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/02/2023 11:20, Juergen Gross wrote: > On 17.02.23 20:29, Julien Grall wrote: >> Hi Juergen, >> >> On 20/01/2023 10:00, Juergen Gross wrote: >>> Introduce the scheme of an accounting data array for per-domain >>> accounting data and use it initially for the number of nodes owned by >>> a domain. >>> >>> Make the accounting data type to be unsigned int, as no data is allowed >>> to be negative at any time. >>> >>> Signed-off-by: Juergen Gross >>> --- >>>   tools/xenstore/xenstored_domain.c | 71 ++++++++++++++++++------------- >>>   tools/xenstore/xenstored_domain.h |  5 ++- >>>   2 files changed, 45 insertions(+), 31 deletions(-) >>> >>> diff --git a/tools/xenstore/xenstored_domain.c >>> b/tools/xenstore/xenstored_domain.c >>> index 44e72937fa..f459c5aabb 100644 >>> --- a/tools/xenstore/xenstored_domain.c >>> +++ b/tools/xenstore/xenstored_domain.c >>> @@ -69,8 +69,8 @@ struct domain >>>       /* Has domain been officially introduced? */ >>>       bool introduced; >>> -    /* number of entry from this domain in the store */ >>> -    int nbentry; >>> +    /* Accounting data for this domain. */ >>> +    unsigned int acc[ACC_N]; >>>       /* Amount of memory allocated for this domain. */ >>>       int memory; >>> @@ -246,7 +246,7 @@ static int domain_tree_remove_sub(const void >>> *ctx, struct connection *conn, >>>       if (keep_orphans) { >>>           set_tdb_key(node->name, &key); >>> -        domain->nbentry--; >>> +        domain_nbentry_dec(NULL, domain->domid); >>>           node->perms.p[0].id = priv_domid; >>>           node->acc.memory = 0; >>>           domain_nbentry_inc(NULL, priv_domid); >>> @@ -270,7 +270,7 @@ static int domain_tree_remove_sub(const void >>> *ctx, struct connection *conn, >>>           ret = WALK_TREE_SKIP_CHILDREN; >>>       } >>> -    return domain->nbentry > 0 ? ret : WALK_TREE_SUCCESS_STOP; >>> +    return domain->acc[ACC_NODES] ? ret : WALK_TREE_SUCCESS_STOP; >>>   } >>>   static void domain_tree_remove(struct domain *domain) >>> @@ -278,7 +278,7 @@ static void domain_tree_remove(struct domain >>> *domain) >>>       int ret; >>>       struct walk_funcs walkfuncs = { .enter = domain_tree_remove_sub }; >>> -    if (domain->nbentry > 0) { >>> +    if (domain->acc[ACC_NODES]) { >>>           ret = walk_node_tree(domain, NULL, "/", &walkfuncs, domain); >>>           if (ret == WALK_TREE_ERROR_STOP) >>>               syslog(LOG_ERR, >>> @@ -437,7 +437,7 @@ int domain_get_quota(const void *ctx, struct >>> connection *conn, >>>       resp = talloc_asprintf_append(resp, "%-16s: %8d\n", #t, e); \ >>>       if (!resp) return ENOMEM >>> -    ent(nodes, d->nbentry); >>> +    ent(nodes, d->acc[ACC_NODES]); >>>       ent(watches, d->nbwatch); >>>       ent(transactions, ta); >>>       ent(outstanding, d->nboutstanding); >>> @@ -1047,8 +1047,28 @@ int domain_adjust_node_perms(struct node *node) >>>       return 0; >>>   } >>> -static int domain_nbentry_add(struct connection *conn, unsigned int >>> domid, >>> -                  int add, bool no_dom_alloc) >>> +static int domain_acc_add_chk(struct domain *d, enum accitem what, >>> int add, >>> +                  unsigned int domid) >> >> You are passing the domid but this doesn't seem to be used within the >> function. > > That was added in order to avoid more code churn in a later patch, which is > making use of domid. > >> Also, from just reading at this prototype, it is not clear to me >> whether 'domid' is meant to correspond to the one of 'd'. > > It is corresponding to 'd', so I think I can remove the domid parameter > without > problem (I think I had it this way because d could be NULL in my initial > version, which changed afterwards - I'm not sure about the history, > though). Ok. Please mention it in the commit message if you want to keep it. > >> The name is also a bit confusing because below you have a function >> call domain_acc_add() that will update "d->acc[what]" so I would >> expect this function to also update it after a sanity get. >> >> I would suggest to rename it to domain_acc_get_chk() or similar (see >> below for some context). > > I could do that, but check is done based on the current value plus an "add" > value, hence the current name. Would domain_acc_add_valid() be a better > name? Fine with me. > >> >>> +{ >>> +    assert(what < ARRAY_SIZE(d->acc)); >>> + >>> +    if ((add < 0 && -add > d->acc[what]) || >>> +        (d->acc[what] + add) > INT_MAX) { >> >> NIT: Even if I know that 'add' will unlikely be INT_MAX, it would be >> better to use '(INT_MAX - d->acc[what]) < add)'. So there is no >> overflow possible. > > Okay. > >> >>> +        /* >>> +         * In a transaction when a node is being added/removed AND the >>> +         * same node has been added/removed outside the transaction in >>> +         * parallel, the resulting value will be wrong. This is no >>> +         * problem, as the transaction will fail due to the resulting >>> +         * conflict. >>> +         */ >>> +        return (add < 0) ? 0 : INT_MAX; >>> +    } >>> + >>> +    return d->acc[what] + add; >>> +} >>> + >>> +static int domain_acc_add(struct connection *conn, unsigned int domid, >>> +              enum accitem what, int add, bool no_dom_alloc) >>>   { >>>       struct domain *d; >>>       struct list_head *head; >>> @@ -1071,56 +1091,49 @@ static int domain_nbentry_add(struct >>> connection *conn, unsigned int domid, >>>           } >>>       } >>> -    if (conn && conn->transaction) { >>> +    if (conn && conn->transaction && what < ACC_TR_N) { >> >> Do you have a use case where 'what' is >= ACC_TR_N and you want to >> modify d->acc? > > Yes, please see patch 7. > >> >>>           head = transaction_get_changed_domains(conn->transaction); >>> -        ret = acc_add_changed_dom(conn->transaction, head, ACC_NODES, >>> +        ret = acc_add_changed_dom(conn->transaction, head, what, >>>                         add, domid); >>>           if (errno) { >>>               fail_transaction(conn->transaction); >>>               return -1; >>>           } >>> -        /* >>> -         * In a transaction when a node is being added/removed AND the >>> -         * same node has been added/removed outside the transaction in >>> -         * parallel, the resulting number of nodes will be wrong. This >>> -         * is no problem, as the transaction will fail due to the >>> -         * resulting conflict. >>> -         * In the node remove case the resulting number can be even >>> -         * negative, which should be avoided. >>> -         */ >>> -        return max(d->nbentry + ret, 0); >>> +        return domain_acc_add_chk(d, what, ret, domid); >> >> I was going to ask here why we are updating d->acc[what]. However the >> function is not doing what I was expecting from the name. You are only >> returning the number of entries adjusted. > > Huh? > > In the transaction case acc_add_changed_dom() is updating the value in the > changed_domain data of the transaction, while in the non-transaction > case ... I was referring to the name of the function domain_acc_add_chk() which lead me to think the helper was doing something different. If you rename it, then the confusion is removed. > >> >>>       } >>> -    d->nbentry += add; >>> +    d->acc[what] = domain_acc_add_chk(d, what, add, domid); >>> -    return d->nbentry; >>> +    return d->acc[what]; > > ... the domain data is updated here. > >>>   } >>>   int domain_nbentry_inc(struct connection *conn, unsigned int domid) >>>   { >>> -    return (domain_nbentry_add(conn, domid, 1, false) < 0) ? errno : 0; >>> +    return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) >>> +           ? errno : 0; >>>   } >>>   int domain_nbentry_dec(struct connection *conn, unsigned int domid) >>>   { >>> -    return (domain_nbentry_add(conn, domid, -1, true) < 0) ? errno : 0; >>> +    return (domain_acc_add(conn, domid, ACC_NODES, -1, true) < 0) >>> +           ? errno : 0; >>>   } >>>   int domain_nbentry_fix(unsigned int domid, int num, bool update) >>>   { >>>       int ret; >>> -    ret = domain_nbentry_add(NULL, domid, update ? num : 0, update); >>> +    ret = domain_acc_add(NULL, domid, ACC_NODES, update ? num : 0, >>> update); >>>       if (ret < 0 || update) >>>           return ret; >>>       return domid_is_unprivileged(domid) ? ret + num : 0; >>>   } >>> -int domain_nbentry(struct connection *conn) >>> +unsigned int domain_nbentry(struct connection *conn) >>>   { >>>       return domain_is_unprivileged(conn) >>> -           ? domain_nbentry_add(conn, conn->id, 0, true) : 0; >>> +           ? domain_acc_add(conn, conn->id, ACC_NODES, 0, true) : 0; >>>   } >>>   static bool domain_chk_quota(struct domain *domain, int mem) >>> @@ -1597,7 +1610,7 @@ static int domain_check_acc_init_sub(const void >>> *k, void *v, void *arg) >>>        * If everything is correct incrementing the value for each >>> node will >>>        * result in dom->nodes being 0 at the end. >>>        */ >>> -    dom->nodes = -d->nbentry; >>> +    dom->nodes = -d->acc[ACC_NODES]; >>>       if (!hashtable_insert(domains, &dom->domid, dom)) { >>>           talloc_free(dom); >>> @@ -1652,7 +1665,7 @@ static int domain_check_acc_cb(const void *k, >>> void *v, void *arg) >>>       if (!d) >>>           return 0; >>> -    d->nbentry += dom->nodes; >>> +    d->acc[ACC_NODES] += dom->nodes; >>>       return 0; >>>   } >>> diff --git a/tools/xenstore/xenstored_domain.h >>> b/tools/xenstore/xenstored_domain.h >>> index 6a2b76a85b..8259c114b0 100644 >>> --- a/tools/xenstore/xenstored_domain.h >>> +++ b/tools/xenstore/xenstored_domain.h >>> @@ -21,7 +21,8 @@ >>>   enum accitem { >>>       ACC_NODES, >>> -    ACC_TR_N    /* Number of elements per transaction and domain. */ >>> +    ACC_TR_N,        /* Number of elements per transaction and >>> domain. */ >> >> The churn here could have been avoided if you add a "," even for the >> edn element and properly indented the comment in the original patch. > > Okay. > >> >> Also, was the comment indented to be updated to remove "and domain"? > > No, the new indentation was meant to keep the comment start aligned with > the one of the following line. Sorry, I meant "intended" rather than "indented". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 12:44:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 12:44:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498112.768921 (Exim 4.92) (envelope-from ) id 1pU5WL-0005w7-5B; Mon, 20 Feb 2023 12:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498112.768921; Mon, 20 Feb 2023 12:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5WL-0005w0-0r; Mon, 20 Feb 2023 12:43:53 +0000 Received: by outflank-mailman (input) for mailman id 498112; Mon, 20 Feb 2023 12:43:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5WJ-0005vq-Mf; Mon, 20 Feb 2023 12:43:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5WJ-0007tX-Jb; Mon, 20 Feb 2023 12:43:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5WJ-0006x0-6L; Mon, 20 Feb 2023 12:43:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pU5WJ-0007Mt-5r; Mon, 20 Feb 2023 12:43:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RUt0GHshT8YQ4I7v8Pu0zYIYWb2mqRo00cvi/jB8EJQ=; b=539hXqUMXBLGgMUj4hX0rGZTVv GuSy7l9zX6ZYe2liG+vBpNMMX8t5rd1W4WCU5FC3GLiKFl+5ufAgoo2ef5ZbsEv1Fm2mHw4sVN4n3 3dtRfsiXBFZrwdP7J+KQ6FxtFE0ZOFA1SfLNcUo6N5PzInLg10Q4LdZB1n99fdXRSSOQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177883: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac X-Osstest-Versions-That: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac From: osstest service owner Date: Mon, 20 Feb 2023 12:43:51 +0000 flight 177883 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177883/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 177852 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 177852 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 177852 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177852 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177852 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177852 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177852 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177852 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177852 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177852 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177852 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177852 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac baseline version: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac Last test of basis 177883 2023-02-20 04:18:32 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Feb 20 13:13:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 13:13:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498122.768932 (Exim 4.92) (envelope-from ) id 1pU5z9-0001a2-J3; Mon, 20 Feb 2023 13:13:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498122.768932; Mon, 20 Feb 2023 13:13:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5z9-0001Zv-Fm; Mon, 20 Feb 2023 13:13:39 +0000 Received: by outflank-mailman (input) for mailman id 498122; Mon, 20 Feb 2023 13:13:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU5z9-0001Zm-0H for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 13:13:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 600fc05b-b120-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 14:13:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 600fc05b-b120-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676898815; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=M3wWiTSJa8onm3VWwUcqdATfRKQonuEe/05I0DHI0Ao=; b=UrNA/9K0Jn0Of3xXtLeIS6nfuDljMjZS8RHk3eBUVPa1T1YhBLUTk7+Q UL9ZiHhXMNhLEvtzot9zfi4KgSG0tYWYezZ6nG6/h+4vmDpATuNJHVzw3 2ojshBvKMYIVYXxzEnQ/ZIPo/jQtLvv5a4vWJSuSp5taIh5Pz1jzo57Yu c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96581669 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:O8B7FqmknJLiwnnhr/Sg3RLo5gx1JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIfWTyAaPqJNzSnf4x/Pt+39xsG6MCDz9UxSARspX1hQyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5geGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eAiLm4nKTWyu9ON4Ii4cttU3cEHAuC+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHWdTFCpU3Tjq0w+2XJlyR60aT3McqTcduPLSlQthfG+ zKfoTqoav0cHPK61AWm1XuVvLTSwgbJSYUrErG98vE/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JyOeAn7ACGyoLP/h2UQGMDS1Zpc8c6vcU7QTgr0 F6hnN7zAzFr9rqPRhq16bO8vT60fy8PIgcqZzIATAYDy8nupsc0lB2nZuhkFKm5n9jkAwbay jqBrDU9r7gLhMtN3KK+lXjNjiiwvJHPQkgw7x/OQ2O+xgpjYciuYInA1LTAxa8edsDDFADH5 SVa3ZHEt4jiEK1higSReuNTNvaM1sq0Cx3mgmZdJ8Ik0xqErivLkZ9r3BlyI0JgM8AhcDDvY VPOtQ452KK/LEdGfocsPdvvVp1CIbzIUI28C6uKNoYmjo1ZLlfvwc14WaKHM4kBemAImLp3B 5qUeN3E4Z0yWfU+l2reqwvwPNYWKsECKYH7H8+TI/ePi+D2iJuppVAtaQLmUwzBxPnYyDg5C v4GXydw9z1RUfflfg7c+pMJIFYBIBATXM6p9ZwML7DYf1U+QwnN7sM9Jpt7JuRYc1l9zL+Ur hlRpGcFoLYAuZE3AVrTMS0yAF8edZ1+sWg6LUQR0aWAghAejXKUxP5HLfMfJOB3nNGPONYoF 5Hpje3cWKUQItkGkhxBBaTAQHtKLkry1V/eYHb0OVDSvfdIHmT0xzMtRSO3nAFmM8Z9nZFWT 2GIvu8Dfac+eg== IronPort-HdrOrdr: A9a23:AjgU5quTNA8YcYQIy3knq9cl7skDTdV00zEX/kB9WHVpm62j5q KTdZEgviMc5wx9ZJhNo7y90dC7MBXhHP1OkOos1NWZPTUO0VHAROtfBO3ZrAEIcBefygcy78 ldmudFebnN5BxB/L/HCDTRKadE/DGkmJrY4tvj8w== X-IronPort-AV: E=Sophos;i="5.97,312,1669093200"; d="scan'208";a="96581669" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH RFC] xen: Annotate printk() as cold Date: Mon, 20 Feb 2023 13:13:25 +0000 Message-ID: <20230220131325.1524786-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There is no such thing as a fastpath with a printk() on it, making printk() an excellent heuristic for slowpaths. Net delta is: add/remove: 595/2 grow/shrink: 56/762 up/down: 70879/-87331 (-16452) Total: Before=4085425, After=4068973, chg -0.40% because cold functions are optimised differently. For example, one function with a particularly large swing is: vmcs_dump_vcpu.cold - 2172 +2172 vmcs_dump_vcpu 7030 408 -6622 with a net delta of 7030 down to 4450. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bertrand Marquis There are other functions which will be good heuristics to annotate, but we probaby want to collect .cold together in one location rather than having them spread out across all translation units. --- xen/include/xen/lib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 05ee1e18af6b..11ef287c1ed9 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -115,7 +115,7 @@ debugtrace_printk(const char *fmt, ...) {} /* Allows us to use '%p' as general-purpose machine-word format char. */ #define _p(_x) ((void *)(unsigned long)(_x)) extern void printk(const char *format, ...) - __attribute__ ((format (printf, 1, 2))); + __attribute__ ((format (printf, 1, 2), cold)); #define printk_once(fmt, args...) \ ({ \ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 13:49:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 13:49:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498133.768942 (Exim 4.92) (envelope-from ) id 1pU6Y9-00061o-Bz; Mon, 20 Feb 2023 13:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498133.768942; Mon, 20 Feb 2023 13:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6Y9-00061h-9B; Mon, 20 Feb 2023 13:49:49 +0000 Received: by outflank-mailman (input) for mailman id 498133; Mon, 20 Feb 2023 13:49:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6Y7-00061Z-Tq for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 13:49:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6eab3720-b125-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 14:49:45 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7D6052032B; Mon, 20 Feb 2023 13:49:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5322A139DB; Mon, 20 Feb 2023 13:49:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b7zoEnh682PUHQAAMHmgww (envelope-from ); Mon, 20 Feb 2023 13:49:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eab3720-b125-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676900984; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3IuN9ge3ye6XDouALoQxVmCLtROBDYgWqlRftjG4Q+U=; b=r68moE7l/3l426cC8GMDZ+7mFgSxziLRYDT3RbegvCsCYeyvx9CaJGS5z3ISn0vSULXHVf uf+7btatOyeSEB8MGqH7sbYttPVKKSrpva2KwXby6eINDPpY4E96vRKi1TFeTH0wnwMtyU MSUrDHCaMaZx57yIdGRI+wCpBRjMIfA= Message-ID: Date: Mon, 20 Feb 2023 14:49:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------qW0mnbweOxsilN0CNqwAc3R0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------qW0mnbweOxsilN0CNqwAc3R0 Content-Type: multipart/mixed; boundary="------------Fpnc3FBfLv9gEQ00OJYwEAcN"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> In-Reply-To: --------------Fpnc3FBfLv9gEQ00OJYwEAcN Content-Type: multipart/mixed; boundary="------------6RU3kLjQq0sIjNdaU38520vH" --------------6RU3kLjQq0sIjNdaU38520vH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMTM6MDcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIwLzAyLzIwMjMgMTE6MDQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyMC4wMi4yMyAxMDo0NiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBPbiAyMC8wMS8yMDIzIDEwOjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+PiBUaGUgYWNjb3VudGluZyBmb3IgdGhlIG51bWJlciBvZiBub2RlcyBvZiBhIGRvbWFp biBpbiBhbiBhY3RpdmUNCj4+Pj4gdHJhbnNhY3Rpb24gaXMgbm90IHdvcmtpbmcgY29ycmVj dGx5LCBhcyBpdCBhbGxvd3MgdG8gY3JlYXRlIGFyYml0cmFyeQ0KPj4+PiBudW1iZXIgb2Yg bm9kZXMuIFRoZSB0cmFuc2FjdGlvbiB3aWxsIGZpbmFsbHkgZmFpbCBkdWUgdG8gZXhjZWVk aW5nDQo+Pj4+IHRoZSBudW1iZXIgb2Ygbm9kZXMgcXVvdGEsIGJ1dCBiZWZvcmUgY2xvc2lu ZyB0aGUgdHJhbnNhY3Rpb24gYW4NCj4+Pj4gdW5wcml2aWxlZ2VkIGd1ZXN0IGNvdWxkIGNh dXNlIFhlbnN0b3JlIHRvIHVzZSBhIGxvdCBvZiBtZW1vcnkuDQo+Pj4NCj4+PiBJIGtub3cg SSBzYWlkIEkgd291bGQgZGVsYXkgbXkgZGVjaXNpb24gb24gdGhpcyBwYXRjaC4gSG93ZXZl ciwgSSB3YXMgc3RpbGwgDQo+Pj4gZXhwZWN0aW5nIHRoZSBjb21taXQgbWVzc2FnZSB0byBi ZSB1cGRhdGVkIGJhc2VkIG9uIG91ciBwcmV2aW91cyBkaXNjdXNzaW9uLg0KPj4NCj4+IEFz IHNhaWQgYmVmb3JlLCBJIHdhcyB3YWl0aW5nIG9uIHRoZSBzZXR0bGVtZW50IG9mIG91ciBk aXNjdXNzaW9uIGJlZm9yZQ0KPj4gZG9pbmcgdGhlIHVwZGF0ZS4NCj4gDQo+IFRoaXMgaXMg bm90IGEgdmVyeSBnb29kIHByYWN0aWNlIHRvIHJlc2VuZCBhIHBhdGNoIHdpdGhvdXQgcmVj b3JkaW5nIHRoZSANCj4gZGlzYWdyZWVtZW50IGJlY2F1c2UgbmV3IHJldmlld2VycyBtYXkg bm90IGJlIGF3YXJlIG9mIHRoZSBkaXNhZ3JlZW1lbnQgYW5kIHRoaXMgDQo+IGNvdWxkIGVu ZCB1cCB0byBiZSBjb21taXR0ZWQgYnkgbWlzdGFrZS4uLg0KDQpZb3Ugc2FpZCB5b3Ugd2Fu dGVkIHRvIGxvb2sgaW50byB0aGlzIHBhdGNoIGluIGRldGFpbCBhZnRlciB0aGUgcHJldmlv dXMNCnNlcmllcywgc28gSSBtb3ZlIGl0IGludG8gdGhpcyBzZXJpZXMuIFRoZSB3b3JkaW5n IHVwZGF0ZSB3b3VsZCBzdHJvbmdseQ0KZGVwZW5kIG9uIHRoZSBvdXRjb21lIG9mIHRoZSBk aXNjdXNzaW9uIElNTywgc28gSSBkaWRuJ3QgZG8gaXQgeWV0Lg0KDQpOb3QgYWRkaW5nIHRo ZSBwYXRjaCBpbiB0aGlzIHNlcmllcyB3b3VsZCByZXF1aXJlIHNvbWUgYWRkaXRpb25hbCBy ZWJhc2UNCmVmZm9ydCwgc28gSSBrZXB0IHRoZSBwYXRjaCBhcyBpcy4NCg0KPj4+IEFsc28g dGhpbmtpbmcgbW9yZSBhYm91dCBpdCwgIlRoZSB0cmFuc2FjdGlvbiB3aWxsIGZpbmFsbHkg ZmFpbCBkdWUgdG8gDQo+Pj4gZXhjZWVkaW5nIHRoZSBudW1iZXIgb2Ygbm9kZXMgcXVvdGEi IG1heSBub3QgYmUgdHJ1ZSBmb3IgYSBjb3VwbGUgb2YgcmVhc29uczoNCj4+PiDCoMKgIDEp IFRoZSB0cmFuc2FjdGlvbiBtYXkgcmVtb3ZlZCBhIG5vZGUgYWZ0ZXJ3YXJkcy4NCj4+DQo+ PiBZZXMsIGFuZD8gSnVzdCBiZWNhdXNlIGl0IGlzIGEgdHJhbnNhY3Rpb24sIHRoaXMgaXMg c3RpbGwgYSB2aW9sYXRpb24gb2YNCj4+IHRoZSBxdW90YS4gRXZlbiBvdXRzaWRlIGEgdHJh bnNhY3Rpb24geW91IGNvdWxkIHVzZSB0aGUgc2FtZSByZWFzb25pbmcsDQo+PiBidXQgeW91 IGRvbid0ICh3aGljaCBpcyBjb3JyZWN0LCBvZiBjb3Vyc2UpLg0KPiANCj4gSSBjYW4gdW5k ZXJzdGFuZCB5b3VyIHBvaW50LiBIb3dldmVyLCB0byBtZSwgdGhlIGdvYWwgb2YgdGhlIHRy YW5zYWN0aW9uIGlzIHRvIA0KPiBjb21taXQgZXZlcnl0aGluZyBpbiBvbmUgZ28gYXQgdGhl IGVuZC4gU28gdGhlIHZpb2xhdGlvbnMgaW4gdGhlIG1pZGRsZSBzaG91bGQgDQo+IG5vdCBt YXR0ZXIuDQoNCk9mIGNvdXJzZSB0aGV5IHNob3VsZC4NCg0KV2Ugd291bGRuJ3QgYWxsb3cg dG8gd3JpdGUgb3Zlci1zaXplZCBub2RlcywgZXZlbiBpZiB0aGV5IGNvdWxkIGJlIHJld3Jp dHRlbiBpbg0KdGhlIHNhbWUgdHJhbnNhY3Rpb24gd2l0aCBhIHNtYWxsZXIgc2l6ZS4NCg0K V2Ugd291bGRuJ3QgYWxsb3cgdG8gY3JlYXRlIG5vZGVzIHdoaWNoIHdvdWxkIHZpb2xhdGUg b3ZlcmFsbCBtZW1vcnkNCmNvbnN1bXB0aW9uLg0KDQpXZSB3b3VsZG4ndCBhbGxvdyBub2Rl cyB3aXRoIG1vcmUgcGVybWlzc2lvbiBlbnRyaWVzIHRoYW4gYWxsb3dlZCwgZXZlbiBpZiB0 aGV5DQpjb3VsZCBiZSByZWR1Y2VkIGluIHRoZSBzYW1lIHRyYW5zYWN0aW9uIGFnYWluLg0K DQpJIGRvbid0IHNlZSB3aHkgdGhlIG51bWJlciBvZiBub2RlcyBzaG91bGRuJ3QgYmUgdGFr ZW4gaW50byBhY2NvdW50Lg0KDQo+IEZ1cnRoZXJtb3JlLCBJIHdvdWxkIGV4cGVjdCBhIHRy YW5zYWN0aW9uIHRvIHdvcmsgb24gYSBzbmFwc2hvdCBvZiB0aGUgc3lzdGVtLiANCj4gU28g aXQgZmVlbHMgcmVhbGx5IHN0cmFuZ2UgdG8gbWUgdGhhdCB3ZSBhcmUgY29uc3RhbnRseSBj aGVja2luZyB0aGUgcXVvdGEgd2l0aCANCj4gdGhlIHVwZGF0ZWQgdmFsdWVzIHJhdGhlciB0 aGFuIHRoZSBpbml0aWFsIG9uZS4NCg0KWW91IGFyZSBhd2FyZSB0aGF0IHRoZSBjb2RlIHdp dGhvdXQgdGhpcyBwYXRjaCBpcyBqdXN0IG5lZ2xlY3RpbmcgdGhlIG5vZGVzDQpjcmVhdGVk IGluIHRoZSB0cmFuc2FjdGlvbj8gSXQganVzdCBpcyB1c2luZyB0aGUgY3VycmVudCBudW1i ZXIgb2Ygbm9kZXMNCm91dHNpZGUgYW55IHRyYW5zYWN0aW9uIGZvciBxdW90YSBjaGVjay4g U28gSSBjb3VsZCBlYXNpbHkgY3JlYXRlIGEgc2NlbmFyaW8NCndoZXJlIG15IG5ldyBjb2Rl IHdpbGwgc3VjY2VlZCwgYnV0IHRoZSBjdXJyZW50IG9uZSBpcyBmYWlsaW5nOg0KDQpBc3N1 bWUgbm9kZSBxdW90YSBpcyAxMDAwLCBhbmQgYXQgc3RhcnQgb2YgdGhlIHRyYW5zYWN0aW9u IHRoZSBndWVzdCBpcyBvd25pbmcNCjk5OSBub2Rlcy4gSW4gdGhlIHRyYW5zYWN0aW9uIHRo ZSBndWVzdCBpcyBkZWxldGluZyAxMCBub2RlcywgdGhlbiBkb20wIGlzDQpjcmVhdGluZyA1 IGFkZGl0aW9uYWwgbm9kZXMgb3duZWQgYnkgdGhlIGd1ZXN0LiBUaGUgY2VudHJhbCBub2Rl IGNvdW50ZXIgaXMgbm93DQoxMDA0IChvdmVyIHF1b3RhKSwgd2hpbGUgdGhlIGluLXRyYW5z YWN0aW9uIGNvdW50IGlzIDk5NC4gSW4gdGhlIHRyYW5zYWN0aW9uIHRoZQ0KZ3Vlc3QgY2Fu IG5vdyBoYXBwaWx5IGNyZWF0ZSBhIG5ldyBub2RlICgjOTk1KSB3aXRoIG15IHBhdGNoLCBi dXQgd2lsbCBmYWlsIHRvDQpkbyBzbyB3aXRob3V0IChpdCBzZWVzIHRoZSAxMDA0IGR1ZSB0 byB0aGUgdHJhbnNhY3Rpb24gY291bnQgYmVpbmcgaWdub3JlZCkuDQoNCj4+IEluIGNhc2Ug eW91IG5ldmVyIGZpbmlzaCB0aGUgdHJhbnNhY3Rpb24sIHlvdSBhcmUgb3duZXIgb2YgbW9y ZSB0aGFuDQo+PiBhbGxvd2VkIG5vZGVzLg0KPiBIb3cgc28/IFRoZSBub2RlcyB3b3VsZCBu b3QgYmUgY29tbWl0dGVkIHNvIHlvdSBkb24ndCByZWFsbHkgb3duIHRoZW0uDQoNCkJ1dCB5 b3UgY2FuIHVzZSB0aGVtIGluc2lkZSB0aGUgdHJhbnNhY3Rpb24uDQoNCj4gV2UgYWxzbyBo YXZlIHF1b3RhcyB0byBsaW1pdCB0aGUgbnVtYmVyIG9mIG5vZGVzIGFjY2Vzc2VkIGluIGEg dHJhbnNhY3Rpb24uDQoNClllcywgYnV0IHlvdSBjYW4gdXNlIHRoZSBleGNlc3Mgbm9kZXMg aW4gdGhlIHRyYW5zYWN0aW9uIHVudGlsIHRoYXQgcXVvdGENCmlzIHJlYWNoZWQuDQoNCj4+ PiDCoMKgIDIpIEEgbm9kZSBtYXkgaGF2ZSBiZWVuIHJlbW92ZWQgb3V0c2lkZSBvZiB0aGUg dHJhbnNhY3Rpb24uDQo+Pg0KPj4gSWYgdGhlIHJlbW92ZWQgbm9kZSBoYXNuJ3QgYmVlbiB0 b3VjaGVkIGJ5IHRoZSB0cmFuc2FjdGlvbiwgaXQgd2lsbCBiZQ0KPj4gYWNjb3VudGVkIGZv ciBjb3JyZWN0bHkuDQo+IA0KPiBJdCBkZXBlbmRzIG9uIHdoZW4gdGhlIG5vZGUgd2FzIHJl bW92ZWQuIElmIGl0IGlzIHJlbW92ZWQgKmFmdGVyKiB0aGUgcXVvdGEgd2FzIA0KPiBoaXQg dGhlbiB5b3VyIHRyYW5zYWN0aW9uIHdpbGwgZmFpbC4NCg0KWWVzLiBUaGF0IGlzIHdoeSB0 aGUgcXVvdGEgY2hlY2sgYXQgdGhlIGZpbmFsaXphdGlvbiBvZiB0aGUgdHJhbnNhY3Rpb24g aGFzDQp0byBiZSBrZXB0Lg0KDQo+IA0KPj4gwqBJZiBpdCBoYXMgYmVlbiB0b3VjaGVkLCB0 aGUgdHJhbnNhY3Rpb24gd2lsbA0KPj4gZmFpbCBhbnl3YXkuDQo+IFNvIHRoZSB0cmFuc2Fj dGlvbiB3aWxsIGZhaWwgdG8gY29tbWl0IGJlY2F1c2UgdGhlcmUgaXMgYSBjb25mbGljdC4g U28gdGhlIA0KPiBjbGllbnQgaXMgZXhwZWN0ZWQgdG8gcmV0cnkgaXQuIFdlIHNob3VsZCBu b3QgZXhwZWN0ZWQgdGhlIGNsaWVudCB0byByZXRyeSBmb3IgDQo+IGVycm9yIGxpa2UgcXVv dGEuDQoNCkNvcnJlY3QuIFRoZSBmYWlsdXJlIEknbSBtZW50aW9uaW5nIGlzbid0IGR1ZSB0 byBxdW90YSwgYnV0IGR1ZSB0byBhIGNvbmZsaWN0Lg0KDQo+IFNvIHRoZSBvdmVyYWxsIGJl aGF2aW9yIGlzIGNoYW5nZWQuDQoNCldlIGRvIHNvIGZvciBhbnkgYnVnLWZpeC4gQW5kIElN TyBteSBwYXRjaCBpcyBhIGJ1Zy1maXguDQoNCg0KSnVlcmdlbg0K --------------6RU3kLjQq0sIjNdaU38520vH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6RU3kLjQq0sIjNdaU38520vH-- --------------Fpnc3FBfLv9gEQ00OJYwEAcN-- --------------qW0mnbweOxsilN0CNqwAc3R0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzencFAwAAAAAACgkQsN6d1ii/Ey9m Vgf9EjWvQLh1YtdkuMBAk5lMovM2oABwUboblIuNhwgLPMFdFGZN3MyVnnTQwmQGHzdO/WMNF32N NXgO1MKdlFT7MGr2N0+ya3eeXaxKzvG7WvJKe1EPWEqBp7IMybT+/8M+7Qtljnb03+qHhawBZggp 5DPcPx5zAHFPx4VwstnBoMvpTNSgLECQyYU9Eb/69H2yd9lnBMjd9TW9r9Fa+YX1mjaoQaABcYWD YsfcpFFbHSwfXm5XlNSSbpsVUR14kWq8t5pDp8EGiN9GsyAjxy2o0T5zF381fUCY0ipR0lKQNot4 NI0qcF4XAZA7iutYyiBOv/7U2bOX9MHJgLO+llIMjA== =A5JF -----END PGP SIGNATURE----- --------------qW0mnbweOxsilN0CNqwAc3R0-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:06:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:06:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498139.768954 (Exim 4.92) (envelope-from ) id 1pU6oT-0000IV-P5; Mon, 20 Feb 2023 14:06:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498139.768954; Mon, 20 Feb 2023 14:06:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6oT-0000IO-MG; Mon, 20 Feb 2023 14:06:41 +0000 Received: by outflank-mailman (input) for mailman id 498139; Mon, 20 Feb 2023 14:06:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6oS-0000ID-It for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:06:40 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cac65a0b-b127-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 15:06:38 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BED4B20386; Mon, 20 Feb 2023 14:06:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 998DB139DB; Mon, 20 Feb 2023 14:06:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id soizI21+82N9JwAAMHmgww (envelope-from ); Mon, 20 Feb 2023 14:06:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cac65a0b-b127-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676901997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pqAH6ORw5HLmrIpb6r+CEEpRnc+4B+xJeQaoDxNgZtU=; b=mKhJgBA0jU/f3KbFzs/0MSCW9gZp6Ihz9GfAqJ1qwLvUZwxap8i5PI3s7kjH2CNDY+14Qi re1m7D7SbK6+VaQVmZjHB+AQ/yXkueWLQVDQ3syRy50SHjBQBNcsZR50zuSSiBrdWuv694 XbLv/Q4oFv0Wt4i+PhmJbAgZ8ZXuirY= Message-ID: Date: Mon, 20 Feb 2023 15:06:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Fl4I02dU0tlOkRNWqupb4JQ8" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Fl4I02dU0tlOkRNWqupb4JQ8 Content-Type: multipart/mixed; boundary="------------A1mY2TX5d00bB9Ip66ugj35V"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> In-Reply-To: --------------A1mY2TX5d00bB9Ip66ugj35V Content-Type: multipart/mixed; boundary="------------DqrIEip04WgyrN4fR2wiwaJf" --------------DqrIEip04WgyrN4fR2wiwaJf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMTQ6NDksIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEFzc3VtZSBub2Rl IHF1b3RhIGlzIDEwMDAsIGFuZCBhdCBzdGFydCBvZiB0aGUgdHJhbnNhY3Rpb24gdGhlIGd1 ZXN0IGlzIG93bmluZw0KPiA5OTkgbm9kZXMuIEluIHRoZSB0cmFuc2FjdGlvbiB0aGUgZ3Vl c3QgaXMgZGVsZXRpbmcgMTAgbm9kZXMsIHRoZW4gZG9tMCBpcw0KPiBjcmVhdGluZyA1IGFk ZGl0aW9uYWwgbm9kZXMgb3duZWQgYnkgdGhlIGd1ZXN0LiBUaGUgY2VudHJhbCBub2RlIGNv dW50ZXIgaXMgbm93DQo+IDEwMDQgKG92ZXIgcXVvdGEpLCB3aGlsZSB0aGUgaW4tdHJhbnNh Y3Rpb24gY291bnQgaXMgOTk0LiBJbiB0aGUgdHJhbnNhY3Rpb24gdGhlDQo+IGd1ZXN0IGNh biBub3cgaGFwcGlseSBjcmVhdGUgYSBuZXcgbm9kZSAoIzk5NSkgd2l0aCBteSBwYXRjaCwg YnV0IHdpbGwgZmFpbCB0bw0KPiBkbyBzbyB3aXRob3V0IChpdCBzZWVzIHRoZSAxMDA0IGR1 ZSB0byB0aGUgdHJhbnNhY3Rpb24gY291bnQgYmVpbmcgaWdub3JlZCkuDQoNCkl0IGlzIGV2 ZW4gd29yc2UsIHNvIEknZCBsaWtlIHRvIHN1Z2dlc3QgdGhlIGZvbGxvd2luZyBjb21taXQg bWVzc2FnZToNCg0KICAgdG9vbHMveGVuc3RvcmU6IHRha2UgdHJhbnNhY3Rpb24gaW50ZXJu YWwgbm9kZXMgaW50byBhY2NvdW50IGZvciBxdW90YQ0KDQogICBUaGUgYWNjb3VudGluZyBm b3IgdGhlIG51bWJlciBvZiBub2RlcyBvZiBhIGRvbWFpbiBpbiBhbiBhY3RpdmUNCiAgIHRy YW5zYWN0aW9uIGlzIG5vdCB3b3JraW5nIGNvcnJlY3RseSwgYXMgaXQgaXMgY2hlY2tpbmcg dGhlIG5vZGUgcXVvdGENCiAgIG9ubHkgYWdhaW5zdCB0aGUgbnVtYmVyIG9mIG5vZGVzIG91 dHNpZGUgdGhlIHRyYW5zYWN0aW9uLg0KDQogICBUaGlzIGNhbiByZXN1bHQgaW4gdGhlIHRy YW5zYWN0aW9uIGZpbmFsbHkgZmFpbGluZywgYXMgbm9kZSBxdW90YSBpcw0KICAgY2hlY2tl ZCBhdCB0aGUgZW5kIG9mIHRoZSB0cmFuc2FjdGlvbiBhZ2Fpbi4NCg0KICAgT24gdGhlIG90 aGVyIGhhbmQgZXZlbiBpbiBhIHRyYW5zYWN0aW9uIGRlbGV0aW5nIG1hbnkgbm9kZXMsIG5l dyBub2Rlcw0KICAgbWlnaHQgbm90IGJlIGNyZWF0YWJsZSwgaW4gY2FzZSB0aGUgbm9kZSBx dW90YSB3YXMgYWxyZWFkeSByZWFjaGVkIGF0DQogICB0aGUgc3RhcnQgb2YgdGhlIHRyYW5z YWN0aW9uLg0KDQoNCkp1ZXJnZW4NCg== --------------DqrIEip04WgyrN4fR2wiwaJf Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------DqrIEip04WgyrN4fR2wiwaJf-- --------------A1mY2TX5d00bB9Ip66ugj35V-- --------------Fl4I02dU0tlOkRNWqupb4JQ8 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzfm0FAwAAAAAACgkQsN6d1ii/Ey8i WQf7BBtaS1JRoXZaL8+wTHcRreOYlC8ZBqkunTdDngAHYur3yC2f+S7eKFt2dBT6QHPbwyMJWwne pAQlOX5d6g1BpjrhRlpvqFgDXjPXJ5f/14PIQ7mwNMCsUnrfWLmoBbI+MPLnOSIXNOfxpdZac4P0 F7nf15JFhtIlvvrKZVZvLUKkDlWU4OOf6XlM8t3fqaGjMfOzJayrnBXOqzkCjEDjo7wgkWc5EQ7v vMRavidGY0xUuHebTB/Cvu8lKovh60pnUwzA+8Fqez1egHEu6+d+J0s/0gFT0F+t9cqeOHHxdFPa lapkkKHhlwpepWNZByTVOqThF8MzA7XXwiWL+n8u6Q== =pg5U -----END PGP SIGNATURE----- --------------Fl4I02dU0tlOkRNWqupb4JQ8-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:15:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:15:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498153.768969 (Exim 4.92) (envelope-from ) id 1pU6wz-00026X-Qo; Mon, 20 Feb 2023 14:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498153.768969; Mon, 20 Feb 2023 14:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6wz-00026Q-Nt; Mon, 20 Feb 2023 14:15:29 +0000 Received: by outflank-mailman (input) for mailman id 498153; Mon, 20 Feb 2023 14:15:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6wy-00026K-2e for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:15:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6wx-0001Zn-0f; Mon, 20 Feb 2023 14:15:27 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.98.51]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pU6ww-00006y-Om; Mon, 20 Feb 2023 14:15:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=QMsLr1C+LnFAyEtyEki6LwbJg1Un3IlzvmAULNT/j24=; b=dTYyNeyYCuMMjYlkd9OUj4P0W7 Ft8bOTpkidciiowO75cUOWMKxpOoas1Mgy7QNgTkbnriAaApoCeMEnCMV82Za4Al0Z0bgywylPGAP VE4BzrAPg73AB8nn7ETree5tNchMpCOEBdTsSvthIg6s6aHVCDWuUFWJSoj3MQMdzbec=; Message-ID: Date: Mon, 20 Feb 2023 14:15:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/02/2023 13:49, Juergen Gross wrote: > On 20.02.23 13:07, Julien Grall wrote: >> Hi Juergen, >> >> On 20/02/2023 11:04, Juergen Gross wrote: >>> On 20.02.23 10:46, Julien Grall wrote: >>>> Hi Juergen, >>>> >>>> On 20/01/2023 10:00, Juergen Gross wrote: >>>>> The accounting for the number of nodes of a domain in an active >>>>> transaction is not working correctly, as it allows to create arbitrary >>>>> number of nodes. The transaction will finally fail due to exceeding >>>>> the number of nodes quota, but before closing the transaction an >>>>> unprivileged guest could cause Xenstore to use a lot of memory. >>>> >>>> I know I said I would delay my decision on this patch. However, I >>>> was still expecting the commit message to be updated based on our >>>> previous discussion. >>> >>> As said before, I was waiting on the settlement of our discussion before >>> doing the update. >> >> This is not a very good practice to resend a patch without recording >> the disagreement because new reviewers may not be aware of the >> disagreement and this could end up to be committed by mistake... > > You said you wanted to look into this patch in detail after the previous > series, so I move it into this series. The wording update would strongly > depend on the outcome of the discussion IMO, so I didn't do it yet. This could have been mentioned after ---. This could allow people to understand the concern and then participate. > >>>> Also thinking more about it, "The transaction will finally fail due >>>> to exceeding the number of nodes quota" may not be true for a couple >>>> of reasons: >>>>    1) The transaction may removed a node afterwards. >>> >>> Yes, and? Just because it is a transaction, this is still a violation of >>> the quota. Even outside a transaction you could use the same reasoning, >>> but you don't (which is correct, of course). >> >> I can understand your point. However, to me, the goal of the >> transaction is to commit everything in one go at the end. So the >> violations in the middle should not matter. > > Of course they should. > > We wouldn't allow to write over-sized nodes, even if they could be > rewritten in > the same transaction with a smaller size. I view the two different. > We wouldn't allow to create nodes which would violate overall memory > consumption. > > We wouldn't allow nodes with more permission entries than allowed, even > if they > could be reduced in the same transaction again. > > I don't see why the number of nodes shouldn't be taken into account. > >> Furthermore, I would expect a transaction to work on a snapshot of the >> system. So it feels really strange to me that we are constantly >> checking the quota with the updated values rather than the initial one. > > You are aware that the code without this patch is just neglecting the nodes > created in the transaction? It just is using the current number of nodes > outside any transaction for quota check. Are you referring to the quota check within the transaction? > So I could easily create a > scenario > where my new code will succeed, but the current one is failing: > Assume node quota is 1000, and at start of the transaction the guest is > owning > 999 nodes. In the transaction the guest is deleting 10 nodes, then dom0 is > creating 5 additional nodes owned by the guest. The central node counter > is now > 1004 (over quota), while the in-transaction count is 994. > In the > transaction the > guest can now happily create a new node (#995) with my patch, but will > fail to > do so without (it sees the 1004 due to the transaction count being > ignored). This doesn't sound correct. To do you have any test I could use to check the behavior? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:15:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:15:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498154.768980 (Exim 4.92) (envelope-from ) id 1pU6xI-0002Rc-2Z; Mon, 20 Feb 2023 14:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498154.768980; Mon, 20 Feb 2023 14:15:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6xH-0002RR-Vw; Mon, 20 Feb 2023 14:15:47 +0000 Received: by outflank-mailman (input) for mailman id 498154; Mon, 20 Feb 2023 14:15:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU6xG-0002Pg-P1 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:15:46 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bf96a80-b129-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 15:15:40 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id bo30so809435wrb.0 for ; Mon, 20 Feb 2023 06:15:40 -0800 (PST) Received: from [10.85.37.29] (54-240-197-224.amazon.com. [54.240.197.224]) by smtp.gmail.com with ESMTPSA id q6-20020a05600c46c600b003dc47d458cdsm1217989wmo.15.2023.02.20.06.15.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 06:15:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bf96a80-b129-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=xQCb1ix8pNS+owqIqISbUEGAgwSj/rWUCCNBqA9XyJ4=; b=S0QZmUyXNbfOuK49Loj+B7q4weWvEakMqyD6NU35NK7SDL8v1+IgWhu0mzrlIxknbE vRl/pCSG+Ftn0giOlnQX3g16OfYU0UpUkGuS4V+1RWMV7x4TjggvvQLoHNWGeqrAnkQ6 zvTedmDD15vnVbMr5hSPnldhsNd8sOoL+On/IcoDszwJCCSYj4KpDs9TbvVaNBAPrGKh 5mUSJd0No8Julb80I2sgNplotIkv7fcwhNTlrV+BA1cO6kbrVBKvzfjyKBws/hX+doAB h2Na/izk0TN9a8HaW981hFwPjpXXJ2Zb1TriDn4+d8jpcyH+XKWlW5r4S0m2XAh0Tk5G GZEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xQCb1ix8pNS+owqIqISbUEGAgwSj/rWUCCNBqA9XyJ4=; b=sngQILQ7ZYGSvcUHi0UoG3Z0ycvKCBaGgKKZHdjOPmHUJS1KDCMsrgLk9cEYaqVker t8YkrtZZk+L2aeSxVMVBb3vBhMaJR8pKkFRFX6o3jHrrBx5s9hd57nIsq3MnH/YxphUt 2YaL3d9hPj7fxbOODPALNZXYlSJpDwU1G0sCvrpQl0Iypk9jDWp76uYTayEPQrocvh4q 5oe2GBIiHAQeWL/xYEJ8PbmOjaEZDtnkwOf+sZnKhTPsZ5NwFIsjBWCjofgRr6oePrI9 FSi9Fhzho6yiIiG+7uiBW3CJ6srAd0QMtm+87/U7dGw5tWm1ZcZt0uHjROcCFQzNAvOn 8DWg== X-Gm-Message-State: AO0yUKV5F8z+mKPGrHoQtL9fip9igJm+K3jkW6uCsEh/5BeUtJZVR76V 9RwToN5WFAOlWOtxkRCcthw= X-Google-Smtp-Source: AK7set/hYzJ62KuefT/lcq2s6/oWByZknFIl8q3J19ZABmaCyMvGNi2AMj4i5yhufpbIcca9PrSPSg== X-Received: by 2002:a05:6000:45:b0:2c6:2ac4:66ee with SMTP id k5-20020a056000004500b002c62ac466eemr2249981wrx.39.1676902536787; Mon, 20 Feb 2023 06:15:36 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <1cdab4ab-a73e-0971-dece-729994f2b8c7@xen.org> Date: Mon, 20 Feb 2023 14:15:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: paul@xen.org Subject: Re: [PATCH] hw/i386/xen: Remove unused 'hw/ide.h' include from header Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Anthony Perard , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum References: <20230220092707.22584-1-philmd@linaro.org> Organization: Xen Project In-Reply-To: <20230220092707.22584-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/02/2023 09:27, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/xen/xen_platform.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c > index 66e6de31a6..3795a203d4 100644 > --- a/hw/i386/xen/xen_platform.c > +++ b/hw/i386/xen/xen_platform.c > @@ -25,7 +25,6 @@ > > #include "qemu/osdep.h" > #include "qapi/error.h" > -#include "hw/ide.h" > #include "hw/ide/pci.h" > #include "hw/pci/pci.h" > #include "hw/xen/xen_common.h" Acked-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:21:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:21:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498170.768990 (Exim 4.92) (envelope-from ) id 1pU72p-0004IZ-Ms; Mon, 20 Feb 2023 14:21:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498170.768990; Mon, 20 Feb 2023 14:21:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU72p-0004IS-KL; Mon, 20 Feb 2023 14:21:31 +0000 Received: by outflank-mailman (input) for mailman id 498170; Mon, 20 Feb 2023 14:21:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU72o-0004IM-Cx for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:21:30 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dca9f428-b129-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 15:21:27 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E81252262C; Mon, 20 Feb 2023 14:21:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C2235139DB; Mon, 20 Feb 2023 14:21:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id S30YLuaB82OkLwAAMHmgww (envelope-from ); Mon, 20 Feb 2023 14:21:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dca9f428-b129-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676902886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7u8x3HiPTwZYBOR7Qt8Ju6d82l5CbSu67vkoya7pNEo=; b=YrnXdD1g0hkIsiasG/kkCuTDn3TZwI/By+WbmboEiQwjkE7CjZTEEEBoWaVtAvfkN21D17 YvMvJ6kJCmPHTCGW4iFyxfQogr5iTaYh/hGk1GM8ALti27LBLgQqP0f4xBO4oieYzK6f2x +4rOJ0YLVeV45A6nwSJDp6hOvQbEX4c= Message-ID: <32a517cf-4448-2208-4877-83c7a7531635@suse.com> Date: Mon, 20 Feb 2023 15:21:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------5a9l0MQz3vB00ig1qfR1tDvM" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------5a9l0MQz3vB00ig1qfR1tDvM Content-Type: multipart/mixed; boundary="------------m3ilG02e0mcemr2SfDmh4ULC"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <32a517cf-4448-2208-4877-83c7a7531635@suse.com> Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> In-Reply-To: --------------m3ilG02e0mcemr2SfDmh4ULC Content-Type: multipart/mixed; boundary="------------mPEpceee8hAd0sakgU0yjHNz" --------------mPEpceee8hAd0sakgU0yjHNz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMTU6MTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gT24gMjAvMDIvMjAy MyAxMzo0OSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE9uIDIwLjAyLjIzIDEzOjA3LCBK dWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gSGkgSnVlcmdlbiwNCj4+Pg0KPj4+IE9uIDIwLzAy LzIwMjMgMTE6MDQsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+IE9uIDIwLjAyLjIzIDEw OjQ2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+PiBIaSBKdWVyZ2VuLA0KPj4+Pj4NCj4+ Pj4+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+Pj4g VGhlIGFjY291bnRpbmcgZm9yIHRoZSBudW1iZXIgb2Ygbm9kZXMgb2YgYSBkb21haW4gaW4g YW4gYWN0aXZlDQo+Pj4+Pj4gdHJhbnNhY3Rpb24gaXMgbm90IHdvcmtpbmcgY29ycmVjdGx5 LCBhcyBpdCBhbGxvd3MgdG8gY3JlYXRlIGFyYml0cmFyeQ0KPj4+Pj4+IG51bWJlciBvZiBu b2Rlcy4gVGhlIHRyYW5zYWN0aW9uIHdpbGwgZmluYWxseSBmYWlsIGR1ZSB0byBleGNlZWRp bmcNCj4+Pj4+PiB0aGUgbnVtYmVyIG9mIG5vZGVzIHF1b3RhLCBidXQgYmVmb3JlIGNsb3Np bmcgdGhlIHRyYW5zYWN0aW9uIGFuDQo+Pj4+Pj4gdW5wcml2aWxlZ2VkIGd1ZXN0IGNvdWxk IGNhdXNlIFhlbnN0b3JlIHRvIHVzZSBhIGxvdCBvZiBtZW1vcnkuDQo+Pj4+Pg0KPj4+Pj4g SSBrbm93IEkgc2FpZCBJIHdvdWxkIGRlbGF5IG15IGRlY2lzaW9uIG9uIHRoaXMgcGF0Y2gu IEhvd2V2ZXIsIEkgd2FzIHN0aWxsIA0KPj4+Pj4gZXhwZWN0aW5nIHRoZSBjb21taXQgbWVz c2FnZSB0byBiZSB1cGRhdGVkIGJhc2VkIG9uIG91ciBwcmV2aW91cyBkaXNjdXNzaW9uLg0K Pj4+Pg0KPj4+PiBBcyBzYWlkIGJlZm9yZSwgSSB3YXMgd2FpdGluZyBvbiB0aGUgc2V0dGxl bWVudCBvZiBvdXIgZGlzY3Vzc2lvbiBiZWZvcmUNCj4+Pj4gZG9pbmcgdGhlIHVwZGF0ZS4N Cj4+Pg0KPj4+IFRoaXMgaXMgbm90IGEgdmVyeSBnb29kIHByYWN0aWNlIHRvIHJlc2VuZCBh IHBhdGNoIHdpdGhvdXQgcmVjb3JkaW5nIHRoZSANCj4+PiBkaXNhZ3JlZW1lbnQgYmVjYXVz ZSBuZXcgcmV2aWV3ZXJzIG1heSBub3QgYmUgYXdhcmUgb2YgdGhlIGRpc2FncmVlbWVudCBh bmQgDQo+Pj4gdGhpcyBjb3VsZCBlbmQgdXAgdG8gYmUgY29tbWl0dGVkIGJ5IG1pc3Rha2Uu Li4NCj4+DQo+PiBZb3Ugc2FpZCB5b3Ugd2FudGVkIHRvIGxvb2sgaW50byB0aGlzIHBhdGNo IGluIGRldGFpbCBhZnRlciB0aGUgcHJldmlvdXMNCj4+IHNlcmllcywgc28gSSBtb3ZlIGl0 IGludG8gdGhpcyBzZXJpZXMuIFRoZSB3b3JkaW5nIHVwZGF0ZSB3b3VsZCBzdHJvbmdseQ0K Pj4gZGVwZW5kIG9uIHRoZSBvdXRjb21lIG9mIHRoZSBkaXNjdXNzaW9uIElNTywgc28gSSBk aWRuJ3QgZG8gaXQgeWV0Lg0KPiBUaGlzIGNvdWxkIGhhdmUgYmVlbiBtZW50aW9uZWQgYWZ0 ZXIgLS0tLiBUaGlzIGNvdWxkIGFsbG93IHBlb3BsZSB0byB1bmRlcnN0YW5kIA0KPiB0aGUg Y29uY2VybiBhbmQgdGhlbiBwYXJ0aWNpcGF0ZS4NCg0KV2lsbCBkbyBzbyBpbiBmdXR1cmUu DQoNCj4gDQo+Pg0KPj4+Pj4gQWxzbyB0aGlua2luZyBtb3JlIGFib3V0IGl0LCAiVGhlIHRy YW5zYWN0aW9uIHdpbGwgZmluYWxseSBmYWlsIGR1ZSB0byANCj4+Pj4+IGV4Y2VlZGluZyB0 aGUgbnVtYmVyIG9mIG5vZGVzIHF1b3RhIiBtYXkgbm90IGJlIHRydWUgZm9yIGEgY291cGxl IG9mIHJlYXNvbnM6DQo+Pj4+PiDCoMKgIDEpIFRoZSB0cmFuc2FjdGlvbiBtYXkgcmVtb3Zl ZCBhIG5vZGUgYWZ0ZXJ3YXJkcy4NCj4+Pj4NCj4+Pj4gWWVzLCBhbmQ/IEp1c3QgYmVjYXVz ZSBpdCBpcyBhIHRyYW5zYWN0aW9uLCB0aGlzIGlzIHN0aWxsIGEgdmlvbGF0aW9uIG9mDQo+ Pj4+IHRoZSBxdW90YS4gRXZlbiBvdXRzaWRlIGEgdHJhbnNhY3Rpb24geW91IGNvdWxkIHVz ZSB0aGUgc2FtZSByZWFzb25pbmcsDQo+Pj4+IGJ1dCB5b3UgZG9uJ3QgKHdoaWNoIGlzIGNv cnJlY3QsIG9mIGNvdXJzZSkuDQo+Pj4NCj4+PiBJIGNhbiB1bmRlcnN0YW5kIHlvdXIgcG9p bnQuIEhvd2V2ZXIsIHRvIG1lLCB0aGUgZ29hbCBvZiB0aGUgdHJhbnNhY3Rpb24gaXMgDQo+ Pj4gdG8gY29tbWl0IGV2ZXJ5dGhpbmcgaW4gb25lIGdvIGF0IHRoZSBlbmQuIFNvIHRoZSB2 aW9sYXRpb25zIGluIHRoZSBtaWRkbGUgDQo+Pj4gc2hvdWxkIG5vdCBtYXR0ZXIuDQo+Pg0K Pj4gT2YgY291cnNlIHRoZXkgc2hvdWxkLg0KPj4NCj4+IFdlIHdvdWxkbid0IGFsbG93IHRv IHdyaXRlIG92ZXItc2l6ZWQgbm9kZXMsIGV2ZW4gaWYgdGhleSBjb3VsZCBiZSByZXdyaXR0 ZW4gaW4NCj4+IHRoZSBzYW1lIHRyYW5zYWN0aW9uIHdpdGggYSBzbWFsbGVyIHNpemUuDQo+ IA0KPiBJIHZpZXcgdGhlIHR3byBkaWZmZXJlbnQuDQo+IA0KPj4gV2Ugd291bGRuJ3QgYWxs b3cgdG8gY3JlYXRlIG5vZGVzIHdoaWNoIHdvdWxkIHZpb2xhdGUgb3ZlcmFsbCBtZW1vcnkN Cj4+IGNvbnN1bXB0aW9uLg0KPj4NCj4+IFdlIHdvdWxkbid0IGFsbG93IG5vZGVzIHdpdGgg bW9yZSBwZXJtaXNzaW9uIGVudHJpZXMgdGhhbiBhbGxvd2VkLCBldmVuIGlmIHRoZXkNCj4+ IGNvdWxkIGJlIHJlZHVjZWQgaW4gdGhlIHNhbWUgdHJhbnNhY3Rpb24gYWdhaW4uDQo+Pg0K Pj4gSSBkb24ndCBzZWUgd2h5IHRoZSBudW1iZXIgb2Ygbm9kZXMgc2hvdWxkbid0IGJlIHRh a2VuIGludG8gYWNjb3VudC4NCj4+DQo+Pj4gRnVydGhlcm1vcmUsIEkgd291bGQgZXhwZWN0 IGEgdHJhbnNhY3Rpb24gdG8gd29yayBvbiBhIHNuYXBzaG90IG9mIHRoZSANCj4+PiBzeXN0 ZW0uIFNvIGl0IGZlZWxzIHJlYWxseSBzdHJhbmdlIHRvIG1lIHRoYXQgd2UgYXJlIGNvbnN0 YW50bHkgY2hlY2tpbmcgdGhlIA0KPj4+IHF1b3RhIHdpdGggdGhlIHVwZGF0ZWQgdmFsdWVz IHJhdGhlciB0aGFuIHRoZSBpbml0aWFsIG9uZS4NCj4+DQo+PiBZb3UgYXJlIGF3YXJlIHRo YXQgdGhlIGNvZGUgd2l0aG91dCB0aGlzIHBhdGNoIGlzIGp1c3QgbmVnbGVjdGluZyB0aGUg bm9kZXMNCj4+IGNyZWF0ZWQgaW4gdGhlIHRyYW5zYWN0aW9uPyBJdCBqdXN0IGlzIHVzaW5n IHRoZSBjdXJyZW50IG51bWJlciBvZiBub2Rlcw0KPj4gb3V0c2lkZSBhbnkgdHJhbnNhY3Rp b24gZm9yIHF1b3RhIGNoZWNrLg0KPiANCj4gQXJlIHlvdSByZWZlcnJpbmcgdG8gdGhlIHF1 b3RhIGNoZWNrIHdpdGhpbiB0aGUgdHJhbnNhY3Rpb24/DQoNCkknbSByZWZlcnJpbmcgdG8g dGhlIHF1b3RhIGNoZWNrIGluIGNyZWF0ZV9ub2RlKCkuDQoNCj4gDQo+PiBTbyBJIGNvdWxk IGVhc2lseSBjcmVhdGUgYSBzY2VuYXJpbw0KPj4gd2hlcmUgbXkgbmV3IGNvZGUgd2lsbCBz dWNjZWVkLCBidXQgdGhlIGN1cnJlbnQgb25lIGlzIGZhaWxpbmc6DQo+PiBBc3N1bWUgbm9k ZSBxdW90YSBpcyAxMDAwLCBhbmQgYXQgc3RhcnQgb2YgdGhlIHRyYW5zYWN0aW9uIHRoZSBn dWVzdCBpcyBvd25pbmcNCj4+IDk5OSBub2Rlcy4gSW4gdGhlIHRyYW5zYWN0aW9uIHRoZSBn dWVzdCBpcyBkZWxldGluZyAxMCBub2RlcywgdGhlbiBkb20wIGlzDQo+PiBjcmVhdGluZyA1 IGFkZGl0aW9uYWwgbm9kZXMgb3duZWQgYnkgdGhlIGd1ZXN0LiBUaGUgY2VudHJhbCBub2Rl IGNvdW50ZXIgaXMgbm93DQo+PiAxMDA0IChvdmVyIHF1b3RhKSwgd2hpbGUgdGhlIGluLXRy YW5zYWN0aW9uIGNvdW50IGlzIDk5NC4NCj4+IEluIHRoZSB0cmFuc2FjdGlvbiB0aGUNCj4+ IGd1ZXN0IGNhbiBub3cgaGFwcGlseSBjcmVhdGUgYSBuZXcgbm9kZSAoIzk5NSkgd2l0aCBt eSBwYXRjaCwgYnV0IHdpbGwgZmFpbCB0bw0KPj4gZG8gc28gd2l0aG91dCAoaXQgc2VlcyB0 aGUgMTAwNCBkdWUgdG8gdGhlIHRyYW5zYWN0aW9uIGNvdW50IGJlaW5nIGlnbm9yZWQpLg0K PiANCj4gVGhpcyBkb2Vzbid0IHNvdW5kIGNvcnJlY3QuIFRvIGRvIHlvdSBoYXZlIGFueSB0 ZXN0IEkgY291bGQgdXNlIHRvIGNoZWNrIHRoZSANCj4gYmVoYXZpb3I/DQoNClRyeSBpdDoN Cg0KLSBjcmVhdGUgbm9kZXMgaW4gYSBndWVzdCB1bnRpbCB5b3UgaGl0IHRoZSBFTk9TUEMg cmV0dXJuIGNvZGUgZHVlIHRvIHRvbyBtYW55DQogICBub2Rlcw0KLSBzdGFydCBhIHRyYW5z YWN0aW9uIGRlbGV0aW5nIHNvbWUgbm9kZXMgYW5kIHRoZW4gdHJ5aW5nIHRvIGNyZWF0ZSBh bm90aGVyDQogICBvbmUsIHdoaWNoIGZhaWwgZmFpbCB3aXRoIEVOT1NQQy4NCg0KDQpKdWVy Z2VuDQo= --------------mPEpceee8hAd0sakgU0yjHNz Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------mPEpceee8hAd0sakgU0yjHNz-- --------------m3ilG02e0mcemr2SfDmh4ULC-- --------------5a9l0MQz3vB00ig1qfR1tDvM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmPzgeYFAwAAAAAACgkQsN6d1ii/Ey8D lwf/XhHvC2Kk/jVLDWM8T3mIQyZj6+E0p7IeXHiLDElzOjytcsF8VUbqJcuN0OqD5hdfICikNWO7 vDWBh28X5pRQ3KMqQn6UheZCx1n0OQMWPKDdO0ntUgXhW/Ur0VDyHLWWZD/lEd7gEXQ3dxmbRj86 nLht1zfhLyAL2quUyhtGF6P1cJHgMKHamQzskW0OfUZtZCM1dwHUdIwLSvZhFKi2ycTwEQ3tMKKB 3e55QMr+18ubSmaC4iB5nkTDYJir0cSI0GWC4MluiLe86MI7gCyGfL0s9vBJTCDgAtgd42L1QjYy BAf4FnzHwf98iowCnnMPc30LQw6raylKtLYSLb8h3w== =rPiS -----END PGP SIGNATURE----- --------------5a9l0MQz3vB00ig1qfR1tDvM-- From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:31:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:31:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498176.769001 (Exim 4.92) (envelope-from ) id 1pU7CG-0005z5-Jz; Mon, 20 Feb 2023 14:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498176.769001; Mon, 20 Feb 2023 14:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU7CG-0005yy-H8; Mon, 20 Feb 2023 14:31:16 +0000 Received: by outflank-mailman (input) for mailman id 498176; Mon, 20 Feb 2023 14:31:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU7CF-0005ys-Ba for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:31:15 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38be83e8-b12b-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 15:31:11 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id p8so1558725wrt.12 for ; Mon, 20 Feb 2023 06:31:11 -0800 (PST) Received: from [10.85.37.29] (54-240-197-224.amazon.com. [54.240.197.224]) by smtp.gmail.com with ESMTPSA id a17-20020adffad1000000b002c54e26bca5sm5769962wrs.49.2023.02.20.06.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 06:31:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38be83e8-b12b-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=uapwYjG86j09Ao3mvRI6hLJtSjzf0Mx1ain+YxVd2BI=; b=hSQTdGUJEXGKq5Wud5TAYYDkn8KABInLFUYE+YusrDV5Ovf+HsD1rOdu/OnXW7yA9Y eLXGYOLqkjZwaniw06Fn35BRstiJPQqPptcg+lPynDycV+nnITZTXrDlzT9zq7VLHQgl 2NVvHbT+7iwVFKKFHGEk4JpNEEYReR/QAVNqh4USvu9GLyKxDHEYmpd+hQ+qiQvxWkSe bKtYvnnPls0hz5vSBMA7BtFrZb/wCyFT7zTjubhQF6XYPx7p/3fwQGq8c/oUna51Q/Oc 6iSm3PD/6+OHGjU0yeR+6tu1RGdsff/OGIn/FeV/Z/0K4qE1Y3xAWqY90dx31HrYwWSM CDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uapwYjG86j09Ao3mvRI6hLJtSjzf0Mx1ain+YxVd2BI=; b=XtNUERh//UdItS1tAHcUsiH6FYJqfv6wcsXTXKsILQEdJ7ACrMIHAO9AlS3LeKMeWu zbhgB5jzKD3Y4SzWtoZHLenXhDB2CxR7DXY4IwpcBteqjKYe+EiXm5SagiSTD4ssi8c7 vlpnGugFVq+1pmlELzjLu84hOnVZ0yFM/dkjpciCRRdEq27RROudTFmd6nUAKirJieDf 27L5D7SdT/CSHZRD81YhRjCtr7hqzKd8rPhzZZHA1lZTE2cHo7oFBOWhzElOmhPcZHWe XakBCs1Em/6+9Kw3fYivpiWFsrBcvRAoruJ3Yw6XZa4T5H4ovkf4eWDHCc+ut3HF7j/f D9Ig== X-Gm-Message-State: AO0yUKUn9DP6dF1hIp+AwzSNBG5F8ZfFfxDKdKFNhCkd/t5+oU4de4Rt wwN9E19EyVPTjooJndqlb24= X-Google-Smtp-Source: AK7set/rskOGDs/Z2znmzqCCaAutsqAyx0x+1Ja7sEXGjK57+P5aqoHZuUBPoOyvYEvouv1K55YXtQ== X-Received: by 2002:a5d:4cc7:0:b0:2c6:5168:7785 with SMTP id c7-20020a5d4cc7000000b002c651687785mr1520329wrt.28.1676903470855; Mon, 20 Feb 2023 06:31:10 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <44b7cee5-5a8a-44fd-7cd9-e50864a6dfa8@xen.org> Date: Mon, 20 Feb 2023 14:31:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: paul@xen.org Subject: Re: [PATCH] accel/xen: Remove dead code Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Anthony Perard , Stefano Stabellini , xen-devel@lists.xenproject.org, qemu-trivial@nongnu.org References: <20230215153451.30626-1-philmd@linaro.org> Organization: Xen Project In-Reply-To: <20230215153451.30626-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/02/2023 15:34, Philippe Mathieu-Daudé wrote: > Unused since introduction in commit 04b0de0ee8 > ("xen: factor out common functions"). > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/xen/xen-all.c | 10 ---------- > 1 file changed, 10 deletions(-) > Acked-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Mon Feb 20 14:57:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 14:57:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498194.769016 (Exim 4.92) (envelope-from ) id 1pU7bL-0000bm-NJ; Mon, 20 Feb 2023 14:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498194.769016; Mon, 20 Feb 2023 14:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU7bL-0000bf-Kh; Mon, 20 Feb 2023 14:57:11 +0000 Received: by outflank-mailman (input) for mailman id 498194; Mon, 20 Feb 2023 14:57:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU7bJ-0000bX-UY for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 14:57:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d91bfb4f-b12e-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 15:57:08 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D52F2049A; Mon, 20 Feb 2023 14:57:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60ADC134BA; Mon, 20 Feb 2023 14:57:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id s10mFkSK82P1QwAAMHmgww (envelope-from ); Mon, 20 Feb 2023 14:57:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91bfb4f-b12e-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676905028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gW0vA6lTPSl+sxfxbA90Yvch05sHmFUrm4oBgNvFLrs=; b=nNfEFQUkkb9yR/Ds+9WAHF4G6bYAE3CDxo5xdaftCeoG/XRXuIgI2Xtko8EIRvQ6TWagXI iQPh3CC7kfyB1QWON4FMqAL1INBdsiKf5HgR3M5/xezCkCKX2IESBJRXAWjhOtAghDWYfX bugdWjdWJaV5b47c+TmV+gdCMAlRAW4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstore: remove stale comment in create_node() Date: Mon, 20 Feb 2023 15:57:06 +0100 Message-Id: <20230220145706.15905-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There is a part of a comment in create_node() which should have been deleted when modifying the related coding. Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 7348f935bc..a61db2db2d 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1480,9 +1480,6 @@ static struct node *create_node(struct connection *conn, const void *ctx, * All new created nodes will have i->parent set, while the final * node will be already existing and won't have i->parent set. * New nodes are subject to quota handling. - * Initially set a destructor for all new nodes removing them from - * TDB again and undoing quota accounting for the case of an error - * during the write loop. */ for (i = node; i; i = i->parent) { /* i->parent is set for each new node, so check quota. */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498239.769104 (Exim 4.92) (envelope-from ) id 1pU9E4-0007Zs-NM; Mon, 20 Feb 2023 16:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498239.769104; Mon, 20 Feb 2023 16:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9E4-0007Zj-Iz; Mon, 20 Feb 2023 16:41:16 +0000 Received: by outflank-mailman (input) for mailman id 498239; Mon, 20 Feb 2023 16:41:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9E3-0006Vi-6U for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:41:15 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63d86e37-b13d-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 17:41:14 +0100 (CET) Received: by mail-lj1-x235.google.com with SMTP id l8so1771605ljq.3 for ; Mon, 20 Feb 2023 08:41:14 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id f8-20020a2e6a08000000b002934d555783sm65798ljc.6.2023.02.20.08.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:41:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63d86e37-b13d-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=brWuH85TZkY9/IYxdPrwIkUjLxv9KxBhQf85+vQ58wk=; b=MmRKeCMdzrG6DgNv6Ggsgf8G/lMwhwCFonQEkCwdQDcQFu9ccqxj95wBG/IVOZaqnk Cn/Q0rk1b86MC+30UZd9NkmfPhLhAhJU7EVQLoI1wsBrv+2PAc6bZAcjnN/NohTxQ+pd G6xq1V8F1sVLqA9lXsE7KNvT4FURLrQ70PaUcwFpGDIFFh6yBZ3mwzHPqgR9W/3P3hWW fb6L5cXlx6isYkbd4QLSRu0tXhXj6MA2pERQmEnA2FP07hRbM6OLMcjDaYuKUB9ozDmL qTCctEWwAALncKXrK8hSO+BJt4zAahcE5X4kuWrsGRn0N3nAGlcutP6XeBh45iOzPyhT zuZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=brWuH85TZkY9/IYxdPrwIkUjLxv9KxBhQf85+vQ58wk=; b=aA8BOoE1Qfz5Q1LiyzCGu7y+n64+YWfpXrwiZUJa9rAkVw2k1nTqGuA7yVuFsrDbrm Zuj4ZLSgvKUEiRdLbLX7IgefwdCmomEQg7Eg1Ri5aSj5dpEEA1c7jOXNcN+XSy/4xSaB +vbvAbbcJnCGh3Fb7w1IXq8E3cUJ//dNDBrtsUSTeCcpPf6nOXgteCdTYLGMWv/pso4H ZtuU11hCSg+t5wTNhwjPP5/PRfLVZP3zurkmarf2GdlJjDS04pEGfZiYNFwmhKEvcwNS DvM1ZCCZd17yqrKsQyQ+tbrYap7VcFJYvYRG/tJUDeKo1hNtclSheVJRlq6jRZof+Azc CgbQ== X-Gm-Message-State: AO0yUKXXITzrmVcGBgcN+lyPwaVgna6BR/KJGLhWHmST1QDt7Qb+iCmL oOT5WWqlKaeneq9Vz3jKeWtmfcvamvs= X-Google-Smtp-Source: AK7set+NVAnmJghQX6aiBFVCLKdpyaj6Mv2mvGiPVfX8m5pajdpOfDnIQD0R+mBYQPtZNwJfbjXQjg== X-Received: by 2002:a05:651c:1543:b0:293:5312:b021 with SMTP id y3-20020a05651c154300b002935312b021mr354992ljp.14.1676911273817; Mon, 20 Feb 2023 08:41:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 4/4] xen/x86: switch x86 to use generic implemetation of bug.h Date: Mon, 20 Feb 2023 18:41:00 +0200 Message-Id: <14900d647181be59b5b7d90c013f0914ed273088.1676909088.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V2: * Remove all unnecessary things from as they were introduced in . * Define BUG_INSTR = 'ud2' and MODIFIER = 'c' ( it is needed to skip '$' when use an imidiate in x86 assembly ) * Update do_invalid_op() to re-use handle_bug_frame() and find_bug_frame() from generic implemetation of CONFIG_GENERIC_BUG_FRAME * Code style fixes. --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/include/asm/bug.h | 88 ++-------------------------------- xen/arch/x86/traps.c | 81 +++++-------------------------- 3 files changed, 18 insertions(+), 152 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba..b0ff1f3ee6 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -11,6 +11,7 @@ config X86 select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 select CORE_PARKING + select GENERIC_BUG_FRAME select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ diff --git a/xen/arch/x86/include/asm/bug.h b/xen/arch/x86/include/asm/bug.h index b7265bdfbe..31fc687669 100644 --- a/xen/arch/x86/include/asm/bug.h +++ b/xen/arch/x86/include/asm/bug.h @@ -1,92 +1,12 @@ #ifndef __X86_BUG_H__ #define __X86_BUG_H__ -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) - -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - #ifndef __ASSEMBLY__ -struct bug_frame { - signed int loc_disp:BUG_DISP_WIDTH; - unsigned int line_hi:BUG_LINE_HI_WIDTH; - signed int ptr_disp:BUG_DISP_WIDTH; - unsigned int line_lo:BUG_LINE_LO_WIDTH; - signed int msg_disp[]; -}; - -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) -#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) -#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ - ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ - BUG_LINE_LO_WIDTH) + \ - (((b)->line_lo + ((b)->ptr_disp < 0)) & \ - ((1 << BUG_LINE_LO_WIDTH) - 1))) -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) - -#define _ASM_BUGFRAME_TEXT(second_frame) \ - ".Lbug%=: ud2\n" \ - ".pushsection .bug_frames.%c[bf_type], \"a\", @progbits\n" \ - ".p2align 2\n" \ - ".Lfrm%=:\n" \ - ".long (.Lbug%= - .Lfrm%=) + %c[bf_line_hi]\n" \ - ".long (%c[bf_ptr] - .Lfrm%=) + %c[bf_line_lo]\n" \ - ".if " #second_frame "\n" \ - ".long 0, %c[bf_msg] - .Lfrm%=\n" \ - ".endif\n" \ - ".popsection\n" \ - -#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ - [bf_type] "i" (type), \ - [bf_ptr] "i" (ptr), \ - [bf_msg] "i" (msg), \ - [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ - << BUG_DISP_WIDTH), \ - [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) - -#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ - BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ - BUILD_BUG_ON((type) >= BUGFRAME_NR); \ - asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ - :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ -} while (0) - - -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ - unreachable(); \ -} while (0) - -/* - * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, - * and use a real static inline here to get proper type checking of fn(). - */ -#define run_in_exception_handler(fn) \ - do { \ - (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ - BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ - } while ( 0 ) - -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; +#define BUG_INSTR "ud2" +#define MODIFIER "c" -#else /* !__ASSEMBLY__ */ +#else /* * Construct a bugframe, suitable for using in assembly code. Should always @@ -128,6 +48,6 @@ extern const struct bug_frame __start_bug_frames[], #define ASSERT_FAILED(msg) \ BUG_FRAME BUGFRAME_assert, __LINE__, __FILE__, 1, msg -#endif /* !__ASSEMBLY__ */ +#endif /* __ASSEMBLY__ */ #endif /* __X86_BUG_H__ */ diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8..39f153a53b 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -24,6 +24,7 @@ * Gareth Hughes , May 2000 */ +#include #include #include #include @@ -1168,10 +1169,8 @@ void do_invalid_op(struct cpu_user_regs *regs) { const struct bug_frame *bug = NULL; u8 bug_insn[2]; - const char *prefix = "", *filename, *predicate, *eip = (char *)regs->rip; - unsigned long fixup; - int id = -1, lineno; - const struct virtual_region *region; + const char *eip = (char *)regs->rip; + unsigned int id; if ( likely(guest_mode(regs)) ) { @@ -1185,83 +1184,29 @@ void do_invalid_op(struct cpu_user_regs *regs) memcmp(bug_insn, "\xf\xb", sizeof(bug_insn)) ) goto die; - region = find_text_region(regs->rip); - if ( region ) - { - for ( id = 0; id < BUGFRAME_NR; id++ ) - { - const struct bug_frame *b; - unsigned int i; - - for ( i = 0, b = region->frame[id].bugs; - i < region->frame[id].n_bugs; b++, i++ ) - { - if ( bug_loc(b) == eip ) - { - bug = b; - goto found; - } - } - } - } - - found: + bug = find_bug_frame((unsigned long)eip, &id); if ( !bug ) goto die; + eip += sizeof(bug_insn); - if ( id == BUGFRAME_run_fn ) - { - void (*fn)(struct cpu_user_regs *) = bug_ptr(bug); - fn(regs); - fixup_exception_return(regs, (unsigned long)eip); - return; + switch ( id ) + { + case BUGFRAME_bug: + case BUGFRAME_assert: + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + return; } - /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ - filename = bug_ptr(bug); - if ( !is_kernel(filename) && !is_patch(filename) ) + if ( handle_bug_frame(regs, bug, id) ) goto die; - fixup = strlen(filename); - if ( fixup > 50 ) - { - filename += fixup - 47; - prefix = "..."; - } - lineno = bug_line(bug); switch ( id ) { + case BUGFRAME_run_fn: case BUGFRAME_warn: - printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); fixup_exception_return(regs, (unsigned long)eip); return; - - case BUGFRAME_bug: - printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) - return; - - show_execution_state(regs); - panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - case BUGFRAME_assert: - /* ASSERT: decode the predicate string pointer. */ - predicate = bug_msg(bug); - if ( !is_kernel(predicate) && !is_patch(predicate) ) - predicate = ""; - - printk("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) - return; - - show_execution_state(regs); - panic("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); } die: -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498235.769060 (Exim 4.92) (envelope-from ) id 1pU9Dw-0006Vv-H5; Mon, 20 Feb 2023 16:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498235.769060; Mon, 20 Feb 2023 16:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dw-0006Vo-Dk; Mon, 20 Feb 2023 16:41:08 +0000 Received: by outflank-mailman (input) for mailman id 498235; Mon, 20 Feb 2023 16:41:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dv-0006Vi-U0 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:41:07 +0000 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [2a00:1450:4864:20::22a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f4e76e2-b13d-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 17:41:06 +0100 (CET) Received: by mail-lj1-x22a.google.com with SMTP id f16so1709196ljq.10 for ; Mon, 20 Feb 2023 08:41:06 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id f8-20020a2e6a08000000b002934d555783sm65798ljc.6.2023.02.20.08.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:41:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f4e76e2-b13d-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IiEn/Rcm1MU1Cyz/bLiQ58eQG40sQBxNpXMLCDni3G4=; b=F9/K41sVEDsZPYf6mDjjHOcxm/puT6B1iAnP9m9qhoX2w17zGAIA/ueuSzAWDs9XbK T9GRlhCCo1r0CMzu74E632JDKkcqpDgX1R+LTplu6DGWUhm+51toYcOux7g6vdHiIozL +fLUIrBMlLTSwoxzA+WhAgcW1W31az00w7sLLkmqApCE4udLpYu86QRuhsEscn9YjR1v UFxPQq5V2JnZXgQOObYH86a+86FwON2u4DbWLnCptYvzISpZUP6RfT15+zoO/i9VP1ck BX85ygqaiDUIcTlyqsLCVv65g3AuvolFpISqzKl3L009DncaIeIE/G0GUp20bPXAD+fu XaEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IiEn/Rcm1MU1Cyz/bLiQ58eQG40sQBxNpXMLCDni3G4=; b=G1VeZ6iYv/7lIhshDy3yC1F3ZflCjUgHruSWv9eszoTIJgdLPonBcEXOqLRwdN1cEz fWPu15ClF7mROVOOm+ZCaI5aZWN+5lO6eXDupzN1sPOkRKi0H6nazBQSMM0iIvRKgvEe b0sfwzxAHCLSDKX0aliBCpPTnrO+KlIKZY6EJLIMZCkjyncOz2dauTRCyg+7Zg2155Np 7tflkdE/IPc57bTdyMUyDcoG0biiS5zm8jusYb41vXYqmCZyQPz03KdxHnoeE2qszaFO yJhiSrPr4cSygfgpZcY59/cAmmkiBo79auXMVGZsCcGGl4IyEXlQv25ibJXcDu6GujRQ 3Szw== X-Gm-Message-State: AO0yUKUjQUVur+8YD6RcZNxi7BJeyCuoDpVdqMOMExNDFEriUDoND5QV d+aeMM6s1UKdPQ5JXTvbeIuQO4n+94M= X-Google-Smtp-Source: AK7set+HzUhRBLgzeYobI5sPALQGFvy3w4VEajoAXRLuwNu1zqLtvzT1A22pd9yPsZTcPu9/deSU4A== X-Received: by 2002:a2e:a1c7:0:b0:293:6037:9850 with SMTP id c7-20020a2ea1c7000000b0029360379850mr722019ljm.51.1676911266074; Mon, 20 Feb 2023 08:41:06 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 0/4] introduce generic implementation of macros from bug.h Date: Mon, 20 Feb 2023 18:40:56 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures (especially x86 and RISCV have the same implementation), so it was created a new config CONFIG_GENERIC_BUG_FRAME which is used to introduce generic implementation of do_bug_frame() and move x86's to with the following changes: * Add inclusion of arch-specific header * Rename the guard and remove x86 specific changes * Wrap macros BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed/etc into #ifndef "BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed/etc" thereby each architecture can override the generic implementation of macros. * Add #if{n}def __ASSEMBLY__ ... #endif * Introduce BUG_FRAME_STRUCTURE define to be able to change the structure of bug frame * Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. * Make macros related to bug frame structure more generic. For ARM only common parts were removed from and re-use generic do_bug_frame() for ARM. RISC-V will be switched to use and in the future, it will use common the version of do_bug_frame() when xen/common will work for RISC-V. --- Changes in V2: * Update cover letter. * Switch to x86 implementation as generic as it is more compact ( at least from the point of view of bug frame structure). * Put [PATCH v1 4/4] xen: change to as second patch, update the patch to change all to among the whole project to not break compilation. * Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. * Change the macro bug_loc(b) to avoid the need for a cast: #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) * Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT * Make macros related to bug frame structure more generic. * Rename bug_file() in ARM implementation to bug_ptr() as generic do_bug_frame() uses bug_ptr(). * Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. * Rework do_invalid_op() in x86 ( re-use handle_bug_frame() and find_bug_frame() ) --- Oleksii Kurochko (4): xen: introduce CONFIG_GENERIC_BUG_FRAME xen: change to xen/arm: switch ARM to use generic implementation of bug.h xen/x86: switch x86 to use generic implemetation of bug.h xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/bug.h | 32 +----- xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/include/asm/traps.h | 2 - xen/arch/arm/traps.c | 79 ------------- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/bug.h | 88 +-------------- xen/arch/x86/traps.c | 81 +++----------- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/bug.c | 113 +++++++++++++++++++ xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/bug.h | 161 +++++++++++++++++++++++++++ xen/include/xen/lib.h | 2 +- 18 files changed, 306 insertions(+), 270 deletions(-) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498238.769093 (Exim 4.92) (envelope-from ) id 1pU9E3-0007Ig-DY; Mon, 20 Feb 2023 16:41:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498238.769093; Mon, 20 Feb 2023 16:41:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9E3-0007IT-9q; Mon, 20 Feb 2023 16:41:15 +0000 Received: by outflank-mailman (input) for mailman id 498238; Mon, 20 Feb 2023 16:41:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9E1-0006Vi-K6 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:41:13 +0000 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [2a00:1450:4864:20::234]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62e5efd1-b13d-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 17:41:12 +0100 (CET) Received: by mail-lj1-x234.google.com with SMTP id e9so1716249ljn.9 for ; Mon, 20 Feb 2023 08:41:12 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id f8-20020a2e6a08000000b002934d555783sm65798ljc.6.2023.02.20.08.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:41:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62e5efd1-b13d-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6vX3xq5gnben6ES0t2bFojgyY8cI1GFCJsQxOuCPDvE=; b=L3M4mVlMD3bSf6SRIPTWrEs+BMqXjJ2CSXtS9rAVuApr8G427G/XwkFRuftlgx0Cnu xnl4yBKbm/OcQUVcxWMhDUot7TJmQxeI2kovl8yDGUcB4Wo1h++PbdFcOVL3SAm4rvs8 TdWg/L4ih5sZVCmcHts75X3Yh22ICYuwbCZUk8X+EkQMTF+nhMTQPbpMGpuhYpOa4d4R oLJ3W9Vlerc8rwNpRvMoY2BnQ5DFXGfu3AILgRapAX+m4c/jOp9ILgXvMXgDF1ysBoRY WKXGdRtrLOlB2NRiX/2uK2Ngpy/AaHRKTWJX06FvVVmvgrl4ERZ9ODkTGso1oUVg+zaG +ThA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6vX3xq5gnben6ES0t2bFojgyY8cI1GFCJsQxOuCPDvE=; b=fn7rwbVptoce5WLuYYR4qjpwirEbo0eE2FDtC77Xj2NlikoSC85SBQKMGNbF0JJI5L gc9fAO7PGJLxnvIL8lVgprvUw/zKpedJJcg5ByBKnTwdLBALfkQprXuZmSgg7perRRRd XqmpFescF+xjxp7eya05PONIpysSJltmvkfisU9pbxSLzZamzyC8Zzg9qLSoE9R56BmR BsH9I+ab5+W5fybQ6uZp8JcwhOUz+FSFyLHqRdQz+mRBMTVuuz1pvxD7KPHbBP1yhLKZ xSe6ss1L7kNAUvzFSFVD4qsfJKJYJQsarcjLTa3QkRKPGTOvdcUE0uMpr9bP0+DKbayC SW+A== X-Gm-Message-State: AO0yUKV/FK3fH/1M3oK9FfLuF1TgdTqtNF1Q2cwg5rBAivqeTpl7DgW2 h+GTK0rGN4cOY+0a4es6s9cq3QWwQlY= X-Google-Smtp-Source: AK7set+9tUQdYT6JIbBO5d4ChaBSfxuBfihRwSW+P2DNFufmkvsKvtu3gKuL7h4Iz+JME9t0r4xi8A== X-Received: by 2002:a2e:8708:0:b0:294:7327:4a0d with SMTP id m8-20020a2e8708000000b0029473274a0dmr652623lji.20.1676911272396; Mon, 20 Feb 2023 08:41:12 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 3/4] xen/arm: switch ARM to use generic implementation of bug.h Date: Mon, 20 Feb 2023 18:40:59 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- Changes in V2: * Rename bug_file() in ARM implementation to bug_ptr() as generic do_bug_frame() uses bug_ptr(). * Remove generic parts from bug.h * Remove declaration of 'int do_bug_frame(...)' from as it was introduced in --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/bug.h | 32 +------------ xen/arch/arm/include/asm/traps.h | 2 - xen/arch/arm/traps.c | 79 -------------------------------- 4 files changed, 3 insertions(+), 111 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..aad6644a7b 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -12,6 +12,7 @@ config ARM_64 config ARM def_bool y + select GENERIC_BUG_FRAME select HAS_ALTERNATIVE select HAS_DEVICE_TREE select HAS_PASSTHROUGH diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h index f4088d0913..174cee477d 100644 --- a/xen/arch/arm/include/asm/bug.h +++ b/xen/arch/arm/include/asm/bug.h @@ -9,9 +9,7 @@ # error "unknown ARM variant" #endif -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) +#define BUG_FRAME_STRUCT struct bug_frame { signed int loc_disp; /* Relative address to the bug address */ @@ -21,18 +19,10 @@ struct bug_frame { uint32_t pad0:16; /* Padding for 8-bytes align */ }; -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) -#define bug_file(b) ((const void *)(b) + (b)->file_disp); +#define bug_ptr(b) ((const void *)(b) + (b)->file_disp) #define bug_line(b) ((b)->line) #define bug_msg(b) ((const char *)(b) + (b)->msg_disp) -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - /* Many versions of GCC doesn't support the asm %c parameter which would * be preferable to this unpleasantness. We use mergeable string * sections to avoid multiple copies of the string appearing in the @@ -77,24 +67,6 @@ struct bug_frame { ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); \ } while (0) -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") - -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ - unreachable(); \ -} while (0) - -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; - #endif /* __ARM_BUG_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h index 883dae368e..c6518008ec 100644 --- a/xen/arch/arm/include/asm/traps.h +++ b/xen/arch/arm/include/asm/traps.h @@ -69,8 +69,6 @@ void do_cp(struct cpu_user_regs *regs, const union hsr hsr); void do_trap_smc(struct cpu_user_regs *regs, const union hsr hsr); void do_trap_hvc_smccc(struct cpu_user_regs *regs); -int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc); - void noreturn do_unexpected_trap(const char *msg, const struct cpu_user_regs *regs); void do_trap_hyp_sync(struct cpu_user_regs *regs); diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd..751c3277aa 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1197,85 +1197,6 @@ void do_unexpected_trap(const char *msg, const struct cpu_user_regs *regs) panic("CPU%d: Unexpected Trap: %s\n", smp_processor_id(), msg); } -int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) -{ - const struct bug_frame *bug = NULL; - const char *prefix = "", *filename, *predicate; - unsigned long fixup; - int id = -1, lineno; - const struct virtual_region *region; - - region = find_text_region(pc); - if ( region ) - { - for ( id = 0; id < BUGFRAME_NR; id++ ) - { - const struct bug_frame *b; - unsigned int i; - - for ( i = 0, b = region->frame[id].bugs; - i < region->frame[id].n_bugs; b++, i++ ) - { - if ( ((vaddr_t)bug_loc(b)) == pc ) - { - bug = b; - goto found; - } - } - } - } - found: - if ( !bug ) - return -ENOENT; - - if ( id == BUGFRAME_run_fn ) - { - void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; - - fn(regs); - return 0; - } - - /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ - filename = bug_file(bug); - if ( !is_kernel(filename) ) - return -EINVAL; - fixup = strlen(filename); - if ( fixup > 50 ) - { - filename += fixup - 47; - prefix = "..."; - } - lineno = bug_line(bug); - - switch ( id ) - { - case BUGFRAME_warn: - printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - return 0; - - case BUGFRAME_bug: - printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - case BUGFRAME_assert: - /* ASSERT: decode the predicate string pointer. */ - predicate = bug_msg(bug); - if ( !is_kernel(predicate) ) - predicate = ""; - - printk("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - show_execution_state(regs); - panic("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - } - - return -EINVAL; -} - #ifdef CONFIG_ARM_64 static void do_trap_brk(struct cpu_user_regs *regs, const union hsr hsr) { -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498236.769071 (Exim 4.92) (envelope-from ) id 1pU9Dy-0006l3-Ph; Mon, 20 Feb 2023 16:41:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498236.769071; Mon, 20 Feb 2023 16:41:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dy-0006kw-Lp; Mon, 20 Feb 2023 16:41:10 +0000 Received: by outflank-mailman (input) for mailman id 498236; Mon, 20 Feb 2023 16:41:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dx-0006Vi-20 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:41:09 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60147f3f-b13d-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 17:41:08 +0100 (CET) Received: by mail-lj1-x236.google.com with SMTP id y44so1882976ljq.7 for ; Mon, 20 Feb 2023 08:41:08 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id f8-20020a2e6a08000000b002934d555783sm65798ljc.6.2023.02.20.08.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:41:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60147f3f-b13d-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QRAP5KqQXYqAUnB17tHsxH6vdQ6lhjVqsW3lN6eZV4Y=; b=SYhVFq1KNWKNHzP99mNP54m4dLKi/BDsJP7iTrd+If6fwXFSvjeAGA1WSTw2cVXyXl pmuG9MGMnVXv+AaINVfCvOelfOf80k+gQo9rTy8ZZT7DZoeIRSanzTnoU+nwUQu6aScH DsuVSmq2YfmMXaM2/3V0H57Vg763TzoqJh7Ev5IIfu8zxbzDHentDVODxBmeOWp/7I6K +Eiw7VetcdAt4sY7L1AMqTMgG/L0n1Itm6puuiXcqZWAlR+i2zy0cbJkzlnDfJOz45+K ECQiENnnAJPpVMB98msRgRX/50b+em4jA7jiDK66Xa+I3mP6RmJkitj9JkwQLFfq/Ew+ gy9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QRAP5KqQXYqAUnB17tHsxH6vdQ6lhjVqsW3lN6eZV4Y=; b=tumk9muWxEyMEeVniu/3M3I3nAjpNIG59aEdGdEoFk2wGkZJuxa64lnEbjhJ3sISy7 OnhreChGSsNjLSukCpFe2rC6GCM1yuw4zYNafFvmfamLrO0BNmKwTXsPR4xpeSZYSCtM nADaY+Wxbs0v0q2NoYCOKB9pRRR2OP6qFE3TsdX+sJVHdHqq7DYQpdA5qU/xiu1wuEGK uCKeIAjeQ+wBGjtJUC3lkNdgovXprFuz970Gs3Yj3ByMkU5eXi2GDWMYLJ1W7zZrO4Wi SNQeLqpT6mwpPOWfZC9x54Fd2a7+/So7yTRgm/5AeMcV2EuYlcTazSXqnr/Tgz8rKxcl KJIw== X-Gm-Message-State: AO0yUKUVwCdRON96L/H7UQoUHDF7c4u+e8WSArYwG9Jr6stneEyLCoAp 2ftprHNRbYm1EnFNes0SgblMY+rk9Cc= X-Google-Smtp-Source: AK7set9SWDvh2MqHKwEbdHQ91ctqf9v82DKc6GEWskqkDFUTB7n/ByGNtMv3bd0dVnQW0vANDstqAw== X-Received: by 2002:a2e:9599:0:b0:290:6500:40f0 with SMTP id w25-20020a2e9599000000b00290650040f0mr696117ljh.42.1676911267595; Mon, 20 Feb 2023 08:41:07 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Julien Grall , Wei Liu Subject: [PATCH v2 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Date: Mon, 20 Feb 2023 18:40:57 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures, so it was decided to create a new config CONFIG_GENERIC_BUG_FRAME. The version of from x86 was taken as the base version. The patch introduces the following stuff: * common bug.h header * generic implementation of do_bug_frame() * new config CONFIG_GENERIC_BUG_FRAME Signed-off-by: Oleksii Kurochko --- Changes in V2: - Switch to x86 implementation as generic as it is more compact ( at least from the point of view of bug frame structure ). - Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. - Change the macro bug_loc(b) to avoid the need for a cast: #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) - Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT - Make macros related to bug frame structure more generic. - Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. - Rework do_bug_frame() and introduce find_bug_frame() and handle_bug_frame() functions to make it reusable by x86. - code style fixes --- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/bug.c | 113 +++++++++++++++++++++++++++++ xen/include/xen/bug.h | 161 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 278 insertions(+) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8..b226323537 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL config ARCH_MAP_DOMAIN_PAGE bool +config GENERIC_BUG_FRAME + bool + config HAS_ALTERNATIVE bool diff --git a/xen/common/Makefile b/xen/common/Makefile index bbd75b4be6..46049eac35 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_ARGO) += argo.o obj-y += bitmap.o +obj-$(CONFIG_GENERIC_BUG_FRAME) += bug.o obj-$(CONFIG_HYPFS_CONFIG) += config_data.o obj-$(CONFIG_CORE_PARKING) += core_parking.o obj-y += cpu.o diff --git a/xen/common/bug.c b/xen/common/bug.c new file mode 100644 index 0000000000..5eab3ebb53 --- /dev/null +++ b/xen/common/bug.c @@ -0,0 +1,113 @@ +#include +#include +#include +#include +#include +#include +#include + +#include + +const struct bug_frame* find_bug_frame(unsigned long pc, unsigned int *id) +{ + const struct bug_frame *bug = NULL; + const struct virtual_region *region; + + region = find_text_region(pc); + if ( region ) + { + for ( *id = 0; *id < BUGFRAME_NR; (*id)++ ) + { + const struct bug_frame *b; + unsigned int i; + + for ( i = 0, b = region->frame[*id].bugs; + i < region->frame[*id].n_bugs; b++, i++ ) + { + if ( bug_loc(b) == pc ) + { + bug = b; + goto found; + } + } + } + } + + found: + return bug; +} + +int handle_bug_frame(const struct cpu_user_regs *regs, + const struct bug_frame *bug, + unsigned int id) +{ + const char *prefix = "", *filename, *predicate; + unsigned long fixup; + unsigned int lineno; + + if ( id == BUGFRAME_run_fn ) + { +#ifdef ARM + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; +#else + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); +#endif + + fn(regs); + return 0; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_ptr(bug); + if ( !is_kernel(filename) && !is_patch(filename) ) + return -EINVAL; + fixup = strlen(filename); + if ( fixup > 50 ) + { + filename += fixup - 47; + prefix = "..."; + } + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); + show_execution_state(regs); + return 0; + + case BUGFRAME_bug: + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + + show_execution_state(regs); + panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + if ( !is_kernel(predicate) ) + predicate = ""; + + printk("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + + show_execution_state(regs); + panic("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + } + + return -EINVAL; +} + +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc) +{ + const struct bug_frame *bug = NULL; + unsigned int id; + + bug = find_bug_frame(pc, &id); + if (!bug) + return -ENOENT; + + return handle_bug_frame(regs, bug, id); +} + diff --git a/xen/include/xen/bug.h b/xen/include/xen/bug.h new file mode 100644 index 0000000000..4aedebeb18 --- /dev/null +++ b/xen/include/xen/bug.h @@ -0,0 +1,161 @@ +#ifndef __XEN_BUG_H__ +#define __XEN_BUG_H__ + +#define BUG_DISP_WIDTH 24 +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) + +#define BUGFRAME_run_fn 0 +#define BUGFRAME_warn 1 +#define BUGFRAME_bug 2 +#define BUGFRAME_assert 3 + +#define BUGFRAME_NR 4 + +#ifndef __ASSEMBLY__ + +#include +#include +#include +#include + +#include + +#ifndef BUG_FRAME_STRUCT + +struct bug_frame { + signed int loc_disp:BUG_DISP_WIDTH; + unsigned int line_hi:BUG_LINE_HI_WIDTH; + signed int ptr_disp:BUG_DISP_WIDTH; + unsigned int line_lo:BUG_LINE_LO_WIDTH; + signed int msg_disp[]; +}; + +#endif /* BUG_FRAME_STRUCT */ + +#ifndef bug_loc +#define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) +#endif /* bug_loc */ + +#ifndef bug_ptr +#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) +#endif /* bug_ptr */ + +#ifndef bug_line +#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ + ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ + BUG_LINE_LO_WIDTH) + \ + (((b)->line_lo + ((b)->ptr_disp < 0)) & \ + ((1 << BUG_LINE_LO_WIDTH) - 1))) +#endif /* bug_line */ + +#ifndef bug_msg +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) +#endif /* bug_msg */ + +#ifndef _ASM_BUGFRAME_TEXT + +#define _ASM_BUGFRAME_TEXT(second_frame) \ + ".Lbug%=:"BUG_INSTR"\n" \ + ".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", @progbits\n" \ + ".p2align 2\n" \ + ".Lfrm%=:\n" \ + ".long (.Lbug%= - .Lfrm%=) + %"MODIFIER"[bf_line_hi]\n" \ + ".long (%"MODIFIER"[bf_ptr] - .Lfrm%=) + %"MODIFIER"[bf_line_lo]\n" \ + ".if " #second_frame "\n" \ + ".long 0, %"MODIFIER"[bf_msg] - .Lfrm%=\n" \ + ".endif\n" \ + ".popsection\n" + +#endif /* _ASM_BUGFRAME_TEXT */ + +#ifndef _ASM_BUGFRAME_INFO + +#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ + [bf_type] "i" (type), \ + [bf_ptr] "i" (ptr), \ + [bf_msg] "i" (msg), \ + [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ + << BUG_DISP_WIDTH), \ + [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) + +#endif /* _ASM_BUGFRAME_INFO */ + +#ifndef BUG_FRAME + +#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ + BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ + asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ + :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ +} while (0) + +#endif + +#ifndef run_in_exception_handler + +/* + * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, + * and use a real static inline here to get proper type checking of fn(). + */ +#define run_in_exception_handler(fn) \ + do { \ + (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ + BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ + } while ( 0 ) + +#endif /* run_in_exception_handler */ + +#ifndef WARN +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) +#endif /* WARN */ + +#ifndef BUG +#define BUG() do { \ + BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ + unreachable(); \ +} while (0) +#endif + +#ifndef assert_failed +#define assert_failed(msg) do { \ + BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ + unreachable(); \ +} while (0) +#endif + +#ifdef CONFIG_GENERIC_BUG_FRAME + +struct cpu_user_regs; + +const struct bug_frame* find_bug_frame(unsigned long pc, unsigned int *id); + +int handle_bug_frame(const struct cpu_user_regs *regs, + const struct bug_frame *bug, + unsigned int id); + +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc); + +#endif /* CONFIG_GENERIC_BUG_FRAME */ + +extern const struct bug_frame __start_bug_frames[], + __stop_bug_frames_0[], + __stop_bug_frames_1[], + __stop_bug_frames_2[], + __stop_bug_frames_3[]; + +#else /* !__ASSEMBLY__ */ + +#include + +#endif /* __ASSEMBLY__ */ + +#endif /* __XEN_BUG_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:41:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498237.769082 (Exim 4.92) (envelope-from ) id 1pU9E0-00070M-2i; Mon, 20 Feb 2023 16:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498237.769082; Mon, 20 Feb 2023 16:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dz-00070F-UX; Mon, 20 Feb 2023 16:41:11 +0000 Received: by outflank-mailman (input) for mailman id 498237; Mon, 20 Feb 2023 16:41:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9Dy-0006Vi-F1 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:41:10 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 610e7f9e-b13d-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 17:41:09 +0100 (CET) Received: by mail-lj1-x235.google.com with SMTP id l8so1771380ljq.3 for ; Mon, 20 Feb 2023 08:41:09 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id f8-20020a2e6a08000000b002934d555783sm65798ljc.6.2023.02.20.08.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:41:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 610e7f9e-b13d-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c1MpbYkthmfF/j5tbT9Ls4HfPFbZX5FNFb/Z6pTJAxg=; b=UiIfZFboHwH67hlEPkfcEEE/34XyvkKLZ3y8Q8ltELBBsTV2cs9LT1uyKUQU3ovcXZ 8shObelEr+mzCYJipWEmbrz7VcsdwZvJjjl2mgTRAjHrcGrLM4Fxw48XGarvD7jBhS+d 7V2Hb4o5oHHiSR+97ncsNbwkpfDL9Y+94sFMuUzqL06Dtc1/WuXyvqSsMrYTlHOGMWlx a4jwBtMy6nnMYIjGtrYDgR8/4XVCRIdBaiMIuz8UbV0sgtQo5qbZrNG1JHV34jQFpATp b+mZKbJJw68kQhyBAtbSBrIgGy8FKizpzfUBiCKgIAowhCAAZv8cMQpmOY7GWluqz3s6 6D9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c1MpbYkthmfF/j5tbT9Ls4HfPFbZX5FNFb/Z6pTJAxg=; b=5xKKEqDKHOT4t2uPcqMStuA9UcgvSgf4TT1/eReTSkC5A2n691oK59sOgpnQgWu0UY R8jrfNVkvyUFcbfgpKwoxC9bbxPDe3bk3zl1XYRBUNet9yFTFfF1Pvtfvp86LsLpQoh0 QK7UA9je45Jyd0AAlQXSi+Uki1GA5zz7v4oPcDy8hEGL2KWVV2/zPyYFKiCuLVYkHrTP VsvPf9+9GL0/B/jWcWBjPbmmzxFxtEeB6WiK/cQjKYMP+CeMjcHKYysW/zzoUAKCJLqS hGmQTI5CFLTTWoy1+qwnxYHMIPOTAoJaqOi1JrzAxlNT2nhaaLSThpDnkn+l4uKLbU4c 7XVg== X-Gm-Message-State: AO0yUKWsjCe7XGgevRr5e12BZGtQl9UBaLZJtX2SBLugLjhQHPGSB/r7 VVf0bA9Fr3wilppcC/9CswNjhvfXPsw= X-Google-Smtp-Source: AK7set89y+om3PEExn5kE/pMZmu/hwZFPshETVGlfRftqChwkTdlUAQ7Jc7yBHswtwsGxg9jGWk1sQ== X-Received: by 2002:a05:651c:2128:b0:293:fea:c912 with SMTP id a40-20020a05651c212800b002930feac912mr822844ljq.13.1676911269268; Mon, 20 Feb 2023 08:41:09 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 2/4] xen: change to Date: Mon, 20 Feb 2023 18:40:58 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the generic version of bug.h stuff was introduced use instead of unnecessary Signed-off-by: Oleksii Kurochko --- Changes in V2: * Put [PATCH v1 4/4] xen: change to as second patch, update the patch to change all to among the whole project to not break build. * Update the commit message. --- xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/lib.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/include/asm/div64.h b/xen/arch/arm/include/asm/div64.h index 1cd58bc51a..fc667a80f9 100644 --- a/xen/arch/arm/include/asm/div64.h +++ b/xen/arch/arm/include/asm/div64.h @@ -74,7 +74,7 @@ #elif __GNUC__ >= 4 -#include +#include /* * If the divisor happens to be constant, we determine the appropriate diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c index 1a99d3a8b4..c90e88fddb 100644 --- a/xen/arch/arm/vgic/vgic-v2.c +++ b/xen/arch/arm/vgic/vgic-v2.c @@ -16,8 +16,8 @@ */ #include -#include #include +#include #include #include diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index f0f2ea5021..b9463a5f27 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -15,9 +15,9 @@ * along with this program. If not, see . */ +#include #include #include -#include #include #include diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index c27cbb2304..18ff2a443b 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -27,6 +27,7 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include #include #include #include @@ -35,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/include/asm/asm_defns.h b/xen/arch/x86/include/asm/asm_defns.h index d9431180cf..a8526cf36c 100644 --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -6,7 +6,7 @@ /* NB. Auto-generated from arch/.../asm-offsets.c */ #include #endif -#include +#include #include #include #include diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index a94520ee57..354f78580b 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -26,6 +26,7 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include #include #include #include @@ -39,7 +40,6 @@ #include #include #include -#include #include #include diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 05ee1e18af..e914ccade0 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -24,12 +24,12 @@ #ifndef __ASSEMBLY__ +#include #include #include #include #include #include -#include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) #define WARN_ON(p) ({ \ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 16:52:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 16:52:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498267.769115 (Exim 4.92) (envelope-from ) id 1pU9OJ-0002Da-Q0; Mon, 20 Feb 2023 16:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498267.769115; Mon, 20 Feb 2023 16:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9OJ-0002DT-NI; Mon, 20 Feb 2023 16:51:51 +0000 Received: by outflank-mailman (input) for mailman id 498267; Mon, 20 Feb 2023 16:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9OI-0002DN-5F for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 16:51:50 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd6bbf13-b13e-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 17:51:48 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id c5so2574859wrr.5 for ; Mon, 20 Feb 2023 08:51:48 -0800 (PST) Received: from horizon ([2a01:e0a:257:8c60:48e5:bfa:d652:b8ef]) by smtp.gmail.com with ESMTPSA id q6-20020a05600c46c600b003dc47d458cdsm1698014wmo.15.2023.02.20.08.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:51:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd6bbf13-b13e-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZrblE+gpgxc/XJD6vkWMSZ2+dCIk37H5XuHx35NlQuo=; b=NHKUONy9L0/a8/aCGe6KxiRezPMTaijYU3L6RI1BApcuDE8rOBloTqZKu5wM0s5dID GOarUJXhLcd1y7bzNCYb98L8y/6245+gzmjgo9Ws1XadOA94ncA8elkD/CUVkoVcCOYQ cxEfhiunxgls4wOx0nkc5bxXaJYZuxiZ1kZeDDzIiKoDrK5xNInQqQg/k1OWLjCzzZ0X BKgEhd0ToEmR9kaJEDQH4NmTClmynXXJu+5LyiSX9RiMIKQmWRz7gCJGo0pJYijiAZIy ktpdMYsO6KZihufVgT3NkGNic36Bht3JU/W4HlWsflN9RMjYBfrmgvSlTkIiob3HXNoP HrAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZrblE+gpgxc/XJD6vkWMSZ2+dCIk37H5XuHx35NlQuo=; b=0yFlTfZO9gsTR5Xbvn/zG4UjSEjG2jn3lZHtuXaWi5TJYag9CzALJ6EQZYqoiwpwl+ mawV21Uq0KjsVC7psfdN7FOYVRhDPT8/TqJZHEWYTpLqoIjxfTqNMwpiRwgEky5vbmne +Jwz0m3Aae4FjwNN4gXHCa38KIEeJzmv2PV3rehZfg9xxd35RXmgJgvdhcL4FcedOGhr SGCDntAP6FKhX7IuisMtuR3ujOb9NsftjeVr4oIsdkAvwb1VKeArf/9DW8/VBEE9A+H0 KgBvs4HGgX/ZUkVmAvwgPMXSKk3fOxON1RRincmqzlKR2VMv4dJbp2wEbNaoMLsiWaAj ldUA== X-Gm-Message-State: AO0yUKXvWkPw0fr7oakOEUGxI3A18QojtEP6pdVimypUtaKI5QO70+fZ tJmOECMPN2nZF9MGYA3ru5Q= X-Google-Smtp-Source: AK7set+dG3Zp+Fen4SBKzG9hBUHfRNF/Iov4bQRUjqvfVZ+HZs4927WZz/xh45tbyiCSyeVy+vYE7Q== X-Received: by 2002:a5d:540d:0:b0:2c5:54a7:363c with SMTP id g13-20020a5d540d000000b002c554a7363cmr262219wrv.23.1676911907351; Mon, 20 Feb 2023 08:51:47 -0800 (PST) Date: Mon, 20 Feb 2023 17:51:44 +0100 From: Matias Ezequiel Vara Larsen To: Jan Beulich Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Message-ID: <20230220165144.GA2653336@horizon> References: <20230216150734.GB2137216@horizon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 16, 2023 at 04:15:29PM +0100, Jan Beulich wrote: > On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: > > On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: > >> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: > >>> @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( > >>> } > >>> > >>> v->runstate.state = new_state; > >>> + > >>> + vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va; > >>> + if ( vcpustats_va ) > >>> + { > >>> + vcpustats_va->vcpu_info[v->vcpu_id].version = > >>> + version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version); > >>> + smp_wmb(); > >>> + memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time, > >>> + &v->runstate.time[RUNSTATE_running], > >>> + sizeof(v->runstate.time[RUNSTATE_running])); > >>> + smp_wmb(); > >>> + vcpustats_va->vcpu_info[v->vcpu_id].version = > >>> + version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version); > >>> + } > >> > >> A further aspect to consider here is cache line ping-pong. I think the > >> per-vCPU elements of the array want to be big enough to not share a > >> cache line. The interface being generic this presents some challenge > >> in determining what the supposed size is to be. However, taking into > >> account the extensibility question, maybe the route to take is to > >> simply settle on a power-of-2 value somewhere between x86'es and Arm's > >> cache line sizes and the pretty common page size of 4k, e.g. 512 bytes > >> or 1k? > >> > > > > I do not now how to address this. I was thinking to align each vcpu_stats > > instance to a multiple of the cache-line. I would pick up the first multiple > > that is bigger to the size of the vcpu_stats structure. For example, currently > > the structure is 16 bytes so I would align each instance in a frame to 64 > > bytes. Would it make sense? > > Well, 64 may be an option, but I gave higher numbers for a reason. One thing > I don't know is what common cache line sizes are on Arm or e.g. RISC-V. Thanks. I found that structures that require cache-aligment are defined with "__cacheline_aligned" that uses L1_CACHE_BYTES. For example, in x86, this aligns to 128 bytes. What is the reason to use a higher value like 512 bytes or 1k?. Thanks, Matias. From xen-devel-bounces@lists.xenproject.org Mon Feb 20 17:17:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 17:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498286.769130 (Exim 4.92) (envelope-from ) id 1pU9ma-0005V0-TK; Mon, 20 Feb 2023 17:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498286.769130; Mon, 20 Feb 2023 17:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9ma-0005Ut-Pt; Mon, 20 Feb 2023 17:16:56 +0000 Received: by outflank-mailman (input) for mailman id 498286; Mon, 20 Feb 2023 17:16:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9mY-0005Un-NT for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 17:16:54 +0000 Received: from poodle.tulip.relay.mailchannels.net (poodle.tulip.relay.mailchannels.net [23.83.218.249]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c5ba0b6-b142-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 18:16:52 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A1C2F3C0CE3 for ; Mon, 20 Feb 2023 17:16:48 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 415CB3C0E1F for ; Mon, 20 Feb 2023 17:16:48 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.179.67 (trex/6.7.1); Mon, 20 Feb 2023 17:16:48 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PL8Gl1rTqz1NZ for ; Mon, 20 Feb 2023 09:16:46 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0067 by kmjvbox (DragonFly Mail Agent v0.12); Mon, 20 Feb 2023 09:16:43 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c5ba0b6-b142-11ed-933d-83870f6b2ba8 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676913408; a=rsa-sha256; cv=none; b=l492S/ueqfNkE2hF1aShCsu/8ItsPVcUL6qlv4ymyreqGZkXfEIDad8Ih6qK2DFGD6Tw7r MApxXTfOhA9o1BKZFEnuj9ePu0RvCD/0jVGYgRKLBVfhSCbBtdgrlNPqNgm5nBB+3azy8E 1mnwHa+0XX/2VDWsx4V/d9ZGT6y+LYWF6Ha8RHA/KTd31ogjjxy6g4ujRCVRWQg8YGc53y XZ/FxGWKwAJq5AdqTi2syyzPkhkcCiuOSNQ9EoVKhane3/gPSmfbztMBWdvbsZGLoe7XbV D+r+QRf5+U6H8N+bp+r9XcrzVnBp5MxdZblrKlYF5GcvgCfL8xbgbhse95jCdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676913408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=fUu5dy7aqGfj6EXLkWJV8gzrUOJ39VlTABuiXGf/DAY=; b=dWv8T6EfGWnWfCcAqPLtxresHVmUaAPkwYmnChDuuSVqErJatinWWUOQF/yJts2O3nEF70 37o9cn0f2OT+Cc5zD/ismISXQ8R4rKUUZVRUfL0BlCDvFLv4vmaU3UBikYYd/lWRNDxQ46 9UACjHt8ZJGVCUa6UOx7PkF/M5rZLFEnvf9DpwaJ/OHcGGaf/8VeIxlBAavkjXT2Sh7COk wIX8lKZc1aosjm+8RXakqatGozKZrjfy8Z3BK89oV157AZm42OxsIXC5fK2o2ekt8Xybo+ S4sDp/9sG2N/e6CJNE3xQShOha/lThI9+5PkydsJvanCEvFHI+JJrea8fokOMA== ARC-Authentication-Results: i=1; rspamd-9788b98bc-l6ctm; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Bored-Irritate: 6331909a11482b5b_1676913408494_3548150860 X-MC-Loop-Signature: 1676913408494:2375623452 X-MC-Ingress-Time: 1676913408493 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1676913407; bh=fUu5dy7aqGfj6EXLkWJV8gzrUOJ39VlTABuiXGf/DAY=; h=Date:From:To:Cc:Subject:Content-Type; b=oizMo8h8X0zgNVSz/6yhg8Unuwn+LyOASs/GaiBa5lJZoI4RqD5eNKfWf1+Vy+OX0 yqFQoihSD0/b2C8QrM1J5naHejiLxMUA6Y10JbaEfZaqRunqILMW2/yVJoUWFMwHVl XovQOnLWQ6Drv/037PMZkbB6BymxPGFCm/tc4KRs= Date: Mon, 20 Feb 2023 09:16:43 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next 0/2] x86/xen TSC related cleanups Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Enclosed please find a pair of patches that perform some additional cleanup that was suggested by Boris and Jan. Specifically: this resync's arch/x86/include/asm/xen/cpuid.h from its upstream source in the Xen tree, and then uses one of the new #define-s to replace a constant in x86/xen/time.c that was previously only numerically defined. Krister Johansen (2): xen: update arch/x86/include/asm/xen/cpuid.h x86/xen/time: cleanup xen_tsc_safe_clocksource arch/x86/include/asm/xen/cpuid.h | 22 ++++++++++++++++++---- arch/x86/xen/time.c | 4 ++-- 2 files changed, 20 insertions(+), 6 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 17:17:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 17:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498287.769141 (Exim 4.92) (envelope-from ) id 1pU9mi-0005lm-5u; Mon, 20 Feb 2023 17:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498287.769141; Mon, 20 Feb 2023 17:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9mi-0005lf-29; Mon, 20 Feb 2023 17:17:04 +0000 Received: by outflank-mailman (input) for mailman id 498287; Mon, 20 Feb 2023 17:17:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9mg-0005Un-UY for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 17:17:03 +0000 Received: from coral.elm.relay.mailchannels.net (coral.elm.relay.mailchannels.net [23.83.212.39]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62d3ef3b-b142-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 18:17:02 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 72C958C184C for ; Mon, 20 Feb 2023 17:16:59 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 150DA8C149F for ; Mon, 20 Feb 2023 17:16:59 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.74.37 (trex/6.7.1); Mon, 20 Feb 2023 17:16:59 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PL8Gx6vMMz19W for ; Mon, 20 Feb 2023 09:16:57 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0067 by kmjvbox (DragonFly Mail Agent v0.12); Mon, 20 Feb 2023 09:16:54 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62d3ef3b-b142-11ed-933d-83870f6b2ba8 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676913419; a=rsa-sha256; cv=none; b=LHjYdKeo+GvxjBb2CAt5RzY3XHvdRjz0Ri//UuR/B0W8j7kdCpsCc+cSjrp0qIAiQW7mDh /rwarpT6ifIm0g7TBF0rDUSSN3kVhaWEO6rLersjz69TKQ/XtrMNI2X/hN860J/obOlKhB S6sfwOnuBvGvAJeiQqm+6iwAsdi9cViW52UiKRRGceLvoPpPhHrE1RfzBFdtLTmzy4MOPc tpPHmCvUEdbP5XN6uwZVPnXrGwYxV+NYvLrr3D5nKq3AIofhOMjnXCm2GXzTG3C8B16F2v WSKCxPvmGUNJKtRxX9/SmO0Wz+Z1xTV+T522qmbWuWpfGe8raon4zOYT4MM75A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676913419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPLOaJx1XC+xepUu7FtXLYzyt2YPI1cX/q7Jp4OSr1s=; b=rdUXetuzMNqmuK9nBl2gfZjCvEfUnaT6XMq9GfLIPCOTE95p5b97DmEiLL9Dzp6KwSM0d/ 0uGLdwtW6dKohn+0Escr26SVcMiu+Kc5tkKiygZhqifUekV8Dinej4c/Y7SCxHfCYT0MNc QkDrxoIYxLsBujDRsoFiiAlw7wHwX27TAI6TQvoWkonO3hXGNRPGS06+zqkr4dkKuTLTmX 114eTwCxIktNTb3WEAfB1V0rfQDjozUr2Pd9UiN/5b807nr9Ls+CypIoxxaf/wC+ObSnis O3VBtwzxZTlCBSX9P/BsBZNU1jyyubBijXPCz0YNylTkD0mJHQceh3p+ZgJdDA== ARC-Authentication-Results: i=1; rspamd-9788b98bc-qjg4h; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Bottle-Quick: 1a8a282a7279178a_1676913419317_2330254153 X-MC-Loop-Signature: 1676913419317:2680030077 X-MC-Ingress-Time: 1676913419317 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1676913418; bh=jPLOaJx1XC+xepUu7FtXLYzyt2YPI1cX/q7Jp4OSr1s=; h=Date:From:To:Cc:Subject:Content-Type; b=rBn5t9nd39DD3PrheNBrV//PfuVBGriKg54u+who5tQJupiTqQmzFpE9n1TFxGgTU xH4H3u37nLpo1Hus0ou6M6JSe53Ak3WZWHlEXNd1YjZ/vUGRYBJlA0SvOslsHhzLUp DozJZqCz3LnFjfiXoMPUBiMBqMd/9C7lTh+5cNiA= Date: Mon, 20 Feb 2023 09:16:54 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next 1/2] xen: update arch/x86/include/asm/xen/cpuid.h Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Update arch/x86/include/asm/xen/cpuid.h from the Xen tree to get newest definitions. This picks up some TSC mode definitions and comment formatting changes. Signed-off-by: Krister Johansen --- arch/x86/include/asm/xen/cpuid.h | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 6daa9b0c8d11..a3c29b1496c8 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -89,11 +89,21 @@ * Sub-leaf 2: EAX: host tsc frequency in kHz */ +#define XEN_CPUID_TSC_EMULATED (1u << 0) +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1) +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2) + +#define XEN_CPUID_TSC_MODE_DEFAULT (0) +#define XEN_CPUID_TSC_MODE_ALWAYS_EMULATE (1u) +#define XEN_CPUID_TSC_MODE_NEVER_EMULATE (2u) +#define XEN_CPUID_TSC_MODE_PVRDTSCP (3u) + /* * Leaf 5 (0x40000x04) * HVM-specific features * Sub-leaf 0: EAX: Features * Sub-leaf 0: EBX: vcpu id (iff EAX has XEN_HVM_CPUID_VCPU_ID_PRESENT flag) + * Sub-leaf 0: ECX: domain id (iff EAX has XEN_HVM_CPUID_DOMID_PRESENT flag) */ #define XEN_HVM_CPUID_APIC_ACCESS_VIRT (1u << 0) /* Virtualized APIC registers */ #define XEN_HVM_CPUID_X2APIC_VIRT (1u << 1) /* Virtualized x2APIC accesses */ @@ -102,12 +112,16 @@ #define XEN_HVM_CPUID_VCPU_ID_PRESENT (1u << 3) /* vcpu id is present in EBX */ #define XEN_HVM_CPUID_DOMID_PRESENT (1u << 4) /* domid is present in ECX */ /* - * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be - * used to store high bits for the Destination ID. This expands the Destination - * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. + * With interrupt format set to 0 (non-remappable) bits 55:49 from the + * IO-APIC RTE and bits 11:5 from the MSI address can be used to store + * high bits for the Destination ID. This expands the Destination ID + * field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) -/* Per-vCPU event channel upcalls */ +/* + * Per-vCPU event channel upcalls work correctly with physical IRQs + * bound to event channels. + */ #define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 17:17:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 17:17:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498292.769152 (Exim 4.92) (envelope-from ) id 1pU9mt-0006BA-De; Mon, 20 Feb 2023 17:17:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498292.769152; Mon, 20 Feb 2023 17:17:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9mt-0006B1-Af; Mon, 20 Feb 2023 17:17:15 +0000 Received: by outflank-mailman (input) for mailman id 498292; Mon, 20 Feb 2023 17:17:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pU9ms-00064N-7y for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 17:17:14 +0000 Received: from gold.apple.relay.mailchannels.net (gold.apple.relay.mailchannels.net [23.83.208.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68b9cdcc-b142-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 18:17:11 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id ABE0688175E for ; Mon, 20 Feb 2023 17:17:09 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4CDFB88184A for ; Mon, 20 Feb 2023 17:17:09 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.227.140 (trex/6.7.1); Mon, 20 Feb 2023 17:17:09 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PL8H76xmYz14y for ; Mon, 20 Feb 2023 09:17:07 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0067 by kmjvbox (DragonFly Mail Agent v0.12); Mon, 20 Feb 2023 09:17:04 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68b9cdcc-b142-11ed-93b5-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676913429; a=rsa-sha256; cv=none; b=kvnksgyh6M8oen6dXHa6hqwrt0jYmY79LMBMaoI1zA39VHsu55q9+GDTX/8PpDQO41/syg tq3Mwm4LnvT/ruGjzdDBmZKeIO3Pr9biW2Z2VyL+c0fVlyTwS4cLuIfernBesdjMZ1VfnY UJGK/4Irz+IBqL+0UOQCt3Q9Lc8YEJ9itq4Xh6+aqQy/opSK8ghgoVwVcSlb7+Z8OmYhzo gViuhA0KA8mAbQzGS3Skg1GbvAQBhoxcn6XbWKhZWpwVkj5giAFsGcG877wrsZW/AfaBEl KzZwIkpGwgf/M+ZR1uXpEt5ePH4y4Avi1BEyakqBy1NjIS2qH5QgvuuxF6/chg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676913429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1W/yHp+digs/9tQmrEdxtc9OFifUEYrTHbBFllZM5ek=; b=J5WP74FErdjwIGmhBynl9T4C1+WS224WE7CKPt25NBtgS3CtoPpUongJ/S06U09ud2vnHB IYSxUzn7j1TTn7ZhNxo03brQHY4HL9z77GM7LLfAOBiZT2uC0hzojc0FUoH0jtUCRLKx/B bf4puFtu1qm7pJxFDEkUo0eLMGtPYTT24MEXm779X4kT9S7bnQu/iEKcglWNR0cOJJTi+E ujCOgCQaHDGdQyoDhdETkCDu+fnbybw2pGakwmZh34eO97bIAnv/m5NzZCkTW1NePgTi+b ZpA2/Hvk1X6MtXlQ0IP7Kpp6bNZQJL7dHqndt1mx4Fj5C52dBqT/HFVAoDe66w== ARC-Authentication-Results: i=1; rspamd-5db48964c-wmdpd; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Skirt-Well-Made: 2c2945951908affb_1676913429530_3151703476 X-MC-Loop-Signature: 1676913429530:3091638531 X-MC-Ingress-Time: 1676913429530 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1676913428; bh=1W/yHp+digs/9tQmrEdxtc9OFifUEYrTHbBFllZM5ek=; h=Date:From:To:Cc:Subject:Content-Type; b=UUG+txwSbZjwjKPTHOyD8W9Nra+sAjzKNx1Z6Zjyj2c3VHCmyut7CT3coeCJ0wFee Wxoq7Kx4mLjOFB5TJiSakB0a5Dwa8JHYwJLGt5lY2dAgcucToTPtRj2A7vMLrsfGup 4IrCnF1Oay8LPGaD551QoJYhFev96Qv8lxefMIik= Date: Mon, 20 Feb 2023 09:17:04 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Modifies xen_tsc_safe_clocksource() to use newly defined constants from arch/x86/include/asm/xen/cpuid.h. This replaces a numeric value with XEN_CPUID_TSC_MODE_NEVER_EMULATE, and deletes a comment that is now self explanatory. There should be no change in the function's behavior. Signed-off-by: Krister Johansen --- arch/x86/xen/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 95140609c8a8..cf6dd9f9fa6a 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) /* Leaf 4, sub-leaf 0 (0x40000x03) */ cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); - /* tsc_mode = no_emulate (2) */ - if (ebx != 2) + if (ebx != XEN_CPUID_TSC_MODE_NEVER_EMULATE) return 0; return 1; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 18:01:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 18:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498326.769167 (Exim 4.92) (envelope-from ) id 1pUATI-0004qB-PF; Mon, 20 Feb 2023 18:01:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498326.769167; Mon, 20 Feb 2023 18:01:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUATI-0004q4-M9; Mon, 20 Feb 2023 18:01:04 +0000 Received: by outflank-mailman (input) for mailman id 498326; Mon, 20 Feb 2023 18:01:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUATH-0004py-Av for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 18:01:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUATG-0007mS-8b; Mon, 20 Feb 2023 18:01:02 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.95.98.51]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUATG-0000yE-2y; Mon, 20 Feb 2023 18:01:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MPti7fO+hkxEWKAMwLaEgaLbjtYIVnIaPQkxsP2ylWA=; b=0WqZ+capgSdVnhioAO0nwdVhrA hazMXCCRSEh4JyJ/UN2ywA6cvbFJgzYAMZZ8EEwVrNTnQmJCt1pJA9onJOx6VQx3Zw+rH9x+2EIP+ EbAwr/DaWpGTnL7rMExYJIZh/OB5y0FvyfWrmafI0NSMXJoiuvTgSK46F/Xh85MYFt1k=; Message-ID: <20151614-96ca-0875-29a0-8099953b7e61@xen.org> Date: Mon, 20 Feb 2023 18:01:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> From: Julien Grall In-Reply-To: <32a517cf-4448-2208-4877-83c7a7531635@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/02/2023 14:21, Juergen Gross wrote: > On 20.02.23 15:15, Julien Grall wrote: >> On 20/02/2023 13:49, Juergen Gross wrote: >>> On 20.02.23 13:07, Julien Grall wrote: >>>> Hi Juergen, >>>> >>>> On 20/02/2023 11:04, Juergen Gross wrote: >>>>> On 20.02.23 10:46, Julien Grall wrote: >>>>>> Hi Juergen, >>>>>> >>>>>> On 20/01/2023 10:00, Juergen Gross wrote: >>>>>>> The accounting for the number of nodes of a domain in an active >>>>>>> transaction is not working correctly, as it allows to create >>>>>>> arbitrary >>>>>>> number of nodes. The transaction will finally fail due to exceeding >>>>>>> the number of nodes quota, but before closing the transaction an >>>>>>> unprivileged guest could cause Xenstore to use a lot of memory. >>>>>> >>>>>> I know I said I would delay my decision on this patch. However, I >>>>>> was still expecting the commit message to be updated based on our >>>>>> previous discussion. >>>>> >>>>> As said before, I was waiting on the settlement of our discussion >>>>> before >>>>> doing the update. >>>> >>>> This is not a very good practice to resend a patch without recording >>>> the disagreement because new reviewers may not be aware of the >>>> disagreement and this could end up to be committed by mistake... >>> >>> You said you wanted to look into this patch in detail after the previous >>> series, so I move it into this series. The wording update would strongly >>> depend on the outcome of the discussion IMO, so I didn't do it yet. >> This could have been mentioned after ---. This could allow people to >> understand the concern and then participate. > > Will do so in future. > >> >>> >>>>>> Also thinking more about it, "The transaction will finally fail >>>>>> due to exceeding the number of nodes quota" may not be true for a >>>>>> couple of reasons: >>>>>>    1) The transaction may removed a node afterwards. >>>>> >>>>> Yes, and? Just because it is a transaction, this is still a >>>>> violation of >>>>> the quota. Even outside a transaction you could use the same >>>>> reasoning, >>>>> but you don't (which is correct, of course). >>>> >>>> I can understand your point. However, to me, the goal of the >>>> transaction is to commit everything in one go at the end. So the >>>> violations in the middle should not matter. >>> >>> Of course they should. >>> >>> We wouldn't allow to write over-sized nodes, even if they could be >>> rewritten in >>> the same transaction with a smaller size. >> >> I view the two different. >> >>> We wouldn't allow to create nodes which would violate overall memory >>> consumption. >>> >>> We wouldn't allow nodes with more permission entries than allowed, >>> even if they >>> could be reduced in the same transaction again. >>> >>> I don't see why the number of nodes shouldn't be taken into account. >>> >>>> Furthermore, I would expect a transaction to work on a snapshot of >>>> the system. So it feels really strange to me that we are constantly >>>> checking the quota with the updated values rather than the initial one. >>> >>> You are aware that the code without this patch is just neglecting the >>> nodes >>> created in the transaction? It just is using the current number of nodes >>> outside any transaction for quota check. >> >> Are you referring to the quota check within the transaction? > > I'm referring to the quota check in create_node(). > >> >>> So I could easily create a scenario >>> where my new code will succeed, but the current one is failing: >>> Assume node quota is 1000, and at start of the transaction the guest >>> is owning >>> 999 nodes. In the transaction the guest is deleting 10 nodes, then >>> dom0 is >>> creating 5 additional nodes owned by the guest. The central node >>> counter is now >>> 1004 (over quota), while the in-transaction count is 994. >>> In the transaction the >>> guest can now happily create a new node (#995) with my patch, but >>> will fail to >>> do so without (it sees the 1004 due to the transaction count being >>> ignored). >> >> This doesn't sound correct. To do you have any test I could use to >> check the behavior? > > Try it: > > - create nodes in a guest until you hit the ENOSPC return code due to > too many >   nodes > - start a transaction deleting some nodes and then trying to create another >   one, which fail fail with ENOSPC. So I have recreated an XTF test which I think match what you wrote [1]. It is indeed failing without your patch. But then there are still some weird behavior here. I would expect the creation of the node would also fail if instead of removing the node if removed outside of the transaction. This is not the case because we are looking at the current quota. So shouldn't we snapshot the global count? Cheers, [1] #include const char test_title[] = "Test xenstore-transaction-limit-1"; #define BASELINE_DIR "data" #define BASELINE_MAX_DIR BASELINE_DIR"/max" #define MAX_NODES 2000 static bool max_out_nodes(void) { unsigned int parent_id = 0, child_id = 0, nr_nodes = 0; xs_transaction_t tid = XBT_NULL; printk("Maxing out nodes\n"); do { int rc; char path[256]; rc = snprintf(path, ARRAY_SIZE(path), "%s/%u/%u", BASELINE_MAX_DIR, parent_id, child_id); if ( rc >= (int)ARRAY_SIZE(path) ) { xtf_error("Unable to create the path\n"); return false; } rc = xenstore_mkdir(tid, path); /* Xenstored will return ENOSPC if we exceed a quota */ if ( rc == ENOSPC ) { /* * If we can't write the first child, then this likely means * we exceed the maximum of nodes quota. Consider it a * success. * * Otherwise, we may hit the maximum size of the parent. * Switch to a different parent. */ if ( child_id == 0 ) { printk("Stopped after %u iterations\n", nr_nodes); return true; } else { printk("Parent ID %u: created %u children\n", parent_id, child_id); parent_id++; child_id = 0; continue; } } else if ( rc ) { xtf_error("Unexpected error %d\n", rc); return false; } else { nr_nodes++; child_id++; } } while ( nr_nodes < MAX_NODES ); xtf_error("Created %u nodes and the quota is still not reached?\n", nr_nodes); return false; } void test_main(void) { xs_transaction_t tid; int rc; if ( !max_out_nodes() ) return; tid = xenstore_transaction_start(); if ( tid == XBT_NULL ) { xtf_error("Cannot start transaction\n"); return; } /* Remove one of the node within the transaction */ rc = xenstore_rm(tid, "data/max/0/0"); if ( rc ) { xtf_error("Cannot remove the node data/max/0/0 (rc = %d)\n", rc); return; } /* Creating a new node should work because we removed one */ rc = xenstore_write(tid, "data/foo", "bar"); if ( rc ) { xtf_error("Cannot create node data/foo (rc = %d)\n", rc); return; } xtf_success(NULL); } > > > Juergen -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 18:54:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 18:54:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498334.769178 (Exim 4.92) (envelope-from ) id 1pUBIl-0003H0-Ru; Mon, 20 Feb 2023 18:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498334.769178; Mon, 20 Feb 2023 18:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUBIl-0003Gt-OA; Mon, 20 Feb 2023 18:54:15 +0000 Received: by outflank-mailman (input) for mailman id 498334; Mon, 20 Feb 2023 18:54:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUBIj-0003Gn-7L for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 18:54:14 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f330b2d0-b14f-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 19:54:08 +0100 (CET) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Mon, 20 Feb 2023 18:54:05 +0000 Received: by hermes--production-ne1-746bc6c6c4-z5xkm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 709e109f7eba8bdeb4f598a7ae93bd2d; Mon, 20 Feb 2023 18:54:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f330b2d0-b14f-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1676919245; bh=NF//yOvPaFCVVecx7YqcRH4ZXNK0YgLwjwhziF0CEH8=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=s4Hk9FJoHUZddrgpcO0mPLfAsZJx77/t6acqta9sONof40uZdAvJ3ANPwRDYB5YZrMjAIdJHURZe7orO89lAltseeXjwWA4zj7iBZTA9DZGbHECG367c6mROLh6O0nRm9MFu1sBDA0LgsCdXfjhboy+3V/UI1pfx2Rsn1R26ElL/eDsw1cf+Y9dNNM8XyCEOvr1y9FEWZ3cgfjI4zE5WVhjhwilMCXJlwn7mVq2zo4i5cAvdfmHF+eoWZtBK8LErlquPRHRvh9F8DF9ErI2Rz+ohCSBHAn5TQQ8mROUl0DWERSLReXgdovaVRj3RF2/XGjAgmdqtGPUx+Koj14YrvQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676919245; bh=+Q9u8MrfUSTcN3A+R9yrY5VGpInvxolcKsSA/Q1+dU/=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Rf8dKu8Oy1UjBfc4r/HGgdPoLhkNta9skX17ETHf6TmnxCnsAGS/pIClYunaFVDAld986Ff20+sE8jsBuMAMg7Lcwb70OcEKWpcoN4NbixdkUze79k9yZqQViAHnKqtKYG8jK2MDFwULD80Q3DEQfYxBMdMEQY+ilQcaSAnRI9+8NFPZBNfvk+C4Q3fyCgeDfPwGnZkvDKQgSagQ8mpR/nPpnuUKT+XlRYnQw7RaAZ7fT3GZYg8DGWh/9rM7m9/OXEnNuzPpmstrOHqStKWcoD11Sw1PrAuP/YfXQN+SxvPD2oGHU1WYQNMWHKDW8MFnW9vW/0TCoV6vt7MwDujVVw== X-YMail-OSG: UM8bUVEVM1nIIoIvSsGDIAh30tj.HfTIugrcVUw9H6wXlACjvNzfpfjyweVR2e7 rkshUUAC60LNVNDCm2i6QN2H71z7BquDwevzzKZRYGkSDQFrMDFxzM5FNM9u4J5bo9GD8m6vQxi5 UFVlvtWF5nx9ZRaR8oeAjHUNSdewD2dnhGPi4M5kj5xC9a4pI5hmEebf9Sjmu.EsYRUGEijNiANm I14HSncUTa52S0bRtGXGb7lzGEXZt6IBo2p0Cmh4zslZlvElOblQW7bVO88kAlGZciKIaHWwXfNV xD1UAyJ..ftxMARiV0cPGAVsuG0B9_zkVe5ze127SmgFc9FYDwSFyf8FZOmqJKSJLjr5BmP1eP6X QD3gF.sDKqMFS3XbL06CqX51Do8A1_LcOUOYttt2NFj0u2hxCsd7MucxUKreayF0MgIBCfRUhXW8 zbYMn2uUj5MGq9PZv_n6lGUyDEkM3ThMC1sl1e0xxAEnjjp3mYLP_mGjP2HmedYZPa1hMsRZHDmr flY4pVkm6EF5HLxWY1fSH1xfEZ4j8JaK8qhWDIbkWO46Jdb9OBplz8c1bRkZMWjfkXzeI9GXlI.u KVfpMu8la5l9Ys1DbIH4F1VKtntMJqW_D2eNYyzPgyGI7TiC6u7tpYxuc_bICNn4FawlnF1rccoz yg1mGDPgOCzGBfo6RZax40jmcu_q5JqG7zCIhMA8qjOIp9MRTCeMaN5wC3VPiqo9lyC2Xp7FEfaC wgFu_zPuV_rVHy30keYBs3gUwEUlCx4kDfCCrHRDM5cMsWuo6juF071xT.JTiF71vs5mDfRgzcGs Avk.XHilayscWLuPGLCxrVe0aYcNIa55tRv3iopNDLAphSJZDtBG0q7QLtQHn.3ROH33awGmivGT Fc4FaTkAFkd18.KFmrMnXWI4d5QQeTlusL2Dg1vr.6B1L0oO1ke3B7MB_uLWoNZJzpOoObJttrur TJ2zB69oIv.bROxGBX32d_hij9CWanyXGVmelbb7Oi9SJuUXeOuEQsIjCqhGy6h1RxPz.CbuHmMa syzFCVNl4RQ7445UHqIIfXZfWMsmAv6peytJ_GdUJJYu18a4Ma9f3sI65tkBBdLsRPMSG.Od8q9F qWSLa690XTmDqRysqr77wjFRyX7doLEnSYo1Df3ohmFggs72OkMzcMXzddRwczZ28wKrpHmV29DB 56q2ImN2dCULQAcFFIzktEnCyZYlf2GdibN.U9vFlXSxTPfJil_W4neks.ZeR4vdNvN05tPwfdkl WwC2k9cK7eVsBkGd4w5F3e7916DkuYh.dmI9yTIbGmXJojreLKYOPtlvZ1tImLjaAACumOPj69K2 ggPEFD1AbLRnYx6kJDSKzKJW1gwCaP_lVDYn7XdS0zd7TtyKoWyeUAYheFQAKGU7c3hrNOTEnx11 FS5cbIYIwHtVze2v6wcBP3TZnD.6G5ia68xtXikK3gf5I7.x_0C9LdNJQPnDzrtI3rusrMfmMVht X3RwK.LKwGf5bn.GXY09ZrRQ45ZM2Qzrpdfa6NxumUmP5L9K_OXt0YSyt5EXowM2VZU1D5_W0eHb sJMPb.xMgPMwXtCq1ZXrLSpy3CangT.yOHhMPYP17qoCxhpjaU08lic9MNzCc0gqRLpUz9GFsCIo HsscjpMjnyzg6KWV8XAojRnj3n4LWLTvUxgbmr3guodlDj_VFQTcpfYAohKRcVzGDd_VAV3216TT .dTIqPL6iRjfQbZ1VgGcgpfV41sqtiAz0rOuHrebhYOopwOPktf_ETwWBuYZe_T57a70ytPO9I9O UwWGMC6oeXc6irO01HsqpQaNC7hW4eFnCpSbw4Q091N6gpoM1dIBKwmfkAV9Fy9xKr_r6hMx8qvX QU4GzGEfHV1aEwLiqCszT9wNMg.ADpBQmNggr9SZDfkbJjvrrQC4H5DZzxmbY2u49vfswvwObwuv eo2Lezq5W43lFl63ltWgcjBBn3k5jY3bbx8rdUjWbu5g.WMfOCydG3vJSLE3qY4hKuI4PFZ5BR8F IrUQ2tYMbDPoWo0gg2bZ62lPQpzsNvSQR8TYI8TS2dQgqhvNcEGlV38lip_bDvX6PGWIpm5CyhUj Yg0VdHD6cCRx_6VcdYRCpzx0yCYo9gPxWdXRSGH8z9.ShmVDozcufBGHCyGQkqgmGb6.XXAzNH7v lEl0EFvySK1yk_sydiUuzjqPNorFKxbNcpavV_nG8DHP_WICpJbjzO7yzAJnA_NXVRAt_3E5QTon _ X-Sonic-MF: From: Chuck Zmudzinski To: xen-devel@lists.xenproject.org Cc: Anthony PERARD , Wei Liu , Juergen Gross , qemu-devel@nongnu.org Subject: [RFC PATCH] libxl/dm: Stop using "xenfv" machine in the Qemu upstream device model Date: Mon, 20 Feb 2023 13:53:53 -0500 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: Content-Length: 8742 The "xenfv" machine is almost a clone of the "pc" machine with accel=xen in Qemu upstream and is mostly redundant, so with this patch libxl stops using the "xenfv" machine type in favor of the "pc" machine type with accel=xen. Looking at the Qemu upstream code in hw/i386/pc_piix.c, the obvious differences between the "xenfv" machine and the "pc" machine are: - The "xenfv" machine unconditionally adds the xen-platform pci device. - The "xenfv" machine uses the igd-passthrough-i440FX host pci device instead of the i440FX pci device when the guest is configured with igd-passthru=on. This patch adds the xen-platform pci device using a command line option with the "pc" machine type instead of relying on upstream Qemu to add it as part of the process of building the "xenfv" machine if the administrator has not explicitly disabled the xen-platform pci device in the domain configuration file. Therefore, the current behavior of adding the xen-platform pci device unless the administrator configures the guest with the xen_platform_pci option set to 0 is retained. So this patch does not affect guest behavior except as follows: - If the guest is configured for Intel igd passthrough, the guest will no longer be configured with the igd-passthrough-i440FX host pci device. For this reason, Qemu upstream should be patched so the igd-passthrough-i440FX host pci device will be used when the guest is configured for igd-passthru. - Live migrations of guests configured to use the "xenfv" machine when they were created to a host that configures the device model to use the "pc" machine instead might be affected. For this reason, it might be appropriate to deprecate the "xenfv" machine in upstream Qemu and it might be necessary patch upstream Qemu to properly handle these live migrations. - Testing reveals the display resolution can be affected in some guests by the change from the "xenfv" machine to the "pc" machine but there is no degredation in performance, just a possible need to reset the display resolution to the desired value. Signed-off-by: Chuck Zmudzinski --- Sorry about how long this discussion is, but it is helpful to again bring together all the considerations about this patch and its alternatives in one place. I submit this as an RFC patch because some caveats might make this patch more trouble than it is worth. The first caveat is complications that might be involved for existing guests that currently use the "xenfv" machine and are migrated to a host with this patch that uses the "pc" machine instead. The second caveat is the effect of the patch on display resolution in the guest. Details of tests that reveal the display resolution can be affected by this patch: Testing existing guests that previously used the "xenfv" machine reveals a subtle difference that is not obvious from reading the Qemu upstream code in hw/i386/ppc_piix.c. The tested guests were configured to use the Qemu stdvga (bochs) emulated video device with a vnc display. When the guest is started using the "xenfv" machine, the resolution of the display manager (either gdm3 or lightdm) is 1024x768, but when using the "pc" machine with the xen accelerator, the resolution of the display manager (either gdm3 or lightdm) is 1280x800. Also, the display resolution of a user's graphical login session might be reset to a default value when changing from the "xenfv" to "pc" machine type, but the user can easily correct this by resetting the display resolution to the desired value in the first graphical login session after changing from the "xenfv" to the "pc" machine type. On a more positive note, this patch will not introduce much of a regression for users of the upstream Qemu igd-passthru feature because that feature is already currently broken in upstream Qemu because upstream Qemu currently fails to reserve pci slot 2 for the Intel IGD and, in fact, with this patch, it is actually easier to patch upstream Qemu to properly support the igd passthrough feature than it is without this patch because, in that case, a more complicated alternative patch to upstream Qemu that reserves pci slot 2 for the igd is required to properly support the igd passthrough feature if we continue to use the "xenfv" machine type: http://patchew.org/QEMU/b1b4a21fe9a600b1322742dda55a40e9961daa57.1674346505.git.brchuckz@aol.com/ This alternative patch, however, has been reviewed and could be merged into Qemu anytime at the discretion of the Qemu Xen maintainers. Some of the "pc" machine maintainers might want an additional patch to Qemu upstream to be applied to change how upstream Qemu's slot_reserved_mask works if this alternative patch is merged into upstream Qemu. A much simpler patch to Qemu upstream is available to fix support for the igd passthrough feature in upstream Qemu for the "pc" machine type: https://patchew.org/QEMU/a304213d26506b066021f803c39b87f6a262ed86.1675820085.git.brchuckz@aol.com/ This patch has not been fully reviewed yet, but it does have an Acked-by and this is the patch that would be applied to upstream Qemu in coordination with this patch to libxl to ensure the guest uses the igd-passthrough-i440FX pci host device when igd-passthru=on. Also, to better support the intel igd, additional patches to libxl could be applied to more easily configure the guest properly for the igd. So, do we want to completely stop using the "xenfv" machine as suggested here: https://lore.kernel.org/xen-devel/Y9EUarVVWr223API@perard.uk.xensource.com/ or, do we want to continue to use the "xenfv" machine and fix the igd passthrough feature in Qemu with the more complicated patch to Qemu that has been reviewed and, since it continues to use the "xenfv" machine type, it also avoids the problem of how the fix might affect existing guests that currently use the "xenfv" machine type? And finally, there is a third option, which is to use this previously proposed alternative patch series to libxl to fix igd passthrough support by only changing guests configured for igd passthrough from the "xenfv" to the "pc" machine type and leaving other existing guests unchanged: https://lore.kernel.org/xen-devel/20230110073201.mdUvSjy1vKtxPriqMQuWAxIjQzf1eAqIlZgal1u3GBI@z/ which would avoid the complications of migrating other existing guests to the "pc" machine type and also allow use of the simpler patch to Qemu to fix support for igd passthrough in upstream Qemu. This alternative patch series also has not been fully reviewed yet but it might actually be the best approach overall after considering the complications of stopping use of the "xenfv" machine type in all cases instead of stopping its use only in the case of guests configured for igd passthrough. tools/libs/light/libxl_dm.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index fc264a3a13..9a3c27ae9c 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -1373,6 +1373,15 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, if (b_info->cmdline) flexarray_vappend(dm_args, "-append", b_info->cmdline, NULL); + /* + * Since we are no longer using the "xenfv" machine, we don't + * rely on Qemu upstream to add the xen platform pci device + * and instead add it here as a command line argument. + */ + if (libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { + flexarray_append_pair(dm_args, "-device", "xen-platform"); + } + /* Find out early if one of the disk is on the scsi bus and add a scsi * controller. This is done ahead to keep the same behavior as previous * version of QEMU (have the controller on the same PCI slot). */ @@ -1809,14 +1818,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, flexarray_append(dm_args, b_info->extra_pv[i]); break; case LIBXL_DOMAIN_TYPE_HVM: - if (!libxl_defbool_val(b_info->u.hvm.xen_platform_pci)) { - /* Switching here to the machine "pc" which does not add - * the xen-platform device instead of the default "xenfv" machine. - */ - machinearg = libxl__strdup(gc, "pc,accel=xen,suppress-vmdesc=on"); - } else { - machinearg = libxl__strdup(gc, "xenfv,suppress-vmdesc=on"); - } + machinearg = libxl__strdup(gc, "pc,accel=xen,suppress-vmdesc=on"); if (b_info->u.hvm.mmio_hole_memkb) { uint64_t max_ram_below_4g = (1ULL << 32) - (b_info->u.hvm.mmio_hole_memkb << 10); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 19:47:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 19:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498352.769204 (Exim 4.92) (envelope-from ) id 1pUC88-00027f-5c; Mon, 20 Feb 2023 19:47:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498352.769204; Mon, 20 Feb 2023 19:47:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC88-00027W-1Y; Mon, 20 Feb 2023 19:47:20 +0000 Received: by outflank-mailman (input) for mailman id 498352; Mon, 20 Feb 2023 19:47:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC86-00026t-Em for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 19:47:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 602db248-b157-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 20:47:16 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 602db248-b157-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676922436; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7VQfclR45ezJQ1yrJQ2kJaN6bb0KI469e9W5ZkludMw=; b=AIOZrcLffhFxppJoj4xOCbEuOlC7sa/EGoavxAgXpkxLksfcsxMTZCiu OKG9HHvbCgUJwPmhUVBo2tiVr5nS402Y+YjNYgoWg+/o2UBnaL2MJNQm+ gthWIDTpXUEEHq5Ir/kAvUfbhYwNLJjXnGcCFwN9khxmrd4akEFu/cezF s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97179657 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:pTM7IayVIavplnEF1yl6t+chxirEfRIJ4+MujC+fZmUNrF6WrkUEx 2ZJXWiHOv+DN2Xxc9hwO97jpx9S6p7UzddmGgJurCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkP6gT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVhp3 KI1DgwBVzeGjMO6wo69S+Yxxf12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+BgHXlfiIeg1WSvactuEDYzRBr0airO93QEjCPbZQKxxnJ+ D+Zl4j/Kj0dHeewjhSIzn7yhNTRwibAV508EqLto5aGh3XMnzdOWXX6T2CTvv2RmkO4HdVFJ CQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooL2yQuEAmkPThZadccr8sQxQFQXO kShxo2zQ2Y16fvMFCzbr+3Pxd+vBcQLBVYlTHEpazcJ2v7mq6A/jC7JT9k+U5fg27UZBgrM6 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4adO6kok+9U G/ociR0xMQHFtmzmSOEW43h95n5tq/eYFUwbbOCdqTNFghBGVb5IOi8Axkkfi+F1/ronhewO SfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlDZrXg+PR7Phju1+KTJrU3YE c3GGftA8F5AUfg3pNZIb7p1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PXBt3VGJis+V2Pm /4Gbpvi9vmqeLGmCsUh2dJJfA9iwLlSLcyelvG7gcbZfFM2RTF+V66IqV7jEqQ895loei7z1 inVcidlJJDX3xUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:Ic//7qgOvUfNyTTuVJAm6uCeTXBQXhoji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2RSvILBzySTV/wb57C8gcSVbeW19QYRcem9AZsQkzuQCWygYzJLrBEtP+tfKH IFjPA33AZJfx4sH6KG7ilsZZm7mzXT/qiWGSI7Ow== X-IronPort-AV: E=Sophos;i="5.97,313,1669093200"; d="scan'208";a="97179657" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 0/2] xen/irq: Perf improvements Date: Mon, 20 Feb 2023 19:47:00 +0000 Message-ID: <20230220194702.2260181-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Andrew Cooper (2): xen/ioapic: Don't use local_irq_restore() to disable irqs x86/irq: Improve local_irq_restore() code generation and performance xen/arch/x86/include/asm/system.h | 9 ++------- xen/arch/x86/io_apic.c | 5 ++--- 2 files changed, 4 insertions(+), 10 deletions(-) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 19:47:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 19:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498353.769214 (Exim 4.92) (envelope-from ) id 1pUC89-0002Nk-ES; Mon, 20 Feb 2023 19:47:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498353.769214; Mon, 20 Feb 2023 19:47:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC89-0002NZ-BG; Mon, 20 Feb 2023 19:47:21 +0000 Received: by outflank-mailman (input) for mailman id 498353; Mon, 20 Feb 2023 19:47:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC87-00026t-8z for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 19:47:19 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61d62945-b157-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 20:47:18 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61d62945-b157-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676922438; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=59YlNFN9gprKCcNZMjv06aajCgsZGhQvKhHumYZ971A=; b=SPF/HPidQT9QQH5iPFa59F21Skd7EwKYwPpTzZr3hIRNst87M8qbZ/CG l+hYbHJO9iAs/HzTqWvEwnMt8uwM4dT5xzWrY/H5EsbFK6utJOKnxhkrQ d+xjQfHM+/MjqS5pnniLUoV6H7Np6KrCUlj9z1tWzy7TWub0z5+2oKy1E Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97179658 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:pLOcRKowHzvlRUst5zmcGuqzJU5eBmIOZRIvgKrLsJaIsI4StFCzt garIBmFPvaJZWLwfot1Pojk9BkGu5/RzdBqTwpl+C82E3sR85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSFNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAkqR06uod66+ZW+QchghPglLca2f7pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVxrl6PqLVxyG/U1AFri5DmMcbPe8zMTsJQ9qqdj jOZpjuoXExKXDCZ4SulyFacvdHupxrQCYECTOT/1dBx2nTGkwT/DzVJDADm8JFVkHWWRNZ3O 0ESvC00osAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAmZDNcbN0ttOctWCcnk FSOmrvU6SdH6ePPDyjHr/HN8G30YHJORYMfWcMaZTIiyofOhr0/tzXKRfdvEpKzj9KoWgill lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3Hb5 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AhkkeS+F0e5eI1cFh XM/XisIvfdu0IOCN/MfXm5II51CIVLcPdrkTOvISdFFf4J8cgSKlAk3OxHOjjm9yBhzyPpnU Xt+TSpLJSxHYZmLMRLsH7tNuVPV7n1WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vdyDg5B +13bpPQoz0GCb2WX8Ui2dJLRbz8BSRhVM+eRg0+XrLrHzeK70l7VaaBnON+J90890mX/8+Rl kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:5+eu96tj6q3WnvMJZVjhrGNG7skDttV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMXFKyfzUzSP9OewGqeP3lJxBh43lvgpQpdcBUdAd0+97YDzrbXGfXGN9dP0E/A L33Ls9m9KnE05nCPhSVhE+LpH+T8SgruOfXSI7 X-IronPort-AV: E=Sophos;i="5.97,313,1669093200"; d="scan'208";a="97179658" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/2] x86/irq: Improve local_irq_restore() code generation and performance Date: Mon, 20 Feb 2023 19:47:02 +0000 Message-ID: <20230220194702.2260181-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220194702.2260181-1-andrew.cooper3@citrix.com> References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit POPF is a horribly expensive instruction, while STI is an optimised fastpath. Switching POPF for a conditional branch and STI caused an 8% perf improvement in various linux measurements. While I don't expect the change to be that dramatic in Xen, there will be an improvement. Furthermore, there is the following code generation improvement: add/remove: 0/0 grow/shrink: 3/52 up/down: 52/-966 (-914) owing to not needing to opencode the restriction to just IF in asm. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/system.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/include/asm/system.h b/xen/arch/x86/include/asm/system.h index 65e63de69a67..4be235472ecd 100644 --- a/xen/arch/x86/include/asm/system.h +++ b/xen/arch/x86/include/asm/system.h @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index, }) #define local_irq_restore(x) \ ({ \ - BUILD_BUG_ON(sizeof(x) != sizeof(long)); \ - asm volatile ( "pushfq\n\t" \ - "andq %0, (%%rsp)\n\t" \ - "orq %1, (%%rsp)\n\t" \ - "popfq" \ - : : "i?r" ( ~X86_EFLAGS_IF ), \ - "ri" ( (x) & X86_EFLAGS_IF ) ); \ + if ( (x) & X86_EFLAGS_IF ) \ + local_irq_enable(); \ }) static inline int local_irq_is_enabled(void) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 19:47:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 19:47:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498351.769193 (Exim 4.92) (envelope-from ) id 1pUC81-0001rs-Re; Mon, 20 Feb 2023 19:47:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498351.769193; Mon, 20 Feb 2023 19:47:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC81-0001rl-P1; Mon, 20 Feb 2023 19:47:13 +0000 Received: by outflank-mailman (input) for mailman id 498351; Mon, 20 Feb 2023 19:47:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUC80-0001rf-5t for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 19:47:12 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5b23a48b-b157-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 20:47:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b23a48b-b157-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676922428; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ozmrT0xsF9T2UPZ0eCR4FeQWVNqHXbEoi8spot3TtxA=; b=JSqgews5QXcv/KlA8+0Y3m8haXat6Y1kcI6dUjZdlH+ADugB6aEIm8v6 q5q/dUPf73dtYrST6zVeWl2BSH4oXeycJ5LCOpVtaEuSe792e82fPklLY A0/6maeTzWfhAJGOa64tU7USQaCbb55jd3CRRLBnkMNclqfZ/XUQPfhap A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97796898 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:OQvNBqCEez9KdRVW/z/jw5YqxClBgxIJ4kV8jS/XYbTApGt31DEFn DdJXW7Xbq3bMWCnftEibd+2pkJQ7ZDQyoJjQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlC5gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw1N14PTlkz v4hBTktah6DnMWN5pmwc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9K4PVFJsFzxbwS mTu9lnBKyomJMakxRmHqVPwoNXhhGDjcddHfFG/3qEz2wDCroAJMzUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiFyuswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3PLaXhRzi AXPxYmwQ2Uy7vvMEyn1GqqoQS2aFxMaETcoXi09YAIl59fju6YIqDnEd4M2eEKqteHdFTb1y jGMiSExgbQPkMIGv5mGEUD7byGE/caQEFNsjunDdif8t14iOtb5D2C9wQKDhcusOrp1WbVoU JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD327wk5JAVdoKiN2bGKuOGp9dEQIFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPcYgLV/frH43Phb4M4XRfK8Ey/xXB HtmWZz0USZy5VpPkVJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYe5tDbd6VchgtPnsiFyMo 75i2z6il003vBvWPnOGrub+7DkicRAGOHwBg5YJL77eclU6SThJ5j246epJRrGJVp99zo/gl kxRkGcBoLYjrRUr8Tm3V00= IronPort-HdrOrdr: A9a23:A1uTNKCpRMHEJJPlHels55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dWpk7MvLcJxxRt+GS2njdLz4jquP3jZxBU43lvgtQpQIBUdAe0+9gYDzrdXGf3GN9dOEE/J z33Lsgm9LxEU5nF/hSHxM+LpD+m+E= X-IronPort-AV: E=Sophos;i="5.97,313,1669093200"; d="scan'208";a="97796898" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs Date: Mon, 20 Feb 2023 19:47:01 +0000 Message-ID: <20230220194702.2260181-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220194702.2260181-1-andrew.cooper3@citrix.com> References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Despite its name, the irq{save,restore}() APIs are only intended to conditionally disable and re-enable interrupts. IO-APIC's timer_irq_works() violates this intention. As it is init code, switch to simple irq enable/disable(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu This is a logical equivelent to Linux's 058df195c2 "x86/ioapic: Cleanup the timer_works() irqflags mess", but we've diverged far enough for the patch to not be remotely relevant. --- xen/arch/x86/io_apic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 9b8a972cf570..199098fa3e0f 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1502,15 +1502,14 @@ static void __init setup_ioapic_ids_from_mpc(void) */ static int __init timer_irq_works(void) { - unsigned long t1, flags; + unsigned long t1; t1 = ACCESS_ONCE(pit0_ticks); - local_save_flags(flags); local_irq_enable(); /* Let ten ticks pass... */ mdelay((10 * 1000) / HZ); - local_irq_restore(flags); + local_irq_disable(); /* * Expect a few ticks at least, to be sure some possible -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 21:24:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 21:24:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498383.769230 (Exim 4.92) (envelope-from ) id 1pUDdy-0007Lp-Iy; Mon, 20 Feb 2023 21:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498383.769230; Mon, 20 Feb 2023 21:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUDdy-0007Li-G6; Mon, 20 Feb 2023 21:24:18 +0000 Received: by outflank-mailman (input) for mailman id 498383; Mon, 20 Feb 2023 21:24:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUDdw-0007Lb-TP for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 21:24:17 +0000 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb375947-b164-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 22:24:13 +0100 (CET) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2023 13:24:10 -0800 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 20 Feb 2023 13:24:10 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 13:24:10 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Feb 2023 13:24:10 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 20 Feb 2023 13:24:10 -0800 Received: from MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) by CH0PR11MB5218.namprd11.prod.outlook.com (2603:10b6:610:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Mon, 20 Feb 2023 21:24:07 +0000 Received: from MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536]) by MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536%3]) with mapi id 15.20.6111.019; Mon, 20 Feb 2023 21:24:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb375947-b164-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676928253; x=1708464253; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=K3K05a6gyOL/k11aIXAtq7ahCnYzje8Vl9Dl05sRF1o=; b=nehWu/RDGEn/woXyaPOWrz1x9yNCsnIABhGugbUYHAbKR+OoSAMc6Ur7 MlKBydjHsw0Z89UQH0SFf1Ckd05PPFThUtPBrLe6d/u4xTijjog8kbIC4 SgcoAm589ctTLQllDK9YAiQpThP20V2HqY7DjB0BRtaG7IDzdwhRh4/yr LQIAOgrl4/KuSem35Ptfo/0GqhhiuxvoBDJRXRJubAQX4RlGahUyYuoJ4 zSw56IlHyFUt+TcfZ/dsgkjYauLt7krk24RmiAMrRvBUgCV/wWiaSg2Ym o4S47ab1XBGLvZiSwLUXH74DaOW5nKCsnx/vXEFCPWQ8fTNh2tNwiumbM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="331156677" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="331156677" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="673467678" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="673467678" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MMuCjnReb2Y5U/d+g/8eTSKgvWQN9xcTOOrRs7UooaLxld4LeVb5jJYpl8mO+G3gytZJnbM/tvmEACq/jUHrQ/KLaaE0sZ4TX81nbkQ1u+dxUXYs+58FOqj4IdpEXr8AczJtTpe7rDL2XydYOJGqb6uegfWvABW56eiNvA5QFH+wFus539dbJf+ivYoDXnJLukmPvlrgFcmztAfmUG4LrQiZ3B+H/v3R6/acEOhzx47ljXSYFaGXap/O1KSKpDcYU6pHrHL16crg3jWwSCDXJXRhbaeiCLTJtQbiJrXPP1vjXaGPYQsbT9My8y7LZB0M2MLFOHAYDI0SbZIQ6q7dDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K3K05a6gyOL/k11aIXAtq7ahCnYzje8Vl9Dl05sRF1o=; b=GY9AhDOX0hkGGsxQjdr75+kG2IU88QqvFtz5iWuXVinm7ot/rm+AK6cIgtoNXFXnidbn9sJeTl8nFi2FeYrFffu0qf81ehEFMgX+nF6h9Hz1V6wmjL4wUVYzGre1iUKZnwfaRBb3JGoNqZQmEcVaOq8qNc8ZBJBphQD1/V260LN6qQMJFIbf2vBi7+kCeTo42Gcs6tLNvH6nQFxe7feUoITV2xlP07JviNjuDJ+xiVKxG2Um+dnf44H8d+7EbZlsnzm/pj9NM6uZ8YcLK7L+2+d8I4n5VxBxubFpd2rJxuiEzkAazknRWNNLH1l3D7aZ/mAQ66ZZg4q04o+ZVJ0ghQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Edgecombe, Rick P" To: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "bp@alien8.de" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "pavel@ucw.cz" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "mpe@ellerman.id.au" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "Yang, Weijiang" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "Schimpe, Christina" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" , "akpm@linux-foundation.org" CC: "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-m68k@lists.linux-m68k.org" , "linux-alpha@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linux-csky@vger.kernel.org" , "dinguyen@kernel.org" , "loongarch@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "monstr@monstr.eu" , "openrisc@lists.librecores.org" , "linux-parisc@vger.kernel.org" , "linux-um@lists.infradead.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Thread-Topic: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Thread-Index: AQHZQ94+cYJhrZsBjUaVUuq1nj/bS67XBcoAgAFVzAA= Date: Mon, 20 Feb 2023 21:24:07 +0000 Message-ID: References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> <875ybxywu9.fsf@mpe.ellerman.id.au> In-Reply-To: <875ybxywu9.fsf@mpe.ellerman.id.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1392:EE_|CH0PR11MB5218:EE_ x-ms-office365-filtering-correlation-id: c9f5ead7-6de7-41a3-3638-08db1388ccbf x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DUGxK4Preadv531pNjY5q3a2Jx+lCLmtVLQqroIQuyio6uCLucPpy1aolAsVnI9u6j07OJV6SYoQa0y4YrHBvaeoI6D7jemPvbIPwZ04plbHunbh1vxvi2rmi32u/c7bUXL4OhMlPIUjlloF33do4CV29bheBeBLhqccRT+CVnw1i5jGKxeDsoMnRdsLXOizMZ7zvuFO5J6zld6dv52HqqiZr4EoXB7EUTuNkI2mTDmxWggTzcNZz0j6rtJdrcmoBvjtj1xKzB3wY9fKolVz1FEk3VdUFC9lQED2Mvuq27QCbuLuCJJpISnJjnQGcPrJvGXkgAuMGtwx3H1kX8aI/6HlT/EJGTL9t2ZFbpTazvSWRtQDSKNWXA+0wpZOf3HBZs+5YKSZ3Dq5gfl4uES5lXe1KCIWhONPw0NY22IfryBgW17clWea3B3Ks+FKwW81/bLfcuYsLSur8uPiyzl4rM+ZPNrWF3Rc3p8mioIW7vfxrQXMa53wQ9JvkIncfhUMMJLP8vOClnFtfMT82VoV62ZWuEjLCJmRsppbq93hV+rfRAuKWXLYwnwiimpNz9WzPhjEc+qGsdq4p6tDGWWUCxMMBApZJR5UpuABztLWbP67ZsV+bHJ05fiUrB0i0UcIhjB73F+ExJbdAnYgGDycnlsJBQDq97cGW2lLLmlQD5LHBCD9KfghGfkD+0QWqOi3x0RCoadK7Qhgasj4xp46u/jsJfCezB2uRGyf5E/ylkoX4EYmEJt6y070SYv9uOQz x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1392.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199018)(5660300002)(8936002)(36756003)(921005)(86362001)(38070700005)(66946007)(122000001)(558084003)(82960400001)(38100700002)(316002)(54906003)(478600001)(110136005)(41300700001)(64756008)(4326008)(66476007)(66556008)(8676002)(66446008)(76116006)(71200400001)(6512007)(2616005)(6506007)(26005)(186003)(6486002)(2906002)(7406005)(7416002)(7366002)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YmZxaktsT3RsWVhjcXdWMExHYTNldDl2MXNFN1llcjF6T3BMQ2dZcnJvSFRP?= =?utf-8?B?NjV2eW1ZMk91alZINXdFRVphcW9IbWhlMnFJblU5MzVJbHVmRnBhQXNnOTJQ?= =?utf-8?B?TmkxWGNnZlB6WkJtMlRqTU12WEkzVE5vU09lajRseVZEM1g2UDIyTnUxUW8v?= =?utf-8?B?N2NvZkdSWEpkU2lUS0dLaEdqa3JyTHNGWHJQMzUvRjN1dmpzUmJpclBQRGl2?= =?utf-8?B?Yjc1c05HZm1mR1loT1o2d0F4bE9HWFJUV2NWVnVoWitnMjBuU2pJRWJ6U0Rz?= =?utf-8?B?SkRmenNoOHVqeWs4SEFsbjhKUkI1dEZRdXNuWWg1N0JTZEI2K00zcStJNFUy?= =?utf-8?B?UENrRzhad2lQbEMzNWhZN055L2FJNEIvQ0hZRGZla0RkaDlhVzROTXpWM1kw?= =?utf-8?B?ZDhFcXVLb1haTDl4ZXdaRGN5TGVpdEFGdC80UFcwSXhsYTZTdnczV3pyYXNW?= =?utf-8?B?Y2toVG11b0s1R2VJZFNVaHg5emZnQ3JxOElSclpFc3R5UzZ6SzYrc0NHcE5Q?= =?utf-8?B?c3N6eHlXOUo2ZU5keStIMjVIUE9Ld1YreW5Rdm0rRHdiMzVxUFpvSzFUSEp2?= =?utf-8?B?aEhZc2RqcDROVGVraklYaDNGcGUvTlJicXpFR09IYXZQamtUMnZSV1VCK1k2?= =?utf-8?B?V0VOc2UxWWQ0L1JYQ1JpRlcvZkJGRkttMFlTVkpiVnpSbnBlUXhFNUhsZ2My?= =?utf-8?B?Q0p0YlVBMmxFU1phQVJ5V2dKekVrK2pOclRIMmRTVDNDVWYyUHU2SnBzckwr?= =?utf-8?B?SzNZUTVQZUpaUFpvV2Y4YVZsYlpWQlhaSDNqZTlWd1pwcDI1dTZ6RHFiV0p5?= =?utf-8?B?Qm5aMktlbWh2UDhPTUJHbmh0R3QyT2R4dU9aazN0QlhsVWZHZFdvV1EyUmJ5?= =?utf-8?B?ZDZuTHk2aU5nWlNUMEE4Vkhkd1dnWkhJSHRPQnc1UGs3MzBZZk9MbjZwU2s2?= =?utf-8?B?V3pnU2dYcTRwUmpvQ2NOekNBNDJaQmc1QjByREpRQTJJaHNaTGlYWXlnNGlI?= =?utf-8?B?TWROSERDTTdiVjl3OCtuWDhMYjlxQ0xldVlGODV1TlBVa3cvV1JNbGs4VUZG?= =?utf-8?B?WE1WYUs3V2kyRG10SEVmUkc0Ni9WVHZXb1hLTlJ3NVRaeWpuV3BIQXRFNkRo?= =?utf-8?B?cG1VY2IwMjlwclAySldiQ24wTEdudVFmdmQxbGVCUWhTYjhnSjQ2WDFSZkIv?= =?utf-8?B?dHNuQktXY0hGWUJ3eEx3K1ErcHpLOFVlWWxMRDBjYURWRCtodi9PTi8rUERu?= =?utf-8?B?clJlbFBiajNlWFNWdUZTTVFnS1VTYkxJcFVxZHJBVExXeEpWamNJMTdXVDNF?= =?utf-8?B?SzJqbkY3K0cyaVZ1WW9wWC9hRUpWV1Iyb2Vwb1FUNUxGQW44MVRlUnpZb2N2?= =?utf-8?B?UHVEQkM5NlBJOUVScXBNbkgvOFVNQXhwaHhUdWF4aHJteU43Y0FaeWgzek1I?= =?utf-8?B?MGNlQmIvcURDaisrT3BHR0VJYWlZT3ljTC9kTzNNUDdBVWJObmhpYS9NelRO?= =?utf-8?B?ZTdtTWFab3B3MnpwSmpnQy9oQlNVb0pqU0NKSVlFNnRSNHZaSFUrTHM4RWxQ?= =?utf-8?B?QTBPK3hCZEVTVTVtK0VZZTVhQ2pHbWRMS0NFc1E2Ny85SmZFZEZRQXlLZ0p5?= =?utf-8?B?TEp3ZkxXS1p6aDJ0KzFtMC83WlBEOXhqRWVPN0dqY3NUOUJLZ3Zkb1NkUTBa?= =?utf-8?B?Ti9ndVRNeHlXT2xKdlpOaFVjK1VCd2dxdXRyaUFqVC81UmdOQlg2WW1vQjJy?= =?utf-8?B?ekVTd3lpcWc5eERmbXh1UnhHa3hBNkQ2OU8rbDJnZTNPRUhnczhjbHdYVDRN?= =?utf-8?B?M1hta042MUprZUhBczJLQzZpQmYvcFpjTVcwOGJRWWpQSStiR0Z5YjNUeElV?= =?utf-8?B?SStaSVdSWlpuc0FSc0FIeHFpbmpIUStXWm5ORTQvMDh2eHVuMldNYXMxZk5a?= =?utf-8?B?ZW9ST2NZRjJseFh1eXh1WnNsazlMd3M5b095K2I1c1ppZm03MU5nT1FXOXZO?= =?utf-8?B?OWk4aHM1UncxbXNYeWI3NEVLVXJFMkwzYy9vTjBMcjVSbjdpalJSNlBHZm0r?= =?utf-8?B?RndUL1RIY3BpNHBsNlg2QjlTVW51aDEzZnFrbElwbW9Gek1rR2hOb0JZUFlZ?= =?utf-8?B?d0s2K0RDaHNFN2ZidG9wZ1pyTkhsaGMvVTl1OW9wWmpEK284SnZya1dQOHl1?= =?utf-8?Q?ux/kqtH8JCpsKqOd/3TJYSA=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1392.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9f5ead7-6de7-41a3-3638-08db1388ccbf X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 21:24:07.4464 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 54cgsuD1w09YcUpGG/uBlI9HwRVjLnV1XDNNgqKe59Hbm8nRBRGvj7DJWaxFIjNzEWIKUODZx5HIp4xBO/lyXB3V5avrmJ9sPAXOPDGPHzQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5218 X-OriginatorOrg: intel.com T24gTW9uLCAyMDIzLTAyLTIwIGF0IDEyOjAwICsxMTAwLCBNaWNoYWVsIEVsbGVybWFuIHdyb3Rl Og0KPiBBY2tlZC1ieTogTWljaGFlbCBFbGxlcm1hbiA8bXBlQGVsbGVybWFuLmlkLmF1PiAocG93 ZXJwYykNCg0KVGhhbmtzIQ0K From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:00:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498393.769241 (Exim 4.92) (envelope-from ) id 1pUECv-0004gt-Fo; Mon, 20 Feb 2023 22:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498393.769241; Mon, 20 Feb 2023 22:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUECv-0004gm-Ct; Mon, 20 Feb 2023 22:00:25 +0000 Received: by outflank-mailman (input) for mailman id 498393; Mon, 20 Feb 2023 22:00:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUECt-0004ga-Fq for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:00:23 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f77394f5-b169-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 23:00:20 +0100 (CET) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31KHFNgi031139; Mon, 20 Feb 2023 22:00:10 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3nv9rbhfh7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 22:00:10 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AS8PR03MB8665.eurprd03.prod.outlook.com (2603:10a6:20b:54b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 22:00:05 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6111.018; Mon, 20 Feb 2023 22:00:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f77394f5-b169-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jL95iSeVpPlIj4h2pPLYHIU75xPC4rD+o/8oEOzMZKrVV1WyUEENcKdwvDjkO4/FaBfX5b+wfylQfi8uQvgJPKMWfj1FloQDU1TriXORwkZJ59TyJz5UEdq3hrtyTqx6PTzAMZgkUaqg7KFjDhR9qWD+BFDq3OJzjqD1dc9b1IMLPjmlyTaZ8SsoNXrDmQDDxF8dC6+QUZtg+LcAVjlo5lTt5jYb3/qTKnjR38Y9H9NUNGq/HJYuPztxM4CTsrXA7UWZZ/XNcYHvZ4a8Drvv+UBiWndrUNMXTaavdmy2TjMVmsbyo98VsE0fbdfABqfOTdvcxD1puy5NUN51O/iQmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7aOSaM0ZM3u2/TK3SXUaBtRLWsPbnid5e2gPMLs4NT4=; b=V7cLwy52smdgLgRO5O1o6/nTNcQK9qGiBROCok272GbGcNjYhqL1l99AWLK06xviQbg3utYVaX0200dJYhJo8TFfMNZYT/J0wftjAW3Th32zBHIuogr0VhTBX3QDNn5JxpVeEieIN6K4e79KQBdadoqMllmSLv2x0gegWPwL3B7xDKic231xQeB4FWa7/sCSaF9IOvmzD+R7L1p753D7ljdsvBYWjm1pjfiML7tBhjA315TyQkoRP0nR9vTGEVS0vSdCVthN1qSbiLbsOF1v/ZwhMaw0QQDfTwE5h+g3Z5Xlw0jDFwLMdvKewRn8h8i9/iarXDlB3glKzBpmYr/OcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7aOSaM0ZM3u2/TK3SXUaBtRLWsPbnid5e2gPMLs4NT4=; b=RoIve1tGNBEIBtTbj/0MaPAFuAWTlZ6l5ZIc0p4LUcGG772odIys4IaDfnAEzTZsnEsO1mA1k6IKH8FJKVHeJv5ejJT0To55Dh8swL5AdeAgnSzFHjzsNoemy8cCjwDm2Mqz1rc/wrtNt3H9MJbKL29njPYMyuJwGl1vvnpI+HCKlrrrToIp4Tvi6e4oqMz/AHmOuQoQdfhLd+h+FxT8R35UM/D6gXhVt5Sl3b+jqYNT8fPuoF0MmZwqJ0RwwZooi14qSYVW094b2/omDM+dLsUm+eYOn0KFWFLG1dNh6IRLd4NI9/emQfJm+XZek/jzAfsX/279Z8ydz3rRc7gkZA== From: Volodymyr Babchuk To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Paul Durrant , Kevin Tian Subject: Re: [RFC PATCH 05/10] xen: pci: introduce reference counting for pdev Thread-Topic: [RFC PATCH 05/10] xen: pci: introduce reference counting for pdev Thread-Index: AQHYvUN/KKgAm1RVgESUCJeBYUFHMK6yViWAgCcBS4A= Date: Mon, 20 Feb 2023 22:00:04 +0000 Message-ID: <87mt58yp3w.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-6-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AS8PR03MB8665:EE_ x-ms-office365-filtering-correlation-id: 046ddfb3-4ea6-41ea-0c01-08db138dd2b0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D5NdbonsaZdnLBFtCOZolli77iiYrAggBN/uIJSsXi9jnEyFAV7GfE3YDI5WKSS2Pf9Z05JmjxIBqE1NbRMfuFynLEqKRNm+0yMtMeOtmluBwM4PujmC6VGaTnZygtTt0W+Q3rIHm8pWohAjtHUSwvoxXmA2Ze/+AzAvt3gMNvcP8B1pCWZhSIqzw92EOkeemRZ7ZSMq08hsae/iZzfVscN2I1lJBB+ixCIqc6Cpv/1ayThOQGWfaHbPYi6yFp6KuyyH6C41GBmV5Lntn//5Y2VxXTS16hltQXqtekZ+EH6y1MujHjuDs1zVNhAgPbzTh+a1zpj1B2Nr4mGFz0RbTO8EWgAiwJlvPxdfu9/V59eNXKXv3r3Jfh4m9yUCpA5Z1iLOh0kxPBrStgU1EW4svIOkZXaWeg6d7g93XUAiXawsKA+bKfWrpLCN1JmBKayuWh0Z4mweLjKABsK9DVjgbK+Ys8TmGV3+ev8SRz7+Z4o01emQBpLGz5DgflWl7YbvQ8bRIngGPUboLQrkgsx3FKxSHP61186YkGxnnKdGMu34bSVzlL6sk43qQjUgqVvftMNk/66PC/Tm0gQ6xfrxkaBRn8JH2LP9EZrO6oHnh0Eo15FQNcffjlyZmU1f0Erx/L0jDcNQ1fmc9wMIO2cPH+dlEwQ4JzIE2hItggrWNAC9cgZv6+s+nUzUDk8EftD95O47FRK2M4KqeHk5hKr14w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199018)(8676002)(4326008)(6916009)(64756008)(76116006)(66446008)(66556008)(66946007)(6486002)(66476007)(54906003)(7416002)(316002)(91956017)(8936002)(41300700001)(36756003)(86362001)(38070700005)(71200400001)(478600001)(55236004)(38100700002)(6506007)(186003)(26005)(6512007)(2616005)(2906002)(5660300002)(122000001)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6SDngIJ4bkyYM/5sY7JeNkgGExs9gBMIoscCwbWxhMPWOewQLwH02gfIJV?= =?iso-8859-1?Q?od63w11VuAswNFIEMjiOO+9S/yUVCN2sDcvk0SPyCHKf6qW3StZ1eVXs5k?= =?iso-8859-1?Q?gcyHWvaQ86nvWeVHiDkBNhvvOAd67/Aj3KuvUnj58Cu0ZafHFbFRaYW3++?= =?iso-8859-1?Q?ZG8OA1XiwXNriC12s6KmmEdALs8N6qht84o+ELDpySGkNh7p0deFTJo+eA?= =?iso-8859-1?Q?ijdvcFuFmZjwgf9v+DNLKR6L2QYQOGl8eTaJyNhyKncFJyZ9wFKEsVvqnl?= =?iso-8859-1?Q?Avs7idOx28QyxzbO5i0wonXKSykrv5fgGuPn9drtQlQiq/hGh1uwjO5+HC?= =?iso-8859-1?Q?fw0Inp/ycPY5OMwK5r3DXUpD4WqjRL8q54+4U1U+UEFJQ9eBveHKa4PCbI?= =?iso-8859-1?Q?Sol7Uw/HLHEgsGdIPtrxoV0npd2apoXHg2ztLtz4UY+C7dyk+yOzYcGGux?= =?iso-8859-1?Q?klTuV3RORIOdYCi68a1pf3290XPsdufSv/rCuBan7ds5Xz7ZFQxj07axNh?= =?iso-8859-1?Q?SzUdYx4LRbWVo+cevB7XQe2wxsbi3VLAnZ7f8+I2WKx9rg6cq4t3rggXE+?= =?iso-8859-1?Q?vK989WYa30u+f61Z8TXdhfgGU9LHAbkW8TrtDMuozEpOiWAgv20agi5xei?= =?iso-8859-1?Q?24ZHWZgF2WHQG5Qi+Xd9Um3HYW3Xko9AMyaCMcqHb74FyOJcd/LklZnZEI?= =?iso-8859-1?Q?+VBsxjtCkvMFKdrlLhNbNe+eIMyAJ6JjtpbN4TUSB2+/H7yd3LuKT30SZJ?= =?iso-8859-1?Q?RJDbTs84rBLRkJRqesfuqMNrW4hq9Lje7AfsbPYOxddn93nv39KQ3WlhI9?= =?iso-8859-1?Q?+v415WL/UMLGMB9S0+jJk4AtUx6/BOTG24EGTNflhCQExYiKBm7GuDQlph?= =?iso-8859-1?Q?dQmNxayYcPBjdWdTpISUy7hzLUTIj5N2D+9s8yMFKbKy9j0ZorWpr/Zhbv?= =?iso-8859-1?Q?0OgAVzlntoQ366AKprhZi5CiD9+l1s9xREO9E4xjg0mAmF0Vep4mA4Ekyc?= =?iso-8859-1?Q?Ct5QCV3xvCRX1blBsdU/kWlT4wO2O0geA9+fCzeBsSiPNuauBu4gFXaYr8?= =?iso-8859-1?Q?bLpgPMRrme1JIbXtf2qBvcKKXui71XhdhWZeSUE+dzgGFJOik9sL5/4xpS?= =?iso-8859-1?Q?kMO5dlESgO752Bm010sHxySkq//kskMzM/DniVYg2kwGAVsEPr4ywonynm?= =?iso-8859-1?Q?aNq4X5kW+juU8aPt0MpYd+kaYVGa9gGB/RMRadG0woPlt9kK0mVdLZL1Gh?= =?iso-8859-1?Q?ui9JaLbT9I6Ss5ujWXq3wVMMTYZeS5GcDthZHhtRHsnpewiyhiMYaRYQg2?= =?iso-8859-1?Q?toaxTNvFYfTym8CIzDFoMrUCid93HRzC0l3Kak/2bJtfQ0krIkx2Vn14Yx?= =?iso-8859-1?Q?q2uAABL1v1NfFsLk/i0kz20q6b8LhBURkGRYrsep9dxzWl6+JA1hcSk3ki?= =?iso-8859-1?Q?eGV8qX4iYWe9Kd1Di9pJusEtncbT7Xp2BvyTw6vYFexC8z0rHAIxOlbM4W?= =?iso-8859-1?Q?e2AN4s0fyeEhQId7TIw+TdxCoQTCqmio09nsKS5ZhUjlJMjjW2wX1OalTn?= =?iso-8859-1?Q?8E4Gj7YUoz5CZ2hXcmfktiJs79fBIUHn68lELnIfpfFi8/NGYkTXgN3/zf?= =?iso-8859-1?Q?rU7u9A+Juaexjyl2BFH0OrhwGGW5ME4H/BG/MXMRgZ6+pRluqfo5W+/g?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 046ddfb3-4ea6-41ea-0c01-08db138dd2b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 22:00:04.8813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gY2qal6wdAz+paJ9I+6XkcIaMhEfvhDBCuoMGO2OvMVyKsSCkEjtNHrKzh9Ot2f8j0ZMp0vx9uJ93t1RRByd7qao/pT3F/YQkboJzKwtXvU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB8665 X-Proofpoint-GUID: OKLpYLnCpIl0r3rmIsJcJLdcnHuIj7yN X-Proofpoint-ORIG-GUID: OKLpYLnCpIl0r3rmIsJcJLdcnHuIj7yN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_17,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200203 Hi Stefano, Thank you for the review Stefano Stabellini writes: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> Prior to this change, lifetime of pci_dev objects was protected by globa= l >> pcidevs_lock(). We are going to get if of this lock, so we need some >> other mechanism to ensure that those objects will not disappear under >> feet of code that access them. Reference counting is a good choice as >> it provides easy to comprehend way to control object lifetime with >> better granularity than global super lock. >>=20 >> This patch adds two new helper functions: pcidev_get() and >> pcidev_put(). pcidev_get() will increase reference counter, while >> pcidev_put() will decrease it, destroying object when counter reaches >> zero. >>=20 >> pcidev_get() should be used only when you already have a valid pointer >> to the object or you are holding lock that protects one of the >> lists (domain, pseg or ats) that store pci_dev structs. >>=20 >> pcidev_get() is rarely used directly, because there already are >> functions that will provide valid pointer to pci_dev struct: >> pci_get_pdev() and pci_get_real_pdev(). They will lock appropriate >> list, find needed object and increase its reference counter before >> returning to the caller. >>=20 >> Naturally, pci_put() should be called after finishing working with a >> received object. This is the reason why this patch have so many >> pcidev_put()s and so little pcidev_get()s: existing calls to >> pci_get_*() functions now will increase reference counter >> automatically, we just need to decrease it back when we finished. >>=20 >> This patch removes "const" qualifier from some pdev pointers because >> pcidev_put() technically alters the contents of pci_dev structure. >>=20 >> Signed-off-by: Volodymyr Babchuk > > tabs everywhere in this patch > Oh, yes, sorry. I asked sometime ago, and want to ask again: instead of adding EMACS magic into each file, we can put one .dir-locals.el file with basically the same config in xen/ directory. This will accomplish two things: - there will be no need to add EMACS magic strings into each new file - the same config will apply to files that do not have magic strings. Files with different coding style rules can be filtered by code in .dir-locals.el and/or by strategically placed files in sub-directories. I am happy to hear maintainers opinion about this. >> --- >>=20 >> - Jan, can I add your Suggested-by tag? >> --- >> xen/arch/x86/hvm/vmsi.c | 2 +- >> xen/arch/x86/irq.c | 4 + >> xen/arch/x86/msi.c | 41 ++++++- >> xen/arch/x86/pci.c | 4 +- >> xen/arch/x86/physdev.c | 17 ++- >> xen/common/sysctl.c | 5 +- >> xen/drivers/passthrough/amd/iommu_init.c | 12 ++- >> xen/drivers/passthrough/amd/iommu_map.c | 6 +- >> xen/drivers/passthrough/pci.c | 131 +++++++++++++++-------- >> xen/drivers/passthrough/vtd/quirks.c | 2 + >> xen/drivers/video/vga.c | 10 +- >> xen/drivers/vpci/vpci.c | 6 +- >> xen/include/xen/pci.h | 18 ++++ >> 13 files changed, 201 insertions(+), 57 deletions(-) >>=20 >> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c >> index 75f92885dc..7fb1075673 100644 >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -912,7 +912,7 @@ int vpci_msix_arch_print(const struct vpci_msix *msi= x) >> =20 >> spin_unlock(&msix->pdev->vpci->lock); >> process_pending_softirqs(); >> - /* NB: we assume that pdev cannot go away for an alive doma= in. */ >> + >> if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) ) >> return -EBUSY; >> if ( pdev->vpci->msix !=3D msix ) >> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c >> index cd0c8a30a8..d8672a03e1 100644 >> --- a/xen/arch/x86/irq.c >> +++ b/xen/arch/x86/irq.c >> @@ -2174,6 +2174,7 @@ int map_domain_pirq( >> msi->entry_nr =3D ret; >> ret =3D -ENFILE; >> } >> + pcidev_put(pdev); > > I think it would be better to move pcidev_put just after done: I'd love to do this, but pdev is declared inside "if" block while "done:" is outside of this scope. I can move pdev into outer scope if you believe that it will be better. [...] All other comments were taken into account.= From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:01:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498398.769252 (Exim 4.92) (envelope-from ) id 1pUEDr-0005E2-Q4; Mon, 20 Feb 2023 22:01:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498398.769252; Mon, 20 Feb 2023 22:01:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEDr-0005Dv-Lt; Mon, 20 Feb 2023 22:01:23 +0000 Received: by outflank-mailman (input) for mailman id 498398; Mon, 20 Feb 2023 22:01:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEDp-0005DD-Ji for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:01:21 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ad5d070-b16a-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 23:01:19 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ad5d070-b16a-11ed-93b5-47a8fe42b414 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676930478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfqBIrdn5rWMQ3+U0cKrDyXxSebET4rDLTATkZ1AnaI=; b=qLliU2OdF3CeCWdUu/vgg+84f2MEcYKOprom+1N3lo3YmqUY2WVd/egbgwUd54ueHzc75A MoZxZhkJi9KCH/zGuNwzYbZpsa4xsC9kNjUPSpzhB//fz5DNhl4SHHro5KqvRJaeIQ5IRc /8DIrz0rbH0cJB/Cluoq5OUIiJQF0E6A+AiTZFPrpT6jLodbuFZul1h9b5X694jV76zi4y OfP8mzpQmGt7NkjDn1auLZjcTgetZflhWDUyqNjWRjegKWRJM8P6QXZ5Rcy2LGy/1uqB3+ W19YfkHtA3ahKQUADvW9bNOe6rTnG9dD/+w0SnT/Xb/F5JZoDTKXSJMcpXzbsw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676930478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfqBIrdn5rWMQ3+U0cKrDyXxSebET4rDLTATkZ1AnaI=; b=yEZzRQZzZkp6F4iyf7NMpiysEygey1YR2ob12Bb9ctIazuHEPk6p4wSzkSdVo8P1IBuHRZ UYBZUPspScc/R2AQ== To: Krister Johansen , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource In-Reply-To: References: Date: Mon, 20 Feb 2023 23:01:18 +0100 Message-ID: <87h6vgov2p.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain On Mon, Feb 20 2023 at 09:17, Krister Johansen wrote: > @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > - /* tsc_mode = no_emulate (2) */ > - if (ebx != 2) > + if (ebx != XEN_CPUID_TSC_MODE_NEVER_EMULATE) > return 0; > > return 1; What about removing more stupidity from that function? static bool __init xen_tsc_safe_clocksource(void) { u32 eax, ebx. ecx, edx; /* Leaf 4, sub-leaf 0 (0x40000x03) */ cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; } Thanks, tglx From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:12:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498406.769263 (Exim 4.92) (envelope-from ) id 1pUEOQ-00075T-P7; Mon, 20 Feb 2023 22:12:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498406.769263; Mon, 20 Feb 2023 22:12:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEOQ-00075L-MF; Mon, 20 Feb 2023 22:12:18 +0000 Received: by outflank-mailman (input) for mailman id 498406; Mon, 20 Feb 2023 22:12:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEOP-000753-EC for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:12:17 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0bea1c1-b16b-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 23:12:15 +0100 (CET) Received: from mail-bn7nam10lp2102.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Feb 2023 17:12:08 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6121.namprd03.prod.outlook.com (2603:10b6:408:11a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 22:12:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 22:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0bea1c1-b16b-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676931135; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=0yTJzDsMslstLixdZonO67454OOLovjj86hvtJJqeEo=; b=Im2HkCl2U8XmFYervE+Zw/GBxULpIXZclh08iNO334wZF2xD3GI9H8qE vRKzUFqAU1szxWZ2n+2W67EKoewOQhX++xfqfGbGNxrmkveDxmbYvK5aY VJ9q5q/g/CFE8Gc8b2xNUvXUO9rKaX4N2bhbkLA/lnlH1u7MU5n1ntohY M=; X-IronPort-RemoteIP: 104.47.70.102 X-IronPort-MID: 100222667 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:3pTfq60J9Plgl4VLHfbD5elwkn2cJEfYwER7XKvMYLTBsI5bpzVRy mROWW7TOazeYzfzfdF0adu29EICucPSzIRgHFBvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfB1xnr dc7Ciw0Tk6Hp72U/o2LdeVHr5F2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFYZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjANhITuPmqZaGhnWM+V4YGA87WWGxpMCI2kiAAvB0F xwLr39GQa8asRbDosPGdxelumyNuhkQXMVZO+I/4QCJjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLv4Ubnh/JCNF5H8aIYsbdHDjxx 3WAqnc4jrBK1coTjfzjpxbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U LE/s5D2xIgz4VulzkRhnM1l8GmV2su4 IronPort-HdrOrdr: A9a23:9WzPLKE2WzsC9iXDpLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI= X-IronPort-AV: E=Sophos;i="5.97,313,1669093200"; d="scan'208";a="100222667" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeTbhuJo0ZwfJFjTlNSXz5XcL+diBkaUS0eSC3HUCVydJlVNbp5iTa2Q/BiBJOwsLGTkcl3byYH7KIffsIM+jh7cMffeGrW3g3vvwi4prcx+QvihC2JRUZwjFwrMabcLh6QyLGySDJtGL5htTDUtCg3GGLr1l6L25Q5Vno0SAUO3knCtBDuUNJfkaUH6hntWY93BBgjLKXtLE3U4V5dK40YYeEAD5wZH+Vo3lw0xYMdOksECMbHaQrptNATe4R54WUZzX4CMl+mCIzuZ+Wlx0eIO4hr8fwAXtJNumCHqwQOU/A5UUnxehpCAgcPfTWCwYyYlLFxNh1LYvgvfmbF9fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CZ9xh4uPgpeeBH6akqmJ0HUOpbOWuDJAv/CjYdHLhU=; b=L1dSQQqLo/P71lc35dsosRrElOLhornx7SD66d2PGpT2o8sg9EGHrAUBGnBzDkgN/aRcY9YISjHgMQM1S4ZeFIbH6e5TVSlz1dDoJRp9c2PF5qYGeNfBgmUXONmJ8WEqsiGPm5mwpxe9PUocflz4cMEtVv//tCYWbX1iXYJtY5bfDfGf/YIXOGpsFcijiBKE2mQy+59Ydz6XznWVu6WohZgc8MKwwi/Xzf7cQzZxZlx5SK7KZsTT29hNCu6mx3TgOfVW5kxLh2TDOLgtx+moJ1nTJu495kBWrPXWzrq2ke/XHqriQesELRQQ9UuFoG7kkaKFQispUsV5f7dn5JjE1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8CZ9xh4uPgpeeBH6akqmJ0HUOpbOWuDJAv/CjYdHLhU=; b=V+6V/iCpck9mXDGXnmtR0K74SaBR45BzTGTF9uOkvSo9g/R+pU9CpqxmjQzRV03P6BfG1n+2BnJTVDL7VKX4RizHLtCWQ7Czf6B1Awd+q0nKVQMFvegFJQQy1vR6GCl/pNeOLGMnEYT5Agwex0Rl4+JhAIYECl9ujUbjJScX1Xs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> Date: Mon, 20 Feb 2023 22:12:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 1/4] x86/svm: cleanup svm.c Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-2-burzalodowa@gmail.com> In-Reply-To: <20230217184814.1243046-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0150.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6121:EE_ X-MS-Office365-Filtering-Correlation-Id: 172468eb-3e8f-4f59-027b-08db138f8099 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jmCX/RE8fQzBgITAr7/E606bYgtriBRyC1zPd5OwkjScaaWIquavG/V3bp07OY9E2Bdwah0DtHry9TpwrDHQU2BfdfjTev2KCeWK87VdhFqZQkyIDaVB5j6IpIXitCxdGMoP2D6BxtfxumbSl1I2ZRklFklzNLZ2YpGHeu0fCXfbx+262bJQSSp4Gi4TmSvzjEqeOZ3SdF/3MizQ84pnNGdgCBz0oslqOgZoLgV+gQOd/w1DSMm3zqW1MKIC0sSK0OfydYXQjEHXuMcLj3HXjDJkFIvCb9wJhmh16d2kwq/6+zoW3HPLv/0PTC0+HzPIT51420wZuSQuhtXcUafu2mxKBnl9BH7EL9/fvQKkR0p+LZmew53fL67cjnSYhnsxc2BFRrxVLoU5JbH+XBjK4jIYwhJP6WhmO2/+IuPL9Fl+Rl9Senn9opbimSLN0OaFkHDtigI12KPl2CktHkfpmoSt8E00CdxgrRrBs/X/fZoT/SVmRMZi60grg1n4ud+yKs/AIHQYTPnRdZsmUKNE9KEcGYTpj70FVeYMjkSQDQOLOCeO6ellLyXktIs0jfkQrNlmweJp9bEGLF2vdHLO8c8GX5x/kx8asPOgCGsg80EJQvLAqVZchCLQMV6D7qM5N1bXGxpGIU+5l/WZ5BGWfvpC7k7AenajfhneukBHdc0qusf60SZK+9W2I81FP/mUID1huIqCHxmikKdBDy3jgasOSJtAtM0tpICzAbSoHTc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199018)(2906002)(86362001)(31686004)(82960400001)(38100700002)(6486002)(41300700001)(53546011)(6506007)(186003)(6512007)(478600001)(26005)(36756003)(31696002)(66946007)(66556008)(66476007)(83380400001)(54906003)(8676002)(316002)(2616005)(8936002)(4326008)(6666004)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDl2d0NxNjI0b1U3d3JWU211YVhOMjRReW1DSXI0cnRBNWpBMDVPQUdvV1p6?= =?utf-8?B?dEdwOSttdDZRRHBDYWtJa1lHQ2RsQTExQ2I4eW5UN3pZWldQcXJ1SW9GWkR1?= =?utf-8?B?eHFYa2kyNHpCdFZrL0NSVEJoaE9TdmJSWlVDZW1UQXlnQ0g5OHRuNjRnWU55?= =?utf-8?B?Y0F4ZGczNEtyRDVJK0FDR1RlWEd2U2hTV1BDemo0YW0zMlJJSUtYZGdwV3NO?= =?utf-8?B?Y0hxUTRJWkFVMzB6VjhXbk1melRJMmJOMmRiWHovczI3TW9HM3UxZlJsVnpo?= =?utf-8?B?aTlSbzJkQlBrRkhXN0MwWVYzR1QzaWpwejZySWthNW1MZmh3Vk1UckgwQ0hY?= =?utf-8?B?dnVsWGE5YW1iQ0xPb1FaK2FKdnZvV1JjNTFJYXl0WVpQZ2dWV2ZVQm0xODdH?= =?utf-8?B?dzM3dEdTN0NRbDRuVzI2SzNXYTJiZGgyTTdObno3MXlUbzhuN3dBaE5ydENS?= =?utf-8?B?dnM2Y1h5aTUxRkRiMncxUTRBQ1dKR28wYTdieU9hU3dxbjNEQ0R4anlmYnBk?= =?utf-8?B?SDhEUGZuRTJvUzJJeXYwWllwNklBcUdKN295K1dtdFY0QXFFU1hjWkJ6a1Vv?= =?utf-8?B?dncvMklxR29vdnN5T3g0Y0RQKzZibkwvWnB3TDg3OEprSEoyM3hTTXBld0pn?= =?utf-8?B?NkVxOUIxVnBZUmhwVVVPcnpZdXFUQnRJSFhKaFAvcHFkeHNQaEtUWDZ6Vmph?= =?utf-8?B?SXRTWElwVUxBYXVmMjZ2SWd4Vkd6V1RxeHJUTlBMSm16dWxFYVhCQ2RsZUti?= =?utf-8?B?eEM5NGpJTS8rYUNDNkVvOFI0a016VDM2UmtueUhYYUg1UWl1cThXWFB4bHk5?= =?utf-8?B?VTh6S1BzZ01GNTYrTzJyaVpCYm5zVnJPenRBS2xJbnZjVW9wS25ZdEYzSnpj?= =?utf-8?B?MUdFY1lFaDY2S1k0RmRkMTFDNVh3bzFUNXhObE45NUsvV2d2cHdCaFlrWFM3?= =?utf-8?B?UnJtakFneldoY3N5eENuWmZaUW5CeWdLQVUvRkFuQ2dZbE0rdkZtRVFnRldW?= =?utf-8?B?Z0VXYU1ZS0dWc0xySWoxSWplSThQTUxrUkJlT2R0K2x1MmF1akdVUzE4bkh4?= =?utf-8?B?bE5ycVgxajRIYzRPemdRdElPVEdIK25zUmZCRnBzMXcyS2xXTWtZd0hDTGFr?= =?utf-8?B?SExIK3I1ZWV3Y0tEZ3lQVlpiL1NvS2kyRkJrOVBMV1JmYk56V29oY2U5T3Ba?= =?utf-8?B?SmQ1U0tEQmFXNlJmcEhEeXorK3lFVEx2OGJDS0tKbi9wb010ZFdWVXhZWHJD?= =?utf-8?B?Y1IzcXVGWkREYXE4Ym90ZWNvNHR3SCt4b0FtSnA3elBHWmxSeWZzSGJacTdP?= =?utf-8?B?MGk1SE8wK2pOb1JLRDNDWnVqWWJQUjBsd1NxMXkrbW9WbHFGWG1YTmM5Q2w4?= =?utf-8?B?MzEwelRwc1RxUlkwTktibTRHV3IwL0o2NG4vOE1ORkRKSE9WYmo5U1FEY0Ny?= =?utf-8?B?YW1XZG1ONk12dnZTbjB4Vm9lUm5Uc0dQOC9yQUZxa3RRRkhTc0VGYVE0aEJY?= =?utf-8?B?L2F0SGdreXpDVWRkSFlXV29XS25KMjRjT1l4OCs2MkM5dXNFdXkyczJ2cjNL?= =?utf-8?B?RWQxSFkwN1FUTEU2MVdraHRZdUdPUDVTaEd4MFYyOFJ0eU9Eem81RGJiTFB0?= =?utf-8?B?V3UwTXppQnJ1RkxqOE1kbmxDcGt4NVZRdEs3QnRGWXFwcm1BUGF1UnA0R1do?= =?utf-8?B?THNSUmxaanRFcmY0RHU5R0ZwVkQybldzdlR0L1JrVUZ0bFEzdkxpNHRSTzlm?= =?utf-8?B?amFFdThwVHFkVS9iakJmS2l5cTFhK05qc0loMDZ4eWRzSWZXN0RlVk1FY2RR?= =?utf-8?B?U1NpeFhiOStQSis5d2JLQVhDcUU2Ukd6Zmc1QU1UV3FuWGR3aGphYU5kMmVT?= =?utf-8?B?RmQrYUlEUGFzNzZIVkpHaW8xandrMjltSnQvUjluaysvWTg2U0pXVFlDd2c4?= =?utf-8?B?eUdnY3VlZVlTYnJkK2h6dm9MU2xpczB0bFNnODU5dWhUeXk2UEhjNUN6QnZH?= =?utf-8?B?Q2ozL0FBYTZPQlJERDAvSDAxUW1nQjhhTG9tUXFxNWx1bHR6RjNuWkcxWnRa?= =?utf-8?B?RURQK1FXMDBPM2MwcVFnWFRYU3BOOHdVKytQUCs1aW1meWkyczNSWGhrR3Rx?= =?utf-8?B?MXlMN2dCWm55dDN2VS95WFcxeHp5UnlHU3poVVlrcnlKNExTTTVVcFM1THlu?= =?utf-8?B?NWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3GDDJBeDkvO5IxTHt7Orldgpqz1sxGDqIflPqeRgF2dd3TEKsoYl/gkykVG3ZU7DZnlB+qnDmognJUHvuKonyr8jXGlmN0yKqhVsqwzCpwEYdK3wOjYxQxj0cvfD751IbFsgC9v9u3te9uq2sMzL2oSm1SDsEk1sc6mwmDil/cHHRRplrsn2DjulycPD9ZvLTwJYamMgm8w5dHlb7H6onxL9VggW1PIRImS5Wy7DsrulTgE1QCaXW+98mfo40FiZsp20Ea28FI9ReIIcj1RTWUrEw7RQBQg7Al1QfGofA+lA9a9u6wfjzzjd4ZL8FuOOoueHnKrHkm6cq64JlhJbm5QmTezATkToi5AyR4ZoHuyOIuWuKVR5wfhbu/bzlnxadMyfuOcQXGcIBWsnEoZ7W4mCSjz+wpGv8x+10aqoBiXm2dCqGZgSmROWUYFJf7jWLWX08EEx2xVPP2QC3j7I3iVJv+XM/o3hC3SKdxoWFHZ8MFCHgjVFXJRglwFU30AJnTU1JmbMYEKnT/jNvQr/5D7l/m7o2+8V42Eq99Zfhruld+1aAFR6TnET68GTtzBvub2hRzkFxKSmbl2CDUjIvYTOlYMltzmaAJPsMT6+xbEwxcQUcM5O5KO7v8Bnj00oD1Q0H6iZFqE4sGG0Y776ELgTSo8PR1djzSGiwHUOhE4qoOKYPouDu7pYKNDMquEHAsxxNrKcF8zgs8KR8JieANhxhX7gWD4vnKZs7IEjNp90BkIGR5Us8cBN7I5uOi9pvwv8DWt3VW4JaJKXVGpSzCOswNZ7mXv/E/9H5N0vUT+I7DctIfUo2/DjuHb8f5RVk5gG3Vgj/feBxpsthNyawOVXuZ5itH4kjFJtko9JGWg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 172468eb-3e8f-4f59-027b-08db138f8099 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 22:12:06.5725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UdxZlWUFj8LRAZv/yiQGIeYCwsIsVwf8SpCwlbYeQslwJ+sXCY7sKT2jW+hRu3UEoW4i/mmBe1XzRzrUVxmAPP2E9qxZCIxVZC0x1mkR84w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6121 On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Do not include the headers: > xen/irq.h > asm/hvm/svm/intr.h > asm/io.h > asm/mem_sharing.h > asm/regs.h Out of interest, how are you calculating these?  They're accurate as far as I can tell. Looking at asm/hvm/svm/*, intr.h itself can be straight deleted, svmdebug.h can be merged into vmcb.h, and all the others can move into xen/arch/x86/hvm/svm/ as local headers.  None of them have any business being included elsewhere in Xen. > because none of the declarations and macro definitions in them is used. > Sort alphabetically the rest of the headers. Minor grammar point. "Sort the rest of the headers alphabetically" would be a more normal way of phrasing this. > > Remove the forward declaration of svm_function_table and place start_svm() > after the svm_function_table's definition. > > Replace double new lines with one. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:30:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:30:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498413.769274 (Exim 4.92) (envelope-from ) id 1pUEfJ-0000g6-DQ; Mon, 20 Feb 2023 22:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498413.769274; Mon, 20 Feb 2023 22:29:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEfJ-0000fz-95; Mon, 20 Feb 2023 22:29:45 +0000 Received: by outflank-mailman (input) for mailman id 498413; Mon, 20 Feb 2023 22:29:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEfI-0000ft-Ao for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:29:44 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 118c2b6c-b16e-11ed-933d-83870f6b2ba8; Mon, 20 Feb 2023 23:29:42 +0100 (CET) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31KHN8NS003537; Mon, 20 Feb 2023 22:29:37 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3nvd0hgpas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 22:29:36 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AM7PR03MB6184.eurprd03.prod.outlook.com (2603:10a6:20b:141::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Mon, 20 Feb 2023 22:29:32 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6111.018; Mon, 20 Feb 2023 22:29:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 118c2b6c-b16e-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lN8HYgBW2xXMKFN5iSiIovwYbEbJMdmG8f2oynVewZYC0HLyVJXiN+PKN1XeSPE4uIku885xtbWLvdgF0RkRNVYCSIEnjAxkD92coeRUU4lu1IWShwfqSWISQJGGEF6bToR3Om+9NxcMSdFGy/ENzLsXohdaH51i9Ykwea9VASJCgUUTqW/MohLCicwCJn/9CowoOfD062vvkKJNQjXcjOXIyc9OVHzjEuye7xEupj3KfkkU7V1FFX9ym5wF+4G1pAy+oBL33UQbK/HjsppiVbyJsnFzNZ97rdm9SEIr6jSHVV6dYc+3CbjUzrEiSqdIL0Rs+bYy6UhPX5wZQt8CNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rgR3Iu1Rr9Nu0FdGhM/WZ/b0x1eHMMrtpWQ4dd8r63Q=; b=AG62hJaolsLJ6lmEEGu2Ea6JfuO0XzkClyEvRd7S08D3j+yjlke6xZLzzYJND29ffNKHm2zQJ92NjtHMeNQHekdE2WWwhyuTKWP5LjkrmccF6lc+sJcOCpymhl6GVpPCC7Q/cc22MfPaEDt7rw7052WpOKnpLeii8c1+t+mDY5bHFH6rX+DkLdehAIx3x4z2kMcGGQxh8U6c5jVR7nhySw0tWfvDzTkpMnR1EYtFW0OhhIAcpHEqf49Reg49Szhe3ihCCsrrejtf23Fg0yoZSaJV7lpLSYBj7GI8zije5vY4siCxqUWPtPQOK8I5Q0ENJU3pS6S5XQS1BrxGdB3eKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rgR3Iu1Rr9Nu0FdGhM/WZ/b0x1eHMMrtpWQ4dd8r63Q=; b=XBlAYr3rwbKrpGoc+3ZJeCD4wXXazBOvZ9bBuY2iF7fPK4fpZYMlOxIZejBJmJAUiePaGzp+wFmC5YXV1vhQj51zC1Y2sCFyaeJOCUDh6j7rULGJcsfND/SxmPBOusj1PVH89Lp2toPMctcryw8h8KrgW1+8HozlcTPhZLv6IyJ9C/HmBRusww1MEbHR2a6djtjEnMr9Hpb3OMnpv/EYXLsbq5jHiUFqSgwRRK+hVt7BosctPTlYEwThaBiYVPpS4teqn7SeBC0K8FNj8OlcvlOVDNAjZHK0s11XyDnZhxX5yu2ZhxjA+HaAzn7czdFroFL0CxLU4XANJpsC4ekknA== From: Volodymyr Babchuk To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Paul Durrant Subject: Re: [RFC PATCH 07/10] xen: pci: add per-device locking Thread-Topic: [RFC PATCH 07/10] xen: pci: add per-device locking Thread-Index: AQHYvUN/+u7dK30KdkO8lqgvo0jPya6z7CCAgCWN6wA= Date: Mon, 20 Feb 2023 22:29:31 +0000 Message-ID: <87cz64ynqs.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-8-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|AM7PR03MB6184:EE_ x-ms-office365-filtering-correlation-id: 0b9bcd88-38a2-48ba-637f-08db1391efe3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OdmpZP6XG5yMzr5gK5G3IU9fmdt2Xrn6uZ0Fzf0ojZMMLUbDm/1vMOCMjPWD/yVm026P698SpfyVyXu//aCsRHpOxFS4tbjrLvB8NL2yOcxRFA5kBQyx8CeBjpX5fwAqIlapv5FaTk5csSX2jXHf+WjU54eCSwqsR87zdbuMfcvaARRUFrKaYBsEOGL1uQLeo/rvcpxKI/rvvf0XWyfor3pPL+93F0EJQIJo0vBhq3wj1Kx4mIHme5Q9r1AYdJNXMvoKDXVQAT5JvWVZ3fNv6CH7kJLOqsX5hVQTVaGvknZwbnCXvl4qZbogPma+syPpT51TiwGCxkbDG10OjvT8/kS9iLc5Wq2Nzr9s5G+EBFIRtVO9M9THJlvYpnPTwzU8HTHPjOX4+q+Zb9DM5Nh0PNj88DJ+N+/0Y9bznxc8wrxBnWi9+NYke9wkwJKt1gZZAvP/wa3wNM8CU8G6NstBIPgVEaQ865nXdRPZF+vgoKikZ/7kHVQE5kFuUwBbWvX8zTbTy5cfKZobJTk360hPCakZJDD8NkMv1xr9GZYWTwr37cJOJca+NUNphK2H9XGBlHSHpS9/fbLgGz5a30BF5iXtKXpV9gwxvKyuxjdoUNtvTCYBHLr11/OaF427vBCWWiUoWnYdYVQpR7fVeozWuVdhAu7sm+UQr+92D272b6IfXlIIZNNgr+ARUnf40RV3AbOXCsbzubTMFRjPTyudfg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199018)(122000001)(38100700002)(2906002)(8936002)(5660300002)(26005)(6512007)(54906003)(76116006)(41300700001)(83380400001)(91956017)(38070700005)(2616005)(36756003)(6916009)(66446008)(8676002)(66476007)(66556008)(64756008)(4326008)(66946007)(6486002)(55236004)(86362001)(478600001)(6506007)(316002)(186003)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GqIC3WT7Z5iE0REFMyNlcA2pM09+cZIeUPs2DpEUNwR5ke1ZoyGK+tdDl0?= =?iso-8859-1?Q?2v6EgjiQCHe3ICJgoRjyaPL1aAH/pgM84aoTJxZ2fl+UG0B9U6NxyH6mF6?= =?iso-8859-1?Q?BZXVv9vKaEDsROxVW8wnQQfYNlYcd3fYcAzEZsrwhHKLAeZEZfksg/i9W8?= =?iso-8859-1?Q?Rh84olG2JEXkxXyaGydf46Oj6Mw5oGVXg6j9e1V0fIIYOdJpugGQcHqcG9?= =?iso-8859-1?Q?avByIgwcZt1TnR4nXrUfpYe5chwMWSoFaklRNapIM5EQJM1HenPjx/cEio?= =?iso-8859-1?Q?X+ycbCUC4LnzF3+JmEiYoUAUl5TwYoL9gze2sUnJ6joZNPT9d8yBhx6tf6?= =?iso-8859-1?Q?vo55IvrstLf1xld8g6yVTJzLD/Xa6f7Mt0jmQBQfnkBeZ83IFaGZC7afIR?= =?iso-8859-1?Q?eSEJB+CW6u7rEqWzr72KKt+Sdit+da1DCvjlgSWpJ6Ov0vtLgCcciLGnGS?= =?iso-8859-1?Q?n4puYrHWOVKkzPt7kNDTWXeVeMTYPvGkEcU/T4Jbdys4MJSY5joapMkoRo?= =?iso-8859-1?Q?LNmEyYhE1eP4f63+Zz0wRsT8624JIm0KuvCmYI0mzT2BxGrBASThgzALmT?= =?iso-8859-1?Q?gfsX6aZcHe6vSTXefUXRItVeqikySyPof6RGLAPkj/vcVpIyRYfqYiBPIQ?= =?iso-8859-1?Q?En6oQB4BEASz/RJ8nAjkSH2uXP0LG8nilqjVIBgqGnEKYG4ELDNjPODFVR?= =?iso-8859-1?Q?Co8V/OQI7rkO4kuHAyhxjuTQt64YIwL/iSUj/hBDuaP29j1OoyPAZbreFJ?= =?iso-8859-1?Q?h/75+C+HmNZkEGnRkYwYk+qwbI0GgktE/h94bgiQK5hBjzjLz76YT7xvAl?= =?iso-8859-1?Q?tH3Mh7TJiMUivBtXE3/yPzvtEesAVbpov9wMm121FiZQWUVKuDRax7TqmB?= =?iso-8859-1?Q?T+qujpWq5kK18IS1R16FsBGUIfcgp5vybv1dRMC+f4rmkv9OBT/62sIvv/?= =?iso-8859-1?Q?rw0VY5Oy7tKk7XDr402FzAXfWQa8eFUTXG0zRIqxx2mMfF43wHxQXMC/L2?= =?iso-8859-1?Q?N4e3YVqFLkteFOqPPlZM4D86p+LGr8/Znw3UOBuulMsEbDMrHl0pVQURGZ?= =?iso-8859-1?Q?M90e7q7gmdMWpmdG4zVJr72YzM6CpiZ6b//j/KfJPE8m4jZumJFWWVxk2G?= =?iso-8859-1?Q?VDgwLyMjPCOb/QP2cmEX6TBvj1KPWtvx6aQ5+3R4DJLQtiEeK3jzUH1gvW?= =?iso-8859-1?Q?dgQy+Vu5KAmoWETPjybOegBtLFiP8DuKfAy1LTdJshEN3RnCBiVjcYmsDT?= =?iso-8859-1?Q?jxlgw0+RZxNOoivqCJEsjgC8unu8SYWVy5HGmiQvpvoAzVD6znQbT2G2fH?= =?iso-8859-1?Q?DzD5KHHucHT0zwstCCc5wkYuiGs1RDcQNqxHWxA9L78i1mlCnr86Coj2Kp?= =?iso-8859-1?Q?WsuVb4oLECfxyZRgmH0TIJdxIFJhHaTCb61ZB8vS1fmsct4Jn9RxHJ/QAR?= =?iso-8859-1?Q?KBsuTn3ShvXyxLGRjbofOKZi0O4p1Ocq2hXEvGZvAaJ+rKVZPrcVopCd1v?= =?iso-8859-1?Q?M7+1sBKKGGtVfXvvaPBuDR2ZenlnaQbCEYWj7yflW7zHRu7Lgr78KaydSX?= =?iso-8859-1?Q?WgIrHSnhCty4VvbanSlSBf7sFTuQumxF0OZJwuneZ/IKV0UspBaxY4FC1q?= =?iso-8859-1?Q?bK46CgNMfhu/XwIoQJ4eAzJe2XiBS7fpcHFfOyNaYaOqkLa4TLAJUrmA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b9bcd88-38a2-48ba-637f-08db1391efe3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 22:29:31.8430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Ruos/Cnb+sfY0u63BS5H9PkbWMbtmkjs0Vv1QFbehP1vhHRUyMcdyiv0tmJP8iJF0D3tTzBAjU3saQyu1HDzGkjfL4KQCcLezTubCjjVjk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6184 X-Proofpoint-GUID: fbdF4JrvU72T7nBP76jQGx368ldgYx3N X-Proofpoint-ORIG-GUID: fbdF4JrvU72T7nBP76jQGx368ldgYx3N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_17,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=931 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200208 Hi Stefano, Stefano Stabellini writes: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> Spinlock in struct pci_device will be used to protect access to device >> itself. Right now it is used mostly by MSI code. >>=20 >> Signed-off-by: Volodymyr Babchuk > > There are 2 instances of: > > BUG_ON(list_empty(&dev->msi_list)); > > in xen/arch/x86/msi.c:__pci_disable_msi and > xen/arch/x86/msi.c:__pci_disable_msix which are not protected by > pcidev_lock. However list_empty needs to be protected. (pci_disable_msi > can also be called from xen/arch/x86/irq.c where it is not surrounded by > pcidev_lock.) I checked all call paths. pci_disable_msi() is called from three places in xen/arch/x86/irq.c. As I can see, all three are "protected" with ASSERT(pcidevs_locked()), or am I missing something? > > Given that they are BUG_ON, I wonder if we could remove them instead of > adding locks there. It would make things simpler. Well, I will be happy to remove them, if there are no objections. > > >> --- >> xen/arch/x86/hvm/vmsi.c | 6 +++++- >> xen/arch/x86/msi.c | 16 ++++++++++++++++ >> xen/drivers/passthrough/msi.c | 8 +++++++- >> xen/drivers/passthrough/pci.c | 2 ++ >> xen/include/xen/pci.h | 12 ++++++++++++ >> 5 files changed, 42 insertions(+), 2 deletions(-) >>=20 >> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c >> index 7fb1075673..c9e5f279c5 100644 >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -203,10 +203,14 @@ static struct msi_desc *msixtbl_addr_to_desc( >> =20 >> nr_entry =3D (addr - entry->gtable) / PCI_MSIX_ENTRY_SIZE; >> =20 >> + pcidev_lock(entry->pdev); >> list_for_each_entry( desc, &entry->pdev->msi_list, list ) >> if ( desc->msi_attrib.type =3D=3D PCI_CAP_ID_MSIX && >> - desc->msi_attrib.entry_nr =3D=3D nr_entry ) >> + desc->msi_attrib.entry_nr =3D=3D nr_entry ) { >> + pcidev_unlock(entry->pdev); > > code style > > >> return desc; >> + } >> + pcidev_unlock(entry->pdev); >> =20 >> return NULL; >> } >> diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c >> index bccaccb98b..6b62c4f452 100644 >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -389,6 +389,7 @@ static bool msi_set_mask_bit(struct irq_desc *desc, = bool host, bool guest) >> default: >> return 0; >> } >> + > > spurious change > > >> entry->msi_attrib.host_masked =3D host; >> entry->msi_attrib.guest_masked =3D guest; >> =20 >> @@ -585,12 +586,17 @@ static struct msi_desc *find_msi_entry(struct pci_= dev *dev, >> { >> struct msi_desc *entry; >> =20 >> + pcidev_lock(dev); >> list_for_each_entry( entry, &dev->msi_list, list ) >> { >> if ( entry->msi_attrib.type =3D=3D cap_id && >> (irq =3D=3D -1 || entry->irq =3D=3D irq) ) >> + { >> + pcidev_unlock(dev); >> return entry; >> + } >> } >> + pcidev_unlock(dev); >> =20 >> return NULL; >> } >> @@ -661,7 +667,9 @@ static int msi_capability_init(struct pci_dev *dev, >> maskbits |=3D ~(uint32_t)0 >> (32 - dev->msi_maxvec); >> pci_conf_write32(dev->sbdf, mpos, maskbits); >> } >> + pcidev_lock(dev); >> list_add_tail(&entry->list, &dev->msi_list); >> + pcidev_unlock(dev); >> =20 >> *desc =3D entry; >> /* Restore the original MSI enabled bits */ >> @@ -946,7 +954,9 @@ static int msix_capability_init(struct pci_dev *dev, >> =20 >> pcidev_get(dev); >> =20 >> + pcidev_lock(dev); >> list_add_tail(&entry->list, &dev->msi_list); >> + pcidev_unlock(dev); >> *desc =3D entry; >> } >> =20 >> @@ -1231,11 +1241,13 @@ static void msi_free_irqs(struct pci_dev* dev) >> { >> struct msi_desc *entry, *tmp; >> =20 >> + pcidev_lock(dev); >> list_for_each_entry_safe( entry, tmp, &dev->msi_list, list ) >> { >> pci_disable_msi(entry); >> msi_free_irq(entry); >> } >> + pcidev_unlock(dev); >> } >> =20 >> void pci_cleanup_msi(struct pci_dev *pdev) >> @@ -1354,6 +1366,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> if ( ret ) >> return ret; >> =20 >> + pcidev_lock(pdev); >> list_for_each_entry_safe( entry, tmp, &pdev->msi_list, list ) >> { >> unsigned int i =3D 0, nr =3D 1; >> @@ -1371,6 +1384,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> dprintk(XENLOG_ERR, "Restore MSI for %pp entry %u not set?\= n", >> &pdev->sbdf, i); >> spin_unlock_irqrestore(&desc->lock, flags); >> + pcidev_unlock(pdev); >> if ( type =3D=3D PCI_CAP_ID_MSIX ) >> pci_conf_write16(pdev->sbdf, msix_control_reg(pos), >> control & ~PCI_MSIX_FLAGS_ENABLE); >> @@ -1393,6 +1407,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> if ( unlikely(!memory_decoded(pdev)) ) >> { >> spin_unlock_irqrestore(&desc->lock, flags); >> + pcidev_unlock(pdev); >> pci_conf_write16(pdev->sbdf, msix_control_reg(pos), >> control & ~PCI_MSIX_FLAGS_ENABLE); >> return -ENXIO; >> @@ -1438,6 +1453,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> pci_conf_write16(pdev->sbdf, msix_control_reg(pos), >> control | PCI_MSIX_FLAGS_ENABLE); >> =20 >> + pcidev_unlock(pdev); >> return 0; >> } >> =20 >> diff --git a/xen/drivers/passthrough/msi.c b/xen/drivers/passthrough/msi= .c >> index ce1a450f6f..98f4d2721a 100644 >> --- a/xen/drivers/passthrough/msi.c >> +++ b/xen/drivers/passthrough/msi.c >> @@ -22,6 +22,7 @@ int pdev_msi_init(struct pci_dev *pdev) >> { >> unsigned int pos; >> =20 >> + pcidev_lock(pdev); >> INIT_LIST_HEAD(&pdev->msi_list); >> =20 >> pos =3D pci_find_cap_offset(pdev->seg, pdev->bus, PCI_SLOT(pdev->de= vfn), >> @@ -41,7 +42,10 @@ int pdev_msi_init(struct pci_dev *pdev) >> uint16_t ctrl; >> =20 >> if ( !msix ) >> - return -ENOMEM; >> + { >> + pcidev_unlock(pdev); >> + return -ENOMEM; >> + } >> =20 >> spin_lock_init(&msix->table_lock); >> =20 >> @@ -51,6 +55,8 @@ int pdev_msi_init(struct pci_dev *pdev) >> pdev->msix =3D msix; >> } >> =20 >> + pcidev_unlock(pdev); >> + >> return 0; >> } >> =20 >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci= .c >> index c8da80b981..c83397211b 100644 >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -1383,7 +1383,9 @@ static int cf_check _dump_pci_devices(struct pci_s= eg *pseg, void *arg) >> printk("%pd", pdev->domain); >> printk(" - node %-3d refcnt %d", (pdev->node !=3D NUMA_NO_NODE)= ? pdev->node : -1, >> atomic_read(&pdev->refcnt)); >> + pcidev_lock(pdev); >> pdev_dump_msi(pdev); >> + pcidev_unlock(pdev); >> printk("\n"); >> } >> spin_unlock(&pseg->alldevs_lock); >> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h >> index e71a180ef3..d0a7339d84 100644 >> --- a/xen/include/xen/pci.h >> +++ b/xen/include/xen/pci.h >> @@ -106,6 +106,8 @@ struct pci_dev { >> uint8_t msi_maxvec; >> uint8_t phantom_stride; >> =20 >> + /* Device lock */ >> + spinlock_t lock; >> nodeid_t node; /* NUMA node */ >> =20 >> /* Device to be quarantined, don't automatically re-assign to dom0 = */ >> @@ -235,6 +237,16 @@ int msixtbl_pt_register(struct domain *, struct pir= q *, uint64_t gtable); >> void msixtbl_pt_unregister(struct domain *, struct pirq *); >> void msixtbl_pt_cleanup(struct domain *d); >> =20 >> +static inline void pcidev_lock(struct pci_dev *pdev) >> +{ >> + spin_lock(&pdev->lock); >> +} >> + >> +static inline void pcidev_unlock(struct pci_dev *pdev) >> +{ >> + spin_unlock(&pdev->lock); >> +} >> + >> #ifdef CONFIG_HVM >> int arch_pci_clean_pirqs(struct domain *d); >> #else >> --=20 >> 2.36.1 >>=20 From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:50:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:50:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498420.769285 (Exim 4.92) (envelope-from ) id 1pUEz3-0004WW-2D; Mon, 20 Feb 2023 22:50:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498420.769285; Mon, 20 Feb 2023 22:50:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEz2-0004WP-VP; Mon, 20 Feb 2023 22:50:08 +0000 Received: by outflank-mailman (input) for mailman id 498420; Mon, 20 Feb 2023 22:50:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEz1-0004WJ-VT for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:50:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUEz1-0006Bg-1u; Mon, 20 Feb 2023 22:50:07 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUEz0-0008Ce-SC; Mon, 20 Feb 2023 22:50:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=sGkU79cHzFGJlqo3sbWpC0pTqDQR2c1WZMmX2tNNvak=; b=uZzYIojCr2WX1IMDG6qJCWohYu A8ec5dchts7SfeNvRrCoRPbj0AOfp5dprNf+6zVXIGzBo5WxN4HfvlanuMVYQX7A30PFlJp4forAp YTc23Sq0subbkSZTv7ocfebXKpbwTtq08SnrC8YKrWFpAc2rUGXZq6bKAIHrGBxEuK50=; Message-ID: Date: Mon, 20 Feb 2023 22:50:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only In-Reply-To: <20230120100028.11142-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: > Instead of modifying accounting data and undo those modifications in > case of an error during further processing, add a framework for > collecting the needed changes and commit them only when the whole > operation has succeeded. > > This scheme can reuse large parts of the per transaction accounting. > The changed_domain handling can be reused, but the array size of the > accounting data should be possible to be different for both use cases. > > Signed-off-by: Juergen Gross > --- > tools/xenstore/xenstored_core.c | 5 +++ > tools/xenstore/xenstored_core.h | 3 ++ > tools/xenstore/xenstored_domain.c | 64 +++++++++++++++++++++++++++---- > tools/xenstore/xenstored_domain.h | 5 ++- > 4 files changed, 68 insertions(+), 9 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 27dfbe9593..2d10cacf35 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -1023,6 +1023,9 @@ static void send_error(struct connection *conn, int error) > break; > } > } > + > + acc_drop(conn); > + > send_reply(conn, XS_ERROR, xsd_errors[i].errstring, > strlen(xsd_errors[i].errstring) + 1); > } > @@ -1060,6 +1063,7 @@ void send_reply(struct connection *conn, enum xsd_sockmsg_type type, > } > > conn->in = NULL; > + acc_commit(conn); AFAIU, if send_reply() is called then we would need to commit the accounting even if we can't send the reply (i.e. send_reply()). So shouldn't this be call right at the beginning of send_reply()? > > /* Update relevant header fields and fill in the message body. */ > bdata->hdr.msg.type = type; > @@ -2195,6 +2199,7 @@ struct connection *new_connection(const struct interface_funcs *funcs) > new->is_stalled = false; > new->transaction_started = 0; > INIT_LIST_HEAD(&new->out_list); > + INIT_LIST_HEAD(&new->acc_list); > INIT_LIST_HEAD(&new->ref_list); > INIT_LIST_HEAD(&new->watches); > INIT_LIST_HEAD(&new->transaction_list); > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index c59b06551f..1f811f38cb 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -139,6 +139,9 @@ struct connection > struct list_head out_list; > uint64_t timeout_msec; > > + /* Not yet committed accounting data (valid if in != NULL). */ > + struct list_head acc_list; > + > /* Referenced requests no longer pending. */ > struct list_head ref_list; > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index f459c5aabb..33105dba8f 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -100,7 +100,7 @@ struct changed_domain > unsigned int domid; > > /* Accounting data. */ > - int acc[ACC_TR_N]; > + int acc[]; Is this actually worth it? How much memory would we save? > }; > > static struct hashtable *domhash; > @@ -577,6 +577,7 @@ static struct changed_domain *acc_find_changed_domain(struct list_head *head, > > static struct changed_domain *acc_get_changed_domain(const void *ctx, > struct list_head *head, > + enum accitem acc_sz, > unsigned int domid) > { > struct changed_domain *cd; > @@ -585,7 +586,7 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, > if (cd) > return cd; > > - cd = talloc_zero(ctx, struct changed_domain); > + cd = talloc_zero_size(ctx, sizeof(*cd) + acc_sz * sizeof(cd->acc[0])); > if (!cd) > return NULL; > > @@ -596,13 +597,13 @@ static struct changed_domain *acc_get_changed_domain(const void *ctx, > } > > static int acc_add_changed_dom(const void *ctx, struct list_head *head, > - enum accitem what, int val, unsigned int domid) > + enum accitem acc_sz, enum accitem what, > + int val, unsigned int domid) > { > struct changed_domain *cd; > > - assert(what < ARRAY_SIZE(cd->acc)); > - > - cd = acc_get_changed_domain(ctx, head, domid); > + assert(what < acc_sz); > + cd = acc_get_changed_domain(ctx, head, acc_sz, domid); > if (!cd) > return 0; > > @@ -1071,6 +1072,7 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, > enum accitem what, int add, bool no_dom_alloc) > { > struct domain *d; > + struct changed_domain *cd; > struct list_head *head; > int ret; > > @@ -1091,10 +1093,26 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, > } > } > > + /* Temporary accounting data until final commit? */ > + if (conn && conn->in && what < ACC_REQ_N) { > + /* Consider transaction local data. */ > + ret = 0; > + if (conn->transaction && what < ACC_TR_N) { > + head = transaction_get_changed_domains( > + conn->transaction); > + cd = acc_find_changed_domain(head, domid); > + if (cd) > + ret = cd->acc[what]; > + } > + ret += acc_add_changed_dom(conn->in, &conn->acc_list, ACC_REQ_N, > + what, add, domid); > + return errno ? -1 : domain_acc_add_chk(d, what, ret, domid); > + } > + > if (conn && conn->transaction && what < ACC_TR_N) { > head = transaction_get_changed_domains(conn->transaction); > - ret = acc_add_changed_dom(conn->transaction, head, what, > - add, domid); > + ret = acc_add_changed_dom(conn->transaction, head, ACC_TR_N, > + what, add, domid); > if (errno) { > fail_transaction(conn->transaction); > return -1; > @@ -1107,6 +1125,36 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, > return d->acc[what]; > } > > +void acc_drop(struct connection *conn) > +{ > + struct changed_domain *cd; > + > + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { NIT: You could use list_for_each_safe(); > + list_del(&cd->list); > + talloc_free(cd); > + } > +} > + > +void acc_commit(struct connection *conn) > +{ > + struct changed_domain *cd; > + struct buffered_data *in = conn->in; > + enum accitem what; > + > + conn->in = NULL; /* Avoid recursion. */ I am not sure I understand this comment. Can you provide more details where the recursion would happen? > + while ((cd = list_top(&conn->acc_list, struct changed_domain, list))) { NIT: You could use list_for_each_safe(); > + list_del(&cd->list); > + for (what = 0; what < ACC_REQ_N; what++) There is a chance that some compiler will complain about this line because ACC_REQ_N = 0. So this would always be true. Therefore... > + if (cd->acc[what]) > + domain_acc_add(conn, cd->domid, what, > + cd->acc[what], true); > + > + talloc_free(cd); > + } > + > + conn->in = in; > +} > + > int domain_nbentry_inc(struct connection *conn, unsigned int domid) > { > return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) > diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h > index 8259c114b0..cd85bd0cad 100644 > --- a/tools/xenstore/xenstored_domain.h > +++ b/tools/xenstore/xenstored_domain.h > @@ -20,7 +20,8 @@ > #define _XENSTORED_DOMAIN_H > > enum accitem { > - ACC_NODES, > + ACC_REQ_N, /* Number of elements per request and domain. */ > + ACC_NODES = ACC_REQ_N, I would bring forward the change in patch #5. I mean: ACC_NODES, ACC_REQ_N > ACC_TR_N, /* Number of elements per transaction and domain. */ > ACC_N = ACC_TR_N /* Number of elements per domain. */ > }; This enum is getting extremely confusing. There are many "number of elements per ... domain". Can you clarify? > @@ -103,6 +104,8 @@ void domain_outstanding_domid_dec(unsigned int domid); > int domain_get_quota(const void *ctx, struct connection *conn, > unsigned int domid); > int acc_fix_domains(struct list_head *head, bool update); > +void acc_drop(struct connection *conn); > +void acc_commit(struct connection *conn); > > /* Write rate limiting */ > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:57:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:57:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498427.769296 (Exim 4.92) (envelope-from ) id 1pUF5h-0005Bo-TO; Mon, 20 Feb 2023 22:57:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498427.769296; Mon, 20 Feb 2023 22:57:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF5h-0005Bh-Qk; Mon, 20 Feb 2023 22:57:01 +0000 Received: by outflank-mailman (input) for mailman id 498427; Mon, 20 Feb 2023 22:56:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF5f-0005Bb-HZ for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:56:59 +0000 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de7a42e4-b171-11ed-93b5-47a8fe42b414; Mon, 20 Feb 2023 23:56:56 +0100 (CET) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2023 14:56:53 -0800 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 20 Feb 2023 14:56:51 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 20 Feb 2023 14:56:51 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 20 Feb 2023 14:56:51 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 20 Feb 2023 14:56:50 -0800 Received: from MWHPR11MB1392.namprd11.prod.outlook.com (2603:10b6:300:24::14) by BL3PR11MB6506.namprd11.prod.outlook.com (2603:10b6:208:38d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 22:56:47 +0000 Received: from MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536]) by MWHPR11MB1392.namprd11.prod.outlook.com ([fe80::d41f:9f07:ed56:a536%3]) with mapi id 15.20.6111.019; Mon, 20 Feb 2023 22:56:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de7a42e4-b171-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676933816; x=1708469816; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=87sxogROsgOIOvh4TVupc8lCT48Kss7Lsmry2uS1YCY=; b=A989Bud8lsBmbEHp9isbBOLUECT4WvbWrn0rvpz7BJCcG2r6+GJnBgyn BCGOf9tjNQSRGu4NkxmYKGZ2QJvLsSSWB0cbWPdtxiJS1unJ1052V+GlG +DFz6DXz0CERAtcUK45PNRk8ffASnOMU35OUDkI3WwZ26kN8+FjLr9lCF KaiqrCjmsbpyoR8tKzICs50HOHNn4lf12UBJNp+WgRILJhYPlpcuXD470 XD3kT/R3b/Z2+F5AhGP7LQIO4ixPgRqbaDSg8S/2BuI8nWEbIkZ6bjAHv GgbTgozkUn3JCSYGOg/S0pPbCUdz7V/UXQYjFgnt237JlK5oklHlb+x7S A==; X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="320629807" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="320629807" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10627"; a="648961940" X-IronPort-AV: E=Sophos;i="5.97,313,1669104000"; d="scan'208";a="648961940" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcTmLuXKveF0WZqUxce7a0VvhGMA5d/ued/IeIfzhaU8Gl0VYVkds1G2HbfeYqxc7VUlRvzTKkAOmVGUCr8+QI0FpHI2eKQXLOB0LbFk+wox2TDEkKpID3/cD5Tpq3KQRzhhlnhUNRVcJScsmWBLg65a7GKReC/bHd7eTnGFeL2itIxh3rsfDaF8y7FZP9JFKDMNijo7NODanTGzUa3DGs6nLCaS9pI4h4OuUMa+hgHiNsgxALaGR6oQApnOvHSIrBYXOigjsyD6F0Z0djtptD8fmKKVKb2TyOGjm187ZNYCl/Lb+30nzL/Kia/74ySq7veW7xnLix9FFqvkpAcJqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87sxogROsgOIOvh4TVupc8lCT48Kss7Lsmry2uS1YCY=; b=EkYzd81cCUOclcKjdLJadxKVv8tgkYdMyYUlwI7e35nKtentNXYnqPrvl6sHlliGOkykn23Wzqa/ZFc5uZc+NFC/oW4up46IraVD/DiZyz2GMCa9wo3w7AHckfl1CStetJ1uepPpCUdHfQQEfPvQdhYBZTbr5zfupgWB07NUm8vBCJfU5Jw0OO+FKQOjqF3y2N7/XK/OZJJp7oN//ViznwIZptMQy4iHfkFZDiq2hRDD5QAr+oFenHuMCKnCe0nj/ignm4WIPguno2lJqAlZpYBJiemhAet6TOINGOp0FBE24W84Isi4l+jJsyer6zhf1BY0y2PqmDq2jg5Qhd5k1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Edgecombe, Rick P" To: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "bp@alien8.de" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "x86@kernel.org" , "mike.kravetz@oracle.com" , "Yang, Weijiang" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" , "akpm@linux-foundation.org" CC: "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-m68k@lists.linux-m68k.org" , "linux-alpha@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linux-csky@vger.kernel.org" , "dinguyen@kernel.org" , "loongarch@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "monstr@monstr.eu" , "openrisc@lists.librecores.org" , "linux-parisc@vger.kernel.org" , "linux-um@lists.infradead.org" , "sparclinux@vger.kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Thread-Topic: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Thread-Index: AQHZQ94+cYJhrZsBjUaVUuq1nj/bS67Xs8UAgADBtQA= Date: Mon, 20 Feb 2023 22:56:46 +0000 Message-ID: References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1392:EE_|BL3PR11MB6506:EE_ x-ms-office365-filtering-correlation-id: e44e50fa-c744-496e-a195-08db1395be80 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ksQ7RIySPNQWtiqdtkozOmRxbrbYyv7MvZu26yZSDw0GbUBfz7lYo0F4Zn8YKnZtpB9xhLgdjKDKou+e0c/wQpGeJUC8TTEPE9GbCAmSKrkw7pHmMznfTx+wG2mGAymW6Lg//9F2D0Vyn4aFopXmZNvmMf99EaZmT3K3o16/PpfNtc0stT0JY0VrxKotBJ4mr3hcwVrKCsXL6vOXaA9DgySWhslFtRyaGPbS8kRRBl/zXRSfQjXHgXgUhbgG3A2QpIdse7CETdLXBjMdSY7irumRsGnexlYzK1WQj4BuwIWct/k1XrPvMHYWdjx6Dnk5O6P9fZR6vyPuQ2sj1qNtpbRP4RLcvd/cBoyamNtkbGZNXb68XYIUh6H8snPqjsz1Kr/eZ8MNkOYxjAg2P28eF1/qaEpMqO7Zsuq2fnBpzcb9d91NU9IULmzhTFl3jvza+EE4TYPkrWQGZFGe/vGdnj6wt2kpsXSGhVZOc7D1uIbaEzG27J8PaY2/itl7j6hD1IXIXgitSZTAGdsdZwIKXv1KBoCh+ewzvpyoWEilsHZZg9axv9quzuXBRVJdCcpOiwelhrKGKsoLqG24+k/5f93dSUJWWVMSUdoizgSGZp+DQQQheitHldiCFiVU3l9zqG3xuxOV3kQCpgdQkl5AyyGAJNlkZoHvuuLNWyfqaaXpLdoVgqhKDkvGwGVn+wv9jME+K9quQn6OQck48RpNBq5irUkgztFUDr1oM6u4EJi9LxK6aHZutQPgagp0kGcm x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1392.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199018)(122000001)(86362001)(2906002)(82960400001)(38100700002)(6512007)(6486002)(71200400001)(6506007)(110136005)(186003)(26005)(478600001)(36756003)(558084003)(921005)(38070700005)(66946007)(76116006)(66476007)(64756008)(66446008)(66556008)(316002)(41300700001)(54906003)(8676002)(4326008)(2616005)(8936002)(7406005)(7366002)(5660300002)(7416002)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YW56eGRwMjJPaXZWRzQ0NkV1SFRiUGFSUlRjbm13ZVA3ejRKRlBWRktCVW5o?= =?utf-8?B?bnA2T1JKcnpRUVhQUGtlWmF4TDFDQVpPVis0c2NHVllBc0dlTHdZZ1hmRWYy?= =?utf-8?B?TWRHRm1KUGhlazQ5MzlwYkJmeFVvTXBlbTE3Y0J1Smc4azRJK20vUng2M2Nn?= =?utf-8?B?amQveGl0NEVzYjROSEM1QVhZenlpaTJ6L1NxRER5QkFmNWl0ZDd3R0RHVHNv?= =?utf-8?B?OHNDZ1BadXpnUkpCQmhWMUNFdkdIOEd5QlVNNE9GQURzWFg0MW5vSDdMRkww?= =?utf-8?B?Ykw3S2pNUC83a1RUdy9sc1V5N0wyTnh4NWFpbWEwYzZLZDdQYVp0cjNXbms3?= =?utf-8?B?VWo0QzJuNEYzWG1LTWtCdVdiZlRjcXBRTUs3VnNWUWFmNC9yM094cWFMOFY3?= =?utf-8?B?MjROQ2xlU3NmT3c5QmUvTVFrbUplaEV4ZXg4d2JiNDNxZExKWG4zOG1OWkd0?= =?utf-8?B?ZHVYalFjZ2w0SkVuc0lrVWxITlAzUHpXY1p6MGl0NDAzS3Z1Qzk2dUZGNHVi?= =?utf-8?B?cGF5YTZSdUdwazFaSlFWdFpyeS9yY1IrM1UzRU9FQ0gzRVY1RTllQUpMRkFt?= =?utf-8?B?bHlBRWlhYXRWVVFSd0M1RnNhbnNLTzlFcU5hdDFlTndGVjltMS9jWXFOSlZs?= =?utf-8?B?b2JtYjhWWnBiancrSmcyRDdpSWtoWnZyMjhWMXEwRlllNEtaTmt2MmI1WlFB?= =?utf-8?B?NllSakM2MFRiU1paUXB3RUhqTGUwS2RtV1ZRZGo3Y2k4VTBTVWpqemtONUQ2?= =?utf-8?B?amtoUitIUG1zYWxNOWVzcm0vRnRkUE5zczFPNGNjZ2xOd3dDM0pDY1MxYmJi?= =?utf-8?B?dk14WEJzOUd5MEZla2k2eXFSdFpLR2ZuWUwrdDdLNmtWb2cwNEd4SnJ4a1RZ?= =?utf-8?B?RDRtUTg3UjR3SFdJOGRqYXhvMm5lZzkxdEl1OUJBOHRnK2JJbGFkNWk2Z1lt?= =?utf-8?B?S2pkTXQ3MmNBYVpHT0JwbUVLU2lrVFlVR1RqOVJ3KzJqUzR5M3NRQ2oyN2x5?= =?utf-8?B?RUVQYVl5NG43aDd2L3hoWitqMTdZOVdXd1JuWWtVVXVIU1BQRkIyZUpaNDZO?= =?utf-8?B?b0NmRWJmMEoySzZwRmFsamFUZ096dTlPWGpTamFUZmEzR082eE9McjkrZllM?= =?utf-8?B?c0t2MjRMNzZBMFYrVWNqcy8wNk9iT3JsbjBoUDFCdTFpWjRoUGozU1ZuUjBm?= =?utf-8?B?c0l2SWZjSktnMkw0UmFSL2xINUcrbFd0Wm9TMWRwQVlFQXZiSnhwTHZpUSth?= =?utf-8?B?SUZ6R1RRbW9FYklRWVpsUmR2NXlzOGdKVTIyL0h1S2FuZzQycFVGckdsZHlY?= =?utf-8?B?bk5zQjRtQVVvSTRIMXRiR29IRmRaWGpJaEFIV2ROelp2NDVvb2dFM1JVR01J?= =?utf-8?B?TmVyT0NnYnc5YUUwSVhkRWE2alZ5QTlJZW8rbXNMdk1xUkwySXZrbEErd2ly?= =?utf-8?B?d0hWeXdJZHAwZWdEdkFoSCs4YW5vUEtKUllsb2xPaVU3WnJGMmc4U3ZuNmU2?= =?utf-8?B?Q1FkREc5ckhjeUtXN2IvaXh2d2NsNS9HZzFjTXJLVGxkcUtyVlkzOUFuVW9i?= =?utf-8?B?MTdQbDVaTmNuUVJMNFIvbngrSkZETDZ5VUpMYW1iaWdiQkZZMGlVaUFiajkv?= =?utf-8?B?Q2VKUHA3eHovMmdjYnpZVG1xeDFWNWhvdnNiZmV3R2JNV3FjZnA1bTJSTDVm?= =?utf-8?B?d0g0cmdlbWlxa0l3dUdJT0ZmaGJlWlNFZk1PNkZiaFV2SEQ5bm5CaEdlNnNj?= =?utf-8?B?WHNFdFNvVllPT3lPUERVcE5IUVVncjg2NmpJU3o4U3k0Zm9qdm81T3ZvNll0?= =?utf-8?B?MkVVY2FrYUdUVWhsVmtmdCs2NTZSdDhFbGpldkM4NTVOSjZkY29uZ2lWcy9M?= =?utf-8?B?NlQrcXZNMEppZHh4S1pRSm5oeUxZQTd6WTdaekNkRDJTYzh2YUt0VjRsb0ta?= =?utf-8?B?RTNFOUdXbzdmajNYQTJJSXVlVkpsalhUQTZyTng4di9aVEtQK1VhWkJzTGFP?= =?utf-8?B?VGpzREc2OWtCMmJQdkMxVy9xakc0NWZZWE9vWW1icVVvcWduQ3JQVWdTTUI1?= =?utf-8?B?SmtPVEhINW1Nbkl3OCswOUpFaHVSc0RjMU1EVmNtMzFEaTRkZU1XTFV6U0NR?= =?utf-8?B?OEhTeWhGQ3RDVVV4eG5Ha2lBb0lrRG1nV0ZBYkNYTmhTaTNRVVhJc3lydk5h?= =?utf-8?Q?jOiiC3V+rt/XwEVkOa/vMqQ=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <23B918A044316A48BC65B5C98C4B680C@namprd11.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1392.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e44e50fa-c744-496e-a195-08db1395be80 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 22:56:46.9900 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IO8b5p75DKogOcIKA0BCZfvD12QKviBW5V3yC9aiMleQN4Ofh9+wjy1xmbwCu0fZfCTp9uz7T5Nm0+W8BUZhH1HMjs6i6gsXQlPwVFHg2WI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6506 X-OriginatorOrg: intel.com T24gTW9uLCAyMDIzLTAyLTIwIGF0IDEyOjIzICswMTAwLCBEYXZpZCBIaWxkZW5icmFuZCB3cm90 ZToNCj4gVGhhdCBsb29rcyBwYWluZnVsIGJ1dCBJTUhPIHdvcnRoIGl0IDopDQo+IA0KPiBBY2tl ZC1ieTogRGF2aWQgSGlsZGVuYnJhbmQgPGRhdmlkQHJlZGhhdC5jb20+DQoNClRoYW5rcy4gWWVz IGl0IHdhcyBub3QgdGhlIG1vc3QgZnVuLCBidXQgSSBhZ3JlZSAtIHdvcnRoIGl0Lg0K From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:57:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498429.769307 (Exim 4.92) (envelope-from ) id 1pUF60-0005YK-8S; Mon, 20 Feb 2023 22:57:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498429.769307; Mon, 20 Feb 2023 22:57:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF60-0005YD-5X; Mon, 20 Feb 2023 22:57:20 +0000 Received: by outflank-mailman (input) for mailman id 498429; Mon, 20 Feb 2023 22:57:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF5z-0005Wc-Kg for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:57:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF5y-0006J0-Uy; Mon, 20 Feb 2023 22:57:18 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUF5y-0000C3-QB; Mon, 20 Feb 2023 22:57:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=P2VuiSuaQPlXf0MR8koO4AUur0W8TiPJsxED2RFblPY=; b=IA3HFXVqZAVfjC2uRrqAmhklC9 Zjl4RIe4xrWLezFY1nKlAND09tJCCAh2XMB80SlvlNF59gJoneX1kkBeqEXu4Cf89XBmuWt/WCdj4 aZmsHwPdNngw8CZo53REvkYthtGyz2IAH3ZOhwIO0bQFCvAz3aO4MBE4HK9jRfaJ5+Uw=; Message-ID: Date: Mon, 20 Feb 2023 22:57:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-9-jgross@suse.com> From: Julien Grall In-Reply-To: <20230120100028.11142-9-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 20/01/2023 10:00, Juergen Gross wrote: > Add a new trace switch "acc" and the related trace calls. > > The "acc" switch is off per default. > > Signed-off-by: Juergen Gross With one reamrk (see below): Reviewed-by: Julien Grall > --- > tools/xenstore/xenstored_core.c | 2 +- > tools/xenstore/xenstored_core.h | 1 + > tools/xenstore/xenstored_domain.c | 10 ++++++++++ > 3 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 6ef60179fa..558ef491b1 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -2746,7 +2746,7 @@ static void set_quota(const char *arg, bool soft) > > /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ > const char *const trace_switches[] = { > - "obj", "io", "wrl", > + "obj", "io", "wrl", "acc", > NULL > }; > > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 1f811f38cb..3e0734a6c6 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -302,6 +302,7 @@ extern unsigned int trace_flags; > #define TRACE_OBJ 0x00000001 > #define TRACE_IO 0x00000002 > #define TRACE_WRL 0x00000004 > +#define TRACE_ACC 0x00000008 > extern const char *const trace_switches[]; > int set_trace_switch(const char *arg); > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index b1e29edb7e..d461fd8cc8 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -538,6 +538,12 @@ static struct domain *find_domain_by_domid(unsigned int domid) > return (d && d->introduced) ? d : NULL; > } > > +#define trace_acc(...) \ The indentation of '\' looks odd. > +do { \ > + if (trace_flags & TRACE_ACC) \ > + trace("acc: " __VA_ARGS__); \ > +} while (0) > + > int acc_fix_domains(struct list_head *head, bool update) > { > struct changed_domain *cd; > @@ -602,6 +608,8 @@ static int acc_add_changed_dom(const void *ctx, struct list_head *head, > return 0; > > errno = 0; > + trace_acc("local change domid %u: what=%u %d add %d\n", domid, what, > + cd->acc[what], val); > cd->acc[what] += val; > > return cd->acc[what]; > @@ -1114,6 +1122,8 @@ static int domain_acc_add(struct connection *conn, unsigned int domid, > return domain_acc_add_chk(d, what, ret, domid); > } > > + trace_acc("global change domid %u: what=%u %u add %d\n", domid, what, > + d->acc[what], add); > d->acc[what] = domain_acc_add_chk(d, what, add, domid); > > return d->acc[what]; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 22:59:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 22:59:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498439.769317 (Exim 4.92) (envelope-from ) id 1pUF8Y-0006ZI-LD; Mon, 20 Feb 2023 22:59:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498439.769317; Mon, 20 Feb 2023 22:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF8Y-0006ZB-Ic; Mon, 20 Feb 2023 22:59:58 +0000 Received: by outflank-mailman (input) for mailman id 498439; Mon, 20 Feb 2023 22:59:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF8X-0006Z0-5h for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 22:59:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUF8W-0006Mi-FW; Mon, 20 Feb 2023 22:59:56 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUF8W-0000HG-AA; Mon, 20 Feb 2023 22:59:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tQ4NbY+LiMHhPOMMU2aC2tHZpVLZ/60wRRM3PzucVPE=; b=3qRTSLjWpnq9l8Yd65VIWNhx3S A06P4Di0qy1FvIRN1C/zNaH9tXSH2WF1RgcY/Be63s1hlT/q4UeR/+GBxZ92hGqmaoYdpo/1/ALXq koMnpChjfbJt0eh8QCWaVTMcAasKR7s5BIyiI4NYTzgTad5KujLeHIha7J89hG9+sEbA=; Message-ID: <0f78fffe-5e53-5881-b5ac-421d1faa5e99@xen.org> Date: Mon, 20 Feb 2023 22:59:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 09/13] tools/xenstore: add TDB access trace support To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-10-jgross@suse.com> From: Julien Grall In-Reply-To: <20230120100028.11142-10-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 20/01/2023 10:00, Juergen Gross wrote: > Add a new trace switch "tdb" and the related trace calls. > > The "tdb" switch is off per default. > > Signed-off-by: Juergen Gross With one remark (see below): Reviewed-by: Julien Grall > --- > tools/xenstore/xenstored_core.c | 8 +++++++- > tools/xenstore/xenstored_core.h | 6 ++++++ > tools/xenstore/xenstored_transaction.c | 7 ++++++- > 3 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 558ef491b1..49e196e7ae 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -589,6 +589,8 @@ static void get_acc_data(TDB_DATA *key, struct node_account_data *acc) > if (old_data.dptr == NULL) { > acc->memory = 0; > } else { > + trace_tdb("read %s size %zu\n", key->dptr, > + old_data.dsize + key->dsize); > hdr = (void *)old_data.dptr; > acc->memory = old_data.dsize; > acc->domid = hdr->perms[0].id; > @@ -655,6 +657,7 @@ int do_tdb_write(struct connection *conn, TDB_DATA *key, TDB_DATA *data, > errno = EIO; > return errno; > } > + trace_tdb("store %s size %zu\n", key->dptr, data->dsize + key->dsize); > > if (acc) { > /* Don't use new_domid, as it might be a transaction node. */ > @@ -682,6 +685,7 @@ int do_tdb_delete(struct connection *conn, TDB_DATA *key, > errno = EIO; > return errno; > } > + trace_tdb("delete %s\n", key->dptr); > > if (acc->memory) { > domid = get_acc_domid(conn, key, acc->domid); > @@ -731,6 +735,8 @@ struct node *read_node(struct connection *conn, const void *ctx, > goto error; > } > > + trace_tdb("read %s size %zu\n", key.dptr, data.dsize + key.dsize); > + > node->parent = NULL; > talloc_steal(node, data.dptr); > > @@ -2746,7 +2752,7 @@ static void set_quota(const char *arg, bool soft) > > /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ > const char *const trace_switches[] = { > - "obj", "io", "wrl", "acc", > + "obj", "io", "wrl", "acc", "tdb", > NULL > }; > > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 3e0734a6c6..419a144396 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -303,8 +303,14 @@ extern unsigned int trace_flags; > #define TRACE_IO 0x00000002 > #define TRACE_WRL 0x00000004 > #define TRACE_ACC 0x00000008 > +#define TRACE_TDB 0x00000010 > extern const char *const trace_switches[]; > int set_trace_switch(const char *arg); Add a newline here. > +#define trace_tdb(...) \ > +do { \ > + if (trace_flags & TRACE_TDB) \ > + trace("tdb: " __VA_ARGS__); \ > +} while (0) > > extern TDB_CONTEXT *tdb_ctx; > extern int dom0_domid; > diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c > index 1aa9d3cb3d..19a1175d1b 100644 > --- a/tools/xenstore/xenstored_transaction.c > +++ b/tools/xenstore/xenstored_transaction.c > @@ -366,8 +366,11 @@ static int finalize_transaction(struct connection *conn, > if (tdb_error(tdb_ctx) != TDB_ERR_NOEXIST) > return EIO; > gen = NO_GENERATION; > - } else > + } else { > + trace_tdb("read %s size %zu\n", key.dptr, > + key.dsize + data.dsize); > gen = hdr->generation; > + } > talloc_free(data.dptr); > if (i->generation != gen) > return EAGAIN; > @@ -391,6 +394,8 @@ static int finalize_transaction(struct connection *conn, > set_tdb_key(i->trans_name, &ta_key); > data = tdb_fetch(tdb_ctx, ta_key); > if (data.dptr) { > + trace_tdb("read %s size %zu\n", ta_key.dptr, > + ta_key.dsize + data.dsize); > hdr = (void *)data.dptr; > hdr->generation = ++generation; > *is_corrupt |= do_tdb_write(conn, &key, &data, Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 23:08:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 23:08:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498447.769329 (Exim 4.92) (envelope-from ) id 1pUFGS-00086T-DS; Mon, 20 Feb 2023 23:08:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498447.769329; Mon, 20 Feb 2023 23:08:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFGS-00086M-Ap; Mon, 20 Feb 2023 23:08:08 +0000 Received: by outflank-mailman (input) for mailman id 498447; Mon, 20 Feb 2023 23:08:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFGR-00086G-9p for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 23:08:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFGP-0006WR-K2; Mon, 20 Feb 2023 23:08:05 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUFGP-0000v2-CN; Mon, 20 Feb 2023 23:08:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FafX2SClFS7Vpo8ixoyZ6ek+9GGkN8gzUr9K9rRrSLI=; b=Okv2MCSxKUXXQnKDpNmpyghZw9 qEMt8FdlQBloLircu1oJGBjmv2mpfu2LBzcE8Vzwd1WA6fv62+dMEEXpQpQsAthfn/XJPQgm8J/Uh YT+4XrxbdSeswH2MhLk6jXJ5tN8RQFEQuN4u6JMuCfekDNDPyL8wC7yxhWOUkO9J7ECg=; Message-ID: <02ec8fb6-3736-8113-6c8c-d9f76c74be2e@xen.org> Date: Mon, 20 Feb 2023 23:08:03 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] tools/xenstore: remove stale comment in create_node() To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230220145706.15905-1-jgross@suse.com> From: Julien Grall In-Reply-To: <20230220145706.15905-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 20/02/2023 14:57, Juergen Gross wrote: > There is a part of a comment in create_node() which should have been > deleted when modifying the related coding. IIUC, you are referring to: 1cd3cc7ea27c ("tools/xenstore: create_node: Don't defer work to undo any changes on failure"). If so, then please mention it in the commit message. It can be done on commit so: > > Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 20 23:08:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 23:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498450.769340 (Exim 4.92) (envelope-from ) id 1pUFGk-0008Sn-Ka; Mon, 20 Feb 2023 23:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498450.769340; Mon, 20 Feb 2023 23:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFGk-0008Sg-Ho; Mon, 20 Feb 2023 23:08:26 +0000 Received: by outflank-mailman (input) for mailman id 498450; Mon, 20 Feb 2023 23:08:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFGi-0008Oo-Bx for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 23:08:24 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78401ec0-b173-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 00:08:23 +0100 (CET) Received: from mail-bn7nam10lp2105.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Feb 2023 18:08:18 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5589.namprd03.prod.outlook.com (2603:10b6:5:2cd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 23:08:16 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Mon, 20 Feb 2023 23:08:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78401ec0-b173-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676934503; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZkrdgVnzit6kWn7S7oMccACtAX2VxqAEUryZpD+YZ6Y=; b=d6dGehQJBljHDBTuHdsTIDkWtnNPkqQqa7tMWnignFTAEABH6Q9VtCNy yHJ1UXv1xNE+S6y13OdKnn1qok6xqdD85lsI9vxKEa+hW+LKbm4F2cSYq NBYa/DYxa+CTR6APxE0jAQlVg8NiThSSTYXxWVjLQ5d3dbY+8rfr07Yz8 Q=; X-IronPort-RemoteIP: 104.47.70.105 X-IronPort-MID: 96642111 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uygY/aJzsUtIriZEFE+R6pQlxSXFcZb7ZxGr2PjKsXjdYENS3zNRm GscWjrVOfaCNmGgft0gbdnj8U4FuZ6AzoBiGQNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZmPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5pHX0e6 /5CNwpdRS6squ6qw6u3Ybhz05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLkWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzH2lBNhLTeTQGvhCvW2+6U8iVw0tcBixmqKAs0KiSfkOA hlBksYphe1onKCxdfH3QgeqqXqDshkDUvJfFuQ77EeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5ty8bniJE+iFTIVNkLLUKuptj8GDW1y TbVqiE73u0XlZRSj/j9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:vKDiGqBc+RUkihHlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.97,313,1669093200"; d="scan'208";a="96642111" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vdq1PXcu1rTAAa7EUNDFQPaPG8wOrTVyAx9jIVBDU0T2D9Iwsil+J86MRBI6O0MOq6k/x7gT3WRGpTnkjUo91DXy4edgacnXHiDw1mZ6NAMA8h4G719gsHL2lJHU2SS1wk/a2XBd6XE5/R7xoYPXDzHMKFH61W2RRM7WrkVgto8JrkCSRku4eVW/URpcwhQKMNe4y0i/4tb3uQwzzBgReCwkI+e3ZQ06fHkEVW7hs31j21O2kj7ZFxFqR0ccG9oy7OkIswAvSyyS4bFxl9rQFrESMNoE5G/DUoH/+nHw3qit7SQ/C+xIK23szL0sasJkrwalX/c+2tWZ4QVHeRUEnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZkrdgVnzit6kWn7S7oMccACtAX2VxqAEUryZpD+YZ6Y=; b=fBcAk/hbAXGVcDoSWKNhDLsj8J2ewIehDAl1O98K2ZmcSgQACKog1Cuaem1Y7d70LIwtyGMbzWVuzlnmb0CiQpBMV0vwtQbjiqaMazmogR5bCgqUjdMYVKr22WPKhWIwqzgau5VACXKsIV/lEyLh6GMHf2MfnRhR0Ueb3EHyeYfLoR9GZcrpPgxjMVbDmvY/DkJi9G8n+T87qiFXBJf5iMJdSf96OXnjcUyVxqo70Nde4EOmtUpKhDziDRI0p5wbTtvc6txBFDewGS9akZTmUHZOwchmDZ7P/ek69Rs6/mFmt0q1biTBEviWxldpeUXN3cJnz7cFeH95tPT36pQ0QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZkrdgVnzit6kWn7S7oMccACtAX2VxqAEUryZpD+YZ6Y=; b=Msphz3mfOT8qiGxvPOBf+e87fjP3/s+sfEnXPm4V+j14L/sRVpebyuV1BGvlnsuDkQf71/BkxqnyVhUm/kSPvuh5UebQxB3lcq7X/2F2X/RhSh8n83eNJ6KmIx2NOqh4EpqhEfwWG9+CWMP51SIB3rvN9sHQUzMgTfScvC9EYYo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <562ae912-e833-ba97-dcd5-4c6b6d8898e0@citrix.com> Date: Mon, 20 Feb 2023 23:08:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 2/4] x86/svm: cleanup svm.h Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-3-burzalodowa@gmail.com> In-Reply-To: <20230217184814.1243046-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0129.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5589:EE_ X-MS-Office365-Filtering-Correlation-Id: 363e28e5-f418-4dd8-7ea6-08db13975950 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2X6f/vFunpMDfVilV5ZXmqbYLD+4Dnlg28T/Cw5+ldNBMc9OD1uRkSI9xsqK+ZXvEMpIofCQI8nhgkMR0LcWsYkzXSoVmr6PJINo4B/qzRdZBl6lbq61ZMbyNrOgkolThlteuk+z+9PMdEQroXnR2gLjO/Es9H8RjN3vpdLSFcGPfp6sCFRv8K3e/a2qM4anSHDx6KJjOsTcpS8X4OqtJfx5T1Qj+8WhQHKLfIRC6mhPzQDN/VkDSmQWrYRRgw20kyInrsrjYKFISpdtYSh4uVt3Z1tGHD61J7zeCHyw51Z2GVidVJaV26XjOh9sjZKUXeyyUsvUGJ+j8r+iCRQpxf7ewPS4TbA/VXO6K2OFHeY6BVcTUyW+rxMguWd0xIAj+me3fWj6qD/3Ydcgm3k4VtVNJqHLafWtMzaNDlO6GZOhIa9SFku5DknhXV4NGgpiV+X6HMVTzsgiiLefy2qw0PuoakHQp+D1IcpKYnIXrQt41yp/FpAnOqCIvYiVwQ8nb5w3IONrx0nhaGMihKdrlJbnAKz9V/WCzCfWggY3sitVZ1HDh5Gz+8nqUdSKv8sDf9hp21XMcUKXG/tTWPl48CYKiU+RbdC/QIJUbhBHlFfnUHViGuviHOyy4ghQ7p27V/cxlpgdgN9+tQQPioNX7oC4aNRRUZJgZXIJaN4iODCpWu/UvA2w4Qk365O1qPKb68/CTwoVNLWcaXJxVPgQyKEG0Yca8fDcTvVhz7dLX0w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(136003)(376002)(396003)(39860400002)(451199018)(478600001)(54906003)(31696002)(82960400001)(86362001)(38100700002)(2906002)(316002)(41300700001)(36756003)(5660300002)(66946007)(8676002)(4326008)(83380400001)(66476007)(8936002)(66556008)(53546011)(6506007)(6512007)(2616005)(6486002)(6666004)(31686004)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEpheVJQNkYzMjVCR0lsTlNISUl3cmhxOFJ4bzVTdUt5NkppcS8rQkx5VjQw?= =?utf-8?B?dE5mMEJaaDBvRUprb3NLSU42U0JucmUzU0dlMHF2NUxBVGwyanZSQmVJcFF6?= =?utf-8?B?eGR0N0I1R1dBUi9uYkFja0ZndHdZVmdja2pGRmJma1laZGppM2ZyaXFQcUVl?= =?utf-8?B?R2RUQmNFWVF5UlJGbUZjcHFYbi9aY1k3VGRFQlJaMWRiNW1Nb1cxZVFyUXpy?= =?utf-8?B?VzRRbWpYaFhGa0F5ZE9mTTl6RklTOStxMzRueFJmSnZ5bHBXUTlhYkp2UmN4?= =?utf-8?B?dVdZK1dZdW9MNFVYa25vUWNKc0w3MWt5cWp5ckl2eEpLY3ZwQjEwQm1nbFdP?= =?utf-8?B?RDZVM2lhbFRMajNFNWFxY0V2VG1HT3dzWENXSGQ3V3EwNlJuTUZlVUViSVBt?= =?utf-8?B?Tk10ckZjZHQ2V3FCMWYrSjJGckdvT015azY3QkdWZWkvTWFvcklVODBBK3RY?= =?utf-8?B?RHJjTjNUZ2tPLzVBTWx3R0NFTStRRCs3anNKT0pXQUhzMVBhVzJsTUJtZXk2?= =?utf-8?B?ZXUzd2FCZEVFMnNZcEVRelAvWG5qN1dRMDcxdklBTEdKek8yVUpBcXNUaERo?= =?utf-8?B?bXg4dXlEQUxoM29sUStPSlF6WmNCWGlobzRYYXVnWDd1MGJrNzJYSGQ0S0JF?= =?utf-8?B?UyswdFI3RjFFR2c1Tm41TTVRMjNiNkNXSlZlMldTNTJPQUVUamdWYTJpWkJv?= =?utf-8?B?Nk5mOFV3cDByQUIxdUxpbnM4R3d4UndiVkVLWC9weExEMDB3d1psVjF2Mk9Y?= =?utf-8?B?MnFUa2tEcFV1dDRzN05ZSGVjTmpiTjVPckVoODc0NUZsdnE4L21QcHNQUWl3?= =?utf-8?B?T0F0c3dnSVA0VWpQNW1VSkxDQzBmSEw0R2wvWERZaGZuMTZpb0pabzBQVFJG?= =?utf-8?B?clBNbHhhZCs1SkE5cVF6Sis3TXg0dGJkNm95TzZid0w1a1VRZTJqbi92azZI?= =?utf-8?B?aG45SE9UUDN0ZUtWSXRIejhNOVFPbkpDTVAvRkNFSk5BQ2MvQlVUb2NFNGZs?= =?utf-8?B?TklLOTZ6SG5pMy96Mk41TXlLMHpOMWx6SDJXdFNkKzc5OHdVczcvNFlEL251?= =?utf-8?B?WXNudFY5VWZiUVd0NFpEemlDd2Ntcms4MW9ZSEtBdE01cHpKYTBycWQvVDlQ?= =?utf-8?B?SmlPSmJKcDZJaHBCenNWSy9hY2c3M0RnV1ZxaXh1aTA0WEpXeDkrTE9sbUpY?= =?utf-8?B?TzcxNUhCdXZZUmIzVnNzUE8xRDVxT0xTZVVYMkl4QlNaVGJ1QUZ3alVkeTRQ?= =?utf-8?B?OWZtRGtpbkhTdk1HYmhuZHlWNkhpZ0dERXlpN1VxUnRCTkZmem00QmFidUh2?= =?utf-8?B?elNSR0t0TlkvbFBiRWFxb2ZFVDhxZXA4YW1SUEYyN1NwdnNiM2pGTDV1N3Fu?= =?utf-8?B?UktlQ3RUcXI1Y3BaOGp4WmRHaFlBYWNsNng2MTViTkMzL201azhvTnd6RUxj?= =?utf-8?B?QjRvQmhPSk9VTlk2SVJUUXlKTmxVaFNkL2w3a0d2REE3K1pjUDB6aGk3TkRB?= =?utf-8?B?MTlhUTNZZFI3OG4rbkFyd09WY0FlTDFnNEVla0hkZjdTQUlFQ3YrRWpFLzN0?= =?utf-8?B?K0VtcjAxdHBoY3Y3UDJLSXBnTEwzRVJZMjg3Ky9GcE9mcCt1d3RENldNdHEz?= =?utf-8?B?VWxkdGtYQ0NzdEU2dUE0d3FGTTlzTVZYd1UyV2RjYWZOSi9RMm44UHp5RVlw?= =?utf-8?B?MHB0RGlaamY0bExaU2FodXNwUGM2bnJQQXE2WjNCWVU5WmwvM21TYUZ6eHY2?= =?utf-8?B?Mzg2TW9JcFpTS0NOTW96Sy9iMmcvbDhzRkp1OE5LaFFPT1ByUFRNUWl6Q2VG?= =?utf-8?B?bExwdDBpTDNsRVZPdU1xT2tONXVxR0p1NGdZemJLSW1jMk45VkF1S1doRko4?= =?utf-8?B?V0dNUElTZmRhV25pWHptYWZzTUw5NUVpYWl1MEJYWEZCRkdxem1NNEdvTFFL?= =?utf-8?B?QU9ISlNFdXRBWURHdDE2VzkreE0ycDk3WFlrM3FlOVdvVXBMNEdQNUN0cDhl?= =?utf-8?B?QWNYZHZFc213TVJFMnZYeHF6STU2dWRWZnYwZm5HQzRWTEhCSm4zWGE4Ujcy?= =?utf-8?B?M25wbHZQRk1nbG91U2l1c2JEdFE2VzVYakFyNHBVTDJtNjJIUHFUN3F3cVJp?= =?utf-8?B?VkVXTVlCUmNSTVlZU1Fmckl5U0ZISlBFSDRKNHp4ZkNnLzlyUWJRaXZEdjVQ?= =?utf-8?B?MHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OlpS2nUSS7yLbiJR+XgIo9xLVJEZyS9iwRbRsVDzNOQLu8Dj7jn/EU1YwGCjuvTEELZx9FD9S0LrUgox3bDnt3XlxKy2EvZsknEVQeWx/2kyxz8Hu3/Q0n/c3URdyJ2z2Uki8jfsO84a6B0qM0hmIdA2K/mDlMmnceKsTd2qL0yVaEEeuY5Tq+gz727x4TVWE85RlR0q0JfK/HimOtK8eMX+NvyOEbyiv3KPA8ay+Q9y9kn4Xur9HGJ4VfGIk7ZEauENbdDh6xa3uckSDcTS2b2VBB5UiY24f1ApaLifegqco8NWfVpL0WE/J8TgiK3MCKGmy2tR523xKLHV92jMVhhnCL/OgoE73QJrU6pn3T2oR3XvRU46qanvzN5mMcdePNp16g4/VqzACGOpFZrAzOMuSXRAPUP2+WUR+PmajhQIb6XnP1qa7ZioxV1kQEAnmjMNcpyPYdZHlJ5WdkrBGBh9yjK2HSruFbPPMCpRyxbKO2Jt4J4y5e6d5WchsI8U+qgp3NNyjXWhETYo4ysOiEUl/UaoCU6HcJLGk67tJnhT3zVkDIIwd8K+/yUuAE6+Gt+o7UT/WP9o2xc7OlF7JSx4oUn5jQFd3jKLKtT00l/Ji73D0CEDUtLs8QdwG7rUCFF3ZA0dwkKii6mTmPHcfolfxzbXl+72YizRKTqJOll8ibCP4fdWlFVFrZA3ZrRccE1J+VgyW8ACPli4i80sIiVuM4ZVhfMLlHZln93BkcmqWdOl0OZ3nlHpGLDkagsO11Ctc2VMmPBz43AZ2w1Y2ppnif2Zk3Pd+Mxh0uZaEwHQahRBj7elJ2FIJoYlRbrxyoECe9+TE4qeCCkQF5eYPW45GUpb7Q5GOI6O3wpURaY= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 363e28e5-f418-4dd8-7ea6-08db13975950 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 23:08:16.5618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UhRs4kagBoBCCTRMpDtSN00Muu0V5zKT1ixaI6KxSSnfO843mqxxuC9NqCpr1YAeQT3lYx2229mwHRZm7FTQuLsEbhyieQkYVsi8o4GXK80= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5589 On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: > Remove the forward declaration of struct vcpu because it is not used. Huh, turns out that was my fault in c/s b158e72abe, shortly after I introduced them in the first place. Also, looking into that, there's one legitimate use of svm.h from outside, which is svm_load_segs*() which means we can't make all the headers be local. But still, most of svm.h shouldn't be includable in the rest of Xen.  Perhaps we can make a separate dedicated header for just this. [edit]  And svm_{doman,vcpu}.  Perhaps we want a brand new include/asm/hvm/svm.h with only the things needed elsewhere. > Move the forward declaration of struct cpu_user_regs just above the > function that needs it (to remind that it will need to be removed > along with the function). I'm not sure.  This feels like churn. > Move the definitions of NPT_PFEC_with_gla and NPT_PFEC_in_gpt in svm.c > because they are used only in this file. IMO, these would better live in vmcb.h because that's where all the other decode information lives, not that there is much.  I previously started trying to convert all the exit_into fields into a typed union, but I didn't get as far the NPT info. > Move the definitions of SVM_PAUSE{FILTER,THRESH}_INIT in vmcb.c because > they are used only in this file. Honestly, at this point you might as well just delete the defines, and opencode at their single usage site.  They're pure obfuscation like this, given no statement of units / behaviour, etc. That said, we do need to stea^W borrow adaptive PLE, and make the settings hvm-common because right now we've got two different ways of configuring the same thing for VT-x and SVM.  (This is definitely not cleanup work.  Just an observation for anyone feeling at a loose end.) ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 20 23:14:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 20 Feb 2023 23:14:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498461.769351 (Exim 4.92) (envelope-from ) id 1pUFMB-0001vD-9q; Mon, 20 Feb 2023 23:14:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498461.769351; Mon, 20 Feb 2023 23:14:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFMB-0001v6-6m; Mon, 20 Feb 2023 23:14:03 +0000 Received: by outflank-mailman (input) for mailman id 498461; Mon, 20 Feb 2023 23:14:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUFM8-0001v0-M9 for xen-devel@lists.xenproject.org; Mon, 20 Feb 2023 23:14:01 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 402295d1-b174-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 00:13:57 +0100 (CET) Received: from pps.filterd (m0174683.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 31KIu5a8006483; Mon, 20 Feb 2023 23:13:47 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3ntppmub60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 23:13:47 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by PA4PR03MB7359.eurprd03.prod.outlook.com (2603:10a6:102:108::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Mon, 20 Feb 2023 23:13:43 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::967e:573a:15a9:176e%4]) with mapi id 15.20.6111.018; Mon, 20 Feb 2023 23:13:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 402295d1-b174-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8qjVVwchmGFx1zHjNMoXjjVFJhAt8yM7uQWlohKX38RgJQpQHNpNSiQbuQkFOZYTqZVb8f8hyDO9vLAVx0W7kNAJlkJKLRazO2qax1yvYSgnZ+qU9TJnBZLtZsdIgjGWx35KNm+AJwLLM+F6SE5RpTSDO6oojxflbigy7XpC4Pz8dfD47RJ+ZWtLqVxDplv/gbJFhF5Fwkym/piZTDnPXf9XBfJgcJWnnwntc1MndbfeD4zJcmlrYtUIrDX6m21erCEviJ3aQzmfilEkkERntF1N6pTWKfqD6mrwcFTPtlfT/RB3qs8tL7sxUtQ8Ye21RHCwFFwDgZsOKAiI3Mu4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6HdyQVikCAk0DiXQKPnFgkUdHnGtAYV79Mdm9px+6HA=; b=G4j3vC11Vy9ElJgUhJSta1CgSbs0a053n/hw5mK6h+ZDDP7+zIzPmRO3BEWNh9NfmEYnY0tJmaK71IFHCRU773G7KMNXW1SgqSvwO+H9OqGtWDTUBSgF849CaNt3KJGmOhtFEUmTzhnoh+zsASedvp1eF2JzZTydOCxdvznE119nX/er5icBGPdc2KBpQ0/wzBY8Eu5dOZubmD9mUeDmmfyVz8GD4fcT2dMA+Nqxa+/vwaQX1mPqvyk5iGEIv+xN2Ep9SycHPPIYKxdoRSwvWgG7PdLpjUeoNgDHyjIZ2Dcqos9G/2Ki2oc3VSfDKWytjSIgCbgYDYEDFckcm1fNvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6HdyQVikCAk0DiXQKPnFgkUdHnGtAYV79Mdm9px+6HA=; b=o9ww2K0X0vWnvyiPdJS+W0kqyAYSATXpxeMK77r3P3asQ8d9H6IUPyX5o8VYOL7LKZVrCl41uRT2PK+XOzV3E5cXFBATdMkDGb7rqWKR29aQRUr9+DNV2Usd56LE0wgbCyU+13AsoSW/TKLTnrgjoz+4OEjjcbSk0kXwsiS7mGgZiY0fYXvBXCZAInOw6DsMy0ptZJVb592gCZIGJY07OE36TDDQ4lhxeU9YwejVl3gxNqWKgkzhjm0pu43PfCAEgVf07Fqakcrs6o9Bjd1QM6IVK9SjxsP3OLkg1R71usosiCyyBbDNb/zQdHMXTkqGFBg89Lb31ce6oLC61IWVSw== From: Volodymyr Babchuk To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Paul Durrant , Kevin Tian Subject: Re: [RFC PATCH 08/10] xen: pci: remove pcidev_[un]lock[ed] calls Thread-Topic: [RFC PATCH 08/10] xen: pci: remove pcidev_[un]lock[ed] calls Thread-Index: AQHYvUN/BRbyNewJG0OqhFjBUWUt7a6z9h8AgCWO7AA= Date: Mon, 20 Feb 2023 23:13:42 +0000 Message-ID: <875ybwylp6.fsf@epam.com> References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-9-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.8.9; emacs 28.2 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: VI1PR03MB3710:EE_|PA4PR03MB7359:EE_ x-ms-office365-filtering-correlation-id: 7a380ca0-2fc6-42a7-3b7f-08db13981bf3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HLgDPCm5OkDyPD5YXSO+LZ1Zs/vGgQ1bZFR+i9twKK88FpeJaw8yU081lI5oyQ7lobogfggWNP3ohhbZe1YkfUkbuZBCFw4wmvp2J4vrcR+if1w0LzXcgMiE2TAbufH+ei7ZX0rjPC/74QmDT5Znq4vmp1Ehl5kkaVj6I4vqiTCab2MUzH1lF9GFrGN0KsiOvrlVpPQ/5u9Hw7ebF2VdnTy41vNR75L9T538WzWTrWi8jDHsq2dwLOhBYCCSsXHz1luWLYuavXofmfmKgaKJu1EXnRuR3vyxHHfdvMHX+bigRR1RdIAjYc053iT9jRD/w5nw4Ul13K5ApFZADSjx6KyvSVJ/wDUJlLWntK6+2R4GU6tpfXw4Xw3H1v0hv8BGKQin8q9pYSTm9lvmW1Fswle3R8L7qFKAb4q3vl3H0fCZ4UddRd5Zp1RRjCDuh0tvl1d781RWPzD/luZUC+kqX/9XMwXvuy9aAftWJs8MjhfdpIu9DWFjZTwm0c4s6MjdVyDLoOZhNdqRL+aN6TbFnchYeMInn0juNIxrxmxaJaPr6QAx4xGAa4XLFlh4efJSi1nH+12LAsK5GEMZ/lKMQDOJnsa0/TZ4sxR0BljJL0JzlGUgEUt1w2s6fA0g9KvXG68vdi6oINhbGOWNKpfZeK4SDJMl0MMHEWj/3iCkad0BAPOov5c6HGz3AiBslMoDojulf9BlcrFtTVKGT6Oau+ILbM0KLu1DxyEZJD/QvL4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199018)(38100700002)(83380400001)(122000001)(36756003)(38070700005)(86362001)(2906002)(8936002)(41300700001)(30864003)(5660300002)(7416002)(6512007)(26005)(55236004)(186003)(6506007)(2616005)(91956017)(4326008)(316002)(6916009)(66556008)(76116006)(8676002)(66946007)(66446008)(66476007)(71200400001)(6486002)(54906003)(64756008)(478600001)(21314003)(559001)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?g1TDgcqq4BCrf90DEr9b276Kd2EnkuBZ4vxNlBCqpoqEEIqe8/Z2C1e1rQ?= =?iso-8859-1?Q?MkvU0RAUb5GPxHOLlpRDsHm18AVpcoVUuY4vUrpb+UhuKRp6P7pBOomXNJ?= =?iso-8859-1?Q?CxOhFQbSfE45ku56wWWNWD8cIHvHzrTb3x+qNPjuf/we5hFZIW2+suQ/iB?= =?iso-8859-1?Q?6j2fXtZxqr40TVgNmbZ1poe2bGWX2cyguCrWn/Xs+IuGyVQhEg5VrGqCz+?= =?iso-8859-1?Q?ATxgk2q9QlewkkQW8PsLmcqSAwonMIxzKeWZvE722ZUbd+hmiqi3fVmjsO?= =?iso-8859-1?Q?wa+xi6HlnidwXuKC831CG1lrDYv5PCJoxHQGZ8Ja3yXZWJkxXhQ4Zqj07J?= =?iso-8859-1?Q?Vza7YgCpWnPhqw8LFzhXvum/MmJkIYKtPkPDEcxny03wOVgmHuD7UG5SnG?= =?iso-8859-1?Q?Vu0CCxLKTz6BpybORgwPhhU02GeJssl1dRPUq2ij4J28iqL2IfhrJe+QlO?= =?iso-8859-1?Q?c4BZSHm+fr93Ixndz2ga1dQh34M20OK08G8CgBxzFVw5W1KbiN2tc2KLC6?= =?iso-8859-1?Q?VlM9dtwHygfnDTnwE1hvNy7WW0h9M4vp9KHb9nYBae4JCOkJCsbQveSFPr?= =?iso-8859-1?Q?IgvHS3nUHxs/NDrj/N+UxV6gYzm5OljRz4UkzOMPhHOZdSlR2Oau2ab6/T?= =?iso-8859-1?Q?DocyJKfBC8JrU7CenFWebEcZnJ8gqEFLpikFGHDbV7GntuGswGNoZuVogC?= =?iso-8859-1?Q?+290XqIxC5xGJdLqAhlKwPESe/aAWFpBhqzrog0Csndcviw5WrTavSJ21o?= =?iso-8859-1?Q?6Xl8sqVSPlxrs6bkSH+rNetxkWKmbcQltcXoL4v6g9TZqDld8k5q3cvvYw?= =?iso-8859-1?Q?9CoGqW4i0ASIiUpBc5j5XSHPBuUu/fBQtWVpvgQh6LVyjWsLS2Cag7QoCb?= =?iso-8859-1?Q?NPjvkL7/zLYeN7R1o970ZjvOBFND55Kju4ZyYjoZpR+dupK/EVYXY3XGzG?= =?iso-8859-1?Q?WuoWOSDhBH7iMvwTEKXU7uiZUIyNmNJZUEKeKsUmQglAg9uytegfLjTg/o?= =?iso-8859-1?Q?ElUbBsw8lJsxyyBcd9i31u+Ze9A21Nfrgu4EV7edLwHAfMFU2IOiJW7G8p?= =?iso-8859-1?Q?mJrPJ/BPBGDjDL2zhGHleDM/+LYv9u9kYFXA2oBaQQ3PT7Vm/YRx+3ydGb?= =?iso-8859-1?Q?ciy3EVsKB++fIV2MB6P1BQUV9zC1kMbyTDwYTf3f2beaiUfuyKu8u2FArm?= =?iso-8859-1?Q?f+7hE9g8XrZU3OZog9AFRf9CUHia3oKrSGySIXwpo21dNqsm6WCRzvv47/?= =?iso-8859-1?Q?qU+Bp5zaGilIVqGd4ngxHhoCCv3T1Ux4mqJ9BI/L8HUXemIs45K4XCYFos?= =?iso-8859-1?Q?3hNnNpABrm5JDirGGFgoBGjHZQ5RtsyPWUKvYOPZWq7pknc7bAO8Pb1E4H?= =?iso-8859-1?Q?hwcOlcN96X/nArmjPajPHp0vztrU5s4/er0LRQbUsH7NMS89v4qAtfpJqL?= =?iso-8859-1?Q?s9hfLs7Sqe1tDZm7N0fZ8ejOwJhykJ/kXxiK9t8DQojnPruiVKsXUUpJ57?= =?iso-8859-1?Q?qZ4WqW8ip5Io/imxwTzYTKfN8Ka/I//EWeV280WNdPbfn9iCwEZiFJJ99l?= =?iso-8859-1?Q?VmrUE9LsmZ/UcgaIxjLJukqkcCNN2sHRL0FTuM9ShbO3SqEA4YaMOtBVSB?= =?iso-8859-1?Q?KOmEBbatrwoSwv+AzljKzFXDdtay1Gj22TJKHJo36qgcVI3ZNxI/EILQ?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a380ca0-2fc6-42a7-3b7f-08db13981bf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 23:13:42.7782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0twmNBvYcKJdKA/oZkkGKI9hs0vCY/iH1Kmz7sU2WAyQBN83beGwSpVRecGvO9otDLIGZPBDAApxNP37d+7gE5zJcY3LWfFH5Tseq2QTKvM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7359 X-Proofpoint-ORIG-GUID: d9_ZB4r4jGjINRMZoH4VmqsrcSLMvzgr X-Proofpoint-GUID: d9_ZB4r4jGjINRMZoH4VmqsrcSLMvzgr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_17,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302200215 Hi Stefano, Stefano Stabellini writes: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> As pci devices are refcounted now and all list that store them are >> protected by separate locks, we can safely drop global pcidevs_lock. >>=20 >> Signed-off-by: Volodymyr Babchuk > > Up until this patch this patch series introduces: > - d->pdevs_lock to protect d->pdev_list > - pci_seg->alldevs_lock to protect pci_seg->alldevs_list > - iommu->ats_list_lock to protect iommu->ats_devices > - pdev refcounting to detect a pdev in-use and when to free it > - pdev->lock to protect pdev->msi_list > > They cover a lot of ground. Are they collectively covering everything > pcidevs_lock() was protecting? Well, that is the question. Those patch are in RFC stage because I can't fully answer your question. I tried my best to introduce proper locking, but apparently missed couple of places, like > deassign_device is not protected by pcidevs_lock anymore. > deassign_device accesses a number of pdev fields, including quarantine, > phantom_stride and fault.count. > > deassign_device could run at the same time as assign_device who sets > quarantine and other fields. > I hope this is all, but problem is that PCI subsystem is old, large and complex. Fo example, as I wrote earlier, there are places that are protected with pcidevs_lock(), but do nothing with PCI. I just don't know what to do with such places. I have a hope that x86 maintainers would review my changes and give feedback on missed spots. > It looks like assign_device, deassign_device, and other functions > accessing/modifying pdev fields should be protected by pdev->lock. You are right, I'll check again this whole patch to identify places where additional locks are required. I already have some candidates besides those you mentioned above. > In fact, I think it would be safer to make sure every place that > currently has a pcidevs_lock() gets a pdev->lock (unless there is a > d->pdevs_lock, pci_seg->alldevs_lock, iommu->ats_list_lock, or another > lock) ? I'll try, but problem is that there are places where we don't have pointer to pdev, so it is not clear what exactly should be locked. > >> --- >> xen/arch/x86/domctl.c | 8 --- >> xen/arch/x86/hvm/vioapic.c | 2 - >> xen/arch/x86/hvm/vmsi.c | 12 ---- >> xen/arch/x86/irq.c | 7 --- >> xen/arch/x86/msi.c | 11 ---- >> xen/arch/x86/pci.c | 4 -- >> xen/arch/x86/physdev.c | 7 +-- >> xen/common/sysctl.c | 2 - >> xen/drivers/char/ns16550.c | 4 -- >> xen/drivers/passthrough/amd/iommu_init.c | 7 --- >> xen/drivers/passthrough/amd/iommu_map.c | 5 -- >> xen/drivers/passthrough/amd/pci_amd_iommu.c | 4 -- >> xen/drivers/passthrough/pci.c | 63 +-------------------- >> xen/drivers/passthrough/vtd/iommu.c | 8 --- >> xen/drivers/video/vga.c | 2 - >> 15 files changed, 4 insertions(+), 142 deletions(-) >>=20 >> diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c >> index 020df615bd..9f4ca03385 100644 >> --- a/xen/arch/x86/domctl.c >> +++ b/xen/arch/x86/domctl.c >> @@ -537,11 +537,7 @@ long arch_do_domctl( >> =20 >> ret =3D -ESRCH; >> if ( is_iommu_enabled(d) ) >> - { >> - pcidevs_lock(); >> ret =3D pt_irq_create_bind(d, bind); >> - pcidevs_unlock(); >> - } >> if ( ret < 0 ) >> printk(XENLOG_G_ERR "pt_irq_create_bind failed (%ld) for do= m%d\n", >> ret, d->domain_id); >> @@ -566,11 +562,7 @@ long arch_do_domctl( >> break; >> =20 >> if ( is_iommu_enabled(d) ) >> - { >> - pcidevs_lock(); >> ret =3D pt_irq_destroy_bind(d, bind); >> - pcidevs_unlock(); >> - } >> if ( ret < 0 ) >> printk(XENLOG_G_ERR "pt_irq_destroy_bind failed (%ld) for d= om%d\n", >> ret, d->domain_id); >> diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c >> index cb7f440160..aa4e7766a3 100644 >> --- a/xen/arch/x86/hvm/vioapic.c >> +++ b/xen/arch/x86/hvm/vioapic.c >> @@ -197,7 +197,6 @@ static int vioapic_hwdom_map_gsi(unsigned int gsi, u= nsigned int trig, >> return ret; >> } >> =20 >> - pcidevs_lock(); >> ret =3D pt_irq_create_bind(currd, &pt_irq_bind); >> if ( ret ) >> { >> @@ -207,7 +206,6 @@ static int vioapic_hwdom_map_gsi(unsigned int gsi, u= nsigned int trig, >> unmap_domain_pirq(currd, pirq); >> write_unlock(&currd->event_lock); >> } >> - pcidevs_unlock(); >> =20 >> return ret; >> } >> diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c >> index c9e5f279c5..344bbd646c 100644 >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -470,7 +470,6 @@ int msixtbl_pt_register(struct domain *d, struct pir= q *pirq, uint64_t gtable) >> struct msixtbl_entry *entry, *new_entry; >> int r =3D -EINVAL; >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(rw_is_write_locked(&d->event_lock)); >> =20 >> if ( !msixtbl_initialised(d) ) >> @@ -540,7 +539,6 @@ void msixtbl_pt_unregister(struct domain *d, struct = pirq *pirq) >> struct pci_dev *pdev; >> struct msixtbl_entry *entry; >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(rw_is_write_locked(&d->event_lock)); >> =20 >> if ( !msixtbl_initialised(d) ) >> @@ -686,8 +684,6 @@ static int vpci_msi_update(const struct pci_dev *pde= v, uint32_t data, >> { >> unsigned int i; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( (address & MSI_ADDR_BASE_MASK) !=3D MSI_ADDR_HEADER ) >> { >> gdprintk(XENLOG_ERR, "%pp: PIRQ %u: unsupported address %lx\n", >> @@ -728,7 +724,6 @@ void vpci_msi_arch_update(struct vpci_msi *msi, cons= t struct pci_dev *pdev) >> =20 >> ASSERT(msi->arch.pirq !=3D INVALID_PIRQ); >> =20 >> - pcidevs_lock(); >> for ( i =3D 0; i < msi->vectors && msi->arch.bound; i++ ) >> { >> struct xen_domctl_bind_pt_irq unbind =3D { >> @@ -747,7 +742,6 @@ void vpci_msi_arch_update(struct vpci_msi *msi, cons= t struct pci_dev *pdev) >> =20 >> msi->arch.bound =3D !vpci_msi_update(pdev, msi->data, msi->address, >> msi->vectors, msi->arch.pirq, ms= i->mask); >> - pcidevs_unlock(); >> } >> =20 >> static int vpci_msi_enable(const struct pci_dev *pdev, unsigned int nr, >> @@ -785,10 +779,8 @@ int vpci_msi_arch_enable(struct vpci_msi *msi, cons= t struct pci_dev *pdev, >> return rc; >> msi->arch.pirq =3D rc; >> =20 >> - pcidevs_lock(); >> msi->arch.bound =3D !vpci_msi_update(pdev, msi->data, msi->address,= vectors, >> msi->arch.pirq, msi->mask); >> - pcidevs_unlock(); >> =20 >> return 0; >> } >> @@ -800,7 +792,6 @@ static void vpci_msi_disable(const struct pci_dev *p= dev, int pirq, >> =20 >> ASSERT(pirq !=3D INVALID_PIRQ); >> =20 >> - pcidevs_lock(); >> for ( i =3D 0; i < nr && bound; i++ ) >> { >> struct xen_domctl_bind_pt_irq bind =3D { >> @@ -816,7 +807,6 @@ static void vpci_msi_disable(const struct pci_dev *p= dev, int pirq, >> write_lock(&pdev->domain->event_lock); >> unmap_domain_pirq(pdev->domain, pirq); >> write_unlock(&pdev->domain->event_lock); >> - pcidevs_unlock(); >> } >> =20 >> void vpci_msi_arch_disable(struct vpci_msi *msi, const struct pci_dev *= pdev) >> @@ -863,7 +853,6 @@ int vpci_msix_arch_enable_entry(struct vpci_msix_ent= ry *entry, >> =20 >> entry->arch.pirq =3D rc; >> =20 >> - pcidevs_lock(); >> rc =3D vpci_msi_update(pdev, entry->data, entry->addr, 1, entry->ar= ch.pirq, >> entry->masked); >> if ( rc ) >> @@ -871,7 +860,6 @@ int vpci_msix_arch_enable_entry(struct vpci_msix_ent= ry *entry, >> vpci_msi_disable(pdev, entry->arch.pirq, 1, false); >> entry->arch.pirq =3D INVALID_PIRQ; >> } >> - pcidevs_unlock(); >> =20 >> return rc; >> } >> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c >> index d8672a03e1..6a08830a55 100644 >> --- a/xen/arch/x86/irq.c >> +++ b/xen/arch/x86/irq.c >> @@ -2156,8 +2156,6 @@ int map_domain_pirq( >> struct pci_dev *pdev; >> unsigned int nr =3D 0; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> ret =3D -ENODEV; >> if ( !cpu_has_apic ) >> goto done; >> @@ -2317,7 +2315,6 @@ int unmap_domain_pirq(struct domain *d, int pirq) >> if ( (pirq < 0) || (pirq >=3D d->nr_pirqs) ) >> return -EINVAL; >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(rw_is_write_locked(&d->event_lock)); >> =20 >> info =3D pirq_info(d, pirq); >> @@ -2423,7 +2420,6 @@ void free_domain_pirqs(struct domain *d) >> { >> int i; >> =20 >> - pcidevs_lock(); >> write_lock(&d->event_lock); >> =20 >> for ( i =3D 0; i < d->nr_pirqs; i++ ) >> @@ -2431,7 +2427,6 @@ void free_domain_pirqs(struct domain *d) >> unmap_domain_pirq(d, i); >> =20 >> write_unlock(&d->event_lock); >> - pcidevs_unlock(); >> } >> =20 >> static void cf_check dump_irqs(unsigned char key) >> @@ -2911,7 +2906,6 @@ int allocate_and_map_msi_pirq(struct domain *d, in= t index, int *pirq_p, >> =20 >> msi->irq =3D irq; >> =20 >> - pcidevs_lock(); >> /* Verify or get pirq. */ >> write_lock(&d->event_lock); >> pirq =3D allocate_pirq(d, index, *pirq_p, irq, type, &msi->entry_nr= ); >> @@ -2927,7 +2921,6 @@ int allocate_and_map_msi_pirq(struct domain *d, in= t index, int *pirq_p, >> =20 >> done: >> write_unlock(&d->event_lock); >> - pcidevs_unlock(); >> if ( ret ) >> { >> switch ( type ) >> diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c >> index 6b62c4f452..f04b90e235 100644 >> --- a/xen/arch/x86/msi.c >> +++ b/xen/arch/x86/msi.c >> @@ -623,7 +623,6 @@ static int msi_capability_init(struct pci_dev *dev, >> u8 slot =3D PCI_SLOT(dev->devfn); >> u8 func =3D PCI_FUNC(dev->devfn); >> =20 >> - ASSERT(pcidevs_locked()); >> pos =3D pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSI); >> if ( !pos ) >> return -ENODEV; >> @@ -810,8 +809,6 @@ static int msix_capability_init(struct pci_dev *dev, >> if ( !pos ) >> return -ENODEV; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> control =3D pci_conf_read16(dev->sbdf, msix_control_reg(pos)); >> /* >> * Ensure MSI-X interrupts are masked during setup. Some devices re= quire >> @@ -1032,7 +1029,6 @@ static int __pci_enable_msi(struct msi_info *msi, = struct msi_desc **desc) >> struct msi_desc *old_desc; >> int ret; >> =20 >> - ASSERT(pcidevs_locked()); >> pdev =3D pci_get_pdev(NULL, msi->sbdf); >> if ( !pdev ) >> return -ENODEV; >> @@ -1092,7 +1088,6 @@ static int __pci_enable_msix(struct msi_info *msi,= struct msi_desc **desc) >> struct msi_desc *old_desc; >> int ret; >> =20 >> - ASSERT(pcidevs_locked()); >> pdev =3D pci_get_pdev(NULL, msi->sbdf); >> if ( !pdev || !pdev->msix ) >> return -ENODEV; >> @@ -1191,7 +1186,6 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bo= ol off) >> if ( !use_msi ) >> return 0; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(seg, bus, devfn)); >> if ( !pdev ) >> rc =3D -ENODEV; >> @@ -1204,7 +1198,6 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bo= ol off) >> } >> else >> rc =3D msix_capability_init(pdev, NULL, NULL); >> - pcidevs_unlock(); >> =20 >> pcidev_put(pdev); >> =20 >> @@ -1217,8 +1210,6 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bo= ol off) >> */ >> int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc) >> { >> - ASSERT(pcidevs_locked()); >> - >> if ( !use_msi ) >> return -EPERM; >> =20 >> @@ -1355,8 +1346,6 @@ int pci_restore_msi_state(struct pci_dev *pdev) >> unsigned int type =3D 0, pos =3D 0; >> u16 control =3D 0; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( !use_msi ) >> return -EOPNOTSUPP; >> =20 >> diff --git a/xen/arch/x86/pci.c b/xen/arch/x86/pci.c >> index 1d38f0df7c..4dcd6d96f3 100644 >> --- a/xen/arch/x86/pci.c >> +++ b/xen/arch/x86/pci.c >> @@ -88,15 +88,11 @@ int pci_conf_write_intercept(unsigned int seg, unsig= ned int bdf, >> if ( reg < 64 || reg >=3D 256 ) >> return 0; >> =20 >> - pcidevs_lock(); >> - >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(seg, bdf)); >> if ( pdev ) { >> rc =3D pci_msi_conf_write_intercept(pdev, reg, size, data); >> pcidev_put(pdev); >> } >> =20 >> - pcidevs_unlock(); >> - >> return rc; >> } >> diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c >> index 96214a3d40..a41366b609 100644 >> --- a/xen/arch/x86/physdev.c >> +++ b/xen/arch/x86/physdev.c >> @@ -162,11 +162,9 @@ int physdev_unmap_pirq(domid_t domid, int pirq) >> goto free_domain; >> } >> =20 >> - pcidevs_lock(); >> write_lock(&d->event_lock); >> ret =3D unmap_domain_pirq(d, pirq); >> write_unlock(&d->event_lock); >> - pcidevs_unlock(); >> =20 >> free_domain: >> rcu_unlock_domain(d); >> @@ -530,7 +528,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(= void) arg) >> if ( copy_from_guest(&restore_msi, arg, 1) !=3D 0 ) >> break; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, >> PCI_SBDF(0, restore_msi.bus, restore_msi.de= vfn)); >> if ( pdev ) >> @@ -541,7 +538,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(= void) arg) >> else >> ret =3D -ENODEV; >> =20 >> - pcidevs_unlock(); >> break; >> } >> =20 >> @@ -553,7 +549,6 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(= void) arg) >> if ( copy_from_guest(&dev, arg, 1) !=3D 0 ) >> break; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(dev.seg, dev.bus, dev.devf= n)); >> if ( pdev ) >> { >> @@ -562,7 +557,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(= void) arg) >> } >> else >> ret =3D -ENODEV; >> - pcidevs_unlock(); >> + >> break; >> } >> =20 >> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c >> index 0feef94cd2..6bb8c5c295 100644 >> --- a/xen/common/sysctl.c >> +++ b/xen/common/sysctl.c >> @@ -446,7 +446,6 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) = u_sysctl) >> break; >> } >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(dev.seg, dev.bus, dev.= devfn)); >> if ( !pdev ) >> node =3D XEN_INVALID_DEV; >> @@ -454,7 +453,6 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) = u_sysctl) >> node =3D XEN_INVALID_NODE_ID; >> else >> node =3D pdev->node; >> - pcidevs_unlock(); >> =20 >> if ( pdev ) >> pcidev_put(pdev); >> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c >> index 01a05c9aa8..66c10b18e5 100644 >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -445,8 +445,6 @@ static void __init cf_check ns16550_init_postirq(str= uct serial_port *port) >> { >> struct msi_desc *msi_desc =3D NULL; >> =20 >> - pcidevs_lock(); >> - >> rc =3D pci_enable_msi(&msi, &msi_desc); >> if ( !rc ) >> { >> @@ -460,8 +458,6 @@ static void __init cf_check ns16550_init_postirq(str= uct serial_port *port) >> pci_disable_msi(msi_desc); >> } >> =20 >> - pcidevs_unlock(); >> - >> if ( rc ) >> { >> uart->irq =3D 0; >> diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/pass= through/amd/iommu_init.c >> index 7c1713a602..e42af65a40 100644 >> --- a/xen/drivers/passthrough/amd/iommu_init.c >> +++ b/xen/drivers/passthrough/amd/iommu_init.c >> @@ -638,10 +638,7 @@ static void cf_check parse_ppr_log_entry(struct amd= _iommu *iommu, u32 entry[]) >> uint16_t device_id =3D iommu_get_devid_from_cmd(entry[0]); >> struct pci_dev *pdev; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_real_pdev(PCI_SBDF(iommu->seg, device_id)); >> - pcidevs_unlock(); >> - >> if ( pdev ) >> guest_iommu_add_ppr_log(pdev->domain, entry); >> pcidev_put(pdev); >> @@ -747,14 +744,12 @@ static bool_t __init set_iommu_interrupt_handler(s= truct amd_iommu *iommu) >> return 0; >> } >> =20 >> - pcidevs_lock(); >> /* >> * XXX: it is unclear if this device can be removed. Right now >> * there is no code that clears msi.dev, so no one will decrease >> * refcount on it. >> */ >> iommu->msi.dev =3D pci_get_pdev(NULL, PCI_SBDF(iommu->seg, iommu->b= df)); >> - pcidevs_unlock(); >> if ( !iommu->msi.dev ) >> { >> AMD_IOMMU_WARN("no pdev for %pp\n", >> @@ -1289,9 +1284,7 @@ static int __init cf_check amd_iommu_setup_device_= table( >> { >> if ( !pci_init ) >> continue; >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(seg, bdf)); >> - pcidevs_unlock(); >> } >> =20 >> if ( pdev && (pdev->msix || pdev->msi_maxvec) ) >> diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passt= hrough/amd/iommu_map.c >> index 9d621e3d36..d04aa37538 100644 >> --- a/xen/drivers/passthrough/amd/iommu_map.c >> +++ b/xen/drivers/passthrough/amd/iommu_map.c >> @@ -726,9 +726,7 @@ int cf_check amd_iommu_get_reserved_device_memory( >> /* May need to trigger the workaround in find_iommu_for_dev= ice(). */ >> struct pci_dev *pdev; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, sbdf); >> - pcidevs_unlock(); >> =20 >> if ( pdev ) >> { >> @@ -848,7 +846,6 @@ int cf_check amd_iommu_quarantine_init(struct pci_de= v *pdev, bool scratch_page) >> const struct ivrs_mappings *ivrs_mappings =3D get_ivrs_mappings(pde= v->seg); >> int rc; >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(!hd->arch.amd.root_table); >> ASSERT(page_list_empty(&hd->arch.pgtables.list)); >> =20 >> @@ -903,8 +900,6 @@ void amd_iommu_quarantine_teardown(struct pci_dev *p= dev) >> { >> struct domain_iommu *hd =3D dom_iommu(dom_io); >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( !pdev->arch.amd.root_table ) >> return; >> =20 >> diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/p= assthrough/amd/pci_amd_iommu.c >> index 955f3af57a..919e30129e 100644 >> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c >> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c >> @@ -268,8 +268,6 @@ static int __must_check amd_iommu_setup_domain_devic= e( >> req_id, pdev->type, page_to_maddr(root_pg), >> domid, hd->arch.amd.paging_mode); >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( pci_ats_device(iommu->seg, bus, pdev->devfn) && >> !ivrs_dev->block_ats && >> iommu_has_cap(iommu, PCI_CAP_IOTLB_SHIFT) && >> @@ -416,8 +414,6 @@ static void amd_iommu_disable_domain_device(const st= ruct domain *domain, >> if ( QUARANTINE_SKIP(domain, pdev) ) >> return; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( pci_ats_device(iommu->seg, bus, pdev->devfn) && >> pci_ats_enabled(iommu->seg, bus, pdev->devfn) ) >> { >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci= .c >> index c83397211b..cc62a5aec4 100644 >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -517,7 +517,6 @@ int __init pci_hide_device(unsigned int seg, unsigne= d int bus, >> struct pci_seg *pseg; >> int rc =3D -ENOMEM; >> =20 >> - pcidevs_lock(); >> pseg =3D alloc_pseg(seg); >> if ( pseg ) >> { >> @@ -528,7 +527,6 @@ int __init pci_hide_device(unsigned int seg, unsigne= d int bus, >> rc =3D 0; >> } >> } >> - pcidevs_unlock(); >> =20 >> return rc; >> } >> @@ -588,8 +586,6 @@ struct pci_dev *pci_get_pdev(struct domain *d, pci_s= bdf_t sbdf) >> { >> struct pci_dev *pdev; >> =20 >> - ASSERT(d || pcidevs_locked()); >> - >> /* >> * The hardware domain owns the majority of the devices in the syst= em. >> * When there are multiple segments, traversing the per-segment lis= t is >> @@ -730,7 +726,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> pdev_type =3D "device"; >> else if ( info->is_virtfn ) >> { >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, >> PCI_SBDF(seg, info->physfn.bus, >> info->physfn.devfn)); >> @@ -739,7 +734,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> pf_is_extfn =3D pdev->info.is_extfn; >> pcidev_put(pdev); >> } >> - pcidevs_unlock(); >> if ( !pdev ) >> pci_add_device(seg, info->physfn.bus, info->physfn.devfn, >> NULL, node); >> @@ -756,7 +750,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> =20 >> ret =3D -ENOMEM; >> =20 >> - pcidevs_lock(); >> pseg =3D alloc_pseg(seg); >> if ( !pseg ) >> goto out; >> @@ -858,7 +851,6 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> pci_enable_acs(pdev); >> =20 >> out: >> - pcidevs_unlock(); >> if ( !ret ) >> { >> printk(XENLOG_DEBUG "PCI add %s %pp\n", pdev_type, &pdev->sbdf= ); >> @@ -889,7 +881,6 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn) >> if ( !pseg ) >> return -ENODEV; >> =20 >> - pcidevs_lock(); >> spin_lock(&pseg->alldevs_lock); >> list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list ) >> if ( pdev->bus =3D=3D bus && pdev->devfn =3D=3D devfn ) >> @@ -910,12 +901,10 @@ int pci_remove_device(u16 seg, u8 bus, u8 devfn) >> break; >> } >> =20 >> - pcidevs_unlock(); >> spin_unlock(&pseg->alldevs_lock); >> return ret; >> } >> =20 >> -/* Caller should hold the pcidevs_lock */ >> static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, >> uint8_t devfn) >> { >> @@ -927,7 +916,6 @@ static int deassign_device(struct domain *d, uint16_= t seg, uint8_t bus, >> if ( !is_iommu_enabled(d) ) >> return -EINVAL; >> =20 >> - ASSERT(pcidevs_locked()); >> pdev =3D pci_get_pdev(d, PCI_SBDF(seg, bus, devfn)); >> if ( !pdev ) >> return -ENODEV; >> @@ -981,13 +969,10 @@ int pci_release_devices(struct domain *d) >> u8 bus, devfn; >> int ret; >> =20 >> - pcidevs_lock(); >> ret =3D arch_pci_clean_pirqs(d); >> if ( ret ) >> - { >> - pcidevs_unlock(); >> return ret; >> - } >> + >> spin_lock(&d->pdevs_lock); >> list_for_each_entry_safe ( pdev, tmp, &d->pdev_list, domain_list ) >> { >> @@ -996,7 +981,6 @@ int pci_release_devices(struct domain *d) >> ret =3D deassign_device(d, pdev->seg, bus, devfn) ?: ret; >> } >> spin_unlock(&d->pdevs_lock); >> - pcidevs_unlock(); >> =20 >> return ret; >> } >> @@ -1094,7 +1078,6 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 = devfn) >> s_time_t now =3D NOW(); >> u16 cword; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_real_pdev(PCI_SBDF(seg, bus, devfn)); >> if ( pdev ) >> { >> @@ -1108,7 +1091,6 @@ void pci_check_disable_device(u16 seg, u8 bus, u8 = devfn) >> pdev =3D NULL; >> } >> } >> - pcidevs_unlock(); >> =20 >> if ( !pdev ) >> return; >> @@ -1164,13 +1146,7 @@ static int __init cf_check _scan_pci_devices(stru= ct pci_seg *pseg, void *arg) >> =20 >> int __init scan_pci_devices(void) >> { >> - int ret; >> - >> - pcidevs_lock(); >> - ret =3D pci_segments_iterate(_scan_pci_devices, NULL); >> - pcidevs_unlock(); >> - >> - return ret; >> + return pci_segments_iterate(_scan_pci_devices, NULL); >> } >> =20 >> struct setup_hwdom { >> @@ -1239,19 +1215,11 @@ static int __hwdom_init cf_check _setup_hwdom_pc= i_devices( >> =20 >> pcidev_put(pdev); >> if ( iommu_verbose ) >> - { >> - pcidevs_unlock(); >> process_pending_softirqs(); >> - pcidevs_lock(); >> - } >> } >> =20 >> if ( !iommu_verbose ) >> - { >> - pcidevs_unlock(); >> process_pending_softirqs(); >> - pcidevs_lock(); >> - } >> } >> =20 >> return 0; >> @@ -1262,9 +1230,7 @@ void __hwdom_init setup_hwdom_pci_devices( >> { >> struct setup_hwdom ctxt =3D { .d =3D d, .handler =3D handler }; >> =20 >> - pcidevs_lock(); >> pci_segments_iterate(_setup_hwdom_pci_devices, &ctxt); >> - pcidevs_unlock(); >> } >> =20 >> /* APEI not supported on ARM yet. */ >> @@ -1396,9 +1362,7 @@ static int cf_check _dump_pci_devices(struct pci_s= eg *pseg, void *arg) >> static void cf_check dump_pci_devices(unsigned char ch) >> { >> printk("=3D=3D=3D=3D PCI devices =3D=3D=3D=3D\n"); >> - pcidevs_lock(); >> pci_segments_iterate(_dump_pci_devices, NULL); >> - pcidevs_unlock(); >> } >> =20 >> static int __init cf_check setup_dump_pcidevs(void) >> @@ -1417,8 +1381,6 @@ static int iommu_add_device(struct pci_dev *pdev) >> if ( !pdev->domain ) >> return -EINVAL; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> hd =3D dom_iommu(pdev->domain); >> if ( !is_iommu_enabled(pdev->domain) ) >> return 0; >> @@ -1446,8 +1408,6 @@ static int iommu_enable_device(struct pci_dev *pde= v) >> if ( !pdev->domain ) >> return -EINVAL; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> hd =3D dom_iommu(pdev->domain); >> if ( !is_iommu_enabled(pdev->domain) || >> !hd->platform_ops->enable_device ) >> @@ -1494,7 +1454,6 @@ static int device_assigned(struct pci_dev *pdev) >> { >> int rc =3D 0; >> =20 >> - ASSERT(pcidevs_locked()); >> /* >> * If the device exists and it is not owned by either the hardware >> * domain or dom_io then it must be assigned to a guest, or be >> @@ -1507,7 +1466,6 @@ static int device_assigned(struct pci_dev *pdev) >> return rc; >> } >> =20 >> -/* Caller should hold the pcidevs_lock */ >> static int assign_device(struct domain *d, struct pci_dev *pdev, u32 fl= ag) >> { >> const struct domain_iommu *hd =3D dom_iommu(d); >> @@ -1521,7 +1479,6 @@ static int assign_device(struct domain *d, struct = pci_dev *pdev, u32 flag) >> return -EXDEV; >> =20 >> /* device_assigned() should already have cleared the device for ass= ignment */ >> - ASSERT(pcidevs_locked()); >> ASSERT(pdev && (pdev->domain =3D=3D hardware_domain || >> pdev->domain =3D=3D dom_io)); >> =20 >> @@ -1587,7 +1544,6 @@ static int iommu_get_device_group( >> if ( group_id < 0 ) >> return group_id; >> =20 >> - pcidevs_lock(); >> spin_lock(&d->pdevs_lock); >> for_each_pdev( d, pdev ) >> { >> @@ -1603,7 +1559,6 @@ static int iommu_get_device_group( >> sdev_id =3D iommu_call(ops, get_device_group_id, seg, b, df); >> if ( sdev_id < 0 ) >> { >> - pcidevs_unlock(); >> spin_unlock(&d->pdevs_lock); >> return sdev_id; >> } >> @@ -1614,7 +1569,6 @@ static int iommu_get_device_group( >> =20 >> if ( unlikely(copy_to_guest_offset(buf, i, &bdf, 1)) ) >> { >> - pcidevs_unlock(); >> spin_unlock(&d->pdevs_lock); >> return -EFAULT; >> } >> @@ -1622,7 +1576,6 @@ static int iommu_get_device_group( >> } >> } >> =20 >> - pcidevs_unlock(); >> spin_unlock(&d->pdevs_lock); >> =20 >> return i; >> @@ -1630,17 +1583,12 @@ static int iommu_get_device_group( >> =20 >> void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pd= ev) >> { >> - pcidevs_lock(); >> - >> /* iommu->ats_list_lock is taken by the caller of this function */ >> disable_ats_device(pdev); >> =20 >> ASSERT(pdev->domain); >> if ( d !=3D pdev->domain ) >> - { >> - pcidevs_unlock(); >> return; >> - } >> =20 >> pdev->broken =3D true; >> =20 >> @@ -1649,8 +1597,6 @@ void iommu_dev_iotlb_flush_timeout(struct domain *= d, struct pci_dev *pdev) >> d->domain_id, &pdev->sbdf); >> if ( !is_hardware_domain(d) ) >> domain_crash(d); >> - >> - pcidevs_unlock(); >> } >> =20 >> int iommu_do_pci_domctl( >> @@ -1740,7 +1686,6 @@ int iommu_do_pci_domctl( >> break; >> } >> =20 >> - pcidevs_lock(); >> ret =3D device_assigned(pdev); >> if ( domctl->cmd =3D=3D XEN_DOMCTL_test_assign_device ) >> { >> @@ -1755,7 +1700,7 @@ int iommu_do_pci_domctl( >> ret =3D assign_device(d, pdev, flags); >> =20 >> pcidev_put(pdev); >> - pcidevs_unlock(); >> + >> if ( ret =3D=3D -ERESTART ) >> ret =3D hypercall_create_continuation(__HYPERVISOR_domctl, >> "h", u_domctl); >> @@ -1787,9 +1732,7 @@ int iommu_do_pci_domctl( >> bus =3D PCI_BUS(machine_sbdf); >> devfn =3D PCI_DEVFN(machine_sbdf); >> =20 >> - pcidevs_lock(); >> ret =3D deassign_device(d, seg, bus, devfn); >> - pcidevs_unlock(); >> break; >> =20 >> default: >> diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrou= gh/vtd/iommu.c >> index 42661f22f4..87868188b7 100644 >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -1490,7 +1490,6 @@ int domain_context_mapping_one( >> if ( QUARANTINE_SKIP(domain, pgd_maddr) ) >> return 0; >> =20 >> - ASSERT(pcidevs_locked()); >> spin_lock(&iommu->lock); >> maddr =3D bus_to_context_maddr(iommu, bus); >> context_entries =3D (struct context_entry *)map_vtd_domain_page(mad= dr); >> @@ -1711,8 +1710,6 @@ static int domain_context_mapping(struct domain *d= omain, u8 devfn, >> if ( drhd && drhd->iommu->node !=3D NUMA_NO_NODE ) >> dom_iommu(domain)->node =3D drhd->iommu->node; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> for_each_rmrr_device( rmrr, bdf, i ) >> { >> if ( rmrr->segment !=3D pdev->seg || bdf !=3D pdev->sbdf.bdf ) >> @@ -2072,8 +2069,6 @@ static void quarantine_teardown(struct pci_dev *pd= ev, >> { >> struct domain_iommu *hd =3D dom_iommu(dom_io); >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( !pdev->arch.vtd.pgd_maddr ) >> return; >> =20 >> @@ -2341,8 +2336,6 @@ static int cf_check intel_iommu_add_device(u8 devf= n, struct pci_dev *pdev) >> u16 bdf; >> int ret, i; >> =20 >> - ASSERT(pcidevs_locked()); >> - >> if ( !pdev->domain ) >> return -EINVAL; >> =20 >> @@ -3176,7 +3169,6 @@ static int cf_check intel_iommu_quarantine_init(st= ruct pci_dev *pdev, >> bool rmrr_found =3D false; >> int rc; >> =20 >> - ASSERT(pcidevs_locked()); >> ASSERT(!hd->arch.vtd.pgd_maddr); >> ASSERT(page_list_empty(&hd->arch.pgtables.list)); >> =20 >> diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c >> index 1298f3a7b6..1f7c496114 100644 >> --- a/xen/drivers/video/vga.c >> +++ b/xen/drivers/video/vga.c >> @@ -117,9 +117,7 @@ void __init video_endboot(void) >> struct pci_dev *pdev; >> u8 b =3D bus, df =3D devfn, sb; >> =20 >> - pcidevs_lock(); >> pdev =3D pci_get_pdev(NULL, PCI_SBDF(0, bus, devfn)); >> - pcidevs_unlock(); >> =20 >> if ( !pdev || >> pci_conf_read16(PCI_SBDF(0, bus, devfn), >> --=20 >> 2.36.1 >>=20 From xen-devel-bounces@lists.xenproject.org Tue Feb 21 03:22:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 03:22:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498500.769370 (Exim 4.92) (envelope-from ) id 1pUJEP-00063j-EO; Tue, 21 Feb 2023 03:22:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498500.769370; Tue, 21 Feb 2023 03:22:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUJEP-00063c-AD; Tue, 21 Feb 2023 03:22:17 +0000 Received: by outflank-mailman (input) for mailman id 498500; Tue, 21 Feb 2023 03:22:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUJEO-00063S-CI; Tue, 21 Feb 2023 03:22:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUJEO-0003mn-8O; Tue, 21 Feb 2023 03:22:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUJEN-0006Je-Qn; Tue, 21 Feb 2023 03:22:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUJEN-0002GK-QL; Tue, 21 Feb 2023 03:22:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MiXb6Ho54IMwIAWK9VLwfZVTop4j3rLB2kLYvzZ90qQ=; b=Zhqq9XMOZQ0ooK+8LwfSY/Zw0D 8YsJCajmTps4njb2+XZ//hprIoR2wVWAX7KXFNw+MU2nVuTx30+DQZPEivHBfhowFZV4XX4Rxra1i lWy+MCbmrJuplDRkyMG9lgKugTXccUdOj+dlpzIvg2fpYak4tjHj74S8skzejvrBQdRM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177951: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit2::broken:regression linux-linus:test-amd64-amd64-xl-credit2:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=91bc559d8d3aed488b4b50e9eba1d7ebb1da7bbf X-Osstest-Versions-That: linux=c9c3395d5e3dcc6daee66c6908354d47bf98cb0c From: osstest service owner Date: Tue, 21 Feb 2023 03:22:15 +0000 flight 177951 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177951/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 broken test-amd64-amd64-xl-credit2 5 host-install(5) broken REGR. vs. 177860 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 177860 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177860 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177860 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177860 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177860 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177860 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 91bc559d8d3aed488b4b50e9eba1d7ebb1da7bbf baseline version: linux c9c3395d5e3dcc6daee66c6908354d47bf98cb0c Last test of basis 177860 2023-02-19 22:42:48 Z 1 days Testing same since 177951 2023-02-20 20:44:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Andrew Morton Arnd Bergmann Boqun Feng Christian Brauner (Microsoft) Christian Brauner Chuck Lever Darrick J. Wong Dave Chinner Denis Kenzior Eddie James Finn Behrens Gary Guo Giuseppe Scrivano Ira Weiny Jann Horn Jarkko Sakkinen Jeff Layton Jeff Layton Jens Wiklander John Hubbard Joseph Qi Julien Gomes Linus Torvalds Masahiro Yamada Matthew Garrett Maíra Canal Miguel Ojeda Miklos Szeredi Nick Desaulniers Paul Menzel Steve French Thomas Weißschuh Uros Bizjak Uwe Kleine-König Wedson Almeida Filho Yang Yingliang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 broken test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-credit2 broken broken-step test-amd64-amd64-xl-credit2 host-install(5) Not pushing. (No revision log; it would be 1941 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 21 04:15:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 04:15:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498510.769380 (Exim 4.92) (envelope-from ) id 1pUK3I-0004Xz-7s; Tue, 21 Feb 2023 04:14:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498510.769380; Tue, 21 Feb 2023 04:14:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUK3I-0004Xs-5I; Tue, 21 Feb 2023 04:14:52 +0000 Received: by outflank-mailman (input) for mailman id 498510; Tue, 21 Feb 2023 04:14:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUK3G-0004Wh-Qe for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 04:14:51 +0000 Received: from buffalo.birch.relay.mailchannels.net (buffalo.birch.relay.mailchannels.net [23.83.209.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45c99ed3-b19e-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 05:14:47 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CB094920D9C for ; Tue, 21 Feb 2023 04:14:44 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6A9C4921502 for ; Tue, 21 Feb 2023 04:14:44 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.48.87 (trex/6.7.1); Tue, 21 Feb 2023 04:14:44 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4PLQsv3tn5zkr for ; Mon, 20 Feb 2023 20:14:43 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e009c by kmjvbox (DragonFly Mail Agent v0.12); Mon, 20 Feb 2023 20:14:40 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45c99ed3-b19e-11ed-933d-83870f6b2ba8 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676952884; a=rsa-sha256; cv=none; b=Dcb93+Ix0KE5U69ERGMEFGNvx+cG1KWohtKFjaiZiWSP2Zfn5KOvZEihwtvMGT50P0KOsy IrW1+zBgoWxdg1hDOO2g/Sxl4nzazMGhLPnggvLyNZVzZ964I4IYR7pYGc+7qb4+3slyvw NgjjtwyxF/LOiNkPUhrUPXyJwneDmqxhlovH1Kk3H/ptmf4xn1a7y/NUeR8JcBvzFbic7z NYQyHSLxDUfLfHvVzm+yi94WME2vfNhQOKFc8ZDR5v6/sVfIe4/xybNFGOTbMUklFXgPqa VYknZc65LRVH9ias8iPuAbIr17EWkr1jWAZYN+RsSavaVMnqSrLr5TtrExWHVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676952884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ImnJPBdDN9t/YWBpOudrdBxjWvZR/5gNnDFra2E2Guo=; b=JnwHYpRJClI69omoN2UKoh2P9GKnV973fFh15ZaSDL/KU2RN9Tne9emix6eFrbelXubwUY 1tSPu4BTxNaJtEPSwMwYL1X7wynHMG2em6d7bTxByczXAetuFlCBF2Lha4cqAGVNwYOGqB Tyv3fzPtDdsv5j5zCXYR7gdxlWp9H1+c33QYFAIghsFsWlIClRW8660QuMb4NdFBi92Lil FYFhzL2Fxr0Ja6gbqLksSm3xyFwZcKrSalTP6VFopIV4uSpM3wsu3eZMSqsivyd8KQia5l oxdts56v9hm+jWxdzR6VLbYGmZrYRDbk/WWHz4KHl7q/KhQMcIHeeK2sZS7Dsg== ARC-Authentication-Results: i=1; rspamd-9788b98bc-pxv92; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Army-Vacuous: 623ca1691d9b7218_1676952884663_3200941994 X-MC-Loop-Signature: 1676952884663:2113353332 X-MC-Ingress-Time: 1676952884663 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1676952883; bh=ImnJPBdDN9t/YWBpOudrdBxjWvZR/5gNnDFra2E2Guo=; h=Date:From:To:Cc:Subject:Content-Type; b=k50CCeG1AwC0vdT3btOV+KuR/P19UQfyulQMidh855dABo99SvbqOYjlLia6T2Jq7 25IXt8VQFc6besORNDAPWD44BZBnVom61wSkATjq/E+342pQKcL794bjulfB8nX5hW NQYr4v7daSO72mW0wgSYvqS3DWYURzi891BhbDgE= Date: Mon, 20 Feb 2023 20:14:40 -0800 From: Krister Johansen To: Thomas Gleixner Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Juergen Gross , Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: <20230221041440.GA1934@templeofstupid.com> References: <87h6vgov2p.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h6vgov2p.ffs@tglx> On Mon, Feb 20, 2023 at 11:01:18PM +0100, Thomas Gleixner wrote: > On Mon, Feb 20 2023 at 09:17, Krister Johansen wrote: > > @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > > > - /* tsc_mode = no_emulate (2) */ > > - if (ebx != 2) > > + if (ebx != XEN_CPUID_TSC_MODE_NEVER_EMULATE) > > return 0; > > > > return 1; > > What about removing more stupidity from that function? > > static bool __init xen_tsc_safe_clocksource(void) > { > u32 eax, ebx. ecx, edx; > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; > } I'm all for simplifying. I'm happy to clean up that return to be more idiomatic. I was under the impression, perhaps mistaken, though, that the X86_FEATURE_CONSTANT_TSC, X86_FEATURE_NONSTOP_TSC, and check_tsc_unstable() checks were actually serving a purpose: to ensure that we don't rely on the tsc in environments where it's being emulated and the OS would be better served by using a PV clock. Specifically, kvmclock_init() makes a very similar set of checks that I also thought were load-bearing. -K From xen-devel-bounces@lists.xenproject.org Tue Feb 21 05:51:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 05:51:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498520.769391 (Exim 4.92) (envelope-from ) id 1pULYn-0000mD-8c; Tue, 21 Feb 2023 05:51:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498520.769391; Tue, 21 Feb 2023 05:51:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pULYn-0000m6-64; Tue, 21 Feb 2023 05:51:29 +0000 Received: by outflank-mailman (input) for mailman id 498520; Tue, 21 Feb 2023 05:51:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pULYl-0000lx-AE for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 05:51:27 +0000 Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c4557ade-b1ab-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 06:51:23 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7126E6C14D2 for ; Tue, 21 Feb 2023 05:51:20 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EEA9B6C13D7 for ; Tue, 21 Feb 2023 05:51:19 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.134.126 (trex/6.7.1); Tue, 21 Feb 2023 05:51:20 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4PLT1M3nCPz4f for ; Mon, 20 Feb 2023 21:51:19 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e00f5 by kmjvbox (DragonFly Mail Agent v0.12); Mon, 20 Feb 2023 21:51:17 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4557ade-b1ab-11ed-93b5-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676958680; a=rsa-sha256; cv=none; b=P/LyeC5VJy2k15smy91wrTaCZPsx3iu4tVq3lIjboluvHkv0xcq39GNu0kfDijFfsHLf0p ULIXZxwyQYkAClvopN00WuZhlRclnlvezipw0h3qSBxH4CugmjEmg3nlgi/5huq/vZeqh7 SeBDZDW1b6UcbdYxooVA4nW1yaj6/1C0/10shj4EHPgzNzKAb43ZBPpPoZt/7PPlmWs8gd kc+BH/vg9IERTZJw9pcdkU7jCyxp7yLrcXSMvDCZdRnqWEIWbqH7QhET9xajN/r8gekLmY lzCGnaL7vEYExdnOSsF3nea5sN3A4YjB9o1Bh8VYS8oQRs6YedqRO1UsafUStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676958680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Ryms4gHoy/MGnNprWGKzCdsTkn+W4ai7vFOzO+3AGw=; b=3P6hxWtKbaqG76Fh6IYONPJSCJYuOVJv2GC1nxO/in/eyXs9LZCqPLKd3d6SSK6cp99bUQ UFLoukSPM3nx4mDYL+Z3Usehjh1VBPC0v8ZD2Ob2QZZsjAnmtF/ra3hWek2fW55Wf0w3y4 6fyd/PPoOGnWipC18REV7qgKVdMnNtDgYKklX30BC615KXDv0HN5L5XsxFu4I4o9YkF6Uz Szn5NnDbHQDbhKYyQj5uT3dvqfMlp0xzB+GBfg8jS4nxF/Sa/gxomFi03+SNeJEk+aHFCq qRkRP/eYRlzV8M+eQoCo4IWqx2ZLpFK8BOFI5QNL3vdTAp1ztpaYlsW9UgI7Sw== ARC-Authentication-Results: i=1; rspamd-5db48964c-9hc9p; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Zesty-Invention: 543ef75e49736803_1676958680241_3740235661 X-MC-Loop-Signature: 1676958680241:2041868574 X-MC-Ingress-Time: 1676958680241 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1676958679; bh=4Ryms4gHoy/MGnNprWGKzCdsTkn+W4ai7vFOzO+3AGw=; h=Date:From:To:Cc:Subject:Content-Type; b=ODo7CVzs5sFOwiyqDH58lvqtbRhN/pp+GDD4QD1mQcWjhYGj7KIwGzNCXNv05epkH AHrXXdv5ri7R5VdJHLYFtSuAw+zt7Zc5ZYr9It1N2KHKsUuicchc0+223SRciI5eHi bcysQHndCS0eGw34Z4+B0DZFd4J+TGPvdwlX+YZ4= Date: Mon, 20 Feb 2023 21:51:17 -0800 From: Krister Johansen To: Thomas Gleixner Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Juergen Gross , Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: <20230221055117.GA1934@templeofstupid.com> References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230221041440.GA1934@templeofstupid.com> On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: > On Mon, Feb 20, 2023 at 11:01:18PM +0100, Thomas Gleixner wrote: > > On Mon, Feb 20 2023 at 09:17, Krister Johansen wrote: > > > @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) > > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > > > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > > > > > - /* tsc_mode = no_emulate (2) */ > > > - if (ebx != 2) > > > + if (ebx != XEN_CPUID_TSC_MODE_NEVER_EMULATE) > > > return 0; > > > > > > return 1; > > > > What about removing more stupidity from that function? > > > > static bool __init xen_tsc_safe_clocksource(void) > > { > > u32 eax, ebx. ecx, edx; > > > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > > > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; > > } > > I'm all for simplifying. I'm happy to clean up that return to be more > idiomatic. I was under the impression, perhaps mistaken, though, that > the X86_FEATURE_CONSTANT_TSC, X86_FEATURE_NONSTOP_TSC, and > check_tsc_unstable() checks were actually serving a purpose: to ensure > that we don't rely on the tsc in environments where it's being emulated > and the OS would be better served by using a PV clock. Specifically, > kvmclock_init() makes a very similar set of checks that I also thought > were load-bearing. Bah, what I meant to say was emulated, unstable, or otherwise unsuitable for use as a clocksource. IOW, even if TSC_MODE_NEVER_EMULATE is set, it's possible that a user is attempting a migration from a cpu that's not invariant, and we'd still want to check for that case and fall back to a PV clocksource, correct? -K From xen-devel-bounces@lists.xenproject.org Tue Feb 21 07:45:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 07:45:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498538.769403 (Exim 4.92) (envelope-from ) id 1pUNKq-0006OJ-CX; Tue, 21 Feb 2023 07:45:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498538.769403; Tue, 21 Feb 2023 07:45:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNKq-0006OC-8n; Tue, 21 Feb 2023 07:45:12 +0000 Received: by outflank-mailman (input) for mailman id 498538; Tue, 21 Feb 2023 07:45:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNKp-0006O3-3P for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 07:45:11 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9db3279-b1bb-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 08:45:08 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id o12so13831949edb.9 for ; Mon, 20 Feb 2023 23:45:08 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id md1-20020a170906ae8100b008b174ef3cdesm6316129ejb.27.2023.02.20.23.45.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 23:45:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9db3279-b1bb-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nb4m+NMSSZ8Xb7XVkirvpnqdk3gD/LNuPpLu5BP4rW4=; b=DD+pcRXM82S2cPljLEEhL8v7MNzjG+9rs6D9ggvC6fMzhzhXiSIoj1nWl/Rcv3c+hO JyPsld0ry5xj6i8cJFkWMuQdbW6a/YUFGPAdzezQUijwZ36XOYYJxy1L7JK1LjyClpUo DF6Yc61vpRQjxiSvXMMbhWX4xz07oqwLWVDtInxuM90vnb8yFzn7xpeo3X/AsjbbU6Vo f/z0BK4sb19v1y/zf/YbkKvovvTEAWLyPV2d2oQWkHuvkRdoiadmm7FmAXXATZ4KGepr d5c2H2A7rWCyEAcoH9Xz/0go2wCkobyhG3ykC+NlBTiBrr2TxdthdvjD5CrNGQ+5s2ZB omzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nb4m+NMSSZ8Xb7XVkirvpnqdk3gD/LNuPpLu5BP4rW4=; b=wc/bRGMR97If+55yPrOdAKInXZGUK60oECCIMMKq7osSA+7w+FHXF1U7VOiUOZ2Z+r RUFmR3fVJNfO97v3h9fiPytuNpI6jsJY/IFaUDRi+ilWW5Bi2nBl1/tCHvG+tTRVX5CZ JrUHvNi17FMd/t5ivYKKcvL+E9Ha/u2ab7ctp5xWLgY1ynDSsNoKhCu2F/gKOKW43Yyy 2BNHLbx0bzCEj+dCoHvbwQGfuayoH1xMBRKaZKsaIq6pwk9EZHbnjmVVmkuFxsP5UPK/ YZppkVQ6UzxjJfYthk6ckknhk3Hlb5q6N8zu/B97B+DlZlKy5MZp83KiPn6JJ4T/qAnw SjNg== X-Gm-Message-State: AO0yUKXJU2T/QP5pAwreB0Vxe7pq0BxtWlEDcIlIGdTs7QMyTe1t0549 QPJfCEDnFm/Fqjm+d75SKsXXxJNaK44= X-Google-Smtp-Source: AK7set8zm+XrZGG/HtFfax0h0db5O30uMJph6obF9LBOv8SpENrMCc8niqL2wxQ/cLmAHSk2PuV9zg== X-Received: by 2002:a17:907:ea2:b0:8aa:f2f2:7543 with SMTP id ho34-20020a1709070ea200b008aaf2f27543mr16234016ejc.29.1676965508059; Mon, 20 Feb 2023 23:45:08 -0800 (PST) Message-ID: <936cd14b-70b8-0c28-3aa8-85e5b3f2a8c9@gmail.com> Date: Tue, 21 Feb 2023 09:45:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/4] x86/svm: cleanup svm.c Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-2-burzalodowa@gmail.com> <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> From: Xenia Ragiadakou In-Reply-To: <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 2/21/23 00:12, Andrew Cooper wrote: > On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >> Do not include the headers: >> xen/irq.h >> asm/hvm/svm/intr.h >> asm/io.h >> asm/mem_sharing.h >> asm/regs.h > > Out of interest, how are you calculating these?  They're accurate as far > as I can tell. I do not use a script (at least not a decent one), if that 's the question :) . I verify that none of the symbols defined or declared in the header is used in the file including the header. > > Looking at asm/hvm/svm/*, intr.h itself can be straight deleted, > svmdebug.h can be merged into vmcb.h, and all the others can move into > xen/arch/x86/hvm/svm/ as local headers.  None of them have any business > being included elsewhere in Xen. I can send another patch for that. > >> because none of the declarations and macro definitions in them is used. >> Sort alphabetically the rest of the headers. > > Minor grammar point. "Sort the rest of the headers alphabetically" would > be a more normal way of phrasing this. I will fix it in v2. > >> >> Remove the forward declaration of svm_function_table and place start_svm() >> after the svm_function_table's definition. >> >> Replace double new lines with one. >> >> No functional change intended. >> >> Signed-off-by: Xenia Ragiadakou > > Acked-by: Andrew Cooper -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 21 07:58:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 07:58:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498547.769414 (Exim 4.92) (envelope-from ) id 1pUNXC-000898-GZ; Tue, 21 Feb 2023 07:57:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498547.769414; Tue, 21 Feb 2023 07:57:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNXC-000891-Cx; Tue, 21 Feb 2023 07:57:58 +0000 Received: by outflank-mailman (input) for mailman id 498547; Tue, 21 Feb 2023 07:57:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNXB-00088v-0o for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 07:57:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0620.outbound.protection.outlook.com [2a01:111:f400:fe0e::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 724f6b9f-b1bd-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 08:57:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8583.eurprd04.prod.outlook.com (2603:10a6:10:2da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 07:57:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 07:57:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 724f6b9f-b1bd-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elDEMYtweG2Y6E4x7W51/0o+YsHF92GXa9hQ0xo5Yc632Ck9vUJ5l7WJFh5X7e5ibDCRQKoUkIGJVhJYM/T560nuvXXFZjZx3eBxMaE5k/eWebqRBAXKGsE5H5T3zxwYdGRlwrHUdfojb6MU9BrO6sM3H/hoRqbpbgvYjrKDBfCKjlmlQRVuwB91ACVqZx7Hp2rWmDYuSwlHeFVAXBsVDEHD1o/L3pgD+YZgPnNDihdaKqdsN1q9Pujo1vnmuo8m5MlksmLrmaxvwDBRb7j+Zl9YjZ7r3xQJUv2M40nE8ok+VXWZIp+dw4O1I8zchEfwCCpe33EIaUjviD727NxHeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MjDnJ4XLe5+/l/qcuZDVurmHSwIiuTvS1d+zludeCt0=; b=EVxch5FLOLRHQhslSIpKKTWysgN2wsJ5mRlREA0B+AvJGwGnB4Czx6SrieItcxORj1rCF6GFwb2tNoerlNf+mcKzRV8eNAwcQRfXuEQvrzjw5/OxesBE2OygHvi2YTwKLPP2VC+nyc/4kQmnNs87HJhjxcFOhALF8WozfJZHSK+IvLjHVmCUVOIzhuCO7ly1i/pZJELBvHED3OAt9OeeMDhGiKxsX+8mBeWqYRYTM/UhnoUkjnQHLbFzp/TTrmMQENVYBQ4UjDp+FFGZ0BccRcZ7Pl+lk7G5vrPR01vssANY3DmX4k7CCeWqODnDLMdLYz4lmsSMQOEZ8FnmmlzQYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjDnJ4XLe5+/l/qcuZDVurmHSwIiuTvS1d+zludeCt0=; b=i6vM6UGD/Nqxs/uzdK2h2IW7EZ5ifQ+LtkIeYZlGbYYxkVon9tlg3aH8U7oBE3rFDi9cjYg8DZqT+uahkyyRaKiFR/vKnzxMuyT3op0yMX83zRtCPGNCJzGX1cIKdTDEEtJtCu5a9cY2/gD3xgdWVqrjCNpP4PzWh0yUFwR8wP8gE6x5ndjOusyrwt3r6oicmgthfoSkdX2uMETUSJ3mq82ektfZbkfhtflhkcVaMdlGBXV8ymWaM5owiqVkUlW/4Yge7Ca0X9ima2X3Q8vk3F1wiPHHQ64eWoE9nb64b9iO2PHRbhGuOeuAfAg69Edn0MXa7fH/nl0SOCppXewm+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <764e4fe6-b4b2-551e-dec7-8307eb94630d@suse.com> Date: Tue, 21 Feb 2023 08:57:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/6] xen/x86: Use SPDX (take 1) To: Julien Grall Cc: demi@invisiblethingslab.com, Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan , xen-devel@lists.xenproject.org References: <20230209230020.52695-1-julien@xen.org> <34dd6673-a8b2-977c-adfd-928418cb5435@suse.com> <8e2d3064-c7c3-4a3c-2f11-a04a68662447@xen.org> Content-Language: en-US From: Jan Beulich In-Reply-To: <8e2d3064-c7c3-4a3c-2f11-a04a68662447@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0179.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8583:EE_ X-MS-Office365-Filtering-Correlation-Id: b4af3fd5-2ccc-4339-9b68-08db13e15512 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KD5Y5o0QH7tetH+aIaxq6fXkEX/nJGm2iZFwGHg9H75vxjkdj40WZIT0oBAveg41oObtzuPcgfF0cXmH1s+1POHmg251e1V5ezLcTKaS4mUnX/UuWgr1nfeE1pfkm13dfbsHqFM5bLZDegbDK+X8B+Zi95IlKhhuh5l/DrAhzeotHI37rPBnQlK08yOYX6NUJb0NEOEzt/meW2PEHP1xFjbKjid8rVFNjaOwYch2ukJAx38EAlhEk9IRVUYjR0QB2Bpp6iYlg/eL+4uMJaYp4uvGIR4MaynKGQtiHVEs8yIFO9XJ6qodh3/cSokR+ufYTuyEkzJfctlnnQfrOMDqOf5/Y6+kQYi9+d6WRHwxnQFObkg1VeSoUfeGQbwzi0Ycr3gNozp0zpyljZY0MUDS59YEb1DEBP3CuPaGGgqxHxPITsLmqNO65363cdmxD9IXZOmbS9RI05qVwbSHcl0NDoNnU4uAyrzX/yucdOr6IvE0/hO/P6f7bN8n4C7h7A0Dash6mjv+nbWLscEiOLfgemgcsBcAyWur5v4MAzTHc3ptFqUhVF0NjlQxDcVsJlLbTPxd2MQvGZp9Ul+rIadJo+kPhN9b6zjiyhF3W12qy9mUpQw61mIPf9GOzwcCT5+8n2u4u8CEAsXCoy+BkU+OZQKJq8lXbxBddPtyzxFK8vPx5H9wh9B5wg7ScLHfXTllanv5GkOLN0HGT/NVWJ77i6AanCdD4HTjpAk90j1HI2k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199018)(38100700002)(36756003)(31696002)(86362001)(2906002)(8936002)(41300700001)(5660300002)(7416002)(53546011)(186003)(26005)(6512007)(6506007)(2616005)(4326008)(316002)(6916009)(66476007)(66946007)(66556008)(6486002)(54906003)(8676002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU4vT2U3aCtaVUx5M0ljamFtNXVkZE5MSUlmZ1FiZnhJWjZ0VHQ2ODFsclFy?= =?utf-8?B?TTRzZmVvWkpsSVdSQk5VejhheGpQaWVaVEJMWDFEZjRVeFZ4ZWxIUlRpaXBn?= =?utf-8?B?T2l6TkhONkd1RGIzbkVGTWJTK3lFQkhtRnQ1SkxzRklCYXFrOVRsNE9NMlk0?= =?utf-8?B?K1U3YmErT0FDS0l1K2xpTVJ1VzBUNm1oTi9PbWhYWjFhSm5JYVRidnRDWXBI?= =?utf-8?B?SllCZ3k2VFhnNVJTOTJCcldycko0S2xxRG5wZGRHaWdHVGJVR1RTSHJkSnJm?= =?utf-8?B?cWFyRkxQYlFkRHQ0SzVjaHdGcktwVmIvbUpNejl2VmNqQ1VCYXloaTRTSENZ?= =?utf-8?B?eGZKcVpMTlpNRC90VktQSFdCVnFrd2Y1cGh6dGozUTFxY1BCaTV1dnBFUktO?= =?utf-8?B?SHRIVm9RcllwVXlNYjBtOVZPM3V5Ymo4MTJUcGR3akdqdWhnSjhxUlIvY25N?= =?utf-8?B?VXl0TDM3b0ZTODFJVTZqZVdzUzViN3Jhc0t1ZXlEVWdEL0RjRG5WckVNcDlP?= =?utf-8?B?aStzL2IyZDVFUXV3RlI0TjJxV3crbVArSC9LWEhUc2N1dW1QOWRZWkhUdURT?= =?utf-8?B?VnNKR1JJRjdBQjlKQlhrTHhTY3pkTmlaUFZFUHZCWXkyS2pGT0NmT2hDd2t4?= =?utf-8?B?ZlNLeGRqNlN1dGo4andSb0lpOWFSTVN5bWlnTzZ0RUg3NjJncm1xU3VnTHNY?= =?utf-8?B?Z00vQVJRWVZ1NlNzdEY3c2YrUllZdFBRMGJ1SlFuMFdGVlNLNDRUWFRCZ1JH?= =?utf-8?B?OXY4SllUL0tHZFhxbTF5MHFUOGZRSnU2TjhZTG1JbW96bm81K01mOWFtTVlr?= =?utf-8?B?akdPYWN3czFzVFFieklpeXRLakpFMXFHZFNEVXBkUHJVV050ZUtqS0owK2Ux?= =?utf-8?B?L3VNOW5xQ1lYVjQwWFpQOHNZYmZlSHNtY0dyVzl2MFNxNlhkQjRPSVgxejNV?= =?utf-8?B?endIK3ZlVzJ4ZnNEeG5KQnFIUlY2RXZqWSs4aVVBenRlWGVraEl6bmxlT0hQ?= =?utf-8?B?MWtkWDRFYWRiSlA2R2dLT3ZjRVFSaFR1dDdrOWsvM0cxckszTW96WUY2Vktz?= =?utf-8?B?Z0JKMk1QRTdIRTJKOU8zbXpkODN3ODR2bkhoTW5uaXd0cTBzbHd2SEl1ZGhz?= =?utf-8?B?Z2VHQXR0dlU3aHpPWXdLVzI2M2U1T2k0UzNSbExETlNoYzMwckdiQVVkN0cz?= =?utf-8?B?N2E3VmRER0hYc2QzL3JrTHRRVkx2VHE1Wkw1a2dwMEtCV0lwQXE4U3FBczZY?= =?utf-8?B?bm5sZDBJNzRQTjhsdDliL2tHVG56TkRwRzNSanEvVU00Ui96WEVwOWpDNzNw?= =?utf-8?B?dTdGNjVWNE1oTzM3Y0VCMkpxNzRmUTBNUnFGYWZRVEJGT0dYWi8zd2RhaVNx?= =?utf-8?B?amM0RkhIMUt0R2hXd1AweTJXSnp6aWxPQVh4NHBLbm4wYUtxNTVEcFB3bWV2?= =?utf-8?B?Z0Z4V2JSdVRDeTJaSTRHaVFyTGNFTGM5UnZsbzFaaGRKOFVsYktKTEJ3dDZl?= =?utf-8?B?ZUNyeW4zYlNKNUhXT2RmNVVCSWZYUEJqS3JHbk9EUFFnWFlZRUhSNUlLV0JX?= =?utf-8?B?S2V6M0M5NXdtQTVMeTZTT2xpR3c3Mm12TFJha2ZBUVRGUzRuZmJIQVU2ZDFY?= =?utf-8?B?d3J3NnBvVjlRd1pOa2JuVlpPYkMydXM2U2FXalNEQkltb0orVUFjK0NZTkwv?= =?utf-8?B?U3ZZS1VTSUJVK0MvSUo3U3FjUXp1bmpHTDkwQjNRK25wMGVjdXlHTmtBdXFF?= =?utf-8?B?Z3dudFNXWEJNcnRoVWNHb1lsWUlUSWFXMXdZK3pSQW92a0VpOFFRbCtQaFJv?= =?utf-8?B?cm1aRkdxSGt3Q3V5MU9rZG1HK2p2eUFxdlgrNlg4TFJKR3NUb2VLcXdyODFV?= =?utf-8?B?UGRQZjhHc1JsNjBidnljUGs2Mllaa2dCNlY3VnhTVFRMZkZwMHVJZXBZaFU1?= =?utf-8?B?TG1tK3ZCMXYzZzJCTTJOclNQMUNEQXdmNi9tK3pucjJCaC9rWjFBaGYzeUkz?= =?utf-8?B?TlN6eWVYbWNWWURRTDlQRmdhaWxVZjhlQ1IxVHZMMjJaUGVtN05hait3T1dZ?= =?utf-8?B?MytkRlFiSzYvV1lUMzVhY3YxNkthbkJCWDJTVmNSbUxiY2N1YlNkdGZBc3Fo?= =?utf-8?Q?C49G9TaqNneG1uhH2Xnem1sC8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4af3fd5-2ccc-4339-9b68-08db13e15512 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 07:57:52.1721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CuPuZCn2cuMbSITah12YFwrN35Fc3acE0kU6gC2hBq+DwG+A1SjPLtNHdO+I4cR3LHAMcBdebM3BetTwOfIuuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8583 On 19.02.2023 19:41, Julien Grall wrote: > On 13/02/2023 09:27, Jan Beulich wrote: >> On 10.02.2023 00:00, Julien Grall wrote: >>> Julien Grall (6): >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 2) >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 3) >>> xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h (part 3) >> >> With the one further adjustment you did spot yourself: >> Acked-by: Jan Beulich > > Thanks! The series is mostly mechanical change. So I am not sure whether > I should wait for all the maintainers to ack before committing (it has > been already a week). > > Any thoughts? While personally I tend to ping and hence push for a complete set of acks even on largely mechanical changes, I think the series here is yet more mechanical and hence okay to be committed at about any time even when taking the rules pretty strictly. Plus there hadn't been any controversy afair on the subject of conversion to SPDX. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 07:58:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 07:58:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498549.769425 (Exim 4.92) (envelope-from ) id 1pUNXb-00008v-PZ; Tue, 21 Feb 2023 07:58:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498549.769425; Tue, 21 Feb 2023 07:58:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNXb-00008m-M7; Tue, 21 Feb 2023 07:58:23 +0000 Received: by outflank-mailman (input) for mailman id 498549; Tue, 21 Feb 2023 07:58:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNXa-00008K-Aq for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 07:58:22 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 825bbe54-b1bd-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 08:58:21 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id ck15so14748496edb.0 for ; Mon, 20 Feb 2023 23:58:21 -0800 (PST) Received: from [192.168.1.93] ([188.73.238.161]) by smtp.gmail.com with ESMTPSA id 8-20020a170906310800b008e0e08b5fc7sm268500ejx.145.2023.02.20.23.58.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 23:58:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 825bbe54-b1bd-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aqLRKH1h7HHnZgA2/GKBFIRjzmkMPaTNCLih2tBfIo0=; b=qE7+EekSANILz7CUg7Y39KHJkUyvxmeXweJkNCEUeuS4vB2n+Wme9k5dgKsRDObMCj 8KT+Enam+KBYWc2jC85kZpDXP+jAofLxJlpEQRynxED0Pfm2IlW6fN31o3wuWTLlPJo6 jhPt9rPuPwaz8Pnnzuj//Gi0VqUpUStXpyxO8Ue9hg8nNxx6Pih5O+/Kh19NMCpW8rtS nmQoMvv+tPK4otWKtUhRsX5k9bdVnS1k6dEDmBe/9A0bJ2J9m0esfPOUUXV68Zw5DnHj bE6rkAWbwmFw1HIZDSGE1IwP8mNBTxq4Irop0kQcMNO2J7M3pO5u6NLtW5ChRsI/xO5P vCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqLRKH1h7HHnZgA2/GKBFIRjzmkMPaTNCLih2tBfIo0=; b=lhVLaYztcJqk3S+prUNkpGVtDImqoWemXMMuShssFkol0couN+NBiw+wJwZ6SuoLIc lkZajBK2qj26WA1MErgSgpkIfQb6txyQ6H5Y+BCW5++SXYYGBfU4CTDRSgoAc9Yk9sCD mMkbj7GsXV4kqFM3SdftaVudssq8yHS4KCXLxFMGEBT/013hULkduiK2O4IJ2hA83U5C Qud92I0kmonW/E7uiJ3n7epPikSjf3uAayv2r4iXGKzb0WgZTMMwrRnD4PwoJ1YBU0eA SZZ6C+Ik2HiU0glSULysHCL+tcJOavlQknuazr+WiJjMks597quxsngyZ6Pt26Y9klBa Gldw== X-Gm-Message-State: AO0yUKXHHY47OGr1UbB8o1l03TF/IBleq+63iYFYoB5JKWsIyjoHdF10 wQXuIt2ywLU3w2evyvUYuwE= X-Google-Smtp-Source: AK7set8qnkjyWcquNvagec3VBzX0bVegh3oaxL8pehY6mkmby1gndMPumhIwB2uzOuIiJMdKPkUU1A== X-Received: by 2002:a17:906:fcd5:b0:8b1:81eb:158f with SMTP id qx21-20020a170906fcd500b008b181eb158fmr15461952ejb.62.1676966300857; Mon, 20 Feb 2023 23:58:20 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 09:58:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] x86/svm: cleanup svm.h Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-3-burzalodowa@gmail.com> <562ae912-e833-ba97-dcd5-4c6b6d8898e0@citrix.com> From: Xenia Ragiadakou In-Reply-To: <562ae912-e833-ba97-dcd5-4c6b6d8898e0@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/21/23 01:08, Andrew Cooper wrote: > On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >> Remove the forward declaration of struct vcpu because it is not used. > > Huh, turns out that was my fault in c/s b158e72abe, shortly after I > introduced them in the first place. > > Also, looking into that, there's one legitimate use of svm.h from > outside, which is svm_load_segs*() which means we can't make all the > headers be local. > > But still, most of svm.h shouldn't be includable in the rest of Xen. > Perhaps we can make a separate dedicated header for just this. > > [edit]  And svm_{doman,vcpu}.  Perhaps we want a brand new > include/asm/hvm/svm.h with only the things needed elsewhere. This can be done as part of the series aiming to make svm/vmx support configurable. > >> Move the forward declaration of struct cpu_user_regs just above the >> function that needs it (to remind that it will need to be removed >> along with the function). > > I'm not sure.  This feels like churn. Ok I will leave it where it is in v2. > >> Move the definitions of NPT_PFEC_with_gla and NPT_PFEC_in_gpt in svm.c >> because they are used only in this file. > > IMO, these would better live in vmcb.h because that's where all the > other decode information lives, not that there is much.  I previously > started trying to convert all the exit_into fields into a typed union, > but I didn't get as far the NPT info. Ok I will fix it in v2. > >> Move the definitions of SVM_PAUSE{FILTER,THRESH}_INIT in vmcb.c because >> they are used only in this file. > > Honestly, at this point you might as well just delete the defines, and > opencode at their single usage site.  They're pure obfuscation like > this, given no statement of units / behaviour, etc. Ok I will do in v2. > > That said, we do need to stea^W borrow adaptive PLE, and make the I cannot understand what do you mean by "stea^W borrow adaptive PLE". > settings hvm-common because right now we've got two different ways of > configuring the same thing for VT-x and SVM.  (This is definitely not > cleanup work.  Just an observation for anyone feeling at a loose end.) I will create hvm_function_table stubs for the functions that are used in common code, do the same thing but are implemented differently by svm and vtx, as part of the series aiming to make svm/vmx support configurable. > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:11:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498566.769436 (Exim 4.92) (envelope-from ) id 1pUNjf-0003cE-6V; Tue, 21 Feb 2023 08:10:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498566.769436; Tue, 21 Feb 2023 08:10:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNjf-0003c7-3j; Tue, 21 Feb 2023 08:10:51 +0000 Received: by outflank-mailman (input) for mailman id 498566; Tue, 21 Feb 2023 08:10:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUNjd-0003c1-7b for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:10:49 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e3bf9df-b1bf-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:10:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A220E5C261; Tue, 21 Feb 2023 08:10:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7680E13223; Tue, 21 Feb 2023 08:10:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YEuCG4V89GNofgAAMHmgww (envelope-from ); Tue, 21 Feb 2023 08:10:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e3bf9df-b1bf-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676967045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dz0+QK94uSdaIqnPNHbrZ9EVlOv0020EfjAdxjA9hyY=; b=pnQjnS+V5QkJ7bFgZOfjy77/2l7u+ylXoZhz/oYrqxvg64cA0EBuecWXYe1Yvg2kpOoh5q 7QXLqxYRvcIdhyz9P5aMmpbdSAKcmgqY0t7XdWcx3svnKop4iAKXgRV4FGSO6jj7BMsdEW cNIL/+W5UjRBlhT1rQjhNAqyRUtOmLw= Message-ID: Date: Tue, 21 Feb 2023 09:10:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: <20151614-96ca-0875-29a0-8099953b7e61@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------8KnR0DNmu6tzonXCdzmVUbvS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8KnR0DNmu6tzonXCdzmVUbvS Content-Type: multipart/mixed; boundary="------------BqnaCl1sI9J9zjInHdE4bPgx"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> In-Reply-To: <20151614-96ca-0875-29a0-8099953b7e61@xen.org> --------------BqnaCl1sI9J9zjInHdE4bPgx Content-Type: multipart/mixed; boundary="------------qzMXwcMZTgCBfDiaM4ojIKxN" --------------qzMXwcMZTgCBfDiaM4ojIKxN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMTk6MDEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gDQo+IA0KPiBPbiAy MC8wMi8yMDIzIDE0OjIxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjAuMDIuMjMg MTU6MTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBPbiAyMC8wMi8yMDIzIDEzOjQ5LCBK dWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+PiBPbiAyMC4wMi4yMyAxMzowNywgSnVsaWVuIEdy YWxsIHdyb3RlOg0KPj4+Pj4gSGkgSnVlcmdlbiwNCj4+Pj4+DQo+Pj4+PiBPbiAyMC8wMi8y MDIzIDExOjA0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+IE9uIDIwLjAyLjIzIDEw OjQ2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+Pj4+IEhpIEp1ZXJnZW4sDQo+Pj4+Pj4+ DQo+Pj4+Pj4+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+ Pj4+Pj4+PiBUaGUgYWNjb3VudGluZyBmb3IgdGhlIG51bWJlciBvZiBub2RlcyBvZiBhIGRv bWFpbiBpbiBhbiBhY3RpdmUNCj4+Pj4+Pj4+IHRyYW5zYWN0aW9uIGlzIG5vdCB3b3JraW5n IGNvcnJlY3RseSwgYXMgaXQgYWxsb3dzIHRvIGNyZWF0ZSBhcmJpdHJhcnkNCj4+Pj4+Pj4+ IG51bWJlciBvZiBub2Rlcy4gVGhlIHRyYW5zYWN0aW9uIHdpbGwgZmluYWxseSBmYWlsIGR1 ZSB0byBleGNlZWRpbmcNCj4+Pj4+Pj4+IHRoZSBudW1iZXIgb2Ygbm9kZXMgcXVvdGEsIGJ1 dCBiZWZvcmUgY2xvc2luZyB0aGUgdHJhbnNhY3Rpb24gYW4NCj4+Pj4+Pj4+IHVucHJpdmls ZWdlZCBndWVzdCBjb3VsZCBjYXVzZSBYZW5zdG9yZSB0byB1c2UgYSBsb3Qgb2YgbWVtb3J5 Lg0KPj4+Pj4+Pg0KPj4+Pj4+PiBJIGtub3cgSSBzYWlkIEkgd291bGQgZGVsYXkgbXkgZGVj aXNpb24gb24gdGhpcyBwYXRjaC4gSG93ZXZlciwgSSB3YXMgDQo+Pj4+Pj4+IHN0aWxsIGV4 cGVjdGluZyB0aGUgY29tbWl0IG1lc3NhZ2UgdG8gYmUgdXBkYXRlZCBiYXNlZCBvbiBvdXIg cHJldmlvdXMgDQo+Pj4+Pj4+IGRpc2N1c3Npb24uDQo+Pj4+Pj4NCj4+Pj4+PiBBcyBzYWlk IGJlZm9yZSwgSSB3YXMgd2FpdGluZyBvbiB0aGUgc2V0dGxlbWVudCBvZiBvdXIgZGlzY3Vz c2lvbiBiZWZvcmUNCj4+Pj4+PiBkb2luZyB0aGUgdXBkYXRlLg0KPj4+Pj4NCj4+Pj4+IFRo aXMgaXMgbm90IGEgdmVyeSBnb29kIHByYWN0aWNlIHRvIHJlc2VuZCBhIHBhdGNoIHdpdGhv dXQgcmVjb3JkaW5nIHRoZSANCj4+Pj4+IGRpc2FncmVlbWVudCBiZWNhdXNlIG5ldyByZXZp ZXdlcnMgbWF5IG5vdCBiZSBhd2FyZSBvZiB0aGUgZGlzYWdyZWVtZW50IGFuZCANCj4+Pj4+ IHRoaXMgY291bGQgZW5kIHVwIHRvIGJlIGNvbW1pdHRlZCBieSBtaXN0YWtlLi4uDQo+Pj4+ DQo+Pj4+IFlvdSBzYWlkIHlvdSB3YW50ZWQgdG8gbG9vayBpbnRvIHRoaXMgcGF0Y2ggaW4g ZGV0YWlsIGFmdGVyIHRoZSBwcmV2aW91cw0KPj4+PiBzZXJpZXMsIHNvIEkgbW92ZSBpdCBp bnRvIHRoaXMgc2VyaWVzLiBUaGUgd29yZGluZyB1cGRhdGUgd291bGQgc3Ryb25nbHkNCj4+ Pj4gZGVwZW5kIG9uIHRoZSBvdXRjb21lIG9mIHRoZSBkaXNjdXNzaW9uIElNTywgc28gSSBk aWRuJ3QgZG8gaXQgeWV0Lg0KPj4+IFRoaXMgY291bGQgaGF2ZSBiZWVuIG1lbnRpb25lZCBh ZnRlciAtLS0uIFRoaXMgY291bGQgYWxsb3cgcGVvcGxlIHRvIA0KPj4+IHVuZGVyc3RhbmQg dGhlIGNvbmNlcm4gYW5kIHRoZW4gcGFydGljaXBhdGUuDQo+Pg0KPj4gV2lsbCBkbyBzbyBp biBmdXR1cmUuDQo+Pg0KPj4+DQo+Pj4+DQo+Pj4+Pj4+IEFsc28gdGhpbmtpbmcgbW9yZSBh Ym91dCBpdCwgIlRoZSB0cmFuc2FjdGlvbiB3aWxsIGZpbmFsbHkgZmFpbCBkdWUgdG8gDQo+ Pj4+Pj4+IGV4Y2VlZGluZyB0aGUgbnVtYmVyIG9mIG5vZGVzIHF1b3RhIiBtYXkgbm90IGJl IHRydWUgZm9yIGEgY291cGxlIG9mIA0KPj4+Pj4+PiByZWFzb25zOg0KPj4+Pj4+PiDCoMKg IDEpIFRoZSB0cmFuc2FjdGlvbiBtYXkgcmVtb3ZlZCBhIG5vZGUgYWZ0ZXJ3YXJkcy4NCj4+ Pj4+Pg0KPj4+Pj4+IFllcywgYW5kPyBKdXN0IGJlY2F1c2UgaXQgaXMgYSB0cmFuc2FjdGlv biwgdGhpcyBpcyBzdGlsbCBhIHZpb2xhdGlvbiBvZg0KPj4+Pj4+IHRoZSBxdW90YS4gRXZl biBvdXRzaWRlIGEgdHJhbnNhY3Rpb24geW91IGNvdWxkIHVzZSB0aGUgc2FtZSByZWFzb25p bmcsDQo+Pj4+Pj4gYnV0IHlvdSBkb24ndCAod2hpY2ggaXMgY29ycmVjdCwgb2YgY291cnNl KS4NCj4+Pj4+DQo+Pj4+PiBJIGNhbiB1bmRlcnN0YW5kIHlvdXIgcG9pbnQuIEhvd2V2ZXIs IHRvIG1lLCB0aGUgZ29hbCBvZiB0aGUgdHJhbnNhY3Rpb24gaXMgDQo+Pj4+PiB0byBjb21t aXQgZXZlcnl0aGluZyBpbiBvbmUgZ28gYXQgdGhlIGVuZC4gU28gdGhlIHZpb2xhdGlvbnMg aW4gdGhlIG1pZGRsZSANCj4+Pj4+IHNob3VsZCBub3QgbWF0dGVyLg0KPj4+Pg0KPj4+PiBP ZiBjb3Vyc2UgdGhleSBzaG91bGQuDQo+Pj4+DQo+Pj4+IFdlIHdvdWxkbid0IGFsbG93IHRv IHdyaXRlIG92ZXItc2l6ZWQgbm9kZXMsIGV2ZW4gaWYgdGhleSBjb3VsZCBiZSByZXdyaXR0 ZW4gaW4NCj4+Pj4gdGhlIHNhbWUgdHJhbnNhY3Rpb24gd2l0aCBhIHNtYWxsZXIgc2l6ZS4N Cj4+Pg0KPj4+IEkgdmlldyB0aGUgdHdvIGRpZmZlcmVudC4NCj4+Pg0KPj4+PiBXZSB3b3Vs ZG4ndCBhbGxvdyB0byBjcmVhdGUgbm9kZXMgd2hpY2ggd291bGQgdmlvbGF0ZSBvdmVyYWxs IG1lbW9yeQ0KPj4+PiBjb25zdW1wdGlvbi4NCj4+Pj4NCj4+Pj4gV2Ugd291bGRuJ3QgYWxs b3cgbm9kZXMgd2l0aCBtb3JlIHBlcm1pc3Npb24gZW50cmllcyB0aGFuIGFsbG93ZWQsIGV2 ZW4gaWYgdGhleQ0KPj4+PiBjb3VsZCBiZSByZWR1Y2VkIGluIHRoZSBzYW1lIHRyYW5zYWN0 aW9uIGFnYWluLg0KPj4+Pg0KPj4+PiBJIGRvbid0IHNlZSB3aHkgdGhlIG51bWJlciBvZiBu b2RlcyBzaG91bGRuJ3QgYmUgdGFrZW4gaW50byBhY2NvdW50Lg0KPj4+Pg0KPj4+Pj4gRnVy dGhlcm1vcmUsIEkgd291bGQgZXhwZWN0IGEgdHJhbnNhY3Rpb24gdG8gd29yayBvbiBhIHNu YXBzaG90IG9mIHRoZSANCj4+Pj4+IHN5c3RlbS4gU28gaXQgZmVlbHMgcmVhbGx5IHN0cmFu Z2UgdG8gbWUgdGhhdCB3ZSBhcmUgY29uc3RhbnRseSBjaGVja2luZyANCj4+Pj4+IHRoZSBx dW90YSB3aXRoIHRoZSB1cGRhdGVkIHZhbHVlcyByYXRoZXIgdGhhbiB0aGUgaW5pdGlhbCBv bmUuDQo+Pj4+DQo+Pj4+IFlvdSBhcmUgYXdhcmUgdGhhdCB0aGUgY29kZSB3aXRob3V0IHRo aXMgcGF0Y2ggaXMganVzdCBuZWdsZWN0aW5nIHRoZSBub2Rlcw0KPj4+PiBjcmVhdGVkIGlu IHRoZSB0cmFuc2FjdGlvbj8gSXQganVzdCBpcyB1c2luZyB0aGUgY3VycmVudCBudW1iZXIg b2Ygbm9kZXMNCj4+Pj4gb3V0c2lkZSBhbnkgdHJhbnNhY3Rpb24gZm9yIHF1b3RhIGNoZWNr Lg0KPj4+DQo+Pj4gQXJlIHlvdSByZWZlcnJpbmcgdG8gdGhlIHF1b3RhIGNoZWNrIHdpdGhp biB0aGUgdHJhbnNhY3Rpb24/DQo+Pg0KPj4gSSdtIHJlZmVycmluZyB0byB0aGUgcXVvdGEg Y2hlY2sgaW4gY3JlYXRlX25vZGUoKS4gPg0KPj4+DQo+Pj4+IFNvIEkgY291bGQgZWFzaWx5 IGNyZWF0ZSBhIHNjZW5hcmlvDQo+Pj4+IHdoZXJlIG15IG5ldyBjb2RlIHdpbGwgc3VjY2Vl ZCwgYnV0IHRoZSBjdXJyZW50IG9uZSBpcyBmYWlsaW5nOg0KPj4+PiBBc3N1bWUgbm9kZSBx dW90YSBpcyAxMDAwLCBhbmQgYXQgc3RhcnQgb2YgdGhlIHRyYW5zYWN0aW9uIHRoZSBndWVz dCBpcyBvd25pbmcNCj4+Pj4gOTk5IG5vZGVzLiBJbiB0aGUgdHJhbnNhY3Rpb24gdGhlIGd1 ZXN0IGlzIGRlbGV0aW5nIDEwIG5vZGVzLCB0aGVuIGRvbTAgaXMNCj4+Pj4gY3JlYXRpbmcg NSBhZGRpdGlvbmFsIG5vZGVzIG93bmVkIGJ5IHRoZSBndWVzdC4gVGhlIGNlbnRyYWwgbm9k ZSBjb3VudGVyIGlzIG5vdw0KPj4+PiAxMDA0IChvdmVyIHF1b3RhKSwgd2hpbGUgdGhlIGlu LXRyYW5zYWN0aW9uIGNvdW50IGlzIDk5NC4NCj4+Pj4gSW4gdGhlIHRyYW5zYWN0aW9uIHRo ZQ0KPj4+PiBndWVzdCBjYW4gbm93IGhhcHBpbHkgY3JlYXRlIGEgbmV3IG5vZGUgKCM5OTUp IHdpdGggbXkgcGF0Y2gsIGJ1dCB3aWxsIGZhaWwgdG8NCj4+Pj4gZG8gc28gd2l0aG91dCAo aXQgc2VlcyB0aGUgMTAwNCBkdWUgdG8gdGhlIHRyYW5zYWN0aW9uIGNvdW50IGJlaW5nIGln bm9yZWQpLg0KPj4+DQo+Pj4gVGhpcyBkb2Vzbid0IHNvdW5kIGNvcnJlY3QuIFRvIGRvIHlv dSBoYXZlIGFueSB0ZXN0IEkgY291bGQgdXNlIHRvIGNoZWNrIHRoZSANCj4+PiBiZWhhdmlv cj8NCj4+DQo+PiBUcnkgaXQ6DQo+Pg0KPj4gLSBjcmVhdGUgbm9kZXMgaW4gYSBndWVzdCB1 bnRpbCB5b3UgaGl0IHRoZSBFTk9TUEMgcmV0dXJuIGNvZGUgZHVlIHRvIHRvbyBtYW55DQo+ PiDCoMKgIG5vZGVzDQo+PiAtIHN0YXJ0IGEgdHJhbnNhY3Rpb24gZGVsZXRpbmcgc29tZSBu b2RlcyBhbmQgdGhlbiB0cnlpbmcgdG8gY3JlYXRlIGFub3RoZXINCj4+IMKgwqAgb25lLCB3 aGljaCBmYWlsIGZhaWwgd2l0aCBFTk9TUEMuDQo+IA0KPiBTbyBJIGhhdmUgcmVjcmVhdGVk IGFuIFhURiB0ZXN0IHdoaWNoIEkgdGhpbmsgbWF0Y2ggd2hhdCB5b3Ugd3JvdGUgWzFdLg0K PiANCj4gSXQgaXMgaW5kZWVkIGZhaWxpbmcgd2l0aG91dCB5b3VyIHBhdGNoLiBCdXQgdGhl biB0aGVyZSBhcmUgc3RpbGwgc29tZSB3ZWlyZCANCj4gYmVoYXZpb3IgaGVyZS4NCj4gDQo+ IEkgd291bGQgZXhwZWN0IHRoZSBjcmVhdGlvbiBvZiB0aGUgbm9kZSB3b3VsZCBhbHNvIGZh aWwgaWYgaW5zdGVhZCBvZiByZW1vdmluZyANCj4gdGhlIG5vZGUgaWYgcmVtb3ZlZCBvdXRz aWRlIG9mIHRoZSB0cmFuc2FjdGlvbi4NCj4gDQo+IFRoaXMgaXMgbm90IHRoZSBjYXNlIGJl Y2F1c2Ugd2UgYXJlIGxvb2tpbmcgYXQgdGhlIGN1cnJlbnQgcXVvdGEuIFNvIHNob3VsZG4n dCANCj4gd2Ugc25hcHNob3QgdGhlIGdsb2JhbCBjb3VudD8NCg0KQXMgd2UgZG9uJ3QgZG8g YSBnbG9iYWwgc25hcHNob3Qgb2YgdGhlIGRhdGEgYmFzZSBmb3IgYSB0cmFuc2FjdGlvbiAo dGhpcyB3YXMNCmNoYW5nZWQgZHVlIHRvIGh1Z2UgbWVtb3J5IG5lZWRzLCBiYWQgcGVyZm9y bWFuY2UsIGFuZCBhIGhpZ2hlciB0cmFuc2FjdGlvbg0KZmFpbHVyZSByYXRlKSwgSSBkb24n dCB0aGluayB3ZSBzaG91bGQgc25hcHNob3QgdGhlIGNvdW50IGVpdGhlci4NCg0KQSB0cmFu c2FjdGlvbiBpcyBwZXJmb3JtZWQgYXRvbWljYWxseSBhdCB0aGUgdGltZSBpdCBpcyBmaW5p c2hlZC4gVGhlcmVmb3JlDQpzZWVpbmcgdGhlIGN1cnJlbnQgZ2xvYmFsIHN0YXRlIGluc2lk ZSB0aGUgdHJhbnNhY3Rpb24gKHdpdGggdGhlIHRyYW5zYWN0aW9uDQpwcml2YXRlIHN0YXRl IG9uIHRvcCBsaWtlIGFuIG92ZXJsYXkpIGlzIGFic29sdXRlbHkgZmluZSBJTU8uDQoNCg0K SnVlcmdlbg0K --------------qzMXwcMZTgCBfDiaM4ojIKxN Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------qzMXwcMZTgCBfDiaM4ojIKxN-- --------------BqnaCl1sI9J9zjInHdE4bPgx-- --------------8KnR0DNmu6tzonXCdzmVUbvS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP0fIUFAwAAAAAACgkQsN6d1ii/Ey+V OAf+KPXAV0Fzr4JSR3mCsfhjK4Q2VPUgewMd2Vim9xrhsUN3G1/3KjRoc9umxli40LfHMlpYVS9E 4RwY9Kn97I8fnaZ/kLftq1mVrI3ZKb+YjegjMy0CFniggSMEN0p0Ehqrk6Hahp3zltKkDe/rQz0D 3RTGEWeUUgLiqiNSos+6SJtJaF1K7rsjSw6ttg83fMf/9MLrloton8n5fBMU+XI4QDogdgyFgY9n 08Bx/eURVwjMUBZSlkw3R2xI5fWFGFid+L5JBnE9KBhlf8sQpyxlX5i7vbCSwXOw7vsAvxmxyY5b e+17IalargVHjUEVKl7NaFFWnv/T5TpnKYvfFhqPTg== =kTER -----END PGP SIGNATURE----- --------------8KnR0DNmu6tzonXCdzmVUbvS-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:37:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498576.769447 (Exim 4.92) (envelope-from ) id 1pUO9U-0006ec-DH; Tue, 21 Feb 2023 08:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498576.769447; Tue, 21 Feb 2023 08:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUO9U-0006eV-Aj; Tue, 21 Feb 2023 08:37:32 +0000 Received: by outflank-mailman (input) for mailman id 498576; Tue, 21 Feb 2023 08:37:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUO9S-0006eN-5R for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:37:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f86fd489-b1c2-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:37:27 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A577720B1B; Tue, 21 Feb 2023 08:37:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8014913223; Tue, 21 Feb 2023 08:37:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id v6jdHcaC9GM9DgAAMHmgww (envelope-from ); Tue, 21 Feb 2023 08:37:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f86fd489-b1c2-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676968646; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1AZtNtrxgI4BvzH4UzfSpv6we092Vy5gZ9fE2x0/6dM=; b=i2glMOs2Vk4exL98oGBqxI/rwgC34LT0GMvh7HkCGdQ3FdzzkrnGwwkRSLOua+a+wb1pqe HVTc2eCBbvhb7dxXAXmffeYdp7b4CzWWyJ7o62BXaRrLDrfqImXW2JSsGZv0WO0V8L3v02 76Ucy43Z7H27b977+0GVAHw0TK+oCK8= Message-ID: <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> Date: Tue, 21 Feb 2023 09:37:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PSgAXvAppKhq0ebBVuSg0iky" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PSgAXvAppKhq0ebBVuSg0iky Content-Type: multipart/mixed; boundary="------------nAnMop6GQ7p0FTJBxiy938cS"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> In-Reply-To: --------------nAnMop6GQ7p0FTJBxiy938cS Content-Type: multipart/mixed; boundary="------------j9fmzJZ1rlQwSrEkWdk99mkL" --------------j9fmzJZ1rlQwSrEkWdk99mkL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMjM6NTAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ bnN0ZWFkIG9mIG1vZGlmeWluZyBhY2NvdW50aW5nIGRhdGEgYW5kIHVuZG8gdGhvc2UgbW9k aWZpY2F0aW9ucyBpbg0KPj4gY2FzZSBvZiBhbiBlcnJvciBkdXJpbmcgZnVydGhlciBwcm9j ZXNzaW5nLCBhZGQgYSBmcmFtZXdvcmsgZm9yDQo+PiBjb2xsZWN0aW5nIHRoZSBuZWVkZWQg Y2hhbmdlcyBhbmQgY29tbWl0IHRoZW0gb25seSB3aGVuIHRoZSB3aG9sZQ0KPj4gb3BlcmF0 aW9uIGhhcyBzdWNjZWVkZWQuDQo+Pg0KPj4gVGhpcyBzY2hlbWUgY2FuIHJldXNlIGxhcmdl IHBhcnRzIG9mIHRoZSBwZXIgdHJhbnNhY3Rpb24gYWNjb3VudGluZy4NCj4+IFRoZSBjaGFu Z2VkX2RvbWFpbiBoYW5kbGluZyBjYW4gYmUgcmV1c2VkLCBidXQgdGhlIGFycmF5IHNpemUg b2YgdGhlDQo+PiBhY2NvdW50aW5nIGRhdGEgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGJlIGRp ZmZlcmVudCBmb3IgYm90aCB1c2UgY2FzZXMuDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSnVl cmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gLS0tDQo+PiDCoCB0b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfY29yZS5jwqDCoCB8wqAgNSArKysNCj4+IMKgIHRvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmjCoMKgIHzCoCAzICsrDQo+PiDCoCB0b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfZG9tYWluLmMgfCA2NCArKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggfMKgIDUgKyst DQo+PiDCoCA0IGZpbGVzIGNoYW5nZWQsIDY4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBpbmRleCAyN2RmYmU5 NTkzLi4yZDEwY2FjZjM1IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYw0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0K Pj4gQEAgLTEwMjMsNiArMTAyMyw5IEBAIHN0YXRpYyB2b2lkIHNlbmRfZXJyb3Ioc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGludCBlcnJvcikNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGJyZWFrOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+IMKgwqDCoMKgwqAg fQ0KPj4gKw0KPj4gK8KgwqDCoCBhY2NfZHJvcChjb25uKTsNCj4+ICsNCj4+IMKgwqDCoMKg wqAgc2VuZF9yZXBseShjb25uLCBYU19FUlJPUiwgeHNkX2Vycm9yc1tpXS5lcnJzdHJpbmcs DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RybGVuKHhzZF9lcnJvcnNb aV0uZXJyc3RyaW5nKSArIDEpOw0KPj4gwqAgfQ0KPj4gQEAgLTEwNjAsNiArMTA2Myw3IEBA IHZvaWQgc2VuZF9yZXBseShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgZW51bSANCj4+IHhz ZF9zb2NrbXNnX3R5cGUgdHlwZSwNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gwqDCoMKgwqDCoCBj b25uLT5pbiA9IE5VTEw7DQo+PiArwqDCoMKgIGFjY19jb21taXQoY29ubik7DQo+IA0KPiBB RkFJVSwgaWYgc2VuZF9yZXBseSgpIGlzIGNhbGxlZCB0aGVuIHdlIHdvdWxkIG5lZWQgdG8g Y29tbWl0IHRoZSBhY2NvdW50aW5nIA0KPiBldmVuIGlmIHdlIGNhbid0IHNlbmQgdGhlIHJl cGx5IChpLmUuIHNlbmRfcmVwbHkoKSkuIFNvIHNob3VsZG4ndCB0aGlzIGJlIGNhbGwgDQo+ IHJpZ2h0IGF0IHRoZSBiZWdpbm5pbmcgb2Ygc2VuZF9yZXBseSgpPw0KDQpPaCwgaW5kZWVk LiBHb29kIGNhdGNoIQ0KDQo+IA0KPj4gwqDCoMKgwqDCoCAvKiBVcGRhdGUgcmVsZXZhbnQg aGVhZGVyIGZpZWxkcyBhbmQgZmlsbCBpbiB0aGUgbWVzc2FnZSBib2R5LiAqLw0KPj4gwqDC oMKgwqDCoCBiZGF0YS0+aGRyLm1zZy50eXBlID0gdHlwZTsNCj4+IEBAIC0yMTk1LDYgKzIx OTksNyBAQCBzdHJ1Y3QgY29ubmVjdGlvbiAqbmV3X2Nvbm5lY3Rpb24oY29uc3Qgc3RydWN0 IA0KPj4gaW50ZXJmYWNlX2Z1bmNzICpmdW5jcykNCj4+IMKgwqDCoMKgwqAgbmV3LT5pc19z dGFsbGVkID0gZmFsc2U7DQo+PiDCoMKgwqDCoMKgIG5ldy0+dHJhbnNhY3Rpb25fc3RhcnRl ZCA9IDA7DQo+PiDCoMKgwqDCoMKgIElOSVRfTElTVF9IRUFEKCZuZXctPm91dF9saXN0KTsN Cj4+ICvCoMKgwqAgSU5JVF9MSVNUX0hFQUQoJm5ldy0+YWNjX2xpc3QpOw0KPj4gwqDCoMKg wqDCoCBJTklUX0xJU1RfSEVBRCgmbmV3LT5yZWZfbGlzdCk7DQo+PiDCoMKgwqDCoMKgIElO SVRfTElTVF9IRUFEKCZuZXctPndhdGNoZXMpOw0KPj4gwqDCoMKgwqDCoCBJTklUX0xJU1Rf SEVBRCgmbmV3LT50cmFuc2FjdGlvbl9saXN0KTsNCj4+IGRpZmYgLS1naXQgYS90b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Nv cmUuaA0KPj4gaW5kZXggYzU5YjA2NTUxZi4uMWY4MTFmMzhjYiAxMDA2NDQNCj4+IC0tLSBh L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgNCj4+ICsrKyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmgNCj4+IEBAIC0xMzksNiArMTM5LDkgQEAgc3RydWN0IGNv bm5lY3Rpb24NCj4+IMKgwqDCoMKgwqAgc3RydWN0IGxpc3RfaGVhZCBvdXRfbGlzdDsNCj4+ IMKgwqDCoMKgwqAgdWludDY0X3QgdGltZW91dF9tc2VjOw0KPj4gK8KgwqDCoCAvKiBOb3Qg eWV0IGNvbW1pdHRlZCBhY2NvdW50aW5nIGRhdGEgKHZhbGlkIGlmIGluICE9IE5VTEwpLiAq Lw0KPj4gK8KgwqDCoCBzdHJ1Y3QgbGlzdF9oZWFkIGFjY19saXN0Ow0KPj4gKw0KPj4gwqDC oMKgwqDCoCAvKiBSZWZlcmVuY2VkIHJlcXVlc3RzIG5vIGxvbmdlciBwZW5kaW5nLiAqLw0K Pj4gwqDCoMKgwqDCoCBzdHJ1Y3QgbGlzdF9oZWFkIHJlZl9saXN0Ow0KPj4gZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyANCj4+IGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jDQo+PiBpbmRleCBmNDU5YzVhYWJiLi4zMzEwNWRi YThmIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5j DQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4+IEBAIC0x MDAsNyArMTAwLDcgQEAgc3RydWN0IGNoYW5nZWRfZG9tYWluDQo+PiDCoMKgwqDCoMKgIHVu c2lnbmVkIGludCBkb21pZDsNCj4+IMKgwqDCoMKgwqAgLyogQWNjb3VudGluZyBkYXRhLiAq Lw0KPj4gLcKgwqDCoCBpbnQgYWNjW0FDQ19UUl9OXTsNCj4+ICvCoMKgwqAgaW50IGFjY1td Ow0KPiANCj4gSXMgdGhpcyBhY3R1YWxseSB3b3J0aCBpdD8gSG93IG11Y2ggbWVtb3J5IHdv dWxkIHdlIHNhdmU/DQoNCkhtbSwgdHJ1ZS4gV2hpbGUgYmVpbmcgbW9yZSBnZW5lcmljLCB0 aGUgc2F2ZWQgbWVtb3J5IGlzIGFjdHVhbGx5IHplcm8sDQphcyBBQ0NfVFJfTiBhbmQgQUND X1JFUV9OIGhhdmUgdGhlIHNhbWUgdmFsdWUuIEFuZCBldmVuIGlmIHRoZXkgc2hvdWxkDQpk aWZmZXIgaW4gZnV0dXJlLCB3ZSBjYW4ganVzdCB1c2UgdGhlIGhpZ2hlciBvZiBib3RoIHZh bHVlcyBoZXJlLg0KDQo+IA0KPj4gwqAgfTsNCj4+IMKgIHN0YXRpYyBzdHJ1Y3QgaGFzaHRh YmxlICpkb21oYXNoOw0KPj4gQEAgLTU3Nyw2ICs1NzcsNyBAQCBzdGF0aWMgc3RydWN0IGNo YW5nZWRfZG9tYWluIA0KPj4gKmFjY19maW5kX2NoYW5nZWRfZG9tYWluKHN0cnVjdCBsaXN0 X2hlYWQgKmhlYWQsDQo+PiDCoCBzdGF0aWMgc3RydWN0IGNoYW5nZWRfZG9tYWluICphY2Nf Z2V0X2NoYW5nZWRfZG9tYWluKGNvbnN0IHZvaWQgKmN0eCwNCj4+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg bGlzdF9oZWFkICpoZWFkLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGVudW0gYWNjaXRlbSBhY2Nfc3osDQo+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdW5zaWduZWQgaW50IGRvbWlkKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3Qg Y2hhbmdlZF9kb21haW4gKmNkOw0KPj4gQEAgLTU4NSw3ICs1ODYsNyBAQCBzdGF0aWMgc3Ry dWN0IGNoYW5nZWRfZG9tYWluICphY2NfZ2V0X2NoYW5nZWRfZG9tYWluKGNvbnN0IA0KPj4g dm9pZCAqY3R4LA0KPj4gwqDCoMKgwqDCoCBpZiAoY2QpDQo+PiDCoMKgwqDCoMKgwqDCoMKg wqAgcmV0dXJuIGNkOw0KPj4gLcKgwqDCoCBjZCA9IHRhbGxvY196ZXJvKGN0eCwgc3RydWN0 IGNoYW5nZWRfZG9tYWluKTsNCj4+ICvCoMKgwqAgY2QgPSB0YWxsb2NfemVyb19zaXplKGN0 eCwgc2l6ZW9mKCpjZCkgKyBhY2Nfc3ogKiBzaXplb2YoY2QtPmFjY1swXSkpOw0KPj4gwqDC oMKgwqDCoCBpZiAoIWNkKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0K Pj4gQEAgLTU5NiwxMyArNTk3LDEzIEBAIHN0YXRpYyBzdHJ1Y3QgY2hhbmdlZF9kb21haW4g DQo+PiAqYWNjX2dldF9jaGFuZ2VkX2RvbWFpbihjb25zdCB2b2lkICpjdHgsDQo+PiDCoCB9 DQo+PiDCoCBzdGF0aWMgaW50IGFjY19hZGRfY2hhbmdlZF9kb20oY29uc3Qgdm9pZCAqY3R4 LCBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkLA0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBlbnVtIGFjY2l0ZW0gd2hhdCwgaW50IHZhbCwgdW5zaWduZWQgaW50 IGRvbWlkKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBlbnVt IGFjY2l0ZW0gYWNjX3N6LCBlbnVtIGFjY2l0ZW0gd2hhdCwNCj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaW50IHZhbCwgdW5zaWduZWQgaW50IGRvbWlkKQ0K Pj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgY2hhbmdlZF9kb21haW4gKmNkOw0KPj4g LcKgwqDCoCBhc3NlcnQod2hhdCA8IEFSUkFZX1NJWkUoY2QtPmFjYykpOw0KPj4gLQ0KPj4g LcKgwqDCoCBjZCA9IGFjY19nZXRfY2hhbmdlZF9kb21haW4oY3R4LCBoZWFkLCBkb21pZCk7 DQo+PiArwqDCoMKgIGFzc2VydCh3aGF0IDwgYWNjX3N6KTsNCj4+ICvCoMKgwqAgY2QgPSBh Y2NfZ2V0X2NoYW5nZWRfZG9tYWluKGN0eCwgaGVhZCwgYWNjX3N6LCBkb21pZCk7DQo+PiDC oMKgwqDCoMKgIGlmICghY2QpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+ PiBAQCAtMTA3MSw2ICsxMDcyLDcgQEAgc3RhdGljIGludCBkb21haW5fYWNjX2FkZChzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgDQo+PiB1bnNpZ25lZCBpbnQgZG9taWQsDQo+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZW51bSBhY2NpdGVtIHdoYXQsIGludCBhZGQs IGJvb2wgbm9fZG9tX2FsbG9jKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCBzdHJ1Y3QgZG9t YWluICpkOw0KPj4gK8KgwqDCoCBzdHJ1Y3QgY2hhbmdlZF9kb21haW4gKmNkOw0KPj4gwqDC oMKgwqDCoCBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkOw0KPj4gwqDCoMKgwqDCoCBpbnQgcmV0 Ow0KPj4gQEAgLTEwOTEsMTAgKzEwOTMsMjYgQEAgc3RhdGljIGludCBkb21haW5fYWNjX2Fk ZChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgDQo+PiB1bnNpZ25lZCBpbnQgZG9taWQsDQo+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgfQ0KPj4gwqDCoMKgwqDCoCB9DQo+PiArwqDCoMKgIC8q IFRlbXBvcmFyeSBhY2NvdW50aW5nIGRhdGEgdW50aWwgZmluYWwgY29tbWl0PyAqLw0KPj4g K8KgwqDCoCBpZiAoY29ubiAmJiBjb25uLT5pbiAmJiB3aGF0IDwgQUNDX1JFUV9OKSB7DQo+ PiArwqDCoMKgwqDCoMKgwqAgLyogQ29uc2lkZXIgdHJhbnNhY3Rpb24gbG9jYWwgZGF0YS4g Ki8NCj4+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSAwOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGlm IChjb25uLT50cmFuc2FjdGlvbiAmJiB3aGF0IDwgQUNDX1RSX04pIHsNCj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGhlYWQgPSB0cmFuc2FjdGlvbl9nZXRfY2hhbmdlZF9kb21haW5z KA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb25uLT50cmFuc2FjdGlv bik7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjZCA9IGFjY19maW5kX2NoYW5nZWRf ZG9tYWluKGhlYWQsIGRvbWlkKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChj ZCkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0ID0gY2QtPmFjY1t3 aGF0XTsNCj4+ICvCoMKgwqDCoMKgwqDCoCB9DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0ICs9 IGFjY19hZGRfY2hhbmdlZF9kb20oY29ubi0+aW4sICZjb25uLT5hY2NfbGlzdCwgQUNDX1JF UV9OLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB3 aGF0LCBhZGQsIGRvbWlkKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZXJybm8gPyAt MSA6IGRvbWFpbl9hY2NfYWRkX2NoayhkLCB3aGF0LCByZXQsIGRvbWlkKTsNCj4+ICvCoMKg wqAgfQ0KPj4gKw0KPj4gwqDCoMKgwqDCoCBpZiAoY29ubiAmJiBjb25uLT50cmFuc2FjdGlv biAmJiB3aGF0IDwgQUNDX1RSX04pIHsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBoZWFkID0g dHJhbnNhY3Rpb25fZ2V0X2NoYW5nZWRfZG9tYWlucyhjb25uLT50cmFuc2FjdGlvbik7DQo+ PiAtwqDCoMKgwqDCoMKgwqAgcmV0ID0gYWNjX2FkZF9jaGFuZ2VkX2RvbShjb25uLT50cmFu c2FjdGlvbiwgaGVhZCwgd2hhdCwNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgYWRkLCBkb21pZCk7DQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0g YWNjX2FkZF9jaGFuZ2VkX2RvbShjb25uLT50cmFuc2FjdGlvbiwgaGVhZCwgQUNDX1RSX04s DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHdoYXQs IGFkZCwgZG9taWQpOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChlcnJubykgew0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZmFpbF90cmFuc2FjdGlvbihjb25uLT50cmFu c2FjdGlvbik7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gLTE7DQo+ PiBAQCAtMTEwNyw2ICsxMTI1LDM2IEBAIHN0YXRpYyBpbnQgZG9tYWluX2FjY19hZGQoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIA0KPj4gdW5zaWduZWQgaW50IGRvbWlkLA0KPj4gwqDC oMKgwqDCoCByZXR1cm4gZC0+YWNjW3doYXRdOw0KPj4gwqAgfQ0KPj4gK3ZvaWQgYWNjX2Ry b3Aoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4pDQo+PiArew0KPj4gK8KgwqDCoCBzdHJ1Y3Qg Y2hhbmdlZF9kb21haW4gKmNkOw0KPj4gKw0KPj4gK8KgwqDCoCB3aGlsZSAoKGNkID0gbGlz dF90b3AoJmNvbm4tPmFjY19saXN0LCBzdHJ1Y3QgY2hhbmdlZF9kb21haW4sIGxpc3QpKSkg ew0KPiANCj4gTklUOiBZb3UgY291bGQgdXNlIGxpc3RfZm9yX2VhY2hfc2FmZSgpOw0KDQpZ ZXMsIGF0IHRoZSBjb3N0IG9mIGFuIGFkZGl0aW9uYWwgdmFyaWFibGUuDQoNCj4gDQo+PiAr wqDCoMKgwqDCoMKgwqAgbGlzdF9kZWwoJmNkLT5saXN0KTsNCj4+ICvCoMKgwqDCoMKgwqDC oCB0YWxsb2NfZnJlZShjZCk7DQo+PiArwqDCoMKgIH0NCj4+ICt9DQo+PiArDQo+PiArdm9p ZCBhY2NfY29tbWl0KHN0cnVjdCBjb25uZWN0aW9uICpjb25uKQ0KPj4gK3sNCj4+ICvCoMKg wqAgc3RydWN0IGNoYW5nZWRfZG9tYWluICpjZDsNCj4+ICvCoMKgwqAgc3RydWN0IGJ1ZmZl cmVkX2RhdGEgKmluID0gY29ubi0+aW47DQo+PiArwqDCoMKgIGVudW0gYWNjaXRlbSB3aGF0 Ow0KPj4gKw0KPj4gK8KgwqDCoCBjb25uLT5pbiA9IE5VTEw7IC8qIEF2b2lkIHJlY3Vyc2lv bi4gKi8NCj4gDQo+IEkgYW0gbm90IHN1cmUgSSB1bmRlcnN0YW5kIHRoaXMgY29tbWVudC4g Q2FuIHlvdSBwcm92aWRlIG1vcmUgZGV0YWlscyB3aGVyZSB0aGUgDQo+IHJlY3Vyc2lvbiB3 b3VsZCBoYXBwZW4/DQoNCmRvbWFpbl9hY2NfYWRkKCkgbWlnaHQgZG8gdGVtcG9yYXJ5IGFj Y291bnRpbmcgaWYgY29ubi0+aW4gaXNuJ3QgTlVMTC4NCg0KPiANCj4+ICvCoMKgwqAgd2hp bGUgKChjZCA9IGxpc3RfdG9wKCZjb25uLT5hY2NfbGlzdCwgc3RydWN0IGNoYW5nZWRfZG9t YWluLCBsaXN0KSkpIHsNCj4gDQo+IE5JVDogWW91IGNvdWxkIHVzZSBsaXN0X2Zvcl9lYWNo X3NhZmUoKTsNCg0KTGlrZSBhYm92ZS4NCg0KPiANCj4+ICvCoMKgwqDCoMKgwqDCoCBsaXN0 X2RlbCgmY2QtPmxpc3QpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGZvciAod2hhdCA9IDA7IHdo YXQgPCBBQ0NfUkVRX047IHdoYXQrKykNCj4gDQo+IFRoZXJlIGlzIGEgY2hhbmNlIHRoYXQg c29tZSBjb21waWxlciB3aWxsIGNvbXBsYWluIGFib3V0IHRoaXMgbGluZSBiZWNhdXNlIA0K PiBBQ0NfUkVRX04gPSAwLiBTbyB0aGlzIHdvdWxkIGFsd2F5cyBiZSB0cnVlLiBUaGVyZWZv cmUuLi4NCg0KSHVoPyBJdCB3b3VsZCBhbHdheXMgYmUgZmFsc2UuDQoNCj4gDQo+PiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoY2QtPmFjY1t3aGF0XSkNCj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgZG9tYWluX2FjY19hZGQoY29ubiwgY2QtPmRvbWlkLCB3 aGF0LA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgY2QtPmFjY1t3aGF0XSwgdHJ1ZSk7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKg wqAgdGFsbG9jX2ZyZWUoY2QpOw0KPj4gK8KgwqDCoCB9DQo+PiArDQo+PiArwqDCoMKgIGNv bm4tPmluID0gaW47DQo+PiArfQ0KPj4gKw0KPj4gwqAgaW50IGRvbWFpbl9uYmVudHJ5X2lu YyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgdW5zaWduZWQgaW50IGRvbWlkKQ0KPj4gwqAg ew0KPj4gwqDCoMKgwqDCoCByZXR1cm4gKGRvbWFpbl9hY2NfYWRkKGNvbm4sIGRvbWlkLCBB Q0NfTk9ERVMsIDEsIGZhbHNlKSA8IDApDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5oIA0KPj4gYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf ZG9tYWluLmgNCj4+IGluZGV4IDgyNTljMTE0YjAuLmNkODViZDBjYWQgMTAwNjQ0DQo+PiAt LS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgNCj4+ICsrKyBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uaA0KPj4gQEAgLTIwLDcgKzIwLDggQEANCj4+ IMKgICNkZWZpbmUgX1hFTlNUT1JFRF9ET01BSU5fSA0KPj4gwqAgZW51bSBhY2NpdGVtIHsN Cj4+IC3CoMKgwqAgQUNDX05PREVTLA0KPj4gK8KgwqDCoCBBQ0NfUkVRX04swqDCoMKgwqDC oMKgIC8qIE51bWJlciBvZiBlbGVtZW50cyBwZXIgcmVxdWVzdCBhbmQgZG9tYWluLiAqLw0K Pj4gK8KgwqDCoCBBQ0NfTk9ERVMgPSBBQ0NfUkVRX04sDQo+IA0KPiBJIHdvdWxkIGJyaW5n IGZvcndhcmQgdGhlIGNoYW5nZSBpbiBwYXRjaCAjNS4gSSBtZWFuOg0KPiANCj4gQUNDX05P REVTLA0KPiBBQ0NfUkVRX04NCg0KSSdtIG5vdCBzdXJlIHRoaXMgaXMgYSBnb29kIGlkZWEu IFRoaXMgd291bGQgYWN0aXZhdGUgdGhlIHRlbXBvcmFyeQ0KYWNjb3VudGluZyBmb3Igbm9k ZXMsIGJ1dCBrZWVwaW5nIHRoZSBlcnJvciBoYW5kbGluZyBhY3RpdmUuIEknZCByYXRoZXIN CmFjdGl2YXRlIHRlbXBvcmFyeSBhY2NvdW50aW5nIGZvciBub2RlcyB0b2dldGhlciB3aXRo IHJlbW92aW5nIHRoZQ0KYWNjb3VudGluZyBjb3JyZWN0aW9uIGluIHRoZSBlcnJvciBoYW5k bGluZy4NCg0KPiANCj4+IMKgwqDCoMKgwqAgQUNDX1RSX04swqDCoMKgwqDCoMKgwqAgLyog TnVtYmVyIG9mIGVsZW1lbnRzIHBlciB0cmFuc2FjdGlvbiBhbmQgZG9tYWluLiAqLw0KPj4g wqDCoMKgwqDCoCBBQ0NfTiA9IEFDQ19UUl9OIC8qIE51bWJlciBvZiBlbGVtZW50cyBwZXIg ZG9tYWluLiAqLw0KPj4gwqAgfTsNCj4gDQo+IFRoaXMgZW51bSBpcyBnZXR0aW5nIGV4dHJl bWVseSBjb25mdXNpbmcuIFRoZXJlIGFyZSBtYW55ICJudW1iZXIgb2YgZWxlbWVudHMgcGVy IA0KPiAuLi4gZG9tYWluIi4gQ2FuIHlvdSBjbGFyaWZ5Pw0KDQpJIHdpbGwgYWRkIHNvbWUg bW9yZSBjb21tZW50cyB0byB0aGUgaGVhZGVyLiBXb3VsZCB5b3UgbGlrZSBpdCBiZXR0ZXIg dG8gaGF2ZQ0KdGhlIGxpbWl0cyBpbmRlbnRlZCBtb3JlPyBzb21ldGhpbmcgbGlrZToNCg0K ZW51bSBhY2NpdGVtIHsNCiAgICAgICAgIEFDQ19OT0RFUywNCgkJLyogTnVtYmVyIG9mIGVs ZW1lbnRzIHBlciByZXF1ZXN0IGFuZCBkb21haW4uICovDQoJCUFDQ19SRVFfTiwNCgkJLyog TnVtYmVyIG9mIGVsZW1lbnRzIHBlciB0cmFuc2FjdGlvbiBhbmQgZG9tYWluLiAqLw0KICAg ICAgICAgCUFDQ19UUl9OID0gQUNDX1JFUV9OLA0KICAgICAgICAgQUNDX1dBVENIID0gQUND X1RSX04sDQogICAgICAgICBBQ0NfT1VUU1QsDQogICAgICAgICBBQ0NfTUVNLA0KICAgICAg ICAgQUNDX1RSQU5TLA0KICAgICAgICAgQUNDX1RSQU5TTk9ERVMsDQogICAgICAgICBBQ0Nf TlBFUk0sDQogICAgICAgICBBQ0NfUEFUSExFTiwNCiAgICAgICAgIEFDQ19OT0RFU1osDQoJ CS8qIE51bWJlciBvZiBlbGVtZW50cyBwZXIgZG9tYWluLiAqLw0KICAgICAgICAgCUFDQ19O DQp9Ow0KDQoNCkp1ZXJnZW4NCg0K --------------j9fmzJZ1rlQwSrEkWdk99mkL Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------j9fmzJZ1rlQwSrEkWdk99mkL-- --------------nAnMop6GQ7p0FTJBxiy938cS-- --------------PSgAXvAppKhq0ebBVuSg0iky Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP0gsYFAwAAAAAACgkQsN6d1ii/Ey9E dwf/ZfNqMjn3jR7IF6BoW/h6B7mqAw9xbBaxmPFy2ZqK59vBdltYsZK0YTCKbaLXzXhgAuCINfiO Mmw/zGrJRJkjaHjISd5HJ9HbsA2VPzCUp0uKYcbwSI0nNvArLwCTQ8i4dT1XzqXOROrBUN5nE+p0 qApmXCHr2kYCoECBehaQkRRgUF3mfyVKIO2wCeo4WNCG2vp4Hpdsoi2+XAzBWlg9sNHNronASlw3 DbdpXeMuohOQINn6ztuT4MDRXFWOE7bwo/qPpVTPp8zy3zvnhUm7CD31+S6LzgnyJg0hJjh7R5uM SpfsbYPKTJFUAVy9MM46tm4j6qlhLs9JLHElmV2VLg== =VUU0 -----END PGP SIGNATURE----- --------------PSgAXvAppKhq0ebBVuSg0iky-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:39:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:39:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498582.769458 (Exim 4.92) (envelope-from ) id 1pUOBk-0007S9-Pa; Tue, 21 Feb 2023 08:39:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498582.769458; Tue, 21 Feb 2023 08:39:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOBk-0007S2-Mz; Tue, 21 Feb 2023 08:39:52 +0000 Received: by outflank-mailman (input) for mailman id 498582; Tue, 21 Feb 2023 08:39:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOBj-0007Rw-D1 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:39:51 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e090336-b1c3-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 09:39:50 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id b12so13866130edd.4 for ; Tue, 21 Feb 2023 00:39:50 -0800 (PST) Received: from gmail.com (1F2EF163.nat.pool.telekom.hu. [31.46.241.99]) by smtp.gmail.com with ESMTPSA id g23-20020a170906539700b008b128106fc7sm6835503ejo.46.2023.02.21.00.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 00:39:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4e090336-b1c3-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=+s3LghqL/xNmAVCsHxyUzyrjEgIj+4vMZ5iip7icUXw=; b=BeQAjFO9ydOReLQGkvdAAU/LRuf7WcC3QQk2V7giMfmBzOpAzm9xlK5CC7pqR25XYO vlGacp8gx2xLItmgNYKS/IMUAEXYqgc+2k0Llwn68G+WN8w0cw1eIrlBvugyaO8H4lS/ BzIg3kd5h5tmPj7T9vF1Fs/6Dk+Iqc87s1guyXkDF9rMOCXyoQZIOv3D1LDA4GZHESE0 EYzFl3AVlvWz0sIpKB8UluoBij7uzBsbQK8gurSlP8igsiOZW6EplyCpUfnkjf9HNkcM RlhbNcoeXHkIW/eq4lkUtsoDgBuMy/6lmqx1/QUZVYjWkOZ3D5R0BXviU0TBpy30MiOL YvNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+s3LghqL/xNmAVCsHxyUzyrjEgIj+4vMZ5iip7icUXw=; b=lgZB/fy1Uk5a8WMdlpKcTP7AxiFubyv40K7mn/bP+tni/02HUG0GCIp45P/+UnqcZq o+mQ1a85IbvSOyXOWJNH4n/seYirfPGV16z+T3qPTMJeL4AVJUmDc66S8yh4MuDmsHWZ g1psQZLnbF6IDnmU/+Y1drwfctqqYm3hBHABIsczfx/3KUL3I/8HpcTa/t8kipaxsSAs rQMJU/yakIQ/NK3Rm4a+QvWOnDG5bWxNxC89P4Mnwht/Le5n6FwVdIcvCpWhSgG4by1d t/2g7KG3ERcAD1+7dff7SjaRAIScq7YEykqu3HmxKhJwzxEVgBzxvSWRCZ8IRyeQMywU qRIg== X-Gm-Message-State: AO0yUKWUplBZILiDcqF5VggCg6UUyfobc5MpzhBdjypvU2hCuL2jdtAh sxQTAtrdTAoGKybloHyMryE= X-Google-Smtp-Source: AK7set8zE5R9imDjkfkNuxiJSk0+e0JA3dNsTUxWIeITlzljnpOOVxOFMIa6S9dDuddJcALQVRJnQQ== X-Received: by 2002:a17:906:2358:b0:88d:d700:fe15 with SMTP id m24-20020a170906235800b0088dd700fe15mr10557817eja.0.1676968789991; Tue, 21 Feb 2023 00:39:49 -0800 (PST) Sender: Ingo Molnar Date: Tue, 21 Feb 2023 09:39:47 +0100 From: Ingo Molnar To: Peter Zijlstra Cc: Stephen Rothwell , Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Xen Devel , Per Bilse , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: duplicate patches in the xen-tip tree Message-ID: References: <20230214124700.22f0a62e@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Peter Zijlstra wrote: > On Tue, Feb 14, 2023 at 12:47:00PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > The following commits are also in the tip tree as different commits > > (but the same patches): > > > > 415dab3c1796 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspace") > > 336f560a8917 ("x86/xen: don't let xen_pv_play_dead() return") > > f697cb00afa9 ("x86/xen: mark xen_pv_play_dead() as __noreturn") > > > > These are commits > > > > 859761e770f8 ("drivers/xen/hypervisor: Expose Xen SIF flags to userspace") > > 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return") > > 1aff0d2658e5 ("x86/xen: mark xen_pv_play_dead() as __noreturn") > > > > in the tip tree. > > This was intentional (dependencies) and the plan is to only offer the > tip branch for merge after the Xen tree goes in. The rebase & *duplication* was not intentional at all - I assumed 1aff0d2658e5 won't get rebased. :-/ We'll probably have to redo the objtool tree. Thanks, Ingo From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:40:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:40:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498585.769469 (Exim 4.92) (envelope-from ) id 1pUOC5-0000Ig-1Q; Tue, 21 Feb 2023 08:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498585.769469; Tue, 21 Feb 2023 08:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOC4-0000IZ-UI; Tue, 21 Feb 2023 08:40:12 +0000 Received: by outflank-mailman (input) for mailman id 498585; Tue, 21 Feb 2023 08:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOC3-0000H9-Nc for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:40:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59528632-b1c3-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:40:09 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 28C7B5BCDA; Tue, 21 Feb 2023 08:40:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 07E4913481; Tue, 21 Feb 2023 08:40:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QDuQAGmD9GOqDwAAMHmgww (envelope-from ); Tue, 21 Feb 2023 08:40:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59528632-b1c3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676968809; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UVj+S+9O0XAa50nQrlGTfSdtbSxPFmvteyGHO25cHaY=; b=TqDDVgbzG0cX3za3fTDCXIaKPTG/cu1EsU2eDPUvOeAGvLxOuQE4gYrmlXm1L1fi33qV7i fi1EJvaZaB5wmceGcGwEHbmTo3U3kh3DaDrCypy2lzzzvbHPD/ND9dTWuR4ZEodJfXJaT1 RSjb3GfP0AhZ0638ATY1JpF1XrkYDNQ= Message-ID: Date: Tue, 21 Feb 2023 09:40:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-9-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tpdcmIIbp3DuPDGz0tqqr1Pi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tpdcmIIbp3DuPDGz0tqqr1Pi Content-Type: multipart/mixed; boundary="------------aZ2uO5maWYzDWZrcwhYTtdW9"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-9-jgross@suse.com> In-Reply-To: --------------aZ2uO5maWYzDWZrcwhYTtdW9 Content-Type: multipart/mixed; boundary="------------4FztCrEWTm70OZMaEE0Z2UV9" --------------4FztCrEWTm70OZMaEE0Z2UV9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMjM6NTcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIwLzAxLzIwMjMgMTA6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBB ZGQgYSBuZXcgdHJhY2Ugc3dpdGNoICJhY2MiIGFuZCB0aGUgcmVsYXRlZCB0cmFjZSBjYWxs cy4NCj4+DQo+PiBUaGUgImFjYyIgc3dpdGNoIGlzIG9mZiBwZXIgZGVmYXVsdC4NCj4+DQo+ PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IA0K PiBXaXRoIG9uZSByZWFtcmsgKHNlZSBiZWxvdyk6DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVs aWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gDQo+PiAtLS0NCj4+IMKgIHRvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmPCoMKgIHzCoCAyICstDQo+PiDCoCB0b29scy94 ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5owqDCoCB8wqAgMSArDQo+PiDCoCB0b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgfCAxMCArKysrKysrKysrDQo+PiDCoCAzIGZpbGVz IGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+DQo+PiBkaWZm IC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hlbnN0 b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IGluZGV4IDZlZjYwMTc5ZmEuLjU1OGVmNDkxYjEg MTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiAr KysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBAQCAtMjc0Niw3ICsy NzQ2LDcgQEAgc3RhdGljIHZvaWQgc2V0X3F1b3RhKGNvbnN0IGNoYXIgKmFyZywgYm9vbCBz b2Z0KQ0KPj4gwqAgLyogU29ydGVkIGJ5IGJpdCB2YWx1ZXMgb2YgVFJBQ0VfKiBmbGFncy4g RmxhZyBpcyAoMXUgPDwgaW5kZXgpLiAqLw0KPj4gwqAgY29uc3QgY2hhciAqY29uc3QgdHJh Y2Vfc3dpdGNoZXNbXSA9IHsNCj4+IC3CoMKgwqAgIm9iaiIsICJpbyIsICJ3cmwiLA0KPj4g K8KgwqDCoCAib2JqIiwgImlvIiwgIndybCIsICJhY2MiLA0KPj4gwqDCoMKgwqDCoCBOVUxM DQo+PiDCoCB9Ow0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9j b3JlLmggYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oDQo+PiBpbmRleCAxZjgx MWYzOGNiLi4zZTA3MzRhNmM2IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaA0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUu aA0KPj4gQEAgLTMwMiw2ICszMDIsNyBAQCBleHRlcm4gdW5zaWduZWQgaW50IHRyYWNlX2Zs YWdzOw0KPj4gwqAgI2RlZmluZSBUUkFDRV9PQkrCoMKgwqAgMHgwMDAwMDAwMQ0KPj4gwqAg I2RlZmluZSBUUkFDRV9JT8KgwqDCoCAweDAwMDAwMDAyDQo+PiDCoCAjZGVmaW5lIFRSQUNF X1dSTMKgwqDCoCAweDAwMDAwMDA0DQo+PiArI2RlZmluZSBUUkFDRV9BQ0PCoMKgwqAgMHgw MDAwMDAwOA0KPj4gwqAgZXh0ZXJuIGNvbnN0IGNoYXIgKmNvbnN0IHRyYWNlX3N3aXRjaGVz W107DQo+PiDCoCBpbnQgc2V0X3RyYWNlX3N3aXRjaChjb25zdCBjaGFyICphcmcpOw0KPj4g ZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyANCj4+IGIv dG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jDQo+PiBpbmRleCBiMWUyOWVkYjdl Li5kNDYxZmQ4Y2M4IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2RvbWFpbi5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMN Cj4+IEBAIC01MzgsNiArNTM4LDEyIEBAIHN0YXRpYyBzdHJ1Y3QgZG9tYWluICpmaW5kX2Rv bWFpbl9ieV9kb21pZCh1bnNpZ25lZCBpbnQgDQo+PiBkb21pZCkNCj4+IMKgwqDCoMKgwqAg cmV0dXJuIChkICYmIGQtPmludHJvZHVjZWQpID8gZCA6IE5VTEw7DQo+PiDCoCB9DQo+PiAr I2RlZmluZSB0cmFjZV9hY2MoLi4uKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBc DQo+IA0KPiBUaGUgaW5kZW50YXRpb24gb2YgJ1wnIGxvb2tzIG9kZC4NCg0KTm90IGZvciBt ZS4gTWF5YmUgeW91IGhhdmUgYSBkaWZmZXJlbnQgdGFiIHNldHRpbmc/DQoNCg0KSnVlcmdl bg0K --------------4FztCrEWTm70OZMaEE0Z2UV9 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4FztCrEWTm70OZMaEE0Z2UV9-- --------------aZ2uO5maWYzDWZrcwhYTtdW9-- --------------tpdcmIIbp3DuPDGz0tqqr1Pi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP0g2gFAwAAAAAACgkQsN6d1ii/Ey8p HAgAns+NYkN19/sL14OUP+Q+TvofMc3g4mYVDuFNGU/LH+iBT5wyEPJa7uGBGWsLYdE8AgAfncPE BXqNWQ54ZJmVsZ5oMthGCdhrvYd1Glmk8OVQ1E2WGKONM2JFCgY06xrrbCniZ91Yyk4V6Vkj79Ws 04lcYTkEtviG7FSknJQJgOiUK8gASaXfNpp2gMTKfnyKLkG4A95s2+0ESO3M9JJ/47aMCoMzyWCP 8JQ7TfXaS4I6wJbSIJTTXUcdHs0BL/yVZZJiLExYtD8a4RKoCCqZe/0SMZW6qzxc+K5PnfKH6i6a 7vjRiNL0A9K/fVd81MgUKE4EZIyPRJffV1qmrCYgeQ== =1u+W -----END PGP SIGNATURE----- --------------tpdcmIIbp3DuPDGz0tqqr1Pi-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:41:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:41:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498598.769484 (Exim 4.92) (envelope-from ) id 1pUOD3-00013X-Gd; Tue, 21 Feb 2023 08:41:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498598.769484; Tue, 21 Feb 2023 08:41:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOD3-00013Q-D3; Tue, 21 Feb 2023 08:41:13 +0000 Received: by outflank-mailman (input) for mailman id 498598; Tue, 21 Feb 2023 08:41:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOD2-00011d-Ih for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:41:12 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d3699fd-b1c3-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:41:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 826E95C239; Tue, 21 Feb 2023 08:41:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5FA0D13481; Tue, 21 Feb 2023 08:41:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9M4jFqWD9GMkEAAAMHmgww (envelope-from ); Tue, 21 Feb 2023 08:41:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d3699fd-b1c3-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676968869; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R0hiB1GnotiwjOHdz4A5KmIRYHIqDndNjpbzReRgBtg=; b=bBq60sd934e+9HDq16qLkSK5596mFFckK/1sQ5iXTnP2UGeRc5rgBENt8I09tR9RBHNeVb ThV2pAuXdtCqiaCmHO0t9oBAGc3wG/SM4n4BfRaXCAn3FUPKQH3ZpeAPo8mQWgKHGtOlHf Y9b8QGO6SPnBZlaQSCBUG935j4E4hFk= Message-ID: Date: Tue, 21 Feb 2023 09:41:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 09/13] tools/xenstore: add TDB access trace support Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-10-jgross@suse.com> <0f78fffe-5e53-5881-b5ac-421d1faa5e99@xen.org> From: Juergen Gross In-Reply-To: <0f78fffe-5e53-5881-b5ac-421d1faa5e99@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------g2T23BbxSwBUAsZ0xuPE6Gj6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------g2T23BbxSwBUAsZ0xuPE6Gj6 Content-Type: multipart/mixed; boundary="------------aWD9t8vcsvlxVOksOoC0UDqX"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v2 09/13] tools/xenstore: add TDB access trace support References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-10-jgross@suse.com> <0f78fffe-5e53-5881-b5ac-421d1faa5e99@xen.org> In-Reply-To: <0f78fffe-5e53-5881-b5ac-421d1faa5e99@xen.org> --------------aWD9t8vcsvlxVOksOoC0UDqX Content-Type: multipart/mixed; boundary="------------TfmROTUzoiAkQ8CDoW1gzxoT" --------------TfmROTUzoiAkQ8CDoW1gzxoT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDIuMjMgMjM6NTksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAyMC8wMS8yMDIzIDEwOjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gQWRkIGEgbmV3 IHRyYWNlIHN3aXRjaCAidGRiIiBhbmQgdGhlIHJlbGF0ZWQgdHJhY2UgY2FsbHMuDQo+Pg0K Pj4gVGhlICJ0ZGIiIHN3aXRjaCBpcyBvZmYgcGVyIGRlZmF1bHQuDQo+Pg0KPj4gU2lnbmVk LW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiANCj4gV2l0aCBv bmUgcmVtYXJrIChzZWUgYmVsb3cpOg0KPiANCj4gUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFs bCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IA0KPj4gLS0tDQo+PiDCoCB0b29scy94ZW5zdG9y ZS94ZW5zdG9yZWRfY29yZS5jwqDCoMKgwqDCoMKgwqAgfCA4ICsrKysrKystDQo+PiDCoCB0 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5owqDCoMKgwqDCoMKgwqAgfCA2ICsrKysr Kw0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3RyYW5zYWN0aW9uLmMgfCA3ICsr KysrKy0NCj4+IMKgIDMgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuYyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IGluZGV4IDU1 OGVmNDkxYjEuLjQ5ZTE5NmU3YWUgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94 ZW5zdG9yZWRfY29yZS5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29y ZS5jDQo+PiBAQCAtNTg5LDYgKzU4OSw4IEBAIHN0YXRpYyB2b2lkIGdldF9hY2NfZGF0YShU REJfREFUQSAqa2V5LCBzdHJ1Y3QgDQo+PiBub2RlX2FjY291bnRfZGF0YSAqYWNjKQ0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgIGlmIChvbGRfZGF0YS5kcHRyID09IE5VTEwpIHsNCj4+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFjYy0+bWVtb3J5ID0gMDsNCj4+IMKgwqDCoMKg wqDCoMKgwqDCoCB9IGVsc2Ugew0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdHJhY2Vf dGRiKCJyZWFkICVzIHNpemUgJXp1XG4iLCBrZXktPmRwdHIsDQo+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvbGRfZGF0YS5kc2l6ZSArIGtleS0+ZHNpemUpOw0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyID0gKHZvaWQgKilvbGRfZGF0YS5k cHRyOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYWNjLT5tZW1vcnkgPSBvbGRf ZGF0YS5kc2l6ZTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFjYy0+ZG9taWQg PSBoZHItPnBlcm1zWzBdLmlkOw0KPj4gQEAgLTY1NSw2ICs2NTcsNyBAQCBpbnQgZG9fdGRi X3dyaXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5LCANCj4+IFRE Ql9EQVRBICpkYXRhLA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGVycm5vID0gRUlPOw0KPj4g wqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBlcnJubzsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4g K8KgwqDCoCB0cmFjZV90ZGIoInN0b3JlICVzIHNpemUgJXp1XG4iLCBrZXktPmRwdHIsIGRh dGEtPmRzaXplICsga2V5LT5kc2l6ZSk7DQo+PiDCoMKgwqDCoMKgIGlmIChhY2MpIHsNCj4+ IMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBEb24ndCB1c2UgbmV3X2RvbWlkLCBhcyBpdCBtaWdo dCBiZSBhIHRyYW5zYWN0aW9uIG5vZGUuICovDQo+PiBAQCAtNjgyLDYgKzY4NSw3IEBAIGlu dCBkb190ZGJfZGVsZXRlKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBUREJfREFUQSAqa2V5 LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGVycm5vID0gRUlPOw0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgIHJldHVybiBlcnJubzsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gK8KgwqDCoCB0cmFj ZV90ZGIoImRlbGV0ZSAlc1xuIiwga2V5LT5kcHRyKTsNCj4+IMKgwqDCoMKgwqAgaWYgKGFj Yy0+bWVtb3J5KSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZG9taWQgPSBnZXRfYWNjX2Rv bWlkKGNvbm4sIGtleSwgYWNjLT5kb21pZCk7DQo+PiBAQCAtNzMxLDYgKzczNSw4IEBAIHN0 cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZv aWQgDQo+PiAqY3R4LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyb3I7DQo+PiDC oMKgwqDCoMKgIH0NCj4+ICvCoMKgwqAgdHJhY2VfdGRiKCJyZWFkICVzIHNpemUgJXp1XG4i LCBrZXkuZHB0ciwgZGF0YS5kc2l6ZSArIGtleS5kc2l6ZSk7DQo+PiArDQo+PiDCoMKgwqDC oMKgIG5vZGUtPnBhcmVudCA9IE5VTEw7DQo+PiDCoMKgwqDCoMKgIHRhbGxvY19zdGVhbChu b2RlLCBkYXRhLmRwdHIpOw0KPj4gQEAgLTI3NDYsNyArMjc1Miw3IEBAIHN0YXRpYyB2b2lk IHNldF9xdW90YShjb25zdCBjaGFyICphcmcsIGJvb2wgc29mdCkNCj4+IMKgIC8qIFNvcnRl ZCBieSBiaXQgdmFsdWVzIG9mIFRSQUNFXyogZmxhZ3MuIEZsYWcgaXMgKDF1IDw8IGluZGV4 KS4gKi8NCj4+IMKgIGNvbnN0IGNoYXIgKmNvbnN0IHRyYWNlX3N3aXRjaGVzW10gPSB7DQo+ PiAtwqDCoMKgICJvYmoiLCAiaW8iLCAid3JsIiwgImFjYyIsDQo+PiArwqDCoMKgICJvYmoi LCAiaW8iLCAid3JsIiwgImFjYyIsICJ0ZGIiLA0KPj4gwqDCoMKgwqDCoCBOVUxMDQo+PiDC oCB9Ow0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgg Yi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oDQo+PiBpbmRleCAzZTA3MzRhNmM2 Li40MTlhMTQ0Mzk2IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X2NvcmUuaA0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaA0KPj4g QEAgLTMwMyw4ICszMDMsMTQgQEAgZXh0ZXJuIHVuc2lnbmVkIGludCB0cmFjZV9mbGFnczsN Cj4+IMKgICNkZWZpbmUgVFJBQ0VfSU/CoMKgwqAgMHgwMDAwMDAwMg0KPj4gwqAgI2RlZmlu ZSBUUkFDRV9XUkzCoMKgwqAgMHgwMDAwMDAwNA0KPj4gwqAgI2RlZmluZSBUUkFDRV9BQ0PC oMKgwqAgMHgwMDAwMDAwOA0KPj4gKyNkZWZpbmUgVFJBQ0VfVERCwqDCoMKgIDB4MDAwMDAw MTANCj4+IMKgIGV4dGVybiBjb25zdCBjaGFyICpjb25zdCB0cmFjZV9zd2l0Y2hlc1tdOw0K Pj4gwqAgaW50IHNldF90cmFjZV9zd2l0Y2goY29uc3QgY2hhciAqYXJnKTsNCj4gDQo+IEFk ZCBhIG5ld2xpbmUgaGVyZS4NCg0KT2theS4NCg0KDQpKdWVyZ2VuDQo= --------------TfmROTUzoiAkQ8CDoW1gzxoT Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------TfmROTUzoiAkQ8CDoW1gzxoT-- --------------aWD9t8vcsvlxVOksOoC0UDqX-- --------------g2T23BbxSwBUAsZ0xuPE6Gj6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP0g6QFAwAAAAAACgkQsN6d1ii/Ey/v aQf+MLMvqgcWrrsQ5FZ8mUehrocBU/9zM0ScpSkI+63TFtkn9j7C8YOb2ttAzFRLjUyjQAq+lr2E r5nIJt8FEwzfm0h7HFMoKThYYnA/z2FXBPELpV9b68AQU5OZk8cx+K0lIhj5Z6k7cHI8vTtqJIiH UipPFrf4FAYsJI6AzmEftJcbIFeD4/JcKC/QAq+8XNW0z0TyHomFSruBeD+nn9Qnr997orW6IeBF 88a4Em9+ODJO2VA11m6w+hh8r/tCTFjrabFkOHJ+PmQAxJNqTv+jPC4LKb6X0gtDzRHCi/Is5/f6 iiiEFTA8qCSJ2X+G2txau4adN5sbRM/KUwTRNxh9eQ== =H67u -----END PGP SIGNATURE----- --------------g2T23BbxSwBUAsZ0xuPE6Gj6-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:47:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:47:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498617.769494 (Exim 4.92) (envelope-from ) id 1pUOJ9-0001o6-5Y; Tue, 21 Feb 2023 08:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498617.769494; Tue, 21 Feb 2023 08:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOJ9-0001nz-2w; Tue, 21 Feb 2023 08:47:31 +0000 Received: by outflank-mailman (input) for mailman id 498617; Tue, 21 Feb 2023 08:47:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOJ7-0001nr-F8 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:47:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d722373-b1c4-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:47:25 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7DBE35C292; Tue, 21 Feb 2023 08:47:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 18E8C13481; Tue, 21 Feb 2023 08:47:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JJulBB2F9GPIEwAAMHmgww (envelope-from ); Tue, 21 Feb 2023 08:47:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d722373-b1c4-11ed-93b5-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1676969245; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fm3hPdB5PlDvDGKs2HpYZScsPgUDguT6fZOTv+Wh0PE=; b=VZW32+1BYbtgREkjm+6g0MuS+3gD7WRg/T7xGeI1/uwp4ani7JBqa8yEoQFOYjbAKRSfnd DdtEMw4ueW0i/CdD/LWkk58TJnpz9PJGNbc976k9QZV/o3GCAtt2JwtbTUH58sD+Ub11Og O6TX7f/2DIgmkqcC2Z6Ar9SZTxdOSzY= Message-ID: Date: Tue, 21 Feb 2023 09:47:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Content-Language: en-US To: Krister Johansen , Thomas Gleixner Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> <20230221055117.GA1934@templeofstupid.com> From: Juergen Gross In-Reply-To: <20230221055117.GA1934@templeofstupid.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------01t2a227HP0z0isoz31TbdIv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------01t2a227HP0z0isoz31TbdIv Content-Type: multipart/mixed; boundary="------------aEejvVXcvRh3zvA1PUMyYEgB"; protected-headers="v1" From: Juergen Gross To: Krister Johansen , Thomas Gleixner Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Message-ID: Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> <20230221055117.GA1934@templeofstupid.com> In-Reply-To: <20230221055117.GA1934@templeofstupid.com> --------------aEejvVXcvRh3zvA1PUMyYEgB Content-Type: multipart/mixed; boundary="------------Nc2aeEGlKWS5cu0pOGONczrT" --------------Nc2aeEGlKWS5cu0pOGONczrT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDIuMjMgMDY6NTEsIEtyaXN0ZXIgSm9oYW5zZW4gd3JvdGU6DQo+IE9uIE1vbiwg RmViIDIwLCAyMDIzIGF0IDA4OjE0OjQwUE0gLTA4MDAsIEtyaXN0ZXIgSm9oYW5zZW4gd3Jv dGU6DQo+PiBPbiBNb24sIEZlYiAyMCwgMjAyMyBhdCAxMTowMToxOFBNICswMTAwLCBUaG9t YXMgR2xlaXhuZXIgd3JvdGU6DQo+Pj4gT24gTW9uLCBGZWIgMjAgMjAyMyBhdCAwOToxNywg S3Jpc3RlciBKb2hhbnNlbiB3cm90ZToNCj4+Pj4gQEAgLTQ5NSw4ICs0OTYsNyBAQCBzdGF0 aWMgaW50IF9faW5pdCB4ZW5fdHNjX3NhZmVfY2xvY2tzb3VyY2Uodm9pZCkNCj4+Pj4gICAJ LyogTGVhZiA0LCBzdWItbGVhZiAwICgweDQwMDAweDAzKSAqLw0KPj4+PiAgIAljcHVpZF9j b3VudCh4ZW5fY3B1aWRfYmFzZSgpICsgMywgMCwgJmVheCwgJmVieCwgJmVjeCwgJmVkeCk7 DQo+Pj4+ICAgDQo+Pj4+IC0JLyogdHNjX21vZGUgPSBub19lbXVsYXRlICgyKSAqLw0KPj4+ PiAtCWlmIChlYnggIT0gMikNCj4+Pj4gKwlpZiAoZWJ4ICE9IFhFTl9DUFVJRF9UU0NfTU9E RV9ORVZFUl9FTVVMQVRFKQ0KPj4+PiAgIAkJcmV0dXJuIDA7DQo+Pj4+ICAgDQo+Pj4+ICAg CXJldHVybiAxOw0KPj4+DQo+Pj4gV2hhdCBhYm91dCByZW1vdmluZyBtb3JlIHN0dXBpZGl0 eSBmcm9tIHRoYXQgZnVuY3Rpb24/DQo+Pj4NCj4+PiBzdGF0aWMgYm9vbCBfX2luaXQgeGVu X3RzY19zYWZlX2Nsb2Nrc291cmNlKHZvaWQpDQo+Pj4gew0KPj4+IAl1MzIgZWF4LCBlYngu IGVjeCwgZWR4Ow0KPj4+ICAgDQo+Pj4gCS8qIExlYWYgNCwgc3ViLWxlYWYgMCAoMHg0MDAw MHgwMykgKi8NCj4+PiAJY3B1aWRfY291bnQoeGVuX2NwdWlkX2Jhc2UoKSArIDMsIDAsICZl YXgsICZlYngsICZlY3gsICZlZHgpOw0KPj4+DQo+Pj4gCXJldHVybiBlYnggPT0gWEVOX0NQ VUlEX1RTQ19NT0RFX05FVkVSX0VNVUxBVEU7DQo+Pj4gfQ0KPj4NCj4+IEknbSBhbGwgZm9y IHNpbXBsaWZ5aW5nLiAgSSdtIGhhcHB5IHRvIGNsZWFuIHVwIHRoYXQgcmV0dXJuIHRvIGJl IG1vcmUNCj4+IGlkaW9tYXRpYy4gIEkgd2FzIHVuZGVyIHRoZSBpbXByZXNzaW9uLCBwZXJo YXBzIG1pc3Rha2VuLCB0aG91Z2gsIHRoYXQNCj4+IHRoZSBYODZfRkVBVFVSRV9DT05TVEFO VF9UU0MsIFg4Nl9GRUFUVVJFX05PTlNUT1BfVFNDLCBhbmQNCj4+IGNoZWNrX3RzY191bnN0 YWJsZSgpIGNoZWNrcyB3ZXJlIGFjdHVhbGx5IHNlcnZpbmcgYSBwdXJwb3NlOiB0byBlbnN1 cmUNCj4+IHRoYXQgd2UgZG9uJ3QgcmVseSBvbiB0aGUgdHNjIGluIGVudmlyb25tZW50cyB3 aGVyZSBpdCdzIGJlaW5nIGVtdWxhdGVkDQo+PiBhbmQgdGhlIE9TIHdvdWxkIGJlIGJldHRl ciBzZXJ2ZWQgYnkgdXNpbmcgYSBQViBjbG9jay4gIFNwZWNpZmljYWxseSwNCj4+IGt2bWNs b2NrX2luaXQoKSBtYWtlcyBhIHZlcnkgc2ltaWxhciBzZXQgb2YgY2hlY2tzIHRoYXQgSSBh bHNvIHRob3VnaHQNCj4+IHdlcmUgbG9hZC1iZWFyaW5nLg0KPiANCj4gQmFoLCB3aGF0IEkg bWVhbnQgdG8gc2F5IHdhcyBlbXVsYXRlZCwgdW5zdGFibGUsIG9yIG90aGVyd2lzZSB1bnN1 aXRhYmxlDQo+IGZvciB1c2UgYXMgYSBjbG9ja3NvdXJjZS4gIElPVywgZXZlbiBpZiBUU0Nf TU9ERV9ORVZFUl9FTVVMQVRFIGlzDQo+IHNldCwgaXQncyBwb3NzaWJsZSB0aGF0IGEgdXNl ciBpcyBhdHRlbXB0aW5nIGEgbWlncmF0aW9uIGZyb20gYSBjcHUNCj4gdGhhdCdzIG5vdCBp bnZhcmlhbnQsIGFuZCB3ZSdkIHN0aWxsIHdhbnQgdG8gY2hlY2sgZm9yIHRoYXQgY2FzZSBh bmQNCj4gZmFsbCBiYWNrIHRvIGEgUFYgY2xvY2tzb3VyY2UsIGNvcnJlY3Q/DQoNCkJ1dCBU aG9tYXMnIHN1Z2dlc3Rpb24gd2Fzbid0IGNoYW5naW5nIGFueSBiZWhhdmlvciBjb21wYXJl ZCB0byB5b3VyDQpwYXRjaC4gSXQganVzdCBtYWtlcyBpdCBlYXNpZXIgdG8gcmVhZC4NCg0K SWYgeW91IGFyZSB1bnN1cmUgeW91ciBwYXRjaCBpcyBjb3JyZWN0LCBwbGVhc2UgdmVyaWZ5 IHRoZSBjb3JyZWN0bmVzcw0KYmVmb3JlIHNlbmRpbmcgaXQuDQoNCg0KSnVlcmdlbg0K --------------Nc2aeEGlKWS5cu0pOGONczrT Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Nc2aeEGlKWS5cu0pOGONczrT-- --------------aEejvVXcvRh3zvA1PUMyYEgB-- --------------01t2a227HP0z0isoz31TbdIv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP0hRwFAwAAAAAACgkQsN6d1ii/Ey+J MQf/REaZWsbBxqfUfWrsv5p352OpZ30WPmQLE0zlyV2JQRAtiv0Wx18En8w2yPvjexkGD6PGjMoH jdIBmRxHl6erwOgVXvi39/AR0HP7EewwQhdY22so4BHELHeDNiOTB6mUM7AojUB0D97wTnMmAevw 3Bbh0mMs3CtFf9QOIiQk7StDoo+eTp6p3ufD0OKSPjB/vkBKv0QTZnGY2gvAolLxeblSgvtQvsjf /Ii478peLPJDnNLiT1CqDQMsGlG6o2+ChiJ8ZYBGT+71W0oLjF3OdARNDSY3dKo8nvt0MUVPLTYR Cwie64GZMwrHIk2Gbc9GmM9wYaIwXBUAuqU9kUr00g== =PQf+ -----END PGP SIGNATURE----- --------------01t2a227HP0z0isoz31TbdIv-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 08:48:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 08:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498623.769506 (Exim 4.92) (envelope-from ) id 1pUOKH-0002Kd-FX; Tue, 21 Feb 2023 08:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498623.769506; Tue, 21 Feb 2023 08:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOKH-0002KW-Ce; Tue, 21 Feb 2023 08:48:41 +0000 Received: by outflank-mailman (input) for mailman id 498623; Tue, 21 Feb 2023 08:48:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOKF-0002KI-RA for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 08:48:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2070.outbound.protection.outlook.com [40.107.7.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88349d90-b1c4-11ed-93b5-47a8fe42b414; Tue, 21 Feb 2023 09:48:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7499.eurprd04.prod.outlook.com (2603:10a6:10:203::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Tue, 21 Feb 2023 08:48:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 08:48:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88349d90-b1c4-11ed-93b5-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLjZJVtMxc6JpyRtkOYIFzob9C+Vgd8s8ekWWosrLdG8DDIrsb+rvxsVrr8DTWsgojVUO/UqXp0sSfq+z0STTAe3Fl2aWJNT4Qegu+n7DWnJnOMQa2pztGjngPcxcvUGIE/tV4EJ5If26mhFABCeAGbJl/YMfXvDOMJY6VarhevMK+agkgKN1l9yCEuyiiwYFjB1u1mRL4hf9bJQUflvaKt7w4ttk41rF8up4Gb2Xl8hTNGKgObfp4tmu2EEoSRJ/mPq4SURWSP9imvWLo/dITbKFxlJr5wR0ZWSGvX+owRPGqRNPScKwUfcc+tTkIBYpZMsbUkzbcAi5b9FesmBTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WzS8JE7Jn0QUDZ/qH5Ic23ZH09b9Uv6EWBtNUT05FZ4=; b=Z2MWfnmIHP0GU2Trm3L5gYzyLzB/DDYCrRr/EGMAL0ClUCvRjHz93FyQbga9ZPHBumY1z50CXYbzJXmnTq5+Q2RHMYNa4HtVL9RUtlK4F3G3dx48U+4+ZrMgxD7i53NXZgBHjFTTmdcNe7MHLlwuof1weH/2mfd5b5yAeDlzzw/XT+u5N+chEOngzGYaflCpyerV6sqsXlbz4MHSKLlbdHy90XWN+26CRjHBF36nqDLlPdjOcGamFKXIZmKrEjPnFcgZT109KGIuwQfSHv/Ch98sMne+8NMzJkciqkg/BzlS796WKdg6Bosc2D+0TvlcKKRgD14g2AohnVpBWyLqhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WzS8JE7Jn0QUDZ/qH5Ic23ZH09b9Uv6EWBtNUT05FZ4=; b=wTkvjwkctA21AYYQwvFMFZJAKUx+ieoGKHlvyz/8pirI3FA/+ZT+q+VgmilqobRuFu9naXjjoTTnATYzVH1/8qX5HCMM38Bom/p3v0wqg4nuLEZcU9OZg3+g3OfObC/vP1buwRaGCF5ExnQg2+7q6j5kpqeH3yDQ4fw87NVr+9wzdE4j9u74LSCAqkUipLqn9gmVwC3zNtCqqnjLn/uNuLp/MLRYOMR17gcPDiCTzNIl4w3xeI00ysY6xsUw6LeO812lM8aQuzgYorI5D45KIWDrMxLdD50egZDEUT56U/WdD5NsrkehS2WDsgBaS6vQ33rPxDYfnT1Ai/eVox0U3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 09:48:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH v2 1/2] xen/memory : Add a stats_table resource type Content-Language: en-US To: Matias Ezequiel Vara Larsen Cc: Matias Ezequiel Vara Larsen , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org References: <20230216150734.GB2137216@horizon> <20230220165144.GA2653336@horizon> From: Jan Beulich In-Reply-To: <20230220165144.GA2653336@horizon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7499:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cba2ac6-6928-411d-aa5e-08db13e85b08 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SyM/PS6HS0Ci6+P3I4wFHZJNm855jTNY5NMZbfq1nRCPARAT0/pd1la9OJxm3QsA6nQ629uKMoIuATsQGzNTX9P0JflrgryuC6vRxptUKUnCzxPKpnue9E8BD3djl0CX+P5sjXWc//htj/P44x4TCFsiALKxMJuMztjiJh9ONlk+gGPfoPmz8bSPRpOfpV/v7Y85lfK+a3kcpQ9QyMl1Qx9awMfpIG/YsAN7PYXpZC73xx+96VZOG1ngmWfBQDyX2SInwLH4AMNawCiVpVWfLFqusRKIIWkKMmzGLz6q+iBO57xFoBx5CwHlpJ0t71b4An9XQF/Axe5M71mpA6PdTXO08vU67HZ5PovQOvFZrKCBDvTIEMUiS0/otqHn3petCMLGSaJMINhM0WvkGnuMj5gE0HwY4Vn3JeNFDMfIaZL64Q4/OcIwadliRQqnK6x3RaK67bzAClMiYhWy7Ji4N7ccwFphfiRDoCgDMWeGvqUmxflzt05zfY3OiJW9pG0NqcEO8d8hyrbWWn32PbNsGeLH5sub15laJd1DIYgo5UaXatHwn+9Xqapgk492tMaoxj067vODaxJ3Ooj0b4gwFpqNhZB4r9UR+7V6hoXVG4wu43z8gRIqpIdtjVwtBdZ/W2fdO9tuMCyMpFny1gNtLmrfNIA8TlViuzG/0k1YV2gOnLZLTVzbQKKwS0QSPVtpZBcYlvxXk1na9c275EM3WDkoCMEc8n+Q02hPKQQQhu4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(2616005)(38100700002)(41300700001)(6666004)(54906003)(186003)(26005)(31686004)(6486002)(86362001)(31696002)(5660300002)(316002)(478600001)(6506007)(53546011)(6512007)(83380400001)(66476007)(36756003)(8936002)(4326008)(6916009)(66946007)(2906002)(8676002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1A4OTZhSjhoVEdlaDZnV3IrMllUb0FoRFJUVVAyeEV5UVBDYitmU2VzVXky?= =?utf-8?B?WUFBN2h3aloydnpma0NrYnJMRVFrQmtMVWo2WDRsRi9QTjFYS2pqbXlhOVo0?= =?utf-8?B?OExRa2ZWTFYweldManFFT252ZE5maGRTUFhjRFFINjZXZ3VlVFM2c1k1ZHg5?= =?utf-8?B?dGZIYW5oTDBtWmp0eXdwUXl1Mm5SYnBoc2lOc1huNkZMQjViNmVBSzRZRFh5?= =?utf-8?B?dWM1cXJZZCtQeFRzQzVNUXhqMnNIV214YVMxRXpzQXJSdDBpbXRLYkxXaVpq?= =?utf-8?B?aFNucGdiM05MQTVNeVJGaFovOW9rTksyVHczaHZndG5aRVZQQlJjMGtSeEI1?= =?utf-8?B?YXVIY01Rb1dNdXlsSjVlaE9HS2w3a3ZSRmRCMjhNWVl1QTFVcUZPczI5ZDVY?= =?utf-8?B?OENHdTRtcnFZZEduWDc1U1VBMExsRXMzckJiTUxRelJici95WjBFalZIYlM0?= =?utf-8?B?eWxLT253aVgyVnhPVGx2d0lkd3ZocjMxQ2N5d3U0M1hXZHVrcWJkUUN2dFgx?= =?utf-8?B?eEU0cTFaVktPbHhiVFJHUmJQS21KWmcrUy9mS08raG8vcWpvU2o4andnSWt5?= =?utf-8?B?QXJYazJ3aUNyRUJ4eWdETFNadmtrRENTUUhTelc2NnlKaHBCVHg3SHpxa3Ev?= =?utf-8?B?UWdUZmFCR3hIcUdiOUdYRGFqNlBGeENWVVhqZVBsZVU2OFBNbUpibUJVbTl4?= =?utf-8?B?d0JzNUlMaUxHVGRaT3g0WC9IeEZFbzdsb2p5ajlsejBTVmtzbG8wVlVTZDdj?= =?utf-8?B?S1RuU0FOMTBiRWlmdEV3ek00WUdRY1VueldoeXkrRnI2VHJZclJkcndoVHFN?= =?utf-8?B?cUZsd01RNS82Z3ZzZVUwTkJobGhzR1JtclJhZktoVlNTRGVMME5oSGJEWTUv?= =?utf-8?B?dUJhMitncFdtNGZCQ3N2b3JSVHVXSGl1MjI3TGt5YmY3VDJPK0xGVTg3a3I2?= =?utf-8?B?TmlEV1dQZVJGelRmQlNkVitaVWNvQmdmejQ4N1NUUVoxbGhuclRmaUkvTVE5?= =?utf-8?B?bnJLdEpZaFA0andXVDF5YUhWRWVvUUU4RHJ4TW92T1VSOGMvL2xLKzFNd3R3?= =?utf-8?B?TVZGbzdYNDJRaFNycHV2a1EvQU1mM0xFTkFibURZZ3FURVN1Vk5pL3NaVGJ4?= =?utf-8?B?WWJ0M1lNUjFmM0xvajBjdjliTm9TeFcyZU1pWVJiMGw0T1JRcUt6MloxNTVT?= =?utf-8?B?YUMyaUVhK05EUFFaMmp4Z1gya1ZXSWE5dFBLV21HNGY4UTJXWDZGNm4vR0Ja?= =?utf-8?B?cmZ6SW42NkZwZ3lRaWwyaFB2VDVOR0JBVkoxWUJ3Z3ROa0wrNVNlcXZLQzEx?= =?utf-8?B?ME5sTk13cG0vTG45TmQvcUJrZm0vT1MzVktHakFyNkRIeTRGN015ZmNhejhE?= =?utf-8?B?UnFjajhwQlRZd285Q1Q4YkcwWktPdHFVS2pVYVJxbmdYSzZOTnFrT1pIL2JG?= =?utf-8?B?YWZLeDdTNlE2QzNCSTl6NVNhOWNOMThraU40bVFzNDVrKy9qS3grVnEyS0I0?= =?utf-8?B?clF2Wm5EQlBPUG43SDQrYXpKUS8wZkw2RGJzYVBTRWk4ZTNFTE0zTlY5SXRY?= =?utf-8?B?czRxbC9BV0tzdC9mcGhRMkdEWDQ3dFBOcC9sYVhzVjR2dTNVODJpQVlaeHhN?= =?utf-8?B?NVk5dG1FTHlQMzNQWWlWTXpKcFRxZTFSbi9mRkdwb1FEL2F3WU9OZ3dpem5V?= =?utf-8?B?THNUQmhuSjFDVjRRa01sRkxMa2hualVnenZrZnFDd2J6QlAxWGp2cmNnRTlr?= =?utf-8?B?SHdDbG4zanRvb0p0ZWg1bXJQYmE1MW1qa3ZTMmNVNlhISUE5Z2llSlBzZ0Fs?= =?utf-8?B?dkJBazZ5UURmUExNRktaaEFzU2EzRzh2dlRtdkhaV0RSYnBkWW1EQU4yQUtT?= =?utf-8?B?cUZmYSt2d2JVTzUzK1E2OHJneU5Kc1BRM1VxQjhLYk12V1kxbm91bm5iYngv?= =?utf-8?B?cm95RzRSMHByRjZ1cHdXanpTUWhTa0Z0cm5HNW5KQkg1eVVqTi9nbVlQMko2?= =?utf-8?B?R3V5N3hjVDdwYTltSnV3d3kybU5uYUxKUThlL3gwbExMazJuQ1RSMDlBTGht?= =?utf-8?B?ZjY5TmVnSGQ2Qmt5QUE4dTV0ZEFLbncrYTNmeWhVSE1jUzlVVUdVTW5aclpq?= =?utf-8?Q?0RLULdkNJDObcROUb0+GZJbHX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cba2ac6-6928-411d-aa5e-08db13e85b08 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 08:48:08.5098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i7cz73V/xXf0/cbm+rwGDcDlukYTfim/vCDq97sW0pEgt1aBi2aV2XO0A0D9+m2c8urU0nrUD08PW6GtkrWGNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7499 On 20.02.2023 17:51, Matias Ezequiel Vara Larsen wrote: > On Thu, Feb 16, 2023 at 04:15:29PM +0100, Jan Beulich wrote: >> On 16.02.2023 16:07, Matias Ezequiel Vara Larsen wrote: >>> On Wed, Dec 14, 2022 at 08:29:53AM +0100, Jan Beulich wrote: >>>> On 07.10.2022 14:39, Matias Ezequiel Vara Larsen wrote: >>>>> @@ -287,6 +289,20 @@ static inline void vcpu_runstate_change( >>>>> } >>>>> >>>>> v->runstate.state = new_state; >>>>> + >>>>> + vcpustats_va = (shared_vcpustatspage_t*)d->vcpustats_page.va; >>>>> + if ( vcpustats_va ) >>>>> + { >>>>> + vcpustats_va->vcpu_info[v->vcpu_id].version = >>>>> + version_update_begin(vcpustats_va->vcpu_info[v->vcpu_id].version); >>>>> + smp_wmb(); >>>>> + memcpy(&vcpustats_va->vcpu_info[v->vcpu_id].runstate_running_time, >>>>> + &v->runstate.time[RUNSTATE_running], >>>>> + sizeof(v->runstate.time[RUNSTATE_running])); >>>>> + smp_wmb(); >>>>> + vcpustats_va->vcpu_info[v->vcpu_id].version = >>>>> + version_update_end(vcpustats_va->vcpu_info[v->vcpu_id].version); >>>>> + } >>>> >>>> A further aspect to consider here is cache line ping-pong. I think the >>>> per-vCPU elements of the array want to be big enough to not share a >>>> cache line. The interface being generic this presents some challenge >>>> in determining what the supposed size is to be. However, taking into >>>> account the extensibility question, maybe the route to take is to >>>> simply settle on a power-of-2 value somewhere between x86'es and Arm's >>>> cache line sizes and the pretty common page size of 4k, e.g. 512 bytes >>>> or 1k? >>>> >>> >>> I do not now how to address this. I was thinking to align each vcpu_stats >>> instance to a multiple of the cache-line. I would pick up the first multiple >>> that is bigger to the size of the vcpu_stats structure. For example, currently >>> the structure is 16 bytes so I would align each instance in a frame to 64 >>> bytes. Would it make sense? >> >> Well, 64 may be an option, but I gave higher numbers for a reason. One thing >> I don't know is what common cache line sizes are on Arm or e.g. RISC-V. > > Thanks. I found that structures that require cache-aligment are defined with > "__cacheline_aligned" that uses L1_CACHE_BYTES. For example, in x86, this > aligns to 128 bytes. What is the reason to use a higher value like 512 bytes or > 1k?. You cannot bake an x86 property (which may even change: at some point we may choose to drop the 128-byte special for the very few CPUs actually using such, when the majority uses 64-byte cache lines) into the public interface. You also don't want to make an aspect of the public interface arch-dependent when not really needed. My suggestion for a higher value was in the hope that we may never see a port to an architecture with cache lines wider than, say, 512 bytes. What exactly the value should be is of course up for discussion, but I think it wants to include some slack on top of what we currently support (arch-wise). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 09:15:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 09:15:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498640.769517 (Exim 4.92) (envelope-from ) id 1pUOjj-0006dn-K6; Tue, 21 Feb 2023 09:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498640.769517; Tue, 21 Feb 2023 09:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOjj-0006dg-HV; Tue, 21 Feb 2023 09:14:59 +0000 Received: by outflank-mailman (input) for mailman id 498640; Tue, 21 Feb 2023 09:14:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUOji-0006dX-4o for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 09:14:58 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34e0b8bb-b1c8-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 10:14:56 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34e0b8bb-b1c8-11ed-933d-83870f6b2ba8 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676970894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xQRPfdgwcRjmMWw+0c3Jqrn1sLC4pxLEI/ts5BFfWNs=; b=4lf3ncTbyGCsTdGUMTqu/8+wSbuNleK+TbpU3r1IdUq+q0A8dPmqfuMqgFUrgK+BVYs6jF GqyO2ZGmz7OeDLnw8JALhMHC3a0xUJOrh2Rq246Ucifk2KKegpYE662PTjWVdcXZrXhqj7 buf/aXZSZCks/cuLzH0p74hDqrEWtnrmgs0/dtxVUzrqSCE1npxYSP2PV8oK7Um2VJkh16 +xqbGFVrSNALd6q1fvQlYTKNae+b3TvpxnhIg1p0tY7+N75t/DRF5UeGtyXOC3tuW9b5BH oLGfKsgVpo5CsMbqxuk9B8gL6TuyVkCPUiQkwgH2k/UbjqU0AQL94Vtr3F+9Kw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676970894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xQRPfdgwcRjmMWw+0c3Jqrn1sLC4pxLEI/ts5BFfWNs=; b=EznI/8jSHUDF8pTcrVH0UpZYp+I9czzXdCCXp84xzi5hwNqJ6pSl8TemI6OPnMvmLMPuR6 9AI94MLXooTH4xCQ== To: Krister Johansen Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Juergen Gross , Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource In-Reply-To: <20230221055117.GA1934@templeofstupid.com> References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> <20230221055117.GA1934@templeofstupid.com> Date: Tue, 21 Feb 2023 10:14:54 +0100 Message-ID: <871qmjpegh.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain On Mon, Feb 20 2023 at 21:51, Krister Johansen wrote: > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: >> > static bool __init xen_tsc_safe_clocksource(void) >> > { >> > u32 eax, ebx. ecx, edx; >> > >> > /* Leaf 4, sub-leaf 0 (0x40000x03) */ >> > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); >> > >> > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; >> > } >> >> I'm all for simplifying. I'm happy to clean up that return to be more >> idiomatic. I was under the impression, perhaps mistaken, though, that >> the X86_FEATURE_CONSTANT_TSC, X86_FEATURE_NONSTOP_TSC, and >> check_tsc_unstable() checks were actually serving a purpose: to ensure >> that we don't rely on the tsc in environments where it's being emulated >> and the OS would be better served by using a PV clock. Specifically, >> kvmclock_init() makes a very similar set of checks that I also thought >> were load-bearing. > > Bah, what I meant to say was emulated, unstable, or otherwise unsuitable > for use as a clocksource. IOW, even if TSC_MODE_NEVER_EMULATE is > set, it's possible that a user is attempting a migration from a cpu > that's not invariant, and we'd still want to check for that case and > fall back to a PV clocksource, correct? Sure. But a life migration from a NEVER_EMULATE to a non-invariant host is a patently bad idea and has nothing to do with the __init function, which is gone at that point already. What I wanted to say: static bool __init xen_tsc_safe_clocksource(void) { ...... /* Leaf 4, sub-leaf 0 (0x40000x03) */ cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; } I didn't have the full context and was just looking at the condition. Now I checked the full context and I think that except for the if (check_tsc_unstable()) check everything else can go away unless you do not trust the hypervisor that it only sets the NEVER_EMULATE bit when CONSTANT and NONSTOP are set as well. But yeah, you might prefer to be paranoid. It's virt after all. Thanks, tglx From xen-devel-bounces@lists.xenproject.org Tue Feb 21 09:32:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 09:32:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498647.769528 (Exim 4.92) (envelope-from ) id 1pUP0t-000189-5R; Tue, 21 Feb 2023 09:32:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498647.769528; Tue, 21 Feb 2023 09:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUP0t-000182-18; Tue, 21 Feb 2023 09:32:43 +0000 Received: by outflank-mailman (input) for mailman id 498647; Tue, 21 Feb 2023 09:32:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUP0r-00017s-N6; Tue, 21 Feb 2023 09:32:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUP0r-0004nE-KZ; Tue, 21 Feb 2023 09:32:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUP0r-00032G-6q; Tue, 21 Feb 2023 09:32:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUP0r-0000GP-6P; Tue, 21 Feb 2023 09:32:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e+ObfBKUq06FGZIl8oRs0qOSwoqOS+/3B321smUrf0s=; b=irUXPrdlwG/U0Sr2/OdHNGicL3 GSdgIkVrIEPYngJVxi130vAXHhWmwEa3fBMk6vGXwv4sYXgbk/YXgBhbx1dJe62pjrhMLyf1JkIzL RNuWeg+7eKWYktLd1HevT642QAP0QzUvyYd9wvMZobt6DGbqpDWyy4D6AaGdLc8UKcqM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 177972: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac X-Osstest-Versions-That: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac From: osstest service owner Date: Tue, 21 Feb 2023 09:32:41 +0000 flight 177972 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/177972/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail like 177883 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177883 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177883 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177883 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177883 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177883 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177883 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 177883 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177883 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177883 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177883 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac baseline version: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac Last test of basis 177972 2023-02-21 01:54:03 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Feb 21 09:51:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 09:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498689.769560 (Exim 4.92) (envelope-from ) id 1pUPIH-00055y-0P; Tue, 21 Feb 2023 09:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498689.769560; Tue, 21 Feb 2023 09:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPIG-00055r-Tn; Tue, 21 Feb 2023 09:50:40 +0000 Received: by outflank-mailman (input) for mailman id 498689; Tue, 21 Feb 2023 09:50:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPIF-00055l-Bl for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 09:50:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1a::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31bf7d5d-b1cd-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 10:50:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8819.eurprd04.prod.outlook.com (2603:10a6:20b:42e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 09:50:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 09:50:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31bf7d5d-b1cd-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MWqMZoFDczvzwYRNvZRXmb635uv+5NQvrgmbAOknveB4l4WKTkJXBXGfUCUkqKcm91td3diLqAULF+FLI/5j/wyGS0XLhhsIvyH6WEZ80B2FfQ7h+smTPArkAvbPrhEUNxzFgyIsmVO0Rt3q9y7kHBKuYPZ27CYW8qMYTlabJ3A4QfOxvFMJOwn0ajAsAHXmkkSCjDlYPQDSJRg35hOTCzZJNTS2zIMOr+N2khItazRCKKS3wvJTxBbd1+y3GZO8wVAXcgSk3qDyv/jxls8uIfBzBZDUZeMBKQJ8U+WA6y6lkB4oBo1NSWNR3WI67hRlqAH/l1O29jguZ1juTiG3zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rg9JZTbZxVv7hSuO3g4tt46XZ2qFvoAKhZUvz3x4I+I=; b=B3kfz1rmwoUjdQEaMJNHagRYQsBb7gk0ctyNELUZTps4G4SgF/M0b19yZOAVU7SvPHi+hwkSCQq2Kk73FBoxnY0x58Ov7NueoQH03zlnZaG0xg9UE1gtaVedjDijJ9YYceq63KvZLfsD8nBcYUUSDoldL8eNtDsY5a7c80VC6YGK1NXXu86MHxigprKi49X7OlX+7dtbhoYzCVULKUAGOxlUY2UUFLmZMEy1D0QS+UEogDiPWU4WkDkT4ghXB36aFF7EOEsjK0xaLkCSRibPn/dxOCnquO626C4yhF4BguUeljUej/aUptE5BopXomWTvn6yfVz6S2jam0KOADP+5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rg9JZTbZxVv7hSuO3g4tt46XZ2qFvoAKhZUvz3x4I+I=; b=lzrRvTdBAx+LX4wQhtwb9tb0lgyF2YQdo9H48jgAOa9WoQyeYAq/XOGsI8tzscV/R3f1YlzprkWrLvKSXgDsEwlQvrdik7CZOBkszhNLHZYczf6G5QZFFdUkmk0mOK8Ev4DWOKxgDaYNVin7y4pf9yiJrlWbNXcPyFxfwvgr8Z2VmgLKUdWMITK+w1lyCVhyFQg/p/b4VsP3TiBWxFaqiPpdyJhqirWvAjB97aG43GDSAgGxwungS5VxENh8Aqej4fZVoDYCYlmQrhesVRcoNloxaUFCTauGDKgm4hHAljOltP6uZ6fqi+CxODUxwsk26Qr4ZaGxFVSLmQlPXZkA3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <67330fed-560d-0078-2c5e-0a71974f3dcc@suse.com> Date: Tue, 21 Feb 2023 10:50:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 08/10] xen: pci: remove pcidev_[un]lock[ed] calls Content-Language: en-US To: Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Paul Durrant , Kevin Tian , Stefano Stabellini References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-9-volodymyr_babchuk@epam.com> <875ybwylp6.fsf@epam.com> From: Jan Beulich In-Reply-To: <875ybwylp6.fsf@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8819:EE_ X-MS-Office365-Filtering-Correlation-Id: bf02f619-0f97-4843-d7e6-08db13f113bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1GnTjiqwqTxzpgf8stPgGMMlDeqymWFLEicMEAearX0NTXISbQoRXnx8a4vbwbnQgh1IhQOyO12XgpiiwJ6eZbQy/dRrVb/L137wPqTkRmqFcnSMWu6toPDDXtHxOXYrRRTZZ6gflnj5fUkSPmhThl0KUXGI83a4bJTp/LKbI0gbksXXamyEZqzdtCAJhkFm9drPdTS54XlHrN3LvjTclyPTsB6RFBaIBsAS3kDTobzFcSpYfpROxmXPrd09g9wt/suRqEmaM5YkXykIw9znA677GTkU6Y6iPWw7a33uowlN4XkKEkw9Ft/LrkgYAE+0fXsJACvGYApoZMxpdk3Uj4lMrnIgOkdgzHrUZ8H00BkkDnJvhloTNLfOS0EyRZWWArG8T3XqWIBwry4E06jwi2JUvAN5I1c18DFLF/nGyl2T9LMZI7yMIdcFLvU4dggmnRRdW/Ocoi9SBvj3CYouoOrBqzsEmb23nX257pN6kAgBTMc1pOJTg46O6QTl/zwqPmcQIylc7/0RrPmOS2r8SFUqYwiZx5E1uMHiloFRKfguIn4kPIA4vsF/df7bZOHcnF7+FZj9lR96vCbU+1RNgtQG4IRP0NxPxa5j/1+1399ZJMOm8AN8agujdu95ZbqUfnkBvKeePgD3WrAdtCgBTWNuM6aKQ1yvYauGQALcznQShQFStZKQns1LQIYRi8vdppx07cTZfsOtJKKzR+3KEyFHEf4DQJiV5DHom6E0JAI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199018)(66899018)(31686004)(36756003)(31696002)(86362001)(5660300002)(7416002)(41300700001)(2906002)(8936002)(38100700002)(83380400001)(478600001)(6916009)(66556008)(54906003)(66946007)(66476007)(8676002)(6486002)(6512007)(53546011)(186003)(26005)(4326008)(316002)(2616005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L09vaHBjN08wYWNMcjhhU3pESTZTME92eDlMLzRjZkRzajlpRmFaNlBtQXJi?= =?utf-8?B?ODNJL3kwdjRBVlgxM2tveGdBYzh1M0x4SVlQMnNxZ2dtMjg4UURpVURWWWE0?= =?utf-8?B?NUhPUmdJc2JTN3I1Y1N3cGF3TXJ6MHo0V2dHb1V2ZGpkUzh5ZXVHbFJpTzZq?= =?utf-8?B?ZlRUQytQcTBZbENFUGc5WjlOWG92VnpuZm1ZZmV3SktDUkNMeHBwa094T2x5?= =?utf-8?B?clc4ZEdZRm5nUjlpaUpmVklKR1JxeHU0UlNpb1c3azVtMXZsUm1sSDNVdXhK?= =?utf-8?B?eFpNTDExUG9hVXd1L2NrL0VlR09vclh2SDdmdE5zQ1d1aG9MS2pQYjdxSnly?= =?utf-8?B?SEdVR2Y1L3pKcTNIZUJLQmRYQnNoNGw2bEJLWFNDUTZHUFBaOGcwbkNBZFJO?= =?utf-8?B?ZlJvWW01R2NKcWZFYkxYOGpTM1loQzJrMnJNR29LYUwrSFlaNkJXVXk0Yi9m?= =?utf-8?B?SXQzMlhGTElzcDJ6WWRLeWNRWUtVSFU2emVqSkloZmpuVUR4V2dBWHVPMXlq?= =?utf-8?B?RVpLb3Vla1hzNGVmK0JEd0tJc1ZPdUtGcVkxNVFJMTFQWStML2dYVHNYWkZD?= =?utf-8?B?UDBOcTBvSXNLWlJLWkFrYS9RMlRWMzVSdFQrZHdlOTVOOTRqTC9CYUNxYXEx?= =?utf-8?B?eFQ4Umxta0pXUldWVkZkVCtyVjdTL1FUdWkwYkh5eWd2MzlDdWNRaGF1aE1F?= =?utf-8?B?S0FtT2NSVm5rRGROVWpnTnBaSFZ4ZGt1aWw0aEIrRE9pTU5KVllZV2hoNDBY?= =?utf-8?B?YzdhK0dRVmRDNDRhRjgvR2ppQ2JZZTRnRUx4U0lsQUU4d2VpVVQrQ1NQaFBK?= =?utf-8?B?eXVHOSt6UzZjN1FnRnExOUxqSlgrN09LYVlGenlYSHVncXNqSmp2Z2ZlcGhq?= =?utf-8?B?c2QrY3BEMFR6K2RYdUFCcm00Q042YkZFcVh2OHR4akJPUDJOTXEramNNRTdn?= =?utf-8?B?ZTdERlNYdndNVWtCT000WEQ4K2M0MU1Pa2RLMVdrb29UTWJnZTJrOGpGbE9k?= =?utf-8?B?MWNvZE45WUxpbkJObGZZdFZLemNnOTBxTGdPc3NmY3dzemZFeWRJT0tYR3pi?= =?utf-8?B?blNXazFZNFRQY3VEcFB3ZytNN1hCdFlVb1BqS0RBVGdYTTNidTdsbGFrNjFr?= =?utf-8?B?L2hEaThBMVFUZmcwZzVHYUFkZlRFZG9WeFVFaExiN01naXpSd2J1a3NseTQ2?= =?utf-8?B?R0VUNzVsVTBjRGdHalhidFRPWjNxZWlWV1RGVWhZVUE5NmZ1ZDN1eXppZ3Rt?= =?utf-8?B?T3V0SlRCUXVUTkQxaTNmTjAzOTBQbEZKZXAzbmZHb1RpTlJDR0xPT1hSemJU?= =?utf-8?B?amtsbjNZOWZYUTR0QjBZSWlhekhFRjFYYmlFRnJ4aW5BbjJJVmE0aWdza1k2?= =?utf-8?B?OTNHd1AwTmNrSnpwb0ZjOTcvN3dsdElmMVpuOTRJNW8zZEdaLzNEbGprMUxT?= =?utf-8?B?SG5SQnBLeTdEMGszanZmRVNZNU01TTBJTlFsblh2bWlEd09DWEdQeDdjM1Jz?= =?utf-8?B?L3doNzN6UGdvZld6UjVRVTlmVFp5YTJzalY0c0lYamtITTVTMVhIaGY0KzM1?= =?utf-8?B?bWVMNjQ5dVhLMTM5Tk5hdTR6WFI3L2pRYXhjNWhMcGlUOG4vbHcyM3lyUzNn?= =?utf-8?B?U0x0RWdaT0FvS0J6OFdaWmNwczB6VHU4UWpXVTZEaitmak02ZjZFdjliZWNM?= =?utf-8?B?Qkl6eEpDN2lzMlV0ald0azJtRHZuVmJiQ0pnODNtcDJHeG0wMXFackhCYkpa?= =?utf-8?B?UVhNdXAwSVhuOVFzcldmZFZySnJLdXpxSzFrWDZRVHJhdnc4RUl6c1ZVYjFv?= =?utf-8?B?Wmw5WnNBUzNWdzJicGdxd2JzWmt6UWw2SlRRTlFSYW9KZS9PdWxTSU5jZnNQ?= =?utf-8?B?cUx5L216QkRKN2dqTmxoYXltVjVQUHQrZ0JrdnVrSWdKYTNaaG1ndzJ6elVB?= =?utf-8?B?WDVtVGUxTWhvSTVVRzZha2U0TTdxNnBKVjFheGJ6MmpGWEZGWWVHNWlEeU96?= =?utf-8?B?enJ1UHQ3WXhLQnRUOGtuVzZCVEhZR0FNR2dhWmhlYUpEZlRGcjlFTTg2S3Ez?= =?utf-8?B?aTQxclN1MHBVWkhUc09wRHFGbGpVdkpwRTVLOUI4Q3R4QUp2SVcrQ1JvZU9P?= =?utf-8?Q?dfPFbJ+gdk9KrwTViuxwjdyzn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf02f619-0f97-4843-d7e6-08db13f113bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 09:50:34.3808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nV4A08RP51uTLkZJnziodEIBBNHcJfxt1bpZNvJhuOgpd/ZhzhCThnIJTDV+UQDuKQfHgEpOOdU+Px9SXjtjtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8819 On 21.02.2023 00:13, Volodymyr Babchuk wrote: > Stefano Stabellini writes: >> On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >>> As pci devices are refcounted now and all list that store them are >>> protected by separate locks, we can safely drop global pcidevs_lock. >>> >>> Signed-off-by: Volodymyr Babchuk >> >> Up until this patch this patch series introduces: >> - d->pdevs_lock to protect d->pdev_list >> - pci_seg->alldevs_lock to protect pci_seg->alldevs_list >> - iommu->ats_list_lock to protect iommu->ats_devices >> - pdev refcounting to detect a pdev in-use and when to free it >> - pdev->lock to protect pdev->msi_list >> >> They cover a lot of ground. Are they collectively covering everything >> pcidevs_lock() was protecting? > > Well, that is the question. Those patch are in RFC stage because I can't > fully answer your question. I tried my best to introduce proper locking, > but apparently missed couple of places, like > >> deassign_device is not protected by pcidevs_lock anymore. >> deassign_device accesses a number of pdev fields, including quarantine, >> phantom_stride and fault.count. >> >> deassign_device could run at the same time as assign_device who sets >> quarantine and other fields. >> > > I hope this is all, but problem is that PCI subsystem is old, large and > complex. Fo example, as I wrote earlier, there are places that are > protected with pcidevs_lock(), but do nothing with PCI. I just don't > know what to do with such places. I have a hope that x86 maintainers > would review my changes and give feedback on missed spots. At the risk of it sounding unfair, at least initially: While review may spot issues, you will want to keep in mind that none of the people who originally wrote that code are around anymore. And even if they were, it would be uncertain - just like for the x86 maintainers - that they would recall (if they were aware at some time in the first place) all the corner cases. Therefore I'm afraid that proving correctness and safety of the proposed transformations can only be done by properly auditing all involved code paths. Yet that's something that imo wants to already have been done by the time patches are submitted for review. Reviewers would then "merely" (hard enough perhaps) check the results of that audit. I might guess that this locking situation is one of the reasons why Andrew in particular thinks (afaik) that the IOMMU code we have would better be re-written almost from scratch. I assume it's clear to him (it certainly is to me) that this is something that could only be expected to happen in an ideal work: I see no-one taking on such an exercise. We already have too little bandwidth. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 09:51:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 09:51:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498694.769571 (Exim 4.92) (envelope-from ) id 1pUPIm-0005cf-Dh; Tue, 21 Feb 2023 09:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498694.769571; Tue, 21 Feb 2023 09:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPIm-0005cY-AW; Tue, 21 Feb 2023 09:51:12 +0000 Received: by outflank-mailman (input) for mailman id 498694; Tue, 21 Feb 2023 09:51:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPIl-00055b-SN for xen-devel@lists.xen.org; Tue, 21 Feb 2023 09:51:12 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2aa5f70d-b1cd-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 10:50:28 +0100 (CET) Received: by mail-pj1-x102d.google.com with SMTP id na9-20020a17090b4c0900b0023058bbd7b2so4114919pjb.0 for ; Tue, 21 Feb 2023 01:51:03 -0800 (PST) Received: from localhost ([122.172.83.155]) by smtp.gmail.com with ESMTPSA id 17-20020a170902c21100b00199190b00efsm9493493pll.97.2023.02.21.01.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 01:51:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aa5f70d-b1cd-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wNQkeraNsuw6hFISAboGasHi5jkq9Qw1lk2C7Y7QJNM=; b=Sp7J+0CTBva8aEj2O9RPa7/fe/vPPgO/x/0R35WMCIEt+K5/CuaIDpJV5pICjBM3i/ 7+YqI+uYKU28wB0J6rXEsxFspuixkueTtJC1QuHP618WlV+JcjMm7ok4BlQCOStrfpNM 2yQVECM/gqB9R4OI372Uh0Ob8q/K1DnWn1311m8zKpRNAwuAVkwMdZXA366q40fR2nt8 +kg02BiIzImPF1W3uJpLDlBacsl39TblpS4TdxtPbW5oVShvfF9GEySZukT2XuIVm+KG ppaGdIC0ARz6+iYjOoPQ3rYf6JzbmxSu+M/7nVry3YTqF5A1nug85vTy/hUml6ZvFuwm u/5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wNQkeraNsuw6hFISAboGasHi5jkq9Qw1lk2C7Y7QJNM=; b=K9YjHoc+WM16Zgg5848SXDmMov1LeSRlzR+4H0ajk58yC7qRjP9zgp+2OxQAOmhnm7 mAn/68+kLKjRAYtueGiSp9EoEQhEq/Qlugo5NL3KBPdZWiCrcMQo12ArICgCYLSdXPqa PUQixpf0SxliFOHGtGYApTijL4bLOv5Lb6AQltLM0JNYp382EoatFCiE7NKodvvoqxZ2 KrnGbcfFR4IR7G1Y1x8JxU8MO2a1Znp6ehNDoqfa5dg0GcReTRrsy+uzZaOh8BPI5F1N vKU9LTGL7gX5WXjb5uAhZX4VpOAOA22Z0lz2xiVTjWMnROy08L+gVPH9x9o7MhFkrgwc aedg== X-Gm-Message-State: AO0yUKUAY7Ve2/FsmENXpJ71wIeKIddp3fvQCmi8gtx5F/D3kJ9LanDs DWf8IdpTBJtQe2YzPiaUR5+nMQ== X-Google-Smtp-Source: AK7set/pSiw2S4PkO5YI37ejuDhSsbMg0prresPSYVtL1WK1e+9RTLesegPL247GZtqxm3Qr6U8vqw== X-Received: by 2002:a17:902:ee91:b0:19a:b302:5158 with SMTP id a17-20020a170902ee9100b0019ab3025158mr4053751pld.29.1676973062371; Tue, 21 Feb 2023 01:51:02 -0800 (PST) From: Viresh Kumar To: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" Cc: Viresh Kumar , Vincent Guittot , =?UTF-8?q?Alex=20Benn=C3=A9e?= , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: [RFC QEMU] docs: vhost-user: Add custom memory mapping support Date: Tue, 21 Feb 2023 15:20:41 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current model of memory mapping at the back-end works fine with Qemu, where a standard call to mmap() for the respective file descriptor, passed from front-end, is generally all we need to do before the front-end can start accessing the guest memory. There are other complex cases though, where we need more information at the backend and need to do more than just an mmap() call. For example, Xen, a type-1 hypervisor, currently supports memory mapping via two different methods, foreign-mapping (via /dev/privcmd) and grant-dev (via /dev/gntdev). In both these cases, the back-end needs to call mmap() followed by an ioctl() (or vice-versa), and need to pass extra information via the ioctl(), like the Xen domain-id of the guest whose memory we are trying to map. Add a new protocol feature, 'VHOST_USER_PROTOCOL_F_CUSTOM_MMAP', which lets the back-end know about the additional memory mapping requirements. When this feature is negotiated, the front-end can send the 'VHOST_USER_CUSTOM_MMAP' message type to provide the additional information to the back-end. Signed-off-by: Viresh Kumar --- docs/interop/vhost-user.rst | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst index 3f18ab424eb0..f2b1d705593a 100644 --- a/docs/interop/vhost-user.rst +++ b/docs/interop/vhost-user.rst @@ -258,6 +258,23 @@ Inflight description :queue size: a 16-bit size of virtqueues +Custom mmap description +^^^^^^^^^^^^^^^^^^^^^^^ + ++-------+-------+ +| flags | value | ++-------+-------+ + +:flags: 64-bit bit field + +- Bit 0 is Xen foreign memory access flag - needs Xen foreign memory mapping. +- Bit 1 is Xen grant memory access flag - needs Xen grant memory mapping. + +:value: a 64-bit hypervisor specific value. + +- For Xen foreign or grant memory access, this is set with guest's xen domain + id. + C structure ----------- @@ -867,6 +884,7 @@ Protocol features #define VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS 14 #define VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS 15 #define VHOST_USER_PROTOCOL_F_STATUS 16 + #define VHOST_USER_PROTOCOL_F_CUSTOM_MMAP 17 Front-end message types ----------------------- @@ -1422,6 +1440,20 @@ Front-end message types query the back-end for its device status as defined in the Virtio specification. +``VHOST_USER_CUSTOM_MMAP`` + :id: 41 + :equivalent ioctl: N/A + :request payload: Custom mmap description + :reply payload: N/A + + When the ``VHOST_USER_PROTOCOL_F_CUSTOM_MMAP`` protocol feature has been + successfully negotiated, this message is submitted by the front-end to + notify the back-end of the special memory mapping requirements, that the + back-end needs to take care of, while mapping any memory regions sent + over by the front-end. The front-end must send this message before + any memory-regions are sent to the back-end via ``VHOST_USER_SET_MEM_TABLE`` + or ``VHOST_USER_ADD_MEM_REG`` message types. + Back-end message types ---------------------- -- 2.31.1.272.g89b43f80a514 From xen-devel-bounces@lists.xenproject.org Tue Feb 21 09:55:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 09:55:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498703.769581 (Exim 4.92) (envelope-from ) id 1pUPMx-0006L2-UU; Tue, 21 Feb 2023 09:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498703.769581; Tue, 21 Feb 2023 09:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPMx-0006Kv-RW; Tue, 21 Feb 2023 09:55:31 +0000 Received: by outflank-mailman (input) for mailman id 498703; Tue, 21 Feb 2023 09:55:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPMw-0006Kp-UY for xen-devel@lists.xen.org; Tue, 21 Feb 2023 09:55:31 +0000 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [2607:f8b0:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df12bfdc-b1cd-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 10:55:30 +0100 (CET) Received: by mail-pf1-x436.google.com with SMTP id fb30so1975621pfb.13 for ; Tue, 21 Feb 2023 01:55:29 -0800 (PST) Received: from localhost ([122.172.83.155]) by smtp.gmail.com with ESMTPSA id k2-20020aa78202000000b005ceb048cfb8sm934520pfi.73.2023.02.21.01.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 01:55:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df12bfdc-b1cd-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FbN7Vg+7W6EgBT1eXd4AMAQsGFDlaH/uiamyNunM1dk=; b=AL9LWHYNvJcon5st9kK94O+cD85JePQmSo9uWkb2kCOF1O5QQhgU6oOm2L0+K6PByv agHELSdTi7Qds8Rmd5dPjRJGAlSnWlYwZgjhrU7oljt0G5y1S0x8PhOf7ikgPv8RIltT T/D+K7FsC1JB2vM0+YXUgib2YgO01189WWkhJ1bbZg+dvyj8OWz5gExJTAFLOq7d9Lxg 078nv+J/KOqxMcKlmJD1GKSk5YZft4WAGX271yqd/gnt2zg38KtJP/HQ6uEySxHcSb+e sxAUyyaS3gqT2o+jbKJuzV1DQq4kVYpYYXnHb0phoYQnJV/UsHlJwcYYlKHMcJnqnDID kILA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FbN7Vg+7W6EgBT1eXd4AMAQsGFDlaH/uiamyNunM1dk=; b=CFfZflSTwIjoGGinNPmuPu1Ww/L/bh+aU3UI+wAa5FgY/8OR8zhua/HKCe9Z+LWywp 9WTjY1zOqt69rZQcMh6PfkWXlGzl/r9aJZGa23owWDNO3IaMWIHpQn06HL7hMIPgPbfM m3luUzYoKRdWH7ti/5iB8sSIUwwTWGe01Ma8FTUj3Kcam6BV07nLH7RlA+ybXopUa9jL eE0pxg8mWEfdnEEE3PvE0ydCK0q8UxAAPt6v86XQRmVqBJa+7my8aphuzQo6fvltuDWW JsFCbN2g4OTKCwcZA6fUmh+fFTZuLxrg4scoRRxof4vpWzoo1YD3A56c4g+gFphweEVn gXkg== X-Gm-Message-State: AO0yUKUSB0lKzRSL1wDbBOllc1b2Yc4DTIjw/9dj2SXH7wHiC33Quw8k LRyFGlag+WTcH/yy8yjt7WRNyw== X-Google-Smtp-Source: AK7set/Te35KUHmo8g3DhdaslU3UfjWgXRygNvBZcfY83tXFrb+j6VN9K8IqISE80+tm9xCOWe+63g== X-Received: by 2002:aa7:9537:0:b0:5a8:b958:e348 with SMTP id c23-20020aa79537000000b005a8b958e348mr3978595pfp.28.1676973328156; Tue, 21 Feb 2023 01:55:28 -0800 (PST) Date: Tue, 21 Feb 2023 15:25:25 +0530 From: Viresh Kumar To: Juergen Gross Cc: Oleksandr Tyshchenko , Andrew Cooper , Stratos Mailing List , Alex =?utf-8?Q?Benn=C3=A9e?= , Mathieu Poirier , Vincent Guittot , xen-devel@lists.xen.org Subject: Re: [Discussion] Xen grants and access permissions Message-ID: <20230221095525.7ty4ctgrpo2ceulb@vireshk-i7> References: <20230216111325.tprjr7rdr52iqvmm@vireshk-i7> <5d945b2d-048a-fc66-023c-377f494b477b@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 20-02-23, 07:13, Juergen Gross wrote: > There are no permission flags in Xen PV device protocols either. The kind of a > mapping (RO or RW) in the backend is selected via the I/O operation: in case it > is a write type operation (guest writing data to a device), the related grants > are mapper as RO in the backend, in all other cases they are mapped as RW. > > The same applies to granted pages for virtio: the frontend side will grant the > page as RO in case the I/O operation is flagged as "DMA_TO_DEVICE", and as RW > in all other cases. The backend should always know, which direction the data is > flowing, so it should be able to do the mapping with the correct access mode. Right, so the back-end actually knows the permission details, but it is getting lost while we do some vhost-user operations. Anyway, I have taken this in a different direction now and suggested a change to vhost-user protocol itself. That lets the back-end know that it is actually running on Xen and then it can do the mapping itself instead of asking the front-end, which doesn't make us loose the permission details. This also lets us write the backends in hypervisor agnostic way, hypervisor specific stuff is handled in vhost-user protocol's implementation now. https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg05946.html -- viresh From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:08:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:08:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498714.769592 (Exim 4.92) (envelope-from ) id 1pUPZ3-0008Bp-2L; Tue, 21 Feb 2023 10:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498714.769592; Tue, 21 Feb 2023 10:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPZ2-0008Bi-Vw; Tue, 21 Feb 2023 10:08:00 +0000 Received: by outflank-mailman (input) for mailman id 498714; Tue, 21 Feb 2023 10:08:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPZ2-0008Bc-2K for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:08:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7d00::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d86395f-b1cf-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 11:07:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7878.eurprd04.prod.outlook.com (2603:10a6:20b:2af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:07:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:07:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d86395f-b1cf-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8RIi7JfA1peri8p93Vyez55b18PtZQO9J4P32gz0JZDiuuo8BLi32TMv93hXk13xvnvG9KfgimIXEvolp3ltIq4hUSz0YhYY3G7vp9Z2wd/Ww1er67O6oZfopgnCj0vjDKR4753TSv5vy2nuN/R1Zg39DzRvqqE9Rnl2WrYv7YsiMOs0LtoBimJRjA6eHFTnyXkVvDFKqaXMCQVr/dm9sAu0xgcJwzg3a9A3T5j+cBAh5OYL5QtNhf2McSvhWY6hWuXFjozRgQXfh8RbStiTjjHEVjjgzwB3Z7wRVgeJoOf/BCKJSbedWdAkVGHE4pLsgga7ZO/tiTG+f6mYjQQGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5nwxMrqXsXkvIK31EmztkiosJrZKAmAtMMBg0ncVPNw=; b=a279ZVspaAr4sQ/qoIpbd/1NB5BuLOoLdpPBfRcSz2Y+0oc6RW2qg1aPdG+brNmcGl3HOWZHOPBEacNXqJmoDlZ9qOsaiNtSPVWh8ViNEMiKCwxmlX4LZ+TSSTHcQM59xfdGkmhr00+GusASWp9kk4rjPlBiTFmTs+sKtW+n5pzK93pmyR0aUSZodFRrsOK110Fy8auhoCj3KIi5vb87xqhOuFB9Ca/8Xi8xIF64YW1RCf1H5ZGNJ3Zko5idtJd0GJp9rIsrnpf0vgJKoimV6xIjEkkP+cY2LXJjmOt9Danrb5FPo7HxRWNLvGJR1DefhBTLXCp6UPTeHYP2wPHakA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5nwxMrqXsXkvIK31EmztkiosJrZKAmAtMMBg0ncVPNw=; b=aeiaeJaexOylhghFV/PWI4mUwM2t5Yh3MVvsJE07zn3kmF+cYX6vinCxXPwj2gPK/cQP0GIrhu7zl1mbUVysbJ9cb/oHoca7DC7beRAUEyEVcMugXnj+4Rk6/a4Cy8TmwK0qmyKvh0/NTxpUaF4C6cy49GXuUO26lwHjbf3iR8uLKs/1OoFYJVylcC5FMp6HkGfUcsqnPriJ64CJvFr9PMOX+coxtzfp0ykYaZC6vU8ikGJVvZwpQ9VaFpGn7lW+iRBtM47BSQ0LGCPS9lxjzStHMQldhkkbUl2if/KmyH1ayCGX1qXqSpgfQu5naFQvTFbEzB/T4MxqrF3otH16vw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8c4aa332-07ee-e91a-50f1-ced9e36db2a1@suse.com> Date: Tue, 21 Feb 2023 11:07:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org References: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7878:EE_ X-MS-Office365-Filtering-Correlation-Id: b1584505-8765-4d86-e4e6-08db13f38121 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LhAX3haEdkyGf3s9OSMor4lw0vZoN2ylwkqQu73uCmtzShy39jJlsFtTmfbx5KmUxtMU8pZ3v0nuduxDJAjjkWqkEidLi/XoTPGu05CXZlMWo7fqNgch7MdScqofnMkGq8Vjd8xVKVkVbCux92RQI4UpzhdjTeWOkuKohATxYw3P9KbmChUHHlgCmpyR7rVwLEcv5gMp65MQDYrAD091ZHhUSpGtUK60rkWKnOL90VBxFVr+71+7s2MVhSOU8SKEtZdi1Nj2ackS4nVz0ZpdVLtloKA6To/Y7JOnBQKN4zWl9+0K7auS6sE/6V8MpidJFQAO7cCX92fWfnowBtr4tCcFwdOXO0nQClQ5h8qMRC0SS1qsHn6YsZEuAm7u4W3l96KxRVTR07I4g3dbtePWWofuz7J06BOY+iP5aPu1FdvFZhxR5jqC9NQ0gcYuoQQ0xBRILhZPk3SG817S4TX0agZMMi25HIcAqrCoKjira6aC9lkR5KSejWKimlp/lObM2cae+aJAVbWORMfAuYRVwnb3FSH3pxTtgkRfOVnPlX9LQCUhKkTjRGzJAw9LvZZwc6IOrSXh2OtCJY7QYOoV2ub5OdDa0447Kh4H95cLRpXYPMoNLdBZYjTakcMbhrpcUhkkfD0PZegw4OIPF42QoNdPWl2fg0/36CkTtCadwfdKdE76Bup9QwStDQWbrV9ykWEQBU+OzTXBLiPd7OUAArZ8lVPsY7KxLSDclXspIUc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199018)(38100700002)(83380400001)(31696002)(86362001)(36756003)(2906002)(8936002)(41300700001)(5660300002)(7416002)(4744005)(6512007)(316002)(53546011)(26005)(186003)(6506007)(2616005)(4326008)(6916009)(66476007)(66556008)(66946007)(6486002)(54906003)(8676002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHNqNkJhZnN5ZWpTQ1NsU29TVVFjSkR3K2ppbTVwVXk5UlZjSFI1cWYxVFhh?= =?utf-8?B?WkJlanhWUHR1T0pPdHVUaTE2dkhZcEdjUUhVb1V6cHhlQnhrYXFVVzNxS2RP?= =?utf-8?B?Y01FV0l6TUZzc1FrZ2kwQVRkL2hoVEhLazBOR01iclU0d1dFNk1sazV5YWtv?= =?utf-8?B?UHJsK24vcGdGRmlUZFJ6Sk9hTllMbmRveVRBRU1kdWRBQis0cWpZVmdOYWFK?= =?utf-8?B?OUJWVWdkemt0QTJ6TnJWaENkN2l3UDFPK1VkYjg0YmwrUnl2eGZ2MkdROGZ5?= =?utf-8?B?VWNFN1ZrclhmamNXSkphc1R5bXZpZnpPUm5qV1lnSVUrNFdwd3RFRFNYTzlV?= =?utf-8?B?SU1YQnVmbGJyU3E4QXoxRUs4MVo3NkFqb2p1WTh5eFlzS2FnODdLWFpmVU5O?= =?utf-8?B?dktDcGEySWdwejl2K1NUV0JSazMxdkpxYU1tY3RzWTJsa1JodUxzTVdUcE1E?= =?utf-8?B?cXZZYVZkczQ2YmZXenVaNDlsUEdzdFdmdGg0SzI3ajVIT3d3V3A1Y0F2WUtG?= =?utf-8?B?NlNOaENqd2tCVHlvWmFMdkErbHFmSkpuUm1YcU51dnlwWnlUdDJBQlQ0ay9y?= =?utf-8?B?SXZEZDFhYS9aeXZRa0V3Y1g0aWRKL3A0VnM5SUkwcWJQNHo1QVBEZ3JZaEtl?= =?utf-8?B?YnZVRFFDTmdhNG5QSmpmY3dUQWNuK21Ba0h1NDI3SHROK0xZNFNMR2djdUtr?= =?utf-8?B?QmZDVHk5UmVWN3MvdEZUbVJHTHZ1cURzbHpIdzBJN3hpOC9wYU1BTVdNV2g0?= =?utf-8?B?bkxXb3BiQXhiWmZuZzh6ZUg3Sk5jSStMU0V3SkxxZEY0M3plNnFQRGVQTSs5?= =?utf-8?B?WHFmL0ZFNE8wM1k4MWxsT3JScjNSRUt5Z05LZWRXVnNBSlZORVcyWnNjUnhj?= =?utf-8?B?NXg0WDUvdlJSbFFKV2ZsUStCOGpiM25EWWFUOWhWaks5RnRTVVhVZjdWYW9i?= =?utf-8?B?dFFqeWdkUEY1UjJkU2NRSkh3K3ZhbjVaTjZrRFQzVDBDSEgxOUpEeG82WTRz?= =?utf-8?B?VVNqbDVnM1luS3FtNlVPTkJZYm1hNXVzcWtTNFRYS3owb0lhdXZVd0FzSzdj?= =?utf-8?B?dmxOamxwaWNlcmtIczJsMS9kL1h6RWsrNldIajV6eFNxYUlpNEJVczFNRC9q?= =?utf-8?B?SlVTclpWdGJTd0laVHVSUEthdEtRSkNockRMYXJpNHBNNUdtc3JwUC9LRlRs?= =?utf-8?B?VXdYOTNQd1FIVGcraUJDVXFRN3lucVdVaFBqOERLc1JPZ3ByQzFoTzFOampU?= =?utf-8?B?ZG45QzZTdDFGMGxvTG5vWkxGQW1QN0RjR25RSFdWS0RQclQ2dm5NUElpRW9X?= =?utf-8?B?cUxFTE5uMDFNVlI0K3VmSDJCTXNZaDRqalRtZURkb2ZlT2QweEMyQ0JmT0Y1?= =?utf-8?B?K2ZjMFRxRmxVMlZBZVd5M1o4bHY5SEsrRkZBMk1OZkV2amhwRWJiZjBVSDhn?= =?utf-8?B?Zk5rNWQyOENaelB6OWMrR2dKcWxQNVFObHkwbk0wbldWcXM4S3JTT1YwWStq?= =?utf-8?B?WW1VQUpaM01ZZSs2dDg2eVVJN1puVmMreCthVkJSY2xRQW0rYVdIWlJsUk82?= =?utf-8?B?T05DeW5nNGpaRDdhRjhJNGFGUWEybkN5MDdYNGtlc2tpZ2YzTHNPNzJpK3lt?= =?utf-8?B?UFdIa0s2S0ZGMUxUK2YxWGQzdjNpaGgzOSsvcGUxS1U0SThWN0dMUjc5S21N?= =?utf-8?B?MHpOVWJGeXo5cnlqMmVZaktkL2hGOC81M1V0ZVduUEFIaWR3KzZBZ2ZjcERa?= =?utf-8?B?YVpwNGMvWFBxZEl6cG1CZVlCZTZPZFRpMHNRaEFNY212K01rMThwWDlRb2V2?= =?utf-8?B?bmdKVkVUb1hvZWFZc09qKzNJM3ZvRThTTlp5UzJsTnBpZGZkL3NRZWZsZkVa?= =?utf-8?B?UUxjR1dFelhBSFVrbGxCd3d0QVViTVp0UzlESlhtSGg1Yk1yT0ljVy83aGM1?= =?utf-8?B?a1RsZmZsZnZRanFadkFMVG1ITUNpdDl4T0lUNTV1SkRsb0lNWDZ4QU1xV0JM?= =?utf-8?B?UXplRWZOR0YwaVhoRFJscWFEZnpyVXRxaXo2Rk9BV1hjdkFFR28yUThrc1U2?= =?utf-8?B?bjdJZHRmNkZxWE5jMGk5WVZMUGczVkx6cEsrbmEvUnVtbG5OK2RGMmw2MDl1?= =?utf-8?Q?LTyu7j6GANKKW70zkIjwNlNtZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1584505-8765-4d86-e4e6-08db13f38121 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:07:56.9551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B3JgCAzIn3SwfkMOS4ej8MBKFksUwxAQ6cfRRkcjgK4KMy+6jn0+jeCJzFo6wwA8bcwOGMqdvOzG9yRiS1+9KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7878 On 19.02.2023 03:46, Demi Marie Obenour wrote: > --- a/stubdom/configure > +++ b/stubdom/configure > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : > if test "x$extfiles" = "xy"; then : > ZLIB_URL=\$\(XEN_EXTFILES_URL\) > else > - ZLIB_URL="http://www.zlib.net" > + ZLIB_URL="https://www.zlib.net" > fi In v3 you said that this URL can't be used anymore for the version we're trying to fetch (which I can confirm). Leaving aside the question of why stubdom was never updated in that regard, what use is it to update URL (without even mentioning the aspect in the description) in such a case? (I haven't gone through any of the other URLs again, so there may well be more similar cases.) Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:32:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498721.769604 (Exim 4.92) (envelope-from ) id 1pUPw1-0003q1-1w; Tue, 21 Feb 2023 10:31:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498721.769604; Tue, 21 Feb 2023 10:31:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPw0-0003pu-Tf; Tue, 21 Feb 2023 10:31:44 +0000 Received: by outflank-mailman (input) for mailman id 498721; Tue, 21 Feb 2023 10:31:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPvz-0003po-Se for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:31:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20623.outbound.protection.outlook.com [2a01:111:f400:7d00::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edcaec45-b1d2-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 11:31:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7558.eurprd04.prod.outlook.com (2603:10a6:20b:23c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:31:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:31:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edcaec45-b1d2-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABTtAnAvxKTwaiEdd9MOZiETsPIUOzrbB614gAlTh9kLXcZnUmQ+en0FhWhSk45/ZtcK3X0p8/lxC98IkO3JLFzunGeu0u4Ol+3pD0jvA0vzx5NeuMPbXqNEkM7/+W47W+qrVinoKfUP+LA5+EhyirSQn7FLzajHcrNj9nMYvF9i1KjtlJH/EdXt8xRc7NjnSDQ0kxuI7Sb7QOPTw6sC4/SrDmno3MsoxMsoLlviutz6AQT5Ki52JskhvvGdD1PFmxFTItC5iHK/5FL919Z27e8ZuFz+PzEakfhqvqERovmlaryx0W8wH/FWV5ven+O1XKadsvjDi9XYYBPdmuq8AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBo8RCIw8/koyDM0t9V0MkNRvC5oq99mXXdBU9AHosc=; b=f1dy/saTMZ2yuk/UrwAvu7F0fzVnTzCpiBIvVSTW1a9iq61cCUZDt97lBangUqPBt5tR6BQWxoj9MVfjBqcFjEFh//KxlPAnEs9v2wgRmPInjft+4vllTyznWNZ3LFPjbP6+1nKi7mFc5QVE5EHr5KTnjuhF6y051By+AFUe/SB7IbIe93wf37K0Ys9Xhfpjjx/ZraP2oFbuyHIDLFKaQc35piVcogwEPbAPVElyA7qxoWqCxoSstb+aD9jlC1ZvpiLRS/v6D2t8EMIU3uo6rzu0ZaIe/9KL1FKRbNTpFdXsV18h4ZR1KlYR1nuD9FhxJHULVeXa85k8PGHnwJ3dDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RBo8RCIw8/koyDM0t9V0MkNRvC5oq99mXXdBU9AHosc=; b=0CD5P+kKK4FUY398UynrCOB7AOwtqQYDDatqXZBc1FSI6J6COYB+bC/PLwDMhx7HaljUARqb7td6/2//KHhRvPqvBek4HaROFNyiC2YGBYyUejRku7lWATLMASiG7U0X26VMLqtuUMVXSRy+W8d0E8eQRXetDSinbQn5iD4HIQ6yPSPzujCZV+AO9BjTuyTDDPp2+R7lhvDVr2PhVtafNvXZttpYoibOT4/EceMPCWfSyquaP9ypgSMuSxuBr8dnrqa7hPjkgJx1d7PTsi55yJCSmt1HKcwUhzEsdrDohDSrEcyqjKRjDnuPqS/Ks/eN0RQmSJ5SCxCesOboRIHn2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <04891259-ffde-a6ff-32a1-e3a84a7278ca@suse.com> Date: Tue, 21 Feb 2023 11:31:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217001914.762929-1-andrew.cooper3@citrix.com> <20230217122203.790737-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230217122203.790737-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7558:EE_ X-MS-Office365-Filtering-Correlation-Id: 27d0318e-7140-4012-9438-08db13f6d0b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mhzoZs1l8Y1HxC/0nJE1hbFWKCWrxlA1qtVX+ycHetfhsesAad2gw7jZTc2DigYC7TTArDN3l6llVABbIi4TvQTWuH+htwqlos/GA2H4TXrgOA8pMk1sa/VIumNrvONG1q+64XkMZLwAnTEBvwxLyR2UoPNCf/xkc4LfMTehuj2nTRCUugvmH7gJ1m9NJM4XsUKZWt+UlQOQvK9jT/5RfXM6FYTdHoomTNjQ+zF58jPGP0soJOzZBAKFRA9GpklsQfLobxglIHdaRyUiTfAbJ5NGE5sWTmbsIf+NcbRzp/n4TWiAK/76rERlpEqtvDF4yO4ZbXGtUjQk0Sg2aWM/omSKGRiKKE7dzqgp6YO9HHqkrPRrIcz61v7IU3vrco5kLXWfelqdlzNp5SuVIl4xooBPFU+gG/jYmunt10g3X5Pd3vy5WjKW5QieE8lTHZs8pqrHIfLa7dr6IW58zNKQY2S4FLi4fm/earg+L41SnWY7aCTacVdEuoHyH/FxhGSYbInAofdJ0dd+prjzZvg+NrSAm4U/rAdfyZR4ZdmryNVNYrSwoS3OMYfsrXQA6vp+lOzPtlvLzPJPWL643Eht09pDFKX+vSvTsC1bZWVIEt3E5LP93FK0gykubeLZAuXXp9SjVuCx+QeRYAG2x6YARLT7w+G5CxY+oXyy9HP4Q9d+AccBw9K+JbgvpOI8o9MFnUKG3AND9KoJI4Q93pqHtpGsiIWNDG3oAiVqjUZH9rM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199018)(31686004)(31696002)(86362001)(36756003)(41300700001)(5660300002)(2906002)(8936002)(38100700002)(83380400001)(478600001)(66476007)(8676002)(66946007)(6916009)(66556008)(54906003)(966005)(6486002)(186003)(26005)(53546011)(2616005)(6506007)(316002)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2lmMnUrRWZ5Q0w3YjhZZEdQeUhZc0JFSHNQeEU0bkMxdzh3cmR5TXlXRmtq?= =?utf-8?B?dElGcUxnbHNad3F4ZXlxMytSbjdzUzVWVjlURTgxdVo4UHNSZ1dYMEZ5TElO?= =?utf-8?B?OG9ONlAveFViRy9TZWlKVi9uQ25RT0FXQUtJTzE3UWh1YjNIU0FTTUpVbFJD?= =?utf-8?B?NVp1NmNVT29JNVNsbEc5S3dwSVY4UzdEcTB0WTVobXBUT1Z4Z2hyYjgvak05?= =?utf-8?B?Zm1SZzBMRFB0NjN5dGhLVnUySEdxdTdnV3dlLzFiZmFsWkFyWkg5OGhyUDNa?= =?utf-8?B?SEMrb1ErbS8yNXBlNzR2anhIVURBRmZKWFB0emVwbHpFeXU4dm9jZDMxN2Ix?= =?utf-8?B?ZWZ1bytUUGd1bnVsUStSUXJBUDFkOXByRW9YdXgwODhuSm5VbUZHTjNnSHcz?= =?utf-8?B?M0JQWklDREwzRE1SaGFJRk5laWMrWXB2Wlpuc2oyNTlPS3JMT1BsSEphNXZp?= =?utf-8?B?T1lqUWs5c3BreHN1OUg1Nm9qdURKZXNjQVJRNVBnUElKT3JSVEhhd2R1MlBh?= =?utf-8?B?QXk0enJaM3Z3YUxvWFlCc3N1emUzMWd5dnl5UGZUYlVIWTNLc1poY2ZMazJ0?= =?utf-8?B?TEZTTm9xTkFLNWRmcUg2bEdQMk45a3U3TDY2WHMyRXdEUmtHUU45YW1wUHdC?= =?utf-8?B?WXpsVk5UdGdMV1hCUlpXMEM2TFhLZ1dCNExocFM4S0EvWkNuRGtpZmxqK2ll?= =?utf-8?B?blgzUEJEeVFKNldqM2tYNWYyVnFMVDhTSkNxdy9VQWs2WEdyYmhPZ0szZ20y?= =?utf-8?B?SXQ3ODNpTG1RZW43Uk55NjBDRHRlaGMybWpjdWRNcmRBRFJ5T3hWbXBWMzRT?= =?utf-8?B?VjUzR0dXYlBNR3g1RHdzTGhiSDJXWE83WXpON3BkNWJzS2N4U2VhbFdDYlN6?= =?utf-8?B?NG9BZXcvQkIvVTFZSUQycGlMTDR6MmtHdnd3YWorelQyeHo5VTB6VFJDQTVk?= =?utf-8?B?eTVPb1N6ZHdvcVFxUmc0OUtJcVlGZDBaV2VQZGpCaFlrczB1VU9icVIyN2F2?= =?utf-8?B?VDlRWlFFV0xTbFJDbzIrYTJJNmkxMUhReTUyaEFRZVIxL1FwWE8rL3hXa1JJ?= =?utf-8?B?eGhLTU1RQ05TOGFOR0NqMXhvVURSS3NTa0dTZzNZclI4ZlY4TFpGeXU3Z1Bk?= =?utf-8?B?QVRLYVR6UGJsMjNZVjQ5blNkVVB6UjNDUnZIUFdYa1c2RW92eFI1aGdZeWFh?= =?utf-8?B?a293YU9EZDJxWDFJMXFNck5FejcvSlhKeDV4UkhWaGk5NC9DL2doQTErYU1J?= =?utf-8?B?SGduYmhFZFZrRndOWGVJT0RoRlZXdnZOaVlmWEVVUFlXRE4rbXhkQ0Nwd1h5?= =?utf-8?B?RzdwZjF3YzRmMzhoL2dUTXlWYk5leXVsem9CMXRpVHhza3NpVFphMDUzNzJM?= =?utf-8?B?TE9XM2NLVVRrV3dXdUd6aG51SHExNjAzc1R3ZjlpN1A4eUd3amQ2dW95ejIr?= =?utf-8?B?Ry9LdC9uemFkV0o2T3cxWC9PQ2pIOStEdXJmOWJzd2RibFBZNGJaWlhxUTVh?= =?utf-8?B?bGVhbTVOTFRKRDJnUWMvL3FVU3Z6V1loS3Z1ZWRHdTdBTkNOeHI0UjRYcHJI?= =?utf-8?B?dTRFL29RVm9UZEduU2d4MlYxQnVSWGRSbk1WdmdMcHEwbFkvWWpVS1ZueGd0?= =?utf-8?B?VzNhRXppYlQrUHdTQ0JFSHlXMTh4Q0Y2VW12MVB1Tmp3TmJJM3VSTjQ5WGU0?= =?utf-8?B?bkszdzBUVHpGa002aDYxbFhETG55UHZUcjdtenA2UG5YNUhDWGlkTUQ4b2Fh?= =?utf-8?B?UG5hZHdvaDM1cHRLdUp0N2crSXBIUlBnbGZhUEQrdHVSK0ZoWmFZTVlpL09s?= =?utf-8?B?Z25vODZncUtXZXM2QUxJRktYeHByL2xHWUIyRWw4b1pnQitMR0o2YzNXL0JM?= =?utf-8?B?Qk9Ndy9kMk01ckNJUWdlb0tVb2prWG4vN0R5WnNsa255clhBcHVjYktRSGJr?= =?utf-8?B?by91Uk0vN0tMM2FWZGs2cXE3d0FrQU0vZ29GZWFmWmVrcVkrRWRyb0F2TmVD?= =?utf-8?B?MXltKzUxOCtSRy9tTW9ScFVPUHg4MVhEaEVpVVZrd2pQVFgzOWgxWVErZWJZ?= =?utf-8?B?OFV6T2Q5VXJhQjZuZ1h2N21wYnJwaTBVUGd0UCt2ZFBCNzBwVHptUWd2ZDU0?= =?utf-8?Q?Oq6FKnmEKZOvBgwGNWLa1HnyE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27d0318e-7140-4012-9438-08db13f6d0b8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:31:39.9258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +5plRvFI5NGm10aH5bDT2/C94mjKDvNE3qFz7gwxjX/Eysgab5FXX6tvRnFsUaS8JjzU0fxE1VJi2R1hbXaQyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7558 On 17.02.2023 13:22, Andrew Cooper wrote: > https://github.com/llvm/llvm-project/issues/60792 > > It turns out that Clang-IAS does not expand \@ uniquely in a translaition > unit, and the XSA-426 change tickles this bug: > > :4:1: error: invalid symbol redefinition > .L1_fill_rsb_loop: > ^ > make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 > > Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mux %= in > too, which Clang does seem to expand properly. > > Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > v1 (vs RFC): > * Rename \foo to \x, reorder WRT \@ to avoid needing \() too. > > I originally tried a parameter named uniq but this found a different Clang-IAS > bug: > > In file included from arch/x86/asm-macros.c:3: > ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] > .L\@\uniq\()fill_rsb_loop: > ^ > > It appears that Clang is looking for unicode escapes before completing > parameter substitution. But the macro didn't originate from a context where a > unicode escape was even applicable to begin with. > > The consequence is that you can't use macro prameters beginning with a u. How nice. If really needed, I guess we could use -Wno-unicode on the assumption that we don't use anything that could legitimately trigger that warning. > --- a/xen/arch/x86/include/asm/spec_ctrl.h > +++ b/xen/arch/x86/include/asm/spec_ctrl.h > @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) > wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); > > /* (ab)use alternative_input() to specify clobbers. */ > - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, > + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_BUG_IBPB_NO_RET, > : "rax", "rcx"); > } > > @@ -172,7 +172,7 @@ static always_inline void spec_ctrl_enter_idle(struct cpu_info *info) > * > * (ab)use alternative_input() to specify clobbers. > */ > - alternative_input("", "DO_OVERWRITE_RSB", X86_FEATURE_SC_RSB_IDLE, > + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_FEATURE_SC_RSB_IDLE, > : "rax", "rcx"); > } Since inside the macro you retain the uses of \@, I'd find it desirable to keep gcc-generated code tidy by omitting the extra argument there. This could be done by introducing another C macro along the lines of: #ifdef __clang__ #define CLANG_UNIQUE(name) " " #name "=%=" #else #define CLANG_UNIQUE(name) #endif Besides the less confusing label names this would also have the benefit of providing a link at the use sites to what the issue is that is being worked around. Plus, once (if ever) fixed in Clang, we could then adjust the condition to just the affected versions. > --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h > +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h > @@ -117,11 +117,15 @@ > .L\@_done: > .endm > > -.macro DO_OVERWRITE_RSB tmp=rax > +.macro DO_OVERWRITE_RSB tmp=rax x= The "=" in "x=" isn't needed, is it? It looks a little confusing to me, raising the question "Why is this there?" Furthermore I think it would be good practice if macro parameters were comma-separated. I realize we don't have this anyway near consistent right now, but still. > /* > * Requires nothing > * Clobbers \tmp (%rax by default), %rcx > * > + * x= is an optional parameter to work around > + * https://github.com/llvm/llvm-project/issues/60792 where Clang-IAS doesn't > + * expand \@ uniquely, and is intended for muxing %= in too. With the above suggestion I'd see this comment move to next to that helper macro, with a link to there left here. Just to clarify: I'm not going to insist on any of the suggested adjustments, but personally I think they would be beneficial. If you are pretty certain the other way around, please let me know, and I'll consider ack-ing (largely) as-is. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:34:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498729.769615 (Exim 4.92) (envelope-from ) id 1pUPyg-0004Tc-IA; Tue, 21 Feb 2023 10:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498729.769615; Tue, 21 Feb 2023 10:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPyg-0004TV-FP; Tue, 21 Feb 2023 10:34:30 +0000 Received: by outflank-mailman (input) for mailman id 498729; Tue, 21 Feb 2023 10:34:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUPyf-0004TP-HU for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:34:29 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20613.outbound.protection.outlook.com [2a01:111:f400:7eaf::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ae4916a-b1d3-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 11:33:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7971.eurprd04.prod.outlook.com (2603:10a6:20b:234::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:34:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:34:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ae4916a-b1d3-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQU2xLwwnhExbN9XV9mwIyHaES/mMfy2kyBOzjqPxGY5y7zAD4wXcNsBWw7fUkrnVkHjT0A6SZN0EbFUSC+1BhcF6qjlJ6bwft1AFynq2V0sNzcazg2uZzZCItpsx/n3arZsr7bmOqSU4grka2dV3JxgYXZiug/927ZBwurQtDSdX8aWVgbdMJ8OCh9GcQ1i8OcNX0g0RE/ZOrIlpRLWZiGzCMT0hgDeO/arZFpkHitQmX25kqMUlLeurDt0VK/gEC3lYLDwM72wINnqNbIEoycyk6HmKO3VosHK44bLYITBAF3R+t8bKemLzYaTsFPqHAeMX1ShSB+7BEUU7MsMCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vueirk411ccbQsk/R6TFPb0Ku2dFHcQ1GekFPx42q2o=; b=naWajNS9H46oI2gYdacWmOsj0YmSiTouCVBGWHJuEplK+JXM/DJlp6LuNrgVR1VY/xU/o/TyINetLrLUf8J7TOyALV8S0ddVMU0f30lc7Qn0T47V2fPtUsmwIEbBlUhkVL96GKpcPKlDK0yQ3LC/LXyOXL9DV0lCuntkPMPe8vu9ypDAIj7LSPFtRyU9K6ILovHLiBJhLCHBe4DhpyriDCEgTNk9g8ut421sLjimPCDGuWuj4DCBR3tiQ0bLycFwAupKyxD0H+bDK/qK4JB7ywHSROSf/aYxTPsRUG32cOJUadei1b5X5oPdTcLCN+hrKwZDopSMaWEEjrcc83eAfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vueirk411ccbQsk/R6TFPb0Ku2dFHcQ1GekFPx42q2o=; b=W9kHT52Bpi562N350z/AMk8n+D4CFR+4lysQ+bOIkRJYn+T43GHtwIhrQ3UdvSj71V2OklHjcMX/eBf6anUbqfQIdo9sF4dIMUt4pTyPb2wTbSBUJZeQHR+Oe+Eet3WrHFpM/zcRDd1jYvBeL5/FeTP6TiNywPo/Ll2iZ4ho0DcTgnB36eDKtCgd2yAa2YuPHYOYMyi589O6omThp4Ob9aZx0N3v8j10MuPF2DDE5XPcNSpILKcaS5zCQ7ajtL7kpq36S89XNk2m6QD3+XH+CXVG5rzbbP6mUICOIGL7CpoQI+FlTJ1WR9Nu9bLWF86ySwEii6ytMre7a5iYP54MuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <27561b8e-0187-5c27-fa4c-e0ee389d5ea9@suse.com> Date: Tue, 21 Feb 2023 11:34:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/3] x86/kexec: Drop compatibility_mode_far Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> <20230217174814.1006961-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230217174814.1006961-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7971:EE_ X-MS-Office365-Filtering-Correlation-Id: f62303cd-4464-4842-afdd-08db13f73352 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UeGWCLzyBT1LhOQTuNcNIYpqtdDYoMCgXm0dYMS8py2YbHvS8D9Di7hVO/N3+GJRWFIgwtQuE1HHFC8i/inksr1on/Rd4MJIN0CTvMMBSJMZrH4m6C8Z127JIy1CNtfKja+0O1p8RQQG+caoyYJ5XeiuV5rOWftp0H0UucIvw6MJqlcHasSg1uo46/pF+qjbzse1s9x8T7yPmkpgGuZ8oypJcibj+w2Vdzlkc1EoAgHzGetvopNt/hAPHIuzGQEfQ88ZKcaxzft36eBW5dpyNnmBvQyLsO8Ko+N7Qkk1ncOBT074MPK6C7rA8xeqB7WcN/oFO2QqGjebpGPyq3ZZEjqeC3+3fpoGGD47NzPbqqH8mxPJJ0nNeWxP+S9Dn9zZBJYYFTwytCSNOSr6BU7eAnmbAW64A+bPqOFvCeHPumGQBgLjQPTdg0bQPron9IbvJdugoZ8nQVXEqQFKhPyoSRo14xMBAKBfnWenKcB0Nid7NRUVyEVi3kxHKT95BKCzA1A7bL3/tqcuR8CtcNz1SdamF/3vj/NyA2lxCEW76hWsVxPgibxmiRYcfoAFqHDwK+1iUCJgsv4z25IWROUaBj8u6OllFHsNoRiaELGP7a2ylOa3ffk4Eid1YE9zS0wH8b9ktyUKaR8WJTe0jBqAH22cZNVwO0PIrRR2Jqn9kYQUsIfGMrZA6fL3ZrFU3eHj0Q1Br+eBwZ9atlPHu1Nl3ONYcxF6hWuxzUADGpUx/qM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199018)(36756003)(2906002)(53546011)(6506007)(38100700002)(2616005)(66476007)(6916009)(186003)(4326008)(26005)(6512007)(8676002)(66556008)(41300700001)(4744005)(316002)(66946007)(5660300002)(8936002)(6486002)(31696002)(54906003)(86362001)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlQyTlYveVNFcUJFRGlKYTlQVnRtUmNWMUtVbWdwN0RGZlVNYldXdkUzdG9o?= =?utf-8?B?WThRV1RXZ3V6d1MraHh4YUdQaHJMYi9RWXdpczNxZWp1czdGbnRGajNIU2dr?= =?utf-8?B?NUFnSWlCTFZPblNlL3g5VVdmRW16U1o3T0ZMcDhVR0RlTFFHZ0xrRXZuZHl5?= =?utf-8?B?NUtnbVhKM3F3cmx0VWxGSmJ6TmUwNm1nZ0hhS3k4ZW82cmpETC9vSE9zSzdH?= =?utf-8?B?YUVTNlR6REtRci90TUpqeTNuYWFrcGdoaUpOeFZyZllXMG9wbk5rOVdaZCtL?= =?utf-8?B?bmF3RU52ajVQTDV2OC9RZklRVHhjNzFuVTgyVE9JQ0J6RjJmTHc2ZHRFWVF5?= =?utf-8?B?OTFBQWUzcDJxZnZndDV0TEsreW5NWEZMUmNrNmNSUzc2a1cxQnM5YnhOU1Bw?= =?utf-8?B?KzNmeVJWVElYMFVJcXI1L3cxblVLWExMWkFsMlI0M0tiM0tyNG9HdEM0ZzRU?= =?utf-8?B?K0dpbnhjdVd2MVBwdXBIUUl4RFlhTjJvcHNmUGR1YlppUWtDVVI5NFQxeity?= =?utf-8?B?a0Z0aTc0ckhuNVBaSmJpYWtlZ3hvQ2QxVU5oV1NIalJUbHRKNU9VRDdwM2JO?= =?utf-8?B?WGN1blY4YTQwT0xncHFsSTZEanpkQ21wZ1NiZGx6K01UNld1MFdaNGkrWkRG?= =?utf-8?B?eExaN1k0cWI4ZllzNWRVVWU1L1Y3SzRMU28rR0I0TXozTWRyN0hUQkQvUmNj?= =?utf-8?B?RDBqWmxFTFR0ZWl1MnA0NDJIbkgvR3BEc29qbEN3Y2RLcFl6d3hFbWRFci9o?= =?utf-8?B?bG8zc2t3RGdEYUVHcmdKbHpDOEttMjZ0dXdzUno0MGh2UzBaTERuOUhHSHZ6?= =?utf-8?B?VmN5UUNqNXQ0aW5uU056YksyeW5peDFPTURWT1pTUWlTWFpDcW5odjlmYy9J?= =?utf-8?B?endwaG0wRjFTR2NrL2tPN0Nuc3VORVJob2EzVHkrdkxjbmpKSk1tREtVbnQz?= =?utf-8?B?MDY3L2ExMW1teXo5ZFZPVHhKclg5MzNhdThHMEdWazlMVE4yOXo1UERZVldY?= =?utf-8?B?eHIzcTRjZzFXMHpaVEVlQkNGcEhFM09nR0w0ZmhIOU1rY05xMURqYW9ka0J2?= =?utf-8?B?aFl4ZG5KcHc5VWp4aWVlNGNmWjJJdkxuc1czeGdnc2gyZDMyTkkrSzFQUDlW?= =?utf-8?B?MkhIRWFidDhGUG5yWm95SVJmQXpkQlhhdDNtTjRGdGV6QUNwVExteW1ReXJH?= =?utf-8?B?andFZFJpWXFYNWlrZk9tNWljb2lmV09KYzJMSDRBNVpUWlhSeW1weVVwZWZQ?= =?utf-8?B?blpVRjcydjFFUFp3Y1grM2t0ajlaQjREVGRGbzBzb3duR2UvMEU3ZEFwNXpO?= =?utf-8?B?ZC9hZGYrc3UrUFVkdWJrMWE1UFVXOFJlb1BrVlFuZ0xpQTVZc2tscXo0eG9v?= =?utf-8?B?OHY1eFpGSndIU0FYVjcwK2ZlOVJxN0ZGYjJqU2lkVHBaeVF4V1Q3Q2hoMEpx?= =?utf-8?B?VWZidlpEMVByT2RTRUhOWWhsTDR5dTU2YXlsUFhVbHorS1ZxK245eVo0Smo2?= =?utf-8?B?cDVxenNwNUkxb1F3R3g3NG5KVi9PUTBqVEVKeDZPYlNscFc2VW9oZ05RTFBG?= =?utf-8?B?QTFISXZhQ1NxdmE1Z0tWdW14aEx1OUZweFJIeklheDJrRi9IR3JKN2E0eG5M?= =?utf-8?B?OUJLaDJSOGRyUU9FN1hQRzkwS3pNemlrUmUwMVNZeDhicUkzS1l1bC9KMTB6?= =?utf-8?B?Z055R29EcFFtdGcrYVdXZHhNTVVJMFRneWlVTFg0TzNXRXdxSWpNM2xXMVNE?= =?utf-8?B?blFGV3ZjWnNLTk0xTlRMTDJOYmVrMFhZWGFpUlBUYUMydTNnRmhEaDFRWm50?= =?utf-8?B?VDYrekJsSExvL1RPQ1dmQzhNN21XMGhQSGVWUkVlczA3MTRLUHl5ZW1sczk3?= =?utf-8?B?amtLRXRsVzFldjFaOWlDRTQ5R1J5ekdNek8veUNyU2dLSmxmUUdoSmpMUDR4?= =?utf-8?B?Z3JDSkE1V1lqRURKclBoRXZCYS9DNmdwSGk0ZkV0RmhlTy9ub3Qrd2dMR1FO?= =?utf-8?B?c3FzYnlJUjVQTDZmSy9XdnJMMWl3MmNmTGR5bnJSN01CZyt1RE5SbHB4MExG?= =?utf-8?B?QnpUWnR2T0Zia1JzWXRINGZEekFiMWNVY1VLeEdpOUFIN0ZuM3FaQ2Y2RWlS?= =?utf-8?Q?lZtElVp3fQLJnwpaUYBazmSJP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f62303cd-4464-4842-afdd-08db13f73352 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:34:24.3213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JQSnnQiaTiXQLmedS4HhUino7L3h1I5dPQ/yE+69lSF/9fvnQiLTqtjmGS5rjx78r7oy9Wp7MdbbQVGkkGgrrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7971 On 17.02.2023 18:48, Andrew Cooper wrote: > ljmp is (famously?) incompatible between Intel and AMD CPUs, and while we're > using one of the compatible forms, we've got a good stack and lret is the far > more common way of doing this. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich One question though: > --- a/xen/arch/x86/x86_64/kexec_reloc.S > +++ b/xen/arch/x86/x86_64/kexec_reloc.S > @@ -86,12 +86,11 @@ ENTRY(kexec_reloc) > movq %rax, (compat_mode_gdt_desc + 2)(%rip) > lgdt compat_mode_gdt_desc(%rip) > > - /* Relocate compatibility mode entry point address. */ > - leal compatibility_mode(%rip), %eax > - movl %eax, compatibility_mode_far(%rip) > - > /* Enter compatibility mode. */ > - ljmp *compatibility_mode_far(%rip) > + lea compatibility_mode(%rip), %rax > + push $0x10 Any thought about making this literal number a proper expression, rendering the code a little less fragile? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498739.769626 (Exim 4.92) (envelope-from ) id 1pUQC3-0006Kw-MM; Tue, 21 Feb 2023 10:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498739.769626; Tue, 21 Feb 2023 10:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQC3-0006Ko-JI; Tue, 21 Feb 2023 10:48:19 +0000 Received: by outflank-mailman (input) for mailman id 498739; Tue, 21 Feb 2023 10:48:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQC2-0006Kh-NS for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:48:18 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20622.outbound.protection.outlook.com [2a01:111:f400:fe12::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 285cda27-b1d5-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 11:47:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9581.eurprd04.prod.outlook.com (2603:10a6:20b:470::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Tue, 21 Feb 2023 10:48:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 285cda27-b1d5-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzKvsouKzbGIm7Kd6Q8udDg0vI0qOxeE8JFlrhxhdRrWZ/Ht1/jAF+7kTYiOBlrT9PhmjeP5grOeDX6SlxQBlwRDfTewlVqkdFrWs3HgU0dIMQjX33w2RfsB9uY2hSdsj0Jky6oXjahlW7z6Cbm08+KEUuDkTBvLIxPgy6hPkhIDfVxh2zy++EEsg6kj8//F3iWtzbweJQpkJJYNyFhX7D66DpzWCY2D+4ZWYiHa33HZT/9w0rsXzztqpB+EJlghvGIcNm6ynnTdOY8y2+47gtVMCyd6wQdGHFb8tZ45P6LWYLiTQAjAZKiT8ShCp7Y4FXZ5HDZzBZnh8tM4YXh3+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jGmv4DRHb8hXct3Q1ksBy2nu+OTuIswsO82OERLJWCM=; b=cmjZtDKkFnTgnEm4hny8OwbcCZz4A3/AZ5GNS2WGlTIi8y6xpIAGWE8Vtk9bSn0JvlgDbqO4C+1bPnZJdixOTX1ZHGypUVG0gn68lwsx/Xra+bffFY20o9yaIdbMl7wNU2DLi2lYin6g87rI3wdXpmmK+VoGZc3m2ERQefeCPv4IzsBMCv46hlXXYNFqgBFtsC7i+6JOanOjf3IVqVDv6/aRI60aIJN9P+sKEzQwhL9C9UKumq628FthP5mO8gzyi5Ns8Dm/6KXnpTF+8VWnCHTI1G2cNt8v6RBlyy7rw87X634RYWy4C9ouAtok+4S39bvyklt//LXYbwk3MrAo+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jGmv4DRHb8hXct3Q1ksBy2nu+OTuIswsO82OERLJWCM=; b=dMJ3dyAzy16B68i8/AvdGUe/uqu5myE9Bk2KDv7izPlKKFaPI9XL9DYb0YHNgr+WS2uNbE+LbXymoHMBxDzo/HL4IyXBapTtEXk2e3oWlAFLIox8kcpg/Bd8KJgnLSMXMKxnHv6PE4bTJthWwSAISqmU3DDzlJErHbjuTFtRNqHv0BS4fJn2OW5brkoV+bhsrZuekjxfJvrFugMIF0UvsLPUCYzU7CpddTX4HIGc5PjYTXhJwgO/tsOmINWbRp9DVPLGaVQ1k5aqE5fTla9dEBpNWZ+ojqObEsPjPuFY8Il64hIi24EwAkTBMvUIsf4jURGAsQEYYx483wVHF0KVnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 11:48:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/3] x86/kexec: Simplify the relocation of compat_mode_gdt_desc Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> <20230217174814.1006961-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230217174814.1006961-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9581:EE_ X-MS-Office365-Filtering-Correlation-Id: 045a0d93-af94-44be-7e90-08db13f92160 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rFQvye7J9Nrc+Kglx8IUkPR4bj3jd7LORQOy64P18Gj9Il2gR6ehFBpO+V25ahejxklQFQEemXH5cV94N9bMXfAyDCPpqs/u3otVU7RDdL16W4nEIw59ircdxhMlh7Y6RR1U1zvmtiGY9V4h8kA0/3F7t+/+m/JwjBfH/R7f5Gh8Wnk2xIM4X5s0K2bBmZPOE9LnPm0otRVJuLT8T0X9iBp1IAs51PR1DbnsVkpdi115lJb0qT2Yigx0VPhhyqZvycZXnkgWsKBFtHpmZ8dHWwzH+nOePA2Qu7oxhNFItcQvuKPidH7/Ef4Bk8oN90+stqA/cmMc0WuBrpm/OsSgq6ljzkzJOCWF+f+UHPvbMtoUMm5M7LJWigaNjg1h1O7Fagv1wrKTFOze5EiC5zgMcw7LXLf9AE4x44rA/MK/OfGEaPRR+qPFPSYKpIaMy50rw6s88M0gbwdbTbnDm6Qqst5mGesw5/e4nHfHdCVLgMIYXu29Xwa4KvfkVHilDr6YL55tuGcwbFpySPRoWFofumJaSxixXPBltiNyQHHGV9tAI4KqNnzLO0zqdD9mhwdcXD0tZJNe5hq8YJYpCJtSEjzqZUXjbpWtnJtaTEIhMuUhFQWZRzd6wavF4OiBTis+eSDVcH8I5X0mXM23ZT3NFVcWgmIzZlhinY0fKp+XA1OtLXHllHkIE2wtSGjfWle9xPhOyPkWxnd9u+iXBu9eiRsfOyZ/ETaVt9MMUZdvso8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(5660300002)(41300700001)(8936002)(86362001)(31696002)(36756003)(2906002)(38100700002)(478600001)(6486002)(2616005)(53546011)(26005)(186003)(6512007)(31686004)(6506007)(4326008)(66946007)(316002)(66556008)(54906003)(66476007)(6916009)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WURST1JJK09qVVAyN3hzNlBsaW51aEsyMlpOUTQyYmtiWHM5VHFlR0FheTNh?= =?utf-8?B?VjY0aUduNm1wUC9jUHlJU05JVk5qWFlFZzhNM3hYWklLMHVoODNuMkNwMU1J?= =?utf-8?B?VGNZaVBEamgveG9UMHFjMnp5RjB6SlFXUWxUSWtDRVJ2bFgvbmhHN0tuMS95?= =?utf-8?B?cGZzbFlWdE1OZ2d4TmZKdXF1VzdNM0h3QUJ2ZmhFMjNoY0Q1QTA0T0t6eWdx?= =?utf-8?B?ZFZsZjZkd3RtbThxb09QRExRbUljRzA0aXozMFFna2dVS2lqaUFvTkMrQlJZ?= =?utf-8?B?VThZRUNXUnIrWTFvZEJDVzJzc21CdElxVHJrejJ0dWt6eGhPMGJPNWhFblZQ?= =?utf-8?B?S1hCbXZtVzhPZkRyRkhINlcxVmdEKzBQRTZCdjhwaU40RFVZOVJaWXc2ZnZq?= =?utf-8?B?TFdEWlN3alk2VDVKcEVtZlVCY3M2bER4UFk0Ny9tY2NEQnFDQ2Q1OUFCei9s?= =?utf-8?B?VnNYTTAvTXRBVkFtUmk4U1JYUW0xNVZJRFBvMWhaYmpZMVgzV2FxTWl5R05v?= =?utf-8?B?ZHpwbzZpRHYrTFY5QkVGQTJOSENxRitxTWcvUDgvS0FPcnF6cnRJdExuNGxk?= =?utf-8?B?UFVRc2hKVWplQXVjYkpNSFRwaU1uQVRLNHpadDg0c0JHUFdNQm8raEx6aGJn?= =?utf-8?B?Q0phaEJjSm5tYmxXY1I2eW1WbFc4WlpETVEwdU5QK1BmV1kvVXVLK0lpNGVR?= =?utf-8?B?aFU5emthYVdub2c5SVZkcWNUT1VwSVh6bGtYanFQZzZ5emFOQzhEV3BSemV1?= =?utf-8?B?QU9sNnZHM1hNd3JLVVlXZTd4eVdORTZFVnU3L1lEcndkZHc3MHRJcWpsMzli?= =?utf-8?B?U2tETGJKemszaHBOWGdqY3BsTEZsei9FTjVwWHFtODR2WkJ0NE1pcEhNZEFq?= =?utf-8?B?MHRkS2c0OEo0WTNCZDNwUDNab0JOTmVaVk9GVGtHM0wrRXdFYzVzVzR3R1hz?= =?utf-8?B?eWNjUkNtOGFXL3ovYlYxRjQzYXVsNWJkbk1OeDZhcUlTcllPUlQ0OEtSamlr?= =?utf-8?B?bkdzaS9ENzMrUGRyRzNTdmRLaCt5TVcvN1drZFcxcW9PT3haUzU0V0h1ck9F?= =?utf-8?B?RWpZNjhXcVRzeHkzWFc4UlNpSEw0VFRBVFZGMVNmQzQ0SE83NWE5dVFCKzNv?= =?utf-8?B?bGdwUFFRQndFM1EyV1hWMU1COUFnZEF5NndmRmdaek9lWlNWUXMzb1ROd3M3?= =?utf-8?B?a240bS85bG8vRnJHN0ZiVEI3UU14V1JUYXhpdEJjOWFneVY4c2dNYmRZL2hT?= =?utf-8?B?aUdpdW53UEtjbmhURHBDdXJBUkxTL3ZISnlVaEtxQnp1N2RRMVVDbWE0L3lz?= =?utf-8?B?UzF2eG5UK3BnWXBaeVVrUmhPejRIaTNWaGRvZTJwa25wWjF5eHlMKzZ4Mnly?= =?utf-8?B?ekRFRVVmdWhUOExSZE1UZHZJTlNvM3R4MWdDRUFzU2t2UngxMkx4a2p1QkVa?= =?utf-8?B?Vm9yVFFhWldhNGk5UWcrb2JaamFKUGc1eitKbWZoMUlwVUpvaGVJZDFnTVpl?= =?utf-8?B?M2lLR1pDRnEycUVwa3czYzZzT2NYUWVvOFNEUGdWUURtcXhoajY2R1RzSlNU?= =?utf-8?B?ZS9IRjE3dktuVVQwVkdkcDFGeHRZbFZ4YXFwbVE1Y3lXZ1FzZm9RZ1g0Z2tQ?= =?utf-8?B?a1ZQV3FtRzlXZWdMNnRIZW9WcnNicGNSVkwrdVRINXRyUVo4QlFVOW9DTUI2?= =?utf-8?B?dGFSL3ZyenVQTnpXQUl5TmFGQkRZaThZL01OQ0NJV2hpNmcxcHVFc1ltL0hw?= =?utf-8?B?aitIUGlpMWlReUwyMDZsQ3kwSjdjaGF5YlZtdU5MQ1daTDVGNUZROU5qZEVD?= =?utf-8?B?dUlLUkxBWm04bjZBWG8wVnFpbTl0T2FwOTVnNEJML053NGtYbVRLT0dtTlJ5?= =?utf-8?B?QzY5N0Z2RlRLWTY3ZnhoU3g5TERyM1lIL1JrYjcrL0dEcHgyODNlTWYrdys4?= =?utf-8?B?S3RFK21tNTVLSGpZUWlDRjl0Qy9FVGJFRWtkUEZsU1l0NC9jcTI2cWNOM0tQ?= =?utf-8?B?WWJqV3RVdmkrQmt4VE1iTFZLU3UyMWloU1dUYzMrL1cwNXEweHhXaWhuQytY?= =?utf-8?B?WFhkT2VvVU5XK3RFaFBJY2lkRVZiOGh0cytoSEVIaEVtM1A2SXZvS3FqMC80?= =?utf-8?Q?lr/ZIK1+UbsLyvhWhsFEZdAmj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 045a0d93-af94-44be-7e90-08db13f92160 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:48:13.2063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F355/GfPZ6+zFSlZFjEMR58iabyRwZjcs+30x9b3ReJZO279frtNibDe6KxTa3d0lRr/PHbg2mlYMAu7rZMpkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9581 On 17.02.2023 18:48, Andrew Cooper wrote: > Assemble the GDT base relative to kexec_reloc, and simply add the identity map > base address to relocate. > > Adjust a stale comment, and drop the unused matching label. Only kind of - the comment is referencing call_32_bit, and hence wasn't really stale. And what was (and would remain to be) dead is call_64_bit. May want slightly re-wording. > @@ -81,9 +80,8 @@ ENTRY(kexec_reloc) > /* Setup IDT. */ > lidt compat_mode_idt(%rip) > > - /* Load compat GDT. */ > - leaq compat_mode_gdt(%rip), %rax > - movq %rax, (compat_mode_gdt_desc + 2)(%rip) > + /* Relocate and load compat GDT. */ > + add %rdi, 2 + compat_mode_gdt_desc(%rip) > lgdt compat_mode_gdt_desc(%rip) Where's %rdi being populated for this? At kexec_reloc %rdi points at the code page, but prior to calling relocate_pages the register is overwritten (and the original value is lost). relocate_pages also has normal C calling convention afaict; kind of as a result %rdi is actually being clobbered there. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:54:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498744.769637 (Exim 4.92) (envelope-from ) id 1pUQHg-00081u-BK; Tue, 21 Feb 2023 10:54:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498744.769637; Tue, 21 Feb 2023 10:54:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQHg-00081n-8e; Tue, 21 Feb 2023 10:54:08 +0000 Received: by outflank-mailman (input) for mailman id 498744; Tue, 21 Feb 2023 10:54:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQHe-00081h-Ur for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:54:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on062b.outbound.protection.outlook.com [2a01:111:f400:fe02::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f54f0cd-b1d6-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 11:54:06 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7821.eurprd04.prod.outlook.com (2603:10a6:102:c5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Tue, 21 Feb 2023 10:54:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:54:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f54f0cd-b1d6-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UoeZMT5pdVWWhdCOCfDXOBHPG4mLSc21vRlzAxa/fvWnpTHQwV3fm226IgHzgETAL0Ya2r5zpdShrez6eqmgl5OaxtNmzxoACf7rFdKxPaS+2pOVobp2jq52mQSpC+p9XjTEnU/rNhdhoLXB3Z4HhGdK7IShSVSguHFQSveAqpnFPGVwqacq9e1cfk8WTbxYcun8jI53MB0nw4tM3YXAahdJpCSqrZRDC/ti1m9QvIReDoJDhrthhspdZ1FXQylRO7HRjYeWMP9g+ODxFQCp1QY1+mYC68MTfRLlLkYnqkOMgi5ZCRy8b3UlYw+cQjR17NmyC08a2MbpL/neZW/KQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmXT8biT7yqitiSgV4ZytugcbZRYwWDboWRvFMT3RYI=; b=Y1Nfd9AHBqPDbX9boltRV8tzCF54JjsvyWsjbyBbqHSewWOH8LGqDAuAqHV3kLumjaBGIPb7hb7ulcpoAM/LmUXnxb+37NAgOGpDsm12SUGJ2+f6DmhyW9aN+mGdgEaITyG+vY57VLxW1/nYKkyNkcZrf4BryHZ8HwOL+u0J3OSzAsu7DNFKAkDefHPUcR+lXjIcTppkkbG4L3Ewr9SltT2VlOlzHkHDv+HR0waGoqJ1rhpdkNzQYOVph6S6pvjJxON4DYkaQ3c5xTpkWVzJt3nFVJ7U0BJbML6S5K2kRVXCzfAI91gLKzwlmhfMcgiFTYEUUjOHbUnXtgplU/QZXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TmXT8biT7yqitiSgV4ZytugcbZRYwWDboWRvFMT3RYI=; b=2hBgoUWAawekn1KFaCvJhhusJOGzs0iUqixMBPBYYJaOVzydzaw0c5VcHLJEOtF5wLrSypcfL27BubiNnmPyXaaGmBlkdmQ9QmzyioRTSbvprqCWmSAE2rd3O8Q+M2/+TPBJIVayjQi/UEDThDrtQNG0h0p1zOuNzY8Hl0dd9zZeVafKnO/kWDQMH+qhx/XqUNbSLKKEf+ajdaV6YSCz1tulU+BtdXbSJTbqhSwa4r9Fyg5tTU9JAZwdEL4wBmvWNhIPZ6kGTuFIeFktuha23WZH9B7xkHa4aCNWVyQx5rjWXKPQV6l8pxKeFJBUrqKzRSByjl3sl8vnmvxuWV9dLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <588323ff-f8cd-5670-789f-65eeb99c495c@suse.com> Date: Tue, 21 Feb 2023 11:54:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] x86/kexec: Annotate functions with ELF metadata Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217174814.1006961-1-andrew.cooper3@citrix.com> <20230217174814.1006961-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230217174814.1006961-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7821:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cddb6c2-b2f2-4b22-c1ee-08db13f9f250 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8VXl9ncaTrKaIsWI77LZAKjEqQUq5358YDZiy31LMDoFOEbPOCpen6ahS+rIlmQIxu215HMuADgoWvOWHGhcsq/ZAaAhJh7iVZATAzguJNNONgnoOb8Zt9XWIoyaOd1a3KRyMf+Kcc92Yr6HFNrQedIj7VPqhl4cAmlW8q47H7wafqxFOohgo+19+D9w/7ScXVznnI9Grc7VJ+ck8mlssdNdyX2Y38DX5DVPUS3BwZ7B8yo07LJl3yZ4397VcMpfT2BAw6bFEj99unm52rcR1cS2XsvXzjN9Y88wkpyx+YX2UJ0NkYYNYKWwzj02M4pTY0oHznGfXqb/MvRIB8EMb5dGmpAQ++/54X4b4asYi048h83vZFvr6uelGeFbN0RIcymeNXKzuN6dGcP4ZOSRyS133itbQ2Cu0uEgd/aGkuXKr4lAr/2LkRPyACUIPkIfNseRINbY5ALDj60+or2gCAhA6vJ2EoopzNCqByO78/DbZQALXVBKBGkqRsQOK4kjbiJyZ0NNy7hi0gjPV8+R0KYaNqY3oQeH/prySSoLJvi+fgbdil1mo7pof2269PjX9PNFKhj5KRnCNCaa2QdDWvuFnWW9XQeVOqV/qb4XgW0OcF5zzHyVroIZKSfU637AnisqW6zGsuMgmnQoArqI621rd1FbDKvnJcDiNdFbfDXiWyVARoP5BngKiKH6iVHRqmYUHkZCX962H4vLzsyB6BQQxRYccOeAyR7MbaYAlYw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(366004)(346002)(376002)(396003)(451199018)(8936002)(5660300002)(478600001)(6512007)(36756003)(38100700002)(53546011)(6506007)(2906002)(8676002)(4326008)(83380400001)(6486002)(66946007)(26005)(186003)(66476007)(66556008)(316002)(86362001)(6916009)(54906003)(31696002)(31686004)(2616005)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkhKZzdSWUU4YllNSVA5RjVYT0lrcE5Id1hwbUMvS2t3T0tzQTc1cm1MUVB3?= =?utf-8?B?N0hTellseFY5MjN6QW9jbTBOVE1xYUxhMmtmK1hZYkNlOWliNHpPeTNML05E?= =?utf-8?B?VGpaTDEzYTBMM2MxcnBLK3hzWnNPYUN0SUp0YkNEMWdiVXFyVmhnL3JDWjVm?= =?utf-8?B?S3B2OGRHSmRHR3RXdHJQYUhNNFRpeGZqRmhEU3FsdGdLMmtZWUFIeHdHc1Ny?= =?utf-8?B?UWNacldrMmcyUzJmVmt6QmdnalY3YWsrbi9SZ0pua0Q3OE04R0VkS01KOUhP?= =?utf-8?B?VmlYVEdkaDJQN1R1UzlvNnJ4ZlJqeXVMcmwvcU1mSWc4SmVrOGloTzFBNTcw?= =?utf-8?B?bXQ5R0lsODk5ankyRFBoU05rTHQ3bklON2dmck5UUTluUDIrVWg3R0FJVjVM?= =?utf-8?B?dHRVaDhjVDIvQUJmYkYwYzNpNm1RODlzRUFKTm96NVpZWkhrRUluOGJFNCtu?= =?utf-8?B?cmFSSWlBUE81TVBKTmM4bEhsdWhQV3MvTHpOL0taS2lZeU85QzdrVVhhSEs4?= =?utf-8?B?NHk4OEJTdk1mbm11SGszRWxQWXFHdCtuYituZXRDdG9WZitZMEhUeVNDcjVV?= =?utf-8?B?N2NzTWFUTDBFOTRRM01UbkJUT1VxcFRkSndQb3NReURRYm9NYVZjYTEwSUZG?= =?utf-8?B?UFg1aWdkZ3BhbGFGbEZGUFVobUhxbThib3dGZHJLc0dmQVZFTjlHZHpoanNX?= =?utf-8?B?L2FrTWdBMWkyeUI2dGQ0MWh6RGVjRENLSDBKSFlZdkdORmdEaGl1eUVubU1t?= =?utf-8?B?NUxRR0FUcnM1eFYwSmlHZVoxbjNwU0VjYWtuQ3IvUWR5RFJXbHFJYmlHMzR4?= =?utf-8?B?U0VWWktaVFhPeXhKVUUvU2wwZGZyS2dnbXlQUWx1RVhvMEpZZ3h0bFh0YWE0?= =?utf-8?B?OWMyVEt3LzRSSTAwNEhlQUVxbGNMWW9oSWRHNFRseTd0eitCaWFhOFU2Ry9k?= =?utf-8?B?U3ZMYXBUOHlFaWxNVTJNaWR1Q1FVaGszUGVMWTJiQ0ZvaHB0dDFDdkUwWm1a?= =?utf-8?B?TW5BSDhMOE9rckE4cm1oMGVxU3BSZVR6UTlHVU9iUVVPVEdBTW9LQnQvL2ht?= =?utf-8?B?b2RPeGhTZ2hHN2tZNDZJQmtGNUdUWUtXMTQ5clRHeFk5SW9pQmpOalorTC9G?= =?utf-8?B?QkpTVjU0YytMb2FDT21DeVRqTGgxblpSYk9UbmdNUVhkQy9qTUIyVjVqMzRK?= =?utf-8?B?WEEwTDRqdjZLZGlQVjIxdHV5ME1mc29RRVhJY3JxbnNMbXJlaFlOSnZXTisz?= =?utf-8?B?a0d6cDdLclFlZ0E2WGZKNHBsbktpWWc1K21aQkt4aXpaS3djTklJT25JU1F1?= =?utf-8?B?cDk5Ti9LcU9rditLZmtZZ293dTZMeGx4dTczdExpdVp1QWtDSGN5OGRwTjk3?= =?utf-8?B?UDNXMDY1UTIzSm1SZ3VLc1lwTWlFYVVWeCtRRCtMS2FuWjgzNGxTSkwvd3Nu?= =?utf-8?B?cHZaZVBRVm5odFNMOVZtYTl3Y2FYc2dDZ29IQVh0Y3ozWDJhaUtQU0VRa09I?= =?utf-8?B?Mkk5b3JzWW1NQ3ZEczJ1eExqYTVsbTR2QWltVWR0NXovRnNJUVRxaUFiUGVN?= =?utf-8?B?bUpZSTJNS3VRalh0OEpQOXJyU1ZTZkQxVHBNaXhxVStXSjYzYUhZUSt5NnJ4?= =?utf-8?B?LzlMZWo3OWZmMlovWlFkWjJyV3BHdlFFYjNWZ2NXVVFsOHhZQVBKd2lEbTdX?= =?utf-8?B?MnVmQXpxaUJPN2pwSVRrK3QrL213NHZVbjFIUFgzQXFDbERvQnpiT3N4RTVa?= =?utf-8?B?VDVWbDFDZnJCajFMTDBDK3NlYzQ4eTN3bHgyUUxzaHVVMERMckNraXVTWjFr?= =?utf-8?B?SERiSEdNb2ExZk9PMFNPb0V6cE1DL3BQc0hVL0hrdC83cVM2d2wrRmViZkpH?= =?utf-8?B?d3E0MWZxZXV2SENhZEVBbWpFM0JNa3dRQ1BDVHkwTWZrNCtiK1g1Qy9ZU2lU?= =?utf-8?B?OXoxc1c0YzhlaDY1dXUwMVArZ2VPSlZsM2d0TUZUUU8yQlRscTZxL09vUDl1?= =?utf-8?B?TENqcTlnZGlnWWcvOXh3UWVsdEpyeVBGdStBYXZZZFg5THVHa3lrZnZtMFpk?= =?utf-8?B?eENWcXZUb05YTklLM2Q0WUZrQi9hUVVQOW1MUUlvZERyQzQ5OGt0bDM1QmhJ?= =?utf-8?Q?er0ZDS5cb7FAQ6ZMfnx2uk/DU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cddb6c2-b2f2-4b22-c1ee-08db13f9f250 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:54:03.7626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZHOAEymcgrhTUQPJS50IfdBJ8DIp3cl3BNUpTJBXAEIEjEK1jUYX/43B9G4KKhnhg2PvycqbvodrvZfxvm7Ig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7821 On 17.02.2023 18:48, Andrew Cooper wrote: > @@ -90,7 +91,10 @@ ENTRY(kexec_reloc) > push %rax > lretq > > -relocate_pages: > + .type kexec_reloc, @function > + .size kexec_reloc, . - kexec_reloc > + > +ENTRY(relocate_pages) > /* %rdi - indirection page maddr */ > pushq %rbx > > @@ -137,9 +141,12 @@ relocate_pages: > popq %rbx > ret > > + .type relocate_pages, @function > + .size relocate_pages, . - relocate_pages > + > .code32 > > -compatibility_mode: > +ENTRY(compatibility_mode) Do you really mean to make both labels global, thus potentially risking a link-time name collision down the road? In C files we try to move the other direction after all, making symbols static which can be. > @@ -167,7 +174,14 @@ compatibility_mode: > call *%ebp > ud2 > > - .align 4 > + .type compatibility_mode, @function > + .size compatibility_mode, . - compatibility_mode > + > + /* > + * Ensure data is in a different cache line to code. > + */ Nit (style): Strictly speaking this is a single-line comment. Jan > + .align SMP_CACHE_BYTES, 0 > + > compat_mode_gdt_desc: > .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 > .quad . - kexec_reloc /* Relocated before use */ From xen-devel-bounces@lists.xenproject.org Tue Feb 21 10:56:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 10:56:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498754.769648 (Exim 4.92) (envelope-from ) id 1pUQKN-0000HI-TX; Tue, 21 Feb 2023 10:56:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498754.769648; Tue, 21 Feb 2023 10:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQKN-0000HA-Px; Tue, 21 Feb 2023 10:56:55 +0000 Received: by outflank-mailman (input) for mailman id 498754; Tue, 21 Feb 2023 10:56:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQKL-0000Ge-P2 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 10:56:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c2af847-b1d6-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 11:56:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9236.eurprd04.prod.outlook.com (2603:10a6:10:370::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 10:56:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:56:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c2af847-b1d6-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWtauqPfFvVWlSABcgw8LeKH9Mk8wk7GamkIo9BwiMlhxhudMA3sXI08QeYHYP49Zr4wcp+4oMfAmpFitb0k5+FqSfl1EqM3+QGFPvyMScaDGayPDZTMWufEFqDKdWkwAvw7ez//ckPK5Xhapn2/rUVYuBok0ZWehxQaXoh8qA9GXDC4YK2NkiiQKLU3MOECM3GEH484l7isnfM4d2nkNGJMnq8wWDbUqnM9V70QODQM44gxV52vLnUow9/DyaEC0BfztAeRcIPGw1CWroS61UspwYQBWycBTtxYtaCfyADdVlc0H+WTD0j6wAuq2tgOCz9oZ72TsTDpSjkYbMwmvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/CZXZxRenR9PER6hQ2CBFDZ1Sg8SZ/wZydxOvUZ4ug=; b=ncxhxEyUz6mJUhhxJ47KHDW7ZPjQ6I57KkRS8hA6BsLJiygwQagEtMDI5zE3ItQjGPEtzHY6fZYEwN+0KqfHNrwhjkU0UwqkGmhzk0691ubnSzeRs9bsF+G4K1RJPcMbzU9/VC8FQKNG12TK2YKvmP4efYe5jO9ifr3yBj/umz7DVrO7bhhU/m+mbEThtqFzNNMKHDDd8rdeWtxBCw1UkN05OCrNAekfncms48bsjjzfJWEuRMyYKibq4alLRab2851U1EmlWUeuTNaXBxh3wOscxnXUztnPaN8PIscf2pu/QsxbPUL4iMyU8Lt/4KNQVy+XdF3tbajO/EIgAMW63Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/CZXZxRenR9PER6hQ2CBFDZ1Sg8SZ/wZydxOvUZ4ug=; b=DEpthQ8V8lpie0i8MxnFdpv3tkvYepIGN7LqamGq9EwwCsuPS0OOmPolI6fcxpMM5G6VzDk0hpRPxnYZPUq1BE4Wi0JxKrlsFURtcDz3UIfKw/vDd7TkWY6jyEsXm6SmFMzoRx5CkWX/adeYXeQK6kT6nVdT8CAIlKJK8ZPRghiv61G6ZaDKjqwRRKMdHRtByHYEmHp3uAGr+ksc3L45DIVjGOqIuDGQXWb62yOqRhh+5yecG3NIYSbK0KI8IbXk14Lr71AQam9I8Qm6vlXDewYo5BOYz156R8dfeUuIJXKB3E+mUHhHOKPn7h/2MBSnKRRc68M+8O/T6/svrFvUnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 11:56:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] x86/asm: ELF metadata for simple cases Content-Language: en-US To: Ross Lagerwall Cc: Roger Pau Monne , Wei Liu , Konrad Rzeszutek Wilk , Andrew Cooper , Xen-devel References: <20230220110439.1518972-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9236:EE_ X-MS-Office365-Filtering-Correlation-Id: d2148356-e75f-488e-1bd0-08db13fa554f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZUxUn7FlguVxx6rIrKz1BJCfT5/Gleab0ey0JuPoXmJPip9P+353xSuKrXRXkVydgc/7gXf2SMGrE3VV5zET4FDR310CUPfA8WjyErx4QT+5VvLYqZPp5qa1z+vpQhmfPpWYZ26VfzasZJcs02iMBnB2udxB/lvWHGbvZLoUMeE0hmWFTX4QB4pV/v8hyqTsxw12R+vZniHz0uOEZOhtseG9cvUjZ009lNUdL1vmnKbr6OlJdVct8vrlnOBOW09dVvbjZ/0zmiBQWvgskwUVWt+VMf9uYGeIH80eZ4y0WvVFtuZRu6v8ZPGtWjcws0NeQvGcosLhvE1XjBZpZ7FoH2+ze0+yWhJj+Pc4agndZmyYLMmJ/fidM2Kf0EzCU2jPg6OJfNlop4E72YZhUXmZvm0uOIgdteiYsAAFC67BvqJw/iVh6hK3f2B5LuA3rQzpQIXyqtvi6vTHZETyhVLvlVu2JbJlOZFNdA8C9Pqy5fsM6sNF7Y/cbT+gXJKTrJI4pT/twbhBCq5Ujzy7MW0jiFU2KdfHFH3keSR0OkKzo3Nfkb+opIxplz5dHGDKU+m9JsRQkjLhT+EWJZK8rp1a+h7X+mBNoeVJlv+BhGBp4xbsTBIc/B0X+e3Kh0887YYc410FF437jWFd2oVz9RVpzA2URBGBUo2TE5FaDJfiBgJovsDWxd2fbmrOQzRUYYO8+7iIGWJMfWh4JA8hD2hgp/iBmiRiCd2puN92ALcoSxA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199018)(6916009)(31686004)(31696002)(36756003)(38100700002)(5660300002)(2906002)(8936002)(86362001)(4326008)(6506007)(478600001)(53546011)(6486002)(6666004)(66476007)(2616005)(4744005)(66946007)(54906003)(8676002)(186003)(41300700001)(66556008)(26005)(316002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHd3K2E2VkE3bnVtTmdGUzBSOUNYK0R2dnJNKzFGUTFPaEY1aWtWNEZWSm41?= =?utf-8?B?eFBXSEhDYU9BS1lBYTUxaGFSeWJ6a3dsSERMQUhHM2RoR1l3elFzOUMvZU9G?= =?utf-8?B?QVpscWxUeXhiSzNNTFBrYWVMWC8vMnZMZVllV2ozcTFqcFJXaFVUNGt5K090?= =?utf-8?B?Q1k1UFc5Q3pNMytIbmhwNnRPS3dLTGlrblViM2dIZml1Y0xYRFZxd3FMbHpN?= =?utf-8?B?U2ZoZm1QVlZ1bDlPbzVhV2lFcXgyTDRIV2krdjhHejBaeG9kd09ISjBhdXRy?= =?utf-8?B?akVaZGJ2MWxqS0hXR2ZLOEJ1YTE0WUYzRlJqMzU5Y0VYWkNHL3NuL2VBaFls?= =?utf-8?B?aHdSbTR3Q2RyNnV4TE9yOFNzZDRZeFl0ak5oN210RG9WS0I0VGlwNTZmR0dy?= =?utf-8?B?cTFQMnFnQVluM1l3ZSswSWxHWG5kY2szMnV1T1ZnRTZ4NENNbUtBb1ZUakFZ?= =?utf-8?B?cVRTK2k5YWhjR1lRbzVMQldxd1d2NmRnVmtDbkJWVE81SVdsSXB1dnRMT0dl?= =?utf-8?B?MjJHK1hDRkVENzZiL0lseDFza01yNUFSREZBVGx2MWIxRXlqVmlNSmFKakFh?= =?utf-8?B?THNydmtCeUxxZE1IMTRsN2R6YVFOSU9WMzlkWFRPb3RsQmVtdFVhSzlzUkI5?= =?utf-8?B?L1B3K3AxWWFmNVNFUTZ6R1VoT0IrVUlLbUdsWndOaU15ejI1Tk81dWorZFBJ?= =?utf-8?B?Z28zVVdpOURIVVplRGZCZ0NPS0puZkVyaEhIaXNscnBiU2E3cVRpTEdCbnFQ?= =?utf-8?B?WEpibGNFUmpFUEN5WW9HUmsxSlhpRFVrb1NING41TVYyeFU5ZXpMQi9IcDFj?= =?utf-8?B?YmgwR1ZUcFVHd2haWEZlenBGZWI3WHo1U0ZXQnRKemgyL0toTFF0bEtuQ3Q1?= =?utf-8?B?VUVPWWkyendlR0krMkFnR01pcEl3OVZrYzhCOUVEMlE3V3Z6T0s3OUpEQTc4?= =?utf-8?B?dTF3cDdtQk9ZeERTS05zWXdwMytoU1JKNUJOSldCVkFQeE1ueWV1NG4yNUlI?= =?utf-8?B?dWxTdWRZUGV3Qm8ydlhseUxQRHZYOEdWeE5oSUFuRXB0UTVaYk5MWnAzQ25O?= =?utf-8?B?NzVlMVBVeHo3eEVZZi9PNFc0VGZxc2Y4azk0THNKUnV3NTRLWHNrUkpvcXZl?= =?utf-8?B?NFJQUGZ1TWJPa3g2QXdnT3Vmd1VHSlNCWWJKRERYRHAyemVqeTRna2o4bGRY?= =?utf-8?B?STZvdWIzUmYyenNhM2pKVUVqRjE2RXdHVlNMRjI4bkRZZkFxNGlpaEZNRTBZ?= =?utf-8?B?ZzluaWxVeHVZVFZZVW5ia0E3clVidGVYSEw4VDBBbHRxQmpxTlpLZW1LOFUx?= =?utf-8?B?Y2FVNWVsbU1qSXhjVjRFTVpraHpvYVRlYldFVHJsc3pEYUxGUmIxV0pUeXJY?= =?utf-8?B?T2lIZW1RckJaaytycWc4YnJEcW5JUG9NV01nNUV5b05xNmI5eE9HejE5dktH?= =?utf-8?B?VmxxUUJGb1ExdkdBdnR0aVY3bnUvTUtuVFZnK3M3YmFXNHA3U1RhdnhnbHBj?= =?utf-8?B?VERmenU5N3JDR3JHSzNZUGg0Q3BoYkxMbEtpdm12Z2hWQmQ3VHdvelNBV28r?= =?utf-8?B?ZldzRWYrZ1VrQnNjbm5XRklkK2lxbkRTM29qZCtxSGE4ZVVId1M5RkxDVGNh?= =?utf-8?B?N1FaNzh3VWJvekR1Y3psb0g1dHkyNE1UN1JxeEFIT0Z5d2NJNzlGUldqT0Jo?= =?utf-8?B?NkxLa2x6VWxwZkpPOXY1U2V1MEQ0UmVRUTdzblBIU0JuZVVJYTlFd2xaZzRo?= =?utf-8?B?by9GRmZmTkNJUmxadU81WHZpY0Y0WVRTcjRCMWJNL284c3NLcjhmVVlmZ1RQ?= =?utf-8?B?ckUySVN4M3pSVUtkUE4rTHA2ZXBNdkwrcEsvQ2lDeXVBcWw0YXJCVVBENEcr?= =?utf-8?B?ZFI1Q2pLYW5sd24rdExRUExIZ1RRb1JFZnllTHFYRERWdEtIN2x6bG5pbGNr?= =?utf-8?B?K3B0aW80dW1INzd6cjdwQWJqd2lsRUlYQ29SNENNaVBDcFVxSTczUnhIdjRL?= =?utf-8?B?WS83V1RYbUg2cHd4Wmc5TkxIMzU5VmRQd2p1a210ZUxQWlNSYXYwd3FNcFBt?= =?utf-8?B?REtjcVBQb3krUjkvSFRNendLYVRIY21mOVF3UjB5RnVNUU1hNWVUVGVUZ016?= =?utf-8?Q?j9lJpR+9kjpUzfsqOxqjhT5Yu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2148356-e75f-488e-1bd0-08db13fa554f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:56:49.8462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n7/ieXnBrg6s5YBjUFGPB2HaAwWdnQjtS55WoSS+Hd3F2fD4sXP7+B3VemFkbfHmpDocDAum0t0bbMK0UGcz4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9236 On 20.02.2023 12:51, Ross Lagerwall wrote: >> --- a/xen/arch/x86/clear_page.S >> +++ b/xen/arch/x86/clear_page.S >> @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2) >>   >>          sfence >>          ret >> + >> +        .type clear_page_sse2, @function >> +        .size clear_page_sse2, . - clear_page_sse2 > > Would it be worth wrapping this pattern in a macro? Funny you should ask this: Yes, certainly, but we can't quite agree what shape that macro (or really set of macros) is to take. Hence we did agree on this minimalistic approach as an intermediate solution. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:06:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:06:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498760.769659 (Exim 4.92) (envelope-from ) id 1pUQTR-00024Z-P0; Tue, 21 Feb 2023 11:06:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498760.769659; Tue, 21 Feb 2023 11:06:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQTR-00024S-M6; Tue, 21 Feb 2023 11:06:17 +0000 Received: by outflank-mailman (input) for mailman id 498760; Tue, 21 Feb 2023 11:06:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQTR-00024L-2G for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:06:17 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2053.outbound.protection.outlook.com [40.107.13.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be078bcc-b1d7-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:06:08 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9340.eurprd04.prod.outlook.com (2603:10a6:20b:4e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 11:05:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be078bcc-b1d7-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7TE+5Jy8SNY67yCQa85On4I4/XZxL08EJd4Do6XkM1UfuFttG9yr0iLEPwOEv3B8OPT1upwlm9JT5VBDbHnHzHVDo3cg+HJq4G42w61hs6d0ZVLgOjR7YnY7XP3aeaStDDSoPim8EYfegBBg0CziSJCwzCmkEFVezJ52zhaXMrCQpUBxHVT/s6WT1/platg/yoNro82JAdO6+kaoia7fmzb/bjie7UGVI97yN8XEPJJ1i6Ic5BFXjh6hKA0OmYchdY1a7qWEESVfpKks9PuY42OmawqrPq6XRcgUSjCRtLdDFknly66F2luLAPPIO2e6BR4sWXKaogRqJ9YwIzZ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7b2sPbg74o7vk11pYUg/xe/lpQ5BS3jZ0zJm4V/RDk=; b=NJKiwjpSkpGi+0Q/b+itapEuJNMJVuWVsDB/j6P2drK62PN+NryIjrEQhu52zau79fVg0uCV2xLmJWtxWZtyh2gY9KA9/+YNWyiuHD7I9Koe0+a+k7aR0vaSGsJ9TWW8Ufm9UPw4WdB+f5emTO44cu85/mZ8vnLDmkaCIGwtnMOjU8IJure+Y84ZJXkJZMTVbE2bNhC9j7MI9tw3wGCzu57Mc1o/LiM03DaTxbUW1i/VlYgUidq8/qZX8YbmVwNxNmTmjM85rmvd6CcFeaQER/c42iodu8A9SxSgnxwy+1R88Xsr7qR8bdCaJBtHO18WcbvslzBZRJAQOExJyVJM4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7b2sPbg74o7vk11pYUg/xe/lpQ5BS3jZ0zJm4V/RDk=; b=JWiq7zIntR1i4dPcJ0h+5mpw7rAIMwHYrnx6t8WzFUJwqJDxM8d4Klg1ALRp+BNFHN/7a7XHdF/ygaRcLZkcLLyuG8Q9dlq9BLd9ziGgspLGTzCY0u63VyKrUsd2/ytDzg0M707XhSVETeo2DS6pQJAs0zCWHo0RoBeJm6vvgFxpnMS691pwMD61ay5QtczNv9WsPw+/upBCMEyTROefraA05Q/LnRPoPNw32WKatxnbvEOAXDFSaTpk83QAuWKKhi/UPIY2rOlS9OTdmSiQoAlpNHoLz7Yk6ph9+rukqNx4FdqOpt4Lb57BfmX4sHx6z1uN0kW1wMA87aoY2EZrmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e938b96-5f56-677a-b127-3f5aaf51f0ad@suse.com> Date: Tue, 21 Feb 2023 12:05:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] x86/asm: ELF metadata for simple cases Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Xen-devel References: <20230220110439.1518972-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220110439.1518972-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9340:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ecade4b-c7e9-4c05-b08b-08db13fb90bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mTEkTX0VHYsnHa93z0fKdH3nzEYGtekCQyUbO9qq9/KwiTO5Iw074QfuN8kd7N6OiJoF3nNvfoUrIxWi+YJXygCYO4v+DTpkD2K3z2aLcxFXtVjQAUFSWRCPLrZVjPsSmZu0Elgnah+ZneO8uV4aD/5o1vutyzhX3o5P8cffvGeh+fVbztMV02TercfLLLJjTVJMfxCW7y3QFm0Fn+gfY6/0jQUlaKwPLciuAcOe7/x45I27AQyrfAujoRqR7KrItyKewFfuze6EbnKIYamf4S6Epr6cKTSi9S/LamyOlIzzFa/MntpiUfTzgQxQkL5Cd816jnErZJ81f6KVCCJUL/AbZE1SThWbPcX9/gKLAHAzzaL6jDH4FBixew47ysZkYMIzfBpLu25YMrjWE/f5FTBTxX3p3VRkElTUbm2OSz+lJpx27Gs4R24wQj6Nmp6l7cZ4MN3YGh8QAfOboLcL664L/bIWtDTjIADq3Bi40Br1a88ku28OwKMMIqajpZqU05sYTDP4gQdyc+Lc4ji5AsigZ5304juKkaV2nGf33kzE3XsIsccb+BFYKWNQM1VHaSVDyN2BGBBiSCFRd3PujZG87JFPCy9vdGyGkS09LUtfzmFV2lXNA/jq/UX3DxN+5+Gvn+3022IpvbTtsQcYyM0LLpSAshGS08vXr5W3jGJ78WoSPqn4nRJQ+cdpgHIfSD4Ar9Okh/m10dXCA2BR6M9HMM/Y+ktHMBBtsPVRYAE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(376002)(39860400002)(136003)(396003)(451199018)(41300700001)(6486002)(66476007)(66556008)(83380400001)(5660300002)(8676002)(54906003)(4326008)(316002)(6666004)(6916009)(2616005)(8936002)(186003)(6506007)(6512007)(53546011)(478600001)(26005)(31696002)(66946007)(36756003)(2906002)(4744005)(38100700002)(31686004)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0RBRmcxcnRyRUp6eCsxWjdVNkJ0Q0grK0pvVldMN0IvTDZpWGVYREFCSE84?= =?utf-8?B?OHVwQjJZck5qUG1scCtVZHl1cVJCYUVIR2h6TkIvRWtCRGw3ODIybjdEU2ta?= =?utf-8?B?RUlkbFRGanZEaGV5SzFXdU1Ed2RxNUhKSlBJd0l6SHZPMitZTVc5UE9Kcy9U?= =?utf-8?B?Q0JlNnpjVWhLRzRhOHNCTHUwNENFdUhYNmJJczc5VGVvR1U5bFo0bk5IWGVl?= =?utf-8?B?MDRNQ25BTlFtelF4K3FIZ2pHbVpiTXQ3ZnRHaDRTTEZmSTNONFVhN2svbGdt?= =?utf-8?B?bzkxNTJnMDllVStaMzVVYWJyaWFwc1U0RWpiaEhWUHczV2NiNWFaTDR4a3Ev?= =?utf-8?B?TWpiWVJGVHdOZ1Y1UlExVkpCbW1ZMy9UbmJOd0kwZTUvbnR2R09ucS9rU1J4?= =?utf-8?B?bnYvM2QrMVg5aGlIbXdTVlNYVktPSHEyMjVOK3FIK0FyUDdJZmxva0tJaklG?= =?utf-8?B?SEFJRlhPV3BwaEI0ZjRqOUZWZVNDa3NQRzBQaEVXM3dkVDB0anp4aTZTaXlS?= =?utf-8?B?aG5TaUhLdm5WSDl0NG00UkNJa3g5WFpwMHhzK1JRSXVQT0VWMXlZQ0dsRENU?= =?utf-8?B?OGhEUHcvUDRIVFRrcFZxT3hoTzJvOGZqMVpnWEgwL3Azd0hmanBuR3FHd2pM?= =?utf-8?B?U0x5cU9JdE0wdGlNN1E3dmo4azA0QitmWGFnMnRqSG5BdFVnbEJUVTM4M25K?= =?utf-8?B?QWFiSHIzdlF0eXVJZ1NDZXFiV1IvdlNid0lqUjc0cFlQOExndWVCMFNYU2Rn?= =?utf-8?B?ODZZakNGTXNzeU9Cb2VlUVFYM3UvL2tNQ3pwM3dhZGpiaWR5L0x5U1JCaExp?= =?utf-8?B?UTduT1YwSzdqUmRyM0RrWXB3T1FvWUVtTUFRVlpQK1hPYzJ4aDNqUHFDMDYw?= =?utf-8?B?ZVpZTkZkSjBpVU1NaGE1T3RTUGVwOGVTNGJpWUNTQWt1VGNVOERtL2ZCeXNh?= =?utf-8?B?NE9LYStOeWMySlhNS1N0TTVoU2llQ2NMVHNWUkp3UHIwcnpyNFdKTU5yaVVx?= =?utf-8?B?UXhuTjRURVY2cU5ZNXEvaHBXVEdqcTY5ejhxaWV6a3hrcEtPK2NWYkp5c2ds?= =?utf-8?B?REhDNTlrN09KY3J0ZGNHZHFPVTZNbWlwS1Vud2xpaGFxUGdJbEVrMGFock4z?= =?utf-8?B?cmJ2N2RLRjkzdzZNcVFJbEdyR3FCa043V0I5YTVnVGRFdytYT2NEMzZ0NXha?= =?utf-8?B?RWRBUFBOVXRoWmtieFdHVXFKQmlFQW1IYWxyV2dRTU9rUkVVcmY5OVorWFJG?= =?utf-8?B?T3hYeHpMTkxOWGdKNHJNeDlFYjZiY0NiY2o2Tyt2M2UvbFFGZXJyZlI4WWlK?= =?utf-8?B?eFVWUjVkVmFjSXV6bHVvbC9KWnlRMU9mbERyaHd6eXJCeURiamVYYzRBVFha?= =?utf-8?B?bldrT0VvT3VGbHdRSVBaZWE2cUp1dEoxOFZEazk3TUVMdGlocVo2NlVFQVRB?= =?utf-8?B?aXJOYzZuNXNDRk81MHhUamZ3UXFYdmhXQ1MveUpkcGlwK0lBbFkwQnJWWC85?= =?utf-8?B?QkhPVkpmQkFaZTl5cTgyU2hPeU92QThkdmxScjdjMmlSSk41TFRNTmpVVjJ6?= =?utf-8?B?U1BIOXF2Nk1pTEhLdWxKYmdyeENCQ24wREozL0U4R0grY29mTDRDSjFqNGp0?= =?utf-8?B?YTVYM0RWODRTcWpXMUtPRlRIWHFOQkxTMUZkWER5bEF0SXhST2Z4OTRHT1N4?= =?utf-8?B?MHEzYzZmblNuV3lQamxqVUZFN3V4a3EwaFVjMm1OdHhOSjlsRkFYZ0dNRk5l?= =?utf-8?B?cUtJeHBsbEl5dk42dVo3a3BFY2hOUEZNQVhlamNiZ25KVGUwNXByR1k2SnRX?= =?utf-8?B?ajFWbi80SFEwWk1VNXFKN1ZmVGRuRmxNVmd2MU5iaHF5RHJ1VUlUcWE0SnJE?= =?utf-8?B?a2xPYml2UUJwckRvVFZlY2NVcmlpR3RmSTlGT0Y0RGlpOVlkOHZPbHkwUndz?= =?utf-8?B?bU5PQ2o5S0dDWThVc3A4ZlNNTWlUM1RqNUdRdzZIM1RkMStnRGVVQjRjSXF1?= =?utf-8?B?WVhaRlRlM3pmUy92dnpUSk5QYlhjWVRkQ3pIaDliK3lWN2VMcVFkZTRGdmlM?= =?utf-8?B?OGkxYUVvb0RyZFQxRUgvUUVDdEZFUXlnSDBXeEpQU1ZvRm1mcDRvb3NNT2Zq?= =?utf-8?Q?r5SO+wjhgfqOhEZShggeaFvsB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ecade4b-c7e9-4c05-b08b-08db13fb90bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:05:39.7810 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qC6ePB/ke0SllpjLL2Ku4Kt5WGmiQ4zmJybO9XrWxu4xKPLBb+IDKvjguLAASxeKOsksnK0q+u8lkhXhPmpIHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9340 On 20.02.2023 12:04, Andrew Cooper wrote: > This is generally good practice, and necessary for livepatch binary diffing to > work. > > With this, livepatching of the SVM entry path works. The only complication is > with svm_stgi_label which is only used by oprofile to guestimate (not > completely correctly) when an NMI hit guest context. > > Livepatching of VMX is still an open question, because the logic doesn't form > anything remotely resembling functions. Both code fragments jump into each > other so need to be updated in tandem. Also, both code fragment entries need > trampolines in the case that patching actually occurs. For now, just treat it > as a single function. I agree. > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:08:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:08:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498766.769669 (Exim 4.92) (envelope-from ) id 1pUQVc-0002dG-5V; Tue, 21 Feb 2023 11:08:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498766.769669; Tue, 21 Feb 2023 11:08:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQVc-0002d9-2g; Tue, 21 Feb 2023 11:08:32 +0000 Received: by outflank-mailman (input) for mailman id 498766; Tue, 21 Feb 2023 11:08:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQVb-0002d3-2B for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:08:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060d.outbound.protection.outlook.com [2a01:111:f400:7eaf::60d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbae7cbc-b1d7-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 12:07:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8782.eurprd04.prod.outlook.com (2603:10a6:102:20d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 11:08:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:08:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbae7cbc-b1d7-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z30V7QMiDnKXkPwEAGKTNlDUE8xJa1GnNJKf5KrWkJaTSvQ3K4r6qmy1ahB2Epjbn/HZpr3GpVrWSy34xIdGI3o+QjwKmGEdypa2aQrQUjG8UmqBVc5ksapkvLPtC0/evTBLuVVi5rZrlpuLTBDOf7gvq9mYzic7knKzTLMjTFuouyijGbxSbv7ZWAV/vMEotJC+TzJdg9YE2LpC0dOZ1pDP8z5Txlnh7lQnUNAxZIDVHfSn0DgphnHBAdY1nbMVe0ZLgKwukQSbHpxJIb/HMS8f3OdhFTpl4R5ru492wLssezHTpC9EAc9aIsatDQzhIfiwTTnfrp5jhCjIvuuRJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HyQhtl55amC85ClUqlqFMX619EtzJopA5hlA96JbDP0=; b=ETIARZ3ZlcU2RwhAFd3dI8UXV5NsOlBB2mvLDGIn53177OM7eabor2sSdEyunQkLhofyohSwnb5u/u44eI/9SnprUDmwSNZSq1PDNADjSd26Vuaee1E6aLoe/p+weqvbOQq0yP19CdyidFZxVqg6NWecmLlxc+MX2b0HxSED4tpCab2VLx6KQi6IwT6HLi/FRLivRUxROUf5mCHK3fnTnJvXYeznc1g5AVSA3r/98l0TkaZS5oZun2Winz4M7xqDxzw3zWpU9+ypc8pJiuFZGZBq/I4GuOrSx1b1oys+rttwM7apl7VxnyhR9DVzyPa6sXsDcYOLtewCbf2iIg6skA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HyQhtl55amC85ClUqlqFMX619EtzJopA5hlA96JbDP0=; b=RiW7OiYUp4XKmzMeNpVOn+iOH3gtHgT1rrtAyZQO3q+fsGg6Q9RPgwr5w3WLPR36aGG2Ageov0fF3gQnSytW4YreybFAoo/2IB8h+QhdTpiEDwWHlrse9fVIa1VSn4qvBtZvOBRSwgv13FY+BmK3zwP60YtbrX145MvNzH+A3A2mUMRNskwsZH3xna62bIxREB6dfKGBSk4YeDnqd0ckC2SNCct0WSt60av0QLSj7rOUh5kPANr+JM6hDRWxsPwFi71Ofk0v8BZh48Ke2p646Ek7j+p2ymEEXwxLRYZybyG/NW/pqnbTLQsJAxMJslqjDczxmMTIjOHECtHDMPyK4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0939d140-a6ba-02f5-09d8-8aea961f5d51@suse.com> Date: Tue, 21 Feb 2023 12:08:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC] xen: Annotate printk() as cold Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Xen-devel References: <20230220131325.1524786-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220131325.1524786-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8782:EE_ X-MS-Office365-Filtering-Correlation-Id: 87eb3930-b57f-4abb-3fad-08db13fbf4d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AHDT70pTN/Uo0DVUd2F4lksOnRS3H+B4GbmI1g0YAO33Ut9tpNmmEeZuVh6igD/kCPGMYzVF+cNj0qkwoTGCeojPljmXUOKA2Jj82hbqnq7QD2c8eppXVI1hRQ7JrIr9t5r+QmAvTObIFA91uOB4qUHiskyWuZIsacVfPqhqE9D62iWb8/m6eOFHvTmj5buCRojuGbUyQHaSBxnk3VGZ8PF576A5FNvRTWDBc10Udq+9mDSruHgT7aawEiEtYeCORwRtr5I2TWDdqRA1NqBUM2tG4XziJBUZOgoNbOkhmibZPXdw9Av05kP1MgpdVbTRgHRPneoZO9f6gqEP3aBmbv3oFRg4+pdpLzFigMal33VyGwDKu9X0Q/o6XJgnEi8SdfujTz06I00KdGA8gVK58eQGdVS8ew0qwNRH5BLyLu4kMIYpaTRM7a5S7DMtZrECv2bP+9jANDwv1g2aC0emav2b9fAv+HCiid06lYsVmeqOK3bJeUf/8tVM+PaPdphsMrZiFP8NAVK59AUrTI8NbmT0ddRB0Qo5dl/J1LcEVBRKf1SZWl1erfDJA4V1iLKh0SaT1JUJZiuURsglm/XmGTlxBlkylgEKH5udz2ITfCIyk9z1HuFmLcuDLfDiCTFBLkSzPEsHf4vfkmDxpeRZulBedgOMwhReiH3QIyLlqixZcwXbPfSHwRFEEh89dz9E1LxieVeZgZc+JVIps3s7jj9jbztQ5vV8lZQai21aHFh49PduUDuPikbpXBcTfT9JkFJKC1A5Ce5rrtDbLseFM/gewotvVNpCkMqobr8W0cs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199018)(41300700001)(186003)(6512007)(54906003)(26005)(316002)(53546011)(86362001)(6486002)(31696002)(478600001)(6506007)(36756003)(2616005)(66946007)(66476007)(66556008)(4326008)(6916009)(8676002)(2906002)(31686004)(38100700002)(5660300002)(8936002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ditvQTZnTEJacWdzNUJzUU9lNG12WDVLekxkSnZNakhPd0JzbS9RZU9PZnVL?= =?utf-8?B?R1pGRE9XbGdiUDgzYzBLVjlScHk4VUc4L21CVHgyNUEvY1Vqbi9qa0tHbjZa?= =?utf-8?B?WlJYNWh2NlgwVjY5ZTJoSTBadDZ5Ujd4MDVrUTZZbm9INk5rQW16ZkRFeU96?= =?utf-8?B?alJFb1VpOW82MUVXbzNsRnNlU0pySGVaQkRINU80Rm8xYzdRSG10SStyUlhT?= =?utf-8?B?dU9vU0FVSVpHZnNMd3VIbUpKTURYWUh3RmtzY1diNG5yczRPbVBqWHNObjVs?= =?utf-8?B?eVJDTGRSNWM4cG1ML3cyRGlETWRlVVU2ZGNWUVFKSkJiaE9uVi90ZjlKTVk5?= =?utf-8?B?YmZnenNEc0QxOG9vdXhUR3RucUtxekJ0dnJQRVBuaHZMYUtmVGlFdUgySmF5?= =?utf-8?B?d3dFbWZLVDcxa3locDh3WXFPSFlXcStWL1lvV3FtTUpFVDJiZmc4dlNvdlBx?= =?utf-8?B?dkFDcURSV1VnamdtbnRFVS8rb2ZHY0h6VWFNVzZHOWh5K1pvTkFzTzIrSlpH?= =?utf-8?B?cURaYWNLOFlzZStIem5uOEdSZ3loUFhNdHU3Q0h3ckErNEtpNHFRYlQzZ0pY?= =?utf-8?B?ZENHdHdFTm80SHFCaE5XWExNUDhkRnhVRHBJU1ZwTmt1N05qQW1QS0lyRm9V?= =?utf-8?B?Wk1CSlZROXJwQUNDdGJMNnQ1TEtUVWlkZ2QrNURRSExVTmd5SjNtb1UrVEx2?= =?utf-8?B?WkZhbFpUYTh2M01lODkvempLQzRQSVFkM2FQcnIvM3E4d3M2MkhEaW5yWFdx?= =?utf-8?B?RVNoYlBSZTc1djNaU3Q4ekhXSnlOY0dUS1l0dzhJMVRteWhkaXQreUlSekNN?= =?utf-8?B?K0NIUXV2T1g2cWs0bWdFS0crVXJLS3hoSVhQT0c1Q053UERGWWhvaStBM0gz?= =?utf-8?B?Ylo0T09ubWFzYjJxdDBHdzVVRmFjVktVbkpLZXR1MzhvTDNWTGc5MStpbVJj?= =?utf-8?B?Z0krNUJ6K0tyd1N5ZWxQWWRNVGd3ZWxCSWJrMXRoUVd1eXpPR0N4OXhuTEVP?= =?utf-8?B?K1p3Ym5GU05YQjV2a1FBeG1qdzVlRzRjWXZrTkVld2R2Y1h6NU1qLzhsTTFQ?= =?utf-8?B?eDgrdmRicEJOcEFlejlaK09jYlFoOTJLNk4xZ0QwZ3Rla3NkYXhnMlg3b3Mx?= =?utf-8?B?aDJYNFM3eHF5d1F5a1RldEJJOXZPdFdtRTg4Z3lIWm5BMDZQRHdWd3NpbGFm?= =?utf-8?B?WWMzQ28yR3d0Q0Z4ZDBFaVVIQmN4eGVmTG9iYWsvYTR0eXN4SGtJcEY5Z0VS?= =?utf-8?B?djllaW4zVTJ2VWdtL2pNOTdTdmJhU2pieEVUTEdob1dKVGMwUWVITWZnVFNS?= =?utf-8?B?clNtTmdIYlJ4bGlYSkFpOVYxdmxmSjJ3TXo2QmxpakNJbVV2QUMxZ0ZkaEp5?= =?utf-8?B?aElEa3ZmWG0vS01NNkdKZWRZUjJUSEp4MGZqOEVFZ200NEVJbkx1T3RXVXoy?= =?utf-8?B?d0laRDZPK1o4SDJvcGJjUStFVEswVkp2aEh5NkNpYlJCTGxIQ1Q3N2tlM3Fs?= =?utf-8?B?dXpiUldWQkRTM0RFT1I1RW85MGIwN1gvMWRMTHNVTzJEZ2c5djNoNGNSbk95?= =?utf-8?B?clZCOHlydFhUU2xPMU51cVMyelNPSlNNU01CaGc4SG1ESUtyMjRFNkFOSE5w?= =?utf-8?B?YkMzbEhTRVNwam80U01ZYmFBWnIrY0ZySkU5VXhMaklMcS9KOFRYODFCbVdo?= =?utf-8?B?MTQ2a29FWUQxVXhFZ1NnYUhmdnFaWThVeTZSWHB3ZVhxWW5KTzh6NTBlSEZl?= =?utf-8?B?WFE3Q3JBSjVIaXFCZjVoU2d3UGw2dC9ROERBVkk0OUEybEkwWFNTaFlUYmRB?= =?utf-8?B?R0FOaGFESm9vVDRKaFJVcTh6WDZNUkFVcXBLRkNCRDdVSkpkOFJaZVlVMVNn?= =?utf-8?B?ZHlMejFvTlo1aE9scDlaSTlTeWlTaDBPTERCbnNHSWFvdVI4TE5STDhKMVI3?= =?utf-8?B?Qlh6SVBMa3dSNkFYR0pmc1hheXJTL0p1OStFK0ZDZGRmUEtONHF1NEdrRHN4?= =?utf-8?B?WmlsTHdpa09SOVl1aGlOb1hqbUl4UFhOZmQwMFBjQ1h4aTl0VFdOaGtwbWx2?= =?utf-8?B?bkVsQWdoZElHd0xBUnpYZ2VEZURJY2doRURwT0YyNXV1aVI5ZW9QY2NmakxY?= =?utf-8?Q?In7yGdqpvUA8j9laIY1YIwA9s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87eb3930-b57f-4abb-3fad-08db13fbf4d4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:08:27.0201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gmgDmYNZuywOq2xJKp7EWAWE2OVXS67g6mtSbfjtFI3AYCGgPE7Poo3EAti0SxUISUesYkIOhi2FiKMtOtRsGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8782 On 20.02.2023 14:13, Andrew Cooper wrote: > There is no such thing as a fastpath with a printk() on it, making printk() an > excellent heuristic for slowpaths. > > Net delta is: > > add/remove: 595/2 grow/shrink: 56/762 up/down: 70879/-87331 (-16452) > Total: Before=4085425, After=4068973, chg -0.40% > > because cold functions are optimised differently. For example, one function > with a particularly large swing is: > > vmcs_dump_vcpu.cold - 2172 +2172 > vmcs_dump_vcpu 7030 408 -6622 > > with a net delta of 7030 down to 4450. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich > There are other functions which will be good heuristics to annotate, but we > probaby want to collect .cold together in one location rather than having them > spread out across all translation units. Doesn't the compiler put it in .text.cold? Or is that compiler variant and/or version dependent? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:12:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:12:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498774.769680 (Exim 4.92) (envelope-from ) id 1pUQZ4-0004OJ-PX; Tue, 21 Feb 2023 11:12:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498774.769680; Tue, 21 Feb 2023 11:12:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQZ4-0004OC-My; Tue, 21 Feb 2023 11:12:06 +0000 Received: by outflank-mailman (input) for mailman id 498774; Tue, 21 Feb 2023 11:12:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQZ3-0004O6-Mj for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:12:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20602.outbound.protection.outlook.com [2a01:111:f400:7e1a::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92690cd5-b1d8-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:12:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8477.eurprd04.prod.outlook.com (2603:10a6:10:2c3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 11:12:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:12:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92690cd5-b1d8-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHNY6iR5u0QieUSUehsOeFJ0uh5J34GQ8XPxj7XWuFbLqAQ3faeD0RT7a7zpvKQKg8G47W4NOiWuTp71TxsjbfyqKE5uGmu7ecbs0pj2hlabDIh4z5Plm+ieAM8IuDYAuqT1eLpwoG5j9VH27iLqxRSwlXnO1zozQT25B4yBEPaFUAPaoQN4dW0txfiRZVNORp/Wx/6ZQ0M2Y7tgTHA7Lbuvn6QYm+hftKBBnd8oZz2rhgwcSwnM9AElt0vAkLVYar0fmtziaPvUFZGeSR2ADY/zgfTlaXIdYnnHt/A+/cEaK76BxGMD7Zl9tatI49j7rsygwZ5PMkSufXlBE8Ew7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slUQ2bLp9MqEYH5/EwKWdF1TzdAfLs4g00vpbimjalM=; b=ITVkqIg8sbkY/4tox0pYUSlvHGXwcaag2b9IkSOccnNJSpu8cPQ7lYm6zbANRm5Q33nnnGMe/OUcHNcXcKXwJLS2Tk1is/7jcMdHX7twhhfh5BU1ldGbv+kPO9vo4WBPbxvHotVj1pHDQDsfSvo9EYs/cAest+8GbE9Cyv2wb6Qnrq4FUzxfjqNp0QcXlIQcQZmmZxU3vtu4fU9W00VlpqCLGjp5MzPKhfWyNZVXOQ6JANXNAJnaQLNP0jvuCP7ho/C2QrNoCSJ556tPXqxcVti0ne9QgGoY9QZbsj5+FLD1lPfRgx9UCHrwWncf9jxt0iYfop5QxBXaWILLid6zIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slUQ2bLp9MqEYH5/EwKWdF1TzdAfLs4g00vpbimjalM=; b=VoHcYTDbJGsLs02vzy2TTgulO/BVcwWxAQJlqq5cx3SdlbHzTFSR/IUJcTFPdx12jxPf1gDnOqi3D4EHKrFMNp+091nlvivtYkIsWRTypzzD4Qv9jeOPqZ/pmmHXPZpzb9elhQ+i+AdX1R1HgsWyp5q02eLxrFgst2i+Rmxduhe4tPcB/r0W3S1R7B6Rz3CJfTjyWMHOCYF1/IATrsQf2NK3ZjyQkEAeO5FlKOq4WynnGC4WhnD66xWPpI2kmtfYm3+vJeUGA+MC8Z0Qe+vEe1htIcAnxKyEb+k7Z1WEOLwSIXae8GJKHJ5v9Ru5FghxGMS1onGihRjXkmADTyf3vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <12c71fff-a27c-36ca-992e-1b1d1c075c4b@suse.com> Date: Tue, 21 Feb 2023 12:12:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/4] x86/svm: cleanup svm.c Content-Language: en-US To: Xenia Ragiadakou Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-2-burzalodowa@gmail.com> <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> <936cd14b-70b8-0c28-3aa8-85e5b3f2a8c9@gmail.com> From: Jan Beulich In-Reply-To: <936cd14b-70b8-0c28-3aa8-85e5b3f2a8c9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8477:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bc788c2-02f6-4717-ce3e-08db13fc75b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mrJCy/4KdZgrn7Rk9z0FcVvLtlHHxkc/7jJvPYbQjEPQmM9gzxHI33iZ+DMvJyT0ffnGwL1k1j5OvCs6HdprPYPVkQU36G9OhKnfjqz09wbTatmdefw84jEswVEXxAlLDZRQSqVG5ENOAMobbgvvSSPbUTFlMa2q72hz7ZlQZoJo9qgiXPW0E5LS9fBI+09oQCKGxihuOQSrG0hq6CXP7WJ3O7DUGEcdtPhlZGf2BuaKNW5AoQRB1KHV+fbRqwgdsR5UfBMHkBSo+GCkvQ2N6VxiziamHejX3s0PtBfWQzwKwyHwDoPDBBuGizGZPtpiz8c5/rzv7JKw6Akv2bM/nZDCveJSSx2fK7KYmZwnrp77eOiO+6A8tq89FsOVz6wJ5VPBUNTjYOmzHLDPh5mveoypHqbB423I1ERV/DLxln/Zl3X2768w2qZGoWkjc1484/320Y8IaAO3sexIt/o4GePIHvbRQIoHRmr3CBJ6cIbTaJOuB9m3bfOpzAZQYELOVezPutfjnoDh/eVMy1zfrKgvAAfbUMFVeNE9KHhRPSzfEpMFYPd6uveS+Jp+1p25ReO0FW6hXX5o1M156T0YxfWsKCEw0dhCPGat/hK2ADeJKBqu0wx8GVtmbscYqn4Xksv+0UjWqxoVyALXREmW8kSxf6nI6CAKm1hp0ZgIG0Vf4Oa0ZTgbxTh7GF2eH+wZA+oM9GW26pBt1kzi64QurHAXAkJ2CV19qll069aPqjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199018)(38100700002)(83380400001)(31696002)(86362001)(36756003)(8936002)(2906002)(41300700001)(5660300002)(6512007)(26005)(53546011)(186003)(2616005)(6506007)(316002)(4326008)(6916009)(66556008)(66946007)(8676002)(6486002)(54906003)(478600001)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1NvVGt0cnJpZCt0WUw2c3I3Tis0Qk9rWnMxdE0zclArMEo4WXliQlZaRzYr?= =?utf-8?B?TFJOUUhVc1RQQzMrWSt5RmRlTEpSOE9jTElRNXRicDh3MEZKSCs0eHVZblFo?= =?utf-8?B?RWVTMGFNb1F2SlV0Tmx5S3R6R2tlWkRMaGtsUDN3NlNjcHNSTXRJczNLTVJG?= =?utf-8?B?Wm9PNnJkOVd3aVNrRmwrOWhORi9lM0RGQ0pTcy81aVQxdHlLQ0hjN3pFSTRV?= =?utf-8?B?UGY0RkkwYUU0ZU90QTFFQm1EblBYL21IWk9XL3EzNXhDNGQ2ZVUvRmxid2ZB?= =?utf-8?B?VWdxV1lldDRSbHpIOTl5YjVDQ25tM05WWGZjYk1vUHlYL3lBZHp6L3gwWVpJ?= =?utf-8?B?MGhCM2c3OUhtTjYybmYxT2NUaitqNDJibFpWUi9RMm00Y1pROUFRQzVSTkJF?= =?utf-8?B?RUhqU2Vkdzdpa1NZMjBCdXk1VjNkYWNtMzAvUlptMWtYalVTaVVTZUdEbC9B?= =?utf-8?B?TlBJTXMvWS8xQjIzbTRENFJtQ09pVkpLNmErWW9VMmN1UFRjSWp3dDBHVFJW?= =?utf-8?B?NHpTSEUxU29ySFFYMDZ3WEdYWDFCYXBjOFczSFdyYjQydHY1b3puZWJqT1cz?= =?utf-8?B?VHhBOXd2R2pTNjhocGFsL3JkbHBHUU5ZR3dSU1picGl2Q2M4WEdVK1lBenI4?= =?utf-8?B?dGljbzFndHdsdGpoQS9KQ3ZybHluUFc4RzV2VGRIK0dyUFR1M2tlNm1JTmJt?= =?utf-8?B?U1NTcCtwdnRodzh1NURVd2l0VkpSUDIxQWRVSXprcWxkbXJOM0tqU3RMYUVV?= =?utf-8?B?bm9NVU93ejRCRndQM2t5MEdjUmlDaDVLdGJWY1NpVDN1bDFBRTdwYXlURFN5?= =?utf-8?B?UDhYN2Y4U3lmb2RqYVZsdVo2bzBrSlVuQzJwSHMrSGkxTzBKcXVSRnFDUXFp?= =?utf-8?B?TTA5eEl4bTMyZVhSQ0hBbkJMVVlUVkdBcWYzemxqVEhFTStMNHV0ZVJJYkpo?= =?utf-8?B?N3pxcEtaUVkyenJ4N0ZMUlF3ZEdVVE9oS2x2RXZpLzdhSkt0Z3J4MjdVTFJw?= =?utf-8?B?WHlEMFJRRU5pelNjak9lNUt4L05mS3hlOVZxbHhxaDdDdDFDOXBReGxObnhm?= =?utf-8?B?UmJBTTZycmc2MWlBejhjOWZadko2K3A3VVdFaEdHQTNTVldDUEZRcDJkdVJm?= =?utf-8?B?d2h4UzczZTJlSS81ZjZBR2pqY3JuVFVUQjRHNWNTQm5hNURoY2tUYkp2WDZr?= =?utf-8?B?YUZMRWFiWmtHYk8wVHVHN29xN0lsaDF5RDRXSzVmTDlyK1NaSkJLdDdINFVK?= =?utf-8?B?dWZKZmNHMjJJVnE1L3RndlRJYW05eEh4b2RmSUsyQnI0WG5OZWNOS01ET1g2?= =?utf-8?B?aHdidis4QVo3SDJiRlplNkhlVUtMM3ROVW1FVy9tbWxSaDZ4dzgrT2tsNE9u?= =?utf-8?B?b2huRmZXdFNZRFYyK0xNSFNGWGZuV01YeFlqaHp6QUtPQ0ZKZGcrZlo4cEpx?= =?utf-8?B?QWIySmtrTnA0UGhIRkgwdExaS2M3ejV0bEFCSVVzUUludzBYSXFoWVpneVZ3?= =?utf-8?B?cGgzWXdvRTg5TERySHdNTW5wRk51amIyYlFjNW1DRW8zQlkxckV2WWdwT0VI?= =?utf-8?B?MDBJWjVMa3RtdVl1WTZWb0EzRUpINHNTRDMzazFtMDhMN0NueDlKbnhzbGpH?= =?utf-8?B?ZUs2cUtLR2w5amNlVEpSREwvRjlpQmVzQ3YzVWpLRU04aGUwSE1JWi9uQ1Ax?= =?utf-8?B?Q1F0c2VvdFV0eGtHaHZQQm56UWtiN1REdEU2bGVZQUJNRjUxVVpjcGNFWXRY?= =?utf-8?B?bExoZE9FeXh0ektDYXNNVTJTM1pZZGxwUnZBTEJBdFZtSTN3Skphd2ZTZG5Y?= =?utf-8?B?Z3hnZFZZWGREMk1KSzh5OTVZZk1nUG1OQmZHcjBUaFkwS0pCVWR5S2c0K3B3?= =?utf-8?B?VUtjcjB1YXozU3lRRmtMTEN0TXA4anNuQ3hlbUd6a0JGNzgwTWowR3FCK1hq?= =?utf-8?B?K3hHa1FQZ2dpUHNWQjlibUYzZmEveE94a1Y5ZVZWbkpRVHFEbDFyZlNTcFNz?= =?utf-8?B?LzN1c1MxejdaaVpSM0ZjVXFyWmRZbm56MlVYMVdGTFN4WTg5WE9ZOWRXcDc0?= =?utf-8?B?NGt1YXRvT3p3bjkwMmE2a0tSNCtjZFJoSU9tdGo2S2xFdWlwQWNKK0pWdTBi?= =?utf-8?Q?UGdlQC2cVNqKawS2+YTOSoaM8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc788c2-02f6-4717-ce3e-08db13fc75b9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:12:03.2260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dgcvziPFbDkJNHxVRrzSy/oj9UkkABt4Qyt+/oBKSVvhmhObRMucOOxoppQoLF+oKocd3C6s3bSTIXJRmYodjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8477 On 21.02.2023 08:45, Xenia Ragiadakou wrote: > Hi Andrew, > > On 2/21/23 00:12, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Do not include the headers: >>> xen/irq.h >>> asm/hvm/svm/intr.h >>> asm/io.h >>> asm/mem_sharing.h >>> asm/regs.h >> >> Out of interest, how are you calculating these?  They're accurate as far >> as I can tell. > > I do not use a script (at least not a decent one), if that 's the > question :) . I verify that none of the symbols defined or declared in > the header is used in the file including the header. > >> >> Looking at asm/hvm/svm/*, intr.h itself can be straight deleted, >> svmdebug.h can be merged into vmcb.h, and all the others can move into >> xen/arch/x86/hvm/svm/ as local headers.  None of them have any business >> being included elsewhere in Xen. > > I can send another patch for that. > >> >>> because none of the declarations and macro definitions in them is used. >>> Sort alphabetically the rest of the headers. >> >> Minor grammar point. "Sort the rest of the headers alphabetically" would >> be a more normal way of phrasing this. > > I will fix it in v2. I guess this can be adjusted while committing, seeing that ... >>> Remove the forward declaration of svm_function_table and place start_svm() >>> after the svm_function_table's definition. >>> >>> Replace double new lines with one. >>> >>> No functional change intended. >>> >>> Signed-off-by: Xenia Ragiadakou >> >> Acked-by: Andrew Cooper ... it's otherwise ready to be committed. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:24:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:24:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498782.769692 (Exim 4.92) (envelope-from ) id 1pUQkW-0006Ap-TD; Tue, 21 Feb 2023 11:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498782.769692; Tue, 21 Feb 2023 11:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQkW-0006Ai-PI; Tue, 21 Feb 2023 11:23:56 +0000 Received: by outflank-mailman (input) for mailman id 498782; Tue, 21 Feb 2023 11:23:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQkU-0006AM-Ro for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:23:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7e1b::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 223d25f4-b1da-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 12:23:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7908.eurprd04.prod.outlook.com (2603:10a6:20b:24c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.14; Tue, 21 Feb 2023 11:23:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:23:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 223d25f4-b1da-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItxMmFUrGilg8cq0z2VAOdVxmkLS9pKhEllcK//X7RfvM7FIGM+qNgPZwHl4dnaA/kakd6G3ARs6JUFf+xJ0MDkvEsNpQB3/KeCKPEEygr4Ht+sJAzco0qQvD9agHo9i6Qv6Kt5LwvfvThcTKLYps1ddR3MirdY2swHLXrLFYVFqSNDpdu/DW3izDDjtzF/vGlcUaVAyEpcZbMsVx80rLRx6e44ENSWvY6IMeANxg+UAqc9Mc9QAToT1mQ2hstVDp1SMxbgZRuzBZxKEvqWe1tn0+IdDOeiqdn7otdJLtxRuPKRnXo2kF5gtrCNIUv6Wd9TKZJEbEQTqniulSNOfvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQnlsk4Sloyu17UrIscbTr+TpVR3sIxbK3XeT00I/AY=; b=L7Mx3YJQxcnwI4dFT0qUbr/uJK3jEpdE1PJYV3wFsROSaMggKsAMekb9FDaACBrFpWeuxjwz4jOhjOi1ULONdrwptWxs/YoRKv0V18tSgOaNgxzYk0kkoFKtvm5HqZkJkUJdAGPoFphzSXAw0eBY4hMZIOyGZV8kK3XvQwUSOMYunjgXIWzwJErnSiuQ46SMeRR6z8f5+5R9Nteq03G81Wy3OtzQ67urXKjWuvjqFIbDNSJlVIH01z5uJ4bWjBv26/Q76CuxhS6nWYZjG0HnqMajE8LdnwBZysSDXTa/haL++xRP30MpjYj/65LCMOIJVfdX41czuoU1wqgIuBXtng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQnlsk4Sloyu17UrIscbTr+TpVR3sIxbK3XeT00I/AY=; b=seiGxQpw2JlCyYbXAvmhSBHdz1vZK2SwcV7Xo3QGFg6ooeGgA3IXfM1mUHP1mFTvtTwsrjh1G4YT4w6DiwJn/QLwvT5fpQ98hJLuuBRrGpbZh8Nj4+VoExbfiqqhG/Lb8Ukk7UAX9ZCLrmgaQ9EU/i0KK7NKnA+J/gNgs51N6bATs2hGHq/Hf/7yxFxVOhMynzT7dysl2MRKN78v8SmLCrlJgP+lsTE5+XUpbzuFxNKOa+u7yWUkOoOO29PCR9i97aSvuCM9aVpHvHUeMahytZMBOJVMFohfYP656hUCJPMrB1rTAMPGYS/s0iYfZSr9Is6iWzS4hJx1Ft/f+h5yxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <236c784d-e128-c35c-3c95-9b4dda08804a@suse.com> Date: Tue, 21 Feb 2023 12:23:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/4] x86/vmx: cleanup vmx.h Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-5-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230217184814.1243046-5-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7908:EE_ X-MS-Office365-Filtering-Correlation-Id: 43c12d5f-6aee-48bf-8ac8-08db13fe1b58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OzebrCSPMnkqLA73cHIK2KfH2n12MQ8RHoL5lozX+FFpy//bFxPyFN6C6onbXSlKWAjjLMSws7MIV+zVa9EYAjY/neMPrjBm6VHgx8mcMQpxT++NtyZDGbdQspzhi3kKNObeSRQuhFif5suTg9MMTiapFEhZCZWuYTp66eRCNsIWkUUojNeMOqm79jIe+k7PAAJEA2q21oK693tNI8kg22o+jZOZ3J9bZuOg9zCa8uW1rBEvW8NsV5/3O1m4PXnpoyUVCJOWayJ326bYT2S/ghIjcun1wv9EA+n69C0OsRft5lIcPnQ4/ugEkVkO4aOqPPi0ENKjvCBDh2Epj6MzYsJNoNFW/2yturi7ihUvT/7UpGzOe+Nu1dxAPOz0MhiYaFULQdH6qOu1flWri66/eHjpm23OPhr4QnHR2SancQzPgXbQ1N8Ou/0IGUdNAWeEyX0IzK4aHf+MVRkS26BTCuRnz+tKSBguQc35MbCw9IshDMts6Ccd1qCrqVHsPeT0XPrtSJErv4NTADQXZdwkIU/e4K/DDqI41dAhljMn/PFvdHG62ahWdecdRjy9+jDMUObjdszAwneHnCGJwpEUX7et3RH9EJVztzDXB37E2rSmh/yye2YhtXCXivUlNi0ZIJOhMqnX+OXeg5nFUz9qkpdJUoXHf8jPJ1Zm8obj9rK5tvHYEEgAGO1jp4pV0YKmSHt+HdvPXnuePeVPL/ajC0AXooWxunbh2PGsuSSdCtGnVaB+Bn039N/rhzjqCe8gj5DWFQtKVunvSdekGWPaadJy4Lk+RYk3T8TiFOy/Z+g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199018)(2906002)(6506007)(4326008)(8936002)(478600001)(8676002)(66946007)(6916009)(41300700001)(66476007)(66556008)(38100700002)(5660300002)(31696002)(86362001)(6486002)(31686004)(316002)(83380400001)(54906003)(36756003)(2616005)(26005)(186003)(53546011)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzlCa052YitxU2ZPVnBjbzIzMGtESDJUdWIvYjlnZG1YS3lrZjUxY0tnYnFR?= =?utf-8?B?MEVNZEZBZUNYWkN2bThiRUw0aGFYRTJhRUxkOGpCUE1SaU5zZ0hwVjdCNnNh?= =?utf-8?B?b2tWaEdYMkhZaVdtMEp0QVdlT0lMK21mQjMvY21lWGNLdkNmdG5WMm1HSXUz?= =?utf-8?B?aVJYRGxEUlF6MXhBT3dMbDJqNWFsb2VUeW1zSERwRUEyL29ZRmIvNi9CV0pa?= =?utf-8?B?RDBtTSsydDFZMXM4Uk1aR2xWNkthQ3g2bHVndkU5aEphMmdyZnl1UHh6Tm9F?= =?utf-8?B?V0NtSis3TmIwMk03ei8wSEwyNGh1endtQzZzVWl5UW1MOGwrelVManBPL2RJ?= =?utf-8?B?bUcrNHh5NDNROS85QTlHZE5IQWJDQmFmTHZCLzVVZEtZdDUzNU9XbzY0VDRw?= =?utf-8?B?T3ozSFV0QWdmc3JEcThybkdJUHlUQWp6VHcydXpFZGJHMXhxZ1c4TnFhZUpM?= =?utf-8?B?Vlg3ZWtNMEdsdlZOeEJjdFhwYU40QVdCZTF6aGxmTk1yMU84R3pEMHcrMmtu?= =?utf-8?B?K2hjQ0Y1VjZYQ2RqNFJ4MWVOSU9mWG9wSjY5bHBmY2N0SDZJZnYvdGtOcjFa?= =?utf-8?B?eisySDhwak1PQ2ZVRm15cXRkMk1NbGc0TDBWelY0WFIzbDZiZlk0cDNaOWVO?= =?utf-8?B?d0N5dWwzQjJoYVRkazM4Q3FyNGtIdTQ5V1ZoNGkrcmkxelZFeWNYVitLNkJ4?= =?utf-8?B?OXVuTHdmRFYrU2JleXVwRXlkL0w5UldWRTAvMW5qaGlvdWVVWklXL3duMWZh?= =?utf-8?B?NmpzV0R3QzVIUW1lUXRoVzhNUFA4c2l0SEZSUG1Od0owNjhlU1dRM2tHTWtx?= =?utf-8?B?VWRFNVZ3QXN4UU9yYUI2WHpHS3ZKYVJZZ3dxdysxTUFuK0VjcXFOSDd6aldR?= =?utf-8?B?UHNkS3BZWEU0T2pTM0RPRWRQUjVqZ094bTZQeUxCVWxQY2llNTY3aDgvZy9S?= =?utf-8?B?SGwvcUh0WTJNRkp4T3o0ZUNMVFFwZHpiUy9sQzRIUlYwM01iTmg1a2dkWENK?= =?utf-8?B?ZzZHbHR2amFkanVtV05OdnhYa1NlaFNRS0puc2dKRzc5WkRTdk81TzBINFhr?= =?utf-8?B?MzNZYm5WTEFvY2V1NjlMQk5EU1NXZXpQcUxZS3BWTngxaFlGVjFuSm4zNmNM?= =?utf-8?B?ZlE3UE9XQzd5Z1dyc2tGc1J3TC8vamFFa2VLNmJDZ2F1cnkwMWlkWUhCcGVQ?= =?utf-8?B?RGVZUGo4V2VIR0hyekZlUkxjN0FEc0srb1Q1Z0pwUmRKUWp5R0IvbGs4c2Yy?= =?utf-8?B?V2ZjazI0aXFtQ3FrdVVDZnJjMFpBNERrUmZ2Q0JjY0V4QXFSTllhVERueE1O?= =?utf-8?B?ZWpZS3huOGUwYjVUaVZMa1gxUjM4QzhXeGtKNFgrUlE0L21jSE1ScVdEdlJ0?= =?utf-8?B?WmovWkdHN2JYL0VzS2FmM1IwQzA1Q3dHcEZZWGdZWWRwQVJpVVFzbWtiOXl0?= =?utf-8?B?WDZFYVY4ajVKWkJpNEVYNFp6azVnNm1pT2Q2MnBDZm1IWjJqMkp5RzlTem5v?= =?utf-8?B?cWFsaFhEV0k3Z0RybEZsZmpuem5zMlp5cVJNcFJ1cGNDM0ZYSFA5NHc4V0J3?= =?utf-8?B?anc4V0hka0krQ3ZMSFZFQldHYUNRRFZza1h2WUdMeW93Ylc3a0ZBUktwYmhG?= =?utf-8?B?eGUzS1lXS0NPdlYrSkd6MVVIVXdrNGZBSVFYT05mZXBuNkM2ay9jbzd6L0I3?= =?utf-8?B?SUJzTzJ5U3l3czNUNGdna05LVklLMkFrL0RucktRZDJMbFozaTRGNHFJanRW?= =?utf-8?B?bmZuZCtyWGx0QzhjZUNCV3g3dlhCaXlyTEpxUWNzcGtLaStyczhUaEhHTmFK?= =?utf-8?B?Q1NqQ2FqaVJDa1VQZDRuTTV5OEo3SVZUSHdvcTVaSi9JUXVnb0p5NHErUXYw?= =?utf-8?B?K1ZiUDFsQnoyNGtCV3c4UDUzRWVyRlJqVVJGdXdlRllKSHlyMUxJWjBKTXhz?= =?utf-8?B?blhieWxtRFdEUGIyNmc0VFpmeWE0MWxTKy9YblQ5WUw3UzlVTjlwcWZFSVlu?= =?utf-8?B?a0pNU3IydmJMWHoxSGRISHA3dTcyNmtxdXhBeHVkRGlRR21rSDVDS3FCVVAy?= =?utf-8?B?SmJBRlV1NnFqTUQ4STZHeVY1YVljV3lQUFU5SmpBWG93WEdNenpxeWw2ODBj?= =?utf-8?Q?tDBACivvoF7CQtjK8Ej66erHA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43c12d5f-6aee-48bf-8ac8-08db13fe1b58 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:23:50.6028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HddClMT4FA8vR5GhK6iVZcH8401+gxowZd4Cakp/5IOtM6JoDpfBHpYE4949+31JUb7Rmv+Dxz3DU9L2uDhdvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7908 On 17.02.2023 19:48, Xenia Ragiadakou wrote: > Do not include the headers: > asm/i387.h > asm/hvm/trace.h > asm/processor.h > asm/regs.h > because none of the declarations and macro definitions in them is used in > this file. Sort alphabetically the rest of the headers. > Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy(). > > Move the definition of GAS_VMX_OP just above the functions that use it and > undefine it after its usage. > > Move in vmcs.c the definitions of: > ept_sync_all() > __vmxoff() > __vmxon() > because they are used only in this file. Take the opportunity to remove a > trailing white space. While the latter two are probably fine to be moved, I think the first one wants to remain where it is, as new uses might appear. > Move in vmx.c the definitions of: > pi_test_and_set_pir() > pi_test_pir() > pi_test_and_set_on() > pi_set_on() > pi_test_and_clear_on() > pi_test_on() > pi_get_pir() > pi_test_sn() > pi_set_sn() > pi_clear_sn() > vpid_sync_vcpu_gva() > because they are used only in this file. I'm not fully convinced of such movement. As a general remark: We typically avoid "inline" for functions in .c files. Yet most if not all of the above are pretty good candidates for being explicitly marked "inline". > Move in vmx.c the declarations of: > ve_info_t > ept_qual_t > idt_or_gdt_instr_info_t > ldt_or_tr_instr_info_t > because they are used only in this file. I disagree with the movement of such types. Sooner or later they may want using by vvmx.c as well. If you want to move them, then to a private header under xen/arch/x86/hvm/vmx/. Finally I think at least the individual groups of what is being moved or adjusted want splitting into separate patches. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:27:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:27:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498788.769703 (Exim 4.92) (envelope-from ) id 1pUQnT-0006m8-A5; Tue, 21 Feb 2023 11:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498788.769703; Tue, 21 Feb 2023 11:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQnT-0006m1-79; Tue, 21 Feb 2023 11:26:59 +0000 Received: by outflank-mailman (input) for mailman id 498788; Tue, 21 Feb 2023 11:26:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQnS-0006lv-HT for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:26:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20603.outbound.protection.outlook.com [2a01:111:f400:fe1a::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6683a15-b1da-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:26:57 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7122.eurprd04.prod.outlook.com (2603:10a6:208:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 11:26:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:26:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6683a15-b1da-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNqERMhBMgyPFQyWrMcMQ9yUq809ZciMukTmFWafXtB4lecb0Pq/Yxp07kudmGIJmro/ud30qx/1eClrdACIFrE2X8MrnjFTrlVM/fQathebFD1q9IlFZr/yvVsotJ8IuGlRLIkzRnjh+at7oF9y2xHITqnFCy80ul+7E35OvkTJCVW1m20mi5hfCUMTA92D91UTJCtBsg9rcHrjs1GRjR2sJJwIVkkoqQU7W9JFED8WD6TPL/xRiNjoHf2SW+IzPbojl4X5hYLVzUF1k41FZQj/OvakHZgfb7f8+uFW0/oY55XoiL8PMMAhGC/kOi+SvEZbnuPEZbEjBu9bIKNlvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0F67tXSTHNqaUTkh/QGVMf9NcUn1Xf9/Wcd+ZhxdqeA=; b=Gdm/lYWh4QmEhxYxQGBxDOZofKkH2XcaEa+xNNhNNDa1MmPCLwkNAvOl1uNPVWYZcVoajSE5YkgtIcLv4LxpOT08+XduF3ZKjC2b35K9heyX3bsGRQapoSnVbI9niF/a0IOzlmQVnO8wBGpfNYujtieco7aJG/6tdgCUsJmqUDR5pBu9HneZ7f4Kyg+LD6gSrXEXHBkc5Klg5kFKuTfh5YEjLWdkNBQC6/RBp7BHZSHDVsStRIJp3i0euloLTw6YEBqeRZ1CI8AVOHfTflWQCI1LbqU24z4l0U5fDbBhCu6pjoO+GMUx26SLgYiZ+6yWQMClSWWAGqH5k8ln0zqyqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0F67tXSTHNqaUTkh/QGVMf9NcUn1Xf9/Wcd+ZhxdqeA=; b=lYMzfo1Ke+CI/dp9Le1gyBwN4eiB7KgkgiuNvI7pHjcurDzesMheFpAZT0koLwPYNlQBBDFapDyJ9B5oEUMZj/v7hTEjJ+xV0PVwKjVwz2RezFS56grlK4sbFhvyklNsPtSo3LMxhlqVoaTmtOQbzL+XN9sWR8S8DDLN3u3Ij7YCiVR+YldSlvatrKL1MgxAw8Vmo56scq1slA5okCnelue+FsKsbajaPfsl31x6nLlmRr5ebXEDtqQ6SCS+RaQBOzSrU6v8WX/RlE+2CuYRzIm8CSNdTQgoXwjoUc7CMmUN6GPOW4BFRMlXkU2RFgKgYKWw2TwY/n+CjdF5MKXYqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3477e48c-e6bc-af9d-65a9-c6c0556318ad@suse.com> Date: Tue, 21 Feb 2023 12:26:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/4] x86/vmx: cleanup vmx.c Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-4-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230217184814.1243046-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7122:EE_ X-MS-Office365-Filtering-Correlation-Id: 75bda6d5-fa6b-4cd7-9cf3-08db13fe89ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iyHiKg3eA0niTi6O2J/FMwnk+1Iq/tpH4aCCcpbt7K/of3hNKugHcZafNVMlTxymvMVVTnN9JffzofeMww7n0s7nqDErSrR0V9enevn/jvM9UJmvL0k6gHXEhgQ4WzUSUg7RVCH0y1+X8g0a8eBXLNacEQalwbOpJZgJVDDudotcrs90mCKAoPInIaaQATuYtb0qgCHiiP6R2oVydgYu7da9/HPlNXhwRbtn70MaHSW95SvRHM13JAi4YG18tYTxclKnQi23ZEAvsDaxVZxlkURur7nCmv8x/sEKPyTqK4yhn243Kkw7OHlaLEoLIl/WFGGYgImhq4XdqQf1vLuXYxps+jLGNOwpQ0XVwYyMrC7G0i4lBebW2Y7trwzbgZ6jH7wa4rscDsYQ9RMSLMZ+A7cuAMQO+QZAXoistawFQR2Cz7UMnbRS2M8Oirpa11sQL6At5VdNucWURbfI4e+w2EvuRSZ1M7ffQIhSydyiv9tmx8DS0MF0HR9Xx6rcKlA4WtC0rpQLzZ8hLihmkDmmkX9mPPP9HRQHslepDf2kv0k5FMCPVYqtYjY8wKRAd9fl2eVJ+uyks5JfmpHcGisQXOyOd9IXN4srz4VjuMJLxcyFdWTyfXMaPKC5GOmxRKHG4W5yx/ra3cYVuTJwuT4UgJ5+2sCGuDI/SVdxZ8vSeKKyNru5lNtdZ7wbKBFuhTYjAASlglF0+UnBW/FEqp8FM8uiRb/rj49fGNdF8PwpYwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199018)(83380400001)(31686004)(6486002)(2906002)(2616005)(478600001)(5660300002)(38100700002)(53546011)(4326008)(31696002)(26005)(66476007)(6916009)(186003)(8676002)(8936002)(316002)(54906003)(6506007)(6512007)(66946007)(66556008)(41300700001)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekZYd0NzenlHU1VETnlMMGpWSmxGTlloTlU4WVhNdHBpZkhaQWhOQnBwSWt3?= =?utf-8?B?VlhOUnIvUWdxRzc5dHhFN2ZLaHlzM1ltVmtPOXE3bFg0NlZic2NwaE5QZkEz?= =?utf-8?B?QllyNFdlbWFVaytVWmJScDBjYnljZnNqb3M0Y3FXaXJDN2lRcUx2RnhhQUdC?= =?utf-8?B?MERaaTFHVUVIYWI0Q0t5b2NDVVBuSUQyVGhCbDNtaTVKU0ltU29wK0NBSG8w?= =?utf-8?B?Uk1zcjBYMlZjNURlNW1vQ1g5Rm11dG5aT01WVlV5K2MyeGJKQTZOM0lac3pF?= =?utf-8?B?YW5hQWZ4ZzlzMkFWeXplSW51TTlPcXFYTEVWOW15ZUh1QVJFZ09iZkh3N3lq?= =?utf-8?B?TlU5Qmp6WUs2eGQyMjYvaXVBSndDL2JKckJxZ1ZEZ3k2V2F6bWpwdjNPTFE3?= =?utf-8?B?QlRhM1haTDNzRmk1alMxaGJQS3lhTm91eDNKaFlFVGdrMHpOSW9aQzZxQjVU?= =?utf-8?B?UWkrczlhQkxxOU80TWNnNHBEVDJ0QThDRVhxNnZVYTNoWGRKcHlMazVoclpj?= =?utf-8?B?ZDMvdDlGVjU2UkxrTEVuWU4xM001aFJhc1Rsa3BZN3dnNWRQZXUyelBxNXFV?= =?utf-8?B?YVNsNzJHYnpBWDBqemRLSnRQbVBXWGlpcmVDZGdwMUhoZHZnMHdHQjJ3Z1JX?= =?utf-8?B?Z2tkWkVIVjNlckFHS1VnY1lyeGFpUkpuUTIwUXB4R3ZOemNiUXpXaDMyV21G?= =?utf-8?B?Y05JbzVIWFlJZ0VET1RPNnZNd01oQW5DOHpPNW0xcURxeW9BVEFMd25oVXg3?= =?utf-8?B?YXZLTmZoY01jWVlvbGVtcngvVVhzMUhXSkdJR1JCNHhBY2NPMmdNZDdDLzda?= =?utf-8?B?RFNmMC9qQnhBOTJ5UHRydVp2Tm4wVFpDSy92VU1qamJxYmJ3cG44dHBRVk85?= =?utf-8?B?Vjh0d3BqTGFsMHBSY3FtQ2JrUUFlN2c0cWhtTURSN0I0TkpWdDNNWXhaTnFZ?= =?utf-8?B?WVZ0U2xxamRXM2tWLzVmT2ozQUtMUFJ6RjVGMDNhK2dhS1pIZHM0eEd1TjQ1?= =?utf-8?B?U09RR3k0Nm0vcDFpU0ZvakJkbVhONGVUcWlqNm5Wc0VzN1ptZHE1RTJkb29j?= =?utf-8?B?amNWclQzL0lUSVAxSUphbkR1d3Nld25jbHRZcUJrb2xqblEvVk4rZDd2RGVa?= =?utf-8?B?bTdzK1JTWlk3Ymk2WVFrdW01WXRiQ0ZpY2I3WlRrUlFCTFJmRk0yeS9SUDRG?= =?utf-8?B?dENzY3NyT09jbzlLbFdZM0QxWkczUktlY0VZK1k3aDhJZkp6SUhuWVI2ZWZk?= =?utf-8?B?S3hrRGZCYnUwbCtDaTNuVW9wU1A3SHNDZTFIb1IrVkpua3I2YS9MNnF5SUMw?= =?utf-8?B?U0Y0SldzKzkvcG45eXBHWVlXR1EybS8rOTM2cnhmSVM3WklpdXA4LzR1TzRS?= =?utf-8?B?M1FtR2JaUUVZOGR3THBUUWlGZitUTG4zd3NveXNnVXBneHpWanprbGg2aWlq?= =?utf-8?B?c0F1VUZ1WlFkcFlFU09leVZNSzVvdkF1RFZaODY1eHByZ1M2Tkp4UTV0aVht?= =?utf-8?B?anFickl0OEY2OXhtRnNiUlJZYXhBb0Era0NKUGQzNHd0eWdXSi9KdnVFa1d5?= =?utf-8?B?ejJDY29mMnhYU0JDaEd5ZStWaWFZbFNicGRSL05FRDhsQVBPQ05UeHJDNDBE?= =?utf-8?B?V2RBYlF5MUMrcG9MTFpmL1ZvK2Rvc1ZpZTNPZjZDRDVBMUZDRkJxRG9ZMUF3?= =?utf-8?B?aDdkWEt2cXhUc3hXYy9ILzZhQlNyTVVJdEE1MFIzb2lVYStFWDlyZm5mY0Mw?= =?utf-8?B?TytmN05vcEl1TXpUcW9Sd2piNHRHalpzMm9iTXIwMFBycERieUxsWEFadzJn?= =?utf-8?B?TWhzK2p3QzlSbjNrdUR3VFBtWk0yeERObFdMWEFYWklacHB3N0lRM1ROZWZP?= =?utf-8?B?Y283MkNGWmQzNytObjdEN2JjSkZhRjMyWmlFaUV6ZFFQTGpFTEhwbDRqaS9a?= =?utf-8?B?V04wdWxxSlVPd3pDZEpKeTUwUURJUFUyWitIUmFXeGQ2Q2JrUGw1NG5iSkp6?= =?utf-8?B?bFdFdGtCVGt6aXNSZnF1c2cxYXhnYm5hdit2MHVudGNNejVpQlZBdTg2azBG?= =?utf-8?B?MGQ5TDN3RjNQQXVCQ091OFI2eXZzZnZFUDhlNTdyUFc3eGp0bXhia0RpNHN1?= =?utf-8?Q?cIp9facb4ewyc/3AW/0qhddGo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75bda6d5-fa6b-4cd7-9cf3-08db13fe89ae X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:26:55.7006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BBGU2asgVzOBFd3a2iHiLP9sDwn2/5G1QQYKSiq6EbRkzGJleqSDn59wB7tOXwpxMxF0U+qkmqcbcO92Wx/eug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7122 On 17.02.2023 19:48, Xenia Ragiadakou wrote: > Do not include the headers: > asm/hvm/vpic.h > asm/hvm/vpt.h > asm/io.h > asm/mce.h > asm/mem_sharing.h > asm/regs.h > public/arch-x86/cpuid.h > public/hvm/save.h > because none of the declarations and macro definitions in them is used. > Sort alphabetically the rest of the headers. > > Rearrange the code to replace all forward declarations with the function > definitions. > > Replace double new lines with one. > > Reduce scope of nvmx_enqueue_n2_exceptions() to static because it is used > only in this file. > > Move vmx_update_debug_state() in vmcs.c because it is used only in this file > and limit its scope to this file by declaring it static and removing its > declaration from vmx.h. > > Take the opportunity to remove all trailing spaces in vmx.c. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou > --- > xen/arch/x86/hvm/vmx/vmcs.c | 12 + > xen/arch/x86/hvm/vmx/vmx.c | 5844 ++++++++++++------------ > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 - > 3 files changed, 2913 insertions(+), 2944 deletions(-) I'm afraid this is close to unreviewable and hence absolutely needs splitting. With this massive amount of re-arrangement (it's half of vmx.c, after all) I'm also concerned of losing "git blame"-ability for fair parts of the code there. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:35:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:35:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498799.769714 (Exim 4.92) (envelope-from ) id 1pUQw3-0000BG-Bb; Tue, 21 Feb 2023 11:35:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498799.769714; Tue, 21 Feb 2023 11:35:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQw3-0000B8-8w; Tue, 21 Feb 2023 11:35:51 +0000 Received: by outflank-mailman (input) for mailman id 498799; Tue, 21 Feb 2023 11:35:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQw1-0000B0-QU for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:35:49 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccb2448c-b1db-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 12:35:11 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id o12so16308154edb.9 for ; Tue, 21 Feb 2023 03:35:47 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id r3-20020a50aac3000000b004ad745b8506sm3195559edc.34.2023.02.21.03.35.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 03:35:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccb2448c-b1db-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=grGr8FjyLpEbOiecwKSx+QmMcxw3brJvaL15RF60xw0=; b=hbG5uBKD4QWvF+/APB386Q/zkx4UdhJ7+2DBH9+dkWEj0ppU0XwViYwAUqnmwHNFla 043lE9DhX5SMUh5kgUQwJTOpJDVTjv3K+xpvXGg/WZiRWaC3775RxvQaA5P4AwEQ/9J7 UtM8jZ2wqizsU9AeEDO+/GCG+KAYf49HAccJvhq5QUd+Z0woRjzh84CC0qcUohESuRj/ hY51bpIkpteyyIAY+RUXPpGNmRkp5Kq5DOc2YgH2U+aIMV3FDx2s2M9xD0xiPzBS6En1 uE4B9fcChcYSnKBZFZkupSJgG0K5PJMqhGwNflI7s5+Y7K9EZI07rfj1l1+v+Dl96Vm8 xo1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=grGr8FjyLpEbOiecwKSx+QmMcxw3brJvaL15RF60xw0=; b=LOfget5WK16LHQQilmrXWnAV3jmmkh3Ggsxp0HlmRhvNGhKM/rTssjMuPAXtOrIFtQ hz5X9TDKbpRl/CKlHM5cheKKC7QIdLqzaTu+IEeFdn2vpHEYfW376dd5i+EuQX3An2Og TX7YDxd/3bHimIZ8E7OxPLexzwK5kOgalC/wHogdumQMUoW0T0Ky9GtgHDciZBaqKrFO lWxnX/kffKRpXlo+psC58CLuJl2Ds0B5bYFdZwVa64CThusrXF0NWy7pUD0wR9X3RUM1 im6Dqy6cPl0Vlf5DUplEgWO12KUJDrZX0pG7dYMq57lgWdc5qSyp2QhwWGXlRz4wBuTj y/9A== X-Gm-Message-State: AO0yUKWiiE+oTyfzPYDY3KTSfe+3j5XK4r0JHbSsQJl2y2txEwjv2Png qS8sZX03GOj7yi2/3JDxDGk= X-Google-Smtp-Source: AK7set8lRS6TB07A5bgoOcB6Kz47PcMvPomLkymjgWAB/RU4JA8sBzTPSM2+3JFDZxgM5afAT++NGw== X-Received: by 2002:a50:ec8d:0:b0:4aa:a390:bf4a with SMTP id e13-20020a50ec8d000000b004aaa390bf4amr5433170edr.20.1676979347377; Tue, 21 Feb 2023 03:35:47 -0800 (PST) Message-ID: Date: Tue, 21 Feb 2023 13:35:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/4] x86/vmx: cleanup vmx.c Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-4-burzalodowa@gmail.com> <3477e48c-e6bc-af9d-65a9-c6c0556318ad@suse.com> From: Xenia Ragiadakou In-Reply-To: <3477e48c-e6bc-af9d-65a9-c6c0556318ad@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 2/21/23 13:26, Jan Beulich wrote: > On 17.02.2023 19:48, Xenia Ragiadakou wrote: >> Do not include the headers: >> asm/hvm/vpic.h >> asm/hvm/vpt.h >> asm/io.h >> asm/mce.h >> asm/mem_sharing.h >> asm/regs.h >> public/arch-x86/cpuid.h >> public/hvm/save.h >> because none of the declarations and macro definitions in them is used. >> Sort alphabetically the rest of the headers. >> >> Rearrange the code to replace all forward declarations with the function >> definitions. >> >> Replace double new lines with one. >> >> Reduce scope of nvmx_enqueue_n2_exceptions() to static because it is used >> only in this file. >> >> Move vmx_update_debug_state() in vmcs.c because it is used only in this file >> and limit its scope to this file by declaring it static and removing its >> declaration from vmx.h. >> >> Take the opportunity to remove all trailing spaces in vmx.c. >> >> No functional change intended. >> >> Signed-off-by: Xenia Ragiadakou >> --- >> xen/arch/x86/hvm/vmx/vmcs.c | 12 + >> xen/arch/x86/hvm/vmx/vmx.c | 5844 ++++++++++++------------ >> xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 - >> 3 files changed, 2913 insertions(+), 2944 deletions(-) > > I'm afraid this is close to unreviewable and hence absolutely needs splitting. > With this massive amount of re-arrangement (it's half of vmx.c, after all) I'm > also concerned of losing "git blame"-ability for fair parts of the code there. I understand. Let me split the changes apart from the one that rearranges the code. Do you agree in principle? or do you want me to except and sth else? > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:40:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498809.769725 (Exim 4.92) (envelope-from ) id 1pUR04-000147-SG; Tue, 21 Feb 2023 11:40:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498809.769725; Tue, 21 Feb 2023 11:40:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR04-000140-PM; Tue, 21 Feb 2023 11:40:00 +0000 Received: by outflank-mailman (input) for mailman id 498809; Tue, 21 Feb 2023 11:39:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR03-00013s-7X for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:39:59 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7789a0e6-b1dc-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:39:58 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id cy6so10441277edb.5 for ; Tue, 21 Feb 2023 03:39:57 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id g13-20020a056402090d00b004acbda55f6bsm1121112edz.27.2023.02.21.03.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 03:39:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7789a0e6-b1dc-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WqmPUovFgDUxQPlbJvg4n4NrDEAZoHu4pIIoXueWiLQ=; b=ic0ESN9hy+9m5eCfetPMrQato5/Hchj6QXy1L4bm+gIxTwnsZm1oM9+XpCPvRKq463 cVbuFXI1kayqS2i4PvUTFlsKqQjz5AblOdJxhZoJQjTJZJwp5ywtEc7H8OiZj8ZaN/Kb 5bG9BzNq6fiSPpfNHJcu+0/4g0OfwFiWNNjdwkQMus4Qgt5hDLHKYH37SjoEkpUOCfuz jAN6BvW9Q8osMaWfeqWUJHkmbFcJikozpTqCTBcw4F5DdECrjEXPqrhh5zAo4KrkjnvM z9DuMiu73GfgOpmjHXRrOaCWFvfzZtdtzDpMfT2dZL3F6AJrhaw4Vxq0NSDtMjNJsDyl uMjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WqmPUovFgDUxQPlbJvg4n4NrDEAZoHu4pIIoXueWiLQ=; b=yoP/g3ORSaAXM2/0yp3C0rb2/EH82/JG4KEjnpkHgLtr5XUNbj5mgGcRbSX61gPNpl gkYKyyBJikv4yh8EZX7CFNMzwKzaOAOY89EntLita6lUzWbMzUPXAvr3IxUbIAFn06mM PfjImLWHmn4Mmi7eTjWvyD6Sbp+bea+39rzB3XvFb7zPiHD5uIdBiIRd7DRfHCa8LEPV le2jyoDCcKgUPr2VX3jr+iDlitYtpcxBfKYA6RnMeAh5QY1OA6ebVLuZpgViXM0VJoNy YZ1tGG0dM2iVKM2EOHG/ajvUK26GLOTp4bPjdjtkoxF88J7wOEPKjxhLiij+6KmXGEam QAxA== X-Gm-Message-State: AO0yUKWil1T4/9HRNfBOy21XyT51zhPZaKDb2D+zIUz0a4nEHz/V8boL YJ9YJVa86g3ecahNH/Mb2ECcLIZCQ/I= X-Google-Smtp-Source: AK7set9nbuGdDG923HFAQfWNQHolDR23UOWU29Y3ntu3EBM7dTSkRXXYoP7OqXp9+0Yx0MRk+fh+4g== X-Received: by 2002:aa7:c2c7:0:b0:4ac:d30d:c3a3 with SMTP id m7-20020aa7c2c7000000b004acd30dc3a3mr3117250edp.32.1676979597145; Tue, 21 Feb 2023 03:39:57 -0800 (PST) Message-ID: <35502e08-6a59-63a9-be4e-4e0592dae61d@gmail.com> Date: Tue, 21 Feb 2023 13:39:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] x86/vmx: cleanup vmx.h Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-5-burzalodowa@gmail.com> <236c784d-e128-c35c-3c95-9b4dda08804a@suse.com> From: Xenia Ragiadakou In-Reply-To: <236c784d-e128-c35c-3c95-9b4dda08804a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/21/23 13:23, Jan Beulich wrote: > On 17.02.2023 19:48, Xenia Ragiadakou wrote: >> Do not include the headers: >> asm/i387.h >> asm/hvm/trace.h >> asm/processor.h >> asm/regs.h >> because none of the declarations and macro definitions in them is used in >> this file. Sort alphabetically the rest of the headers. >> Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy(). >> >> Move the definition of GAS_VMX_OP just above the functions that use it and >> undefine it after its usage. >> >> Move in vmcs.c the definitions of: >> ept_sync_all() >> __vmxoff() >> __vmxon() >> because they are used only in this file. Take the opportunity to remove a >> trailing white space. > > While the latter two are probably fine to be moved, I think the first one > wants to remain where it is, as new uses might appear. Ok I will leave it where it is. > >> Move in vmx.c the definitions of: >> pi_test_and_set_pir() >> pi_test_pir() >> pi_test_and_set_on() >> pi_set_on() >> pi_test_and_clear_on() >> pi_test_on() >> pi_get_pir() >> pi_test_sn() >> pi_set_sn() >> pi_clear_sn() >> vpid_sync_vcpu_gva() >> because they are used only in this file. > > I'm not fully convinced of such movement. As a general remark: We typically > avoid "inline" for functions in .c files. Yet most if not all of the above > are pretty good candidates for being explicitly marked "inline". I could create a private header. > >> Move in vmx.c the declarations of: >> ve_info_t >> ept_qual_t >> idt_or_gdt_instr_info_t >> ldt_or_tr_instr_info_t >> because they are used only in this file. > > I disagree with the movement of such types. Sooner or later they may want > using by vvmx.c as well. If you want to move them, then to a private header > under xen/arch/x86/hvm/vmx/. Ok will do. > > Finally I think at least the individual groups of what is being moved or > adjusted want splitting into separate patches. Ok. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:42:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:42:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498817.769736 (Exim 4.92) (envelope-from ) id 1pUR2R-0002ST-94; Tue, 21 Feb 2023 11:42:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498817.769736; Tue, 21 Feb 2023 11:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR2R-0002SM-69; Tue, 21 Feb 2023 11:42:27 +0000 Received: by outflank-mailman (input) for mailman id 498817; Tue, 21 Feb 2023 11:42:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR2P-0002SG-V1 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:42:26 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b8867161-b1dc-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 12:41:46 +0100 (CET) Received: by mail-ed1-x536.google.com with SMTP id f13so15419243edz.6 for ; Tue, 21 Feb 2023 03:42:23 -0800 (PST) Received: from [192.168.1.93] ([188.73.238.161]) by smtp.gmail.com with ESMTPSA id n17-20020a50c211000000b004ad7bfad182sm3368396edf.6.2023.02.21.03.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 03:42:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8867161-b1dc-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XL5bp8r8QAaNoeNfuHR79AjlEEXjEq2YSKIfFs/T1NI=; b=QVgOaqfnQmwnobbi+g1kuSYA0pAHQ7F7mVldjEiKNE/C93OIZa16gvyHw1Y7oOoh/h rrLj1R9nrAJAgIkvmi7+wxDteNEJHOX90WmZhELby3qpdj6ICAhLtes4ZLDXxSyDFl71 Gcwr0a8O4/zD0cMqyqowy+cwO1kNFxVsc8Zv28CgQFHJnae2IeBYlP74wb4fzZ4cFlEZ UE8oUnYtswDMJbvNYNCmSp2LCR+o9Of+CN4mf71I/YoQIZ4Lb6pymTXiYvjeB5lV1sAY tUw/lC1gt9hgcoExH9TXKFa8M6A4zeGpVp7usasJBfEB4cDWyBDxBtAvidLC+Qe/s29f PHoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XL5bp8r8QAaNoeNfuHR79AjlEEXjEq2YSKIfFs/T1NI=; b=6mesfGNWYuGpMOKF1Ci/wVnPIQrLYL53b1BTclVtJcKNKSM3OPqKQ9xRkpnwDIaUvF y7DMO1MBsC5iu3NRQ2lUMxHaJ7oiDvqHFdGUa3vXUckEmW+5LXaZlLYY/oo5c2uyl9Zx IrKg4pySWonSxTsft/bcXHe2mSTIzJ4IUjPEJPyW6AgXImzYmlfgCBRRUNUrkZ9XYI/e +wC/lVEr1CQpoKfK1SI9Uz+0DALJ8fve6dhkDGdjQH4HSlwJdEJhjbjDd7F6+zbPIoTp lG75eUD8stfcXSpUwwWn3RfRDDrbwkCHDScxICttOxhoq3PqfHcll0fzJpsV89L4Mq8m Mg2g== X-Gm-Message-State: AO0yUKXHIk6rNIrEn0kAFOIoRFguqZOxc0iom2j+3Gbv17HXMSbdBpWj DgjfouIKHJ8xn5IWzPDw84k= X-Google-Smtp-Source: AK7set802DIil1PYJVd9i1w8kd95YG9BpQW7x+YgIaymIDEEsyn5YBlQit6Bp3Bgi9vgGEje3nMt5g== X-Received: by 2002:a05:6402:4d:b0:4ac:b32e:b6f with SMTP id f13-20020a056402004d00b004acb32e0b6fmr5758765edu.23.1676979743114; Tue, 21 Feb 2023 03:42:23 -0800 (PST) Message-ID: <712f3022-3760-717d-7683-b320fb8dad3e@gmail.com> Date: Tue, 21 Feb 2023 13:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/4] x86/svm: cleanup svm.c Content-Language: en-US To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-2-burzalodowa@gmail.com> <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> <936cd14b-70b8-0c28-3aa8-85e5b3f2a8c9@gmail.com> <12c71fff-a27c-36ca-992e-1b1d1c075c4b@suse.com> From: Xenia Ragiadakou In-Reply-To: <12c71fff-a27c-36ca-992e-1b1d1c075c4b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/21/23 13:12, Jan Beulich wrote: > On 21.02.2023 08:45, Xenia Ragiadakou wrote: >> Hi Andrew, >> >> On 2/21/23 00:12, Andrew Cooper wrote: >>> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>>> Do not include the headers: >>>> xen/irq.h >>>> asm/hvm/svm/intr.h >>>> asm/io.h >>>> asm/mem_sharing.h >>>> asm/regs.h >>> >>> Out of interest, how are you calculating these?  They're accurate as far >>> as I can tell. >> >> I do not use a script (at least not a decent one), if that 's the >> question :) . I verify that none of the symbols defined or declared in >> the header is used in the file including the header. >> >>> >>> Looking at asm/hvm/svm/*, intr.h itself can be straight deleted, >>> svmdebug.h can be merged into vmcb.h, and all the others can move into >>> xen/arch/x86/hvm/svm/ as local headers.  None of them have any business >>> being included elsewhere in Xen. >> >> I can send another patch for that. >> >>> >>>> because none of the declarations and macro definitions in them is used. >>>> Sort alphabetically the rest of the headers. >>> >>> Minor grammar point. "Sort the rest of the headers alphabetically" would >>> be a more normal way of phrasing this. >> >> I will fix it in v2. > > I guess this can be adjusted while committing, seeing that ... > >>>> Remove the forward declaration of svm_function_table and place start_svm() >>>> after the svm_function_table's definition. >>>> >>>> Replace double new lines with one. >>>> >>>> No functional change intended. >>>> >>>> Signed-off-by: Xenia Ragiadakou >>> >>> Acked-by: Andrew Cooper > > ... it's otherwise ready to be committed. Great, thx. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:45:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:45:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498796.769746 (Exim 4.92) (envelope-from ) id 1pUR58-000340-NS; Tue, 21 Feb 2023 11:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498796.769746; Tue, 21 Feb 2023 11:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR58-00033t-Kp; Tue, 21 Feb 2023 11:45:14 +0000 Received: by outflank-mailman (input) for mailman id 498796; Tue, 21 Feb 2023 11:31:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUQrX-00006G-F0 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:31:11 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3940b7b7-b1db-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:31:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 128645C00AF; Tue, 21 Feb 2023 06:31:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 21 Feb 2023 06:31:03 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Feb 2023 06:31:02 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3940b7b7-b1db-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zhukoff.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t=1676979063; x=1677065463; bh=i2ie1WFcVhi5uCvumoVgxqFPz hMCaPOtaACT2Dv2yC8=; b=abSYmEdhvfIoXEM1h3Z+p9zx2omIvHh5XPQcGavD/ buJWUhwaBMUgXgkpGNNSoTSPNifhgJwIZF6qKUtqUTl3vFsMMJwcUwuXjYzpNvaV qtQyKpHMR/wWeeokyZNCk4GlYl7LexW/orRN8DggJXvXLhR6fGiKOlAYtVd2/gEN qyljxfpTcTVAjwb7WE/301hYym4HYRrRgMQ4DKTr8iwO52zmk+7oK3GOh6mjhMul T0faNRQ4UJzaSihqE5tW1NyYzrZhc3MRzu+SPBpr3jDKyyZwCAV4qK1iWe5UNld4 c4v+9aOmTQerRiHglBAYuVMLId4b54f+1FM9xNxG9hlbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1676979063; x=1677065463; bh=i2ie1WFcVhi5uCvumoVgxqFPzhMCaPOtaAC T2Dv2yC8=; b=Lb4rCoUy3xxRetZZPHCUxereLUzvGnK7uwTSwc+uvnx08R0kHnc VyyyRxw/QwUiYuz3qxNU7YjDBJjBL3gMzn9htauqzo/BP5XfXkQl6qAyCtGUuFL2 +Kf0XbUYr6332BxuWRXjqCMeyrSBJ5KCYGslJQOU8JQ1+G9Q8bmI2aN6LuitrUjP JjuFHzzNVaq+MwZU6YRKqw/dx49wJ680juY0ZNzYUUEd76OsOCS+ST6CYEikR5zg alp+XsNf6NakrFpMQNpjLvz/Cr1921smbFX0Nshac6uSu0oAaZo913tGNZh2fjbO w4eQiXuUYfmiLqU7yjrkZGj0PwB4b31VFGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejjedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefrrghvvghlucgkhhhukhhovhcuoehprghvvghlseiihhhukhho fhhfrdhnvghtqeenucggtffrrghtthgvrhhnpeevfeejkeejudegledtkeejhfettdefje euffehieekvddugfdtffffledvvdefhfenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehprghvvghlseiihhhukhhofhhfrdhnvght X-ME-Proxy: Feedback-ID: ib94946c9:Fastmail From: Pavel Zhukov To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, Pavel Zhukov Subject: [ImageBuilder][PATCH] uboot-script-gen: Add virtio loader Date: Tue, 21 Feb 2023 12:30:36 +0100 Message-Id: <20230221113035.5899-1-pavel@zhukoff.net> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit uboot supports virtio-blk drives and can load kernel image from it. Adding option to use '-t virtio' for loading image from virtio device Signed-off-by: Pavel Zhukov --- README.md | 14 +++++++------- scripts/uboot-script-gen | 3 +++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index cb0cb13..64e62cd 100644 --- a/README.md +++ b/README.md @@ -267,9 +267,9 @@ Where:\ -d specifies the "root" directory (paths in the config file are relative to it), this is not a working directory (any output file locations are specified in the config and any temporary files are in /tmp)\ --t specifies the u-boot command to load the binaries. "tftp", "sd", "usb" - and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1" - and "load scsi 0:1", but actually any arbitrary command can be used, +-t specifies the u-boot command to load the binaries. "tftp", "sd", "usb", "virtio" + and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1", + "virtio load 0:1" and "load scsi 0:1", but actually any arbitrary command can be used, for instance -t "fatload" is valid. The only special commands are: fit, which generates a FIT image using a script, and fit_std, which produces a standard style of fit image without a script, but has @@ -339,10 +339,10 @@ Where:\ -o specifies the output disk image file name\ -a specifies whether the disk image size is to be aligned to the nearest power of two\ --t specifies the u-boot command to load the binaries. "tftp", "sd", "usb" - and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1" - and "load scsi 0:1", but actually any arbitrary command can be used, - for instance -t "fatload" is valid. +-t specifies the u-boot command to load the binaries. "tftp", "sd", "usb", + "virtio" and "scsi" are shorthands for "tftpb", "load mmc 0:1", + "fatload usb 0:1", "load virtio 0:1" and "load scsi 0:1", but actually + any arbitrary command can be used, for instance -t "fatload" is valid. disk\_image supports these additional parameters on the config file: diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 7e5cc08..f07e334 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -1025,6 +1025,9 @@ while getopts ":c:t:d:ho:k:u:fp:" opt; do sd ) load_opt="load mmc 0:1" ;; + virtio ) + load_opt="load virtio 0:1" + ;; usb ) load_opt="fatload usb 0:1" ;; -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:46:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:46:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498830.769757 (Exim 4.92) (envelope-from ) id 1pUR6k-0003cW-1t; Tue, 21 Feb 2023 11:46:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498830.769757; Tue, 21 Feb 2023 11:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR6j-0003cP-VN; Tue, 21 Feb 2023 11:46:53 +0000 Received: by outflank-mailman (input) for mailman id 498830; Tue, 21 Feb 2023 11:46:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR6i-0003cH-Po for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:46:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7e1b::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5789bb8c-b1dd-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 12:46:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9256.eurprd04.prod.outlook.com (2603:10a6:102:2ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Tue, 21 Feb 2023 11:46:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:46:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5789bb8c-b1dd-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HevpR9SYzQGTzN7lHC0BHvxnoAGi7Z73y9Urf0f1fhyi4poQk6fcvbtNFMkXiLGJ8Fig2tOzfajQZoGX2RUWRwish2HVRY/L5wiylnzUufwKU5xeRxrnolJ7e7ysRIamfW8Um9f7Mrj1xK834xzewePf4iGJCo2tfvywd630jGJvfZ7yLBJE3O9aYwyX59LdUR1l+fQy7x9Xy5WNoUNqZgJYwgHZ0FjdJHRsJSV1/gxsRB2V+hY2FlHDzGUoQU5o6r503NNLQxstYYzI+neOKYwLwhg9OcO3pbXu2Es/xkU1xhvFee89jTlaTWb08ELS9m4D9rn8mlRMC7yMl7XOJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0eXlZA1QoDOm9OHGtcFI8UbVABcXIw6qHaZQ04e+qj8=; b=j03TJpcJkGtjngs6+6m9VLx5McA4d2PXLDRN5crcuZtAPp3VkSFDxJTqI7bN7py3hLrk29Plx2tQq1G2KyozPVhC1pBqrnScHukstgiMFgpKN+Lj+q7Yog60rr3/0dc6laRhIwsJeOSOUs9iVNaQD8nengDKRZyx8/ADuau20GeL9yb6m1GbmKMJ7gyWCQSHQBNUkg7fBbh8b2iI93JaPgY5cyvkF8xr1xmHFu6+f9+r2YdCQtmOop9MUMglmoNNqBznP+w9wpMV+qLsrymZB1X6dNSF6h21kKWpZfjx5QdIMauNCjKX9AucL99+pY6XyHHxC+wobKe1WSW7ndd2Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0eXlZA1QoDOm9OHGtcFI8UbVABcXIw6qHaZQ04e+qj8=; b=f7Eka1XnIl+J59KDIKrY6HBSPxCXXcBM6+PKloi9IK2lV6nTz/jr/+58Vo+I0lgjoLhffXhW6JbSXK5r/hfEqiw+xC6NMI1C4cFxmo9pH1EKWqxuQpPr380kO+N9QW3zwo+4yYqu0I1vZ4MFINSqE7WZ8XePRh4diGNJgRR8KFk4Sxp2uvkb/38dtmWdYRkGoTK6plOk8xFhsJefu/r8w0jbw4/GGt0876TLBuDk6CZrK1XMtEqHoNuqyIu6GfeF+ZuGK7+61lttrAixvHmnLUwcaX9575wjUrh7kJ+aygdsftU1z0kGu20+cEUZlU0hmTqievn8+KeGsn2pWFtWRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <49542663-d21e-6af2-42e6-bb28397b9e57@suse.com> Date: Tue, 21 Feb 2023 12:46:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/3] x86/entry: Rework the exception entrypoints Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Xen-devel References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> <20230220115956.1522728-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220115956.1522728-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9256:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e58efce-9ad8-4e08-123d-08db140150af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A3eDdudGl7aAJ5mIcGnyqSQmFHT+VS81Jp1pNsaI4qIk8cIX0X7smlZr3233aw43QL+yWFNDmxmsh6jpDMLNR4tOJG6tmZuzPo5RaYwZuDNM7h806f7/CrR+aOulmf3zUMO0DVvl8HEIVn08TlfLqoZdRjaY8F/MTR2xdBRZyruQ9D32F6E6lw/Je5DVcIxZbSxsVKDS2+5zH2WPu5GaWjU8yGQrFqdX0MxZgUUXGMsFml/W25VOuUz14J/Pnhp/S3Pl5NwgDXE6VZrr8OuM0f9YggKg3fu7s/s3sP8aPKOv6gW0nKeDGKaduxIgsEJmzFvVtmXrrhqNgjITP3TETUEE6fIRSPkn0EIp2YtZiZgeMrbN5yLIsZ2AqKIW771UPP9R63f77chQDb/S4Qgeh+PFTRNUe1nR82QmVs70Z3+Gd8cpoNKXBPlZpaH/EYRc+nMKW5yOlxqpRqMULlTfyXL/HNIdB6vTYI+O27qprRVJe6lzAZNaMvALu8ncqQueyKTCNyU0Glw+ibugczCnW1xkvWt4Rjn7T0wb628Kvvdy82vHPbXWba3y1UrIs47lHhrX5FCcwfS8zOfGDLjahnQNtYrwpPBrUmxqituN68RQsKvuJe4c7Z3M7Ia1cu36pQzZO8KRYEYr+gpMmB+UAVbuw07ZbdhxAyqz4E1glFt3DtSc5ZbhZoWW80A7qMhdDWOL7f9gmTNeX1xmkUSS+op+xSohSnwKY0rH634EUTo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(366004)(396003)(346002)(376002)(451199018)(26005)(186003)(6506007)(38100700002)(83380400001)(6512007)(5660300002)(8936002)(53546011)(2616005)(6666004)(31686004)(66946007)(6486002)(478600001)(4326008)(6916009)(2906002)(31696002)(54906003)(41300700001)(66476007)(8676002)(66556008)(316002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDlvV0Z3dDdhTkcvTlA2bndyNU9YTy9ra2VFTzc4eHhnSGZ1dkMxZ29XYzdq?= =?utf-8?B?emRrYWltWEFzRHVIV3ZYMTFCbDk4TzNwcXNMUTdXam5ma2o5Ukg4NHlKY2V3?= =?utf-8?B?anE5REZoWko5aU05WXRFTEZ4ZVdHODBxZUM0UFlCRDd1ajkyNkVjUEd3d0NZ?= =?utf-8?B?dTBUd0lUUXVIZHpjS29NUy9xWis4ZUx5NnB6UTZ4cDIydEIwSGhpa1ZnRUEw?= =?utf-8?B?MTJodmZpcSszbEcvVU9BVDRKdVkrZG8xVE5EWmR5VDdlaG1PVmJZWU5JQVlm?= =?utf-8?B?a2YzVEF6WUtQL285a1BmV1N2UjlBS0dpT0RpcjB0WEFDL3B3b0dmUjBiUkhP?= =?utf-8?B?RW0wbmdSMTd2Zk5aeHd0M1dGUFFhQ240aFgxakZ1Y3hVNmh3Y3plUytyZlVE?= =?utf-8?B?Qm9qYzhSenFRbUZndXZ1MmhyTUlsb2o2aWh2SlZFM04xcWxqWXFpMmRUYk82?= =?utf-8?B?c2ZuSkE2eTBRUW1XWlVBaEhBU2tWWFg5TXovWktOSnplM0VVRjd1ZGd4VHRB?= =?utf-8?B?VXByaE5TQ3I0NEg5SWgrNTZGUlQvTCtjZ3c0cXFMSmJrTDdqTVhXM3NuVXNr?= =?utf-8?B?VjA4RVJlUjJzam50Y3J0V3VGVi93a2lQOFhwZE1vRUZ5K2s4cDd5S1Npb0VS?= =?utf-8?B?d0hyQTlmZXFyNk0wWklycUpnUW9ldlBEU3Vpb1VoWWZ6am5rR2dDYXFUNUsz?= =?utf-8?B?MFlGME1SaVJiWFVQS0l5U3FnRVJ4T2hPU09OWmVoZGRMTFRvTGw0aFU4a2tB?= =?utf-8?B?K3o4cnREelBaOExtTWxlYkxNSFlTNVpxMTNLb05CeWw1SVh0YjVnTEloKzUr?= =?utf-8?B?WC9RUFNRQVEveG92WXBNZTh6dlNheC9LVzRsQk1sZzFFNTdVQXhDQjZmdURD?= =?utf-8?B?OHh0VmtRM3p0YUJzYUE0WWNyNHkrRUtGbUxFa0wzemxwcUdsZjU2bjNVcHhv?= =?utf-8?B?anB3N1ZGYjBjTnMwOVpZNzk4TWd1YXJzOXdDL08yc1lnN0xpTXRJcTI5dHg5?= =?utf-8?B?MmdubTZuRlptcndDUFJCandoSDZDcFU2TUZVV0JaZ1JER012anBkaGVaOEdO?= =?utf-8?B?TnZlaW03ZWhibS8rcnBwRGNvWU9mOU5HcGV4YnFKN1RydjZmNEVBdlAwQkI3?= =?utf-8?B?NlRUZE5QYTROQ1UrdGgzRWZYblJ4ZkxqdkNjbjZtdnVrZHF1SzBGdjFOdW10?= =?utf-8?B?blZiQ1IrZTVGYUxUcW1MbDZiRlROZGhOUnAvVmVUQnVxTXl1R3o5Q0Z4QWxV?= =?utf-8?B?cEZqYlhHTm1RWmFQeFU2V2tuT25yOWp4NHdjRlZ3TTFnOGxobnNDSkh0T2xJ?= =?utf-8?B?M3lMMk5RZWdpM3IrT1VsQURUK29nSE9YTitlVVVCWjFGQXZDMW02aVpRbWZv?= =?utf-8?B?ekM4V0QyaVU0YWpNV0g2VWpDZWR1aVJndzhob1JrREZZODNxUGF5eC9NRUtJ?= =?utf-8?B?TXAzWTlpa1V6ZzIvMkxkQUEweklsN0lLZmNPNEtoZ1paQ0xqTkQyZjdEM2pU?= =?utf-8?B?SWE1dk9WdXg5NDlJcUFmaDFjMU44YWZqazBTZG96UW51d05VQVRlZG0zZTVN?= =?utf-8?B?djRWd3B0dk55K1lyU05VRDFOelZTMlpzbEw2emp6b1dneWxscGU3SHI1VGUy?= =?utf-8?B?ZmNUaHZIdm9xNkVHUW1JRUprWThoZjlYYXQ4Wi9OUWhxRjFiUS9GeWRkMWJU?= =?utf-8?B?d1FWQjZDbFpnNmRUc1A5UmV3TVplNzBXemsyMnhHWVhmNjJGWkdtNlBOa05T?= =?utf-8?B?dTJXOW5sSUhMYStDVm5KSk5ScHNVUDBtUU5tMXpnRUhmRGJoOEVQdkZBYklP?= =?utf-8?B?MlJYSlkzQUJMT3FPRXBsbUtwNCtPME9YOHJGM0J5Q3ZOeEFDbTFaYU1JS2Vt?= =?utf-8?B?U0l2NndFN2laaXNxZ3dKaVlsYnBPU29pUVBrQ2FvcFYxUnhIMWQ1MlBvZ1pl?= =?utf-8?B?azZFVmh0UEJ3UjJzQll5RjJ4WEp3K3E0dFlxKzRlNm9NT2dTT05FdzhBcWc5?= =?utf-8?B?cEQySWhPTGZGNVoyMzhLZ1NmanA0djVoYTZjNHp0OU9CWlc2YnQ1ZC9pVEo4?= =?utf-8?B?eVdYaTF0aXd3WUpHc0txNkNFa2pXQnlMVUdZNkg2QzhPTnorTTN5OG1abmtK?= =?utf-8?Q?fikdVsbtRHYf9LCG91ZMBmxAY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e58efce-9ad8-4e08-123d-08db140150af X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:46:48.5793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eQ7Xw7YxjpXpiZcWJKn4EUGlyObn9XdMsTc8GJxlhKoTSJw42YRPFfFnvzbkDqi3Dqu9eixsEWNx819DkBxdrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9256 On 20.02.2023 12:59, Andrew Cooper wrote: > This fixes two issues preventing livepatching. First, that #PF and NMI fall > through into other functions, I thought this was deliberate, aiming at avoiding the unconditional branch for the most commonly taken path each. I'm not really opposed to the change, but I think it wants saying a little more as to how little (or big) of an effect this has (or at least is expected to have). > and second to add ELF metadata. > > Use a macro to generate the entrypoints programatically, rather than > opencoding them all. Switch to using the architectural short names. > > Remove the DECLARE_TRAP_HANDLER{,_CONST}() infrastructure. Only NMI/#MC are > referenced externally (and NMI will cease to be soon, as part of adding FRED > support). Move the entrypoint declarations into the respective traps.c where > they're used, rather than keeping them visible across ~all of Xen. What about Misra? Won't they be unhappy about global functions with no declaration in any header? > Drop the long-stale comment at the top of init_idt_traps(). It's mostly > discussing a 32bit Xen. The use of interrupt gates isn't 32-bit only, and justifying why trap gates aren't used looks to me like quite reasonable a purpose of that comment. > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -142,6 +142,50 @@ process_trap: > > .section .text.entry, "ax", @progbits > > +.macro IDT_ENTRY vec label handler As said in reply to another recent patch: Could we agree on separating macro parameters by commas? I also wonder whether they shouldn't all have ":req" tagged onto them, as none of them is optional. > +ENTRY(\label) > + ENDBR64 > + .if ((1 << \vec) & X86_EXC_HAVE_EC) == 0 Nit: Hard tab slipped in here. > + push $0 > + .endif > + movl $\vec, 4(%rsp) > + jmp \handler > + > + .type \label, @function > + .size \label, . - \label > +.endm > + > +.macro ENTRY vec label > + IDT_ENTRY \vec \label handle_exception > +.endm > +.macro ENTRY_IST vec label > + IDT_ENTRY \vec \label handle_ist_exception > +.endm > + > + > +ENTRY X86_EXC_DE entry_DE /* 00 Divide Error */ > +ENTRY_IST X86_EXC_DB entry_DB /* 01 Debug Exception */ > +ENTRY_IST X86_EXC_NMI entry_NMI /* 02 Non-Maskable Interrupt */ > +ENTRY X86_EXC_BP entry_BP /* 03 Breakpoint (int3) */ > +ENTRY X86_EXC_OF entry_OF /* 04 Overflow (into) */ > +ENTRY X86_EXC_BR entry_BR /* 05 Bound Range */ > +ENTRY X86_EXC_UD entry_UD /* 06 Undefined Opcode */ > +ENTRY X86_EXC_NM entry_NM /* 07 No Maths (Device Not Present) */ > +/* _IST X86_EXC_DF entry_DF 08 Double Fault - Handled specially */ > +/* X86_EXC_CSO entry_CSO 09 Coprocessor Segment Override - Autogen */ > +ENTRY X86_EXC_TS entry_TS /* 10 Invalid TSS */ > +ENTRY X86_EXC_NP entry_NP /* 11 Segment Not Present */ > +ENTRY X86_EXC_SS entry_SS /* 12 Stack Segment Fault */ > +ENTRY X86_EXC_GP entry_GP /* 13 General Protection Fault */ > +ENTRY X86_EXC_PF entry_PF /* 14 Page Fault */ > +/* X86_EXC_SPV entry_SPV 15 PIC Spurious Interrupt Vector - Autogen */ > +ENTRY X86_EXC_MF entry_MF /* 16 Maths Fault (x87 FPU) */ > +ENTRY X86_EXC_AC entry_AC /* 17 Alignment Check */ > +ENTRY_IST X86_EXC_MC entry_MC /* 18 Machine Check */ > +ENTRY X86_EXC_XM entry_XM /* 19 SIMD Maths Fault */ > +/* X86_EXC_VE entry_VE 20 Virtualisation Exception - Not implemented */ > +ENTRY X86_EXC_CP entry_CP /* 21 Control-flow Protection */ I expect you won't like the request, but still: There's a lot of redundancy here. The first two arguments could all be folded, having the macro attach the X86_EXC_ and entry_ prefixes. Or wait - only quite, as long as X86_EXC_* are C macros rather than assembler equates. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 11:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 11:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498838.769769 (Exim 4.92) (envelope-from ) id 1pUR8i-0004In-Jf; Tue, 21 Feb 2023 11:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498838.769769; Tue, 21 Feb 2023 11:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR8i-0004Ig-GR; Tue, 21 Feb 2023 11:48:56 +0000 Received: by outflank-mailman (input) for mailman id 498838; Tue, 21 Feb 2023 11:48:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUR8g-0004FH-No for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 11:48:54 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7532602-b1dd-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 12:48:54 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7299.eurprd04.prod.outlook.com (2603:10a6:20b:1d4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 11:48:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 11:48:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7532602-b1dd-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+VPP3GaegmU3UMpqrxXWuMT/wT1wF+cSLIwxTLX3DPBYaJUttmtFLk1TT3NeemVKt2z5n+k2L0hMrTKfqkDyTk4zjSsorRfTdbFExuLJmyqEv5G++Kd4Ko0Ka/69UTQiiWdAK61Ns+1+S3+vEd6HRwh3vBwuQmSIzKU02AoNLN5kjpFGCVQW+Xmiz09qyZh9JxjQDEgCkEgEJAclqjWvH7lnyf0TS7anOM5GlFliArcTfpX8i8G4eRkw6TDDYsB9vGEEAElA6KCFGy+XDkiMNkn2FDl6RDxUJcZBalkGBgwA+FO+LcAvKaLfpxyH5tJEklRH1baNg2EUhYTNCyZJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEA3FPRhxZI4b8KGHvOf4M0GjIBAL+TyUWa2A08BYyA=; b=nmBc6Pg0c0iJKGb2BPtLCdgrbOalO+9wmZ6Zaj9R5GePyc+ytS+PYvI6OE/YdXSPd2u/oqoM9Y75Z4wrUGeUoC99X5uRoKKxtX0QjEdPiOqu3h3SyR7+7Zzv7ce5JIMeaOSy2Tn+7vNJxJMtxV4uHPckYFARZ82Mw6OvYgCpgRwEEOgWSfsAiMKq+UmOFnNNlEuKwmMmJ5IlSasdLS3yMniVV/HzEugJM3zFp7RHBaOLvEmNeMybB3UnkXm6EXRPbCfIvNd6oakySXsWpOQffKRMqnDw7mUfXiRXtO6Ot6o7wL+XoTi8cVJC9kteDvhRAaGYNaSE/HgWQ9Jd15hnNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEA3FPRhxZI4b8KGHvOf4M0GjIBAL+TyUWa2A08BYyA=; b=W48MtFq5XrYLTmaQKLRQK23iqqwBAfJw37YKe0J82XYeFX/Ynl/vvHO43gHqzwf78Zzja2dczNyJSfcV4YER49OFQsO1gMGHRsQkARLXYe3t/KAIP1bNVHw3kAii7944q4VsqaOfpBcR+e3ve8ga9DfPtoIyMLY5cbSTYOgKxQ4UMOEjwybc5AwgO9CAc5jbcg9d0ZjsIgFReA9ml4TkvKXMwzIbfqgr8F0ObnMUNItNYz10OoOCJ3lqZWhlMrpKTJDJEt2TVTd80ovcbDAhC9N33OwL35wXhbyuyruSmZCk4pNnV4owgPhOBjjiuYGFxJaTiZcOO3FfcqYUPkQwpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c9ccd64-0d4d-f77e-517d-f99e6023aa17@suse.com> Date: Tue, 21 Feb 2023 12:48:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/3] x86/traps: Move do_general_protection() earlier Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> <20230220115956.1522728-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220115956.1522728-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0140.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7299:EE_ X-MS-Office365-Filtering-Correlation-Id: e17c2d17-4e6f-4dc6-8233-08db14018a30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I93qRhUOg2IqC69tjfh+dfaVWN80sy5refyOXaq2+omzH/bWtCytU4026SiMMpcZzKvsXmY0ShmPnEfqLgPH/khoaYdACjzkUVG/4NJ38m4DU12A3RnVpBoz1XMcY/gH4nFT4OWSo5sUdRGLMOj4QRh3X2Bu2CCDUvfn2wvyXsiJIzsNNU6J/qk02Rlq/uYNuLLH5RLb9Y3pEQkG/1HCAJazs3UlY8rquFiLAw6DSrV/jLKAi2xJYyM7LFSco407i3nq53eBMOMU+LbsCl4Sz4bSmVqLyGgDXbYX9Ya3nCWSPJdzcC8XjF5VoOLbGGmNw402rDdN/jTvwb6UdGLhFoEPvLzGadzEq0Yqe36aq4loECrY9SiFSGjJ7bBE/sXnans7QfafBRKqjNwgZKou6jiOoGY/MXf3ZB3KDJPs7ewLKHZrSQNDqXIAh5SUoZ3Qg0e5gUvgsCIAjEGEQyJlwSmE3zFXlDcciumNQ4z5Wv/eCJlTPgwhwFzLM2+5f+Wuhqmeb7OYgHw8WG910oxireWUudAXu8EYJbX2lr3LfIbq6KP5i6ZiHB06nUSGVXDxWHrpEVUs8vaodlI3tfL44RsOGvDkk8L5jHXx9QHRVLrmQRJVZP/pE8CwBF5Fj5qsCOTmUW3sZ84gW31RfO/f1Ex3jnqEHqwhE9k90b+1UaSVfN2ve6IO0XAtKXlyrJVBLEiGnL9tilXbDFtbIALKsFE4lCMaY5O+pmoBUmmuyv8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199018)(31686004)(38100700002)(2906002)(8936002)(5660300002)(4744005)(6512007)(54906003)(26005)(186003)(41300700001)(83380400001)(2616005)(36756003)(66476007)(66556008)(6916009)(4326008)(8676002)(66946007)(6506007)(86362001)(53546011)(478600001)(31696002)(6486002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTdmWkdRa0VuQWtvVktlcURhWlNEOVhTSkdNZWpzMVVwczNiOTRWV2tZUFRQ?= =?utf-8?B?VUVleTFWQi9RZ1pLZGJqUjJMenRGUmE5TTZiQTk4TU9vUjlGLzNGU3JyQ201?= =?utf-8?B?bFNWNHFsSFFONjJPVnI5VjhUZEw2WExEUDFDMUMvMmhNY2RYZCtFVm53T3Bk?= =?utf-8?B?TGZQRVVBY09ybmZRL2dLWmFxTVptQ2p3Y20wUXJNSU9mc0FWcTAvNUpVU3Aw?= =?utf-8?B?TmVLVFVZMnJaWi8wcm5yOUltaUt2WkVpTnREVGdDdGxvQmh0dXBpcVRQQUZa?= =?utf-8?B?OEdyeHFhTzVza21ZdmZUMHQ2OEdrTTZPc3lRRy9EcTY2Nzd1QTVFS2lYSG85?= =?utf-8?B?ZEV2d24rby9LNmVEazJpQVVwckJmNTZPMzI5bjNsYXYxVi8xcm8yNlRGZnJh?= =?utf-8?B?MnAzdlBRaUJiaEZmQWowM1l4RVltMU84SGlBYm95cTV4M2V6WEo1VDUyM1N1?= =?utf-8?B?a2Q3a2dSdHpuU09lWGlyVFgzeHFOMUtVSVVZcTNoUlRCTWRYNEpDOW1sYzF6?= =?utf-8?B?cDlmSm5hTyt0MW40K2RNajVLVnF5ZFN5WU9DM0tnTUlicmQzdEZRQVU3amF1?= =?utf-8?B?aVBSOG55VHEyZ2thNHZTN1QwUTBvblN6T25RVFRaVFd0Q2FIMHA0WHZia0ox?= =?utf-8?B?SDZCSTQ2cVN3N29jWmJNdTBVOFN4TTVwN0FRaWk4RTNDQ1Bka20rSTFEbUx1?= =?utf-8?B?K3dSeDlNRVp4dzEzUWVhZXZPeGR6NE5BTll4dzdRUGhTS0ZFb0xkcU5OQUsr?= =?utf-8?B?bzQ3NVhsNTdoUzlKcGF6TXVlYXFRdFB4dVkrTkJYTC9rb3NVMlEzRmZkNmM1?= =?utf-8?B?SFBnQ09aMVNnMUx0VVIyMDhSWHZ3akpxTG5ON1ZiUjJ0MXVYOHhJckcxU3I4?= =?utf-8?B?YVFPZ0R5MjRDUlp6NEZoaHI0NWF2WDU1dUtLaU90OXhuaHVmeE51NTU3SkVa?= =?utf-8?B?ZXlhQU4yM2hmT21JdnRIMlp2MUhRZGlWZjBxYmZ1VTNiKzZQSXRWR3ZQcEo1?= =?utf-8?B?cmpTeWxMdXI3emlhSkFGUmdSMjQ4YndnNk83TTVYMklsK3hTT2IxbSsvcDN5?= =?utf-8?B?eFY1OTFUSlpSdTg1RmcvQnN4SktkOHNUMmdCYlA3OUdOMzh5cjFTZGI5cVVk?= =?utf-8?B?dCtQNSt2QkdsbWVWRnN5U3laQUJFZGgrMjllMGFBbityV21hNUN3dFMrbmEw?= =?utf-8?B?VzdWWVdJSG9EZGlpaVFGQm82b1ltU241NnFBVzB6MWxIK242c3o0OUdQdFZ1?= =?utf-8?B?RWJIR3FxMzNSMFQ0Z3JQV1pCWDV3SXhKRHVFQ1VxN1pDU1Fjbk9vMFVnVGRX?= =?utf-8?B?SjZiVmtScDdJNjVOK2syTGZKeUhhYndQTjFkcXMyMFg4MjJuTS9sMnJMYXhT?= =?utf-8?B?Q295MHl5ajVMRTIxdStVaE5wcDRHeFdseG8xN09WM3BnZmNqeStoQm5peFM1?= =?utf-8?B?WlFOQmNhbk1IZGJTTTRaeGxTSGgrK0ZnODNoNzV0WVBSMlZRRUQ5Z1NmbGd6?= =?utf-8?B?aE1aeDBnSWw2Y0JzeEd0ZHV0YThOTzJuZnFKcXloTHJNOTVqZHQwN3ZPV05w?= =?utf-8?B?Y1lsdGlaSUlhZDdIa2lYVGNXM2RZcW01cE05dWl4WkV2N1ppTnlzQzQwZW1M?= =?utf-8?B?M0UzNGxpc1pZNktLbVl1MVV2RWo1OTQ4ZUlIaThOdEFuRE91Q0Nqd0ozVm45?= =?utf-8?B?dmVSanR5K2JmVDJ6amM3azRSVzFGLzdxVm03dnNwTlgxZVJDcndiM2lQODQ5?= =?utf-8?B?U2xhcVJ6alg2dEMwSHBNTjhWR3VFeTJCdXpnblFTRUxlOEErN29OWkhxRzlB?= =?utf-8?B?OTZlNXRlVUtsRTVCYk5qdXJRNys4OHVDenN4czBDNVRGd09lMjU2QWNOeUhI?= =?utf-8?B?c2d5NDhvQ1R3cTlSNVd5NUxnaElFVnljSUY2eWZ6eGc1cmU0d1IxSWVNRkwr?= =?utf-8?B?bGJ1MnUyMEk2VjY1NnhYYi9BeGFOblo3b3R0TzhYQ09rWldBOHJhYkp4NDhp?= =?utf-8?B?M3FxZ3d3cGxQb2hKZlFvL2svdTZBbjUxSUh2MkxLSWlJRVVVWm9JSGpOa2U2?= =?utf-8?B?TGNjQ3BNMW1pTVFTRzMvdERUU250VlU4VFVSMW9PbFRuQkNFYVJ5TmsrYlR4?= =?utf-8?Q?Shg8SWzIaNX2chsYK+JAmTr9s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e17c2d17-4e6f-4dc6-8233-08db14018a30 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 11:48:25.1045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z+LlhBmcKa39XwWQhnwBaXMEMYAKJ7qYxnGoY3TCmxMhxE3e0CRD3rAkksv+ifRKkhjHAat8CUXDt3H4iikAHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7299 On 20.02.2023 12:59, Andrew Cooper wrote: > ... in order to clean up the declarations without needing to forward declare > it for handle_gdt_ldt_mapping_fault() > > No functional change. > > Signed-off-by: Andrew Cooper This is okay with me as long as the Misra related comment on patch 2 can be resolved suitably. I'll defer the ack here until then ... Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 12:26:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 12:26:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498857.769779 (Exim 4.92) (envelope-from ) id 1pURj4-0001Wi-RF; Tue, 21 Feb 2023 12:26:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498857.769779; Tue, 21 Feb 2023 12:26:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pURj4-0001Wb-OO; Tue, 21 Feb 2023 12:26:30 +0000 Received: by outflank-mailman (input) for mailman id 498857; Tue, 21 Feb 2023 12:26:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pURj4-0001WV-0M for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 12:26:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f509d21d-b1e2-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 13:26:26 +0100 (CET) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 07:26:23 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6925.namprd03.prod.outlook.com (2603:10b6:a03:41a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 12:26:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 12:26:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f509d21d-b1e2-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676982386; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=G/bBfFYyrF8TBbcszQE4xLDWFGX64Lpw36EATLVpxI8=; b=VIJSLOSCQCyarHmBWvpajISGm/KYFueIVW63W26KLvhuynsA70U+v6Xl LXHjuEPxGzKTgesq7BqB/NdrV4hrU0ml5Vk3CCLR5C+iR7BBwFULDPdXR 3Nc8Dvwehs8AEvGpJmsf3vi2Y3CcWOITa59HnyTQSIrwD/crCNVnhAlgI Q=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 97894208 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FJG1L6of+/SbhCLaAxs2PFlkUDFeBmI6ZBIvgKrLsJaIsI4StFCzt garIBnQOPaJa2Hxft1ybYuyphhTusXVyNIxTgBsryExQXwR8ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAgPcxnfvbro+6OEVtZWguMJJcXPJKpK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSEEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqa473AfLlgT/DjVMXmWZsaO2lXKPXv17I A9PwxMWg5U9oRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey9zqoYV2hBSfSN9mSfexloesR2C2x C2Wpi8jgblVldQMy6iw4VHAhXSru4TNSQk2oA7QWwpJ8z9EWWJsXKTwgXCz0BqKBNzxooWp1 JTcp/Wj0Q== IronPort-HdrOrdr: A9a23:JU6y46p3DkoktWGm/etpP4saV5qieYIsimQD101hICG9E/b1qy nKpp8mPHDP6Ar5NEtApTnEAtj4fZr3z+8T3WBzB9iftXfdyQ2VxehZhOOJrgEIWReOjtK1s5 0QCJSWY+efMbEVt7eH3CCIV/om3dmb4OSJqI7lvghQpNhRGttdBtFCe3umO3wzfgVAGIEoUL +b6MRKvFObCBYqR/X+PHUDQvPS4/jMmpzreloiCwEq7WC1/FaVwY+/KRSewwwPFwpVx7Qv+3 WtqX2b2oyT98u2zQLGxyvp441SiJ/dzLJ4daixtvQ= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97894208" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmA0Uq0dkl8NgeJy1CKreoHnPdaZ4Yemo68ooHmXIVVtRMHMPfUL03TyhGBfZMwXF7/Nv8+veOyURBreE2Wy7L5cV6e9jwNtYa+UTSyjmj1mH+3OgoncaVZD8J4pnStgSNYVKSE0NGdklsrO34yvFViAb42F8S56XTMeo+QOB5JwUOPIGv4zqpLcDgDZaSXYeBql0e5ZovRWxtaqaOuuwhC9nfEvjfMUyka0CCOKqrggHEqQQ591ToCaH/j8uXUc/iNfSdp0o5UzT3LgEx6Mdag9NEXmaNg+b2t45OpE6J9Wb2cExRihqM7uLUYaZgN48U32xzIzqwKtbuYlMaUTbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f191Wq+xydGKOKbZYTnvxXioQfHnK7gPpW1v6/rvmjY=; b=R38Jpr33giJ4b/d/1qmizaZ2Wl1S73j/ueCzZxrr7ts3tPMTCNOF7SPMAmAiFLykQ/rLfkhqv8lIsO/ezQfm0QWZ9E/2gXAd1DXzIJioj2hUMCCueU0QdT76r28QaASfTuWpROEotsS/ny5mNPbnav6zWzP4CwS4DIh+t0ghlBTunQXOC54RL1i/zppAJ9jXPp2WI3ZjKNf+f417Vq8+TNY/47G0Ihv14Z4ZHUaW9edzyw77ZOOVxjeBFL8X9RX48JEtpv66vvIxNPf+ehXqw1Vfa/8kPvy49+1M2ejf6T+Ks+H0LEl0insEHQefUZA/rGAX6Trr8hUwXymOK/jWwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f191Wq+xydGKOKbZYTnvxXioQfHnK7gPpW1v6/rvmjY=; b=nmUWiU5yHMOwLwKBi2yzXalNXrffg6wBGiAIv6LqOnlIPJMtRhp21Gwe7M8t1zF0rWKyGdfLlcwXrVzSZu0AfAM/Y/IfDqsdHHmdeInfkNraoXqmBml/pO8yTdgEBRPC+Z6z8blYUvTnMra2IvOtCaQ2UJcYTc0vhSYYaDE34zg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 21 Feb 2023 12:26:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217001914.762929-1-andrew.cooper3@citrix.com> <20230217122203.790737-1-andrew.cooper3@citrix.com> <04891259-ffde-a6ff-32a1-e3a84a7278ca@suse.com> In-Reply-To: <04891259-ffde-a6ff-32a1-e3a84a7278ca@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0185.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6925:EE_ X-MS-Office365-Filtering-Correlation-Id: d1ba98fd-1970-4565-c9e8-08db1406d694 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8czAoa0PmiurEjIgF9e9lXA++E9in+NXeZ95RwMwzWJOWCbvZnAcpWQ6H+Ja+IRdYPcIhhJetqwoBy8qg4sMuV9opRJZnY+x4u+UJ+lRxiA6QGe/8L+Oewgbi1kMtOBWueNPopvqiIlfye+lDzaPHHqf3M0XkCKERDaJJS3w+/dxeEAyGa2TKFASrDYXexh5fUtOzQNaPxI/mJR14OBnRfCsHl+3CjZDnKnNwMFwLmuSko57CYIuPL28QZa5g6TjC5J/JZqM1g3KrHVjtWD+viuEMpwq71kCdFmacNZsqGICKvkq3kOEkAwH3q7AKYcTRbnsEXNhCI0etFf3dMNZFKdyhv0Vg8nQWMXbWENNX0Ro0voNBgL6Wz+MjpPjeqkUFe96ce/f8sVXUYy8KrrdyMp4mv8jDlUYmbIxhKbgD14UuwC8072GgvXsYmlZW0/ueduE4FIL8wXq66+Ku0ZA3KZk6crQo0wsxLeW9DWzEaAcqUun9OR/+XCUC/maCmys+afexxra6Qjhu+DHtfMRbQwJe2H8eGeGTonZKq+QzWtYRH3noTeHAb1sPEl7CXa7Ppdf9qoY6CcI4/5npOW5cv4B5OvHzkc/k+uojc8jHWIBicoaFHcJx7uyOeudCHBUIjg4Xd/pN8l247/L5N1cfeWaq+KaGvyEZHRzppwvC6gWzZfr2rt/FOR6JDscedPebHEgJJAK9JZ/4bZE4UTVduvl7lSL+QC8yKOIaXPEe9k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(451199018)(31686004)(83380400001)(316002)(54906003)(36756003)(38100700002)(6916009)(82960400001)(66946007)(66476007)(66556008)(8676002)(53546011)(6506007)(2616005)(41300700001)(6512007)(186003)(26005)(6666004)(478600001)(6486002)(966005)(4326008)(31696002)(5660300002)(8936002)(2906002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWN3bHdaMk9wSDlxTmpRSUw1Zzd2NU56dEc2UnZmb2VyZGVQdHVlWGFla0VU?= =?utf-8?B?U1I4bHAxOUNvcHJZek5HMlgvZW83UVljdWFHQmZtYmNPemc3d0RtbUMzblp1?= =?utf-8?B?blJiQllReFV4cDlMTndYVmNuSnB4a3AzQ1Z5SnJvMmNOQ1JrQ2E3N2J5aWhp?= =?utf-8?B?K1YxMHNkcDJTeC9hZzFVckNsME1qcjZpQi9HUDhadWZKVFlKbFFoOTVVMzl2?= =?utf-8?B?L3hIbUcrRnVSeU5DVjI1Z2RrcklzeE9sMTI0VlBnODR1dS8rUlZnai9oUHE4?= =?utf-8?B?NzRLcHhjSFhmSEUwQlJ6MWhmajQ1SjBvMzRqYTR6UlRNd2krY2s2QzRDc0Fo?= =?utf-8?B?WCtqbms4SVRnMHBabG1XZ2w5SGJUY0VZeUUzcER1RTN0Z0RRWnhCRVpQdXpm?= =?utf-8?B?UklXeUVWQmFNTTVLZ3liQzdXczBLYkF1TlBJcklLa2ZGaUVkZnRNZmFUc0hq?= =?utf-8?B?aVM2NzQvM25sOTJ2U01hN2grNFUzRStGRTNOanlQaWh4dzdQVGlIUlFOOGFV?= =?utf-8?B?UXd5emJPT1Rac2Q2SkpQL2JsSnY5YWZpK1NUc3JjTDQydjFWV293UGlSdURi?= =?utf-8?B?T2ROaDcwOUYzL05QM0NWWGJGVEVOY2NFMG4xL3pGbzFTaW9SME9OQWh6Nm45?= =?utf-8?B?amk5UTlKYTVncmZDV2hkUHcvZSt2TnlQNHRudERTRlpwTzlSS244akkxM2gz?= =?utf-8?B?YnZJUjJISk5vU1BkblFIQVVyTG96M2JXUVVXYzNvR3NFSGxVV3I5d1RoOFcw?= =?utf-8?B?Tnc5RUVBV04vdU5sRzZtd2pNZkFmU0ZnMzZ5Y2IzZUh6bWJGY2twcnVwUUJB?= =?utf-8?B?aVhKL3dGOS94SzgyK040Y3hXNkJ5aXlZL2RYVTI3czFMdWpIOXRzSzQ0U0di?= =?utf-8?B?Q1ZKVld1MXU2SWtJa0MvZUdpR2xPSHV0SUxxYVVaZVEzSTVUYWs0TXBZeXpM?= =?utf-8?B?cUpYMExyTUVORnJNNGpQU3lHU3JqQzRHblhTWHRRL0UwM0Z1ekdNcUlVVUxo?= =?utf-8?B?aVArV0VqeGJSRVB0MWdJVlVXMHVsdkFqM0VjS3prZ01RN0RaYXR5SmN5NGdh?= =?utf-8?B?NnVlejd2dkpDaGFzTEQyTE9oUTNhQ3NXWkZWN1dHWXhHVWJ0N0NxNUJUZC9v?= =?utf-8?B?ZzN5bTN3THdScFQ1dXN5elBpTXNFMDRvK013bWM1VytqWk96WXdRdHB5dkdK?= =?utf-8?B?dTc3Y3FvMGZxWEFzUUFzSGpzbTBiYVJBTy9WMUpPSi9yZ1RhNWFhN3hRdnJT?= =?utf-8?B?NFNyMUtwd1dLWWNMVmRXRHAvdDE5d0JnWHc0U2ZEVjFqZWlHczBWelUzZ3BV?= =?utf-8?B?cjBnU0pyTE9JN0lqbFVsYjZYbFFwQ1BnZitHWlNhMkNtaDhXRXhQQVdRRm9h?= =?utf-8?B?d0NRSVAwWVNvanlPUXhLZlM0czIrRlMyT3ZXUjdUaEdIMWluc0hDRVRiSCtF?= =?utf-8?B?bWovTUd6VFRlemZ2bGpJTzlPNVUrcVdXb2J3WHdNZlFYRUNuNXI1MUhQd3Bi?= =?utf-8?B?NlluS0thMnhIQ042dWNucEdTVC8vY3plamZBZUN5MUdsM3d3UTNBV0hiZHMw?= =?utf-8?B?YmhBeGIxeGZXZGZwblhONWhlc1JVN2V1Tm5uVmpyMjFhQVVoNTdVZndTUmoy?= =?utf-8?B?aXk0ai82dG1QMWM3V200TmQ5czIzRWw2MnlSeVorQTh5dmt4dDFtOEdZM3pa?= =?utf-8?B?UWFYMkxlMGlMdUVaS1B0QnMyTTc4bVVuQ3kzOEpEaUtmMFE2dFl6b1g1TWd1?= =?utf-8?B?NHNuR2RGQkg2b0FIdWxnb0l0WjZmZGNqR0dHSm91a0FWSGZGWUE4RHRQT0NJ?= =?utf-8?B?RUE2b3V3SlJMMWEzQisrV3NFRE13SkRiVzhKSXRLaXVrS1hLdlhkZTRJUFRu?= =?utf-8?B?S25DMGo2Rjd3RVZISk52N1hrOXZueVVodTVSZkw4bS90WjF4VGhKanFLWG5I?= =?utf-8?B?NlplQ29sM0Y4c2wya29wNXpob2RTNmJSalJ2dFBsUUpESW5VTnRBNEJZcGxH?= =?utf-8?B?MDRVWkNCZ0ZrSWNpT3lZcUtFUE5MdzltL20rNk1FRkhXaVZ1aFdieGVyK3E3?= =?utf-8?B?eWtPZWxuMXE5TENZSlUvY2psSGZPeDhmR3FzMEhBZ3RUZ0pWOW5taUhNOXha?= =?utf-8?B?UXROU2hzaThUVXkwN2hBT2tMZDBacDZnTENiNXc3VjRmYTdFSXhKU3M2Umkx?= =?utf-8?B?QWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: C7asOmUWlDs/C9BcTEwEk21JAk+TT4ayPDmwdwlfg5coWZtZ9MQgAFQTjhC7qBtvVmOptTusDDar5+PB1XALlu0auPy+EvuMjk2gG9vnqPUaUpOssIdbUHDOdMVgRGhC2shg9qZnrkzKEaY/9i3gr2roIZjG10xCXEq3E2xa5SvnK6nbvzA3kHz7y3tZdbbhcvGg3f+D3448ayTiSNziG3DK5KY7o5z6arEC1nTt23yDNNbOfZNXz46XtUeYqaOz0CTJJtJLvEAwqzyC+nYiiOW5wFQvX8rtVKqzAAv9by2TPS4ClRPVAF0CZBqCJY8zoojaJHl5pXIL4u2q06bbvbCP8YAuNz+kbJEqcGzpI5U5HgevFk5qOdXZcy23r3oERkoG8NNmrMf/ejnVmjgerlUgZNqlaiijk0OAsUjlbHyQzULGhlU4oG87PIu9TJe2T/4+SiFGySrBdhF05S5Z5dxz1TKvpaibPoiyMcsPaCa16tSlgNBGMWCh0RqzGp1RqYaV9Jy6bJKYK6RqDddZyJyOUrm/p4SesV3O/iriNkNrjjDOsn0zajf0CPMcHoACnXfEtHDWTP8K1vJgpUrwigujjQPMSwn69ijIPlw6gklQED53ednWVBqWIRiMYQpnKtPAMBrx1cY3ThDgZEgCfxodgyptNuemKHuHs+AwdDna81s7wZFonDfD2HbRBsqcn2t7dNgYVpPgYaHz0XMaJsxVCD1+QOCjrV2QQpq5yfQaVhoyKSjv9f+QelRI5kxQ7Y7Ih1OXeu2Xpifq7KevPpMVQXfM610eNkaKZCQv/dxwx4ylofQLBQsJr1q9pzC3qIVMtrgn5zXerxfp8qugbQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1ba98fd-1970-4565-c9e8-08db1406d694 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 12:26:20.9397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C87vumzcfTHOVNGuZuYEJYiR829DgOSb/zElV7JxZ3svw1UEKhITecwRpMEwZDCYBv/s5wbY5SkQ5InEDi0qF/YziIJLrowyXWs9vM3uZ2s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6925 On 21/02/2023 10:31 am, Jan Beulich wrote: > On 17.02.2023 13:22, Andrew Cooper wrote: >> https://github.com/llvm/llvm-project/issues/60792 >> >> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >> unit, and the XSA-426 change tickles this bug: >> >> :4:1: error: invalid symbol redefinition >> .L1_fill_rsb_loop: >> ^ >> make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 >> >> Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mux %= in >> too, which Clang does seem to expand properly. >> >> Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Roger Pau Monné >> CC: Wei Liu >> >> v1 (vs RFC): >> * Rename \foo to \x, reorder WRT \@ to avoid needing \() too. Sadly, this is not quite correct.  There needs to be a non-numeric character separating \@ and \x or the concatenation of the two can end up non-unique.  So I think we need the \(). >> I originally tried a parameter named uniq but this found a different Clang-IAS >> bug: >> >> In file included from arch/x86/asm-macros.c:3: >> ./arch/x86/include/asm/spec_ctrl_asm.h:139:5: error: \u used with no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] >> .L\@\uniq\()fill_rsb_loop: >> ^ >> >> It appears that Clang is looking for unicode escapes before completing >> parameter substitution. But the macro didn't originate from a context where a >> unicode escape was even applicable to begin with. >> >> The consequence is that you can't use macro prameters beginning with a u. > How nice. If really needed, I guess we could use -Wno-unicode on the > assumption that we don't use anything that could legitimately trigger that > warning. It's proving very stubborn to narrow down. I really can't reproduce it outside of this specific occurrence in the Xen build system, but my gut feeling is that it's something to do with the asm level .include. >> --- a/xen/arch/x86/include/asm/spec_ctrl.h >> +++ b/xen/arch/x86/include/asm/spec_ctrl.h >> @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) >> wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); >> >> /* (ab)use alternative_input() to specify clobbers. */ >> - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, >> + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_BUG_IBPB_NO_RET, >> : "rax", "rcx"); >> } >> >> @@ -172,7 +172,7 @@ static always_inline void spec_ctrl_enter_idle(struct cpu_info *info) >> * >> * (ab)use alternative_input() to specify clobbers. >> */ >> - alternative_input("", "DO_OVERWRITE_RSB", X86_FEATURE_SC_RSB_IDLE, >> + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_FEATURE_SC_RSB_IDLE, >> : "rax", "rcx"); >> } > Since inside the macro you retain the uses of \@, I'd find it desirable > to keep gcc-generated code tidy by omitting the extra argument there. As I said in the RFC, I tried to have x=\@ but gas really didn't like that. But given the concatenation observation, we also cannot simply replace \@ with %= (given the option, which I couldn't figure out), because they can overlap. > This could be done by introducing another C macro along the lines of: > > #ifdef __clang__ > #define CLANG_UNIQUE(name) " " #name "=%=" > #else > #define CLANG_UNIQUE(name) > #endif > > Besides the less confusing label names this would also have the benefit > of providing a link at the use sites to what the issue is that is being > worked around. Plus, once (if ever) fixed in Clang, we could then adjust > the condition to just the affected versions. It's only Clang IAS, but there's no suitable define to figure this out. And while I appreciate the effort to be more descriptive, this name is literally longer than the thing it wraps and ... >> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h >> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h >> @@ -117,11 +117,15 @@ >> .L\@_done: >> .endm >> >> -.macro DO_OVERWRITE_RSB tmp=rax >> +.macro DO_OVERWRITE_RSB tmp=rax x= > The "=" in "x=" isn't needed, is it? It looks a little confusing to me, > raising the question "Why is this there?" Because I started out with u=\@ >> /* >> * Requires nothing >> * Clobbers \tmp (%rax by default), %rcx >> * >> + * x= is an optional parameter to work around >> + * https://github.com/llvm/llvm-project/issues/60792 where Clang-IAS doesn't >> + * expand \@ uniquely, and is intended for muxing %= in too. > With the above suggestion I'd see this comment move to next to that > helper macro, with a link to there left here. ... there's no getting rid of this comment, at least in some form.  The parameter is odd, and needs explaining. Passing %= unconditionally doesn't matter for GCC/Binuitls, and in this case, attempts to "declutter" the niche usecase of inspecting the assembled file comes with a substantial complexity at the C level.   It's really not worth the extra complexity. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 12:46:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 12:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498864.769790 (Exim 4.92) (envelope-from ) id 1pUS2X-0004YX-IX; Tue, 21 Feb 2023 12:46:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498864.769790; Tue, 21 Feb 2023 12:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUS2X-0004YQ-G0; Tue, 21 Feb 2023 12:46:37 +0000 Received: by outflank-mailman (input) for mailman id 498864; Tue, 21 Feb 2023 12:46:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUS2W-0004YK-Iz for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 12:46:36 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062f.outbound.protection.outlook.com [2a01:111:f400:fe16::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c63cd1f8-b1e5-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 13:46:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7715.eurprd04.prod.outlook.com (2603:10a6:20b:285::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 12:46:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 12:46:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63cd1f8-b1e5-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHcDCIoRgVftrhhl0CQKAAjE56AxNyl4JYrhSlrrj6pAf6GLzqBiDoGiIPsERge0JLPOt8oJfYT5cbwXOgPqGLZbhXT11SRaGVfZ6zEBo5QEsi/O17wf6gptsY0NSoSXHLuw9BNSv3mI/Hh0VMBMcwbMHDfAfu8yNxVxgisK+AndIXZNVqBmMP+1Pm5Az0lzYn+fNDDh2qtYVnrHzpKyVw0fY4KHFsBYuWZW4rG4MVC/uJZ8N3gOlLgjTOGvaBVSJsrh7nWFP6r1iEwrMITtRWSaxXUQzfj6QOM6obPspKONkl9Aja6hmMo76Gwb1aMAb/nLPK786MMn1LkFtIg7yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/M+MUZZf4ZJbbGM6PtWH2pybkV7nJpW6muEe6UWfYYw=; b=VzM44QEy8jFdRcfJ32dAvejUzVad70BaklDj+1ewa2PI8A9B7vXvKv7PlvQA/Nik6uIS2Vg/ESUbl30e/CZ/3y7UwVwa8S4o2a4N72/dEUAHzUy4JaqXeeHGonJyVNr9+xnaQIWAnNLJJLhMYhP+joEJ25VILcFjFPj3K2414as/MATe2ZbKe2ERrU0pZATgmlJVoavZiHgQ7z4t2NRKg46vKCCoeetz+wo/J1Hoqhxg5ft3DELHwkId95/LnrFQjg/EnQWYzluq6MrPwtag1jdlcYHjEav+q098oeVu6OKkbK+dzoGbTfaduKZ78ntynVDEzlZwkrPw90H0+K4WhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/M+MUZZf4ZJbbGM6PtWH2pybkV7nJpW6muEe6UWfYYw=; b=UrSW5+FekkUEL19jslUHE7Hy1MShpdbM02BxkvpcuBVKIa3ywjE8a2Hs5ggGyh8m0dZPrLpt5JB/8M3kP7TRRTOoqJhDo6HksFKmYkMPrAqLsiGUNjuNF8uwLLOsdV6SLTOy1byCF/Jga0Omk1LG8nJbkbVuhDY2Nb+o2Vp+yiocvyj1gGAaNklpTpoN/mIC1I8WAeXIqVr44QYrNBzJceyS+ACjXdBFYh4ydY5m86lX01SXv0G+aaX8Jtx0MhmDO9d+QcaBDnUYWrZQ+fWXUgsevEuagR4D1lcAqRsfaf3dG9OewPp5PbeRf+nb+6SDLTjubxDexiX06s2r1LwSBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 13:46:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217001914.762929-1-andrew.cooper3@citrix.com> <20230217122203.790737-1-andrew.cooper3@citrix.com> <04891259-ffde-a6ff-32a1-e3a84a7278ca@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7715:EE_ X-MS-Office365-Filtering-Correlation-Id: 87a257ed-8e9a-4a59-507e-08db1409a929 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bgFDfDMAeJ9gdN/ElSgok52nSpEPl5O2CGGY5AjA077hwRD0WoVPo+v/h1v7vaAsqRN62kHWYhvYFRCaE4+BjNe4BCgp1B5SUwuUZnwvbfa3asvxDXFFWfDp8R+IxYHyFpG1nFDS+emUUQfxtghPDjf/bBLAGR4FIfGxkGsPGeqSf3IEFm3dHv1I3noHDFN4UtM+I6x+SYRil/TQ6AbrIGcRMgQBPWFvURAMDrC3eIrJ0ynGUWQ4aKwxdjy5RYlV0K58rL4tMszGUaMPJ8bOYfmpcYgHebBtIur8rhkJ0zQI5qLUuMtHZklajlP9UrUpBnBMrcMHQkI89iPKYvVmPWbpmviD13+A/rpW87PEuDB75VuK51sIJIYzWbk8udhXfwm5x/XYNzoVTGSUh6CeU+o2Gt2SKwmbpVQJBfQcfMU8lVjcQltg4+xD1kmeSEOZqNMNkxI5J3JSajL5bidhGUXOPXtIyFr7wGCsdi6Tmjeepl6HVFIf9DNMvFDiyAEl2suZbCY3Kz0cgB2LXEywRrCS5NqH3LOKA0h6NgMsajD0MoZkUtKuHscZeUa2ksw3PhQbOlBKsvCKfbi6eqYjbFn5NkVMe6p7Q5ygcakwHhKvKnMlYNY0hBLyTxi038ZO+CQOlzpdtGz7o0Znr3snzlzTlxbWbqXasPEdLhcVZUp4RAyfEJjMiVREiM/1gP1fkognFCQp2S1dy8vuomSxXSpYNgySBdm+VapMUgg5w/g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(5660300002)(54906003)(316002)(4326008)(26005)(66476007)(8676002)(6916009)(8936002)(186003)(66556008)(66946007)(41300700001)(86362001)(36756003)(6506007)(6512007)(31696002)(53546011)(38100700002)(2906002)(2616005)(83380400001)(31686004)(6486002)(966005)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Snd4VmQ0M3ZVVVZOazlueDZodGF5bnhVVERiNG5Zd2s2TEdYZ3ltMmR6bjNa?= =?utf-8?B?TVQvTDlRU3EzVFV2Q3RpbGpEWUxaZjAzQUZ1c2VVNGpWYVVtR2NzR242di9a?= =?utf-8?B?UWFHMGg1VGJUK1FUTi9sVDJzVVpxa2YyM2tXY2hpSkpwcHdHWFdYbVNQcWtC?= =?utf-8?B?NEcvYXJyOExSRHBQSGpLSlFhaFFFVnpxSU5xWWhUYmJQUS80cTNaakoxaVlW?= =?utf-8?B?a0swSmlDZHBUOWdTVnhESElNNHg5emdqc1BJY0ZyVnNhaXJpbGtvV0dqMUI1?= =?utf-8?B?OWhPRVpNcmFuVWNwZVJoc3FhME5iSGwzSjgzNkpCSnVVTVJnY1h3SDA5eWZt?= =?utf-8?B?Y25iZkpqZmQ3TEVmK3U3ZmgzZTBvQUhzN3FrdGVlZzZFZnpUSWRINHFDQzdk?= =?utf-8?B?YkQySUNDZFZIN0lGeTZkeWpXd1pKQ3ZoMWxNb3Rqb2l2SStvdFdNL0RRSkZi?= =?utf-8?B?cS9jTVdRdmRRbkV1cEFQOHZ2WkpxZW5LcTdiMzBqTmlLaU5pVVhqTWVuTlYw?= =?utf-8?B?bnhKR0NyNVQzUnVxYU9DQW4yQk9abHE2UjlzZlFQZDg1WEtBR3dqVkM2T2hM?= =?utf-8?B?TER0cjhPYTkrdDVLZG9hTHhwdnpxZGg3WUVhb2o0QkZuc1NkcHJRUVVObVlw?= =?utf-8?B?b0hBZGJjSlY5c1p5bGNCU0JGNGFVT0VJMlRROTNXbDdWUWNzNjNab2E3UWhB?= =?utf-8?B?YTYrVVpibDZJVHh2YmZySUhWb2NXVjBZOXdyeE1tKzZBMEFXVnc1ZzZOaENx?= =?utf-8?B?QlNpY1VzRHo4eWZLTGFzOUtTZ0JYYjlYSVYzOUd1QVRlamRhd3dWQ0VGa1l1?= =?utf-8?B?OVRtWnBYcjFXemg3ZmY0eWRZQmFJR016b2FOVjExL2Rzd1dOSmFjaDZhalh3?= =?utf-8?B?akNLL1paTHhwOGp6bW8wdklKeG16RzlLRjVPZ3ZFazNzNnBOOGZxR0lIdDhE?= =?utf-8?B?RjJtMENldERrZzdSOWVsemZwWmZmcjFVeVhmOXpMOEFrRy9wTXgwdElwK3gy?= =?utf-8?B?ZTdxbGpTeStnajYvQ0VOTnZKU2xFb3k0NTRqT1ZFWDc2bFpWR1F3enpjelBZ?= =?utf-8?B?ckNVQzdFSDNBVm9CUlEvTm9Id2xnMFdVelgwUG9LcUVSVHEzTjN3OFg1QkZm?= =?utf-8?B?RFZxVWJ4cU9JS2tUcHJqRUdPcnloRExvNGJkVVQ2MGJtQ0JUMXpvcmVQdFhw?= =?utf-8?B?c1VuN1YrSjFhbVErSzZvZnU3cTFNaUVYbllERWNIZy9HQWRPbkFLZ2ZIeVdm?= =?utf-8?B?VkQ2RmEwOHBXc3l2cmJMZmhoa1V2dFp6SjVnakw0NE92dElDeElFb3hxRTZU?= =?utf-8?B?d0lYRHZPdVRMUGp0Wm9xdmI1UE8wNlBsM0JFbzVsRHU3SkROMHBJVlEvZWZP?= =?utf-8?B?MmtHN3NGY1ZiVDN5WnA4SUNBTm1tcVUwc2orRWI1aktKY3IzNzUvOTJ1clE5?= =?utf-8?B?Z2JPRGtzN0pjMyt2cnVjRU0zazJ4RTh3OWVva2k1Q0JUT2ZMem9GSzQ1VmtP?= =?utf-8?B?bmJIZ3FmYlhDV2Jhd1o5VEcvMTFaVmEyR3N0TUJiZm5WMmw1amF3cGloUklO?= =?utf-8?B?WjNXSDVkVXkwZTNTcklZN0NZbTVmb0RHamhkZ2FNRlBndGJLYjFhVlJEY0xI?= =?utf-8?B?WFAzODJEY3Nzd1cwOERPUVR6NU0wWUZQcWFmejBYMmJnU3pRMDFWdnh0RS9H?= =?utf-8?B?YUF5cER0Tkh0WFdwaDJCNy9PMFYvRmlidThBZW1wN01LODFyVHdPRmlqNXBB?= =?utf-8?B?c0ZrM3o0ekZ4VDlPMWt3MGxjWStLbG42MER1RU1jM1FwUnZwMjlMZWRTeTZW?= =?utf-8?B?SURiMDVQbmxyVU1LU2hkcG9PTERyMFhaMm05aVlmOFF1Y1JPSVBZS1dLMXJp?= =?utf-8?B?WVI4WE1ZNVNMNGExNHQrVjhmdDdSUEE3dU1Ma05QNW9yQ2ZQWHovb1IyWFBB?= =?utf-8?B?akZXdkZDVHFCU2FlcSt3RTVmd21QMWpXQTVHWHZHdW9KSENHdEJEd0M0bmJ5?= =?utf-8?B?Zk9rWjd4MUs2NzBabXkrRWxaVTFqdExFVHhyYVRySnBSMGlJVHdVdFliUU45?= =?utf-8?B?dlV1RmpXSlZqTGM0QWozTlFFV0w5N3p2bTVXREdYMG9hL3FoUzBodVU4YzZo?= =?utf-8?Q?5lNWSL9MmwDhXnP0JIFMhyW2p?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87a257ed-8e9a-4a59-507e-08db1409a929 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 12:46:32.9937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o7h1FL8wamwtCXtoiI6QZNdHP76ciYgIVUqNKaeOmqwORLKW9aSPgrnIiRHNqWzeSlTwzS2oZai5ZL3m54+JXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7715 On 21.02.2023 13:26, Andrew Cooper wrote: > On 21/02/2023 10:31 am, Jan Beulich wrote: >> On 17.02.2023 13:22, Andrew Cooper wrote: >>> https://github.com/llvm/llvm-project/issues/60792 >>> >>> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >>> unit, and the XSA-426 change tickles this bug: >>> >>> :4:1: error: invalid symbol redefinition >>> .L1_fill_rsb_loop: >>> ^ >>> make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 >>> >>> Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mux %= in >>> too, which Clang does seem to expand properly. >>> >>> Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") >>> Signed-off-by: Andrew Cooper >>> --- >>> CC: Jan Beulich >>> CC: Roger Pau Monné >>> CC: Wei Liu >>> >>> v1 (vs RFC): >>> * Rename \foo to \x, reorder WRT \@ to avoid needing \() too. > > Sadly, this is not quite correct.  There needs to be a non-numeric > character separating \@ and \x or the concatenation of the two can end > up non-unique. How that if \@ is always 1? >  So I think we need the \(). Or put one at the start of the label and the other at the end? >>> --- a/xen/arch/x86/include/asm/spec_ctrl.h >>> +++ b/xen/arch/x86/include/asm/spec_ctrl.h >>> @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) >>> wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); >>> >>> /* (ab)use alternative_input() to specify clobbers. */ >>> - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, >>> + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_BUG_IBPB_NO_RET, >>> : "rax", "rcx"); >>> } >>> >>> @@ -172,7 +172,7 @@ static always_inline void spec_ctrl_enter_idle(struct cpu_info *info) >>> * >>> * (ab)use alternative_input() to specify clobbers. >>> */ >>> - alternative_input("", "DO_OVERWRITE_RSB", X86_FEATURE_SC_RSB_IDLE, >>> + alternative_input("", "DO_OVERWRITE_RSB x=%=", X86_FEATURE_SC_RSB_IDLE, >>> : "rax", "rcx"); >>> } >> Since inside the macro you retain the uses of \@, I'd find it desirable >> to keep gcc-generated code tidy by omitting the extra argument there. > > As I said in the RFC, I tried to have x=\@ but gas really didn't like that. > > But given the concatenation observation, we also cannot simply replace > \@ with %= (given the option, which I couldn't figure out), because they > can overlap. > >> This could be done by introducing another C macro along the lines of: >> >> #ifdef __clang__ >> #define CLANG_UNIQUE(name) " " #name "=%=" >> #else >> #define CLANG_UNIQUE(name) >> #endif >> >> Besides the less confusing label names this would also have the benefit >> of providing a link at the use sites to what the issue is that is being >> worked around. Plus, once (if ever) fixed in Clang, we could then adjust >> the condition to just the affected versions. > > It's only Clang IAS, but there's no suitable define to figure this out. "this" being what? The case of Clang but with / without integrated as? Since we have to turn that off, we could as well add a -D option along with the -no-integrated-as one. > And while I appreciate the effort to be more descriptive, this name is > literally longer than the thing it wraps and ... > >>> --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h >>> +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h >>> @@ -117,11 +117,15 @@ >>> .L\@_done: >>> .endm >>> >>> -.macro DO_OVERWRITE_RSB tmp=rax >>> +.macro DO_OVERWRITE_RSB tmp=rax x= >> The "=" in "x=" isn't needed, is it? It looks a little confusing to me, >> raising the question "Why is this there?" > > Because I started out with u=\@ > >>> /* >>> * Requires nothing >>> * Clobbers \tmp (%rax by default), %rcx >>> * >>> + * x= is an optional parameter to work around >>> + * https://github.com/llvm/llvm-project/issues/60792 where Clang-IAS doesn't >>> + * expand \@ uniquely, and is intended for muxing %= in too. >> With the above suggestion I'd see this comment move to next to that >> helper macro, with a link to there left here. > > ... there's no getting rid of this comment, at least in some form.  The > parameter is odd, and needs explaining. Of course, hence my "with a link to there left here". > Passing %= unconditionally doesn't matter for GCC/Binuitls, and in this > case, attempts to "declutter" the niche usecase of inspecting the > assembled file comes with a substantial complexity at the C level.   > It's really not worth the extra complexity. I wouldn't call that one simple macro "complexity". I'm in particular not advocating for (conditionally) removing the extra macro parameter. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:11:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:11:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498872.769802 (Exim 4.92) (envelope-from ) id 1pUSQM-0000R5-N6; Tue, 21 Feb 2023 13:11:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498872.769802; Tue, 21 Feb 2023 13:11:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSQM-0000Qy-Iq; Tue, 21 Feb 2023 13:11:14 +0000 Received: by outflank-mailman (input) for mailman id 498872; Tue, 21 Feb 2023 13:11:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSQL-0000Qr-4v for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:11:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 307e1a03-b1e9-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:11:04 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 08:10:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6557.namprd03.prod.outlook.com (2603:10b6:510:bc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:10:53 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 13:10:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 307e1a03-b1e9-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676985063; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=bjcQQMHaCLQXFhK7s2aRZ3B0LEiyRdl2C9TII1BItfQ=; b=MGXF1ll84fGW6+434XeCc7hT7KbsUuhAxQVK3TRvJ7rhM3JM5aPmpBmw SWIx5e7/AcjrMWn79yaZyuNboZqocVWMEajIF1K2O9CYW3eqs1CtXejTn /PDAMTuQgHVD/ish6MyIoHgMARwwtMMZtqGauwXSOiVKdS30AMAaXi5pf c=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 98299614 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TYPi8KhlY0M+CAX8dPvYQOa0X161QhEKZh0ujC45NGQN5FlHY01je htvDzrTP6mMYjT0eIhxPoS/oEID68OAztcxGwdo/nw0EyMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWHzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRIKR8/fB+cndi2/+KJYMYy29oCNMPSadZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6Re3ip6802QH7Kmo7ARsQdUOFkNCDk0Ofdc55O Wc93hExlP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDRLoViMA6tjn5Ys13hTGS486FLbv14OlXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94eRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:YuROX6zCaGcHMB9Xww5mKrPxMegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67SdC9qADnhPlICO4qTMqftWjdyRGVxeRZgbcKrAeQeBEWmtQtsJ uINpIOc+EYbmIK8/oSgjPZLz9I+rDunsGVbKXlvg9QpGlRGt5dBmxCe2Km+yNNNW977NYCZf ihDp0tnUvdRZ1bVLXyOpFDNNKz1eHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lMzQi5C2rAr9E nCikjc6r+4u/+25xfA3yuLhq4m1OfJ+59mPoihm8IVIjLjhkKBY5lgYaSLuHQYsfyi81Ejlf jLulMFM95o433cU2mpqV/G2hXm0hwp93j+oGXozEfLkIjcfnYXGsBBjYVWfl/w7Fchhsh11O Zu03iCv5RaIBvclGCljuK4HS1Cpw6Rmz4PgOQTh3tQXc83b6JQl5UW+AdwHI0bFCz3xYg7GK 1FDd3a5txRbVSGBkqp9VVH8ZiJZDAeDx2GSk8Ntoi81CVXpmlwyw8iyMkWjh47heUAYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMUqJSG6XVJ0vCjbokdra8b817OaldNgj150pgq nMV1teqCobZ1/uM8uTx5dGmyq9AVlVZQ6diP222qIJ/4EVHNHQQGm+oREV4oWdSswkc47ms6 3ZAuMQPxfhRVGebbqhkTeOHaW6EkNuI/H9iuxLKm5mnfi7WrECltarBso7d4CdWAoMayfYPk YpegTVCYFp0n2LM0WI9SQ5HUmdNXDCwQ== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="98299614" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5HSlNjrn0IENNwu7nNVisWpBVqOsvOKihnL2yIz4Sz51PR0N7fNLsBpP99qeTckcdnk3MVPOYOGPVQRRN44HpFT7qmAICGi/raZgf8k3mM2P2un9nl4sn3lmzGbvUiBkWrrt9HIfJfY1aaGVRRSimtdmBal34jDl8ZJ2H0NNMsLRszyoZaqq2RoW3HUcCkeI4sr3qspyqR0yVjpMaqgsoDvDQozAMpRKo97YcAtBFhmeg0l9U9tq6WBSbI3n263NKWNY3eGqoBzxPmIX8/5nb0bGmClkNVP9IsrrSFKlf3KgyjEM45lvEtUYW31zRT/IvVVWCWEpID+7tLIhEAqng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGg+S/YX3ih7sldNRpJcUDqZqWYCbeNPIix+ilwvGVs=; b=S4EbC1JkbSSoca2ncMI4q9RqxdfUJD4TCFwq6ksIkFBMTQuGXe40/33GhVL6hM+q6pS9w3bkhHSZBHttTsp/xi50p75R+iEpysuEA4aHWiObMtKE+kuEmsNVWrdAUep2JYC/AmfPRz2964QaFUGDoNGLVeMItXt9ekZGeJUz9uXt2qXin2zEkIsDytqFBI9HDCOpcUF54lrJ3yP7juuB2wsypdFYbupyELNTzXeeomuCmQpwAYxbUwPiZipFUJ/dqFSTS7wXCULdAxiEUYfTxkyYmaOgAZci3TrpGIayQjhYoMVH64bACj6i+Vh6Ksh8lrLdWfuDxOrxBxZYSF8dDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RGg+S/YX3ih7sldNRpJcUDqZqWYCbeNPIix+ilwvGVs=; b=ArD9lEZDWKwCa1Y2uKgo6G9Qd5nQXPgwutRqniIKWxZrDBLS9Dk6fANAbRSvSbady+v6UFiyUD219ihTGeC5zSMFuQmU6TuP7mB3acMWwDkDL6F3jbAoB4h0hH7PsVyC2lWZ9n3eu/oGAWWTdU+UgmoxzpIYglkCJTPzumKqosE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <56b47562-4305-2150-5131-0c3966f11825@citrix.com> Date: Tue, 21 Feb 2023 13:10:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1] xen: Work around Clang-IAS macro expansion bug Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230217001914.762929-1-andrew.cooper3@citrix.com> <20230217122203.790737-1-andrew.cooper3@citrix.com> <04891259-ffde-a6ff-32a1-e3a84a7278ca@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0359.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6557:EE_ X-MS-Office365-Filtering-Correlation-Id: a25f8978-a6a4-44b2-9217-08db140d0f8c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2+vFOFvSb2S/423+8Vo3liPpK8TxPzCOcnp1oJz2/6cVE1dhL569/W5Y45P6chiCwkgq/2Layp2EP1TesyGHKImfPgmtdJWdvVGiAc7idRO/FkgzKF4hZRX14g3vt8w8sn7+JYYQ7sNKASnZ0o0aTQxhy0qumQ1IRPr5dwt+Mw+WJ4T+B/NMyCp/I9AjtFIs7LOHbllPGNeDRfI4ADno2SMXEJ1BmKK/oGwbibtzdab/wksyaNHdh3b1I4gbpUPWKLnlZOUAkBaoA+SiBFPHqHAxbm0kSLejlCHgHEqwCWKd15I68x3LkxBvOrD3I8lyoOgBEvg348QMAq+v2qR+WQSiB1Rxzo868aOPGZcppSUw40Veybd9kf6blV7FVxnFDtMtcydI0VrG6mihC4n3kKMeSihNpZLIT9H6zgayV1O287b/DNU6FY91+yvmwxDH7TRpJNvep5UCEAt5JFQx3Pm/eIkYdKTN4JSktKT+gbkq+VcNInE05xmRity9+5F+6ZkDo6roM2YIYvWN9lHV7WTlDKcXyFTgHHbH3lZCnS0YQ8K8qMh5bd7zoaV9K1DbLR4utukymL6oGOJ8ZEO0u7BWAgPFooke/ppw8qFTgNj2f3yNh2HMMvFhKk4DTsJnrbfri8qWTCPxDtGSb2LVvnf9cU+vvNUP47H1AhlqUmOpuFH/6NUqn09HfyxZg07AelTknSlQHcBA+ZoImxnh/W+5xwaIm/OTUs8XDX3F6JQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(451199018)(36756003)(54906003)(83380400001)(316002)(6666004)(6486002)(966005)(2616005)(53546011)(6506007)(41300700001)(186003)(6512007)(26005)(478600001)(8936002)(2906002)(86362001)(31696002)(5660300002)(4326008)(66556008)(66476007)(82960400001)(38100700002)(6916009)(66946007)(8676002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzlMYU44QzBOUjcxNEk1aFNvUFh5UThHeFhVWWxuY1YyOTJnWHppcDBpRmpm?= =?utf-8?B?V0tFbHJmNzJJcDRqanNhU0pjVk1NcUN4QTRCZTE0K1hpVlZ2bkw0d24xcjg1?= =?utf-8?B?OFVnY1EyS0hFWmdRSFF2TUdFNkhqcEFseEZJYVNTRVg2UmZxZTlEUzliNkZv?= =?utf-8?B?a1dUazJQaDFtbmlUR1RLYktoMXQyNEl0dG9kWVlKRGFldzdqVC9NQUlRSlUx?= =?utf-8?B?SVZHK2pVdjBweVozOEJLekI4NGRpT1pqRFRLTmZtcmxwSlczYjNUbkkvd1A1?= =?utf-8?B?dTMzUVhKZUFtQTJ2cCtCcFBWbEJxR0xFcEZWTysxakVxaDJVZ05WUU1mL1RS?= =?utf-8?B?Y0JLUWpPNjkvTnJnNEJJVkdpSElpL1d3TVZRT1VtKy9NdHN2eHd6YVdSQ1JK?= =?utf-8?B?a2ZrSTlXclExazEvYlU3dndtSWZDYTJMcG1KMjhIWGs5SnVGem00bGQ2U3Jv?= =?utf-8?B?Ym5QQXpGQnk1SCtiVHg4akNDTEp3QWdHUENPdXNraHl0V0dyaFJWZ0MwaGNt?= =?utf-8?B?U3pjemt3MytIVW5WNlAzWldTbEN6Vk9IVEZCankvNFN5aXQ5NWxNRUViQldV?= =?utf-8?B?OHNpZ09QYzE3T3UrQ1JPZmVKQUYrQjRjUTBqZDJSTGZmajVpQURtL0hhTDlL?= =?utf-8?B?MnN1M3dydi9RUHEvSndmZXpDb282U2NGM1FjMjRHd3JObm1wVmJFODduMzJY?= =?utf-8?B?MWdudURVNng0WUlkMWJQNk1BNlpyblpEMnA4ak9QcXlKME9SN1VjbUdTc2JZ?= =?utf-8?B?MkJienJRd1VuUnRIWVIxV3lXdDFlcWFMU1NPMHZkdkVEQmlYWHREZm1XakEw?= =?utf-8?B?WlBpYWE2V3NJWHZtN0ZyMFliUTNrcnVKRGlISVV3YUlOdVNGeWN2QllweXNF?= =?utf-8?B?c1hxZGIvZ0RURW9KQWhWTTkvajdBV2haTHdwcFl4aThzSEV0bXFrOXFDWHE1?= =?utf-8?B?V0RmTlNiZkpVRzBOdEFVTDBkbUtMem40Ly9NWmoyN1ZWWkExb2ZUaVdmSHNU?= =?utf-8?B?U3FMa1AzdTU2ZlRvZ0luMTNyVlNyS2VCVUM2UndGWnlveExKeVR2KzBVRm1n?= =?utf-8?B?REFSeUNVN2I3dldCWS9ybHRWSVBUWS8zU0IybXVMQUpjRFcwMDFCRDM0SWIy?= =?utf-8?B?dXRnNzJrT0c1SWJaUERuN3RLeTZFTmxvZmZ6WG5pMDFGaER3ZURudGNmTHhv?= =?utf-8?B?V0VQUWU5OWcrZGp6N1c2YS9WdmRLWUNMQkZyWkNCMWRjdkNhWUlKcU1zaEJX?= =?utf-8?B?NkZXSzVqR1JmS2RiUVVON1QwUktHSVdzS1A1S1dCaUdrdWZGMnowWDdKMTlE?= =?utf-8?B?VTVCNXh0ZmUwUk1wUDg0NUp3RWtOQXFkbkZjem5ybThubGdWdFc2ZDdueXp0?= =?utf-8?B?V2hWWHJuVis3VVVHRmhiZGpJZ3Y2N3ppdHpHTmgwRFcwM2FzWmlSb3Rrdloz?= =?utf-8?B?b2R2cVBqWmZBK2g4TGxoZVU1NnkvWk1nTDV5Q29pMmdUL095MExPY0Z6Wk9W?= =?utf-8?B?b2EwdlQwREhyZEpPaVNhaUdycGdBdkNlZno4RmhkU1d1cGxjN1NzdDV2RlNF?= =?utf-8?B?V09uWmhDY3ZCUktYMVE0L2YyRVlUak9ONFRCZzhEd1c2cVlSeE9BNUhmU3ZR?= =?utf-8?B?Mmh5YWtsYTJGN0RacEhzL1F1WDZTRm8vN3owaGhOOFExQW9XVDFPWlQxWkV3?= =?utf-8?B?UDdxLzNXM2Ryd2RIV3Z1bW1vU1dhVEJqTWw1T1kvWDhvNGtxclNWbUVLY2xr?= =?utf-8?B?bjFIWm1VMk1heVg0VUFLSk51L1d2SC9kWXdLN0s5MW9GNGlEd0ZQczFOM21O?= =?utf-8?B?cmc4ckFnQ1ZsYk5zVDZLbHFraEVqOXp0WDVuMFBNMkpSWnZsdnJkUnUyT05x?= =?utf-8?B?S2h1ZFljKzZtYkx6LzVJWTdQcUZ5bDJVSlpCSWRUWWdmNC84ZEFrWlFlckps?= =?utf-8?B?ZzJBcXh0cGl3OWUvY1M5UnVmWkF2aU03Wi9uQ3lJbnFGa1gxS2NEcGNPZXRm?= =?utf-8?B?S0JsZk9EVVRqb1ZIaXNRNjFBNXg4em5YVmtNdDkyK0RreS81SVhhZVowNWFh?= =?utf-8?B?S0N2bzk0TlZTZyt0Zk05RURiZU03bjNMaXMyRFowd3FONW1lVnlWYU12OWdn?= =?utf-8?B?SXEweDliWkJFaUxxbkttM2tkTFJzbVVoNnpDOEZ6a2VGWmRKVnM1NFdxc3Vp?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EsNtB14i+aKE2XaeCAsN4oQdIZ5BTai9DSEJIqrnXi9Ocy+279e7bmcaxXGM1T7y/H5p3viebwDLusyB+gP53qU/feHKermYtMSybLIr9VkYCVuqFxlmd9wSlPJJX24IgSshr+FygjcihJkH/BV2nOQKBPd1/17q1nRMAzghz1kqFMMOm202yhutNr/NgZ0564R1FsGoRcqN2ye/9Knmh12jjMuoOttjxUpvPgRN2FIrbBn9zM+mndnseiB5jHNGugqFuN4X4l8pH9/FaFBCwAybKWDWYVB1VvfdHXzqAnBsSydHCt3gmG2oleT3aN4+dPOwGcSlkCGrpK9obtAlEoekd1NBvOfRcTTTQ2YPJhA5RtC+GGs3/+htCs57SV+Wl5FOEy9YghA69dU0mFgRk04m9A6ROQmgiHPuSSTzRygcIX3WUxL08X4f7qLB5KiRLnTbZkSk8l5cQpHzPyySJydnTdN2Sm5hd+97IwwLHOH5y/25x9ADSzsQM+CzWoGIC/z5DVAHyDchcrwOJ8coOXsxqsWKkEDqbFPm04w8llCzQNk4a40+EnrEprT88f5Spu7rVihsRIHY0CpPsTlxBa7S5RfL0HUG07sLo90wZ/wusqW+xYRbS7l5+OfDUdgM3zVfDpsdajRfwEmMpvGWXS5gMqwpAqet/4vsmzF/ZoK1FiW+Az9dwGw50/Id8nKcjPlG2+7VPvR95Iq+xTV+ualmvjdQy9pnVHJUO1cMvQnm5085ZpQMgBmw3IKGCuJM+UR6EPwedElapvv/vV/bvvn5jLGcWJ9iLMAyKOLY2QnIDznMT10/urxIpHfRUJ3G X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a25f8978-a6a4-44b2-9217-08db140d0f8c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:10:53.3558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /7JrUerVO9hrI+4Tm/Pe7wRNnP0HwbMK+ytW/Gdt8DDJp++K4wcyvAAQnaQUqhOMxwO0w24aMEVuo+fC6YKEnH429UI3PdxDuiAgn60xHqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6557 On 21/02/2023 12:46 pm, Jan Beulich wrote: > On 21.02.2023 13:26, Andrew Cooper wrote: >> On 21/02/2023 10:31 am, Jan Beulich wrote: >>> On 17.02.2023 13:22, Andrew Cooper wrote: >>>> https://github.com/llvm/llvm-project/issues/60792 >>>> >>>> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >>>> unit, and the XSA-426 change tickles this bug: >>>> >>>> :4:1: error: invalid symbol redefinition >>>> .L1_fill_rsb_loop: >>>> ^ >>>> make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 >>>> >>>> Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mux %= in >>>> too, which Clang does seem to expand properly. >>>> >>>> Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") >>>> Signed-off-by: Andrew Cooper >>>> --- >>>> CC: Jan Beulich >>>> CC: Roger Pau Monné >>>> CC: Wei Liu >>>> >>>> v1 (vs RFC): >>>> * Rename \foo to \x, reorder WRT \@ to avoid needing \() too. >> Sadly, this is not quite correct.  There needs to be a non-numeric >> character separating \@ and \x or the concatenation of the two can end >> up non-unique. > How that if \@ is always 1? It isn't always 1. Global (file scope) have \@ expand properly from 0 to N. Function scope have \@ expand properly from 0 to N in a single asm() statement. The 1 here is actually because mknops took the 0 and didn't use it.  If instead we had something like: asm ("DO_OVERWRITE_RSB"); // \@ = 0 asm ("mkops 2;"      "DO_OVERWRITE_RSB"); // \@ = 1 then it would assemble fine, but the way we build alternatives in asm() statements reliably causes the alternative block to consume \@=1. >>   So I think we need the \(). > Or put one at the start of the label and the other at the end? We already played that trick with \n for the .irp, which suffers similarly with concatenation. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:11:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:11:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498873.769813 (Exim 4.92) (envelope-from ) id 1pUSQY-0000ij-U9; Tue, 21 Feb 2023 13:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498873.769813; Tue, 21 Feb 2023 13:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSQY-0000ic-RA; Tue, 21 Feb 2023 13:11:26 +0000 Received: by outflank-mailman (input) for mailman id 498873; Tue, 21 Feb 2023 13:11:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSQY-0000iE-9x for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:11:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ddbb205-b1e9-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 14:11:24 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9323.eurprd04.prod.outlook.com (2603:10a6:10:356::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 13:10:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:10:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ddbb205-b1e9-11ed-933d-83870f6b2ba8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JUS9bAra+3l6RLaOF3fPV6C+7kqSonSu1A2oT80anbbWL/P5OvyjedTtdEuepttsMLngruIPfp6zoFI+t0ujpqFs+Y7I+VV5zbyQISlZAGIbRU0lA6v3zeNfbsqUIYCnDAUrKYsCFL6TAopG6tAeAouNVKKPmFjWGGxbf7yYP+dhGL9kX3jZ3c9CpfaLzUod0FQXVMkgmvOg4xzKJeovric1UUx0jMLzS97hUhUZt0sRWCXjP33S2e7l5Vd/KZMbeJlLQjjRqX6jmxAz+v2yfliI3apWKuTQjh5Lj379OV+ACSRwitOXG0W1cVnQxr27AdbvD5VAuBQKMLH/SPbPfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCn4oP6M2cAS/Hs26RYklNpRZNWqAmNzHQY8Wwk+2KQ=; b=dgzD2oLDAUeqzxYYegXpTaau2C+2M0eT84cr4TrzO+DmiaOssHnsc8E54JNARp35KNXylTIWVkfDGYHVOFlNQRxpl5KXFRoiuoWlT3vvnQS4ufPteS0/SIZAgyuhZP1jVoTzNjO4mY6Apo8PI93rt6UNkpHHLYV+YTdjCedPFGj3ad+gKFaXUj2vwXBVqWJ3b/vrcaWYfY+SqxJHcAynZAqCOA1WAmNC95J1EegggtvRn9T9NJYkM2nd0cvxu4lsjWtnW9/70/pB13Fa8iONIW87aGlH8oZkuIT6QMEGs/NqkfpG0G/l8I2Y0Z6wLNVH1Gyx6td3Uss32F0BlPRcNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCn4oP6M2cAS/Hs26RYklNpRZNWqAmNzHQY8Wwk+2KQ=; b=ljpKxmSzjqb7nB7umLsFetM908b5U4G20PAuWx7spOawsltFA77tnB/a6VUrDzDWSBJnnkws7Sb7TcEw/sLqj07TWR83me9Z1E2oGgfLhsy3AZHkHaImbN2F9szBBo0ph/s2/kyjiHNr46zG5X/nLIxbSqqikrI68DZh+zZrMqqhQIUTxt3HdtA4vRi7aRTBsN3GbksBM2BaybJv4duGp/drn7mZsbP73q+4w0B4Vq4A0oKVXM8FdQbHAajXkgiDW1qtq8vs+Njp9pWFtMtbkthSc852ZHQmJfJwIYlEgNFmag6llyWUm2KXDcJvQq77AzTgvwnPQ1za6ddqnzlKaQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1684ac85-f9ac-a57e-9529-f2e09f6f81ff@suse.com> Date: Tue, 21 Feb 2023 14:10:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] x86/treewide: Drop the TRAP_* legacy names Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220115956.1522728-1-andrew.cooper3@citrix.com> <20230220115956.1522728-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220115956.1522728-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9323:EE_ X-MS-Office365-Filtering-Correlation-Id: bba545d6-a6b2-4f40-1af6-08db140d10c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y5J6Vgf53HC63dITvhWInP7WxNt6wZX2Kxc7q1S2Re8ZcAclqLPm7+2rHivw5oVo18BAXbUCcgYe1PlmUS64kbrJHKKoLY28A+1+iFu8vM4UnUBKPODxEXlbSIEn4VUsHlo/x+9/nq+PALK+4RfcvXe8+ELOYHhQHDJLTpJ5Ermbj2fOvK0cvzDpr9sqLBSaMHFe6y2sIQnVT0eRspW5uonR1XrmqVDuZH5qg26gcGzq/6gIHZfM5tuXJNu24j2bPKGOmlcFzkHgTSq9zcyQ6/YFXOkWwvjrvfByek/m8vw99O0fvcGCoiLzRBxOMbM4+Qet+4yA01cluntIH0WOiJb+U3JREH5dftaDADf4w8heAeoQvPyak3x4mtrWBLoXLpKG8N4FiBvTMzihBNvechmMf91HDBuBN8TvnsQSiXDdGqN2W2kXgzLR6ZV94d00BHGxT014tXEMe6jRLJvMMXK62AH388fjw6cLnR3xlAwKgaX80mZ4IYO0oPrPMtxYBT/b49IF8XVASfK4lvPq8Njny5be74DzLeUxg8qCdJCo31heQrIKl4AGlnLtVBPNbSeDlb6K+/3dFQnkUiLi/aq4v1E9UPou70Op9oF6CYIpNjHfBBSZhuWZ+FCLj0I+sIeUSP1Yxouw+hZ9KAgmn/6Tn8/cXZBANVWShjNR9R7PiYactbbM0hmzY67rIgUFaujnhVa6yNrqLdjqr69UuJahcveaddXAJq3YpYsYSjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199018)(6916009)(316002)(66556008)(54906003)(41300700001)(83380400001)(66476007)(8936002)(5660300002)(2616005)(8676002)(4326008)(186003)(478600001)(6512007)(53546011)(26005)(6486002)(66946007)(6506007)(36756003)(31696002)(2906002)(38100700002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?USs1Vk9RbFpMcm1IMlhzbWM4MC84MkJmaTh5Zm10d3lFamtvb3I2RHBsODBs?= =?utf-8?B?aUJWbmhkWHJSOWdDZHRXODcyL0ZENnVDZUZ6NGdiT0I1Tmk4b2pnYm1aaU5v?= =?utf-8?B?Y3BBQU1uOEI0ekE5M1RBWTFBWjZqU1MxMGdmUVRrTUpJbmlIeG92U0V1Z1p5?= =?utf-8?B?WC9rQysvNTE2Tlp0Tjk1eWlZeEZtMmtqbUV0RmtJdlRmYVZKekJZYXhjUUIx?= =?utf-8?B?VkZPazV2dmNXS3liWVR0TEpwOUxpTUk4WkdiSG4wV05OZEtmbDdwUnlvWk83?= =?utf-8?B?MWJjSTJ2Zm1wSDBpeTZnbWNFL1hrRzlCNU5GL1U2L01lbVU4ZXVmN0xNRnFP?= =?utf-8?B?ZEJyOHNkTXdxbXZidDV0eFNJenVlMFNuZTVVOTZmbFp0cXpheEREUCt6amFV?= =?utf-8?B?MmZRU05YVWI0VlRHR2RWVUMwQzhZMTYxWWJDbDB0TG0vdVVTV2E5M0NLWFdp?= =?utf-8?B?STc1VjIwVzJ0dFJEZ0JJZ25BSlFWUzdmQW0vOUJJeGFOQ3RSRFRtaVE2MnBa?= =?utf-8?B?TXh0ejN6K1labW9RWXhZdzFKYVpqL01zYVZhblFVZkh0RFNYanFkcEl5dEZE?= =?utf-8?B?WFhnSUlDeTgxNnM2NUhMcjRjTmpuS3FmOGhoRnFzOGNPUTBQa25YaDBMWDNq?= =?utf-8?B?R3pNV0ZJVmJqcUgzMnpPMFZJQ2d0SEptOElCVGpleDMwaERvVGFkWjRqV0dq?= =?utf-8?B?dUswSDFSdjJBTmdQU29MYmRiWnlScDBQaUpQQ2VnL1REUVNUYmdhaXNZRTZK?= =?utf-8?B?U1pqZnpNMmRTRTZVTWFTeXVGbHVPZU4zOHZjd1R6eW9UR29PN2lrTnJJN3dv?= =?utf-8?B?MWp2QXBvd0t0TkJ2akJoRXJ2bEtuOFQxNm5NM3NVL1l2QzQ3OVNqeWZiY2Va?= =?utf-8?B?alB3RXMzY3VYSVN6bXhNNk93VmRvbHdhMExKZjNCUW5CU3BQdjF5T0Z0MUlj?= =?utf-8?B?anR2NlFZMUxjYWxnQURtS0YxbGlpOFBBaXJVL2krT2RGVFdKNkFZZzB2UEY3?= =?utf-8?B?T2EwUU85aExLa1R5M2dnQm9NNGsvaURJYlJIaTVNVkFjVHBGYWdmZFVrbkt6?= =?utf-8?B?Slc4TGpkRVNEL3hjdzhsbkxNYXA2eHRnNGhRSDF6cU4xY3VIc0hJdzRHd2lx?= =?utf-8?B?aTgrekZybGNwdWhMbjhKdjZsWFh6Q0JJQnNNM2lLUllvUThLWHlFenU4d0VS?= =?utf-8?B?ZFFVSU1jMWVEUVBpcDVIMncxWExRMDd1bCs0dG5XbXlNOFFCaHZwVURFVklo?= =?utf-8?B?WnFaRFRvRHAzWVMxYmF0RENZdk5PcUZSWnZJcUNZbXYrZy9MTm96cnhFZjlz?= =?utf-8?B?Zmo0UWNQbVg4YXhRV3lrRjA4SlJLYnlUVGo0d251bXZLemxEZXpJa0JlZ2ht?= =?utf-8?B?dDFLWFNzNHpQemowSExZTWNvaHhpcFNZTCtWbEkrcjNhajkrMHVkSWUwcDU1?= =?utf-8?B?NEFoQ3NHRWw1bytlenRxSzhza1FxMFM0WXF5R3JFcUtEcjAydWNESkhJeFRm?= =?utf-8?B?UlZ1WVhVSkxrUlE0SmMyYXpRd0l1Uzg4ZDIzaTN5cVJQZVlYN1VqcVlCbDI1?= =?utf-8?B?c2VPUVZWSjJiVlhqbklhemFkNTZ3QWh5cUwzb2l4YkQ4d2Q1d096aHRBNW1X?= =?utf-8?B?SlNMRi9zTUI1RnlKckQ4TWd3NXdaMC9jWXhpcmY3bFVxNGRZZk1NYU1Qc2pm?= =?utf-8?B?b1ZQNEdVNEtJa1RRcGFuS1RTZkxSakE0TDhGd0tWOVJSS2QxSDg1Y29teEJk?= =?utf-8?B?SFV2Zkhmcy9Qc3hiTkdyY1B0R0NINHd3VmhkVHJJMll4QnNzQTErMU1ZV2hX?= =?utf-8?B?b1BKejdQV0dPWVNIUFdQSkl0RVV6b09nWkhpS1RjNmRWQmJoeDY3UnZXZUpP?= =?utf-8?B?cHJoODl2aDljVUNSaWZXTlF2V3JlcTh0WThYSlFUaVk5akR0K2ZsbmM2VkhX?= =?utf-8?B?RmpnSGVyaHlQTURNQmdCT0laVk8zd1ArNTN3YTN4K3ZiaWQ0eGtaZHdDUDZm?= =?utf-8?B?Z2Iva1pTNjBOZXhiWlI3UXg2bFJDZm16bE5zYWx5Y3Fkc29zV014MWJaR3A2?= =?utf-8?B?NFNZVDJaaWN5cHh5a01oaGRTRExTOWVMMXkzT3lXVS8wOEczRDlIcEdUSkhD?= =?utf-8?Q?DbEJyLpBu1kCu87/DC27OC/IY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bba545d6-a6b2-4f40-1af6-08db140d10c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:10:55.3390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GeQR+w+Pk4wMA7FCyHgE4SeVWxmDS52VcfMNYQVU3Z3Q13LkRkzVC2ZbI3N58J2mPUTtSuN3l/oXXGF9j7+kJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9323 On 20.02.2023 12:59, Andrew Cooper wrote: > We have two naming schemes for exceptions - X86_EXC_?? which use the > archtiectural abbreviations, and TRAP_* which is a mix of terminology and > nonstandard abbrevations. Switch to X86_EXC_* uniformly. > > No funcational change, confirmed by diffing the disassembly. Only 7 binary > changes, and they're all __LINE__ being passed into printk(). > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > --- a/xen/arch/x86/mm/shadow/multi.c > +++ b/xen/arch/x86/mm/shadow/multi.c > @@ -2745,9 +2745,9 @@ static int cf_check sh_page_fault( > * stream under Xen's feet. > */ > if ( emul_ctxt.ctxt.event.type == X86_EVENTTYPE_HW_EXCEPTION && > - ((emul_ctxt.ctxt.event.vector == TRAP_page_fault) || > - (((emul_ctxt.ctxt.event.vector == TRAP_gp_fault) || > - (emul_ctxt.ctxt.event.vector == TRAP_stack_error)) && > + ((emul_ctxt.ctxt.event.vector == X86_EXC_PF) || > + (((emul_ctxt.ctxt.event.vector == X86_EXC_GP) || > + (emul_ctxt.ctxt.event.vector == X86_EXC_SS)) && > emul_ctxt.ctxt.event.error_code == 0)) ) > hvm_inject_event(&emul_ctxt.ctxt.event); > else Entirely unrelated to your change, but seeing that this piece of code is being touched: Aren't we too lax here with #PF? Shouldn't we refuse propagation also for e.g. reserved bit faults and insn fetch ones? Maybe even for anything that isn't a supervisor write? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:14:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:14:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498884.769824 (Exim 4.92) (envelope-from ) id 1pUSTX-0001ZH-EB; Tue, 21 Feb 2023 13:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498884.769824; Tue, 21 Feb 2023 13:14:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSTX-0001ZA-Av; Tue, 21 Feb 2023 13:14:31 +0000 Received: by outflank-mailman (input) for mailman id 498884; Tue, 21 Feb 2023 13:14:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSTW-0001Z4-Og for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:14:30 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab375334-b1e9-11ed-933d-83870f6b2ba8; Tue, 21 Feb 2023 14:14:29 +0100 (CET) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 08:14:26 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6123.namprd03.prod.outlook.com (2603:10b6:408:11c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:14:19 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 13:14:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab375334-b1e9-11ed-933d-83870f6b2ba8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676985269; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=9/DnHKdozb7q5W/ktgv0Wq2StSDL36ifMJlDECpxKog=; b=QA9jITpYIrDxzGSeuK0X33LK70foX5fYhpOGMFOI9bzzx2Bk8aam/vZG 96w607tErCsMquvV3VgXnDjmRb7DanosdkF/ieQV0fWpJSo8fo0YsQLOx zdNtn6jeYwEICKdAlfvNg7qdhsZpopAhsJjZ/lccnQN4FHAblbjThflhU 4=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 97806393 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xvItCKPo5/CFHsTvrR2elsFynXyQoLVcMsEvi/4bfWQNrUomhTVVy GBNWz+AOP+IYmWjfNonaduwoBsH6pODyNIyTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5AVmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0utKHDxl2 dMcEywAcAu7rvKt7pjlbPY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujeJpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewnOjBtlDT9VU8NZ3q0WpnTQLAiQXSFyiiMKgj0SyBttmf hl8Fi0G6PJaGFaQZtPgRQ+xpHmIuQEVc9VVGuw+rgqKz8L84QyUG2wFRT5pc8E9uYk9QjlC/ kCNt8PkA3poqrL9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWdi9T0HXT7x GmMpS1n3rEL15dUjeO84EzNhC+qqt7RVAkp6w7LX2WjqARkeIqiYI/u4l/ehRpdELukopC6l CBss6CjAComV/lhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:X8CFlKs0v4jhSHyEmAnoZ85d7skDzdV00zEX/kB9WHVpmwKj9v xG+85rsyMc6QxhP03I/OrrBEDuex7hHPJOjbX5eI3SPzUPVgOTXf1fBMjZskDd8xSXzJ8j6U 4YSdkBNDSTNzhHZLfBkW2F+o0bsaC6GcmT7I+0854ud3AJV0gH1WhE422gYyhLrWd9a6bRPa Dsl/Zvln6PeWk3cs/+PXUMRe7Fzue77q7OUFopBwMH9ALLtj+j6Kf7Hx+Ety1uKA9n8PMN8X Xljwe83amos+i6xhjAk0ff4o9bgsGJ8KoyOOW8zuYUNxTxgUKTaINtV6bqhkFMnN2S X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97806393" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U6v16eMDoWQPZngPl/bMOWTL2QoaRVa/CwpbMEF9wCf4geGuEUNSWCP5tkksG82bAH3opGWs0MZdM55cSY4/A1jDwmgTOwTp134GyUtHULdOUU17jwM+7pDJstGxIpYOfFPM/v6H58CFCBqxKHW4ebSPu2+QJaahU3f4cfSINKQoRsKqNg6jDSQ2G2NT2aTH76thqB0to1Nty4hcbsZodOpe9Z3LKh07XTVCUKx+ZIwAp8bUjkhd6z7IR277rlH8KM+H4Hh8WeJoNNDFIFqMpX6PD0+hmkn26GHhCnYTd5Fz/hQifQ+hPkb6faE/DoERBtE24FY67PhpLmG+JkP5bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/DnHKdozb7q5W/ktgv0Wq2StSDL36ifMJlDECpxKog=; b=BoVjFUJIX8QPUnIxPmtwR77Ts4E+406Tohg5lqpsYqOX1GUYOzi8S9pMfxqc+nxX8WjoPxoud5Ay4tCeeNLRB27WKPZGg5tEaO6P1ulERrqZct/HATWRmQp7gMGl3RGO1g51XRhtbBZlR/yIAEKrcKy9ah3UswrUf38ROw87olXR/MFA2p/dMqFluJWVBco6lEuWeyFyc88sqN29I8pm+naI/HpMMxrAuWhekrmJkreU3JOp4g4C9IMqgLMo9dl01U9+cyG75uC0tfafefVBbDruxX46x1ddjzqRaaCw7Twhk71EE0yRleTBReGtWXJey0zy75d3x0ngLuLJbNkBUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/DnHKdozb7q5W/ktgv0Wq2StSDL36ifMJlDECpxKog=; b=H4fyMyrFP7jCsHDHQ+4LvBILjLIFzjdNuom+eYgjbEzxDLH+xh30fN9M2QiRuYsPrv+B0mMud1XICjdslq6W4OTgwZiWRrpgABvQtzrUPS2aDIVYXoKcrmAOK6WRnwUUOboCLYV6AQJVjXszewsU1+/aRbtk+2ZhTqOuGi7r454= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3caf6e6a-e2af-60ad-63ac-ae1a4de8ac92@citrix.com> Date: Tue, 21 Feb 2023 13:14:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 1/4] x86/svm: cleanup svm.c Content-Language: en-GB To: Xenia Ragiadakou , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-2-burzalodowa@gmail.com> <0f35ee23-c6f2-9015-4328-266baf287156@citrix.com> <936cd14b-70b8-0c28-3aa8-85e5b3f2a8c9@gmail.com> <12c71fff-a27c-36ca-992e-1b1d1c075c4b@suse.com> <712f3022-3760-717d-7683-b320fb8dad3e@gmail.com> In-Reply-To: <712f3022-3760-717d-7683-b320fb8dad3e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0002.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6123:EE_ X-MS-Office365-Filtering-Correlation-Id: 8143f569-b162-4a9b-a6a5-08db140d8a10 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ufGZfCwLnlWbazvbp4EvgR/vLuTmM/6IlvpkN2NaiDl/eJpX81kVWska9GJuLKuG/te2SCz1DgmbddrPS3KlcXax07B6D40tgR4prIUL0tglECq2xNwlzwWBKlR3YO2dPgBxui+OZNr28pvHN12gC1rC+a9EFPW64BxpN1eldzj2ES9Tttb4b15VQJ3Ilrk9mQ1jTx0RhH0w0U0ZknjWn4L/3jByulKTYqPrzmoQLgnAb0LLVriSRCctZ3uwc5xCyySEIDGBT4hh80bGnStqX+RhA+9JYUC5NmhNGPp5XkajJrDnCyQlslocZlKZnIUD8pCmupmpx1wgqlh3u0gMXyNCKpgr6SJNm9qst798NqoYfE0ZQ1D7JPLKUSrnHYSV8Qytb8KGCcG2sBPfjqttZrUlB5pKRGJR0w7btnD2vtoiE7MouTGaZqhFrwFsPrhvea8KHUE4FS4XeJgpZWn7pepnprzcRJQEh71vfXaEChZVuGhqZTVpouXJBdirjYiB+vW2PjbiVBqQf3HIdiAq8EsdOcSEwqTxUlXlKyriZnijf3qu6CaKx/utAIlefLb81J1fQmwz7E/CmrrLKjCvi3FC1iABvofMT7vk6wbXQA5qaGOravkTpcaDvVZ6H6krxZJs+vlwDzPDr7/oyFeuK/mdhHWu73SfV/YrzavMAPZIA11f8NNnf8c5HPNi7vBfCYZl6eMQsvMP2fuGyPRXfmJAdmdC4kG5MdU/iuXgf0g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199018)(31686004)(38100700002)(2906002)(82960400001)(8936002)(5660300002)(6512007)(54906003)(26005)(186003)(83380400001)(41300700001)(2616005)(36756003)(66556008)(8676002)(66946007)(66476007)(4326008)(6486002)(86362001)(6506007)(478600001)(6666004)(31696002)(53546011)(316002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGtNYUNWa3pYQzdrMWNXVnZrVWVhVm1VT0hIcDVrSkMyWnlXSHJwYWphRU5P?= =?utf-8?B?N3p4d25PMC9ja2pIcUd3OHRQL241STRJK2NkMmtnSE5vN3BiQ01OQ2VRQkRT?= =?utf-8?B?Rmh6Q3BBLzhhaW1qU25RQjBPbnlFa1l4V3BLYkZzbWZNcDhkNGpZdU91Njgr?= =?utf-8?B?ZmlNM3EyaXpaa081TUR2aCtHSndlbDl5Z3dyQU5nT3hKZWZHM01maHlRQk5u?= =?utf-8?B?M0NaMk03cDFGYnlqbkhSY1VWYzh5RFR2T1dqZFUyb3RvLzZ2dzIwNVpRc2hy?= =?utf-8?B?Tlo4aG14bmIvVFlodDlzYWZrdkRNUGd6KzVxb2dlREtIK21qcGRUWWxINEdi?= =?utf-8?B?eGM0RVlKcHFGRGFGQk4xTWtreUVYRzVrd3UrZGhhd0dscDVoRjY5UC9BQWJi?= =?utf-8?B?aGhtcHFZMlJlenJ4cHJ1SWx0bldmVGNjTHBYSWkxOFJ5VzRCekJFUTRXaGQw?= =?utf-8?B?N0JGbWx3eEdidGI0U0ttNnVqc2g1MVNZSGQwL0E0SU9wRUFqMmVscEMwcVFr?= =?utf-8?B?a3U4ZUJOTFFEb0NWM3JwZTlyajJ6TDdld2ErcGt1L0QvN3ZoZDlzZDZGQkMr?= =?utf-8?B?Yy81VXEybUhybmw1SUNiME1VNGpETm9RY3gzbnF2ZVhLalRrS2o3eTJVMWIr?= =?utf-8?B?Y0k2QitJOWZDZnV5U0RWZ3FjRU5hSzRMWkVXcWt1OTA1MURLaytSSmZwb0ZJ?= =?utf-8?B?UnFoUTNpc3N0NmdFUWR2azNsUjJLWTFOVlhMbjZENTMvNHFXcTJYK2FYRmtI?= =?utf-8?B?NDdSMlRtN0czVnBFLzYxWE44SVJHUnE0ZUpkQmk1bVZQZ1dXcWF0dlAySGhE?= =?utf-8?B?Wmx6V2N5bW9EdHozUUYrbzBHeEZvc1V5cytqQTU3K3ZaclpKdHRnUWYxRkZw?= =?utf-8?B?N05ZdlErMVExQ2VmdFArcitkK05zMFRFQitQZkxVSlI5TEFRRjNtZXNUc2l1?= =?utf-8?B?b21ZRHB6N1liaUhIelFTMWZLTm1ORDQxZy9vY3M2b2tyOE5kdmhnRWpyYUdT?= =?utf-8?B?V25BbHdvQ1cya1BhQVlHZVFIcEhkbUVkVG5STmovQkh4OW9lWXRDcXhDRXB2?= =?utf-8?B?T3JHMllJZmJWR2ZjRVdFWmNjQWNnT1ZlaHk5WlRCOXBXUTdpN0gxbnNtMElZ?= =?utf-8?B?RTRidGZOK1JVRnhCeVQwQXI3WWc0RHhLK09uN1BOU0U1VDVJVkwxNFJuNnAy?= =?utf-8?B?NStJZ2Q4TFZGcFVxRHlwaUl6SW9oeEFrZzNPZHRvR3pzTGZ1bXV6L2JCdWNK?= =?utf-8?B?Z3FrVzB0OTZVend0SEhtWHFEdWh1SSt1amxGZ05RNm9YZU5vMlgvNGVic3Vo?= =?utf-8?B?QU5hZE9Ya0VqOTlwSHlwdk9ielpCNm5iTkZXbkk3UG9aa3hyVWJwZzlLeDA5?= =?utf-8?B?OU9FQ3pmc1JpWDMzTGNvdVZEMEpRU3NDRy92YlVlL08xd0JHYUo1WmNDSEhh?= =?utf-8?B?RHcrYTd3eTR6NTRCdjRsTEc3TlFvTXE0YkkvejhjYkM2NTdmc0NKR2h5OWhz?= =?utf-8?B?ZTBIRDd2bFk5bHo4WGxtV2hsUU9RZWVhQ2toaWNGSEdlbERTWGJUMGxWMVlD?= =?utf-8?B?cDZpeW5sWDZEV2UySzFtOEVjYXhSR0MydktvTWJjeFRwQmpjcFdOQkxZdmFQ?= =?utf-8?B?Umk5Y0ZDcmtvSkRGS2RDMFhqVnR5N1Q4NWlzR2EyMXZ4dGxyeFplZVY3Q0lx?= =?utf-8?B?MVRMSlBjaVFNSml0RVRTV1l6WW5HRVk2b2U1YzlYMVZtSEUzVElXSUprellx?= =?utf-8?B?OWN1bUc1UFFHVUlUTHZKZUdzKzllQXh4MDNpT0Y1LzUwQnVsQzFIQWcvdEoz?= =?utf-8?B?clhZVEdEWlR5VU4vaUVCSFZ2V1J4YXpMRGRlWkFxcTFYNlp3SW91UnpQR013?= =?utf-8?B?ajZ2d0tocXJXTjF3WmdSN1BnRkozV2oveCsvVEgzRzk5T1FGV3U1YWNMVFZB?= =?utf-8?B?NkJ2ejMvWSs5OTY3anpodCtqVTVLdGFtTWpGSTZZQXE5Z1Y3dXNYWC9OSG5U?= =?utf-8?B?M01rMERjcnFjaFVaMUlXT0JUc08vNi9jeWhLdDQ3eFpWSGh3VDR3djJ6TE1r?= =?utf-8?B?Y2I2YkJqRXRHNmFyd3M2VmFnbUZqeGVrRjlCYXVFSDU1OGVZUzFBck5IdHhY?= =?utf-8?B?cm1lc3daaVpUWUZMQjQwWlNxSmUvODdhZVk4VW9hTzFOZVRRTU56OHRzMDNy?= =?utf-8?B?UUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xzpcREKU2uB1FiKmXb3pks+dK1hU3lcTsxz2ufmyGufp5SDCb69Zqk7CR1VWtI7uccT3efGAyXQ/WeQEfXrRO7xxAj5iE1kFR25bsQCrccOOnkWIyRJXAZ6oFCK0T4Lj1QjX4SLXuRQZZtkr79iIAvM7tKAVQ8/wD+LdwkCkWNGgGqSavhq2qLOdLcJt5yfJponbwyguDkd8gEyNSoGCNH3WrIZistnm7q7ksccuDWQryicE30L/wbInq+rf7U5v7QK+CxDnYZZpE3sCIO6Dp++zMgBaPcz5w1ROoJPtAVHVnqkMj6cMEUYxxxjW/eFa8AjsCNJclI3CIeGSIXp2jFxDJ5f8JYgsu/WdbB8axvmZx0HqzbiZOZi9rLMQBQy9iAbhwPcdS446sEscChQFWnmIMP7bGA2qfadYxNlY9MpHqaKhsVwW/58ui5Ywi+A0gjDGotvSOqf9kqKnOjGM2K134u5Fmch35S1T36AMZSUIsVO9kQYmAAg6mtpEZRSb5CjVU8FbvaAs5rnj9wHnBny96PgBaLGk+DC9OCbVgB374bVTSgcCQmReitZL2mo6fWPa31KHXD0PPWmufaYyW9SWzj3mnLsqKTcvJJNxwF81wqJsQVlFWl3YH3T10j9tr6/rHq9+VBROdvI19Fnh6AW/YRhZh4CwbP/sSmzQUYYD5XWh3+SF0hS7/Q1Lmm1IHdM2/fO9QlBxmyUQEvjKYOq1y6pRE6r/KnwYGPTS9N1WiymD0/6WjZsa55qyKlyp4UWADfAxCRQdE2EFpUYou7CeyTorZYkczdSvGRBFnrcR7efF6JsnfHCAPUUZ4wIwGvxhVGS+G0GjY/X7481iT6x5b/8W791cRUfqtphyXps= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8143f569-b162-4a9b-a6a5-08db140d8a10 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:14:18.7472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0IpdR5uLu75yJ1DYIxmVW47jwHNXmfhaygEUo/f/q01E6kQSKeyro2KnOPKqUTViflnqP/Y87mNcjVyDM3Zj2FsI9rdPhATSZdwfLRZyaDw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6123 On 21/02/2023 11:42 am, Xenia Ragiadakou wrote: > > On 2/21/23 13:12, Jan Beulich wrote: >> On 21.02.2023 08:45, Xenia Ragiadakou wrote: >>> Hi Andrew, >>> >>> On 2/21/23 00:12, Andrew Cooper wrote: >>>> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>>>> Do not include the headers: >>>>>     xen/irq.h >>>>>     asm/hvm/svm/intr.h >>>>>     asm/io.h >>>>>     asm/mem_sharing.h >>>>>     asm/regs.h >>>> >>>> Out of interest, how are you calculating these?  They're accurate >>>> as far >>>> as I can tell. >>> >>> I do not use a script (at least not a decent one), if that 's the >>> question :) . I verify that none of the symbols defined or declared in >>> the header is used in the file including the header. >>> >>>> >>>> Looking at asm/hvm/svm/*, intr.h itself can be straight deleted, >>>> svmdebug.h can be merged into vmcb.h, and all the others can move into >>>> xen/arch/x86/hvm/svm/ as local headers.  None of them have any >>>> business >>>> being included elsewhere in Xen. >>> >>> I can send another patch for that. >>> >>>> >>>>> because none of the declarations and macro definitions in them is >>>>> used. >>>>> Sort alphabetically the rest of the headers. >>>> >>>> Minor grammar point. "Sort the rest of the headers alphabetically" >>>> would >>>> be a more normal way of phrasing this. >>> >>> I will fix it in v2. >> >> I guess this can be adjusted while committing, seeing that ... >> >>>>> Remove the forward declaration of svm_function_table and place >>>>> start_svm() >>>>> after the svm_function_table's definition. >>>>> >>>>> Replace double new lines with one. >>>>> >>>>> No functional change intended. >>>>> >>>>> Signed-off-by: Xenia Ragiadakou >>>> >>>> Acked-by: Andrew Cooper >> >> ... it's otherwise ready to be committed. > > Great, thx. I already committed this patch, with it fixed up, and one other tweak that we commonly do which is to leave a blank line between different groups of headers. It greatly helps people trying to figure out where to put a new header. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:15:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:15:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498892.769834 (Exim 4.92) (envelope-from ) id 1pUSUp-0002DH-Tk; Tue, 21 Feb 2023 13:15:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498892.769834; Tue, 21 Feb 2023 13:15:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSUp-0002DA-Qr; Tue, 21 Feb 2023 13:15:51 +0000 Received: by outflank-mailman (input) for mailman id 498892; Tue, 21 Feb 2023 13:15:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSUo-0002D2-Hm for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:15:50 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061c.outbound.protection.outlook.com [2a01:111:f400:fe1a::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db2747e3-b1e9-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:15:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8220.eurprd04.prod.outlook.com (2603:10a6:10:242::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:15:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:15:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db2747e3-b1e9-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IX877QcoPNjZxbtWvvdLmYxNeqF+Bpa3s42/tRSx1I4AaOAcoqs3QmBcszBGk9YT4cuYuvyd2wCt2fVpHrG2inFJeH64/VZoaZMyML433vO9ZTun4ToY7CkqPKy/iyva074XT5+RxIbMHeJLdg8m6C3G55py1IqlSdlrf9J2JizTQmN3bmiCBdvPg8cnmyyJlxbAota4O9Yyu6FBT7/R+ZY41pR5eIdMBUpPkNeh38i0JTls/q4PC2b3ZG6btZwx3fW8jLHIV9CjIWVFjJTBNPZw8e6ka8mvcZhQmOz+S9hIEWzBbCWwPPdIqbPAQLt9wtVbAYisnOs71CfeuOcMKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jmrmf4hy3NHgGSeKGiH6Xqn1/Nq/LP0hJLPg5IaRRKI=; b=CY2MVi+yXq7WCszgQWFp8qPJUDTXf/u0IvQUuje4Zi9yIg8SSGqChZaTWjcjxkEfCGrRIqcMDCUD5hSpoTawdRYRkIcXT1TFkSVNxTHKWmvvURLEIwgNULzGrq6OyBHmjTJmpj5a5b/0Z7RW8MeYv9gvvC14bsvMYaeSFsfQtiLoApsehfdlwzLQWixnV8xVzom2huAnoZx9oTHUyuGtFBgPsf+h44ZZJ7fw4AkcJB+96LW/ypt4zlwX/Z0tzfNTqv7iKtwL1O+qoavfzu62FnWfRLKCEOKGQfDDS/nAxIZhkN74vi180gR90dNZ3I/HCdd0bn/wP9mNg6KX+DN13A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jmrmf4hy3NHgGSeKGiH6Xqn1/Nq/LP0hJLPg5IaRRKI=; b=d7OhVZ9Cjd5XAnxsXB4PLfn9WjdzfcgITzlXvlsXN2pQqyczWhVW1xg+kHadB1kCkcTTa+PZ4qyVT4BDXzUd0PUM1YZL5yYxsbStGVfLQyyPUAf/54PrHpBHzZF4+WKfATHGgfJ+Y8sLd8G9CVWxgrjtljPnkSQL0nfbbD16Qb0+MXFAnSZlVbtoyqtTsgGwYUSMSV+gsY7jcFiijWp5Z8xtxUIyQoC0hS/NS3U74v24a4x9iO62meh1Arp51obFn+61sOYXJ/gUKjkpF4WhxWgxXOvIPnvaEvJwlxDn43lDLJLAs2ljBvTzUMI5y3mET24ductJC/giiOikzgiYxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 14:15:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/4] x86/vmx: cleanup vmx.c Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-4-burzalodowa@gmail.com> <3477e48c-e6bc-af9d-65a9-c6c0556318ad@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8220:EE_ X-MS-Office365-Filtering-Correlation-Id: 23d01a23-0d1d-4fd8-6615-08db140dbe75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RT3IAshtQ4H/mKMjUgbovVWZnFCjSWNUTeStFXKS2RVRDwQKJfyA2BLrlfe6xV3paM4lRIE+YZwsnKQFxayo5lgdyDGvToF8xe/yTn0mbunxP/uIHjKPo0aROk+vnab08p5GpUHOrbTDLSDiHo5xFdMWEv+WMcE3m8mExUQpHHzNw8Vfo09fkbG8G5zRr6jasi6YYU3h1LBkND9WyQLChsnQUzuVsQeD67fa6JqIbspkM65OT3Ykv9nzBQaCoa3QjmN8gLycCUFa6KI9BfJ/g6vK/CMGmKw0ILtsJKalQiphMAixLzzTeY950ilw+gtp/0Z4KSjE57co5/id3v9tmzm69umHlvT0iLl7/lydw9YDcIu09sek2wTnmTzcWU/lQY8OdbwDwUpYVZfwe7aIp67v6HYoZCJaSWf2Gb3+C2iyu5JB18dTwqUPPlMv5tMdtsI9DbALvBG5PTJ1e6ZTK7zhKmUM9T4ZUP24DXHFIsKbaxzPpuykNstSpWbWp4+g+s40AIW/Pr9zewTb/cYGhHKeWPulb+baWKLgBs08wodS8aIwglQg5To/oP60SIhdw09rqE1j7XgKYwh1XPrZvQX+4F0ym46nomD10b15QucZirnqAJwOuxW0uniuMQBNBhQmFLqrgCYUEhpY+B7ii0hZR7ERCx8asHNDuh3DJWZW+zmMIJXhF6YdryF89BQp+dcL56DFPBZfmGSkJXjvIBwLSjNvXt6Id3aloiO4GW8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199018)(83380400001)(41300700001)(54906003)(186003)(6512007)(26005)(316002)(53546011)(6486002)(86362001)(31696002)(6506007)(478600001)(36756003)(8676002)(2616005)(66556008)(66946007)(6916009)(66476007)(4326008)(2906002)(31686004)(38100700002)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzlDbEpseUZsZ2RUaThQYlZtcXBUUTNvVEx1MEFtZTBuUTU2a0hoaGptZzY0?= =?utf-8?B?alJBdm5NVXJEOVBEdzRUcU44RUFKWkduZng4dStqdEQ2cUc2b2JsOUZzTnFT?= =?utf-8?B?aWx5TFhiTDdKTnU5ZktBS2d0TTAvY0hpK05hVmRITzhQdk8vKzBWd0piNEtV?= =?utf-8?B?eXd6dy9Jak5TcnpJWEt1NDF5WGpMQjFhSG04ZUVEbXhqRmxtdlpDRDFsMTBi?= =?utf-8?B?RVJibXRzYXhvQ21wWVViUHdxRW1rejlid05od0pKR09xbFQzcTFqci9jeWxC?= =?utf-8?B?Z2hOWWVNVjdWSTUvNE1yalQ2U0RVRStlYjRPZlRGcDR3bjFRc25nbjE4U2x1?= =?utf-8?B?cDJROXN3QlkzSENMdmltdnhralZJYzBxRmJzQkw0MG0rcStLak0wVnZrVExT?= =?utf-8?B?bmwyOVlxbFVsVUMyeGJFSEdvY1lwSWVDNWQ2d0Zaakx0TEtpUTZGd2Vrc3Y2?= =?utf-8?B?SFZpWHVNTm50amlsSFpEaWkwYklzWnk5cU5JVEtOOWNFZ0F3cnFZRnh3Nzd4?= =?utf-8?B?eXVLUFZMR2ZBOHVqK0szL1VVOWRPWUZBRlN1TzBpYUNYYzltcDAyMnZ5NTZo?= =?utf-8?B?bTNqaFczcy9ITDN0UzNYZUt0aWxiT3BPRFgyQ2tTMU5HRk9oSCtsaFdFMHBD?= =?utf-8?B?Z1ZwV0x0YVR6VDlqZFpCTVpLZThIWWZUTVlqZjhZL085VkM1cEZyZGNuZjZY?= =?utf-8?B?NVNkakU4WUQyVVNvV3VETTZhTEhITGpRMVY2bWc2bGJ2K3NyaFVyQTE3dno0?= =?utf-8?B?bGJDdHNMWDJPZW83N3gzWUFXeExxRUZQVEc1eEtTRGFHWXp5WmtuSU9kaGpm?= =?utf-8?B?cWxCK3laTVVLR0dBNVlPVW5CWkJSSGN2KzlsQ0M2OTVoU2JxQmUxMkd0T243?= =?utf-8?B?bWNIcEErYkNXUFZDODR3WEFUVnM3aVluQ0UyU2tKeWY0NEV6ZFdrK2J6eEZS?= =?utf-8?B?dFcwOU1tRVNmRm84RE1Ba3FjTVh1V0ZyczMzV3hnZmVFZmxKNTNMK0g0NkZN?= =?utf-8?B?U3NjS3dHQ05rWjNyVzFaYitPVStaTFM1WFlMeitScGZtUmFKYWJaTVk0MjBq?= =?utf-8?B?RHhrbGtmUXprTVhkQVcvMXVIWlVpVE5UcitqUHBSOStjc1U1aEw0V20yRkVx?= =?utf-8?B?bWZBODhKOHNIR0Rpa0dKM0R3ZVNnVmNUZHhmUFRVUDB4RVlkcElsSk1COXEx?= =?utf-8?B?UTh4Yk5mazMrYkgvUEtVYTBlRytMSDZIcENqUkdvMWlJaEZzOWhqQzFlQ3Az?= =?utf-8?B?OFpZd0lkVTJaT0Q2SmlrU25USWFoOHFxZWFGdUZDR3RDUTU2QkNvUndFYThq?= =?utf-8?B?N3krQVZ2blQ0dHUxcjFPUFV0RktrQzAyUDNsSkVsc0lJNitJUk1xazYwZXlK?= =?utf-8?B?VkUwQmVHbWhVVUpVRHpSU1hoNmF3a2svbktFUzArZnFaVmVUaTF0bEE0Ynl0?= =?utf-8?B?eW9JZVRxaDByZkdIRlFsaDloQmp6c2hnb3dPd29Tb09WY3I3VzFaaG1YaXpw?= =?utf-8?B?dmNlVUhjelI1TGhIbVNkY2Y1YVFldXVrTU1GVjg0bnJMTVBscUFoQ0NDUkFv?= =?utf-8?B?Y012bXRWb1luaEFkSTU3SWR3RHJQOXlIR09mdk1EMmx1TVdndlNtS2JUOFFF?= =?utf-8?B?R0NuYnl0U0JmTXZKOWxOZnVIcDZlOUYvNnlwdlBJeTZFU3Z1KzBjblIrbGc1?= =?utf-8?B?QzZSRXRlUHhuZUFWSmxDODhaTkFZQzZhaGZKempDWWVzWEMwM25MVzhHKy9H?= =?utf-8?B?ZFJtd1k5ZUhSZ2c3LzJmOEZtbU0yMWNLbjJ3S3JZcTV1WE5ISmU4TytUOFpF?= =?utf-8?B?TkJyNFd1dUF4Tko1T0hWWTBQNFdPdE9Sb0FBM2RQTHBsZmxvelUrTDZiMUt4?= =?utf-8?B?UzBoT2ZiUUNZN0ZJZitBTWVDMDVDeGFzM2ZEcVVaKzVaWVdlUUxsMUd0d1RD?= =?utf-8?B?SVlHb1I0ZmpwS1M2eEJiZDhKa0JFNDg2L2RBMTI4N1lZQUNxNWNWS0IxL0xs?= =?utf-8?B?WnIvSDFWVmpYSmxGcU5UaXEwcG9qM2VvWEt0YVlXUzVSZ1N3dEpwanR2elFN?= =?utf-8?B?OVRNYXVJdGwzbXBtQm9BZVVyM1dFRG5TZmFmb0RSNno0ZDZ6aGRlalN5ZkNx?= =?utf-8?Q?H0INeCui19p5iruDAOvBJ8rn0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23d01a23-0d1d-4fd8-6615-08db140dbe75 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:15:46.7583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1gVEN6JZKxe8x9fPLJVQQOJ4pY9tmnLFWWVJbNUN9yrkuRSsxAy+fzUROx6i/SpJJNSRYOijd+ktXBwAY+l9Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8220 On 21.02.2023 12:35, Xenia Ragiadakou wrote: > On 2/21/23 13:26, Jan Beulich wrote: >> On 17.02.2023 19:48, Xenia Ragiadakou wrote: >>> Do not include the headers: >>> asm/hvm/vpic.h >>> asm/hvm/vpt.h >>> asm/io.h >>> asm/mce.h >>> asm/mem_sharing.h >>> asm/regs.h >>> public/arch-x86/cpuid.h >>> public/hvm/save.h >>> because none of the declarations and macro definitions in them is used. >>> Sort alphabetically the rest of the headers. >>> >>> Rearrange the code to replace all forward declarations with the function >>> definitions. >>> >>> Replace double new lines with one. >>> >>> Reduce scope of nvmx_enqueue_n2_exceptions() to static because it is used >>> only in this file. >>> >>> Move vmx_update_debug_state() in vmcs.c because it is used only in this file >>> and limit its scope to this file by declaring it static and removing its >>> declaration from vmx.h. >>> >>> Take the opportunity to remove all trailing spaces in vmx.c. >>> >>> No functional change intended. >>> >>> Signed-off-by: Xenia Ragiadakou >>> --- >>> xen/arch/x86/hvm/vmx/vmcs.c | 12 + >>> xen/arch/x86/hvm/vmx/vmx.c | 5844 ++++++++++++------------ >>> xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 - >>> 3 files changed, 2913 insertions(+), 2944 deletions(-) >> >> I'm afraid this is close to unreviewable and hence absolutely needs splitting. >> With this massive amount of re-arrangement (it's half of vmx.c, after all) I'm >> also concerned of losing "git blame"-ability for fair parts of the code there. > > I understand. Let me split the changes apart from the one that > rearranges the code. Do you agree in principle? or do you want me to > except and sth else? Well, the large amount of code movement wants at least one other party (e.g. Kevin, Andrew, or Roger) agreeing with your approach. As said, I for one don't like this interruption in half-way easy history determination (which can be particularly helpful e.g. when you want to find a commit to put in a Fixes: tag). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:27:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498898.769846 (Exim 4.92) (envelope-from ) id 1pUSgB-00042T-0Q; Tue, 21 Feb 2023 13:27:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498898.769846; Tue, 21 Feb 2023 13:27:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSgA-00042M-T7; Tue, 21 Feb 2023 13:27:34 +0000 Received: by outflank-mailman (input) for mailman id 498898; Tue, 21 Feb 2023 13:27:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSg9-00042G-JM for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:27:33 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20625.outbound.protection.outlook.com [2a01:111:f400:fe12::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7da16fe2-b1eb-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:27:31 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8298.eurprd04.prod.outlook.com (2603:10a6:10:248::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:27:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7da16fe2-b1eb-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B0THMarJaoI+GZ/hSfVadZ2h8b+vlXevNBWxh9J7D5EMhjHNMxm6OQQww6QZoK5DMgjEwMNOkautlncJRztrgnAPjSNimvlHVtnUiEg0U31RNT8JY605fkDGg5M5TS97ygjJVMyNP9QG5aWs/uwUTJEuu57gOBCvwE/EaHu0agO4xHnpOf392wKYFagriMPUpMWAEkd3qZ/DcFoEdMjl+vCPbI9UwCj6g6FFPaTXY6mh0zypszwfK96zQiSFgOdVh+69faRbQ+38f5Y/HaUR+bo+gYc8Ycua7JTJXE49Ku3ohQ4TMGJTkeE85fA91vLuLkz98Fu+ICiB8C98wZdpqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w9qlElWTRRv0iSVXLMjPiy8BHJYHZmIhdJ27iGx102g=; b=QB/3zvvSEfER0utsLjwoTSNOk3tK8o7l84Ib1OsJeq6TcFgetvxzagDsUkisqlKB1gUjhVI3S2Vkvw7XB0K+OljTAyKG/lFe39xa4FvpOYKupQK0xKQ3uCPA9eS9B8slDUjrdhN5ddUPYSLgLUqaQeJHY8HXGq5vBPvFj0MkJGMjohdK53pFae6CI0a9BAgaLyWQlJyYxFoG7z/p1tVZ4FNFWsR+56nWZM6Hkjl88hgzf03KDjBrpU3JRJvBBunl6dk15ZZGAnhKgLjVRmnGkq3O6iQFSl8Fwqz57w7xytcQeCEGLJG4PE9T/91+TbS42vjz8wIt3aEBjPWlK0ivag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w9qlElWTRRv0iSVXLMjPiy8BHJYHZmIhdJ27iGx102g=; b=At/fRDev8HLzOeP5h/UFwRLJLTXjMN30EOjw5mS40sNrMF6i8q19eZ9lXGLc+an4p1XxktDKRLQl5DRQhLRdN+aolejVtBlCoVGAh3HczHowJJwUN2raUvVA050H0PTrOExc09ZxYRluHO9Bf8uRFhNN1z4de+SvAgW+02fZsBn5SO2ltq4syWaXy1F/uWxSOuLJ+WFQmTLDuqzsYs3oHkyF8pqj8Gz+xseuV53h7lFcawL3Gp2wmoBe3XVe9gW/JDBJvnXDIqs2z4p80lUPuN8Z9zaskh//jRs/+CdUWU+PCDk/pQISCXc3eEx73ZiFq5ocHIWrXr3y6p+hH6+R9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b9de55d-010c-2498-2956-98753a6cb34f@suse.com> Date: Tue, 21 Feb 2023 14:27:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH v2] x86/MSI: use standard C types in structures/unions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8298:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f9b886d-eba9-4c3b-9bde-08db140f60ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5kri2DEhmFqfOQmM2bnx02hcNXq3jUrWcxb7tB9t749g1jkm9f1D0cHGNPCi08CZ+H8F1fPgJGUKpBGbiLz/tcnaGoZOEXNoe0P9NkZdx4fkDrm6QI4a63X0Omi8sY9tlnaC+ORElgzixcugnnWqPMhd7i1ZDp66AwjAQgAgqvKdaA362sWNKtY9Dt8/MLpccPia6s5/u2TMdS7Uy5cqvsT2AYhOwJuNK7H71/wC35TKNzo4ZZxVAV2mEZUtzMB4lmpsV9TcIYtl6oIaz0+E2NZwHCJRjIF0g71qBni2b+54Wi6hIG9hBFaUDu8lsSKHfA40ljsIVYIbEpavLCVG48KqTDfZUEVMNlt36V1hC8sqGD3TYyLfw3tEiQ6SqeNXEagbsubZ3K57Fy2w09lsiY4cHxcNes67Zly7lxpBbBckERvw1zBxrocptNNfWa0jfh0vJK10J0jtQy3q0EW+j9xjbU15nsRNgJRsDOI/J36/znjht+dFulBkIwkYiI17g9GvMAMlGVlZdnBusS44msAhospPwsDP+KKLtFkS1ntPYIIzx5GGA+P040DnCKQAnJSdmrl1YJcJWqp9BLFyprUGtbz+r8SN/aau8OqJLKrnI6GieYvvnQI/3/xKVO5zIXk64DYeRKQ8lhwDehmvMpHGC5QO+NzuLGeOfKcOrsOx2W++I81JmiFAXTAzKecdcYFJd95eRoSKl/FW188yNuWDkkeScQsmJ6uu5uj6mIs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(39860400002)(136003)(346002)(366004)(451199018)(8936002)(5660300002)(38100700002)(41300700001)(2906002)(31686004)(6916009)(4326008)(66476007)(66946007)(66556008)(8676002)(83380400001)(478600001)(36756003)(31696002)(2616005)(6486002)(316002)(54906003)(86362001)(6506007)(26005)(6512007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWM4N2xmSUJsM2daRzc1MWRSVW42dGhmaWh4ekJjTXUyUEw5RzYrQWh1aUNj?= =?utf-8?B?M2JRTHY2SHRsTHVoYWRrV21xWTRzTitrcWU2WCsrZUM3RjRUa1lpeVhDeHow?= =?utf-8?B?Q05zcmpzZFJQdnhxNm9maUJIYy91Uld2eXFGQXBVaTJCOGdWLzlnK3g0Tmpt?= =?utf-8?B?UW45enFrQkg4ZjZDSWtPeExWdXdJbXhEdThQaDV1ZEV2a2JOeForNFdKUUVG?= =?utf-8?B?SG9raWxMTWxveGs5UDg3bWZ2ajhSSlN3WXpEalpxQnJ5cC9YNlZHUml5OUF1?= =?utf-8?B?R0Y1WFFQV1U2K1BDWkd3M2syMHh5K0NaZFBxMnU2SVhoWTZhMVBOZEVSajFC?= =?utf-8?B?QnpWbGdaQ0FrOHpHdVdFLzgxaXRIdmhnQjUrSzgrYWF2K1R6S3N2eGFFK0hk?= =?utf-8?B?aTByMDF6MTVRMGZtZllhRmtLd3l6WFp5d3M1Sjh2dEVBcHRMa1I1NFFXWGZI?= =?utf-8?B?aVpZNlVJS1ZKSDEzRVIvRUQza3hKWEM5c1g5VXNPYU10S1Z6cXA5VGhxRFl1?= =?utf-8?B?QzJrc3g4Q2REWkQ3aFhTNkpaK29oVzJmN29vWVpYN1U0STlTSTVkaHE4RFVv?= =?utf-8?B?Qm83N2Q4dlh1bUs1ZE5hTDBzR3E5MFVwMGZ2cUpRc25tV2lMUDVpNzJRdUQv?= =?utf-8?B?WXNGcDZrcVh4c1Y3dUNtSXhxVEJxNXlYbTQwUkpKSHg0T1hOeUhpVUFlSTg2?= =?utf-8?B?dE8yZUdHM1JnZEd6KzBoR2F5MU1tdkpWTDVDd3dzeWVwNWIyR0RNbUNPY2I5?= =?utf-8?B?Mk1Ed3FzaTNqQURNL2pmdkE3ZXhFR0lUL3pZdTNWUVFZN0dqZTd1b1F5eXg3?= =?utf-8?B?RHZZNExRVExXTkY3aFgrSEJKZWRzS1h1T1E5TWJJbkxUeXRyeVRBYlNoSElr?= =?utf-8?B?L3VZaDc3L1c3L0hiK3VEM2dPM1JoWjVZRXg3cUpVVjNKSlQ2TU14MW4wRUEy?= =?utf-8?B?VU9jT2E2UzNOK2dIZjR5Y2ZhU281MkdGdTdkSFBjVXVhM3NkOGcrYTFHLzZo?= =?utf-8?B?OEkzUzdhK3EvTElJeE43NGRPMy9oL0FwZ3dNQmk1WklWdkMwbnVJUVZTOXYy?= =?utf-8?B?cldabHZNUUlPMGFzdUZkVnZvZ0Y1VGJTLzRtbGZSSHJ5c0FyaVUrMi9OZXBk?= =?utf-8?B?WkxkdjdyOFMrQTA4Z1lxWXQ2UllKamgzMFQ2Z08wU040YjdDdW04bTZBRkVr?= =?utf-8?B?RmJoOEpjeDhncGtOYkF2R2Nybkw5VDY3MzN6NXplanNuSDM1T2ZIVjlIUmI3?= =?utf-8?B?Vk43VDFHSDVNT2ZML3ByYVVxTFJoSURtNmphTlF6N2sxTW9UWndaZTFIMmll?= =?utf-8?B?dlhBSnZORjAwcE9XU3dINmxFQmc0cHd6OVRVWVVSV2kvb3pKN1Y2VUZZc3Zp?= =?utf-8?B?SnlVSHVocU9rdklTblZ0Tk9Mc2tjVDR3dmJTQVhQckJGU09JeWdwTlJvQ0Za?= =?utf-8?B?bXRDcVRsWVlVZU1DYXBCYm5KZm0zRzlrU0hYMTRaVEhPZG5YWmZxUXZYekNk?= =?utf-8?B?VmN1dmRjclhvU2t2MGpQVkYzOGU1OTNSbEJLMWFzTTJXU01ZRUhqRjhmNDFn?= =?utf-8?B?Rm5WUVJJTU5leGl5N0hJMXpRcjg2ckgvbndCdDBzbUJmN1ZJYlgwYWNGaGc5?= =?utf-8?B?dktyclR1WTROTFcycG90cDVpZ2ZkWHFkUmpjaVYrRUJGUnRmbGpUb1hUUm1v?= =?utf-8?B?T213bjZSWXlIcGwyYUUrWTgxMk42WTRMMVpBVmZWdlNXS0F3TkJiVFl0d2x6?= =?utf-8?B?a2N1UHJwTzB4dFhKOVJBVExVUjlQUGJhanJTNURvaE1oV3RzSG5ZUFltUk5H?= =?utf-8?B?Rk9NVWhBaTZkRjFUK25LN1dVenlMMDV1REk5NUZRcFp2bDhHOUVVd2d5RHhp?= =?utf-8?B?RGNQVFFmQVFqOW11UlFGRmhIVC9OdkpvT2dIVFZaT0pMdGltRU1oV0RSVjJu?= =?utf-8?B?SE9zMmFMNUlYMEJJbHRqb0pLVTJ1ZkxEd1YwQVBzSVRqOFlvVzY1ZXc2V0VR?= =?utf-8?B?YWZWTGhlOGtoNzNjUkhjQVk0b1JJYmZwZ21mQUJRSnk0ZUpKV2dQZ2RkTmU0?= =?utf-8?B?eXNvK0F1N3doQlRMQVRyUDlCNmc3UnNEUmZacy9WQm5leGZJaE90MDMraVpF?= =?utf-8?Q?heK3WUKi3YmRa3ZGErulhSr1N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f9b886d-eba9-4c3b-9bde-08db140f60ca X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:27:28.5419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jIS/L8Xbczt47IKPnORukEZNOYfbPbqvaYjIBRHVNnMGTUv76vnkgqyX1u8gXNsYp7CslbJj0hgReE8RUoe6Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8298 Consolidate this to use exclusively standard types, and change indentation style to Xen's there at the same time (the file already had a mix of styles). While there - switch boolean fields to use bool, - drop the notion of big-endian bitfields being a thing on x86, - drop the names for reserved fields, - adjust the comment on "dest32". No functional change intended. Signed-off-by: Jan Beulich --- v2: Make secondary adjustments ("While there ..." above). --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -66,15 +66,15 @@ struct msi_info { }; struct msi_msg { - union { - u64 address; /* message address */ - struct { - u32 address_lo; /* message address low 32 bits */ - u32 address_hi; /* message address high 32 bits */ - }; - }; - u32 data; /* 16 bits of msi message data */ - u32 dest32; /* used when Interrupt Remapping with EIM is enabled */ + union { + uint64_t address; /* message address */ + struct { + uint32_t address_lo; /* message address low 32 bits */ + uint32_t address_hi; /* message address high 32 bits */ + }; + }; + uint32_t data; /* 16 bits of msi message data */ + uint32_t dest32; /* used when Interrupt Remapping is enabled */ }; struct irq_desc; @@ -94,35 +94,35 @@ extern int pci_restore_msi_state(struct extern int pci_reset_msix_state(struct pci_dev *pdev); struct msi_desc { - struct msi_attrib { - __u8 type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ - __u8 pos; /* Location of the MSI capability */ - __u8 maskbit : 1; /* mask/pending bit supported ? */ - __u8 is_64 : 1; /* Address size: 0=32bit 1=64bit */ - __u8 host_masked : 1; - __u8 guest_masked : 1; - __u16 entry_nr; /* specific enabled entry */ - } msi_attrib; - - bool irte_initialized; - uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ - const struct pi_desc *pi_desc; /* pointer to posted descriptor */ - - struct list_head list; - - union { - void __iomem *mask_base;/* va for the entry in mask table */ - struct { - unsigned int nvec;/* number of vectors */ - unsigned int mpos;/* location of mask register */ - } msi; - unsigned int hpet_id; /* HPET (dev is NULL) */ - }; - struct pci_dev *dev; - int irq; - int remap_index; /* index in interrupt remapping table */ + struct msi_attrib { + uint8_t type; /* {0: unused, 5h:MSI, 11h:MSI-X} */ + uint8_t pos; /* Location of the MSI capability */ + bool maskbit : 1; /* mask/pending bit supported ? */ + bool is_64 : 1; /* Address size: 0=32bit 1=64bit */ + bool host_masked : 1; + bool guest_masked : 1; + uint16_t entry_nr; /* specific enabled entry */ + } msi_attrib; + + bool irte_initialized; + uint8_t gvec; /* guest vector. valid when pi_desc isn't NULL */ + const struct pi_desc *pi_desc; /* pointer to posted descriptor */ + + struct list_head list; + + union { + void __iomem *mask_base; /* va for the entry in mask table */ + struct { + unsigned int nvec; /* number of vectors */ + unsigned int mpos; /* location of mask register */ + } msi; + unsigned int hpet_id; /* HPET (dev is NULL) */ + }; + struct pci_dev *dev; + int irq; + int remap_index; /* index in interrupt remapping table */ - struct msi_msg msg; /* Last set MSI message */ + struct msi_msg msg; /* Last set MSI message */ }; /* @@ -179,49 +179,27 @@ int msi_free_irq(struct msi_desc *entry) */ struct __packed msg_data { -#if defined(__LITTLE_ENDIAN_BITFIELD) - __u32 vector : 8; - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ - __u32 reserved_1 : 3; - __u32 level : 1; /* 0: deassert | 1: assert */ - __u32 trigger : 1; /* 0: edge | 1: level */ - __u32 reserved_2 : 16; -#elif defined(__BIG_ENDIAN_BITFIELD) - __u32 reserved_2 : 16; - __u32 trigger : 1; /* 0: edge | 1: level */ - __u32 level : 1; /* 0: deassert | 1: assert */ - __u32 reserved_1 : 3; - __u32 delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ - __u32 vector : 8; -#else -#error "Bitfield endianness not defined! Check your byteorder.h" -#endif + uint32_t vector : 8; + uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ + uint32_t : 3; + bool level : 1; /* 0: deassert | 1: assert */ + bool trigger : 1; /* 0: edge | 1: level */ + uint32_t : 16; }; struct __packed msg_address { - union { - struct { -#if defined(__LITTLE_ENDIAN_BITFIELD) - __u32 reserved_1 : 2; - __u32 dest_mode : 1; /*0:physic | 1:logic */ - __u32 redirection_hint: 1; /*0: dedicated CPU - 1: lowest priority */ - __u32 reserved_2 : 4; - __u32 dest_id : 24; /* Destination ID */ -#elif defined(__BIG_ENDIAN_BITFIELD) - __u32 dest_id : 24; /* Destination ID */ - __u32 reserved_2 : 4; - __u32 redirection_hint: 1; /*0: dedicated CPU - 1: lowest priority */ - __u32 dest_mode : 1; /*0:physic | 1:logic */ - __u32 reserved_1 : 2; -#else -#error "Bitfield endianness not defined! Check your byteorder.h" -#endif - }u; - __u32 value; - }lo_address; - __u32 hi_address; + union { + struct { + uint32_t : 2; + bool dest_mode : 1; /* 0:phys | 1:logic */ + bool redirection_hint : 1; /* 0: dedicated CPU + 1: lowest priority */ + uint32_t : 4; + uint32_t dest_id : 24; /* Destination ID */ + } u; + uint32_t value; + } lo_address; + uint32_t hi_address; }; #define MAX_MSIX_TABLE_ENTRIES (PCI_MSIX_FLAGS_QSIZE + 1) From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:29:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:29:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498905.769857 (Exim 4.92) (envelope-from ) id 1pUSi0-0004ss-Av; Tue, 21 Feb 2023 13:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498905.769857; Tue, 21 Feb 2023 13:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSi0-0004sl-7R; Tue, 21 Feb 2023 13:29:28 +0000 Received: by outflank-mailman (input) for mailman id 498905; Tue, 21 Feb 2023 13:29:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUShz-0004sb-2e for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:29:27 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0fae803-b1eb-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:29:24 +0100 (CET) Received: from mail-mw2nam04lp2175.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 08:29:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6927.namprd03.prod.outlook.com (2603:10b6:a03:43d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:29:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 13:29:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0fae803-b1eb-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676986164; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=/F/EWAi3TMe3vy/gcyGhAWm9fzohUi3ZNbymQYgh+pM=; b=I3i2WjjjYqT+sP8QdKiaUtbnAFtefqKytG9c7w05Vo1Olk7dQbRRg8Yf 2JJp7bL0yzvKlzTqKIiGHXEMg9pU+bhdAX63YJ/sYaFtkzG9hVJl60KF+ fxky2veTLsR66v+HSytvSM6dtS55YBo+y4V4Vixkqg81CBZ09YZsqBSwo Q=; X-IronPort-RemoteIP: 104.47.73.175 X-IronPort-MID: 98302475 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:VlNKr6h25Esvz8GDe0YRIRLdX161QhEKZh0ujC45NGQN5FlHY01je htvXz+AM/6Oamv9ed9ybou0pxkP75SDx9BkQFNs+HxgRikb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWHzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQdcwtQRS3ctd697/H4FOI0g+4hD5HCadZ3VnFIlVk1DN4AaLWbH+Dv2oUd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6Re3jrqQ23wD7Kmo7FUcaR3bmi+aAgVeCXM1NI kc21AF0ov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDRLoViMA6tjn5YQs1BTGS44/FLbv14KoXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:hNgVsa9dFXzFjNWnx31uk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="98302475" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfoqobQTbJjG3HaBjK2aDkPrCDJ44LFz3hzMe5VEOdYuJOR+T0fHHAFPu2o6Ap4D9GOwbLrDHZ5UWC+YJPpEt6a9KVyHSroTl9Ns91+27t6CbzzBkZDLDO5nQhQ3VqJMKT5pPi5AC/CdLpRKCxnU4cSAxO3LiKDYjI/klA+i+Zkm5pKL3NE540/sCDUQMyOBlRcTkZhnwLj5iWvWazIHgi/8aYgpYegJVylV1CUiVENiOB5tl4j/YPdikXI69Q8NgW9EPdDq2edefceuJLJGZyCZrinfHRI5p0ocia1YY3NokOlPRJpokrWeTsWT5VksWtcOeiyqAkD3MqUZQh7jpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/F/EWAi3TMe3vy/gcyGhAWm9fzohUi3ZNbymQYgh+pM=; b=XGm5BLPC470aS21nH3ELSQjDAGGHLWHCZjK1v1tza40v/GvjpD3zP2ZN3xPruzd4eNMgAJiz5E5UgO3CD221oTim4wR8bUJZZNdqnPvHcnSuPCq+ROO9wnQjkGdrxFlquRPA6U04o8l1HIcGOfNTSA/15StuRv7vTVuAvAqmo0E3Ucis7I41uCxFXqzQzQodPYY4p+c1BCauC8gTmAPxuKHYWk4fqc2t9aumMp2aF2WsKg0Kfuu5IXdyLwXqLhbG9yuzkhmFUm3MlpgDMRoi4O78sdbV0jlMUIM78c9bwk9lWr5UVigfyMJkrGt9EPsBANnu8V3Alxvi026kakRquA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/F/EWAi3TMe3vy/gcyGhAWm9fzohUi3ZNbymQYgh+pM=; b=AbpLJo95QVpiBwojKofPY/mcXbgmVhx2DkWafWlvMbUqjSWGmlLQ2yuHxd5H7FLK0SRRyJeVHoFFtswJj2NZdkoyMVblYcbGqidwv3Xr7m63XhOZ9N7VSARINwcadlu5DrpycHtmg83AQHblyTUWTwwxgoxdG3bIsbYS4Igpd30= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <447d9cfd-dd07-e7e9-56c7-d2129ec3f924@citrix.com> Date: Tue, 21 Feb 2023 13:29:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2] x86/MSI: use standard C types in structures/unions Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <3b9de55d-010c-2498-2956-98753a6cb34f@suse.com> In-Reply-To: <3b9de55d-010c-2498-2956-98753a6cb34f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 96b7e19f-3d5b-4e7d-9398-08db140fa3a6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0i/Qc/8oy1TRGJ06Np9yJ1hvzDX+BbQ8tyvbYhoLw90OudGZZiD2xPUfSs1mqgleKL6JociuJ7TCpXPwUEVIx3mPj5iY/n5dnhTANvZ1iVNZF9rti4Inw/E/nlUSH9skWACl8NN7cMQ55gv9xrxd1Rge4NoDHWdW/Xg1iG2JiKeD5oBlE35+SvN2Y6uzKHGpGqWwJ/dKhuYUM25/KsPUgsKhYTnlVy9GhFzGjhfLGa2GbjkQmk1oJzHFl8LuM73o9vC6sAsxgIZi3+C+Ub8qth4JvlTctIS9Qu5TWN3+nlOxF3eFvIlqCpqZMKCgeAhwCEay1J/EMDE/IdXMbU2F81KjsooOJ/d5znnnDFIdDIWuY+0ZNcnbMPttlcvsYa49J4i0Mp02ibe09WhGZCwLChp1GO8StkdBueXtdHzh4++3G6htI6cdo7Uy9Hk3CorWL0Dd+6z6Q9E+uXuOWGDIVVBN5Dt3e4aWkyglM4FuF8Tp149CC4meA7Bk0gXOSSuUVNyKRFtUcD2RRw/SOGam8aIA6iDf7vASs4YMNzbP+xCyd75FRw7je96DI3ATd6DWp+wZ4MS9Oxv6T57FHXcPQI/VLfmeb+MFry8nDTmsqOM4/UzHxjZTjmEqrxz6UdmApbv1NcDJ8sUNXUQfCu+UZQ4Yv+863nKN1AElsmD95NEwGFz3ju4ozGSNdQdnp9nrCYCFDW+/XNe+MMMKcmUBnCry+SKr4q0UUVHcl3gRvOk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(346002)(396003)(366004)(39860400002)(451199018)(36756003)(2616005)(82960400001)(38100700002)(5660300002)(4744005)(41300700001)(8936002)(31696002)(2906002)(53546011)(6666004)(6506007)(6512007)(186003)(26005)(107886003)(6486002)(86362001)(478600001)(316002)(54906003)(110136005)(31686004)(8676002)(4326008)(66946007)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2RoeEVrSDIvNUdZOENPRE1Lb05aMFJ2YVRTWm1RdmdUd3JibXZURlJBR1lj?= =?utf-8?B?Z25xbTh5T3gyRGlFb0pLWlZxdGoxRzhNQklDaDY0Y0dNN3BQSjFCZXBWV2tF?= =?utf-8?B?WitMMWxvd1hiUkJmbG0xQXN4bUVZQlZMYnJMYWhCenQyRU1BTWRDaGQxNjN2?= =?utf-8?B?WmEwaWpHQURTV1JxYTRqRXUySnBOV0dDa3Z0M3hHUzVGRHFrSm9DeVdSbVd6?= =?utf-8?B?cm8vOEFSczd2dWp1WmRTYkZINk1vS25IQjNMRXdnbzcxTTc4V2hmdmZ0RkE5?= =?utf-8?B?TlUvcnJXdTdYWTFyaGJKKzFTbnRNOWN5MjcyOG9oYnI3OW5qSTdWOHBnQnlW?= =?utf-8?B?NHVxK2kzcnh1aExzTkMyNWhJeXdHL21ta3ZBMHp1VThkcWlpSHR4SHh6blhj?= =?utf-8?B?a0tZNFBnbGtYTTZ2eWkwMFFKSUgzTDltWGVmT2JGYjFKSGN6TThybkpCZ1Rn?= =?utf-8?B?SnZHaWp2QlNlNXU0dFErTDErNEh4T2YzR05SVXJxL2c1U1lkSU9WeEErVG95?= =?utf-8?B?QWc1dm55U2lwYnFkSUFlejdEMThpeWxOanMzY0szelpwRHVBai9PSDBIVU5X?= =?utf-8?B?eFBsZVRnQWd6ZHdESWlQUkNLUkJla05NLzBob1RZRWkrSGdFTHZWTDgyUDZr?= =?utf-8?B?QVBXQUJmZXQ5ZzRid0NDRVlEMUhzOEoxTHkzeUtsUVJFdGZSQ2ExbGN4elVD?= =?utf-8?B?blMwN2pNRVUxWnM4eGNGd2pIQ0MxR0k2eko1S0pZdlZ0Mm1mVEFPUlJNOURv?= =?utf-8?B?bDExVlZmNTFQYzlNbEpJSUp6OTNqR1BIdUxydlpCVk1tMWpqNU5SY2dnYXdk?= =?utf-8?B?MEdPVFJKR0FaU0FhTGV2eHUxU2l2OVNhb0J1T1hrK2x2ZFFGUExMZWQrN1JG?= =?utf-8?B?dVg0T0huVG1jRnFFWTduYURnQ2wyK1pCVWsyb0J5bGY0elU3SDNndENoRGxx?= =?utf-8?B?cWx4WFY2N0g4MHJuVnp4Tjl5ZHZDNmVXRG9yNkowMTJDV05OL1JyL3BZWm9K?= =?utf-8?B?QnkzTGg1N0JNUXVHaTRVNWRSOVpqQTdJajdvQzNlNmVHNW8za3JYaUhBeERv?= =?utf-8?B?M1JacUZEUkdLSmFKMzlSSkxwOURLNmZyVFFRbE9yWUs2L1FCMlRlRFBTZUF0?= =?utf-8?B?SWNuLzdEaXgwbFZMTEExcWRyc1g1NTdka0h2UHdoQ2h6VHYzdjlxMVkrUC9x?= =?utf-8?B?SDE4dFJtU2t3NjBSMDRpOEErdUQ4S0FjbHlFaTAvTWJ5MEdPT1RrUXhaM040?= =?utf-8?B?OGhjWjJjQk5ZandjL3U4aEV3RFIrYk9ZMXNaUGMyMEkrRDFOWnN6eW1zRndH?= =?utf-8?B?V0pGMEh1UHA3TTlvOXpZQXNpL09vam8xMXh3T21EaXB2c0NrcjVMSG1hbXgw?= =?utf-8?B?NjRJRlcrRHdSRDF3eXRiWFUySTZiMTR2YzcxZW0zQ2t3YmFNRm1nZ3loZVp2?= =?utf-8?B?c0VnTXRUTnovKzlIY0NhRUROOXZyR1ZvR3R0NzAwYVpQZkhMS2gyZVpqdnVW?= =?utf-8?B?b3RJWEdBMXZZdGZGSG91R01FWXRJQXBncGVTUVgwUE5Rc0N3TmdrQi9DN2VT?= =?utf-8?B?Yjh5RHFEbTBzRzU3L2REcjE3SjN5aDhTeG04bUNhaWJwclhOR0xEa1I0c250?= =?utf-8?B?aXlrMWNySG13Q2E5cm9WR1pWclo1NGZCaXE5ZDNMc3l3MmYrWjZWa2h3Qk5O?= =?utf-8?B?a3BkTWVqTzVyMi9MYkgxUkVFYUNJMkhVVnVCVlJIL2pVUzVNRWMrK0tHdmxp?= =?utf-8?B?bW1vaXRDMnZvcFFaS25tcEtWU3o2MHNqMGtwWkxSS1VsZElPMDNBVkcrT1NF?= =?utf-8?B?bkJMRzlvS08yQ1FHQmFSZU1LTG05cWxidHRGakZML2hFVU5EcVZoU2RuTGti?= =?utf-8?B?VzJsclJlYzJZemRpOUxJQUdUSzVZMkIrOE9kOXVBaDA2dnZqUm1EQXdJUkZO?= =?utf-8?B?WUdWN2d4MHVoOVJEdzIzdUxoR0UzSzh0eU9OOFdXUTNWZVYvYmhkcGttWDhj?= =?utf-8?B?bHFhVkRvY1JjV2paZndKcFVsdWNVMUViTWRZQy9PVUFBWUhLTU9samtVZzBN?= =?utf-8?B?T0xFcE9NQ1R0b3ZMaDZjWmJvSk1sVThPUlJGL3BhendnVklxZlYrcE9EQlVm?= =?utf-8?B?ZklTYWFPYW5XamtZQUxuaHlkMjh1R3JsR1M2SjcyYmI5ZHE0YTFmNXVXMm5V?= =?utf-8?B?YVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FNqC+V5ou82tklKYjLjqogDre4877wrXvWIaHARc/O3NLNIj3LQj3ZrGV8MpqNAem0Lg1VcKiAKQ7eVgh0gWksEwxGEkg0f7qG7OGHBSFEoIrpPdcXSZ1dYJbD8O3h6cetfPEDGXkdi9jH/QPmJ5bnYFzw6rqr/cHiG90DYEhdn3e+3E6oRK+61luTnZ1M89CQQwt5pxJa+rzmPb/C/SBnzCF91+fyoG4jg+DnMGReQFiPU8gf546WjcbI+2X8TINHWpMoUFlDWBb+JY8K1jnXs8fpmJYvjll5Nnl/E6LAQTs1hqIFYvuCaU7Xg2pzHnxuMm6f++bGe9GlEi5FWSsJzbav5Y/0dDacA1j7DJkPR82T2MaZ9Q20JE6uAp8e6ot65hoDUjrTVancRpDEvCxuVsrSL9A0DsNN5L18kpZrfySrCDr+4MlRzu3Mh+LQ0o1CDotdSfZBd1qJgiVtH88HT8LEyjLbNdwxkjFSaUc8TXH7ahp3/HObW+dFV/+uUjSVB6LqrA5OeREBy2w3mseTXMXSNyaxyLWkLEdKududd7MTHX9A2ZtngRlxUDj3fqwDNKCBDa/BQbXtdLRCrbP4GbgNZkALkEvO1IKYGr7wMVgMHUsBPKKG8v1R7y+krCSa8VzrctJV+OAJuwLPfZzfdEtOqUiywY3EUdzQXwsegj4hHLTDX/OffoCYEeWJrY0Sz81+BW6tiWnF9EXmXv5LNpflfAxlKlFyJXpFJEyqKm2vTM49tOCrXnlR8dsBYxmbO4zvqP7IqnpH2pHeCL9W7t2bKOfrJjhWNYvGJZOej3ELnCEuNs9mPxHpdVlz/E X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96b7e19f-3d5b-4e7d-9398-08db140fa3a6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:29:20.8537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zWnEUNFZcMAIJbcjb0zR/KldAS/RKH1B/hR75RsX4nTZT6kjf9d55ojiCNHWx1HnGGliHIqvbnvZ6A2S1MnUAj5azVHnRmswI8Uwf2GbAxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6927 On 21/02/2023 1:27 pm, Jan Beulich wrote: > Consolidate this to use exclusively standard types, and change > indentation style to Xen's there at the same time (the file already had > a mix of styles). > > While there > - switch boolean fields to use bool, > - drop the notion of big-endian bitfields being a thing on x86, > - drop the names for reserved fields, > - adjust the comment on "dest32". > > No functional change intended. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:36:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:36:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498914.769868 (Exim 4.92) (envelope-from ) id 1pUSp6-0006Sr-69; Tue, 21 Feb 2023 13:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498914.769868; Tue, 21 Feb 2023 13:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSp6-0006Sk-2G; Tue, 21 Feb 2023 13:36:48 +0000 Received: by outflank-mailman (input) for mailman id 498914; Tue, 21 Feb 2023 13:36:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSp5-0006Sa-4T; Tue, 21 Feb 2023 13:36:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSp4-00024J-US; Tue, 21 Feb 2023 13:36:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSp4-0001Zo-KT; Tue, 21 Feb 2023 13:36:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUSp4-0004VK-K1; Tue, 21 Feb 2023 13:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NwSuQdLA14mcosWgulWfBSGCA1523IAPxr1/ZRXJPWI=; b=bBMpeXU2d2m3r8OT5pHZkOUW7D meFtLsGw00H+MEZKhgSxIzHeJaMOK7YhbWFIUaQKRvI5FpGR0GUvDMiEzllNOhYwKxl2CynokhrgM ZjOcAbCxuLMPOg0np5h0jaYghELoE4NzlhggZreWmJsCMEnNgH9hJLYaPpWPFuFETqSk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 177979: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=89f5349e0673322857bd432fa23113af56673739 X-Osstest-Versions-That: linux=c9c3395d5e3dcc6daee66c6908354d47bf98cb0c From: osstest service owner Date: Tue, 21 Feb 2023 13:36:46 +0000 flight 177979 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/177979/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177860 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177860 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177860 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177860 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177860 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 89f5349e0673322857bd432fa23113af56673739 baseline version: linux c9c3395d5e3dcc6daee66c6908354d47bf98cb0c Last test of basis 177860 2023-02-19 22:42:48 Z 1 days Failing since 177951 2023-02-20 20:44:41 Z 0 days 2 attempts Testing same since 177979 2023-02-21 03:27:38 Z 0 days 1 attempts ------------------------------------------------------------ 482 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git c9c3395d5e3d..89f5349e0673 89f5349e0673322857bd432fa23113af56673739 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:40:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:40:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498924.769878 (Exim 4.92) (envelope-from ) id 1pUSsv-0000I2-Lz; Tue, 21 Feb 2023 13:40:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498924.769878; Tue, 21 Feb 2023 13:40:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSsv-0000Hu-J0; Tue, 21 Feb 2023 13:40:45 +0000 Received: by outflank-mailman (input) for mailman id 498924; Tue, 21 Feb 2023 13:40:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSsu-0000HO-No for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:40:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0c::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55d0f3af-b1ed-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:40:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9458.eurprd04.prod.outlook.com (2603:10a6:20b:4ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 13:40:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:40:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55d0f3af-b1ed-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsl5nW/UExFWDDDqz9tLUtkBal9Dx2JIxR9RsSSVkQtIcRE3ob2e0YxPqPNwfsJrdt6jJKXEC/tn/3ZXdyRlkPud+B5Pd33GusprfUGTxvujw7a0u5SWEnITbkXsVbQOtzPQZ9uIxp4wUbBNIH5b5etJ4EPa6YENBF6dJJjyfFIT3+rxoGYR7jO2I9XRBtOs//DTlVHWqiyfipb4PCfapKgjh6Pj6uYAYtwDFxcL0jOByyyktJhxlg2hJf9jIUHwTQgM6wSRGZ+LBM5ZmS1sH8vWxaGhjji8qrZ4LzW9G+ACspqBnRmxSw1aB6/tTKlTUWKJJkpOEvecOtFAcFkpOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aG4+Rvk4oBN/gBEzlbqVzRZTGMIwzdsIKympAT5ijNY=; b=T/7guqhvLcHj/j/XeVH0lLEcNfetGoPKd0ZtT3cDkPoFhMumD0EuHU0OkB1EV8fKpkfrCQh3M46McdJnlr96w4BzRQmwtVc1N1B84dFSAiZX5VT/5sPllxLfJjFMQAigmiJyskNbLUI+BsKn8qTR6FKPojYcvCBKQYUR3b70+uy8uEt655RWAmt+lV6td6p6Wspo5VHCCDp1Fcmis6wgebdmtvKt1bCtkf0sNBxpo0DcmhT462Lj6uOdVaxj9TVocaNRcb9bK4GfzIOndA1uBLdZRnNjYT32S2Nwa2YfGjNDWH+zAjILsuFt46klN7Q5z1M5WWt5Tv3Grns16HlE8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aG4+Rvk4oBN/gBEzlbqVzRZTGMIwzdsIKympAT5ijNY=; b=iQDcBF69uqg/ByHeJ/6WmhuF7Uom72Owxctk0nYMZRWUXaA7TEi3upFG8JTJYpb6cnCgXUQE3L+Pe68c6MWGXdk04aE0hUIRvzxXkuAtYBg7Yo6yvi1r7QfForiEJKD9OLUV2OnOIBACKERsIhPzgVOQfqNSSFrZHiesfNWU1B1JT29pZtj4UwXae2WD9ZP94l0n1WJ1dWtw9ZOp+q8TXW9IkmsfgLUbniLvN8/hUg9X7XAWS6JUla/GytPib90V+rYFZvTS8cgzKeZjrUkWdQtkARxD9O1p03VNWoAHHy00VrJsAz1D67ZIHsnKzTmsBnlVpTTSacIW6yLkGLpRlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 14:40:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> <20230220194702.2260181-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220194702.2260181-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9458:EE_ X-MS-Office365-Filtering-Correlation-Id: 63816a10-d74c-4722-d47a-08db14113920 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCywHu5y4JE9cXXOZnE+NjvnbrXIWLEfUDHjNCSD2btYtxC51jb8NqmSelWS3JzAq5qzvBjiwWkD2X7QrtSQHLphc7ZJbKyE8U98YyTpoPnmkWECSPkqL6eEmdQYCtmv3pD1AzNG+PaDcNc5MBkOSaoCXLKMmF/1zMpbqM+MB4vIE0274Mm4qjaGLNIB67QqFmLw7Yx8fbVlf89GNZimjpLvm9bX15nSuV9I18ehG1N42M44yxOt6U0klkGiJO8H5vMg78XafQw6DgG9vg5ZcKyc+EjpEudxQlIdyyiX7kffbDUxrNfJ5AOvyPReeP1gorB7+qjWFHd0glWrLRy6hGve4A18YZMxHPPlA12h386TX6d9o3JTKEI+nSQoykChrwe5Mz4A4JiaVqSv2UdLGJbeyhCkKYjyRbUjbKx2Bfo5xioPmTlUD2T8p0+2JPHM7/DyV1dIDt0tl8M4epNVKhAY2fXtraafPsjtWi4o+ZbCssVzKAI04IxUgXNocN2ch/EhrO6R7HmBtKPgrkLgWFkAaIEairJtOW+o+uaHiwgU5cc4/jnk/X3gcdCvxl6Fvhwny31gRNQ6sIlMDFl+9fGhu0HFI3epAiPOZuoPxuyPG81zEvb1X+19ZgEK47kkYM21R4ea0Vs3Y0YvGdkYFryU7JK7QdqKV1aDQerEwk05Ow3kBH/lADDJ+wu4TRKiEzqxHkT9tPaBnMzMtxg+7SGbJnFJaZgLbF2X1qULjzE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(376002)(39860400002)(366004)(136003)(451199018)(6486002)(478600001)(2616005)(4744005)(38100700002)(66476007)(66946007)(66556008)(6916009)(53546011)(2906002)(83380400001)(6506007)(6512007)(8676002)(54906003)(316002)(36756003)(8936002)(86362001)(31696002)(5660300002)(186003)(4326008)(26005)(31686004)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2VadUVvZmdpODdnZFZFYVN0bk4zdmp1dFBCRElsNkViWkZZWEd0ellPTlhT?= =?utf-8?B?dmVIYzFIdE95K2ZJbXk2YWtMZHlRRmxLWW1pbVAwUHl1c0pzd0tTaGlRenRF?= =?utf-8?B?NnhjUzVVeUdHM3RyVUNWRUFFOE1sNVBSVVM1RC8xZ3BlUWJ1cnRMeU5tWG5q?= =?utf-8?B?UVB1cUNmWHJPS0FWM3N0QU1rK1dmOUl0V2xNeTB2MEVYT3Ura3JWQStRT21D?= =?utf-8?B?WWJIUE56N28vV1BuU3FGRGtqb2tLYnBsamtCS3UxK2NrNEdsa0VVa3BCK0pZ?= =?utf-8?B?UDYrNnBSK3AyYTJGdWNGbS9kSHhXMlo4QzhBTUI0NjQzZmltalZXOS9YZ2J3?= =?utf-8?B?TkdHMUk1TGdyUDY5ZjU3UGFqRnZjbDVrRUt4ckZnS0Z4NWlMZzZhbThucWEr?= =?utf-8?B?YklzdDdnanhHZTJKbUE1bno1VTMrUnVQUjl4eXh1SXBoUklKS281bG1BaUFr?= =?utf-8?B?Y0lEelBkYjhoMlUxcHc5RlNNUk9uV3B2cnE4SjFWOE5qK0w1UjZtbmJEZHdz?= =?utf-8?B?clpkZDdmNFRKcy9VNHVkMzcxZEswcDBZY1k2Q2J4WTNOTXAwN2ZVdGRBUUFi?= =?utf-8?B?ay8xbkRjdndpdTdWSlo5UVlkZHExNDh3Y0JUbFBvb0syd1ZocGY2NTFnQTlh?= =?utf-8?B?bFJGU0RsK1kybks3TFhVNGo2cEdRZ1VQMUhQQmlianRGc0FFV1JmckZTaDZo?= =?utf-8?B?ZXVrMWRtbW1DMWxzRjB2TElIaUk5aC9Cb0srN1hjOGlkandOTy9hK1N3STFr?= =?utf-8?B?V2dSY1VUY0UydEJTWXVkQTk3MnNOWkNkVUdHVndiYkw5aVpRMytOM0o4d1kv?= =?utf-8?B?MG9CTXc2c2llVHF1RkREUWIydXZ0eEFzaWlwdWtmSDdNeWg0U1BUdHQ0cGdm?= =?utf-8?B?S1FBYW1GMDZZR3E3dVhMOFJKL1JHdjNHMXYvc2liNDYwVFh6a1FvV3BvNit3?= =?utf-8?B?OUdob0Z2N1cwTHgrMGlhTWZXVVI2NFoyeCtjd1U4TmRiS0VsSWI0c2J5UlVG?= =?utf-8?B?TFVyeFQzM3doRmlhclJ4NldJTXJieXI4a1YyVFJpSzg3dnM5Ym9BUnprZlpN?= =?utf-8?B?NTkweGI4YkFpM0xyaEZoYUIvcm9CVDE0TFhma1cydjVpNmhZbUxsNTk4L2hI?= =?utf-8?B?YnhXbjdCYTBwM0RQK2dudFo2R0o5ci9KSml2VUpYWUswdGRlS01kOEhnNXBz?= =?utf-8?B?aXpDS3AwbExlRHdmOCtTZmZUQk15M1BTcDlZbjE1MlpLYmc1K2FDZ09lV1RP?= =?utf-8?B?aXExS2drbXp5SFlBdmtYZHhHY2huQU43VG94aEJaRG1jNGc5N3l1TDIybzNp?= =?utf-8?B?aGJTV1ozdENyTGtZUTJveEJBL25IWWpUdkc0SGVxQnd3Q0dQaFNvVkhtMUwv?= =?utf-8?B?Slc5NHRubVZEVFRvdHN0UUZzd2YwVnBBUTZQMUpQU1EvNDJ1M1BwNUlOclRT?= =?utf-8?B?ZDJiSE1oMGNRVDhjbUwyZGRTbkxZb3Y5ZXg5UkxDQlRjT1FJWkdHTTBBYkIr?= =?utf-8?B?d1l6bTBocytMRFd6VXo5RjZGMHBGaVkrajlvb1ZxM0xweW1BQ2ZCb3R5RmIv?= =?utf-8?B?NjlLaVA4aVlOK3ljM2g0aVBvOHRtOTJicWdMeVNMd1dOODB6RG44VXpicU1v?= =?utf-8?B?cXZzdG9xL2hua3QrWXYydHQzVSs2VjRDdTlvbFJKbjVGSy81S1JJYnpXMTNH?= =?utf-8?B?bUFUdG1weW5jTXNqZU5mZjVDbTBzcURnZ3VyN2tmOGxZbUJCS2dCaXZmZTJv?= =?utf-8?B?Z0VkYTI5TGMwMTdxRG5VY2YrMjd2VDdRZHhvMEZZUEpvSXJEWVhraUNUY3Q4?= =?utf-8?B?aE5LUElyNDQ0aGhkbDRqMm1WRjdRVXM0VmxuMVVqU2Y3SXZPWWtKbFh2K0Vn?= =?utf-8?B?QnU5cXJzaW5WSkQ5T0E4WlZYMkdoblRmbko5dWhLbmJLZ2JDRU1kSnVYMWZ1?= =?utf-8?B?YTFyamRLcDk5dCszVWxtM2krTm1kVFFya2ZicG1CN0Vzc1RESGk1WnhVL2No?= =?utf-8?B?eG5zRkUrUFJhV1lQR2MwRm1PSER6UnN2MnpMbms1UVdqc1liNXVDcm1HTWFL?= =?utf-8?B?VEJ4cXpBT2xvUTgwVjM0ZVlxZ0FMdzNYek82WHJ6VFplQ09Ob1grckVDcmth?= =?utf-8?Q?zrOl9tdYYDj9uacm35F9NTIi7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63816a10-d74c-4722-d47a-08db14113920 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:40:41.0228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qOe9UVZLhguOr0dhY+Hr2RbRMREuRm7L7HAcBw2AV4GK2Auiuupptov1EppxfhLnZaEoI6MrUixA2CZlA4gyIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9458 On 20.02.2023 20:47, Andrew Cooper wrote: > Despite its name, the irq{save,restore}() APIs are only intended to > conditionally disable and re-enable interrupts. Are they? Maybe nowadays they indeed are, but I couldn't spot any wording to this effect in Linux'es Documentation/ (and I don't think we have anywhere such could be put). Yet I'd expect such a statement to be backed by something. > IO-APIC's timer_irq_works() violates this intention. As it is init code, > switch to simple irq enable/disable(). If all callers of the function obviously did have interrupts off, I might agree. But the last of them sits _after_ local_irq_restore(), and all of this is called from underneath smp_prepare_cpus(), i.e. after IRQs were already enabled. I'm willing to believe that the local_irq_restore() there really comes too early, but then, ... > No functional change. ... in order for this to be true, that'll need fixing at the same time (or in a prereq patch). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:44:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:44:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498930.769890 (Exim 4.92) (envelope-from ) id 1pUSw8-0000yc-4g; Tue, 21 Feb 2023 13:44:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498930.769890; Tue, 21 Feb 2023 13:44:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSw8-0000yV-1k; Tue, 21 Feb 2023 13:44:04 +0000 Received: by outflank-mailman (input) for mailman id 498930; Tue, 21 Feb 2023 13:44:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUSw7-0000yP-58 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:44:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0602.outbound.protection.outlook.com [2a01:111:f400:fe0c::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc125f51-b1ed-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 14:44:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7295.eurprd04.prod.outlook.com (2603:10a6:800:1ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:43:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:43:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc125f51-b1ed-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkveMoSjrFPh+M3TT4E6u/r2jlusw7dqCvSLG4GLr4vcD0ox/hmxGroNQOcJHRAX78ihOHqO/mkyJ9Rcf3eL/kdS8EaeDGpv/NoHkQd5bfRAs8oquBSFQoZs03QsZojeaY/3TsLEINWQXuyiIXG0sihO9ZXoQcvNw1c8yVBZaA+Jrb40W9jHLsENR1O62EI3E6iit8OAZijiTvWG78Goy1H8f4mr3zVb6aD9FeuXEZMpYQOdT/grsReEwYKwIKsZ7CRaFKUIalqILsjCe9CIge25FksjmcAiZsV8e8NQe77CJBaY9oD1vOMgg9tczZu7TZYVL5U1aY0wngfdlBdg2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W0h+IFmTm7H0B8bt9+u1IPd1LTqVSaMnnzLYj4qgZWw=; b=VT9tvHTyC6iqlUb8vPwR/UKBr/eT2zRY8hhioKVR2GYQhKxWnV/mJBc47nmiorA2Uwd9lk0jed2JyKOWDbQdGhTX3cF8ax8ud0pdK0T5HYnZ0InLYLJc0XnidCcCkiqW9854J9rWXSUWlNw337N2QT4iT+mRQIWGqw7E9j+9hTHd6eAoWcfOOAOyg4SCnzJcMo7oXl3945XFjMLkSkeE/lbnNZTFfogMnRgah7J38fO46C59c0ANtHMSu7xlhMpCkr4NUYBgGUZcYfngRsOVXs7VCOfVBx4AHP4BmV/SHv9zFZqQrs/p6EcmjucGlR9D8BQPf+Kh8RJXUlE2VzI5UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W0h+IFmTm7H0B8bt9+u1IPd1LTqVSaMnnzLYj4qgZWw=; b=kbzXeZvy4TjluGYFGfVrqb6Ekt2I8LW35PDK2mmgbqpjHA1C3uW39bnzM+Bm3svKSl0GyescQsLK5LBAHAgMrsTvEwpVxaW64VitYaI9PHooeI8cEH7Pd6FK9SO4349t0ReZOWbCXW3k5nNiuQ/6+fNEn8KgUY+9FXBla9xZUpaGcWsyxTPenOHIk1A/FTUGQq9n2SAVm6aIZwsHzaNk6kMucA/2+KDvg7SbqP/UJNBWoorpduXPSKQiWHWAT4Nh2pnpB5DPu2pEDYt11CNeISExCnHI67CWl1tbzB7M57n4ydmKUIYefxAVj92sUBCtTbxbDpEBxSn86reFv40BZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2def744e-e074-db7f-cb8f-3ec2e6ed273a@suse.com> Date: Tue, 21 Feb 2023 14:43:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Ping: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h Content-Language: en-US From: Jan Beulich To: Paul Durrant , Wei Liu Cc: George Dunlap , "xen-devel@lists.xenproject.org" References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7295:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bd8f451-76a1-45d3-9762-08db1411af3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7qMLB7cns0A8D7bQ15wOPl3AHL3MhXZ4mtUmHR4fr/WPZLhwuCPBsqfbM2WzhBJBn28yqP9oCEeTXsZjjN7zas1jaj++31rwl/x6G4tInRhzJgQ7qmH8wKps7qGluSFfH8AGKnP8fII9eVe/FLgZLyqcqOQ1E+aFUN11li01q+XHCBjsohz8VADk/CRL//5WMYj9xGclBJTmPb2AASqokTtAj6R0A4DTNWiHOrveA+BNIj2qmabrJNiR7i3YGtmKQd7X5EtMIq1kCUp5/XL1tnezM6bs/U3DhduxGF1aBtTa6FUqi6KZhs6m51jsKqtgjcw8IXcs11imP8BMeGEyq3AVUSsl75ENpzKJXGqX5t3980Jl9nATgczjNOGQ2J+nyIjhbjdIDUIwHhRl1sP8YwRODFIRbbZ+5alqRRIRmbx34uhxT7ixTgYM40/Jv/OHUvRy3Opibrkw5V1PEBR2++M0bIZ1xT7L5UPhSPCNxmEwXniX6D8wzF5J0PXYkGwp1JQ9PfzGkwZdH/J7E2QRAvWds1idwyYGL7Ew9itkILvf0J7ELcmkMmDik8m9CmM4cPkWuihWHOLlfZfvA49ILgOABxEB2T7f+N9jeLI6AgnZ5iXKXR8w/4WhfybtCN5AcutCWNnEwjhR+0Vy4UZpSUp4wyKiYlfSdK3d9ygRwXngKhuXtV2kc3xz0RsD7iGgw/9u7k6OltL+nbOHMxy/KgET6yKSMRgg+DGlxMKz6uM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39850400004)(136003)(376002)(366004)(346002)(451199018)(38100700002)(83380400001)(31696002)(86362001)(36756003)(8936002)(2906002)(41300700001)(5660300002)(30864003)(6512007)(26005)(53546011)(186003)(2616005)(6506007)(4326008)(316002)(66556008)(66946007)(8676002)(6486002)(110136005)(54906003)(66476007)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmRPMU5JZEVlZlZqYTFDbHhSWUFuZnUrdVZjaUwwUDRvSk02WVBCdmc0VTRK?= =?utf-8?B?MlVid0tqUzE4SjNnekRIZnhicUxJYm9zMjYvM1JpMk1mYjRieExVVE9YMHJB?= =?utf-8?B?L3VYS3FONkJnQUllbVpMWTNOTVBuazFTck5Zdk5pOGF6QTNCdjY4Q2NuanVE?= =?utf-8?B?cHRZNCtJT2kvckF3ZlNqMzZZV21GYWtoRGdrOFQ1aG9nSmRNTngyazRsSGJG?= =?utf-8?B?NWV6NWZReE93SDNVS1J5MjhSSklkcS8wVlBEQXZFUDZlSUxEeXp1TC9wcHV6?= =?utf-8?B?U2k0ME5VcitwbVFjcVVEd2ZPektjYmNMSFIzdG9SWGxOQUhIWk1zL0t2T092?= =?utf-8?B?NGpERlhzU0NjYXhRNVNtbE9Qd2FkWmkrN2xvckdYSGZmNzBsck5iMW1EcXZK?= =?utf-8?B?K3MxVnJ4cVRab2JqNmNZK0JzVDd1UDJIVmd2WSs0bG8xZ3hYMFdPMHBwaE5K?= =?utf-8?B?Z25rQVNRbnovajJXUy9WWVVFQ2xmeWlYZnM2RHJ6TmFsNkRGTGFyUXB6UTdG?= =?utf-8?B?b3VYdkRXM1J4N3NFa0pVcEFnOC95Nm5pUk9LMW1CRjBFV2t6RFF5UWIwNVV6?= =?utf-8?B?aFc2RG1BRzR6M0FSRkdLbzZMSHowUUpRVzBkUVROSnYyUlQ1VkNZVE92K2Qz?= =?utf-8?B?eGt2b3NVTjhsc2xubTRqZEY4Q2haWi8rL2EvY05iaTFzUE1Lb0hHeklkVSsr?= =?utf-8?B?RXB6bE83Qjg1L3l3ZHZTbWp3VzdQK1YxWGxaL1gzOFczY2kxcUN5NS85dWNt?= =?utf-8?B?N015VHVwSkFscVY3WmF6U3FGZE8ySVk1c0ZzbFNHRjVRcWRFeUh5U0VEc3B1?= =?utf-8?B?aFRmK200OWFPQm0wNDBkaHZla3pDc0F3S0VjdzRjb2xMYUt3MVp2TitOWXl3?= =?utf-8?B?a0czbktvWnBqc241ZDh5Q1hKVkZMa0xveDB3ay9SM24rTldxQTZKQUZVM0tH?= =?utf-8?B?c3lxdXp5dzNLemhZNjhmNjBTUEZXN3VNc2hycjIzOFZBZjc2SmN0M2ZDV1BS?= =?utf-8?B?SGVyRE1DNDJCbytIRm9BY2FQSmtpUjlnU2JNLzlVUXg4bThlY2VFVkprajlY?= =?utf-8?B?dmNLV0ZwcTBnQjBQbTBvZFFMUG1oREx5VmpwYlk1RlhWQjBLUjJDV3Vtc3l3?= =?utf-8?B?VnU5OXRYWlBxRTArMDVoaUk3T3dOQzVNMmhJamRtQ0tZMDd5dUg2THZKaXZI?= =?utf-8?B?ZHdLWGdUcnRMb0d6MWlSMm5WbUtxQlpZSHFzbUc3cnJETmpOaCtJZ0pQSmhI?= =?utf-8?B?b05YVGdObzdIcllQY2VOV3VadklMZlNGbmdmc2ZXT29TcWxld2NCWE9oZ1pR?= =?utf-8?B?T3NsMEVGTEV6KzJac0U2VzBGZU5QZjRlcDUrRERzK3RsbkZncnpoK3FaWUlh?= =?utf-8?B?K21GVVEyakN2VncyNlJLaDR1RkNaMHI2UWtIQnJKR01RVjl5MGVISjliWEpr?= =?utf-8?B?a0Z2WkQ0cEl4K3E0cXNQS2FudlFQQzBwbjhBUlZmblM3RTZvMU1PWVpOS2hl?= =?utf-8?B?dm9DV0crNmt1VmhaanRBZllxV3U4ZHBVZWNxSnhkdzg4S3RyUFE0WS9VMGV2?= =?utf-8?B?c3c2MjJadVBBRW1CcFA2Rmx4bGJuallyak1zSkVCemdhMG9OWGpxSUEzZUpF?= =?utf-8?B?K2JQUUROaFcxdXJiaVRxSXVYbDdnM2VmMUEwTllGUTZ1dEdnVXBQMXNWRzhn?= =?utf-8?B?WTlla2FYbXpUMStScnVPUEdrcHJrb0U0UFhGcjIvY0lRcUlUVFVmb0IvNWhW?= =?utf-8?B?eS8ybmRIRUVFeWd2VVlTUFl6VERUbllUZTYrS3lyTU1tS0owSFFzMFRWS3BC?= =?utf-8?B?bmlqTDdlNUh1QmJ5V051WUNPQUVyU1pEYW5zaXkwaHd1bjBFSUREdGk5ODB6?= =?utf-8?B?Q0ZlU2JGQVhuTlgxTXRqdi84V2Q3T2pNamZTZVNXdDMra0F5L3hkM3JDclVr?= =?utf-8?B?K1kwNnhnb1VGazFYOGJ6VDIyVy9LSzlNSHlxUW45YWtnazR0QmZEdVcxbm5Z?= =?utf-8?B?QmJHbkhDN1B4U0I1TFhDMjJnenlaVU0yVnl2RXhRa2MwSmd5SDFFYU0rUnBH?= =?utf-8?B?bStDN09RWDdHY1Z4TlNzYmJ4U3dUdGd6KzFrd0U3QW5oanErenM2U2h5Z0xo?= =?utf-8?Q?N7PeMQnims5aY8ZNojBDIC6e6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd8f451-76a1-45d3-9762-08db1411af3d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:43:59.1980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /hgyiwY+w2xSHMZPCaXQ6ukXlPMYO1/YisDrpay0OILI8EhxdU/m+AnyziiP2WCgmx5vEC/Mje7dkUDwFa19gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7295 On 09.02.2023 11:38, Jan Beulich wrote: > This is the only file left with a use of an __s type coming from > Linux. Since the file has been using an apparently random mix of all > three classes of fixed-width types (__{s,u}, {s,u}, and > {,u}int_t), consolidate this to use exclusively standard types. > > No functional change intended. > > Signed-off-by: Jan Beulich Ping? (I'll wait a few more days, but I'm going to commit this eventually with just Andrew's ack if no maintainer one arrives.) Jan > --- a/xen/arch/x86/include/asm/guest/hyperv-tlfs.h > +++ b/xen/arch/x86/include/asm/guest/hyperv-tlfs.h > @@ -283,11 +283,11 @@ > * Declare the MSR used to setup pages used to communicate with the hypervisor. > */ > union hv_x64_msr_hypercall_contents { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 enable:1; > - u64 reserved:11; > - u64 guest_physical_address:52; > + uint64_t enable:1; > + uint64_t reserved:11; > + uint64_t guest_physical_address:52; > }; > }; > > @@ -295,11 +295,11 @@ union hv_x64_msr_hypercall_contents { > * TSC page layout. > */ > struct ms_hyperv_tsc_page { > - volatile u32 tsc_sequence; > - u32 reserved1; > - volatile u64 tsc_scale; > - volatile s64 tsc_offset; > - u64 reserved2[509]; > + volatile uint32_t tsc_sequence; > + uint32_t reserved1; > + volatile uint64_t tsc_scale; > + volatile int64_t tsc_offset; > + uint64_t reserved2[509]; > }; > > /* > @@ -343,21 +343,21 @@ union hv_guest_os_id > }; > > struct hv_reenlightenment_control { > - __u64 vector:8; > - __u64 reserved1:8; > - __u64 enabled:1; > - __u64 reserved2:15; > - __u64 target_vp:32; > + uint64_t vector:8; > + uint64_t reserved1:8; > + uint64_t enabled:1; > + uint64_t reserved2:15; > + uint64_t target_vp:32; > }; > > struct hv_tsc_emulation_control { > - __u64 enabled:1; > - __u64 reserved:63; > + uint64_t enabled:1; > + uint64_t reserved:63; > }; > > struct hv_tsc_emulation_status { > - __u64 inprogress:1; > - __u64 reserved:63; > + uint64_t inprogress:1; > + uint64_t reserved:63; > }; > > #define HV_X64_MSR_HYPERCALL_ENABLE 0x00000001 > @@ -442,10 +442,10 @@ enum HV_GENERIC_SET_FORMAT { > #define HV_CLOCK_HZ (NSEC_PER_SEC/100) > > typedef struct _HV_REFERENCE_TSC_PAGE { > - __u32 tsc_sequence; > - __u32 res1; > - __u64 tsc_scale; > - __s64 tsc_offset; > + uint32_t tsc_sequence; > + uint32_t res1; > + uint64_t tsc_scale; > + int64_t tsc_offset; > } HV_REFERENCE_TSC_PAGE, *PHV_REFERENCE_TSC_PAGE; > > /* Define the number of synthetic interrupt sources. */ > @@ -499,30 +499,30 @@ enum hv_message_type { > > /* Define synthetic interrupt controller message flags. */ > union hv_message_flags { > - __u8 asu8; > + uint8_t asu8; > struct { > - __u8 msg_pending:1; > - __u8 reserved:7; > + uint8_t msg_pending:1; > + uint8_t reserved:7; > }; > }; > > /* Define port identifier type. */ > union hv_port_id { > - __u32 asu32; > + uint32_t asu32; > struct { > - __u32 id:24; > - __u32 reserved:8; > + uint32_t id:24; > + uint32_t reserved:8; > } u; > }; > > /* Define synthetic interrupt controller message header. */ > struct hv_message_header { > - __u32 message_type; > - __u8 payload_size; > + uint32_t message_type; > + uint8_t payload_size; > union hv_message_flags message_flags; > - __u8 reserved[2]; > + uint8_t reserved[2]; > union { > - __u64 sender; > + uint64_t sender; > union hv_port_id port; > }; > }; > @@ -531,7 +531,7 @@ struct hv_message_header { > struct hv_message { > struct hv_message_header header; > union { > - __u64 payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT]; > + uint64_t payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT]; > } u; > }; > > @@ -542,19 +542,19 @@ struct hv_message_page { > > /* Define timer message payload structure. */ > struct hv_timer_message_payload { > - __u32 timer_index; > - __u32 reserved; > - __u64 expiration_time; /* When the timer expired */ > - __u64 delivery_time; /* When the message was delivered */ > + uint32_t timer_index; > + uint32_t reserved; > + uint64_t expiration_time; /* When the timer expired */ > + uint64_t delivery_time; /* When the message was delivered */ > }; > > struct hv_nested_enlightenments_control { > struct { > - __u32 directhypercall:1; > - __u32 reserved:31; > + uint32_t directhypercall:1; > + uint32_t reserved:31; > } features; > struct { > - __u32 reserved; > + uint32_t reserved; > } hypercallControls; > }; > > @@ -571,199 +571,199 @@ union hv_vp_assist_page_msr > > /* Define virtual processor assist page structure. */ > struct hv_vp_assist_page { > - __u32 apic_assist; > - __u32 reserved1; > - __u64 vtl_control[3]; > + uint32_t apic_assist; > + uint32_t reserved1; > + uint64_t vtl_control[3]; > struct hv_nested_enlightenments_control nested_control; > - __u8 enlighten_vmentry; > - __u8 reserved2[7]; > - __u64 current_nested_vmcs; > + uint8_t enlighten_vmentry; > + uint8_t reserved2[7]; > + uint64_t current_nested_vmcs; > }; > > struct hv_enlightened_vmcs { > - u32 revision_id; > - u32 abort; > + uint32_t revision_id; > + uint32_t abort; > > - u16 host_es_selector; > - u16 host_cs_selector; > - u16 host_ss_selector; > - u16 host_ds_selector; > - u16 host_fs_selector; > - u16 host_gs_selector; > - u16 host_tr_selector; > - > - u16 padding16_1; > - > - u64 host_ia32_pat; > - u64 host_ia32_efer; > - > - u64 host_cr0; > - u64 host_cr3; > - u64 host_cr4; > - > - u64 host_ia32_sysenter_esp; > - u64 host_ia32_sysenter_eip; > - u64 host_rip; > - u32 host_ia32_sysenter_cs; > - > - u32 pin_based_vm_exec_control; > - u32 vm_exit_controls; > - u32 secondary_vm_exec_control; > - > - u64 io_bitmap_a; > - u64 io_bitmap_b; > - u64 msr_bitmap; > - > - u16 guest_es_selector; > - u16 guest_cs_selector; > - u16 guest_ss_selector; > - u16 guest_ds_selector; > - u16 guest_fs_selector; > - u16 guest_gs_selector; > - u16 guest_ldtr_selector; > - u16 guest_tr_selector; > - > - u32 guest_es_limit; > - u32 guest_cs_limit; > - u32 guest_ss_limit; > - u32 guest_ds_limit; > - u32 guest_fs_limit; > - u32 guest_gs_limit; > - u32 guest_ldtr_limit; > - u32 guest_tr_limit; > - u32 guest_gdtr_limit; > - u32 guest_idtr_limit; > - > - u32 guest_es_ar_bytes; > - u32 guest_cs_ar_bytes; > - u32 guest_ss_ar_bytes; > - u32 guest_ds_ar_bytes; > - u32 guest_fs_ar_bytes; > - u32 guest_gs_ar_bytes; > - u32 guest_ldtr_ar_bytes; > - u32 guest_tr_ar_bytes; > - > - u64 guest_es_base; > - u64 guest_cs_base; > - u64 guest_ss_base; > - u64 guest_ds_base; > - u64 guest_fs_base; > - u64 guest_gs_base; > - u64 guest_ldtr_base; > - u64 guest_tr_base; > - u64 guest_gdtr_base; > - u64 guest_idtr_base; > - > - u64 padding64_1[3]; > - > - u64 vm_exit_msr_store_addr; > - u64 vm_exit_msr_load_addr; > - u64 vm_entry_msr_load_addr; > - > - u64 cr3_target_value0; > - u64 cr3_target_value1; > - u64 cr3_target_value2; > - u64 cr3_target_value3; > - > - u32 page_fault_error_code_mask; > - u32 page_fault_error_code_match; > - > - u32 cr3_target_count; > - u32 vm_exit_msr_store_count; > - u32 vm_exit_msr_load_count; > - u32 vm_entry_msr_load_count; > - > - u64 tsc_offset; > - u64 virtual_apic_page_addr; > - u64 vmcs_link_pointer; > - > - u64 guest_ia32_debugctl; > - u64 guest_ia32_pat; > - u64 guest_ia32_efer; > - > - u64 guest_pdptr0; > - u64 guest_pdptr1; > - u64 guest_pdptr2; > - u64 guest_pdptr3; > - > - u64 guest_pending_dbg_exceptions; > - u64 guest_sysenter_esp; > - u64 guest_sysenter_eip; > - > - u32 guest_activity_state; > - u32 guest_sysenter_cs; > - > - u64 cr0_guest_host_mask; > - u64 cr4_guest_host_mask; > - u64 cr0_read_shadow; > - u64 cr4_read_shadow; > - u64 guest_cr0; > - u64 guest_cr3; > - u64 guest_cr4; > - u64 guest_dr7; > - > - u64 host_fs_base; > - u64 host_gs_base; > - u64 host_tr_base; > - u64 host_gdtr_base; > - u64 host_idtr_base; > - u64 host_rsp; > - > - u64 ept_pointer; > - > - u16 virtual_processor_id; > - u16 padding16_2[3]; > - > - u64 padding64_2[5]; > - u64 guest_physical_address; > - > - u32 vm_instruction_error; > - u32 vm_exit_reason; > - u32 vm_exit_intr_info; > - u32 vm_exit_intr_error_code; > - u32 idt_vectoring_info_field; > - u32 idt_vectoring_error_code; > - u32 vm_exit_instruction_len; > - u32 vmx_instruction_info; > - > - u64 exit_qualification; > - u64 exit_io_instruction_ecx; > - u64 exit_io_instruction_esi; > - u64 exit_io_instruction_edi; > - u64 exit_io_instruction_eip; > - > - u64 guest_linear_address; > - u64 guest_rsp; > - u64 guest_rflags; > - > - u32 guest_interruptibility_info; > - u32 cpu_based_vm_exec_control; > - u32 exception_bitmap; > - u32 vm_entry_controls; > - u32 vm_entry_intr_info_field; > - u32 vm_entry_exception_error_code; > - u32 vm_entry_instruction_len; > - u32 tpr_threshold; > - > - u64 guest_rip; > - > - u32 hv_clean_fields; > - u32 hv_padding_32; > - u32 hv_synthetic_controls; > - struct { > - u32 nested_flush_hypercall:1; > - u32 msr_bitmap:1; > - u32 reserved:30; > + uint16_t host_es_selector; > + uint16_t host_cs_selector; > + uint16_t host_ss_selector; > + uint16_t host_ds_selector; > + uint16_t host_fs_selector; > + uint16_t host_gs_selector; > + uint16_t host_tr_selector; > + > + uint16_t padding16_1; > + > + uint64_t host_ia32_pat; > + uint64_t host_ia32_efer; > + > + uint64_t host_cr0; > + uint64_t host_cr3; > + uint64_t host_cr4; > + > + uint64_t host_ia32_sysenter_esp; > + uint64_t host_ia32_sysenter_eip; > + uint64_t host_rip; > + uint32_t host_ia32_sysenter_cs; > + > + uint32_t pin_based_vm_exec_control; > + uint32_t vm_exit_controls; > + uint32_t secondary_vm_exec_control; > + > + uint64_t io_bitmap_a; > + uint64_t io_bitmap_b; > + uint64_t msr_bitmap; > + > + uint16_t guest_es_selector; > + uint16_t guest_cs_selector; > + uint16_t guest_ss_selector; > + uint16_t guest_ds_selector; > + uint16_t guest_fs_selector; > + uint16_t guest_gs_selector; > + uint16_t guest_ldtr_selector; > + uint16_t guest_tr_selector; > + > + uint32_t guest_es_limit; > + uint32_t guest_cs_limit; > + uint32_t guest_ss_limit; > + uint32_t guest_ds_limit; > + uint32_t guest_fs_limit; > + uint32_t guest_gs_limit; > + uint32_t guest_ldtr_limit; > + uint32_t guest_tr_limit; > + uint32_t guest_gdtr_limit; > + uint32_t guest_idtr_limit; > + > + uint32_t guest_es_ar_bytes; > + uint32_t guest_cs_ar_bytes; > + uint32_t guest_ss_ar_bytes; > + uint32_t guest_ds_ar_bytes; > + uint32_t guest_fs_ar_bytes; > + uint32_t guest_gs_ar_bytes; > + uint32_t guest_ldtr_ar_bytes; > + uint32_t guest_tr_ar_bytes; > + > + uint64_t guest_es_base; > + uint64_t guest_cs_base; > + uint64_t guest_ss_base; > + uint64_t guest_ds_base; > + uint64_t guest_fs_base; > + uint64_t guest_gs_base; > + uint64_t guest_ldtr_base; > + uint64_t guest_tr_base; > + uint64_t guest_gdtr_base; > + uint64_t guest_idtr_base; > + > + uint64_t padding64_1[3]; > + > + uint64_t vm_exit_msr_store_addr; > + uint64_t vm_exit_msr_load_addr; > + uint64_t vm_entry_msr_load_addr; > + > + uint64_t cr3_target_value0; > + uint64_t cr3_target_value1; > + uint64_t cr3_target_value2; > + uint64_t cr3_target_value3; > + > + uint32_t page_fault_error_code_mask; > + uint32_t page_fault_error_code_match; > + > + uint32_t cr3_target_count; > + uint32_t vm_exit_msr_store_count; > + uint32_t vm_exit_msr_load_count; > + uint32_t vm_entry_msr_load_count; > + > + uint64_t tsc_offset; > + uint64_t virtual_apic_page_addr; > + uint64_t vmcs_link_pointer; > + > + uint64_t guest_ia32_debugctl; > + uint64_t guest_ia32_pat; > + uint64_t guest_ia32_efer; > + > + uint64_t guest_pdptr0; > + uint64_t guest_pdptr1; > + uint64_t guest_pdptr2; > + uint64_t guest_pdptr3; > + > + uint64_t guest_pending_dbg_exceptions; > + uint64_t guest_sysenter_esp; > + uint64_t guest_sysenter_eip; > + > + uint32_t guest_activity_state; > + uint32_t guest_sysenter_cs; > + > + uint64_t cr0_guest_host_mask; > + uint64_t cr4_guest_host_mask; > + uint64_t cr0_read_shadow; > + uint64_t cr4_read_shadow; > + uint64_t guest_cr0; > + uint64_t guest_cr3; > + uint64_t guest_cr4; > + uint64_t guest_dr7; > + > + uint64_t host_fs_base; > + uint64_t host_gs_base; > + uint64_t host_tr_base; > + uint64_t host_gdtr_base; > + uint64_t host_idtr_base; > + uint64_t host_rsp; > + > + uint64_t ept_pointer; > + > + uint16_t virtual_processor_id; > + uint16_t padding16_2[3]; > + > + uint64_t padding64_2[5]; > + uint64_t guest_physical_address; > + > + uint32_t vm_instruction_error; > + uint32_t vm_exit_reason; > + uint32_t vm_exit_intr_info; > + uint32_t vm_exit_intr_error_code; > + uint32_t idt_vectoring_info_field; > + uint32_t idt_vectoring_error_code; > + uint32_t vm_exit_instruction_len; > + uint32_t vmx_instruction_info; > + > + uint64_t exit_qualification; > + uint64_t exit_io_instruction_ecx; > + uint64_t exit_io_instruction_esi; > + uint64_t exit_io_instruction_edi; > + uint64_t exit_io_instruction_eip; > + > + uint64_t guest_linear_address; > + uint64_t guest_rsp; > + uint64_t guest_rflags; > + > + uint32_t guest_interruptibility_info; > + uint32_t cpu_based_vm_exec_control; > + uint32_t exception_bitmap; > + uint32_t vm_entry_controls; > + uint32_t vm_entry_intr_info_field; > + uint32_t vm_entry_exception_error_code; > + uint32_t vm_entry_instruction_len; > + uint32_t tpr_threshold; > + > + uint64_t guest_rip; > + > + uint32_t hv_clean_fields; > + uint32_t hv_padding_32; > + uint32_t hv_synthetic_controls; > + struct { > + uint32_t nested_flush_hypercall:1; > + uint32_t msr_bitmap:1; > + uint32_t reserved:30; > } hv_enlightenments_control; > - u32 hv_vp_id; > + uint32_t hv_vp_id; > > - u64 hv_vm_id; > - u64 partition_assist_page; > - u64 padding64_4[4]; > - u64 guest_bndcfgs; > - u64 padding64_5[7]; > - u64 xss_exit_bitmap; > - u64 padding64_6[7]; > + uint64_t hv_vm_id; > + uint64_t partition_assist_page; > + uint64_t padding64_4[4]; > + uint64_t guest_bndcfgs; > + uint64_t padding64_5[7]; > + uint64_t xss_exit_bitmap; > + uint64_t padding64_6[7]; > }; > > #define HV_VMX_ENLIGHTENED_CLEAN_FIELD_NONE 0 > @@ -794,17 +794,17 @@ struct hv_enlightened_vmcs { > * Synthetic timer configuration. > */ > union hv_stimer_config { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 enable:1; > - u64 periodic:1; > - u64 lazy:1; > - u64 auto_enable:1; > - u64 apic_vector:8; > - u64 direct_mode:1; > - u64 reserved_z0:3; > - u64 sintx:4; > - u64 reserved_z1:44; > + uint64_t enable:1; > + uint64_t periodic:1; > + uint64_t lazy:1; > + uint64_t auto_enable:1; > + uint64_t apic_vector:8; > + uint64_t direct_mode:1; > + uint64_t reserved_z0:3; > + uint64_t sintx:4; > + uint64_t reserved_z1:44; > }; > }; > > @@ -816,70 +816,70 @@ union hv_synic_event_flags { > > /* Define SynIC control register. */ > union hv_synic_scontrol { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 enable:1; > - u64 reserved:63; > + uint64_t enable:1; > + uint64_t reserved:63; > }; > }; > > /* Define synthetic interrupt source. */ > union hv_synic_sint { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 vector:8; > - u64 reserved1:8; > - u64 masked:1; > - u64 auto_eoi:1; > - u64 polling:1; > - u64 reserved2:45; > + uint64_t vector:8; > + uint64_t reserved1:8; > + uint64_t masked:1; > + uint64_t auto_eoi:1; > + uint64_t polling:1; > + uint64_t reserved2:45; > }; > }; > > /* Define the format of the SIMP register */ > union hv_synic_simp { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 simp_enabled:1; > - u64 preserved:11; > - u64 base_simp_gpa:52; > + uint64_t simp_enabled:1; > + uint64_t preserved:11; > + uint64_t base_simp_gpa:52; > }; > }; > > /* Define the format of the SIEFP register */ > union hv_synic_siefp { > - u64 as_uint64; > + uint64_t as_uint64; > struct { > - u64 siefp_enabled:1; > - u64 preserved:11; > - u64 base_siefp_gpa:52; > + uint64_t siefp_enabled:1; > + uint64_t preserved:11; > + uint64_t base_siefp_gpa:52; > }; > }; > > struct hv_vpset { > - u64 format; > - u64 valid_bank_mask; > - u64 bank_contents[]; > + uint64_t format; > + uint64_t valid_bank_mask; > + uint64_t bank_contents[]; > }; > > /* HvCallSendSyntheticClusterIpi hypercall */ > struct hv_send_ipi { > - u32 vector; > - u32 reserved; > - u64 cpu_mask; > + uint32_t vector; > + uint32_t reserved; > + uint64_t cpu_mask; > }; > > /* HvCallSendSyntheticClusterIpiEx hypercall */ > struct hv_send_ipi_ex { > - u32 vector; > - u32 reserved; > + uint32_t vector; > + uint32_t reserved; > struct hv_vpset vp_set; > }; > > /* HvFlushGuestPhysicalAddressSpace hypercalls */ > struct hv_guest_mapping_flush { > - u64 address_space; > - u64 flags; > + uint64_t address_space; > + uint64_t flags; > }; > > /* > @@ -890,11 +890,11 @@ struct hv_guest_mapping_flush { > > /* HvFlushGuestPhysicalAddressList hypercall */ > union hv_gpa_page_range { > - u64 address_space; > + uint64_t address_space; > struct { > - u64 additional_pages:11; > - u64 largepage:1; > - u64 basepfn:52; > + uint64_t additional_pages:11; > + uint64_t largepage:1; > + uint64_t basepfn:52; > } page; > }; > > @@ -903,32 +903,32 @@ union hv_gpa_page_range { > * count is equal with how many entries of union hv_gpa_page_range can > * be populated into the input parameter page. > */ > -#define HV_MAX_FLUSH_REP_COUNT ((HV_HYP_PAGE_SIZE - 2 * sizeof(u64)) / \ > +#define HV_MAX_FLUSH_REP_COUNT ((HV_HYP_PAGE_SIZE - 2 * sizeof(uint64_t)) / \ > sizeof(union hv_gpa_page_range)) > > struct hv_guest_mapping_flush_list { > - u64 address_space; > - u64 flags; > + uint64_t address_space; > + uint64_t flags; > union hv_gpa_page_range gpa_list[HV_MAX_FLUSH_REP_COUNT]; > }; > > /* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */ > struct hv_tlb_flush { > - u64 address_space; > - u64 flags; > - u64 processor_mask; > - u64 gva_list[]; > + uint64_t address_space; > + uint64_t flags; > + uint64_t processor_mask; > + uint64_t gva_list[]; > }; > > /* HvFlushVirtualAddressSpaceEx hypercall */ > struct hv_tlb_flush_ex { > - u64 address_space; > - u64 flags; > + uint64_t address_space; > + uint64_t flags; > struct hv_vpset hv_vp_set; > - /* u64 gva_list[]; */ > + /* uint64_t gva_list[]; */ > }; > > struct hv_partition_assist_pg { > - u32 tlb_lock_count; > + uint32_t tlb_lock_count; > }; > #endif > > From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:49:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:49:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498938.769901 (Exim 4.92) (envelope-from ) id 1pUT1H-0001f5-Su; Tue, 21 Feb 2023 13:49:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498938.769901; Tue, 21 Feb 2023 13:49:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT1H-0001ey-PT; Tue, 21 Feb 2023 13:49:23 +0000 Received: by outflank-mailman (input) for mailman id 498938; Tue, 21 Feb 2023 13:49:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT1G-0001es-89 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:49:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060c.outbound.protection.outlook.com [2a01:111:f400:fe0e::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ae406f0-b1ee-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 14:49:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8163.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:49:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:49:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae406f0-b1ee-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzQ5Q5kQegwMlaA1ufnT6EUWuZshvTddGzTKiaNetFS5gT0BCpZ/xPCTwjP6J4+k2+eJSPryjUnRWSma10DDmV8w1pXEZJFehxIXy6EIRAkSLP9oJyc7TvC0UrYKWtotZvKwiC6CTrOsgswnsxiyYFljqhpDPRuc05j3w8CZroqoZJ6Ep2C94Mxsh8BH1ZyuOXK4lCyPAWwp1muMUOBfwIGNmWMnpuCUSj2/ymJfuYK09t8ksf3NFO3v6bECoAjEbRwbwaoE+KxbiEEwOInNze6DmeSvPGVIFEakZinDbz5En2GNVcF8MyleYw+8zcn2p6vuGYpqsBStJekAwYmXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEmawrD/VsVa9EqwTbkEfCkcw4oEGdNj9/RTJNDBNqI=; b=cNV80TpRngt3stEOSjxRU/oF7XFWS4OOzEGaRLc0XwMklKFFLV0Rsi3+gtR9KMiGFDEVOyPK3rb57+6s55y4YMcCpCgBdlzn6xYHwZHgtwxxvEUlESmOoQR7k0AokUTBIjbT4eBiqwnMUXVYa8Smf7hZy7KOSvHP4xsHxnpnb789CwOK2Rst8H80Lk+JAmdO2L0RLs80ry+ZAbfMnQLzHGRw3hx/0inTT/Sev3zUq56e1L5EwuXr8+bGdWtnxvu9Y+EsBi0L6bSx6w9rwrjXP9hIiGFJ9blI2OV6vInaWAJBp9+pxWQ5aRn3uO/NgfVTOOwfnL4v4boqHFqZtoAWmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEmawrD/VsVa9EqwTbkEfCkcw4oEGdNj9/RTJNDBNqI=; b=EJWeS/MYGSoNTnoia2k4nUHBvM35p5u/PqwRfOUoBen5ybECGr5qaNP2xWQo42nYglokiX8hMdfz2naqo4Rvpa8MlUjFPYT9Fi3vu28ogXvuvgZGviy8S1IJHO5EAshX4AhXkZNsMmH1vSZ8lveDSrimu+KrsJv4FdZwgB+xS84lbcT3HMwF2qOA9tSEx+xSJqwcpCfs6Z3C+/TSXgC3A5x4n5yTFNyGMVhi+MwUWDQJXMJJCuchXLn/pFvo/Xn4MTkLAeVvnnhSHi1GB+pWwvEYCQO6l6El7EpLzDlg1DndjQIYlnAI4UGLwhnO2QiPp8/FrYOmbI2oHVhRuq5ZFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <10e72c5b-7e32-f459-2d95-db3b1c7c2be4@suse.com> Date: Tue, 21 Feb 2023 14:49:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] x86/irq: Improve local_irq_restore() code generation and performance Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> <20230220194702.2260181-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230220194702.2260181-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8163:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cbc7c3a-6848-4e9e-3fdc-08db14126de1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AouxYZYZcRQhWADi4qjC0jFQjWTqUFGdrji0rrRz1yOMEnPr7+F0GI03TJAmr3tK9wECFyfpbAq4Ybo9VpAE6N7YDuUdsCTK6+ZpRaMvodOlBalbVOFvUWx9xOInPy6pX/LLjq2j+f1zSz3F11mYtM3lV/Ssi/37nO0b0/N/c755LI2VKWXcRuOnfbQtRyuHCeTQhUTM8n9Lrj0BwBjxAxvLzq4FAfvID3HS1BueMMSKtqzTFeOIsF+3ISPTZf5AE8zfLdvfsvDTskVsAlkxYxOPbY+79k/SdP5CtKJtg1Ch704zzG9wA/y00IKWAE+K3tUAtc4bHqczTU14/lXiQtwk2j7BXMXCbVe9pil3CrThnNciVEcih0aa0E2yk0eAzSmoZiBsUIE65nGxCYM3DGz2k7Se4fErYLzPuOu0jiTtEOTixKMOcoVgAG9m1XFHYRYOn6ZDoIEKcSYXK4McbpuuZmneqi7NXCZXGS888vcF9iYbme78PEmmuPpB+QQT1MQ8sYWueN3nmrgmlKz7OhBw1rft3RCZ2MTsJvJg4ZqBQQovhjxy+IWsc2/Wd/bmFHMmL5vNXieOrCnePc/ayYMmvgKxgt1AyUagQycMW+ltUqYIJCseeUSK0nY9eFk2EwPkb3baepRT02q3aYSWpYtSmVtCH5h9e5gjeWfk6EvY+lO/+/5qX6WYFEn8cZiob7ZrSn3iVvIeBYQ+fg43xlePbJPNGtASbayaC8FQAUA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(366004)(136003)(376002)(39860400002)(451199018)(31686004)(38100700002)(2906002)(8936002)(4744005)(5660300002)(186003)(6512007)(54906003)(26005)(83380400001)(41300700001)(2616005)(6916009)(8676002)(36756003)(66476007)(66556008)(66946007)(4326008)(86362001)(6506007)(53546011)(478600001)(6486002)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZC92WDRleExNbmg3bURYT2RDM25IUzJEb0krdWltWVY2TVZCQXhCbHVBamw5?= =?utf-8?B?bGFObEI4R0IwS0dtZGJpOTdtMkEzeVY1b2hXcnlHa2E1T3lxb0tYNGNLVDU2?= =?utf-8?B?T1BCWXE3SUFpRFE2b1BOZjRrM09yVHRseHFOamRuaXFHQURoRWtvVC9OOVFL?= =?utf-8?B?UzVCOUpzRDJOQmlOU1ZRaS9vaVd5bUxXYjhXdy9KK202ZExMU1dDN1N2MFh5?= =?utf-8?B?RC9wL2I2QlNWZHRJVFhXU3VHOUtjU0JWUmNFdW5LRE53eXBodTd4Zy9MaHVS?= =?utf-8?B?eE53RUV4ZHJnMG4zdkk5U1pxWXMvS29nQWdlR1Q5eDQvU3U0RDNQVEEyWmV5?= =?utf-8?B?bFk2OVdkd3AyaVFCL1ZsbVFraWJ0OUNERm5KYzFleWw0Ylk1NUl4bnJKbHU2?= =?utf-8?B?aHlDZldkQ2NsQWx2WVd2alhZcUhKT29hbENFM3NpeHBXMENNSGRzaCtRQ2or?= =?utf-8?B?VUdUZWtueVNyNjJFeWpneWFZZzcvRjZjYWwyUVVKeG1uTnVrL2J6RXBxSTBu?= =?utf-8?B?YkthcFNnZDlkSVlGcCtDMXZxZklhcGR0R0tmWmZDSmJiQ1FaUFNuUk1iY0VW?= =?utf-8?B?bjlUTUlmZ1h1R2dpNENUTjFFQWdrSnpVdWowdjUySGZaTzhJYVBpVk5vTE4r?= =?utf-8?B?OWlwamVCVkJjbFcxbE1XR2F0U0g1UkNYNjhFWlVYQ0tHbENKV3ZqSGZvQVFs?= =?utf-8?B?SWpOR0kxTStvb0ttKzJJdlo0WERKSVVZN01YcGhxVXU2cXZ1TlVjSDczbTNT?= =?utf-8?B?dGk4ZFhsbUJHUTZTTFZkNzRwU3BvN1lYV3hjZ21RT3U1dUFnVXIyN1l6a2ZW?= =?utf-8?B?SnB3dDdmSDNuYmx5eDgrcUpmRktEVmFxdExZV0F6ZjZJUElLMDd3MlNLa2Qy?= =?utf-8?B?UExhdHJ3UVlsTXZjQU95Y1J6eURHdXVhbkFURGtGSVVQN2dlQm9UTC9xajlk?= =?utf-8?B?S1VKVXlxSkFvNXhCNDhSQTdIeFg4VzRRVE13eGpvcitHV1NZdUlpUzVtR0J2?= =?utf-8?B?ZUJTK2NrMjhOYmc5VFRRZ3FXZUFLemx2U2lJbjBIOFJTaEF1RUFLZU1FeEFK?= =?utf-8?B?RVJvRGtSWFNUSU5USUZSa2xpM0ZxNklBSzJZazhST1h3bTFON1k3RlYvS1F1?= =?utf-8?B?Zkg4eGJDcTA2MWlQT2F0NElEdEtLSElLeXhWWlp5N1BLeU1GVWQrRTJ5MnE2?= =?utf-8?B?WlNMTjlmcVBCdlI3MlpwYWFCSVE2OVN3WmFBOFZiVHJhVzhxdXhyd0ZXcmZN?= =?utf-8?B?eW53U2dOaWJTU2VNWjl4V28yM0laWElGYW5ZV2RNaGM0d09JRElpMmNRUFB4?= =?utf-8?B?Z2wvN1JDK3dQL1QzTHFYaHI1aGk5UHhWWjk2L3lLVWpIN0lhZVdnb0s3R3Ro?= =?utf-8?B?L1dVeDJqQkdJQ20zcVBoZEhpbHZqaEFCQVhtaWxGV0Y2aGVGZGlyZFJjZVU4?= =?utf-8?B?dUlEU0cvY1FHRHp1WFh5SmlCazZ3b3VObHphaW1zUVhteGVtTHpWMVhsRFc0?= =?utf-8?B?c2RZaVc4a3p4Wit3aWVzakVWcjZLRVdZbU1DdTNNcDdpT1dhMWFCM1E4aVR1?= =?utf-8?B?ckxJbFR6RGhtSW15VmxsamVDL2U5OE15a3BXS1Q0cGZxQ2VxZHdzOG1id3Er?= =?utf-8?B?TXE0aFBGTHY5cWZpVElwbHp2QjBYamxNMzFiNGM0Y09WbHBsL1RJRVcxeUZK?= =?utf-8?B?NGhxcGRKYkNrSy9FRFdrTXlGUE1wWkJvOVZSakUrQmxMK0hNWUhqQ2tkM2xG?= =?utf-8?B?UVFKY1RaZXJySDhrTGhVVldFclZpalhiTUMxK0VJSGNTeTRoZzlicldKWVpk?= =?utf-8?B?bjFCVXdzZHRjeHpKY3BDR1lGR2ZHMDlVTHh4bXlyZGpHZnQvQlVUMWVyZnBn?= =?utf-8?B?bFVkMDFITFpmY05CaDg5cDMxS1M3b2EzWlRZL0t2cHZXRFNid3kwWENlclY0?= =?utf-8?B?eldvL2hHWGdVYnloU1RWYkFaY3RPZjJocm9GZjFrSUxHeStGZEZQc1d0c21z?= =?utf-8?B?ZWZjQ2dwNkgvazVnU25wenN0QWt4SVd5Ky8vOEtscm5qcTNiUGwvRnl3Smh0?= =?utf-8?B?R3ZPOHI2dVVFNjRLYkhDRENXbUx1VFhRQjBzSFN5b281aDROK1YySGhUQ0Y0?= =?utf-8?Q?lExlGBoZ6bAMyXEqGaT3e+4xK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cbc7c3a-6848-4e9e-3fdc-08db14126de1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:49:19.0064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tYAPQogHMP0MyzYVM0LXsjIt4bDPAh59t4DcbQ6RbLQ1sflw4joNgNfUbNcfd/wI10AtJOp3jFrhwYtNUvhIYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8163 On 20.02.2023 20:47, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/system.h > +++ b/xen/arch/x86/include/asm/system.h > @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index, > }) > #define local_irq_restore(x) \ > ({ \ > - BUILD_BUG_ON(sizeof(x) != sizeof(long)); \ > - asm volatile ( "pushfq\n\t" \ > - "andq %0, (%%rsp)\n\t" \ > - "orq %1, (%%rsp)\n\t" \ > - "popfq" \ > - : : "i?r" ( ~X86_EFLAGS_IF ), \ > - "ri" ( (x) & X86_EFLAGS_IF ) ); \ > + if ( (x) & X86_EFLAGS_IF ) \ > + local_irq_enable(); \ > }) Without it being written down anywhere that IRQs cannot be turned off this way, and without there being a reference to that documentation in the description, this is introducing a plain bug; I'm sorry to say it that way. With both of the above fulfilled I'd of course be happy to see the improvement take effect. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:54:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498945.769911 (Exim 4.92) (envelope-from ) id 1pUT6G-0003Oi-FM; Tue, 21 Feb 2023 13:54:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498945.769911; Tue, 21 Feb 2023 13:54:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT6G-0003Ob-Cc; Tue, 21 Feb 2023 13:54:32 +0000 Received: by outflank-mailman (input) for mailman id 498945; Tue, 21 Feb 2023 13:54:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT6G-0003OV-09 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:54:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0612.outbound.protection.outlook.com [2a01:111:f400:fe0e::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42d6edf3-b1ef-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 14:54:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7937.eurprd04.prod.outlook.com (2603:10a6:20b:248::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:54:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:54:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42d6edf3-b1ef-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQSCL0fT9wusFuybQlxVp7I0Rl0K8lKj0EyfabK9I8rYt238E83tcK0fX3IdSodDC6ei0faKWUGtg3X3VZl+j+kIMv0skxuulwd5higzHCFu7QvlVqG5Klhb5Cxt7hQfaNrkAmULOKIEk3PwuIHbJTpEpTYNskqD0vmt/QNN1XpHuLyTlJvBJCcvRqC/LUOan5M1dnwzfH37C/M6IGa5HjFQc0J68pyTQuWNyftCltN+0NF2W1FTg/0Amdh7gFkfL42F/6IgW4riHR4rV10FoCZ+pFKrJtwuUG7UK6hnr/5kpS4zcLqwcWVJWwGqaqqqYwInVu7kM7twvdKa3sLfvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EVTJvYTKDnQXBucUhW3cMkKX3h61OEW67kbmqIYv/Js=; b=HSJKO2arEXReO2nkt6dSloHS/IzAZ7Fia+RAJCOmTUT30AEoXhr0ZVkhfO0bPWyGvzMyNpbWm0pN9xsvEANWaW8EVBOfS2UQvUUZbKpZ2h9awmesMWK5GKK0H6iQTk21O/xJ7E3nmrTFtLcruVJkNjhGszIXWHJWWuXAVGcChPySpl2keYvcwrTDABAk2aWoMqhrYhNZ1V2Lx1ovHKHPUdtv8e3yC3YsXGlgaO105So2fHkbZSCGO3xRwrnFO9i52PhL1W6q+rYUM3H2sCkm6dyW+EoRQ3xzxeBCfnumb7CjI9ytrnEm6oxQQJVlzNPFamFu3Eg8SIsmZLe/0lQFiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVTJvYTKDnQXBucUhW3cMkKX3h61OEW67kbmqIYv/Js=; b=Vj5dwczGGRtzl7iXvPKaJ7cEYjpmrTZo5SY7+be+U5xD8/nvxP/R5wBeQiylW/7ct/XFQJk75JVmOtccsi445SN2hCsGQBvLgtnTnxrvVIEytvu5/PUERpJWS8VSi81UjAyESDaBCZxJtYdWcN4J58RMiPT723kHppQq67huXE5f8FO6Q4LjsBoMla9MqjI7mN/U6BRfbe09SE4Aph6n7Mkp/geNeZXgk+w9kVmOH51g8JZSXu59Tm0J2HFZKHtYcQiPhO2kXNLmfb43WpvqNnxe3wo2u2viw1fAbM3o2f1IK559jMFhva7zMtEWf5dAE+cs4p23Km7puQoM6CNCCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2692e97d-b3d6-6512-bff7-c13941c10cd4@suse.com> Date: Tue, 21 Feb 2023 14:54:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7937:EE_ X-MS-Office365-Filtering-Correlation-Id: 702276a7-c929-4a51-96d5-08db141325de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 33ES1B95OstajfYOuIWYWBTMgIJ2BBnOFJL5v0M+Z5Tbs/4Qp1LjvajRtGQ1ofhC7XjT/Iv1XI+qYNxsQlktt33h31h7JfyCM0zqpA2ICmgDDrtoZVJUDDFonQpu0yWauYB01bgKjeX3lIlJB0bPUNN05awwNpqhkkR0yh/tEkzX7ZJlH729NGkm1Y2RPPKTbSwiNs9bWtLXrTcAx3WQ9PZHvgNstiuNdIa6I64XsVZZomjFjjCalq8VTkldCQrsRi6SbTB4QOlNfv7RAQou2bnjJW/sfAdbhKmMB9mhtWgt3j46MuSaeEifyKuIhOOLF64qhhKTWpM4dFOyIbjErsJ+i5P9d8zjeGnxGyCLMHiSMLQPnFQ5Mm2+PSXn71GDEoCnR/CaoC/sBQDFUhrFShNtUKJusAAbxwuOXlTDQWa5kF1FkcUj2z0ARAWNpaXnM5lZNRPbmc0wsw+GssRqtfse2JnWSndFFLT0Ou9b7QxH1gYbK6ATiydN1PtffroU27+UTUbIBpzA4d50cQHzmHpmY5PX0ns7R7cx2TchIIbE2OaWjgYzHPpwmMFZPbabVkM1kg6Ero4GN1z4fblS9pKEiM5YayZsz0JtUiZ+UIzTBg6lG5LcUiMPrN4PZCHsi1JICqAVUPg3fdAdaLXyU+IhK8DeJvTfZozA35sXor7C0xGdffGSq6nzhWq6MZFEXSiCrsQc/2tieW9jlAvwRpqzx24tcp0NSblNALdxP9U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(39860400002)(396003)(346002)(366004)(451199018)(83380400001)(41300700001)(54906003)(186003)(6512007)(26005)(316002)(53546011)(86362001)(6486002)(6506007)(478600001)(31696002)(36756003)(6916009)(2616005)(66476007)(66556008)(8676002)(4326008)(66946007)(2906002)(38100700002)(31686004)(5660300002)(8936002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2pJYy8wVjdCVGtkT1VnSVk0UitzV0U2T0FQaE1Ua3N5YzFCb0NkT2FpVTdp?= =?utf-8?B?aFNneXAwQy8vOU56ckp5bFRvTWhzRVRYNG5UL2laaVJxd2RDMGdsRnppVnBP?= =?utf-8?B?dXZXTVpzR0VqZWo4a1l1R05HK2k5WTVDS3pnK2tJdnRuQzFTWW81RC92ZS9s?= =?utf-8?B?bnR1clVYdGFueXhoMGlXR0Jaa2I4akY3TDJPT0xkbFRmWWl1ZDhLUE1MRnQ5?= =?utf-8?B?WkRPZDdiNXdlMW95eGpNbzBNVGdTSjdtb3VVK2o4VjRGQmhSOHp5RzJkMCtS?= =?utf-8?B?ZGNLQUZrZDE2b3hLdW9MRGJWM2FETkk1TTNxSHFHazVkN3lEd3JrVmtHSTVz?= =?utf-8?B?Z09xY1A0SXphaTlORGFja3NRZ0VUSWtPM1VJMlF3WXpuOXl2a2s3RURPZE1q?= =?utf-8?B?cE9GUGdwS01VUENaclNTYkR1YVhPODZtZjJ6Qzg2dnRkK294MDNKT3JGNzc5?= =?utf-8?B?Qi9ubkw4ODUyaVpBWGdmMWsvdDFXajd0THgwWUw0UjBSTlI4M0FySWpBSzJy?= =?utf-8?B?TlIxQ1B4U0lLREQvMkVUdEh6cTlpOWQ4b1REZGx4LzhvcjUybG1xeTlrOUJ2?= =?utf-8?B?NHpacHBFMkdiZVg2ZkxLVmozUVI5SFNlMGo2cWhCcXVpQTZyZHRHbTNBbW5z?= =?utf-8?B?WDc2VE5ldkhJSS8wUVVDNjNuTmlqbUxEUDEralZCVkxwWjdJaXNYSUVtK1hH?= =?utf-8?B?ZkErR2FMaHFET2Z0Y2U3K2x1T1BaOEduMXQ4bk90K1VnZjF1MVkvTzduU1dN?= =?utf-8?B?eHVlRHdUalF0L0JxQlpmZlJ6VE56akEwUWRDcUMvVWJ4Y254OHgyeGUxeWQz?= =?utf-8?B?N1hJNTgwZjVoZWtiZ1VPS2V3WEJnbVVzM2h0TlFQWmMxeUkrUzFWSW0wSnYz?= =?utf-8?B?VXVndzE1azNieDZIV2FneGpiQ1pmZkMzS1RZVlpPK1ZGSGgrR0hhN05mVzRV?= =?utf-8?B?VEJKbDFLTTJUOGYxQkJsWGRlcHdMSkhVQmtnZ3dwenJoWlQzbjZ0dTI1TGF6?= =?utf-8?B?d0UvQTdzcnNkU3pjbStZOXVNaDQvMEw5b1dNTmVGYWpLdzZaRzNxWGkxUG5h?= =?utf-8?B?WXY0UzdjeVlNNDYvdmh2U25BZUVyb0g5cVFZS0owOEpzSzYzZXNBa2d6OUNC?= =?utf-8?B?MXpvZDBqYXc2VG1sekVlVnFFOEhMQ3doUDZMSnRKZUxpSE9aME8xUTd0d2l5?= =?utf-8?B?MXlJUTNjMFIxZFkyOVM5cDEyMDc5L2xPQjVSdzlYUktEbUx5SXVFK051bklj?= =?utf-8?B?cVE2bmhnQU9NRFFWcy9INzhtcFQ4KzgyWTFWdlN0T2YrVVg3djN0Wmp4eWor?= =?utf-8?B?dzRieHFVcHFkcWl4WEdENjJHYVVFTzNiSWY3UFFjNHFoOVR2R0JvRHFSaFRE?= =?utf-8?B?Vk9lbnJTRi96aVBPejVDbUxZOWFZT010ekpISkRXQzlnZUs2MmN1bkU5OGNF?= =?utf-8?B?QkhUalZob1pUQXFBWHQ3V2dSRTRsMSsySTg0cFc0clRodndMT2cwNW9CcXN0?= =?utf-8?B?a0JXa2p1dlplZytnS2RWWFpYQUt4Mm1ONG92cWtrWngyMkRrZGVxWjI4Slh5?= =?utf-8?B?eUEyVnFkYnQyVnk3NjhpdEZsODRqR1pDU2tUcmJFb3pqdUEwc0JOZnFYMU8y?= =?utf-8?B?SUhKU3o5Si9xWk9LNGNuT1JVWjZLMkFLT1dDYXJZNlFWNTlWM3NCMzMrNkM3?= =?utf-8?B?bEtsSVcyamRUcnU3UUZzWkp2SHFGZVFmTTdpaWhRUEhXQjZyNmVwc2oxdlRI?= =?utf-8?B?UnB2MDJwQXNtWnhOalBkQldBWTlieGdEUEw3RnhLT3BkZnVFKytFTDdMSGMw?= =?utf-8?B?ekRZeXNER0dNS3oyMXRibXZIRW9YaG9QaCtkTlB1VWNDTnZzRVRWVUk3MExB?= =?utf-8?B?dzJYRjNUZ0JkdVl5b0FJMmtGeC9Yb1VoTDZVZ2N0WDZtQ3NJcno0T1JhTmxF?= =?utf-8?B?VUpZSVNtQzRpZURNVDJZa01FbnV1THlwYzdtNFR0SVk1alRyWTdheTJaaW41?= =?utf-8?B?RVY1cWFvMVBsM1Vzb1RPMmRRWVZQTnlOS1VFWmNRVWJJQ0dwVSszZEtsQ2F6?= =?utf-8?B?OHlrRTdPbkNsSi9qTEN5djBRdHBJdTl5UVhIT1hKZjN2dTV2blNsZEVVcDdC?= =?utf-8?Q?Jcfk4J5Rs9KqesAoYNe/GOLeb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 702276a7-c929-4a51-96d5-08db141325de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:54:27.6585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N43O8fo9iMaKl05plv1Sdf8PgYkicRIZPkx2yjsS9rksMuPQSg03wU4GYizkjvSVpjdP3/4koyqICYhK8zHz7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7937 On 15.02.2023 18:07, Tamas K Lengyel wrote: > An assert failure has been observed in p2m_teardown when performing vm > forking and then destroying the forked VM (p2m-basic.c:173). The assert > checks whether the domain's shared pages counter is 0. According to the > patch that originally added the assert (7bedbbb5c31) the p2m_teardown > should only happen after mem_sharing already relinquished all shared pages. > > In this patch we flip the order in which relinquish ops are called to avoid > tripping the assert. > > Signed-off-by: Tamas K Lengyel > Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively") Especially considering the backporting requirement I'm disappointed to find that you haven't extended the description to explain why this heavier code churn is to be preferred over an adjustment to the offending assertion. As said in reply to v1 - I'm willing to accept arguments towards this being better, but I need to know those arguments. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 13:57:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 13:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498951.769923 (Exim 4.92) (envelope-from ) id 1pUT98-00040A-Th; Tue, 21 Feb 2023 13:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498951.769923; Tue, 21 Feb 2023 13:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT98-000403-R6; Tue, 21 Feb 2023 13:57:30 +0000 Received: by outflank-mailman (input) for mailman id 498951; Tue, 21 Feb 2023 13:57:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUT97-0003zu-NH for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 13:57:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062e.outbound.protection.outlook.com [2a01:111:f400:7e1a::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad77120a-b1ef-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 14:57:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8006.eurprd04.prod.outlook.com (2603:10a6:20b:288::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:57:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 13:57:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad77120a-b1ef-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XyOgCF3YbPZhxyUDpvEHmTCuDi4o2q3jPZhm2IoHjXFJU50JknKtC4aLvzQ/yP6ACKya1ya2SAxtJXINahyIT36wTNpD8ND+rdg7lX2kt0oxgATN8LMzKCVsdlAbFQ5+xS3z+OsRBqEnj7rK8HWjaECsc8z31iF2Xzr8CWPxEd+rsYBTaEvSN+bRJgDhIujoj5J8YGmAy68KJmo57hedk15PpFkYEkeSppuM1o+a9/tLvf1wz/IoMfg1hNjif84wD3AUrv15yOhGDZPFV7al8uyypeDMcMf2UNM7nGPWHINLwc/oDtMdunMejT3dY2SXLsINEnSVBxSsQzlcOC7f1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=umNI7GOz8f8ODLRijF15cVDByfHm1eNx+85SYK6v1Rc=; b=KXbIspAYgm3w17B+PJmgJcwnGeve6cXtQ8tKX5KB9tPK5/3g+iuZtkLtVj0HoidaYD39t3c1BGthT2wzk0AesCIE7B2uxcJrNSbANlUFGBxbK9ZPHHlBAWde+4f1XEY+umVQscTVlVCTeMStQvlGLI/bpdqdocbuXqv1wbH6GXKyFVnbducho+p/OpL+lbcaYH3bThS4Lbyo5j9Wmyr4H/2/uJWvn8+kvFpWlYQnXZDIaO/6lNnuXZSQO2y7Gp87Oo8jOi73prvt71qkDFwxAMHeP+TEf9P0PLc33dVVwMaQ9kKfm1NB/s7YLF8BiKXnn5Iw25t1LuaY6ZVvC/ngow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=umNI7GOz8f8ODLRijF15cVDByfHm1eNx+85SYK6v1Rc=; b=38+Nk03opQqH7aMVMu5hgM5BdT7C6FMc0nCCEr8K3ZNZBNk1fr/anwnHZ5OWT8XLP4uZQleBT00xEs0oqnPDmOShCRfKwqj4gay1/6zndYKvULDtWVvZUpOCR6Xxc4d54odmSyJtaMz7KniNk/sdcGrj/mzKCchwQZPcXvcg44WpYn6VzZoSssEJnBUReTAiGJdCSdqEwoLUFw6xb+9vfs5qK4CN7tNff+6LWpeEIoNikkdAG78bboeUmNEI1ySfRTH7daeGK3YFAYIFZ9xaBHfPliD6pypB0GPLpjepkhCIZ76weNtWCKQZYUzVwFJPhkEq5047JDpolTjiWsEtbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1876699c-b87e-3b90-57d8-f735a5c6e6d0@suse.com> Date: Tue, 21 Feb 2023 14:57:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 1/2] x86/ucode/AMD: apply the patch early on every logical thread Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Sergey Dyasli , xen-devel@lists.xenproject.org References: <20230215153846.18582-1-sergey.dyasli@citrix.com> <20230215153846.18582-2-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230215153846.18582-2-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8006:EE_ X-MS-Office365-Filtering-Correlation-Id: f029e9d0-86b5-47db-4edf-08db1413902c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i98PuhMzqt5i6xrRd7CopbRC27pMktssyqaC81wUADhoad07QcoRl08Zupy4XuBjKb3X6bRmMAOHBnwt6Dnx2J6cJcLCrgsU4dv6xzwfUAZoQ3byDhjTxdgYq0zP8YggMR+pKBuNGzgyYd2KBU4+Ya8bJL3EM0tn41fBSL9qvKrf5hi7mQ+TQI0MWAEPMIvMcjdTCX51kGA7DmYzgCs/C/y8l3fJgMdbuSZqDv7vRUwEY6ZfCQBfgNVejzo5u0AzA+RfFdi14QpQ8Ot3pOx8NB+H+9lQl7++cyD/T5l3EuGlaNpyFik2BCM4mBc6D+yrE957pa25/Ijw3NUV9KwHQXN7m2mwV+o+va2Zg+cON0C9IrLG5ymZIRbe0dGPawX/1mSpYCayrhD/dFhQnX7lFXDprwc7KZTzcFqucrA78yje/zn5JdHro/6YB9+FS6Eu3Rx+43Vcf/k8YpeJe2aTjboelfEcj5HSBSyYee8QZ+eETpyocy7zQcj3RIAWpOJSMaPjeSPT4oL+XoUkCATJcYBpJQgWyKzHK4bhBM9n5/dxICnZZtHZ/3UuLSlkWKElJrojiw21gcdi+8IBK21CwDlYtPJ/0zuJZSLdkZcDwS+BFg6rmgPZeBWNKd6Xsh0GZ7tjsjOW1tTCzNrLcJPUdxhnBIpuXOwAJsB/24g5z1CnncRZWSMN+cr85QVsjEj5RxugWJidcntuCB7o120JsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(376002)(346002)(396003)(366004)(136003)(451199018)(41300700001)(83380400001)(186003)(6512007)(54906003)(26005)(316002)(53546011)(6506007)(86362001)(31696002)(966005)(6486002)(478600001)(36756003)(8676002)(2616005)(4326008)(66946007)(66556008)(6916009)(66476007)(2906002)(31686004)(38100700002)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eno5d2pnelN5dU9vSXcxT0U0UGxUY2VqRW9tVzdOc0xzY0tSSnpnRng1T1kr?= =?utf-8?B?aHlOSjhhSCtFblpHS0F1dzFDbWhRcjFieE13U2NVbENjeWMxcnNpU0cza3dF?= =?utf-8?B?ajVGOEtGV3RuaDVxSC9LTGd2eXZwSnFnQ0NtSVM1MUliSFFBRng3S1dUbFls?= =?utf-8?B?Q3U3Rm9ZdUtEY0wwTjg4R2MxdDZSdkl2b2dXaCtGVjBkbmRNbUM4NUFqT2F5?= =?utf-8?B?MXozTDAvYXgyVWNpT3hZem9RODdCQXY3aUYvRTIxaEh4NmlaUHYxRXlURVgy?= =?utf-8?B?TXFpYzFBYVNLZHEwRHgxU0lmWDRHcFFQQWovYTNMTXBOczVtQWtwT3E4ak02?= =?utf-8?B?UnBrVm5NN3lUVCtBOTN1YVdNd3doSHBYYTRoOVpuUDZwRFNBOXd6ei9aNFdw?= =?utf-8?B?TlpmaExnZDRjL0xTSmtFYU5ZS3ZVaWJtbEpnazQvTklseVdzZzZZaUd2bzNX?= =?utf-8?B?K1padmdCY1VDMzlzNzdjNEVsMnNIaFlLek9hK3lDaHhCQWNPQmNhaFd6YzRH?= =?utf-8?B?NC9yQ1VSOUlWa21CTWd3Ym0wVWE2ZGNNeGxJMzBuR2hvVHdMSVZiVFo0Sms4?= =?utf-8?B?cE14YkxpNDZWTlU0NmxyOHVGYXdpZHI0QkNWeWQyMkNrMVAyYzJNZGVLV1pN?= =?utf-8?B?a1NRMDdaL2RJYWtPMkNvWnhRQXJ6dWRENXl0bkF2QmZUUHZzZUl1b25PY0Zo?= =?utf-8?B?WkszeUdMNXJtUUhkaFpLSnVORjhuYkJKVndYQWNsUDN3ekJzdFdvSzJTY1pO?= =?utf-8?B?L2dYN1Z6RjgzUSthemRTT2FHb2tKT3lkaVhnclV3SW4vS21lK2lmZWcrNjF3?= =?utf-8?B?cE9wWjU1Z2txTmE1QnlSdWxlLzRQYm9HQ3B2aUdnOVRSUFhJblMwbUk0dEh6?= =?utf-8?B?T0F6ZXhsL0NpV09HeE5uMTdDSXNEKzRFVlQ0ZTh2T29FRUVIekVjakxVZmlL?= =?utf-8?B?NGIxQTB6Q1Avem1WaEVHakNzOWhuUE5mUXArWlB4Z2FMbVN0dnd1MU1mcVhz?= =?utf-8?B?M0hKUGRMS2x3WU9uOFVRYkFtOGxqVGUxS0NlSkZVdTdtWGtVSnBkc3dnSXIv?= =?utf-8?B?VkhQTzNCNFVDR1lIOVkydmdBRVduTXJac1VqTXk3c0VUbTQ3Z29hVnBpcFRq?= =?utf-8?B?a2pHS2NCeURwdjFTODFYYi9LVGJYQzNMWEdPWEtyS1A2azhCMXA5N0xWRnNU?= =?utf-8?B?YS9remZkUUtBUDFEMWxuUDVMMzIrZjdxL2JldWg5bzI2VVRRRTZleXNDaEtO?= =?utf-8?B?TXdhY1hFSnlESThxM3BhSDY0TUc1Y3R0V1o1ZjZEMGYxK0Yyby9KOVcyWVZh?= =?utf-8?B?cGdkbHAvQ2VTcUVGOTZUdXJ0Yk1BY0w3SEpVUlBSRXZDVENuVnZBUzVvRUx1?= =?utf-8?B?aE8vRld4ODFNbGRJS0lleUZ1a0pQampBZWR4L1RTUjE3K2twcGVGRzFyOTh2?= =?utf-8?B?aUl4UDcyY2ZIUG0xMjJCemhyY25HenRSQnNUMnJVRGc0L3lwOHpYa1dMSkZB?= =?utf-8?B?bVF2M1l6c200VDlsbWhqbk9OS0JhR1FTZmpHOWZ2ZUNxbW5Vb2R1NC9iaDZS?= =?utf-8?B?cmZjZkdtOGJPaU1mdW9PQ1VJYlEwTFhiRlFKb2UxZ1RoaEhUMzduQmRuMWR4?= =?utf-8?B?K3JiVDFSMVJFSE9BQmpTZFI2Z2FGbjBDTzlQL0E4czlGMVVKRlduTVZ6ODB0?= =?utf-8?B?SkFKUlBhN09RRlpDM2ZXUm5tdlF5SERDWkF2Syt2Mm9LS0QwWmViQTFIeTVx?= =?utf-8?B?UmY5NXp6VElHK3FwelhXMU9RWDhLaUNRdkkyWkhTdzJRK0pNNERYMzhMNXVu?= =?utf-8?B?WlQ0RUpiRnVJU2diUUZvRi9OOG9Ba3RpVTI4bUsrWkNTVmd6UGFDQXJ4RmdQ?= =?utf-8?B?Wm1ZYWVpSmpnM3Fpc29UNUZlYm45aWlBZFJ5QkN4eXRqcVpqWDJnMEQ1cTMw?= =?utf-8?B?M2lmN3h4MkQvT0FpcVJkTmpWUm5sS3F5VFIrc0FhUmd0MnRzaUxyeWRSWVlJ?= =?utf-8?B?VWtmZTVtdENwVXhWUkJSNzk1MHRULytHelJPWFJMY1JvWEdGTlVWeEVnZitX?= =?utf-8?B?VXRlZ1dLdkwzUnYrNmx4Y1pPOG5uUUM1WXFUTnM5TnkyeWU0UDMxVGNqTGlL?= =?utf-8?Q?OIA0Fx3944voT5n8YT5fDlTEG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f029e9d0-86b5-47db-4edf-08db1413902c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:57:26.0845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iA6g9IilP9nOEEXxPrj47+nMPz5fm5aS0ikBlJSy05RIDp7eIlYadCpyHTtmb5uW8ARIpXKc4Y0YAQl/IRCQ8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8006 On 15.02.2023 16:38, Sergey Dyasli wrote: > The original issue has been reported on AMD Bulldozer-based CPUs where > ucode loading loses the LWP feature bit in order to gain the IBPB bit. > LWP disabling is per-SMT/CMT core modification and needs to happen on > each sibling thread despite the shared microcode engine. Otherwise, > logical CPUs will end up with different cpuid capabilities. > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216211 > > Guests running under Xen happen to be not affected because of levelling > logic for the feature masking/override MSRs which causes the LWP bit to > fall out and hides the issue. The latest recommendation from AMD, after > discussing this bug, is to load ucode on every logical CPU. > > In Linux kernel this issue has been addressed by e7ad18d1169c > ("x86/microcode/AMD: Apply the patch early on every logical thread"). > Follow the same approach in Xen. > > Introduce SAME_UCODE match result and use it for early AMD ucode > loading. Take this opportunity and move opt_ucode_allow_same out of > compare_revisions() to the relevant callers and also modify the warning > message based on it. Intel's side of things is modified for consistency > but provides no functional change. > > Signed-off-by: Sergey Dyasli Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Feb 21 14:04:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 14:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498962.769934 (Exim 4.92) (envelope-from ) id 1pUTFE-0005vJ-No; Tue, 21 Feb 2023 14:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498962.769934; Tue, 21 Feb 2023 14:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTFE-0005vC-LA; Tue, 21 Feb 2023 14:03:48 +0000 Received: by outflank-mailman (input) for mailman id 498962; Tue, 21 Feb 2023 14:03:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTFD-0005v6-7N for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 14:03:47 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0616.outbound.protection.outlook.com [2a01:111:f400:fe0c::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e83d589-b1f0-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 15:03:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8819.eurprd04.prod.outlook.com (2603:10a6:20b:42e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 14:03:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e138:4fc3:705c:d178%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 14:03:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e83d589-b1f0-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GslxS+YPckaCdg9KtV27AF+/uI6jh/d+rdfPJa0FEEpXDfocSbkezTXxtV9G5OhI6PgIkqr3pp/ooPZ9Y5TiUyMvGjkb6te6Z5lfh/YxtMSldm/OLRCaprppZrcvKMewKi9r/oR+8AU6woFCzMGd57/2fDwm2DW6KLOVI9av8XeHSEJi4GlgC+mr1DmIANv976vE4RVVARePl5KopHmAuKHhhF15YOB16cC3RVEdxQWgvAYZLKFh5+T5uXQz7lC76QBt6nVTGKUaop6zyyMDzL0PZlyQcYGgrrZpOMyDSY5K+/6jvqUS8v1nJrCFjTlSkfbdc6dvtoWIczzi/vlnug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eFs7A2VAug61hvU98LDtRRrgTXr58yHOjvk5+u07sK8=; b=ZO7P6WCdoK1JSF0oHeLoKdlaSiL7ZU2/rgnePcGNPzgbYvBOj27rEJNpnwT9/Dlwuf02s219uoA5mm4q2S039iIIr06TKjxMNwxss/3JcuixVCoDxP9ViIffrwsKaTBARedqirTUj8LBpUcAq3wp4gwYBz7Iweq3mjA659bfAZ5xzn4KWjIRGIML0r3uyHO0wPNzll1c9HPCfJ2wCgsBTVxeRX/YBh7lYewlgXdibQZXCL/GR1RTi8vC9+cIoaktJ12UjxmU6auzmhZNicvIx5NH99MRz4RXOHlU8Zy/vwrtCt+t6mHrN/XwQZ+iE2S91SwRNlk+tQUjip+GQ/wPUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eFs7A2VAug61hvU98LDtRRrgTXr58yHOjvk5+u07sK8=; b=1HCfekApL7lwj5licpRkqTVH4DRDopzzXh69sozDjM6QnvVN7WTGbegT3mTw3apB3Vo9TyrvfcuWYWqEYoSe3MwZGovv/GoTP+ZEDsmD7NOLmLLYDrY+jPHLPwa8zq7NqCVkcETyJzSLEBPLpjcOHsQhAKk3skVUzYgh36TvQWukAfy6kLzr3zwUGtyIiykq/aNl9DpPF27QPxHycSWT9El0dwBdpSfZRdKWxbBBikNv7sHKaWH23OuR/O8TwpfZzOy9P8suegbaw2hZU2rjTLsuGbTdVoyT6pyCc+jvY9X+SYfTlFAiKqcuD2f7S7nbVPJ0ULUXottkCJG0wGQlzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 21 Feb 2023 15:03:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Sergey Dyasli , xen-devel@lists.xenproject.org References: <20230215153846.18582-1-sergey.dyasli@citrix.com> <20230215153846.18582-3-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230215153846.18582-3-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8819:EE_ X-MS-Office365-Filtering-Correlation-Id: bd103c45-be2f-4096-c4a4-08db1414715c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TpNuli0wjqGPALt1C7+EqFuaETFj5z6OpzGxwGyseAZC3uZsrWleHIY0lN5hmpXJVqzRrWuPq60pMkbWiEvUj34G+NVnzrSPWaMZ+j4pPkwCeJ+/bXD/JundDRXlmvYpakR2QWuz9ZfiDBRsZZNf1c4pK/r0v8RzWVI7hW90yWvzyQUWZhg5633aADM6gJaHL+XynIpScJptog/8tqyecVufQuKMp9jvT1D8kCr0vcGjCi0B/JeNgB09Wr5oGQnYtFEGmHjGNG8D9n+JgKjTZxVwG71m6kE5cXvSeUhzwJXow+LLH7E/NExm2P3SPmYUUeuQezc9YtjU4vO6kSziYVdm5tnFQtuG1CE7XDpkF8a/i3O5PXAZ+zMZEvJap+YBMTEX79prm+4iZ2TW27ZylWKkHOw690fON4M+X+8RvLBhBPEh/2CoI1DgcUodNAsMqxAOzZLG36GVQn9aS1O60hi1julCye4aD+DIbkGLVQ7vgirfJTrc11rJ7uc2ZDYAzFR8EtBpW206JOfk9di7gGtuOBYJKZrjSwE+wGb7/6mAzmGMc+b/UrPpOIeVU9G8p+QyGKnSKTee6o/heU3PABOVKBFP5nIwvfmVGQR6+jzBqbEqHTrguf1N60vbAnIgD9Ti7vxXQpBM+gxsExLe4M41W3ZjAZwijMFYOkFHQ+rau7S6ZCNhMbrhfYaNVl2au4rWz1h0dlkWfHQcwopnrExPIL8SOAoHil9cfmnaIsw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199018)(38100700002)(31696002)(86362001)(36756003)(8936002)(2906002)(41300700001)(5660300002)(53546011)(6512007)(26005)(186003)(6506007)(2616005)(316002)(4326008)(6916009)(66556008)(6486002)(66946007)(8676002)(66476007)(54906003)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d010VWtTemh3bDliYmwrVWZva3MxZDRMYW80NGdESU5SbWZGNHU3bkh3Wlhx?= =?utf-8?B?Q3lWUWNXcmJZZ3dadHpVc25jMDBTOFlpMkttTGxJUDNaQjhGak5PajU2MURI?= =?utf-8?B?UE1XbzZTcXhyY0NiOFowc1dGY3hadFU0b0YxZW45bisvUitZRys4cmxQUU44?= =?utf-8?B?UHR6cndwbmFIUEljUUtoZTA0Yy9PbjdaL1l5cE02L3VMc1VKUm5FazI2TG1L?= =?utf-8?B?ZUxhWnIyeExNaGZnUXZjVGdrcDk1T1ZkUkpZakMwWDh3ckJMYUVTWFozaFBn?= =?utf-8?B?OHVHeE00MzBRYmFOQThqUmhVMVYzZS9qalc5alhWdWRjNjZISWVoSEUvSk1T?= =?utf-8?B?V1ZwMkwrV2xiTjlON1NaV1BiS1haYTdSVmtheVp1bVVwaHcxYjlwc0gzeFph?= =?utf-8?B?c012dm1wakdWM092SGcxalFpQ3MrN1FuMFJPUmE4M2t6cjM2SDdHSldOamFO?= =?utf-8?B?eVJERHlDeVpOaEJ4blBMRldzc2dDMVJSRVI3YVdIV0JlZWpOamZGZ3phWlh4?= =?utf-8?B?WGVFZVNnUSs4Zk94Q2EwRmUrYXlNbFd2dzdZeXpFMExoVG1sczVrWkZmWlQ0?= =?utf-8?B?Rm1Fc3NPb3R5L1BZTEZxREJZVXVaSzN3KzZ0SzVyZmJTUmF5ZmYydHY0M3Nh?= =?utf-8?B?M2ZIUlpDQzlHaklzSDZTU2FPRTRwNHRrY1dmOWhpWWMzbVpUT2pEdmZ4cnpl?= =?utf-8?B?U3pQbTRnMWwyYmNEaEU1THFnUU1lQWdnckZBbjFiL1EzR1dMeTJUTFExTmdw?= =?utf-8?B?aDFuNWFmNEhMOGM1WFBJZjlLdW44NjlGMjBYejRkS0xhTDhYd3Vuby80Z1Qy?= =?utf-8?B?dEN1eldmZEpTTHdHeXp2aEthSGE0cU9ScDRBNGlZSW5hSzJXWUU0YXZaL3B3?= =?utf-8?B?bDBsNmJSMmZKVVdqbmdvTmpjQmxwbVFHZ3ZpYzFleHFSdVBBemNvRHVwZTFU?= =?utf-8?B?RnBWMmdqQVk2Vy9pQkZwOXVoWFkvRVZQVkJZbzZKaUxBZWtOYzJlRXY0aVNQ?= =?utf-8?B?cCtOYU9xaDZkM01pbEZobEVxTjdTT3FCVlRTK2JwM1FoTWJSZVVFTm5kY1BP?= =?utf-8?B?K2l2dTRGWnVQcm9MT0FXQTJVQXQ5ZEIyOGdWK1k5UzBUcSttSXVZUk50OGIr?= =?utf-8?B?V0ZaNjFXMEx4QkpXbGw2WVByelloK3d5V1lWZUZiZUgvejlsQ0NRZDJ2U1N2?= =?utf-8?B?eUlTQ3RSS25scDQ2cThiOENvSDIzaEtGbHhjZklxWkFOYnZialBLWUloYXlz?= =?utf-8?B?N3hwODM1UlJSRzBwdDhNNjFSeEVSMUJQeElhZkpJSTlCRHVudzh2V2dydXBu?= =?utf-8?B?N0NLMjhhQmJFS1AzZFZaVytWQkZaMGNYcDhkQzQ4azlWRWp0R2NLVVJVT2I3?= =?utf-8?B?bXRCelJwTkFmUHFaaXFjekRRUWhTdzUxZzFBaVQ3RUZKTDJZK3ROQjQxbk9a?= =?utf-8?B?WmJBdHZqTHJ1Qm94RkJ4L1ZKci9oMGRjUjd4bEJnaGxWTytCN3pVaDJTdzEx?= =?utf-8?B?QXRReElHQ0tVVEhhVmpsd0FGS3d1RUJUQ09IRjNqdHl6MUt4RWdEU25sNFg4?= =?utf-8?B?bWRqR0k1WTd5b3JzTXZxZFBleTZ1aXBaZmZnSS9nTzBsRVFkMEFOVUlIYzNs?= =?utf-8?B?OExMVHpNTHFndDJFbjdQU0x3SEl0Z0pVY3d3MWllcXpHVlltaEluSHNOUG5Z?= =?utf-8?B?MU5NZ1ZhbXpuWXorN05za05CTUR3Rm1rYW50QlRvRzFLbUllUkRXVWtZajlm?= =?utf-8?B?MzZmWk1QdUFZTVd5TUFyZmkyaWlVRXRyUWQwUjhzN2lkRUJoa2NUZkdRTC9v?= =?utf-8?B?T0JkMXV5bjRKUVJxQVk1dWt1MENrQXNFbTExNDlOT0FrUlBBRy9ZeTVlQVJK?= =?utf-8?B?NDRPRGhhbjRjNm1jT1dPdVJYOEFyOUxCVUIzbldaeVIrU2Jtd0ZGY1E4Ujk2?= =?utf-8?B?S080YW95dzdlc0V1MGgzR0lxcTVITS9YVmhoYTJLRXNDc3AwMHkrL0Jja3hm?= =?utf-8?B?YktHY3F0VnlHNEkyVEZBUkIyaUxFZS9VWis3dThiNTBicTdma0txdTBiY2Jm?= =?utf-8?B?ZHVSSXNLdkJsbVJ2TmhBcDJmdGRkcjBHN09TODVUYnI1WmhraVVqQ2k5a2Vl?= =?utf-8?Q?Iy6gRIbBYzwz+2xBaO0lWnfDN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd103c45-be2f-4096-c4a4-08db1414715c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 14:03:43.8113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ivE6WPleuv8ESaShsj0/PEJwqff8NXxctCCRzGet+FWHHL6RxhyH3Kcjf6CQKURvfDG+yM5+dCR4LOxmmGF9dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8819 On 15.02.2023 16:38, Sergey Dyasli wrote: > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( > (!ucode_in_nmi && cpu == primary) ) > return 0; > > - if ( cpu == primary ) > + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) Given their origin, I'm pretty certain Hygon wants treating the same here and below. > + /* load ucode on every logical thread/core */ > ret = primary_thread_work(nmi_patch); > else > - ret = secondary_nmi_work(); > + { > + if ( cpu == primary ) > + ret = primary_thread_work(nmi_patch); > + else > + ret = secondary_nmi_work(); > + } May I ask to get away with less code churn and less overall indentation? Already if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) /* load ucode on every logical thread/core */ ret = primary_thread_work(nmi_patch); else if ( cpu == primary ) ret = primary_thread_work(nmi_patch); else ret = secondary_nmi_work(); would be shorter, but I don't see anything wrong with simply going with if ( cpu == primary || /* Load ucode on every logical thread/core: */ (boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON) ) ret = primary_thread_work(nmi_patch); else ret = secondary_nmi_work(); Same again further down, I believe. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 21 14:15:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 14:15:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498970.769945 (Exim 4.92) (envelope-from ) id 1pUTQ1-0007kr-OU; Tue, 21 Feb 2023 14:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498970.769945; Tue, 21 Feb 2023 14:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTQ1-0007kk-KQ; Tue, 21 Feb 2023 14:14:57 +0000 Received: by outflank-mailman (input) for mailman id 498970; Tue, 21 Feb 2023 14:14:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTPz-0007ke-S2 for xen-devel@lists.xen.org; Tue, 21 Feb 2023 14:14:55 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19c92644-b1f2-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 15:14:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19c92644-b1f2-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676988891; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pFo4aVLkOcxmiWbJUtshp9TPp+36939f/k5lOtsAwZk=; b=eZ4pjHPk3sR7laYnCPWdb30xQGmlKPEsLD7OW+qB3RMUwGukFtlUJqo2 7L74UXr6z91dS7Eor8pGmOU9Z2yS5e60LJywN4Fs3kb2xMomaC6Fmei/4 yhgkTcXv+Uzpcv7W7mfmtz9pvGSflgiNZZFTRz8Z7/WGtJXzaiFwL4LFm o=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 100318756 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:rqejVK37AVGWF/O8PfbD5dNxkn2cJEfYwER7XKvMYLTBsI5bp2EAn WEeUW+GPq3fZGbyeYx1Yd7g/E0D68eBxtVrSgVlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXXNj/ voIIgo2bw3Sgfyr/LCZSMxQr5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tP2vnWK5dzRXpUiKrK4zy2PS0BZwwP7mN9+9ltmiHJ0NxR/I+ T+Yl4j/KiA7aIWAlAqJyXCLi9fjgSfcUa5LFKLto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8gqsVNaVdx6/pmSNslgDWt5TO+og4QqJx+zf5APxO4QfZmcfMpp87pZwHGF0k AbTxLsFGACDrpXJW1+W8KeelwizJHkTM3I+Zw0GaDcstoyLTJ4IsjrDSdNqEaiQh9LzGC3tz z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNtFsRWWKzW2C/BbE3B95kJZ3RcFSOt WNsdyO2vLFXVsHleMBgrYww8FCVCxStamC0bb1HRcNJG9GRF5mLJNk43d2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa/S4W8BqiEMYMVOvCdkTNrGwk0OCatM53FyhBwwcnTx 7/GGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlnyaPU6lTCfNE98taQLeBt3VGYvY+G05B f4DbZrVo/ieOcWiChTqHXk7cwlRdydiW8yrwyGVH8baSjdb9KgaI6e56dscl0ZNw8y5Ss+gE qmBZ3Jl IronPort-HdrOrdr: A9a23:Hfu0M6khvru06LbsIh6sMiFp1qLpDfIJ3DAbv31ZSRFFG/Fw9v rPoB1/73TJYVkqNk3I9erwXZVoIkmyyXcW2+gs1N6ZNWGN1QeVxedZnPLfKlXbakrDH8FmpM VdmsNFebnN5DZB/LzHyTj9P9E8wMSWtICE7N2uskuEBmlRGsddBnxCe2Wm+5RNNXF77EwCZe Gh2vY= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="100318756" From: Ross Lagerwall To: CC: Konrad Rzeszutek Wilk , Andrew Cooper , Ross Lagerwall Subject: [PATCH] livepatch-build: Check compiler version matches Date: Tue, 21 Feb 2023 14:14:32 +0000 Message-ID: <20230221141432.972145-1-ross.lagerwall@citrix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain For reliable live patch generation, the compiler version used should match the original binary. Check that this is the case and add a --skip-compiler-check option to override this. Signed-off-by: Ross Lagerwall --- livepatch-build | 54 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/livepatch-build b/livepatch-build index 91d203b..e4b4dba 100755 --- a/livepatch-build +++ b/livepatch-build @@ -33,6 +33,7 @@ DEPENDS= XEN_DEPENDS= PRELINK= STRIP=0 +SKIP_COMPILER_CHECK=0 XENSYMS=xen-syms warn() { @@ -266,27 +267,44 @@ function create_patch() objcopy --set-section-flags .livepatch.xen_depends=alloc,readonly "${PATCHNAME}.livepatch" } +check_compiler() { + orig_ver=$(readelf -p .comment "$XENSYMS" | grep -o 'GCC.*') + + in_file=$(mktemp --suffix=.c) + out_file=$(mktemp --suffix=.o) + echo 'int main(void) {}' > "$in_file" + gcc -c -o "$out_file" "$in_file" + new_ver=$(readelf -p .comment "$out_file" | grep -o 'GCC.*') + + rm -f "$infile" "$outfile" + + if [ "$orig_ver" != "$new_ver" ]; then + die "Mismatched compiler version: Original \"$orig_ver\" New \"$new_ver\"" + fi +} + usage() { echo "usage: $(basename $0) [options]" >&2 - echo " -h, --help Show this help message" >&2 - echo " -s, --srcdir Xen source directory" >&2 - echo " -p, --patch Patch file" >&2 - echo " -c, --config .config file" >&2 - echo " -o, --output Output directory" >&2 - echo " -j, --cpus Number of CPUs to use" >&2 - echo " -k, --skip Skip build or diff phase" >&2 - echo " -d, --debug Enable debug logging" >&2 - echo " --xen-debug Build debug Xen (if your .config does not have the options)" >&2 - echo " --xen-syms Build against a xen-syms" >&2 - echo " --depends Required build-id" >&2 - echo " --xen-depends Required Xen build-id" >&2 - echo " --prelink Prelink" >&2 - echo " --strip Remove all symbols that are not needed for relocation processing." >&2 + echo " -h, --help Show this help message" >&2 + echo " -s, --srcdir Xen source directory" >&2 + echo " -p, --patch Patch file" >&2 + echo " -c, --config .config file" >&2 + echo " -o, --output Output directory" >&2 + echo " -j, --cpus Number of CPUs to use" >&2 + echo " -k, --skip Skip build or diff phase" >&2 + echo " -d, --debug Enable debug logging" >&2 + echo " --xen-debug Build debug Xen (if your .config does not have the options)" >&2 + echo " --xen-syms Build against a xen-syms" >&2 + echo " --depends Required build-id" >&2 + echo " --xen-depends Required Xen build-id" >&2 + echo " --prelink Prelink" >&2 + echo " --strip Remove all symbols that are not needed for relocation processing." >&2 + echo " --skip-compiler-check Skip compiler version check." >&2 } find_tools || die "can't find supporting tools" -options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,xen-depends:,prelink,strip" -- "$@") || die "getopt failed" +options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,xen-depends:,prelink,strip,skip-compiler-check" -- "$@") || die "getopt failed" eval set -- "$options" @@ -358,6 +376,10 @@ while [[ $# -gt 0 ]]; do STRIP=1 shift ;; + --skip-compiler-check) + SKIP_COMPILER_CHECK=1 + shift + ;; --) shift break @@ -383,6 +405,8 @@ OUTPUT="$(readlink -m -- "$outputarg")" [ -f "${PATCHFILE}" ] || die "Patchfile does not exist" [ -f "${CONFIGFILE}" ] || die ".config does not exist" +[ -f "$XENSYMS" ] && [ "$SKIP_COMPILER_CHECK" -eq 0 ] && check_compiler + PATCHNAME=$(make_patch_name "${PATCHFILE}") echo "Building LivePatch patch: ${PATCHNAME}" -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 21 14:16:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 14:16:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498976.769955 (Exim 4.92) (envelope-from ) id 1pUTRj-0008Kw-1d; Tue, 21 Feb 2023 14:16:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498976.769955; Tue, 21 Feb 2023 14:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTRi-0008Ko-VE; Tue, 21 Feb 2023 14:16:42 +0000 Received: by outflank-mailman (input) for mailman id 498976; Tue, 21 Feb 2023 14:16:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTRi-0008Kf-Kw; Tue, 21 Feb 2023 14:16:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTRi-0003Bh-Jt; Tue, 21 Feb 2023 14:16:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTRi-0002Vs-9A; Tue, 21 Feb 2023 14:16:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUTRi-0005EU-8i; Tue, 21 Feb 2023 14:16:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ELZJpGGP30sJklcAL6sZPg6GmxI124exoiCP5a4ipnY=; b=OUYXvDqWkunP3YneUDzxEum2uw 8Vw8uLSKEE73ihGIInoRNpM0Zz3jrKWOn1RwRXgV0vGp4h6Ju6s8eJJ36g3IQL71AJKhqk7Bky+0z Zczd4Do4KOuui2aKrdN4ECfhkYnRJOGRbz1dyIteQjNl7j6M/1gQ5100FWamxy3v9was=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178016: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a90a0018f605e3bb0588816e5a1f957d6e4562eb X-Osstest-Versions-That: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac From: osstest service owner Date: Tue, 21 Feb 2023 14:16:42 +0000 flight 178016 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178016/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a90a0018f605e3bb0588816e5a1f957d6e4562eb baseline version: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac Last test of basis 177843 2023-02-19 19:00:26 Z 1 days Testing same since 178016 2023-02-21 12:03:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 406cea1970..a90a0018f6 a90a0018f605e3bb0588816e5a1f957d6e4562eb -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 21 14:38:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 14:38:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.498986.769967 (Exim 4.92) (envelope-from ) id 1pUTmd-00036a-Qm; Tue, 21 Feb 2023 14:38:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 498986.769967; Tue, 21 Feb 2023 14:38:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTmd-00036T-Ns; Tue, 21 Feb 2023 14:38:19 +0000 Received: by outflank-mailman (input) for mailman id 498986; Tue, 21 Feb 2023 14:38:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUTmb-00036N-UR for xen-devel@lists.xen.org; Tue, 21 Feb 2023 14:38:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e536bba-b1f5-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 15:38:14 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 09:38:07 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB5994.namprd03.prod.outlook.com (2603:10b6:408:133::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.18; Tue, 21 Feb 2023 14:38:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 14:38:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e536bba-b1f5-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676990294; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=85UKRV/t07Qf+ryceesESGNmRFwd8iiQWpiMyg5bjXo=; b=H+1GnWVU0+5IHQh23SVx0+hoco3vaCV7oCK9SRyGK8vjC0e+KGGV7LEj X4mKuX038llAqIIZsOzCzP9B6dejP//prccp10EnlpcnihFbwTVnnxCII LKhtCSWxaGgDcI+xJCuXYjF9PsySqc6L3c0GWvjEmjP5Xj8q3to5bEmeD s=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 97290956 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BRmwFqszUX36/aw4HfjBvwp5IefnVEpfMUV32f8akzHdYApBsoF/q tZmKW3TOPeNZWGjfNknOtjn90NTucSAmoNhQAFo+yk0FCIS+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEziFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwIgIHNxmbxMmKn7uRa+tUgu09Bc/FFdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4W9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOznrK8y0QDNroAVICU6Xl25quGLtmm/Sc5yN Q8Z9RU2sJFnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAC4DVDEpQN8hstU/SXo11 1uKt9TzDDdrvfueTnf1y1uPhTa7OCxQIWpcYyYBFFEB+4O6/951iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:nF21JK/9E18FseMR90puk+AFI+orL9Y04lQ7vn2ZESYlC/Bxl6 iV/cjzpiWE8Ar5OUtQ5exoXZPqfZqyz+8R3WB8B9iftUzdyQ2VxeJZnPTfKl/baknDH4dmvM 8LHsRD4Z/LfD9HZK3BgDVQZuxQouVvh5rY5ts2oU0Ccem3A5sQkTuRQTzraXGeDDM2f6bROq Dsm/Z6mw== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97290956" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/IwsBjryVHW3GywvHXfLgKbj15XvQHUW1f2u6AnBeu8HOJQ8nk59PpjNOHkmWF05WwCvsKKW9UrlWOr3KrOmabPS/3oHD9doGPMGhOok4VZXaB/vIZ8Lcno6QX8U5ah6qnzLmLsTlWaWgY2H5eyeuvGyfpAApGz5HjJtTQoRF6cnsXaWsmgCxZtKOeqeU8f8JBGUfBDpStXKfDD5tWQW+FaZk0MNi2Euxm0xxwtrRFl1qAb3X4ExDBRohIS0iv+yi497gi8csYXBh0se/Gy22eFIUIottYrgVH0PfzijL6v9+cWbSZdAw94tzqG5H6BlWIAzuGyUSWY9pW2DKLUBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MM37u8V4czHa6d+O9uK5G9EuKa9HzrnjqRj5yHHjEnM=; b=GReWcgknXAMHu+1s1Gbn1i9+dgdVFQyh4ElE17hKwwRJbcn5Jb52ZfzdoR2ImZANYiDiDko6YrNVv+HiP0+NBOv8FGbZA1nIQqQLmli4e5rGZZLgkTAtXCNAe9Fx/F+78iKgeBR/6oM/7najR3IUp2OOcQ1BNpmdKHx/c9NmitWUuD21FPs12+kW7oi48ji/S05hJaccO/khnWGV1V1wk6d3jRZ8OFh6p6GF4pVkLPAjMZ5F15KorQZA3/ppKzvhu7+D3Aq5ct6FErHqj7Ss2/R21yw82MDsfVKvohpLxrQc4ijZezk8bScpG2Yq/LtkZ7mOWIip06rykz7yqlnwqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MM37u8V4czHa6d+O9uK5G9EuKa9HzrnjqRj5yHHjEnM=; b=ds1WgoSp/uGMu2JqShOoDzM4fXXZlrpj9cEGtQBQ7QP8py3qR6QXh2Zvh34E0dhCkvdj1iJT56MhP0DQ6YzWTP86om8ukTdM8UZW/yp65rMAKHa8qu/AYW378eqh2vPBZ4lXB3VVUhmwRtgA+3E0III1sel9GAM3uJfVPW165iM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <41113fd1-d1bc-df92-ef5f-8e85689c82c2@citrix.com> Date: Tue, 21 Feb 2023 14:37:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] livepatch-build: Check compiler version matches Content-Language: en-GB To: Ross Lagerwall , xen-devel@lists.xen.org Cc: Konrad Rzeszutek Wilk References: <20230221141432.972145-1-ross.lagerwall@citrix.com> In-Reply-To: <20230221141432.972145-1-ross.lagerwall@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB5994:EE_ X-MS-Office365-Filtering-Correlation-Id: fa09873c-2e77-479d-1c4c-08db14193dde X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 308KyWHubkHYO27O0xwKienuWy2oXS6ic8/dQ0OwGa+Q0FvxTrAoWFe67bzC+vgIvd/qTaUPNPFDqufmIdDWewoVWviKL8rYJjftrSruSHC57n1SmKYnP5t6sf71LPhuPb/PI4d+KFNPfAlQsmiH7kPMB/DAZQLRSgpl7AC7+Po/G3lChZQvNNWUAOERnOLMeleSi6Oe6zRxz7pPozJHszeiqCJC4BdmAvfWjEzEqiTLeJ6btw3/zw1FjAUkIOuHSYCnucj0DWWofBRb+N+dqaLjdEJ4zwwAYBJUZ0id3qCfWsAjdZp8HjEUTy2D6o13P1VoPN4+v02Y6DhiEbZpyF+aKv0aFzWzZxe+Goz7VKqbyfCn08wzQSYQZgKhkKgg16fxIbGTOepgyjuSQgjgmByW51mybER07HKJkB0iOqC2RuNnBoUqKA438U67PBUSdbLLB0jMiLK0xduVpkredvuo7HP/LUxYXUkcbOt/iTKcuj6cL11tiC7yTUZSpQwWeLNLKlxovP7vD9iixsjZ9ISvSsjK4rq15xYMQZtZCI7B0/42ZAH8hneMjk2GfAvThfEIfbPcoOVXklznpZjRN5bSrFSq3O3QcQCkJnQblFy591l/aZiusE0irZfnvurzlAnvEI9zPBMcUfpAabjmxvfYqlP0HTFp6YZfhSLDJqcw7jZgiINpBN8/CqimXHaFYVk58ifjk1oWkMnrwAGUQKQ6O7OeTfr93rU5m0rLLOU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199018)(186003)(26005)(31686004)(38100700002)(4326008)(6486002)(8936002)(53546011)(6512007)(6506007)(5660300002)(2616005)(83380400001)(6666004)(36756003)(478600001)(41300700001)(82960400001)(8676002)(66476007)(66556008)(66946007)(2906002)(86362001)(316002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TitlSjVkc0d3d1pFT3FLaGVUZlRDZ2czc1NzaTY4TXE3SVYrUkw3U2txL2Mx?= =?utf-8?B?VHpaUXZKaEVuTE0vRG9LanZwM0hkM2VDbzR5TVJUc2UvYzRsTXdRMktjTlBr?= =?utf-8?B?Y1FPVTFVbEw2UDNoclExY28xRFFmb0QwOVd2ODlyaDNKMlZTUzlNZnFKT0Z4?= =?utf-8?B?WWNuUUsraGRaaGpSRHBBazNva240VlZGaUVFUVJiU3IyVDJtSkhQY0NiR3p3?= =?utf-8?B?UUptRGVSV09QRC9BZ2wvT3pFNWtHNnJKK2cyVlNTUGpoYlJvdlZxZ1dEc1d4?= =?utf-8?B?NGxkTTd0UkFYOW95SVR1Z3BKTXhjSEdpbHp4UXR1MHhOVWQyaUFnZmZXWnAw?= =?utf-8?B?bFozVjNJaEgrN2p2RU9NdkRhU1Q5UElwcWpuRFdCblE3NU9ISjFackdyVUll?= =?utf-8?B?Y2NBM3gwcUlxc3ZVSU1vUHpLWFVMQXFKUDZTVktDOG5BRlJRV0N6OHpKd1JD?= =?utf-8?B?ZUFBWTBYeW1LNlNHbGdnM0lNNkMzU0liK0piazlnVU0xN2ZaUHJkaDhZTWhH?= =?utf-8?B?UnJJcEFyd1FTNFBjTXM5cUtJeDlKT2QxbnpuL0hBUENwOUNESEhjS21jd09B?= =?utf-8?B?elNoRVBIdFFnZ1NvV1lsOVNzZFRocFlMUzFtR2dzdGtlZ3NSd0E2MnBhNEpJ?= =?utf-8?B?VERqd1hjWFNjNS9zc1Zia3FKN3dUQVE2R1dHeVZlM21vN2RTMXFwaU02RzY3?= =?utf-8?B?UEhmYUFqSDFheEhGNi9rdDV1S1hLUkJ2cnF0ZUFNTEJZQjRFeUlyMW14Rk1v?= =?utf-8?B?VVlFMmh4d3pWTjV5a1VLRW0wejU3SnZ3amppa1N5L0Q5R2J5bjZPc00zRkFW?= =?utf-8?B?OCtKaktoREtxeFhrVVhxbXMwZldhVjJPSjNwSkFKdWZNSWUzdVF2NWRzdkZy?= =?utf-8?B?emh4dEFOUEZ5YUgzSmxGTytRelh0UlFSWWwwUGV1K21udGU0T2wwOXJtSW5Y?= =?utf-8?B?cmE0dk1RejBGL0duSFVBNFh0SXdYTEN3SEdKOWxITE1ZWWgvdWxRMXArbUNH?= =?utf-8?B?YTV3L1lsS2J6QXRocTNsTENpYW1uWkRBc3MzamZHYStNWk1PczRnUERkaHlJ?= =?utf-8?B?U2pHeGFQYnpoMHRqeTJXR3ZGUWZSc2hlUTN4bDhZWkZoNHNEZ2pENlp2anJB?= =?utf-8?B?bHplNzBIQ2ZBN0xhVjFUbXMvYkx6bFBqNzcrQ1h4ZC9iNEkrbWNWVkp0MThz?= =?utf-8?B?cFpQTFFGM0tacWFkSEpMQk9rWmg0bFFwQnpZb3hIZ1grdHR4UnNER1ZnbnZk?= =?utf-8?B?T3hCSUJDZWQwMk52dU84NG1Telh4amRiNHJrTHJrNU1qelVlekpab2kyOWcw?= =?utf-8?B?VS9RaXFmemx1T04wS0l1WW1BcGVLNkZEQkF0Z08xTUFzYWdpbmk2MXJBa0Q0?= =?utf-8?B?SXZ5eUw0a0hsSG1TWkNoYmdWZDZNeFByOFZlaGtaOC9ITHhueDNZSm5xQzk1?= =?utf-8?B?OTMyQjMyMWZKekg1VmVmczFsMy9KRjVRZldaY2ZnWWxXWlNtdDR4dkh2akxZ?= =?utf-8?B?UGhwRVdOZlFvQTZVblE5dk5UNDREa3hyKzh4cUhFekszbCttR0l0SFRrWTl3?= =?utf-8?B?Z2FGUFYzc2drbHNCSzRMSGIxaEN4dmZkcFI2RFpJY2JHUFpPRlYvNUdzZ0RK?= =?utf-8?B?T3lxbzUxSHc3WXpqaktwZzZpeDVvc3Fob3hjcFdGdlcwTTNzN3V0VDdrL25z?= =?utf-8?B?anRFZGErS3lsUFhzaUVEWjcvRWN0LzlTTWVXOXpnQ1hIZ0ltZWEzWFhpdXdl?= =?utf-8?B?Q0xyM2FKd05TQXN5aE9JL3c2MXJBclBWVnpBcXhFTXMyZmt4dVk2cUNCd3g1?= =?utf-8?B?QS83U2xka0JORW1xVDUwL0JKaUNDM0M3NHJhLzBnQzVUT01GcTVEZmxjU0Vl?= =?utf-8?B?Yy9IUm1XMk01NVEvekgzOVBlc3hEUjJpQ2RIdnNrU3d4NExrRHRjS0hDQWYr?= =?utf-8?B?SWpxK3h3dVFKM3FNSk5IdVpnSEJqUU8xTENlR05Wb1p5b3VZdlRLT1NDemZj?= =?utf-8?B?NG51OFYya3RqUjFWYnAxWW5QclBTeGVkNStTcXRjZ2RvZGxFY3kyWXNCdkUz?= =?utf-8?B?dlgvcHI1aWRvWThYaEcwemgwdUVSNkNQaWtqYW5DMkRXQnY1QmJtZWNCSHdp?= =?utf-8?B?WEJ3SmxLcjdWMkVOb3NDZTlPc0taRFhGNFFjQk9NNFN1Ri9YajhMOGtZTThk?= =?utf-8?B?K3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: V0+4rSY7CrYPTfz925MhFK0A0K3Do3ANwe+By4E8cTmE/OayJKmbfon0oT3i7uK6cm1WlJZed004UAQNrZ9qvYoyVpwIYwgT+P8tk4TZPTbl8vnFiDy+Gc/k9EUbJc4puBFJhQLG2nPLS0fHfxAJDsIzKrAhhbFQkQNNyNX6wgBd98UR3b1zuxN4lmsDgbtbopXKP7OAaHu1aVSSYSELms8c8S8e/OMctzrftO0obmSN36wDJyw7LbMnsfQQ2z0z0GHxeIVAtchReG43NqVyBXOnnhXjkc+8zJPvzFQFmuHdrLWYK6luNYjxdbWyySgaNNiRpgzBPurexFCdWyDgGsoUrK3D5Gjh6F2/pIOJwlWBGAs8VYSgLjyf9kYjBLDFQFctRM7UQw8gCF2TWyYJLHvW0VUO66nTOekhkmViOwgvwErr5G8dYbokQYWBPQLyAAJ0DV1iGZtWToNjOabx0BQvqRXk1APgKegJYXbSbPcI3moMTTgjGXFXLZwfZuhVEHsHx2iwAUh26cAX5lOvX8b1xnOtvoqMxM4DrnZ6XrKjzpG9iz0VbnIdc+hyYy/s1c+aoU6FNynCR9GUXAvWJADJdHdbZfEeSUVaA75D7w9WmOZDTJOmv8II3c29SXCDZF7GjrkR9mdDUC+ZlJtVZNGMJKt+nvHpqQHq9GprS7VtxYcw2YZLywmm/Jnht8h/v60c6ImkoLxx5QvX36omx5TJfbiy4t3VcCeymu/tA9zLr1owDl1r+xP1ycvoSwpTvYJXQ4DmP8QdfBH/gbttCbqCnNKSngLyde6sKs8qLPQ= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa09873c-2e77-479d-1c4c-08db14193dde X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 14:38:05.0886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fFRlTH1KNk4rUdWStsVaDBDGoJL2qCeB8uBqygZSJy48tpzye6ABkZECdZOCOVm+EPiHRMbteWsiHzTrjP7jYemYHZ3RZf8MzIALKeMdB/M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5994 On 21/02/2023 2:14 pm, Ross Lagerwall wrote: > For reliable live patch generation, the compiler version used should > match the original binary. Check that this is the case and add a > --skip-compiler-check option to override this. > > Signed-off-by: Ross Lagerwall > --- > livepatch-build | 54 +++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 39 insertions(+), 15 deletions(-) > > diff --git a/livepatch-build b/livepatch-build > index 91d203b..e4b4dba 100755 > --- a/livepatch-build > +++ b/livepatch-build > @@ -33,6 +33,7 @@ DEPENDS= > XEN_DEPENDS= > PRELINK= > STRIP=0 > +SKIP_COMPILER_CHECK=0 > XENSYMS=xen-syms > > warn() { > @@ -266,27 +267,44 @@ function create_patch() > objcopy --set-section-flags .livepatch.xen_depends=alloc,readonly "${PATCHNAME}.livepatch" > } > > +check_compiler() { > + orig_ver=$(readelf -p .comment "$XENSYMS" | grep -o 'GCC.*') This rather breaks Clang as a toolchain, but it doesn't seem to be the only GCC-expectation in livepatch build tools. $ readelf -p .comment xen-syms String dump of section '.comment':   [     0]  Debian clang version 11.0.1-2 Irritatingly, while clang* --version always reports itself as "clang version ..." matching the .ident it writes out, gcc* substitutes argv[0] into it's --version.  But the way the Xen build is invoked, I think Xen will always substituent cc for gcc, so this may not be a problem. A build of Xen should only use a single compiler, so I think you're better off looking for s/[     0]  \(.*\)/\1/ rather than assuming that GCC was used. Also, I think you should error out if we can't identify a compiler, because very little good will come from trying to proceed. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499003.769978 (Exim 4.92) (envelope-from ) id 1pUV3r-0006hs-U1; Tue, 21 Feb 2023 16:00:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499003.769978; Tue, 21 Feb 2023 16:00:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUV3r-0006hl-Qv; Tue, 21 Feb 2023 16:00:11 +0000 Received: by outflank-mailman (input) for mailman id 499003; Tue, 21 Feb 2023 16:00:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUV3q-0006hc-NW for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:00:10 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-sth1.inumbo.com (Halon) with UTF8SMTPS id d01e2cb5-b200-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:00:08 +0100 (CET) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by 9d1469203088 with SMTP id 63f4ea86403d4a45c7fb71a4 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Tue, 21 Feb 2023 16:00:06 GMT Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-536c2a1cc07so55136737b3.5 for ; Tue, 21 Feb 2023 08:00:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d01e2cb5-b200-11ed-a089-e9535cc0f9c3 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1676995206; x=1677002406; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=A8FosNzblNVltvtSuxm7lOrbAJOLJey346OrMJVjX3o=; b=ZtoC/fYUH9adJ+pmMBG6Uequau5oeXYHYTKUHZetddIcUu9x7xUi1wlXrtpczpDTLo6OjroXohW7glyuIAZnft8s4v/8BNy3pwoqm9iQXmqn188043bjnz5FegZVvZ215cOATIsI2VuAJzb/JohlAHfSgau/NFzIC5Tpg5iGHt5bAVqL7UmPKq6vfpZQMEAoJgtgtw8bo0UN8rwxd4WB1jpGyMXa3X4uriXuv6qxOm8T68X3szghNeK1mXprhzRkNtdpfSC1XwBm4KGX1eiXk8wDsDLs7fkhUK1VbtairF8MF6ssE7MTy4alSFmMcS/HiNauS2Q7o0yIOciCcr4ulQ== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKX8pSnPvb6ZB2qvLgzbcVE8Pib82gLBNr/wP5vKKXZ1vTixu4Fy HuKitqOxdN5oOjNN/JYWrN2NoENZbs4R23uYXR4= X-Google-Smtp-Source: AK7set8dafSHJWIbgA+Vkkn/dIDjiTpcPdnEhnciLOSnuisnWrygos4O5fjXFvkb4kquohtto+8121aw3cAntcV/Xbk= X-Received: by 2002:a81:72c1:0:b0:525:1590:32ef with SMTP id n184-20020a8172c1000000b00525159032efmr2111911ywc.221.1676995200523; Tue, 21 Feb 2023 08:00:00 -0800 (PST) MIME-Version: 1.0 References: <2692e97d-b3d6-6512-bff7-c13941c10cd4@suse.com> In-Reply-To: <2692e97d-b3d6-6512-bff7-c13941c10cd4@suse.com> From: Tamas K Lengyel Date: Tue, 21 Feb 2023 10:59:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="00000000000037a42b05f537dfba" --00000000000037a42b05f537dfba Content-Type: text/plain; charset="UTF-8" On Tue, Feb 21, 2023 at 8:54 AM Jan Beulich wrote: > > On 15.02.2023 18:07, Tamas K Lengyel wrote: > > An assert failure has been observed in p2m_teardown when performing vm > > forking and then destroying the forked VM (p2m-basic.c:173). The assert > > checks whether the domain's shared pages counter is 0. According to the > > patch that originally added the assert (7bedbbb5c31) the p2m_teardown > > should only happen after mem_sharing already relinquished all shared pages. > > > > In this patch we flip the order in which relinquish ops are called to avoid > > tripping the assert. > > > > Signed-off-by: Tamas K Lengyel > > Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool preemptively") > > Especially considering the backporting requirement I'm disappointed to > find that you haven't extended the description to explain why this > heavier code churn is to be preferred over an adjustment to the offending > assertion. As said in reply to v1 - I'm willing to accept arguments > towards this being better, but I need to know those arguments. The assert change as you proposed is hard to understand and will be thus harder to maintain. Conceptually sharing being torn down makes sense to happen before paging is torn down. Considering that's how it has been before the unfortunate regression I'm fixing here I don't think more justification is needed. The code-churn is minimal anyway. Tamas --00000000000037a42b05f537dfba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 21, 2023 at 8:54 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 15.02.2023 18:07, Tamas K Lengyel wrote:
> > An assert= failure has been observed in p2m_teardown when performing vm
> > = forking and then destroying the forked VM (p2m-basic.c:173). The assert
= > > checks whether the domain's shared pages counter is 0. Accord= ing to the
> > patch that originally added the assert (7bedbbb5c31= ) the p2m_teardown
> > should only happen after mem_sharing alread= y relinquished all shared pages.
> >
> > In this patch we= flip the order in which relinquish ops are called to avoid
> > tr= ipping the assert.
> >
> > Signed-off-by: Tamas K Lengyel= <tamas@tklengyel.com>
= > > Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool p= reemptively")
>
> Especially considering the backporting r= equirement I'm disappointed to
> find that you haven't extend= ed the description to explain why this
> heavier code churn is to be = preferred over an adjustment to the offending
> assertion. As said in= reply to v1 - I'm willing to accept arguments
> towards thi= s being better, but I need to know those arguments.

The assert change as you proposed is hard to understand and will be thus = harder to maintain. Conceptually sharing being torn down makes sense to hap= pen before paging is torn down. Considering that's how it has been befo= re the unfortunate regression I'm fixing here I don't think more ju= stification is needed. The code-churn is minimal anyway.

Tamas
--00000000000037a42b05f537dfba-- From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:08:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499010.769989 (Exim 4.92) (envelope-from ) id 1pUVCI-0007nx-Pg; Tue, 21 Feb 2023 16:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499010.769989; Tue, 21 Feb 2023 16:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVCI-0007nq-Mu; Tue, 21 Feb 2023 16:08:54 +0000 Received: by outflank-mailman (input) for mailman id 499010; Tue, 21 Feb 2023 16:08:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVCH-0007n7-BJ; Tue, 21 Feb 2023 16:08:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVCH-00065x-8v; Tue, 21 Feb 2023 16:08:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVCG-0005xT-U6; Tue, 21 Feb 2023 16:08:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUVCG-0002d1-Tb; Tue, 21 Feb 2023 16:08:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7bar8Qlu40ML4z1GcXDWKsKzngPS8pLm/Y2HzkuriSc=; b=MtoI+VZg6jMMbj8h+20fZprbAr E90fpi4oh8QUMDAAFX5c/iRCV8+ZfLLJbj2OTI20RxFaysj7T56tyjfzTFF5nTKMfVcS3aY9vrIeD kLPlPLgfsevPIO3wCuDHRuXAQ0DIrsq8O7WZy9mB0Jw2yl9cnG+lv614x/79Vd/L+Ju4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 177984: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=f0c1ce43824f049bb3dea056d4302132d47d24e8 X-Osstest-Versions-That: libvirt=15e5eb8a7684992d1a885038d28781462a727bf2 From: osstest service owner Date: Tue, 21 Feb 2023 16:08:52 +0000 flight 177984 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/177984/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt f0c1ce43824f049bb3dea056d4302132d47d24e8 baseline version: libvirt 15e5eb8a7684992d1a885038d28781462a727bf2 Last test of basis 177679 2023-02-18 04:20:11 Z 3 days Testing same since 177984 2023-02-21 04:18:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrea Bolognani Michal Privoznik Peter Krempa Temuri Doghonadze jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 15e5eb8a76..f0c1ce4382 f0c1ce43824f049bb3dea056d4302132d47d24e8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499022.770040 (Exim 4.92) (envelope-from ) id 1pUVwA-00072M-Mf; Tue, 21 Feb 2023 16:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499022.770040; Tue, 21 Feb 2023 16:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwA-00071p-ET; Tue, 21 Feb 2023 16:56:18 +0000 Received: by outflank-mailman (input) for mailman id 499022; Tue, 21 Feb 2023 16:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw7-0006LK-V8 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1a83510-b208-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 17:56:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1a83510-b208-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Vyg/T9XMUEE68jg+6QZXY7ebqN0NWemozUvwP8WqujU=; b=K6exygKpgoRC1snPAf10ED/JT3Ay6YAxv3zniv29YdDMTGqRsUgqwMDG TklOBXFauFwOaWlYdgYCgndRj7YD0qzg19T2hzky0k5HSf3VU23DeiLMi /QWGZpzFzO0tiUnwD9mGnvRjYVI3zkMYWcaewY9Nf37gx4sR8Hii2G+DF I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97316291 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:TbFGLq+s2lGsd2BdGqwMDrUDmn6TJUtcMsCJ2f8bNWPcYEJGY0x3y DFMWGGBM/+LYzP2KI9yatvjpBtQupDTyIVnQQRqq3g8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oS5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkkTz dIXERERPiuJuPqt6ZihcsRt3/4aeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0EwR3B+ DiXpgwVBDkeGt3OzxWuokv0rffrmznSAo4LDLyBo6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0UNNKH+o3wAqE0KbT7kCSAW1sZiVadNUsucsyRDor/ lyEhdXkAXpoqrL9dJ6G3u7K93XoY3FTdDJcI3ZeFmPp/uUPvqlutjzAd/d/QJW/scXuMBvq+ x2L9RIH0uB7YdEw6423+lXOgjSJr5fPTxIo6gi/Yl9J/j+Vd6b+OdX2tAGzAeJoad/AEwLf5 CRsd922trhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iQsI2KBj Kz741k5CHpv0JyCNPYfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZzz/Bma c/LLp/3VR727JiLKxLsGo8gPUIDnHhilQs/u7imp/hY7VZuTCHMEupUWLd/Rus48LmFsG3oH yV3bqO3J+FkeLSmOEH/qNdDRW3m2FBnXfgaXeQLLL/cSuencUl9Y8LsLUQJIdI7wf4Ozb+Rp hlQmCZwkTLCuJEOEi3SAlgLVV8ldcwXQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:QW8CjqocuN6YBWyuhW0PBCYaV5rdeYIsimQD101hICG9Evb0qy lhppQmPH7P+VAssRQb8+xoV5PufZqxz/BICMwqTNWftWrdyQyVxeNZnOjfKlTbckWTygce79 YET0EXMrbN5DNB/KLHCWeDcurJwLO8gd+VbeW19QYScem9AZsQnjuQCWygYz1LrBEtP+tBKH IFjPA32gZJfx4sH7yGL0hAZcfvjfvRmqnrZBYXbiRXlDVn3VuTmcXH+wHz5GZlbw9y X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97316291" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 4/7] automation: Use EOL tag for Jessie container Date: Tue, 21 Feb 2023 16:55:39 +0000 Message-ID: <20230221165542.7642-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain As Jessie is EOL, the official tag isn't supported anymore. Also, the GPG key for the packages on the repository on the official image are expired and it isn't possible to update or install packages. But we can use the image from "debian/eol" tag which use repositories from archive.debian.org and have workaround to ignore the validity date of the keys. There isn't a dedicated i386 tag for jessie, but we can ask docker to pull the i386 image of the "debial/eol:jessie" tag. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch, this replace "automation: Ignore package authentification issue in Jessie container" workaround I've seen in the debian/eol:jessie: 'Acquire::Check-Valid-Until "false";' in /etc/apt/apt.conf.d/ And a script to replace the "gpgv" binary used by apt, which check that the only issue with a signature is that the key has expired. automation/build/debian/jessie-i386.dockerfile | 2 +- automation/build/debian/jessie.dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index 3f86d91f63..276b640ec9 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -1,4 +1,4 @@ -FROM i386/debian:jessie +FROM --platform=linux/i386 debian/eol:jessie LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 2f19adcad3..06128d1a40 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -1,4 +1,4 @@ -FROM debian:jessie +FROM debian/eol:jessie LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499019.770011 (Exim 4.92) (envelope-from ) id 1pUVw7-0006Sa-MR; Tue, 21 Feb 2023 16:56:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499019.770011; Tue, 21 Feb 2023 16:56:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw7-0006ST-I1; Tue, 21 Feb 2023 16:56:15 +0000 Received: by outflank-mailman (input) for mailman id 499019; Tue, 21 Feb 2023 16:56:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw5-0006DG-Pv for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a25355ec-b208-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:56:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a25355ec-b208-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dejqBUDapsyzI7HHhOmckM2GIW5qoACppxaU6sOaF10=; b=Reuwv/iuGWcZq2cHzUtYIEuUviDT2WWnNjlE7zxui0kJ18jJK7AnQ6kI ffzFCJAfgywXQjiiDdZuCJwAlbeyDEl1LQO9Cz2igQ5+OOLIQZqalV/wY ueeH0cO2N6BAImPddMuJcSx/qdvkKYKumZJwHQwKUeEAFXz3pgCx9ruo2 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98340059 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:5brBn61BmJQpBWpJQvbD5clxkn2cJEfYwER7XKvMYLTBsI5bpzxSx msZXzvSafiINzTweNBwPNzipk5T65GGydFrQQA6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfRn0f8 aQHAnMxZDvfq7yon5KFYdtImZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFJUOwh7A+ zOuE2LRDB8ZGsKdwx650W+Kl/HrzTHEV44qC+jtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHslhUVQdZXHsUx4RuBzaeS6AGcbkAfVSJIYtEisM4wRBQp2 0WPktevAiZg2IB5UlrEqO3S92nrf3FIcylbP3RsoRY5D8fL551iikrQZJVfGoXpooPrRhHO6 AKus31r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGpxZEdMKS BWJ0e+02HO0FCLzBZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzxZ9yPFna cjCKp7E4ZMm5UNPlmfeegvg+eVzmnBWKZ37GPgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2 483Cid+8D0GCLeWSnCOoeYuwaUicSBT6Wbe95YGKYZu42NORAkcNhMm6el/JdI/xP8Nz7+gE 7PUchYw9WcTTEbvcW2iAk2PopuzNXqjhRrX5RARAGs= IronPort-HdrOrdr: A9a23:rYtewaz3j4P9G2KmD245KrPw2r1zdoMgy1knxilNoHxuH/BwWf rPoB17726TtN91YhsdcL+7V5VoLUmzyXcx2/hyAV7AZniAhILLFvAA0WKK+VSJdxEWtNQtsJ uIG5IUNDSaNykfsS+V2miF+9ZL+qj5zEir792usUuEm2tRGtBdBwQSMHfqLqVvLjM2fKbQjP Cnl7d6TzzLQwVuUu2LQkMrcsLkvNPxmJfvcXc9dmIaAFnnt0LS1FbieSLopCsjbw== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="98340059" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 7/7] automation: Remove expired root certificates used to be used by let's encrypt Date: Tue, 21 Feb 2023 16:55:42 +0000 Message-ID: <20230221165542.7642-8-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain While the Let's Encrypt root certificate ISRG_Root_X1.crt is already present, openssl seems to still check for the root certificate DST_Root_CA_X3.crt which has expired. This prevent https connections. Removing DST_Root_CA_X3 fix the issue. Signed-off-by: Anthony PERARD --- Notes: v2: - remove unneeded changes to CentOS containers automation/build/debian/jessie-i386.dockerfile | 5 +++++ automation/build/debian/jessie.dockerfile | 5 +++++ automation/build/ubuntu/trusty.dockerfile | 5 +++++ 3 files changed, 15 insertions(+) diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index 276b640ec9..e04b43f32f 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -49,3 +49,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i '/mozilla\/DST_Root_CA_X3\.crt/d' /etc/ca-certificates.conf && \ + update-ca-certificates diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 06128d1a40..e8aa0183ee 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -48,3 +48,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i '/mozilla\/DST_Root_CA_X3\.crt/d' /etc/ca-certificates.conf && \ + update-ca-certificates diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile index b4b2f85e73..16d08ca931 100644 --- a/automation/build/ubuntu/trusty.dockerfile +++ b/automation/build/ubuntu/trusty.dockerfile @@ -49,3 +49,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i 's#mozilla/DST_Root_CA_X3\.crt#!\0#' /etc/ca-certificates.conf && \ + update-ca-certificates -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499020.770015 (Exim 4.92) (envelope-from ) id 1pUVw7-0006W0-SW; Tue, 21 Feb 2023 16:56:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499020.770015; Tue, 21 Feb 2023 16:56:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw7-0006Ug-P9; Tue, 21 Feb 2023 16:56:15 +0000 Received: by outflank-mailman (input) for mailman id 499020; Tue, 21 Feb 2023 16:56:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw6-0006DG-Ps for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5b0cede-b208-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:56:13 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5b0cede-b208-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998573; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W4o5O3b5dmJ26VW9ys1Vtbxkf00DnhjCjIf1FOqAqhM=; b=JbbPl/ZS1puejkGJVYT6+Xee+EhSgcdJp/MTee9Kzb8KSZGsLbQzw5UI /hMFtFCGGKmPeIXvOgtHeigXI04KIlypvmaqP3TRhO3yDnQOnQqKtkyu6 jQa+jIcDyAoSsLwYkfJWnPNNv50o2fvLSaowu6P4Vq0KFz3XwpESImtpQ 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96765393 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:fx2+Fq4CpECVkqBc1o6p5wxRtCLHchMFZxGqfqrLsTDasY5as4F+v jAYUGyDa6zcYTT2f9hxad+/9U4Ou5XTndZlHgs5rixhHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR5QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 8QzCRUrTC+5uc2Pwrn4YLhzmMM4M5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxjH+ D+drj+R7hcyH9m6xGCJol+QiMDSjzHeB99RL4e/+as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9FZCeE95SmGw7DY5AvfDW8BJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bnCrkb/NFMpGPsPLMGzqz6 WGVsi8lmOBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW0C KMwkVkLjHO2AJdNRfYuC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzv9uY MfDIZn1Vi5y5UFbIN2eHbp17FPW7npmmTO7qW7TknxLLoZylFbKEOxYYTNin8gy7b+eoRW9z jqsH5Li9vmra8WnOnO/2ddKfTg3wY0TWcieRzp/KrTSfWKL2QgJV5fs/F/WU9Y7wfoPzbyQp ynVt40x4AOXuEAr4D6iMhhLAI4Dl74kxZ7nFUTA5WqV5kU= IronPort-HdrOrdr: A9a23:KBwSm6nhPVGsO77zcuwGm0sYK4bpDfLa3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRcdcLW7UpVoLkmyyXcY2+cs1PKZLWvbUQiTXeZfBOnZsl7d8kTFn4Yw6U 4jSdkaNDSZNzNHZK3BkW2F+rgboeVu8MqT9JjjJ3UGd3AVV0m3hT0JezpyESdNNXl77YJSLu vk2iLezQDQBEj+aK6AdwE4dtmGnfLnvrT8byULAhY2gTP+8Q9BuNbBYmOlNg51aUI0/Ysf X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="96765393" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 2/7] automation: Ensure that all packages are up-to-dates in CentOS 7 container Date: Tue, 21 Feb 2023 16:55:37 +0000 Message-ID: <20230221165542.7642-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This was prompt by the fact that `wget https://xenbits.xenproject.org` fails with expired certificates, which turned out to be an expired root certificates. Updating all packages fix the issue. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch, this replace a change in "Remove expired root certificates used to be used by let's encrypt" automation/build/centos/7.dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/automation/build/centos/7.dockerfile b/automation/build/centos/7.dockerfile index e688a4cece..f5264e02d9 100644 --- a/automation/build/centos/7.dockerfile +++ b/automation/build/centos/7.dockerfile @@ -15,7 +15,8 @@ RUN rpm --rebuilddb && \ rm -rf /var/cache/yum # install Xen depends -RUN yum -y install \ +RUN yum -y update \ + && yum -y install \ gcc \ gcc-c++ \ ncurses-devel \ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499018.769999 (Exim 4.92) (envelope-from ) id 1pUVw6-0006DY-DF; Tue, 21 Feb 2023 16:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499018.769999; Tue, 21 Feb 2023 16:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw6-0006DR-Ab; Tue, 21 Feb 2023 16:56:14 +0000 Received: by outflank-mailman (input) for mailman id 499018; Tue, 21 Feb 2023 16:56:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw5-0006DG-4j for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9fd1cedf-b208-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:56:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fd1cedf-b208-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998565; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CunKAyRcxTzgTRqFGUV8eBEdQzfnPyauV8u6JmcacUY=; b=K+ZnI42UG/o9S3nBnK6LizRh5AxXfsCRcjE4uBGk9KaENHlYYJf0zOwR tualiDEWXv9keizj2KJKvFEWxLddtXMX8N4le72sX4bG/VEicfmU+z3QT H3Qvtr8ynNZTxofKBEWUigCdVUfpOCBk67DGZd9JqP+SGSMmIqVfl44fr U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96765384 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:7ghZP6L6xQKkMXaCFE+Ry5UlxSXFcZb7ZxGr2PjKsXjdYENShWMHm 2FOUG+GPK6KYjP3e99+PYXn/U9X6sfTyYcxSQBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZnPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5THDsN1 PAHcQsRLTyeofrp+OqXVOpz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbG5oLwx3I+ goq+Uz2Kx9DKcaOwwaU3Srrr8uUgiinWbg7QejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxaspQUAUtBdF+k77gClyafO5QudQG8eQVZpY9U8uMg7bTcjz FOOkpXiAjkHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fHHvdtwrx7QF+1/U4KoqMWqIWnc3 TOV+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJtsldzBO hW7VeZtCHh7ZSLCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6yzhl1wflvZ s7AKa5A6Er27ow9kVKLqxo1i+d3lkjSO0uOLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5TPb9q r5i2z+x40wHCoXWO3CHmbP/2HhWdRDX87iq8Z0IHgNCSyI6cFwc5wj5m+1/JdY+xPwMzo8lP BiVAydl9bY2vlWfQS3iV5ypQOqHsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:21FyeK0YPlGvqhMFShXb1gqjBEQkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7gr5PUtLpTnuAsa9qB/nm6KdpLNhX4tKPzOW31dATrsSjrcKqgeIc0HDH6xmpM JdmsBFY+EYZmIK6foSjjPYLz4hquP3j5xBh43lvglQpdcBUdAQ0+97YDzrYnGfXGN9dOME/A L33Ls7m9KnE05nFviTNz0+cMXogcbEr57iaQ5uPW9a1OHf5QnYk4ITCnKjr20jbw8= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="96765384" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Stefano Stabellini , Doug Goldstein Subject: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits Date: Tue, 21 Feb 2023 16:55:35 +0000 Message-ID: <20230221165542.7642-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v2 v2: - Remove CentOS 7.2 - Remove Debian Jessie test, but update container recipe for the benefit of older branches. - Fix CentOS 7 containner recipe to update all packages. (Fix missing update of HTTPS root certificates) There is work in progress [1] to update urls in our repo to use https, but those https urls to xenbits don't work in our containers, due to an expired root certificate. So we need to update those containers. This series update the dockerfile where just rebuilding the container isn't enough. I've tested the new containers but didn't updated them yet. You can see the result in the following links (if you can access them). There are other containers been test which didn't need dockerfile update. (That was with v1 of the series) https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/777474218 https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/778218868 Building randconfig on debian unstable seems to be an issue. [1] https://lore.kernel.org/xen-devel/75d91def8234bceb41548147ee8af5fea52bd1d6.1675889602.git.demi@invisiblethingslab.com/ Cheers, Anthony PERARD (7): automation: Remove CentOS 7.2 containers and builds automation: Ensure that all packages are up-to-dates in CentOS 7 container automation: Remove clang-8 from Debian unstable container automation: Use EOL tag for Jessie container automation: Add more aliases in containerize automation: Remove testing on Debian Jessie automation: Remove expired root certificates used to be used by let's encrypt automation/build/centos/7.2.dockerfile | 52 ---------------- automation/build/centos/7.dockerfile | 3 +- automation/build/centos/CentOS-7.2.repo | 35 ----------- .../build/debian/jessie-i386.dockerfile | 7 ++- automation/build/debian/jessie.dockerfile | 7 ++- automation/build/debian/unstable-llvm-8.list | 3 - automation/build/debian/unstable.dockerfile | 12 ---- automation/build/ubuntu/trusty.dockerfile | 5 ++ automation/gitlab-ci/build.yaml | 60 ------------------- automation/scripts/containerize | 3 + 10 files changed, 22 insertions(+), 165 deletions(-) delete mode 100644 automation/build/centos/7.2.dockerfile delete mode 100644 automation/build/centos/CentOS-7.2.repo delete mode 100644 automation/build/debian/unstable-llvm-8.list -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499023.770043 (Exim 4.92) (envelope-from ) id 1pUVwA-000780-V4; Tue, 21 Feb 2023 16:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499023.770043; Tue, 21 Feb 2023 16:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwA-00076F-P0; Tue, 21 Feb 2023 16:56:18 +0000 Received: by outflank-mailman (input) for mailman id 499023; Tue, 21 Feb 2023 16:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw8-0006LK-QC for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:16 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6d01d7f-b208-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 17:56:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6d01d7f-b208-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998574; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8cDiBnY23n4DTQU+8+mCfEObQrVGXl20gEs0zMV2ut8=; b=FbKAeuoIwXA5Xq2iAHHsD3ctE0MKa61tEp91ev9oh4dBSGPG+GL/vnmd HylyUvTULjXNo51XrBfJX/t3qLIgYXWSOp6faEr/IQ0nZOSCaf/y/Nxzj CbtiRr7bsZ9D1wVmXAEvine7NpZc8ymXNvxQhvuH7nKu+pGeoEykfwaBV 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97316298 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:EzTa/a5t624+VFfSXuMW0wxRtCLHchMFZxGqfqrLsTDasY5as4F+v jAfX2vQMqnbYGWgc9h3bNzlpB4GvJODm4JnTgo5+S41Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR5QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 cEUOG5WTw+/vriqmK+fa+5SoZxyI5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxnD/ zycrjSR7hcyH8Sv7xG393eXpu7Dny24fZwoLrSZ6as/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c9FZCeE95SmGw7DY5AvfDW8BJhZac8AvvsIyQT0s1 3eKksnvCDgpt6eaIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bki/DXog4MbGJt4fpQSzU4 je0i3BviOBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW0C KMwkVkLjHO2AJdNRfYuC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzv9uY MfDIZn1Vi5y5UFbIN2eHbp17FPW7npmmTO7qW7TknxLLoZylFbKEOxYYTNin8gy7b+eoRW9z jqsH5Li9vmra8WnOnO/2ddKfTg3wY0TWcieRzp/KrTSfWKL2QgJV5fs/F/WU9Y7wfoPzbyQp ynVt40x4AOXuEAr4D6iMhhLAI4Dl74jxZ7nFUTA5WqV5kU= IronPort-HdrOrdr: A9a23:Mksvda/q9jL3N5+Te1luk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97316298" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 5/7] automation: Add more aliases in containerize Date: Tue, 21 Feb 2023 16:55:40 +0000 Message-ID: <20230221165542.7642-6-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper --- automation/scripts/containerize | 3 +++ 1 file changed, 3 insertions(+) diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 9e508918bf..9b1a302d05 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -33,9 +33,12 @@ case "_${CONTAINER}" in _fedora) CONTAINER="${BASE}/fedora:29";; _focal) CONTAINER="${BASE}/ubuntu:focal" ;; _jessie) CONTAINER="${BASE}/debian:jessie" ;; + _jessie-i386) CONTAINER="${BASE}/debian:jessie-i386" ;; _stretch|_) CONTAINER="${BASE}/debian:stretch" ;; + _stretch-i386) CONTAINER="${BASE}/debian:stretch-i386" ;; _buster-gcc-ibt) CONTAINER="${BASE}/debian:buster-gcc-ibt" ;; _unstable|_) CONTAINER="${BASE}/debian:unstable" ;; + _unstable-i386) CONTAINER="${BASE}/debian:unstable-i386" ;; _unstable-arm32-gcc) CONTAINER="${BASE}/debian:unstable-arm32-gcc" ;; _unstable-arm64v8) CONTAINER="${BASE}/debian:unstable-arm64v8" ;; _trusty) CONTAINER="${BASE}/ubuntu:trusty" ;; -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499024.770052 (Exim 4.92) (envelope-from ) id 1pUVwB-0007Gu-FZ; Tue, 21 Feb 2023 16:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499024.770052; Tue, 21 Feb 2023 16:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwB-0007Fh-6t; Tue, 21 Feb 2023 16:56:19 +0000 Received: by outflank-mailman (input) for mailman id 499024; Tue, 21 Feb 2023 16:56:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw8-0006DG-Q5 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:16 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5c8ca27-b208-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:56:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5c8ca27-b208-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998574; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=E1BA4ZDwCy7hT4Mgu12M5f6GV+oxRNyGgRa7eiPzv24=; b=ZG+djzhKWkfs4C3dnpDFnk5a5NdPJtD/jepue5JSn+gxtPw5CGiyXvR0 miBJ5iHzkgrWdCpwXrZjWJAh82RPDaQyJoiyfNNHqtBYL6sYMG9rpwTKe rk7/9gFNh0jltgAMu9Br0/ExE6mIDDQKw4Q2ngvsotqQwWU7rPd1gexyU Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96765392 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ykBzhaJlWeTFwJazFE+Ry5UlxSXFcZb7ZxGr2PjKsXjdYENSgmdSy 2QcCDrSaP3bYTSgf4wnPo219E8OvMSDz4dhSlRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZnPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lOUpv0 No6FwozQSmBjKGcka2lTfJz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbG5oLwx3J/ Aoq+Uy+Phw8LNem+QasrHz0nvDRuHLVX4ANQejQGvlC3wTImz175ActfVCyu/W+h2a1UshTL EFS8S0rxYAp71CiRNT5Wxy+oVaHswQaVt4WFPc1gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fHxmKoSqzTtcexdP5e3hZ7fSC7ux CuV+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJtsldzBO hW7VeZtCHh7ZSLCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6yzhl1wflvZ s7AKa5A6Er27ow9kVKLqxo1i+d3lkjSO0uOLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5TPb9q r5i2z+x40wHCoXWO3CHmbP/2HhWdRDX87iq8Z0IHgNCSyI6cFwc5wj5m+1/JdY+xPwMzo8lP BiVAydl9bY2vlWfQS3iV5ypQOiHsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:P2Z/Ra+Wh5AghNS1aJJuk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="96765392" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 1/7] automation: Remove CentOS 7.2 containers and builds Date: Tue, 21 Feb 2023 16:55:36 +0000 Message-ID: <20230221165542.7642-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain We already have a container which track the latest CentOS 7, no need for this one as well. Also, 7.2 have outdated root certificate which prevent connection to website which use Let's Encrypt. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch automation/build/centos/7.2.dockerfile | 52 ------------------------- automation/build/centos/CentOS-7.2.repo | 35 ----------------- automation/gitlab-ci/build.yaml | 10 ----- 3 files changed, 97 deletions(-) delete mode 100644 automation/build/centos/7.2.dockerfile delete mode 100644 automation/build/centos/CentOS-7.2.repo diff --git a/automation/build/centos/7.2.dockerfile b/automation/build/centos/7.2.dockerfile deleted file mode 100644 index 4baa097e31..0000000000 --- a/automation/build/centos/7.2.dockerfile +++ /dev/null @@ -1,52 +0,0 @@ -FROM centos:7.2.1511 -LABEL maintainer.name="The Xen Project" \ - maintainer.email="xen-devel@lists.xenproject.org" - -# ensure we only get bits from the vault for -# the version we want -COPY CentOS-7.2.repo /etc/yum.repos.d/CentOS-Base.repo - -# install EPEL for dev86, xz-devel and possibly other packages -RUN yum -y install https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm && \ - yum clean all - -RUN mkdir /build -WORKDIR /build - -# work around https://github.com/moby/moby/issues/10180 -# and install Xen depends -RUN rpm --rebuilddb && \ - yum -y install \ - yum-plugin-ovl \ - gcc \ - gcc-c++ \ - ncurses-devel \ - zlib-devel \ - openssl-devel \ - python-devel \ - libuuid-devel \ - pkgconfig \ - # gettext for Xen < 4.13 - gettext \ - flex \ - bison \ - libaio-devel \ - glib2-devel \ - yajl-devel \ - pixman-devel \ - glibc-devel \ - # glibc-devel.i686 for Xen < 4.15 - glibc-devel.i686 \ - make \ - binutils \ - git \ - wget \ - acpica-tools \ - python-markdown \ - patch \ - checkpolicy \ - dev86 \ - xz-devel \ - bzip2 \ - nasm \ - && yum clean all diff --git a/automation/build/centos/CentOS-7.2.repo b/automation/build/centos/CentOS-7.2.repo deleted file mode 100644 index 4da27faeb5..0000000000 --- a/automation/build/centos/CentOS-7.2.repo +++ /dev/null @@ -1,35 +0,0 @@ -# CentOS-Base.repo -# -# This is a replacement file that pins things to just use CentOS 7.2 -# from the CentOS Vault. -# - -[base] -name=CentOS-7.2.1511 - Base -baseurl=http://vault.centos.org/7.2.1511/os/$basearch/ -gpgcheck=1 -gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 - -#released updates -[updates] -name=CentOS-7.2.1511 - Updates -baseurl=http://vault.centos.org/7.2.1511/updates/$basearch/ -gpgcheck=1 -gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 - -#additional packages that may be useful -[extras] -name=CentOS-7.2.1511 - Extras -baseurl=http://vault.centos.org/7.2.1511/extras/$basearch/ -gpgcheck=1 -gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 - -#additional packages that extend functionality of existing packages -[centosplus] -name=CentOS-7.2.1511 - Plus -baseurl=http://vault.centos.org/7.2.1511/centosplus/$basearch/ -gpgcheck=1 -gpgcheck=1 -enabled=0 -gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 - diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 079e9b73f6..aed8fc0240 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -211,16 +211,6 @@ archlinux-gcc-debug: variables: CONTAINER: archlinux:current -centos-7-2-gcc: - extends: .gcc-x86-64-build - variables: - CONTAINER: centos:7.2 - -centos-7-2-gcc-debug: - extends: .gcc-x86-64-build-debug - variables: - CONTAINER: centos:7.2 - centos-7-gcc: extends: .gcc-x86-64-build variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499021.770033 (Exim 4.92) (envelope-from ) id 1pUVwA-0006yf-92; Tue, 21 Feb 2023 16:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499021.770033; Tue, 21 Feb 2023 16:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwA-0006yU-66; Tue, 21 Feb 2023 16:56:18 +0000 Received: by outflank-mailman (input) for mailman id 499021; Tue, 21 Feb 2023 16:56:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVw7-0006DG-Q3 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:15 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a64f8060-b208-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 17:56:14 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a64f8060-b208-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998574; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lZPdRI/rCKRxPfrcQsNJIuk7eF0eSCT4HXLvudQRh+U=; b=U8Z5C+5cecy1PfLbdbjTDmq3eakqtVa17ZAM7OTegr3FwPUbVOpfYsJe sl36hen2JMlKHHjvyDH/I93zYhnZygKaS7Yv5pAbEXNK1N/9Mj1Inec+2 uGrDsk79ZcuAopz50GK90uS9inj08oT/QQUmPFC0ZSLh+h9hzV4qRK0x2 w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96765394 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:nwrPIKxJ1wEjfQ05Ow56t+ctxirEfRIJ4+MujC+fZmUNrF6WrkUFy GIYC2+GbK7YZDSge9gja4mzoEpUvJDWyoI2SwNurSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkP6kT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KXN23 t09DhIyVC6svuC9g5jqVfdrndt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZQLwRjF/ TOal4j/KiEfDOWY5AXUznOXu+Dphz+8W4wrT4Tto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYXUsBcFOAS4wiXxq3ZpQ2eAwAsVSVdYdYrsMs3Qz0C1 VKTmd7tQzt1v9WopWm1r+nO62noYG5McDFEPHVfJecY3zX9iJMLpTPqaPRcKpCat9/+Whuh3 C6Ntzdr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 BDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0O5eJFcFg 2eJ42u9AaO/21PzNMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhdywPhvY cfEKJ30ZZr/NUiA5GDrL9rxLJdxnnxurY8tbc2TI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A P4GX/ZmPy53CbWkCgGOqN57ELz/BSRjbXwAg5ANJ7Hrz8sPMD1JNsI9Npt7JdI7xf8Ozr6Ql px/M2cBoGfCabT8AV3iQhhehHnHBv6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:SkJ8sKM2FDyxHsBcTjejsMiBIKoaSvp037BK7S1MoNJuEvBw9v re+sjzsCWftN9/Yh4dcLy7VpVoBEmsl6KdgrNhWotKPjOW21dARbsKheffKn/bakjDH4Zmvp uIGJIObOEYY2IasS77ijPIbOrJwrO8gd6VbTG19QYdceloAZsQnzuQEmygYzRLrJEtP+tFKH KbjPA33waISDAsQemQIGIKZOTHr82jruObXfZXbyRXkzVnlFmTmcTHLyQ= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="96765394" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 3/7] automation: Remove clang-8 from Debian unstable container Date: Tue, 21 Feb 2023 16:55:38 +0000 Message-ID: <20230221165542.7642-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper --- This change will break "staging-*" branches as they would still test clang-8. So patch needs to be backported. (at least build.yaml change) Current container have: root@f3d1fc4f58c7:/build# clang --version clang version 8.0.1- (branches/release_80) root@113cb5730b2a:/build# clang-8 --version clang version 8.0.1- (branches/release_80) (built about 3years ago) --- automation/build/debian/unstable-llvm-8.list | 3 --- automation/build/debian/unstable.dockerfile | 12 ------------ automation/gitlab-ci/build.yaml | 10 ---------- 3 files changed, 25 deletions(-) delete mode 100644 automation/build/debian/unstable-llvm-8.list diff --git a/automation/build/debian/unstable-llvm-8.list b/automation/build/debian/unstable-llvm-8.list deleted file mode 100644 index dc119fa0b4..0000000000 --- a/automation/build/debian/unstable-llvm-8.list +++ /dev/null @@ -1,3 +0,0 @@ -# Unstable LLVM 8 repos -deb http://apt.llvm.org/unstable/ llvm-toolchain-8 main -deb-src http://apt.llvm.org/unstable/ llvm-toolchain-8 main diff --git a/automation/build/debian/unstable.dockerfile b/automation/build/debian/unstable.dockerfile index 9de766d596..b560337b7a 100644 --- a/automation/build/debian/unstable.dockerfile +++ b/automation/build/debian/unstable.dockerfile @@ -51,15 +51,3 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* - -RUN wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|apt-key add - -COPY unstable-llvm-8.list /etc/apt/sources.list.d/ - -RUN apt-get update && \ - apt-get --quiet --yes install \ - clang-8 \ - lld-8 \ - && \ - apt-get autoremove -y && \ - apt-get clean && \ - rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index aed8fc0240..22ce1c45e7 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -329,16 +329,6 @@ debian-unstable-clang-debug: variables: CONTAINER: debian:unstable -debian-unstable-clang-8: - extends: .clang-8-x86-64-build - variables: - CONTAINER: debian:unstable - -debian-unstable-clang-8-debug: - extends: .clang-8-x86-64-build-debug - variables: - CONTAINER: debian:unstable - debian-unstable-gcc: extends: .gcc-x86-64-build variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 16:56:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 16:56:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499025.770062 (Exim 4.92) (envelope-from ) id 1pUVwC-0007TW-4W; Tue, 21 Feb 2023 16:56:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499025.770062; Tue, 21 Feb 2023 16:56:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwB-0007Qg-Og; Tue, 21 Feb 2023 16:56:19 +0000 Received: by outflank-mailman (input) for mailman id 499025; Tue, 21 Feb 2023 16:56:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUVwA-0006LK-DO for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 16:56:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6e795ff-b208-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 17:56:16 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6e795ff-b208-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1676998576; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UseCy4+DGI15ehevA8lX7nQmBmn5pL/bMgIUe4HdfiA=; b=SpLtwq+UFEPVDSGIYr4ML4Gq1Mc0Cad78RzLKXHxRbMZtJa3SxwGhjjV Y+RKyBmizPp9H6xBxvL+kDv4blFdFKMrbkS7IZutuavmlJGPGk6ieFGId ABSIIt/ekXk1d2NdUy1tePAaQu+Z5I0eOBGTAy1pLo/ejT75Pi6BMygiW k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97316300 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:N1uj96qyt3qDMSc3Vi5zp3snLWleBmICZRIvgKrLsJaIsI4StFCzt garIBmBOKyOZTejKd8lYIvl/UkAu5OBytI2HlA//yFnFSgU85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSBNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACwwYgDd3MOp/IvhVrFxouUkEu6zbYxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jOZpD2nWUlCXDCZ4TSUqnKeo7bMoQy4X6BIHoWZ/8VBv2TGkwT/DzVJDADm8JFVkHWWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Ux4RuBzaf86A+DCm8JCDVGbbQOr9QqTDYn0 luImdLBBjF1trCRD3WH+d+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZspeHL7r1fzqJQiq3 2iXiAk5uZJL3MFegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ5Gu9B7cJZhNGiJObhKroUqwXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ 8jFIJ/8VSZFUP8/pNZTewv6+eV2rh3SOEuJHcyrp/hZ+ef2iIGppUctbwLVM7FRAFKsqwTJ6 ddPX/ZmOD0GONASlhL/qNZJRXhTdChTOHwDg5APHgJ1ClY8ST5J5j646e9JRrGJaIwPyLmWp CrmAhYAoLc97FWeQTi3hrlYQOuHdf5CQbgTYUTA4X7AN6AfXLuS IronPort-HdrOrdr: A9a23:+gAjrKzdJSoWJP+tGuBWKrPw2r1zdoMgy1knxilNoHxuH/BwWf rPoB17726TtN91YhsdcL+7V5VoLUmzyXcx2/hyAV7AZniAhILLFvAA0WKK+VSJdxEWtNQtsJ uIG5IUNDSaNykfsS+V2miF+9ZL+qj5zEir792usUuEm2tRGtBdBwQSMHfqLqVvLjM2fKbQjP Cnl7d6TzzLQwVuUu2LQkMrcsLkvNPxmJfvcXc9dmIaAFnnt0LS1FbieSLopCsjbw== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97316300" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie Date: Tue, 21 Feb 2023 16:55:41 +0000 Message-ID: <20230221165542.7642-7-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> References: <20230221165542.7642-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Jessie as rearch EOL in 2020. Even if we update the containers, we would still not be able to reach HTTPS webside with Let's Encrypt certificates and thus would need more change to the container. Signed-off-by: Anthony PERARD --- Notes: HTTPS would fail unless we commit "automation: Remove expired root certificates used to be used by let's encrypt", that is. Patch still in the series, and fix Jessie. automation/gitlab-ci/build.yaml | 40 --------------------------------- 1 file changed, 40 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 22ce1c45e7..2be1b05d5c 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -221,46 +221,6 @@ centos-7-gcc-debug: variables: CONTAINER: centos:7 -debian-jessie-clang: - extends: .clang-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-clang-debug: - extends: .clang-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc: - extends: .gcc-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc-debug: - extends: .gcc-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-32-clang: - extends: .clang-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-clang-debug: - extends: .clang-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc: - extends: .gcc-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc-debug: - extends: .gcc-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - debian-stretch-clang: extends: .clang-x86-64-build variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:02:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:02:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499074.770088 (Exim 4.92) (envelope-from ) id 1pUW2J-0003d3-W0; Tue, 21 Feb 2023 17:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499074.770088; Tue, 21 Feb 2023 17:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUW2J-0003cw-Ru; Tue, 21 Feb 2023 17:02:39 +0000 Received: by outflank-mailman (input) for mailman id 499074; Tue, 21 Feb 2023 17:02:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUW2I-0003ck-6Z; Tue, 21 Feb 2023 17:02:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUW2I-0007OF-48; Tue, 21 Feb 2023 17:02:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUW2H-0008U6-Tq; Tue, 21 Feb 2023 17:02:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUW2H-0000RT-TN; Tue, 21 Feb 2023 17:02:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BOlBjilJBLwSoITlS/ihefaFAklCBv3Mw7OjhwRqWxQ=; b=PoMWhUKvUN8FzDRtgvzpIditU+ x0dKElHNimO0qAxvEOhiYcvqAFzC+runbmgOuRXppxQ0GIKLT4sNG+IJwM61KqZvkedu3bGkinG+f JulZEIIXyPNlVnNAeMCzy1/kx9UUEZG+hW7aEzHRTc9mGlLfehDJyq6K54DMC1HX7PCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178030: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=d58f3941ce3f8943df842fab2d4d761c483af6c4 X-Osstest-Versions-That: xen=a90a0018f605e3bb0588816e5a1f957d6e4562eb From: osstest service owner Date: Tue, 21 Feb 2023 17:02:37 +0000 flight 178030 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178030/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen d58f3941ce3f8943df842fab2d4d761c483af6c4 baseline version: xen a90a0018f605e3bb0588816e5a1f957d6e4562eb Last test of basis 178016 2023-02-21 12:03:32 Z 0 days Testing same since 178030 2023-02-21 15:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Sergey Dyasli jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a90a0018f6..d58f3941ce d58f3941ce3f8943df842fab2d4d761c483af6c4 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:22:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499082.770099 (Exim 4.92) (envelope-from ) id 1pUWL7-0006mk-IQ; Tue, 21 Feb 2023 17:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499082.770099; Tue, 21 Feb 2023 17:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWL7-0006md-Fk; Tue, 21 Feb 2023 17:22:05 +0000 Received: by outflank-mailman (input) for mailman id 499082; Tue, 21 Feb 2023 17:22:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWL6-0006mX-4o for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:22:04 +0000 Received: from fossa.birch.relay.mailchannels.net (fossa.birch.relay.mailchannels.net [23.83.209.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f30b637-b20c-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 18:22:00 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 19FAD100BDE for ; Tue, 21 Feb 2023 17:21:58 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A3A9C100D49 for ; Tue, 21 Feb 2023 17:21:57 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.107.134.126 (trex/6.7.1); Tue, 21 Feb 2023 17:21:57 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4PLmLD3KPszs2 for ; Tue, 21 Feb 2023 09:21:56 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0049 by kmjvbox (DragonFly Mail Agent v0.12); Tue, 21 Feb 2023 09:21:53 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f30b637-b20c-11ed-93b6-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1677000117; a=rsa-sha256; cv=none; b=6LNeswM14LG7SEv4EJuJzbcPK9yxw2FjS8mK39q4oSvkJ2Ya6yHlBhgnhiIgCiLH19sJNA eTjJuazBcEjhOsWnk26Tx9G6G4u8CMzEIEoFEA39ZE4VjpGzMW/79VPlMudOUS+RORJZPG nfTdqXSxbDroc+Nb77kTOvSHdrQ23j7YVlL/BIH/JPkZqjgm057e/Dbi8UG+vmgEmmtf5p c0ACxiueVbw7MoR0QiyquLmdtsNka8w7LJBOQxIPIV+OWAm3ZUyrSQnzi02M9VCsI/Q31T T9SxvFwIIemm5or70jo+EGo45tUUcfyb5+iomzqtcs/aR75BghGtGsDEffVtyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1677000117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ik/BxQVPULpYrwYc2hSx19d57QjiK1F7eWzQZ1uWOVk=; b=J4derqVFJoMoBMS/cOvGnTn+1pWG8PtkakqynpvlrMNI7DP8XPx22NbRhksWdA7Mz3US7t RXP1weVwGeCUrjhYnx584vnfuZwbuI1WsY2jnCQp+E96FLqX0uKvtwV6KxWp7txe6DQCNh jhWH6jBRFA1ufHME3j7WAlNeJwjsMKKtx9vbQZaxa1tOoefKz/Py6a+Gftljo2ey8tz5G/ cSaVj/Pk5tU3wv80JVQijOrpiVbRZH6Er2VYnz1whEkFt3J6/VxKd9+oE5ej35izV93H5p vqgH2cWE3dHQmVVScySMf+WQlnxLiYNF5sKFGL0NPvGCRtaHtPWniXQE2ce6zQ== ARC-Authentication-Results: i=1; rspamd-5db48964c-h5x86; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Reign-Belong: 345d51f47e06eb0c_1677000117906_2636194607 X-MC-Loop-Signature: 1677000117906:3418325762 X-MC-Ingress-Time: 1677000117905 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1677000116; bh=Ik/BxQVPULpYrwYc2hSx19d57QjiK1F7eWzQZ1uWOVk=; h=Date:From:To:Cc:Subject:Content-Type; b=gqF9568282uKRsEIEgA1nRl+jKjN+IosOQmmHCR/gPRbwLyXl2ITSNpOf7umXPYdF u73Oxg7tU1yOpCAY7rg/bT5YAvg/eOIlyqKV4CizKqFDA7SQjMXbJH3nfWz5Elz71n idH4kJJcLrOUw5dgnxgx03DDEjqg2oXoNYnz0oEY= Date: Tue, 21 Feb 2023 09:21:53 -0800 From: Krister Johansen To: Thomas Gleixner Cc: Krister Johansen , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Juergen Gross , Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: <20230221172153.GA1958@templeofstupid.com> References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> <20230221055117.GA1934@templeofstupid.com> <871qmjpegh.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qmjpegh.ffs@tglx> On Tue, Feb 21, 2023 at 10:14:54AM +0100, Thomas Gleixner wrote: > On Mon, Feb 20 2023 at 21:51, Krister Johansen wrote: > > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: > >> > static bool __init xen_tsc_safe_clocksource(void) > >> > { > >> > u32 eax, ebx. ecx, edx; > >> > > >> > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > >> > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > >> > > >> > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; > >> > } > >> > >> I'm all for simplifying. I'm happy to clean up that return to be more > >> idiomatic. I was under the impression, perhaps mistaken, though, that > >> the X86_FEATURE_CONSTANT_TSC, X86_FEATURE_NONSTOP_TSC, and > >> check_tsc_unstable() checks were actually serving a purpose: to ensure > >> that we don't rely on the tsc in environments where it's being emulated > >> and the OS would be better served by using a PV clock. Specifically, > >> kvmclock_init() makes a very similar set of checks that I also thought > >> were load-bearing. > > > > Bah, what I meant to say was emulated, unstable, or otherwise unsuitable > > for use as a clocksource. IOW, even if TSC_MODE_NEVER_EMULATE is > > set, it's possible that a user is attempting a migration from a cpu > > that's not invariant, and we'd still want to check for that case and > > fall back to a PV clocksource, correct? > > Sure. But a life migration from a NEVER_EMULATE to a non-invariant host > is a patently bad idea and has nothing to do with the __init function, > which is gone at that point already. > > What I wanted to say: > > static bool __init xen_tsc_safe_clocksource(void) > { > ...... > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; > } Thanks, I'm happy to make it look like ^ that. I should have thought to do this myself. :/ I'll send out a v2 making this correction. > I didn't have the full context and was just looking at the condition. > Now I checked the full context and I think that except for the > > if (check_tsc_unstable()) > > check everything else can go away unless you do not trust the hypervisor > that it only sets the NEVER_EMULATE bit when CONSTANT and NONSTOP are > set as well. But yeah, you might prefer to be paranoid. It's virt after > all. Unless there are objections, I think I'd prefer to err on the side of paranoia here. Sorry for the confusion. -K From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:22:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499083.770110 (Exim 4.92) (envelope-from ) id 1pUWLD-00072x-Qo; Tue, 21 Feb 2023 17:22:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499083.770110; Tue, 21 Feb 2023 17:22:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWLD-00072q-O0; Tue, 21 Feb 2023 17:22:11 +0000 Received: by outflank-mailman (input) for mailman id 499083; Tue, 21 Feb 2023 17:22:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWLD-00072a-55 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:22:11 +0000 Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44136aff-b20c-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 18:22:08 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7E37E640D4C for ; Tue, 21 Feb 2023 17:22:06 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 172E4641123 for ; Tue, 21 Feb 2023 17:22:06 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.138.62 (trex/6.7.1); Tue, 21 Feb 2023 17:22:06 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4PLmLN0f0Dzyl for ; Tue, 21 Feb 2023 09:22:03 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0049 by kmjvbox (DragonFly Mail Agent v0.12); Tue, 21 Feb 2023 09:22:00 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44136aff-b20c-11ed-a089-e9535cc0f9c3 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1677000126; a=rsa-sha256; cv=none; b=o9FVfGd+S5cbGE25X6uMiTupqVMxKNZq+be6g+k5TuI59ZyjSBvzerbgp5dhGpz5SBv+CJ 4PteRvLicgDQqAdRvZX+xbsFJfycnpeh+YFS6Y79L8KllgMxpVFcEnaXbtvH2U4js9EMwa KtxGoYDXPbzZCHQ1qddQii6Nw70wZMZLEo5kRz1hBiTeFh/4jcbWzqqScjyeniEYpV5wW0 sRoZw7PhGXhGCGBp11lXh4Q78Zh54+ykOAE/ohhHTnx6dVhvPnvNxFGftWHa4t2ojtbYU8 xytaUgQzulG32eIchUArzigxGSqiM9ogRYjpqHcXtFSAfWf26WnpZXgs9GjgCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1677000126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V/XcrwQCic125n2lnngmDNOBHq5WbsWAtWXZs/Ki6+I=; b=O58r4wR44Bi7btXXk0tmTJkuiA9es2N5rQNlo1qCWiHZWf/NVOQxVkIyg7xjkfyP9Lp2ER npFT/doMfOAKL3j6TQwMirKvsFjMlfQ8G5zqn4plqfYvPZxlxcKH+ox8o0CkLFLPXSzIRY uG62+cK64UcndoqXUuLqvn1pj0nk3qrzcpuVlXp7d0b6xn136Mppqgg3YvFIVSo8G6jz2t uwD1e1PQt7TcjD7i8p/Q4r8VNMdv7UJOnZmYWpG07ya7ZOVJGnvqfyfMSwWzM0Q1OzdzJp VAw4obKkV31Iwbayua2s92szIFCAUFpkIGdSkM3SA3Dp+R1lL+6m9BP7QhqT7g== ARC-Authentication-Results: i=1; rspamd-5db48964c-ktlv5; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Trade-Relation: 02c95bf72858f16f_1677000126326_4027845758 X-MC-Loop-Signature: 1677000126326:668681715 X-MC-Ingress-Time: 1677000126326 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1677000124; bh=V/XcrwQCic125n2lnngmDNOBHq5WbsWAtWXZs/Ki6+I=; h=Date:From:To:Cc:Subject:Content-Type; b=t38e3ebH6n0d5KAs1qjo+n9b7yYz904DV8k7Xm4gfAeAvlRyaKDDgF5f5myB4DFNz GW/e+O3i5YqMryRYNEMlfdLI1G8jHb8ihCRKW5zanR4jwJU2dynL91n7DmCWMgQWcL uJvrwUpSBfmIbAhMqrx8ptJvUv1RXb6kjneLFU9o= Date: Tue, 21 Feb 2023 09:22:00 -0800 From: Krister Johansen To: Juergen Gross Cc: Krister Johansen , Thomas Gleixner , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Jan Beulich , Boris Ostrovsky , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: Re: [PATCH linux-next 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: <20230221172200.GB1958@templeofstupid.com> References: <87h6vgov2p.ffs@tglx> <20230221041440.GA1934@templeofstupid.com> <20230221055117.GA1934@templeofstupid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 21, 2023 at 09:47:24AM +0100, Juergen Gross wrote: > On 21.02.23 06:51, Krister Johansen wrote: > > On Mon, Feb 20, 2023 at 08:14:40PM -0800, Krister Johansen wrote: > > > On Mon, Feb 20, 2023 at 11:01:18PM +0100, Thomas Gleixner wrote: > > > > On Mon, Feb 20 2023 at 09:17, Krister Johansen wrote: > > > > > @@ -495,8 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) > > > > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > > > > > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > > > > - /* tsc_mode = no_emulate (2) */ > > > > > - if (ebx != 2) > > > > > + if (ebx != XEN_CPUID_TSC_MODE_NEVER_EMULATE) > > > > > return 0; > > > > > return 1; > > > > > > > > What about removing more stupidity from that function? > > > > > > > > static bool __init xen_tsc_safe_clocksource(void) > > > > { > > > > u32 eax, ebx. ecx, edx; > > > > /* Leaf 4, sub-leaf 0 (0x40000x03) */ > > > > cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); > > > > > > > > return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; > > > > } > > > > > > I'm all for simplifying. I'm happy to clean up that return to be more > > > idiomatic. I was under the impression, perhaps mistaken, though, that > > > the X86_FEATURE_CONSTANT_TSC, X86_FEATURE_NONSTOP_TSC, and > > > check_tsc_unstable() checks were actually serving a purpose: to ensure > > > that we don't rely on the tsc in environments where it's being emulated > > > and the OS would be better served by using a PV clock. Specifically, > > > kvmclock_init() makes a very similar set of checks that I also thought > > > were load-bearing. > > > > Bah, what I meant to say was emulated, unstable, or otherwise unsuitable > > for use as a clocksource. IOW, even if TSC_MODE_NEVER_EMULATE is > > set, it's possible that a user is attempting a migration from a cpu > > that's not invariant, and we'd still want to check for that case and > > fall back to a PV clocksource, correct? > > But Thomas' suggestion wasn't changing any behavior compared to your > patch. It just makes it easier to read. > > If you are unsure your patch is correct, please verify the correctness > before sending it. Thanks, and apologies. I misunderstood and thought a more complex change was requested. -K From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:24:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:24:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499097.770121 (Exim 4.92) (envelope-from ) id 1pUWNp-0007ty-8J; Tue, 21 Feb 2023 17:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499097.770121; Tue, 21 Feb 2023 17:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWNp-0007tr-5J; Tue, 21 Feb 2023 17:24:53 +0000 Received: by outflank-mailman (input) for mailman id 499097; Tue, 21 Feb 2023 17:24:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWNn-0007tg-Vr for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:24:52 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a475ecfe-b20c-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 18:24:50 +0100 (CET) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 12:24:47 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5428.namprd03.prod.outlook.com (2603:10b6:208:285::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 17:24:44 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 17:24:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a475ecfe-b20c-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677000290; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Cjw+4q3s9dMqWHqaE/OpaprXq9r1/fGZDGw7AGy2+JY=; b=ciAaYURoI1sPdhj3/zQlBjOqTCGcj6JGhu6EwPolIJ0jUoLgqWpu/7oz lzNmeaQbxgZrvDu+q1wONKHPRr6/wTAKqzKeIKtNlvlo+JkkAv7D979mm En3lFhcsFbl+Ltd+/PVvzXn7yK4LXrDDjTViXmxdx7JEYl+o5R76xu8V2 I=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 97943639 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:h5XZea0+ir5zfoVYOfbD5ehwkn2cJEfYwER7XKvMYLTBsI5bpzwBm GcWW2qEbq2CNmb3ctByPoq/9k5TsZOGzYNrG1Q9pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfXGRvt vMpIQsxfBW8nv/x7ZyJZ85Kv5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6Kk1QZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKkCd5JSubpnhJsqEOT3T0OSyVLb0eAn8CUrlGAYfh1F 3VBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/H8pKkjgxSJScxseJNZlfXwEDD0h jyP8i43guxKidZRjvrju1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nU/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:smz3TquNp7r3eajNfbvAcqvr7skDZ9V00zEX/kB9WHVpm62j+v xG+c5xvyMc5wxhO03I5urwWpVoLUmzyXcX2+Us1NWZPDUO0VHARL2KhrGM/9SPIUzDH+dmpM JdT5Q= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97943639" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSRFhh+vwgkLkBtbQzNRyHlHcV6oCqFBXX4rQOk8z20/lbGpHXSgNPWOUaTZI0oDooG+YeyivfopFOPUlxh7WXiZUQuUhxsGe9lxO5NE/k/tqo9dOYVCb5m10gkenpJkmlUZgC7hy19tSJqukg/32N7lftk0V/fw5y0paHrEcgIgCoHAoEVvpi/ASbXRiLJQ1aiiZw9wIdVOcDC8bH5IFdO77WvwUM9iBy2XFPsrpbeO0TN8AoJFTQKRXk7Pf0J5KULUGyQfVmv7aCRap5s6HLtLgLLVWbzIMJp8SqkaDZjewdEZLgwmLqAFFHfjP/Cxt7ZGthGYjnELVkHnL6+0xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cjw+4q3s9dMqWHqaE/OpaprXq9r1/fGZDGw7AGy2+JY=; b=Psz+PfPfJmSGl335fh95mS2+N870R5GYJcep1yQesSwXYBLs5IBJfrBI1Sb6YP1J+ECcGgr2umLg5nO6PZfJzb1phUSPJ/570GN2nelG+on6ZMMJ5dRrWzu2UjrCOIB/Jk0XYlItxHvGXwHyGI/v3WAswWkLHFn3RJI7QLSQQ2v2SuhP6KIqhoYvlr59+AXvsSA4akPCUZ868Bjax4MtfBZrE9qgY2KcTcF3RpC2q5DG0tyXke2UE87Oj5RXAlBTB5OPt9e2nwVEiCZEdo5qZC5Ww0OxCo6CeDUKBbcVT0Kzil0qkW87s37QyXsFaQMJMOrOWf8K2kYiqGXNRqmlpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cjw+4q3s9dMqWHqaE/OpaprXq9r1/fGZDGw7AGy2+JY=; b=oVnbIZc444xtsvPWlg8HYAehmiCQwd1y+YAoKWci8GtIOyEAG4ylz+mLeQTrDMKLbJ52ac/UNkkKqP0Nxd8SVvaroyH2GyoUWqpPTyCJEUAe8IWNG+8SI661zzN31V5g++U1+2GBGori/P2VvJsE8PdaeSnvyXDppDzlPBzu1Lg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7d3514ca-f557-3c1f-3a62-3ad8695cf5c9@citrix.com> Date: Tue, 21 Feb 2023 17:24:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 2/4] x86/svm: cleanup svm.h Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230217184814.1243046-1-burzalodowa@gmail.com> <20230217184814.1243046-3-burzalodowa@gmail.com> <562ae912-e833-ba97-dcd5-4c6b6d8898e0@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0595.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5428:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ce688ac-bb6b-4400-e079-08db14308571 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7J7Cm+ZUtp75IRZ02JpbcU0z3jSANKBzT5LIzBju7eg9Lp3mIbIrGWXDVj106HaMtcUd92HpQMuXmFhlu9mOfbFS7zrK+nv9WIbKdmOMJHOkSMcjU8IytJj6KCpoDaJnFQybNHsSKc6RrL2qLCVYiEuIDbuEmlaCzTXT2Td0GvLfQBz9die4sEhg5PDOMomnOSE1Qp/Z1FaVNE6Rrs0EuTmWPwUeNrYUN8wa1WsSaN50GgmWt/P0EESZu65CrOQ06n8o7HKz5oRt0lfaVq3EQXL5AT5MynyWH51LWK/UpaljyEWbz/UtUDGR6F9kF+fFZWHQv3M56gY+o4eoEe9qlRL+JQQUaC+nnZk20ajdWnDePSemLq3uJYcblZFLw/PSYoEDRth13tGjcsYM5UcZBge6J3v355ASlI2Gc0+axJLkQQDhVQ2xmkoOiL7ZrNTDFAQKdAB00V7aZr3QAv9q+TSrJ/vRqxwL5VoksD5CnAKRETNWXJ84VY7oDQzaEN2qkElqw71fepF3F64OXaZ7bdBe3wz2rClTuhMP4XYFjrdm9QaDdkDwPok8ppVN9Fs6FdGXmuce9ou2DgMSQurJKCcEbVglVClBAc1LG87DgQt0kvbXnC0UPeSbulZofrndB/uRuvmIfCEKDBQImdKXKdg4ENZeh/zrgNdMkvxPG9/JkDiWlxv2PagK/PEKt9dVQFEJGSpGqceTItBm72Sed+ISbwf3gCS3etT88yYn02Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(451199018)(41300700001)(83380400001)(54906003)(186003)(6512007)(26005)(316002)(6506007)(86362001)(6486002)(31696002)(6666004)(53546011)(478600001)(36756003)(2616005)(66476007)(4326008)(8676002)(66946007)(66556008)(2906002)(82960400001)(31686004)(38100700002)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkJSYnJyUXkyMzFFc3dnelY0UFlmRlNocGdTSVRPMmRqQWdJVWpucysxSWlJ?= =?utf-8?B?M2J4QnBsb3h5djd1VlFJc1d5bG5RLzRVSGpIQ0JLTEszZHhpT2RLN3ZhUFpD?= =?utf-8?B?NldhaTdHbkUxL2NQOHovMEgzVzRIVklSZXY0QVdUMEw5dEdzYmI5UEFiWFBP?= =?utf-8?B?ekt3cHd3azViMEk5ejJZSm43TlBRL25zTWlHY2NIRVVPL3B6eExvaGdJQWtt?= =?utf-8?B?c3JYZDE4VGZNTnBlMVJLS2xzOWVmcjJjL0lJd2J0REw0ZEY0SzNEWUZsU0Jo?= =?utf-8?B?YkFWZUNPbWVTRHVKQkxOMEo1a3RVd2tGMUZVZzQ4aGdZTWczYk9uUVVDZjJH?= =?utf-8?B?emY4Ym9zaWp0NGNDaitmZFduQ2VUUGRWUUtjRVFKd2tWa3N0UmZtN1paRmNN?= =?utf-8?B?dXVKYXRJR2RHMjJRTHcveCtOaXBmb1pDczYrcXNGblJVNUNVUzhHaXRpNFYr?= =?utf-8?B?WmI4Y1BUeFRMT0hBbnpqY2ZiSHNPY1AzLzViQmtBVjN1K0YvUWFZcTBobjNk?= =?utf-8?B?NzFyNG9yVlhLcUNlMkZuWjVBL2ZFSzhWVmtYYXZZRGltdHI1alFna1FpZXpm?= =?utf-8?B?Z01YbzlXYVZRV3RBdzdzd1c2RUhrYjMxYUlNTkNMWmduUEZiUDVYYTBtKzNz?= =?utf-8?B?TVFEOWl4b1pPekZCZFdzMEFNYzJ0SWpaM0d2aW5lN3IyK3JnL0dUd3pRNTlY?= =?utf-8?B?R0YxUUtDTlhSenNPdGUyQlVmS3B6Tk51SjZSU3N2cU4yWlIyNEFCOThZWXoz?= =?utf-8?B?RE9TVS9LOFNyWThoLytmUWpXUW1oaDJqcExOK3NTWUF0VHp3SUhFZngwcis5?= =?utf-8?B?ZGRrNmVzRWNVYlFOTU9kWGU3Q1AzcUcwaytndG81cGYzSjNzZ1BnNWtNQW1Z?= =?utf-8?B?c2hOTkNNT1FoRDhxb3JNejhFNy95NDFXdFliUm1jWmhqMVoyaXk4ZkE2bkRW?= =?utf-8?B?SWtWSGxSUmlDckJxakc2TVVxNXU5TlRHN1dpVWhuVmFob0xjYjIzSG9LMmJD?= =?utf-8?B?QXVacDFmcVQrVENjN24remFpOXNNYktJa1l6T0szNFdNUU5XTThxdWpNQlRv?= =?utf-8?B?REh1cE9LV2U5T2dXNHE3L2h3OXc3NlpXZllTVU9ON1VGaXFTWXNkdFZWcWM3?= =?utf-8?B?bUFQT3FGaFQwQWFWaW94NWR3cjN0aVBCOWpTUE1KSUJXa1BPWUxVQXZwZnVn?= =?utf-8?B?bHJtN2x6UkxzMWw3VWRLazVHL3R3UnROQjRJVnJrUUFuR1g1T2FERmtGczV6?= =?utf-8?B?T2VJK2xSM2JrWU9IbjYyTERhaEg0WTh4MnhqcXZmWWUwRW9HVU1KZktteTJn?= =?utf-8?B?VFYrVjdOUzBsZnZPUEswa1Nsc1F5L0twOEM4NXBKOHV3OXJQVUc4eTJtOXVl?= =?utf-8?B?V2t3dS8rcDJYYkFhaFNhT1d2eW4wU3VmZ3ozc1NrQVg2N1phY2s3ZWxIbTBO?= =?utf-8?B?aTFyODY5S0NXcVRyUzBCWm9GM09iQkJZWXg3T0hFNm9oOGF1KytrbTRVK0dy?= =?utf-8?B?MFJPVjlRaFBuZHA1NUVZM2lMNk1McFcwTnQvZ2k3b3d6VUFKeENsbDUyMk9a?= =?utf-8?B?YVd6azhKZC8rY1RKSXNFSFduVU4zV1hnNjV5M3NrYUpic04xSDE1Z24yQm9D?= =?utf-8?B?akZ0S1lGN3N6WjduWlFoYTdLWGo5ZExBcUZUNGp1bUZTSWxIdU9MdXFTWDds?= =?utf-8?B?Yytia0xzZTZMeGdXcUQwekhVVHRScXRNdXF0NE5zS1U1WFd5WjI0K3ZpcHFj?= =?utf-8?B?eWhCM09MaFBGcTNzWTh6dXdVeWZtTnd2VU00UUJJU1ZjVVdkWGtTN3htbWdF?= =?utf-8?B?SXZwdHdZTXVHWFlXWXc5a3Flc2VGWUtGODhLRTdZNnBDRi9zanVoZG5mQytL?= =?utf-8?B?NEFzNUJNK0N2a2Zrc1NhS3BDSEJndENXaUs5alBuRUhDcEJSbmprUElPK1lX?= =?utf-8?B?Z1ZFbkIzbm85NUlQbTdhdEs1UUxNa1dFNTN3WkpSbld5dUFzSFdodGo4NThr?= =?utf-8?B?cFQ4RmgzaVZ2L2Y5Vm5WNWFxRDZXNHdad2Q0RlBrZXRnU2djTC8zeTFIWVV4?= =?utf-8?B?THR1eW9oT2R3RmYxQkZGeGR2NVdRdTNiYy8xKzdPVnZZNWJpTncvU0xDczJs?= =?utf-8?B?MSszZXlFL2dFZjJoTXpmZVpzWGhUVC9tOHNOR0ZMdi9icjVjVHhnWFhCSVM0?= =?utf-8?B?SlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tqU7U5zSIWnO8QngFYcmHTu+MSDR4yoafDYE3/DUs2BUsVDqxCBbTdmzAkkgmF19z+SrOWuBjMAkd9yOmsF5oSphYoUsq/JbYqe9ElZGFz7XUc2V/RPWo8Liogak29/E64GXBazyGZCp/fTweNY8v0UhWBEFvQPOixnPm1yLSFNU0u4f+38mG8dzLszdSGNvyJ8ViPExtOhOz4YG7JLeo5+wLitOzcXHgV529Al3Yavj2PpGuSA6M6gWEjuT08+++Dgiu6MNJpVsjJoeKvji0OjIzhBL1ne6C8sHerl93yMQC0QmmAkHgWjKyFpK1+2uzQhG3grPeJJSne2yE5a3oa0GQxzjZXaLD8b1ef0SIUtFvDjBSoFdkRiMj3avJz5mh8TD7h2GF0LhymqbLAQ3B/LcfiSjrRjW/kGBzN5+6q7cnNk2+jtDZi4ZdLDWfRUcUDddDQfN/wMwbGEcnWsNkBKYrwYIe0k9dprhs6o/15pTusmtY3MUySVu9io7jX0l4zq7xgQ8WmiIrnGgEcvfTu3JCB2JxjnySgwVo4Lbl7Xgz3a1QK2CExFoC6PV+QvqYbIeQKwTQulIkg3RxkNjPxkt08x1N2ndo57GNSLWhUwh/CRaRyWsZux/Jao1b6aVREWCNq2pv1HZfWQA5gwdZSOg8WGJSHORbN+jnIGGWmu8jMITSR18SD/0teWRu6/pe6bZhyrw0XyWgv1g1+mLbEITYbvyu3wAU+08l7D63DhRgclBJVEJ2YAi8sOXce6XOqvCSM99ae5uB0xHpxkQdJCDsBpI/IvoIuh6nu+SfmuiZjPPsoQxtA3SD6uGpEmJvCO3TH5qFHk8YHqFh1Vc2H/NAJHDxBvCnfPhycUX0xE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce688ac-bb6b-4400-e079-08db14308571 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:24:43.7875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YfT58+8xC+CVwNaYV5QPosn4pEm7Y/B12JBoENm/DUhYP8xA4r0GJwJiND3hZIhWwYVbbc5il+ysSV+IhMkSKTgCgbfblhM4MNxxWaRTOZo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5428 On 21/02/2023 7:58 am, Xenia Ragiadakou wrote: > > On 2/21/23 01:08, Andrew Cooper wrote: >> On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote: >>> Remove the forward declaration of struct vcpu because it is not used. >> >> Huh, turns out that was my fault in c/s b158e72abe, shortly after I >> introduced them in the first place. >> >> Also, looking into that, there's one legitimate use of svm.h from >> outside, which is svm_load_segs*() which means we can't make all the >> headers be local. >> >> But still, most of svm.h shouldn't be includable in the rest of Xen. >> Perhaps we can make a separate dedicated header for just this. >> >> [edit]  And svm_{doman,vcpu}.  Perhaps we want a brand new >> include/asm/hvm/svm.h with only the things needed elsewhere. > > This can be done as part of the series aiming to make svm/vmx support > configurable. Ok, that's fine. Honestly, there's a lot of cleanup which can be done.  We probably want to end up making a number of $foo-types.h headers so we can construct struct vcpu/domain without xen/sched.h including the majority of Xen in one fell swoop. > >> >> That said, we do need to stea^W borrow adaptive PLE, and make the > > I cannot understand what do you mean by "stea^W borrow adaptive PLE". Pause Loop Exiting is tricky to get right. The common expectation is that PLE hits in a spinlock or other mutual exclusion primitive. It is generally good to let the vCPU spin for a bit, in the expectation that the other vCPU holding lock will release it in a timely fashion.  Spinning for a few iterations (even a few hundred) is far lower overhead than taking a vmexit. But if the other vCPU isn't executing, it can never release the lock, and letting the current vCPU spin does double damage because it consumes the domain's scheduler credit, which in turn pushes out the reschedule of the vCPU that's actually holding the lock.  (This is why paravirt spinlocks are so useful in virt.  If you get them right, you end up with only the vcpus that can usefully do work to release a lock executing.) For overall system performance, there is a tradeoff between how long you let a vCPU spin, and when it's better to force such a vCPU to yield.  This point depends on the typical spinlock contention inside the guest, and the overall system busyness, both of which vary over time. Picking fixed numbers for PLE is better than not having PLE in the first place, but only just.  There is an algorithm called adaptive-PLE which tries to balance the PLE settings over time to optimise overall system performance. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499105.770132 (Exim 4.92) (envelope-from ) id 1pUWfm-0002iq-TB; Tue, 21 Feb 2023 17:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499105.770132; Tue, 21 Feb 2023 17:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWfm-0002ij-QK; Tue, 21 Feb 2023 17:43:26 +0000 Received: by outflank-mailman (input) for mailman id 499105; Tue, 21 Feb 2023 17:43:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWfl-0002id-Mm for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:43:25 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b356364-b20f-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 18:43:22 +0100 (CET) Received: from mail-bn8nam04lp2044.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 12:43:19 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6468.namprd03.prod.outlook.com (2603:10b6:806:1c3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Tue, 21 Feb 2023 17:43:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 17:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b356364-b20f-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677001402; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=R8QDHo0m146qUi6RWY3MuPvPg92UpEIcsN1A8VgDBAs=; b=hPXoxqcfZjinbduTsnW7yHAtEqgjgLboff2ZLmbS9WG0crsL/ZJsnI3/ mFXvB0BIGNcG9SgGM/9twVrM3v1cSfhTYXxO61EjJa57q2o7OKjR80Dtl 5YVsRRQ+R4N9V6pVwwBaHDRz7HI4MkUlm53JsKDyCFMBMtz9QDj5SfjxF Q=; X-IronPort-RemoteIP: 104.47.74.44 X-IronPort-MID: 97854316 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xRGOBKDDnl8hVxVW/+niw5YqxClBgxIJ4kV8jS/XYbTApDkn1GNSn TEeXGyEbvbZYmf0KYojOYux9h8Bup/RmNdiQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlC5wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5992UGgVz 8AidWoKXknZg+WI6YnmY7w57igjBJGD0II3nFhFlW2cJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK+exrvwA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE17CfwH+gAdx6+LuQ0P1Lonq663wqVBxGUGuAmaf+hGOiYocKQ 6AT0m90xUQoz2S7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjVIctAhuec9TCYm0 VLPlNTsbRR0q6GcQ3+Z8raSrBuxNDITIGtEYjULJSMH6dT+pIA4jjrUU81uVqWyi7XI9SrYx jmLqG00geUVhMtTi6Gjpwib33Sru4TDSRMz6kPPRGW54whlZYmjIYu19Vzc6vUGJ4GcJrWcg EU5dwGlxLhmJfmweOalGY3hwJnBCy65DQDh IronPort-HdrOrdr: A9a23:sTQyMKG7cfZU3Yt/pLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI= X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97854316" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czLfdDv/+3Svu2mAvAjXX4QxDG/6CUfN8AfpYa3ZYGGxObY857hzLjHF4DOfUzPkVximvZJslscVr/qtF3/aGU5Bq4SFMiovJf/9nRceBiEu6rpVeqV9f/fxY+71PBtDBGl1gJpFBnTbaLbte403AI2zNzECDF643bMMY0IxGveXmtf7JNwn388wbJcaYKSOwGZzDsoaa1BNxI8uN+8oLCcyFEwzaZpo6TwKERODAopcANxlMZAWP5TdlBjGARbEdUy0jDwX9m3gUG800dhdDbwAhyaSxqS2Az1J7Rj8tAiukI1rjb/G7QTwShPqnIiitgrwtiKWmtO1soaQplx1aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hmazuq2y6xTEMviGjaNHVe8PmcmurT0Gu1Bvv/fAg/A=; b=UbMdhQIRp0CGCGHgJ+mv+VbDPHigATqRtv9S5VBOEOQPMOOI5ECZQSVNrbpxdRooxrbw3th+omOY2TnDB56m0NOqgPjO0udKUpnID/w4qAxZYDx4RXaTCC9Buy6vXpZERvV/zb3pxt216EfhYLZUa1f/2hN0OSsptVRLKgoGdhMz19rTlRT88lF2nnrgzD2B5e4jx60QRhrrt7VNrSxVAhQuxO4I6vdj8VoW2t2fphG9WdnLteHLFzg96/t9LCtxGNaRu2/i9x5+0wTQwwvz4u0dmdaDuxzhwhhzEebGtl60CsKLZ60z6pSktNk4UdOby9sysKSApWGBcN9n18HCYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmazuq2y6xTEMviGjaNHVe8PmcmurT0Gu1Bvv/fAg/A=; b=VhoPucwmGQ2OA98kcxQSVxSdkn5icGnHMZDQ9rf3t4MKh2gyNh5syan6FEmdAyplZsflliQXKtMde/7ZlRd6UcnNonvgQwSqdQqjAD6rN30uV8wdBmBv0kIqiz222zYDZyYIY89G8/4ktxsUG9+QWGfcvLT7xtcjKr+BKSD1BdM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 21 Feb 2023 17:43:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2 3/7] automation: Remove clang-8 from Debian unstable container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini , Jan Beulich References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-4-anthony.perard@citrix.com> In-Reply-To: <20230221165542.7642-4-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0249.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6468:EE_ X-MS-Office365-Filtering-Correlation-Id: cb060044-5636-4685-d35a-08db14331b25 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Dsj7U6rtF1bj7GQdChq17PyEgMGJd7oEYQa87bVw3EnwIaT4muSlxdI2hep8zOaejFMYSVKbKuLuhYLhn1fW41C1YgtRR/yXc+TSCvi7Ut3HYk+7wMqweeRk0Uq+Z1qmJcBL1ZD9CcvNwRVVUPa6oIStmzA+TobtQid48+u8kuEbb0NAq/Ph531UL2PJry1wb4tMf1M6EwOqMl3XrTSjITAj+tCspX8N+nzb0j0SOaxc4N1rUGCFJwHYDPc24Lr4pm9RdH+mLSkLXf7ua06nNCcynf3gjcoNr9wBfICSAWrFIPqolZRIfGKg9K0QqBnbw3eMU3W9DPeKhnrcafQyCNQdcMqRgGItD3m8hhUZlnt4CsU833enlq5gnthZTnarxYaB6DwxcuvM/bFJFux6kwd9Jb0wnpyfX6FttyZDW/2AJwHWIt4nYA0g1bshygQ5ThCSL3OjNW1ECIz4JmqbgjJk1YNRLYDNAj7yvGYj3tgcRyx68+CV4DGIxU2xd9q1vur+Rhfa29EEQYa8etYFTEs5ykzl0WHN0SOcZdR0Nw2ChZ6yae8xYwR0YNaRZPIP7ktJxCtVUA0UyVbCcgLAtNuZrPOMVBJJIs7nxORbCnGuTvYmtGQXSG/KxCAezxszfJBdVKAAutdmiLcVCq3UNPyPRxOE4MtRiiIrxlv4JXSJxSntqW0c7wAJ4PqS9QZ2/VGCp7BDtlLwBOU8BbJD+Hp439y9pxdv14qtYdd9bs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199018)(8936002)(41300700001)(38100700002)(31696002)(54906003)(53546011)(6486002)(83380400001)(66556008)(8676002)(4326008)(316002)(82960400001)(478600001)(2616005)(6506007)(26005)(36756003)(66476007)(186003)(6512007)(86362001)(66946007)(6666004)(2906002)(31686004)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGpnWWNEMHY1dHNyYzdRaTdVQWpNVkNaRjc1K0k4QmxhMGJKOEh3WjZ1OHRK?= =?utf-8?B?ZFY3RmxmaW9vblJ4T0lzMC8wQktpRGRPZXBVN1JUa2wwaUVZbStTa2dpWk00?= =?utf-8?B?cUJJeDloK3NWaG1nM2lXZFlIbEhadTNHR2ZhRmRoWjFFcVdRUldla0VXR09B?= =?utf-8?B?ZVBadVVpcFhmNmJuMkpGYlNrSWZyTFc1VWo4QXhhWXhQR1Iya0JESzBHazRE?= =?utf-8?B?ZVhFQ2VqaENQYVVaUm9DejF0WkMyMDRYWG5ieldXNWZkRzN6SUg2cFZYNkhO?= =?utf-8?B?TTJwZG15U05mVUZOVVpqUXhXYkFxRHFyUVVlSm1aenBPYmZzRlpHWGhlVFBV?= =?utf-8?B?dHN3VU1rN1p2ZWszZ05jeUdyVW1oVGVvbFlhSStGQ3JIb1NNejczczYxMmw1?= =?utf-8?B?ekUvOFZNWXczc25kZEVQSUNTZ0o4VkI1ejc1SU5jM0V4QWFlME9KT0htbzRj?= =?utf-8?B?ZlM4dnphNkMzcFYzalhpeUtKYis1ekNtS3ByYnRBdDB6YW1tMmYyRzNNcjg5?= =?utf-8?B?Tk5Pc3B2cGZxdGF2K1F1a1NVa0k1N2lCL1o1Y3VYV1FuN1gzbGptc29paVQw?= =?utf-8?B?M1U0SWEzRlRoUW5lUkVJUkZTTXExRG9EeFhxSmlaRHkreUl3Ny95aktpQnhL?= =?utf-8?B?QmVlUzdxcGR1a084TlNlaTNlQm5mYXdZWDlBS3JSbE53cmxGVmkxS01VRW1h?= =?utf-8?B?SGdGbWpwbEh2dXdUZmM0MjdKRkNUWnUwa0QrUTFONG5yQkI5V3FGTG9xL2J0?= =?utf-8?B?VDllb3RnUkFGMzA5WWc0ZGJIWW4wZ2dsRjhFakVJV0d1cUJRa2VqMFVkdnFG?= =?utf-8?B?blovSEhVYXAvN2FVbVhCTFo3MTNsUnJHL0Uvd1c3ZklhUG9NZnR4dlVBczVv?= =?utf-8?B?d0JQSVFOVS8vSjZEMk16RTZ0aU5zTzJudTJ6d0ZsNnpNMVZBbU0ybXNyWkNE?= =?utf-8?B?SGQxeS9nL0RQSjhCeE1yaENENDZhNGduUDcrWGwrWnFjaDRESWR6VEJheWNv?= =?utf-8?B?ck96NStuR1NoUERqMzJxV3hIMnQrdThmbUtFcWtpWVdoWXlHNlpyM1JtLzBm?= =?utf-8?B?WXBWT1V2ei9VMFFhWml5Y3hMVFBGZmFLQ0Y4MERmY1FrdEhQUlQ1d1ByTVFN?= =?utf-8?B?eWpqRDdkWkRIVytOcEhmY1A3bXBaZEhwbDAwbTFseEkxZ3RXSTdvK3N1Z25J?= =?utf-8?B?SFd4a1M0bm9EeGViSmlUWjlhL1gySmRUSSsxM0VsNCtOcGlIQzU0VDBUQzlz?= =?utf-8?B?Y3EwangzaTlsd0hyN2RUallTVURsQ2R2MU1OTTNYeEJDRnVuYUk2R2cxQUQ5?= =?utf-8?B?MHh2VEZNT0RKMW5DdXJlbXh1bDNtc1FoRlZMUU14WHBJTFM4enQzWU84bWFJ?= =?utf-8?B?cENxaWhyTWszK0ljVE9mcXBKNS9lcjBiMHdYMzVNa3BoVEEwQTBIWm1YSUhm?= =?utf-8?B?dGQyUnJudVgyclZLT0lmaFQ3Yjc2a0YzRm83THc0NTB1ak1NdjRETFJDRi9z?= =?utf-8?B?MERSekd4Um95Zk8xcHUzTmU3c1dYcExmUFpWRDdOK3RVaVJMVUpWYUZFa3N3?= =?utf-8?B?NHNRS1F0RDA2YS8wbVdPNHJuUk5KZys0emF6YjhqcmhGM0EvYWR4YnV6RjBR?= =?utf-8?B?UmJtT0crbEx3OUw3dXozQTVpbmtWa3dOdEpGTWltMzJuREFmWmpINkJjZnl1?= =?utf-8?B?U1RXYTUrWFN5WE5wRzBmbUJQZFF4Mk5Jb3JIL1JMcFBBcENuK25mQkFPV2pj?= =?utf-8?B?YTEzU2o5bUlSckZGblo5eFRHajUvdi9BcFJNMnUzSHQvUTV2MXNzOUdTYUVh?= =?utf-8?B?cHE5UmxEeUJQVU1pSTRkamNpN21POHB0dW5sZjNNdTEzN29ydDlDZldmUGJQ?= =?utf-8?B?NU9iZmpid0dOWmpScEs2cXBsV2JZRHJ1TEVJR043RjhKSHcxYWc5RW94RWVR?= =?utf-8?B?cXZPcWhybDlWRHp6cUoyZ29adTdJYWdhWi9qTUsvQm4wKy9LQ1RTckFCRmRu?= =?utf-8?B?WElJMUh0Zm4zdmpRSHlpSk4yT1lZekFQTFMySDV6Y0ZLbTBuL1NQN2R0a200?= =?utf-8?B?aGJNdDMvQ3ZOKzRiVmhuaW9Ta01yRzB4QnhyMXcrOFJtMTFzbm9PRVFlN1Ar?= =?utf-8?B?K1pYQnBwbGxCRE9OeVo5Z2I1TXpyNjhPZ3Qxb3UrZ082ZGVxMXZTem1Tandh?= =?utf-8?B?ZlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6o5Nm+zf/vqj1QS4+PXaVo22nsIfffvn/9jKLhMbEttMxTiPjtTlX11LDZMkyAwkKI+6hoVYTtxYETu4zlMKtDmVjbEAJbafBcSJJNmZe+ikKeAiWo8DIrNG2Crs+a8Klapp9NU5Zizh2ZJI6eC7PDnz9lKq5nK0wVLjGD+K8W3FnFIuWHY7nYy8qmXW1NpjP/MQiIcqBqwQH+fFkEn5pslYT7IZR3kAga1nDu18N8qU50ExT03VGIzea/BZ08PKZwNd2820Y/KriAzU65l5XA87TykD0LP+9G79gEJTo2HmDudpunko8YIwcgMNPo118nsWwPfDzRcTb/OC11y2bsKHDo1UoBfSsXSjEuisArN5lox3v1+v96Lwf+kIyEov2Ti5yNAAfy06+v6wmr9V1W7KKL+4aYcK75bEHgQfUYTewyuPa8hi3Mtn5CH+IiosHPwHsf4UhyjNTveBlMb0Q8tOjnVU3UD7jVkqy1fYRhcWk2zlbo5hti/LhbdPZ1T4JLESlA2QYS7UHUzt8aLW1LfVLsgxjclqLfryyd6ziRGWbDlFHMHEoxCAmd6kjOEwnwI3TzlPs1TOGfojuOsvKAR2YNJCasWtIyuG3H9CCL+Tachoefw4v53TAyIUn8ZDqfvy612uOh533dS1xtszqmToaDtTWEzBnKXzuw9Mo15l+Kp/A5cuJ0icdiSfkZveIkT+NvTX7O+Wn87+YGO8DltAxC/GRe5d7Xj2BUCMvne4x2MDTTYsgjeXR30/o5VEfIJYkYDdu8Kh1xiln6PazMZ1QQ0B4So/XzLDUDJYv1mUOJvMcJ/+E91iFH4LCWUvl6rBXXsu7K1kbFrvkmF477SsUqLgb+G2fNXdd4zNFao= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb060044-5636-4685-d35a-08db14331b25 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:43:13.7220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gxZOUhKikfcLsXUvstq7+oqWUvN/Xp+QutcDlyrY/2ElVj/I3oAy94/TQ8Hgb5xPegC1vCNnKXGVKYe3y2addBdjS7WnmP+VCQGBCfRo1Uc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6468 On 21/02/2023 4:55 pm, Anthony PERARD wrote: > First, apt complain that it isn't the right way to add keys anymore, > but hopefully that's just a warning. > > Second, we can't install clang-8: > The following packages have unmet dependencies: > clang-8 : Depends: libstdc++-8-dev but it is not installable > Depends: libgcc-8-dev but it is not installable > Depends: libobjc-8-dev but it is not installable > Recommends: llvm-8-dev but it is not going to be installed > Recommends: libomp-8-dev but it is not going to be installed > libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable > E: Unable to correct problems, you have held broken packages. > > clang on Debian unstable is now version 14.0.6. > > Signed-off-by: Anthony PERARD > Acked-by: Andrew Cooper > --- > > This change will break "staging-*" branches as they would still test > clang-8. So patch needs to be backported. (at least build.yaml change) Well - it means we should backport this to all trees before rebuilding the container.  Which is fine, but we need to be aware of this going in. CC'ing Jan just so he's aware. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:50:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499119.770144 (Exim 4.92) (envelope-from ) id 1pUWmL-0004dM-Lt; Tue, 21 Feb 2023 17:50:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499119.770144; Tue, 21 Feb 2023 17:50:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWmL-0004dF-Gq; Tue, 21 Feb 2023 17:50:13 +0000 Received: by outflank-mailman (input) for mailman id 499119; Tue, 21 Feb 2023 17:50:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWmJ-0004cL-BS for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:50:11 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2dcdfa78-b210-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 18:50:09 +0100 (CET) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 12:50:05 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6357.namprd03.prod.outlook.com (2603:10b6:a03:38c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Tue, 21 Feb 2023 17:50:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 17:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dcdfa78-b210-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677001809; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=GMN6LHchYXPg04l7Sv0xrPy91abE6HYskkMDgI03Hgw=; b=M2XbUgqZyStJph7BF5ZkkLsa+DzyYTRM6NMbbgdUt+hE37QS7ownwUkJ sy1Fp7rtSqZQO27lAc/t6HJHYXEvEakYLRKA1L1jdTpeO6a4JUp8zCe9A LRdJam9EkBB7QPpKts3TI9ioy2sjhMYGcnDPGi/+wUajDKzLa9yEhBteF U=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 97324379 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ITEoY673phvkX0VKeid+TgxRtA7GchMFZxGqfqrLsTDasY5as4F+v jZKWG3XO/eCa2OhfIh/a9uwpx8P68SAx9FjTwZqqypnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR5QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m3 vM/eWAtMTm4je+Mg+3jCblhpcsZBZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+SF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNNT+fkraE76LGV7m8qLSwLeQO6mr6grkCMY/xcd GkSxCV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc9TCYm0 VKhlNrzCTti9raSTBq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kOYgnnS99iFOu+iYTzEDSpm jSS9nFh2/MUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:Aeh/36Cz6KW4+O7lHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97324379" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/6QSn6ve6w/qRvpvROddLcm4f1TxKmlE0Gk1xZZupJCPg3pMRU7de9EGaL3N7x7LI5xMkVGZ3FgbfJld+bRTGgUqLc7v0MBxSPERl1FNdeMyaydJG5cqNZGjDcNEg02mekAHTsmViQuppxWoA9igJ2kYBPvFGjq0QcB4aulzq8EzZxMu371VahUpNXL1tJZ6aDOx1f9nNkw8rNAZSANmwikZyr4pbDE+7vx1uux3wZyI2ubOo/KqkWtkTXlejbSNxBVDuw6Z3VWhHC/CyJZoVFYDIY24uGt480egPLN7Ztc+kkyiLwQA9OSu6AJaRpNsIKSvby2/jvgFbgQhJqE5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GMN6LHchYXPg04l7Sv0xrPy91abE6HYskkMDgI03Hgw=; b=ITVrHhrd7jIAMFPagyn+us+mU8fsPnik+vS6B/VPhS7ZrU5DPZes8YMyyfdFW3H6TSSm3b8JpZw0QVkF3bXpxyxjAlb5W1rUsql71KVw6ZzC0s8sx5Sbp/boZbGxx0jJIuYPglxsoQmisSEHvqYCFpcf85IY+38qaV6L02+7gxEIiOuU+oy8NQk58S4K+oAAP0zpEDSeNIo/N5aAVGFxAZsVOdB/RWq31lEqbzxcomOHwvT6jYKmepJ9Ya4xayyGProuZTM5Bp+08kNBeUdabUqN1XcNwxIjOq1UMGKAARqArc4OjwP1W2RD7EgGBoU054A+z0vTH9Phd/GY19dXZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GMN6LHchYXPg04l7Sv0xrPy91abE6HYskkMDgI03Hgw=; b=Ag+qMQOacoHwisC6Tgxvn+om//rDBT9dQgLFLKK8Llk2CSizB5FxjatpLFTa9+Un5FsSGeNTmd/zQRs5OHtmmpORd4+3CMJP76yJ4L78VykMRR+zU5P2sXfGRIcHZm6NgPbVSf/ppBK1iFZYsJOzy6f6ZgRJwI6Bxipb31MMSZ8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6ae598df-b200-d20d-85a4-183200048313@citrix.com> Date: Tue, 21 Feb 2023 17:49:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2 1/7] automation: Remove CentOS 7.2 containers and builds Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-2-anthony.perard@citrix.com> In-Reply-To: <20230221165542.7642-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0131.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6357:EE_ X-MS-Office365-Filtering-Correlation-Id: a00e4692-c434-4a9a-3b4d-08db14340f3d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HCzXT5tEesZN9CpestJTVK7jidZeGta8Ey7Y80AASviHi/Uj137P/9LqJmCUG6SK9/7VHGDaIUPkp+/oy7cT3TB+8qf4kALtvxdjEebsg40hmwiRrI4g1iFXW6j27mtTNl0sCrnocxIMNYWCPqje5OsMe4cEEuxy62YSOZ7hza6HRosDyWEpZEbyU/dt5y4IHrFoM43MnaVdhqshk8zt7Ej6Dmwf6OF2Ck2l2BBG8yWH2HMhTkdgZdElLDkKEntrwaa/cgEH+gE2izmdPQufy1LpmIvMdR9iuxbQHaR4maiuUaoR5ccyEK+YdFbXwMFW3nmt4PyCNV7+qROYcPulamaFcdLc8kenQ/VSIzwCbhYyrO9TennWwR15nPayVgQ/psRlpoF8oZMxgxUxWujCwm6ho7usMrRPa1s0uDIlyQ56yDS0eBHsl/OLkY196Nqy9W6TQ5nmPUeO72OJ3cfe/rWr/sCsiUvypmwgjgEsdNyvDQFjQnzI0Q0dMZA7Uep+A6lqFd0pAOS9SBzPHn4jR3jd0dF2+DDQ0tPJaL8qXdPuMBiLobPkOtf5g7hAvg1jcogDVdr3xUaJEYSTaRhtTQ5aBcT4VzWn9m1utTWZJo73t+KgJPeFN5/1tsQLHWk/Cys9Ua1NZs6zoVDN6viKaCDkr4BoajHpQILmLRUT6T2OlmzM03PbkKNSLAzD6IiQkvCCRzP/B+iplCDaRvNbD3geGwHzQdYX3GO13Ab59Tc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(451199018)(66556008)(8676002)(66946007)(66476007)(5660300002)(31696002)(316002)(41300700001)(4326008)(31686004)(2616005)(86362001)(186003)(26005)(6506007)(6512007)(6666004)(6486002)(54906003)(53546011)(2906002)(38100700002)(82960400001)(36756003)(4744005)(478600001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZCtienlHQisxUUdDYm44NHd2cFQyZTJKTklpZ3NPeE9USWU0dlVFckdtYzFq?= =?utf-8?B?UFFmUVp6TG0rTm9oVEo3Um94SGwraUJhUGNRSnFUeE8wTFJFbmpMOHZNQTFG?= =?utf-8?B?ZS8rVHErUjdua3ZDZG0vYm96My9oZXNGcWhuaHQ4RmhodFdVWXVtMmZKVUNr?= =?utf-8?B?RmF1NzdVRjlNdXUyKzJvRnd0d05TNmlBWkRxK0ZiTCtGYml2cm9aYjk2T0Nn?= =?utf-8?B?Z2Q4TjNFbEZ2NlBmbUVHaFFsOGVrcmVTWlpzdG5wYXd6L2tkRGFoSnJKS1U5?= =?utf-8?B?cDRKeHJETDBubEtzdmNmVEVMeXpodXhEL2JyclBHOHBJUngyK0RWQkFsOVpN?= =?utf-8?B?b3RGTXhkak9OQmtIbEQ5aWRjaVp2TDFhYk8xQU9wNlZPaTU5VW5LRDdKY1Fo?= =?utf-8?B?U3VpRUlFUDJud0pWZDUvL2krcDFzUzZwdFdSN1ZTV3FaRmlGaTlvNHFUSTZ5?= =?utf-8?B?TUNUazVsbDE3RXNWQjQ1amRlakZYbURxSUpGNHpaVFJ4TFIyQ3o3ejZabWxh?= =?utf-8?B?VU45d0ZHa1habTdnSGtKa29xWU1JYzVmMEI3MTBKZmZsazBXaWYvWE5ub2d2?= =?utf-8?B?eDQyK1k4SGRLbjZqOFJGcG5yTDlmR1R2VFY2Vm8zejBobkptQmZJM2tsYXlV?= =?utf-8?B?QkdrRGFBdGxBa29xN09FaW5jM2xMOXlpT0xvZnZpK2pIeTFHTTc4bFcwZ3gv?= =?utf-8?B?NGtIWkVXamIrL2R0d0kxdkpXV1dWVU1nU3F0WXZSVXUvdkRPQlhoTDh2VmJx?= =?utf-8?B?VHFhQWVubVlxRkxMTU1raFltRnNUQnBMdWlqMW1GdGUvazZ1NGpoQ21NUGtW?= =?utf-8?B?ZzVmNmFzbE03S0hjb3cxanh5Q2tVYzFnM3JrOXgyejJjcjZmWll5ZVlhcERn?= =?utf-8?B?YUZYdUlzd1NFTmFzbWE4QjlQdXpkTGZ4ZUxrWFlEQnZMU2c4U21xbFM1dW4r?= =?utf-8?B?WU1MRGpYL1pEUW1tcXdGOC9kck5Yc1RpZWNUQk9YcWdQN2dVV0JpcUdTR2pl?= =?utf-8?B?NWhBVkJDb1NKemgwN0RLRzVDdTFXL3Z2THlZUVU2akVvOUhJTnhheVJyOWRR?= =?utf-8?B?MlhwRjdlZEI2U3BsRU0xM2pML0h5QWwwTlEzK2lvRmNZQjhzZUplMlE1WFB5?= =?utf-8?B?Rm4wdkNORU1jZzlwci9zd1dNUmRtUlR2WmpzZUlxOFI1VjBmNVZ2Z3BWMlBw?= =?utf-8?B?cm9zK3NTT2krNGtDZlh2cnNpZmFpSmVvemRaSGhhZUZLV0NBQ2NXK3JxbENj?= =?utf-8?B?NFFhUE5WRXVwUUN2OHRoRXNublZvSTVBWGttbEIwR041UFlsV1Nub0pJQ21n?= =?utf-8?B?YllvdjNuMm1RdjJmWkFMSWRjZ1pZMlhqMTBaQlREdElWTmgvby9ON05jaTZl?= =?utf-8?B?TjlIRjZtR3NzTFdWRDZQRXE0am5kKzF0a2Z3ZDdiM2grNVFQUFVTd3ZHeXQ1?= =?utf-8?B?Zms0aXFmVkpEMUtpZVdCYm9pdC9xQVNLS2MybmtURFdPeFJNNmo3OTk1NjBF?= =?utf-8?B?cjFqZWVTSUhHcWFldXNTeXRNUkU0K0hPYnJJK2RLQ2xNeFNjNEw2T01BbFpu?= =?utf-8?B?bTJjTXoyRGNqRTQ4ZTkrM1Zaa3pQMGVob05sTGRzWThMNWtiN2o1ZDJlK1VQ?= =?utf-8?B?U0V5V2VHZDZHWGt1V3luZVBNYXlLcVlWR2FYaDJpaGRsQUk2MnZxS1dvMS9N?= =?utf-8?B?NXlLSUlSTkJRUUdpakJmb2haQmwwQTNiUVBWK2xkcGFFSm9PRnlYMHFrY2tj?= =?utf-8?B?alQ5ZmFhZ1VVSk44TG1vVDZVUXUvaXM1aXh2dURYVnZNdEJnc2ZaQUpmckZX?= =?utf-8?B?Wit2OTdjSnc1OWVHMHJhV3hSaENBWmZIUjlDSlBMclZQYzVwWnRSSVhBc1Y2?= =?utf-8?B?YmtvN3U4djZidjNWdjluamg4OFBiSW81bEE1M3lBb1BaWjFzM1g1OEdPVDNl?= =?utf-8?B?dFd3UlRHM2JkdCt1b1BFSTVGWTRUYjN2LzNsc0RETmJ5U1IxYVhTZVpRUDlO?= =?utf-8?B?ckNwVmRaTjJPVXAwdStBR3o2YUpteXllMkZnMTFBZDlPbkJFUzFZYlhxZ0ZD?= =?utf-8?B?aytVcDRtN1lLMGUvcnoxbFFwV0ZHMk1KMjd4Ym5Wbmc0RjF4bFBHUDhXQUdE?= =?utf-8?B?TDdmaWhnQ2pvZjVmYStidnl4VXhRYmJ4Ukx4d016a0V6a29RbWl4VEEyMDla?= =?utf-8?B?UVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: khnlGZcgSOUt7wkSftMdQPmw2ZZy2KlxpNLLhOCoHW1aiZvXQF4G5Dr2Sx+Bs0aGkZ3vQBk3BB6OCxJwNl/zf927ichPeqyLnKaquw+m6OfumHA15n7DD88lxybqCbsow/nLav30U7F7vm7N2PgercLz5WvlH+DSEYH1DfwicHEzLGpq6rXop3GRDzfWIgPaV8ec4xl3UqvqwAwSQJ0ynPCImf/R/53NUvozylm4b2MRKjFjuHYZ4OQBBxcEiQyk/iWOs3RhI3vvVV9GPqrLt205hCc5kl+kpCahOtauM0aLYc6hOb5NffbWEY6+vpLBbwFFpyc20unqG2A6k6OXJnx1iW7i+y0DmRBX3ZOGXZb0c5rW8sRxSnEWIygPftiUEGL53YNN6U4NC50p4af9H1EIZOd+oFMv6AbnSYH8vQuIrIkTGwJhDLcRQxjgQtDxfZuHehh+7wlbCPkZte+z8BON1srmKoKRHJxDnUMWXJKGPZ4hYkh/Btva5HJKZ4m+hgRrGoVYrA6S8b08IfVFfLZ/U6t6n7iMpx+OFKv1tK4o/z0KdC6SqdBQ5LooTPCvVi6Z/ppzlH7TnMMrvci+Ak7DTowG/o3oHWmbZzkJyXoE0MK+wIsl2cTwG1G5LBfoLwpz1D3uYXvg+gxrzD1BDKGDj+kyqb2FT50HVy/Mte/J5cxaAp/pq48fcZ2xg04173ITeqfWEU3fC3JSX15a2AbrZrH5tNGZlRKQNC17ZqIQCZWLUKklSpuO+OKYYMeFTkBXQcrURdXC2OorvE57H0/0GcrOdR20D6C0cD+TKPm5KHXZEH24a/3XTRAhRDtW9o84DefJrgspuafDlPkEhw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a00e4692-c434-4a9a-3b4d-08db14340f3d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:50:03.2864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jsG6EZyRcJfHl3NjdEwsWU5t7irfOwDYVEk/svTFO1rLSl9pn6ecdSTunIvQlH3ziNEKfJ0rucucdfEPhtuB8SQXcUjPhbaj0AeN9Igl7nk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6357 On 21/02/2023 4:55 pm, Anthony PERARD wrote: > We already have a container which track the latest CentOS 7, no need > for this one as well. > > Also, 7.2 have outdated root certificate which prevent connection to > website which use Let's Encrypt. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper For posterity, this container exists because Doug wanted something which was roughly a XenServer build environment, but we've long since moved on. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 17:50:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 17:50:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499124.770153 (Exim 4.92) (envelope-from ) id 1pUWmw-00059g-TB; Tue, 21 Feb 2023 17:50:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499124.770153; Tue, 21 Feb 2023 17:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWmw-00059Z-QK; Tue, 21 Feb 2023 17:50:50 +0000 Received: by outflank-mailman (input) for mailman id 499124; Tue, 21 Feb 2023 17:50:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWmv-00056H-F3 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 17:50:49 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 449981eb-b210-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 18:50:48 +0100 (CET) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 12:50:44 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6468.namprd03.prod.outlook.com (2603:10b6:806:1c3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Tue, 21 Feb 2023 17:50:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 17:50:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 449981eb-b210-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677001848; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=zdYggp8u82TKz3KEBuAEBqRY/yrwexK7KR4ocMV1INQ=; b=Aa2mPQlhb44H6fGZTWsxS7hnfqYqpJ40HaUyswBgqbG7yoP+USm+wFKM HYWl/aFkYz0uFtnZnFYwdP1u1NtZorV2Y5AuS5OaVQnaMDmXtI0B0yg+x jlrdEs1hEFpSBOZO85bNHm8DhjaoJQtWH+vODGx7EQDuVBthK5WDPwR0/ A=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 98349198 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8CEKxKqEp99hEhIuzYunUyC+EdteBmIuZBIvgKrLsJaIsI4StFCzt garIBmHOvbfNDP2eNx3Oo+19kIH6sTSzNJhQFZo+Ck0EXsQ8JuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSBNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAwUST+ChcGQ+ZSmRO9lq/8zF+rGDbpK7xmMzRmBZRonabbqZvyToPR/hXI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jearaYWKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXppqU20QTClgT/DjUrEniLn/aJu3eSdNQGM E1I1hAB/fcboRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC3 VaTk9TkLTdmqrGSRDSW8bL8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nczp4OKu8j9mwEjapx TmP9XE6n+9K0pFN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:KVaN4qr8PgrOOiIzUqzbyfwaV5rveYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafN5VoRt7eG3OFveexQvOVu88qT9JjjJ28Gd3APV0n5hT0JcjpyFCdNNW57LKt8Lr WwzOxdqQGtfHwGB/7LfUXsD4D41rv2fIuNW29+OyIa X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="98349198" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=COgnfi1zKMPr4e2m+n4HJ3gQpYDBUgZNT6+XYqYDY7Nj60FTekjbEPvJHpNejdbhO/m9W3WaNCUBCujjCjr0rUbMws964vtpckP9cqXj882tA1sVivMk5iYiTgOeD9agGqMmw5pMc/cAUw/9p9SN2ZvPWG3lHHgOzTJVKfU9jockMdsPRFFb2XUTXcpxORlGLWifGCk0DfQY9BOgl2lPT5PzuenbmPsI0srFixMqRnxPWgEGj3IWODiY0jmHfOU8wOnYRQ5lid519bGiWIrHRdi90R2nu1u4UmJpicPnu7LUzxY5N97BoHhUIxQTlvYXcfr/5NOpGWr5dKlTpsEI7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zdYggp8u82TKz3KEBuAEBqRY/yrwexK7KR4ocMV1INQ=; b=fbdck5GThD9AAetVWU55BQXZ1BG8zw8D+T0YS2cj3nyNPFksn3EvIgw/H3kv6narqjWVU+bkCFZQED3ISuCp1ZW8bkmfyy5qokr8pp2Q7msj7EudY0GJOr+kqNiLHfQtDkudRbmHiggGRbLCK0EY1iTZtKmUT6FNMgq1NQ7sOEopNFu+N36GAgdpjVdn0udgt425PK611ayFwcyePqlUr1BL+psL1yUmfCMbW1jCwdE1ZKUyo59E9SFadEYVKaLzabkzJALQEKPakhOtBGozrpTFTiNF5HimCdOUM+WraOLgCGAmQtUwL5l7biHwQtDarUA5n7LB78EOXosIYu0vqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zdYggp8u82TKz3KEBuAEBqRY/yrwexK7KR4ocMV1INQ=; b=vh+acLp7TG4n721NwzhYvXV19k8Cr9WmslydMHVLL4l5i0iuWQcpiah7J0V+1j7fv5ePFZErGwwgdj9xRF6/+SC/EAAS/XD8z65JkxMsYiGa8qYvxXQbsWxpxvbNnpC5gH7F5GKava8VtxXwOBWZ9lvQ0/XgdtzCZx4KBvr3YMc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 21 Feb 2023 17:50:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2 2/7] automation: Ensure that all packages are up-to-dates in CentOS 7 container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-3-anthony.perard@citrix.com> In-Reply-To: <20230221165542.7642-3-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0130.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6468:EE_ X-MS-Office365-Filtering-Correlation-Id: ecf5bf0b-bd69-4deb-5055-08db143425cb X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uJ9ApcR00790HiVNSSrJAU0U8HMfBitFh556hD7ql1V/td/Kw0JomkvmZK2OaBWmCRMnxHv07CvhDwEM/QaqpvKu84eB/xmcl1ohC7JEPgxy0nNwxCSkfPBmURPGttl2ZEf45GFS3p+MRtXu9ffO1/NWJ1lubnBPoHJnOIsfzzFIPLaAEGhd2ugUElijlcqJsCH+h3mEd88TKJFW1gMUANs7p0Km+BzqTormTTBbPDxBkF6duwgYUe4dQqi/VYcHhli8GO495o7b7jsOalJNSt4cWStkvN2z4eyKbSbEfioaq0Ex+SBHMjRFxwoRsD5HBFE0WpnAXFlPCQ9Ph3TZ8xo4LJszYWQKEsxQJbFzku5TK9nSqEpwjoW65QO0jM7NF9FQDLyXxETKzWKAlddPHgbVLnGyhSxyiYdHk4iq5dwkB1ZnU1L5JMcQ6A3XOMKXbLT0A8wsyX5SmHX5yYNFd9qmfSngFnhbN4OvjYGB1zsQnYdno4UlOazWzt0kyBdK32kkn3Yp8pXQjKMvysOTKdC0XsldztL5hbHT/OlTadpIMbS/ZoqxSSBEN/UtRRpE1iPKR3NvV/GWBWPP2V7axXZ6XtPqaOK0ttSSms/13NEQRq9QKulwzfDVGLswSrNSQ/aD5TD3T3yIxoc4v3MOkmvLcnDRR9oSASsrnBxUXoVb3lK9oK74YKV31lTLVrkYY6+XrqwT6TAwoh81Y1U5SK9Y5F0rMxy37+7zWxjaRcQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199018)(8936002)(41300700001)(38100700002)(31696002)(54906003)(53546011)(6486002)(83380400001)(66556008)(8676002)(4326008)(316002)(82960400001)(478600001)(2616005)(6506007)(26005)(36756003)(66476007)(186003)(6512007)(86362001)(66946007)(966005)(6666004)(2906002)(31686004)(4744005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXVoYWl1ZmFIOExvdXB3L0QvNEpqWVMvemc3eUtUMUhzZ0VGelBOV3JqVi8z?= =?utf-8?B?andOY0xYSStEekM0VDcxN0dtTGpOZkh6RXBJbXVLV0J6TFdOL1MrREdoY2lL?= =?utf-8?B?ZHJzR1ZLa2RsZWVScXVqMUZnSmN6Z0M0M3dUbmtwUU5yMDJyK0JFM3dEMjVV?= =?utf-8?B?TzZHOGRneGMvdjdGT2JwQUo3a1gySkFFelM3aC93UVY5Ry8vZEowamNYblBG?= =?utf-8?B?elZBblhrUUZhRXRYZ01GVnVpdnVZbXBtR0Zoc3dyZHl0U2M4d1JjbVRBUFRN?= =?utf-8?B?ZE5NekVKMnB3WFREMGNRWlYvK2FENDdvSHNGMEp0VlA4c0hBVWp6ZVJ5STZr?= =?utf-8?B?YXQ0Ym5PUmZOREdRemh0RkplRE5LU0xCOG1ja1NDa1lDS0QxTE11d2p4OUp6?= =?utf-8?B?L0RKVmFWTmk3d0pqSUdZVXV5VURMQm1Fdi9sS3VacnoxMEhSZVZVL3pyQkho?= =?utf-8?B?L3JhZ3pmckk1Mzl0cm9yUU1JZHYwcTRSTmc3cFM3SjBPeGE3UlRvSENoREdK?= =?utf-8?B?bWlZR0FTNjliWmg1QTJISUZmNGV1emdscHI0TTZXSWQ4V083ZjdwOTJyQkg1?= =?utf-8?B?L2NMV0JVM1RwL0FKdXpFRmxxRlo5V3FVb29Yd21GYTh6S0V4SFpwSnpjUFkv?= =?utf-8?B?RjlvVlpBVlNCME5LcUhyZW5vOExxanlWb1NrT0x1aVBrUFFzWUtQTWNndWlz?= =?utf-8?B?dEoxYU8ySlJvdEVRbXRZUVgyVmRncVpSeThIa2NCcmdHd1pQWVZxY0JsWVJI?= =?utf-8?B?WHg3b2NSMkFuWlhqWERCOXp3RFJoVk5BQlRNckNqZFRBdnZYWjIzeTNTd29N?= =?utf-8?B?dHBTWmd6Q2E2SExnc3QxSlpVdnpKY2tqbCt3QTR0VEU5MFJvSkVWVlZpRS9z?= =?utf-8?B?Zmp0Mm05d2JYa3U1UGpKYUwyVElxMXdHV2xOamFJTS9aS0N1bUJ2VERlWHgv?= =?utf-8?B?ajVsYk9YZCs1Tkp5Y1AyL1IyYmE3OGx0M1NBOWxwM09xSm5kaTg3aGhuS2dw?= =?utf-8?B?VjFhY2F0U0JpY2dybUVnaENybzY4d0Nad09nV3RQalg2VDBqbTQ2MGtLc3JL?= =?utf-8?B?ZmVrYjFWQkhwOVJ1Z1ZmeTl2aDFKUk93b2YxeE1hUXF1V0lmdnUzSHVzQjN2?= =?utf-8?B?ZkhCZ3ZkOHN0NjI0SEtPc0tBMmVMZ2lLd0NBOTQrdWh1dzhNcnF3NjZRTmVK?= =?utf-8?B?aXpTT0hidXo5c0RBZ0ZKVUpoQkhaUEFvckxRejZMZktzdmJDMHZiT0M2V0Rt?= =?utf-8?B?clBWaU5PQzBaS3ZYM3B6ZFJVL2czZ0FPWlNFS3FETzlzVHNpU0VJeEFvbTh6?= =?utf-8?B?NHpWbzcvM1lLc3FLT1M3YWxHTEZ0SlFLeCtzZkF4OS9VN05tTTJHdkJUREJn?= =?utf-8?B?K0F1SkszWjNXS0hEamF2L002c200L1JRYTV1d0tqUFZ4TjJ4UkQ2RlRHS2xl?= =?utf-8?B?MHVyWUloekV2OElUbWZkaldxenJua01sTWQ3Y1JaZHhaK0ZuT2ZERGE0T1pu?= =?utf-8?B?YlBBamF0T0ZYb0pBM1haeUdLaVplQnpDbWg5QjJKSkdydnNRbFdId0RWc3BT?= =?utf-8?B?dUlzRVFzQ3l5VzJ5TFZuYUtRRXM2aGE3T1BtSXZQSHd1aVd3QmdJVEd2MUVp?= =?utf-8?B?dVlLSzF1M2x4c1hxcVZPMjhrUWdFQ3pRTFlWaUUwL1g4SnRodHBveGM0RzQz?= =?utf-8?B?b1hlKzVpY3ZKaHhvWXpNR0xLbjIzNjZReks2NTlkemk1eFpKbzN1ODVXNGxk?= =?utf-8?B?d2pYVDJJRnhGSTBHZWZEa1VidkRYeXl0aXFWZ1l0RzRla0RrK1ZIanNWUHBh?= =?utf-8?B?UHdpZktqYmtKWExUOVJiTFV4N1NzVnc0RXF5aEcwNGFNNE5HRGlaaTJ2MjJP?= =?utf-8?B?Y0x0ZHVXK3pJczY4OHpmSXBXalowK1ZnRDl0aFBnUUlnRWw5bVNZVjd1ZmYy?= =?utf-8?B?b2wzczFwZFNiVU9iV2pBV0lsT3hJM2doZnA1WnhlTVRLU1B2czdzcXgyRi9M?= =?utf-8?B?dkxrSFl2TjJscGVNcXVGM1dZSnk2aExYYkxaSWFPYnRTSFJ6aUtNRklDM3RM?= =?utf-8?B?ZUIyc0oyUWJ2RityUDFZUlpoU2FQMXBScjh6Q3UzdVFjRmRMQXVGTDQyQ1Y5?= =?utf-8?B?enBobXVRMkMrTG5aeldic3hMOXFwYXJFUUFuQUxFMzB0aDRPQTBTUjRSQ1dF?= =?utf-8?B?OHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QWGfwQPdGWtvTjYYw/ZcpAMYdOTcxOzwz/CW4zaQra47xI15wGfLeYTK1ZU7pMgvntt6nwQC3Szut09/K3YwRS5YjO9UFZIAemPq/OVFMo/ZPHTMjkCUJsngHYkoUWIbp6VFceLatAJhsW3HFiqGiDLnew5aOyf14DdgXWtNW0R+XlUWzwAP+4IuM5GcaatBpOba8bDESYUJKT967oFWtuYpK9RhRH9Oju9x4sCQHpOgpjNWasael5CZsMrnFKI8jVf5nfNIhr66eBMFjLwkad0R/YlZL0CI7fPT3VfExF/akiEsoJ1Z5IUgew9Se1lkN52gqvMUiCzYfYSrsaJU2kod9kMca3PpTXw17qsw3eXNm6hRRKtcEWATRUkR/hiI0dfh8Yvgicd/vCfeOGwtasu9/76dVAtMbyQd8MDQKS2CS8HYrspf1Kw0QnwRr5l/ExS7Z6IrhEJNoxILlx/wYI9U1byoKDWSOyKG5+9w8IFmW3A2QSdA7tmef+HSZTwbhTOyaQJcbC1Kub2XIMVKfuyLZq3PBmRH6qFtUggobUFy3wTmmVdkWmTP39y66zG7D1/KD88VMQhewYwzu1Qz9sy3QyrQQy8V9/tvE+u5DbwFzsh/Na/ZDyYqKcRe68UQo9QSmlq5fviYlfYyiPG3YeCd0k2iNVBu51rx894qOeWGPREdnTVIEwunz6fIR7txjNMTkKcYRAqUtB+NMjrcj2dG/hZ1/okKZv4a+SvUzJC3R+ey7a2HKnv9EiObVQO9vk2uWsafyBmOgscBTJRyIvY3ExBwh2dhfbLARUQtYWKHmjQucbSR8iBbNQmBz9VNweMJC7jXZ+G90k/F4USElQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecf5bf0b-bd69-4deb-5055-08db143425cb X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:50:41.0961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wTAPSRqonC+CMNBysElIFHSBfuqixnvJtfjdF2zcuGNYcRsevOEG8RSEOGUTP4+jTJXQ2nwz4NVBFu5hS7klYbmI9O54nAdZN5H20jRgPBg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6468 On 21/02/2023 4:55 pm, Anthony PERARD wrote: > This was prompt by the fact that `wget https://xenbits.xenproject.org` > fails with expired certificates, which turned out to be an expired > root certificates. Updating all packages fix the issue. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Feb 21 18:00:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 18:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499134.770165 (Exim 4.92) (envelope-from ) id 1pUWvt-0006zp-Vq; Tue, 21 Feb 2023 18:00:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499134.770165; Tue, 21 Feb 2023 18:00:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWvt-0006zN-Qw; Tue, 21 Feb 2023 18:00:05 +0000 Received: by outflank-mailman (input) for mailman id 499134; Tue, 21 Feb 2023 18:00:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWvs-0006d2-RH for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 18:00:05 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c4b153f-b211-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 19:00:00 +0100 (CET) Received: from mail-bn8nam12lp2174.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 12:59:19 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5459.namprd03.prod.outlook.com (2603:10b6:208:296::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 17:59:16 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 17:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c4b153f-b211-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677002400; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=jm+/EiayX+QXIKjrZJgSObO+ob28AtNgjOn2G9xcG88=; b=W6F35rxpOrA0wVXAMQMV0uwbVSb7g449vlQ2DKmxRHWoG02o3Rn5Xotv t7Q5xQBqk3/+l/CYY71anbcu+BBnAY9LhHFQtl8g8qlK349NzaCfXedbe nk45vodBMn0bZkGoxDazaLvMFbNYHWfNEOvYOMmKKHRbqGIbPcaIjlJpB 8=; X-IronPort-RemoteIP: 104.47.55.174 X-IronPort-MID: 97856259 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:fqyYyKvQdiVTPVooxRVk5zTFE+fnVGdfMUV32f8akzHdYApBsoF/q tZmKWuEb6nbNmamf4x/bI6ypBkCvMWGzNdgHFRr+C41EnhH+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEziFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOS8NUi2Ko+yK+OiRFu4zlMsqHODABdZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4a9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOznpqM02gDCroAVIAQ1VnSUjsuCsF7gA9dDO 3UZ3iUAtbdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQh3 0WFmN7BDjV1vLqYD3ma89+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXryos1LFae0ipj/H2H2y jXT9iwm3exM0YgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2sbFm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:4JLnCaptOJEVLPeEGLaS7xcaV5vLL9V00zEX/kB9WHVpm5Sj5q STdYcgpFHJYVcqKTAdcL+7Scu9qB/nmqKdgrNhTotKPjOW3VdARbsKheCOrwEIcBeeygcp79 YCT0EIMr3N5DZB4/oTTWKDeeoI8Z2iyuSFlO3ex3BiQUVBcKd79Tp0DQ6dDwlfWBRGLYBRLu vo2uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qi1iy+y4rKSKWnt4v5eaUI5/V4Ryx mNr+XL3NTqjxh98G6W64bn1eUhpDIm8KoIOCXDsLlZFtymsHfOWG0oYczlgNizy9vfp2rDRL L30lsd1oJImgHsV3Dwrh331wb61jEyr3fk1F+DmHPm5df0XTQgFqN69PxkmzbimjYdVetHod 129nPcs4ASAQLLnSz76dSNXxZ2llCsqX5nleIIlXRQXYYXdbcU9OUkjTNoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DSEkfvc6e1SRQgRlCvjol7d1amm1F+IM2SpFC6e iBOqN0lKtWRstTdq55DPdpe7rLNoUMe2O3DIu/GyWdKEhcAQO1l3fe2sRM2N2X X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97856259" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GN2P9TZolxuzpzqk6Xi184MI3QeJjS/a5IogRJyYe4Ep9Gdjg4mIbGbtYN3mbC2XFEFuRgUvEFDxWJ4ZItyGa8X757O7VARToLQAjrgef6GzMSj9hyRDX7E2jHETK/alFWO0MONOohOR5DqDkMqzkRFKXm8LLfAi5nyxT7ajx7clVuYuwZXPJEXYY8se2FcMLHqKYNGEUg/tvwTRyBQtV53z4qTB4G3RUsHe8GcNAL34XCWr71UjOFOeR9kA9jYf9N7J+O6V8+xs2YcDZYgGiyUA5NxAhzZPPsS+zvZ4Yu+ykv3ziT7Sfcu+l98xK/+DtZ2O8jTlMj8hWjXbviHjmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W4B32Yjqam8iFFIgpR+nelJ2DgQphaHmmqzDDs2HVGY=; b=XQn3nGElxgXgLGdN2/fdB1avXQPetGmzUmT9lNWVCbmV+cxAcclfyXFhzgmc3nUZU5K7sdZXp0kCQOn5RC7+ox8UMBlk9E3Ab56nd3tHBA/8Ot/IKTOoHxonI2rHWzLh8dpvL4ySFECioaGo834nf6uf3ii11hxDJQvTK6K37sgycvRkcO0btWjsUL3/GDKOjQ5TRgpOL2sIKQHwZOBaRE6utrZaIqVoRiwDDZLnVIfxC7gUYODy0AMTvxEIcFx8iHHzoWI54XcGj364eKRYTsGnNCPIBVcsrtEkxbSIg+Sx3yTMXCaziSKdn8+p3O70gY3TITD9g2EQ1BD9izefcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4B32Yjqam8iFFIgpR+nelJ2DgQphaHmmqzDDs2HVGY=; b=OEMqICPQPoPPoaPcfFYrScQnZx7EgtwVD3TroPDhfoXEmczgpVZgtuv7GG0qmJhLec1u/WqdAmgd4uJimj53fp3n0pUwlcp8oEAFyagx5Zr2Eh687SW/21Fs3cUiIBJTpwbpUEi49ivRnhENZ7Z/o7cFuShKpKGa92+KASEooiE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <04e6ccb1-919f-671e-6d70-15a74e01bbb4@citrix.com> Date: Tue, 21 Feb 2023 17:59:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-7-anthony.perard@citrix.com> In-Reply-To: <20230221165542.7642-7-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5459:EE_ X-MS-Office365-Filtering-Correlation-Id: f0bcc83d-0224-4d66-d444-08db1435592e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: apoZTt9G/Mjvi5uEIr+ix0p4mWGx4jyAmAsYJxPOK9/oVj0+UOLQCDkbak3p13xK0cv+Zq0gsLhZoRo7pwfp/Fu4ICBHFZ9S2sspJc9X/Bec1qdFDGr83DoZb3SCAcbmBmf5WZCLxdSu1h8NHYv8UkcXR+FeXIPiFEt0mDZJ8TSUsTP5MD9ouERsbQaPJ5nznOGKiLBURh0fNLskeT0fvRbBsk4tsLwIeC/tXAGziOX8btGbXO3dR+WfZD9KLm7Tv4bsHnmi7bFJAk8dFbtoEDZ5fbS8IzuKLpP38QUf0/PjdFtR1fF3sQmDGXkHvvNxeQfSPtJPEsfcqjh+MV2W5gF1xUbr4cOfOIdqT7zVX/+vXn8aTLsEU7M9DLVI1fDKd8Uy9YJeHvXlJWnSsmt8oVmcKInqAll7Nuf9AFDUbhit3dyvxVs+Wa//AXr0jvgs/WoCYs764lGdQzsyHxFXxwP6P7kqQDbiSLXwDpd+PjNPf+exwksmffTTlwR0RCQgC6P9RajYOcXXABmVMGSCaGw/ontkLdkCk2FUb5njvQ3kQGDh1//Y80rdApZ1ERLoJSuUVkaurlZBZoeVYV6XFqb+UoWsS0z0FAdYZOjEKaPFoMAgE2uE9fr4gewXMe2fnPkukVNMUOq15/c6YDdWeoI9MAPj3QP7bCIg7sEBDIotqYTENOwg2AiA2U52Uvg3qachcObSSMLgZSpPKCJRGsfw2Q7MjWULhAH8sbZ9ZhM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199018)(36756003)(54906003)(83380400001)(316002)(6666004)(6486002)(2616005)(6506007)(53546011)(41300700001)(26005)(6512007)(186003)(8936002)(2906002)(86362001)(5660300002)(4326008)(31696002)(478600001)(82960400001)(66556008)(66476007)(38100700002)(66946007)(8676002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWhJWE9pZTJFb0lpSjU1aGRtbERBeHh2S3RacDlFRDZyamRicjhyMzdLVXdy?= =?utf-8?B?NE5sRHdra0ppRjQrL3VnWXFFeDJBT1pRakxoUVFyQUt4d1MreW51OXhOemZv?= =?utf-8?B?a0lCM1IwQmhVMmpaSTBaY3hrK05CcXVQeC8rZlN5WEpvSUhnRlRHcFVJY1Rv?= =?utf-8?B?YXl0Si84RjRRODNlT0xyc0wrZDZqK1E4TS9oNFRtWVVrMXBITHdJVlN1bExY?= =?utf-8?B?OExQblBkWGpCa3dDY1FLWGkzOWZ2dHJBUEtESzV3bVZoaDl1d1Uvc0dOMzJa?= =?utf-8?B?Q0d3TktsM3o4TUx4WGZWUDBERDJTWWRTOGRyOHhYUGhJNzNscEpNNXMycmM4?= =?utf-8?B?Tmo3OWwwM2N5bGJtTVdQOW84WkxzOXF2eXNSUld1Ni96UWJwcGpwZU5RUkhT?= =?utf-8?B?Qjc2UHBBT2NSWXhhQ2czNDFrVURCTHpNbkloR2dBWllISXpQVlRhU3QxZEZF?= =?utf-8?B?OWQ3R2U5L1prUG9UNUZUS0Jka2VCZ0lPK1FWVCtjaG5WSEY4VzlLaENJTkph?= =?utf-8?B?LzdIYkJQWkxGancweVozWVdpeXF2Zld4NFE1cjJ5cXBsSjlzdXp2dU9Ka2lT?= =?utf-8?B?QVhLY2Y3TVU5bGpRZ1hzbm12YTM1MVFkQm5lR0RMWWgzWEtJMnZSaWJpb1By?= =?utf-8?B?WXh3Z201dXlGRkdOUXcrWUJMVVNjeXE2cnpIOUVzZXNPTnIxb1h1aWxmcVph?= =?utf-8?B?NVZVV2hRWm0xSXdMK1hQMVY4Y3hLQVhDTUh1eWZMOFZKaCtwaGpHdWcxemZW?= =?utf-8?B?dFAxbFZ4MHZsRk5nVm0vcWRhdVplUTJFbHJUcFhTcVl6d1FKOUcxTUJFbUdX?= =?utf-8?B?a2tURkRwMUlJdjBmWkdUL1NnWTlTeCtQeThCeDJIdjlzTHpPemhzZnRnUXVU?= =?utf-8?B?LzM4ejh5UzBLNndHVlJmY0owNGlaeUg0TXB2K1lSeVdmSXd1ZDlvdjZoY0Fu?= =?utf-8?B?R0sxMXNKOTZncG54TENUUnJwOVFJRVVzbXZVRGlqaGZnbWZSWGxyZ2FBSXk4?= =?utf-8?B?T0ltRmVXdXVRbk9TZ3VlNE9PWEwvdVlEVVg3bGM5anR4TkZkUk4wRno4ejdW?= =?utf-8?B?VWovejl2SGliNVNhdC9GbVVSZFZlVDVoMmJHeVkrVXNFVG10NjloNFR0VElT?= =?utf-8?B?OHNpeENLeFFISnRIWmd1Lzkzakk3Q3B4K1diUHJtU1lEYWtYUUd3enJ2T1RM?= =?utf-8?B?L2hDRXNVTFRoMW1qbzR0cTZCd1ZmRVZLZVBnNCtVRzNzczFIWW5Pd1pIMXhE?= =?utf-8?B?Tzdyb3Y1b285RVUrVFZCcmd4Ti9HSW8vZFJmQVVzcDFGRklBYlQwNlBiSzdn?= =?utf-8?B?KzhPSEJybmRVZUNoR2s1eElWRXgvUlp0eWE3d2puZC9uRW1QWHErdiswb3hr?= =?utf-8?B?YU01Sy9wZkJWOW95L09KR1Rsa0NrQ01CR0daS09TUkhtc2JpNDJLY2xlVDE0?= =?utf-8?B?Y2RhNURmUVhYbGluMFkyb1VmazZ2cW1FRUFnbHNlRm5PdE4xMXBjSTlSYklB?= =?utf-8?B?UkpHRHdlbTRKWjVOVm1GUTM2eS9ZaU9LN2MyNzdpaHd0OWlERm54TUxGQVMy?= =?utf-8?B?VVBlK254MmI3ZG1rVy91SC9zanNSMXA3cVYxbjgwYUsxZmI2dlVLMUpOUHFq?= =?utf-8?B?ZGtSMmNZMSt0RXRMRlVIZUh0YlE5ZUY3bzRuSVlLTFdGUHc2K0NmMUN6NWJv?= =?utf-8?B?eEhSLzJBZDRqUi9BZDhCOW9CMTQ0YkhEQ3E1U1FpOXFNY3lkNUtiV0ZMandt?= =?utf-8?B?UllGWUlYTEQ4OW5OUjlqNFhUMnUzb3QzYjQvTVVucElWYlUxM1IzUnRYaTRV?= =?utf-8?B?RW12RVNlNWJQTGVaeEF4R0pSdzA0Kzl4TUIxaC9BSFU0VlRVMFVXMVBOcGJX?= =?utf-8?B?ekdaYVQwUnhCMURld1hrRVREVTd1b3NpUjVQRWk3ays1NEFsWWplWjBiOHdL?= =?utf-8?B?elp6SW1pVEc3SFpQUTNnM2s0MHRuYjJMQVBzSlY0bGJiWm1uS0E4RDlGU1ht?= =?utf-8?B?RVI2K1RQbTI2VkJsRWwrWms4RVpBVUxXZDJwdkVhcnlsa2s4SjRsbnBhclEw?= =?utf-8?B?dnNsb2V6S2JtVURNSk1VSXdUT1R4VDNhVHM2aWFValRzY2k2NE1reEFDY3lY?= =?utf-8?B?enA1emt3c1ZMU0E5ZmxhVzBESjFkZTJlOXVVZUpvUG5vcEQ5SDBKVzUzMFdK?= =?utf-8?B?VXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: HLVwyRWT0ZuB0eZx26RGszlwkAWqJFZgwxrryUWsTivM1mqqigzi/VQXrEyLr00MGa7O8cJeiOJbhLv6fhvdaVPIAQj0fQ0FGKZjFX0fJbgAQsiQD5FPBJj8KenIB29AcTIo6TozXxzXtGejMy9iBd2iR+KLDT1BTRkYdSFGxG3DqUEJD5TA1J7DYLs9UMFb85xwEEZWThVHdK+Aj3LITlZLAq7RU4zlv3rTtuPvDQMCFyjA+Vw2JF1N6U+FMLQf/KABP94UWQkqtIGiqAh1Eb5ObPamTUNuMIiyUP8o3AaKkGPVDhtWQPNzHd2I/IFFw1KJrNUvqVNGKMhmIF1/dWjVEuTPF8qtSHhkKg3BwDJ5fqWr9kIwORHKD6eATRfOole4KjrlEtLM9RCCKjWak+I83TdDCHZuQOy+POMtAfpQ0438A6jHwQPWVtqnL1QI0A4Xix9Vj+Qa1vJtRQWIUvfYu98bkHC8JgwnMOExc54ZUTxhDPjSbjIvfjVKuozr2W+1+InzmlqL79f4T5Cno+87Zdo/1agoSLnS50JqDRt8nbIYm2yFNeceUyEAiPECLGIr1RTR6ObSFs5alxCYU3XYo2eg3GClt179/xLTd8kQ7WNSzOyXlCtaOzfvRz26OTl7kGKfuoE89Ss6koewKPpLXoX035mw8EKhGfto+1FPdLgrpL4uyf8lX3v4Qkb71ttQGcgOqbFEvUZ9KcJN5RrXD2joeZxW+G9zEEs8bpRNrfzb4DkAVUAKUO/K7S4xbk/mfVQKR/ygro5M853O3LWP7nOjz9HDrdVDCSmkglGoHJ60VIhDm8gICvxMMIxkavbye7MNOsuUL42mjS2x8A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0bcc83d-0224-4d66-d444-08db1435592e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:59:16.7776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CLHf7bHFZajblULWKfJOmymVC0SyhM8e/Z8KqDdvkkka0e5qw7yq3+Uy7PWMQIOVFt/yw3YoUOm5RP5KboIRYUkB9QZQb+dV8I6iY7/P9Lg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5459 On 21/02/2023 4:55 pm, Anthony PERARD wrote: > Jessie as rearch EOL in 2020. > > Even if we update the containers, we would still not be able to reach > HTTPS webside with Let's Encrypt certificates and thus would need more > change to the container. > > Signed-off-by: Anthony PERARD How is this interact with the other patches in the series? I presume we do want to take patch 4 and rebuild the containers, for the older branches.  And that's fine. And IMO we should be dropping jessie testing, so this is almost fine for staging. Except, jessie-32 is the only x86-32 build test we've got, so I think we want to replace it with a newer container before dropping the jessie*. > --- > Notes: > HTTPS would fail unless we commit "automation: Remove expired root > certificates used to be used by let's encrypt", that is. Patch still in > the series, and fix Jessie. If we're dropping the jessie containers, do we really need that change too?  Because we really shouldn't be playing around with URLs on older branches. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 18:01:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 18:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499141.770176 (Exim 4.92) (envelope-from ) id 1pUWxT-0007kv-AL; Tue, 21 Feb 2023 18:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499141.770176; Tue, 21 Feb 2023 18:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWxT-0007ko-7B; Tue, 21 Feb 2023 18:01:43 +0000 Received: by outflank-mailman (input) for mailman id 499141; Tue, 21 Feb 2023 18:01:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUWxR-0007kU-BF for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 18:01:41 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8d74dd0-b211-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 19:01:38 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 13:01:27 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA3PR03MB7282.namprd03.prod.outlook.com (2603:10b6:806:302::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 18:01:25 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 18:01:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8d74dd0-b211-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677002498; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=1iEVppZakVn10DsySyvc6X2JVosMVkZovMLPCSw6KVA=; b=V2DKDqrFIoydjO3faXBWg8bGe9InA63Qit5oqrMrlIbakxuAKIxqfk+s /+tF2E97BOG4oiWV6OwHJiiiMjO4IHpYiq9nUq9I7YhBK0z8P4hqeR/q0 nBzjGkxs4ZIUfaqMyApwJm/vd/+Qdx/W7mQZ+JqAEqjuusWUyGwvaQjGr E=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 96776293 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2qgdbaIQZDg5fXx7FE+R5pQlxSXFcZb7ZxGr2PjKsXjdYENS0zcGy zYbUGiAOfqPYjTwKtgnO4+z9E5XuZLTnYRgSgRlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZnPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5aBloQy 9tbIQo3fwmbgPnpwa+SDclF05FLwMnDZOvzu1lG5BSAV7MDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/RppTSNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eew3ykBthDT9VU8NZHigOw/UwaNyRJRHyGjqm80HOya9ZAf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpY9U8uMg7bTcjz FOOkpXiAjkHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRt3jX4iIQ6jxaKS8k5Fqew14fxAWuon 27MqzUijbIOi8JNz7+84V3MnzOroN7OUxIx4QLUGGmi62uVebKYWmBh0nCDhd4oEWpTZgXpU KQs8yRG0N0zMA== IronPort-HdrOrdr: A9a23:aR3GT6rLFRUfa2Vm6/IJNkwaV5oUeYIsimQD101hICG9vPbo7v xG/c5rrSMc7Qx6ZJhOo6HkBEDtewK/yXcx2/hzAV7AZmjbUQmTXeVfBOLZqlWKJ8S9zI5gPM xbAs9D4bPLfD5HZAXBjDVQ0exM/DBKys+VbC7loUtQcQ== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="96776293" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qrg9HzcvCR5sYEz+cFn+WNtRdKm9xHhA4ejSet70FEC3350nJTu+JRYfigY2ozcc5ktbOYl346p9VwulFgBe4+UOv+9PNkzJkTxRDOXcZzAyCTfz1NO0Gtjb/5UsEQb2SYG8o0Rxe8gqKj8oOXusob5OblNmkEhmu6es2kEkgVO/Ri56awPSwljhcwdTBP8UC1nLZgGoH+8Pqc1SkUozZppukn6/j9k3n+1Z/uv0TWqoaRrFODK8WllhMIJ4CVjZncD2JL8SBgjN1HSQBIsVccfWWiGzm4FMfH5aFpAWCoj4UjQPW2NYnlr9aDY2zKZN/9lDlsKVMbGpSIzDY7kRyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m58ciIlzrfjpoV2Px9JAXbSkrfk6mNVMkGqGPg4Tvec=; b=kSwjUMLAUbm/vKDcnOW0HrDXdVvGaHe1RjxMfZyXMvvObIAJSPTW/1OQNstkFRFoleLbIPkvlqM3rK0mLXfii3Npm7oRVjq8Ocx2lXV/4aKJVyebol6Wc8aesJDLIWe6IeHUXH9qPHlowxhJIc2yEGaegBQrBJ7ZOXeUsd+FA2v2/mVAo8XQtsRbGogp7zx2F5hXEosln4R4L/e7zggrfe2qIqYSkh0COfIaflFNNiIQPKgHN4xviudodOl/VdwzzfsJg3J941tpHw2S6lp8yU4U4Y2X75wv87QJwhT8lAV+3OFaW5os8k5Vg4jPjcXcXwifyVx3Vudb4KnWi4/2MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m58ciIlzrfjpoV2Px9JAXbSkrfk6mNVMkGqGPg4Tvec=; b=m13iVHtzxmG3jB6xynkD5HbvFcaQYzwt4TbCEAxVscv7EmS6jfKq//m+6LI6FfAul1SIMFqIqAf6v4H6dSY38Ycco/8V3AG6FHYouVwngM0+0blp6TYFZNdujPfUhzdRZyeE9h8NCC+e4u1V+BB5OhxAceaOkrnbLdpW1tJ/MHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7ec61260-0fec-25e2-6fa7-ec1d86e8067d@citrix.com> Date: Tue, 21 Feb 2023 18:01:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie Content-Language: en-GB From: Andrew Cooper To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-7-anthony.perard@citrix.com> <04e6ccb1-919f-671e-6d70-15a74e01bbb4@citrix.com> In-Reply-To: <04e6ccb1-919f-671e-6d70-15a74e01bbb4@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA3PR03MB7282:EE_ X-MS-Office365-Filtering-Correlation-Id: 3439bd40-2015-4c12-f602-08db1435a5a5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mZPPCrTnA8zR+nRtSx1J3lQrINTf52gkPIzm9J9ZCDhIzmkY613c/lRa55GTWLYLxswK+bO28xoZnf8s+XcUzVgb7kkXjPC4GwWW26Lpu1KNqv+nOLqE8Y8xRByMfgl+Uh5Kp9fXJuKF0c0mvQ1K7GAXZiUSaCQP48LQjVHb8+K0bKTC6TKzaiTWxsDgewd/812v03XtcIk9lAnN/VZNDbdun0KO7e4C/w3l9Yx/w9qHuryBRCRFHf4Hrhenmxiyrfg17LXE8xIQwovzPrA/lktCKQGeV1Bl5tHj0YHs7TjjarPXtqC3lq9ITQhC3G+DNeZx+efRQi2qE+BlXChUkdzjr/EoBqvnlY60rB/OMIEE61L2JOn6nyzQ6sbdAkyAZeti0WGvMeXhjruXDAhe1qAXxGkLdLSXbT6u8GnPbC8J6LSMrTKqxqm9RGNsQx6EPvbCXP0VwisT6H+h2ttGkcxjDn1NMYrsw2pXYIhZRjJ+m0SWguv+a0IztYiclHdS88tEdEmaVjZ94Ho6VBBzNT+XHF+qoVyMm7x8xh+Qyar/nfzT8UKlh7mwFMPhwJuBWf/iMM9ahSAUP32aemR3tz79vimdJUgaEZyxdybGusra9t8+AqCXk8jyp5BVYsYDx8MrISQYEiT2K+47le/XFpusnADlDUaysrXcr1leohLnkAi404Ya9emmEtTKjXimaAy64eexg2Khedu3s4TYjQ3I0UZmjEM8lypP6BNRtQw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199018)(41300700001)(31686004)(86362001)(38100700002)(5660300002)(8936002)(2906002)(82960400001)(4326008)(8676002)(66476007)(66556008)(66946007)(316002)(478600001)(36756003)(6486002)(54906003)(83380400001)(31696002)(6506007)(6512007)(26005)(53546011)(186003)(6666004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YklQcm1qa2c1R2ZqczYvOU1LbVp3YkxYaVRZNHBhR25Zblp1UGxtQjBPMFFS?= =?utf-8?B?ZjZNcENTOGs5MmlIcVhHN3RkeFpGUEhsWXNLVFdZNm9NcWhpUzZ1QTR4elVL?= =?utf-8?B?ZXErTWQ5L3B5dldQZHczV0d2MVlnZlhMRERmc1g2YlpJT2xFV1lDMUtzUlk1?= =?utf-8?B?ZGV5TVBoUVlQV1o4blpQaU9abk5jWTZ0eFRwYXN3WmcyTVdkV1VBS3FWUlUy?= =?utf-8?B?QkxJeHFDN1lQTWpwa1lCSWpJZFpSdXhzblFjL040ck91blQza3BlZHRQZHk5?= =?utf-8?B?bm5GSlZwQTVkeGhpdk9PMm9vR2pSb000T0g5YXBGNTVRa1FvL2d3U2xtMzNo?= =?utf-8?B?TCtJNXkweDlXMmVIa0FZUnZ5T0ZrUDZPd3d1T3BvQzZGYVlzb3c4SG5QS0JK?= =?utf-8?B?d2pJbFc4ZFlneTlaSGo5Q0lwdG5IOFJSZFE3SmN4cGhudjZLTzFYNlh4ZHBQ?= =?utf-8?B?VlYzeFVGeitGUjc1QUpWOHhTeGN5akgzVUR6bHZTTUdYN205Y3hRZ2lXd1NF?= =?utf-8?B?dk4vWFlzQUFRSU9Obmc0N0h3a1dwLzdGbG1aSXFhR1hhM2dkVWMvQnVQZ2d3?= =?utf-8?B?ek9YT3dMZTZyU3pXU29FVlNNMjlDMjJKZTNndzhJWVpqZlAxdWtFUFFKSHM5?= =?utf-8?B?NWpES3o5alVOTnNCZVdQSk9UNS9UVTczbTExYlVna1psRnFPTlB1VHdDcWJt?= =?utf-8?B?RlAzUzlKRXp3Zjg4V1ZpbFZCSlk5YlNtY0FEeGpoMHUxRHJsUThGRForb1FK?= =?utf-8?B?eXpSSGFDYXgwVXp2b1ZqN05ZbktjeWV5T28wQ3l0aWFzTSt5WVR3V0VQUlg5?= =?utf-8?B?RVg2bWV6NWRiQWVOL2cyTk13cmJIcTRtMG1BWHlVM2hJRmlyNCtDQlpUVlNR?= =?utf-8?B?bGYwbW52V3BKeDlqd1k5NGdxRnJnREVQTmp5Y1JKUytXMzlaVVpRREUxODgr?= =?utf-8?B?UWh1YS9uV3ZOVDFpRkE0M3NJMU1FSTVZeWtOcjd0T1VmS092U2lXcllTRHJ1?= =?utf-8?B?M1pZMUhXVDdJZFpSOXlhL0x6Y0R5cE51U3lkWUVyL2s0NWZmUVdPVFZvZllK?= =?utf-8?B?K3FzeVhVUWg0dllpUUpsOHlyeU5TZjRGdkpwS04vWlFXVnJ2M0xyS2lOYTZU?= =?utf-8?B?aGM3a0xscHN4dUUzYW5jeHBESEdvb1gya0QxZi92UzBhMnBCV1V0UDA1Rmhi?= =?utf-8?B?alA0eGQxVlFXc09ZV0FRdEd5RVlSSXpRajBta21qSzROaU10U2Q1SmtuSTVH?= =?utf-8?B?cmJjWkN2WnA2RDBMNTBNdmwwN092NVNIVkVRVjhkSXhlOWZmUzBhbmFCWnQ2?= =?utf-8?B?OCtRODlPZW9tNTA4ZGpwSENzRmJpTWo3NWs5WEc3SnpVUDY3RExxVnI1cm1P?= =?utf-8?B?OG1ZbHhjMzZhQ3BETDFJQk4xTVY4R084d0x5MGJCSFpRKzBZYThWeUd2bk9N?= =?utf-8?B?UkcyeXlWSkdldEt6STVLdXZWTy9ueUJibklGWjc1d1YyU1dGSkgwR3dLb2NJ?= =?utf-8?B?aisrVGhiV1J4cWlBSFpkMk1rM014cmovZnBCRkw3b0dLVzhsbUNFNlM4UWtN?= =?utf-8?B?MzRieEZ5M0Jkc212QXNML0hqYmRGeXp5QXEvSnRNdVc4eGxDRWhNWTNKMVdB?= =?utf-8?B?aERqNi8xaWVxWWpjVEZZdGVKeEhhazFnQnpGU2NiaWlwQkFrN3h4TkRsa041?= =?utf-8?B?T1ptSkg1WCtIb29EVzFqRGlDL2FKeFhqdjUyakZ5dXRZdmxUeDhkdmhFMmxS?= =?utf-8?B?OXB3RkdSN0p2WjVjWUwycXBxWHhkei9WVXlNT0Y5ajdON0svNmdFM1ZabVJ6?= =?utf-8?B?cW1RWUYzRk5tVWFDelpMOGQwcmdkZzg3dzVYV3JYOFlWVlpYQTRhdHc5T3o2?= =?utf-8?B?YlZlSzBEZUtTVXZwUldINDZwZ1dMT1o3RG5UWDVjbXNtWW1QT2htRGdpend2?= =?utf-8?B?dDBzdUpwZlZKNlU0bWNUUU1OQStOY3hDVklSeVhSeTdGUFpDMkJHcHpoWGlj?= =?utf-8?B?TTJFd3dPNE1IZnJhdVBCVnROeTVENFVWcEM5MmV1bmF4Yzl4REpxMW5EN2pY?= =?utf-8?B?OFAxZmJSa3Awd0ZOWXhqaTdybDlrZHlGRFNtUXhYUHl2emw0WDQ0dUZmbk41?= =?utf-8?B?UVZMR1ZqWWFVaVplVFhTWjd3dVduWTFXc3FnNmUxUEdUZlZBaXR4OFVycHZQ?= =?utf-8?B?RXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FGQOXAJ7Ml1ik8482yyGnIBjeesCT846kK9hl4wuDLeDv9z+eN2wETRl3m+kbQWZt7UJaw0XvqQPp5PDrEZrA4lv560vteIr/lZ53y+Ymc4I+9gTkRo/ueBjxPbSZ0NbddDMsKlU81ZHJu1LaYH3Kt1RHRK2l0eqPjAobEXMKVMKa9PpSJlsje6AhYqTKxpfRzK5b0mmUJMshJLBQ8CUEfOt3zADTjwfKD/SayTXILfcsUYCF6DIuk/uTQYhn/1LypoZkSNO/oXcmp3qERVCZqQjYdX92dkhquVW0JYi1Hqvs3pB6moJ5+91PutToqwP/EXQwOkJLac0pHJln7VB2+YLiAW2eMIm/Fo156yTK3c3gyTmIZbV6hiSwYllQ+CfqIqEt3xHGMFvAVvRgmCj0T0jlDHJc0H3SbHfiI3zU13AP/NEyNKMvKwbPvjadrqmRsBbvNaeQZv5Eu77EjVIUZLVV0G0H4bLCGE/GQNFTqxtOEtk1n83x1T1K+p8DW1+5ohCS5n5mmBZO+QKCWAxoavDSJcqpndsvh3i4bwchHLTegesGjX3MREWUb50Oz+4SWKRuflFyjeaKGGN5BSw+JlDLx25GMWRW8nVGaUJD+/+xZovbWujAFCF8H8VvpYF1Va1IfdSJroO2FPW6cEABLuFItAjHH+F7JVKg3iqCnHBSCFDO5oLkbIDnc/n8RfV81XpZvFKyWRsK3hXnGBEP4i/nLJkz/9YHdqdWFetCTve0pjTx7Z/sb7ZmRtDXvaxi25HjLMl7q0HTo0RDmdFxKqzJQBfFEP/fX5Qf/IFZrItEPIhTcKvehlOLKRHS8rZwmMi7KVyeFB1JKDPxHeA1w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3439bd40-2015-4c12-f602-08db1435a5a5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 18:01:25.0496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /o5BIEbGSQIBL07wkpMjQ2NlGByjL2sUeIESDiY6Gt7c0SpmQXSW6FGrBR0gQh52ApNedcQG3vAewNuPRV+3TAguBxgK7YXoUEbEOnFQIWk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR03MB7282 On 21/02/2023 5:59 pm, Andrew Cooper wrote: > On 21/02/2023 4:55 pm, Anthony PERARD wrote: >> Jessie as rearch EOL in 2020. >> >> Even if we update the containers, we would still not be able to reach >> HTTPS webside with Let's Encrypt certificates and thus would need more >> change to the container. >> >> Signed-off-by: Anthony PERARD > How is this interact with the other patches in the series? > > I presume we do want to take patch 4 and rebuild the containers, for the > older branches.  And that's fine. > > And IMO we should be dropping jessie testing, so this is almost fine for > staging. > > Except, jessie-32 is the only x86-32 build test we've got, so I think we > want to replace it with a newer container before dropping the jessie*. Further to this, I really don't think we need to have a 4-wide matrix of {clang,gcc}{debug,release} for just a 32bit tools userspace.  Debug clang+gcc will do, and save on some testing cycles. ~Andrew > >> --- >> Notes: >> HTTPS would fail unless we commit "automation: Remove expired root >> certificates used to be used by let's encrypt", that is. Patch still in >> the series, and fix Jessie. > If we're dropping the jessie containers, do we really need that change > too?  Because we really shouldn't be playing around with URLs on older > branches. > > ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 18:06:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 18:06:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499147.770186 (Exim 4.92) (envelope-from ) id 1pUX1U-0008P0-Qe; Tue, 21 Feb 2023 18:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499147.770186; Tue, 21 Feb 2023 18:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUX1U-0008Ot-Nt; Tue, 21 Feb 2023 18:05:52 +0000 Received: by outflank-mailman (input) for mailman id 499147; Tue, 21 Feb 2023 18:05:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUX1T-0008On-1J for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 18:05:51 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d19e0ac-b212-11ed-93b6-47a8fe42b414; Tue, 21 Feb 2023 19:05:47 +0100 (CET) Received: from mail-dm6nam04lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 13:05:44 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5251.namprd03.prod.outlook.com (2603:10b6:a03:22b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 18:05:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 18:05:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d19e0ac-b212-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677002747; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Fp/pxNOae4UU+0q7K7xEtDFxcv7JNCW6Zq44M22EC2Q=; b=Xts5pddNpZ4/uKw0+LMOmXlD73FIPUC9eaXIRd69WSkv4iBxSv3xxhVW eN5KLqBiujTx8Qr94LQB2NryweQtAxTkCVUvZRl2qCa4tlOtvIiJVQxfk 2Uthzqyn9hiFxX474fCSXEVIQ1+If7vXstWFaJbzQtfZ8n55hD7xGvoyg I=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 97949463 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kk8o56jWhrlhSlRPeidWNr3iX161fxEKZh0ujC45NGQN5FlHY01je htvDz2DO6uDZmv0fIx3bd7n8UMPvpbcy99qGwFr+CE8H3kb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWHzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQYCSoNaEDAgtmvmoziY8BCnu4ya5LCadZ3VnFIlVk1DN4AaLWbH+DmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluS2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDS+zkp6I02zV/wEQVUBM3DXCSkcO9yV+ZHPUGM VYIpyEx+P1aGEuDC4OVsweDiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRzYny 1uIlNPBHiF0vfueTnf1y1uPhTa7OCxQIWpcYyYBFVcB+4O7/Np1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxlgRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:23MZ36kBKiNTfoLoH+yOO4OYTZXpDfIT3DAbv31ZSRFFG/FwWf re5cjztCWE8Ar5PUtLpTnuAtjkfZqxz+8W3WBVB8bAYOCEggqVxeNZnO/fKlTbckWUygce78 ddmsNFebrN5DZB/KDHCcqDf+rIAuPrzEllv4jjJr5WIz1XVw== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97949463" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFLGYt/NgiNPva7rXPbYVYscnQfE4donkk5xH0aQZ87t5Ov3FnSMtANkQuIRvrJETU8zyKsZbNoDcHoWzE4pGYN32o+EhGC8ioF2eVaFBuEYLjM6yBlpuqMUK4Dp409NKOZfPD/inqoF4sj49UgWYQ2ie1cDy4q7alZ638GQl1Q2V/uPnmFOGK2lB3y9AUSsukYtydarFYc/R6xpdis0QJnOtQTDRssY45xzYQM8FDQkSrGJx9Qi99HLu8ctBmxAZc19/jnXNFp17PozEycJ01YJAjKJX9winFlX4EUdRKdbZS0ezKU/OU2o9NFuw1272al1wUKpmh0ItXtoTU7+8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fp/pxNOae4UU+0q7K7xEtDFxcv7JNCW6Zq44M22EC2Q=; b=bPQgZwztrRZvqdTgfGk/97NWljh6jPhqMpZzmbUyERjUTS56zJdn4pyIt/1Ih9ciBXSPliIW+RgQMDaCmydOlWZ+5cOMHXnsZ5SatGOkXRHkU3SO3EDTm8UWp13OJSkBxWg8XvQWCNHhjUdTy3L5CY6ZASA5tPgc02P1Qqgpq/8Hkk2Ul241GOhkFOpQcLsvwrXw3q9iMVplHqGDgaOTkeMLqZIZGPZT8mZsWZa/G2XD58QGVYsnmjuqR6PtJhyJ5jcKXTPnXBQcJ757vBYbutyyo2IkiHC/wtMypCpN1ZhXsjsPzlDUFqse5eiT1v0biWBrTZxB9LfwI4KxeBrjyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fp/pxNOae4UU+0q7K7xEtDFxcv7JNCW6Zq44M22EC2Q=; b=fQDdA6dT3JTrdkWwFMtnK7x74hAwiz3avVNY6Wp+iuPOYQNTb19RhlGFDbtcOJDGhOfCSt+uTEo9FXAkjqNxhREbaGXx6vqV4qKUg2+6c+s9FtUaUDme5PQDlNS3ceAj0hVsrV97/m5LZRwuADLD35fnAbadcvoKutJbVr1iWEI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <19396277-127d-1127-cdad-341368f97e92@citrix.com> Date: Tue, 21 Feb 2023 18:05:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Debian randconfig failure, Was Re: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Jan Beulich References: <20230221165542.7642-1-anthony.perard@citrix.com> In-Reply-To: <20230221165542.7642-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5251:EE_ X-MS-Office365-Filtering-Correlation-Id: b32e2613-20ea-4d19-e43d-08db14363f20 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bD1lsSH0PO4yJ2PjiEYCVO9U+vny3l5VdTDR6n5P0NkBdyb0Rm7oBwgYNYaLwjRV+gj+zBa5LWI53Vhu8+ka9UCubYmyTMyuogs/EyIbRc+vay5fheRRDEyJ2r7dNotreERH6b1m0SCmQvrP+kdh+fpiuCMQGvoLAjNeq++s1j34eq5fpy0pcemrki1TfCFp6v7dE39zddehKUGV9l2sbEFYkIs3g1R0VR7asBA4zruFLIn6odRUJYfRobo2GQT2W4hkBttQb6F/vS2Cx9GtTCCI2690RyDX+pDh2rZUyK8ga/HyCgeSjg5Z9pyiJ/AGrH87nPjrpaeQ3Ur5LaNAgRN0HrGOvwdaAvYrB3973yPCkyC+tqDFrJhKudhSssH3X9UWybM0QVWNFE5smNQ7g15zkzxlFJd55A1dw6Noz6fui5ocBmpYkkEGbH9hd0nJL8lWxOlnWGr6BgEJDo6xjlaQ17pzj7l5uLCBR/QX9Z0iGIcoGsPCIV/WYey6izBkUPfgUUp45+HvO0DuPpuOso6i8y6QGXgzaZNYohJAcERvzTFiQaFRAaFxopqgiVqfDzlL10jMPgTcWsOCL4ZM9UNd517CuTuvbdMLYbBmYLk/Z+qErAYpXF93TQTMtkf7/KAJpoBTfKe6lX+h5ZSoUjEcS1ha32RPXM0ESSf1hWNNqz853CC69uBFm40/zy0nEmKNeIxnGlcrgDYMLCLBKkaKgk5vxHETzfQd/O9j1Y0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(376002)(366004)(39860400002)(396003)(451199018)(31696002)(86362001)(36756003)(66556008)(186003)(66476007)(4326008)(6512007)(26005)(8676002)(8936002)(5660300002)(2616005)(316002)(41300700001)(966005)(478600001)(6486002)(66946007)(6506007)(53546011)(6666004)(38100700002)(82960400001)(83380400001)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXpkaTNVU0JzVkhwUktDSjhRNFp3TzV0U2hYWFAvSHBxQmpvR3dGRWc0QVIx?= =?utf-8?B?SjJ0MVZPcEE2UWVnTkJPNitkdXI1YXFRaWxPRTB4ZmdrUXdNcEZvSThCRlFx?= =?utf-8?B?MFN2QUhuKzN0L2pnZmZ4eVE4ZjZJTGQ0dGhxbGRBMXE1aEl3eHA2R3FSM2lJ?= =?utf-8?B?MVZFQ3Z2NUtQemFsc1o4c0J5TDJjcDFiNExXN3ZCdVVDRVBNK0FONXRqZEdV?= =?utf-8?B?bjlRNFdYUm5CVFQxWm9vd2xLaXg0SUhXbWRHWXg3S21xekpndy9Kd1grWHNz?= =?utf-8?B?MEVLYU9mOXNLdWVBeWVWOUtSYTRtQ2NrazBuS3Z5dFc3Y0E1NzJxK1FWaXJo?= =?utf-8?B?a2FCdTFmMGlLN2xpcGxhL0VHWDVQbnRxcjduTmRjOG5RTmJSTnRmSTB3WXFB?= =?utf-8?B?TzNwK3FSWGZMS25UeU0ybmpQcUNlM0NmdmpRdStEZUdSd1JlcDIwdndrSm5k?= =?utf-8?B?WXVtZGltaUdiMllsdGJPWVZGaXRXRVhIeTk0azlObFBRTmZZM01JRklxdHhJ?= =?utf-8?B?dEJ2K2VDb1ZqaWVhL3Z1ZTM5b2M0VE1lKzczM0JDY3cxaDRFLytvQU4vVkxP?= =?utf-8?B?djg1NzRzMmNtNHJ0NCtPSkRZYXNxaWJUdVhoRHdWR3ErUTJxdW9YVklZNjIr?= =?utf-8?B?OVFkRWt0Wk0vNW5ha0kyVGFvVmF0cElUYmNpYzhnTkRyanErcHp6SEpZZ29S?= =?utf-8?B?bDlhemR5ekkxeGQycDdsb2wyVFBkbndpTEs0SWxIa250dlZFd0FjLzBES2hs?= =?utf-8?B?Q2lYaU43SXRUUUNzYTlQcGh4aTJEdzNsdlpQNUVUTi8ydEpjUFdHekw5ZXcr?= =?utf-8?B?OWZ2QWhuWjVUeVRFWTFEOXd4RmNLNENxZFVadE14SFJwWkM2ZWp0OUR3bkw5?= =?utf-8?B?ZG5wWlNoYk9UR0ZNZ0RmY0tDVGJjZnBlQnczd2FoenR5TjM2cm5jYjV4NE00?= =?utf-8?B?UlZLMXVkYkh6ZlVtZmdiY3lJYUc4YndIc3RQMTZ6QXUzZ0twVU9JYzFIOGtU?= =?utf-8?B?SzgvelhqdFlrWWZzZnVqTWhaVksrRGZGVDdnMFVsdG1XYjd4YkQzdFFqVGN3?= =?utf-8?B?UWloeTM3Q1hrRDdxVmlmK09kL01XVDl3bFdXT3FGTHpjd0xwNngwUFNJV0tL?= =?utf-8?B?MlpKVTREcVdYMG1HM0FrQmQ0eUpmVXRLRzRjRGRhNEQwZjE2NzhsVnBDWTA3?= =?utf-8?B?OVFEc3JpbkRXMWNQdjVXNTNLUTNuMHZ0aktNQUdkL0hpUFR0NEI4cmlxSU52?= =?utf-8?B?RFNRYzlBR2czSTZub0Q1eGk1SWJNbXEramR0dHhLTStOb0NwZWN1WlIxMFZ4?= =?utf-8?B?eEkrSW1jVGhrWnNEaG1rN0t0OTRmKzNwMjY3TW9rWEZmRjRyYkU0ZXROdnF2?= =?utf-8?B?bXpiMHNrNXZEbTV2ZHJZcTN2bXFDbWU1RUNjczh6YVJPWWFkODYyWTk0Mjlo?= =?utf-8?B?c0N6YUYwbHRHbHpqSkRrVXdQRy9VVm9uYmV6US9UNkZYeUlwaGVuaW11YXdC?= =?utf-8?B?ek1pTTd5blIvbHJGS2tabUVVVnRGUU1jWnpxM1VxYXd6WngvQmg1SWdDUVNV?= =?utf-8?B?MVNmckVxRUpDckFKYVhoKzZ1bG11KzVPUmo4TDVyQ0hKSVowSGdhcjFmRm4r?= =?utf-8?B?VWR4MkQwQURZbW5Lc1Y1RFRrejNtRmYwREU2dVVvWTgrbi9mQVd5T0N0UW5L?= =?utf-8?B?N1lRTXY5SnF0VkQ3dDN6S0d0K0N2UWRScUZmcDMveDdTQXBON1VHUlV5Vmlw?= =?utf-8?B?OVNYeHcwKzI3Uzh1c2VIUjZleTZEMU9IV2UrYVhwTERsdHM0bkpueTZVVTBP?= =?utf-8?B?dTFqZlpMNzhxOFlUZ0Njb3ozc2J0WmpNUHZ1YldTQjY4cVhlVWpVLzF6ZjZq?= =?utf-8?B?T2R3MFB1SDRPUkpWTFZsbWdNME40ZGRzQVEwY0dOZ0RDblhsaXZwRENqdTli?= =?utf-8?B?MXhhOGowdmtPMjdNa0VNZUdJZ21UVmRFYWFTWjJqYTVJMTlYNVN1THVJWHdm?= =?utf-8?B?QitzYmdMeWxXeUFhMi9tUjMrVDYxOUNaeWxmR1RHcUdmV1hxL29RbUZmQ1RJ?= =?utf-8?B?cUlEb2F0UUNwdEc5T2djWHRySWtkRytpSitKblpGTjZKQm5lS0NVWXdCd1Rz?= =?utf-8?B?eUp6aGVTL0ZaTXkvVkQ4RUZxeW11VFpLcHZFRlR1Rklkb0ppZHVrcWxGRWpa?= =?utf-8?B?QkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xbl9nrFP/fjaTCX4tEPet2L4nc+yFqygq/gN43dX6gqjebmoPlnEwSqjvx+x77pDV0eJHPa1nsIMq/VBUQdPfwNOyP+s2ghQFDZSnxaseHbrJ6NUELm0MDUFokshhYrCe2KQFPoCAgbXYVg5Hhx+eSSJo3pLF5kTNw6JXNJMoakZFBcqM8G2V6S3tLXw291b7k+WXU5qDroHqspqwdtw70WlWp4Wtb/2WYZpdYBHpjFJqYVFPaYQCxuS6ohSEPY9QTcUIIOaKqfgmimh8ye0g8ci/3FTcNAuZhNzBgsOCKXjrGCAQBa5l6QW+sYaHL0xExxQaHUODytlBwACN+uFVN+KI1WWpAD7cS5HAsa8ajmnSbG5LGAzMaop/YPm1vLoofRubj7WzzebUkq4dX2mcY8LLf8lWbCdxuhBc7OZqirV9UjNV809at1CUFCOkzCiNSRi8GLdmDa2wPvLpVkUOpgv9KUNbYfpr5fHI0SMad2OsI9Ei6EaO7kjgWbKHMP+UiFPzOXtw3TJgIfEnBGw4G231FsO9jrKkCWIa5eZqCMlO7fAyoaMn5CiztYeo456T5GrVZLjoM93UQmNTgI3e85p+6pPpob9wKmrxuQDV7rIGqDEWItW0f1uMwT+WEK/dyt8eL1EFaz8F1T67c9yzJcm5Z6PxVS0E6wQY9cC5alioCrzZVeiEryeBlUkfx0aw5P3fp7zHrHNRrMeM/up/gR3ZZ+pWI0g6Dl7jO8vLnl991JwGvljP/glUL/KKhgVwtB/FWNSTCJl5wjI06kOvlns2W3lrXga/kjEy5c8zIw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b32e2613-20ea-4d19-e43d-08db14363f20 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 18:05:42.5622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VP+HgrlXr8mDGEFicHhtUv6Kt7TghHkEFsXTm10BTi6udWedsF3uMSdA8JJ5txhmSV25wL5KsM2n5ZGaC/BfpKKjTYRWfnaETwZxoHNOEys= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5251 On 21/02/2023 4:55 pm, Anthony PERARD wrote: > Building randconfig on debian unstable seems to be an issue. You're talking about https://gitlab.com/xen-project/people/anthonyper/xen/-/jobs/3769926509 ? + gcc --version gcc (Debian 12.2.0-14) 12.2.0 arch/x86/extable.c: In function 'search_pre_exception_table': arch/x86/extable.c:200:27: error: array subscript -1 is outside array bounds of 'struct exception_table_entry[1152921504606846975]' [-Werror=array-bounds]   200 |     unsigned long fixup = search_one_extable(       |                           ^~~~~~~~~~~~~~~~~~~   201 |         __start___pre_ex_table, __stop___pre_ex_table-1, addr);       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from arch/x86/extable.c:8: ./arch/x86/include/asm/uaccess.h:414:37: note: at offset -8 into object '__stop___pre_ex_table' of size [0, 9223372036854775807]   414 | extern struct exception_table_entry __stop___pre_ex_table[];       |                                     ^~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[3]: *** [Rules.mk:246: arch/x86/extable.o] Error 1 Jan: do we need some more gcc-wrap sprinkled around? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 18:14:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 18:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499155.770197 (Exim 4.92) (envelope-from ) id 1pUX9f-0001sx-Ng; Tue, 21 Feb 2023 18:14:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499155.770197; Tue, 21 Feb 2023 18:14:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUX9f-0001sq-Kn; Tue, 21 Feb 2023 18:14:19 +0000 Received: by outflank-mailman (input) for mailman id 499155; Tue, 21 Feb 2023 18:14:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUX9f-0001sk-5Y for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 18:14:19 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d749f02-b213-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 19:14:18 +0100 (CET) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Feb 2023 13:14:08 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5430.namprd03.prod.outlook.com (2603:10b6:5:2c9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 18:14:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 18:14:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d749f02-b213-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677003257; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=BhC6xaM59cHXUqcukPF5bWhYgZ9GHsHZSNxUSqRFPCA=; b=ggEPs6BKb8N5Jc9BSY7of0xNcGsWqZSyeMYvUb2qx8lENpJTeHjPWaGI m3qFXstIZWxvcxC9zQdoJ+DweOS8wbNOOelq4dgMutI+KRXbomqDR2ADQ nwt+EH54jX+YpUvug15bGgv2sN/dFIev2eGbXmgDV4QA6u+pL3RlFk4Wr o=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 97328888 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8NUBLa1pYXYvhTJbDfbD5fFwkn2cJEfYwER7XKvMYLTBsI5bpzMEy mAdCmrTMqnbajH8et8ibo3k8EIHsZPdxoNrQVZvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfKEdkx KYSb2A3SBGNpMiqx5yVdMZVmZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6KklwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKkA9hCRO3onhJsqE/PnzYfMAIqaUKqruKepGCFWNkBJ 1NBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI89QOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:tf9NSK7Dp+qhc8VnqwPXwM/XdLJyesId70hD6qkRc3xom6mj/P xG88506faZskdyZJhfo6HnBEDwexLhHPdOiOF8AV6MZmbbUQCTXeJfBOXZsljd82WXzIRgPe 0JScVD4JOaNykfsS4biDPIdOod/A== X-IronPort-AV: E=Sophos;i="5.97,315,1669093200"; d="scan'208";a="97328888" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDiNZWVXrD/e3useeeejDi3CLwNlAI369KKQnoW/XtcfARTLY+NY8gHfj7NNwTWGp9rJxpBoxUx8reRP5/p5Fc2vaZHTPAJA518h+Yflh4Qq3ZVm3YGop9AWm9ohgO7zzVzftYKyDhTeh02Wc1KePMCocl7tAnDlVBljXjRRfdQUvIup2mBmQ7J0kpLKSXw6kH6ShzjQioXS6nxUjKjz1zscw2M5hj9x6hkJ6Awhi/+828ihvKj7Bzy4RDZWMrqV42J0A1CTz34GVwhcN6GceYNnIFtFlfOjqf6DO+9TaJMmCl/4o7mlxtTKfMwMrcZSiXDcUBPjSdzSctLYcFb1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ypegoioatRCyWXwJPAOfgkp/o360rWNmzPJTKGTFzL4=; b=ENcU9j7jO5knO1QC83FWOdZG0/Ql2D7i5p1bVbR1TY4tztS1x/d2s/7SejwF6TmnpNvrBkts23nus5+eBjV23sHbZ3TpVJUnfW4gucTPK9d5TcZa1TYBz3lm+FKJA5ZwoxhpHTfM3h4q1mm4q+KojJfIre9E08ALxyaN13hOe0vgakLhGI6bJqwq76hx0t8LQ1/Gs71+MRE7BJjCxL1a2bFSlPaaSrW1aYnrViRsDTEG4+QSn4qxeUf+haSnn7Rldmz49Q2phlQf9ZpM2zJJFbdCBeG/lLF5XxQnbHYnwJG3h7d471kxQNDi4N7t9sDxZM79tKFEKJxK3kdpy7QKCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ypegoioatRCyWXwJPAOfgkp/o360rWNmzPJTKGTFzL4=; b=usqOvNg3C5qORGpBMEeflRizSEDwa908a3HFfn8caeFnZG6P7sz0oyJl9r0xEsW5/9saPKLN8ecM+qxMqDKm3az906xoYkXrHZc4gQk/EZxz9oHSEvMf5ubj6B9VjRhYDzA29KhohzvD93qdbqTyIaVByPcJQGNVp8nSLYuF7cg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <95737b30-f377-7c2a-316f-8dc6ed7a863a@citrix.com> Date: Tue, 21 Feb 2023 18:14:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> <20230220194702.2260181-2-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0174.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5430:EE_ X-MS-Office365-Filtering-Correlation-Id: 7465c398-bb73-4ef2-d8c2-08db14376b9d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXo0wRdUK4iP9qlBtFbzu/oDNWcIuqQ5nl3Nax074obpxlXiUub3Ra6g1DxTt+1gkZE1gT7Gq1EMM097hVbSfnv2/2sbmpw3pl6cSO65MjJVS4DCofj/hyFdp0PZCGrpRrnWZtuTxqdMh3YmbiszsoBw7hBxPzTGHtiN5blmj/V/s5JVKpt7LF591rwpHSVfuM6sXb8BtQiV+c4lqXuGAXIsS3SKagNYlzlF7jEuA8LqMgyWbj7jyDi4a5oS7tAB+lHfRUTRQqxRz5srqbb+N2hh40aSX4AEBH350ze0sZ5pI6x8x8iMLIFPiaZ7dJXZE6KqfJl6dZCnL4tyX4GIplFC3P7wK0lQtRkXYdtFrT5QTmez1RTwhxyzQJjSFTnY6Z5lcmbOANKQiAVGHs3zCqQtEuAnixXb+wkYY1BbeMO9EWVNalGGdxyGb2UUOb3MVanNcrNPoR73COjxOcPD9f0EOH5XVpW5Uc5xfxmEjKX5U7zZQllOKf58302mQKx+Ea9moK+etLZbZbYtoTRk5nAprSDFEQswWvfWtOqU7HAQlsvg1pjRsq9FuUEqA7ncUvVYVMo0aNibASsaAKZ3SYdqO98in8F5tkJBoxRte0nhPMu3HJdhJOMRB46lk5yKqVuQXQ91fhH8rmtwUBheO5FPn2kxQdvSjs+CHTMAyneRqrgiR7v87Cu8HpNsFfsc7Sy4mVmUFM6MzkdFhhUfV7RjOJFfrCECvZkqgZKy86o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199018)(31696002)(86362001)(36756003)(83380400001)(316002)(54906003)(478600001)(6506007)(6666004)(186003)(26005)(31686004)(6486002)(2616005)(53546011)(6512007)(8936002)(5660300002)(2906002)(38100700002)(8676002)(6916009)(4326008)(66476007)(66556008)(66946007)(41300700001)(82960400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3pldUEwY1V0N2Q2QzhhclduZGVRaE1tckNuNVhUSmRMUGtseGRKWlVKNm5k?= =?utf-8?B?U09CUUNHYk54Vy95SitPVk9QNE5pbXlib0dtOXRjVmdvdXZEazd1RkZIaVJr?= =?utf-8?B?dVNENXlaYVgxM2pIS2hlU2RXYTM4ejlRc0RkNzREK0ZTV3NrMEVYNk1tS2R0?= =?utf-8?B?WHl2aWdaWWtyVTd4c2RraDFac25kN1g5aWgxUVlhMXZnbnIxYzhoblFlVlJm?= =?utf-8?B?UnVKZzRBVjhDZFF6bm1MbS9RNGxWUGVPSERqMXVDcUxLd1NMWVpwVGZpWGMv?= =?utf-8?B?SEpyaUJkQVhWWkpBRVJQM3Zob29nWkpNaWJxS3FaN1J5cWpERm9YbUFIMnk0?= =?utf-8?B?d3FkVlJjSTZnK2VQVzh1WW5BQkhwMXpBNEp2KzVua1h5M2JwblM5cHovalV5?= =?utf-8?B?Z1plUEYyQTNLMnpTOEx6UlBYd1hoN1RBSktTN3ZPWnZTeXViVnJuMDBjOW51?= =?utf-8?B?SVBRLzBYQkZWcm5zeEpsNFhUbC9RTWsxcHpDUUVlY1pnd2lMU1Jkenh5TytK?= =?utf-8?B?VnBRTzVBMzZhYkVQV0FiR1N2VyttUmljVnRTL2JTQ2ZWU0Q1a0lNc3Q5NDBl?= =?utf-8?B?YzVBUVFsRDVxV2Z0WTVtVUE3aExVRkdIRnE4WG4yNlFpcStjbXlYMy9sY3Rv?= =?utf-8?B?NmhsMkJ0WUFGS2hZMi9IdUU4TUpPL1JWUVByZjgxcllxcUlteFprKzQyaGJR?= =?utf-8?B?enR2NWZ1U29rVDhPTk9EZW1tYTB2RW9SRFJveUFWbUIrT3M0MFNJdXRibGly?= =?utf-8?B?VExOVzF3QTFjSFFvQzc1NVpsNkpTWE51SnhjSGE4N2xPbnl6WXVPTEd6T0Na?= =?utf-8?B?dHhoVllrdzRhNDBWSHI3eDMycHF5KzZDcnV0bm1PVkErS245RUpZUUtqTFdP?= =?utf-8?B?bU1UZC8wSEV3b1FxZ0gwU2wxbFlGUk5KcHc4Y3hXVVhwRmNINXE1TWh6N1A0?= =?utf-8?B?ejQrZ2xySFFaYldhUWJoc2NUY2M2VER5MTJrQ3Z4Zjdub1BqblZjZG81ekVE?= =?utf-8?B?SWZVY0dRWEEwb3JPdWpxcHVBT29hK2hENVNqTG9DbVV5ZUxtcXdId2hxZjdF?= =?utf-8?B?VWxJSlZvZnU2TnFnVFFTeUc4MWwrSFlmT2V3ZEhKcTUyVjRRekJHWDByTG1G?= =?utf-8?B?WUo3bXVaTnZTK0tzWlhOSU5LeGRUbHB2bDVvUHpkTVlNbDBod1BIbEdkanBU?= =?utf-8?B?WWZqYkdIeVprVGIrREcwTHJUdGtZV05ZbEx6WGJrTlhsQnpLVnVFYW1EcmpL?= =?utf-8?B?Qmw1a3BNVUE1NXFIUmRzUzJpMzVHMFl0VGFnVk13Wjd0VGd4Umg1NWlvWHZs?= =?utf-8?B?OGJtcFlVSGMyN2RkVzBnMlcvNUdNcElyaFdWNHRna2EyaTY5d1JiQXpxRVFy?= =?utf-8?B?V1BOU0tIN280b3BZU3NsQWxIZWY1NGtFYlh2QjIxWmJNcFZhaUVEb0s2N0ZV?= =?utf-8?B?OEIyRWxGVGZSa2lTYk5SRThNVVoyLzE2ZDRQcm5jVDUrQkNrUTRvL3M2Tk9P?= =?utf-8?B?RXE4VXFXTUZ0eU9kUi8vZnZFZGw1NjdHbWNXN1A4dkN0WXJhWTlHNGw3bU90?= =?utf-8?B?R2kvTnBVTHBtNmhvMjJveXJQUnJHYWNZdjNvcXgvWVp6Znk5N1pvdURtc2pO?= =?utf-8?B?eC8zelp3Z1dLWWRTcUhaYmx5bGNMRGh3bzhrcytqdWlCcjBCWFRUVzdMMVlt?= =?utf-8?B?dUhxTDlkaWwrcXdkMG5sZFFuN1RMbitaZmdYeENwMGhFdVdKQ05FOG9YY2hL?= =?utf-8?B?Ump2QUxoVDU5NEFmeG0rTGRkYThDMk9UUS9NWWRudzlxMkl4NllaUFBISVE0?= =?utf-8?B?cU1wcUJ2NmlDZzNQTnZCYW5PcTc1TW12V1dGKy9ZcU5oV3lZZTNkd0JjMTZ3?= =?utf-8?B?d2ZKTWoyelVxOXBtSEFKVjlUZ29TRXFQc3F1Tmc4bmlEVVkrd0c3WGpMUVZy?= =?utf-8?B?ZnFWaG8wTUNVTGdvNzFCY3VEelkxeEhObTRoelBKSWRRRGtnQ2pQZFhkczlG?= =?utf-8?B?d0lzT2t1bktBd3BaR25oOEZhY2FFNG1BeFc0ZWxXNTk5VitTaUJTU3NVcXhw?= =?utf-8?B?UHZReUUycU9GaVdjNCt6TUFKQVVxUmUvMjRsYTRQUkMzWjlIZzlQUHoxM2c3?= =?utf-8?B?SXJWZ3FXVXVjRVpOc1RKSGkvOVNncFlGaC9TcmtxQzZQUHl3S29QQ1dsR2Jn?= =?utf-8?B?aFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1JiPUWqeCebeweaJk5klWlpy8HwECZmH6SMeyRC1v9MLoL3fGqw/m/bd4ioiG7MM4wUSM5F9LxZNFga+/AoLSS1gkPkVlH3jn1RAftAMLP/x3i609gstGX0qGfJzdEeGFlFf+HbmNGjr5KvHOgqd1bPaNBhMJqEVnJh2cPxP5tyGWqC6TpPlUWRqtCzKzUgPRqdLYgdyxIFED3NLqirosVkG8Ucpf483U+a/I7l3PNKE5k5CnNhThlNHzKzb9nkhRT7dxPIZLs7YyNTIbPK6ueL4DpIcF1m1Z+SNiIDMNzJvH8uG1o7V00B5r1a4lNK6Or5dsV+bHBQPBbytQsYmsHMHio7weNrvyPzsTlW1IFAHeF2Kdv/VyZlMF/AgWZm0UImA4uw87sW9nhBxeEjYuHgIAYiW13NpQlyV7B27fpOVf7ZN6446u+32Qs3uu09YjkN/cTKCeLunccPNZKjw944au1v8jooK+UzQT7K7A/LeHZnAPEw4panvdKfimaYyuGTWgySYZ+N1zlI63ORaA8q91JT7FQOb/PkiP9TfQKTfZ2HQ/L5zQCQJmMSAuofkxQ67uB4JR/ekQy1fWXm6eM2D4iaz9PWZS6xTFeoHGMwiO9GKiOn2VAlKS7eXz2NiuoRoFGCDchkPCs/eIybpgVy7nBw8NxK1Jk5It/e4T/sUQ9aWQ2XUzreX8cT2mR73J7GF4O10HgjCpRazaprmu9r0EuRhb8nl+PA3Y9/hViqFl0kWizmxYmUHYI7wB/2twUO6W6ncawowFKd4FsPppYH4t9gwbQJDKr9SVcv912E21r9VGKIAcxuNzWQQTA6K X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7465c398-bb73-4ef2-d8c2-08db14376b9d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 18:14:06.7601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wX3zzaIgjGGQrnSmXVO6Ku+O4uLLS1MI4VBPu6v6/tYm3n7f4+S/AKJGYSeHPnKtDUxaAIlc3uoY/yNhTGp6oiwM9g7p6UaS9mTtld9UN2w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5430 On 21/02/2023 1:40 pm, Jan Beulich wrote: > On 20.02.2023 20:47, Andrew Cooper wrote: >> Despite its name, the irq{save,restore}() APIs are only intended to >> conditionally disable and re-enable interrupts. > Are they? Yes, absolutely. And as said before, the potentially dubious naming does not give us permission or the right to interpret the behaviour differently. > Maybe nowadays they indeed are, but I couldn't spot any wording > to this effect in Linux'es Documentation/ (and I don't think we have > anywhere such could be put). Yet I'd expect such a statement to be backed > by something. It is backed by the rude words the owners of this API had to say on discovering this particular use. Conditionally enabling with a construct like this is bogus everywhere.  It is only ever safe to enable irqs if you know exactly why they were disabled previously, and that can never be the case with a construct like this. It only reason this one example doesn't explode is because its an init path not nested within an irq/irqsave lock or other critical region. > >> IO-APIC's timer_irq_works() violates this intention. As it is init code, >> switch to simple irq enable/disable(). > If all callers of the function obviously did have interrupts off, I might > agree. But the last of them sits _after_ local_irq_restore(), and all of > this is called from underneath smp_prepare_cpus() Which do you mean "the last of them" ? There is a large amount of genuinely dead logic here. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 21 20:27:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 20:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499171.770208 (Exim 4.92) (envelope-from ) id 1pUZE3-0001wx-9F; Tue, 21 Feb 2023 20:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499171.770208; Tue, 21 Feb 2023 20:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUZE3-0001wq-6X; Tue, 21 Feb 2023 20:26:59 +0000 Received: by outflank-mailman (input) for mailman id 499171; Tue, 21 Feb 2023 20:26:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUZE2-0001wg-9W; Tue, 21 Feb 2023 20:26:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUZE2-0003jX-3S; Tue, 21 Feb 2023 20:26:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUZE1-0005gv-NA; Tue, 21 Feb 2023 20:26:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUZE1-0003qC-Mj; Tue, 21 Feb 2023 20:26:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=knI8V3Vr5+zFguCdIQS9Ky5Qm/z+GDf1SPl6Rhf30Eg=; b=zhHCbfV6aoqkTH4U2CrzKa2K16 xvhV5jKlYISequPbyJVgOSu4RdgnK7zathY/7o/AkSn5GIHGyHCeQs40V50Gh/MU/3ZLHO3jv42ep GvvuZRu5RmvJtk7EATCAeKjOvhlkBqHq01JZB4Vmi3XF4EYBo3wBYT6Qu/180TXA2SiQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178044: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd X-Osstest-Versions-That: xen=d58f3941ce3f8943df842fab2d4d761c483af6c4 From: osstest service owner Date: Tue, 21 Feb 2023 20:26:57 +0000 flight 178044 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178044/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd baseline version: xen d58f3941ce3f8943df842fab2d4d761c483af6c4 Last test of basis 178030 2023-02-21 15:00:25 Z 0 days Testing same since 178044 2023-02-21 18:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d58f3941ce..c76e4ff7d5 c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 21 21:26:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 21:26:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499179.770220 (Exim 4.92) (envelope-from ) id 1pUa9T-0001d7-Od; Tue, 21 Feb 2023 21:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499179.770220; Tue, 21 Feb 2023 21:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUa9T-0001d0-LV; Tue, 21 Feb 2023 21:26:19 +0000 Received: by outflank-mailman (input) for mailman id 499179; Tue, 21 Feb 2023 21:26:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUa9R-0001ct-Im for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 21:26:17 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f7d91f8-b22e-11ed-a089-e9535cc0f9c3; Tue, 21 Feb 2023 22:26:16 +0100 (CET) Received: by mail-ed1-x531.google.com with SMTP id h16so22842476edz.10 for ; Tue, 21 Feb 2023 13:26:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f7d91f8-b22e-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ontRbTiCbaS8agLcerZLCHDWnInQNV4DuMau5l48sng=; b=Z2SdCEOJV2uEqpU/ui01AbLiSvckGBYIL0kDcq6C4PfHbKn8Xp3w+OjZ58QEHq1n0u kbRPx/Jpz8l5iPY5NloYHCZXcFt0KY1VN5KCWXo/yb5FCcEsfmOol4rSS014iP+qW1QG FjeJGngd8+QZQ7JT9r7PVNHhu953/PxaHD58Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ontRbTiCbaS8agLcerZLCHDWnInQNV4DuMau5l48sng=; b=FlqX1ZzcPfjhYcV18MtTiOsHf6x2Gl7cdQIrUEgf7KQ6vyYRKDQocaKVS2OaXxSOIx J9iFIcAmSTwZAWuUKI4HlbcO5QQPvj9LZqYClRF75PzqQ6qqo5OaFUf19uA8uyXY05V+ 6YkJ9DPQdDtXEoSF3qOlDaJTnT5LPGXAL86cEwPJ8zITo4nVd/5xAatms1k9X/JweXwL fHUT+zWoWfz8+1cQbzXLxs1NmwKM3rcJ+1VSnBImUjXO+8LUrN2CPtB3L/t/CuxPeJxy geHn7+wq+ouIIeEiC84eXUfLecCmAvW7skVL74d/zYsxM7LK95SOvWwN2wX2W5b9KH8P ij3Q== X-Gm-Message-State: AO0yUKVYYjC3LTJQ32nJz3TDFZzzVonaj33PmgyxwIECF/IMgUQDlbvh 0XFd4Nn03dRjeiIKdz6PIy2Fx3LLt1D1rPYHWJ3Wew== X-Google-Smtp-Source: AK7set/YpaYTqoZo2mpFEA1k42RwEc7aebJptWLdzOAdx42NV9ZnuPkQKmxJ+u3ftwvPJHOZJysmg0f++o3oqetZ75M= X-Received: by 2002:a17:906:4f0b:b0:8b2:d871:d74a with SMTP id t11-20020a1709064f0b00b008b2d871d74amr6639811eju.10.1677014775450; Tue, 21 Feb 2023 13:26:15 -0800 (PST) MIME-Version: 1.0 References: <20230215153846.18582-1-sergey.dyasli@citrix.com> <20230215153846.18582-3-sergey.dyasli@citrix.com> In-Reply-To: From: Sergey Dyasli Date: Tue, 21 Feb 2023 21:26:04 +0000 Message-ID: Subject: Re: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Sergey Dyasli , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Tue, Feb 21, 2023 at 2:03 PM Jan Beulich wrote: > > On 15.02.2023 16:38, Sergey Dyasli wrote: > > --- a/xen/arch/x86/cpu/microcode/core.c > > +++ b/xen/arch/x86/cpu/microcode/core.c > > @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( > > (!ucode_in_nmi && cpu == primary) ) > > return 0; > > > > - if ( cpu == primary ) > > + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) > > Given their origin, I'm pretty certain Hygon wants treating the same here > and below. Hygon? ucode_ops is currently initialised only for Amd and Intel. Speaking of which, I'm thinking about adding a new function is_cpu_primary() there. This would make the core code much cleaner. I'll see if I can make it work. Thanks, Sergey From xen-devel-bounces@lists.xenproject.org Tue Feb 21 22:36:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 22:36:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499190.770231 (Exim 4.92) (envelope-from ) id 1pUbFB-0002SG-TU; Tue, 21 Feb 2023 22:36:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499190.770231; Tue, 21 Feb 2023 22:36:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbFB-0002S9-Qo; Tue, 21 Feb 2023 22:36:17 +0000 Received: by outflank-mailman (input) for mailman id 499190; Tue, 21 Feb 2023 22:36:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbFA-0002S2-G9 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 22:36:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbF9-0006jI-Bw; Tue, 21 Feb 2023 22:36:15 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUbF9-0001M9-6V; Tue, 21 Feb 2023 22:36:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=8N7ZTxZRpwrluNySXgT83M02a08yev1m+nEgeD0g1zU=; b=ERs3UxJVspoKio5b59Zw04RBbz Cxnr6dLB37UZIYPLSIWLVgZp+QXa8LOh14pAky+T9bE9AZ2NjWFvExirAWHMukVdXHBKiDlPupkIi zIGsMT+ylyrOsNquTtYEwVm0/zEi7AtxAoX/bqW6Nv1+5fBB99mRgE1gW2XpxKrtOgmw=; Message-ID: <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> Date: Tue, 21 Feb 2023 22:36:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> From: Julien Grall Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 21/02/2023 08:10, Juergen Gross wrote: > On 20.02.23 19:01, Julien Grall wrote: >> So I have recreated an XTF test which I think match what you wrote [1]. >> >> It is indeed failing without your patch. But then there are still some >> weird behavior here. >> >> I would expect the creation of the node would also fail if instead of >> removing the node if removed outside of the transaction. >> >> This is not the case because we are looking at the current quota. So >> shouldn't we snapshot the global count? > > As we don't do a global snapshot of the data base for a transaction > (this was > changed due to huge memory needs, bad performance, and a higher transaction > failure rate), I am a bit surprised that the only way to do proper transaction is to have a global snapshot. Instead, you could have an overlay. > I don't think we should snapshot the count either. But that would mean that the quota will change depending on modification of the global database while the transaction is inflight. I guess this is not better nor worse that the current situation. But it is still really confusing for a client because: 1) The error could happen at random point 2) You may see an inconsistent database as nodes are only cached when they are first accessed > A transaction is performed atomically at the time it is finished. Therefore > seeing the current global state inside the transaction (with the > transaction > private state on top like an overlay) is absolutely fine IMO. To me it is just showing that our concept of transaction is very broken in C Xenstored. I am curious to know whether OXenstored is behaving the same way. Anyway, I agree this is not better nor worse than the current situation. So I will acked this patch: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 21 22:42:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 22:42:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499196.770243 (Exim 4.92) (envelope-from ) id 1pUbLL-0004Bu-KF; Tue, 21 Feb 2023 22:42:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499196.770243; Tue, 21 Feb 2023 22:42:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbLL-0004Bn-Eq; Tue, 21 Feb 2023 22:42:39 +0000 Received: by outflank-mailman (input) for mailman id 499196; Tue, 21 Feb 2023 22:42:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbLK-0004Bh-NR for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 22:42:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbLJ-0006zv-Sx; Tue, 21 Feb 2023 22:42:37 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUbLJ-0001cJ-O3; Tue, 21 Feb 2023 22:42:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=PfEg1fMfXnnEetfIB7XGPVKIr8vDaNbxhGpoEd0ZMZI=; b=COfpxK4CRWsDk8KfGZRpM0C6rD tqja7xKnvNcrJm5COl+Cf6KhOOGLBYhsUOZb7hvxOI7srpcQzhn5nZEKJJ/0HjrWT/nWdiJ1fhwqn voADAStmLsxIcJVXQz4t5zaFDmGBT/50riGAFmE+EDiYSXOu4EnGajt53V+nuMVVDUZs=; Message-ID: <6b9b0afc-da89-6f6f-859f-c8f7ae0be972@xen.org> Date: Tue, 21 Feb 2023 22:42:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> From: Julien Grall Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only In-Reply-To: <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 21/02/2023 08:37, Juergen Gross wrote: > On 20.02.23 23:50, Julien Grall wrote: >>> +        list_del(&cd->list); >>> +        talloc_free(cd); >>> +    } >>> +} >>> + >>> +void acc_commit(struct connection *conn) >>> +{ >>> +    struct changed_domain *cd; >>> +    struct buffered_data *in = conn->in; >>> +    enum accitem what; >>> + >>> +    conn->in = NULL; /* Avoid recursion. */ >> >> I am not sure I understand this comment. Can you provide more details >> where the recursion would happen? > > domain_acc_add() might do temporary accounting if conn->in isn't NULL. I am confused. To me recursion means the function (or the caller) will call itself. But here you seem to say you just want to avoid temporary accounting. What did I miss? > >> >>> +    while ((cd = list_top(&conn->acc_list, struct changed_domain, >>> list))) { >> >> NIT: You could use list_for_each_safe(); > > Like above. > >> >>> +        list_del(&cd->list); >>> +        for (what = 0; what < ACC_REQ_N; what++) >> >> There is a chance that some compiler will complain about this line >> because ACC_REQ_N = 0. So this would always be true. Therefore... > > Huh? It would always be false. Yes false sorry. This doesn't change about the potential (temporary) warning. > >> >>> +            if (cd->acc[what]) >>> +                domain_acc_add(conn, cd->domid, what, >>> +                           cd->acc[what], true); >>> + >>> +        talloc_free(cd); >>> +    } >>> + >>> +    conn->in = in; >>> +} >>> + >>>   int domain_nbentry_inc(struct connection *conn, unsigned int domid) >>>   { >>>       return (domain_acc_add(conn, domid, ACC_NODES, 1, false) < 0) >>> diff --git a/tools/xenstore/xenstored_domain.h >>> b/tools/xenstore/xenstored_domain.h >>> index 8259c114b0..cd85bd0cad 100644 >>> --- a/tools/xenstore/xenstored_domain.h >>> +++ b/tools/xenstore/xenstored_domain.h >>> @@ -20,7 +20,8 @@ >>>   #define _XENSTORED_DOMAIN_H >>>   enum accitem { >>> -    ACC_NODES, >>> +    ACC_REQ_N,       /* Number of elements per request and domain. */ >>> +    ACC_NODES = ACC_REQ_N, >> >> I would bring forward the change in patch #5. I mean: >> >> ACC_NODES, >> ACC_REQ_N > > I'm not sure this is a good idea. This would activate the temporary > accounting for nodes, but keeping the error handling active. I'd rather > activate temporary accounting for nodes together with removing the > accounting correction in the error handling. I am not sure I fully understand what you would rather do. Can you clarify? > >> >>>       ACC_TR_N,        /* Number of elements per transaction and >>> domain. */ >>>       ACC_N = ACC_TR_N /* Number of elements per domain. */ >>>   }; >> >> This enum is getting extremely confusing. There are many "number of >> elements per ... domain". Can you clarify? > > I will add some more comments to the header. Would you like it better to > have > the limits indented more? something like: I am afraid it doesn't help understanding the comment. For instance, > > enum accitem { >         ACC_NODES, >         /* Number of elements per request and domain. */ you wrote "per request and domain" here. But... >         ACC_REQ_N, >         /* Number of elements per transaction and domain. */ ... here this is "per transaction and domain". Should not nbe "elements per transaction"? And if not, then why don't we had "per request, transaction and domain" above? >             ACC_TR_N = ACC_REQ_N, >         ACC_WATCH = ACC_TR_N, >         ACC_OUTST, >         ACC_MEM, >         ACC_TRANS, >         ACC_TRANSNODES, >         ACC_NPERM, >         ACC_PATHLEN, >         ACC_NODESZ, >         /* Number of elements per domain. */ >             ACC_N > }; > > > Juergen > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 21 22:45:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 22:45:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499204.770253 (Exim 4.92) (envelope-from ) id 1pUbOK-0004ss-5T; Tue, 21 Feb 2023 22:45:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499204.770253; Tue, 21 Feb 2023 22:45:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbOK-0004sl-1e; Tue, 21 Feb 2023 22:45:44 +0000 Received: by outflank-mailman (input) for mailman id 499204; Tue, 21 Feb 2023 22:45:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbOI-0004sf-N2 for xen-devel@lists.xenproject.org; Tue, 21 Feb 2023 22:45:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbOH-00074I-TL; Tue, 21 Feb 2023 22:45:41 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUbOH-0001ny-Ol; Tue, 21 Feb 2023 22:45:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yEp5jb+jc4Za9n0DzJuymd9meDiECOlMQO4b/Lk3Mhs=; b=yqgVrwYnwVjC4F1ahVRzuMBvtS bckUxW4q/mGzJC2MtcsES7D+e150ktfCuuqZlGMo9y4jXfmljZBIf+zMMWlG9KmNjXKL+8+xeaA/C CeQti9F5kfhr0eTj7Z++axI38itNAiXsPTRWqX3CBOQ7yyaqZK9AHLONtSVAqxw3RKoA=; Message-ID: <4ab275aa-3ff6-68cf-e307-bbe119d285d3@xen.org> Date: Tue, 21 Feb 2023 22:45:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 08/13] tools/xenstore: add accounting trace support To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-9-jgross@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 21/02/2023 08:40, Juergen Gross wrote: > On 20.02.23 23:57, Julien Grall wrote: >> Hi Juergen, >> >> On 20/01/2023 10:00, Juergen Gross wrote: >>> Add a new trace switch "acc" and the related trace calls. >>> >>> The "acc" switch is off per default. >>> >>> Signed-off-by: Juergen Gross >> >> With one reamrk (see below): >> >> Reviewed-by: Julien Grall >> >>> --- >>>   tools/xenstore/xenstored_core.c   |  2 +- >>>   tools/xenstore/xenstored_core.h   |  1 + >>>   tools/xenstore/xenstored_domain.c | 10 ++++++++++ >>>   3 files changed, 12 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/xenstore/xenstored_core.c >>> b/tools/xenstore/xenstored_core.c >>> index 6ef60179fa..558ef491b1 100644 >>> --- a/tools/xenstore/xenstored_core.c >>> +++ b/tools/xenstore/xenstored_core.c >>> @@ -2746,7 +2746,7 @@ static void set_quota(const char *arg, bool soft) >>>   /* Sorted by bit values of TRACE_* flags. Flag is (1u << index). */ >>>   const char *const trace_switches[] = { >>> -    "obj", "io", "wrl", >>> +    "obj", "io", "wrl", "acc", >>>       NULL >>>   }; >>> diff --git a/tools/xenstore/xenstored_core.h >>> b/tools/xenstore/xenstored_core.h >>> index 1f811f38cb..3e0734a6c6 100644 >>> --- a/tools/xenstore/xenstored_core.h >>> +++ b/tools/xenstore/xenstored_core.h >>> @@ -302,6 +302,7 @@ extern unsigned int trace_flags; >>>   #define TRACE_OBJ    0x00000001 >>>   #define TRACE_IO    0x00000002 >>>   #define TRACE_WRL    0x00000004 >>> +#define TRACE_ACC    0x00000008 >>>   extern const char *const trace_switches[]; >>>   int set_trace_switch(const char *arg); >>> diff --git a/tools/xenstore/xenstored_domain.c >>> b/tools/xenstore/xenstored_domain.c >>> index b1e29edb7e..d461fd8cc8 100644 >>> --- a/tools/xenstore/xenstored_domain.c >>> +++ b/tools/xenstore/xenstored_domain.c >>> @@ -538,6 +538,12 @@ static struct domain >>> *find_domain_by_domid(unsigned int domid) >>>       return (d && d->introduced) ? d : NULL; >>>   } >>> +#define trace_acc(...)                \ >> >> The indentation of '\' looks odd. > > Not for me. Maybe you have a different tab setting? I only looked at the code from my mail client. In my editor, it looks OK. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 21 23:19:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 21 Feb 2023 23:19:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499210.770264 (Exim 4.92) (envelope-from ) id 1pUbuQ-0000th-Hf; Tue, 21 Feb 2023 23:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499210.770264; Tue, 21 Feb 2023 23:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbuQ-0000tA-Er; Tue, 21 Feb 2023 23:18:54 +0000 Received: by outflank-mailman (input) for mailman id 499210; Tue, 21 Feb 2023 23:18:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbuP-0000mR-2p; Tue, 21 Feb 2023 23:18:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbuO-0007mj-V8; Tue, 21 Feb 2023 23:18:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUbuO-0003dG-Lt; Tue, 21 Feb 2023 23:18:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUbuO-000226-LP; Tue, 21 Feb 2023 23:18:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=khYI2RItDnHzhK+YwSgZ8tlb7+Z/zYKAjR4SQMisgdU=; b=Zf17pun6/PVyXksfSZOv5Nbk2e fbIOqXtAI8BXeRLbs9Ce07dLx7IWYE8oGAS+7Fm8mtCVB5ILU6f0r4XnB6QgOHQ+AaIxx1+WS771R vwpw73Hl7uIG6K8ikddcxHLqLwOilUeW3NRasC65lZO/ei2w/Orvj/kr2ywcsKgGYEr4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178027: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a90a0018f605e3bb0588816e5a1f957d6e4562eb X-Osstest-Versions-That: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac From: osstest service owner Date: Tue, 21 Feb 2023 23:18:52 +0000 flight 178027 xen-unstable real [real] flight 178060 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178027/ http://logs.test-lab.xenproject.org/osstest/logs/178060/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail REGR. vs. 177972 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 178060-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 178060 like 177972 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177972 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177972 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177972 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177972 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 177972 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a90a0018f605e3bb0588816e5a1f957d6e4562eb baseline version: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac Last test of basis 177972 2023-02-21 01:54:03 Z 0 days Testing same since 178027 2023-02-21 14:38:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit a90a0018f605e3bb0588816e5a1f957d6e4562eb Author: Xenia Ragiadakou Date: Fri Feb 17 20:48:11 2023 +0200 x86/svm: cleanup svm.c Do not include the headers: xen/irq.h asm/hvm/svm/intr.h asm/io.h asm/mem_sharing.h asm/regs.h because none of the declarations and macro definitions in them is used. Sort the rest of the headers alphabetically. Remove the forward declaration of svm_function_table and place start_svm() after the svm_function_table's definition. Replace double new lines with one. No functional change intended. Signed-off-by: Xenia Ragiadakou Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Feb 22 01:43:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 01:43:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499229.770281 (Exim 4.92) (envelope-from ) id 1pUeAC-0000jz-C4; Wed, 22 Feb 2023 01:43:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499229.770281; Wed, 22 Feb 2023 01:43:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUeAC-0000js-8b; Wed, 22 Feb 2023 01:43:20 +0000 Received: by outflank-mailman (input) for mailman id 499229; Wed, 22 Feb 2023 01:43:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUeAB-0000jm-R0 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 01:43:19 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47c8d55a-b252-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 02:43:18 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B2FCB811C5; Wed, 22 Feb 2023 01:43:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 416B0C4339C; Wed, 22 Feb 2023 01:43:16 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 22161C43151; Wed, 22 Feb 2023 01:43:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47c8d55a-b252-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677030196; bh=Ot4IlMt86aLhIt4eznKFWGHa4CeI1g3LzAsedP1CeGU=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=oeZVUqDzX5xEOo/Nai3x2ChVWabCoMF1MLh4pTLSJ9CCk2tGseSE7Phs2ibL3+PSr SRZBBv9fbUXgHIBazveRH41MmAxFnMG3OGh2LecINwbpgVrKCScnRSFjf59U1KUo8A CHp5aPSIoLfVbChQyTcuI3x4lpF+hTqZ3kuebqNhvbkzXYXB7PgKGTcZRyGIKme7Ha rNjlbXKfFX0DCyrUnVZhM8dzCYqvhD/M9QrmNqYe8A3FUZoc7f8s9yvQwxSjdM1iFH zGXYaRt50N+eWxBisfoAuA4NIR3e1YLJayAxH1gh9GkO05T3r41FsuRXJPVtJpN65d UAAVbmIdYmoZA== Subject: Re: [GIT PULL] xen: branch for v6.3-rc1 From: pr-tracker-bot@kernel.org In-Reply-To: <20230219053326.4980-1-jgross@suse.com> References: <20230219053326.4980-1-jgross@suse.com> X-PR-Tracked-List-Id: Xen developer discussion X-PR-Tracked-Message-Id: <20230219053326.4980-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.3-rc1-tag X-PR-Tracked-Commit-Id: 4ecc96cba8d93d86abf46d17067e9b4c96241a29 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 239451e90355be68130410ef8fadef8cd130a35d Message-Id: <167703019613.10177.1154874445058167246.pr-tracker-bot@kernel.org> Date: Wed, 22 Feb 2023 01:43:16 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Sun, 19 Feb 2023 06:33:26 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.3-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/239451e90355be68130410ef8fadef8cd130a35d Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Wed Feb 22 04:59:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 04:59:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499236.770292 (Exim 4.92) (envelope-from ) id 1pUhDb-0007MI-BD; Wed, 22 Feb 2023 04:59:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499236.770292; Wed, 22 Feb 2023 04:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUhDb-0007MB-7Q; Wed, 22 Feb 2023 04:59:03 +0000 Received: by outflank-mailman (input) for mailman id 499236; Wed, 22 Feb 2023 04:59:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUhDa-0007M1-1i; Wed, 22 Feb 2023 04:59:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUhDZ-0006ui-VS; Wed, 22 Feb 2023 04:59:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUhDZ-0001El-MY; Wed, 22 Feb 2023 04:59:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUhDZ-0004uy-M9; Wed, 22 Feb 2023 04:59:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x7eTyLUsr5JhVRadd+c6o7AixQ312UI3FibgTbgfJxY=; b=B++d6JRizy8LaZN/QMwDiCBONL je3DLlFhg8ey1tOh/GPcsc5XJp7zP3rOHJZXzdtCNPbm5SrHB3q2Z+CeJT9KcRVplMfzMYRTJ95mB bc7mfXi1wqUN9xX7iUOiQJDM+ek4h5M7Uzp3Pp5jiur50xSSeUWh40ybgnxCEjDiejKs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178042: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 X-Osstest-Versions-That: linux=89f5349e0673322857bd432fa23113af56673739 From: osstest service owner Date: Wed, 22 Feb 2023 04:59:01 +0000 flight 178042 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178042/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177979 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177979 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177979 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177979 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177979 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 baseline version: linux 89f5349e0673322857bd432fa23113af56673739 Last test of basis 177979 2023-02-21 03:27:38 Z 1 days Testing same since 178042 2023-02-21 17:44:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Halaney # sa8540p-ride Ashok Raj Babu Moger Borislav Petkov (AMD) Borislav Petkov Brian Gerst Guangju Wang[baidu] Ingo Molnar Li Zhang Linus Torvalds Manivannan Sadhasivam Peter Zijlstra (Intel) Peter Zijlstra Qiuxu Zhuo Reinette Chatre Sai Krishna Potthuri Sebastian Andrzej Siewior Shuah Khan Shubhrajyoti Datta Shubhrajyoti Datta Smita Koralahalli Steev Klimaszewski # Thinkpad X13s Thomas Gleixner Tony Luck Yazen Ghannam Youquan Song jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 89f5349e0673..3f0b0903fde5 3f0b0903fde584a7398f82fc00bf4f8138610b87 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Feb 22 08:13:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 08:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499259.770323 (Exim 4.92) (envelope-from ) id 1pUkG2-0005yA-Qh; Wed, 22 Feb 2023 08:13:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499259.770323; Wed, 22 Feb 2023 08:13:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkG2-0005y3-Na; Wed, 22 Feb 2023 08:13:46 +0000 Received: by outflank-mailman (input) for mailman id 499259; Wed, 22 Feb 2023 08:13:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkG2-0005xt-96; Wed, 22 Feb 2023 08:13:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkG2-0003nt-7W; Wed, 22 Feb 2023 08:13:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkG1-00012E-Tw; Wed, 22 Feb 2023 08:13:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUkG1-0003EH-TS; Wed, 22 Feb 2023 08:13:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GJHqBQOgOu1eEg/qcOnIAJ20Jx7tJ3TfQrci7MhJWb4=; b=Lebns8odVIpngaNFgx9RgtuK+u TYmJHkSSF5BqmRn5LrLgpe9wNr81ko8oTYnIOlNXe0ww7fe97O/+aBkI3NT2aejsIDdux4/HcmzVN 2pMWIzSoaxiSimmeZGVlJ2G3EdR5eYCrRb4pi4T16e7PpxUBUW9HCn8mPMk7LjcGKhdA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178070: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd X-Osstest-Versions-That: xen=406cea1970535cd7b9d6bcf09bc164ef9bb64bac From: osstest service owner Date: Wed, 22 Feb 2023 08:13:45 +0000 flight 178070 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178070/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177972 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177972 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177972 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177972 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177972 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177972 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd baseline version: xen 406cea1970535cd7b9d6bcf09bc164ef9bb64bac Last test of basis 177972 2023-02-21 01:54:03 Z 1 days Failing since 178027 2023-02-21 14:38:42 Z 0 days 2 attempts Testing same since 178070 2023-02-21 23:39:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Sergey Dyasli Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 406cea1970..c76e4ff7d5 c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd -> master From xen-devel-bounces@lists.xenproject.org Wed Feb 22 08:37:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 08:37:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499267.770334 (Exim 4.92) (envelope-from ) id 1pUkcX-0000OH-LF; Wed, 22 Feb 2023 08:37:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499267.770334; Wed, 22 Feb 2023 08:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkcX-0000OA-IT; Wed, 22 Feb 2023 08:37:01 +0000 Received: by outflank-mailman (input) for mailman id 499267; Wed, 22 Feb 2023 08:37:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkcX-0000O4-3q for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 08:37:01 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1274ca40-b28c-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 09:36:59 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 233DF228F9; Wed, 22 Feb 2023 08:36:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC3E9133E0; Wed, 22 Feb 2023 08:36:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K06/NyrU9WNDQwAAMHmgww (envelope-from ); Wed, 22 Feb 2023 08:36:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1274ca40-b28c-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677055019; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FSvkwpS+jevzLkevzDTODVOyCqQ74bUHwd9/ScJ05bA=; b=NzkbiouZrk7ZuJbF2HKFeDCMIIIoYAK+/CpuCM8u5jR+RrF1sYrTh3Zf4hFHeImbwq1vIW fg8mlEOlefinO9qtm2HElQ2SaTm+i8/mNJx7queAd07ro0lV8SjWUuVZ5siWAwqTrZO6BG 5GduDMOo3p9ibSmU55qiK8nLG0LN0dY= Message-ID: <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> Date: Wed, 22 Feb 2023 09:36:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction In-Reply-To: <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------9XTjrhiQF0Bj5j3V9YUY1SW7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------9XTjrhiQF0Bj5j3V9YUY1SW7 Content-Type: multipart/mixed; boundary="------------TMLBY3hUp3T9eul5peV8Eq4Q"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Message-ID: <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> In-Reply-To: <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> --------------TMLBY3hUp3T9eul5peV8Eq4Q Content-Type: multipart/mixed; boundary="------------HdBmljjmTIy142tzzkiK21Qy" --------------HdBmljjmTIy142tzzkiK21Qy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDIuMjMgMjM6MzYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIxLzAyLzIwMjMgMDg6MTAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyMC4wMi4yMyAxOTowMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IFNvIEkgaGF2ZSBy ZWNyZWF0ZWQgYW4gWFRGIHRlc3Qgd2hpY2ggSSB0aGluayBtYXRjaCB3aGF0IHlvdSB3cm90 ZSBbMV0uDQo+Pj4NCj4+PiBJdCBpcyBpbmRlZWQgZmFpbGluZyB3aXRob3V0IHlvdXIgcGF0 Y2guIEJ1dCB0aGVuIHRoZXJlIGFyZSBzdGlsbCBzb21lIHdlaXJkIA0KPj4+IGJlaGF2aW9y IGhlcmUuDQo+Pj4NCj4+PiBJIHdvdWxkIGV4cGVjdCB0aGUgY3JlYXRpb24gb2YgdGhlIG5v ZGUgd291bGQgYWxzbyBmYWlsIGlmIGluc3RlYWQgb2YgDQo+Pj4gcmVtb3ZpbmcgdGhlIG5v ZGUgaWYgcmVtb3ZlZCBvdXRzaWRlIG9mIHRoZSB0cmFuc2FjdGlvbi4NCj4+Pg0KPj4+IFRo aXMgaXMgbm90IHRoZSBjYXNlIGJlY2F1c2Ugd2UgYXJlIGxvb2tpbmcgYXQgdGhlIGN1cnJl bnQgcXVvdGEuIFNvIA0KPj4+IHNob3VsZG4ndCB3ZSBzbmFwc2hvdCB0aGUgZ2xvYmFsIGNv dW50Pw0KPj4NCj4+IEFzIHdlIGRvbid0IGRvIGEgZ2xvYmFsIHNuYXBzaG90IG9mIHRoZSBk YXRhIGJhc2UgZm9yIGEgdHJhbnNhY3Rpb24gKHRoaXMgd2FzDQo+PiBjaGFuZ2VkIGR1ZSB0 byBodWdlIG1lbW9yeSBuZWVkcywgYmFkIHBlcmZvcm1hbmNlLCBhbmQgYSBoaWdoZXIgdHJh bnNhY3Rpb24NCj4+IGZhaWx1cmUgcmF0ZSksIA0KPiANCj4gSSBhbSBhIGJpdCBzdXJwcmlz ZWQgdGhhdCB0aGUgb25seSB3YXkgdG8gZG8gcHJvcGVyIHRyYW5zYWN0aW9uIGlzIHRvIGhh dmUgYSANCj4gZ2xvYmFsIHNuYXBzaG90LiBJbnN0ZWFkLCB5b3UgY291bGQgaGF2ZSBhbiBv dmVybGF5Lg0KDQpJIGRpZG4ndCBzYXkgdGhhdCBhIGdsb2JhbCBzbmFwc2hvdCBpcyB0aGUg b25seSB3YXkuIEFuZCB3ZSBhcmUgdXNpbmcgYW4NCm92ZXJsYXkuDQoNCj4gDQo+PiBJIGRv bid0IHRoaW5rIHdlIHNob3VsZCBzbmFwc2hvdCB0aGUgY291bnQgZWl0aGVyLg0KPiANCj4g QnV0IHRoYXQgd291bGQgbWVhbiB0aGF0IHRoZSBxdW90YSB3aWxsIGNoYW5nZSBkZXBlbmRp bmcgb24gbW9kaWZpY2F0aW9uIG9mIHRoZSANCj4gZ2xvYmFsIGRhdGFiYXNlIHdoaWxlIHRo ZSB0cmFuc2FjdGlvbiBpcyBpbmZsaWdodC4NCg0KSSByZWFsbHkgZG9uJ3Qgc2VlIHRoZSBw cm9ibGVtIHdpdGggdGhhdC4gQnV0IGl0IHNlZW1zIG91ciB2aWV3cyBhcmUgZGlmZmVyZW50 DQppbiB0aGlzIGNhc2UuDQoNCj4gSSBndWVzcyB0aGlzIGlzIG5vdCBiZXR0ZXIgbm9yIHdv cnNlIHRoYXQgdGhlIGN1cnJlbnQgc2l0dWF0aW9uLiBCdXQgaXQgaXMgc3RpbGwgDQo+IHJl YWxseSBjb25mdXNpbmcgZm9yIGEgY2xpZW50IGJlY2F1c2U6DQo+ICDCoCAxKSBUaGUgZXJy b3IgY291bGQgaGFwcGVuIGF0IHJhbmRvbSBwb2ludA0KDQpZZXMsIGxpa2Ugd2l0aG91dCBh IHRyYW5zYWN0aW9uLg0KDQo+ICDCoCAyKSBZb3UgbWF5IHNlZSBhbiBpbmNvbnNpc3RlbnQg ZGF0YWJhc2UgYXMgbm9kZXMgYXJlIG9ubHkgY2FjaGVkIHdoZW4gdGhleSANCj4gYXJlIGZp cnN0IGFjY2Vzc2VkDQoNCkl0IGlzbid0IGluY29uc2lzdGVudCBhdCBhbGwuIFRoZSBzYW1l IGNvdWxkIGhhcHBlbiBpZiBzdWNoIG90aGVyIG5vZGVzIGFyZQ0KYWRkZWQvbW9kaWZpZWQv cmVtb3ZlZCBqdXN0IGEgbWljcm9zZWNvbmQgYmVmb3JlIHlvdSBzdGFydCB0aGUgdHJhbnNh Y3Rpb24uDQpZb3Ugd29uJ3QgYmUgYWJsZSB0byB0ZWxsIHRoZSBkaWZmZXJlbmNlLiBZb3Ug Y2FuIG9ubHkgcmVhc29uIGFib3V0IG5vZGVzDQpiZWluZyBhY2Nlc3NlZCBpbiB0aGUgdHJh bnNhY3Rpb24sIGFuZCB0aG9zZSBhcmUgdHJhbnNhY3Rpb24tbG9jYWwuDQoNCj4+IEEgdHJh bnNhY3Rpb24gaXMgcGVyZm9ybWVkIGF0b21pY2FsbHkgYXQgdGhlIHRpbWUgaXQgaXMgZmlu aXNoZWQuIFRoZXJlZm9yZQ0KPj4gc2VlaW5nIHRoZSBjdXJyZW50IGdsb2JhbCBzdGF0ZSBp bnNpZGUgdGhlIHRyYW5zYWN0aW9uICh3aXRoIHRoZSB0cmFuc2FjdGlvbg0KPj4gcHJpdmF0 ZSBzdGF0ZSBvbiB0b3AgbGlrZSBhbiBvdmVybGF5KSBpcyBhYnNvbHV0ZWx5IGZpbmUgSU1P Lg0KPiANCj4gVG8gbWUgaXQgaXMganVzdCBzaG93aW5nIHRoYXQgb3VyIGNvbmNlcHQgb2Yg dHJhbnNhY3Rpb24gaXMgdmVyeSBicm9rZW4gaW4gQyANCj4gWGVuc3RvcmVkLiBJIGFtIGN1 cmlvdXMgdG8ga25vdyB3aGV0aGVyIE9YZW5zdG9yZWQgaXMgYmVoYXZpbmcgdGhlIHNhbWUg d2F5Lg0KDQpJIGRvbid0IGtub3cgZWl0aGVyLg0KDQo+IEFueXdheSwgSSBhZ3JlZSB0aGlz IGlzIG5vdCBiZXR0ZXIgbm9yIHdvcnNlIHRoYW4gdGhlIGN1cnJlbnQgc2l0dWF0aW9uLiBT byBJIA0KPiB3aWxsIGFja2VkIHRoaXMgcGF0Y2g6DQo+IA0KPiBBY2tlZC1ieTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCg0KVGhhbmtzLA0KDQoNCkp1ZXJnZW4NCg0K --------------HdBmljjmTIy142tzzkiK21Qy Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------HdBmljjmTIy142tzzkiK21Qy-- --------------TMLBY3hUp3T9eul5peV8Eq4Q-- --------------9XTjrhiQF0Bj5j3V9YUY1SW7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP11CoFAwAAAAAACgkQsN6d1ii/Ey8O xAf9FIhmdZ+hymGVKd96T4IqdggSbS1azOlr1EFU/zndFyfEofNpsocVve1mCRZt08OLplSiXaL8 8gxhS77iHnYTqEY7j8GMPYR9CLgW930y/OkauSuwa37dkLwW0UcjM5RhfHBbkHFU75LFl9DUguMR HMTznPmJWFkgfWvPzmG9cLS6+JcSDUJQ8hJCiw1guUTJ/VBAHYqe8VTC0MNB8cfOuQP+Y7SAAsJe HfIoOHlM5/55V8Ke5Dzb3UVeA96eyAIkCTW4uEszY8/48BCVystghcmORmAvsaUdtQF4qYT7e3gG C2We+s6orCMzuoFgja34nUXqZo51aIH0me4RNAc2Bw== =PdUq -----END PGP SIGNATURE----- --------------9XTjrhiQF0Bj5j3V9YUY1SW7-- From xen-devel-bounces@lists.xenproject.org Wed Feb 22 08:52:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 08:52:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499278.770345 (Exim 4.92) (envelope-from ) id 1pUkrB-0003BE-3U; Wed, 22 Feb 2023 08:52:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499278.770345; Wed, 22 Feb 2023 08:52:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkrB-0003B7-0f; Wed, 22 Feb 2023 08:52:09 +0000 Received: by outflank-mailman (input) for mailman id 499278; Wed, 22 Feb 2023 08:52:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkrA-0003B1-0Q for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 08:52:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e38481a-b28e-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 09:52:05 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF17A34871; Wed, 22 Feb 2023 08:52:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85177139DB; Wed, 22 Feb 2023 08:52:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id igIpH7TX9WO9SwAAMHmgww (envelope-from ); Wed, 22 Feb 2023 08:52:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e38481a-b28e-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677055924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2fZOxYFQ1u6aa7nDSO4yeuD6e3R0gL3rSI4163pEb0k=; b=lXwk6c084L0qHl0qJDO3B8taOIWW4hpAvF3Cqs5jpVeEJ7Tdb1+Q2OuAfGBc5QuUurfZ3L rdV4h1zyxAgVuKpXKzS8ZWQVJmxzFu1D1uBn5XibThhXJrBWyPUZ2yUA186eHPff9drEUC D5zEShL8bNVJ04StQMt9q4cM2SNnnts= Message-ID: <292847c2-02b8-b190-8439-75ddb9ff4cb0@suse.com> Date: Wed, 22 Feb 2023 09:52:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> <6b9b0afc-da89-6f6f-859f-c8f7ae0be972@xen.org> From: Juergen Gross Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only In-Reply-To: <6b9b0afc-da89-6f6f-859f-c8f7ae0be972@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JK0uYwVuKsyI0qG7v57kzjh9" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JK0uYwVuKsyI0qG7v57kzjh9 Content-Type: multipart/mixed; boundary="------------Lic0A12vVRH9JiiHOLbppMpq"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <292847c2-02b8-b190-8439-75ddb9ff4cb0@suse.com> Subject: Re: [PATCH v2 04/13] tools/xenstore: add framework to commit accounting data on success only References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-5-jgross@suse.com> <66e2bbb2-b244-77c7-d6bf-21d037ddaac9@suse.com> <6b9b0afc-da89-6f6f-859f-c8f7ae0be972@xen.org> In-Reply-To: <6b9b0afc-da89-6f6f-859f-c8f7ae0be972@xen.org> --------------Lic0A12vVRH9JiiHOLbppMpq Content-Type: multipart/mixed; boundary="------------iBztJC0Mqe83KYPBajkmGOjw" --------------iBztJC0Mqe83KYPBajkmGOjw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDIuMjMgMjM6NDIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIxLzAyLzIwMjMgMDg6MzcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyMC4wMi4yMyAyMzo1MCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+PiArwqDCoMKgwqDC oMKgwqAgbGlzdF9kZWwoJmNkLT5saXN0KTsNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHRhbGxv Y19mcmVlKGNkKTsNCj4+Pj4gK8KgwqDCoCB9DQo+Pj4+ICt9DQo+Pj4+ICsNCj4+Pj4gK3Zv aWQgYWNjX2NvbW1pdChzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubikNCj4+Pj4gK3sNCj4+Pj4g K8KgwqDCoCBzdHJ1Y3QgY2hhbmdlZF9kb21haW4gKmNkOw0KPj4+PiArwqDCoMKgIHN0cnVj dCBidWZmZXJlZF9kYXRhICppbiA9IGNvbm4tPmluOw0KPj4+PiArwqDCoMKgIGVudW0gYWNj aXRlbSB3aGF0Ow0KPj4+PiArDQo+Pj4+ICvCoMKgwqAgY29ubi0+aW4gPSBOVUxMOyAvKiBB dm9pZCByZWN1cnNpb24uICovDQo+Pj4NCj4+PiBJIGFtIG5vdCBzdXJlIEkgdW5kZXJzdGFu ZCB0aGlzIGNvbW1lbnQuIENhbiB5b3UgcHJvdmlkZSBtb3JlIGRldGFpbHMgd2hlcmUgDQo+ Pj4gdGhlIHJlY3Vyc2lvbiB3b3VsZCBoYXBwZW4/DQo+Pg0KPj4gZG9tYWluX2FjY19hZGQo KSBtaWdodCBkbyB0ZW1wb3JhcnkgYWNjb3VudGluZyBpZiBjb25uLT5pbiBpc24ndCBOVUxM Lg0KPiANCj4gSSBhbSBjb25mdXNlZC4gVG8gbWUgcmVjdXJzaW9uIG1lYW5zIHRoZSBmdW5j dGlvbiAob3IgdGhlIGNhbGxlcikgd2lsbCBjYWxsIA0KPiBpdHNlbGYuIEJ1dCBoZXJlIHlv dSBzZWVtIHRvIHNheSB5b3UganVzdCB3YW50IHRvIGF2b2lkIHRlbXBvcmFyeSBhY2NvdW50 aW5nLg0KDQpJdCBpcyBiYXNpY2FsbHkgZGF0YSByZWN1cnNpb24uIFRyeWluZyB0byBhcHBs eSB0ZW1wb3JhcnkgYWNjb3VudGluZyBkYXRhDQpsZWFkaW5nIHRvIHRoYXQgdGVtcG9yYXJ5 IGFjY291bnRpbmcgZGF0YSBiZWluZyBtb2RpZmllZCBhZ2FpbiBtaWdodCByZXN1bHQNCmlu IGVuZGxlc3MgbG9vcHMuDQoNCj4gV2hhdCBkaWQgSSBtaXNzPw0KPiANCj4+DQo+Pj4NCj4+ Pj4gK8KgwqDCoCB3aGlsZSAoKGNkID0gbGlzdF90b3AoJmNvbm4tPmFjY19saXN0LCBzdHJ1 Y3QgY2hhbmdlZF9kb21haW4sIGxpc3QpKSkgew0KPj4+DQo+Pj4gTklUOiBZb3UgY291bGQg dXNlIGxpc3RfZm9yX2VhY2hfc2FmZSgpOw0KPj4NCj4+IExpa2UgYWJvdmUuDQo+Pg0KPj4+ DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCBsaXN0X2RlbCgmY2QtPmxpc3QpOw0KPj4+PiArwqDC oMKgwqDCoMKgwqAgZm9yICh3aGF0ID0gMDsgd2hhdCA8IEFDQ19SRVFfTjsgd2hhdCsrKQ0K Pj4+DQo+Pj4gVGhlcmUgaXMgYSBjaGFuY2UgdGhhdCBzb21lIGNvbXBpbGVyIHdpbGwgY29t cGxhaW4gYWJvdXQgdGhpcyBsaW5lIGJlY2F1c2UgDQo+Pj4gQUNDX1JFUV9OID0gMC4gU28g dGhpcyB3b3VsZCBhbHdheXMgYmUgdHJ1ZS4gVGhlcmVmb3JlLi4uDQo+Pg0KPj4gSHVoPyBJ dCB3b3VsZCBhbHdheXMgYmUgZmFsc2UuDQo+IA0KPiBZZXMgZmFsc2Ugc29ycnkuIFRoaXMg ZG9lc24ndCBjaGFuZ2UgYWJvdXQgdGhlIHBvdGVudGlhbCAodGVtcG9yYXJ5KSB3YXJuaW5n Lg0KDQpTaG91bGRuJ3QgdGhhdCByYXRoZXIgcmVzdWx0IGluIGRlYWQgY29kZSBlbGltaW5h dGlvbiBpbnN0ZWFkPw0KDQo+IA0KPj4NCj4+Pg0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBpZiAoY2QtPmFjY1t3aGF0XSkNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBkb21haW5fYWNjX2FkZChjb25uLCBjZC0+ZG9taWQsIHdoYXQsDQo+Pj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNk LT5hY2Nbd2hhdF0sIHRydWUpOw0KPj4+PiArDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoCB0YWxs b2NfZnJlZShjZCk7DQo+Pj4+ICvCoMKgwqAgfQ0KPj4+PiArDQo+Pj4+ICvCoMKgwqAgY29u bi0+aW4gPSBpbjsNCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiDCoCBpbnQgZG9tYWluX25iZW50 cnlfaW5jKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCB1bnNpZ25lZCBpbnQgZG9taWQpDQo+ Pj4+IMKgIHsNCj4+Pj4gwqDCoMKgwqDCoCByZXR1cm4gKGRvbWFpbl9hY2NfYWRkKGNvbm4s IGRvbWlkLCBBQ0NfTk9ERVMsIDEsIGZhbHNlKSA8IDApDQo+Pj4+IGRpZmYgLS1naXQgYS90 b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmggDQo+Pj4+IGIvdG9vbHMveGVuc3Rv cmUveGVuc3RvcmVkX2RvbWFpbi5oDQo+Pj4+IGluZGV4IDgyNTljMTE0YjAuLmNkODViZDBj YWQgMTAwNjQ0DQo+Pj4+IC0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4u aA0KPj4+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmgNCj4+Pj4g QEAgLTIwLDcgKzIwLDggQEANCj4+Pj4gwqAgI2RlZmluZSBfWEVOU1RPUkVEX0RPTUFJTl9I DQo+Pj4+IMKgIGVudW0gYWNjaXRlbSB7DQo+Pj4+IC3CoMKgwqAgQUNDX05PREVTLA0KPj4+ PiArwqDCoMKgIEFDQ19SRVFfTizCoMKgwqDCoMKgwqAgLyogTnVtYmVyIG9mIGVsZW1lbnRz IHBlciByZXF1ZXN0IGFuZCBkb21haW4uICovDQo+Pj4+ICvCoMKgwqAgQUNDX05PREVTID0g QUNDX1JFUV9OLA0KPj4+DQo+Pj4gSSB3b3VsZCBicmluZyBmb3J3YXJkIHRoZSBjaGFuZ2Ug aW4gcGF0Y2ggIzUuIEkgbWVhbjoNCj4+Pg0KPj4+IEFDQ19OT0RFUywNCj4+PiBBQ0NfUkVR X04NCj4+DQo+PiBJJ20gbm90IHN1cmUgdGhpcyBpcyBhIGdvb2QgaWRlYS4gVGhpcyB3b3Vs ZCBhY3RpdmF0ZSB0aGUgdGVtcG9yYXJ5DQo+PiBhY2NvdW50aW5nIGZvciBub2RlcywgYnV0 IGtlZXBpbmcgdGhlIGVycm9yIGhhbmRsaW5nIGFjdGl2ZS4gSSdkIHJhdGhlcg0KPj4gYWN0 aXZhdGUgdGVtcG9yYXJ5IGFjY291bnRpbmcgZm9yIG5vZGVzIHRvZ2V0aGVyIHdpdGggcmVt b3ZpbmcgdGhlDQo+PiBhY2NvdW50aW5nIGNvcnJlY3Rpb24gaW4gdGhlIGVycm9yIGhhbmRs aW5nLg0KPiANCj4gSSBhbSBub3Qgc3VyZSBJIGZ1bGx5IHVuZGVyc3RhbmQgd2hhdCB5b3Ug d291bGQgcmF0aGVyIGRvLiBDYW4geW91IGNsYXJpZnk/DQoNCkhhdmluZyBBQ0NfUkVRX04g PiAwIHdpbGwgcmVzdWx0IGluIHRlbXBvcmFyeSBhY2NvdW50aW5nIGJlaW5nIGFjdGl2ZSBm b3INCkFDQ19OT0RFUyAod2hpY2ggaXMgMCksIGR1ZSB0byAid2hhdCA8IEFDQ19SRVFfTiIu DQoNCkF0IHRoZSBzYW1lIHRpbWUgdGhlcmUgYXJlIHN0aWxsIGFsbCB0aGUgcGxhY2VzIHdo ZXJlIGluIGVycm9yIGNhc2VzIHRoZQ0Kbm9kZSBhY2NvdW50aW5nIGlzIGNvcnJlY3RlZCBh Z2FpbiAodGhlIG1lbnRpb25lZCBlcnJvciBoYW5kbGluZykuIFNvIHdlDQp3b3VsZCBoYXZl IGJvdGggZXJyb3IgaGFuZGxpbmcgbWVjaGFuaXNtcyAoZXhwbGljaXQgYW5kIHRlbXAgYWNj b3VudGluZykNCmFjdGl2ZSBhdCB0aGUgc2FtZSB0aW1lIGZvciBub2Rlcy4NCg0KPiANCj4+ DQo+Pj4NCj4+Pj4gwqDCoMKgwqDCoCBBQ0NfVFJfTizCoMKgwqDCoMKgwqDCoCAvKiBOdW1i ZXIgb2YgZWxlbWVudHMgcGVyIHRyYW5zYWN0aW9uIGFuZCBkb21haW4uICovDQo+Pj4+IMKg wqDCoMKgwqAgQUNDX04gPSBBQ0NfVFJfTiAvKiBOdW1iZXIgb2YgZWxlbWVudHMgcGVyIGRv bWFpbi4gKi8NCj4+Pj4gwqAgfTsNCj4+Pg0KPj4+IFRoaXMgZW51bSBpcyBnZXR0aW5nIGV4 dHJlbWVseSBjb25mdXNpbmcuIFRoZXJlIGFyZSBtYW55ICJudW1iZXIgb2YgZWxlbWVudHMg DQo+Pj4gcGVyIC4uLiBkb21haW4iLiBDYW4geW91IGNsYXJpZnk/DQo+Pg0KPj4gSSB3aWxs IGFkZCBzb21lIG1vcmUgY29tbWVudHMgdG8gdGhlIGhlYWRlci4gV291bGQgeW91IGxpa2Ug aXQgYmV0dGVyIHRvIGhhdmUNCj4+IHRoZSBsaW1pdHMgaW5kZW50ZWQgbW9yZT8gc29tZXRo aW5nIGxpa2U6DQo+IA0KPiBJIGFtIGFmcmFpZCBpdCBkb2Vzbid0IGhlbHAgdW5kZXJzdGFu ZGluZyB0aGUgY29tbWVudC4gRm9yIGluc3RhbmNlLA0KPiANCj4+DQo+PiBlbnVtIGFjY2l0 ZW0gew0KPj4gwqDCoMKgwqDCoMKgwqDCoCBBQ0NfTk9ERVMsDQo+PiDCoMKgwqDCoMKgwqDC oMKgIC8qIE51bWJlciBvZiBlbGVtZW50cyBwZXIgcmVxdWVzdCBhbmQgZG9tYWluLiAqLw0K PiANCj4geW91IHdyb3RlICJwZXIgcmVxdWVzdCBhbmQgZG9tYWluIiBoZXJlLiBCdXQuLi4N Cj4gDQo+PiDCoMKgwqDCoMKgwqDCoMKgIEFDQ19SRVFfTiwNCj4+IMKgwqDCoMKgwqDCoMKg wqAgLyogTnVtYmVyIG9mIGVsZW1lbnRzIHBlciB0cmFuc2FjdGlvbiBhbmQgZG9tYWluLiAq Lw0KPiANCj4gLi4uIGhlcmUgdGhpcyBpcyAicGVyIHRyYW5zYWN0aW9uIGFuZCBkb21haW4i LiBTaG91bGQgbm90IG5iZSAiZWxlbWVudHMgcGVyIA0KPiB0cmFuc2FjdGlvbiI/IEFuZCBp ZiBub3QsIHRoZW4gd2h5IGRvbid0IHdlIGhhZCAicGVyIHJlcXVlc3QsIHRyYW5zYWN0aW9u IGFuZCANCj4gZG9tYWluIiBhYm92ZT8NCg0KVGhpcyBpcyBkdWUgdG8gdGhlIG5lc3Rpbmc6 IHRoZSBvdXRlcm1vc3QgbmVzdGluZyBsZXZlbCBpcyAiYWxsIGFjY291bnRpbmcNCml0ZW1z Iiwgd2hpY2ggY292ZXJzIGV2ZXJ5dGhpbmcsIGFuZCBpcyB0cmFja2VkIG9uIGEgcGVyIGRv bWFpbiBiYXNpcy4NCg0KVGhlIG5leHQgbGV2ZWwgaXMgInBlciB0cmFuc2FjdGlvbiIgKEkg Y2FuIGRyb3AgdGhlICJhbmQgcGVyIGRvbWFpbiIsIGFzDQpldmVyeXRoaW5nIGlzIHBlciBk b21haW4pLg0KDQpUaGUgaW5uZXJtb3N0IGxldmVsIGlzICJwZXIgcmVxdWVzdCIuIEEgcmVx dWVzdCBjYW4gYmUgZWl0aGVyIHBhcnQgb2YgYQ0KdHJhbnNhY3Rpb24sIG9yIG5vdC4gVGhp cyBkb2Vzbid0IG1hdHRlci4NCg0KDQpKdWVyZ2VuDQo= --------------iBztJC0Mqe83KYPBajkmGOjw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------iBztJC0Mqe83KYPBajkmGOjw-- --------------Lic0A12vVRH9JiiHOLbppMpq-- --------------JK0uYwVuKsyI0qG7v57kzjh9 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP117QFAwAAAAAACgkQsN6d1ii/Ey/C dwf+K9LbYuW5F+0WLs9RLTCpoJq08q6uN0+TKPHW/F0amLPEgvAWZ3hboB9uUZuxRI7MceYzNZnw vumVWDSt2K2/kJirv8bpYTTXLfM1dkejtkhDpP/2Ll6qrHo+BbrJy1kuQrP65krNgHOy3dOj539F gkhYwGw3S6MPYJm9v54i+IeaRF7WdgBuZ3fxeCcZXHQm+D0iySqKromw4qSvm0Mdsz2ablaGL5Au GKE//1LhxbJb0gsIkS7kannLg6hiq29ASHDtZ+VPB29tEy4dXPevs9q3nUyZ37qb3U/wGRkdG1Nz r8XluoDgBg0sN8O+IrWqCHz8NPCR7tGn4IPUjKP/Qw== =XEE8 -----END PGP SIGNATURE----- --------------JK0uYwVuKsyI0qG7v57kzjh9-- From xen-devel-bounces@lists.xenproject.org Wed Feb 22 08:52:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 08:52:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499279.770356 (Exim 4.92) (envelope-from ) id 1pUkrR-0003VR-Ak; Wed, 22 Feb 2023 08:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499279.770356; Wed, 22 Feb 2023 08:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkrR-0003VH-85; Wed, 22 Feb 2023 08:52:25 +0000 Received: by outflank-mailman (input) for mailman id 499279; Wed, 22 Feb 2023 08:52:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkrQ-0003Th-3o for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 08:52:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUkrP-0004jk-8E; Wed, 22 Feb 2023 08:52:23 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.17.136]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pUkrP-0001qR-2i; Wed, 22 Feb 2023 08:52:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xJ5HQcprTiac3L/UXci5ULvA395COXHkhHUBx1COmsI=; b=L9xkSgmzkWFZjUGXtcG1wSVS/K SoBM6VUjhmRhQi3LdfvEh3toZvoH2QHHBkef+AkVSrKGoy/Sj9q/uM5iANxZpdZfWRGTHReyYLJVB qyyy6lqIl/A18IXxkOa/wFVhhTjSbihaU+bsL21nMvJwjDmI5bQwY+0WIZLbLNzXLULY=; Message-ID: Date: Wed, 22 Feb 2023 08:52:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> From: Julien Grall In-Reply-To: <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 22/02/2023 08:36, Juergen Gross wrote: > On 21.02.23 23:36, Julien Grall wrote: >> Hi Juergen, >> >> On 21/02/2023 08:10, Juergen Gross wrote: >>> On 20.02.23 19:01, Julien Grall wrote: >>>> So I have recreated an XTF test which I think match what you wrote [1]. >>>> >>>> It is indeed failing without your patch. But then there are still >>>> some weird behavior here. >>>> >>>> I would expect the creation of the node would also fail if instead >>>> of removing the node if removed outside of the transaction. >>>> >>>> This is not the case because we are looking at the current quota. So >>>> shouldn't we snapshot the global count? >>> >>> As we don't do a global snapshot of the data base for a transaction >>> (this was >>> changed due to huge memory needs, bad performance, and a higher >>> transaction >>> failure rate), >> >> I am a bit surprised that the only way to do proper transaction is to >> have a global snapshot. Instead, you could have an overlay. > > I didn't say that a global snapshot is the only way. And we are using an > overlay. > >> >>> I don't think we should snapshot the count either. >> >> But that would mean that the quota will change depending on >> modification of the global database while the transaction is inflight. > > I really don't see the problem with that. But it seems our views are > different > in this case. See below. > >> I guess this is not better nor worse that the current situation. But >> it is still really confusing for a client because: >>    1) The error could happen at random point > > Yes, like without a transaction. > >>    2) You may see an inconsistent database as nodes are only cached >> when they are first accessed > > It isn't inconsistent at all. The same could happen if such other nodes are > added/modified/removed just a microsecond before you start the transaction. > You won't be able to tell the difference. You can only reason about nodes > being accessed in the transaction, and those are transaction-local. I am not talking about the case a node is added/modified/removed outside of a transaction. I am talking about the in-transaction case. For example, let say we have a transaction A that remove node 1, 2 and transaction B to access 1, 2 (it may do more). Now let's imagine the following sequence with the initial state is node 1 and 2 exists: - TA started - TA remove 1 - TA remove 2 - TA remove 3 - TB started - TB read 1 - TA ended - TB read 2 With the above, one would expect that transaction B can read 2 as transaction A didn't commit before B started. But this is not what's happening. My point here is that a protocol could require that if 1 is present then 2 is. So it would be valid for a client to error out because the other side was considered to have misbehaved. However, here this is just how Xenstored behave and AFAICT it is undocumented. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Feb 22 09:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 09:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499291.770366 (Exim 4.92) (envelope-from ) id 1pUlGx-0006fT-ES; Wed, 22 Feb 2023 09:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499291.770366; Wed, 22 Feb 2023 09:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlGx-0006fM-BZ; Wed, 22 Feb 2023 09:18:47 +0000 Received: by outflank-mailman (input) for mailman id 499291; Wed, 22 Feb 2023 09:18:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlGv-0006fC-K9; Wed, 22 Feb 2023 09:18:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlGv-0005Pu-Gp; Wed, 22 Feb 2023 09:18:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlGv-00030E-8G; Wed, 22 Feb 2023 09:18:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUlGv-0006sH-7o; Wed, 22 Feb 2023 09:18:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=92+3lR2XbA3vo1DQwQW3e8bDnMTxKOrKEisB8fxTuns=; b=tfXWTM45bgbaBgfHvoZXy3tWlb wopkpuy2YQjqDBTSKsQWHjLowHX5X8T5vN1I8023qjDl6xHv1f/1h/GL0tGNElFOsB6S2/ZUW+jso AfFvt/oj2ED1TsGzI+lS1nuJXqPCTgTuXKOrBBzT/w3/ywbqEmlHaGDSScY3czXxOQSU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178093: regressions - trouble: blocked/broken/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-coresched-amd64-xl::broken:regression linux-linus:test-amd64-coresched-amd64-xl:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Wed, 22 Feb 2023 09:18:45 +0000 flight 178093 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178093/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-coresched-amd64-xl 5 host-install(5) broken REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 build-armhf-pvops 6 kernel-build fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 build-arm64-pvops 6 kernel-build fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 0 days Testing same since 178093 2023-02-22 05:02:47 Z 0 days 1 attempts ------------------------------------------------------------ 685 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl broken test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-coresched-amd64-xl broken broken-step test-amd64-coresched-amd64-xl host-install(5) Not pushing. (No revision log; it would be 69393 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 22 09:33:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 09:33:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499301.770377 (Exim 4.92) (envelope-from ) id 1pUlVC-00014V-QX; Wed, 22 Feb 2023 09:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499301.770377; Wed, 22 Feb 2023 09:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlVC-00014O-Na; Wed, 22 Feb 2023 09:33:30 +0000 Received: by outflank-mailman (input) for mailman id 499301; Wed, 22 Feb 2023 09:33:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlVA-00014I-Lq for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 09:33:28 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20621.outbound.protection.outlook.com [2a01:111:f400:fe1a::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4f708b8-b293-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 10:33:26 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8316.eurprd04.prod.outlook.com (2603:10a6:10:246::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.18; Wed, 22 Feb 2023 09:33:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 09:33:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4f708b8-b293-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGeRGAKNDePP0MOKYv4g6/oNP0WzMpZ+EAy9DcH1GqHj9xoQVWgeKmg5yXjXbuwImIk1QSRYCFP8qjMgGgF1x68oVwQi6oDyqXBZYkGR6ZuxbTr9Q2SKL5mX1X1kiP08P1M0/B3TFvw5dZXBbgwoCn0PsIrucBfudd2xZd8cGsSpcXCPoqwFkzgEt0bEYnsdHXAMkQESgACYY58rCQBwH02mF0nAhvOS1/A+d/vkxKod989LWCMoJwkcnbNTz6IXIPSXgT04QZMOpN/UFIHDgAlPgbi/2Qxf1KPDNS8KynjURnn/x9rdCDP99oNZeiGWf5t+DjJVqBJS0tabI2qbGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/T6Dg7QHblN9sHPTSrT66ZFu1n2VLTRFa9wx5/oY7w=; b=OPSefJA/BKjhTa+nhsuKkLdHD8J3IkTRpwzoTMNh0nVbMEuWJ/pwHXawUmr44WxGUH+RsLlq3EouIiXKpZq2vKGA+Eh6kQtGzLJFeo1faobO8dYXcCE/+OPfNapmJ/TWMZhWrLejN/xP3puWiF5VMoovxFZqEN2rLp6WYQ8omrsN1DCM+cCYZygMSsNwMIjIMVOO14p8MKqyxi1iswp9krTz04lSzBBLudpIKHjQBFbxw1zxJH7sxNs8Erfq4CFjPRFXU3nSBx0X1IAoV96RgwFGY2cX/9BDTTL/QKvkTGQ/wKskSiT5TUZ0Aw57v7OBkpS8Y0lMA39hFqzKvxbrhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/T6Dg7QHblN9sHPTSrT66ZFu1n2VLTRFa9wx5/oY7w=; b=F/Bzwj5hsUr0qjMHGptPRhvfQdXA2pwN5axE3aXFThRIje3XPMczi9LNIHCFje1oV/doAKZt4Pa33wIxQ7UnEWTCMkDFkoDv72os604K1PYmowJjsy3VrK1JVvNFw7hL8WSkl7FsAag0gNmh81jh906mMIDJYVEfRZO5XZJARBhpLjLm41UVH9FKy/lX7yL5oQUJRzbqW4TXqAqaSeVrbwtop09/PZEPj7pwLP9yruK2GTlAJhbjEzE3y+CffzpQI2opKqRi9h4Us0GH+82bHRfB17poeq//NzChwSncWPLKK3zVcL9ufVl9l8X2iepYDPgbsk4EHHOj34ReGervHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <71b9a6c4-950b-201e-7d39-eee602f2c26c@suse.com> Date: Wed, 22 Feb 2023 10:33:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] xen/ioapic: Don't use local_irq_restore() to disable irqs Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230220194702.2260181-1-andrew.cooper3@citrix.com> <20230220194702.2260181-2-andrew.cooper3@citrix.com> <95737b30-f377-7c2a-316f-8dc6ed7a863a@citrix.com> From: Jan Beulich In-Reply-To: <95737b30-f377-7c2a-316f-8dc6ed7a863a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8316:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b8213f3-f68d-487d-d02f-08db14b7d82d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rECo/Mfh85s/uWpxX/BPjVqngPJ4zHgkLcG2I4HwwA+gorKY84i0RpIN6IeM/3i7HB9AoEXEg5bsVC+ZVwA8Md6PSNv8Ksv44EMswdx5wN5SdSeLccddHYhidkBAOGFxObSkjSSXnq8AaNs7rOJSEt6dLcFtuSIg4UJE8ey5Vt7sY141idJw2rzMlXo5v/Ze9dxh/JTyHznFbn0Zt+6udvlrdPLmIB8Ix9+x8IVXw/ASEBHPoeGenjB3MzbMSPtYkArsjuwN3OevqqdEP/xaWOOkdq46WgdSboQSvCwRivuoi+5zYoj5XCCsy2QJJk9bQRbAt8SNTsii5W6vWJDJ9rIAHGnA1bnfakl49l/KbgOFqSuTxGO6Sa1IFAQcEZd90fCHI/kwzuORLwfyINWVpj695URU5GhP9pUpTbO22nANdUQvnZt1jvdEi/KxJ/cPABKlw1XELQCoamfa8FbfY+wAaE/q6gpvhorOqZRg1YOqZkaSsrgJAmlP8jf00LsjIP0RjNcXNX5ffGwAe7LltLHkOdyv/yQptnpp8rXJDWeRb8tBVyILzgMaKnHjnPO3656Te6CHLrpJgZpDdjNZxM/Py/UH6wWqBotLgqRsnRUD5p8J8m5NqtQwOlqIiivqWwhdunAgeGh6qKzR2X9MkQBT2S/bfeQR9kLuW6oxDnwNsO1vIx+rpIn9wpdeYJfPR3fKSDN1hJ4ymiWvVUwoL5QPsQ9kj93CBUA3FFQOILk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199018)(36756003)(478600001)(31696002)(86362001)(2906002)(38100700002)(316002)(54906003)(41300700001)(5660300002)(8936002)(83380400001)(66476007)(66946007)(4326008)(8676002)(66556008)(6916009)(31686004)(6486002)(186003)(26005)(6512007)(53546011)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzkvVEJ1MVJMM2VUZVExa2dydjVOaVMxcjFKSFIvTzJUdDZndHJUTlZFNCt5?= =?utf-8?B?VGVkR0FVU3E2TFJ1aXZhU0JZMnZZN1NKVWVhc1YwSEptZXRqaFZRRE1vTUtM?= =?utf-8?B?eTVjV1U5UEVxYk92TmtxNlh1YThKZlcvWm9zZzg0OTg2NEdpUDdhYkNINWdX?= =?utf-8?B?QVRpYU1PT0cxa2M3TWE4UFBlNUhya2d1Y2FLY0NvWnljZjNHM1N6Zmx0ZWFF?= =?utf-8?B?aGNLdFd1OW1hQUl6ckE5R0RGTHBRc3N3cGpnM3JNQjhYL05YVmRsOGNMa0Ex?= =?utf-8?B?Q2tKQWJQZVd3T0txSXByaGFnUGpIaWk2a3VRTDdLVC9QdEc3dHZjZzYvdk1j?= =?utf-8?B?a05JM1ZkOFZEQ3l1Z0lvZjNOa09ST3RsMGtpdFNKeWRET2p6RFpMTXI1MGYv?= =?utf-8?B?TXZVOS81d3dXRnl1QVZ6WGl2WXM0ZlRSenQrc1pyWklKMGtBS01BT245Y3pF?= =?utf-8?B?aU9YN2hRamdHZE1QZ1M2Z0dKRTRja0oweUR4anZkWHpVOExSNzQ0RE83UUk2?= =?utf-8?B?d2F1UzJGVUtDK2traUxXNk5DdU5zNC9CMkNTb1FUMVBTZHdlT2hUWVVLRVQ3?= =?utf-8?B?cXF2TU4rOTlMNlhMQ0RZUzZTbGN4SkVmOWE4ekpSbEE1b0RKekpRYi90RWZ2?= =?utf-8?B?WHYwNWZLcTlxbkdveUJhQ1BnelZTd2hCMXVKcFZnWFp0ZFB2U2V0UE1NM2pv?= =?utf-8?B?Z0V5NXZkNUJidFgxTzZRWTc3WUlrNDdtSFR3cWoyd0c3bU1jV1NuVm14bGRo?= =?utf-8?B?M2FOZDNTQ2lKL2g4TFhTdVdqWUx5M2kxdkJ5WlBCcUNENEFaSVRuTXJzdFpE?= =?utf-8?B?Ly9tb3k5Tlhrb1gzSGRNVktFTktpVjF3YkoyTTkvdG9kV1RQcUprMnZOTHcz?= =?utf-8?B?UkNwK3pzbG9aU005Q29tSGdWK1hRM0Q1c3I4RGZYOE41RmorbFlIT1lPNXA3?= =?utf-8?B?U0F4ZDBQYUdBdzhGbmJGVzZTWFA0SGt6U3Q3REhXVy9sMDdoNnlabkZadTA1?= =?utf-8?B?b25zbk5TQmVGTHZjMUNwN2xrQXJuVkQ2a2lCdGxCMDBvY0pOWll1YXp1OE5j?= =?utf-8?B?NHZGTEdvUWI3MEJVVHdUNWV3azYwbFZaTFppb2x3VkFqOWVkMWp0d0hMTGRS?= =?utf-8?B?TElSNHJ1RzBtQThRSDJrMEhjSG9ya0Nxa3d5cURNNGJVekJyNy9JdkdGenFF?= =?utf-8?B?UzUraklHNFN1NWhMWGZyTm5TVUNUVUJOOXd4MHFRemZEUGZlTHhEVVd1NU1P?= =?utf-8?B?ME03LzFId2lpOU1qY25CRWF1Yk9mSEdLcWRKV2o5Nit4WVFjRytpTy9NN0ZW?= =?utf-8?B?aHNNZjFlY1JNMEZNR3RoYWhQUWRZanR0WWFEcmtlOE5tUlh4blRkYXIyeHhV?= =?utf-8?B?K2hRaFRTUm1ZZ1U3K3NtMnhod1NLNUV2UEpGWGg2endTMU10UTdRNXhlUDNt?= =?utf-8?B?cXZvOUwxaHFKRDdTNkcySG4zSW5sYWdJYmNxRSt3VnZtNHcvR0xzWlIrc3pS?= =?utf-8?B?YmJlVFAvVDQwbmlZU2NqOW9aMVI2L2piZHFQclNtNFFad2JXNU80VTBHOU40?= =?utf-8?B?b0tCVXVNd1lQTU1QMWtPMWlSbVBjcWw0SmF6d0xkSHdOaEx6NVNQK2V4aG5X?= =?utf-8?B?OGkyZUU1T1ZRWUVjNlVrdWpFVSt2ajQ4aGhnVVBqSW1qNnI1dFYvaDlocW9T?= =?utf-8?B?QUdQYVZnTXZXbENLZURoNHdVV3BRN0g5L3h6M2tWL0k1VFhjNHY2MVh1SmMw?= =?utf-8?B?anBvdmJwZkdWR29kU2xWY2lKL0tOV1hmQnVPbXUzL2h4RVRwU3BMOURzZG5D?= =?utf-8?B?bWFpZDUvenY1aWNFVEZQWk9zRzZPTHh3SjZlZ0dsNmw3K21nUVpZNmIveDZl?= =?utf-8?B?SGU1UytLaytVZWE4VldPaEJxVXdKdVFlcTJ4OFNjdFNwZ05Fb0dvei9HTVZv?= =?utf-8?B?Q090bmlMc3dKeWhaNGVHSUJQeW16Vy9uK2FFWDZUYWRjL0MxZXlkMy8ycDRk?= =?utf-8?B?T25OVWt6T0dkOVQ2S2ZHdTdsKzRmR1dxN1U0b2kycnNmZ2h5dVBMRzVwU0h4?= =?utf-8?B?ZUZ2OUh0UituT3daT3VYUUIwOHZhd2dnMnVTRnNZaUcrdWxXZmJ0M0pJSENC?= =?utf-8?Q?fotdcrqRPS5+sh7q+N+QVM14w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8213f3-f68d-487d-d02f-08db14b7d82d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 09:33:24.3227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YjMCv17RwiTg59um+mMo73bpRaiO92MARHa0otIF7thGk27NpTwbQlHNQO2Sct/owvPTig8/7HQmrlx8JYHmMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8316 On 21.02.2023 19:14, Andrew Cooper wrote: > On 21/02/2023 1:40 pm, Jan Beulich wrote: >> On 20.02.2023 20:47, Andrew Cooper wrote: >>> Despite its name, the irq{save,restore}() APIs are only intended to >>> conditionally disable and re-enable interrupts. >> Are they? > > Yes, absolutely. > > And as said before, the potentially dubious naming does not give us > permission or the right to interpret the behaviour differently. When I started to work with Linux, I seem to recall there were more uses of this nature, not considered dubious at the time. Views change, and if such views aren't expressed in the function names, then it is even more so important that this is spelled out in some other prominent way. So ... >> Maybe nowadays they indeed are, but I couldn't spot any wording >> to this effect in Linux'es Documentation/ (and I don't think we have >> anywhere such could be put). Yet I'd expect such a statement to be backed >> by something. > > It is backed by the rude words the owners of this API had to say on > discovering this particular use. ... have those rude words found their way into documentation, in a place I simply didn't spot? > Conditionally enabling with a construct like this is bogus everywhere.  > It is only ever safe to enable irqs if you know exactly why they were > disabled previously, and that can never be the case with a construct > like this. > > It only reason this one example doesn't explode is because its an init > path not nested within an irq/irqsave lock or other critical region. Which is why, I assume, it was deemed fine to code that way back then. >>> IO-APIC's timer_irq_works() violates this intention. As it is init code, >>> switch to simple irq enable/disable(). >> If all callers of the function obviously did have interrupts off, I might >> agree. But the last of them sits _after_ local_irq_restore(), and all of >> this is called from underneath smp_prepare_cpus() > > Which do you mean "the last of them" ? Is "last" ambiguous here in any way? If so, this code fragment is the one: unlock_ExtINT_logic(); local_irq_restore(flags); if (timer_irq_works()) { printk(" works.\n"); return; } printk(" failed :(.\n"); panic("IO-APIC + timer doesn't work! Boot with apic_verbosity=debug and send a report\n"); } Besides aspects one may deem benign and/or pre-existing, your change leads to the "works" path now running (returning) with IRQs off, when the caller expects them on. > There is a large amount of genuinely dead logic here. Possibly. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 09:37:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 09:37:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499307.770388 (Exim 4.92) (envelope-from ) id 1pUlZJ-0001fs-Ao; Wed, 22 Feb 2023 09:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499307.770388; Wed, 22 Feb 2023 09:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlZJ-0001fl-7g; Wed, 22 Feb 2023 09:37:45 +0000 Received: by outflank-mailman (input) for mailman id 499307; Wed, 22 Feb 2023 09:37:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUlZH-0001ff-Qv for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 09:37:44 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c499b91-b294-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 10:37:39 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 839C45C341; Wed, 22 Feb 2023 09:37:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A373139DB; Wed, 22 Feb 2023 09:37:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xX/GFGPi9WPBZAAAMHmgww (envelope-from ); Wed, 22 Feb 2023 09:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c499b91-b294-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677058659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Iji8OsdvXBhM/POPsPgFug1wYdIPUler1Sxos8F54g=; b=VSD+OIL8BXUoaRJvG+Tba/xlaswW2gJMECurw6bHg3QO8j1h4sLjZGd87pfxkR9ei+4F/G hBaqJY84Fua2hGg0CtsuWGQZygYgUw8lPtsup+oa3P0MOG0pNv0lEg94f53sEvUChHAjU1 MLBswK5DXMGvN7jWvBPirUDDjRJKTyg= Message-ID: Date: Wed, 22 Feb 2023 10:37:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OzNMiYGf4oUyP9My4G6kRV9J" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OzNMiYGf4oUyP9My4G6kRV9J Content-Type: multipart/mixed; boundary="------------N07yogLjHR4aWprqHXhRtYl1"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Message-ID: Subject: Re: [PATCH v2 01/13] tools/xenstore: don't allow creating too many nodes in a transaction References: <20230120100028.11142-1-jgross@suse.com> <20230120100028.11142-2-jgross@suse.com> <2131198f-f54b-2c38-8104-1c8b63e9990c@xen.org> <32a517cf-4448-2208-4877-83c7a7531635@suse.com> <20151614-96ca-0875-29a0-8099953b7e61@xen.org> <5fc2636e-45b0-e515-d901-18dc5fc214eb@xen.org> <28c5c478-b1b6-c8e1-ce9c-287e8afc604a@suse.com> In-Reply-To: --------------N07yogLjHR4aWprqHXhRtYl1 Content-Type: multipart/mixed; boundary="------------av6WNI7RO55KITFxB6HOvG7b" --------------av6WNI7RO55KITFxB6HOvG7b Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMDIuMjMgMDk6NTIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDIyLzAyLzIwMjMgMDg6MzYsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyMS4wMi4yMyAyMzozNiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBPbiAyMS8wMi8yMDIzIDA4OjEwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4+PiBPbiAyMC4wMi4yMyAxOTowMSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+Pj4gU28g SSBoYXZlIHJlY3JlYXRlZCBhbiBYVEYgdGVzdCB3aGljaCBJIHRoaW5rIG1hdGNoIHdoYXQg eW91IHdyb3RlIFsxXS4NCj4+Pj4+DQo+Pj4+PiBJdCBpcyBpbmRlZWQgZmFpbGluZyB3aXRo b3V0IHlvdXIgcGF0Y2guIEJ1dCB0aGVuIHRoZXJlIGFyZSBzdGlsbCBzb21lIA0KPj4+Pj4g d2VpcmQgYmVoYXZpb3IgaGVyZS4NCj4+Pj4+DQo+Pj4+PiBJIHdvdWxkIGV4cGVjdCB0aGUg Y3JlYXRpb24gb2YgdGhlIG5vZGUgd291bGQgYWxzbyBmYWlsIGlmIGluc3RlYWQgb2YgDQo+ Pj4+PiByZW1vdmluZyB0aGUgbm9kZSBpZiByZW1vdmVkIG91dHNpZGUgb2YgdGhlIHRyYW5z YWN0aW9uLg0KPj4+Pj4NCj4+Pj4+IFRoaXMgaXMgbm90IHRoZSBjYXNlIGJlY2F1c2Ugd2Ug YXJlIGxvb2tpbmcgYXQgdGhlIGN1cnJlbnQgcXVvdGEuIFNvIA0KPj4+Pj4gc2hvdWxkbid0 IHdlIHNuYXBzaG90IHRoZSBnbG9iYWwgY291bnQ/DQo+Pj4+DQo+Pj4+IEFzIHdlIGRvbid0 IGRvIGEgZ2xvYmFsIHNuYXBzaG90IG9mIHRoZSBkYXRhIGJhc2UgZm9yIGEgdHJhbnNhY3Rp b24gKHRoaXMgd2FzDQo+Pj4+IGNoYW5nZWQgZHVlIHRvIGh1Z2UgbWVtb3J5IG5lZWRzLCBi YWQgcGVyZm9ybWFuY2UsIGFuZCBhIGhpZ2hlciB0cmFuc2FjdGlvbg0KPj4+PiBmYWlsdXJl IHJhdGUpLCANCj4+Pg0KPj4+IEkgYW0gYSBiaXQgc3VycHJpc2VkIHRoYXQgdGhlIG9ubHkg d2F5IHRvIGRvIHByb3BlciB0cmFuc2FjdGlvbiBpcyB0byBoYXZlIGEgDQo+Pj4gZ2xvYmFs IHNuYXBzaG90LiBJbnN0ZWFkLCB5b3UgY291bGQgaGF2ZSBhbiBvdmVybGF5Lg0KPj4NCj4+ IEkgZGlkbid0IHNheSB0aGF0IGEgZ2xvYmFsIHNuYXBzaG90IGlzIHRoZSBvbmx5IHdheS4g QW5kIHdlIGFyZSB1c2luZyBhbg0KPj4gb3ZlcmxheS4NCj4+DQo+Pj4NCj4+Pj4gSSBkb24n dCB0aGluayB3ZSBzaG91bGQgc25hcHNob3QgdGhlIGNvdW50IGVpdGhlci4NCj4+Pg0KPj4+ IEJ1dCB0aGF0IHdvdWxkIG1lYW4gdGhhdCB0aGUgcXVvdGEgd2lsbCBjaGFuZ2UgZGVwZW5k aW5nIG9uIG1vZGlmaWNhdGlvbiBvZiANCj4+PiB0aGUgZ2xvYmFsIGRhdGFiYXNlIHdoaWxl IHRoZSB0cmFuc2FjdGlvbiBpcyBpbmZsaWdodC4NCj4+DQo+PiBJIHJlYWxseSBkb24ndCBz ZWUgdGhlIHByb2JsZW0gd2l0aCB0aGF0LiBCdXQgaXQgc2VlbXMgb3VyIHZpZXdzIGFyZSBk aWZmZXJlbnQNCj4+IGluIHRoaXMgY2FzZS4NCj4gDQo+IFNlZSBiZWxvdy4NCj4gDQo+Pg0K Pj4+IEkgZ3Vlc3MgdGhpcyBpcyBub3QgYmV0dGVyIG5vciB3b3JzZSB0aGF0IHRoZSBjdXJy ZW50IHNpdHVhdGlvbi4gQnV0IGl0IGlzIA0KPj4+IHN0aWxsIHJlYWxseSBjb25mdXNpbmcg Zm9yIGEgY2xpZW50IGJlY2F1c2U6DQo+Pj4gwqDCoCAxKSBUaGUgZXJyb3IgY291bGQgaGFw cGVuIGF0IHJhbmRvbSBwb2ludA0KPj4NCj4+IFllcywgbGlrZSB3aXRob3V0IGEgdHJhbnNh Y3Rpb24uDQo+Pg0KPj4+IMKgwqAgMikgWW91IG1heSBzZWUgYW4gaW5jb25zaXN0ZW50IGRh dGFiYXNlIGFzIG5vZGVzIGFyZSBvbmx5IGNhY2hlZCB3aGVuIHRoZXkgDQo+Pj4gYXJlIGZp cnN0IGFjY2Vzc2VkDQo+Pg0KPj4gSXQgaXNuJ3QgaW5jb25zaXN0ZW50IGF0IGFsbC4gVGhl IHNhbWUgY291bGQgaGFwcGVuIGlmIHN1Y2ggb3RoZXIgbm9kZXMgYXJlDQo+PiBhZGRlZC9t b2RpZmllZC9yZW1vdmVkIGp1c3QgYSBtaWNyb3NlY29uZCBiZWZvcmUgeW91IHN0YXJ0IHRo ZSB0cmFuc2FjdGlvbi4NCj4+IFlvdSB3b24ndCBiZSBhYmxlIHRvIHRlbGwgdGhlIGRpZmZl cmVuY2UuIFlvdSBjYW4gb25seSByZWFzb24gYWJvdXQgbm9kZXMNCj4+IGJlaW5nIGFjY2Vz c2VkIGluIHRoZSB0cmFuc2FjdGlvbiwgYW5kIHRob3NlIGFyZSB0cmFuc2FjdGlvbi1sb2Nh bC4NCj4gDQo+IEkgYW0gbm90IHRhbGtpbmcgYWJvdXQgdGhlIGNhc2UgYSBub2RlIGlzIGFk ZGVkL21vZGlmaWVkL3JlbW92ZWQgb3V0c2lkZSBvZiBhIA0KPiB0cmFuc2FjdGlvbi4gSSBh bSB0YWxraW5nIGFib3V0IHRoZSBpbi10cmFuc2FjdGlvbiBjYXNlLiBGb3IgZXhhbXBsZSwg bGV0IHNheSB3ZSANCj4gaGF2ZSBhIHRyYW5zYWN0aW9uIEEgdGhhdCByZW1vdmUgbm9kZSAx LCAyIGFuZCB0cmFuc2FjdGlvbiBCIHRvIGFjY2VzcyAxLCAyIChpdCANCj4gbWF5IGRvIG1v cmUpLg0KPiANCj4gTm93IGxldCdzIGltYWdpbmUgdGhlIGZvbGxvd2luZyBzZXF1ZW5jZSB3 aXRoIHRoZSBpbml0aWFsIHN0YXRlIGlzIG5vZGUgMSBhbmQgMiANCj4gZXhpc3RzOg0KPiAN Cj4gIMKgLSBUQSBzdGFydGVkDQo+ICDCoC0gVEEgcmVtb3ZlIDENCj4gIMKgLSBUQSByZW1v dmUgMg0KPiAgwqAtIFRBIHJlbW92ZSAzDQo+ICDCoC0gVEIgc3RhcnRlZA0KPiAgwqAtIFRC IHJlYWQgMQ0KPiAgwqAtIFRBIGVuZGVkDQo+ICDCoC0gVEIgcmVhZCAyDQo+IA0KPiBXaXRo IHRoZSBhYm92ZSwgb25lIHdvdWxkIGV4cGVjdCB0aGF0IHRyYW5zYWN0aW9uIEIgY2FuIHJl YWQgMiBhcyB0cmFuc2FjdGlvbiBBIA0KPiBkaWRuJ3QgY29tbWl0IGJlZm9yZSBCIHN0YXJ0 ZWQuIEJ1dCB0aGlzIGlzIG5vdCB3aGF0J3MgaGFwcGVuaW5nLg0KPiANCj4gTXkgcG9pbnQg aGVyZSBpcyB0aGF0IGEgcHJvdG9jb2wgY291bGQgcmVxdWlyZSB0aGF0IGlmIDEgaXMgcHJl c2VudCB0aGVuIDIgaXMuIA0KPiBTbyBpdCB3b3VsZCBiZSB2YWxpZCBmb3IgYSBjbGllbnQg dG8gZXJyb3Igb3V0IGJlY2F1c2UgdGhlIG90aGVyIHNpZGUgd2FzIA0KPiBjb25zaWRlcmVk IHRvIGhhdmUgbWlzYmVoYXZlZC4gSG93ZXZlciwgaGVyZSB0aGlzIGlzIGp1c3QgaG93IFhl bnN0b3JlZCBiZWhhdmUgDQo+IGFuZCBBRkFJQ1QgaXQgaXMgdW5kb2N1bWVudGVkLg0KDQpB aCwgb2theS4NCg0KWWVzLCBJIGNhbiBzZWUgeW91ciBwb2ludC4NCg0KSSB3YXMgdGhpbmtp bmcgZm9yIHNvbWUgdGltZSBub3cgdG8gc3dpdGNoIG92ZXIgdG8gYSAiQ29weSBvbiBXcml0 ZSIgc2NoZW1lIGZvcg0KdHJhbnNhY3Rpb25zLiBUaGlzIHdpbGwgcmVxdWlyZSB0byBnZXQg cmlkIG9mIFREQiwgYXMgb3RoZXJ3aXNlIGl0IHdpbGwgYmUgcXVpdGUNCmhhcmQgdG8gc2V0 dXAgdGhlIG5lZWRlZCBsaW5rcyBiZXR3ZWVuIG5vZGVzLg0KDQpJJ20gcXVpdGUgY2xvc2Ug dG8gc3VjY2VlZCBvbiB0aGUgVERCIHJlbW92YWwuIFN3aXRjaGluZyB0aGUgdHJhbnNhY3Rp b24NCm1lY2hhbmlzbSB3aWxsIG5lZWQgc29tZSBtb3JlIHRob3VnaHRzLCB0aG91Z2guDQoN ClNvIHRoaXMgaXMgbm90aGluZyBJJ2xsIGJlIGFibGUgdG8gc29sdmUgc29vbi4gOy0pDQoN Cg0KSnVlcmdlbg0K --------------av6WNI7RO55KITFxB6HOvG7b Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------av6WNI7RO55KITFxB6HOvG7b-- --------------N07yogLjHR4aWprqHXhRtYl1-- --------------OzNMiYGf4oUyP9My4G6kRV9J Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP14mIFAwAAAAAACgkQsN6d1ii/Ey9z igf9GLwzr9R2fLV7Kefkg+u4e5kGZlqOIQVtiComlHwXg1CTWWh1y0HgDX7tLmfN2b2Yy85YYd64 856pLJx4w8ye7m3rgErks6kI7FkMAHOq3UulTXcifm+NdYfsWneICZoJzyA8TL1zcYLMwue7B0SN 1NLTpXrJUMpC4ssgTcm8rajP/1ahq3/rW0uL7SyzMAgVRiPGDeTiLNU6YZWI0mDUrrLvAJqAJwKk bIoAWJbOjT2cADEoLlg4zHA5ex6KjASKVN0j4CZzpgffPzNdU4Tg7DqFf1Tap23cW5cIERpbgH3X +sRRG9fZhSdx0zrk9DklIs45Ftb88VJF6U33NgniHw== =lEjF -----END PGP SIGNATURE----- --------------OzNMiYGf4oUyP9My4G6kRV9J-- From xen-devel-bounces@lists.xenproject.org Wed Feb 22 09:42:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 09:42:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499315.770400 (Exim 4.92) (envelope-from ) id 1pUldk-0003Id-VB; Wed, 22 Feb 2023 09:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499315.770400; Wed, 22 Feb 2023 09:42:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUldk-0003IW-SG; Wed, 22 Feb 2023 09:42:20 +0000 Received: by outflank-mailman (input) for mailman id 499315; Wed, 22 Feb 2023 09:42:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUldj-0003IM-Bz for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 09:42:19 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20617.outbound.protection.outlook.com [2a01:111:f400:fe16::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 320a7fa0-b295-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 10:42:18 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9385.eurprd04.prod.outlook.com (2603:10a6:20b:4e8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 09:42:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 09:42:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 320a7fa0-b295-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVPxVsPojw8Llz6IVf4BzDBbK3nwEPa8/T3eDWbblsPnxQzETnkVWhPg3WDqkEyVE8wAy3nkwGMPbDNgXT76X9kfRnBIs31+Lt3NIV2GxyPKSp514ZHmB6CXmrY2O6AbJG+NE1dFpeQTR4IoK5F3dSoQbqA/WjCZFT/ZRbCSTcP5Qsb62VDVxtH7YzZ/wtvNIztjwJWrW8HR7SZ/X6qpHnbs0t2IFN5ZJY+hyKALxQkK1wtKl8KHtt/rLeh8BiFSgtyYk0Z1PjOtdzNy/uJoPxfi3P5KLZkubx9oDe64Ge0K1U7JDzUr9C8XFlfQdlf5emo5I+ccht976H9YkRjsRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79YgbylKNmpmqn5WaEIFXhdCLmBY7/F7PcJedzqjRIw=; b=kIW90XKLdgkpakZtN1GLilyMG+/v420VxZxPGPaN4husQMU2Tx4RKdd9tQ26bYMIhTlBy/AOtHAmBGtt3gA+MlmFZZsr0n3F2cqozW8iIYCOP9bgYPSeg7dF3cFeq/4V7NcwCADqFYq5qFfaOxGGPory2ukQglpKrycs9astsDHOdIHYJTJ9WHrsGUc8M+VV2glwP09Emh/+BrzLHhagAKDxqaCxhJChTHybrSbjIOC9GI7MCBU5op2qHIQfSZ0X57avtCMn840ucJEweUQzwiPWbZHJ9yiG7n3hJ+uoengnygswwqk+/4Ve3SYj6i3+7oTDXb6Ypz3WveyjsD5ImA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79YgbylKNmpmqn5WaEIFXhdCLmBY7/F7PcJedzqjRIw=; b=O/fgJ5NKyeA/Uw4EcozwNdfbri5I6xnPGWfVuL+aFRlSiPJCQdAbsITEd6yS3MIqkHSOue1sNNJc7ske4hA/FBtIabj6PWetLdHK1qvtDEhanL9U6NzIETkJz5XY3xXWhXLK9HPJ/thTpbwSFEF/BwUbmot6pX+YDAeuWUppdc4IYkDW8Ng5A6Xg5SW4Y8/CvYPTMpW9zAMPXwjqk0SQrGdXQt5u9fHzyXzsh2hfQAZgUiKvopzZC8HxPRTGcJ4D35vh+71mUGabLPdXckzaQgzrEEwKuViNhTV0fQi2dHC253dzDeXB3P8BR0kQEccFhYnVupWNAOME21339Ijj1g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <621319f4-0924-9b5f-9f84-be275f878cb4@suse.com> Date: Wed, 22 Feb 2023 10:42:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Debian randconfig failure, Was Re: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-US To: Andrew Cooper References: <20230221165542.7642-1-anthony.perard@citrix.com> <19396277-127d-1127-cdad-341368f97e92@citrix.com> Cc: Anthony PERARD , xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <19396277-127d-1127-cdad-341368f97e92@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS4PR04MB9385:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c10d325-5adc-4185-e3db-08db14b91513 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mmsUxppuEuaOrlODxzF/IvZDVHtq86HirJkqq1miahQ+1aTQMDwiC1Od2myrieInlE4PqboxQ2bFoF/mEZb3cEwK2+icSHsKgNiBrP47UTS2OsPgPP563YLGKhzD7GNAyd86TFRgzlQXSVob2epMgxltdm8kr6BSt4pu2zy2q7zjNbYKzFQ533qxEPSszDHcCLkK++4qSnihiv0uwwbXK257GOH2C1IS2m9drFqs0vZkd69cj6HHs08toquB0wePcgWQcOwwU6kFVfus+T6qJtraA+FUXycD7AfWkBy4aQHuwYCawBuArlpLU2z+j2tM1qZr5TDpXDpzjRpzEul4HlkPWk7zj+wQ0LWYLHN3PD3i/3vVN6s+gpvTOu7ZeSwTJc1QgOjMg7DviuTI8Pj7bIg9SoAy+V5JgkdxjjeCJgu/QKzEB/4XMw5Pi8GHuIiq9ypMQ7RF8/FM1bezN8YOdlM7dSb4bZHFP/jKbxSOBDVS+2oeql+SqOKSEyzyExyIwABAB2FYWs44jinx1XlzcEqZHkyUpF1p9pSKcp7RI4XOdaxZppEU59zZ1rHHikdic7etCRWImDeV2t6DYaa6FKk998J0MWWLDA7fOgfnwijjlBcUkb7yZrF/J1XNQbhQIpEMsKDdaVhhUCHCvjDN4Mv9C9A9WK92yksXb6PzaxbMoxVgR1A5Otcfnm8kalXFPhpTf78+i0FnFg1Wd2nZyY+dPLOgGkZRDQGlV8uvTuo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(478600001)(31696002)(2906002)(38100700002)(86362001)(316002)(41300700001)(5660300002)(8936002)(83380400001)(66556008)(66946007)(8676002)(66476007)(6916009)(4326008)(2616005)(6486002)(966005)(31686004)(6512007)(26005)(186003)(53546011)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MCt2ZWV4VjFzNi8yOUhNMDJmNzFxbTNmNjBzb0swY3hJUkdjL0sxMkxCQVR4?= =?utf-8?B?eUFKaXkvRU10d3dLU3FKaVFGaUJkVkxjdzlBVGhGZTNncXhQcytFZ2hrbnlD?= =?utf-8?B?RFhiQjRhbGxQNHM0amgySWk5V3phZjc0TGl6VmxEOWZUdStYWWgwNURLUEZC?= =?utf-8?B?dXBoN2cxRUFnTmowN05DejNOS2Rybi85V0RyQ0RsTzFFTFNjVTZidUloaTBw?= =?utf-8?B?T05CL1M0bDJNSWVQZndLRWxaa1BGMlpNUWk3aFdCSXcyVFFlT0FlUTdhZ2tM?= =?utf-8?B?YnVkNVZWRlVUc1E4WXByYURmdDhyVGQ2TjZBVTREc2FKY050a3Z2MjhIN25u?= =?utf-8?B?UTBROXRpb08yUElDOE50NnM1SGlHMXJDTS8yRzRReVVKc2V5L0NUa25zQW5G?= =?utf-8?B?OEQ0ZWhib2dkTElNK2MxbEx2QjRUbXV4WUNpYmIwT0ZoZWVoaEJvR0tDZ21Z?= =?utf-8?B?ZHQ0dlVPclVLVjNFMVkvV1MvbURMOTYzOXZNNFVRL1hlTXAvNDVwQURBOGRT?= =?utf-8?B?QUVBbmtkNjNEYXVZVjY5amw5VG1ta0M2bE5Ua2xNVXNTSVBVYnIyTVdySG5B?= =?utf-8?B?K3VLTS9mSk1RZldnMTdCNDhkUXFodTU2c3V1M1cvdEQrLzJhbUVmcndMcERF?= =?utf-8?B?bTN3NDh5Nkx4MkxpNGhNa21WR0dBaWNudXlXenQ4YXlja1BCamRLd05zaWJ2?= =?utf-8?B?L1NyY2NseWdyRU8vajBtMVluV0xhZzloZjg3Q1l0bUVNQmMrbHFpK2ZIRFNB?= =?utf-8?B?MVFYS1YwTFJaVTNxdzJ6TUlUdUp2bS8zdGhRUUlVL2pDTm9SSmUzb3BkbXNM?= =?utf-8?B?WlVIR29GeVBPSTNMSU5hTjZDU2Z5UkxQa2dpeXIxVHRuS0RybWRNQ01xbmZo?= =?utf-8?B?b0M2M1I0Q1phVHZBOFV6Nk5QN0E2aXVxV2RmK3hVQVd6TnhudUNVbjFKcjRx?= =?utf-8?B?UkxScjVRZmNVYkxVSDdYYjZnZkNjS0NHMkxNNE5yUUhwYk9nZDQ2UjZIa29I?= =?utf-8?B?MGVyZGlxVnlZL25lc3MrdXZacyt6WEx0bFJYNitoMnhGd1JxWTdKek41NHRm?= =?utf-8?B?RWFjam5EejVFR3M1Z050aWdkbGM0TlJDZE1ISjRDQmYyb2piY0drRHpxUllj?= =?utf-8?B?NHEyRzczTDh5UUNQY1lpcUc5K0lGK0dLL1pZNEwvT0wvS0VyVVVQUTRDcEEr?= =?utf-8?B?OXlPSEpuOHc1WUNWNmZnSE53TGMreGtkbWlPMHBIdFVDbEF0WU9MYjNGVDRT?= =?utf-8?B?dDgrU2hLbkdjSWpsaVMrRTU1QStHRjkxM3VCMnBhN1B5TGlUWnVEdnMvV2NU?= =?utf-8?B?U2U5ZVJFcHZpVmYyOEV5WWV1Ujl5Q0RtZk9QTUR4aUY4eHlCdW4yMDJUMFFX?= =?utf-8?B?bi9OaFNZRFYvMGdydzM5ODhvSEhhUmpVeUZkc0NNRCs5d1hkRkVUbnJXYXor?= =?utf-8?B?V25lY0s2Y0hudWdKdzh0N0ZILzNiZi9UZDdYVitrRVlNa0FjLzNwU0trUk9M?= =?utf-8?B?RnBwK0hOYXMxTTlFcGFjck1QNEpGRjJpSTNvTGRsQkljczZKN2hFSTVBZDVF?= =?utf-8?B?dXIwVVJjQVpWYlpMYUxHNExzR0kweTc2RzRzRGZZWC9zSkNrRWN5UHR6ZlQ4?= =?utf-8?B?SjZsa0VjYWdLQ1k4SGlGekc2dU0yU25GL0xwOXBvVHFjNTh0NXZ2R2l3VmM0?= =?utf-8?B?WVdwMWNQTVpOQlA5d1p5aFZoNEdheVRxMkppZ1lDT0VjOC94SUpsTDUvU2Vw?= =?utf-8?B?bTFzblNGNDIrOGpIdVlVZ0JoWGN0UmVXcVhFNGxUWUE0M0FkOEV2UTVqM1FD?= =?utf-8?B?cllvL2d2Z0FzUWp5QWlyQkVjV2MyVy9CMEJRNG9lUEttWTBGQTJKTkRZMlc2?= =?utf-8?B?UmNtRktMV05NRWcyU3JyMlFYMTk4ZFByWFg0OXA4V2JCd2dLcUVab3dEZWQ1?= =?utf-8?B?OU8vK2J3c2VLUW9Sc0luRld2cEMxYXFNcTY2TjRaWXE1SnZKVnR4eTFuZXRy?= =?utf-8?B?U3JmTjFmdjZnVXA1V2ZiN05mbUJuSTN3UW5EalBHTXY3d1Nha1JiS3lQcXNw?= =?utf-8?B?QjJtQU5uRmU2bWhXRGZGa1NWODdadzk2V2hrMGh6R1ovN1BoZmZXR2pacUZE?= =?utf-8?Q?KUkplunbFUx2vGGw4B3fcZ0ez?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c10d325-5adc-4185-e3db-08db14b91513 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 09:42:15.9906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pIzy3JmPiHoQJjT8sAC9L9DEOdya8P2au4RmBULaPhdG7L3i381A5EK/oAFNZgr29kiT3E/0VVUfxG+V8I5B7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9385 On 21.02.2023 19:05, Andrew Cooper wrote: > On 21/02/2023 4:55 pm, Anthony PERARD wrote: >> Building randconfig on debian unstable seems to be an issue. > > You're talking about > https://gitlab.com/xen-project/people/anthonyper/xen/-/jobs/3769926509 ? > > + gcc --version > gcc (Debian 12.2.0-14) 12.2.0 > > arch/x86/extable.c: In function 'search_pre_exception_table': > arch/x86/extable.c:200:27: error: array subscript -1 is outside array > bounds of 'struct exception_table_entry[1152921504606846975]' > [-Werror=array-bounds] >   200 |     unsigned long fixup = search_one_extable( >       |                           ^~~~~~~~~~~~~~~~~~~ >   201 |         __start___pre_ex_table, __stop___pre_ex_table-1, addr); >       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from arch/x86/extable.c:8: > ./arch/x86/include/asm/uaccess.h:414:37: note: at offset -8 into object > '__stop___pre_ex_table' of size [0, 9223372036854775807] >   414 | extern struct exception_table_entry __stop___pre_ex_table[]; >       |                                     ^~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[3]: *** [Rules.mk:246: arch/x86/extable.o] Error 1 > > Jan: do we need some more gcc-wrap sprinkled around? I think we can get away without, but first of all I'm curious why gcc12 spots an issue there, but not in my (and perhaps also your) local builds. Being a randconfig failure, is this tied to a specific setting in .config? Off the top of my head I can't think of any which might affect this code. To work around this, instead of adding gcc-wrap-ery, I'd favor simply changing search_one_extable()'s 2nd parameter's meaning from "last" to "end" (i.e. the range passed in from [,] to [,) in mathematical spelling). Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 09:53:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 09:53:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499323.770411 (Exim 4.92) (envelope-from ) id 1pUloI-00053R-2P; Wed, 22 Feb 2023 09:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499323.770411; Wed, 22 Feb 2023 09:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUloH-00053K-Vl; Wed, 22 Feb 2023 09:53:13 +0000 Received: by outflank-mailman (input) for mailman id 499323; Wed, 22 Feb 2023 09:53:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUloG-00053E-E1 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 09:53:12 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20612.outbound.protection.outlook.com [2a01:111:f400:fe12::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b664ad3e-b296-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 10:53:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7678.eurprd04.prod.outlook.com (2603:10a6:102:ec::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 09:53:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 09:53:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b664ad3e-b296-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jyn3dqyMKr8kmQJxc9ujW+Qtx+91ecitkdIJKAQNDtu0QGPsX3Rtur6LBpkeNEFYcjBBD51G11TTzizr4RBqFU9FzfE9exa3UuPeE2pLgc7ve0+ke4SfGnblJQBYHLUKrfISeZDxuazMWdvAnhWrO+eFlys63s/vU1KvhhaY4kA/R27kNKLbM+KyJfrKN6AkGkdC4bUBbHZwxDhQspun3DiIYm3/14EfBzxgOT/VoaahKv9cMapBcSn160Sm7V6rJGtZRm4FIHKfJWen6KfzVMR8AaTyeGnQhbKqQrWpnIiASoolzyGSfsPaaeKUWJxm2UslWVDxSOJujJW9YL8Iwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4sVT6+6VZGaVE3SwUFqM7jDYqL5+aYTWCo/kbX1NcYs=; b=YwBAxOPmJtPHt3J9rixK+8NIzfIISAuyNqCh7yRumaWcewhxgFMxbIgdQsDD+LQqOJu3aRsOwxs8bQzhtQPZya2dWAsmnJ0g8PDzoUc3P5O2oHQj1wKVhhFtdRCQfuzR4Z2uBo9M23/6zXwwSMhnH1KgoDoDRbyNXuVuyn7Vr7pvf7rkQVvaR9H6sId42uF6f+FrgRHSq+gt/mvAGtcS89lbPKWhD7EVouNEoC2fOhisX+cuVI5dISHu94IPLuamPk4ST+3Px+Klxp+Ilguo9gPBBh6duLmca0UlDTIYIHowogqgjAUV/d0ewKAKujH51sVUrRG23aYxEp6HSLXrvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4sVT6+6VZGaVE3SwUFqM7jDYqL5+aYTWCo/kbX1NcYs=; b=h85Nxu+AARXvmlA6+qVMw6aqXvOxKgUGaAtIezCKC77jvkSoqQyqnnZW10bCGMgKRt4xQ5/wVHSITaoMZpQQ+Lrw5K16u4mbku3IZm4Q20mrhlKiLFFkbpiep+dZxgMIcr26yeO4rfHYy9NZdGrxU3yaVCrryv+T7rgurH6Vh7zWSMPsgtJ97NtNYZ3Pt8DOJMH0yvGPv8VLdGuHpGzUGsO1AEM12pcZRcnk0GZLiE34a8WKuYEA1dfMs+25Q0gmgTE6BvcUdw5kPvLnaCzT8UiHi/QHECWzLYngLzahxeO+tyvFBnY/Wb1XgqRzzn2X436W5HJm1+ouMsNdQ3Gb1g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 22 Feb 2023 10:53:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Debian randconfig failure, Was Re: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: Anthony PERARD , xen-devel@lists.xenproject.org References: <20230221165542.7642-1-anthony.perard@citrix.com> <19396277-127d-1127-cdad-341368f97e92@citrix.com> <621319f4-0924-9b5f-9f84-be275f878cb4@suse.com> In-Reply-To: <621319f4-0924-9b5f-9f84-be275f878cb4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7678:EE_ X-MS-Office365-Filtering-Correlation-Id: 31a2a678-25cb-4735-1c55-08db14ba996f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qqv8Quj0NIAiGwxvo6n/1KyrYQgUiKSXu6yZa2EwwsNawI4i/FPvtnMMcCEyHqEBa53DwHJzFuLSwawDF6f0e07HOxjQgCIsptLhOyag+FXJWE6qcEvSgd6XnvjuYmZoUcrCzVdAqFwgdmGR/mN5oQnK6OPmbbif6slK3Lgof6pto/N/75n0B3H8G8lQ5jrQ0a9UORkdp9PnbwtrrssUxzuQiQEr8L2VkzlCkMU4pxZcG+uRf6XWDSGVkOHvlAp3kjOlab21i40D0QioKSwDkXiTPHiefbkF0h8OSJB/8so36B+ZscIN/Ydjk2pX9CU8HjLI6p+Qkgc8hh/yaekTB7Ga1tMjoAYFemAwzKVR6CQBiC82YbRKk4iEyoj7DK2AjdVhqkGlF5TqN30pVANcPoa59V1cfd5m4utJr39hs524ffpFNmh0SpFd5733l0/GIFmGoVcSMN0zrZ5eTnwwrRVTk2GWC86uNLtnHlsweuE3VlSqAs1enu7vAQkg3HQmSZysEkLCDvE7zFOpcDJY11Dtf6A2Y7Ox7DyHd4iKyaHgU5dcPphS4RjGJkZCDbhzc3RwsV7+lvnCZosognG86OAwFjGPpAntjDmFIJea4tNazmjVFd4Gnb/knztSoBwGZI5gBzfF0vEHA5QInVPXaB0wpzEHO2g/F/TitBxVinh2YOzX+4C18w5/vUoyTzDsy68zA0clyz5dUncBNNSOU8QLHGzglxRAMjiyLkQlHmY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199018)(36756003)(83380400001)(6506007)(186003)(6512007)(53546011)(26005)(966005)(6486002)(2616005)(478600001)(31696002)(41300700001)(4326008)(6916009)(8676002)(66556008)(86362001)(66946007)(66476007)(2906002)(5660300002)(8936002)(38100700002)(316002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0VQNkJZOVkyM2pTRFVyWFZYeERuYlZnaDg3NGNNbWtKbzZCV1RvbzROYkt5?= =?utf-8?B?aW14WWpwQmpYYi9pVEoxdnB4ako0UWh4SnI3cUFYSys4QlV4QTk1Tm5vTHFt?= =?utf-8?B?ZDd3NWxXNlIzYnpxUHo5QTlCODcrU2VlK3hENitoVHdiRFIvVlNxeURheG9w?= =?utf-8?B?d25pSEZCWlJPbVFxc2UxbnJ5QmhKaURQb3JsYUZ2bmx5ZWxyVVNwRTdvZGJP?= =?utf-8?B?THRMakRxY2FTZnN6NjFhOFBDajJkelZXTE1selpEYXg4eWVFT3g1T0JDZDdy?= =?utf-8?B?T21jM3dnWENDdmNUL3hpMFVQdXBCYU55NGxtVjhOVHIvcjVUNHRRRkRzSVhN?= =?utf-8?B?Y3MzUDlsQ3BnZTk4UWpuSkhGa2drQk1kZHlUNFRRNFpKMzh1S01aTThjWnJm?= =?utf-8?B?dFFaRGV3MUVFZ2lkZHZGQ0dkTGpodlVNQXRPT01ncjBCMktUbDFlUUhsczhl?= =?utf-8?B?UVVzVmY5c0hGT3QyZkdIZWRJOUtRSFR4K1UvL0Q3VGNwRVFTZkRKVnEwNk9h?= =?utf-8?B?MFQvL0N2c1pweWpGcUlrbWZZM2pBOGJ2aXFZWkhEZGhuME5rb2JpZHhxR01i?= =?utf-8?B?RTF1dmcxM3N0QnFEbnk2YTRXMjE1MXZmK1ljbVZzZisrQjZTNS8reUxFdm5Y?= =?utf-8?B?UkM2N3ZhQkhiZ3JWUVV2ZndUSEdwS2VUL3lXZWpaTitwUE1QeW9xaEJMdlJs?= =?utf-8?B?dnQ5TzhoY25QcjAra0xJR09CNi8xVmNLdWxlb3VVSWxsdDNMSDZYWUxNMG1o?= =?utf-8?B?SS9PNEk1K1k0RHhRZkZabHNQdVhGZ3lzbUlua3JQeEFoUEtnS1lYM1F5b2E4?= =?utf-8?B?YU9YcjBzemtJdVlRZllwc1E4ZTZtUTVONmJibmxiNU8vYzdEY0drcmo4Z0VD?= =?utf-8?B?RzZpd2pHQ1ZzQUJHOHlpT0RLWjNGTGw3K1pYdEtXaUlScGtPSUhVYU8xeWpE?= =?utf-8?B?QXZOTzJsYlpVZi9TcThEWTNRVDgyUjhJUDJVdXZFSmpoWGlXVUdjSi8xRGFs?= =?utf-8?B?em16N0NJMmZjanJlRjlnRndhNVlZalhRVkprZHRBbS9wSklqZFpSUzk3QzQx?= =?utf-8?B?c1NJRlZkY2N3SklDY0tJRGhCZTJ2RTl4dXFmcmJYdTc1QnVFblhhRWpEZFE1?= =?utf-8?B?bzJoRnNGK1ovMEdJc3ovT2x6SmwwQXZnMTluZ05LU05GNmhjV1lRVVRCWVly?= =?utf-8?B?cVVZQU5jMWlpVGE2QmtMdy9ncldwdkRKaUZ3Y3hrK3pJMVBySm04UDVOY1ZJ?= =?utf-8?B?TXVKWmxhY3dsa2FBRXNaanpJUzlJQmZIZHM4Sml3WkhidGdoL1J1ZlJKYzZ2?= =?utf-8?B?VTNuZkcrSkRkRzZUVWRSMGVYTmRHU1lLQTljSWYwZjl4Tmg4dGU5S3VGbmRD?= =?utf-8?B?RkFsRS92Nkg1QU5FRUxDaTQ5d2VjVGN0WDVxMDBRYit4T2o4eWVSaVM5ZGlR?= =?utf-8?B?ckZtY3RPOE9IQlppOFQvaks5NVVYdkFrN0tVcVBKNUoxdHNrTU1hQ081VDdm?= =?utf-8?B?QVBrRHdGOTNkNVRRMU5HMkFKL2NrQVJrOVRoN1lrWVA4T3d4QS92RVBKeFY1?= =?utf-8?B?TzVpbXRYVEpUUVBuWEFobEN5cjJkcVFZRkMxbFZwVURwRXV0R3BHeFlwT2dz?= =?utf-8?B?dmhjQ0pOYktWbk9FdFlrRzBSVEJyQTUrSnFOMGcxYkJhWWo0WEh2WWorMmNN?= =?utf-8?B?TXVJNm96UkY2UVROOVVSQkdGdHVXemhSY01VUnRhM1A4SnNVd0hzUTVRL2c4?= =?utf-8?B?WVRraU04Tml4Q3RuTFN2d3c2RUo2QnVHNkxnOUZnbFA0OGlzREYyY1UrN0p1?= =?utf-8?B?a1RVbXhOaFhwbWNxNDl0VnVseTFLTzJaeG0rR2crN3FvQVZZeHoxQ0o3cjdG?= =?utf-8?B?b091N1JWMzl1UU42QWl0T2JpUC9zSk9mU2g1TE85RGErRVViZHBqcW5IRVRL?= =?utf-8?B?ZHhZazhFSnV4VkV4MGhYU20xVGhUQ3gzNnRHOGd6b0VoU0tFMk1sQllGVW5l?= =?utf-8?B?U1AycmVyRStWVzRUV0g5RU45ZjZzZU1ENXVlajBmcklDTlhMRW9NU1ZwQWpT?= =?utf-8?B?bG8xenlvZzJvWnNxc1M2aUYydm9xWnR3cEdiRlNrbDREQVB0MHBIQzNZQlFa?= =?utf-8?Q?gbVIfaTOs9496BLeDGsltr88C?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31a2a678-25cb-4735-1c55-08db14ba996f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 09:53:07.8100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0gQ0wvP7VLwRc/Be6X2DyJEMNLjOafsU/MH7qbf9FSSUOthshSt8sqDNAnno4Q3acmekg9/IurJhJ9ZkHJfR6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7678 On 22.02.2023 10:42, Jan Beulich wrote: > On 21.02.2023 19:05, Andrew Cooper wrote: >> On 21/02/2023 4:55 pm, Anthony PERARD wrote: >>> Building randconfig on debian unstable seems to be an issue. >> >> You're talking about >> https://gitlab.com/xen-project/people/anthonyper/xen/-/jobs/3769926509 ? >> >> + gcc --version >> gcc (Debian 12.2.0-14) 12.2.0 >> >> arch/x86/extable.c: In function 'search_pre_exception_table': >> arch/x86/extable.c:200:27: error: array subscript -1 is outside array >> bounds of 'struct exception_table_entry[1152921504606846975]' >> [-Werror=array-bounds] >>   200 |     unsigned long fixup = search_one_extable( >>       |                           ^~~~~~~~~~~~~~~~~~~ >>   201 |         __start___pre_ex_table, __stop___pre_ex_table-1, addr); >>       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from arch/x86/extable.c:8: >> ./arch/x86/include/asm/uaccess.h:414:37: note: at offset -8 into object >> '__stop___pre_ex_table' of size [0, 9223372036854775807] >>   414 | extern struct exception_table_entry __stop___pre_ex_table[]; >>       |                                     ^~~~~~~~~~~~~~~~~~~~~ >> cc1: all warnings being treated as errors >> make[3]: *** [Rules.mk:246: arch/x86/extable.o] Error 1 >> >> Jan: do we need some more gcc-wrap sprinkled around? > > I think we can get away without, but first of all I'm curious why gcc12 > spots an issue there, but not in my (and perhaps also your) local builds. > Being a randconfig failure, is this tied to a specific setting in .config? > Off the top of my head I can't think of any which might affect this code. Looks to be the combination of DEBUG=n and COVERAGE=y. > To work around this, instead of adding gcc-wrap-ery, I'd favor simply > changing search_one_extable()'s 2nd parameter's meaning from "last" to > "end" (i.e. the range passed in from [,] to [,) in mathematical spelling). I'll make a patch along these lines then, I guess. Should I credit Anthony, you, or both of you as the reporter? Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:08:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499329.770422 (Exim 4.92) (envelope-from ) id 1pUm32-0006rm-Br; Wed, 22 Feb 2023 10:08:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499329.770422; Wed, 22 Feb 2023 10:08:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUm32-0006rf-90; Wed, 22 Feb 2023 10:08:28 +0000 Received: by outflank-mailman (input) for mailman id 499329; Wed, 22 Feb 2023 10:08:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUm30-0006rZ-1o for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:08:26 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6a7508a-b298-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 11:08:24 +0100 (CET) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2023 05:08:15 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6233.namprd03.prod.outlook.com (2603:10b6:510:d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 10:08:13 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Wed, 22 Feb 2023 10:08:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6a7508a-b298-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677060504; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=K92uLc8rhYz2tw4w3QIKK5F2UC5P0rVMaInszbcBO2Q=; b=UfWdeCLmktGuMBxhHcUcQzqG4edz/vBRT12aA43rp9Ht4RCJeLlYU0iA YSd8rQ+g6K8oy1IYl/QXUP+IyadcJWpEZGdXud1D/VPujUblBLsAXrGnI QdFeZYxVhjSiv5yJtWliyaVTLePbAKuZla327dSdZj7mUu/wkT9qVOwuY A=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 100460146 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uC7nxakvWLE/PVh0c9/Sdlno5gyYJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIaWT3Saf+NMzHyfYx+OY6x8EoOsZDWzdVgTFM5qntjEyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5gWGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f0zOA0qMhyTvsGR8qyGYck22OJkNvC+aevzulk4pd3YJdAPZMmZBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkV03iee0WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTOXkqKYz3AP7Kmo7KBcub1z8+PSAtA2dZPRcB UUI1iMFsv1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnop4thu3MCkRaGMHOykNSFJf58G5+d5qyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCslDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:K7SvaqBf+90vvMnlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa X-IronPort-AV: E=Sophos;i="5.97,318,1669093200"; d="scan'208";a="100460146" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZqD+AAhMeAhxJVeeuIj/hrNIJIMsdR4Nzc6aVQHW2GU+emSi0tzD4lWO95L8ae7Evhv/mgE+2iz2WUgPF8CBuIZN0txm2glKkS0vNquZ7cqhva20jsKTA+RDm92Jiv3o/gxebXk+srtkp7imfkRp4mQpj48JZ0flGyDvwiMDI0c7bh2ZXAkxiWnPETCttBN2MCvizFekrmUX4clHrTr0LdvAbMXBfQyaXihqp/kJFyvtGAxUkRnTCaZFHL/5B+GLLwAAifDRpXXn+pv/jFjwyi7hll7hn+tUdwAb1xADMNCY2oT/yPn0et2f3VcgMabzCbafwYrVCcFNm7NqFOMYAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K92uLc8rhYz2tw4w3QIKK5F2UC5P0rVMaInszbcBO2Q=; b=UO405YkmrpTaP9lVN2/tO9qwHtKWE/VbohXeftxXLSSyoM0KhsIi6qiVRZDcrbocrL6Q5UMId6Y+fhbRhr1Bi4XUDn0NrMDXPlPgMHLs9fgUaWYlNgwuDKZTvuByF5yRFgH7Dfadnt22JdGmcGBA/l5F6Vo3OzcjLkQmKgDyUMp4viI4e6JHA4RlxfO6PtDyp/1AFhPnQuNCZPRLCCQ+yR5QojoIfeqWWKQmWwSB+bchXnZZx6ndXMLcIi+g9UymcjddEPsqyQ3bxPv/hdqxQrMKfI+UsMZE/Rcyqx1BdIsIVc+cFI+oeOgeIO68Xxta5W7QPBXGGBBprWtP2usykQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K92uLc8rhYz2tw4w3QIKK5F2UC5P0rVMaInszbcBO2Q=; b=Ntd0mBnrWcgtAu/E7SgzOdBBwOHsUfStVDXA3v56TB/FnrHQNdKrRR3JFR9XS5zj3rXXFF7OCQwRNMwr15/xFYwZTjBFCUePWHgi020lGwaZ37SsV8h8KW7EfYLn7L5VbhUnmZT7vaxwebMwSqhxjdjtFIAsc5dIdUIsg7ipRgw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7f34e7aa-e4a2-f5e7-f111-92e599713cb3@citrix.com> Date: Wed, 22 Feb 2023 10:08:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: Debian randconfig failure, Was Re: [XEN PATCH v2 0/7] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-GB To: Jan Beulich Cc: Anthony PERARD , xen-devel@lists.xenproject.org References: <20230221165542.7642-1-anthony.perard@citrix.com> <19396277-127d-1127-cdad-341368f97e92@citrix.com> <621319f4-0924-9b5f-9f84-be275f878cb4@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0016.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6233:EE_ X-MS-Office365-Filtering-Correlation-Id: ea860141-6755-436b-1599-08db14bcb574 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gwP8XR4k9AVBGIQze1fvG3Nj8RqKUZh+jX6o4jE5M3Br/TiMC9H42zQrMaSFMvDbBVhpS7XQ6MgmM1xQaY5WfWMuqJp40ZtcZWrIawscxs19urzHgwaqpgxcQhHQsECnMhmHFiZgRzIU5L3KKc2VitO0YbrOZjIhxwyKIpVb6D4GNdaN1uCABOcISDElvmekc4bQ4ZCHnLYiPttwQbKpGfU53amOFtCrIzfOBAJRJ0X3TkQpx6oMLluu375CVFxefxQLxYajyBKYkQ1gWEtfXUHFgs9budAd67gKpmYIKny7c7xtaViKSlmjbKJAGPFN9tOkoTf1oPqATKjmR2DQaSK8LjjgPeiKPYYHCMIoemk1Wb7m91Vct1VbCabKdYpYKHclAElw935tFIP3w24uxcShJdWZRMC9WdzoU6vBeeAlpzwgQb8bmTOBwADMN3sTT7KZCXOREOOUPclkVgHE6TClxBfSPXhqSH2E/YJTgZv6d339G+1g+NSNPMkK/b/mqvmOso1XAjDH69Ntnr2RyjvfM5i4eCc6jhatYxb5pie6h0I/xDSTdmvZ+S+2WqkmSA5/zxwNM3DexGm/f+tPNChFxvyJKBGlJ2yO7mb/f89LO3rekcLUPcksoT7HdwicsuCVK/mivFxNNmA99DmH489NpLqxAzyVINxxxAdRuaThaAgyywdlIejNfZXo6kDD5pCLuS05DLnaUH0y3XY/k+0FG/wZjIVliYToN7K0NsY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199018)(316002)(83380400001)(478600001)(38100700002)(36756003)(82960400001)(2906002)(86362001)(31696002)(66946007)(66556008)(66476007)(8676002)(6916009)(4326008)(8936002)(41300700001)(5660300002)(2616005)(966005)(6486002)(26005)(186003)(31686004)(6512007)(6506007)(53546011)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVFWb2hIemcxOVRQeXNzU3B5SXRFaHVreU1VRUF6WHBXb2ZiLzNBWGpjYkJG?= =?utf-8?B?YS9vYVNYQlNoTndJc3VjZ0VwdUlwWElYVVZhb2hzODJuZVlBMVdxalVLL2cw?= =?utf-8?B?cDVFUGZoZEhBZkpkam5lWVZMa0FqdE1oZ1k5RWZEcWMwMVFPbDg4cFc3WVRk?= =?utf-8?B?UGV0VVo2b2lzcFc5aTAwRUNoM21ZUmQyYVo0MkdublJKdmxYUkxzekVIamFI?= =?utf-8?B?WkVENS9TVkRZV3IxdWwrdUk1bTdDU1hwaVpQUkhIYTlIRXNVWG5LTWZIbmR1?= =?utf-8?B?NzR4QzBqeXk3UlAydGFhaFdkZWZucDBhU25LWGZQWE5MYUxrSk4reDVEUklX?= =?utf-8?B?dzM2b0k2dE9vKytnK1d2amw0ZzJMblRoUUQ4MU94L1F0bFN0WlpOTis2YmhM?= =?utf-8?B?NFcwSDViWTRUYy9vK2ppdFVjYndWeHhyVTVNRlRuTThOUTNDamR2dlpSekJz?= =?utf-8?B?aUlMSnBKUE1VRDR1T1VDL3VmaWcyakN5aWNOSkZXV3lEb0d1ZnN2aU00Tlpm?= =?utf-8?B?UDV0K1NDREp5OTFMaTRZN0lhTFp3aXR0NUFqU0VEZ2pYVnd2Zjl3ZnF6MnU5?= =?utf-8?B?c296bkxJN3BLR1ZLdE1PL2FEWFVnb2pVYUNsVUlOUkxjOVZ5eWh4ZjJzVFpu?= =?utf-8?B?NVdnU21BT1NUdjVoa1hXNk5PM2ZNL0hoOXZZSGZjUXBHTVNlT21kSkdMSkY5?= =?utf-8?B?bHhMQzlsSnpZdEpKZFI5VTM4WFpEbFNGZUNlTysybmN5RmNjcFprNWFvTHdk?= =?utf-8?B?Skw3N2Fld2xvWTlxcGljSGhjTWNVNjkzUnViNGIyaFZlNklZOEZjMWc0MVU5?= =?utf-8?B?M3psRnpJK1pIb3R4Z1I2TC93anY1UktLSHlrTXBJVWVDMTZLSEx1bmFCaWVt?= =?utf-8?B?NmFFR0xVQVRyMWpzakFVNjJJOE1zVkxrVHd0Q0VnTG5UaU9vdks5Q0E0K1A1?= =?utf-8?B?UHFHUkNNRzM2ZjBXYXIvc3RIQ3FuMTdMT2o2cmpZczdCWFYwY2JhRUh6ZXpt?= =?utf-8?B?ZG1tM1RIazM0REcrZW05VmRBYy9rdlUrR3RLeGI1b0o2dXF6VkY0ZnRxRzRD?= =?utf-8?B?R2VyRzBkZExNRTlLSVZnRjNoZW96RS80bUtvdmp1OTE3MDZIb0hJQ2ZNK3d2?= =?utf-8?B?RUlnVkFjc3orZHRCYWZOaEhsVFhFVDRlb053QXhsdHJVSGpWTll2VWZjaGVk?= =?utf-8?B?TE5uQkJ0SUNXU1V4VlJHcTBHQXZMcFRPUGpYcjcxNi9EOTZqNDhsYjBpMUpn?= =?utf-8?B?YzY2ZW9qQ2dDTk5pYTFVQ3p5SWhsZlVkOExMZjFKUmhPWHphWERIZWV3aFk0?= =?utf-8?B?WE1FREU2ZUMwQXJVMHhEL1JoTjdEekJXVHhvKzJzOUhEVE5oZm1PSjRpTHMv?= =?utf-8?B?VFZXVWpTUGt1dnZ0RW5tZkRJaXZadDJQYlhNNE9pWllKd3d5dVVsK21kd0dW?= =?utf-8?B?N2JGUktDdjR2eFF0dGVyZU9kWEFOejdOSW10MlJDVlhnMDZjYlBlejVUUXAv?= =?utf-8?B?V1RVc1I1emxzcnc4b1UyZ2dpRUQ5T203SkJwclJvOXpRcnFTNWF2YnIrejhW?= =?utf-8?B?dU5qMHQ3YWpBamhnY05TckNPbTFRNkxuOFJHNlZFTmprODFTWmtLQ29MNTcw?= =?utf-8?B?K2dobWtZR1BLdzFOVktyV0tma0R3cUNZbW15Y1AydlN1ZytiNndyTHNTTjA1?= =?utf-8?B?TmJ3YnpOTmdkcnNIYi9YV1BKc0ZUT1dEdzVHSm5qMzBoV1JzMEdUdDA3OXVI?= =?utf-8?B?L3dqdVNjY2R4TEVtdW1UbFU3UjNKZktBb2NpVlhkMUZJNEphNmxkNWFmMXJW?= =?utf-8?B?RVRRZUdXUDAwdmtFYzZQZUpRbGpyOU9ic1lrQkxvSTV5aTZ1ZC9TYlB0Ly9Z?= =?utf-8?B?VWN0ZEQ3dVZYb2xTRTQ4TEJaVFBwZzNMUjMyVHo3TCtaSDIxVnhqVmJRVWtq?= =?utf-8?B?K2dCMnZ0MmVJYUxLMUo4OWNCbWQ0cnJQNG5xVmVaWkNDeUtRTHRNaUljSjVB?= =?utf-8?B?a1hPV3N5V2VRMzBEZkdNekpORzEyZ2VZdmFRS2E4S0hyOFBmNmpGZmNyMkhz?= =?utf-8?B?QW15SGhqQzNVLy9qeXJTaTJBeERHN2ZBWFJab1d5Z0xiV2lzVHlNQU1CcUto?= =?utf-8?B?NFRuSjlYdkFETjJIWFh5QkxhSVQ0akZnZGdkTS9sSzVrY1BnY3R5d1A1Y214?= =?utf-8?B?K2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9SmD/P0tQHfsxdvG75OAUUGckbva57W2GsYHy/En38p2Nj7ApjRAO8rwbzmKOoOtXYurLUin+LanATV5smgeikmeIlS6l3huOZ0HeGS3aHFze+AbOmw1as06iE5ERLVltXvXZJtXnbhtbyTymqxdQnvTFqGXOdFlCTqH07vHdLRiZTmQULQc6OjP6imZTXDAVtCWwPUQ27+Bh1p4nPLESrTIlaRGUa22AHtXuIAKF2KKt6Rjr3YXzCsjQyl+OTREUh5EjJtWXiOOC4fJxGKnFS5QuqhW0k7hBU4hHpi/5D3csqj0E0/nznFhdtqqP7JH2GCtHeUnx4bEFVjnl5gq/cCOCqIYnjUPRahOpjXP56Ud1wsXULzXVahHxcinV5znoJYEU5O6ys1S6YquOsw+mheOVunrUy5Oo3F8x9ApDee82mXvhSZqdoJVW/XsEw9WnYzZxThqWsIHFICwXooV+jSlC0Ku5TFZEOIcCSMEMnfUV1ZpCYgL/czwsaN1NqJgRbL5eKiCdF51ZLytki9ILNKv3nOtHMnIl0nqyGdhq1JghzbjwORZsqO/5Fguyd1VGYHpFY/0sOG8DqntII05IA4psAstiRMi2KYWkt39UwziU39PcSa85Q+huBLVjW5NmzADW1CimDfSKuUx+IZcHeWMk4f/fjRBSIfhrkSo98hocIuk1KFBGVlzw8+wjEQwkDbGiPrnzfcmWcSorUYkCKBijDHR6K8pxfc0YCuHP6IDg1y7xROW8yv0axAThut0bNWWd0Vn5JWe+fkVP6w9hHgQHpM9R3QPpXVDQ+IgqzFD7jnCAweyrE7BBlnz5q6I X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea860141-6755-436b-1599-08db14bcb574 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:08:13.6716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N/Np0F/1fMrLx2hv+bX/rFkBUcLBwv9QxBKjI5FNOBIAwx5DOZhLdoBx4909aJw54HN5FgR+NpRgDRqqIH+/KupAoMgR23TtMHK0516Ys4M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6233 On 22/02/2023 9:53 am, Jan Beulich wrote: > On 22.02.2023 10:42, Jan Beulich wrote: >> On 21.02.2023 19:05, Andrew Cooper wrote: >>> On 21/02/2023 4:55 pm, Anthony PERARD wrote: >>>> Building randconfig on debian unstable seems to be an issue. >>> You're talking about >>> https://gitlab.com/xen-project/people/anthonyper/xen/-/jobs/3769926509 ? >>> >>> + gcc --version >>> gcc (Debian 12.2.0-14) 12.2.0 >>> >>> arch/x86/extable.c: In function 'search_pre_exception_table': >>> arch/x86/extable.c:200:27: error: array subscript -1 is outside array >>> bounds of 'struct exception_table_entry[1152921504606846975]' >>> [-Werror=array-bounds] >>>   200 |     unsigned long fixup = search_one_extable( >>>       |                           ^~~~~~~~~~~~~~~~~~~ >>>   201 |         __start___pre_ex_table, __stop___pre_ex_table-1, addr); >>>       |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> In file included from arch/x86/extable.c:8: >>> ./arch/x86/include/asm/uaccess.h:414:37: note: at offset -8 into object >>> '__stop___pre_ex_table' of size [0, 9223372036854775807] >>>   414 | extern struct exception_table_entry __stop___pre_ex_table[]; >>>       |                                     ^~~~~~~~~~~~~~~~~~~~~ >>> cc1: all warnings being treated as errors >>> make[3]: *** [Rules.mk:246: arch/x86/extable.o] Error 1 >>> >>> Jan: do we need some more gcc-wrap sprinkled around? >> I think we can get away without, but first of all I'm curious why gcc12 >> spots an issue there, but not in my (and perhaps also your) local builds. >> Being a randconfig failure, is this tied to a specific setting in .config? >> Off the top of my head I can't think of any which might affect this code. > Looks to be the combination of DEBUG=n and COVERAGE=y. > >> To work around this, instead of adding gcc-wrap-ery, I'd favor simply >> changing search_one_extable()'s 2nd parameter's meaning from "last" to >> "end" (i.e. the range passed in from [,] to [,) in mathematical spelling). > I'll make a patch along these lines then, I guess. Should I credit Anthony, > you, or both of you as the reporter? Yeah, I did wonder about changing the final parameter after sending this email.  It stands a reasonable change of simplifying search_one_extable() anyway. Probably Anthony.  All I did was look through some logs. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:23:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:23:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499335.770433 (Exim 4.92) (envelope-from ) id 1pUmH8-0001Ak-KY; Wed, 22 Feb 2023 10:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499335.770433; Wed, 22 Feb 2023 10:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmH8-0001Ad-Gv; Wed, 22 Feb 2023 10:23:02 +0000 Received: by outflank-mailman (input) for mailman id 499335; Wed, 22 Feb 2023 10:23:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmH7-0001AX-CX for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:23:01 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061a.outbound.protection.outlook.com [2a01:111:f400:fe1a::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0b5de9c-b29a-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 11:22:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6935.eurprd04.prod.outlook.com (2603:10a6:20b:10e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Wed, 22 Feb 2023 10:22:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 10:22:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0b5de9c-b29a-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jlq0qxK9Ds/6pID+/wPqHgn25q9JRlb4D1l8aIlzAUtFIi6EaZIhoBWT+kXdAA69JWQIuHV7ZXGwSFKBnja80x5/ZQtjK8WyTVJFQKOXtNHsZv3AEZ1tn+JY7tSZuLYmhG77cnqGKZMq0bTQ7CBoiGnnP5Pf+wPKecSF8xeaXupX4sgSQA0dhlaWePCCGizmBsh909BhUG/SUPWdMFjLY/OHQAgziiX8H3cZQwyizjRIj+zx+Y0uu14nD6X+40CDQoO63icfFOuyH23ToE1vn7OXrySg8T8jSv5q9tgm7v+aK4ZR5hbIyeXXf2XJ360fNe134pFdoNCc7YpVfBkYdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OABGfhw/XniI7F6M7hCIrlgr1VnzTirO+SOQl/uiVm4=; b=MJJ+EQsDuWzTboHavD2Eekfz7wiOH2bjBMoQX5lxgLUuFlXTSigXWaDku6iZy9z12M4TPD9z1waPvm/lmTEqyZUyUvR3kM0Xox8/5SAuxcpTIADi9jD5yxYsm6CuoNhr09MrfvpTywl/Iv/TxBfK56/Sqz0Ygg6CybfnW7rx0yiyjDqo/23tZjtw2BRv0GiC3VRa9jTjGJNUYEkF7LTQvFscrFxquj1kkdaGJ6zlVr3Uz5piWS3Av/yCAn7Q1CS5v/GQK0uKLSgpLVreg/OYXAYmYtnwe0q86eczMHUOsjHzHOlz3kBVV0mFEzvqYDwrVODu8LgVsR/PiGuV6q6REw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OABGfhw/XniI7F6M7hCIrlgr1VnzTirO+SOQl/uiVm4=; b=c2v50GSSSwGew/jLEJ5YVJVjDKawZVsKjtkoY4ez6sm03n/GZu4VwWclz//kVSQ5rtSKOkHzxm9cDsk6jY4i9YuGsnLOYfrQTC7DEi5Bs3sgONrAVjbn7yDhW2bN8yTOmL2mTJJ6lKP69SSyQSuDSW5KIi1my1A9aak8sZ0a2WUbulhLDnsNNM1ohudNOAZZr3EliMFe+K8eYxQtjfZdK2AOgmwCA882lYU5urphTwobJg8OG8x/iPDcc7/b11hHsSmy7+R2iLVpnhsbbzkVIBM8iXGyRv+8mPR4Swhp0GNGVaW07ltzx+NJKQUw+UKrXHEp7FplK80A8vNVTv/pSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <359b8d70-0a97-8a52-fca4-4f6b7621d58c@suse.com> Date: Wed, 22 Feb 2023 11:22:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/extable: hide use of negative offset from array start Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6935:EE_ X-MS-Office365-Filtering-Correlation-Id: 1db58c3f-3b58-4cd3-67a8-08db14bec3aa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QrmfSYRhs/UoW16GlVrkvu0Cdbd7jwsOPA9wKGWfvbKMS+/ezo6cQq7Xf67vnr8rIGzKoy5OlQ1dGefG49NKKJUThJmMhAw/mK1fK9OGDyC0HeRM4ei2jqOK//ZIe8ra5pKDCX+ZAk8Nw9Om0Iv4trZSyYoTpW2K4T7P7uS5gGGyrUZB6si214kHMQPAm30BAbSlui1BiJdfBAnfkyaHEmFoRW6JkMCZgonNAD3uZH6Z1j2P54iLu6EtmT9HzlEGVOWd6rsxVytsRNiM0ukwb2rKy7XLxmI08D/9QGipT4S3N6tZDwA31xeWFyhzETFKSjlJMK4qlEdogGfXNPczFN1VqOwNn6wwGXgLeFGJboEfHHSnO7NmuShVwk+o0N+yulOUJxlU2CvZHFjCTUIrjO0CwlaFRV+6QTHeH8BPeDhI/VQHJ8mFHBM64rcnqeW2fRT7L1PJmIEoJQYFuLzo7DNVWDAGiR9s302QXf6g4DqvkJ5lidtYYPRVj1jAvP6Zjj55qK+DqkaxEzDbKDjtcw9O11fZiLKoJsU3lsiLTYsnZ2dwDXI6G8KGBIZ/K90n4YG9YTSTfZtNjXuNIJYYo9lVCVQNa24P5kWdWnksTpBrytprGy75V8iiK5qyFqE4NmZIxTdNh1K+EuvnL/bIHfrnwtRX31Ol8u44eIReHQdKPjufQZFOkaez0VP8gFhEFJN01ieIHjSe2FV637Hnmd6h7xFfPZSyRqXkp2SF86k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39850400004)(346002)(396003)(136003)(376002)(366004)(451199018)(2906002)(86362001)(2616005)(31696002)(83380400001)(5660300002)(38100700002)(66476007)(6916009)(316002)(41300700001)(66556008)(4326008)(54906003)(66946007)(6486002)(8676002)(8936002)(26005)(6506007)(478600001)(186003)(36756003)(6512007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGFQMlVMYzJKRnllN1UxUVAyR3d0bVZLNnp2S2ZTZkNQVnZBVDhsR3kvVmJp?= =?utf-8?B?UEdOQTNPaFNnMUZreEZ3WmhTZ0pvVTdESDBBbWVPUzB5U043MDNyWVZTY0FL?= =?utf-8?B?QUNzbWkvMjQ5MldWazY1d0Qwcm5rbVJTWU9ocXhPRjgyRlNYMEMwT0FQdmN3?= =?utf-8?B?QS8weUdQb1lMQUNmQnk0UlR3UWRMVmduOUFVSWgzU05pbFdUcEt6WkJFSzh5?= =?utf-8?B?SW1xYlorRVZDZEpQWkFFRjFrMFk5Z0NWRk9ucWlLYnB1c3FjMmsyUDFia1Jn?= =?utf-8?B?ekdOdDg1Y0xuUGhxSFZUUGM1WkQ0RzMxK255K3U5b3hhTVhJSmdnTkxiRGxr?= =?utf-8?B?eUs2MnQxakt1N0lMNW1SL1dGUjlDRUEwcDB4SW5ZRmpmSUhnSTRjWVJ2YUxH?= =?utf-8?B?Zm5KcmpEVTUyb09SRDhCSWlTNXdYOTE1bk1TenNnZVNyZkxzdm01bUpNU3l1?= =?utf-8?B?eTExWGlSMTZVdmRkblU3WFM3WFo0d05PSmZLeUwwazZhMExQcmZhTWg4eTRQ?= =?utf-8?B?N3FCNzJVZTFYZEk5L1A4STZ3am5tbXU0MWFvQ1V3R1FTTEhvaGVxRGgxVm13?= =?utf-8?B?T1NmcHJvdHpHdTFaaUU1TS80blJtemFPdWhVZWRqMVpvR2RSMkZubTFzWC9F?= =?utf-8?B?TkVhV1lsU1dQWXFaR0dnTnFGbllaeGlOeDZKTklRYmE4amlxT1FkajJ5eHBE?= =?utf-8?B?cDVaR21LZFFYUTZTOG1KUlRwcm1UT2pVZkhjYlVpN2VtWGxYV2VuN012TEdD?= =?utf-8?B?QVpXS2gwQUpqbU9NdVRtL1NMMy9KUHZvVTNWSFhCQTczbHV3QzduTm5mYTVh?= =?utf-8?B?MGQ3YnZKbDVCaDRSYlhqcjhwbnUrcEVOZHJodWFpaVhCYUdpVHcvYnIrNkdq?= =?utf-8?B?YzF5WWhwbTFha2FkeGo0azZxd0k0bE9Ib1V1Rlp5QlI5OGlUUmthVm9TR3Bl?= =?utf-8?B?RXhYOGZiSlNCd0ovM1pBU1p6NGhBajdMYUZzNytlOTBqUkZENm9penNtYmIv?= =?utf-8?B?LzBWa0pQejJwTmZuQzZrSU9hNk9MY1NQazUwOGNlZU5CcWlsVzJRZGhJWXVN?= =?utf-8?B?eDZIZFF5amtUQXRVNFk5MzB0dXY5RDVFNVI2QW1ac01zMVVPaHF4VTJVKzlZ?= =?utf-8?B?Y200QW02endDOUU0dTBSUWhNYkNBNVpYUkNCb3dTc1F4aVFMelNGQ0lPN243?= =?utf-8?B?SG9RRUkzUC9SeS85eE1VMmI1akY2VXNmdk1lVTFubXdPbjZjZnpnUUVTTUlh?= =?utf-8?B?YlFDWVFkOXFvWU9XdGk3RTJTalRjR245a0QxbWlHek5lT3lmUUlpeCs4Z2JX?= =?utf-8?B?MnRJUEV0QWFhZDFEM1M3OEVXTlFyWlJzWnZLTW9PQlNBdVFRNWhGMTVuRTdZ?= =?utf-8?B?dDVZODMrclNhOEpCSkhXN2hVeno0L0RxaXE5SVphWTNsRzh3UnBIdEQxN1A1?= =?utf-8?B?UUJxZjRTZitGd2d5azJZWGUwZXN2YXNjazVxYXgvVnh2OHJXVm1KRnhvOGNL?= =?utf-8?B?VWJxYzVobkh0VXg3TFc5MzRZLzRqKzE0YytjaDFiUDVnL0NtNkhQTEpIbGJI?= =?utf-8?B?d3cvSDZ1QzZtVzkvay9pdEltOExCQ0VuVWkxWTZabEZ6VERnQ0pMR2lHZTQx?= =?utf-8?B?S0lrRlhPWlVmRWxlU2RwU29vRndVR09Qeis5alpZSFF4UTlMQkdTc3JuQ3Vj?= =?utf-8?B?Ulo1cUFtaC9RK2k4M1FmUWRJVUFxTE1DRDNDaWZzanQydkpEekNDaDM1RzVq?= =?utf-8?B?VnhTVGQ0YWVLTER3YnJLL0JidmthbWJVbUNjQUVJVnRnV0xJYm5VMzkvZ3ZI?= =?utf-8?B?Y3FZR2J6VFRkeFBVU0cyS2FlbVg4N1ZQQ2lad08vODE2eXkxMlNFZmFYOEM4?= =?utf-8?B?ZU82Z3FwRGRKYktvZ3h4WVlTY2lEbDBOeWlTeTgxMlNqSGVmZHdoOXo5NjJz?= =?utf-8?B?MExySHJXbjB2ZzV0UitBdmdsL21ITjZOaE9TeE9HTEpPY1E2cGgzTGY1MnJt?= =?utf-8?B?aHV0Y28zSG5VYldRRExmUW9iZ01QK3N3OEJXZ0g5eWcyOHN6dE5ZemFNUFND?= =?utf-8?B?ditrTHV4Um9yZzBsY3IrTHVtNUtEeHJXSFVpZUVlT3VoeUFvS1FXQXNXTXJE?= =?utf-8?Q?mufGsRBNF5bdaSJoRv/qy+dhQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1db58c3f-3b58-4cd3-67a8-08db14bec3aa X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:22:56.3842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wknenollkm+xZXPIs78+Ja7+IHFhh7dJQXroSi8maF1Dao6IWbihA0QcIMyD8aaKDwa5vmK1Ckj49DEH7/tidQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6935 In COVERAGE=y but DEBUG=n builds (observed by randconfig testing) gcc12 takes issue with the subtraction of 1 from __stop___pre_ex_table[], considering this an out of bounds access. Not being able to know that the symbol actually marks the end of an array, the compiler is kind of right with this diagnosis. Move the subtraction into the function. Reported-by: Anthony PERARD Signed-off-by: Jan Beulich --- To keep things simple, I'm merely calculating "last" as a local variable now, rather than replacing its uses by suitable ones of "end". In the longer run it may become necessary to actually go this 2nd step, as in principle the compiler could inline the function and then still spot the same issue. However, while the subtraction of 1 can likely be avoided by suitable other adjustments, "last - first" cannot easily be. Yet that's also an offense, in that it's calculating the difference between pointers into distinct objects. --- a/xen/arch/x86/extable.c +++ b/xen/arch/x86/extable.c @@ -64,9 +64,10 @@ void __init sort_exception_tables(void) static unsigned long search_one_extable(const struct exception_table_entry *first, - const struct exception_table_entry *last, + const struct exception_table_entry *end, unsigned long value) { + const struct exception_table_entry *last = end - 1; const struct exception_table_entry *mid; long diff; @@ -91,7 +92,7 @@ search_exception_table(const struct cpu_ unsigned long stub = this_cpu(stubs.addr); if ( region && region->ex ) - return search_one_extable(region->ex, region->ex_end - 1, regs->rip); + return search_one_extable(region->ex, region->ex_end, regs->rip); if ( regs->rip >= stub + STUB_BUF_SIZE / 2 && regs->rip < stub + STUB_BUF_SIZE && @@ -102,7 +103,7 @@ search_exception_table(const struct cpu_ region = find_text_region(retptr); retptr = region && region->ex - ? search_one_extable(region->ex, region->ex_end - 1, retptr) + ? search_one_extable(region->ex, region->ex_end, retptr) : 0; if ( retptr ) { @@ -198,7 +199,7 @@ search_pre_exception_table(struct cpu_us { unsigned long addr = regs->rip; unsigned long fixup = search_one_extable( - __start___pre_ex_table, __stop___pre_ex_table-1, addr); + __start___pre_ex_table, __stop___pre_ex_table, addr); if ( fixup ) { dprintk(XENLOG_INFO, "Pre-exception: %p -> %p\n", _p(addr), _p(fixup)); From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:35:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:35:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499347.770444 (Exim 4.92) (envelope-from ) id 1pUmTP-00032b-VL; Wed, 22 Feb 2023 10:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499347.770444; Wed, 22 Feb 2023 10:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmTP-00032U-Re; Wed, 22 Feb 2023 10:35:43 +0000 Received: by outflank-mailman (input) for mailman id 499347; Wed, 22 Feb 2023 10:35:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmTP-00032O-3l for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:35:43 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe13::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7179f4d-b29c-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 11:35:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8144.eurprd04.prod.outlook.com (2603:10a6:102:1cc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 10:35:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 10:35:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7179f4d-b29c-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAC0ESwZS6TtArQ6xWJxMV3XzIIT0TJUXBJbrOKGaateULlXv/1xrtL1ZpIO46qp/aMUniPXD5Fwpuha7a3Jvad3BhzeumOf2qTAR/rzap4G8UAYDk1kcwmjYcEPpr3cmpoPClavfvpIqz3fzoz8bAfdSmWUVXUHYz5GtZmER3SRKjmwtArlCLEbozNnhmTBKMELYOpBMxe+h6HfPTmPNaScVIh6h4vmrp9aPdtOe5uPuJ6x5+xZz0LACxYySNT/I/PeaUDmgdHoNrxFBW0g/H1uKw9OkmoDy3yXfBx6jHsFO810ZbuYuwMqB7tsDCL1c+UXcJ6MgU9+cvtEsHqB0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5etHIMqI3C7arm6Ep3GLTy1uNN/G7VrBq+eM8Xi+RqM=; b=ISsYA47byBFrO/YT95QVECKqBYYnSqQV4r+vbmR3wL4KhJKrRIzkSst4Aw3vTHHkWQ1CNmEeMdQjdYbvYzlOmFPRTXqO+MvMZdqWhDBuRTbXvKbIb+MIlUQQ/vqFE4ffJuXRhzJdZ64YzSP0XchOWT7v6WckekmcRwYCPdwNGFM1M0XfH2cTRlX6YbF/1OugROvPoy9NVyEjhkVOaqL627MpfXu8Wvwrg6U7zxpQvzKfMpvKz4Ectu1x70L35CLcSs1blEdGYhkbNN87X5K1Uio6NbmvpKeknPTObdyN+72bMCj58uwL7KNsZB55SX5JokWYtvj4fkQJg4wbCOFOjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5etHIMqI3C7arm6Ep3GLTy1uNN/G7VrBq+eM8Xi+RqM=; b=xuWtiYvzuPjKuggTnUBuf1jJDWE3pL1viKttAmmWkW8Y+iVgt4Vit3tNIEi81c0irRGvlhBtWZTpqDKNcOa3lpBgxxK0+P39s7eS1XWKDeqNLelHemQmFb60sKE04x4nGYUYX2XLmTEkBegG1DO1z3+n3zh6RjGr+hEwcfPvgTYOwWdwi+NZB9twalE3VYQLaJKNqX3lgA4FCVFhDm6mPChiYDcnaeSi7KgmMMSnDlcy8cZLg86YaGTfEw2i64r1u7eoXIC8SELmY0zmex9QhL61UcLuziVThWQiBDog5wiDkVgOa3WlDfkEoJ/0ku7KjsdB+jkk+IwOfaP/4e1ehg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c362963-e6c0-f610-3bae-9465dc91a73b@suse.com> Date: Wed, 22 Feb 2023 11:35:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/MSI: drop "packed" attribute from message data/address structures Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8144:EE_ X-MS-Office365-Filtering-Correlation-Id: 855cfe64-e62a-44fd-dd33-08db14c08a74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yXUAabAXhU9k2ai7dY7YxmoST9sOPbN81Z8aBZjjKwV5hntl6/jjShyM8NjDmQVV9KBm5zSrumEGD6FkKNcfx5OYjUyjdCtBEHgf8D3P4Mc6lLBNwe05IpQkPnSz8ATv8XZkb8ThPOYzHb2ulQ33tPavnEq9hC9qW0lsqmof6dn+9jVMA4O9LI6j/+datLffidMtM9iQcidYMrCh9cqPaKGAAL9Fyn7MKeiwM38Ttux24g3FQa62wINmp8hZTgCxMcqmg9tO2bAgcAHDaapWbqvHMWQ5Bi+LugklFsa8+GjAizLVijb2fCfHVlAHadKYGEsRBM91qEkqDJKImSh4ykoL0Zfue8xm8pRDNfeF/0TbwetZM7JQmdRU6nZhfXOpyLrCcia3WrdLywro8/eylTA7XOKp+pIaCyCFnyYIudlUgqGD9CevdQ9fDM8JaHW8S4b8LlfomBoAcelqgduSvjBqgq2NNr5CAbfzWNoIoE+dNCZ9WmGDgT5d+oAAq6U26KpAhhPHuRxyYGiOvEFnFkuqS60dZtRykkyQ0n0EX7ZW89JnQiKDI9vLlPVAe+DpBqojoJmhTv+wzLOAZIG7uInkAABDToN3sqx93uhxxef2+a/uu94T8mrSLv68+y+ZjWFBuU2jdZ6QLhGbDXDkLxoZ7yTjAosx56p0c3t2+nWGVZnZDQLfhGRgyvQMIgEsZpSV2d3oBk2jTj04Iho7OPG9K8N4XIJY4yTFhdHlat8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199018)(83380400001)(38100700002)(31696002)(36756003)(86362001)(2906002)(4744005)(41300700001)(5660300002)(186003)(26005)(316002)(6506007)(6512007)(2616005)(4326008)(8936002)(54906003)(66476007)(6486002)(8676002)(66556008)(478600001)(6916009)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjRBUUxXQ1pGdXNWZkQxTWxyY2duQXJ2a3BIV1RiQzZORkxGYzE4MktZNy9J?= =?utf-8?B?Zktydy85WW01UjR3TVhxR1cvN1N1MmFjeWdFSTV2UDlnQ3lySEtzditmWjRU?= =?utf-8?B?bjFKRmgxS3llZlJvelVVVXBJT2ZxZUEydVZGcUFWREJEQVRGNW9nWWwzRUdj?= =?utf-8?B?WWc3TkZqTHdZdUo0cjVRK2JaWkYxUWUxU0NOQUg5bnlWdU5JMFIra3FsejB1?= =?utf-8?B?Y0ZzdUVkc210MCtSVTUwb3ZqUWxxL0EwMkh3NGFIc3FvYlo3SVdFK3dKZGU0?= =?utf-8?B?SG9sOVQ3VURGSFFpRnJrUHZsR1UxUE9OWjYwZHRVMnBGbXMrcit0VDlNMGVE?= =?utf-8?B?TzNqRzA3SW92R2hRWU1IOE5BRjQySnowTDg0VVpON0ZUdWFFZ3lYT2V1Y0Vp?= =?utf-8?B?UU1QVVoxNno5dy94cmJMS0JibXBzU0kxKzhUN3k1dXpzKzhGVjNLQmVBbkR4?= =?utf-8?B?VlRtRnppUmNlUTVPNytyV0NzbEJpYzFPa3dtVzV5Z042cXpUcFRIVU5WMDdq?= =?utf-8?B?ZVg1bGFoQTBDUk03K2ZQMXRZVm1jakVSR01CZXJJRGdOV0J0TTJYaTJjOXVV?= =?utf-8?B?clZsWnBqUDNMUVVZcEtVNW5HQkNraEUyY0w0Tmd4b1k5WklaNjdtQ3ZaS0Z5?= =?utf-8?B?eGQwekhVWlI5ZlZJK0g1ZDR5RUt6U0J0NE9Ua21abHhnWE9DcVRWVTh3czJC?= =?utf-8?B?eHVzQ2FWa09nOVd0NktlSEJ3Y09wWm5tMVlRWmxWT0lGVHY3Vk10UlE0REVy?= =?utf-8?B?czdMZkJ2ZFBsdjRFc2hFQkdnUGF3VU5pQUp6TnpZQVBXSnlyMnV5M0kzSXRK?= =?utf-8?B?cnZVOGdpWFczWG9ka0hYaG9jTFlLcWJXYVR2OWxaVk9OdHVab1A5WE9sVTVU?= =?utf-8?B?MkMxcFBlRlBTa1JuWGhHNU1McmhuczAvY0orc3Z1QXY0RDZMRWRlTFRENUFW?= =?utf-8?B?TUlFQVIvSVNFYUl0eFlscEMzUGR1aU4rbTZJb1VVOEdhaDhLcjlqV3ZHdzNr?= =?utf-8?B?VFo0d1RmYVBhM0VrWFNXblVTZjFoblpEL0hSK1ozblZZc2RyNUd0WUNMb2pV?= =?utf-8?B?MkJnQVFubW5SZ3lkUTl6bUhoS20yWG5XVVp1dTZPczVhK29jcVZRWCthejl5?= =?utf-8?B?Zkp2KzlkS0JDQnZnelliYllEUXJCNExQQlVwc0Q2cit1SHY5Y2REUlcvRFdy?= =?utf-8?B?ekUrMitGaWhkMjhmMWxGK28xeWhVbHpoQ0tDa0o0THluWEVDUEtqQUEwdkNI?= =?utf-8?B?VE9ycnptQlEramlFRXU2SDM5QVFBQmJXQ0pwWXpZR2RFUENYUERLM0NFZFFJ?= =?utf-8?B?QW05akhrOHhzdXJtSzRjLzV2L1hUOWtEZytNTS9Ja0d1U3BvWFNIL2pMeVd4?= =?utf-8?B?STBvS3hIai9jUXVDZzZWbGdMck1CT0R0aTMyQ2JMYzgwdmVNNFpBZ05EV051?= =?utf-8?B?ZFJIQVFHOGhRaW4zaUo1SExYVkprblFXOUVPQktnN2lkdnorNEZyRXZqOWhx?= =?utf-8?B?VzJUOWNxSmY0eEdtQnJmY1pzUGYzWGd2TEFHWVlHT1JYK2FWaGdNNFBrK0hs?= =?utf-8?B?V0tMaVhiS2xNaENTRnRBUEJGOUNkSHlrRHhQLzhKZzJrL1RqWGtNNis5VFFX?= =?utf-8?B?Vyt0Ky93K2RTSE1lZzg5YitiMm43aXFGVlUra3Zva1RreEZNWjVOMFhyazRk?= =?utf-8?B?Z0l5NjBwVWsyOXU0OXpqMkhlRk45dGg3Y2VPVzFxUUJJV0xoc0l3Nkl5YlFu?= =?utf-8?B?MVg1VFhnYlhxQSs0bE44Z1E4MDdHb042UGR1Z1QrTzl5cEcwVHZKZGY2Zzlu?= =?utf-8?B?N01NRFB2am45VEFqVXliTUEwSDFpTWJXOHNPMTdoamRVeFNvUjdad1VML2V2?= =?utf-8?B?d2s4dklSMXJ1ZnV1VGpMeFdacXdCVE5NRFFjMVoyRFVUaGFWdXUyUmMzamJi?= =?utf-8?B?emZtNzBsVzMySXF6Slg4K1dHZDlqdzhhamo5RHBWamN3d2pwcS83cncrc1pq?= =?utf-8?B?NW02Q0tzaFllYTYyRHZLMU9ERGtzM3ZNWEordDdabmJ2U25KaWlRME51WlF4?= =?utf-8?B?NGNRdElMOGJ2NEViVUd0aWkxNGxJT2paSkZZUEhRSUU0WTA1c2I4VXZyYmFW?= =?utf-8?Q?oyad8hIRDfFx1f2n1DdQfZF/8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 855cfe64-e62a-44fd-dd33-08db14c08a74 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:35:39.4123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j7fCLw/l6BKDS4G3gfvmScl24vArzrHnYbF7zlRyTRLoksVa9blByQYWfT6yTWh6FmLOcLcRlTb/Iu9Sv84yuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8144 The attribute has no purpose here and, in the worst case, could lead to the compiler generating worse code. In practice, however: No change to generated code (surprisingly not even to generated debug info), at least with gcc12 and the .config-s I've tried. Requested-by: Andrew Cooper Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/msi.h +++ b/xen/arch/x86/include/asm/msi.h @@ -178,7 +178,7 @@ int msi_free_irq(struct msi_desc *entry) * MSI Defined Data Structures */ -struct __packed msg_data { +struct msg_data { uint32_t vector : 8; uint32_t delivery_mode : 3; /* 000b: FIXED | 001b: lowest prior */ uint32_t : 3; @@ -187,7 +187,7 @@ struct __packed msg_data { uint32_t : 16; }; -struct __packed msg_address { +struct msg_address { union { struct { uint32_t : 2; From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:41:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:41:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499357.770455 (Exim 4.92) (envelope-from ) id 1pUmYr-0004hB-JI; Wed, 22 Feb 2023 10:41:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499357.770455; Wed, 22 Feb 2023 10:41:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmYr-0004h4-FT; Wed, 22 Feb 2023 10:41:21 +0000 Received: by outflank-mailman (input) for mailman id 499357; Wed, 22 Feb 2023 10:41:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmYq-0004gu-6Q for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:41:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7e1a::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f5208c9-b29d-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 11:41:16 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7371.eurprd04.prod.outlook.com (2603:10a6:102:87::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 10:41:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 10:41:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f5208c9-b29d-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZCJbZ+nEBeYn6cB+G5/hEc1JMAhsI82W5MqxhxRsEiLkQx0Rlo4RM4faPJ68IPwn0h3sE8dPxtAj9YI33wuTcioKqM6E7nGxirKS+r2DgW1EW4V0HjY5GROWsIuAy2lXhoezyOhosnaryPfd7o4f2KOC5zvd4tADmgheSKLzQp4l/yjqUoRbbq+iS5jerAebk5tXTqnqwgTyPX0VC6yfEous2SFEw32YLfnEHZE3bTQX2MsUI/up47exXJb619gBCwLOVmo/TeDzXq5F84t6i7Yy1gvoIbzhUNUo5RtqR7bLpulJjKMgABrYz6J/AEoyi+ic0+2YHuG+JQ9gqMxGiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S898DbvOU8X/7qbqKlcl7oA6g86K8tEknAb8fcpc0rg=; b=SZq+/dhDUES+nNzuHWPzKFM3mKL4Egs+O3eVnXskHUVP8fvIsePfhHHCMJK2OD765RGiBacTmuGTeeWf/ymYQAjh5H1f8E3p2NepNFejrqYAQrNh47d5zpZksAYtT1cT6TSxO3vK9xfkKGZ/+ViHXa3OHrhUnUCvVntOZnIBKpFBcRuzPUwuq8jb6X3+QNshAlpoaIUNXoE3Wn3TrC+lnwlE1zCQqSsaiQBzqtDePBffPwef+gGNWuGl84W9UGOuVdQRKP/RroaFoT7ltEwETX3NJrtNGk17oMJTK530AVNskrwt39h324xe2Ga2AGqXwljC0mxZuWV9g0NDehtg4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S898DbvOU8X/7qbqKlcl7oA6g86K8tEknAb8fcpc0rg=; b=O4C5f6ESE8wdO/JaSpwWYcIvonFrKcfV94hhpn96irAZJcBDKp5YAuf5GXE9mt7epP7EJloV9/d2Gsw5+uQqOXTiX5+vMXxDnR8e1tm4oqpC5qoqUGP7f+jpm956pVLjS/4xjcpQbDnGbK7QS9Qobvnk+RTKbDTczsgeh2LNCFTXAzlkEcoRcx5iyREyj3RyLAk/vpx/wLY6vERurCbxaRaiY4T0V+rD/mwQQGEb4/A2/ouFEQbd1d9+OlLcu+fl08+TjorBYZmz2diFqZczYUFNq4uaPFqfvsXaca8wAraZXFH6YMd8DA4Xj/UL4A3RgM9cZSKfvsAw8Iobj+oMrg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2ae439fe-1294-f731-82d8-4e2f15e3de15@suse.com> Date: Wed, 22 Feb 2023 11:41:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/2] x86/ucode/AMD: late load the patch on every logical thread Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Sergey Dyasli , xen-devel@lists.xenproject.org References: <20230215153846.18582-1-sergey.dyasli@citrix.com> <20230215153846.18582-3-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: d63cd6a4-a62d-4ebf-4854-08db14c151f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a3S48iyRnjigJL0HL7AXmwYjCLoSHEmru0Vj+YzbR0JvuCUMXoNxyNTKo/ePC4akp2rtMJWEvqrSttbKVe1nMWiXTaamsyJUXqneKaSoUw9azdXEKnMgEcr5Lhp5Qm+CMIypVIhiDTWzmyJyzXiIlN5ZK6iE3iXsBFJZTw3n0iAa4j9huc+D2yfKhxfWGZadQ3t7kWOi5lFp9C3tQ0EIpWgFJCwf8RgDjP0b4Eio/D1MxgRI9r/og4gODL+sjfshH1FNcxY4zYf+bBhdxongPDQeuuQukqzdW4S3J0GlBNTlK86jjWVJyZ0r31AbMHksXMA1scRMXyX7oweKfFWPd5FlIjJpkevPYtHnmyCoqc2MzZjCSYbh4s/RTWNMexaX9Y5DIb8iWSZ5OPziids2zfs/E3VgegSUKS09+bqkWKSylbbfN1Swq7Z1dZfeclHhug77zviWLH/b8j+qlciOXIhJZ0AwP+v2KqXjrKdwd19aaT11GY6DnDwC1utShjvAk+ZLXN+bnV4MmYJ/4g4Jy7PqPCNJe11ZyhnWNcyfRHAx1/51S8LWc174fZws2EPzIvtyexWTKGThVEVSF3/FVpMC5v3XnhTX4YTxDefIPZg04qnCzjEW3hUQYR0VZHLvxL/Um+YWl+J4DqQ9ruavmc4XWsI0mFXqLSaOt90yGSF9wff46eZT+/kdhDmzlxD8h8/wqAU8VBgTPl2KzK04yoVRgALxsDArjbHhPxBY+10= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199018)(478600001)(316002)(31696002)(38100700002)(86362001)(2906002)(54906003)(41300700001)(36756003)(5660300002)(8936002)(4326008)(8676002)(66946007)(66556008)(66476007)(6916009)(31686004)(66899018)(26005)(186003)(6486002)(53546011)(6512007)(6506007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWxJSkhGc2dmTkFEZVJkVUg0SkZwQzVGWTN4a1JBL0pRV2xEU2VER01BSWVv?= =?utf-8?B?T3grVktQZG16OFREd2JqZ0JYYW9vWXNISmx5UXVZWStLNVlJbEh2RHdZbmV1?= =?utf-8?B?Q1AxSFd2cjdjeTlnSzhGMVNwU1JweVd2d0V0VEgzbzVWR2pkL3pGeS9yeU5L?= =?utf-8?B?QjI4eTJocDdBeHBCb29iVHRxWm1VN0hjQk5pOUxRWXZTUURZU29mQUlPYTVs?= =?utf-8?B?NnRHOXk4UEZwekpEQW40Q2FFT1EvanZRSW1ydktqd0wyd0VZMmZrUXZGNGdZ?= =?utf-8?B?SWVCOStFbzMyeWpxODFZWnVPaS9DbmtWcS8wQS9aazF4Si9GcmNRYjhHT1dJ?= =?utf-8?B?Z012aUdENFdjMDRoTHhhUkc1MitrTjUrUXpJNlp3Tk5IcEhzZUk0cEs2aUhj?= =?utf-8?B?T1FPVGIvcHdHVjdqOWUxUzVDS1R4RmszVW1vNFZob0tjQnNQTms4Skx6YUov?= =?utf-8?B?WEhoOG5ybVZoaGgxS3BxbjBSK0E3WHN4NDdvK0VBczBLcjZ2K3BxT2FGZVVV?= =?utf-8?B?V1c5M1JJajdpQlMzZjQ1L2JNc0VaWVVaZTFHMFkxVFBPOGJOeDZtN1BGUE5V?= =?utf-8?B?UUt6QXUzdmdDcHlkTHlBendac095ZzE2a0puVzNqUUtFK3ZjYkNzVWpzbEpL?= =?utf-8?B?VkdENjh5RWhsdDhLU2pLWFlkZUdTbG9sRHJOeHF3S0NKdGpzdGUvN1ZVQXdq?= =?utf-8?B?emgwZEJEY0ZHN2NyWjNRR1FSSTR5V0JlT3kwZGl3bDlkU1ZocTJMMExIazVr?= =?utf-8?B?d25pVVFURzhycnlhVUl3NS9LN2JpNVpLZFRlM3VPQis5L3hEVzVvN2lYUlFK?= =?utf-8?B?WWZiRURBTlE2cTJXc25uT2N3QkpYczcxL2dmOGxXZm8zcGtIK1hpS1c0SnR4?= =?utf-8?B?RWFaTjNDLzhPbHZWWmJ3NFRvdDJwemlaVTlPUkFJSDNFQmNSTEVzUVkxendJ?= =?utf-8?B?OUtVaHc0RmVQRUVHY3lQQlJrVktYclJ1dEF4YmhLZTYvSmptTGhkbjRCcVBp?= =?utf-8?B?em1GZUc1bU4wNDhSSGdyTndDaXA3TEtJVG5LS21XMVd2MndZMjFYdlo1b2cv?= =?utf-8?B?N2h6SEJvRXJzRm0zMUlQZFRUR3RWM2NxME04ODc0Nm96eWgvWXMyZWVkbXZi?= =?utf-8?B?YVU2bHdSZWtndTFtM1NwVUxZUFR6ZVFlSThiZ2tzMFpjNlJ3SlBPOHQ3cHpQ?= =?utf-8?B?Ky9IZEpUc1ZRKyt4bnBSeDVSNDlhMmtYTm1Sc3Ard3R3S2dlU3pnNmgvNDE1?= =?utf-8?B?UE92eGxiRExLczQ2ckpMY3FpVFljeFlib2FVYmFHK01kUzNyZEtLb2tDSUl6?= =?utf-8?B?Zjh1R05scWhwc2tBK0poSHJRSnUyNzdDMFRrcytyOEtWSnVDUENCeHBNV3Q3?= =?utf-8?B?Rit5TjJlalJoQnVYY2xSbkR5WndHaUFLUGxMUXJMQjhrMkp5ZDRtY0JVZUxl?= =?utf-8?B?TkJETFFERWZMcldIekEvMUZ5clVjdnpaMVVjTjdtSEhVaVNqdXdoelZ3Mi9n?= =?utf-8?B?aHAyTTVDVkRrdFNvdml4S1BUSGY5eW5Xa0JqSVlVS3BrTmh1R3F0NkFvbGdN?= =?utf-8?B?WnN3UXg0RW9XSkxqcXltQ3hYemVuUzRoRCtrSnduL1pvejlmUnoxaU5CVUZl?= =?utf-8?B?ck1Zb0lXdnMxWmV5VmJiSVRCMkV2NmhEOXJPK0lrWCthM3JFSUR3UkFKWFk5?= =?utf-8?B?N1V5OGh4WVdOVzd0S3JzaVEyb2JRZy9DaE5PMms3cHNscDBBb2poK2hjd3F6?= =?utf-8?B?ZmVpck5Sb0w3M3pCZFloUFR5MnJqZDd4aWVxUjIySWM5bGhwMVZRY2RwK0tZ?= =?utf-8?B?dTlMOVN4RWRwN2padldOYzNjV2JyaThpZFdLVVE5eDZwQjlmSGNNNG12OUlO?= =?utf-8?B?L2U3eFBhTFRNSXJyWXJ2cDVGYzNFd1diN0V3UDdNY0N3YUxTUTRhZWFZY1gx?= =?utf-8?B?TlZkZEVIdGtZSjlsVjNTeGp0blRITUpxOWVQdmMvRG4vWmtDbkphOGhMOS9q?= =?utf-8?B?eERkcVpjTUN5SmFLampTMHh5eEd4b29OMzczakZsRFBPUjd0SUtnM1hRNXRl?= =?utf-8?B?ZUdPd0pvd3pST3JiWitUQ256WjFLYlV3SzB4eFZnT1Bpc011akRweUt6ODRm?= =?utf-8?Q?OZY7o1lvbp6heMLRcgcEjlM7N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d63cd6a4-a62d-4ebf-4854-08db14c151f6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:41:14.0958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rNFbUyVVWOWn2vuUyUr1gWf9Hkx1jHkSZKXso4e6v2NERUhULbatGveBBkt8JM5W5qivwtz8J1ExSo1pvfpKIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7371 On 21.02.2023 22:26, Sergey Dyasli wrote: > On Tue, Feb 21, 2023 at 2:03 PM Jan Beulich wrote: >> >> On 15.02.2023 16:38, Sergey Dyasli wrote: >>> --- a/xen/arch/x86/cpu/microcode/core.c >>> +++ b/xen/arch/x86/cpu/microcode/core.c >>> @@ -398,10 +398,16 @@ static int cf_check microcode_nmi_callback( >>> (!ucode_in_nmi && cpu == primary) ) >>> return 0; >>> >>> - if ( cpu == primary ) >>> + if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) >> >> Given their origin, I'm pretty certain Hygon wants treating the same here >> and below. > > Hygon? ucode_ops is currently initialised only for Amd and Intel. Hmm, you're right, we still haven't sorted that aspect. I'm inclined to say though that adding Hygon in your changes right away reduces the burden later on. And it'll do no harm as long as early_microcode_init() isn't properly dealing with Hygon. > Speaking of which, I'm thinking about adding a new function > is_cpu_primary() there. This would make the core code much cleaner. > I'll see if I can make it work. Thanks - I was actually meaning to suggest something like that, realizing the potential improvement only after sending the earlier reply. Even just a static helper (without new hook) may already improve things. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:48:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:48:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499364.770466 (Exim 4.92) (envelope-from ) id 1pUmfJ-0005M0-Bs; Wed, 22 Feb 2023 10:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499364.770466; Wed, 22 Feb 2023 10:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmfJ-0005Lt-7K; Wed, 22 Feb 2023 10:48:01 +0000 Received: by outflank-mailman (input) for mailman id 499364; Wed, 22 Feb 2023 10:48:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmfH-0005Ln-T3 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:48:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ea99e88-b29e-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 11:47:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7194.eurprd04.prod.outlook.com (2603:10a6:10:127::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 10:47:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 10:47:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ea99e88-b29e-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZaH4onAMUPUthJOVZB7o6UW0ZmGn0ACyhnQ801pqsPYd2LLDWtQbymrpHZamkexYgjI6M4v4I7pBxaGeQH7PPmNUIMnHyWOXyAoP7F9UaG+bnR02dxE3bT7SgiQ9z8ewbyqZbNpmx6f/AVpbKK1KMlqOkbDr9KBTladIYEA94lFbMKgk+bCTksVJgQ8DdD6svN94WzNl//EqWh/8/gsd8nJ4n8zieF8QHzmKOGM7Rj0ics2IACUWGx65WNW2Haqs5PdorEH8Zy1WisIbuX16iL6XvKVFTuu/VPOYxzs8ve2nBj+URlMiwIws7GFWotpBpgEVQLELiCkxtxGucBtLcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=czLsrhaeSt88jH/RsPNV2z++4bWSQlkbq8CPkJbo8B8=; b=VG7p5CdNT6tBVIxuvVWU81NAOLSoW5ryr/mpbW88NVW4Vh4YgLyDJU/onsMvJxjhFrCmdYid/7K/4EbwPIbmzJQLdko+8xYd5kbNmgKnCWiqJP9vqq8mnCoLkbfdovWNX2b6ACr7XIxGTsOWzAuA1ow63fA74y9t0dQfH3A9ErM/iNsGTSJfCWDTlGiYHu9fTpUsBWHOv/a/lCLM9RrGzmo4f42CJ1s5GulhOw6fEWCSXFALtYkTZs/YbrFJai22xEYrzfsbrxEFw+vMdMR2ZElh7RJLPvXpyyqE7Ahw1URocuKCqOTZmvkI350vxu/vEWQpYxFA5Yl91+X5YJ8CTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=czLsrhaeSt88jH/RsPNV2z++4bWSQlkbq8CPkJbo8B8=; b=gro30kynY8tCMdzKmoX6CqPg95NxKBZ38rCCPRujMnnxMFJiOrZR9l4/kCjHrh5NfguNwGuBfreiuJT+UNyEKIRrQOudoQ3oq5ySWP6ak0nyrA1fNZcGs2NipJ7RLhnJZ34vEQOiTR46w4uZwh7vTp/kEB4O9GXkj16mANdhKBkhQNEniffI2ig188V7RHQKOKvKMiwnp798css6IdnlVtTBdCclKtNhEs2FBr0pSg6D26Gsqg4uUtaTDLo/HOQjgNF1Lxg7f5mdszJruYdfinz92Rz5kCx2ETFe8UC+ERX84aULdl0JELZtOs9RxLNVdw8ipKyhaoTI5m1M7sm4dQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3dc23c64-8058-c9a0-55e2-68f99a6235da@suse.com> Date: Wed, 22 Feb 2023 11:47:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <2692e97d-b3d6-6512-bff7-c13941c10cd4@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7194:EE_ X-MS-Office365-Filtering-Correlation-Id: e2fc1ee9-54e1-4c28-80ea-08db14c241b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZXclMZVgoKx5WCWDiu3ZyFhkfT6Z3Cdst8BV5m2FOOy5kSOP2cMuwqzy8Iv+Sk2oPDgsnbPQbj/sCBIN5P2TQGVoWPx9ZbKAZIX1nrphqWdGCktMV4Hlea3eLtSZ/v25UhsOjA3gTrpKfzcqRIhwSIhcjp8MQRq2BjI0VVs5cuoDFmnLybVhJXO9H6dNQ4pmCzr8pdIyadQ38OPYgh4CwMDf71fEsc64WixcWI4VTSE4ajKG6WCabEZJzNNHpR5p+QShqx2OnE3QYQoatV+1/wq3BPGka4F+gDfEHIRKDuVRFa9g68vlq2VYi6a5ONK9YUPLcNc7bFSSldXI1Lulb/mSENyr2g7/oVcbUy4PWleUYhx7OnxU/UID5hjRh+ir/793GyGfOcicYs1FZHnWrIp1C6dRaTyQJkICQw/Vt7oq0bKoeZWJsYzwnf1oHO9mhqKLTa2d+CdXUYVuI8jdD87KO+ictfv8tVX2cpV0d55/LZRGWrC8a2JScwYZuGtKpR08YH69dPLVz6IRoQ6ns5KI1aHKj/0R/3WQMy60yKSREAgS7ymgSZ52E1OgB7bJuWR3P1JNxMkJ6u7Z8bpRzc7fcEBb60fXk38oUm9nUOtMcy/Vx2mdD7rNuyXImTMlQD4pVO+IUi+WiCuVtonNf+1e1jQwj/91ppSz7d5rYjKbV+DBJKE84vFI9FoAuDC5t6cLedvYkdJV7CSYNQc+jtRg5AOYykLSzHNEkoCNz10= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199018)(31686004)(36756003)(41300700001)(2616005)(66476007)(53546011)(6512007)(8676002)(8936002)(186003)(26005)(66556008)(66946007)(6916009)(6506007)(4326008)(86362001)(31696002)(5660300002)(83380400001)(478600001)(6486002)(316002)(54906003)(2906002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHVvTjBGR2o1S1QwaVRUamU3UFh4RzV1WUNwcENUK1RoNnFSVU5PblBXK044?= =?utf-8?B?L2xUdmRtazgrOTRkMjJFZThKKzVkbWh3a1N0ZVRPdUNGdzZsbE4zWEw0d1dE?= =?utf-8?B?K0RxZFE1TUxIcHJHYmR0enRZUXRpSE81ZnFXRjRTL3hqN1E2SHErUUFOVmZ6?= =?utf-8?B?RnVVeVA4OThnZXpNTnNJSUFpc1ozVFIrV0tvK2F5Q3EyaEQ3ZGlyeFFlQk9H?= =?utf-8?B?Q3NDV0t1MEhzU0pPOEErV25FYi9RL09RMTRJRU00dkcvWGZKUVFvS2hQNTBL?= =?utf-8?B?VzIvTFhSMHJhZHFiL0VsL0pmNUl1Q2k3VzZlYTdPbVBSa3ljd2FqN1pNVWpR?= =?utf-8?B?bDdvaGIvUVpoeVRDbS9RSWx0S0ZybUxTS1JHSjFKOVRYTkJZYjlrYXhmSFcz?= =?utf-8?B?c0dOU0R1MFNiS043KzI0WDdsMllkU3cvLy9JRjVuQWxvWW1KcGlvUnlQZk14?= =?utf-8?B?d3B0eUgzUFI1aW9tWGE0QzNtMUJJZWhIZ0NWTnk3bjRONkR4V1VkYzMydzJG?= =?utf-8?B?UjRndjdXTWpIdmhiYmV0K1VuVW5vdlRiZjl6NUFCMnk0MnZXUzVhUXVaRTl0?= =?utf-8?B?Y2tkWjBtWHc2YitURXZkQ2F4Q2ZlaDB6bElyZzN6dUtmM05GaDhvTzZaTkNP?= =?utf-8?B?UFhkRVJTUVlSR0ozQ0t2MzJXU1NudFNBTnpVVFNzQzY0NlZ3Q1JmaFVIaFA4?= =?utf-8?B?Q3BTVHJ3NDRzYVlJaFVxd1VkWlkwUUdmU29YTHNtY2lUTHRVQzdpL2V4UHYx?= =?utf-8?B?OWQ1d20xUWVZR3RITHpqb0ZSNzh5MVgrMVNTcnJxTmZ4ZWR5VlZYSXVHT1o1?= =?utf-8?B?N3VIMUc5Tm1aWTlIMUxCOWJLN3ljZlFxaGdZbDVvL3VMaWVnMmFjcXc0d2Rm?= =?utf-8?B?akF0bVU5MjAyRDNCQXovS3owZklsZWgyVkp2dmlER0VrbVZQWGdweFQ3cTkv?= =?utf-8?B?V21QWHE3RWNRY3BTbzJianJzNTErb3VQazIxcWZMRDV6L3AwK0JFbTFqclQ5?= =?utf-8?B?YzJlUXBzcHhPa3NUeWJaeFZaVk9Gb1VzNUYrSEZuYSs2MmdJdVljcndGZTY4?= =?utf-8?B?S0QxMVlheEhyek90UVdKVlB2Um5rcWZsYXdpVWRzV28xTGRjbisweEhKWHhw?= =?utf-8?B?akd2eWJ2WHBoMlJaNUN2Q0JVRVBQTmgxYXNLUkJScWFRN0R6ZkViYndESkR5?= =?utf-8?B?L2E5TG1wclJlcy9DQ0VxNEozdVUxbnJKUUZnQUhlMHluYjcwbWpoVVl4eEdr?= =?utf-8?B?LzRQKzl5dnIxTnJDa2ZKdkFvVGtoUGNSNTNBQ2w5d0lEY0syUkRERDRweDlL?= =?utf-8?B?OXVhdjVueDZtdHFOelBJaHlJeGlONGdvUGc1RDZ4MFRYY0w2UElSWHdBRjNz?= =?utf-8?B?SE5pWW1GUVdOaG8vNTVHbmtUWWswL09ORnhGUVl0Y2dRTVVSbDdjSGY4ZTZs?= =?utf-8?B?bTlqTW9sbWRsTVczbi8zN3dZc2o3SDF2NzhWSnVOM2c5MXhpdnM0WWozZXNj?= =?utf-8?B?WHdjdHNqL0FXclQ2OWVydEtsT09sMkdlWXIyMzlaaUxGdm1jMEF1TW8wZEEz?= =?utf-8?B?VFpOOUlZUlhVZFFYNVAwaVh6NUJodHdFeTdIb3lhUlFrMVdwNkkzSWJqYUpF?= =?utf-8?B?QmQ5WXRvaEV0YmptaHhUa04vZFdSdjVZaHQ3MlhjUWQrdDNKU2hkbWRPK3ZY?= =?utf-8?B?T3ZsdHlxclhVV2VHb3hZYmxGeGlSM3hUWHp1clVoK21YOHlXVjRoS0RIQmNP?= =?utf-8?B?Rko2emFuT2FFMTBhTWcxYktCNzIyZWp3ZGQ2NnlnWVRMRGhJc3lqU1AvRHZO?= =?utf-8?B?T2pJZTlOditiSDM5dDFCejlPdjN0dVRhd2g5Vm1qWVRSS3hSWmMxVnJKa2ky?= =?utf-8?B?d2Q2aC9RQ1FEcjIwaitHL3ZtMmJOT0NDVzBVNThUTHZiV3lWL0pqSDZTQUtE?= =?utf-8?B?eGpmbW4yb3Bsd3JpV0cyUGJhb0h5WE1VaGI3dG5LVndMYWlYZ0dHZ2pVMXl3?= =?utf-8?B?amY2WG1CV1k3ZmFzeVpTNndVaGNwU3lLS2ZpOUpnYWdBU0xLRTJHMGtrUVFv?= =?utf-8?B?WHdsRmVsalVqcWF1RkF6SFo4N1BZa2I5U1B6RlpwME52S20wbGVGU0ZteTV0?= =?utf-8?Q?rLgWceAz7MWrG13zjT8QCRjw/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2fc1ee9-54e1-4c28-80ea-08db14c241b9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:47:56.4131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QzKOCkoko6NHMlxgwM+OfQyHSIxxeJllxPZs6LiqtPCgx0r3rKwMtFC7Ps2L6a34DpkGjQE3F4zEEYW0xxtSeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7194 On 21.02.2023 16:59, Tamas K Lengyel wrote: > On Tue, Feb 21, 2023 at 8:54 AM Jan Beulich wrote: >> >> On 15.02.2023 18:07, Tamas K Lengyel wrote: >>> An assert failure has been observed in p2m_teardown when performing vm >>> forking and then destroying the forked VM (p2m-basic.c:173). The assert >>> checks whether the domain's shared pages counter is 0. According to the >>> patch that originally added the assert (7bedbbb5c31) the p2m_teardown >>> should only happen after mem_sharing already relinquished all shared > pages. >>> >>> In this patch we flip the order in which relinquish ops are called to > avoid >>> tripping the assert. >>> >>> Signed-off-by: Tamas K Lengyel >>> Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool > preemptively") >> >> Especially considering the backporting requirement I'm disappointed to >> find that you haven't extended the description to explain why this >> heavier code churn is to be preferred over an adjustment to the offending >> assertion. As said in reply to v1 - I'm willing to accept arguments >> towards this being better, but I need to know those arguments. > > The assert change as you proposed is hard to understand and will be thus > harder to maintain. Conceptually sharing being torn down makes sense to > happen before paging is torn down. This is (perhaps) the crucial thing to say. Whereas ... > Considering that's how it has been > before the unfortunate regression I'm fixing here I don't think more > justification is needed. ... I disagree here - that's _not_ how it has been before: paging_teardown() has always been called first. The regression was with how much of teardown is performed from there vs at the final stage of domain cleanup. I'd be fine adding the "Conceptually ..." sentence to the description when committing, of course provided you agree. > The code-churn is minimal anyway. Perspectives here may vary. Plus, as said, being the one to backport this eventually, the larger the code change (even if pure movement), the larger the chance of there being a conflict somewhere. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 10:59:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 10:59:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499373.770477 (Exim 4.92) (envelope-from ) id 1pUmq8-0007Ni-Gp; Wed, 22 Feb 2023 10:59:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499373.770477; Wed, 22 Feb 2023 10:59:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmq8-0007Nb-Dy; Wed, 22 Feb 2023 10:59:12 +0000 Received: by outflank-mailman (input) for mailman id 499373; Wed, 22 Feb 2023 10:59:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUmq7-0007NB-A8 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 10:59:11 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee13628d-b29f-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 11:59:09 +0100 (CET) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2023 05:59:03 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB5955.namprd03.prod.outlook.com (2603:10b6:610:e2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 10:59:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Wed, 22 Feb 2023 10:59:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee13628d-b29f-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677063549; h=message-id:date:from:subject:to:references:in-reply-to: content-transfer-encoding:mime-version; bh=fWrwGLXSV94IBKjjRx+qKvN1iL1SNb7Kxwu+Tw0JdaY=; b=BC6g8Nlnav4e5xskSu2IxPrAIoyudxTCmzJDOsi90DjKy/ww6dZhB54g hjiUIHYDzLYbDKbKVQ9AbVBwJO175Ca4CE4fnWoFZUopkVUxEBVECPUe8 9txCy445K6m5AZSdY/ZBk/aKPBY3AYdvEKX7DH41ni/jZCfFe2LgTl9St g=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 96879014 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:dfhymqgMXDlee9uLGptorJUlX161bREKZh0ujC45NGQN5FlHY01je htvWDuCP/6Ia2rzfI0jPN+z8UJSu5DWzNdrTwFtrChnFy4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWEzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQaCiAnTwupqtmt3auBatswi/pyFerkadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RePoqa8y2QH7Kmo7UxEbaHbmvvmAgV+aQJFAN mc7oXEQhP1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/ lqAntesCTkxtrSQECiZ7u3N82L0PjUJJ2gfYyNCVREC/9TovIA0iFTIU8pnF6m2yNbyHFkc3 gy3kcT3vJ1L5eZj6klx1Qmvb+6EznQRcjMI2w== IronPort-HdrOrdr: A9a23:r47B8KpuimtsiAJC30AUCKkaV5o6eYIsimQD101hICG9E/b0qy nKpp9w6faaskdzZJheo6HjBEDtex3hHP1OjbX5X43DYOCOggLBEGgI1+TfKlPbehEW/9QtsJ tdTw== X-IronPort-AV: E=Sophos;i="5.97,318,1669093200"; d="scan'208";a="96879014" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQcpWvMSSF+8IuuciPAVrlQmixZlz9r4AioMgp9O4hN9NMP+rbvWaZzRr8rHanbPpcprXPTsmRhIuqPKZneV0lor9c/K8uPEDEmvWcSKzOWVbQ+2qzdGbyrSfbdiqENi5Y0L0P7Q6ya9Csg1U93fACcmAexZpr5iXdH600JZRvGNIsNrrSC8jLWsjZPoElsP4rH0yWDv6pe3wmWSrQ479H7snZbsa89vupXq/IIApO4LVbSe6RCaCRmYu1yjjilWhZJW1SRUkebjwF1uMb9QaGOIVr/GjMmSdV14dZIKXzTRV7QXWiO/vj9e8s9hRe2FOm/W5HczxRTvHwFiVCUoag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWrwGLXSV94IBKjjRx+qKvN1iL1SNb7Kxwu+Tw0JdaY=; b=jb41zyGN/lUdF950x5vFUiny8CSd7drcbuh7rT34QKNYxxuXcJQVVQjGmIf4AKwYdZ2BK58jdjmIqTMti3G8FfnR+H7gv8fY8Q81/7sdiNXnula8DyqVaK/mf7jJTVuKD45aOEmsp8YT2FUe1H2dYrzeyEc69wHS/v3/E4ZaYrD8m9S4Oclv3LLeJLpgo6NilF8fgNrOUnjw4EoiRWJDm+FPBQkiBgUqYUL0TdQkkxV88sI/YVqes9ERbqh3qJYPFcBFTvhXnpuXDw7a0yD6EeVB9uehGL8n/u1evFS4+CFE5yD/csM7a5yXg7Hftq8TnTao/QhJK8qzogwYjzVyQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWrwGLXSV94IBKjjRx+qKvN1iL1SNb7Kxwu+Tw0JdaY=; b=trNqTFU080sBLdBRZKb06L/e2biOLOwPF45A536y6ws4+U2Ma4JseAc/krKray5/p6wXayG573tt7MPiJZiW1Vl9C1ePKXr2koGlAb5nPvYSBxUw7W3bUcpPcMB9mkTXcbTqWWhcspCyq6ZT1q7Yy80dQDWEN+8k6OLZf41Ex44= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 22 Feb 2023 10:58:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/MSI: drop "packed" attribute from message data/address structures Content-Language: en-GB To: xen-devel@lists.xenproject.org References: <7c362963-e6c0-f610-3bae-9465dc91a73b@suse.com> In-Reply-To: <7c362963-e6c0-f610-3bae-9465dc91a73b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0035.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB5955:EE_ X-MS-Office365-Filtering-Correlation-Id: 04dcacdf-7f7d-47fc-637c-08db14c3cdfa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zDvI/Snrx+YFoWGLOlR7E5sL43YopGQ9Ay3uES7OBrCDU3xT7GKEYj4th0zNaw/86VDMnMOinMUQvgmbrNG08J3ZAmZBjO4OEkr3ucsAmNLTdfjD70Wh6qo4TqTo7em9OFi9VTaaAKiwEJSNaqe7zEPK0v4VD9JN828hWWxHf+bHx1u1wIef9fcvYx8SIIxJhdvTuuDA05Om0+8soTe1axSGgKEiuCnNbYWFdex+SMxYY73efRB4nR6GkTe5naIieG9pQgzccersAH6dTzwBKpZfxskGXvC6tgqQWkge/6jePPwEsYcUTV2agjt9vZdx6pD3LyE6+H1eCl9ccz5QK6ALD/ibFcwV8r+llmeK/iYtNbZnpEK3N6p/quR4oqbI+czH/+UPWjx29ZucwtsKLTeHwytZTxTyFb2/30EJz+/lY0i2KXyca1wQtOECDUQuhjQukeM41H8l21sSUuQJzZzPfU/Q7T8QP6y50BSH2709Kbqc2xXC/0B9Dm+5kuqBZVv2kVeLn4xEN3aZOoVX8+JNls/ZrC3A0bOKCvlCdyZCPh1pJDR6qGg9g67glrLaMHOsaibmwFb10ZB91sx+9pdbXqxUxSy/AJLWOAcjpK3M8pBpOEfgcSjlHjsPHWKXEBP5tH0ukBAEnM2/YA5Ny/gNAjy1tM8ODGUoRMcy/+O7fmb2Q3tYREyHHHTDcLyrDM+5Y68Kdpx922/4zXiaEwElnr19J3Lxm5L2xzUrYD8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(451199018)(36756003)(316002)(83380400001)(6486002)(6506007)(4744005)(478600001)(6666004)(53546011)(2616005)(26005)(186003)(41300700001)(6512007)(2906002)(86362001)(8936002)(31696002)(5660300002)(6916009)(66556008)(66476007)(82960400001)(38100700002)(8676002)(66946007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0pLM2FOVllMcm5jYnQweVJOV0kvTGdaemI1WC9WV3c1cjNVRnhNSGRpVTZv?= =?utf-8?B?RjBEUWdkeVViVU1TSndYY2pwSHJFUzVIVG9tYVlEaDVxdjJSZVVCckxKMmJt?= =?utf-8?B?QXBwUUs5andScEY1N09VTFp3a0dqNStRSnB1cXZPN3dzakZWeFJCMm9NNnEy?= =?utf-8?B?cVNRMXRkTW9PZVlXOWtUdnJIWGxLSktteCtkOVJvTmt2LzlOb0hPRW1mS2hG?= =?utf-8?B?VE4xcDhHR3lNSXN1ZjFLckNSMzBwTmJIOWRiQ1RYMDNIeUs1RkhzN2tNdHdn?= =?utf-8?B?aWI2cm9GdlUrbDlBT0RoY2Z0L3poaXBzSEJabWtBdVdJRVJRTlZYQXpLZUJi?= =?utf-8?B?dFF1Q3liNzVrMUpjb2xIY2ZaRFV4UTlaakkreDJNV2I3VVlBUUVzdDFXNWMz?= =?utf-8?B?NjJJb2dZZFJCb3N0Q2dwb2NkRWV1NTlEVXVBSDI1a2N1V09NYjVRVmg0a0do?= =?utf-8?B?WXREKytDbXIvdjRJUG8xeHkwd2N0SUx1OUZRdkNZaGdQblFZSHlUWUhzcjZF?= =?utf-8?B?bTBrR3IrL2tBaWc0RHN0UTkwaUJjcFYxeU4vNUZpS3c4NVpHV1hzTExZV2JE?= =?utf-8?B?VGxlSmVhWkRoeG5pNngxRDdwUmhVSEF0OGg5OUxCSlN1MlVTRU1id1dONmR6?= =?utf-8?B?NFVqVzBDK1BmTHN6MEpibkErUnI3SE83MEd2QndjMGRtczBCZXJZeHF2RHNp?= =?utf-8?B?U3B3Qzg3eGVWN1orSGlSdkhNanNrTnNCZ0dFelhyQzRZTG5BaFZ5OXJvN1l1?= =?utf-8?B?b0hjSzg3RzUvY0NpaE01Q0NweU5sZlFmVk5HUzBIUkRjaUkvN0lOZ0I0TEdZ?= =?utf-8?B?MWUrb3FiYktOeWdvWE9oSGJWMGx6Rk92Uk9hMWpHUTByRCtmamNuZXliaGVm?= =?utf-8?B?RXdlb1hEc202V3BKanR5MlB4WFUvTUZwV3dEYnFEY3dhVCtCcWNRejdnOG1z?= =?utf-8?B?YW1UR1RXQUFBOUJ4RE9VaE1XeGN6OGxFSVhTUThzdjlHV0syTGkwdnZGczJP?= =?utf-8?B?TXI1dkNrZ1lKTkdiUnJXem9yZmpmYjh0NUc3RW4zNVNta1A5d2p4ZHdSWjhB?= =?utf-8?B?M1NOaEN0cHVjOWt1VFE1QVRpaWwyVEdvMnU3K0w1RlNKb1NKYSs5U0MwcFNt?= =?utf-8?B?cjVqeTJpa3VJeHExZENoREFzOFdweWV4a1g4MjlIYmtnU1prRksvc3V5M1Fa?= =?utf-8?B?S3RjZG1qdkRlZ3NPcVJkZVU3cFYrTTdRcmdmZVN0Tno0ZHNQVDRJLzY5Y2oz?= =?utf-8?B?RkJTU0FkWExzdkVLRmVZM053bERLaXN2aTRiQ1kzVm1PT1RhVWY4dnpOTldS?= =?utf-8?B?djhyQmxleGtEWXp0eGlwbUhuVm9TMzJYMWlKZjc4VGdKWnpVdS9leDVIdTdv?= =?utf-8?B?dEZ6cThueWJSQTNJOGovMXlnUUxLc0IyWk9KbWtGd1VWYVF1UUI1TUVVNjZ4?= =?utf-8?B?ZFJlYTV5WDJIOUFqbi9jTkEyMzhjSkVwdmJKeWQrd1JsdThRdTJxTjZDTjRp?= =?utf-8?B?VFBmUUh5QkVjcUh5bi9OaGhDWHlYMkVuNmc5NlpCaHNBM1l4SEoxYkE5Szgr?= =?utf-8?B?T2oxSmdVYWQxbVhyNVRpaktzbi84RE1WQVQrYjJzaWdSVWM3MVZ2bHhBSUdn?= =?utf-8?B?eU5MaGQ4VUZCUk1BTEgvaHkvSm0yWFBuOWpWVEJNa0l1R2RUdFV5c1Roekox?= =?utf-8?B?MDNNUHVMaTJ5b2g2UjVjUDIxQXBSR1Z4b0E2bllSaHRYN0N3SiticGM4RzJI?= =?utf-8?B?bTc4cktqZUZHV3VmV21tMTdZNDF5ZDRtVnZFOFFwNnBoMFFXRmk4UEl6Y0Jq?= =?utf-8?B?b2lYdHM2dFFUa3IrbkwvSmZ5VFU0QWQ4c3pSUnlHZkJzb2VJQ3FMNkh6UXl1?= =?utf-8?B?cmxsZVJXQytwaDFkQ1dsNkIyc0lnK0xsY0E1YnpydlZmTXZtZzl6REhaUkIw?= =?utf-8?B?S0NTT2xUemFmNkQwNm16UjVLMU9IVmdQRXpaOEV2Y09mRUEwTDZZYzZqbTZJ?= =?utf-8?B?am5SOGNUQ1B4VlN5MmxIZk5wbXhUaWZjOHJ4RUg1aGhsbzVDSDlVZU01VW5k?= =?utf-8?B?TDA3NDZOeG1DZWdzaURTb1pkV3V0L0krRkMyYVJaNUl6aitxR2I0RmhuUDZn?= =?utf-8?B?L0ozNWM2azc2YjNKS0g0M3BTNC9BSTBGN1NDSHhzeWQrcTlGVmsvZ3UvaDQx?= =?utf-8?B?RFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zwF1DLsGXO+VdXsGLj1CahHDtVYzLpeXsl94LKecnOmUyIDX+PcFIEbaVAsRv2KIKec0qRLVdPFma/Rpu9f4nMmSWU1zH3Ry74XLMx9yZv+Atz/4JeujFlumk2c2BEbEym1fR8YrTKmcYo+SWrq8wqttAYPEeP3yZ93OuY+Pd5z45SLqNePB/4nyds8jOjhRIiPUBk4msxxwxe28LydVmVf60kjheHPtdHBV8ccuo8boTd016ouHdp2IruM73lvnSjhkf2Zkdn9X3L++2xYo6WOfOpelhgPhXKa3GOvTjhHSzskuzIeHlNuC6ncuOJDRsez66pT4fRI+sE1Ychd6w1dgkpjsCCqBE5adIc5bplaDdoU1wg6SJ/ZSQ0XZjkxF9WnAkkNOFcMbVdCSAQCr5nB5V/4d73AH8VGGQA1Z0rCj5uNZUBCs8ziHSXkq5QgX/xXkK8ms8PA6scsvo/muZ3BCE9wew5xYyOuAgRZyfJqLkSMzpa3zvRF4t5ovygISFWNxY7A2QCC4mjlvfoDBLN5skGPt35IJOCA2Ehuj1lLdDYDMyahAiN6cEqAWDAnuuwc+0DVZUODRLPIr3yObRowzi67ia1RGF/JVu3g9bMhEKJScVlQBnHIDZyXc1R+DrXw7SCp7QWoFsfl9RCyrdcsh0HxGvX12QeZU4DXAPXW2WOacWFlf5JYlPPIviAaFsJlMkDvAYN/IHyL02nXQlKg4bWz2AVqnpWwHl13eNGFymQJjFKBlpSQp+2sHo1Fo0luxEXvkVt2y53+m23PyEQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04dcacdf-7f7d-47fc-637c-08db14c3cdfa X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 10:59:01.2942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1XC5nTZsHJ1XH8kvuJ64PLjuOpZwGZWdNytobSYj8Ml7ZMpqDjyWtJ1bv0pz3xrXOJgCDs7k3PCc6Jg8llQvZB2IsQe/VIIvNBXB9/SnDuY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5955 On 22/02/2023 10:35 am, Jan Beulich wrote: > The attribute has no purpose here and, in the worst case, could lead to > the compiler generating worse code. In practice, however: No change to > generated code (surprisingly not even to generated debug info), at least > with gcc12 and the .config-s I've tried. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Feb 22 11:15:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 11:15:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499382.770488 (Exim 4.92) (envelope-from ) id 1pUn6D-0001gA-UD; Wed, 22 Feb 2023 11:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499382.770488; Wed, 22 Feb 2023 11:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUn6D-0001g2-RN; Wed, 22 Feb 2023 11:15:49 +0000 Received: by outflank-mailman (input) for mailman id 499382; Wed, 22 Feb 2023 11:15:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUn6B-0001fV-VE for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 11:15:48 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f6f2032-b2a2-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 12:15:45 +0100 (CET) Received: from mail-dm3nam02lp2046.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2023 06:15:42 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5048.namprd03.prod.outlook.com (2603:10b6:a03:1e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 11:15:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Wed, 22 Feb 2023 11:15:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f6f2032-b2a2-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677064545; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=sh1wpwHdxbDyGh9SykDiS26j5kbKk2jniYlLAR4RauU=; b=MJ1HYdMLThZ5RL+0nxaSnwvqgNKS3nDcuIH9sE5QcRtUbUbztN0Wfk5P LUgxaKTAVoanmJeer38vfZSInC3/jYi4kKA8m2BacBCgHdiBwZhsDzLlP xbnaNDZI91KNqfjM5uaIgMr4cqazRO39I9iPK6qgM/mDxZPaeeQ69qCFr o=; X-IronPort-RemoteIP: 104.47.56.46 X-IronPort-MID: 98459504 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:L/0H9a9Lw69G+TydWFpvDrUDo3+TJUtcMsCJ2f8bNWPcYEJGY0x3z WAcD2iHbqyKY2TyeN93YNnn8EgA6JDdy9BkSFM+pSo8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oR5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklVt sI5eSgtSimAvMz18ZGiU85FhugKeZyD0IM34hmMzBn/JNN+G9XvZv6P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilAvuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCN5PReDgqpaGhnWU624ULRgqVWKirNKitGL5YNdzB m0br39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A79y4pog21kjLVow7TPDzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:Y985CqpWkg7QUrdKz8XkoRIaV5v5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssRAb6La90cy7LU80mqQFhbX5UY3SPjUO21HYT72Kj7GSugEIcheWnoEytZ uIG5IOcOEYZmIK6voSjjPIdurI9OP3i5xAyN2uvEtFfEVPUeVN/g15AgGUHglfQxRHP4MwEN 656tBcrzStVHwLZoDjb0N1KtTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S zukhD/5I+kr/anoyWspVP73tBzop/M29FDDMuDhow8LSjtsB+hYMBbV7iLrFkO0Z+SAAJBqr jxiiZlG/42x2Laf2mzrxeo8RLnyiwS53jrzkLdqWf/oOTiLQhKQfZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIbRd3jUC5yEBS2tL7t0YvHLf2VYUh5LD3vXklZqvoJRiKn7zPxd MeRP01555tACynhj7izyVSKeeXLwgO9ye9MzU/U/OuokJrdVBCvjolLZ8k7wc9HdQGOu1529 g= X-IronPort-AV: E=Sophos;i="5.97,318,1669093200"; d="scan'208";a="98459504" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxnIxDqrhlGrzG4L4e6Z06aCE0VlkujtoS1mF7YARIf5/YjUK1SJefJ0b35yQ0Ena2u5KuflVl01lXRCCN/QrnbYpCnJvZz8wwyJZWmreQf5Yu+CZVQme/2OpxIK+3RUWrjMq+ANV19iP61hLggWIHkO6Iim2Rxf7SwY26viDUzCkK91C6Cxi0iR6y3GwepEdgOFK/YLDiPLKlZ9PXtITOlMzrmMfn/+v00RB+UNQS6geGUf5my6/95AjnKEZ/X7yvcVoIPyIFIaLsrjHhZxwVei7BZp9YuNpdjhrkxFCzw2QXPFsq5xJ73Im17HejRCciszEb8A/niltiNp/Ay6uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sh1wpwHdxbDyGh9SykDiS26j5kbKk2jniYlLAR4RauU=; b=LTSXyzspmmXeaIjSWFC4ovBnCRjUkzIOhqZbvYcTd/G+nUZYZS6NFgZDj2SAtK6jS+Shuf+PbF19efxwvXCaiASNrmbP20fQAkgE3HzIGVTPM18wfQZEqZileiO8DcnS69i3p7puUNhuvs5SLijCoqTWnscYMlXRS0u9CO33yjNJ6c3/1s1jNXda3dwTCMAcRot8U+4OMXlRbHZOm5zuTtSF4euDBNdyfPeusGE4tzqci6I64lzYaE/JOAvq2Vjsbc/pEo2KDJYuF/tW0m/HXGUCJ4pNSbFJZaRQFBcdI6+oeTgjWsSh8+L1lDJiu0PVyNSnegQId0B44NdNHWOMlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sh1wpwHdxbDyGh9SykDiS26j5kbKk2jniYlLAR4RauU=; b=S1UETaq3Z6NuZTDCF+4PSGyvq+KtTfjmYkTxcK72ryZn3MUDJ9vWE2J219ryU+fqWKa9wXrfNR/KxY427o1JP1nQRr2zGbhGP64UxzeHN6529cYyvnVXLzZ6KazS7687T8XYOvAswjwF8KGNHVZhpbwwCfDjf3KXm072QGmbIDA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 22 Feb 2023 11:15:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/extable: hide use of negative offset from array start Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <359b8d70-0a97-8a52-fca4-4f6b7621d58c@suse.com> In-Reply-To: <359b8d70-0a97-8a52-fca4-4f6b7621d58c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0307.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5048:EE_ X-MS-Office365-Filtering-Correlation-Id: d1782fc5-46d8-471c-32a0-08db14c62160 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zqvkKqwS5qg1St5RVPY2KQ3ouLdWBM0GTirfft1Ezkcoh2fzi6bj65V6F8pXKFFoe6SYuddgubdEv7GNrxCVRZorRDj550FDQQyqfWRfstjfOpe1nmAFeE6cZPGqtifNZcyNbdCwFQLl24UKRcsj2ZmK78Me5QDDOBxV7zxqDecmXrJbKTVpWZu06a9KM6xFVKZ0uqsnmWV6ieRfIkLydVrjDioOHhk2tpZVbEQPMfIydS7A1dskXIeTjZ73jbTVcSnMdmw8xDSNYHIbPlK0+CoFyf1FQhnbkVvPoNElBYf5vitY8OmQ9vkBu9Tb1fPt9mJq9TQSj2jMalDo1lN4SDVzIzIYdNSNOIFp5+G7h9qEEJfP1H8Zme9ex+sp61CdOP5EQurUB7CeJn5ZXgOYikzQ9KQBIt0oTaiP2of3eYUFRN3X7jHJ5IAG2N591jGrK380zYwXUy0rSoeJ9ThMRJUjJiSDjv//ZJKH7Hm6u9zfqL7pcR7xJPm077QE7OtxzPT5f9mYYMwqZ9u0CiGkw+V4W7xyEeu6bCs7XMMuYGXSUyoe6fqAhi9060Lb8wQQQ2l55ZjSRU2xemsMih63ZLrwagp5a1NZ5XjYd4iIEDSdlYCwkii+nG0tWM1aL8TLLY0pywW+f7hy9muj9CGUuFHrYPwLEeA5cSCJobLVXvjAWHLBbyxZBhKiJKPR/bNBFjkaU+FE023nRrgyzvWUzWLzxBdDM/9IcbLyJh5rimk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199018)(316002)(26005)(186003)(6512007)(53546011)(41300700001)(8676002)(66556008)(66476007)(66946007)(4326008)(6486002)(54906003)(6506007)(31696002)(478600001)(110136005)(86362001)(6666004)(107886003)(2906002)(36756003)(83380400001)(38100700002)(8936002)(2616005)(5660300002)(82960400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VURxWmorTE1DbENWekhVOEhBb0tsWWR5eHV0NURNMnJqSUlmVnRvNi93VGlH?= =?utf-8?B?ZStIU1Z3Q05qMUJtOSsvc1ArZmI3d2NjMVFCL0p0bUQ4ZlkyOUlaTUl1SDJ2?= =?utf-8?B?L2dYeGR4eWJXSXZtQ0RpRS9RQ3ZlUmxDdlNYYWRXWHZ6anNYMytiN1k1UVl4?= =?utf-8?B?MVpwMEFaVER6MFY3dG9YMmRKMHlRTFh2TXFJM29DaEd4OGV2NW5YQjBaQXVh?= =?utf-8?B?T2lhYzRKdUhML1ArRlNoU2NUU1lzMWt2QzJtQzdZU0xpcWlreXBTQW9OUFZo?= =?utf-8?B?MFNCQjNIRlY5aVlaN3pzamgrSHozd2d1UlU2NDJ0MGZINFhtZ2xDbi9Cemw2?= =?utf-8?B?SWpBT05BT2RXNkdDcjh2TnBYaXZ6TG05L1pxM1h2TTBTNlBrM3dBaE8yYzYw?= =?utf-8?B?VjJvZXEyNEhWT2dNa0ZnenFMOG1raGpRMkdhbjJRaFhtVXd0dVV1Mk9QSVhB?= =?utf-8?B?dHBlb1M5YlBrWXRtN0FHdmx2bjFQR0xkemZuU2xMNU5TWVdoUkdJWEdVSjZR?= =?utf-8?B?bmQ1WTY0c3huTzFPSmVsakhDeXlnd1h1SktlTzdzZnN3SXcyblhaRXQ2akNR?= =?utf-8?B?bHlrcmF0bHE1TVRjUkU0UE9tS0VCRVh6YmFMUVBHOEo2OEZ4dXhLUFN6bk4r?= =?utf-8?B?azZtUElkMUErdkV1MFhneUc4bUpOcllFaFpDK3FERndzNjdMNHRwTmdnYzJl?= =?utf-8?B?RTN3WXFxR1V1QkRheVFtZ0lEV3lWdnZOaXBvSjdpTnkrcEE2eFhTNDRFeXF5?= =?utf-8?B?S2xyNWNnNFRjblVpZmNpNzY4OUt6S004Z3B0RlZCNGMyQWlVdWIzb2hoWGV5?= =?utf-8?B?WkUvZUlYVklBN3czNTQwYzgxRDR6LzF2cEs3ZlUvTDFMZzhQTzRRODdaNExr?= =?utf-8?B?OGtSVGR5d2tOTU9Fa0FTNGM2Nk01NlcwandxVEtESloveHR5aFA4WlJCT0VE?= =?utf-8?B?blQ2Uk5lRHdjUmZEeHhueFptZlRFU3VXcWVGMUZmSUIyQlZoS0hrZzQxbW1S?= =?utf-8?B?VENqbTV3YStYalJ4MFplRzd1dStVM0ZtZEVyQ1RJMDhqSGlqY3F0V0lPUUJw?= =?utf-8?B?OXQxODVoRldKcEVsU3pXbnRnazY4RnZ0eXFjRXU4cTg0NmYva1ozUmpiM1pQ?= =?utf-8?B?SVdMeVFCcFNLUllVRlNFb3dGSThEeEpjZWRZRmZmV0pnSVFDdzVraHhhRjhF?= =?utf-8?B?SDB0RW4ySzMyVllNN2xrcmJUM3BkcnhKYUJqVkU3aW9PN1YrNDNZKzEyckZj?= =?utf-8?B?aUZiTGJIMGI0dXAvaG5tcEJWaEVScEJPbHZ4eDFhVjFINWo5SzZvYmF4QVNZ?= =?utf-8?B?YnhIcHJVZk5hQTVMZVhRUG9qaElHcmZNT05ORCttWWEwbmVJekorbzY3eDls?= =?utf-8?B?R2toODZtOWpuMlVVcTFFc3d3dTVUUzFCWVVIUy9sK1BiV1FCVFU1aDAzbjBV?= =?utf-8?B?S3Bpa2hieklnd0hjVHVkSW5sYTdTSy9WSy9DOWF1YzNBbDZaN2xudGRkbVZy?= =?utf-8?B?ZkdWWHkzeEpNZU1XMGZLOXpPdHJsYloyd3N6eXRzdjAwbWVhSWFzOFpId1hp?= =?utf-8?B?aDdETnk3U0N5bnBQaGwwdzBoWGVVamtqOHlMMEpQRHplV1g4QVU1bjhkdThJ?= =?utf-8?B?NTQ1Rld5c1JDa3JvaHVHQ3JjZi8zaWc0NFo5SUMzczkvUDNTUWZqMjVKWnhF?= =?utf-8?B?MHNNWEFxRHU0YzhIZHNpUnlaMGdNOGRFZngxQTRJaGI1VzE1WTkyaDdMcEFD?= =?utf-8?B?cWs3STd5WjN3UGZWRE9XTnp5TnBlRXNyb3hvOVpuNFc5eUNxQ2F2anhzdXZj?= =?utf-8?B?d3RGTERGSEROYWJHOW5lbDI0b2tLdDYxV2pOQjlkc3Bva25IUXhkUXRESEZn?= =?utf-8?B?eHk2Qk1hRmE4ZlVWd1AxMjBqc2kyNzlLcWJza1dEb0ppVlBuMkRpL3FPMEFl?= =?utf-8?B?d1RXbUdFZ1R0a0c3REF1VDJON2pRYTVhNzRHNFRnWUJ1eFU4dWdVaVBIUjhJ?= =?utf-8?B?UHg4YkQxTVR1U2liZkswYmYrV0lseFZ6S3pUejVhc2lsTUFyeWlVYUZGQnF4?= =?utf-8?B?eWUxazFpeHBWWVd4TFhzN1RkSHlTdTR0dzk1VFBheThHU2R5R1FpR21VWDJv?= =?utf-8?B?bWM2c21xVDhOc1FJa3ROam5FZFlidXZmZ2w3bjNPUFBtRVhDTmJwRU5yelNu?= =?utf-8?B?akE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5WaRLXyAT3CHaxWY9fqYwzWtP3SQqF0oblRMwTIp0lqDYX0Zo5RQLfd5dn/GVHyU3C8pE8CAjwYVqRfCPld5NricOSiJWs4m3+2SN00+cZN+mYM4JFLiqzjaDCkZAmMK0jFrfwfYRv3lqucwWbsqzLkqrIFtK1QMfWUk1Ty5D6B3FcybPrrShLO/fHl0jhCiEL7NXJNq+whjNWhjKk1Alkpcrtxxn5LrpotVwfgGq9C76/VgUXfX4+2Hm6I+cYOsYLY87XCatcGFgzxZx2xUgIop3+wmlU5+1eYAGGt99IdES42Z6wukN5lfoWcRxNiQjkdozYFTFA0+2z3LWkKQ/VWzRTlhfIbx4UIkxBNumFioGN/cW2FWnMgF+/9FClKfPG62j8OFD1eHN7CHZmpmiuTstPXJoQwqerdRlznGFjTYnoqJbYtodIgy+EmsQKraI55tZ+VS0UsaUzlnUScIkRLkUI0VrKx2W1sharLa98x8SsuPx7hKDW0XzR+m8rgkIsZ3sanYc7VpLj7geppCbPzNqYxaAea9oc/rEiIrSAnl3L+i/Hp097WyaUMMcwkif4Fhb01/ApIhnA/2kZf5hJ9sVY7wAI3f3XM5IX5aUwGTJiH5tO2qPybwmWLrQ+j6wrTVVDIi2HJwCS0BRZPMa51mY6cQtTFO/a3Cmsi79OABoOCDeXCGX2KkoJSY9z9Pfhr8Nl1qjVwgKPlINmmijtN8eRRWgfnPbztWWvKf3IFZ/KKLydFBRVhD2UXVp5YzA6kYFgPCM1UGkVHLwN6l8y43j1w/fRq0RqtjUK7Kv+k1+0EXI88+WdBuuybgzzod5PyeYlUKYZiEGxVhbgI5kw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1782fc5-46d8-471c-32a0-08db14c62160 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 11:15:40.1433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Jc28apq47cVWzndqgHzbjRC1MmfdVLMMf875jVRuck16ZXu9jEs5RL9RDlJt+h3Gtxmr8ZuCqHYvHtvFicP/sMvdqacwmAn5x97C6jC4hs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5048 On 22/02/2023 10:22 am, Jan Beulich wrote: > In COVERAGE=y but DEBUG=n builds (observed by randconfig testing) gcc12 > takes issue with the subtraction of 1 from __stop___pre_ex_table[], > considering this an out of bounds access. Not being able to know that > the symbol actually marks the end of an array, the compiler is kind of > right with this diagnosis. Move the subtraction into the function. > > Reported-by: Anthony PERARD > Signed-off-by: Jan Beulich > --- > To keep things simple, I'm merely calculating "last" as a local variable > now, rather than replacing its uses by suitable ones of "end". In the > longer run it may become necessary to actually go this 2nd step, as in > principle the compiler could inline the function and then still spot the > same issue. However, while the subtraction of 1 can likely be avoided by > suitable other adjustments, "last - first" cannot easily be. Yet that's > also an offense, in that it's calculating the difference between pointers > into distinct objects. All of these bugs are ultimately because gcc doesn't know that these two labels are the bounds of a single array, and not separate objects. There is no possible at all to get rid of the "last - first" calculation - this is a binary search through an array.  But it's also not going to actually stop working, because this is the common (and documented) way of getting linker symbols into C. For the patch, Acked-by: Andrew Cooper   but if it were me, I'd have gone one step further and made search_one_extable() into a more normal looking binary search. From xen-devel-bounces@lists.xenproject.org Wed Feb 22 11:26:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 11:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499388.770499 (Exim 4.92) (envelope-from ) id 1pUnGU-0003Pc-UG; Wed, 22 Feb 2023 11:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499388.770499; Wed, 22 Feb 2023 11:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnGU-0003PV-RB; Wed, 22 Feb 2023 11:26:26 +0000 Received: by outflank-mailman (input) for mailman id 499388; Wed, 22 Feb 2023 11:26:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnGT-0003PP-2Y for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 11:26:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7d00::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc46f800-b2a3-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 12:26:23 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8879.eurprd04.prod.outlook.com (2603:10a6:102:20e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 11:26:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 11:26:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc46f800-b2a3-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FOrmsWLKpyDOWPA162jOWemtnmWjtnEXMXHRTVytwKcHomSEN6vxR7nVZ7t/UwwuO4HSOyyIznTSR1BplBM5WAZuK5NxtDAgH1UtEea0porhtmOHDCi1qZuqmxQO1dqEKjiPwwJ8ndY/0Rydmz8rnBOYtFVPM+a+cswt1hBkZaaYd6I4khrYe/QxQmfB/bx2+XLkbD0BkfNv/OtDncZH7tYgcZGT+Ijoflha3XzmEq1O4+M8JhWQ+HttQG/TZy/pbfG7befML2G2+ZsWog2TO9ugyWEf0DUEn+/5F+MV9Zbr/GSdUWRbl2HAlTayzGIwL3nU3qB1L7zFSncw4IL1YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGdPVvN+6sqr0QWyGpmV++DEXd8f/B8hU1wxly5arKM=; b=EHYEJV+7H224dOLEU0oP0rBmwSgwjBv6Ged6aMqp+5us6/H05zREPo17yoLfFQC4mZcDr9XWeujyZX21XF/xHEPzlqOlusNc45WNA0000wtLXV0hOoUDOB4+5nD5Xdax9LzBBmc2GxBYGLHaxvUX/OaOzoae0c0Dl4WlZ2HBSjpikePobfgZZ6QbBURZAvO0j01DU80/jqflGUtR/QFzmYXuFFm/OrvOneA0y3h2hs5taQgvrrhenHo3Rkkm9HsROvRIdkHqjqjvBB1TN1eD1TCEKQxrGCLjG86ABfiXEBAGt+IpRNXSbnQ8R4o4ru/DEwi6+99eV6CH2v80X5aItA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nGdPVvN+6sqr0QWyGpmV++DEXd8f/B8hU1wxly5arKM=; b=roSxhoNAzWauAefiq1Z1Z9xKdtHVQXjDoET0JwiGsM8zhF1dMkCCmHBeKPKqRZvGGuOg9pq6nKoTNSaYRCQrxlw65mOoSo44Y4h/ddAB5duVemgaiAI2ak/CbFJ8sqh4LfuTmI5ckD/KNDx/Utbez1klGoAttrOZJnqd6Q15MA6DOLqqWGGg+pcfvZ2168H48cdbj3I/HzhudAw5VbdZdMHw8mu3amcSszqFuiXfZXzgJw9WLIXU1cE9yuK4N9w2hdL1GpqljCHsCxESoB9S8geKXmeXjPPVJ9rV3X0G2NJyVb6ZtTEJO3zPPpvHEd7H/5/vRjzvuhx1eW+R/ytk1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <54af6801-6a43-e1cc-46ad-bc37302ea460@suse.com> Date: Wed, 22 Feb 2023 12:26:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] x86/extable: hide use of negative offset from array start Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <359b8d70-0a97-8a52-fca4-4f6b7621d58c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8879:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c8c6b6b-c528-41b4-168c-08db14c79f54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rdrAGDhJczaMCfCJPEhwDqrqPlZtwCS+Wuj/rI/qhfKmril7FglnETfvknlCDX9/0OJ+E6QkVCeSK9+vxIh5srVshz/DmVow44Aczl0sW41h7LdOmE0czoaMJk8+Es93Ssq3GPrkqfz8BvpnVbszrX+xgXoG/o35Flx1DnJ+gwDZeFoBXyR2ld8lD9Mu6RQoEIn4YM496XQqKMbu5IjYMCJmXP/QJ3we0e7bufkNPljDUrG1zFk+XdxTCGimUesNMcDFe5nWdiXEee7xaa43jUl+iwCQG9Yp9OdWCRg0XF8fCyLWgCtGtxfezO3kkiKgC2cofCn4iFrGrNcOkpmCaET6q/yICX/Y/VHDkH9cNN/ajmYcShs7l3rKIDMPRdwQoY54nCKz1lCPG4Xy+x/MLAbWCObthuBpVFvci0dW84IOsSDronDhX6MB4PzqT+NGu6dzPFz+KUrB2mdpilrGljALTTqP1u/pUl4hH2ur5j/Tp4kB7b1yJ2m1NXijPpYs/iTTRsKg/VevsTEY/da6Sa/WMpjuAoecyU8ejHdsHDYiUf/EKYHIlYtXQXxjwiF8kyY7/z/1q8g5mkPR91gWCpE/UNUNcXhaH7XX970zw/KvD6xneCBsw1VbjOG438Ps5BUOMecI/pFlQufSfBCIYLrOomWsN/L+L0VDctDfZux7Lh33CnyBB8Ap5iNbExPiXAOjBT/zZbRNPudnbgTUJbZwzqgckE+iDFJIgrWFxio= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(136003)(376002)(396003)(346002)(451199018)(31686004)(83380400001)(36756003)(2906002)(5660300002)(53546011)(54906003)(6486002)(31696002)(86362001)(6512007)(478600001)(8936002)(41300700001)(38100700002)(2616005)(26005)(186003)(6506007)(66476007)(316002)(8676002)(6916009)(66556008)(66946007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWcxTjNMcmg1Nzh6dVpnUGtvQ2d0RFRUVThSNVAwWExPOFhSNHZPZ2dDeUdu?= =?utf-8?B?ekZ6SUMyK09QZWN0MllUVzBMYzZnT0Y3emNLYkFXcTdXNUplQXk5Wlk3eGs1?= =?utf-8?B?KytJUFhCOWpvVTk5czl6ODNaSHdSNitCMDE2RDBOVVp5amd3SStKZUhOcXpR?= =?utf-8?B?UlVDeW05OUc2dnMxNk1CSllxekVWbUhGZ1orNzZ0TGJvNzBIbXdqZk9GZUpN?= =?utf-8?B?RUdxaGRCM3NmZWdwRTdjQ1ZLMjJsWWQyeGVwazR4RjZWMkp3TUxWa0VPWk5r?= =?utf-8?B?NlRZakxuc1VRa2hnT0oyUXFQeWJ6TWhETkZCNmhraGJMZDJSZTZQNDZLRVQ4?= =?utf-8?B?V2hXcFh0VnR0ZEtlcTJFRFVUTElEbkRmRzlNRnprZTZ3NmJRamlKL1NhMHhs?= =?utf-8?B?Y0JuZU01V3gxcTlHL09rRUM5b1RoYVRVZXE2QmRLQUl5NGpJZmJBcFB2d1pZ?= =?utf-8?B?Z1djRmxpWTFicTgzeWt4SVBYS1RiVnZPVjViaXVGOGxVMTY5aEhZTEFEekZa?= =?utf-8?B?ajV5N1pJRlQvZUZYZGxkZVEyV3NQRTlOck1oRjduZmtLVHNmcGoyMmkzMjZX?= =?utf-8?B?bzFUSFczRUhsT1NFSXY3eHFPaEpvZ2pkZnNQcjRLcHY2clZQSUdCNmFUQjV5?= =?utf-8?B?MGNrQkxSSnFUS0VqZ29kMTg2cFkvK3FHUks1UGo3TSttSzdjTE5pNWRKZmpJ?= =?utf-8?B?NlVhQ0dBdFNwaVNwMEdYNWlheUdkWndNdG9DQkp4RjB4SmtoOSs0TDlENit5?= =?utf-8?B?RFcvVmlORnVBeWF5UDAzTE9GUkhrWVF1dlZHenBwNkZMZDhCK3pGenJKRElN?= =?utf-8?B?Ykl3OG9qWUc1cFZyRkFoaTNJcnk4MUthakRFU3BSZUtwNDk3bC90RUhFTDZu?= =?utf-8?B?SHZkcCtVRWc0d01tMzFpTXFQbTVlZm5jZWFsUDY0cWpNbnN4N0ZOWG9NMkF4?= =?utf-8?B?NUpzNndXZ0lNTUIweW1ZRlRwazUzU2JFc0c1V2N6cy81c1JydUhVNzk2WHhP?= =?utf-8?B?Zi9GakZKTitWS3IyTjgreDNGNS9iekhoUnVvK0ZQR00rV0tqdDU0RmRyaWhN?= =?utf-8?B?L3p5OU9iYm5QMEZ1UktBZnN3cTNPRzhxVnNpRzZJSDV6Y3hRQTRIVHdkYTQv?= =?utf-8?B?bWVvMURPcWZmU3pQeWUwaVY5NUN3cFJlVUxia0FmakE0clJNeStsQWthSXJT?= =?utf-8?B?Tk40N1lWQXUxaXFzam1HclRDbjZWQWFWcHFWeUVlM1Q4OUdPWFQ2SytMUEVo?= =?utf-8?B?aVNDb1lpTUV0cjNnQVJFSHZ6OHhQWG1ISk1ZTWlwQkZOakF6VGNqRGNLbDFi?= =?utf-8?B?eEpoNmQ4SmtlRlNEdHRGb0VYVzJMUFFMcUU4Z1BKdHAyTUZRRmdwSE14dlJs?= =?utf-8?B?N1lRNkMvRFFQQktVNEtpd1RwZnBrUTA0TXFDYkxNSFJXTHRWOGY1bHVZQkJj?= =?utf-8?B?VDJvOE5HZ1NoSGsxK2h2L09jMkNueFRtc2VzVEtORXRGQXZDMVB2THRMYk5C?= =?utf-8?B?b0VtMStFSHcyQTYzc1JTV1pwS2RwK2FmZGcySVRFV042UUtnVUxkTTFBbjVQ?= =?utf-8?B?bVpNMU0rSWJzd1pxeFpYUHRPWFh2aEwwckpIQnRRVytkTS9CSlBqWHNKWmFT?= =?utf-8?B?YTZHRTFNSW1aTy9oZVY2dmNVOXNNc0RmOHFNRzIzR0JLZUE3ZFNZUk40Y2Ju?= =?utf-8?B?Z3ZzZnZTY2RneUY4blRyYS9MT3JtUHphdyt6QjdpKzl6Qzd0aml4ZEFlQkpl?= =?utf-8?B?ZnhGM3FHYjMyaFlDRTNDalh1RTVVbUJ2NFpJWGMxSDJLQnRQV0lCNzU0U2FF?= =?utf-8?B?eDFiZWFLVEhtR2tIMXVZN1lSdG55YmxlTWM1d1RJNVUwMXFTY0VGcXVZUk9h?= =?utf-8?B?Rnc0eUN2STNsdXNPM2JiMGFLaEpGLzhLUFVOcDNWeERJYkdRRFNjNVpmL2hQ?= =?utf-8?B?T0JRazFZZ2E1WHJUbFJUWHMzV1NGbmZLamhIdFkvY3JSZXhlYUJNK3Z2VGpu?= =?utf-8?B?WXBsRlVxQlJpVlI3eW5qSzlacFZJclRTajI0V3BMcXhBcXVCYnhROWc5WW1V?= =?utf-8?B?OE1aV0V4VlFsM1MyOHJQYTF5TUUxTVFDTjRjUnV5enRxVHpkdGZWU2pQbzRi?= =?utf-8?Q?32X+BXiLoRG4BpGWOqkM6+TS4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c8c6b6b-c528-41b4-168c-08db14c79f54 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 11:26:20.8598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6WzecOdsKY62Say6MhaxB6ttSSD/LmjQbG0OodtBgWEc+FLaG1nJ29YnN7aQT+AtlV2OmxlnhO/cIT855paPkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8879 On 22.02.2023 12:15, Andrew Cooper wrote: > On 22/02/2023 10:22 am, Jan Beulich wrote: >> In COVERAGE=y but DEBUG=n builds (observed by randconfig testing) gcc12 >> takes issue with the subtraction of 1 from __stop___pre_ex_table[], >> considering this an out of bounds access. Not being able to know that >> the symbol actually marks the end of an array, the compiler is kind of >> right with this diagnosis. Move the subtraction into the function. >> >> Reported-by: Anthony PERARD >> Signed-off-by: Jan Beulich >> --- >> To keep things simple, I'm merely calculating "last" as a local variable >> now, rather than replacing its uses by suitable ones of "end". In the >> longer run it may become necessary to actually go this 2nd step, as in >> principle the compiler could inline the function and then still spot the >> same issue. However, while the subtraction of 1 can likely be avoided by >> suitable other adjustments, "last - first" cannot easily be. Yet that's >> also an offense, in that it's calculating the difference between pointers >> into distinct objects. > > All of these bugs are ultimately because gcc doesn't know that these two > labels are the bounds of a single array, and not separate objects. > > There is no possible at all to get rid of the "last - first" calculation > - this is a binary search through an array.  But it's also not going to > actually stop working, because this is the common (and documented) way > of getting linker symbols into C. I disagree with the "impossible" aspect: Rather than surfacing start/end symbols, a start/size pair would eliminate all such concerns. Recall my attempt to make use of .startof. and .sizeof. assembly operators, which sadly Clang doesn't support? (These aren't properly usable here, because there's no separate .extable section in the final binary, so the remark is merely to support the point I'm trying to make.) I'm also unsure of that supposedly documented way actually covering symbols at the end of objects. If that really was meant to be like that, then why would Misra make an issue of it? > For the patch, Acked-by: Andrew Cooper   but Thanks. > if it were me, I'd have gone one step further and made > search_one_extable() into a more normal looking binary search. Well, I kind of inferred that from your reply on the original thread, but I have to admit that it's not really clear to me why things would end up "more normal looking" if the upper bound is exclusive rather than inclusive. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499397.770521 (Exim 4.92) (envelope-from ) id 1pUnnX-0000V6-Vr; Wed, 22 Feb 2023 12:00:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499397.770521; Wed, 22 Feb 2023 12:00:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnX-0000Uz-St; Wed, 22 Feb 2023 12:00:35 +0000 Received: by outflank-mailman (input) for mailman id 499397; Wed, 22 Feb 2023 12:00:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnW-0000FF-Fu for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:34 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82e0f6a4-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:34 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id b12so29314480edd.4 for ; Wed, 22 Feb 2023 04:00:34 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82e0f6a4-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=doY9xB02Xms2D/8hQa289Ytj+RDMjA/uK7oMTVWbZgo=; b=U01QLToEtjBNMZh9WqRp9v+HSVHnkWs+YwojM6x6vSUy6QnYLBIaUFYT6/TpGwGKD2 F7bifHF+YvytZcMjjsv2loVKnPQHL1jFrRC4zN7eWGfDyJRL30yzBFmJ3S7pybshAAye 65TbBN6PMQ1G+vBKN8q6+2VQ7hI6BaTLSND0sGiI1OSBKlqq1kHY9GkdiiveDQnErCmw 4HUyZ506GrbMIKSyMj8J8FpqXL7eZ/r3ow6pMJiK1CqqD5rl5nSjcSs133F7KSEpHee4 6WIZB6iL5wju/lTCdcn+50FtVEXcT7LvezOjLdgKmF+pbZiO/WPFVdMfkQ7G1Xmc9aDg GmwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=doY9xB02Xms2D/8hQa289Ytj+RDMjA/uK7oMTVWbZgo=; b=7mZYGS4XKwjQjFA7Zkuz4OqfNWf1v5wnKSdSlTBHlp9BsqfRuqpikGheETc8Zc0Dss v4zUaMN9kBGDpkf7pOwsT9oAAvuVj6po/GimlOid5f7WiB5HEaxj7fYfUL/SfMHLZrgG j4kHkA4HyqtC+zkuMfW3u4J+uKlEBxBtOnDoJ1XczHc3817yie6oZnJW1VHxKXx8PtQA DJ8QEqJs7DKeylx5wmASFYRYY4PylhAliMkPTwuLUXc8UURemQGzOQeD+cp69knysPCX J8qZjgkIoJ596ILwPjX6Kjpk5xAplCiItDnid/rXhNsVdbhNFdKMZTYesqkiLdBuCoTA mviQ== X-Gm-Message-State: AO0yUKX+mHHwWwtTZX0x9Qj0JOqG/NXz0fBaktvMFBKeI7qqN3vLVX5q +fd04BBncOnorLT45UP7xfQeH8XClgc= X-Google-Smtp-Source: AK7set9bqpqNZCoEv9JQGLkQyFa19l0Q5ZONZVxe7iSweBiYxtsg1iScHoerVH7dvrHpSHxmAUhmVg== X-Received: by 2002:a17:906:f0d1:b0:8b1:3009:536b with SMTP id dk17-20020a170906f0d100b008b13009536bmr14613232ejb.29.1677067233378; Wed, 22 Feb 2023 04:00:33 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 2/9] x86/svm: opencode SVM_PAUSE{FILTER,THRESH}_INIT Date: Wed, 22 Feb 2023 14:00:16 +0200 Message-Id: <20230222120023.3004624-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Delete the macros SVM_PAUSE{FILTER,THRESH}_INIT from svm.h and opencode their values, since they are used in a single place and using macros is just unnecessary obfuscation. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - opencode instead of moving the macros in vmcs.c, suggested by Andrew xen/arch/x86/hvm/svm/vmcb.c | 4 ++-- xen/arch/x86/include/asm/hvm/svm/svm.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 305d4767e3..ba93375e87 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -169,11 +169,11 @@ static int construct_vmcb(struct vcpu *v) if ( cpu_has_pause_filter ) { - vmcb->_pause_filter_count = SVM_PAUSEFILTER_INIT; + vmcb->_pause_filter_count = 4000; vmcb->_general1_intercepts |= GENERAL1_INTERCEPT_PAUSE; if ( cpu_has_pause_thresh ) - vmcb->_pause_filter_thresh = SVM_PAUSETHRESH_INIT; + vmcb->_pause_filter_thresh = 1000; } /* diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index fa39d4d76a..c62d0caa32 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -95,9 +95,6 @@ extern u32 svm_feature_flags; #define cpu_has_svm_sss cpu_has_svm_feature(SVM_FEATURE_SSS) #define cpu_has_svm_spec_ctrl cpu_has_svm_feature(SVM_FEATURE_SPEC_CTRL) -#define SVM_PAUSEFILTER_INIT 4000 -#define SVM_PAUSETHRESH_INIT 1000 - /* TSC rate */ #define DEFAULT_TSC_RATIO 0x0000000100000000ULL #define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499398.770533 (Exim 4.92) (envelope-from ) id 1pUnnZ-0000kf-8k; Wed, 22 Feb 2023 12:00:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499398.770533; Wed, 22 Feb 2023 12:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnZ-0000kX-32; Wed, 22 Feb 2023 12:00:37 +0000 Received: by outflank-mailman (input) for mailman id 499398; Wed, 22 Feb 2023 12:00:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnY-0000Rg-1U for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:36 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81d0e24f-b2a8-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 13:00:32 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id b12so29314066edd.4 for ; Wed, 22 Feb 2023 04:00:32 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81d0e24f-b2a8-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3N3piCiGWBTq0LmBNA8fpZwNDzK/IZkQT7MxXOAi4Ls=; b=cYDsEaf7/te6v2zDN6IZBxWjfuyyDdqGG4sQ9zaJas4CNh5Gk6qUBaT6M6QNPDSuI4 2dC9qQD0Jzyt3PJRXmItZj7lwxskarHK+cSJvsj7mAZCSuI25DENgApLwztENg62pTAs PQ0xjWoEvJUXLpsR2u6uz5NmfLkRy5B8RYyMkEqMgj922RI0q9mREW+ANql2Apy1ZVak NbYkXVLuak60fJiNYclhEvD3f+mGOmpR+g+8M3tN6bPsM1qnfUAJ2Pioutsj7MhhjLY1 05c+9aq+D0cWC3jUCWnOT0GdLUztO3tjlJGhw0FunEcfDgF69bXaQoOqmLuqgfySTGCN 8b6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3N3piCiGWBTq0LmBNA8fpZwNDzK/IZkQT7MxXOAi4Ls=; b=blARJ6eisRSgHtxjxOgwnaPsoI0YXCHHJAkyNQjlcc7YFhLD1dvcji38908lyqyF7m fBr0LCIsrSGAWGLfZzeDVdJYlrjYdnDNj0WBhml+SMF890mPcpu2KVe6AoncY4jfbTv7 Kcx3wIgVjKyVPG3di/iVt08PtnS8TnhTbZRTB0IH5Xll6yJwAPghXUqUgsszDOaPaIMn EC09qMowOLxb0y80Ghti4pqb+42a3Lale6aVaFxth3ZNiPbcO7WZTBWn21Pg+6mn+Ar0 p+r7Wo0UX4kz2fT/VNoie1fbp/DrK/OpnTGm9rl99d0YYULRF1ZEEzhs2mJ7lA/ZFdU2 TUGQ== X-Gm-Message-State: AO0yUKXOoC9jaLtIofOsPUy1MJuNaDuebTvsGWZO6GR7PmQFIiESqpiL Njw/F0i8WKn7PWyBKUPmGYIyD5VIA1k= X-Google-Smtp-Source: AK7set+b72Vu/wbcA1IfmKn1TWGG7/7r4g7qVI595O8rmfN6pyzv8OpoHyY52kM6bA3bcvxK5auL2w== X-Received: by 2002:a17:906:805a:b0:873:1b57:b27f with SMTP id x26-20020a170906805a00b008731b57b27fmr14555060ejw.61.1677067231533; Wed, 22 Feb 2023 04:00:31 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 1/9] x86/svm: remove unused forward declaration of struct vcpu from svm.h Date: Wed, 22 Feb 2023 14:00:15 +0200 Message-Id: <20230222120023.3004624-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove forward declaration of struct vcpu, that is a leftover since the removal of svm_update_guest_cr()'s declaration from svm.h. Signed-off-by: Xenia Ragiadakou Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") --- Changes in v2: - leave the forward declaration of struct cpu_user_regs in place, suggested by Andrew - add a fixes tag based on Andrew's comment - update commit message xen/arch/x86/include/asm/hvm/svm/svm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index 65e35a4f59..fa39d4d76a 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -46,7 +46,6 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) } struct cpu_user_regs; -struct vcpu; unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499399.770537 (Exim 4.92) (envelope-from ) id 1pUnnZ-0000np-JB; Wed, 22 Feb 2023 12:00:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499399.770537; Wed, 22 Feb 2023 12:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnZ-0000mK-BX; Wed, 22 Feb 2023 12:00:37 +0000 Received: by outflank-mailman (input) for mailman id 499399; Wed, 22 Feb 2023 12:00:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnY-0000FF-6p for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:36 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83df4187-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:35 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id x10so28531088edd.13 for ; Wed, 22 Feb 2023 04:00:35 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83df4187-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=58ojOoNDnWoUZmyiyDiKwllMRC7EMTKC77s0cYAKiQs=; b=XgUEknz8X7C+j8NC9vaUD5dfDiMVudUsOd4Dl75Mpy42/lrlJCoY5c/bn8HRXZCN/A UCYPo5Fn59qpVit5vVufPupjkBxLg+MxTc1Db1xXZv8uwf8Cg87r7/3mv4HHHXvUur2w 2Aj/uXmAoIxis2bMeiq1Mr6J8ERfSqIXMtEh5plPrWqZBbiL/y69UrO7cyBe7Of65vEb 6wIM3A/Qa7g3hppbQSjz6AXQo4DUDxb0uRmEul/x8l1O8mhH9dfqdWz0S8O96ohjTw/s SW6syULDQ09JTTgISRgDhI/9/a9aJsyBEBC0Z3s+8iLQVrF/7Z4x1yWlNYY7ot4yv2FW IjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=58ojOoNDnWoUZmyiyDiKwllMRC7EMTKC77s0cYAKiQs=; b=19tRrjMjPJrOUEivZlwWMz3QimWnmyrT2v6CJTRg0bl1rqhPtB0b2hgIsJrcfz5s+b 6k5WGym7c0/7JLkPwEYvPdTbWKS688y8RerZGotX1ebolBczUfatxm8tefWQw6afopGY g8BcFWRxMze6dnCv4Y9Diajz72D17l1QZoHKbNkSYLmdtvu5uPls2Sa15t4w5nEOiJbl /djQoWmqOyVJllcu3XOr1KTX3LjrblLeY7wZH3clvowQ2InPucZCKjcu3j8yktxEMjgf YcV74HAqaqrWjaggS8/yJJhnqrCHCXbHKw/0BWPj6tg4CynuaiYdPC/T4n48Xxo/Bxh2 EzGw== X-Gm-Message-State: AO0yUKVnZbWiOStjTq6FYMg3XmfjPvpIJ/cmbs1AwWazJBCJrvNj53aq RK5t3pkNesR40Dw11+bR/AIEXbt8ziw= X-Google-Smtp-Source: AK7set+BMqvFT3yhEj6etKOZAcECpL3SSt3qrQjDUEFp/IysmDyOAD68iIW0dXQxo+QCz7UiqCGVuA== X-Received: by 2002:a17:907:d50c:b0:896:427b:148 with SMTP id wb12-20020a170907d50c00b00896427b0148mr15722125ejc.1.1677067235052; Wed, 22 Feb 2023 04:00:35 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 3/9] x86/svm: move declarations used only by svm code from svm.h to private header Date: Wed, 22 Feb 2023 14:00:17 +0200 Message-Id: <20230222120023.3004624-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/svm called svm.h and move there all definitions and declarations that are used solely by svm code. The function svm_invlpga() stays in arch/x86/hvm/svm/svm.h because it is used by arch/x86/hvm/svm/asid.h. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - new patch, the creation of a private header was suggested by Andrew and Jan I have not added #ifndef guards as it is a private and it should not be included by other headers. However, this is considered a MISRA-C violation ... I 'm not sure what to do. xen/arch/x86/hvm/svm/nestedsvm.c | 1 + xen/arch/x86/hvm/svm/svm.c | 2 ++ xen/arch/x86/hvm/svm/svm.h | 40 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/svm/svm.h | 29 ------------------- 4 files changed, 43 insertions(+), 29 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/svm.h diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 77f7547360..a341ccc876 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -27,6 +27,7 @@ #include /* for local_event_delivery_(en|dis)able */ #include /* p2m_get_pagetable, p2m_get_nestedp2m */ +#include "svm.h" #define NSVM_ERROR_VVMCB 1 #define NSVM_ERROR_VMENTRY 2 diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 9c43227b76..6d394e4fe3 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -55,6 +55,8 @@ #include +#include "svm.h" + void noreturn svm_asm_do_resume(void); u32 svm_feature_flags; diff --git a/xen/arch/x86/hvm/svm/svm.h b/xen/arch/x86/hvm/svm/svm.h new file mode 100644 index 0000000000..b2ec293078 --- /dev/null +++ b/xen/arch/x86/hvm/svm/svm.h @@ -0,0 +1,40 @@ +#include + +static inline void svm_vmload_pa(paddr_t vmcb) +{ + asm volatile ( + ".byte 0x0f,0x01,0xda" /* vmload */ + : : "a" (vmcb) : "memory" ); +} + +static inline void svm_vmsave_pa(paddr_t vmcb) +{ + asm volatile ( + ".byte 0x0f,0x01,0xdb" /* vmsave */ + : : "a" (vmcb) : "memory" ); +} + +struct cpu_user_regs; + +unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); +void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); + +/* TSC rate */ +#define DEFAULT_TSC_RATIO 0x0000000100000000ULL +#define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL + +/* EXITINFO1 fields on NPT faults */ +#define _NPT_PFEC_with_gla 32 +#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) +#define _NPT_PFEC_in_gpt 33 +#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index c62d0caa32..254de55ee9 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -22,20 +22,6 @@ #include -static inline void svm_vmload_pa(paddr_t vmcb) -{ - asm volatile ( - ".byte 0x0f,0x01,0xda" /* vmload */ - : : "a" (vmcb) : "memory" ); -} - -static inline void svm_vmsave_pa(paddr_t vmcb) -{ - asm volatile ( - ".byte 0x0f,0x01,0xdb" /* vmsave */ - : : "a" (vmcb) : "memory" ); -} - static inline void svm_invlpga(unsigned long linear, uint32_t asid) { asm volatile ( @@ -45,11 +31,6 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) "a" (linear), "c" (asid)); } -struct cpu_user_regs; - -unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); -void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); - /* * PV context switch helpers. Prefetching the VMCB area itself has been shown * to be useful for performance. @@ -95,14 +76,4 @@ extern u32 svm_feature_flags; #define cpu_has_svm_sss cpu_has_svm_feature(SVM_FEATURE_SSS) #define cpu_has_svm_spec_ctrl cpu_has_svm_feature(SVM_FEATURE_SPEC_CTRL) -/* TSC rate */ -#define DEFAULT_TSC_RATIO 0x0000000100000000ULL -#define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL - -/* EXITINFO1 fields on NPT faults */ -#define _NPT_PFEC_with_gla 32 -#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) -#define _NPT_PFEC_in_gpt 33 -#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) - #endif /* __ASM_X86_HVM_SVM_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499396.770509 (Exim 4.92) (envelope-from ) id 1pUnnV-0000FS-Ny; Wed, 22 Feb 2023 12:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499396.770509; Wed, 22 Feb 2023 12:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnV-0000FL-Ko; Wed, 22 Feb 2023 12:00:33 +0000 Received: by outflank-mailman (input) for mailman id 499396; Wed, 22 Feb 2023 12:00:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnT-0000FF-Pt for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:31 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 809f8dbd-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:30 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id da10so30583596edb.3 for ; Wed, 22 Feb 2023 04:00:30 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 809f8dbd-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vctN9byLZ3zzX+3VJyfxjohjvmSQiMhPGUBNk/doJeU=; b=IznCQCRCnR2fPm5jak0+CYdnx7/Rjl+M1r781niBYAoNyTus693IF9EGbpNEEu3j8k ooT2RPBZmUZ6kc7NEXAgG2KN9RwRcbKX6+FCqNpJLn7TQjTDBJwiCva0HLrq/pAW5fCh 2Fh1OKGa114KgoMTsKiWCUSAefgo9cdP1yH694O+4Da85Qq+awGlloPMEepyD6goIsLv ii3ZjWqYPd+b+pyo8v7Uyiv3vASf3e1TVrO70Va/L3wlc9X6Z+h11sPiesP+66R14Y1i D72aEJIaIeRuI5WyiqtTBx1bWiiqF+XkY3Q4mhf0RMW/tPouJ8EujKFfz2jlKc87P6Pc E2lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vctN9byLZ3zzX+3VJyfxjohjvmSQiMhPGUBNk/doJeU=; b=SaePBZSsJDD/WteJtFcKieeMMXQKH5Obm4GhJAFkZDCDVa8IZzweEWYnF3OthVuD1W LDIAXoF7gycBwaKLd2xK44KLTsVLUTHK+ooqV5vDbX2OPdUcXEYrDERIoT0qBtZ82d0k J0jybsdCFjxJ4dnQfGAfSSWoQUIv4spDD60XcLaE48CpI/7S6XJsKRI717vxDelMxM8c VFcyuBD4OkYIich7ZcwdwfnggLPKN2bpR8DfHeoPhbz2frPgou7SEzxu2bG+Wb6gPF/g IkHbqdjaZNTp/0gjregwF29BPX1Gyff918dsEaV2HPQL/xNDgcq9sWeGvRY7O+lLta+N NWbA== X-Gm-Message-State: AO0yUKXGZnGkLwgtyKDZKkZEqelRWtGm+Hpv851+aIHlYP5prDZcdHgV kCm1cfCaf4g3naeFAJXzy3mN89olpMU= X-Google-Smtp-Source: AK7set9qw2grfl40dxYJZ/ez6sUwMy1z/NWiRVGdfxseW35rfGF/sZ9crOu1dVjFngdF4b08gssBRw== X-Received: by 2002:a17:907:7817:b0:8b1:3a23:8ec7 with SMTP id la23-20020a170907781700b008b13a238ec7mr14234567ejc.43.1677067229419; Wed, 22 Feb 2023 04:00:29 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v2 0/9] x86/hvm: {svm,vmx}.{c,h} cleanup Date: Wed, 22 Feb 2023 14:00:14 +0200 Message-Id: <20230222120023.3004624-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series attempts a cleanup of files {svm,vmx}.{c,h} by removing redundant headers and sorting the rest, reducing the scope of declarations and definitions, moving functions used only by internal {svm,vmx} code to private headers. This series aims to address the comments made on the first version. Main changes from the v1 series: - split the changes into smaller reviewable patches - drop the huge code rearrangment done in vmx.c - instead of spreading arround the declarations in c files to hide them, use private headers There are more detailed per-patch changesets. Xenia Ragiadakou (9): x86/svm: remove unused forward declaration of struct vcpu from svm.h x86/svm: opencode SVM_PAUSE{FILTER,THRESH}_INIT x86/svm: move declarations used only by svm code from svm.h to private header x86/vmx: remove unused included headers from vmx.h x86/vmx: reduce scope of GAS_VMX_OP definition x86/vmx: move declations used only by vmx code from vmx.h to private header x86/vmx: remove unused included headers from vmx.c x86/vmx: declare nvmx_enqueue_n2_exceptions() static x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static xen/arch/x86/hvm/svm/nestedsvm.c | 1 + xen/arch/x86/hvm/svm/svm.c | 2 + xen/arch/x86/hvm/svm/svm.h | 40 +++ xen/arch/x86/hvm/svm/vmcb.c | 4 +- xen/arch/x86/hvm/vmx/intr.c | 2 + xen/arch/x86/hvm/vmx/realmode.c | 2 + xen/arch/x86/hvm/vmx/vmcs.c | 14 + xen/arch/x86/hvm/vmx/vmx.c | 73 ++-- xen/arch/x86/hvm/vmx/vmx.h | 458 ++++++++++++++++++++++++ xen/arch/x86/hvm/vmx/vvmx.c | 2 + xen/arch/x86/include/asm/hvm/svm/svm.h | 33 -- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 468 +------------------------ 12 files changed, 564 insertions(+), 535 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/svm.h create mode 100644 xen/arch/x86/hvm/vmx/vmx.h -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499400.770554 (Exim 4.92) (envelope-from ) id 1pUnnb-0001IZ-QN; Wed, 22 Feb 2023 12:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499400.770554; Wed, 22 Feb 2023 12:00:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnb-0001IO-MY; Wed, 22 Feb 2023 12:00:39 +0000 Received: by outflank-mailman (input) for mailman id 499400; Wed, 22 Feb 2023 12:00:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnna-0000FF-4v for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:38 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8516d8fa-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:37 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id cq23so29075164edb.1 for ; Wed, 22 Feb 2023 04:00:37 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8516d8fa-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aCe2e8yII+W8C97Qm8Q6kxpPS0WeF8P3OBexIFC6KlA=; b=dg4HMlrrLfJhNwUn9/mdMnmfnt76ucjv2SprMcdN+D8wibUcScNaw+7QrF9+ZbN/2I Qc036yIZMcgPpIM94/CSu9AUt+JFQwOQUn9I2ClizErcdw9dmlUimrq8ZviDqfdOdfbf hJ8eBBeOqmc4Zbk6neR+g4NpauQcvPbXbma92csWVeblK41Q2+/bnMs1fUahlAC/W0ST WcwURF2M5ukOJwIpP/w9oGxfL3Z57NmBcm4RV7h8rLRINYksd+zkXcd/EwYOInE2FRG7 yNpa8F8RQtaKVeyZRW/chA/OVR5papgKpHbTZKxznkc/i6M0G5U9/PwzRecKdltPux0f j4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aCe2e8yII+W8C97Qm8Q6kxpPS0WeF8P3OBexIFC6KlA=; b=DdSrKTL+spjYWKnUzeHsWDKi5b7Ia3tBcSBUJqz49RT15evGHfAU/WN4+x89kVaADs 45/8a6Ev2/ueFxlEGEBnRlye4ZxOgG6jHmJnMV3pZ1GqK2acfzhR4dUhNf2GCfRvIe3N BJc6nt3JHScd1auPZR9pkWJk3yPB9V0L18Hs+jeLFkUvuKjNW4ZCY0099ElPIvsnJ6Eq yYZPFZKfIexN9nzBV2ASi7LosSSiX9LUnTmEBxXexkwosGHQm4o3mnHgaftu/8HsIU67 BikzmWCmnwWmzFJX6ttyD87MDbrJNPH90/AGNE0VrDtHw8c9sbtU/SRSI7BpCWJohIvM aNzQ== X-Gm-Message-State: AO0yUKWCRdEvm4WQv08HEODcjI9LdcNuLeQivhdcxevvXDAyrzoH1ZZa +3NcUAavqyDxw+8PRWVx4cVzQk+xrDQ= X-Google-Smtp-Source: AK7set930ay0yKAQ1/kzIMCVr92R/OoyojJ+FncrdszvL6+XOcmcUqEcJWlwxcKm2Dqau3lPSnBk+Q== X-Received: by 2002:a17:906:2a03:b0:883:fe6b:814 with SMTP id j3-20020a1709062a0300b00883fe6b0814mr14576122eje.37.1677067237157; Wed, 22 Feb 2023 04:00:37 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 4/9] x86/vmx: remove unused included headers from vmx.h Date: Wed, 22 Feb 2023 14:00:18 +0200 Message-Id: <20230222120023.3004624-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/i387.h asm/hvm/trace.h asm/processor.h asm/regs.h because none of the declarations and macro definitions in them is used in this file. Sort the rest of the headers alphabetically. Fix build by including asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy(). Signed-off-by: Xenia Ragiadakou --- Changes in v2: -add a blank line between different types of headers, reported by Andrew -fix english in commit message, reported by Andrew xen/arch/x86/hvm/vmx/vmx.c | 1 + xen/arch/x86/include/asm/hvm/vmx/vmx.h | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0ec33bcc18..a0297e8c6c 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 97d6b810ec..c0ca6d10e3 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -19,14 +19,11 @@ #define __ASM_X86_HVM_VMX_VMX_H__ #include -#include -#include + #include -#include -#include -#include -#include #include +#include +#include extern int8_t opt_ept_exec_sp; -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499401.770565 (Exim 4.92) (envelope-from ) id 1pUnne-0001cg-A2; Wed, 22 Feb 2023 12:00:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499401.770565; Wed, 22 Feb 2023 12:00:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnne-0001cX-6k; Wed, 22 Feb 2023 12:00:42 +0000 Received: by outflank-mailman (input) for mailman id 499401; Wed, 22 Feb 2023 12:00:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnd-0000Rg-7P for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:41 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8647edfc-b2a8-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 13:00:39 +0100 (CET) Received: by mail-ed1-x52a.google.com with SMTP id ee7so14262212edb.2 for ; Wed, 22 Feb 2023 04:00:39 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8647edfc-b2a8-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P2sR+ZHD7PGnYGWl4CAsPoK4VvzcqTimIkDugq8HftE=; b=M6NwNjYAfFKkG6YHT/G1ScixCYFLDYjYUFFAnszuY88+Nvke1Zt5JySwL2EyLwLpk0 4FSGFL4chAga8yGLKycaCHkAMqGFmQ4YlX+2m/UVkrS9iF9dYfJ0+Uoztt3tV0eGSk3e wqpuiVdT8j4I8MW3/FHRADBVPGjoNuZN6i00Ya6Wx/oY79EIdWKEZuCya0tO7aLA5hOE nEWrLfdmLtQjOzFSndc1trvjC63L9ZCGk3LDQzqx/vSq++4T8uGmFQCsP/YSqZkj1tNO Hi5LJg9cka8htYGi8wL2FOArf4k1RtTDz1ZhMTEf5YevcidaWeZ+JReult//u5+q1FWa 5jJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P2sR+ZHD7PGnYGWl4CAsPoK4VvzcqTimIkDugq8HftE=; b=Odoa8Mu9p9qwEjeiIGMTeXI+Cx2bv/ccYMqvGrpGAq0Pilzkt5CdPUdOQOdzYJbaK/ oadtIc8Ai4O13UAcdEcYILeD1zf9Icp2pdXm3jUDXfQPpwrM4BP4Wqheda9QIqqgOTpB 4SZyxPXR0vA2nzhUxMIlxFUqo4jAbyT7PyHFe3iXIrM6kWjp6qk5jidR+ZasXnwq4fQw 9K4JQ3FW5ID2nA/kuH8FvE8omermCMQLW9ObtzVAox38p6sdhLxtDrbVVieL5x+CvANW VWd4qv5KXeSM8JBxSEJVae91dmm/6THRCPYh58Rtciq3sqkljezUsBXyx/y3efqxg2cS Tqyw== X-Gm-Message-State: AO0yUKWKKpTIARyIrjm1oKB09oliB/roorBZ62l4rTBuXobaH3Vffssj JT7tMwLl3pG0OobBWdrOGkNoQrmBcrA= X-Google-Smtp-Source: AK7set9WAj9zvoGbLC+eMz76L24vUQyCkVdiizLj2utZ4FpQyqvjFHCyKOK6wOsomomX5K61OnzrLA== X-Received: by 2002:a17:907:b609:b0:88e:682e:3a9e with SMTP id vl9-20020a170907b60900b0088e682e3a9emr14679589ejc.61.1677067238949; Wed, 22 Feb 2023 04:00:38 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 5/9] x86/vmx: reduce scope of GAS_VMX_OP definition Date: Wed, 22 Feb 2023 14:00:19 +0200 Message-Id: <20230222120023.3004624-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since GAS_VMX_OP is used only by vm{read,write}_safe, move its definition just above those functions and undefine it after use. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - none xen/arch/x86/include/asm/hvm/vmx/vmx.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index c0ca6d10e3..1ba2937c23 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -319,12 +319,6 @@ extern uint8_t posted_intr_vector; #define INVVPID_ALL_CONTEXT 2 #define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 -#ifdef HAVE_AS_VMX -# define GAS_VMX_OP(yes, no) yes -#else -# define GAS_VMX_OP(yes, no) no -#endif - static always_inline void __vmptrld(u64 addr) { asm volatile ( @@ -414,6 +408,12 @@ static always_inline void __vmwrite(unsigned long field, unsigned long value) ); } +#ifdef HAVE_AS_VMX +# define GAS_VMX_OP(yes, no) yes +#else +# define GAS_VMX_OP(yes, no) no +#endif + static inline enum vmx_insn_errno vmread_safe(unsigned long field, unsigned long *value) { @@ -460,6 +460,8 @@ static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, return ret; } +#undef GAS_VMX_OP + static always_inline void __invept(unsigned long type, uint64_t eptp) { struct { -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499402.770576 (Exim 4.92) (envelope-from ) id 1pUnnh-0001xu-Is; Wed, 22 Feb 2023 12:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499402.770576; Wed, 22 Feb 2023 12:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnh-0001xh-Et; Wed, 22 Feb 2023 12:00:45 +0000 Received: by outflank-mailman (input) for mailman id 499402; Wed, 22 Feb 2023 12:00:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnf-0000FF-MZ for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:44 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87acfda0-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:41 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id cq23so29076041edb.1 for ; Wed, 22 Feb 2023 04:00:41 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87acfda0-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xp171KZwAsQPheQj1isQUJOpmjl0rnTHo3TSkhKp2Vw=; b=V2rIPUjwGNvwRg78f+GhjCgSIj10KrPxE4n4XoWeMss3nzcqv9ZS1YggLYJXMo2eMI Ax5FYfdARKZTNMSSAhWDNAwG8Cwejtw48khVC7jBJqutZlXzbJWK4m9cCfK5Tt/tpUNR YDhtlHpyyAXfMsnoO+NbtY3DK0n7eExbzB9jROhjrP2w+mKnRcuttZRDsgSVvZQGwwX9 26WJMUUSvyYemYhC12/OgIiHRfQz+5OuidW1cP9GfASOJEt0T54SINYG8x4mtuRFbx+t WlG2tnzP9WxGvpkmbfo4jJrFtEcCXOPXVV5DGBvi2PO8s7AIMU0oruur7db5TgKgObDQ RXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xp171KZwAsQPheQj1isQUJOpmjl0rnTHo3TSkhKp2Vw=; b=UJg5s55k5oP5jIOO6QFjvDXjK2DTJ6xWEH0zaz/sAX47PoEcTr2pajt2h56t7EOvoX Q7nOxQX1J8/zaemiMbwLBSbsZ9PagsM8BOH3DPkV76RMNuy6uZ4wg6+KqM8krlhy+/rO 2cDMDDvOccu5oNQaowAiDKLSH+q6xxqUWNVSZM9kQLinyxUXJNyK+AGdlxZYOCg6uBam CQ8TcvumWZdCrFDB90qxBukeZq8+UzFmneBhIrkinDc8X95xjSJhmRchV7K3D+40KsLe D8hMiBqTmpQdpKFQUiSn4H1xppEVPlhGXDMDRHs1ahP7BQv/MgVrPfszE/OkbaY47raX hzbQ== X-Gm-Message-State: AO0yUKV3e7/FznEgqYTWt41orrTIQ3GTXWiJnkm9+OaMudatxLS5uQoB aIAIUzXZYRSpyOBDFskRZCLP1DPAHD0= X-Google-Smtp-Source: AK7set+XvXtK8ytTooDGm52VZHOAV0d8NoMNS9SxIK5Oon99fXTKbbunblABqPQgOWrdOs1hZ8J16w== X-Received: by 2002:a17:907:7f0d:b0:87b:d2b3:67ca with SMTP id qf13-20020a1709077f0d00b0087bd2b367camr18847740ejc.75.1677067241085; Wed, 22 Feb 2023 04:00:41 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 6/9] x86/vmx: move declations used only by vmx code from vmx.h to private header Date: Wed, 22 Feb 2023 14:00:20 +0200 Message-Id: <20230222120023.3004624-7-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/vmx/ called vmx.h and move there all definitions and declarations that are used solely by vmx code. EPT related declarations and definitions stay in asm/hvm/vmx/vmx.h because they are used in arch/x86/mm and drivers/passthrough/vtd. Also, __vmread(), used in arch/x86/cpu, and consequently the opcodes stay in asm/hvm/vmx/vmx.h. Take the opportunity to remove a trailing white space from __vmxon(). Signed-off-by: Xenia Ragiadakou --- Changes in v2: - new patch, creation of private header for holding declarations and definitions consumed only by vmx code, suggested by Andrew and Jan I have not added #ifndef guards as it is a private and it should not be included by other headers. However, this is considered a MISRA-C violation ... I 'm not sure what to do. xen/arch/x86/hvm/vmx/intr.c | 2 + xen/arch/x86/hvm/vmx/realmode.c | 2 + xen/arch/x86/hvm/vmx/vmcs.c | 2 + xen/arch/x86/hvm/vmx/vmx.c | 2 + xen/arch/x86/hvm/vmx/vmx.h | 459 ++++++++++++++++++++++++ xen/arch/x86/hvm/vmx/vvmx.c | 2 + xen/arch/x86/include/asm/hvm/vmx/vmx.h | 463 +------------------------ 7 files changed, 479 insertions(+), 453 deletions(-) create mode 100644 xen/arch/x86/hvm/vmx/vmx.h diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e..c8db501759 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -38,6 +38,8 @@ #include #include +#include "vmx.h" + /* * A few notes on virtual NMI and INTR delivery, and interactions with * interruptibility states: diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c index 4ac93e0810..5591660230 100644 --- a/xen/arch/x86/hvm/vmx/realmode.c +++ b/xen/arch/x86/hvm/vmx/realmode.c @@ -23,6 +23,8 @@ #include #include +#include "vmx.h" + static void realmode_deliver_exception( unsigned int vector, unsigned int insn_len, diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index e1c268789e..bc2acd3063 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -43,6 +43,8 @@ #include #include +#include "vmx.h" + static bool_t __read_mostly opt_vpid_enabled = 1; boolean_param("vpid", opt_vpid_enabled); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index a0297e8c6c..a19ece90fc 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -62,6 +62,8 @@ #include #include +#include "vmx.h" + static bool_t __initdata opt_force_ept; boolean_param("force-ept", opt_force_ept); diff --git a/xen/arch/x86/hvm/vmx/vmx.h b/xen/arch/x86/hvm/vmx/vmx.h new file mode 100644 index 0000000000..ffc19539bc --- /dev/null +++ b/xen/arch/x86/hvm/vmx/vmx.h @@ -0,0 +1,459 @@ +#include + +#include +#include +#include +#include + +extern int8_t opt_ept_exec_sp; + +#define PI_xAPIC_NDST_MASK 0xFF00 + +void vmx_asm_vmexit_handler(struct cpu_user_regs); +void vmx_intr_assist(void); +void noreturn cf_check vmx_do_resume(void); +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); +void vmx_realmode(struct cpu_user_regs *regs); +void vmx_update_debug_state(struct vcpu *v); +void vmx_update_exception_bitmap(struct vcpu *v); +void vmx_update_cpu_exec_control(struct vcpu *v); +void vmx_update_secondary_exec_control(struct vcpu *v); + +#define POSTED_INTR_ON 0 +#define POSTED_INTR_SN 1 +static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) +{ + return test_and_set_bit(vector, pi_desc->pir); +} + +static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) +{ + return test_bit(vector, pi_desc->pir); +} + +static inline int pi_test_and_set_on(struct pi_desc *pi_desc) +{ + return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline void pi_set_on(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) +{ + return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_on(struct pi_desc *pi_desc) +{ + return pi_desc->on; +} + +static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) +{ + return xchg(&pi_desc->pir[group], 0); +} + +static inline int pi_test_sn(struct pi_desc *pi_desc) +{ + return pi_desc->sn; +} + +static inline void pi_set_sn(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_SN, &pi_desc->control); +} + +static inline void pi_clear_sn(struct pi_desc *pi_desc) +{ + clear_bit(POSTED_INTR_SN, &pi_desc->control); +} + +/* + * Interruption-information format + * + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification + * field for EPT violations, PML full and SPP-related event vmexits. + */ +#define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ +#define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ +#define INTR_INFO_DELIVER_CODE_MASK 0x800 /* 11 */ +#define INTR_INFO_NMI_UNBLOCKED_BY_IRET 0x1000 /* 12 */ +#define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ +#define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 + +/* + * Exit Qualifications for NOTIFY VM EXIT + */ +#define NOTIFY_VM_CONTEXT_INVALID 1u + +/* + * Exit Qualifications for MOV for Control Register Access + */ +enum { + VMX_CR_ACCESS_TYPE_MOV_TO_CR, + VMX_CR_ACCESS_TYPE_MOV_FROM_CR, + VMX_CR_ACCESS_TYPE_CLTS, + VMX_CR_ACCESS_TYPE_LMSW, +}; +typedef union cr_access_qual { + unsigned long raw; + struct { + uint16_t cr:4, + access_type:2, /* VMX_CR_ACCESS_TYPE_* */ + lmsw_op_type:1, /* 0 => reg, 1 => mem */ + :1, + gpr:4, + :4; + uint16_t lmsw_data; + uint32_t :32; + }; +} __transparent__ cr_access_qual_t; + +/* + * Access Rights + */ +#define X86_SEG_AR_SEG_TYPE 0xf /* 3:0, segment type */ +#define X86_SEG_AR_DESC_TYPE (1u << 4) /* 4, descriptor type */ +#define X86_SEG_AR_DPL 0x60 /* 6:5, descriptor privilege level */ +#define X86_SEG_AR_SEG_PRESENT (1u << 7) /* 7, segment present */ +#define X86_SEG_AR_AVL (1u << 12) /* 12, available for system software */ +#define X86_SEG_AR_CS_LM_ACTIVE (1u << 13) /* 13, long mode active (CS only) */ +#define X86_SEG_AR_DEF_OP_SIZE (1u << 14) /* 14, default operation size */ +#define X86_SEG_AR_GRANULARITY (1u << 15) /* 15, granularity */ +#define X86_SEG_AR_SEG_UNUSABLE (1u << 16) /* 16, segment unusable */ + +extern uint8_t posted_intr_vector; + +#define INVEPT_SINGLE_CONTEXT 1 +#define INVEPT_ALL_CONTEXT 2 + +#define INVVPID_INDIVIDUAL_ADDR 0 +#define INVVPID_SINGLE_CONTEXT 1 +#define INVVPID_ALL_CONTEXT 2 +#define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 + +static always_inline void __vmptrld(u64 addr) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmptrld %0\n" +#else + VMPTRLD_OPCODE MODRM_EAX_06 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmptrld) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "m" (addr), +#else + : "a" (&addr), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory"); +} + +static always_inline void __vmpclear(u64 addr) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmclear %0\n" +#else + VMCLEAR_OPCODE MODRM_EAX_06 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmclear) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "m" (addr), +#else + : "a" (&addr), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory"); +} + +static always_inline void __vmwrite(unsigned long field, unsigned long value) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmwrite %1, %0\n" +#else + VMWRITE_OPCODE MODRM_EAX_ECX +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmwrite) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "r" (field) , "rm" (value), +#else + : "a" (field) , "c" (value), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + ); +} + + +#ifdef HAVE_AS_VMX +# define GAS_VMX_OP(yes, no) yes +#else +# define GAS_VMX_OP(yes, no) no +#endif + +static inline enum vmx_insn_errno vmread_safe(unsigned long field, + unsigned long *value) +{ + unsigned long ret = VMX_INSN_SUCCEED; + bool fail_invalid, fail_valid; + + asm volatile ( GAS_VMX_OP("vmread %[field], %[value]\n\t", + VMREAD_OPCODE MODRM_EAX_ECX) + ASM_FLAG_OUT(, "setc %[invalid]\n\t") + ASM_FLAG_OUT(, "setz %[valid]\n\t") + : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), + ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid), + [value] GAS_VMX_OP("=rm", "=c") (*value) + : [field] GAS_VMX_OP("r", "a") (field)); + + if ( unlikely(fail_invalid) ) + ret = VMX_INSN_FAIL_INVALID; + else if ( unlikely(fail_valid) ) + __vmread(VM_INSTRUCTION_ERROR, &ret); + + return ret; +} + +static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, + unsigned long value) +{ + unsigned long ret = VMX_INSN_SUCCEED; + bool fail_invalid, fail_valid; + + asm volatile ( GAS_VMX_OP("vmwrite %[value], %[field]\n\t", + VMWRITE_OPCODE MODRM_EAX_ECX) + ASM_FLAG_OUT(, "setc %[invalid]\n\t") + ASM_FLAG_OUT(, "setz %[valid]\n\t") + : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), + ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid) + : [field] GAS_VMX_OP("r", "a") (field), + [value] GAS_VMX_OP("rm", "c") (value)); + + if ( unlikely(fail_invalid) ) + ret = VMX_INSN_FAIL_INVALID; + else if ( unlikely(fail_valid) ) + __vmread(VM_INSTRUCTION_ERROR, &ret); + + return ret; +} + +#undef GAS_VMX_OP + + +static always_inline void __invept(unsigned long type, uint64_t eptp) +{ + struct { + uint64_t eptp, rsvd; + } operand = { eptp }; + + /* + * If single context invalidation is not supported, we escalate to + * use all context invalidation. + */ + if ( (type == INVEPT_SINGLE_CONTEXT) && + !cpu_has_vmx_ept_invept_single_context ) + type = INVEPT_ALL_CONTEXT; + + asm volatile ( +#ifdef HAVE_AS_EPT + "invept %0, %1\n" +#else + INVEPT_OPCODE MODRM_EAX_08 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, invept) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_EPT + : "m" (operand), "r" (type), +#else + : "a" (&operand), "c" (type), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +static always_inline void __invvpid(unsigned long type, u16 vpid, u64 gva) +{ + struct __packed { + u64 vpid:16; + u64 rsvd:48; + u64 gva; + } operand = {vpid, 0, gva}; + + /* Fix up #UD exceptions which occur when TLBs are flushed before VMXON. */ + asm volatile ( "1: " +#ifdef HAVE_AS_EPT + "invvpid %0, %1\n" +#else + INVVPID_OPCODE MODRM_EAX_08 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, invvpid) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION "\n" + "2:" + _ASM_EXTABLE(1b, 2b) + : +#ifdef HAVE_AS_EPT + : "m" (operand), "r" (type), +#else + : "a" (&operand), "c" (type), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +static inline void ept_sync_all(void) +{ + __invept(INVEPT_ALL_CONTEXT, 0); +} + +static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) +{ + int type = INVVPID_INDIVIDUAL_ADDR; + + /* + * If individual address invalidation is not supported, we escalate to + * use single context invalidation. + */ + if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) + goto execute_invvpid; + + type = INVVPID_SINGLE_CONTEXT; + + /* + * If single context invalidation is not supported, we escalate to + * use all context invalidation. + */ + if ( !cpu_has_vmx_vpid_invvpid_single_context ) + type = INVVPID_ALL_CONTEXT; + +execute_invvpid: + __invvpid(type, v->arch.hvm.n1asid.asid, (u64)gva); +} + +static inline void vpid_sync_all(void) +{ + __invvpid(INVVPID_ALL_CONTEXT, 0, 0); +} + +static inline void __vmxoff(void) +{ + asm volatile ( + VMXOFF_OPCODE + : : : "memory" ); +} + +static inline int __vmxon(u64 addr) +{ + int rc; + + asm volatile ( + "1: " VMXON_OPCODE MODRM_EAX_06 "\n" + " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ + "2:\n" + ".section .fixup,\"ax\"\n" + "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ + ".previous\n" + _ASM_EXTABLE(1b, 3b) + : "=q" (rc) + : "0" (0), "a" (&addr) + : "memory"); + + return rc; +} + +int cf_check vmx_guest_x86_mode(struct vcpu *v); +unsigned int vmx_get_cpl(void); +void vmx_inject_extint(int trap, uint8_t source); +void vmx_inject_nmi(void); + +void update_guest_eip(void); + +void vmx_pi_per_cpu_init(unsigned int cpu); +void vmx_pi_desc_fixup(unsigned int cpu); + +void vmx_sync_exit_bitmap(struct vcpu *v); + +#define APIC_INVALID_DEST 0xffffffff + +/* #VE information page */ +typedef struct { + u32 exit_reason; + u32 semaphore; + u64 exit_qualification; + u64 gla; + u64 gpa; + u16 eptp_index; +} ve_info_t; + +/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ +typedef union idt_or_gdt_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :5, /* bits 6:2 - Undefined */ + addr_size :3, /* bits 9:7 - Address size */ + :1, /* bit 10 - Cleared to 0 */ + operand_size :1, /* bit 11 - Operand size */ + :3, /* bits 14:12 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 30:63 - Undefined */ + }; +} idt_or_gdt_instr_info_t; + +/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ +typedef union ldt_or_tr_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :1, /* bit 2 - Undefined */ + reg1 :4, /* bits 6:3 - Reg1 */ + addr_size :3, /* bits 9:7 - Address size */ + mem_reg :1, /* bit 10 - Mem/Reg */ + :4, /* bits 14:11 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 31:63 - Undefined */ + }; +} ldt_or_tr_instr_info_t; + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb07..0bda8430b9 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -29,6 +29,8 @@ #include #include +#include "vmx.h" + static DEFINE_PER_CPU(u64 *, vvmcs_buf); static void nvmx_purge_vvmcs(struct vcpu *v); diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 1ba2937c23..c81d76e4eb 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -20,13 +20,9 @@ #include -#include -#include #include #include -extern int8_t opt_ept_exec_sp; - typedef union { struct { u64 r : 1, /* bit 0 - Read permission */ @@ -77,71 +73,8 @@ typedef enum { #define EPTE_RWX_MASK 0x7 #define EPTE_FLAG_MASK 0x7f -#define PI_xAPIC_NDST_MASK 0xFF00 - -void vmx_asm_vmexit_handler(struct cpu_user_regs); -void vmx_intr_assist(void); -void noreturn cf_check vmx_do_resume(void); -void cf_check vmx_vlapic_msr_changed(struct vcpu *v); struct hvm_emulate_ctxt; void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt); -void vmx_realmode(struct cpu_user_regs *regs); -void vmx_update_debug_state(struct vcpu *v); -void vmx_update_exception_bitmap(struct vcpu *v); -void vmx_update_cpu_exec_control(struct vcpu *v); -void vmx_update_secondary_exec_control(struct vcpu *v); - -#define POSTED_INTR_ON 0 -#define POSTED_INTR_SN 1 -static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) -{ - return test_and_set_bit(vector, pi_desc->pir); -} - -static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) -{ - return test_bit(vector, pi_desc->pir); -} - -static inline int pi_test_and_set_on(struct pi_desc *pi_desc) -{ - return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline void pi_set_on(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) -{ - return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_on(struct pi_desc *pi_desc) -{ - return pi_desc->on; -} - -static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) -{ - return xchg(&pi_desc->pir[group], 0); -} - -static inline int pi_test_sn(struct pi_desc *pi_desc) -{ - return pi_desc->sn; -} - -static inline void pi_set_sn(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_SN, &pi_desc->control); -} - -static inline void pi_clear_sn(struct pi_desc *pi_desc) -{ - clear_bit(POSTED_INTR_SN, &pi_desc->control); -} /* * Exit Reasons @@ -212,60 +145,6 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_NOTIFY 75 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ -/* - * Interruption-information format - * - * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification - * field for EPT violations, PML full and SPP-related event vmexits. - */ -#define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ -#define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ -#define INTR_INFO_DELIVER_CODE_MASK 0x800 /* 11 */ -#define INTR_INFO_NMI_UNBLOCKED_BY_IRET 0x1000 /* 12 */ -#define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ -#define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 - -/* - * Exit Qualifications for NOTIFY VM EXIT - */ -#define NOTIFY_VM_CONTEXT_INVALID 1u - -/* - * Exit Qualifications for MOV for Control Register Access - */ -enum { - VMX_CR_ACCESS_TYPE_MOV_TO_CR, - VMX_CR_ACCESS_TYPE_MOV_FROM_CR, - VMX_CR_ACCESS_TYPE_CLTS, - VMX_CR_ACCESS_TYPE_LMSW, -}; -typedef union cr_access_qual { - unsigned long raw; - struct { - uint16_t cr:4, - access_type:2, /* VMX_CR_ACCESS_TYPE_* */ - lmsw_op_type:1, /* 0 => reg, 1 => mem */ - :1, - gpr:4, - :4; - uint16_t lmsw_data; - uint32_t :32; - }; -} __transparent__ cr_access_qual_t; - -/* - * Access Rights - */ -#define X86_SEG_AR_SEG_TYPE 0xf /* 3:0, segment type */ -#define X86_SEG_AR_DESC_TYPE (1u << 4) /* 4, descriptor type */ -#define X86_SEG_AR_DPL 0x60 /* 6:5, descriptor privilege level */ -#define X86_SEG_AR_SEG_PRESENT (1u << 7) /* 7, segment present */ -#define X86_SEG_AR_AVL (1u << 12) /* 12, available for system software */ -#define X86_SEG_AR_CS_LM_ACTIVE (1u << 13) /* 13, long mode active (CS only) */ -#define X86_SEG_AR_DEF_OP_SIZE (1u << 14) /* 14, default operation size */ -#define X86_SEG_AR_GRANULARITY (1u << 15) /* 15, granularity */ -#define X86_SEG_AR_SEG_UNUSABLE (1u << 16) /* 16, segment unusable */ - #define VMCALL_OPCODE ".byte 0x0f,0x01,0xc1\n" #define VMCLEAR_OPCODE ".byte 0x66,0x0f,0xc7\n" /* reg/opcode: /6 */ #define VMLAUNCH_OPCODE ".byte 0x0f,0x01,0xc2\n" @@ -284,8 +163,6 @@ typedef union cr_access_qual { #define MODRM_EAX_07 ".byte 0x38\n" /* [EAX], with reg/opcode: /7 */ #define MODRM_EAX_ECX ".byte 0xc1\n" /* EAX, ECX */ -extern uint8_t posted_intr_vector; - #define cpu_has_vmx_ept_exec_only_supported \ (vmx_ept_vpid_cap & VMX_EPT_EXEC_ONLY_SUPPORTED) @@ -299,70 +176,6 @@ extern uint8_t posted_intr_vector; #define cpu_has_vmx_ept_invept_single_context \ (vmx_ept_vpid_cap & VMX_EPT_INVEPT_SINGLE_CONTEXT) -#define EPT_2MB_SHIFT 16 -#define EPT_1GB_SHIFT 17 -#define ept_has_2mb(c) ((c >> EPT_2MB_SHIFT) & 1) -#define ept_has_1gb(c) ((c >> EPT_1GB_SHIFT) & 1) - -#define INVEPT_SINGLE_CONTEXT 1 -#define INVEPT_ALL_CONTEXT 2 - -#define cpu_has_vmx_vpid_invvpid_individual_addr \ - (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) -#define cpu_has_vmx_vpid_invvpid_single_context \ - (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT) -#define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ - (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) - -#define INVVPID_INDIVIDUAL_ADDR 0 -#define INVVPID_SINGLE_CONTEXT 1 -#define INVVPID_ALL_CONTEXT 2 -#define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 - -static always_inline void __vmptrld(u64 addr) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmptrld %0\n" -#else - VMPTRLD_OPCODE MODRM_EAX_06 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmptrld) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "m" (addr), -#else - : "a" (&addr), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory"); -} - -static always_inline void __vmpclear(u64 addr) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmclear %0\n" -#else - VMCLEAR_OPCODE MODRM_EAX_06 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmclear) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "m" (addr), -#else - : "a" (&addr), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory"); -} - static always_inline void __vmread(unsigned long field, unsigned long *value) { asm volatile ( @@ -386,215 +199,20 @@ static always_inline void __vmread(unsigned long field, unsigned long *value) ); } -static always_inline void __vmwrite(unsigned long field, unsigned long value) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmwrite %1, %0\n" -#else - VMWRITE_OPCODE MODRM_EAX_ECX -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmwrite) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "r" (field) , "rm" (value), -#else - : "a" (field) , "c" (value), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - ); -} - -#ifdef HAVE_AS_VMX -# define GAS_VMX_OP(yes, no) yes -#else -# define GAS_VMX_OP(yes, no) no -#endif - -static inline enum vmx_insn_errno vmread_safe(unsigned long field, - unsigned long *value) -{ - unsigned long ret = VMX_INSN_SUCCEED; - bool fail_invalid, fail_valid; - - asm volatile ( GAS_VMX_OP("vmread %[field], %[value]\n\t", - VMREAD_OPCODE MODRM_EAX_ECX) - ASM_FLAG_OUT(, "setc %[invalid]\n\t") - ASM_FLAG_OUT(, "setz %[valid]\n\t") - : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), - ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid), - [value] GAS_VMX_OP("=rm", "=c") (*value) - : [field] GAS_VMX_OP("r", "a") (field)); - - if ( unlikely(fail_invalid) ) - ret = VMX_INSN_FAIL_INVALID; - else if ( unlikely(fail_valid) ) - __vmread(VM_INSTRUCTION_ERROR, &ret); - - return ret; -} - -static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, - unsigned long value) -{ - unsigned long ret = VMX_INSN_SUCCEED; - bool fail_invalid, fail_valid; - - asm volatile ( GAS_VMX_OP("vmwrite %[value], %[field]\n\t", - VMWRITE_OPCODE MODRM_EAX_ECX) - ASM_FLAG_OUT(, "setc %[invalid]\n\t") - ASM_FLAG_OUT(, "setz %[valid]\n\t") - : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), - ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid) - : [field] GAS_VMX_OP("r", "a") (field), - [value] GAS_VMX_OP("rm", "c") (value)); - - if ( unlikely(fail_invalid) ) - ret = VMX_INSN_FAIL_INVALID; - else if ( unlikely(fail_valid) ) - __vmread(VM_INSTRUCTION_ERROR, &ret); - - return ret; -} - -#undef GAS_VMX_OP - -static always_inline void __invept(unsigned long type, uint64_t eptp) -{ - struct { - uint64_t eptp, rsvd; - } operand = { eptp }; - - /* - * If single context invalidation is not supported, we escalate to - * use all context invalidation. - */ - if ( (type == INVEPT_SINGLE_CONTEXT) && - !cpu_has_vmx_ept_invept_single_context ) - type = INVEPT_ALL_CONTEXT; - - asm volatile ( -#ifdef HAVE_AS_EPT - "invept %0, %1\n" -#else - INVEPT_OPCODE MODRM_EAX_08 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, invept) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_EPT - : "m" (operand), "r" (type), -#else - : "a" (&operand), "c" (type), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory" ); -} - -static always_inline void __invvpid(unsigned long type, u16 vpid, u64 gva) -{ - struct __packed { - u64 vpid:16; - u64 rsvd:48; - u64 gva; - } operand = {vpid, 0, gva}; - - /* Fix up #UD exceptions which occur when TLBs are flushed before VMXON. */ - asm volatile ( "1: " -#ifdef HAVE_AS_EPT - "invvpid %0, %1\n" -#else - INVVPID_OPCODE MODRM_EAX_08 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, invvpid) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION "\n" - "2:" - _ASM_EXTABLE(1b, 2b) - : -#ifdef HAVE_AS_EPT - : "m" (operand), "r" (type), -#else - : "a" (&operand), "c" (type), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory" ); -} +#define EPT_2MB_SHIFT 16 +#define EPT_1GB_SHIFT 17 +#define ept_has_2mb(c) ((c >> EPT_2MB_SHIFT) & 1) +#define ept_has_1gb(c) ((c >> EPT_1GB_SHIFT) & 1) -static inline void ept_sync_all(void) -{ - __invept(INVEPT_ALL_CONTEXT, 0); -} +#define cpu_has_vmx_vpid_invvpid_individual_addr \ + (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) +#define cpu_has_vmx_vpid_invvpid_single_context \ + (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT) +#define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ + (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) void ept_sync_domain(struct p2m_domain *p2m); -static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) -{ - int type = INVVPID_INDIVIDUAL_ADDR; - - /* - * If individual address invalidation is not supported, we escalate to - * use single context invalidation. - */ - if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) - goto execute_invvpid; - - type = INVVPID_SINGLE_CONTEXT; - - /* - * If single context invalidation is not supported, we escalate to - * use all context invalidation. - */ - if ( !cpu_has_vmx_vpid_invvpid_single_context ) - type = INVVPID_ALL_CONTEXT; - -execute_invvpid: - __invvpid(type, v->arch.hvm.n1asid.asid, (u64)gva); -} - -static inline void vpid_sync_all(void) -{ - __invvpid(INVVPID_ALL_CONTEXT, 0, 0); -} - -static inline void __vmxoff(void) -{ - asm volatile ( - VMXOFF_OPCODE - : : : "memory" ); -} - -static inline int __vmxon(u64 addr) -{ - int rc; - - asm volatile ( - "1: " VMXON_OPCODE MODRM_EAX_06 "\n" - " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ - "2:\n" - ".section .fixup,\"ax\"\n" - "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ - ".previous\n" - _ASM_EXTABLE(1b, 3b) - : "=q" (rc) - : "0" (0), "a" (&addr) - : "memory"); - - return rc; -} - -int cf_check vmx_guest_x86_mode(struct vcpu *v); -unsigned int vmx_get_cpl(void); - -void vmx_inject_extint(int trap, uint8_t source); -void vmx_inject_nmi(void); - void ept_walk_table(struct domain *d, unsigned long gfn); bool_t ept_handle_misconfig(uint64_t gpa); int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, @@ -603,13 +221,6 @@ void setup_ept_dump(void); /* Locate an alternate p2m by its EPTP */ unsigned int p2m_find_altp2m_by_eptp(struct domain *d, uint64_t eptp); -void update_guest_eip(void); - -void vmx_pi_per_cpu_init(unsigned int cpu); -void vmx_pi_desc_fixup(unsigned int cpu); - -void vmx_sync_exit_bitmap(struct vcpu *v); - #ifdef CONFIG_HVM void vmx_pi_hooks_assign(struct domain *d); void vmx_pi_hooks_deassign(struct domain *d); @@ -618,8 +229,6 @@ static inline void vmx_pi_hooks_assign(struct domain *d) {} static inline void vmx_pi_hooks_deassign(struct domain *d) {} #endif -#define APIC_INVALID_DEST 0xffffffff - /* EPT violation qualifications definitions */ typedef union ept_qual { unsigned long raw; @@ -635,56 +244,4 @@ typedef union ept_qual { #define EPT_L4_PAGETABLE_SHIFT 39 #define EPT_PAGETABLE_ENTRIES 512 -/* #VE information page */ -typedef struct { - u32 exit_reason; - u32 semaphore; - u64 exit_qualification; - u64 gla; - u64 gpa; - u16 eptp_index; -} ve_info_t; - -/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ -typedef union idt_or_gdt_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :5, /* bits 6:2 - Undefined */ - addr_size :3, /* bits 9:7 - Address size */ - :1, /* bit 10 - Cleared to 0 */ - operand_size :1, /* bit 11 - Operand size */ - :3, /* bits 14:12 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 30:63 - Undefined */ - }; -} idt_or_gdt_instr_info_t; - -/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ -typedef union ldt_or_tr_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :1, /* bit 2 - Undefined */ - reg1 :4, /* bits 6:3 - Reg1 */ - addr_size :3, /* bits 9:7 - Address size */ - mem_reg :1, /* bit 10 - Mem/Reg */ - :4, /* bits 14:11 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 31:63 - Undefined */ - }; -} ldt_or_tr_instr_info_t; - #endif /* __ASM_X86_HVM_VMX_VMX_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499403.770587 (Exim 4.92) (envelope-from ) id 1pUnnj-0002HS-8v; Wed, 22 Feb 2023 12:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499403.770587; Wed, 22 Feb 2023 12:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnj-0002GG-21; Wed, 22 Feb 2023 12:00:47 +0000 Received: by outflank-mailman (input) for mailman id 499403; Wed, 22 Feb 2023 12:00:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnng-0000FF-Mt for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:44 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8883b747-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:43 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id ec43so28829560edb.8 for ; Wed, 22 Feb 2023 04:00:43 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8883b747-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SKxkFC3sN6rYFx1RlFQZ9txKMSWy7NH5dDU5vh7uVoo=; b=J81GmpsXZP2HRFHWTgxdOsCjFZt6sh4CSK0sZBxmDwDPphpUwhC26DPxjU8/7GW0gr 3XQ814zmWzwrG9g0L1qXQxaXccQAoDig8IFJUeojrZgG5RPbUvTMPnyCwNE8Crm6UYSY p+RariflHrAUBLtFNzk0ZEb/0lWJx4zSBGy/0wGqrGCC1BRJKEoWSTyoyRVaEtwy1+O5 vDJij+1ELHohRVPFd0d89787ovEUPH5lct+h83C2F+t6LrAYTGuDGJkWm64iO1TpuK5r Xb1kMzbBARwWZTqbbOOFv9alFzexxtA0QSpB/jtCSewO2AfuwhGmOf7MkrzklSg0IPO3 nTPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SKxkFC3sN6rYFx1RlFQZ9txKMSWy7NH5dDU5vh7uVoo=; b=OVRRpCgzZ/SGG+ay/wDhVEoZ67U8zeY0XkYtp6tv33nnlXl1xZjqj7+8r4fiEZwhoP M72JP3v+Pu824lUcd53BtbTgdE/CcbeTTYhuvYjGW3lZ8hwSxz098oLTusap2+H5BozC KJZQKCrJCsRQbfRguxdvS+XktAGezhe14niLZju4Q4GVDFc86kSj6Tb2muRua+FwxYHW 3F/GLP6xAZ0/EqkqI4djgL9K3uGgKVqCCvhsXuUP/GYKMo6+v0fkl6BVHIEVDB+mi9u3 8YV2bVetzh2QgLpfmcQrC43Xt4WA+MsaYSmNrl4tg8NuYOGio9ZIerNhZFInPLGSYo4m WMEg== X-Gm-Message-State: AO0yUKWMK5R5lwI8bGVKK5psdCDxFb2NpkX20Ljfwf2rimRHp/qxNp4u U2ne3S5aELnazx87sE3SFjXs74qbyks= X-Google-Smtp-Source: AK7set+YnkscDNljbkWncdvh7jiPZpconVrnLmKRsDczVFSkH1Me8CeCLNUYgI4azccPXUjZuLz3Dg== X-Received: by 2002:a17:906:5651:b0:884:fd73:8053 with SMTP id v17-20020a170906565100b00884fd738053mr14837658ejr.9.1677067242727; Wed, 22 Feb 2023 04:00:42 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 7/9] x86/vmx: remove unused included headers from vmx.c Date: Wed, 22 Feb 2023 14:00:21 +0200 Message-Id: <20230222120023.3004624-8-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/hvm/vpic.h asm/hvm/vpt.h asm/io.h asm/mce.h asm/mem_sharing.h asm/regs.h public/arch-x86/cpuid.h public/hvm/save.h because none of the declarations and macro definitions in them is used. Sort the rest of the headers alphabetically. Signed-off-by: Xenia Ragiadakou --- Changes in v2: -add a blank line between different types of hesders xen/arch/x86/hvm/vmx/vmx.c | 56 +++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 31 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index a19ece90fc..a6ec0a11fb 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -15,52 +15,46 @@ * this program; If not, see . */ +#include #include +#include #include +#include #include #include -#include +#include #include -#include #include -#include -#include -#include -#include -#include -#include -#include +#include + +#include +#include #include -#include +#include +#include #include -#include -#include -#include +#include #include #include +#include +#include #include -#include +#include +#include #include -#include -#include +#include +#include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include #include +#include +#include #include -#include +#include +#include +#include + +#include +#include #include "vmx.h" -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:00:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499405.770598 (Exim 4.92) (envelope-from ) id 1pUnnk-0002Yg-Ms; Wed, 22 Feb 2023 12:00:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499405.770598; Wed, 22 Feb 2023 12:00:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnk-0002Y7-FW; Wed, 22 Feb 2023 12:00:48 +0000 Received: by outflank-mailman (input) for mailman id 499405; Wed, 22 Feb 2023 12:00:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnj-0000FF-ED for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:47 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a9eec1c-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:46 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id s26so29310229edw.11 for ; Wed, 22 Feb 2023 04:00:46 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:46 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a9eec1c-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6pd1IsfmVUdREn+72l4bwA5xZ7W4U+B+UhoBSO74jgE=; b=jWyKf+veZsmd3eCAewTS++qu/E0UeyXv9OpPq7y1RFbQ1VWOh9rgxLvwCbBtlc1OZH P7u/sImEOhlCZo8JeXMB+yoEec4K++xBh86QakWRy39nmkWPebjnDWTGAe0WIs1NaVeD MsocwW0MKPFgZD+vSRdeiRf+itlYRYln7FCaOTgwJ9sCSfNlAGdT2J7U5KWGxkFOsWe4 NX6iYuAIPjG0PCHZ/mmbM1qGBahuRbe5XY0m3TBmV1ymDewmmbmbQ3iFumTT8ASr71XU 9rYiXTv2qoLlLiNanWUXKVxFJJcAa+92G+vHFXmSS66XoIZxJTU8WXZ0KHjj7jGMD6+X NhVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6pd1IsfmVUdREn+72l4bwA5xZ7W4U+B+UhoBSO74jgE=; b=4p/T2o9YBvcEWVfIKCVUT26P/6bgMhCSWJg/xEmHkuWSOWSGn58S+imM/fXh7yw2/5 V+RtcZXfhoGe+cKOHUvjUtsqGmmVaq2jSvH9MtM3alhn2eact3DsJMIKV730cc7J3qnB ZUVrA4QPMbDR/pJlb4vpltPoedICf/KHyhxGGi1HNNFaRH3u/cb8ssFQVWreQaDEideD 9N5TiQj+r+wi5RWCTQRlirxI84UIRoTMDfoie9oBWTQuKp/2MPOhtEiOF+8KL21omfXg rVGoA3E4H+mH+D+ieiVO24nlHpRH7+K5bUQ+cMZWLVEuV7UKGQlDou6jAOmoxln1s+RZ VSwg== X-Gm-Message-State: AO0yUKUp7iJr5EtgcdPWmdz86eK20W7cTKfGIjovf41JD2fP6KGepatF AQ0TK0p0W/mVwoSEzkvOF0p/cN5P+70= X-Google-Smtp-Source: AK7set+0rv8noKcn8UZ+q7u6JZExNgzfSC62/oG5lYFS8qdKZbCXE6opqMRYfhM4q7OAxWihjU8TNA== X-Received: by 2002:a17:907:ea2:b0:88d:33fe:3306 with SMTP id ho34-20020a1709070ea200b0088d33fe3306mr21202519ejc.31.1677067246331; Wed, 22 Feb 2023 04:00:46 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 9/9] x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static Date: Wed, 22 Feb 2023 14:00:23 +0200 Message-Id: <20230222120023.3004624-10-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move vmx_update_debug_state() in vmcs.c because it is used only in this file and limit its scope to this file by declaring it static and removing its declaration from private vmx.h Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove it from the private vmx.h header instead of the global one xen/arch/x86/hvm/vmx/vmcs.c | 12 ++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 12 ------------ xen/arch/x86/hvm/vmx/vmx.h | 1 - 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index bc2acd3063..1492f85213 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1868,6 +1868,18 @@ void vmx_vmentry_failure(void) void noreturn vmx_asm_do_vmentry(void); +static void vmx_update_debug_state(struct vcpu *v) +{ + if ( v->arch.hvm.debug_state_latch ) + v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + else + v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + + vmx_vmcs_enter(v); + vmx_update_exception_bitmap(v); + vmx_vmcs_exit(v); +} + void cf_check vmx_do_resume(void) { struct vcpu *v = current; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 5b210e0db4..ada36d6923 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1610,18 +1610,6 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) vmx_vmcs_exit(v); } -void vmx_update_debug_state(struct vcpu *v) -{ - if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; - else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); - - vmx_vmcs_enter(v); - vmx_update_exception_bitmap(v); - vmx_vmcs_exit(v); -} - static void cf_check vmx_update_guest_cr( struct vcpu *v, unsigned int cr, unsigned int flags) { diff --git a/xen/arch/x86/hvm/vmx/vmx.h b/xen/arch/x86/hvm/vmx/vmx.h index ffc19539bc..7d4ecf6d59 100644 --- a/xen/arch/x86/hvm/vmx/vmx.h +++ b/xen/arch/x86/hvm/vmx/vmx.h @@ -14,7 +14,6 @@ void vmx_intr_assist(void); void noreturn cf_check vmx_do_resume(void); void cf_check vmx_vlapic_msr_changed(struct vcpu *v); void vmx_realmode(struct cpu_user_regs *regs); -void vmx_update_debug_state(struct vcpu *v); void vmx_update_exception_bitmap(struct vcpu *v); void vmx_update_cpu_exec_control(struct vcpu *v); void vmx_update_secondary_exec_control(struct vcpu *v); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:09:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499443.770609 (Exim 4.92) (envelope-from ) id 1pUnvn-0005b6-HS; Wed, 22 Feb 2023 12:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499443.770609; Wed, 22 Feb 2023 12:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnvn-0005az-Ei; Wed, 22 Feb 2023 12:09:07 +0000 Received: by outflank-mailman (input) for mailman id 499443; Wed, 22 Feb 2023 12:09:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUnnl-0000FF-Nx for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:00:49 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b2bd9db-b2a8-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:00:47 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id f13so28811679edz.6 for ; Wed, 22 Feb 2023 04:00:47 -0800 (PST) Received: from uni.router.wind (adsl-161.109.242.137.tellas.gr. [109.242.137.161]) by smtp.googlemail.com with ESMTPSA id br4-20020a170906d14400b008de729c8a03sm2133171ejb.38.2023.02.22.04.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 04:00:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b2bd9db-b2a8-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PT+Ksue1+E+w99TtdgjOaQagRH8S4XRZ2zbUy1hdUfQ=; b=f7sBEFlAiFt8BwckZZSAdepoiq4oPj8xdQ25kOFg8ZFxw4Rq+BOXv9OJkt4tUbntr1 QtzNdDALpmqPGQpYMCymeEg5BhzqbQ3QRrXUd2sRXeXJNPyCTemMQHe9z8KAqmkYnHbs hyhjweiZ1laGMgfRcSU4ugBtrGN6eH09NaL6w8G4fitImlR15Ap/e5Z7pzboDe0fCum8 HmY+J8Q2zTTxCDhDU4rYUZD40uHFtnDg+YX6LKIEF8OkgYXV+NDaS3rpvf+dmLYGAbq6 DijIzH8G9aARQpZXompCj1KQS5pLJJVABd1sAFSGabcTi0hUziSJqkzzwjFHwj3Q1f2U eEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PT+Ksue1+E+w99TtdgjOaQagRH8S4XRZ2zbUy1hdUfQ=; b=W6oAqxKHmB9DiAWUu+SPzHEKe/rQUI1Ka8H79Yfg/MF8pbF2jSKOGaStuEVX3tUSvH +0MdswclU2ZzHZ8RN/ZjlJcL3BXqMXjZtoMVBQY1j7QaeE9BUBBf6DnKtqqrzFZSHtlC 5w2nw3UanSxjf7Z1QxAKKoD3GDqa/aJmKXLbS/wSaYdeXvd3fVwpDdKzymtL3jwdGMqg 1OK7pCEagZRkM3qMrm68ueyoBys3pjMuWVCJj7FCvZMWKQ8uihyyO+jUgz/qbCg3EHuS Ry/cZTUaHRbEvSzRp2OmkOm+52oF6L+GHSDmjt8n+tFSOAenN3xeGn5S53W8VpOwBJe3 0lww== X-Gm-Message-State: AO0yUKViKX1LYldRYWSeRCJTKknJk4urIvYAIPaSyda1c53SrXvWgYTl 2zQH96ENoJf4e1RZArV9dtwO0Yewfvk= X-Google-Smtp-Source: AK7set95xEBEhwxinuF+Ewg4dWtI1668L/9cwbJv7N/Z2epvwFWWYJuaPofhaYeDX2KLOElA8zTF2Q== X-Received: by 2002:a17:906:248c:b0:878:5f35:b8d6 with SMTP id e12-20020a170906248c00b008785f35b8d6mr16771158ejb.51.1677067244443; Wed, 22 Feb 2023 04:00:44 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 8/9] x86/vmx: declare nvmx_enqueue_n2_exceptions() static Date: Wed, 22 Feb 2023 14:00:22 +0200 Message-Id: <20230222120023.3004624-9-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230222120023.3004624-1-burzalodowa@gmail.com> References: <20230222120023.3004624-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reduce the scope of nvmx_enqueue_n2_exceptions() to static because it is used only in this file. Take the opportunity to remove a trailing space. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - none xen/arch/x86/hvm/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index a6ec0a11fb..5b210e0db4 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1908,7 +1908,7 @@ static void cf_check vmx_update_guest_efer(struct vcpu *v) vmx_set_msr_intercept(v, MSR_EFER, VMX_MSR_R); } -void nvmx_enqueue_n2_exceptions(struct vcpu *v, +static void nvmx_enqueue_n2_exceptions(struct vcpu *v, unsigned long intr_fields, int error_code, uint8_t source) { struct nestedvmx *nvmx = &vcpu_2_nvmx(v); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:13:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499473.770619 (Exim 4.92) (envelope-from ) id 1pUo0R-00079J-3E; Wed, 22 Feb 2023 12:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499473.770619; Wed, 22 Feb 2023 12:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo0R-00079C-0b; Wed, 22 Feb 2023 12:13:55 +0000 Received: by outflank-mailman (input) for mailman id 499473; Wed, 22 Feb 2023 12:13:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo0P-000792-GD; Wed, 22 Feb 2023 12:13:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo0P-0001P3-Ct; Wed, 22 Feb 2023 12:13:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo0P-0002UT-2h; Wed, 22 Feb 2023 12:13:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUo0P-0007fL-2C; Wed, 22 Feb 2023 12:13:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zhJjun8BWKzsNt7AOba1Zc4Ut8B9l6CXG7S/GYcfHSA=; b=RdV6+tlGG3Tr93+s5F4X2jofuQ K7DhxG+fRhycNhGF1RHMsqhxfKn+cTP5ZMbBZlH4LKSmAsKcvXmZ5N11r2Uw8Z8ZXSMyPGrOk7Vli 2p7kE0C6mM5Eud74b6gsmuZRiuWDpwTEiUpcOKDDDP1cJIf7HOm8hTHHZQGsXh8mQHTw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 178089: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=110d209263022c6029e398116154562518e4a474 X-Osstest-Versions-That: libvirt=f0c1ce43824f049bb3dea056d4302132d47d24e8 From: osstest service owner Date: Wed, 22 Feb 2023 12:13:53 +0000 flight 178089 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/178089/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 110d209263022c6029e398116154562518e4a474 baseline version: libvirt f0c1ce43824f049bb3dea056d4302132d47d24e8 Last test of basis 177984 2023-02-21 04:18:51 Z 1 days Testing same since 178089 2023-02-22 04:20:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kristina Hanicova Laine Stump Martin Kletzander Pavel Hrdina Peter Krempa Temuri Doghonadze Zhenguo Yao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git f0c1ce4382..110d209263 110d209263022c6029e398116154562518e4a474 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:16:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499481.770631 (Exim 4.92) (envelope-from ) id 1pUo2Y-0007kH-Fe; Wed, 22 Feb 2023 12:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499481.770631; Wed, 22 Feb 2023 12:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo2Y-0007kA-Cx; Wed, 22 Feb 2023 12:16:06 +0000 Received: by outflank-mailman (input) for mailman id 499481; Wed, 22 Feb 2023 12:16:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUo2X-0007k4-0g for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:16:05 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acc9b3a2-b2aa-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 13:16:03 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id j2so7341334wrh.9 for ; Wed, 22 Feb 2023 04:16:03 -0800 (PST) Received: from [10.95.97.18] (54-240-197-228.amazon.com. [54.240.197.228]) by smtp.gmail.com with ESMTPSA id g2-20020a5d4882000000b002c55521903bsm10289016wrq.51.2023.02.22.04.16.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 04:16:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acc9b3a2-b2aa-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:from:to:cc:subject:date:message-id:reply-to; bh=Op3GqQejLWil+XviHMTN9lShBYElpQ9YfeVLRqy5Tio=; b=E8+dEoQiJKdt7O9wrejlauPiWeebG59CqBpg66DBf5a5BJHtHGPwpGiVYcwJ4pQyPA +k1B2GW3fcN7fNIjnWyWFESXLpp5dBZ5wfDH6iQYAKMzoc6jTcb3OHshYG9aBCLRVm2b OkjaKJ7FnURjavzIsLBR7uZ41P6dwTp96XYYgWrws9fReXPAbdH/z2j6JF1ZODQKLvvQ R/De8q0F3yNBxrdD/Co9iSHxm1A+eGtfEe40sZ6+s1cD1kTBD/mC3VR2nbKwtka9ujl7 9KaLhJusvxnUhONpJ0eWL8e7QS+yxcZYIr8CFlD9qSHvOOZ2tdtGYye4F1wp8ARHNTZK l2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Op3GqQejLWil+XviHMTN9lShBYElpQ9YfeVLRqy5Tio=; b=y4XNMLqjgDJejwXJnWZi3qGWMX3zDx6uqfcRmyG5AOwep9lRNwhrL7sAfLqWhjMbI7 2uMXIJpsLXPnTOY0Jc3Y/BkBdAIUshGPR0J2I5m8Ey3vdkAwO40ZD+xHofXUQMZz+/iw HqKO+qZzejAlvUDTEhnZtaKc8hHgYMynav0dkrNptevAFhOJuazYnU0P0BR3I91027Yd 7LVGU3mW877boeDGsBdkSxZI0NvwC2NXd8iuoGj8lRZH0Q1Uj2k8swIuTgy6jGfsijDQ nsvgNLFCHlOoHGumDfZX+l8qdUak3WEQ5nU3fXEsFU8eFXTLVXpjuNHELwWh+QxzjdUt Pejg== X-Gm-Message-State: AO0yUKU+rJd2zBAYRpzlRb4EgUPrv/RwXYpjfZb+vBJrX88qFe1gxbas uFHqQsaZtCSjMpEm76WdMRI= X-Google-Smtp-Source: AK7set+owGjg60Xwb1oOv12YJlBd5+0UfVLCpnwFbMldFB8lqUrN1PmHrgd2QqdzYmChKwauuMrB7w== X-Received: by 2002:a5d:678a:0:b0:2c3:e142:5fd0 with SMTP id v10-20020a5d678a000000b002c3e1425fd0mr7944714wru.49.1677068162486; Wed, 22 Feb 2023 04:16:02 -0800 (PST) From: Paul Durrant X-Google-Original-From: Paul Durrant Message-ID: <307f63c0-b3b5-d424-8a93-d76acc0934f5@xen.org> Date: Wed, 22 Feb 2023 12:16:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: paul@xen.org Subject: Re: Ping: [PATCH 1/6] x86/Hyper-V: use standard C types in hyperv-tlfs.h Content-Language: en-US To: Jan Beulich , Wei Liu Cc: George Dunlap , "xen-devel@lists.xenproject.org" References: <98c3141c-9d49-695e-a936-4e755a4fc527@suse.com> <2def744e-e074-db7f-cb8f-3ec2e6ed273a@suse.com> Organization: Xen Project In-Reply-To: <2def744e-e074-db7f-cb8f-3ec2e6ed273a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/02/2023 13:43, Jan Beulich wrote: > On 09.02.2023 11:38, Jan Beulich wrote: >> This is the only file left with a use of an __s type coming from >> Linux. Since the file has been using an apparently random mix of all >> three classes of fixed-width types (__{s,u}, {s,u}, and >> {,u}int_t), consolidate this to use exclusively standard types. >> >> No functional change intended. >> >> Signed-off-by: Jan Beulich > > Ping? (I'll wait a few more days, but I'm going to commit this eventually > with just Andrew's ack if no maintainer one arrives.) > No objection from me, but I assume the types were as they were because the header was imported. Paul From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:46:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499489.770643 (Exim 4.92) (envelope-from ) id 1pUoWB-0003RC-0d; Wed, 22 Feb 2023 12:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499489.770643; Wed, 22 Feb 2023 12:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUoWA-0003R5-SS; Wed, 22 Feb 2023 12:46:42 +0000 Received: by outflank-mailman (input) for mailman id 499489; Wed, 22 Feb 2023 12:46:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUoW9-0003Qu-4V for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:46:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f238acbb-b2ae-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:46:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7257.eurprd04.prod.outlook.com (2603:10a6:102:93::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 12:46:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 12:46:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f238acbb-b2ae-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZpDamAT6fve8hIM0TSHD1uasQ4yYe2M3BtWbmIOXI/in54UZZds+hFRYbITgtK02oDkTekETQsspi6b5dggWywtNUtApbSGWjO9MWqhCAse7YKs02L47GKeHyREmoAb4yB18po/ti1q26Ml7CKZhJvpDljsyLsiJC+ByxF5ZiWRKQQ+LaPUtg8RguGc5SKCaFLnkM2jXm8WySOWDLmbs2LyEAm9e5K5jCdhhEExshX7tjYJl54ApEx9UrgaX7uk4sQklL0Owv1bFjOIUQOlVxjBw2ns0NHhb4TY+5S2yALKjkce5Xzjvl0dE2FwV3nLAjeCqDTBKZzZVVFG0HR2KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2e2gYccZwIsZm+Te80WpjZ3dxaiEcjm/S7skp/m8/d4=; b=dhePvobic6xRptiR+5CmSlesbuWMuqj8HFXu+MEz71U9vlcqNMNkGUf2UWXQYQdKGttWYNOfrQR6JabViFDy7NHIH3tAPARp4iSII24vxKfoBj+ojpzZgFQrWFVYWuFRIxVabGW+omyZyEbs2aof+X377vxFbTpRtdE1VU0yKnuCK31yJAT+7Gf1VJxKAQBSZydHzpKrd2LMR4No/MeTVZxIvxqap9UuSf4/64pPhqOgbgxuEKe4wSLyIXztN9+gG06CcIyQ7bN7mRSEtKPPw+wIZvqkTKGIAUGsFo6bgux7N+/laM21d9zI7q9xZZBB2iqveraJLWTrwTrNwRsRBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2e2gYccZwIsZm+Te80WpjZ3dxaiEcjm/S7skp/m8/d4=; b=B8ebiim4DGHRJ4kPQU5LtMrULILBwDeglzIEjg/y4J47Lo+PXds1k10IZBDLfi0QYvFW28pQwEq2F2n1hAbAznAPQKynyFbt/gIE62CyOR5ORRVT7icLsX3LjFvADR/HGXPuehvfNwZAsjgZLsi9bRDGFZhPpEj5UvheKea/3bAjZxxhNkZLlKFf6WSxNTi9BpiwFCiLqkiSSPip3WqtgtgLvj+0loYUWiWSZ8FurN+6nQN7z69Rw609veL/WrQXCbdq/IcQMSHn6t/bxJ5rLUvg7cf0Tn40fd8GjYtSfAf/V1V+vVeJaC4XOoK2guOP2ivAx81gz1XiNGzqHd4Gyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <214973b0-5fe7-9208-2cfc-dd2884583157@suse.com> Date: Wed, 22 Feb 2023 13:46:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Kurochko , Andrew Cooper Cc: Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7257:EE_ X-MS-Office365-Filtering-Correlation-Id: c527d5be-d02d-4adf-4ecf-08db14d2c492 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +cdyNd61lT0OyyKkNDIILWBRkPnAOufXFwgbGxct8TzF6p+WiiEtvg7WUTZKEKbz21DtyfwwvXwHiuhitTx+YfrATti5DlBVLyKaHAxDNOWeSITePdDMW76NzRTCmV2hnDwzuV7ZhG/6cqu+QYP9Hkz6bmzKbe9O6y0sEk/gH4dRVxRV6IGuZibI8TvSe9NC7uRMfcgBAmlBA2wxwpkj4ash9CN0EhCwmuxctZnJUylZM/Wa6QVSUJz2CI9zA3drEi2CEfnG6jsRWPlvJScf6Puo5wnYIsHRwSz7zT8Lg1Gvndz9IUuzOHgXNRnKUq567EL5vr8Ifz6UPmK2TM4p0U0nUWuNj370SOrl1+0dg4GAmKW6IqpCHO7fYoSjNhVk9VM4eNXK5IsJytVjjtYbtDDwd+1K95GwRGt5WFR/atM7knulsG88KrHmwPfEsFzjkfCWo3edaldABf5vC0yTaM5EpEE+njJ1vnT4ZgLxLae4T+oVAU7aH93n7k37m4E0lbLCN8bnHfT02QRqWxhcM8ArP7+21gTWk9fHSX2pln1UjGFq4/4J305lyBBQNBY1Phw7tQUaa+j3yycJl8LV/StDSVuoNbc3MCoq8tRHPXZ3jdkM+1IhiUmToL3OvW+MbiCD7CzrkjRg3RAmwOfT/tcE/cjgGxV80FTu9NuKZ6CdHfZ/bjo9jkUTMvLfuQ3pGqJfynTKRGSr8XjRJwnlIEwwGEsuP/4/NiiEX96r/sqPpLsYvd+KYghst3n/1eFH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199018)(86362001)(31696002)(5660300002)(2906002)(31686004)(38100700002)(41300700001)(4326008)(66946007)(66556008)(66476007)(8676002)(316002)(6486002)(36756003)(54906003)(110136005)(26005)(8936002)(6512007)(6506007)(6666004)(53546011)(2616005)(186003)(478600001)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmpnSGlqSy9NYW1rdDAwSVRJS1g4cmh3LzJZdGtJSCtpTE9kWnNOOXo1Zy9n?= =?utf-8?B?OGo1WjRIQnpONXFiblBocUFnN0hpNVBqYUJpQlUrY1R6c3BKd21IcXpBQWow?= =?utf-8?B?d2ZkUmVkNlRQQkNuQkxGZW9XS0JjMnFBenY1QW9MaHRDRE9aQ2xieDloMlIr?= =?utf-8?B?YURVRVVnVjZFTVBDK2pXRzRSS21SVkhCQ2dmMzVYMkE4eERCaGh1d3p5SEh0?= =?utf-8?B?a3dsK2szWndsWmtPdkZ0c2tQY25TaVdVL0g0NXB6cWtCUmJGTnBqSGZuMHZI?= =?utf-8?B?Qks3WTlqcFJCT1p1Qk5COUQ2RFY4alhOMUZNT1I4cUhsQWwvTVdyS2hZbDlv?= =?utf-8?B?aUhsaFhWY0JRVXBXbWwvemhxbGMxUFJtZktOMFJ3Rm5Mbk44OVQ0Q0pjSVEv?= =?utf-8?B?V2dvalU4UTVMWS83QTBSY1Uralc0ZXMxajQzekpLaEFDVFdLWDhMYkZTRC93?= =?utf-8?B?S251c2pWRXJLOHNiRHFycFlPZ2Y3TitsMExJcGJWcUtoUFU4N1pYVWlTdkRu?= =?utf-8?B?bU85WUo2ZEw3ZmF6ZTc2TDRxM0pnSjFJcVltc0EwSGJBSi9EY2ZRRWc3UzNK?= =?utf-8?B?KzJQRzBpRklhVE1ZelZ1NzlRME05UFdsSlJiSTQzMlhlZHdBdFJaWkx4aklZ?= =?utf-8?B?akwrb1NsSHorcktWUTdpZnIxeTIvS05CNlhkVy9NMnYwN0J1RzlJNlRzR1Nz?= =?utf-8?B?QmRZcDVNTkhmbVZCdnFnMS9vT2xhaVRoSm5tTUVJODU0eGNaMXkza1pybTM3?= =?utf-8?B?cXNiaUtXVTRWZHFSNXdneFRmNXVlZkpFN3Z4c3ZadmxyWDNCVWhqMnE3dzRL?= =?utf-8?B?bzBkcW8zVHlFcVgvRVU2Rmx0cWUxalV5Q3dtVnNneTFrREZkVXpPYzdBQXhj?= =?utf-8?B?Qnl1OVMzL0RHa2ovWDRCOGRxUDU1bzFZVzlSLzNuNkdSTlAwUmhoQ0U0OTNk?= =?utf-8?B?L2pBVnZxZGFqNFRLRnBvS2JLUEs0OWdkNS9BdklhTzRrVjZ3NkdJVUhreDFh?= =?utf-8?B?bWRTNHU0VEtpelpwUWM5SXkxZU5oaHpiaUNUSmlYL2xBZ0U3WHYvRkcwcXdh?= =?utf-8?B?eFM1Zmh2NVFiV2RNbGtQMTVpbGV3RkgvUmJBOVZ3ZGZSS2EzK2tMSE1vNG0w?= =?utf-8?B?VlI5YTk0ZlRUVTVoQzlveFRwUzVyUnhtNjdDOGIyVDkyZTd0OXJIaEpMUkZJ?= =?utf-8?B?LzJYVGVTNVNvRmVNemJqVzF5UzE2NzBSbHFVN2c2eWl4dllCcEJheW5nbzZR?= =?utf-8?B?RG96b3JhdGhCb0JtbDdMbEpWTzdUeUZOT0JTMHltejdmcFpRRUxsc1ZQTTgw?= =?utf-8?B?dzR5alYvQUVEUXFrdWh5Vm43M0ZEdUxhOXNsVFQvU2RhWlMxME0wWVdRSUUy?= =?utf-8?B?NDJWY1ZSZWQ0QjZnYXdKRE43RWZvM0Z3KzVkTmo2WlR6a2p5NFZtMDlYY2Vz?= =?utf-8?B?TWJCS3ZXWW1OVU92c3ZRL3BzdnRaNnBmRFg0c1YzdkNkRUIrL3BtUUY4TmhT?= =?utf-8?B?aVlIZlVjOFV1STJVaDcvUjgyZkkxWkZKVVpPdHBZQmltcHE0dkpmM05RL085?= =?utf-8?B?M1MvdHpESkI0OVNZb2dCY3ZlL3Q0ME5lRUg1NU9JTndWTmYyNkdoMDRibkZj?= =?utf-8?B?RGp3UGovYTVjTHZqemlqUklaSi9xaFlzMjdFV014Unc0K0I1amNROVBseDNH?= =?utf-8?B?bFhSaCtuTndVaGVrRHBGSHRucWtxZGhTNmVJSEw1a3FUQnRkL1ZGb1YxT3Ba?= =?utf-8?B?eFd5alMrNHExZGdvam9MRGZ0YzhNMVNSOGRNMHFDMktkRUd4anRXaThrMXBV?= =?utf-8?B?RUc1WUMxQ2tRaVBMazFsMHRxSzhGVFhJc3kxVGFkOXo4S21XeE1DcXNCL25F?= =?utf-8?B?QkxpbmlHR0xSTG14aUg4ZjdWcHh5YjBmdHR3azBDb3grakpXR05VY0RIbkZG?= =?utf-8?B?citBbExBT081T25lZVdSbUVWdmJJZldsckI2d0JtaGZiM25jbEZ3NkV4Unhh?= =?utf-8?B?OGFabjJwcmV1VEdWWjFzYUNJelFMMTJrbGx1eHBFOEF4a2JFWUM1MUFiaVh1?= =?utf-8?B?N2lNOThreFJTbTFtRWhoT25yRFVISmZFMXQvZ2dmSTVveVkyWW9rY2hEUCta?= =?utf-8?Q?tgfgT9EwKOHgpfTJ5/lvSpo9a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c527d5be-d02d-4adf-4ecf-08db14d2c492 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 12:46:07.8542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m8U7Smco0zhsRTu1A+AK1j5RDCXP+9ETNLXfuspKyyZJk46YU+1CPHYt8gzR0bfEe4tqeexjisONv7itzt4IZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7257 On 20.02.2023 17:40, Oleksii Kurochko wrote: > A large part of the content of the bug.h is repeated among all > architectures, so it was decided to create a new config > CONFIG_GENERIC_BUG_FRAME. > > The version of from x86 was taken as the base version. > > The patch introduces the following stuff: > * common bug.h header > * generic implementation of do_bug_frame() > * new config CONFIG_GENERIC_BUG_FRAME > > Signed-off-by: Oleksii Kurochko > > --- > Changes in V2: > - Switch to x86 implementation as generic as it is more compact > ( at least from the point of view of bug frame structure ). > - Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. > - Change the macro bug_loc(b) to avoid the need for a cast: > #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > - Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT > - Make macros related to bug frame structure more generic. > - Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable > between x86 and RISC-V. Hmm, below I see it's really just "MODIFIER". I see two issues with this: For one the name is too generic for something which cannot be #undef-ed after use inside the header. And then it also doesn't really say what is being modified. While ending up longer, how about BUG_ASM_CONST or alike? I also think this should default to something if not overridden by an arch. Perhaps simply to an expansion to nothing (at which point you won't need to define it for RISC-V, aiui). > --- /dev/null > +++ b/xen/common/bug.c > @@ -0,0 +1,113 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include Is this really needed here? > +const struct bug_frame* find_bug_frame(unsigned long pc, unsigned int *id) Is this function going to be needed outside of this CU? IOW why is it not static? Also, nit: Left most star wants changing places with the adjacent blank. > +{ > + const struct bug_frame *bug = NULL; > + const struct virtual_region *region; > + > + region = find_text_region(pc); > + if ( region ) > + { > + for ( *id = 0; *id < BUGFRAME_NR; (*id)++ ) > + { > + const struct bug_frame *b; > + unsigned int i; > + > + for ( i = 0, b = region->frame[*id].bugs; > + i < region->frame[*id].n_bugs; b++, i++ ) > + { > + if ( bug_loc(b) == pc ) > + { > + bug = b; > + goto found; While in the original code the goto is kind of warranted, it isn't really here imo. You can simply "return b" here and ... > + } > + } > + } > + } > + > + found: > + return bug; ... "return NULL" here. That'll allow the function scope "bug" to go away, at which point the inner scope "b" can become "bug". > +} > + > +int handle_bug_frame(const struct cpu_user_regs *regs, > + const struct bug_frame *bug, > + unsigned int id) Nit: Indentation is off by one here. Also same question regarding the lack of static here. > +{ > + const char *prefix = "", *filename, *predicate; > + unsigned long fixup; > + unsigned int lineno; > + > + if ( id == BUGFRAME_run_fn ) > + { > +#ifdef ARM Who or what defines ARM? Anyway, seeing ... > + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; ... this, wouldn't it be better (and independent of the specific arch) if you checked for BUG_FN_REG being defined? Another (#ifdef-free) variant would be to have bug_ptr() take a 2nd argument and then uniformly use ... > +#else > + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); ... this, slightly altered to void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug, regs); > +#endif > + > + fn(regs); > + return 0; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_ptr(bug); > + if ( !is_kernel(filename) && !is_patch(filename) ) > + return -EINVAL; > + fixup = strlen(filename); > + if ( fixup > 50 ) > + { > + filename += fixup - 47; > + prefix = "..."; > + } > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); > + show_execution_state(regs); > + return 0; > + > + case BUGFRAME_bug: > + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); > + > + show_execution_state(regs); > + panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); > + > + case BUGFRAME_assert: > + /* ASSERT: decode the predicate string pointer. */ > + predicate = bug_msg(bug); > + if ( !is_kernel(predicate) ) > + predicate = ""; > + > + printk("Assertion '%s' failed at %s%s:%d\n", > + predicate, prefix, filename, lineno); > + > + show_execution_state(regs); > + panic("Assertion '%s' failed at %s%s:%d\n", > + predicate, prefix, filename, lineno); > + } > + > + return -EINVAL; > +} > + > +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc) > +{ > + const struct bug_frame *bug = NULL; Nit: pointless initializer. You could of course have the assignment below become the initializer here. > + unsigned int id; > + > + bug = find_bug_frame(pc, &id); > + if (!bug) Nit: Style (missing blanks). > --- /dev/null > +++ b/xen/include/xen/bug.h > @@ -0,0 +1,161 @@ > +#ifndef __XEN_BUG_H__ > +#define __XEN_BUG_H__ > + > +#define BUG_DISP_WIDTH 24 > +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > + > +#define BUGFRAME_run_fn 0 > +#define BUGFRAME_warn 1 > +#define BUGFRAME_bug 2 > +#define BUGFRAME_assert 3 > + > +#define BUGFRAME_NR 4 > + > +#ifndef __ASSEMBLY__ > + > +#include > +#include > +#include > +#include > + > +#include Any reason this cannot live ahead of the #ifndef, eliminating the need for an #else further down? > +#ifndef BUG_FRAME_STRUCT > + > +struct bug_frame { > + signed int loc_disp:BUG_DISP_WIDTH; > + unsigned int line_hi:BUG_LINE_HI_WIDTH; > + signed int ptr_disp:BUG_DISP_WIDTH; > + unsigned int line_lo:BUG_LINE_LO_WIDTH; > + signed int msg_disp[]; > +}; > + > +#endif /* BUG_FRAME_STRUCT */ > + > +#ifndef bug_loc > +#define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > +#endif /* bug_loc */ For short #if / #ifdef I don't think such comments are necessary on the #else or #endif; personally I consider such to hamper readability. > +#ifndef bug_ptr > +#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) > +#endif /* bug_ptr */ > + > +#ifndef bug_line > +#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ > + ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ > + BUG_LINE_LO_WIDTH) + \ > + (((b)->line_lo + ((b)->ptr_disp < 0)) & \ > + ((1 << BUG_LINE_LO_WIDTH) - 1))) > +#endif /* bug_line */ > + > +#ifndef bug_msg > +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) > +#endif /* bug_msg */ > + > +#ifndef _ASM_BUGFRAME_TEXT > + > +#define _ASM_BUGFRAME_TEXT(second_frame) \ > + ".Lbug%=:"BUG_INSTR"\n" \ > + ".pushsection .bug_frames.%"MODIFIER"[bf_type], \"a\", @progbits\n" \ You may want to use %progbits here right away, as being the more portable form. > + ".p2align 2\n" \ > + ".Lfrm%=:\n" \ > + ".long (.Lbug%= - .Lfrm%=) + %"MODIFIER"[bf_line_hi]\n" \ > + ".long (%"MODIFIER"[bf_ptr] - .Lfrm%=) + %"MODIFIER"[bf_line_lo]\n" \ > + ".if " #second_frame "\n" \ > + ".long 0, %"MODIFIER"[bf_msg] - .Lfrm%=\n" \ > + ".endif\n" \ > + ".popsection\n" I think I said so in reply to an earlier version already: The moment assembly code moves to a common header, it should be adjusted to be as portable as possible. In particular directives should never start at the beginning of a line, while labels always should. (Whether .long is actually portable is another question, which I'll be happy to leave aside for now.) Also nit (style): The line continuation characters want to all line up. > +#endif /* _ASM_BUGFRAME_TEXT */ > + > +#ifndef _ASM_BUGFRAME_INFO I don't think these two make sense for an arch to define independently. INFO absolutely has to match TEXT, so I think an arch should always define (or not) both together. > +#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > + [bf_type] "i" (type), \ > + [bf_ptr] "i" (ptr), \ > + [bf_msg] "i" (msg), \ > + [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ > + << BUG_DISP_WIDTH), \ > + [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) > + > +#endif /* _ASM_BUGFRAME_INFO */ > + > +#ifndef BUG_FRAME > + > +#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ > + BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ > + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ > + asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ > + :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ > +} while (0) > + > +#endif > + > +#ifndef run_in_exception_handler > + > +/* > + * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, > + * and use a real static inline here to get proper type checking of fn(). > + */ I realize you only copy this comment, but I'm having a hard time seeing the connection to BUILD_BUG_ON() here. Would be nice if the comment was "generalized" in a form that actually can be understood. Andrew? > +#define run_in_exception_handler(fn) \ > + do { \ > + (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ > + BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ > + } while ( 0 ) > + > +#endif /* run_in_exception_handler */ > + > +#ifndef WARN > +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) > +#endif /* WARN */ No real need for the comment here; you also have none below for e.g. BUG(). Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 12:59:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 12:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499497.770653 (Exim 4.92) (envelope-from ) id 1pUoiM-0005PP-4p; Wed, 22 Feb 2023 12:59:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499497.770653; Wed, 22 Feb 2023 12:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUoiM-0005PI-1J; Wed, 22 Feb 2023 12:59:18 +0000 Received: by outflank-mailman (input) for mailman id 499497; Wed, 22 Feb 2023 12:59:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUoiK-0005PC-PA for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 12:59:16 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20617.outbound.protection.outlook.com [2a01:111:f400:7eaf::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5e339c5-b2b0-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 13:59:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9416.eurprd04.prod.outlook.com (2603:10a6:102:2ab::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Wed, 22 Feb 2023 12:59:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 12:59:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5e339c5-b2b0-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5JsBXHElQlS+32LI3jTx78LMzaEYQx5/4VsV1owO5M0RPqzKDO7POVw4FdEKH5RHByYY3vkaJQ4/6oVNiW1V1frmQlXadZeCdz35COKbVoagb3S+JsRbutrSjVJIqtK3S9RerR54Ni/cyaP+bkIlJMp1YM83YvVFd079x+rFLiqpIeg3T5a6IC2P5nE9lommeakMm6lZ6D16ZPq4ScJFd2WwYZlvjtfztl0khZDZJlqXOJdsCrj+yKcFmUEndtdySBiMzRhxhISLaiYkee8y4xZe3SXT/928oD3Q63RuXulD1pQnXZ+dBd6xmO20ZUqofkw3axH9RlX0I18cO6OsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SDi6Bfcv8Lu2yK3u1S8qbcPR/undBb+oSdjV0dUaHUw=; b=L3NTa959cSzifJxBBRGrkhqv1VPu5Ss3yGI2IeleK+YVvlUWSljN3Ote1BuLlwQQzlWRXJNm6P6EoCBp5p6affuYPlXPmZerzcL6Dpp+Xlrqni6QHVam+4ez60kOkhGDkXG5icPizjdgIkzxMzJr6tIf87mODkPkTN7AJxh7dNk+/6GomHlTSIv0rDK2/LAcwnPEuhOM4bHTnOmr85KsrmXTovOONJcCcGCmTzrR+D1bOYasOR5jx5UEAgCxLKY6sxe7fcMhaavOks2iKW65WVEhTfXV60pF8tfnN8E43c6M/Rz8HRE5YkYHIl+Nq+MPBOBqtudO6Z/Vgz9s8BgsFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDi6Bfcv8Lu2yK3u1S8qbcPR/undBb+oSdjV0dUaHUw=; b=uwShq5CfaDNYfYTr24ZlspGg3MxX++F0puLxR7r5OxAnM6Hqd3ZCzOIVSk/Elqs/OrWN6Ir+FFqYGSdPGZ02YfB4n+tE/KZ09dALdrfsAlfsx5ehE1WrAZLH0y9gxzD55v2Xs7pFejo93qoBO8cEEbwdqr81Fh6wJOQ6jSmgDD+KRf8ygOC08NG2QAPNdrR8HsZIsNqjM/HK74iT1epIvW6g2fsUvG4TDMFTU99Jhc0DuWohdGHm7J+0k8g44Uv4ZIc2V5+Mr70C/kuNO2mSGI1eHa0TCDWprurhDp0cDAkQNCBqHh7MhuHQ44eFuTX83AGzuies8Rjflf0LeEGx0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 22 Feb 2023 13:59:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/9] x86/svm: remove unused forward declaration of struct vcpu from svm.h Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230222120023.3004624-1-burzalodowa@gmail.com> <20230222120023.3004624-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230222120023.3004624-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9416:EE_ X-MS-Office365-Filtering-Correlation-Id: e1290341-4748-4a6c-8e40-08db14d498db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E8+12TbASNxtIcQADlZ94ys7LPJsMDl0Q3ffpdJ34GhUvysB9zLk9DtlQKF8sct/U9rxWJiKjBApyfu3HoKJpsVRDDz0NV2opcbK2swJ6XBmux/thzeeG4xIN5TmlINjh6nmdbqFc949jclWEZCdhJS8C4ToKaEvbAODMDaY7JT4TCOMYT4twR6k6lf5W6fciZlTEeQGtU9hxKdnjhHqDwMR8+P6sQQAfQgrpVblujj+/PwKCURgtsiYSnM0/yqWxGxbNAmUpUTRlnGyAS755HKfeoKU9nz5Ibtrue++6vbXLFg+ywCvkr5UxCjNW4TXvg3wTE/1eS+nYud5RKMNrTGXW8DgCB+L4J20BNkg2JQUGu53DPlwoIlD8M0MVJthft6phQkMa4NZ44aDKxu6mp1Uwon1yJPbFTWDhL6fDi2WGH5KuQJbLeNMLSE1yRqxnq2P4/F7BGoGBWDFHC93dH0rv2WZp63MXEilveOKc6hnxLsf/is2Rfm6pB+8fzJsQIcxobQdq6B2D5CkJT+2bycGdBNiLsaBgPmg2Nuxd/AZ9YegeTEUt/FX4n8bkigiB2OF4CKGuVADc9Sm4LR1DAHpm5DCNreL5PnZ2pK9/K37v76/KkRMMaP0KlmPemPJlof87FsQsl6lL2e/rOSnDzHM4eQut9WEIBU5tHjo3dB23N1EJoyQQ7B6OtQ+C215ZXL5cnA+Z07QGLD1Ci4Rdt591KVWDJm4zoo5a34aAgo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199018)(5660300002)(4744005)(41300700001)(2906002)(53546011)(2616005)(54906003)(8936002)(6486002)(6512007)(316002)(186003)(478600001)(4326008)(6916009)(66556008)(26005)(66946007)(6506007)(8676002)(66476007)(31696002)(86362001)(36756003)(38100700002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkJGTE9YRk1wRUpjYjNCNlJFN3VFWHlaUGw1OVFFdXVOOWNwM21KSGp1MU56?= =?utf-8?B?dDdJQjVBOWh1ZTZXU25xTGdqc05ZK1BhRmFnSThyajlpV0RPWnRQVzZ3T3ZT?= =?utf-8?B?ajBlWjcweDB4d3FrODVPM1h5cTZLMksvdndIc01sT2RrNFhUc1Y2ZFNpVXdT?= =?utf-8?B?dmI5Z08wckxpTHNIZVF2VFR1eWpzZU41ZXFmTHNEcFJCVCtBTWdBQWlLd3FK?= =?utf-8?B?MnVwdkxuYU1KWXJvemNNdHBhR05HWTkyKzkvR3dKQkxyRzhEWElGbnVMeG9o?= =?utf-8?B?QUc2YnNicUxsdkFiSTFYRFBJL0h0eE9NUCtMOEJFVkNLK29UZERSK3Yxdy8x?= =?utf-8?B?M1U5ZC9mR0NiamhiT0dBd0NkMzJMdGlWQ0pINzh6d2RZVWF0R1FkOXNFUE8r?= =?utf-8?B?UUlhcmZyZDVOTmJ4d2w5SHB2TjFZRDJpcWxEVG8rVC93akxCbnhrOW9yVE5o?= =?utf-8?B?RW8yWFlKeERDclRwSDVoVkFwdE94VHEyQStRZzgzOUJiSldnUzlyWkh1Si9v?= =?utf-8?B?UEhZR0l4RmhMdW9YaWhITGo0eVd6OFlUR2JnbExWVFl3bjZ4dHJKWTNmdGFY?= =?utf-8?B?bzRHOE9hc241UVIvQlkzUWJSVUlLN0o4UEJSbXY0cW1qZFBNaG9mdTlRc3pr?= =?utf-8?B?TjM4MTB3ZmkwQ2k2MnpwRlBqQ1FzaVJCOXZOK0dXYXdVRjlaM0xDQXNtLzFo?= =?utf-8?B?MEJMU1BsZE41aFlwbWpkYlZvbjBQMWgvTEp5S0Q2akFVb1Vub0hwVm5uRjlq?= =?utf-8?B?RUY5Ni8vb0FESHdESW01bm1EMEJhdXBoQUdYNlZhL01FdkdLTnp3OEUreGxj?= =?utf-8?B?dEYvK00vZ1YySzV6T2Nkb01BUVc2MHpVSUtCNUg5L3Q3emZseUNHUlB4NGVM?= =?utf-8?B?cDF0RTVQZm1nd3NVZDBTaDlwMmYvVEFzZFBaQ2hDS01sWkM1SjFhREtDUUxG?= =?utf-8?B?V2RFUWZKdmNEejdPRDZncnlIVTdpQ1Vtb2VPZFJxZ2lNaGd6Tm42NTUyMmxZ?= =?utf-8?B?Z1dWK09zcXNUdXUxd1Rnb3JRbC9nejB3SUdycE54TVpUNFdPYVRFNzR0cUZi?= =?utf-8?B?MjdhdWpzckVsQndHTnkrWHI4YlFrdE1wblVUcEpmem9oM2hxTU9UcjEzTmdN?= =?utf-8?B?ZU5RaVVyT2kyaXAzbVYycDJCcXE3Rkg0NTA3YlNiRHlIV0Uzc1ZZMG5Uenlk?= =?utf-8?B?eHQydWFJYUUzL0tVUXgrNmY0Q2FSMXF2aHlYOXc4RVBKSDRBU2hOelIxZTNW?= =?utf-8?B?Ykx6Qlh5Q2VNdVJiSFFoMjdZYmk3Y2d6cUxxVG01WmU1ckc1STVrKzJyQlRU?= =?utf-8?B?RCtJQnl0U1ZwUWZlVVBDamF2VXkrNHozOEpua1o1ejdtNDREZFUwZ24vVTgw?= =?utf-8?B?WWhWSWw2V0hJTktxaFJibzVSWDFsZ0s3YnRUTUtpdzkzNHN3WHBiSlVwTlk0?= =?utf-8?B?WDRQUU04OWZETWE3cDgwMklITnk1K3VnMXNRZi9ZMGhBZ1NialArNTdPVUpK?= =?utf-8?B?Y2t6c2hBeXBUMlUrclRueWRkU0RLTFpCODd5OWxEQ2o2NW56dXNvV2NYM1d5?= =?utf-8?B?VUxNQTJHWHJnVS9qVzl5MFVHaEtXOTMxZTRGaG5SWko0d3ZLQUZvTTA3dW80?= =?utf-8?B?SE1Od2F3K2tFRE9BSng3U1BrZjNRSTlzMjdPZlFEQW1qbWJ5VEtNZmN4ek84?= =?utf-8?B?blc3Y0RtWTNPcHpEblRlbnZMT3pEK1lzSWoyNnpnWHNGQ2lZZHdaYWtwVHF4?= =?utf-8?B?TVFpekJsR2xmY2ZRUW54V2dkdklmT0E3OG5mRmE4MWNHN1RRVFNXRHZuMzh1?= =?utf-8?B?aGFYa3h2U2VNZy85RkV2ZlRIM21vVWNwUXFxc3JkQUV6eGtXYTBod2UvT09s?= =?utf-8?B?dTAxK3lYU1pDOGhxeVdodWYrV3ZzMUVGeDhNMVVUWHdkaXgzNEJEUXl3c2l3?= =?utf-8?B?NERWcWl6Uit3bVZnUUpoWUpJNWlYWUM3dWVPaXEzZmZsamJKa3ZvQmFtMEh2?= =?utf-8?B?RVJ4RzRBbHUzekZJMGZXL2h0d2EvQjBpbWdneVkyT0NnZDE0RzhXb3IyUlRK?= =?utf-8?B?blhOeS8xSUx2UnltNnUrYlZIVVpyZG1IZkxZNkgrSEZRWVk1WXVvSUN5aDFQ?= =?utf-8?Q?nITwyu3pviSVz5BeeVxD7zuiH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1290341-4748-4a6c-8e40-08db14d498db X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 12:59:13.5079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cmkoLe6vfWm+LL4l8yH/vmjNMyj+C81Djmlz9QJGWQ0umjO0TQvI5LN5TwBqR6zDpBsORFnpfYE1jiQVoyGqHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9416 On 22.02.2023 13:00, Xenia Ragiadakou wrote: > Remove forward declaration of struct vcpu, that is a leftover since > the removal of svm_update_guest_cr()'s declaration from svm.h. > > Signed-off-by: Xenia Ragiadakou Acked-by: Jan Beulich > Fixes: b158e72abe30 ("x86/hvm: CFI hardening for hvm_funcs") I'm a little puzzled by this (a stray forward decl of a struct isn't really a bug imo), but ... > --- > > Changes in v2: > - leave the forward declaration of struct cpu_user_regs in place, > suggested by Andrew > - add a fixes tag based on Andrew's comment ... I realize you were asked to add it. (As a minor remark, more commonly the Fixes: tag would come ahead of the S-o-b: one, I think.) Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 14:14:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 14:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499505.770664 (Exim 4.92) (envelope-from ) id 1pUpsZ-0006f3-Gj; Wed, 22 Feb 2023 14:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499505.770664; Wed, 22 Feb 2023 14:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUpsZ-0006ew-Dl; Wed, 22 Feb 2023 14:13:55 +0000 Received: by outflank-mailman (input) for mailman id 499505; Wed, 22 Feb 2023 14:13:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUpsY-0006eq-2Q for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 14:13:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ffcb122-b2bb-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 15:13:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ffcb122-b2bb-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677075230; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=CCwb4C4/pVhn/n+dWOWl4tTtfVWWM2Gf7ytY4MuOlVs=; b=F4XyT5lfQDPWGSo7f6xw0D4usctrU7BRxvU7DTGn8GWAnWNzV+UuKT+k Qu26HmfSQNjr7nYE3BU0HWBKWn8y21dz8Jd7PGpyN4aglqJEsb+6UANi2 MnkLJr7L5F8PaL13jtLkcC86ksynari36wnGSPwjY6APPUC74Es/V7VhR s=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 96903000 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:uX4F/6B3zLst7hVW/xnjw5YqxClBgxIJ4kV8jS/XYbTApGgr12MDx mQYDDzQPPeCazf8fot3OoWypkwFuJ7cm9ZhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlC5ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5MhOOUZf0 e0iDhMBZRu63vmR+a2yRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9K4LbHZ4Nxh7wS mTuok3BPiMEOY2myBmF+XP2g/fIj2THR9dHfFG/3qEz2wDCroAJMzUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiGWfohcWVt5UEus7wAKA0KzZ50CeHGdsZjtAY9wvsIkxXy4n0 neAmt+vDjtq2JWeQGiR8bq8pjqoNS8Ya2QFYEc5oRAtuoe55ttp11SWE4glSfTu5jHoJd3u6 y6klRAZlpECt+go266wxAncpAuzr5ecG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl CNawpbDtYjiGbnIzXXQG7tVQNlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM Cc/Ve68jaK/3UdGj4ctPupd6Oxwl8AM8OgJsdiNN7JzjmBZLlPvwc2XTRf4M5rRuEYti7ojH pyQbNyhC30XYYw+kmXpH79BjO56n3hjrY82eXwc5076uYdymVbPEetVWLdwRr1RAFy4TPX9r I8EapriJ+R3W+zieCjHmbP/3nhTRUXX8ave8pQNHsbae1oOJY3UI6OJqV/XU9A/zvs9eyah1 i3VZ3K0P3Km3yafeFXbMS8+AF4tNL4mxU8G0eUXFQ7A8xAejUyHtc/zq7NfkWEbydFe IronPort-HdrOrdr: A9a23:/KZnoaxuYTkR3qUE78YaKrPwFL1zdoMgy1knxilNoH1uA6qlfq +V/cjzuSWVtN9zYgBGpTnjAtjkfZq0z/cciuN9UdjNYOCBghrKEGgI1/qH/9SPIVydygaAvZ 0QDpSWc+eAdGSSSfyKmHjCYqxQvOW6zA== X-IronPort-AV: E=Sophos;i="5.97,318,1669093200"; d="scan'208";a="96903000" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Anthony PERARD , Stefano Stabellini , Michal Orzel , Doug Goldstein Subject: [PATCH] CI: Drop gettext from containers Date: Wed, 22 Feb 2023 14:13:22 +0000 Message-ID: <20230222141322.2376955-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Xen 4.13 is fully out of support now. Drop this legacy build dependency. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Stefano Stabellini CC: Michal Orzel CC: Doug Goldstein --- automation/build/alpine/3.12-arm64v8.dockerfile | 2 -- automation/build/alpine/3.12.dockerfile | 2 -- automation/build/centos/7.dockerfile | 2 -- automation/build/debian/jessie-i386.dockerfile | 2 -- automation/build/debian/jessie.dockerfile | 2 -- automation/build/debian/stretch-i386.dockerfile | 2 -- automation/build/debian/stretch.dockerfile | 2 -- automation/build/debian/unstable-arm64v8.dockerfile | 2 -- automation/build/debian/unstable-i386.dockerfile | 2 -- automation/build/debian/unstable.dockerfile | 2 -- automation/build/fedora/29.dockerfile | 2 -- automation/build/suse/opensuse-leap.dockerfile | 2 -- automation/build/suse/opensuse-tumbleweed.dockerfile | 2 -- automation/build/ubuntu/bionic.dockerfile | 2 -- automation/build/ubuntu/focal.dockerfile | 2 -- automation/build/ubuntu/trusty.dockerfile | 2 -- automation/build/ubuntu/xenial.dockerfile | 2 -- automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile | 2 -- 18 files changed, 36 deletions(-) diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile b/automation/build/alpine/3.12-arm64v8.dockerfile index f8d3927ee3ed..180c978964aa 100644 --- a/automation/build/alpine/3.12-arm64v8.dockerfile +++ b/automation/build/alpine/3.12-arm64v8.dockerfile @@ -20,8 +20,6 @@ RUN apk --no-cache add \ dtc-dev \ flex \ gcc \ - # gettext for Xen < 4.13 - gettext \ git \ iasl \ libaio-dev \ diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile index fbf4aa4d3d63..c847aa82d9e2 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.12.dockerfile @@ -21,8 +21,6 @@ RUN apk --no-cache add \ flex \ g++ \ gcc \ - # gettext for Xen < 4.13 - gettext \ git \ grep \ iasl \ diff --git a/automation/build/centos/7.dockerfile b/automation/build/centos/7.dockerfile index f5264e02d92f..69dcefb2f011 100644 --- a/automation/build/centos/7.dockerfile +++ b/automation/build/centos/7.dockerfile @@ -25,8 +25,6 @@ RUN yum -y update \ python-devel \ libuuid-devel \ pkgconfig \ - # gettext for Xen < 4.13 - gettext \ flex \ bison \ libaio-devel \ diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index 3f86d91f63c6..b152d658d3b3 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -28,8 +28,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 2f19adcad395..1e33e635d2de 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -26,8 +26,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/debian/stretch-i386.dockerfile b/automation/build/debian/stretch-i386.dockerfile index c7840d33ab52..d93f74c979ef 100644 --- a/automation/build/debian/stretch-i386.dockerfile +++ b/automation/build/debian/stretch-i386.dockerfile @@ -29,8 +29,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/debian/stretch.dockerfile b/automation/build/debian/stretch.dockerfile index 30fcc5288dee..2c086b197cba 100644 --- a/automation/build/debian/stretch.dockerfile +++ b/automation/build/debian/stretch.dockerfile @@ -27,8 +27,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/debian/unstable-arm64v8.dockerfile b/automation/build/debian/unstable-arm64v8.dockerfile index 0080c22ba21f..b9b1587f888b 100644 --- a/automation/build/debian/unstable-arm64v8.dockerfile +++ b/automation/build/debian/unstable-arm64v8.dockerfile @@ -26,8 +26,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ libfdt-dev \ bin86 \ diff --git a/automation/build/debian/unstable-i386.dockerfile b/automation/build/debian/unstable-i386.dockerfile index 6ce54a481b07..1c4928b09eb1 100644 --- a/automation/build/debian/unstable-i386.dockerfile +++ b/automation/build/debian/unstable-i386.dockerfile @@ -28,8 +28,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/debian/unstable.dockerfile b/automation/build/debian/unstable.dockerfile index b560337b7a10..6ef28782008c 100644 --- a/automation/build/debian/unstable.dockerfile +++ b/automation/build/debian/unstable.dockerfile @@ -26,8 +26,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/fedora/29.dockerfile b/automation/build/fedora/29.dockerfile index 60a5d722668f..e55b06a4517e 100644 --- a/automation/build/fedora/29.dockerfile +++ b/automation/build/fedora/29.dockerfile @@ -14,8 +14,6 @@ RUN dnf -y install \ python3-devel \ libuuid-devel \ pkgconfig \ - # gettext for Xen < 4.13 - gettext \ flex \ bison \ libaio-devel \ diff --git a/automation/build/suse/opensuse-leap.dockerfile b/automation/build/suse/opensuse-leap.dockerfile index 5e8111f40b13..bac938541215 100644 --- a/automation/build/suse/opensuse-leap.dockerfile +++ b/automation/build/suse/opensuse-leap.dockerfile @@ -22,8 +22,6 @@ RUN zypper install -y --no-recommends \ flex \ gcc \ gcc-c++ \ - # gettext-tools for Xen < 4.13 - gettext-tools \ git \ glib2-devel \ glibc-devel \ diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile index b165c4824536..3e5771fccd2b 100644 --- a/automation/build/suse/opensuse-tumbleweed.dockerfile +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile @@ -22,8 +22,6 @@ RUN zypper install -y --no-recommends \ flex \ gcc \ gcc-c++ \ - # gettext-tools for Xen < 4.13 - gettext-tools \ git \ glib2-devel \ glibc-devel \ diff --git a/automation/build/ubuntu/bionic.dockerfile b/automation/build/ubuntu/bionic.dockerfile index 1e5a27c70f15..e15f54431efb 100644 --- a/automation/build/ubuntu/bionic.dockerfile +++ b/automation/build/ubuntu/bionic.dockerfile @@ -27,8 +27,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/ubuntu/focal.dockerfile b/automation/build/ubuntu/focal.dockerfile index 74655b9876d2..9c851c062073 100644 --- a/automation/build/ubuntu/focal.dockerfile +++ b/automation/build/ubuntu/focal.dockerfile @@ -26,8 +26,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile index b4b2f85e7344..b298a515c611 100644 --- a/automation/build/ubuntu/trusty.dockerfile +++ b/automation/build/ubuntu/trusty.dockerfile @@ -27,8 +27,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/build/ubuntu/xenial.dockerfile b/automation/build/ubuntu/xenial.dockerfile index 82171d856dad..2d2ba3e31f63 100644 --- a/automation/build/ubuntu/xenial.dockerfile +++ b/automation/build/ubuntu/xenial.dockerfile @@ -27,8 +27,6 @@ RUN apt-get update && \ pkg-config \ flex \ bison \ - # gettext for Xen < 4.13 - gettext \ acpica-tools \ bin86 \ bcc \ diff --git a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile b/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile index 7eb1f22940d6..cb8e9e59bb43 100644 --- a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile +++ b/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile @@ -19,8 +19,6 @@ RUN \ apk add dbus && \ apk add bash && \ apk add python2 && \ - # gettext for Xen < 4.13 - apk add gettext && \ apk add zlib && \ apk add ncurses && \ apk add texinfo && \ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 14:21:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 14:21:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499513.770675 (Exim 4.92) (envelope-from ) id 1pUpzk-0008MN-9L; Wed, 22 Feb 2023 14:21:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499513.770675; Wed, 22 Feb 2023 14:21:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUpzk-0008MF-4v; Wed, 22 Feb 2023 14:21:20 +0000 Received: by outflank-mailman (input) for mailman id 499513; Wed, 22 Feb 2023 14:21:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUpzj-0008M9-Cn for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 14:21:19 +0000 Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) by se1-gles-flk1.inumbo.com (Halon) with UTF8SMTPS id 29f2daf6-b2bc-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 15:21:15 +0100 (CET) Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by a36d55857b8a with SMTP id 63f624d9fde7ddb1513bcded (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Wed, 22 Feb 2023 14:21:13 GMT Received: by mail-yb1-f178.google.com with SMTP id z95so8488834ybh.0 for ; Wed, 22 Feb 2023 06:21:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 29f2daf6-b2bc-11ed-93b6-47a8fe42b414 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1677075673; x=1677082873; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=X/L2/m+Rl0wKXf1ngv8ZpwZ0FVqxiDepHcL0dqCUoEE=; b=VYdWKsdBfpwV15rjDtceHfxJ6samnxqQ75xJOvxKXSpuVtMKnKHu3BKp4MTKF9VPYWsKgRYJFgEggqZAwdAOHXXxE8OEhZI3D60FdZlnOP640cVNjn/TInC6N6jprRodPlwx1v1r2DD408tL9ERphyOmsW2Xtcy0KV65f/g0gDnWZHJk5JSkbUrlEVCw0vDFAZMpCaI4ISLh02YsfrQ4gT6bXcTbZ89s1UM4hyFJz1zOyVEwHlpmKVybOk9j5fxiFYRN0peUWcBAT5Te+M63W243O6lglsCbNX7QNxYE19DQ9D8IT0S06kiCOre+ROqr+d0/kDTZLuC8C7FcEXUwoA== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyIyYTNmOCIsInhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyIsImNkODQwIl0= Sender: tamas@tklengyel.com X-Gm-Message-State: AO0yUKUzSLdigl2uULVTo8OM5FHeQqyWN+aqaqDccyk+lYfv+IaRw2/O 59qpwuNiUlVH1WRlhrIWr5Y2mIFLzZ5pqolUtkw= X-Google-Smtp-Source: AK7set9E2kW/UnZ9qFyYabcgRUR3bGDgIlsBLrCguKu364k6DUMmJcEeFuJF+OvkjolBO6t2iZqyRX8TMl1RAb74iPo= X-Received: by 2002:a25:908e:0:b0:891:8ebc:309c with SMTP id t14-20020a25908e000000b008918ebc309cmr1161769ybl.555.1677075673341; Wed, 22 Feb 2023 06:21:13 -0800 (PST) MIME-Version: 1.0 References: <2692e97d-b3d6-6512-bff7-c13941c10cd4@suse.com> <3dc23c64-8058-c9a0-55e2-68f99a6235da@suse.com> In-Reply-To: <3dc23c64-8058-c9a0-55e2-68f99a6235da@suse.com> From: Tamas K Lengyel Date: Wed, 22 Feb 2023 09:20:35 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] x86: Perform mem_sharing teardown before paging teardown To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000c564e905f54a9ba3" --000000000000c564e905f54a9ba3 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 22, 2023 at 5:48 AM Jan Beulich wrote: > > On 21.02.2023 16:59, Tamas K Lengyel wrote: > > On Tue, Feb 21, 2023 at 8:54 AM Jan Beulich wrote: > >> > >> On 15.02.2023 18:07, Tamas K Lengyel wrote: > >>> An assert failure has been observed in p2m_teardown when performing vm > >>> forking and then destroying the forked VM (p2m-basic.c:173). The assert > >>> checks whether the domain's shared pages counter is 0. According to the > >>> patch that originally added the assert (7bedbbb5c31) the p2m_teardown > >>> should only happen after mem_sharing already relinquished all shared > > pages. > >>> > >>> In this patch we flip the order in which relinquish ops are called to > > avoid > >>> tripping the assert. > >>> > >>> Signed-off-by: Tamas K Lengyel > >>> Fixes: e7aa55c0aab3 ("x86/p2m: free the paging memory pool > > preemptively") > >> > >> Especially considering the backporting requirement I'm disappointed to > >> find that you haven't extended the description to explain why this > >> heavier code churn is to be preferred over an adjustment to the offending > >> assertion. As said in reply to v1 - I'm willing to accept arguments > >> towards this being better, but I need to know those arguments. > > > > The assert change as you proposed is hard to understand and will be thus > > harder to maintain. Conceptually sharing being torn down makes sense to > > happen before paging is torn down. > > This is (perhaps) the crucial thing to say. Whereas ... > > > Considering that's how it has been > > before the unfortunate regression I'm fixing here I don't think more > > justification is needed. > > ... I disagree here - that's _not_ how it has been before: paging_teardown() > has always been called first. The regression was with how much of teardown > is performed from there vs at the final stage of domain cleanup. > > I'd be fine adding the "Conceptually ..." sentence to the description when > committing, of course provided you agree. Perfectly fine by me. Thanks, Tamas --000000000000c564e905f54a9ba3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Feb 22, 2023 at 5:48 AM Jan Beulich <jbeulich@suse.com> wrote:
>=
> On 21.02.2023 16:59, Tamas K Lengyel wrote:
> > On Tue, F= eb 21, 2023 at 8:54 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 15.0= 2.2023 18:07, Tamas K Lengyel wrote:
> >>> An assert failure= has been observed in p2m_teardown when performing vm
> >>> = forking and then destroying the forked VM (p2m-basic.c:173). The assert
= > >>> checks whether the domain's shared pages counter is 0= . According to the
> >>> patch that originally added the ass= ert (7bedbbb5c31) the p2m_teardown
> >>> should only happen = after mem_sharing already relinquished all shared
> > pages.
&g= t; >>>
> >>> In this patch we flip the order in whi= ch relinquish ops are called to
> > avoid
> >>> tri= pping the assert.
> >>>
> >>> Signed-off-by: = Tamas K Lengyel <tamas@tklengyel.= com>
> >>> Fixes: e7aa55c0aab3 ("x86/p2m: free t= he paging memory pool
> > preemptively")
> >>
= > >> Especially considering the backporting requirement I'm di= sappointed to
> >> find that you haven't extended the descr= iption to explain why this
> >> heavier code churn is to be pre= ferred over an adjustment to the offending
> >> assertion. As s= aid in reply to v1 - I'm willing to accept arguments
> >> t= owards this being better, but I need to know those arguments.
> ><= br>> > The assert change as you proposed is hard to understand and wi= ll be thus
> > harder to maintain. Conceptually sharing being torn= down makes sense to
> > happen before paging is torn down.
>= ;
> This is (perhaps) the crucial thing to say. Whereas ...
>> > Considering that's how it has been
> > before the = unfortunate regression I'm fixing here I don't think more
> &= gt; justification is needed.
>
> ... I disagree here - that'= ;s _not_ how it has been before: paging_teardown()
> has always been = called first. The regression was with how much of teardown
> is perfo= rmed from there vs at the final stage of domain cleanup.
>
> I&= #39;d be fine adding the "Conceptually ..." sentence to the descr= iption when
> committing, of course provided you agree.

<= /div>
Perfectly fine by me.

Thanks,
= Tamas
--000000000000c564e905f54a9ba3-- From xen-devel-bounces@lists.xenproject.org Wed Feb 22 14:29:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 14:29:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499521.770686 (Exim 4.92) (envelope-from ) id 1pUq7l-0000n6-2P; Wed, 22 Feb 2023 14:29:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499521.770686; Wed, 22 Feb 2023 14:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUq7k-0000mz-V2; Wed, 22 Feb 2023 14:29:36 +0000 Received: by outflank-mailman (input) for mailman id 499521; Wed, 22 Feb 2023 14:29:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUq7j-0000mt-LD for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 14:29:35 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20628.outbound.protection.outlook.com [2a01:111:f400:fe5a::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50fa3b7b-b2bd-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 15:29:29 +0100 (CET) Received: from MW4P220CA0024.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::29) by CO6PR12MB5442.namprd12.prod.outlook.com (2603:10b6:5:35b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 14:29:26 +0000 Received: from CO1NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:303:115:cafe::3c) by MW4P220CA0024.outlook.office365.com (2603:10b6:303:115::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21 via Frontend Transport; Wed, 22 Feb 2023 14:29:26 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1NAM11FT086.mail.protection.outlook.com (10.13.175.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.19 via Frontend Transport; Wed, 22 Feb 2023 14:29:26 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 22 Feb 2023 08:29:25 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Wed, 22 Feb 2023 08:29:24 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50fa3b7b-b2bd-11ed-93b6-47a8fe42b414 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O9/TBGYkv3m+6nhf7S9pZgjMWfdIuPDbxleXux9Ao177tN68WqXADenY220446S/k+9hOjqgp/GfE2Atwh1YM3zw4WrM68FLon1cJ+JNz1zkKey8BKAgwYfNVkesPh4Ihkg+lJp8ASuH9daMAVYBBuqSdys6JcZMwtSb6ljqcAjAhmzuJNJFOc4VKH3Mbcxe1H/wgCqYkNXFEi+qM6I/fAcwdDyeMAuivjXC6vK5lf6XclZ73HdATSbTRcvkcYtx6SGAbJ2iK3CDQtup6W6tBcOwEZYgxn0F483kJ3fYMQ6QyN4l7MRpdytrbpjKZQLa0ETdn4Isz0zIuPa/G+eF4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=36096YKz37QqTUKhSoDa6xhVrBBx0hJAdhfhrB5Pr7s=; b=kgdBTyeKXhXTQILLstukIquQSHV6gV7110yLPl6l1ODlkpl+bT+QD7k30GwyIDPn/3GVQVV6yxpXPU5+sgU5BMN2D0nZ1ucoOtQtk5x9uwkL7DuZU6wsRTFZjQBnfs2UO5YKd7AsUO7x2c6ggkwQTmBBU8KEOkAk6iIPGdtbjbZMWnrvOpzFyskCbCjex2one+2rVF+TQrnkjb7oQdr+rx6XdPxE4Jg3p6ZC/iF9Kpa3/0kzzD32axoosYE39Ls6S/TEdjvyxr5yCRfkxw25xxjW+HcEi9p6wnHCBfu5g7hQXUHsJUTrg6Z0cEJ1QUmutV0+XZ260b5Um8N6l58QOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36096YKz37QqTUKhSoDa6xhVrBBx0hJAdhfhrB5Pr7s=; b=oIqj6yiT4LaYWFQrGfS3jELP/rs6Z7yU0VsYkAxKSVFUmp50/qQjLjBMmA9hYvftmgwG51gA4qRzahbrRIbJ4hpaUcLP0Ugr0KPK6SiV+yw/LZoCo6Q0tFl5JuSwxoWSEglmtoSJdUMs1ktw8Et1Ffxa0sPvp9ISNMmLdocKtLo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Wed, 22 Feb 2023 15:29:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] CI: Drop gettext from containers To: Andrew Cooper , Xen-devel CC: Anthony PERARD , Stefano Stabellini , Doug Goldstein References: <20230222141322.2376955-1-andrew.cooper3@citrix.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230222141322.2376955-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT086:EE_|CO6PR12MB5442:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b030541-d295-4d1d-1a27-08db14e1333e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jt/DkRgnQR3b3/7/TdjTyEpwyzJADSyu3krmGyW6LbY1Vmj7GM1IqCkE1Be4ECPJnUuR4NqV/zxhpyWOYu5iGJ15qK22TzsJgG2/SDty5BBV8EvCvtFHMiiKZyCX1o/oXtcsdO9q93whTH7RfMO2vog4kn+eMx82/Gts6/1p3BG65kf1bCzdjvMG6EsSKVa7O25rw3sO0Wso0GnAbfd/s8bOH0ALfIS2lL3xhQY2u9MvmRxWM8KTIkJnDLfq3l6k6Agy8n6oyMcJnNLbtWH7Kyq3zfkZlCvfs7D+gsZGETNV8qsU/XOzY2yR3vPEMFPC3i24l1B4ni7kM+d64cBHLK6udr1O2fS1f2fGxIzCvvsRGbppziYW0WQRsLLr9btMm72HXvfMPc6f5bi6a0PgOlcoiP8+oYM69F3Yz+8T7zlQ8pU029zkG+m/XMgWRj5GxdyLc+usMMg4BYZUEK6eCbp16cXdSlDklbQAiQ3NhX63INsFtrbkoXhwcvia42+xhuomi5Ozapqj4lKNOqQIThLGolveb+N1cHKgWjF3+QehijUDhw8GmDu2qPoPl79COv3GcsJkuy5CbqSUjtODu89ThjyOt7bHPbbHbIvZAhhS3tTH3/2WGZ/haH9WkgEdFoa2C9wcYCm2aw9xdRYoFNnl6yEcq2eTgHLWEglo2FrT6GuZIMK/L7MJghR3eo/mBg8mYCC4Tf0alYY+nIYNLTYFq7VGTPG9p2G1vKj+68NtWXETwbg86PZbCTYdQyAasexKJup112NSark1RBydEw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199018)(40470700004)(36840700001)(46966006)(44832011)(5660300002)(2906002)(36756003)(426003)(47076005)(26005)(40480700001)(186003)(336012)(2616005)(356005)(36860700001)(81166007)(82740400003)(70586007)(70206006)(316002)(40460700003)(16576012)(8676002)(4326008)(8936002)(558084003)(53546011)(54906003)(86362001)(478600001)(31696002)(110136005)(41300700001)(82310400005)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 14:29:26.0774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b030541-d295-4d1d-1a27-08db14e1333e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5442 Hi Andrew, On 22/02/2023 15:13, Andrew Cooper wrote: > > > Xen 4.13 is fully out of support now. Drop this legacy build dependency. > > Signed-off-by: Andrew Cooper Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:20:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:20:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499529.770697 (Exim 4.92) (envelope-from ) id 1pUquZ-0007ZU-S5; Wed, 22 Feb 2023 15:20:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499529.770697; Wed, 22 Feb 2023 15:20:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUquZ-0007Yr-OO; Wed, 22 Feb 2023 15:20:03 +0000 Received: by outflank-mailman (input) for mailman id 499529; Wed, 22 Feb 2023 15:20:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUquY-0007Mq-GH; Wed, 22 Feb 2023 15:20:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUquY-0005iU-EB; Wed, 22 Feb 2023 15:20:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUquY-0005lC-3x; Wed, 22 Feb 2023 15:20:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUquY-0008EN-3W; Wed, 22 Feb 2023 15:20:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wtH1FVJfdYi80415cKfxTuM5efuX0+sq9r4Z/MLbES4=; b=F4+f0D3sO5M9oXjZ8cifLNROUM N+YN0IfgfvEfjEydVhzu5zVMqrEJ+gSTHLfBnfBUz+BSMzBB/+xOlsR30/XN8hoFxvMv57w1pL5xn /bCD00+PTYFpT4ajSrzuhBX/iHJl17h9+WcD0lfkj78tlwiCRGBGPJKZnwVgN0p9YfZI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178129: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=40c12ba546729fdcc8b6731f675806dc268a5745 X-Osstest-Versions-That: xen=c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd From: osstest service owner Date: Wed, 22 Feb 2023 15:20:02 +0000 flight 178129 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178129/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 40c12ba546729fdcc8b6731f675806dc268a5745 baseline version: xen c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd Last test of basis 178044 2023-02-21 18:00:27 Z 0 days Testing same since 178129 2023-02-22 13:00:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c76e4ff7d5..40c12ba546 40c12ba546729fdcc8b6731f675806dc268a5745 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499538.770719 (Exim 4.92) (envelope-from ) id 1pUr85-0001bl-F8; Wed, 22 Feb 2023 15:34:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499538.770719; Wed, 22 Feb 2023 15:34:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr85-0001be-8c; Wed, 22 Feb 2023 15:34:01 +0000 Received: by outflank-mailman (input) for mailman id 499538; Wed, 22 Feb 2023 15:33:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr83-0001MC-68 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:33:59 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5311e990-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:33:58 +0100 (CET) Received: by mail-lf1-x133.google.com with SMTP id m6so10601552lfq.5 for ; Wed, 22 Feb 2023 07:33:58 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5311e990-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zqvukz9Wc9inONzmuv1uqsHsrEr+5BrdoP3LyiYlJNc=; b=A5wwFKfLIQXuxIScvZsdkXI7TfET/8Br388Cj7wQG+b6a6GmqgTNLaCaxklh0lPUDS nAtT2c9RPmuCRUo9tHO/DoToQ6fM2JSEDsNaDEkka0r2rrTlb8NZTB3yVjfyUE55xwsJ MbWoyYJXmJ78Hfk8KBYdC/1UWDc3CPohkl3MjiC8fbTBmTWDN86nHVwYZOAXt395BHrB 0r1M5lmxpHiviohxpFyo+3w+stRsTSLsQmN+a+WbHu5sZp81OGz1bXzZoeJ8PW82Z2WL qZHrVGIulMCIaK8N750h+PWtKziYA7TTPJGkgAjWklIj8QJSCMfg81WhXynCr5u9e/5R RjLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zqvukz9Wc9inONzmuv1uqsHsrEr+5BrdoP3LyiYlJNc=; b=iMTFeCRCtHmehAD/djPzKFMSCd5OOE06jXql96iy/cty55qYHOkhRomRBX+9qrCGqm Pg4lp26jwBfOY2zsg6xhlQOgYs3664jE5qunbxt3rUJY+sNSOl+Ws1QHAf8sNwZO0tP1 0ARMLhssKwYx2fAyEWvEh86YVRVOymsrzsQJtkm7Klt1NTH5WkEEFxB81W+w2RGKzocZ dU6LX7v9GIKEVajpnGcdo4FBnHMioYCVonKjCQcOEN4Ebu9SSbmgKikaXdu6w/Gk0kx5 gQR+bvhnSIN1oWhxMNPZDkQ46VncnpLtGtnv8IJeAwK+qjFCQs4FSTG80o4r6fnAEKn7 G7uA== X-Gm-Message-State: AO0yUKWE5ozFZ/Il3/8JCAn1AyaHJqb/CKZBbC/w7KaLSo4himpLmzhm DBfNLJqdontwEP7G5zgHAhIy/UwIopDLKx4mLBM= X-Google-Smtp-Source: AK7set+DcuvGaDQ5vp9ctw+TkJQtIbCDGMtu3l/ttC+FbPE+boIAHse0unqWaTs9of2BqAGtALrbeg== X-Received: by 2002:ac2:5234:0:b0:4cb:4374:cc78 with SMTP id i20-20020ac25234000000b004cb4374cc78mr3352349lfl.26.1677080037933; Wed, 22 Feb 2023 07:33:57 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [XEN PATCH v7 04/20] docs: add Arm FF-A mediator Date: Wed, 22 Feb 2023 16:33:01 +0100 Message-Id: <5c588d92cdf23a7355a79bf4b91c7214e5ced197.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describes a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- SUPPORT.md | 7 +++++++ docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index aa1940e55f09..5e0595419684 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -818,6 +818,13 @@ that covers the DMA of the device to be passed through. No support for QEMU backends in a 16K or 64K domain. +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator + + Status, Arm64: Tech Preview + +There are still some code paths where a vCPU may hog a pCPU longer than +necessary. The FF-A mediator is not yet implemented for Arm32. + ### ARM: Guest Device Tree support Status: Supported diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index 024bceeb61b2..ca4fc3e67b0c 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1645,6 +1645,21 @@ in OP-TEE. This feature is a B. +=item B + +B Allow a guest to communicate via FF-A with Secure Partitions +(SP), default false. + +Currently is only a small subset of the FF-A specification supported. Just +enough to communicate with OP-TEE. In general only direct messaging and +sharing memory with one SP. More advanced use cases where memory might be +shared or donated to multple SPs is not supported. + +See L for more +informantion about FF-A. + +This feature is a B. + =back =back -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499541.770737 (Exim 4.92) (envelope-from ) id 1pUr86-0001qB-Nc; Wed, 22 Feb 2023 15:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499541.770737; Wed, 22 Feb 2023 15:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr86-0001nu-9s; Wed, 22 Feb 2023 15:34:02 +0000 Received: by outflank-mailman (input) for mailman id 499541; Wed, 22 Feb 2023 15:34:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr84-0001MC-6N for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:00 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5368d821-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:33:59 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id k14so9541428lfj.7 for ; Wed, 22 Feb 2023 07:33:59 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5368d821-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KI1veJQCzcrc4867Mx0BfEZYRjuokQrrKibNDvguIjM=; b=b9ez+PWmP+J9IWGA/jmj+YSV97dCG8tsXUG6IOwBaO5H6cJ/qSpfYTAeagM9q8rBcx ybA9pfqW/XGjTmxj3MckoVjI4diyDvI0KJpi/udWoV8OMCLPWC17UwAt6hQfHqTqB7hA yXcaEBquUsyPSJ4F59x8YSDyAkcFXqkYRgFNjAjnL/HRkGMlsUO3TIumNXkb+tXhkjTO OlLvZo/sQWK9dj20yMPPvv/n8eQnpIAKYZnsWNjyh5UWrp6OatcUxVErrot0NtzETC1Q /dg0qdr4mQHAoVk6/x3GtLkhK0RiciNZyKLF2YmUgarE6dpWqdP3CxJBjwmhQriEEWE2 DgEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KI1veJQCzcrc4867Mx0BfEZYRjuokQrrKibNDvguIjM=; b=3PDda9sz6rIx3l+JGIqryRwoFHtCqW07hs3LiJz/DgA6R3IL6gGftWOx4/rZt4BLuH Jje/gWFZDk1a5w4US0Ch3S+V+FAu8SqZabJZoxO/IlsNAUSrK2vR1iH4c7cdOuj5Uhzc 4Z4TLJk6X7Wrgmu3eMc+iFmPB1O4UrPHrl3y2tkagobYWxkQ3fM7Qvlthk0W3bYb/HVv KRo4A/LLuu023Zgtd8VDDdhx+cfwKZMyn2pz19TVuae3ZcVcyZY+oT/fD+VMxhRTTtDi lF80eOCEbeizTTFfmiYL8ZwrAkXkVgEUdYr+ShXp6Q3dGDpzpsW+eBmZyWOgaL56yUZo YVEA== X-Gm-Message-State: AO0yUKUaBALXt1B7z9civ0g0OnGmCeWacf9hWUeP4/mR+mJXgYYf5s8P j6Dzd5OgFW0tpixfJETOBf2jMJSfjmA1RL2PmHM= X-Google-Smtp-Source: AK7set8mGAbfiuOZUZFXo+60NODykwSWgKjBA3+5AeEojv6aoHvq/0M/OGv8C5ap23Is/KGNmJDyEg== X-Received: by 2002:a19:ac4d:0:b0:4dc:8409:b214 with SMTP id r13-20020a19ac4d000000b004dc8409b214mr3389448lfc.21.1677080038697; Wed, 22 Feb 2023 07:33:58 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 05/20] xen/arm: ffa: add remaining SMC function IDs Date: Wed, 22 Feb 2023 16:33:02 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds the remaining SMC function IDs from FF-A 1.1 specification. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 824153c9303a..aa6cdbe0a4f9 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -59,7 +59,41 @@ /* Function IDs */ #define FFA_ERROR 0x84000060U #define FFA_SUCCESS_32 0x84000061U +#define FFA_SUCCESS_64 0xC4000061U +#define FFA_INTERRUPT 0x84000062U #define FFA_VERSION 0x84000063U +#define FFA_FEATURES 0x84000064U +#define FFA_RX_ACQUIRE 0x84000084U +#define FFA_RX_RELEASE 0x84000065U +#define FFA_RXTX_MAP_32 0x84000066U +#define FFA_RXTX_MAP_64 0xC4000066U +#define FFA_RXTX_UNMAP 0x84000067U +#define FFA_PARTITION_INFO_GET 0x84000068U +#define FFA_ID_GET 0x84000069U +#define FFA_SPM_ID_GET 0x84000085U +#define FFA_MSG_WAIT 0x8400006BU +#define FFA_MSG_YIELD 0x8400006CU +#define FFA_MSG_RUN 0x8400006DU +#define FFA_MSG_SEND2 0x84000086U +#define FFA_MSG_SEND_DIRECT_REQ_32 0x8400006FU +#define FFA_MSG_SEND_DIRECT_REQ_64 0xC400006FU +#define FFA_MSG_SEND_DIRECT_RESP_32 0x84000070U +#define FFA_MSG_SEND_DIRECT_RESP_64 0xC4000070U +#define FFA_MEM_DONATE_32 0x84000071U +#define FFA_MEM_DONATE_64 0xC4000071U +#define FFA_MEM_LEND_32 0x84000072U +#define FFA_MEM_LEND_64 0xC4000072U +#define FFA_MEM_SHARE_32 0x84000073U +#define FFA_MEM_SHARE_64 0xC4000073U +#define FFA_MEM_RETRIEVE_REQ_32 0x84000074U +#define FFA_MEM_RETRIEVE_REQ_64 0xC4000074U +#define FFA_MEM_RETRIEVE_RESP 0x84000075U +#define FFA_MEM_RELINQUISH 0x84000076U +#define FFA_MEM_RECLAIM 0x84000077U +#define FFA_MEM_FRAG_RX 0x8400007AU +#define FFA_MEM_FRAG_TX 0x8400007BU +#define FFA_MSG_SEND 0x8400006EU +#define FFA_MSG_POLL 0x8400006AU struct ffa_ctx { uint32_t guest_vers; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499537.770707 (Exim 4.92) (envelope-from ) id 1pUr84-0001Ma-3O; Wed, 22 Feb 2023 15:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499537.770707; Wed, 22 Feb 2023 15:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr84-0001MT-0V; Wed, 22 Feb 2023 15:34:00 +0000 Received: by outflank-mailman (input) for mailman id 499537; Wed, 22 Feb 2023 15:33:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr82-0001MC-GP for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:33:58 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 511aef28-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:33:57 +0100 (CET) Received: by mail-lf1-x132.google.com with SMTP id w27so10582924lfu.4 for ; Wed, 22 Feb 2023 07:33:55 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:54 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 511aef28-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oeWtQaC3JHvl+29pYelyweMXbxlYjOwAamRSQUiecqg=; b=SifL+Ye44BVdwX9OQqbEOwDBBvuUDaaGPV8NgFtyEKHTR77C8e9Ib7MswD2hORx3CR J6gvwE9Y3DXsnFMjOoRJRNBO8NCwEmdKDZL8j8zsnVk3SQtW2lAL7H5qZwvU5pQwozWd Elr0bDjST4kbYwRscQcg/IGGatUvJkYvvup/SD7+Q/IuQQwWUvy0s6QaY/QGR3uK5h0o HogP1Ibppq7zCCZ/7M/8l1MkfZqmGtthLXXXP1Qwg9pZhcgOyRxbwkI4CKjPi/VofU3J ak2vEWzR5fJkZq5GzkT6LHKUL/DxvZAKCyadg3cXPe2tQHH3rZSxg+CfPa/O4HLyjyE4 wPRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oeWtQaC3JHvl+29pYelyweMXbxlYjOwAamRSQUiecqg=; b=ljZ1GCnM8y+BMLb+vbwNkiav0Lq8sP0mr55wwA6Ouczj++Skxl6Rn+24SEC1gU2WSD Cy1g2voYdBtu60sPsD0eS/FhXyhE0Vs5VI8s/a+VKmDWD7SEgjpb5SlZwuWvSMcJyJdj +ZM+hFVvaft5VPl+U/2InpufEMOJF4ousE2k2LY3BqZ3Cu29ygSvqSLBfZDmIyqk/8F1 e9/G8ifXAeXjEQ3x1OpqWUl9D90mDJSVozdJgs7ZBQsZll7w8NfjBRPZykIrsqcn9Kmf eUxCq3YfXIkoo2Ljhh6GAzVJpdOPrSsqQQkuZwic09ZaGAzQNCmU5ha1pSMMDFYfniCj A9xw== X-Gm-Message-State: AO0yUKVuGJG87BPMgSADmLPD6FdktFIKdElx4LIOTDFcdfgRPDOu3atv Q4V0MKoCcYnQ9gvWp0ZbptK/AunSTzc0TpTdM2w= X-Google-Smtp-Source: AK7set9ZKkyXjXuW14WrdBSdQEKq16nsolr64pMwzHGxJKq+tIYmPFN/35u2YFGyHLpg9+F2WFHE6Q== X-Received: by 2002:ac2:55b5:0:b0:4b5:7e4c:dcea with SMTP id y21-20020ac255b5000000b004b57e4cdceamr2648612lfg.51.1677080034533; Wed, 22 Feb 2023 07:33:54 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich Subject: [XEN PATCH v7 00/20] Xen FF-A mediator Date: Wed, 22 Feb 2023 16:32:57 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch sets add an FF-A [1] mediator to the TEE mediator framework already present in Xen. The FF-A mediator implements the subset of the FF-A 1.1 specification needed to communicate with OP-TEE using FF-A as transport mechanism instead of SMC/HVC as with the TEE mediator. It allows a similar design in OP-TEE as with the TEE mediator where OP-TEE presents one virtual partition of itself to each guest in Xen. The FF-A mediator is generic in the sense it has nothing OP-TEE specific except that only the subset needed for OP-TEE is implemented so far. The hooks needed to inform OP-TEE that a guest is created or destroyed are part of the FF-A specification. It should be possible to extend the FF-A mediator to implement a larger portion of the FF-A 1.1 specification without breaking with the way OP-TEE is communicated with here. So it should be possible to support any TEE or Secure Partition using FF-A as transport with this mediator. The patches are also available at https://github.com/jenswi-linaro/xen branch "xen_ffa_v7". With help from Bertrand I've intregrated this in a test setup with OP-TEE. Please check prerequisites at https://optee.readthedocs.io/en/latest/building/prerequisites.html My setup is duplicated using: repo init -u https://github.com/jenswi-linaro/manifest.git -m qemu_v8.xml \ -b qemu_xen_ffa repo sync -j8 cd build make -j8 toolchains make -j8 all make run-only Test in dom0 with for instance: xtest 1004 at the prompt. To start up a domu and connect to it do: cd /mnt/host/build/qemu_v8/xen xl create guest_ffa.cfg xl console domu Then test as usual with "xtest 1004". The setup uses the branch "ffa" from https://github.com/jenswi-linaro/xen. That's currently the same as the "xen_ffa_v7" branch, but the "ffa" branch may change later as I update for a new version of the patch set. [1] https://developer.arm.com/documentation/den0077/latest Thanks, Jens v6->v7: * Split some of the larger patches into smaller patches for easier review. For instance, the v6 patch "xen/arm: add a primitive FF-A mediator" has been replaced with: - "xen/arm: add a primitive FF-A mediator" - "tools: add Arm FF-A mediator" - "docs: add Arm FF-A mediator" - "xen/arm: ffa: add remaining SMC function IDs" * Some small fixes in the error path for handle_mem_share() * Switched to SPDX for license in new files. * Fixed comment style issues in "xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers" * Made FFA support UNSUPPORTED in "xen/arm: add a primitive FF-A mediator" * Replaced ffa_get_call_count() with FFA_NR_FUNCS * Update the FFA_MAX_SHM_PAGE_COUNT with a formula instead of a value. * Replaced XEN_ARM_FLAGS_FFA with XEN_DOMCTL_CONFIG_TEE_FFA to minimize impact on struct xen_arch_domainconfig. This works because the FF-A mediator and the OP-TEE mediator will not be used at the same time in by a guest. * Replaced "ffa" boolean in the guest config with a new "ffa" value to the enumeration "tee_type". * Integrated the FF-A mediator in the TEE mediator framework instead of being its own. * Rebased on staging as of 2023-02-16 v5->v6: * Updated "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" commit message and moved the patch right before the patch which needs it. Applied Michal Orzel's R-B tag. * Renamed the guest configuration option "ffa_enabled" to "ffa" and updated the description. * More tools update in "xen/arm: add a primitive FF-A mediator" with the "ffa" option, including golang and ocaml. * Update ffa_domain_init() to return an error if communication with the SPMC can't be established. * Factored out a ffa_domain_destroy() from ffa_relinquish_resources(). * Added ffa_get_call_count() to give an accurate number of FF-A function, updated in each patch as new FF-A functions are added. * Added a flags field in struct xen_arch_domainconfig that replaces the ffa_enabled field. * Made check_mandatory_feature() __init * Replaced a few printk() calls with gprintk() where needed. * Rebased on staging as of 2022-09-14 V4->v5: * Added "xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h" * Added documentation for the "ffa_enabled" guest config flag * Changed to GPL license for xen/arch/arm/ffa.c * Added __read_mostly and const where applicable * Added more describing comments in the code * Moved list of shared memory object ("ffa_mem_list") into the guest context as they are guest specific * Simplified a few of the simple wrapper functions for SMC to SPMC * Added a BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE) since the mediator currently depends on the page size to be same as FFA_PAGE_SIZE (4k). * Added max number of shared memory object per guest and max number of size of each shared memory object * Added helper macros to calculate offsets of different FF-A data structures in the communication buffer instead of relying on pointer arithmetic * Addressed style issues and other comments * Broke the commit "xen/arm: add FF-A mediator" into multiple parts, trying to add a few features at a time as requested * Added a missing call to rxtx_unmap() in ffa_relinquish_resources() * Assignment of "ffa_enabled" is kept as is until I have something definitive on the type etc. * Tested with CONFIG_DEBUG=y v3->v4: * Missed v3 and sent a v4 instead by mistake. v2->v3: * Generates offsets into struct arm_smccc_1_2_regs with asm-offsets.c in order to avoid hard coded offsets in the assembly function arm_smccc_1_2_smc() * Adds an entry in SUPPORT.md on the FF-A status * Adds a configuration variable "ffa_enabled" to tell if FF-A should be enabled for a particular domu guest * Moves the ffa_frag_list for fragmented memory share requests into struct ffa_ctx instead to keep it per guest in order to avoid mixups and simplify locking * Adds a spinlock to struct ffa_ctx for per guest locking * Addressing style issues and suggestions * Uses FFA_FEATURES to check that all the needed features are available before initializing the mediator * Rebased on staging as of 2022-06-20 v1->v2: * Rebased on staging to resolve some merge conflicts as requested Jens Wiklander (20): xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers xen/arm: tee: add a primitive FF-A mediator tools: add Arm FF-A mediator docs: add Arm FF-A mediator xen/arm: ffa: add remaining SMC function IDs xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET xen/arm: ffa: add defines for framework direct request/response messages xen/arm: ffa: note dependency on 4k pages xen/arm: ffa: add support for FFA_ID_GET xen/arm: ffa: add direct request support xen/arm: ffa: map SPMC rx/tx buffers xen/arm: ffa: send guest events to Secure Partitions xen/arm: ffa: support mapping guest RX/TX buffers xen/arm: ffa: support guest FFA_PARTITION_INFO_GET xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h xen/arm: ffa: add defines for sharing memory xen/arm: ffa: add ABI structs for sharing memory xen/arm: ffa: support sharing memory xen/arm: ffa: add support to reclaim shared memory xen/arm: ffa: support sharing large memory ranges SUPPORT.md | 7 + docs/man/xl.cfg.5.pod.in | 15 + tools/libs/light/libxl_arm.c | 3 + tools/libs/light/libxl_types.idl | 3 +- xen/arch/arm/arm64/asm-offsets.c | 9 + xen/arch/arm/arm64/smc.S | 42 + xen/arch/arm/include/asm/domain.h | 2 +- xen/arch/arm/include/asm/psci.h | 4 + xen/arch/arm/include/asm/regs.h | 12 + xen/arch/arm/include/asm/smccc.h | 40 + xen/arch/arm/include/asm/tee/ffa.h | 35 + xen/arch/arm/tee/Kconfig | 11 + xen/arch/arm/tee/Makefile | 1 + xen/arch/arm/tee/ffa.c | 1839 ++++++++++++++++++++++++++++ xen/arch/arm/tee/optee.c | 11 - xen/arch/arm/vsmc.c | 19 +- xen/include/public/arch-arm.h | 1 + 17 files changed, 2037 insertions(+), 17 deletions(-) create mode 100644 xen/arch/arm/include/asm/tee/ffa.h create mode 100644 xen/arch/arm/tee/ffa.c -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499539.770724 (Exim 4.92) (envelope-from ) id 1pUr85-0001dt-Oi; Wed, 22 Feb 2023 15:34:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499539.770724; Wed, 22 Feb 2023 15:34:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr85-0001cu-Ha; Wed, 22 Feb 2023 15:34:01 +0000 Received: by outflank-mailman (input) for mailman id 499539; Wed, 22 Feb 2023 15:33:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr83-0001MH-Kj for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:33:59 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50f65889-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:33:55 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id w27so10582964lfu.4 for ; Wed, 22 Feb 2023 07:33:56 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50f65889-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ibm5vTCF8Joq270sdlVxryR5ZCLMLLfQMKzjgKlN6DY=; b=wRVF7YizhkRn9nUAGgaCmHQuX6WNYy5/1oDuW4uuCegBbsJWedRwekbKr8MU8MJVQe n88ECzGOtoGhPcN5JvYmrhutBupt1zYH8q5SLPwYgYIKwhOmiJcOHcJGIs2AmJ1OAmYV Hti1rWLWr9ZI5LjIiGJsrnzHJN2UPZMaYp/Zotly4RKnKkuU87G/4dSORQqbwwoJjmjf NlJQEJT7VMZ/gYh/IUtZzVb3UBr7I3hsFPu/NwL1C9GjqhTGWzQG3quRGMAN7EMp8Osu t4GO3ZAy/9USiu8KlCwJPPZ3B3DvBqDhlhqPi/L8+O5+3rW1bSDW9bL+JAFtsGwwdF6P QFbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ibm5vTCF8Joq270sdlVxryR5ZCLMLLfQMKzjgKlN6DY=; b=H3V2r189R/kXKUOcmohB2tr3VLBKKoSXDNoGTzdINLiqYKWBKaQrPmWFP95R5OUKgE bzYeIE/WL4Z+q8p/2MAPKjJeKk3kgKiAjKSjclrlIeFwp0QNI+1wOlVlai/dgqCx4K6n 0284F0Q8yY440T5V5OGVaJ4e+m3kjt5z+VtWteJITPyTVFBkKw4ChIrp+D7HnXJUDa/F j6L2tkKzr68nsgFsyvLu15eWcb2XRNPuWPvFwrQ7FjfZ5+48UEluZ5nLqzJYXjVv3Njg qmEE524DjVHVSpuvZ5SvanAPr+IojPMJBsrBs6tLLLga5mtWZ7F/zx77pOR9Yhq+/fVa 6HQw== X-Gm-Message-State: AO0yUKUheNUnG6Bdx7UlMks+IaR7i038AVeLPUPl9tdpz12OhZgpsuoT ZajLYyAJUWqXOvylAD3RhJLAkepH7pzc8d/NjU8= X-Google-Smtp-Source: AK7set8IyNbdN1JqtHC+inBoApaGbt/v+7RKn27kEmbic8++PN1Is1ZsWBBoYL2JWOwXB4wrfMdC6A== X-Received: by 2002:ac2:5308:0:b0:4dc:8366:2ea0 with SMTP id c8-20020ac25308000000b004dc83662ea0mr3013987lfh.5.1677080035438; Wed, 22 Feb 2023 07:33:55 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Luca Fancellu Subject: [XEN PATCH v7 01/20] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Date: Wed, 22 Feb 2023 16:32:58 +0100 Message-Id: <13719ab3736160259ad9245d5d5b5071b8933194.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SMCCC v1.2 [1] AArch64 allows x0-x17 to be used as both parameter registers and result registers for the SMC and HVC instructions. Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as parameter and result registers. Let us add new interface to support this extended set of input/output registers. This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 extended input/output registers") by Sudeep Holla from the Linux kernel The SMCCC version reported to the VM is bumped to 1.2 in order to support handling FF-A messages. [1] https://developer.arm.com/documentation/den0028/c/?lang=en Reviewed-by: Luca Fancellu Signed-off-by: Jens Wiklander --- xen/arch/arm/arm64/asm-offsets.c | 9 +++++++ xen/arch/arm/arm64/smc.S | 42 ++++++++++++++++++++++++++++++++ xen/arch/arm/include/asm/smccc.h | 40 ++++++++++++++++++++++++++++++ xen/arch/arm/vsmc.c | 2 +- 4 files changed, 92 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/asm-offsets.c b/xen/arch/arm/arm64/asm-offsets.c index 7226cd9b2eb0..7adb67a1b81a 100644 --- a/xen/arch/arm/arm64/asm-offsets.c +++ b/xen/arch/arm/arm64/asm-offsets.c @@ -57,6 +57,15 @@ void __dummy__(void) BLANK(); OFFSET(SMCCC_RES_a0, struct arm_smccc_res, a0); OFFSET(SMCCC_RES_a2, struct arm_smccc_res, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X0_OFFS, struct arm_smccc_1_2_regs, a0); + OFFSET(ARM_SMCCC_1_2_REGS_X2_OFFS, struct arm_smccc_1_2_regs, a2); + OFFSET(ARM_SMCCC_1_2_REGS_X4_OFFS, struct arm_smccc_1_2_regs, a4); + OFFSET(ARM_SMCCC_1_2_REGS_X6_OFFS, struct arm_smccc_1_2_regs, a6); + OFFSET(ARM_SMCCC_1_2_REGS_X8_OFFS, struct arm_smccc_1_2_regs, a8); + OFFSET(ARM_SMCCC_1_2_REGS_X10_OFFS, struct arm_smccc_1_2_regs, a10); + OFFSET(ARM_SMCCC_1_2_REGS_X12_OFFS, struct arm_smccc_1_2_regs, a12); + OFFSET(ARM_SMCCC_1_2_REGS_X14_OFFS, struct arm_smccc_1_2_regs, a14); + OFFSET(ARM_SMCCC_1_2_REGS_X16_OFFS, struct arm_smccc_1_2_regs, a16); } /* diff --git a/xen/arch/arm/arm64/smc.S b/xen/arch/arm/arm64/smc.S index 91bae62dd4d2..fc6b676e2ee3 100644 --- a/xen/arch/arm/arm64/smc.S +++ b/xen/arch/arm/arm64/smc.S @@ -27,3 +27,45 @@ ENTRY(__arm_smccc_1_0_smc) stp x2, x3, [x4, #SMCCC_RES_a2] 1: ret + +/* + * void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + * struct arm_smccc_1_2_regs *res) + */ +ENTRY(arm_smccc_1_2_smc) + /* Save `res` and free a GPR that won't be clobbered by SMC call */ + stp x1, x19, [sp, #-16]! + + /* Ensure `args` won't be clobbered while loading regs in next step */ + mov x19, x0 + + /* Load the registers x0 - x17 from the struct arm_smccc_1_2_regs */ + ldp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + ldp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + ldp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + ldp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + ldp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + ldp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + ldp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + ldp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + ldp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + smc #0 + + /* Load the `res` from the stack */ + ldr x19, [sp] + + /* Store the registers x0 - x17 into the result structure */ + stp x0, x1, [x19, #ARM_SMCCC_1_2_REGS_X0_OFFS] + stp x2, x3, [x19, #ARM_SMCCC_1_2_REGS_X2_OFFS] + stp x4, x5, [x19, #ARM_SMCCC_1_2_REGS_X4_OFFS] + stp x6, x7, [x19, #ARM_SMCCC_1_2_REGS_X6_OFFS] + stp x8, x9, [x19, #ARM_SMCCC_1_2_REGS_X8_OFFS] + stp x10, x11, [x19, #ARM_SMCCC_1_2_REGS_X10_OFFS] + stp x12, x13, [x19, #ARM_SMCCC_1_2_REGS_X12_OFFS] + stp x14, x15, [x19, #ARM_SMCCC_1_2_REGS_X14_OFFS] + stp x16, x17, [x19, #ARM_SMCCC_1_2_REGS_X16_OFFS] + + /* Restore original x19 */ + ldp xzr, x19, [sp], #16 + ret diff --git a/xen/arch/arm/include/asm/smccc.h b/xen/arch/arm/include/asm/smccc.h index b3dbeecc90ad..1adcd37443c7 100644 --- a/xen/arch/arm/include/asm/smccc.h +++ b/xen/arch/arm/include/asm/smccc.h @@ -33,6 +33,7 @@ #define ARM_SMCCC_VERSION_1_0 SMCCC_VERSION(1, 0) #define ARM_SMCCC_VERSION_1_1 SMCCC_VERSION(1, 1) +#define ARM_SMCCC_VERSION_1_2 SMCCC_VERSION(1, 2) /* * This file provides common defines for ARM SMC Calling Convention as @@ -265,6 +266,45 @@ void __arm_smccc_1_0_smc(register_t a0, register_t a1, register_t a2, else \ arm_smccc_1_0_smc(__VA_ARGS__); \ } while ( 0 ) + +/* + * struct arm_smccc_1_2_regs - Arguments for or Results from SMC call + * @a0-a17 argument values from registers 0 to 17 + */ +struct arm_smccc_1_2_regs { + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; + unsigned long a4; + unsigned long a5; + unsigned long a6; + unsigned long a7; + unsigned long a8; + unsigned long a9; + unsigned long a10; + unsigned long a11; + unsigned long a12; + unsigned long a13; + unsigned long a14; + unsigned long a15; + unsigned long a16; + unsigned long a17; +}; + +/* + * arm_smccc_1_2_smc() - make SMC calls + * @args: arguments passed via struct arm_smccc_1_2_regs + * @res: result values via struct arm_smccc_1_2_regs + * + * This function is used to make SMC calls following SMC Calling Convention + * v1.2 or above. The content of the supplied param are copied from the + * structure to registers prior to the SMC instruction. The return values + * are updated with the content from registers on return from the SMC + * instruction. + */ +void arm_smccc_1_2_smc(const struct arm_smccc_1_2_regs *args, + struct arm_smccc_1_2_regs *res); #endif /* CONFIG_ARM_64 */ #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index 7335276f3fa1..cd68fa80e98a 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -85,7 +85,7 @@ static bool handle_arch(struct cpu_user_regs *regs) switch ( fid ) { case ARM_SMCCC_VERSION_FID: - set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_1); + set_user_reg(regs, 0, ARM_SMCCC_VERSION_1_2); return true; case ARM_SMCCC_ARCH_FEATURES_FID: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499540.770727 (Exim 4.92) (envelope-from ) id 1pUr85-0001jD-VE; Wed, 22 Feb 2023 15:34:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499540.770727; Wed, 22 Feb 2023 15:34:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr85-0001fk-Qv; Wed, 22 Feb 2023 15:34:01 +0000 Received: by outflank-mailman (input) for mailman id 499540; Wed, 22 Feb 2023 15:34:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr83-0001MH-V8 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:00 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 518898e9-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:33:56 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id w27so10583020lfu.4 for ; Wed, 22 Feb 2023 07:33:56 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 518898e9-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ZsjNSv3BszwMRlZ3430f1yrOpOpDXzM9fMCdGNbTzc=; b=BIq73+5buxXluU82WKlUW/WkRfEhf2NGWpvWB7eFKDakZ9a0NK1xttUZuQLUbSy53x 3qMp5eYpS+922Ioc4H6ovetIJtTwjO6Sr90NMjW+JeT1vVA6GatO0bcSfb1iB1y5Wuli G9vG2m3RDsnYE5M7xKjyVjXFT2joNgz00pLx8EUxkQnQi3+ecoKqUgje5JlyJq7ynOFY 6aetXU/Yjzh7wYAyCt+yS78E+kPdySk+5mQOqA4Q/nVoo0cxpo7jU7gHHcjGlVsADlOx UAcZNVja1R6KetSU/oneOtbvZaXC0kguKoMoBP7ZufnaG8TDIGqj2eGAF+TO7Rz2wn1T AV4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ZsjNSv3BszwMRlZ3430f1yrOpOpDXzM9fMCdGNbTzc=; b=8MaZlQ/+FaKpTo+M+y9jhWlW8BsJfHgHuZmCMCZ4A496wIe9zTwsJXM127PpjOJsuY aCu3MyNAQx08OfwG+/I39Ic+ZrWW68tq07qUHJ1BlH5BcuFvXHI5eIapl5v0ADdkzGDk pEEduWSHAh6LrOOpv596+uSq+zmIYTHNELH0mGRBoF7ry27wzsZ84hKMRc0F30KWc7kF bBhMZnJiGF+mA9bEjZmbteu4TWmTN+Pk6j1CHSWKqO7GshkyYt5ZGsvbSMUQIcrmZOiU 0kMiClIzaQucogZTs4xa+BNqOyoW6sPiDxpAUSfaG+0t34zNGS+IC/9aVlWauKkQlnOl DBww== X-Gm-Message-State: AO0yUKWr217Gm+tcBEptisg/2OCiRU7sylJ0HcwNMstgck48iiHxpFEu 9/zSmi/XPTa+1Lvwk4nW4cJj+Nc2xwsWm8gvJMs= X-Google-Smtp-Source: AK7set9riMwQZMLprPrPH8sv4ujWvOXUCd5+6lnZiau7TuboZfgOu1DHlL74ZRYowGtdO7JjwnwicQ== X-Received: by 2002:a19:550e:0:b0:4db:456a:9a1 with SMTP id n14-20020a19550e000000b004db456a09a1mr2892389lfe.66.1677080036259; Wed, 22 Feb 2023 07:33:56 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH v7 02/20] xen/arm: tee: add a primitive FF-A mediator Date: Wed, 22 Feb 2023 16:32:59 +0100 Message-Id: <5f0a74b3e4f6cda56e780a739859537246d4892f.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a FF-A version 1.1 [1] mediator to communicate with a Secure Partition in secure world. This commit brings in only the parts needed to negotiate FF-A version number with guest and SPMC. [1] https://developer.arm.com/documentation/den0077/e Signed-off-by: Jens Wiklander --- xen/arch/arm/include/asm/domain.h | 2 +- xen/arch/arm/include/asm/psci.h | 4 + xen/arch/arm/include/asm/tee/ffa.h | 35 +++++ xen/arch/arm/tee/Kconfig | 11 ++ xen/arch/arm/tee/Makefile | 1 + xen/arch/arm/tee/ffa.c | 217 +++++++++++++++++++++++++++++ xen/arch/arm/vsmc.c | 17 ++- xen/include/public/arch-arm.h | 1 + 8 files changed, 284 insertions(+), 4 deletions(-) create mode 100644 xen/arch/arm/include/asm/tee/ffa.h create mode 100644 xen/arch/arm/tee/ffa.c diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index 0e310601e846..754daa8efa04 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -110,7 +110,7 @@ struct arch_domain struct vpl011 vpl011; #endif -#ifdef CONFIG_TEE +#if defined(CONFIG_TEE) || defined(CONFIG_FFA) void *tee; #endif diff --git a/xen/arch/arm/include/asm/psci.h b/xen/arch/arm/include/asm/psci.h index 832f77afff3a..4780972621bb 100644 --- a/xen/arch/arm/include/asm/psci.h +++ b/xen/arch/arm/include/asm/psci.h @@ -24,6 +24,10 @@ void call_psci_cpu_off(void); void call_psci_system_off(void); void call_psci_system_reset(void); +/* Range of allocated PSCI function numbers */ +#define PSCI_FNUM_MIN_VALUE _AC(0,U) +#define PSCI_FNUM_MAX_VALUE _AC(0x1f,U) + /* PSCI v0.2 interface */ #define PSCI_0_2_FN32(nr) ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ ARM_SMCCC_CONV_32, \ diff --git a/xen/arch/arm/include/asm/tee/ffa.h b/xen/arch/arm/include/asm/tee/ffa.h new file mode 100644 index 000000000000..94960100718e --- /dev/null +++ b/xen/arch/arm/include/asm/tee/ffa.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: MIT */ +/* + * xen/arch/arm/include/asm/tee/ffa.h + * + * Arm Firmware Framework for ARMv8-A(FFA) mediator + * + * Copyright (C) 2023 Linaro Limited + */ + +#ifndef __ASM_ARM_TEE_FFA_H__ +#define __ASM_ARM_TEE_FFA_H__ + +#include +#include + +#include +#include + +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) + +static inline bool is_ffa_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; +} + +#ifdef CONFIG_FFA +#define FFA_NR_FUNCS (9 + (IS_ENABLED(CONFIG_ARM_64) ? 3 : 0) ) +#else +#define FFA_NR_FUNCS 0 +#endif + +#endif /*__ASM_ARM_TEE_FFA_H__*/ diff --git a/xen/arch/arm/tee/Kconfig b/xen/arch/arm/tee/Kconfig index 392169b2559d..923f08ba8cb7 100644 --- a/xen/arch/arm/tee/Kconfig +++ b/xen/arch/arm/tee/Kconfig @@ -8,3 +8,14 @@ config OPTEE virtualization-enabled OP-TEE present. You can learn more about virtualization for OP-TEE at https://optee.readthedocs.io/architecture/virtualization.html + +config FFA + bool "Enable FF-A mediator support (UNSUPPORTED)" if UNSUPPORTED + default n + depends on ARM_64 + help + This option enables a minimal FF-A mediator. The mediator is + generic as it follows the FF-A specification [1], but it only + implements a small subset of the specification. + + [1] https://developer.arm.com/documentation/den0077/latest diff --git a/xen/arch/arm/tee/Makefile b/xen/arch/arm/tee/Makefile index 982c87968447..58a1015e40e0 100644 --- a/xen/arch/arm/tee/Makefile +++ b/xen/arch/arm/tee/Makefile @@ -1,2 +1,3 @@ +obj-$(CONFIG_FFA) += ffa.o obj-y += tee.o obj-$(CONFIG_OPTEE) += optee.o diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c new file mode 100644 index 000000000000..824153c9303a --- /dev/null +++ b/xen/arch/arm/tee/ffa.c @@ -0,0 +1,217 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/arch/arm/tee/ffa.c + * + * Arm Firmware Framework for ARMv8-A (FF-A) mediator + * + * Copyright (C) 2023 Linaro Limited + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +/* Error codes */ +#define FFA_RET_OK 0 +#define FFA_RET_NOT_SUPPORTED -1 +#define FFA_RET_INVALID_PARAMETERS -2 +#define FFA_RET_NO_MEMORY -3 +#define FFA_RET_BUSY -4 +#define FFA_RET_INTERRUPTED -5 +#define FFA_RET_DENIED -6 +#define FFA_RET_RETRY -7 +#define FFA_RET_ABORTED -8 + +/* FFA_VERSION helpers */ +#define FFA_VERSION_MAJOR_SHIFT 16U +#define FFA_VERSION_MAJOR_MASK 0x7FFFU +#define FFA_VERSION_MINOR_SHIFT 0U +#define FFA_VERSION_MINOR_MASK 0xFFFFU +#define MAKE_FFA_VERSION(major, minor) \ + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ + ((minor) & FFA_VERSION_MINOR_MASK)) + +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) + +/* + * This is the version we want to use in communication with guests and SPs. + * During negotiation with a guest or a SP we may need to lower it for + * that particular guest or SP. + */ +#define FFA_MY_VERSION_MAJOR 1U +#define FFA_MY_VERSION_MINOR 1U +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ + FFA_MY_VERSION_MINOR) + +/* Function IDs */ +#define FFA_ERROR 0x84000060U +#define FFA_SUCCESS_32 0x84000061U +#define FFA_VERSION 0x84000063U + +struct ffa_ctx { + uint32_t guest_vers; +}; + +/* Negotiated FF-A version to use with the SPMC */ +static uint32_t ffa_version __ro_after_init; + +static bool ffa_get_version(uint32_t *vers) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_VERSION, + .a1 = FFA_MY_VERSION, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) + { + gprintk(XENLOG_ERR, "ffa: FFA_VERSION returned not supported\n"); + return false; + } + + *vers = resp.a0; + + return true; +} + +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, + register_t v2, register_t v3, register_t v4, register_t v5, + register_t v6, register_t v7) +{ + set_user_reg(regs, 0, v0); + set_user_reg(regs, 1, v1); + set_user_reg(regs, 2, v2); + set_user_reg(regs, 3, v3); + set_user_reg(regs, 4, v4); + set_user_reg(regs, 5, v5); + set_user_reg(regs, 6, v6); + set_user_reg(regs, 7, v7); +} + +static void handle_version(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + uint32_t vers = get_user_reg(regs, 1); + + if ( vers < FFA_VERSION_1_1 ) + vers = FFA_VERSION_1_0; + else + vers = FFA_VERSION_1_1; + + ctx->guest_vers = vers; + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); +} + +static bool ffa_handle_call(struct cpu_user_regs *regs) +{ + uint32_t fid = get_user_reg(regs, 0); + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx ) + return false; + + switch ( fid ) + { + case FFA_VERSION: + handle_version(regs); + return true; + + default: + gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); + return false; + } +} + +static int ffa_domain_init(struct domain *d) +{ + struct ffa_ctx *ctx; + + if ( !ffa_version ) + return -ENODEV; + + ctx = xzalloc(struct ffa_ctx); + if ( !ctx ) + return -ENOMEM; + + d->arch.tee = ctx; + + return 0; +} + +/* This function is supposed to undo what ffa_domain_init() has done */ +static int ffa_relinquish_resources(struct domain *d) +{ + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx ) + return 0; + + XFREE(d->arch.tee); + + return 0; +} + +static bool ffa_probe(void) +{ + uint32_t vers; + unsigned int major_vers; + unsigned int minor_vers; + + /* + * psci_init_smccc() updates this value with what's reported by EL-3 + * or secure world. + */ + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) + { + printk(XENLOG_ERR + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", + smccc_ver, ARM_SMCCC_VERSION_1_2); + return false; + } + + if ( !ffa_get_version(&vers) ) + return false; + + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) + { + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); + return false; + } + + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; + minor_vers = vers & FFA_VERSION_MINOR_MASK; + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", + FFA_MY_VERSION_MAJOR, FFA_MY_VERSION_MINOR); + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", + major_vers, minor_vers); + + ffa_version = vers; + + return true; +} + +static const struct tee_mediator_ops ffa_ops = +{ + .probe = ffa_probe, + .domain_init = ffa_domain_init, + .relinquish_resources = ffa_relinquish_resources, + .handle_call = ffa_handle_call, +}; + +REGISTER_TEE_MEDIATOR(ffa, "FF-A", XEN_DOMCTL_CONFIG_TEE_FFA, &ffa_ops); diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index cd68fa80e98a..7f2f5eb9ce3d 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -24,7 +25,7 @@ #define XEN_SMCCC_FUNCTION_COUNT 3 /* Number of functions currently supported by Standard Service Service Calls. */ -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) { @@ -188,13 +189,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) return do_vpsci_0_1_call(regs, fid); } +static bool is_psci_fid(uint32_t fid) +{ + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; + + return fn >= PSCI_FNUM_MIN_VALUE && fn <= PSCI_FNUM_MAX_VALUE; +} + /* PSCI 0.2 interface and other Standard Secure Calls */ static bool handle_sssc(struct cpu_user_regs *regs) { uint32_t fid = (uint32_t)get_user_reg(regs, 0); - if ( do_vpsci_0_2_call(regs, fid) ) - return true; + if ( is_psci_fid(fid) ) + return do_vpsci_0_2_call(regs, fid); + + if ( is_ffa_fid(fid) ) + return tee_handle_call(regs); switch ( fid ) { diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index 1528ced5097a..92aff923056a 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -296,6 +296,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); #define XEN_DOMCTL_CONFIG_TEE_NONE 0 #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1 +#define XEN_DOMCTL_CONFIG_TEE_FFA 2 struct xen_arch_domainconfig { /* IN/OUT */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499542.770746 (Exim 4.92) (envelope-from ) id 1pUr87-00026T-G1; Wed, 22 Feb 2023 15:34:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499542.770746; Wed, 22 Feb 2023 15:34:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr87-00024z-94; Wed, 22 Feb 2023 15:34:03 +0000 Received: by outflank-mailman (input) for mailman id 499542; Wed, 22 Feb 2023 15:34:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr84-0001MH-La for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:00 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51ed4ceb-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:33:56 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id m6so10601495lfq.5 for ; Wed, 22 Feb 2023 07:33:57 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51ed4ceb-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hFm2TzWcNGWz8FKUUitzejc0u2aQwxYFeFHIlHq40P4=; b=GzxgN7BXbxo0+/tv1J0713rHL72vukYSwgLPf/P+YI0EbO88BD0N2mt9tsEc6yuqgF qEj0fifpnuzJYhfMWU8RXfcPezwCsDHddm6k4RBNibMtxs9op6/jrECuaKfTT7I4J02a DWqthWpQA1u4SpXUGpD/ARFbHmTN/j7AK58oQckLu9w9Ycnj6T2O4VkVaafp+p2SScMc WsXJRsp6sEDpaAINKRX1NDCnBCGIm01gBQ1xVJyq3qgmK32pgr9T/8p8m/YW18HlF/OH 68FoBzYyObu5o0DLZts2/ZKRP5tuaHzZvf5kFlBwS152PpNiWb3HNvan9mwU/WNnDxnS FZ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hFm2TzWcNGWz8FKUUitzejc0u2aQwxYFeFHIlHq40P4=; b=eUx/Ra97c0jPV2kkEw1qZmM3RnlZaV4EWP4Gr28DwTkKa7JPO6zWmRve/Q5AOOQqQl NF1BCIAZXSniSjON4iKFDNL6KaBBMVmN1ZmlIg7B5AZ8tItC56dqQbhHQb9UhD2Uoo5k Q1XjbhschQeXLgRxedIFGloxW6XmPlviWlU33OM9PPlw7aVw/uO2lshcYspVRI71Dg/S y5pUC0A9SIKq1OeySIto12knQymECsRdJtnfVhlGqSEw/hUxUPJDbcjpDluU5UWsjjRh uIs3zT3UcEB92ZZX5PbikiIgLXstdAb/y0/0h7h1V+BgG7KrWi+pp/RghOrsK01tQbjc CnCw== X-Gm-Message-State: AO0yUKXSpG5Y7XalpaeBGnSKu/xu13H+UhR2dzaCt4wK2mPb0n6jfFpQ gcM+MlJwRZRLu6KC7XpT8vU9W99vOTtcKxpSPdw= X-Google-Smtp-Source: AK7set83a9EuQm3FIhZUxGYQNpN+Xliw3SPos9E5nhOpkX42RfqIIRGvaj5zAtDXQpR0Z7Rfgn5MBA== X-Received: by 2002:ac2:4ad9:0:b0:4db:268a:4ec5 with SMTP id m25-20020ac24ad9000000b004db268a4ec5mr2962768lfp.52.1677080037078; Wed, 22 Feb 2023 07:33:57 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN PATCH v7 03/20] tools: add Arm FF-A mediator Date: Wed, 22 Feb 2023 16:33:00 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a guest is trusted to use FF-A. Signed-off-by: Jens Wiklander --- tools/libs/light/libxl_arm.c | 3 +++ tools/libs/light/libxl_types.idl | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index ddc7b2a15975..601890dda1ce 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -205,6 +205,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, case LIBXL_TEE_TYPE_OPTEE: config->arch.tee_type = XEN_DOMCTL_CONFIG_TEE_OPTEE; break; + case LIBXL_TEE_TYPE_FFA: + config->arch.tee_type = XEN_DOMCTL_CONFIG_TEE_FFA; + break; default: LOG(ERROR, "Unknown TEE type %d", d_config->b_info.tee); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 0cfad8508dbd..64fb570bc19a 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -494,7 +494,8 @@ libxl_gic_version = Enumeration("gic_version", [ libxl_tee_type = Enumeration("tee_type", [ (0, "none"), - (1, "optee") + (1, "optee"), + (2, "ffa") ], init_val = "LIBXL_TEE_TYPE_NONE") libxl_rdm_reserve = Struct("rdm_reserve", [ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499543.770755 (Exim 4.92) (envelope-from ) id 1pUr88-0002HA-9l; Wed, 22 Feb 2023 15:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499543.770755; Wed, 22 Feb 2023 15:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr87-0002En-Qi; Wed, 22 Feb 2023 15:34:03 +0000 Received: by outflank-mailman (input) for mailman id 499543; Wed, 22 Feb 2023 15:34:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr85-0001MC-6h for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:01 +0000 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [2a00:1450:4864:20::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5466f783-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:00 +0100 (CET) Received: by mail-lf1-x133.google.com with SMTP id m6so10601696lfq.5 for ; Wed, 22 Feb 2023 07:34:00 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5466f783-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=daCXmezi75zgDEVaU54najSvdry1ZvL/v784GcKBNIM=; b=r8/bfWS5zxacR3bGf35cbhZHARGEdjT5DmuvT3lTG7ZqVQpv8gjMCyEsMth1VaAQ9/ 2FikkF1y4tF41RUHKkqLyZt8DBE1K4FEABM6GXx07QoGTw5heKZwFgojECn2LHaZBxEy 5GlWAOOlphjbZ+r+mkbVaHlJCwLDWlzZiXaGkESTk2kuPgiYXRYShC6y/wXXO5ARQF2L 5Pkz6V/C4RmjPB+3zwEUpaimm0UBwUaJju7dtVvmNN0/epxtkF3gTdVYa5AuTFH6fKbM ZPOVDl4Vedq8I7CvapjlQprNWfY3x3WqQQIpAbuvgNQwlwUSrcfc5R6S8b6bSJNoafZr dXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=daCXmezi75zgDEVaU54najSvdry1ZvL/v784GcKBNIM=; b=SmyspjUt14CUVenSviS4kfNFIASHc/KN8Rpb+/Cs2HiJn7ng+emJSuRAJO9lOLkIla 3eg2R/6mPTwOqatlZyWo0m2mtrar1OZlkb4Hf/DXrPceKGcNx4g9hNsxOtoHttuhbiba F/xJ+MZfBWxyr45sOQZBevu4VyUT1CB55XsC3wERJQ4QgdYjrwN3lSDmXVRlasXuj31K L6pJuGvRt6vPxMFTT+xBhH3dpRoAa/I5JUWcy5FxJvLBf55w14B5Nb0S9Os0E+lTIlGP A0iektnR7QKsQVnmjKg7NFz++qhhinX2ItT/13KMl0D6Hblma+DhYhjSnLFQYrelQrZX 0WuA== X-Gm-Message-State: AO0yUKVSfN5W3voHoo1G80p4BnU+jOCm9lbZo3lzf8mRQFOqWLAnVxj4 lD9J8Di7blqp1Q+GJn6HR9sVWRsGmGI8vJ1N+8o= X-Google-Smtp-Source: AK7set93muUJIEST07jzhhKMCkgsqD+Eb2DfvRNAehJS1K297RREfCeyvjA9vIOjRgr5rCQkNWg07g== X-Received: by 2002:ac2:5a05:0:b0:4b5:8f03:a2bc with SMTP id q5-20020ac25a05000000b004b58f03a2bcmr3022146lfn.9.1677080040361; Wed, 22 Feb 2023 07:34:00 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages Date: Wed, 22 Feb 2023 16:33:04 +0100 Message-Id: <904055064f4b4e4514acf1e64751672eca045c05.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds defines for framework direct request/response messages. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f4562ed2defc..d04bac9cc47f 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -56,6 +56,15 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* Framework direct request/response */ +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) +#define FFA_MSG_TYPE_MASK 0xFFU; +#define FFA_MSG_PSCI 0x0U +#define FFA_MSG_SEND_VM_CREATED 0x4U +#define FFA_MSG_RESP_VM_CREATED 0x5U +#define FFA_MSG_SEND_VM_DESTROYED 0x6U +#define FFA_MSG_RESP_VM_DESTROYED 0x7U + /* * Flags used for the FFA_PARTITION_INFO_GET return message: * BIT(0): Supports receipt of direct requests -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499544.770767 (Exim 4.92) (envelope-from ) id 1pUr89-0002Uz-IM; Wed, 22 Feb 2023 15:34:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499544.770767; Wed, 22 Feb 2023 15:34:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr88-0002QV-Ox; Wed, 22 Feb 2023 15:34:04 +0000 Received: by outflank-mailman (input) for mailman id 499544; Wed, 22 Feb 2023 15:34:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr85-0001MH-Ns for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:01 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 536c2c77-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:33:59 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id f18so10543953lfa.3 for ; Wed, 22 Feb 2023 07:34:00 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:33:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 536c2c77-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oaAb7ukOE/W1jF7n380+WVov1wWGPwFJcHBGgA4I42A=; b=PsIcsB1eAGAv31fKhzszD8BPuis7RyhebinM1YoSHMcMlhsPv+l5LRETNGSJgaWiOE vfoFQQNo+Z592qPRDlV+kqKb+5E8EmzMz3+Txwwqg0txE7h9x6COb81lmSwWOTM0USuI pHUguVHJU/s/rLl+H9m4QFmRWR9TEydGMFyNVTxCBHM4EGex5yO6/bSbIrHATk9ZSLjA qFav1IYaJG30zWOgLqi6BNAjnWGFgjnakHyII6qasFKHHEkH0GU6jqXA1JLxjKAiu4Y/ Kazw2LNaosSD0z8bJimwxf96wgDm1Iuo/ckhKILeffwCrxz6bWlTmpNZIeIax34OB5i6 mwgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oaAb7ukOE/W1jF7n380+WVov1wWGPwFJcHBGgA4I42A=; b=kqWLteWdKuPfHwK2AWvsT3rrjkxT0Tx0y1Hk1KQQ6gJmoxeMcpXJeWvX1i1WLPdk/P Mh9gkYhUSWN1JkpnFiHlbCJL/o1v+1kTEYyW913NasSuhMKtmzNoBl1ciqzOkaUo1WTr m33rM08EmdALegp3K7MPgNTHcYHPrDNs+Am/i19xiO8l21u/6pl1y0uAERMOv8kYsBHo 1fc3mi4NstKd2XTc5RMhaEPcxOKQW+3pzqwSZOB9uQIIgW4kdZyk2n1t297Xos4jTHKP te8hgNT3UbEkiAEbsYx+kE6Ngk9cM4NTss7CmlVXycSLBwyGs+K165ouKdNi7Hc4BuoQ /gGA== X-Gm-Message-State: AO0yUKWxFtO/tdT1c0Qhqwp0LDdZWI566P0bNoXGY8BfZ5CaVSlr/+yd PYKUfrZnbpxbHIMutPUSxKgJkvsZVYzTBTGK4oo= X-Google-Smtp-Source: AK7set/BrU6GpxdvnsexBpdAumv70/Z+G4UeQ/FoCu2NxcHU8B/LeNDcv7Ablb5ZYe6LLtZazjYCTQ== X-Received: by 2002:ac2:5ece:0:b0:4dd:9aec:e468 with SMTP id d14-20020ac25ece000000b004dd9aece468mr1184919lfq.58.1677080039581; Wed, 22 Feb 2023 07:33:59 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Date: Wed, 22 Feb 2023 16:33:03 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Defines flags used for the function FFA_PARTITION_INFO_GET. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index aa6cdbe0a4f9..f4562ed2defc 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -56,6 +56,32 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * Flags used for the FFA_PARTITION_INFO_GET return message: + * BIT(0): Supports receipt of direct requests + * BIT(1): Can send direct requests + * BIT(2): Can send and receive indirect messages + * BIT(3): Supports receipt of notifications + * BIT(4-5): Partition ID is a PE endpoint ID + */ +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) +#define FFA_PART_PROP_IS_PE_ID (0U << 4) +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) + +/* + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition + * count only. + */ +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) + /* Function IDs */ #define FFA_ERROR 0x84000060U #define FFA_SUCCESS_32 0x84000061U -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499545.770773 (Exim 4.92) (envelope-from ) id 1pUr8A-0002er-8B; Wed, 22 Feb 2023 15:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499545.770773; Wed, 22 Feb 2023 15:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr89-0002c4-Gi; Wed, 22 Feb 2023 15:34:05 +0000 Received: by outflank-mailman (input) for mailman id 499545; Wed, 22 Feb 2023 15:34:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr87-0001MH-B7 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:03 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5461d2c2-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:00 +0100 (CET) Received: by mail-lf1-x12c.google.com with SMTP id bp25so10676489lfb.0 for ; Wed, 22 Feb 2023 07:34:01 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:00 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5461d2c2-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6KguU5fKyIYZ3B6fRSfTmGKEYTHZutvCnKPhrDpB1io=; b=YQ7QaUw2xSr0uhygfwAIAPTnrqAX0QSAeZ638gQy98K6yT9B0ioUdpuyfD/GEtFt34 E/q0d6XP2L3ipHWJwhkjyR7Sfq08lY5CYYj9oLtjj86uVPLOe6wmrFCCUiSmNwMc8d4w bLdQmsYNKgnSuQ1e2GmC2kCPGuLo9KM5IPf/rJ7iNEpy2L7nacLcUPXj4a32DtpSjmqx Ww4Slve+itnWYK3BK8k3cBJhIngJrnUd7FigQzG6zTc6HCeeMRsM8JI3VSUi4p6fVZNs XkNR0Fw0hv1Y4AXvWq+xFYJtG8ujcRIr8RDF9i1z2cgHl81oZColGEa8Nq8oA6Mvj7FI 3ItQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KguU5fKyIYZ3B6fRSfTmGKEYTHZutvCnKPhrDpB1io=; b=GS+WVJftdXyfPCPi+XgF5RV0EKWljbVdcTnBM2G3QRRXPRDgsnHNxiso/YGmG9YQuy 0kcdC91wKKXCLXS51eK0fqOChWdinjZvNnAfqe++VPLbu+0aO9nvgCnGrIEenuA0wn6E qiyA3jDOiYJaIvTeuxjFo3lQ/EL7bvP8mg0FkER72xyeLMrWhCFDEhrOgcKt3Cd6ei18 O+v8kbwOtVF67SNXBUXn4dhWF+Rz+S7UsD5Ibuk07TcHAsEnR5X9gAPR53Eu1ItdyMfs QcQxtka34HrCCq/tRobBUSSE+auiNodU/5vF0GOPmG0mm2xlWjFXaU5CskU9LyDgpOgt Jyxw== X-Gm-Message-State: AO0yUKXG2DmIMr0I2QmmJx6AGsf1/RSUTjaJmqUQdYB1ojKSBcKvF30W Ytc1WoOO9wk07qG3KGFgwWFd2Wsaq0scD04Dvwk= X-Google-Smtp-Source: AK7set/xYReyFarccwfkMjZIxvACnhtNCeZqDqdQl+pSNBAcE7+gyQOEvXc3nFfTscS6Ntnj2sDjTw== X-Received: by 2002:ac2:43b3:0:b0:4dc:4b05:485c with SMTP id t19-20020ac243b3000000b004dc4b05485cmr2784611lfl.50.1677080041130; Wed, 22 Feb 2023 07:34:01 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages Date: Wed, 22 Feb 2023 16:33:05 +0100 Message-Id: <6c0ef5d2174bfa8c25aeb94395160ab9d863b63a.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A mediator. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index d04bac9cc47f..8b0b80ce1ff5 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -56,6 +56,16 @@ #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ FFA_MY_VERSION_MINOR) +/* + * The FF-A specification explicitly works with 4K pages as a measure of + * memory size, for example, FFA_RXTX_MAP takes one parameter "RX/TX page + * count" which is the number of contiguous 4K pages allocated. Xen may use + * a different page size depending on the configuration to avoid confusion + * with PAGE_SIZE use a special define when it's a page size as in the FF-A + * specification. + */ +#define FFA_PAGE_SIZE SZ_4K + /* Framework direct request/response */ #define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) #define FFA_MSG_TYPE_MASK 0xFFU; @@ -242,6 +252,17 @@ static bool ffa_probe(void) unsigned int major_vers; unsigned int minor_vers; + /* + * FF-A often works in units of 4K pages and currently it's assumed + * that we can map memory using that granularity. See also the comment + * above the FFA_PAGE_SIZE define. + * + * It is possible to support a PAGE_SIZE larger than 4K in Xen, but + * until that is fully handled in this code make sure that we only use + * 4K page sizes. + */ + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); + /* * psci_init_smccc() updates this value with what's reported by EL-3 * or secure world. -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499546.770779 (Exim 4.92) (envelope-from ) id 1pUr8A-0002st-RA; Wed, 22 Feb 2023 15:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499546.770779; Wed, 22 Feb 2023 15:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8A-0002oX-Aa; Wed, 22 Feb 2023 15:34:06 +0000 Received: by outflank-mailman (input) for mailman id 499546; Wed, 22 Feb 2023 15:34:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr87-0001MH-TG for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:04 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54c90f4c-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:01 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id m6so10601812lfq.5 for ; Wed, 22 Feb 2023 07:34:02 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54c90f4c-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qlRarVPuGGMxZJ7O9DysTL7l0g/2Vw4D9Z/5pFVB9eY=; b=v6eOR64rfNhuETorAOP32Qsll4kvQB9Dgr24SH4+6NC8LyDPcWLA9Txni/P313Yu84 ijBsLthYJCWX8rLhn0AZ8WgHJiggxz0OGHcnjWi2ELDHpC2tyY5sjFg4SaKglJPE2y1c OobXeDx38ZOfnjIXy+5uSycUzKX7aEJpk3gHYsyDn4ocAJLGOMijC1kkxh69COT7r5Gv lH/yW2Ce/ylH/JdyjppsFcQtZ2pQyVQQXOWN8LdFvaqOMxYOXXRMBcpk3qDA3PhXE5oG Br/N22skns/Tggkr1hYsnjSxVvbB9YQGoa15L0qL5UuQ4A3ZVsDot0SudVgBewchl/1E FeMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qlRarVPuGGMxZJ7O9DysTL7l0g/2Vw4D9Z/5pFVB9eY=; b=VVLb35Nd3O61M+MnaZxMV+/QwVY+l9eLgyzQNlZ/dIXXC0M52l/uB5QuLDx4+oNOQ7 3/lsmpmmkGsXZEVCCVtKMin+jAr2S+0KCJR+CR8AKjEvcTViYDdH8+oS3Wwfv1ubuBA4 AnLjA/+09bRvtLbcd3v7PpNNlCzhlapqgrLutiNPYbxi83phfw9ZilmoXRhEy5m+N5KZ 5KUi4BhTBxalYNWUk4JfVoGLO2q2xsP3BJ4WWytuRwiqSSZ0w4ZLTIGV6Znv3pk1Wxh6 ji9SM40NrZI8KeugFGMozAzWzDus1KDkqpgVtnlO3LcDpCcH6VFoLjrf1NS4Zp3UUeQu dvJQ== X-Gm-Message-State: AO0yUKVVqPs6MV5+NJfJGrqsnY4wl57gC359P/mF4AOs9faFPcFr3Irm nHwAHwKEXJ6+7l+TNNlTPKMX9QOSpETNd6RxMmQ= X-Google-Smtp-Source: AK7set/IEh/V1KX9mwsFk0gNb3edbAK94pykYyZvOLSlTnGOfCA8Xl0pLjrnvD6r9JW5sb3plOEDfA== X-Received: by 2002:ac2:4893:0:b0:4db:44e1:d8a1 with SMTP id x19-20020ac24893000000b004db44e1d8a1mr3484319lfc.0.1677080041867; Wed, 22 Feb 2023 07:34:01 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET Date: Wed, 22 Feb 2023 16:33:06 +0100 Message-Id: <82e4e0c3ac1614822fddd90336c22e6fad5b485e.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for the FF-A function FFA_ID_GET to return the ID of the calling client. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 8b0b80ce1ff5..463fd7730573 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -167,6 +167,12 @@ static bool ffa_get_version(uint32_t *vers) return true; } +static uint16_t get_vm_id(const struct domain *d) +{ + /* +1 since 0 is reserved for the hypervisor in FF-A */ + return d->domain_id + 1; +} + static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, register_t v2, register_t v3, register_t v4, register_t v5, register_t v6, register_t v7) @@ -181,6 +187,12 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, set_user_reg(regs, 7, v7); } +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, + uint32_t w3) +{ + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); +} + static void handle_version(struct cpu_user_regs *regs) { struct domain *d = current->domain; @@ -210,6 +222,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_VERSION: handle_version(regs); return true; + case FFA_ID_GET: + set_regs_success(regs, get_vm_id(d), 0); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -221,7 +236,11 @@ static int ffa_domain_init(struct domain *d) { struct ffa_ctx *ctx; - if ( !ffa_version ) + /* + * We can't use that last possible domain ID or get_vm_id() would cause + * an overflow. + */ + if ( !ffa_version || d->domain_id == UINT16_MAX) return -ENODEV; ctx = xzalloc(struct ffa_ctx); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499547.770791 (Exim 4.92) (envelope-from ) id 1pUr8B-000357-RG; Wed, 22 Feb 2023 15:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499547.770791; Wed, 22 Feb 2023 15:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8B-00031j-8Q; Wed, 22 Feb 2023 15:34:07 +0000 Received: by outflank-mailman (input) for mailman id 499547; Wed, 22 Feb 2023 15:34:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr88-0001MH-O3 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:04 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5540a006-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:02 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id f18so10544187lfa.3 for ; Wed, 22 Feb 2023 07:34:03 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5540a006-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kkuvt9UXNHNkVAS/s0VFcET0eufVzl6U4CDVsy+uJVk=; b=x4CHeQVoB/gXPv4A4zyctWjL31vbD1kfqcBY3qLXtFmefh7ew6OVmaP4Vk1eZk0XFB 1unpgsf/zq2oM05no+wr34qzXZ2K1mg7qjMck3c7E4LDAl8Xwg1LUzFOBViI7NfrI71t IPeool/FV+xSeJwrGWZHuAVYkyXwEHxDHadmasEdQ0964YvVGytqlGcX6z4QxcJnGsXs veZO5cy85ofIpYmkIjTECfbvVy605ADh4PzL9mEgtYZMdUhV46H4tZwHvwvgu3IY/u0d FqBft1E3btju1jSF+8tnYg52S7LngoeG+JPe6U0bCh2UESkx8lmzlVswBHXIbdXzaKEj SBGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kkuvt9UXNHNkVAS/s0VFcET0eufVzl6U4CDVsy+uJVk=; b=XbKwlvUo9aBGbMa3hKdZI+HtxxLt9ESTbXUo1+HFDoCcpFbV3GgNjfZZYdWJhzckIf QaY4MVGvy5bIrfueJvpKL+9RDSM6eBxVHPKo9C1sK1Zf8UB/ZrIFQNhPTxorzC4aAAZU UOSEhjgh+NlGJorTNTcJd/LaUxnfUBaWDOgqukzW5RQMRrQM8iN6o7oi0nGf7wmP0SVI PC0tmWA/kvSEKYP5TFqxSZHQfw/dEWzcss9kk4oYOBRldrAkJG2HzigseTBVQmK+i1SB WzFo7MNhWfVLWiynJnHwQpWhWzwEgQBeg6fahlUsHXw/akZNWrG2jiKCp3njs8zQYUfM cGUA== X-Gm-Message-State: AO0yUKU8HNpotzhWLvEnfpcu7QnOIrAt4uUg0BrgeiNdB9CiccQKl9Ty gOUvZ3laCanyyfYjzH4MWAOak4GeA3TjfnQMTTA= X-Google-Smtp-Source: AK7set9MBF+cgaDazaqsWQaTxBA/fD7CzrvHmWOKRiZpG84l7B6lwQ56kwpuzjVn65GmxYxseRPcgA== X-Received: by 2002:a19:5517:0:b0:4db:26d3:e2f8 with SMTP id n23-20020a195517000000b004db26d3e2f8mr2748068lfe.22.1677080042624; Wed, 22 Feb 2023 07:34:02 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 10/20] xen/arm: ffa: add direct request support Date: Wed, 22 Feb 2023 16:33:07 +0100 Message-Id: <3332563e64568b2ffd236b1f428c27aa4cdf9790.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for sending a FF-A direct request. Checks that the SP also supports handling a 32-bit direct request. 64-bit direct requests are not used by the mediator itself so there is not need to check for that. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 119 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 119 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 463fd7730573..a5d8a12635b6 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -142,6 +142,7 @@ struct ffa_ctx { uint32_t guest_vers; + bool interrupted; }; /* Negotiated FF-A version to use with the SPMC */ @@ -167,6 +168,55 @@ static bool ffa_get_version(uint32_t *vers) return true; } +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) +{ + switch ( resp->a0 ) + { + case FFA_ERROR: + if ( resp->a2 ) + return resp->a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + return FFA_RET_OK; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a2, + register_t a3, register_t a4) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = fid, + .a1 = a1, + .a2 = a2, + .a3 = a3, + .a4 = a4, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + return get_ffa_ret_code(&resp); +} + +static int32_t ffa_features(uint32_t id) +{ + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); +} + +static bool check_mandatory_feature(uint32_t id) +{ + uint32_t ret = ffa_features(id); + + if (ret) + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); + + return !ret; +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -208,6 +258,66 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) +{ + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; + struct arm_smccc_1_2_regs resp = { }; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + uint32_t src_dst; + uint64_t mask; + + if ( smccc_is_conv_64(fid) ) + mask = GENMASK_ULL(63, 0); + else + mask = GENMASK_ULL(31, 0); + + src_dst = get_user_reg(regs, 1); + if ( (src_dst >> 16) != get_vm_id(d) ) + { + resp.a0 = FFA_ERROR; + resp.a2 = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + arg.a1 = src_dst; + arg.a2 = get_user_reg(regs, 2) & mask; + arg.a3 = get_user_reg(regs, 3) & mask; + arg.a4 = get_user_reg(regs, 4) & mask; + arg.a5 = get_user_reg(regs, 5) & mask; + arg.a6 = get_user_reg(regs, 6) & mask; + arg.a7 = get_user_reg(regs, 7) & mask; + + while ( true ) + { + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_INTERRUPT: + ctx->interrupted = true; + goto out; + case FFA_ERROR: + case FFA_SUCCESS_32: + case FFA_SUCCESS_64: + case FFA_MSG_SEND_DIRECT_RESP_32: + case FFA_MSG_SEND_DIRECT_RESP_64: + goto out; + default: + /* Bad fid, report back. */ + memset(&arg, 0, sizeof(arg)); + arg.a0 = FFA_ERROR; + arg.a1 = src_dst; + arg.a2 = FFA_RET_NOT_SUPPORTED; + continue; + } + } + +out: + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & mask, + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -225,6 +335,12 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_MSG_SEND_DIRECT_REQ_32: +#ifdef CONFIG_ARM_64 + case FFA_MSG_SEND_DIRECT_REQ_64: +#endif + handle_msg_send_direct_req(regs, fid); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -310,6 +426,9 @@ static bool ffa_probe(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + return false; + ffa_version = vers; return true; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499548.770800 (Exim 4.92) (envelope-from ) id 1pUr8C-0003Kg-Qa; Wed, 22 Feb 2023 15:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499548.770800; Wed, 22 Feb 2023 15:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8C-0003Ft-6g; Wed, 22 Feb 2023 15:34:08 +0000 Received: by outflank-mailman (input) for mailman id 499548; Wed, 22 Feb 2023 15:34:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr89-0001MC-9m for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:05 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56b60095-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:04 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id k14so9541792lfj.7 for ; Wed, 22 Feb 2023 07:34:04 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56b60095-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NJzaZctbLN0X37KKF3Aj2PkBCjDMgRDd+78/Gv1GG98=; b=xW0vwRbqy+Pj5n+CkSZhIHnFgo7jW37etlbDh+MBLwGfNouZ1wHYvefyhsCl6XIezR MkpBOzKjOMVGpR4Knf3TTFFWoezZiLyAVTvBAyFPEQoKcrTpYgP1i4e5TqK/5kdIvw3a XhYK8HUYcodRDDVwQhcaoDbndxLV518PCJk/aNl7Uq/sV3yXmsfpo++GSRoaYX6GvEL5 huJYZgDf+uqbD1Z/2lO3YTnoE3JeGiwl6kqZRM151xjUK6LCxRgfDMnMCt1tbbIMSkeW BuiM/4rd6hSwWaSUQzQAmszU5TiVa8MpXTEpZKQQ1oQ7otVPClvPYLs+DyVYB0li21t4 1YEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NJzaZctbLN0X37KKF3Aj2PkBCjDMgRDd+78/Gv1GG98=; b=tlaqueQ9jYQFKqkMrFHW+82TDXoRDZTjuee63R58Awcfeu7Zqx9YhfW6QMQfd9cfMD uvgZFYXIZhkSnodsWmVVwzoAeizJ0NFHkiCK98/cOPHjnbXtFrENRAop/FS9w+/TOUa3 5ck6ZuqTO6pJVDyy/6wnsSxEgN+D5/HJHj2SUUlXyYvAE8NITLCHD/r4jPjQikt6qSjV YWVWjW/nkwlyToZP/Wh9uzFMCIDJZuS3z6XGQSieIaYfGNKXHxhNTOlOEZZetBF71laE U929eJB41jrrimG4WfsdDnwSno2EhBIwI5/9jhrxhXv1BePm93eBEAhzsA8xRRdG/42t YO1g== X-Gm-Message-State: AO0yUKViLc6z+2E19yEiLWAsjcU2WgzeK5c7i1Hd5tHlqk2ctK98y9DQ kLDeTy2zLXftZZcBkcUF1iT/rinDKQecPXgwyYw= X-Google-Smtp-Source: AK7set+kbgkO0xYcIfALEaMQ3URs/Gg48aA5WIJtUSrrOKjk1+heIZ1I7EoUZOCEb4HMmQ0fJRPLFQ== X-Received: by 2002:ac2:5229:0:b0:4da:b5d4:efd5 with SMTP id i9-20020ac25229000000b004dab5d4efd5mr2902410lfl.60.1677080044182; Wed, 22 Feb 2023 07:34:04 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 12/20] xen/arm: ffa: send guest events to Secure Partitions Date: Wed, 22 Feb 2023 16:33:09 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The FF-A specification defines framework messages sent as direct requests when certain events occurs. For instance when a VM (guest) is created or destroyed. Only SPs which have subscribed to these events will receive them. An SP can subscribe to these messages in its partition properties. Adds a check that the SP supports the needed FF-A features FFA_PARTITION_INFO_GET and FFA_RX_RELEASE. The partition properties of each SP is retrieved with FFA_PARTITION_INFO_GET which returns the information in our RX buffer. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (us), so once we're done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 191 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 190 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 07dd5c36d54b..f1b014b6c7f4 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -140,6 +140,14 @@ #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +/* Partition information descriptor */ +struct ffa_partition_info_1_1 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; + uint8_t uuid[16]; +}; + struct ffa_ctx { uint32_t guest_vers; bool interrupted; @@ -148,6 +156,12 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* SPs subscribing to VM_CREATE and VM_DESTROYED events */ +static uint16_t *subscr_vm_created __read_mostly; +static unsigned int subscr_vm_created_count __read_mostly; +static uint16_t *subscr_vm_destroyed __read_mostly; +static unsigned int subscr_vm_destroyed_count __read_mostly; + /* * Our rx/tx buffers shared with the SPMC. * @@ -237,6 +251,72 @@ static int32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); } +static int32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_PARTITION_INFO_GET, + .a1 = w1, + .a2 = w2, + .a3 = w3, + .a4 = w4, + .a5 = w5, + }; + struct arm_smccc_1_2_regs resp; + uint32_t ret; + + arm_smccc_1_2_smc(&arg, &resp); + + ret = get_ffa_ret_code(&resp); + if ( !ret ) + *count = resp.a2; + + return ret; +} + +static int32_t ffa_rx_release(void) +{ + return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); +} + +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, + uint8_t msg) +{ + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; + int32_t res; + + if ( msg == FFA_MSG_SEND_VM_CREATED ) + exp_resp |= FFA_MSG_RESP_VM_CREATED; + else if ( msg == FFA_MSG_SEND_VM_DESTROYED ) + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; + else + return FFA_RET_INVALID_PARAMETERS; + + do { + const struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, + .a1 = sp_id, + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, + .a5 = vm_id, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) + { + /* + * This is an invalid response, likely due to some error in the + * implementation of the ABI. + */ + return FFA_RET_INVALID_PARAMETERS; + } + res = resp.a3; + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); + + return res; +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -371,6 +451,10 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) static int ffa_domain_init(struct domain *d) { struct ffa_ctx *ctx; + unsigned int n; + unsigned int m; + unsigned int c_pos; + int32_t res; /* * We can't use that last possible domain ID or get_vm_id() would cause @@ -383,24 +467,121 @@ static int ffa_domain_init(struct domain *d) if ( !ctx ) return -ENOMEM; + for ( n = 0; n < subscr_vm_created_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_created[n], get_vm_id(d), + FFA_MSG_SEND_VM_CREATED); + if ( res ) + { + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_created[n], res); + c_pos = n; + goto err; + } + } + d->arch.tee = ctx; return 0; + +err: + /* Undo any already sent vm created messaged */ + for ( n = 0; n < c_pos; n++ ) + for ( m = 0; m < subscr_vm_destroyed_count; m++ ) + if ( subscr_vm_destroyed[m] == subscr_vm_created[n] ) + ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + return -ENOMEM; } /* This function is supposed to undo what ffa_domain_init() has done */ static int ffa_relinquish_resources(struct domain *d) { struct ffa_ctx *ctx = d->arch.tee; + unsigned int n; + int32_t res; if ( !ctx ) return 0; + for ( n = 0; n < subscr_vm_destroyed_count; n++ ) + { + res = ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id(d), + FFA_MSG_SEND_VM_DESTROYED); + + if ( res ) + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_id %u to %u: res %d\n", + get_vm_id(d), subscr_vm_destroyed[n], res); + } + XFREE(d->arch.tee); return 0; } +static bool init_subscribers(void) +{ + struct ffa_partition_info_1_1 *fpi; + bool ret = false; + uint32_t count; + int e; + uint32_t n; + uint32_t c_pos; + uint32_t d_pos; + + if ( ffa_version < FFA_VERSION_1_1 ) + return true; + + e = ffa_partition_info_get(0, 0, 0, 0, 0, &count); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", e); + goto out; + } + + fpi = ffa_rx; + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + for ( n = 0; n < count; n++ ) + { + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) + subscr_vm_created_count++; + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) + subscr_vm_destroyed_count++; + } + + if ( subscr_vm_created_count ) + subscr_vm_created = xzalloc_array(uint16_t, subscr_vm_created_count); + if ( subscr_vm_destroyed_count ) + subscr_vm_destroyed = xzalloc_array(uint16_t, + subscr_vm_destroyed_count); + if ( (subscr_vm_created_count && !subscr_vm_created) || + (subscr_vm_destroyed_count && !subscr_vm_destroyed) ) + { + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"); + subscr_vm_created_count = 0; + subscr_vm_destroyed_count = 0; + XFREE(subscr_vm_created); + XFREE(subscr_vm_destroyed); + goto out; + } + + for ( c_pos = 0, d_pos = 0, n = 0; n < count; n++ ) + { + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) + subscr_vm_created[c_pos++] = fpi[n].id; + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED ) + subscr_vm_destroyed[d_pos++] = fpi[n].id; + } + + ret = true; +out: + ffa_rx_release(); + + return ret; +} + static bool ffa_probe(void) { uint32_t vers; @@ -447,7 +628,8 @@ static bool ffa_probe(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); - if ( + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || + !check_mandatory_feature(FFA_RX_RELEASE) || #ifdef CONFIG_ARM_64 !check_mandatory_feature(FFA_RXTX_MAP_64) || #endif @@ -475,6 +657,9 @@ static bool ffa_probe(void) ffa_page_count = 1; ffa_version = vers; + if ( !init_subscribers() ) + goto err_free_ffa_tx; + return true; err_free_ffa_tx: @@ -485,6 +670,10 @@ err_free_ffa_rx: ffa_rx = NULL; ffa_page_count = 0; ffa_version = 0; + XFREE(subscr_vm_created); + subscr_vm_created_count = 0; + XFREE(subscr_vm_destroyed); + subscr_vm_destroyed_count = 0; return false; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499549.770814 (Exim 4.92) (envelope-from ) id 1pUr8E-0003gG-J0; Wed, 22 Feb 2023 15:34:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499549.770814; Wed, 22 Feb 2023 15:34:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8D-0003Xc-7g; Wed, 22 Feb 2023 15:34:09 +0000 Received: by outflank-mailman (input) for mailman id 499549; Wed, 22 Feb 2023 15:34:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr89-0001MH-MV for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:05 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55cba0ed-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:03 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id n2so7258380lfb.12 for ; Wed, 22 Feb 2023 07:34:04 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55cba0ed-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r2jocSbtwo5F8M83i1Ug9henF/cqlpwGkk7d8f2nrvc=; b=o5OthBNe4k7qeC6QV8RqK6drlj4jAq/lTI23snrg+DvDPxM+xJK65Q1P8runQ9137I ReT0cfDRYfkgXfuJjNr9N8Z6wCwNiJyum2M8HWqpj/FDtp4Y+xT/1oD4uVWTjtUVTYkv CtflFM/RddhzC0zM47ANJf60jfNG8GyOiw3vcvrLSGrR4d1+2oKk4bEusteknyRlnBLK T7//T4PE6O9Cas86oK9ib+TYAeUlQ9/zxM1FH0FFyZmsgoFD4WVxbGvqcNkDv+BieOzt pDZhB+SFslJtKcXM5/sH3HxC8KgojFhYxTc9zQvH9XamCPNDqYHQTzdU68lTfbWTgC58 NIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r2jocSbtwo5F8M83i1Ug9henF/cqlpwGkk7d8f2nrvc=; b=yy5nrO89KuzlbXRzx/OBKwNKhOn+ROU12H/+BP5pyZiCPPfZpOtjTV9GndZq5Ce++Y heytb61npoRVK60EV8u6L+6l813H/EF6uetyDO9Ouhv0mX1FR2xxY2X+DpcBYorxEZB6 yk3uvR7FgrEKTHRrUSIZigQrXiFdl2P4DwUXuz4ogWojboDV2n6WFRKtkBmjaslVytJv OEvhZ+I8nlb6DgnafEXfE3H7aEvRYZhsY7k1wIul/1lUgscSMpmwA+vEOdkdz7r/TItz /RMTwqnrzZ+AFRcJm8Bidwllux1iU6HTdjvpVWVtVWN28eIEOPvZC2ZGMVZqerjlhZ4e PAJw== X-Gm-Message-State: AO0yUKW3cT339U7bQE4JJTk3bv3ZlVEMoa2JVGRUJCEuCISZDy1zf/M+ 1PVW+WIKxuYqRqcpxcXTaY59yr41hKQ3L68AnDY= X-Google-Smtp-Source: AK7set8Mt0ftqqKEa4+wKLn4rNec2sPsBqbyC9zFbjak0+oSQqFYa7nlPlOPUNPvcX9LYg6RQn498Q== X-Received: by 2002:ac2:5615:0:b0:4a4:68b8:f4bd with SMTP id v21-20020ac25615000000b004a468b8f4bdmr2975009lfd.3.1677080043409; Wed, 22 Feb 2023 07:34:03 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 11/20] xen/arm: ffa: map SPMC rx/tx buffers Date: Wed, 22 Feb 2023 16:33:08 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When initializing the FF-A mediator map the RX and TX buffers shared with the SPMC. These buffer are later used to to transmit data that cannot be passed in registers only. Adds a check that the SP supports the needed FF-A features FFA_RXTX_MAP_64 / FFA_RXTX_MAP_32 and FFA_RXTX_UNMAP. In 64-bit mode we must use FFA_RXTX_MAP_64 since registers are used to transmit the physical addresses of the RX/TX buffers. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 57 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index a5d8a12635b6..07dd5c36d54b 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -148,6 +148,15 @@ struct ffa_ctx { /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; +/* + * Our rx/tx buffers shared with the SPMC. + * + * ffa_page_count is the number of pages used in each of these buffers. + */ +static void *ffa_rx __read_mostly; +static void *ffa_tx __read_mostly; +static unsigned int ffa_page_count __read_mostly; + static bool ffa_get_version(uint32_t *vers) { const struct arm_smccc_1_2_regs arg = { @@ -217,6 +226,17 @@ static bool check_mandatory_feature(uint32_t id) return !ret; } +static int32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, + uint32_t page_count) +{ + uint32_t fid = FFA_RXTX_MAP_32; + + if ( IS_ENABLED(CONFIG_ARM_64) ) + fid = FFA_RXTX_MAP_64; + + return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); +} + static uint16_t get_vm_id(const struct domain *d) { /* +1 since 0 is reserved for the hypervisor in FF-A */ @@ -384,6 +404,7 @@ static int ffa_relinquish_resources(struct domain *d) static bool ffa_probe(void) { uint32_t vers; + int e; unsigned int major_vers; unsigned int minor_vers; @@ -426,12 +447,46 @@ static bool ffa_probe(void) printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", major_vers, minor_vers); - if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) + if ( +#ifdef CONFIG_ARM_64 + !check_mandatory_feature(FFA_RXTX_MAP_64) || +#endif +#ifdef CONFIG_ARM_32 + !check_mandatory_feature(FFA_RXTX_MAP_32) || +#endif + !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; + ffa_rx = alloc_xenheap_pages(0, 0); + if ( !ffa_rx ) + return false; + + ffa_tx = alloc_xenheap_pages(0, 0); + if ( !ffa_tx ) + goto err_free_ffa_rx; + + e = ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); + if ( e ) + { + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", e); + goto err_free_ffa_tx; + } + ffa_page_count = 1; ffa_version = vers; return true; + +err_free_ffa_tx: + free_xenheap_pages(ffa_tx, 0); + ffa_tx = NULL; +err_free_ffa_rx: + free_xenheap_pages(ffa_rx, 0); + ffa_rx = NULL; + ffa_page_count = 0; + ffa_version = 0; + + return false; } static const struct tee_mediator_ops ffa_ops = -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499550.770825 (Exim 4.92) (envelope-from ) id 1pUr8G-00042x-Gt; Wed, 22 Feb 2023 15:34:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499550.770825; Wed, 22 Feb 2023 15:34:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8F-0003yw-79; Wed, 22 Feb 2023 15:34:11 +0000 Received: by outflank-mailman (input) for mailman id 499550; Wed, 22 Feb 2023 15:34:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8A-0001MC-9x for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:06 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57258fdd-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:05 +0100 (CET) Received: by mail-lf1-x132.google.com with SMTP id w27so10583569lfu.4 for ; Wed, 22 Feb 2023 07:34:05 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57258fdd-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cS+8KCwx/w81eQ/g9wS82HyI0n3UdnJ7LzOtx2RTVL8=; b=bQvRcXo07xFoAPdUYDd6yJX5vesisEukCPpmrxVmhT5GYEb4VzZiKujwBo2PHqc2uV JX449HIVFh15Qxxwp+FWhevN8Upr/P2WSy2pdrNHk24uxHZYopBxI98GvEzKj2gt7fX7 5BkfawNB8ZFuZ2/GZqDM0EN4YN+A7f4ghRgl8aEGpT2PMe+ZoAq2XwfkcezRQwK8BR4N eeIE+0Akk5LL0/uQsS2xyJUdkVjJsgHgT4uoiCwYk9S8ysOHDtZ1CRZWN04FytCGTIv3 /p1SyNNGxi+PxgjySWCokiR7CPvOVXUdsY9We+QB2fwohK/qEEj8I34bgTRmk44Aqeo0 YCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cS+8KCwx/w81eQ/g9wS82HyI0n3UdnJ7LzOtx2RTVL8=; b=fQcWCiOB5c3dhgxqOWo8W9XUkVSYxJyiSftCdwJCLMUkRNg75Q9eEI2Ck8aXURv9xx TZsSBj2HPrZ85bazRMQXrXM9e4QhsrjUxJWwHcOkKafR4UrTT4lXE2FBr9bAyj7wH2kc Knv+X9czY3hMSNP/3ABiV/Of2Pr98qog1OtcBShkre1nX4REuFldrbKeURCq+0Hn65Bv 5m2IU0gSANicwQefp7YdFfMZENd7/nMC3sSkJhFjQdSfMbuT1F1SQuJseYvTPzbiAjNh /Dl+vN4/BacWdkOkOy9t9zfnlonOyAgALgg/NJOhrP4O97bihNW8hW58MrkJcpt60+c3 xbvw== X-Gm-Message-State: AO0yUKUoU75Jypkf01egxfLM/M2oNanqRiHbIpXeFuIB1819t4WfU5Ey 8UD3tlyOBbrov1yyMdQ8jbLF+ZbIx5X+pnsXrGk= X-Google-Smtp-Source: AK7set+s2js1Y9IyBYq/3+57C2Q5sWOQATXUGDSMOT3Gxj/f5u8Icwuc5V/KVEXvPSOj1xaGwIG+iQ== X-Received: by 2002:ac2:5615:0:b0:4d8:6540:a731 with SMTP id v21-20020ac25615000000b004d86540a731mr2937063lfd.47.1677080044956; Wed, 22 Feb 2023 07:34:04 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 13/20] xen/arm: ffa: support mapping guest RX/TX buffers Date: Wed, 22 Feb 2023 16:33:10 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to map and unmap the RX and TX buffers provided by the guest using the two FF-A functions FFA_RXTX_MAP and FFA_RXTX_UNMAP. These buffer are later used to to transmit data that cannot be passed in registers only. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 127 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 127 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index f1b014b6c7f4..953b6dfd5eca 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -149,10 +149,17 @@ struct ffa_partition_info_1_1 { }; struct ffa_ctx { + void *rx; + const void *tx; + struct page_info *rx_pg; + struct page_info *tx_pg; + unsigned int page_count; uint32_t guest_vers; + bool tx_is_mine; bool interrupted; }; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -337,6 +344,11 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, set_user_reg(regs, 7, v7); } +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) +{ + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); +} + static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, uint32_t w3) { @@ -358,6 +370,99 @@ static void handle_version(struct cpu_user_regs *regs) set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); } +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, + register_t rx_addr, uint32_t page_count) +{ + uint32_t ret = FFA_RET_INVALID_PARAMETERS; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct page_info *tx_pg; + struct page_info *rx_pg; + p2m_type_t t; + void *rx; + void *tx; + + if ( !smccc_is_conv_64(fid) ) + { + tx_addr &= UINT32_MAX; + rx_addr &= UINT32_MAX; + } + + /* For now to keep things simple, only deal with a single page */ + if ( page_count != 1 ) + return FFA_RET_NOT_SUPPORTED; + + /* Already mapped */ + if ( ctx->rx ) + return FFA_RET_DENIED; + + tx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(tx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + return FFA_RET_INVALID_PARAMETERS; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_tx_pg; + + rx_pg = get_page_from_gfn(d, gfn_x(gaddr_to_gfn(rx_addr)), &t, P2M_ALLOC); + if ( !tx_pg ) + goto err_put_tx_pg; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + goto err_put_rx_pg; + + tx = __map_domain_page_global(tx_pg); + if ( !tx ) + goto err_put_rx_pg; + + rx = __map_domain_page_global(rx_pg); + if ( !rx ) + goto err_unmap_tx; + + ctx->rx = rx; + ctx->tx = tx; + ctx->rx_pg = rx_pg; + ctx->tx_pg = tx_pg; + ctx->page_count = 1; + ctx->tx_is_mine = true; + return FFA_RET_OK; + +err_unmap_tx: + unmap_domain_page_global(tx); +err_put_rx_pg: + put_page(rx_pg); +err_put_tx_pg: + put_page(tx_pg); + + return ret; +} + +static void rxtx_unmap(struct ffa_ctx *ctx) +{ + unmap_domain_page_global(ctx->rx); + unmap_domain_page_global(ctx->tx); + put_page(ctx->rx_pg); + put_page(ctx->tx_pg); + ctx->rx = NULL; + ctx->tx = NULL; + ctx->rx_pg = NULL; + ctx->tx_pg = NULL; + ctx->page_count = 0; + ctx->tx_is_mine = false; +} + +static uint32_t handle_rxtx_unmap(void) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + if ( !ctx->rx ) + return FFA_RET_INVALID_PARAMETERS; + + rxtx_unmap(ctx); + + return FFA_RET_OK; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -423,6 +528,7 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) uint32_t fid = get_user_reg(regs, 0); struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.tee; + int e; if ( !ctx ) return false; @@ -435,6 +541,24 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) case FFA_ID_GET: set_regs_success(regs, get_vm_id(d), 0); return true; + case FFA_RXTX_MAP_32: +#ifdef CONFIG_ARM_64 + case FFA_RXTX_MAP_64: +#endif + e = handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(regs, 2), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; + case FFA_RXTX_UNMAP: + e = handle_rxtx_unmap(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: #ifdef CONFIG_ARM_64 case FFA_MSG_SEND_DIRECT_REQ_64: @@ -515,6 +639,9 @@ static int ffa_relinquish_resources(struct domain *d) get_vm_id(d), subscr_vm_destroyed[n], res); } + if ( ctx->rx ) + rxtx_unmap(ctx); + XFREE(d->arch.tee); return 0; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499551.770832 (Exim 4.92) (envelope-from ) id 1pUr8H-0004HR-7C; Wed, 22 Feb 2023 15:34:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499551.770832; Wed, 22 Feb 2023 15:34:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8G-0004CY-9y; Wed, 22 Feb 2023 15:34:12 +0000 Received: by outflank-mailman (input) for mailman id 499551; Wed, 22 Feb 2023 15:34:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8B-0001MC-A9 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:07 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 579dbb43-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:06 +0100 (CET) Received: by mail-lf1-x132.google.com with SMTP id f41so10501931lfv.13 for ; Wed, 22 Feb 2023 07:34:06 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:05 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 579dbb43-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PKen3qJPmkTvDeSAkak1h6D6WS5xyInpmZTn/4tNUg8=; b=a6V1ggfXAR5GzGDCNUPBm18CgChnXa1ayRPDFApfPH9Pgwg5cmjbYd2l0wkfBDDDkW N0v4szwyfOBMZJ7ONe1XLyjf8zh5XScn2DuE19tmjBOFW8t3Gzmsi+NFpdAcz5WuTAIX mNrYRanN3NLBG19vo6ES/EHVmuCx0NOnew2aCSEXARn23Ny4zfi2B8ywQEDWcK8JjMEj DPurICq7hEUbkgEZLLX2xR/SJEnf7IRbwvKpHxkkgck1lwxsx6xpwzfM2Z2jS5WegLry 4laj1Y+Hl8DaZY0pjSOtBsJ93HeyivCzJSpPaGu9vOm73X9HlVOTYmZv69tw00izK01+ QREQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PKen3qJPmkTvDeSAkak1h6D6WS5xyInpmZTn/4tNUg8=; b=yn/7naHkl1qJglGUTKepVITi1uAnSD7J76rv9fSLUNVQllLFI+9dQUR6nptKMM1n2U G2mt0MJxzEZpOe4M/+iarJxYMKUDMIQAkfCWyRHoqEkLgyV4itgZ+PwV761EfN+YWofF dzDCUA+phPv1zI+RZgFotc+lC1AWPjkkVMm/JfG3gSdlOpmaKjdIasZz15TyQ0JGfIhs ANLvQXyHwpgdFsuFMOZ3bGUQRB4flNuX+r+9+7P9qdlyXGTmL0bNRT1sMcFaIYtoPbnE alj++2PkASQw6BKgSvTBy9blmi5305D+RYI6/ucYTGiR4+Q/imde4kJVt9oYIctPHktu dnWA== X-Gm-Message-State: AO0yUKUhTCAN9D6GQEwHjouJVEdwhbbSD02UGq4S6dwkLW+MM0NFmnZF kfDrsTQ6bMTN1FQTj20C4WTU+6CM83/UjVPqEOw= X-Google-Smtp-Source: AK7set+0o0Ptn4JK86nuCdJ1Z4yrG0grXUD+actcFpHCgn3J/tEoAMIddbOZsMfrFPicXzS30zyXwA== X-Received: by 2002:ac2:4479:0:b0:4da:ffb1:9872 with SMTP id y25-20020ac24479000000b004daffb19872mr3228121lfl.4.1677080045700; Wed, 22 Feb 2023 07:34:05 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 14/20] xen/arm: ffa: support guest FFA_PARTITION_INFO_GET Date: Wed, 22 Feb 2023 16:33:11 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support in the mediator to handle FFA_PARTITION_INFO_GET requests from a guest. The requests are forwarded to the SPMC and the response is translated according to the FF-A version in use by the guest. Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the caller (the guest in this case), so once it is done with the buffer it must be released using FFA_RX_RELEASE before another call can be made. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 126 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 953b6dfd5eca..3571817c0bcd 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -141,6 +141,12 @@ #define FFA_MSG_POLL 0x8400006AU /* Partition information descriptor */ +struct ffa_partition_info_1_0 { + uint16_t id; + uint16_t execution_context; + uint32_t partition_properties; +}; + struct ffa_partition_info_1_1 { uint16_t id; uint16_t execution_context; @@ -157,9 +163,8 @@ struct ffa_ctx { uint32_t guest_vers; bool tx_is_mine; bool interrupted; + spinlock_t lock; }; - - /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -173,10 +178,16 @@ static unsigned int subscr_vm_destroyed_count __read_mostly; * Our rx/tx buffers shared with the SPMC. * * ffa_page_count is the number of pages used in each of these buffers. + * + * The RX buffer is protected from concurrent usage with ffa_rx_buffer_lock. + * Note that the SPMC is also tracking the ownership of our RX buffer so + * for calls which uses our RX buffer to deliver a result we must call + * ffa_rx_release() to let the SPMC know that we're done with the buffer. */ static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; static unsigned int ffa_page_count __read_mostly; +static DEFINE_SPINLOCK(ffa_rx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -463,6 +474,98 @@ static uint32_t handle_rxtx_unmap(void) return FFA_RET_OK; } +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, + uint32_t w4, uint32_t w5, + uint32_t *count) +{ + bool query_count_only = w5 & FFA_PARTITION_INFO_GET_COUNT_FLAG; + uint32_t w5_mask = 0; + uint32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + /* + * FF-A v1.0 has w5 MBZ while v1.1 allows + * FFA_PARTITION_INFO_GET_COUNT_FLAG to be non-zero. + */ + if ( ctx->guest_vers == FFA_VERSION_1_1 ) + w5_mask = FFA_PARTITION_INFO_GET_COUNT_FLAG; + if ( w5 & ~w5_mask ) + return FFA_RET_INVALID_PARAMETERS; + + if ( query_count_only ) + return ffa_partition_info_get(w1, w2, w3, w4, w5, count); + + if ( !ffa_page_count ) + return FFA_RET_DENIED; + + spin_lock(&ctx->lock); + spin_lock(&ffa_rx_buffer_lock); + if ( !ctx->page_count || !ctx->tx_is_mine ) + goto out; + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); + if ( ret ) + goto out; + + if ( ctx->guest_vers == FFA_VERSION_1_0 ) + { + size_t n; + struct ffa_partition_info_1_1 *src = ffa_rx; + struct ffa_partition_info_1_0 *dst = ctx->rx; + + if ( ctx->page_count * FFA_PAGE_SIZE < *count * sizeof(*dst) ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + for ( n = 0; n < *count; n++ ) + { + dst[n].id = src[n].id; + dst[n].execution_context = src[n].execution_context; + dst[n].partition_properties = src[n].partition_properties; + } + } + else + { + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); + + if ( ctx->page_count * FFA_PAGE_SIZE < sz ) + { + ret = FFA_RET_NO_MEMORY; + goto out_rx_release; + } + + + memcpy(ctx->rx, ffa_rx, sz); + } + ctx->tx_is_mine = false; +out_rx_release: + ffa_rx_release(); +out: + spin_unlock(&ffa_rx_buffer_lock); + spin_unlock(&ctx->lock); + + return ret; +} + +static uint32_t handle_rx_release(void) +{ + uint32_t ret = FFA_RET_DENIED; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + + spin_lock(&ctx->lock); + if ( !ctx->page_count || ctx->tx_is_mine ) + goto out; + ret = FFA_RET_OK; + ctx->tx_is_mine = true; +out: + spin_unlock(&ctx->lock); + + return ret; +} + static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) { struct arm_smccc_1_2_regs arg = { .a0 = fid, }; @@ -528,6 +631,7 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) uint32_t fid = get_user_reg(regs, 0); struct domain *d = current->domain; struct ffa_ctx *ctx = d->arch.tee; + uint32_t count; int e; if ( !ctx ) @@ -559,6 +663,24 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) else set_regs_success(regs, 0, 0); return true; + case FFA_PARTITION_INFO_GET: + e = handle_partition_info_get(get_user_reg(regs, 1), + get_user_reg(regs, 2), + get_user_reg(regs, 3), + get_user_reg(regs, 4), + get_user_reg(regs, 5), &count); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, count, 0); + return true; + case FFA_RX_RELEASE: + e = handle_rx_release(); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; case FFA_MSG_SEND_DIRECT_REQ_32: #ifdef CONFIG_ARM_64 case FFA_MSG_SEND_DIRECT_REQ_64: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499552.770837 (Exim 4.92) (envelope-from ) id 1pUr8J-0004aR-2D; Wed, 22 Feb 2023 15:34:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499552.770837; Wed, 22 Feb 2023 15:34:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8H-0004Uq-Mz; Wed, 22 Feb 2023 15:34:13 +0000 Received: by outflank-mailman (input) for mailman id 499552; Wed, 22 Feb 2023 15:34:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8C-0001MH-FF for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:08 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 578f1631-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:06 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id f18so10544559lfa.3 for ; Wed, 22 Feb 2023 07:34:06 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 578f1631-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/X5KC3KPrylB3VOA87nQRK8zMTV0Yo7K5jzAEfaZqM=; b=BiBI0jbPKBI4welALwUtVN89qYfR1BkiTBwDkT+C+bFarA7eY6ZdgmyUhfcVoS/s7i fXFHx6g832m6SZgh/t7IJsN88hltOFTld2HhEPu4QaYwfl3vANaBPgWrmO5Lp0mGWbDL x+lQPW4lbO9T59cm5Mrgx5T+W/elLyPsnXGTnziFG5UCPI/qdFZvAdwiLSnmOzPRpvW4 drWtFTcmGlkd8EjrT65Gen771+9AQVo9CcDQg1mEtNZMo18qgmcHWJ+ZXVt6m+V0j+oA dbg6qQyOv0n78sT+K9SsZ3VLR7DOx/lFAYF3GIdAg4eVQnd2OptSu0GKMyHTuos75W10 79AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G/X5KC3KPrylB3VOA87nQRK8zMTV0Yo7K5jzAEfaZqM=; b=EbEamxhxbhQsoinuNhFVaSOMWnm+4Ir9PC1Riy3rrRlyewUGof9BGy2y1MToGEnj4t 27Oav7m24cv8xJAtzxofvikeViWexoe7KbfBeXr6D6oAFuKPdAclAmlr0KxtRdC/LwM3 fKZZkZVG3JcNgK88MU8mopICJI94KA1xbgu/VJji1wcFwq98PgsqvXunT4WF7tiWGc1x ga3tiGe8rUkU/pP2koNmXohJM0kfVcF+eYvkVOc/YB1swgDpTuht2Lu2aAI3/huUQCbi bh2MlqxvbeuG50MDCFl+K7WsFGqOmLcmpX7xEK9mYEHJzyDiDSNga3CU50hGMzBTFSg3 sGOw== X-Gm-Message-State: AO0yUKUoPtIcvm/S6FF2vZ4JXarcsFvSBMJswuDCRHkIf3vIERqfsyuU YE26ngsevYlIJhYShkBAo4q3WISZ68/5x4XIxKM= X-Google-Smtp-Source: AK7set+y8n4M2F+vnq1AqE4NZOLtp1Zn6O1TO09h1u14zQ6vavsu3iXYmjkK47rB0n7oRpzNE3zN7w== X-Received: by 2002:a05:6512:31cd:b0:4db:5120:367 with SMTP id j13-20020a05651231cd00b004db51200367mr3754959lfe.31.1677080046518; Wed, 22 Feb 2023 07:34:06 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: [XEN PATCH v7 15/20] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h Date: Wed, 22 Feb 2023 16:33:12 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Moves the two helper functions regpair_to_uint64() and uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm specific regs.h. This enables reuse of these functions in the FF-A mediator in a subsequent patch. Reviewed-by: Michal Orzel Signed-off-by: Jens Wiklander --- xen/arch/arm/include/asm/regs.h | 12 ++++++++++++ xen/arch/arm/tee/optee.c | 11 ----------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/include/asm/regs.h b/xen/arch/arm/include/asm/regs.h index 0693a681315f..aa39e83ee5f4 100644 --- a/xen/arch/arm/include/asm/regs.h +++ b/xen/arch/arm/include/asm/regs.h @@ -60,6 +60,18 @@ static inline bool guest_mode(const struct cpu_user_regs *r) register_t get_user_reg(struct cpu_user_regs *regs, int reg); void set_user_reg(struct cpu_user_regs *regs, int reg, register_t val); +static inline uint64_t regpair_to_uint64(register_t reg0, register_t reg1) +{ + return ((uint64_t)reg0 << 32) | (uint32_t)reg1; +} + +static inline void uint64_to_regpair(register_t *reg0, register_t *reg1, + uint64_t val) +{ + *reg0 = val >> 32; + *reg1 = (uint32_t)val; +} + #endif #endif /* __ARM_REGS_H__ */ diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 9cb9f16d43cb..47027ecef47c 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -268,17 +268,6 @@ static int optee_domain_init(struct domain *d) return 0; } -static uint64_t regpair_to_uint64(register_t reg0, register_t reg1) -{ - return ((uint64_t)reg0 << 32) | (uint32_t)reg1; -} - -static void uint64_to_regpair(register_t *reg0, register_t *reg1, uint64_t val) -{ - *reg0 = val >> 32; - *reg1 = (uint32_t)val; -} - static struct page_info *get_domain_ram_page(gfn_t gfn) { struct page_info *page; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499553.770849 (Exim 4.92) (envelope-from ) id 1pUr8K-0004ro-Ai; Wed, 22 Feb 2023 15:34:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499553.770849; Wed, 22 Feb 2023 15:34:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8J-0004iT-6u; Wed, 22 Feb 2023 15:34:15 +0000 Received: by outflank-mailman (input) for mailman id 499553; Wed, 22 Feb 2023 15:34:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8C-0001MC-Bc for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:08 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 589ce21f-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:07 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id g8so6807600lfj.2 for ; Wed, 22 Feb 2023 07:34:07 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 589ce21f-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qhAiY5OLLPHeZBZaC/MjkG52+6CXwzhSsS3y4KPhi9A=; b=cky4pHS//IDFn8KcURyNgEQyvp6E4MB4IMdKlCgh47mvVsRQlq9BRRMlVq8DdZL8jb eMuzQbcLf4sF/lfyHIHRni4sEPnlikqeVLYcW5Ku+sGPopazRytm7RDXOhc739bzWQsI JySIaXdFwJjbsHB2ePyF4iiiWuClN+EUfie3s/rkur03emkjT57nxcpg/0abTSwpQ89S mZD/CJtVpeZnvrccbmeva3AsuRZWB4l68xCDfjIYKKVaEPOwVvryAn6PUzOm4ZjnFutJ WpHEmbRuXwSd/QQbYwtmz/5SiySYHrNKK4JNk6eSrm97uIVFnlBPofTOjRry2XxdVyLf zhQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qhAiY5OLLPHeZBZaC/MjkG52+6CXwzhSsS3y4KPhi9A=; b=i/OCr7sKGqRbCgT3VHvEK1Q30aBJJa2FQjlPWbPQGZWrp2VIXydpOmMPVxQXTULY0j EuVJkPaQlHIC2ZpnFPmmi0ubjSPjG+etcFGGgHe/KOPToOsQSICt+aSZgQOe6z/0gjA9 TFi6vLNcGgGgsN3D9mypiyEbXGqziKJZ2KwzVO6L2X4aFeYY201qlunPEbXwPK0B375A mT/FR2HRiqqDNTiiZIm1feKSMAC9l4jBXlXimC/a93M7oXE7WrxPwOx/CzkjCLsCO33H ZD5vZC9JxTxrqEVsQcrXINl6SwleOFaYBTnkpMkU7PJq8jmitiuW7uTdY/0ddu0NVMw0 RPMQ== X-Gm-Message-State: AO0yUKXzjSJH3yloYpRtBwlRBqCzBjQFyQEWvxoIstqpJqAyVhust2W5 IKikGaRX5E7SHvyk8XsoEQMySJUmOmgRb0HZ3D4= X-Google-Smtp-Source: AK7set/kmBjenoML7LDyTljAhBrKRq++3DX/KZvrrW+9a4EJ0hpd35LEVJfNiOGCpNNLk1MoOSkTyg== X-Received: by 2002:ac2:54b0:0:b0:4d2:72bf:7382 with SMTP id w16-20020ac254b0000000b004d272bf7382mr2950346lfk.37.1677080047369; Wed, 22 Feb 2023 07:34:07 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 16/20] xen/arm: ffa: add defines for sharing memory Date: Wed, 22 Feb 2023 16:33:13 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds defines needed for sharing using the function FFA_MEM_SHARE and friends. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 57 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 3571817c0bcd..bfd378f7fcd7 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -22,6 +22,14 @@ #include #include +/* + * References: + * FF-A-1.0-REL: FF-A specification version 1.0 available at + * https://developer.arm.com/documentation/den0077/a + * FF-A-1.1-REL0: FF-A specification version 1.1 available at + * https://developer.arm.com/documentation/den0077/e + */ + /* Error codes */ #define FFA_RET_OK 0 #define FFA_RET_NOT_SUPPORTED -1 @@ -66,6 +74,55 @@ */ #define FFA_PAGE_SIZE SZ_4K +/* + * Limit for shared buffer size. Please note that this define limits + * number of pages. But user buffer can be not aligned to a page + * boundary. So it is possible that user would not be able to share + * exactly FFA_MAX_SHM_BUFFER_PG * FFA_PAGE_SIZE bytes. + * + * FF-A doesn't have any direct requirments on GlobalPlatform or vice + * versa, but an implementation can very well use FF-A in order to provide + * a GlobalPlatform interface on top. + * + * Global Platform specification for TEE requires that any TEE + * implementation should allow to share buffers with size of at least + * 512KB. Due to align issue mentioned above, we need to increase this + * value with one. + */ +#define FFA_MAX_SHM_PAGE_COUNT (SZ_512K / FFA_PAGE_SIZE + 1) + +/* + * Limits the number of shared buffers that guest can have at once. This + * is to prevent case, when guests tricks XEN into exhausting its own + * memory by allocating many small buffers. This value has been chosen + * arbitrary. + */ +#define FFA_MAX_SHM_COUNT 32 + +/* FF-A-1.1-REL0 section 10.9.2 Memory region handle, page 167 */ +#define FFA_HANDLE_HYP_FLAG BIT(63, ULL) +#define FFA_HANDLE_INVALID 0xffffffffffffffffULL + +/* + * The bits for FFA_NORMAL_MEM_REG_ATTR FFA_MEM_ACC_RW below are + * defined in FF-A-1.1-REL0 Table 10.18 at page 175. + */ + /* Memory attributes: Normal memory, Write-Back cacheable, Inner shareable */ +#define FFA_NORMAL_MEM_REG_ATTR 0x2fU +/* Memory access permissions: Read-write */ +#define FFA_MEM_ACC_RW 0x2U + +/* FF-A-1.1-REL0 section 10.11.4 Flags usage, page 184-187 */ +/* Clear memory before mapping in receiver */ +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) +/* Relayer may time slice this operation */ +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) +/* Clear memory after receiver relinquishes it */ +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) +/* Share memory transaction */ +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (1U << 3) + + /* Framework direct request/response */ #define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) #define FFA_MSG_TYPE_MASK 0xFFU; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499554.770862 (Exim 4.92) (envelope-from ) id 1pUr8N-0005Pj-5s; Wed, 22 Feb 2023 15:34:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499554.770862; Wed, 22 Feb 2023 15:34:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8L-0005HY-VU; Wed, 22 Feb 2023 15:34:17 +0000 Received: by outflank-mailman (input) for mailman id 499554; Wed, 22 Feb 2023 15:34:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8E-0001MH-Nb for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:10 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58c7bb9a-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:08 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id i9so10367529lfc.6 for ; Wed, 22 Feb 2023 07:34:09 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58c7bb9a-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8mpbdpWvkQP3NZC61nZP/NPeTV2c8jtDhk5/FkNx/Xw=; b=hmD0HnFwUA9POGeBbCmOz3zaonZ39Kq5HvhDBcqw4q4BOOQV/dU0BVezOkVQShkaoM ZsXwZKJYYOFCM7MY0jtygaykHy/TqeFJHl/nToc3gyFVK3WEy4QdS3tZJSvsk/2L5Pxd 24i+LVCwqjOJtB2JPUiQCQajkohPAKRb9SQJayOwH9ayLS/WwM+yem+vjYAGtOxkWbzi k1jtSfjVv0jFUXJ+jGK/bDU1WkhAtdbH+0rb3+R1RgnhnDOFxGm4rhsFdzoswJWFXDP2 wa0lZaL/nZJhSTSKBRaLFZws+puREJRWuRnGrHVsriSZmpv8g9N6+WAd91ybtpI8nwgI 0xiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8mpbdpWvkQP3NZC61nZP/NPeTV2c8jtDhk5/FkNx/Xw=; b=EyJe4d9v6CWMr9+CXlOFvGi+YefvsIA8juXmwqL+z8oo5pQws4lBTVCyqmUrqmkdLv GV/0Z/A19Mgjm/NoNiTHcvrLMBUcZv+FftLKkrAI9Mal2kfWnEz319edpyqtlSUHeJ98 Apv1hXupx8JM53Lsgnq+zjjZ3vhLZEJEUAFcc5hGClaSsUNET2fu2Ck6t6b6MSvCSttz oolYJEzCRIH66WI9EIo12U4WUnpubwudfVStrdDcDI2gTauK22Fp232Ji2XHJzPHkhct G1YCDaQDORmHW0fRYHc7PXgd0Pp0WhcNevCLxZwiCU5DHg89jE79S8+1LDCwpZ4PrYTD WRXg== X-Gm-Message-State: AO0yUKW0scNVQk/EARNBIKtLvgWOkcIqwfLhN5ClHsqfQJu6ZuN6Hk/X DOYG1K1HJNm1SQQY5MjDKNZ34f+gCRm6zREQ1KE= X-Google-Smtp-Source: AK7set+0TRegHa85MMH11cxIFnQQ6a0Xj9077dunvyV3UVJYeFbfsDVnZWDz2A/+evM6CP8tk9cPHQ== X-Received: by 2002:ac2:4c0f:0:b0:4cb:2c19:ec21 with SMTP id t15-20020ac24c0f000000b004cb2c19ec21mr2816894lfq.0.1677080048376; Wed, 22 Feb 2023 07:34:08 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 17/20] xen/arm: ffa: add ABI structs for sharing memory Date: Wed, 22 Feb 2023 16:33:14 +0100 Message-Id: <50da283fe4a91820a818d13db4ce50fd8414580a.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds the ABI structs used by function FFA_MEM_SHARE and friends for sharing memory. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 74 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index bfd378f7fcd7..94c90b252454 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -197,6 +197,11 @@ #define FFA_MSG_SEND 0x8400006EU #define FFA_MSG_POLL 0x8400006AU +/* + * Structs below ending with _1_0 are defined in FF-A-1.0-REL and + * struct ending with _1_1 are defined in FF-A-1.1-REL0. + */ + /* Partition information descriptor */ struct ffa_partition_info_1_0 { uint16_t id; @@ -211,6 +216,75 @@ struct ffa_partition_info_1_1 { uint8_t uuid[16]; }; +/* Constituent memory region descriptor */ +struct ffa_address_range { + uint64_t address; + uint32_t page_count; + uint32_t reserved; +}; + +/* Composite memory region descriptor */ +struct ffa_mem_region { + uint32_t total_page_count; + uint32_t address_range_count; + uint64_t reserved; + struct ffa_address_range address_range_array[]; +}; + +/* Memory access permissions descriptor */ +struct ffa_mem_access_perm { + uint16_t endpoint_id; + uint8_t perm; + uint8_t flags; +}; + +/* Endpoint memory access descriptor */ +struct ffa_mem_access { + struct ffa_mem_access_perm access_perm; + uint32_t region_offs; + uint64_t reserved; +}; + +/* Lend, donate or share memory transaction descriptor */ +struct ffa_mem_transaction_1_0 { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t reserved0; + uint32_t flags; + uint64_t global_handle; + uint64_t tag; + uint32_t reserved1; + uint32_t mem_access_count; + struct ffa_mem_access mem_access_array[]; +}; + +struct ffa_mem_transaction_1_1 { + uint16_t sender_id; + uint16_t mem_reg_attr; + uint32_t flags; + uint64_t global_handle; + uint64_t tag; + uint32_t mem_access_size; + uint32_t mem_access_count; + uint32_t mem_access_offs; + uint8_t reserved[12]; +}; + +/* Endpoint RX/TX descriptor */ +struct ffa_endpoint_rxtx_descriptor_1_0 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_range_count; + uint32_t tx_range_count; +}; + +struct ffa_endpoint_rxtx_descriptor_1_1 { + uint16_t sender_id; + uint16_t reserved; + uint32_t rx_region_offs; + uint32_t tx_region_offs; +}; + struct ffa_ctx { void *rx; const void *tx; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:34:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:34:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499555.770874 (Exim 4.92) (envelope-from ) id 1pUr8O-00061J-Uy; Wed, 22 Feb 2023 15:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499555.770874; Wed, 22 Feb 2023 15:34:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8N-0005sA-TL; Wed, 22 Feb 2023 15:34:19 +0000 Received: by outflank-mailman (input) for mailman id 499555; Wed, 22 Feb 2023 15:34:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8E-0001MC-Vd for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:11 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59ccab43-b2c6-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 16:34:09 +0100 (CET) Received: by mail-lj1-x233.google.com with SMTP id e9so8175052ljn.9 for ; Wed, 22 Feb 2023 07:34:09 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:08 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59ccab43-b2c6-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WdZRzPZwwG/fX18/7IY+cXVLO7gdKBMeAYMh6i/Po7k=; b=G/wGOj70DT2gTYZ1rb27kBnjEeoBKT2iz7tYG0j3W8jVJqtY+8oUPhsEv2SHPNVMdM BZ7L8XSESD4d6uKRp3XufeK6qAPjKSAPle4QJbHE9Wc0OH8x6Gu/CP8rm36LMzxuqeKz MzVBNqsok20kbWrVXbHZLwMEt3MjA4LqCFLku5X77ksLaOVPwOQDRTzZJ59UTFi51apn Mdt6vwMkgzZoKNvIXq39DOAkfew4HNGZbMYvT0+mUS39FvCFFU+hE2m1p8H0il2clKq/ sF11GGJpTYRlF3ZIdSB4eeX2G0a3B50iulvyxP+XVbH/tZVO4IHw0rBB/IvrwKKMbYLM GAZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WdZRzPZwwG/fX18/7IY+cXVLO7gdKBMeAYMh6i/Po7k=; b=7WjDskTi0RMlWeO4nbk8hNz2r7sKAzwFhRT2ZNhvZ28KLFxZyJNw85TZgHxytPRsQp UYzdyeq9P0DXXGpojOl2kIiTLdWzrazJTLmmu5SxYdWh3gDyBVaXVtIExZqbPdBV1vOi tadeeewLM/z626V5ppmOUGvn6k73Q2kqHPK6HEDCjVDfhPe3rmZ/V7WzWxPFvzYnm35m Ra+El5S29+77oqtIu3A8lgR9IFSIo0a6ltkJZxE2xg5PvnpAxHcVYLW0yFYAfj4SMIC2 AXPRCuYXYL8wscB8EhJ8juxuH3XCIfiR8JRnEuCJQABiTRjqKd2zZi6AVPJjdxPB58BL +Fgw== X-Gm-Message-State: AO0yUKUwad4CKsh8Geg9w4JUttSPGpNtl1qH5uRi6PjVEZX0r7SeuMp2 dh7D4cLsmW7iPk1DS89dEM5azqrtUGj1r5bmC9k= X-Google-Smtp-Source: AK7set84sywa4fkmKPbl5uTdh5VQbx094u7I4/4RMrHRGuNExAM2+/Lr/2FvTbA0oqXQmG7/mz4gFw== X-Received: by 2002:a2e:964f:0:b0:294:712a:5190 with SMTP id z15-20020a2e964f000000b00294712a5190mr3263154ljh.28.1677080049263; Wed, 22 Feb 2023 07:34:09 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory Date: Wed, 22 Feb 2023 16:33:15 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for a guest to share memory with an SP using FFA_MEM_SHARE and FFA_MEM_RECLAIM. Only small memory regions can be shared using a single call to FFA_MEM_SHARE are supported. A memory region that doesn't need to be shared any longer can be reclaimed with FFA_MEM_RECLAIM once the SP doesn't use it any longer. This is checked by the SPMC and not in control of the mediator. With this commit we have a FF-A version 1.1 [1] mediator able to communicate with a Secure Partition in secure world using shared memory. The secure world must use FF-A version 1.1, but the guest is free to use version 1.0 or version 1.1. Adds a check that the SP supports the needed FF-A features FFA_MEM_SHARE_64 or FFA_MEM_SHARE_32. [1] https://developer.arm.com/documentation/den0077/latest Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 491 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 491 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 94c90b252454..cdc286caf62c 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -270,6 +270,38 @@ struct ffa_mem_transaction_1_1 { uint8_t reserved[12]; }; +/* Calculate offset of struct ffa_mem_access from start of buffer */ +#define MEM_ACCESS_OFFSET(access_idx) \ + ( sizeof(struct ffa_mem_transaction_1_1) + \ + ( access_idx ) * sizeof(struct ffa_mem_access) ) + +/* Calculate offset of struct ffa_mem_region from start of buffer */ +#define REGION_OFFSET(access_count, region_idx) \ + ( MEM_ACCESS_OFFSET(access_count) + \ + ( region_idx ) * sizeof(struct ffa_mem_region) ) + +/* Calculate offset of struct ffa_address_range from start of buffer */ +#define ADDR_RANGE_OFFSET(access_count, region_count, range_idx) \ + ( REGION_OFFSET(access_count, region_count) + \ + ( range_idx ) * sizeof(struct ffa_address_range) ) + +/* + * The parts needed from struct ffa_mem_transaction_1_0 or struct + * ffa_mem_transaction_1_1, used to provide an abstraction of difference in + * data structures between version 1.0 and 1.1. This is just an internal + * interface and can be changed without changing any ABI. + */ +struct ffa_mem_transaction_x { + uint16_t sender_id; + uint8_t mem_reg_attr; + uint8_t flags; + uint8_t mem_access_size; + uint8_t mem_access_count; + uint16_t mem_access_offs; + uint64_t global_handle; + uint64_t tag; +}; + /* Endpoint RX/TX descriptor */ struct ffa_endpoint_rxtx_descriptor_1_0 { uint16_t sender_id; @@ -294,8 +326,20 @@ struct ffa_ctx { uint32_t guest_vers; bool tx_is_mine; bool interrupted; + struct list_head shm_list; + unsigned int shm_count; spinlock_t lock; }; + +struct ffa_shm_mem { + struct list_head list; + uint16_t sender_id; + uint16_t ep_id; /* endpoint, the one lending */ + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ + unsigned int page_count; + struct page_info *pages[]; +}; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -310,6 +354,8 @@ static unsigned int subscr_vm_destroyed_count __read_mostly; * * ffa_page_count is the number of pages used in each of these buffers. * + * The TX buffer is protected from concurrent usage with ffa_tx_buffer_lock. + * * The RX buffer is protected from concurrent usage with ffa_rx_buffer_lock. * Note that the SPMC is also tracking the ownership of our RX buffer so * for calls which uses our RX buffer to deliver a result we must call @@ -319,6 +365,7 @@ static void *ffa_rx __read_mostly; static void *ffa_tx __read_mostly; static unsigned int ffa_page_count __read_mostly; static DEFINE_SPINLOCK(ffa_rx_buffer_lock); +static DEFINE_SPINLOCK(ffa_tx_buffer_lock); static bool ffa_get_version(uint32_t *vers) { @@ -429,6 +476,42 @@ static int32_t ffa_rx_release(void) return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); } +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, + register_t addr, uint32_t pg_count, + uint64_t *handle) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_SHARE_32, + .a1 = tot_len, + .a2 = frag_len, + .a3 = addr, + .a4 = pg_count, + }; + struct arm_smccc_1_2_regs resp; + + if ( IS_ENABLED(CONFIG_ARM_64) ) + arg.a0 = FFA_MEM_SHARE_64; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + *handle = regpair_to_uint64(resp.a3, resp.a2); + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + *handle = regpair_to_uint64(resp.a2, resp.a1); + return resp.a3; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, uint8_t msg) { @@ -757,6 +840,404 @@ out: resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & mask); } +/* + * Gets all page and assigns them to the supplied shared memory object. If + * this function fails then the caller is still expected to call + * put_shm_pages() as a cleanup. + */ +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, + const struct ffa_address_range *range, + uint32_t range_count, unsigned int start_page_idx, + unsigned int *last_page_idx) +{ + unsigned int pg_idx = start_page_idx; + gfn_t gfn; + unsigned int n; + unsigned int m; + p2m_type_t t; + uint64_t addr; + + for ( n = 0; n < range_count; n++ ) + { + for ( m = 0; m < range[n].page_count; m++ ) + { + if ( pg_idx >= shm->page_count ) + return FFA_RET_INVALID_PARAMETERS; + + addr = read_atomic(&range[n].address); + gfn = gaddr_to_gfn(addr + m * FFA_PAGE_SIZE); + shm->pages[pg_idx] = get_page_from_gfn(d, gfn_x(gfn), &t, + P2M_ALLOC); + if ( !shm->pages[pg_idx] ) + return FFA_RET_DENIED; + pg_idx++; + /* Only normal RAM for now */ + if ( !p2m_is_ram(t) ) + return FFA_RET_DENIED; + } + } + + *last_page_idx = pg_idx; + + return FFA_RET_OK; +} + +static void put_shm_pages(struct ffa_shm_mem *shm) +{ + unsigned int n; + + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) + { + put_page(shm->pages[n]); + shm->pages[n] = NULL; + } +} + +static struct ffa_shm_mem *alloc_ffa_shm_mem(struct ffa_ctx *ctx, + unsigned int page_count) +{ + struct ffa_shm_mem *shm; + + if ( page_count >= FFA_MAX_SHM_PAGE_COUNT || + ctx->shm_count >= FFA_MAX_SHM_COUNT ) + return NULL; + + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); + if ( shm ) + { + ctx->shm_count++; + shm->page_count = page_count; + } + + return shm; +} + +static void free_ffa_shm_mem(struct ffa_ctx *ctx, struct ffa_shm_mem *shm) +{ + if ( shm ) { + ASSERT(ctx->shm_count > 0); + ctx->shm_count--; + put_shm_pages(shm); + xfree(shm); + } +} + +static void init_range(struct ffa_address_range *addr_range, + paddr_t pa) +{ + memset(addr_range, 0, sizeof(*addr_range)); + addr_range->address = pa; + addr_range->page_count = 1; +} + +/* + * This function uses the ffa_tx buffer to transmit the memory transaction + * descriptor. The function depends ffa_tx_buffer_lock to be used to guard + * the buffer from concurrent use. + */ +static int share_shm(struct ffa_shm_mem *shm) +{ + const uint32_t max_frag_len = ffa_page_count * FFA_PAGE_SIZE; + struct ffa_mem_access *mem_access_array; + struct ffa_mem_transaction_1_1 *descr; + struct ffa_address_range *addr_range; + struct ffa_mem_region *region_descr; + const unsigned int region_count = 1; + void *buf = ffa_tx; + uint32_t frag_len; + uint32_t tot_len; + paddr_t last_pa; + unsigned int n; + paddr_t pa; + + ASSERT(spin_is_locked(&ffa_tx_buffer_lock)); + if ( !shm->page_count ) + { + ASSERT_UNREACHABLE(); + return FFA_RET_INVALID_PARAMETERS; + } + + descr = buf; + memset(descr, 0, sizeof(*descr)); + descr->sender_id = shm->sender_id; + descr->global_handle = shm->handle; + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; + descr->mem_access_count = 1; + descr->mem_access_size = sizeof(*mem_access_array); + descr->mem_access_offs = MEM_ACCESS_OFFSET(0); + + mem_access_array = buf + descr->mem_access_offs; + memset(mem_access_array, 0, sizeof(*mem_access_array)); + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; + mem_access_array[0].region_offs = REGION_OFFSET(descr->mem_access_count, 0); + + region_descr = buf + mem_access_array[0].region_offs; + memset(region_descr, 0, sizeof(*region_descr)); + region_descr->total_page_count = shm->page_count; + + region_descr->address_range_count = 1; + last_pa = page_to_maddr(shm->pages[0]); + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + continue; + region_descr->address_range_count++; + } + + tot_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, + region_descr->address_range_count); + if ( tot_len > max_frag_len ) + return FFA_RET_NOT_SUPPORTED; + + addr_range = region_descr->address_range_array; + frag_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, 1); + last_pa = page_to_maddr(shm->pages[0]); + init_range(addr_range, last_pa); + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) + { + pa = page_to_maddr(shm->pages[n]); + if ( last_pa + FFA_PAGE_SIZE == pa ) + { + addr_range->page_count++; + continue; + } + + frag_len += sizeof(*addr_range); + addr_range++; + init_range(addr_range, pa); + } + + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); +} + +static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, + struct ffa_mem_transaction_x *trans) +{ + uint16_t mem_reg_attr; + uint32_t flags; + uint32_t count; + uint32_t offs; + uint32_t size; + + if ( ffa_vers >= FFA_VERSION_1_1 ) + { + const struct ffa_mem_transaction_1_1 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->global_handle = descr->global_handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = descr->mem_access_size; + offs = descr->mem_access_offs; + } + else + { + const struct ffa_mem_transaction_1_0 *descr; + + if ( blen < sizeof(*descr) ) + return FFA_RET_INVALID_PARAMETERS; + + descr = buf; + trans->sender_id = descr->sender_id; + mem_reg_attr = descr->mem_reg_attr; + flags = descr->flags; + trans->global_handle = descr->global_handle; + trans->tag = descr->tag; + + count = descr->mem_access_count; + size = sizeof(struct ffa_mem_access); + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); + } + /* + * Make sure that "descr" which is shared with the guest isn't accessed + * again after this point. + */ + barrier(); + + /* + * We're doing a rough check to see that no information is lost when + * tranfering the values into a struct ffa_mem_transaction_x below. The + * fields in struct ffa_mem_transaction_x are wide enough to hold any + * valid value so being out of range means that something is wrong. + */ + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || + count > UINT8_MAX || offs > UINT16_MAX ) + return FFA_RET_INVALID_PARAMETERS; + + /* Check that the endpoint memory access descriptor array fits */ + if ( size * count + offs > blen ) + return FFA_RET_INVALID_PARAMETERS; + + trans->mem_reg_attr = mem_reg_attr; + trans->flags = flags; + trans->mem_access_size = size; + trans->mem_access_count = count; + trans->mem_access_offs = offs; + + return 0; +} + +static void handle_mem_share(struct cpu_user_regs *regs) +{ + uint32_t tot_len = get_user_reg(regs, 1); + uint32_t frag_len = get_user_reg(regs, 2); + uint64_t addr = get_user_reg(regs, 3); + uint32_t page_count = get_user_reg(regs, 4); + const struct ffa_mem_region *region_descr; + const struct ffa_mem_access *mem_access; + struct ffa_mem_transaction_x trans; + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct ffa_shm_mem *shm = NULL; + unsigned int last_page_idx = 0; + register_t handle_hi = 0; + register_t handle_lo = 0; + int ret = FFA_RET_DENIED; + uint32_t range_count; + uint32_t region_offs; + + /* + * We're only accepting memory transaction descriptors via the rx/tx + * buffer. + */ + if ( addr ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_set_ret; + } + + /* Check that fragment length doesn't exceed total length */ + if ( frag_len > tot_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_set_ret; + } + + /* We currently only support a single fragment */ + if ( frag_len != tot_len ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_set_ret; + } + + spin_lock(&ctx->lock); + + if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) + goto out_unlock; + + if ( !ffa_page_count ) + { + ret = FFA_RET_NO_MEMORY; + goto out_unlock; + } + + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); + if ( ret ) + goto out_unlock; + + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + /* Only supports sharing it with one SP for now */ + if ( trans.mem_access_count != 1 ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + if ( trans.sender_id != get_vm_id(d) ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out_unlock; + } + + /* Check that it fits in the supplied data */ + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) + goto out_unlock; + + mem_access = ctx->tx + trans.mem_access_offs; + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_offs = read_atomic(&mem_access->region_offs); + if ( sizeof(*region_descr) + region_offs > frag_len ) + { + ret = FFA_RET_NOT_SUPPORTED; + goto out_unlock; + } + + region_descr = ctx->tx + region_offs; + range_count = read_atomic(®ion_descr->address_range_count); + page_count = read_atomic(®ion_descr->total_page_count); + + shm = alloc_ffa_shm_mem(ctx, page_count); + if ( !shm ) + { + ret = FFA_RET_NO_MEMORY; + goto out_unlock; + } + shm->sender_id = trans.sender_id; + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); + + /* + * Check that the Composite memory region descriptor fits. + */ + if ( sizeof(*region_descr) + region_offs + + range_count * sizeof(struct ffa_address_range) > frag_len ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, + 0, &last_page_idx); + if ( ret ) + goto out; + if ( last_page_idx != shm->page_count ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret ) + goto out; + + list_add_tail(&shm->list, &ctx->shm_list); + + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + +out: + if ( ret ) + free_ffa_shm_mem(ctx, shm); +out_unlock: + spin_unlock(&ctx->lock); + +out_set_ret: + if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -818,6 +1299,12 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) #endif handle_msg_send_direct_req(regs, fid); return true; + case FFA_MEM_SHARE_32: +#ifdef CONFIG_ARM_64 + case FFA_MEM_SHARE_64: +#endif + handle_mem_share(regs); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -857,6 +1344,8 @@ static int ffa_domain_init(struct domain *d) } } + INIT_LIST_HEAD(&ctx->shm_list); + d->arch.tee = ctx; return 0; @@ -1012,11 +1501,13 @@ static bool ffa_probe(void) !check_mandatory_feature(FFA_RX_RELEASE) || #ifdef CONFIG_ARM_64 !check_mandatory_feature(FFA_RXTX_MAP_64) || + !check_mandatory_feature(FFA_MEM_SHARE_64) || #endif #ifdef CONFIG_ARM_32 !check_mandatory_feature(FFA_RXTX_MAP_32) || #endif !check_mandatory_feature(FFA_RXTX_UNMAP) || + !check_mandatory_feature(FFA_MEM_SHARE_32) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:39:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499642.770924 (Exim 4.92) (envelope-from ) id 1pUrD3-00048r-3n; Wed, 22 Feb 2023 15:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499642.770924; Wed, 22 Feb 2023 15:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrD2-00047w-SR; Wed, 22 Feb 2023 15:39:08 +0000 Received: by outflank-mailman (input) for mailman id 499642; Wed, 22 Feb 2023 15:39:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8G-0001MH-3p for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:12 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59bb165a-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:09 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id w27so10583974lfu.4 for ; Wed, 22 Feb 2023 07:34:10 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59bb165a-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L7KfqryCuiLTxh6V7wTFhyCR1D3Skcqadhm2jdw7Dpg=; b=buPVoqX4k+wFegkL/jsOQNHnwtRYALuPdIV2R1Q43tL4QfQQDMkPAsD6JccvuqSX/x p8yeHRPleXPwIEgmmkNjoYPQYfwv0nd3SmPWQqZQL6MZDj3jC3Zy8ybOHQnwnMGVtImk pTF2ASVOte+CYmGMoJ2+4jCYS3Yix9eRfelaR4gJo8+AuC/KMtryLZ8YRFnqlQnMOWXx UF67Hd7yckN/L+EX0n16HaMXJpxmjKEgp6UZfYRzuBEb5tyAacSGKJrlfjmdB2wFk3Hb itts9MsS5hRC/qzHI3bNFXVp4D9gGWk9eDi/HHcaFGYLHhK4BzEcCugkOg5NXAWSNSXh HPrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7KfqryCuiLTxh6V7wTFhyCR1D3Skcqadhm2jdw7Dpg=; b=VgpvMnuG3aNOp/IN2KwFOXIrSWH200eBEvlWkkTju1hb3c63ocBAKYap2hDUGksLKT cDHCXgIjVAilZmaavz3rUEOJlXr6MpCwIVmXpZDh2VvEoJqOxBEnmSew3XeHKHZuc9JE QBUwDPxf5AYKPubhtuViv43w+hOsGylmOLz1JSnf+lrAlLlOrbMtY7ceK1WeKpfGQ99A R1Izsij28Pd70oiHku1ZhG9xjpAo+vZZHlAfr9K6e1snAuXWiUN+OEOVFTdhjKdFEsMb As5P18C05YO0us0o8pc2K1W4PT6E3dxMzcHO4PZajQ9nDyT7XaWWfJOKQQB7Es+O+AsD R6SQ== X-Gm-Message-State: AO0yUKVf4JAu+gw/TBbMaA2/OxbsH62krgg9/XDebKIdLZHWqZW4tvVy WNKXFZ0TvV9k0xxjaSBFIsFii0i1daWN508PURY= X-Google-Smtp-Source: AK7set9AQLUVCBjm0EJ6SEfxAjBSS8LFZYBlQPJteDZtuDeT2rcECFkrQMoVQbHhHPG+EBuP2WABgg== X-Received: by 2002:ac2:554f:0:b0:4db:664d:7bb0 with SMTP id l15-20020ac2554f000000b004db664d7bb0mr3094883lfk.47.1677080050152; Wed, 22 Feb 2023 07:34:10 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 19/20] xen/arm: ffa: add support to reclaim shared memory Date: Wed, 22 Feb 2023 16:33:16 +0100 Message-Id: <6dda7c17462221fac26f45a8663370952e37040d.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support to reclaim memory previously shared with FFA_MEM_SHARE. Adds a check that the SP supports the needed FF-A feature FFA_MEM_RECLAIM. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 53 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index cdc286caf62c..3557edc455d0 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -512,6 +512,12 @@ static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, } } +static int32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, + uint32_t flags) +{ + return ffa_simple_call(FFA_MEM_RECLAIM, handle_lo, handle_hi, flags, 0); +} + static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, uint8_t msg) { @@ -1238,6 +1244,43 @@ out_set_ret: set_regs_error(regs, ret); } +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + struct ffa_shm_mem *shm; + register_t handle_hi; + register_t handle_lo; + int ret; + + spin_lock(&ctx->lock); + list_for_each_entry(shm, &ctx->shm_list, list) + { + if ( shm->handle == handle ) + goto found_it; + } + shm = NULL; + ret = FFA_RET_INVALID_PARAMETERS; + goto out; +found_it: + + uint64_to_regpair(&handle_hi, &handle_lo, handle); + ret = ffa_mem_reclaim(handle_lo, handle_hi, flags); + if ( ret ) + { + shm = NULL; + goto out; + } + + list_del(&shm->list); + +out: + free_ffa_shm_mem(ctx, shm); + spin_unlock(&ctx->lock); + + return ret; +} + static bool ffa_handle_call(struct cpu_user_regs *regs) { uint32_t fid = get_user_reg(regs, 0); @@ -1305,6 +1348,15 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) #endif handle_mem_share(regs); return true; + case FFA_MEM_RECLAIM: + e = handle_mem_reclaim(regpair_to_uint64(get_user_reg(regs, 2), + get_user_reg(regs, 1)), + get_user_reg(regs, 3)); + if ( e ) + set_regs_error(regs, e); + else + set_regs_success(regs, 0, 0); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -1508,6 +1560,7 @@ static bool ffa_probe(void) #endif !check_mandatory_feature(FFA_RXTX_UNMAP) || !check_mandatory_feature(FFA_MEM_SHARE_32) || + !check_mandatory_feature(FFA_MEM_RECLAIM) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:39:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:39:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499640.770916 (Exim 4.92) (envelope-from ) id 1pUrD2-00045V-N0; Wed, 22 Feb 2023 15:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499640.770916; Wed, 22 Feb 2023 15:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrD2-00045O-JY; Wed, 22 Feb 2023 15:39:08 +0000 Received: by outflank-mailman (input) for mailman id 499640; Wed, 22 Feb 2023 15:39:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUr8H-0001MH-G9 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 15:34:13 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a36b5af-b2c6-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 16:34:10 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id i9so10367712lfc.6 for ; Wed, 22 Feb 2023 07:34:11 -0800 (PST) Received: from localhost.localdomain (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id q9-20020ac25289000000b004db0d26adb4sm927746lfm.182.2023.02.22.07.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:34:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a36b5af-b2c6-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9EBnqstd93+kMQVfeEulFqyhSQhNIu3e1sgUFJ4bxhc=; b=uOGa2/AjT1YEsddJLsepEfyIkRMybDZu5DbW5UIHDySSh4Ux2xCVd2QVsS45rgb43i kEQAu66NdQ/NaZOiVA0Y8Bn/inG1lws/N5EXhh2Dm5tt6Udcmj+lX2GMbBV8JRiQnh3j a2x+n5KsZZWXmiiLM9p2+z+ru18dE6WU5c+uZUhVUfk96YSPrWdPBvELsYgUFBMBMBfj RwWJ7uCUsYP72TsaH2SoT5EefN/SJhCd1IzzFOXWVayGUUr1hz8igMVppLJQ1HUaHzCW SB4w6xNg4aJ/l8VVjCxXA5d4D6ALfgxPeLL9V9r0wuK8007KHRibwZdGzcoMxQkzLWJ2 38zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9EBnqstd93+kMQVfeEulFqyhSQhNIu3e1sgUFJ4bxhc=; b=gdQb3vZR+v8Kkz9l882fjDhabGHVOGukRRpUS8By95OB8S/hg/kkIfoOqsfn5eBHx+ l698Ownkx25+ZjZ1FN4CNi6KQZ1gJQ/vtIFLlefSdXF9h25mRslvx/FlXCJN/+kUxG5i nB2dg0QyVeYMcuSVl7Ngmlh5MbnvMgXMML5uxrFCWoVci4dW30exsVNHnxXYfeyaJSXC OmMu8bn8D3MCNc4tU8F0DG0aHQbb0Q0lxHzXDZ6bUmrs21+hgyznosG1xATnLYabxWUY fxZ8bkjtwEgsdbPww1GroieIRZROYfsRxMIoxJDTCFyn0wqSntQQVCQyfqXOpL7gIpl6 lwiA== X-Gm-Message-State: AO0yUKVspX0PMuuFkDlCHkpo+5puoR5gOdWXV8p08O7kLhnpgye3lHCg VPJcwlnGZ8foG3ji2E0fPdKpNlzCq6DthyiLO3E= X-Google-Smtp-Source: AK7set/siyuKsdBS5hCv12Um9J1mP06l9QLSNfMmqFSvZxRjhoRsprVfaZLYg2Ob61HD0WF3EQs0kA== X-Received: by 2002:ac2:4a88:0:b0:4d8:65c5:8684 with SMTP id l8-20020ac24a88000000b004d865c58684mr3719214lfp.58.1677080050928; Wed, 22 Feb 2023 07:34:10 -0800 (PST) From: Jens Wiklander To: xen-devel@lists.xenproject.org Cc: Bertrand.Marquis@arm.com, Marc Bonnici , Achin Gupta , Jens Wiklander , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis Subject: [XEN PATCH v7 20/20] xen/arm: ffa: support sharing large memory ranges Date: Wed, 22 Feb 2023 16:33:17 +0100 Message-Id: <5a48b7c7a56b83138932850eb7f94f90604168e4.1677079672.git.jens.wiklander@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds support for sharing large memory ranges transmitted in fragments using FFA_MEM_FRAG_TX. The implementation is the bare minimum to be able to communicate with OP-TEE running as an SPMC at S-EL1. Adds a check that the SP supports the needed FF-A feature FFA_MEM_FRAG_TX. Signed-off-by: Jens Wiklander --- xen/arch/arm/tee/ffa.c | 254 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 240 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c index 3557edc455d0..72c0249d8cad 100644 --- a/xen/arch/arm/tee/ffa.c +++ b/xen/arch/arm/tee/ffa.c @@ -326,6 +326,7 @@ struct ffa_ctx { uint32_t guest_vers; bool tx_is_mine; bool interrupted; + struct list_head frag_list; struct list_head shm_list; unsigned int shm_count; spinlock_t lock; @@ -340,6 +341,18 @@ struct ffa_shm_mem { struct page_info *pages[]; }; +struct mem_frag_state { + struct list_head list; + struct ffa_shm_mem *shm; + uint32_t range_count; + unsigned int current_page_idx; + unsigned int frag_offset; + unsigned int range_offset; + const uint8_t *buf; + unsigned int buf_size; + struct ffa_address_range range; +}; + /* Negotiated FF-A version to use with the SPMC */ static uint32_t ffa_version __ro_after_init; @@ -512,6 +525,36 @@ static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, } } +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, + uint16_t sender_id) +{ + struct arm_smccc_1_2_regs arg = { + .a0 = FFA_MEM_FRAG_TX, + .a1 = handle & UINT32_MAX, + .a2 = handle >> 32, + .a3 = frag_len, + .a4 = (uint32_t)sender_id << 16, + }; + struct arm_smccc_1_2_regs resp; + + arm_smccc_1_2_smc(&arg, &resp); + + switch ( resp.a0 ) + { + case FFA_ERROR: + if ( resp.a2 ) + return resp.a2; + else + return FFA_RET_NOT_SUPPORTED; + case FFA_SUCCESS_32: + return FFA_RET_OK; + case FFA_MEM_FRAG_RX: + return resp.a3; + default: + return FFA_RET_NOT_SUPPORTED; + } +} + static int32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, uint32_t flags) { @@ -586,6 +629,14 @@ static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); } +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, + uint32_t handle_hi, uint32_t frag_offset, + uint16_t sender_id) +{ + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, + (uint32_t)sender_id << 16, 0, 0, 0); +} + static void handle_version(struct cpu_user_regs *regs) { struct domain *d = current->domain; @@ -955,6 +1006,8 @@ static int share_shm(struct ffa_shm_mem *shm) paddr_t last_pa; unsigned int n; paddr_t pa; + bool first; + int ret; ASSERT(spin_is_locked(&ffa_tx_buffer_lock)); if ( !shm->page_count ) @@ -994,13 +1047,23 @@ static int share_shm(struct ffa_shm_mem *shm) tot_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, region_descr->address_range_count); - if ( tot_len > max_frag_len ) - return FFA_RET_NOT_SUPPORTED; + /* + * Sharing memory with secure world may have to be done with multiple + * calls depending on how many address ranges will be needed. If we're + * sharing physically contiguous memory we will only need one range but + * we will also need to deal with the worst case where all physical + * pages are non-contiguous. For the first batch of address ranges we + * call ffa_mem_share() and for all that follows ffa_mem_frag_tx(). + * + * We use frag_len to keep track of how far into the transmit buffer we + * have gone. + */ addr_range = region_descr->address_range_array; frag_len = ADDR_RANGE_OFFSET(descr->mem_access_count, region_count, 1); last_pa = page_to_maddr(shm->pages[0]); init_range(addr_range, last_pa); + first = true; for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) { pa = page_to_maddr(shm->pages[n]); @@ -1010,12 +1073,34 @@ static int share_shm(struct ffa_shm_mem *shm) continue; } - frag_len += sizeof(*addr_range); - addr_range++; + if ( frag_len == max_frag_len ) + { + if ( first ) + { + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + first = false; + } + else + { + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); + } + if ( ret <= 0 ) + return ret; + frag_len = sizeof(*addr_range); + addr_range = buf; + } + else + { + frag_len += sizeof(*addr_range); + addr_range++; + } init_range(addr_range, pa); } - return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + if ( first ) + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); + else + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); } static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, @@ -1092,8 +1177,53 @@ static int read_mem_transaction(uint32_t ffa_vers, const void *buf, size_t blen, return 0; } +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, + unsigned int frag_len) +{ + struct domain *d = current->domain; + unsigned int o = offs; + unsigned int l; + int ret; + + if ( frag_len < o ) + return FFA_RET_INVALID_PARAMETERS; + + /* Fill up the first struct ffa_address_range */ + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); + s->range_offset += l; + o += l; + if ( s->range_offset != sizeof(s->range) ) + goto out; + s->range_offset = 0; + + while ( true ) + { + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, + &s->current_page_idx); + if ( ret ) + return ret; + if ( s->range_count == 1 ) + return 0; + s->range_count--; + if ( frag_len - o < sizeof(s->range) ) + break; + memcpy(&s->range, s->buf + o, sizeof(s->range)); + o += sizeof(s->range); + } + + /* Collect any remaining bytes for the next struct ffa_address_range */ + s->range_offset = frag_len - o; + memcpy(&s->range, s->buf + o, frag_len - o); +out: + s->frag_offset += frag_len; + + return s->frag_offset; +} + static void handle_mem_share(struct cpu_user_regs *regs) { + static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; uint32_t tot_len = get_user_reg(regs, 1); uint32_t frag_len = get_user_reg(regs, 2); uint64_t addr = get_user_reg(regs, 3); @@ -1128,13 +1258,6 @@ static void handle_mem_share(struct cpu_user_regs *regs) goto out_set_ret; } - /* We currently only support a single fragment */ - if ( frag_len != tot_len ) - { - ret = FFA_RET_NOT_SUPPORTED; - goto out_set_ret; - } - spin_lock(&ctx->lock); if ( frag_len > ctx->page_count * FFA_PAGE_SIZE ) @@ -1195,11 +1318,41 @@ static void handle_mem_share(struct cpu_user_regs *regs) if ( !shm ) { ret = FFA_RET_NO_MEMORY; - goto out_unlock; + goto out; } shm->sender_id = trans.sender_id; shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); + if ( frag_len != tot_len ) + { + struct mem_frag_state *s = xzalloc(struct mem_frag_state); + + if ( !s ) + { + ret = FFA_RET_NO_MEMORY; + goto out; + } + s->shm = shm; + s->range_count = range_count; + s->buf = ctx->tx; + s->buf_size = ffa_page_count * FFA_PAGE_SIZE; + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, + frag_len); + if ( ret <= 0 ) + { + xfree(s); + if ( ret < 0 ) + goto out; + } + else + { + shm->handle = next_handle++; + uint64_to_regpair(&handle_hi, &handle_lo, shm->handle); + list_add_tail(&s->list, &ctx->frag_list); + } + goto out_unlock; + } + /* * Check that the Composite memory region descriptor fits. */ @@ -1238,7 +1391,75 @@ out_unlock: spin_unlock(&ctx->lock); out_set_ret: - if ( ret == 0) + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); + else if ( ret == 0) + set_regs_success(regs, handle_lo, handle_hi); + else + set_regs_error(regs, ret); +} + +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, + uint64_t handle) +{ + struct mem_frag_state *s; + + list_for_each_entry(s, &ctx->frag_list, list) + if ( s->shm->handle == handle ) + return s; + + return NULL; +} + +static void handle_mem_frag_tx(struct cpu_user_regs *regs) +{ + struct domain *d = current->domain; + struct ffa_ctx *ctx = d->arch.tee; + uint32_t frag_len = get_user_reg(regs, 3); + uint32_t handle_lo = get_user_reg(regs, 1); + uint32_t handle_hi = get_user_reg(regs, 2); + uint64_t handle = regpair_to_uint64(handle_hi, handle_lo); + struct mem_frag_state *s; + uint16_t sender_id = 0; + int ret; + + spin_lock(&ctx->lock); + s = find_frag_state(ctx, handle); + if ( !s ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + sender_id = s->shm->sender_id; + + if ( frag_len > s->buf_size ) + { + ret = FFA_RET_INVALID_PARAMETERS; + goto out; + } + + ret = add_mem_share_frag(s, 0, frag_len); + if ( ret == 0 ) + { + /* Note that share_shm() uses our tx buffer */ + spin_lock(&ffa_tx_buffer_lock); + ret = share_shm(s->shm); + spin_unlock(&ffa_tx_buffer_lock); + if ( ret == 0 ) + list_add_tail(&s->shm->list, &ctx->shm_list); + else + free_ffa_shm_mem(ctx, s->shm); + } + else if ( ret < 0 ) + free_ffa_shm_mem(ctx, s->shm); + list_del(&s->list); + xfree(s); +out: + spin_unlock(&ctx->lock); + + if ( ret > 0 ) + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id); + else if ( ret == 0) set_regs_success(regs, handle_lo, handle_hi); else set_regs_error(regs, ret); @@ -1357,6 +1578,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) else set_regs_success(regs, 0, 0); return true; + case FFA_MEM_FRAG_TX: + handle_mem_frag_tx(regs); + return true; default: gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); @@ -1396,6 +1620,7 @@ static int ffa_domain_init(struct domain *d) } } + INIT_LIST_HEAD(&ctx->frag_list); INIT_LIST_HEAD(&ctx->shm_list); d->arch.tee = ctx; @@ -1560,6 +1785,7 @@ static bool ffa_probe(void) #endif !check_mandatory_feature(FFA_RXTX_UNMAP) || !check_mandatory_feature(FFA_MEM_SHARE_32) || + !check_mandatory_feature(FFA_MEM_FRAG_TX) || !check_mandatory_feature(FFA_MEM_RECLAIM) || !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) return false; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 15:50:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 15:50:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499675.770939 (Exim 4.92) (envelope-from ) id 1pUrNu-0007Kf-1D; Wed, 22 Feb 2023 15:50:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499675.770939; Wed, 22 Feb 2023 15:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrNt-0007KY-Ud; Wed, 22 Feb 2023 15:50:21 +0000 Received: by outflank-mailman (input) for mailman id 499675; Wed, 22 Feb 2023 15:50:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrNt-0007KO-2L; Wed, 22 Feb 2023 15:50:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrNs-0006b8-VF; Wed, 22 Feb 2023 15:50:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrNs-0007J7-M2; Wed, 22 Feb 2023 15:50:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUrNs-0004mP-Lb; Wed, 22 Feb 2023 15:50:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/8QQBWbMJRYz0ObRqhGWIDhEjW4SijDscCsK6JMtKaQ=; b=2szZ8AtB/POIGBiuNw6C7qThaW WBe3lwA0n7MyBFhZUuzOi33v9EUN47JfMHqaoKcMErYpCFUQ4OZ5ZBPsoUxPYwvOl/xZrqzpA3IMZ JyiHd2bAvfPL/1mqQ6ShiMNKhxee2PjaJsNhsXwOEHY3F6mwLaMVfmz/P+b4XKYmDFtY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178114: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Wed, 22 Feb 2023 15:50:20 +0000 flight 178114 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178114/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 build-armhf-pvops 6 kernel-build fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 build-arm64-pvops 6 kernel-build fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 0 days Testing same since 178093 2023-02-22 05:02:47 Z 0 days 2 attempts ------------------------------------------------------------ 685 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 69393 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Feb 22 16:05:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 16:05:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499693.770950 (Exim 4.92) (envelope-from ) id 1pUrc1-0001L6-Az; Wed, 22 Feb 2023 16:04:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499693.770950; Wed, 22 Feb 2023 16:04:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrc1-0001Kz-8E; Wed, 22 Feb 2023 16:04:57 +0000 Received: by outflank-mailman (input) for mailman id 499693; Wed, 22 Feb 2023 16:04:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrbz-0001Kt-J4 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 16:04:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a299f9c5-b2ca-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 17:04:52 +0100 (CET) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2023 11:04:40 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5795.namprd03.prod.outlook.com (2603:10b6:303:9b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20; Wed, 22 Feb 2023 16:04:39 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Wed, 22 Feb 2023 16:04:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a299f9c5-b2ca-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677081891; h=message-id:date:to:cc:from:subject: content-transfer-encoding:mime-version; bh=38zvKDkk5vqJDj8XXymqC8QaIrvQS3pO3Dlxi9Z+Zrk=; b=DINdOil6PUf1jjomjIQrpIApUjCdyHvayaqSJ+kklIK9Gvsfefz8OEH3 uZLnSxe66L1LZ7TaH7cF1r0YCe6kQjkNqZCQ6NRXd50uxJ6qKjIwx11fb U5YlteztMqOLyXySCVdR3qugTgSngyuesJRvlXybq4D/FcI2seYrio2Pa 4=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 97472559 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kWe6bKoBKP+WPSdKQEgk2TYD1+5eBmLLZBIvgKrLsJaIsI4StFCzt garIBmOaKmIMDTzetl2YY7l8UlVv5Xcn9djQQNvqS43RXgX9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSNNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACouNTaCxMm3+qi6VLlhpMIRHfHHMapK7xmMzRmBZRonabbqZvyQoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3juarbIC9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOznqqEw3QDCroAVIBsOc3fhs8KntmivfNtFF 0IP1hoiqrdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQo3 FKUm9LiBRR0raaYD3ma89+8sjeaKSUTa2gYakcsVhAZ6tPupIUyiBPnTdt5FqOxyNrvFlnYy S2QviE6gLkUkscj2KCy/FSBiDWpzqUlVSYw7wTTG2e6tAVwYdf/Y5TysQSBq/FdMIyeU1+N+ mAenNST5/wPCpfLkzGRROIKH/ei4PPt3CDgvGOD1qIJr1yFk0NPt6gJuFmS+G8B3h44RALU IronPort-HdrOrdr: A9a23:biaMCqoBeUFsULUMACnOPFkaV5oUeYIsimQD101hICG9vPbo7v xG/c5rrSMc7Qx6ZJhOo6HkBEDtewK/yXcx2/hzAV7AZmjbUQmTXeVfBOLZqlWKJ8S9zI5gPM xbAs9D4bPLfD5HZAXBjDVQ0exM/DBKys+VbC7loUtQcQ== X-IronPort-AV: E=Sophos;i="5.97,319,1669093200"; d="scan'208";a="97472559" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQSqmt91haoul2dZO9LYWNK1Dwk5HD2TRgQlNg5tX6nvQgzsxDG7KtKOkRTX12iS/M1yCO8gi6nd4eYvBVyWzccd9JRl9bDplRU0zmLVTJ5XshYiQjcijZ4AmDMIkMOHFkOIIj7zc5wHVlXniSOUERMsZJ5ThT/WFaMCujlemAnPrNf0nbftMSu/9n+e9rYCeh8Nb2S/7YEOmnuWpYHj/k/jHvRg1sgJYVTK+bZLebxmR8lVNueRuzDAQBILnw9iML8OSpfFZS+Ja9yqEjz+TmobyFA5XZKM/MemvE1vT4UrLE87q0IMlGxQ/fkvHySF9V8Gk2yQxlakdC+ch+FnIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=38zvKDkk5vqJDj8XXymqC8QaIrvQS3pO3Dlxi9Z+Zrk=; b=aMBxK/A+YMX9rTa0TJeYf8XFEWgrKWEPwSIPw3SZJ7gC9qeMwRtqRIepYcQPPwNrbTHo8pAagY188i0/a9/GENWCctvshPZxcQUAD/6FYo5R5yr6XgC/pzHRutHzec+sTyTIuiKHuYmuC4Xjc+uday8k0LnF+SW7g4DGdnIjIzQVrciXnPtXPeGfQJ0JOekgNySC+psidbM/DnwhpvvfmPtCd4rMuV0K78MoZteZumlPEB401odPcj3r2FAHr1ju1MzhO++9V/KgX6++JQ3+3OQtNgBEvJp3OdCUbGxZHUfCg5lu0RhNakwJW2NQraJbjSDZRZnPSK199zYI7Yidvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38zvKDkk5vqJDj8XXymqC8QaIrvQS3pO3Dlxi9Z+Zrk=; b=vQKZbduX9fwdpjC2DYIAvkS5taq8/1EUQ+n5rrqeRt5dC9seJ2y7iAol5KOIt6IDFmAVU8JBCty+6AgAQkmhHF3gC1550YuYt75KzIOnWu0h4aJSPCRvzQJdSoVYK/l6pEoqlMStB7ttVKwSYorditsUFdCtr5qKOwM8vZWxdog= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <75b06911-9ff0-e75f-b611-810277524171@citrix.com> Date: Wed, 22 Feb 2023 16:04:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-GB To: xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Xenia Ragiadakou From: Andrew Cooper Subject: Core parking broken with NR_CPUS=1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0401.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO1PR03MB5795:EE_ X-MS-Office365-Filtering-Correlation-Id: a8715fc5-9852-4a58-90d9-08db14ee7ff2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cdkC6pmu35NZzR4tKQA8J3Gqn3dUrbR8+WEO7Q5iONKLFQ9OGKbsClqmdK+PTVHjOU5rVyEUxnJt9oALLSm9ic+cmLfj7M1lyQgzBTxUitCowiFW05a194hmnvMSSg3JKWav9EfTzP5RD7KuPqA38IBuSYNY8JZnNZm8VGETTfTfj939Cdv8LdKgZFn2W374F3996TZQnm+uKwg1wYgn00mPt36HXisgXLF/l7Kz7u+B7rRj0SotLUXDFs/khMbzPcmoZZcPd/PmctgQ/1UBC/iqwkZNxUuCbv6L7Ytxz+tUqGwFSHPXzUETfVoG0SikgM2xdlbmYa1sQgsdQRQYTgRekDGZxVOyqav19grFIS5Jz90/kPOuRtPrK0YjAyozEq2Ce3yAnWEjJr4T54BOOETUiLo+ZpPxw9GAFqLycdPl5oTi2K+7toqvII0xqilb3lRiFkMgiO66h1cgZYRuEOsHULbgIH+mmGK3M7SXVLx7EsZZzqIpjcLsjuJpYw05XXS8zRrPw3Cq3NR2/5PS0OofWDLAbgrK2a/WWPseZOWEPw/CXeml5LWY8xdmF58/tXHmBr6sgad2kmN8t4TrmABRppOEEf1JHhIt+iv2GLa5Ny8Bqw4JAePSgSYsLGpLuJRypkwYPfw5+LIT9RuEmntVqn2C9Ud9ihZRe+qfjoXNLPV3TDOmq7Ro/bBNBkhMqjsXwUczrDlkNHY4++2pTiqVWql38hiixF4sZJbn6m4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(136003)(366004)(396003)(346002)(451199018)(6512007)(2906002)(38100700002)(82960400001)(8936002)(6916009)(4326008)(41300700001)(66946007)(8676002)(66556008)(66476007)(5660300002)(36756003)(6506007)(186003)(478600001)(26005)(6666004)(2616005)(86362001)(316002)(31696002)(54906003)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnlpY05EQ1BQcVhObzBrM0VFLzRZR1ovb3k3RlVBQW9DS0w4TDhqVnRSMXdv?= =?utf-8?B?UWNNN3I2NlVmMnpldkh6dzJoV1o3WUpjdlZoK0djT21VWitibWRaaGl2MGRw?= =?utf-8?B?cVRqNU1oT2ZVd2JnUEhPNkF5b2FjSWp2bzFvck16QXRJN283dzZlTlhMeUQ2?= =?utf-8?B?OG5VejZiVEppZmRMdUFDVmlYV0NWRDdrc2JORjlsQlFHRmtkUFBsYitVQ1d2?= =?utf-8?B?U2NlZW1xbTNnYU1LOThuNHFoY2x6bkU5WWVNZG1oNlY4eVBuc1RhYU9Dcm1O?= =?utf-8?B?U0RoeHdSSTVPVnU0L3Fzc21NazUyT3p0RzZNbmI4cFk5WHVScE15N2xySlBh?= =?utf-8?B?SHYxMTFnVTdCZHdIZlc0MmZsTFd1a1V5YmJsTkxJckhQVDdhdlQ2bUVpREhI?= =?utf-8?B?b0tHd0N1MUdDYkF6bmVPQStCVXlsVnlzOVBzR2hHcytyN1FkYkhmMWp0OU50?= =?utf-8?B?Ry9tUzhaTmU2UlVrdWJkaHJLTFMwMXBUZndZTk5lZVhkY1F6SE1oL3dUcWZ2?= =?utf-8?B?ei93YytOQmttMjZ1N0ZQRnBSditnaEhxSmJoMEt4MDA3aFBlRXpxdm1zaHVK?= =?utf-8?B?SnRmc0t5bjdiSVY1WElseW5pQ2NQQjE0UU5nenVoWktJbmtwOFIxNlptcWQ3?= =?utf-8?B?WjhTTG9WSHJ2Nk5oK2dCZ3U1RlVJK3ZQS3FZNFF6T25OWnZHNERsazJFTnhy?= =?utf-8?B?OGdKaGp1aloyd2JSWDNNWHIvYjhjYlg1QW5qQVZWVDVUeWFobldvSzNnczB0?= =?utf-8?B?N3NNRlhUK1NDV2NLUkE5a1NQQUNELzJrL3JhTkZDcHlKVUMxTStCZU5JUGNN?= =?utf-8?B?SnUxSFhXT05aT0RRZlhwYUk1eFN6U2VKQjc1TzNHbUlIVC9teXlxQzUxUGZ6?= =?utf-8?B?K3BDQkFVK2ZGRVROaHZwczQ3SnZqaTl3NU9oNTExemlxamlLKy8xUm84OEg3?= =?utf-8?B?QVU2S3N4QXJIemgxWnk5djFGZ1l6YVdSV1lhQUFqNWJwNTF5NG4rZldrOHp0?= =?utf-8?B?ZHQ2YUwzSEQ0amRRcC95eXlEWnh5NVFFeG1FZUF2YjQvbWVYVFFlVWFNZlFI?= =?utf-8?B?Y2RHOG9sanNhQnk4ZGU0NHVabzhKM2cwcEo1eGNWa0lRSk44N04vZzdHZDNL?= =?utf-8?B?UGZ6LzcyRFRkcGlKaFRHdis4M0FnNUJBS3RzRkc1VGpwOXFVby81RzBwUDZh?= =?utf-8?B?VndTL2ozNFozMjliQ0F2WXBURVJ4emRZQldnL3hCUmtiblhJalFLR0RHWlZV?= =?utf-8?B?WnVyTlJnK3VOT3dJYTZZdGUxWExSb29YZXZnbUdQSXNvdnhuQXUxcXlNaHdl?= =?utf-8?B?MThQWkZTUUozYWJUdEowZDU0R01mZlBhVHlnUDJVNFBwVm1WRTVmRWN1M2ZT?= =?utf-8?B?N211K2lSTU4vTmZ6djVlenpEK3V6WFNrSmVDbmdSbmp4dlhzbXEyRk1mUmNl?= =?utf-8?B?OElnOWFXdlcwQ2R1Njd0eUpmZjBaVmRidDNQbXF5UExhM1RQQ2JBanpMZ3RZ?= =?utf-8?B?Y21CNVZNVmlmQ3c4SjFpdlpVbnd6U1BkZ3BRY0dzTU9UQWJoQndzdTY1YmVr?= =?utf-8?B?K0xZZnZkSGVwc2lEdk44dkljdFhaSWNtRklFaUNtZzlTMkxJbUdMS1FrMGgr?= =?utf-8?B?djhVc3d3ZEw4UmtLNXQxOGV6ZC9tb3JON3Y5NXpHUENKK1lmWjRIaXRXSVA3?= =?utf-8?B?NVZwWnRnZ2ltcHEzZGs0Z293alk5Mnd3dVFNRW9XMEZzelZrV3FOYTlqSEpX?= =?utf-8?B?M0wrQ3RoTXk4YWd6SkZsaThmcnM2dTQ1akh2UVhPSjF3SWJsdFNiYkI5dE1K?= =?utf-8?B?cFpkcit2RlR6TXdWeks1VjhMc2c1eTByckd3Szd0M01Gb2s1RmNhTlhXSnUz?= =?utf-8?B?ZFlZQXhLcFJsRk8zWm4vamZlOUFqcDFOdlB0UHRsTU84SDFFN0pQZlYybW9Y?= =?utf-8?B?bnI1VkNwTFZkeEdITGJKWnFpc2h2cmg1L3A3SEFGSVdDTm5lK2JHQWxKeGpv?= =?utf-8?B?a3hyZ1VWdDRLcEk0bFJqdUFBamVET2xBa3RDOUJDYWVCZjFHRWgyU0w1SXdn?= =?utf-8?B?M3JmbmNPZjJuTHF5b1pHTHNnRU5jSGhJL1I0UEdxTmo5bXVUVlg4KzNPcW5s?= =?utf-8?B?d1Z4YzRXYnlGNXJZbXpDWWRhUzNXSkZJd3dzU29Zc08yNklSQWY2NXR2RXBr?= =?utf-8?B?Snc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g5+eclxvM6txDaH+Z7QT74Vi9w3610dRPdqJa5Yhc6O31h3GZ2+PRYFFmVF6jtYpGrwq8faHNfDFNlpf6JqOzudr28mSHxIgSYn4Lixz09VmV99iEi1/PGq+9pEBcaBYsAAOKLCalHx+8+IdrHNzYFphQ2cH7RKh9MAdr607S0RZIeUcmtxrIY8owlzI7zueRhAAYt0xovnaWoALuwbbibLgF11dp00hnL5uCOmpytmph/q764+jXX7GSzlQ83mPf6Ip6EfKVl1vfF229zDTZwDOHd/g/QNnGR23GZpkbzSonPrT5QgO9QmM40JxDUFvd5l2dGncwm/dCYZ8pW2FxGfhEdzwUsNNF3TsBoIW+kSfiUPCHx2MrdmBODtYBzQzKTFdc00DoMkAC+yBpU6QjBNXzZ2ZxRViyITfvEAPptZs7YoGVpn7TafQKzqF19G1VTZkAvitxxBkIl/yKa8ttfLRuQni0hZWmzww24ODeEk/G69MA+2yHSpm1hCbhNZ+QWpTMPsgWiIQxMDP8kM1cAAq/82xOpNWqr4bzErOijMM6tbMFW7vQHsCEcHk3+hui5lFrAAsRPG98qyqVU2JoPhBfpCObSTk542WetIdKJxGN2xERX70YJTzxDNxMJjP1azCAab8fhaYwCvZ6gcbg3EafUGvBLBoyQ4i1iVlEHou/o4pHzwLjKrxxreXrtwVZ9ndZoanbjYSUBvgEcyeJJMIQBdg/uPO6ZYzwSrt6UrK7NuGLIYefWHB2mMv1+h2FyYQMCe0qGI75CDv3ik55jeB7oRhuvyU1nl8CSCW9efxhdYRERlbBiE5+JVsKyJY5btlHJiq/LyBO8zNUo3U3sXrKodLaTtfBoFwrmMt3XsKsziPNC11+A05+HGJ/VPF X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8715fc5-9852-4a58-90d9-08db14ee7ff2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:04:38.7713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9s6zp3QNAUg3uIhkewpthPs8hNhIcYdH99l+K4xryhPZN0gPlRpfaJnf2S7iU0jiet6FhywYzj3wUtwJyBt6bNv341OaiJsk8uzTaQj2yKg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5795 While testing the rebuilt debian unstable container, I found: common/core_parking.c: In function 'core_parking_remove': common/core_parking.c:230:53: error: array subscript 1 is above array bounds of 'unsigned int[1]' [-Werror=array-bounds]   230 |         core_parking_cpunum[i] = core_parking_cpunum[i + 1];       |                                  ~~~~~~~~~~~~~~~~~~~^~~~~~~ common/core_parking.c:31:21: note: while referencing 'core_parking_cpunum'    31 | static unsigned int core_parking_cpunum[NR_CPUS] = {[0 ... NR_CPUS-1] = -1};       |                     ^~~~~~~~~~~~~~~~~~~ which is an legitimate complaint - this logic is simply broken with NR_CPUS=1. In principle, I think the best fix is probably to have CORE_PARKING depend on NR_CPUS > 1, except none of the interacting x86 code has been written in a way that would be compatible. But it also occurs to me that this is the kind of thing an embedded x86 usecase would want to compile.  Frankly, its niche even on regular x86 use-cases. Except having looked at the code, it's a different to the other thing we call core parking which is the smt=0 logic to keep the stacks valid for cores/threads we don't want to use, because of #MC broadcast problems - and this logic does need to stay. Thoughts? ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 22 16:16:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 16:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499700.770961 (Exim 4.92) (envelope-from ) id 1pUrnO-00037e-Ct; Wed, 22 Feb 2023 16:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499700.770961; Wed, 22 Feb 2023 16:16:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrnO-00037X-9Q; Wed, 22 Feb 2023 16:16:42 +0000 Received: by outflank-mailman (input) for mailman id 499700; Wed, 22 Feb 2023 16:16:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrnM-00037M-9L for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 16:16:40 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46903f8e-b2cc-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 17:16:34 +0100 (CET) Received: by mail-lf1-x132.google.com with SMTP id m6so10791062lfq.5 for ; Wed, 22 Feb 2023 08:16:35 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id q17-20020ac25291000000b004dd7fefd2c8sm1426664lfm.242.2023.02.22.08.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 08:16:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46903f8e-b2cc-11ed-93b6-47a8fe42b414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pl/l88vFg0XydW7+PCts+hWlPZfFq8wxrzjug3bp2Iw=; b=erUJ/eAzeCDRbIyPYWQyMZunR9gAHlgFWwFqLOUCz4licunKLwlkwJrZ/ZXnaYjotD L5S8OPWnsnMTLLkpKUdpTIYJB+2z5aJeLrDhRLT0H/5m7khWjuhhElT+WjiXouCyaY+0 PNespyiySNHQQ1IZGNWJCaJcDh/CFInyXqXJfXxDkzhNYN1h/hdENl06rwcGnpcb8eci 8ZyqtV5fB2NNQFKgqwug/vWeNew0Z5i2li+xYe/8fMYA4r0LzL2rK9sJLvNUU6UTO3m/ RGrBypwY7LYw64iLzs7xbHdUFSuUEqjRiNu5uxeyUrwZ8EFmWHpvYLRzLO4wJvjquXmQ opgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pl/l88vFg0XydW7+PCts+hWlPZfFq8wxrzjug3bp2Iw=; b=E7bBBBKDi9aFw7M43pYWjQZ4dW9fgHfZIrQyc2Wwr7f2zM73HdUaphkvlJYgM/s9hX tPGqU0kd8uzTLKAI0JM4bTbIMIt/RHXt7bnz56QBK2YOlRR0ZZrsGeC6HS084Sl5xK6P H5D+elyV7q8+0BieyrVcB92U2h+l2gSVdnM2gG65q3PsVN7l4Azu0i1yPJ7Kc+4qQwzc Cf2FVBNj6uNXO4YZKlz2FCp43L6AO+6X3wurxdvQq+7o6wrVZ/PCVdRGO2ArDHw6FSZk l8TlTtaaG8vvU3Y8r41bsifbKFiSKifKgtanfwgsIsVkPUJTje63pdNACisZE3sO9WZt BCCg== X-Gm-Message-State: AO0yUKUl7IkNsshS1N8u5TR0QxTu0HT77nV7/NAwukPhY94rp5F6lulo 4vbahHXVTKNXSGjnnGf7SoI= X-Google-Smtp-Source: AK7set9GQmN9eebcWeXzWIt9gEhmQqzkuzHjoFLyKZPS7LecpEXgyfRkWLPuY+QjEY1tlvkC2woBkw== X-Received: by 2002:ac2:4bd3:0:b0:4b6:fddc:1fcd with SMTP id o19-20020ac24bd3000000b004b6fddc1fcdmr3119898lfq.23.1677082594990; Wed, 22 Feb 2023 08:16:34 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich , Andrew Cooper Cc: Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Date: Wed, 22 Feb 2023 18:16:32 +0200 In-Reply-To: <214973b0-5fe7-9208-2cfc-dd2884583157@suse.com> References: <214973b0-5fe7-9208-2cfc-dd2884583157@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGVsbG8gSmFuLAoKT24gV2VkLCAyMDIzLTAyLTIyIGF0IDEzOjQ2ICswMTAwLCBKYW4gQmV1bGlj aCB3cm90ZToKPiBPbiAyMC4wMi4yMDIzIDE3OjQwLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ ID4gQSBsYXJnZSBwYXJ0IG9mIHRoZSBjb250ZW50IG9mIHRoZSBidWcuaCBpcyByZXBlYXRlZCBh bW9uZyBhbGwKPiA+IGFyY2hpdGVjdHVyZXMsIHNvIGl0IHdhcyBkZWNpZGVkIHRvIGNyZWF0ZSBh IG5ldyBjb25maWcKPiA+IENPTkZJR19HRU5FUklDX0JVR19GUkFNRS4KPiA+IAo+ID4gVGhlIHZl cnNpb24gb2YgPGJ1Zy5oPiBmcm9tIHg4NiB3YXMgdGFrZW4gYXMgdGhlIGJhc2UgdmVyc2lvbi4K PiA+IAo+ID4gVGhlIHBhdGNoIGludHJvZHVjZXMgdGhlIGZvbGxvd2luZyBzdHVmZjoKPiA+IMKg ICogY29tbW9uIGJ1Zy5oIGhlYWRlcgo+ID4gwqAgKiBnZW5lcmljIGltcGxlbWVudGF0aW9uIG9m IGRvX2J1Z19mcmFtZSgpCj4gPiDCoCAqIG5ldyBjb25maWcgQ09ORklHX0dFTkVSSUNfQlVHX0ZS QU1FCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE9sZWtzaWkgS3Vyb2Noa28gPG9sZWtzaWkua3Vy b2Noa29AZ21haWwuY29tPgo+ID4gCj4gPiAtLS0KPiA+IENoYW5nZXMgaW4gVjI6Cj4gPiDCoCAt IFN3aXRjaCB0byB4ODYgaW1wbGVtZW50YXRpb24gYXMgZ2VuZXJpYyBhcyBpdCBpcyBtb3JlIGNv bXBhY3QKPiA+IMKgwqDCoCAoIGF0IGxlYXN0IGZyb20gdGhlIHBvaW50IG9mIHZpZXcgb2YgYnVn IGZyYW1lIHN0cnVjdHVyZSApLgo+ID4gwqAgLSBSZW5hbWUgQ09ORklHX0dFTkVSSUNfRE9fQlVH X0ZSQU1FIHRvIENPTkZJR19HRU5FUklDX0JVR19GUkFNRS4KPiA+IMKgIC0gQ2hhbmdlIHRoZSBt YWNybyBidWdfbG9jKGIpIHRvIGF2b2lkIHRoZSBuZWVkIGZvciBhIGNhc3Q6Cj4gPiDCoMKgwqAg I2RlZmluZSBidWdfbG9jKGIpICgodW5zaWduZWQgbG9uZykoYikgKyAoYiktPmxvY19kaXNwKQo+ ID4gwqAgLSBSZW5hbWUgQlVHX0ZSQU1FX1NUVUZGIHRvIEJVR19GUkFNRV9TVFJVQ1QKPiA+IMKg IC0gTWFrZSBtYWNyb3MgcmVsYXRlZCB0byBidWcgZnJhbWUgc3RydWN0dXJlIG1vcmUgZ2VuZXJp Yy4KPiA+IMKgIC0gSW50cm9kdWNlIEJVR19JTlNUUiBhbmQgTU9ESUZJRVIgdG8gbWFrZSBfQVNN X0JVR0ZSQU1FX1RFWFQKPiA+IHJldXNhYmxlCj4gPiDCoMKgwqAgYmV0d2VlbiB4ODYgYW5kIFJJ U0MtVi4KPiAKPiBIbW0sIGJlbG93IEkgc2VlIGl0J3MgcmVhbGx5IGp1c3QgIk1PRElGSUVSIi4g SSBzZWUgdHdvIGlzc3VlcyB3aXRoCj4gdGhpczoKPiBGb3Igb25lIHRoZSBuYW1lIGlzIHRvbyBn ZW5lcmljIGZvciBzb21ldGhpbmcgd2hpY2ggY2Fubm90IGJlICN1bmRlZi0KPiBlZAo+IGFmdGVy IHVzZSBpbnNpZGUgdGhlIGhlYWRlci4gQW5kIHRoZW4gaXQgYWxzbyBkb2Vzbid0IHJlYWxseSBz YXkgd2hhdAo+IGlzCj4gYmVpbmcgbW9kaWZpZWQuIFdoaWxlIGVuZGluZyB1cCBsb25nZXIsIGhv dyBhYm91dCBCVUdfQVNNX0NPTlNUIG9yCj4gYWxpa2U/CkJVR19BU01fQ09OU1Qgd2lsbCBiZSBt dWNoIGJldHRlci4KPiAKPiBJIGFsc28gdGhpbmsgdGhpcyBzaG91bGQgZGVmYXVsdCB0byBzb21l dGhpbmcgaWYgbm90IG92ZXJyaWRkZW4gYnkgYW4KPiBhcmNoLiBQZXJoYXBzIHNpbXBseSB0byBh biBleHBhbnNpb24gdG8gbm90aGluZyAoYXQgd2hpY2ggcG9pbnQgeW91Cj4gd29uJ3QgbmVlZCB0 byBkZWZpbmUgaXQgZm9yIFJJU0MtViwgYWl1aSkuCj4gCkFncmVlLgoKSW5pdGlhbGx5LCBJIHRo b3VnaHQgYWJvdXQgdGhhdCB0b28gYnV0IGNvdWxkbid0IGVzdGltYXRlIGhvdyB3ZWxsIHRoZQpt b2RpZmllciAnJWMnIGlzIHN1cHBvcnRlZCwgZGVjaWRpbmcgdGhhdCBlYWNoIGFyY2hpdGVjdHVy ZSBoYXMgdG8KZGVmaW5lIGl0LgoKQnV0IHdlIGNhbiBtYWtlIGl0IGVxdWFsIHRvIG5vdGhpbmcg KGF0IGxlYXN0IGZvciAyIGFyY2hpdGVjdHVyZXMgKSBpdApkb2Vzbid0IGhhdmUgdGhlIHNhbWUg c3VwcG9ydCBhcyBpbiB4ODYuCgo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIveGVuL2NvbW1v bi9idWcuYwo+ID4gQEAgLTAsMCArMSwxMTMgQEAKPiA+ICsjaW5jbHVkZSA8eGVuL2J1Zy5oPgo+ ID4gKyNpbmNsdWRlIDx4ZW4vZXJybm8uaD4KPiA+ICsjaW5jbHVkZSA8eGVuL2tlcm5lbC5oPgo+ ID4gKyNpbmNsdWRlIDx4ZW4vbGl2ZXBhdGNoLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9zdHJpbmcu aD4KPiA+ICsjaW5jbHVkZSA8eGVuL3R5cGVzLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi92aXJ0dWFs X3JlZ2lvbi5oPgo+ID4gKwo+ID4gKyNpbmNsdWRlIDxhc20vcHJvY2Vzc29yLmg+Cj4gCj4gSXMg dGhpcyByZWFsbHkgbmVlZGVkIGhlcmU/ClllcywgaXQgaXMuCgpGdW5jdGlvbiBzaG93X2V4ZWN1 dGlvbl9zdGF0ZSgpIGlzIGRlY2xhcmVkIGluIHRoaXMgaGVhZGVyIGZvciBhbGwKYXJjaGl0ZWN0 dXJlcyBhbmQgaXMgdXNlZCBieSBoYW5kbGVfYnVnX2ZyYW1lKCkuCj4gCj4gPiArY29uc3Qgc3Ry dWN0IGJ1Z19mcmFtZSogZmluZF9idWdfZnJhbWUodW5zaWduZWQgbG9uZyBwYywgdW5zaWduZWQK PiA+IGludCAqaWQpCj4gCj4gSXMgdGhpcyBmdW5jdGlvbiBnb2luZyB0byBiZSBuZWVkZWQgb3V0 c2lkZSBvZiB0aGlzIENVPyBJT1cgd2h5IGlzIGl0Cj4gbm90Cj4gc3RhdGljPwo+IApJdCdzIG5v dCBzdGF0aWMgYmVjYXVzZSB0aGVyZSBpcyBub3QgcG9zc2libGUgdG8gdXNlIGRvX2J1Z19mcmFt ZSgpIGFzCmlzIGZvciB4ODYgYXMgeDg2IGhhcyBzb21lIGFkZGl0aW9uYWwgY2hlY2tzIGZvciBz b21lIGNhc2VzIHdoaWNoCmFyZW4ndCBpbiBnZW5lcmljIGltcGxlbWVudGF0aW9uOgpbMV0KaHR0 cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3Blb3BsZS9vbGt1ci94ZW4vLS9ibG9iL3N0YWdp bmcveGVuL2FyY2gveDg2L3RyYXBzLmMjTDEyMTcKWzJdCmh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4t cHJvamVjdC9wZW9wbGUvb2xrdXIveGVuLy0vYmxvYi9zdGFnaW5nL3hlbi9hcmNoL3g4Ni90cmFw cy5jI0wxMjM4ClszXQpodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxlL29sa3Vy L3hlbi8tL2Jsb2Ivc3RhZ2luZy94ZW4vYXJjaC94ODYvdHJhcHMuYyNMMTI1OQoKUHJvYmFibHkg dG8gbWFrZSBnZW5lcmljIGRvX2J1Z19mcmFtZSgpIG1vcmUgcmUtdXNhYmxlIGZvciB4ODYgd2Ug Y2FuCmltcGxlbWVudCBhcyBzdHVicyBmaXh1cF9leGNlcHRpb25fcmV0dXJuKCkgYW5kIGRlYnVn Z2VyX3RyYXBfZmF0YWwoKQp1bmRlciAjaWZuZGVmIFg4NiAuLi4gI2VuZGlmIGluc2lkZSBjb21t b24vYnVnLmMuCgpDb3VsZCB5b3UgcGxlYXNlIHNoYXJlIHlvdXIgdGhvdWdodHMgYWJvdXQgdGhh dD8KCj4gQWxzbywgbml0OiBMZWZ0IG1vc3Qgc3RhciB3YW50cyBjaGFuZ2luZyBwbGFjZXMgd2l0 aCB0aGUgYWRqYWNlbnQKPiBibGFuay4KVGhhbmtzLiBJJ2xsIHVwZGF0ZSBpbiB0aGUgbmV4dCB2 ZXJzaW9uIG9mIHRoZSBwYXRjaCBzZXJpZXMuCgo+IAo+ID4gK3sKPiA+ICvCoMKgwqAgY29uc3Qg c3RydWN0IGJ1Z19mcmFtZSAqYnVnID0gTlVMTDsKPiA+ICvCoMKgwqAgY29uc3Qgc3RydWN0IHZp cnR1YWxfcmVnaW9uICpyZWdpb247Cj4gPiArCj4gPiArwqDCoMKgIHJlZ2lvbiA9IGZpbmRfdGV4 dF9yZWdpb24ocGMpOwo+ID4gK8KgwqDCoCBpZiAoIHJlZ2lvbiApCj4gPiArwqDCoMKgIHsKPiA+ ICvCoMKgwqDCoMKgwqDCoCBmb3IgKCAqaWQgPSAwOyAqaWQgPCBCVUdGUkFNRV9OUjsgKCppZCkr KyApCj4gPiArwqDCoMKgwqDCoMKgwqAgewo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29u c3Qgc3RydWN0IGJ1Z19mcmFtZSAqYjsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2ln bmVkIGludCBpOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZm9yICggaSA9IDAs IGIgPSByZWdpb24tPmZyYW1lWyppZF0uYnVnczsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGkgPCByZWdpb24tPmZyYW1lWyppZF0ubl9idWdzOyBiKyssIGkrKyApCj4g PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGlmICggYnVnX2xvYyhiKSA9PSBwYyApCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBi dWcgPSBiOwo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8g Zm91bmQ7Cj4gCj4gV2hpbGUgaW4gdGhlIG9yaWdpbmFsIGNvZGUgdGhlIGdvdG8gaXMga2luZCBv ZiB3YXJyYW50ZWQsIGl0IGlzbid0Cj4gcmVhbGx5Cj4gaGVyZSBpbW8uIFlvdSBjYW4gc2ltcGx5 ICJyZXR1cm4gYiIgaGVyZSBhbmQgLi4uCj4gCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIH0KPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+ICvCoMKgwqDCoMKgwqDC oCB9Cj4gPiArwqDCoMKgIH0KPiA+ICsKPiA+ICsgZm91bmQ6Cj4gPiArwqDCoMKgIHJldHVybiBi dWc7Cj4gCj4gLi4uICJyZXR1cm4gTlVMTCIgaGVyZS4gVGhhdCdsbCBhbGxvdyB0aGUgZnVuY3Rp b24gc2NvcGUgImJ1ZyIgdG8gZ28KPiBhd2F5LAo+IGF0IHdoaWNoIHBvaW50IHRoZSBpbm5lciBz Y29wZSAiYiIgY2FuIGJlY29tZSAiYnVnIi4KQWdyZWUsIG1pc3NlZCB0aGF0IHdoZW4gZGVjaWRl ZCB0byBtb3ZlIHRoYXQgcGFydCBvZiB0aGUgY29kZSB0bwpzZXBhcmF0ZSBmdW5jdGlvbi4KCj4g Cj4gPiArfQo+ID4gKwo+ID4gK2ludCBoYW5kbGVfYnVnX2ZyYW1lKGNvbnN0IHN0cnVjdCBjcHVf dXNlcl9yZWdzICpyZWdzLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGNvbnN0IHN0cnVjdCBidWdfZnJhbWUgKmJ1ZywKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgaWQpCj4gCj4gTml0OiBJbmRlbnRhdGlv biBpcyBvZmYgYnkgb25lIGhlcmUuIEFsc28gc2FtZSBxdWVzdGlvbiByZWdhcmRpbmcgdGhlCj4g bGFjawo+IG9mIHN0YXRpYyBoZXJlLgpSZWdhcmRpbmcgc3RhdGljIGFuIGFuc3dlciBpcyB0aGUg c2FtZSBhcyB3aXRoIHByZXZpb3VzIG9uZSBzdGF0aWMKcXVlc3Rpb24uCgo+IAo+ID4gK3sKPiA+ ICvCoMKgwqAgY29uc3QgY2hhciAqcHJlZml4ID0gIiIsICpmaWxlbmFtZSwgKnByZWRpY2F0ZTsK PiA+ICvCoMKgwqAgdW5zaWduZWQgbG9uZyBmaXh1cDsKPiA+ICvCoMKgwqAgdW5zaWduZWQgaW50 IGxpbmVubzsKPiA+ICsKPiA+ICvCoMKgwqAgaWYgKCBpZCA9PSBCVUdGUkFNRV9ydW5fZm4gKQo+ ID4gK8KgwqDCoCB7Cj4gPiArI2lmZGVmIEFSTcKgwqDCoMKgwqDCoMKgIAo+IAo+IFdobyBvciB3 aGF0IGRlZmluZXMgQVJNPyBBbnl3YXksIHNlZWluZyAuLi4KaXQgaXMgZGVmaW5lZCBieSBkZWZh dWx0IGluIEtjb25maWc6Cmh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvb2xr dXIveGVuLy0vYmxvYi9zdGFnaW5nL3hlbi9hcmNoL2FybS9LY29uZmlnI0wxMwo+IAo+ID4gK8Kg wqDCoMKgwqDCoMKgIHZvaWQgKCpmbikoY29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKikgPSAo dm9pZCAqKXJlZ3MtCj4gPiA+QlVHX0ZOX1JFRzsKPiAKPiAuLi4gdGhpcywgd291bGRuJ3QgaXQg YmUgYmV0dGVyIChhbmQgaW5kZXBlbmRlbnQgb2YgdGhlIHNwZWNpZmljCj4gYXJjaCkgaWYKPiB5 b3UgY2hlY2tlZCBmb3IgQlVHX0ZOX1JFRyBiZWluZyBkZWZpbmVkPwpJZiBJIHVuZGVyc3RhbmQg S2NvbmZpZyBjb3JyZWN0bHkgdGhhbiB0aGVyZSBpcyBubyBzaWduaWZpY2FudApkaWZmZXJlbmNl IHdoYXQgY2hlY2suIEJ1dCBwcm9iYWJseSBCVUdfRk5fUkVHIHdvdWxkIGJlIGEgbGl0dGxlIGJp dApiZXR0ZXIgaWYgc29tZW9uZSB3aWxsIGRlY2lkZSB0byBjaGFuZ2UgYSB3YXkgaG93IHBvaW50 ZXIgdG8gZnVuY3Rpb24Kd2lsbCBiZSBwYXNzZWQgaW4gY2FzZSBvZiBBUk0gdGhhbiB3ZSB3aWxs IGdldCBjb21waWxhdGlvbiBlcnJvciBhbmQgc28Kd29uJ3QgbWlzcyB0byBmaXggdGhlIGxpbmUg aW4gZG9fYnVnX2ZyYW1lKCkuCgo+IAo+IEFub3RoZXIgKCNpZmRlZi1mcmVlKSB2YXJpYW50IHdv dWxkIGJlIHRvIGhhdmUgYnVnX3B0cigpIHRha2UgYSAybmQKPiBhcmd1bWVudAo+IGFuZCB0aGVu IHVuaWZvcm1seSB1c2UgLi4uCj4gCj4gPiArI2Vsc2UKPiA+ICvCoMKgwqDCoMKgwqDCoCB2b2lk ICgqZm4pKGNvbnN0IHN0cnVjdCBjcHVfdXNlcl9yZWdzICopID0gYnVnX3B0cihidWcpOwo+IAo+ IC4uLiB0aGlzLCBzbGlnaHRseSBhbHRlcmVkIHRvCj4gCj4gwqDCoMKgwqDCoMKgwqAgdm9pZCAo KmZuKShjb25zdCBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqKSA9IGJ1Z19wdHIoYnVnLAo+IHJlZ3Mp OwpQcm9iYWJseSB0aGlzIG9uZSBvcHRpb24gd2lsbCBiZSB0aGUgbW9zdCB1bml2ZXJzYWwgYW5k IHdlIGhhdmUgdG8Kc3RpY2sgdG8gaXQuCj4gCj4gPiArI2VuZGlmCj4gPiArCj4gPiArwqDCoMKg wqDCoMKgwqAgZm4ocmVncyk7Cj4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4gPiArwqDC oMKgIH0KPiA+ICsKPiA+ICvCoMKgwqAgLyogV0FSTiwgQlVHIG9yIEFTU0VSVDogZGVjb2RlIHRo ZSBmaWxlbmFtZSBwb2ludGVyIGFuZCBsaW5lCj4gPiBudW1iZXIuICovCj4gPiArwqDCoMKgIGZp bGVuYW1lID0gYnVnX3B0cihidWcpOwo+ID4gK8KgwqDCoCBpZiAoICFpc19rZXJuZWwoZmlsZW5h bWUpICYmICFpc19wYXRjaChmaWxlbmFtZSkgKQo+ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAt RUlOVkFMOwo+ID4gK8KgwqDCoCBmaXh1cCA9IHN0cmxlbihmaWxlbmFtZSk7Cj4gPiArwqDCoMKg IGlmICggZml4dXAgPiA1MCApCj4gPiArwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoCBmaWxl bmFtZSArPSBmaXh1cCAtIDQ3Owo+ID4gK8KgwqDCoMKgwqDCoMKgIHByZWZpeCA9ICIuLi4iOwo+ ID4gK8KgwqDCoCB9Cj4gPiArwqDCoMKgIGxpbmVubyA9IGJ1Z19saW5lKGJ1Zyk7Cj4gPiArCj4g PiArwqDCoMKgIHN3aXRjaCAoIGlkICkKPiA+ICvCoMKgwqAgewo+ID4gK8KgwqDCoCBjYXNlIEJV R0ZSQU1FX3dhcm46Cj4gPiArwqDCoMKgwqDCoMKgwqAgcHJpbnRrKCJYZW4gV0FSTiBhdCAlcyVz OiVkXG4iLCBwcmVmaXgsIGZpbGVuYW1lLCBsaW5lbm8pOwo+ID4gK8KgwqDCoMKgwqDCoMKgIHNo b3dfZXhlY3V0aW9uX3N0YXRlKHJlZ3MpOwo+ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAwOwo+ ID4gKwo+ID4gK8KgwqDCoCBjYXNlIEJVR0ZSQU1FX2J1ZzoKPiA+ICvCoMKgwqDCoMKgwqDCoCBw cmludGsoIlhlbiBCVUcgYXQgJXMlczolZFxuIiwgcHJlZml4LCBmaWxlbmFtZSwgbGluZW5vKTsK PiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBzaG93X2V4ZWN1dGlvbl9zdGF0ZShyZWdzKTsKPiA+ ICvCoMKgwqDCoMKgwqDCoCBwYW5pYygiWGVuIEJVRyBhdCAlcyVzOiVkXG4iLCBwcmVmaXgsIGZp bGVuYW1lLCBsaW5lbm8pOwo+ID4gKwo+ID4gK8KgwqDCoCBjYXNlIEJVR0ZSQU1FX2Fzc2VydDoK PiA+ICvCoMKgwqDCoMKgwqDCoCAvKiBBU1NFUlQ6IGRlY29kZSB0aGUgcHJlZGljYXRlIHN0cmlu ZyBwb2ludGVyLiAqLwo+ID4gK8KgwqDCoMKgwqDCoMKgIHByZWRpY2F0ZSA9IGJ1Z19tc2coYnVn KTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBpZiAoICFpc19rZXJuZWwocHJlZGljYXRlKSApCj4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmVkaWNhdGUgPSAiPHVua25vd24+IjsKPiA+ICsKPiA+ ICvCoMKgwqDCoMKgwqDCoCBwcmludGsoIkFzc2VydGlvbiAnJXMnIGZhaWxlZCBhdCAlcyVzOiVk XG4iLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJlZGljYXRlLCBwcmVmaXgs IGZpbGVuYW1lLCBsaW5lbm8pOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIHNob3dfZXhlY3V0 aW9uX3N0YXRlKHJlZ3MpOwo+ID4gK8KgwqDCoMKgwqDCoMKgIHBhbmljKCJBc3NlcnRpb24gJyVz JyBmYWlsZWQgYXQgJXMlczolZFxuIiwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBw cmVkaWNhdGUsIHByZWZpeCwgZmlsZW5hbWUsIGxpbmVubyk7Cj4gPiArwqDCoMKgIH0KPiA+ICsK PiA+ICvCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArfQo+ID4gKwo+ID4gK2ludCBkb19idWdf ZnJhbWUoY29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MsIHVuc2lnbmVkIGxvbmcKPiA+ IHBjKQo+ID4gK3sKPiA+ICvCoMKgwqAgY29uc3Qgc3RydWN0IGJ1Z19mcmFtZSAqYnVnID0gTlVM TDsKPiAKPiBOaXQ6IHBvaW50bGVzcyBpbml0aWFsaXplci4gWW91IGNvdWxkIG9mIGNvdXJzZSBo YXZlIHRoZSBhc3NpZ25tZW50Cj4gYmVsb3cKPiBiZWNvbWUgdGhlIGluaXRpYWxpemVyIGhlcmUu ClRoYW5rcy4gSSdsbCB1cGRhdGUgaXQgdGhlIG5leHQgdmVyc2lvbiBvZiB0aGUgcGF0Y2guCj4g Cj4gPiArwqDCoMKgIHVuc2lnbmVkIGludCBpZDsKPiA+ICsKPiA+ICvCoMKgwqAgYnVnID0gZmlu ZF9idWdfZnJhbWUocGMsICZpZCk7Cj4gPiArwqDCoMKgIGlmICghYnVnKQo+IAo+IE5pdDogU3R5 bGUgKG1pc3NpbmcgYmxhbmtzKS4KVGhhbmtzLiBJJ2xsIHVwZGF0ZSBpdCB0aGUgbmV4dCB2ZXJz aW9uIG9mIHRoZSBwYXRjaC4KPiAKPiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL3hlbi9pbmNs dWRlL3hlbi9idWcuaAo+ID4gQEAgLTAsMCArMSwxNjEgQEAKPiA+ICsjaWZuZGVmIF9fWEVOX0JV R19IX18KPiA+ICsjZGVmaW5lIF9fWEVOX0JVR19IX18KPiA+ICsKPiA+ICsjZGVmaW5lIEJVR19E SVNQX1dJRFRIwqDCoMKgIDI0Cj4gPiArI2RlZmluZSBCVUdfTElORV9MT19XSURUSCAoMzEgLSBC VUdfRElTUF9XSURUSCkKPiA+ICsjZGVmaW5lIEJVR19MSU5FX0hJX1dJRFRIICgzMSAtIEJVR19E SVNQX1dJRFRIKQo+ID4gKwo+ID4gKyNkZWZpbmUgQlVHRlJBTUVfcnVuX2ZuIDAKPiA+ICsjZGVm aW5lIEJVR0ZSQU1FX3dhcm7CoMKgIDEKPiA+ICsjZGVmaW5lIEJVR0ZSQU1FX2J1Z8KgwqDCoCAy Cj4gPiArI2RlZmluZSBCVUdGUkFNRV9hc3NlcnQgMwo+ID4gKwo+ID4gKyNkZWZpbmUgQlVHRlJB TUVfTlLCoMKgwqDCoCA0Cj4gPiArCj4gPiArI2lmbmRlZiBfX0FTU0VNQkxZX18KPiA+ICsKPiA+ ICsjaW5jbHVkZSA8eGVuL2Vycm5vLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9saWIuaD4KPiA+ICsj aW5jbHVkZSA8eGVuL3N0cmluZ2lmeS5oPgo+ID4gKyNpbmNsdWRlIDx4ZW4vdHlwZXMuaD4KPiA+ ICsKPiA+ICsjaW5jbHVkZSA8YXNtL2J1Zy5oPgo+IAo+IEFueSByZWFzb24gdGhpcyBjYW5ub3Qg bGl2ZSBhaGVhZCBvZiB0aGUgI2lmbmRlZiwgZWxpbWluYXRpbmcgdGhlCj4gbmVlZCBmb3IKPiBh biAjZWxzZSBmdXJ0aGVyIGRvd24/Ckl0IHNob3VsZCBiZSBmaW5lLgpQcm9iYWJseSBJIGhhZCBz b21lIGlzc3VlcyBkdXJpbmcgdGhlIGluaXRpYWwgc3RhZ2Ugb2YgbWFraW5nIGJ1Zy5oCm1vcmUg Z2VuZXJpYy4uLgoKPiAKPiA+ICsjaWZuZGVmIEJVR19GUkFNRV9TVFJVQ1QKPiA+ICsKPiA+ICtz dHJ1Y3QgYnVnX2ZyYW1lIHsKPiA+ICvCoMKgwqAgc2lnbmVkIGludCBsb2NfZGlzcDpCVUdfRElT UF9XSURUSDsKPiA+ICvCoMKgwqAgdW5zaWduZWQgaW50IGxpbmVfaGk6QlVHX0xJTkVfSElfV0lE VEg7Cj4gPiArwqDCoMKgIHNpZ25lZCBpbnQgcHRyX2Rpc3A6QlVHX0RJU1BfV0lEVEg7Cj4gPiAr wqDCoMKgIHVuc2lnbmVkIGludCBsaW5lX2xvOkJVR19MSU5FX0xPX1dJRFRIOwo+ID4gK8KgwqDC oCBzaWduZWQgaW50IG1zZ19kaXNwW107Cj4gPiArfTsKPiA+ICsKPiA+ICsjZW5kaWYgLyogQlVH X0ZSQU1FX1NUUlVDVCAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgYnVnX2xvYwo+ID4gKyNkZWZpbmUg YnVnX2xvYyhiKSAoKHVuc2lnbmVkIGxvbmcpKGIpICsgKGIpLT5sb2NfZGlzcCkKPiA+ICsjZW5k aWYgLyogYnVnX2xvYyAqLwo+IAo+IEZvciBzaG9ydCAjaWYgLyAjaWZkZWYgSSBkb24ndCB0aGlu ayBzdWNoIGNvbW1lbnRzIGFyZSBuZWNlc3Nhcnkgb24KPiB0aGUKPiAjZWxzZSBvciAjZW5kaWY7 IHBlcnNvbmFsbHkgSSBjb25zaWRlciBzdWNoIHRvIGhhbXBlciByZWFkYWJpbGl0eS4KVGhhbmtz LiBJJ2xsIHRha2UgaXQgaW50byBhY2NvdW50LgoKPiAKPiA+ICsjaWZuZGVmIGJ1Z19wdHIKPiA+ ICsjZGVmaW5lIGJ1Z19wdHIoYikgKChjb25zdCB2b2lkICopKGIpICsgKGIpLT5wdHJfZGlzcCkK PiA+ICsjZW5kaWYgLyogYnVnX3B0ciAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgYnVnX2xpbmUKPiA+ ICsjZGVmaW5lIGJ1Z19saW5lKGIpICgoKCgoYiktPmxpbmVfaGkgKyAoKGIpLT5sb2NfZGlzcCA8 IDApKQo+ID4gJsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKCgxIDw8IEJVR19MSU5FX0hJX1dJ RFRIKSAtIDEpKQo+ID4gPDzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBc Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJVR19MSU5F X0xPX1dJRFRIKQo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgICgoKGIpLT5saW5lX2xvICsgKChiKS0+cHRyX2Rpc3AgPCAwKSkK PiA+ICbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoMSA8PCBCVUdfTElORV9MT19XSURUSCkg LSAxKSkpCj4gPiArI2VuZGlmIC8qIGJ1Z19saW5lICovCj4gPiArCj4gPiArI2lmbmRlZiBidWdf bXNnCj4gPiArI2RlZmluZSBidWdfbXNnKGIpICgoY29uc3QgY2hhciAqKShiKSArIChiKS0+bXNn X2Rpc3BbMV0pCj4gPiArI2VuZGlmIC8qIGJ1Z19tc2cgKi8KPiA+ICsKPiA+ICsjaWZuZGVmIF9B U01fQlVHRlJBTUVfVEVYVAo+ID4gKwo+ID4gKyNkZWZpbmUKPiA+IF9BU01fQlVHRlJBTUVfVEVY VChzZWNvbmRfZnJhbWUpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gXAo+ID4gK8KgwqDCoAo+ID4gIi5MYnVn JT06IkJVR19JTlNUUiJcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKg wqDCoCBcCj4gPiArwqDCoMKgICIucHVzaHNlY3Rpb24gLmJ1Z19mcmFtZXMuJSJNT0RJRklFUiJb YmZfdHlwZV0sIFwiYVwiLAo+ID4gQHByb2diaXRzXG4iwqDCoMKgwqDCoCBcCj4gCj4gWW91IG1h eSB3YW50IHRvIHVzZSAlcHJvZ2JpdHMgaGVyZSByaWdodCBhd2F5LCBhcyBiZWluZyB0aGUgbW9y ZQo+IHBvcnRhYmxlCj4gZm9ybS4KU3VyZS4gVGhhbmtzLiBJJ2xsIHRha2UgdGhhdCBpbnRvIGFj Y291bnQuCj4gCj4gPiArwqDCoMKgICIucDJhbGlnbgo+ID4gMlxuIsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgCj4g PiAiLkxmcm0lPTpcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoAo+ID4gwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCAiLmxvbmcgKC5MYnVnJT0gLSAu TGZybSU9KSArCj4gPiAlIk1PRElGSUVSIltiZl9saW5lX2hpXVxuIsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCAiLmxvbmcgKCUiTU9ESUZJRVIiW2JmX3B0 cl0gLSAuTGZybSU9KSArCj4gPiAlIk1PRElGSUVSIltiZl9saW5lX2xvXVxuIsKgwqDCoMKgwqDC oCBcCj4gPiArwqDCoMKgICIuaWYgIiAjc2Vjb25kX2ZyYW1lCj4gPiAiXG4iwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCAiLmxvbmcgMCwgJSJNT0RJRklF UiJbYmZfbXNnXSAtCj4gPiAuTGZybSU9XG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAKPiA+ICIuZW5kaWZc biLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAKPiA+IMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgIi5wb3BzZWN0aW9uXG4iCj4gCj4gSSB0aGlu ayBJIHNhaWQgc28gaW4gcmVwbHkgdG8gYW4gZWFybGllciB2ZXJzaW9uIGFscmVhZHk6IFRoZSBt b21lbnQKPiBhc3NlbWJseSBjb2RlIG1vdmVzIHRvIGEgY29tbW9uIGhlYWRlciwgaXQgc2hvdWxk IGJlIGFkanVzdGVkIHRvIGJlCj4gYXMKPiBwb3J0YWJsZSBhcyBwb3NzaWJsZS4gSW4gcGFydGlj dWxhciBkaXJlY3RpdmVzIHNob3VsZCBuZXZlciBzdGFydCBhdAo+IHRoZQo+IGJlZ2lubmluZyBv ZiBhIGxpbmUsIHdoaWxlIGxhYmVscyBhbHdheXMgc2hvdWxkLiAoV2hldGhlciAubG9uZyBpcwo+ IGFjdHVhbGx5IHBvcnRhYmxlIGlzIGFub3RoZXIgcXVlc3Rpb24sIHdoaWNoIEknbGwgYmUgaGFw cHkgdG8gbGVhdmUKPiBhc2lkZSBmb3Igbm93LikKSSBhbSBub3Qgc3VyZSB0aGF0IEkgdW5kZXJz dGFuZCBhYm91dCB3aGljaCBvbmUgZGlyZWN0aXZlIHdlIGFyZQp0YWxraW5nIGFib3V0Li4uIEFy ZSB3ZSB0YWxraW5nIGFib3V0IC57cHVzaC9wb3B9c2VjdGlvbiBhbmQgLnAyYWxpZ24/ClByb2Jh Ymx5IHlvdSBjYW4gc2hvdyBtZSBhbiBleGFtcGxlIGluIFhlbiBvciBvdGhlciBwcm9qZWN0PwoK PiAKPiBBbHNvIG5pdCAoc3R5bGUpOiBUaGUgbGluZSBjb250aW51YXRpb24gY2hhcmFjdGVycyB3 YW50IHRvIGFsbCBsaW5lCj4gdXAuCj4gCj4gPiArI2VuZGlmIC8qIF9BU01fQlVHRlJBTUVfVEVY VCAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgX0FTTV9CVUdGUkFNRV9JTkZPCj4gCj4gSSBkb24ndCB0 aGluayB0aGVzZSB0d28gbWFrZSBzZW5zZSBmb3IgYW4gYXJjaCB0byBkZWZpbmUKPiBpbmRlcGVu ZGVudGx5Lgo+IElORk8gYWJzb2x1dGVseSBoYXMgdG8gbWF0Y2ggVEVYVCwgc28gSSB0aGluayBh biBhcmNoIHNob3VsZCBhbHdheXMKPiBkZWZpbmUgKG9yIG5vdCkgYm90aCB0b2dldGhlci4KWW91 IGFyZSByaWdodC4gSSdsbCB0YWtlIGludG8gYWNjb3VudCB0aGF0Lgo+IAo+ID4gKyNkZWZpbmUg X0FTTV9CVUdGUkFNRV9JTkZPKHR5cGUsIGxpbmUsIHB0ciwKPiA+IG1zZynCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKg IFtiZl90eXBlXcKgwqDCoCAiaSIKPiA+ICh0eXBlKSzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBbYmZfcHRyXcKgwqDCoMKgICJpIgo+ID4gKHB0 cikswqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDC oCBbYmZfbXNnXcKgwqDCoMKgICJpIgo+ID4gKG1zZykswqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBbYmZfbGluZV9sb10gImkiICgobGluZSAm ICgoMSA8PCBCVUdfTElORV9MT19XSURUSCkgLQo+ID4gMSkpwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgPDwKPiA+IEJVR19ESVNQX1dJRFRIKSzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgW2Jm X2xpbmVfaGldICJpIiAoKChsaW5lKSA+PiBCVUdfTElORV9MT19XSURUSCkgPDwKPiA+IEJVR19E SVNQX1dJRFRIKQo+ID4gKwo+ID4gKyNlbmRpZiAvKiBfQVNNX0JVR0ZSQU1FX0lORk8gKi8KPiA+ ICsKPiA+ICsjaWZuZGVmIEJVR19GUkFNRQo+ID4gKwo+ID4gKyNkZWZpbmUgQlVHX0ZSQU1FKHR5 cGUsIGxpbmUsIHB0ciwgc2Vjb25kX2ZyYW1lLCBtc2cpIGRvCj4gPiB7wqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgQlVJTERfQlVHX09OKChsaW5lKSA+ PiAoQlVHX0xJTkVfTE9fV0lEVEggKwo+ID4gQlVHX0xJTkVfSElfV0lEVEgpKTvCoMKgwqDCoMKg wqDCoMKgIFwKPiA+ICvCoMKgwqAgQlVJTERfQlVHX09OKCh0eXBlKSA+PQo+ID4gQlVHRlJBTUVf TlIpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgIGFzbSB2b2xhdGlsZSAoCj4gPiBfQVNN X0JVR0ZSQU1FX1RFWFQoc2Vjb25kX2ZyYW1lKcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgOjogX0FTTV9CVUdGUkFNRV9JTkZPKHR5cGUsIGxpbmUsIHB0ciwgbXNnKQo+ID4g KTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICt9IHdoaWxlICgwKQo+ID4gKwo+ID4gKyNl bmRpZgo+ID4gKwo+ID4gKyNpZm5kZWYgcnVuX2luX2V4Y2VwdGlvbl9oYW5kbGVyCj4gPiArCj4g PiArLyoKPiA+ICsgKiBUT0RPOiB1bnRhbmdsZSBoZWFkZXIgZGVwZW5kZW5jZXMsIGJyZWFrIEJV SUxEX0JVR19PTigpIG91dCBvZgo+ID4geGVuL2xpYi5oLAo+ID4gKyAqIGFuZCB1c2UgYSByZWFs IHN0YXRpYyBpbmxpbmUgaGVyZSB0byBnZXQgcHJvcGVyIHR5cGUgY2hlY2tpbmcKPiA+IG9mIGZu KCkuCj4gPiArICovCj4gCj4gSSByZWFsaXplIHlvdSBvbmx5IGNvcHkgdGhpcyBjb21tZW50LCBi dXQgSSdtIGhhdmluZyBhIGhhcmQgdGltZQo+IHNlZWluZwo+IHRoZSBjb25uZWN0aW9uIHRvIEJV SUxEX0JVR19PTigpIGhlcmUuIFdvdWxkIGJlIG5pY2UgaWYgdGhlIGNvbW1lbnQKPiB3YXMKPiAi Z2VuZXJhbGl6ZWQiIGluIGEgZm9ybSB0aGF0IGFjdHVhbGx5IGNhbiBiZSB1bmRlcnN0b29kLiBB bmRyZXc/Cj4gCj4gPiArI2RlZmluZSBydW5faW5fZXhjZXB0aW9uX2hhbmRsZXIoZm4pwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvC oMKgwqAgZG8ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoCAodm9pZCkoKGZuKSA9PSAodm9pZCAoKikoc3Ry dWN0IGNwdV91c2VyX3JlZ3MgKikpTlVMTCk7IFwKPiA+ICvCoMKgwqDCoMKgwqDCoCBCVUdfRlJB TUUoQlVHRlJBTUVfcnVuX2ZuLCAwLCBmbiwgMCwgTlVMTCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ICvCoMKgwqAgfSB3aGlsZSAoIDAgKQo+ID4gKwo+ID4gKyNlbmRpZiAvKiBydW5f aW5fZXhjZXB0aW9uX2hhbmRsZXIgKi8KPiA+ICsKPiA+ICsjaWZuZGVmIFdBUk4KPiA+ICsjZGVm aW5lIFdBUk4oKSBCVUdfRlJBTUUoQlVHRlJBTUVfd2FybiwgX19MSU5FX18sIF9fRklMRV9fLCAw LAo+ID4gTlVMTCkKPiA+ICsjZW5kaWYgLyogV0FSTiAqLwo+IAo+IE5vIHJlYWwgbmVlZCBmb3Ig dGhlIGNvbW1lbnQgaGVyZTsgeW91IGFsc28gaGF2ZSBub25lIGJlbG93IGZvciBlLmcuCj4gQlVH KCkuClRoYW5rcy4KPiAKPiBKYW4KCn4gT2xla3NpaQoK From xen-devel-bounces@lists.xenproject.org Wed Feb 22 16:17:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 16:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499703.770972 (Exim 4.92) (envelope-from ) id 1pUrnr-0003Xq-NQ; Wed, 22 Feb 2023 16:17:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499703.770972; Wed, 22 Feb 2023 16:17:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrnr-0003Xh-KV; Wed, 22 Feb 2023 16:17:11 +0000 Received: by outflank-mailman (input) for mailman id 499703; Wed, 22 Feb 2023 16:17:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrnp-0003QQ-SR for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 16:17:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1b::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b139eed-b2cc-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 17:17:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8614.eurprd04.prod.outlook.com (2603:10a6:10:2d9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 16:17:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 16:17:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b139eed-b2cc-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7VZHdKUQH5bdDV5oifPuzsOIz+nLyBu26gS9ZypsK19GWXA3spwZJvjYt2i2wSxxzWMq2ianKogtos9cFm5axbU40irR/lvXae0+Sms5U71EUFhDiUw8KZmJdPDLTAbkOXAzTeGQerAT3VNGmPyoF6/j0GlCs7x4pmKI53fVMGuDIilvrbHR+x+5m57TrVpGlUHy3+Rnt6C76+d25XCu40+BZD3xg1hmp9aGAc3fScsI2fk5NnoYzybrwk65EchOOmHfD7c5EWJcAcrnw5J1u99j+ITZrCJkNraJscF2qwxc2+yErkqLSbVOP08LDzajpNUlorGrSiC7aPH73N8SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZedYKDsnFMcEA9XU9STZjvC78cDO0bEbNWZr8fKPBsE=; b=S+6xdy9fEW6BW6tt6DoHvly05hLxzk0LDMUzl7iJ2EryQ2+YE0kewbh/eWJoBbdOwC26xhNe9zS4HafGmfC4kTLppo2kDAmxXxPAdVxgfCuAknKYjKfnYys7NWv36dmlCkpd2DoJKVsqF9+yS+1Kk70L5u/KreDR8M7tUn3wRPAsQ9hOCoe8QGj5dGWsOvR5zMYc2/2qs2ukPxWOhg/zuNcZLm+tH2XgL08nhgfNeF+bz17Q99n7/fDHeAKozzWPXq8HiC783mBmJAy1+FlXqJJ8vmke1ButEqHq5uZbEjb6tRMQYDeEDpHIOvGTd2RRJ1eXhBr1k9wbwszvpssBKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZedYKDsnFMcEA9XU9STZjvC78cDO0bEbNWZr8fKPBsE=; b=3neqTbqohUm4LQJv1jAub0H3TctfRvIdETwN6Qm5GWUFBiUWZXBeYXFJNFZz7QvN1gX1MwyZwH2jSXGHE1dCZZkvivwdEDkNeHvs8ZD+Y9AJyPw6OOGB2WXZ4xcSvSEMTiPkwVSbSNTTbZaczUzR4GtGtVNFvEThkC6Wn0rCl2dvptBRbee0Vpjr2r9qVq5xYssNoVU6SjgZJvg4X1oaepPhJTRJW/RrQHFgVJbIMvpwDCgPSxxoyAs6JGHh3jN/FAmiPGAZRk4CL22LLTa3MHGudnicORAwvtcmoAH5V6g79IS99miII6ZaE+5RaTdtnVHNJEd1oRF8uINz79zcYA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ab8641a-684a-3a13-50c2-d9912286f313@suse.com> Date: Wed, 22 Feb 2023 17:17:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Core parking broken with NR_CPUS=1 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Xenia Ragiadakou , xen-devel References: <75b06911-9ff0-e75f-b611-810277524171@citrix.com> From: Jan Beulich In-Reply-To: <75b06911-9ff0-e75f-b611-810277524171@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8614:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b6d4d67-2d3c-4082-ffb9-08db14f03dc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qoesRn3QvRgmTf7nHBzlDDV2dHdFEwnpPGqxgo+38V7OI36Fr3kchRDJZQI6wpLt0Cd1qn5iM9UDifZYsoUG2ZQCUZjKjLc9jKAnyqsv8AJk+ISTtIQRSHllU6q6h6RtJtaH71VOed/gA8T00V7YlFoQbC31VwqZRZesr2T+p9WTU8be0QwHFw3m5mffp1bXeuUBmUe3XBBi7OlGQ/Ip1m1A4F9Qem7QrhTJ86noBDXbV8S5bJkezT3WyQEZ24Lbn2z5LV1KazzZYIv5C/AlDNKceKZxuK8DG2cO9FhYiztkWMXPGQ9KSE4puaCyqVFUQT9nA863nImlRQx7DO437RXsTZSTQhAsWXbn+97SICGK9xXBMEz/OB/BUI1iVrT1FrGs3tKIuMnbsCQibq9xuoUHEsh1klXbHp9g4eiHJ9Wiu+rgKxAEyoP2QQUPkf0bar8qdHxS+H7qYeNYno6qLUosX/jYc43XgxngoJjvvqBLhEtIokngKRGzYelrcYdxBLEBPIfCPLuQizDRmtJcvAWi0qZKKxk2cynejSkxckR17AFIDg50t71PC/mHon2eW+mtxTxpr7DkN5mjMbd5V7hh52kCqT6wGfPqOHamjmgouguc0GwVv5YbboPFf3VxrEw23E5lfkzvX1+XNxwT/eRX5Xnrio4Z3HFIJy/Hx5mqGFkoUeJRBerx2ThIlJJSs852ChcF0kp1+O+c4gNPTIL+cjXgCDtTdJJfDccfZZE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199018)(86362001)(5660300002)(2906002)(31696002)(31686004)(38100700002)(41300700001)(66946007)(6916009)(66476007)(66556008)(8676002)(4326008)(316002)(6486002)(36756003)(54906003)(26005)(8936002)(6506007)(6512007)(53546011)(186003)(2616005)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzdNdzkvZ2RsVjJVNVk4dldWdUVWL3BWUklWRWRpYWpEZkNURXFvZ21hMTFH?= =?utf-8?B?YnBHNXVwQTVvTHBEN3BpSm1IMXVoVnozeHdGODE1NVhTemhBMXJqZ3BIV3pm?= =?utf-8?B?Nk9PcmNTSUNqOHhiZlRTV1FLWlJmNlhtT1c1UFl5M1h4a1VWcThWb3dxeS8z?= =?utf-8?B?V01manlwRVNwNzczWFBwaStSV3IwTmJ3VVpUTkZFL1JEZDVZOEQzUUhNMUtJ?= =?utf-8?B?NXNsbEtaRDJ3c0tnSm1scTZvdHlBR1pGS0Q4cVVxeW8vNTUyNERBSWljUGh1?= =?utf-8?B?WnFsY2NzSHZKbVB2Y29lUlhudmZReG5TWUx6bFBNaVpTWVdaNFJ2SHlPVGts?= =?utf-8?B?SVgxbmRXd0V4Tm0vVlhlTUZoSmI1NkJNakFFZWhRdEdmWkxaaHlKcjdCMWdm?= =?utf-8?B?bFJDeTRGL3FQbHVsM2VKRWx0dEY5alFaVm5OSGZRWUhnYW12Nnl0aksxUUJE?= =?utf-8?B?WTVwNFlGZWJmN2FGMzB5bWNMbHI3NXlRaElaakVWTzhTN3BnWHgydjVKSFNT?= =?utf-8?B?c2k0dHhFZUd1R1ZLazJVSjBETjN5TWh0RHZYQzVIWFVFQjFPZ0ZYTTNPZUQ2?= =?utf-8?B?L2dhYUliTjlzUmtxc1p5VzZ1b1l1K1BkRTA4VEtLeE1yMVZmM1NMaVlWMW8v?= =?utf-8?B?YTJKOTY3M1c5dE9yVmt6WDJUUkN5T0ZwK3o0N09RWCtJV0hEcUF6TmJnYlZO?= =?utf-8?B?ak9jRFZHM2xoS0Q1REVKQUVZRWNkN29YOVNmUXlmUUlqMHVZL093YUtFY2Ja?= =?utf-8?B?UnhweVJiT3c3MjJVZ3VOLzVheVlPWVBBUnpJczFVUUNEU0h3TEdjMTg5ODN3?= =?utf-8?B?VW1nOTlxMDhFbi9qVXh3OW1PRGRnZ1VZZW12VjdlZTNFbE42NTRaS0FpWWgy?= =?utf-8?B?dGxQNGtiK2hRT2NLOVF1Q2lPVEw4ZVNvdjBrbTJEMFVVMzVmMVR6NDdVcENw?= =?utf-8?B?aTJKd2tteExqTjZJcGx0SjdyUHNVV2lQWCsvek00cktzM0N4cWxaeVpEdFpI?= =?utf-8?B?dmJGUmtGeDRFaWk5U3cwZFFHSGxqaHhCVzZLdVYwb1oyd0tKRU05ZDc1WDJw?= =?utf-8?B?T2pVZGtaam9QeFZJRTJxdU15MWlJQnc1ZkxGUlg1VVJzWlNRbEt6TzVkd3pr?= =?utf-8?B?bzJKRys1cVVZY0JjeENnUTVFdXl6eVM1eGdvd0pKTElUWTlTYTkvUFBkczZZ?= =?utf-8?B?dEdBWG1WUTY4L3BHQ1lrais4SXZkYjJhcUNGMExiTlFVNlZ2dVlodkQ3TC95?= =?utf-8?B?WUlBSzhYTG5CVVk2M2NzS1VjaE1qMEZDMjV1T3oyRU0xTzlFQjRvQ3lyS1Vq?= =?utf-8?B?QjNta0hONnJ0ajZmY1hnRE5PWUpsR0syQVRhUVQ0WkZ4Ui8rZHZsTFUzSElS?= =?utf-8?B?cThEYVZxYjlOdXV0bm9lbDlOR2RVOStKYktISVYvaGZrcVdXZzFoWnpvK2V1?= =?utf-8?B?QzMxbGtYRWxYcFU4WThjMWxvbm5UY3hYaHdPaXV5OU8zdW4zR0VaQnVISXcw?= =?utf-8?B?WjZVWWpvVlhoNytpUkJXbmhZdDFsYWVHU3JLaTVlZVZQMmZYRnhXWEZGZ20v?= =?utf-8?B?V0xLM3dlTlV3WXJGdlQ0bmVjRUFtN1RLNlAvWkFpZmRWOVUrUy9uVXJQbzhK?= =?utf-8?B?cUwzT2l4dlJackx6ZEllM3VvTlhpTUc4eXlXTXY5OW16L0NsK2FLcVpWRnpw?= =?utf-8?B?UTkzSHdYdHRXSURKYkVqcE1ib1FsVzE4UkFqRC9yR2pmNUFxMHkwTXNtRkd4?= =?utf-8?B?V1hZWFhPOU15WkFlZks5M1VXdWdVOWtzYjZRUFYrWndMM2xaNDVXRmJDbVB4?= =?utf-8?B?Skw1cWI4WENhNlVZcjREcDVFYThLTWU2T28rWWM2MGl1NVZUV0pNMVc3THNM?= =?utf-8?B?VkhrSlV1M1dkdkNOQ3hPeDc3REFWZkZIQTlpT041eC9uOXF2anlNdlpDT2Vj?= =?utf-8?B?cFlqVldhdnprVk0zbHlieHZhQWxiMTdHVHpmMThTQjFzZEFSNXNrWmhUWGt2?= =?utf-8?B?ZUZtZ1hwM2FWeHltTm4wL1pkTzA4UzBlNFh1TjVjUTN2c0NHTjZGQUVjejlx?= =?utf-8?B?U2hSQjVobGlXcU9iaHZ3RDJoQTVtZExUcW1TQjJOU3ZxTS81a0JyL2JOM2sv?= =?utf-8?Q?0K7DY0qKawfkFl/zRxpOhLi2I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b6d4d67-2d3c-4082-ffb9-08db14f03dc9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:17:06.5818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2NfXETv+R2CpjBbCUNWKDyp0TwsN+NPgtB3uanVeLLPmkB6L+kwHDYSV1ej0a+pq7javmxtIc5qxuWZBDZVllA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8614 On 22.02.2023 17:04, Andrew Cooper wrote: > While testing the rebuilt debian unstable container, I found: > > common/core_parking.c: In function 'core_parking_remove': > common/core_parking.c:230:53: error: array subscript 1 is above array > bounds of 'unsigned int[1]' [-Werror=array-bounds] >   230 |         core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >       |                                  ~~~~~~~~~~~~~~~~~~~^~~~~~~ > common/core_parking.c:31:21: note: while referencing 'core_parking_cpunum' >    31 | static unsigned int core_parking_cpunum[NR_CPUS] = {[0 ... > NR_CPUS-1] = -1}; >       |                     ^~~~~~~~~~~~~~~~~~~ > > > which is an legitimate complaint - this logic is simply broken with > NR_CPUS=1. > > In principle, I think the best fix is probably to have CORE_PARKING > depend on NR_CPUS > 1, except none of the interacting x86 code has been > written in a way that would be compatible. > > But it also occurs to me that this is the kind of thing an embedded x86 > usecase would want to compile.  Frankly, its niche even on regular x86 > use-cases. > > Except having looked at the code, it's a different to the other thing we > call core parking which is the smt=0 logic to keep the stacks valid for > cores/threads we don't want to use, because of #MC broadcast problems - > and this logic does need to stay. > > Thoughts? See "core-parking: fix build with gcc12 and NR_CPUS=1" sent back in September last year. Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 16:21:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 16:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499716.770982 (Exim 4.92) (envelope-from ) id 1pUrrm-0005Ox-7Q; Wed, 22 Feb 2023 16:21:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499716.770982; Wed, 22 Feb 2023 16:21:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrrm-0005Oq-4Z; Wed, 22 Feb 2023 16:21:14 +0000 Received: by outflank-mailman (input) for mailman id 499716; Wed, 22 Feb 2023 16:21:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUrrl-0005Ok-HC for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 16:21:13 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8c9d3d1-b2cc-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 17:21:09 +0100 (CET) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2023 11:21:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6179.namprd03.prod.outlook.com (2603:10b6:610:d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 16:20:56 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6111.020; Wed, 22 Feb 2023 16:20:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8c9d3d1-b2cc-11ed-a089-e9535cc0f9c3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677082869; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ry1zgO45iuqBc571aeuGCh+3uDngkmuUFg84b/u2b2s=; b=dskAnNSdbn43Bl6gwTWDwAuaIIdEmKRByKqV6FVzQSVFRYJNi+htwYPr kcaF+MuOPkWH6+GJW7lCRHyq1fUbOuosY9wODyYkwMaMKsGM61bUyZUvt /gR6sNzTADzS473NQgF8DHWqx/JTii6wl5FqWeyyrJpjIn0ta60YCQ3z3 8=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 98503601 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8qWVDawMMinp3KZRPo16t+fkxyrEfRIJ4+MujC+fZmUNrF6WrkVVn DdMDTzVPPiCY2Lwfd10PIqwoUwCv8OHyIdlHAVoqiAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkP6oT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWNW9 adCKHM3VTaoh/uY3q6qE8l1iMt2eaEHPKtH0p1h5RfwKK98BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvTaVkFIZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKrBdpJSuXhnhJsqGyunG1LByQkaWuAut6wiHS9ecNtd GVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQMc9qMY8SDgu1 1mIt9DkHzpitPuSU3313r2JtyG7PS8ZKnALTSABRAoBpdLkpekbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lW0rmBqpr5nNCwsqvAPeWzv/6hsjPNL7IYu19VLc8PBMap6DSUWMt 2QFnM7Y6/0SCZaKl2qGR+Bl8KyV2stp+Qb02TZHd6TNPRz3oBZPoag4DOlCGXpU IronPort-HdrOrdr: A9a23:XPLLIqCww3fl1crlHemo55DYdb4zR+YMi2TDgXoBLSC9E/b5qy nApp8mPHPP4gr5O0tApTnjAsa9qCjnhPtICOAqVN+ftW/d1VdAR7sN0WKN+VHd84KVzJ876U /NGZIOa+EZrDJB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.97,319,1669093200"; d="scan'208";a="98503601" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPMnepnX+Cx+ZQlH8ukoQBdY2I1fNyTjhwavu2J6Sw1qyO+K7F2wVAmhCFEMUr2pdfUXXqoKJ0BaucXUcWXFhaDy47z5BmNXoksoUBCc172WA38lJjWxNjHgFNL2RAAxw5/HCCgftMiBY7VDHf/ZU2z1FB/Yuqqnn4VBr2T7oZdP6E+vTl2sXp8xbqHLNsBxR8T36gtJm1bKaHMGS7yQUGbOjrtbZVSFrwjjeWlNI16OVfW7rY6jvmrftIFk/sLnMB30WUSSI/deEqLSx2bAQdOgwV0ltLzxFleJ7HNvCugaDVU81mF3/g31f1QgarlioPg5NukMhTMiLeiwaIWVvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ry1zgO45iuqBc571aeuGCh+3uDngkmuUFg84b/u2b2s=; b=ZiuiDMiJ93OsSNvehNXEEjsLouDDFftu8mwwo0eJHV5jhRc1/DobVpdKgUsTDKddIUVN8FkXl7lU4haCUDvoA1T+GptdRKzstJNnKtHoRYytN7dR4c6W0btOd3VNOJzGDxHkS8j8D5ZmRm6/QFOody1BtOorRcW0ev07i/KFVNjc5cHygi19dQkcscwt6WKQPE2i/8KVe6hOl5vtTMIdY093HJNOzsoFFXkHSyVnFU8SoS1e1VEN0Xi16LT1vdfdLZ234bas/AWXiV1JIc+H/xFL80OlZkaSapHrU9ISSb2Dpo7sN8w49PiiJw1c2IIa0IGF8W8+SVTdfGtRAEOGKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ry1zgO45iuqBc571aeuGCh+3uDngkmuUFg84b/u2b2s=; b=CuUFB413vleBvMnZV+TjCDrj3JqYDOk3HzGmtvKs5x4p2W7uE9EafSXkmgbURX5FRDrSUZxrPA1aAZZqGeIw7BLKOzbzaa66qe+9627/AMFN5C3qO6j0WQnbwNjyE8A6+svNh91v6lstVIrdrcWw5TTfSiE82hCv5CJ/hGXX+OU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <99baebe6-7552-bd46-6f84-724bb300443b@citrix.com> Date: Wed, 22 Feb 2023 16:20:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: Core parking broken with NR_CPUS=1 Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Xenia Ragiadakou , xen-devel References: <75b06911-9ff0-e75f-b611-810277524171@citrix.com> <0ab8641a-684a-3a13-50c2-d9912286f313@suse.com> In-Reply-To: <0ab8641a-684a-3a13-50c2-d9912286f313@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0375.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::27) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6179:EE_ X-MS-Office365-Filtering-Correlation-Id: 736380b2-cda7-498f-8a8a-08db14f0c691 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5W4hAX/Bx8s5QwTFYC7PqQjf3kqQYEv1dJ07X1C3rDufKlnmwQPRdsBI2H1GGUmd4tmfgDBOtgFQwieKfqK9b9dGqT3B9mFfDPBqSqJYdxmdMJbwzai2tqh3mrRnrui5iqUK99JUMyYLSVgb2fN67xsvOlD6+cYrh28oMFHT1if2Y47m8wSXHvtsHWCuiGS3ZQb5el+vIe8tYVEhSUvHWiIrMSEwtkzA8ieWsuDEPL0NvUjMgXEkyai0vwfhJ/h0ftEgOweCZdNJ/p1yvRuHgJ+u/AqGaAjsIskysYBx5lLGuDvkikVpGSzavwCe4Rdm7l7H1/hQZ0N7l/VO0q74QeeprATFFeQmKDfgldbIvHZPKDz0C35WiiTl2MjBgzmFwCOdQ6YHgoadfKuPnhRgD7ieKHRVtYSfBxZLPNBD0UU5ZMxylGmj+AGiK/rNnRo9vpY29cqV/s2X8B0caFgDdCDFj2NQhfFc1zMwhcxRW4HiqYfxmuGdKyvthaYOKQfOWY153oA8h4FEhCcc3q10xNIgCEGeQPDp7RgsnRr6pgDIuJBh8AsWAJIgAjn80hHh+xO1QHBeAPhZUVWYQM28ziWqPNHBa7CrWbjG2MG4LS1tTni0SfUtFwtsG445bXXmWryHv1cSQX29g0Az/y76JmfEcoFmdac6s64/UUdLyWv3dY3g30WmWZ/9sjzcJzA9R1qQrIRQlVb6MMPlQsmzEsuUCQk39iWIEWjFdDto9LY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(451199018)(31696002)(86362001)(36756003)(6512007)(66476007)(66946007)(53546011)(6916009)(4326008)(8936002)(66556008)(186003)(26005)(41300700001)(2616005)(316002)(38100700002)(6666004)(82960400001)(6506007)(54906003)(6486002)(478600001)(2906002)(8676002)(5660300002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2lxaVVRblVpQ25vMW9FNE9Db3ZGR0U3aFNkdXRoVUJSTXluYWI2UmM2S0lD?= =?utf-8?B?RDVWVm44QVlpbCsxRzhqZmo0UzlPa1BVUjl4TXBiNWc5b25yUDNabjM4NGxQ?= =?utf-8?B?K05ld3J2S0hRWnpRS29rRzEvMWpiYWFJQkg4cy9jdG0xcmNiQ1lNUXpueno3?= =?utf-8?B?ZUpjL0MrUVdPK3R2ZERvNXFTWm54cGlsT05EVC9XNEpaVVlBSy9YRUJoc00x?= =?utf-8?B?WlpDazNiWkpqMDlqMGlyRkk5T2NiUTR3Z2FjSmp3cE1ZaWRGWDY4NXJsTnFH?= =?utf-8?B?UG90MDFxc3JVbStmaUIwNnV5Y0JIRTBjV3JDTVIycnFINHlwZmJOVFFmV2Z6?= =?utf-8?B?dnUreFRSRUdOYzdHMUlJMjFDZE5ueFBZT0YreGFhdVNUM2pCRXhRTlNEY3Bm?= =?utf-8?B?QTA2d2EvZ1FVRTluWGx2SjdqWldqNFJLZGc4eFRWYnFtNmxYM2FOVjBnUEEw?= =?utf-8?B?Y3BmUHIzeU55MXljcThWQjd2MVUveS9KcyticzltTzIxQnNyN0g0WlJYS2Jn?= =?utf-8?B?bnhRV2ljanJyYW80MklERHZGcFUzZFBIUHNWN2UyUjg4MXc1TWo4bUFPeWRt?= =?utf-8?B?ZnIvaFcyZGJzd0s0SVVDSkU1M1FoMFNSNUJ2aFN2WkpDSmszcFIwN3NIZUxV?= =?utf-8?B?Um9CNFRYY3hYcWVQVlFETW0zYVZvL2VNakg4OEZKRWk0ZFluNS9sb0NXL3Rk?= =?utf-8?B?QXpWcGhwZ2ZxSU0vUVFCK3RIamw1ZnZVRHNhMGtzUFFWc2tPYmk2bDFETkVz?= =?utf-8?B?Wi9JRFUxNEZ4OEtxZ1lJajZ2djJOdzFpY1VTVmMwMTlhamNSN1FjeWpUd0gv?= =?utf-8?B?NE44NDFVYjkyWmxWbkgrUFltbDIrMXBmMGE4Um5Jejd3ajFBZldoaGtkN2I5?= =?utf-8?B?bDhEKzBZZCtmUXc2RnpZcG5ZS0p0UkFRNDA0UXpad2tpRTl0TzJmZnZqekt1?= =?utf-8?B?UndBYlBvcE9pZ3p1UmV6dzVSbnU3MEIwakRFNWE0M3lYd1lZSHhpSE5ycURR?= =?utf-8?B?SjJSeEpQeTV4S2RMUlJ2eTJobGhyVkhpMjZvRk5GbXM2eVpncmpDQlVHcERO?= =?utf-8?B?QU9yN3pVUVB1cU1KRitXejFoQW9PMzk3ZVJTMTg4d1JpVjRBTlpwK05lQ0RR?= =?utf-8?B?dy8rWTFDQjFncUd0TDVTamxTcjhheE9vUUhxb1hMYUhEUHY0VEpjOWM0dkhI?= =?utf-8?B?NHgrcXI5dmQwNVJIQnIwSkI2QXArdlFnTkJGRXpRalZhK3BCdlBRbVBYSC81?= =?utf-8?B?QnpGQlR2MFpOTytOQm5YWTc0QmVaRitqZnlWYkZDNFJGaE51RXRtMEhWNXRE?= =?utf-8?B?ekVYUFAxQ1FnYmlKcFBJUEt0enoxT3A1RXA1RnJrTUhCNnExNEFwTHNjekZn?= =?utf-8?B?QXdKeEY3WlM1RXdKM1BUc0E0aGVBTElUc0N4eWxVeUs0K0t2V0RBTXB5WWhm?= =?utf-8?B?M0Q0cnJSaGdmQ3lKRFBRK3VEZWFYMDRYdDRLa29LYzVzR1VRZTBFcFV1bnNK?= =?utf-8?B?N1RKckZ1ZC9lbkpLQTNsVC9YSVVHV2Z4YnJEVk82R2loMFE0SThDZk90RXJ1?= =?utf-8?B?aWlkYUNzUmhWY0Jyb3NScWdON1pSQjhPbHBuRXI2OHhBMmZpVVlTQkRaSnVt?= =?utf-8?B?U0NveWxsRlFzdXlHMHhmMHdiR3gva0QxS0RUWUg0dEZob3NodXBaV0NqL2Ft?= =?utf-8?B?WS9EMEhsNkVXd2ZlTG9qOUQ2VFZlaldtN1N5VzdXc1BuTkFCb0EvZlRmck80?= =?utf-8?B?akw3WFZ2d0lqdHArUVM5R0VwQ2g3WWdGcUZOa1cxVStYc3k4K2w1eVFlaUQw?= =?utf-8?B?TW84WXFzVFpkQkhpajhaWHhDRjVSS3pjOHZydHBMRXltTmh5WTdQMURDVVFa?= =?utf-8?B?cC81cDVEV0E5YXR6Y2czcXJkL1FhajF2SytaOVNWYnFySHJHbGpxWTNUL1Ra?= =?utf-8?B?RWJMNGNMdVZwM01kSlFhWGJkK1dudUxDblg3YmFCRXVXaW1xSGo4OEFZMlp5?= =?utf-8?B?R1ROd0tpSnNaQmovZy9nYnRpc3pXS2pvWjRQcmw1TzVSYTUwb1pwaDVtMXZR?= =?utf-8?B?S1d5emRhYjdpZENsYWVIQ3JpejgvMFpxN0VGVTJxZ0VoSFpwVm0ydnB3Q2NL?= =?utf-8?B?cFIxZFc5RlB0RnhVbGZ0WWJqVFZ2dFpPMGoreTVIQjF2c05EVjFrUjRCdnE3?= =?utf-8?B?eXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wU+auJYotSzbM47SxDqIdkFRg9DYyGLl9k93g8JRvPpNv3z5sG+q4qT1V6RwM+TX6Mj0B+PxNh9xzkGNV1vRaKAeb5JZtlvgKhz+iNWv/0ZzU2IIen7L1ASRQrCsrpWe3e1o52/bzCIhLGtaBWBN7GFqTy+T5bgwlwiTUHPt6Ayr4i6JSUyUAsBnbMc+d9x7+mSKqBTra2FfDYVRyjKnix89DZTFmhPLhI//wsAolww9NNeas1O2itBCS10u1C5JHb+OmK0Zj2irAqjOYynX4OK0LCKmIUEa7yCLIcnp3SvFpZI5LOUk9J4/Oh89ZoR6MjxUMSe1ABedxFlphj3tAsLAyM9oFENtdU7B7JWfXbUMV52eIghnuqmAptM59iY2z5H4saLevVQEUhvCUA0/6NXHWFT/2Tplbfpb+UvRctz6DJ8bG5MDkA0TlKrApUclDCaq0oPxu1fFP0eICraSt4pAPZs/XcidT6MzACZwOSTXY+t59r22lGdQ8cMTqD2xOEJZ+HcdzW9U4bqmMxMa0Y2S5yPU1Qm65GhFmWX2FUBP8gFHXtdNRE41Th7UWIrB+T49yvQYBEVTBFxArIV0oA6dawbexCXjpLm6yVUoC7svbD0KpIAPpQZJAXOtmDF+tEFHxB5RBc10gq/vz79bftbI0R/cIm6woDdFKqUOhygXTD2MPm7iSMukRcfo8REqt8aIfl4H2HL+9o8LZbbErHHAhuW52nZIEpzpTQRU+cPOCCMpyw392IkQXKCjnpOFZkVXxr+6S/9RJCh43M2FL+q7mSKVBrPOybp72ieJk+EEzPMLiv89LgEflzaZnkgDScF/3kcIu3HQgFjqECx53qEusdM+bda7RiiYDDK559HsZMOYei+k3mlon0EHyNcR X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 736380b2-cda7-498f-8a8a-08db14f0c691 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:20:56.1846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N60JA1mpMqNdwLnjpSftbdKO/qdPSh9lz45kWCLztT/UXoWu6xt635OVP+6jpezCmxzbfTq86S1MGFb8cJHe+Pq15fAnR/IvGrK3lJoyZvA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6179 On 22/02/2023 4:17 pm, Jan Beulich wrote: > On 22.02.2023 17:04, Andrew Cooper wrote: >> While testing the rebuilt debian unstable container, I found: >> >> common/core_parking.c: In function 'core_parking_remove': >> common/core_parking.c:230:53: error: array subscript 1 is above array >> bounds of 'unsigned int[1]' [-Werror=array-bounds] >>   230 |         core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >>       |                                  ~~~~~~~~~~~~~~~~~~~^~~~~~~ >> common/core_parking.c:31:21: note: while referencing 'core_parking_cpunum' >>    31 | static unsigned int core_parking_cpunum[NR_CPUS] = {[0 ... >> NR_CPUS-1] = -1}; >>       |                     ^~~~~~~~~~~~~~~~~~~ >> >> >> which is an legitimate complaint - this logic is simply broken with >> NR_CPUS=1. >> >> In principle, I think the best fix is probably to have CORE_PARKING >> depend on NR_CPUS > 1, except none of the interacting x86 code has been >> written in a way that would be compatible. >> >> But it also occurs to me that this is the kind of thing an embedded x86 >> usecase would want to compile.  Frankly, its niche even on regular x86 >> use-cases. >> >> Except having looked at the code, it's a different to the other thing we >> call core parking which is the smt=0 logic to keep the stacks valid for >> cores/threads we don't want to use, because of #MC broadcast problems - >> and this logic does need to stay. >> >> Thoughts? > See "core-parking: fix build with gcc12 and NR_CPUS=1" sent back in September > last year. I'd clearly missed that thread, but the final part seems to have agreed on a NR_CPUS check, with you saying that you'd send a v2 "in a minute". ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Feb 22 16:57:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 16:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499723.770993 (Exim 4.92) (envelope-from ) id 1pUsQI-0001SN-SZ; Wed, 22 Feb 2023 16:56:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499723.770993; Wed, 22 Feb 2023 16:56:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUsQI-0001SG-Pw; Wed, 22 Feb 2023 16:56:54 +0000 Received: by outflank-mailman (input) for mailman id 499723; Wed, 22 Feb 2023 16:56:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUsQH-0001SA-9O for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 16:56:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7d00::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e714c07a-b2d1-11ed-a089-e9535cc0f9c3; Wed, 22 Feb 2023 17:56:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9581.eurprd04.prod.outlook.com (2603:10a6:20b:470::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Wed, 22 Feb 2023 16:56:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Wed, 22 Feb 2023 16:56:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e714c07a-b2d1-11ed-a089-e9535cc0f9c3 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbfDcXX66t2PACUS+KViHmjV51EhnlvPSJYInv4EKO3/sebttXKT6A1aSG6WH/zrjCWuOhmJ7KwlHauVhDAMvOPg7UCOS9+60exInOSfCeiGmVw8eSPqaQ5JouPH+yAEBkhaNzl50NvKnT8RXH1+gKO5UK98Aq4hsxKFOmGnJxkfuoJcFfhoUY5TtjQqaqV+T1tUrf476MlhwsR98pCjTGkJPU20LD3yNYbHWPdKbp3R/ihgSiwJo6fCTzInkSxrGbruNie3y004Q+Glux76GEHB1PKhfyVjJc6nAo5bg2E0NniptyZCEqCAlNejQS7EH7nWA6hv/yr6wBcYBxCLNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uz1B4ZwDYVJs1GUArQztzdg/Oss6AlYDIWpxSyBKX1g=; b=Jkcw1mR0sMId8/16GBBqR426h6cpvHrrKarQouvVvfSUpRkxCwRbApQ77u7SYZ0UzmH67z4RPU/mKLt6FqpzDuzsjQh7ZLx4t7+vpzuxrqSu0KpcbtTIfAOIYSeLFOXiXMqdQkbQBJJN+U+2CMlSGoWijI8E2Hm0fFep3eINtZoGLlfzwz7rnKJBqJoK7hvgAvKkwIsgEc4825EZhFkjotQ7o1LS42vlCrSgmk11zy84fDzX4lbZnHgg/iVVXGxnADug73vGU372XKxRQ0G68oO9gdH5Hjp+nGjrxvNYUbtk8WZRv5zcNKR7mRYHRfgXAhy/rPTtrI0SOULnpGWCIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uz1B4ZwDYVJs1GUArQztzdg/Oss6AlYDIWpxSyBKX1g=; b=EDqDLKl17hWvm4QYHKBrD8tGIkdEL8N9hV5hzVGDw7pq+9GTyq8qfnjdHPNwUqTa2B8DhGNqNce/1ElXiaV0ToVxNlCOTalak5kARUP2vECuT3VS8uOqDtDoMTl1RfpSsX8FKEHPkWHv8Q87VpSNlSO0s30v11bCyeWxAoxJFxNgUu2cmdQQtxSTuVExqZqHxM+0J8Vle0pHJl7oAEKSQjzueBkNG6WFqYH4YGveIVKJV1WTf7qCip46d/6qudbPkn4xzy9dIO7bsB4OnKL3YQzVfJXYi8EtNXKl0B4txasLuP2DE41Js6eyCuD8c3sP73CiTd5NTVO2WzVIXA6zow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <874332b1-8cd0-431a-7d90-616bf7d762d8@suse.com> Date: Wed, 22 Feb 2023 17:56:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Core parking broken with NR_CPUS=1 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Xenia Ragiadakou , xen-devel References: <75b06911-9ff0-e75f-b611-810277524171@citrix.com> <0ab8641a-684a-3a13-50c2-d9912286f313@suse.com> <99baebe6-7552-bd46-6f84-724bb300443b@citrix.com> From: Jan Beulich In-Reply-To: <99baebe6-7552-bd46-6f84-724bb300443b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9581:EE_ X-MS-Office365-Filtering-Correlation-Id: 694b8985-3b5d-47f0-33f2-08db14f5ca1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +H8GTqnpC0JPbBIq+tIxPxUBe1uxhSUxayb+CRHjzxBP8ZdwY8G2lCpRb8dId4cgYkjt3ApUX2S9v15qZWDMqYcJbWTKhKOtS65Pac1gCifR8tFW9EmLrdbXRpQ+JKBuVLwS67Z0bT7KP//xd8phXdpRLypLU6qG76L0eZahIrNACV3LnCvyWctrRrkFLjOOvKs1XmcnzQP740VYv5w/FO+PVetTSUIcB164W49737qzkVHAlrd/3N9c41tpe/99uuNbS3vyUOwKzN9h7Nu62JDp3ixtb01+qVscdNrbHExHe5Ihoyvk/P3e2DDtdrsbPA/s1MVvX3fR0kQ3mvaI+aDeb2gcIf2QCzi11+FT8qBUqBfRuxsuMFYuJOpPVEH35QIF+TsnFri5w3XRjUoxMoTF1unS8qYDk+d9K5V1uGhFLTP2K9lCVqXtqhaH8M4hxwzAeqwpzmmBl0uVTozrHQ64SccYxtzHQKAPSI7w5S4lBjfe6ladcHpzDj76oC+Taytcom69isUWwW9RadFzHIjYJcP8/Go/pNN0c7jFZ0VP4B2n9qPCdpqXAO8pF/AVtlAhWZ8PMm+UlXjIiLe4Jms4d0NCNAnyN/dh4G7DiB0O0BXF9HyK5WjOaxNAQqo7K2Ki/61IlWv2hLsp9GA5/F03wlBtqJirbxMmEIPS75820Z4R6/BOzalySkoIhpLVVi47d5PpwveTZX4dgilXaq3IRNFNeeZeWo7h8qiRm3k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199018)(53546011)(186003)(6512007)(26005)(478600001)(6486002)(2906002)(2616005)(966005)(66946007)(316002)(8676002)(6916009)(54906003)(66556008)(66476007)(6506007)(4326008)(31686004)(41300700001)(8936002)(5660300002)(38100700002)(36756003)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUpoRU9Gcjc3WXlJU05qcjdCK1FCaStQMHRhVm9LcUkwRnpQZkxrVnZTbEpn?= =?utf-8?B?U3hSOG5nQzVOQjRhNVJrSThqOXhUVTlQZkZWN3hxckhIRVRFVmpJcUtyblZs?= =?utf-8?B?aXREdUZpdDJqQ04weU1UdkJ1dWtOaHZmM0hvZUJLSi8yZDE1TXgrM3BONyty?= =?utf-8?B?OWF1dFZzREpSYXBCYWFoTGd0bGl3MTlSMGZhU2I4dWRPSHZ1ZG1aSVp3WVpN?= =?utf-8?B?ZVZ3VHFxd1VhZVVBYXdsV0Jvc1ZqQWUyWU41VUV1cGpEQ3pIZVNzSk9kWTNt?= =?utf-8?B?SVFsRXQ0QjZ0YndKOUlmUWZhQWlYQjFZRGdscUdXYk9WeUVOUWVOWG92SDl0?= =?utf-8?B?eEtDaW5NbElzRWJqcGJzUjNuRElOaFdpUzg5ak1iL2dlOTVHUmFKbWpoWmw2?= =?utf-8?B?UzJhY0dlc3EzRmU5aFFXbTB3OC93SFg1QS9xN2VRZFczdkU0NGRCSTFCZTV1?= =?utf-8?B?UTlHTzY2SHN0dXVDUXNtSWFmY01NRnBHSmVYenI5SmZNSDdmNXJoZXlYNmh6?= =?utf-8?B?MXBUekNmYUlmNDRNN1hqQXE3MGlwZUx3c3hIcit4NzNwSGliaDlvVXlpQzBG?= =?utf-8?B?dmlDT3NQdW1ZWE0xUEVyMU1jWExkeThkODdocXUrRlFrdkI4YUdLdCtTRFRJ?= =?utf-8?B?SVdPR1Z3cUptQS9xbnpXNmpoZUo4SzBOdWtVUmExS0c5ZEc5UklVVVI4cHly?= =?utf-8?B?MEhBdGNQVjRaeUxuTjRrTk1kbEtpeGUxTGIzNUlvSU1QSkJPL1I0VjRIenU4?= =?utf-8?B?MlhkbytmclFNbWF5UXdaaFBPZVFCVXArc2dQL29PT3dPSklvYzRHbmpmVitk?= =?utf-8?B?ZkdRTjhzc2gvT0JlaDNqL1RWVU0yOHdPT3lyVGtERGRkT0NYb1QzOFBtQVRY?= =?utf-8?B?QlR1RnRqVk8xeEZ2bHAyM3dMa2JQR2RZMnptWTZWRmVQY0F1MlVldFBTWm9h?= =?utf-8?B?eHAya21Fb1pvc0FEeTBScm1Iaktwa2t4Y0xjZGRVeE5jaUo3dllDanhNTnZC?= =?utf-8?B?WW9XZWRpM09yOGR6bUZRcG5xYllzMnJUNWR0N2k3RVZHdjI1UDlzU3p4OVdE?= =?utf-8?B?TG91eVBPVjNoMnJjYnFJTnZDMmZSSk5HdEJ0S0ZTdW1NTFBNNU9BWlh1RDUv?= =?utf-8?B?Ri9EZ3VvQUk4VDNyM2prVzNiRG1nWmVCQm1vTWxZYXdQK2EvdHRZUjVlejRN?= =?utf-8?B?U3NOY0dwcTIrVEpHS3pPMGxvcHV5N3J4Z28vOWo1RjN3akV1RnpKOE92eVZj?= =?utf-8?B?VWw0WW1CdFB4TjNTZlNYc0JFT0pWZWJsU05Bbm1RZDFhcDFoQXFBR3BHZ2tw?= =?utf-8?B?a2RFVUFuNWU2K1BTVFRKVjR6MzNWaHNMSXBwNklXRlAweW0vSisyRHVCaDM0?= =?utf-8?B?QUFwZTJDay9BYUg1SlFzWWJkekFHRDh3UzIxUGZ5ZUJVK0NqK1NpL1pXSVVW?= =?utf-8?B?RldpVzlKdWxCeC9aeFVadGk2eW52MjJpL0JQK2FhNHIwaWJIdWtxVFE4NC9y?= =?utf-8?B?ci85dzhEUXo0UFRJYzlFUmE2NVBBa3VNbTdOZkVPSEcvRkNHM1Fmb1ZZYmF4?= =?utf-8?B?M0hYNW1IcStWdVYyQW5oc0MrcHdaekNPWGdaTTRqZlV3OEtNSVhzeG40bFBi?= =?utf-8?B?eUQyMXFJWVc3WnFpOUVvZ1p2cTNPcW5kMVRHbWlTL3ZvcEdYcmptUldhQnlR?= =?utf-8?B?N1FwUTlhOXUxRXBHOHBmSjJFT3NKYmZ1cnNmTzdYSzQ1ZFhJNStqdHM0b0Rk?= =?utf-8?B?b1NzR3RreUM2SnpzSkpNSWMrRFJRRnlTLzRsaXZQalBuTys2bXI5REYrTmQr?= =?utf-8?B?Tk05TU95dmF3SzgzNkV0STI1UEsxR3kxZXlrdnJDUmpyRVE2SlhrOG9rM1Nw?= =?utf-8?B?QXVRa3F6TkJpUTh2YktEaEg3MDhFN3RvNFh2VlJLZ3UraWRFV2szSnpqU04w?= =?utf-8?B?KzRNTUlTWUpSVCt3djhxNU5ncjhMM3o5TjA1czRORnk0NHovc05WQ05DVmVw?= =?utf-8?B?QktBdnp2MmJNSFRUNEU0eG16OVFORytGYjFta0RIYks3KytFaTBtNmlmelJC?= =?utf-8?B?REpRTTNma2FGMHJVdUtGVU1Gb0VCMU40NTJCVm9yeFVGdTllNmRmVlU5dmNq?= =?utf-8?Q?oFxnaCtsKCRh/i77CoJY9/L21?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 694b8985-3b5d-47f0-33f2-08db14f5ca1b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 16:56:49.5255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4MnzZCvUcQrWVcllDjYUqWpBabSBg9+pR8gS0dUqEOm00V5gEwaxJhH0212QkT/MVeiU2hxqeU199266SN4Bog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9581 On 22.02.2023 17:20, Andrew Cooper wrote: > On 22/02/2023 4:17 pm, Jan Beulich wrote: >> On 22.02.2023 17:04, Andrew Cooper wrote: >>> While testing the rebuilt debian unstable container, I found: >>> >>> common/core_parking.c: In function 'core_parking_remove': >>> common/core_parking.c:230:53: error: array subscript 1 is above array >>> bounds of 'unsigned int[1]' [-Werror=array-bounds] >>>   230 |         core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >>>       |                                  ~~~~~~~~~~~~~~~~~~~^~~~~~~ >>> common/core_parking.c:31:21: note: while referencing 'core_parking_cpunum' >>>    31 | static unsigned int core_parking_cpunum[NR_CPUS] = {[0 ... >>> NR_CPUS-1] = -1}; >>>       |                     ^~~~~~~~~~~~~~~~~~~ >>> >>> >>> which is an legitimate complaint - this logic is simply broken with >>> NR_CPUS=1. >>> >>> In principle, I think the best fix is probably to have CORE_PARKING >>> depend on NR_CPUS > 1, except none of the interacting x86 code has been >>> written in a way that would be compatible. >>> >>> But it also occurs to me that this is the kind of thing an embedded x86 >>> usecase would want to compile.  Frankly, its niche even on regular x86 >>> use-cases. >>> >>> Except having looked at the code, it's a different to the other thing we >>> call core parking which is the smt=0 logic to keep the stacks valid for >>> cores/threads we don't want to use, because of #MC broadcast problems - >>> and this logic does need to stay. >>> >>> Thoughts? >> See "core-parking: fix build with gcc12 and NR_CPUS=1" sent back in September >> last year. > > I'd clearly missed that thread, but the final part seems to have agreed > on a NR_CPUS check, with you saying that you'd send a v2 "in a minute". And so I did: https://lists.xen.org/archives/html/xen-devel/2022-09/msg00906.html Jan From xen-devel-bounces@lists.xenproject.org Wed Feb 22 17:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 17:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499732.771005 (Exim 4.92) (envelope-from ) id 1pUtKE-0000qb-AQ; Wed, 22 Feb 2023 17:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499732.771005; Wed, 22 Feb 2023 17:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKE-0000qU-6U; Wed, 22 Feb 2023 17:54:42 +0000 Received: by outflank-mailman (input) for mailman id 499732; Wed, 22 Feb 2023 17:54:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKD-0000qN-6G for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 17:54:41 +0000 Received: from dog.birch.relay.mailchannels.net (dog.birch.relay.mailchannels.net [23.83.209.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f86537c4-b2d9-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 18:54:37 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 479017E13FE for ; Wed, 22 Feb 2023 17:54:35 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CF8667E1EFB for ; Wed, 22 Feb 2023 17:54:34 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.123.200.110 (trex/6.7.1); Wed, 22 Feb 2023 17:54:35 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4PMP1P4f8szQ7 for ; Wed, 22 Feb 2023 09:54:33 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e004a by kmjvbox (DragonFly Mail Agent v0.12); Wed, 22 Feb 2023 09:54:29 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f86537c4-b2d9-11ed-93b6-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1677088474; a=rsa-sha256; cv=none; b=A11yR1jR0VRK8sbWVZl8BEktB8QVm1bKuuOWsPW6PSpNrTXYvrsHLf2gypnkQhDdK0/4pp IKBeBNHYe0PkSvxS80QVdmc/1hutXoSPioUOtlnE/LDuqLqf/HGHa2wzD4cX9Q1y7v7vrS j5J6egdgdCvh8eoGBPFL1P1nNvnoxPejrofEgbRwEyxfGaSGDWH6ADO3i1O34iBp9KkA12 bXXhuv/QPme+Sm8LOOIJTfQnD6Ma/z3U24uEM39lUncz8+J11B3sXHGvqvhyDi9geJhxAH S21fHJuipZ+vJF2BzCXntZtp3z06BdXx1N1a0viXGCEEx9rbF7wGdsDQBJgy3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1677088474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=ukKEaiyitO8JgQ7lcfjsogM/CK+0CQFsiEgPLxhpECQ=; b=NKNRzIymtrfIHpsabE+/C5W1QFbnuFwVeE2R2++O91pwhHJiS6ETO1QFzmhMWRv1bgxDHY 1QkCtNbofpX3IB8egf48f4SkEpQd8uGnFnAj9vRHPzHnK8SBgSotqzjSrQdgyeWALpbB+I 9n1bshqR3CQHDjSALKHRKsSLOI5rtPGc2nIHGMxH2eINS+NVCwGhUKt0cuenPJ+v1q+oHR IKAntGwNTdla8+MUnf5oEUcwNtCJATyVOIGNVNQHmucz8kGaLvkDp7c6UMWk+nIWcOAVsb SciKS81rSnfvqKdqSXg9mw1FvmTjm1lIhuQOwDWo2gFtBzbh+MPHG/WNQ5Wf/g== ARC-Authentication-Results: i=1; rspamd-9788b98bc-v29wb; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Ski-Illegal: 4b00b3901d902351_1677088475102_3597865880 X-MC-Loop-Signature: 1677088475102:2949484615 X-MC-Ingress-Time: 1677088475102 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1677088474; bh=ukKEaiyitO8JgQ7lcfjsogM/CK+0CQFsiEgPLxhpECQ=; h=Date:From:To:Cc:Subject:Content-Type; b=n6aSC8JJj9p6YgxlzCV0CgwuEhiplwmIKbx7sibkesNgedAcbvsSKcH8YZSz4Hfys T0DUzGNn8bEMBkJlxII4tNAu/w1Ovc48CJ/3B+ZeuTcPANzCHDU9Myp/rZ4rzWZWlZ TWgPt3FEXYj3D7D1/IF1+zzG5p9LCWr2I1+a0hoE= Date: Wed, 22 Feb 2023 09:54:29 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next v2 0/2] x86/xen TSC related cleanups Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Enclosed please find a pair of patches that perform some additional cleanup that was suggested by Boris, Jan and Thomas. Specifically: this resync's arch/x86/include/asm/xen/cpuid.h from its upstream source in the Xen tree, and then uses one of the new #define-s to replace a constant in x86/xen/time.c that was previously only numerically defined. Pedantic code from v1 is dropped in favor of a more appropriate return statement. Changes from v1: - Coding style fixup in arch/x86/xen/time.c (Feedback from Thomas Gleixner) Krister Johansen (2): xen: update arch/x86/include/asm/xen/cpuid.h x86/xen/time: cleanup xen_tsc_safe_clocksource arch/x86/include/asm/xen/cpuid.h | 22 ++++++++++++++++++---- arch/x86/xen/time.c | 7 ++----- 2 files changed, 20 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 17:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 17:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499733.771016 (Exim 4.92) (envelope-from ) id 1pUtKP-00017q-Gr; Wed, 22 Feb 2023 17:54:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499733.771016; Wed, 22 Feb 2023 17:54:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKP-00017j-ED; Wed, 22 Feb 2023 17:54:53 +0000 Received: by outflank-mailman (input) for mailman id 499733; Wed, 22 Feb 2023 17:54:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKN-0000qN-Dp for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 17:54:51 +0000 Received: from beige.elm.relay.mailchannels.net (beige.elm.relay.mailchannels.net [23.83.212.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fef0b3c7-b2d9-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 18:54:49 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D3D513E109B for ; Wed, 22 Feb 2023 17:54:46 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 71AD63E16EA for ; Wed, 22 Feb 2023 17:54:46 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.179.67 (trex/6.7.1); Wed, 22 Feb 2023 17:54:46 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PMP1d5LMsz14t for ; Wed, 22 Feb 2023 09:54:45 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e004a by kmjvbox (DragonFly Mail Agent v0.12); Wed, 22 Feb 2023 09:54:42 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fef0b3c7-b2d9-11ed-93b6-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1677088486; a=rsa-sha256; cv=none; b=63+Wzl6aBa531tl++b0ez2kBBPnfvSmR1U3paRQGyxN98y0O6OP92cYBF2lR5ZZEZsUgan fB0zWbwPctZXpYaqJrenQutcV4/kpDkxk6uuUu50mmU91JN5YFLCPNfwMfq/jUxLi/mbS7 eoSv1QL4WS5EHUqTjCZ4/2BpZ/UR99OnIbNVAr6qWOYFSpwgf8Wu2YJAhTD2pUY281J0dp Xr05cSpGW3mFme/tmnPYZIjf4aYfC7fgn1WU++4Rl0Jrat0h4HfwhmCv6RDVwGXyEyYK8l XXVVVzgW5qL97/JY3XdYIcyAj4aS2kqF1ISOSUgKG4rxlqAiI7rng7xpxVl52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1677088486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPLOaJx1XC+xepUu7FtXLYzyt2YPI1cX/q7Jp4OSr1s=; b=skRg/mcrOyzGQm0FL1h7oKwMmwDebYA2MST4Egm8WShxvESPe1l4fTiOvcpnjYlWYAXVrH dXjIjk+R4Xo9meW81cAoVIkLi8iVvbiIuBqCso2zkU2RhuMKvx8HdT/GUtyXF5kAo+aI73 M6uuKWqON/mHF5PH59N9Ia1MHCj8DaAbm/QttXJi0XC6quHOr71LrN0dXd0e53yMTASGhW paHtyFqPB7sM63+wFP+CyBdzljyvwqwwk0+uig30e5kY7sVHzZyvTW6aL8lWaH9FTmmj+s 1KVJcgILAerjpfcX/f6AiLvjBcVEkXv6VjkrA1IA3rTTp5ccH0MnwlJQH67t9Q== ARC-Authentication-Results: i=1; rspamd-9788b98bc-5fcpp; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Macabre-Tart: 3a1cb88f046d65e9_1677088486703_666751592 X-MC-Loop-Signature: 1677088486703:994943487 X-MC-Ingress-Time: 1677088486702 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1677088485; bh=jPLOaJx1XC+xepUu7FtXLYzyt2YPI1cX/q7Jp4OSr1s=; h=Date:From:To:Cc:Subject:Content-Type; b=qdobVzsjR9zv6DZs/ZU+JlQIvIMABZGLWOYbRVtroNjbc4+MwJguWEWeMnrF0Cp+n gyLo1jZQeSTRi5y6uDlBdZ1ToVqbbFNaMxVqgSWzePjP0AK2N+YAgj/UzF5mEFIvTo DPXCiUhTXg4XfeSPA2n2I53qi0o3iQTxErDZ2PEU= Date: Wed, 22 Feb 2023 09:54:42 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next v2 1/2] xen: update arch/x86/include/asm/xen/cpuid.h Message-ID: <94b9046dd0db3794f0633d134b7108508957758d.1677038165.git.kjlx@templeofstupid.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Update arch/x86/include/asm/xen/cpuid.h from the Xen tree to get newest definitions. This picks up some TSC mode definitions and comment formatting changes. Signed-off-by: Krister Johansen --- arch/x86/include/asm/xen/cpuid.h | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 6daa9b0c8d11..a3c29b1496c8 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -89,11 +89,21 @@ * Sub-leaf 2: EAX: host tsc frequency in kHz */ +#define XEN_CPUID_TSC_EMULATED (1u << 0) +#define XEN_CPUID_HOST_TSC_RELIABLE (1u << 1) +#define XEN_CPUID_RDTSCP_INSTR_AVAIL (1u << 2) + +#define XEN_CPUID_TSC_MODE_DEFAULT (0) +#define XEN_CPUID_TSC_MODE_ALWAYS_EMULATE (1u) +#define XEN_CPUID_TSC_MODE_NEVER_EMULATE (2u) +#define XEN_CPUID_TSC_MODE_PVRDTSCP (3u) + /* * Leaf 5 (0x40000x04) * HVM-specific features * Sub-leaf 0: EAX: Features * Sub-leaf 0: EBX: vcpu id (iff EAX has XEN_HVM_CPUID_VCPU_ID_PRESENT flag) + * Sub-leaf 0: ECX: domain id (iff EAX has XEN_HVM_CPUID_DOMID_PRESENT flag) */ #define XEN_HVM_CPUID_APIC_ACCESS_VIRT (1u << 0) /* Virtualized APIC registers */ #define XEN_HVM_CPUID_X2APIC_VIRT (1u << 1) /* Virtualized x2APIC accesses */ @@ -102,12 +112,16 @@ #define XEN_HVM_CPUID_VCPU_ID_PRESENT (1u << 3) /* vcpu id is present in EBX */ #define XEN_HVM_CPUID_DOMID_PRESENT (1u << 4) /* domid is present in ECX */ /* - * Bits 55:49 from the IO-APIC RTE and bits 11:5 from the MSI address can be - * used to store high bits for the Destination ID. This expands the Destination - * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. + * With interrupt format set to 0 (non-remappable) bits 55:49 from the + * IO-APIC RTE and bits 11:5 from the MSI address can be used to store + * high bits for the Destination ID. This expands the Destination ID + * field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) -/* Per-vCPU event channel upcalls */ +/* + * Per-vCPU event channel upcalls work correctly with physical IRQs + * bound to event channels. + */ #define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 17:55:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 17:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499736.771026 (Exim 4.92) (envelope-from ) id 1pUtKf-0001X8-P9; Wed, 22 Feb 2023 17:55:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499736.771026; Wed, 22 Feb 2023 17:55:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKf-0001X1-MT; Wed, 22 Feb 2023 17:55:09 +0000 Received: by outflank-mailman (input) for mailman id 499736; Wed, 22 Feb 2023 17:55:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtKe-0000qN-O5 for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 17:55:08 +0000 Received: from bee.yew.relay.mailchannels.net (bee.yew.relay.mailchannels.net [23.83.220.14]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08a50463-b2da-11ed-93b6-47a8fe42b414; Wed, 22 Feb 2023 18:55:06 +0100 (CET) Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0C7123C0F14 for ; Wed, 22 Feb 2023 17:55:03 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 9C5503C121C for ; Wed, 22 Feb 2023 17:55:02 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.196.241 (trex/6.7.1); Wed, 22 Feb 2023 17:55:02 +0000 Received: from kmjvbox (c-76-102-200-71.hsd1.ca.comcast.net [76.102.200.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4PMP1x3PjLz16n for ; Wed, 22 Feb 2023 09:55:00 -0800 (PST) Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e004a by kmjvbox (DragonFly Mail Agent v0.12); Wed, 22 Feb 2023 09:54:56 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08a50463-b2da-11ed-93b6-47a8fe42b414 X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1677088502; a=rsa-sha256; cv=none; b=8Zs+e79PUTur1pKIYqSseh/3YYpctXHHUG3GycmJb7iEdHZwh3xiQDMtSw3iwF/ElWC1jO ommpNiCmt8bdjc7iNnX2CTPHMLCAbdi+LYaKSIxBMDe5HkXDzumqkVrAPXlcv5onCo1Fzf f8LDvD2nu498InMVOz/Z6qo1sTBiDkpazfoI2YHajI+mGWi78Fe5zrwzNIcUOIYdPrZTIY a3cBj+wZwi8xYxHjL8cvLGxwzj0g0Na20M8Ui32qu9qvz329/CZYo3j3CBaqGoTXav3gPc OhL+H6VrfvTq1W9uYyWLriSjXYDEmSyqpTt3h/hELvjchL4kI/KAyyk6nEY1wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1677088502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SFO62oAKLgPH71Y0Xq/5Q3j7DH6Nq6RDi9wLwjcluGc=; b=h8mVkyZHbUBEALiaIWjXcFZz/KPRxjmuORzreG3ZSTkVSFqX5ixXfASZAtdAy38jhyMvge 3hQqSabRrsfriX5TbsJiSpfAPdpWqCDVvCt4oQqYxintaQL31SdENyaZ2Z/+ge9mx4Bt+X vJ4gDwlb8X6P/P73dYWnWkSmxESDD4bFalo5+TL3t7qEXjw7WJukQKK0YEv1T00eK5gIxd e+FZbjPTUJzycm94qkwU99gXBlMB4eGtFkWLcalDZDGu2nZAXstKR80EF5j/c1Xp5jV3i7 RRicXhz2UReH2NlM7OqBO5gmIKcXWDUKLrxFzGC/ZRGW2SkvMOxgMzoz2VURZQ== ARC-Authentication-Results: i=1; rspamd-9788b98bc-pxv92; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Society-Bored: 028f1e1360e580b5_1677088502885_2835282340 X-MC-Loop-Signature: 1677088502885:1762775582 X-MC-Ingress-Time: 1677088502884 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1677088501; bh=SFO62oAKLgPH71Y0Xq/5Q3j7DH6Nq6RDi9wLwjcluGc=; h=Date:From:To:Cc:Subject:Content-Type; b=vTqKdTqV3fyyocP+64zXlj1tzc67az1mF0QlGIVA7FWxEvS4mSVL+7fk4t/2Fcwtf 2pU84jGzaNFXWp/Bzge0J21sWy4OU5ap/jKeZcu17zdwPCeVivDtpNouR+3TN6D9Wu Du4Fbz0DE1/+XUB7IPgSTi+etkSammTUibilmSYw= Date: Wed, 22 Feb 2023 09:54:56 -0800 From: Krister Johansen To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Subject: [PATCH linux-next v2 2/2] x86/xen/time: cleanup xen_tsc_safe_clocksource Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Modifies xen_tsc_safe_clocksource() to use newly defined constants from arch/x86/include/asm/xen/cpuid.h. This replaces a numeric value with XEN_CPUID_TSC_MODE_NEVER_EMULATE, and deletes a comment that is now self explanatory. There should be no change in the function's behavior. Signed-off-by: Krister Johansen --- arch/x86/xen/time.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c index 95140609c8a8..94056013a2a4 100644 --- a/arch/x86/xen/time.c +++ b/arch/x86/xen/time.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include @@ -495,11 +496,7 @@ static int __init xen_tsc_safe_clocksource(void) /* Leaf 4, sub-leaf 0 (0x40000x03) */ cpuid_count(xen_cpuid_base() + 3, 0, &eax, &ebx, &ecx, &edx); - /* tsc_mode = no_emulate (2) */ - if (ebx != 2) - return 0; - - return 1; + return ebx == XEN_CPUID_TSC_MODE_NEVER_EMULATE; } static void __init xen_time_init(void) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Feb 22 18:07:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 18:07:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499757.771038 (Exim 4.92) (envelope-from ) id 1pUtWn-0003qN-S9; Wed, 22 Feb 2023 18:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499757.771038; Wed, 22 Feb 2023 18:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtWn-0003qG-PV; Wed, 22 Feb 2023 18:07:41 +0000 Received: by outflank-mailman (input) for mailman id 499757; Wed, 22 Feb 2023 18:07:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtWm-0003q5-Lr; Wed, 22 Feb 2023 18:07:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtWm-0001pJ-KA; Wed, 22 Feb 2023 18:07:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUtWm-0005Eh-92; Wed, 22 Feb 2023 18:07:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUtWm-0003R8-8W; Wed, 22 Feb 2023 18:07:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9y3kWd7lh9iggTkKdXs84wvnrRAhWi0YZIjYQAKPvXI=; b=dNzh6UKlewbQr3fCvV/iipkIH3 ngDe/PVhQ91EZmlCPGQILv07tIej82EZQ4RgVMjRoMAElxcKgW+9txzOjFHedteY639tHPOnycL7k lf/GwZdRMFqD2AIpgCWiu+u8QBsg4aIY33Gkzj3XxGBlxbVGRMCghT3o+f0IEaT1pHMg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178146: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c15e2d4c1c93d3d1744501b7f938db4ca23ee5e1 X-Osstest-Versions-That: xen=40c12ba546729fdcc8b6731f675806dc268a5745 From: osstest service owner Date: Wed, 22 Feb 2023 18:07:40 +0000 flight 178146 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178146/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c15e2d4c1c93d3d1744501b7f938db4ca23ee5e1 baseline version: xen 40c12ba546729fdcc8b6731f675806dc268a5745 Last test of basis 178129 2023-02-22 13:00:29 Z 0 days Testing same since 178146 2023-02-22 16:04:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 40c12ba546..c15e2d4c1c c15e2d4c1c93d3d1744501b7f938db4ca23ee5e1 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Feb 22 19:01:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 19:01:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499765.771049 (Exim 4.92) (envelope-from ) id 1pUuMz-00036c-Tw; Wed, 22 Feb 2023 19:01:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499765.771049; Wed, 22 Feb 2023 19:01:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuMz-00036V-Qx; Wed, 22 Feb 2023 19:01:37 +0000 Received: by outflank-mailman (input) for mailman id 499765; Wed, 22 Feb 2023 19:01:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuMy-00036L-CI; Wed, 22 Feb 2023 19:01:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuMy-00035F-95; Wed, 22 Feb 2023 19:01:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuMy-0007yT-33; Wed, 22 Feb 2023 19:01:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUuMy-0002dj-2a; Wed, 22 Feb 2023 19:01:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HjY6vpzPg0u9II22gQTGEA6mgIW/m3KS7ChXKKLETns=; b=5xa01nBHV6kDqaT2dp22O4md6l 0Wg7YcnJLgJpiM4DpMQjb0LL8Wpy6xeLykuDLfv+6XmB2SiCpwip1b+HnUv8dXkZlb6yT22p84tOE 14MZ07ETvA+Wjmh/Xe4P6iVdPnRVkt5yhk2814YI0EZZx7qj1XBx5PeFFcAkG+D1tS2U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178107: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine-bios:memdisk-try-append:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd X-Osstest-Versions-That: xen=c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd From: osstest service owner Date: Wed, 22 Feb 2023 19:01:36 +0000 flight 178107 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-examine-bios 4 memdisk-try-append fail blocked in 178070 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178070 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178070 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178070 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178070 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178070 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178070 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178070 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178070 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178070 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd baseline version: xen c76e4ff7d531ee2bf37c9d4037c8645f9e586fcd Last test of basis 178107 2023-02-22 08:17:28 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Feb 22 19:14:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 22 Feb 2023 19:14:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499775.771060 (Exim 4.92) (envelope-from ) id 1pUuZa-0004xK-46; Wed, 22 Feb 2023 19:14:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499775.771060; Wed, 22 Feb 2023 19:14:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuZa-0004xD-0X; Wed, 22 Feb 2023 19:14:38 +0000 Received: by outflank-mailman (input) for mailman id 499775; Wed, 22 Feb 2023 19:14:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUuZY-0004x7-7j for xen-devel@lists.xenproject.org; Wed, 22 Feb 2023 19:14:36 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21e8fc3e-b2e5-11ed-a829-c9ca1d2f71af; Wed, 22 Feb 2023 20:14:34 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0CE9B5C00D6; Wed, 22 Feb 2023 14:14:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 22 Feb 2023 14:14:30 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Feb 2023 14:14:29 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21e8fc3e-b2e5-11ed-a829-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm1; t=1677093270; x= 1677179670; bh=Jfwfo/kKVXF2Dky7lxFz/j0xQqdCdFBEYU86C864xco=; b=i t7D4rPoCB9M+x+2Y5Na6LuwAdse2K0mNiYpv+FoexrSOytUxkJWLCkOqqvNqnOrf jONLfwBfJjMG/izjFQn19ON6tplVJkxe5LOftr8iIO1E+cwnlWlatqTp7abC9dPn 6QHmVM/qjyMwo2uSdp4U3JBVAOJ2Z/nOZkMmwHMSjpJJQwE/mBp5nwgEPbIsv61d VLF8rX0ZsZ3ugC329hYP5pt7Qqo35vRlUUlrZfrpFIbYcUGrnskRZmYDQ746siM4 61qeldlfRCLToz5CuQTxsgYMsLnu4mp7aFv6i3ijTL2KsQA5rJlGJH95wIo5fsXb zIcE1Q87GQjIUIeK6AxbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1677093270; x=1677179670; bh=Jfwfo/kKVXF2Dky7lxFz/j0xQqdCdFBEYU8 6C864xco=; b=XUUQ7nmhSxeboDxoGKhcQbeSbKYluyhXerCbnyKDDPvnxUutVpp Ta2kep/srKyS+hKg1WcS/oWobt3G67zE5mpk/uQMUp+VwlDKjUAfx0Wn7DXpNrhT k8fFFtS+ihhUsoi+KRBIQ9IhMXlCRAz5XVelXJ+SN3zAOPJh/3hAAmR6z9/1xi5p VP7zNQyrKYFZEnXUAK7OWS/v1IYML5p7S9bwlT0chQtkEPAktl9HcYGIjf9r5kQG Mf3IQVPzFDTYTTqo4rBfj9iZq3W0EgcIaN0QYQhd62qskir19DzsyVEPhpdX8E/k RvxlYplgj4QXMl6rD9rmAwZOshjC4nQ7Qxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejledguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [PATCH] Call SetVirtualAddressMap() by default Date: Wed, 22 Feb 2023 14:14:23 -0500 Message-Id: <9a0e5021a612951c4174c45099edc8a4fb5bd3bb.1677091168.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To quote Andrew Cooper: > I know we've had this argument before, but not calling > SetVirtualAddressMap() isn't a viable option. It's a prerequisite to > function on literally millions of devices Qubes OS has been shipping EFI_SET_VIRTUAL_ADDRESS_MAP for years, and I believe OpenXT and EVE ship it as well. Mark EFI_SET_VIRTUAL_ADDRESS_MAP as SUPPORTED and enable it by default. Signed-off-by: Demi Marie Obenour --- What is necessary for this patch to be accepted? xen/common/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8ebdc1e9d0968b9de007f4df44bac79..5b8edb6d81a1296969f968702c5e7f2c775ceba9 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -215,14 +215,15 @@ config KEXEC If unsure, say Y. config EFI_SET_VIRTUAL_ADDRESS_MAP - bool "EFI: call SetVirtualAddressMap()" if EXPERT + bool "EFI: call SetVirtualAddressMap()" + default y ---help--- Call EFI SetVirtualAddressMap() runtime service to setup memory map for further runtime services. According to UEFI spec, it isn't strictly necessary, but many UEFI implementations misbehave when this call is missing. - If unsure, say N. + If unsure, say Y. config XENOPROF def_bool y -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Thu Feb 23 00:31:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 00:31:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499812.771087 (Exim 4.92) (envelope-from ) id 1pUzVM-0003hm-9z; Thu, 23 Feb 2023 00:30:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499812.771087; Thu, 23 Feb 2023 00:30:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzVM-0003hf-5t; Thu, 23 Feb 2023 00:30:36 +0000 Received: by outflank-mailman (input) for mailman id 499812; Thu, 23 Feb 2023 00:30:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzVL-0003hV-HX; Thu, 23 Feb 2023 00:30:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzVL-0003Sk-Db; Thu, 23 Feb 2023 00:30:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzVL-0003Ln-1o; Thu, 23 Feb 2023 00:30:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUzVL-00007Y-1G; Thu, 23 Feb 2023 00:30:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IEv7ZPbtKTTdAKzE99LKV7xkAdr5e0O/5rqiaA2Y2kA=; b=O8H1qP4OnSmoLnH4Ko8cbYcy7/ /Ect0b9d8UsBxxMeU/84oGR3hbCWbKJkuRQomnpvCFGQZES1wYWZVFJZmpLrXJ4ZlKxqhcMCJp2nK HPBpSGE/OQKOdXpEN2L+oiaredlmJOZfQHFMFfJJdAr4e/OYwHfPDW+zKSjEH7c69j18=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 178125: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=64121e2adf7d6fe2e684eec09ec9b9986d951d42 X-Osstest-Versions-That: linux=59342376e8f0c704299dc7a2c14fed07ffb962e2 From: osstest service owner Date: Thu, 23 Feb 2023 00:30:35 +0000 flight 178125 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/178125/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 176460 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 176722 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 176810 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 176810 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 176810 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 176810 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 176810 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 176810 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 176810 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 176810 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 176810 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 64121e2adf7d6fe2e684eec09ec9b9986d951d42 baseline version: linux 59342376e8f0c704299dc7a2c14fed07ffb962e2 Last test of basis 176810 2023-02-10 03:27:19 Z 12 days Testing same since 178125 2023-02-22 12:17:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Thompson Al Viro Alan Stern Alexander Egorenkov Alexander Potapenko Alexei Starovoitov Alexey Khoroshilov Amit Engel Anand Jain Andrea Righi Andreas Kemnade Andreas Schwab Andrei Gherzan Andrew Morton Andrey Konovalov Andy Shevchenko Anirudh Venkataramanan Anton Gusev Ard Biesheuvel Arnd Bergmann Artemii Karasev Bart Van Assche Bo Liu Brian Foster Bryan O'Donoghue Chandan Babu R Chandan Kumar Rout (A Contingent Worker at Intel) Chao Yu Charles Keepax Chris Healy Christian Hopps Christoph Hellwig Cristian Ciocaltea Damien Le Moal Dan Carpenter Daniel Borkmann Darrick J. Wong Darrick J. Wong Dave Chinner David Hildenbrand David S. Miller David Sterba Dean Luick Dennis Dalessandro Dennis Wassenberg Devid Antonio Filoni Ding Hui Dmitry Perchanov Dmitry Torokhov Dongliang Mu Dragos Tatulea Eduard Zingerman Eelco Chaudron Fedor Pchelkin Felix Riemann Florian Fainelli Florian Westphal FUKAUMI Naoki George Kennedy Gilles BULOZ Greg Kroah-Hartman Guenter Roeck Guillaume Nault Guo Ren Guo Ren Gurucharan G (A Contingent worker at Intel) Gwendal Grignou Hangbin Liu Hannes Reinecke Harshit Mogalapalli Heiko Carstens Heiner Kallweit Helge Deller Herbert Xu Hulk Robot Hyunwoo Kim Ido Schimmel Ilpo Järvinen Ilya Dryomov Ingo Molnar Jaegeuk Kim Jakub Andrysiak Jakub Kicinski Jason Xing Jay Vosburgh Jeff Moyer Jernej Skrabec Jerome Brunet Jim Minter Joel Stanley Joerg Roedel Johannes Zink Jon Hunter Jonathan Cameron Josef Bacik Kailang Yang Kajol Jain Kalle Valo Kees Cook Kuniyuki Iwashima Leon Romanovsky Linus Torvalds Linus Walleij Linux Kernel Functional Testing Longlong Xia Luiz Capitulino Marc Kleine-Budde Marcin Szycik Marius Dinu Mark Brown Mark Pearson Martin Blumenstingl Martin K. Petersen Martin Wilck Maurizio Lombardi Maxim Korotkov Mengchi Cheng Michael Chan Michael Ellerman Michael S. Tsirkin Michael Walle Mika Westerberg Mike Christie Mike Kravetz Mike Rapoport (IBM) Miko Larsson Minsuk Kang Miroslav Zatko Muchun Song Munehisa Kamata Naresh Kamboju Natalia Petrova Neel Patel Neil Armstrong Oleksij Rempel Olivier Moysan Pablo Neira Ayuso Palmer Dabbelt Paolo Abeni Paolo Bonzini Parav Pandit Peter Suti Peter Ujfalusi Peter Xu Peter Zijlstra Phillip Lougher Pierluigi Passaro Pierre-Louis Bossart Pietro Borrello Prashant Malani Qi Zheng Qingfang DENG Rafał Miłecki Randy Dunlap Ryusuke Konishi Samuel Thibault Sasha Levin Seth Jenkins Shannon Nelson Shaoying Xu Shawn Guo Shiju Jose Shuah Khan Shunsuke Mie Srinivas Kandagatla Steffen Klassert Steven Rostedt (Google) Sudip Mukherjee Suren Baghdasaryan Takashi Iwai Takashi Sakamoto Toke Høiland-Jørgensen Tom Murphy Tony Nguyen Trond Myklebust Udipto Goswami Ulf Hansson Vasily Gorbik Vyacheslav Bocharov Werner Sembach Wesley Cheng Wolfram Sang Xin Long Xingyuan Mo Xiongfeng Wang Xiubo Li Xu Yilun Yang Yingliang Yuan Can Zhang Xiaoxu Zheng Yongjun Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 59342376e8f0..64121e2adf7d 64121e2adf7d6fe2e684eec09ec9b9986d951d42 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 00:40:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 00:40:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499822.771098 (Exim 4.92) (envelope-from ) id 1pUzf2-0005Wf-Cp; Thu, 23 Feb 2023 00:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499822.771098; Thu, 23 Feb 2023 00:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzf2-0005WY-AA; Thu, 23 Feb 2023 00:40:36 +0000 Received: by outflank-mailman (input) for mailman id 499822; Thu, 23 Feb 2023 00:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzf1-0005WO-Ok; Thu, 23 Feb 2023 00:40:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzf1-0003mZ-GZ; Thu, 23 Feb 2023 00:40:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pUzf1-00045D-4P; Thu, 23 Feb 2023 00:40:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pUzf1-0005eP-40; Thu, 23 Feb 2023 00:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WDyPmGxdhoPZ6rGTtzOgtQCl8grYueXW5jnUJBk1FHs=; b=FZ4XlBWAcIksq9NMQrgJzKHQbq WmBtjVfrV/qGxuCMuevGQiGn58QnNex/5afOulC5y4/KfWdy8Y+Wk/vOZtogkLcztlM5F2WVUQt+L lWR8mvgOGipTzob0JLL5+d+7K2VWYw74TKRYw7NPz+AXBN3G4o811ZyEjU9mFWd6SpKM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 178136: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64::broken:regression xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:host-install(5):broken:regression xen-4.14-testing:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-localmigrate/x10:fail:regression xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.14-testing:build-armhf:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c267abfaf2d8176371eda037f9b9152458e0656d X-Osstest-Versions-That: xen=46040a5fe68831530b8ffdea7d264e52ae316c87 From: osstest service owner Date: Thu, 23 Feb 2023 00:40:35 +0000 flight 178136 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178136/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 broken test-amd64-amd64-xl-qemuu-win7-amd64 5 host-install(5) broken REGR. vs. 174677 test-amd64-amd64-xl-qemut-debianhvm-amd64 18 guest-localmigrate/x10 fail REGR. vs. 174677 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174677 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a version targeted for testing: xen c267abfaf2d8176371eda037f9b9152458e0656d baseline version: xen 46040a5fe68831530b8ffdea7d264e52ae316c87 Last test of basis 174677 2022-11-08 18:07:02 Z 106 days Testing same since 178136 2023-02-22 14:37:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 broken test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-win7-amd64 broken broken-step test-amd64-amd64-xl-qemuu-win7-amd64 host-install(5) Not pushing. ------------------------------------------------------------ commit c267abfaf2d8176371eda037f9b9152458e0656d Author: Anthony PERARD Date: Tue Feb 21 16:55:38 2023 +0000 automation: Remove clang-8 from Debian unstable container First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper (cherry picked from commit a6b1e2b80fe2053b1c9c9843fb086a668513ea36) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 23 03:18:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 03:18:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499838.771110 (Exim 4.92) (envelope-from ) id 1pV27p-0005ti-T6; Thu, 23 Feb 2023 03:18:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499838.771110; Thu, 23 Feb 2023 03:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV27p-0005tb-QI; Thu, 23 Feb 2023 03:18:29 +0000 Received: by outflank-mailman (input) for mailman id 499838; Thu, 23 Feb 2023 03:18:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV27n-0005tR-WA; Thu, 23 Feb 2023 03:18:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV27n-00064X-UG; Thu, 23 Feb 2023 03:18:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV27n-000524-L1; Thu, 23 Feb 2023 03:18:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pV27n-0008Ut-KK; Thu, 23 Feb 2023 03:18:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u2cRbIPJIsLwF4ZeFyZgi8LjGkCjzAlEwhzEBG/y86g=; b=X1+w+/n0n0warDxYe2YSf2Jycn /7ftx3RPZlE5N7jZTmO5OO8RJBR4mrZKVHgEdnDbqI3PpHXEJJNmYSKQtpim9gWFogXZsFCra8yIs OD9qFWDX41k6HL/225ZHNuD3Ns+Q6SP+UBLmIoPHUE1jqqjf5aKrlmUS3URK/HPru+LU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 178138: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-4.16-testing:build-arm64-pvops:kernel-build:fail:regression xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=0802504627453a54b1ab408b6e9dc8b5c561172d X-Osstest-Versions-That: xen=d4e286db89d80c862b4a24bf971dd71008c8b53e From: osstest service owner Date: Thu, 23 Feb 2023 03:18:27 +0000 flight 178138 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178138/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 177405 build-arm64-pvops 6 kernel-build fail REGR. vs. 177405 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 177405 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177405 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 0802504627453a54b1ab408b6e9dc8b5c561172d baseline version: xen d4e286db89d80c862b4a24bf971dd71008c8b53e Last test of basis 177405 2023-02-15 16:37:16 Z 7 days Testing same since 178138 2023-02-22 14:37:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0802504627453a54b1ab408b6e9dc8b5c561172d Author: Anthony PERARD Date: Tue Feb 21 16:55:38 2023 +0000 automation: Remove clang-8 from Debian unstable container First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper (cherry picked from commit a6b1e2b80fe2053b1c9c9843fb086a668513ea36) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 23 04:34:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 04:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499850.771128 (Exim 4.92) (envelope-from ) id 1pV3JI-0007wr-Kf; Thu, 23 Feb 2023 04:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499850.771128; Thu, 23 Feb 2023 04:34:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV3JI-0007wj-HM; Thu, 23 Feb 2023 04:34:24 +0000 Received: by outflank-mailman (input) for mailman id 499850; Thu, 23 Feb 2023 04:34:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV3JI-0007wa-7P; Thu, 23 Feb 2023 04:34:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV3JI-0007ye-5o; Thu, 23 Feb 2023 04:34:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV3JH-0001Px-UR; Thu, 23 Feb 2023 04:34:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pV3JH-0007W8-U1; Thu, 23 Feb 2023 04:34:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aWwh3K0d2G05y2fKr6eQPGRIGB2c45UP77mXINmHcyo=; b=Rb9z0g3JkoldDyyuVmeLpM60EX i66zM7dkHQb8PgkZr4uitHE7BcM0O3dckI+3LjM7c9W6E8zJl8bNTbS15K48xw7F27clIa8zdmBQ1 qRFm9IC4/mEt5O+4qNaXqkGVJBxsSOMQIc4Pm8zp4+qVSlKJ/9EgrvxFt0HkmBodWYyY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 178137: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.15-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=fa875574b73618daf3bc70e6ff4d342493fa11d9 X-Osstest-Versions-That: xen=a056387c532ce6e36a0fec60788d5a5b68f978be From: osstest service owner Date: Thu, 23 Feb 2023 04:34:23 +0000 flight 178137 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178137/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174778 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174778 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174778 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174778 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174778 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174778 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174778 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174778 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174778 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen fa875574b73618daf3bc70e6ff4d342493fa11d9 baseline version: xen a056387c532ce6e36a0fec60788d5a5b68f978be Last test of basis 174778 2022-11-15 08:06:47 Z 99 days Testing same since 178137 2023-02-22 14:37:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a056387c53..fa875574b7 fa875574b73618daf3bc70e6ff4d342493fa11d9 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499863.771161 (Exim 4.92) (envelope-from ) id 1pV4MF-0000wd-2K; Thu, 23 Feb 2023 05:41:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499863.771161; Thu, 23 Feb 2023 05:41:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4ME-0000wW-Vq; Thu, 23 Feb 2023 05:41:30 +0000 Received: by outflank-mailman (input) for mailman id 499863; Thu, 23 Feb 2023 05:41:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4ME-0000Ql-00 for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:30 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b7723ca6-b33c-11ed-a82a-c9ca1d2f71af; Thu, 23 Feb 2023 06:41:27 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 094831FB; Wed, 22 Feb 2023 21:42:10 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 145923F587; Wed, 22 Feb 2023 21:41:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7723ca6-b33c-11ed-a82a-c9ca1d2f71af From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 2/8] xen/arm: re-define a set of data structures for static shared memory region Date: Thu, 23 Feb 2023 13:40:59 +0800 Message-Id: <20230223054105.2357217-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit introduces a set of separate data structures to deal with static shared memory at different stages. In boot-time host device tree parsing, we introduce a new structure "struct shm_node" and a new field "shm_info" in bootinfo to describe and store parsed shm info. only SHMID and "nr_borrowers", which describes the number of borrower domain, are considered here for per shm node. We also introduce a new local global data "shm_data" in bootfdt.c, in which, reserved memory bank is recorded together with shm node, to assist doing shm node verification. In order to apply above changes in acquire_nr_borrower_domain, we now use SHMID to iterate "shminfo" to find requested shm node, then acquiring the information of "nr_borrowers". In the last, a new anonymized structure "shminfo", which is a array of compound structure that contains SHMID and a "struct membank membank" describing shared memory regions in guest address space, is created in "kinfo" when dealing with domain information. Signed-off-by: Penny Zheng --- v1 -> v2: - As the original "struct shm_membank" was making reserving memory more complex and actually memory information could be still got from host Device\ Tree when dealing with domain construction, we introduce a new simple structure "struct shm_node" in bootinfo to only store SHMID and "nr_borrowers" - Further restrict the scope of the local variable "struct meminfo *mem = &bootinfo.reserved_mem" - Introduce a new local global data "shm_data" in bootfdt.c. In which, reserved memory bank is recorded together with the shm node, to assist doing shm node verification. - Define a set of local variables that point to "shm_data.shm_nodes[i].membank->start", etc, to make the code more readable. - Use SHMID to iterate "shminfo" to find requested shm node, as we no longer store host memory bank info in shm node. - A new anonymized structure, which is a array of compound structure that contains SHMID and a "struct membank membank", describing shared memory region in guest, is introduced in "kinfo". --- xen/arch/arm/bootfdt.c | 61 ++++++++++++++++++------- xen/arch/arm/domain_build.c | 74 +++++++++++++++---------------- xen/arch/arm/include/asm/kernel.h | 9 +++- xen/arch/arm/include/asm/setup.h | 21 +++++++-- 4 files changed, 106 insertions(+), 59 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0085c28d74..dc32d1b9b3 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -16,6 +16,16 @@ #include #include +#ifdef CONFIG_STATIC_SHM +static __initdata struct { + unsigned int nr_nodes; + struct { + const struct shm_node *node; + const struct membank *membank; + } shm_nodes[NR_MEM_BANKS]; +} shm_data; +#endif + static bool __init device_tree_node_matches(const void *fdt, int node, const char *match) { @@ -380,7 +390,6 @@ static int __init process_shm_node(const void *fdt, int node, const struct fdt_property *prop, *prop_id, *prop_role; const __be32 *cell; paddr_t paddr, gaddr, size; - struct meminfo *mem = &bootinfo.reserved_mem; unsigned int i; int len; bool owner = false; @@ -452,17 +461,21 @@ static int __init process_shm_node(const void *fdt, int node, return -EINVAL; } - for ( i = 0; i < mem->nr_banks; i++ ) + for ( i = 0; i < shm_data.nr_nodes; i++ ) { + paddr_t bank_start = shm_data.shm_nodes[i].membank->start; + paddr_t bank_size = shm_data.shm_nodes[i].membank->size; + const char *bank_id = shm_data.shm_nodes[i].node->shm_id; + /* * Meet the following check: * 1) The shm ID matches and the region exactly match * 2) The shm ID doesn't match and the region doesn't overlap * with an existing one */ - if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + if ( paddr == bank_start && size == bank_size ) { - if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + if ( strncmp(shm_id, bank_id, MAX_SHM_ID_LENGTH) == 0 ) break; else { @@ -474,17 +487,17 @@ static int __init process_shm_node(const void *fdt, int node, else { paddr_t end = paddr + size; - paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + paddr_t bank_end = bank_start + bank_size; - if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + if ( (end <= paddr) || (bank_end <= bank_start) ) { printk("fdt: static shared memory region %s overflow\n", shm_id); return -EINVAL; } - if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + if ( (end <= bank_start) || (paddr >= bank_end) ) { - if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + if ( strcmp(shm_id, bank_id) != 0 ) continue; else { @@ -496,22 +509,38 @@ static int __init process_shm_node(const void *fdt, int node, else { printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", - mem->bank[i].start, bank_end); + bank_start, bank_end); return -EINVAL; } } } - if ( i == mem->nr_banks ) + if ( (i == shm_data.nr_nodes) && (i == bootinfo.shminfo.nr_nodes) ) { - if ( i < NR_MEM_BANKS ) + struct meminfo *mem = &bootinfo.reserved_mem; + + if ( (i < NR_MEM_BANKS) && (mem->nr_banks < NR_MEM_BANKS) ) { /* Static shared memory shall be reserved from any other use. */ - safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); - mem->bank[mem->nr_banks].start = paddr; - mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].type = MEMBANK_STATIC_DOMAIN; + struct membank *membank = &mem->bank[mem->nr_banks]; + struct shm_node *shm_node = &bootinfo.shminfo.node[i]; + + membank->start = paddr; + membank->size = size; + membank->type = MEMBANK_STATIC_DOMAIN; mem->nr_banks++; + + /* Record static shared memory node info in bootinfo.shminfo */ + safe_strcpy(shm_node->shm_id, shm_id); + bootinfo.shminfo.nr_nodes++; + + /* + * Reserved memory bank is recorded together with shm + * node info in shm_data, to assist doing shm node verification. + */ + shm_data.shm_nodes[i].node = shm_node; + shm_data.shm_nodes[i].membank = membank; + shm_data.nr_nodes++; } else { @@ -524,7 +553,7 @@ static int __init process_shm_node(const void *fdt, int node, * to calculate the reference count. */ if ( !owner ) - mem->bank[i].nr_shm_borrowers++; + bootinfo.shminfo.node[i].nr_shm_borrowers++; return 0; } diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 4a6f743f35..2daf36cdbd 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -752,28 +752,25 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM -static int __init acquire_nr_borrower_domain(struct domain *d, - paddr_t pbase, paddr_t psize, +static int __init acquire_nr_borrower_domain(const char *shm_id, unsigned long *nr_borrowers) { - unsigned int bank; + struct shm_node *shm_node; + unsigned int i; - /* Iterate reserved memory to find requested shm bank. */ - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + /* Iterate to find requested static shared memory node. */ + for ( i = 0; i < bootinfo.shminfo.nr_nodes; i++ ) { - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + shm_node = &bootinfo.shminfo.node[i]; - if ( (pbase == bank_start) && (psize == bank_size) ) - break; + if ( strcmp(shm_id, shm_node->shm_id) == 0 ) + { + *nr_borrowers = shm_node->nr_shm_borrowers; + return 0; + } } - if ( bank == bootinfo.reserved_mem.nr_banks ) - return -ENOENT; - - *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; - - return 0; + return -EINVAL; } /* @@ -837,7 +834,7 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, static int __init assign_shared_memory(struct domain *d, paddr_t pbase, paddr_t psize, - paddr_t gbase) + paddr_t gbase, const char *shm_id) { mfn_t smfn; int ret = 0; @@ -871,7 +868,7 @@ static int __init assign_shared_memory(struct domain *d, * Get the right amount of references per page, which is the number of * borrower domains. */ - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + ret = acquire_nr_borrower_domain(shm_id, &nr_borrowers); if ( ret ) return ret; @@ -907,13 +904,16 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, paddr_t start, paddr_t size, const char *shm_id) { - if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) + unsigned int nr_banks = kinfo->shminfo.nr_banks; + struct membank *membank = &kinfo->shminfo.bank[nr_banks].membank; + + if ( nr_banks >= NR_MEM_BANKS ) return -ENOMEM; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; - safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); - kinfo->shm_mem.nr_banks++; + membank->start = start; + membank->size = size; + safe_strcpy(kinfo->shminfo.bank[nr_banks].shm_id, shm_id); + kinfo->shminfo.nr_banks++; return 0; } @@ -997,7 +997,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * specified, so they should be assigned to dom_io. */ ret = assign_shared_memory(owner_dom_io ? dom_io : d, - pbase, psize, gbase); + pbase, psize, gbase, shm_id); if ( ret ) return ret; } @@ -1354,12 +1354,12 @@ static int __init make_memory_node(const struct domain *d, static int __init make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct kernel_info *kinfo) { unsigned int i = 0; int res = 0; - if ( mem->nr_banks == 0 ) + if ( kinfo->shminfo.nr_banks == 0 ) return -ENOENT; /* @@ -1369,10 +1369,10 @@ static int __init make_shm_memory_node(const struct domain *d, */ dt_dprintk("Create xen-shmem node\n"); - for ( ; i < mem->nr_banks; i++ ) + for ( ; i < kinfo->shminfo.nr_banks; i++ ) { - uint64_t start = mem->bank[i].start; - uint64_t size = mem->bank[i].size; + uint64_t start = kinfo->shminfo.bank[i].membank.start; + uint64_t size = kinfo->shminfo.bank[i].membank.size; /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ char buf[27]; const char compat[] = "xen,shared-memory-v1"; @@ -1381,7 +1381,7 @@ static int __init make_shm_memory_node(const struct domain *d, __be32 *cells; unsigned int len = (addrcells + sizecells) * sizeof(__be32); - snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, start); res = fdt_begin_node(fdt, buf); if ( res ) return res; @@ -1400,7 +1400,7 @@ static int __init make_shm_memory_node(const struct domain *d, dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", i, start, start + size); - res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + res = fdt_property_string(fdt, "xen,id", kinfo->shminfo.bank[i].shm_id); if ( res ) return res; @@ -1425,7 +1425,7 @@ static int __init make_shm_memory_node(const struct domain *d, static int __init make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct kernel_info *kinfo) { ASSERT_UNREACHABLE(); return -EOPNOTSUPP; @@ -1435,13 +1435,13 @@ static int __init make_shm_memory_node(const struct domain *d, static int __init make_resv_memory_node(const struct domain *d, void *fdt, int addrcells, int sizecells, - const struct meminfo *mem) + const struct kernel_info *kinfo) { int res = 0; /* Placeholder for reserved-memory\0 */ const char resvbuf[16] = "reserved-memory"; - if ( mem->nr_banks == 0 ) + if ( kinfo->shminfo.nr_banks == 0 ) /* No shared memory provided. */ return 0; @@ -1463,7 +1463,7 @@ static int __init make_resv_memory_node(const struct domain *d, if ( res ) return res; - res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + res = make_shm_memory_node(d, fdt, addrcells, sizecells, kinfo); if ( res ) return res; @@ -2696,8 +2696,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, return res; } - res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, - &kinfo->shm_mem); + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, kinfo); if ( res ) return res; } @@ -3254,8 +3253,7 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; - ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, - &kinfo->shm_mem); + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, kinfo); if ( ret ) goto err; diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 4617cdc83b..590bc56f6c 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -38,7 +38,14 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; - struct meminfo shm_mem; + /* Static shared memory banks */ + struct { + unsigned int nr_banks; + struct { + char shm_id[MAX_SHM_ID_LENGTH]; + struct membank membank; + } bank[NR_MEM_BANKS]; + } shminfo; /* kernel entry point */ paddr_t entry; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index a926f30a2b..f92fb51551 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -50,10 +50,6 @@ struct membank { paddr_t start; paddr_t size; enum membank_type type; -#ifdef CONFIG_STATIC_SHM - char shm_id[MAX_SHM_ID_LENGTH]; - unsigned int nr_shm_borrowers; -#endif }; struct meminfo { @@ -95,6 +91,17 @@ struct bootcmdlines { struct bootcmdline cmdline[MAX_MODULES]; }; +#ifdef CONFIG_STATIC_SHM +/* + * struct shm_node represents a static shared memory node shared between + * multiple domains, identified by the unique SHMID("xen,shm-id"). + */ +struct shm_node { + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; +}; +#endif + struct bootinfo { struct meminfo mem; /* The reserved regions are only used when booting using Device-Tree */ @@ -105,6 +112,12 @@ struct bootinfo { struct meminfo acpi; #endif bool static_heap; +#ifdef CONFIG_STATIC_SHM + struct { + unsigned int nr_nodes; + struct shm_node node[NR_MEM_BANKS]; + } shminfo; +#endif }; struct map_range_data -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499864.771171 (Exim 4.92) (envelope-from ) id 1pV4MI-0001FK-Ho; Thu, 23 Feb 2023 05:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499864.771171; Thu, 23 Feb 2023 05:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MI-0001FB-E6; Thu, 23 Feb 2023 05:41:34 +0000 Received: by outflank-mailman (input) for mailman id 499864; Thu, 23 Feb 2023 05:41:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MG-0001BN-La for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b94a0642-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:30 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 451761FB; Wed, 22 Feb 2023 21:42:13 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 927AB3F587; Wed, 22 Feb 2023 21:41:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b94a0642-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 3/8] xen/arm: introduce allocate_domheap_memory and guest_physmap_memory Date: Thu, 23 Feb 2023 13:41:00 +0800 Message-Id: <20230223054105.2357217-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We split the code of allocate_bank_memory into two parts, allocate_domheap_memory and guest_physmap_memory. One is about allocating guest RAM from heap, which could be re-used later for allocating static shared memory from heap when host address is not provided. The other is building up guest P2M mapping. We also define a set of MACRO helpers to access common fields in data structure of "meminfo" type, e.g. "struct meminfo" is one of them, and later new "struct shm_meminfo" is also one of them. This kind of structures must have the following characteristics: - an array of "struct membank" - a member called "nr_banks" indicating current array size - a field indicating the maximum array size When introducing a new data structure, according callbacks with function type "retrieve_fn" shall be defined for using MACRO helpers. This commit defines callback "retrieve_meminfo" for data structure "struct meminfo". Signed-off-by: Penny Zheng --- v1 -> v2: - define a set of MACRO helpers to access common fields in data structure of "meminfo" type. "struct meminfo" is one of them, and according callback "retrieve_meminfo" is also introduced here. - typo of changing 1ULL to 1UL --- xen/arch/arm/domain_build.c | 119 ++++++++++++++++++++++++------- xen/arch/arm/include/asm/setup.h | 33 +++++++++ 2 files changed, 127 insertions(+), 25 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 2daf36cdbd..a6ce22b423 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -77,6 +77,26 @@ custom_param("dom0_mem", parse_dom0_mem); */ #define DOM0_FDT_EXTRA_SIZE (128 + sizeof(struct fdt_reserve_entry)) +static void __init retrieve_meminfo(void *mem, unsigned int *max_mem_banks, + struct membank **bank, + unsigned int **nr_banks) +{ + struct meminfo *meminfo = (struct meminfo *)mem; + + if ( max_mem_banks ) + *max_mem_banks = NR_MEM_BANKS; + + if ( nr_banks ) + *nr_banks = &(meminfo->nr_banks); + + if ( bank ) + *bank = meminfo->bank; +} + +retrieve_fn __initdata retrievers[MAX_MEMINFO_TYPE] = { + [NORMAL_MEMINFO] = retrieve_meminfo, +}; + unsigned int __init dom0_max_vcpus(void) { if ( opt_dom0_max_vcpus == 0 ) @@ -391,34 +411,20 @@ static void __init allocate_memory_11(struct domain *d, } } -static bool __init allocate_bank_memory(struct domain *d, - struct kernel_info *kinfo, - gfn_t sgfn, - paddr_t tot_size) +static bool __init allocate_domheap_memory(struct domain *d, + paddr_t tot_size, + void *mem, enum meminfo_type type) { - int res; struct page_info *pg; - struct membank *bank; unsigned int max_order = ~0; - - /* - * allocate_bank_memory can be called with a tot_size of zero for - * the second memory bank. It is not an error and we can safely - * avoid creating a zero-size memory bank. - */ - if ( tot_size == 0 ) - return true; - - bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; - bank->start = gfn_to_gaddr(sgfn); - bank->size = tot_size; + unsigned int *nr_banks = GET_NR_BANKS(mem, type); while ( tot_size > 0 ) { unsigned int order = get_allocation_size(tot_size); + struct membank *membank; order = min(max_order, order); - pg = alloc_domheap_pages(d, order, 0); if ( !pg ) { @@ -438,15 +444,78 @@ static bool __init allocate_bank_memory(struct domain *d, continue; } - res = guest_physmap_add_page(d, sgfn, page_to_mfn(pg), order); - if ( res ) - { - dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); + if ( *nr_banks == MAX_MEM_BANKS(type) ) return false; - } + + membank = GET_MEMBANK(mem, type, *nr_banks); + membank->start = mfn_to_maddr(page_to_mfn(pg)); + membank->size = 1ULL << (PAGE_SHIFT + order); + (*nr_banks)++; + tot_size -= membank->size; + } + + return true; +} + +static int __init guest_physmap_memory(struct domain *d, + void *mem, enum meminfo_type type, + gfn_t sgfn) +{ + unsigned int i; + int res; + unsigned int *nr_banks = GET_NR_BANKS(mem, type); + + for ( i = 0; i < *nr_banks; i++ ) + { + struct membank *membank = GET_MEMBANK(mem, type, i); + paddr_t start = membank->start; + paddr_t size = membank->size; + unsigned int order = get_order_from_bytes(size); + + /* Size must be power of two */ + BUG_ON(!size || (size & (size - 1))); + res = guest_physmap_add_page(d, sgfn, maddr_to_mfn(start), order); + if ( res ) + return res; sgfn = gfn_add(sgfn, 1UL << order); - tot_size -= (1ULL << (PAGE_SHIFT + order)); + } + + return 0; +} + +static bool __init allocate_bank_memory(struct domain *d, + struct kernel_info *kinfo, + gfn_t sgfn, + paddr_t total_size) +{ + struct membank *bank; + struct meminfo host = { 0 }; + + /* + * allocate_bank_memory can be called with a total_size of zero for + * the second memory bank. It is not an error and we can safely + * avoid creating a zero-size memory bank. + */ + if ( total_size == 0 ) + return true; + + bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; + bank->start = gfn_to_gaddr(sgfn); + bank->size = total_size; + + if ( !allocate_domheap_memory(d, total_size, (void *)&host, NORMAL_MEMINFO) ) + { + printk(XENLOG_ERR "Failed to allocate (%"PRIpaddr"MB) pages to %pd\n", + total_size >> 20, d); + return false; + } + + if ( guest_physmap_memory(d, (void *)&host, NORMAL_MEMINFO, sgfn) ) + { + printk(XENLOG_ERR "Failed to map (%"PRIpaddr"MB) pages to %pd\n", + total_size >> 20, d); + return false; } kinfo->mem.nr_banks++; diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index f92fb51551..c42fd83db2 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -57,6 +57,39 @@ struct meminfo { struct membank bank[NR_MEM_BANKS]; }; +enum meminfo_type { + NORMAL_MEMINFO, + MAX_MEMINFO_TYPE, +}; + +/* + * Define a set of MACRO helpers to access meminfo_type, like "struct meminfo" + * as type of NORMAL_MEMINFO, etc. + * This kind of structure must have a array of "struct membank", + * a member called nr_banks indicating the current array size, and also a field + * indicating the maximum array size. + */ +typedef void (*retrieve_fn)(void *, unsigned int *, struct membank **, + unsigned int **); + +#define MAX_MEM_BANKS(type) ({ \ + unsigned int _max_mem_banks; \ + retrievers[type](NULL, &_max_mem_banks, NULL, NULL); \ + _max_mem_banks; \ +}) + +#define GET_MEMBANK(mem, type, index) ({ \ + struct membank *_bank; \ + retrievers[type]((void *)(mem), NULL, &_bank, NULL); \ + &(_bank[index]); \ +}) + +#define GET_NR_BANKS(mem, type) ({ \ + unsigned int *_nr_banks; \ + retrievers[type]((void *)mem, NULL, NULL, &_nr_banks); \ + _nr_banks; \ +}) + /* * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. * The purpose of the domU flag is to avoid getting confused in -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499861.771139 (Exim 4.92) (envelope-from ) id 1pV4MA-0000RO-Hu; Thu, 23 Feb 2023 05:41:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499861.771139; Thu, 23 Feb 2023 05:41:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MA-0000RH-Ek; Thu, 23 Feb 2023 05:41:26 +0000 Received: by outflank-mailman (input) for mailman id 499861; Thu, 23 Feb 2023 05:41:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4M9-0000Ql-NG for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b3700423-b33c-11ed-a82a-c9ca1d2f71af; Thu, 23 Feb 2023 06:41:21 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3DC681FB; Wed, 22 Feb 2023 21:42:03 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C93253F587; Wed, 22 Feb 2023 21:41:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3700423-b33c-11ed-a82a-c9ca1d2f71af From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH V2 0/8] Follow-up static shared memory PART I Date: Thu, 23 Feb 2023 13:40:57 +0800 Message-Id: <20230223054105.2357217-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some unsolving issues on current 4.17 static shared memory feature[1], including: - In order to avoid keeping growing 'membank', having the shared memory info in separate structures is preferred. - Missing implementation on having the host address optional in "xen,shared-mem" property - Removing static shared memory from extended regions - Missing reference release on foreign superpage - Missing "xen,offset" feature, which is introduced in Linux DOC[2] All above objects have been divided into two parts to complete. And this patch serie is PART I. [1] https://lore.kernel.org/all/20220908135513.1800511-1-Penny.Zheng@arm.com/ [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/reserved-memory/xen%2Cshared-memory.txt Penny Zheng (8): xen/arm: remove stale addr_cells/size_cells in assign_shared_memory xen/arm: re-define a set of data structures for static shared memory region xen/arm: introduce allocate_domheap_memory and guest_physmap_memory xen/arm: use paddr_assigned to indicate whether host address is provided xen/arm: support static shared memory when host address not provided xen/arm: remove shm holes for extended regions xen/p2m: put reference for superpage docs: refine docs about static shared memory docs/misc/arm/device-tree/booting.txt | 52 +- xen/arch/arm/bootfdt.c | 129 +++-- xen/arch/arm/domain_build.c | 704 ++++++++++++++++++++------ xen/arch/arm/include/asm/kernel.h | 9 +- xen/arch/arm/include/asm/setup.h | 57 ++- xen/arch/arm/p2m.c | 60 ++- 6 files changed, 784 insertions(+), 227 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499862.771145 (Exim 4.92) (envelope-from ) id 1pV4MA-0000Up-Sr; Thu, 23 Feb 2023 05:41:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499862.771145; Thu, 23 Feb 2023 05:41:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MA-0000UU-NM; Thu, 23 Feb 2023 05:41:26 +0000 Received: by outflank-mailman (input) for mailman id 499862; Thu, 23 Feb 2023 05:41:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4M9-0000Ql-U2 for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b565c53b-b33c-11ed-a82a-c9ca1d2f71af; Thu, 23 Feb 2023 06:41:24 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F67BC14; Wed, 22 Feb 2023 21:42:06 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C34463F587; Wed, 22 Feb 2023 21:41:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b565c53b-b33c-11ed-a82a-c9ca1d2f71af From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 1/8] xen/arm: remove stale addr_cells/size_cells in assign_shared_memory Date: Thu, 23 Feb 2023 13:40:58 +0800 Message-Id: <20230223054105.2357217-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function parameters {addr_cells,size_cells} are stale parameters in assign_shared_memory, so we shall remove them. Signed-off-by: Penny Zheng --- v1 -> v2: - new commit --- xen/arch/arm/domain_build.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index edca23b986..4a6f743f35 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -836,7 +836,6 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, } static int __init assign_shared_memory(struct domain *d, - uint32_t addr_cells, uint32_t size_cells, paddr_t pbase, paddr_t psize, paddr_t gbase) { @@ -998,7 +997,6 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * specified, so they should be assigned to dom_io. */ ret = assign_shared_memory(owner_dom_io ? dom_io : d, - addr_cells, size_cells, pbase, psize, gbase); if ( ret ) return ret; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499865.771183 (Exim 4.92) (envelope-from ) id 1pV4MK-0001XJ-Rf; Thu, 23 Feb 2023 05:41:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499865.771183; Thu, 23 Feb 2023 05:41:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MK-0001X4-Mz; Thu, 23 Feb 2023 05:41:36 +0000 Received: by outflank-mailman (input) for mailman id 499865; Thu, 23 Feb 2023 05:41:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MJ-0001BN-JS for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id bb627dc7-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:34 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB7A71FB; Wed, 22 Feb 2023 21:42:16 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CE5843F587; Wed, 22 Feb 2023 21:41:30 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb627dc7-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 4/8] xen/arm: use paddr_assigned to indicate whether host address is provided Date: Thu, 23 Feb 2023 13:41:01 +0800 Message-Id: <20230223054105.2357217-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We use paddr_assigned to indicate whether host address is provided, by checking the length of "xen,shared-mem" property. The shm matching criteria shall also be adapt to cover the new scenario, by adding when host address is not provided, if SHMID matches, the region size must exactly match too. During domain creation, right now, a static shared memory node could be banked with a statically configured host memory bank, or a set of arbitrary host memory banks allocated from heap. To cover both scenarios, we create a new structure shm_meminfo. It is very alike meminfo, but with the maximum array size being a smaller number NR_SHM_BANKS(16). As "shm_meminfo" is also a new member of "enum meminfo_type", we shall implement its own callback "retrieve_shm_meminfo" to have access to all MACRO helpers, e.g. GET_MEMBANK(...). Also, to make codes tidy and clear, we extract codes about parsing "xen,shared-mem" property from function "process_shm" and move them into a new helper "parse_shm_property". Signed-off-by: Penny Zheng --- v1 -> v2 - In order to get allocated banked host memory info during domain creation, we create a new structure shm_meminfo. It is very alike meminfo, with the maximum array size being NR_SHM_BANKS. As shm_meminfo is a new member of type meminfo_type, we shall implement its own callback retrieve_shm_meminfo to have access to all MACRO helpers, e.g. GET_MEMBANK(...) - rename "acquire_shm_memnode" to "find_shm_memnode" --- xen/arch/arm/bootfdt.c | 100 ++++++++++----- xen/arch/arm/domain_build.c | 207 +++++++++++++++++++++++++------ xen/arch/arm/include/asm/setup.h | 3 + 3 files changed, 243 insertions(+), 67 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index dc32d1b9b3..98cf6b89f6 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -21,7 +21,15 @@ static __initdata struct { unsigned int nr_nodes; struct { const struct shm_node *node; - const struct membank *membank; + /* + * For a static shared memory node, it is either banked with a reserved + * host memory bank, or arbitrary host memory which shall + * be allocated by Xen with a specified total size(tot_size). + */ + union { + const struct membank *membank; + paddr_t tot_size; + }; } shm_nodes[NR_MEM_BANKS]; } shm_data; #endif @@ -392,7 +400,7 @@ static int __init process_shm_node(const void *fdt, int node, paddr_t paddr, gaddr, size; unsigned int i; int len; - bool owner = false; + bool owner = false, paddr_assigned = true; const char *shm_id; if ( address_cells < 1 || size_cells < 1 ) @@ -433,7 +441,7 @@ static int __init process_shm_node(const void *fdt, int node, } /* - * xen,shared-mem = ; + * xen,shared-mem = , and paddr could be optional * Memory region starting from physical address #paddr of #size shall * be mapped to guest physical address #gaddr as static shared memory * region. @@ -444,16 +452,24 @@ static int __init process_shm_node(const void *fdt, int node, if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) { + /* paddr is not provided in "xen,shared-mem" */ if ( len == dt_cells_to_size(size_cells + address_cells) ) - printk("fdt: host physical address must be chosen by users at the moment.\n"); - - printk("fdt: invalid `xen,shared-mem` property.\n"); - return -EINVAL; + paddr_assigned = false; + else + { + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } } cell = (const __be32 *)prop->data; - device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); - size = dt_next_cell(size_cells, &cell); + if ( !paddr_assigned ) + device_tree_get_reg(&cell, address_cells, size_cells, &gaddr, &size); + else + { + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + } if ( !size ) { @@ -466,23 +482,37 @@ static int __init process_shm_node(const void *fdt, int node, paddr_t bank_start = shm_data.shm_nodes[i].membank->start; paddr_t bank_size = shm_data.shm_nodes[i].membank->size; const char *bank_id = shm_data.shm_nodes[i].node->shm_id; + paddr_t tot_size = shm_data.shm_nodes[i].tot_size; /* * Meet the following check: + * when host address is provided: * 1) The shm ID matches and the region exactly match * 2) The shm ID doesn't match and the region doesn't overlap * with an existing one + * when host address is not provided: + * 1) The shm ID matches and the region size exactly match */ - if ( paddr == bank_start && size == bank_size ) + if ( !paddr_assigned || ((paddr == bank_start) && (size == bank_size)) ) { if ( strncmp(shm_id, bank_id, MAX_SHM_ID_LENGTH) == 0 ) - break; - else + { + if ( !paddr_assigned && (size != tot_size) ) + { + printk("fdt: when host address is not provided, if xen,shm-id matches, size must stay the same too(%"PRIpaddr" -> %"PRIpaddr")\n", + size, tot_size); + return -EINVAL; + } + } + else if ( paddr_assigned ) { printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", shm_id); return -EINVAL; } + + /* host address is not provided, and with different SHMID. */ + continue; } else { @@ -517,37 +547,41 @@ static int __init process_shm_node(const void *fdt, int node, if ( (i == shm_data.nr_nodes) && (i == bootinfo.shminfo.nr_nodes) ) { - struct meminfo *mem = &bootinfo.reserved_mem; - - if ( (i < NR_MEM_BANKS) && (mem->nr_banks < NR_MEM_BANKS) ) + if ( i < NR_MEM_BANKS ) { - /* Static shared memory shall be reserved from any other use. */ - struct membank *membank = &mem->bank[mem->nr_banks]; struct shm_node *shm_node = &bootinfo.shminfo.node[i]; - - membank->start = paddr; - membank->size = size; - membank->type = MEMBANK_STATIC_DOMAIN; - mem->nr_banks++; + struct meminfo *mem = &bootinfo.reserved_mem; /* Record static shared memory node info in bootinfo.shminfo */ safe_strcpy(shm_node->shm_id, shm_id); bootinfo.shminfo.nr_nodes++; - /* - * Reserved memory bank is recorded together with shm - * node info in shm_data, to assist doing shm node verification. - */ shm_data.shm_nodes[i].node = shm_node; - shm_data.shm_nodes[i].membank = membank; shm_data.nr_nodes++; + if ( !paddr_assigned ) + shm_data.shm_nodes[i].tot_size = size; + else if ( mem->nr_banks < NR_MEM_BANKS ) + { + struct membank *membank = &mem->bank[mem->nr_banks]; + + membank->start = paddr; + membank->size = size; + membank->type = MEMBANK_STATIC_DOMAIN; + mem->nr_banks++; + + /* + * Reserved memory bank is recorded together with shm + * node info in shm_data, to assist doing shm node verification. + */ + shm_data.shm_nodes[i].membank = membank; + } + else + goto fail; } else - { - printk("Warning: Max number of supported memory regions reached.\n"); - return -ENOSPC; - } + goto fail; } + /* * keep a count of the number of borrowers, which later may be used * to calculate the reference count. @@ -556,6 +590,10 @@ static int __init process_shm_node(const void *fdt, int node, bootinfo.shminfo.node[i].nr_shm_borrowers++; return 0; + + fail: + printk("Warning: Max number of supported memory regions reached\n"); + return -ENOSPC; } #else static int __init process_shm_node(const void *fdt, int node, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a6ce22b423..91feb8f37c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -49,6 +49,51 @@ boolean_param("ext_regions", opt_ext_regions); static u64 __initdata dom0_mem; static bool __initdata dom0_mem_set; +#ifdef CONFIG_STATIC_SHM +#define NR_SHM_BANKS 16 + +/* + * A static shared memory node could be banked with a statically + * configured host memory bank, or a set of arbitrary host memory + * banks allocated from heap. + */ +struct shm_meminfo { + unsigned int nr_banks; + struct membank bank[NR_SHM_BANKS]; + paddr_t tot_size; +}; + +/* + * struct shm_memnode holds banked host memory info for a static + * shared memory node + */ +struct shm_memnode { + char shm_id[MAX_SHM_ID_LENGTH]; + struct shm_meminfo meminfo; +}; + +static __initdata struct { + unsigned int nr_nodes; + struct shm_memnode node[NR_MEM_BANKS]; +} shm_memdata; + +static void __init retrieve_shm_meminfo(void *mem, unsigned int *max_mem_banks, + struct membank **bank, + unsigned int **nr_banks) +{ + struct shm_meminfo *meminfo = (struct shm_meminfo *)mem; + + if ( max_mem_banks ) + *max_mem_banks = NR_SHM_BANKS; + + if ( nr_banks ) + *nr_banks = &(meminfo->nr_banks); + + if ( bank ) + *bank = meminfo->bank; +} +#endif + static int __init parse_dom0_mem(const char *s) { dom0_mem_set = true; @@ -95,6 +140,9 @@ static void __init retrieve_meminfo(void *mem, unsigned int *max_mem_banks, retrieve_fn __initdata retrievers[MAX_MEMINFO_TYPE] = { [NORMAL_MEMINFO] = retrieve_meminfo, +#ifdef CONFIG_STATIC_SHM + [SHM_MEMINFO] = retrieve_shm_meminfo, +#endif }; unsigned int __init dom0_max_vcpus(void) @@ -842,6 +890,24 @@ static int __init acquire_nr_borrower_domain(const char *shm_id, return -EINVAL; } +static struct shm_memnode * __init find_shm_memnode(const char *shm_id) +{ + unsigned int i; + struct shm_memnode *shm_memnode; + + for ( i = 0 ; i < shm_memdata.nr_nodes; i++ ) + { + shm_memnode = &shm_memdata.node[i]; + + if ( strcmp(shm_id, shm_memnode->shm_id) == 0 ) + return shm_memnode; + } + + shm_memnode = &shm_memdata.node[i]; + safe_strcpy(shm_memnode->shm_id, shm_id); + return shm_memnode; +} + /* * This function checks whether the static shared memory region is * already allocated to dom_io. @@ -987,6 +1053,102 @@ static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, return 0; } +/* Parse "xen,shared-mem" property in static shared memory node */ +static struct shm_memnode * __init parse_shm_property(struct domain *d, + const struct dt_device_node *dt_node, + bool *paddr_assigned, paddr_t *gbase, + const char *shm_id) +{ + uint32_t addr_cells, size_cells; + const struct dt_property *prop; + const __be32 *cells; + uint32_t len; + unsigned int i; + paddr_t pbase, psize; + struct shm_memnode *shm_memnode; + + /* xen,shared-mem = ; And pbase could be optional. */ + prop = dt_find_property(dt_node, "xen,shared-mem", &len); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + + addr_cells = dt_n_addr_cells(dt_node); + size_cells = dt_n_size_cells(dt_node); + if ( len != dt_cells_to_size(addr_cells + size_cells + addr_cells) ) + { + /* pbase is not provided in "xen,shared-mem" */ + if ( len == dt_cells_to_size(size_cells + addr_cells) ) + *paddr_assigned = false; + else + { + printk("fdt: invalid `xen,shared-mem` property.\n"); + return NULL; + } + } + + /* + * If we firstly process the shared memory node with unique "xen,shm-id", + * we allocate a new member "shm_memnode" for it in shm_memdata. + */ + shm_memnode = find_shm_memnode(shm_id); + BUG_ON(!shm_memnode); + if ( !(*paddr_assigned) ) + { + device_tree_get_reg(&cells, addr_cells, size_cells, gbase, &psize); + if ( shm_memnode->meminfo.tot_size == 0 ) + goto out_early1; + else + goto out_early2; + } + else + { + device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, gbase); + psize = dt_read_number(cells, size_cells); + } + + /* + * The static shared memory node #dt_node is banked with a + * statically configured host memory bank. + */ + shm_memnode->meminfo.bank[0].start = pbase; + shm_memnode->meminfo.bank[0].size = psize; + shm_memnode->meminfo.nr_banks = 1; + + if ( !IS_ALIGNED(pbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase); + return NULL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical MFN 0x%"PRI_mfn"\n for static shared memory node\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return NULL; + } + + out_early1: + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return NULL; + } + shm_memnode->meminfo.tot_size = psize; + + out_early2: + if ( !IS_ALIGNED(*gbase, PAGE_SIZE) ) + { + printk("%pd: guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, *gbase); + return NULL; + } + + return shm_memnode; +} + static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { @@ -994,51 +1156,17 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, dt_for_each_child_node(node, shm_node) { - const struct dt_property *prop; - const __be32 *cells; - uint32_t addr_cells, size_cells; paddr_t gbase, pbase, psize; int ret = 0; - unsigned int i; const char *role_str; const char *shm_id; bool owner_dom_io = true; + bool paddr_assigned = true; + struct shm_memnode *shm_memnode; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; - /* - * xen,shared-mem = ; - * TODO: pbase is optional. - */ - addr_cells = dt_n_addr_cells(shm_node); - size_cells = dt_n_size_cells(shm_node); - prop = dt_find_property(shm_node, "xen,shared-mem", NULL); - BUG_ON(!prop); - cells = (const __be32 *)prop->value; - device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_number(cells, size_cells); - if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) - { - printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", - d, pbase, gbase); - return -EINVAL; - } - if ( !IS_ALIGNED(psize, PAGE_SIZE) ) - { - printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", - d, psize); - return -EINVAL; - } - - for ( i = 0; i < PFN_DOWN(psize); i++ ) - if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) - { - printk("%pd: invalid physical address 0x%"PRI_mfn"\n", - d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); - return -EINVAL; - } - /* * "role" property is optional and if it is defined explicitly, * then the owner domain is not the default "dom_io" domain. @@ -1053,6 +1181,13 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, } BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + shm_memnode = parse_shm_property(d, shm_node, &paddr_assigned, &gbase, + shm_id); + if ( !shm_memnode ) + return -EINVAL; + pbase = shm_memnode->meminfo.bank[0].start; + psize = shm_memnode->meminfo.bank[0].size; + /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index c42fd83db2..fc5ca11e08 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -59,6 +59,9 @@ struct meminfo { enum meminfo_type { NORMAL_MEMINFO, +#ifdef CONFIG_STATIC_SHM + SHM_MEMINFO, +#endif MAX_MEMINFO_TYPE, }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499866.771194 (Exim 4.92) (envelope-from ) id 1pV4MO-0001qb-1h; Thu, 23 Feb 2023 05:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499866.771194; Thu, 23 Feb 2023 05:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MN-0001qQ-Ur; Thu, 23 Feb 2023 05:41:39 +0000 Received: by outflank-mailman (input) for mailman id 499866; Thu, 23 Feb 2023 05:41:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MM-0001BN-Q1 for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id bd647e09-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:37 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13D3B1FB; Wed, 22 Feb 2023 21:42:20 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6075E3F587; Wed, 22 Feb 2023 21:41:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd647e09-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 5/8] xen/arm: support static shared memory when host address not provided Date: Thu, 23 Feb 2023 13:41:02 +0800 Message-Id: <20230223054105.2357217-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to support static shared memory when host address not provided, we shall do the following modification: - we shall let Xen allocate memory from heap for static shared memory at first domain, no matter it is owner or borrower. - In acquire_shared_memory_bank, as static shared memory has already been allocated from heap, we shall assign them to the owner domain using function "assign_pages". - Function get_shm_pages_reference is created to add as many additional reference as the number of borrowers. - We implement a new helper "add_foreign_mapping_for_borrower" to set up foreign memory mapping for borrower. Instead of using multiple function parameters to deliver various shm-related info, like host physical address, SHMID, etc, and with the introduction of new struct "shm_memnode" to include banked host memory info, we switch to use "shm_memnode" as function parameter to replace them all, to make codes more clear and tidy. Signed-off-by: Penny Zheng --- v1 -> v2: - combine commits 4 - 6 in Serie 1 - Adapt to changes of introducing "struct shm_memnode" --- xen/arch/arm/domain_build.c | 222 +++++++++++++++++++++++++----------- 1 file changed, 155 insertions(+), 67 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 91feb8f37c..9b4aabaf22 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -869,6 +869,11 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM +static bool __init is_shm_allocated_from_heap(struct shm_memnode *node) +{ + return (node->meminfo.nr_banks != 0); +} + static int __init acquire_nr_borrower_domain(const char *shm_id, unsigned long *nr_borrowers) { @@ -912,12 +917,12 @@ static struct shm_memnode * __init find_shm_memnode(const char *shm_id) * This function checks whether the static shared memory region is * already allocated to dom_io. */ -static bool __init is_shm_allocated_to_domio(paddr_t pbase) +static bool __init is_shm_allocated_to_domio(struct shm_memnode *node) { struct page_info *page; struct domain *d; - page = maddr_to_page(pbase); + page = maddr_to_page(node->meminfo.bank[0].start); d = page_get_owner_and_reference(page); if ( d == NULL ) return false; @@ -935,67 +940,129 @@ static bool __init is_shm_allocated_to_domio(paddr_t pbase) } static mfn_t __init acquire_shared_memory_bank(struct domain *d, - paddr_t pbase, paddr_t psize) + struct shm_meminfo *meminfo, + bool paddr_assigned) { - mfn_t smfn; - unsigned long nr_pfns; int res; + unsigned int i = 0; - /* - * Pages of statically shared memory shall be included - * into domain_tot_pages(). - */ - nr_pfns = PFN_DOWN(psize); - if ( (UINT_MAX - d->max_pages) < nr_pfns ) + for ( ; i < meminfo->nr_banks; i++ ) { - printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", - d, nr_pfns); + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; + unsigned long nr_pfns; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + if ( paddr_assigned ) + { + res = acquire_domstatic_pages(d, maddr_to_mfn(pbase), nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + goto fail; + } + } + else + /* + * When host address is not provided, static shared memory is + * allocated from heap and shall be assigned to owner domain. + */ + if ( assign_pages(maddr_to_page(pbase), nr_pfns, d, 0) ) + goto fail; + } + + return maddr_to_mfn(meminfo->bank[0].start); + + fail: + while( --i >= 0 ) + d->max_pages -= PFN_DOWN(meminfo->bank[i].size); return INVALID_MFN; +} + +static int __init get_shm_pages_reference(struct domain *d, + struct shm_meminfo *meminfo, + unsigned long count) +{ + struct page_info *page; + unsigned int i = 0, j; + + for ( ; i < meminfo->nr_banks; i++ ) + { + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; + unsigned long nr_pages = PFN_DOWN(psize); + + page = maddr_to_page(pbase); + for ( j = 0; j < nr_pages; j++ ) + { + if ( !get_page_nr(page + j, d, count) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + count, mfn_x(page_to_mfn(page + j))); + goto fail; + } + } } - d->max_pages += nr_pfns; - smfn = maddr_to_mfn(pbase); - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); - if ( res ) + return 0; + + fail: + while ( --j >= 0 ) + put_page_nr(page + j, count); + while ( --i >= 0 ) { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - d->max_pages -= nr_pfns; - return INVALID_MFN; + page = maddr_to_page(meminfo->bank[i].start); + j = PFN_DOWN(meminfo->bank[i].size); + while ( --j >= 0 ) + put_page_nr(page + j, count); } + return -EINVAL; - return smfn; } - static int __init assign_shared_memory(struct domain *d, - paddr_t pbase, paddr_t psize, - paddr_t gbase, const char *shm_id) + struct shm_memnode *node, paddr_t gbase, + bool paddr_assigned) { mfn_t smfn; - int ret = 0; - unsigned long nr_pages, nr_borrowers, i; - struct page_info *page; - - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); + int ret; + unsigned long nr_borrowers, i; + struct shm_meminfo *meminfo = &node->meminfo; - smfn = acquire_shared_memory_bank(d, pbase, psize); + smfn = acquire_shared_memory_bank(d, meminfo, paddr_assigned); if ( mfn_eq(smfn, INVALID_MFN) ) return -EINVAL; - /* - * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need - * to create mapping in the P2M. - */ - nr_pages = PFN_DOWN(psize); - if ( d != dom_io ) + for ( i = 0; i < meminfo->nr_banks; i++ ) { - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, - PFN_DOWN(psize)); - if ( ret ) + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; + + /* + * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do + * not need to create mapping in the P2M. + */ + if ( d != dom_io ) { - printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); - return ret; + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), + maddr_to_mfn(pbase), + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + gbase += psize; } } @@ -1003,7 +1070,7 @@ static int __init assign_shared_memory(struct domain *d, * Get the right amount of references per page, which is the number of * borrower domains. */ - ret = acquire_nr_borrower_domain(shm_id, &nr_borrowers); + ret = acquire_nr_borrower_domain(node->shm_id, &nr_borrowers); if ( ret ) return ret; @@ -1015,24 +1082,30 @@ static int __init assign_shared_memory(struct domain *d, * So if the borrower is created first, it will cause adding pages * in the P2M without reference. */ - page = mfn_to_page(smfn); - for ( i = 0; i < nr_pages; i++ ) + return get_shm_pages_reference(d, meminfo, nr_borrowers); +} + +static int __init add_foreign_mapping_for_borrower(struct domain *d, + struct shm_memnode *node, + paddr_t gbase) +{ + unsigned int i = 0; + struct shm_meminfo *meminfo = &node->meminfo; + + for ( ; i < meminfo->nr_banks; i++ ) { - if ( !get_page_nr(page + i, d, nr_borrowers) ) - { - printk(XENLOG_ERR - "Failed to add %lu references to page %"PRI_mfn".\n", - nr_borrowers, mfn_x(smfn) + i); - goto fail; - } + paddr_t pbase = meminfo->bank[i].start, psize = meminfo->bank[i].size; + int ret; + + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + gbase += psize; } return 0; - - fail: - while ( --i >= 0 ) - put_page_nr(page + i, nr_borrowers); - return ret; } static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, @@ -1156,7 +1229,7 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, dt_for_each_child_node(node, shm_node) { - paddr_t gbase, pbase, psize; + paddr_t gbase; int ret = 0; const char *role_str; const char *shm_id; @@ -1185,15 +1258,30 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, shm_id); if ( !shm_memnode ) return -EINVAL; - pbase = shm_memnode->meminfo.bank[0].start; - psize = shm_memnode->meminfo.bank[0].size; + + /* + * When host address is not provided in "xen,shared-mem", + * we let Xen allocate memory from heap at first domain. + */ + if ( !paddr_assigned && !is_shm_allocated_from_heap(shm_memnode) ) + { + if ( !allocate_domheap_memory(NULL, shm_memnode->meminfo.tot_size, + (void *)&shm_memnode->meminfo, + SHM_MEMINFO) ) + { + printk(XENLOG_ERR + "Failed to allocate (%"PRIpaddr"MB) pages as static shared memory from heap\n", + shm_memnode->meminfo.tot_size >> 20); + return -EINVAL; + } + } /* * DOMID_IO is a fake domain and is not described in the Device-Tree. * Therefore when the owner of the shared region is DOMID_IO, we will * only find the borrowers. */ - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + if ( (owner_dom_io && !is_shm_allocated_to_domio(shm_memnode)) || (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { /* @@ -1201,16 +1289,14 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * specified, so they should be assigned to dom_io. */ ret = assign_shared_memory(owner_dom_io ? dom_io : d, - pbase, psize, gbase, shm_id); + shm_memnode, gbase, paddr_assigned); if ( ret ) return ret; } if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) { - /* Set up P2M foreign mapping for borrower domain. */ - ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), - _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + ret = add_foreign_mapping_for_borrower(d, shm_memnode, gbase); if ( ret ) return ret; } @@ -1219,7 +1305,9 @@ static int __init process_shm(struct domain *d, struct kernel_info *kinfo, * Record static shared memory region info for later setting * up shm-node in guest device tree. */ - ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + ret = append_shm_bank_to_domain(kinfo, gbase, + shm_memnode->meminfo.tot_size, + shm_memnode->shm_id); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499867.771205 (Exim 4.92) (envelope-from ) id 1pV4MR-0002F5-Fb; Thu, 23 Feb 2023 05:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499867.771205; Thu, 23 Feb 2023 05:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MR-0002Ep-BD; Thu, 23 Feb 2023 05:41:43 +0000 Received: by outflank-mailman (input) for mailman id 499867; Thu, 23 Feb 2023 05:41:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MP-0001BN-OP for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:41 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id bf471208-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:40 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F0AA1FB; Wed, 22 Feb 2023 21:42:23 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9C3683F587; Wed, 22 Feb 2023 21:41:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf471208-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 6/8] xen/arm: remove shm holes for extended regions Date: Thu, 23 Feb 2023 13:41:03 +0800 Message-Id: <20230223054105.2357217-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Static shared memory acts as reserved memory in guest, so it shall be excluded from extended regions. Extended regions are taken care of under three different scenarios: normal DomU, direct-map domain with iommu on, and direct-map domain with iommu off. For normal DomU, we create a new function "remove_shm_holes_for_domU", to firstly transfer original outputs into the format of "struct rangeset", then use "remove_shm_from_rangeset" to remove static shm from them. For direct-map domain with iommu on, after we get guest shm info from "kinfo", we use "remove_shm_from_rangeset" to remove static shm. For direct-map domain with iommu off, as static shm has already been taken care of through reserved memory banks, we do nothing. Signed-off-by: Penny Zheng --- v1 -> v2: - new commit --- xen/arch/arm/domain_build.c | 94 ++++++++++++++++++++++++++++++++++++- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 9b4aabaf22..4cd1e3d433 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1914,6 +1914,32 @@ static int __init handle_pci_range(const struct dt_device_node *dev, return 0; } +static int __init remove_shm_from_rangeset(const struct kernel_info *kinfo, + struct rangeset *rangeset) +{ + unsigned int i; + + /* Remove static shared memory regions */ + for ( i = 0; i < kinfo->shminfo.nr_banks; i++ ) + { + struct membank membank = kinfo->shminfo.bank[i].membank; + paddr_t start, end; + int res; + + start = membank.start; + end = membank.start + membank.size - 1; + res = rangeset_remove_range(rangeset, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + return -EINVAL; + } + } + + return 0; +} + /* * Find the holes in the Host DT which can be exposed to Dom0 as extended * regions for the special memory mappings. In order to calculate regions @@ -1922,6 +1948,8 @@ static int __init handle_pci_range(const struct dt_device_node *dev, * - MMIO * - Host RAM * - PCI aperture + * - Static shared memory regions, which are described by special property + * "xen,static-shm" */ static int __init find_memory_holes(const struct kernel_info *kinfo, struct meminfo *ext_regions) @@ -1997,6 +2025,14 @@ static int __init find_memory_holes(const struct kernel_info *kinfo, } } + /* Remove static shared memory regions */ + if ( kinfo->shminfo.nr_banks != 0 ) + { + res = remove_shm_from_rangeset(kinfo, mem_holes); + if ( res ) + goto out; + } + start = 0; end = (1ULL << p2m_ipa_bits) - 1; res = rangeset_report_ranges(mem_holes, start, end, @@ -2012,6 +2048,62 @@ out: return res; } +static int __init remove_shm_holes_for_domU(const struct kernel_info *kinfo, + struct meminfo *orig_ext) +{ + struct rangeset *guest_holes; + unsigned int i = 0, tail; + int res; + paddr_t start, end; + + /* No static shared memory region. */ + if ( kinfo->shminfo.nr_banks == 0 ) + return 0; + + dt_dprintk("Remove static shared memory holes for extended regions of DomU\n"); + + guest_holes = rangeset_new(NULL, NULL, 0); + if ( !guest_holes ) + return -ENOMEM; + + for ( ; i < orig_ext->nr_banks; i++ ) + { + start = orig_ext->bank[i].start; + end = start + orig_ext->bank[i].size - 1; + + res = rangeset_add_range(guest_holes, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; + } + } + + /* Remove static shared memory regions */ + res = remove_shm_from_rangeset(kinfo, guest_holes); + if ( res ) + goto out; + + tail = orig_ext->nr_banks - 1; + start = orig_ext->bank[0].start; + end = orig_ext->bank[tail].start + orig_ext->bank[tail].size - 1; + + /* Reset original extended regions to hold new value */ + orig_ext->nr_banks = 0; + res = rangeset_report_ranges(guest_holes, start, end, + add_ext_regions, orig_ext); + if ( res ) + orig_ext->nr_banks = 0; + else if ( !orig_ext->nr_banks ) + res = -ENOENT; + +out: + rangeset_destroy(guest_holes); + + return res; +} + static int __init find_domU_holes(const struct kernel_info *kinfo, struct meminfo *ext_regions) { @@ -2039,7 +2131,7 @@ static int __init find_domU_holes(const struct kernel_info *kinfo, res = 0; } - return res; + return remove_shm_holes_for_domU(kinfo, ext_regions); } static int __init make_hypervisor_node(struct domain *d, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:41:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499874.771216 (Exim 4.92) (envelope-from ) id 1pV4MU-0002e8-RC; Thu, 23 Feb 2023 05:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499874.771216; Thu, 23 Feb 2023 05:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MU-0002cs-Jj; Thu, 23 Feb 2023 05:41:46 +0000 Received: by outflank-mailman (input) for mailman id 499874; Thu, 23 Feb 2023 05:41:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MT-0001BN-1U for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id c13553b7-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:44 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A74D1FB; Wed, 22 Feb 2023 21:42:26 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D7F443F587; Wed, 22 Feb 2023 21:41:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c13553b7-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 7/8] xen/p2m: put reference for superpage Date: Thu, 23 Feb 2023 13:41:04 +0800 Message-Id: <20230223054105.2357217-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We are doing foreign memory mapping for static shared memory, and there is a great possibility that it could be super mapped. But today, p2m_put_l3_page could not handle superpages. This commits implements a new function p2m_put_superpage to handle superpages, specifically for helping put extra references for foreign superpages. Signed-off-by: Penny Zheng --- v1 -> v2: - new commit --- xen/arch/arm/p2m.c | 60 +++++++++++++++++++++++++++++++++------------- 1 file changed, 44 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 948f199d84..e8fa61fcbc 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -851,17 +851,9 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, return rc; } -/* - * Put any references on the single 4K page referenced by pte. - * TODO: Handle superpages, for now we only take special references for leaf - * pages (specifically foreign ones, which can't be super mapped today). - */ -static void p2m_put_l3_page(const lpae_t pte) +/* Put any references on the single 4K page referenced by mfn. */ +static void p2m_put_l3_page(mfn_t mfn, unsigned type) { - mfn_t mfn = lpae_get_mfn(pte); - - ASSERT(p2m_is_valid(pte)); - /* * TODO: Handle other p2m types * @@ -869,16 +861,53 @@ static void p2m_put_l3_page(const lpae_t pte) * flush the TLBs if the page is reallocated before the end of * this loop. */ - if ( p2m_is_foreign(pte.p2m.type) ) + if ( p2m_is_foreign(type) ) { ASSERT(mfn_valid(mfn)); put_page(mfn_to_page(mfn)); } /* Detect the xenheap page and mark the stored GFN as invalid. */ - else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) + else if ( p2m_is_ram(type) && is_xen_heap_mfn(mfn) ) page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); } +/* Put any references on the superpage referenced by mfn. */ +static void p2m_put_superpage(mfn_t mfn, unsigned int next_level, unsigned type) +{ + unsigned int i; + unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level); + + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + if ( next_level == 3 ) + p2m_put_l3_page(mfn, type); + else + p2m_put_superpage(mfn, next_level + 1, type); + + mfn = mfn_add(mfn, 1 << level_order); + } +} + +/* Put any references on the page referenced by pte. */ +static void p2m_put_page(const lpae_t pte, unsigned int level) +{ + mfn_t mfn = lpae_get_mfn(pte); + + ASSERT(p2m_is_valid(pte)); + + /* + * We are either having a first level 1G superpage or a + * second level 2M superpage. + */ + if ( p2m_is_superpage(pte, level) ) + return p2m_put_superpage(mfn, level + 1, pte.p2m.type); + else + { + ASSERT(level == 3); + return p2m_put_l3_page(mfn, pte.p2m.type); + } +} + /* Free lpae sub-tree behind an entry */ static void p2m_free_entry(struct p2m_domain *p2m, lpae_t entry, unsigned int level) @@ -907,9 +936,8 @@ static void p2m_free_entry(struct p2m_domain *p2m, #endif p2m->stats.mappings[level]--; - /* Nothing to do if the entry is a super-page. */ - if ( level == 3 ) - p2m_put_l3_page(entry); + p2m_put_page(entry, level); + return; } @@ -1752,7 +1780,7 @@ void p2m_final_teardown(struct domain *d) * p2m_final_teardown() is called either after domain_relinquish_resources() * where relinquish_p2m_mapping() has been called, or from failure path of * domain_create()/arch_domain_create() where mappings that require - * p2m_put_l3_page() should never be created. For the latter case, also see + * p2m_put_page() should never be created. For the latter case, also see * comment on top of the p2m_set_entry() for more info. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:42:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499882.771227 (Exim 4.92) (envelope-from ) id 1pV4MY-0003At-13; Thu, 23 Feb 2023 05:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499882.771227; Thu, 23 Feb 2023 05:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MX-0003Ah-TN; Thu, 23 Feb 2023 05:41:49 +0000 Received: by outflank-mailman (input) for mailman id 499882; Thu, 23 Feb 2023 05:41:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4MW-0001BN-SQ for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:41:48 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id c323e35d-b33c-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:41:47 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C62A71FB; Wed, 22 Feb 2023 21:42:29 -0800 (PST) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1F5EF3F587; Wed, 22 Feb 2023 21:41:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c323e35d-b33c-11ed-88bb-e56d68cac8db From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v2 8/8] xen/docs: refine docs about static shared memory Date: Thu, 23 Feb 2023 13:41:05 +0800 Message-Id: <20230223054105.2357217-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230223054105.2357217-1-Penny.Zheng@arm.com> References: <20230223054105.2357217-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit amends docs(docs/misc/arm/device-tree/booting.txt) to include the new scenario where host address is not provided in "xen,shared-mem" property, and we also add a new example to explain in detail. We also fix some buggy info in the docs, like SHMID is "my-shared-mem-1", not "0x1". Signed-off-by: Penny Zheng --- v1 -> v2: - no new changes --- docs/misc/arm/device-tree/booting.txt | 52 ++++++++++++++++++++------- 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 3879340b5e..ce9e71e087 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -574,7 +574,7 @@ communication. An array takes a physical address, which is the base address of the shared memory region in host physical address space, a size, and a guest physical address, as the target address of the mapping. - e.g. xen,shared-mem = < [host physical address] [guest address] [size] > + e.g. xen,shared-mem = < [host physical address] [guest address] [size] >; It shall also meet the following criteria: 1) If the SHM ID matches with an existing region, the address range of the @@ -585,8 +585,8 @@ communication. The number of cells for the host address (and size) is the same as the guest pseudo-physical address and they are inherited from the parent node. - Host physical address is optional, when missing Xen decides the location - (currently unimplemented). + Host physical address is optional, when missing Xen decides the location. + e.g. xen,shared-mem = < [guest address] [size] >; - role (Optional) @@ -613,7 +613,7 @@ chosen { role = "owner"; xen,shm-id = "my-shared-mem-0"; xen,shared-mem = <0x10000000 0x10000000 0x10000000>; - } + }; domU1 { compatible = "xen,domain"; @@ -624,25 +624,36 @@ chosen { vpl011; /* - * shared memory region identified as 0x0(xen,shm-id = <0x0>) - * is shared between Dom0 and DomU1. + * shared memory region "my-shared-mem-0" is shared + * between Dom0 and DomU1. */ domU1-shared-mem@10000000 { compatible = "xen,domain-shared-memory-v1"; role = "borrower"; xen,shm-id = "my-shared-mem-0"; xen,shared-mem = <0x10000000 0x50000000 0x10000000>; - } + }; /* - * shared memory region identified as 0x1(xen,shm-id = <0x1>) - * is shared between DomU1 and DomU2. + * shared memory region "my-shared-mem-1" is shared between + * DomU1 and DomU2. */ domU1-shared-mem@50000000 { compatible = "xen,domain-shared-memory-v1"; xen,shm-id = "my-shared-mem-1"; xen,shared-mem = <0x50000000 0x60000000 0x20000000>; - } + }; + + /* + * shared memory region "my-shared-mem-2" is shared between + * DomU1 and DomU2. + */ + domU1-shared-mem-2 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-2"; + role = "owner"; + xen,shared-mem = <0x80000000 0x20000000>; + }; ...... @@ -656,14 +667,21 @@ chosen { cpus = <1>; /* - * shared memory region identified as 0x1(xen,shm-id = <0x1>) - * is shared between domU1 and domU2. + * shared memory region "my-shared-mem-1" is shared between + * domU1 and domU2. */ domU2-shared-mem@50000000 { compatible = "xen,domain-shared-memory-v1"; xen,shm-id = "my-shared-mem-1"; xen,shared-mem = <0x50000000 0x70000000 0x20000000>; - } + }; + + domU2-shared-mem-2 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-2"; + role = "borrower"; + xen,shared-mem = <0x90000000 0x20000000>; + }; ...... }; @@ -683,3 +701,11 @@ shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest physical address space, and at 0x70000000 in DomU2 guest physical address space. DomU1 and DomU2 are both the borrower domain, the owner domain is the default owner domain DOMID_IO. + +For the static shared memory region "my-shared-mem-2", since host physical +address is not provided by user, Xen will automatically allocate 512MB +from heap as static shared memory to be shared between DomU1 and DomU2. +The automatically allocated static shared memory will get mapped at +0x80000000 in DomU1 guest physical address space, and at 0x90000000 in DomU2 +guest physical address space. DomU1 is explicitly defined as the owner domain, +and DomU2 is the borrower domain. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 05:43:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 05:43:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499894.771237 (Exim 4.92) (envelope-from ) id 1pV4OQ-0005Nx-Em; Thu, 23 Feb 2023 05:43:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499894.771237; Thu, 23 Feb 2023 05:43:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4OQ-0005Nq-C3; Thu, 23 Feb 2023 05:43:46 +0000 Received: by outflank-mailman (input) for mailman id 499894; Thu, 23 Feb 2023 05:43:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV4OP-0005Ng-A5 for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 05:43:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08963795-b33d-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 06:43:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 659243768C; Thu, 23 Feb 2023 05:43:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2D4A13524; Thu, 23 Feb 2023 05:43:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HYwiNQ799mMlJAAAMHmgww (envelope-from ); Thu, 23 Feb 2023 05:43:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08963795-b33d-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677131023; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IHejay9Cos6UnBIHVby2h+E6MdwHaWOzzvaCEWnrVvY=; b=qRvWcxOJtWBACJ32nfR9kQdfXGU8GxwXREVdzbS1/skSX6gmr0kZGd3R7gxT8UsrC7w9aC vIK5COUmX/pmX8cMvObyQlm/mf0tL0Sw6+7NL74LgKAFiZmgTpfnkZVdShsfI6NfFV+E8H M7t5aRULTTI87Gs73jX5d/2Q7Ia51z4= Message-ID: <98d0ac9a-66af-6fdd-ff19-d4805a57f8d9@suse.com> Date: Thu, 23 Feb 2023 06:43:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH linux-next v2 0/2] x86/xen TSC related cleanups Content-Language: en-US To: Krister Johansen , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------XPqT0GIeb0bfN0VKqzFykd2d" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------XPqT0GIeb0bfN0VKqzFykd2d Content-Type: multipart/mixed; boundary="------------Y0rDYZBjuwBEPs36bRHEABMN"; protected-headers="v1" From: Juergen Gross To: Krister Johansen , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: Jan Beulich , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Marcelo Tosatti , Anthony Liguori , David Reaver , Brendan Gregg Message-ID: <98d0ac9a-66af-6fdd-ff19-d4805a57f8d9@suse.com> Subject: Re: [PATCH linux-next v2 0/2] x86/xen TSC related cleanups References: In-Reply-To: --------------Y0rDYZBjuwBEPs36bRHEABMN Content-Type: multipart/mixed; boundary="------------FdNJxns2APFImyPwxgf1iouK" --------------FdNJxns2APFImyPwxgf1iouK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMDIuMjMgMTg6NTQsIEtyaXN0ZXIgSm9oYW5zZW4gd3JvdGU6DQo+IEhpLA0KPiBF bmNsb3NlZCBwbGVhc2UgZmluZCBhIHBhaXIgb2YgcGF0Y2hlcyB0aGF0IHBlcmZvcm0gc29t ZSBhZGRpdGlvbmFsIGNsZWFudXANCj4gdGhhdCB3YXMgc3VnZ2VzdGVkIGJ5IEJvcmlzLCBK YW4gYW5kIFRob21hcy4NCj4gDQo+IFNwZWNpZmljYWxseTogdGhpcyByZXN5bmMncyBhcmNo L3g4Ni9pbmNsdWRlL2FzbS94ZW4vY3B1aWQuaCBmcm9tIGl0cw0KPiB1cHN0cmVhbSBzb3Vy Y2UgaW4gdGhlIFhlbiB0cmVlLCBhbmQgdGhlbiB1c2VzIG9uZSBvZiB0aGUgbmV3ICNkZWZp bmUtcyB0bw0KPiByZXBsYWNlIGEgY29uc3RhbnQgaW4geDg2L3hlbi90aW1lLmMgdGhhdCB3 YXMgcHJldmlvdXNseSBvbmx5IG51bWVyaWNhbGx5DQo+IGRlZmluZWQuICBQZWRhbnRpYyBj b2RlIGZyb20gdjEgaXMgZHJvcHBlZCBpbiBmYXZvciBvZiBhIG1vcmUgYXBwcm9wcmlhdGUN Cj4gcmV0dXJuIHN0YXRlbWVudC4NCj4gDQo+IENoYW5nZXMgZnJvbSB2MToNCj4gDQo+IC0g Q29kaW5nIHN0eWxlIGZpeHVwIGluIGFyY2gveDg2L3hlbi90aW1lLmMgKEZlZWRiYWNrIGZy b20gVGhvbWFzIEdsZWl4bmVyKQ0KPiANCj4gDQo+IEtyaXN0ZXIgSm9oYW5zZW4gKDIpOg0K PiAgICB4ZW46IHVwZGF0ZSBhcmNoL3g4Ni9pbmNsdWRlL2FzbS94ZW4vY3B1aWQuaA0KPiAg ICB4ODYveGVuL3RpbWU6IGNsZWFudXAgeGVuX3RzY19zYWZlX2Nsb2Nrc291cmNlDQo+IA0K PiAgIGFyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9jcHVpZC5oIHwgMjIgKysrKysrKysrKysr KysrKysrLS0tLQ0KPiAgIGFyY2gveDg2L3hlbi90aW1lLmMgICAgICAgICAgICAgIHwgIDcg KystLS0tLQ0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgOSBkZWxl dGlvbnMoLSkNCj4gDQoNCkZvciBib3RoIHBhdGNoZXM6DQoNClJldmlld2VkLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------FdNJxns2APFImyPwxgf1iouK Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------FdNJxns2APFImyPwxgf1iouK-- --------------Y0rDYZBjuwBEPs36bRHEABMN-- --------------XPqT0GIeb0bfN0VKqzFykd2d Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP2/Q4FAwAAAAAACgkQsN6d1ii/Ey8C wwgAhnL8X2zH5z7EA+RoNKpROeQo1zhcJRQo6ThHhQXu+1WiKD0CQtD7LdyFXSrwKpa6nEOh1Efq EtfNrZD8D/QVCPRz5E+JkaFdG5P+wD0rIpZTv/R+zm6Rs9jpiyMG5SNKS+V8YtO8SzHp9cVJIL4W gbRrYo4oxtkvWhq8y6RnrZ12/F52VPIrIycaW0pE6jj1ZEp1IgWYIyLyX5JBL+W0LVGRMXK25gQz FfxCYYapsq9DOByLNCRs/csbdvo6NKSgXzDuJwbOr5MtIts1zJl7WSDde6LpCmC3XAewPzdTnyJE a634XwoTPaowTktpbAoGLzkxqb3OJ9gLtDviZDO0wQ== =KuN2 -----END PGP SIGNATURE----- --------------XPqT0GIeb0bfN0VKqzFykd2d-- From xen-devel-bounces@lists.xenproject.org Thu Feb 23 08:42:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 08:42:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499959.771249 (Exim 4.92) (envelope-from ) id 1pV7BP-0003cF-N0; Thu, 23 Feb 2023 08:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499959.771249; Thu, 23 Feb 2023 08:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7BP-0003c8-Js; Thu, 23 Feb 2023 08:42:31 +0000 Received: by outflank-mailman (input) for mailman id 499959; Thu, 23 Feb 2023 08:42:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7BO-0003by-Pc; Thu, 23 Feb 2023 08:42:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7BO-0006WT-MF; Thu, 23 Feb 2023 08:42:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7BO-0005Bp-CV; Thu, 23 Feb 2023 08:42:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pV7BO-0003E3-C3; Thu, 23 Feb 2023 08:42:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mf6QTnY8UblzXt1N6aMmZR/bfBdx2D9qDKTiU0GGfz4=; b=wfnnJODHtr+Iehtd8FDdydF3vI V7xfMSSBHtf4ExL/ojr6MPBsI347G788C5zZOQDjKHBh0qLJ0TaSYKKALsELdDQghRSSjpXcJy37J x18AyfOAloK6ojP5v2/pTjeLJblk68pLBXS03mJErjw4dDvK5xrNgdOl0OcUXa3D2abU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178148: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:build-armhf-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:build-arm64-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Thu, 23 Feb 2023 08:42:30 +0000 flight 178148 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 build-armhf-pvops 6 kernel-build fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 build-arm64-pvops 6 kernel-build fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5b7c4cabbb65f5c469464da6c5f614cbd7f730f2 baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 1 days Testing same since 178093 2023-02-22 05:02:47 Z 1 days 3 attempts ------------------------------------------------------------ 685 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops fail build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine blocked test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 69393 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Feb 23 09:33:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 09:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499969.771260 (Exim 4.92) (envelope-from ) id 1pV7y7-0001ti-FH; Thu, 23 Feb 2023 09:32:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499969.771260; Thu, 23 Feb 2023 09:32:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7y7-0001tb-BK; Thu, 23 Feb 2023 09:32:51 +0000 Received: by outflank-mailman (input) for mailman id 499969; Thu, 23 Feb 2023 09:32:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7y6-0001tV-LM for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 09:32:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0875ffa3-b35d-11ed-a82a-c9ca1d2f71af; Thu, 23 Feb 2023 10:32:48 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CD0005BCDA; Thu, 23 Feb 2023 09:32:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 640BD13928; Thu, 23 Feb 2023 09:32:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iFEhF74y92NebAAAMHmgww (envelope-from ); Thu, 23 Feb 2023 09:32:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0875ffa3-b35d-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677144766; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=C995AjaZ46xbV13+isMfz3LA3fxYywRVUZkm4+TPAWU=; b=txNsDPLk4f2qQu+vuFEutx6H4efCH4XDAlf5/mg63gyYRT89Wsgajq4Fzdy9gcCNuqw7gf 5poPJ9ggFpgCDn4QrEBY7Tlz7telq+D3bpc8JlhdqwacNdF4ThetYCobiVROkv4iNVMJvX 4p5BQG0GXkRbMTKwTbPii9X5KbZeOtg= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-hyperv@vger.kernel.org Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Boris Ostrovsky , xen-devel@lists.xenproject.org, Andy Lutomirski , Peter Zijlstra Subject: [PATCH v3 00/12] x86/mtrr: fix handling with PAT but without MTRR Date: Thu, 23 Feb 2023 10:32:31 +0100 Message-Id: <20230223093243.1180-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series tries to fix the rather special case of PAT being available without having MTRRs (either due to CONFIG_MTRR being not set, or because the feature has been disabled e.g. by a hypervisor). The main use cases are Xen PV guests and SEV-SNP guests running under Hyper-V. Instead of trying to work around all the issues by adding if statements here and there, just try to use the complete available infrastructure by setting up a read-only MTRR state when needed. In the Xen PV case the current MTRR MSR values can be read from the hypervisor, while for the SEV-SNP case all needed is to set the default caching mode to "WB". I have added more cleanup which has been discussed when looking into the most recent failures. Note that I couldn't test the Hyper-V related change (patch 3). Running on bare metal and with Xen didn't show any problems with the series applied. It should be noted that patches 9+10 are replacing today's way to lookup the MTRR cache type for a memory region from looking at the MTRR register values to building a memory map with the cache types. This should make the lookup much faster and much easier to understand. Changes in V2: - replaced former patches 1+2 with new patches 1-4, avoiding especially the rather hacky approach of V1, while making all the MTRR type conflict tests available for the Xen PV case - updated patch 6 (was patch 4 in V1) Changes in V3: - dropped patch 5 of V2, as already applied - split patch 1 of V2 into 2 patches - new patches 6-10 - addressed comments Juergen Gross (12): x86/mtrr: split off physical address size calculation x86/mtrr: optimize mtrr_calc_physbits() x86/mtrr: support setting MTRR state for software defined MTRRs x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest x86/xen: set MTRR state when running as Xen PV initial domain x86/mtrr: replace vendor tests in MTRR code x86/mtrr: allocate mtrr_value array dynamically x86/mtrr: add get_effective_type() service function x86/mtrr: construct a memory map with cache modes x86/mtrr: use new cache_map in mtrr_type_lookup() x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID x86/mm: only check uniform after calling mtrr_type_lookup() arch/x86/include/asm/mtrr.h | 15 +- arch/x86/include/uapi/asm/mtrr.h | 6 +- arch/x86/kernel/cpu/mshyperv.c | 4 + arch/x86/kernel/cpu/mtrr/amd.c | 2 +- arch/x86/kernel/cpu/mtrr/centaur.c | 2 +- arch/x86/kernel/cpu/mtrr/cleanup.c | 4 +- arch/x86/kernel/cpu/mtrr/cyrix.c | 2 +- arch/x86/kernel/cpu/mtrr/generic.c | 487 ++++++++++++++++++----------- arch/x86/kernel/cpu/mtrr/mtrr.c | 94 +++--- arch/x86/kernel/cpu/mtrr/mtrr.h | 7 +- arch/x86/kernel/setup.c | 2 + arch/x86/mm/pgtable.c | 24 +- arch/x86/xen/enlighten_pv.c | 50 +++ 13 files changed, 447 insertions(+), 252 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 09:33:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 09:33:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499971.771271 (Exim 4.92) (envelope-from ) id 1pV7yX-0002Gt-M8; Thu, 23 Feb 2023 09:33:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499971.771271; Thu, 23 Feb 2023 09:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7yX-0002Gm-JR; Thu, 23 Feb 2023 09:33:17 +0000 Received: by outflank-mailman (input) for mailman id 499971; Thu, 23 Feb 2023 09:33:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV7yW-0002Du-FD for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 09:33:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1939410a-b35d-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 10:33:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 596FD337F7; Thu, 23 Feb 2023 09:33:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 110F513928; Thu, 23 Feb 2023 09:33:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id a0MDAtsy92OmbAAAMHmgww (envelope-from ); Thu, 23 Feb 2023 09:33:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1939410a-b35d-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677144795; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjil8ydj+MbGLi24YOvmKTY6GkdCwB8f6NUZv/v3iL0=; b=f1lGkoc901x7lIfA6dv5NQpuQXuNT2Y9un8+vttO+jCblw1+Z+0VJz0GmtM8iUuNOWIJel zgALYUpQ3GLTcj425d8OzgfSLsqex9QOV+ZRjt7hqepTZeOZ4n5M0z2FX9oxt/xgInoJFz dMKS3jUEiMuk6ne8ZFQr4MNruZxSTtM= From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain Date: Thu, 23 Feb 2023 10:32:36 +0100 Message-Id: <20230223093243.1180-6-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230223093243.1180-1-jgross@suse.com> References: <20230223093243.1180-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When running as Xen PV initial domain (aka dom0), MTRRs are disabled by the hypervisor, but the system should nevertheless use correct cache memory types. This has always kind of worked, as disabled MTRRs resulted in disabled PAT, too, so that the kernel avoided code paths resulting in inconsistencies. This bypassed all of the sanity checks the kernel is doing with enabled MTRRs in order to avoid memory mappings with conflicting memory types. This has been changed recently, leading to PAT being accepted to be enabled, while MTRRs stayed disabled. The result is that mtrr_type_lookup() no longer is accepting all memory type requests, but started to return WB even if UC- was requested. This led to driver failures during initialization of some devices. In reality MTRRs are still in effect, but they are under complete control of the Xen hypervisor. It is possible, however, to retrieve the MTRR settings from the hypervisor. In order to fix those problems, overwrite the MTRR state via mtrr_overwrite_state() with the MTRR data from the hypervisor, if the system is running as a Xen dom0. Fixes: 72cbc8f04fe2 ("x86/PAT: Have pat_enabled() properly reflect state when running on Xen") Signed-off-by: Juergen Gross --- V2: - new patch V3: - move the call of mtrr_overwrite_state() to xen_pv_init_platform() --- arch/x86/xen/enlighten_pv.c | 50 +++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index bb59cc6ddb2d..729fb447a5b6 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -68,6 +68,7 @@ #include #include #include +#include #include #include #include @@ -119,6 +120,52 @@ static int __init parse_xen_msr_safe(char *str) } early_param("xen_msr_safe", parse_xen_msr_safe); +/* Get MTRR settings from Xen and put them into mtrr_state. */ +static void __init xen_set_mtrr_data(void) +{ +#ifdef CONFIG_MTRR + struct xen_platform_op op = { + .cmd = XENPF_read_memtype, + .interface_version = XENPF_INTERFACE_VERSION, + }; + unsigned int reg; + unsigned long mask; + uint32_t eax, width; + static struct mtrr_var_range var[MTRR_MAX_VAR_RANGES] __initdata; + + /* Get physical address width (only 64-bit cpus supported). */ + width = 36; + eax = cpuid_eax(0x80000000); + if ((eax >> 16) == 0x8000 && eax >= 0x80000008) { + eax = cpuid_eax(0x80000008); + width = eax & 0xff; + } + + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { + op.u.read_memtype.reg = reg; + if (HYPERVISOR_platform_op(&op)) + break; + + /* + * Only called in dom0, which has all RAM PFNs mapped at + * RAM MFNs, and all PCI space etc. is identity mapped. + * This means we can treat MFN == PFN regarding MTTR settings. + */ + var[reg].base_lo = op.u.read_memtype.type; + var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT; + var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT); + mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1); + mask &= (1UL << width) - 1; + if (mask) + mask |= 1 << 11; + var[reg].mask_lo = mask; + var[reg].mask_hi = mask >> 32; + } + + mtrr_overwrite_state(var, reg, MTRR_TYPE_UNCACHABLE); +#endif +} + static void __init xen_pv_init_platform(void) { /* PV guests can't operate virtio devices without grants. */ @@ -135,6 +182,9 @@ static void __init xen_pv_init_platform(void) /* pvclock is in shared info area */ xen_init_time_ops(); + + if (xen_initial_domain()) + xen_set_mtrr_data(); } static void __init xen_pv_guest_late_init(void) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Feb 23 09:46:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 09:46:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.499984.771282 (Exim 4.92) (envelope-from ) id 1pV8BT-0004Kg-1X; Thu, 23 Feb 2023 09:46:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 499984.771282; Thu, 23 Feb 2023 09:46:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8BS-0004KZ-Ty; Thu, 23 Feb 2023 09:46:38 +0000 Received: by outflank-mailman (input) for mailman id 499984; Thu, 23 Feb 2023 09:46:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8BR-0004KP-0K; Thu, 23 Feb 2023 09:46:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8BQ-0007zi-Sv; Thu, 23 Feb 2023 09:46:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8BQ-0008DA-KM; Thu, 23 Feb 2023 09:46:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pV8BQ-00072O-Js; Thu, 23 Feb 2023 09:46:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ug2Izxq0IavmtwtPGKBWVS5l1UtMlpncuzoLrOFBOzM=; b=2E6lGDz8G4HI/mt0raUY8gRhd7 7aHUubjP7q91BdenB0lc0lOih6PK8fVefPKg8WN5OQGYKakAv6k64P8vE5b6cdr38HsAgMHnP2RtA r3o12Sd1Ltp3T9tKchdYvoY5aN8AnFHWoMVcCtubmONw2xLG2d84i09yY1yJwlKIUPpI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 178139: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=aaf74a532c02017998492c0bf60a9c6be3332f20 X-Osstest-Versions-That: xen=3685e754e6017c616769b28133286d06bf07b613 From: osstest service owner Date: Thu, 23 Feb 2023 09:46:36 +0000 flight 178139 xen-4.17-testing real [real] flight 178219 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178139/ http://logs.test-lab.xenproject.org/osstest/logs/178219/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 177300 Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 178219-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 178219-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177300 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177300 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177300 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177300 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 177300 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177300 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177300 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177300 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177300 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen aaf74a532c02017998492c0bf60a9c6be3332f20 baseline version: xen 3685e754e6017c616769b28133286d06bf07b613 Last test of basis 177300 2023-02-14 18:07:07 Z 8 days Testing same since 178139 2023-02-22 14:37:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit aaf74a532c02017998492c0bf60a9c6be3332f20 Author: Anthony PERARD Date: Tue Feb 21 16:55:38 2023 +0000 automation: Remove clang-8 from Debian unstable container First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper (cherry picked from commit a6b1e2b80fe2053b1c9c9843fb086a668513ea36) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Feb 23 10:11:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 23 Feb 2023 10:11:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500146.771376 (Exim 4.92) (envelope-from ) id 1pV8Zi-0001aw-6V; Thu, 23 Feb 2023 10:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500146.771376; Thu, 23 Feb 2023 10:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8Zi-0001ap-3C; Thu, 23 Feb 2023 10:11:42 +0000 Received: by outflank-mailman (input) for mailman id 500146; Thu, 23 Feb 2023 10:11:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pV8Zg-0001ae-5M for xen-devel@lists.xenproject.org; Thu, 23 Feb 2023 10:11:40 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20602.outbound.protection.outlook.com [2a01:111:f400:fe16::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75ed61ae-b362-11ed-88bb-e56d68cac8db; Thu, 23 Feb 2023 11:11:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7664.eurprd04.prod.outlook.com (2603:10a6:102:f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Thu, 23 Feb 2023 10:11:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6134.019; Thu, 23 Feb 2023 10:11:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75ed61ae-b362-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGEghjvPXbk0mqv07lyQXbwZrJCUrOoBhh4+B/m4zk886BqvQEdyXxb5Ty0sdt03ldMJQWDnh6dS6eBXnkQngFPuEvRtELJuT5YFcDKczkmQleCUVfJMNxtWT4rUUPJigZpNtZEE8ljPwBSlqyc6m9TWigWjiBSWyNtVIMkylmTGfiKizGZkLzLV+IWO1A4rOLzdLzWXRdbE6xj4eEUFPQp/O/2tIgEjwKftbbf2qY4c65HmRqDXVGzCkwILjyNgAzjPGClKk/v/Xt0xQMpd4AMPkOQ/scvN/lVqqOWwsRvproykvcB/rH9ovrF5OE9QCNJ9tMXVNGp0qUuiDysG/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/BPHwQK6RhV39CQbmdTgVpoLkkPcki07C1OWjtIF+mo=; b=IsEyTf+56CC9tKJbs0dxWpDC+gHOwVm63NrFyxt/fuXOHx3e2T1+JsijFBSs9FkiIOESiQROOJUZRSLicTAkbQrhJsAvwkvNAHJCUns+EVlkZ8b2rynUJ3uxCCGwM6rZdKmOZsQ144BEfAXTcCzPC6EB1JfbLBqJdacv6u8VTJmyx1VS56QxbJGYTFhlF88yobsKJlN8HxXPLpoV9cpy6Y9DLR9Nj+IEL0QWarVbC7Vx5Dpj2gxmyMYRAHXFqPn9NQJfmtnzz1wiFec3BVSuKJS8f82VOH9iBFjCk/c+EpTqkYdldOKCB0GFY+knY4Ym/soDOZEVLdxteXSNlkSSbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/BPHwQK6RhV39CQbmdTgVpoLkkPcki07C1OWjtIF+mo=; b=wuEIxtGbDDibI/pcQAfkoylIoz6JShwh3YdYY4XtAGv1w2SZoXn582mhObuNU47F05rvDCgJ82cuRAPKgRMvFpvWFlUir6BpQu1MwIjp0HNqrBMJ8gJUbA9XA8QyoVIiA9+jifMFEGhYBZ2I0ZBWOemlNXFEF1MlvNXfEnrn4E7EIzuz0rU+DKTzs40NFvPEkKHaxIbOMf/w2EuhClcbtKTKjAN00jVCru2JMlqcQ4L7YyN59v6c1R55idxMfBbDQfneGNRWNNq7zVI/u7aahoFfNLx2DKTqT0uj6MHdSw0wwmMjJKl4Jx2f/veE1rweeMokxvWKk9vl2wTCogCkWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 23 Feb 2023 11:11:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper References: <214973b0-5fe7-9208-2cfc-dd2884583157@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7664:EE_ X-MS-Office365-Filtering-Correlation-Id: 707d94c7-8afe-46e6-3c3a-08db1586584a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3aiIYkaWknBvtkezotQPHWT4i6HWIFJtKUJAkcNP1ol5Xcbimx6L5+F7EpGdRuNXGeJQafJTDdsCxqwIhgbarJbm8apPZjtOmC+6i43qd2lKOmKlTBplcsG7Co6zdrSGOVGFMGp+gaSCMRbS4OmaV8DxsldLrIk9YVZf6EshQhqBWZelhl8+pCleXOSyiy28nAAwD1qgIj79xAaOj1VQBeOjIk6l2JIQOhhntAZVarr99KfyJ5G0UoKqPUbgCj9C5f8bcoIFVSa4xPCqFQCPcwffiFo77gWQISxWiQIsH9sCMQx8XTE9at2o/krx6Erhhp3JmbwOMCo96E8p71XLjIIAlye3tpSQDsEH7zOxYC4gjFGuILPqfLbIorfta9oXYv57IbQCxDR5DzXY21un6bsZBFoLFwu9YxsxHQJtAYsB5FDLAsogR7wPhnnuE+yQYOEGe77bK0nZZq2RVInpRMcq/lS+YAIVo37rWaZCNhu4eA2jMTES9JKpYuY65teXRr+KkU1mkLXC22dhhXonBM0rGzcgE17nH+J9/PlJCieu19rzcz9/bRZMElV5UBi3QLK1+IXmQKZChV7+ITq5K+c1R+5aJkjl6aJVXUSYJUjVZl+++KuFvPFmPq3uh14kZgL1oHaPT9vUT4Z3uYQpyMAxzY+6P8oYIyEZXBety8nkSksvgvCLjhzUvEJFzfu+8CNY9Gtpq9roQJeMa/rbNIEomLy/WAiIr+uCXZ7l8dFt4JSfVZRzvSAvnw+L6LKMibYRLfDs63A/0coRNulhbfCDZ7/036RlDE/12wCE5fE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(136003)(346002)(396003)(39860400002)(451199018)(186003)(26005)(31686004)(5660300002)(2616005)(966005)(6486002)(6666004)(6512007)(6506007)(54906003)(53546011)(478600001)(316002)(66476007)(4326008)(6916009)(41300700001)(8936002)(8676002)(66556008)(66946007)(38100700002)(86362001)(36756003)(2906002)(31696002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXhrWnF1YWtMZklPMEk3UTNzc2NUWWtGWThIVlhEcFl4TjNpY3FzT215OFgz?= =?utf-8?B?QllGb1R1NFpla3d3WlBZTDVweGFlM1YzRWlVWU5iOGFyZWVib3haVHUxT0c5?= =?utf-8?B?djZFUnRhY3hFOEJRN3pOb2hQcUVLRkpqV0ZJMVFiWGFLV1JORCtnd3VGYVVT?= =?utf-8?B?S25LV3FENmFQNFduS1JRR1BhaXp1YjBlZG5JblhIL084VmVmV1phTGpGSTdo?= =?utf-8?B?c1dDV2hPbzg2c21LcTQ3MGxiT0lyT0FwdFV1Z3NXRkw2VThHNWNPSHgrNWFl?= =?utf-8?B?NXIvL2FTczRZZmkweVdrdkh4R2IzNzhvdW02bldXY1FKUnBrVHF6UTJQSXpL?= =?utf-8?B?bk11UW9RbmxKaDl5WVZGMGM2ZVVqTGxINUlMbHdsd0pmVWhZTm5RT2ZUci9H?= =?utf-8?B?UmZaTHlHYXZKdC9EaXZFL2JJUy9WZlMwZ29tcGNrWHRzM0FWdDRwMnZZVVdD?= =?utf-8?B?akRPaVg3QWJyWUR2TktoSGI5cmdIblZLb2JkRURONWVkM0VjSW1UL24xZGdj?= =?utf-8?B?OGl3eE85YnZPb2I2L3dXWGRSTzcyajBSQjhQQk1FMHptWHhmTGRjUXhabVh2?= =?utf-8?B?YTdEbTl1c09sajdPeGdzelIwNE1nbndnd0trYkxGd29DTVBIY2w2WW9OTloz?= =?utf-8?B?NmVFK1FFOW1Md2txVGlrYWpWTEVDQzQ1eVQ2WHczRUt2NFVkc0JXcWZCR2Qy?= =?utf-8?B?UlZEQzdTUGxrVXFlVHRqSG5ZSTc2ay9TbVI1SStscEh1UFFsRXpQcS9TYjJZ?= =?utf-8?B?RkNjSFYyTFJPLzFocUpOL1dTTnVQMWtubXZLejJjT2hWUERpdFRFQTZlbFU1?= =?utf-8?B?dzgvTldUWlJabGJoNG02Mm1CcUV0WlZybkNtZWVsWWFzWGVlU3dqNUx0L3Vt?= =?utf-8?B?M3dla0dLVFo4aGVFZ0dGeFprN24xNEhuUjc1M1VnZTlseGh1ZHdFajc3ZUla?= =?utf-8?B?Q0xhSnBXaU5xUGxNcG9xUHF1NXgzS0xuVGlPQkhOVFVtSW9LK1ZVYWx5MjZ2?= =?utf-8?B?RjY1Q25hSzVPLzRCeVRRdjRucXhOREhmSlBmc3kvVk9sYm1sdlBqbFgwa2Rq?= =?utf-8?B?cjJJbjBueENDWlJHNmNlTENwQ1Q3S3BLWExORjE4R3JVVk12WXBtTmN0Qi9Q?= =?utf-8?B?L1lvU1hhUWJhOTZFUkk2THlld2RJdzNvQmVudEdCVjlFcUI5OWZmQThpWmdn?= =?utf-8?B?VFhIbTlQRnBLYVVSOFRuTktLd1g5TUoxanJxamY0aEtkK0lGZTVjY092enBU?= =?utf-8?B?RmlyaWl4dm9CVWllL1UwWVRVTjRZSTIzLzd5dDdwaW00ODV6RklsVXJiNmcv?= =?utf-8?B?M0tPcUkvK3c5ZnR0Si82aGRyYUhnbnNpKzFiTXQvekNySXhzYkVvYU9OK2Nh?= =?utf-8?B?TS9DQkNJTzArczBjZ0ZrdWliWGZ6WHJEZ3NieGNCdUpxbDdYZ3FDUzlpZnJS?= =?utf-8?B?bnB6MFozN0c0SWlEeG9ZV0NYVUNJaXJnL1NXYStaNzhiZ2lhZGxwQ250QVJ0?= =?utf-8?B?eVdUeEMvSWpZeWlUaTRuS1IrQ1VHbUd6QnZxUndmcWpLL0JHd1k2eGRVQUU4?= =?utf-8?B?TzA2Y1hVSnR6WHNwQU9BbEtIc3pzUFQ1ODVJc2Vmbk5OcklpZVk5cWRxTFJI?= =?utf-8?B?b3VkcWdPMjAvUm85ZkJvdXE3czFJTURzNXdQMDlPZ1kyQThtMm5iemQ0SW14?= =?utf-8?B?L2hUcWF6cmEwTHZhWk84d05McUFydWtiRjR0NVZOWlViRXFpRmFTdkZmWEtX?= =?utf-8?B?aHArVmZWZDBZL0RJaDZkbCtmRHlhNzRualEyc2QvNGRqNUdHMURoaTI2Mk1w?= =?utf-8?B?bW5MRGtzSFdsdVAwK3B1cGgwK3RvbC9CUTllTDFOa2psUG1sNkk3TXh4MU9k?= =?utf-8?B?a2ZkN1MyMWZqWExYbkNaWTY2RUJIcEdJSkhSSVNNZHRWVzlmOFoyNE96Zmg3?= =?utf-8?B?ajZUK0UzQkhiemNxbFIzTjRJZ0lBR0U5M004ZVl4UkpKVm1mYk5HTFZNaHU3?= =?utf-8?B?VzFDN281S3VCSzkzQllRSmxTckIxVUZ1TUxCUjFDM1FZR2tBVDh2d3ZpSEc4?= =?utf-8?B?YnBiTlgxNmVlL1YybUdOSFozMzFJMDRmSE1ha3FzcWRZWHU1SDI4SUQ5R3Q4?= =?utf-8?Q?EX2PpRC6tb30ofk3KxhGPNFb9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 707d94c7-8afe-46e6-3c3a-08db1586584a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 10:11:35.5836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VOTCA/yX7qzNaqkIbftQyc7vRvv2OtMq+s3UPuybqVUd4hbT+j4VndJXln5HaBcZhiwyRb+36I7kGjtHJptzOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7664 On 22.02.2023 17:16, Oleksii wrote: > On Wed, 2023-02-22 at 13:46 +0100, Jan Beulich wrote: >> On 20.02.2023 17:40, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/common/bug.c >>> @@ -0,0 +1,113 @@ >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >> >> Is this really needed here? > Yes, it is. > > Function show_execution_state() is declared in this header for all > architectures and is used by handle_bug_frame(). Ugly, but yes, you're right. >>> +const struct bug_frame* find_bug_frame(unsigned long pc, unsigned >>> int *id) >> >> Is this function going to be needed outside of this CU? IOW why is it >> not >> static? >> > It's not static because there is not possible to use do_bug_frame() as > is for x86 as x86 has some additional checks for some cases which > aren't in generic implementation: > [1] > https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86/traps.c#L1217 > [2] > https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86/traps.c#L1238 > [3] > https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/x86/traps.c#L1259 > > Probably to make generic do_bug_frame() more re-usable for x86 we can > implement as stubs fixup_exception_return() and debugger_trap_fatal() > under #ifndef X86 ... #endif inside common/bug.c. > > Could you please share your thoughts about that? Isn't all that's needed a suitable return value from the function, for the caller to take appropriate further action? (Maybe even that isn't really necessary.) That said, debugger_trap_fatal() imo may sensibly be generalized, and hence could be left in common code. Arm may simply stub this to nothing then for the time being. >>> +{ >>> +    const char *prefix = "", *filename, *predicate; >>> +    unsigned long fixup; >>> +    unsigned int lineno; >>> + >>> +    if ( id == BUGFRAME_run_fn ) >>> +    { >>> +#ifdef ARM        >> >> Who or what defines ARM? Anyway, seeing ... > it is defined by default in Kconfig: > https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/xen/arch/arm/Kconfig#L13 That'll be CONFIG_ARM then in uses in C code. >>> +        void (*fn)(const struct cpu_user_regs *) = (void *)regs- >>>> BUG_FN_REG; >> >> ... this, wouldn't it be better (and independent of the specific >> arch) if >> you checked for BUG_FN_REG being defined? > If I understand Kconfig correctly than there is no significant > difference what check. But probably BUG_FN_REG would be a little bit > better if someone will decide to change a way how pointer to function > will be passed in case of ARM than we will get compilation error and so > won't miss to fix the line in do_bug_frame(). Indeed - #ifdef like this one generally want to check for the precise aspect in question, without making assumptions about something implying something else. (Pretty certainly there are exceptions to this rule, but it holds here.) >>> +    ".p2align >>> 2\n"                                                          \ >>> +    >>> ".Lfrm%=:\n"                                                        >>>      \ >>> +    ".long (.Lbug%= - .Lfrm%=) + >>> %"MODIFIER"[bf_line_hi]\n"                  \ >>> +    ".long (%"MODIFIER"[bf_ptr] - .Lfrm%=) + >>> %"MODIFIER"[bf_line_lo]\n"       \ >>> +    ".if " #second_frame >>> "\n"                                               \ >>> +    ".long 0, %"MODIFIER"[bf_msg] - >>> .Lfrm%=\n"                               \ >>> +    >>> ".endif\n"                                                          >>>      \ >>> +    ".popsection\n" >> >> I think I said so in reply to an earlier version already: The moment >> assembly code moves to a common header, it should be adjusted to be >> as >> portable as possible. In particular directives should never start at >> the >> beginning of a line, while labels always should. (Whether .long is >> actually portable is another question, which I'll be happy to leave >> aside for now.) > I am not sure that I understand about which one directive we are > talking about... Are we talking about .{push/pop}section and .p2align? > Probably you can show me an example in Xen or other project? I'm talking about all directives here. Fundamentally assembly language source lines are like this (assuming colons follow labels): [
--0000000000002d515c05f56e8250-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 09:31:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 09:31:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500861.772382 (Exim 4.92) (envelope-from ) id 1pVUPg-0000qL-Sb; Fri, 24 Feb 2023 09:30:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500861.772382; Fri, 24 Feb 2023 09:30:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUPg-0000qE-PC; Fri, 24 Feb 2023 09:30:48 +0000 Received: by outflank-mailman (input) for mailman id 500861; Fri, 24 Feb 2023 09:30:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUPf-0000q8-QB for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 09:30:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea73b8b2-b425-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 10:30:46 +0100 (CET) Received: from DB7PR02CA0016.eurprd02.prod.outlook.com (2603:10a6:10:52::29) by PAXPR08MB6702.eurprd08.prod.outlook.com (2603:10a6:102:134::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 09:30:41 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::e2) by DB7PR02CA0016.outlook.office365.com (2603:10a6:10:52::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 09:30:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.11 via Frontend Transport; Fri, 24 Feb 2023 09:30:40 +0000 Received: ("Tessian outbound 43b0faad5a68:v132"); Fri, 24 Feb 2023 09:30:40 +0000 Received: from 2dfaf0d8d9be.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 36A6EC97-9EC6-430C-951C-8C13542ADD2B.1; Fri, 24 Feb 2023 09:30:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2dfaf0d8d9be.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Feb 2023 09:30:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS4PR08MB7853.eurprd08.prod.outlook.com (2603:10a6:20b:51c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 09:30:27 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 09:30:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea73b8b2-b425-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShNW6fG4S+HSV39TrO3L3RCVPXUhCOt4kcszsvLmgMs=; b=D7sbQZgk/PjENqzrvpw8ahvOAfv4QGBtYD40d6wVGjbC6KdbyLtfGPt2mio6kMDJjKeIIKy6HNfkbnolqkDKryautt77ALD0ViPWSTC0Fa0ubwSapFwGsmqLUmm6Cm8V/sDmz3jBk+XKPeJ5z3o+t4FDDS9/X1RWZD4UQ/jbhWQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 113e5bab92f8a054 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/2mLbPwCk6CUGlfwT+ymbglmBHkdaFitN9XacTQrbzDpFDjKHOyIj1zwqyykZpzuv2H4UIBeea7qiYCUMeYKZ0h8OX7u+5Gbh7TC0O1T1aEpJl+oL9iv+ChSmAmbEzexTcIGRDxq1QVpuwhwVNEcEWgbW2OYbvHsnQ38qHaRDX6KopRN+Q0I5gVYT8c//Aol06YxtzenZ8J9wGH4uLz7ZhAN3M/Wis6I1hlohFOCD/iP6qhiyJWtW0FAeSGbwF2+tDuL8PH2wIEleCfdt7pGbYpiF4e4RB9hZAKsECZ0TlYeHrHPVDOja+4xx2TbN5rxkEA9LEsJMr/XM0wuQbXRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShNW6fG4S+HSV39TrO3L3RCVPXUhCOt4kcszsvLmgMs=; b=R0oVX9Eaod100gJJnWayoAeIH8BJBSFjB6VchURCiv4HgyNjS/4MPoi14ELbmnXK/iGO4e53KXaWib+PV8/u6B6Oa9m0P6qO63IZZ3J3bBNTqzr9joYOlt3+/UHvk+t7OO2LFpzZIYiaSx5tILOO2y+32o416h3mA9fv7IKOL5QPE+9h5CcoJOOnwRF9WAvEE6IrMj5EgdZgVQ/vOteAWUSJY9EgVWW2U4Lahp79mDou+dozCY9RzLLA3xWgHl+80Ucu3S8gbh2RlFC97LdjT8MTG9VwwUmFlUbix2rA2sI4IZE1qHyAHvSCnxIEix1c4PgXEUYNLHp6Kswa6Vglkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShNW6fG4S+HSV39TrO3L3RCVPXUhCOt4kcszsvLmgMs=; b=D7sbQZgk/PjENqzrvpw8ahvOAfv4QGBtYD40d6wVGjbC6KdbyLtfGPt2mio6kMDJjKeIIKy6HNfkbnolqkDKryautt77ALD0ViPWSTC0Fa0ubwSapFwGsmqLUmm6Cm8V/sDmz3jBk+XKPeJ5z3o+t4FDDS9/X1RWZD4UQ/jbhWQ= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Topic: [XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET Thread-Index: AQHZRtMZk9F4kN2K/k606WK6T8KuQ67d144A Date: Fri, 24 Feb 2023 09:30:27 +0000 Message-ID: <6B714A07-F3D0-4F27-BA66-078433430B3D@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS4PR08MB7853:EE_|DBAEUR03FT057:EE_|PAXPR08MB6702:EE_ X-MS-Office365-Filtering-Correlation-Id: e37cc82a-249a-44db-796f-08db1649cbc2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vwaqMGsmaUpsFInWPjBUaV/CWjkkYWhwuKHPbNMraSYQp7BKzVxzSMpE4Nq8NHt/Uakk8fA8rLJxasn3JbJrljZfFALN6tKdGs4DSqjWz6Xn+BM8+Vx2yKG27EAjDcRB4Ak7ss3wmpzb8zGiJYj23YRjulO9tUBWt9QXg8XDS1D5UuIQBhw3b7KVuqnF4TjVzfFnWySTQlAwTY2Ko2G3XWhpI8rMzO6dF8z/jFxSW5tpT/WzCrt90FvbuV6P2H0mmzRONrY31/d4JsppzG1hnT2MeWVvdSaQujwCLqYPt6Cj9Tm07ab1CIqZiVNygrPos9g7Ciiw1LBECj9u2GbC/2530dTMwJ8Vj2viz9VueXPWKe4I51Fd5wFMnR8AL67BOXHSVKh2c9HEeEJ7U3vQz5HNdDD466wgM9fC7lLP6GA+4A8QeyhZaTRTfax8pLnUhH8nairTj2vILNQ9wcDrbA5F2S1bLBoRpkQIT7C3BkLWExH/q8BzhOFNeNLQTZ+qClb04VKLViB43yAKirawo5rpVEgejvEaSchUoZ3d3pDmZsjO6Fvfify4d3O578Bn5GvqrebEDTVsmqC+mfqqm3XRIRHBZNsKGUucauTNDQySNRPlAt24UVroNhWU0DNl27STtjV5yCjzrENJMSnl0LWBaolQENUFH2dMaJvw0ELipPW4BH+8+Ze5s8Mzexns6kOHgRMo5QYLUn4S+83sbYYHvwcwsxTLP3zNIC1YBpY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(396003)(39860400002)(136003)(376002)(451199018)(38100700002)(33656002)(41300700001)(4326008)(66556008)(76116006)(66446008)(6916009)(66946007)(8676002)(64756008)(66476007)(53546011)(8936002)(6512007)(6506007)(478600001)(86362001)(71200400001)(6486002)(54906003)(91956017)(316002)(2906002)(83380400001)(36756003)(186003)(38070700005)(26005)(5660300002)(2616005)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7853 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d78d1ac5-964e-445a-a0dd-08db1649c37e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZKQvVwz60JUdvccRPzPjrFWQHVJJccPN4oMp7+Oi05VuOFhzsvkEat0+DpgS3Wce0AMaULgE8/0wBAvCyT4hjLFCIWqgKaXfDIyH+SAXyXccAoq7Or6zDvadpsEhtp7zchRt4fOkn8/TmW1M3XlwmlYhybE9cgSpoB/sJUUock3MsdkK5W6/XMKTC+q5iclAH1OvEoN8Lfg3P0EX0JEdDQKZSxe1KgH3co5zwf1PA3XwYbY8PRxTiNlCUk20Of5Wyqaqv2MScZ7ijJ5oxnaNGJeiu+yvSknC+VWDakLRCHFfnI7JMZn+HdtAfh76wK2/mYuZHypiDWvr5r9j2KFI8etDDXF5MODgGXxlwfPhV85x5DA2Bk9AFhOLi8EzJNldi0gK/EEinPpgWi8kduFfrWwwTD5n7oy0kqbGdd5rN4I/veBFkmGsIlyRIpYShb9kqS14V/N4OOho0+DN6WVZiePL/YoCMRHnPj6nC4xef5lNopfzMbuoXRhAD5qZEED49ufkUpwc+OsliAYLsw/Z+yTbrrYvV6WEBSZ+W0f85tfhHuYWxndZPvXBt4Cwa0mEN40PZd9MKGUj2BAZzoOme4F9DC3P1f5C6W/2LTRFeeXEuODiQ3ld7ux3gUktSrhBJ2sHZ2EdSmF7Qaz4RD2SSoxFJjZSgO2/0fC+mNB83xztUhmLfywsehVPqLruzu9vJAk/NMCdp6SKE9oXuCqA5g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(39860400002)(136003)(396003)(451199018)(36840700001)(40470700004)(46966006)(36756003)(33656002)(8676002)(478600001)(36860700001)(82310400005)(82740400003)(6486002)(83380400001)(336012)(47076005)(2616005)(186003)(53546011)(6506007)(6512007)(26005)(8936002)(356005)(41300700001)(2906002)(40480700001)(5660300002)(86362001)(6862004)(316002)(54906003)(81166007)(70206006)(70586007)(4326008)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:30:40.9844 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e37cc82a-249a-44db-796f-08db1649cbc2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6702 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > Defines flags used for the function FFA_PARTITION_INFO_GET. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index aa6cdbe0a4f9..f4562ed2defc 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -56,6 +56,32 @@ > #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > FFA_MY_VERSION_MINOR) >=20 > +/* > + * Flags used for the FFA_PARTITION_INFO_GET return message: This is somehow no completely precise. Could I suggest to use what the doc says: Flags to determine partition properties in FFA_PARTITION_INFO_GET return me= ssage > + * BIT(0): Supports receipt of direct requests > + * BIT(1): Can send direct requests > + * BIT(2): Can send and receive indirect messages > + * BIT(3): Supports receipt of notifications > + * BIT(4-5): Partition ID is a PE endpoint ID You describe all bits until 5 but not 6,7 and 8. Please describe all of them to be coherent. > + */ > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) > +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) bits definitions are coherent with the standard > + > +/* > + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition > + * count only. > + */ > +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) same here. Cheers Bertrand > + > /* Function IDs */ > #define FFA_ERROR 0x84000060U > #define FFA_SUCCESS_32 0x84000061U > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 09:39:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 09:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500866.772393 (Exim 4.92) (envelope-from ) id 1pVUXw-0001qT-OC; Fri, 24 Feb 2023 09:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500866.772393; Fri, 24 Feb 2023 09:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUXw-0001qM-KF; Fri, 24 Feb 2023 09:39:20 +0000 Received: by outflank-mailman (input) for mailman id 500866; Fri, 24 Feb 2023 09:39:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUXu-0001pT-VU for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 09:39:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061f.outbound.protection.outlook.com [2a01:111:f400:7d00::61f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1aaad18d-b427-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 10:39:16 +0100 (CET) Received: from DB6PR0501CA0028.eurprd05.prod.outlook.com (2603:10a6:4:67::14) by GV2PR08MB9374.eurprd08.prod.outlook.com (2603:10a6:150:d0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 09:39:13 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:67:cafe::3f) by DB6PR0501CA0028.outlook.office365.com (2603:10a6:4:67::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21 via Frontend Transport; Fri, 24 Feb 2023 09:39:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 09:39:13 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Fri, 24 Feb 2023 09:39:13 +0000 Received: from a64373369177.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF014BAA-231E-4608-A634-FBEFC2293D88.1; Fri, 24 Feb 2023 09:39:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a64373369177.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Feb 2023 09:39:03 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB5571.eurprd08.prod.outlook.com (2603:10a6:20b:1d0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 09:38:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 09:38:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aaad18d-b427-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LtX+fRT9aF0cgsD/r6pLaSpb9wDi1/WXMmNDtc8YzdE=; b=rL8tRdiAi/xHMyqISQuhKhn42HyfJEf/z2efTKVsm6sErCaxbAkXIK/hk7TFdKgCkVosdhIhVgIf9dCjS4Tkvw5SXQUOlIflcMdH97RWVnhFr8NNBB34rxfjIILJrF5x4EQRlJL1wlbdzTKf7jRxJCupNtdDkjd358o3A1uTlfc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bc04bff6c9509a55 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcDSW3DpldOItYrs76q8XZPutzYiV87rnHFPRDda3cv6oqtTo7TZRkBjTo8qSNNh9aSiWdGp+cyyE5Axbr/hRlIKOhCOpuS+6y4wKZgo8q6WR2sxhtuFQgS2diMYhr18yaDV28N+WRBx5a4o7y0e0UbGBS96bzbUNPFAL4glE0DXWfv4nbXRO+GI0iuxDI1VtZaedST9mub0+ROD/CO+ZHdz05Eb+zfmA9tGGvL/DAX36DI8j/82iH8FXdC+mRUqrDFyLTFAgEK8nR6ejySuceyVezGvYadnsJJR8lIPoWGwJeLQd7n2j72QjZCBL3n+6josyu2xUvGvtWl5YiH3NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LtX+fRT9aF0cgsD/r6pLaSpb9wDi1/WXMmNDtc8YzdE=; b=SQ5N/P5MH0fRIsN5dcfT4LV1FmCi9tjeybkmBYDyhrVTf4FmPnkizd380Y8tRJD0PChPqoGzt+P4RmbbFFWQSrRnbQDM0Qs/HEvHhvsPNi2woN8kOr90JIyIL+b7Ylcfi5LMeymMWD2xriXoHRKrWNF9YvRj1ojgCfqd8l8SfL0QKGck1BJjQ/yc56bDrR9ID6TnU9DRITgGII5sIzXNXBx75Vjzx/PZbhVMOsZNFzms5eK2+SbmMUXHzKYm+6uFNmlhv3bB9Mg/eReKLXwVBgfZtHH0eUHj17KMAy2CBR48KlDuxquTxqDCjCcKq/M/zamShQP60g5E/9DFiCv6hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LtX+fRT9aF0cgsD/r6pLaSpb9wDi1/WXMmNDtc8YzdE=; b=rL8tRdiAi/xHMyqISQuhKhn42HyfJEf/z2efTKVsm6sErCaxbAkXIK/hk7TFdKgCkVosdhIhVgIf9dCjS4Tkvw5SXQUOlIflcMdH97RWVnhFr8NNBB34rxfjIILJrF5x4EQRlJL1wlbdzTKf7jRxJCupNtdDkjd358o3A1uTlfc= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages Thread-Topic: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages Thread-Index: AQHZRtMc9l4FLuQsA0eLhPi3rXVDQK7d2fAA Date: Fri, 24 Feb 2023 09:38:59 +0000 Message-ID: References: <904055064f4b4e4514acf1e64751672eca045c05.1677079672.git.jens.wiklander@linaro.org> In-Reply-To: <904055064f4b4e4514acf1e64751672eca045c05.1677079672.git.jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB5571:EE_|DBAEUR03FT049:EE_|GV2PR08MB9374:EE_ X-MS-Office365-Filtering-Correlation-Id: 17072fa4-e186-4055-8d5b-08db164afd1c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8f3h7GPciF05RXre8H974faTLWGu+Tl8KubOehupYF12vk0KTlOqtvfhfJazAzifMKCMgbfGB42RHGVit8j65HgW7egdlM6qAkjDFnNC+PjiZpE5f0zKr468mT+xIBl0LQeBIN1mousW3BWUl42BjV3Zg5wP137XWdZixo/nN6VFjErnIsobaWZhw4Eg+9uhaI+XRJmYYhLFFJ+ECFTrjMjWVnTh+0uA6vPGhuMZypAWh0qyteVvgw7JFEfViB9ehjUDldAIcMMbn7PhiDv2RjrdNT4OwY+ImGCxnCZPsrrd1dWyfeSZWAjtaCF4Wqs5iNNxaO/9I42/SdCqGlDeCamj28wuWuQ2IdcOHzrdEwP+4mNPstQaQmqePRTvGKQr6hHpsLPOrE0XSkZyFWC+9qB0ujahN4kMItactaRkzx/r/Hl0Vcq4ECrSntYzAPrzi4DqGVuFR5E/IUOI+OXAM/gGmC0+ePld2AoEvnwu73GqrNLyCkeAT0nmsTPgcB9OnQgPUQ303UWifulGRYTLaRzXMUlqOL/ud5rUP+IZU5k4avejzfnfRhj0uHPrH8yQi4i1A56K+Yb/k/rqUx/QoYTN4/5FViSpi0fMEh+71hj2fcwvZOu5rk6t4MynGWnq2DayuvfgqjJGpROSw29D1tVbUQSwooF8zmBeZtJRl7dgceBaY2SnmHvkxKLSYbW3a5dxu7WJiTBbS1kg1fx1F4redONqsTgP9jprz+piIG0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199018)(36756003)(33656002)(66556008)(66446008)(71200400001)(6486002)(83380400001)(2616005)(186003)(26005)(53546011)(6512007)(6506007)(8936002)(41300700001)(38070700005)(91956017)(86362001)(2906002)(5660300002)(15650500001)(316002)(54906003)(38100700002)(478600001)(6916009)(64756008)(8676002)(76116006)(66946007)(4326008)(66476007)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5571 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a98b8cbb-606a-43af-481c-08db164af4dc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZzdwaw8n0Ivxk7aP/H+Pd/fvzxhCRsscJdKJmSlHcWIcH7uYXZxuqRLRnIntGr/91O/KuWLo8/j4yuYJXzhluLr2dq9IBaOWxD6u3VjxvZpWS4KOjemUVySDdyDm6YwnJ9BSM9szBAplJbWNKG6GPICZg6rCqdnjmd8yWYSQhSGzksBDCZj8HZSHJ4jN/jWiNZyzVXDrTACwRNbTmoIoJ5TsWl5ZfvReVh3OJCuFmWJ9jLmReMDA1nvYBDDfgyFfEXoMWEiOlnq7g1bv9KaY3wHlRQjInOaRaywUKuGh/UkWcBwj1Yb5aCyuxKa3RNlAURup0+XIXl174zg+PMXqGvOdy5geOMTnuT8nEEQZuX5jPNQYxzY+i+eNyDpVYPqXNCXmxlMYqFD169KP+jYwZlTnCy6dgu8ZnARIIIWQ4paCdi2lW7GbV//vpPUvk5GPqCrc4UkyQIldAzW0Gqo1CFdjBk4AUr6JX/GSyElsSOaJ/jjhszi2VBC3ihDHaxVww/zCcZviMOg46hCMFnRQx7fDuXKk2IIOTNpbWoc2+bKSSwQZfHDVk//fSXWze6HagyCf2Yugic7jDVJWWx20bLiYEkMbduZZ8HODachUYMMVjeZGhnfi6CuQD0cBB78YSRiali93q+kUPJigN4NvfSlwKlK+XFHW8AbH+05pJhVAWG0RIglUQOkHcvEg6QloXkE09pwSmqS1jTPzEqLfg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(346002)(376002)(451199018)(36840700001)(46966006)(40470700004)(40460700003)(6862004)(5660300002)(15650500001)(82740400003)(8936002)(336012)(41300700001)(2906002)(53546011)(2616005)(47076005)(54906003)(6486002)(478600001)(6506007)(316002)(70586007)(26005)(70206006)(356005)(8676002)(6512007)(186003)(86362001)(33656002)(36756003)(82310400005)(40480700001)(83380400001)(81166007)(4326008)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:39:13.2798 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 17072fa4-e186-4055-8d5b-08db164afd1c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9374 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > Adds defines for framework direct request/response messages. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index f4562ed2defc..d04bac9cc47f 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -56,6 +56,15 @@ > #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > FFA_MY_VERSION_MINOR) >=20 > +/* Framework direct request/response */ In the previous patch you were more verbose in the comment which was nice. I would suggest here to use the same "format": Flags used for the MSG_SEND_DIRECT_REQ/RESP: BIT(31): Framework or partition message BIT(7-0): Message type for frameworks messages > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > +#define FFA_MSG_TYPE_MASK 0xFFU; Maybe more coherent to name this FFA_MSG_FLAG_TYPE_MASK ? I am a bit unsure here because we could also keep it like that and just add _TYPE to other definitions after. What do you think ? > +#define FFA_MSG_PSCI 0x0U > +#define FFA_MSG_SEND_VM_CREATED 0x4U > +#define FFA_MSG_RESP_VM_CREATED 0x5U > +#define FFA_MSG_SEND_VM_DESTROYED 0x6U > +#define FFA_MSG_RESP_VM_DESTROYED 0x7U > + > /* > * Flags used for the FFA_PARTITION_INFO_GET return message: > * BIT(0): Supports receipt of direct requests > --=20 > 2.34.1 >=20 Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Fri Feb 24 09:56:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 09:56:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500879.772407 (Exim 4.92) (envelope-from ) id 1pVUoI-0004rp-CK; Fri, 24 Feb 2023 09:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500879.772407; Fri, 24 Feb 2023 09:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUoI-0004ri-9V; Fri, 24 Feb 2023 09:56:14 +0000 Received: by outflank-mailman (input) for mailman id 500879; Fri, 24 Feb 2023 09:56:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVUoH-0004rc-4z for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 09:56:13 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2060d.outbound.protection.outlook.com [2a01:111:f400:7e8d::60d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7739d927-b429-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 10:56:10 +0100 (CET) Received: from BN9PR03CA0371.namprd03.prod.outlook.com (2603:10b6:408:f7::16) by PH8PR12MB7303.namprd12.prod.outlook.com (2603:10b6:510:220::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 09:56:07 +0000 Received: from BN8NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::39) by BN9PR03CA0371.outlook.office365.com (2603:10b6:408:f7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 09:56:07 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT115.mail.protection.outlook.com (10.13.177.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 09:56:07 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 24 Feb 2023 03:56:07 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 24 Feb 2023 01:56:06 -0800 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 24 Feb 2023 03:56:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7739d927-b429-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YvvpUla/Pd9RkuDofcTs2iX6qZNwARIoG0C4v6k2FItQKzBwv04GZR/MsHU9v71G1ytbAj/sIjJc2nZ8euLoI0uA8WWZE2lhsJZ3tqgeNdVP7OglQYtB2VlWnP+Krqe92L1LJl6fnUBBxfz2RdcjGRjGgGgfq2npFWQCSBcJ2CIHZOYAvYQBKETR99VLWL7vlAi97Jc8lhDaL/8pyG2/oZH/Lf9OKhswzQOTdUtwajiiQFTM3ShI440yFh4zoTlV4NMU+NPzYkMrNIybBFITYwyGfuz3i2AqCvvHl4BiDOnyUqo7+tQ9wmLm3Hu6cLQ7ckiXpnhnleKMxn7lJqXhtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JreF+hEZyg+r91C3CKlwJUx0ARm3Xgak1UcofWDJZYE=; b=Fw5x/+MTL1n1Bfael1JFPb2hLBnZ316GgDn1vyMIcUEvOH+S0ut1Y27jA0aK24V6Lxv+mU90z9faIsrBwvwmRaAYtcg4ney+PYTf8nFnCSjJcfr7iyD7kC40zn3KFUZoZPADPGmxkPxlgTYfQt1/gAAOfsUyZkaV1zm3kVp1w48ZraDHRUxHEdudF2o3lZJ4iYMCAnWqu9LGZsIFov94XYE+tg8IojJeX4TSFDly+/BfOPDzRbDds9LWjjBRQzDXrwP0BZ4EB/1fWChZ4f3ErKLEZ4EVvtPdPIPv+m7uL2t+oIJkZn/A1Q+4MTv1KRJNmFK3gjVVYBLmLIUEW1Ke5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JreF+hEZyg+r91C3CKlwJUx0ARm3Xgak1UcofWDJZYE=; b=rCn3Dl6onqvtXE/D5Pg5M3Z4/2Ht2XRMphTkjWHYSg1t6T57D0o4IjbOxl1gK3e3r9z8fXRF+6tPniw0vejXSXlElHtrTcOiFgSm/L2ntJX3FhLtIf8OAq3jCWNW8w7HJYvJAhYcKAFyHAgaakr17Z+e1tXFaiOX9ASRj4+EvX4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Fri, 24 Feb 2023 10:56:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/3] automation: add binaries/ to artifacts for Yocto arm32 job To: Stefano Stabellini , CC: , Stefano Stabellini References: <20230218000747.2965719-2-sstabellini@kernel.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230218000747.2965719-2-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT115:EE_|PH8PR12MB7303:EE_ X-MS-Office365-Filtering-Correlation-Id: 44f06183-1e66-4723-196a-08db164d59b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yfOsJg0m1mDuD6gqQtpLc3H70IG2/oROE2qOjo0rUza9R2P0ibVltnGgLWYmg5SgOs2A+0iz0j4r+ueoCTsWpWuhn6JTJz4T3avCQKwkqBEEslCjbQrkt0ynu+LkwxzotN27kWiS7phrlC9Lq2Uzuwez5G43UlH7QI6JX+iNYw+o31bbpX7hL78BI0sPP2OoyJ6Fbdj4+Q5iT4bUwrd+/6cCF/f2dsk0UwzopAJqBaaQO9EMh3DHTSNEnr6SjmL1WJynH+mQ4gmIYeUEZL+hpdBmEmF5Y9dVJdV1P5AOBXmBYVWwIYo5PbjNdhyqhsv4TigHqIsNC3p7BJDsgYIuq/Js9TQ3MNmrgzSRf+Ms6iJWGuHhSKkFo7MIPAb4TAd9I3bOuLl+kzUT8KMMrjKVlVT+/1U3CHiDcE29gxJqhfkHimZxnccNFl/IaoSfTYiSfa3u1BG/kC4B5QLO1fC0k6/J8116rZgL4W5zGXaiS1fGaKvLzBGCYEs8BgSTUPXx+gu4OKvbYiKudLduYG9GqKXcuW401BAA8SGymgUwdTLbD0p/QozAsQ5AHA9DR97TQNiaj4pN1UGILyHtAz1oddumKzUdeMcDQQpi2Duv+uLuC9Dz6gYLBP1M/H96St2KrglqAeiatVDmRcG7UxQTTYR7FMHA/a6xNkzLNHHhTJw5O2DHHBHt5VX8uLciwKxTrcaqpIUxxXnq6AK0LJy5WkfEvOapWoDHyYfRd2VeahPMtdP9R8mM2+4L+XN0AcfbLv/B6OJE5pgGdkiz3iDy8w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199018)(36840700001)(40470700004)(46966006)(4744005)(2906002)(5660300002)(44832011)(36756003)(478600001)(426003)(47076005)(186003)(40480700001)(2616005)(86362001)(316002)(54906003)(26005)(356005)(36860700001)(336012)(4326008)(40460700003)(70206006)(70586007)(82740400003)(8676002)(81166007)(16576012)(8936002)(41300700001)(31696002)(82310400005)(53546011)(110136005)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:56:07.5659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44f06183-1e66-4723-196a-08db164d59b1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7303 Hi Stefano, On 18/02/2023 01:07, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > Copy the build output of Yocto builds to binaries/ for the arm32 target, > and export binaries/ among the jobs artifacts so that they can be reused > by other jobs. > > Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 24 10:08:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 10:08:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500884.772418 (Exim 4.92) (envelope-from ) id 1pVV0B-0006nq-G9; Fri, 24 Feb 2023 10:08:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500884.772418; Fri, 24 Feb 2023 10:08:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVV0B-0006nj-CP; Fri, 24 Feb 2023 10:08:31 +0000 Received: by outflank-mailman (input) for mailman id 500884; Fri, 24 Feb 2023 10:08:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVV0A-0006nb-HF for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 10:08:30 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20606.outbound.protection.outlook.com [2a01:111:f400:7e8a::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2cd659c7-b42b-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 11:08:26 +0100 (CET) Received: from BN9PR03CA0657.namprd03.prod.outlook.com (2603:10b6:408:13b::32) by DS0PR12MB7994.namprd12.prod.outlook.com (2603:10b6:8:149::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 10:08:21 +0000 Received: from BN8NAM11FT095.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13b:cafe::37) by BN9PR03CA0657.outlook.office365.com (2603:10b6:408:13b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 10:08:21 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT095.mail.protection.outlook.com (10.13.176.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 10:08:21 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 24 Feb 2023 04:08:21 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 24 Feb 2023 04:08:20 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 24 Feb 2023 04:08:20 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cd659c7-b42b-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5vLm0zTr+Z2gyypUTrUOJ/3oVgjHEegARs44t68V5wT/q9ZSQ+KqYyk7eDIYLtKOoHzK0PeXBXfJ2sw4EoWjpnMfY1FK94nxPyutL8slavQhBCUjhbw3ge0hFsvALe+FMIvuwEIf3w7EEyTi8VgqUBp2n7y6wuVY5Py/NxdOHIo2+/+naHf6s9xa6NmI/4/3sLsMzKYqm1ZdBo/f1FZg4I+CSacb2TE9SYYgP1VvX60/ze3WdesN8tkqy116Cblkfu2MI9fwQHeucnowa9GapzlBgQTx3r1RmFS/IM1X1eNd5uLBzzLxYY44BZZt8IRfth2vWbA//qIu7e7vzE4aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l5NnKV5PC5nWIme5U/qii0TPnb2iwSZADvc62G5g428=; b=dJKzmU/2kOj5yT/FOupLAEXmUBkbxG2AxvY/4sWm9yWwSCmP9/22rvW/8R3kZbG3hPRWpfDM3yepBow9quQaExb183PY1/6cxSugzypZVyMAyEMUBR0EMGMcfKT1p9gO2pgvSNHjdT3JEooKd8006G50FIC7uFJ8ABHFA3wZObMUiT5HWTHAUOYxL5dmCXyCLluHYigk/7e5OLMk//X1DG3FpZTUMv8fCPQ6w3SKckfLcHQEBRL7vBF8qyB0Fu+r6tJMZQ35Hd24pToYjpuY6ZFJ8iAAQyh1nLI0tM9lY5LzeuO5+vOZUHfx5unNYSpsTtOF/wSLqOKgU6UOeSV7xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5NnKV5PC5nWIme5U/qii0TPnb2iwSZADvc62G5g428=; b=l81pznk9ihbfc+44TmecbfPTOKnHfyFvubwlBvCDYKXBQJglqhIGM8ZgwRF4d5TsVkgNTqgsyWuMgAGi0XuDcjTKtnLVYdrdSX3TmvD4Yiyf3zsFvCKzquXpjfC6f8PpksLPviX+PseesuEdK0Tl3qET2eXUYn0KUMo/STwmpxI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <34c7b0b6-319e-5dd8-28f7-ac2153c0ffe8@amd.com> Date: Fri, 24 Feb 2023 11:08:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 3/3] automation: expand arm32 dom0 test adding xl domain creation Content-Language: en-US To: Stefano Stabellini , CC: , Stefano Stabellini References: <20230218000747.2965719-3-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230218000747.2965719-3-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT095:EE_|DS0PR12MB7994:EE_ X-MS-Office365-Filtering-Correlation-Id: d7524fb6-11b6-495f-6d03-08db164f0f47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KMVCSkRkMmlkGFLdk/Dpod4oItqEeAnfWnA1tEzC28y3V5h8IzL9WZz6RkGES4Ue0G/po8JPGr0p9MWB7X3RpjBhCFuJLRqGfuK784hkTlNTnEMpPmEBV7miV3BkuJxyfsmBZUFJoOI9BQ+1NLjZtCXFeeyjKGVdqTmZyH2fX19FQKPkruZWOvt4GrTih8FW3qy+/F7thAuGyYkju1WmUElRZczCdBjIUxCK2c7nilaJVlNEaDmnD8p87aamfubjHouU9s0Yg4dI4OAqLyxJI+un+m103NVJS5+uOtLj/HPZW58SDUq3U04OP/RaTPwrE1DgopJ83NAAETPhPon7bMzobAp6BGIbqVb29G9yscl97XvLv3tDUYFv9tTWkLes0IiJSvWeQXOgjtvIM7xDG1oAdOP0eejhiWMlW+GWqb+3VI4uOqp9MZIZs04M93E/t0SD85aVkGq0Md1aJfhY+2XNbu9LGW1TfNZ87IuX+CxAEaHmwnrdWaPpcGPh/g7eqhLpa3t0TnC1yX7uECLCEtz90M/+apUiGvxyVocdJGdjKW2Bs51ewL8Rr2UputgnOF8GWXDhu7CmBa1lphtnClxdepMaYccE8lFKi6Z4wmK7mYPv+Ob71wIyenqRmFjYuxEinwXLN3frbv0/BYBTVxNqpP5nuyH6CfDj0K1lTOFl6WT5ZBmf1XMBG6JazRUG7MiVkTo/66N8bJ5QIOq3arYmGXs61+JuAXAWQABFPM/0n65uyGn/Qq++IDOkBDOgLQtFkp6Imxx3kz/5YScMoQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199018)(46966006)(36840700001)(40470700004)(82310400005)(40480700001)(40460700003)(2616005)(426003)(336012)(47076005)(83380400001)(478600001)(6666004)(186003)(26005)(53546011)(356005)(82740400003)(31686004)(86362001)(31696002)(36860700001)(81166007)(41300700001)(4326008)(8676002)(8936002)(44832011)(5660300002)(36756003)(2906002)(316002)(16576012)(70586007)(70206006)(110136005)(54906003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 10:08:21.7155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7524fb6-11b6-495f-6d03-08db164f0f47 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT095.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7994 Hi Stefano, On 18/02/2023 01:07, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > As part of the arm32 dom0 test, also create a simple domU using xl. To > do that, we need the toolstack installed in the dom0 rootfs. We switch > to using the kernel and rootfs built by the Yocto arm32 job. > > Remove the PCI node from the host device tree: it is unused but causes a > Linux hang at boot. > > Use xen-watchdog to trigger the domU creation for convience > (/etc/local.d is not handled by rootfs.) > > Signed-off-by: Stefano Stabellini > --- > Changes in v2: > - remove unsued debian-unstable-gcc-arm32 dependency for > qemu-smoke-dom0-arm32-gcc > - remove job qemu-smoke-dom0-arm32-gcc-debug as it doesn't make sense > anymore > - grep for both dom0 and domU prompts in qemu-smoke-dom0-arm32.sh > --- > automation/gitlab-ci/test.yaml | 11 +---- > automation/scripts/qemu-smoke-dom0-arm32.sh | 52 +++++++++++++++------ > 2 files changed, 41 insertions(+), 22 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 00273b21c8..6d09c97702 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -171,15 +171,7 @@ qemu-smoke-dom0-arm32-gcc: > - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE} > needs: > - *arm32-test-needs > - - debian-unstable-gcc-arm32 > - > -qemu-smoke-dom0-arm32-gcc-debug: > - extends: .qemu-arm32 > - script: > - - ./automation/scripts/qemu-smoke-dom0-arm32.sh 2>&1 | tee ${LOGFILE} > - needs: > - - *arm32-test-needs > - - debian-unstable-gcc-arm32-debug > + - yocto-qemuarm > > qemu-smoke-dom0less-arm32-gcc: > extends: .qemu-arm32 > @@ -244,6 +236,7 @@ qemu-smoke-dom0less-arm32-gcc-debug-without-dom0: > needs: > - *arm32-test-needs > - debian-unstable-gcc-arm32-debug > + - yocto-qemuarm I assume this was placed here by accident as this is a dom0less arm32 test. With this removed: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Feb 24 10:17:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 10:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500889.772428 (Exim 4.92) (envelope-from ) id 1pVV8c-0000CS-9C; Fri, 24 Feb 2023 10:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500889.772428; Fri, 24 Feb 2023 10:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVV8c-0000CL-6U; Fri, 24 Feb 2023 10:17:14 +0000 Received: by outflank-mailman (input) for mailman id 500889; Fri, 24 Feb 2023 10:17:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVV8a-0000CF-VG for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 10:17:13 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66780a8e-b42c-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 11:17:11 +0100 (CET) Received: from DS7PR07CA0022.namprd07.prod.outlook.com (2603:10b6:5:3af::24) by CH3PR12MB7524.namprd12.prod.outlook.com (2603:10b6:610:146::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 10:17:08 +0000 Received: from DS1PEPF0000E64C.namprd02.prod.outlook.com (2603:10b6:5:3af:cafe::3c) by DS7PR07CA0022.outlook.office365.com (2603:10b6:5:3af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 10:17:08 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DS1PEPF0000E64C.mail.protection.outlook.com (10.167.18.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6134.14 via Frontend Transport; Fri, 24 Feb 2023 10:17:08 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 24 Feb 2023 04:17:07 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Fri, 24 Feb 2023 04:17:06 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66780a8e-b42c-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z84RwlrJ0WOBT5d1YVs2hvziXEybR1R9IKXExzdDSpHJ2iMaq64FNTDi+ctFx/2so9B7DCGncgMkqJ4iC5KjzaikuU9Viaqz3z9re6xemPeD9F5W5+nDTtrjasDl95m8TqBamX3nnkWW1VnA5dOetw+liXYMPKWE1WbpkKr+fIpnSG67pznvas9XdcMXTL03+vtrVivpw0x3jUUgyRUDY1MI6+VoINh/houjlwDqwdpH4U/Z1g87t6Y4AhbELAfmdJlg4GUj2sJz/jsJqik7KcT+HzrUZuGu0PIDFMyY6QmGpzwY7D0BvHByiMm+HD4l432pV+6FLkb/l7T4Tw/zGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=61a/TSaClznaggO4+EgAcPq0tYybJpY9KuOG/x+Er5A=; b=hPX3pcuz8AIy6C9f75IXnBsZv3z/09Tdl3AJ5aR9cCjlhN7c4zp79Rif5VYQuUlIeyr2QOrhjBYE6DWDMbvBmt6cRg1EQkDsHAyWhZp7kITNN6FIGdyyug7/WTlUkySpGXzrMvp7k6EBY8PHRXPH77psvTuHMgenOgh14xMRkL3mTT6GYr7B+/7emlSa+KTJLP/zHdTycaURKLD4JRFFzUl1yCTEJa+VuNNZkWpF8euauQhWOa/6YGsnj7UEb1R5Tkviwg0kx3dGddFPZ+s7I/GzjzXeEl1ewXZBPcFepSBhS87jqASCM6dGbdDuOKIMyElmxCNbcX6e4h6oqd7IUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61a/TSaClznaggO4+EgAcPq0tYybJpY9KuOG/x+Er5A=; b=OSRf5AovdiZzyvy6srHfb315hRpAxkTe1ireguFNHs50kJA0tpWKHzk67Bvk2xFgZSSUuotXc6WWJL96weAV9WKX0ctY7k3um/8ogvlV2sn5DK3GbaGZ5yGgSQVhlBL9arHdzLBVdJ4c6RQMPYvZfDeUGGleWkvRcSjCfy+VRPw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH v3] automation: Add container and build jobs to run cppcheck analysis Date: Fri, 24 Feb 2023 11:17:00 +0100 Message-ID: <20230224101700.9032-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E64C:EE_|CH3PR12MB7524:EE_ X-MS-Office365-Filtering-Correlation-Id: af9b912b-9350-4ab7-b754-08db165048ff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u18iw8vpK2WuaMo85JJUQivg0CVyfUHov5b9IA+eYMeu1D4gtkPHFeD0fLnJPtZRdwL2Lk6SbDaAghVdfz5uolD3Jbud+wSeYhMXZKHe0bamLL41J+oDzBJB0rmVEPP9mm/6ElU0EvA8bWWh++RKN+h5eCv/uqYNKlRYB0qB2zIIUDN3hWsDdzwx/6EqFrvVoA8lCGmHG+dO+SuWuX9mg8+Jlfv5xj/bz5ayDxh43g1CsqWswxzABh0MWCfbJqg3q14OrT5vRa4/uEAEyX135W4BON1O7pVXcMv61p10mnDwUZdStrV7V8jGC4cGF6D2RGRTy3p4RHwsCzFqacHW8oMFAFhFGCrBog5Wi3CJkulexR94PFCYTerAFfKPNGPmSgTkEBquXs26ghP+pBnPu2HwOf5nkOa6qt9IQfb1AJHnUyUdLUN5m4NQuE+P/bbezJRacidOhT7sNfE0f4rQv3/PUhpmQ44yHl+pe3OCcA1uevmO8+xhNuhuXnGMZYVdDtk+9dnSwXKb/b1Ls+QG+q8AlPwjoOaAFbJMjlRgzQFdslhOOSgke1WUG8Qaf6F/NjAawsLK3wWu6of+qVYrnWd56hQSV35Pw3n9ECZxDkPpzE/OgpK+IE10qd8EUjeje2dOm5hUSWr0GYXbWWjzTVAPidVIWaQSFk8ZCIbF9ihCnwHj43+lP96U31JDaxMgLjjHOQ9C7uBbuu0kU//qXD0NoSBUOMwuJd2ATJqlqZE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199018)(36840700001)(40470700004)(46966006)(36756003)(82310400005)(426003)(47076005)(316002)(83380400001)(54906003)(6666004)(81166007)(966005)(478600001)(70206006)(40460700003)(4326008)(2616005)(186003)(41300700001)(26005)(1076003)(40480700001)(356005)(2906002)(86362001)(8936002)(5660300002)(44832011)(82740400003)(336012)(6916009)(36860700001)(70586007)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 10:17:08.0345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af9b912b-9350-4ab7-b754-08db165048ff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E64C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7524 Add a debian container with cppcheck installation routine inside, capable of performing cppcheck analysis on Xen-only build including cross-builds for arm32 and x86_64. Populate build jobs making use of that container to run cppcheck analysis to produce a text report (xen-cppcheck.txt) containing the list of all the findings. This patch does not aim at performing any sort of bisection. Cppcheck is imperfect and for now, our goal is to at least be aware of its reports, so that we can compare them with the ones produced by better tools and to be able to see how these reports change as a result of further infrastructure improvements (e.g. exception list, rules exclusion). Signed-off-by: Michal Orzel --- Changes in v3: - use multi-stage build to reduce the size of container - drop Stefano Rb as a result of dockefile changes Changes in v2: - use arm64 container instead of x86 to make pipeline faster - explicitly set HYPERVISOR_ONLY=y for cppcheck jobs --- .../build/debian/unstable-cppcheck.dockerfile | 53 +++++++++++++++++++ automation/gitlab-ci/build.yaml | 43 +++++++++++++++ automation/scripts/build | 11 +++- 3 files changed, 106 insertions(+), 1 deletion(-) create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile new file mode 100644 index 000000000000..adc192cea645 --- /dev/null +++ b/automation/build/debian/unstable-cppcheck.dockerfile @@ -0,0 +1,53 @@ +FROM arm64v8/debian:unstable AS builder + +ENV DEBIAN_FRONTEND=noninteractive +ENV CPPCHECK_VERSION=2.7 +ENV USER root + +# dependencies for cppcheck build +RUN apt-get update && \ + apt-get --quiet --yes install \ + curl \ + build-essential \ + python-is-python3 \ + libpcre3-dev + +RUN mkdir /build +WORKDIR /build + +# cppcheck release build (see cppcheck readme.md) +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ + cd cppcheck-"$CPPCHECK_VERSION" && \ + make install -j$(nproc) \ + MATCHCOMPILER=yes \ + FILESDIR=/usr/share/cppcheck \ + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" + +FROM arm64v8/debian:unstable +COPY --from=builder /usr/bin/cppcheck /usr/bin/cppcheck +COPY --from=builder /usr/share/cppcheck /usr/share/cppcheck + +LABEL maintainer.name="The Xen Project" \ + maintainer.email="xen-devel@lists.xenproject.org" + +ENV DEBIAN_FRONTEND=noninteractive +ENV USER root + +RUN mkdir /build +WORKDIR /build + +# dependencies for cppcheck analysis including Xen-only build/cross-build +RUN apt-get update && \ + apt-get --quiet --yes install \ + build-essential \ + python-is-python3 \ + libpcre3-dev \ + flex \ + bison \ + gcc-arm-linux-gnueabihf \ + gcc-x86-64-linux-gnu \ + && \ + apt-get autoremove -y && \ + apt-get clean && \ + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 22ce1c45e7cd..0835b7a65190 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -7,6 +7,7 @@ paths: - binaries/ - xen-config + - xen-cppcheck.txt - '*.log' - '*/*.log' when: always @@ -199,6 +200,23 @@ variables: <<: *gcc +.x86-64-cross-build-tmpl: + <<: *build + variables: + XEN_TARGET_ARCH: x86_64 + tags: + - arm64 + +.x86-64-cross-build: + extends: .x86-64-cross-build-tmpl + variables: + debug: n + +.gcc-x86-64-cross-build: + extends: .x86-64-cross-build + variables: + <<: *gcc + # Jobs below this line archlinux-gcc: @@ -679,6 +697,31 @@ archlinux-current-gcc-riscv64-debug-randconfig: EXTRA_FIXED_RANDCONFIG: CONFIG_COVERAGE=n +# Cppcheck analysis jobs + +debian-unstable-gcc-cppcheck: + extends: .gcc-x86-64-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/x86_64-linux-gnu- + CPPCHECK: y + HYPERVISOR_ONLY: y + +debian-unstable-gcc-arm32-cppcheck: + extends: .gcc-arm32-cross-build + variables: + CONTAINER: debian:unstable-cppcheck + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- + CPPCHECK: y + HYPERVISOR_ONLY: y + +debian-unstable-gcc-arm64-cppcheck: + extends: .gcc-arm64-build + variables: + CONTAINER: debian:unstable-cppcheck + CPPCHECK: y + HYPERVISOR_ONLY: y + ## Test artifacts common .test-jobs-artifact-common: diff --git a/automation/scripts/build b/automation/scripts/build index f2f5e55bc04f..7d1b19c4250d 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -38,7 +38,16 @@ cp xen/.config xen-config # Directory for the artefacts to be dumped into mkdir binaries -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then +if [[ "${CPPCHECK}" == "y" ]] && [[ "${HYPERVISOR_ONLY}" == "y" ]]; then + # Cppcheck analysis invokes Xen-only build. + # Known limitation: cppcheck generates inconsistent reports when running + # in parallel mode, therefore do not specify -j. + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra + + # Preserve artefacts + cp xen/xen binaries/xen + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then # Xen-only build make -j$(nproc) xen -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 10:50:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 10:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500897.772438 (Exim 4.92) (envelope-from ) id 1pVVf5-0005rz-W1; Fri, 24 Feb 2023 10:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500897.772438; Fri, 24 Feb 2023 10:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVVf5-0005rs-So; Fri, 24 Feb 2023 10:50:47 +0000 Received: by outflank-mailman (input) for mailman id 500897; Fri, 24 Feb 2023 10:50:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVVf3-0005rm-Mc for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 10:50:45 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14c0d1cc-b431-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 11:50:43 +0100 (CET) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 05:50:36 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5721.namprd03.prod.outlook.com (2603:10b6:806:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Fri, 24 Feb 2023 10:50:30 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 10:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14c0d1cc-b431-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677235843; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=wQW0tVFHbRWREiactdV7dwWmnC6byRBmE0FxAt33bi0=; b=BQmpnSSSzifi3ymjWaxbO1DHwXbEIHFqbOqXsXhOvuOdTyQNxWcH8+Ak oMIrLVgQ/c22n7gsFTpuy9Kx/FoqBDUqvSlA0FsuY3RWie73kzCOIiMXZ H40cS5SSrz3xAzXg61nf4bEwe8/SafCVUK1kuDrve2BZ9XNScFFHi5fPA k=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 100818965 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8nsIdK707wEii2sJlsZ65AxRtBXGchMFZxGqfqrLsTDasY5as4F+v mUdWGiOOvqPNDSgfYxzOY20o00O7ZHUzNJjTFY5/itmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mp NA1ECocYCy/3Ly92qqQdrVIwe4GFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOCF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtKTO3hpq803TV/wEQUIgUZaGaiucO2k2qPfuoGN 34a5iMh+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mqodsiBvKF45nCPTs1oWzHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:596/uq0fZcLKN12+xL6OygqjBLYkLtp133Aq2lEZdPUzSKClfq GV88jzsCWetN9/Yh8dcLy7WZVoI0mslqKdkLNwAV7KZmCP0gaVxepZnOnfKlPbaknD398Y+a B8c7VvTP3cZGIK6voSOTPIduod/A== X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="100818965" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D45Pcj2aUI63gbYEhHdlDtNZpuPWSKVCgd4y85kA6dyqwarM6OWzpaXpcqe6iFHIoPG6m4pk30wcQEwZ7+c9jhEv+0p3tlBUoIlLnFkc3rOx2cS6fVaxLiwfed+Nzku0WjYI70XBugO2mcGpPxZX47Hyf1afG8cCT+sxnH/beqe01BlVjwJQWoaHcIWlrcgafKtQG8M5pwHYgVvo/MR96ne0DwYy8e8WfoVyeA8VvZ+oYbtbht6bNKmmmgUJ35ShFI2uzCWe5cExwqEzwsD2/LI4ThFc44mKrrMs7t9QtoAFLcU23klLIMw7c4m82qkLiIetfBUQRR28AsuCPOpPng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aEWFSXOJzM0VAOxMbmcE5UR2SI9UuGakZIz+PDYLc14=; b=QDTGyFQST26eFoL0VoGAW/PxOata4oaatwWGNM4V7aywFXTlX1PfEEeSFaQgcbz7Bwhmf//0gk6wwKe5a4AvwHJLfT4ccIL9S1mR0VXBWNSE7ihj789uVnoN+3RgJYzKa+X0eDwqldkPf6Fnkqw4fi45QRnplczl7xn621y5yUK08EwG/uos3S9dZBrDF3FR3WDcqXABMi+niB7deNceRe6oxA4ptELR7jBCfplgrARjGd1zbzncln2zvITxAGJLAAvVSNsUAoRNP/QVtjrX46jw2JwVCsU5PVokvyCZKw43jg57/TJH7BmDg03K1xcfVE4u5xD4FDK2JoGIUywuPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEWFSXOJzM0VAOxMbmcE5UR2SI9UuGakZIz+PDYLc14=; b=s3s3T30qlUG1u6K0C6rkxanOCByA2AyYDOCQHayQQsA7IfJfIJc50tanAGqFPwL8M8XchlUZjCDhhRhJt5EftRIiXcjDqf11S7S4wTS21oFsg+m4cdvXpCqV1qruTEev4SgQnvbnM6gjus3Trd2t1pcRnoc8gBwP3Abn9mtHVGc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 10:50:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] xen: Work around Clang -E vs -Wunicode bug Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Xen-devel References: <20230223220358.2611252-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0210.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5721:EE_ X-MS-Office365-Filtering-Correlation-Id: 62a52780-7c53-4343-8dc3-08db1654f234 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OV2kJUd+0pAb9tQee60dRLJdhkDAr1srR5WEJyzRQgBcbNm5DF4nOMWgPffpEyrrEWiJOTjpGkMaPP0Aed4jjpPudrNDnXpENYcVZoSUPdpAkHZyMDh/UXech6GLoJhDrPQzSZEKo4FCxCh4x7uu38AswGmOBpePizYVzsryGg6+QVfQMIGuaoZHmIbImCQja6/MK0ACficlCl927oSvGa5Uhi9FOsSRGUYocCwm2GMbG+fGPPoBZOze4WByhgkRiqHl+yq4+hSiKLYFrctY5lDG8pIp4qed1MB5KIkp2buEHSApwwOn8T2/SvTqkVVK9WQaxC1uIz0RIukD0THJVyFH4Zc+CkiH9ETxwBdOLmEXe3S8y6ZuXebdI9cVxdDWMyNv80bHLroZeeUHEFzRTp0tP45ZzfLY/AtpEuU1pMZCgAepKMq/lWIUNEPtJcU4xhAiKrSBSSBEffpcjvuXJZyVXzaVomkZvQN+HT9kpkvBxvnEkvb66LWkfhUVddMgWRCp/0ALDlVaWDTI7ozDz2ghXx6juP1D/5vRMkxZm40krfrEZHeb/5+l4FmXtdB3Rgtp0eMqb7HcWTXSXoUgsNBhF1Dg6Qd3pEpj72tiYmnoLGyR10Veu8S+eU7rgLwO1jyeKtHFMAa+Xdudg//a7PnONCw5rFinJnjoFBJjOYjmaFvTFgYbKehfoTYoAIxum1ktS2gpTM0TSuLnpOwXH5D0p/nY+4MlylP77XpHAXw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(346002)(136003)(366004)(451199018)(41300700001)(31696002)(8936002)(86362001)(316002)(4326008)(66946007)(6916009)(31686004)(5660300002)(8676002)(66556008)(66476007)(2906002)(6486002)(966005)(54906003)(478600001)(6506007)(26005)(53546011)(6512007)(36756003)(6666004)(186003)(82960400001)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2pibDhRZUt1eVUydjl3em02bUt1U1prWHl6VUJkT24vd1pEUU56VGltbUZy?= =?utf-8?B?d0JOMERqR2tUcHhGcnBReVZkYXhHeGNLYkNQaGhIclhzWm1oMVArbXdjS3pp?= =?utf-8?B?UWJrUTNreEtxVDBOaEhqbmZjUE9yc0V5NEJoTU81OFFncWRqMDJ3bVVSMmZS?= =?utf-8?B?WVhJaEw5VDV4UStBOXZLUytxWXRKSkV6Z0pkSjFqZkdzSXBLVENWLzlDSGFR?= =?utf-8?B?cm1BSG9KZElBZjJyeXA4ZUhKUkNtdVRWKzBlUGRQZmR4OG83dDhVRlpGVlVt?= =?utf-8?B?THYrNG00TkViMmY5OHdreUVFYkdOaVZ1VEx0L2ZnNGx0TEM0UGJpTHp3T2Mw?= =?utf-8?B?U20xdGFWV1BzdVYvMC82eTBldG5pNjNkOUhhTFpGYXJSS1UxakJ3S3hGRlZW?= =?utf-8?B?M005ZFY1M3luRDQ1T3lHa0xNN0tUaGx1YlN0SFVTN0FObnh6UktpRTcwdmJ2?= =?utf-8?B?RjZXckxXU0N4dlVPMW9FK2JqMU9mZHcxNWVrNFRHNEk3a0NHdW5BVi9ZekJy?= =?utf-8?B?Tm9HcFNmWTV1ejJDYko2ajBBQ0k1OHV5UmJoSHF6aDBqSEVUaURLdFp5aGlY?= =?utf-8?B?a3pQaXhCd08yZTFkYzZaRnQ0K3ZWaW5pVWpXR1VWUFJTSTZlZDYxL0x4Njk2?= =?utf-8?B?QXAvcmcxMmJyWkNLb2h5T1ErdlJ0N05VeGVMaVk4dFU1WHcrMS8xRzd4bW9D?= =?utf-8?B?SHFvTElIRzgrS29tMW1MNU1CVHRIQ1V4eU1TdzMxRWNqZHZnNXhyc1AvN1RI?= =?utf-8?B?c2JBR2Y0RUFOMnVDZ2FLUG0yUElYQ0FPd1JiUTREVXZyTHVvZ3pwemt5M1RE?= =?utf-8?B?VWxDWkVGTkdBaENYeGJ3YWJjeVF6RnJXVEFPc2pBU0tZQjZhMmwzR0VEMXB3?= =?utf-8?B?WUF5c0pFQ2dIUHlKR2FUeG1ZelI2NGxiZmVGNnlWRENmZURYalByNlJjMHY1?= =?utf-8?B?VmdmRXlzQmdnTUk0M3FHVmxBK3k3bkZHbEJRU2NnaFh0RlAvTlBHNVI2ZDhl?= =?utf-8?B?allxclMzRlJDbTlGSGhBWEpURlk5cmtnOG8xdk1nUndva3F5c3pEKzVZZlR5?= =?utf-8?B?U1hyQWhBY2FURVNKQXJtQ2k5elh6RElCbEh2bjdOdWJHeFBwQStBUVNTalNH?= =?utf-8?B?U1NMTmhUUnZhYkRXeWxxNUZaS0lyVC93RThwSEsrRTNLdDd2UGIzN2MwaFVU?= =?utf-8?B?elFDcnIzQXBHV2c4NkdCSjFqelVCQ2VPTVVBR3JaRldkcHhWT05PRUZPTnRF?= =?utf-8?B?ekx4dkYyL0h4T1kxSzhFMjliUFJsK2owRFQ0b0Z3VUpIejRWdmxVMXZITEhP?= =?utf-8?B?STZ5ZlRmUmZWSWdLZk14MEN4SUF0ODNkalByNkw5ejRDdkVibEtMenlLc0NJ?= =?utf-8?B?WW1GRVBoWHZkZEd3WE1kaEpwUnJieHIxYVpic2VMMVR6YVFsRkx0b3JUd3FI?= =?utf-8?B?Y2pxOFFTSHdRS29zOGVkYnphNFlSR0VWQTgrVnZYdDhBNEhpUkJNbDJmcmZT?= =?utf-8?B?TnpuUEtGc3Z5Z291ak9iWE9EM0NzelNHa1hOUStZeFBzWUo4b2FGSnZFZWRK?= =?utf-8?B?Zkl1Rm42QjJ6VzQwNkxaT203MlVJK1VkWlIrRU0rVlExcmFKdnhuU0d3K3M1?= =?utf-8?B?ckU1ZmdzSXY3ZGdYaklyQzdxRUZWUkFqWXU5YUVVTm9MNzMxazB1MEVYNjM0?= =?utf-8?B?Z0xWcUI4SVFwQ3dYdE1Bck5ValUzQk9WYUFDT2hCY0cwK0pWVzZCNVJreE5y?= =?utf-8?B?YVFhKzdtV2FKSkpIQitYSU9OSWVBbU43KzZYVUZmeW5USWJLYi9SdE9DK0F4?= =?utf-8?B?VU5UVTMrYWtyRGNRbDdwM2NENUw4Tjdpek1xNmJiczA5NURrUWFYLzYya0lV?= =?utf-8?B?ZmNRd1NndzRRMzQzUCt6OE1wTHAzdzJ0Rms2QldYUmducVBPVWE4TGdOUitF?= =?utf-8?B?MVBmZS94WE81N0FXNTdVWXhzTjBYY0oxK2t2TFZwMFNWbDNHWEJqOXhWajho?= =?utf-8?B?Y2VtcWJkT3Q5L0lKME9mK0RtTHVPdnpIUklqTjNiMzlJbGp3KzZReHIwOGRp?= =?utf-8?B?TDlyQ3lOOE1CZzRYOTg2YXp4NU9WUVFhamI5YlBLRHJHd21Ea25UcG9qY3Vy?= =?utf-8?B?ZXU2Rk1IQ0ZNSVFPTURCM0djWGtCcnVhcys2cFpCckRkNnJuYjRyNXR2RjNl?= =?utf-8?B?ZHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /anNION0lCyHAe08Q+AFgR/ewnwhLNWkLngR1ja8pHDRnHXs/fq84MG2kDKLngvnalmRUfGFVWdE9pV0fDcTlZ+J1wLn0QRZSafot2MVRKWJ2jp2uHurV6Jnzj/rhCr15V5Suxv993gOk+edlMw0dyqMrq4HmDihwJsp6nJVkrNpLM2ptTTu6uYd3diR/MLRh34FTCu+mTVUpqc5nPWfiqAqPKHvbD4azEnRCfh6LvhnmlA+YAwLR9JSTxPttC3dhaVvBi9K2Ohghen5m3a3fOyg43HwmWxO8xjU3gPDB/bXVJs56TJjr4E5n1csNmt943hHiFtxKT1lmLYSiphWNb0aWfeJr73es2Br8SW2kkoXctQQD3CtooX8ccffIyRVlbJKg32dGtHewVRGak9KW+Br7gmljoV/d1G/w3tBWKaGU6gHq1+veXbuOGgIKAo+kdX2GPDalyXZZpqqx9s1Ckirm18rRblf4GvkeWIYmCisqgwtDlVQUWcIjlnMecvyIFZyk4iBGc80RyQ8nt9KEaQbsM8y78VaL7IbvASWM64cbNL+A/CX50ZmzbZOPLxOW/ddM1U5LCblALMNyFCMn8LG03gB1RsxQKcwcdbPI3KxQxrH7JQOjgVz0hVU8oHfFtFw97g0ikeNv5/Z8l1C6k0J+GUduUnr0Qy8L0qMfw69sYkrokAZPaWMUqxPi3YNndVd4CNWNLLpG6p9wAKId9xeV23SuLwr41h//zeqx13oVFG8ys49jXdfjWRkMM2tgZbQWjkYiDqkr2SZerCjCemrBaUJ7V/Lkmoc73n3MuHkSSk10UQQG8bFTBxQ4uVgqEApqrbSe++5ROPo1Vrd/Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62a52780-7c53-4343-8dc3-08db1654f234 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 10:50:30.2932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FVOWq52ZhInJTQ/BpBEEZj9iTLjctypkfC+2xaXBcssCVNAX5u3CHxFbvPCYkWAZd6q8HZlbu1+lEpO7NpRuSjWggRbZQHhczTK2UJdjECA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5721 On 24/02/2023 7:27 am, Jan Beulich wrote: > On 23.02.2023 23:03, Andrew Cooper wrote: >> https://github.com/llvm/llvm-project/issues/60958 >> >> While trying to work around a different Clang-IAS bug, I stubled onto >> >> In file included from arch/x86/asm-macros.c:3: >> ./arch/x86/include/asm/spec_ctrl_asm.h:144:19: error: \u used with >> no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] >> .L\@_fill_rsb_loop\uniq: >> ^ >> >> It turns out that Clang -E is sensitive to the file extension of the source >> file it is processing. > I'm inclined to say there's no bug there in Clang. Gcc, while not affected > in this specific regard, also treats .c and .S differently in some perhaps > subtle ways. This part was just an observation. Whether .c and .S should be treated the same or not, this -Wunicode diagnostic is given against something which isn't in a char/string literal, and that is a bug. > >> asm-macros should really have been .S from the outset, as it is ultimately >> generating assembly, not C. Rename it, which causes Clang not to complain. >> >> We need to introduce rules for generating a .i file from .S, and substituting >> c_flags for a_flags lets us drop the now-redundant -D__ASSEMBLY__. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:18:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500904.772448 (Exim 4.92) (envelope-from ) id 1pVW5W-0000rP-4Z; Fri, 24 Feb 2023 11:18:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500904.772448; Fri, 24 Feb 2023 11:18:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVW5W-0000rI-1c; Fri, 24 Feb 2023 11:18:06 +0000 Received: by outflank-mailman (input) for mailman id 500904; Fri, 24 Feb 2023 11:18:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVW5V-0000rC-D5 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:18:05 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20616.outbound.protection.outlook.com [2a01:111:f400:7eaf::616]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e747b34f-b434-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:18:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9208.eurprd04.prod.outlook.com (2603:10a6:20b:44f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 11:18:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 11:18:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e747b34f-b434-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVopxcYGVyWDyOzRKR6+fCRnqTUv7WabRF8JeyjyqUu20pkjAKjkl/+x6W7QM4lJQwCVZ/Sv5JKuPg2XoVw1vx3tykMVtKHk4zAPyENEq0SmQy0E42zRuiaacypEGdqAr6WhlVjPKSDo8FHiYiOqDyPfnTMP1HAO9zmGt5DrsGnM/CZ7+adABCnRhuazMqs+UWDC9HJ+pEpqNJ+giO4CHWxVSwQH0pt3WMAdiypOg1mwKLYFj43Fet/oXlolre1ncigE8HWNe9Zvl6VeB4nLJc1a6k4CedGCid6r6gWIMImyFYVb4i4kihutZNV8IYnKycwqFm/3nXB7sv2Ykmdh7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XQe7NUCwpXPD6Tur/KcP0YWIbGixxBBFMoamjTuI6a4=; b=RMmDiAHq8Zk13HqQZ1Q2HJe6cZwfjgnvLlQKJUeoWgTOKUfos8eAnpiV7apm05vLHYIhP76L/zzC26yhUGyrF8ffzY0bTaFAF/Bt2BCCYx8O0KpsxfUDeJXtlsobsuaKljznqgsMAwB9cUeN90Wjbz+iPITtjn0cOP/VS12AopVBOc+TICYC4mT+fYhOUwd+QDtiV67doVxQ1gDaMpYL950v74RsLbl3ELLGmrn0Osg66s7UB0BjsJ+nBpSOKihifpIEp9jx/Vn9uAbUEcAQ02CzSNqqBaRotB3qPUaQukqvDzTd7kmLaIu7DlncCAonW4wS2QhtbKhK+bPAX908SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XQe7NUCwpXPD6Tur/KcP0YWIbGixxBBFMoamjTuI6a4=; b=XfZAgtA9MigkMHiNfeT5jRHmi5ieeZifF7SXxpXl2EjIZ4V9E+v1ZD/+GdYG7FCAj4SgebxB8BMErSvfFw01SLqxt32pHCG7tlmjWPLVLxRnB8r2PnWa4N0mIazQ2l1u+eaePXtigFG21IVaheH2oPhQlWOQi9iIJXZvbqTJO419cKO/xYQMrT8BU6vMU1kVTEN1RKu4EUc9SSNSnJb3GbpcHwVVy1lktHnhkuQ0CiCNsHBXgMoIO6n9QQ1XgzHvJ35PyD1Z5Vr/AQ3H7Tf+OqXxShOI/JNCJjpcYcWuJ1e+61C2eBg8tLrCCb4hyGMYINeKWL43mNYy8Ca3mbo7PA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <372e227d-a18b-fa76-d62a-4321493d8a24@suse.com> Date: Fri, 24 Feb 2023 12:17:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen: Work around Clang -E vs -Wunicode bug Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Xen-devel References: <20230223220358.2611252-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9208:EE_ X-MS-Office365-Filtering-Correlation-Id: 65f36b24-7051-4bb2-3f24-08db1658c99d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yCN4hVlJRlS0STAcFFJzf4O49sA8Saie8loF501t95e0GwbToTeo1j2EZeTzcxC+pigCkFndcmPwE/Yk5XvZunChuK52bO2GaA5wB8RWE4Ictp7yP+YU8czGJHNMc5Vj2MELOpCF81lNr2QWTqPxS8K21rmYjkk1BKDqL2SFCrFPKqtEnpCfpoOa4rfYQAptFvDKSa/NTQhnqMhn8XAjxxzDulNgrt08iyG/9rHhYqIu6MdHjjv3Z8E3wBkvkdnhKI3AHaVegqONgwF2btwmi2KOlziv0p37jau0PQyZrwLwg9Q8+C1Df0aMN+ZudNJ0AxSNb+eYNPZE7O7GWOicN+igzCIRY2sK2yNX+psFxdYgS6iAfXP7M+VWaBxzQnKMAaKOsXlP/B6AQCwt7vqCnBLIxgW3ywOxCi4FguQERKQrvJ8Z0e2iaUbhOBFSV/26HHTfv5K1qb881+g8+Ru2CH+SFLRg4n9qsNny+/mYTYm58NR8/bD/MymAzLxF15vDZxDkWYC8jPZuDGsf5b/l9Ah8Xi/xaBXLSLFvltPQoPi9mGGnSEWF/Hf0HXQ5Tt9eHQke2bngjcfW3mxyubF0aeQGmna7DWq/nvgMXspQ1AwunGdeKmRQ+uvwneGkHO0RhKjFFYoprcJQW29jfrCiF7kyVCuK8jYTiR5vBoL117187gNB2qiXV7E/QNjTVW5RL6eo/XjReZNwnnui/BS7ElFKLVP13Jj9Ne1h20sUZzk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199018)(26005)(54906003)(316002)(36756003)(6486002)(966005)(6512007)(6666004)(6506007)(53546011)(2616005)(186003)(478600001)(8936002)(38100700002)(86362001)(5660300002)(2906002)(31696002)(31686004)(66556008)(41300700001)(4326008)(8676002)(6916009)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0laQ3FxclpQdE1Idk1zQXRuSHFGcmtiSjZIdlppTFREWXU2RG4wZmJGbnc5?= =?utf-8?B?YjFyYm9lNUptR0cwaU9RZmI2VFQ5cmFSbmR6SktUVHc5Qkw5eVlCanBhdkd1?= =?utf-8?B?dGdoc2tnSXhiRGVpL2loY0tWcmlEQXpjTXNoK2pBMmxXL0xaNzRPdXJIOEpJ?= =?utf-8?B?YzFtTE9rUTJ6K1FoMk1zeHJ6ODFHYytBOTRVMHl0ZXJqbzVOUDJSL0tNWDli?= =?utf-8?B?L3hJUlc4c2w0YWZLMlVFaGhYV00zdXc1VTdvMXVXN3UzMys4OUd6TFZKUEFG?= =?utf-8?B?ZkV1d3VDNmV2Z2pWOEdPb2crcjZlSjdOYk1JTkV1cWU5OVVPYTNsTTJKbjBM?= =?utf-8?B?NjE5SVB5ei96MURUblhWK3FvNlBFWUtqL0ZFNWVwTzcxY0t5Qk5VdmdaN3BY?= =?utf-8?B?cHVNZWluWXNsOEZoNXkwSXg4UjE3N0Z0WFFjRGFKbUhadUNTT0RlTzQrMHND?= =?utf-8?B?YzROQi9vZlMva2VicXM4QSs1cGhIMlkyMG5VQ0tvN1R1bFdScEUvMmpNNFZV?= =?utf-8?B?Mk5DV0xqNnAvdjM4b3FiTmRSSUZzN3NZK25sVHRubXQwWnJhbUdJNHp5MjJj?= =?utf-8?B?TjdWZmV6OWpjdXJQR0JuZys1Vi9OYlpGaDlyQ2Z6WkozSStVeHRVeDBUZmEz?= =?utf-8?B?MlpGQlVPVG5WVWs5elVadVdzazA5SU9pRzdjWVlGSzlXTmhnN1lPb3ZRS2hP?= =?utf-8?B?eFNtekt2ODJBSzBqZGx5MFl6emlpSXBNb0ZqQlZBTjdjeFRjL1hLUVdhK1J4?= =?utf-8?B?V2dtSHZOQzV0K2gxV2JoVFFjUWN3ZUFOTkNlN0w5dnRPUDVsVEs0aVg5NEdi?= =?utf-8?B?cXFTa0RvYVliTnF2aXh4ZkpoK2JmaTNpRlFUUDVyTk5aU21xVGZzU2hSRWN0?= =?utf-8?B?Y0U3YlNteDdvaEhYa0w3U3ZYUmV6VElkTitOcE9XazlSODNvYUFIK3Era2hI?= =?utf-8?B?cHN0VXMyZW12RE1Jb0ppTVQvekE1c0RWR3duVERTbXhJdlphdHJ0R2ljVUgv?= =?utf-8?B?RnFjeEF0WWRpQjJBNllEU0pTcTRKck9jVTVQMitmMGovTGpyVE03bndvK1Zm?= =?utf-8?B?TXNlRXFwaWZ6SHR1RUZQSFRreDR1LzRrU2VIUlNTR1pza3YyaEJwVGdJbmZC?= =?utf-8?B?NnRvcURsS3RwSllmdGNFTHp4V2tMZS9qQ0MvSXc3M05GT1pETGZWbVZ1R0cw?= =?utf-8?B?eGFiZ2J1bnl3UklRSVRhNllmK0dmcWV2Y2RMczIybmUwTlo4bjFDUk42alJD?= =?utf-8?B?QXRhWG5jMlBnNWNTS0ZYcXp6MFdaMkI4Q0xrLzBCbFI1ZVNIdlBCazViMEVZ?= =?utf-8?B?N3FJMi9iemNZSDM3MEpORlIwRTkrc0Z6eCsyaS9ROXlVTXljbEovaW1ORGov?= =?utf-8?B?TExYaTNwNThVS0pxTEVnTzFjd0YzWTNoV3VBc1JYMVlEUFdHU0oxVmVxQjNR?= =?utf-8?B?OEh3Y2YrYVQzR2JnbVZMUlo2N1AxMkVUbGFEaDJKSDhPU3JlbkpRZ2ZLcUpy?= =?utf-8?B?RXRkZGhjdDdlbFMzcEh2ZEhsQTM2NWhRS3dYcWNCU3dwRitabWs0SnZIQUQ0?= =?utf-8?B?YTZDUWdqVDdWTEkvdjRQWWp1ck1QcEoyU2ZORWhvaWRjcFNJbmdieUtHQWtU?= =?utf-8?B?WVJERlN4elhXYlBDUUFQNVRsR1dxaXhReHhxQ3phdUV3bmIwZWhMYzc2bW1Z?= =?utf-8?B?OUJSV1RtbzF4S1UwczJNZERGdXV0cEdlYW95S2h2ZmVLQ1JiOFVGOEZ3TEtC?= =?utf-8?B?bnV3VHJZWUpqT3J0T1NzUklLTzByY2oramIxZHg0WWZ3NDV1WXY2Nkl4WEhh?= =?utf-8?B?RUZla2RUVEV6L001K0p1OW5ibGRWbVZSc0YrbXdLemhWMTBjdWliTlFsVDZG?= =?utf-8?B?NEhkQlJVUjByQ2tEcENqaTgxYzFXZWpZQXU4Z3cwQWxaR21LMXJuOVNLQlF5?= =?utf-8?B?RnFlVDNoOVhvVFg1L3lVanl4QXFSaUpBUWtxZHcvZjNZa0ptTU5IWHlkUWdi?= =?utf-8?B?S3JrUGpmY00xQ2lkamthdXBDSVc1aUFObVM2QXorSmtOa2dwL3hIVXFKd3FY?= =?utf-8?B?Z1NwK2NHaFRoWkFTTlRCWkJXeUdSeVQxRjN6SXZnMFkzQUhMWXBGR3RUeUpV?= =?utf-8?Q?y5uM0kDDWKor3Kw+7Qre/LOQR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65f36b24-7051-4bb2-3f24-08db1658c99d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 11:18:00.1172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AQWW+m18KP2TEe2RhQ54Zxdug7MJcODIKiZwyJwEarchGBmeg+u6dcFNWwsHZQitH9hxvPW/GoNpAr9ekZtdow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9208 On 24.02.2023 11:50, Andrew Cooper wrote: > On 24/02/2023 7:27 am, Jan Beulich wrote: >> On 23.02.2023 23:03, Andrew Cooper wrote: >>> https://github.com/llvm/llvm-project/issues/60958 >>> >>> While trying to work around a different Clang-IAS bug, I stubled onto >>> >>> In file included from arch/x86/asm-macros.c:3: >>> ./arch/x86/include/asm/spec_ctrl_asm.h:144:19: error: \u used with >>> no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] >>> .L\@_fill_rsb_loop\uniq: >>> ^ >>> >>> It turns out that Clang -E is sensitive to the file extension of the source >>> file it is processing. >> I'm inclined to say there's no bug there in Clang. Gcc, while not affected >> in this specific regard, also treats .c and .S differently in some perhaps >> subtle ways. > > This part was just an observation. > > Whether .c and .S should be treated the same or not, this -Wunicode > diagnostic is given against something which isn't in a char/string > literal, and that is a bug. Why are you thinking of only string literals? Gcc is quite okay with void test\u0024ä\u00F6ü(void) {} yielding "test$äöü" in the object file (I haven't understood yet why it dislikes \u0040, i.e. @.) Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:29:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:29:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500914.772458 (Exim 4.92) (envelope-from ) id 1pVWGo-00038H-6X; Fri, 24 Feb 2023 11:29:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500914.772458; Fri, 24 Feb 2023 11:29:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWGo-00038A-30; Fri, 24 Feb 2023 11:29:46 +0000 Received: by outflank-mailman (input) for mailman id 500914; Fri, 24 Feb 2023 11:29:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWGn-000384-5V for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:29:45 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86abedf7-b436-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:29:42 +0100 (CET) Received: from mail-bn8nam12lp2169.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 06:29:38 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6753.namprd03.prod.outlook.com (2603:10b6:510:120::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 11:29:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 11:29:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86abedf7-b436-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677238182; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=kgcxkP9caO8xC6csUiWVoP2Y5IYSOj2kLc+JSMltAfk=; b=BJseNQjelXohSMSe/UgEY/WQcMUd81oVm1sfBuMsQjxyqqDzM8i/cvq4 tUZq1qpAchp0iIIG3oM9mxJ62JFm8Y7y14N42yaBUdox0kxp8g2mo6+Ns aC60gWWVb3g8WiXTtjZFw7Jo25UR1PgApEuqovD0NdGCHid2pA1+pQ/DJ g=; X-IronPort-RemoteIP: 104.47.55.169 X-IronPort-MID: 98806997 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:N55IeKmbP5sXUZn96y+uTKro5gyjJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOUTzSOfmMMTSnf9AgPYWx90kBuMPXydUxSAZo+Xo0RCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dAqBhY8d0jdvPOv3OufUMVpu8Q4NfC+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDRO3gqK873zV/wEQ6LxgdTQKdhsOcsRKuRI1vF hIf020x+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqWMMfZQ4M4t2mqodjiBvKF4xnCPTs0IyzHizsy TeXqiR4n68UkcMAy6S8+xbAni6ooZ/KCAUy4207Q16Y0++wX6b9D6TA1LQRxa8owFqxJrVZg EU5pg== IronPort-HdrOrdr: A9a23:7EmMDKmAc4w3yGCdFCo+uWhHDUXpDfIH3DAbv31ZSRFFG/Fw9v re+cjzsCWf5Qr5N0tNpTntAsa9qArnhOdICOoqTNWftWvd2FdARbsKhbcKpQePJ8SUzJ8/6U 4PSclD4erLfDxHZJbBizVQy+xQu+VvKprY49s2Ek0dKj2Ct5sQlzuR1DzraHFLeA== X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="98806997" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i6LvHK443hmK5Kl0Uisc8Jl6aSbk/4zsMUOYWzNgPCePhVQ6RxdoktFMpG/cUxBoB6hS9MftaJ8IVqGESK2s+1EnOZB5nhfXjGVHZ3td4sgSKD83kkW9x0Lu1KJXrtVfflJLUMQEsz9b3px+OSSc+5gxd3o9FLpr+I5Ix7kh/4VkX8nzvanYuoTjhuFoWAK8UIrSvEB1ZqfrgffjNLL6LuandJrWC4THwYSLQZGGwAqQ2VsTCJE64sCUGWxUAOJN/oNl8Wj4cZeRkQrrwTTYhJVFruo8H1msu4caVn7WKASzH0yiEbRZVoybdcXmwxrByTQ+dkuHyEtsAtpq6pdLXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R39DJEougWpSxEFIPwBYJJ4S2mBajUEhWNIfe6fTpHc=; b=MrVmwkjs5sK+YkSe5kxAQaJKnr7I8y8AGn48TgHYNF56Y9DqFSP0jw/YZP5BQpD/dnTT8BIRAy6owribTsgDpTgRNDSs0UvlxwnlnBir+TbOb1X5vU3zYVBl3jy8YYR90qSifkKfG74ewYAjuzMfhvNlC5ZKpOuI2YxObvrdjSl8yZGW1wRxWbp/bXfHFaL6ozxOwLL6alDad6RHV0XJJXBOJ5wjcBGurYcK36Y/H+Hnt+ME3vblppwxoKqtQ8Ts1IFp0ymELFJ6Xf7oL+H8kUSd4qVfXIH0W45UX5/OQM65NhCS6qXoCC7skj1A9mp64JO6ILHV5z1sihnxNcGE/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R39DJEougWpSxEFIPwBYJJ4S2mBajUEhWNIfe6fTpHc=; b=glBHDcPG8AKqbFc5i1xvorCpKdhT4iHDbPqPjeolATJ7JsmdxxLNJmDBw56poBvcDREpQHK4JHYleOdiUjVk8fpmm1lcpl6myer+NufYOrc+vH5KIQUpCWMV50SxK4NSliHqMmg50opVIrbqnvHQ3fIlXUwLEi9R2SAUKmez1eA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <460a7e1f-dbc2-4948-3ee3-434832db4283@citrix.com> Date: Fri, 24 Feb 2023 11:29:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] xen: Work around Clang -E vs -Wunicode bug Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , Xen-devel References: <20230223220358.2611252-1-andrew.cooper3@citrix.com> <372e227d-a18b-fa76-d62a-4321493d8a24@suse.com> In-Reply-To: <372e227d-a18b-fa76-d62a-4321493d8a24@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0208.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6753:EE_ X-MS-Office365-Filtering-Correlation-Id: a64ede3b-0320-4060-3745-08db165a686b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hADP/uphkm1mTGFJ9FFuUFPqde+NtJeQWbBMZIhB5F0vZQF8yF7yKBJgEDKrbOdj15M/mh0kV60RgN7VlKD2Mt4sZeOITw4KZ6yfhb+0/t5iVrnHVr0Tv9Nvp0LXCRE/WC+nO5RsgbS0lrtUvded0f/hRE4lRvy4ddl5OY/lm2NCbmnWGiip+VM4kCCvQRnqIv1blfYh4avoldnXU44O5NvxyJuNI4npxjXd+DejIsc0J7oTg+xxzLeEguJcs9+HQsRq/jDlzLzGDQRXy1dJieqMDpFwngKjMAsmaV4OuMUmsjHRQCI5nAlFIvtNO10Eg9AersClTph+T5gp85FkOsMoHMqrDRNfieKHvMyI5at1S/Gk02UzctC0PZY6W8ruCzbIHOMDsNv4ECRLTyrpuyMrf6oRiAe5eZOMalsm3twBrL+1B+DX26KXiRgNN62eoeTAtk61MGygvThsZ9r8VFUcdSFLMjCXac5gWnKk2uer/ts96veehxKhKLiQTWwvRY+7YGiCCHMx8sh13+YiREwaQnxkcpprpDYAVW9+IsMjToKBn5KtkuWWk44wcvqSOPTLnFPOf5kjxGCjEsOFOXg1PrIafHRYOO1KtKnTOS3JEa2JvFD5Oc2HgcXEA9aR+zhnmHGu4O8PsnNm49VKxLubvT+V9O/47RkaVnSKj6dZg2qGUIodtc1i+yAQRNkB8Ob+NgTLw7xSwdwlUC1/LKYPfWMv5czt3NGKpGa5uRc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(451199018)(966005)(6486002)(31686004)(2906002)(41300700001)(36756003)(26005)(6666004)(186003)(6512007)(53546011)(6506007)(4326008)(31696002)(54906003)(86362001)(83380400001)(316002)(66946007)(5660300002)(66476007)(8676002)(66556008)(6916009)(38100700002)(478600001)(2616005)(82960400001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVZXTmo1TndQVWM2SGkzWnp3cWZHZmpSbG9sa2hxeGxvQW5PZEhVUGM4OVNy?= =?utf-8?B?Y2NFTURvRkFKeXRkdGdxMUU4bGpHOFppZkhYa0xPek5HVDN5alpUcGk0OTZm?= =?utf-8?B?alJFbXRoVkZPUFR3b3IvVE11eXFCdWF6QkUxRUp0NXNjZktRYVlxZzhGTE5z?= =?utf-8?B?eWhNWS9zR2t1VUt3SytSM1RqcnBQTjhCYW1LbkRaN281MUhtem9XbGFKczdr?= =?utf-8?B?dWpoVU81dHVjWUZMWVFlUURhZ1dzcFROR2RmT2pRdGVLaWJVNStaTmtMTWFE?= =?utf-8?B?Z1B2a1VtaTVxZ2hhWGRyUmZhUGh4WjNRR2tJc1lxeG9PeHV4eWZuYTc5T2xl?= =?utf-8?B?N2pUMGhGalFTWllwcURIcUdlUm9yS1NPNGR4UzdHMDdtU2VrbDNEMHhENnE1?= =?utf-8?B?RnRHWmt4cnNGU2V2TEw1VndXWUJLOGtRTitieEZsVzhRazlZU2dNU0VOb0tu?= =?utf-8?B?WkxjQ2xoeDcwaGhzZi9HaTg3a0t2VVdkMW4vVVcxQTVLUWVSeldOb0szZGxi?= =?utf-8?B?N0dTVXZZN241a2pVQTB0YTNENjZEbFZwanJvbzB0aU9COHZLbXRuYU1lREZo?= =?utf-8?B?TUJrS0luMGRodVNtNGZpRGYvUFk2MmY2S1NpUVJMV0gzREEzT0xsM2tlc1gz?= =?utf-8?B?MEsyTlVZZkpFK2pmVVlIQWs0WDR3VGZaenNwdzdlQ1liQTBBN1F6dGluTjhQ?= =?utf-8?B?Mk4yWVBaM1NMbXVTRGZlcmUzblN0VU85YW5SVFFuTUVYaTFHY2d1cGR1NjR4?= =?utf-8?B?bnVweHZoTEkxbTN1L1V5aS94VCtYaVVHQU9IMGNOWTlJU0pxc05XaFpnZ3c4?= =?utf-8?B?UHFsM0JRdEtPWHpETVFucFJWSEVyUTNOdmg2TVpid3BSUVNzNUxIQjNOS09H?= =?utf-8?B?K29kdEh3T1BpdFNWSm5RUVQ2MVRHREhUQU9nTnkrRG9kL0U1K2x0ZkZqRE82?= =?utf-8?B?cXdFaEVxdjJzcEZiYkdXaEdWNnBFR0pEVmo5MUVsVDJNd2pTRVJWVEQzeWRn?= =?utf-8?B?VFZxbGdaZmJ4NXBwTlFNc0tWSy9QS2hkSWQ0bVJvcWM5QnVBczJQT3R5dW5h?= =?utf-8?B?Mmo2OERaSmZjUEdoeTR1TFFVRHhnNm04Lyt2TmNwRmRPU1VaaVgydGhQVEJv?= =?utf-8?B?dERJM0ZFYi9HQTJlbVB6cnRhb2N6eU5KcnB5YXF0eW90RldpbWRJUnQ4b21V?= =?utf-8?B?OERqZEhBbDdzUy9MSWtUbDJ4Q0FmTzEvZTdRcmc5S1E1M3Mwd1NVdDNnNHZh?= =?utf-8?B?K3BpQ0paZEFndmpoNDdWUnF2bmlyL3MzQlY4MHRLTG9kb1FUNlpqNHdsVW56?= =?utf-8?B?VTh2d1hzb2NzNDEyUWpjQ2gzcTlHRi9raFg5SjlKeGtEVzU5VVZrWXc1V2o0?= =?utf-8?B?clpFdDMrNjZtYVh2eWkrWnNPa0U5OXljYm53cHYyUEc4WGZIOFZTQmxUeXdX?= =?utf-8?B?Y0lUeGppQ2hsUDh6bFJvZDFNakpQbjFCb0JBcEx6SzFTdE4xdFB3VDArNU0y?= =?utf-8?B?dCtjUHNWc3hZNFc0dnRhYlBrZk16VEtzemR6TUQvdlJmbDFCSENYdlRtOWpC?= =?utf-8?B?NExtOEliU0o1eGd5ZTc2Q1M5RHdPTTJRemhNY1lzVnZIRGZuVmFBY20xSFRH?= =?utf-8?B?QTNOSlBaK2NnREFOWHpyV254cFp4THgrMkgzRURMTUE1NlBBUWVMRGM4TGNJ?= =?utf-8?B?MXEyOStkYmdwMjczWHBvbWp5NDlGMlc5Skl1WEtiUjVtSjB6U3VFLzlqSzdI?= =?utf-8?B?TFVkd1FqQUV6UklmRWFobTFIWGNrcXVNQ3VyKzdPYklTbW5pWW9ZR2VOaXpD?= =?utf-8?B?QmF5cjFKZlFDaFNoSk5EcDBWYVdFcjh6azNpTm1WdTFKQldFT2VFVk90YVpI?= =?utf-8?B?V1VIZlVvV0RDbHMvL0FpMlYwbFJrejBQWStCVEtGS1pmdWlwa0lJdHhWcGxU?= =?utf-8?B?TGxsUkxaSFhENEd2L0Vwd2lCaTYvWlNQODlRbC9JbVZaR1FIZWtSaGJjK0Mz?= =?utf-8?B?cXpua3A5NEtoKzA5WnR3S0NDY1BLRVhxR1JFQlV3K0lvVFp4S3RWWVQ2cXo1?= =?utf-8?B?b1QwSE5wRjJQUDQ2RjAyOTA5bkZZWlpSK09uVkdCVWdJVngyanMxcW9idW9s?= =?utf-8?B?cnM3THZ1ZExlSWlIZmx2TEl6NzdyaEtUSmxLbFo1S1NqSlR1STBITS9RdUh6?= =?utf-8?B?L3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4itFmZvTxHUrLIC4rTn7PGfr2vKcUeztTS2h6i5HF8tx7qbyYD6DoiGBMqokv1CFvMMQEBq+AtuAMFtC+R8S/sP8exoxQM7EvUewi78c3IPzcIH3W+djey5+ib0G++4VVhlJUwEGrjrY5AVbG+d8B0yROtz5EBrRiJSFtv8dfH8SlN2IaSJgX8PPxsLshxPQ/toVflbwk2YWoLDizmhpjUOITJ908oyZwieqE0kz3sTUyCLoSRNX/mDo4DBfJv7InAACsENcaNvph+cWV/Bjfd0l7wL8aeTmv7Dna5MFv3I4X14RzVmrtVkgLqPZes2dhCxelpSIc4M/j+3CWFpa7nDlopEKC5q8KFUmvdAVrNEXMUvqu7jgohZ2da8pkEP7Z/5YziQ7SSMHBXaHvBQMOT7zYfA6QP3SN1xKrcP9/8skgFU2HMViMh/5F8DhONZFwsQIanQKNbBPvr3mIeWOamggIGvbQ5ZM+WpZ2CrY6dPL1XcfLtQw104K+vana+hPKoC9CdSKWafcop3AMgInv7y1Kmeugk/l/XUJEK2Sr6FsAqlTYde/sSmZ+vvYbAE8+yjiRBSIIwGQcEnet1/RXqmkU71/Y0IP28FujQx1iirPpPAXMhqEA1Pg3b8B1CthTy16CiSduTKRlM2z5rKD/gcbbI7gVVuFpwCBagYs1//ZEz7qROrHsyAqVsSOeC7296om83s8eVwfHMIxVVP5VESRk1bGBo+uvA2jYe+DVTJ8b0o89Uv1Bo+SpBwBIa8fc/OvCX2wEleWBxjUf5dK0lMNEDlTYl76HHzEMRADw3sIvK7U3ul/hMxcu2RAWIViiS7f9/gtX+FbS+4PU9rA4A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a64ede3b-0320-4060-3745-08db165a686b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 11:29:36.0437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bv9xNewtKRKpPW8ZR6qRgqhy3DUL8JELzHAgVeULnPQKrRI4yKfCLvzCGMxttUKPAiytrK0FaMVfK/LyU1+OsjgZtQrW8OKv8A+JyQYQPE4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6753 On 24/02/2023 11:17 am, Jan Beulich wrote: > On 24.02.2023 11:50, Andrew Cooper wrote: >> On 24/02/2023 7:27 am, Jan Beulich wrote: >>> On 23.02.2023 23:03, Andrew Cooper wrote: >>>> https://github.com/llvm/llvm-project/issues/60958 >>>> >>>> While trying to work around a different Clang-IAS bug, I stubled onto >>>> >>>> In file included from arch/x86/asm-macros.c:3: >>>> ./arch/x86/include/asm/spec_ctrl_asm.h:144:19: error: \u used with >>>> no following hex digits; treating as '\' followed by identifier [-Werror,-Wunicode] >>>> .L\@_fill_rsb_loop\uniq: >>>> ^ >>>> >>>> It turns out that Clang -E is sensitive to the file extension of the source >>>> file it is processing. >>> I'm inclined to say there's no bug there in Clang. Gcc, while not affected >>> in this specific regard, also treats .c and .S differently in some perhaps >>> subtle ways. >> This part was just an observation. >> >> Whether .c and .S should be treated the same or not, this -Wunicode >> diagnostic is given against something which isn't in a char/string >> literal, and that is a bug. > Why are you thinking of only string literals? Gcc is quite okay with > > void test\u0024ä\u00F6ü(void) {} > > yielding "test$äöü" in the object file (I haven't understood yet why it > dislikes \u0040, i.e. @.) Oh - it seems universal-character-name is an explicitly permitted part of identifier-nondigit. In which case, Clang is arguably correct given a semantic expectation of being a C file.  I'll reword the commit message seen as I've not quite pushed it yet. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:31:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:31:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500921.772468 (Exim 4.92) (envelope-from ) id 1pVWIG-0004Z3-It; Fri, 24 Feb 2023 11:31:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500921.772468; Fri, 24 Feb 2023 11:31:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIG-0004Yw-G3; Fri, 24 Feb 2023 11:31:16 +0000 Received: by outflank-mailman (input) for mailman id 500921; Fri, 24 Feb 2023 11:31:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIE-0004Yi-Sx for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:31:14 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bdf422ee-b436-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:31:12 +0100 (CET) Received: by mail-lj1-x22d.google.com with SMTP id z5so13859786ljc.8 for ; Fri, 24 Feb 2023 03:31:12 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id v19-20020a2ea613000000b00295a815e555sm92682ljp.134.2023.02.24.03.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:31:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdf422ee-b436-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QplnGM5/2JJSuu65J297m5fTZ0hr6VBvMaS6u6b5al8=; b=R09VBqlWdgu5NmfjE+AsXmpsTVJFQMBjJf0qv4nbKyrt2JeB7trdVGVrCwgl0UdJaG BDRveJ73bpu863lRmFe1S+n+/tZ5BrgBGzZIY3qGRJ5kuFHqyPA7/G+L5Hpw4bRfsslw R3u9QPJOVU0XgEYIsCs2zJMWt2mF9esAnciXVMe5PyRuK/iuX+x4BgWQsCHwYbrXwyE3 ty0hL2NAxsaXeYtILXU0l4Fl6sYT2IA+tfr9Zu03oMevvfxCagkKk6eYgoeDMiYxpcQN AvuITXNWm54gsrUdO9EQyvOFRKZSOZRD+0nphxWqIPSry33JMbe48L5/9LvLzh23fBvs IGww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QplnGM5/2JJSuu65J297m5fTZ0hr6VBvMaS6u6b5al8=; b=Uw7gPb9p1VHg+qn4DQiQBMsSk68NbdsE56Hj1BnfdddZbriOcScItuZIaZZ24GmFQ/ DoPGm77zF56uDBm0Y4ZYawmdbykdAPE+q+8hwWn8KRMG1ySNFriRuVF3eqh/cbOEnZ0c BtEJdpSxVMMk3nO5GMsg2vDgPryCtCv8LjHdKpPP1rtIZ6pJkZEGBLvyYQVUKZyvacpd LCUsyqd7UWg8pV6nHWmwHj3ws2uJC3LHkkLrU1k8ZoCq4e7vDjy+alb9QhUTPMrii8Zg wnXP5no4Pn/NybDXcGg2DYdkhStld3HSoNn1KntLhH9LYin4cxkDIZci+cs6hg55OmGY LCuQ== X-Gm-Message-State: AO0yUKXgu7UxCrFNyN6L4AyLnQ62CCc6oJzEgmOOGI9MoNtFg8MHohWx ul3oYphXw3Pt1owpvHqjPNAqsUinoX0= X-Google-Smtp-Source: AK7set8jUvkC0ZZ2lbSC7fNzE0jcUQD0QxrOCoBA/PRfDHi1oKBX8hXV+ij73Q0gJvC5M5E5ZjlZMg== X-Received: by 2002:a05:651c:2123:b0:295:a1bc:33ca with SMTP id a35-20020a05651c212300b00295a1bc33camr2372187ljq.6.1677238271975; Fri, 24 Feb 2023 03:31:11 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 0/4] introduce generic implementation of macros from bug.h Date: Fri, 24 Feb 2023 13:31:03 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures (especially x86 and RISCV have the same implementation), so it was created a new config CONFIG_GENERIC_BUG_FRAME which is used to introduce generic implementation of do_bug_frame() and move x86's to with the following changes: * Add inclusion of arch-specific header * Rename the guard and remove x86 specific changes * Wrap macros BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed/etc into #ifndef "BUG_FRAME/run_in_exception_handler/WARN/BUG/assert_failed/etc" thereby each architecture can override the generic implementation of macros. * Add #if{n}def __ASSEMBLY__ ... #endif * Introduce BUG_FRAME_STRUCTURE define to be able to change the structure of bug frame * Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. * Make macros related to bug frame structure more generic. For ARM only common parts were removed from and re-use generic do_bug_frame() for ARM. RISC-V will be switched to use and in the future, it will use common the version of do_bug_frame() when xen/common will work for RISC-V. --- Changes in V3: * Nothing was done with the comment in before run_in_exception_handler but I think it can be changed during the merge. * Add debugger_trap_fatal() to do_bug_frame(). It simplifies usage of do_bug_frame() for x86 so making handle_bug_frame() and find_bug_frame() not needed anymore. * Update do_bug_frame() to return -EINVAL if something goes wrong; otherwise id of bug_frame * Update _ASM_BUGFRAME_TEXT to make it more portable. * Drop unnecessary comments. * Update patch 2 not to break compilation: move some parts from patches 3 and 4 to patch 2 * As prototype and what do_bug_frame() returns was changed so patch 3 and 4 was updated to use a new version of do_bug_frame * Change debugger_trap_fatal() prototype for x86 to align with prototype in --- Changes in V2: * Update cover letter. * Switch to x86 implementation as generic as it is more compact ( at least from the point of view of bug frame structure). * Put [PATCH v1 4/4] xen: change to as second patch, update the patch to change all to among the whole project to not break compilation. * Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. * Change the macro bug_loc(b) to avoid the need for a cast: #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) * Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT * Make macros related to bug frame structure more generic. * Rename bug_file() in ARM implementation to bug_ptr() as generic do_bug_frame() uses bug_ptr(). * Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. * Rework do_invalid_op() in x86 ( re-use handle_bug_frame() and find_bug_frame() ) --- Oleksii Kurochko (4): xen: introduce CONFIG_GENERIC_BUG_FRAME xen: change to xen/arm: switch ARM to use generic implementation of bug.h xen/x86: switch x86 to use generic implemetation of bug.h xen/arch/arm/Kconfig | 1 + xen/arch/arm/arm32/traps.c | 2 +- xen/arch/arm/include/asm/bug.h | 34 +----- xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/include/asm/traps.h | 2 - xen/arch/arm/traps.c | 81 +-------------- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/bug.h | 88 +--------------- xen/arch/x86/include/asm/debugger.h | 4 +- xen/arch/x86/traps.c | 81 ++------------- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/bug.c | 109 +++++++++++++++++++ xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/bug.h | 150 +++++++++++++++++++++++++++ xen/include/xen/lib.h | 2 +- 20 files changed, 291 insertions(+), 280 deletions(-) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:31:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:31:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500922.772478 (Exim 4.92) (envelope-from ) id 1pVWIH-0004oZ-RH; Fri, 24 Feb 2023 11:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500922.772478; Fri, 24 Feb 2023 11:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIH-0004oO-NA; Fri, 24 Feb 2023 11:31:17 +0000 Received: by outflank-mailman (input) for mailman id 500922; Fri, 24 Feb 2023 11:31:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIG-0004Yi-2S for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:31:16 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id becefdc9-b436-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:31:14 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id i9so17342115lfc.6 for ; Fri, 24 Feb 2023 03:31:14 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id v19-20020a2ea613000000b00295a815e555sm92682ljp.134.2023.02.24.03.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:31:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: becefdc9-b436-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AgBxbMPWe3EyzCfXpR5m0OP7A2Ia8jQUyV6vwTk/ZCU=; b=OavmJP0f9Si3LbeNdFM7APxBmB+wWffF4AoIbo4dpvWh4tqRxJcWFlklAIGZWIH4ej ciMkdIvPEerKsGvfEae25dyJ6/CJTbWlf+1BQCKQ1+4ybAOrfrpUgTswSroHlQi54XX5 h0OXhQpoZ4heUcPb9z1lZxAJ56lgORd/ngXP/c1ir7AiYvB6KeR30XrvKOojp+QKE4np qjOCZjxdqcnT9Yb/pUw1nZuBYtQb6vPBUomvstl/4JL16StS2ZKLFRCPKV9s5b/0C1Uw APCZU+l19vonmNG1inN7VH3rMva4wSpY16pso1NzSDiBWQZDYfbcLE2Df6yxSl43R+5W 8bsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AgBxbMPWe3EyzCfXpR5m0OP7A2Ia8jQUyV6vwTk/ZCU=; b=AnfZOxCtguhd4CCo9lmNFUDLDrOQCZGh+14KR2sp05j5RLlPcjtJ9a6w6n9voCYd5S 3oVDSPbD6iOsPzPhuEQNqgiTYsu2oupC3IDcOKxeUX8b3QhQUtaBBRhIgCQdjqeKGscP yyidw0zaTKj4Cs31h6Izy1eLVd5fZjISyKR1rhzB0n+CPSbyYXcQ0YEz04gJHK2/Raxr w/B//NvgYjKSY1dsurw575efiyVs6kLNdfqM8rinGayHIw4EiUKuv+M8ltGp4qdiS5zs RgI8n6Fhwk4z3O4LZ1VHzrVodB7USUHCvO4/Kw4HmPnQ2EEA5I6QixrSubfCUCohac8i c6Rg== X-Gm-Message-State: AO0yUKWDZndo4EejglVc8H2V9iD0aGqFHZPEdEBQ8wZ52Nij3ZKPB59G grORbmxVv+0e0hP+YTLHyTD3QJcUKAY= X-Google-Smtp-Source: AK7set9A/YDVjjVV+2W/FAHrKbqpSzjpwJZ8sJ1tl3wkhL6E4yqeC+r2iZMxCzCYrfNUnD+K9a55rA== X-Received: by 2002:a05:6512:3089:b0:4db:787:e43b with SMTP id z9-20020a056512308900b004db0787e43bmr6985309lfd.8.1677238273501; Fri, 24 Feb 2023 03:31:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , George Dunlap , Julien Grall , Wei Liu Subject: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Date: Fri, 24 Feb 2023 13:31:04 +0200 Message-Id: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A large part of the content of the bug.h is repeated among all architectures, so it was decided to create a new config CONFIG_GENERIC_BUG_FRAME. The version of from x86 was taken as the base version. The patch introduces the following stuff: * common bug.h header * generic implementation of do_bug_frame * new config CONFIG_GENERIC_BUG_FRAME Signed-off-by: Oleksii Kurochko --- Changes in V3: * Add debugger_trap_fatal() to do_bug_frame(). It simplifies usage of do_bug_frame() for x86 so making handle_bug_frame() and find_bug_frame() not needed anymore. * Update do_bug_frame() to return -EINVAL if something goes wrong; otherwise id of bug_frame * Update _ASM_BUGFRAME_TEXT to make it more portable. * Drop unnecessary comments. * define stub value for TRAP_invalid_op in case if wasn't defined in arch-specific folders. --- Changes in V2: - Switch to x86 implementation as generic as it is more compact ( at least from the point of view of bug frame structure ). - Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. - Change the macro bug_loc(b) to avoid the need for a cast: #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) - Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT - Make macros related to bug frame structure more generic. - Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable between x86 and RISC-V. - Rework do_bug_frame() and introduce find_bug_frame() and handle_bug_frame() functions to make it reusable by x86. - code style fixes --- xen/common/Kconfig | 3 + xen/common/Makefile | 1 + xen/common/bug.c | 109 ++++++++++++++++++++++++++++++ xen/include/xen/bug.h | 150 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 263 insertions(+) create mode 100644 xen/common/bug.c create mode 100644 xen/include/xen/bug.h diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8..b226323537 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL config ARCH_MAP_DOMAIN_PAGE bool +config GENERIC_BUG_FRAME + bool + config HAS_ALTERNATIVE bool diff --git a/xen/common/Makefile b/xen/common/Makefile index bbd75b4be6..46049eac35 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_ARGO) += argo.o obj-y += bitmap.o +obj-$(CONFIG_GENERIC_BUG_FRAME) += bug.o obj-$(CONFIG_HYPFS_CONFIG) += config_data.o obj-$(CONFIG_CORE_PARKING) += core_parking.o obj-y += cpu.o diff --git a/xen/common/bug.c b/xen/common/bug.c new file mode 100644 index 0000000000..f81724fc9b --- /dev/null +++ b/xen/common/bug.c @@ -0,0 +1,109 @@ +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +/* Set default value for TRAP_invalid_op as it is defined only for X86 now */ +#ifndef TRAP_invalid_op +#define TRAP_invalid_op 0 +#endif + +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc) +{ + const struct bug_frame *bug = NULL; + const struct virtual_region *region; + const char *prefix = "", *filename, *predicate; + unsigned long fixup; + unsigned int id = BUGFRAME_NR, lineno; + + region = find_text_region(pc); + if ( region ) + { + for ( id = 0; id < BUGFRAME_NR; id++ ) + { + const struct bug_frame *b; + unsigned int i; + + for ( i = 0, b = region->frame[id].bugs; + i < region->frame[id].n_bugs; b++, i++ ) + { + if ( bug_loc(b) == pc ) + { + bug = b; + goto found; + } + } + } + } + + found: + if ( !bug ) + return -EINVAL; + + if ( id == BUGFRAME_run_fn ) + { +#ifdef BUG_FN_REG + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; +#else + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); +#endif + + fn(regs); + + return id; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_ptr(bug); + if ( !is_kernel(filename) && !is_patch(filename) ) + return -EINVAL; + fixup = strlen(filename); + if ( fixup > 50 ) + { + filename += fixup - 47; + prefix = "..."; + } + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); + show_execution_state(regs); + + return id; + + case BUGFRAME_bug: + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + return id; + + show_execution_state(regs); + panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + if ( !is_kernel(predicate) && !is_patch(predicate) ) + predicate = ""; + + printk("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) + return id; + + show_execution_state(regs); + panic("Assertion '%s' failed at %s%s:%d\n", + predicate, prefix, filename, lineno); + } + + return id; +} diff --git a/xen/include/xen/bug.h b/xen/include/xen/bug.h new file mode 100644 index 0000000000..4b18cfa69c --- /dev/null +++ b/xen/include/xen/bug.h @@ -0,0 +1,150 @@ +#ifndef __XEN_BUG_H__ +#define __XEN_BUG_H__ + +#define BUG_DISP_WIDTH 24 +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) + +#define BUGFRAME_run_fn 0 +#define BUGFRAME_warn 1 +#define BUGFRAME_bug 2 +#define BUGFRAME_assert 3 + +#define BUGFRAME_NR 4 + +#include + +#ifndef __ASSEMBLY__ + +#include +#include +#include + +#ifndef BUG_FRAME_STRUCT + +struct bug_frame { + signed int loc_disp:BUG_DISP_WIDTH; + unsigned int line_hi:BUG_LINE_HI_WIDTH; + signed int ptr_disp:BUG_DISP_WIDTH; + unsigned int line_lo:BUG_LINE_LO_WIDTH; + signed int msg_disp[]; +}; + +#endif /* BUG_FRAME_STRUCT */ + +#ifndef bug_loc +#define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) +#endif + +#ifndef bug_ptr +#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) +#endif + +#ifndef bug_line +#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ + ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ + BUG_LINE_LO_WIDTH) + \ + (((b)->line_lo + ((b)->ptr_disp < 0)) & \ + ((1 << BUG_LINE_LO_WIDTH) - 1))) +#endif + +#ifndef bug_msg +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) +#endif + +#ifndef BUG_ASM_CONST +#define BUG_ASM_CONST "" +#endif + +#if !defined(_ASM_BUGFRAME_TEXT) || !defined(_ASM_BUGFRAME_INFO) + +#define _ASM_BUGFRAME_TEXT(second_frame) \ + ".Lbug%=:"BUG_INSTR"\n" \ + " .pushsection .bug_frames.%"BUG_ASM_CONST"[bf_type], \"a\", %%progbits\n" \ + " .p2align 2\n" \ + ".Lfrm%=:\n" \ + " .long (.Lbug%= - .Lfrm%=) + %"BUG_ASM_CONST"[bf_line_hi]\n" \ + " .long (%"BUG_ASM_CONST"[bf_ptr] - .Lfrm%=) + %"BUG_ASM_CONST"[bf_line_lo]\n"\ + " .if " #second_frame "\n" \ + " .long 0, %"BUG_ASM_CONST"[bf_msg] - .Lfrm%=\n" \ + " .endif\n" \ + " .popsection\n" + +#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ + [bf_type] "i" (type), \ + [bf_ptr] "i" (ptr), \ + [bf_msg] "i" (msg), \ + [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ + << BUG_DISP_WIDTH), \ + [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) + +#endif /* _ASM_BUGFRAME_TEXT || _ASM_BUGFRAME_INFO */ + +#ifndef BUG_FRAME + +#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ + BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ + asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ + :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ +} while (0) + +#endif + +#ifndef run_in_exception_handler + +/* + * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, + * and use a real static inline here to get proper type checking of fn(). + */ +#define run_in_exception_handler(fn) \ + do { \ + (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ + BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ + } while ( 0 ) + +#endif /* run_in_exception_handler */ + +#ifndef WARN +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) +#endif + +#ifndef BUG +#define BUG() do { \ + BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ + unreachable(); \ +} while (0) +#endif + +#ifndef assert_failed +#define assert_failed(msg) do { \ + BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ + unreachable(); \ +} while (0) +#endif + +#ifdef CONFIG_GENERIC_BUG_FRAME + +struct cpu_user_regs; + +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc); + +#endif /* CONFIG_GENERIC_BUG_FRAME */ + +extern const struct bug_frame __start_bug_frames[], + __stop_bug_frames_0[], + __stop_bug_frames_1[], + __stop_bug_frames_2[], + __stop_bug_frames_3[]; + +#endif /* !__ASSEMBLY__ */ + +#endif /* __XEN_BUG_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:31:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:31:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500923.772488 (Exim 4.92) (envelope-from ) id 1pVWIJ-00054R-2k; Fri, 24 Feb 2023 11:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500923.772488; Fri, 24 Feb 2023 11:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWII-00054K-Vw; Fri, 24 Feb 2023 11:31:18 +0000 Received: by outflank-mailman (input) for mailman id 500923; Fri, 24 Feb 2023 11:31:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIG-0004Z5-S3 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:31:16 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfdc4502-b436-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:31:15 +0100 (CET) Received: by mail-lj1-x22e.google.com with SMTP id j17so14012390ljq.11 for ; Fri, 24 Feb 2023 03:31:15 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id v19-20020a2ea613000000b00295a815e555sm92682ljp.134.2023.02.24.03.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:31:15 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfdc4502-b436-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FHOe3gWUHwieeNaUAZbwaaYvn/OKztq6D7rxSzkp37U=; b=nXD0eeC04kAsS+A9n1ec0duP6Z7xCP0jiZLGU+57mD38kYw4rCpdJF2NAKbEHt42Qb 3zFp9xusxhT7PvWfJdDL022rDqS86UjH9fDwcyZ8rZWSau9y8fJDejuzzVWFhtcq0ZLT kzI//i4ZvmWw8ufi43iQfGYI/KxpyVSgkEa9ZH4Z6fv9qZdkVCE0/O0zYz4SbAlvNjfc gS1d4ymufnvzquYKIOX+kaY78Rcm1v2sPPRVGjI+N7//kQ7zw5VVNqAg96kElnHYC3b+ ydujYcdlT9N8EG/NUMvk0whCagM8jQWVAKoklxkdjyESqiQFYlDJ/NTwKjpCraobqQ1L fybA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FHOe3gWUHwieeNaUAZbwaaYvn/OKztq6D7rxSzkp37U=; b=CUmwMPKIcvICgiwi0sMZepmizHWgU0LDlGv7r8V5tR9yDjmIKKYwwJhI0jIaFGyg+P YPc+TcRDrVRsptLuPz34i8I8NlnAHSChBclhD2JKlt+y8GOhKsTbzual37HZivaJ6lfd ugDJ5MX1tG3CIJRTn77/WjZ5BlQzEORz7iPbcMjKOp23KkPhnC5CvXAqkNNRRPMT6DYE iDnGoP7FxIWqspA43RoeBZwUDKSScftfcR7MuPmWSQ8Sum52HiQ/LWw50EnTpym2tJWQ I5NBiVPjfauL45nELcmgAB73hkUqItJuQ0QHynVtcjNkTQeofBSjCEodWlj/qIEzkKWQ hkwQ== X-Gm-Message-State: AO0yUKXpnC0uaXu+GAhzust7RhW6ir1z8+/8BPV24gR52SkcS4BH5olJ 4/HsDp4rLoER+hF06AyTogbNiT45+OA= X-Google-Smtp-Source: AK7set+Xij/4ZC2hO7U4EhhN2RDupsNnQZm8MtDj4vPEbhS3DrR1uAbQI3sKaR+ET+UKMLFn0h4gVA== X-Received: by 2002:a2e:be08:0:b0:282:d00d:4be6 with SMTP id z8-20020a2ebe08000000b00282d00d4be6mr7174601ljq.40.1677238275282; Fri, 24 Feb 2023 03:31:15 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 2/4] xen: change to Date: Fri, 24 Feb 2023 13:31:05 +0200 Message-Id: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the generic version of bug.h stuff was introduced use instead of unnecessary Signed-off-by: Oleksii Kurochko --- Changes in V3: * Update patch 2 not to break compilation: move some parts from patches 3 and 4 to patch 2: * move some generic parts from to * add define BUG_FRAME_STRUCT in ARM's --- Changes in V2: * Put [PATCH v1 4/4] xen: change to as second patch, update the patch to change all to among the whole project to not break build. * Update the commit message. --- xen/arch/arm/include/asm/bug.h | 19 +++---------------- xen/arch/arm/include/asm/div64.h | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic.c | 2 +- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/include/asm/asm_defns.h | 2 +- xen/arch/x86/include/asm/bug.h | 19 ++----------------- xen/drivers/cpufreq/cpufreq.c | 2 +- xen/include/xen/lib.h | 2 +- 9 files changed, 12 insertions(+), 40 deletions(-) diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h index f4088d0913..cacaf014ab 100644 --- a/xen/arch/arm/include/asm/bug.h +++ b/xen/arch/arm/include/asm/bug.h @@ -1,6 +1,8 @@ #ifndef __ARM_BUG_H__ #define __ARM_BUG_H__ +#include + #if defined(CONFIG_ARM_32) # include #elif defined(CONFIG_ARM_64) @@ -9,9 +11,7 @@ # error "unknown ARM variant" #endif -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) +#define BUG_FRAME_STRUCT struct bug_frame { signed int loc_disp; /* Relative address to the bug address */ @@ -26,13 +26,6 @@ struct bug_frame { #define bug_line(b) ((b)->line) #define bug_msg(b) ((const char *)(b) + (b)->msg_disp) -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - /* Many versions of GCC doesn't support the asm %c parameter which would * be preferable to this unpleasantness. We use mergeable string * sections to avoid multiple copies of the string appearing in the @@ -89,12 +82,6 @@ struct bug_frame { unreachable(); \ } while (0) -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; - #endif /* __ARM_BUG_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/div64.h b/xen/arch/arm/include/asm/div64.h index 1cd58bc51a..fc667a80f9 100644 --- a/xen/arch/arm/include/asm/div64.h +++ b/xen/arch/arm/include/asm/div64.h @@ -74,7 +74,7 @@ #elif __GNUC__ >= 4 -#include +#include /* * If the divisor happens to be constant, we determine the appropriate diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c index 1a99d3a8b4..c90e88fddb 100644 --- a/xen/arch/arm/vgic/vgic-v2.c +++ b/xen/arch/arm/vgic/vgic-v2.c @@ -16,8 +16,8 @@ */ #include -#include #include +#include #include #include diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index f0f2ea5021..b9463a5f27 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -15,9 +15,9 @@ * along with this program. If not, see . */ +#include #include #include -#include #include #include diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index c27cbb2304..18ff2a443b 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -27,6 +27,7 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include #include #include #include @@ -35,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/include/asm/asm_defns.h b/xen/arch/x86/include/asm/asm_defns.h index d9431180cf..a8526cf36c 100644 --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -6,7 +6,7 @@ /* NB. Auto-generated from arch/.../asm-offsets.c */ #include #endif -#include +#include #include #include #include diff --git a/xen/arch/x86/include/asm/bug.h b/xen/arch/x86/include/asm/bug.h index b7265bdfbe..4b3e7b019d 100644 --- a/xen/arch/x86/include/asm/bug.h +++ b/xen/arch/x86/include/asm/bug.h @@ -1,19 +1,10 @@ #ifndef __X86_BUG_H__ #define __X86_BUG_H__ -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) - -#define BUGFRAME_run_fn 0 -#define BUGFRAME_warn 1 -#define BUGFRAME_bug 2 -#define BUGFRAME_assert 3 - -#define BUGFRAME_NR 4 - #ifndef __ASSEMBLY__ +#define BUG_FRAME_STRUCT + struct bug_frame { signed int loc_disp:BUG_DISP_WIDTH; unsigned int line_hi:BUG_LINE_HI_WIDTH; @@ -80,12 +71,6 @@ struct bug_frame { unreachable(); \ } while (0) -extern const struct bug_frame __start_bug_frames[], - __stop_bug_frames_0[], - __stop_bug_frames_1[], - __stop_bug_frames_2[], - __stop_bug_frames_3[]; - #else /* !__ASSEMBLY__ */ /* diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index a94520ee57..354f78580b 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -26,6 +26,7 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include #include #include #include @@ -39,7 +40,6 @@ #include #include #include -#include #include #include diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 05ee1e18af..e914ccade0 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -24,12 +24,12 @@ #ifndef __ASSEMBLY__ +#include #include #include #include #include #include -#include #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) #define WARN_ON(p) ({ \ -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:31:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500924.772498 (Exim 4.92) (envelope-from ) id 1pVWIK-0005Ly-JX; Fri, 24 Feb 2023 11:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500924.772498; Fri, 24 Feb 2023 11:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIK-0005Lp-G8; Fri, 24 Feb 2023 11:31:20 +0000 Received: by outflank-mailman (input) for mailman id 500924; Fri, 24 Feb 2023 11:31:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWII-0004Yi-Tf for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:31:19 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0a5b9b2-b436-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:31:17 +0100 (CET) Received: by mail-lj1-x22d.google.com with SMTP id z5so13859968ljc.8 for ; Fri, 24 Feb 2023 03:31:17 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id v19-20020a2ea613000000b00295a815e555sm92682ljp.134.2023.02.24.03.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:31:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0a5b9b2-b436-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cOshq+qKbDwQMkJNLbvBoFxXJPrCc7l4QBus5ql+hrQ=; b=ltuWFLkn+rkcMbJuSMNyb6XPd72AvRfFGSala1oi+RzSSOdI7Ohr0onvF9IOhOWlLZ PBT78GgpjF8IRzcqfm9HmNgXB+zdJjiMs2HKPLqUD7ngbqoMmDzhwENTHwr+V07HJj+S TBVliYoR7gwBW53VH+oN55AHL2xdT5sjP1man/UzEoWlNg0f0nqK/ghC2YSkeVU8PXSi /QGKe2M8FOFahEjwDhYolyn+fafZJsqzI101HBAlaOgY+U7/NqEcJ6Jf9EPTdmhjVsF1 9Ybw7ProSQLRcjHiM3X7TsDAG9XIFytKrXuxqW+w2vAyiv8WEg9wNUV11QJ6VjXA4EVu hbcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOshq+qKbDwQMkJNLbvBoFxXJPrCc7l4QBus5ql+hrQ=; b=lhl5cWcwwUkSfBJiJ7bt5KAEG1fXWYgsJ1prJn4TePO9jo8Q7hStNDAlZTOwd+VefY yD1zgxPSLZFL4g8uNrSu21aapZwSXxxgiqrWyq0iVVga2/WaazhV5O0PnA0MXPciyvU2 UVDPtQMP/H3dOyR0yu52NILKse/VBXUvmA3I+pZadD71h52g9stbLeXORTUAVta2zfAN oXaPWiPu5rGLygzl0xbj4IX59M9DV1TYto27IXo1hBIW5eW4l2HCanJXBWiRjmdW3pyN wlObUSjivOn3Ip7NMc84uwlxT2OqLz2LpFm85fJwcQPYepZZbigLUWQI/kAa8g0PINoA lIbA== X-Gm-Message-State: AO0yUKXMO4LYddTBR8V1UnuRJpUjwB8B7O7YRnzMjl58iCWwSXdBt8G5 eLVw9kvyHVKcUO4iOfs8J1UZy/Qix1g= X-Google-Smtp-Source: AK7set/RR8/tgFB4o0vxWajvTbl5KSLp0dIFfXf1evPIchk774YEk111cWWnIw900IE+GgreQPHusg== X-Received: by 2002:a05:651c:39c:b0:294:6d1d:cbf2 with SMTP id e28-20020a05651c039c00b002946d1dcbf2mr5031499ljp.40.1677238276713; Fri, 24 Feb 2023 03:31:16 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h Date: Fri, 24 Feb 2023 13:31:06 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following changes were made: * make GENERIC_BUG_FRAME mandatory for ARM * As do_bug_frame() returns -EINVAL in case something goes wrong otherwise id of bug frame. Thereby 'if' cases where do_bug_frame() was updated to check if the returned value is less than 0 * Change macros bug_file() to bug_ptr() to align it with generic implementation. Signed-off-by: Oleksii Kurochko --- Changes in V3: * As prototype and what do_bug_frame() returns was changed so patch 3 and 4 was updated to use a new version of do_bug_frame --- Changes in V2: * Rename bug_file() in ARM implementation to bug_ptr() as generic do_bug_frame() uses bug_ptr(). * Remove generic parts from bug.h * Remove declaration of 'int do_bug_frame(...)' from as it was introduced in --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/arm32/traps.c | 2 +- xen/arch/arm/include/asm/bug.h | 15 +----- xen/arch/arm/include/asm/traps.h | 2 - xen/arch/arm/traps.c | 81 +------------------------------- 5 files changed, 4 insertions(+), 97 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..aad6644a7b 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -12,6 +12,7 @@ config ARM_64 config ARM def_bool y + select GENERIC_BUG_FRAME select HAS_ALTERNATIVE select HAS_DEVICE_TREE select HAS_PASSTHROUGH diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c index a2fc1c22cb..61c61132c7 100644 --- a/xen/arch/arm/arm32/traps.c +++ b/xen/arch/arm/arm32/traps.c @@ -48,7 +48,7 @@ void do_trap_undefined_instruction(struct cpu_user_regs *regs) if ( instr != BUG_OPCODE ) goto die; - if ( do_bug_frame(regs, pc) ) + if ( do_bug_frame(regs, pc) < 0 ) goto die; regs->pc += 4; diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h index cacaf014ab..e6cc37e1d6 100644 --- a/xen/arch/arm/include/asm/bug.h +++ b/xen/arch/arm/include/asm/bug.h @@ -21,8 +21,7 @@ struct bug_frame { uint32_t pad0:16; /* Padding for 8-bytes align */ }; -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) -#define bug_file(b) ((const void *)(b) + (b)->file_disp); +#define bug_ptr(b) ((const void *)(b) + (b)->file_disp) #define bug_line(b) ((b)->line) #define bug_msg(b) ((const char *)(b) + (b)->msg_disp) @@ -70,18 +69,6 @@ struct bug_frame { ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); \ } while (0) -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, "") - -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, ""); \ - unreachable(); \ -} while (0) - -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - #endif /* __ARM_BUG_H__ */ /* * Local variables: diff --git a/xen/arch/arm/include/asm/traps.h b/xen/arch/arm/include/asm/traps.h index 883dae368e..c6518008ec 100644 --- a/xen/arch/arm/include/asm/traps.h +++ b/xen/arch/arm/include/asm/traps.h @@ -69,8 +69,6 @@ void do_cp(struct cpu_user_regs *regs, const union hsr hsr); void do_trap_smc(struct cpu_user_regs *regs, const union hsr hsr); void do_trap_hvc_smccc(struct cpu_user_regs *regs); -int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc); - void noreturn do_unexpected_trap(const char *msg, const struct cpu_user_regs *regs); void do_trap_hyp_sync(struct cpu_user_regs *regs); diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 061c92acbd..9c6eb66422 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1197,85 +1197,6 @@ void do_unexpected_trap(const char *msg, const struct cpu_user_regs *regs) panic("CPU%d: Unexpected Trap: %s\n", smp_processor_id(), msg); } -int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) -{ - const struct bug_frame *bug = NULL; - const char *prefix = "", *filename, *predicate; - unsigned long fixup; - int id = -1, lineno; - const struct virtual_region *region; - - region = find_text_region(pc); - if ( region ) - { - for ( id = 0; id < BUGFRAME_NR; id++ ) - { - const struct bug_frame *b; - unsigned int i; - - for ( i = 0, b = region->frame[id].bugs; - i < region->frame[id].n_bugs; b++, i++ ) - { - if ( ((vaddr_t)bug_loc(b)) == pc ) - { - bug = b; - goto found; - } - } - } - } - found: - if ( !bug ) - return -ENOENT; - - if ( id == BUGFRAME_run_fn ) - { - void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; - - fn(regs); - return 0; - } - - /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ - filename = bug_file(bug); - if ( !is_kernel(filename) ) - return -EINVAL; - fixup = strlen(filename); - if ( fixup > 50 ) - { - filename += fixup - 47; - prefix = "..."; - } - lineno = bug_line(bug); - - switch ( id ) - { - case BUGFRAME_warn: - printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - return 0; - - case BUGFRAME_bug: - printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); - panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - case BUGFRAME_assert: - /* ASSERT: decode the predicate string pointer. */ - predicate = bug_msg(bug); - if ( !is_kernel(predicate) ) - predicate = ""; - - printk("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - show_execution_state(regs); - panic("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - } - - return -EINVAL; -} - #ifdef CONFIG_ARM_64 static void do_trap_brk(struct cpu_user_regs *regs, const union hsr hsr) { @@ -1292,7 +1213,7 @@ static void do_trap_brk(struct cpu_user_regs *regs, const union hsr hsr) switch ( hsr.brk.comment ) { case BRK_BUG_FRAME_IMM: - if ( do_bug_frame(regs, regs->pc) ) + if ( do_bug_frame(regs, regs->pc) < 0 ) goto die; regs->pc += 4; -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:31:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:31:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500925.772508 (Exim 4.92) (envelope-from ) id 1pVWIM-0005eg-TG; Fri, 24 Feb 2023 11:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500925.772508; Fri, 24 Feb 2023 11:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIM-0005eV-Pn; Fri, 24 Feb 2023 11:31:22 +0000 Received: by outflank-mailman (input) for mailman id 500925; Fri, 24 Feb 2023 11:31:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWIK-0004Yi-IV for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:31:20 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c16ed476-b436-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:31:18 +0100 (CET) Received: by mail-lj1-x235.google.com with SMTP id a10so13919272ljq.1 for ; Fri, 24 Feb 2023 03:31:18 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id v19-20020a2ea613000000b00295a815e555sm92682ljp.134.2023.02.24.03.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:31:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c16ed476-b436-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0G6bE1AlT3k8lziFMWj2l/M2niQSqBi5lrDekN1qx28=; b=GYUYtzeTNuhG3D/yG/hHVooXpxlTJ0x1pReKqll9NUaF9Vu0cEEK1hg3/zR3JOMXQ8 lDdRVSQFNDZlkxD8kj+VY4W7rge5cwmIGQ+ZXa3XpeD7lOcIZp/Y3kw7foaF46eanqg+ MB2JJ97nWiir3SLqq0fjOjmOddvri+8ZsaJvOpvFy88SZ+4T1vfhWUBwBYI8NR3OKsGo dx8xUMCl8rzmx8tH939fPYX0+HeWNlKykOXiRsrw8SrI5fYVSKnkIcH+fOMzToapoo7K c0cKow1BGl9yo6VU+RkDZf+A/O44J8Mhp0PkAzTALbeUhijVzhc15zrYWqNMGrC4WtSx U7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0G6bE1AlT3k8lziFMWj2l/M2niQSqBi5lrDekN1qx28=; b=jLjd0/pDDBuDOsBcQ49ost2w0cix1//Ex20I8Nk7GZtIlzl5Cylb080MAD4E2A/VZp FRW/8G7gAtzo190o+FX2u/XsQ4cnVNh0NlOwpBBF+AAbgYUv2iLfgqHf72ID2oN30Iv3 jldIrf2jmvMIu6VMVeWcSnufXyf+dR9DNbT7rsccsP3KUTC3CQlVUkILwS+DrJBv5Pvc 2vfSsK19NrYV8mOKYgG8UxlW8vlUQ0hD4H7v7SMZikQFG7ST7FZX6cmYJybpG4QXgXM7 QnTj0LSE9QqlRAfSnjps81E0DHk5axuB+tf0pX4xc+H/Lx6f1DLm0NYFpnWb54aIMhkm ZhbQ== X-Gm-Message-State: AO0yUKUifjhZEyFh9g20PEu0VmyzOk7nngQ4Mak25U2eWu5z+kaO0j38 bgIXww17nEMWtwol3bb89xR/ZPzmL5U= X-Google-Smtp-Source: AK7set9jt2Oel6r7VafLykfXdQdGunzpx2L3B48YkrPx2A0fDH3ADfKCtJqxLLOjL5rKb+ZkWvQ5AA== X-Received: by 2002:a2e:b045:0:b0:293:4be1:29df with SMTP id d5-20020a2eb045000000b002934be129dfmr5548154ljl.36.1677238277999; Fri, 24 Feb 2023 03:31:17 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 4/4] xen/x86: switch x86 to use generic implemetation of bug.h Date: Fri, 24 Feb 2023 13:31:07 +0200 Message-Id: <38bb75b9add8655288347aa4df1394450e4e10c9.1677233393.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following changes were made: * Make GENERIC_BUG_FRAME mandatory for X86 * Update asm/bug.h using generic implementation in * Change prototype of debugger_trap_fatal() in asm/debugger.h to align it with generic prototype in . * Update do_invalid_op using generic do_bug_frame() Signed-off-by: Oleksii Kurochko --- Changes in V3: * As prototype and what do_bug_frame() returns was changed so patch 3 and 4 was updated to use a new version of do_bug_frame * MODIFIER was change to BUG_ASM_CONST to align with generic implementation --- Changes in V2: * Remove all unnecessary things from as they were introduced in . * Define BUG_INSTR = 'ud2' and MODIFIER = 'c' ( it is needed to skip '$' when use an imidiate in x86 assembly ) * Update do_invalid_op() to re-use handle_bug_frame() and find_bug_frame() from generic implemetation of CONFIG_GENERIC_BUG_FRAME * Code style fixes. --- xen/arch/x86/Kconfig | 1 + xen/arch/x86/include/asm/bug.h | 73 ++------------------------ xen/arch/x86/include/asm/debugger.h | 4 +- xen/arch/x86/traps.c | 81 +++-------------------------- 4 files changed, 14 insertions(+), 145 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba..b0ff1f3ee6 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -11,6 +11,7 @@ config X86 select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 select CORE_PARKING + select GENERIC_BUG_FRAME select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ diff --git a/xen/arch/x86/include/asm/bug.h b/xen/arch/x86/include/asm/bug.h index 4b3e7b019d..d7eb41baf3 100644 --- a/xen/arch/x86/include/asm/bug.h +++ b/xen/arch/x86/include/asm/bug.h @@ -3,75 +3,10 @@ #ifndef __ASSEMBLY__ -#define BUG_FRAME_STRUCT +#define BUG_INSTR "ud2" +#define BUG_ASM_CONST "c" -struct bug_frame { - signed int loc_disp:BUG_DISP_WIDTH; - unsigned int line_hi:BUG_LINE_HI_WIDTH; - signed int ptr_disp:BUG_DISP_WIDTH; - unsigned int line_lo:BUG_LINE_LO_WIDTH; - signed int msg_disp[]; -}; - -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) -#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) -#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ - ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ - BUG_LINE_LO_WIDTH) + \ - (((b)->line_lo + ((b)->ptr_disp < 0)) & \ - ((1 << BUG_LINE_LO_WIDTH) - 1))) -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) - -#define _ASM_BUGFRAME_TEXT(second_frame) \ - ".Lbug%=: ud2\n" \ - ".pushsection .bug_frames.%c[bf_type], \"a\", @progbits\n" \ - ".p2align 2\n" \ - ".Lfrm%=:\n" \ - ".long (.Lbug%= - .Lfrm%=) + %c[bf_line_hi]\n" \ - ".long (%c[bf_ptr] - .Lfrm%=) + %c[bf_line_lo]\n" \ - ".if " #second_frame "\n" \ - ".long 0, %c[bf_msg] - .Lfrm%=\n" \ - ".endif\n" \ - ".popsection\n" \ - -#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ - [bf_type] "i" (type), \ - [bf_ptr] "i" (ptr), \ - [bf_msg] "i" (msg), \ - [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ - << BUG_DISP_WIDTH), \ - [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) - -#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ - BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ - BUILD_BUG_ON((type) >= BUGFRAME_NR); \ - asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ - :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ -} while (0) - - -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) -#define BUG() do { \ - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ - unreachable(); \ -} while (0) - -/* - * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, - * and use a real static inline here to get proper type checking of fn(). - */ -#define run_in_exception_handler(fn) \ - do { \ - (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ - BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ - } while ( 0 ) - -#define assert_failed(msg) do { \ - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ - unreachable(); \ -} while (0) - -#else /* !__ASSEMBLY__ */ +#else /* * Construct a bugframe, suitable for using in assembly code. Should always @@ -113,6 +48,6 @@ struct bug_frame { #define ASSERT_FAILED(msg) \ BUG_FRAME BUGFRAME_assert, __LINE__, __FILE__, 1, msg -#endif /* !__ASSEMBLY__ */ +#endif /* __ASSEMBLY__ */ #endif /* __X86_BUG_H__ */ diff --git a/xen/arch/x86/include/asm/debugger.h b/xen/arch/x86/include/asm/debugger.h index a5c299c6c3..1873dc5779 100644 --- a/xen/arch/x86/include/asm/debugger.h +++ b/xen/arch/x86/include/asm/debugger.h @@ -14,9 +14,9 @@ /* Returns true if GDB handled the trap, or it is surviveable. */ static inline bool debugger_trap_fatal( - unsigned int vector, struct cpu_user_regs *regs) + unsigned int vector, const struct cpu_user_regs *regs) { - int rc = __trap_to_gdb(regs, vector); + int rc = __trap_to_gdb((struct cpu_user_regs *)regs, vector); if ( rc == 0 ) return true; diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index cade9e12f8..7c33ebceff 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -24,6 +24,7 @@ * Gareth Hughes , May 2000 */ +#include #include #include #include @@ -1166,12 +1167,9 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, void do_invalid_op(struct cpu_user_regs *regs) { - const struct bug_frame *bug = NULL; u8 bug_insn[2]; - const char *prefix = "", *filename, *predicate, *eip = (char *)regs->rip; - unsigned long fixup; - int id = -1, lineno; - const struct virtual_region *region; + const char *eip = (char *)regs->rip; + int id; if ( likely(guest_mode(regs)) ) { @@ -1185,83 +1183,18 @@ void do_invalid_op(struct cpu_user_regs *regs) memcmp(bug_insn, "\xf\xb", sizeof(bug_insn)) ) goto die; - region = find_text_region(regs->rip); - if ( region ) - { - for ( id = 0; id < BUGFRAME_NR; id++ ) - { - const struct bug_frame *b; - unsigned int i; - - for ( i = 0, b = region->frame[id].bugs; - i < region->frame[id].n_bugs; b++, i++ ) - { - if ( bug_loc(b) == eip ) - { - bug = b; - goto found; - } - } - } - } - - found: - if ( !bug ) + id = do_bug_frame(regs, regs->rip); + if ( id < 0 ) goto die; - eip += sizeof(bug_insn); - if ( id == BUGFRAME_run_fn ) - { - void (*fn)(struct cpu_user_regs *) = bug_ptr(bug); - - fn(regs); - fixup_exception_return(regs, (unsigned long)eip); - return; - } - /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ - filename = bug_ptr(bug); - if ( !is_kernel(filename) && !is_patch(filename) ) - goto die; - fixup = strlen(filename); - if ( fixup > 50 ) - { - filename += fixup - 47; - prefix = "..."; - } - lineno = bug_line(bug); + eip += sizeof(bug_insn); switch ( id ) { + case BUGFRAME_run_fn: case BUGFRAME_warn: - printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); - show_execution_state(regs); fixup_exception_return(regs, (unsigned long)eip); return; - - case BUGFRAME_bug: - printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) - return; - - show_execution_state(regs); - panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); - - case BUGFRAME_assert: - /* ASSERT: decode the predicate string pointer. */ - predicate = bug_msg(bug); - if ( !is_kernel(predicate) && !is_patch(predicate) ) - predicate = ""; - - printk("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); - - if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) - return; - - show_execution_state(regs); - panic("Assertion '%s' failed at %s%s:%d\n", - predicate, prefix, filename, lineno); } die: -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500949.772524 (Exim 4.92) (envelope-from ) id 1pVWM5-0007XS-RT; Fri, 24 Feb 2023 11:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500949.772524; Fri, 24 Feb 2023 11:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM5-0007Wd-Lw; Fri, 24 Feb 2023 11:35:13 +0000 Received: by outflank-mailman (input) for mailman id 500949; Fri, 24 Feb 2023 11:35:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM4-0007Ri-Gr for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:12 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ca96701-b437-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:35:12 +0100 (CET) Received: by mail-lj1-x233.google.com with SMTP id h9so13753925ljq.2 for ; Fri, 24 Feb 2023 03:35:12 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ca96701-b437-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LEV0XXkwftLh/YYhu2PWBtw6xma6pefn5J7iR2uA1b8=; b=L3mCGaEwgUnEZk8uJDMAAGvHR0buasQ8IhDhO15TIhAmXamcOJV1NS2r9Zk6dO4XT2 Oq4KS5euJxgy/5Tx4G0ojC4iNMUWGbsczmHfURnPCFpt5HoNV4FQGf8tVtqsphK2Tgvd SmrCr3pkR+SgHdSDq8GzYEKqiKMhs7/Fm80v56SdOpxB02rGtbYkHeqcW29yOBZAxbam k5I+G3/3n7KEgtLDeKTwCPQv+URHCgzU//eqbbfyH/oztfsiz12ONrftYxpR7urg/wSC eaT3+GejRSw7IBaSaOhELaiF9rL1mxTqC8dVpb+ok0GtYXT7klBA1NTEpnRBi7My/70u l1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LEV0XXkwftLh/YYhu2PWBtw6xma6pefn5J7iR2uA1b8=; b=a1oDHuTjNaD3tXi+hgPhL1j0HpZFtPekojYA/G2/+SyS9MkpEQKdJ9l680sCRayGcf Az78IZY334bCeCM6zz4wtzPEaflniZfGwYHOGvAywfM8HC/5h1dohC5y1agqXv/nb7ov DHSNhz/7D9PGYRLckr+j1ZfSOHlDCKgXClIylqfJ6hpn8pPr/eHHWwBz0qus4C53X3fH MXTaXx45/UzahPXYtZfx+Jn2L0btm56f0ZrW2Jg5xXDxR86B7h76/whetCsDKYuJrowD OjhUW13sNS9+sbo9wmmg2Is2OqZ+A5uCHuGlqqczwWe8xPbLpoN6YYASetiubE3KRyfH JMKw== X-Gm-Message-State: AO0yUKWmODUfkcYxoGmJrSniJogHnflkLV3pkUqMglhfAum+czxTFJTJ 7JF1dgOpcBPy99z5LGpM3EyBRiCXBdE= X-Google-Smtp-Source: AK7set+4UsiLENwc9Yu3xAUF6hHU3jFibegHt+1QqE3NwHASdq0D9Wrbl2xtm0BO70wAZ2lAdhQRvw== X-Received: by 2002:a05:651c:a0e:b0:293:4cfe:ad31 with SMTP id k14-20020a05651c0a0e00b002934cfead31mr9704967ljq.14.1677238511687; Fri, 24 Feb 2023 03:35:11 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 1/5] xen/riscv: introduce decode_cause() stuff Date: Fri, 24 Feb 2023 13:35:01 +0200 Message-Id: <397e6741438a8b125dc53945a74a58246fac4faf.1677237653.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko --- Changes in V4: - fix string in decode_reserved_interrupt_cause() --- Changes in V3: - Nothing changed --- Changes in V2: - Make decode_trap_cause() more optimization friendly. - Merge the pathc which introduces do_unexpected_trap() to the current one. --- xen/arch/riscv/traps.c | 87 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index ccd3593f5a..29b1a0dfae 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -4,10 +4,95 @@ * * RISC-V Trap handlers */ + +#include +#include + +#include +#include #include #include -void do_trap(struct cpu_user_regs *cpu_regs) +static const char *decode_trap_cause(unsigned long cause) +{ + static const char *const trap_causes[] = { + [CAUSE_MISALIGNED_FETCH] = "Instruction Address Misaligned", + [CAUSE_FETCH_ACCESS] = "Instruction Access Fault", + [CAUSE_ILLEGAL_INSTRUCTION] = "Illegal Instruction", + [CAUSE_BREAKPOINT] = "Breakpoint", + [CAUSE_MISALIGNED_LOAD] = "Load Address Misaligned", + [CAUSE_LOAD_ACCESS] = "Load Access Fault", + [CAUSE_MISALIGNED_STORE] = "Store/AMO Address Misaligned", + [CAUSE_STORE_ACCESS] = "Store/AMO Access Fault", + [CAUSE_USER_ECALL] = "Environment Call from U-Mode", + [CAUSE_SUPERVISOR_ECALL] = "Environment Call from S-Mode", + [CAUSE_MACHINE_ECALL] = "Environment Call from M-Mode", + [CAUSE_FETCH_PAGE_FAULT] = "Instruction Page Fault", + [CAUSE_LOAD_PAGE_FAULT] = "Load Page Fault", + [CAUSE_STORE_PAGE_FAULT] = "Store/AMO Page Fault", + [CAUSE_FETCH_GUEST_PAGE_FAULT] = "Instruction Guest Page Fault", + [CAUSE_LOAD_GUEST_PAGE_FAULT] = "Load Guest Page Fault", + [CAUSE_VIRTUAL_INST_FAULT] = "Virtualized Instruction Fault", + [CAUSE_STORE_GUEST_PAGE_FAULT] = "Guest Store/AMO Page Fault", + }; + + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) + return trap_causes[cause]; + return "UNKNOWN"; +} + +const char *decode_reserved_interrupt_cause(unsigned long irq_cause) +{ + switch ( irq_cause ) + { + case IRQ_M_SOFT: + return "M-mode Software Interrupt"; + case IRQ_M_TIMER: + return "M-mode TIMER Interrupt"; + case IRQ_M_EXT: + return "M-mode External Interrupt"; + default: + return "UNKNOWN IRQ type"; + } +} + +const char *decode_interrupt_cause(unsigned long cause) +{ + unsigned long irq_cause = cause & ~CAUSE_IRQ_FLAG; + + switch ( irq_cause ) + { + case IRQ_S_SOFT: + return "Supervisor Software Interrupt"; + case IRQ_S_TIMER: + return "Supervisor Timer Interrupt"; + case IRQ_S_EXT: + return "Supervisor External Interrupt"; + default: + return decode_reserved_interrupt_cause(irq_cause); + } +} + +const char *decode_cause(unsigned long cause) +{ + if ( cause & CAUSE_IRQ_FLAG ) + return decode_interrupt_cause(cause); + + return decode_trap_cause(cause); +} + +static void do_unexpected_trap(const struct cpu_user_regs *regs) { + unsigned long cause = csr_read(CSR_SCAUSE); + + early_printk("Unhandled exception: "); + early_printk(decode_cause(cause)); + early_printk("\n"); + die(); } + +void do_trap(struct cpu_user_regs *cpu_regs) +{ + do_unexpected_trap(cpu_regs); +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500948.772517 (Exim 4.92) (envelope-from ) id 1pVWM5-0007So-D0; Fri, 24 Feb 2023 11:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500948.772517; Fri, 24 Feb 2023 11:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM5-0007Sh-AH; Fri, 24 Feb 2023 11:35:13 +0000 Received: by outflank-mailman (input) for mailman id 500948; Fri, 24 Feb 2023 11:35:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM3-0007Ri-MH for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:11 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bd9b731-b437-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:35:10 +0100 (CET) Received: by mail-lj1-x233.google.com with SMTP id h9so13753861ljq.2 for ; Fri, 24 Feb 2023 03:35:10 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:09 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bd9b731-b437-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ECAcOZyAZg3Dpbh3eSLd5IFMQTfPPWRvoFGodXIgSFw=; b=Iofvxq4DQPxocp3qHrjr3PYdeA4JbyjCZArwGn0tGHCLpZqYicU5bRku/Pxq5rzrUp VpMDGEzRdFW/c9kyIXmWMJyLs98eM6Fhs0lHJs03XzqqfSiW9oxYus/eeAjZE9tsl0I6 LXpt3kXN0BNZjuMGRSI72vSOE6FqPeFFUk9wFPE1OjgPRGGsQlUKcPd1FR5HrSWPqwTm zKRAFYw9q3Eu651L78RRmY18ppuAVW4IRt/FiezUnlax7bJbMYG5tHlig4fnXZfFaHQy hca/Ow07pou/lngYc0j9naKpAJ+Sdbd4XoXny2yu1ZGzFDzQ7iK1Rm6jO7mJpyxFvZpS FlPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ECAcOZyAZg3Dpbh3eSLd5IFMQTfPPWRvoFGodXIgSFw=; b=YwJriQpQINVhE2L8UlIWviz2Jd0q8H0ulQUIL92URMnH2qWleMHqtZxsc0ky3zQcK8 5A686NUjQRhqdWzkz9OoZLkx8ehPx0hhqf4BooDTqY9So+uoDaFIHHOyWd12Mq6141Jc 7WIa6HN9rg0cQHDgT56nCcOLfQIQcv8a7VRl7ppYlBOxnYGMXqmtFH+93qiO1SvobEwu 6PhpHvPzLg1Ce2UoP6uPQmjK/Pe76yCRHNZosrR5Qijefgx7+lwvuSBIQ6ec+0z14ej1 gowp0GUcGOzkcXLY2Y2wH2TIUe/+ILvo743+rjvj/u0VxXvTkmvHRgpX7wnWPQ3kWLie kJIw== X-Gm-Message-State: AO0yUKVNJxHsPLyNeKU2OecR0Q42gDD9pEWvqkqPV5FId7QT/JHG4kiH +IAMW2i+2r90lr6T7crJWAmHGoJ9AZI= X-Google-Smtp-Source: AK7set8TfNbsO2VU0reGOpxaezKx6LgtuB3hEs+cSb0Mugc2HEDpDislI8aa1WVXzK7d/NgVSur0Bw== X-Received: by 2002:a2e:bc0e:0:b0:294:6b9a:baa7 with SMTP id b14-20020a2ebc0e000000b002946b9abaa7mr8551645ljf.38.1677238510173; Fri, 24 Feb 2023 03:35:10 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v4 0/5] RISCV basic exception handling implementation Date: Fri, 24 Feb 2023 13:35:00 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series is based on [introduce generic implementation of macros from bug.h] which hasn't been commited yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instruction if an exception can not be handled. To verify that exception handling works well it was implemented macros from such as BUG/WARN/run_in_exception/assert_failed. The implementation of macros is used "ebreak" instruction and set up bug frame tables for each type of macros. Also it was implemented register save/restore to return and continue work after WARN/run_in_exception. Not all functionality of the macros was implemented as some of them require hard-panic the system which is not available now. Instead of hard-panic 'wfi' instruction is used but it should be definitely changed in the neareset future. It wasn't implemented show_execution_state() and stack trace discovering as it's not necessary now. --- Changes in V4: - Rebase the patch series on top of new version of [introduce generic implementation of macros from bug.h] patch series. - Update the cover letter message as 'Early printk' was merged and the current one patch series is based only on [introduce generic implementation of macros from bug.h] which hasn't been commited yet. - The following patches of the patch series were merged to staging: [PATCH v3 01/14] xen/riscv: change ISA to r64G [PATCH v3 02/14] xen/riscv: add header [PATCH v3 03/14] xen/riscv: add header [PATCH v3 05/14] xen/riscv: introduce empty [PATCH v3 06/14] xen/riscv: introduce empty [PATCH v3 07/14] xen/riscv: introduce exception context [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation [PATCH v3 10/14] xen/riscv: mask all interrupts - Fix addressed comments in xen-devel mailing list. --- Changes in V3: - Change the name of config RISCV_ISA_RV64IMA to RISCV_ISA_RV64G as instructions from Zicsr and Zifencei extensions aren't part of I extension any more. - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] - Update commit messages --- Changes in V2: - take the latest riscv_encoding.h from OpenSBI, update it with Xen related changes, and update the commit message with "Origin:" tag and the commit message itself. - add "Origin:" tag to the commit messag of the patch [xen/riscv: add header]. - Remove the patch [xen/riscv: add early_printk_hnum() function] as the functionality provided by the patch isn't used now. - Refactor prcoess.h: move structure offset defines to asm-offsets.c, change register_t to unsigned long. - Refactor entry.S to use offsets defined in asm-offsets.C - Rename {__,}handle_exception to handle_trap() and do_trap() to be more consistent with RISC-V spec. - Merge the pathc which introduces do_unexpected_trap() with the patch [xen/riscv: introduce exception handlers implementation]. - Rename setup_trap_handler() to trap_init() and update correspondingly the patches in the patch series. - Refactor bug.h, remove bug_instr_t type from it. - Refactor decode_trap_cause() function to be more optimization-friendly. - Add two new empty headers: and as they are needed to include which provides ARRAY_SIZE and other macros. - Code style fixes. --- Oleksii Kurochko (5): xen/riscv: introduce decode_cause() stuff xen/riscv: introduce trap_init() xen/riscv: introduce an implementation of macros from xen/riscv: test basic handling stuff automation: modify RISC-V smoke test automation/scripts/qemu-smoke-riscv64.sh | 2 +- xen/arch/riscv/include/asm/bug.h | 48 +++++ xen/arch/riscv/include/asm/processor.h | 2 + xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 21 +++ xen/arch/riscv/traps.c | 219 ++++++++++++++++++++++- xen/arch/riscv/xen.lds.S | 10 ++ 7 files changed, 301 insertions(+), 2 deletions(-) create mode 100644 xen/arch/riscv/include/asm/bug.h -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500950.772538 (Exim 4.92) (envelope-from ) id 1pVWM8-0007yh-2M; Fri, 24 Feb 2023 11:35:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500950.772538; Fri, 24 Feb 2023 11:35:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM7-0007ya-VH; Fri, 24 Feb 2023 11:35:15 +0000 Received: by outflank-mailman (input) for mailman id 500950; Fri, 24 Feb 2023 11:35:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM6-0007Ri-67 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:14 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d9edc5d-b437-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:35:13 +0100 (CET) Received: by mail-lj1-x229.google.com with SMTP id h3so7820599lja.12 for ; Fri, 24 Feb 2023 03:35:13 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d9edc5d-b437-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IcCcmDaZL5zu7cfe/7cHTiIVDkNgVS1oXLcUiC5qO7w=; b=JK3DMo2dMWh8dHqhVMFgjt/8fBVa204x55PqUZhNMcPl/464ndON30L8Gxp6y9mpDt HgAAYeyp4JGL2FjqSo8MCaVJHs7mhoW6pMBKY4A/GyW2N9dF/N6ggBMfM/BYVCu/d6qO t1Bsk4A0HQ/8pPyoXmyxS3HHoqpqpjOYT2TyNsAMeNqbB5bWUhnJ5lu9Ha631xMZ+Yvq ijKZ4nGskNg2xI07SDBO1c57YboWiyupmVEcttAyW8b67wEuJVUdlPZd9uWrsGua8K3w u1wdhALPqpJkXjXdfeAiQ0Hh5/7lz1HRPyJMWYuu7di3qR0rpvDBnDQSnnNgKzvJjKwg mqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IcCcmDaZL5zu7cfe/7cHTiIVDkNgVS1oXLcUiC5qO7w=; b=rEkongJXukuMETybYXu4/Dvwyjarsw+B/ROKX9G2gBQXstSadVTXq0XhphMrFGCC4t wxnABcB8JQvFLNjl3tK/AwaDKSKH7/mvhwnJ8Rdb7IkE9F5HXLEHcDsGXNrtebQ/ILvA YBRY/d3Opz7sSgZPumXl3Z//xxQHFlY44vrGBC+y/da1NqACEAGw7rn6Oc3vPfGMlAdp 6IzzHV4EQ1HZ/+0RSVdFmoyDpMr/N6Bm+VO2DNChq4EC+U/2jVhCvzAB0uZX3RmH2FFJ 7hqQRMPPKmrXaKSuZDFpSdG1I0tIdAeScVSPqOn069I/JfgrUjM0wQSFU+OVVu0Vz5Go oL5Q== X-Gm-Message-State: AO0yUKW4HBcK+aU9ojrhoaWbX0/gQe6SzHH6Iq4MedvGd7qbeIRNvQNx 6xLrLG/FRzW0QEnyfL7GqaaF4f0pJU4= X-Google-Smtp-Source: AK7set/EXM1tkclqIwZBSYHsUoP7ePa7hIn3WHt4VPvdZEUY/320uQhvIUMa3beAC7izmOId4sJqNA== X-Received: by 2002:a05:651c:547:b0:294:6361:6fe6 with SMTP id q7-20020a05651c054700b0029463616fe6mr7081109ljp.8.1677238513273; Fri, 24 Feb 2023 03:35:13 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 2/5] xen/riscv: introduce trap_init() Date: Fri, 24 Feb 2023 13:35:02 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed --- Changes in V2: - Rename setup_trap_handler() to trap_init(). - Add Reviewed-by to the commit message. --- xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 4 ++++ xen/arch/riscv/traps.c | 7 +++++++ 3 files changed, 12 insertions(+) diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h index f3fb6b25d1..f1879294ef 100644 --- a/xen/arch/riscv/include/asm/traps.h +++ b/xen/arch/riscv/include/asm/traps.h @@ -7,6 +7,7 @@ void do_trap(struct cpu_user_regs *cpu_regs); void handle_trap(void); +void trap_init(void); #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index d09ffe1454..c8513ca4f8 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,7 +1,9 @@ #include #include +#include #include +#include /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] @@ -11,6 +13,8 @@ void __init noreturn start_xen(void) { early_printk("Hello from C env\n"); + trap_init(); + for ( ;; ) asm volatile ("wfi"); diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index 29b1a0dfae..ad7311f269 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -13,6 +13,13 @@ #include #include +void trap_init(void) +{ + unsigned long addr = (unsigned long)&handle_trap; + + csr_write(CSR_STVEC, addr); +} + static const char *decode_trap_cause(unsigned long cause) { static const char *const trap_causes[] = { -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500951.772547 (Exim 4.92) (envelope-from ) id 1pVWMB-0008IN-A9; Fri, 24 Feb 2023 11:35:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500951.772547; Fri, 24 Feb 2023 11:35:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWMB-0008IC-72; Fri, 24 Feb 2023 11:35:19 +0000 Received: by outflank-mailman (input) for mailman id 500951; Fri, 24 Feb 2023 11:35:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM9-0007Ri-Cr for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:17 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f91104c-b437-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:35:17 +0100 (CET) Received: by mail-lj1-x236.google.com with SMTP id j17so14022782ljq.11 for ; Fri, 24 Feb 2023 03:35:17 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f91104c-b437-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hIxTAP/3TGyxLcEVY7CEZJFocAqIc1IBpnueXSNtmDY=; b=U+larZamfCH9mQ/VwojXLUSZs/o1gPlNXvwsNihd1K3DkqNEk91cGqCfuf2gQCJ66A DWwEsKOI28MaozS1WldORIM81djT2x+Mp+icOsWqOsZR8tohe3uewbUpJvTSZXfFims7 h7L/bo6K4+yxAPi/i1/ZojVrte53Xj3t+oZnc1W4eBaWkUXrtPnpnfw7VokgxWvcl4o7 rnMlfplee6O11yKaPFmgAcdL0irYbbcBOGfvTfT92KMwUgT1pornu+8so/qrTn1wLa9W 8/alYmPjcxS/8xrXx69JldcsmyBhm9V8JJCJt14BnQeBROJx6nnonlfdWRzIF0TyYEkG ZV8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hIxTAP/3TGyxLcEVY7CEZJFocAqIc1IBpnueXSNtmDY=; b=1wL1mwKKYolNxyLMhXgiK+UDs+DWUoKT5CutLIULCmBdTCn19MdZwPGQE33rlfa+Rm HXRxmZ+M05eAk4o7/KDFa999JvlOTUabs5QDGRpT5W/cU3qKpVhT6RuttT1bWErSgA9k xMpJ5iQscGrq+InTWPBA023u2qPG9HXHfcBt1OsU/2mienwumZRXe/VDycrsYsDXLYVq 7PbFWSXeJQllTGzXDf5gvksYdKJiH5ZPvaT7w0wf4giE6ECK6wmSoT0t6XeV//HFwm0l 6+mK/A8J97DkcPdgHc71XT/gjUcVQjn9QB6M+L1iUgxV3Ngyxmeg7Oc0M9EjeTHL5Bw1 pblQ== X-Gm-Message-State: AO0yUKUHalsvaub/XSgdCqexhz6+OgXovHG/bB1v3/jWqzMne07ubXqv wkAnEpCO9XHlxR6v7Gl2ss6ZETNrNj8= X-Google-Smtp-Source: AK7set/C7+Z9LsxeOBSwfXCljzTFBvEwKy3H2gCJtW4JKrebBOV4qBcf2dZyo9tINQj1Ny2AzLC+/g== X-Received: by 2002:a2e:7d08:0:b0:293:51ba:24b3 with SMTP id y8-20020a2e7d08000000b0029351ba24b3mr5522813ljc.41.1677238516392; Fri, 24 Feb 2023 03:35:16 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 4/5] xen/riscv: test basic handling stuff Date: Fri, 24 Feb 2023 13:35:04 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V4: - Add Acked-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes in V2: - Nothing changed --- xen/arch/riscv/setup.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 73b9a82883..b3f8b10f71 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -10,12 +10,28 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); +static void test_run_in_exception(struct cpu_user_regs *regs) +{ + early_printk("If you see this message, "); + early_printk("run_in_exception_handler is most likely working\n"); +} + +static void test_macros_from_bug_h(void) +{ + run_in_exception_handler(test_run_in_exception); + WARN(); + early_printk("If you see this message, "); + early_printk("WARN is most likely working\n"); +} + void __init noreturn start_xen(void) { early_printk("Hello from C env\n"); trap_init(); + test_macros_from_bug_h(); + for ( ;; ) asm volatile ("wfi"); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500952.772554 (Exim 4.92) (envelope-from ) id 1pVWMB-0008MQ-OI; Fri, 24 Feb 2023 11:35:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500952.772554; Fri, 24 Feb 2023 11:35:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWMB-0008LX-Gr; Fri, 24 Feb 2023 11:35:19 +0000 Received: by outflank-mailman (input) for mailman id 500952; Fri, 24 Feb 2023 11:35:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWM9-0008F6-JN for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:17 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e97e729-b437-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 12:35:15 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id m7so17451980lfj.8 for ; Fri, 24 Feb 2023 03:35:15 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e97e729-b437-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=51X9MeY84AeI86UksVCXFvV/ywJXDcqY/IRT+9++n+0=; b=Cm3iRbMNcUp94s2Ne+koA/IZarQkv+AuXuJQGinD3yoETGZxCS5ZTTBkWfUwQbTUDV +U0Omhk1NpXJlMZgGbmGgEktbRg0ISL7W5jRcyHCXR+DxUnpIsiYymmRqxahcTTF6xJt LzPoaiP69oL2FQmuu4J/Kcai1W8LGjDvFtxXHI3kZ3SRppYbcArl//S6cJElWlfbiwxS O83FiFSbyyzpAUmZhEfKcj4b9ycFlTQN98CdpLGO4JUKGg6BtqmRSET2Ysy04TS6s3Rf FZriy3YtvdXg/uWv6aX3M0cOP0gscdZlcDEQef+NAfpyO2VkLqZxkY5bY8FRE5OJQn/o mRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=51X9MeY84AeI86UksVCXFvV/ywJXDcqY/IRT+9++n+0=; b=ObOGbBgfFxVdrRTNSfXbz7xfaJams4uxJe1M5xmMA/jfnRaFVZx1FtFhusBIWDpGOx ALU44CYodzCes7xW+FdZMIv9GsoYu0t2Sd5SG7TRPhyvH96TVBasBJm8pUnwAdhr/sRx 7Ts4e9rhf2NKk0s2+KF4OTAD7u1ENTylu9GFsFJI9kPOqjz/7/7aROr78GY2+uh2dad5 r/HXfwwtGlVCy7DgG2O7fQ7XHOG3T9QDJUtnbHrXh1aNRJJjlId5W0G8gSM2uqIrOLVq RsZcQ1LMLWvMp7kLipGrbh331E78JaVH9hSbe0HIaKVVHwf1ci+StJ0jEh5xrtDPRrAF skew== X-Gm-Message-State: AO0yUKWzXP0zcYRN6knVS7eaYjy5IKJ3EClH5odZU9nwnEs4XOgCoPHB ZoPfl2Eg8HuTvOPyL0PP6zAwpPX+Xyg= X-Google-Smtp-Source: AK7set+oZ+AFDYIcbDmMMFFIbxZwMRNFhQH6aO+qx8QQaR//6vlQ2TEWysdF5xvyqn4sb4oxguCajg== X-Received: by 2002:ac2:5927:0:b0:4dd:9a38:fcc with SMTP id v7-20020ac25927000000b004dd9a380fccmr3430648lfi.63.1677238514815; Fri, 24 Feb 2023 03:35:14 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v4 3/5] xen/riscv: introduce an implementation of macros from Date: Fri, 24 Feb 2023 13:35:03 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. Signed-off-by: Oleksii Kurochko --- Changes in V4: - Updates in RISC-V's : * Add explanatory comment about why there is only defined for 32-bits length instructions and 16/32-bits BUG_INSN_{16,32}. * Change 'unsigned long' to 'unsigned int' inside GET_INSN_LENGTH(). * Update declaration of is_valid_bugaddr(): switch return type from int to bool and the argument from 'unsigned int' to 'vaddr'. - Updates in RISC-V's traps.c: * replace /xen and /asm includes * update definition of is_valid_bugaddr():switch return type from int to bool and the argument from 'unsigned int' to 'vaddr'. Code style inside function was updated too. * do_bug_frame() refactoring: * local variables start and bug became 'const struct bug_frame' * bug_frames[] array became 'static const struct bug_frame[] = ...' * remove all casts * remove unneeded comments and add an explanatory comment that the do_bug_frame() will be switched to a generic one. * do_trap() refactoring: * read 16-bits value instead of 32-bits as compressed instruction can be used and it might happen than only 16-bits may be accessible. * code style updates * re-use instr variable instead of re-reading instruction. - Updates in setup.c: * add blank line between xen/ and asm/ includes. --- Changes in V3: - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] --- Changes in V2: - Remove __ in define namings - Update run_in_exception_handler() with register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); - Remove bug_instr_t type and change it's usage to uint32_t --- xen/arch/riscv/include/asm/bug.h | 48 ++++++++++ xen/arch/riscv/include/asm/processor.h | 2 + xen/arch/riscv/setup.c | 1 + xen/arch/riscv/traps.c | 125 +++++++++++++++++++++++++ xen/arch/riscv/xen.lds.S | 10 ++ 5 files changed, 186 insertions(+) create mode 100644 xen/arch/riscv/include/asm/bug.h diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h new file mode 100644 index 0000000000..67ade6f895 --- /dev/null +++ b/xen/arch/riscv/include/asm/bug.h @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2021-2023 Vates + * + */ +#ifndef _ASM_RISCV_BUG_H +#define _ASM_RISCV_BUG_H + +#include + +#ifndef __ASSEMBLY__ + +#define BUG_INSTR "ebreak" + +/* + * The base instruction set has a fixed length of 32-bit naturally aligned + * instructions. + * + * There are extensions of variable length ( where each instruction can be + * any number of 16-bit parcels in length ) but they aren't used in Xen + * and Linux kernel ( where these definitions were taken from ). + * + * Compressed ISA is used now where the instruction length is 16 bit and + * 'ebreak' instruction, in this case, can be either 16 or 32 bit ( + * depending on if compressed ISA is used or not ) + */ +#define INSN_LENGTH_MASK _UL(0x3) +#define INSN_LENGTH_32 _UL(0x3) + +#define BUG_INSN_32 _UL(0x00100073) /* ebreak */ +#define BUG_INSN_16 _UL(0x9002) /* c.ebreak */ +#define COMPRESSED_INSN_MASK _UL(0xffff) + +#define GET_INSN_LENGTH(insn) \ +({ \ + unsigned int len; \ + len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ? \ + 4UL : 2UL; \ + len; \ +}) + +/* These are defined by the architecture */ +bool is_valid_bugaddr(vaddr_t addr); + +#endif /* !__ASSEMBLY__ */ + +#endif /* _ASM_RISCV_BUG_H */ diff --git a/xen/arch/riscv/include/asm/processor.h b/xen/arch/riscv/include/asm/processor.h index a71448e02e..ef23d9589e 100644 --- a/xen/arch/riscv/include/asm/processor.h +++ b/xen/arch/riscv/include/asm/processor.h @@ -69,6 +69,8 @@ static inline void die(void) wfi(); } +void show_execution_state(const struct cpu_user_regs *regs); + #endif /* __ASSEMBLY__ */ #endif /* _ASM_RISCV_PROCESSOR_H */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index c8513ca4f8..73b9a82883 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,3 +1,4 @@ +#include #include #include diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index ad7311f269..d87a9cfd2c 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -5,6 +5,7 @@ * RISC-V Trap handlers */ +#include #include #include @@ -99,7 +100,131 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) die(); } +void show_execution_state(const struct cpu_user_regs *regs) +{ + early_printk("implement show_execution_state(regs)\n"); +} + +/* + * TODO: change early_printk's function to early_printk with format + * when s(n)printf() will be added. + * + * Probably the TODO won't be needed as generic do_bug_frame() (at + * least, for ARM and RISC-V) has been introduced and current + * implementation will be replaced with generic one when panic(), + * printk() and find_text_region() (virtual memory?) will be + * ready/merged + */ +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) +{ + const struct bug_frame *start, *end; + const struct bug_frame *bug = NULL; + unsigned int id = 0; + const char *filename, *predicate; + int lineno; + + static const struct bug_frame* bug_frames[] = { + &__start_bug_frames[0], + &__stop_bug_frames_0[0], + &__stop_bug_frames_1[0], + &__stop_bug_frames_2[0], + &__stop_bug_frames_3[0], + }; + + for ( id = 0; id < BUGFRAME_NR; id++ ) + { + start = bug_frames[id]; + end = bug_frames[id + 1]; + + while ( start != end ) + { + if ( (vaddr_t)bug_loc(start) == pc ) + { + bug = start; + goto found; + } + + start++; + } + } + + found: + if ( bug == NULL ) + return -ENOENT; + + if ( id == BUGFRAME_run_fn ) + { + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); + + fn(regs); + + goto end; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_ptr(bug); + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + early_printk("Xen WARN at "); + early_printk(filename); + early_printk("\n"); + + show_execution_state(regs); + + goto end; + + case BUGFRAME_bug: + early_printk("Xen BUG at "); + early_printk(filename); + early_printk("\n"); + + show_execution_state(regs); + early_printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + + early_printk("Assertion \'"); + early_printk(predicate); + early_printk("\' failed at "); + early_printk(filename); + early_printk("\n"); + + show_execution_state(regs); + early_printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + } + + return -EINVAL; + + end: + return 0; +} + +bool is_valid_bugaddr(vaddr_t insn) +{ + if ( (insn & INSN_LENGTH_MASK) == INSN_LENGTH_32 ) + return ( insn == BUG_INSN_32 ); + else + return ( (insn & COMPRESSED_INSN_MASK) == BUG_INSN_16 ); +} + void do_trap(struct cpu_user_regs *cpu_regs) { + register_t pc = cpu_regs->sepc; + uint16_t instr = *(uint16_t *)pc; + + if ( is_valid_bugaddr(instr) ) { + if ( !do_bug_frame(cpu_regs, cpu_regs->sepc) ) { + cpu_regs->sepc += GET_INSN_LENGTH(instr); + return; + } + } + do_unexpected_trap(cpu_regs); } diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index ca57cce75c..139e2d04cb 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -39,6 +39,16 @@ SECTIONS . = ALIGN(PAGE_SIZE); .rodata : { _srodata = .; /* Read-only data */ + /* Bug frames table */ + __start_bug_frames = .; + *(.bug_frames.0) + __stop_bug_frames_0 = .; + *(.bug_frames.1) + __stop_bug_frames_1 = .; + *(.bug_frames.2) + __stop_bug_frames_2 = .; + *(.bug_frames.3) + __stop_bug_frames_3 = .; *(.rodata) *(.rodata.*) *(.data.rel.ro) -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 11:35:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 11:35:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.500953.772561 (Exim 4.92) (envelope-from ) id 1pVWMC-00006V-Cl; Fri, 24 Feb 2023 11:35:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 500953.772561; Fri, 24 Feb 2023 11:35:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWMC-00004z-59; Fri, 24 Feb 2023 11:35:20 +0000 Received: by outflank-mailman (input) for mailman id 500953; Fri, 24 Feb 2023 11:35:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWMA-0007Ri-Sy for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 11:35:19 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5052f9a5-b437-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 12:35:18 +0100 (CET) Received: by mail-lj1-x229.google.com with SMTP id h3so7820806lja.12 for ; Fri, 24 Feb 2023 03:35:18 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id a25-20020a05651c031900b00295a8d1ecc7sm50489ljp.18.2023.02.24.03.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 03:35:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5052f9a5-b437-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GhDjXc5QZ2qmKSV3xte4Vj9qFfnQzX3JEEqYRrvMiGo=; b=jXp3wZzXEtg1G0jPWq0OaoCQsDDxu+oWJIrpVKHkdyNfyKQwyYUBhjo8mGVi4yq3Qi ay1HcLtoWDgFrlVqzdFur6lNd3yAv4EE/q3JTVo0BzUNoTcW8uC/wck3ICPuitsWK12T AjmzVlfos9Hhj0DiPc4Ny6WR4ZZle5wD7sKV3OhFXoB6vhZFB+Ch+7rpnyqafKKDpKzY j4UJ9U94A4tZE0WRphuo885YeCuRVmpsZGl4pdCgltluhNvKsZNECbCUqyiXvU+4yvWu 6EZZp3DnTT1T0P2DSEQr2J6jB5266qQY56znJ4Ou610GopbmZ1d5rbKyoxaVSsUAUcnP VQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GhDjXc5QZ2qmKSV3xte4Vj9qFfnQzX3JEEqYRrvMiGo=; b=iYA5/myFtR1hRT5cPeNEo9VQgLR7y/u7o3952LFozSB3JcCZp20STSeeuYge6Lj05u xAGTdiV4uvgHc9+eyYSnwCMOzibijpFTJD0jS2yldZgUqQOl+XUyQrJG3jwWreLooo/s X2o1I4momDHD/P3z9eBxLH1egAj7ZUm2hve1pFxonBDTFz/JDmV+FbQfjiSdJitKxwlg 8f1XhXpIS9UAw3oV4FGIucUZCNKP0HzocehyPMOYjaHji0UmApWamcyBakbZxoeNLTDd I/TJgrh1ZSMXiePxGkxmLD/21Hdxoi4L6auki3Eva0bP2wHArSVXdXd9/4C++uQmt8nd RZlA== X-Gm-Message-State: AO0yUKUT2Q35f3ZcOac1lMMaT+aeyGKhIeXubLrXAu3Dj/rUHJgh9ndM 3kbXgG07lXcwYR1l5Er0s6Ors0xp62c= X-Google-Smtp-Source: AK7set+kCZYjX00+I0jYPqCcg9yoYxAzqNu5KXS1Wd2yZGjwj9ZtrcYK/48pkTgsXOl5R1e04CnJTA== X-Received: by 2002:a05:651c:b06:b0:295:733a:3463 with SMTP id b6-20020a05651c0b0600b00295733a3463mr7754865ljr.29.1677238517834; Fri, 24 Feb 2023 03:35:17 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein , Alistair Francis Subject: [PATCH v4 5/5] automation: modify RISC-V smoke test Date: Fri, 24 Feb 2023 13:35:05 +0200 Message-Id: <8a34b2b5ea5a948cdd4c608834f22c14ebe7ca6d.1677237653.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch modifies the grep pattern to reflect the usage of WARN. Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Acked-by: Stefano Stabellini --- Changes in V4: - Add Reviewed-by: Alistair Francis and Acked-by: Stefano Stabellini --- Changes in V3: - Update commit message --- Changes in V2: - Leave only the latest "grep ..." --- automation/scripts/qemu-smoke-riscv64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh index e0f06360bc..02fc66be03 100755 --- a/automation/scripts/qemu-smoke-riscv64.sh +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -16,5 +16,5 @@ qemu-system-riscv64 \ |& tee smoke.serial set -e -(grep -q "Hello from C env" smoke.serial) || exit 1 +(grep -q "WARN is most likely working" smoke.serial) || exit 1 exit 0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 12:02:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 12:02:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501016.772578 (Exim 4.92) (envelope-from ) id 1pVWm6-0006jd-0Y; Fri, 24 Feb 2023 12:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501016.772578; Fri, 24 Feb 2023 12:02:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWm5-0006jW-Sm; Fri, 24 Feb 2023 12:02:05 +0000 Received: by outflank-mailman (input) for mailman id 501016; Fri, 24 Feb 2023 12:02:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWm4-0006V3-J0 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 12:02:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c37f275-b43b-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 13:02:02 +0100 (CET) Received: from AM5PR0601CA0073.eurprd06.prod.outlook.com (2603:10a6:206::38) by PAVPR08MB8823.eurprd08.prod.outlook.com (2603:10a6:102:2fe::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 12:01:32 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:206::4) by AM5PR0601CA0073.outlook.office365.com (2603:10a6:206::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 12:01:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20 via Frontend Transport; Fri, 24 Feb 2023 12:01:32 +0000 Received: ("Tessian outbound 3ad958cd7492:v132"); Fri, 24 Feb 2023 12:00:28 +0000 Received: from eabc25f93461.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6ACC1B7B-4A5B-4E4B-9972-F2B39AE45AFB.1; Fri, 24 Feb 2023 12:00:21 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eabc25f93461.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Feb 2023 12:00:21 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by VE1PR08MB5837.eurprd08.prod.outlook.com (2603:10a6:800:1a9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 12:00:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::f0e7:5f67:ed2f:a70a%4]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 12:00:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c37f275-b43b-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zLOVVoAacto1Jzpzmq3jLyL8wvwRUK+oNZOTKsyOb6k=; b=4imvAfeOKgPHGXuVxAuGol7m6plEin9Nowgand5XEKSqwTGNqBJZNjWt0a2mqwCPajCEWloja3nTrpTXcXW8I/4DvM/VKI4+LTR34mxM+5X7HuEpVB4IiIjU5OR8sz4CIIxlhT3PwWosY2Vn9sCrDXnhrvYM6YqTu2c+vLVTUec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 78b1a55c1cf4cf18 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bfhoa6BV05xQjm/A/jjKppGAp1KcDhtevIGm0mRvzBBu4GTZt/tLxmCqldIEeLf3Bx3YX36YG16IChKGfQIEeg8A9SFCdwf5Ksua9EN2Q+QvloZEsQV+T8mrbyPRTLCi6NjktJXCE8Bat3DdSszaIiP5UlbiVyMG1gx6ubUMBFlFCjkNfzxe/vuhjiymu5QdKMn2el7floIjWk3vs3GghxlCrarJswVyjq1gcBRR2FtR4ulxVhGDn8opBjOh8dsHRNn3l44kl093rGfx5FC3Asaru+K4xRf6xDU6fg2TR7Aib54bPzu549JrEv+9HobD/jJKkWDhdpsSiYtKMArifA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLOVVoAacto1Jzpzmq3jLyL8wvwRUK+oNZOTKsyOb6k=; b=jGIY/un3Y/9gmeeScwr6QL4edv5axFw6Hd0qJRtHcO1JEu9okJAFxoQxkFtKusDL5MvYtkBJXI2j/b0O59xi/9GYALfgBVf2YYizakiWgUdb3PUZ5xi7jlakcxW8oNyokgLORBLEV1d18ZtHBDw7q9UZ2kyNo4aMVEy+S9kVeOleY7eMnF8ShJG4U3p3GPWiRD3nVm4xPBKxaoCM6SkeSiZjwS7gE5kQxBH/1VK3QZaHg/vFpOn2Ivfw6cckCxnDEg0+80c1bW3DJTma2TlO+yDxl546SQSPyZvZzj/gcMjSdX/YnHWC7zMQZATvgtmbHzjn69KyMUHh266tXZKvvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zLOVVoAacto1Jzpzmq3jLyL8wvwRUK+oNZOTKsyOb6k=; b=4imvAfeOKgPHGXuVxAuGol7m6plEin9Nowgand5XEKSqwTGNqBJZNjWt0a2mqwCPajCEWloja3nTrpTXcXW8I/4DvM/VKI4+LTR34mxM+5X7HuEpVB4IiIjU5OR8sz4CIIxlhT3PwWosY2Vn9sCrDXnhrvYM6YqTu2c+vLVTUec= From: Luca Fancellu To: Stefano Stabellini CC: Jan Beulich , Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json Thread-Topic: [PATCH 2/2] xen/misra: add entries to exclude-list.json Thread-Index: AQHZQFJXk2XcVjdJnEaLn2MagKXua67OM+KAgADR84CAALBGAIAA+Y0AgACOdYCAABDwAIABExCAgAusUYA= Date: Fri, 24 Feb 2023 12:00:18 +0000 Message-ID: <80D0D2C7-AA0A-490D-85E5-0CA3F5EECF34@arm.com> References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|VE1PR08MB5837:EE_|AM7EUR03FT033:EE_|PAVPR08MB8823:EE_ X-MS-Office365-Filtering-Correlation-Id: fb731e5c-b94e-4296-6cec-08db165edee6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QZxgKvbOFUH8AI1zBdwejEOceXrGqhK8Xr0HdTY3+QKy/WVm3z1ZTwmzoAudVqk3hP8LbYTTUQF62fWrMZKdSgxaIY4oyYoAID3S5sJrEMZsZCXQA4hOfph/Y+nBZ4VDbGwdLzpVboZAzXPZn4mHGr2IHlS6axZE3UxIWdtfEd3YUaNWmKoCs40xOzZfQ1wh0xVnsvfgCK3ve1DGt9OKoT0XJ10F1leZBcGBCa5V3NJFJHOSZXut2yu7yWY2wb5nlSq1r020npHM+3kCp3njTPvKsz/rIoxZI7m0JtiTUtaNDK+U2eITCgoH+jh0y9aqoAEqd7gKAwst76Fxe39z7NyEEzhpZkJFmsF/aQsTumBv+WPD8zOFmvnT7Q+y79c5j2FWOXGGDUpXqQu+3KvUl1kDuyW+4f+hEGSIA1YVQMFlNF37wWX0GnYzIzohHzpT49IjG8pOILhGR5LcFGBCljIeU/IrqyI9e2cD4DXJ/abQ/8REVS964hSDA+8z2nFnHH2wGwUijrqWc1sVWF7MzQRvYoaOdiFTjm9T4Ye0ofB24EQHRBRG+q13voqnASTytRneHVU/c4OnkcCkxqSHE+alHKfqU3QLg4y8l08DWhUIw+dNOVILxRxg9oddb8CONIgmgjfBTh7+Snha0vOL9iXRWIAvwLbG+gm9C6jgWcoUEq7J8rOP50EYUOjMRANzRDWVf0jdLKCoixmhBYGIeXRHEglILYzW/t5YuBA3QZw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199018)(86362001)(33656002)(38070700005)(478600001)(54906003)(36756003)(71200400001)(6486002)(41300700001)(66446008)(91956017)(5660300002)(8936002)(64756008)(2906002)(6916009)(316002)(66946007)(4326008)(66476007)(66556008)(76116006)(122000001)(38100700002)(8676002)(186003)(26005)(6506007)(2616005)(83380400001)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5837 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f8c296d-1f5f-4ef1-73cd-08db165eb2df X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QD5k760/ipP07hVrNCr8zq5NUtJlk0hRp/FK7tYI+klMyhg+Rsan3NCaqaTl/2W7rwSItbXiFhZ7PE6l3cltz9u3V9dU9rESTpyuttomXGK/zM8JK83HdpLZALhDR2YjDrl9v2G+nrrmCXERw0lUwvEIpGdu+SKmybUow+tcWgsDI52ON4EHgcOoGhpJKrhomeeaiJS2w7n8bmM36Hu97lVOhHpmVUQrFeqgeV1wcxfKNs4oTIXI+grev7ybSikCI6WwUPDif9ksy5W7+Ns4dgeneLLpZzTqa3RnKQCwxUKZb8vvQadm6EGl04KEh88FNSZVzQ/WnVML/r2jmDHJcmcrO3fFsdeI+EAhvRQ42/XA47EHjdAZqKz25lsM/qFQ8pGQ5M8zd4OZ3DegpsXtl1yGK30vpQfMlxnPQlq0e5Mtz5HZ8WntrPSUUVkDg5f/vNMEPA6xYMDaWYyCd7cZv4bO8Dgf0OQ45r3R4+QgU8f6Mzu2mQDpQwsHCtsfBz4vsMjVOGuBoaWg5OeIhV8ndoODoZ9UlMleVR/9uEMcjczLX7JoGomt4V7L4YX0eC4JkHGQss3H9aMsk2WGwaUy9RXU6/QlBLSjtQXoGI0MJiHfGSJ7MnMk6A97PPzM7YT/bT1DgmQcjdbrJQoDorIt1PNGY78G5mSMT6t5aWhqJoL1Md9BSp7xLkxqcqwiTdT4IL1DCEiqm5YWReFlBxk+Bg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199018)(46966006)(40470700004)(36840700001)(6486002)(40480700001)(36860700001)(47076005)(83380400001)(82310400005)(356005)(86362001)(33656002)(82740400003)(81166007)(6506007)(6512007)(336012)(36756003)(186003)(26005)(2616005)(40460700003)(5660300002)(6862004)(8936002)(54906003)(41300700001)(478600001)(70206006)(70586007)(316002)(2906002)(8676002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 12:01:32.4812 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb731e5c-b94e-4296-6cec-08db165edee6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8823 SGkgU3RlZmFubywNCg0KPj4gSGkgSmFuLA0KPj4gDQo+PiBteSBwZXJzb25hbCBvcGluaW9uIGlz IHRoYXQgd2UgY2Fu4oCZdCBoYW5kbGUgdGhlbSBmb3IgZmlsZXMgdGhhdCBuZWVkcyB0byBiZSBr ZXB0DQo+PiBpbiBzeW5jIGZyb20gYW4gZXh0ZXJuYWwgc291cmNlLCBiZWNhdXNlIHdlIGNhbuKA mXQganVzdGlmeSBmaW5kaW5ncyBvciB0YWcgZmFsc2UNCj4+IHBvc2l0aXZlcywgaWYgd2UgYXJl IGx1Y2t5IHdlIG1pZ2h0IGZpeCB0aGUgbm9uIGNvbXBsaWFuY2VzIGJ1dCBldmVuIGluIHRoYXQg Y2FzZQ0KPj4gdGhlcmUgbWlnaHQgYmUgdGltZXMgd2hlbiB0aGUgZml4IGdvZXMgdGhyb3VnaCBh bmQgY2FzZXMgd2hlcmUgdGhlIGZpeCBpcyBvYmplY3RlZA0KPj4gYnkgdGhlIG1haW50YWluZXJz IGp1c3QgYmVjYXVzZSB0aGVpciBwcm9qZWN0IGlzIG5vdCBmb2xsb3dpbmcgdGhlIE1JU1JBIHN0 YW5kYXJkLg0KPj4gDQo+PiBPbiBvdXIgc2lkZSwgd2hhdCB3ZSBjYW4gZG8gaXMgdHJhY2sgdGhl c2UgZmlsZXMgYW5kIGZyb20gdGltZSB0byB0aW1lIGNoZWNrIHRoYXQNCj4+IHRoZXkgYXJlIHN0 aWxsIGVsaWdpYmxlIHRvIGJhY2twb3J0LCBiZWNhdXNlIHdoZW4gdGhleSBhcmUgbm90IGFueW1v cmUgd2UgY291bGQNCj4+IGp1c3QgcG9ydCB0aGVtIHRvIFhlbiBjb2Rpbmcgc3R5bGUgYW5kIHN0 YXJ0IGRvaW5nIGRpcmVjdCBjaGFuZ2VzLg0KPj4gDQo+PiANCj4+IEBTdGVmYW5vL0BCZXJ0cmFu ZC9ASnVsaWVuIHRoYW5rcyBmb3IgeW91ciBlZmZvcnQgb24gdGhlIGxpc3QsIHllc3RlcmRheSBt b3JuaW5nDQo+PiBJ4oCZdmUgYWxzbyBoYWQgYSBsb29rIG9uIHRoZSBNaWNoYWzigJlzIGZpbGUg bGlzdCBhbmQgSeKAmXZlIHRyYWNrZWQgZG93biB0aGUgb3JpZ2luLCBoZXJlDQo+PiBteSBmaW5k aW5ncywgbWF5YmUgd2UgY291bGQgbWVyZ2UgeW91ciBsaXN0IHdpdGggbWluZT8NCj4gDQo+IFll cyB0byBtZXJnZSB0aGUgdHdvIGxpc3RzLCBidXQgSSB0aGluayB3ZSBzaG91bGQga2VlcCBvbmx5 IGl0ZW1zIHRoYXQgd2UNCj4gYWN0dWFsbHkgbmVlZCBmb3IgdGhlIHNha2Ugb2YgaGF2aW5nIGEg Y2xlYW5lciBiYXNlbGluZS4gU28gSSB3b3VsZCBvbmx5DQo+IGFkZCB0aGluZ3Mgd2UgbmVlZCB0 b2RheSB0byByZWR1Y2UgdGhlIG5vaXNlIG9uIGNwcGNoZWNrIHJlc3VsdHMNCj4gKGV4Y2x1ZGlu ZyAyMC43IGFuZCBhbHNvIGV4Y2x1ZGluZyB1bnVzZWRTdHJ1Y3RNZW1iZXIgd2hpY2ggSSB0aGlu ayB3ZQ0KPiBzaG91bGQgcHJvYmFibHkgc3RvcCBzY2FubmluZyB3aXRoIGNwcGNoZWNrIGFsdG9n ZXRoZXIpLg0KDQpZZXMgSSB0aG91Z2h0IGFib3V0IGV4Y2x1ZGluZyB1bnVzZWRTdHJ1Y3RNZW1i ZXIsIEkgc2VlIHRoZXJlIGFyZSBhIGxvdCBvZiBmaW5kaW5ncyBvbiB4ODYNCndoaWNoIGFyZSBu b3QgcmVhbCBmaW5kaW5ncywgaXTigJlzIGp1c3QgdGhhdCB0aGUgdG9vbCBoYXMgbm90IHRoZSBj b21wbGV0ZSBwaWN0dXJlLg0KDQpIZXJlIHRoZSB3YXlzIGFyZSB0d286DQoxKSBleGNsdWRlIGds b2JhbGx5IHVudXNlZFN0cnVjdE1lbWJlcg0KMikgZXhjbHVkZSB1bnVzZWRTdHJ1Y3RNZW1iZXIg b25seSBvbiBzb21lIHNlbGVjdGVkIGZpbGVzIChhdmFpbGFibGUgb25seSBvbiBjcHBjaGVjaykN CiAgICB0aGlzIHJlcXVpcmVzIHNvbWUgd29yayB0byBhZGQgYSBmaWVsZCB0byB0aGlzIGxpc3Qs IGxpa2Ug4oCcY3BwY2hlY2stZXJyb3ItZXhjbHVkZeKAnSBhbmQgYSBsaXN0LA0KICAgIGNvbW1h IHNlcGFyYXRlZCwgb2YgZXJyb3ItaWQgdG8gYmUgc3VwcHJlc3NlZCBmcm9tIHRoZSBjb3JyZXNw b25kaW5nIGZpbGUuDQoNClJlZ2FyZGluZyB0aGUgbGlzdCwgSSBtZXJnZWQgeW91ciBsaXN0IHdp dGggbWluZSAoYW5kIE1pY2hhbOKAmXMgd29yaykgdG8gY3JlYXRlIGEgY29tcGxldGUgbGlzdCwN CkkgdGhpbmsgaXTigJlzIGJldHRlciB0byBoYXZlIGl0IGNvbXBsZXRlIGJlY2F1c2UgYWxsIHRo b3NlIGZpbGVzIGFyZSBleHRlcm5hbCBhbmQgZXZlbiBpZiB0b2RheSB3ZSBkb27igJl0DQpoYXZl IGZpbmRpbmdzIGZvciBzb21lIG9mIHRoZXNlIGZpbGVzLCB3ZSBjb3VsZCBoYXZlIHNvbWUgaW4g dGhlIGZ1dHVyZSwgYW5kIHNpbmNlIHdlIGtub3cgdG9kYXkgDQp0aGF0IHdlIGNhbuKAmXQgZG8g ZGlyZWN0IGNoYW5nZXMgdG8gdGhlbSwgaW4gbXkgb3BpbmlvbiBpdOKAmXMgYmV0dGVyIHRvIGxp c3QgdGhlbSBub3cgaW5zdGVhZCBvZiBmb3JnZXR0aW5nDQp0aGVtIGxhdGVyLg0KDQpJIGxlZnQg b3V0IGZvciBub3cgdGhlc2UgZmlsZXMgdG8gc3RhcnQgYSBkaXNjdXNzaW9uIGZvciB0aGVtLCBi ZWNhdXNlIEkgdGhpbmsgdGhleSBzaG91bGQgYmUgaW5jbHVkZWQgaW4NCnRoZSBhbmFseXNpczoN Cg0KY29tbW9uL3N5bWJvbHMtZHVtbXkuYzoNCiAgdGhpcyBmaWxlIGFjY2VwdHMgZGlyZWN0IGNo YW5nZXMsIGNwcGNoZWNrIGNvbXBsYWlucyBhYm91dCBtaXNyYS1jMjAxMi04LjQgYnV0IEkgdGhp bmsgaXQgaXMgcmlnaHQsIGFsc28NCiAgQ292ZXJpdHkgY29tcGxhaW5zIGFib3V0IHRoZSBzYW1l IGZpbmRpbmdzLCB0aGV5IGNhbiBiZSBmaXhlZCBhZGRpbmcgZGVjbGFyYXRpb25zIG9uIHN5bWJv bHMuaCBJIHRoaW5rDQogIGFuZCByZW1vdmluZyB0aGUgZGVjbGFyYXRpb25zIGZyb20gc3ltYm9s LmMgbW9kdWxlDQoNCmNvbW1vbi92ZXJzaW9uLmM6DQogIEFwYXJ0IGZyb20gdW51c2VkU3RydWN0 TWVtYmVyLCBjcHBjaGVjayBpcyBjb25mdXNlZCBvbmx5IG9uIDIgZmluZGluZ3MgdGhhdCBjb21w YXJlcyBvbmUgbG9jYWwgc3ltYm9sDQogIGFuZCBvbmUgbGlua2VyIGRlZmluZWQgc3ltYm9sLCBj b3VsZCB3ZSBoYXZlIGp1c3Qgb25lIHRhZyB0byBzdXBwcmVzcyB0aG9zZSB0d28gZmluZGluZ3Mg aW5zdGVhZCBvZiByZW1vdmluZw0KICBjb21wbGV0ZWx5IHRoZSBmaWxlPyBUaGlzIGZpbGUgaXMg dW5kZXIgb3VyIGNvbnRyb2wsIHNvIHdlIGNvdWxkIHB1c2ggY2hhbmdlcy4NCg0KaW5jbHVkZS94 ZW4vbGliLmg6DQogIEZpbmRpbmdzIGFyZSBmcm9tIHRoZSBic2VhcmNoIGZ1bmN0aW9uLCB3aGlj aCBpcyBkZXJpdmVkIGZyb20gTGludXgsIGJ1dCBJIGNhbiBzZWUgdGhlIGNvZGVzdHlsZSBpcyB0 aGUgWGVuIHN0eWxlDQogIGFuZCBpdCBzZWVtcyAoSSBtaWdodCBiZSB3cm9uZykgdGhhdCBpdCBo YXMgZGl2ZXJnZWQgZnJvbSBMaW51eCwgc28gd2UgbWlnaHQgZG8gY2hhbmdlcyBhbmQgZml4IHRo ZSBmaW5kaW5ncyB0aGF0DQogIGFyZSBjb3JyZWN0LCB2b2lkKiBhcml0aG1ldGljIGlzIHdvcmtp bmcgYmVjYXVzZSBnY2MgbWFrZSBpdCB3b3JrIGFzc2lnbmluZyBhIHNpemVvZiBvZiAxLCB1c2lu ZyBjaGFyKiBwb2ludGVycyB3ZQ0KICBoYXZlIHRoZSBzYW1lIHJlc3VsdCB3aXRob3V0IGhhdmlu ZyB0aGUgdW5kZWZpbmVkIGJlaGF2aW91ciAoY29ycmVjdCBtZSBpZiBJIGFtIHdyb25nKS4NCg0K aW5jbHVkZS94ZW4vc29ydC5oOg0KICBBbHNvIHRoaXMgb25lIGlzIGRlcml2ZWQgZnJvbSBMaW51 eCwgYnV0IHNlZW1zIHRoYXQgd2UgY29udmVydGVkIGl0IHRvIG91ciBjb2Rpbmcgc3R5bGUgYW5k IHdlIGNhbiBkbyBkaXJlY3QgY2hhbmdlcywNCiAgdGhlIHNhbWUgcmVhc29uaW5nIGFib3V0IHZv aWQqIHBvaW50ZXJzIGFyaXRobWV0aWMgYXBwbGllcyBoZXJlLg0KDQoNCldoYXQgYXJlIHlvdXIg dGhvdWdodHM/DQoNCkhlcmUgdGhlIG1lcmdlZCBsaXN0LCBjYXB0dXJpbmcgYWxzbyBKYW4gY29t bWVudHM6DQoNCnsNCiAgICJ2ZXJzaW9uIjogIjEuMCIsDQogICAiY29udGVudCI6IFsNCiAgICAg ICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL2FybS9hcm02NC9jcHVmZWF0dXJlLmMi LA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25vcmUgZm9y IG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gv YXJtL2FybTY0L2luc24uYyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIG9uIExp bnV4Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC9h cm0vYXJtNjQvbGliL2ZpbmRfbmV4dF9iaXQuYyIsDQogICAgICAgICAgICJjb21tZW50IjogIklt cG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0K ICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvYWNwaS9ib290LmMiLA0KICAgICAgICAg ICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25vcmUgZm9yIG5vdyINCiAgICAg ICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gveDg2L2FjcGkvY3B1 X2lkbGUuYyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGln bm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgi OiAiYXJjaC94ODYvYWNwaS9jcHVmcmVxL2NwdWZyZXEuYyIsDQogICAgICAgICAgICJjb21tZW50 IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAg ICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvYWNwaS9jcHVpZGxlX21lbnUu YyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBm b3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJj aC94ODYvYWNwaS9saWIuYyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20g TGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAi cmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L2FtZC5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAi SW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7 DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9jcHUvY2VudGF1ci5jIiwNCiAgICAg ICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQog ICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9jcHUv Y29tbW9uLmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBp Z25vcmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRo IjogImFyY2gveDg2L2NwdS9oeWdvbi5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0 ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAg ICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9jcHUvaW50ZWwuYyIsDQogICAgICAgICAgICJj b21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0s DQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiYXJjaC94ODYvY3B1L2ludGVsX2Nh Y2hlaW5mby5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwg aWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0 aCI6ICJhcmNoL3g4Ni9jcHUvbWNoZWNrL25vbi1mYXRhbC5jIiwNCiAgICAgICAgICAgImNvbW1l bnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAg ICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9jcHUvbXRyci8qIiwNCiAg ICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ci DQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9j cHUvbXdhaXQtaWRsZS5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBM aW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJy ZWxfcGF0aCI6ICJhcmNoL3g4Ni9kZWxheS5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1w b3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQog ICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9kbWlfc2Nhbi5jIiwNCiAgICAgICAgICAg ImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAg fSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni9tcHBhcnNlLmMi LA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25vcmUgZm9y IG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImFyY2gv eDg2L3NyYXQuYyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgs IGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3Bh dGgiOiAiYXJjaC94ODYvdGltZS5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQg ZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAg ICAgICJyZWxfcGF0aCI6ICJhcmNoL3g4Ni94ODZfNjQvbW1jb25mLWZhbTEwaC5jIiwNCiAgICAg ICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQog ICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJjb21tb24vYml0bWFw LmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25vcmUg Zm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImNv bW1vbi9idW56aXAyLmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExp bnV4LCBpZ25vcmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJl bF9wYXRoIjogImNvbW1vbi9lYXJseWNwaW8uYyIsDQogICAgICAgICAgICJjb21tZW50IjogIklt cG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0K ICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL2luZmxhdGUuYyIsDQogICAgICAgICAgICJj b21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0s DQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL2xpYmZkdC8qIiwNCiAg ICAgICAgICAgImNvbW1lbnQiOiAiRXh0ZXJuYWwgbGlicmFyeSINCiAgICAgICB9LA0KICAgICAg IHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImNvbW1vbi9saXZlcGF0Y2hfZWxmLmMiLA0KICAg ICAgICAgICAiY29tbWVudCIgOiAiTm90IGluIHNjb3BlIGluaXRpYWxseSBhcyBpdCBnZW5lcmF0 ZXMgbWFueSB2aW9sYXRpb25zIGFuZCBpdCBpcyBub3QgZW5hYmxlZCBpbiBzYWZldHkgY29uZmln dXJhdGlvbnMiDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJj b21tb24vbHpvLmMiLA0KICAgICAgICAgICAiY29tbWVudCIgOiAiSW1wb3J0ZWQgZnJvbSBMaW51 eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxf cGF0aCI6ICJjb21tb24vbHo0L2RlY29tcHJlc3MuYyIsDQogICAgICAgICAgICJjb21tZW50Ijog IkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAg ew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL3JhZGl4LXRyZWUuYyIsDQogICAgICAg ICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAg ICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiY29tbW9uL3Vic2FuL3Vi c2FuLmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25v cmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjog ImNvbW1vbi91biouYyIsDQogICAgICAgICAgICJjb21tZW50IjogInVubHo0LmMgaW1wbGVtZW50 YXRpb24gYnkgWWFubiBDb2xsZXQsIHRoZSBvdGhlcnMgdW4qIGFyZSBmcm9tIExpbnV4LCBpZ25v cmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjog ImNvbW1vbi94ei8qIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51 eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxf cGF0aCI6ICJjb21tb24venN0ZC8qIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQg ZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAg ICAgICJyZWxfcGF0aCI6ICJjcnlwdG8vKiIsDQogICAgICAgICAgICJjb21tZW50IjogIk9yaWdp biBpcyBleHRlcm5hbCBhbmQgZG9jdW1lbnRlZCBpbiBjcnlwdG8vUkVBRE1FLnNvdXJjZSINCiAg ICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogImRyaXZlcnMvYWNwaS9h cGVpLyoiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25v cmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjog ImRyaXZlcnMvYWNwaS9od3JlZ3MuYyIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVk IGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAg ICAgICAicmVsX3BhdGgiOiAiZHJpdmVycy9hY3BpL251bWEuYyIsDQogICAgICAgICAgICJjb21t ZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQog ICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgiOiAiZHJpdmVycy9hY3BpL29zbC5jIiwNCiAg ICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ci DQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJkcml2ZXJzL2Fj cGkvdGFibGVzLmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4 LCBpZ25vcmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAgICAgICAgICAgInJlbF9w YXRoIjogImRyaXZlcnMvYWNwaS90YWJsZXMvKiIsDQogICAgICAgICAgICJjb21tZW50IjogIklt cG9ydGVkIGZyb20gTGludXgsIGlnbm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0K ICAgICAgICAgICAicmVsX3BhdGgiOiAiZHJpdmVycy9hY3BpL3V0aWxpdGllcy8qIiwNCiAgICAg ICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJvbSBMaW51eCwgaWdub3JlIGZvciBub3ciDQog ICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAgICJyZWxfcGF0aCI6ICJkcml2ZXJzL3ZpZGVv L2ZvbnRfKiIsDQogICAgICAgICAgICJjb21tZW50IjogIkltcG9ydGVkIGZyb20gTGludXgsIGln bm9yZSBmb3Igbm93Ig0KICAgICAgIH0sDQogICAgICAgew0KICAgICAgICAgICAicmVsX3BhdGgi OiAibGliL2xpc3Qtc29ydC5jIiwNCiAgICAgICAgICAgImNvbW1lbnQiOiAiSW1wb3J0ZWQgZnJv bSBMaW51eCwgaWdub3JlIGZvciBub3ciDQogICAgICAgfSwNCiAgICAgICB7DQogICAgICAgICAg ICJyZWxfcGF0aCI6ICJsaWIvcmJ0cmVlLmMiLA0KICAgICAgICAgICAiY29tbWVudCI6ICJJbXBv cnRlZCBmcm9tIExpbnV4LCBpZ25vcmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAgICAgIHsNCiAg ICAgICAgICAgInJlbF9wYXRoIjogImxpYi94eGhhc2gqLmMiLA0KICAgICAgICAgICAiY29tbWVu dCI6ICJJbXBvcnRlZCBmcm9tIExpbnV4LCBpZ25vcmUgZm9yIG5vdyINCiAgICAgICB9LA0KICAg ICAgIHsNCiAgICAgICAgICAgInJlbF9wYXRoIjogInhzbS9mbGFzay8qIiwNCiAgICAgICAgICAg ImNvbW1lbnQiIDogIk5vdCBpbiBzY29wZSBpbml0aWFsbHkgYXMgaXQgZ2VuZXJhdGVzIG1hbnkg dmlvbGF0aW9ucyBhbmQgaXQgaXMgbm90IGVuYWJsZWQgaW4gc2FmZXR5IGNvbmZpZ3VyYXRpb25z Ig0KICAgICAgIH0NCiAgIF0NCn0NCg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Feb 24 12:15:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 12:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501024.772588 (Exim 4.92) (envelope-from ) id 1pVWzM-0000Fd-6X; Fri, 24 Feb 2023 12:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501024.772588; Fri, 24 Feb 2023 12:15:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWzM-0000FW-3W; Fri, 24 Feb 2023 12:15:48 +0000 Received: by outflank-mailman (input) for mailman id 501024; Fri, 24 Feb 2023 12:15:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVWzK-0000FQ-5r for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 12:15:46 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f39cecf0-b43c-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 13:15:42 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 07:15:35 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6170.namprd03.prod.outlook.com (2603:10b6:408:11f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 12:15:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 12:15:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f39cecf0-b43c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677240942; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=QGNR8zoSD8SzLVJBMh89pR6xXz9DOYFM+df5Y1cUTVU=; b=ClGkQma/QCnzsZmEONQUzy2ouDrul0WtxzKgIs9+Q7J2XLWTHakzY6Il q3rke4PF4KTCKCbY4N9/YnKBk7nB+u5Jx8Z5qAOI7poDA9zsOWlsB4Ujr NtMA7GVBXvPh5YQI0bIxenH+l7/pp40Xp7G4eAGZ6dcRo22+A0gqjOEeW U=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 97230917 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lNSzI6g07dgkfcGysgSrgihxX161QhEKZh0ujC45NGQN5FlHY01je htvXm7VPP2OMWKjfY10PoXk8EIHu8fWndBgGVBsqns3Rnwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWCzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQEFHciPxmEgd7r+5GGE/YrieF5durkadZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReLiraY72QL7Kmo7ISczCBjj/N6FiWX9YfVCE x0e/CUhlP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDRLoViMA6tjn5Ys13hTGS486FLbv14OlXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:IhJlF6muiCffZDh7ZA7wv1rCmALpDfIX3DAbv31ZSRFFG/Fw9v re5cjzsCWetN9/YhAdcLy7VpVoOEmwyXct2+Us1NSZLW/bURWTXeJfBOLZqlWOJ8SZzJ856U 5OSdkbNDSaNzhHZKjBkWuF+whK+rO6GLrCv5a480tQ X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="97230917" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hE1JrfethE1OtGyi2KOBU38qVUFHsTzZAuUy8G5MEAttsLJf0N+e7vfmUbHlQ/q9jrL4vbIcMqgqseuCYqvmtcCN0xKEWVPZVgkkWrvu3PWiwDK0cxDOJSGIIZsseAqacMna8A/U6XunNuAX6gY2WNAAyUrMiVpnTP3C6XF51GIoPUqr+mcVuwYtKL+HesH8md6z0okQGkHC71GK7Z7t/zHIKHKY2Cn/TvC5UKMNdQZCR3Xu3d15OVBcn0YWTOkaX1F9hGKGYq+fQf7ZxQJCc6wbbTbAbzK2MJPQnNncMX/VeAGrVpzqQVKg1nz0+ZkJ8wT/paJmFEBGiTjM4mdfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4U8NCPg4+c5YLYKjwqjmKVf47QAqrWwrWpmb9THUcTc=; b=LGsObn6Dh/aJzmI/hNrwDhvjBexZG3R8Kwadotjv81muShNsOxTeElvwCsTfZNUp1sQQ+mC2NQn5An5Br4IZAjx4k7AG91FiFqoRuw2gaGD2WQ3ebY8p/roHIeSJXjBD7vA+8QDXUxKY3X1pNtEvQks3w+msQ8Z0/t5Ou5SlujW0siaLVGXCHtd/hlc4LSH5f1EssWtsbpBnD2cfEs1CdEuayQp7TZmd/RR3KqxT0A+HDrsWMWVhMAjKBpxQUj3dGqtDR5rtEV/fdS0FCsJ10XFSCIir2eSsXrXeDJWHbL1Ta9z9dKhzNH8uldWsJHoAGxj8qup37HVFJQ87TofWgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4U8NCPg4+c5YLYKjwqjmKVf47QAqrWwrWpmb9THUcTc=; b=mcYJiUf6qjMW7K83RZSC4+fW5lXobOz7icnbAIGE3MZSuIAY7KEPkaoR2qkIKk5oL/Wpr+13N8ynYp93PLUe3RwO/pXkPubTdz/7DDP4whlGSoX4EOP0bXPNsirX3sofdFXlbO2xpTxYcCMEfm2up0T1UC8a7VsxjApkx27fmYg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <46415d75-f6c3-f56f-f02c-cf2822735e8e@citrix.com> Date: Fri, 24 Feb 2023 12:15:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2] xen: Work around Clang-IAS macro \@ expansion bug Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230223203659.2594851-1-andrew.cooper3@citrix.com> <25dde064-0b6f-0871-d7bf-9cc99c104bfb@suse.com> In-Reply-To: <25dde064-0b6f-0871-d7bf-9cc99c104bfb@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0291.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6170:EE_ X-MS-Office365-Filtering-Correlation-Id: 4598afac-f511-402a-0ffe-08db1660d3aa X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O7OQhKc0ANKupbqqWdnKxkJzT4XHivJEkUU3ICR7pnpcNHuBvwrgvNX7f5zm92iuJErS1OnYLPhjpH8SBvSAXju5xM/NP6xPzDK+TKLeiT9Dt30guM9mo+1L6ItwTHqWHEorPiU4+A0mETPx8llN2XAcjkvAXs3YbbAbMoNKLVjnPd468SZ+/aY4jh65ZI5e60Gjj1l6Z7AKwMmq8sCNmCDzno/5nE34YJ++nDn3b6FbhG/vXWPAwLvdjDH4MZqoUYCxTLTVxwvla0o0XxigKY7eBZvkYfzEhjkbHzG3O+tAQAdzdMwJB8sd9aRyNXw9i/BxO5EK6+QHevF432n8942u3vUBGLHCPJJqAQojeuoKbhQPE3ShrHZMpTzv/iXekHED/1C6j5pZyVwlNuqNAhhAeV5620ccuCL6lHJjtbihr/SfrEmG2llqGMp1w1gKIsmfIlhQptiJKHidHahoPRcFXt0Xe8hQxyg0zl3aX1uZMEzR/zSkSb2EsNIHPYeavl8GWt3hs+OrpQ3QiIL3hiPo3dZeHaV3x/BN8+YsLGfd/3bZIahRIFrco1/NpCVax9djqz9JmvSZEoyMjwCTMRMWJ2vNiWxW5HU6Llql5IZWAPkR9oGCuYVY6dOlGjHt1RB7wMuUFR0WjIe1KnjX4xnkYilHkj/Wg+eaPZ3/5EPlHtl3y3QHSGnhNUhMILqbaLGaREERxgpOxwvgxYL3FlkqvqmJCFgbAkEaotNEF1o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199018)(186003)(26005)(5660300002)(41300700001)(31686004)(8936002)(8676002)(4326008)(6916009)(66946007)(66556008)(66476007)(31696002)(86362001)(6506007)(6486002)(2906002)(6512007)(966005)(53546011)(316002)(82960400001)(2616005)(478600001)(38100700002)(54906003)(36756003)(6666004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0F5Z1BqK1gxMkpzaWdTT2hKT3FrbGNJZnFubjc4MjdvMjJjN0ZRMVRFQWI0?= =?utf-8?B?VmhsRzg4R1NKYzRzS2M2aDhhcjhaZ01aLzZsOXVnTjF5dU1pZ05sck5NaG04?= =?utf-8?B?ZVFzK0hyZXEyTTBmNnpkYVlkZmorNFdleWNiQ2lzTVdMbjVCZ1NvK2RxbSsx?= =?utf-8?B?WGxFQWtBU3pzYWZFK2VoVmEwK2xGay9BNVFyckE0UjdNWnhiRXN1eTZlSC84?= =?utf-8?B?bGpqQlJwZ1ZVK3hRUTdHczBhTjIzTGhSRlZNcTdNcW5IS01waVMwdGpPSGc0?= =?utf-8?B?eUd5dGxKSHFBZGYrM0NxR2lxS2Z4Z0tidnZKT2RST0RycTRWK2JMRFVGSzR2?= =?utf-8?B?c2lUSWtxMmNoK2VmVjV5YlNtRzg3NzJXaFFLKzQrVjJTNGczZUtUby91VXVS?= =?utf-8?B?ZUVVQ2dnZVpWaTVUaVhHSU9iMnRGY2NRZjZ2Y1EwU3ZIOU9oakY1dGpnbWpw?= =?utf-8?B?bVJrN1JJR3VqVVJIbTNMcmY5NVBaZTgvNlBudS9ndWpLOXJXQ3V6L0tMTDI2?= =?utf-8?B?NDVBbnN4SjliR1JqZVRyalV6eGJTY0dkY1crd29uUHpNaG1QUWNCTTFJSTl2?= =?utf-8?B?enk4K3o3UnlQOHEvRklLVFpnNTZWVXpNUFZuTUlzcEVOaTA0K0RidUt2U0ky?= =?utf-8?B?MW5hcHRMMlZBNlV4RVU2bi9NTWJZbTBvc3paZ3FjSU0yNGNqZ1VwSlRjdHpB?= =?utf-8?B?d29XMlBydm1keitDQkJialNJOHJRdkR4MFhreElELzFuMnd3bWQ3S3gxdUJx?= =?utf-8?B?aWN5Y0ZUV0ZwTWtVdHpRM3VtR0ZJeU0ySmZadEdyTEppQ29PTmdYYTVTM09v?= =?utf-8?B?Wk5lamlvZlEyWFZrMUdUS2ZGWEpZbTZydVIrc0dwVXRqVUJqWFFNc0kwcU1i?= =?utf-8?B?ZWM3dXZ3czFtVVZDazhUSzB0aWhRbzlUZ09BSjBhQnlUNGN3SWltMndteUxU?= =?utf-8?B?SnlFblIwdCtpU2FPcHZZdjlSdnovTHNEZyt6ekpuMUpzZjh0cXBzMXN6YlNh?= =?utf-8?B?ZDIyaWlheDdIL2ZENllkMjF6VGVDM0NycGdGUmZoamlXbHhwcnZFaVZjZ0dW?= =?utf-8?B?c29ydFVFSCtrUEx3V3BvdjVvYURpdk1IVnZ4eGR0T21vRG9BbHNUZmRoQjdu?= =?utf-8?B?ZlNjUzdIeEd0czJWeHdndi9zSzFyUGRsMmZMdkhzU1dkOC8xVTJhMHZxS1l6?= =?utf-8?B?dGFzS0dYQXpySWIxV2ZZQXdOUllZYlNjVm9BRjBIdUhCNlJJNk8yZWgraXN4?= =?utf-8?B?U3JMbFVHNkZablY0SllzZ3M5Qm1ocWlXY0kxYVZRN0NnaERUaWs0NmRzeUNJ?= =?utf-8?B?WTAyZ2l5bnc0N28wZFUwWVZXNU5udEdObjJNYzVGelQ2RTVPZ2JOSnBKZ3Q1?= =?utf-8?B?TTJseHMxVDRQOHV5ME83L05NQjgzU1I2QTRzeWQ3VHJKMUlwVENWa2QzQWlm?= =?utf-8?B?cGNpdWFqMzZ1TXJkWC80UTRybU5rVUJyTHRFczR3Q29UaTRWVkczVDNBTW5E?= =?utf-8?B?a1MxNTZhS2NPV3FDSmIwMzF3ampBMW1YVlFuTFZjZDFvZmtmekl4Q2ZqbG9q?= =?utf-8?B?ZVI2Y1N0cXNsb0NZU0o4UGc5akZTOHZDOGFiQjlXSEVFV0RKK0JheDRROFJX?= =?utf-8?B?NGNyUm9oYVpXMlE5aEdEa3FFR0lhVW5ubVVxMVh1WjF5bzhVZVRiL3BTZ3F1?= =?utf-8?B?UUtuTEg4S2pxa0dpQVJ5SlZYSUl4b1JwUlJiN0RxQTI5Sm9ScVpRRHl4WEVD?= =?utf-8?B?UlNNNm9XTzFJYU5NelFWR1FFRmZMT0svZEc0djNLNXlpMk9xRS9wS3BiV3hG?= =?utf-8?B?aUhqT28zWFZLUHE1OGVGSURZd0RWSktOaVRxQkVLdXovOS8rM0MrWVJSTkEr?= =?utf-8?B?WXBRT2kvRVE4MzNNYi9KdzhqUjB4SVdYZUFQTFhwK05lMk5YWXZLb3piUklM?= =?utf-8?B?blhlUjZXSnpWd1h3YXpKb2hTbnhpdlZac1NFYmp6MlRZQTlQY1c2M2xsZ09k?= =?utf-8?B?aEtlRVl3UCt6MFV1aUVFa1RudzZ5bVVCdmNCckZoOWNyQWgyM0FBYUtZakl3?= =?utf-8?B?dlRLY3ZvS1RhWE5IR2NuUTl1LzV0bncyMmdCZUdiWUgySFM1d1NlbjhHNXJM?= =?utf-8?B?YjVxd2U2UWpQN3hYSzIzdlZpbjcveDMrTEtXN1N1bmIrSS8xR1FTYy9ORVpI?= =?utf-8?B?WFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PrWC2qiHJMfq2+oP2h9dSrIAKn1aQ529vT9KCixH7puildVhZCSoLbHxYiAXMxBuoZIKUAR85olCB5I6ePLJJhnmO5vWWnAe+LFeH+83nfIJkYu/3A5Xm3zxZXEYLCl3+v/CafuSKxQSap4LJqkwxTlvmK3Dn0/D5QLNHeCSFU0Diunnp1ThS6QEnobHgS1v22/THr08LsvIWQdxsQcfZOgQDsdbrJO9OJszt4PhU0r/eZoc8K0I8cMrJ2j/8aAEwz1SqgE4s+l4qsJ9mgFsPtDvda4JLwMTPhBhqnRpFjiGMYOQFFW0bMBBxT4CEue27yf9MUsJTrM3e7WI1U2G+xt2K47Gip449BIlS45qAmjg72udr5fl4uP0/aYu3q84X0UBs2iGI6dDwybGgmqcP2S2voHUuIJmTW/C6IJ5ZZF6SISS2/PUPEHg27/BHYoGj0ILSdcPTFF9GmexhBjDl9FEetruTqpbQKth4C/l8Xq+axQ+hVuYgrjPn7KlIHUKQTtQe6DOumwMRv3s12gYfzP5tWt1PfmuArRbAzuf9aVDo8h8x5Oj/4HeOactUaFFoOjcL4ZEwtGXKSp16u3b9KJyK1gXd2TFcKQXuI9iPdzfQRprA8p696GHfziJ2siKj+vGi4BIktgR5ppaF5pLot6kM/L1LHmu2DEZOLN5qS0VOAMDk9TjvtB5U75fj2yJJRVMm1BdHLvL2A/vRrHgUvF1sXQqnUmNZzkKt7wE9e6jXoFOJkBbJn4b10Kw/s3TQQoLcqRCGpw/0jhqTHKKqLQUiOVnFuK+VSP3yDqnCmeIMMt+TwLoky38q8jpcmbsrqMEYxGt7nx2TZXlA7i60g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4598afac-f511-402a-0ffe-08db1660d3aa X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 12:15:32.9522 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NWsuzsc+Rc3358mLcyYK7jA3w9i6kAraX16aWCeYxJlM/U8m1wHfU94iMy2OrL0hVWbxKievat8DlXtX6ng+6ghaUL2YShV3t/16RD7ri2E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6170 On 24/02/2023 7:14 am, Jan Beulich wrote: > On 23.02.2023 21:36, Andrew Cooper wrote: >> https://github.com/llvm/llvm-project/issues/60792 >> >> It turns out that Clang-IAS does not expand \@ uniquely in a translaition >> unit, and the XSA-426 change tickles this bug: >> >> :4:1: error: invalid symbol redefinition >> .L1_fill_rsb_loop: >> ^ >> make[3]: *** [Rules.mk:247: arch/x86/acpi/cpu_idle.o] Error 1 >> >> Extend DO_OVERWRITE_RSB with an optional parameter so C callers can mix %= in >> too, which Clang does seem to expand properly. >> >> Fixes: 63305e5392ec ("x86/spec-ctrl: Mitigate Cross-Thread Return Address Predictions") >> Signed-off-by: Andrew Cooper > A little hesitantly > Reviewed-by: Jan Beulich Thanks. > >> --- a/xen/arch/x86/include/asm/spec_ctrl.h >> +++ b/xen/arch/x86/include/asm/spec_ctrl.h >> @@ -83,7 +83,7 @@ static always_inline void spec_ctrl_new_guest_context(void) >> wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); >> >> /* (ab)use alternative_input() to specify clobbers. */ >> - alternative_input("", "DO_OVERWRITE_RSB", X86_BUG_IBPB_NO_RET, >> + alternative_input("", "DO_OVERWRITE_RSB xu=%=", X86_BUG_IBPB_NO_RET, > Especially with there possibly appearing more cases where we need to > add such, wrapping the extra parameter in a C macro continues to > seem better to me, for having a minimal level of documentation (I > has CLANG in the suggested name for exactly this purpose) right at > the place of use. The way you have it you force readers to go look > up the assembler macro and read through the commentary there in order > to find any explanation for the oddity. I'm not massively happy with the patch in this form, but it is less bad than splitting the name out. We do not separate out parameters elsewhere.  Doing so adds cognitive complexity to following the C, because now instead of having 2 places to look at to figure out what's going on, you have 3. Even a name like CLANG_EXTRA_UNIQUE is only meaningful to you and me.  Everyone else has to go and find the two other places to understand what's going on. Finally, and most importantly, despite having moved to a 2-char macro parameter name, there's still not a meaningful identifier here in C that's shorter. I do understand the want to try and make this more obvious, but adding cognitive complexity and code volume isn't a good way of improving things. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 13:10:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 13:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501035.772598 (Exim 4.92) (envelope-from ) id 1pVXqC-0008VZ-DF; Fri, 24 Feb 2023 13:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501035.772598; Fri, 24 Feb 2023 13:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXqC-0008VS-AE; Fri, 24 Feb 2023 13:10:24 +0000 Received: by outflank-mailman (input) for mailman id 501035; Fri, 24 Feb 2023 13:10:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXqA-0008VI-Dt; Fri, 24 Feb 2023 13:10:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXqA-0006S2-AO; Fri, 24 Feb 2023 13:10:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXq9-0001Bm-TI; Fri, 24 Feb 2023 13:10:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVXq9-0008TA-Sj; Fri, 24 Feb 2023 13:10:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X6ZfZT1bOta85499OFe0eD8bKQBNB/HNvYxN5zBjMZw=; b=BV9gYRAtKvv687mnflQUZhB5aV E24XQzmp32vH9ml20WmxXtzElY9XvkGql50Wgv4f/p6TBOup8HKu9c/O1qF2DPiO9I6xjKMaLujub jDcR1F72HqrwbpuoNsB/HpCapMNBhxLzTueeKVR39V1GwlPSzjQS5IOZ2/7G623NYpZE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178260: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=91d4d9506a4e8906253d1280bd5a1f39668fad64 X-Osstest-Versions-That: xen=c15e2d4c1c93d3d1744501b7f938db4ca23ee5e1 From: osstest service owner Date: Fri, 24 Feb 2023 13:10:21 +0000 flight 178260 xen-unstable real [real] flight 178348 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178260/ http://logs.test-lab.xenproject.org/osstest/logs/178348/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 178348-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 178348-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-shadow 7 xen-install fail like 178160 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178160 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178160 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178160 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178160 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178160 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178160 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178160 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178160 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178160 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 91d4d9506a4e8906253d1280bd5a1f39668fad64 baseline version: xen c15e2d4c1c93d3d1744501b7f938db4ca23ee5e1 Last test of basis 178160 2023-02-22 19:11:20 Z 1 days Testing same since 178260 2023-02-23 16:14:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Tamas K Lengyel Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c15e2d4c1c..91d4d9506a 91d4d9506a4e8906253d1280bd5a1f39668fad64 -> master From xen-devel-bounces@lists.xenproject.org Fri Feb 24 13:18:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 13:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501044.772616 (Exim 4.92) (envelope-from ) id 1pVXyB-00018W-AH; Fri, 24 Feb 2023 13:18:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501044.772616; Fri, 24 Feb 2023 13:18:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXyB-00018P-7P; Fri, 24 Feb 2023 13:18:39 +0000 Received: by outflank-mailman (input) for mailman id 501044; Fri, 24 Feb 2023 13:18:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVXy9-00018J-KN for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 13:18:37 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be1bb5b4-b445-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 14:18:35 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id l25so13480784wrb.3 for ; Fri, 24 Feb 2023 05:18:35 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be1bb5b4-b445-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bZMZWljjINbt3cbT8XvI8FDvFGZuMTOtIROv06JT5e8=; b=YrxrMEESeyWJv6DgP5n7pbFRLiSTIsXyQU8bOR1xG4Z9ENi5FKzm407nHECiPzIKxQ mOhY1Dzf6SHoSHbwyOW8H6hNz4uvU3yDHm01Mur/NaVcXkZGimUAKGRm0Aybomh4qcbA RK7GkWsgfk2p6dJ5wa35GGrW6ZpS0KXufLw/ajXVzhI6vvKmnPk2raYBoKe4ebVkwIRA s/atD4sQqH5FrTOkym/ZBWPm3l9EIKo2bIqI8LPG2yB1v6zNxuhM3qQsHQJYEAXP8Kom 9Z4K7516qIPcHQ9I4tOXxYUBtTLr0Z9xkkTAnJV2DAdpE6bAzAMlSTg7sCcHCkBluWSr Q65w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZMZWljjINbt3cbT8XvI8FDvFGZuMTOtIROv06JT5e8=; b=6FJl5Wwy93q2Gv1mYeu74PHcXhYanYUNuQm3x04rZk5y8sltIwgfljmihtcmJd4vnE 5mmMgF+zp4lCnlF9HTsYwNJ9RCIbHFfDlLXNYVdFO+L8nc1VOab2bvwIC4AQsXtqDaku j1c/eUH/Qw3tZetvPwE+KAw0BseQ/HzrPr25b3qHZPQvsdQ1AfUMNHWi4F055Bme1+XE 9AfXtaOYWt7EyZzQ7uJ9+g/qWEzpcJFwSIX+DUPrUZJal9Iv8i8hPkHwRGToZdP/U0F2 sVo1zZDnJr5VCNnSnzbJTu+LTOMggz6BRYuC1jHSY7IJCHSsC3ZpV2NMiTESR0jbp1zd i/Rg== X-Gm-Message-State: AO0yUKUSUfGLVoTCzilAw10EpCwMdN9PRnVJeGtxGZVZrQwX/6bk5Iqb O3GDv7X7zegZTRefrDKjjsmBmvXWzfSRZaO6s50sFA== X-Google-Smtp-Source: AK7set+DBzCY5Ru6dJrnynKF/H65JA8NtfVUfLf/+RDDrTa9eiM+lJbBaaG1wdDYYw6MxN1poR1cuQ5F+MWpayqlY8o= X-Received: by 2002:a05:6000:15c1:b0:2c7:cc8:7825 with SMTP id y1-20020a05600015c100b002c70cc87825mr1398138wry.3.1677244714968; Fri, 24 Feb 2023 05:18:34 -0800 (PST) MIME-Version: 1.0 References: <6B714A07-F3D0-4F27-BA66-078433430B3D@arm.com> In-Reply-To: <6B714A07-F3D0-4F27-BA66-078433430B3D@arm.com> From: Jens Wiklander Date: Fri, 24 Feb 2023 14:18:24 +0100 Message-ID: Subject: Re: [XEN PATCH v7 06/20] xen/arm: ffa: add flags for FFA_PARTITION_INFO_GET To: Bertrand Marquis Cc: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Hi Bertrand, On Fri, Feb 24, 2023 at 10:30 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Defines flags used for the function FFA_PARTITION_INFO_GET. > > > > Signed-off-by: Jens Wiklander > > --- > > xen/arch/arm/tee/ffa.c | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index aa6cdbe0a4f9..f4562ed2defc 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -56,6 +56,32 @@ > > #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > > FFA_MY_VERSION_MINOR) > > > > +/* > > + * Flags used for the FFA_PARTITION_INFO_GET return message: > > This is somehow no completely precise. > Could I suggest to use what the doc says: > Flags to determine partition properties in FFA_PARTITION_INFO_GET return message OK > > > > + * BIT(0): Supports receipt of direct requests > > + * BIT(1): Can send direct requests > > + * BIT(2): Can send and receive indirect messages > > + * BIT(3): Supports receipt of notifications > > + * BIT(4-5): Partition ID is a PE endpoint ID > > You describe all bits until 5 but not 6,7 and 8. > Please describe all of them to be coherent. OK > > > + */ > > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0, U) > > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1, U) > > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2, U) > > +#define FFA_PART_PROP_RECV_NOTIF BIT(3, U) > > +#define FFA_PART_PROP_IS_PE_ID (0U << 4) > > +#define FFA_PART_PROP_IS_SEPID_INDEP (1U << 4) > > +#define FFA_PART_PROP_IS_SEPID_DEP (2U << 4) > > +#define FFA_PART_PROP_IS_AUX_ID (3U << 4) > > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6, U) > > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7, U) > > +#define FFA_PART_PROP_AARCH64_STATE BIT(8, U) > > bits definitions are coherent with the standard > > > + > > +/* > > + * Flag used as parameter to FFA_PARTITION_INFO_GET to return partition > > + * count only. > > + */ > > +#define FFA_PARTITION_INFO_GET_COUNT_FLAG BIT(0, U) > > same here. Thanks, Jens > > Cheers > Bertrand > > > + > > /* Function IDs */ > > #define FFA_ERROR 0x84000060U > > #define FFA_SUCCESS_32 0x84000061U > > -- > > 2.34.1 > > > From xen-devel-bounces@lists.xenproject.org Fri Feb 24 13:37:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 13:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501052.772636 (Exim 4.92) (envelope-from ) id 1pVYFt-0004av-44; Fri, 24 Feb 2023 13:36:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501052.772636; Fri, 24 Feb 2023 13:36:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFt-0004ao-1F; Fri, 24 Feb 2023 13:36:57 +0000 Received: by outflank-mailman (input) for mailman id 501052; Fri, 24 Feb 2023 13:36:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFr-0004LB-SG for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 13:36:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d67cd02-b448-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 14:36:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d67cd02-b448-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677245815; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+p41LuGA6ZH/mH4WZJzQfHg34IdLZsNOgxsII11jPNw=; b=NS5Y681LWvY5qmQWxLoSdmHfbIxB8XJdQWa5oIfrks3Y0b1qCno0//VI lAkcVy5FvS6wlcMp8em5f8naDm8WEC7KJ2cLskr7W+tgGHorY8+SeNOeS i0TvlOe1w5mPdYtYgcEc5MUqiADhy988JH6xYDYfu+YY+rrXjcsjlgzAd g=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98414697 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:VkUb7aNvXiD9M5TvrR2tl8FynXyQoLVcMsEvi/4bfWQNrUon1DZRz mMaCG+DM6yJYGLyKowkPIu+8EtS6p6GyIRjSQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0slYLEpQz 6E1EWFXUjCutsCkzq6KF9A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLozkPmpgD/jdCdfq3qepLYt4niVxwt0uFToGIuFJoXWG5QK9qqej jP+zkjwKwpLDfy092aPrSiombbzugquDer+E5Xnr6U30TV/3Fc7ChIMUkCgieKkkUP4UNVaQ 2QL/gI+oK5081akJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpVTA9nJZoH3pwj AbPxo63Q2U169V5VE5x6J+7gh6ZJxJIAFZTPxMkYDon8df/kdwK20enoslYLIa5idj8GDfVy j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPdTA1LTN0RpXwG91pHGlt WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHRcRJG9eFoSTLkWVsDNZWdS9U3j4sI2OBX aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CK+LN4UROMcsJV/WlM2LWaJ39zqw+HXAbIllY cvLGSpSJSty5VtbIMqeGL5GjO5DKtEWzmLPX5HrpylLIpLHDEN5vYwtaQPUBshgtfPsnekg2 4oHXyd840kFAbKWj+i+2dJ7EG3m2lBiX8iu9JYIK7/TSuekcUl4Y8LsLXoaU9QNt8xoei3gp RlRhmcwJILDuED6 IronPort-HdrOrdr: A9a23:Ib6Edq9yrJCVMQYRarJuk+DiI+orL9Y04lQ7vn2YSXRuE/Bw8P re5MjztCWE8Qr5N0tQ+uxoVJPufZqYz+8Q3WBzB8bFYOCFghrLEGgK1+KLqFeMdxEWtNQtsp uIG5IOc+EYZmIbsS+V2meF+q4bsby6zJw= X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="98414697" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v1 2/2] backup_ptes: fix leak on realloc failure Date: Fri, 24 Feb 2023 13:36:46 +0000 Message-ID: <2f23492a3861a3ebddbf1f811296e98143b9b8f4.1677245356.git.edwin.torok@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török >From `man 2 realloc`: `If realloc() fails, the original block is left untouched; it is not freed or moved.` Found using GCC -fanalyzer: ``` | 184 | backup->entries = realloc(backup->entries, | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | | | | | (91) when ‘realloc’ fails | | | (92) ‘old_ptes.entries’ leaks here; was allocated at (44) | | (90) ...to here ``` Signed-off-by: Edwin Török --- tools/libs/guest/xg_offline_page.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c index c594fdba41..a8bcea768b 100644 --- a/tools/libs/guest/xg_offline_page.c +++ b/tools/libs/guest/xg_offline_page.c @@ -181,10 +181,13 @@ static int backup_ptes(xen_pfn_t table_mfn, int offset, if (backup->max == backup->cur) { - backup->entries = realloc(backup->entries, + void* orig = backup->entries; + backup->entries = realloc(orig, backup->max * 2 * sizeof(struct pte_backup_entry)); - if (backup->entries == NULL) + if (backup->entries == NULL) { + free(orig); return -1; + } else backup->max *= 2; } -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 13:37:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 13:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501053.772646 (Exim 4.92) (envelope-from ) id 1pVYFu-0004qH-CP; Fri, 24 Feb 2023 13:36:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501053.772646; Fri, 24 Feb 2023 13:36:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFu-0004q7-98; Fri, 24 Feb 2023 13:36:58 +0000 Received: by outflank-mailman (input) for mailman id 501053; Fri, 24 Feb 2023 13:36:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFt-0004am-BQ for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 13:36:57 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bae5d63-b448-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 14:36:54 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bae5d63-b448-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677245814; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cm/Hn5vaptcJiAlYcN7JDgSNF6QhhER+noAm3OqySF4=; b=IMgs2QUuKVdxmH1iFHcAMfSs8mW1kNY2QCsbv0hK28/PVa6iIYMTBjXT 5jXZvq0b+bb9CR5fxNu6KHHMbytv0kK3lTk1jnIQSrKZEKW3O2Cj+mpVU go/ogHYAhgniZ3RtgyekxkU9ue2aAw+TvPyVr6cd4fA4qnC7ayezmifDT 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98321074 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:QWrHOap7bfrWqmO513hF/xN5al5eBmIQZRIvgKrLsJaIsI4StFCzt garIBmGbvyCY2TzKoh0OYzkoR8Pv5LTydBjTAZupC8zHn5DpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSVNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADYhVC6IurOt+4+mbsdwjJx/cNHyE7pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVVpEyUo+wr5HLUzyR60aT3McqTcduPLSlQthfI/ Tifpzulav0cHIKekySMtVvvuvHOkQ/1AdsXObLlpsc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JPF8Uq5QfLzbDbiy6bCXIDVSVpc8E9uYk9QjlC6 7OSt4q3X3o16uTTEC/DsO7O9lteJBT5M0cESRU6RjZU+OLevaUdkhiXEop7CYGM24id9S7L/ xiGqy03hrM2hMEN1rmm8V2vvw9AtqQlXSZuuFyJAzvNAhdRIdf8Otf2sQSzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF5yLJ904DNJWfh0B3iM4ldjBM SfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlDYpX4xPxHNjjC8+KTJrU3YE c3GGftA8F5AUfg3pNZIb7p1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PXBt3VGJis+V2Pm /4Gbpvi9vmqeLGmCsUh2dJJfA9iwLlSLcyelvG7gcbaeFI+Rzt+Vq6BqV7jEqQ895loei7z1 inVcidlJJDX3BUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:uWYXOKCjBLEML3blHem955DYdb4zR+YMi2TDtnoddfUxSKfzqy nApoV56faKskdyZJhNo7690cq7LU80l6QU3WB5B97LYOCMggSVxe9ZjLcKygeQfhHDyg== X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="98321074" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak Date: Fri, 24 Feb 2023 13:36:45 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török Prior to bd7a29c3d0 'out' would've always been executed and memory freed, but that commit changed it such that it returns early and leaks. Found using gcc 12.2.1 `-fanalyzer`: ``` xg_core_x86.c: In function ‘xc_core_arch_map_p2m_tree_rw’: xg_core_x86.c:300:5: error: leak of ‘p2m_frame_list_list’ [CWE-401] [-Werror=analyzer-malloc-leak] 300 | return p2m_frame_list; | ^~~~~~ ‘xc_core_arch_map_p2m_writable’: events 1-2 | | 378 | xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (1) entry to ‘xc_core_arch_map_p2m_writable’ |...... | 381 | return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (2) calling ‘xc_core_arch_map_p2m_rw’ from ‘xc_core_arch_map_p2m_writable’ | +--> ‘xc_core_arch_map_p2m_rw’: events 3-10 | | 319 | xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, | | ^~~~~~~~~~~~~~~~~~~~~~~ | | | | | (3) entry to ‘xc_core_arch_map_p2m_rw’ |...... | 328 | if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) | | ~ | | | | | (4) following ‘false’ branch... |...... | 334 | if ( dinfo->p2m_size < info->nr_pages ) | | ~~ ~ | | | | | | | (6) following ‘false’ branch... | | (5) ...to here |...... | 340 | p2m_cr3 = GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width); | | ~~~~~~~ | | | | | (7) ...to here | 341 | | 342 | p2m_frame_list = p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | 343 | : xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | | | (9) ...to here | | | (10) calling ‘xc_core_arch_map_p2m_tree_rw’ from ‘xc_core_arch_map_p2m_rw’ | | (8) following ‘false’ branch... | +--> ‘xc_core_arch_map_p2m_tree_rw’: events 11-24 | | 228 | xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinfo, | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (11) entry to ‘xc_core_arch_map_p2m_tree_rw’ |...... | 245 | if ( !live_p2m_frame_list_list ) | | ~ | | | | | (12) following ‘false’ branch (when ‘live_p2m_frame_list_list’ is non-NULL)... |...... | 252 | if ( !(p2m_frame_list_list = malloc(PAGE_SIZE)) ) | | ~~ ~ ~~~~~~~~~~~~~~~~~ | | | | | | | | | (14) allocated here | | | (15) assuming ‘p2m_frame_list_list’ is non-NULL | | | (16) following ‘false’ branch (when ‘p2m_frame_list_list’ is non-NULL)... | | (13) ...to here |...... | 257 | memcpy(p2m_frame_list_list, live_p2m_frame_list_list, PAGE_SIZE); | | ~~~~~~ | | | | | (17) ...to here |...... | 266 | else if ( dinfo->guest_width < sizeof(unsigned long) ) | | ~ | | | | | (18) following ‘false’ branch... |...... | 270 | live_p2m_frame_list = | | ~~~~~~~~~~~~~~~~~~~ | | | | | (19) ...to here |...... | 275 | if ( !live_p2m_frame_list ) | | ~ | | | | | (20) following ‘false’ branch (when ‘live_p2m_frame_list’ is non-NULL)... |...... | 282 | if ( !(p2m_frame_list = malloc(P2M_TOOLS_FL_SIZE)) ) | | ~~ ~ | | | | | | | (22) following ‘false’ branch (when ‘p2m_frame_list’ is non-NULL)... | | (21) ...to here |...... | 287 | memset(p2m_frame_list, 0, P2M_TOOLS_FL_SIZE); | | ~~~~~~ | | | | | (23) ...to here |...... | 300 | return p2m_frame_list; | | ~~~~~~ | | | | | (24) ‘p2m_frame_list_list’ leaks here; was allocated at (14) | ``` Fixes: bd7a29c3d0 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") Signed-off-by: Edwin Török --- tools/libs/guest/xg_core_x86.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 61106b98b8..69929879d7 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -297,6 +297,8 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf dinfo->p2m_frames = P2M_FL_ENTRIES; + free(p2m_frame_list_list); + return p2m_frame_list; out: -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 13:37:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 13:37:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501051.772626 (Exim 4.92) (envelope-from ) id 1pVYFr-0004LO-Pw; Fri, 24 Feb 2023 13:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501051.772626; Fri, 24 Feb 2023 13:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFr-0004LH-MW; Fri, 24 Feb 2023 13:36:55 +0000 Received: by outflank-mailman (input) for mailman id 501051; Fri, 24 Feb 2023 13:36:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVYFr-0004LB-BQ for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 13:36:55 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b1705b0-b448-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 14:36:53 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b1705b0-b448-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677245813; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=sligjGhE8zp3txxXLxxDw/E3mUVI6/l5sCV442ETKLo=; b=XjM+ceeAEadGfmuMioL1cD8i2lFx5yS9XYBaXOJmFac086JL8d8eCbz3 e+KpLSKcrTw2E5ClvXY5lEE7+0mrqa8rvx/cbcYPXJfMnsWlfyMlvVEEK e+RC6/3AGc8cFSVNYaAr13PaqH/rKo/4lgKFBych82HHJHMaV4BfBA65s E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98414694 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:qXFGeKnnYVUdPMvBgjz2wvbo5gyJJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdWWmCOf6LY2f9fN10PN7k9E0HsZ/UndVrSgVopC01EyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 fkeczU0dznavMfo+5ucZc9Kq/ghA/C+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglHyfyNZrhSJorAw4EDYzRBr0airO93QEjCPbZQFwh/E+ DOal4j/KggbP86w0DWnzlyh2qzGx3LKQ6ciNYTto5aGh3XMnzdOWXX6T2CTo/ajjVWlc8lCM EFS8S0rxYAt8GS7Q9+7WAe3yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBeeNAx/ gbXxZWzX2Up6eDLDyvHrd94sA9eJwAQKzQHXDYtFDAgveLKh64VqD/zTPlaRfvdYsLOJRn8x DWDrS4bjroVjNIW26jTwW0rkw5AtbCSEFdru1y/snaNq1ogOdX7P9DABU3zt64oEWqPcrWWU JHoceC65ftGM5yCnTflrA4lTODwvKbt3NExbDdS83gdG9aFoSPLkWN4umsWyKJV3iEsKFfUj Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMcuLVDYpn4zNB7Bt4wIrKTLuftiU ap3jO72VSpKYUiZ5GfeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9cWGZimtsRtfveyC2Mq oY3Cid/40kHOAEISnWNoNF7wJFjBSRTOK0aXOQOLLbbfVA5RTBxYxITqJt4E7FYc21uvr+g1 hmAtoVwkTITWVWvxd22V01e IronPort-HdrOrdr: A9a23:RSlYHal907ntCY/7oo0jx1/d/pLpDfI93DAbv31ZSRFFG/Fw9v rCoB1/73SftN9/YgBCpTn+AtjjfZqxz/BICOoqUYtKPjOHhILAFugL0WKI+VLd8kPFl9K13J 0QFpRDNA== X-IronPort-AV: E=Sophos;i="5.97,324,1669093200"; d="scan'208";a="98414694" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v1 0/2] fix memory leaks reported by GCC -fanalyzer Date: Fri, 24 Feb 2023 13:36:44 +0000 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Edwin Török Using GCC 12.2.1 with -fanalyzer it has shown some memory leaks: This is how I enabled -fanalyzer (adding it to CFLAGS for toplevel configure didn't seem to work): ``` CFLAGS += $(call cc-option,$(CC),-fanalyzer) ``` Note that there are more errors shown than fixed here, but they seem to be false positives (which is why this flag cannot, yet, be enabled by default). Edwin Török (2): xc_core_arch_map_p2m_tree_rw: fix memory leak backup_ptes: fix leak on realloc failure tools/libs/guest/xg_core_x86.c | 2 ++ tools/libs/guest/xg_offline_page.c | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.39.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:48:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501081.772655 (Exim 4.92) (envelope-from ) id 1pVZN4-00070r-JP; Fri, 24 Feb 2023 14:48:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501081.772655; Fri, 24 Feb 2023 14:48:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZN4-00070k-GX; Fri, 24 Feb 2023 14:48:26 +0000 Received: by outflank-mailman (input) for mailman id 501081; Fri, 24 Feb 2023 14:48:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZN2-00070e-AA for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:48:24 +0000 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [2a00:1450:4864:20::236]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4849c744-b452-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 15:48:21 +0100 (CET) Received: by mail-lj1-x236.google.com with SMTP id j17so14566922ljq.11 for ; Fri, 24 Feb 2023 06:48:21 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id z9-20020a2e3509000000b0029352fc39fbsm1481923ljz.63.2023.02.24.06.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 06:48:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4849c744-b452-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gqs1O6BrGgUjBQwv5/Wo5K7s6aN+rCmfuqoj9RJz1Dk=; b=VY3iQtCSyiHWtlJtvrkE+Ni53vTwmU+SlXRpkj53JYYSUiERSOMph4wjCg37+Jva9R DNGG9yKB/jzbgoNnpImhgJYP+BWBGEyc3JzH4fw6XtQb6KZTkvk+qO2KBcOWcUTt6TMb cvv/oNOkDhS5LampNYg11+qytj1xbIBO9SM+AwcTj0Gxpnm4nqjcx056JSIZRDeMfGUA nOT9DgP39zP7DwFLxayembvtdrDMp6+lZuWnrp84r/T41B+hSuqRBk6lmUHiCor6lnaT TtOe1APZUkVM6dpmuGyx6TQpN1z88LT1bd3Ggf4rDzdG3V7tgvOuTSkDpy2OIn8nRJIX hs4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gqs1O6BrGgUjBQwv5/Wo5K7s6aN+rCmfuqoj9RJz1Dk=; b=hkBuMXTyOGUzGTwaoTaSAkU3McORwigQrj4TzlyAxZpSmZnit0rsqsn2qT6CQGFDdv ygWeR+pQpU88XO1bV9y+BSqO+KMI8Cmnk6ANCqqAR77qFRHcwo4BVpSz2UmJkqHgUrHV LwiUnSyf0I2WpBB0gfV39ujPDW1+9ckYq/N3AojPdNEVQ3FG0P7nY7rUsSrx3nqdodZk N9KeYbLl/LejhIecssioDCXfGZinvtoqz1+/l/IEW9dZw7Fwk2jgyUL2zInPU6g9kixk OeTh1Hn1htrsov+Y3xcSLuy2p45hyIX96PAig3W7SN17tHmhWfFyacrfuRjs7CFH9n5/ 4Liw== X-Gm-Message-State: AO0yUKUxzqZwnvauFK63IZUM4XXPBThRwdSc6wE10Gj2z0v2YjH0NyOG VDxrdN/2rs7svdavmgFROKiemkrPa54= X-Google-Smtp-Source: AK7set9qi5LCaooJ9u5U5ZW7+Lui02JjCe57lsfjGowWKdLjWJrzgztFZWxXXxJ55Qd5hnArzVDnDA== X-Received: by 2002:a2e:9e44:0:b0:295:8c47:dca6 with SMTP id g4-20020a2e9e44000000b002958c47dca6mr4385392ljk.17.1677250100386; Fri, 24 Feb 2023 06:48:20 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader Date: Fri, 24 Feb 2023 16:48:14 +0200 Message-Id: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index b3f8b10f71..154bf3a0bc 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) void __init noreturn start_xen(void) { + /* + * The following things are passed by bootloader: + * a0 -> hart_id + * a1 -> dtb_base + */ + register unsigned long hart_id asm("a0"); + register unsigned long dtb_base asm("a1"); + + asm volatile( "mv %0, a0" : "=r" (hart_id) ); + + asm volatile( "mv %0, a1" : "=r" (dtb_base) ); + early_printk("Hello from C env\n"); trap_init(); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:48:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:48:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501083.772666 (Exim 4.92) (envelope-from ) id 1pVZNN-0007Jx-S8; Fri, 24 Feb 2023 14:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501083.772666; Fri, 24 Feb 2023 14:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZNN-0007Jp-P5; Fri, 24 Feb 2023 14:48:45 +0000 Received: by outflank-mailman (input) for mailman id 501083; Fri, 24 Feb 2023 14:48:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZNM-00070e-Fs for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:48:44 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55476ef1-b452-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 15:48:43 +0100 (CET) Received: by mail-lf1-x135.google.com with SMTP id k14so17220114lfj.7 for ; Fri, 24 Feb 2023 06:48:43 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id d17-20020ac244d1000000b004d6f86c52fcsm1479313lfm.193.2023.02.24.06.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 06:48:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55476ef1-b452-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zE4IPS4UCnrjNybkfHTwwWZ+bHlMLh1Uu83yRnN418M=; b=nfmGl78c01HgnzMp9tMUAxo10ulXYs6n8mGgh3XahUm2rRQeUVWc2fzONkWy/EOfu1 x2zbY1kLg6+lIxlpsCo3A3+os9bn9agg9CcMDj/mJDgtnEQ6FrS3w5V7l956BwSEg4mW rxcuHGn11/QGyCmFd11u1c5NqC2ltTynpaEr8QrObZ3SeGfhM0WIaD4bN3WsbB6XRL4N CtL9dBbLPTV4zwhjUfW45kkNq1TtQD2+7KY2aD+v3pguma+ZQ1cmXVURbCA/Dfl6xZQd 1NtJ4reuR5e356lmEmoVJM5yGuGM7PSDfWbY4dqFNErnZ4TdldRty/gMTQHf91UKS4J9 /akg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zE4IPS4UCnrjNybkfHTwwWZ+bHlMLh1Uu83yRnN418M=; b=aEKEJgHNjMNNeLLMEy0EA1gr0LHnCzE9FSbwNNqheUdTT4hOylS1Fpornw+Xm+DbA2 blNacPrpopvfmywkJWnRNwbQGETERKKEoPpWT4Skn2K4gIyExRJYaLX/GoKVcTjBLAsT JDNHc+/IVwlO4MK5dQQi1Ao5tUFHJpHEqNVs7wpVpSzkIvm0ar68JS/5bTpZw/L8+Y3q EYqrgljLUWKUn0wSv7IjRPqMrPHnAt+vzM8Vpqifd68hJUL0304x5Lk4XhIxE2y1X8VQ cP6EsORsheaGUVDHT0yiQuOf+rAEQJai589DX5frBLgInEBVaHqusubnIUDofFKS6jBD 8zHQ== X-Gm-Message-State: AO0yUKWa8X74SOWESNYJqzgeSW/qBYeX3OkX0IKlAI4/AgX3pbzYFypK aFWUdXLXspzQNphtUpnd2zZYYFPyERo= X-Google-Smtp-Source: AK7set9vJ697IP+nk//T7zYy/ptm8U77xBsVVccpAs6bRffBH5FVq1IgULmOX0l6o0R/9SmLJ/2Ong== X-Received: by 2002:ac2:52aa:0:b0:4dd:aefc:8777 with SMTP id r10-20020ac252aa000000b004ddaefc8777mr396583lfm.47.1677250122327; Fri, 24 Feb 2023 06:48:42 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH] xen/riscv: init bss section Date: Fri, 24 Feb 2023 16:48:38 +0200 Message-Id: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 154bf3a0bc..593bb471a4 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) early_printk("WARN is most likely working\n"); } +static void __init init_bss(void) +{ + extern char __bss_start; + extern char __bss_end; + char *bss = &__bss_start; + + while ( bss < &__bss_end ) { + *bss = 0; + bss++; + } +} + void __init noreturn start_xen(void) { /* @@ -38,6 +50,8 @@ void __init noreturn start_xen(void) asm volatile( "mv %0, a1" : "=r" (dtb_base) ); + init_bss(); + early_printk("Hello from C env\n"); trap_init(); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:48:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501086.772676 (Exim 4.92) (envelope-from ) id 1pVZNY-0007iA-3a; Fri, 24 Feb 2023 14:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501086.772676; Fri, 24 Feb 2023 14:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZNY-0007i0-0u; Fri, 24 Feb 2023 14:48:56 +0000 Received: by outflank-mailman (input) for mailman id 501086; Fri, 24 Feb 2023 14:48:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZNX-0007IB-4m for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:48:55 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c43c133-b452-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 15:48:54 +0100 (CET) Received: by mail-lf1-x12c.google.com with SMTP id n2so14923450lfb.12 for ; Fri, 24 Feb 2023 06:48:54 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id b4-20020ac25624000000b004a6f66eed7fsm1571158lff.165.2023.02.24.06.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 06:48:53 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c43c133-b452-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Hs9xct8hb/nlXAK7Nyc2whENbhfxbFpjP6SpILZy2o=; b=FPNQbAO9m/t3pUb9Qq4/M/P+igikEs6zD8PA2Ec+U1BmOqn0F44xgZIuYxHUrsNr8u lZm1KUwOPTzrStl/+XXPcUaNkPV2BMHaMhfBB0CSp9N5X8APiChTuHvkp6uMjimIJFoG pZvcGXgft91aAd6F8bEWNC540FFGjwxqO8X8fkFuMpLwg8T638ymRnBp6KYUXE/S5who Kb664/anteIkDPTHIi67LKVOz4kgx9BVz/CFXT2IXbIfW0X4JMBEpi7XVlR0Bd0SxPsF /NoBqTZtnmG23UUPNd0+0mSG9pGzT+9xGGKXY1sG/NwLE2j30Mf+gZa9FhxLPk9CIFZ/ tvWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Hs9xct8hb/nlXAK7Nyc2whENbhfxbFpjP6SpILZy2o=; b=vdRE81T/oGX6b8jlL0VJV4kAKpfdBg9m+lWpxTR7pRVema7kB++d0Z8ELV1zkfAz1M SVJCOXzU3pVmrYonAzcCOWddcYKyoNLp92avkLm8khpOfbPuXjSsqeWTT92a8AOYsg/c q0n6v6Tg86+ZUf84tuUy9Xfr/j4CTFCLYcb/+meKb19+3xxQd+xHWssBLqraGuCSnVaz RpzzBvYHGqnDVSOMq9tD5S6/J52bgED1L7w/G/O+xj086VSS84C/cJ/yJw4pZIYDd325 XUsYrDOTUuFvK0YENiWnR1XPyfroni4HcA+bNCy/Z36pV/wk72dOv+IYzmMEX8tGLh1U RjrQ== X-Gm-Message-State: AO0yUKVE7Lkzo1g2sNrltUH3B5XoyYYYT+60YIjHGLcaxLJP36szYPzW ictR7OXj+3LpBi/0MshCvtm1VoYIqzQ= X-Google-Smtp-Source: AK7set8XUbyS+x4trNUwRHRaJheIJVa3nylABL8kQj57GkzJC17ug5YeZT4f4LbHhu/zXi5WMySxiA== X-Received: by 2002:ac2:4f10:0:b0:4dd:840d:462 with SMTP id k16-20020ac24f10000000b004dd840d0462mr5633142lfr.21.1677250134025; Fri, 24 Feb 2023 06:48:54 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH] xen/riscv: disable fpu Date: Fri, 24 Feb 2023 16:48:50 +0200 Message-Id: <63c797ba52f6d7edc64f9d2e41b460c7d64330ae.1677249707.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Disable FPU to detect illegal usage of floating point in kernel space. Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 593bb471a4..b7cd438a1d 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -36,6 +36,11 @@ static void __init init_bss(void) } } +static void __init disable_fpu(void) +{ + csr_write(CSR_SSTATUS, SSTATUS_FS); +} + void __init noreturn start_xen(void) { /* @@ -52,6 +57,8 @@ void __init noreturn start_xen(void) init_bss(); + disable_fpu(); + early_printk("Hello from C env\n"); trap_init(); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:56:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:56:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501101.772686 (Exim 4.92) (envelope-from ) id 1pVZUn-0001bM-1G; Fri, 24 Feb 2023 14:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501101.772686; Fri, 24 Feb 2023 14:56:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZUm-0001bF-UR; Fri, 24 Feb 2023 14:56:24 +0000 Received: by outflank-mailman (input) for mailman id 501101; Fri, 24 Feb 2023 14:56:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZUk-0001b9-U0 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:56:23 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6649226c-b453-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 15:56:21 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9554.eurprd04.prod.outlook.com (2603:10a6:10:302::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Fri, 24 Feb 2023 14:56:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 14:56:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6649226c-b453-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GX35uCpbvwZ5h0EpVlmgTOfcDcXWcv9gfnGclLStyTzqT5f8CYjVR5iwrKLhOpyGPwc/rz9LQd5Yrv5NttKRACj7MomZpcd9g/OBw903iAmgKpjebkvhFJwGGuqbwcYPihL7g0k+J2nSlTCAvzaiTQmcOEEGq1LCFSkwhpzW4vX+m6lohIuTVtXCdYNGkcv2WELoKFa7JxFLB3PvyulHt7Kv6lIeFiueUTDLQQ5jpqa/vsho5JHWhiMc5yTY4GciMEO1zZmKCyAEPFKaszXj9cFKjvC0wx/y7a7Xlylmqi98nDdOsFYy3u/IlOVgsMsVO5yzvZdp0foF8v2583IIdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IHEEUfUF20HxZ5D3lpWO3zDJYtU2QA0Xdgfe/VrBu3Q=; b=SZRCO6KBkFB6xDBPBDpk2SwaazRBnRUflNDrqorK98mkmpHexLHPFex+4fMtH+Vexa6HgJPlo7rzxxM1nHeyQZ5lGSsw28gJjYG9Mi60/Vh2E7Sc/cV2p5TilAiFmLB+m0fkCoVzgHE8o46W8n2nHB2BdTxQfOfFla4+ShU6Sph7qImZWHUVu3Okw6O7yoiWYb8o01Igg1oX2RS7NC0hnpe20DsrKl998p4OnAsQ78A0UgXV1dfJZ3Q7RlcEcRSd4fFBo4JzkW1M1d7qk2p5oJts0UNxqra29+Rfdq9NBRp46mHziSoiaDDUYaKbDtBW9uRYU6w9dqUHmOmK4HswLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IHEEUfUF20HxZ5D3lpWO3zDJYtU2QA0Xdgfe/VrBu3Q=; b=0Sx03MlRs8PL5iaPa1ExKSpkTtv6eLsAM536raajbwvYb+xUrcikozzDRhLs2JYRH81iFO4g2y1zV0/zPBfcFK4LiGE5nWBlEtsPP4aj+KjChZbaPmU7wdj71YpObAPUSXoGERjaXYai77GzAhMkwa/lpTjCn1CP2rWy1xawJDU1HCdvBz7fqFB4uHyUBP8WY+1Z8NL+5OQT9iMVj+7+/h7uooBC64XdgnuJGWSEbtgrM/TqCVeRh1E5YEH9uPMqYo1cpcjHFN8B3fjBt+E0T7YcGVjJQMWKKWjGCLBsv5C+w0tg3mlxAHjgtpK/CnRPKdNhbaRK5B7ceNGsMiqEHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 24 Feb 2023 15:56:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: init bss section Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9554:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e391f9d-114b-46ff-343a-08db1677493c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T4c7PDDUzjMNO9MT20o2IxkOPY7tAinyHg6bzfwqiffRYYmvZvSGAkEdyKedZa/32e0+UAm4Mar3ZMk7mKLiwgkM8WPn8XC20hG1sWPm4LE/C7fyicMtwMHzY8ptmU1Yv7vGtL0X0B1YvIL7ekyckxwMJcC65WZp9FLekpGi2Wy0+JGqozKA56xaizh+kN+MXhjjLXy7JCnWMpxsiBl7lz+don7L38jrzzS75xyHwB0NEkCx51EW9qD8RD/VRpBxLgqOr6ZcJ073N5aaW5u3aDnLuhpkqEOzV5yMq74EbgoasTRgwE3M1sq5FkhslFQPEVp25UZbDlsKnwEpouowe01xlbTeR2pVuME5kTVXspN2oD9/ccyVLekOsvo/Tr/M++Gfd08oZruwoncQlCBn1j93SzkLTGp2/pSkrH0OPCw7JvXMusWgIaFXimOZxITOzRdvAog4KArD227m4g198p+/V+TPzS65Mnj9/ou1gnoN3C1xl8IgkXV7lOeW+8tECwATCJYdeliCR7/Myxd93BpRgq9hmXj3UIUIMdzwqWQBxiA59bjOBLjXX5iM1W5YWn1I8k9q3pN68oEiVu3uUjkeyf2OW5AdVzLBOMpPrEosVLcYivtjI9LtdtIeaiK7VYCCLME9cUWDbZrMlw5mxvGTiJNfWaJbLMqLxg7RpahqGColpQtcNtJZgoWMhcXcSSN+keIz+0iYyhMz5/Xt8GobasC074e2KKrzGo01ZgU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199018)(66946007)(53546011)(86362001)(31696002)(38100700002)(8676002)(6486002)(31686004)(66556008)(66476007)(2616005)(316002)(478600001)(54906003)(4326008)(6666004)(36756003)(6916009)(6506007)(2906002)(26005)(186003)(6512007)(8936002)(5660300002)(4744005)(83380400001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmM3cTFkd3hlNEVrOHFKVTMvR3Z3WnNGdGQ5eG9XWlozV0JPSnN6R0ZvVnU3?= =?utf-8?B?RGZLK1FzVk5XNkRJcGM0eUFYdXB1NGVIVmpNanVBMVFVb3FiRDV6OWwwSTlG?= =?utf-8?B?VHZaWkNYUFFXRGNHVFJHd1UzcnRxTXVwWVZrbDBwQVgvamdXaHlxM0plR3Mx?= =?utf-8?B?WjIzdmYxSmRPR1hyVGtnaXIzL1ZDRkdNUXp5aHcxOUZJVlZ3WTRLQnAwMFc0?= =?utf-8?B?dnNKdWhXQUs5VVB2bzVFTU5UV3EyYjF2NWR6UFNyMHZyME5NQTMrUmtsdm5O?= =?utf-8?B?Tm83a1BpcjNJUEE3Q054Q1I3aUFqQ1E2T0VtYXgxQ1M1UHhCVDNneUVjUzVl?= =?utf-8?B?ZFlxY3o5eTJOd3J5SVlrV1hDRndXNzNpeHRZVG03bzVmUFI5dllFOVIzbzJ5?= =?utf-8?B?TlRJL1o3TXZtMVJXZFMzaTNheUFFQjA4ZFo2a25NYXc5RUU5MCtrQytxWE9H?= =?utf-8?B?SUkyK3lSOEVLTEpIa2hFOVl1aVNNdDk3Vk8vUTJGYUpWbjZla3lhcWtBUFVC?= =?utf-8?B?RE1PSUQxQmVQTWx1eE02QkVseVU5WnpZSHVFMUNFalFtOWRpU3lqWGFJOE9U?= =?utf-8?B?VjJwNVp3MEVaVTFtQXJsa0pTRTNHV25aclIwOElubGZRMGVXU0prVnI3Wmda?= =?utf-8?B?SVJhQi9tS1crY25ybUxiTG9vRk9lc04xbEhucG10enZBYXdycXNkcUJNU0d2?= =?utf-8?B?cXR0dUhtMXN4Sk9RK0t3Ymd4U1FYYldZZW9teTJnMDBDc2lYQ2JSSytHRlRF?= =?utf-8?B?dCtyck1aNER3bm03M1VxcFJnc2xMOHBaUXpTcU93dlpPYkdlNFp2S2JPLy9q?= =?utf-8?B?TlppYXQ1L0R5ZVZna0wzNzhsNUFDckYxc1BneDVqdXFaMlI5aTNobWJ3THJk?= =?utf-8?B?azFza3hNOFBXQS9JREZkMklPUHBSTGdBS2UramN1VjZEeHRSK0czRXh2Tnhx?= =?utf-8?B?bDJMK0dyYy9hbUEwVzdZZ0Vzb3lnTnpSK2RXbEU4Y3ZDUWxDWXhFeFpJaFg4?= =?utf-8?B?YjdDbThlWnFtdFpSRjg1Y2tyYTFzaEhPQzlDY3E2TEpMbURMb1gwNXJkb0ZY?= =?utf-8?B?RWZGZjZHTFc4bVhqZWRXb3FRcVJmeTBYdWI0eWNLSmRqVGtnVEtzNENtQWVM?= =?utf-8?B?dWIxUGh6djI2QjRTQTZBR1BUeDRRV3dIMTBDak1XVXBhV3VORWVNZVRuOVdY?= =?utf-8?B?cnppR3FnTDlsNzAwb1h2YjI2MUQxcGJ1SzZWblpmYWdYY3A5SytlUS8vMUxa?= =?utf-8?B?ZDh6Vm9UcGZuNWkwSVlkbUtWZHFZT2NEaVpvRkhraVRPYnVURzVEQk5oVWhV?= =?utf-8?B?RmFrT0JDLzFXcjJjaDdZaUVMeHg2RG9YM3Qwc3cxMG9nWm9TaXY1ekRSaDAy?= =?utf-8?B?OFd6bEdjYS9HZDN4d1hVUStJMW5iZDNIdlNIcVN2ZXNIYlBMb0pkazhiZUVL?= =?utf-8?B?bG9lNFVrbWU1Y2FIdHMwcG4xb2l6bW05YWxnRFNGbE5ZREZndFJmU21tTE1o?= =?utf-8?B?RzdscUNVOEp4ZUxqNXhLSUwzWWNOZEk1RnAvVTgzbHpxc2hubmVvWU9XbGls?= =?utf-8?B?UjE2bjBpNWlBT3hUeXVvMW1tcWgrb2xhSTZqYnRmQmR1REMvNmJLZjdEZDVh?= =?utf-8?B?S21wYUErQkRwUDJ3eEYxQWtDbUFnVTFCSmJ3WHEzM2p4Q0dVd3Z6OWF5ODY4?= =?utf-8?B?eklXSTBhVVNrZVFKRkZEaEJKQ0E3VzJuZ3JBazVBVUtOTG5vdHhUOHVSVXc5?= =?utf-8?B?d0RiRUNxVnJoSmRqU3FxaG1Cdy9vMEs0R3B3RUxuNGJ1RjFGRDBPMS82R1M1?= =?utf-8?B?dmFCdENxM2VOTndTS1NvVUhCZVYxZmVBRWROSG1talVsSS85d3ZpRGE2RFhU?= =?utf-8?B?TlV4UkRnMytoeTZKNzhwdlp5ays2VUZzU2F5b0U2eXU1WFFLNzkxUVp0d1cw?= =?utf-8?B?enJ1VXZTMmxTZ3RwUml0NTBJRVZ0K09PMTFjWDdPM1cxWjIxbnNqNkdMTXJK?= =?utf-8?B?MVovMnpoc0I1SFZCSGRGbTBreXFkN040d1JKcHVhNzhOYk91d1NIQ1RheEF0?= =?utf-8?B?bStmSUZYdXgrcWJ6K1ZlazduSmFaOU9xMVRKb21zajg1bjFNM2xlSXRSRjFi?= =?utf-8?Q?/mDSUz2Yl8sLVmWVGJon44TgV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e391f9d-114b-46ff-343a-08db1677493c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 14:56:19.0221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z2rTBR29TH1C5D/jvmtO8IRwIF4dBHsNg04Q2Wb+VIjJPOTEgCQ36SiHoxMM1qXpe2tPTCrhN7q+Uc7deSbVHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9554 On 24.02.2023 15:48, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > early_printk("WARN is most likely working\n"); > } > > +static void __init init_bss(void) > +{ > + extern char __bss_start; > + extern char __bss_end; Better use [] and then perhaps omit the & operators further down. However, I thought we have a compiler warning option in use which precludes extern declarations which aren't at file scope. Even if I'm misremembering, perhaps better to move them. > + char *bss = &__bss_start; > + > + while ( bss < &__bss_end ) { > + *bss = 0; > + bss++; > + } > +} If you're sure you can defer this until being in C code, why not use memset()? Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:56:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:56:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501102.772696 (Exim 4.92) (envelope-from ) id 1pVZUt-0001sI-8x; Fri, 24 Feb 2023 14:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501102.772696; Fri, 24 Feb 2023 14:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZUt-0001s9-5p; Fri, 24 Feb 2023 14:56:31 +0000 Received: by outflank-mailman (input) for mailman id 501102; Fri, 24 Feb 2023 14:56:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZUr-0001rE-Er for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:56:29 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 687d3aa8-b453-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 15:56:26 +0100 (CET) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 09:56:12 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5607.namprd03.prod.outlook.com (2603:10b6:5:2ce::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Fri, 24 Feb 2023 14:56:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 14:56:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 687d3aa8-b453-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677250586; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=sJ2Jlpcul6YwnIOvkMF56K/vaXxTyKCFXKUyWo5CE3U=; b=a4X+9fKjbFv/qkUZJRJ3L2E3KkD6bl1hBmMUCJII0d7UWRrkzseOKSx/ Ae8K+Y9p1GOUQfpFE6+u+85TfGaf+snUYbf1ZUuGgLL1kOLsubblpGrLV Qqu+mF7w3BQGxPnjL9T0TCOpqS9Nac2D7mFEeZ3rNm10ECXDhJT1uirVx c=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 100846098 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:S4DwDa1xTX/fMn65KfbD5etwkn2cJEfYwER7XKvMYLTBsI5bpzEPy WdNDD3UO66KZDD9eI8iO4nkpEkGvZWGm9QwHAdopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfRkcW3 9EdFAA3LU6up/jvxo29b7dNiZF2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1AZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjANJOSuXpppaGhnW4wlQ6FAIvaGCbqPiLo1/kespbd EAbr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOucMpRDpsy liTmNDBDjhorbHTQnWYnp+LqRuiNC5TKnUNDQcGQhEC+MLLu5wog1TESdMLLUKuptj8GDW1z zXUqiE73u8XlZRSiPn9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:WfFp56o0gxYvWFLIdSBXooYaV5s2LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwJ080hqQFhbX5Wo3SITUO2VHYVr2KiLGP/9SOIVycygcw79 YZT0E6MqyKMbEYt7eF3ODbKbYdKbC8mcjH5Ns2jU0dND2CA5sQkDuRYTzrd3GeKjM2YqbRWK DshPau8FGbCAgqh4mAdzE4t6+pnay4qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFx9f3Ls49m DBsgrhooGuqeuyxBPw33Laq80+oqqs9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbknyPgzDEtwXn/zkLwuwqvneXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o4GgbWAhqmOE5V4Z1cIDhX1WVoUTLJdXsIwk5UtQVLMNBjjz5owLGP RnSOvc+PFVW1WHaG2xhBgl/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgPcSm38RnahNPKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBGB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT9Yd3U8LAd23FFgMy4eFKyWhfzDGzG0vHQ7cn3O/erGM paY/ltcrjexWiHI/c84+SxYegVFZAkarxnhj8KYSP+niv1EPybigX6SoekGFO/K0dsZkrPRl 0+YRPUGOJsqmiWZ16QummlZ5qqQD2xwa5N X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="100846098" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKx3Gy70ZjyLer/Zn6Qm3Kjou4bbaQc9jV3zQLZr5aPuFxdqxeepar6zsPCD4w5isYA+ToXo1M42UfR3v9MQYN35+LOD892L5naJJcJp+j7YhAwQXG5db31N7bDZFEaNOuCRUEmdEF6ZcaEtXVFWEkGg6/uXmXBoBqaTNYnIls+dk1ssqnQw1XIAjLHSmkmHHPuxNyyqTaEaRsisz/U5MRdkn58voAqzLtdbXZbRI0FDQnp1ibgnHQfRi4GRPewc1hqsmUtigD24xBbS9WoNflMKl0iUTPUqA/aUH0OuLRGwlRaZCfqG7cDHm/SGepunYZbVNXlQOxhCFBuveGvCYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y/oaELvFBpy6DwLcgD6jhADRmlgUKUV1FmnIE6QgsK8=; b=iDiqWB/dPQtzklQ0vL58Ena6pytA1Ob88NcOmDcQGrA8St7Bw7V2LBWFozDS1NNC7LOCQ4phV2YrZ2wEtU4/52nITfRKJIbFpV6JR5CNBG6NymBKGwMMpAcqyUfdGOh0nZKtG+yhanvoNQzOuLzU/FTNtUi3uI1jx0yD1/lFA9GWpauy6ZfO3WhZv5aiPfVoxznPqLmcr/ZAtjyaBfQ4jVLkKU8laJSD00pGgQlVu01bpTifMHdn2JEBcB0GutmXMfMVCrFGqCz/fcec0BlfipM3usQYHjaVCtVcq96qIvrbg1as9vL2aNMurUYTYbcXPwk0qIrfpjUVHb0ehze+HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/oaELvFBpy6DwLcgD6jhADRmlgUKUV1FmnIE6QgsK8=; b=KtK7rSKJW4ZomdE2LeRhF5iB7SRyuTPaY9yQpHBSMoNiHvj2329sV2v6SFHjeuwyCL90vb0umizVkY0LuQi3UaQbHNgl1LdKYLOUQS1Tjju3R6a/c9FvUAVdnTL09tRhpfpmK+6NvGQAtgZ1IRM1QEGZBczoeaIdC374PVxZdEg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> Date: Fri, 24 Feb 2023 14:56:01 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak Content-Language: en-GB To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Wei Liu , Anthony PERARD , Juergen Gross References: From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DS7PR03MB5607:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f7da24f-a34f-44c1-7195-08db1677427f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rihDQDLFHAezddv637i8hwBj3H/RTpYRlomKgK1oRaNI3T29UcahcubOGjnWuHW87QljyTCwcorbQy29Ja9M0v3Xgc807+We9/jmtwMYdUrWLLC1Mqa5X/fNal0PkJ7KTBPszyDm6CyBY78J/qZnqpThZNy9wQTP7epAsJV9BMUPLYdKgT3KERqY5vb5inWHkQldMHfXzExzOtecSgYdQT6VNo5rctKYrT9f+EOqNRun7XvLYX7XA3nolAXY53Y6gPG0ivnTQHXNG4lCROCWHw9jVyFKZdmt+DsSKrHMj3yLqJKIrfLNFqtF6RLe7639eB6HPEzH7I3TBBcFgcKIRFkN/steFeFKzDSfHYIWM2bDwocnNeob2pMYKkUkI7vmqYq20/HGUYW5a2vR/D/A5+HY0G/TqEQ+yiGPjkwh9EFaYWiQTCE+V2/5VkaKmgfPTkSL06vfFPEVxMign//+GEVN8fma9OrVasl97jqgZRFK0NgcXmeBDapHZP25NDA2x3Fvdug2Yx5i/txmRq7IqofKJZYc87t3Fs+mxQ9L+ILxuXXB0wh/BDza+2gQjsE/S6GSjxpjKai9cvi76useXmVWsEMHlV4cMUgwlyA6CrYuAaiITaWwPjxhpSMlgcHL1zgkwoV6JySZpGHVDlQytcm8mTeSvNLzoNPTXqp0856sJoAIXutYB2RXHvlI1EQ8bx2SY5o0dEoEp7OhlkvdSgjO+VdGlA/Cboj5VV/ve8c9VcQ4qXvlKDJvoN5t/5plUBQTRK5bFkMbbh3u9tIALA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199018)(26005)(6512007)(186003)(66556008)(66574015)(82960400001)(38100700002)(36756003)(31686004)(53546011)(86362001)(66476007)(66946007)(2616005)(8676002)(4326008)(31696002)(6666004)(5660300002)(478600001)(6486002)(54906003)(41300700001)(2906002)(316002)(6506007)(8936002)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVdNNnY5dUFQckJzblg0NXBkMEdkSDh4M09rSGIvSlNVM0ZNREpwQVhtSEdn?= =?utf-8?B?NkNEU0JlU1k0a3RrV2RVamtTWGEyZHB6Z294ek1tREdVT3JPelcrS1djNVY4?= =?utf-8?B?WUpHeCtqck9qTVlpWVgvdXN0aGRVdFhLekF2V3UvblE1VkdvWEp0SDJmWWtr?= =?utf-8?B?TWlGVVlOYytKdGZkOGZ6RVNWV2RrbGc0eFArcXJWcmhwWkJEUjkrcGZZRXQv?= =?utf-8?B?cE52bXhqMjBybHlETld4VER0SDM5OENxOVJUKzIxcnNMdjZ3OTNjdnhCUC9L?= =?utf-8?B?U3Vva2xPZS9yUjBINEZkZkgveG83NHRobm1LNGpjUTZRWkRySHhidWtJcExR?= =?utf-8?B?MXZYSmdCbzN5K3ZyckVaNk4ybmk0bVNTbVRCUmlGWEZQaGZCbjBseVU0N21h?= =?utf-8?B?aUM0VWRSaWI5TUEzQUlocjFHS29uNklyU2Z3M2dUMHBvN2pDWDFDd1VSZ1VS?= =?utf-8?B?NFNPb2tWQmd2L1pKc0RUZGdJQzBoWStsWGNUZGVuWFBQWS9tbGtYTEwzcUJQ?= =?utf-8?B?VmNnZkJjSnhVeEx4MUZtV0I5SDhaU0pvUnYxbzVvRlo2TjlKL1FjT3lERnVq?= =?utf-8?B?MHRtUi9jVmkza3N0MzdickNGL2ppUmRmZFhnbUNKT01HUFpwVHVwWHRQUXpu?= =?utf-8?B?NHF2NEwveXpmTDcyVUVlQW45OFI4bVFVcGRtcmJQNDVXeG9HSFlkSXptRFoy?= =?utf-8?B?SkpsNzhzeW4yVllzeWVyU0l6ZWIydG1TRWJQcHVkZHU0MlpGd2owdHRoZGJt?= =?utf-8?B?eUtkKzVUL1M0NVB3dnprWHAvN0tZZHhCZU14VUZEZGxZNDhFK1JHZnduVlRt?= =?utf-8?B?RVorbi9BVXhPOWZVTEtQczFUelVNNE9zdytjek5XT3JLbGUzZGZUSllRVzdu?= =?utf-8?B?akhPVlZJQTBpN2Jsd1paMk9RWDR2M0NvMGV1ZTUyeDBqZ1ZzaEI2Um9laVBR?= =?utf-8?B?Tzg3N3JQOCs0a0dMLzdSU1dBem55VHROVnZqSkY4K25QYWkvQlJmc1hBdktP?= =?utf-8?B?cGdqU2VZb3pDL0xHZjRkZFNKV1puaC9FQTZZZXAzS2l6ZENpMmZhS0d3b0xD?= =?utf-8?B?VlJ5d1dNTGZxK0l6RGFMdk43Q3JVcWZaNk5CQ1ZYK1JPZGdQRDN4NTByRVN6?= =?utf-8?B?TGJNQ2xQTzFrRGdpZFBweVNDZG9QSlYvZEUrUUdPZng4cjJNRWtucThlSXlW?= =?utf-8?B?eGdSVjhQemNBVU04SnU0dTFXK25aYzQ2L05lTElEa29XZUlRamVhN1lFOFMr?= =?utf-8?B?NHNQQ3pvcm5KV0FZMHg3K3l0RkE1RklBclI0SE0yVThqL3RuOFZsU2R5UzYr?= =?utf-8?B?b2VMajY3Z1JBS3lwV25PUXM4dGpVWWF6QXJQd0pBdTR3SUN2Y0QwVGpkSGlv?= =?utf-8?B?VU02endJSWpES0QwVnNlN1NCTjczL09PWXRLL0pSUGROaWsrVmhnZTZXZkE1?= =?utf-8?B?K0lzR0srOFFZNXh6OUNxSXNjR2VpNi8rZFcvelhXNW53cCtVUzRqNlAxVUpy?= =?utf-8?B?MVMvckc1SWFvTHcxME9VY3E5WWxPa0hodi80VDVBY1NQaG5vd0U1QWM2cGdR?= =?utf-8?B?cmlOT1MwV0gzOHFuS3Q3Q2didkV1eWsrNVV4a2pENVdRaTQyTlllZkY1aFdC?= =?utf-8?B?UUh0djdWY2NpSWJ1eUNXai9DbC9xR0JIaCswK2F3QnFQdWgrV1dzTFdJWmdt?= =?utf-8?B?ZkFBL0J1cUJDSUYwcTRxSWhRVDVuQzVmbDBHZmpGblk1RzFNVVJzSkhOUGQ5?= =?utf-8?B?NGRPN1V6SFEwamQvZWROVXRqWkVjYnFlYlExRzNSYnIzMGVwNTVlV201bWR4?= =?utf-8?B?WjFpUFQydmpVeEpIOXJ1NW1DLzQzVjZHNU1oMW95aWJKazNKVUpxQVBwaXQ0?= =?utf-8?B?MEFZNHBldHRHMktOam8zWXNzRkRFcFVKSVE4RloyRVp3bHhQeUNyV3FMM2Qx?= =?utf-8?B?b0poQUZXM2IyK0grUWMzNVNMczZnYTRxcWZ6M1hvQTNSb2RoVHU5YnR2bDIw?= =?utf-8?B?WmNEZGdqWWt1ZmZ3NGNFYmI3bjJJMk1HUWZHcHZBZytsbDFHRnVuRjZaMVJt?= =?utf-8?B?TjVWMElrZjJtZFErNUVPNXFNYWIzS2U2bk9qR1oxQ29LalZ0SWtLQnpaUDg3?= =?utf-8?B?UnFOdE9DVE9VNUkzYy9pTFlyY0J3Z1Jndk5KZk5helpuRTN6QlA2aW9aNFB1?= =?utf-8?B?M3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2A3VbU0Eyh8SnXJNCv/RkG0GzGoWkoVCiEHXX6J7Go0d90vNqg4LEOI3ybZTbd8a7WTfFe0KzdTEe9nuoO52VUSUCxq1LbPwydf72sOGJsKIpnd6R9yE7GxTXgVeWDPEzr5u4mjS5c3PENKCm7oTTeiccdJ5EMfHBdN+Almlc/0wYngbiv2MhRVXJ3RrZjqAWWZentG//Ex7mZXsUQ5TWLdBZ7Yxi8rmg6Xm601+csltOJ2gZuNvhlsIbXD+ePvSRS6+pyKWK3hez80vGM0IQo1Tit29dgxTAGepsNQpTJcuZF9q8bBQfAx1sCeWkzH7LqzW4cBeO9WGN/EWq/EEO0YlJskvVLi0huzJnWZrRwuy4A7I8wW5CjJ7JRq6K38eOtsNcZwl93Gf2ucjsNsSFkQvOitGSS/ELchzjsnq031nzPPVona92NvUa+UtiuLDzy4wRlijLhb/M3b0Nyw6LuQ+r3KG2VyXn/VfTipcx8f+ciQ0cdcu+09xv0sbnRdxpZPc166SF6rghbyMt4qZ7wky2CGwcatGbHdPB+gA/w3ipT6GzW4UUO0Xh8+dnBXA6S4kuevEo+/ilIi79DvlsSbdwDzcs4se+uA0may3E/0AtuYO3GDjkbJS5KFKsJvqsMclKIrwmYVH4hhfbKPhnkLFkxUYziu6J7lrQngqnJplAI2a/+JIUQ8rDKvaQmAmwArQIgU0lx8qZksqVCaMcDJ+GeXvTGwGdTOGq8Wu5HszHgdH4x6nD+0UnGOE2VV+l0IB97vgZuxaiWlyJ006VPEm+/vfAQTPY2WRj7g/x8aPmXhu9UaDUX9tjkyAHEN7yf/i+bCG+6BBuc0nNAYXZSXXc/CFUdLVkSy2FjQI/b4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f7da24f-a34f-44c1-7195-08db1677427f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 14:56:08.0155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /V1ccFGEoV/9OTenH8/ahlNDk81Q1eaQj3hXqLAsi2VlSbkSjIjv3fNNfIzEmplRN4wN+d233MiEhLEFZxJzxxkQM/N5+eaJT2SrYwTJ91I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5607 On 24/02/2023 1:36 pm, Edwin Török wrote: > From: Edwin Török > > Prior to bd7a29c3d0 'out' would've always been executed and memory > freed, but that commit changed it such that it returns early and leaks. > > Found using gcc 12.2.1 `-fanalyzer`: > ``` > xg_core_x86.c: In function ‘xc_core_arch_map_p2m_tree_rw’: > xg_core_x86.c:300:5: error: leak of ‘p2m_frame_list_list’ [CWE-401] [-Werror=analyzer-malloc-leak] > 300 | return p2m_frame_list; > | ^~~~~~ > ‘xc_core_arch_map_p2m_writable’: events 1-2 > | > | 378 | xc_core_arch_map_p2m_writable(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, > | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | | > | | (1) entry to ‘xc_core_arch_map_p2m_writable’ > |...... > | 381 | return xc_core_arch_map_p2m_rw(xch, dinfo, info, live_shinfo, live_p2m, 1); > | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | | > | | (2) calling ‘xc_core_arch_map_p2m_rw’ from ‘xc_core_arch_map_p2m_writable’ > | > +--> ‘xc_core_arch_map_p2m_rw’: events 3-10 > | > | 319 | xc_core_arch_map_p2m_rw(xc_interface *xch, struct domain_info_context *dinfo, xc_dominfo_t *info, > | | ^~~~~~~~~~~~~~~~~~~~~~~ > | | | > | | (3) entry to ‘xc_core_arch_map_p2m_rw’ > |...... > | 328 | if ( xc_domain_nr_gpfns(xch, info->domid, &dinfo->p2m_size) < 0 ) > | | ~ > | | | > | | (4) following ‘false’ branch... > |...... > | 334 | if ( dinfo->p2m_size < info->nr_pages ) > | | ~~ ~ > | | | | > | | | (6) following ‘false’ branch... > | | (5) ...to here > |...... > | 340 | p2m_cr3 = GET_FIELD(live_shinfo, arch.p2m_cr3, dinfo->guest_width); > | | ~~~~~~~ > | | | > | | (7) ...to here > | 341 | > | 342 | p2m_frame_list = p2m_cr3 ? xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) > | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | 343 | : xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); > | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | | | > | | | (9) ...to here > | | | (10) calling ‘xc_core_arch_map_p2m_tree_rw’ from ‘xc_core_arch_map_p2m_rw’ > | | (8) following ‘false’ branch... > | > +--> ‘xc_core_arch_map_p2m_tree_rw’: events 11-24 > | > | 228 | xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinfo, > | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | | > | | (11) entry to ‘xc_core_arch_map_p2m_tree_rw’ > |...... > | 245 | if ( !live_p2m_frame_list_list ) > | | ~ > | | | > | | (12) following ‘false’ branch (when ‘live_p2m_frame_list_list’ is non-NULL)... > |...... > | 252 | if ( !(p2m_frame_list_list = malloc(PAGE_SIZE)) ) > | | ~~ ~ ~~~~~~~~~~~~~~~~~ > | | | | | > | | | | (14) allocated here > | | | (15) assuming ‘p2m_frame_list_list’ is non-NULL > | | | (16) following ‘false’ branch (when ‘p2m_frame_list_list’ is non-NULL)... > | | (13) ...to here > |...... > | 257 | memcpy(p2m_frame_list_list, live_p2m_frame_list_list, PAGE_SIZE); > | | ~~~~~~ > | | | > | | (17) ...to here > |...... > | 266 | else if ( dinfo->guest_width < sizeof(unsigned long) ) > | | ~ > | | | > | | (18) following ‘false’ branch... > |...... > | 270 | live_p2m_frame_list = > | | ~~~~~~~~~~~~~~~~~~~ > | | | > | | (19) ...to here > |...... > | 275 | if ( !live_p2m_frame_list ) > | | ~ > | | | > | | (20) following ‘false’ branch (when ‘live_p2m_frame_list’ is non-NULL)... > |...... > | 282 | if ( !(p2m_frame_list = malloc(P2M_TOOLS_FL_SIZE)) ) > | | ~~ ~ > | | | | > | | | (22) following ‘false’ branch (when ‘p2m_frame_list’ is non-NULL)... > | | (21) ...to here > |...... > | 287 | memset(p2m_frame_list, 0, P2M_TOOLS_FL_SIZE); > | | ~~~~~~ > | | | > | | (23) ...to here > |...... > | 300 | return p2m_frame_list; > | | ~~~~~~ > | | | > | | (24) ‘p2m_frame_list_list’ leaks here; was allocated at (14) > | > ``` > Fixes: bd7a29c3d0 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") > > Signed-off-by: Edwin Török > --- > tools/libs/guest/xg_core_x86.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c > index 61106b98b8..69929879d7 100644 > --- a/tools/libs/guest/xg_core_x86.c > +++ b/tools/libs/guest/xg_core_x86.c > @@ -297,6 +297,8 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf > > dinfo->p2m_frames = P2M_FL_ENTRIES; > > + free(p2m_frame_list_list); > + > return p2m_frame_list; > > out: I agree there are problems here, but I think they're larger still.  The live_p2m_frame_list_list and live_p2m_frame_list foreign mappings are leaked too on the success path. I think this is the necessary fix: ~Andrew ----8<---- diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 61106b98b877..c5e4542ccccc 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -229,11 +229,11 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf                               uint32_t dom, shared_info_any_t *live_shinfo)  {      /* Double and single indirect references to the live P2M table */ -    xen_pfn_t *live_p2m_frame_list_list; +    xen_pfn_t *live_p2m_frame_list_list = NULL;      xen_pfn_t *live_p2m_frame_list = NULL;      /* Copies of the above. */      xen_pfn_t *p2m_frame_list_list = NULL; -    xen_pfn_t *p2m_frame_list; +    xen_pfn_t *p2m_frame_list = NULL;        int err;      int i; @@ -297,8 +297,6 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf        dinfo->p2m_frames = P2M_FL_ENTRIES;   -    return p2m_frame_list; -   out:      err = errno;   @@ -312,7 +310,7 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf        errno = err;   -    return NULL; +    return p2m_frame_list;  }    static int From xen-devel-bounces@lists.xenproject.org Fri Feb 24 14:57:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 14:57:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501112.772705 (Exim 4.92) (envelope-from ) id 1pVZW1-0002j9-Mz; Fri, 24 Feb 2023 14:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501112.772705; Fri, 24 Feb 2023 14:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZW1-0002j2-KK; Fri, 24 Feb 2023 14:57:41 +0000 Received: by outflank-mailman (input) for mailman id 501112; Fri, 24 Feb 2023 14:57:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZW0-0001rE-Sf for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 14:57:40 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94b9f42d-b453-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 15:57:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7517.eurprd04.prod.outlook.com (2603:10a6:102:e0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Fri, 24 Feb 2023 14:57:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 14:57:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94b9f42d-b453-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oqjs/GDkU19ic+2AmhSJFVYeeNYazmuopk0jZmg2RZY/cwSGloP7S5Sx97bKplq3VWejDp3jwQHaTf5+TIqI0L3+g0j8e1EfTYwx0XpsNlIdZ2viBpNQm6Y0zmIji80FJWJpBj4foiU/8+Q9AYOBy2wj4M7tSSRjo/BwKBcy+VlHPQUyjrtBqE0xJLmjBdcSNwIz/J6AoCSn34lWoD2o31gFTBYEgB+WH7yAS2iv30ZOKSj+vm2Da3+hfLc1XVD/YMSdeC085+YEjNDJp8noGKe9tIOMmqIq85nI9I8MjrVozKVNkOHS4s6W/WfkisrwRqgjvtv2SVjN5C99VZzLuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4745qez8NjFm9C7vOU8UYAB/8/YMfohpH+6j+jrjx/k=; b=Krb1QJaRh4KgttMTKfyrPs9l8k1nzElG3oFb4TBd9iHTuAT5zZJoCrw7hFh5l1e+MwQvb56DGMDNuf9gHWc6VVwJF5ujR53a6I3bYyjGsGZzpp0pZo9fZdeytpCWdRh5/kXUh1gPyJGYGu2bKERrN0ID8xZDiMCiMY+5fO7fxznlt0DSKs2U+M15Y+KRprm+Jm+3srDbAOM8Fx1KN7DSR1ozrQfj/sA6dI8YAEPn26FrZzqIpvRjVDcysCqOwL1EjTKPakn9tVYMD7K6XtiuAojVxJ4Svw/s9er/MH5lu+77y8eiwmVIusgY5gQxOuHiseU5jFb/fKHDbmF/b6cwHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4745qez8NjFm9C7vOU8UYAB/8/YMfohpH+6j+jrjx/k=; b=31QGr9nVqWVagfj5PI70BQ5lIThKRvfCYfs82nRxzdhNiIXs8+cYunOBBSV8drwaXMnxUUicw3oNYlPeRS61e/QA49rE4rBsJh0YTk1DfuQg6fO/h1THBDvvbtto5nnH6w11tyml7SEMxCLG511fzSx9P1O7UvSMM22G1qKLH9OS0v0oSNkQqA35RU8YkwzKfQNEbSLzaoCV5Ip2cI8/86ku6LpX7+o1GfMcyURwolfKYkK/CbmJzeIIO4M4mKDOrDF3pIp/25eyOCm7TvyG8zKubiQ5ht2BPjpk0wQmAloa3ZJ0/u2s8ezd7NYfumpXOnVY4jqPaMNwOHrM5OnfIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <426fbcf7-eb25-b736-c125-0ee495e63fbe@suse.com> Date: Fri, 24 Feb 2023 15:57:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: init bss section Content-Language: en-US From: Jan Beulich To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7517:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f4668b0-6441-4286-f0a1-08db1677673f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9G/796RxmT3nMY1W5teGVNs0DEzsj/vnPtqGsDjaSv4SJgKlXj3li9ZhKsHjIFvtpBCaNx9QHvs0n3SfL/Q+TCtyGBO48+k0T3qB3ZSC9pyfJy4M6mwR6o8Px4x3KXJVj2fU6IcgeqqZGmeKiSyS7QXJazViK6dTZWCaKfgS1u9LGLJg7CppIzb919ySESQpkyAMnt+IEGevJJXSfoOcupsdWf41a5oaXENqu6MzBuTqi46u7vIpS8XIbSzPPVJGNpputkjkPYoPCd6R7CDUGMg+ADE+TMcal8qD1t9VfGtHmvqRIS7rT94f+NQykvReDSNFwsUFPw9mzuOX8KlQrFmm/Wh5Ci6XiupVCotVXfQBoRWP6c+tRKM96zawWUStguT1fQ6564y+lHMNhrN84+yUZwyUr/zWXxQOYL3AonDo9JYvbeyY63DRTBUX170bUVRIF+ZTgj3Vf7GDOwOZo8VBBUwdVZYztpqIedRQU/6dF60/R8bloTOqQ2VxWW82cvSElhEc+Ms8HHqvSboEtlKeABDX74ppkEBYp+ZYNQabMca+MJk1JsyLNVe9DCzRW/n+fsBdhcdQ4HS5nKGNiFVfkkm2FWjBRVuI+3siIrg2SuMQtOMsowfn9/lmKZHVNSG/UYIq2NjU52UGXXL03pmR+fkbhRM7AOusYyDtL5wiBGFNbxYAiyn14TYM+g2O5SUz/PtB+7YfSq7fIAJ4xe86OHpbyyWaIu7W9FihLuY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199018)(31686004)(38100700002)(8936002)(4744005)(5660300002)(2906002)(54906003)(6512007)(26005)(41300700001)(6916009)(478600001)(2616005)(66556008)(36756003)(66476007)(66946007)(8676002)(4326008)(316002)(186003)(31696002)(6506007)(86362001)(53546011)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elpDTkVGS3QvLy9OdjBPbCszQVcwdTM3RGU1VEs4blkweXdNM1lENjlVRjh3?= =?utf-8?B?MjBEYnIwR0dwd0Mrc2laTEx6QWYxTGhyTjUyT24vb2duVnJ5clNtTXA5R1p1?= =?utf-8?B?b1Y4WUV6KzNwN003NFkrRTJSa1VhVW9tTVVtdFl1YS9kbkl3djg1UjZmRDA2?= =?utf-8?B?OWgzNzM4bHVUY3hpQXdCYTBPV0YzN0NtMDhpVnR1eE42bXJ1UndpQmgrYWxT?= =?utf-8?B?LzVWdExldDlSOGdDMmMvU2JJbUtUMlR1cnduM2EwNzlXRTBnUkUwOGp0bGtR?= =?utf-8?B?QXk5dzJuR0lpOTVTN3JWOVZFVmxob3lTa1NQM3dERE4xZWdQSWphblRpRmwy?= =?utf-8?B?Tmt2bXo3d0ludmo2a0llcHlhUDlSSnV5a21oZWJqZXl4R0NvYlVYcWNEL1Q1?= =?utf-8?B?YVprSnFvdy9UaDVmSmE0NnNjZ3FFSFQzNURDM1FUL0lRNEIwTHM2TUpVZ0pK?= =?utf-8?B?cGcvRlpjWHFCclhWYlVNTEtybC9lcUgxMFBYcDlkTEdPTGs3TmpNVm55Z25S?= =?utf-8?B?djNrRWo0RFlQVzNWNWgzNnJjeDN6Y1p6Ny9WVDZTNjFNdmpncFdNd2ozdTNX?= =?utf-8?B?TlhRaXV0TDBCS1IyMFNBT0tSNUl6d1AwbnFPdkNKd3A1OFdXYkwxa3praklE?= =?utf-8?B?cjF6bnZHZlJqTUdheDdpOWF2UjBFaCtHMkpIOEE4NG1vK0VCUGU0Z1pVRWIz?= =?utf-8?B?TkJFbjBla1lOMDQwODdmQzFNd05VWlU2clpGUUx1ZW9HQkpvODFjT21rV3lx?= =?utf-8?B?Z1MweWhaMzVESEpJMWptT3FQMGxENzZNMjFWa01yQkhlSmhHTzcwUHkwZmxX?= =?utf-8?B?b2hZbGxyMlJRaDBVaUh2Um1hblNlUFV3TTB6OFdmZnpNRVI4MlI2MVlwOFlx?= =?utf-8?B?RlFPK2RENTdQeUVoRlpMWGNiZ29wM25zYVo1K2EvQ21MazhDTVNlNUovc0hv?= =?utf-8?B?eHk0RytRdXNuWFg4bC82aUdWbzlVMWk1YjhNRkVJR05VRzRvQS80LzJ6YTV2?= =?utf-8?B?Q3c3TGtQT3FSYVROL1B1Tkl4VXlOMDR5aTBoTFVJU0JsN1VUdVVNQTdscVpt?= =?utf-8?B?MGljQS9tRUliMHp0VVhTOWp3elNUdk1MNDg2bW5rUDNJUUlsdzZNWk5BVElN?= =?utf-8?B?N01OQnQ2QXMxNFdhWlVYZnlzQnlEVzY0eVFIRFJ3eE84bk05b0JnTjdUNTRE?= =?utf-8?B?eXBwRkpGYi9xeHE0UGJkclgvTlpNdDIrOXVyL1ArQ213T0NZeUkzYVhWeFRO?= =?utf-8?B?Vm5rWCs0RkNScE5OWG0rd0tNZ2J5VFBuUFZrbGZPcTdGa2hPV01PbjY4VGIx?= =?utf-8?B?S2wxNzhyNnM2RWdXdXE1L2VzQzg1YjFCMDRiMDZodUVSQkZFRmtKOFJYVmx4?= =?utf-8?B?ZmhZdWViOVl3NWczdWdpaHZBSDIzdUV1aUpndmI3a2xUcEJYRWppN0JuTXBi?= =?utf-8?B?VEJqSURlSUZLSWtKTHpKcDNCUURoT1ZITE82M0lON0c1R1pzNnA0YXZUdG8x?= =?utf-8?B?U2t6c2FBRjVERndKM1JoZ2MwR3dxVHgxb1RDRTlEQkh5akFoVWlRNU5TK0hy?= =?utf-8?B?bUlQV1FFU2hjYk52ZERCYmQ2M21VU1VIOTAwcDZ5RmlldzlGWnRDNmk3UFRL?= =?utf-8?B?SnlJL1VoSDZGL00rTUNBQ0dJWlN5WEFyY2VUaGRERUlBaTY2U3FyMkw5N2pF?= =?utf-8?B?QmR1UjV3ODJWL3FBMVM5ZWV4Y1JEOS9NNis1NWtXT3Q4Z25oTU5yYldVNFFR?= =?utf-8?B?SkFrQi9TOU1jUWNjeTgxZlY1YnJCc3JVOXlPM3pUSVd1a05RUzlOcE15V2ky?= =?utf-8?B?NFJhZFFPV3FyWEZUYVRPcWpncUVGUm5RZHVySFpmRDA5TDJwT2ZQeE1KVlNL?= =?utf-8?B?aU5hUzdRYUdmUlM5L2R3NlZqcXZiaWJJamtzam1EV2pvaDhETXhyc0xwbWhP?= =?utf-8?B?VHlFcnFsSVZPWElsY1MrbHc0Q1pGdkhUeXdGN3JrdVZrRDRYSVNQbzN1THZU?= =?utf-8?B?RzBEYUxEVS8zNGVjdGhhbVdjQzN6MG9TYmlCcGY1R2QyOWtzdStuV3NMRjhi?= =?utf-8?B?T0hmZWN6RmE4WVdnSVEvUk1xcDN2OHpkZTFRRWRCUWcyRkdsU3RUTXRNZWFH?= =?utf-8?Q?tsDDs9YAOzK7umznd23OvYdW6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4668b0-6441-4286-f0a1-08db1677673f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 14:57:09.3938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UvOx+GO8kKh5TZLWCxpOcGUlutobm0vZO9eC43DRK0LKOswoabtvZIFtyMuIIHhpY4isVqR1pV6+iToVmm5Cmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7517 On 24.02.2023 15:56, Jan Beulich wrote: > On 24.02.2023 15:48, Oleksii Kurochko wrote: >> + char *bss = &__bss_start; >> + >> + while ( bss < &__bss_end ) { >> + *bss = 0; >> + bss++; >> + } >> +} > > If you're sure you can defer this until being in C code, why not use > memset()? Oh, otherwise: Nit (style) - brace placement. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:01:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501120.772716 (Exim 4.92) (envelope-from ) id 1pVZZE-0004dN-51; Fri, 24 Feb 2023 15:01:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501120.772716; Fri, 24 Feb 2023 15:01:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZZE-0004dG-1j; Fri, 24 Feb 2023 15:01:00 +0000 Received: by outflank-mailman (input) for mailman id 501120; Fri, 24 Feb 2023 15:00:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZZC-0004d9-Fn for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:00:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZZC-0000RC-BN; Fri, 24 Feb 2023 15:00:58 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.156.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVZZC-0001fl-5e; Fri, 24 Feb 2023 15:00:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To: MIME-Version:Date:Message-ID; bh=2mzti8Sv1CTJp4qEfEXVPD+6RBsoor0gOmFXqiBYw/o= ; b=I0tAOrWVIMc64hBjH3eITvf9vJvHp2ilMYMVA9UpVlrhz6DfGB8KqXTaiJeeAb9Uq0KU1ZgMS /i0kYu1YrDdMMmYQhgGSpCBHmZQmKKL+KxxZMKmKUV9IKRXUBGgfVDljSBARbodmaiQAI9Qb/u5i9 AlWSOogu9nvtILoOpzIQ0=; Message-ID: Date: Fri, 24 Feb 2023 15:00:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" From: Julien Grall Subject: xenstored: Interaction bettwen SET_PERMS and transaction Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, For some internal purpose, I need to write a script that would do the following: 1) Start a transaction 2) Call GET_PERMS 3) Call SET_PERMS with the permission just retrieved 4) Commit the transaction (Don't ask why :)) This was executed from dom0 on every nodes. In some cases, we noticed that 4) would return -ENOSPC. When digging through the code, it looks like this is because transaction_fix_domains() (now called acc_fix_domains()) will check that the quota is correct. The domain is question were over its limit, but given this is called by dom0, I would have expected that it should not never return -ENOSPC (note that a SET_PERMS outside of a transaction would work, but this can't be used our case). Furthermore, the transaction is not changing any accounting. So I find a bit strange that we would prevent it even if this was run from an unprivileged domain. Do you know if this issues would be fixed by your current rework? If not, then I think we at least want to skip the quota check if the domain is privileged. For non-privileged domain, I am not entirely sure what to do. I was originally thinking to check if cd->nbentry is 0 and then skip the quota check. But this would allow a domain to remove a node and then replace by a new one (I think we still want to forbid that). What do you think? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:01:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501121.772726 (Exim 4.92) (envelope-from ) id 1pVZZS-0004wF-Ch; Fri, 24 Feb 2023 15:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501121.772726; Fri, 24 Feb 2023 15:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZZS-0004w8-8g; Fri, 24 Feb 2023 15:01:14 +0000 Received: by outflank-mailman (input) for mailman id 501121; Fri, 24 Feb 2023 15:01:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZZQ-0004vZ-LW for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:01:12 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10aae71f-b454-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:01:08 +0100 (CET) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 10:01:03 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5913.namprd03.prod.outlook.com (2603:10b6:806:11d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 15:01:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 15:01:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10aae71f-b454-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677250868; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=yk/I0+ff3zQkqleLmM7GlYQED0Okn7cLE63Dp6HPuAE=; b=QlGQkV+ECZTQWE5CDoi7cMS1xxunkxsEX7TCX2Z+2zCBf7K9Wfk+S/qx enLqlDYF0DRzLUNVlvQYxAAV2mr175DCNzs7t97l/zC0UGiyHhUQFFn3s RrWeZFr10Ka8wFfIo7hkSwlfl5hFe6r3/Rw+OsMoHygcjKysIUD0U5Wow o=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 97250547 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RwPNwaOP3RxUnw3vrR2clsFynXyQoLVcMsEvi/4bfWQNrUoggmMCx mYXWz3Xb66OYWLweop3OdmwpBtS6JOEz4dkHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vYrEEpE6 eA3ER8EMDean7iowZHjY+Y506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCOpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewnmmAN9OS9VU8NZHsASTmXwcJiFNC3CKs6KLpUCaV+N2f hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpZdA5tclwWTsw0 VyhlNfuGDApu7qQIVqC8p+EoDX0PjIaRUcAajUDVhAt+MT4rcc4iRenczp4OKu8j9mwHC6qx TmP9XA6n+9K1ZNN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:BgCm4a+1bNx4g7dJxfZuk+HFdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXpVoMkmskaKdhrNhQItKPTOWwldASbsP0WKM+UyCJ8STzJ8k6U 4kSdkENDSSNykFsS+Z2mmF+r8bqbHokZxAx92utkuFJTsaFJ2IhD0JbzpzfHcGIzWuSaBJdq Z1saF81kadkDksH4yG7j5vZZmwm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjsOTj9Vxr8m0G 7d1yj0/L+qvf2XwgLVkza71eUbpPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+Bwlve21714usd /U5zMtJd565X/9dny85THtxw7j+jAz7GKK8y7UvVLT5ejCAB4qActIgoxUNjPf9kobpdl5lI ZGxXiQuZZ7BQ7J2H2V3amDazha0m6P5VYym+8aiHJSFaMYdb9qtIQauGdYCo0JEi7W4J0uVM NuEMbfzvBLdk7yVQGTgkBfhPiXGlgjFBaPRUYP/uSTzjhthXh8i3AVwcQO901wg64Vet1h3a DpI65onLZBQos9dqRmHtoMRsOxFyjkXQ/MGHj6GyWmKIg3f1b277Ln6rQ84++nPLYSyoEppZ jHWFRE8UYvZkPVD9GU1pEjyGGNfIyEZ0Wu9ihi3ek9hlWlL4CbdRFrCWpe3fdIms9vQfEyAJ 2ISdVr6/yKFxqbJW8G5Xy5Z3BoEwhsbCQkgKdLZ7uwmLO6FmTLjJ2sTB+BHsulLR8UHkXCP1 AkYB/fYO1902HDYA6MvPGWYQKjRnDC X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97250547" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bv/aHSRXCY3M1NRE1GVW5bUzLNV6H8TAtVN2y+NKhEQ+PAbHnMANaCvgySo5yEW7SUOuMRu0VrX/yQupSi0zTk7vlFPsDehobkgElq9FwvdJjOPrBBpFFjG2Kjg6y67eXdHZhhEVyXFwf8JV1YjaOkj0GDRMhLK5clmpdBLY2VJH1lp/nyEjKUAiXBAjIHu/yMcElHjGDY7Ad1kVpdWxXM6F/zj5npbldLgqaemnrxfnYiNXIgpNAgJrK8pUp9LAzycE7WhuY47SQ/aXfm1TUWHlPHyzzWi+jxIrJE0wZKX78TOWQTKnH0L69ERKcfQh2PePqxnER+gcnz03whg5Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMszfW/goHMfjxmUPzM9M3YXrjXP3E0cFLVZ4cZIyMQ=; b=n1di9EUwGsX9/JIPt9fZOEel3fmTU89b7BGKTS4Dg+YSMIHq2KAiOrQfClkb56vNkDeiiJYhAf0W2mFEV4bD5HqhAO6eEQAyOrHlpDAnwjrP50BJksTIHqbG8Gl/G23eiLUWCIw8p/00Bps8lJ4Ve7jFxc68VyrL8peBmoQJ8kGElFxx/jkE2sa/B0FH3xYI/wyyXI+3qgV+CsDe+AZ9AftleNZDIkvLu0HpXacuFs3Q+jmc9ST8Drnw18Q7FUgsqC/xiZFPT9cUFDXO3ljGgam7G/omgLrO+ANaeJqzaZpURL09raTtPi7TdXq6HdY/10eJ+onqALaLkcfr+Xl0zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMszfW/goHMfjxmUPzM9M3YXrjXP3E0cFLVZ4cZIyMQ=; b=YfmdiXrr2kEy2wZL6lAeFBO/TU5AoF8VDEM1JJz5GIuDYW6ttRyk0kWZr+hzQDo1GLseVmo7nnSJa6mVpLi0uj6oRoo6rJTf/Yu+TC54X0rACTl1de/bIAc1iCyGosXHI4GdBoLt6hl/u78Vf5o8jP+MMTuht3geAZNR10FUTsY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <7dbd6e34-ec28-5ba9-24ff-cc9e0b7e790b@citrix.com> Date: Fri, 24 Feb 2023 15:00:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 2/2] backup_ptes: fix leak on realloc failure Content-Language: en-GB To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Wei Liu , Anthony PERARD , Juergen Gross References: <2f23492a3861a3ebddbf1f811296e98143b9b8f4.1677245356.git.edwin.torok@cloud.com> From: Andrew Cooper In-Reply-To: <2f23492a3861a3ebddbf1f811296e98143b9b8f4.1677245356.git.edwin.torok@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0209.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::29) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5913:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fc356ce-30ca-4f63-16f6-08db1677f18e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nv6hDOpXNpZrNfV5c3vUsX2AGEvPnZu7ZNwgZD9jteBrlHV2XjQzv74hHy72Puz7KHeAbekya2Q3W/5aWnwC73AZh+EA7dK3rnIRz8Plz3wyY01xD9Jg3grnw90N9PyeWTI5VKjayLnWQXZ754h6AUvbvyI98ez4n4LbX9D3MZfI2rUI5TPtomBezsBO2Bfs49ISqtzlgc2YpRXgLOFeRKhpn6Pk1sdorYRJydrzfJs2EdoKf3oh5aNRDXfj+cKol+49XffD5qt3KI6m5gZNHB/bPNQ/4MxVcc8JPZFOtt5vyst723/8tJLtexFBO/F23mk9yjWmP3Dvk6Jh64MMt/V64DiqWAP4Nts58pe87MXYul7GDlO67BT+dNykaNj+KKG6pERDLmzGmX8S8oB7r22FDl7xUIphU+glNm0Rs08vgQEfvAGTOlTE2/CtWRKVkGbv6YUZ7BeuUDbbFblFn0tZQcAXTQD5ux3AQC+GamalbhabIu/QKBPXhgelTXtn61XXqrtKw74+hJGNzlyN2HTl1kh4GnDAeYp5kxPMByekUp2ya1ThwvHiYJtRkxo20Xvh9+2TrOB133JFBJ6M8X/EL3y116nJkl2859k8FGyHF5qEW9tl/t6Bj+mwhy4XzJYJAMv4ZcLrA4RzBmb0eiUHbyZ0pjpVbNpK5Dvp1deA6vJgOgVvwBfaKspzso29/1lESnbmK1622slmsXb9LdpN2dhvCXTZpu5fxnbguTY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199018)(83380400001)(36756003)(31696002)(66946007)(66476007)(4326008)(66556008)(8676002)(5660300002)(6666004)(8936002)(6506007)(53546011)(41300700001)(6486002)(82960400001)(54906003)(316002)(31686004)(478600001)(38100700002)(86362001)(2616005)(186003)(26005)(6512007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEZIRFBZMml0clEySURqQlIyRDcvNWtmblYxaXVQRU1YYjRsZkJPdU5lWXZE?= =?utf-8?B?c3Exa21LaUphd0Mxd1ZxOUw2SVlVY29tSS9tUVJQZllwN1FTK1lRSUZiY3ho?= =?utf-8?B?Y0FVNnQ1TXozQ1QzVWd5bDkwQTJlMVlTMkFsNTZWSmFmZVJvLzFPSzVJMHll?= =?utf-8?B?WitBL0xiTUNDSTZpMUNvYVBVbHVaMVpQUjgvV2p4NDZtelN4NWttVko3ZU9t?= =?utf-8?B?QkxJRVU2RUthMFdQazlvU3N2UHJCN0dKc0dZWFA0ZndTRzdVWFZJS3FxT25W?= =?utf-8?B?QlJINFRLVkpYVlBjdjFXdUo2NzVPaTlBS0lxL0svcS9zNUl6WnBldjRVWXVX?= =?utf-8?B?WnVVZWsvWFBXb3JqYk9rY25kRnlGTnlOajY2VUVtblg5dE8vN0wvK1pXNWV4?= =?utf-8?B?VmlUMWsxSmNVQnZNOWlCSUIzcU5PSzNSUTY4SkExVUpVZmw5ME1MM2pOSXMv?= =?utf-8?B?a3lXUlh2Ujd2ZUVpSFFpdWxuVEVrOG5uandhUU5CL0NsUTNVMURyWmpqN3Nh?= =?utf-8?B?TGtmUmJnUUNvK2pNclR2bjF0OXl1V3ZEVmVraG5Bbmw2V1R4ZGFtSlBXTkpI?= =?utf-8?B?OThqRDZzYWpDQlFhbmRJTmNYNjAvZHhRNitFMGxCeFFhS0hlYVpPZzhQM2kr?= =?utf-8?B?UFU1UUp5T2ZtM1BFeEwrL2lNR1JZZ2Q0S2V0T1FMdlphMCtHaTluUmJMajhB?= =?utf-8?B?R1E0Umg2T3IrTGh5RGNuU1FQclNvUXU1QkpXeUFkeUN0U3dYVlRrNUlEQTJP?= =?utf-8?B?cmxIR3g5cW43OXZmcDJ2UnlOQnpiSldyQ0VPaWF4NWZDbnFuM0NENXhPQzF2?= =?utf-8?B?SmRnVVJKbEExVndQaU9pM2gxbWU4VXpJaGk3eWZxdm5NV1BNMzhHdkwvOWFj?= =?utf-8?B?NVBrcUtEM0IwY0tjcW51VllqL2pOZ0JHVzI1SWk3b0RDTGVSdURlZGd1R01x?= =?utf-8?B?TGl0VWJjVHVNRnRpWHo0Qm1ZK21qT1luRFRpY1JJRExvK0Z2enh4aG95RE83?= =?utf-8?B?WGl1bUJ1elAyK3M1L09kVjNZQitSLzZvM3A2RGczRThmYzJ4MWxpd2xRMURr?= =?utf-8?B?ZEYxQ1d2ejdMeE9iNlhFWlNOdE1SNmwyYWd2N2ROMHJXOER3R2dyOGk4cHFV?= =?utf-8?B?QUtkanRGaStabVhhbHQwY1B6L2lpU0NuU3IxNzVzcG51WVVIbm15NVRUa1JJ?= =?utf-8?B?MWxEamxvb25RZFk2VTl3c1VJT2ZjOFU4WGhSZmVHT0FMSy93VWFyVnZ4S2U2?= =?utf-8?B?SWNRKzdnSnlRU0hvamxtaUhFeGJYVG1IcVBpT2RSRU9KRi81TTR4VmdLSWx6?= =?utf-8?B?azlxQ1lWcUUyMVZjQTVXTXZQZGNGb2tJL0RKWmZmV0RPZkZvZUxaY0NjUGt5?= =?utf-8?B?M1NyeW5zUjUvaEY0VTZkRjVHWXNXUGNVRFh5VXRFcVROZEYya1lvSlU4aUQw?= =?utf-8?B?SDN6cnAzYTFBSWZzeFhFQTRObE5ZWHRqWlczZUlub3FlTHZCUlAxUzlHb29J?= =?utf-8?B?WktONGxFc1NaUVBnMzMzZjNuNVJIUUFGUjYvckJqNjRBTzBpUmpLQk5uY29x?= =?utf-8?B?MENIOUVxTCtzN2JXc2Y1VndHT3lBRU9Vckg4UENXRlk2NUJuODNQcjZrdEJh?= =?utf-8?B?RnBwK05IaGx1SFNnSWJSdFFmNVdqc0ltbFpYWjZpOWdWM2d6c25vZnJQYzhN?= =?utf-8?B?LzFMZDBMQ0YyS2lKbEVNQUl1TjA1Z3VjOFBhT3dvSC9UM2FxdGpzeHpSRTRj?= =?utf-8?B?OTRZcE5VZURMakY0dHBoQ2ZmNmMxZlVYYmFHL2J0c3AyY1N0SktkQmFnQmx1?= =?utf-8?B?VmFwT25wcnBTQi91ZmRzYTZETEhlRkN0TGxkNUo4Y244RGZIcUJQSzhKNytJ?= =?utf-8?B?TkpUL1RyalpvNGY4eGhwckFJLzRpSXFhb3dZczhwS0dzTkg4MTFjbGp2V2h3?= =?utf-8?B?V0RwUlVxaUJPakpaR3BDb3R3V2JEbVovNGZpUnZsV3NvOWZUWnB3S0FWSUFs?= =?utf-8?B?aC9ZZWpPR3ZqTExpaTFDc2lTRy9LQzZuN0p0VU9MVTYzOHk1WDNITzNxajNE?= =?utf-8?B?YTJKWEE4SndXdUVkVWJoalkzZlpkNytnSjV0WWF1UGpOMjV5OWZVMG9HbExt?= =?utf-8?B?U2ZYa0lIODdjMGRBZmxqWFYvb2F4VWVCbEE0MUJZODhoS014TEVMZ2VmV3FM?= =?utf-8?B?WkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Gsw+fa4kFiV+uUED5kWIm34UP9PBjgRGNSdKAe8TiSoI2eiXI6i4DZs9DBU8kupkdk+mWen3igrroMucuG18iuKcqw2BKYB/fAH/aGypH5lN1n7iF8iXaxxEUYpzRiXTJ6qiOmxOVkfEy5p+J2JCSShgihU8zHhg68b/VYszjpQnTrpFJxw8g96Hj21H5C6POz2ly+50Y6uLj2PtGAahymVm1yXfnoF1Kw2q0sSYjsy/LcS/sr+MNE5lEEqoinsAYSxsMfgRrTwgE3wNV7Kq08qWcg9q0QtjKb1p6vUSzgFZEwcKzZyNH8vPSoVpSHvMigmkRnxvFsmsK35ZEZWD4pE6TYjAN+hOYJUdyFyIjLabh4qRuyepqXdZMVMUIL4xLfw6bm+VHvA44kdLSDLo49rqGy80vSUCLTBfwZvMGYM4QA9gUx0m1G/B1BnOyfY+HlJFz4cJy9ziOlpq9PAC6hmA6kj+FHi2TT6jHwCnFV478//M8jdWjEmFAMhNUVCq6Yr9756yHXJgwHXtby0rGtcs7ZW1laQTSSE9KlwscJ7mG2zgPe1/5NtNZAct2rtmlLhXaCopEjc55KyJvYSJzJ9JAdVBVRxqkBsZbzKBj+YpSIia30logdk/eonBVi+HbQYUXePIf+LiqDaYbdHqK8f/RJE+h31aA9ppGbPwtqvbnu2DqV38AmvZPTZIz3kRpthKQxbkup3hOcZu58m4apZC/4gIRM9+z7DEV+Axojn9OU6OL9qVpxd/8t1o/abcoLJ3iNT9NhoUazzdxgzDcxEUKI9/WJV/6XfmGuEeRLwFyrWa7DkpneKqggFUkEDdhAdvp/sCZtxLq8rUqUd4IZrwr+I5LUbehL3gff+mcQY= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc356ce-30ca-4f63-16f6-08db1677f18e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:01:01.5722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SOa+09IRHOatTe3wZpMlZlgXKEoP0UPBoZ1wEjtSLWkHGVsP9i8Zb+Ub0HdqHPY30GGIp+Dn7k6USug8gdRV1Uyztp4Sx0Xdpx21Io4NX6s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5913 On 24/02/2023 1:36 pm, Edwin Török wrote: > From: Edwin Török > > From `man 2 realloc`: > `If realloc() fails, the original block is left untouched; it is not freed or moved.` > > Found using GCC -fanalyzer: > ``` > | 184 | backup->entries = realloc(backup->entries, > | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | | | | > | | | | (91) when ‘realloc’ fails > | | | (92) ‘old_ptes.entries’ leaks here; was allocated at (44) > | | (90) ...to here > ``` > > Signed-off-by: Edwin Török In terms of the fix, Acked-by: Andrew Cooper , but > --- > tools/libs/guest/xg_offline_page.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c > index c594fdba41..a8bcea768b 100644 > --- a/tools/libs/guest/xg_offline_page.c > +++ b/tools/libs/guest/xg_offline_page.c > @@ -181,10 +181,13 @@ static int backup_ptes(xen_pfn_t table_mfn, int offset, > > if (backup->max == backup->cur) > { > - backup->entries = realloc(backup->entries, > + void* orig = backup->entries; void *orig, and a newline. > + backup->entries = realloc(orig, > backup->max * 2 * sizeof(struct pte_backup_entry)); > - if (backup->entries == NULL) > + if (backup->entries == NULL) { Newline. Can be fixed on commit. ~Andrew > + free(orig); > return -1; > + } > else > backup->max *= 2; > } From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:04:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:04:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501130.772735 (Exim 4.92) (envelope-from ) id 1pVZcO-0005kl-Qu; Fri, 24 Feb 2023 15:04:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501130.772735; Fri, 24 Feb 2023 15:04:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZcO-0005ke-O4; Fri, 24 Feb 2023 15:04:16 +0000 Received: by outflank-mailman (input) for mailman id 501130; Fri, 24 Feb 2023 15:04:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZcN-0005kY-CZ for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:04:15 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [2a01:111:f400:fe0e::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 803da0a5-b454-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:04:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9461.eurprd04.prod.outlook.com (2603:10a6:102:2a9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 15:04:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 15:04:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 803da0a5-b454-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGdWm5rEJZH3FZGgGWj1KM2T9FvJ7GFXijkmxGLGmm77NdUi6p6GvvGbnW7s2tfap1UZaqU0ljG/CPcTBsJb9mrvWmlFCMZyn4LbxUIIYdnEt9C/ipLA0vRlJ3yPmB+U5GKS+9CQcvtIrx7ZLfqr2mS75um+/5UrjglnFwp5bVGjLs9SERhuXRsYAqTq0DInCLz66GJEhLQskhPpryJB0MxSy4hHFIeo7Y9ZTFwdX6EcoVGIXW04F5TZEW2LTngyPgdH8tZ5h+y4/QENud5eo1+Zktccb0xP51iiSYlXyUGRwOwCKKxWXvwPwgc5JNfKanA4jReHj5rE3oAB9Ol7gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/P2JW8hT5mG4fWX+r20I6j0WMkFT8r2krlr/tKelmZY=; b=K7uMnE5fMHEaM52wRer5zrz7W7sGNEAews+7205+YnEaJ9NYCotVNLJJtSgSavRz5+yXh6zVy0Cus5doXuNHtNAdAqBS83PQhalnL6qDS1S7vIafe7FupNVGWBq1iO0oUH+faAiT4gKzv2T2xY4UgSpgmb+o4eErkP7n0ecfc9DERSZ6DBMtvZ0oVAhVersRkioomWaexw7kjcpdTkHop3q5wedlPnCy1NTtVYhIUkdKDi4fnm087yWILSR7ejUbk3GvxYk8zpc96d9Iqe6hptNM6ZhbPiIgRpdw3im+9jBNi9oSChynmjMR+q5esMlWFzAK3MQ81xAogHlRm1p53Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/P2JW8hT5mG4fWX+r20I6j0WMkFT8r2krlr/tKelmZY=; b=IKvFRy+ChT4n3S9s1a/A4DhCviIaYj+ErJVKDYhjLxcpSdvdqIKRpSV/SktucY5dwjs2mqyIp0MOHK93ZgdpqqOsUvzvVKONXH+cNK45yVykVZ43nnuN5NrM7lHkqMa5bsBzhzirEflzX0F1WA8KYoufom9hr2l4ELiwrPjKss6In+dO8TgGEFavvH9LaKb1y5sFAbtaEiGwBCQDFUMu/FSlxl8kdtnb35UCAaTJxwkQc0nx6xkXQvxBpm9vsGT22c/hRijkZupJF8SS8CjMZ0PjFmO4vdS3iELYdKZxRpqMGruAGs0RJGlPdm0mix1AoeZYSpZnb1jjyF6DdxIl4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 24 Feb 2023 16:04:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: d5c8a045-f3e1-43d6-8fa5-08db167863a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5eXnFg90wEP1KNpaN1NnceQeRbj6HyAYdZoxN4sHMJirgSgYk0Vm7MDIZanmxyqkfBNLy/0JT9+sMAMlYs1nDHgL+8hsE8VMH18ZMd17dKvVsPZU7VVH0WB/KsQ7LYKlOxF1jt1UR1t1DmGtG4zp8Wfmb8KLCxQq3w1ROkgaYeCL+K1v9z90+F6KyYIA3Y0wmopPzXccxzMSsL3H3MxsTdE/dXDtNHobrLHD8h0HRwDd94CvvPEUOJGRiRwoS0VRdftrvUvsNqFoS3L1RqvZm7uQl4eLDGRRAro1L5XHLvOy8B8WmTWPbWDnuVfD6F51JcCnDX6A+iAlwgLBTewqHPlXe+E4jCmVPE5OFvV904Vcu4BE4RZEdG+qz0pKcQa7RpHnqlN7mP2xgLAH540ND4YvDTjkIWHF4nQQFoaVpZWrVz5KjBPCqb6DEOssdUk0eLzrEYb61EviKuYjNdQ7yTYDKExepp6UJZ8yCDr7Q4/fFMiozhJxMJEZ3XYI2kGgWQ1GKQUMbhc+EFihQHo7ifPyXaiNVsB3hYbFjUlO73vDsgwxcA1w2y0J8yoHp6McJn7XTLzVlrxSFyMVTLtr1yGxLeV9DTg7YiH/DTFfiKYJVeqK6oh4CPPhvVePPm3aFaQMpKdf6fkhDkfHtEZsDNZfRiucUUeSMm1McfkP48ZRCNENDrlnqf64t/O9JUKVCP9q6536RlvEGI1nNPH/qwLDljSYHF4ukm9WQUchaOQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199018)(2906002)(5660300002)(36756003)(478600001)(6506007)(2616005)(186003)(316002)(54906003)(86362001)(26005)(38100700002)(6916009)(66556008)(66946007)(66476007)(8676002)(4326008)(8936002)(41300700001)(6512007)(31696002)(53546011)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUY3MGYwQ2N6SWRRYUtGbVl0Q3BoOHQzaXJYcE1OTGFVb0loQmV6NXRLSGtj?= =?utf-8?B?K25UL1Z0aGw2alRyMDVwQ0JEMDEyVktvTm13UXBCU3Y2R2lNVUhzYlpDT2t2?= =?utf-8?B?NEpWczZydnp5N2RyYkdEb1RKeU11NzRkR2JnMEQ4RzFVVEVFdHViTVNBMDlG?= =?utf-8?B?dFdQbmo3blJQSllURVpyV3hzRGRZb0NzSlFVWVZLYUFhSS9QWnNWQlIxZlFH?= =?utf-8?B?N01MTXpEWjRzREkwaG0zeG9leTY3NHN3cGdGMS9uc0hGbld0cmtHMyszM1V4?= =?utf-8?B?WVB5ellRQnpjcDVPcHE0TDRsUGp5Q0RxQVBEVUpEZDNJblRBMGNlNDJOVkJ6?= =?utf-8?B?dFFWMGRrNkF5OFhaT2wvT1QvSURkTnNmUGhCVDdqK08za2l4UE9IM1ZLaFR2?= =?utf-8?B?anFKOEQ1aW8wQlI1QnRXZC9YR0VZUXJMM3NKelMzU1hBUFVacEdBUGJ5UEZN?= =?utf-8?B?UEhNU1h3NzRaQWVHQyt0amMrcU1ucmRqRXE1V2JYUjVsaVpJaHV3ZCs0WlNH?= =?utf-8?B?ajNkWXlmWHg4S1ZCUVN0Z3l6Rzc4OVVrZitCOVlOU0FrbktXM3hzdy8rMUlZ?= =?utf-8?B?UkZxclA2ZUhWS1R1MWxJazVRdTFQMWZLZHdoR2F6cVZyZ3Z1SEFQTy9DVWpG?= =?utf-8?B?V2RCOStGQXV1ZGtZRzhXTlgyOExWdzZ1NS9zT3ZMamZmYVpETnFEVmlzSHlX?= =?utf-8?B?UldSdkZNSmVxM2lrd1VtQkFoeFc5Q2NSOTdiS3IyVWZRQVZOc3htKytYNDJM?= =?utf-8?B?ZVFvdG5jSXNKb3pkNVN5eVppYVRDSk1oT0VpTjFJOXR1dk5hT0NlS1NEbGZW?= =?utf-8?B?VXdNWmZYN0U5TEdKVWdJbkllWVQxV3pjRnl6MWFHL1NLaVFEcDY4R1VuS0U2?= =?utf-8?B?ZUJjNWVRRk42L1cwVE0xOUJyTmJ2ei9EQTl3aC80dVNsbEo4Nk9jYkdUd0ZB?= =?utf-8?B?ZmxMREFPcUtyUVU5dHRGZmpzV2t0d2g0YVRJYUZXaHVlc2JHVmlqNzdPS29Q?= =?utf-8?B?ZnQySGQvb1lTVytaaUd5OXRNdDVnMGMyM1lSUlIzVDFHbjlNYTdnT095b04w?= =?utf-8?B?a29HeEQwVnFlNHlBSWxOOURQNjczaDNsYlJNSVo5UWtjRnUzalVtZnJ6Vlhh?= =?utf-8?B?WVN2SEF5cncwWVBmYXg4K2t3UHkxN1F4OXdrRWJHNnlneSsybmZrejFNTnlm?= =?utf-8?B?NkhLTElZYkRSbkgyZGJORUc2N3E2SW5jaHJNWGNrWlZBWHJKaTRndkdoRVB4?= =?utf-8?B?UExQSG8wOTQzSGZtR1VSYkJRMlpHNW5hbFg3ekF4T3lNUEZnY3JMNDFCYWJu?= =?utf-8?B?aEsyeW1kUjR1ZDZDUDVZZ21UdVp3Snd2Qm9TYlU4ald3Yk1heC80RVF6eSs1?= =?utf-8?B?OWhVMWI0bWpmRTFUaVl0TWtjdnIxdGpoNnZhQ3VwVE8vL0hzb0FpTzh5Zk8y?= =?utf-8?B?ekhla3hXSVBnQkZXeFphRWFaVXYxaHFGcXVIQ1NxVHNzd0g2RzJQclhBZWE2?= =?utf-8?B?eVdmdVEyTlRGU095OThoZ0RwaWlCYlhQOWRmc0I0bkVzTlpacWljblVxaEZl?= =?utf-8?B?TEZmQUZYL2tkQ1JsTnRYR0N4andkL3FILzlyMlo2VHZiY01Ba3FiUS84TGlI?= =?utf-8?B?cWZSYzV0aUtDeCtDSEVlV2E0YmtnUGgyRGFDOTVNN1cyZTUxc2UrN0ZtQnJl?= =?utf-8?B?OWRZL1NjNWluQWxKWEpQTnppWUcwcW03c3R6R080d3J3Vzc1anBNQmpPNjBl?= =?utf-8?B?alV0ckZxU0pKZkNMRGpOSVdRT0MxcnhZNFFRdFM3bTJzRjJNejNvMFRjQkQ0?= =?utf-8?B?ZUNzRFl5cWZXcnJGVEFkN0ZpejcwdkVINXBEbzQ0dVZsVkpMWTZ5blN1U1FV?= =?utf-8?B?QjhkQUpNNlByakovaEVJQnpubFJsc1FNbG01ZTVLNWpUWnNZM0c5Rk4reXcx?= =?utf-8?B?N1lxMW4rOXdzQ2RUYlkvRDBSMUdRNUd5NnAreUZUVUYycm40N2hudm9FZk5U?= =?utf-8?B?clpQdE0yQ29uSWhWaVdkaExYajBuS1pCc2F5a3N1MXYwMFhjL3VQQmFnWnFB?= =?utf-8?B?QzBVbmJpTHpjeXdYcUxqeVVzWUFnYXlNM0Y1bjR4LzlBb1NuSW1NWlphd2RH?= =?utf-8?Q?k5AZMZAy5wtTGlvzoneycsgbx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5c8a045-f3e1-43d6-8fa5-08db167863a1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:04:12.7882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LIzdzJ5pXHvjwuncqN8Tn4DCDaqTGeSmDc9XRcgN8oxGj7RrqeYql1Qx9OynX8wU/VZUEpUA/aErJFEJtMPtRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461 On 24.02.2023 15:48, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/setup.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index b3f8b10f71..154bf3a0bc 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) > > void __init noreturn start_xen(void) > { > + /* > + * The following things are passed by bootloader: > + * a0 -> hart_id > + * a1 -> dtb_base > + */ > + register unsigned long hart_id asm("a0"); > + register unsigned long dtb_base asm("a1"); > + > + asm volatile( "mv %0, a0" : "=r" (hart_id) ); > + > + asm volatile( "mv %0, a1" : "=r" (dtb_base) ); Are you sure this (a) works and (b) is what you want? You're inserting "mov a0, a0" and "mov a1, a1". I suppose as long as the two local variables aren't used further down in the function, the compiler will be able to recognize both registers as dead, and hence use them for argument passing to later functions that you call. But I would expect that to break once you actually consume either of the variables. Fundamentally I think this is the kind of thing you want do to in assembly. However, in the specific case here, can't you simply have void __init noreturn start_xen(unsigned long hard_id, unsigned long dtb_base) { ... and all is going to be fine, without any asm()? Otherwise again a style nit: In the asm statements (not the register declarations) there is a missing blank each before the opening parenthesis. Jan From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:06:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501137.772747 (Exim 4.92) (envelope-from ) id 1pVZek-0006PC-Cj; Fri, 24 Feb 2023 15:06:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501137.772747; Fri, 24 Feb 2023 15:06:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZek-0006P5-82; Fri, 24 Feb 2023 15:06:42 +0000 Received: by outflank-mailman (input) for mailman id 501137; Fri, 24 Feb 2023 15:06:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZej-0006Ou-8l for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:06:41 +0000 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [2a00:1450:4864:20::234]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d78ae3bd-b454-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:06:40 +0100 (CET) Received: by mail-lj1-x234.google.com with SMTP id b13so15435084ljf.6 for ; Fri, 24 Feb 2023 07:06:40 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id d23-20020ac25457000000b004d863fa8681sm1492443lfn.173.2023.02.24.07.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:06:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d78ae3bd-b454-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=15r4qNmq9J3Ng12XQxf1KofVc3mLAOcGQ5mfhCiR/cs=; b=MHsG/oBZGPtXAwgyVfUwHZBMNIqzbWZ1kW/XW2zOimWNruUNtDMrHk1DmeEeJ1KnOI psTM+AtLOE1JilOdmmMpqMzR4KZSY4XwXZ1gNFEk2XHIQUuGVANuN6JB9iKlr34AGUfL NlMsOysODTRbqhO7g3HRt/bjrP/KIUn0GXuA9rTu85I/G6v4UpzO1mOdURWHT32Uhy/R tzeXJLoNt8OOOAPtFmaxYGKOSkmeVq0Bh4RRxa7a+e+yjz8qrtQa5kunaH7UyzfzwW9N RWWQ342y+1QkyzufPlQNGt4T0qeCTJvHFXLHlJEqqGC8xuizl32dp6Fr3yh7XJxA6iGw Euuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=15r4qNmq9J3Ng12XQxf1KofVc3mLAOcGQ5mfhCiR/cs=; b=xgtSlgPFNovNeVPIUZssRbz9ZTqm9FbJk64LVRPCxFpRHrXJzhQugTnV3uxAsKC6fe Uwx3uCvVuHfoLPs8SWeHZA0Gud86DvIf9SbW2JxzDqmXNxE7eNqqDmK4H7tP8EGdzmv+ umjUYZ5asw7xdusjt10PLDj50r2rLY4D1tZpZ5Siw3T2Ls4HaR3/xItdD7OyhtyaFv5F 1ZFu8R7yzRgoJtzHgjR9a+bypVB3qBfNst9aNrLd+pDu+co8dGb+qbKhL/sCwFlMvtMq xgFLtrmRi7BhqSaICnFiabzvwMtjjkyvaJ/VSb/zuyI44sCx/PLsUumA38M+cBHV3Dkt uG6Q== X-Gm-Message-State: AO0yUKUIE9BepEEMvREwaH4CjnurDchSS2M3y86z3WpgRFYwlT8X1QPf byO7zeXlvIdZwP/s0RwD5C0DQLbDAHY= X-Google-Smtp-Source: AK7set/5BmrZmVHTpT5zPx9cW2CXbZRcOsbPDOiPcYrXrwc6NxZVi90IbQsJni8SGPff05K8pGN8Xg== X-Received: by 2002:a2e:7310:0:b0:295:9659:fba5 with SMTP id o16-20020a2e7310000000b002959659fba5mr4011795ljc.37.1677251199776; Fri, 24 Feb 2023 07:06:39 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Subject: [PATCH v1 0/3] enable MMU for RISC-V Date: Fri, 24 Feb 2023 17:06:32 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map the following: * The physical location of Xen (where the bootloader loaded it) * The link-time location of Xen (where the linker expected Xen's addresses to be. 2. Load the built page table into the SATP 3. Enables MMU. 4. Updates smoke test to grep message which should be printed after MMU is enabled. Oleksii Kurochko (3): xen/riscv: introduce setup_initial_pages xen/riscv: setup initial pagetables automation: update RISC-V smoke test automation/scripts/qemu-smoke-riscv64.sh | 2 +- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/mm.h | 9 + xen/arch/riscv/include/asm/page.h | 90 +++++++++ xen/arch/riscv/mm.c | 223 +++++++++++++++++++++++ xen/arch/riscv/setup.c | 11 ++ 6 files changed, 335 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:06:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:06:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501138.772756 (Exim 4.92) (envelope-from ) id 1pVZel-0006eX-Ir; Fri, 24 Feb 2023 15:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501138.772756; Fri, 24 Feb 2023 15:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZel-0006eQ-FE; Fri, 24 Feb 2023 15:06:43 +0000 Received: by outflank-mailman (input) for mailman id 501138; Fri, 24 Feb 2023 15:06:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZek-0006Ou-Lj for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:06:42 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d85a0d9d-b454-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:06:41 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id k14so17292450lfj.7 for ; Fri, 24 Feb 2023 07:06:41 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id d23-20020ac25457000000b004d863fa8681sm1492443lfn.173.2023.02.24.07.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:06:40 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d85a0d9d-b454-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gXawhnE5jkqhZOoZruY5CrZc+i29kTMYxJVObGHfjMI=; b=Cu5oxsw7VJsw/LxVADe9BvwNUZR4vaXCU4C2+tIt4O2iPhdW76P3bb0wtbdl2QXB7/ wlFhr7JuYwZExbKAfDBco+cFcNpGaAaZZbgnSd77ibALk0nZ/SYB496Gsh46uEMBgfGa hAbY2Mn6cTVUoW2sgOMtvQ0m8D7A2PSDODsfv0U5TjBCWjVpQCbqPDVrm2QfkLa2xdd3 CI8mvdLCODbKNwyFfstHs4PA6DG+rmgXPH0iGBXDeZxzRmAn6wC+5OrKKavDl085Lm2V FaFnACEiqndlnyvg6YQRFVSc7SuQN9+Ep7WQpORuR3AlI/9IuL0ZeMfpRar5qmXtyt2h 91pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gXawhnE5jkqhZOoZruY5CrZc+i29kTMYxJVObGHfjMI=; b=Dqp/tX72vmeOwxm2jVoi13yBCMPQEaclcUYwxp8CAhsi+XrW/RmRuLi6qCLhrOKYRj vur4VwyDUvQUo7DJzodHeZKUp9rx74GERuz3DTIzOI81xIlTmDu05yPp4oE/ZdKDtosO G8oDczrJigRPQPJO+21X+SRdmQar/7bWICQa+JNBgG8qXXFYWFLoHuxd9HKginID2C0U ZNM0gCjzawUbyt+PDi8jbUIM4IWj6XVH7waQC0gvxIjMw/8PwOJVTR4iGyLXzVaKMXMR g1mlIGsABOoR0zZR4giCMUvjgWkt7fDND2iGrd8ndD6SGOpy6ihRm3n57fBQ6qHQqIQZ p/EQ== X-Gm-Message-State: AO0yUKVjsziUwrNvE8qs3/IU2W/alCjS8qvSLP9LzfyDzAxQXStKvQiT TZOw4eRD3Co0a8u2GQg2HK9IYUxlvC4= X-Google-Smtp-Source: AK7set86tEFDgJknJHgH2TlaUlv4gl/KdDVxTIX/gEUSUMZtLJNIBzmst4hjSM6Kwvax+5AsBN5fGA== X-Received: by 2002:ac2:59d9:0:b0:4dc:260e:6b59 with SMTP id x25-20020ac259d9000000b004dc260e6b59mr5945954lfn.40.1677251201252; Fri, 24 Feb 2023 07:06:41 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Date: Fri, 24 Feb 2023 17:06:33 +0200 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Mostly the code for setup_initial_pages was taken from Bobby's repo except for the following changes: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add writable argument for _setup_initial_pagetables to have an opportunity to make some sections read-only * update setup_initial_pagetables function to make some sections read-only * change the order of _setup_inital_pagetables() in setup_initial_pagetable(): * first it is called for text, init, rodata sections * after call it for ranges [link_addr_start : link_addr_end] and [load_addr_start : load_addr_end] Before it was done first for the ranges and after for sections but in that case read-only status will be equal to 'true' and as sections' addresses can/are inside the ranges the read-only status won't be updated for them as it was set up before. Origin: https://gitlab.com/xen-on-risc-v/xen/-/tree/riscv-rebase 4af165b468af Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/Makefile | 1 + xen/arch/riscv/include/asm/mm.h | 9 ++ xen/arch/riscv/include/asm/page.h | 90 ++++++++++++ xen/arch/riscv/mm.c | 223 ++++++++++++++++++++++++++++++ 4 files changed, 323 insertions(+) create mode 100644 xen/arch/riscv/include/asm/mm.h create mode 100644 xen/arch/riscv/include/asm/page.h create mode 100644 xen/arch/riscv/mm.c diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile index 443f6bf15f..956ceb02df 100644 --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -1,5 +1,6 @@ obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += entry.o +obj-y += mm.o obj-$(CONFIG_RISCV_64) += riscv64/ obj-y += sbi.o obj-y += setup.o diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h new file mode 100644 index 0000000000..fc1866b1d8 --- /dev/null +++ b/xen/arch/riscv/include/asm/mm.h @@ -0,0 +1,9 @@ +#ifndef _ASM_RISCV_MM_H +#define _ASM_RISCV_MM_H + +void setup_initial_pagetables(unsigned long load_addr_start, + unsigned long load_addr_end, + unsigned long linker_addr_start, + unsigned long linker_addr_end); + +#endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h new file mode 100644 index 0000000000..fabbe1305f --- /dev/null +++ b/xen/arch/riscv/include/asm/page.h @@ -0,0 +1,90 @@ +#ifndef _ASM_RISCV_PAGE_H +#define _ASM_RISCV_PAGE_H + +#include +#include + +#define PAGE_ENTRIES 512 +#define VPN_BITS (9) +#define VPN_MASK ((unsigned long)((1 << VPN_BITS) - 1)) + +#ifdef CONFIG_RISCV_64 +/* L3 index Bit[47:39] */ +#define THIRD_SHIFT (39) +#define THIRD_MASK (VPN_MASK << THIRD_SHIFT) +/* L2 index Bit[38:30] */ +#define SECOND_SHIFT (30) +#define SECOND_MASK (VPN_MASK << SECOND_SHIFT) +/* L1 index Bit[29:21] */ +#define FIRST_SHIFT (21) +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) +/* L0 index Bit[20:12] */ +#define ZEROETH_SHIFT (12) +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) + +#else // CONFIG_RISCV_32 + +/* L1 index Bit[31:22] */ +#define FIRST_SHIFT (22) +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) + +/* L0 index Bit[21:12] */ +#define ZEROETH_SHIFT (12) +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) +#endif + +#define THIRD_SIZE (1 << THIRD_SHIFT) +#define THIRD_MAP_MASK (~(THIRD_SIZE - 1)) +#define SECOND_SIZE (1 << SECOND_SHIFT) +#define SECOND_MAP_MASK (~(SECOND_SIZE - 1)) +#define FIRST_SIZE (1 << FIRST_SHIFT) +#define FIRST_MAP_MASK (~(FIRST_SIZE - 1)) +#define ZEROETH_SIZE (1 << ZEROETH_SHIFT) +#define ZEROETH_MAP_MASK (~(ZEROETH_SIZE - 1)) + +#define PTE_SHIFT 10 + +#define PTE_VALID BIT(0, UL) +#define PTE_READABLE BIT(1, UL) +#define PTE_WRITABLE BIT(2, UL) +#define PTE_EXECUTABLE BIT(3, UL) +#define PTE_USER BIT(4, UL) +#define PTE_GLOBAL BIT(5, UL) +#define PTE_ACCESSED BIT(6, UL) +#define PTE_DIRTY BIT(7, UL) +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) + +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE | PTE_EXECUTABLE) +#define PTE_TABLE (PTE_VALID) + +/* Calculate the offsets into the pagetables for a given VA */ +#define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT) +#define first_linear_offset(va) ((va) >> FIRST_SHIFT) +#define second_linear_offset(va) ((va) >> SECOND_SHIFT) +#define third_linear_offset(va) ((va) >> THIRD_SHIFT) + +#define pagetable_zeroeth_index(va) zeroeth_linear_offset((va) & ZEROETH_MASK) +#define pagetable_first_index(va) first_linear_offset((va) & FIRST_MASK) +#define pagetable_second_index(va) second_linear_offset((va) & SECOND_MASK) +#define pagetable_third_index(va) third_linear_offset((va) & THIRD_MASK) + +/* Page Table entry */ +typedef struct { + uint64_t pte; +} pte_t; + +/* Shift the VPN[x] or PPN[x] fields of a virtual or physical address + * to become the shifted PPN[x] fields of a page table entry */ +#define addr_to_ppn(x) (((x) >> PAGE_SHIFT) << PTE_SHIFT) + +static inline pte_t paddr_to_pte(unsigned long paddr) +{ + return (pte_t) { .pte = addr_to_ppn(paddr) }; +} + +static inline bool pte_is_valid(pte_t *p) +{ + return p->pte & PTE_VALID; +} + +#endif /* _ASM_RISCV_PAGE_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c new file mode 100644 index 0000000000..6e172376eb --- /dev/null +++ b/xen/arch/riscv/mm.c @@ -0,0 +1,223 @@ +#include +#include + +#include +#include +#include + +/* + * xen_second_pagetable is indexed with the VPN[2] page table entry field + * xen_first_pagetable is accessed from the VPN[1] page table entry field + * xen_zeroeth_pagetable is accessed from the VPN[0] page table entry field + */ +pte_t xen_second_pagetable[PAGE_ENTRIES] __attribute__((__aligned__(PAGE_SIZE))); +static pte_t xen_first_pagetable[PAGE_ENTRIES] + __attribute__((__aligned__(PAGE_SIZE))); +static pte_t xen_zeroeth_pagetable[PAGE_ENTRIES] + __attribute__((__aligned__(PAGE_SIZE))); + +extern unsigned long _stext; +extern unsigned long _etext; +extern unsigned long __init_begin; +extern unsigned long __init_end; +extern unsigned long _srodata; +extern unsigned long _erodata; + +paddr_t phys_offset; + +#define resolve_early_addr(x) \ + ({ \ + unsigned long * __##x; \ + if ( load_addr_start <= x && x < load_addr_end ) \ + __##x = (unsigned long *)x; \ + else \ + __##x = (unsigned long *)(x + load_addr_start - linker_addr_start); \ + __##x; \ + }) + +static void __init clear_pagetables(unsigned long load_addr_start, + unsigned long load_addr_end, + unsigned long linker_addr_start, + unsigned long linker_addr_end) +{ + unsigned long *p; + unsigned long page; + unsigned long i; + + page = (unsigned long)&xen_second_pagetable[0]; + + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_second_pagetable); i++ ) + { + p[i] = 0ULL; + } + + page = (unsigned long)&xen_first_pagetable[0]; + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_first_pagetable); i++ ) + { + p[i] = 0ULL; + } + + page = (unsigned long)&xen_zeroeth_pagetable[0]; + p = resolve_early_addr(page); + for ( i = 0; i < ARRAY_SIZE(xen_zeroeth_pagetable); i++ ) + { + p[i] = 0ULL; + } +} + +/* + * WARNING: load_addr() and linker_addr() are to be called only when the MMU is + * disabled and only when executed by the primary CPU. They cannot refer to + * any global variable or functions. + */ + +/* + * Convert an addressed layed out at link time to the address where it was loaded + * by the bootloader. + */ +#define load_addr(linker_address) \ + ({ \ + unsigned long __linker_address = (unsigned long)(linker_address); \ + if ( linker_addr_start <= __linker_address && \ + __linker_address < linker_addr_end ) \ + { \ + __linker_address = \ + __linker_address - linker_addr_start + load_addr_start; \ + } \ + __linker_address; \ + }) + +/* Convert boot-time Xen address from where it was loaded by the boot loader to the address it was layed out + * at link-time. + */ +#define linker_addr(load_address) \ + ({ \ + unsigned long __load_address = (unsigned long)(load_address); \ + if ( load_addr_start <= __load_address && \ + __load_address < load_addr_end ) \ + { \ + __load_address = \ + __load_address - load_addr_start + linker_addr_start; \ + } \ + __load_address; \ + }) + +static void __attribute__((section(".entry"))) +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t *zeroeth, + unsigned long map_start, + unsigned long map_end, + unsigned long pa_start, + bool writable) +{ + unsigned long page_addr; + unsigned long index2; + unsigned long index1; + unsigned long index0; + + /* align start addresses */ + map_start &= ZEROETH_MAP_MASK; + pa_start &= ZEROETH_MAP_MASK; + + page_addr = map_start; + while ( page_addr < map_end ) + { + index2 = pagetable_second_index(page_addr); + index1 = pagetable_first_index(page_addr); + index0 = pagetable_zeroeth_index(page_addr); + + /* Setup level2 table */ + second[index2] = paddr_to_pte((unsigned long)first); + second[index2].pte |= PTE_TABLE; + + /* Setup level1 table */ + first[index1] = paddr_to_pte((unsigned long)zeroeth); + first[index1].pte |= PTE_TABLE; + + /* Setup level0 table */ + if ( !pte_is_valid(&zeroeth[index0]) ) + { + /* Update level0 table */ + zeroeth[index0] = paddr_to_pte((page_addr - map_start) + pa_start); + zeroeth[index0].pte |= PTE_LEAF_DEFAULT; + zeroeth[index0].pte &= ~((!writable) ? PTE_WRITABLE : 0); + } + + /* Point to next page */ + page_addr += ZEROETH_SIZE; + } +} + +/* + * setup_initial_pagetables: + * + * 1) Build the page tables for Xen that map the following: + * 1.1) The physical location of Xen (where the bootloader loaded it) + * 1.2) The link-time location of Xen (where the linker expected Xen's + * addresses to be) + * 2) Load the page table into the SATP and enable the MMU + */ +void __attribute__((section(".entry"))) +setup_initial_pagetables(unsigned long load_addr_start, + unsigned long load_addr_end, + unsigned long linker_addr_start, + unsigned long linker_addr_end) +{ + pte_t *second; + pte_t *first; + pte_t *zeroeth; + + clear_pagetables(load_addr_start, load_addr_end, + linker_addr_start, linker_addr_end); + + /* Get the addresses where the page tables were loaded */ + second = (pte_t *)load_addr(&xen_second_pagetable); + first = (pte_t *)load_addr(&xen_first_pagetable); + zeroeth = (pte_t *)load_addr(&xen_zeroeth_pagetable); + + /* + * Create a mapping from Xen's link-time addresses to where they were actually loaded. + */ + _setup_initial_pagetables(second, first, zeroeth, + linker_addr(&_stext), + linker_addr(&_etext), + load_addr(&_stext), + false); + _setup_initial_pagetables(second, first, zeroeth, + linker_addr(&__init_begin), + linker_addr(&__init_end), + load_addr(&__init_begin), + true); + _setup_initial_pagetables(second, first, zeroeth, + linker_addr(&_srodata), + linker_addr(&_erodata), + load_addr(&_srodata), + false); + _setup_initial_pagetables(second, first, zeroeth, + linker_addr_start, + linker_addr_end, + load_addr_start, + true); + + /* + * Create a mapping of the load time address range to... the load time address range. + * This mapping is used at boot time only. + */ + _setup_initial_pagetables(second, first, zeroeth, + load_addr_start, + load_addr_end, + load_addr_start, + true); + + /* Ensure page table writes precede loading the SATP */ + asm volatile("sfence.vma"); + + /* Enable the MMU and load the new pagetable for Xen */ + csr_write(CSR_SATP, + (load_addr(xen_second_pagetable) >> PAGE_SHIFT) | SATP_MODE_SV39 << SATP_MODE_SHIFT); + + phys_offset = load_addr_start - linker_addr_start; + + return; +} -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:06:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:06:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501139.772765 (Exim 4.92) (envelope-from ) id 1pVZem-0006uc-RN; Fri, 24 Feb 2023 15:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501139.772765; Fri, 24 Feb 2023 15:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZem-0006uP-OZ; Fri, 24 Feb 2023 15:06:44 +0000 Received: by outflank-mailman (input) for mailman id 501139; Fri, 24 Feb 2023 15:06:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZel-0006Ou-Ew for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:06:43 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d91818c7-b454-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:06:43 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id k14so17292528lfj.7 for ; Fri, 24 Feb 2023 07:06:43 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id d23-20020ac25457000000b004d863fa8681sm1492443lfn.173.2023.02.24.07.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:06:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91818c7-b454-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X/gSRFTkaEkbR97ZxT3k+xBfRgzno3qG9xfy82tbgR4=; b=KpaLs9XDqIEFJGBISyk8iVLbk6s7isw+z2/FCAbm6+7xC6SY7A0ewqbumbWNCnrMvQ JvoYHnJPaW24kXfuzDH1Bf5hTs7vltWdDTSNGyk4Zu95zdXgZABR4i35RRK6rtRrpo0Z YwN0jQ6/cuWW8gL1gifIpgFs7ARDBFaISO7ndeSJC46aYexrRwhlt0LHHikRMoDzCusi ElJwvIkyD2ub4iEtAzRa1ttQttyYojZm+oz1kwydk1kuM3CALwpPEkex4KlbdHVaSWuH 56JDKXoJKHHwscrKrZwptmos84T2OMkUhyLxAUgm9shR12+SzJ8d41/yDxrlluoexxkm iaaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/gSRFTkaEkbR97ZxT3k+xBfRgzno3qG9xfy82tbgR4=; b=x5IkIonnvJNKuVdWyr/Tge7mu0Re9OuPGo8cw91jut2n1tF+aCfvTW3mmYRdeUAzOM iRxKS+V5zPuShQwkvekuikQB5FIoaPOPwbwoq57vkr8f4Vvp/kGoar/wqIO+7eTLuiwB lg+oDi0XwW54h+CFcIDmiLnEbronSQAhy/Yb/R5iMiIzB1ro0WXrKlcPvZqbR1VzcSYi k4Lt21y6Pqb/Nrebn7dU+xIdbuFjXTsjuNAvWPpph38SnDBimJlVesPapT434a5ilPyZ pFhsFX9G2BuJ1wp4m2rkGQVqxHpLZPQM4VEwzQIjzJ3NbrABDNVVI7TEgGnH7NiPikbz hGHw== X-Gm-Message-State: AO0yUKWo1nCl8eaxba9dXtLt6OizDV0xHkxenwPhF4xrUrK1ecnyjVpi tfQi1TXoGzllsBfEGxKAHVlT+XjLbFc= X-Google-Smtp-Source: AK7set9qr9ZwCV993coDibwSZiYqqCn2yTQnL7BMb3eCLn+q32l0dNLfCPvrA7NMVssXL087GeITSg== X-Received: by 2002:a19:700d:0:b0:4dc:554b:d27e with SMTP id h13-20020a19700d000000b004dc554bd27emr5013319lfc.65.1677251202580; Fri, 24 Feb 2023 07:06:42 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v1 2/3] xen/riscv: setup initial pagetables Date: Fri, 24 Feb 2023 17:06:34 +0200 Message-Id: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Calculate load and linker linker image addresses and setup initial pagetables. Signed-off-by: Oleksii Kurochko --- xen/arch/riscv/setup.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index b7cd438a1d..f69bc278bb 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,9 +1,11 @@ #include #include #include +#include #include #include +#include #include /* Xen stack for bringing up the first CPU. */ @@ -43,6 +45,11 @@ static void __init disable_fpu(void) void __init noreturn start_xen(void) { + unsigned long load_start = (unsigned long)start; + unsigned long load_end = load_start + (unsigned long)(_end - _start); + unsigned long linker_start = (unsigned long)_start; + unsigned long linker_end = (unsigned long)_end; + /* * The following things are passed by bootloader: * a0 -> hart_id @@ -65,6 +72,10 @@ void __init noreturn start_xen(void) test_macros_from_bug_h(); + setup_initial_pagetables(load_start, load_end, linker_start, linker_end); + + early_printk("MMU has been enabled\n"); + for ( ;; ) asm volatile ("wfi"); -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:06:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:06:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501140.772776 (Exim 4.92) (envelope-from ) id 1pVZeo-0007BP-4l; Fri, 24 Feb 2023 15:06:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501140.772776; Fri, 24 Feb 2023 15:06:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZeo-0007BI-1j; Fri, 24 Feb 2023 15:06:46 +0000 Received: by outflank-mailman (input) for mailman id 501140; Fri, 24 Feb 2023 15:06:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZem-0006Ou-Ll for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:06:44 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9c83172-b454-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:06:44 +0100 (CET) Received: by mail-lj1-x22e.google.com with SMTP id y14so7341641ljq.4 for ; Fri, 24 Feb 2023 07:06:44 -0800 (PST) Received: from 34-6F-24-FC-D2-65.. (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id d23-20020ac25457000000b004d863fa8681sm1492443lfn.173.2023.02.24.07.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:06:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9c83172-b454-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AWdB+WhVKhbKIc4Ieg60li/sx7jyPhuZ3hOGCvSZofI=; b=i3735LWE9VNOsxiDAfi7bdl1+CjDSmrUFuH9jCeC/+mmv5RwMtAr3zp6GiElGraKmr C8d8D31tKEujTdEC2XU5xthFrqRktVGEQMw7hMBkk38hsjdzxuyTVlW7+prsoqLAmAdw 0DbOdlkGvYQgZEWJH7nMwRXm8ZrE5BFvAXAbQ1tZGWzDSNisS1T5NwJbcdRplWGpjBuA +9S30q5f2VhqjsWf8zVZt8HZB0OtNE7mJMq79nEs67GvfOS5anmI17B0Z88OtcqHA5Vl ZXxy+jYRc2FfnrQRiGQPwtkBXUcCDpCCmN9qI4bQU2vny/LaBA2uHZjSLMpBXD+LHHDE YjdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AWdB+WhVKhbKIc4Ieg60li/sx7jyPhuZ3hOGCvSZofI=; b=d/gcpQcuuzmk86aMBd/ssJYLgxIx2h6kcUYywCDfLwYMsZA26qc3EFkpOwz0VkVbr6 f/f/QZEUoxmMir8HkiiFhPj6GKmxdTBGE/DdLVxQIBpdmHaHR3lAM5qoUjPEK5SzTBRC XsWBK8vwbPKu36nQpWIhuVXqK0w9NEMMgNzWkjL4pnldB9Co7JxppQU63+bpn3f7HKhd mSIUi3GQd1pSqjtf/ob6KqrHAibd8w/gyTJ6IcIixI88w7bKgYVoYF1kMyQUUwU2yw6P AhIZmwBokDGMgNq9ycyx3o1j5+Gq/kELG3mu/95OFMXJ2EwMPgJeiA95w6U6hmBWqHaj mFQw== X-Gm-Message-State: AO0yUKXHI+dQHkoq9CGeyGaO15JqS0twPRG0pM8eJaiJpp+Ybo0qURCi j6i8Jo+aIQFXX7PYL0usgQyQ/I7kSMI= X-Google-Smtp-Source: AK7set8iTORSXQRVgsqy08wdFvBsYysGaVjpQnbN6EJsnRPi7bOszKhjVPpe7vkNSMR1CAiv7PFbag== X-Received: by 2002:a2e:a4a1:0:b0:294:694f:54 with SMTP id g1-20020a2ea4a1000000b00294694f0054mr5981834ljm.0.1677251203837; Fri, 24 Feb 2023 07:06:43 -0800 (PST) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Oleksii Kurochko , Doug Goldstein Subject: [PATCH v1 3/3] automation: update RISC-V smoke test Date: Fri, 24 Feb 2023 17:06:35 +0200 Message-Id: <38ddf88eabd9cc36c332d6a27c6ee1242d33df19.1677250203.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The smoke test was updated to verify that MMU has been enabled. Signed-off-by: Oleksii Kurochko --- automation/scripts/qemu-smoke-riscv64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh index 02fc66be03..01cd08e407 100755 --- a/automation/scripts/qemu-smoke-riscv64.sh +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -16,5 +16,5 @@ qemu-system-riscv64 \ |& tee smoke.serial set -e -(grep -q "WARN is most likely working" smoke.serial) || exit 1 +(grep -q "MMU has been enabled" smoke.serial) || exit 1 exit 0 -- 2.39.0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:08:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:08:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501164.772786 (Exim 4.92) (envelope-from ) id 1pVZgd-0000D1-Lg; Fri, 24 Feb 2023 15:08:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501164.772786; Fri, 24 Feb 2023 15:08:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZgd-0000Cu-Ip; Fri, 24 Feb 2023 15:08:39 +0000 Received: by outflank-mailman (input) for mailman id 501164; Fri, 24 Feb 2023 15:08:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZgc-0000Cn-LV for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:08:38 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2085.outbound.protection.outlook.com [40.107.13.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c738981-b455-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:08:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8363.eurprd04.prod.outlook.com (2603:10a6:10:24b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 15:08:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 15:08:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c738981-b455-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RU9FAJZ68e2IE12rXyBC8zxNnhngK6plEM+sJstrfHKozC1XLFTb/pPH97OmpiqAQO/goBfDUzZAdWow+Z4/SQ9h4FcsFbkHrkCcReprXak/SX/eqAiWHl9K8zZIXHM1n/SHlsHEBC9jHMqsrL9i/M1MPl2dz4K9zfz5oLdEpSahAgjkxtDI+owK3pz0TY+jV8HnlMM2FXvK7iZYlxPfbObbXp3BZ88fDngeOV/O5Aeb087cbz+LTSQBgZ6Yw/FZRXBgFr3jwG7nb7jtKPA99icNhvGvnkCVEiDQBkY1i8oJOL8BvwVx68d8sdSion/pVKU8xzl143lj04kTpAeDjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FU9S0wQ4o14Fb66xxfXuPOpqsc3+yhLf5uCXSDFQ20=; b=nV6dPr0Ut9oehNuswKvOgPxXEl8Wmul+Ad2t4g+Q3z1gH2JPnnwl+2H6pJIFra1EmaKJ24rNjS8MapUIyz/stFJQx+sbnHqDPhr65Lrg3hfyKizd70frfNo0BrKpxNfcm6VwZcN4s7OvpIMPJOT2GFoRDTHjEzU44IzQO8vZxyYaTRK0M3wUuSrHuA/7ltYNYl/3idXXA9/vpJ80cO5BR+K5HlNPss3r9aI4t5Q6oyM3Ww20TSasTObt1+g12NckM1lokQT0JS69dpwWJbT9c207loSL87T7AMDc8nI/Di9j1u+Ptz5i/U8NStoB1ieBkwzgEXF90aL3UVa6t23tPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FU9S0wQ4o14Fb66xxfXuPOpqsc3+yhLf5uCXSDFQ20=; b=E9S9+kWvtTRFIMzYMj8jf1BpvxY3swYkfWci59fLhWmHNIairO/NA3+CKZNBpzyarFtNVWWtA1rcR4hkvSByR1GVJOcjP9t370W6E3Ju3jGMCKEf8zgEVAJZ/yyQCqTOrFiZ1YscYi+mVB0R+kj0zTBIlukYCaidjEHgpFNUGRvLuxcuO4S/QYscJBJNECw4ptcfDbNBVsH3toct0aHkQ+UsxcksNCmKBuKoPSaWm7WHGUhNs7BNBEBPFRQWmks9uKxxV1v5E2FXMXcURlB6ake5ffv3j8MVo1LwHlxfJj8WBTJdMjDizxHmD9LWsvbfFCkm6DhraYqqJPa1kgEnxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f825ae6-a325-eb5d-f7df-f598fb22b27e@suse.com> Date: Fri, 24 Feb 2023 16:08:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: disable fpu Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <63c797ba52f6d7edc64f9d2e41b460c7d64330ae.1677249707.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <63c797ba52f6d7edc64f9d2e41b460c7d64330ae.1677249707.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8363:EE_ X-MS-Office365-Filtering-Correlation-Id: 1215bdd8-c949-4d6f-9986-08db1678ef16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZP01rTlku7ysfOV2WFAfexiQOJQ/GkQlsl1zj/cy3dFna2gzNq6FeqkGMjpopG2D4OehrvO3P+VS00DK81zHq5rCrPD6M4/DzLXzukeMvtSqgcqF527sNPq4n6o4lovyJmNYKCCxVvRchVqvxzPFBZnBXfnonvLNdRFzOATncgdQ+caLuRDEP1EIxg5c3etIMJ90XRzVIdqpczu0hFVhcC6JCYC1vkoHhU3APxSGAL2MESdIR+iQly6oJXfZDdVFvERU3xZvFVIhQ/cd9a/i/6WBKLznm7W+09Xyj7Z4YLmeCyjYgH7UNK3QpGd/194DuIGkVoDkke8Nm5xknwuF9HxnFsrEcRbSs0vwKZr3oRSBMe9A5uplk7WhS3o8aFaTeaNqi+qlW+aHknuLsb38U4+bnOrbyVN+EigEMqvE6zWNN+R9+TmrZPWxhFqrbkWMp1j4NRlseeXovJYzoj4zPoU3gNXKvFN7WpGB37gPfXeurQ2m1W0FiPyXBGSdwTNHscbOUFzBu8CDALQvyvKjF6jj4yo9n9lbVc3GB60TfIKBRa3L1qDjvR/IPwULgyEvhoesTypCQgFrjGjFpF82glQ3MU3ErbRcLlEzCdQo1fRie5Rpdc+zC6pdu+5DoSgl8afvv63V/sTEEy+0A8VCrcjcdyGfNXkzWrkwh9MEHaZB+bt/LJ5XP2lpjX0leIhy43SOsjV4amS5wUMW9d5E8VxBGQPFS15BzNJqwLyLOzQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199018)(26005)(6512007)(6506007)(186003)(53546011)(36756003)(41300700001)(2906002)(38100700002)(66556008)(66476007)(4326008)(4744005)(8676002)(6916009)(5660300002)(8936002)(2616005)(478600001)(66946007)(86362001)(54906003)(316002)(83380400001)(31696002)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHBWZkpiZ1VoMEN0c1pWOG81SmFoTzFDU2pFY3hqVnF3NE8xdHg4eHJzV2hu?= =?utf-8?B?RFErU1ozVFViMVlnMkE4UDlOUzc2ZGYyaEtXWHpoNk9TR1JsdUhwdmpIditR?= =?utf-8?B?YXA4Tm96eUZSbVdrWWJydUVUY25KcGdzOWtxWitEbmhCRnB6K1dpOFJyZ0JK?= =?utf-8?B?bDhtNjBsN2tPOW5uRDBhSmhXd0lLUEJ3dWhYUEZ1VDIyUzBmWW1SYWR4UjJT?= =?utf-8?B?dVl6dEsxWnpJRDhSQmFMTmJ5T2ZCTFB4V3pYN1UvWUR2RkM0dUgxbG5xc3Rw?= =?utf-8?B?N0hHRVFuMUdkdjlKTWVNOVQwQXN6eEZjazhEWnJDOE5STEQzUmhJUVRBallO?= =?utf-8?B?YXRoYm1aR1pTUFdlbytjeWIzMEhwY2NRdTdHbUtaWmVYY290TnlDd1I0YXF3?= =?utf-8?B?RWxybDZxMWV2SzFlYVJndUdPM205Z2s2SjVTNTVZN2pXY0FZUkNMaXU2QU95?= =?utf-8?B?eDZxbGliMDVad1ZqaVRFTm03cXBvRDdUeE4veHBzVS9MWXoyaEhXRm53S2NE?= =?utf-8?B?THlCamh1SDROU0FzREEvMXlpMzZDMXVYZjVxdTFPY1Rkb2w3SU4vOVdzeHRH?= =?utf-8?B?VHEzdno4K3BjN01BcXRLd2JQZjVyUkVTZkprY2JXYndyWVdBVEQ0NUxtSVE5?= =?utf-8?B?OVJEQjcxb01QSU03QlczVVRWTEZ5YjRMc1lUYlhuVjNYZytpdHhCbTNsakY0?= =?utf-8?B?ZGF3OHVRMVVyenRHWUxQTXpZR0hDcmczV21ib2xnYndqNkxGRUpOTEx5ajFN?= =?utf-8?B?TnJQZVZyUEI5RlVFa2xYNkRVdW1qQUtncnFBRGJnVnViSW5IYTZIcis0Um4v?= =?utf-8?B?MXJXSEVuczlJN3QwRzcrTUJ3OG5iU2l4aThHYzlTdXp6NUY2NSsxa2pHNEYy?= =?utf-8?B?dlFlNWhZS0E2SCtLL29TRHdJQWlQT25wL3dDSXlUTFV3cVBBNXdJTHNROFhM?= =?utf-8?B?ZVZPL1cxa0dhbWRWcGVrRUNpaThEdDA2OTYxOWgzMWw2SlhaK21JQWtoZ04x?= =?utf-8?B?OUtLWDJJTDF6dGgveGsrK1cwWi9YakZnQVRUbDZtbjdJL29zbWJpZTM2QmJj?= =?utf-8?B?UFM0ZnVWMDJ6UW1ja1hxTzBxNXF0Mkt2cTRHcGVHdFBIbi9ndVJLVUpZeXQ5?= =?utf-8?B?TE4rVGthR3JTdzV3TTFpei8wWEg1TGI3UHFuVWZpRFBqWFRjOWs2R1lSNWEx?= =?utf-8?B?QTQwbzA5d0pCVnJoL2lMOURLWFYyNldnN0R0N3k3RmxnZ2kvUWZrTFVraHNq?= =?utf-8?B?bktuQnRocklmSXc4b1dQZGRKeTM2QVhoVU90b043dzVEUGJkV0xFUnYrWnd0?= =?utf-8?B?UnY0M2J4cmJWbWJML0F4WWdMT0dJclE2RzhWcmFObVFYU0NOQ0tZZFN3SFpD?= =?utf-8?B?NnV4VDVTV2ppTHBBTklJS3JCeVRUc3FXM2tMRFZSVDlHTHFzZ0F4Um9PM1o3?= =?utf-8?B?V3U3UnZoQVJMYlhnNDQ5cDdMNHdKbFZDb0E0WDdhVjFGQmpjUXY2QWFTSjJY?= =?utf-8?B?a3BWc0pLVTAzd2FOc1ZhcXRwdVp2djZTUlk3WkJOY2hpa2F4UHZTVFJUWUFr?= =?utf-8?B?TFBxU3MvOXBoU3F3WmpRbE01L2UxWUhRY3h3SFYxS1B0MXZiVFZTRWZ4UndS?= =?utf-8?B?YUVGQnRVNGR1dWt1OURnZzJNOE5IWWN1UHZpOU5oWXo2eGZLVXc4QStQaENT?= =?utf-8?B?Y2ZjY0dHc0tJN0QrSklUOVRQZUY4eTFVWlBwQlR3em9FK2ljcmxqejZIWXZ6?= =?utf-8?B?R215ZVpJby9xR3JtT2VuTlYvcjRjTUJGT2tuVHpqZEFNaE04WXZFcDcza3VC?= =?utf-8?B?eU9aRVpwNzFWNE9qd0xjSTJiR3JBUDFjNjF5aWdqTU9heWpwVE9HeTFlN05Z?= =?utf-8?B?ZVkzWmc0ZFB0d1MzZlQzbWppbVp6bDdWa25GeE9QZDlsdmRWS3plUFV4Z0Va?= =?utf-8?B?TEJUNWw5YThyY2V3ZEVwYWtJOTB6akZ3MDlGWCsrNGFYQUh0OHFWNll0VWNn?= =?utf-8?B?QzF3dCtCcGtjeFVjdWtEUW5qeCt3bU42L1JlSVNRUVBXeGUvd2xiemVFekZz?= =?utf-8?B?RGRlUlVlOC9nY00wdXVncVIwaGpoMDFxQ3BoL2tNUXRsR2JMMTM0UFNyUTNZ?= =?utf-8?Q?IdCHBfwCDlSGN8lWL/LIorTTX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1215bdd8-c949-4d6f-9986-08db1678ef16 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:08:06.8366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ap1RNjAWYiqSBgf7drbixAbtIfCMRk/3cRk8tepPoRN4ZT0Gph9H5Ck8AqysBrjZibMrQA0qCQ0cUydJ8pCY9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8363 On 24.02.2023 15:48, Oleksii Kurochko wrote: > Disable FPU to detect illegal usage of floating point in kernel > space. > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/setup.c | 7 +++++++ > 1 file changed, 7 insertions(+) This looks to contextually depend on earlier individually sent patches. When there are dependencies, preferably group the patches in a series, or if not at the very least call out the dependency in the post-commit- message area, for committers to be aware. Jan > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -36,6 +36,11 @@ static void __init init_bss(void) > } > } > > +static void __init disable_fpu(void) > +{ > + csr_write(CSR_SSTATUS, SSTATUS_FS); > +} > + > void __init noreturn start_xen(void) > { > /* > @@ -52,6 +57,8 @@ void __init noreturn start_xen(void) > > init_bss(); > > + disable_fpu(); > + > early_printk("Hello from C env\n"); > > trap_init(); From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:15:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501175.772796 (Exim 4.92) (envelope-from ) id 1pVZn9-0002At-CI; Fri, 24 Feb 2023 15:15:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501175.772796; Fri, 24 Feb 2023 15:15:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZn9-0002Am-96; Fri, 24 Feb 2023 15:15:23 +0000 Received: by outflank-mailman (input) for mailman id 501175; Fri, 24 Feb 2023 15:15:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZn7-0002Ag-L8 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:15:21 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cc4b6c3-b456-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:15:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0283D38DE1; Fri, 24 Feb 2023 15:15:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB64E13A3A; Fri, 24 Feb 2023 15:15:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wNywM4bU+GMWCAAAMHmgww (envelope-from ); Fri, 24 Feb 2023 15:15:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cc4b6c3-b456-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677251719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1bQ/CxViv3aWP77kUXOw/4pjF/p+w4XUm/zF0keRF30=; b=k1RMqS6VJ9/B87lhjjgaWBhVeuwH9TW65Qdg2JXmrP3XusgXWRvvEVC1zP/0HgGLp7rt1m ma0TmcIIsxBqxLBTSyaio80nqzilEH4HppX622zGOfCggheCASQadMiHgKlpIK8cat4hUw QFOCOpcWGNahgmajd3frxwoxyrsVLnY= Message-ID: Date: Fri, 24 Feb 2023 16:15:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Julien Grall Cc: "xen-devel@lists.xenproject.org" References: From: Juergen Gross Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Ra079v0Xoq3Pa13SfHcCv53G" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Ra079v0Xoq3Pa13SfHcCv53G Content-Type: multipart/mixed; boundary="------------o64r1bgRmU6itW00wNOujzft"; protected-headers="v1" From: Juergen Gross To: Julien Grall Cc: "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction References: In-Reply-To: --------------o64r1bgRmU6itW00wNOujzft Content-Type: multipart/mixed; boundary="------------PfiXV67MUQDclwL0BRMKQ09t" --------------PfiXV67MUQDclwL0BRMKQ09t Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDIuMjMgMTY6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IEZvciBzb21lIGludGVybmFsIHB1cnBvc2UsIEkgbmVlZCB0byB3cml0ZSBhIHNj cmlwdCB0aGF0IHdvdWxkIGRvIHRoZSBmb2xsb3dpbmc6DQo+IA0KPiAgwqAgMSkgU3RhcnQg YSB0cmFuc2FjdGlvbg0KPiAgwqAgMikgQ2FsbCBHRVRfUEVSTVMNCj4gIMKgIDMpIENhbGwg U0VUX1BFUk1TIHdpdGggdGhlIHBlcm1pc3Npb24ganVzdCByZXRyaWV2ZWQNCj4gIMKgIDQp IENvbW1pdCB0aGUgdHJhbnNhY3Rpb24NCj4gDQo+IChEb24ndCBhc2sgd2h5IDopKQ0KPiAN Cj4gVGhpcyB3YXMgZXhlY3V0ZWQgZnJvbSBkb20wIG9uIGV2ZXJ5IG5vZGVzLiBJbiBzb21l IGNhc2VzLCB3ZSBub3RpY2VkIHRoYXQgNCkgDQo+IHdvdWxkIHJldHVybiAtRU5PU1BDLg0K PiANCj4gV2hlbiBkaWdnaW5nIHRocm91Z2ggdGhlIGNvZGUsIGl0IGxvb2tzIGxpa2UgdGhp cyBpcyBiZWNhdXNlIA0KPiB0cmFuc2FjdGlvbl9maXhfZG9tYWlucygpIChub3cgY2FsbGVk IGFjY19maXhfZG9tYWlucygpKSB3aWxsIGNoZWNrIHRoYXQgdGhlIA0KPiBxdW90YSBpcyBj b3JyZWN0Lg0KPiANCj4gVGhlIGRvbWFpbiBpcyBxdWVzdGlvbiB3ZXJlIG92ZXIgaXRzIGxp bWl0LCBidXQgZ2l2ZW4gdGhpcyBpcyBjYWxsZWQgYnkgZG9tMCwgSSANCj4gd291bGQgaGF2 ZSBleHBlY3RlZCB0aGF0IGl0IHNob3VsZCBub3QgbmV2ZXIgcmV0dXJuIC1FTk9TUEMgKG5v dGUgdGhhdCBhIA0KPiBTRVRfUEVSTVMgb3V0c2lkZSBvZiBhIHRyYW5zYWN0aW9uIHdvdWxk IHdvcmssIGJ1dCB0aGlzIGNhbid0IGJlIHVzZWQgb3VyIGNhc2UpLg0KPiANCj4gRnVydGhl cm1vcmUsIHRoZSB0cmFuc2FjdGlvbiBpcyBub3QgY2hhbmdpbmcgYW55IGFjY291bnRpbmcu IFNvIEkgZmluZCBhIGJpdCANCj4gc3RyYW5nZSB0aGF0IHdlIHdvdWxkIHByZXZlbnQgaXQg ZXZlbiBpZiB0aGlzIHdhcyBydW4gZnJvbSBhbiB1bnByaXZpbGVnZWQgZG9tYWluLg0KDQpZ b3UgYXJlIHJpZ2h0LiBJdCBzaG91bGQgb25seSBiZSByZWplY3RlZCBpZiBub2RlcyBhcmUg YWRkZWQgaW4gdGhlIHRyYW5zYWN0aW9uLg0KDQo+IA0KPiBEbyB5b3Uga25vdyBpZiB0aGlz IGlzc3VlcyB3b3VsZCBiZSBmaXhlZCBieSB5b3VyIGN1cnJlbnQgcmV3b3JrPw0KDQpJIGRv bid0IHRoaW5rIHNvLg0KDQo+IA0KPiBJZiBub3QsIHRoZW4gSSB0aGluayB3ZSBhdCBsZWFz dCB3YW50IHRvIHNraXAgdGhlIHF1b3RhIGNoZWNrIGlmIHRoZSBkb21haW4gaXMgDQo+IHBy aXZpbGVnZWQuDQoNCkknbGwgYWRkIHNvbWV0aGluZyB0byBjaGVjayBxdW90YSBvbmx5IGZv ciB1bnByaXZpbGVnZWQgZG9tYWlucyBBTkQgb25seSBpZg0Kbm9kZXMgaGF2ZSBiZWVuIGFk ZGVkIGluIHRoZSB0cmFuc2FjdGlvbi4NCg0KPiANCj4gRm9yIG5vbi1wcml2aWxlZ2VkIGRv bWFpbiwgSSBhbSBub3QgZW50aXJlbHkgc3VyZSB3aGF0IHRvIGRvLiBJIHdhcyBvcmlnaW5h bGx5IA0KPiB0aGlua2luZyB0byBjaGVjayBpZiBjZC0+bmJlbnRyeSBpcyAwIGFuZCB0aGVu IHNraXAgdGhlIHF1b3RhIGNoZWNrLiBCdXQgdGhpcyANCj4gd291bGQgYWxsb3cgYSBkb21h aW4gdG8gcmVtb3ZlIGEgbm9kZSBhbmQgdGhlbiByZXBsYWNlIGJ5IGEgbmV3IG9uZSAoSSB0 aGluayB3ZSANCj4gc3RpbGwgd2FudCB0byBmb3JiaWQgdGhhdCkuDQoNCkNvcnJlY3QuIE5v ZGUgY3JlYXRpb24gaXMgdGhlIHRyaWdnZXIgd2Ugd2FudC4NCg0KQlRXLCBjdXJyZW50IGNv ZGUgaXMgcmVhbGx5IGJhZCwgYXMgaXQgd291bGQgZXZlbiByZWplY3QgcmVtb3ZpbmcgYSBu b2RlDQppbiBhIHRyYW5zYWN0aW9uIGZvciBhIGRvbWFpbiBiZWluZyBhYm92ZSBxdW90YSBh ZnRlciB0aGF0IHJlbW92ZS4NCg0KDQpKdWVyZ2VuDQo= --------------PfiXV67MUQDclwL0BRMKQ09t Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------PfiXV67MUQDclwL0BRMKQ09t-- --------------o64r1bgRmU6itW00wNOujzft-- --------------Ra079v0Xoq3Pa13SfHcCv53G Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP41IYFAwAAAAAACgkQsN6d1ii/Ey/o vAgAjR2llR/WfKOWdCYhWNH/ILsSdsQdhfrfs3vs/EQEYxW+suxn+zQz0p8TjWUSwQQAHhv4/L3n nphehZIVd80hteb+2EIQciqXBlNLzs5Y1MBljdC6EQHlH5JSdIwx01zLlTZnFW7MsxW2P/w2VEme TQPyg16vvzjGA4dfJ0W09P+HwB0bdmm4kSrDjr7dCtaC7JzuKdx5umvtDp8se283xEylLmcBBej4 bdZLyDUiOWqChebePn2GPTV8HKB785ojJgtfmX9wfZsTuwA2Z5RTbvQg4rCFNZK0k/TLLpHbe3rR NOAJ19EVboHPcBMUVz6LCVLDMrcOwNRsqS2JSo+yKQ== =NIOp -----END PGP SIGNATURE----- --------------Ra079v0Xoq3Pa13SfHcCv53G-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:19:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:19:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501180.772806 (Exim 4.92) (envelope-from ) id 1pVZr9-0002qp-TY; Fri, 24 Feb 2023 15:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501180.772806; Fri, 24 Feb 2023 15:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZr9-0002qi-Qk; Fri, 24 Feb 2023 15:19:31 +0000 Received: by outflank-mailman (input) for mailman id 501180; Fri, 24 Feb 2023 15:19:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZr8-0002qc-Ms for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:19:30 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a21e9a3b-b456-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:19:29 +0100 (CET) Received: by mail-lf1-x130.google.com with SMTP id g17so5598386lfv.4 for ; Fri, 24 Feb 2023 07:19:29 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id p12-20020a19f00c000000b004d37d647637sm1659755lfc.64.2023.02.24.07.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:19:28 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a21e9a3b-b456-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=uTp/HMRYAQd1DwVBw1+20SdFpWuT2ZnHUkCVqPOj3B4=; b=S8m4uFt0gyNcYBN7JKaAwKnagPYIpKWWi954ckZj2AQJEr3BcFQMYCvdQATKL8oYkc dB1/RScK+SaT1afmX3OGkYLERAXGiidUJ5hCezkWFJl3eRx5XR8M25yTj0t7bUf0mWA2 78KZumpwug3A9oeIXaINTS/ufpCh/mXHKhZzJCG7f+erdtj0WHjGXiDcvhWJVk6jBUPD WTj67PT3hEG2+FysoIXnj+R7w9mK98F13VALQfAKVZ14dEWXlc5mHFIC2Z+FEV+PatpD 5Ewg8roZHNNjYYClkBGDfYg5q5PP+8PDwMfXn+e7xAuJSW+NGCuIUy4/ld18B+2vgdY1 Wxhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uTp/HMRYAQd1DwVBw1+20SdFpWuT2ZnHUkCVqPOj3B4=; b=2qUNKJ2ejLMgoNKS64kPo0gEbC4WHAGe8+Cg/TOH0JPZmRU1pR1O2Hwaf9Hp0oGIVO k40zK8HHh5yRMRglAFXlCTXqtNY07Gj2IpCfDDyitAtUpJe/k+ROHe23GhbqsT+HJJ/K bpBxDSD4MT/g1WPVhpD92KxTkTnUUsbSxQ0MwboIJLy/n3572aJ8S8gcj5ujaJXtFSZH BHxfgc2esWjBhw7s2eN6srXMZdLfko15Z7Ripk4Zi98MbbL4dCpDxVG6slHELqk+bSOY QHPF4FY/alxCuMh+3M1XGaRiaaBmdEFmp1KscAjIm364dbubVC2hi+r6JFLc6BzymQZu Nmmg== X-Gm-Message-State: AO0yUKVowZBpvwsH7OPlgJK4p8bjuCeGdYsgaVExc7fILFdCx0JhY8zz OgLiRYXLHO6Y5NpjswoB41xloAjIIgU= X-Google-Smtp-Source: AK7set+0V2dO8X2K/e39nRGCviU66TuccHz6SxamHU1cvzMTT013sN4coJoUNdlLi5+1cSEtflQRkg== X-Received: by 2002:a05:6512:3b0d:b0:4da:ffa0:3f21 with SMTP id f13-20020a0565123b0d00b004daffa03f21mr26212lfv.14.1677251969220; Fri, 24 Feb 2023 07:19:29 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 0/3] enable MMU for RISC-V From: Oleksii To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Doug Goldstein Date: Fri, 24 Feb 2023 17:19:26 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-24 at 17:06 +0200, Oleksii Kurochko wrote: > The patch series introduces the following things: > 1. Functionality to build the page tables for Xen that map the > =C2=A0=C2=A0 following: > =C2=A0=C2=A0=C2=A0=C2=A0 * The physical location of Xen (where the bootlo= ader loaded it) > =C2=A0=C2=A0=C2=A0=C2=A0 * The link-time location of Xen (where the linke= r expected Xen's > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 addresses to be. > 2. Load the built page table into the SATP > 3. Enables MMU. > 4. Updates smoke test to grep message which should be printed after > =C2=A0=C2=A0 MMU is enabled. >=20 > Oleksii Kurochko (3): > =C2=A0 xen/riscv: introduce setup_initial_pages > =C2=A0 xen/riscv: setup initial pagetables > =C2=A0 automation: update RISC-V smoke test >=20 > =C2=A0automation/scripts/qemu-smoke-riscv64.sh |=C2=A0=C2=A0 2 +- > =C2=A0xen/arch/riscv/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 = 1 + > =C2=A0xen/arch/riscv/include/asm/mm.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 9 + > =C2=A0xen/arch/riscv/include/asm/page.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 90 +++++++++ > =C2=A0xen/arch/riscv/mm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 223 > +++++++++++++++++++++++ > =C2=A0xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 11 = ++ > =C2=A06 files changed, 335 insertions(+), 1 deletion(-) > =C2=A0create mode 100644 xen/arch/riscv/include/asm/mm.h > =C2=A0create mode 100644 xen/arch/riscv/include/asm/page.h > =C2=A0create mode 100644 xen/arch/riscv/mm.c >=20 I forgot to mention in cover letter that the patch series is based on top of 'introduce generic implementation of macros from bug.h' and 'RISCV basic exception handling implementation' patch series. From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:24:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:24:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501185.772816 (Exim 4.92) (envelope-from ) id 1pVZvb-0004a6-Ff; Fri, 24 Feb 2023 15:24:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501185.772816; Fri, 24 Feb 2023 15:24:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZvb-0004Zz-Cc; Fri, 24 Feb 2023 15:24:07 +0000 Received: by outflank-mailman (input) for mailman id 501185; Fri, 24 Feb 2023 15:24:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZvZ-0004Zt-GP for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:24:05 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43e87c48-b457-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:24:03 +0100 (CET) Received: from mail-dm6nam12lp2175.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 10:23:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6335.namprd03.prod.outlook.com (2603:10b6:510:aa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.20; Fri, 24 Feb 2023 15:23:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 15:23:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43e87c48-b457-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677252243; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=mksvIhVF3yH5ia6s2zcyTH6WWQ0Ay5mhiOyLv/rrGMs=; b=eUWlbLnygpl5m6cxLoal7WO5CRikAlm3VMXCMYTu1+j4Uy3GOIR1q7fN cgDAdi+NLv13liMFK9dkU2pYvCmd8x3L24P6cp5yh2UVxNw5Erdk+SK1f j5tJr60hWsOKV3FZ7YhA3eVA+OES7CR1sHjmzsx8kyrZJrsi4u1+PY4K8 E=; X-IronPort-RemoteIP: 104.47.59.175 X-IronPort-MID: 98335443 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:P5PrpagAN+LnQtGMH9tXDP4xX161+BEKZh0ujC45NGQN5FlHY01je htvX2qOb62ONzf9LtEjadizpEsPupfSnYRrHVRqrS9kFS8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gWCzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRfIQlQUS+ci9uHxYqRa+5h2vUMJfbSadZ3VnFIlVk1DN4AaLWaGeDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEgluGybbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6Re3jraM23Ab7Kmo7VzAnX1CkuqeD20PuWvNzE n4y+gA8sv1nnKCsZpynN/Gim1aDuhMfQNtRVe4n8gaGyqnTywmcD2kACDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vX6GDj2x y2BpQAkhqsUls8N3OOw+lWvqzirrJLYQxU14gjSV2SN4QZwZYrjbIutgXDS6fdbMI+YVB+Pp nECkMmFxP8CBteGkynlaO4KGreu5fqMLjzHqVFqFpglsT+q/haekZt45Th/IAJlN5gCcDqwO kvL41oOudlUIWegarJxb8SpEcM2wKP8FNPjEPfJct5JZZs3fwiClM1zWXOtM6nWuBBEuckC1 V2zKK5A0V5y5Xxb8QeL IronPort-HdrOrdr: A9a23:58G7gaATiXE9VsrlHemo55DYdb4zR+YMi2TDgXoBLSC9E/b5qy nApp8mPHPP4gr5O0tApTnjAsa9qCjnhPtICOAqVN+ftW/d1VdAR7sN0WKN+VHd84KVzJ876U /NGZIOa+EZrDJB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98335443" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Btp6KrTG9pMhsgk+RfqYkUAvH08rVCXeJqOdEnrhOHsLXWN59MKDfP/5Ljnm02FEiDDqRZCURtM99r6vYfuejRrE3r2QTLZlqcYgugbd36jR3vsK+L7gEX9vL6+sn1jG3uIbg0Mt0TXwWQEzprV6L3JDluwpDw2zKtK6lpZiABj5/O1nChv7wOSvtvASL8vN2XD7Usydzt8k3ALg++jufn1yW3c/P1xv2WTUiBoJS5t8A+q0EHoJLLMTgd9wMPAMShbjTk994v0yJ0YtD8ZJc7re+uoPkZWvz8TBrqk//8XUb5PtI5rEoURgas+6Bobq2pfelafZ36RO5uYkTzXWSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t2hCQnm3TZvBvFpIF9lO32P5+ojF4fZG0l5NOWjcCMI=; b=PVD3WhtMaAl1juAWo7gBk1AUKRKv/cL+mORqCmDkDPMEa2VRomSUI1qRSCmx07jK/KGcW1QZQhYxXTqf2TbMaE5NhYgBwpm/5QEYpBO1Ys9NT1n1bWuZcPKAu4/JLPHDSol3NgCfg9kGR4R97wMyqZnCF6lfgBO3dMhpRociQrvjgChSCl3CtcLwJVnwa/ErFDEB+O9QV3Ivbz4UA8+OJqCJJjN711tjv3Bz9jJ85gXaYrAK9wUQeqpmSJ8EJ/c9XzF77GRhgNFJMJXrsb5MTX3vbcUEFpGdstudu7QFc8fUAm2moE1uApQVBUa2y3pgmxpPlgfKkP6+N2UgK59BZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2hCQnm3TZvBvFpIF9lO32P5+ojF4fZG0l5NOWjcCMI=; b=r/QLgIQapnJFZvSSIHOhG7o/+80Tt6pAf13cmIcGhtZVe7xSiaaxyvko8VUfZP8FBJe0M+NMj8ywvgejNpXu6P/GABOlboryy/K8MXQjQBM8TWZ6WrAz7ECchPtWy4k1uEUZCvPkAB09joszoqvpHiJBcYN1e3jGBBPQv1vX6Ho= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 15:23:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Content-Language: en-GB To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0185.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB6335:EE_ X-MS-Office365-Filtering-Correlation-Id: 15c02ac6-ee9c-4ce3-e313-08db167b25cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G7QARIfHLvGFOlCy/fXThUTc3g8Swxo9qDISyvEsORtM8H41DlkJeHwInwlXTr3mRt4CTmA7IWtFOXuvTjoVW4wrY/sAS93OusWYILnSayhScNqipTDbETZjVNO8nUI234flO3A6ue22y+JAUShiIZAUWGAWnyPuMitpQif6gLo/UCGwr0stuwHKuhsP7beufS0escyTUdqFd3d/tKJWgE2YQITo8oc9Cj3tlyNRmFJ4H85AWuqKAUlXjNeZzbeM2ReWpLUabafmlj9jXb7R2D+u7aSx2juNsEw7BqAIDqePS1Jw7w1v4FTAkbhUCSelBB8P+PQD2Fagtehow6cErCFbG6nPWN5Epcckwds6H4L5qhB6k6YfpP7CRiM6rmD+mBIKwJaOvIE8Mx17Vq0qWtXZyKZGLzMLXGEcCuVtMUJPhA+ggv6Q3MxEhckWvvkQ0+TioJkBx7d67utv4wcPb5Bx/HrIt+D5GelLQop/JPRayKsgulgmDFS6SZ8tRtgTIEbnqbzKLNa/e4E4j9hTj1rGA/do7o1HRzViwXOhyR3tMFoeSZ9XV/wPgXlQcXhxkOI4SbVfuWyInEFSf8/aw0tCvLerkyHPRocw1somK2lk5wTkrLMo5IdFoaqR38mKyFdGrRCqY8rWHHf6RjMWFTH5pX34j2V1WiDGs4Pjk2FOsuyEmukjvhu3Ukp2OZUzW/DLn4Yd3II5yliAlNXsDB8daSCQ5KA1DdR1lv/3Yqc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(451199018)(82960400001)(31696002)(38100700002)(31686004)(54906003)(83380400001)(86362001)(2616005)(8936002)(36756003)(4326008)(8676002)(316002)(5660300002)(2906002)(6486002)(478600001)(66946007)(41300700001)(66476007)(66556008)(53546011)(26005)(186003)(6512007)(6666004)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzQvd2NtMjFSZ2NuMDVYZ1pvVEozdEpOSGpBN1orNGNkZndzNWtYc3hydi9o?= =?utf-8?B?Vk1DNDdqTkFpbEorNWxETktCYXhtZnVZS1FLRWdFQWNsWm1tMGdDalV6OHI3?= =?utf-8?B?SDVZL2ErY2RCSVVLVEZRb1g4VjVrc0gzTDJCT2dVUk1YUHJMeXdyWHlIMm5J?= =?utf-8?B?ZUZpMlVrNzk2dHNnR2c4QTZKcTF6dlRtcXBoUS9SaXViVnh2eUlycmNsaHhK?= =?utf-8?B?NkJHVk1yOUJoZElJMk9TTFhKSVBLZDZIN1BGVVAvaDdtZzdkaDhLenBoaGxF?= =?utf-8?B?MzBZR0pKb3UxSVhqdlYzcFdxKzRqSGJXVmpRZTUyMW5NblIzbFZzdnJseFFN?= =?utf-8?B?K0QrZVJTQW9mYXJDWDdNQlNjd2FQUUxGNnpaVjFnSFNEOEZHa28rcUZTMmVY?= =?utf-8?B?UlROT2IxVXFxMzhuYVg2SVk5SC9tYThmWFF3RVVTelRGNmxJM2E4R3p0Vkla?= =?utf-8?B?UkUrcjU1Rk9oV2NUUldzZTBnQzlVWG1JZkNTTXhYeGQwM3ZtZ2oyODhDVG9p?= =?utf-8?B?cFkzVGZlbEJQR0xCK1d5MHBucmZHTlFxWjVFRDBKWStVSkNYYVY2Y3hHVFZq?= =?utf-8?B?MEhyeUU4M1dWNmptck1qb0NnQSt4Q29oVUMwS25mQnlxMVAxclBTbFRCT2lt?= =?utf-8?B?S0prQlJvdmgwZzZ6ekc4M1hYNERiTFRqTkU5bllHUlYvTGVRWFZKNGRHNm9H?= =?utf-8?B?c0dCRlkyRjJsaWppd1RYWWQwUTVUaGVPRTNPM1hmY3JCdGh5MzlCSERwQ3c0?= =?utf-8?B?N29QMFdjYzltMXIwZjZ2Q21HUnBSMkp0OUVkNjd4a1BjNlNNbnZOT2w0ZjVO?= =?utf-8?B?QTZBZGZNNExGcGs1VnpHQ3JhaW9GeDhIT3NMMlFxVXJUTmRuQnBabVdoeEZB?= =?utf-8?B?OWw2d3VlZC9RelFSczJpaVVURUNWQkJaMXVKUWd1WklZR2U0UlVteCtjbkJ1?= =?utf-8?B?MjVIS1FIbHJHT0NHU1hvNitNL2lKSzdqa2l2Ry9KdUkwMHJndm53d2o2UHFU?= =?utf-8?B?TElwYlBIbUhWWUluQVhwd0g3VVJ2dExRS1VlazZUWWpIQ3gvOUl0K3ZpaDgz?= =?utf-8?B?WjVCVEtnVVB5dndaMjJrYmI5SThXa0l1eEl3ZGVjYUYxVWt4ZGpjeW92aU1H?= =?utf-8?B?Y0hZTCtsbFZKNk9VMTRUd0xiL1YwOHE4VWlWY3FIa0JxVUlJTm0vTlZEWnd4?= =?utf-8?B?dXFuNGdxbUxmUTFqelp1YXJUQ0JDTVpiYld2Tkwrc0JHMncxeldQNEdWeG5O?= =?utf-8?B?ZGkvNFVRZklMNkpZNFk4N1VVVk1aQU9CRTRZVXU3NGJuZElhYzBoV3IxZHdE?= =?utf-8?B?d1BWNnNPUk5HTDRaNEV6YXZlZXovTGZRNXpkN2M0VEVrZjJ4cDc4N0RKSTVX?= =?utf-8?B?aFNCeThYenpGdi9KMTUxT0NXWUxCNElNdzhlTGtWY2pQYTAwV2JDVEZ5NG5J?= =?utf-8?B?OU1wdVJxUXJRbjV5dTRBME9OUHg2ZnJETERnRW1ycnVBbFNyOS81S2doU2JR?= =?utf-8?B?TmtFQzVwbXZWczRNR3hWM3dZbXFHbUhCQ0Jla3R3SUhuVXVMc1lJeGJ3TVNM?= =?utf-8?B?ZlRiMTNoU3Vlem1heWw0cTZ5WWl3RXg2MWU1cUNUamZ5WGxKSEdZSFVrRHJT?= =?utf-8?B?RVNKL2ErRzFkNE5PM2o2eFB5UFZXaXphWG5tZjM3eXZ1Q2lNekw5U3JLVWpp?= =?utf-8?B?b2tDM01Zbmgwek8vYS9saDdQYVF0Y3YvQUFnZjNiUFIvOWRuVnpjTVorWmlM?= =?utf-8?B?V0E5SFAwcHJwZHE5b09TTzcwU1cxeW8rbmdvbXEvZ01xMGFvaUVyZ1VzMXFU?= =?utf-8?B?WXNsRU56S1U3eWY1ZktiNnZVZWx6aTk0TjFEcjRLTjR1MENyanVtbnpvZk1E?= =?utf-8?B?SFF6OFc3THhrWEZQK3B6OTZTVU9YNEkwYnR5aGhQM25ZL2wwK0hXakpIQ2JE?= =?utf-8?B?enZOblAxQWsrYkhyQ2p2eEJwK0MzU1FHYWJFc3BiOGk1NzlCcHIzWkQ4WnN1?= =?utf-8?B?Qjd4K3c0NXFYN2VEQlNYQVloV002ZFJFTnB4bE0zWWI0N2ZvaGkzOWlLUGNR?= =?utf-8?B?YUFuSTBCczVTTjhmMTY1Wi90N2RuZCtRTnpJTVNReDJCTWp3ZjE0U1U4THlL?= =?utf-8?B?aDFIeTA5L0JTZlMrck1uT3FlN3FlVS9XZjlxVVN4ekJMc0VJWUFMVG1RTXQv?= =?utf-8?B?R0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: m51bccOLI1sMDGSVCwLrh9/c4X+LRz4bGh9oV5kVyDoKqcV4+v543zK4AVznOoJKGWbM7RNet3dhr9kihUILtPAryk+nbE5KdQSBC1w6ypDCarTS4KaZ6AjpYNneMZQJQOMf0qALTD8Ccd2halDKYa/s5bDKP7FX9hVnbTTwIlyTL/bNFVc/3G49+qb39IR6rK6ocSbuiSd48D7iGe/Nm4NL3D/F/oX2c8oxtIS9nugWCXp3KfggUKc4jSZxd56iao+iLjJEnuOB3ofXtfbAS/+j8BGdnp/1fMJbCt2hf7mOgb6rzlTYQmpPLHQ4EYUYP4m+1wRflZy4hCRFZ0gh92L/IdaiqJYhl77xUQVYyzBDhqSRb7jao5yjmoShThKVP3BobPDoP5yD0maEJx3S+dIGWBaG+X9IKgcEz7UH0y3h6bM+lev9uoVSGcOfDsfmdN3huZqKU7XmfysjYewx5DCPpY/fzxQONB3DIsMf0TiaTKl62Od249q2tUAFviDGyRfGVTcdOGfPTK+Ny/Mh1+aohYDQUwJjpo7ptMKxnGh6BuYXj0zSZW0obsKLbGryiRTYrc4ahu2Hltt7TH91afgSLlIdZ39OzWwC9eyljt91B2lh7G2YcDSlLdKYzPGtGHarkjz3Nq0nN+eawSKbJupnVmvsGaWmuRWxp22HBTppEZpU2dh9E0flg3VxkcujLaZThNyDVwXo/J94lsKiccSszk1TSNUb9sklfbY4/wSGkw2NLqbD8yqAat9JUzY28KbAGQonyEeAp1hcGav/qibkF2+8P6u0YHDBgq+V+mJ0lX9Df8F6vQhVq1Q/gQtHewQ+aZl4Q1nlVdMb4SRgChAa1I3/FQ7ehawmN59Hz4MhPuIN9G68S61qPNma7xdmbJQTVROm8hAxEn1T/rlzRQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15c02ac6-ee9c-4ce3-e313-08db167b25cd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:23:57.6751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IKtHbgUrJEHGfhyI7rYy1gLs+HnYfYOK07DxapRzM6TrUzcvmk+kynjj+gSX8RXRFI4hsxpLOpJAZYoC/7JUooY30MpohiC5F6eGaVi+6dE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6335 On 24/02/2023 3:06 pm, Oleksii Kurochko wrote: > diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h > new file mode 100644 > index 0000000000..fabbe1305f > --- /dev/null > +++ b/xen/arch/riscv/include/asm/page.h > @@ -0,0 +1,90 @@ > +#ifndef _ASM_RISCV_PAGE_H > +#define _ASM_RISCV_PAGE_H > + > +#include > +#include > + > +#define PAGE_ENTRIES 512 > +#define VPN_BITS (9) > +#define VPN_MASK ((unsigned long)((1 << VPN_BITS) - 1)) > + > +#ifdef CONFIG_RISCV_64 > +/* L3 index Bit[47:39] */ > +#define THIRD_SHIFT (39) > +#define THIRD_MASK (VPN_MASK << THIRD_SHIFT) > +/* L2 index Bit[38:30] */ > +#define SECOND_SHIFT (30) > +#define SECOND_MASK (VPN_MASK << SECOND_SHIFT) > +/* L1 index Bit[29:21] */ > +#define FIRST_SHIFT (21) > +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) > +/* L0 index Bit[20:12] */ > +#define ZEROETH_SHIFT (12) > +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) Don't name these with words.  That's an error ultimately inherited from an architectural mistake ARM. These should be named L1 (4k) thru L4 (512T), and don't need separate separate masks or shifts because it looks like RISC-V designed their pagetables in a coherent and uniform way. You'll find the code simplifies substantially if you have PAGETABLE_ORDER 9 somewhere in here. The shift is always (PAGE_ORDER + level * PAGETABLE_ORDER), and it's rare that you need something other than "(addr >> shift) & mask".  About the only time you need a virtual address masked but unshifted is for debugging. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:27:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501192.772825 (Exim 4.92) (envelope-from ) id 1pVZzH-0005FR-3D; Fri, 24 Feb 2023 15:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501192.772825; Fri, 24 Feb 2023 15:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZzH-0005FK-0U; Fri, 24 Feb 2023 15:27:55 +0000 Received: by outflank-mailman (input) for mailman id 501192; Fri, 24 Feb 2023 15:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZzG-0005FE-BS for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:27:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc3f75cd-b457-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:27:51 +0100 (CET) Received: from mail-co1nam11lp2169.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 10:27:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5118.namprd03.prod.outlook.com (2603:10b6:208:1af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 15:27:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 15:27:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc3f75cd-b457-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677252471; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=w72nSpG8huOx7jsZcNfSm8rLlSCP5++qKuhOnPjC29o=; b=h1BM4mCLQxkahBpE67nJrbTg47RKPeJjX0k860kBWlsksWYjKis5Xcq6 6crpRHiYLA7VxWfWo7L4+QzDNzcdxzDiRRWDwTmlvVKB2+MV0+Nq7wpnz po5evOkpDpC+hGV7gS1HdeL5dsqEOGy74DEQDkB4Ti93M1WJOZ3loVPX6 w=; X-IronPort-RemoteIP: 104.47.56.169 X-IronPort-MID: 98335931 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:mXfRPKIu56Mhlg4VFE+RMpQlxSXFcZb7ZxGr2PjKsXjdYENSg2YPy WIcWmCBbvqOZmb2fYtxYNi28RlUup7QnN83SldlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5LOmBO8 KZAGAsmLQu4mN3xw7OxF/Nz05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGNnWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHOgA99DT+TQGvhCoASOxFEJLkIsD0K+sKKVjxOOWdJDA hlBksYphe1onKCxdfH6WxC7u3+F+B0BQd1bE+49wA6Iw6vQpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv5sEaezisD+EBnqw i6Ntyk4jPMYistj/66y51zAjhqnr4LFSQNz7QLSNl9J9St8bY+hIoevsF7S6K8ZKJ7DFwfQ+ n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5dEdM1S Cc/YT9s2aI= IronPort-HdrOrdr: A9a23:UvX3Sq1QUCqQT0GcwvIXmgqjBGokLtp133Aq2lEZdPWaSL3jqy nOpoVl6faQsl0ssR4b6La90cW7MBThHNtOkO0s1NSZLWvbUQmTXfhfBOLZqlWLdxEWtNQtsJ uIGJIOcOEYY2IK9voSIzPXLz/j+ra6GWyT5ds3YhxWID2D7MpbnntE4tLxKDwKeOCOP/tJd6 ah2g== X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98335931" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YUagpEqwUZAGYdui8p86e9sOSXe71re/w3bz6tivHXtv4X3Bjhmchu1WSKe8BXmZO7wnFhn/PeQjnTWJ3MmghL/9Bx3PyEsyRsFtjNw9P9JkzRzjDGYqXBGpu8dS/hJseRCAaR/+5ZS7OnlFz7BhCkyDvP0+ba3OxHban03uMmF9V5xI2xNoWHkV4xG5CIwmGJFMFhP5GM+R+YbyHjd2pk69yI5My+37zR48o1bQ+9216gt3TB9FEWiXyYJ6F2uyN4jgVGAZWqs93QMyaDoXGbDfLe4zBTIThmw7R21s9AlVZJintsQ5lgJMbwgdUKnMd9Y7BEaqMJeMvmuYrSCO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eO5sceEjNml8Su0R3x+JE4rtA4mDswN2OJ0CMgHQOKc=; b=JeqjnFp1ertRtWngwPVPDAdKidNK4Vxzx/pnuHFAEJbKKLQoZkbQcOmn9FbFYTyLGwdg9qbMS5O1KQc+GkEDaQDdUtnNtCdmqX3WIXKMZ06iNRe0qQMlZC2OepCnJeqnGK7j7l6btHJuYoBP/72Xd65MDHuXNuGrsYFCxJED4QBnnXwFAzu8XEscLDyIoBw+7+hFPRUwnbV9HJPj1z2imn2GuhKT4NG90anBmZOeoBP/R9F5EnjKjABlkBq4YVQwDVG5xOMAye1vItI854J9KDjfxr8x4CJH3V7sGNBbtL4T5k+fOgWhUMxB+u8lEmMTJr187ss4LBJkFowgHSjLoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eO5sceEjNml8Su0R3x+JE4rtA4mDswN2OJ0CMgHQOKc=; b=nnSBX+3iZnSgqkPB3QZ9RwDEX6fiGb8F5PHoheNsUNaq+Q7yNm1kKObvi9hR1WsJ/HV4gWoa7wGaZJAdUuFq8WR6LcZvnyo5LJzbjK8/SVFR6FgealiymX8OwpJTZoFK16FnOWfCk6wZnVUQVO1HbbTooroMqCIWl2JPMRBdalQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <88839882-29bc-0de1-ae6f-f47dc1ee3aee@citrix.com> Date: Fri, 24 Feb 2023 15:27:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 3/3] automation: update RISC-V smoke test Content-Language: en-GB To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Gianluca Guida , Doug Goldstein References: <38ddf88eabd9cc36c332d6a27c6ee1242d33df19.1677250203.git.oleksii.kurochko@gmail.com> In-Reply-To: <38ddf88eabd9cc36c332d6a27c6ee1242d33df19.1677250203.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0246.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5118:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c9e249c-cfa2-4e5b-a0ea-08db167badac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9dkvnXFG727lCOpAg6AtEsiREP13yIdBZw3HIGBcT2+J5+hw0EvAyfo1xMjFSfJz9jyzTYRHKVncp55hYYLe3AH8F6Y/qcT/J0E+dd3mn/dMrxjsOcPPxBUbg5oOxh7vYjwaPS11Wzhz2hLlCdgbdEOYNd/Kp+ZMKtxgAI23hx4mBJeL97qEnt4beSvAtVTu48ylEFd7GOCTPvhM2o2YZbzIapusJPz+tfJzz4etHSbkJVoSQE0m4zD2b25CkkR/jDmAVROvVu37jnOKLheJ8p+sHmehftHSi14xA0tnc5cpo2V2Q/m9zhtdwl7DPjtL6BpXR8SuCAAkeccerK1tbmtkcCGZVI5JJcpJCTUPe0aqdIfwGjfNRA5ulUxgET1SH8sIjMk9dwfuSAd69yHQJv4yCWVFBRZ/xx4w2IYYxW23gFoswurkiU/EJgeMYZ5mUwJNW695odQrl5+m5OW7227hFi4nAkBzNSe3z6JR+bG3ip+HdC7maa0PscV4bCrzfiA1YYrALdqe8uFjseALLwh/jimusDxh0J3p4tR+3/i8t0Mq+uXlMRaOtnbrk9U3R1uMAFLXK2MtFUAhgxzq6HOfp6J9LyX3dDM0wGqya/e8btN95wi8soDzV3fwn2NCVhFsChJPWRj+glYjVfBORC5lNvOFqf09lrXp4qyL/1Rtt4sdpsxPXenRI0miiWHEvs7Xj1AfMIQbNmYYNnJWUQA6VlUq8nXa1Pgnt+QFfnw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(451199018)(36756003)(31696002)(86362001)(478600001)(83380400001)(316002)(54906003)(6506007)(6666004)(53546011)(186003)(6512007)(26005)(31686004)(6486002)(2616005)(2906002)(15650500001)(4744005)(38100700002)(82960400001)(41300700001)(8936002)(66556008)(5660300002)(66946007)(66476007)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmF6UWNTMDFOZWlSL3NDQ2FLU3pjYTg4c3hxM3B2MDlJVVo1RjhHcXcyTGJL?= =?utf-8?B?RHkzTWJKM3doOVN5Qk9UR3VYV2dONFZwZS8xM2dqV1NuUDhPd3cxQzdRanFr?= =?utf-8?B?RVNKT2FRSlBLRXFiYW1kdEJDQUJGd2RNRDdObU9mRGZwZkZOSlExZWNSVTV2?= =?utf-8?B?ZThkeVdtZDVOZERkVFI0Wk44SDNCK2dBMTNPdlBwN2NuVEFhVU1JTDhXbnJk?= =?utf-8?B?UEhsRCtzMG5YWUl3aTdsRW15QUpUV0FMTnRON2xid1N6a0JLYnJja25NeHlZ?= =?utf-8?B?U2pjdW11b2pOMGVGUGdxSU9ZNmpGdXNHUHRmNFkxNjRHSHdybUZFVXM5M09G?= =?utf-8?B?eVY4YnQ4eitoZkVvMVZmdExxRzlRQm5kZHNqMEcxMDFlYVNmSzQ5KzRDN01t?= =?utf-8?B?NUw5SHRZcTJxVEV5ZWJ2dFJpVDJ5THZMN3ZZMEFVMXJhWG9EcGN6TkVzWkta?= =?utf-8?B?SFBZd1NlQ1l1RlEvUXZmTGo3RUNOb0xaTmUzT252VXhqNW9WRmgwZVoxeTU3?= =?utf-8?B?T1N4d05HR2NhY3VrVFJ5RldHb1JuenBmTDc0aEd6RHlqN3ZDWElTWVJHZ2d4?= =?utf-8?B?T0Z2L2o0eE5Bc1JBWUNnV0VtV01pbHFJcEQ1b01vRzIvdTI4RWlkUUNpMjdh?= =?utf-8?B?NHdrSXJEZXE0TFk2dkFYTUFTb1VqVko3Y1B2WlFocThrVkRLbTk3OXdOajhu?= =?utf-8?B?Tk0ySUN4YW04SWlJRGJwbmIwSXZubWd0R2hrTmh1NEdNRGtKRlg1Q2xOM1pi?= =?utf-8?B?L1RYOVRPOUdWQ3I4Sm9lRVRzZWJOZWg0cnRBWnlTRC82Vi9jaEN2VHVGaTlC?= =?utf-8?B?NUgzUmlGbVlUS1Q2REVKV0F2RmxmSW85WXRYUjlvdWR4RDJjdWI1bWtrU1R0?= =?utf-8?B?b2lQMjZsektyYTl2SXZRMkFlMG1ZaTBrQ3pwcEdEUHJCekNRd3NVT01INzlo?= =?utf-8?B?R2lFYzFFY0Z4d0pPUGdUOVphQmZUc1M4SjVQUDlLTG1leVlSUmJra2pSNVF3?= =?utf-8?B?RWR4dWlDQ1hyVGY2dnBTMkRxT09nVmthaDFMUDBWZ0VaUlZTZ1NGVi9DUmt5?= =?utf-8?B?OFFMK20xc0p2eHRoUlBwQm9BTW5XZFVPT3RoUzcwUHN1YU9sdHhsRWVEK2V3?= =?utf-8?B?Yi9YWDEwTEdtUkwwM1hoRnl2dEpXZFdnMWZwRllCVWYvVkY4YzdhVy9xYzJr?= =?utf-8?B?K0Q3SXQza2UzOHhTcTdYcU9QZjloLzM0NHZHNFR4YklGTVArUTE3Ukp0T0FF?= =?utf-8?B?ajNOUUhzWmhHdWlvdHBkKzZjdmZzcTZsMnBZWWRPL21ndXo3bTM1MzEyUVdw?= =?utf-8?B?cmdNS3Q3ZkhVa2ZqK081UDYyLzFNRU83WFc4VU0vcDVXZ3R4YjhOQ2Q0UjI1?= =?utf-8?B?SW9jRVV5SU0zNmtxVjRiYUI0U1krdzF4bWxvVnZvem5GdjVTTVV3T3R3bkp5?= =?utf-8?B?SVBFYURkQUNUblAxbE9YbkN1bldCNDRMNlpUTzUxMCtpdWU5aUQrQWtoTTIy?= =?utf-8?B?V1hDeWZ6YnVISENGWHljVWMrcVdPbUVCcjBKWDJxTE85SGdxSTJEa3ZzbEtM?= =?utf-8?B?bENmNFhEc1ozUGpXUUg2bFZqREJ4cnlTRyt4SU5PNXBRN2NRZk8wS2FtU2Fj?= =?utf-8?B?R3FvR1ptOVhBTitpckZsUE9xUHdJZnBrMFE3LzBuNWcrNUpnYTQ1NHdRUkF4?= =?utf-8?B?aHZKM1hMVnd2UTcvZTRyaEFwOGliRVZlbjVvVmZtbi9lUmpyRDQvM3F4dnhL?= =?utf-8?B?dzdYc1g2RTRrZU5jOU9PUDFHNXVPTlQwTWMyOS9PRGRVdmtGenZvZXlRdDF3?= =?utf-8?B?QzZCNVlpTGRMMmh6bG5rcW4xZHZaVmc0aVZJNWRBTmJ1NXIySkM2UVpUblp1?= =?utf-8?B?K0FiQWRManRVS2E3NjUzaXQzSDZGVUFNVHliYS9yYTZ5cUxkTVlKSWVsc3Ji?= =?utf-8?B?L1pQbEJvby9wUDBUblRtMHpXV3QyNG1abTUrVDArTk5BWHA0ZVQvekM0TVlz?= =?utf-8?B?MVZkN0k0U1VlZFVQclptOXhBaVppVHdDR2Fhd1R5UFEyZXd5dUhpaHA4K1Js?= =?utf-8?B?YkwxOUpYcEkzSFNBSXVsbnRxSVVyb2loc2t1TnVHZHVuTzhscHIyRUlPakRz?= =?utf-8?B?bTJzMjZOQVNJZThqWGs0VW1JeDlxZjNxbnBMM2hUNFJYdFFWWC9IdHptbkkz?= =?utf-8?B?NWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TCDyl738H33DditxABzv7QGhxdNyCLOtCrHykUJH5v6eSZiJMsWyVbk+MOalmXyquOSVcq2BdDjEH+3BdwrUaDhJi6Y8zgdsIpNAX5vZQ99xgXtuutJUBmNBi7O+tlKesyt/qQ6QBKqLGEzhfojubamPhdKSQJ6JjZ0mwnz+zfu/18hYvVdjhZ5cImN33H99hZmNgFRtMubl+wOpiEXxXNlnYs9Ep58E7R26/cs4EpAQBiDqrbWqgT9PU54Fn0l4C/iI6tHCrnLhGGQZ3QkdtwMH7J9i/MnFxi3hQhvqloagzmdD/0MV4Zwbj4ZM+Qu7o9GG3ENHGtxVG8ub5u37grpv0mu+cd1jL6N1F72AnbdzgjVkXAbNZlx5IAMvjrGM5Ul5TdQLb9qH3EKqfCagufyohhpEusbduABXlGup4qhFDoVNg4pDEOWhpIC9zZYuq85nhNlrsOt3dxofTYXb9EWtlAjAF1DCZ2z7Cq7eb7pUsCOEfL3ClhaRFN9dkh9j+uhg1Xk9SwbhjIyYc5BBQnEUPKFunXGYhfBumEc2etlYkHkyTqwZGSgYWgFV7tzIZaBNfhCUc/08qpuXpLi2a1DDkzTcgIPfnNuwbBrizUvwif1Li341D3zNSQ84ZpZcBCiZIbqErAVzHI++uRmO6lZS1iYRTC/H9N+lzk0ByvcLIaNoEeK2ocuEQfplMb8o2YwwMCb4z0VJ2B6ayAEtb7pkklHFD+OBcHRDyYCDZxQGXtll4fPlgV0D2QEhtlhss8c9YwL/qCzxdh+Q5NHoWj3j148je1/gOdvgZJtuJ+kSAlsyT3UmnKeTsyCFAWaoJs9Gq6+XTJey3tsPOko/GXPTNMRJBZq8KWzoS/9rrYvJ6kf7wiaFC8LxcxieWVqstQo8EnFrH3DclxYWzEGgSQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9e249c-cfa2-4e5b-a0ea-08db167badac X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:27:45.6117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vt5NEw8FtALWIqpX+Yk6hJ6LcCcrFSPhJQGA1FHDSj5azpfEKCMcoAvmZcvFWNoikZhJC01ItmS9Bj+rWUcJU329m/CKRo66swpWZqYM764= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5118 On 24/02/2023 3:06 pm, Oleksii Kurochko wrote: > The smoke test was updated to verify that MMU has been enabled. > > Signed-off-by: Oleksii Kurochko > --- > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > index 02fc66be03..01cd08e407 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > |& tee smoke.serial > > set -e > -(grep -q "WARN is most likely working" smoke.serial) || exit 1 > +(grep -q "MMU has been enabled" smoke.serial) || exit 1 > exit 0 There's a more simple way than this.  I'll do a patch. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:27:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501193.772836 (Exim 4.92) (envelope-from ) id 1pVZzJ-0005Ui-CH; Fri, 24 Feb 2023 15:27:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501193.772836; Fri, 24 Feb 2023 15:27:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZzJ-0005US-7J; Fri, 24 Feb 2023 15:27:57 +0000 Received: by outflank-mailman (input) for mailman id 501193; Fri, 24 Feb 2023 15:27:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVZzI-0005SZ-6b for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:27:56 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cec64d22-b457-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:27:54 +0100 (CET) Received: from DB6PR0601CA0001.eurprd06.prod.outlook.com (2603:10a6:4:7b::11) by DB9PR08MB8314.eurprd08.prod.outlook.com (2603:10a6:10:3de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 15:27:25 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::6) by DB6PR0601CA0001.outlook.office365.com (2603:10a6:4:7b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21 via Frontend Transport; Fri, 24 Feb 2023 15:27:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.11 via Frontend Transport; Fri, 24 Feb 2023 15:27:24 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 24 Feb 2023 15:27:24 +0000 Received: from 246d866e407e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9C0D851E-1617-4C21-B741-EB388869F6C9.1; Fri, 24 Feb 2023 15:27:14 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 246d866e407e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Feb 2023 15:27:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB9849.eurprd08.prod.outlook.com (2603:10a6:10:462::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 15:27:12 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 15:27:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cec64d22-b457-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sLuA7n4YeEA5pGgCF0/yJiUAM9VSnZKIFtqScOmWx7M=; b=bfn7dqr5t7ld1n3uG/gbkTZ09U0+aW2GtXS/XZYw5K8fBsXCsDbKRUFvVUDu7Ouw1WkjXHqA8M6r9m2w8StJaiCni2bwnnBXqKZLSuMddDgLfYcvzuKI/69ylL27KFV/ZBwjdhyCsKJaa2WN5WFbCjo7S1tuLud+Vfa1akFmmno= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 272b069c31ecc33a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H31qi+I9XJD6mPOnIVqaZvT/RaqovVXTqlw83FBVm7Q/fwznVzXlV5oUGRYOjL9mjAGHYdVoXkFDALUKHoQCs5xe4E+SJEZhoHmkRzLDrwHZImA5LTO7QOcSjBuvdqBYAPvGNNNCjRa0D5GyNrI1j1AXFVGxa7fdASZdFepQKj3FnLAGkcR5gL0E/3y9vowkz/5kV3+itZ6FVNs6LuxahxlMV7oakRqY3F8SH6VR86KIcMo1j9zM0fYNLdvk1N5EPBRbhoYLSFtCugtAKlVLt8JYid+RTPwqxRUF4d95HhfRsShxzdVYSedIVpBzD+LUOu8x9G0/MHXKn9y3gOHfjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sLuA7n4YeEA5pGgCF0/yJiUAM9VSnZKIFtqScOmWx7M=; b=m0+DME/CRTbKBHjyRAFtuWMACP0F8p2nx3JKonv57xCpMG6nhseN+NogUlRwOys8u9tbf5r3xShlqzaoH9q2hO0km7mujuXFA4It0r09Aim8ke8z4QgNS2eLuA6yx1ANSdWl/S9SW0rVYS17IP6rE31ysmkIlMZ5GOmMnfszRBVAry9nn3vaZDheAyQiDJiIP7KvKFDGv/EN/5xMIbwg8V9WD74/xKahfq/p1Cr4CsNaWidhGyUkTuLiWoX8fjfub8y0zojcAAvMg8zhFbP5Xcs5SddGy71EkXMCD6XO128JlY8lu0uGwNmaqv8EBTyli7JxmFBl3ryCdqqmYr9CEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sLuA7n4YeEA5pGgCF0/yJiUAM9VSnZKIFtqScOmWx7M=; b=bfn7dqr5t7ld1n3uG/gbkTZ09U0+aW2GtXS/XZYw5K8fBsXCsDbKRUFvVUDu7Ouw1WkjXHqA8M6r9m2w8StJaiCni2bwnnBXqKZLSuMddDgLfYcvzuKI/69ylL27KFV/ZBwjdhyCsKJaa2WN5WFbCjo7S1tuLud+Vfa1akFmmno= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages Thread-Topic: [XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages Thread-Index: AQHZRtMZN0hUXh0yA0u/TS4KHErP767eOzoA Date: Fri, 24 Feb 2023 15:27:11 +0000 Message-ID: References: <6c0ef5d2174bfa8c25aeb94395160ab9d863b63a.1677079672.git.jens.wiklander@linaro.org> In-Reply-To: <6c0ef5d2174bfa8c25aeb94395160ab9d863b63a.1677079672.git.jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DB9PR08MB9849:EE_|DBAEUR03FT028:EE_|DB9PR08MB8314:EE_ X-MS-Office365-Filtering-Correlation-Id: 1caa8c17-b404-4b9f-af37-08db167ba17f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JY26Jmv3Ja5m8PZEaEjSaI8Gv/wHyjeT4RX80pioA9Vvpw3iUgLedg2WuUHpGD3r/1obhBHa8gvMdoHG8NiW4JNaQcLuqyXSGRHWX1Y6RnzmxnR6xpmsV9UvPfX7ofjVsA6r847LbRBtYkMLNVBbYmo+SthUbRVD68EmRfTTDAXeBc37xieWSdP0KpNWdhRLkBq1cxBHKanmj9oEUkPCgtZgRzQfAIEQ28HmK+VZvyCXHUdhkz3ajrzSNgkhmoNobOnfU80lPonFs1EuEyMy7BkKWPkFlucNfNsDoZfpxhWIrlvks6xMAb41b0r4X9NQSqRWQBlpGsxHeofDllPJwSEumINuFDGjM3NoKQKKS3KXdemYBN8Zd8LbgMCA54BssQ1UzrpcHXGlfegbbcxRcW0OCgr27ppqR8viaduFlJRR7prHpSNBk7kp1Nx6BJzEEgcPMOyzDEl6qJQNRObXvZGSB+jwKzXKe5sz64tWLLVPWz9Fw3BJKqGEGiIgs6Te4x5ooFR+SqyIg/+5Q2s64gYVAlo8wqjI3Bnzwk2n18D0HpwOlbxcbu4jS+3EUKfhLH086OqHBe9SgiAZSOYRhxj88Vxu/vnY42H4WNiwLwpADhSt4Dtw+Kg7k8fav9XMNQU7HxDC5jaLcHqAuBwR1WXvdYeiZDOl4huJoujtyXt4yKNiBxcX6Fanfbtm4yWOzuM31/EGnx0Vkj4v1ypUeN2j2NuFQOuiV8U6NuJH9wY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(451199018)(8676002)(36756003)(33656002)(66476007)(76116006)(64756008)(71200400001)(6486002)(2616005)(83380400001)(186003)(26005)(53546011)(6512007)(6506007)(8936002)(41300700001)(86362001)(38070700005)(5660300002)(2906002)(66946007)(54906003)(316002)(91956017)(38100700002)(478600001)(66446008)(4326008)(6916009)(66556008)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <17DC4005EC033D438EE1A6ABD015AAF9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9849 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 50606521-f005-4d1a-4b48-08db167b99d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: urngFWmnnrXcDvzeOgVaqyv5Tsl4zQztwYOOMbHAVyS7wxZlhfyeWpC0F5VF2OuECGs/XTqxT+/jFGwTEwhOznQBE583hBvSk9/jEqKH0Dfxji1PDp7BlyRgaNWpEQTqS+/R32+Q1F65PFPNJvwM/bs0eY7Yp/ko0BDP7aLCcLV9DPY+wKVK+c4+xN/dLKXfVRYcjyexziHQ3is7Qwb4fSAWJ3pWldalpSN9zHFfOL+gow8jDSZ6GkPfnEb6SxEiWrzLm7SEMf1kKzfpM9onu8luEZBdKByUFna3O2XgMITh+xtfNgy4eZ+tbPYjENx6rmpRWmmwNc1UmdW5qixWm1Uxv5Uf/dld3/lbZl1J2qbL4Q2oEnX9DF635c6o9WG9hoSprSV5ayuaPy1xDoSwNvTlyL09HEG1MqEPrg2/gJufl6pBfhjaj82cEftX4dcGZAV1aZtg+k8YbvPAnE2WTXxx18XR9nvTy0oPQxcvjttFLaf3wy+iKfZ0eVp0Ypp+kLZ5jGEusKTlgeC4gQULDWwzssJSA0AsFYh6ALKqz3qnHBewQpCnrKgv7MKggg7xBu84WZTzE8ANCxxZ0tmMdP2c63npPm8ol8nbGexDhAX4LuuZ8FDFGECNrYV9gw9VrP3tSYx9Fb2KaVQHmkZwSjYxDGUzfKpDSWlvFsTh7svlOz0kYSWhVnpIMnXmW9OtjK5QB8goNZ6Ev8b94d56Sw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199018)(40470700004)(46966006)(36840700001)(2906002)(40460700003)(81166007)(86362001)(53546011)(8676002)(40480700001)(54906003)(478600001)(356005)(316002)(70206006)(70586007)(6486002)(82740400003)(36756003)(6506007)(6512007)(41300700001)(5660300002)(33656002)(6862004)(8936002)(26005)(186003)(4326008)(83380400001)(36860700001)(82310400005)(336012)(2616005)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 15:27:24.9189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1caa8c17-b404-4b9f-af37-08db167ba17f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8314 HI Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A > mediator. >=20 > Signed-off-by: Jens Wiklander NIT: I would s/note/enforce/ in the title: xen/arm: ffa: enforce 4k pages Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index d04bac9cc47f..8b0b80ce1ff5 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -56,6 +56,16 @@ > #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > FFA_MY_VERSION_MINOR) >=20 > +/* > + * The FF-A specification explicitly works with 4K pages as a measure of > + * memory size, for example, FFA_RXTX_MAP takes one parameter "RX/TX pag= e > + * count" which is the number of contiguous 4K pages allocated. Xen may = use > + * a different page size depending on the configuration to avoid confusi= on > + * with PAGE_SIZE use a special define when it's a page size as in the F= F-A > + * specification. > + */ > +#define FFA_PAGE_SIZE SZ_4K > + > /* Framework direct request/response */ > #define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > #define FFA_MSG_TYPE_MASK 0xFFU; > @@ -242,6 +252,17 @@ static bool ffa_probe(void) > unsigned int major_vers; > unsigned int minor_vers; >=20 > + /* > + * FF-A often works in units of 4K pages and currently it's assumed > + * that we can map memory using that granularity. See also the comme= nt > + * above the FFA_PAGE_SIZE define. > + * > + * It is possible to support a PAGE_SIZE larger than 4K in Xen, but > + * until that is fully handled in this code make sure that we only u= se > + * 4K page sizes. > + */ > + BUILD_BUG_ON(PAGE_SIZE !=3D FFA_PAGE_SIZE); > + > /* > * psci_init_smccc() updates this value with what's reported by EL-3 > * or secure world. > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:31:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:31:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501202.772847 (Exim 4.92) (envelope-from ) id 1pVa2k-0007bq-Tc; Fri, 24 Feb 2023 15:31:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501202.772847; Fri, 24 Feb 2023 15:31:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa2k-0007bj-PO; Fri, 24 Feb 2023 15:31:30 +0000 Received: by outflank-mailman (input) for mailman id 501202; Fri, 24 Feb 2023 15:31:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa2j-0007bd-Gb for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:31:29 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dad0dbd-b458-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:31:27 +0100 (CET) Received: by mail-wr1-x431.google.com with SMTP id h14so5643107wru.4 for ; Fri, 24 Feb 2023 07:31:27 -0800 (PST) Received: from horizon ([2a01:e0a:257:8c60:48e5:bfa:d652:b8ef]) by smtp.gmail.com with ESMTPSA id n9-20020a5d4c49000000b002c54536c662sm13066801wrt.34.2023.02.24.07.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:31:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dad0dbd-b458-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZV5C0hVPYC0aBKYitXuskCf1e0ZV+iPaAkzufBrwV78=; b=bUs9rI57R7lETZvlexfoMYqFcthg+BP9KjLRVlfr8m9O4jPRkDWbpR6GrT1PHtyp4H SOuq72nNfwoJ75aVCnyG4tdLak4uaL9HLHVl+l+nyENG5snmRuRJlxAyT1xTQlajRoyS iv9ixqUlywGoy1HHsqoFNO/1jvVW4ZxWqM/eWGxrAGqD21HuJ10ItwmdaOMVPDjyD61z 4qCPZei9hgzlYBw1xWaI2j0N+jXaL38aUc3l3yP5XyjhxP2CScQsMAJvuQxhNN4oUpQf lvWtw23iisvpE6QXkdo0bX+06h2Us2lV5Saf6WnsTaHjCl69QymH/yz2mS4aUxOX83QW f3LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZV5C0hVPYC0aBKYitXuskCf1e0ZV+iPaAkzufBrwV78=; b=HF7xvNPq4r7BDCfcRc9kkRwGzjNRBrLk9K79lWJB2u4YZ5r6fHsysHrMX6zCb773UR u+N6h/f5pDBM5+nn9FDJ/NgYx0uConzR3eMJdyuxxyY3OA24Gv744sUKUFJleD60+uoN R9VJp+VHmUX16isUfCjKoUKAmEzFJUFKo4wwBjsR7p9aAS4CTVf/7MSQwKuYqkdnVGEU m5HoJEkHLWcOyWqNudnRORPDjUfZ9myKY8U52UkH/X8fdwwQOw2KApLSTM1C9EVSq2M2 a5ZrjrORg+hPPTTfuiyYZWf7KC/J3BdNqnlxI41nXTkNL4sVEssFQAMYgRWFcFjNv6H+ Ztpw== X-Gm-Message-State: AO0yUKU0wgX2wGBJKiskEgdB+FVf4BUWZPHUKzX1ylpvp8U0HSGjT8OE 3FOFasnQ2ic49+b74jDV8Mg= X-Google-Smtp-Source: AK7set/Np1CirXs68TrXcIO5r9v7owhi/BkPczCCiv337bPpwNzV1c9xKda0dwqXrgIiYO3IFX1zGg== X-Received: by 2002:a5d:4e47:0:b0:2c8:840:26ea with SMTP id r7-20020a5d4e47000000b002c8084026eamr824217wrt.12.1677252686447; Fri, 24 Feb 2023 07:31:26 -0800 (PST) Date: Fri, 24 Feb 2023 16:31:23 +0100 From: Matias Ezequiel Vara Larsen To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Matias Ezequiel Vara Larsen , Wei Liu , Anthony PERARD Subject: Re: [RFC PATCH v2 2/2] tools/misc: Add xen-vcpus-stats tool Message-ID: <20230224153123.GA3764964@horizon> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hello Andrew and thanks for the comments, On Thu, Feb 23, 2023 at 04:01:09PM +0000, Andrew Cooper wrote: > On 07/10/2022 1:39 pm, Matias Ezequiel Vara Larsen wrote: > > A couple of observations, all unrelated to the stats themselves. > > Although overall, I'm not entirely certain that a tool like this is > going to be very helpful after initial development. Something to > consider would be to alter libxenstat to use this new interface? > Yes. We discussed about this in a design sesion at the summit. I could not move forward on that direction yet but it is the right way to go. I use this tool only to play with the interface and I could just remove it from the RFC in next versions. > > diff --git a/tools/misc/Makefile b/tools/misc/Makefile > > index 2b683819d4..837e4b50da 100644 > > --- a/tools/misc/Makefile > > +++ b/tools/misc/Makefile > > @@ -49,6 +49,7 @@ TARGETS_COPY += xenpvnetboot > > > > # Everything which needs to be built > > TARGETS_BUILD := $(filter-out $(TARGETS_COPY),$(TARGETS_ALL)) > > +TARGETS_BUILD += xen-vcpus-stats > > This patch is whitespace corrupted. If at all possible, you need to see > about getting `git send-email` working to send patches with, as it deals > with most of the whitespace problems for you. > > I'm afraid you can't simply copy the patch text into an email and send that. > I am using `git send-email` to send patches. I may have missed some flag. I'll double-check. > > > > # ... including build-only targets > > TARGETS_BUILD-$(CONFIG_X86) += xen-vmtrace > > @@ -135,4 +136,9 @@ xencov: xencov.o > > xen-ucode: xen-ucode.o > > $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS) > > > > +xen-vcpus-stats.o: CFLAGS += $(CFLAGS_libxenforeginmemory) > > + > > +xen-vcpus-stats: xen-vcpus-stats.o > > + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) > > $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) > > + > > -include $(DEPS_INCLUDE) > > diff --git a/tools/misc/xen-vcpus-stats.c b/tools/misc/xen-vcpus-stats.c > > new file mode 100644 > > index 0000000000..29d0efb124 > > --- /dev/null > > +++ b/tools/misc/xen-vcpus-stats.c > > @@ -0,0 +1,87 @@ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#define rmb() asm volatile("lfence":::"memory") > > This is rmb(), but rmb() isn't what you want. > > You want smp_rmb(), which is > > #define smp_rmb() asm volatile ("" ::: "memory") > > > I'm surprised we haven't got this in a common location, considering how > often it goes wrong. (Doesn't help that there's plenty of buggy > examples to copy, even in xen.git) > Got it. I'll rework on it in the next version. For inspiration, I used the code at arch/x86/kernel/pvclock.c:pvclock_read_wallclock(). > > + > > +static sig_atomic_t interrupted; > > +static void close_handler(int signum) > > +{ > > + interrupted = 1; > > +} > > + > > +int main(int argc, char **argv) > > +{ > > + xenforeignmemory_handle *fh; > > + xenforeignmemory_resource_handle *res; > > + size_t size; > > + int rc, domid, period, vcpu; > > + shared_vcpustatspage_t * info; > > shared_vcpustatspage_t *info; > > no space after the *. > > But you also cannot have a single structure describing that. I'll reply > to the cover letter discussing ABIs. I am reading it and I will comment on this soon. > > > + struct sigaction act; > > + uint32_t version; > > + uint64_t value; > > + > > + if (argc != 4 ) { > > { on a new line. > > > + fprintf(stderr, "Usage: %s \n", argv[0]); > > + return 1; > > + } > > + > > + domid = atoi(argv[1]); > > + vcpu = atoi(argv[2]); > > + period = atoi(argv[3]); > > + > > + act.sa_handler = close_handler; > > + act.sa_flags = 0; > > + sigemptyset(&act.sa_mask); > > + sigaction(SIGHUP, &act, NULL); > > + sigaction(SIGTERM, &act, NULL); > > + sigaction(SIGINT, &act, NULL); > > + sigaction(SIGALRM, &act, NULL); > > + > > + fh = xenforeignmemory_open(NULL, 0); > > + > > + if ( !fh ) > > + err(1, "xenforeignmemory_open"); > > + > > + rc = xenforeignmemory_resource_size( > > + fh, domid, XENMEM_resource_stats_table, > > + 0, &size); > > + > > + if ( rc ) > > + err(1, "Fail: Get size"); > > + > > + res = xenforeignmemory_map_resource( > > + fh, domid, XENMEM_resource_stats_table, > > + 0, XENMEM_resource_stats_frame_vcpustats, size >> XC_PAGE_SHIFT, > > + (void **)&info, PROT_READ, 0); > > + > > + if ( !res ) > > + err(1, "Fail: Map"); > > + > > + while ( !interrupted ) { > > { on newline again. > > > + sleep(period); > > + do { > > + version = info->vcpu_info[vcpu].version; > > + rmb(); > > + value = info->vcpu_info[vcpu].runstate_running_time; > > + rmb(); > > + } while ((info->vcpu_info[vcpu].version & 1) || > > + (version != info->vcpu_info[vcpu].version)); > > So I think this will function correctly. > > But I do recall seeing a rather nice way of wrapping a sequence lock in > C99. I'll see if I can find it. > > > + printf("running_vcpu_time[%d]: %ld\n", vcpu, value); > > + } > > + > > + rc = xenforeignmemory_unmap_resource(fh, res); > > + if ( rc ) > > + err(1, "Fail: Unmap"); > > Given that you unmap(), you ought to close the fh handle too. > Thanks, I'll fix these issues in the next version. I think Jan's review have already spotted some of them. Matias From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:35:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501210.772855 (Exim 4.92) (envelope-from ) id 1pVa6U-0008HX-GW; Fri, 24 Feb 2023 15:35:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501210.772855; Fri, 24 Feb 2023 15:35:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa6U-0008HQ-Dv; Fri, 24 Feb 2023 15:35:22 +0000 Received: by outflank-mailman (input) for mailman id 501210; Fri, 24 Feb 2023 15:35:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa6S-0008HK-BT for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:35:20 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8031373-b458-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:35:19 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id ck15so57515502edb.0 for ; Fri, 24 Feb 2023 07:35:19 -0800 (PST) Received: from EPUAKYIW03DD.. ([91.123.150.38]) by smtp.gmail.com with ESMTPSA id kg19-20020a17090776f300b008be0b7242d5sm8441360ejc.90.2023.02.24.07.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 07:35:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8031373-b458-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VzbLUEUjtY0tsDWNS62Tcb+S81iHP1D44kGH0OHXbkA=; b=UUW2cNQxQ9wiI1y1uEIiov8/aAn6pQQMVXzfBkhJVbnD02igAWyzWePL5TL0KIpFXc f06QP9Z9KFOrAD5Ctv6w7WEt4EpGTRp7azcZPWKRgRcy7Rq6bww9dx6TUNU5NGO2rgjk yo4aNdOesMKZr3LRk9rjWzwFngPGaCK+rpUGcmZndXmJb/SCuTPWMP987JyoGPrq687s ZVdvsxSaXkI4Dq/rU97CmzGR6MHk9vwsst50gUNty8yu/Rf8o86l8jy2Z4iYWyKTLm2+ qmsbKn9RXvDBmUJKNNwq8NfnVSmnAykvHSw/wUNDR0l1tseozRwukyc+jIcN3OqCKJFh W4xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VzbLUEUjtY0tsDWNS62Tcb+S81iHP1D44kGH0OHXbkA=; b=gNwM13qojWkzyD+4jmmpniF3BH3CaKWpJHsmg8gPSZakKNUsSiyYSvelzipPBr3C98 Ha5JciJ8niw1r6hs/SFUEbJlswUBe7mI76IBWzqlY9PEP92xMyUilKyaNp1EOADuUQnK fTKAb+pQhzi5zWQqEpIlhPA7ettHO9RhvuJ3pQ9SrCoxxh/rDBAXkwD1OG1HnwfcIpVR uHxXcdqqO1gnBokT/NN0VumQKJNCWP0G7NcfcNIrMPIu89+49SuJJc0jTmmVfM7eXEjE 1W+OY97BgX5GzB8knPhWXqXLBkIId+3qhfJJFgbmIi0x8dj6dxry2/EhfEd6S1AW+ny4 f8HA== X-Gm-Message-State: AO0yUKWb6nwwiBKGC+S0CgBnyLb6Ua0RuDmBS+42GKfewmigC/pZEsxd Yro/JFfgmWTmA3jGFi6W6owmRfmb+3I= X-Google-Smtp-Source: AK7set9QwwaNgb3OunBObQ+DvB0YGMDXoLNPjUGf1qbnK8dvMDVSCNC8+t8Bu3sMBeMmTuUP+/sN9w== X-Received: by 2002:a17:907:1612:b0:8e4:86ed:7203 with SMTP id hb18-20020a170907161200b008e486ed7203mr144549ejc.11.1677252918233; Fri, 24 Feb 2023 07:35:18 -0800 (PST) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Dmitry Osipenko , Juergen Gross , Stefano Stabellini Subject: [PATCH] drm/virtio: Pass correct device to dma_sync_sgtable_for_device() Date: Fri, 24 Feb 2023 17:34:50 +0200 Message-Id: <20230224153450.526222-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko The "vdev->dev.parent" should be used instead of "vdev->dev" as a device for which to perform the DMA operation in both virtio_gpu_cmd_transfer_to_host_2d(3d). Because the virtio-gpu device "vdev->dev" doesn't really have DMA OPS assigned to it, but parent (virtio-pci or virtio-mmio) device "vdev->dev.parent" has. The more, the sgtable in question the code is trying to sync here was mapped for the parent device (by using its DMA OPS) previously at: virtio_gpu_object_shmem_init()->drm_gem_shmem_get_pages_sgt()-> dma_map_sgtable(), so should be synced here for the same parent device. Fixes: b5c9ed70d1a9 ("drm/virtio: Improve DMA API usage for shmem BOs") Signed-off-by: Oleksandr Tyshchenko --- This patch fixes the following issue when running on top of Xen with CONFIG_XEN_VIRTIO=y (patch was only tested in Xen environment (ARM64 guest) w/ and w/o using Xen grants for virtio): [ 0.830235] [drm] pci: virtio-gpu-pci detected at 0000:00:03.0 [ 0.832078] [drm] features: +virgl +edid -resource_blob -host_visible [ 0.832084] [drm] features: -context_init [ 0.837320] [drm] number of scanouts: 1 [ 0.837460] [drm] number of cap sets: 2 [ 0.904372] [drm] cap set 0: id 1, max-version 1, max-size 308 [ 0.905399] [drm] cap set 1: id 2, max-version 2, max-size 696 [ 0.907202] [drm] Initialized virtio_gpu 0.1.0 0 for 0000:00:03.0 on minor 0 [ 0.927241] virtio-pci 0000:00:03.0: [drm] drm_plane_enable_fb_damage_clips() not called [ 0.927279] Unable to handle kernel paging request at virtual address ffffffffc0053000 [ 0.927284] Mem abort info: [ 0.927286] ESR = 0x0000000096000144 [ 0.927289] EC = 0x25: DABT (current EL), IL = 32 bits [ 0.927293] SET = 0, FnV = 0 [ 0.927295] EA = 0, S1PTW = 0 [ 0.927298] FSC = 0x04: level 0 translation fault [ 0.927301] Data abort info: [ 0.927303] ISV = 0, ISS = 0x00000144 [ 0.927305] CM = 1, WnR = 1 [ 0.927308] swapper pgtable: 4k pages, 48-bit VAs, pgdp=000000004127f000 [ 0.927312] [ffffffffc0053000] pgd=0000000000000000, p4d=0000000000000000 [ 0.927323] Internal error: Oops: 0000000096000144 [#1] PREEMPT SMP [ 0.927329] Modules linked in: [ 0.927336] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 6.2.0-rc4-yocto-standard #1 [ 0.927343] Hardware name: XENVM-4.18 (DT) [ 0.927346] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.927352] pc : dcache_clean_poc+0x20/0x38 [ 0.927370] lr : arch_sync_dma_for_device+0x24/0x30 [ 0.927379] sp : ffff80000972b3e0 [ 0.927381] x29: ffff80000972b3e0 x28: ffff000001aa8a00 x27: 0000000000000000 [ 0.927389] x26: 0000000000000000 x25: ffff000002815010 x24: 0000000000000000 [ 0.927396] x23: ffff8000090f9078 x22: 0000000000000001 x21: 0000000000000002 [ 0.927403] x20: ffff000002b6b580 x19: 8000000000053000 x18: ffffffffffffffff [ 0.927410] x17: 0000000000000000 x16: 0000000000000000 x15: ffff80000963b94e [ 0.927416] x14: 0000000000000001 x13: ffff80000963b93b x12: 64615f616d645f67 [ 0.927423] x11: ffff800009513110 x10: 000000000000000a x9 : ffff80000972b360 [ 0.927430] x8 : ffff8000095130c8 x7 : ffff80000972b150 x6 : 000000000000000c [ 0.927436] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 000000000000003f [ 0.927443] x2 : 0000000000000040 x1 : ffffffffc0067000 x0 : ffffffffc0053000 [ 0.927450] Call trace: [ 0.927452] dcache_clean_poc+0x20/0x38 [ 0.927459] dma_direct_sync_sg_for_device+0x124/0x130 [ 0.927466] dma_sync_sg_for_device+0x64/0xd0 [ 0.927475] virtio_gpu_cmd_transfer_to_host_2d+0x10c/0x110 [ 0.927483] virtio_gpu_primary_plane_update+0x340/0x3d0 [ 0.927490] drm_atomic_helper_commit_planes+0xe8/0x20c [ 0.927497] drm_atomic_helper_commit_tail+0x54/0xa0 [ 0.927503] commit_tail+0x160/0x190 [ 0.927507] drm_atomic_helper_commit+0x16c/0x180 [ 0.927513] drm_atomic_commit+0xa8/0xe0 [ 0.927521] drm_client_modeset_commit_atomic+0x200/0x260 [ 0.927529] drm_client_modeset_commit_locked+0x5c/0x1a0 [ 0.927536] drm_client_modeset_commit+0x30/0x60 [ 0.927540] drm_fb_helper_set_par+0xc8/0x120 [ 0.927548] fbcon_init+0x3b8/0x510 [ 0.927557] visual_init+0xb4/0x104 [ 0.927565] do_bind_con_driver.isra.0+0x1c4/0x394 [ 0.927572] do_take_over_console+0x144/0x1fc [ 0.927577] do_fbcon_takeover+0x6c/0xe4 [ 0.927583] fbcon_fb_registered+0x1e4/0x1f0 [ 0.927588] register_framebuffer+0x214/0x310 [ 0.927592] __drm_fb_helper_initial_config_and_unlock+0x33c/0x540 [ 0.927599] drm_fb_helper_initial_config+0x4c/0x60 [ 0.927604] drm_fbdev_client_hotplug+0xc4/0x150 [ 0.927609] drm_fbdev_generic_setup+0x90/0x154 [ 0.927614] virtio_gpu_probe+0xc8/0x16c [ 0.927621] virtio_dev_probe+0x19c/0x240 [ 0.927629] really_probe+0xbc/0x2dc [ 0.927637] __driver_probe_device+0x78/0xe0 [ 0.927641] driver_probe_device+0xd8/0x160 [ 0.927645] __driver_attach+0x94/0x19c [ 0.927649] bus_for_each_dev+0x70/0xd0 [ 0.927656] driver_attach+0x24/0x30 [ 0.927660] bus_add_driver+0x154/0x20c [ 0.927664] driver_register+0x78/0x130 [ 0.927670] register_virtio_driver+0x24/0x3c [ 0.927675] virtio_gpu_driver_init+0x18/0x24 [ 0.927684] do_one_initcall+0x50/0x1d0 [ 0.927691] kernel_init_freeable+0x210/0x27c [ 0.927699] kernel_init+0x24/0x12c [ 0.927707] ret_from_fork+0x10/0x20 [ 0.927716] Code: d2800082 9ac32042 d1000443 8a230000 (d50b7a20) [ 0.927721] ---[ end trace 0000000000000000 ]--- [ 0.927728] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 0.927732] SMP: stopping secondary CPUs [ 0.927791] Kernel Offset: disabled [ 0.927794] CPU features: 0x80000,41058100,0000421b [ 0.927799] Memory Limit: none [ 1.015063] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- --- --- drivers/gpu/drm/virtio/virtgpu_vq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index a04a9b20896d..1778a2081fd6 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -604,7 +604,7 @@ void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev, bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev); if (virtio_gpu_is_shmem(bo) && use_dma_api) - dma_sync_sgtable_for_device(&vgdev->vdev->dev, + dma_sync_sgtable_for_device(vgdev->vdev->dev.parent, bo->base.sgt, DMA_TO_DEVICE); cmd_p = virtio_gpu_alloc_cmd(vgdev, &vbuf, sizeof(*cmd_p)); @@ -1026,7 +1026,7 @@ void virtio_gpu_cmd_transfer_to_host_3d(struct virtio_gpu_device *vgdev, bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev); if (virtio_gpu_is_shmem(bo) && use_dma_api) - dma_sync_sgtable_for_device(&vgdev->vdev->dev, + dma_sync_sgtable_for_device(vgdev->vdev->dev.parent, bo->base.sgt, DMA_TO_DEVICE); cmd_p = virtio_gpu_alloc_cmd(vgdev, &vbuf, sizeof(*cmd_p)); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:37:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501218.772866 (Exim 4.92) (envelope-from ) id 1pVa8g-0000PX-Sv; Fri, 24 Feb 2023 15:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501218.772866; Fri, 24 Feb 2023 15:37:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa8g-0000PQ-Q2; Fri, 24 Feb 2023 15:37:38 +0000 Received: by outflank-mailman (input) for mailman id 501218; Fri, 24 Feb 2023 15:37:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVa8f-0000PI-Ia for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:37:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2848d582-b459-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 16:37:35 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2848d582-b459-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677253055; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PtAwsUY/Fwt8xIERNpc2GH/6MwL3Unj3xN1X4Ttps6k=; b=WOJDa/TObEgn20S0hINervLWlNtXA7PYY122el0ZaPYE3fPAMbRDx8ij kiPDflzwP/5Yo1K6IdmCNmA1ppYiN2NfQTjcyVPYIvqcYEAbypzCIO6Wz yoRNRsKdkKD89/lh4/+cUF1WbjvFMh0YlgkYQ8mSV+Pr29XYYgpIYGYrU 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 100852897 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:whRN5a/Os8hFZoyLythbDrUDHn6TJUtcMsCJ2f8bNWPcYEJGY0x3z zcbXm6BaKnfYGChKI92aI7np0hTu8PdytNjHgFkrS08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oX5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklr9 eEYFi0iPiq4lsSWm7yQSvJyl94aeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAr3/zaTBH7nmSorI6+TP7xw1tyrn9dtHSf7RmQO0Mxh7I+ ziWrjuR7hcyc+WT7QGC/26Xlsjqknr/eZ4iGJrn36s/6LGU7jNKU0BHPbehmtGikVK3Ud9bL 00S+wItoLI0+UjtScPyNzWzqWSIuRM0UNNKH+o3rgqKz8L85geSBmEACDlbetEinMYzSXoh0 Vrht9rtBCdzubyPD3yH/7GfrCiaJiQea2QFYEcsXQYDptXuvow3phbOVcp4Vr64iMXvHjP9y CzMqzIx750UicMIzKS6u1PamTWnppvOZgEw7wTTGGmi62tRb4mjYYuq5VHF7O1oI4OQT13Ht 38B8+CU6+oEHJyWlCiARewLNL6s7veBdjbbhDZS84IJrmr3vST5JMYJvW84fR0yWioZRdP3S GrTpANv+bADBkC7S48sbamxENo715G1QLwJScvoRtZJZ5FwciqO8ydveVOc0gjRraQ8rU0sE czFKJjxVB72HYwilWPrHLlFjdfH0whknQvuqYbHIwNLOFZ0TFqcUv87PVSHdYjVB4vU8VyOo 76z2yZnoiizsdESgAGNrOb/znhQdxDX4KwaTOQGHtNv2iI8RAkc5wb5mNvNgbBNkaVPjfvv9 XqgQEJew1eXrSSZdlrTNS85N+6+DccXQZcH0csEZwvA5pTeSdz3sPd3m2UfINHLC9CPPdYrF qJYKq1s89xESyjd+iR1UHUOhNUKSfhfvirXZ3DNSGFmL/Zdq/nhpoeMkv3HqHNfUUJadKIW/ 9Wd6+8sacBTF1Q6VJaKOa3HIpHYlSF1pd+elnDgerF7EHgAOqAwQ8Atppfb+/0xFCg= IronPort-HdrOrdr: A9a23:m5LA5auuSpMoUVZvrDAmdK9/7skCw4Mji2hC6mlwRA09TyXGra 6TdaUguiMc1gx8ZJh5o6H9BEGBKUmskaKdkrNhQotKPTOW9FdASbsC0WKM+UyZJ8STzJ8+6U 4kSdkCNDSSNyk0sS+Z2njCLz9I+rDum8rE5Za8854ud3ARV0gK1XYfNu/vKDwOeOAwP+teKH Pz3LsjmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlal9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4kow3TX+0aVjbZaKv+/VQMO0aSSAZER4Z 3xSiIbTodOArXqDyaISFXWqk/dOX0VmgHfIBej8AreSIrCNWsH4w4rv/MDTvMfgHBQ5O2UmZ g7rF5wu/dsfGP9tTW46N7SWx5wkE2o5XIkjO4IlnRaFZATcblLsOUkjQho+bo7bWvHAbocYa FTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYEit2ZF8Ih4R4hP5u zCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tTKyaRw4PvvdI0DzZM0lp iEWFREtXQqc0arEsGK1I0jyGG6fIx8Z0Wb9ihz3ekMhlSnfsuYDcSqciFar/ed X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="100852897" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Anthony PERARD , "Stefano Stabellini" , Michal Orzel , Doug Goldstein Subject: [PATCH] CI: Simplify RISCV smoke testing Date: Fri, 24 Feb 2023 15:37:21 +0000 Message-ID: <20230224153721.2623760-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Use a single fairly generic string as the "all done" message to look for, which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature is added. Signed-off-by: Andrew Cooper --- CC: Oleksii Kurochko CC: Bob Eshleman CC: Alistair Francis CC: Connor Davis CC: Anthony PERARD CC: Stefano Stabellini CC: Michal Orzel CC: Doug Goldstein I considered "All set up and nowhere to go" but it's probably a little niche. --- automation/scripts/qemu-smoke-riscv64.sh | 2 +- xen/arch/riscv/setup.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh index e0f06360bc43..4008191302f9 100755 --- a/automation/scripts/qemu-smoke-riscv64.sh +++ b/automation/scripts/qemu-smoke-riscv64.sh @@ -16,5 +16,5 @@ qemu-system-riscv64 \ |& tee smoke.serial set -e -(grep -q "Hello from C env" smoke.serial) || exit 1 +(grep -q "All set up" smoke.serial) || exit 1 exit 0 diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index d09ffe1454a4..1c87899e8e90 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -11,6 +11,7 @@ void __init noreturn start_xen(void) { early_printk("Hello from C env\n"); + early_printk("All set up\n"); for ( ;; ) asm volatile ("wfi"); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:58:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:58:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501226.772876 (Exim 4.92) (envelope-from ) id 1pVaSK-0003gb-II; Fri, 24 Feb 2023 15:57:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501226.772876; Fri, 24 Feb 2023 15:57:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaSK-0003gU-FP; Fri, 24 Feb 2023 15:57:56 +0000 Received: by outflank-mailman (input) for mailman id 501226; Fri, 24 Feb 2023 15:57:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaSJ-0003gH-L3 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:57:55 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb8d8428-b45b-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:57:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb8d8428-b45b-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677254269; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=mGK4sVuywPtn9RlB8nuTz5RshNsNbm0fHTmP0XqHyqg=; b=XPN7Z3mxZUWbhgOfH9s5mvTZn3zAIWgYoj7tc4FRWHAphby57HhBIw93 FbrdDyBixNpDV/VLFkdiZhetxiJqha6UsZIEUcbpdiIkTpdRoqu0bs5si iLGpD+tKGHnEWTMBTCCgm2AJe1nSqz1y2gv23vJBKOdngZccfZ7JgfXb2 Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98838575 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:4OTNNK2onlQncLM+kPbD5edxkn2cJEfYwER7XKvMYLTBsI5bpzZTn 2odW2zQb/yDMWenLdx3Od/l/R5S68fczt4xGgQ6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfLktO7 94KGAo3SB24276Q46mxCfRhiZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiFJUFxRbF+ T+uE2LRGj4QaYOW1Rq5zG/0mv+MwTPCX9IWG+jtnhJtqALKnTFCYPEMbnOguuWwgEO6X9NZK mQX9zAooKx081akJvH0RxCiqWSIlgIdUdFXVeY97WmlwaPO7wGULmMNVDJGZZots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAtuoe55ttp11SWE4glSfTu5jHoJd3u6 x+grDIclYUpt+gG7Pnn23PciXGxq5ecG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl CNawpbDtYjiGbnIzXXQG7tVQNlF8t7faFXhbUhT847NHthH01qqZshu7T53Py+F2e5UKGayM Cc/Ve68jaK/3UdGj4ctPupd6Oxwl8AM8OgJsdiFBueimrArKGe6ENhGPCZ8JVzFnkk2ir0YM pyGa8uqBntyIf05k2XvGLhHjuJ6lnFWKYbvqXfTlUnP7FZjTCTNFedt3KWmM4jVE59oUC2Kq o0CZqNmOj1UUfHkYzm/zGLgBQliEJTPPriv85Y/XrfacmJb9JQJV6e5LUUJJ9Y0wMy4V47go hmAZ6Ov4ACv1S2fcVXWOy8LhXGGdc8XkE/X9BcEZT6As0XPq672hEvDX/PbpYUaydE= IronPort-HdrOrdr: A9a23:9OzmFKP/kTxIFsBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98838575" Date: Fri, 24 Feb 2023 15:57:37 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH v2 6/7] automation: Remove testing on Debian Jessie Message-ID: References: <20230221165542.7642-1-anthony.perard@citrix.com> <20230221165542.7642-7-anthony.perard@citrix.com> <04e6ccb1-919f-671e-6d70-15a74e01bbb4@citrix.com> <7ec61260-0fec-25e2-6fa7-ec1d86e8067d@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7ec61260-0fec-25e2-6fa7-ec1d86e8067d@citrix.com> On Tue, Feb 21, 2023 at 06:01:19PM +0000, Andrew Cooper wrote: > On 21/02/2023 5:59 pm, Andrew Cooper wrote: > > On 21/02/2023 4:55 pm, Anthony PERARD wrote: > >> Jessie as rearch EOL in 2020. > >> > >> Even if we update the containers, we would still not be able to reach > >> HTTPS webside with Let's Encrypt certificates and thus would need more > >> change to the container. > >> > >> Signed-off-by: Anthony PERARD > > How is this interact with the other patches in the series? > > > > I presume we do want to take patch 4 and rebuild the containers, for the > > older branches. And that's fine. > > > > And IMO we should be dropping jessie testing, so this is almost fine for > > staging. > > > > Except, jessie-32 is the only x86-32 build test we've got, so I think we > > want to replace it with a newer container before dropping the jessie*. Actually, we have two mores: debian-unstable-32-* and debian-stretch-32-*. So an old distrib and a very new. So there's probably no need to add more. > Further to this, I really don't think we need to have a 4-wide matrix of > {clang,gcc}{debug,release} for just a 32bit tools userspace. Debug > clang+gcc will do, and save on some testing cycles. I guess we could remove debian-{stretch,unstable}-32-{clang,gcc}. I'll add a patch for that. > ~Andrew > > > > >> --- > >> Notes: > >> HTTPS would fail unless we commit "automation: Remove expired root > >> certificates used to be used by let's encrypt", that is. Patch still in > >> the series, and fix Jessie. > > If we're dropping the jessie containers, do we really need that change > > too? Because we really shouldn't be playing around with URLs on older > > branches. No, there's no need to change it. It's just a bit confusing to both update and delete. In the patch that remove the debian-jessie jobs, I kind of want to also remove the dockerfile, but if the dockerfile is updated in the series it is weird to remove it in that same series. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 15:58:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 15:58:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501233.772885 (Exim 4.92) (envelope-from ) id 1pVaTF-0004By-Rh; Fri, 24 Feb 2023 15:58:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501233.772885; Fri, 24 Feb 2023 15:58:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaTF-0004Br-P7; Fri, 24 Feb 2023 15:58:53 +0000 Received: by outflank-mailman (input) for mailman id 501233; Fri, 24 Feb 2023 15:58:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaTE-0004Bj-N3 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 15:58:52 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20f97a19-b45c-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 16:58:50 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5F3333F1A; Fri, 24 Feb 2023 15:58:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9B19C13A3A; Fri, 24 Feb 2023 15:58:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7q6PJLne+GNzIQAAMHmgww (envelope-from ); Fri, 24 Feb 2023 15:58:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20f97a19-b45c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677254329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wl+a2do04B2F3KH/ZC80E/NrhvVPqgBzEuaqORsCe88=; b=iGVsc6K2vN+QPw5XDJTDfdbMJ8xzKZMnQuXA6OvtlEI9qiawyJZnj6jQx/SM2aJIM0js1H RYjsTj4i11UWNpFfmVfbe7mdXdBpnnxXarA7ky1Q1MZIIJPXPOtywNA6WdDkPQ4+J7Ec4w m6amD1iSXZPC18uUPZyHaJZQzOlnB2A= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH] tools/xenstore: fix quota check in acc_fix_domains() Date: Fri, 24 Feb 2023 16:58:48 +0100 Message-Id: <20230224155848.31036-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when finalizing a transaction the number of node quota is checked to not being exceeded after the transaction. This check is always done, even if the transaction is being performed by a privileged connection, or if there were no nodes created in the transaction. Correct that by checking quota only if: - the transaction is being performed by an unprivileged guest, and - at least one node was created in the transaction Reported-by: Julien Grall Fixes: f2bebf72c4d5 ("xenstore: rework of transaction handling") Signed-off-by: Juergen Gross --- tools/xenstore/xenstored_core.c | 3 +++ tools/xenstore/xenstored_domain.c | 4 ++-- tools/xenstore/xenstored_domain.h | 2 +- tools/xenstore/xenstored_transaction.c | 16 ++++++++++++++-- tools/xenstore/xenstored_transaction.h | 3 +++ 5 files changed, 23 insertions(+), 5 deletions(-) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index a61db2db2d..3ca68681e3 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -1472,6 +1472,9 @@ static struct node *create_node(struct connection *conn, const void *ctx, if (!node) return NULL; + if (conn && conn->transaction) + ta_node_created(conn->transaction); + node->data = data; node->datalen = datalen; diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index d7fc2fafc7..f62be2245c 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -544,7 +544,7 @@ static struct domain *find_domain_by_domid(unsigned int domid) return (d && d->introduced) ? d : NULL; } -int acc_fix_domains(struct list_head *head, bool update) +int acc_fix_domains(struct list_head *head, bool chk_quota, bool update) { struct changed_domain *cd; int cnt; @@ -552,7 +552,7 @@ int acc_fix_domains(struct list_head *head, bool update) list_for_each_entry(cd, head, list) { cnt = domain_nbentry_fix(cd->domid, cd->nbentry, update); if (!update) { - if (cnt >= quota_nb_entry_per_domain) + if (chk_quota && cnt >= quota_nb_entry_per_domain) return ENOSPC; if (cnt < 0) return ENOMEM; diff --git a/tools/xenstore/xenstored_domain.h b/tools/xenstore/xenstored_domain.h index dc4660861e..ec6aa00cc7 100644 --- a/tools/xenstore/xenstored_domain.h +++ b/tools/xenstore/xenstored_domain.h @@ -96,7 +96,7 @@ void domain_outstanding_dec(struct connection *conn); void domain_outstanding_domid_dec(unsigned int domid); int domain_get_quota(const void *ctx, struct connection *conn, unsigned int domid); -int acc_fix_domains(struct list_head *head, bool update); +int acc_fix_domains(struct list_head *head, bool chk_quota, bool update); /* Write rate limiting */ diff --git a/tools/xenstore/xenstored_transaction.c b/tools/xenstore/xenstored_transaction.c index 1aa9d3cb3d..2b15506953 100644 --- a/tools/xenstore/xenstored_transaction.c +++ b/tools/xenstore/xenstored_transaction.c @@ -160,12 +160,20 @@ struct transaction /* List of changed domains - to record the changed domain entry number */ struct list_head changed_domains; + /* There was at least one node created in the transaction. */ + bool node_created; + /* Flag for letting transaction fail. */ bool fail; }; uint64_t generation; +void ta_node_created(struct transaction *trans) +{ + trans->node_created = true; +} + static struct accessed_node *find_accessed_node(struct transaction *trans, const char *name) { @@ -509,6 +517,7 @@ int do_transaction_end(const void *ctx, struct connection *conn, const char *arg = onearg(in); struct transaction *trans; bool is_corrupt = false; + bool chk_quota; int ret; if (!arg || (!streq(arg, "T") && !streq(arg, "F"))) @@ -523,13 +532,16 @@ int do_transaction_end(const void *ctx, struct connection *conn, if (!conn->transaction_started) conn->ta_start_time = 0; + chk_quota = trans->node_created && domain_is_unprivileged(conn); + /* Attach transaction to ctx for auto-cleanup */ talloc_steal(ctx, trans); if (streq(arg, "T")) { if (trans->fail) return ENOMEM; - ret = acc_fix_domains(&trans->changed_domains, false); + ret = acc_fix_domains(&trans->changed_domains, chk_quota, + false); if (ret) return ret; ret = finalize_transaction(conn, trans, &is_corrupt); @@ -539,7 +551,7 @@ int do_transaction_end(const void *ctx, struct connection *conn, wrl_apply_debit_trans_commit(conn); /* fix domain entry for each changed domain */ - acc_fix_domains(&trans->changed_domains, true); + acc_fix_domains(&trans->changed_domains, false, true); if (is_corrupt) corrupt(conn, "transaction inconsistency"); diff --git a/tools/xenstore/xenstored_transaction.h b/tools/xenstore/xenstored_transaction.h index b6f8cb7d0a..883145163f 100644 --- a/tools/xenstore/xenstored_transaction.h +++ b/tools/xenstore/xenstored_transaction.h @@ -36,6 +36,9 @@ int do_transaction_end(const void *ctx, struct connection *conn, struct transaction *transaction_lookup(struct connection *conn, uint32_t id); +/* Set flag for created node. */ +void ta_node_created(struct transaction *trans); + /* This node was accessed. */ int __must_check access_node(struct connection *conn, struct node *node, enum node_access_type type, TDB_DATA *key); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:00:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501240.772896 (Exim 4.92) (envelope-from ) id 1pVaUl-0006cd-Ax; Fri, 24 Feb 2023 16:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501240.772896; Fri, 24 Feb 2023 16:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaUl-0006cW-7Z; Fri, 24 Feb 2023 16:00:27 +0000 Received: by outflank-mailman (input) for mailman id 501240; Fri, 24 Feb 2023 16:00:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaUj-0006XQ-GK for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:00:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5938015b-b45c-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:00:24 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6E82238E9F; Fri, 24 Feb 2023 16:00:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5299113A3A; Fri, 24 Feb 2023 16:00:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kFFMEhjf+GOSIgAAMHmgww (envelope-from ); Fri, 24 Feb 2023 16:00:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5938015b-b45c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677254424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X7s0FzallCl4DMp0OPykuiav5YheiBDCtlUCgqseXlg=; b=Xa0oXrxTFjC6T6uFSgopVWfmshOyxkNf2VtegPsWWLa2NiaMmy3gHpuI71OjEjFtAs/Wz6 j2Ci6qbydhWHFzulqPrYM+6jKALQmH0FMP1rnRY2conY6v0BoYVrx8psnnjom2EQgKwA+Y SoUeQNgLaWnvxw4xq8ZJ/oB9WRpcYUw= Message-ID: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> Date: Fri, 24 Feb 2023 17:00:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction Content-Language: en-US To: Julien Grall Cc: "xen-devel@lists.xenproject.org" References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------AxBQ4fhrkxEndD0ig1IdeC8H" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------AxBQ4fhrkxEndD0ig1IdeC8H Content-Type: multipart/mixed; boundary="------------29rgvCpnShdsq6g0XYa674Uc"; protected-headers="v1" From: Juergen Gross To: Julien Grall Cc: "xen-devel@lists.xenproject.org" Message-ID: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction References: In-Reply-To: --------------29rgvCpnShdsq6g0XYa674Uc Content-Type: multipart/mixed; boundary="------------PC5BAo6d1bCldXb1zoWdQsBd" --------------PC5BAo6d1bCldXb1zoWdQsBd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDIuMjMgMTY6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IEZvciBzb21lIGludGVybmFsIHB1cnBvc2UsIEkgbmVlZCB0byB3cml0ZSBhIHNj cmlwdCB0aGF0IHdvdWxkIGRvIHRoZSBmb2xsb3dpbmc6DQo+IA0KPiAgwqAgMSkgU3RhcnQg YSB0cmFuc2FjdGlvbg0KPiAgwqAgMikgQ2FsbCBHRVRfUEVSTVMNCj4gIMKgIDMpIENhbGwg U0VUX1BFUk1TIHdpdGggdGhlIHBlcm1pc3Npb24ganVzdCByZXRyaWV2ZWQNCj4gIMKgIDQp IENvbW1pdCB0aGUgdHJhbnNhY3Rpb24NCj4gDQo+IChEb24ndCBhc2sgd2h5IDopKQ0KPiAN Cj4gVGhpcyB3YXMgZXhlY3V0ZWQgZnJvbSBkb20wIG9uIGV2ZXJ5IG5vZGVzLiBJbiBzb21l IGNhc2VzLCB3ZSBub3RpY2VkIHRoYXQgNCkgDQo+IHdvdWxkIHJldHVybiAtRU5PU1BDLg0K PiANCj4gV2hlbiBkaWdnaW5nIHRocm91Z2ggdGhlIGNvZGUsIGl0IGxvb2tzIGxpa2UgdGhp cyBpcyBiZWNhdXNlIA0KPiB0cmFuc2FjdGlvbl9maXhfZG9tYWlucygpIChub3cgY2FsbGVk IGFjY19maXhfZG9tYWlucygpKSB3aWxsIGNoZWNrIHRoYXQgdGhlIA0KPiBxdW90YSBpcyBj b3JyZWN0Lg0KPiANCj4gVGhlIGRvbWFpbiBpcyBxdWVzdGlvbiB3ZXJlIG92ZXIgaXRzIGxp bWl0LCBidXQgZ2l2ZW4gdGhpcyBpcyBjYWxsZWQgYnkgZG9tMCwgSSANCj4gd291bGQgaGF2 ZSBleHBlY3RlZCB0aGF0IGl0IHNob3VsZCBub3QgbmV2ZXIgcmV0dXJuIC1FTk9TUEMgKG5v dGUgdGhhdCBhIA0KPiBTRVRfUEVSTVMgb3V0c2lkZSBvZiBhIHRyYW5zYWN0aW9uIHdvdWxk IHdvcmssIGJ1dCB0aGlzIGNhbid0IGJlIHVzZWQgb3VyIGNhc2UpLg0KPiANCj4gRnVydGhl cm1vcmUsIHRoZSB0cmFuc2FjdGlvbiBpcyBub3QgY2hhbmdpbmcgYW55IGFjY291bnRpbmcu IFNvIEkgZmluZCBhIGJpdCANCj4gc3RyYW5nZSB0aGF0IHdlIHdvdWxkIHByZXZlbnQgaXQg ZXZlbiBpZiB0aGlzIHdhcyBydW4gZnJvbSBhbiB1bnByaXZpbGVnZWQgZG9tYWluLg0KPiAN Cj4gRG8geW91IGtub3cgaWYgdGhpcyBpc3N1ZXMgd291bGQgYmUgZml4ZWQgYnkgeW91ciBj dXJyZW50IHJld29yaz8NCj4gDQo+IElmIG5vdCwgdGhlbiBJIHRoaW5rIHdlIGF0IGxlYXN0 IHdhbnQgdG8gc2tpcCB0aGUgcXVvdGEgY2hlY2sgaWYgdGhlIGRvbWFpbiBpcyANCj4gcHJp dmlsZWdlZC4NCj4gDQo+IEZvciBub24tcHJpdmlsZWdlZCBkb21haW4sIEkgYW0gbm90IGVu dGlyZWx5IHN1cmUgd2hhdCB0byBkby4gSSB3YXMgb3JpZ2luYWxseSANCj4gdGhpbmtpbmcg dG8gY2hlY2sgaWYgY2QtPm5iZW50cnkgaXMgMCBhbmQgdGhlbiBza2lwIHRoZSBxdW90YSBj aGVjay4gQnV0IHRoaXMgDQo+IHdvdWxkIGFsbG93IGEgZG9tYWluIHRvIHJlbW92ZSBhIG5v ZGUgYW5kIHRoZW4gcmVwbGFjZSBieSBhIG5ldyBvbmUgKEkgdGhpbmsgd2UgDQo+IHN0aWxs IHdhbnQgdG8gZm9yYmlkIHRoYXQpLg0KPiANCj4gV2hhdCBkbyB5b3UgdGhpbms/DQoNClBh dGNoIHNlbnQuIENvdWxkIHlvdSBwbGVhc2UgdGVzdCBpdCB3aXRoIHlvdXIgc2NyaXB0Pw0K DQoNCkp1ZXJnZW4NCg0K --------------PC5BAo6d1bCldXb1zoWdQsBd Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------PC5BAo6d1bCldXb1zoWdQsBd-- --------------29rgvCpnShdsq6g0XYa674Uc-- --------------AxBQ4fhrkxEndD0ig1IdeC8H Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP43xcFAwAAAAAACgkQsN6d1ii/Ey+p twf6A63VKCXn7i+GGqR2lKNvL01o0X63dp1NcaW52wun6VnN9lLTcqL8uH+BzVCw1rp3Nhlt5YGk E3+Ls0KPaMxrtSD70JynfVLthYe7Rtc4L+JUqY/RsUd3yVaWjurgbxXyK71NB9vg4PpFBoBT6YQZ /hUwfAbiG82vrDfOYhI+Eky08aSVyvJ9m+pq32k1PwTUP2vhEs0DW6bet4G6mpEjBjkgbA/mbM5E txyHDpLQP584EaCyCpEmPdpLz5Xe7Dq5InZZnfp0ir161YcTr9O4lUfFHrGCDFYP7clCZo/HuscN MZWKU+opYDJzjQgr5lrYyHeKUk7W6dI2SfWmbdh9kA== =cRJx -----END PGP SIGNATURE----- --------------AxBQ4fhrkxEndD0ig1IdeC8H-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:01:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:01:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501245.772906 (Exim 4.92) (envelope-from ) id 1pVaVq-0007B9-Lg; Fri, 24 Feb 2023 16:01:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501245.772906; Fri, 24 Feb 2023 16:01:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaVq-0007B2-IT; Fri, 24 Feb 2023 16:01:34 +0000 Received: by outflank-mailman (input) for mailman id 501245; Fri, 24 Feb 2023 16:01:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaVp-0007Ar-9T for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:01:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaVp-0002Sg-6t; Fri, 24 Feb 2023 16:01:33 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[10.95.156.194]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVaVp-0004NT-1d; Fri, 24 Feb 2023 16:01:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=95FPTHzD+3E2P5+fq2zcpOgCjxu434nv+7It7boYjBE=; b=lDUwy9Pfo5RywqUqStuC/tatNO ieMOhuWyamNSF4GCQu5aZgfmZRcj3L6csvvvX/J5trGT+6XEt0xXg6rYfImdDAXSzo2srXIXj/Xde KgHPUqayC7a7hEs5l27O9LF13LDVhuoe16FU8DtNLksKmULpk96LWfvFTAOd/V7WcLI4=; Message-ID: <3bb3e5d3-06c5-8c06-014e-5aef226b5f31@xen.org> Date: Fri, 24 Feb 2023 16:01:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction Content-Language: en-US To: Juergen Gross Cc: "xen-devel@lists.xenproject.org" References: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> From: Julien Grall In-Reply-To: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 24/02/2023 16:00, Juergen Gross wrote: > On 24.02.23 16:00, Julien Grall wrote: >> Hi Juergen, >> >> For some internal purpose, I need to write a script that would do the >> following: >> >>    1) Start a transaction >>    2) Call GET_PERMS >>    3) Call SET_PERMS with the permission just retrieved >>    4) Commit the transaction >> >> (Don't ask why :)) >> >> This was executed from dom0 on every nodes. In some cases, we noticed >> that 4) would return -ENOSPC. >> >> When digging through the code, it looks like this is because >> transaction_fix_domains() (now called acc_fix_domains()) will check >> that the quota is correct. >> >> The domain is question were over its limit, but given this is called >> by dom0, I would have expected that it should not never return -ENOSPC >> (note that a SET_PERMS outside of a transaction would work, but this >> can't be used our case). >> >> Furthermore, the transaction is not changing any accounting. So I find >> a bit strange that we would prevent it even if this was run from an >> unprivileged domain. >> >> Do you know if this issues would be fixed by your current rework? >> >> If not, then I think we at least want to skip the quota check if the >> domain is privileged. >> >> For non-privileged domain, I am not entirely sure what to do. I was >> originally thinking to check if cd->nbentry is 0 and then skip the >> quota check. But this would allow a domain to remove a node and then >> replace by a new one (I think we still want to forbid that). >> >> What do you think? > > Patch sent. Could you please test it with your script? Thanks! I will give a try next week and let you know the result. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:04:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:04:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501250.772916 (Exim 4.92) (envelope-from ) id 1pVaYl-0007pA-2S; Fri, 24 Feb 2023 16:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501250.772916; Fri, 24 Feb 2023 16:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaYk-0007p3-Vu; Fri, 24 Feb 2023 16:04:34 +0000 Received: by outflank-mailman (input) for mailman id 501250; Fri, 24 Feb 2023 16:04:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVaYk-0007ow-1d for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:04:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecc1c406-b45c-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 17:04:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B4A8F3EA44; Fri, 24 Feb 2023 16:04:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99D9E13A3A; Fri, 24 Feb 2023 16:04:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QHEkJA/g+GOHJAAAMHmgww (envelope-from ); Fri, 24 Feb 2023 16:04:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc1c406-b45c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677254671; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6rBdkRoznX2BXlF69UXYYpsxISvtDwjUaU4drdRzA7Q=; b=OpgzoOJQ7Wz21/Zy9sJKL/aucQ01/GwxNksezZuxknhx7VFKW2nQ8KdamjPu6mnG13uE45 wTuFWGKbIt0IIamplt7Xxo5QHojYgTw58qpreolYRFrbrRtB2s75EGJUVjqOV1fls6LjcQ UJNwCqLH4D0AhwgDka884tzIWqq91Ys= Message-ID: <4cc21538-9d37-9a68-1089-5858615fabf8@suse.com> Date: Fri, 24 Feb 2023 17:04:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction Content-Language: en-US To: Julien Grall Cc: "xen-devel@lists.xenproject.org" References: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> <3bb3e5d3-06c5-8c06-014e-5aef226b5f31@xen.org> From: Juergen Gross In-Reply-To: <3bb3e5d3-06c5-8c06-014e-5aef226b5f31@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MuKLFfM0pz3yt2aBzsUpuMVS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MuKLFfM0pz3yt2aBzsUpuMVS Content-Type: multipart/mixed; boundary="------------KFo6UWHr5E1m9YxTO1782Hmq"; protected-headers="v1" From: Juergen Gross To: Julien Grall Cc: "xen-devel@lists.xenproject.org" Message-ID: <4cc21538-9d37-9a68-1089-5858615fabf8@suse.com> Subject: Re: xenstored: Interaction bettwen SET_PERMS and transaction References: <338d9214-fce4-6158-7696-bf8a7421ee9a@suse.com> <3bb3e5d3-06c5-8c06-014e-5aef226b5f31@xen.org> In-Reply-To: <3bb3e5d3-06c5-8c06-014e-5aef226b5f31@xen.org> --------------KFo6UWHr5E1m9YxTO1782Hmq Content-Type: multipart/mixed; boundary="------------QQ4dY4XnC6WGiO7Iy9Zv8CUc" --------------QQ4dY4XnC6WGiO7Iy9Zv8CUc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDIuMjMgMTc6MDEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDI0LzAyLzIwMjMgMTY6MDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyNC4wMi4yMyAxNjowMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpIEp1ZXJnZW4s DQo+Pj4NCj4+PiBGb3Igc29tZSBpbnRlcm5hbCBwdXJwb3NlLCBJIG5lZWQgdG8gd3JpdGUg YSBzY3JpcHQgdGhhdCB3b3VsZCBkbyB0aGUgZm9sbG93aW5nOg0KPj4+DQo+Pj4gwqDCoCAx KSBTdGFydCBhIHRyYW5zYWN0aW9uDQo+Pj4gwqDCoCAyKSBDYWxsIEdFVF9QRVJNUw0KPj4+ IMKgwqAgMykgQ2FsbCBTRVRfUEVSTVMgd2l0aCB0aGUgcGVybWlzc2lvbiBqdXN0IHJldHJp ZXZlZA0KPj4+IMKgwqAgNCkgQ29tbWl0IHRoZSB0cmFuc2FjdGlvbg0KPj4+DQo+Pj4gKERv bid0IGFzayB3aHkgOikpDQo+Pj4NCj4+PiBUaGlzIHdhcyBleGVjdXRlZCBmcm9tIGRvbTAg b24gZXZlcnkgbm9kZXMuIEluIHNvbWUgY2FzZXMsIHdlIG5vdGljZWQgdGhhdCA0KSANCj4+ PiB3b3VsZCByZXR1cm4gLUVOT1NQQy4NCj4+Pg0KPj4+IFdoZW4gZGlnZ2luZyB0aHJvdWdo IHRoZSBjb2RlLCBpdCBsb29rcyBsaWtlIHRoaXMgaXMgYmVjYXVzZSANCj4+PiB0cmFuc2Fj dGlvbl9maXhfZG9tYWlucygpIChub3cgY2FsbGVkIGFjY19maXhfZG9tYWlucygpKSB3aWxs IGNoZWNrIHRoYXQgdGhlIA0KPj4+IHF1b3RhIGlzIGNvcnJlY3QuDQo+Pj4NCj4+PiBUaGUg ZG9tYWluIGlzIHF1ZXN0aW9uIHdlcmUgb3ZlciBpdHMgbGltaXQsIGJ1dCBnaXZlbiB0aGlz IGlzIGNhbGxlZCBieSBkb20wLCANCj4+PiBJIHdvdWxkIGhhdmUgZXhwZWN0ZWQgdGhhdCBp dCBzaG91bGQgbm90IG5ldmVyIHJldHVybiAtRU5PU1BDIChub3RlIHRoYXQgYSANCj4+PiBT RVRfUEVSTVMgb3V0c2lkZSBvZiBhIHRyYW5zYWN0aW9uIHdvdWxkIHdvcmssIGJ1dCB0aGlz IGNhbid0IGJlIHVzZWQgb3VyIGNhc2UpLg0KPj4+DQo+Pj4gRnVydGhlcm1vcmUsIHRoZSB0 cmFuc2FjdGlvbiBpcyBub3QgY2hhbmdpbmcgYW55IGFjY291bnRpbmcuIFNvIEkgZmluZCBh IGJpdCANCj4+PiBzdHJhbmdlIHRoYXQgd2Ugd291bGQgcHJldmVudCBpdCBldmVuIGlmIHRo aXMgd2FzIHJ1biBmcm9tIGFuIHVucHJpdmlsZWdlZCANCj4+PiBkb21haW4uDQo+Pj4NCj4+ PiBEbyB5b3Uga25vdyBpZiB0aGlzIGlzc3VlcyB3b3VsZCBiZSBmaXhlZCBieSB5b3VyIGN1 cnJlbnQgcmV3b3JrPw0KPj4+DQo+Pj4gSWYgbm90LCB0aGVuIEkgdGhpbmsgd2UgYXQgbGVh c3Qgd2FudCB0byBza2lwIHRoZSBxdW90YSBjaGVjayBpZiB0aGUgZG9tYWluIA0KPj4+IGlz IHByaXZpbGVnZWQuDQo+Pj4NCj4+PiBGb3Igbm9uLXByaXZpbGVnZWQgZG9tYWluLCBJIGFt IG5vdCBlbnRpcmVseSBzdXJlIHdoYXQgdG8gZG8uIEkgd2FzIA0KPj4+IG9yaWdpbmFsbHkg dGhpbmtpbmcgdG8gY2hlY2sgaWYgY2QtPm5iZW50cnkgaXMgMCBhbmQgdGhlbiBza2lwIHRo ZSBxdW90YSANCj4+PiBjaGVjay4gQnV0IHRoaXMgd291bGQgYWxsb3cgYSBkb21haW4gdG8g cmVtb3ZlIGEgbm9kZSBhbmQgdGhlbiByZXBsYWNlIGJ5IGEgDQo+Pj4gbmV3IG9uZSAoSSB0 aGluayB3ZSBzdGlsbCB3YW50IHRvIGZvcmJpZCB0aGF0KS4NCj4+Pg0KPj4+IFdoYXQgZG8g eW91IHRoaW5rPw0KPj4NCj4+IFBhdGNoIHNlbnQuIENvdWxkIHlvdSBwbGVhc2UgdGVzdCBp dCB3aXRoIHlvdXIgc2NyaXB0Pw0KPiANCj4gVGhhbmtzISBJIHdpbGwgZ2l2ZSBhIHRyeSBu ZXh0IHdlZWsgYW5kIGxldCB5b3Uga25vdyB0aGUgcmVzdWx0Lg0KDQpUaGFua3MuDQoNCk5v IG5lZWQgdG8gaHVycnksIGFzIEknbGwgYmUgYXdheSBtb3N0IG9mIG5leHQgd2VlayAoYWZ0 ZXIgTW9uZGF5KS4NCg0KDQpKdWVyZ2VuDQo= --------------QQ4dY4XnC6WGiO7Iy9Zv8CUc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------QQ4dY4XnC6WGiO7Iy9Zv8CUc-- --------------KFo6UWHr5E1m9YxTO1782Hmq-- --------------MuKLFfM0pz3yt2aBzsUpuMVS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP44A8FAwAAAAAACgkQsN6d1ii/Ey9d KAf/ZCR8qTRSWtMbkoSWYoalmajmG2eNuHt/knBY1mI8xryuAZfAyntwrJltuJ9n+2LuQk2yEQDq 0jJ0n0RC2q5DUrOUPfkebb1LVngPqI+s0Vs55SDtL8JNNgQf0OvsWpeouSbY26XbYz2TAG6CIs5r SNS/Jy5aW+4FJy5/s+2IcK+SUWGZNNhWZwBe9EQdfL9qZREIh9qXV9GiY5G5cLP5rW+lOm5Gvwgj NmWsNbtcMLkcACRa1xHBEWeBLKyPXhYZcHx1rLX9SORrZ2sTj393cOucybcTITmkF7Pcqh5+5iQJ YtxLNgtKpCGo76Kh/VsKswAZF/5w1J3bjwNzpiWduQ== =Kwv7 -----END PGP SIGNATURE----- --------------MuKLFfM0pz3yt2aBzsUpuMVS-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:35:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:35:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501260.772926 (Exim 4.92) (envelope-from ) id 1pVb2Q-00042w-Ff; Fri, 24 Feb 2023 16:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501260.772926; Fri, 24 Feb 2023 16:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb2Q-00042p-CM; Fri, 24 Feb 2023 16:35:14 +0000 Received: by outflank-mailman (input) for mailman id 501260; Fri, 24 Feb 2023 16:35:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb2O-00041C-VM for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:35:13 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 334f5f43-b461-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 17:35:09 +0100 (CET) Received: from mail-dm6nam04lp2049.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 11:35:06 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6533.namprd03.prod.outlook.com (2603:10b6:a03:386::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Fri, 24 Feb 2023 16:35:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 16:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 334f5f43-b461-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677256509; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=PyPsUbtKpA5ufh7NFR9eFdaedOoj/rxpC+0JXt9uPkI=; b=ChGXHExaetfi6vkBB8oWDHj+WEuJFXYaLzs6Qrb4uGNUyEZSLi6PtMke Z4aJISh6hRlyl/hStNTTgYTBXazIh/sb1k/QS42/X+yA77Ui7BMfOGCOd bJHf/50cnJcOmAsIjbvx1wFwePNIEdH3eB07vQ2ujiNJeL6rjfw0wsfwO Y=; X-IronPort-RemoteIP: 104.47.73.49 X-IronPort-MID: 98439518 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:O7/uiq5PHhjkPW+PiDLG4wxRtAPGchMFZxGqfqrLsTDasY5as4F+v jcXWGnQa/jZZWvxcth2OYTg80gP6MTUztBrHlA/pCxmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 uIqdW4gbU+/u+eq46KwS7kygtRyI5y+VG8fkikIITDxK98DGcyGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Ml0otgdABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdJOT+zlr64CbFu790wCKwcvCwqCnLqS0VD5Z80YN h0v9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO0cSCEu1 1SJt8j0HjEpu7qQIVqC8p+EoDX0PjIaRUcBYikeRAdD/Njno6k0lBvEStslG6mw5uAZAhn1y jGO6SQ72bMaiJZX073hpQyWxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTWKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:Ivy3xKvpZnPeR09JJiTG2Pk87skCbYAji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H4BEGBKUm8yXcH2/hoAV7CZniRhILMFu1fBOTZsljd8kHFmdK1kJ 0QFZSWa+eARGSS7/yKhDVQeuxIqOVvsprY4ts2pE0McegeUdAD0+4PMHf5LqQZfmd7LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGi8zXmIngaRsmAQdizAWVlzun5JPzDhDdh34lInhy6IZn1V KAvx3y562lvf3+4hjA11XL55ATtMr9xsBFDMmsjNFQDjn3kA6naKloRrXHljEop+OE7kosjb D30l8dFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxyL5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjw0C3ELFuJ4O5n7ZvvX+9I61wXB4SL7pXU9 WGOfusqsq+t2nqLUwx8FMfheBEFU5DZStuCnJywPB9lQIm1kyRhnFoufA3jzMO8okwRIJD4P mBOqN0lKtWRstTdq5lAvwdKPHHf1AlbCi8Q156G26XZp0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdduXQpc0zjBMWS1NkTmyq9N1mVTHDo0IVT9pJ5srrzSP7iNjCCUkknl4+lr+8ECsPWVv 6vMNZdAuPlL2HpBYFVtjeOL6V6OD0bSokYq9w7U1WBrobCLZDrrPXSdLLJKL/kAV8fKxPC67 s4LUnOzel7nz6WsyXD8WTsslvWCzPCwa4= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98439518" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9eR73bjmjlCbw2L+Wm+DeDObUIUNbQmkh+SrFBzp+Xx6uy+vCDZslfKLLN8hOPLzlf6+LY1VgujJytckz+snLu+oPe448Uj7JQVWIln9CPfao+648HxxBlb6H1s6Iz9FIIbyCGjKq1RjYqxNMAHQosTCB257HGq+xf0b+dvf6rkKT5Vk2+atYK6slFEg5M31wS45B3THOrUUGpER8knnHSx5SbTHg48bdp9/W57U8MBtideolIPafDdCicgcgyMejZ+EDv4fdTfOAgC/GuwKTkj4CxPbFoUeNwbbZyYxC3d9Rm8AmOijT2Agq1CFl1zwXDgTnVVSK3DAnFQREsn/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pExa22XpCdf6FMWlmzdPxVnFn0mfgpC5FgLzzUVB3Rs=; b=EPn9ik3e5pNiqz3I1sgwxiVoYSBjUmVtzohMoKTrNe4m83HOZplHj4ZMIwmzOdy/J/9acXfxYdDMFGiXnQNbnSE7IdY4u7ycn/zsV/uiRD1e6RMqcRl6jFu6l0h7zkJ1GE3r6m50P1mtNkO7pxjOwZwkTP9YlUqmxTaxhppVJONbTYTqPVMxnFFTbErq3cQqXpOgMOaXIKgVP6eNO/1Z6LvtO1OT2H8sJ2xEtf4jMjms/Q6F8l70q1tIzbEsz9Rh1HmZ8fG4/oeGeTKvuvkJDDUu0lhlfVeAHSif0ZSTAeiuQMDYJpcr5fD/coRYNIg7WFVaEBBEtEjEVpYA53bWxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pExa22XpCdf6FMWlmzdPxVnFn0mfgpC5FgLzzUVB3Rs=; b=J54KjdUOxxnRKuUNXsF9wWntl3dJuZrBsCYiUj//CsmQUAB4mYSIRqMq+shB1km22j2v6cpFgMYvaenORpor3IolcSFr1vNUaZYM8Ls4G6ugkBDqc3Rhkoxr6vedbvYQdEBlLxCTnx6n8CoMyH6TYzVBCszf0OcKnu8j9UPz9X4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <705c2c21-5517-805a-101c-3bd67aec5039@citrix.com> Date: Fri, 24 Feb 2023 16:34:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/asm: ELF metadata for simple cases Content-Language: en-GB To: Ross Lagerwall , Xen-devel Cc: Jan Beulich , Roger Pau Monne , Wei Liu , Konrad Rzeszutek Wilk References: <20230220110439.1518972-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0006.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6533:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c171a25-0952-40eb-c407-08db1685149a X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jme4CqXzb+kk+ZwlMYpXfxUjlEGRibM2nme9/q9zJGm6zkp9THoAIbqc0WHeIpuy1VtYxXVv8PwTCSSXddsMOaM6qJ+FUAxXp5TevSPfikqGnmS0TdjSZWOJsSx/7cXvrMPRTZLe8tcohZ96NX/zGmJgOA9K5tVXhO+DzUtPt5fcKJeJL4S0O4QWURQrLLZ85Ujzg4bSyFEu+JUqlNpJKxZoXUpq2VCUPHIee0zclBodoRDghpdJWxtPVBwGaCool1x5A/PD0/zaOkbqsIISahBdamzIBD3GWhNXfJaYov7iCVGF/RTBy/OmWUkBBJxmw5d/w8S+6OELcFBubvnX9Ozg4mhlrj0PeKSTTJKFXEidjbJqKnDwTdtFT+fvD0wQt/6Kq6AsJ9jd/muFEPKsuAlgRmb4opTm9b1ut6qQNwjoJYs2rrB70deeikKiur9C+LzxBAyXA3EPEo4LueDG55cxgr5/HuX4dB0TR9wnNKPFmty7JuEglVmp5zYiWpWORHthHEOR/4ur2PJ8KhpmArfUusC+tx/qVQ7ss3siekrvjefJtLNReW9CSMlHJlYkwJ4d86pxNMC//ymZlNGWIqIal3WmuZk5C7gDtz+CvU+Z6MIzZ75uVZk72kEw4IAbYYJdD/4WVv82RJ4ekYMUHHhcEZHfAfLzzg8Tfxyv8hyXgi8zjLuaG5xHEbTYwooag/wN8Ftl1gZ+7QEAnqUJSBt5emmg5m0e5VDLwXa0XNk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(451199018)(31686004)(2906002)(5660300002)(8936002)(41300700001)(53546011)(4326008)(83380400001)(66946007)(66556008)(66476007)(8676002)(186003)(6666004)(36756003)(6486002)(26005)(478600001)(6506007)(31696002)(82960400001)(86362001)(110136005)(38100700002)(2616005)(54906003)(316002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHNQQ2N3ekhRYm9RMXBtRFZQaCtya0lMM2hHUVYrdEQ4bFZUZDZHZXFqN2NZ?= =?utf-8?B?TjllemNDaUNxOERoM1ZSVU9xUlRXM05EZjAvVzcyRkVkenlycUUydmNFbHhJ?= =?utf-8?B?cy9FTXBIRExlYWlsQUlJdW9CN25CdXBobUphVEJ5ZmdoTHpydkk4bXBkWTJv?= =?utf-8?B?ck50d2NTcGFTV3NYU2psd0NYMFgyZ28wRkZZYit2KzJLclR1RDdQRm9mWDd6?= =?utf-8?B?TzZLSmw0S3EzRDgxeHhoZkVkUGhaUE5qN2tyYVBrRDZkVFRGVW80Q1BSZFhR?= =?utf-8?B?T0tQTFVWcTZ3VXZjTkJON2RxL3ppLy9yWkFOdXFmQmIwSGxsZVZxUHdVMFpt?= =?utf-8?B?Zm1uWHo1T2haQXV5dXlrdzlGZGRkSmNscnlOczEyMklLTEpMU2NDNnF0Mnd3?= =?utf-8?B?YitPN0RHVjBSYUpFb0h0QVdod0xDMHc2U2ZIOWxRc1l1ZzNGc2EzeUJpMjhP?= =?utf-8?B?bktVeWhod3Z2bU9uSHlHQU5mYUZTVk1DYkl0MkpSTUIzMkt3R2J3L1FseDFU?= =?utf-8?B?KzFGNVVvdzdVV2FBeGE2Qi9ISXRxbGFMUm1JcDNob2NUUDJibHhMODZJZjhj?= =?utf-8?B?OUY0Q2hYNXp4SUxpKzh4YlNkMkZRTS9mVTNaN0R5WmpyZHFEenloZzhMcTFu?= =?utf-8?B?clFQYStXT1NVYTVJa3V2b3BnZHYrK3ZoN3lNczBqeTcwd1hqQUdUa0lpa0l1?= =?utf-8?B?WDhaMVM3Qkl0MU9lQmsrZ2tvVTliQ053bjkwcVlSS2VZOC9Lc1ArWkNBTW9M?= =?utf-8?B?Tm9tcDZvZ2E4cGJZQmExZklRM2tzajNNK2twamVVSnFlbzhjQjZ1am5XaURx?= =?utf-8?B?YnNrRjBSeUE0aVdqMGlwOGU3VC9idURkVURwWWVwTml2UkVHMmsrNWtpNVMv?= =?utf-8?B?QkRvdGdNd2JSR0dzNnR2anloT0diS0VScVR0bmtXYTR6N3hsakxwZFpZejZn?= =?utf-8?B?ZDB5YW5wclNpaUsyZzhvcUVBdEE1a0NVMDgyOEdtTjFqckppY3l2ZWxweTlr?= =?utf-8?B?b1krL2hlSTFybUFDdXQzVlhsckdJQ250VDFlcXNtV1ZqY3lFd2hBTlZXUlRy?= =?utf-8?B?amNURk9zak52N0VJSUV6REZ6ZnlOWGcrdmVBQnpLa1lQYUVhRGdZc3JQMDNO?= =?utf-8?B?RjNpbWFSK0lXby9takdYRE9LYnQ4N2I1Qk02ODhzSDRXNmNSaVJUbHg5cGN5?= =?utf-8?B?bUVreS9nb0liL0tvTS9CY25KZjlualRBclVhdXI0Mk1LYi90QzdZenpRcndT?= =?utf-8?B?VXh4NHJCZm9QQkpUVmVWeTVUMC9RK3pLaElzZ3hTTlVGY20xbVVhaWFhd0lR?= =?utf-8?B?WWRTS2U0U0lYM0hkYkZrNEVQT0xFemFPelRMQVgxNVlqUDJWa1NmZmZzVTNl?= =?utf-8?B?dEdzNWFsQ21lSXJrcW4wNHhhV3hvQmJyaDU1RlhUbFp3T09ZSS9sTHVkSzhh?= =?utf-8?B?eHFQRkZqK3JqKzRDdXMxMHJ2ckhrekppR1lSUUgxUThnVkllM1prNVVSQjJM?= =?utf-8?B?WllGTG93a1hVT0dUODhLZHZvRkNhS01PN29Lb0F6aVdDZGxYZmwyT2lmYWJj?= =?utf-8?B?L3hkVVZ3M0dKNExRQUl5MUJNV2ROYkx3R21vVUVNVjdoQ2d0UHJXQkJHRVJX?= =?utf-8?B?WmJpdDYzcFBrZTlmOHBONnp1TGNIbG1LdDhyQ0JSQ3h6ajRuUXRhY2lacGNl?= =?utf-8?B?U2Nna1h6OVNvY0dQUGpEUU9nViszR1lVMm9EVVYxTGZsckRVNnZxdktpdUpo?= =?utf-8?B?ZnNkV3JsaGJic0p1SXl0RnJ5dy9VRzRCempteWlpQzg5QTFvVGdxaWthZ1Zp?= =?utf-8?B?TS9ZTGFhT3cvR1Z6T1piejBpcklYWjFXU3FDcmxMQkVDLy85UEpJQ0xsUVYr?= =?utf-8?B?cmp0ZkxOSDRPNU9FZDFpR1gvdFFFckJhWGhkVGEvS2FXdFZYa0dmT1NHUzNm?= =?utf-8?B?bHMxUFFoQjlzMkNiN2hITEhSWmRwWDhndnk0VzIxTXowY1lqTkV2ajQxUlJU?= =?utf-8?B?ZHREZFg0NytCK1FpVWRUOW1qZVRaWEo1QXpIaC9tanJRc2NJdkQzby8vTnMx?= =?utf-8?B?YWorQVdPRjZxeXdJMnp4dU1TY1UvYUlNNWJodks1djk1Y0EvbGhWOWRJQ1NH?= =?utf-8?B?cWRURll2TUhHREVhNjlHSXVUSHc2bzdGMVdEVFFyZ0g0MC9HK3RldXhicHRZ?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: c1j7x2F6a2MKIzx/ZhGzEhn1K9sKhjrJ3nFY4zYKWJoJ+SSksE4TQOpsb45q5pYIuyzFaZrybFfwdywq3qrWF8R+CtyINlhR0U+ubF0dW+43RW70442w7lhrUE5W9nbmp37oyUibU2gsqf4Voe0z3DhHxYxpCIzqywh9Uvs+P0e2Hx33ytjDkvGtCCZ+uHQj/mtkdE+cZWJ8QYH459SNrgeYrCs25MQT08m9Tulti9DEkEPAqTZUUaWu9APaeG0AP2vj1Li7Nj/MBfqzmPm7SNKY+0sDx5mh/Q4WgidXCxOG+2HtCf7VHtt0T0ErgQT5U24EoQQgoh9jtefoX+yp86zUde78xKyVL39+faFcCy6oyM+OVmWayTZAfjsjk2Vuxg7Yma/0uYYnYVte+MgGMpSNrWWb0unKAL3gMjmx+Io/Mo1rJtyhMQJbRM2UFwbaqCTEBd0yy37pVuWphpkrPRX6f5CdP2VMG0gl1XiKkNuerCdtUYlreStyOSMZpaB+T8jgyOWCUkjNwwRwOG4Wafw7vTxmnQ2qID6LKj+7DC/Cyg2CQIxkklwn9sHnTTvUbDWQ84zDVeTwmll81N5W8MM5vCNPiaoB5oaDSn3ZAoeh3KHgDBMB6g3AtUvfLlGGVbWF7MDFv34q6J/ppoWC+WYeqQRTJ1+0+D0Zjfc9eDJWVCUP0rrPBzL8LFLAebLdQC8j5uUlvSIv5UbhsV+Usx2WoSDA8qG0wWEq3O9SmqGlO7OzeGaLuDb1X6+uaL2TIjZOZSl7LibFP+XJ0bMsYGE33KyigsNP4JpiSnmqJTutuALD4AS9/spL2kyMQeKNxMug8kdY7ftRQAos2H2DjrG7O04Yh3a30pNo48IWqic= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c171a25-0952-40eb-c407-08db1685149a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:35:03.8017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HKkjyXIE2n3Gl9B4T4Ug78HwzxC7CdgqxWYmeurxkji2tLaPFXYJ8fzblRCpho+tcA4sQzwQswJ0ZJcSXi6AwHtSdMr+h/rw4xJnqURx1uk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6533 On 20/02/2023 11:51 am, Ross Lagerwall wrote: >> From: Andrew Cooper >> Sent: Monday, February 20, 2023 11:04 AM >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich ; Roger Pau Monne ; Wei Liu ; Konrad Rzeszutek Wilk ; Ross Lagerwall >> Subject: [PATCH] x86/asm: ELF metadata for simple cases >>   >> This is generally good practice, and necessary for livepatch binary diffing to >> work. >> >> With this, livepatching of the SVM entry path works.  The only complication is >> with svm_stgi_label which is only used by oprofile to guestimate (not >> completely correctly) when an NMI hit guest context. >> >> Livepatching of VMX is still an open question, because the logic doesn't form >> anything remotely resembling functions.  Both code fragments jump into each >> other so need to be updated in tandem.  Also, both code fragment entries need >> trampolines in the case that patching actually occurs.  For now, just treat it >> as a single function. > If it is treated as two functions and both functions are always included in > the live patch, would that work? I think so, but only because the first jumped-to label in vmx_asm_do_vmentry is beyond the trampoline. But I guess the question is how to tie the two symbols together.  We don't want to be hardcoding this in livepatch-build-tools IMO. Perhaps we want a CONFIG_LIVEPATCH build of Xen to include a section/note/something identifying "grouped symbols", meaning "if there's a delta in one, include all even if they haven't changed" ? I'm getting the distinct impression that we're going to need it it for the PV entry/exit paths too. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:36:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:36:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501267.772935 (Exim 4.92) (envelope-from ) id 1pVb3e-0004dc-Tj; Fri, 24 Feb 2023 16:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501267.772935; Fri, 24 Feb 2023 16:36:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb3e-0004dV-Qv; Fri, 24 Feb 2023 16:36:30 +0000 Received: by outflank-mailman (input) for mailman id 501267; Fri, 24 Feb 2023 16:36:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb3c-0004dI-Jy for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:36:28 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61faf62e-b461-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 17:36:26 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id n2so15350889lfb.12 for ; Fri, 24 Feb 2023 08:36:26 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id m22-20020ac24256000000b004b57bbaef87sm779882lfl.224.2023.02.24.08.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 08:36:25 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61faf62e-b461-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=PBLNpcztKBOquH/6KGWSHcSNv1WI6wUvaGKzulw6zwQ=; b=X34w8upy/2GpRTobrlMAaUnzAnpV5b6aIxQf49IVs5ywY2fpIHqp8GTvwabs4Z0BZi vYhLpEmpIKL2qLKVgzQ22UBWMVHZxZxLTO/VYTdoQ4pyk8INds1JPDqAswneuS+BfdlC 0fSDSNP+md5NAZa0+pGYr1vUZzfMKDLYr89g4unNYvDGx63HiLqBpd5rV/TgteDK6Phq tZltlqrHjGpZTLVgp+OJNOo2feU5hjz/oml0u+fDL4YYeZ0eptcGmwZcVgIruO7c0mnC nlgiNy9mG5B5xaMvLpxCDkyeZSwInuM+o9bFO33Nzam9HIN6QSFgszshoblI7qThpovv suHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PBLNpcztKBOquH/6KGWSHcSNv1WI6wUvaGKzulw6zwQ=; b=D5oKkzPqr6ClOsOhO252Wfwlq8sdPuKE960WkArdx9iDQOuyPH7urzkHiTAypy3xkT BMEOsE0KOGzh+SBE1AP0vHv2+BRQq1yMfoZ5yIvA4ldWa6R1ql9aVb4MdSPaL2C3nPfl jbZkZTJV/1qIh2++S4AEC67UpvBUUWR968ZyfmY8arLJ9Q66TbU/LJetXSX47hIxQ/b5 y0ZGRcWafOotdyilFxFMZZEGDhM/wt+dhy5/xs1w7YrRjhrG8UCDflrL9lIgMACPJc09 t0Yd2b/6xkHaF3nGkaoIN1YFU9d6dM7KGSAyeKLJOZYbB68S5lWpqvdUGcnQqANhjfQP Zb+w== X-Gm-Message-State: AO0yUKWM4wKGN6px9rP//VMN4xPX0zjzweiUljyvXvsLhUpj+C1cER+7 xS0K8WPWI37q0lyUbUO38vI= X-Google-Smtp-Source: AK7set91lUBBwja1Vlta0EtqwFBC/CczfT5ORO1z9xzofAxIPYo58GZ+nR9nIZy/QNisf93Yvydx1A== X-Received: by 2002:ac2:4479:0:b0:4da:ffb1:9872 with SMTP id y25-20020ac24479000000b004daffb19872mr5844786lfl.4.1677256586178; Fri, 24 Feb 2023 08:36:26 -0800 (PST) Message-ID: Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Fri, 24 Feb 2023 18:36:24 +0200 In-Reply-To: References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote: > On 24.02.2023 15:48, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0xen/arch/riscv/setup.c | 12 ++++++++++++ > > =C2=A01 file changed, 12 insertions(+) > >=20 > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > index b3f8b10f71..154bf3a0bc 100644 > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) > > =C2=A0 > > =C2=A0void __init noreturn start_xen(void) > > =C2=A0{ > > +=C2=A0=C2=A0=C2=A0 /* > > +=C2=A0=C2=A0=C2=A0=C2=A0 * The following things are passed by bootload= er: > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a0 -> hart_id > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a1 -> dtb_base > > +=C2=A0=C2=A0=C2=A0 */ > > +=C2=A0=C2=A0=C2=A0 register unsigned long hart_id=C2=A0 asm("a0"); > > +=C2=A0=C2=A0=C2=A0 register unsigned long dtb_base asm("a1"); > > + > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a0" : "=3Dr" (hart_id) ); > > + > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a1" : "=3Dr" (dtb_base) ); >=20 > Are you sure this (a) works and (b) is what you want? You're > inserting Oh, yeah... it should be: unsigned long hart_id; unsigned long dtb_base; I did experiments with 'register' and 'asm()' and after rebase of my internal branches git backed these changes... Sorry for that I have to double check patches next time. It looks like it works only because the variables aren't used anywhere. > "mov a0, a0" and "mov a1, a1". I suppose as long as the two local > variables aren't used further down in the function, the compiler will > be able to recognize both registers as dead, and hence use them for > argument passing to later functions that you call. But I would expect > that to break once you actually consume either of the variables. >=20 > Fundamentally I think this is the kind of thing you want do to in > assembly. However, in the specific case here, can't you simply have >=20 > void __init noreturn start_xen(unsigned long hard_id, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long dtb_base) > { > =C2=A0=C2=A0=C2=A0 ... >=20 > and all is going to be fine, without any asm()? One of the things that I would like to do is to not use an assembler as much as possible. And as we have C environment ready after a few assembly instructions in head.S I thought it would be OK to do it in C code somewhere at the start so someone/sonething doesn't alter register a0 and a1. >=20 > Otherwise again a style nit: In the asm statements (not the register > declarations) there is a missing blank each before the opening > parenthesis. >=20 > Jan ~Oleksii From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:37:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:37:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501274.772945 (Exim 4.92) (envelope-from ) id 1pVb50-0005Cd-7m; Fri, 24 Feb 2023 16:37:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501274.772945; Fri, 24 Feb 2023 16:37:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb50-0005CW-5B; Fri, 24 Feb 2023 16:37:54 +0000 Received: by outflank-mailman (input) for mailman id 501274; Fri, 24 Feb 2023 16:37:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb4z-0005CQ-G7 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:37:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93c94f87-b461-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:37:52 +0100 (CET) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 11:37:49 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6179.namprd03.prod.outlook.com (2603:10b6:610:d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 16:37:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 16:37:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93c94f87-b461-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677256671; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=A2ltDIxK0Z7OtJP62qJfsCpYbJWpsn/uFvhECxWTVS8=; b=Nbuy8MchyaZiLTn9yt5JMaBb8RBJYEqaYqI+h5mvJOV0i+4degA/9r9m DKybyysn8GRGFFozcbc3N6vzJZsnERNCumhUAWost/xnynIKcyCyCOPMI 7JQbkL5IJln0olnpfhOZqE7LtuviDzpGdWiZ0fOrTcW6Qu2LaHvQnBols c=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 98347659 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:sr6Ei64JLAqVmCOZqPXCdgxRtAnGchMFZxGqfqrLsTDasY5as4F+v mVKXWGHbvmOMDejeNh+aozn9UlV6sPRxoQyTgJqqy5kHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 8MCFBAyNTG/oOvo37ziae9n3eMvI5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNCT+HnqKM76LGV7kIvECEVW1eAm9eC1nOeV+AGB k849DV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqeS4BZRsI5Z/kuo5bs/7UZtNqEarwgtirHzj1m mqOtHJn2OpVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:njhBQqqtYpSeru2i9zOW3DYaV5oWeYIsimQD101hICF9WcaT/v re+8jzsiWZtN9xYh4dcLW7U5VoLkmzyXcY2+gs1NWZLWrbURqTTL2KhLGKq1eMJ8SUzJ8+6U 4PSdkbNPTASXR8kMbm8E2ZPr8bsb+6GXmT9ILj80s= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98347659" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPl2E8nLvzFGXzWIW4FeWnj7H6jZ9oxR4ASvsNShwFIk7GuLehrqHVNURv0aX9KOZ4EHUxOH/aCsHfevM+Mq3IbqDdNFnhDdxJW4VLZiVZBNxs0eXiuRMZzrkUFd2JZNqsFjK70nAOUJJ0HGI5jtEtaaENjyhKTytk5vdK/vlYdCnQyQ6NJqt297PjL24tWNx24Zhp2lWCM8IKqFYxVjRY4KcMzrf/bJYmAPs9ekBunCxgZkkMTypoVIyhu9Cs2lL+dcBvLOqVI+VggGa31Smo+HEraDG4Xs+yI0sbNGmCvYRN6lvJ1DmoRMJi+bk7Gj8nTgxDi4Ow4A3CvaHY9iPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FgHb+kl3c343dpaFQUqBPUninPZYgF4SgVkufcJ8BjI=; b=lYyGagMrRQfcyRNz3m5ptWl60l/250w0WVejc97l/LHDjf3UHe+uGaB9z9uhC78gv99AbzFEO8OF6jUwhbksR6YZHbHQUkcHQdRSv87/J1CnHyQJgjLj60bT0oWFUEbrJ/ztPv5ML4gSs1nlX0cfj3+z58b39axr1qINZTT5EdSGVVuRqnI0PDUDTnfTz6Xmy4DYyyjZ0l4EAAwwel1NcxowsjL5oYtaUKSdoOjZippCQ65WU9JpA8owyL56yymDC7L4soj7TVwoOtl6ewWeYPxfOqDJJsT2xBSk+pqgtzwAgjfP+pFrtyYyEf0BZVMOeYJL07j9jMS8+pSfoqJFqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FgHb+kl3c343dpaFQUqBPUninPZYgF4SgVkufcJ8BjI=; b=rY6FngsAkT9YRLOy63sExAGqU4jRz+8DJgqsHijJ+9deqNtiYHa4SzWzAZybr06pzliG9RzSadEwmUJJf1hWa6hGRA1yVNRJJC3CQgfwzi4BvwOvN4Ppe61TGGEuvTqBkTnydEyAPot1SGZbQtmSyqCp764Y3eM1BbUjunLrUaI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 16:37:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2 1/3] x86/shadow: move dm-mmio handling code in sh_page_fault() Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <0e682cd4-3cc0-461d-ee53-13a894797f17@suse.com> <5d8a938e-cb4a-a989-1849-d702cd25d890@suse.com> <1d4848eb-4b99-1492-45d1-c0ce2b0ae6a6@suse.com> In-Reply-To: <1d4848eb-4b99-1492-45d1-c0ce2b0ae6a6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0203.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6179:EE_ X-MS-Office365-Filtering-Correlation-Id: 88ec776f-f633-48b6-8289-08db16857555 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M7whaxct48Gnwk3mftRcr1vSyTSKDCdmzrVZgkHoa1tkZJSyBWYlixxaBqZaUnIXed/AiikbuFD+mJvMmGn+/Ilvmc7RP66RdLsZ7oQcpG3pwfXU3Rd3/rMiMDu3hN+AxopbyAb/AVSsNM6aYunikwgmPqsZCtK00qKfM00J+wxGFgHbwSxhCvmPHYGhAvTRVQpN0+vEVNZZyM+P9GuO5WaD7kHPndvx9fnNLAMG3VH91TPLt8FbBZ7h4ZUbh3oKEV9y0mBXB7reMdsw6aQqmymr1zxTe5onPlkFbHh2RPEZ+CfqKtJeLt5ClwcfJGDeDpxMYNPEjEf+KRW0U6YE75DJnm25LkO+6p7tP8zCHDLGqX5uvvaw/E/6nF81bfcF+nsq2NM05SE708vfZlHxgcUDUzYxZmDbyIWNWtjR5s8jFKhrXNgE322hhcVHaHjQHvMn5TCI2Ckg7qKlahUqV7qN2yI0xqYh12Ww9JZXUGjzSnBihizvFIqE/ARkYg90pGHbvyk3UGINBHLgLHMqtU+UrZcvF9biiaZVNN0/eF8+zNc0oVWIviNHL4HuW5RLdsDQqPJnHZBujOWriAcDxZtlfCsG3sU5/IDfqhe1IDPcAfRN5XbAJ+dvzSv0FQVAlG4ihN4ZH7D1k3+kiwVbxrAqxQUGBGQvyvQkTQ1kd5iaPBcmpZ/lV3DL1JYWQA4weWxU55Z7U5TYfQZ4ldX1xCuvSwMYzpMaPzWiJjbA7KAfgubPwtV6I1EfN+OaEp6DEMyLEFmLpLCdHWqPyffqHZis1CA70E7aKL9Yek3EaC7IC4C/hLsimXb1o7odiIAc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199018)(31686004)(2906002)(5660300002)(41300700001)(8936002)(66946007)(83380400001)(66556008)(4326008)(8676002)(66476007)(316002)(107886003)(36756003)(186003)(6666004)(6486002)(26005)(478600001)(53546011)(6506007)(31696002)(38100700002)(86362001)(2616005)(82960400001)(6512007)(110136005)(54906003)(45980500001)(43740500002)(473944003)(414714003)(357404004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmkvOVdOTVhTRnBQMVNrS0dYb3FDY2ZvSnpHbVI3NmZXRFJZR3ovcDVocmYr?= =?utf-8?B?ck0rK00xcExuZVZPSUMwdk5UR2syVDBDNlVMNko1L1NPeGwrV2R4RTYzOE56?= =?utf-8?B?VWYxMjNNZXZsR1JoZ3F6U21LODZDQ1N3VUR0NjJkVUVRUXdqZzZhbDJ4WFdD?= =?utf-8?B?RmcwLzc3dVUzS3Y1NTdVcEN2aVZmSlNpeUtTWG1oWW0ycHgwdStwWis1Nloz?= =?utf-8?B?aEtMeDVXOWVyZHFhT3VvRFhNekl6WFFVUHdtSTdhWW55SFNUMzhEeHhnRDFL?= =?utf-8?B?M2QyWDNZVjBldmFMbWMrVjRzWEVBSnNjbkJKZ3JURERpY3hJblh5Y0pZdHZE?= =?utf-8?B?bkdlbVpqV2ZPRit3c3ZNVmphT2FWNXNrRW5TYWRiakNKa2E2OVVsNDA2K3VI?= =?utf-8?B?T3FaZjNNb2lTNk50aGNMVkhWdGdvVThZanArbmZGZnlPV09XSmRUUlM1bVho?= =?utf-8?B?b1FYcUhWQnNFaDdvTjBva2YvVXhsSnBBNWZ3eGJ3SlNKL1NXOEUvQkFKZzUr?= =?utf-8?B?TkZjcjJCRWVyRUhCOVBzUFdUTFVvd1QwZUFVMkZNd0wyRkJXS2J1cWplQlIx?= =?utf-8?B?QVNWSmJSUDNkOFppMGRZWFQ1dCtZOTBWZDRqWEJ4WVMzcTZGSE5tNkt3SXNX?= =?utf-8?B?NCtoLy9FTWNJWUU1a1kxeUhqa1BUS0pmaHFCb0w0TU1MbUl1MVprWEd5TFJW?= =?utf-8?B?VVNydDh4L1JXelRPWFp1U1Y1Z1JUUGsvS2NYc05OZkQzbHVza2c2aVQ2aWVn?= =?utf-8?B?OWQ1ekdwWjBNM05SRGdnbDRZSXdrRlpLOXlVRWVXUHJyR0N4VzZNZit6cXg2?= =?utf-8?B?eVhqaW52cWpmd29VRmZpekVrcXlTRm52NnNzU3VHUFI1emNzNkpHY0xLcGxX?= =?utf-8?B?aDNRTlVON0lQRldFWldvRkZkcFNoTGpoZmpLRytWZnZVZDM4T1I4aUR2cEwy?= =?utf-8?B?Ymk4VldLWEVvK3JwM3B6U3RkeHJ2NW1GSms4d0pBb3p2ZFZNdFZ4ejBFS3o1?= =?utf-8?B?UUpXc1h6RFl3MVdpMGliOTErbnBuaS80Q0VnOE9XM3B1SXk5MmRpeld2SkU1?= =?utf-8?B?WER5L0pxdUhaTUVPdTByVUcrQUUwQVNDcnpSREwzWlRnZWcxYm1oSjNJSnhi?= =?utf-8?B?TDMrMzJBS1QxakRDaW5vYzhSUktxU0ZWR3dyZGU0amtackc0cUhHREliUjVY?= =?utf-8?B?WUc0MXZmVnk4dFVEelR5elE3eXlKZXBXdklLSDU2ZWdCcVE5ZUdvV21yZVZq?= =?utf-8?B?TmZjUlFPQUFUWlM1VVBBN2pwaDg1eDFDV0pDWDg4RU9IN0RQNEVJdEljYmpw?= =?utf-8?B?cEVSZVRad1BTR1RXSG5iMWFLTmM0Ym9xVEpDOStYaW1KMUtmb0ExTGs1MXRI?= =?utf-8?B?eFZCNmhuSENTWDZGazQzVWRTYWM0QThPQUprdWZFZ2w3WW1pWUNrZTFVL01H?= =?utf-8?B?WWJ3bFc3T3RTdFpNbEYzaDlieEtKQWlsN1VBRnYvcDhvUnVWRkVETmZsY1NJ?= =?utf-8?B?MEZoRlBrTytkcFVnMmRDb25YaXpaWnFlbHhEMGR1U3FocnViNGFvV0c1akpm?= =?utf-8?B?eDlMa1hsNmdVaWdMMEVCS0lwTlZjdzdjK3ZUWG03NkIrYWlnTWdvZnU5QnlP?= =?utf-8?B?Y1BTS0FSL1RzNlRKZUM0eVpZTWxoU0tBclVtMkZYNXRvZ0dKbHVMb09UcmVp?= =?utf-8?B?YUZwSURuK1JrVXlia3FtUG04dmFoYXdpempoUHlQbE9wZUNiM0dzVWYybUw3?= =?utf-8?B?c0NIL3VlcGdWMG9IOUFhMnZWR3pkaHJWd2t4Mjd1bXljdTZscEY1K3UxUWtL?= =?utf-8?B?RG9qbTZwV3lwQ2w1TmxJR04zNTlpQ0VLcWRQYWJ3eDBOcUw3ZStBSjRaSEw3?= =?utf-8?B?MmJXOEFzWkxSZWRCd1FycjRvd201a1l3MllveTNPZHpCYi9HbGI2dU5LZDdW?= =?utf-8?B?MlFodUdhaE9LUjRSVks3LzBpMEh4bUlxOTFsUnpJR1dzOVQyN1IwQkpQOHZj?= =?utf-8?B?bHdsSmdmTEdrcUFzUVZZTUoxYS9VMHgzYWJtZUxsNUQyOTVzWTNpbmNmWHdF?= =?utf-8?B?UG5ibVZtOVh3Nkt2WEZ2Vll2REo2OUF0dm96RTl6cXRQeSt4QTFydkRxWitN?= =?utf-8?B?L3o0OFNPMTFJcndGeTF4UXZEVjk0eUU3dHkxbFl4ek5HMXc1V0tYbFdyMVRU?= =?utf-8?B?SXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /I1rwimKw9Fc6+dAlhvkjghhv6d8DHTPrI4a/uS/bVmU/iIZkXZ8he7XLbcfm+kw5fcuUAV62SxiG07eZJDa8+MCAH3G2yKRYzD3HoWRP3W7l7fPShF9ql5JnjqDJJbret54AVvVTvWqu1BsGRlHi6g+9WX82Rh954vXlF0uA0qwF8GkuT5kz79pPxHsZErqVOk8Av5ueSlBQtFGWnnzZktB97qhRq078ljljBAoAnafW2e9l5dg5rovxu1VbZkuoHB6nLgrUNmTVHt7D7/r6xCJxUkIXWfQwPv3AjGF1nlvYUb57wMTu+ljWRnqurN7MuJ8lxmAs+P5h6a1UkD5Z6NJV1Stejrumxx0Uuc8aMk+eJXg3JYHkPGxliLQavbIq+MexFJsqnQlDxKI6qxrCYqIllfSdtZ7TY/ARMNT/J94+7SBQc4UGeaJCcRPiBFRMO2kphC6MFuD5OY3hUWjJbI77O2HeEZG+SSK3HhXiTCZj2oJe3TtQ+R6KAXjqerqpjSgcxXPQKjqbueQe0Ojon5WnbS+n1dcAbisYdE1ZXM/iYcH5Xw5c1I8iB0NC3htNkV6eqz6jrq5vh3bJRJEwWtpQfTznBS/4RvKmd3ApIrsgMH+1SpNSBMONflpjaJTTxfASg4aDbQXqD2vegPG6LorCr72K1un0WUnRt9zU9sjY1yt1ChuSgVFtnv/TtZWqaEs/OskksB0kcJs04J0LJsuwtnrarL2OokLFGNMnfw/PSGV2vmbEDFIuVKriBB7ljJ1qmj1NYTdOfwfchBOpkk74oZJUtGTEmqbRE+Z2lkPuLfxowpDuay6EM9r6JwG X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88ec776f-f633-48b6-8289-08db16857555 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:37:46.0556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w7GFaFv5Yd/hc95zVvazGWQsJj5lMmU3TLxsY0saYaD+F61p4+MBxVc7zMWpxgvNvu1mXn0xxRyr/LmynOGafLOY/BGvGdgow5b6SAQhquw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6179 On 23/01/2023 3:08 pm, Jan Beulich wrote: > On 23.01.2023 15:26, Jan Beulich wrote: >> Do away with the partly mis-named "mmio" label there, which really is >> only about emulated MMIO. Move the code to the place where the sole >> "goto" was. Re-order steps slightly: Assertion first, perfc increment >> outside of the locked region, and "gpa" calculation closer to the first >> use of the variable. Also make the HVM conditional cover the entire >> if(), as p2m_mmio_dm isn't applicable to PV; specifically get_gfn() >> won't ever return this type for PV domains. >> >> Signed-off-by: Jan Beulich >> --- >> v2: New. >> >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c > I've sent a stale patch, I'm sorry. This further hunk is needed to keep > !HVM builds working: > > @@ -2144,8 +2144,8 @@ static int cf_check sh_page_fault( > gfn_t gfn = _gfn(0); > mfn_t gmfn, sl1mfn = _mfn(0); > shadow_l1e_t sl1e, *ptr_sl1e; > - paddr_t gpa; > #ifdef CONFIG_HVM > + paddr_t gpa; > struct sh_emulate_ctxt emul_ctxt; > const struct x86_emulate_ops *emul_ops; > int r; Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:40:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:40:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501280.772956 (Exim 4.92) (envelope-from ) id 1pVb73-0006IM-Li; Fri, 24 Feb 2023 16:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501280.772956; Fri, 24 Feb 2023 16:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb73-0006Hm-IC; Fri, 24 Feb 2023 16:40:01 +0000 Received: by outflank-mailman (input) for mailman id 501280; Fri, 24 Feb 2023 16:40:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb72-0006Dk-Bk for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:40:00 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df36389b-b461-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 17:39:58 +0100 (CET) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 11:39:55 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6179.namprd03.prod.outlook.com (2603:10b6:610:d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 16:39:53 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 16:39:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df36389b-b461-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677256798; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=2Emg39pTfnI8nhGWBdriWGevupgKdOb/6oGg39CZ38c=; b=RmGXntP7olAly2z56x7VtfSrJ4C436GPe54vdnGXgXkBH0kjrfY6O4e7 bexnZ/NEJJQG9JXv5+cuGOCBgabq/WRnGz+FgiNa5/JsWmeC4Mv8XpI0c pt1S7GwVxh29V1NXM49sVmVwfzP1aqcKrxDmBq/D/JBFRfBjedLAw+XL4 o=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 98440680 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8pHfUaL3sudoiLGqFE+R4JQlxSXFcZb7ZxGr2PjKsXjdYENS1TBTn zFNXG3QaKyOa2XyLthzaNm09U1S6MCGyNU2TFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c52IjFk7 qwmGgoxazedm9Om8qm5b+5z05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHOnBNpMROXQGvhCrXjO2TY4ARsqdUqEmuGnkW2ge8xNA hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9UQAJLGoqdSICCwwf7LHeTJobixvOSpNvFfCzh9isQzXom WnV9m45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 xDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:5GpK9a9lqNaHEYXvx2tuk+AVI+orL9Y04lQ7vn2ZLiYlFPBw9v re+8jzsCWftN9/YhAdcLy7WJVoIkmskaKdg7NhX4tKNTOO0ADEQO4N0WKI+UyEJ8SRzJ8/6U 4ZSdkGNPTASWFgi8D0+Q+5FMtl7uWm3cmT9J3j5kYodBptba546Qd/F0K8KW1ZACd7JbdRLu vg2iJgzwDQAgVpUi1+PAh8LpT+m+E= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98440680" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYQ6zhl3wu7q3PRVzDhqPP41GtQnrp7Ktp9h+vC5FDMXXAh9/xiT7d09weiN9Z+XkYqXJx5AJItHu+BBBLcpMMNaOuRJZrW7xCMv+wzU4C5KQMdr8AFapzSGsLvSzAA9/mHLNuZRk+D1LA9bj8dCCkDJ1y9/QaAC6rNcu9G9zEleZG9hYz1b4isNq4dHT0Y8oH5ftQ8GY5IvD+8kkphGOC4mZQ7OCYS75GiVyAUfBU9WQ+PbOwgiFU+BZhJoVJ1/Ip80Kc6YcYFrynkmybkxDi1hIinev1ulDdAnyAkxsX3w/VSKD5p2+G8Zg3XMY1MPrwZsb7wTdpvLyE/ziKe0yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Emg39pTfnI8nhGWBdriWGevupgKdOb/6oGg39CZ38c=; b=arTe3EkTtfnb0r9S5dv0iBYxqzWrx+6VS7s1zbmG30pGr/iLQ7Im1Itm4a9zl76xuVHO+Z6PvGvCanbpPs3rJt80CTlRkdvgEopw4lBIejvkVl5b7LmdFDygPEZY3uoJORveMD2i7ZYlM5fE55pS46dMkHGta9BYR2V5LoW5zI1zakUguzPUGrgQ/eUfK0u32v+qTO5zRaJZh0/Fk+ZtjAYN9ZAOta7iZHHMqbfanCdf265HoYi5k7cVJ3+P8GxUtaa3ws1RqU8liJttNwOvUeaUsSSbEPfQYFoH8n6CVdC5MK1WKp29+CAvBtib6i5KOFEA/FP86GZm1+Mop0rroA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Emg39pTfnI8nhGWBdriWGevupgKdOb/6oGg39CZ38c=; b=sduhoM2XgTNSkLEeRnBzzEq/vWlx+OfsAeydcguI9IpVogkMINaQ/bGL/o601n7yYf6pe/g/PmnXyeE2Ue65jsSR7+lRb6IzZiUJB7dPTswlrb0xNpPDOI3037hM/zJP2K3ltaMAlFoaryC9qMvXmSphZCLyFOX8YCdrxiRHflE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 16:39:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2 2/3] x86/shadow: mark more of sh_page_fault() HVM-only Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <0e682cd4-3cc0-461d-ee53-13a894797f17@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0672.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6179:EE_ X-MS-Office365-Filtering-Correlation-Id: 8de4b087-da1a-4ad2-4bed-08db1685c12f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BXLcZKtzHhxPIjHJ0b3GKGq8abLNIsBqTcRhbJOKuCLA3UfTo9G2md012oDaEoU4TkeR7WjAP5yzMB76KRqOJWeEfwximHKHAEBmpD6cCM1Mg8ouI2NikmZxMcpAHAT5o+DcHnLM3vsXNtT9FZ17G2iyujtGNK/UHoYLwlfGfVhSopAipJu4uFFCDEEGNlc/EThD5J82sN1z92BZ0azPX+b4O+OZ5NwEFsxq4sF/78XsTRRrOMTGkD2dKlOZJsIUcxip/8GeMYQQL0f7iDsa/xaElYNho59hrsQquT51Ohmh80teyhMGO5/cDQDZTNRmR8hIOplo0KthPIgvNMqiR3lusEFaUbUPmDsNcmxnu9MEXEhu2fkOXCQXgLlqX76w2ZOVIw6Sq9jZIbXb3p5WIz1O2m28mUEx0aB4zEIt9UxFiKmYVtPaUo25IVwB9B6G5BgyETSVGQE7EkL3+srZTfdWa/sx1u4NEIOYQOvMv7xMOgOKvpb8brUqsfwsAinUVn8kJNdye6J2YE8h6stHYooJ+QvUfiRdoXDKhezc2xAGXn6v9XT2sdyeAyBWYbCpxmXlBMIwzSrwaVbJAi+Dc39QNtvOWblSny2qgFeuIAMlSogwEVPOoa0oUFHieG+N8UVdHHG2wovjMmSqESTlSc/xAbSF3em2gYqFzm/tobW4tW/Q0nk4GHUVCfZRPjwcu4aOBdc9HeC/C/RhilqduZHGKL+zIz1lRo+3jEFVgNU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199018)(31686004)(2906002)(5660300002)(4744005)(41300700001)(8936002)(66946007)(83380400001)(66556008)(4326008)(8676002)(66476007)(316002)(107886003)(36756003)(186003)(6666004)(6486002)(26005)(478600001)(53546011)(6506007)(31696002)(38100700002)(86362001)(2616005)(82960400001)(6512007)(110136005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUNGRHlySVFwd2hkbXFleVVxeTYreVAzdHArZXp0eHIrY3RzSGQ4aDRDUGMw?= =?utf-8?B?RGdaeFRIWEVxVWR2MnBRK1Iyams3b216a21wYXAxWDVacjh2L21taThZVDY4?= =?utf-8?B?QWdjQksrSzhpUWdqRmc4T3VWaE1BZzBjU3Q5TndHV09DWWdCVGgzZ2FoRFM0?= =?utf-8?B?NkNIQUxvdkUwcThBK0NjOXl1SjlSWXcvTW5YbGUxcU5Vbi9xQjQ3TjZZZ0Fs?= =?utf-8?B?Qmd6eHNrMnJ6c0YydFA4TytoTDdoekhidHd6a3V2NUMwVFVGWVE1eTJKQ2h6?= =?utf-8?B?WWdxNGk0dlYyS2hPd0dxQWJIbWxSRFVoYUM4SERPMmV3TEpqTC83dHhveTFW?= =?utf-8?B?a2VUdmJhcU9CdEFiTlVsT3A1ZWtROWpGZGxuWTEvSVYvM2s0ZWdibCt4cGtB?= =?utf-8?B?U3N5NGk3UlVDUTliN2JWY0ZmUUFIUlN5YUZxQlBjWldjdk8wZ0txS0dnRm1R?= =?utf-8?B?ODNuTE1INzQ4MmtEMGE1MkFYV0xrUjBFakRCQVQ4RkFSZEZ0V2RrSTlvSnU5?= =?utf-8?B?ZVEvZTlqTzdmSUgwWGhubzhod2syUnVOdHJjbkVhMHJ1d05Db1RMYnJoeWgz?= =?utf-8?B?K2lzOGtQdHJoL2Y4Um5aQnV5SW9McmMybTNOQjV6c3hDamxDNHQrWW1KTm5l?= =?utf-8?B?Z1FLZDBWaVdyTzBBVWpuOTJ6OW5BSm43VFh2c2VON1FGNjhsMVJUSzlkVHM2?= =?utf-8?B?QkZpMUpTUTBSdjl1empZTklaaG9QUzY0LzErVHFaaEFzMHAzYzQyeVVORE92?= =?utf-8?B?a2llZFo5SHN0SVE1T0FEVm1yRFBYS1AyTXlnMTltSzNrQ0dSMks4VE5VdXU3?= =?utf-8?B?Y21xQkpZdUlTTkNjaHI0Zk9jdjB3SDAyUllsQlQ2bmthTjd0SGJPTUhkTW9K?= =?utf-8?B?TzBCTkhjbWt5SnpHaEd6MWJmaGc2anZSRWNjdjhkY3RSaXg2RmJ3eDVic0dU?= =?utf-8?B?Q0FiVXVZalVMY0lxeFcraXkvR3hYVDFLZWNudEJEWGtFWlVNWHljZGliUzRW?= =?utf-8?B?aEoranFwZjkvYjQrWHZEZVJLZHpDVmlsV0RZTFJnVmhxWVNtQUN2RDdFQkVC?= =?utf-8?B?MGIwOE5LSEhMdXZjY1EwU3EzTXA0cDVSZGM2eDRsZHVWd3JZNjlzL1pTOGxr?= =?utf-8?B?d1FQZnFWZnVWYjNVL2pmZTVJNU9lUGNSVndTOVY1RVhjTFdIbFRHSzA5VmtS?= =?utf-8?B?L3ZlRk1GZTRlRjVVSFdmKzF2aWZTMFBtTDNuTFBHTDlPNmwzZGtWRXVneUV1?= =?utf-8?B?ZElFRGUxOUhCREVBYTZkdHZzWjQ5RlhmYWxIeGhpNUFMOERSNWh2QUh2QXZS?= =?utf-8?B?Mkp3R2VRd2ZIREl0c253Uzd2eWRzMTFVSGJZcFNIbWtlMUovUEE0eGVjYVJ1?= =?utf-8?B?OFFxbWlVNFZBajBLYWRxb0JLQlpnVnQ4bUhPMkVLNmEwQ0RSRjZ6RFd4Y1Zo?= =?utf-8?B?bFBLd0lZQVUvRkwyajByenBzbEI5bCsyNHQ5YTUrRkxsK0t5a240L3dvdjFj?= =?utf-8?B?Wkc2SEltZURJdDM1eUZENDJkV0NLeWcwd01lVnBmQXBKTTB2ak1IcThqWGg4?= =?utf-8?B?NVFuRGlVUStpWHRwYmtUaUJaZC8yR0N4Z1IrM2RnNzZWaDRtdlpNNGNTWC9M?= =?utf-8?B?TWRyc2k1RUpOY0RzbVhJaDEyeGFLeGRXMDdzUU45dis5bWdDeUxjMU1qYnpW?= =?utf-8?B?NW9YQjB1KzNLcUdWWmxSUmFwekczSjR4QWVhenBpMVgrc0dXTm9WN3hvZzZG?= =?utf-8?B?UTVDWmFISmVsbzVGVExULzJtRWNIODFub0VhOUNGMTlkeVpha0VKZ0ZvczVM?= =?utf-8?B?T25ZamZ6ZGMxVzJCUWkvZWkvL2Rucno3SnVoT21jRFZUb0NQb0JtUUMrVzVX?= =?utf-8?B?UkF5WjhMcmZmRmRyWkNZWWNLcnVNLzV5dkdPNkRteVYzZWtFdk1JaS9rT1Iv?= =?utf-8?B?Nk9lZVJqZ1FCYlRLYnRDb1JPOUNmOStKeWw3bGFhVUZRQXdRWDFQeTkybWtE?= =?utf-8?B?OXBJa0tpMVZQMjRsanlIQ2plVS8xYUJrVHovWnAwc0NTVDM0QTZidUNLMTFF?= =?utf-8?B?WG1EbzcrcEZ6YVpCaVgxZGpOMlJIRElqRkJGSXY3RFQ2aWU0cDkweWVXaFpH?= =?utf-8?B?RkVKL09BS2ErSG43YUtIOG92N2pnZ0gwbXN1WHNyWnpmQW1TdXpsU1Nwaktu?= =?utf-8?B?L2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CtI0ihkvHUqpo9xJi7HdRxDCc3I60DcYvtRpdXbrlr5K90PkiQuRs5Gxk3xene7DrLU82SE66ELlLGdqC5L3/3i7tHJ+GeetjR3yiEvamUSUJHnv0fAJVhCc30trU6vptMXR3eezECkme2wZ19DhN7vARRc92zFGNDlm+e3h6MiwMDaYMwOkmk2J1LgWvo1NLFMDnDbKrl+/UWqDUDhA3YurZEzr5p38xtXID2yIlFfks+s0UD+JGM5s2jv3PW8BcLnuZfvt7cZgIFkSSTzSmdwXoTHtZJbrxSkb2FfQHInshtkmYLrmQuAD1NVPBDifRDYL7s3Fw99eMUWXdO9wconzRhYDQv0HNWwLNhPUSg0WsCddpQ2MBLIqhFbcQJtPdqYKqWQhlHLPZ3eQeWyd4g6ANFqy8RQZh05ahGg4/9qLanFbARqYELl9uvr4siFCSYCdOpQBSWvq4Y0krNVqZHkE64yoPqkrtIzFLteVqQOnNHZHPmn/CD5Y6vxij2Od0jESz4Dd5c/5SSndAtUeamnfYvufTy7qfPwi1qQBjqyITzK0XgOs2M0Ri7WJeoxBwMmBj+SsYF8rCswgb8hka14J7R5R/UKCNv0SxiuDOZYyqCssq7rrUAngjwILk0El28lG0+eDtdJnaWPSVvbSNXott2v41O0lFJQ3H7MV9jXxBA7IM1ESnS6jCkeVP6Ku/6SXhKartQQ7xJr9BTTQ1gfUwjHQKixF5jlwh1PMNg/ZtCvigGpqK/CQWRGxVUggbUSSIS37SEXo03+Gp3067EP1d7WbOSf863wdkTthZbJxlQkdHVDECzb5zpnjb3TQ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8de4b087-da1a-4ad2-4bed-08db1685c12f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:39:53.3120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 30ZeCq9idx3hbPKdB+5JO1QWnFJ8mJaHt9U8e3SH9fkMe2aLxITRBkfaaTY+SachDJXFl6ryrSSvULLrDZrfKhtsH/wqoGkoHnhzy2+tlis= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6179 On 23/01/2023 2:27 pm, Jan Beulich wrote: > The types p2m_is_readonly() checks for aren't applicable to PV; > specifically get_gfn() won't ever return any such type for PV domains. > Extend the HVM-conditional block of code, also past the subsequent HVM- > only if(). This way the "emulate_readonly" also becomes unreachable when > !HVM, so move the conditional there upwards as well. Noticing the > earlier shadow_mode_refcounts() check, move it up even further, right > after that check. With that, the "done" label also needs marking as > potentially unused. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:41:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:41:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501287.772966 (Exim 4.92) (envelope-from ) id 1pVb8J-0007fZ-5t; Fri, 24 Feb 2023 16:41:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501287.772966; Fri, 24 Feb 2023 16:41:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb8J-0007fS-3J; Fri, 24 Feb 2023 16:41:19 +0000 Received: by outflank-mailman (input) for mailman id 501287; Fri, 24 Feb 2023 16:41:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVb8I-0007fM-02 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:41:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e15185d-b462-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:41:16 +0100 (CET) Received: from mail-dm6nam12lp2168.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 11:41:03 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6179.namprd03.prod.outlook.com (2603:10b6:610:d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 16:41:01 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 16:41:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e15185d-b462-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677256876; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=7uTl8tMvLaSfDKTxdpBnAX0uS30zHEFtm5N9vI+5thQ=; b=F100pg+tt0Kma8DUDup5hfhY4J6cHK/Qzw7RRgcWaToADhXHjHNID64o 20aYyYMVqj9hmu7AVPm/phn/G31pZ+8viunek0Q4kV5QVLYwpRr78bgHu mgHXla40h0Sb5KK3ZRuZfOTYbSh+B28katKIeToDFPpcMyZVU0xYWdRCN Y=; X-IronPort-RemoteIP: 104.47.59.168 X-IronPort-MID: 100863818 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Oeg1C6KMa8bFrK+cFE+R4ZQlxSXFcZb7ZxGr2PjKsXjdYENS3jUGn GsWXjiPP6nZZ2ujKYtwa9+0oxgA6pfSm9A1GQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5lMFwfr MM5dgkcbyChmLqVze2idORF05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGNnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHujCNxJROTonhJsqE/U4VJMLDgcaUqQp+jjrnKBV/diO 2VBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkA9MW4HTT8JS00C+daLnW0ophfGT9ImHKvriNTwQGv02 2rT8nh4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CJsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:tLQpRKr9VwE8DRBKSp/2/8AaV5rmeYIsimQD101hICG9Ffbo8f xG/c5rsiMc7Qx6ZJhOo7G90cW7IU80lqQFhbX5X43SPjUO0VHAROoOgeSN/9SKIVyaygcy79 YCT0EHMqyIMXFKyf/g5g+2CtAhx8TC3pyJqI7lvg1QZDAvUrpn6QhhDAadDwlRfylpQbQENL f03Ls7m9KHEU5nFbXFOpDAZZm61qH2qK4= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="100863818" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4Wp2PThvPw5QHqo2Xc4zoYNW/Nkx6wV1DrhM2nP6dZjtvlXPB/5w971H75FTUMwHKgCYz1koQBPFPAezuSkNR1gYigd+Ti7CttJB9c1HKpqFNuNTwBjqGscJzr97oRC+Ixhn+WA53/KWcQ54H6jFKEh7TenOSL5z2mRQB6+/5Y3z99wmFunAxsi53iwFY+27HmR9RlfO1IkLeDzol5fAH759fvWggDFG6Th8Q3IycrfFqZLfhV7LvqEm+z/vdIqJjH8O5B0oayvr/0VZ153aSx2+pZqH8FNbCKQwQME7Lu5Zubnswm6jsee6ZkChhjE/iV1V3rw0lNrkKtN6+tHIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7uTl8tMvLaSfDKTxdpBnAX0uS30zHEFtm5N9vI+5thQ=; b=n2opfTAMTXy8ooKS5XcNcVMQIuLyw8KOtSD50iM9scu+RX+v63p3oRF8im5f4ZB2o5/7AYzUxDTZe6SUgRds9tiul8vraoSPgHyIHwpqArdH9Vczc3ng/pzsFGUH2v2iPrB2Gecd2ZeoSKQXbGDnmqFp4oCt8C+tsEfDFOO2Wps46zhb6s15C5LHiOyv88lWXfDQcE1rLEwEQTUuyCMeBfDeRa1DE5ZidMQVnih98BoQw5VXdYaLic9cW6yBGkFgrxbQHVvg6L2PCW9Sg53NNj5yl7iIRaNQ1BeeWnaT4FhWvtEayEr4wEYJs85rOebO4ryoV1vJwNO61n5tMzo88w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7uTl8tMvLaSfDKTxdpBnAX0uS30zHEFtm5N9vI+5thQ=; b=kUcDlO6xhXd7WAq9EjCDualijI99dEALzPRxAE71Bq/Gqnxv+Xh2gW0Yb7FA93YY/3VA+fIhQx+f1wBKi7+l9y8gqJctk/12DN/We9UiETwseXoE2FC4cxgiwqwz+dr9BCgeH0Mp5TQ1HUjUVsIXLf3Hy2JkwFWbUltoeGyXelE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <8c1a3b60-9a14-43ed-15bf-8f9c87ef2c53@citrix.com> Date: Fri, 24 Feb 2023 16:40:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2 3/3] x86/shadow: drop dead code from HVM-only sh_page_fault() pieces Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , George Dunlap References: <0e682cd4-3cc0-461d-ee53-13a894797f17@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0677.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6179:EE_ X-MS-Office365-Filtering-Correlation-Id: f7a83a7e-5afe-47aa-97ee-08db1685e9c9 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QoxhyEfdvNNPonaWFcDOgN05GuysoxcFFMI48xEAagNJWSeQy1v1tw3VzWr9vTTRJH5La42s2H01a1d2IHSvzOXQAa8KvYhVaMSQHSXCQH8y+8L3tVBYU2UgtkkJXskPmtjZpid0aP3i1lgoTUyFlHkx4NeFZje5++foG7ExARX5gOMSRJjjCCBJmoB1i5J4cTCRO2fuwmRaZzI3sja6j4Y/oSldET4ICehe2p/sLESjyTUx/HPQ+8o1Wxf0YiBhJ1G8GZ9F+xLgdgrzE1A9f7wq8a226N+XE98CxM5qZwWFnCtuNbx8ICwrMBhWhkDM4treK6/DCjDfEqitCswX0+Wdew1isKPfKRWS0V6iXzVUWYDGzv5A37ASqcdRj21U8dLUAjzLPekyeHtyRr+9DrN/TiXw8bw+YXWaCEjTVJRDIymhAIGhBeM5NpS2VB2uYGNSIzHEbnZAOBlqWPo4kXbMPcS1183WvcUwoHaGX8i91G8ebKhIaSrxUHEkdHQmFRuDP7kOj4zWbLINzxO4PbL745nVY46enJ9j7duMUVOeyZdn2YU+gPciJlIUoMo7+X+T3wbtcD9GFtq1ZXEy7mNVmuU1OssBzZAEto/8uUDWeUr1dbapILw+VshHmKcTK3tz9EQT5eqJioavSp7DA5dUv+MfJHNJMeJG1KNC+M/mW25EHpsJx7NdYor+D8+jjAFOvsHjHCxo+305dGtvd1h8fqVpF1dS6QHTt4dqXqg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199018)(31686004)(2906002)(5660300002)(66899018)(4744005)(41300700001)(8936002)(66946007)(83380400001)(66556008)(4326008)(8676002)(66476007)(316002)(107886003)(36756003)(186003)(6666004)(6486002)(26005)(478600001)(53546011)(6506007)(31696002)(38100700002)(86362001)(2616005)(82960400001)(6512007)(110136005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Szcxc1hhOWdIYnpCdG9UWTk0YlJ0NW5vTTMvOC84c012RFdkTk4vNmhUTVhL?= =?utf-8?B?R1VySmplK3FQQmxhQkNCcXNocnQrMDZvQWxJU1I0aXhUdUNRb3RDSGtVTHVk?= =?utf-8?B?V3FVWHQvTEcxaDNleE9WWi92MTU4Zmt0Mjl3VTZaYjFvSzM0Q2dNeEJ4Vkla?= =?utf-8?B?cnlpTW9uRXhFcDkzSmdVcDRkdWoxaG0zbDI1MGtDM3ZINncza3NYNWdGei81?= =?utf-8?B?elJZRFBCOFFQTFBkV1VPc0N6Sm9kRXBZZHJrWm52MVhKaXp3ZGVzT1pvM3pD?= =?utf-8?B?RmdvYWJGRFV3RUlialhkZG02Z2NVa3dJdkxQS0pvRHd0eW15VlJaNVA0WUhV?= =?utf-8?B?ZnpkdjVJQ3M5RFNJM3phT0ZNWDZFV3NOUU0zRDluUklSQXlCMnpOVkFiWG9l?= =?utf-8?B?NURkQ3pMZlBrOXlCNVlDQjFYRVloQkwrckpsYW82SXRreVpERm1YN2ZFTTNJ?= =?utf-8?B?byt6NGhpM1JBT0EyTGtXdk42VkRjL0dhL3gyOFljZUVtcERtMklRVTNDWm5M?= =?utf-8?B?ZHpBeWdIamorWndtNitIdmh4V2F2RWZndzJRbFd3M1FacStvMGlBZ1BCNUhK?= =?utf-8?B?ZGE2Z051NHp4WmNNOTduSFFpcktVNFkxaE5wNjJIQTZXN1J0OTRTTU5FNyto?= =?utf-8?B?V1ZIK0lybDFqMWZ3WDB2YWZoMHlFaW1WeTZtc2RRcC83TkIxcW5WbCthWUhv?= =?utf-8?B?OGtqRHViRnBxRE1Gd1JtRytMak05N0sxT2ErVDNKZlB0cUNSNGFtZ0pMNnFh?= =?utf-8?B?cnB2UFhKdXlxemFoeVkveGdVTzJaUnBEK3hRUnBNcjJmK0RCLzdrc25McTNq?= =?utf-8?B?dkI2RUl0SnhGSmgxQTRubHJsSVhSQ0ozSzgvL3NScHNlaGVWYU40VjRIT1F3?= =?utf-8?B?WmNHdjBQNERyQ2dRQ0lXc2FveVVpRG9SN1p0alovT1lObVdheU41N2VnNHRY?= =?utf-8?B?VW1jeVRQZ3RXTm5qUjlZUmFMUzhldXN1UFdGUnl4d01peHpIRS93NGVmL0lm?= =?utf-8?B?SVNlK3J2Qmd2cldURGFpc3NLVXBJYlppbDFmcmRkUThFZ21QQ3p6VStBNHN0?= =?utf-8?B?RzFocSttNEtuQUZHZGNzUzV1T2tFUkVtQzdHYlVlazRlR29GaHJkS1FhN3pn?= =?utf-8?B?MXhIR21nVkN6ZHRKWWExVGswTFp2TUFMZ0lWOEY2MXpMNGgrSEhPWmcrU2M1?= =?utf-8?B?OFFwTGVNbi9WNXY4emN0WVltR1pQR2JBS2ZCS0ZUVGJIUU0rZUF5QTFoTnhW?= =?utf-8?B?R3RUZ2c3OHZsTUdLRWo3OFMzcTM0Tlp4cDE0cjlGMnFHVG0vbTRWMlVHZ2lP?= =?utf-8?B?TzdUc1hWVGJvWnY3eUpUTDhHaU03bDd5VkpXZ051VURKMnhmSThqNVpBb1cr?= =?utf-8?B?REVPRUZGN0lTemlMKzBxSG1KOUIvTTZaZ0NmbjFoa0xQSVluZVZrK1hpRzVs?= =?utf-8?B?Z3lFL2pCaGN0QWR5QkxpNlh4Y2JUZDY5ZG14VXZza3N2cjB2NmFNd1MvVnhM?= =?utf-8?B?L2dxTVhTbWJDeG5rVm5mNEw0V2FRTVYxcTF5UkFjQWExMUZzTVY5aUxjR2hG?= =?utf-8?B?aSsvTGQ1OXpkS0hsclhGanNVT0JpVFBiWDJRQ2RCeXJzeE1RZmxRZ1ZYT0dU?= =?utf-8?B?VE11WndjeHM0UGxrTU1PeUo0ZzdZZTIrSDl6YS9ObWx3NWtKdzJ4UUltY29N?= =?utf-8?B?QnQxaHgrQkNLZzFSd2swdXhFdFBDbzNNdTRKVHZOelB5UFZ3Wmw1WVhVeW9z?= =?utf-8?B?a3d3Rml6Sm5SVWFnM2tyRTdSeHVDSUpwd2FNRm5wemxQaEZkVHc2MlZHZmd5?= =?utf-8?B?ZkUyczV5c05UUFI4K0FoM1hBZ3J4dDNNRWc4WWFaWjA5eWhpUGw3SnlqSXk2?= =?utf-8?B?b0diREh2Um9OUUZmRWxNVXdRSldQRVBJRG9wbFRjcjhQa09oU3BTdWcvTmY4?= =?utf-8?B?QS9ySXg0UmZHYUg1WnFJeE8zVnVCNlpMZkZPZTIxWGV5UVZEekUxVmFmdzVE?= =?utf-8?B?QXhveVFIRElNUzBNNWM2L203RTk1SW9oM1cwU2ptcXpxR1JGYXdQeFRZVFVD?= =?utf-8?B?QnorcUo3SDBxdW5HWnV5N1BjYXQ3ajEvTFFma1BQRUhUNENFbWcyMFRwU2ht?= =?utf-8?B?UUV1QlNybkl4cGZCbjJtT3ZadmdLYWQ1ay9yMGlmWU45c1pRa0x1NU5LRG5k?= =?utf-8?B?NWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ztDPWHfcZ31RCZWeFp7FiknlAfFX1ug+9GkkR9cyyirs4MabicPQnqU36tum1dqXLehSp4RWpQ0HxMf4pFkYrXnonlIcwe3obx5fpyf2pGbVVcG3saEtJVWvVqbH9hVcj7eDiDCi4/Fk8AEAJGnp/T7FN9/3oC8mvBIQ4WWlBZDBxMC8+FbwdLIB5T5L91DamsUL8EeFGztkxT/6eF+NbJpVCpiV2/PWrAdDPrr+1wn3JwBRByXc9cTBS5DvPDiloOw806TYq0jFlA48YBfZQTrfFefOy9ovhVKuOSR/oOLU8C/oZ+0R4yiD3ThLJ8VNpXZNRjAERxdy/xhz7PX/QFkpVfBlI7KwLzy0T8bNsDxSO/HXSaDPNBAOaZluaitGuByYFZzM7e8qo3aNuWJZXoWc7DFJM5qd7V89stj0p4y9DIUNkJ7ipFpE25sV5ncYE7u/tEJYR5WYiYDBd9BaZ8rPivhb3j5Mn2z7FVYPIAHwK9/RnrS8x1wY9Pi3sHDMJ+EgXhfoM532+OHpeJRPyqObwba9L8W1x9C+79kp2uUeGIB5N4MrLfxFGxFtlVwHV+BCsHRDKtJPk7AgHk93vfVyC9Fy6ZXdSZ0QITvQ4l4ElXDh4/azyVksnPpR4lYZExgD9Oum1Fm8MAkgTBiQu2JBS6PEOFlEiDx/AfrUDksOUGA2SVmtRL6l9bw1xUyAkvkLzwZMoY4pJS3ZM2HDl4Pri8ZnRBJB3umY52WZsnqYPX1H6+cGZOE/f0nhm1T3A70j98FyKLjftRoajoCn+nXTgnrVf/aT+BnIL1cU0EIkjk3t65KA+r280JawKwiS X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a83a7e-5afe-47aa-97ee-08db1685e9c9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:41:01.5258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xfRflR5RdtxacxBVcRCtpbMpYs2NyF/Pb07GtiCkMB09jSIXRhDXtTlSlkr1Jf/RCzIcBtZ4wjywVZ5wn9Ztx3A0nyxUP5pPHv/usoQQeK8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6179 On 23/01/2023 2:27 pm, Jan Beulich wrote: > The shadow_mode_refcounts() check immediately ahead of the "emulate" > label renders redundant two subsequent is_hvm_domain() checks (the > latter of which was already redundant with the former). > > Also guest_mode() checks are pointless when we already know we're > dealing with a HVM domain. > > Finally style-adjust a comment which otherwise would be fully visible as > patch context anyway. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Thanks for splitting apart - it's much easier to follow like this. From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:43:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501294.772976 (Exim 4.92) (envelope-from ) id 1pVbAp-0008FR-Ip; Fri, 24 Feb 2023 16:43:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501294.772976; Fri, 24 Feb 2023 16:43:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbAp-0008FK-Fo; Fri, 24 Feb 2023 16:43:55 +0000 Received: by outflank-mailman (input) for mailman id 501294; Fri, 24 Feb 2023 16:43:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbAn-0008EV-KT for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:43:53 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b57e1a2-b462-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 17:43:52 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id i9so18482718lfc.6 for ; Fri, 24 Feb 2023 08:43:52 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id i19-20020a056512007300b004dd7fefd2c8sm571491lfo.242.2023.02.24.08.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 08:43:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b57e1a2-b462-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BPSRDjzdeB6txEqgf31L69bsNBIZpJBcGCUVmQUMvow=; b=Jbwivhhsyp6NmIirVTDq0Ay8uIPynWaFixc1ORAuEuyO5BA09TSEKNoxBU07mhU/w7 P2kmIW2xjtls2yXvoj5po+TmYC1exZh5ddp9uJJ3R2caQMBp/CBKRMYxDlTHe28pEGuq iEN47V6JN804Mm/eeVfWE4ma6jeg2UkBMXWlgZ8BDvWtLF8h9eK5387x3sUE7yKNlMS2 louajjp48udf6eMeiJ6iZYQ3vW7zhvd82KU60c+RIfyKQo+bspVmpXLYHKR5O8EXRPjB 5mWMwg0LkTqEPpOgN0dwgIC8zEsv979VXwW1IL0RTi9nfw/ooZSKhx9uHdwoy6m2o0fG O+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BPSRDjzdeB6txEqgf31L69bsNBIZpJBcGCUVmQUMvow=; b=vc1rP1q/V75nL7FZUHDhbYszyicewejeBbGQA8wqEzIaBAjwZYQkOcLhORl5zyO/90 KVrJHZqoF4GszW21+WW8c0qJvhnXK9t03EM/Juon0WyoDltS4xrDPrWrTRkIQcAyJvca 1AUSv+gPCVbvvjiB6iuO8wnYRKILQajfHN9XS8ulHOQBcrCeVtIJnbk/jNqKFhitakYU jFx5UIDemvgPQr3+xCev+X+wUYHudc0dGdBrF1/cXEsjj3lGerfXSXQ24bDELy4dWF+A WNCVsG9dlcaq53Ibg6m1shczwUdCPhsdAFHQDpj+z0Aw00AeadLaV3j2+cxyQg/Gig+x ergw== X-Gm-Message-State: AO0yUKVpFWroOdF9nCueGz+UBMKhDGDzHfnV78E5qFIbzR33bGmN/Iqt 0YRybXcXbS936EJp1Qw2ivk= X-Google-Smtp-Source: AK7set9PCqIaaQPnEYXdGQws7RFxWAeG1oClAj3Y/Ca2uM2PFg5Zs3wNYslc9KKRwVURrbXVL/UvbA== X-Received: by 2002:a19:ac45:0:b0:4cb:1189:285c with SMTP id r5-20020a19ac45000000b004cb1189285cmr6453054lfc.10.1677257031376; Fri, 24 Feb 2023 08:43:51 -0800 (PST) Message-ID: Subject: Re: [PATCH] xen/riscv: init bss section From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Fri, 24 Feb 2023 18:43:49 +0200 In-Reply-To: References: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-24 at 15:56 +0100, Jan Beulich wrote: > On 24.02.2023 15:48, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > > =C2=A0=C2=A0=C2=A0=C2=A0 early_printk("WARN is most likely working\n"); > > =C2=A0} > > =C2=A0 > > +static void __init init_bss(void) > > +{ > > +=C2=A0=C2=A0=C2=A0 extern char __bss_start; > > +=C2=A0=C2=A0=C2=A0 extern char __bss_end; >=20 > Better use [] and then perhaps omit the & operators further down. > However, I thought we have a compiler warning option in use which > precludes extern declarations which aren't at file scope. Even if > I'm misremembering, perhaps better to move them. Thanks. I will update the code then to use []. >=20 > > +=C2=A0=C2=A0=C2=A0 char *bss =3D &__bss_start; > > + > > +=C2=A0=C2=A0=C2=A0 while ( bss < &__bss_end ) { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *bss =3D 0; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bss++; > > +=C2=A0=C2=A0=C2=A0 } > > +} >=20 > If you're sure you can defer this until being in C code, why not use > memset()? I had an issue with from #ifndef __HAVE_ARCH_MEMSET #define memset(s, c, n) __builtin_memset(s, c, n) #endif but there is no issue any more so I think I can use memset(). >=20 > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:45:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:45:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501301.772986 (Exim 4.92) (envelope-from ) id 1pVbCj-0000Pz-UT; Fri, 24 Feb 2023 16:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501301.772986; Fri, 24 Feb 2023 16:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbCj-0000Ps-Rb; Fri, 24 Feb 2023 16:45:53 +0000 Received: by outflank-mailman (input) for mailman id 501301; Fri, 24 Feb 2023 16:45:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbCj-0000Pm-Cy for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:45:53 +0000 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [2a00:1450:4864:20::230]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b348ebdc-b462-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:45:52 +0100 (CET) Received: by mail-lj1-x230.google.com with SMTP id e9so14752399ljn.9 for ; Fri, 24 Feb 2023 08:45:52 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id p12-20020a2eb98c000000b00295a8c68585sm164521ljp.56.2023.02.24.08.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 08:45:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b348ebdc-b462-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3ROOQhNVqMUAZjCPKo1j893EG5DhF3n7MP2Vc/cEbqM=; b=ObREOdVIkTL7+BZruWwXUhb5iSYubU0L5FZGdOWSb9MZ7bTnGOweGmo5BEnWoKQLMS fHMmxw4Q7yIyoscNuRUK0g3QeHNRXpPXPuiQDN3c7mc2qFzyXrS1eSwxn4pM+w8Ny5PF Vr5AuAFPvqi2NNVCJ8f9Ig4HGvl+QUy6q1Gy5r1VjuLYTpqYhPHi+bauCuV6MRU3xlg6 /ZxtzFv/BXMllo2FVqq1PMzScPlSmczHC0i5kiiUJ1rvuGm/OeEdVmiteOMvpATIhdC5 wQ7RxYkD/WJh8Fzt5wC0ax/e1aDMPW8AqbIKmaQSMo3mNBBzvzHsaYHudDKPl96aOPnJ EARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3ROOQhNVqMUAZjCPKo1j893EG5DhF3n7MP2Vc/cEbqM=; b=LppnWg+E9BXYCAFnQ0JEEv19ixZMY5OyVSe+Aq9irYnG5vy9agJnG+fEdEMesUIQ2Q Hnn7h6TP+cH8GdEwEtuYJoY2az1QQ8h+ZO5/ulkLcXjee78desAIuTKrabhTAwlKE7Pi oCHHfYXKcPpeTm1fc50d2dk85lexkeulaAuHK0A1VeHu8djg7daVMDqQc+5Dk8p+vqOg mb8BlKKR7EmSFVn3FPQpK1qZhDiXC6IT9egvszoiz3IB7+k1149dOmuLWqKKSvZ/jKMG umtCOOYzshOeA13a3DQla+MoF6deF42um8ssElsW9W+gPx5wbYNYUThxvh3wpXgoYW0S YLOA== X-Gm-Message-State: AO0yUKVoJbmjouG5dziE+VHzS58//NIDTXGiQIlk0UMPc8dxQuubsA+k JkguBRohFYegUe+BqLZg3ik= X-Google-Smtp-Source: AK7set+KZcYir25Il4lRADq69l+LCW/DoYQjlmKpiReKiVkXg9/RvhI1Gw5P/BP5X60nx7qrB6oCaw== X-Received: by 2002:a05:651c:4d1:b0:290:4dd3:c177 with SMTP id e17-20020a05651c04d100b002904dd3c177mr7573990lji.32.1677257152256; Fri, 24 Feb 2023 08:45:52 -0800 (PST) Message-ID: <446e180b380251ec2c2e0778b73cf2c06739fe21.camel@gmail.com> Subject: Re: [PATCH v1 3/3] automation: update RISC-V smoke test From: Oleksii To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Gianluca Guida , Doug Goldstein Date: Fri, 24 Feb 2023 18:45:50 +0200 In-Reply-To: <88839882-29bc-0de1-ae6f-f47dc1ee3aee@citrix.com> References: <38ddf88eabd9cc36c332d6a27c6ee1242d33df19.1677250203.git.oleksii.kurochko@gmail.com> <88839882-29bc-0de1-ae6f-f47dc1ee3aee@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-24 at 15:27 +0000, Andrew Cooper wrote: > On 24/02/2023 3:06 pm, Oleksii Kurochko wrote: > > The smoke test was updated to verify that MMU has been enabled. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0automation/scripts/qemu-smoke-riscv64.sh | 2 +- > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh > > b/automation/scripts/qemu-smoke-riscv64.sh > > index 02fc66be03..01cd08e407 100755 > > --- a/automation/scripts/qemu-smoke-riscv64.sh > > +++ b/automation/scripts/qemu-smoke-riscv64.sh > > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > > =C2=A0=C2=A0=C2=A0=C2=A0 |& tee smoke.serial > > =C2=A0 > > =C2=A0set -e > > -(grep -q "WARN is most likely working" smoke.serial) || exit 1 > > +(grep -q "MMU has been enabled" smoke.serial) || exit 1 > > =C2=A0exit 0 >=20 > There's a more simple way than this.=C2=A0 I'll do a patch. Definitely your way is more simple. Thanks. >=20 > ~Andrew ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:47:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:47:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501307.772996 (Exim 4.92) (envelope-from ) id 1pVbE3-0000yR-87; Fri, 24 Feb 2023 16:47:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501307.772996; Fri, 24 Feb 2023 16:47:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbE3-0000yK-4x; Fri, 24 Feb 2023 16:47:15 +0000 Received: by outflank-mailman (input) for mailman id 501307; Fri, 24 Feb 2023 16:47:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbE2-0000yE-IN for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:47:14 +0000 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [2a00:1450:4864:20::230]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3a9f3c3-b462-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:47:13 +0100 (CET) Received: by mail-lj1-x230.google.com with SMTP id b13so15766684ljf.6 for ; Fri, 24 Feb 2023 08:47:13 -0800 (PST) Received: from [192.168.8.199] (46.204.108.92.nat.umts.dynamic.t-mobile.pl. [46.204.108.92]) by smtp.gmail.com with ESMTPSA id x3-20020a2e9c83000000b002934ea0def9sm1331545lji.140.2023.02.24.08.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 08:47:13 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3a9f3c3-b462-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DM0/WnFvjALj6ZDgRgjy0kvjYwl8UHomuj6mz28wim8=; b=YW3/17EEEQGu/sbdecsO0SeS1w2s5giIyxJmo/GPavfUgvjV56JB0j1mCCgOHR9Rfc BcS7Xal+ood06HlfhCviv9krTXQSAih+Y65mOl8VWibz2q4GF8g9JgCR9YqPqXYCd5c4 PFBTaDNT8A+4HvSRignvw1XyPaa099vThFr7yK77oEPzUr8uT1bmPtQ2olCzu1mSmDWg Lg1ekVTOq9+xKt9Z2gz5l+kYzGTwB1jA63Z5HLk/QbZeZXXX2za9RGOYkgBhCNuiCpg4 Rdo1JBdVE7w6P39mnKHYsW9v08loTpyiPziimU/SnvKJ3b+8XP0PUlkCc4/aujlx5XaG WZyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DM0/WnFvjALj6ZDgRgjy0kvjYwl8UHomuj6mz28wim8=; b=jPU4MY4sVajLTIrn/NcVD3dOMMr2oYDZurzeZ0Gp7o2ojzWZGygHgrNu7cgOlfVDVq aKKe3BuszwHKVpfBcqEdqz3eWk/J42QrY8m1TCkuHo37s67uBr4WICpnaOhYsaIfKOwK QzeN/bt9ls07GxEXM+KysOSfOyAUmuLvhEGsmqcFwBCo/GTGi7CVUlPjXgHGc4RpLGRt D3P98QJFXLvd/wQra8N9NGZbkm3lsFKezUII3VhUJbBRHmZX5WHRvfU6v8/mfzSjSiEJ 16O2U8maUUPzRmweNlvCBzmog0l+y6tUcROjVJ3yn/hXRO3/RShfpkoS9y7Ip1QggEHs e+3g== X-Gm-Message-State: AO0yUKWVYKHNPOOfgDpK6FAuE5c8ywEbwhEWf4Ie+0wFD+TMYawC/0d9 a91dtHXt2r6KTISrDGw6rO4= X-Google-Smtp-Source: AK7set+sc9mMOfep8n9Tr7Py/NkNnqbJdkNmJF9F9XOcn7wvUB83miz5WA9foWlkpM8aBjjpwlOz4A== X-Received: by 2002:a2e:b805:0:b0:293:1ab0:27d9 with SMTP id u5-20020a2eb805000000b002931ab027d9mr5574190ljo.24.1677257233451; Fri, 24 Feb 2023 08:47:13 -0800 (PST) Message-ID: Subject: Re: [PATCH] CI: Simplify RISCV smoke testing From: Oleksii To: Andrew Cooper , Xen-devel Cc: Bob Eshleman , Alistair Francis , Connor Davis , Anthony PERARD , Stefano Stabellini , Michal Orzel , Doug Goldstein Date: Fri, 24 Feb 2023 18:47:11 +0200 In-Reply-To: <20230224153721.2623760-1-andrew.cooper3@citrix.com> References: <20230224153721.2623760-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Looks good to me. Thanks. Reviewed-by: Oleksii Kurochko ~ Oleksii On Fri, 2023-02-24 at 15:37 +0000, Andrew Cooper wrote: > Use a single fairly generic string as the "all done" message to look > for, > which avoids the need to patch qemu-smoke-riscv64.sh each time a new > feature > is added. >=20 > Signed-off-by: Andrew Cooper > --- > CC: Oleksii Kurochko > CC: Bob Eshleman > CC: Alistair Francis > CC: Connor Davis > CC: Anthony PERARD > CC: Stefano Stabellini > CC: Michal Orzel > CC: Doug Goldstein >=20 > I considered "All set up and nowhere to go" but it's probably a > little niche. > --- > =C2=A0automation/scripts/qemu-smoke-riscv64.sh | 2 +- > =C2=A0xen/arch/riscv/setup.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 + > =C2=A02 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/automation/scripts/qemu-smoke-riscv64.sh > b/automation/scripts/qemu-smoke-riscv64.sh > index e0f06360bc43..4008191302f9 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > =C2=A0=C2=A0=C2=A0=C2=A0 |& tee smoke.serial > =C2=A0 > =C2=A0set -e > -(grep -q "Hello from C env" smoke.serial) || exit 1 > +(grep -q "All set up" smoke.serial) || exit 1 > =C2=A0exit 0 > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index d09ffe1454a4..1c87899e8e90 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -11,6 +11,7 @@ void __init noreturn start_xen(void) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0 early_printk("Hello from C env\n"); > =C2=A0 > +=C2=A0=C2=A0=C2=A0 early_printk("All set up\n"); > =C2=A0=C2=A0=C2=A0=C2=A0 for ( ;; ) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 asm volatile ("wfi"); > =C2=A0 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 16:55:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 16:55:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501325.773006 (Exim 4.92) (envelope-from ) id 1pVbM2-0002zN-6R; Fri, 24 Feb 2023 16:55:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501325.773006; Fri, 24 Feb 2023 16:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbM2-0002zG-2J; Fri, 24 Feb 2023 16:55:30 +0000 Received: by outflank-mailman (input) for mailman id 501325; Fri, 24 Feb 2023 16:55:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbM0-0002zA-AM for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 16:55:28 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0874ffdb-b464-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 17:55:26 +0100 (CET) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 11:55:13 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH8PR03MB7272.namprd03.prod.outlook.com (2603:10b6:510:251::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Fri, 24 Feb 2023 16:55:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 16:55:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0874ffdb-b464-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677257726; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=EgvXkmbAXRbF7IYHg33OHVD/L4Qy8VD2nB09+l6reD0=; b=UzuglqOaYYU5rGbHX9xlL4GNGOe0MhVi8mqRuwhLBBr7tr8JmPX1oFqT xfIe5jAyJrLkE53Is3uDQgrz7f20IRYzfLBQNyzLMOs8gdxFJm1Y6wGA2 87GUKFuO6P7jnqizIXprUtIJ1bkgb8nsqWI50UF2SPICXFiY4HL1mX9mh 8=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 97825106 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tycfZqs0FxVW5U+HRyu4VXlzTOfnVM9fMUV32f8akzHdYApBsoF/q tZmKTrXbP6OajT2e9ojO4vgpEMF7ZWAnYdmTQA9pCxjRi9G+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEyyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwA2AUVxuJ1/yMxeigZfkytNoMB+TII9ZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xbLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6ReLorKMz2AP7Kmo7LAI1TlKe/fSF0BCQdvlDF 0gSynsAov1nnKCsZpynN/Gim1aDuhMfQNtRVe4n8gaGyqnTywmcD2kACDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vX6GDj2x y2BpQAkhqsUls8N3OOw+lWvqzirrJLYQxU14gjSV2SN4QZwZYrjbIutgXDS6fdbMI+YVB+Pp nECkMmFxP8CBteGkynlaO4KGreu5fqMLjzHqVFqFpglsT+q/haekZt45Th/IAJsLZwCcDqwO kvL41sNuNlUIWegarJxb8SpEcM2wKP8FNPjEPfJct5JZZs3fwiClM1zWXOtM6nWuBBEuckC1 V2zLK5A0V5y5Xxb8QeL IronPort-HdrOrdr: A9a23:7TsmI66IPfuzx6aczwPXwKvXdLJyesId70hD6qkRc3xom6mj/P xG88536faZslwssRIb+OxoRpPufZq0z/cc3WB7B9uftWfd1leVEA== X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97825106" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpCoffjM6zkDa/6CZrmX2JhVhAWG03XFdEfO7whCPmKD2pbqVbfc2t+e7xGbtuUtR/c1L99ApsUP9vRMSbdU6UJO3t1C6CKyKOwaSAGQmJym0g8sPz4q6cGpIytE6uVemKWJt6txxn3mMQQ+7qIZdLVQPfHE1P8sZG2tc03tPA4lECQJMMZJZ674o19cdws0PZPmG0QK4VrsBmNJkYZLgGN5qDZQsv07ysvhHb7BQcARFW1QZ7Oyqg/iPY1h4AiH3NritHTGeHYr3G4V08XiakwacVATwutuYCHIRAorYwvvzGzHqdZedFn/qOCPEkrh3T2xJxIZi18DloKzREU1Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8AsOnkZ93FKjt7dyr38w2/7YTVfOQDe1xEzpKG63yk=; b=AvAcCaDnhTcPGd+/NpgxaJmnnZoyLOzTNYzyBfmcHUk7sht4doStRs9kKkEbmbYtiFpLei6uLfmBt6XJqag/KnrPoagYoA+tSBIK3rP/C5y/OS7PMNiGMbDBlfMYO9X+X9F8QgnyzkKS4TaWX+fVEwbsYhERUjW67qnPKhSq+Nntz6HvzIYJ8a9TdV2jmbCgjADFe7KIGfMfmTomHE08WpSrk5jLkf+Mvvpc8EYtsC20TNIsOENlKVe0wLjtqhp0epv20fa2EQYCJ9kmLh8DZzgccNE5Pl9bzgGQ7b7eW62oTzQ8elHAtgrdd5i0Eh95G51iHxw7YFGmUdudQkl7lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8AsOnkZ93FKjt7dyr38w2/7YTVfOQDe1xEzpKG63yk=; b=Y5sW99n/9rAOCLQuB9C48jljKuxZk4iNXccqopRKkiY+p7PDwl8/PJ1W7wKPnOfMybEz+nxtDowdEiVS8BTWuZ2Skd0chtBNlClNdaeESiNDelwS48VR1F3cqK4XJTShuj5BsMMv6jAs9213yMsUcot3R3NCseElKHUqnVviFrA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <349f4817-ab12-b648-a0d7-76ed4aaafc74@citrix.com> Date: Fri, 24 Feb 2023 16:55:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] xen/riscv: init bss section Content-Language: en-GB To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> In-Reply-To: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0020.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH8PR03MB7272:EE_ X-MS-Office365-Filtering-Correlation-Id: 27c25950-32ed-48a7-b2b4-08db1687e4f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oDJeIP6cobyaD3TMl97lHBc5EukbMD22SZ1Y3Er0BvHqJZFBMSSOcP3lrwT47S0GkC/Sq0/Za6wrkLN0U/GD/BZCfY9se7j8/UJgv9KMBLfVKkH8A8nJOVzGVm/vu0pydMr6Nic2NhCmaEoFwgF9BRx7h8DyL/GJGD5XdsiEE14KY0OENEmr2nMsDBf83cF9F2iYvVNILxYSJCb0TCSqreuLKtQbOnERrdiiXULN+3HG8EKTFDvxYPTPeOKroRDQzFbouYyqGt8MDH80bZ74Amf60QCjCkYB02H/o832B7QjN0g4C5xI/1cp20JOGf+7xPUHXCpMs3DByVC+B+IL+B7Bc4hNCRLMgmXuHS6GV5V3AfC8TLisA5TntRjtkGtkY2+7UOef4koqMUpHtgrsJ7qpGpnZYhWqtGR5Q6yYfhIW4l2Rsty63J3kYyd4q331hCAzpeDOlQql8sL8aCRnfzsTNeCt5E9ABrYE3EC+CZC9iorGRYyDPh1eUKerFZfAEzsjmxaTLlGbPu0HdWb7HXvXKtGUhK4QWPP+RJn06o8rVIcOmTwp6Yznxx3Ox0loDVDhf1ShcKIyc36q4FQ9pCvo4x8Vd/ZoOd72A/BGrHUPEneoX8YcZ3ovD1Z8dqFczUVqfB7otJ8nHJ3dbaSf8BRv7CvSXVZKlSD3PKRGVt8aQv3kdrGmkRumcaKCoDrqybS6ldRQaDleyoHdEdN8ZAGS8gBkSaWmiO4S/uTaed4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199018)(31686004)(36756003)(316002)(2616005)(478600001)(54906003)(6666004)(6512007)(6506007)(53546011)(6486002)(8936002)(186003)(83380400001)(26005)(38100700002)(2906002)(82960400001)(8676002)(66556008)(4326008)(66476007)(31696002)(41300700001)(86362001)(66946007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHQxNjM3d0ZXS0pvTVI4bXlvRmxudWZsWVg5OTYyVDdBd1BySm1mSDBtcU41?= =?utf-8?B?bVJmSzBqZXBsZlhkSVBRdTZpaHhmaU0wNGpCMzlqaDY5cmxmZ1ZSTDZxQzhs?= =?utf-8?B?cUd1NldWQUNhUE4zYTAzL1FzR2xndmpkeDRWc3l2ZlppOEFKTk1IbzdRcDc2?= =?utf-8?B?NU5UUlpJZmwvSWkyUm5uejhGdnl0TWZGeXZSWG1USUVWaXNvSEoyRDdnMTVI?= =?utf-8?B?eXdqM0NuRnRDYXdUT0JzcXI3d1hUbUVXMzBlQzNTS1dnVDRGZWtHQzVQSXB5?= =?utf-8?B?Nm4xUXFPeXlzSm1CVlJGbWhVa3Zna2lrK3owTk5sNFJsV2pGeFFYQzlqcjha?= =?utf-8?B?blhULzFSa091UmsrZGh0N2ZYZGNnUE10SW5lbU5LUDBZTUdPcE16VTF3dklW?= =?utf-8?B?YVVRS09aeXVaNDBBY0dWZVYydjh3Rmc0OTdTQ3UreFZrc0wwVlYxWFBwWUtm?= =?utf-8?B?NGlTZExMbCs0RUVmekhnSFpWYWRkN0FEbmtQbS9RTmVtRlFUYVpxMFk2VEtm?= =?utf-8?B?NXBBeFlPKzZYbUQ5am4zUW5JN3hrZ2xwTnNyNkpJdDdFVmNTRTF4QWU3Qm5L?= =?utf-8?B?RjErWXZiRWIvdVc1Q2FmaTJhNHBESHpEVHlNREdjQ1ZJMWN4dTNDcWRUY0xw?= =?utf-8?B?UWxsTTdOaG5mc0RTeEVpOU5kQ2x6VU1sdjc0NzFXRzlzTnJ4eVRvNXBjcDcx?= =?utf-8?B?Y09Gc3ExNzN5MEltWjBHbUZ2a04vQkxoelkrRkkyQWZELzc1Y2JOckhrMGhZ?= =?utf-8?B?blBNRzArMjBlaXhXSGJnazhLeWp6ZndMOTVuS1FJRzZ3YUdKaDZYVFBXdUZo?= =?utf-8?B?cnFtUnR5NnV2QnVyOWY0UFp3bmwrVkpvY1BkTHo2cnE3R3lmQTJXVDgvR1lU?= =?utf-8?B?TWZ4aWpnNVdjTk1GSXJqeFJxcUJOQllBWUtGQjgyc29PdjZBT0dEcGVjbDY4?= =?utf-8?B?VmJBNElzZ3JjanJWSDVkYkVvOUE1YUpuYWZNREcxUExZcW0yaHExdVQzd002?= =?utf-8?B?M0NWaGwzNUV0b0xwYUNrZm84QldoMEROczlKV1c2elQvbXFMZHo0aVJWSkxJ?= =?utf-8?B?a0FzRnFtMzRwUHdPeVZqV1RIS3YrdG5YSWhpUDgvQ05aKzJ0R3loQzRjRno1?= =?utf-8?B?THRoajcwbFhKSC9MM2NXQkJ5cWxFczV5TjlTZEdveGsvQXljZk83VlJieEhx?= =?utf-8?B?dWJUczhzbjZ0Q2o1Ny91ZXNHQ1BPOXJRQmZrdmFJK3orWjV1cUdNQk5XL2RG?= =?utf-8?B?TUc1cGNGTGd5dmJObUdNcHB0OFR4YWc5cEdsbjhvazViSno3NnpIUk9qdXRj?= =?utf-8?B?eFVWclJTS2ZEV0ZBbm1COUlma3NyTXUzbW1kRTBVNktkQXd6NU1vOGIveVZl?= =?utf-8?B?d2o1UkpWZUxtQVZHNEFneDE4TmVaNWp2STBNMW5SZHhNZ2FzNkp2bkswS3lv?= =?utf-8?B?MlJ4WjZteWw2VjBMNk00REhMZmZWZFRTZDlQZnY0ZVVrdWJpb2NIWHRDVGNs?= =?utf-8?B?VVJwdkluUEpNZmVMeGtDckdweWgzaVU4RHh5ckQxK00rRFpnV2dWUnU1UHVr?= =?utf-8?B?Q3JiaTlyVzg0aXN5SGt4TjZqZ3Q0ekFYeHNMOTlZL1VwWTNzNVY5Nk9zL3BZ?= =?utf-8?B?UzA1WHAzNGZFNVI2SjdGUTgvdVRMOWx1aHpwZDcyQ0lBNkhSb2NGZm4wdWYy?= =?utf-8?B?ejJkM0IxWklFMnNxbExzS1J6R2tJZFVFNjZCWEltdG90eXJrWmhwM28vNStB?= =?utf-8?B?SmZwUUV4Sm9PVnRJMWRRb3JrNjBwZjZRTnZxNFk4MklLWEZWU0RNMWpOVTN0?= =?utf-8?B?RHhCK3ppb0ZweUYzajR2OEtFcXBFRFQxL0RvcmxBall6RTV0VllDc0F6QUhD?= =?utf-8?B?VEhOZHNkWGQwTUs1K1FOYXVLd002QXU5dUNLUFEwTGlvUmNCUEEzSWlxeEVq?= =?utf-8?B?Z2h4YmtZbWx3Nk1Eb3hSVUZYM0QrS2RzbzduaUZWZDJGQ3VuRXVLRUF1bkZs?= =?utf-8?B?ZXJqcHVFOWFLRG8zSC9SNmU1VzBKdXpZMmdYSVowcHN2a0tFZFJCd3M1ZFVM?= =?utf-8?B?c0kzWDJSWU1NRUhhT2tTb2RTeXl5TWlGVmRtVjBQb2NBbWVpMXd2VHFaV0My?= =?utf-8?B?dEtBTFUrUUxsZmpmSHZuVk50Q3I5OGh5dlY5cUsyRlRsMkNzMHM4dGx3Z0Yw?= =?utf-8?B?dnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ir8apWen7INWyowzZyo0T2S7lADjgo5U0Q4UBajpqSyfRu/2Cz8dnPF7lJmXwDolILEublYgEQvazYGmCfSLul3nWmls55U9g/aew7hRx2R+6ubLGupLifEHaBbAEHRaZ1YPyhw1d5YIS1+fFcB4UKzWleqXzJtUyOZ27U1nF8zydrwHrBekZDvKTexzXu6He7f8mt/+AUJfPSf02wo+JdCGjABD/bPuEC9V51xhwpPABD8Cj2C45TyWknrpSuHK5SLTnMXBkWeZhpecL9YUb60Ly+XXcdN/sKIq7XhAzsld4kXfLdYFFktgjABc34n5spKmIbTcNjWreFyEuSGVXgLWKJvld8C2WiqfmCdSi7OqbOc6I8UbMtEGxp5LI04bkpULt4MIhUXEqpOOS+3vckNa3JGUcNM92nVKwFm5xvHQ8vqm7daoefhVihv+FAgxlyok/zC8Gb04sTVXEjOnwgLprrNy+onHDeJ3LCwPEOr8JXz3UWCsaMnlZD2qUool1L1A1EewipgUHL8oGgZfJ6SOnJspEE8Xffx86hGQZEDom9yJWmgzWwHbKPL7SFE1gS3hm2KYMMeeamplGU+fgIMCp9AiUaqu8JCiDNVta9nXJC0gKZAgVOlb+xNKL9kK8iqV2K3TT0grqfXo5kiAl7jTIdhpYTI3uzDiFldFLBItc1N8uIcTFDU46VoAASQDqolibV5+HtppWf7f1QPBw8QZRHma4pLL3D7J2LModv/Hka0ktIaUGTOazW5sVnsyNB51cZfl7lTbeA1s9mufFdHuzzcG1NziOMi2OIjtN4mpSJnmmDcHvDQ3Pri0Vd8vUrPesR02XWGRnUUsOynUrkKxtCLIIDVlIQBe2XUbgaD8KLlK51NwrlJ7+ZSWJFdUrokBvNuNcEc7KoduVYp4BA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27c25950-32ed-48a7-b2b4-08db1687e4f7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 16:55:12.3078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d4BXPFXNXON0UtfZMZLUEbeibTb/gZc+THTX+Cfwc3ss6TTOCs5ziO9oSDScSIN2Lfvhw/QjGZE2CkS4QVLTjK7A2i/o0Ba3YJcgze26SSM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR03MB7272 On 24/02/2023 2:48 pm, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/setup.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index 154bf3a0bc..593bb471a4 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > early_printk("WARN is most likely working\n"); > } > > +static void __init init_bss(void) > +{ > + extern char __bss_start; > + extern char __bss_end; > + char *bss = &__bss_start; > + > + while ( bss < &__bss_end ) { > + *bss = 0; > + bss++; > + } > +} > + > void __init noreturn start_xen(void) > { > /* > @@ -38,6 +50,8 @@ void __init noreturn start_xen(void) > > asm volatile( "mv %0, a1" : "=r" (dtb_base) ); > > + init_bss(); > + > early_printk("Hello from C env\n"); > > trap_init(); Zeroing the BSS needs to one of the earliest thing you do.  It really does need to be before entering C, and needs to be as close to the start of head.S as you can reasonably make it. I'd put it even before loading sp in start. Even like this, there are various things the compiler might do behind your back which expect a) the BSS to already be zeroed, and b) not change value unexpectedly. Also, note: arch/riscv/xen.lds.S-143-        . = ALIGN(POINTER_ALIGN); arch/riscv/xen.lds.S:144:        __bss_end = .; The POINTER_ALIGN there is specifically so you can depend on __bss_{start,end} being suitably aligned to use a register-width store, rather than using byte stores, which in 64bit means you've got 8x fewer iterations. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:11:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501330.773016 (Exim 4.92) (envelope-from ) id 1pVbb4-00065Z-G7; Fri, 24 Feb 2023 17:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501330.773016; Fri, 24 Feb 2023 17:11:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbb4-00065S-D0; Fri, 24 Feb 2023 17:11:02 +0000 Received: by outflank-mailman (input) for mailman id 501330; Fri, 24 Feb 2023 17:11:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbb1-00065K-Rw for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:11:00 +0000 Received: from mail136-1.atl41.mandrillapp.com (mail136-1.atl41.mandrillapp.com [198.2.136.1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3192cfcd-b466-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 18:10:54 +0100 (CET) Received: from pmta11.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail136-1.atl41.mandrillapp.com (Mailchimp) with ESMTP id 4PNby43Q2qz9K7SPP for ; Fri, 24 Feb 2023 17:10:52 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id cc9718df75dd46cb9779f48374244071; Fri, 24 Feb 2023 17:10:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3192cfcd-b466-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.fr; s=mandrill; t=1677258652; x=1677316252; i=marc.ungeschikts@vates.fr; bh=/cM4GSWoAvfTw5pelgWypLFM+HWEwZsUu3yaR4x1+8M=; h=From:Subject:To:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:CC:Date:Subject:From; b=F4VOXzCh9zIJmZ73828tUlArUwJ/3LwA8DfscoXs7D2PkRZexR/e4jGVr8jgTFxP+ biSSWBLqxc3//kVdwJUI5+DS9IqtA9ljwAg3gGRZTl4fisvi52JrF6zia7v9tJc5WZ +71EFZQR4S/E2Lw+U3VRDGb2r5IrbhWcX4r5xEqY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; i=@mandrillapp.com; q=dns/txt; s=mandrill; t=1677258652; h=From : Subject : To : Message-Id : Date : MIME-Version : Content-Type : From : Subject : Date : X-Mandrill-User : List-Unsubscribe; bh=/cM4GSWoAvfTw5pelgWypLFM+HWEwZsUu3yaR4x1+8M=; b=HfJ28WoV/BxMZ+kkjQgRvHXjW3ucAfVCUDchoArsfDhUc79oGKAYnRAzTaIlWdPANK/Fdf qFVLM1xVe++/S2xyJ99VEY0wZGPT5s6ijriBZivkPbkGYG+fYAnQ99E1f0lQHI4VRjDCAyGO q6LTxwhmqb5HlCsAXw7j12AOhJJ5g= From: Marc Ungeschikts Subject: =?utf-8?Q?RE=C2=A0:=20Weekly=20meeting=20-=20Xen=20Gitlab=20Issues=20Review?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 48e5b86a-aec2-49cd-9e7e-fb489512856c X-Bm-Transport-Timestamp: 1677258650908 To: xen-devel@lists.xenproject.org Message-Id: <20230224171050.D21C8E103B@mail2.vates.fr> X-Report-Abuse: Please forward a copy of this message, including all headers, to abuse@mandrill.com X-Report-Abuse: You can also report abuse here: http://mandrillapp.com/contact/abuse?id=30504962.cc9718df75dd46cb9779f48374244071 X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20230224:md Date: Fri, 24 Feb 2023 17:10:52 +0000 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_av-3nxTeFG5xCWYb7EtOZu2sw" --_av-3nxTeFG5xCWYb7EtOZu2sw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =F0=9F=93=9D 2023-02-24 Report minutes Xen Gitlab Issues review mee= ting: https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/ =F0=9F=93=85 For next Week 2023-03-03 14 :00 UTC : https://cryptpad.fr/pad/#/2/pad/edit/GBcZpfFD5WELm7mdE2C-anKD/ and https://meet.jit.si/XenIssuesReview Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*vendredi 17 f=C3=A9vrier 2023 16:15 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*RE : Weekly meeting - Xen Gitlab Issues Review =F0=9F=93=9D 2023-02-17 Report minutes Xen Gitlab Issues review meeti= ng: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ For next Week 2023-02-24 : https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*vendredi 3 f=C3=A9vrier 2023 16:55 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*RE : Weekly meeting - Xen Gitlab Issues Review =F0=9F=93=9D Report minutes of today's Xen Gitlab Issues review meet= ing: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/ For next week: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/ Marc Ungeschikts (Vates) *De : *Marc Ungeschikts *Envoy=C3=A9 le :*lundi 30 janvier 2023 10:56 *=C3=80 : *xen-devel@lists.xenproject.org *Objet :*Weekly meeting - Xen Gitlab Issues Review Hi everydody, last Friday, during the Backlog Review meeting, we decided to schedule a weekly meeting *every Friday-14:00(UTC)* to talk about Xen Gitlab issues (discussion, grooming, triage,...) *Jitsi Room*: https://meet.jit.si/XenIssuesReview You are all welcome, specially developers and maintainers. * Marc Ungeschikts | Vates Project Manager* *Mobile: 0613302401* *XCP-ng & Xen Orchestra - *Vates solutions *w:* vates.fr | xcp-ng.org | xen-orchestra.com --_av-3nxTeFG5xCWYb7EtOZu2sw Content-Type: multipart/related; boundary="_av-3YoemH699BdadnfmvfAIQw" --_av-3YoemH699BdadnfmvfAIQw Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

=F0=9F=93=9D 2023-02-24 Report minutes Xen Gitlab I= ssues review meeting: https://cryptpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI= +mqUDXs9/


=F0=9F=93=85 For= next Week 2023-03-03 14 :00 UTC : https://cryptpad.fr/pad/#/2/pa= d/edit/GBcZpfFD5WELm7mdE2C-anKD/
and https://meet.jit.si/XenIssuesReview

Marc Ungeschikt= s (Vates)

 

De : <= /b>Marc Ungeschikts
= Envoy=C3=A9 le :vendredi 17 f=C3=A9vrier 2023 16:15
=C3=80&n= bsp;: xen-devel@lists= .xenproject.org
Objet :RE : Weekly meeting - Xen Gi= tlab Issues Review

 

=F0=9F=93=9D 2023-02-17 Report minutes Xen Gitlab = Issues review meeting: https://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6= q31w5HLOx/


For next Week 2023-02-24 : https://cryp= tpad.fr/pad/#/2/pad/edit/PhI0GK3pNtbm80GI+mqUDXs9/

Marc Ungeschikts (Vates)

 

De : = Marc Ungeschikts
Envoy=C3=A9 le :vendredi 3 f=C3=A9vrier 2023 16:55
=C3=80&n= bsp;: xen-devel@lists= .xenproject.org
Objet :RE : Weekly meeting - Xen Gi= tlab Issues Review

 

=F0=9F= =93=9D Report minutes of today's Xen Gitlab Issues review= meeting: https://cryptpad.fr/pad/#/2/pad/edit/CymKm6lKLO-y81RRYtrPdJOI/

 

For next week: https= ://cryptpad.fr/pad/#/2/pad/edit/fRRWiCN07eq4oa6q31w5HLOx/

 

 

Marc Ungeschikts (Vates)

 

De := Marc Ungeschikts
<= b>Envoy=C3=A9 le :lundi 30 janvier 2023 10:56
=C3=80 : = xen-devel@lists.xenpr= oject.org
Objet :Weekly meeting - Xen Gitlab Issues Revi= ew

 

Hi everydody= , last Friday, during the Backlog Review meeting, we decided to schedule a = weekly meeting every Friday-14:00(UTC) to talk about Xen Gitla= b issues(discussion, groo= ming, triage,...)
 Jitsi Room: https://m= eet.jit.si/XenIssuesReview


You are all = welcome, specially developers and maintainers.
 
 

 
Marc Ungeschikts | Vates Project Manager
Mobile: 0613302401
XCP-ng & Xen Orchestra - Vates solution= s
w: vates.fr | xcp-ng.org | xen-or= chestra.com
3D""
3D"" --_av-3YoemH699BdadnfmvfAIQw Content-Type: image/png Content-Transfer-Encoding: base64 Content-Id: Content-Disposition: inline iVBORw0KGgoAAAANSUhEUgAAAK4AAACfCAYAAABgKuLmAAAm4XpUWHRSYXcg cHJvZmlsZSB0eXBlIGV4aWYAAHjatZxpkmSpcoX/swotgXlYDuBgph1o+foO kVmva2jZa8lU1VWZFRlxL+DuZ3C47c5//ed1/8GvEYZ3ubReR62eX3nkESff dP/5Nd/fwef39+el8/Wz8PPrbtyvH0ReSnxNn3/2+vX+79fDjwt8vky+K3+5 UN9fP1g//2Dkr+v3Xy70daOkEUW+se8RfV0oxc8PwtcF5mdavo7e/jqF9TW1 r89/loE/Tn/dHYdeK+vzs1//nRurZ4X7pBhPCsnzd0pfA0j6E12afFP5O6YU 30vvlc7fIcWvkbAgf1qnH7+4rbsaav7jm36Kyo/vfonWGV9r9Gu0cvx6S/pl keuPr3983YXy56i8pf/LnXP/+i7+/ProMX5G9Mvqv8W/1u+bM7OYubLU9WtS 31N83/E+wpF16+4YWvWNP4VLtPd78LuT1ZtUML/94vcOI0TCdUMOFma44byv O2yGmONxsfFNjDum92JPLY64iVtIWb/DjS2NZMQxpv3CnlP8MZbwbjv8du9u nTtb4K0xcLHwkuAf/nb/9AP3qhRC0FoS+vCJb4xabIahyOlv3kZEwv1a1PIW +Pv3r78U10QEi1ZZJTJY2PW5xCrhX0iQXqATbyx8/dRgaPZ1AZaIWxcGExIR IGohlVCDbzG2EFjIToAmQ48px0UEQinRGGTMKVVi06NuzUdaeG+NJfKy43XA jEgUKq4Rm5Emwcq5kD8td3JollRyKaWWVnoZZdZUcy211lYFirOlll0rrbbW ehtt9tRzL7321nsffY44EqBZRh1t9DHGnNxzcuXJpydvmHPFlVZexa262upr rLlJn5132XW33ffY06IlAz+sWrNuw+YJh1Q6+ZRTTzv9jDMvqXaTu/mWW2+7 /Y47f0TtK6y//f4HUQtfUYsvUnpj+xE1Xm3t+xJBcFIUMwIWXQ5EvCkEJHRU zHwPOUdFTjHzA8RLJTLIophZUMSIYD4hlhu+Y+fiJ6KK3P8pbq7ln+IW/7eR cwrdP4zc73H7U9RMNLRfxD5VqEX1ierj56fP2KfI7revTjNvjRUI8HbqXrdv xdvlv139mjVY7qcXSmjvnE4bo8XF2Po+56wzNhTXorNcILFSOrVFGe7A9LnF NK3KmL3OuveqQXFodY9uQGIfkzocZ0Cv8/S0/XDHjzVuYJly3SeNUl+5pphZ wnA2ydC5/Gms3vWbhUrjhH59OqOcMI3qtTTNBUi/7wWM2upzkzUk28nDkwib peRNfVeuOYkcWVEWoyHtrJzdejkdFUJybDcy60sGdOZf9xzr7tVPLgZWA7un pRuJQj8ELu92/SHFjDBxrTEZXWplj7tcjiRQ4D5UgmkAhMlaKocx7HLjJAQl 9VJOmYvI1pLi7gW+inX1OEsjy85pbl7+BXiFxSL5wj8LObqCTULGAjEO1rnn wFVOKo0ViBEtRMFsS6GXmk+2c1ybjIVsz7WWXfhA8jt3VrhNhlQHFGQzHX4e ZjUS/aSpW55k96xiSA/L0ABTG6msQIjyQvgR07amtR6O1VNaM4TSYvixPq0R Q0zGHM3yu8WsA54kRg4as3LTaiSL7RbO1PULaxupwhzbYriRYgtjo35KhXsz eTLrqYUs3Zv5Uj9uz7vJCkpxmU+FYDZbKIZUQN6Qx76gQSdpxs0I0VlJRj9O 7kq+ESja3fKmRM4l+FVE0ts+FR0WSvOdwJ05zt61BMqn8P6sb3KROvzDV/d3 P+ArI2aAo+Vl5PoF2pjz7GUZf3ZpixEAFndYSd5ZbHu3g7q4hXRf5cRrYeUM qhAAgn8LRDbvzMHbmoHwGtULYwdAYuUWNffgiHnbCcCpfiRIgpvCkk0IC5MC djESpKS45mPpSOM23fU0tA24Vcoq2cCj0ljOvraFsVoKBygJaezT7LbGZftN dsqezHCWvfxRvjLwPQjcpNiJ0J7AyDk1jNJCzGVITzWSgMQPdw6GulgkQwyR PLycbZGTzOSmaicBIevmmMO8w92FvlpzFWp5VIubWS9KCtSKB4IrI5L2fs9F nXrrZyYwoTAR4MoD3iFQ9WE4BCJzWaQh6bqbNaqMer0l2WAGm8iV2QLVEU05 xLhPBy9yIFFLPZpF4JaOpSX5gfmRbh8xqzJnaCWBCZV/8zFKB73YMCswBIgc y5lb8Y+xGtzVUlzH7eZBm7JT2tQxeQBjWa2HdbwR7iqwwRi5Ax/oGWNGK+qe 4ChoR2neDKzG5YI/lfWf5Sq+eofFAEN11Bs1ukG6OOPRrM5B5RbgASIjWTpk OS4/7cPyJPyeRG7xxA0MrlJmznPtjQFsZfrT4csNvEYSgjFwXVYXSjA+yNio PXHFudRaXBQjl5IZYI2qRqLAHq7YrYLgc3cIm5QmkKx0hUJUfavDYmQVP9zm JnFBSPcKas+sFIaCFuIkGFkcdqvkk5HNKz9p3jdTj3B6k468jPV4gAOoLQR6 Znj9dooOfjjiNIqBP/bFpQav+Pm+93/z1f32A+gH4Ukq1JOgssPStw3Jwfyn whyQiGpvyfDNS6Ch2WTRLdsKR4+3mp04YMjSSbs4Ka8hCaw4g4Z8CJHEihCJ Qt1INC0iFkMfTMhRY/MuJnzJbjyHl3Bi8XoX1gP6jZrwECpaqwrtKA1WhUEb vL+mJAjyaTsqdiC1oqgFLO+oPZUQtE3ZiZt46xqinw2tJt6VVRKFNIROU7G2 8cD+uLoo2YFCGIb4AfP6nO1Ax8BvTJXc6wYHpKbvblGt7ZA6tcB4pKuQGMze 3DWMV52icGOw7aiwmrLukCtzCh9JP8ogGQxb6pOFYPm9naWRAVeSXqf0K8U3 iCsY6nKfVW/KAhNgp4IRtc7LgA/xKtQF9YegPNVSrHyu8SKpXtwDcEgEyqIe 9uNXBIJW1b9kgs9IZ2iHeW3kQkbropKAJ+IY4KZMAiC0CBdsM1rjSowX7fnU BzIuAohIyQbYIQ1hi0l2AyJA4eKGAAGhYLnCEaQ4FEJBb4vNIWgYRPKKu8om wWngQLKnFA6ITpUjdsXB6Yqtqb0pcRML3M8FVwuQBrIIgASuO/V19R+RQoyg 0akfOB+/la7ZZml5F682FBXw5jsy10Hz2QgSq9tJbCKU14K20MOpUR2dSuk7 XH1EQ5/Q/RVmiwFQ28dmb5J+YNlAId7Hrghw6NI/lkZ6/DtfixlubSy3rQAE udThFyrPp3Q8UoSlHcd4A3oe1YyER6rHhQIuZGEn6nBDUQZy45VGdSREAR6J BapWqnTiWU7D45jaIEgVrdtl+CdU2ADjeUVeyw4fWDs+n1SSO6jHLc24Qfk6 FqxNjlNVLXnk32DJK1oYyQuKAHukDjA8MAPoGeCXOidbNwRJmkGfUAicRf3o dnJESUKZ+k8d82Faki0rSGitzzVwC/sywE61wVitOxZ4oyqhn0SUIAwQDnc0 QAHAjgxgTRa5jtZjhan0+qXUScl+SRR0xOGaLgEhr6GAEQifCt8jI0P0flJk ngQQHWWxJFtH6zLe4tX3qipkxL8oxkFSTAqWQ9kcALxJBMaSVfckL1kzfTGP ifK3UPbob0IC65JJwCjv405ze8cIPD4EYAC9kK8suFJW/pRy0GXhfOCIT7CC Yy6KuU4KH7GLx9hG9clqOIwliQmeLtQw+W31bhCJoXX4dEaWmTVgqEVYB/YA Z6AnSh0J6GMhqTBUq1IiCMBja9cDTUEHU7MghUBUqTmsgkHYT1QDi4hHJAGQ vTEkvuYkj5V2yehsNAkLFAwEmRNjsQX4oSL3A54OjbcQa7gh3tQRAbFQ3qTG 9lsgenApESnmgB+jGKAkcAbtjZ6BLzHCAN6BmpBCcwSiTQIrTZFOqaNWD+gH DuaKo+x2p7N7UVpeFKGhBRyTbkj+XgkzxsK/GDp/GCJmA1RA5EdWTi2wSg4R NKY27t4SaKgqUtTjkRYpl0UAOxEk4Phc3M5ZCV1MwTI1ZMNDNDIuiJTAsoCI IGNmarfyXvlRrB0431hcFPcqCETCeNOtuGUuBm2thX5BmB0YGECmGOSy/85+ v68Lw4p5Yf2O76iggwZOMD1qRTl1JbDD83WIURg6S5PB1QaMI94lfMBYCX44 2cslSY61K/6naDCuBY6TkDywKdIAJKZo0eFEGQ6R7BURjryANggvspKA9UEy IyhYXMQ1ohBEgRzJu1wzMgq9TzGSkMOEQWTERMPAsbAQlA7q9+UX6IFF24ls BluJt+QVLoscQKHhQQnG1IQdeOszYoOy2RDpwNvqDhQWVjo3y0gguMEQToho ZJtxV+JUKOw4kCDUKF44uowWRMDkhiGW9qDExF19nxmBm2tCIPVgUBcCt8uS zLlQWih3ro3iAHgzVhQM52OsCT/Ez6IN+WHHQCw0PDWIcztNmrPydkqJIhJ7 YgrxMxdyRwaPUzHHeeM8wIvbgqwimabmNZ4b6s7PsJJD8ckXiEshRXQPVp2A dRYiV3WXnDy/YTNPqjgASLmAs9gx8jExJEAUEGhwA4DP2mK8WN9B3cIyov/G RRaGyQW0RCXeaPCLiwloClz+JSlQORQvNQqg14TyQFpPBA0IBuGRKig0hY2c mym7NVJsSKfI20gBTNWD4y9oHZVgQEa4INaBYbTMbTqItzCcBulQJLiNlNwH fEFJ7Gc4H6kUYUIYAlEzkFn5brIfTbdAIuXRAIqPyK2Qm9hww8dRIgnp2ja4 UyWu0IHrUDuIFwgLJ4Ptq6fLE+A9D9mHlInPZmCU0KRSLI14uziWBdAQn0PS 5IjlQUMhVHfWssaGbS/6GzLinixuxloP6PYCc4/Gr3yQw7zjGLH2IBGrsaXK KOYOJEGRh0msAS+q0plegcRZNwQNkSBdq4WI2kNmOO02NRINR0tCJzCIZV9k PwUInB2P7CUCFKotNQeh4N0lTTe1g7a+CRoAtR3FRI01WIc0Gr2jeFkhxBWu EQoCwLpnkkudJNQ6OI7p4q8h9Sr7nkhlVsNRkGgttKIZ3MuNMGUJ6WuMOIA9 3bxQOG4AFoAC+NXOeZ5g7CfOUPOM1pHxH/3V/w4m40SAqB1rPe8plGBuaAem i+CeRNTIK0cJTYUlHwQhSQ50Y/AoRji5W2bs0MVFOIBGhHKA+SsI7QZVFlHD i3RqsTksFmOlPvAdkXStYcJ82BByMQYSrNaGYasIGQo43ZZVyVXMBWMEQKKX 68sh/AE1UlId8ELfDK1FDCPrFpkJH5sUASwEBsBTSPuQZeD2JrS2YahANTFV 11dQq1rtWFhWbYUnUkORrggIYnQoVplspLCxL/29CFKkco8ujBrAXxyHNAas mIZym8TPZig66mdGqQA0a2pVPr0QZ8gy+MDMcH0kKAqg4DqYUVtgdvKoctBT zVNwgJzSTJFt2Fo8LbxV1RGs6k8EFU6mHGHfirzLwBI4hKpy6jUuxhGylGC9 KH302FNwWtygpUC78FG01lI3ed7LMnbKcUrhCR+gBzfxH5qSqbHNZxF6XVm2 qGx1eOS7jFXrSZtF8v94P0TTaZTQZVA9YGMlIvAp8J7QSXR4tdU7q2oSJAOX h5jSh8kyMqJUgfRIpC2xEGojxyEN5IubFZ84iXeEp9XO1FrbyqqrCDyk68FX YEwdAZAtlWcRDnx8yGN0cJKV9w7MuaoyqRRxlzQPQILqgehKUNMG9G5kE5AP SVR5YGMF8VsgyJYPiLfgRRAH2I09qV34HSETRaymlkhDYvFFu5hhJUA5xtrk 1DtUAHKR1vV5TbV9UOVzHaCWyr3Q7dj26YUaVNn/fcPlfnohyLfhFagX5Bwq 69ELyR4gl9s2KvBOuSVMh3wCmv+1JvZMz/dDBd4aa/xAnSJE4oC461G3evlj 1jjJf6z6IH+xikLGim9eQ9uEbZhrYBgCg7RJmHojSXANmK0Ku3p7TgJjLd6H 1Ej4HUuPBAxUJR0hogL7UmYsNl4ablQXrcqO1NI2iYeO56LIeaRUVa8nT5BB 9hFpjNEbZCQKSY3xJlvsbIbYnjNCi6NDQFJCPZVNGWinvJN6CKR9R0/h1kS0 Er8YaDW2N8KQFPausAo4yIDNmCQ3ghZUIK9kvckR9D2wF1Di0COvRxRxU2NQ zc+k3l4lwcq6rsULUWGWo5SfkR/oMNxAr0n7PkQnq1OKwmVlgW+GAhYgpyBu xMDBc0nBZMclcBlUGWasCH1UJ0gSbp7UlED8seLYCcww9R+Upw+PYBKApG2U YvLpOioc2JLBWTcAH1tdcQQ/YWuRIp0kNuDdwUG5r7f5xDxx6gk9S1HUFRrY 6IKOUeCUcScJfoMpKFuo72ovK4YQqUSkCQlPfjGbpL2HQaYhliCMpZ2GQ5Y6 lhjYR6p5eAiUQnyrpQDqkFP3IFNRM/ACYY/DTGZmdDzF7p4yQlCpFQ4jY2pw ayjb+LZSKytzyAybS1s4B505IcY91KuBEwFIct7uoZBQN4CTIaMPueuGZ/mo 5whtUNdloSNImaBtUAwLfN1RXyhkBDWwzFi7NBtRB5kRW9pNBRDMaRPvU+65 pf5P2it/LfbVULWvCYrI1/bDSqQ92CajeVrVvugFGZFHmbXqFQ5Gj7PMRBaQ RmcsVD946d3OR0UMQrxtR5wbpAS0gqirk7QocPDtykVi4utOkCE2Mowzj0dx TmQBybS40BWBQfpgJ1pD+yiwONhHul3BpxQWV8JaET/lpNcqErTI2jV5/w4Q uartko6/yIFvhDmUSlj19WJR0WrIs9Rkt1o0VLB62JAg2B8W2hOdbDBMcHVB MoxUO942t4eb4OKpVl2QImC2FZZWYyyomcEPXjc7elQhxgeZEMHE7ZL21du1 myVqsHOYFxg0IoQQP9R4er0W8iOJ0OJuW0PC9sWtPlqhNFnW46gjZrcZT8eo Qj1F2nDlcnBh2jBgGIFJYg+RX1fdeXmdzkxmNJjEUOZlNtcRktSwr9ryPt2Q EqDIwKYgw+L0alDBT0kVTWaC+7vfpcxGiwUyb6nHv7bLGw+HMtM2b/u0WFGj QAFy+YBfSELlBqZ9HFOLjvIoSwiGTzyIi6RdsX2dUBobL8k3UQ6oNSCLqio7 yVdgqNDUiMaKlg/YaOC3GrBP0EdCg1UqDlaCjpp6HIhwFE/QnimevXtJPRAc FYdnI/B4CGzb8VQ9ohGoqjDSYiqVG2hbfrhYtTnpXzhNHrYQUpQiA99cs8L7 UTsGUoJTWyjaxIckVsBP5nfYqWMx8P1UCDAGtKyFoJi1AkMF5whVJg3F1OzH +XkIlNWO+Af4lAVFpvQ7lyQYes/BweCcNijuXmDn7b5AIMSHrK3AQcfzR6/0 yyzr1g5qRGTierT3BU5CX0Cdo+jxORtSUwMfQgNjKobiG1uq/x93VX98df7f fOP/z4XQrKyQQe24MASGuL9bQst6ZDlvWoAz5SIRTf2zMAAzYFIR92qkqpWF VcLeC6BY66kyjHh93532mfldIDxpvxi4FgrAi/77EwLqgQF0acSOBLAV8a6F N5BSaD+kYdJxBKkRtPqtHbjHaSbuRjUBABkfGwgtMgLO9/XsMUgo8VLxfQ2x LsiXIl4M7+PUw4xxC6j35rMYn/vzvXQraoK5XB2JIR1JUvRSBdxwtQlzTKI6 rx2XEnFDCCYk1YaE0WPYT4EkN3y5LF4Hc3NX7xHEu1jv65EuU3vTOsvjSn0H TeTqAfqo4zddR4d8ax4PAUYh7aDfO+4AsaI2DMoEC2vdhnAh4wZwW1xSK5DR MYpf1lAnaj4z67+PmjBCL0YxHCijtusiwhmKxxvKgejzBHVzOXwnqgFwWSh7 BgXnqJrRWVvdfaH2jbkkUMUvHKRwSy6SKUXs5lIcYGSS5vdJ/Wm0o32G5ub3 2H4fmv91cJtcAuFFnB7c53MFAQ1krG5O27m1fgXi9AKxkYdSZ9BqeTs12LjX isZNI68Qs0AIvJyLyoSgwm9tYI7JhC3KEhgHtbPByXwYDByIsJfbswVc6+wW CYOivdQS9ApjlSu1GFbxUv4IuJs17iniVpS4vQ2QT4QGCU6ENfxsgDkMTrlU MQb0aSwdGaNWA1YUAvubvVxkHJUGqOOAQt7kDk5c7RJAq01UA7qfq09yMLhG NDN1NZP29PuldqeteWPVdjJWMlydNJQ0FpVh/UhezJjISBvjOjekNj/h10kP yWOsH6uHGMaisgQNAeELYQ77Y3XebjIAoqNA2BsEEIFicXXcB99vmOVV1TNI F3ZBUuaKsjlSAVtNY+0s4pyRgQSyjXEE32iaDglFirYbFHbx/RdLAkuetpg0 fiYGdCRrq+0rhdNQce0oXnBwgG5ginN5h5zmJhIduV+TEyZqI6ohEQ5Wh2Ed dcQKLk0t3ZKQ3QDOEjX1Vv3FgUBZpjNRI1MJB60dUP6wok6ZHJgT+Yvqw4lR +ls722h9fF7QDmel0iNqg4zUDFjsxji6OggHl41fUwdVR0ZC6aQGJIp+EiID c0ZVNrVEESpk/2Itr3aRieVQMxoTUkSXMm/uuY/8zAlFofPhgixEltqB1xBS hJJ6azqigp5JF62PHmf28qP5deR4xYHyx9SOydJsQy2UygLwxhGokbMl83LD 6peFYfSGBYBRMKM2Vq7aeqEcC4Ids3TV6H6ZTuBwFPgJmJlvQHxisuCC8bbb 9/DaVB0Zrtbukc5ewQJqjjowt7HWE2hEENi9KKqqTRrZ0hVxZUJF7Pc6W0Lr 6Him2nZZh1/iOwGjVXSBkWBGn6QkSwGZpO4/yhY00XYNCffGCiSkDMChgs8A +yqGHRxSg9/OTk7aBi80BIdGXiL+qHDmiuNbG76ksMhOLR+ufhMaGVQsKsoO uESzsZpm4+33+23etBPGL92UpcDCBWU3mNzVtUcbbb1AWeaedbwGB77RqEO9 bjjYRaEXF21SVQxmzBKoc9uwDWt4DiIO2QCJgAng/y6gLZndN+UYcBJN5zDI I+BK4hL3bzgOcsKrWYnuy20NbCXYRrCKtoPgLTweinn7VXVDzBO5qfM8YzgS GsOoYyZFB6LgBKCIdDdDbWBzQPLwPDf8XNQZTSA3L/SJzZj8UA3esZf7CLOD bdPB3D8roqr9Udm3pZ0M+MNQj8MbzN4wFxcnvJyaq0wy6+Rjxv9g8KunsifW FA/BmIz4Q4TzpIOgzV1nNxEtpWG3prQzAyzDeeqEPMLzok1b40YHiY+kx6NX Qsi15Wcg6aWhg5yI4FGOfCx1wlC1SiM64lyLjpBpgzm8bT7tg8TedCIRmFrv VCDABIri+JZ6+OqdtBhuQrlrR+dYd4h7yLcEHSTd6GhVPUU6dIIdc32W6JB5 KhBQChiVcNkrUXTW0ntoIBD46+5YF/jBqlPOSAbgAT4qmExybiIQKSivwwUZ /wSzUCtXA4euhU4VUCaWKTjA4mR1sK8xsL2eqhusynk9owPwogPTQWZ1vGPQ CcDdIU7eFhg6NYOmKur5o7goq463YDhXx1gM/MIaa8fXIxp0/C9REs9HRX6r NwThJWEAljiJ7xw0Cp00xG1TPwfFAHLpKQl/dI6YcL8tacPiwHEnJ4zPq8/4 OrxendSGhXHEEMEAmHudF8bQaopKMfgPfTl0Bkgf2TqdnpG+Jplzs863JTFj WAcI6w6ppJ0SxHyGjHVqGL4qwiF4DZgD2YAGzF0lsOgwon/1oAjIfjC2nRxX Uzg40jKMoX8sIicHpP5Xwt+9k3VeUT1oAcHgVoePMRSNFGZ6W1GA3/S47L11 GnRfaYqExmG5UtKR8gdlVGsj/4GloazLDAj6YbaxemTdODqkuxMG0M0MFqu2 SIwTtWfqBRAJrwUyzopVrl6HjRpRIEKv8wE2wKWrHgTJAPsEtfNo0/hFAC3A Dd6esVEb2lssgzlSYHCgR4Uj+6oIXk6vMo5oBiji8XGQxLWqr6oqyaYjZxVR ON5OiLW+0HpDMafgxI2FSIOSeppGbSkdgQw6NlGhbAxreMeaO9WMpNGZ0QAJ AcctHnUVECpqEIfLaMT8XQeug69wUQvomoa9cGkfpRy0HgSo2gdeRY3apOkO omIKNkoI4Djqj4mLQH6IMenmOg+FRHRfm1YXkiTN/nZHC1WDBtisLtLLr0Ta a/9rCWYBA234LrUukVZd54x76L7qyaG+Gf+R1D0oCqAJB6LKRyVoPxysQanO gXyJ0seGzZIgSO9MDzGjng0loxNuL46eGh1oOu1yIowBpV58IwA2H4ztuhje ojhcifs2ryOIhqeaLOEcOquBqx3ECqbhR+BMzWhHKf6zVmaE2rHWUUuSCWDG HWXtCZMDSU0BHX+N8EBWGwpNzdB6DFldWk2qFykdMgs80UEFPV4RElS6VnAL o1d03EQa0MAc9YmpRcJraHxyBeGIEGZygQVbr5BAjl+XwWkd3mkcTd7rMFrL VZ6yaN80KuSAdWuJggb+NCOdVLMpYmJASKikkqZEdDbD5DtAiKhUnV+7EcA1 LItsaBfd7N/h9AZxdHinvTsl9RPPtNvMReU+agY/jhQbRB8h7SW1PseQgYC/ QcYI4arJJ6+UcZADR5CRdlHaDv9AxWR1RcVi0XMPUl590KTm45MAY/WlE8Y1 Te0Jo5W0CbVsoF7xjy0Z1oWrl/IFaTDeB9ISiPRGQ3VM1vo+VMQ6Bgz3BelR cU5OJQ17khIVgoZBXQ1j/vgp4jJMx60PAg0FopFXHSSHvX/BUfcTkJazovrr ADeVeXwt1BdXguOTpChFKoG+u55+MnRgkmMrrIK5ObAAynVZaBKRUbfzJrKO L0qRv8znzWYPqQ+qAk5d2u7FVq2rJ1h0ejXorNzU0SOdxUchfNr2k4T34zW3 oZyQ/3U379/9dDdEiNSIHnlBA189VVR1RgM8itPrgRLteQ30DTaEbNE5Edwe 0TAdTAe+HrqC76yfd6QsBMfoyHc+CBSqs7LUISAD9pT3bu1PuLAAhKLTVwlU Oq69XUDyyriYWlIr6qDYVOcB8CezqqaFatDO7tQzEg2hijCLIyxLrFXW6VY1 NKtcjI7HnWY68IPa1uPDUYVXtUcjh4cy0qnTI+Ir/etRC1Dp+0Cn037hMZ3H BWh6fudXoQ2DjZAgEABGtqFetSGQZPt1bkb9IeEaK7tX0IFFlL8ekEG/qpmv apOOkAJfcELSqalS9QSOdm6pTuqaCUfspajcK+6EHVGfdR7yneE22SB8xL8y qGJeH5PgpNsnhYoO0vDm9jmAMtunb4Oiso8XyThe7S/r5HlSH2ZVrPJRSwQx KfV+f7qX7pTePljXoYwE1zqv1rYe22lBp+fOmDGKei7CVU/qaIOx+dfVwG1o r1znqV+3cSMATMdaqEamtq72unb13evgWJL1U/97+Pf4VxVibz0uhmYkJUER zAq6O8hg6/kHaGLrFKueWwHM/e46fagng8DrY6anGfaV4FDL8zA+dC6qwN+q xpT8MchedXwKh39c0JNoF87ziMrxtcJ/WV/yoSFu4LQGsthmHjAy6by1PYfW 06FrH7MjrlsgtbxBuLpQ1YXa94Xi8xAe5sWLBsKuh7tC8Tr7dpCNkJ2O/Ban 58Z+D3R+GdF+itJVH4zqgEYoJ27WdTRCJ4sA5ekgXC9/iO3QU9wqzS6JjKFH FCDRCxoFhAgvcXw0dZd0EpbYlxqwhjrjMrHrkyqbpdg7mzY1h+/xa1PqGNZF zxOyKKbVxfLrUbKLdiHZHy7BVEkPntSHuwnB8g0QQ8ckGqrkarfyqeyLtAJN sMNaXD2F0CAK7VagxKEj70LQI5RepwcwzGLtGrInq/bRc80jk/aoBPQs5I7O CP6CmTfFrtPwwDmSTeN0fx7oH8fZPuP8HA75daSSfnok1mIEzScJl7yIcckV Yt/6x6v9SIsf+RXV+s/Wi/inJu+yTvvoZKwOMGRI8Wh3HJcHStX/cYFr1Olt nVsPlLjTg+AYvPQNEXt9rfBn1GGzolx+NsGDrqPNdj1yMdfrISRIXgF3wi0d dQnv2EGbOYK0oANiE7/3+R8ElKwjOkYt6fzJ1rFFCAiunF0n8UH105x6u/2d s6CueC8aZWLowSdqyy/R6aDGk/oeOvgdYNzp/5L48QOFTl2ydzud290hYIn1 UDbqdH5qoiblpU72j6ND5qHgS1Fs1D1LGEkhYgOLpLXD3GCQThoWSBHmRymq laltPcjToi549PRbVAcpyhz0jiGfgUigglie5CKUixIbb1cQw6fI7qXnPYcU NCUStU/lwxZSEr4aV44WMWnLrg5FA8iIdxfWMp20g5HnV3+PNfru7wVpGSbX 1HUrUpZVR9JT1qF9eHRR2k197eFsjIYi9NrllvhHNlxtwUG5V8dZcfWsfHzN voSEfE8x1iZnhvOyZ9DWTlf7/QxnUjMIh4iIZL5JZ1dJEGgCOga3buO1Tm1V PYnbSSevTTu15hIXJufV0QLS9ThxgVWv/tcEEF97nRLtRkxZS/8auuTMfhpC F23Ub1ZTOWtnlDjqqOd7qIvKQ4aOT6niuD+F8Kb5Cpzw4z4/Wxlo3vg6pNpy YbV0cMnFsHgbUqYundrX8TcdhD9BnZC3Al/X/1z9c23/dfWmq+M8qCLtZcNw aBltgOgJwaRBH1YTL+vzeyQiqxdWt9ScpZOzMr8h8VLX/75BveU+HHX1lqEh CFG4lpCG2p0ZMLE0vp7mJXVhx04IR2N9vY6XHD07YnpuRKSxigNXq8zX2xH+ vmrQFnkXk34vw4hSNDuCpkl2IOg5Gj1lgfE8A3PiekNB6Fk+VgJHTnVsMbSa Fd+XlXq1PpYdibF1SalsH/qa5VOy+SLYS9HxFfWlNtUBs+p8BUyCDvRBZk9t MSipvP8XRg7azQhJj1kyzLNg213PdTCeTlJTE72mlMZ77GzrkRXBjXb71ipd 55a2Glx6diuj9H1epWHCxJuqvUr4jzr1yKKES1xYftMeI4HzehSydmEette/ p41SVtWwGClRy9pe1lnzBMAyIrTJ0mGLIypX6Lok8ce4EDxdtr3LAgXaTBp6 4Kd1oq4d/2PKkFrRR11PAp7wykec4aGTqFVO611svYfQ9NTppzxIO6FMHDJk /bwD8Se497gOfF3L0YYBWBBkipUwOuZetBuvDa5P1akzrII4uF21OLWptgZO 6TidysQmyAlcM+0X6lQQmhEIkGBtepZ963jC1tEZkinO9lkJPTvyulkarvtY AkYshwUpH4nHV0B6qF3PFyQ9w9yE0jonpHOJeuzWH6G8nod4hd0cNbY//SPU ivS52PKsqh/DhTZQhbdKLSMr9RzK0D4j2ZIMnNl6eNSTqdXpiT+CgEfpLHuT avpEuuAFlKY6Y+kTSLBAfjSf9uY/R7DexlQNldie5ChkcdeM7+i72nY23H8D uWZ05wi91FUAAAGEaUNDUElDQyBwcm9maWxlAAB4nH2RPUjDQBzFX1O1IhUH C4o4ZKhOFqSKOGoVilAh1AqtOphc+iE0aUhSXBwF14KDH4tVBxdnXR1cBUHw A8TRyUnRRUr8X1JoEePBcT/e3XvcvQOEeplpVsc4oOm2mU4mxGxuRQy9ogsD iCCEuMwsY1aSUvAdX/cI8PUuxrP8z/05etW8xYCASDzDDNMmXiee2rQNzvvE EVaSVeJz4jGTLkj8yHXF4zfORZcFnhkxM+k54gixWGxjpY1ZydSIJ4mjqqZT vpD1WOW8xVkrV1nznvyF4by+vMR1msNIYgGLkCBCQRUbKMNGjFadFAtp2k/4 +Idcv0QuhVwbYOSYRwUaZNcP/ge/u7UKE3EvKZwAOl8c52MECO0CjZrjfB87 TuMECD4DV3rLX6kD05+k11pa9Ajo2wYurluasgdc7gCDT4Zsyq4UpCkUCsD7 GX1TDui/BXpWvd6a+zh9ADLUVeoGODgERouUvebz7u723v490+zvB3gHcqkl oKXxAAAN/WlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPD94cGFja2V0IGJl Z2luPSLvu78iIGlkPSJXNU0wTXBDZWhpSHpyZVN6TlRjemtjOWQiPz4KPHg6 eG1wbWV0YSB4bWxuczp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1Q IENvcmUgNC40LjAtRXhpdjIiPgogPHJkZjpSREYgeG1sbnM6cmRmPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4KICA8 cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgeG1sbnM6eG1wTU09 Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9tbS8iCiAgICB4bWxuczpz dEV2dD0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL3NUeXBlL1Jlc291 cmNlRXZlbnQjIgogICAgeG1sbnM6ZGM9Imh0dHA6Ly9wdXJsLm9yZy9kYy9l bGVtZW50cy8xLjEvIgogICAgeG1sbnM6R0lNUD0iaHR0cDovL3d3dy5naW1w Lm9yZy94bXAvIgogICAgeG1sbnM6dGlmZj0iaHR0cDovL25zLmFkb2JlLmNv bS90aWZmLzEuMC8iCiAgICB4bWxuczp4bXA9Imh0dHA6Ly9ucy5hZG9iZS5j b20veGFwLzEuMC8iCiAgIHhtcE1NOkRvY3VtZW50SUQ9ImdpbXA6ZG9jaWQ6 Z2ltcDo5NmE3ZjI0MS1lMjNjLTRiMWEtOTdjZS1kNmU2NjliOTk4ZTIiCiAg IHhtcE1NOkluc3RhbmNlSUQ9InhtcC5paWQ6MGNlZmJjNjYtNjFiMy00ZDZk LWExYzgtMTg5M2QwNWFjOTg5IgogICB4bXBNTTpPcmlnaW5hbERvY3VtZW50 SUQ9InhtcC5kaWQ6NDIyZDdlNTItOGE2Ny00NmExLWI5MjYtNTJiOGEzMGIx OGIwIgogICBkYzpGb3JtYXQ9ImltYWdlL3BuZyIKICAgR0lNUDpBUEk9IjIu MCIKICAgR0lNUDpQbGF0Zm9ybT0iTGludXgiCiAgIEdJTVA6VGltZVN0YW1w PSIxNjU2MDE0ODk0NDU0Mjg5IgogICBHSU1QOlZlcnNpb249IjIuMTAuMzAi CiAgIHRpZmY6T3JpZW50YXRpb249IjEiCiAgIHhtcDpDcmVhdG9yVG9vbD0i R0lNUCAyLjEwIj4KICAgPHhtcE1NOkhpc3Rvcnk+CiAgICA8cmRmOlNlcT4K ICAgICA8cmRmOmxpCiAgICAgIHN0RXZ0OmFjdGlvbj0ic2F2ZWQiCiAgICAg IHN0RXZ0OmNoYW5nZWQ9Ii8iCiAgICAgIHN0RXZ0Omluc3RhbmNlSUQ9Inht cC5paWQ6YTY0MGI4MmMtMDg0My00MjYwLTk3NmMtYTg1ZjA3MDc5ZjcwIgog ICAgICBzdEV2dDpzb2Z0d2FyZUFnZW50PSJHaW1wIDIuMTAgKExpbnV4KSIK ICAgICAgc3RFdnQ6d2hlbj0iMjAyMi0wNC0yOVQxMzoyMzo1NCswMjowMCIv PgogICAgIDxyZGY6bGkKICAgICAgc3RFdnQ6YWN0aW9uPSJzYXZlZCIKICAg ICAgc3RFdnQ6Y2hhbmdlZD0iLyIKICAgICAgc3RFdnQ6aW5zdGFuY2VJRD0i eG1wLmlpZDozYTUyMDNkNS04NGRiLTQzNDMtOWZhYy03NjFmZDZmZmFhYjgi CiAgICAgIHN0RXZ0OnNvZnR3YXJlQWdlbnQ9IkdpbXAgMi4xMCAoTGludXgp IgogICAgICBzdEV2dDp3aGVuPSIyMDIyLTA2LTIzVDIyOjA4OjE0KzAyOjAw Ii8+CiAgICA8L3JkZjpTZXE+CiAgIDwveG1wTU06SGlzdG9yeT4KICA8L3Jk ZjpEZXNjcmlwdGlvbj4KIDwvcmRmOlJERj4KPC94OnhtcG1ldGE+CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAg ICAgICAgICAgICAgICAgICAKPD94cGFja2V0IGVuZD0idyI/PlmiVpAAAAAG YktHRADwAKIAftw2PhcAAAAJcEhZcwAALiMAAC4jAXilP3YAAAAHdElNRQfm BhcUCA56CWQaAAAgAElEQVR42ux9Z5gkV3X2e+6tqk4Td3d2epN2tUlhJRSQ QEKABpFE/ggm2SAMxmBbtjA2/uwPJ2wwGNs8BBuDbTAyOdnYGIEtECMhhISQ YIXianOc2Z3diR2r7j3fj3sqdO/M7Ehik9TneXq3p7u6uvrWe8894T3nEjry mOWnT79UFdaUledrUoFPBADWAgzYRoio3rTR2CQfuW/UPuPgdu6M2GMX6gzB I5MvAuqiN7+8N9/f1Uta94C5xzbCZQCWE/MSUqoLzAFZVrAccWRqNoomOTIj 1vIBT6uDNjTTptqYmtkxOnHR5ntqnVHtAPe4yAcA9aprX3O231N6ktJ6E0Ab CLyWmc8gYFApBTADlsHWAswgZsAwYC3YMmAsODKwYVSHtXs4srvYmK22GT1g a817p3cdvOein9871hntDnAfs4x95DeWB+XBl0S18MW1feMbibEUhD4AgAXA DGYGCVhhOXkNNn7YBMDuISCOH5FpIjKH2JgDpt78cWOy+vWoEd1y/o/ujDp3 oAPcBcn0z79O/uKlJZ6aXG12bX0bwuYvAeiv7DgYmJkagWXAmMEWABxQs6CN wcqMFKjt/xsHYjY2AbH73xgY2zC18CFTb36Cm9G3olrz0Dk/vqvZuTsd4M4q tT3f61G54tNA9FoeP/wqs3NLCcagfmgS9f3jIM4CFSBmB073T6phGQDbDHjb tW1sPlhQon3NUSBGZGEb4RbbjK63jehbY7f85L7LEHa0cAe4Tr4P0OUjt7xA 5XK/CqWv4kp1UfTQPUCjhqjWRGXHKLhpkNW2DsDynMkBVQCdALXNdKDY/s2Y DWwtyLADa6yBI3kexQA2sI3oAW5G/9mcqn7irLt+uqsD2ycwcOt7vqOY9BqV L/wx+cGLoPQAIkPhQ/eCx8cAZtT2HUHzyLSAVAZMNC/Hmje2d5E1F6zYuQCx PE+ctVbTIQYtotgeNmDDgDUpkCMLhKZpm9HOqFr/a2v4c9GRmfDcrQ89YUNr +gkJ2t3f7qEg9xKVy3+afP/ZINUFIjIj+2EO7AGshak00Dg04bReLC3gjac9 y1NuUwecqoW246ntfOCMCiH3lI5WK5qIFmtPX03Aucr3HvytpUsP//3IKHeA +0QA7Y5vbaRC/t0IgveS5y0FiKAItlJFtO0hoFEDW0ZjbApmun70CZgyiJsN gTHwSMwKyiA9A0aOj6UW0B6FYzpqUfSUUptI0ZUKmH7TpHrgk80p0zEVHqdS ve/LSnV1PY3y+Q/C858KpRVIAUoDDITbt8Ls3ApSCrYRorL9oFu6E13q7AVi yuCWW7VwxmEjMR1iBy0xGVqiD3GEIXXYkHHYkvdixy1yNm9sPnAzGjfN8PP1 w5U/O3fLA0c6wD3JwibSbK0GW5+NLbCNjA2bDQ6bhqPQchRZNpEtrjlrQctk 9YEv+6pQeBHlCx8nzyuz0gTScMBVsJUaGrffArIWpBTqByfRHJvODBCJkkyX f7KZEUwiDXL9MTiRcdjaw2aZBEUK3NjObQ2XJeCNDDhiUGQcsCMLNE1omtE3 o0b4e8pXu9bdcfcTwnTwTrULMmFjEVuzni0vh4lK1kTEJiKOIsCaBlszzdZM sAkPTz949xSHYQXM1Z4nXTbrclm99/NFlcu9SeVzH4BW3dmVGaI8w507wI0m oBWstQgnKslSziCQ876S5Z8TwLZaDUycrPMxnlODFanZEL+usrpDOa1MBCiV 2gwxyBWBtQLYgKHSL2b4CniF76mSZf59APd2NO4Jlqg6vQTAZTCmLwYsoojY RMaayMJEPhujOQVzncNwkk1z3IbRITbRyOJnvHAyNQ8+X9CFwrWUy70bnt8L JaYBacTPbb2J6i03A40aSGuYWhO1fUdafKv5BooZIMqALLZtmVvBl9W0nIn5 xq+bWTSvbYvtGuPeiyMNJmM6GAbl9O3N6fp163545487wD1B0jh4gMjXl7C1 Z7GJFKLIMts9BGxja2esiRgmUjYMCxw2+zkKl9owLLOJijARWRMZNlEdUTRm w+jhXF80mh/w30aF4l+S9rqgtQNt/CD3f3PvftTvuhPEBqQ1wqkqmmMzqe16 1GAd7Zy1BA1sm/0bZ9CQPncWRzZpkUkNcxa8DDbGxXqtgDR+L5S/TQpgHXgM ojubk9W3nXnrnT/rmAonxK5tehzaIluj2Rpma7eTUncWVp8Vth06PrX5tgNs 7QMwkeJmY4BNuMZG0UpEUcma6EzYaD1pfR4F/luIkBPPqQ1qTqWaI0fAjRBQ nNqnQkkEEZjIEWbiMxBnIJzGcuNvOEr7QlQy24y1EM+KTMRBUaqBKY6JMUgp MDsnEZ4CIoBgwR5l7Q2AGTay5HcFTwl68h/ceeVT3r7m5h9v7wD3OItt1tlG IWCMYhM12PK+nk2XhLMd23PB0xJdBuAAgAOj//VZn61ZbqNwdXFQvTS3uPBG Isq1hKJa9KN7bmZmwGEIaAcAHXiIFDkPPrED2j5Oqf3bEpeNTYckOpaJAVNG UyukSQvKfI2iVr3ODsCkyH0LE6Al2MYK7AGAkRMy2DAsA7rgP5eZ37v1souu XX/7T490gHscpbj6rGjq53dU2BogipS19hF5x4MvfUMIYFf17n9eqoq5FytP dR29zvNRhhKDYKMISkLa5Cn4/UUXVbAupcs0Wyx3lvPNYnsxZ4E9WzzXARNW JgQh0bgOsCxuoYA30bAWBAX24vnrZoM1FirnQxf81+RQOnQj8M7nOnQ/rkSd UhGFWvWgqVUiU6/6tl7pfcSx2js/PkC++jPy6KzUPIhVIKcevizDYED39jiz MjJgE4EjA5UPECzpBnn66Ngrs3ATRCPDgpH+zVnGWBwBludHWcYUTx52c4FE 9SqAldPApMhpYqXccy1/a3ccKeVWC3m4cxEo5yld8N941vOe9pbHo8Y9pYDL YWO/rVWnTK0amGqlPPrNzwcL/ez4v/+5B/BvkadelLC42jJaRyk+ZgTLlwF+ DhxGCXhhDXQxQH55H4LFJaiCB/KUA1qW6WWt8HIFfAkrjJNH1gim9vgZ0tBZ elnueCKn6V14jEQLKwE2pWBVAGnKAFdWCN+DCrw+rxhct+s5l118/8aN1AHu cZJFV1wd2Ub9XlurwNSqK2zYGFjoZ/0l3c9Xvn6HI7s4NDHzLIt5JjEAhtff i/yTNsGGkQNvaMCRAUcRQIygv4TCikXIr+hHfkU/gmX9CAZ64C8qwesrQHcF 8IoBdM6HCjyQryWRHpNonOfPcTQgq30zThqJicCKkjgxqRSryGpgUqlJodwB DrwO1GzZTTRfQ+W8c3Uh+N2uM5eUOjbu8XTSarVdNmruYWPWsok27f3sRw6u fMN14Xyfmfzvv1iuct4fgdADy26pzWhVZLQftdu7xCiesxGILGp33gmERixG 9zkLgDwNnfOAonJLM1HCMcjGGBJeQRLGlZBW5GxPjgw4NOBGCNuMYKoNl/iw 6bUloeBsAE4ULospQYpdEoKNHJwlO5D7Lq3Er2RoBK82kfnOtisv+cK6m3/C HeAeBym//E3R3s999CdsomUcmY0cRTsBbJnr+MOffZf2unJvIOJLnBtunbPC FiS2KLNuATC1k2ICH8WLNsFbsgi1n26GnZ4Em2YmicCwrKEYYM/ZlaQAaOXA SgJaUuJXCdJiGyFW8vH5LCdEdI4MTK0JU2nAzFQRzdQltSuJB2KXvYudNY41 NLtMGqwYxNYBWJGjRSoCPC+2PAK/K/eeqBF+F8BoB7jHS+vWa4c5MvewNU+x xlyx7UPvPrLune+btZDQX1TaCMIbAeQSMncc0FcshYtWNJQAxrLEbV1CF2CQ VsiduQrByuUIRw8hGhmFnZ4G12tAWAfCJtiGQDNyqWGtQUwg0oCWeC9ZsCzj 1OIJphExzsRsiQHyPZCn4ZXywJIesImBXIep1GBrTZhq08WaORMyY7lyFcfW 4siDcpPVMpSvwYEnsQhenesr/h6AP3g8APeUNdh3fPQ9RRs1n8/GnAFjdrAx 393w7g9VW0yEb/yxTznv3bpU+DOVCwDfB3nuAc8HPA+kPEDLQ2lAe+CWtK9y z4lApNyQKPc/hyG4EYKbTQhXQlKwkctagUHW2cQEYX+5WDQoioCoCYQNcLPu PgvKmDApo6w98ZFlidlmCFMPHZCnazCTVXBkMsWYklXLknUiC10K4PcUHYss ioBmBNsItzanar+0+pu3/qwD3OMoD3/gXQNszP+BMUU25ic2Mnec875/TOqu xr/yByu9ntLdqpgfoMAD+YGA1nP/ax+kNaB9uJSvgFd5gFIOwEqlXpBSmWVe ZZIPqjUR0ZIZQyvN0XJS/ZDSFg240QDqVXB1GlyZBlcmgXpVQmwSTrOcOHDc UuLj+Ak2isDNCNFkBeGRGdh6U0p9suAFYCzIU8gN9gChTZxNbhhj6s0PTNy7 /z2bfn5/2AHucZSH/vTajWzM89gazZG5ka19YNPf/SsDwOTX//B9urv4R5Tz iQK/ReOS5wlgZ9G6ygMrBVKO2ug0MBBTHSlejikT8CeAWbUl0lqdojTjlbFr M5oxKWM3wjlo1MEzU+DpCfDMBNCog8M6OGwCRiaAkfhwzMmNARoahNM1B+Bq A7YRyXnTmrf8qkXuPKERu9nA1sKfR9Xmq1Z99aYtHRv3eCYlKpWtUKqPjbkC xj7LGtMEsPXwP//mMqXptWBLR3NdnZYisgBZMImjJsTw2CYErLMZrQWRcl67 smCbAShJViqpfKC20FqWdBOHstLXKE4oAGAoB17tJgrl84CfA/UtdsCqVYDq DOzMJLgyBcxMgK2rTI/TvkkGzdPwe4vwSjmYSgPRVBXRZBW21kiiDCyZwGxZ kcrx+RSZK3a87BnbzvzPH5y2GbVTvnTnH370M/7NS590iKOwyCZayZFZ/mtn rR9dvGnJy1TOfwV52leeLPOkkqWf4r/lQXFgNKMhCRLgByVJqzRcRq00B8qE uxJiubx+lPZFi2kRg7m9Lo3bExGeD8oXobp6QaV+UM8iUL4AGGcvE7ddV3zN noZXyMEr5qACDxxGYGuhSzmoQCe8oCTRYblP+frLH7pnW9gB7nGUj9+x2fzG xecesM1oKYxZpjXO6FrV/Xqd99c7G1biq0olYak4ch+HqwAl2ah2AGa8/hha TKm2nM26mqWSkaid7hh/dyuYqf08NJsmJ5DWYD8AFbug+5aAuvqE+hhJ6CtT jZEkLBR0zoPXlQdpBXgaKtCZ0qPkWlc2p6r/+eH7dx7oAPc4yz/+5L7oN87f uIejqKzz6ik67w353UFR5XxQFrixxo0B2wJeJGGjJKqfZNFUGxYpA+A58EuU wSQfrXUFnDQLIz3W+URHfwFTWyElKVCQg+pdBOruA5QHshZswgT0JMmU2KzQ +QC6qwjl+RLL5qzWJQDVD/1s6/90gHsC5BObH2q+/bz1I7m+4GkEfpYJDfnd OajAl4ySSp0rSvP7FCcDkvwpzfL/LG5rsiRTK7E8k5WjozTzLDbwUeDN2MDy eUosZEoATekMSTW254FK3VClXqhc0dn1Yf1oCgQBKshBFQsg7WK5HEWp4if0 vW5L/dP/1JiMOsA9AfIXb7lC5RcVXmItPzmsNhHVQ/jdeSjfazUXlErDWImN mzUP6JEHVtiRZx3uCG053xatfrSKbbOFidqOEB1MbYVqbXZ3ch6tnT1c6gEK 3UDYAKIo07OBQYEPFQRuRfI8kOc57oS1IEU6WNXzgw/fs/207IzjnXYXnNNd 5HuXeqUcZkam0RyvYGr7QfSsL8Pv1s4OJAkjkcRBYR14LYNhj4Zqu8mb7dih tDtPrAI5Trva1AyJqxYSnZkloGcKexTJNcQvKYl6xH4jAVaBlAWzAhQjtYA5 5T+wc7gckTwPpT1QsRt2/BB4bASoVR2NR2vAc+X35DOU2M5mega2Wiv6/T1P N8w/auzewsrzTX7FWu4A9zgJG7uYPD7Xy2t0repFZf8UGocmMcWM7vXL4fd7 SdM5F+aKg/tGaCyUhMISZRnnYpXYiUoSCETp/6QkR6tS+1ecvZTdZVu1aYsT lzEbIARxJba1UCIpS9Zjm8SQKWPJZvluBBbwimmwuAyUemCOHALGD4GUA2pM u4yvxOvuhvG8HFTXUOWhzbfrXK5mrZ2sHdg1rTx/mrQ3HSxaajrA/QXJyJ++ kmy1cb7KeQEsw8/76DqjHzN7J9A4NAUbWXSftRK5xb2upFy0LZEFWwLYIOvX J0kCBZCSrBepjEWhWioSQKJR4wSFOhrAiPmwMZOrxXrgpM6MbOoTAgAsuetw vLS2OHEavyXWLcVChEjAy04L5wvQS5eDu3qByjQQ1Y6uygBDI09EXtkcPniW GlxWBxETUZ1J1UipSnPy8GGl/f1Q6pBX7LId4D6WZMRMhWDNxV5vIUmRenkf 3WuWYGr7ITSPTGPyvl3oPXcNckt6QUYIKCZmTikwmTT5QNwKYEmUOWXHDszK 1X7F3j8RA5bSpEQM7qTVAWcAzWn4jdEaKFZZ8Aq0bEpddCnoWfxFHWvgNJjr XvdSzjoDVCwBQQnUqMPOjIG4hpTX7swOCuu56P6fPOQtecFegAYYWAqgZIEu ApYyaKNSQcU0ajtIeztJ6xqRsh3gPkKhyBDXG5tsvQnKec4UsAwv56F34zJM bT2IxuFpTPxsG3rOX4vC4CLJiMXsKSN+i3GVtko7jaycxkvWZPk74RwoSstq SIl2zfQHI5VoXmTrx5iOtpvjyshY8yYJihjAbrJRsrirWYMdaVxCZ173Ms9Z EjAeSPvgyjioNikmkgb5AFvbT4e2e91nXbQFwJbK9vsVrOmDCcsglC3QA3Av cXARSJ1FpLYx824AE0TEHeAuUKofvRHF33nuRlttQHcX0nZFiqE9B97pXR6q e49g4qdbYM45E12ry0k4LE6Zoi3k77DHwlXgFFxKA2SkYLLdUROerEo5sQzl eoslwITUoVHatSaxh9MHIcMFV7H1qqSDjqSiMwBuddg4S6dw3GMwCB7IKHFG A6BrMeDlgMo4UJ8Rh832kfUWxectrT3XAjgC4Eh9ZPeDMKafQWUAZwC82ILP I/JXEaktzLydiE5aKE2d6mCtj+wmU68pZu454/ChjWxoma00HLWPWUpiXIBd eRo9Z5ZRWj0A2wgxde82TG7ZA9NoCgHFpMebTG9aeR3WZB629WEMEEUJQSb5 XKY0B2zSjjNx07qWjuUp26u9lCcFc1pjxkpJuY6W+jJKqJiucFI75yumZyr5 W7KJ8IQdJ6Ew5EugnqWgYj/geyBf++Tp/u/NEhPMl8+wuaUrDoP5frb2BxyF P+dmI+Sw2cvWXAjgHGb2Ohq3TQ7f8i3f6+3LcxQus1FztQqC/nD8cDcA31Zq sPUmKPBBSgBnlHOstEbP2mWA1qjsHMX0vdthGyF6zl4Dr5AXe9ZzlQJJVEol /RJIcRKidT27MrRHZIokk9dj8nhWEzvSOif9QFKOr1DGEo3M1JYuTmzgWJGn kQ1SGnEfBafHZdlvSWcwCNqNhfFSsyK2bQFQrH2nx4BGtGj1W1/o4Z9vmJW3 ECwpM4CZcGLsHhuFoQI/Ccw+PP9cUmoMrq9FB7h7PvN3XbqrZ9A2aitto7Ay mpnMgygkoolo/15CFDEzw0xWoUt5p1mMY3WRNQ4QWqPnzGXQ+RymH96HmQd2 IqrU0XveOgS9Pc7WZRcPTcrPFYOUdpW6BJAWABpOQ2TZzBuzA6tSmWVfpd1p SDmQsZgolh0IkwqJ1AZmUm3ZOk4dPpuaGe7w2AZWAkorZkWbzeuyFK02MWXj wl0AaSiV6+49R2kA8xJu/L4l3Dw8+qC19gyydoli9qG9VTZsjio/sE9Y4G75 y+uKKpc/N6rW1kB7i0l7PkAVADtJe7t1d+/YzA1fOIejkEEa5vAU7KJuKK0d aA07+qJQGYkIpWWLofM5TN63A7U9I4iqdfRdsBGFgcWAjp0rKdmKPW4BYtJu KY7f8izghQLX6+BmE5TLg/J5cdxUxplL7WsYAbXKkH2Yjo7/zpZhE83rSnWk T69SaTwXypUlJXRKlZCGkigC0kY87u8CYFA0hYVlUIPFg7Y+sntGWX/AMoM8 308Zd08g4N71yueRLuY93du1KZqaebIu2S4QMYFnCPgZaW+LLhQrpjIdBj2L edfbn+trYwmKwI0Q0dgk/HzgMk1khP1lQWQcMJRCYVEP9JPPxpHNWxEensDh 2+5B30Vno7RyEPDS+C10ppkHuYJKluLHuEmH075WogiM6MgRmIlxhwat4JWX Q/f1Sz1bHCZTqQdGkoY2nPYlUxkvjV34LO3B0BZPSIIMEus1ovFZzAatUnOA /JaohQO1zoBYIO55HuuFZf4rW+/N22ZjKVtLyu3vNkpK8xMKuHe8aEhxZFay MU+31foqMAwIh0F0P4Cfr/nNP6ke9aHIGBibcGjDg5PQfV1Aj4YiI0ATEDMl jeGCUh5LLjkbE/fvQn3/IRz50WZE561H9/rV0PmcgNJhkiV+y1IUxsSiGeNq WwJHDYSjo7DTk5msmkK0fx9UoQgKgrRwkjNxWbKpJo4N3JYoBGUa6FFbq9NM nzIid26F1N5uy7ARuwhJkiaG16px43N52ir/2DCY3HxbzkbhJYrQBWay4P1k ov358hlPHODePnSZ5mrjEpP3LwNRD1ueAeFuAPec+8FPjc8Zx52oTHOOmIzk 90Mg3D+OIJ+DVQpkLEAuO8baOltWu2Xa830sOm8tprqLmHloN6bueRjhZBW9 m9Yh6OlKa9BYpYWMkgJ2HRstQBqm0UQ4sh92ZsaxupQSLe+0oJ2cgF4y4Mrg W2K/3NqNJsmypbxdjsNlSrWnupJgbxrG4zQC0RYqAynAatczV6d8iTRtnIJc 53I1v6s0r406fsf3ejiKLmRqrLVsFTGPKvDdhdVnVZ8wUYVbNp1P0Uz9WSrn XUqEAMxjIHybiHZf8Kl/nzcuSFqFkF4DiBzXwEzMIDo0Bb/cLzHPuDRHHDUY uUOA0ho9Zy6HXypgYvPDqO3ch2hyGr0XnIVieUmijuLtnYhbkw62XkNz3z7Y atWV0iglpB6VEHpsZQZ60aKjQJlUWyT9wVRiw7JQL51il++nTOOR2Gywadw5 3RSFUs5DvKsPeTKRbBpliM0FnfkbDPJ0FRqzAvfQ/35Vkx9ssGFzkwL3Wdfg abtS6q7i+vOnnlgJCLYXcZMutYhyxDwBa79JRHsu+Y/vHnPJMX1do/rIhE28 64jBHCHcNwZVykP36gSsTrM4jetuvnFaUGkUBxfBu/xJGN/8MMIjUzh822aE 561H95krHbdXmoiwZUdUIYat1dDYsxdcr2dirKKNlYDRWlfNa0wCPBaqolva M8mNtgyaOy4u1HTZvcQkQIZUzi29+49uGKk0iL2M2REbHpyGzrImSRhNHL73 wURh7PviPyjy/EAFuaUcRReBaEDmzIxi3AOih7ufdPlJL/k5ocAdPnNjF4f2 AlguANrA8j0M7HnK8B0LspOoUpuC5SqMKba0V66FaO4YQbB+JXR3UZwXkwEs UuaxmAFBdwGLLz4bkw/vQW33CCbufgDhVBW9Z62B310UXDGYCaYyjXDvPtha VSqD40SAaOM4ARD3YoiipFVTmiLmNns21pay1EtLUbKZqg1QUrnAnNbJtdQx cFsimAiSz209JGMmIILQHS0oFxze8Kf/YHZ/6oMead3PJhokpddzFC2XfOA4 gD0A7ut/+gsmTpUo1InVuIZ7mE0vrCIwmhzZQ0+/e/OCjXuaqVkGdhBjietF ALDnNv2wk1U0tx9AsHY5dHdJbpLcPM7cPEq3dPLyAfrOWYOgtwuT9+9A5aHt CCen0XvOWhTKSwBiRGMTiA4cADcbzg6OTYOEtG7FPnbFmSzZtaTal9itDnEo DUga1aUZCE4IO6wy5TxCoYwrLDiJCLTt5scZaJKX2LwsHc2zh1A8gyOANU+b ah07Pvae820YrlTAEhD1WgqhgEMgPMxEexpTM2OrXvvrpxRX94QClw1HZGHY 9ZLNwdCiR3YCZgAPwfClSHxsm9h4dmIGzW37E/DGFbGsKWmRy4pb9iRTWqFr 1VJ43UVM/HwrmiNjODI1g9KG1SiUcrCHD8vSLyaBirNaUspOSl6XaIcx7hED VykJswmIFSXhsKOcNQGw40BQ6nMlnF+VDAOhrchSCA+kc+67rDOLkkN00sAM 1kaIqlWEU9Nh9cDoJjZRFwiaQREYuwG6j5U+gCiqD77iLaccpfHEa1zGEWbe SeABZtLQ6sKb1569B0Q7rtz2wLFnNBNg7T2OdB0bacq11xQNbMen0XxoN4K1 K6D6ul2TEKSUAdKZ1rmWJdevke/rweJLzsXkfdtR33sQ48N3odKVQ/eKRfAK OZehk33QXBIh5g64PgxxNIAj2Vw6abEYmwQqWfIpm2WLaZCU6ZZDShJznKmf UxmHk9JO57GpwORqy5SW3mgaMBGsNa59aqOOaHoG0cw0bK3mtHdopqNqbYKN GQeww4IeVkqNn3HN756SYD1pwH3W/q3R95etu5UtdRPzuYBdykq9jBTfdvP6 s++/cuuD0/N93uYDpnrzTmoaZw9qm4Z5JIwFTbDTNTTu3wlvxQD0kj5nOgSU tP+MebbQygFJAyALbS26l/SARw+hVm+iPlWDma6juGoRCv1daYdyss4WTXqP 2dSMEIJO0kshBmQmRew0asbGNZlSdZJMWmJFxHTJjA17VK2RVPAqH6bRhKnX YWo12FoFplqFqVRgmw0Qu4mqcwWofA4Atk/v3Ptl02ju3vjuD51WRZMnpQXT 95et6wFwKRRdTory0NQkrQ5Aq/tJ0z3PfOC+OQG8+wUXroGxPwZhAFq5BsaZ Dt0JoUU7WqIq5qC6S9CLeqB6SlCFAijnWjOBXeWrrTZgp2Zgq1Vwo+k27as2 MbN/EmG1AeVr5Ad60LW8HzoXuMWBFjYAACAASURBVEgFpWwtQuqs6cUDCDZu yPR3oJYGzNmWpMjasi2vZ96LqZMJ+SYO+QE2jGCqNZhKFabWAIcM2wydgxiG ieZXngevuwdeVze8gtSoKQrZmo/lNz3393AayknrHfb9Zes0QMtBeCYpWgOP fNKKyVMNeGoHaXU/ebSbfN0gX0Xkeeby4dt599UXLoYxnwXzCxzVT2VayTuw ZvdNgFauylUKB0kraYCXlrFztl2SjhvguQbJ0yNTaIxX3X4RpQA9Zw4g6CpA aS39aSk5DykFPbAUwYb1rYBUWQBniDbZluM0W6k8JfYxRxGiag1RtYpopoJo esZ1kYwpFX4Oygsc1VFp6FIXgr5+B9hiwX2XS9O6lcHYKRs235rf9OyvdID7 aEG8Yv0qUnQ+NK0irfrJUyV4isjXNeWrA+TrfeTrEQq8qXxem77m9LXUDN/l Uv8OmKwFQPHeCEQOpKJ9Y1AmGlll3lMZjSjAJa0S6mF1oobqwWmYegTyFEor +lEc6IHO+SkoBZB66VLkNm5odb5UpkGJoqTJM0tTvJSfa2EjA9towDQaMLWG 06bVKrjZTDQ3KQXyPei8W/J1Vw+83n54XT3wu7rhlbqgfD9pPcpxv2B2HGTX TMTuCyvTl5cuuHpPB7iPNc57xsZuaCqTokHy1HJ4qky+WqwCrSnQlgK/pgJv qqjt2XkTvlUp5EiRUGMpaTCXhJPYiK8Ta2OVaGPKAjUBcgbEif1KIAWEDYPq oRnUj1QArRD0FVEq9yHfV0z6OTAAtXgJ/HVrXWdEk5LWbRRJO/1I3pPWn6GB DSPYZhMcNh1BPjMRSBFUEEB3d8Pr6oIuFaG7itCFAnQuD10swF+0FCqXd90k kwaASJoAMrfv0G4BE30rWPf0F+M0lVOKjzu0e8s0gOmb1529FZbzsJyD5SJH djmDliuOBi3z4kbOa2hShxRhpdIeyHcNL5QfPzTI90Gedg9p0USedtmpRLPS 0VNYgArpnRtHHXylUFgH1KbrmNz8AJpHKogqDVSKubRNLgOq+zD03jHJvkma ldM0MmSXSHdeSlYAUgoUBPAX9cLr6YLuKsHv6oJXKkDl8/I7PChPqhxiTV7s AgW5tEslZ6riJWyX7V/ivo/YRvgiTmM5JSsgrtz2IAOoyWPiBxddcICY7wYz gaGbTP19pjlAxv4ye55m4wG+LLWc8lFVzJpSGgh8IPBBfgDlyw45nvTLFQ2X dHSMCxez8VN57i8l5JcuwfjmB1DfvR/N8UrGPiZopUHVmpgqGqw1yNdQMglU PgddLMArFqCLBac5i3nnNOVybS2ksi2lkFybc7oAeD5UroCE6xXveJlllVG6 fatLO1uwwQFrzXc6wD3O8oyfbs5uEGYAjO55yaWf5cPVl4LRFwOPfQ34ngOp 74F9B1Yb+KDAAwUBOPBhfR8UOACTp8WRa3XYjuqpgLR5niagf8MqTHOI6t5R mHrkqt89heKKJShu2gAVBK4tlO9DBb5bCYKg1d4las2mxRuryH4kJCQZNrFp Y1OWmKegC6WY/wG0tFHN0BaTymVytq17+4sqCKY7wD0Zxvmqvlt4qnYP18Nn xuVg1Ixca/lGmEQZWMjcnN2hUWvA11JsmLFvdVqU2AoupFqZKFl2CznAW9mP 6lgFjYkabNOgcWQahcggN9CVmANJijjuRB6H0qAc9VGlapLjY1m1lANxhpRD WkEVSm67AGtTk4dtS+untFNPTNIgEHicib9hGrXTupW+Pl0v/EN3bjfvuGDN jD1SfSURWnrcU0t3xex+uEiNUes2HoGxbiMS49rNI4qAMBInKkpTuFLpy9ak LfEBaE3Ideeh8x6iaghTa6IxOY2w3oDfU3ImQmLfZri0nCmOjCmU8ZoS794e X2uyH7B7UeWL0F09LaZAAk7O7AecCarFf7O1/83G/Gth3TNrHeCeJHn7isFd 0Ux4lTnSWJX2MUhvcKJogKSbdwKGJGXMKcvMWnBoYBoGptqEqYsGR6YSlzOf SzrDEPy8j6A37wiESiGcmELtwBgoF0DnA+d8MbcCMbPrTgIym6F5Z/cEjr8r l4fX15+QZ+bKrbc4nXG9mbVTUa3x4fyZV9yB01y803rWDXTVTGQ+HI03nhzt reeooKALChQoaF+BAg0VKChfupbDAFaWabaJA2aMgY0sTCOCqUWw9QgxQZs0 Qffk4C8qwe/JZ4g2Cqw4Q75R8JRCz7I+2CVLUBufRmP0CCZ+ch9qK5aia80K FJb0O7ILK+ETuMoJZDgJ2XKflO/gbCFVKMLr6XPfHfdjiHuXcXsTXm7Rxszg +sTUgfv++pPTNwLBc4Hm6XzvT/uNibe87PKBaNvYv/C+6kuTpVM8fPIJ5JEL l+WU2w9BkhEMcrFUw8nOOGzRatNm9tBVnkawrAtBXzHT+Ty2mymJCZPvIzhn A6irhOrBI5h+eA9sowlVLKCwfAA968+AVypKdYRqidei5bVMJk0pqHwe3pIB UC7naJIUGwFtfX+pNfOWtEY1trnzhps/t+dX37+bBnr/F8AdVx3abk9bpXW6 A/djD+2t/s75a+pcbV6Fui0l4GW4ComIXQ6/bmBqBqZqYGoRTCWCrRlw0+0p xnHD5vYVl1MurK00oUsBlG6rxM1uJmIMqKcHXm83gp4u5JcuggkNzEwVzcMT qI2MAbLZCGXolmCb9iKLTZt4c5QggL94idulJ7aTk7BfVg1lgy+ZPdgIgDGf ffBPPvYJnmluBGEdgJHrq+NjHeCeRHn3bz9vW2PHofU83rgw6cGZ2RAa3L64 tFYSUNZxi6P1LQ2eKXHa2Vj4pVwG3PHewKlzRYEP1dvlSDe+j+LSRdClAjgy CCdnUN93EM3pGSjPh8r5LusnoE3sYDm3yufhDQxA5fMttiu1zJg0htvSjze2 +a3dwlH0tt0f++oWNCIPwBkAzrym1L/7+ur41Ol4zwmPE3n4FU87I9py6Aa7 p7qplSKY+aUxOVujdfsnTUmrT7e5dDYEhpYlmHyNwooeeKWglTij0nAZFYsI LjgHqpDLxIYVTDNC/fAEZrbvQzRThcoFyJWXoLR6OfJL+jMpZve/7umGv3QA FOTld7SxxmKnsn0Xobjw0iF3mg1fx6H5bG71M6KbBtaWALwcwFkAtgH4j6sO bZ/sAPdk2rtXX/qc6KGxb/CRZgnZJnLZkFGchdJJ+vMo8EK4Dy3HxzFUBfiL Cigs6ZIYcab+LGObBudthF68SEg86W5AIIIJI8zsOYjKrv1gY6ByAfLlJeje sBp+VxHwPHh9vfCXLgX5Hlo2giDV+nd7x5tMlx0iGLb286bZvDa/5llJwuGm gbWLAPwqgH4AwwBuvurQ9tMqrqsfT8C97qK1+8HW2Knm0xGxbp2eWV5C2y46 oKT0uyX+Ge+G094aiQFd8DO75WTf42QjaW9xb2a5To9TWiG/qAe5gX5YY2Gq dTTHxlHbdxBMQLBsKfIryiBf4WhDti3cNVcozPVZ2myb0bX5Nc8ayR5xfXW8 dk2p/wiAcwGsArD7+ur4eAe4J0k+ev/u6LqL1z1oTbQaU81zwS196Y/aLK/1 ZWpxspKAvXQXz8b02TB0zoP2VGrnirOWJD9qDVBvN1QuSE8qAI7juDoXoDDQ B18akphGA83KNMJaDdZa6MCHzgetAVmeJU47K355Dxvz9tzqoZ/O9vY1pf4p AAUAawEMXFPqf+D66vhpo3UfV6ZCYu++9LLV4cNjX7L7ak+N98BLQlvZJTW2 eQkZjkImjKTJTW2NdGMRiYL5fXnk+gqOxK4yfcJUthqiD/65awHPS7ZsJZWp cohplL4Pb3ARjCJMPrQDtV17HaGnvw/FNavQs2Et/O5uHL0vG6V2b8tmajTO lt8WVutfL539gjlDXjcNrC0DeDWAATEXvtsB7skG7yuv2Bj+fOTf7Wj93KxS TR2uzHNFGcpfZlhiuzUGL6UtRVWgUBjscjRDIbS3OmsK5GvotavgLR9ICeoZ GiM8Dd3bhdwZg1DFHECupq16cByTP38IzUOHwcZCFQvo2rgePRvWwSvmQdpD a1tzuVb39xQYf2Ii+4n82uccM8lw08Da5wO4AsAEgM9ddWj7wY6pcBLlnetX HuFA/QhhdBnXTRktMfl5NtDLOnNx909u3x2SwJahfZWYC9QWz4VUHXC1Dirm HTNMlnnSCrqrAH/5YgTLF4kD5sJqpBSCniK6Vq+Av6gfzAwzNY3qjl2o7NoD YwzI86DjDQkJ2VDcNJj/xkT8kfy65y4oM3ZNqb8GYBOAbgAz15T6d11fHe8A 92TJR7bsxR+/4YrR5tjM3WDzZK5Gy1oC8nR0PDcFL9DCfYj9nbb9OthaeHk/ w1nIOGixNCOgUgOKeahCDrqvBL/ch2BpP3RXrpX3kLGFSRGC3m4Uly9FbnAA qlBAc+wwarv2oLp3P5pTFfn+HKTb4gyAP42a9iOF9c9fcDr3mlL/DIDzAPTJ VN12fXW82QHuSZS/veUBvPuFF+83im9GM7qYq9EKJC0PqSVJQUeBN8OyijNo 3KZ1DaA95TJpQGtbUM7MkjACGjUEq5YgWD0IHVdN2CzZBhnyDSeZOVIEv6uI wuASlM5cBVXIIzx0BI3Rg6jvO4DKnv2I6o2KtfjjmYMTn7rjkl+qf+4RjNH1 1XFcU+o/B8ASAD6AB6+vjp/yXF3CE0S2XX3JoBmb+ajZPfNS27D5JGLQFv6C JCCo3ZlL+hu4piIuSUHw8hqF/rw4ZM7WJU+KMD0FlfNAOSH55H34mzYgWLcK qpRPS3B0WiKUlOTEpUUtSQkNgBDVm5jeuReVnXvRGB07MLNz7Lbp23Y9wJVw Oxib4Xp9VUCoXXVwOx/DxtUA3iphMQbw6asObd/eAe4pJHtfdXlfuG/qOnOg cq0day6xyoGXhRye7BopiYW4gXhL+liliQhogDyFfF8OftFH3OeBPAUEGsrP RBmIQNrtA6xXLIW/cTW88mKokpSOJ7vmqKQaI67MyBJ6EgArbcJ68zu7v3Hz p/b98TeZBoI1cBvsEYBJALsB7AVwEG4LqMmrDm1vtIG2COBiAFcByImp8Omr Dm3f0QHuKSb7fv25+fDBg8/kidp77c7KpWziPRkgtEJhESaZMAdQViTWQxxW EAWpCbrLR7Ck4BIGnk7Da0l1sTDHVCZ0FnjwBpdAryrDX1WG6iqkIE22hFIt FcdJtQbpcfaCD8HPfyq35oUHbiqv82F4EYAyXCp3A4CSTLWq2L9VABV5biSG uxjAoIAWcDvofOmqQ9vHOsA9FTXvm5+jzP6JMlea77K7Jt/Ik1E/DChJ+WbS xUnzOdVmF6us2aDgDxagu4LEXEhitNn4bty4JC4N0uSqkQs5eKtXwD9zOVRP t9sGy0tAmikvUg1o/x7ki+8C0W25DS9vSRjctHQtgeEDyANYDeAc+b+AlKWR vffx/bcC6Buh6KdXjW7jDnBPYal84To19oUfPdfunXwnjzeeyhNRLyxad30k auUraMwKXspp+INFqECnnIWYeKPRymeINXEyMTK1ZINL4K9eDjXQD10qgAp5 kO8beP6DCILPcan/44UNL1kwo+umgbU+gGUAlosp0ScaNo5mNwGMArjnqkPb 93YSEKeRHPi/r+xr3rXzRXam+Toeqz6PRxp+mmnLgFcBRzHPVFopoUoa/qI8 KNAtO0Qm5kJG06avq8z5UzYb5XPQ5QF4a1c9EKw740tU6vpa/uI33v+L+L03 DazNifZlEDWuOrjttCOUd4ArMva3b6bqj7cuhu892R6uvs3uPPICHqkFrj3M HODNpoYVQB5BFTX8/pyzd7OtneL2ULEJojMApqwNTAxPR7Sof6saGPgEafVt b9PZu3pfdF2zc5c6wJ1TRt/7RgoPVQLS+qxo3+E3m4dHrsZEY4Aj20PVyGtJ YChKCTnCayCPoHIKXl8OKqdaTQTp8sjZFLMmKZVX0+QHk7S49261fPCz3hkr v2PGJ2uLf+NvTOeudID7iOXI1/6yv/K9u59p9h6+gierm9A0a2HsGXy4UsRk oxW8RIBPIA8gX8HrDaAK4lwRUq2qFVDMMbTeC0/vpEJ+K/UWf6RXL7958Tv+ fktn1DvA/YXKwY++Y3Hjvp0reaK6DL5eg2a4kWcaa2CilVxtLEY+txTVRhGa FGmX+lWeangF7zAF3gQU7UHg7abA3wZjtqCQO6CXLdnvv/iZ+3oveUtHs3aA e/xl/N//Sjfu2RZEe8Z8rtV8O1HRKOQ1pisq0azWAgD7pcBQITDkqwg9pVAt H2gO/MEnw84odqQjHelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQj HelIRzrSkY50pCMd6UhHOtKRjnSkIx3pSEc60pGOdKQjHelIRzry2OW4FksO D5bVPN9hh0ZH+GScc3iwTMf47bzQaxseLB+PHsM82zXIdavHeu6h0RG7wN8W f58H1xyvC67P2BSIDsqGwo/qPj5W8Y4jaPMAPgy3l1a7GACfA3DDIzpneVkJ zB+D60Q4283+RwA3L+BUlwG4fB7w7gLwtQX8xhyATx+HcawA+CiAn7W9fg2A 5+GxNeSeGh4sv3dodGTXMe7dagBXA3gJgIvgGuel21YyjwO4C8B/DQ+WbwRw YGh0pHnaA1ekBLery2ySf6TABfOzAfwKXOfsdpkG8EcL1Nh/LgCYS3YND5Zv Gxod2X+M02n5fb/ocZyUidMO3Ivl+x4LcMcA/INMztnGZy3c5n1vgWuWN5cU 4BrpvQTAdgCfGB4sf2ZodOTQiQCuOo7nbgL4+jzvnz88WF7/CM/5ynlu2o1w /V2PJRfB7XkwnywG8MIFXtPxaBiX3U16Ia//Is6N4cHyebJqvfsYoG2XtQDe B+CTw4Pllac1cMWOuh/AfXMcshTA0x+B6bEcwCXzXPNXZbIcS64WYB5rpXjO 8GC58ERxdoYHy4MA/hLAcx6l7+MDeCmAjw4PlntOZ40LAPsA/HCO93oAXC52 4kLkcnEQZpOHAfzsWE6H3JxnIO3APZ/TejFcY+STMYbH02k+yjEV8+n5AP7P PL/HOWXO/p7PdHougF+Rc56eNu7Q6EhleLD8QwCvFaC2y5MBrITbxXs+wHkA njaHowcAt8kkOZZslO9ciKwDcMnwYHnz0OjIXH29DID/Fm3DswBkBYAL5/js NgAPzOOcPdKN8u6Ea9B8LNBOiA3dri3fNs/nDosTeq9M+mcCeAWA4izHdsHt zv4fCzTdTknnDKJx980B3PMBrB8eLG8/Rkhl2TxmwgyAW4dGR6aPAf4AwBDc tkgLXY1eCuArcrPnsuPfNs/nXwng7+ewM28A8Bdz/CaeBVzHko8B+J8F2uQT s9j0F88zOT8K4P1DoyOhjOXXANQAvHkOn+MyUUinL3CHRke2DQ+Wfwa3qUb7 TQoAPBtu6/nGPKc5U5yqucyR2xZwKT0CpNmkMYf58Gy5ARNz/DaeSzPKUjk1 j4NUHRod+UVuEjI5NDryaLczXTZHpCYG+v/EoJXfPT48WP4C3G49g3Pgas3w YPmuhcaMT0WNGztOL5cQWLu8BMD75wLu8GDZFyeue45BvW9odGQhLeYvBHDB HO99GsCvzXLz8gBeI0vk41n0McyLFbO8fheA/zfHSqrEKT9uiYkTBdzvybJx 5izvnSWAGp7js3kAL5tnqf76Aq/hrXO8flCW8wvFAWyX1w0Plj94LFPkNJfR Y4D6ncOD5fuHRkcezGjdaTGjToqcKOBOi7H+zjlm9GvmAe66eeyvIwC+tYBQ z5kAnjXH2/8DYD+Ab8wB3BUSQvvqaRDSOmY0Yg5f4hBcEmHDHPfnMgBfGx4s fxzAF+V+mpOR6j1R4bDsYH0ZQDTHIVcPD5a753jvl+aZYN+Yx47MyivnWNIs gG/LOX4AYLZtwwPMnf07leQ88fbne1wyR2y6KYCcT+tuEgfwHgDvhQtlLjtO XI1TA7giWwH8eI73Fosj1K5BcuLZz+U0fOlYs354sNwF4AUCwHZ5CMDPxYHY KSGl2cboQskqncryPlm15nt8Hi5N265YIgD/BuDuBeBlJYD/C+C7cr53DQ+W L5WQ5eMSuDNwMc/ZpCjgapfL4TZHnk3uxtxx0KxcKnb0bMvoT2WJBIARmViz xWxXArjycWDLRvO8t0MAudANqAtifr0PwJfg0r1nPe6AK8yh2+cIH2kAF8yS 534hZg9yQ2zbY8VuPYlILJ9jIt0yNDpSzZgzt4i9N5uD+MzhwfKix6t3JqvO TeJv3A639y8vEENr4ZhrNw4Pll9+IswHdYLH54F5QkvrsuEqAcllmD2+OA6X dGgc4/uWwsUaZ9O2YwC+3/ba7QD2zHGuZ8BR/U5noWOBd2h05CdwfIXflWjQ yALPrWV1/EcALzne4FUneFaPALgDwGw7ziwR5yG2RS+QmTyb3ANH4DmWh71e wN8uDMdt2NJ2fdNys2ZbUpcBuPJE23KPUCn88BiPuwDUF3CfKkOjI/8kjvE1 4ozdfgxTI5ZBONromsdDOCwr/wsX7B+Y5b0r4XidYxICm22JDwH8eAFcWQ9z Jz2MRDlmky8DuG6OsXk9gH9e4A080fJBGdtj2biHH4GimQDwv8OD5WHRpBsB /LIAumceDX6BaN2/F8fvcQHcH8pyPBtwLxOwRrI0zzYwk1hYTr57njDWYQDf meO9ewFsnkNTPxku9XzrKQjcIwuYzI/FP9k/PFg+IPfvQ3DZzhdi7lTxCwF8 8nhN8hMO3KHRkVBIGhfOYqoU4IL9/425ubq7sTBuwksAlOd47z/FOcMc2vgL cwBXwVUGnIrAfdQyXF7mg7k8h6JgAKNDoyNNcWBDAA8MD5bfKtGEZ83xuXPx 2Co1TinnLJavzGNrvVpMhtnI3hbAfw2NjtTmvRFnrCYAb5xnKfvqHGGvOLrw XczNCLvqRLH8T6B0i4n01VkeX5ptEkuJzn/Po1GXHE98nSzg7p3Fo4/lfMye GgZchucLxzx7o3GpzPjZgLsZwEPHSFyMYO4U9GIAL35cwZa5LhGTp8zyuAyO Tz3Xij2XcpjE44BkM5uD9RUAL5ojrHLmXMpUTIVjyQsxN+n8pgU4KFMSXXjZ LDemCOD5w4Pl64+l+U+wLJLypmOJBXA4S1MUrTkszudsyu2Vw4Pl7wO4YWh0 pCJRmzXi/M5lDjw416p22gJ3aHTEDg+W7xAQnvEIPvplzB5Ky4bB5ivPmQJw W5x0mOf6zPBg+W65vvbYLcmqcB5mTxGfLLlOPP5jyQSAP0Rr1UkIx1V4FWZP jS+FY9B9e3iwvANpFcSl82jcb2FhNYCnlcaNl+ObAbxhgcfvAXDHAojJ52Fu 3u02uDTvQuRe0RqzJR3WAnjq8GD57nnKek60XLjA48bQxm0eGh3h4cHybXCk pbkiMUvhYrp2ASbmVgDfPl6hsJNp42JodGQSjpFVX+BHbsYxSkGElPPMORw7 A2Dz0OjItgVe39Q810dijvSdjhbtbLbn0OjIEQAfAPCTY9imx8LMtGjn+4/n j1AneRDvWKDNWodL8U4c47heuErV2aSGBXB32+QGzB02u/IRmjmnvAyNjvwU wNvh4uThozjFGFyM95+O90p0soF7HxbG8NorID+WXArgSfMM6o2P8Po2z6M5 igB+6VGWYc/X/2w+ITz20vV5zzE0OnIXXCebd8CliBcSGYgE7G8B8Fcnwmn1 TvIMN8OD5X+CY4z58xz6EIjuPYaZQBJJuH6Owb5DzJNH6kR+SGxjmsP8mG9J 3gbHc7WzvPeTR7lCFfHYAvvTcJUj8/3uEbkvXxVF8Hy4FPxaAIuQlrnvgOMw fBuOPzJxoqoiCCdZFtA5EVhg98RjnIsfZXfIR33OX/T1LHCs8IsYy3m+lzKT 71GPa0c60pGOdKQjHelIRzrSkY50pCMd6UhHOtKRjnTk8S3UGYKOPBaRquc+ KHV46MD+E5aI8DIXkIOr4rwIjrd6B4CDx5MsIe2RngzH2pqY57gyXIn0UwA8 9bHmwuW3FuF6ytpf0G/Jwe0dMX66ZJKGB8sb4Squ/+bR7JYjGbWXAfhtWPt2 OBroY72mM+B2T/rAfFtaeXJwNxy5+GVwvIECHBHkT4cHy9+V5xpaN2BML4Aw ZsJnvrBXNPjk0OgIDy9bTrC2AKI6mLsBqKHRkfamcmcA+ASAa4YHy3cB8KFU E9b2A2gMjY7MDJeXebJN1DMBvAdAODxYjs/bBaAuBZgFue4JSGv7odGRppBg egFEQ6Mj0zLYr5XBed7wYHmfHG/h0pjxcxvv2yU9ehWImkMjB1i0TC+AytDo SEx7fBVcO6JLhwfLR+AI2SZzjpyMTwNAfP25+Jjh8jIN5l4AtfaJKb8hB6Xq sLZXXp4UHm3LuGcA1QsgglIVWFuQ87K81wdH8u6D69n2D5nP9QAJ7XQ2YHUL biaFyxEXru6T/dFivm6XTGIjr3fL39FweRmBuQDH+ssDyEHriaH9+1i+/2oA H2/DFgBMxb+R5I3Xy418J4i+LwP4DqQbtJ0LR7LwATwVjqjxKTi+agGOef9s Od+tAK4HUQjm98NtLHIFHGv+63CN6iL53nPh9vN6k1zYs+U7LhEAfgRuP4TP wxGZbwXw+wB+A66n68UA/lpu0lvlmB/IwO6EK+a7RlYRgiNKPwxHvXsaXB+C 98BVqhblRj4omvPw0OjIl6Ujy9Uyyf4VrlvLtXCdd8bk2rbJOZ8j3/ERuLKk zUOjI/8hv/UaOJ7w9aIk7pLf+8+iLH4HjsQyKWP07cyNWya/eULGEnDNqON9 5DwAnwXwXzLOvwxHjKnLeGwA8Fcyad4k3zsNx3x7hUy6MRmrIRmrHwC4Pgvg 4cHyi+V4wJFqPgXXTuD1cO32r5HvXwbXjOVOGY83y98/gev4GME1DblLvq8f wI/gejecAeCbcM0Ot8Ix1a6S7/whgE8OjY5UlcyyV8P1Zht5LAAABqlJREFU 0bpxaORANDQ6clgGOA9XLLcObu+rQG7QDBxZuCxf8DoZyE+K1n4NmEtwNLcN cDtM3i6TYy7a4SoAvwdHFv9rGYA/guPR/hBuQ7mvyOu/Jtf8kMzkv8pcWwjg twSsa+B6YX1NburvC8h/CNfG6Xq4yoohAU6fAP4ypK37SSbuFQKUj8P1zP0b uL6674fr3nKbgOEzMjmubvutl8r3lOA4w++S756Qm9kHtyfEjwH89fBgOdsT uEdAcbaM5VbRklfLZx+AI4EPyHe8C65m7tNwZf7Xyji9EK7E5wa4nT0vFpBp uPqxV8tnPgHXmvV1cSul4cHyYri2TLfJuL1IxqQsz7sEYL8s3/0ZuU8fkM98 Uu7F6wRXr5fnXxWF9lbBS0LegavUfp0A+pMyad40PFimmEvah6PLsadkxg7I zbsHjiB8C4C/E4A8Ha7i9Udw3NotctFPF018BK6c/HY4el8Vs7dljwFyH4Bv Do2O/FDAtlau4QHRSrfAUQlnBKx/I8vSMnl+swx8XJ7TkKXrQgHJtXC7NW6T a7ldNIoF8CMQXSugtjiaGhmfZwOADw6Njtws2vpv4cqQtsu1/ihjr7efI/7b yCT7SwHl+QKGg0ib+V02y/34N1l1viTn+qRcx+dl6V8Pt13TdwF8BkTfk1Vi XFayF8n5PyOrzafkmj1RQHfClSxtg+MuXyaAhBx3CK6DpoLr7HgnWisqrIzp fwoYbxXz4IsyWW6QyReIQvq3odGRG+Dq3T4DVysYV5X0yiT8X7me+2VSPx9I ieQPAtjQtufYWjlJvMFeDek+DVUBblE04JNktr5G1H7cZypE2lExks/PF8mY RFpg15zlhnPmuCPiOMa/oS72Tw1puc0eAH8mN+YPAfwBWjfbsJn/DwyNHDDy nNBaNBjvHRzvZ+uKLbVuCmCnM9eXPWeWY5xv+z3xTkOBPK6W8XuVKIltbZO6 nvmNkTwqmbEyojkDub7m0MgBztwryL2qZZp7VDP3tARXr/dquBZL8X0MM8B9 L1x711+RlWbTLBNzKvP7K3I/4r9n5BqVHFsRezqSz/lIucZK/r5Iruc18trt EIeJZeadB+DPhwfLTx0eLL9ILvLHSLsrXgLg9cOD5U1idyyVyMOtcsJvy2NV 22Adr5BbfN4xGZy3SPPl18qyDLG/3gjXxv/34DbcO0eAVoIreJytQ/ceAE8b HizHG55cLQP9M1mZfn14sHw2jHmr2LPL5abk4NqRFgV4Vw4Pls8ZHiw/DbN3 xoGM734B0OfEJDobR3dJXMg4hnLPXgjXu+si+f0DAvRb5fUXDw+Wnyz3sU9A f5N8xw2Z+9jMALsgy/k4gN8W5XEFHhmpPfsbCgDeMDxYfsrwYPnZYgrdn1n5 p2QCB2Lz3ij271hW4/5UbJ+nidr+sCz7fyQgJFkWLhFj+w2yzG2VZWqLLA1f kxt4Y0bbRpnZWEFr55N42TdyfCWjVUN5j2UAq5llaSZznu1iR70IwL/LcnOP DPiorCZfkCXyftEYPxAQflhmdDXW0hIe+7RMhv+QSMEd8v6E2M9PlvNdB+Bf BHxxR8S/kwjI+5FutP0O+b5qRvMY+b4pAL8JV8N2qzgtX0brVrLZcUL7OTLv N+Umf09Mp8/IdT8k4/lV0VgfFafwiEywUCbNw/Kbvy7A+Z84HDo0OjIjy/Z1 goUV8tsa8t2xhs0Wl9ba/q7LayzPd8q1/Ivcxw9ncBOKP7EbrmXW12X8/2to dIRbt8ZctlzB2mUApmVAIcb5r4nH/OsxqOSHZMMk/fIDk5DXcHmZD6IoDkwP l5d5AOzQyAELAMPLVxCs9UjriI0hENTQgQMu4rBsmQJDATAgIjCroZEDLpQC aBCZbMB7uLwsB+ZeaH0I1moALEt/HC8uktaHrnQhFyTnAQwICgzEx8tnAgCL oNRhABbMyJzPB9AHosmhkQPNzDXE57RDIwfscHlZAOZ+AEegFIMZ0NrAGA9K RRL+yQby+0E0PTRyoKWyWM7rAYiGRg64UCNz+reMI7SKhvbt45tXriIOw0UA 6iCqtnx2+QqCMYtBVBHQKQBmaORA/Lk+AdbkbPFoCU8uhivTaQyvWKlgjIJS BtZqEHjogIzTsuWejJvc0+VOOzuM3Sq4+qFo3/Gh0REeXrGSsuMjwYMuAB6U mojv+TGXHwHuW8Xof8sCKm070pFjYWqlOPS/OjQ68t3HlDmbR1iWLfP/x0DD k0lGwYgCX6AjJE8o7eAQU+oy0vJkklEwokpcRuiIwR9yp9wBBiwyY5u0u3MA AAAASUVORK5CYII= --_av-3YoemH699BdadnfmvfAIQw-- --_av-3nxTeFG5xCWYb7EtOZu2sw-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:29:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501342.773036 (Exim 4.92) (envelope-from ) id 1pVbsu-0000L8-BZ; Fri, 24 Feb 2023 17:29:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501342.773036; Fri, 24 Feb 2023 17:29:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsu-0000Kx-89; Fri, 24 Feb 2023 17:29:28 +0000 Received: by outflank-mailman (input) for mailman id 501342; Fri, 24 Feb 2023 17:29:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbss-0008WD-RP for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:29:26 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7b10a3a-b468-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 18:29:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7b10a3a-b468-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677259765; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zjChtf1zSIMhYiy5u8WzrbNRWG5mnbhddn5BxMoTNO4=; b=BABzUmCMWJsczGGGGxlc9SUMkl2QDKukHb9f8rxllRB+703NrlHqOMQ+ ORhMyV8fH8j1Rt/mVQOVI+1Ihi/L6eSRfrRpnssqyMamdMDpdkLCO8Dsy prkCHeR73dKGktaqfqZu+fF5YT+Ey8m6TPVGlmymxvbc+1eQtHWrjItEx M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98853267 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:/UAwdKM706krZw7vrR29l8FynXyQoLVcMsEvi/4bfWQNrUoihWQOy mMWXjyFMv2CYWT1L4tyaISzpBgE65/XztRiHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sxsX2MS1 sRCExIUMBmB2+buyqCWb+Y506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUo3aFZgOxBjHz o7A13T/XkkZZcWi8mGAqlCOj7HvgAO8Zo1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaPtwQQXNd4GOQg5AaAjKHT5m6xHXMYRzRMbNgnss4eRjEw0 FKN2dTzClRSXKa9ECzHsO3O9HXrZHZTdDVZDcMZcecby/P4/oNvrSqVdfR6Tqe30tmtEyPd5 j/f+UDSmI4vpcIM0qy6+3XOjDStuoXFQ2YJ2+nHYo62xlgnPdD4PuRE/XCetK8dd9jBEjFtq VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sxm8zb67omhezO ic/XD+9A7cCVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOgD+0zxd2zvxua cbznSOQ4ZEyU/kP8dZLb71Fje9DKt4WmAs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iFy9z jqrDOPTk083eLSnMkHqHXs7cQhiwY4TWcqn9KS6t4erfmJbJY3WI6OOneh8I9Q4xsy4VI7gp xmAZ6OR83Kn7VWvFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:MaOqz653dHIKE+YmgAPXwdeCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP+ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdk0NDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA+adm6PGAMW6zutsDGj5XvZD8BHloC5BOVhT2lxbbmG1zAty1uHg9n8PMHyy zoggb57qKsv7WSzQLd7Xba69B7icbs0dxKAe2Lk4wwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86SsIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsPuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59cs5Ufa/peVFZil/1dwKpnKuZDIMs80vFjLA BaNrCd2B+RSyLfU5mWhBgp/DXmZAVPIv7PeDl/hiXS6UkboJkx9Tpm+OUP2ngH754zUJ9C+q DNNblpjqhHSosMYbt6H/ppe7rBNoXhe2O4DIupGyWSKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFFdVr3Q7dU7iAdCHmMQjyGGFfEytGTD2js1O7ZlwvbPxALLtLC2YUVgr18+tue8WDMHXU+ u6fJhWH/jgJ23zHpsh5XyJZ7BCbX0FFMEFsNcyXFyD5srNN43xr+TeNO3eIbL8eAxUKF8Xwk FzLwQbCP8wnnxDAEWI/iQ5c0mdC3DCwQ== X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98853267" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v3 2/4] automation: Remove testing on Debian Jessie Date: Fri, 24 Feb 2023 17:29:13 +0000 Message-ID: <20230224172915.39675-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224172915.39675-1-anthony.perard@citrix.com> References: <20230224172915.39675-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Jessie as rearch EOL in 2020. Even if we update the containers, we would still not be able to reach HTTPS webside with Let's Encrypt certificates and thus would need more change to the container. Signed-off-by: Anthony PERARD --- Notes: While we remove some x86_32 testing, there's still debian-stretch-32-* and debian-unstable-32-*. automation/gitlab-ci/build.yaml | 40 --------------------------------- 1 file changed, 40 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 22ce1c45e7..2be1b05d5c 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -221,46 +221,6 @@ centos-7-gcc-debug: variables: CONTAINER: centos:7 -debian-jessie-clang: - extends: .clang-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-clang-debug: - extends: .clang-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc: - extends: .gcc-x86-64-build - variables: - CONTAINER: debian:jessie - -debian-jessie-gcc-debug: - extends: .gcc-x86-64-build-debug - variables: - CONTAINER: debian:jessie - -debian-jessie-32-clang: - extends: .clang-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-clang-debug: - extends: .clang-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc: - extends: .gcc-x86-32-build - variables: - CONTAINER: debian:jessie-i386 - -debian-jessie-32-gcc-debug: - extends: .gcc-x86-32-build-debug - variables: - CONTAINER: debian:jessie-i386 - debian-stretch-clang: extends: .clang-x86-64-build variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:29:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501343.773046 (Exim 4.92) (envelope-from ) id 1pVbsx-0000cQ-It; Fri, 24 Feb 2023 17:29:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501343.773046; Fri, 24 Feb 2023 17:29:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsx-0000cJ-Eg; Fri, 24 Feb 2023 17:29:31 +0000 Received: by outflank-mailman (input) for mailman id 501343; Fri, 24 Feb 2023 17:29:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsw-0008WD-IK for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:29:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca4721db-b468-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 18:29:29 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca4721db-b468-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677259769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vL1+kixkoAxqRCdE4M2Z2BxIpHTnvKCzyD7h58x79y8=; b=Ep+ljSti8Mf9h+4aAjrV9jqFiH1r7V7cdbvW+9G3fRphFhqCLL7bfB5C D9AXeNFDHK/8qD6YWMvUlu2kS0i1U+URpqdScXiWiezpWkuwWkHtRsx/P SZjWvageT+Se3XHdmbl/UTk7/guP6WKPXGrzK41Sl24MwDNY4XGhlfJEW o=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98447619 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:b8167KKB5VLYO1kfFE+R8pUlxSXFcZb7ZxGr2PjKsXjdYENSg2ECm mIYWD2CaK6OZTPzc91/Ptm19UkOu5fRyNRlG1FlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5OMH9Ty 78EJAwgcwibt+a84JCcCctj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TbFZkJwRjB9 woq+UzhCB86C/6i5gC71VPzntPpgyrLcaA7QejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxastRcGV91dO+Yz8g2Kx+zf5APxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fHakZ8usFHTQupODbatvtn/ORPXg BKF+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJtsldzBO hW7VeZtCHh7bROXgVdfOd7ZNijQ8YDuFM7+StffZcdUb556eWevpX8xOhfPgDqyzRl8wMnT3 Kt3lu72UB4n5VlPlmLqF4/xL5d2rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRtcu5TPHu2 48HbaOikkwPONASlwGLqeY7N04RF3EnCPje8ooPHgJ1ClY8ST5J5j646e9JRrGJaIwJybuTo ynlBxYwJZiWrSSvFDhmo0tLMNvHNauTZ1phVcDwFT5EA0QeXLs= IronPort-HdrOrdr: A9a23:jRoZzKme+6NaJg1U6sX0NZsprLjpDfKX3DAbv31ZSRFFG/FwWf rOoB19726TtN9xYgBGpTnkAsO9qBznmKKdjbN8AV7mZniEhINHRLsSkbcKgAeQZhEXz4ZmpN hdmtFFeaPN5DpB7foSkTPId+rIm+P3iZxA7N22pxxQpENRGsNdBmFCZTpzeXcGITWua6BWKH O03Ls3mxOQPVoWc+WmDT0/U+DYodqjruOdXTc2QzAm9SiThneS5LT7ChiV2Qp2aUI1/Z4StU bEji3k7eGZv/u60x/R0HKWx5lag9f60LJ4dbyxo/lQBDXwqxqiIL5sXLCPp1kO0ZmS1Go= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98447619" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v3 4/4] automation: Remove non-debug x86_32 build jobs Date: Fri, 24 Feb 2023 17:29:15 +0000 Message-ID: <20230224172915.39675-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224172915.39675-1-anthony.perard@citrix.com> References: <20230224172915.39675-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In the interest of having less jobs, we remove the x86_32 build jobs that do release build. Debug build is very likely to be enough to find 32bit build issues. Signed-off-by: Anthony PERARD --- Notes: v3: - new patch Proposed here: https://lore.kernel.org/r/7ec61260-0fec-25e2-6fa7-ec1d86e8067d@citrix.com automation/gitlab-ci/build.yaml | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 2be1b05d5c..a2891c5937 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -251,21 +251,11 @@ debian-stretch-gcc-debug: variables: CONTAINER: debian:stretch -debian-stretch-32-clang: - extends: .clang-x86-32-build - variables: - CONTAINER: debian:stretch-i386 - debian-stretch-32-clang-debug: extends: .clang-x86-32-build-debug variables: CONTAINER: debian:stretch-i386 -debian-stretch-32-gcc: - extends: .gcc-x86-32-build - variables: - CONTAINER: debian:stretch-i386 - debian-stretch-32-gcc-debug: extends: .gcc-x86-32-build-debug variables: @@ -311,21 +301,11 @@ debian-unstable-gcc-debug-randconfig: CONTAINER: debian:unstable RANDCONFIG: y -debian-unstable-32-clang: - extends: .clang-x86-32-build - variables: - CONTAINER: debian:unstable-i386 - debian-unstable-32-clang-debug: extends: .clang-x86-32-build-debug variables: CONTAINER: debian:unstable-i386 -debian-unstable-32-gcc: - extends: .gcc-x86-32-build - variables: - CONTAINER: debian:unstable-i386 - debian-unstable-32-gcc-debug: extends: .gcc-x86-32-build-debug variables: -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:29:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501341.773025 (Exim 4.92) (envelope-from ) id 1pVbsr-0008WQ-30; Fri, 24 Feb 2023 17:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501341.773025; Fri, 24 Feb 2023 17:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsr-0008WJ-0V; Fri, 24 Feb 2023 17:29:25 +0000 Received: by outflank-mailman (input) for mailman id 501341; Fri, 24 Feb 2023 17:29:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsq-0008WD-Gq for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:29:24 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c63fe622-b468-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 18:29:23 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63fe622-b468-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677259762; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=3m8i8hP0Ojht3qB1jKYvUIcfgvkxQ/uk2031nXKLdpg=; b=bWWtf8HkmynVoPqwDI8wfZtygfzuJP8UnlZc8Z9XQ9nfIihNIVFExpx9 KwC7x0OCmQfK2mOKrlO0dG0Z/wEOp9WUOK/2P/2ZDP1x3rbcNSeGYNWSD mZ3kbBFG4+uvbzlr0kaBtGTtM+wPJvzO7pBZ9+hGxbpvysa4iRkeRvQtD k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97274433 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:jymK5qsbOUqfoENteokXfdVhUufnVE5eMUV32f8akzHdYApBsoF/q tZmKW+POfvYZ2Wgc9p2aoW38kIHsMWHx9VhSwNorSwyEiwQ+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEyyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBR8VQCG+uOONzei6S81vn5QecvjLM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WzRetFKSo7tx+2XJxRZ9+LPsLMDUapqBQsA9ckOw9 z2coDilWUpy2Nq3xzmh9yuztMX1pQTWQ48ZD5q/5sNSqQjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+Yz8g2Kx4Lf6hyVAWVCRTlEAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnop4thvrZ3JTdzVbI3ZZE01cuYKLTJwPYgznY/l7Pp+IsdzOFGvxw hSJtXgD2YQzgptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWO0e+yzMUJVJdPUUOQS9PZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9gZ s7ELpzzUCdKWMyLKQZaoM9HjNcWKt0WnzuPFfgXMTz6uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivBnFSnCPq+Y7dAlaRUXX8Liq86S7gMbfeFs5cIzgYteNqY4cl3tNw/sJzbqQp izkMqKaoXKm7UD6xcyxQigLQNvSsVxX9BrX4QRE0Y6U5kUe IronPort-HdrOrdr: A9a23:hYQAh6/kxmn+PnVTbbtuk+HHdr1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8brYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOQ+EYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRsOnBkMdV+yGi8zXmIngaRsmAQdizAWVlzun5JPzDhDdh34lIn5y6IZn1V KAvx3y562lvf3+4hjA11XL55ATtMr9xsBFDMmsjNFQDjn3kA6naKloRrXHljEop+OE7kosjb D30l0dFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxyr5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjwUC3ELFuKYO5n7Zvv3+9I61wXh4SL7pXVd WGOfuspMq+t2nqK0wx8FMfh+BEFU5DYytuCnJyxvB9lQIm0EyRhnFou/A3jzMO8okwRIJD4P mBOqN0lKtWRstTdq5lAvwdKPHHfVAlbCi8RV56G26XYJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdduXQpc0zjBMWS1NkTmyq9CVmVTHDo0IVT9pJ5srrzSP7iNjCCUkknl4+lr+8ECsPWVv 6vMNZdAuPlL2HpBYFVtjeOLaV6OD0bSokYq9w7U1WBrobCLZDrrPXSdLLJKL/kAV8fKxHC67 s4LUvOzel7nzCWsyXD8WbsslvWCz3Cwa4= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97274433" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v3 0/4] automation: Update containers to allow HTTPS access to xenbits Date: Fri, 24 Feb 2023 17:29:11 +0000 Message-ID: <20230224172915.39675-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v3 v3: - new patch which remove non-debug x86_32 builds - don't fix root certificates in jessie containers as those won't be used anymore on the main branch. v2: - Remove CentOS 7.2 - Remove Debian Jessie test, but update container recipe for the benefit of older branches. - Fix CentOS 7 containner recipe to update all packages. (Fix missing update of HTTPS root certificates) There is work in progress [1] to update urls in our repo to use https, but those https urls to xenbits don't work in our containers, due to an expired root certificate. So we need to update those containers. This series update the dockerfile where just rebuilding the container isn't enough. Cheers, Anthony PERARD (4): automation: Use EOL tag for Jessie container automation: Remove testing on Debian Jessie automation: Remove expired root certificates used to be used by let's encrypt automation: Remove non-debug x86_32 build jobs .../build/debian/jessie-i386.dockerfile | 2 +- automation/build/debian/jessie.dockerfile | 2 +- automation/build/ubuntu/trusty.dockerfile | 5 ++ automation/gitlab-ci/build.yaml | 60 ------------------- 4 files changed, 7 insertions(+), 62 deletions(-) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:29:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:29:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501344.773056 (Exim 4.92) (envelope-from ) id 1pVbsy-0000t1-Qq; Fri, 24 Feb 2023 17:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501344.773056; Fri, 24 Feb 2023 17:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsy-0000ss-NT; Fri, 24 Feb 2023 17:29:32 +0000 Received: by outflank-mailman (input) for mailman id 501344; Fri, 24 Feb 2023 17:29:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsx-0000bj-Bx for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:29:31 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c88de6ac-b468-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 18:29:28 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c88de6ac-b468-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677259768; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dKjZmvLIgfgTCPTPD7KJgT13Ikz4Lhyv/yjVesUtAEg=; b=afhjV7klf2BlKyDKMxKNl0jYh1We3+k1Ss5y1DdWJ5KpKHjf6gxr1LEp 1MGt2v7r2UvXRlG+w3MW5EC+JiijO4gylvNrUsKLK3a28xX3I87TEBZKe wBlrVr5NEOLslqxS45YNTQm7HS+1X2TmQ78Q8Se1eEVoC3PmPtRJd8zs/ 0=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97830161 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:7XdTr6MY1mOmKNnvrR29l8FynXyQoLVcMsEvi/4bfWQNrUp0gTZVy WAaDWDSO/7cMGvxf4onPtu180JX6p7SmoRlSgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0v4wGltV+ K0fERAAZS6dmLmv3bmpbsA506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUo3VFZ4NxxjBz o7A1zm6XColMJuv8yeE3lKqt8HLjH7cYI1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaPtwQQXNd4GOQg5AaAjKHT5m6xHXMYRzRMbNgnss4eRjEw0 FKN2dTzClRSXKa9ECzHsO3O9HXrZHZTdDVZDcMZcecby8Gku7sog0PId/ZuG5CrkYbsBDri5 xnf+UDSmI4vpcIM0qy6+3XOjDStuoXFQ2YJ2+nHYo62xlgnPdD4PuRE/XCetK8dd9jBEjFtq VBew6CjAPYy4YZhfcBnaMEEB/mX6vmMK1UwanY/TsB6p1xBF5NOFL28AQ2Sxm8zb67omhezO ic/XD+9A7cCVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOgD+0zxd2zvxua cbznSOQ4ZEyU/kP8dZLb71Fje9DKt4WmAs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iFy9z jqrDOPTk083eLSnMkHqHXs7cQhiwY4TWcqn9KS6t4erfmJbJY3WI6OOneh8I9Q4xsy4VI7gp xmAZ6OR83Kn7VWvFOlAQioLhG/HNXqnkU8GAA== IronPort-HdrOrdr: A9a23:L5dqDq17o66h+ZbCd2jvXwqjBWByeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OUtQ/+xoXZPtfZqyz+8Q3WB8B8bBYOCEghrKEGgB1/qa/9SIIUSXmYA86U 4JSdkHNDSaNykcsS+V2njcLz8V+qj9zEnkv5as815dCSVRL41w5QZwDQiWVmVwWQl9HJI8UL 6R/NBOqTaMcWkeKp3TPAhxY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortU LFjwv6zKO+tOzT8G6v60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIL9sXrWT1QpF3t1GvDwR8e XkklMFBYBe+nnRdma6rV/GwA/7ygsj7Hfk1BuxnWbjidaRfkNxN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnzUQ1wnEbcmwtorQcqtQ0TbWIiUs4ZkWVfxjIiLH44JlOM1GnzKp gnMCnejMwmDm9yIUqp8lWH++bcIkjbLi32P3TqhfblqQS+vEoJvnfwl/Zv7kvosqhNP6V52w == X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97830161" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v3 1/4] automation: Use EOL tag for Jessie container Date: Fri, 24 Feb 2023 17:29:12 +0000 Message-ID: <20230224172915.39675-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224172915.39675-1-anthony.perard@citrix.com> References: <20230224172915.39675-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain As Jessie is EOL, the official tag isn't supported anymore. Also, the GPG key for the packages on the repository on the official image are expired and it isn't possible to update or install packages. But we can use the image from "debian/eol" tag which use repositories from archive.debian.org and have workaround to ignore the validity date of the keys. There isn't a dedicated i386 tag for jessie, but we can ask docker to pull the i386 image of the "debial/eol:jessie" tag. Signed-off-by: Anthony PERARD --- Notes: v2: - new patch, this replace "automation: Ignore package authentification issue in Jessie container" workaround I've seen in the debian/eol:jessie: 'Acquire::Check-Valid-Until "false";' in /etc/apt/apt.conf.d/ And a script to replace the "gpgv" binary used by apt, which check that the only issue with a signature is that the key has expired. automation/build/debian/jessie-i386.dockerfile | 2 +- automation/build/debian/jessie.dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/automation/build/debian/jessie-i386.dockerfile b/automation/build/debian/jessie-i386.dockerfile index b152d658d3..c9ac15a3ff 100644 --- a/automation/build/debian/jessie-i386.dockerfile +++ b/automation/build/debian/jessie-i386.dockerfile @@ -1,4 +1,4 @@ -FROM i386/debian:jessie +FROM --platform=linux/i386 debian/eol:jessie LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" diff --git a/automation/build/debian/jessie.dockerfile b/automation/build/debian/jessie.dockerfile index 1e33e635d2..63b2c1e5b7 100644 --- a/automation/build/debian/jessie.dockerfile +++ b/automation/build/debian/jessie.dockerfile @@ -1,4 +1,4 @@ -FROM debian:jessie +FROM debian/eol:jessie LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:29:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:29:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501345.773066 (Exim 4.92) (envelope-from ) id 1pVbt0-0001Ad-5H; Fri, 24 Feb 2023 17:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501345.773066; Fri, 24 Feb 2023 17:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbt0-0001AU-28; Fri, 24 Feb 2023 17:29:34 +0000 Received: by outflank-mailman (input) for mailman id 501345; Fri, 24 Feb 2023 17:29:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVbsy-0000bj-1s for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:29:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8f907a6-b468-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 18:29:29 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8f907a6-b468-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677259769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1ZVP9ILrNhbusIRgE8ATcFEGu4Gjie58ccJgoiV0r98=; b=X0Vij8GE+XKzqzP8iINDyFxUbYiR63g9uOezhfy10fmFZrm2YMI0TimO fH/+AToj+WTO/zySdXxKMQWDP8awDaliWlkfTNg17na/JbfNtdiyRmuRX KlqbQzyItX+erRR8oS6V+xV6rkCjOF3oGs8z6oUujQtwzvbtX8p+FtJdK E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98354844 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:6RPR6qlcfYMDshxa1vzFXybo5gyZJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJMDzqDM/vYMWSjKNskO97l9BhTvcLdy9VnT1RurCk8ECMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5gOGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 e0cORogSi6EvsP18eOKUedhv54CC+C+aevzulk4pd3YJfMvQJSFSKTW/95Imjw3g6iiH96HO ZBfM2A2Kk2dPVsWYAx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthfI/ T+arzilav0cHMaF8hWCr2qdv7PwgHL3cqspHaT7+sc/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JbGvc27wylwaPO7wGUQGMDS1Zpc8c6vcU7QTgr0 F6hnN7zAzFr9rqPRhqgGqy89G3of3JPdClbOHFCFFFeizX+nG0tpgPLX/xONJCyt/y2KGDB2 D6HlXIfoJxG2KbnyJ6H1VzAhjutoL3AQQg0+hjbUwqZ0+9pWGK2T9f2sAaGtJ6sOK7cFwDc5 yZcx6By+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romxezP Sc/WisLvve/2UdGiocmC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzv5mZ sjBLpv9XSdy5UFbIN2eHbp17FPW7npmmTO7qW7TknxLLoZylFbKEOxYYTNin8gy7b+eoRW9z jqsH5Li9vmra8WnOnO/2ddKfTg3wY0TWcieRzp/KrTSfWKL2QgJV5fs/F/WU9A6w/8Izr+Vp xlQmCZwkTLCuJEOEi3SAlgLVV8ldc8XQa4TVcD0AWuV5g== IronPort-HdrOrdr: A9a23:FZq3Zq6fLKauuWrWPwPXwM7XdLJyesId70hD6qhwISY7TiX+rb HIoB17726MtN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpM FdmsNFZuEYY2IXsS+D2njaL+od X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98354844" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH v3 3/4] automation: Remove expired root certificates used to be used by let's encrypt Date: Fri, 24 Feb 2023 17:29:14 +0000 Message-ID: <20230224172915.39675-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224172915.39675-1-anthony.perard@citrix.com> References: <20230224172915.39675-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain While the Let's Encrypt root certificate ISRG_Root_X1.crt is already present, openssl seems to still check for the root certificate DST_Root_CA_X3.crt which has expired. This prevent https connections. Removing DST_Root_CA_X3 fix the issue. Signed-off-by: Anthony PERARD --- Notes: v3: - remove change to Debian Jessie containers, as we won't use them with HTTPS urls. v2: - remove unneeded changes to CentOS containers automation/build/ubuntu/trusty.dockerfile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/automation/build/ubuntu/trusty.dockerfile b/automation/build/ubuntu/trusty.dockerfile index b298a515c6..22e294c20c 100644 --- a/automation/build/ubuntu/trusty.dockerfile +++ b/automation/build/ubuntu/trusty.dockerfile @@ -47,3 +47,8 @@ RUN apt-get update && \ apt-get autoremove -y && \ apt-get clean && \ rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* + +# Remove expired certificate that Let's Encrypt certificates used to relie on. +# (Not needed anymore) +RUN sed -i 's#mozilla/DST_Root_CA_X3\.crt#!\0#' /etc/ca-certificates.conf && \ + update-ca-certificates -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:38:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:38:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501369.773076 (Exim 4.92) (envelope-from ) id 1pVc1A-00041W-8S; Fri, 24 Feb 2023 17:38:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501369.773076; Fri, 24 Feb 2023 17:38:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVc1A-00041P-5I; Fri, 24 Feb 2023 17:38:00 +0000 Received: by outflank-mailman (input) for mailman id 501369; Fri, 24 Feb 2023 17:37:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVc18-00041J-E8 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 17:37:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8aa4288-b469-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 18:37:56 +0100 (CET) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 12:37:54 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6762.namprd03.prod.outlook.com (2603:10b6:a03:409::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Fri, 24 Feb 2023 17:37:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 17:37:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8aa4288-b469-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677260276; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=+XSjsAk8jWSiDOjWQFPbWt5qqLOM0Vu3etiNJhXwjDQ=; b=Jwkj7n76tfw+XNRr1Bsb569ZwrHXrx2s4pbMQGjBHmKjDXrjdDIpyXBE FQkOhA3L+fg1UIYGikHavcPK7M0kVOpenLCc54cM7FSwjm3L8Ko76O8ve cvy3Qj1yt8WmrltucjMxrIvUMk7Uvt8gOzZCzTpPUEO0+N5YNeALWonHm Y=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 98448850 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UMLinK64QQTScKiohPHKAQxRtA/GchMFZxGqfqrLsTDasY5as4F+v mMcUW/TPv6JYmqnedEgaYy/9EkF65fdyoRiSFFs/C0zHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx fMqMwAQXCC5mbzu47KpZNlHvpkSM5y+VG8fkikIITDxK98DGMqGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Nkkotj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdJOSO3oq6YCbFu77S8MDTIzeACB5sa91l/uUIl/C nU75X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMQ/XzAt2 3eClsnlAjEpu7qQIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyLzflTrKR9dnVauq1Nv8HGiqx yjQ9HRhwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:JnVzbqh++V/SiL3wIhcYUjdta3BQXt4ji2hC6mlwRA09TyXPrb HLoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SOTUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebrN5fQRt7eY3OEYeexQouW6zA== X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98448850" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8sx/MnLB62MgGgdr5iz5jUbFhcJLDn6AV+Uf1cuJ0vS12xwPUnVJDW9ARUyfaAAE6BQzWB0l/jmyX6/Px4atyd0GnuhHlGK9aVwCjKS/8l99oGqgCLyvfVeZengzOPYtTfce8Kh/4zjk0aiPGmFXQztcGzPnRDCb/oDnSg/gswfGWzJ704XYvK4Wwxz6X0Ky3XRmXNDOoPpFpiGlGz66d6tc6GIPABatvpCHG3HSkOgzY13uOgwTgtAQ3WY1YqjB6QaRPaKCGn2u9GHTEbzxq70ITjP61sqggGcqTx2io0ohaEtD3Dk2O2ZV4VDtlYuxiq7UNBJPFSqDVGfRlz2mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U9S+T7vv4d8pPJuPKqLn8ORHt1uiw2csfSfb5GMXDCY=; b=UiYrUR4Vbu3gaB7q2WKrRMTwNDtkDO9kJUqJRGO31I6NuMVLhKaaT2X4L7AUqZ6ao4wX8BmGRvjulv4/YhOPy/niNVUHFaPTQ9l6WMBlKJEfCganRXt2ry6oQxhvpppqwuzO6kf/sZ2cGw7x27kStWL+jlXKz08xQeOtHiwWWB2c7Vcjs8eXG9CFs0xGkQdxUSNX/YPJLaABm4tQK7SruXx9LiprAl+N73I4oPciFoWn/ZBdhwNmFZRYdOLGgYT7H2rb3mNVTZz5DSGZmJm11mGRm/lklT4FuoW8k9iyRG4YrUunWTdQIo1m4skskJ9oESas3yeWddRcqpZmCbA36w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9S+T7vv4d8pPJuPKqLn8ORHt1uiw2csfSfb5GMXDCY=; b=PuIvq8iaOuCd1RFvMkiNqb5gOAvM2ObVts3U7jLDfYMy1O0AKDDsdglBr9u5+QPtt0e5LFfGSqiIOJCym97qybufUBbnVTfMhLz2ycNEiL0qIGH79maZMUO6up0udUudqy+43NNFSvX4d8JdGGb9I8h1S2J+dXqjNxgBuFWokL0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 17:37:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v3 0/4] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230224172915.39675-1-anthony.perard@citrix.com> In-Reply-To: <20230224172915.39675-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0107.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6762:EE_ X-MS-Office365-Filtering-Correlation-Id: fe8b3f7f-9fe9-4a99-8816-08db168dd930 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zaQDfwNe/ICIw7rPmXzygpEB+W9VLwet+zBx7sF4Dq0H76YVpbDQ4IbygVvfbm2VxSQSTOuocD3lSFEQ8C3FKiVSMyRrqOYsY7Eb88/j9ruT4EkqYZT0L+8KcZDTtFOyAHRoPexS7+ytY0KfgRwSEUo1W9yz0/jeXVG3vb/Id0yDFiEXFYLyzR4ZH4y+1ALHqkXwW2aY7tK5uLuha72bw9zEMPJN+Uf1JEJy0qoKZ8vw08RvnOBWydme80Wo5U2yL2hjCVZ7W3P4hoWYVxTk7tiFEPaRLieYj944YBaonRffWKBHCOZ2X9Ku7ON3DxTebmWSzBXwCHH/Nto/Df7rgEXrqdV4EarHiiIo00nN3OZ96lZWhEb8sPB+/qX+UJ5FRsXCAEvw8JfU8BkBswYd5OHl1Ujh7tY1BJNAkcuNOBjN6R4Kn8yfLMfJgPvxlkVHkZZsNOZC1eE5FzNkW9iPMF1BCz0Giw6F8K99rIvG0dVfrp6NaIamCfx/zHesMFkDPzAu6MU5Ku44Me0njLd7WIADJaB7qYUwLlR8P4+iBBdqO0iEz17IeDDwEzxDd+QH/sZ7c2BT0Jem4z8fsnEu7L6y8dtjEHETViVPAkbuQnjLhkGxpKpxz79cbhga5EChzUF+HoxfMR33DxcB4mFOJ1PLFRG3UKesNQCK6tXYJyDx6CvUq7S50qGrQh3by+HzAbGdzAanIU4bIhZaDh9uGtTaClgEMaFXJAPzezsRONw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(346002)(396003)(376002)(136003)(451199018)(31686004)(966005)(26005)(6486002)(53546011)(186003)(8936002)(4326008)(66556008)(8676002)(66476007)(66946007)(83380400001)(6512007)(2616005)(6506007)(36756003)(6666004)(5660300002)(316002)(31696002)(478600001)(41300700001)(54906003)(86362001)(38100700002)(82960400001)(2906002)(15650500001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDNxNERwUkZsMUY4bThKTVkyU3hUclNUUjY2eHNBajNhd1FhVW5GS29xTUtp?= =?utf-8?B?dkdub2o1M1RZUXdMeCtIQnlKMWxmaFM2bFFUeHJ2SGJmRGl3TlZJUkNWZEx6?= =?utf-8?B?dElEMUNNaGJQK3E3ZjQzQ1A5NjluWlFLaXdPWkx1elgvUmxjRGppRldQalQ5?= =?utf-8?B?ZS9uWGQ5UUNuK2tkWFdLbUVkUWIzTzhEcUtqRjJrTU91Zk42YUx1MGVjTVRO?= =?utf-8?B?c2J3bGdLWm00U1I2SGM5cVZGcVEzdkRmT3I1R1grbERRRDBZa3BLTW5XSUpN?= =?utf-8?B?ZW5vQ2ErZUpLTC9UbkRIS0hya0N3d0FUbitNWVVlekhQNld3eGdaNmgzbFJh?= =?utf-8?B?LzZKR1hhaUhwUDZJOHdGM3NnRUl2RjdPZWV3WVdhMzhBdGhVcC9IaHM1ajN4?= =?utf-8?B?MDFjaWVjb0NLS2cyNXIwU0N6eGpHWDFkTi9jbmN3ektLY1U2dDFPc0NTZmwx?= =?utf-8?B?eGIyYk9LOUd0M0ZoaXJnZVVXT3MvMTVJZmhnT3B3bC9Lb2toQUttY2EvdHIx?= =?utf-8?B?SzNvSTgvbk5XaGNsZU9Rb0p1amNrS0RaQ0R2SUZKOGN1UkdXSEVJVHBrWCs4?= =?utf-8?B?NzRDa0hZT0FBVW0yQVZqdTN5MEZXMTFUVjk5WWVHbHFnN25DdjcvMmZreldV?= =?utf-8?B?bFFwNzYrOGM5YnIrMXhoUjBDK1F1dVJVU0l2a243cHRiTjNpMURnUkhKdU85?= =?utf-8?B?RGZLMEE2bWdHWjRsS1RaME4vemdnWTI4OERzVGszSE15aXhSVmY0a3EyN1VZ?= =?utf-8?B?aldtVnhEY2lSN2E4K0RSS0ZQUVhwZ0VXVFd4dkRqWENQU3RGVHJMUTdtbXpH?= =?utf-8?B?NE5JOTRWRmJOakhMdVV0OWJiM284dHVpVmV2NnEvS2prZzROZVZwWFBDR2xr?= =?utf-8?B?MnJjM2xHcU84Y0hucUc0N2R2eWlGN3Zoa21TRmZOL2pwYVdIYzZlZHJ4V2Vp?= =?utf-8?B?S0hTeVNtQnN6MXJLK1Nhb0FJaFZ1T3BENTdjVDh5ZHF2V0JQR2F5Rjd0M05S?= =?utf-8?B?c1IzSGFsMWFWZUUxcm1jMUhFTDF1dXFqVjl1UUJSdko3K0QrTTdhRmVabzdu?= =?utf-8?B?MnVVSFJEZ1hMeW52Mk1VWWNoSFVoakhKdU15ZTRER3RlK2VuaW9FWnplYVZK?= =?utf-8?B?eDZ5QlB5Vy9qd2FZTzFVeHRONSt4ZTZPM0pQdVc1ZElJb0Z2RWJwMVNhRTU0?= =?utf-8?B?MjMxYXI2cGdpeVhUY1ltRmxQTU83bUZWeHlrNWhudWg1bG1tN1VGWFRDaTNN?= =?utf-8?B?YXdTUzZ3aWhmblk3ZGswT0Z0VUZZanlTU1oxL3VIVFUvZEhNWDlWMFJVNXMr?= =?utf-8?B?dDRqcFY3anVSYytUaWxHdHVIUVRhNk1xR2kxTEx4bXE1SW9RRFRhZnJmaThl?= =?utf-8?B?enJZaDZUbmkxTFJPVkorVVgydHF3aWdHdlJJWHNGRG5YQXhWaTZ5NFpabGJO?= =?utf-8?B?VUM3ZFpnYXpjWUxrOUk2YmV2MEFmdTNMWE1oWFBONm9pRHRnRWVEbWJBME9j?= =?utf-8?B?QlhmbThVRXZ2YmtiSkZaOFg0QXlRVmdhK1VaWFVZY3RYbWIvQ09uYUx1R3JN?= =?utf-8?B?YU1vaC9NKzZhWTllc0xhNzNiMndxMkJ3ZzFxOHNGNW5CTitGUzl6dUFNM2Vj?= =?utf-8?B?Tm5YQjBmbU5IaXBPMUwyK3ZLV3kwd01Sc1kyZWVsWnFtYmtSbHhGVGgra3Q0?= =?utf-8?B?ZEltNHBERndRU3pJWjMzODFndmpreWVtZGdXdE93bERaTldHWVRneEJ4WUxx?= =?utf-8?B?cWRZQmgzRWlCUE5PcXRnZjQzZHA0elI3TmpUQm1tN29RWmxYRWZBUzRvUVlq?= =?utf-8?B?UXJjSFVEYTN1V3pvdWlKb0hoVVdmeVJPTzd2MGJscXB4SndqTlpnZGs2eWdD?= =?utf-8?B?d0dwdWJkRm9EYkRLTWVoTkx5T1d1dHJ0c0FVemt6RU02T0Z0bWpLOExuOFlH?= =?utf-8?B?QWUvOE5FWkRRM09hTWY3Z3g4MUZIeDJjY2ExSFY5bndMODRGNU5pblFSTk1w?= =?utf-8?B?K09tdTVuZUt3ZTJyMmpIUUJZYXhkdHBhSlREdGEyaWxhNm9jbnRyKzVsR0Fz?= =?utf-8?B?WnFSM3NEK2pyeFROSVJUbm82d3IzWXBrUnhVRmdrMUVhQzhTLzlpNlJzN2dt?= =?utf-8?B?V0VsTng4dlNDTXMvSEo2Um1BREF4Vk5ZM003WWpjRlVwd3REbFJZZGVVNkN0?= =?utf-8?B?WlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zCvZxsQehAobuNkcUcUGS4jZqWnVgLyc92Qx8mYwnIlas35tZ0mHCEuvlZffLS7sHwL0diz5kgUMQiMc9A1zoEoAp9aIQLhbFHUBgdH7O7C2BjausMoj25CrMByOtqV43fRHZgRyMa/3ah5VhpIMTcBnlUp4l3D8RRqg7BtqWbXZxaoE40zClgW+MuIvxpUiB3SnilTKGG/3MlgpLKwjOfKLN3GhnKuDYiEwdeDM6uGrvjo5C9gtrUZQGxVLm7KlZrjKDO2uHSN5GiHg/aX61so7zoNO8e9YlMhhXHQCFihFENZEnLLr3lC0+7eCjDcmGay8F1gWkOAvCkyAp+hzJcn3FGcX+S28lSx66f06gE5r80QKXIHaOzchVcpdJFZuhne8BVEoTfzsxUYa9s29WOwt3sC25qtOCDm4OWeGoo9qVYtad5EzhfX7ZtmnVK+5rCP5WJkxI7eB9drktsbIYrZtuEV4YFXTDQNyQQdrc5KbwXYTabktDG+rfwfwMRg2SkmOmyA70ionIJH8C8jdMoUsGmn4rmHrXPowA1n0fixW99kv+h2L4Yz/6NTOmjxocIKqzSr3AtgcyX63NlEOhmwjDU1fuhC6WET/AsmTXLaEK4u4k/bkDqZUMPsdEQVYB3rcS9dTXCxVLnyYfVQg1pF69BRUXGGz4bP5+C7nYhoAfKImMQvRv8zeJcyFCoFpbP8VPD7cH3O/dz+BBVB+1HQRee0GgYDIweUZq+EV3FmSnjiwCVxOUrIr6svursDa/hRDDce7TRmi96zgk8+Jit2+tTjqOqqu3ho1rZDnc77tVDb4+KSKnnIKtCAVd15ad3mNSkUhT9n3dteLy3454w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe8b3f7f-9fe9-4a99-8816-08db168dd930 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 17:37:49.5749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OSsxkLvL6VvV60X2rZNfybL8DO2e7/7RvE4HLku4KtNFw5fJLM6w7vNmqR1+z1YXkbrpMimVUhM+jfe542iS0cWShLCUFqqlpzt+7DwoaRk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6762 On 24/02/2023 5:29 pm, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v3 > > v3: > - new patch which remove non-debug x86_32 builds > - don't fix root certificates in jessie containers as those won't be used > anymore on the main branch. > > v2: > - Remove CentOS 7.2 > - Remove Debian Jessie test, but update container recipe for the benefit of > older branches. > - Fix CentOS 7 containner recipe to update all packages. (Fix missing update of > HTTPS root certificates) > > There is work in progress [1] to update urls in our repo to use https, but > those https urls to xenbits don't work in our containers, due to an expired > root certificate. So we need to update those containers. > > This series update the dockerfile where just rebuilding the container isn't enough. LGTM. Acked-by: Andrew Cooper I'll add this to my commit sweep, and rebuild the remaining containers. But on that note, I noticed that the debian unstable container was 2.3G when I last rebuilt it.  Which I think is obscenely large for what we're doing. Can we see about switching to slim/tiny container bases? ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 17:49:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 17:49:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501376.773086 (Exim 4.92) (envelope-from ) id 1pVcCH-0006HM-7x; Fri, 24 Feb 2023 17:49:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501376.773086; Fri, 24 Feb 2023 17:49:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcCH-0006HF-5E; Fri, 24 Feb 2023 17:49:29 +0000 Received: by outflank-mailman (input) for mailman id 501376; Fri, 24 Feb 2023 17:49:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcCF-0006FQ-Df; Fri, 24 Feb 2023 17:49:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcCF-00056j-6W; Fri, 24 Feb 2023 17:49:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcCE-0004ss-Nh; Fri, 24 Feb 2023 17:49:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVcCE-0005Pg-NH; Fri, 24 Feb 2023 17:49:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B11BAiwUkfz92gCo2U6bIxaKW3ZTPNqAoCC92m+SE3U=; b=f68kYhah/MDdSD5VqLmZ+2d39N bTe/KutSEpW8ERxh/bjb4ZbMGroEuWKc4udXQZuuCZ9lxQ5Uoood1sicFt1+GbxxEMbQs60h3Z879 A2XTncfMGQppuo3WYb9cSZbcuk1lWBXHARUbBPniBsL1/5Awxoqp/59amf08ddlbu7IM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 178273: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.14-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=c267abfaf2d8176371eda037f9b9152458e0656d X-Osstest-Versions-That: xen=46040a5fe68831530b8ffdea7d264e52ae316c87 From: osstest service owner Date: Fri, 24 Feb 2023 17:49:26 +0000 flight 178273 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178273/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 174677 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 174677 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 174677 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 174677 test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen c267abfaf2d8176371eda037f9b9152458e0656d baseline version: xen 46040a5fe68831530b8ffdea7d264e52ae316c87 Last test of basis 174677 2022-11-08 18:07:02 Z 107 days Testing same since 178136 2023-02-22 14:37:17 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 46040a5fe6..c267abfaf2 c267abfaf2d8176371eda037f9b9152458e0656d -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:09:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:09:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501386.773100 (Exim 4.92) (envelope-from ) id 1pVcV6-0000xi-28; Fri, 24 Feb 2023 18:08:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501386.773100; Fri, 24 Feb 2023 18:08:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcV5-0000xb-UF; Fri, 24 Feb 2023 18:08:55 +0000 Received: by outflank-mailman (input) for mailman id 501386; Fri, 24 Feb 2023 18:08:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcV4-0000xR-S0; Fri, 24 Feb 2023 18:08:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcV4-0005Xj-Oq; Fri, 24 Feb 2023 18:08:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcV4-0005ga-E2; Fri, 24 Feb 2023 18:08:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVcV4-00021x-Dd; Fri, 24 Feb 2023 18:08:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kW+8LXUDxQvT/Pa6bftaXFhACMOz4p8FQbf4FK/88Rw=; b=mLoxGsnhkN4wFHFJ44CQjY0NbH qbXVauUOqOXyVDqMNfG+chtlCBIziwW64oBzk0lmop8EeHseBjUPS/FbtXU3IEZbYIOoI2YIRTe7M WrGoXrc/1sl4qDKZLxIro51qJUiy8frGhtZuPteJgMdCk7/SinOTJbd1plkambGaezAs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 178275: regressions - trouble: blocked/broken/fail/pass/starved X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm::broken:regression xen-4.16-testing:build-arm64:xen-build:fail:regression xen-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:heisenbug xen-4.16-testing:test-amd64-i386-xl:guest-localmigrate/x10:fail:heisenbug xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-4.16-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=0802504627453a54b1ab408b6e9dc8b5c561172d X-Osstest-Versions-That: xen=d4e286db89d80c862b4a24bf971dd71008c8b53e From: osstest service owner Date: Fri, 24 Feb 2023 18:08:54 +0000 flight 178275 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178275/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken build-arm64 6 xen-build fail REGR. vs. 177405 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken pass in 178195 test-amd64-i386-xl 20 guest-localmigrate/x10 fail in 178195 pass in 178275 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 177405 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177405 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177405 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 0802504627453a54b1ab408b6e9dc8b5c561172d baseline version: xen d4e286db89d80c862b4a24bf971dd71008c8b53e Last test of basis 177405 2023-02-15 16:37:16 Z 9 days Testing same since 178138 2023-02-22 14:37:31 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 fail build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken broken-step test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm host-install(5) Not pushing. ------------------------------------------------------------ commit 0802504627453a54b1ab408b6e9dc8b5c561172d Author: Anthony PERARD Date: Tue Feb 21 16:55:38 2023 +0000 automation: Remove clang-8 from Debian unstable container First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper (cherry picked from commit a6b1e2b80fe2053b1c9c9843fb086a668513ea36) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:13:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501394.773111 (Exim 4.92) (envelope-from ) id 1pVcZ3-0002ot-Jh; Fri, 24 Feb 2023 18:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501394.773111; Fri, 24 Feb 2023 18:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcZ3-0002om-Eq; Fri, 24 Feb 2023 18:13:01 +0000 Received: by outflank-mailman (input) for mailman id 501394; Fri, 24 Feb 2023 18:13:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcZ1-0002og-Tb for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:13:00 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db9a66ce-b46e-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:12:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db9a66ce-b46e-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677262375; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=TYBo1ClyDWvRp652kD06s+0oldmXR52xdZiAg+g1s20=; b=E9lIqUEuezA5qhcNO3GUqjXDdsJVQIs1OBn8yrPVc0Hvc0v1skcFcIs9 rCZfzTfCQm1CGkOHhMuhywq52fSuK44mqwot/IltVlhCqPmyZqcjJU5Ec tgpFjJMZgRZhmJdsuHx3uKPaYqPpnNcFkvxA5BDKCxNhEcCWLyPDaN+fw I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97836272 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:GI8Ci6M27b3yrM3vrR2Ql8FynXyQoLVcMsEvi/4bfWQNrUp2hjdRy DAbXDqDP6yKZDD3L4p0YY++9UpUvZbVmIc3GQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sQwBD5Hz u4gEi4qXh3YpPmH7Z2FQ8A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUo3VFZ4LxBnCz o7A12WoRSo+LPqB8DeiyGqdiMPggQDqBo1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaPtwQQXNd4GOQg5AaAjKHT5m6xHXMYRzRMbNgnss4eRjEw0 FKN2dTzClRHuaWYU3uH+p+IrDm5Pm4eKmpqWMMfZVJbuZ+5+th110+RCI85S8ZZk+EZBxnSh DXVpRMsv48Nqv4GjIagzH3ovTuF882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4 iFaxpH2APQmSMjUyXfTGLll8KSBva7tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj KM+VGpsCH5v0JmCN/Ifj2GZUZ5CIU3c+TPNB5jpgiJmOMQZSeN+1HgGibSs927silMwtqo0J I2Wd82hZV5DV/s4lWXpHbhAgO96rszb+Y80bcqmpylLLJLEPCLFIVv7GAbmgh8FAFOs/1yOr oc32zqiwBRDSuzuChQ7AqZKRW3m2UMTXMisw+QOL77rH+aTMD15YxMn6e97KtMNcmU8vrugw 0xRrWcElwak2CWfdFzih7IKQOqHYKuTZEkTZUQEVWtEEVB+CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:EK+1K6BQGnN4NpnlHemU55DYdb4zR+YMi2TDsHoddfU1SKClfq WV9sjzuiWUtN98YgBDpTmrAtjnfZqkz+8T3WBzB9eftWvd1ldARbsKhbcKpQeQeBEWndQtsJ uIHZIQNDShNzNHZcGW2njdL+od X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97836272" Date: Fri, 24 Feb 2023 18:12:28 +0000 From: Anthony PERARD To: Andrew Cooper CC: , Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH v3 0/4] automation: Update containers to allow HTTPS access to xenbits Message-ID: References: <20230224172915.39675-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Feb 24, 2023 at 05:37:44PM +0000, Andrew Cooper wrote: > On 24/02/2023 5:29 pm, Anthony PERARD wrote: > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v3 > > > > v3: > > - new patch which remove non-debug x86_32 builds > > - don't fix root certificates in jessie containers as those won't be used > > anymore on the main branch. > > > > v2: > > - Remove CentOS 7.2 > > - Remove Debian Jessie test, but update container recipe for the benefit of > > older branches. > > - Fix CentOS 7 containner recipe to update all packages. (Fix missing update of > > HTTPS root certificates) > > > > There is work in progress [1] to update urls in our repo to use https, but > > those https urls to xenbits don't work in our containers, due to an expired > > root certificate. So we need to update those containers. > > > > This series update the dockerfile where just rebuilding the container isn't enough. > > LGTM. > > Acked-by: Andrew Cooper > > I'll add this to my commit sweep, and rebuild the remaining containers. > > But on that note, I noticed that the debian unstable container was 2.3G > when I last rebuilt it. Which I think is obscenely large for what we're > doing. > > Can we see about switching to slim/tiny container bases? I don't think that would help much, the non-slim container is only 116MB vs 74.6MB for the slim (amd64 containers). But maybe we could try to use "--no-install-recommends", that might save a few bytes in our containers. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:21:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:21:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501399.773120 (Exim 4.92) (envelope-from ) id 1pVcgn-0004in-BB; Fri, 24 Feb 2023 18:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501399.773120; Fri, 24 Feb 2023 18:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcgn-0004ig-7M; Fri, 24 Feb 2023 18:21:01 +0000 Received: by outflank-mailman (input) for mailman id 501399; Fri, 24 Feb 2023 18:20:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcgk-0004ia-W4 for xen-devel@lists.xen.org; Fri, 24 Feb 2023 18:20:59 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb116856-b46f-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:20:57 +0100 (CET) Received: by mail-wr1-x434.google.com with SMTP id l1so41383wry.10 for ; Fri, 24 Feb 2023 10:20:56 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003e876122dc1sm3967939wmq.47.2023.02.24.10.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:20:55 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 53E091FFB7; Fri, 24 Feb 2023 18:20:55 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb116856-b46f-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=8a4GZn4ha/5hEHiBbNnraxRAqCIgTi7PRjzwWK8+ESU=; b=N1DAEs2WC/OXmk0i+ZhAPYAdw9TMRfuFPwvVoLS/i4fgwhLiNb58S0qxDWWTFQKmaF H+G4FKG1baO9JRqcZBwejznUAe+mlZtpxsSTRaJvMVS0lQ8y84yhUmNcamMi71go3OcU VB6i6jotD8Vl1MPaGl4yCeRXEsSb7MTwNSoLoFSXGLPOCDFeZ6SRF22sjaPq1r5KNWTp 6hQIj9SQcvVYtpdJqNP8+DLnhpJgspir+XLh4XWPr6K+46kHKXNN7ezcCYwSS/ofPDOU 7rAHSLsxEHRvMwQGaSymKIMHrs0cMrBlfygbY1jHM/atrOeCGTRrdGegtGPphx7NavL/ 2bHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8a4GZn4ha/5hEHiBbNnraxRAqCIgTi7PRjzwWK8+ESU=; b=T0qkJ4Rp5bc9T/TAz3pwD+fRxs6iskZsIdLyQc9Ufcv40Eo2bBXw5jKwfIWndBEssG O4eMcEVOjUYR+pxDFrtzKWqNMK73O5QRRzTEYgFvEl+3sCVivPEKVF+frMXvFprWJ61f P1P4cDru6naxq4W2hCnOFc2hUTPxjuHveO765Hl37HENy4oJ+pcmY1PerqOzMfMP15Iy BIbp4jTN0kisD3Eru1pJ6soO9X8PUS2AesQpvhhbgP4Dmymk+P+UmL4yx0A85p2Hxq3G y7Lnyw2ssc+2fy0Nz+viXVCDOz3yTA3S4/RW1a8FqKjxMWlI/Seiwo+g4fcOc/nsihwZ 687A== X-Gm-Message-State: AO0yUKXh8tOq2SMmoL/7rY7M08kFcWMbJda8Y4cFRDY1lJnmjFuO7xuo awOlphPLR9Ls7zxkh2Dp2U192Q== X-Google-Smtp-Source: AK7set8UPFrVTjYS0MJCgqyh+wW7y7tnk9QcLIurR75ujbKeyLojHM11V5UzbFoZuqm3NOPolHAXfA== X-Received: by 2002:a5d:5274:0:b0:2c7:1e32:f7ff with SMTP id l20-20020a5d5274000000b002c71e32f7ffmr2555417wrc.16.1677262856092; Fri, 24 Feb 2023 10:20:56 -0800 (PST) References: User-agent: mu4e 1.9.21; emacs 29.0.60 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Viresh Kumar Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" , Vincent Guittot , stratos-dev@op-lists.linaro.org, Oleksandr Tyshchenko , xen-devel@lists.xen.org, Andrew Cooper , Juergen Gross , Sebastien Boeuf , Liu Jiang , Mathieu Poirier Subject: Re: [RFC QEMU] docs: vhost-user: Add custom memory mapping support Date: Fri, 24 Feb 2023 18:20:31 +0000 In-reply-to: Message-ID: <878rgmorg8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Viresh Kumar writes: > The current model of memory mapping at the back-end works fine with > Qemu, where a standard call to mmap() for the respective file > descriptor, passed from front-end, is generally all we need to do before > the front-end can start accessing the guest memory. > > There are other complex cases though, where we need more information at > the backend and need to do more than just an mmap() call. For example, > Xen, a type-1 hypervisor, currently supports memory mapping via two > different methods, foreign-mapping (via /dev/privcmd) and grant-dev (via > /dev/gntdev). In both these cases, the back-end needs to call mmap() > followed by an ioctl() (or vice-versa), and need to pass extra > information via the ioctl(), like the Xen domain-id of the guest whose > memory we are trying to map. > > Add a new protocol feature, 'VHOST_USER_PROTOCOL_F_CUSTOM_MMAP', which > lets the back-end know about the additional memory mapping requirements. > When this feature is negotiated, the front-end can send the > 'VHOST_USER_CUSTOM_MMAP' message type to provide the additional > information to the back-end. > > Signed-off-by: Viresh Kumar > --- > docs/interop/vhost-user.rst | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst > index 3f18ab424eb0..f2b1d705593a 100644 > --- a/docs/interop/vhost-user.rst > +++ b/docs/interop/vhost-user.rst > @@ -258,6 +258,23 @@ Inflight description >=20=20 > :queue size: a 16-bit size of virtqueues >=20=20 > +Custom mmap description > +^^^^^^^^^^^^^^^^^^^^^^^ > + > ++-------+-------+ > +| flags | value | > ++-------+-------+ > + > +:flags: 64-bit bit field > + > +- Bit 0 is Xen foreign memory access flag - needs Xen foreign memory map= ping. > +- Bit 1 is Xen grant memory access flag - needs Xen grant memory mapping. > + > +:value: a 64-bit hypervisor specific value. > + > +- For Xen foreign or grant memory access, this is set with guest's xen d= omain > + id. > + > C structure > ----------- >=20=20 > @@ -867,6 +884,7 @@ Protocol features > #define VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS 14 > #define VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS 15 > #define VHOST_USER_PROTOCOL_F_STATUS 16 > + #define VHOST_USER_PROTOCOL_F_CUSTOM_MMAP 17 >=20=20 > Front-end message types > ----------------------- > @@ -1422,6 +1440,20 @@ Front-end message types > query the back-end for its device status as defined in the Virtio > specification. >=20=20 > +``VHOST_USER_CUSTOM_MMAP`` > + :id: 41 > + :equivalent ioctl: N/A > + :request payload: Custom mmap description > + :reply payload: N/A > + > + When the ``VHOST_USER_PROTOCOL_F_CUSTOM_MMAP`` protocol feature has be= en > + successfully negotiated, this message is submitted by the front-end to > + notify the back-end of the special memory mapping requirements, that t= he > + back-end needs to take care of, while mapping any memory regions sent > + over by the front-end. The front-end must send this message before > + any memory-regions are sent to the back-end via ``VHOST_USER_SET_MEM_T= ABLE`` > + or ``VHOST_USER_ADD_MEM_REG`` message types. > + >=20=20 > Back-end message types > ---------------------- This looks good enough for me. We will see how it works in prototype. Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:23:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:23:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501407.773129 (Exim 4.92) (envelope-from ) id 1pVcip-0005Kp-QY; Fri, 24 Feb 2023 18:23:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501407.773129; Fri, 24 Feb 2023 18:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcip-0005Ki-Nt; Fri, 24 Feb 2023 18:23:07 +0000 Received: by outflank-mailman (input) for mailman id 501407; Fri, 24 Feb 2023 18:23:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVcio-0005Kc-SK for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:23:06 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46b72825-b470-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:23:05 +0100 (CET) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 13:23:02 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6269.namprd03.prod.outlook.com (2603:10b6:a03:304::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 18:23:00 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 18:23:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46b72825-b470-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677262985; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=lQks1ken6pnYzR+AaHEvkr0po9hqHuWv4gZOW9pA3jc=; b=eFo72SpkPf/9ZDUPMmy7CUXCjnojId7lBf0iir8rgdjE6dNubyXnQIP4 xqxOO/7H9UMjtP1qciph4mHOfi121e2stYN9UPO8BEb1iNtNZfzZYZDvf ZpldGotwt65QfbDbdxhWFhn5NO/nrYt7WyAATLvHHe2SUxRWdHdQfhX5G 0=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 98361465 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iVHjz69NHnQrPaLTliaODrUDtn+TJUtcMsCJ2f8bNWPcYEJGY0x3m 2QbX2yFOquCa2Pxet8iaoq/oEgPsJDVn9YyHgI9pSg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oX5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk3 qcnNBJXRCuFxPCzw5G0CfBgq+IKeZyD0IM34hmMzBn/JNN/GNXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWMilUui9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdJJSuTkqKMCbFu7yWVQEi09Wn6Hh9Klu1W9AOBgB HYd9X97xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMQ/XzAt2 3eClsnlAjEpu7qQIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyLzflTrKR9dnVaKw0Nv8HGipx yjQ9XdlwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:vdPq2K4FQs8rkalErAPXwD7XdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsyMc7Qx6ZJhOo7+90cW7L080sKQFg7X5Xo3SOzUO2lHYT72KhLGKq1Hd8m/Fh4tgPM 9bGJSWY+eAaWSS4/ya3OG5eexQv+Vu8sqT9JnjJ6EGd3AaV0lihT0JejpyCidNNXB77QJSLu vg2iJAzQDQAUg/X4CAKVQuefPMnNHPnIKOW297O/Z2gDP+9g9B8dTBYmKl4is= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98361465" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpFJjZsJlVn252KHxjGED70+UYUoYujtyiAzb7kxyeFQWD3yHKusJXtb+Z5bO0G4XwNRM+MYN2FUK0AmJU8bpHVVi/LnGrvWxcKX+jTLiPXEVJNkW3IQWCP5QNLEWQNzXj7BqohJ+V3gXiBmx40mfKAXVuiaSiF80GpxpCnjUweCudVzm7TtiFwjqIXVpKcXj2ZgPaR7vA9fQPuqbLIT+pykdZpESPAJDjkdG/HazstVJBE7PO6UTjBh2Cd8Eo4/QzNtdOLKpb7l8WR6X0LAwO2Prz+4b+SUVkp7qUvCeggV9VZhcGehj7JHCL1rFvm5jb8RIY6yYzbuFw5Ae03PpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVu5tVFhfS4KWENS5o27ClQFN70qQ4D0sbmH7KiiZqY=; b=VmMJnh2STBi3s38iJoRnbnJCWAi1qZoREiFC1ncuGWhSJxHPOW/SkCkL24oDHiqgGqQ1aRFuglqz8mNavc1uW8m8WTBqKilRRO/j6/OlH0yDdHw3QLZrIpprXojfdfu7xXLRbUg/LyjxlN8dJOdfSd75eCKN/EvHPhvFSXvP0slPegUgjfCd0qHInG9NSM5Vzta9b7UY3fxQiVFM1Mfee067zEgThA7CGRMtlv3bh29DFnsAzkv9ZQNYzZegu9q86NmlqsRPpPCr+8dUZbxs1BQs1/7PokPzG9ez1ztXzFZ1KfeX7jq6FfrlEd4x3p6AGxxDybxLZyE0A+oBm5165Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVu5tVFhfS4KWENS5o27ClQFN70qQ4D0sbmH7KiiZqY=; b=bbrgwiJU84mNxhhhfUo5kkAYHwRopgts0vY01vWPnKBWRXRnBGH0fXStVg2dj9S0SfUPeHYXZybOajS9cbNPGqdyaZVG589E0ijWuEQCXQULupBmhLhnByT9jlMNyeWKx1ZCEycMG+kaHWNwi3u3jTP3UQ1DZCpf4KmkHkd77vU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 18:22:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH v3 0/4] automation: Update containers to allow HTTPS access to xenbits Content-Language: en-GB To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini References: <20230224172915.39675-1-anthony.perard@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0077.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6269:EE_ X-MS-Office365-Filtering-Correlation-Id: c2e61543-0d23-4aa8-16aa-08db169428ce X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VihC3P+EdceucoV2MW2bRPrNN3QWeuiqPi/wW0OXwx9uMr5CcKpNFQq1IoQhTJhSq/fHHIrkwDEN3F2QIjAK1uxtpi3VsmzOECz1uJb33s0knlxZ0wY3nJ0JfjlQpwD3o099fM8PvQ7WtIYXPT+Ibxzr6CisYwI4yYgwu1Yq1rgx7SkpBPbIo4rQ1M02eWXl+JvYjwRdvUY7r+NdivjripCDH8u4k4x14ZxXp6x83uCCtRO7rcB1m2CvD0/aVajGBVvKrnlwzLr/4AvNjLk+gKKCU5yrnPdBXTNa3jHi7rcvFmJRy/FfsduSq1wJYog5qYgf1HI6QN+80XNHCyBpYH7gQBpYpQEasioNlta9D/bnDAPyj4KDtdduh/WwsdG18xIGtDWYB3+2Pcp4jY1wmgVoiJIt8gSE2S4q/h9UWWz54mjuK2x+x9AWbZgrAhe1TYz95KUieDVutNbQ1zp6aHETTRrG5Dq4dgEKoeuFDdGs63KzsVjD8+wcZyvBUaCmZgFWyAswoq+B4aTRc1NJgW/cL15x/ada/ymS6ebDc+Glq4RHnQiQoesnZTXGkyQbFweuEMcldR0M22KNV2fumC9GXDpj9000IM+d7GAGgJapU8HdyvywHebFLUGWlxcDfiF27fq4Nw+wRIvaB93erAaEEfjOb76SK5yXE5lOzsqxWcRNPpnlvAxJt22XOVURpbBehE2yeQ7r1p9RPUTyIp7WJPADFmC2xQl8RqD2Wh8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199018)(186003)(53546011)(26005)(2616005)(66574015)(478600001)(966005)(6486002)(8676002)(4326008)(83380400001)(54906003)(6636002)(66556008)(66946007)(66476007)(6666004)(6506007)(6512007)(316002)(37006003)(31686004)(41300700001)(8936002)(6862004)(5660300002)(82960400001)(2906002)(38100700002)(15650500001)(86362001)(36756003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ry94cVN0eE5VYUdvendmUjlpaGdzOXhIWWxXU3RKWEUrM0Y3dXpRbWUrWnJm?= =?utf-8?B?cUgyUUhWZFRoT0lVd0luaGFydUh3OGNGcHFhN0RLL2V2b0ZmYnFKa2crSmto?= =?utf-8?B?aWJEaUtyejMxZVZoc2RaekpUYVhRR3R4anRXaFBxY2Z0Y0t6QUdTMmovSUR6?= =?utf-8?B?SFRub0p6MEtTM2NMWVNrT0o0dFhmdlJLdjZMR3laL090WE81WFQ3VmtkMjM3?= =?utf-8?B?Zm5XNThnMDJnZ2Zoa3BKbDdtV1V5UnBpbnp4MlBmeWxTSTV1OFBGaHIyNWVJ?= =?utf-8?B?ZkRMRmtTSDczbU9PWXZ4c2FsWks2Z0lmQjdSUlJpVmJsdnJPTG9pRlk5VFEz?= =?utf-8?B?R2xvU01GbyszejFuYm0yS2ZRQk1lSVdvQ1U1a3JIRzVOK3UxN20vUzFOSDVW?= =?utf-8?B?eHI5STB0bTRnWXZNWkdvVGpxRi9lSkJvUE13L1NCR3VCeG9WWTdDVVJqaSt1?= =?utf-8?B?Wk1XdHdwNGFhYVQveWoweEdWVm1JWDlVQ1NhdzZNNEdSMFlUcWoxZDRlSml2?= =?utf-8?B?ZlVVODVCalIxd285T0ZBaEdIUDE2SGVZakJEQm0yMk5teDZvcHlIenVKUW1U?= =?utf-8?B?YmQwR0lXS0d1WC80NGFTVXFIdlFYV2VoZXBZamZZTUZmckltaFA0dnlOYWNj?= =?utf-8?B?aGVyVmQyQ0hnNVBnMVdRQVk5MnphbGgxVHZWdWFrTHZSU2U1NUg2RWtHVzFF?= =?utf-8?B?Q3lDbEdNdWxCWGxRQ29rZHJicTJkNU45ajUxOEkzMWVjZ1h3NW82WXd6TWVD?= =?utf-8?B?S0NCNXpsZ0pTYzhMMU4rRDNtWUwyMWRkS25IdWtyNnNKRHVWTXBjTDVNdjIz?= =?utf-8?B?Zm9LOU9QRW9hL0ZFaXFMVjdiR1NaZU5nTmpkS3k3MmN6U2Q4dFcvMFVEaXB1?= =?utf-8?B?UjZaQ3RFRmN6QXRKNDgzV3RUTG9VK2RjQkgzcHh2TGVNdzdXa01xNVFJMVEr?= =?utf-8?B?N3B6Ums4R3U5Tm9EV2lQWjhmZlhmbnhzL1E4MW1Qalh1bmpiTWJ0NGsxc3RL?= =?utf-8?B?b0diT244T3lWeDJPMWR5bFpJUXpaQXNnYmRCempUL1M5MTA1UEhXRVM2eGJO?= =?utf-8?B?N2dTRjY3SzBLbWRtYzl3L1p0TmN6SG90b1lWVW02M2RBdEtuTTJhYzAzTkx6?= =?utf-8?B?ZW5BcFdLb0VpM09ibWU1RDBvRUtRVCthUUdwTTBrcUttS3lVaTQxZ2ZmcEZX?= =?utf-8?B?RHlKQXlTdS9nYXdaMkxwZGJlZVFQUDdUVlYzc2Q0b04wM0Zoc2J0MXNTYndm?= =?utf-8?B?TUVBaTRTaFdab1N4Vkx5Szh3cFZCZnJ0MzVocUZRK3ZnR3pXdmRmZUZYT0pF?= =?utf-8?B?ZkpWTkxXSnhkZnRVaDhrV205OGFXMjNsY1NVOU5JeFhZb3IzOGlpcW9xMFdP?= =?utf-8?B?RVY4dzdlSHlYQ3NJdlNSMkQybVA1KzNPV1p3YWd2aFNBSEUrd2xYanY5TFF3?= =?utf-8?B?Q1JENU03R1JtUlg1YUFham1GRG5kdzhFU1p1MFVoTHQ2dWZGUkJyRURtRjlv?= =?utf-8?B?UTBwb042TXdWOFhCMCsyUHo5cG9lYjZlRVVzWjl6RDEzZ3UvTHp4UllJWmZL?= =?utf-8?B?U0w0ZjlqalkwMmtZMFNTS3E5T3FaRU5ucERaOVFXNW5ZVVExYy9odm5WeElH?= =?utf-8?B?QzRlQ1ljckd1V0ZjSUVRc2VmNC9QWUVxMzNRbStUenh0SnJrd2FwMURnd3V2?= =?utf-8?B?Tnh4OE42dDNobTBMTFllbmE2S05mYjNOQ1N5SG5nRGVNc0kzVXgxc0kxMGIw?= =?utf-8?B?SSt6VUZsNzNaM2RmY2NGcVZDMm5hRTFKbEQrSUt3dnE5UnpIWFlINk8wd3pU?= =?utf-8?B?R2VSckRoMHRwcWtadFAvY2RpVCs1RWRKTTU5Nlh5U0xydERHeTl6dkowZ0Vz?= =?utf-8?B?SGVSWWhxdGFjVG1nT3FEUHdrNXF3SVZUMjlGQzR5Z0JDY0lXQTcxMEJBWkpn?= =?utf-8?B?S1JhZVM0MllxSTduV0liVy9KdXpSUjdVRllMUk5yTnJQZENodzNSaTk4ZnBO?= =?utf-8?B?Z0l6Q3I4elJyMDI2aGJVOVRoVGtNWmJHSlJpK3R5eXdnT3UyL2RBL1Y5aEY5?= =?utf-8?B?NUNVMXdVRDZ3TU5nWFJZcFNib3dtOHE2cjdwUmJxT210ZFY5blc0ZlpDa3du?= =?utf-8?B?Y1FYRjhJV2s0OG5vV1Z2Nms0U05LbGpiNkJsWXZKa01mTXh6cjhuaWJ2Y0tN?= =?utf-8?B?YXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2Z/JmNuOBsFMTgEzs65unZIXqEP4Wz1mNquC97/6b4oGzRRDlKGFU52902vHSDWmOoS5fUdn/dr2IkXl2YWgdSdr5ZdSxWeUuI09UlVu1EWinlKNkdFCXIToI0YEw+rrQW6ZOPJc6w1KYgcd/mUAkcV7ESVTYPwJEJuqIZ3mingEzgGUCxZ6tq2HxL218EsqH+nZiumwH/9rjMuk6/TFAu1GxZoP/eWxJQtmTvzhxmvuIzAkYtEJCnp78n1N+2A8kX+AQmoAkhSMigqh7u0DnhSOmnRSUATf9JVvGrZByytwTX4y24Nc0hchP+gaYn+nXrzM4ivcdAxTmhL1eyWQumls3tU06lpPsyIFAQZEUzIKb4YpkRmmGv/vIb4PxJNEa7pi1DZOWfyXhBBUkKrlOWIKryvyKtQZypjsnQlFPYrfq+rRtVo26w6zN7qTLnmeq+nL31GFOnRxTLWhVfnRMKmjS+gLtA76vKFAv+b8K3vM5/X8TA5ubsPPR+sQAA8jhhd/V4jijYjMcmTAW3rkLOA97equELtgHrcTDA6+Clr2+1qlPvMSddnsK0t0BKSsNhaTzJliP3SsFzo/gTBftKpd4Jla2Y1xXlJdg9lpO+ShTtLqxHSP16f/w1hVw7SbEsG2ADwq6Z1N2VidAbWQqkDSE0xWQSvgYNIek2HvGCArsbCw+xwV724XI4ThYnWpNHwDX2SLs8zU7Wb2CYs9r319xSfNTcCNZJRiap31nkWJ4j7d2uMCluF5LIgRX4JfVpem1/byEsRfUMEkfmX8yYIkWS9ko8+Moh50DnkAObCZxCZTdvjEoJyels4CFJkOJN4tdEdbxhrZDWPlrR/w+g== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2e61543-0d23-4aa8-16aa-08db169428ce X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 18:23:00.1435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Oz5X7aBQDrhXo9aDsktn6MHhgw7JfRxXLTHCe8UXkHJRw6RP9i1iIGnnpt5IOoNj7gaN86SlWA1GnDns+SMaBlYGsoCqn282kcD1rZn8tIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6269 On 24/02/2023 6:12 pm, Anthony PERARD wrote: > On Fri, Feb 24, 2023 at 05:37:44PM +0000, Andrew Cooper wrote: >> On 24/02/2023 5:29 pm, Anthony PERARD wrote: >>> Patch series available in this git branch: >>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-containers-update-v3 >>> >>> v3: >>> - new patch which remove non-debug x86_32 builds >>> - don't fix root certificates in jessie containers as those won't be used >>> anymore on the main branch. >>> >>> v2: >>> - Remove CentOS 7.2 >>> - Remove Debian Jessie test, but update container recipe for the benefit of >>> older branches. >>> - Fix CentOS 7 containner recipe to update all packages. (Fix missing update of >>> HTTPS root certificates) >>> >>> There is work in progress [1] to update urls in our repo to use https, but >>> those https urls to xenbits don't work in our containers, due to an expired >>> root certificate. So we need to update those containers. >>> >>> This series update the dockerfile where just rebuilding the container isn't enough. >> LGTM. >> >> Acked-by: Andrew Cooper >> >> I'll add this to my commit sweep, and rebuild the remaining containers. >> >> But on that note, I noticed that the debian unstable container was 2.3G >> when I last rebuilt it.  Which I think is obscenely large for what we're >> doing. >> >> Can we see about switching to slim/tiny container bases? > I don't think that would help much, the non-slim container is only 116MB > vs 74.6MB That's 64% smaller to start with... > for the slim (amd64 containers). But maybe we could try to use > "--no-install-recommends", that might save a few bytes in our containers. Oh wow - yeah.  For buster-gcc-ibt (which is already slim), we're getting: Suggested packages:   binutils-doc bison-doc bzip2-doc cpp-doc gcc-8-locales dbus-user-session   libpam-systemd pinentry-gnome3 tor debian-keyring flex-doc g++-multilib   g++-8-multilib gcc-8-doc libstdc++6-8-dbg autoconf automake libtool gdb   gcc-doc libgcc1-dbg libgomp1-dbg libitm1-dbg libatomic1-dbg libasan5-dbg   liblsan0-dbg libtsan0-dbg libubsan1-dbg libmpx2-dbg libquadmath0-dbg   parcimonie xloadimage scdaemon glibc-doc sensible-utils git bzr gdbm-l10n   gmp-doc libgmp10-doc libmpfr-doc libsasl2-modules-gssapi-mit   | libsasl2-modules-gssapi-heimdal libsasl2-modules-ldap libsasl2-modules-otp   libsasl2-modules-sql libstdc++-8-doc m4-doc make-doc man-browser ed   diffutils-doc perl-doc libterm-readline-gnu-perl   | libterm-readline-perl-perl libb-debug-perl liblocale-codes-perl   pinentry-doc readline-doc which is a whole bunch of junk we absolutely do not need. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501413.773150 (Exim 4.92) (envelope-from ) id 1pVd9A-0001mF-5J; Fri, 24 Feb 2023 18:50:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501413.773150; Fri, 24 Feb 2023 18:50:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9A-0001m7-21; Fri, 24 Feb 2023 18:50:20 +0000 Received: by outflank-mailman (input) for mailman id 501413; Fri, 24 Feb 2023 18:50:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd98-0001Wv-4B for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:18 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14bfc9df-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:17 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id cq23so1153781edb.1 for ; Fri, 24 Feb 2023 10:50:17 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:16 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14bfc9df-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ScwbromLqQzqYYYpYwRfyt5tCHilx4TfocktUtAVLMw=; b=imsg0nhoS2lUO0ejUqH5ReEs5g1iPOUXNMG0gXXT+zTgb0LKTjD4Tzpw/dreiswITJ 6RcEN9yg7Jnptj7GcpBW1Adc6x/Px8M1KmADIsipt2XQ1E5NNYKf8EfwnzyGk3iFiY6X dc3FBkIm4yT6VKu2cC3eRfc1kWvSluLjxoqo64mWyVV+e52l1hnUhgMBYvOuP5tYXRlM Rfd2wUIwz4sGx52UXdJXi2W1JmmGWDzTsHm7QkhXmckENPca+FN3t4JyAwbCK2BOtLB/ QwQhKzBZQ+iW66p8mgkD1xXYlscnQa+CCG+5kaJGgWYhAGndoJoefVXdiyCQk2S8ykos nycA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ScwbromLqQzqYYYpYwRfyt5tCHilx4TfocktUtAVLMw=; b=ikoNIfE0cxaoKKjyQocaudJcI9W4m3hSjrDNqHTniuetCJve5Kbbr6nSMtirqPzXYN 5Fdr4W52IoQYucsViRxVBbisgjbcdOhN4VIcH2CWaaamfiPj+LjmBpfKPM0mpHXlo0sD 0DRJB+LZKhfWtBHSPFp8UD5nuhbfTrQtLKPPALqatS9er4dCwDVFF14asUW3KEJPt/ri EyVY1b3JGLxWHLmBHqzbCqHKUG5YYdGEZyRysiqW1NKgNGn9DzCZjVXioXQYuvji41HP CbZB44+5BcvhSRP9WfmfTkQPEHa1oGcSGGBaf66/puCkV6mBiWWH2fa6q3iKZiCwsY1I wW5w== X-Gm-Message-State: AO0yUKX8UbcXCoEf2GdiscTsJJX+TpbvNjZjSULCsIngZ8yIGepjW3IS c2kH8rg54SULrY9XesFC6VFEj4X8RcY= X-Google-Smtp-Source: AK7set+cVi/w59x3bEbuJP1hWtElJc4+bNCGVmyhyPPnhZd7wAT6Q8FRGFrb7dZx/jeBefRhvhWilQ== X-Received: by 2002:a05:6402:510f:b0:4af:6e08:319 with SMTP id m15-20020a056402510f00b004af6e080319mr769584edd.15.1677264617008; Fri, 24 Feb 2023 10:50:17 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 01/14] x86/svm: move declarations used only by svm code from svm.h to private header Date: Fri, 24 Feb 2023 20:49:57 +0200 Message-Id: <20230224185010.3692754-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/svm called svm.h and move there all definitions and declarations that are used solely by svm code. Take the opportunity to remove the forward declaration of struct vcpu, that is a leftover since the removal of svm_update_guest_cr()'s declaration. Take the opportunity to re-arrange the header as follows, all structures first, then all variable decalarations, all function delarations, and finally all inline functions. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - add SPDX identifier in priv header, reported by Andrew - add #ifndef header guard, reported by Andrew and Jan - move svm_invlpga() as well, it was not called anyway - fold patch removing redundant forward declaration of struct vcpu into this patch, suggested by Andrew - rearrange the header in the way Jan's proposed - update commit message xen/arch/x86/hvm/svm/nestedsvm.c | 1 + xen/arch/x86/hvm/svm/svm.c | 2 + xen/arch/x86/hvm/svm/svm.h | 62 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/svm/svm.h | 41 ----------------- 4 files changed, 65 insertions(+), 41 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/svm.h diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 77f7547360..a341ccc876 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -27,6 +27,7 @@ #include /* for local_event_delivery_(en|dis)able */ #include /* p2m_get_pagetable, p2m_get_nestedp2m */ +#include "svm.h" #define NSVM_ERROR_VVMCB 1 #define NSVM_ERROR_VMENTRY 2 diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 9c43227b76..6d394e4fe3 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -55,6 +55,8 @@ #include +#include "svm.h" + void noreturn svm_asm_do_resume(void); u32 svm_feature_flags; diff --git a/xen/arch/x86/hvm/svm/svm.h b/xen/arch/x86/hvm/svm/svm.h new file mode 100644 index 0000000000..9e65919757 --- /dev/null +++ b/xen/arch/x86/hvm/svm/svm.h @@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * svm.h: SVM Architecture related definitions + * + * Copyright (c) 2005, AMD Corporation. + * Copyright (c) 2004, Intel Corporation. + */ + +#ifndef __X86_HVM_SVM_SVM_PRIV_H__ +#define __X86_HVM_SVM_SVM_PRIV_H__ + +#include + +struct cpu_user_regs; + +unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); +void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); + +static inline void svm_vmload_pa(paddr_t vmcb) +{ + asm volatile ( + ".byte 0x0f,0x01,0xda" /* vmload */ + : : "a" (vmcb) : "memory" ); +} + +static inline void svm_vmsave_pa(paddr_t vmcb) +{ + asm volatile ( + ".byte 0x0f,0x01,0xdb" /* vmsave */ + : : "a" (vmcb) : "memory" ); +} + +static inline void svm_invlpga(unsigned long linear, uint32_t asid) +{ + asm volatile ( + ".byte 0x0f,0x01,0xdf" + : /* output */ + : /* input */ + "a" (linear), "c" (asid)); +} + +/* TSC rate */ +#define DEFAULT_TSC_RATIO 0x0000000100000000ULL +#define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL + +/* EXITINFO1 fields on NPT faults */ +#define _NPT_PFEC_with_gla 32 +#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) +#define _NPT_PFEC_in_gpt 33 +#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) + +#endif /* __X86_HVM_SVM_SVM_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/hvm/svm/svm.h b/xen/arch/x86/include/asm/hvm/svm/svm.h index cf9ed517d5..7d5de0122a 100644 --- a/xen/arch/x86/include/asm/hvm/svm/svm.h +++ b/xen/arch/x86/include/asm/hvm/svm/svm.h @@ -20,37 +20,6 @@ #ifndef __ASM_X86_HVM_SVM_H__ #define __ASM_X86_HVM_SVM_H__ -#include - -static inline void svm_vmload_pa(paddr_t vmcb) -{ - asm volatile ( - ".byte 0x0f,0x01,0xda" /* vmload */ - : : "a" (vmcb) : "memory" ); -} - -static inline void svm_vmsave_pa(paddr_t vmcb) -{ - asm volatile ( - ".byte 0x0f,0x01,0xdb" /* vmsave */ - : : "a" (vmcb) : "memory" ); -} - -static inline void svm_invlpga(unsigned long linear, uint32_t asid) -{ - asm volatile ( - ".byte 0x0f,0x01,0xdf" - : /* output */ - : /* input */ - "a" (linear), "c" (asid)); -} - -struct cpu_user_regs; -struct vcpu; - -unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); -void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); - /* * PV context switch helpers. Prefetching the VMCB area itself has been shown * to be useful for performance. @@ -96,14 +65,4 @@ extern u32 svm_feature_flags; #define cpu_has_svm_sss cpu_has_svm_feature(SVM_FEATURE_SSS) #define cpu_has_svm_spec_ctrl cpu_has_svm_feature(SVM_FEATURE_SPEC_CTRL) -/* TSC rate */ -#define DEFAULT_TSC_RATIO 0x0000000100000000ULL -#define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL - -/* EXITINFO1 fields on NPT faults */ -#define _NPT_PFEC_with_gla 32 -#define NPT_PFEC_with_gla (1UL<<_NPT_PFEC_with_gla) -#define _NPT_PFEC_in_gpt 33 -#define NPT_PFEC_in_gpt (1UL<<_NPT_PFEC_in_gpt) - #endif /* __ASM_X86_HVM_SVM_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501412.773140 (Exim 4.92) (envelope-from ) id 1pVd97-0001X8-Ul; Fri, 24 Feb 2023 18:50:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501412.773140; Fri, 24 Feb 2023 18:50:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd97-0001X1-QY; Fri, 24 Feb 2023 18:50:17 +0000 Received: by outflank-mailman (input) for mailman id 501412; Fri, 24 Feb 2023 18:50:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd96-0001Wv-Tv for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:17 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13a4be97-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:15 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id cq23so1153443edb.1 for ; Fri, 24 Feb 2023 10:50:15 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13a4be97-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WPWU64P9jS5sgFIdD2Beznq5vyuGl4TCAyjWIhiI6p4=; b=Cdyo4SBxTWxk6zTj2VcRTvFPY5k4Oil02mGPLvTN7+gV2AltYdDK5LxfRz5v+2LnoW o+YyNo1v7uzIYVcSHDb/G8ovbPFNUa2YdWdPYHVpinN89fHD0rTq/felytAzOfNv6fn5 yY/bSlj/YDBFRs7/IApbnkIfs4lNH2rwYXwleeBYr5GVhGE97nyGmtDmorJ7N9QEBhrH Ywq3ycUuo3mub5fMsW7zNs+ufOUJm8GlHHWsr7bIBgH2RDPGoUV+VKsi69bl/7SNBulK qZtTOOWDNLkuGohWdlF9oyFHrbfUFHcVFjx25wfJWlb0OnOShFjSa28mV/pSCsmFt7Vg Zk1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WPWU64P9jS5sgFIdD2Beznq5vyuGl4TCAyjWIhiI6p4=; b=A1SQgSe1mT/X/fznB0EILshRUd5z8/MdKnKg0j3YDDAVFdPGerJ7rxzwdH1zO9K8Wv N6sMdsQZPYAiUhrCmz7jmkPenno5AXCg6V2SkGHHuL2zJRVUaj0kPWX74fSq5RFURH+G 5Y5Xa34AqNdCc0EybVPFXXZaun1fEswkWJlt5v+1AIMZqflfinYMZKyKDPppvapL4Tbf 4K70sPKcqOdJbtBGJs9qPdtAV4QgdkPAbdj65wl/45PdjvaZi2oo0rRRlV0Ln6/uSHj7 /wmOvN3VE9NPGciiya3WnzWPsSAqeiukPGqeFqnWQtGZvc9qAx5KYB3L3PUlZIJ8bo8N nAcA== X-Gm-Message-State: AO0yUKVxOAfU4yiHOqZr92tUuQCAnInric8qDAEAL3Sz2s3n+h4MU62u xLjmcOHLJmv7U2xn5eZbbOZ6iLqwx+U= X-Google-Smtp-Source: AK7set+5brI5Ej3zPaMIHvbXd/NKrG97foF+uPKqacv5xTYuvgaSBvNToLgEn1p/dUiSMIgyt2mBsA== X-Received: by 2002:a05:6402:164c:b0:4ad:7c30:25a3 with SMTP id s12-20020a056402164c00b004ad7c3025a3mr17302430edx.1.1677264615035; Fri, 24 Feb 2023 10:50:15 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Date: Fri, 24 Feb 2023 20:49:56 +0200 Message-Id: <20230224185010.3692754-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series attempts a cleanup of files {svm,vmx} files and headers by removing redundant headers and sorting the rest, reducing the scope of declarations and definitions, moving functions used only by internal {svm,vmx} code to private headers, fix coding style, replace u* with uint*_t types etc. This series aims to address the comments made on v2. Main changes from the v2 series: - move all internal svm/vmx declarations found in external headers into private headers - add SPDX tags and guards to the new headers - take the opportunity to fix coding style issues and rearrange the code per Jan's suggestion - replace u* with uint*_t - rebased to the latest staging There are more detailed per-patch changesets. Xenia Ragiadakou (14): x86/svm: move declarations used only by svm code from svm.h to private header x86/svm: make asid.h private x86/svm: delete header asm/hvm/svm/intr.h x86/svm: make emulate.h private x86/svm: move nestedsvm declarations used only by svm code to private header x86/svm: move vmcb declarations used only by svm code to private header x86/svm: move svmdebug.h declarations to private vmcb.h and delete it x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static x86/vmx: remove unused included headers from vmx.h x86/vmx: move declarations used only by vmx code from vmx.h to private headers x86/vmx: remove unused included headers from vmx.c x86/vmx: declare nvmx_enqueue_n2_exceptions() static x86/vmx: move vvmx declarations used only by vmx code to private header x86/vmx: move vmcs declarations used only by vmx code to private header xen/arch/x86/hvm/svm/asid.c | 4 +- xen/arch/x86/hvm/svm/asid.h | 38 ++ xen/arch/x86/hvm/svm/emulate.c | 4 +- .../x86/{include/asm => }/hvm/svm/emulate.h | 20 +- xen/arch/x86/hvm/svm/intr.c | 4 +- xen/arch/x86/hvm/svm/nestedhvm.h | 77 +++ xen/arch/x86/hvm/svm/nestedsvm.c | 7 +- xen/arch/x86/hvm/svm/svm.c | 10 +- xen/arch/x86/hvm/svm/svm.h | 62 ++ xen/arch/x86/hvm/svm/svmdebug.c | 3 +- xen/arch/x86/hvm/svm/vmcb.c | 3 +- xen/arch/x86/hvm/svm/vmcb.h | 597 ++++++++++++++++++ xen/arch/x86/hvm/vmx/intr.c | 4 + xen/arch/x86/hvm/vmx/pi.h | 78 +++ xen/arch/x86/hvm/vmx/realmode.c | 2 + xen/arch/x86/hvm/vmx/vmcs.c | 17 +- xen/arch/x86/hvm/vmx/vmcs.h | 100 +++ xen/arch/x86/hvm/vmx/vmx.c | 76 +-- xen/arch/x86/hvm/vmx/vmx.h | 416 ++++++++++++ xen/arch/x86/hvm/vmx/vvmx.c | 4 + xen/arch/x86/hvm/vmx/vvmx.h | 187 ++++++ xen/arch/x86/include/asm/hvm/svm/asid.h | 49 -- xen/arch/x86/include/asm/hvm/svm/intr.h | 25 - xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 53 +- xen/arch/x86/include/asm/hvm/svm/svm.h | 41 -- xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 30 - xen/arch/x86/include/asm/hvm/svm/vmcb.h | 575 +---------------- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 118 +--- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 453 +------------ xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 165 +---- 30 files changed, 1685 insertions(+), 1537 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/asid.h rename xen/arch/x86/{include/asm => }/hvm/svm/emulate.h (73%) create mode 100644 xen/arch/x86/hvm/svm/nestedhvm.h create mode 100644 xen/arch/x86/hvm/svm/svm.h create mode 100644 xen/arch/x86/hvm/svm/vmcb.h create mode 100644 xen/arch/x86/hvm/vmx/pi.h create mode 100644 xen/arch/x86/hvm/vmx/vmcs.h create mode 100644 xen/arch/x86/hvm/vmx/vmx.h create mode 100644 xen/arch/x86/hvm/vmx/vvmx.h delete mode 100644 xen/arch/x86/include/asm/hvm/svm/asid.h delete mode 100644 xen/arch/x86/include/asm/hvm/svm/intr.h delete mode 100644 xen/arch/x86/include/asm/hvm/svm/svmdebug.h -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501414.773156 (Exim 4.92) (envelope-from ) id 1pVd9A-0001qa-Iv; Fri, 24 Feb 2023 18:50:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501414.773156; Fri, 24 Feb 2023 18:50:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9A-0001px-EA; Fri, 24 Feb 2023 18:50:20 +0000 Received: by outflank-mailman (input) for mailman id 501414; Fri, 24 Feb 2023 18:50:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd99-0001Wv-Uw for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:20 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15c00070-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:19 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id ee7so1127029edb.2 for ; Fri, 24 Feb 2023 10:50:19 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15c00070-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bco5bSqEWusubMpaw+Hfl1JBeko3KHLffepxLAFmo6E=; b=R/Bk6ghbcUbXyuoFrgS3T5hNsN5ZIk9+H4PgFcX9k9vnmrEJswbaKEV4nz/825tFvc 4oJvRifjhKIcSPjgarXKJaHtNXre0cQ/z9MTsYyvLyx0tVTQPoiDf343/AATpquKGIIP 4SZwHCi7rovxiNEMz/amOGRH1ZL7HEa+Y3Tg0W1MF2aqmdhoLMY3RSST0GXjjLaeS5n6 C30AOXN/s/vWIYoInBYdQigmBJlMHgKitlotTR0UNLkwH9uFfZ79rV4UsOuZ3jCoOHKv qUxG9pwiq0wRGfYlRIJ0fTCvpAgmxY1C9yK2aNqgU8jJW16G3k8q14nqqHAFeNY5VYdh 46Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bco5bSqEWusubMpaw+Hfl1JBeko3KHLffepxLAFmo6E=; b=xFWQdv7px6+bDNKTL4iPEkYO0lnO1+TFpodGbMk1DfYXIDwzsTS1J9A/tqB0fPZdvj G7mNiaX3oajtFYPvOqk2ET+YnMQPwhSVDWlBEwoPIqlU62YreEhkpFYobB8iV5Dh+/Pm d1sPw1yS4vWhDuL06iQEd1Gk4uFQ2eKWnEVqPBLLs1qC/33DQnL+sHvFxIdbQPKTxp40 LoLp0f8D89OgIhWHSdH4DXdrQRGoQVLv7K0n+Rjl6D/0UiO6thEDzeiM32KN/egLkeZi UKGSe2twmefTF7wnXa0Wmqv/5ukF1xai8njRTz/LUDloHEPlS5hu0TFBT+iSZoCzH/BS /DBA== X-Gm-Message-State: AO0yUKVeea77gU6tYPTZcpk5wtHCPX0Iqo0P1hU1wC5Xd+JUH7PHtIXb /E9JTVIFIlJao2O2KJhLroaHDiHKU4M= X-Google-Smtp-Source: AK7set+8uC8eKcxhrC/cQNSnKM9kiGL8BrTnT8AKAF2bYRESkZE8apgLs9KYZV8250yv4ZUXtjC1FQ== X-Received: by 2002:a17:906:af1a:b0:880:a42d:dfb4 with SMTP id lx26-20020a170906af1a00b00880a42ddfb4mr23476209ejb.16.1677264618696; Fri, 24 Feb 2023 10:50:18 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 02/14] x86/svm: make asid.h private Date: Fri, 24 Feb 2023 20:49:58 +0200 Message-Id: <20230224185010.3692754-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The asm/hvm/svm/asid.h is used only internally by the SVM code, so it can be changed into a private header. Take the opportunity to use an SPDX tag for the licence and remove included but unused xen/types.h. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/svm/asid.c | 3 +- xen/arch/x86/hvm/svm/asid.h | 38 +++++++++++++++++++ xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/include/asm/hvm/svm/asid.h | 49 ------------------------- 4 files changed, 41 insertions(+), 51 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/asid.h delete mode 100644 xen/arch/x86/include/asm/hvm/svm/asid.h diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index ab06dd3f3a..1128434878 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -17,9 +17,10 @@ #include #include -#include #include +#include "asid.h" + void svm_asid_init(const struct cpuinfo_x86 *c) { int nasids = 0; diff --git a/xen/arch/x86/hvm/svm/asid.h b/xen/arch/x86/hvm/svm/asid.h new file mode 100644 index 0000000000..4dd6abb5fb --- /dev/null +++ b/xen/arch/x86/hvm/svm/asid.h @@ -0,0 +1,38 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * asid.h: handling ASIDs in SVM. + * + * Copyright (c) 2007, Advanced Micro Devices, Inc. + */ + +#ifndef __X86_HVM_SVM_ASID_PRIV_H__ +#define __X86_HVM_SVM_ASID_PRIV_H__ + +#include +#include + +void svm_asid_init(const struct cpuinfo_x86 *c); +void svm_asid_handle_vmrun(void); + +static inline void svm_asid_g_invlpg(struct vcpu *v, unsigned long g_linear) +{ +#if 0 + /* Optimization? */ + svm_invlpga(g_linear, v->arch.hvm.svm.vmcb->guest_asid); +#endif + + /* Safe fallback. Take a new ASID. */ + hvm_asid_flush_vcpu(v); +} + +#endif /* __X86_HVM_SVM_ASID_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 6d394e4fe3..793a10eaca 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include @@ -55,6 +54,7 @@ #include +#include "asid.h" #include "svm.h" void noreturn svm_asm_do_resume(void); diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h deleted file mode 100644 index 0e5ec3ab78..0000000000 --- a/xen/arch/x86/include/asm/hvm/svm/asid.h +++ /dev/null @@ -1,49 +0,0 @@ -/* - * asid.h: handling ASIDs in SVM. - * Copyright (c) 2007, Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - */ - -#ifndef __ASM_X86_HVM_SVM_ASID_H__ -#define __ASM_X86_HVM_SVM_ASID_H__ - -#include -#include -#include - -void svm_asid_init(const struct cpuinfo_x86 *c); -void svm_asid_handle_vmrun(void); - -static inline void svm_asid_g_invlpg(struct vcpu *v, unsigned long g_linear) -{ -#if 0 - /* Optimization? */ - svm_invlpga(g_linear, v->arch.hvm.svm.vmcb->guest_asid); -#endif - - /* Safe fallback. Take a new ASID. */ - hvm_asid_flush_vcpu(v); -} - -#endif /* __ASM_X86_HVM_SVM_ASID_H__ */ - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501415.773170 (Exim 4.92) (envelope-from ) id 1pVd9C-0002JR-RK; Fri, 24 Feb 2023 18:50:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501415.773170; Fri, 24 Feb 2023 18:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9C-0002JF-OM; Fri, 24 Feb 2023 18:50:22 +0000 Received: by outflank-mailman (input) for mailman id 501415; Fri, 24 Feb 2023 18:50:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9B-0001Wv-8v for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:21 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16941704-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:20 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id o12so973145edb.9 for ; Fri, 24 Feb 2023 10:50:20 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16941704-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EVRXkyrkP5QFPLk14BArykZPkRsSPQyM5ImGy6R3Rls=; b=H8CE5B8FtW7HBZUNB+eEIqli2ySexAbCBkHo2Fe4zsCgCRi+7hbLECKFyq8YQSxQzE i0fegid+8lkZ0/klzpIRgXk1CNkLYT4w1ehKTQDW9pl2sZ5eP8gr60HhyOjGug72FJWo W9ViG/CDuQ8iZNAZRy0it6FCzximnW+dQR3zm9xscua7kzystn+nrm5gzrckwW/VklyB n3CjOJAg7bnyJ0CXGjR/GZLFg0Sy4knGYEQTjuBDuH87xQ1dKigbHFpHTklHyT0hBd9V 5V+ucOrWm1ScdsuiUIhfotC1hyPmz/++IjqBYGZSx24gWJxKyszeOepdJZ3wFHlDiOCe oW0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EVRXkyrkP5QFPLk14BArykZPkRsSPQyM5ImGy6R3Rls=; b=44Hyhd2TMpvQE9qPVIc/rUvLGzhKIt01AqTfY7e684CBmN+YrbRpbI89AKcFLBQMkN qp1jHK30f4w4C8uMPiGL6zNJu3q8jTWnM2124FjtY22eBbJAm5eF0E3JKQW8WHs+2jAF 6YzuNp3F/KGZghH5t2zNQKABo6726/ldxv/xZV8Z1fJMvf6W8FFrRmUGmc4hmIfexiUk eDltB7cHPvXpTZ1yw4hRWp7WMHA66XZriyQ8vkSqWUrCPLaQNxxF91kaEvDFCW9oKyHm lBYvF4PoYnVxDO9gE1NV9A4Zz9mToQfgQzk65+Rsj1PJzVXR0VF3Yut7frIGB8o/ajH7 HMAQ== X-Gm-Message-State: AO0yUKX+3EkBVBSZJIHeMsMSBPH3U2ea2Gt5at0P69t5vXQptTA6W7/Z xbtwWg6KKnnUNPBiWZWJ0D4ABfpP5U0= X-Google-Smtp-Source: AK7set+TpHnuQ8SG+/zZz97KRpdgwMkSwKqi4YH0qqP0s+IJ7pgKT8ycsnrT0kWyENH+iIfTU+higg== X-Received: by 2002:a17:906:8d0a:b0:8f2:62a9:6159 with SMTP id rv10-20020a1709068d0a00b008f262a96159mr5518393ejc.2.1677264620157; Fri, 24 Feb 2023 10:50:20 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 03/14] x86/svm: delete header asm/hvm/svm/intr.h Date: Fri, 24 Feb 2023 20:49:59 +0200 Message-Id: <20230224185010.3692754-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Delete asm/hvm/svm/intr.h because it contains only the declaration of svm_intr_assist() which is referenced only by assembly. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch, suggested by Andrew xen/arch/x86/hvm/svm/intr.c | 1 - xen/arch/x86/include/asm/hvm/svm/intr.h | 25 ------------------------- 2 files changed, 26 deletions(-) delete mode 100644 xen/arch/x86/include/asm/hvm/svm/intr.h diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index 9525f35593..d21e930af0 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -29,7 +29,6 @@ #include #include #include -#include #include /* for nestedhvm_vcpu_in_guestmode */ #include #include diff --git a/xen/arch/x86/include/asm/hvm/svm/intr.h b/xen/arch/x86/include/asm/hvm/svm/intr.h deleted file mode 100644 index ae52d9f948..0000000000 --- a/xen/arch/x86/include/asm/hvm/svm/intr.h +++ /dev/null @@ -1,25 +0,0 @@ -/* - * intr.h: SVM Architecture related definitions - * Copyright (c) 2005, AMD Corporation. - * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * - */ - -#ifndef __ASM_X86_HVM_SVM_INTR_H__ -#define __ASM_X86_HVM_SVM_INTR_H__ - -void svm_intr_assist(void); - -#endif /* __ASM_X86_HVM_SVM_INTR_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501416.773179 (Exim 4.92) (envelope-from ) id 1pVd9F-0002bi-6Q; Fri, 24 Feb 2023 18:50:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501416.773179; Fri, 24 Feb 2023 18:50:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9F-0002bb-2u; Fri, 24 Feb 2023 18:50:25 +0000 Received: by outflank-mailman (input) for mailman id 501416; Fri, 24 Feb 2023 18:50:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9E-0002YL-6h for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:24 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 176698b8-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:22 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id h16so957915edz.10 for ; Fri, 24 Feb 2023 10:50:22 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 176698b8-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KL9lzwZ35ftF87QkRCnj2FkoflnDCOsUHUBVWqz7qNU=; b=HF3jxW9vODJL8Fmk50sLGa5xDdXq2HeRmYVvW+7y7LqH1gpMOeFrUeBrPO1y9fuUsp IJCB6GhYPiI9dDLqQu8KfkUpMsUCYIgwI515HV49XGRexLXxUTjtIIDZd64PhjHo9gSj OW2p13RKl/tMe1ltzZdYj+b7YDxXjavoEN7k9q9tDRQ1JQQuVN4Z0Ck1NUZgEo7GzDxu 37I2EljTppxssX60KPqD3VzVZ3NvhWIeKMLR4WwaPntdLkANisi9Chp+NLd9Ns6F/K9/ qQtohPTnArQJZhwhrTsBAVEYWDLQP3h5Ds/HSwYeZVWuHYCnMNFm5VjuXKunmxNmWFHP GtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KL9lzwZ35ftF87QkRCnj2FkoflnDCOsUHUBVWqz7qNU=; b=h6W0rM6O5ttV+IYmGvWJOEvnc8Mc1taP7jXun63Y9CF4tOliJ32XD2QEL1sI9LjdzZ h/SpwAjDTL9CY6w9WaqTSdX2TxM+/ZEAMe0QpY4hGuyIcrFMXu1GtSmpWK9+U2b4NEBy d8Z/ZQEpQtAjBPersfUpFSZpY/YOr/Tgyq7hQf5Zg8MTW/v8AE7VqBuEaq0U1P4/Txey pFy+yvSoi1LkdNg+Mgr+XUpgntMtuf9ITYTVSv62ctUDYc4wgCgvRzdkaKQglQQzchfr HSVeARRcPdvAZT291JznQuRYAjrQ26bChrWc+VQGLHKVAJhaNv0FLr1/sTcmaOsJ2DoQ Chkw== X-Gm-Message-State: AO0yUKXWjJy5fQIAEeE0PL/TrhTIZEgrCtZMsjDaLZj1Mv/5wkAVlN4k NSdA6VguJWTf1VEpz2QWfThYVhX49AU= X-Google-Smtp-Source: AK7set8wO/M04U9cnd0sCME4qj2tNOUpoPg6UmcMghRa+mE7pAAWnUID9EMwFSS7vNY1mRRHj4XKzA== X-Received: by 2002:a17:906:e293:b0:8aa:9abe:8edd with SMTP id gg19-20020a170906e29300b008aa9abe8eddmr27669015ejb.66.1677264621570; Fri, 24 Feb 2023 10:50:21 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 04/14] x86/svm: make emulate.h private Date: Fri, 24 Feb 2023 20:50:00 +0200 Message-Id: <20230224185010.3692754-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The header asm/hvm/svm/emulate.h is used only internally by the SVM code, so it can be changed into a private header. Take the opportunity to use an SPDX tag for the licence. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/svm/emulate.c | 3 ++- .../x86/{include/asm => }/hvm/svm/emulate.h | 20 +++++-------------- xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- 4 files changed, 9 insertions(+), 18 deletions(-) rename xen/arch/x86/{include/asm => }/hvm/svm/emulate.h (73%) diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883..4a84b4e761 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -24,7 +24,8 @@ #include #include #include -#include + +#include "emulate.h" static unsigned long svm_nextrip_insn_length(struct vcpu *v) { diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/hvm/svm/emulate.h similarity index 73% rename from xen/arch/x86/include/asm/hvm/svm/emulate.h rename to xen/arch/x86/hvm/svm/emulate.h index eb1a8c24af..c0d27772a5 100644 --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h +++ b/xen/arch/x86/hvm/svm/emulate.h @@ -1,23 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * emulate.h: SVM instruction emulation bits. + * * Copyright (c) 2005, AMD Corporation. * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . */ -#ifndef __ASM_X86_HVM_SVM_EMULATE_H__ -#define __ASM_X86_HVM_SVM_EMULATE_H__ +#ifndef __X86_HVM_SVM_EMULATE_PRIV_H__ +#define __X86_HVM_SVM_EMULATE_PRIV_H__ /* * Encoding for svm_get_insn_len(). We take X86EMUL_OPC() for the main @@ -53,7 +43,7 @@ struct vcpu; unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc); unsigned int svm_get_task_switch_insn_len(void); -#endif /* __ASM_X86_HVM_SVM_EMULATE_H__ */ +#endif /* __X86_HVM_SVM_EMULATE_PRIV_H__ */ /* * Local variables: diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index a341ccc876..5f5752ce21 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -17,7 +17,6 @@ */ #include -#include #include #include #include @@ -27,6 +26,7 @@ #include /* for local_event_delivery_(en|dis)able */ #include /* p2m_get_pagetable, p2m_get_nestedp2m */ +#include "emulate.h" #include "svm.h" #define NSVM_ERROR_VVMCB 1 diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 793a10eaca..c767a3eb76 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include @@ -55,6 +54,7 @@ #include #include "asid.h" +#include "emulate.h" #include "svm.h" void noreturn svm_asm_do_resume(void); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501417.773190 (Exim 4.92) (envelope-from ) id 1pVd9G-0002su-Fz; Fri, 24 Feb 2023 18:50:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501417.773190; Fri, 24 Feb 2023 18:50:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9G-0002sg-B0; Fri, 24 Feb 2023 18:50:26 +0000 Received: by outflank-mailman (input) for mailman id 501417; Fri, 24 Feb 2023 18:50:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9E-0001Wv-AN for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:24 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1842c71b-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:23 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id cy6so1064825edb.5 for ; Fri, 24 Feb 2023 10:50:23 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1842c71b-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gqq2LM2t+HmFiSRF7FgdQUDEL19Q+hSAOOihEvGk4Dc=; b=L8p9Wve2dDEeQN1XTdp7iNd4kJdRVxTiDa1Pcm+GXkxAFqtMI77EWbXqr3B8lVdmRG Hqy3mUfHS4HtIet0RwUgr4HTAOVHAeMsE6XdqfILHnFnYJRO0mx9I+/ZIdzDIxcITkEd mhtA1nmDY2oWun6zZ9prBz9G6eYeHokTD/f/T61XS7ZKIxSxwUeF1oBNX1/CXWMplWwc tT9MggRxWlZC4zm8XJP+r7HyWRS5WOTbk2e+Q0XP2oo9R97Am6gAS1mLGK31zJhvjZhD rcN4Rj40JQeBXhDLJHICznNf6BjKxiwr9IV4OU2Zj0wfcgZfts0cGiQzEfmRBRCyZHdi 5gkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gqq2LM2t+HmFiSRF7FgdQUDEL19Q+hSAOOihEvGk4Dc=; b=aWWkl27kcjeY08+skMypthOvZPNfdfNbNfESoLqXHrrMBLgZ0WwzPfJWL5Ku6KEaar ZfFmxnH0xVDrUCKU80qziRUfE1mdIwY6IJ/+cpQut6NKrTLa1YijUmtitRFBC9CpUAgj m+jQhkXLry+BEQXejQtSnr6LYAaPNNERpfTTjADhskRRVVLoXi7iPzu4OlYwLorVplHN aRNDl6fLiCeIUb9RrPnFMr2tDzI4HLKYCf/uMzoQ+EBGepl05vSIbfvT0A5EKLLR/kZm 9DLO0i5htrd3TNfuwW/lzlwnM0wo3Q6UNq4uQzRPqBLnrFDAI4z18fg6Up5bk7Ko+25T XINg== X-Gm-Message-State: AO0yUKX0bbxSPs4O8RVGWAHexsMJZBVDohNTl7RgHzXozrEVJSa1+N8y MSlFVopc3RXoIFP3ldepeccPGBvFmeI= X-Google-Smtp-Source: AK7set+kcFY7XsDKtLQs18c6Bb0OK0K3u0Stm/G02MIx8hyZlJr+N6G0D80/JfLmA3IwyCtPtv6aRw== X-Received: by 2002:a17:907:5c6:b0:8af:3b78:315d with SMTP id wg6-20020a17090705c600b008af3b78315dmr33240581ejb.23.1677264623042; Fri, 24 Feb 2023 10:50:23 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 05/14] x86/svm: move nestedsvm declarations used only by svm code to private header Date: Fri, 24 Feb 2023 20:50:01 +0200 Message-Id: <20230224185010.3692754-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/svm called nestedsvm.h and move there all definitions and declarations that are used only by svm code and don't need to reside in an external header. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/svm/intr.c | 2 + xen/arch/x86/hvm/svm/nestedhvm.h | 77 ++++++++++++++++++++ xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 53 +------------- 6 files changed, 86 insertions(+), 52 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/nestedhvm.h diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index d21e930af0..dbb0022190 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -37,6 +37,8 @@ #include #include +#include "nestedhvm.h" + static void svm_inject_nmi(struct vcpu *v) { struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h new file mode 100644 index 0000000000..43245e13de --- /dev/null +++ b/xen/arch/x86/hvm/svm/nestedhvm.h @@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * nestedsvm.h: Nested Virtualization + * + * Copyright (c) 2011, Advanced Micro Devices, Inc + */ + +#ifndef __X86_HVM_SVM_NESTEDHVM_PRIV_H__ +#define __X86_HVM_SVM_NESTEDHVM_PRIV_H__ + +#include +#include + +#include +#include +#include +#include + +/* SVM specific intblk types, cannot be an enum because gcc 4.5 complains */ +/* GIF cleared */ +#define hvm_intblk_svm_gif hvm_intblk_arch + +#define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) + +/* True when l1 guest enabled SVM in EFER */ +#define nsvm_efer_svm_enabled(v) \ + (!!((v)->arch.hvm.guest_efer & EFER_SVME)) + +int nestedsvm_vmcb_map(struct vcpu *v, uint64_t vmcbaddr); +void nestedsvm_vmexit_defer(struct vcpu *v, + uint64_t exitcode, uint64_t exitinfo1, uint64_t exitinfo2); +enum nestedhvm_vmexits +nestedsvm_vmexit_n2n1(struct vcpu *v, struct cpu_user_regs *regs); +enum nestedhvm_vmexits +nestedsvm_check_intercepts(struct vcpu *v, struct cpu_user_regs *regs, + uint64_t exitcode); +void svm_nested_features_on_efer_update(struct vcpu *v); + +/* Interface methods */ +void cf_check nsvm_vcpu_destroy(struct vcpu *v); +int cf_check nsvm_vcpu_initialise(struct vcpu *v); +int cf_check nsvm_vcpu_reset(struct vcpu *v); +int nsvm_vcpu_vmrun(struct vcpu *v, struct cpu_user_regs *regs); +int cf_check nsvm_vcpu_vmexit_event(struct vcpu *v, + const struct x86_event *event); +uint64_t cf_check nsvm_vcpu_hostcr3(struct vcpu *v); +bool cf_check nsvm_vmcb_guest_intercepts_event( + struct vcpu *v, unsigned int vector, int errcode); +bool cf_check nsvm_vmcb_hap_enabled(struct vcpu *v); +enum hvm_intblk cf_check nsvm_intr_blocked(struct vcpu *v); + +/* Interrupts, vGIF */ +void svm_vmexit_do_clgi(struct cpu_user_regs *regs, struct vcpu *v); +void svm_vmexit_do_stgi(struct cpu_user_regs *regs, struct vcpu *v); +bool nestedsvm_gif_isset(struct vcpu *v); +int cf_check nsvm_hap_walk_L1_p2m( + struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order, + uint8_t *p2m_acc, struct npfec npfec); + +#define NSVM_INTR_NOTHANDLED 3 +#define NSVM_INTR_NOTINTERCEPTED 2 +#define NSVM_INTR_FORCEVMEXIT 1 +#define NSVM_INTR_MASKED 0 + +int nestedsvm_vcpu_interrupt(struct vcpu *v, const struct hvm_intack intack); + +#endif /* __X86_HVM_SVM_NESTEDHVM_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 5f5752ce21..80b72b5dee 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -20,13 +20,13 @@ #include #include #include -#include #include #include /* paging_mode_hap */ #include /* for local_event_delivery_(en|dis)able */ #include /* p2m_get_pagetable, p2m_get_nestedp2m */ #include "emulate.h" +#include "nestedhvm.h" #include "svm.h" #define NSVM_ERROR_VVMCB 1 diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index c767a3eb76..4b74ee3d7c 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include @@ -55,6 +54,7 @@ #include "asid.h" #include "emulate.h" +#include "nestedhvm.h" #include "svm.h" void noreturn svm_asm_do_resume(void); diff --git a/xen/arch/x86/hvm/svm/svm.h b/xen/arch/x86/hvm/svm/svm.h index 9e65919757..f700f26f90 100644 --- a/xen/arch/x86/hvm/svm/svm.h +++ b/xen/arch/x86/hvm/svm/svm.h @@ -36,7 +36,7 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) ".byte 0x0f,0x01,0xdf" : /* output */ : /* input */ - "a" (linear), "c" (asid)); + "a" (linear), "c" (asid) ); } /* TSC rate */ diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 656d7d1a9a..94d45d2e8d 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -18,15 +18,12 @@ #ifndef __ASM_X86_HVM_SVM_NESTEDSVM_H__ #define __ASM_X86_HVM_SVM_NESTEDSVM_H__ -#include -#include +#include -/* SVM specific intblk types, cannot be an enum because gcc 4.5 complains */ -/* GIF cleared */ -#define hvm_intblk_svm_gif hvm_intblk_arch +#include struct nestedsvm { - bool_t ns_gif; + bool ns_gif; uint64_t ns_msr_hsavepa; /* MSR HSAVE_PA value */ /* l1 guest physical address of virtual vmcb used by prior VMRUN. @@ -72,7 +69,7 @@ struct nestedsvm { uint64_t ns_vmcb_guestcr3, ns_vmcb_hostcr3; uint32_t ns_guest_asid; - bool_t ns_hap_enabled; + bool ns_hap_enabled; /* Only meaningful when vmexit_pending flag is set */ struct { @@ -90,48 +87,6 @@ struct nestedsvm { } ns_hostflags; }; -#define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) - -/* True when l1 guest enabled SVM in EFER */ -#define nsvm_efer_svm_enabled(v) \ - (!!((v)->arch.hvm.guest_efer & EFER_SVME)) - -int nestedsvm_vmcb_map(struct vcpu *v, uint64_t vmcbaddr); -void nestedsvm_vmexit_defer(struct vcpu *v, - uint64_t exitcode, uint64_t exitinfo1, uint64_t exitinfo2); -enum nestedhvm_vmexits -nestedsvm_vmexit_n2n1(struct vcpu *v, struct cpu_user_regs *regs); -enum nestedhvm_vmexits -nestedsvm_check_intercepts(struct vcpu *v, struct cpu_user_regs *regs, - uint64_t exitcode); -void svm_nested_features_on_efer_update(struct vcpu *v); - -/* Interface methods */ -void cf_check nsvm_vcpu_destroy(struct vcpu *v); -int cf_check nsvm_vcpu_initialise(struct vcpu *v); -int cf_check nsvm_vcpu_reset(struct vcpu *v); -int nsvm_vcpu_vmrun(struct vcpu *v, struct cpu_user_regs *regs); -int cf_check nsvm_vcpu_vmexit_event(struct vcpu *v, const struct x86_event *event); -uint64_t cf_check nsvm_vcpu_hostcr3(struct vcpu *v); -bool cf_check nsvm_vmcb_guest_intercepts_event( - struct vcpu *v, unsigned int vector, int errcode); -bool cf_check nsvm_vmcb_hap_enabled(struct vcpu *v); -enum hvm_intblk cf_check nsvm_intr_blocked(struct vcpu *v); - -/* Interrupts, vGIF */ -void svm_vmexit_do_clgi(struct cpu_user_regs *regs, struct vcpu *v); -void svm_vmexit_do_stgi(struct cpu_user_regs *regs, struct vcpu *v); -bool_t nestedsvm_gif_isset(struct vcpu *v); -int cf_check nsvm_hap_walk_L1_p2m( - struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order, - uint8_t *p2m_acc, struct npfec npfec); - -#define NSVM_INTR_NOTHANDLED 3 -#define NSVM_INTR_NOTINTERCEPTED 2 -#define NSVM_INTR_FORCEVMEXIT 1 -#define NSVM_INTR_MASKED 0 -int nestedsvm_vcpu_interrupt(struct vcpu *v, const struct hvm_intack intack); - #endif /* ASM_X86_HVM_SVM_NESTEDSVM_H__ */ /* -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501418.773200 (Exim 4.92) (envelope-from ) id 1pVd9I-0003Co-UK; Fri, 24 Feb 2023 18:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501418.773200; Fri, 24 Feb 2023 18:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9I-0003CZ-Qj; Fri, 24 Feb 2023 18:50:28 +0000 Received: by outflank-mailman (input) for mailman id 501418; Fri, 24 Feb 2023 18:50:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9H-0001Wv-Kz for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:27 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a51def2-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:27 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id x10so890554edd.13 for ; Fri, 24 Feb 2023 10:50:27 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:26 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a51def2-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qi5tSetwNB2KxLoKFto8c4h593SGH+tQKkr8ph4elAo=; b=cgBa9w+QDqIEgbqmSB94g1hRBCeI3j4m4nhjP5KZ4Cfo4v1t2Mq47pYwFxO/0Ot/F8 Jq7Uejult3qFPddSY7UKMHxaGk/sTfgi8NYboZBCa1IePRLhZfOky60sn1MHzI8PR3gP wq2E305K7NetQVnwafcOE9hHOyAAyIoxjpDrSSsUGPL3zv1h5nqPr8LHVAYJfWLAB6L1 3VnurPD9X7rrPgdVCNpfe9/pfMNDNv8+zdCzKwEcSujZ5IMaexx1QNWhKm4gph6kdITm jhRsxRt+lphRabXmvGVmfRDnFQxJp2r1FEBmfpr6lh/2clWUgcrKNxu41sZxlHe0v6Gp +NUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qi5tSetwNB2KxLoKFto8c4h593SGH+tQKkr8ph4elAo=; b=4xMselme8ZSQNGNPJ8kFyz2GFQ2aZW5fyZSJClSmg1z5/Kc7qG2kgG93qjvitGeQxz CzQuYMyUmpYGr7ONL/1Edvj1xksioIQYzm3YDddiai7an3B3wQyQY09IDMMlkJ5HN7vZ X0J3Pgj/Ht53goP1sLYSt5TMM9NrUEjmT4wkuTNXOxSO+cw0uSsu08WgdmQfJpRSJZDr pzf1m3NFAx8/F1/Upitwjot5r0rrmRfslijoDB5px6pGwwcQ0R3z4gDS87F6HV5wevnz ciNUPK6gHgHdi6VezjY3uHa+5d2BEAMbCluqafUGufEEGHNSUy+uxaDWdnfPPZjpaYk/ zoKA== X-Gm-Message-State: AO0yUKVozoIoWlDCTqiYyX/2IvcV+E7YI3MxnG9Co73X02sNsp+DxcgG /w7OH7De/REeNXAgwGfYy8rTBOAKeGg= X-Google-Smtp-Source: AK7set8b7hRU9JfFfiGBOSn2pcFnBtYVPgGpW5Hwa2AxGLaJd9xetIYoMA3yRULeOHwUcudm3Nw8/g== X-Received: by 2002:a17:906:7488:b0:8b1:7a86:b06f with SMTP id e8-20020a170906748800b008b17a86b06fmr27507338ejl.63.1677264626471; Fri, 24 Feb 2023 10:50:26 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 07/14] x86/svm: move svmdebug.h declarations to private vmcb.h and delete it Date: Fri, 24 Feb 2023 20:50:03 +0200 Message-Id: <20230224185010.3692754-8-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the declarations in svmdebug.h to private vmcb.h because are vmcb specific and are used only by internal svm code, and delete svmdebug.h. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch, suggested by Andrew xen/arch/x86/hvm/svm/nestedsvm.c | 1 - xen/arch/x86/hvm/svm/svm.c | 1 - xen/arch/x86/hvm/svm/svmdebug.c | 1 - xen/arch/x86/hvm/svm/vmcb.c | 1 - xen/arch/x86/hvm/svm/vmcb.h | 6 +++++ xen/arch/x86/include/asm/hvm/svm/svmdebug.h | 30 --------------------- 6 files changed, 6 insertions(+), 34 deletions(-) delete mode 100644 xen/arch/x86/include/asm/hvm/svm/svmdebug.h diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index efbd9bbb77..201da7d531 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -20,7 +20,6 @@ #include #include #include -#include #include /* paging_mode_hap */ #include /* for local_event_delivery_(en|dis)able */ #include /* p2m_get_pagetable, p2m_get_nestedp2m */ diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 86b1bf3242..0a1b447e36 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -38,7 +38,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index ade74dfd8f..7fd0753116 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -19,7 +19,6 @@ #include #include #include -#include #include "vmcb.h" diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 1d512fedb0..657b4b1670 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -27,7 +27,6 @@ #include #include #include -#include #include #include "vmcb.h" diff --git a/xen/arch/x86/hvm/svm/vmcb.h b/xen/arch/x86/hvm/svm/vmcb.h index c58625fd80..80143164e5 100644 --- a/xen/arch/x86/hvm/svm/vmcb.h +++ b/xen/arch/x86/hvm/svm/vmcb.h @@ -11,6 +11,7 @@ #include +#include #include /* general 1 intercepts */ @@ -518,6 +519,11 @@ void svm_destroy_vmcb(struct vcpu *v); void setup_vmcb_dump(void); +void svm_sync_vmcb(struct vcpu *v, enum vmcb_sync_state new_state); +void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb); +bool svm_vmcb_isvalid(const char *from, const struct vmcb_struct *vmcb, + const struct vcpu *v, bool verbose); + /* * VMCB accessor functions. */ diff --git a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h b/xen/arch/x86/include/asm/hvm/svm/svmdebug.h deleted file mode 100644 index 330c1d91aa..0000000000 --- a/xen/arch/x86/include/asm/hvm/svm/svmdebug.h +++ /dev/null @@ -1,30 +0,0 @@ -/* - * svmdebug.h: SVM related debug defintions - * Copyright (c) 2011, AMD Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - * - */ - -#ifndef __ASM_X86_HVM_SVM_SVMDEBUG_H__ -#define __ASM_X86_HVM_SVM_SVMDEBUG_H__ - -#include -#include - -void svm_sync_vmcb(struct vcpu *v, enum vmcb_sync_state new_state); -void svm_vmcb_dump(const char *from, const struct vmcb_struct *vmcb); -bool svm_vmcb_isvalid(const char *from, const struct vmcb_struct *vmcb, - const struct vcpu *v, bool verbose); - -#endif /* __ASM_X86_HVM_SVM_SVMDEBUG_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501420.773215 (Exim 4.92) (envelope-from ) id 1pVd9K-0003ZD-OI; Fri, 24 Feb 2023 18:50:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501420.773215; Fri, 24 Feb 2023 18:50:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9K-0003Xm-HH; Fri, 24 Feb 2023 18:50:30 +0000 Received: by outflank-mailman (input) for mailman id 501420; Fri, 24 Feb 2023 18:50:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9I-0002YL-Rp for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:29 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 198ecfb8-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:25 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id f13so1041114edz.6 for ; Fri, 24 Feb 2023 10:50:25 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 198ecfb8-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EViI3mZmnE5vT4lmNn/pIOedAgt2T4pJJfLbz7KKHMo=; b=kTHblB7ucI2CyZWjb1GzA0Tc9ytEQv8Vo3dyf1sCwS1Dh/e0Xy8hNRSHh/HufOx5hs TaZ/e18Z3xAyPQjMVOpfUU1KiiZ88wAETCwO17W0w9lZcWiNxKKHojV2tj9ZzKn8cqUe Oz2IyMml+KPWd5/s3xF5uHkO6F3bNTT/uatpYgI98oyl1xAgXTYZnPsSasQXCKS7jwJm bt5mru8porhWHKLU/8UTlxFilonM4LXDRQdzvCxT2A5SCTorCpAiBcZgUs03bi+3yryW x1h3dSb1woeP2NYlixVvfaKrJmrNGpXRHMG5ZYBQU+2CqUeMOICAk4ywwjgn8CfSfqyR RAQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EViI3mZmnE5vT4lmNn/pIOedAgt2T4pJJfLbz7KKHMo=; b=2rGXFb0Xi2MBwPBI7LGNUneW07GW07LdAJip4L6ua+0jrK30sbGwBvPuG40tTMdIIG JxSvz47Rgnw+qiMoYdzVFH2Ky5A7HEE+OQapp+sHW+XTF3GxgcRalb9+P8zMQFpoRAXQ T1dKpo6tiOXVF8G2MWq8rityowJPNn5/cdyXC60Nw8jvbnTDZwwulwDV/bTtc65EJsu5 tvExTUdc04ChYIfmRgSS1pQ2k8IRpFJfB1vLpQiLFvaNU5ueJt8HyyrJ+cJvAxbm6CnO S5o450IpjyBuQ8yN3je68I90WN1Wl8OLbafKZZ9uPT6Q6sw4BAp6cCu71/C2l+FbSpAB ackQ== X-Gm-Message-State: AO0yUKWUXJAZM8HUy4MTo/Q9sIcZB9UhInon64W3qWqIA/WXnfXIli5O Oly5R6/eEsn1XKpJxLo5oToAlBV1iC0= X-Google-Smtp-Source: AK7set+So/D8uX1KCY0RLyTCuRSm0p/kvV1tJdqRARDace7QLP5u/Xhz3dD0SEuyui+50P0s/GCEyA== X-Received: by 2002:a17:906:16c5:b0:870:94e:13f9 with SMTP id t5-20020a17090616c500b00870094e13f9mr23075921ejd.0.1677264624886; Fri, 24 Feb 2023 10:50:24 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 06/14] x86/svm: move vmcb declarations used only by svm code to private header Date: Fri, 24 Feb 2023 20:50:02 +0200 Message-Id: <20230224185010.3692754-7-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/svm called vmcb.h and move there all definitions and declarations that are used only by svm code and don't need to reside in an external header. Take the opportunity to replace u* with uint*_t and remove redundant blank lines. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/svm/asid.c | 1 + xen/arch/x86/hvm/svm/emulate.c | 1 + xen/arch/x86/hvm/svm/intr.c | 1 + xen/arch/x86/hvm/svm/nestedsvm.c | 1 + xen/arch/x86/hvm/svm/svm.c | 1 + xen/arch/x86/hvm/svm/svmdebug.c | 2 + xen/arch/x86/hvm/svm/vmcb.c | 2 + xen/arch/x86/hvm/svm/vmcb.h | 591 ++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 575 +---------------------- 9 files changed, 604 insertions(+), 571 deletions(-) create mode 100644 xen/arch/x86/hvm/svm/vmcb.h diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index 1128434878..05ba2df9d5 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -20,6 +20,7 @@ #include #include "asid.h" +#include "vmcb.h" void svm_asid_init(const struct cpuinfo_x86 *c) { diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 4a84b4e761..573d005127 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -26,6 +26,7 @@ #include #include "emulate.h" +#include "vmcb.h" static unsigned long svm_nextrip_insn_length(struct vcpu *v) { diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index dbb0022190..2655c5b4c8 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -38,6 +38,7 @@ #include #include "nestedhvm.h" +#include "vmcb.h" static void svm_inject_nmi(struct vcpu *v) { diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 80b72b5dee..efbd9bbb77 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -28,6 +28,7 @@ #include "emulate.h" #include "nestedhvm.h" #include "svm.h" +#include "vmcb.h" #define NSVM_ERROR_VVMCB 1 #define NSVM_ERROR_VMENTRY 2 diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 4b74ee3d7c..86b1bf3242 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -56,6 +56,7 @@ #include "emulate.h" #include "nestedhvm.h" #include "svm.h" +#include "vmcb.h" void noreturn svm_asm_do_resume(void); diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index bce86f0ef7..ade74dfd8f 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -21,6 +21,8 @@ #include #include +#include "vmcb.h" + static void svm_dump_sel(const char *name, const struct segment_register *s) { printk("%s: %04x %04x %08x %016"PRIx64"\n", diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index ba93375e87..1d512fedb0 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -30,6 +30,8 @@ #include #include +#include "vmcb.h" + struct vmcb_struct *alloc_vmcb(void) { struct vmcb_struct *vmcb; diff --git a/xen/arch/x86/hvm/svm/vmcb.h b/xen/arch/x86/hvm/svm/vmcb.h new file mode 100644 index 0000000000..c58625fd80 --- /dev/null +++ b/xen/arch/x86/hvm/svm/vmcb.h @@ -0,0 +1,591 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * vmcb.h: VMCB related definitions + * + * Copyright (c) 2005-2007, Advanced Micro Devices, Inc + * Copyright (c) 2004, Intel Corporation. + */ + +#ifndef __X86_HVM_SVM_VMCB_PRIV_H__ +#define __X86_HVM_SVM_VMCB_PRIV_H__ + +#include + +#include + +/* general 1 intercepts */ +enum GenericIntercept1bits +{ + GENERAL1_INTERCEPT_INTR = 1 << 0, + GENERAL1_INTERCEPT_NMI = 1 << 1, + GENERAL1_INTERCEPT_SMI = 1 << 2, + GENERAL1_INTERCEPT_INIT = 1 << 3, + GENERAL1_INTERCEPT_VINTR = 1 << 4, + GENERAL1_INTERCEPT_CR0_SEL_WRITE = 1 << 5, + GENERAL1_INTERCEPT_IDTR_READ = 1 << 6, + GENERAL1_INTERCEPT_GDTR_READ = 1 << 7, + GENERAL1_INTERCEPT_LDTR_READ = 1 << 8, + GENERAL1_INTERCEPT_TR_READ = 1 << 9, + GENERAL1_INTERCEPT_IDTR_WRITE = 1 << 10, + GENERAL1_INTERCEPT_GDTR_WRITE = 1 << 11, + GENERAL1_INTERCEPT_LDTR_WRITE = 1 << 12, + GENERAL1_INTERCEPT_TR_WRITE = 1 << 13, + GENERAL1_INTERCEPT_RDTSC = 1 << 14, + GENERAL1_INTERCEPT_RDPMC = 1 << 15, + GENERAL1_INTERCEPT_PUSHF = 1 << 16, + GENERAL1_INTERCEPT_POPF = 1 << 17, + GENERAL1_INTERCEPT_CPUID = 1 << 18, + GENERAL1_INTERCEPT_RSM = 1 << 19, + GENERAL1_INTERCEPT_IRET = 1 << 20, + GENERAL1_INTERCEPT_SWINT = 1 << 21, + GENERAL1_INTERCEPT_INVD = 1 << 22, + GENERAL1_INTERCEPT_PAUSE = 1 << 23, + GENERAL1_INTERCEPT_HLT = 1 << 24, + GENERAL1_INTERCEPT_INVLPG = 1 << 25, + GENERAL1_INTERCEPT_INVLPGA = 1 << 26, + GENERAL1_INTERCEPT_IOIO_PROT = 1 << 27, + GENERAL1_INTERCEPT_MSR_PROT = 1 << 28, + GENERAL1_INTERCEPT_TASK_SWITCH = 1 << 29, + GENERAL1_INTERCEPT_FERR_FREEZE = 1 << 30, + GENERAL1_INTERCEPT_SHUTDOWN_EVT = 1u << 31 +}; + +/* general 2 intercepts */ +enum GenericIntercept2bits +{ + GENERAL2_INTERCEPT_VMRUN = 1 << 0, + GENERAL2_INTERCEPT_VMMCALL = 1 << 1, + GENERAL2_INTERCEPT_VMLOAD = 1 << 2, + GENERAL2_INTERCEPT_VMSAVE = 1 << 3, + GENERAL2_INTERCEPT_STGI = 1 << 4, + GENERAL2_INTERCEPT_CLGI = 1 << 5, + GENERAL2_INTERCEPT_SKINIT = 1 << 6, + GENERAL2_INTERCEPT_RDTSCP = 1 << 7, + GENERAL2_INTERCEPT_ICEBP = 1 << 8, + GENERAL2_INTERCEPT_WBINVD = 1 << 9, + GENERAL2_INTERCEPT_MONITOR = 1 << 10, + GENERAL2_INTERCEPT_MWAIT = 1 << 11, + GENERAL2_INTERCEPT_MWAIT_CONDITIONAL = 1 << 12, + GENERAL2_INTERCEPT_XSETBV = 1 << 13, + GENERAL2_INTERCEPT_RDPRU = 1 << 14, +}; + +/* control register intercepts */ +enum CRInterceptBits +{ + CR_INTERCEPT_CR0_READ = 1 << 0, + CR_INTERCEPT_CR1_READ = 1 << 1, + CR_INTERCEPT_CR2_READ = 1 << 2, + CR_INTERCEPT_CR3_READ = 1 << 3, + CR_INTERCEPT_CR4_READ = 1 << 4, + CR_INTERCEPT_CR5_READ = 1 << 5, + CR_INTERCEPT_CR6_READ = 1 << 6, + CR_INTERCEPT_CR7_READ = 1 << 7, + CR_INTERCEPT_CR8_READ = 1 << 8, + CR_INTERCEPT_CR9_READ = 1 << 9, + CR_INTERCEPT_CR10_READ = 1 << 10, + CR_INTERCEPT_CR11_READ = 1 << 11, + CR_INTERCEPT_CR12_READ = 1 << 12, + CR_INTERCEPT_CR13_READ = 1 << 13, + CR_INTERCEPT_CR14_READ = 1 << 14, + CR_INTERCEPT_CR15_READ = 1 << 15, + CR_INTERCEPT_CR0_WRITE = 1 << 16, + CR_INTERCEPT_CR1_WRITE = 1 << 17, + CR_INTERCEPT_CR2_WRITE = 1 << 18, + CR_INTERCEPT_CR3_WRITE = 1 << 19, + CR_INTERCEPT_CR4_WRITE = 1 << 20, + CR_INTERCEPT_CR5_WRITE = 1 << 21, + CR_INTERCEPT_CR6_WRITE = 1 << 22, + CR_INTERCEPT_CR7_WRITE = 1 << 23, + CR_INTERCEPT_CR8_WRITE = 1 << 24, + CR_INTERCEPT_CR9_WRITE = 1 << 25, + CR_INTERCEPT_CR10_WRITE = 1 << 26, + CR_INTERCEPT_CR11_WRITE = 1 << 27, + CR_INTERCEPT_CR12_WRITE = 1 << 28, + CR_INTERCEPT_CR13_WRITE = 1 << 29, + CR_INTERCEPT_CR14_WRITE = 1 << 30, + CR_INTERCEPT_CR15_WRITE = 1u << 31, +}; + +/* debug register intercepts */ +enum DRInterceptBits +{ + DR_INTERCEPT_DR0_READ = 1 << 0, + DR_INTERCEPT_DR1_READ = 1 << 1, + DR_INTERCEPT_DR2_READ = 1 << 2, + DR_INTERCEPT_DR3_READ = 1 << 3, + DR_INTERCEPT_DR4_READ = 1 << 4, + DR_INTERCEPT_DR5_READ = 1 << 5, + DR_INTERCEPT_DR6_READ = 1 << 6, + DR_INTERCEPT_DR7_READ = 1 << 7, + DR_INTERCEPT_DR8_READ = 1 << 8, + DR_INTERCEPT_DR9_READ = 1 << 9, + DR_INTERCEPT_DR10_READ = 1 << 10, + DR_INTERCEPT_DR11_READ = 1 << 11, + DR_INTERCEPT_DR12_READ = 1 << 12, + DR_INTERCEPT_DR13_READ = 1 << 13, + DR_INTERCEPT_DR14_READ = 1 << 14, + DR_INTERCEPT_DR15_READ = 1 << 15, + DR_INTERCEPT_DR0_WRITE = 1 << 16, + DR_INTERCEPT_DR1_WRITE = 1 << 17, + DR_INTERCEPT_DR2_WRITE = 1 << 18, + DR_INTERCEPT_DR3_WRITE = 1 << 19, + DR_INTERCEPT_DR4_WRITE = 1 << 20, + DR_INTERCEPT_DR5_WRITE = 1 << 21, + DR_INTERCEPT_DR6_WRITE = 1 << 22, + DR_INTERCEPT_DR7_WRITE = 1 << 23, + DR_INTERCEPT_DR8_WRITE = 1 << 24, + DR_INTERCEPT_DR9_WRITE = 1 << 25, + DR_INTERCEPT_DR10_WRITE = 1 << 26, + DR_INTERCEPT_DR11_WRITE = 1 << 27, + DR_INTERCEPT_DR12_WRITE = 1 << 28, + DR_INTERCEPT_DR13_WRITE = 1 << 29, + DR_INTERCEPT_DR14_WRITE = 1 << 30, + DR_INTERCEPT_DR15_WRITE = 1u << 31, +}; + +enum VMEXIT_EXITCODE +{ + /* control register read exitcodes */ + VMEXIT_CR0_READ = 0, /* 0x0 */ + VMEXIT_CR1_READ = 1, /* 0x1 */ + VMEXIT_CR2_READ = 2, /* 0x2 */ + VMEXIT_CR3_READ = 3, /* 0x3 */ + VMEXIT_CR4_READ = 4, /* 0x4 */ + VMEXIT_CR5_READ = 5, /* 0x5 */ + VMEXIT_CR6_READ = 6, /* 0x6 */ + VMEXIT_CR7_READ = 7, /* 0x7 */ + VMEXIT_CR8_READ = 8, /* 0x8 */ + VMEXIT_CR9_READ = 9, /* 0x9 */ + VMEXIT_CR10_READ = 10, /* 0xa */ + VMEXIT_CR11_READ = 11, /* 0xb */ + VMEXIT_CR12_READ = 12, /* 0xc */ + VMEXIT_CR13_READ = 13, /* 0xd */ + VMEXIT_CR14_READ = 14, /* 0xe */ + VMEXIT_CR15_READ = 15, /* 0xf */ + + /* control register write exitcodes */ + VMEXIT_CR0_WRITE = 16, /* 0x10 */ + VMEXIT_CR1_WRITE = 17, /* 0x11 */ + VMEXIT_CR2_WRITE = 18, /* 0x12 */ + VMEXIT_CR3_WRITE = 19, /* 0x13 */ + VMEXIT_CR4_WRITE = 20, /* 0x14 */ + VMEXIT_CR5_WRITE = 21, /* 0x15 */ + VMEXIT_CR6_WRITE = 22, /* 0x16 */ + VMEXIT_CR7_WRITE = 23, /* 0x17 */ + VMEXIT_CR8_WRITE = 24, /* 0x18 */ + VMEXIT_CR9_WRITE = 25, /* 0x19 */ + VMEXIT_CR10_WRITE = 26, /* 0x1a */ + VMEXIT_CR11_WRITE = 27, /* 0x1b */ + VMEXIT_CR12_WRITE = 28, /* 0x1c */ + VMEXIT_CR13_WRITE = 29, /* 0x1d */ + VMEXIT_CR14_WRITE = 30, /* 0x1e */ + VMEXIT_CR15_WRITE = 31, /* 0x1f */ + + /* debug register read exitcodes */ + VMEXIT_DR0_READ = 32, /* 0x20 */ + VMEXIT_DR1_READ = 33, /* 0x21 */ + VMEXIT_DR2_READ = 34, /* 0x22 */ + VMEXIT_DR3_READ = 35, /* 0x23 */ + VMEXIT_DR4_READ = 36, /* 0x24 */ + VMEXIT_DR5_READ = 37, /* 0x25 */ + VMEXIT_DR6_READ = 38, /* 0x26 */ + VMEXIT_DR7_READ = 39, /* 0x27 */ + VMEXIT_DR8_READ = 40, /* 0x28 */ + VMEXIT_DR9_READ = 41, /* 0x29 */ + VMEXIT_DR10_READ = 42, /* 0x2a */ + VMEXIT_DR11_READ = 43, /* 0x2b */ + VMEXIT_DR12_READ = 44, /* 0x2c */ + VMEXIT_DR13_READ = 45, /* 0x2d */ + VMEXIT_DR14_READ = 46, /* 0x2e */ + VMEXIT_DR15_READ = 47, /* 0x2f */ + + /* debug register write exitcodes */ + VMEXIT_DR0_WRITE = 48, /* 0x30 */ + VMEXIT_DR1_WRITE = 49, /* 0x31 */ + VMEXIT_DR2_WRITE = 50, /* 0x32 */ + VMEXIT_DR3_WRITE = 51, /* 0x33 */ + VMEXIT_DR4_WRITE = 52, /* 0x34 */ + VMEXIT_DR5_WRITE = 53, /* 0x35 */ + VMEXIT_DR6_WRITE = 54, /* 0x36 */ + VMEXIT_DR7_WRITE = 55, /* 0x37 */ + VMEXIT_DR8_WRITE = 56, /* 0x38 */ + VMEXIT_DR9_WRITE = 57, /* 0x39 */ + VMEXIT_DR10_WRITE = 58, /* 0x3a */ + VMEXIT_DR11_WRITE = 59, /* 0x3b */ + VMEXIT_DR12_WRITE = 60, /* 0x3c */ + VMEXIT_DR13_WRITE = 61, /* 0x3d */ + VMEXIT_DR14_WRITE = 62, /* 0x3e */ + VMEXIT_DR15_WRITE = 63, /* 0x3f */ + + /* processor exception exitcodes (VMEXIT_EXCP[0-31]) */ + VMEXIT_EXCEPTION_DE = 64, /* 0x40, divide-by-zero-error */ + VMEXIT_EXCEPTION_DB = 65, /* 0x41, debug */ + VMEXIT_EXCEPTION_NMI = 66, /* 0x42, non-maskable-interrupt */ + VMEXIT_EXCEPTION_BP = 67, /* 0x43, breakpoint */ + VMEXIT_EXCEPTION_OF = 68, /* 0x44, overflow */ + VMEXIT_EXCEPTION_BR = 69, /* 0x45, bound-range */ + VMEXIT_EXCEPTION_UD = 70, /* 0x46, invalid-opcode*/ + VMEXIT_EXCEPTION_NM = 71, /* 0x47, device-not-available */ + VMEXIT_EXCEPTION_DF = 72, /* 0x48, double-fault */ + VMEXIT_EXCEPTION_09 = 73, /* 0x49, unsupported (reserved) */ + VMEXIT_EXCEPTION_TS = 74, /* 0x4a, invalid-tss */ + VMEXIT_EXCEPTION_NP = 75, /* 0x4b, segment-not-present */ + VMEXIT_EXCEPTION_SS = 76, /* 0x4c, stack */ + VMEXIT_EXCEPTION_GP = 77, /* 0x4d, general-protection */ + VMEXIT_EXCEPTION_PF = 78, /* 0x4e, page-fault */ + VMEXIT_EXCEPTION_15 = 79, /* 0x4f, reserved */ + VMEXIT_EXCEPTION_MF = 80, /* 0x50, x87 floating-point exception-pending */ + VMEXIT_EXCEPTION_AC = 81, /* 0x51, alignment-check */ + VMEXIT_EXCEPTION_MC = 82, /* 0x52, machine-check */ + VMEXIT_EXCEPTION_XF = 83, /* 0x53, simd floating-point */ +/* VMEXIT_EXCEPTION_20 = 84, 0x54, #VE (Intel specific) */ + VMEXIT_EXCEPTION_CP = 85, /* 0x55, controlflow protection */ + + /* exceptions 20-31 (exitcodes 84-95) are reserved */ + + /* ...and the rest of the #VMEXITs */ + VMEXIT_INTR = 96, /* 0x60 */ + VMEXIT_NMI = 97, /* 0x61 */ + VMEXIT_SMI = 98, /* 0x62 */ + VMEXIT_INIT = 99, /* 0x63 */ + VMEXIT_VINTR = 100, /* 0x64 */ + VMEXIT_CR0_SEL_WRITE = 101, /* 0x65 */ + VMEXIT_IDTR_READ = 102, /* 0x66 */ + VMEXIT_GDTR_READ = 103, /* 0x67 */ + VMEXIT_LDTR_READ = 104, /* 0x68 */ + VMEXIT_TR_READ = 105, /* 0x69 */ + VMEXIT_IDTR_WRITE = 106, /* 0x6a */ + VMEXIT_GDTR_WRITE = 107, /* 0x6b */ + VMEXIT_LDTR_WRITE = 108, /* 0x6c */ + VMEXIT_TR_WRITE = 109, /* 0x6d */ + VMEXIT_RDTSC = 110, /* 0x6e */ + VMEXIT_RDPMC = 111, /* 0x6f */ + VMEXIT_PUSHF = 112, /* 0x70 */ + VMEXIT_POPF = 113, /* 0x71 */ + VMEXIT_CPUID = 114, /* 0x72 */ + VMEXIT_RSM = 115, /* 0x73 */ + VMEXIT_IRET = 116, /* 0x74 */ + VMEXIT_SWINT = 117, /* 0x75 */ + VMEXIT_INVD = 118, /* 0x76 */ + VMEXIT_PAUSE = 119, /* 0x77 */ + VMEXIT_HLT = 120, /* 0x78 */ + VMEXIT_INVLPG = 121, /* 0x79 */ + VMEXIT_INVLPGA = 122, /* 0x7a */ + VMEXIT_IOIO = 123, /* 0x7b */ + VMEXIT_MSR = 124, /* 0x7c */ + VMEXIT_TASK_SWITCH = 125, /* 0x7d */ + VMEXIT_FERR_FREEZE = 126, /* 0x7e */ + VMEXIT_SHUTDOWN = 127, /* 0x7f */ + VMEXIT_VMRUN = 128, /* 0x80 */ + VMEXIT_VMMCALL = 129, /* 0x81 */ + VMEXIT_VMLOAD = 130, /* 0x82 */ + VMEXIT_VMSAVE = 131, /* 0x83 */ + VMEXIT_STGI = 132, /* 0x84 */ + VMEXIT_CLGI = 133, /* 0x85 */ + VMEXIT_SKINIT = 134, /* 0x86 */ + VMEXIT_RDTSCP = 135, /* 0x87 */ + VMEXIT_ICEBP = 136, /* 0x88 */ + VMEXIT_WBINVD = 137, /* 0x89 */ + VMEXIT_MONITOR = 138, /* 0x8a */ + VMEXIT_MWAIT = 139, /* 0x8b */ + VMEXIT_MWAIT_CONDITIONAL= 140, /* 0x8c */ + VMEXIT_XSETBV = 141, /* 0x8d */ + VMEXIT_RDPRU = 142, /* 0x8e */ + /* Remember to also update VMEXIT_NPF_PERFC! */ + VMEXIT_NPF = 1024, /* 0x400, nested paging fault */ + /* Remember to also update SVM_PERF_EXIT_REASON_SIZE! */ + VMEXIT_INVALID = -1 +}; + +enum +{ + /* Available on all SVM-capable hardware. */ + TLB_CTRL_NO_FLUSH = 0, + TLB_CTRL_FLUSH_ALL = 1, + + /* Available with the FlushByASID feature. */ + TLB_CTRL_FLUSH_ASID = 3, + TLB_CTRL_FLUSH_ASID_NONGLOBAL = 7, +}; + +typedef union +{ + struct + { + uint8_t vector; + uint8_t type:3; + bool ev:1; + uint32_t resvd1:19; + bool v:1; + uint32_t ec; + }; + uint64_t raw; +} intinfo_t; + +typedef union { + struct { + bool intr_shadow: 1; + bool guest_intr_mask:1; + }; + uint64_t raw; +} intstat_t; + +typedef union +{ + uint64_t bytes; + struct + { + uint64_t tpr: 8; + uint64_t irq: 1; + uint64_t vgif: 1; + uint64_t rsvd0: 6; + uint64_t prio: 4; + uint64_t ign_tpr: 1; + uint64_t rsvd1: 3; + uint64_t intr_masking: 1; + uint64_t vgif_enable: 1; + uint64_t rsvd2: 6; + uint64_t vector: 8; + uint64_t rsvd3: 24; + } fields; +} vintr_t; + +typedef union +{ + uint64_t bytes; + struct + { + uint64_t type: 1; + uint64_t rsv0: 1; + uint64_t str: 1; + uint64_t rep: 1; + uint64_t sz8: 1; + uint64_t sz16: 1; + uint64_t sz32: 1; + uint64_t rsv1: 9; + uint64_t port: 16; + } fields; +} ioio_info_t; + +typedef union +{ + struct { + bool intercepts:1; /* 0: cr/dr/exception/general intercepts, + * pause_filter_count, tsc_offset */ + bool iopm:1; /* 1: iopm_base_pa, msrpm_base_pa */ + bool asid:1; /* 2: guest_asid */ + bool tpr:1; /* 3: vintr */ + bool np:1; /* 4: np_enable, h_cr3, g_pat */ + bool cr:1; /* 5: cr0, cr3, cr4, efer */ + bool dr:1; /* 6: dr6, dr7 */ + bool dt:1; /* 7: gdtr, idtr */ + bool seg:1; /* 8: cs, ds, es, ss, cpl */ + bool cr2:1; /* 9: cr2 */ + bool lbr:1; /* 10: debugctlmsr, last{branch,int}{to,from}ip */ + bool :1; + bool cet:1; /* 12: msr_s_set, ssp, msr_isst */ + }; + uint32_t raw; +} vmcbcleanbits_t; + +#define IOPM_SIZE (12 * 1024) +#define MSRPM_SIZE (8 * 1024) + +struct vmcb_struct { + uint32_t _cr_intercepts; /* offset 0x00 - cleanbit 0 */ + uint32_t _dr_intercepts; /* offset 0x04 - cleanbit 0 */ + uint32_t _exception_intercepts; /* offset 0x08 - cleanbit 0 */ + uint32_t _general1_intercepts; /* offset 0x0C - cleanbit 0 */ + uint32_t _general2_intercepts; /* offset 0x10 - cleanbit 0 */ + uint32_t res01[10]; + uint16_t _pause_filter_thresh; /* offset 0x3C - cleanbit 0 */ + uint16_t _pause_filter_count; /* offset 0x3E - cleanbit 0 */ + uint64_t _iopm_base_pa; /* offset 0x40 - cleanbit 1 */ + uint64_t _msrpm_base_pa; /* offset 0x48 - cleanbit 1 */ + uint64_t _tsc_offset; /* offset 0x50 - cleanbit 0 */ + uint32_t _guest_asid; /* offset 0x58 - cleanbit 2 */ + uint8_t tlb_control; /* offset 0x5C - TLB_CTRL_* */ + uint8_t res07[3]; + vintr_t _vintr; /* offset 0x60 - cleanbit 3 */ + intstat_t int_stat; /* offset 0x68 */ + uint64_t exitcode; /* offset 0x70 */ + union { + struct { + uint64_t exitinfo1; /* offset 0x78 */ + uint64_t exitinfo2; /* offset 0x80 */ + }; + union { + struct { + uint16_t sel; + uint64_t :48; + + uint32_t ec; + uint32_t :4; + bool iret:1; + uint32_t :1; + bool jmp:1; + uint32_t :5; + bool ev:1; + uint32_t :3; + bool rf:1; + } task_switch; + } ei; + }; + intinfo_t exit_int_info; /* offset 0x88 */ + union { /* offset 0x90 - cleanbit 4 */ + struct { + bool _np_enable :1; + bool _sev_enable :1; + bool _sev_es_enable :1; + bool _gmet :1; + bool _np_sss :1; + bool _vte :1; + }; + uint64_t _np_ctrl; + }; + uint64_t res08[2]; + intinfo_t event_inj; /* offset 0xA8 */ + uint64_t _h_cr3; /* offset 0xB0 - cleanbit 4 */ + virt_ext_t virt_ext; /* offset 0xB8 */ + vmcbcleanbits_t cleanbits; /* offset 0xC0 */ + uint32_t res09; /* offset 0xC4 */ + uint64_t nextrip; /* offset 0xC8 */ + uint8_t guest_ins_len; /* offset 0xD0 */ + uint8_t guest_ins[15]; /* offset 0xD1 */ + uint64_t res10a[100]; /* offset 0xE0 pad to save area */ + + union { + struct segment_register sreg[6]; + struct { + struct segment_register es; /* offset 0x400 - cleanbit 8 */ + struct segment_register cs; /* cleanbit 8 */ + struct segment_register ss; /* cleanbit 8 */ + struct segment_register ds; /* cleanbit 8 */ + struct segment_register fs; + struct segment_register gs; + }; + }; + struct segment_register gdtr; /* cleanbit 7 */ + struct segment_register ldtr; + struct segment_register idtr; /* cleanbit 7 */ + struct segment_register tr; + uint64_t res10[5]; + uint8_t res11[3]; + uint8_t _cpl; /* cleanbit 8 */ + uint32_t res12; + uint64_t _efer; /* offset 0x400 + 0xD0 - cleanbit 5 */ + uint64_t res13[14]; + uint64_t _cr4; /* offset 0x400 + 0x148 - cleanbit 5 */ + uint64_t _cr3; /* cleanbit 5 */ + uint64_t _cr0; /* cleanbit 5 */ + uint64_t _dr7; /* cleanbit 6 */ + uint64_t _dr6; /* cleanbit 6 */ + uint64_t rflags; + uint64_t rip; + uint64_t res14[11]; + uint64_t rsp; + uint64_t _msr_s_cet; /* offset 0x400 + 0x1E0 - cleanbit 12 */ + uint64_t _ssp; /* offset 0x400 + 0x1E8 | */ + uint64_t _msr_isst; /* offset 0x400 + 0x1F0 v */ + uint64_t rax; + uint64_t star; + uint64_t lstar; + uint64_t cstar; + uint64_t sfmask; + uint64_t kerngsbase; + uint64_t sysenter_cs; + uint64_t sysenter_esp; + uint64_t sysenter_eip; + uint64_t _cr2; /* cleanbit 9 */ + uint64_t res16[4]; + uint64_t _g_pat; /* cleanbit 4 */ + uint64_t _debugctlmsr; /* cleanbit 10 */ + uint64_t _lastbranchfromip; /* cleanbit 10 */ + uint64_t _lastbranchtoip; /* cleanbit 10 */ + uint64_t _lastintfromip; /* cleanbit 10 */ + uint64_t _lastinttoip; /* cleanbit 10 */ + uint64_t res17[9]; + uint64_t spec_ctrl; + uint64_t res18[291]; +}; + +struct vmcb_struct *alloc_vmcb(void); +void free_vmcb(struct vmcb_struct *vmcb); + +int svm_create_vmcb(struct vcpu *v); +void svm_destroy_vmcb(struct vcpu *v); + +void setup_vmcb_dump(void); + +/* + * VMCB accessor functions. + */ + +#define VMCB_ACCESSORS_(name, type, cleanbit) \ +static inline void \ +vmcb_set_ ## name(struct vmcb_struct *vmcb, \ + type value) \ +{ \ + vmcb->_ ## name = value; \ + vmcb->cleanbits.cleanbit = false; \ +} \ +static inline type \ +vmcb_get_ ## name(const struct vmcb_struct *vmcb) \ +{ \ + return vmcb->_ ## name; \ +} + +#define VMCB_ACCESSORS(name, cleanbit) \ + VMCB_ACCESSORS_(name, typeof(alloc_vmcb()->_ ## name), cleanbit) + +VMCB_ACCESSORS(cr_intercepts, intercepts) +VMCB_ACCESSORS(dr_intercepts, intercepts) +VMCB_ACCESSORS(exception_intercepts, intercepts) +VMCB_ACCESSORS(general1_intercepts, intercepts) +VMCB_ACCESSORS(general2_intercepts, intercepts) +VMCB_ACCESSORS(pause_filter_count, intercepts) +VMCB_ACCESSORS(pause_filter_thresh, intercepts) +VMCB_ACCESSORS(tsc_offset, intercepts) +VMCB_ACCESSORS(iopm_base_pa, iopm) +VMCB_ACCESSORS(msrpm_base_pa, iopm) +VMCB_ACCESSORS(guest_asid, asid) +VMCB_ACCESSORS(vintr, tpr) +VMCB_ACCESSORS(np_ctrl, np) +VMCB_ACCESSORS_(np_enable, bool, np) +VMCB_ACCESSORS_(sev_enable, bool, np) +VMCB_ACCESSORS_(sev_es_enable, bool, np) +VMCB_ACCESSORS_(gmet, bool, np) +VMCB_ACCESSORS_(vte, bool, np) +VMCB_ACCESSORS(h_cr3, np) +VMCB_ACCESSORS(g_pat, np) +VMCB_ACCESSORS(cr0, cr) +VMCB_ACCESSORS(cr3, cr) +VMCB_ACCESSORS(cr4, cr) +VMCB_ACCESSORS(efer, cr) +VMCB_ACCESSORS(dr6, dr) +VMCB_ACCESSORS(dr7, dr) +VMCB_ACCESSORS(cpl, seg) +VMCB_ACCESSORS(cr2, cr2) +VMCB_ACCESSORS(debugctlmsr, lbr) +VMCB_ACCESSORS(lastbranchfromip, lbr) +VMCB_ACCESSORS(lastbranchtoip, lbr) +VMCB_ACCESSORS(lastintfromip, lbr) +VMCB_ACCESSORS(lastinttoip, lbr) +VMCB_ACCESSORS(msr_s_cet, cet) +VMCB_ACCESSORS(ssp, cet) +VMCB_ACCESSORS(msr_isst, cet) + +#undef VMCB_ACCESSORS + +#endif /* __X86_HVM_SVM_VMCB_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index e87728fa81..593badc651 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -21,515 +21,16 @@ #include -/* general 1 intercepts */ -enum GenericIntercept1bits -{ - GENERAL1_INTERCEPT_INTR = 1 << 0, - GENERAL1_INTERCEPT_NMI = 1 << 1, - GENERAL1_INTERCEPT_SMI = 1 << 2, - GENERAL1_INTERCEPT_INIT = 1 << 3, - GENERAL1_INTERCEPT_VINTR = 1 << 4, - GENERAL1_INTERCEPT_CR0_SEL_WRITE = 1 << 5, - GENERAL1_INTERCEPT_IDTR_READ = 1 << 6, - GENERAL1_INTERCEPT_GDTR_READ = 1 << 7, - GENERAL1_INTERCEPT_LDTR_READ = 1 << 8, - GENERAL1_INTERCEPT_TR_READ = 1 << 9, - GENERAL1_INTERCEPT_IDTR_WRITE = 1 << 10, - GENERAL1_INTERCEPT_GDTR_WRITE = 1 << 11, - GENERAL1_INTERCEPT_LDTR_WRITE = 1 << 12, - GENERAL1_INTERCEPT_TR_WRITE = 1 << 13, - GENERAL1_INTERCEPT_RDTSC = 1 << 14, - GENERAL1_INTERCEPT_RDPMC = 1 << 15, - GENERAL1_INTERCEPT_PUSHF = 1 << 16, - GENERAL1_INTERCEPT_POPF = 1 << 17, - GENERAL1_INTERCEPT_CPUID = 1 << 18, - GENERAL1_INTERCEPT_RSM = 1 << 19, - GENERAL1_INTERCEPT_IRET = 1 << 20, - GENERAL1_INTERCEPT_SWINT = 1 << 21, - GENERAL1_INTERCEPT_INVD = 1 << 22, - GENERAL1_INTERCEPT_PAUSE = 1 << 23, - GENERAL1_INTERCEPT_HLT = 1 << 24, - GENERAL1_INTERCEPT_INVLPG = 1 << 25, - GENERAL1_INTERCEPT_INVLPGA = 1 << 26, - GENERAL1_INTERCEPT_IOIO_PROT = 1 << 27, - GENERAL1_INTERCEPT_MSR_PROT = 1 << 28, - GENERAL1_INTERCEPT_TASK_SWITCH = 1 << 29, - GENERAL1_INTERCEPT_FERR_FREEZE = 1 << 30, - GENERAL1_INTERCEPT_SHUTDOWN_EVT = 1u << 31 -}; - -/* general 2 intercepts */ -enum GenericIntercept2bits -{ - GENERAL2_INTERCEPT_VMRUN = 1 << 0, - GENERAL2_INTERCEPT_VMMCALL = 1 << 1, - GENERAL2_INTERCEPT_VMLOAD = 1 << 2, - GENERAL2_INTERCEPT_VMSAVE = 1 << 3, - GENERAL2_INTERCEPT_STGI = 1 << 4, - GENERAL2_INTERCEPT_CLGI = 1 << 5, - GENERAL2_INTERCEPT_SKINIT = 1 << 6, - GENERAL2_INTERCEPT_RDTSCP = 1 << 7, - GENERAL2_INTERCEPT_ICEBP = 1 << 8, - GENERAL2_INTERCEPT_WBINVD = 1 << 9, - GENERAL2_INTERCEPT_MONITOR = 1 << 10, - GENERAL2_INTERCEPT_MWAIT = 1 << 11, - GENERAL2_INTERCEPT_MWAIT_CONDITIONAL = 1 << 12, - GENERAL2_INTERCEPT_XSETBV = 1 << 13, - GENERAL2_INTERCEPT_RDPRU = 1 << 14, -}; - - -/* control register intercepts */ -enum CRInterceptBits -{ - CR_INTERCEPT_CR0_READ = 1 << 0, - CR_INTERCEPT_CR1_READ = 1 << 1, - CR_INTERCEPT_CR2_READ = 1 << 2, - CR_INTERCEPT_CR3_READ = 1 << 3, - CR_INTERCEPT_CR4_READ = 1 << 4, - CR_INTERCEPT_CR5_READ = 1 << 5, - CR_INTERCEPT_CR6_READ = 1 << 6, - CR_INTERCEPT_CR7_READ = 1 << 7, - CR_INTERCEPT_CR8_READ = 1 << 8, - CR_INTERCEPT_CR9_READ = 1 << 9, - CR_INTERCEPT_CR10_READ = 1 << 10, - CR_INTERCEPT_CR11_READ = 1 << 11, - CR_INTERCEPT_CR12_READ = 1 << 12, - CR_INTERCEPT_CR13_READ = 1 << 13, - CR_INTERCEPT_CR14_READ = 1 << 14, - CR_INTERCEPT_CR15_READ = 1 << 15, - CR_INTERCEPT_CR0_WRITE = 1 << 16, - CR_INTERCEPT_CR1_WRITE = 1 << 17, - CR_INTERCEPT_CR2_WRITE = 1 << 18, - CR_INTERCEPT_CR3_WRITE = 1 << 19, - CR_INTERCEPT_CR4_WRITE = 1 << 20, - CR_INTERCEPT_CR5_WRITE = 1 << 21, - CR_INTERCEPT_CR6_WRITE = 1 << 22, - CR_INTERCEPT_CR7_WRITE = 1 << 23, - CR_INTERCEPT_CR8_WRITE = 1 << 24, - CR_INTERCEPT_CR9_WRITE = 1 << 25, - CR_INTERCEPT_CR10_WRITE = 1 << 26, - CR_INTERCEPT_CR11_WRITE = 1 << 27, - CR_INTERCEPT_CR12_WRITE = 1 << 28, - CR_INTERCEPT_CR13_WRITE = 1 << 29, - CR_INTERCEPT_CR14_WRITE = 1 << 30, - CR_INTERCEPT_CR15_WRITE = 1u << 31, -}; - - -/* debug register intercepts */ -enum DRInterceptBits -{ - DR_INTERCEPT_DR0_READ = 1 << 0, - DR_INTERCEPT_DR1_READ = 1 << 1, - DR_INTERCEPT_DR2_READ = 1 << 2, - DR_INTERCEPT_DR3_READ = 1 << 3, - DR_INTERCEPT_DR4_READ = 1 << 4, - DR_INTERCEPT_DR5_READ = 1 << 5, - DR_INTERCEPT_DR6_READ = 1 << 6, - DR_INTERCEPT_DR7_READ = 1 << 7, - DR_INTERCEPT_DR8_READ = 1 << 8, - DR_INTERCEPT_DR9_READ = 1 << 9, - DR_INTERCEPT_DR10_READ = 1 << 10, - DR_INTERCEPT_DR11_READ = 1 << 11, - DR_INTERCEPT_DR12_READ = 1 << 12, - DR_INTERCEPT_DR13_READ = 1 << 13, - DR_INTERCEPT_DR14_READ = 1 << 14, - DR_INTERCEPT_DR15_READ = 1 << 15, - DR_INTERCEPT_DR0_WRITE = 1 << 16, - DR_INTERCEPT_DR1_WRITE = 1 << 17, - DR_INTERCEPT_DR2_WRITE = 1 << 18, - DR_INTERCEPT_DR3_WRITE = 1 << 19, - DR_INTERCEPT_DR4_WRITE = 1 << 20, - DR_INTERCEPT_DR5_WRITE = 1 << 21, - DR_INTERCEPT_DR6_WRITE = 1 << 22, - DR_INTERCEPT_DR7_WRITE = 1 << 23, - DR_INTERCEPT_DR8_WRITE = 1 << 24, - DR_INTERCEPT_DR9_WRITE = 1 << 25, - DR_INTERCEPT_DR10_WRITE = 1 << 26, - DR_INTERCEPT_DR11_WRITE = 1 << 27, - DR_INTERCEPT_DR12_WRITE = 1 << 28, - DR_INTERCEPT_DR13_WRITE = 1 << 29, - DR_INTERCEPT_DR14_WRITE = 1 << 30, - DR_INTERCEPT_DR15_WRITE = 1u << 31, -}; - -enum VMEXIT_EXITCODE -{ - /* control register read exitcodes */ - VMEXIT_CR0_READ = 0, /* 0x0 */ - VMEXIT_CR1_READ = 1, /* 0x1 */ - VMEXIT_CR2_READ = 2, /* 0x2 */ - VMEXIT_CR3_READ = 3, /* 0x3 */ - VMEXIT_CR4_READ = 4, /* 0x4 */ - VMEXIT_CR5_READ = 5, /* 0x5 */ - VMEXIT_CR6_READ = 6, /* 0x6 */ - VMEXIT_CR7_READ = 7, /* 0x7 */ - VMEXIT_CR8_READ = 8, /* 0x8 */ - VMEXIT_CR9_READ = 9, /* 0x9 */ - VMEXIT_CR10_READ = 10, /* 0xa */ - VMEXIT_CR11_READ = 11, /* 0xb */ - VMEXIT_CR12_READ = 12, /* 0xc */ - VMEXIT_CR13_READ = 13, /* 0xd */ - VMEXIT_CR14_READ = 14, /* 0xe */ - VMEXIT_CR15_READ = 15, /* 0xf */ - - /* control register write exitcodes */ - VMEXIT_CR0_WRITE = 16, /* 0x10 */ - VMEXIT_CR1_WRITE = 17, /* 0x11 */ - VMEXIT_CR2_WRITE = 18, /* 0x12 */ - VMEXIT_CR3_WRITE = 19, /* 0x13 */ - VMEXIT_CR4_WRITE = 20, /* 0x14 */ - VMEXIT_CR5_WRITE = 21, /* 0x15 */ - VMEXIT_CR6_WRITE = 22, /* 0x16 */ - VMEXIT_CR7_WRITE = 23, /* 0x17 */ - VMEXIT_CR8_WRITE = 24, /* 0x18 */ - VMEXIT_CR9_WRITE = 25, /* 0x19 */ - VMEXIT_CR10_WRITE = 26, /* 0x1a */ - VMEXIT_CR11_WRITE = 27, /* 0x1b */ - VMEXIT_CR12_WRITE = 28, /* 0x1c */ - VMEXIT_CR13_WRITE = 29, /* 0x1d */ - VMEXIT_CR14_WRITE = 30, /* 0x1e */ - VMEXIT_CR15_WRITE = 31, /* 0x1f */ - - /* debug register read exitcodes */ - VMEXIT_DR0_READ = 32, /* 0x20 */ - VMEXIT_DR1_READ = 33, /* 0x21 */ - VMEXIT_DR2_READ = 34, /* 0x22 */ - VMEXIT_DR3_READ = 35, /* 0x23 */ - VMEXIT_DR4_READ = 36, /* 0x24 */ - VMEXIT_DR5_READ = 37, /* 0x25 */ - VMEXIT_DR6_READ = 38, /* 0x26 */ - VMEXIT_DR7_READ = 39, /* 0x27 */ - VMEXIT_DR8_READ = 40, /* 0x28 */ - VMEXIT_DR9_READ = 41, /* 0x29 */ - VMEXIT_DR10_READ = 42, /* 0x2a */ - VMEXIT_DR11_READ = 43, /* 0x2b */ - VMEXIT_DR12_READ = 44, /* 0x2c */ - VMEXIT_DR13_READ = 45, /* 0x2d */ - VMEXIT_DR14_READ = 46, /* 0x2e */ - VMEXIT_DR15_READ = 47, /* 0x2f */ - - /* debug register write exitcodes */ - VMEXIT_DR0_WRITE = 48, /* 0x30 */ - VMEXIT_DR1_WRITE = 49, /* 0x31 */ - VMEXIT_DR2_WRITE = 50, /* 0x32 */ - VMEXIT_DR3_WRITE = 51, /* 0x33 */ - VMEXIT_DR4_WRITE = 52, /* 0x34 */ - VMEXIT_DR5_WRITE = 53, /* 0x35 */ - VMEXIT_DR6_WRITE = 54, /* 0x36 */ - VMEXIT_DR7_WRITE = 55, /* 0x37 */ - VMEXIT_DR8_WRITE = 56, /* 0x38 */ - VMEXIT_DR9_WRITE = 57, /* 0x39 */ - VMEXIT_DR10_WRITE = 58, /* 0x3a */ - VMEXIT_DR11_WRITE = 59, /* 0x3b */ - VMEXIT_DR12_WRITE = 60, /* 0x3c */ - VMEXIT_DR13_WRITE = 61, /* 0x3d */ - VMEXIT_DR14_WRITE = 62, /* 0x3e */ - VMEXIT_DR15_WRITE = 63, /* 0x3f */ - - /* processor exception exitcodes (VMEXIT_EXCP[0-31]) */ - VMEXIT_EXCEPTION_DE = 64, /* 0x40, divide-by-zero-error */ - VMEXIT_EXCEPTION_DB = 65, /* 0x41, debug */ - VMEXIT_EXCEPTION_NMI = 66, /* 0x42, non-maskable-interrupt */ - VMEXIT_EXCEPTION_BP = 67, /* 0x43, breakpoint */ - VMEXIT_EXCEPTION_OF = 68, /* 0x44, overflow */ - VMEXIT_EXCEPTION_BR = 69, /* 0x45, bound-range */ - VMEXIT_EXCEPTION_UD = 70, /* 0x46, invalid-opcode*/ - VMEXIT_EXCEPTION_NM = 71, /* 0x47, device-not-available */ - VMEXIT_EXCEPTION_DF = 72, /* 0x48, double-fault */ - VMEXIT_EXCEPTION_09 = 73, /* 0x49, unsupported (reserved) */ - VMEXIT_EXCEPTION_TS = 74, /* 0x4a, invalid-tss */ - VMEXIT_EXCEPTION_NP = 75, /* 0x4b, segment-not-present */ - VMEXIT_EXCEPTION_SS = 76, /* 0x4c, stack */ - VMEXIT_EXCEPTION_GP = 77, /* 0x4d, general-protection */ - VMEXIT_EXCEPTION_PF = 78, /* 0x4e, page-fault */ - VMEXIT_EXCEPTION_15 = 79, /* 0x4f, reserved */ - VMEXIT_EXCEPTION_MF = 80, /* 0x50, x87 floating-point exception-pending */ - VMEXIT_EXCEPTION_AC = 81, /* 0x51, alignment-check */ - VMEXIT_EXCEPTION_MC = 82, /* 0x52, machine-check */ - VMEXIT_EXCEPTION_XF = 83, /* 0x53, simd floating-point */ -/* VMEXIT_EXCEPTION_20 = 84, 0x54, #VE (Intel specific) */ - VMEXIT_EXCEPTION_CP = 85, /* 0x55, controlflow protection */ - - /* exceptions 20-31 (exitcodes 84-95) are reserved */ - - /* ...and the rest of the #VMEXITs */ - VMEXIT_INTR = 96, /* 0x60 */ - VMEXIT_NMI = 97, /* 0x61 */ - VMEXIT_SMI = 98, /* 0x62 */ - VMEXIT_INIT = 99, /* 0x63 */ - VMEXIT_VINTR = 100, /* 0x64 */ - VMEXIT_CR0_SEL_WRITE = 101, /* 0x65 */ - VMEXIT_IDTR_READ = 102, /* 0x66 */ - VMEXIT_GDTR_READ = 103, /* 0x67 */ - VMEXIT_LDTR_READ = 104, /* 0x68 */ - VMEXIT_TR_READ = 105, /* 0x69 */ - VMEXIT_IDTR_WRITE = 106, /* 0x6a */ - VMEXIT_GDTR_WRITE = 107, /* 0x6b */ - VMEXIT_LDTR_WRITE = 108, /* 0x6c */ - VMEXIT_TR_WRITE = 109, /* 0x6d */ - VMEXIT_RDTSC = 110, /* 0x6e */ - VMEXIT_RDPMC = 111, /* 0x6f */ - VMEXIT_PUSHF = 112, /* 0x70 */ - VMEXIT_POPF = 113, /* 0x71 */ - VMEXIT_CPUID = 114, /* 0x72 */ - VMEXIT_RSM = 115, /* 0x73 */ - VMEXIT_IRET = 116, /* 0x74 */ - VMEXIT_SWINT = 117, /* 0x75 */ - VMEXIT_INVD = 118, /* 0x76 */ - VMEXIT_PAUSE = 119, /* 0x77 */ - VMEXIT_HLT = 120, /* 0x78 */ - VMEXIT_INVLPG = 121, /* 0x79 */ - VMEXIT_INVLPGA = 122, /* 0x7a */ - VMEXIT_IOIO = 123, /* 0x7b */ - VMEXIT_MSR = 124, /* 0x7c */ - VMEXIT_TASK_SWITCH = 125, /* 0x7d */ - VMEXIT_FERR_FREEZE = 126, /* 0x7e */ - VMEXIT_SHUTDOWN = 127, /* 0x7f */ - VMEXIT_VMRUN = 128, /* 0x80 */ - VMEXIT_VMMCALL = 129, /* 0x81 */ - VMEXIT_VMLOAD = 130, /* 0x82 */ - VMEXIT_VMSAVE = 131, /* 0x83 */ - VMEXIT_STGI = 132, /* 0x84 */ - VMEXIT_CLGI = 133, /* 0x85 */ - VMEXIT_SKINIT = 134, /* 0x86 */ - VMEXIT_RDTSCP = 135, /* 0x87 */ - VMEXIT_ICEBP = 136, /* 0x88 */ - VMEXIT_WBINVD = 137, /* 0x89 */ - VMEXIT_MONITOR = 138, /* 0x8a */ - VMEXIT_MWAIT = 139, /* 0x8b */ - VMEXIT_MWAIT_CONDITIONAL= 140, /* 0x8c */ - VMEXIT_XSETBV = 141, /* 0x8d */ - VMEXIT_RDPRU = 142, /* 0x8e */ - /* Remember to also update VMEXIT_NPF_PERFC! */ - VMEXIT_NPF = 1024, /* 0x400, nested paging fault */ - /* Remember to also update SVM_PERF_EXIT_REASON_SIZE! */ - VMEXIT_INVALID = -1 -}; - -enum -{ - /* Available on all SVM-capable hardware. */ - TLB_CTRL_NO_FLUSH = 0, - TLB_CTRL_FLUSH_ALL = 1, - - /* Available with the FlushByASID feature. */ - TLB_CTRL_FLUSH_ASID = 3, - TLB_CTRL_FLUSH_ASID_NONGLOBAL = 7, -}; - typedef union { + uint64_t bytes; struct { - uint8_t vector; - uint8_t type:3; - bool ev:1; - uint32_t resvd1:19; - bool v:1; - uint32_t ec; - }; - uint64_t raw; -} intinfo_t; - -typedef union { - struct { - bool intr_shadow: 1; - bool guest_intr_mask:1; - }; - uint64_t raw; -} intstat_t; - -typedef union -{ - u64 bytes; - struct - { - u64 tpr: 8; - u64 irq: 1; - u64 vgif: 1; - u64 rsvd0: 6; - u64 prio: 4; - u64 ign_tpr: 1; - u64 rsvd1: 3; - u64 intr_masking: 1; - u64 vgif_enable: 1; - u64 rsvd2: 6; - u64 vector: 8; - u64 rsvd3: 24; - } fields; -} vintr_t; - -typedef union -{ - u64 bytes; - struct - { - u64 type: 1; - u64 rsv0: 1; - u64 str: 1; - u64 rep: 1; - u64 sz8: 1; - u64 sz16: 1; - u64 sz32: 1; - u64 rsv1: 9; - u64 port: 16; - } fields; -} ioio_info_t; - -typedef union -{ - u64 bytes; - struct - { - u64 lbr_enable:1; - u64 vloadsave_enable:1; + uint64_t lbr_enable:1; + uint64_t vloadsave_enable:1; } fields; } virt_ext_t; -typedef union -{ - struct { - bool intercepts:1; /* 0: cr/dr/exception/general intercepts, - * pause_filter_count, tsc_offset */ - bool iopm:1; /* 1: iopm_base_pa, msrpm_base_pa */ - bool asid:1; /* 2: guest_asid */ - bool tpr:1; /* 3: vintr */ - bool np:1; /* 4: np_enable, h_cr3, g_pat */ - bool cr:1; /* 5: cr0, cr3, cr4, efer */ - bool dr:1; /* 6: dr6, dr7 */ - bool dt:1; /* 7: gdtr, idtr */ - bool seg:1; /* 8: cs, ds, es, ss, cpl */ - bool cr2:1; /* 9: cr2 */ - bool lbr:1; /* 10: debugctlmsr, last{branch,int}{to,from}ip */ - bool :1; - bool cet:1; /* 12: msr_s_set, ssp, msr_isst */ - }; - uint32_t raw; -} vmcbcleanbits_t; - -#define IOPM_SIZE (12 * 1024) -#define MSRPM_SIZE (8 * 1024) - -struct vmcb_struct { - u32 _cr_intercepts; /* offset 0x00 - cleanbit 0 */ - u32 _dr_intercepts; /* offset 0x04 - cleanbit 0 */ - u32 _exception_intercepts; /* offset 0x08 - cleanbit 0 */ - u32 _general1_intercepts; /* offset 0x0C - cleanbit 0 */ - u32 _general2_intercepts; /* offset 0x10 - cleanbit 0 */ - u32 res01[10]; - u16 _pause_filter_thresh; /* offset 0x3C - cleanbit 0 */ - u16 _pause_filter_count; /* offset 0x3E - cleanbit 0 */ - u64 _iopm_base_pa; /* offset 0x40 - cleanbit 1 */ - u64 _msrpm_base_pa; /* offset 0x48 - cleanbit 1 */ - u64 _tsc_offset; /* offset 0x50 - cleanbit 0 */ - u32 _guest_asid; /* offset 0x58 - cleanbit 2 */ - u8 tlb_control; /* offset 0x5C - TLB_CTRL_* */ - u8 res07[3]; - vintr_t _vintr; /* offset 0x60 - cleanbit 3 */ - intstat_t int_stat; /* offset 0x68 */ - u64 exitcode; /* offset 0x70 */ - union { - struct { - uint64_t exitinfo1; /* offset 0x78 */ - uint64_t exitinfo2; /* offset 0x80 */ - }; - union { - struct { - uint16_t sel; - uint64_t :48; - - uint32_t ec; - uint32_t :4; - bool iret:1; - uint32_t :1; - bool jmp:1; - uint32_t :5; - bool ev:1; - uint32_t :3; - bool rf:1; - } task_switch; - } ei; - }; - intinfo_t exit_int_info; /* offset 0x88 */ - union { /* offset 0x90 - cleanbit 4 */ - struct { - bool _np_enable :1; - bool _sev_enable :1; - bool _sev_es_enable :1; - bool _gmet :1; - bool _np_sss :1; - bool _vte :1; - }; - uint64_t _np_ctrl; - }; - u64 res08[2]; - intinfo_t event_inj; /* offset 0xA8 */ - u64 _h_cr3; /* offset 0xB0 - cleanbit 4 */ - virt_ext_t virt_ext; /* offset 0xB8 */ - vmcbcleanbits_t cleanbits; /* offset 0xC0 */ - u32 res09; /* offset 0xC4 */ - u64 nextrip; /* offset 0xC8 */ - u8 guest_ins_len; /* offset 0xD0 */ - u8 guest_ins[15]; /* offset 0xD1 */ - u64 res10a[100]; /* offset 0xE0 pad to save area */ - - union { - struct segment_register sreg[6]; - struct { - struct segment_register es; /* offset 0x400 - cleanbit 8 */ - struct segment_register cs; /* cleanbit 8 */ - struct segment_register ss; /* cleanbit 8 */ - struct segment_register ds; /* cleanbit 8 */ - struct segment_register fs; - struct segment_register gs; - }; - }; - struct segment_register gdtr; /* cleanbit 7 */ - struct segment_register ldtr; - struct segment_register idtr; /* cleanbit 7 */ - struct segment_register tr; - u64 res10[5]; - u8 res11[3]; - u8 _cpl; /* cleanbit 8 */ - u32 res12; - u64 _efer; /* offset 0x400 + 0xD0 - cleanbit 5 */ - u64 res13[14]; - u64 _cr4; /* offset 0x400 + 0x148 - cleanbit 5 */ - u64 _cr3; /* cleanbit 5 */ - u64 _cr0; /* cleanbit 5 */ - u64 _dr7; /* cleanbit 6 */ - u64 _dr6; /* cleanbit 6 */ - u64 rflags; - u64 rip; - u64 res14[11]; - u64 rsp; - u64 _msr_s_cet; /* offset 0x400 + 0x1E0 - cleanbit 12 */ - u64 _ssp; /* offset 0x400 + 0x1E8 | */ - u64 _msr_isst; /* offset 0x400 + 0x1F0 v */ - u64 rax; - u64 star; - u64 lstar; - u64 cstar; - u64 sfmask; - u64 kerngsbase; - u64 sysenter_cs; - u64 sysenter_esp; - u64 sysenter_eip; - u64 _cr2; /* cleanbit 9 */ - u64 res16[4]; - u64 _g_pat; /* cleanbit 4 */ - u64 _debugctlmsr; /* cleanbit 10 */ - u64 _lastbranchfromip; /* cleanbit 10 */ - u64 _lastbranchtoip; /* cleanbit 10 */ - u64 _lastintfromip; /* cleanbit 10 */ - u64 _lastinttoip; /* cleanbit 10 */ - u64 res17[9]; - u64 spec_ctrl; - u64 res18[291]; -}; - struct svm_domain { /* OSVW MSRs */ union { @@ -558,7 +59,7 @@ enum vmcb_sync_state { struct svm_vcpu { struct vmcb_struct *vmcb; - u64 vmcb_pa; + uint64_t vmcb_pa; unsigned long *msrpm; int launch_core; @@ -577,14 +78,6 @@ struct svm_vcpu { uint64_t guest_sysenter_eip; }; -struct vmcb_struct *alloc_vmcb(void); -void free_vmcb(struct vmcb_struct *vmcb); - -int svm_create_vmcb(struct vcpu *v); -void svm_destroy_vmcb(struct vcpu *v); - -void setup_vmcb_dump(void); - #define MSR_INTERCEPT_NONE 0 #define MSR_INTERCEPT_READ 1 #define MSR_INTERCEPT_WRITE 2 @@ -593,66 +86,6 @@ void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); #define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) #define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) -/* - * VMCB accessor functions. - */ - -#define VMCB_ACCESSORS_(name, type, cleanbit) \ -static inline void \ -vmcb_set_ ## name(struct vmcb_struct *vmcb, \ - type value) \ -{ \ - vmcb->_ ## name = value; \ - vmcb->cleanbits.cleanbit = false; \ -} \ -static inline type \ -vmcb_get_ ## name(const struct vmcb_struct *vmcb) \ -{ \ - return vmcb->_ ## name; \ -} - -#define VMCB_ACCESSORS(name, cleanbit) \ - VMCB_ACCESSORS_(name, typeof(alloc_vmcb()->_ ## name), cleanbit) - -VMCB_ACCESSORS(cr_intercepts, intercepts) -VMCB_ACCESSORS(dr_intercepts, intercepts) -VMCB_ACCESSORS(exception_intercepts, intercepts) -VMCB_ACCESSORS(general1_intercepts, intercepts) -VMCB_ACCESSORS(general2_intercepts, intercepts) -VMCB_ACCESSORS(pause_filter_count, intercepts) -VMCB_ACCESSORS(pause_filter_thresh, intercepts) -VMCB_ACCESSORS(tsc_offset, intercepts) -VMCB_ACCESSORS(iopm_base_pa, iopm) -VMCB_ACCESSORS(msrpm_base_pa, iopm) -VMCB_ACCESSORS(guest_asid, asid) -VMCB_ACCESSORS(vintr, tpr) -VMCB_ACCESSORS(np_ctrl, np) -VMCB_ACCESSORS_(np_enable, bool, np) -VMCB_ACCESSORS_(sev_enable, bool, np) -VMCB_ACCESSORS_(sev_es_enable, bool, np) -VMCB_ACCESSORS_(gmet, bool, np) -VMCB_ACCESSORS_(vte, bool, np) -VMCB_ACCESSORS(h_cr3, np) -VMCB_ACCESSORS(g_pat, np) -VMCB_ACCESSORS(cr0, cr) -VMCB_ACCESSORS(cr3, cr) -VMCB_ACCESSORS(cr4, cr) -VMCB_ACCESSORS(efer, cr) -VMCB_ACCESSORS(dr6, dr) -VMCB_ACCESSORS(dr7, dr) -VMCB_ACCESSORS(cpl, seg) -VMCB_ACCESSORS(cr2, cr2) -VMCB_ACCESSORS(debugctlmsr, lbr) -VMCB_ACCESSORS(lastbranchfromip, lbr) -VMCB_ACCESSORS(lastbranchtoip, lbr) -VMCB_ACCESSORS(lastintfromip, lbr) -VMCB_ACCESSORS(lastinttoip, lbr) -VMCB_ACCESSORS(msr_s_cet, cet) -VMCB_ACCESSORS(ssp, cet) -VMCB_ACCESSORS(msr_isst, cet) - -#undef VMCB_ACCESSORS - #endif /* ASM_X86_HVM_SVM_VMCS_H__ */ /* -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501419.773210 (Exim 4.92) (envelope-from ) id 1pVd9K-0003UZ-Ag; Fri, 24 Feb 2023 18:50:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501419.773210; Fri, 24 Feb 2023 18:50:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9K-0003TJ-52; Fri, 24 Feb 2023 18:50:30 +0000 Received: by outflank-mailman (input) for mailman id 501419; Fri, 24 Feb 2023 18:50:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9J-0001Wv-3F for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:29 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b5adb9f-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:28 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id o12so974360edb.9 for ; Fri, 24 Feb 2023 10:50:28 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:27 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b5adb9f-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JPYCsGMeBTiPN9pOJ5LMApZIn6k2wD9Q3YWmBtml8QE=; b=Vv5j0WwwWDrjByFvRX4M/pnpcjrev6SIvPMEeM65ox88mEYfJAfV/B9fCU4oZySTwq D7ixLk6mVcJ+bZxqI7PNm5aRuxZl/UBUOgo9wbuENOuUXRMZe0AH6gRhLwsjx5TGptXP IFqiVki0Sh4GrrR3p0xS8pjCPGCHTG3vAHLqQ0KLW4SrU2FBDt9obwxrMaA2NF/rbCxh WzExUc1JgQHJgae/ooyWQl72GyI3EQTnSeKFPTtgYS5rqk6uMZD0yTKOkGHgb0Ape0Pf TL6utOAOWIObULsR4ufbQ1+sxBGlnKBMWqxE7frncjeXWPAqWctzMpWGp6tFi9stWKzQ 6M7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JPYCsGMeBTiPN9pOJ5LMApZIn6k2wD9Q3YWmBtml8QE=; b=FnqoKZdmLgPmKYutv3wXCjrRSi67ARfAj9HIhUq6FCQG+jE97qzIC4yowHEU0Mzc+i tIvDOHH2PBWgz5vOSFizu9qXR+6iEWBz+tOjo1ONyTs2T5l0viY7DJhjYGw82deQn/DD dKiyvqd/JlQPzTNgF2TCqJPGp1ov9sfnzhFqdwPJiO4yhusJx3pD2mb7YwBBGu7JqrAq y7ftGQEyLfgVvn2f/ZmNrNsjN0wKSA0OLTSSy4sTS4n+/OkUPsW3RqrYlvTZOydYYayc +3+K/AMLsRqT+kSWr5dCbYDm0oFLj7eC2CVoWF6FbHRwuXik59xZRscuCQP7ECtF5Blc 2ypA== X-Gm-Message-State: AO0yUKVlWTTS2g9T2BEJ3Cf3EcKbPw7M+cIZjR8Mlr7iTGFdNtE8upk3 /MXSJ5xMmICPlr21p5/Mcd0jg5Ar4Mc= X-Google-Smtp-Source: AK7set+QTjwryCVbsSQr32RjmQeAdXlFIteI8LnZIqM7lH+SpUsxV5Of3ROMxoBTa8a0P9/zRmJB0Q== X-Received: by 2002:a17:907:2c66:b0:8f3:8bfd:a8e with SMTP id ib6-20020a1709072c6600b008f38bfd0a8emr684802ejc.26.1677264628225; Fri, 24 Feb 2023 10:50:28 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 08/14] x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static Date: Fri, 24 Feb 2023 20:50:04 +0200 Message-Id: <20230224185010.3692754-9-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move vmx_update_debug_state() in vmcs.c because it is used only in this file and limit its scope to this file by declaring it static and removing its declaration from vmx.h. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - apply the change before moving the declarations into private headers to avoid churn, suggested by Jan xen/arch/x86/hvm/vmx/vmcs.c | 12 ++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 12 ------------ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 - 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index ed71ecfb62..d3c75b3803 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1868,6 +1868,18 @@ void vmx_vmentry_failure(void) void noreturn vmx_asm_do_vmentry(void); +static void vmx_update_debug_state(struct vcpu *v) +{ + if ( v->arch.hvm.debug_state_latch ) + v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + else + v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + + vmx_vmcs_enter(v); + vmx_update_exception_bitmap(v); + vmx_vmcs_exit(v); +} + void cf_check vmx_do_resume(void) { struct vcpu *v = current; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0ec33bcc18..294c8490b4 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1613,18 +1613,6 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) vmx_vmcs_exit(v); } -void vmx_update_debug_state(struct vcpu *v) -{ - if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; - else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); - - vmx_vmcs_enter(v); - vmx_update_exception_bitmap(v); - vmx_vmcs_exit(v); -} - static void cf_check vmx_update_guest_cr( struct vcpu *v, unsigned int cr, unsigned int flags) { diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index f6308ed656..82a9487b40 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -88,7 +88,6 @@ void cf_check vmx_vlapic_msr_changed(struct vcpu *v); struct hvm_emulate_ctxt; void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt); void vmx_realmode(struct cpu_user_regs *regs); -void vmx_update_debug_state(struct vcpu *v); void vmx_update_exception_bitmap(struct vcpu *v); void vmx_update_cpu_exec_control(struct vcpu *v); void vmx_update_secondary_exec_control(struct vcpu *v); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501426.773239 (Exim 4.92) (envelope-from ) id 1pVd9Q-0004nj-Sz; Fri, 24 Feb 2023 18:50:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501426.773239; Fri, 24 Feb 2023 18:50:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9Q-0004nH-PE; Fri, 24 Feb 2023 18:50:36 +0000 Received: by outflank-mailman (input) for mailman id 501426; Fri, 24 Feb 2023 18:50:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9P-0002YL-0y for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:35 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d965e9e-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:32 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id f13so1042240edz.6 for ; Fri, 24 Feb 2023 10:50:32 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d965e9e-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KDSu3wlyjcEsRo6P/0IC3D8voa/3jwZDyNKKsxwwZnY=; b=I34MONNbi5qYK2570f44lx1ApTgHdxujGWoupBhr5bHWzOuw9H5I/RfH7aG5spHMsk LrgYv/8DUGUNER1CUF2LRQxsA7g9Cz7CMyYsTipqWPlhP162istg1+6DnOT4P8h56AsK DnVa0seSStdrMVrsZIpEj8MSIoNh7APC9EJobdR4t21vtz7m9ePdY2S2TBJErSL1zs5E fpbR0NaUreRBKVE89JUXfpJWla0VuAtvZVdT2ccPY61II1c6EEziEg3THgXm030eztrN N4Xsh10pL+q188KcwUrXN47KLsF6W5G3agzjPS6g2C2LCrEaRfES27HUHvr1M/w7dxbb 1TkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDSu3wlyjcEsRo6P/0IC3D8voa/3jwZDyNKKsxwwZnY=; b=70E5Eb3VcsiD5+hPnOUKpE1Rmx0Dd3b8HtTLFNaTb1XJ+lKPpgoWPH45FYGsX/b4Hz PA4jlN6IFte6j49tndGxNIecwzUsA3M25gASe2u4Fc9LqPaK6vpQJV+h1r12gMZhSPE8 H6pOZqVibkGCkRch9quy6z8ft+8CACodidwDFp1Da4TZ6C1A/6FSP0VfB/VhR8C4stEm yj4NeXd02xrI3lan/jOJZmQrts5zQX6BN2Bdxas1Q0vymcG7uC7yEsmOAbuk7coW8dD0 rQLIZWT7hjif8tOs4st0uZ1QudwT1ywjkB+EsPL7Bi/mtSY01f6VtDhhcN52dSWYC/Ea A5Dw== X-Gm-Message-State: AO0yUKVTlYyXl5BhAEOjdovgXNxTW5e5YQEX1MQ3Ft2rQVlPALjif6Sz jy/7ZqI3MepNzbNhYvaqvv7ZuFO1W2w= X-Google-Smtp-Source: AK7set8lfngmkCbHaWvTISk1kJlO8Ikgo5Rh8KVZh9DbgYoFlyaHxqAG/9jz3l/QKpEW/f7dmooXIQ== X-Received: by 2002:a17:907:2d2c:b0:8e7:916f:193d with SMTP id gs44-20020a1709072d2c00b008e7916f193dmr13453880ejc.28.1677264631616; Fri, 24 Feb 2023 10:50:31 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Date: Fri, 24 Feb 2023 20:50:06 +0200 Message-Id: <20230224185010.3692754-11-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create two new private headers in arch/x86/hvm/vmx called vmx.h and pi.h. Move all the definitions and declarations that are used solely by vmx code into the private vmx.h, apart from the ones related to posted interrupts that are moved into pi.h. EPT related declarations and definitions stay in asm/hvm/vmx/vmx.h because they are used in arch/x86/mm and drivers/passthrough/vtd. Also, __vmread(), used in arch/x86/cpu, and consequently the opcodes stay in asm/hvm/vmx/vmx.h. Take the opportunity during the movement to replace u* with uint*_t, fix minor coding style issues and reduce scope of GAS_VMX_OP definition. Also, rearrange the code in the following way, place all structures first, then all variable decalarations, all function delarations, and finally all inline functions. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - add SPDX identifier, reported by Andrew - add #ifndef header guard, reported by Andrew and Jan - fold patch reducing the scope of GAS_VMX_OP definition into this, suggested by Jan - put pi related declarations in a separate priv header, suggested by Jan - perform minor coding style fixes pointed out by Jan - replace u* with uint*_t, suggested by Jan - rearrange the header in the way Jan's proposed - rebase to the latest staging xen/arch/x86/hvm/vmx/intr.c | 2 + xen/arch/x86/hvm/vmx/pi.h | 78 +++++ xen/arch/x86/hvm/vmx/realmode.c | 2 + xen/arch/x86/hvm/vmx/vmcs.c | 2 + xen/arch/x86/hvm/vmx/vmx.c | 3 + xen/arch/x86/hvm/vmx/vmx.h | 416 +++++++++++++++++++++++ xen/arch/x86/hvm/vmx/vvmx.c | 2 + xen/arch/x86/include/asm/hvm/vmx/vmx.h | 439 ------------------------- 8 files changed, 505 insertions(+), 439 deletions(-) create mode 100644 xen/arch/x86/hvm/vmx/pi.h create mode 100644 xen/arch/x86/hvm/vmx/vmx.h diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 6a8316de0e..c8db501759 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -38,6 +38,8 @@ #include #include +#include "vmx.h" + /* * A few notes on virtual NMI and INTR delivery, and interactions with * interruptibility states: diff --git a/xen/arch/x86/hvm/vmx/pi.h b/xen/arch/x86/hvm/vmx/pi.h new file mode 100644 index 0000000000..c72cc511da --- /dev/null +++ b/xen/arch/x86/hvm/vmx/pi.h @@ -0,0 +1,78 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * pi.h: VMX Posted Interrupts + * + * Copyright (c) 2004, Intel Corporation. + */ + +#ifndef __X86_HVM_VMX_PI_PRIV_H__ +#define __X86_HVM_VMX_PI_PRIV_H__ + +#include + +#include + +#define POSTED_INTR_ON 0 +#define POSTED_INTR_SN 1 + +static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) +{ + return test_and_set_bit(vector, pi_desc->pir); +} + +static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) +{ + return test_bit(vector, pi_desc->pir); +} + +static inline int pi_test_and_set_on(struct pi_desc *pi_desc) +{ + return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline void pi_set_on(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) +{ + return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); +} + +static inline int pi_test_on(struct pi_desc *pi_desc) +{ + return pi_desc->on; +} + +static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) +{ + return xchg(&pi_desc->pir[group], 0); +} + +static inline int pi_test_sn(struct pi_desc *pi_desc) +{ + return pi_desc->sn; +} + +static inline void pi_set_sn(struct pi_desc *pi_desc) +{ + set_bit(POSTED_INTR_SN, &pi_desc->control); +} + +static inline void pi_clear_sn(struct pi_desc *pi_desc) +{ + clear_bit(POSTED_INTR_SN, &pi_desc->control); +} + +#endif /* __X86_HVM_VMX_PI_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c index 4ac93e0810..5591660230 100644 --- a/xen/arch/x86/hvm/vmx/realmode.c +++ b/xen/arch/x86/hvm/vmx/realmode.c @@ -23,6 +23,8 @@ #include #include +#include "vmx.h" + static void realmode_deliver_exception( unsigned int vector, unsigned int insn_len, diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index d3c75b3803..4eb2571abb 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -43,6 +43,8 @@ #include #include +#include "vmx.h" + static bool_t __read_mostly opt_vpid_enabled = 1; boolean_param("vpid", opt_vpid_enabled); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 232107bd79..cb8b133ed5 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -62,6 +62,9 @@ #include #include +#include "pi.h" +#include "vmx.h" + static bool_t __initdata opt_force_ept; boolean_param("force-ept", opt_force_ept); diff --git a/xen/arch/x86/hvm/vmx/vmx.h b/xen/arch/x86/hvm/vmx/vmx.h new file mode 100644 index 0000000000..7f8a00952b --- /dev/null +++ b/xen/arch/x86/hvm/vmx/vmx.h @@ -0,0 +1,416 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * vmx.h: VMX Architecture related definitions + * + * Copyright (c) 2004, Intel Corporation. + */ + +#ifndef __X86_HVM_VMX_VMX_PRIV_H__ +#define __X86_HVM_VMX_VMX_PRIV_H__ + +#include +#include + +#include +#include +#include +#include + +#define PI_xAPIC_NDST_MASK 0xFF00 + +/* + * Interruption-information format + * + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification + * field for EPT violations, PML full and SPP-related event vmexits. + */ +#define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ +#define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ +#define INTR_INFO_DELIVER_CODE_MASK 0x800 /* 11 */ +#define INTR_INFO_NMI_UNBLOCKED_BY_IRET 0x1000 /* 12 */ +#define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ +#define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 + +/* + * Exit Qualifications for NOTIFY VM EXIT + */ +#define NOTIFY_VM_CONTEXT_INVALID 1u + +/* + * Exit Qualifications for MOV for Control Register Access + */ +enum { + VMX_CR_ACCESS_TYPE_MOV_TO_CR, + VMX_CR_ACCESS_TYPE_MOV_FROM_CR, + VMX_CR_ACCESS_TYPE_CLTS, + VMX_CR_ACCESS_TYPE_LMSW, +}; + +typedef union cr_access_qual { + unsigned long raw; + struct { + uint16_t cr:4, + access_type:2, /* VMX_CR_ACCESS_TYPE_* */ + lmsw_op_type:1, /* 0 => reg, 1 => mem */ + :1, + gpr:4, + :4; + uint16_t lmsw_data; + uint32_t :32; + }; +} __transparent__ cr_access_qual_t; + +/* + * Access Rights + */ +#define X86_SEG_AR_SEG_TYPE 0xf /* 3:0, segment type */ +#define X86_SEG_AR_DESC_TYPE (1u << 4) /* 4, descriptor type */ +#define X86_SEG_AR_DPL 0x60 /* 6:5, descriptor privilege level */ +#define X86_SEG_AR_SEG_PRESENT (1u << 7) /* 7, segment present */ +#define X86_SEG_AR_AVL (1u << 12) /* 12, available for system software */ +#define X86_SEG_AR_CS_LM_ACTIVE (1u << 13) /* 13, long mode active (CS only) */ +#define X86_SEG_AR_DEF_OP_SIZE (1u << 14) /* 14, default operation size */ +#define X86_SEG_AR_GRANULARITY (1u << 15) /* 15, granularity */ +#define X86_SEG_AR_SEG_UNUSABLE (1u << 16) /* 16, segment unusable */ + +#define APIC_INVALID_DEST 0xffffffff + +/* #VE information page */ +typedef struct { + uint32_t exit_reason; + uint32_t semaphore; + uint64_t exit_qualification; + uint64_t gla; + uint64_t gpa; + uint16_t eptp_index; +} ve_info_t; + +/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ +typedef union idt_or_gdt_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :5, /* bits 6:2 - Undefined */ + addr_size :3, /* bits 9:7 - Address size */ + :1, /* bit 10 - Cleared to 0 */ + operand_size :1, /* bit 11 - Operand size */ + :3, /* bits 14:12 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 30:63 - Undefined */ + }; +} idt_or_gdt_instr_info_t; + +/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ +typedef union ldt_or_tr_instr_info { + unsigned long raw; + struct { + unsigned long scaling :2, /* bits 0:1 - Scaling */ + :1, /* bit 2 - Undefined */ + reg1 :4, /* bits 6:3 - Reg1 */ + addr_size :3, /* bits 9:7 - Address size */ + mem_reg :1, /* bit 10 - Mem/Reg */ + :4, /* bits 14:11 - Undefined */ + segment_reg :3, /* bits 17:15 - Segment register */ + index_reg :4, /* bits 21:18 - Index register */ + index_reg_invalid :1, /* bit 22 - Index register invalid */ + base_reg :4, /* bits 26:23 - Base register */ + base_reg_invalid :1, /* bit 27 - Base register invalid */ + instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ + instr_write :1, /* bit 29 - 0:store, 1:load */ + :34; /* bits 31:63 - Undefined */ + }; +} ldt_or_tr_instr_info_t; + +extern int8_t opt_ept_exec_sp; + +extern uint8_t posted_intr_vector; + +void vmx_intr_assist(void); +void noreturn cf_check vmx_do_resume(void); +void cf_check vmx_vlapic_msr_changed(struct vcpu *v); +void vmx_realmode(struct cpu_user_regs *regs); +void vmx_update_exception_bitmap(struct vcpu *v); +void vmx_update_cpu_exec_control(struct vcpu *v); +void vmx_update_secondary_exec_control(struct vcpu *v); + +int cf_check vmx_guest_x86_mode(struct vcpu *v); +unsigned int vmx_get_cpl(void); +void vmx_inject_extint(int trap, uint8_t source); +void vmx_inject_nmi(void); + +void update_guest_eip(void); + +void vmx_pi_per_cpu_init(unsigned int cpu); +void vmx_pi_desc_fixup(unsigned int cpu); + +void vmx_sync_exit_bitmap(struct vcpu *v); + +static always_inline void __vmptrld(uint64_t addr) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmptrld %0\n" +#else + VMPTRLD_OPCODE MODRM_EAX_06 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmptrld) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "m" (addr), +#else + : "a" (&addr), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +static always_inline void __vmpclear(uint64_t addr) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmclear %0\n" +#else + VMCLEAR_OPCODE MODRM_EAX_06 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmclear) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "m" (addr), +#else + : "a" (&addr), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +static always_inline void __vmwrite(unsigned long field, unsigned long value) +{ + asm volatile ( +#ifdef HAVE_AS_VMX + "vmwrite %1, %0\n" +#else + VMWRITE_OPCODE MODRM_EAX_ECX +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, vmwrite) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_VMX + : "r" (field) , "rm" (value), +#else + : "a" (field) , "c" (value), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + ); +} + +#ifdef HAVE_AS_VMX +# define GAS_VMX_OP(yes, no) yes +#else +# define GAS_VMX_OP(yes, no) no +#endif + +static inline enum vmx_insn_errno vmread_safe(unsigned long field, + unsigned long *value) +{ + unsigned long ret = VMX_INSN_SUCCEED; + bool fail_invalid, fail_valid; + + asm volatile ( GAS_VMX_OP("vmread %[field], %[value]\n\t", + VMREAD_OPCODE MODRM_EAX_ECX) + ASM_FLAG_OUT(, "setc %[invalid]\n\t") + ASM_FLAG_OUT(, "setz %[valid]\n\t") + : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), + ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid), + [value] GAS_VMX_OP("=rm", "=c") (*value) + : [field] GAS_VMX_OP("r", "a") (field) ); + + if ( unlikely(fail_invalid) ) + ret = VMX_INSN_FAIL_INVALID; + else if ( unlikely(fail_valid) ) + __vmread(VM_INSTRUCTION_ERROR, &ret); + + return ret; +} + +static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, + unsigned long value) +{ + unsigned long ret = VMX_INSN_SUCCEED; + bool fail_invalid, fail_valid; + + asm volatile ( GAS_VMX_OP("vmwrite %[value], %[field]\n\t", + VMWRITE_OPCODE MODRM_EAX_ECX) + ASM_FLAG_OUT(, "setc %[invalid]\n\t") + ASM_FLAG_OUT(, "setz %[valid]\n\t") + : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), + ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid) + : [field] GAS_VMX_OP("r", "a") (field), + [value] GAS_VMX_OP("rm", "c") (value) ); + + if ( unlikely(fail_invalid) ) + ret = VMX_INSN_FAIL_INVALID; + else if ( unlikely(fail_valid) ) + __vmread(VM_INSTRUCTION_ERROR, &ret); + + return ret; +} + +#undef GAS_VMX_OP + +#define INVEPT_SINGLE_CONTEXT 1 +#define INVEPT_ALL_CONTEXT 2 + +static always_inline void __invept(unsigned long type, uint64_t eptp) +{ + struct { + uint64_t eptp, rsvd; + } operand = { eptp }; + + /* + * If single context invalidation is not supported, we escalate to + * use all context invalidation. + */ + if ( (type == INVEPT_SINGLE_CONTEXT) && + !cpu_has_vmx_ept_invept_single_context ) + type = INVEPT_ALL_CONTEXT; + + asm volatile ( +#ifdef HAVE_AS_EPT + "invept %0, %1\n" +#else + INVEPT_OPCODE MODRM_EAX_08 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, invept) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION + : +#ifdef HAVE_AS_EPT + : "m" (operand), "r" (type), +#else + : "a" (&operand), "c" (type), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +#define INVVPID_INDIVIDUAL_ADDR 0 +#define INVVPID_SINGLE_CONTEXT 1 +#define INVVPID_ALL_CONTEXT 2 +#define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 + +static always_inline void __invvpid(unsigned long type, uint16_t vpid, + uint64_t gva) +{ + struct __packed { + uint64_t vpid:16; + uint64_t rsvd:48; + uint64_t gva; + } operand = {vpid, 0, gva}; + + /* Fix up #UD exceptions which occur when TLBs are flushed before VMXON. */ + asm volatile ( "1: " +#ifdef HAVE_AS_EPT + "invvpid %0, %1\n" +#else + INVVPID_OPCODE MODRM_EAX_08 +#endif + /* CF==1 or ZF==1 --> BUG() */ + UNLIKELY_START(be, invvpid) + _ASM_BUGFRAME_TEXT(0) + UNLIKELY_END_SECTION "\n" + "2:" + _ASM_EXTABLE(1b, 2b) + : +#ifdef HAVE_AS_EPT + : "m" (operand), "r" (type), +#else + : "a" (&operand), "c" (type), +#endif + _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) + : "memory" ); +} + +static inline void ept_sync_all(void) +{ + __invept(INVEPT_ALL_CONTEXT, 0); +} + +static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) +{ + int type = INVVPID_INDIVIDUAL_ADDR; + + /* + * If individual address invalidation is not supported, we escalate to + * use single context invalidation. + */ + if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) + goto execute_invvpid; + + type = INVVPID_SINGLE_CONTEXT; + + /* + * If single context invalidation is not supported, we escalate to + * use all context invalidation. + */ + if ( !cpu_has_vmx_vpid_invvpid_single_context ) + type = INVVPID_ALL_CONTEXT; + + execute_invvpid: + __invvpid(type, v->arch.hvm.n1asid.asid, (uint64_t) gva); +} + +static inline void vpid_sync_all(void) +{ + __invvpid(INVVPID_ALL_CONTEXT, 0, 0); +} + +static inline void __vmxoff(void) +{ + asm volatile ( VMXOFF_OPCODE : : : "memory" ); +} + +static inline int __vmxon(uint64_t addr) +{ + int rc; + + asm volatile ( + "1: " VMXON_OPCODE MODRM_EAX_06 "\n" + " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ + "2:\n" + ".section .fixup,\"ax\"\n" + "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ + ".previous\n" + _ASM_EXTABLE(1b, 3b) + : "=q" (rc) + : "0" (0), "a" (&addr) + : "memory" ); + + return rc; +} + +#endif /* __X86_HVM_VMX_VMX_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 674cdabb07..0bda8430b9 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -29,6 +29,8 @@ #include #include +#include "vmx.h" + static DEFINE_PER_CPU(u64 *, vvmcs_buf); static void nvmx_purge_vvmcs(struct vcpu *v); diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index f5720c393c..3b32001149 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -21,12 +21,8 @@ #include #include -#include -#include #include -extern int8_t opt_ept_exec_sp; - typedef union { struct { uint64_t r : 1, /* bit 0 - Read permission */ @@ -77,69 +73,8 @@ typedef enum { #define EPTE_RWX_MASK 0x7 #define EPTE_FLAG_MASK 0x7f -#define PI_xAPIC_NDST_MASK 0xFF00 - -void vmx_intr_assist(void); -void noreturn cf_check vmx_do_resume(void); -void cf_check vmx_vlapic_msr_changed(struct vcpu *v); struct hvm_emulate_ctxt; void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt); -void vmx_realmode(struct cpu_user_regs *regs); -void vmx_update_exception_bitmap(struct vcpu *v); -void vmx_update_cpu_exec_control(struct vcpu *v); -void vmx_update_secondary_exec_control(struct vcpu *v); - -#define POSTED_INTR_ON 0 -#define POSTED_INTR_SN 1 -static inline int pi_test_and_set_pir(uint8_t vector, struct pi_desc *pi_desc) -{ - return test_and_set_bit(vector, pi_desc->pir); -} - -static inline int pi_test_pir(uint8_t vector, const struct pi_desc *pi_desc) -{ - return test_bit(vector, pi_desc->pir); -} - -static inline int pi_test_and_set_on(struct pi_desc *pi_desc) -{ - return test_and_set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline void pi_set_on(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_and_clear_on(struct pi_desc *pi_desc) -{ - return test_and_clear_bit(POSTED_INTR_ON, &pi_desc->control); -} - -static inline int pi_test_on(struct pi_desc *pi_desc) -{ - return pi_desc->on; -} - -static inline unsigned long pi_get_pir(struct pi_desc *pi_desc, int group) -{ - return xchg(&pi_desc->pir[group], 0); -} - -static inline int pi_test_sn(struct pi_desc *pi_desc) -{ - return pi_desc->sn; -} - -static inline void pi_set_sn(struct pi_desc *pi_desc) -{ - set_bit(POSTED_INTR_SN, &pi_desc->control); -} - -static inline void pi_clear_sn(struct pi_desc *pi_desc) -{ - clear_bit(POSTED_INTR_SN, &pi_desc->control); -} /* * Exit Reasons @@ -210,60 +145,6 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_NOTIFY 75 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ -/* - * Interruption-information format - * - * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification - * field for EPT violations, PML full and SPP-related event vmexits. - */ -#define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ -#define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ -#define INTR_INFO_DELIVER_CODE_MASK 0x800 /* 11 */ -#define INTR_INFO_NMI_UNBLOCKED_BY_IRET 0x1000 /* 12 */ -#define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ -#define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 - -/* - * Exit Qualifications for NOTIFY VM EXIT - */ -#define NOTIFY_VM_CONTEXT_INVALID 1u - -/* - * Exit Qualifications for MOV for Control Register Access - */ -enum { - VMX_CR_ACCESS_TYPE_MOV_TO_CR, - VMX_CR_ACCESS_TYPE_MOV_FROM_CR, - VMX_CR_ACCESS_TYPE_CLTS, - VMX_CR_ACCESS_TYPE_LMSW, -}; -typedef union cr_access_qual { - unsigned long raw; - struct { - uint16_t cr:4, - access_type:2, /* VMX_CR_ACCESS_TYPE_* */ - lmsw_op_type:1, /* 0 => reg, 1 => mem */ - :1, - gpr:4, - :4; - uint16_t lmsw_data; - uint32_t :32; - }; -} __transparent__ cr_access_qual_t; - -/* - * Access Rights - */ -#define X86_SEG_AR_SEG_TYPE 0xf /* 3:0, segment type */ -#define X86_SEG_AR_DESC_TYPE (1u << 4) /* 4, descriptor type */ -#define X86_SEG_AR_DPL 0x60 /* 6:5, descriptor privilege level */ -#define X86_SEG_AR_SEG_PRESENT (1u << 7) /* 7, segment present */ -#define X86_SEG_AR_AVL (1u << 12) /* 12, available for system software */ -#define X86_SEG_AR_CS_LM_ACTIVE (1u << 13) /* 13, long mode active (CS only) */ -#define X86_SEG_AR_DEF_OP_SIZE (1u << 14) /* 14, default operation size */ -#define X86_SEG_AR_GRANULARITY (1u << 15) /* 15, granularity */ -#define X86_SEG_AR_SEG_UNUSABLE (1u << 16) /* 16, segment unusable */ - #define VMCALL_OPCODE ".byte 0x0f,0x01,0xc1\n" #define VMCLEAR_OPCODE ".byte 0x66,0x0f,0xc7\n" /* reg/opcode: /6 */ #define VMLAUNCH_OPCODE ".byte 0x0f,0x01,0xc2\n" @@ -282,8 +163,6 @@ typedef union cr_access_qual { #define MODRM_EAX_07 ".byte 0x38\n" /* [EAX], with reg/opcode: /7 */ #define MODRM_EAX_ECX ".byte 0xc1\n" /* EAX, ECX */ -extern uint8_t posted_intr_vector; - #define cpu_has_vmx_ept_exec_only_supported \ (vmx_ept_vpid_cap & VMX_EPT_EXEC_ONLY_SUPPORTED) @@ -302,9 +181,6 @@ extern uint8_t posted_intr_vector; #define ept_has_2mb(c) ((c >> EPT_2MB_SHIFT) & 1) #define ept_has_1gb(c) ((c >> EPT_1GB_SHIFT) & 1) -#define INVEPT_SINGLE_CONTEXT 1 -#define INVEPT_ALL_CONTEXT 2 - #define cpu_has_vmx_vpid_invvpid_individual_addr \ (vmx_ept_vpid_cap & VMX_VPID_INVVPID_INDIVIDUAL_ADDR) #define cpu_has_vmx_vpid_invvpid_single_context \ @@ -312,61 +188,6 @@ extern uint8_t posted_intr_vector; #define cpu_has_vmx_vpid_invvpid_single_context_retaining_global \ (vmx_ept_vpid_cap & VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL) -#define INVVPID_INDIVIDUAL_ADDR 0 -#define INVVPID_SINGLE_CONTEXT 1 -#define INVVPID_ALL_CONTEXT 2 -#define INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 3 - -#ifdef HAVE_AS_VMX -# define GAS_VMX_OP(yes, no) yes -#else -# define GAS_VMX_OP(yes, no) no -#endif - -static always_inline void __vmptrld(u64 addr) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmptrld %0\n" -#else - VMPTRLD_OPCODE MODRM_EAX_06 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmptrld) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "m" (addr), -#else - : "a" (&addr), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory"); -} - -static always_inline void __vmpclear(u64 addr) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmclear %0\n" -#else - VMCLEAR_OPCODE MODRM_EAX_06 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmclear) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "m" (addr), -#else - : "a" (&addr), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory"); -} - static always_inline void __vmread(unsigned long field, unsigned long *value) { asm volatile ( @@ -390,207 +211,8 @@ static always_inline void __vmread(unsigned long field, unsigned long *value) ); } -static always_inline void __vmwrite(unsigned long field, unsigned long value) -{ - asm volatile ( -#ifdef HAVE_AS_VMX - "vmwrite %1, %0\n" -#else - VMWRITE_OPCODE MODRM_EAX_ECX -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, vmwrite) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_VMX - : "r" (field) , "rm" (value), -#else - : "a" (field) , "c" (value), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - ); -} - -static inline enum vmx_insn_errno vmread_safe(unsigned long field, - unsigned long *value) -{ - unsigned long ret = VMX_INSN_SUCCEED; - bool fail_invalid, fail_valid; - - asm volatile ( GAS_VMX_OP("vmread %[field], %[value]\n\t", - VMREAD_OPCODE MODRM_EAX_ECX) - ASM_FLAG_OUT(, "setc %[invalid]\n\t") - ASM_FLAG_OUT(, "setz %[valid]\n\t") - : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), - ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid), - [value] GAS_VMX_OP("=rm", "=c") (*value) - : [field] GAS_VMX_OP("r", "a") (field)); - - if ( unlikely(fail_invalid) ) - ret = VMX_INSN_FAIL_INVALID; - else if ( unlikely(fail_valid) ) - __vmread(VM_INSTRUCTION_ERROR, &ret); - - return ret; -} - -static inline enum vmx_insn_errno vmwrite_safe(unsigned long field, - unsigned long value) -{ - unsigned long ret = VMX_INSN_SUCCEED; - bool fail_invalid, fail_valid; - - asm volatile ( GAS_VMX_OP("vmwrite %[value], %[field]\n\t", - VMWRITE_OPCODE MODRM_EAX_ECX) - ASM_FLAG_OUT(, "setc %[invalid]\n\t") - ASM_FLAG_OUT(, "setz %[valid]\n\t") - : ASM_FLAG_OUT("=@ccc", [invalid] "=rm") (fail_invalid), - ASM_FLAG_OUT("=@ccz", [valid] "=rm") (fail_valid) - : [field] GAS_VMX_OP("r", "a") (field), - [value] GAS_VMX_OP("rm", "c") (value)); - - if ( unlikely(fail_invalid) ) - ret = VMX_INSN_FAIL_INVALID; - else if ( unlikely(fail_valid) ) - __vmread(VM_INSTRUCTION_ERROR, &ret); - - return ret; -} - -static always_inline void __invept(unsigned long type, uint64_t eptp) -{ - struct { - uint64_t eptp, rsvd; - } operand = { eptp }; - - /* - * If single context invalidation is not supported, we escalate to - * use all context invalidation. - */ - if ( (type == INVEPT_SINGLE_CONTEXT) && - !cpu_has_vmx_ept_invept_single_context ) - type = INVEPT_ALL_CONTEXT; - - asm volatile ( -#ifdef HAVE_AS_EPT - "invept %0, %1\n" -#else - INVEPT_OPCODE MODRM_EAX_08 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, invept) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION - : -#ifdef HAVE_AS_EPT - : "m" (operand), "r" (type), -#else - : "a" (&operand), "c" (type), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory" ); -} - -static always_inline void __invvpid(unsigned long type, u16 vpid, u64 gva) -{ - struct __packed { - u64 vpid:16; - u64 rsvd:48; - u64 gva; - } operand = {vpid, 0, gva}; - - /* Fix up #UD exceptions which occur when TLBs are flushed before VMXON. */ - asm volatile ( "1: " -#ifdef HAVE_AS_EPT - "invvpid %0, %1\n" -#else - INVVPID_OPCODE MODRM_EAX_08 -#endif - /* CF==1 or ZF==1 --> BUG() */ - UNLIKELY_START(be, invvpid) - _ASM_BUGFRAME_TEXT(0) - UNLIKELY_END_SECTION "\n" - "2:" - _ASM_EXTABLE(1b, 2b) - : -#ifdef HAVE_AS_EPT - : "m" (operand), "r" (type), -#else - : "a" (&operand), "c" (type), -#endif - _ASM_BUGFRAME_INFO(BUGFRAME_bug, __LINE__, __FILE__, 0) - : "memory" ); -} - -static inline void ept_sync_all(void) -{ - __invept(INVEPT_ALL_CONTEXT, 0); -} - void ept_sync_domain(struct p2m_domain *p2m); -static inline void vpid_sync_vcpu_gva(struct vcpu *v, unsigned long gva) -{ - int type = INVVPID_INDIVIDUAL_ADDR; - - /* - * If individual address invalidation is not supported, we escalate to - * use single context invalidation. - */ - if ( likely(cpu_has_vmx_vpid_invvpid_individual_addr) ) - goto execute_invvpid; - - type = INVVPID_SINGLE_CONTEXT; - - /* - * If single context invalidation is not supported, we escalate to - * use all context invalidation. - */ - if ( !cpu_has_vmx_vpid_invvpid_single_context ) - type = INVVPID_ALL_CONTEXT; - -execute_invvpid: - __invvpid(type, v->arch.hvm.n1asid.asid, (u64)gva); -} - -static inline void vpid_sync_all(void) -{ - __invvpid(INVVPID_ALL_CONTEXT, 0, 0); -} - -static inline void __vmxoff(void) -{ - asm volatile ( - VMXOFF_OPCODE - : : : "memory" ); -} - -static inline int __vmxon(u64 addr) -{ - int rc; - - asm volatile ( - "1: " VMXON_OPCODE MODRM_EAX_06 "\n" - " setna %b0 ; neg %0\n" /* CF==1 or ZF==1 --> rc = -1 */ - "2:\n" - ".section .fixup,\"ax\"\n" - "3: sub $2,%0 ; jmp 2b\n" /* #UD or #GP --> rc = -2 */ - ".previous\n" - _ASM_EXTABLE(1b, 3b) - : "=q" (rc) - : "0" (0), "a" (&addr) - : "memory"); - - return rc; -} - -int cf_check vmx_guest_x86_mode(struct vcpu *v); -unsigned int vmx_get_cpl(void); - -void vmx_inject_extint(int trap, uint8_t source); -void vmx_inject_nmi(void); - void ept_walk_table(struct domain *d, unsigned long gfn); bool ept_handle_misconfig(uint64_t gpa); int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, @@ -599,13 +221,6 @@ void setup_ept_dump(void); /* Locate an alternate p2m by its EPTP */ unsigned int p2m_find_altp2m_by_eptp(struct domain *d, uint64_t eptp); -void update_guest_eip(void); - -void vmx_pi_per_cpu_init(unsigned int cpu); -void vmx_pi_desc_fixup(unsigned int cpu); - -void vmx_sync_exit_bitmap(struct vcpu *v); - #ifdef CONFIG_HVM void vmx_pi_hooks_assign(struct domain *d); void vmx_pi_hooks_deassign(struct domain *d); @@ -614,8 +229,6 @@ static inline void vmx_pi_hooks_assign(struct domain *d) {} static inline void vmx_pi_hooks_deassign(struct domain *d) {} #endif -#define APIC_INVALID_DEST 0xffffffff - /* EPT violation qualifications definitions */ typedef union ept_qual { unsigned long raw; @@ -631,56 +244,4 @@ typedef union ept_qual { #define EPT_L4_PAGETABLE_SHIFT 39 #define EPT_PAGETABLE_ENTRIES 512 -/* #VE information page */ -typedef struct { - u32 exit_reason; - u32 semaphore; - u64 exit_qualification; - u64 gla; - u64 gpa; - u16 eptp_index; -} ve_info_t; - -/* VM-Exit instruction info for LIDT, LGDT, SIDT, SGDT */ -typedef union idt_or_gdt_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :5, /* bits 6:2 - Undefined */ - addr_size :3, /* bits 9:7 - Address size */ - :1, /* bit 10 - Cleared to 0 */ - operand_size :1, /* bit 11 - Operand size */ - :3, /* bits 14:12 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:GDT, 1:IDT */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 30:63 - Undefined */ - }; -} idt_or_gdt_instr_info_t; - -/* VM-Exit instruction info for LLDT, LTR, SLDT, STR */ -typedef union ldt_or_tr_instr_info { - unsigned long raw; - struct { - unsigned long scaling :2, /* bits 0:1 - Scaling */ - :1, /* bit 2 - Undefined */ - reg1 :4, /* bits 6:3 - Reg1 */ - addr_size :3, /* bits 9:7 - Address size */ - mem_reg :1, /* bit 10 - Mem/Reg */ - :4, /* bits 14:11 - Undefined */ - segment_reg :3, /* bits 17:15 - Segment register */ - index_reg :4, /* bits 21:18 - Index register */ - index_reg_invalid :1, /* bit 22 - Index register invalid */ - base_reg :4, /* bits 26:23 - Base register */ - base_reg_invalid :1, /* bit 27 - Base register invalid */ - instr_identity :1, /* bit 28 - 0:LDT, 1:TR */ - instr_write :1, /* bit 29 - 0:store, 1:load */ - :34; /* bits 31:63 - Undefined */ - }; -} ldt_or_tr_instr_info_t; - #endif /* __ASM_X86_HVM_VMX_VMX_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501421.773229 (Exim 4.92) (envelope-from ) id 1pVd9M-00040H-EG; Fri, 24 Feb 2023 18:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501421.773229; Fri, 24 Feb 2023 18:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9M-0003yz-4E; Fri, 24 Feb 2023 18:50:32 +0000 Received: by outflank-mailman (input) for mailman id 501421; Fri, 24 Feb 2023 18:50:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9K-0001Wv-Rw for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:30 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c687060-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:30 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id cq23so1155733edb.1 for ; Fri, 24 Feb 2023 10:50:30 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c687060-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tf7rK6h2R1hnCH3sI+RxI9BdV0x0fUj0Pl5i4U926Qo=; b=Hl5p1WNymqkIwVQgUM4+n1XHAUka6weLZbCQCbVxHKqMhU1jjIDcHs7We728B548OT ojilNwy6QrI9FqOIazvZ5q9T4jQYQDfYVySAJEHBR6a06W9AgBSJWmXsQoAY9ZC1Ze+F LvYCNDtslwGZQtqPwX9+qimA4mpy9oTCE/bbyL3oXR7/Eo5Ek52DPrnsHWtfIOG/I8t3 pax+m/8XB6VxHc18XU1YJJbk+gGgqoFTEkWtHu2pUfyMS7QOXILh/ljzgTsP9Un2w4tR HlTf2rbSHKbcveco7wbrO7OP4+HE2xbTyW53FPx2uVi3JdsteyLjDh9jFfYIb9k/+jvP m0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tf7rK6h2R1hnCH3sI+RxI9BdV0x0fUj0Pl5i4U926Qo=; b=bC+JeyL4nQjXjjyOmJrr09aF2zx7iU3C5iGinHEutgLdsq7kPS+xEzIE1kLeH6br59 epJcFGpu6fGk9jdV3gjNxx74TBeWVJSNZqNCjTif0r7E/HuftiJzTnC6Gm/Nwu/tPcTB MC76BtzbQcLrVQGatbkG+uj/EzZUuY1I6gJtKmP+Up5K8jpZqQZu7YGYRyU6B1Hb4DMZ bUZRPXl0xPrvkl0VUc+9uCT4X5R0TKYKhxhzqZ6VFTacp8ZuOI9CsIJjsRD8aJ68yGRL swYo4SUspUb7D5mIaNzxphIgHsnv4I2fK87EM/6iQjCSSozA4AbuuK/5GZtEoni/R7Hd FHvw== X-Gm-Message-State: AO0yUKWKC/dJyJ8kqQadXUNRC6lolkKqALyyt2umORYlSrMNK1oopJ2m yLO9jMVZ+qdIZjAtzb6yNi+YaxdUsRg= X-Google-Smtp-Source: AK7set8k7+JX10Hrw5HOz7NLFdBlES5/dA87K6uhp6LNUy5yFb3HwTVwtMb+giTiIpZTnglsWKMfHA== X-Received: by 2002:a17:906:53c7:b0:885:fee4:69ee with SMTP id p7-20020a17090653c700b00885fee469eemr22870606ejo.59.1677264629835; Fri, 24 Feb 2023 10:50:29 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 09/14] x86/vmx: remove unused included headers from vmx.h Date: Fri, 24 Feb 2023 20:50:05 +0200 Message-Id: <20230224185010.3692754-10-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/i387.h asm/hvm/trace.h asm/processor.h asm/regs.h because none of the declarations and macro definitions in them is used in this file. Sort the rest of the headers alphabetically. Include asm/i387.h in vmx.c, needed for vcpu_restore_fpu_lazy(). Take the opportunity to include xen/types.h in the place of asm/types.h and replace u* with uint*_t and bool_t with bool. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - reword the commit message to not look like a bug fix, reported by JAn - include xen/types.h instead of asm/types.h and use uint*_t instead of u*, suggested by Jan xen/arch/x86/hvm/vmx/vmx.c | 1 + xen/arch/x86/include/asm/hvm/vmx/vmx.h | 15 ++++++--------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 294c8490b4..232107bd79 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 82a9487b40..f5720c393c 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -19,20 +19,17 @@ #define __ASM_X86_HVM_VMX_VMX_H__ #include -#include -#include +#include + #include -#include -#include -#include -#include #include +#include extern int8_t opt_ept_exec_sp; typedef union { struct { - u64 r : 1, /* bit 0 - Read permission */ + uint64_t r : 1, /* bit 0 - Read permission */ w : 1, /* bit 1 - Write permission */ x : 1, /* bit 2 - Execute permission */ emt : 3, /* bits 5:3 - EPT Memory type */ @@ -49,7 +46,7 @@ typedef union { _rsvd : 1, /* bit 62 - reserved */ suppress_ve : 1; /* bit 63 - suppress #VE */ }; - u64 epte; + uint64_t epte; } ept_entry_t; typedef struct { @@ -595,7 +592,7 @@ void vmx_inject_extint(int trap, uint8_t source); void vmx_inject_nmi(void); void ept_walk_table(struct domain *d, unsigned long gfn); -bool_t ept_handle_misconfig(uint64_t gpa); +bool ept_handle_misconfig(uint64_t gpa); int epte_get_entry_emt(struct domain *d, gfn_t gfn, mfn_t mfn, unsigned int order, bool *ipat, p2m_type_t type); void setup_ept_dump(void); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501429.773250 (Exim 4.92) (envelope-from ) id 1pVd9T-0005JW-Ei; Fri, 24 Feb 2023 18:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501429.773250; Fri, 24 Feb 2023 18:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9T-0005JD-8a; Fri, 24 Feb 2023 18:50:39 +0000 Received: by outflank-mailman (input) for mailman id 501429; Fri, 24 Feb 2023 18:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9R-0002YL-Ff for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:37 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f4a88b9-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:35 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id eg37so918338edb.12 for ; Fri, 24 Feb 2023 10:50:35 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:34 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f4a88b9-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cgbm5NZC1PT7zNDMW6qxeefiGl1B4h2NMbEX/nSdgxk=; b=ABOZi85NTTLSQ1Bzz3aLA2XtgFm22B/2plA8glx7U0Mw/31zy85yrNLJr+nuhrA100 43pNXxhtXFBniSt0EXclVrSgiXQZM83FM1tLw7aeNpCvXn9ubP5esNPScGdN+JKVljR+ hgIS17l5Z+94KdjGLha4yvnUAUPC5K3PwImxIJweT3bDWpFpTsjxbOr+v3MLivCQxbqt 1dM5RA6+5Te9W1ocW+1nyx8N88QxrbUjhhztpHsB1yjEzuQlYMaM3Ui8knwaLvwhQ9l+ 5RAMdv6XwpyuIkRpvJafVJAiGaSEKXmvGnnixpL3TXBPPKJMF7e6rB+t+osmIm7yPeYt THZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgbm5NZC1PT7zNDMW6qxeefiGl1B4h2NMbEX/nSdgxk=; b=hXTxUYX8Ryl0Or1Ir1MeDTtfTufNBdZFuYVcrhk40bb6eN6yzZdpL3EqArHwQIisqF dAkn6JJAI81omMZTA3SOGvP705VwQEijXatERbnRZrmTXSuyGBDbX9ti25dCnlRDfXO8 v9dN/1x+Yx1h3um0FpnYCxssN6C4S147uRRE1tfiFpXIYdjnPNBpb1wj31BHQ4N7+Q+c xFAnXzO9Nt+jRWwnNCn/JZlq98MD366GSTbITQqODnAlRVZFjpKG+p8qAL3lb6yqsKDo wQ3+NWXuDCxbfG0BwVDFTQF/EiRPezDc2C2kac3hmtAghY62jHB5hfRH5QWEazZLNfsM A9GQ== X-Gm-Message-State: AO0yUKVFEvCQtGNweKTq857OBH9DSpuNOJ8QmLkkiy3yoJjJLDnBekhE C3E7ufGwNXYrvNm8bYyqj4F4BDRGTnQ= X-Google-Smtp-Source: AK7set9FmOCw2k3VCNZ7PgS99bFeT8J2UOQic9ubHYd1gWEaUXF26RKSt33YmUyN1OWt0euzIKLkeg== X-Received: by 2002:a17:906:8484:b0:8b1:7f7d:7282 with SMTP id m4-20020a170906848400b008b17f7d7282mr29967280ejx.7.1677264634878; Fri, 24 Feb 2023 10:50:34 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 12/14] x86/vmx: declare nvmx_enqueue_n2_exceptions() static Date: Fri, 24 Feb 2023 20:50:08 +0200 Message-Id: <20230224185010.3692754-13-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reduce the scope of nvmx_enqueue_n2_exceptions() to static because it is used only in this file. Take the opportunity to remove a trailing space. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich --- Changes in v3: - add Jan's R-b tag xen/arch/x86/hvm/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 9b009ebcef..72d8f058f7 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1897,7 +1897,7 @@ static void cf_check vmx_update_guest_efer(struct vcpu *v) vmx_set_msr_intercept(v, MSR_EFER, VMX_MSR_R); } -void nvmx_enqueue_n2_exceptions(struct vcpu *v, +static void nvmx_enqueue_n2_exceptions(struct vcpu *v, unsigned long intr_fields, int error_code, uint8_t source) { struct nestedvmx *nvmx = &vcpu_2_nvmx(v); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:59:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501474.773266 (Exim 4.92) (envelope-from ) id 1pVdHh-0000NA-QG; Fri, 24 Feb 2023 18:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501474.773266; Fri, 24 Feb 2023 18:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdHh-0000Mx-MK; Fri, 24 Feb 2023 18:59:09 +0000 Received: by outflank-mailman (input) for mailman id 501474; Fri, 24 Feb 2023 18:59:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9X-0002YL-GY for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:43 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 21472588-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:38 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id f13so1043298edz.6 for ; Fri, 24 Feb 2023 10:50:38 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:37 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21472588-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oPu/CWLizak/IEWUGPIk9YBOHGWgcE+p+9Gx9liFImY=; b=M+rCwNla4KthKEp+2PbbfuXze83MK0Onq9VS/jOP3ModXka4wg5mqXP3eoc63+12c8 81Pwd0hASHLJSYItsXHT+btPrTRHXMLeGwc6JF7ZhPAguXJqOaZySGhufxigZqPzkPaw ab+CEHbB/33pjSMbBd9l5b2n3nBex+c/vu1sWH9ddywhg/szO8E3HQQ2uw4sPb1hFvev IXmFH60eAXk95yrDXn9ddOzkkbdysDY0viDBYUIdARzlp26NUwl7dMo+O52FrfQQWaLx /qZkwa1sUz49n+PnhsiYQuwNXI0sBv9FH+Dw2/VGuvEcCwEN/8Z+rKspNWPI1iQCOPbS z8UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPu/CWLizak/IEWUGPIk9YBOHGWgcE+p+9Gx9liFImY=; b=tjhF9beAQ/X9/jX2IvCexSxsYhMRY00vpfgjOIEzJrkog5AQ7h1qDMO8m2ybfQmTrD SS6CRJuljfzouzaeE9lDx6NzlW3RRYCZPEJReKQvlroVVVjztVzWfJnL3HEFDS6hioiw wxk6HFRzjITBGLcdBvARnP+T7x11DD5QQFPorcuiaJdXnGgMMEwJZlX/oQldkZxZiSym prBaqMTm/RMKFzK7y+rTSb5hWTfi6P+e2CuHZ/sq7EGcV+i4QqGMmKwWchvB7rdhEyck CuPbYVD3UYz6Ue3na+HwC3sRNnpu++X1rrr7nyWEZydJycMYC7dutobLjO4ijIfbQ6Ok ht5A== X-Gm-Message-State: AO0yUKUT3JQ7sCtGebVCOZ/p8OCAi6kz2d/Si6+KsmshLYn7ZDRAyuFz mKzCPMUgSXKWqSCftygr3ZcC1zFQqHM= X-Google-Smtp-Source: AK7set9VCrxsCfrj8WDMJqnfM3n3CCnV/bOaEvihD8tqZ0eHsE5kIn0RiNmLBZtpr8p7NCKKWlojSQ== X-Received: by 2002:a17:906:f249:b0:878:81d7:9f77 with SMTP id gy9-20020a170906f24900b0087881d79f77mr21568882ejb.34.1677264638178; Fri, 24 Feb 2023 10:50:38 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 14/14] x86/vmx: move vmcs declarations used only by vmx code to private header Date: Fri, 24 Feb 2023 20:50:10 +0200 Message-Id: <20230224185010.3692754-15-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/vmx called vmcs.h and move there all definitions and declarations that are used only by vmx code and don't need to reside in an external header. Take the opportunity to replace u* with uint*_t, bool_t with bool and to re-arrange the header as follows, all structures first, then all variable declarations, all function delarations, and finally all inline functions. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/vmx/intr.c | 1 + xen/arch/x86/hvm/vmx/vmcs.c | 1 + xen/arch/x86/hvm/vmx/vmcs.h | 100 ++++++++++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 1 + xen/arch/x86/hvm/vmx/vvmx.c | 1 + xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 118 +++++------------------- 6 files changed, 128 insertions(+), 94 deletions(-) create mode 100644 xen/arch/x86/hvm/vmx/vmcs.h diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index 8431937f42..d8387e7215 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -38,6 +38,7 @@ #include #include +#include "vmcs.h" #include "vmx.h" #include "vvmx.h" diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 3d0f6be5bb..57e19e8dad 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -42,6 +42,7 @@ #include #include +#include "vmcs.h" #include "vmx.h" #include "vvmx.h" diff --git a/xen/arch/x86/hvm/vmx/vmcs.h b/xen/arch/x86/hvm/vmx/vmcs.h new file mode 100644 index 0000000000..c0cca0ce73 --- /dev/null +++ b/xen/arch/x86/hvm/vmx/vmcs.h @@ -0,0 +1,100 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * vmcs.h: VMCS related definitions + * + * Copyright (c) 2004, Intel Corporation. + */ + +#ifndef __X86_HVM_VMX_VMCS_PRIV_H__ +#define __X86_HVM_VMX_VMCS_PRIV_H__ + +#include +#include + +#include + +struct vmcs_struct { + uint32_t vmcs_revision_id; + unsigned char data [0]; /* vmcs size is read from MSR */ +}; + +#define _VMX_DOMAIN_PML_ENABLED 0 +#define VMX_DOMAIN_PML_ENABLED (1ul << _VMX_DOMAIN_PML_ENABLED) + +/* + * Layout of the MSR bitmap, as interpreted by hardware: + * - *_low covers MSRs 0 to 0x1fff + * - *_ligh covers MSRs 0xc0000000 to 0xc0001fff + */ +struct vmx_msr_bitmap { + unsigned long read_low [0x2000 / BITS_PER_LONG]; + unsigned long read_high [0x2000 / BITS_PER_LONG]; + unsigned long write_low [0x2000 / BITS_PER_LONG]; + unsigned long write_high[0x2000 / BITS_PER_LONG]; +}; + +#define NR_PML_ENTRIES 512 + +void vmcs_dump_vcpu(struct vcpu *v); +int vmx_vmcs_init(void); +int cf_check vmx_cpu_up_prepare(unsigned int cpu); +void cf_check vmx_cpu_dead(unsigned int cpu); +int cf_check vmx_cpu_up(void); +void cf_check vmx_cpu_down(void); + +int vmx_create_vmcs(struct vcpu *v); +void vmx_destroy_vmcs(struct vcpu *v); +bool __must_check vmx_vmcs_try_enter(struct vcpu *v); +void vmx_vmcs_reload(struct vcpu *v); + +void vmx_vmcs_switch(paddr_t from, paddr_t to); +void vmx_set_eoi_exit_bitmap(struct vcpu *v, uint8_t vector); +void vmx_clear_eoi_exit_bitmap(struct vcpu *v, uint8_t vector); +bool vmx_msr_is_intercepted(struct vmx_msr_bitmap *msr_bitmap, + unsigned int msr, bool is_write) __nonnull(1); +void virtual_vmcs_enter(const struct vcpu *); +void virtual_vmcs_exit(const struct vcpu *); +u64 virtual_vmcs_vmread(const struct vcpu *, uint32_t encoding); +enum vmx_insn_errno virtual_vmcs_vmread_safe(const struct vcpu *v, + uint32_t vmcs_encoding, + uint64_t *val); +void virtual_vmcs_vmwrite(const struct vcpu *, uint32_t encoding, uint64_t val); +enum vmx_insn_errno virtual_vmcs_vmwrite_safe(const struct vcpu *v, + uint32_t vmcs_encoding, + uint64_t val); + +DECLARE_PER_CPU(bool, vmxon); + +bool vmx_vcpu_pml_enabled(const struct vcpu *v); +int vmx_vcpu_enable_pml(struct vcpu *v); +void vmx_vcpu_disable_pml(struct vcpu *v); +void vmx_vcpu_flush_pml_buffer(struct vcpu *v); + +static inline int vmx_read_guest_loadonly_msr( + const struct vcpu *v, uint32_t msr, uint64_t *val) +{ + const struct vmx_msr_entry *ent = + vmx_find_msr(v, msr, VMX_MSR_GUEST_LOADONLY); + + if ( !ent ) + { + *val = 0; + return -ESRCH; + } + + *val = ent->data; + + return 0; +} + +#endif /* __X86_HVM_VMX_VMCS_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 73ab4e9816..c5f6902206 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -57,6 +57,7 @@ #include #include "pi.h" +#include "vmcs.h" #include "vmx.h" #include "vvmx.h" diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 0af5411076..d0a6fa2d20 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -29,6 +29,7 @@ #include #include +#include "vmcs.h" #include "vmx.h" #include "vvmx.h" diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e74478..47206b1e9d 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -20,22 +20,10 @@ #include -extern void vmcs_dump_vcpu(struct vcpu *v); -extern int vmx_vmcs_init(void); -int cf_check vmx_cpu_up_prepare(unsigned int cpu); -void cf_check vmx_cpu_dead(unsigned int cpu); -int cf_check vmx_cpu_up(void); -void cf_check vmx_cpu_down(void); - -struct vmcs_struct { - u32 vmcs_revision_id; - unsigned char data [0]; /* vmcs size is read from MSR */ -}; - struct vmx_msr_entry { - u32 index; - u32 mbz; - u64 data; + uint32_t index; + uint32_t mbz; + uint64_t data; }; #define EPT_DEFAULT_MT X86_MT_WB @@ -49,14 +37,12 @@ struct ept_data { :5, /* rsvd. */ mfn:52; }; - u64 eptp; + uint64_t eptp; }; /* Set of PCPUs needing an INVEPT before a VMENTER. */ cpumask_var_t invalidate; }; -#define _VMX_DOMAIN_PML_ENABLED 0 -#define VMX_DOMAIN_PML_ENABLED (1ul << _VMX_DOMAIN_PML_ENABLED) struct vmx_domain { mfn_t apic_access_mfn; /* VMX_DOMAIN_* */ @@ -69,36 +55,22 @@ struct vmx_domain { bool exec_sp; }; -/* - * Layout of the MSR bitmap, as interpreted by hardware: - * - *_low covers MSRs 0 to 0x1fff - * - *_ligh covers MSRs 0xc0000000 to 0xc0001fff - */ -struct vmx_msr_bitmap { - unsigned long read_low [0x2000 / BITS_PER_LONG]; - unsigned long read_high [0x2000 / BITS_PER_LONG]; - unsigned long write_low [0x2000 / BITS_PER_LONG]; - unsigned long write_high[0x2000 / BITS_PER_LONG]; -}; - struct pi_desc { DECLARE_BITMAP(pir, X86_NR_VECTORS); union { struct { - u16 on : 1, /* bit 256 - Outstanding Notification */ - sn : 1, /* bit 257 - Suppress Notification */ - rsvd_1 : 14; /* bit 271:258 - Reserved */ - u8 nv; /* bit 279:272 - Notification Vector */ - u8 rsvd_2; /* bit 287:280 - Reserved */ - u32 ndst; /* bit 319:288 - Notification Destination */ + uint16_t on : 1, /* bit 256 - Outstanding Notification */ + sn : 1, /* bit 257 - Suppress Notification */ + rsvd_1 : 14; /* bit 271:258 - Reserved */ + uint8_t nv; /* bit 279:272 - Notification Vector */ + uint8_t rsvd_2; /* bit 287:280 - Reserved */ + uint32_t ndst; /* bit 319:288 - Notification Destination */ }; - u64 control; + uint64_t control; }; - u32 rsvd[6]; + uint32_t rsvd[6]; } __attribute__ ((aligned (64))); -#define NR_PML_ENTRIES 512 - struct pi_blocking_vcpu { struct list_head list; spinlock_t *lock; @@ -123,9 +95,9 @@ struct vmx_vcpu { int launched; /* Cache of cpu execution control. */ - u32 exec_control; - u32 secondary_exec_control; - u32 exception_bitmap; + uint32_t exec_control; + uint32_t secondary_exec_control; + uint32_t exception_bitmap; uint64_t shadow_gs; uint64_t star; @@ -154,7 +126,7 @@ struct vmx_vcpu { unsigned long host_cr0; /* Do we need to tolerate a spurious EPT_MISCONFIG VM exit? */ - bool_t ept_spurious_misconfig; + bool ept_spurious_misconfig; /* Processor Trace configured and enabled for the vcpu. */ bool ipt_active; @@ -191,12 +163,8 @@ struct vmx_vcpu { struct pi_blocking_vcpu pi_blocking; }; -int vmx_create_vmcs(struct vcpu *v); -void vmx_destroy_vmcs(struct vcpu *v); void vmx_vmcs_enter(struct vcpu *v); -bool_t __must_check vmx_vmcs_try_enter(struct vcpu *v); void vmx_vmcs_exit(struct vcpu *v); -void vmx_vmcs_reload(struct vcpu *v); #define CPU_BASED_VIRTUAL_INTR_PENDING 0x00000004 #define CPU_BASED_USE_TSC_OFFSETING 0x00000008 @@ -219,14 +187,14 @@ void vmx_vmcs_reload(struct vcpu *v); #define CPU_BASED_MONITOR_EXITING 0x20000000 #define CPU_BASED_PAUSE_EXITING 0x40000000 #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000 -extern u32 vmx_cpu_based_exec_control; +extern uint32_t vmx_cpu_based_exec_control; #define PIN_BASED_EXT_INTR_MASK 0x00000001 #define PIN_BASED_NMI_EXITING 0x00000008 #define PIN_BASED_VIRTUAL_NMIS 0x00000020 #define PIN_BASED_PREEMPT_TIMER 0x00000040 #define PIN_BASED_POSTED_INTERRUPT 0x00000080 -extern u32 vmx_pin_based_exec_control; +extern uint32_t vmx_pin_based_exec_control; #define VM_EXIT_SAVE_DEBUG_CNTRLS 0x00000004 #define VM_EXIT_IA32E_MODE 0x00000200 @@ -238,7 +206,7 @@ extern u32 vmx_pin_based_exec_control; #define VM_EXIT_LOAD_HOST_EFER 0x00200000 #define VM_EXIT_SAVE_PREEMPT_TIMER 0x00400000 #define VM_EXIT_CLEAR_BNDCFGS 0x00800000 -extern u32 vmx_vmexit_control; +extern uint32_t vmx_vmexit_control; #define VM_ENTRY_IA32E_MODE 0x00000200 #define VM_ENTRY_SMM 0x00000400 @@ -247,7 +215,7 @@ extern u32 vmx_vmexit_control; #define VM_ENTRY_LOAD_GUEST_PAT 0x00004000 #define VM_ENTRY_LOAD_GUEST_EFER 0x00008000 #define VM_ENTRY_LOAD_BNDCFGS 0x00010000 -extern u32 vmx_vmentry_control; +extern uint32_t vmx_vmentry_control; #define SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES 0x00000001 #define SECONDARY_EXEC_ENABLE_EPT 0x00000002 @@ -269,7 +237,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_TSC_SCALING 0x02000000 #define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 #define SECONDARY_EXEC_NOTIFY_VM_EXITING 0x80000000 -extern u32 vmx_secondary_exec_control; +extern uint32_t vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 #define VMX_EPT_WALK_LENGTH_4_SUPPORTED 0x00000040 @@ -286,7 +254,7 @@ extern u32 vmx_secondary_exec_control; #define VMX_VPID_INVVPID_SINGLE_CONTEXT 0x20000000000ULL #define VMX_VPID_INVVPID_ALL_CONTEXT 0x40000000000ULL #define VMX_VPID_INVVPID_SINGLE_CONTEXT_RETAINING_GLOBAL 0x80000000000ULL -extern u64 vmx_ept_vpid_cap; +extern uint64_t vmx_ept_vpid_cap; #define VMX_MISC_PROC_TRACE 0x00004000 #define VMX_MISC_CR3_TARGET 0x01ff0000 @@ -373,7 +341,7 @@ extern u64 vmx_ept_vpid_cap; */ #define VMX_BASIC_DEFAULT1_ZERO (1ULL << 55) -extern u64 vmx_basic_msr; +extern uint64_t vmx_basic_msr; #define cpu_has_vmx_ins_outs_instr_info \ (!!(vmx_basic_msr & VMX_BASIC_INS_OUT_INFO)) @@ -614,23 +582,6 @@ static inline int vmx_read_guest_msr(const struct vcpu *v, uint32_t msr, return 0; } -static inline int vmx_read_guest_loadonly_msr( - const struct vcpu *v, uint32_t msr, uint64_t *val) -{ - const struct vmx_msr_entry *ent = - vmx_find_msr(v, msr, VMX_MSR_GUEST_LOADONLY); - - if ( !ent ) - { - *val = 0; - return -ESRCH; - } - - *val = ent->data; - - return 0; -} - static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, uint64_t val) { @@ -644,7 +595,6 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, return 0; } - /* MSR intercept bitmap infrastructure. */ enum vmx_msr_intercept_type { VMX_MSR_R = 1, @@ -656,27 +606,7 @@ void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, enum vmx_msr_intercept_type type); void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, enum vmx_msr_intercept_type type); -void vmx_vmcs_switch(paddr_t from, paddr_t to); -void vmx_set_eoi_exit_bitmap(struct vcpu *v, u8 vector); -void vmx_clear_eoi_exit_bitmap(struct vcpu *v, u8 vector); -bool vmx_msr_is_intercepted(struct vmx_msr_bitmap *msr_bitmap, - unsigned int msr, bool is_write) __nonnull(1); -void virtual_vmcs_enter(const struct vcpu *); -void virtual_vmcs_exit(const struct vcpu *); -u64 virtual_vmcs_vmread(const struct vcpu *, u32 encoding); -enum vmx_insn_errno virtual_vmcs_vmread_safe(const struct vcpu *v, - u32 vmcs_encoding, u64 *val); -void virtual_vmcs_vmwrite(const struct vcpu *, u32 encoding, u64 val); -enum vmx_insn_errno virtual_vmcs_vmwrite_safe(const struct vcpu *v, - u32 vmcs_encoding, u64 val); - -DECLARE_PER_CPU(bool_t, vmxon); - -bool_t vmx_vcpu_pml_enabled(const struct vcpu *v); -int vmx_vcpu_enable_pml(struct vcpu *v); -void vmx_vcpu_disable_pml(struct vcpu *v); -void vmx_vcpu_flush_pml_buffer(struct vcpu *v); -bool_t vmx_domain_pml_enabled(const struct domain *d); +bool vmx_domain_pml_enabled(const struct domain *d); int vmx_domain_enable_pml(struct domain *d); void vmx_domain_disable_pml(struct domain *d); void vmx_domain_flush_pml_buffers(struct domain *d); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:59:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:59:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501468.773261 (Exim 4.92) (envelope-from ) id 1pVdHh-0000Je-II; Fri, 24 Feb 2023 18:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501468.773261; Fri, 24 Feb 2023 18:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdHh-0000JX-Dt; Fri, 24 Feb 2023 18:59:09 +0000 Received: by outflank-mailman (input) for mailman id 501468; Fri, 24 Feb 2023 18:59:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9U-0002YL-G1 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:40 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 205db879-b474-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 19:50:37 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id ck15so1299371edb.0 for ; Fri, 24 Feb 2023 10:50:37 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:36 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 205db879-b474-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NQP0LkNmoNNIDo9tvroAigJG+F5sDEavNOm42WnmMgM=; b=QhE+a2TaHrI2pZRjODv6nwgqIHV91v5kIYBi9bRu5gv1ElB/SSpC/pzE838gEDIrKj WJmeQb09+8Ct0sNKXqY85F97bPFjWBneM076Jv1lrBIrSscGPBbNsIyLBVNMahwBVT82 Tv9GqCzjQK5Bom7GKM7cRbAqVU0aJX+4ycvDgYjHiSEJ/GSxki8L8GjsI6JYlAS+p1lq 4V50eAx2mmWQG59XMxD3tjXXuP3RN8BBisfyGHmMMzouGfAsLG6z33ZJYEveuTNgx8d9 yChQ0jjwMg8yoXDCApRhPTQ/e/LCBJsMdVI/m+KrTlneKRiZ4jsFL+5bZbJ/AqURaTLQ 0bQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NQP0LkNmoNNIDo9tvroAigJG+F5sDEavNOm42WnmMgM=; b=65FZCX3u0PRr0lRzNUYBKGfWsgJWq2ZeUqvL5bqTMBCMqf08yByWtl+V7P6kNT1vuV DB9RDWACda8M31RYyB065cOKehMuQAcTHv63IulnmbemqQCE45nFlbkDjOxEzScxuRat JXtdj+NiaB/OcVxsAv7tp4dPsYmf0cyb1OegacJmqfNStT/lZyuvpzRJr+mSbtWcewVa dBSTM/gaW4MLH17aVbTJzr6Blf3btY7ukN59ovIp1MsKKSBg5btDFge1tw61NkkCuunH +6UJH0apHVbkTjehfMcqndS9cmU87NvrnTgCrbohFc91o/5YsGomTDsBjf89njNZrG2U qXdw== X-Gm-Message-State: AO0yUKUrCmtUURsmsCOhYbg3+O1xPUTM6kploQCBzg3C09i5OybN6P8F gTmGziYUticGgQGwW0U+blIyH3Gyw3U= X-Google-Smtp-Source: AK7set+Hik9tPVE2DMDelEX1IWgyVI1gKJG77OX+DeTSgOUG8Z5biw8D7LBOAiTVRVe32PK0WccPbQ== X-Received: by 2002:a17:907:e8b:b0:8e7:672f:23c0 with SMTP id ho11-20020a1709070e8b00b008e7672f23c0mr833416ejc.33.1677264636597; Fri, 24 Feb 2023 10:50:36 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 13/14] x86/vmx: move vvmx declarations used only by vmx code to private header Date: Fri, 24 Feb 2023 20:50:09 +0200 Message-Id: <20230224185010.3692754-14-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create a new private header in arch/x86/hvm/vmx called vvmx.h and move there all definitions and declarations that are used only by vmx code and don't need to reside in an external header. Take the opportunity to replace u* with uint*_t, bool_t with bool and to re-arrange the header as follows, all structures first, then all variable decalarations, all function delarations, and finally all inline functions. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - new patch xen/arch/x86/hvm/vmx/intr.c | 1 + xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 1 + xen/arch/x86/hvm/vmx/vvmx.c | 1 + xen/arch/x86/hvm/vmx/vvmx.h | 187 ++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vvmx.h | 165 +-------------------- 6 files changed, 198 insertions(+), 159 deletions(-) create mode 100644 xen/arch/x86/hvm/vmx/vvmx.h diff --git a/xen/arch/x86/hvm/vmx/intr.c b/xen/arch/x86/hvm/vmx/intr.c index c8db501759..8431937f42 100644 --- a/xen/arch/x86/hvm/vmx/intr.c +++ b/xen/arch/x86/hvm/vmx/intr.c @@ -39,6 +39,7 @@ #include #include "vmx.h" +#include "vvmx.h" /* * A few notes on virtual NMI and INTR delivery, and interactions with diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 4eb2571abb..3d0f6be5bb 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -34,7 +34,6 @@ #include #include #include -#include #include #include #include @@ -44,6 +43,7 @@ #include #include "vmx.h" +#include "vvmx.h" static bool_t __read_mostly opt_vpid_enabled = 1; boolean_param("vpid", opt_vpid_enabled); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 72d8f058f7..73ab4e9816 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -58,6 +58,7 @@ #include "pi.h" #include "vmx.h" +#include "vvmx.h" static bool_t __initdata opt_force_ept; boolean_param("force-ept", opt_force_ept); diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index 0bda8430b9..0af5411076 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -30,6 +30,7 @@ #include #include "vmx.h" +#include "vvmx.h" static DEFINE_PER_CPU(u64 *, vvmcs_buf); diff --git a/xen/arch/x86/hvm/vmx/vvmx.h b/xen/arch/x86/hvm/vmx/vvmx.h new file mode 100644 index 0000000000..0367fae42a --- /dev/null +++ b/xen/arch/x86/hvm/vmx/vvmx.h @@ -0,0 +1,187 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * vvmx.h: Support virtual VMX for nested virtualization. + * + * Copyright (c) 2010, Intel Corporation. + * Author: Qing He + * Eddie Dong + */ + +#ifndef __X86_HVM_VMX_VVMX_PRIV_H__ +#define __X86_HVM_VMX_VVMX_PRIV_H__ + +#include +#include +#include + +#include +#include +#include + +struct vvmcs_list { + unsigned long vvmcs_mfn; + struct list_head node; +}; + +#define vcpu_2_nvmx(v) (vcpu_nestedhvm(v).u.nvmx) + +/* bit 1, 2, 4 must be 1 */ +#define VMX_PINBASED_CTLS_DEFAULT1 0x16 +/* bit 1, 4-6,8,13-16,26 must be 1 */ +#define VMX_PROCBASED_CTLS_DEFAULT1 0x401e172 +/* bit 0-8, 10,11,13,14,16,17 must be 1 */ +#define VMX_EXIT_CTLS_DEFAULT1 0x36dff +/* bit 0-8, and 12 must be 1 */ +#define VMX_ENTRY_CTLS_DEFAULT1 0x11ff + +union vmx_inst_info { + struct { + unsigned int scaling :2; /* bit 0-1 */ + unsigned int __rsvd0 :1; /* bit 2 */ + unsigned int reg1 :4; /* bit 3-6 */ + unsigned int addr_size :3; /* bit 7-9 */ + unsigned int memreg :1; /* bit 10 */ + unsigned int __rsvd1 :4; /* bit 11-14 */ + unsigned int segment :3; /* bit 15-17 */ + unsigned int index_reg :4; /* bit 18-21 */ + unsigned int index_reg_invalid :1; /* bit 22 */ + unsigned int base_reg :4; /* bit 23-26 */ + unsigned int base_reg_invalid :1; /* bit 27 */ + unsigned int reg2 :4; /* bit 28-31 */ + } fields; + uint32_t word; +}; + +/* + * Virtual VMCS layout + * + * Since physical VMCS layout is unknown, a custom layout is used + * for virtual VMCS seen by guest. It occupies a 4k page, and the + * field is offset by an 9-bit offset into u64[], The offset is as + * follow, which means every pair has a max of 32 + * fields available. + * + * 9 7 5 0 + * -------------------------------- + * offset: | width | type | index | + * -------------------------------- + * + * Also, since the lower range has only one + * field: VPID, it is moved to a higher offset (63), and leaves the + * lower range to non-indexed field like VMCS revision. + * + */ + +struct vvmcs_header { + uint32_t revision; + uint32_t abort; +}; + +union vmcs_encoding { + struct { + uint32_t access_type : 1; + uint32_t index : 9; + uint32_t type : 2; + uint32_t rsv1 : 1; + uint32_t width : 2; + uint32_t rsv2 : 17; + }; + uint32_t word; +}; + +enum vvmcs_encoding_width { + VVMCS_WIDTH_16 = 0, + VVMCS_WIDTH_64, + VVMCS_WIDTH_32, + VVMCS_WIDTH_NATURAL, +}; + +enum vvmcs_encoding_type { + VVMCS_TYPE_CONTROL = 0, + VVMCS_TYPE_RO, + VVMCS_TYPE_GSTATE, + VVMCS_TYPE_HSTATE, +}; + +int cf_check nvmx_vcpu_initialise(struct vcpu *v); +void cf_check nvmx_vcpu_destroy(struct vcpu *v); +int cf_check nvmx_vcpu_reset(struct vcpu *v); +uint64_t cf_check nvmx_vcpu_eptp_base(struct vcpu *v); +enum hvm_intblk cf_check nvmx_intr_blocked(struct vcpu *v); +bool cf_check nvmx_intercepts_exception(struct vcpu *v, unsigned int vector, + int error_code); +void cf_check nvmx_domain_relinquish_resources(struct domain *d); + +bool cf_check nvmx_ept_enabled(struct vcpu *v); + +int cf_check nvmx_hap_walk_L1_p2m( + struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order, + uint8_t *p2m_acc, struct npfec npfec); + +uint64_t get_vvmcs_virtual(void *vvmcs, uint32_t encoding); +uint64_t get_vvmcs_real(const struct vcpu *, uint32_t encoding); +void set_vvmcs_virtual(void *vvmcs, uint32_t encoding, uint64_t val); +void set_vvmcs_real(const struct vcpu *, uint32_t encoding, uint64_t val); +enum vmx_insn_errno get_vvmcs_virtual_safe(void *vvmcs, uint32_t encoding, + uint64_t *val); +enum vmx_insn_errno get_vvmcs_real_safe(const struct vcpu *, uint32_t encoding, + uint64_t *val); +enum vmx_insn_errno set_vvmcs_virtual_safe(void *vvmcs, uint32_t encoding, + uint64_t val); +enum vmx_insn_errno set_vvmcs_real_safe(const struct vcpu *, uint32_t encoding, + uint64_t val); + +#define get_vvmcs(vcpu, encoding) \ + (cpu_has_vmx_vmcs_shadowing ? \ + get_vvmcs_real(vcpu, encoding) : \ + get_vvmcs_virtual(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding)) + +#define set_vvmcs(vcpu, encoding, val) \ + (cpu_has_vmx_vmcs_shadowing ? \ + set_vvmcs_real(vcpu, encoding, val) : \ + set_vvmcs_virtual(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) + +#define get_vvmcs_safe(vcpu, encoding, val) \ + (cpu_has_vmx_vmcs_shadowing ? \ + get_vvmcs_real_safe(vcpu, encoding, val) : \ + get_vvmcs_virtual_safe(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) + +#define set_vvmcs_safe(vcpu, encoding, val) \ + (cpu_has_vmx_vmcs_shadowing ? \ + set_vvmcs_real_safe(vcpu, encoding, val) : \ + set_vvmcs_virtual_safe(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) + +void nvmx_destroy_vmcs(struct vcpu *v); +int nvmx_handle_vmx_insn(struct cpu_user_regs *regs, unsigned int exit_reason); +int nvmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content); + +void nvmx_update_exec_control(struct vcpu *v, uint32_t value); +void nvmx_update_secondary_exec_control(struct vcpu *v, unsigned long value); +void nvmx_update_exception_bitmap(struct vcpu *v, unsigned long value); +void nvmx_switch_guest(void); +void nvmx_idtv_handling(void); +uint64_t nvmx_get_tsc_offset(struct vcpu *v); +int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs, + unsigned int exit_reason); +void nvmx_set_cr_read_shadow(struct vcpu *v, unsigned int cr); + +uint64_t nept_get_ept_vpid_cap(void); + +int nept_translate_l2ga(struct vcpu *v, paddr_t l2ga, + unsigned int *page_order, uint32_t rwx_acc, + unsigned long *l1gfn, uint8_t *p2m_acc, + uint64_t *exit_qual, uint32_t *exit_reason); +int nvmx_cpu_up_prepare(unsigned int cpu); +void nvmx_cpu_dead(unsigned int cpu); + +#endif /* __X86_HVM_VMX_VVMX_PRIV_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h index 2c3adb5dd6..2bf6ef40e9 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vvmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vvmx.h @@ -22,10 +22,10 @@ #ifndef __ASM_X86_HVM_VVMX_H__ #define __ASM_X86_HVM_VVMX_H__ -struct vvmcs_list { - unsigned long vvmcs_mfn; - struct list_head node; -}; +#include +#include + +#include struct nestedvmx { /* @@ -42,11 +42,11 @@ struct nestedvmx { /* deferred nested interrupt */ struct { unsigned long intr_info; - u32 error_code; - u8 source; + uint32_t error_code; + uint8_t source; } intr; struct { - bool_t enabled; + bool enabled; uint32_t exit_reason; uint32_t exit_qual; } ept; @@ -54,161 +54,10 @@ struct nestedvmx { struct list_head launched_list; }; -#define vcpu_2_nvmx(v) (vcpu_nestedhvm(v).u.nvmx) - -/* bit 1, 2, 4 must be 1 */ -#define VMX_PINBASED_CTLS_DEFAULT1 0x16 -/* bit 1, 4-6,8,13-16,26 must be 1 */ -#define VMX_PROCBASED_CTLS_DEFAULT1 0x401e172 -/* bit 0-8, 10,11,13,14,16,17 must be 1 */ -#define VMX_EXIT_CTLS_DEFAULT1 0x36dff -/* bit 0-8, and 12 must be 1 */ -#define VMX_ENTRY_CTLS_DEFAULT1 0x11ff - - -union vmx_inst_info { - struct { - unsigned int scaling :2; /* bit 0-1 */ - unsigned int __rsvd0 :1; /* bit 2 */ - unsigned int reg1 :4; /* bit 3-6 */ - unsigned int addr_size :3; /* bit 7-9 */ - unsigned int memreg :1; /* bit 10 */ - unsigned int __rsvd1 :4; /* bit 11-14 */ - unsigned int segment :3; /* bit 15-17 */ - unsigned int index_reg :4; /* bit 18-21 */ - unsigned int index_reg_invalid :1; /* bit 22 */ - unsigned int base_reg :4; /* bit 23-26 */ - unsigned int base_reg_invalid :1; /* bit 27 */ - unsigned int reg2 :4; /* bit 28-31 */ - } fields; - u32 word; -}; - -int cf_check nvmx_vcpu_initialise(struct vcpu *v); -void cf_check nvmx_vcpu_destroy(struct vcpu *v); -int cf_check nvmx_vcpu_reset(struct vcpu *v); -uint64_t cf_check nvmx_vcpu_eptp_base(struct vcpu *v); -enum hvm_intblk cf_check nvmx_intr_blocked(struct vcpu *v); -bool cf_check nvmx_intercepts_exception( - struct vcpu *v, unsigned int vector, int error_code); -void cf_check nvmx_domain_relinquish_resources(struct domain *d); - -bool cf_check nvmx_ept_enabled(struct vcpu *v); - #define EPT_TRANSLATE_SUCCEED 0 #define EPT_TRANSLATE_VIOLATION 1 #define EPT_TRANSLATE_MISCONFIG 2 #define EPT_TRANSLATE_RETRY 3 -int cf_check nvmx_hap_walk_L1_p2m( - struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order, - uint8_t *p2m_acc, struct npfec npfec); - -/* - * Virtual VMCS layout - * - * Since physical VMCS layout is unknown, a custom layout is used - * for virtual VMCS seen by guest. It occupies a 4k page, and the - * field is offset by an 9-bit offset into u64[], The offset is as - * follow, which means every pair has a max of 32 - * fields available. - * - * 9 7 5 0 - * -------------------------------- - * offset: | width | type | index | - * -------------------------------- - * - * Also, since the lower range has only one - * field: VPID, it is moved to a higher offset (63), and leaves the - * lower range to non-indexed field like VMCS revision. - * - */ - -struct vvmcs_header { - u32 revision; - u32 abort; -}; - -union vmcs_encoding { - struct { - u32 access_type : 1; - u32 index : 9; - u32 type : 2; - u32 rsv1 : 1; - u32 width : 2; - u32 rsv2 : 17; - }; - u32 word; -}; - -enum vvmcs_encoding_width { - VVMCS_WIDTH_16 = 0, - VVMCS_WIDTH_64, - VVMCS_WIDTH_32, - VVMCS_WIDTH_NATURAL, -}; - -enum vvmcs_encoding_type { - VVMCS_TYPE_CONTROL = 0, - VVMCS_TYPE_RO, - VVMCS_TYPE_GSTATE, - VVMCS_TYPE_HSTATE, -}; - -u64 get_vvmcs_virtual(void *vvmcs, u32 encoding); -u64 get_vvmcs_real(const struct vcpu *, u32 encoding); -void set_vvmcs_virtual(void *vvmcs, u32 encoding, u64 val); -void set_vvmcs_real(const struct vcpu *, u32 encoding, u64 val); -enum vmx_insn_errno get_vvmcs_virtual_safe(void *vvmcs, u32 encoding, u64 *val); -enum vmx_insn_errno get_vvmcs_real_safe(const struct vcpu *, u32 encoding, - u64 *val); -enum vmx_insn_errno set_vvmcs_virtual_safe(void *vvmcs, u32 encoding, u64 val); -enum vmx_insn_errno set_vvmcs_real_safe(const struct vcpu *, u32 encoding, - u64 val); - -#define get_vvmcs(vcpu, encoding) \ - (cpu_has_vmx_vmcs_shadowing ? \ - get_vvmcs_real(vcpu, encoding) : \ - get_vvmcs_virtual(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding)) - -#define set_vvmcs(vcpu, encoding, val) \ - (cpu_has_vmx_vmcs_shadowing ? \ - set_vvmcs_real(vcpu, encoding, val) : \ - set_vvmcs_virtual(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) - -#define get_vvmcs_safe(vcpu, encoding, val) \ - (cpu_has_vmx_vmcs_shadowing ? \ - get_vvmcs_real_safe(vcpu, encoding, val) : \ - get_vvmcs_virtual_safe(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) - -#define set_vvmcs_safe(vcpu, encoding, val) \ - (cpu_has_vmx_vmcs_shadowing ? \ - set_vvmcs_real_safe(vcpu, encoding, val) : \ - set_vvmcs_virtual_safe(vcpu_nestedhvm(vcpu).nv_vvmcx, encoding, val)) - -void nvmx_destroy_vmcs(struct vcpu *v); -int nvmx_handle_vmx_insn(struct cpu_user_regs *regs, unsigned int exit_reason); -int nvmx_msr_read_intercept(unsigned int msr, - u64 *msr_content); - -void nvmx_update_exec_control(struct vcpu *v, u32 value); -void nvmx_update_secondary_exec_control(struct vcpu *v, - unsigned long value); -void nvmx_update_exception_bitmap(struct vcpu *v, unsigned long value); -void nvmx_switch_guest(void); -void nvmx_idtv_handling(void); -u64 nvmx_get_tsc_offset(struct vcpu *v); -int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs, - unsigned int exit_reason); -void nvmx_set_cr_read_shadow(struct vcpu *v, unsigned int cr); - -uint64_t nept_get_ept_vpid_cap(void); - -int nept_translate_l2ga(struct vcpu *v, paddr_t l2ga, - unsigned int *page_order, uint32_t rwx_acc, - unsigned long *l1gfn, uint8_t *p2m_acc, - uint64_t *exit_qual, uint32_t *exit_reason); -int nvmx_cpu_up_prepare(unsigned int cpu); -void nvmx_cpu_dead(unsigned int cpu); #endif /* __ASM_X86_HVM_VVMX_H__ */ -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 18:59:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 18:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501504.773280 (Exim 4.92) (envelope-from ) id 1pVdIC-0001dv-79; Fri, 24 Feb 2023 18:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501504.773280; Fri, 24 Feb 2023 18:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdIC-0001do-4A; Fri, 24 Feb 2023 18:59:40 +0000 Received: by outflank-mailman (input) for mailman id 501504; Fri, 24 Feb 2023 18:59:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVd9O-0001Wv-Sn for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 18:50:35 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e68e05c-b474-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 19:50:33 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id ec43so997289edb.8 for ; Fri, 24 Feb 2023 10:50:33 -0800 (PST) Received: from uni.router.wind (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.googlemail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm10585245ejb.53.2023.02.24.10.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 10:50:33 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e68e05c-b474-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=528hQ/puYwtMp7ly/Urv37WROfXxwGzhdab+4MGW6p4=; b=GqnIbgqjaApSOWWbCN7NXw6lsDgDIHTa/wlKQFJSpx/YudssltgsBQXGtlHhx0ZOyv D17vsOg7oRMOUE/fGafJ4i9P6z7phv/zSJryNyr4RZuBL+Dolq05a+bms716ktN/9/La GN9RHYA3PzUQLUQs22WDBqA9uDHkN9EFcjMQUxvNpcocS9cjR5WgxoEXgEn2Vm70MIRh etuPBC/YlQntawSjVEiixWJR1yhwwHpZcYvr/MVHhe2NCqATLirGGNODqDSH3TIM3BEJ zRz1oRYPkx1g/kZ2EbW1k/Bv0cPFWOIN4+26BAlqZ7LVLUsjydpA7hnx5jF4gOg2Il/z N38Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=528hQ/puYwtMp7ly/Urv37WROfXxwGzhdab+4MGW6p4=; b=xUPE3N6ViAKD9FgKv9OAxdHogp5hMrfDbviqFwhRiVi/Vn9DjR/Mp3ap0rmz+jX6qv h246nVZedzJru51n9WFTPyrX/49fZX/aN4MLCidzLYK2e7H9uvgsQxLTRPd0z/r/6PiD bqNAf+4Othhra12Ro4kGEwOAHsz2DRG2hOaRLjTcxvll6QyzgIVurjIVKhvwir2JSDIf QhKRrxOS4gYPo4Ge90gclSH8IRjqhMvy2badCvLFsWDTC++NMYODPdckdapUVWDjKDpF c3ykynlGDZYC2T5u/ete4VkK3BIf5IWU0KIaatDzeqL8Dl2vrl5eqdTjLPPW8C7Cnkrt NabA== X-Gm-Message-State: AO0yUKV/ngNQnrW5p4QjAQ5GObmMyRVSc9mpaXsAsU5b6l0wnUH55WPA ZTo50Ag96tw/w2A/DfI0gjLGgFwylZE= X-Google-Smtp-Source: AK7set/BvteQN6Ufz1XBNK/qBrZCrW5hJyuGBhGDJthGJhHYKkgYiXxHiNEv0huAJaBUSFy9Pb4oZQ== X-Received: by 2002:a17:906:1d45:b0:884:930:b014 with SMTP id o5-20020a1709061d4500b008840930b014mr22660008ejh.6.1677264633304; Fri, 24 Feb 2023 10:50:33 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v3 11/14] x86/vmx: remove unused included headers from vmx.c Date: Fri, 24 Feb 2023 20:50:07 +0200 Message-Id: <20230224185010.3692754-12-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> References: <20230224185010.3692754-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Do not include the headers: asm/hvm/vpic.h asm/hvm/vpt.h asm/io.h asm/mce.h asm/mem_sharing.h asm/regs.h public/arch-x86/cpuid.h public/hvm/save.h because none of the declarations and macro definitions in them is used. Sort the rest of the headers alphabetically. No functional change intended. Signed-off-by: Xenia Ragiadakou --- Changes in v3: - none xen/arch/x86/hvm/vmx/vmx.c | 56 +++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 31 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index cb8b133ed5..9b009ebcef 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -15,52 +15,46 @@ * this program; If not, see . */ +#include #include +#include #include +#include #include #include -#include +#include #include -#include #include -#include -#include -#include -#include -#include -#include -#include +#include + +#include +#include #include -#include +#include +#include #include -#include -#include -#include +#include #include #include +#include +#include #include -#include +#include +#include #include -#include -#include +#include +#include #include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include #include +#include +#include #include -#include +#include +#include +#include + +#include +#include #include "pi.h" #include "vmx.h" -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 19:29:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 19:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501514.773290 (Exim 4.92) (envelope-from ) id 1pVdl6-0006Y8-I4; Fri, 24 Feb 2023 19:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501514.773290; Fri, 24 Feb 2023 19:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdl6-0006Y1-FS; Fri, 24 Feb 2023 19:29:32 +0000 Received: by outflank-mailman (input) for mailman id 501514; Fri, 24 Feb 2023 19:29:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdl4-0006Xt-Du for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 19:29:30 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c7a71be-b479-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 20:29:28 +0100 (CET) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 14:29:24 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5907.namprd03.prod.outlook.com (2603:10b6:303:6e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 19:29:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 19:29:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c7a71be-b479-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677266968; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=OFro7h0AJZcfednimzLgri+QYxEpuz4UHy0T/n6gh5E=; b=bWEbXWXqbdwUMz0QqYYEanI/vt011p/o8K1TpZafnBSBgfq6WGvitK8W BKyWJmlZ3ZXuutJI04qw6HT2OG2XQO15ex1A53ZELwBxWHtf7GXhxgSZt U4wCuwpESY16eqoE/C6kFv7kxu5/SWOLXalH/NC7uU5KPmvDKmQtMGxFV I=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 98460822 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:p+IeM63Y3Wli8gb04fbD5Tpwkn2cJEfYwER7XKvMYLTBsI5bpzEEy GQZUGnUafjfYjChed8gOY23oU1VusXTnd9rTQZkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfBDxt3 9AReQoxUAGCltPt7J2DFu9ImZF2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFQZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKrBNxKROfinhJsqAKr3HxKLQA5bFimoNCXg3KVYsh8N mVBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/H8pKkjgxSJScxseIa3k9uzHzjzy jKLqSEWhrMPgMpN3KK+lXjEjiytoN7VTwczzgTRQm+hqAh+YeaYi5eA7FHa6bNKKtmfR1zY5 HwcwZHGtKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX742u9OLc70KOWUJJK IronPort-HdrOrdr: A9a23:ObH81qreejEeJ5WjsGUIpmcaV5rreYIsimQD101hICG9Evb0qy nOpoV/6faQslwssR4b9uxoVJPvfZq+z+8W3WByB9eftWDd0QPFEGgL1+DfKlbbak7DH4BmtJ uJc8JFeafNJGk/t+nWyk2TKfFI+qjizEir792uskuEm2tRGt1dBwQSMHflLqVvLjM2YqbQjP Cnl7F6TzzLQwVwUizqbkN1JtQqvrfw5erbXSI= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98460822" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFHEARyaLXPh8RuJgp7Rh5zkejSTa8kL13S2M/bECMcloO5Zgph8mi4TeKWZlwyXoGSTUEt7EQKpRp27iPkRoWfoTdtyOPjbjT2BeigbbB84Q4PbZVMOaJzOhw1bpIAnU8/hq6HEJmlcuAQ6rdt0HHNB/a33DWklSKRSseyzbIr/zfO3AS0Xu9ea+H+xeyCue3TC1/s+sxs5gaqF/IrZl2TUXt2cfVmOcMGPr/UadPgw5a7PvaHjMfMGzQwrihwB2NrSef12wukhI135gefIuVGDyyo5Fg6fqZ7CgTfvdAI0V+3w7/Bfu9HhG4fy7/T0Ckp3nAbFB6ISC2tu6Xgxcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IF72UqMKYtYo7gCbrTF6rw0GunHgKCYG55j2RyMonFc=; b=S2tq12jnyqV7Z/c0+0s44g4cxjEJUme7yHmkckjj9qNzUbmly9DbrjN3EXVjZk7j9voj7JL1E3mv5jubkw6JbcDu8rOIdi5LdtIQ9GvDz35UvRTzJWd/rOlithBnwDLwIgVCVpA4vANeCy/OjZ7P/VA/YnmQmrfxFT/PvI8ep1Ik6144ggYSM1MWPqICgHlypnKICr7X4fu4F1CikEoZL4PciaHtIuvFz3CkrKFkVC6jfHXDA9O7qcQIvwTLq1gkA4UZejYZO7pn2GHSP2D2SzBbcNxvvNSR7yi9H7WZRhhEDmv66YGAC6oVu5DvNw+JwMeW/xfbFkIUl9LT8N+iAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IF72UqMKYtYo7gCbrTF6rw0GunHgKCYG55j2RyMonFc=; b=MtKSjQyNkVYzCcogLitVGW/A1d+Jvnr/EnI0tWzcFJMdWPZWMfnNEnhHwXH/+K4UWV/QE9U57NIHc7HRKOSIFdyLjZ5Dc/BTpETEz3fmyFLJOYsr2Tl+oULvo6IQ2ZBxnWdnAZ0/C1y4NY51eo+aY2qiIf3QMfv8R8dUo/9y32o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 19:29:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230224185010.3692754-1-burzalodowa@gmail.com> In-Reply-To: <20230224185010.3692754-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0059.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO1PR03MB5907:EE_ X-MS-Office365-Filtering-Correlation-Id: 896d71d6-f5d2-46f1-1c6b-08db169d6de0 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RJOE6Nhni7/rfVGfJktkzdqQJrxE38y/W4kmsNV445TaeJaa7conLM26HscsOmlI8Syjxbk/CcxdP46e4Wdzw0j0DJrdADuRbAhkAbtV9YLOFYzR8v72Rk8p7j3w4ac5qfv58bynfTv4ulLVCQFt29C9Ux6CE8b9TQexL6Wj1hRDXx63Qr0IJkg3sakNn3lNnkdL9+N0r+6r/r9YPxZ3DfPy/iTairDMAEb5bWYOK0HfZHwTCB83QEj6fJ/1MNcVzxqhKW3aL6XRDBmHZACS3uNzqu8L5klCwUx+Xljj1+3BhTsW+AW5MlTS6LURfL23VLH2W+ZYqsGG6RCrAUydh7L2XioZIK+30H9xOGhKszri6L7edbO7kk1SouR+vsStIxklzpo6exg2eEmupuZMgGhrkBpGiIixMSxUe2x7dZjdqSpytaBfkoZQ7UvYB/5/Sjv6D72iiTWPiQ7C2d20/pShpJwZycchbX4KkVdnlmeLZRLtdWU1CHlwZpwgxDIF7CNi8QDcbaYMF9Om+q1pRyQWzgn/+ZsUbXXrzutGIK8yBHEKFAP1dJM8cQF76iVON22eyG8fzySBopurl8YfSZYtvXOybQLzx2UG3QHmDtcPag8nvua7kce8SxLg69HyutB6ZgnfTwxnngFVBXYFrByn/tBbXj3BtbbfS6EYjfsZYerW/dimkxpW8WKq/uae5/bfHQvtLQ6h4afE2t/XiM8jCSGkzjNjZLqyBFGHjXo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199018)(2616005)(316002)(6486002)(31696002)(36756003)(86362001)(54906003)(31686004)(26005)(186003)(2906002)(66476007)(4744005)(66556008)(6512007)(66946007)(8676002)(41300700001)(53546011)(6666004)(6506007)(478600001)(4326008)(5660300002)(82960400001)(8936002)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0xUVlJ4emQwWE5IcjFEQUM0MzdlOXJ6WHRsVitDUmRTeWVZR3ZIY2xyYlVN?= =?utf-8?B?akQ3dzc4NWFHa2RvZ3N4amlJY2NQaHIzYUlkVFp2Mml0cGtBTDVlZXBrMkhW?= =?utf-8?B?RVl6U2hIaFdLOFY0SlRRNENzdjBqM0pJaFRmV3NOT2MwK1R6b3A0RkVsV2cy?= =?utf-8?B?Wkx2TE1Rd0d6dHlJSVJXaURVRFMxRkV4TWJkaGFqYnJ5bmVkV1NZalJiUjdM?= =?utf-8?B?N3ZIVks4OE9yR05ITHMwamNxSGljOGljdm9haGlXWTlDUkN5Sm1lV1VrTEkz?= =?utf-8?B?VmdCTXRpUkpQb1hNcW12VTJMTlhicHdCZktKS1FaeU1BbkFNZjlKUEhzWnN5?= =?utf-8?B?blpIY2lmN0s0VVZVU1l2Q3FMMG5CU0grTEVKSVA3OSswSFVlMWRlUWNMYWZk?= =?utf-8?B?Zll1Nk9kN29jeG1Mck9PcUM1T3doSDhvK1djNXZiTEFLWUtpN2JzbzBjaVNW?= =?utf-8?B?Tmdmb3h3dXBVRzlCVEtjQXlWWkVUNEdOK1QwMEg2bytrQURoVzc4ZVlnTHhU?= =?utf-8?B?ek1OcFNNWUk5aEZHNWVDMG1hY3JIQlc1ZFR3cWkvTkQ3WHJYVkU5dm8vNGNl?= =?utf-8?B?WmZhWmEyL0RkbFdtUXZ6a1hBUzJuYnNiSVVIMklIQWhYaGpHU3lDczNOMHBo?= =?utf-8?B?SVlYRklORGNPMzJJZGczUll4WmlTdlVYOTB3S3dpRW9Pc0JkT0ZuNXFrQjZK?= =?utf-8?B?aW5kbFNZdTJDREJ0clE2U2M3T3N5bmFGdDlEZ0RNbFdDak9RUkNzM1hiRENS?= =?utf-8?B?ZTdNbm05RVl5TDRBOStsa1htOHhYT213S1BIWThHRUMwTXZxN211R2RBNkNt?= =?utf-8?B?RHo5Z2tjVGk1Y2JRVkwyN29XaHQrSWxHUzNMdHp6cGdob1ZNakxhOFhiRGph?= =?utf-8?B?OWQzS1dBT2V1MEhkTE83MlhtWk5UcEdRSjFhM2JNeXI3aDk1d2xzNEFCZHV3?= =?utf-8?B?Znh6WmdPbmh5UWNYdHpDbWJaS0pLSzVsTExBNE1jL043ZU12OFh6Snc5SFVO?= =?utf-8?B?SFJqdEtabHhpT1VJQkJ5QzZLVDBBcWV4eTRSbDdKSUFxcEpLMWp3RHJPcmEv?= =?utf-8?B?d2FtSEpPc0J1WTNYc1JLV2dMVXJTZWl3a2ppbkNFcjB4WUNCVUpBQmJyVy9n?= =?utf-8?B?ckZ0SEZ2eUFRMkVZZm1OWkRtOU56bU1TN2xObjdnSStYOXgvTHl5QkcwQUNH?= =?utf-8?B?S0I1UjhKMXZzcm1FaEY5VWs2WWZvVmM1QktMNzRGRks0TTFvQmFwT3FPNmtm?= =?utf-8?B?eDRncGYzaVRsZ1R2SHZXNWVkb252b1FuNVBpZnp3cFFWUE5zaFVjWU1FLzhs?= =?utf-8?B?ZzhGZUJMYUZZUnYraGFQSnJqMEgxK0VsYm00ZWpLQnUxU1gyZEpKZzREOElt?= =?utf-8?B?REhzN08wWVMwM3hRV3NPT0Z3MFlUVTk3alNZY3d6czZxOTdtU3lpSXBWam01?= =?utf-8?B?SWZVaW8vUEJEWmxsSmNocVVZRTJ0Mmo5eDZKV2cyTko3ZjQ3YytwZ21zN1Yw?= =?utf-8?B?UU1vV1VlODV3RFc2WEJqR1lWazB3OXd2ZDFsWUpkTDY3Ym5EeERTeG4vR3ZW?= =?utf-8?B?S2JPbGd0L3dFdzM1WE1yUkx1cHQ2ZjgzRktDclN1WHNxODVyTkpoYm1GeWlr?= =?utf-8?B?cVVaN2JhaE1uWkY0dmxsd2RwRWZMeGRjMTNGamFVWnlFcG01aG5VMnBISzA0?= =?utf-8?B?azA3ckdjc0RwSFBUYnFlZVZNRGt6THBIU24vY0J2YWFKaE5UV0JyRytzOW5Z?= =?utf-8?B?M3VGWTAzbEJzSWxRTzdpZ1E5ZUkwT29TWGdNdWtWcitmd24waU11ZS8wZTJR?= =?utf-8?B?ZHMyVUpVc1o3OUVNR0wycFdKMFZNWDZWbE82TFVwYTdaRDVUU3IzODI3a0VB?= =?utf-8?B?UGhDS2NUcEZFUVRTOW9hZHpoQnlQSk1qS3BaQVoxRGh1TTBhRmNIaFBVY3JE?= =?utf-8?B?ZE50U3NXblg4YkxZa1hhTjlkeGhpWDRWNFVNazBva3c4WkF2R0NuRlF3cjhK?= =?utf-8?B?YkdidTltU1NROHc1TDNRekdBS1ZScEcwanJpS0wvcjZzR2Fta2MzUnA1NE9F?= =?utf-8?B?a0V4cXhnUHZvNUpNNG5TOE5xMlFxSStQczhPcllWRmVFcVY4VGp1NTFVTVM5?= =?utf-8?B?MURCUVIyRUR0TENuWkFYRDdlcXBsRnhBanFGK1hSc3BaalBBQmNhVDdKTmlq?= =?utf-8?B?c1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: e3IRNp+HFslcpuMteg/bbDGp/qJI4MsRXrPo4wiM80uFh1MrzWwh21rxHv60Vxx0H1xkDawslwqx51rgyLmgM73uCFjrl+x/S7WGOqB9LDhz/CM0W7voJeA4UmI6wk93wtbcR3hsYkT4nJ6EErxNFumcTuGH4SsQq41YkiQuxJuSuMtMh6FoQwy8d1L5Z3M+um7iIJ0b4juaKEsl3KLM6rfY9Lsts69x48bHYRVYXTQWM6i/6PCyA9y6Pnta/oMTbDZEIR4SXYMNpGBceQzPDv1viVbprEyRv+LENme/zqmy0LKR+OCmzjSKyTjJ4bNN2mQnJJRQOXCH7N8XMI/AREdkYETVOLbGf/aFDcSykLyI6xh7qtCuj5VgJcYw5aa8fTR1m5rIwVWvJR143S8gNQavCity4+A7JNIUKopn6S0b3qfAFuXYmljZeAMqaKULi5k8rKytybGe5NpP1It226/yVhbVv8RrtRDdOiBID6xGkO0g9wLFm+fiGD2jEx33fJbcJj9YUx58kcgy/5OUueadZlcwdD72V+b/PauuNUDrxbifBCMYmlQFHJ8dMLZe5C/OPkyAfqpbNTogzS8ehefJWOWqOuXsq2vcZ9r4xN+dxGvx9a6RUbAYmisjd45TAtBLC2wv0zP4x/yKyCtT1uwu88Qgmgh0bcxLsf1fKhe8y8iWqY1p+GpsGuZvbTZPCU9xpzwFPCqcn16fmqPKYZOV5cza5YarR6zn03q2kvCmLr6Np2slgaXYcko8pYD9FIr9u+QP4eGWK9iym+kDdL24JbgVYUGpEPcaDEShtsH7gKeO63z0qqkVGEZF24F2vHPcZp6qL6wD0SJRuoaZ2HkSt9jXomvgLt0qf8NZX22e1m/lqMVt5jrxgoybJLkK X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 896d71d6-f5d2-46f1-1c6b-08db169d6de0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 19:29:21.6043 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gkNP3Jp7ipalSN5cVeVnymwRHcRe3P6d5wzAQOlibcYj1UfwAEdBV0tJjnqCnRh0zAP/tSIOJB+RdEX+IHaaJrFsizghU+pRmRyZ03WknpE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5907 On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote: > There are more detailed per-patch changesets. > > Xenia Ragiadakou (14): > x86/svm: move declarations used only by svm code from svm.h to private > header > x86/svm: make asid.h private > x86/svm: delete header asm/hvm/svm/intr.h Thankyou for this work.  I've acked and committed patches 1 and 3. Note that you had one hunk in patch 5 (whitespace correction in svm_invlpga) that obviously should have been in patch 1, so I've moved it. Looking at asid.h, I still can't bare to keep it even in that state, so I've constructed an alternative which I'll email out in a moment. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 19:42:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 19:42:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501518.773300 (Exim 4.92) (envelope-from ) id 1pVdxn-0000wG-MI; Fri, 24 Feb 2023 19:42:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501518.773300; Fri, 24 Feb 2023 19:42:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdxn-0000w9-JP; Fri, 24 Feb 2023 19:42:39 +0000 Received: by outflank-mailman (input) for mailman id 501518; Fri, 24 Feb 2023 19:42:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVdxl-0000w3-Js for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 19:42:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62836878-b47b-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 20:42:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62836878-b47b-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677267755; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BdqtGc6g8VRVqBrNCmDNZDXs+3JRlo/VmvHWh/tPNKY=; b=dfM05GvF8kfUZ0rodyXKOradUs9pq9mQu54OjEi/n2WS/0ELIXWzwtBs h6AWkPUD6hKiqvTZoJrScolA+HgK80p7ZXAYwBxrMxmq+zTj232cB48yB xlkPHFjoOASsGKvufOMGB+LcGGxAG8L1mZckPCufESCeeg6ALGYFkLH73 k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98462222 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:XIUcv6LYH95LMke8FE+R/JUlxSXFcZb7ZxGr2PjKsXjdYENS1zJTz TQbWmiAPq6DZzTzeI12aY3j905V6JKAyINhTAFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AZiPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5wDUtAy a1FAwkrYx2Rtunt0PGAZLNz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TbFZkLxBzC/ Aoq+Uy+PSAiO4Wu9ADb82uHjOvFpSbZZqc7QejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxasnDQRRt5RGO0S8xyWx+zf5APxLncAZi5MbpohrsBebTY3z E2Am9TlAiNmmLKQQHOZsLyTqFuP1TM9dDFYI3VeFE1cvoel+dto5v7Scjp9OKm5pNPJSGzb+ haHoToPjO4DzvUljbruqDgrnAmQjpTOSwc04CDeUWSk8h51aeaZWmC41bTIxa0eddjEFzFtq FBBwpHDt75WUflhgQTXGI0w8KeVC+Fp2dE2qXpmBNEf+juk4BZPlqgAsWgldC+F3ivpEAIFg XM/WysLufe/31PwN8ebhr5d7Ox7pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FLpn2Uy1EWP05kWXeqwIhPVgDnH1W+I8ubcqjk0TPPUS2ORZ5tovpwHPRN7tkvctoUS3e8 spFNtvi9vmseLSWX8UjyqZKdQpiBSFiVfjLRzl/KrbrzvxORDtwVJc8ANoJJ+RYokiivruXo irgAhcFkTISRxTvcG23V5yqU5u3Nb4XkJ7xFXVE0YqAs5T7XbuS0Q== IronPort-HdrOrdr: A9a23:+yKcaalYKA/4GM2nTC8xK7sUcTbpDfIR3DAbv31ZSRFFG/GwvM ql9c5rsiMc7wx8ZJhAo7+90cy7Kk80mqQa3WB8B9aftWvdyQiVxfBZjbcKqgeIc0eSygc379 YDT0ERMqyVMXFKyer8/QmkA5IB7bC8gcaVbD7lvhJQcT0= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98462222" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Xenia Ragiadakou Subject: [PATCH v3 02/14 - ALT] x86/svm: Remove the asm/hvm/svm/asid.h header Date: Fri, 24 Feb 2023 19:42:30 +0000 Message-ID: <20230224194230.2758210-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224185010.3692754-3-burzalodowa@gmail.com> References: <20230224185010.3692754-3-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fold svm_asid_g_invlpg() into its single caller, deleting the #if 0 which has been present for the entire 16 years this helper has existed: c/s 322a078ab140 "[HVM][SVM] Reintroduce ASIDs." Move the two remaining prototypes into the private svm.h, forward declaring cpuinfo_x86 in preference to including asm/processor.h No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Xenia Ragiadakou --- xen/arch/x86/hvm/svm/asid.c | 3 +- xen/arch/x86/hvm/svm/svm.c | 4 +- xen/arch/x86/hvm/svm/svm.h | 4 ++ xen/arch/x86/include/asm/hvm/svm/asid.h | 49 ------------------------- 4 files changed, 8 insertions(+), 52 deletions(-) delete mode 100644 xen/arch/x86/include/asm/hvm/svm/asid.h diff --git a/xen/arch/x86/hvm/svm/asid.c b/xen/arch/x86/hvm/svm/asid.c index ab06dd3f3ae2..150d8dfc8178 100644 --- a/xen/arch/x86/hvm/svm/asid.c +++ b/xen/arch/x86/hvm/svm/asid.c @@ -17,9 +17,10 @@ #include #include -#include #include +#include "svm.h" + void svm_asid_init(const struct cpuinfo_x86 *c) { int nasids = 0; diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 6d394e4fe3bc..46ae0b6602e2 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include @@ -2421,7 +2420,8 @@ static bool cf_check is_invlpg( static void cf_check svm_invlpg(struct vcpu *v, unsigned long linear) { - svm_asid_g_invlpg(v, linear); + /* Safe fallback. Take a new ASID. */ + hvm_asid_flush_vcpu(v); } static bool cf_check svm_get_pending_event( diff --git a/xen/arch/x86/hvm/svm/svm.h b/xen/arch/x86/hvm/svm/svm.h index f700f26f9082..b8178f62161b 100644 --- a/xen/arch/x86/hvm/svm/svm.h +++ b/xen/arch/x86/hvm/svm/svm.h @@ -12,6 +12,10 @@ #include struct cpu_user_regs; +struct cpuinfo_x86; + +void svm_asid_init(const struct cpuinfo_x86 *c); +void svm_asid_handle_vmrun(void); unsigned long *svm_msrbit(unsigned long *msr_bitmap, uint32_t msr); void __update_guest_eip(struct cpu_user_regs *regs, unsigned int inst_len); diff --git a/xen/arch/x86/include/asm/hvm/svm/asid.h b/xen/arch/x86/include/asm/hvm/svm/asid.h deleted file mode 100644 index 0e5ec3ab788a..000000000000 --- a/xen/arch/x86/include/asm/hvm/svm/asid.h +++ /dev/null @@ -1,49 +0,0 @@ -/* - * asid.h: handling ASIDs in SVM. - * Copyright (c) 2007, Advanced Micro Devices, Inc. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - */ - -#ifndef __ASM_X86_HVM_SVM_ASID_H__ -#define __ASM_X86_HVM_SVM_ASID_H__ - -#include -#include -#include - -void svm_asid_init(const struct cpuinfo_x86 *c); -void svm_asid_handle_vmrun(void); - -static inline void svm_asid_g_invlpg(struct vcpu *v, unsigned long g_linear) -{ -#if 0 - /* Optimization? */ - svm_invlpga(g_linear, v->arch.hvm.svm.vmcb->guest_asid); -#endif - - /* Safe fallback. Take a new ASID. */ - hvm_asid_flush_vcpu(v); -} - -#endif /* __ASM_X86_HVM_SVM_ASID_H__ */ - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 19:51:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 19:51:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501527.773310 (Exim 4.92) (envelope-from ) id 1pVe65-0002xm-Ep; Fri, 24 Feb 2023 19:51:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501527.773310; Fri, 24 Feb 2023 19:51:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVe65-0002xf-Bo; Fri, 24 Feb 2023 19:51:13 +0000 Received: by outflank-mailman (input) for mailman id 501527; Fri, 24 Feb 2023 19:51:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVe64-0002xZ-OY for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 19:51:12 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93d9ed52-b47c-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 20:51:08 +0100 (CET) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 14:50:56 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5262.namprd03.prod.outlook.com (2603:10b6:208:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Fri, 24 Feb 2023 19:50:50 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 19:50:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93d9ed52-b47c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677268268; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=dEGrEgzvh+KXhdmODzmXHYdU1IPPQ3aQQ45GA7ydIjw=; b=V+N6iBYIhc4HA9pEDwnpE7qf6wTIjf7VOWJqtZ0oYye/ml9XN8ZeOcau Fs18l8iAbMgWuUCpMjGl9HpK7SLXCD28kteAbUYe9i0l0WQDjgwfNAkhC 7gKzqkmK1IFsy7jhrUgfBUt2mQQKx36q0kK21mCmqEi0DKqi7YmmzMIH0 o=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 97847154 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HLVrCK+3zYrO2l+9XBtZDrUDu3+TJUtcMsCJ2f8bNWPcYEJGY0x3y mcbWGyOa/iPN2L0Ltl0OYm0oB4BvZDWyN8yTQNuqCE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oX5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklx5 b84LSBccCuKivi3mYKxZsp0pP4seZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCd1CSOLhq6ICbFu7300IUjoMTHiCs6OhrXGbAPR/D UAW0397xUQ13AnxJjXnZDWyvWSWtxobV91PGsU17QiMzuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8rzm/JCwUJm8qfjIfQE0O5NyLiJ43pgLCSJBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQ+BhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:74Tslq4XeBoc0qcrmAPXwNnXdLJyesId70hD6qkRc3Fom6mj/K qTdZsgtSMc9wxhOk3I9eruBEDiex/hHPxOkOos1N6ZNWHbUQCTTb2Kg7GN/9ToIVyaytJg X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97847154" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJ0tzZ+WE6l+RYZRvOmJdmk9tyYy7i8TH66sMaJ3ZMjidMXVbVTn/fso+4tx6r/dOXiewgI24TKYkkb2l+2ju80dqc2OZFDf1Od+Od+LGSw8rf1QgMk5Wix/NyZpKpwtZkR+ZsXM6Mykc4I+YfQTRM6kpmt1OkWbf8YB3rey7Rkpy8otSxHOAtD8pkyyC7+L9QHShiJBWsPCR4F7ljpnRIV7Y2ds0yIgQpJGSXIw3DNpRuSP+vzJ7mzjhiGMZSMcYqzkPETpNFFtInlhTYZD5Yloo3tNsHTpQwMu4ws5OYetGausFz5bQtUpJCoZO05ZVYnmtUTcz/jJqCScV5YX5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEGrEgzvh+KXhdmODzmXHYdU1IPPQ3aQQ45GA7ydIjw=; b=gH+LtXQ1XHlQKEc/8MnLpYAYU2D0ds631BV+3rXK/U5GhCWtva6PndmuHwnuzW9tp+RY8qk+BTJEyarZtnrynBtZ96xfGLWbZM9YFMjWL/+jiM+L2GpF52QJRepWkQWpsTMChRKxRg43Pvi4Ws/ixBeGEeOUkKHZbh9sIwzISpGEu1qYyfEByACDHZHt/dnITpjnzIuZtZAMBZQZnelIKNPg4FyQY5Wb9N7hrj8lnvjyO5lj60X15nZWPUHbvZPRzv7nsvZc03k3+32fbFRNDDYn4DaRVxB54O1GS4Av3EhHk76wwczHM+wGp7N9xkVIrq9JQEYK3tH3uub4gY8vSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dEGrEgzvh+KXhdmODzmXHYdU1IPPQ3aQQ45GA7ydIjw=; b=RYZKUeqVErkNu/eVCfaisNqmPCgbm66EYt12gSV2ckCu0Af56m5rK5CpEb2PGuMN/6ZXACpQ8sKbzgWncwf405tdVMB82yhXCcSdoocOkNGjqLrQ1mgWednVkFxOlmjH6JUWUl9DouU42ELhrF3W0YAf0AWUhl+R6H+D2yjceFQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 24 Feb 2023 19:50:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 04/14] x86/svm: make emulate.h private Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-5-burzalodowa@gmail.com> In-Reply-To: <20230224185010.3692754-5-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0256.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5262:EE_ X-MS-Office365-Filtering-Correlation-Id: b96e274a-ee5b-4b13-a472-08db16a06e00 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EcCCNmHQyWmcR3Ae2JhA9v0wKS/3q/quZJZiguNWtvQjg2cTwujjAHU//+IJZ3eZdDLxkjKfePvJwXd0KTMUyqx9EMJ6TDMaGHjUV4EGD+LBDx8XVPQlrjC1vrm+VeKvdqBjRNJAWI+S+wcR1jkEvWgOzcZNq5KAfEf9QZxjYMDxIXCMh5DLn+XjNpwy6/JWeyu+l4HdR6Ro/3kOuwGknTsVDYyh+UGPXXoQdhDDgkp8x5gtbpwYAXB6y++KXej3ttsk7yWJ4rtiRdi0ph3ZGBmH13qTbncHUvbQ+h1j0Ucl4miC5jiYq/j98juwxjru/wvYPpAjoLazo438HvngbF4tEb/UaGFqEjdEGPFei+Eoqmw7eSbsR4pM5sQMzQeO7+ft+l1v2LDDZTYxTktDCapRl2BQhNl2tppDL3hcAAhnC7IRsDh0kl3odaaryw6zGY7PZCkNz72GVF2UfGDVCJ89IO/XWLG2LrrQVPWO5ILnG6H6E5tJXKQSHTlyNH98xAcClxAL1DPz6yIszQ0L6cYzfx+pQr5YrznIjYmYKKtvo0mk3KhrL0dN11oiXExJ2fPAWIhqIgJohvRfmJHa6jBI6lvU7xoZzmAb+UNtgRl9uGp9uSXrsxhdgY2MmstVyw5Ab7gGcsrXWL2lCvyJAXgGZXtmNtxJ5L/N7g8fkM2Mxp8octJIB3qLmhKvcnoFznSNvlcsr/G7lqGuKqVe52TuKIupTrUJ0J55xg9N4o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199018)(53546011)(66946007)(2906002)(5660300002)(186003)(38100700002)(6512007)(6486002)(26005)(6506007)(82960400001)(8936002)(31686004)(6666004)(2616005)(4744005)(478600001)(4326008)(41300700001)(316002)(86362001)(66556008)(31696002)(8676002)(36756003)(83380400001)(66476007)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG91Q294R3Z0bjZZRXpJd2hscGhCUjE0cDNDalRidE80RHMydU14WndwT1Bj?= =?utf-8?B?SHA4dHU1TG5VU3ZJcGMwNnlZalZYVVNReDZKNHpubkxXTFp1Rm5Ub0hVM2tY?= =?utf-8?B?MUZBVjlOQWlWQWNHUUdNaE9HbEpydVJ2R21jY2VpdDRqK3hoSWpLRllSS29E?= =?utf-8?B?S1c1NXF0amZ6M0IveVhwa0k2VjlyQUMrNDlma2l3TzlUZk04MjVnUXlBZ3Ru?= =?utf-8?B?aW5CU1Y5b1VnWnA1elVnajlRdVZ1bFNwOWh3NFF0bUo0eUhjM0thUGxzRi9H?= =?utf-8?B?dUJXQjhtUHZNc1ZuKzdIakJvNUtpcGNCaDdJSGM4YTYrSkhoWXVYTHhCaEU1?= =?utf-8?B?ZC9kbEUwZkNMdzdoN0czZ3pxSHFxN242aTB6azVQb1Q1L1ZpYVZLN2xPYlNM?= =?utf-8?B?VDJBdVIybHZoUitmQzAwU2lRQ0xmTlYrRW1kMnMwdDMwWWc3eitpbjIrQkRI?= =?utf-8?B?eDNuUjZhcU1MTlFTdjI2YUpiaDdvdmluZU43elB5Y2xxR2k4dDlRa0xvVW9q?= =?utf-8?B?SC92VkhCdWVXN0hNV2dubFVUQ1ZuME04NnlsRUtYK3dtei9YUGF4UHlWZjZO?= =?utf-8?B?c3VvK0NEQ2FUUDFxTHVFUHUvc3c5eEZkR0lPRXM2S3Ivc01wV1FpN2JudWFr?= =?utf-8?B?ejVxZ252Q2pwZlFyN0o5NzFLQ3U3T3pSVENuWlU2VkdnQXRrSjdBT09TbUJ6?= =?utf-8?B?RGZGcmc4Yk00R3cwejdwVGNXZnkwMTI0dHR5Z0pueU54RCt6OEVQVGwrckN4?= =?utf-8?B?Q3lVRm9VM04wUVFuSC9GcG1MVGdaalIva0EzZHBpY1NhWHd1V2swQ0NUczlR?= =?utf-8?B?RldNV2pVQ1p3WC9OQU1iY0xER1BDdEdKSExZcGtOVytXejFiSktBd2ZkSWln?= =?utf-8?B?Mmh5TlV0cnJuQllFWnA3S1oyamR1KzZ1THoxQmNmc3pROFgxRW5FK0o5enNK?= =?utf-8?B?Z0ZZR1Z4R251dVlUdjU5NVNrRkdqdTkrbTF0eTd3c1liU1BjRjRoQnpYY0dt?= =?utf-8?B?N0NlRWlTbkIrUlQ5N2gyeElsYTlzVHBEcmtZUUhhSnEvdFNOWHpBcll2QVRS?= =?utf-8?B?a0d5VmYzZVB2Nld5WURpQUlTOE1RQmZmUW9kNkpRakZWK2ZtZHpRTjRVSS96?= =?utf-8?B?QVdwTVM3dEZLcjNNbHY5VjE5eER1VmJLRHZocXpKR1V4dGkvcmt4M1ZpSEJy?= =?utf-8?B?NHFqbUF3TUZOOUZRS1FkRHlQMWtIQjRWL2tjTFloRHZjNmwzTUwrck9GR2Nv?= =?utf-8?B?K3ZTd1h4VVA5VDZadjFlMHJ4eW1POW0rNi9nNWdaaUJld1FtWWtYMjUzcUpa?= =?utf-8?B?ZkpNWlNVL1c3V0RSQVFBS2daWlNZUDVvWEJ0ai9VWUZOTTVrS0Nwa1hWSzFO?= =?utf-8?B?T09sbHZoT1J2UmNyYS96dEJ6QkNrNFp1dDAyTVJhVUt0WTVZalpVMFhrRnA3?= =?utf-8?B?MUluZDl1aGw1TGpCSm9CcUVsc0Y2M2l0ajNzRytJaXJ0OUkyUmlqRSsxd01u?= =?utf-8?B?YjlxcmVFVWRsSUEyeTBxQjFBUVBuTmkvaFNFT1E5YXk2Q242clJzZ21YUGNo?= =?utf-8?B?Zklndk5KcnZaa3VNY21XdkFnSnNNbmtvcElub2w4Z0l6aXpJM1I5RDVKR2hr?= =?utf-8?B?QWtpTzEzRlhSTlUrK0ljdFBZYytFVEIzV0hYcTBzS3JFV1FscG9VQVdHbW1L?= =?utf-8?B?b3QvK3hNdDBiN01UK0hFVEpwOTducmhoeElzaGswTnhiejcrZFYyTUpKc0pC?= =?utf-8?B?RTB0TDB3U255ZW1wc0dYUExOYk1Vb29HdTk5a2VGL3B2elIvVXl0NENsMXIr?= =?utf-8?B?ckF1c3lSZ1pPZG1ORmM5cFFUOC9hOVV0MEZBQkUwcXN5QXd0bXFTRHc1MFpF?= =?utf-8?B?NjVlYmpXVzFOeGFYaWhpUVdSSzF0OFErNE9nYksvbCtoU3JxcDQ5WHBXY01a?= =?utf-8?B?SWI4bnlzR3Z3bXpMbDJoZkw0Z1BEMW1HWEsvYzlHWTJEeEVDaHRLV0NYNERI?= =?utf-8?B?RVJ1TVh5VEpKanYwOVhnQlpMOGV3RGxoQys3a3Q5WlFtVC9PQ3FzRFFkdWpH?= =?utf-8?B?OThCTWZ3cU9EVUNLK1JNOXdHclkxVzc2c0d3Ny9lb0U1ZS8wMUZPYzBpZC9H?= =?utf-8?B?WTJONHZlWWJQT0pqekZVOWlKemFDS3JPWU43Y2VMT1d2MzlRbUE0ZE55RVVh?= =?utf-8?B?UEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fUq+eJXeAyaKlZKMfLiYPw6rSJoADhbttNIKpbGvsLu8MnpoH49xJmQ5GEsoXgeSf5t5SN3bNCVuYxwI3EDtsGGt5SiyTv/zt37uam5gc4cgIwip2czwNVzNXKDqB/YZdR97w4LlXJCoc9toWipzhUhta/L1u3x2OiCaXIKVfaWAA2/lQayXM+G9xT2FTiyXfqWYlAiWSkjeZtajdB/NHH/WmZ0lfMsVBuyrKkUiM+NCYVS+kiT9V5jIoPSFJ7JGoGo/K8eTwShspxu8GIt6cwz6jSEilISnEr9I5e7cywUI5i/DjX5xTD8+w6EpoqzMKl08qF2Wc9Bfd7zwq2EfZkckjlTcx0ikn0+TJ9saRvtHWhOmiLPjrjpV/k4d+GtC/Cw4LyVZI+LNkzr96YP1Ecivg147JNpIadWQD06vQpjAFPNOqDx0wb0ky+C1ctaYyXCGOk3057i8jNyv2yvsJw3BoULkbjpnT5b+mw7VJkh0gRUt+nZqWN3wpBcxmn/Xt7qzG7v3YaDl1RAjJ7Wl+EvHWRi+IuDFmjCOL3DhKgBPJY9fU+q/uLYhi57Yf9MFQ+x2Laabx8bITysS8ttZSzWIZR9S9hNcZr6Ehvj2uhs3LX9Yny21j95vrrRXU5+1eIvoK+x7hFUoVcMbKsGAnWKiAkVzKyPLLzz+S8AiAPdM6qFBMuLL7SfnBX2UcF4P3x1EGIyoysC/+AT1p6hulY4lqUNp/ScHHyIuY1OKkanAyW6tvS94rKxGssnoJS1Xtkjif0klqI35kkLddgjb7lR3rpg+8aaFl3FzlB4i+z2GF6oVEROJfwBY95+Wt+sEvQ3VzRQRyEusc3OKT4zGdsoow0nP01EoateTTRoUf+o= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b96e274a-ee5b-4b13-a472-08db16a06e00 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 19:50:50.2139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IDnNhnUdVBiIsfpK7JcfB1Nqgujx6+l8Vhm0m49pJmUXzGVYe7zijqFJIUzxUhRUiAMADYNa/yci9H5Qw9OSCnRLXUOIqjI9omsX5i4rdxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5262 On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: > The header asm/hvm/svm/emulate.h is used only internally by the SVM code, > so it can be changed into a private header. > > Take the opportunity to use an SPDX tag for the licence. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou The name emulate.h is rather stale now.  We used to have a full ad-hoc x86 emulator in emulate.{h,c}, before the work to use one single emulator (rather than the 4(?) we had at the time). Nowadays, it's just the the instruction length helpers, which you can see are wrappers around x86_insn_length() which is the main emulator. Given that it's now just two function declarations and a few constants for the instr_enc field, it would be better to just move them into the private svm.h (like I did the asid declarations) and remove the header entirely. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 19:59:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 19:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501534.773320 (Exim 4.92) (envelope-from ) id 1pVeDg-0004AO-Au; Fri, 24 Feb 2023 19:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501534.773320; Fri, 24 Feb 2023 19:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeDg-0004AH-7q; Fri, 24 Feb 2023 19:59:04 +0000 Received: by outflank-mailman (input) for mailman id 501534; Fri, 24 Feb 2023 19:59:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeDf-0004AA-Hk for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 19:59:03 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aba2c2d8-b47d-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 20:58:58 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aba2c2d8-b47d-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677268738; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PI+v5Dw4mRi5sdZsaH2koVPYCg9fqaOuR5R8xbwq2f0=; b=g8o7vptxZOarXlZ5mh5APJTwSAKRuBTGg3nvnlt/kL1DTnc+m8X/DHJP Z3u0Z4907yLrTjMIwffZ+T16u9PNssdC+s7zMcVT8ndZUr5lzISteRnnq IzByxSO7XxmJI4EJ5ihBVO65g2t53uDHcuvoIBnxuatOIfIbl7R/dPnUq 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 100887586 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:C74hTq5suHP9cXBIgTGkVwxRtCDHchMFZxGqfqrLsTDasY5as4F+v mYaC2rQPP/ZYDbyf9B0bNzg9x5XscWHmIAxSQo4qXpnHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4AeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mx KZGBwAAKUG6tsWHmeKKU7VOlM4CBZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9xx7A9 jKZojSnav0cHILG6CuAtXKHv8KMtyTZUbkwSuaT0PE/1TV/wURMUUZLBDNXu8KRqGSzRtZeI Ew84Tc1oO4580nDZtPgRQ+xpHmIuQEVc9VVGuw+rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bv0iRYeZuV/+Mv/rEQGHB2 myoviIfruBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWW0C KMwkVkLjHO2AJdNRf4fXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZzzvthY snKKJjxUh727JiLKxLsGo8gPUIDnHhilQs/u7imp/hY7VZuTCHMEupUWLd/Rus48LmFsG3oH yV3bqO3J+FkeLSmOEH/qNdDRW3m2FBnXfgaXeQLLL/cSuencUl9Y8LsLUQJK9A1wfQNyb6Sl px/M2cBoGfCabT8AV3iQhhehHnHBP6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:gyjosKGndcXdrgoVpLqEi8eALOsnbusQ8zAXPiFKKSC9F/byqy nAppkmPHPP4gr5O0tApTn/Asa9qBrnnPZICOIqUYtKMjOJhFeV X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="100887586" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Xenia Ragiadakou Subject: [PATCH v3 04/14 - ALT] x86/svm: Remove the asm/hvm/svm/emulate.h header Date: Fri, 24 Feb 2023 19:58:47 +0000 Message-ID: <20230224195847.2762464-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224185010.3692754-5-burzalodowa@gmail.com> References: <20230224185010.3692754-5-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain These days, this is just two length helpers. Move into the private svm.h No functional change intended. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Xenia Ragiadakou --- xen/arch/x86/hvm/svm/emulate.c | 3 +- xen/arch/x86/hvm/svm/nestedsvm.c | 1 - xen/arch/x86/hvm/svm/svm.c | 1 - xen/arch/x86/hvm/svm/svm.h | 33 +++++++++++ xen/arch/x86/include/asm/hvm/svm/emulate.h | 66 ---------------------- 5 files changed, 35 insertions(+), 69 deletions(-) delete mode 100644 xen/arch/x86/include/asm/hvm/svm/emulate.h diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c index 16fc134883cf..391f0255162e 100644 --- a/xen/arch/x86/hvm/svm/emulate.c +++ b/xen/arch/x86/hvm/svm/emulate.c @@ -24,7 +24,8 @@ #include #include #include -#include + +#include "svm.h" static unsigned long svm_nextrip_insn_length(struct vcpu *v) { diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index a341ccc8760e..c0b5474756f4 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -17,7 +17,6 @@ */ #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 46ae0b6602e2..97783b7f1118 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -37,7 +37,6 @@ #include #include #include -#include #include #include #include diff --git a/xen/arch/x86/hvm/svm/svm.h b/xen/arch/x86/hvm/svm/svm.h index b8178f62161b..d2a781fc3fb5 100644 --- a/xen/arch/x86/hvm/svm/svm.h +++ b/xen/arch/x86/hvm/svm/svm.h @@ -13,6 +13,7 @@ struct cpu_user_regs; struct cpuinfo_x86; +struct vcpu; void svm_asid_init(const struct cpuinfo_x86 *c); void svm_asid_handle_vmrun(void); @@ -43,6 +44,38 @@ static inline void svm_invlpga(unsigned long linear, uint32_t asid) "a" (linear), "c" (asid) ); } +/* + * Encoding for svm_get_insn_len(). We take X86EMUL_OPC() for the main + * opcode, shifted left to make room for the ModRM byte. + * + * The Grp7 instructions have their ModRM byte expressed in octal for easier + * cross referencing with the opcode extension table. + */ +#define INSTR_ENC(opc, modrm) (((opc) << 8) | (modrm)) + +#define INSTR_PAUSE INSTR_ENC(X86EMUL_OPC_F3(0, 0x90), 0) +#define INSTR_INT3 INSTR_ENC(X86EMUL_OPC( 0, 0xcc), 0) +#define INSTR_ICEBP INSTR_ENC(X86EMUL_OPC( 0, 0xf1), 0) +#define INSTR_HLT INSTR_ENC(X86EMUL_OPC( 0, 0xf4), 0) +#define INSTR_XSETBV INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0321) +#define INSTR_VMRUN INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0330) +#define INSTR_VMCALL INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0331) +#define INSTR_VMLOAD INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0332) +#define INSTR_VMSAVE INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0333) +#define INSTR_STGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0334) +#define INSTR_CLGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0335) +#define INSTR_INVLPGA INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0337) +#define INSTR_RDTSCP INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0371) +#define INSTR_INVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x08), 0) +#define INSTR_WBINVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x09), 0) +#define INSTR_WRMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x30), 0) +#define INSTR_RDTSC INSTR_ENC(X86EMUL_OPC(0x0f, 0x31), 0) +#define INSTR_RDMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x32), 0) +#define INSTR_CPUID INSTR_ENC(X86EMUL_OPC(0x0f, 0xa2), 0) + +unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc); +unsigned int svm_get_task_switch_insn_len(void); + /* TSC rate */ #define DEFAULT_TSC_RATIO 0x0000000100000000ULL #define TSC_RATIO_RSVD_BITS 0xffffff0000000000ULL diff --git a/xen/arch/x86/include/asm/hvm/svm/emulate.h b/xen/arch/x86/include/asm/hvm/svm/emulate.h deleted file mode 100644 index eb1a8c24af6d..000000000000 --- a/xen/arch/x86/include/asm/hvm/svm/emulate.h +++ /dev/null @@ -1,66 +0,0 @@ -/* - * emulate.h: SVM instruction emulation bits. - * Copyright (c) 2005, AMD Corporation. - * Copyright (c) 2004, Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms and conditions of the GNU General Public License, - * version 2, as published by the Free Software Foundation. - * - * This program is distributed in the hope it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for - * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; If not, see . - */ - -#ifndef __ASM_X86_HVM_SVM_EMULATE_H__ -#define __ASM_X86_HVM_SVM_EMULATE_H__ - -/* - * Encoding for svm_get_insn_len(). We take X86EMUL_OPC() for the main - * opcode, shifted left to make room for the ModRM byte. - * - * The Grp7 instructions have their ModRM byte expressed in octal for easier - * cross referencing with the opcode extension table. - */ -#define INSTR_ENC(opc, modrm) (((opc) << 8) | (modrm)) - -#define INSTR_PAUSE INSTR_ENC(X86EMUL_OPC_F3(0, 0x90), 0) -#define INSTR_INT3 INSTR_ENC(X86EMUL_OPC( 0, 0xcc), 0) -#define INSTR_ICEBP INSTR_ENC(X86EMUL_OPC( 0, 0xf1), 0) -#define INSTR_HLT INSTR_ENC(X86EMUL_OPC( 0, 0xf4), 0) -#define INSTR_XSETBV INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0321) -#define INSTR_VMRUN INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0330) -#define INSTR_VMCALL INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0331) -#define INSTR_VMLOAD INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0332) -#define INSTR_VMSAVE INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0333) -#define INSTR_STGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0334) -#define INSTR_CLGI INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0335) -#define INSTR_INVLPGA INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0337) -#define INSTR_RDTSCP INSTR_ENC(X86EMUL_OPC(0x0f, 0x01), 0371) -#define INSTR_INVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x08), 0) -#define INSTR_WBINVD INSTR_ENC(X86EMUL_OPC(0x0f, 0x09), 0) -#define INSTR_WRMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x30), 0) -#define INSTR_RDTSC INSTR_ENC(X86EMUL_OPC(0x0f, 0x31), 0) -#define INSTR_RDMSR INSTR_ENC(X86EMUL_OPC(0x0f, 0x32), 0) -#define INSTR_CPUID INSTR_ENC(X86EMUL_OPC(0x0f, 0xa2), 0) - -struct vcpu; - -unsigned int svm_get_insn_len(struct vcpu *v, unsigned int instr_enc); -unsigned int svm_get_task_switch_insn_len(void); - -#endif /* __ASM_X86_HVM_SVM_EMULATE_H__ */ - -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * tab-width: 4 - * indent-tabs-mode: nil - * End: - */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 19:59:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 19:59:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501536.773330 (Exim 4.92) (envelope-from ) id 1pVeDv-0004Y4-K3; Fri, 24 Feb 2023 19:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501536.773330; Fri, 24 Feb 2023 19:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeDv-0004Xx-HT; Fri, 24 Feb 2023 19:59:19 +0000 Received: by outflank-mailman (input) for mailman id 501536; Fri, 24 Feb 2023 19:59:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeDu-0004UE-C3 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 19:59:18 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b884456e-b47d-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 20:59:17 +0100 (CET) Received: by mail-ed1-x532.google.com with SMTP id da10so1797819edb.3 for ; Fri, 24 Feb 2023 11:59:17 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.138.tellas.gr. [109.242.138.185]) by smtp.gmail.com with ESMTPSA id z26-20020a1709064e1a00b008b95c1fe636sm8930929eju.207.2023.02.24.11.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 11:59:17 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b884456e-b47d-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=umiL4hWI5T7jCbJChxD9By9qs5yCMLRWtMXBcLNgMbg=; b=eoXIqOX1Tp528EJL8BYyXxvXXez/Jwm8W674ViFrImYNAWo+hb9SYs5opSNEYMgtLy 96MNZw09OntnsZQb6cDTrPWrMX1bdNuA4uO/0AHA09Lp0r2pBj2Gnl8+GNhES6KWqUB+ l7wKgZb7NJPQkq9v6H68xkzrZseIi37jWbwth+vbFbPBUuoSw3/PVPHsd0k8yeKe+hOK BU6dUkFdonZiRVHz0Hg4YrumLFn7tXZqq220O2TX6ivmLnSzrp0Gh5LgbgLT81LauZN8 OZSXFZIHkQCak/4j37IfRwAbPkn7Jfr3Rqs6lRHvOHp8leEX2xYtm5qhv7Zbwevx+0jD /9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=umiL4hWI5T7jCbJChxD9By9qs5yCMLRWtMXBcLNgMbg=; b=INfwazJusZMm2JGxLoC+hdfrflpYK6uU8Nd3tiLEH2iczYiVkBM2SzpV8K6vFnq8A5 Ry5FG5wrOuF6PrlbYm/fFsNEpJBHDOQDlc/GRroiYnkJfkE1CBFxY2lBCYsJxlYys916 bV3n+AIQQCHrVq/KDSO5y5Q9Xq/dyHOeYp7HT4zFkIOQPjYgGfcPrrbYPXsV/oxdyiVa 5k/XdK7W9lr8621hlBTK1hZaZGjsspJYbNIC5tdEe461tFxmSKybYrQMyhKyX2fAhwPR RKkB0xRy/MT/JirPJdGO0ln+NqlQVwYZpVbz5Kdh03/cGVp2f3V/xF0btTkJ2/eLBG7n 2PfQ== X-Gm-Message-State: AO0yUKUY/dDMkyeYQ18KJvKq7G1NP7W5c8AG+f5gSIf6sZaeLdOZCNPx LhDvzKhmoVbGK2ukgIx671jVIP0NvFY= X-Google-Smtp-Source: AK7set9VZPxXqralMuGYw7MVFxT5q7INWTjtbS+TYcA9EZsqPuo+Qkp/pb58YtNeSldgeOIE0WKueg== X-Received: by 2002:a17:906:4550:b0:8b1:7ae8:ba6f with SMTP id s16-20020a170906455000b008b17ae8ba6fmr27622054ejq.16.1677268757295; Fri, 24 Feb 2023 11:59:17 -0800 (PST) Message-ID: <515d438b-0638-060d-d0c3-229f47f65762@gmail.com> Date: Fri, 24 Feb 2023 21:59:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 02/14 - ALT] x86/svm: Remove the asm/hvm/svm/asid.h header Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-3-burzalodowa@gmail.com> <20230224194230.2758210-1-andrew.cooper3@citrix.com> From: Xenia Ragiadakou In-Reply-To: <20230224194230.2758210-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/23 21:42, Andrew Cooper wrote: > Fold svm_asid_g_invlpg() into its single caller, deleting the #if 0 which has > been present for the entire 16 years this helper has existed: c/s 322a078ab140 > "[HVM][SVM] Reintroduce ASIDs." > > Move the two remaining prototypes into the private svm.h, forward declaring > cpuinfo_x86 in preference to including asm/processor.h > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Xenia Ragiadakou From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:04:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:04:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501544.773340 (Exim 4.92) (envelope-from ) id 1pVeIY-0006H3-6N; Fri, 24 Feb 2023 20:04:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501544.773340; Fri, 24 Feb 2023 20:04:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeIY-0006Gw-35; Fri, 24 Feb 2023 20:04:06 +0000 Received: by outflank-mailman (input) for mailman id 501544; Fri, 24 Feb 2023 20:04:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeIW-0006Gq-If for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 20:04:04 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6245af14-b47e-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 21:04:02 +0100 (CET) Received: by mail-ed1-x52f.google.com with SMTP id eg37so1644854edb.12 for ; Fri, 24 Feb 2023 12:04:02 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id w18-20020a50d792000000b004af720b855fsm88757edi.82.2023.02.24.12.04.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 12:04:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6245af14-b47e-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0A3Um1lvGw9ad7leL/bytGGZ60GVzQoDPB4UpXIlpbU=; b=Uo2a/xQBhTjfhu1Jq6jjVoSdPG8TU4mTZ4YWNAVWebpSTOKDuQu1eVRTOXxwejP67n 6rwT7L/evVZFuT5bzDpz3/zE7F6pxSpDUBlejvSn8Yr2FvXiY6BT0On6tp0pUSH0ogKX VYYGAgwNNfYIA7dTAB0Mswo7vMe/poACXmn2avfqOfqW7dHyxDTATlLc/LZpB0j7bOzO ybkN3YVIi0Yt24tlqQsMFPiOSoAE4ZqyOKZRqGjGyB4Ud01ZO22XN/XRUx217aC/YkTF B49tCr85Ekx5xW3Eo2ttA6pl9E9gRR8eDIEYIoL2a/fE3vZClsdtriyYBrIljpRtR/9O GZvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0A3Um1lvGw9ad7leL/bytGGZ60GVzQoDPB4UpXIlpbU=; b=Az3qujbpkUWFoM1Z1+b2zHC1as9IowNmSjMwbzjkRstxRVoz6IPgCW2JZBZ8tt/b5d G37GKnS/7wQZsqEnyPSL2pqKLkQaeO482+/RdWH85f6S2WoQfzu3yVr235z95Cev6CDN auECg+xT0vs/Qfx+mC34hmvih1e0nG6WmrmvBcMpsV7FJg7LK8AWrnNLOl7/tSi6dgt7 dW73QNebk/Zuxu47PLn8G6zXf96pCxqerpFkTD7O1nc3AJF3KN5AJzFzGstXDdEhBKjA /kqMmNE9o/UWr9EGuXWGnRXJ1jl8hD+QY72hjXgCeH/NqIDP48SrZoz5sI315cbe1cgF xXmA== X-Gm-Message-State: AO0yUKX4TCSfhLlMUq8tLlSvQu0GUQXOXITfJ75USXMHcLrH25m3Ap0t 79/vo3KYAPsDAc8YYA4NdQ4= X-Google-Smtp-Source: AK7set9CGw+aqlBqHJ8GbX9tp0e/2wBqU0yj9aZAIVpljF5ZGNxOvf3lJr1PomcZGvz9eHE6sLR17Q== X-Received: by 2002:aa7:dada:0:b0:4af:6a7e:9286 with SMTP id x26-20020aa7dada000000b004af6a7e9286mr7317704eds.6.1677269042279; Fri, 24 Feb 2023 12:04:02 -0800 (PST) Message-ID: Date: Fri, 24 Feb 2023 22:04:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 04/14 - ALT] x86/svm: Remove the asm/hvm/svm/emulate.h header Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: Jan Beulich References: <20230224185010.3692754-5-burzalodowa@gmail.com> <20230224195847.2762464-1-andrew.cooper3@citrix.com> From: Xenia Ragiadakou In-Reply-To: <20230224195847.2762464-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/23 21:58, Andrew Cooper wrote: > These days, this is just two length helpers. Move into the private svm.h > > No functional change intended. > > Signed-off-by: Andrew Cooper Reviewed-by: Xenia Ragiadakou -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:08:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501549.773350 (Exim 4.92) (envelope-from ) id 1pVeMq-0006uk-Mc; Fri, 24 Feb 2023 20:08:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501549.773350; Fri, 24 Feb 2023 20:08:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeMq-0006ud-JY; Fri, 24 Feb 2023 20:08:32 +0000 Received: by outflank-mailman (input) for mailman id 501549; Fri, 24 Feb 2023 20:08:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeMp-0006uV-96 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 20:08:31 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01e55015-b47f-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 21:08:30 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id f13so1816622edz.6 for ; Fri, 24 Feb 2023 12:08:30 -0800 (PST) Received: from [192.168.1.93] ([188.73.239.185]) by smtp.gmail.com with ESMTPSA id gc20-20020a1709072b1400b008d85435f914sm6197031ejc.98.2023.02.24.12.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 12:08:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01e55015-b47f-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nEPyyov4+/6ertWA3DKmR9y7axROyN9YMZttew1AM9E=; b=od7ioC7pP+UhpJyxqInOwLAUX1N4+LRekgYRDK2XChtZFQ7vNGVWq2sssehPwtsJbV MogOWkg3Br5pSiZsX9eDnumWsQ3o1HTM1GZiVfV2DyfN0W1sG1uOiXJSpr5i1QoR56JY Tz53lwwZansMHsJflAH+JcLXJV/IAqWCTMXamea4V949qImMz4U38yX13LyyY2wTLJr0 LEzDwpzvvwG4JBXe7+bfwZS+jaoeRzEXDf4BvTolprvtvVao1wpR4IS01iP9rgZOPI3z fk414hyWdCsPawKraxLEAatDvMk2rHqTfiLx6OeBvrfrlxYQnv+ZFl1ePnyQ/uSg/pfe BsAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nEPyyov4+/6ertWA3DKmR9y7axROyN9YMZttew1AM9E=; b=qd9P1Z3k35oteFyVxf7PqYFVnGL8qc8EBkvn7yC3A0SgI4Iu3cOOeKtE1m2UQQEzjm GO7Kz4AelFBLVRISsxGCwkJ5G1BOcT5o4rB+YpJbI1NBJ6+29vphNvp0NGupTVWyVFGf u5PgvINfi/EO1RGczEN+pPXDdCqby2mz6OsjGZggItDjOKofV/70stm5j5c25gwRR+cI cQm+yH+1ima+nbTqLPA/mhuYd36je1I7wemM7X/XGbhs8pcTMjNAwBO6mzQMuPEF7w3J Z/o5M+2w7w6qffpLVQClva7cVlFpFI3LG7uroe0GRil7uJpgn+MHgIEKTxMau9nwsgsp Sy6w== X-Gm-Message-State: AO0yUKWyYrpyIbo7kCV+3K1ATtebxifxehppKD6sDU5WV2XjWE/pOnlz R+GETG0TwFg4NwEARHTE0DQ= X-Google-Smtp-Source: AK7set+wjnX8Dsj2cRpQGTKgKkmZpJJFezDzsmCitsibqzu0ZI6NrPY1QaN3RFysLBrM+m4RmW+NWQ== X-Received: by 2002:aa7:cb57:0:b0:4aa:a51a:7380 with SMTP id w23-20020aa7cb57000000b004aaa51a7380mr15637995edt.0.1677269309999; Fri, 24 Feb 2023 12:08:29 -0800 (PST) Message-ID: <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> Date: Fri, 24 Feb 2023 22:08:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230224185010.3692754-1-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/23 21:29, Andrew Cooper wrote: > On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote: >> There are more detailed per-patch changesets. >> >> Xenia Ragiadakou (14): >> x86/svm: move declarations used only by svm code from svm.h to private >> header >> x86/svm: make asid.h private >> x86/svm: delete header asm/hvm/svm/intr.h > > Thankyou for this work.  I've acked and committed patches 1 and 3. > > Note that you had one hunk in patch 5 (whitespace correction in > svm_invlpga) that obviously should have been in patch 1, so I've moved it. Thanks, I missed that ... > > Looking at asid.h, I still can't bare to keep it even in that state, so > I've constructed an alternative which I'll email out in a moment. I 'm also in favor of less headers. > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:13:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:13:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501554.773360 (Exim 4.92) (envelope-from ) id 1pVeRB-0000Oe-7U; Fri, 24 Feb 2023 20:13:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501554.773360; Fri, 24 Feb 2023 20:13:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeRB-0000OX-4U; Fri, 24 Feb 2023 20:13:01 +0000 Received: by outflank-mailman (input) for mailman id 501554; Fri, 24 Feb 2023 20:12:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeR9-0000OP-MD for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 20:12:59 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a07e47aa-b47f-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 21:12:58 +0100 (CET) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 15:12:55 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6073.namprd03.prod.outlook.com (2603:10b6:408:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 20:12:52 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 20:12:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a07e47aa-b47f-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677269577; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=oNq/zxWK3J2oMVBAydTBZ00EjFHWerRzfzYbVtiitsw=; b=g9IjbVM6EYZzSYIKiy0p0BWJY1Wh0Af9OD3VjKuL2hxdUe16dk5wDIKB EEmEuTdX0OrN9IHwiS/fOa61Hlw1st7BLrSf/mzm+I+bj5lZTgG49AWKO tkIBcLvpS/kKog0sDXqTTvuIYT0ezLP9+jLYxpOb30ZEODEsLo5LWNCZr c=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 97849954 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xLot2a1Qd5VXWaGO+fbD5ehwkn2cJEfYwER7XKvMYLTBsI5bpzRRy mFKDzzXParcN2Pzed8ga4+09UtT75TVmIJmTwBqpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfKGIf2 KIAbyg2QxWq2d+E2bedcNs8r5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6Kk1IZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKkCN5DReDknhJsqHrP92g9MQZIbn6mof+VoUG3WeB5D lNBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313rWeoC62OCMVBXQffiJCRgwAi/H8pKkjgxSJScxseJNZlfXwEDD0h jyP8i43guxKidZRjvrlu1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nU/MBRaI3hxI2U2ss= IronPort-HdrOrdr: A9a23:RpzoTqjzmVlb7ZO3WtZ65WLy6XBQXzp13DAbv31ZSRFFG/FwyP rFoB1L73TJYWgqME3IwerwXpVpQRvnlaKdkrNhRItKPTOWz1dASbsO0WKM+UyFJ8STzIBgPM RbAt5D4b/LfD9HZK/BiWXWLz9K+qjlzEncv5a6854bd3AJV0gP1WZEIzfeNnczaBhNBJI/Gp bZzNFAvSCcdXMeadn+LmUZXsDYzue73K7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFqQrk/a+u2svLgSM0llWjpai+quGRhuerN/b8xfT9Hw+cxzpAKr4RFYFq9wpF2N1HoGxa6+ Uk5S1QdvibokmhBF2dsF/j3RLt3y0p7GKnwViEgWH7qci8Xz4iDdFd7LgpACcxxnBQzO2U6p g7rF6xpt5SF1fNjS7979/HW1VjkVe1u2MrlaoWg2ZEWYUTZbdNpchHlXklZKsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgwJu9CT0TJRgHdlpnFosfA3jzMF7tYwWpNE7+ PLPuBhk6xPVNYfaeZnCOIIUaKMex3wqNL3QRyvyHjcZd460ij22uPKCZ0OlZ2XRKA= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97849954" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlejUzrVtq14aL/3zo4dgTO8OeRRZA3jVhLRA9qylmW9upS05sUUOLrTg4LKWVyzbkal0SeWdFPKi2xRllmCCfu7pmTHhJnz/TQHD0kML2iJYnQ/qok2PlqSe5oJ6oSE2BEv/9D90Hy7DWvpY9yx0nKKd5ICl3XFsIG33GIAoIV0nlofuGYdr+UDWZLw593zjO8j6n4U0ND8CQsA6pnLNtKyAYIT6FARkHftSqz9PlxDus7f6Fl/81VxnCWHy1cw8ClzERmSlIFocNbaes9aI4hdZYNsvRZTJYMaATK5vKUx4v85jPIqLDFqjCUwZ2W0ytqSm5OqUSQDwUjSCFgL7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7i/jt+KTi0wVe7bRfcDojkbjGN2u6/RVgMKjz5A+N/E=; b=VuTbF+ZeCJD9Jikih6W266lCsw7dV5d0V8Cp9AzKAe2atTwFTFTuJ5zqrvknvQ9yzt4OX0wT4dBjt3YDZbSQWrI5H81zY5k97axZi1MHFCrf1/6tAYOvU9vnqE0wOsiIYNlCzewJRpQKhV7BlAmROcNfTvAOLEzuU6YHZZIUssk8r8kvU+iIpweYBqy68zm2oqoPJF9lLbAfWPxAuE5MxmDl3xQHAPh/Xw+k5qQKLzaLtbENN7lsFuruj0eV7Ga/tjU/eHY5uiWS1M4vWC3Nrr1WRlGZlG3JRi2q5YH0YuBTtMU6iM0FgIYyJSqwsz/iWGaHIGUYddKN8SSOznwgyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7i/jt+KTi0wVe7bRfcDojkbjGN2u6/RVgMKjz5A+N/E=; b=JQk2wqJnO0ed3I9oiCYWT74IHJ+ZP1jq62wK2gdrUh67t/UzQbgRWdM5+zkpCCGUHIUkOi/B2prVJXI5k8elb9IpvO2ClgWy1T1+bOGjaJa3CR4CQinuZuGMtKTmDs3p1N7IaWOIpRGtD4VPRP1am7HAu2LID93SRpwkBXfmWls= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <2c6f4132-9c75-767d-1b98-dca1527c2b58@citrix.com> Date: Fri, 24 Feb 2023 20:12:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 05/14] x86/svm: move nestedsvm declarations used only by svm code to private header Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-6-burzalodowa@gmail.com> In-Reply-To: <20230224185010.3692754-6-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6073:EE_ X-MS-Office365-Filtering-Correlation-Id: e8bc281b-b150-4018-5c6a-08db16a381d3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jKtnCn5nclbrrFxAykSyRkziSMHNYxZsAl0uBMZjADOwupEgVKFuTSlN1KwLHrZ5LIkK0wU9STs3Au1x1/0C08T74fkQoOxAXy8JltNQbrKV3heIFp1mXm5hqb/7ADKats5nlAQ2hHYhmCAVTZyfcU/xbTP9NnxjcdTXCVbBLsJw4ZxUAaCf7kQkpAIceCZiXZu1WUlHi79mcP68Fnt4mql09vESocfMPrdJlmN0eMZwVEaOIPrRjzOjcUldZGishU1xtmrw6M4YRkbL5HH6FfctvM1RznuAeOLXGpEyQaK+5jT3bcw0zWzzwp6+d5+k5E5PXOpjuD9RiQRURMGXhNEkR6b1HmwuHXNQScJf4BdWBBmKIKTX/Xmvq4OXxtA51Pw9GhZrb8y0bDZVs1xKHFJSjK5ym4Ducy7SzJNToh1XVVF6GWSfygFybvhcAL3OPK9ZL2bA9Er4kui4upDI8Tl9fqMybIL4jkxWftVdmsTXPFI2ctmpjjZmROs/5MK4XRRYrvn5rlrZUkSNJ1FGg3H8GwFrKemPjk30GqCJcxssJAC+7AvJlHYqTIA0YxdOm9qsYeUg1GJds3vAQyPrlE1yIY8WpRYkPF4lx6LRIQMv9/ZaNGetqKbHaWDEy9rskK9nXs1GmgrdwGP6tL30ggc+QhvCFq6k6QTWIekiCzy3+tn+3dNAUqP6VCbA+S9krceUdPFzSKRnQ29hlctDA3pS4ILarcH66pfLkDpaVyo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199018)(31686004)(2906002)(8936002)(41300700001)(5660300002)(66946007)(4326008)(83380400001)(66476007)(66556008)(8676002)(6666004)(53546011)(316002)(36756003)(478600001)(186003)(6486002)(6506007)(38100700002)(2616005)(6512007)(82960400001)(26005)(86362001)(54906003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmxaSHRyME42RW9BV0xxSVBrSjlRbzVseGtpNkNKZ2hmU1lSd0RyTHQya01o?= =?utf-8?B?QitRTG1tVk4rdmlIL2RYMHJuUEd3bHBXdFR5YWNncDlCT0Z4dUJ4aDk1Qytr?= =?utf-8?B?SXkwNkMzeWpNTG5CNFJONVNXNlVsUkNqb2RJWDlMVEs1NjRaQWoreUZxTkY4?= =?utf-8?B?SEk0TDhUYlpXL3NYV2NXeDlqdEtiWXcrdUVMVU1sRTE3cEdJdDRuZTh5dk9F?= =?utf-8?B?c1RBR2UvcFdHYkJqY1NrS0tHclVFdTY1aDEwK3BSVjdxQWV6T3dXMDZENDV5?= =?utf-8?B?RWJBeWVlWFhEWTNFdlBaaXloZ1NDMFVudm9mbjcxbkJwMDV4bmZQblM5ZnMx?= =?utf-8?B?RXBkZFdYOXE5aGdIOG9EdkYzMVlLOGFIc2REVWpkcUJoeEE1UWpFNUtqT25q?= =?utf-8?B?QnJhbWV6SGpkVzBjUHRlaVhIaGh4YlkvQVM5ZkNlZkNHWHFqVmVMWkZPL1o4?= =?utf-8?B?cUFwNmRTOGFRaGNDampBVlVkcDFXa0NNL0hub0Rib1pkcDdMeW1VdHVzamxa?= =?utf-8?B?NlllbEJOZ2Z4ZlNVUndXbDVPUUxxMUh2ZzBLS1hEWDFZRmdJUjJEeTFKajZj?= =?utf-8?B?UFhDZDJBQ0QyS3ZFY25JYVlnN09YOFdCRDhpamZZVW5ob0tkWS9Vb3FMMEU2?= =?utf-8?B?QXFreHVLRVlzdzMyZklvdytJbkNLMHJuaUhWa0d6dVgwSkY3a2hsdEtISVY3?= =?utf-8?B?aWU1VGhqeVdnejZPVkd0ZnZHb0lrdEtTdk5CQUl2RDY1VDA5dEFxMHhrVm9Y?= =?utf-8?B?TDE5b3diSmpydzRwZ1hBSkhmU0NEVlF2Sm5rV1VhbTRsUXU1NmpocWVTUllw?= =?utf-8?B?Z2JNV0d5QlIxbXIya3pSamZqaHVyNHZJYnpjakRTZTB4WTlhR2VMclp0byt2?= =?utf-8?B?aWRJSUxsZXNpVnhPTDFSZS9qc1ZwSVhZOHdpNGJEY3ZJdmtBMlFvQ3ZkY09y?= =?utf-8?B?a3orZlp0eFVkNGZtd0ppaFc0V29HTVVFaXRZMWJCNDEvaGxJZ0x4cExHeTFv?= =?utf-8?B?K0dVRG5GN3VBZnYxeEo0TDF0Y0M2eURwL1pkWmhkNWdqeXBwNzcvMjIybWFP?= =?utf-8?B?THFIYTBpYld2WjhIbnRBc1QvbFU4TVh2RGJOVVNqWitIQ1djWk9sdDFYUWRP?= =?utf-8?B?dFp2bEVqNU9pWWp2ZllGd2JWeHcwMVIzL2d3dVZqM0Y1OXc1QXRQVU9PTVJC?= =?utf-8?B?dVJ4b3VDUjdYNUVMb2tuSG85OHZHMXM0dGNleUtuUy9OZVZRc0o1N0xTZWhR?= =?utf-8?B?QmtCRGJzZXVUMEZTMkk2RWVzMzk4V3ozNERyWDRXelh1SnQ3UHJXKzYzbG1C?= =?utf-8?B?enBVWVc3MVdJUHFNdXJxNXNBNFVrSGVNUzRlK3J0OU9KQmNlL3k1c2F4T2tj?= =?utf-8?B?d3RDSThwTjJlWERkT2pyN0VvQlh1Sy9WMHVNVWR4dVo0d2sxWUZJMkJNV2hh?= =?utf-8?B?R0Q3YjZucUhsUlBwd1Rqb3lmbWZ0eUNxWkpCaklzWWVHdkpXcU1pZDl1UmxJ?= =?utf-8?B?alVHQ2Z5SStEcmRXcTFyNmMvRnNpWmdlcVk5bkNTRzY4TnMvcHZEeGt5dGoy?= =?utf-8?B?K1VmTlByMzhFak1kQUU0eU51SUZpVVNjSzlkY3BTRVgvWUdkK25jdkxQVFJ4?= =?utf-8?B?SEdITTVDVE9WdHYrRlJoRThYOUxrenhCRHZBOE43SnpERzlTMitMTE9VdHA1?= =?utf-8?B?OWh2dFd0dGozSm05L25BMnBaQUorRHo1WkFwN2VJU0NOTFpkVVY2REprWUdy?= =?utf-8?B?RFpBbDV0SVFpS2pqUEVUNC9JSldmNFVaME1maUNwWEhXbHdxajAreUVlOEpC?= =?utf-8?B?eWExT2wrcjFxbE00MUhtWXlMdTJqdVMxR3dhNVVXWFhoM25MbUFLMlRIU3o0?= =?utf-8?B?TkhoL1B6ZUMxSHdlSWgvbUk1a2YxSnIwU0I4M05jcVVCeGxyU3pFa1huYWEx?= =?utf-8?B?WmJuQUZveVV6Q2duemREVE1KNWt5SE9vTHJoTThtWDJkS0ZuMGp2TFJPc3VW?= =?utf-8?B?RS84dGV4RktkZmQrVEhCZFhIT3B1V2MwV21VYUFjZzkrZUMvYjdGbjRmV3NI?= =?utf-8?B?emVnblF1MG5vcHFFTmlaMzhsU3JidWxoREtla0dHNjNZTUdPMmxHTFpQVTZO?= =?utf-8?B?dk9FbDdzaS9SSlJXcVBZaEMvdkRnYTVUNGtSZ1F4b2swSU9JNnJHMmJ4THF4?= =?utf-8?B?cGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: D/LHk0BgrbsU7OO7D53rHtH+Rnw5meW8BxVBPrdQZthPePOp189sY3fuJNQp5+UA3HD4+F7hm0gMLl6ovQWCjeTeO7enYsJCzDg/JFJBQUSkT37RK/ZvmNfU4BkQ6vEP5pM0JZ+/sqzitfEg6vRX8GerNYvpWiPdlwBZ2SbV9Yzwvbp5gHQ6EJ50DJXrHHboPzZabnebA5L5cS3gSDzjyrEELHkAEV5YQAkfdRhffeNOIkbkAABY4sEk+eKnqZPphntOhNQ5RNx+mKSuoHZsTct4JLfBCVgKyvUkT4lJSnJVmzppZT47AYOwxIS8iweMhrpxLRCyXPHJodV1QW5/4u18mWA4fbDUxnZdq6JUWuXUTZJ/MHgiJO2s8X0uwDHhWeZ4DKIDhAItPraNax3Sui0+5gqczLHji3GMY2g548pT8STXKZKLRw7qgx1RoAwxk4JrD5XCrj6KA5XCO02p0LKYSb5+4xsHCpEmw1J8rtlaFq8mzJ6L98ykty/u9n7otgzvVYVojvQeAcYdbCt5YrNFpBzATOMalAUjl/CiCMCqCKOywfcfjdak56kxYoFU/Xf5CPa5fubDlhUuXBnBbx/4DBe4dzdJUO25/Au0hVAat70Y/2qkXW6mduodm08peAKPWVQhzVmzECGBwmH135dVT8oB1nZt8WZd32zbO+8vb8c9KozCOpdZJcwJeaIimWMMvfKZtgM1xi9LRDWz92l3yXF62GdcjgReLbeE9AM3F/xw+AXCoK2qfLGiYq9XpBgolVpT8NhEcun2Ob7x9G+TClueVmLTe4aYLBnTCr9vqwzNvGA3L1bVBssW5kIKjEdk1KAeFoMpArBdUPJyTUsd18HbJzWzMsNrI7rnkIg= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8bc281b-b150-4018-5c6a-08db16a381d3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 20:12:51.9774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fON4rdD1YReWCsZtYKfOoGHQGD7XCkJUsR8rvsy7jKgmZnqzR4RFJHkBSFAoveveGELEW7oDRTMa4BEWsP1mRD+Ik1Q+qBHkDY44n3aoWt8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6073 On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: > diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h > new file mode 100644 > index 0000000000..43245e13de > --- /dev/null > +++ b/xen/arch/x86/hvm/svm/nestedhvm.h > @@ -0,0 +1,77 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * nestedsvm.h: Nested Virtualization > + * > + * Copyright (c) 2011, Advanced Micro Devices, Inc > + */ > + > +#ifndef __X86_HVM_SVM_NESTEDHVM_PRIV_H__ > +#define __X86_HVM_SVM_NESTEDHVM_PRIV_H__ > + > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +/* SVM specific intblk types, cannot be an enum because gcc 4.5 complains */ > +/* GIF cleared */ > +#define hvm_intblk_svm_gif hvm_intblk_arch I know you're just moving code, but I simply don't believe this comment. This additional delta seems to compile fine: diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c index dbb0022190a8..111b10673cf4 100644 --- a/xen/arch/x86/hvm/svm/intr.c +++ b/xen/arch/x86/hvm/svm/intr.c @@ -154,7 +154,7 @@ void svm_intr_assist(void)              return;            intblk = hvm_interrupt_blocked(v, intack); -        if ( intblk == hvm_intblk_svm_gif ) +        if ( intblk == hvm_intblk_arch ) /* GIF */          {              ASSERT(nestedhvm_enabled(v->domain));              return; diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h index 43245e13deb7..c7747daae24a 100644 --- a/xen/arch/x86/hvm/svm/nestedhvm.h +++ b/xen/arch/x86/hvm/svm/nestedhvm.h @@ -16,10 +16,6 @@  #include  #include   -/* SVM specific intblk types, cannot be an enum because gcc 4.5 complains */ -/* GIF cleared */ -#define hvm_intblk_svm_gif      hvm_intblk_arch -  #define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm)    /* True when l1 guest enabled SVM in EFER */ diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 92316c6624ce..1794eb2105be 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -1247,7 +1247,7 @@ enum hvm_intblk cf_check nsvm_intr_blocked(struct vcpu *v)      ASSERT(nestedhvm_enabled(v->domain));        if ( !nestedsvm_gif_isset(v) ) -        return hvm_intblk_svm_gif; +        return hvm_intblk_arch;        if ( nestedhvm_vcpu_in_guestmode(v) )      { but the first hunk demonstrates an error in the original logic.  Architecturally, GIF can become set for SKINIT, and in systems where SVM isn't available. I'm unsure whether its better to fix this up in this patch, or defer it for later. > + > +#define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) > + > +/* True when l1 guest enabled SVM in EFER */ > +#define nsvm_efer_svm_enabled(v) \ > + (!!((v)->arch.hvm.guest_efer & EFER_SVME)) This seems to be the only use of asm/msr-index.h, and it's a macro so the header is actually unused. I'd drop the include - its a very common header anyway. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:18:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501560.773370 (Exim 4.92) (envelope-from ) id 1pVeVy-00016T-To; Fri, 24 Feb 2023 20:17:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501560.773370; Fri, 24 Feb 2023 20:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeVy-00016M-R5; Fri, 24 Feb 2023 20:17:58 +0000 Received: by outflank-mailman (input) for mailman id 501560; Fri, 24 Feb 2023 20:17:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeVx-00016C-Kj; Fri, 24 Feb 2023 20:17:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeVx-0000gK-I5; Fri, 24 Feb 2023 20:17:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVeVx-0002XN-7b; Fri, 24 Feb 2023 20:17:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVeVx-0007aL-77; Fri, 24 Feb 2023 20:17:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YAIF8+/b4y4xE3to0N4HTlS8zj5OTWNqfpZ/9pprlIA=; b=4fok5z1kxiB6dfeYIi0HVs26mK Gwrp3frJT9xE0iIysGwOWxQfICYHLJSpVNKu9u7XvRFaskOTZMDz9BP5oZW0F9wlwbxPvziASD1oN GALBTBqwInGi8ZCNhXUxic6v61xR0t5983BFgs7yiGqkcaqfdOLieZU1eb1PyPCvhltM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178376: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=7b66792ea7f77fb9e587e1e9c530a7c869eecba1 X-Osstest-Versions-That: xen=91d4d9506a4e8906253d1280bd5a1f39668fad64 From: osstest service owner Date: Fri, 24 Feb 2023 20:17:57 +0000 flight 178376 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 7b66792ea7f77fb9e587e1e9c530a7c869eecba1 baseline version: xen 91d4d9506a4e8906253d1280bd5a1f39668fad64 Last test of basis 178238 2023-02-23 12:01:59 Z 1 days Testing same since 178376 2023-02-24 18:03:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Bertrand Marquis Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 91d4d9506a..7b66792ea7 7b66792ea7f77fb9e587e1e9c530a7c869eecba1 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:28:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:28:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501566.773380 (Exim 4.92) (envelope-from ) id 1pVegD-000387-TJ; Fri, 24 Feb 2023 20:28:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501566.773380; Fri, 24 Feb 2023 20:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVegD-000380-QH; Fri, 24 Feb 2023 20:28:33 +0000 Received: by outflank-mailman (input) for mailman id 501566; Fri, 24 Feb 2023 20:28:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVegC-00037u-Bf for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 20:28:32 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cce678f9-b481-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 21:28:30 +0100 (CET) Received: by mail-ed1-x52e.google.com with SMTP id f13so2012878edz.6 for ; Fri, 24 Feb 2023 12:28:30 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id kx20-20020a170907775400b008b17de96f00sm10325122ejc.151.2023.02.24.12.28.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 12:28:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cce678f9-b481-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4Xx88+lcqjIy+YjQrkkEWWwYNjNSBD7jbJc1YEwTWV0=; b=SIwuQsAie0pLFnzDwkpVj3wFh4+Bwn4MmqRYfBv66NUQhqXHygR/M3Rgh6C1uWaMO5 Wy8K49h9yxqoVNRcIkQ0A5hPJrjgcrxAW3EqlkZ+kLcsn6L+OfOl7feKSeFa7SsOmDyP iSCCaGk1/pmzU8NsMqL9Dz1LQxTrzqXj+jHO7pM0LsksTzhS/kttottseW/gwcw2LTbu 0y704b/TyN2+RHA6GQwHo4AFRtjTsAD9q6aKzSNXRByh9d1EGDIBuTZvXdaSrnM4eoMu kaS97Uhuqz5DSRfWLWT4Ci++qpnuz9byfdXBBAEhJPqI7FaWEHI+HW2wSf0b/zBpsAII 9uiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Xx88+lcqjIy+YjQrkkEWWwYNjNSBD7jbJc1YEwTWV0=; b=dxS9Fm/aVue3bpyTF9bCWZ/c6/ggdxJx75dfzdvHUgq+hnIS++V2aN7ekeWqko39z3 WgZCYH3MdR6bpRKSe1hVrBlQBAWBXNmXcor0jCb2zNBqQVQ5A38tHMmYs1uvwl9L7KZW vN0JM56NxhHIcm/ivqMaAWthUaEvNKwrCeg2UDMyV52CJP9DEfGxW+Rmv6HZlse1Vo7S 5v0WCCEAU4d/VxGnmSQMVNIfqY8oKjs8fANS/F1+lBmsExwLsdkETB1hcnH3GkoccBf+ 6VtLniqmrNC0aDaEPUxa78vqAYabhQpYOASfJhzlQa6QDPYziJwq1kLagAZbQGli1cxx 945A== X-Gm-Message-State: AO0yUKVONqlUs7jPkYoxZ6qlCEHQuMTnr1ufkBQGZod6bjwwT3kYTXpq rtwI4/RmqeUniqKwoSP1g9Y= X-Google-Smtp-Source: AK7set9ot7uAncmnY+NByDkDbtODRmTfdHvcm0diXQtK+SURg5bTz9GxGkPx+n3K1ZBwYMj8JWxReA== X-Received: by 2002:a17:906:3a46:b0:8af:54d2:2088 with SMTP id a6-20020a1709063a4600b008af54d22088mr25272626ejf.37.1677270509521; Fri, 24 Feb 2023 12:28:29 -0800 (PST) Message-ID: Date: Fri, 24 Feb 2023 22:28:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 05/14] x86/svm: move nestedsvm declarations used only by svm code to private header Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-6-burzalodowa@gmail.com> <2c6f4132-9c75-767d-1b98-dca1527c2b58@citrix.com> From: Xenia Ragiadakou In-Reply-To: <2c6f4132-9c75-767d-1b98-dca1527c2b58@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/23 22:12, Andrew Cooper wrote: > On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: >> diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h b/xen/arch/x86/hvm/svm/nestedhvm.h >> new file mode 100644 >> index 0000000000..43245e13de >> --- /dev/null >> +++ b/xen/arch/x86/hvm/svm/nestedhvm.h >> @@ -0,0 +1,77 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * nestedsvm.h: Nested Virtualization >> + * >> + * Copyright (c) 2011, Advanced Micro Devices, Inc >> + */ >> + >> +#ifndef __X86_HVM_SVM_NESTEDHVM_PRIV_H__ >> +#define __X86_HVM_SVM_NESTEDHVM_PRIV_H__ >> + >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> + >> +/* SVM specific intblk types, cannot be an enum because gcc 4.5 complains */ >> +/* GIF cleared */ >> +#define hvm_intblk_svm_gif hvm_intblk_arch > > I know you're just moving code, but I simply don't believe this comment. > > This additional delta seems to compile fine: > > diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c > index dbb0022190a8..111b10673cf4 100644 > --- a/xen/arch/x86/hvm/svm/intr.c > +++ b/xen/arch/x86/hvm/svm/intr.c > @@ -154,7 +154,7 @@ void svm_intr_assist(void) >              return; > >          intblk = hvm_interrupt_blocked(v, intack); > -        if ( intblk == hvm_intblk_svm_gif ) > +        if ( intblk == hvm_intblk_arch ) /* GIF */ >          { >              ASSERT(nestedhvm_enabled(v->domain)); >              return; > diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h > b/xen/arch/x86/hvm/svm/nestedhvm.h > index 43245e13deb7..c7747daae24a 100644 > --- a/xen/arch/x86/hvm/svm/nestedhvm.h > +++ b/xen/arch/x86/hvm/svm/nestedhvm.h > @@ -16,10 +16,6 @@ >  #include >  #include > > -/* SVM specific intblk types, cannot be an enum because gcc 4.5 > complains */ > -/* GIF cleared */ > -#define hvm_intblk_svm_gif      hvm_intblk_arch > - >  #define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) > >  /* True when l1 guest enabled SVM in EFER */ > diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c > b/xen/arch/x86/hvm/svm/nestedsvm.c > index 92316c6624ce..1794eb2105be 100644 > --- a/xen/arch/x86/hvm/svm/nestedsvm.c > +++ b/xen/arch/x86/hvm/svm/nestedsvm.c > @@ -1247,7 +1247,7 @@ enum hvm_intblk cf_check nsvm_intr_blocked(struct > vcpu *v) >      ASSERT(nestedhvm_enabled(v->domain)); > >      if ( !nestedsvm_gif_isset(v) ) > -        return hvm_intblk_svm_gif; > +        return hvm_intblk_arch; > >      if ( nestedhvm_vcpu_in_guestmode(v) ) >      { > > > but the first hunk demonstrates an error in the original logic. > Architecturally, GIF can become set for SKINIT, and in systems where SVM > isn't available. > > I'm unsure whether its better to fix this up in this patch, or defer it > for later. I think this change merits its own patch. > >> + >> +#define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) >> + >> +/* True when l1 guest enabled SVM in EFER */ >> +#define nsvm_efer_svm_enabled(v) \ >> + (!!((v)->arch.hvm.guest_efer & EFER_SVME)) > > This seems to be the only use of asm/msr-index.h, and it's a macro so > the header is actually unused. > > I'd drop the include - its a very common header anyway. Feel free to drop it. There was not in the other header. I have a tendency to include headers for everything. > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Feb 24 20:34:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 20:34:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501571.773390 (Exim 4.92) (envelope-from ) id 1pVelz-00052s-Hz; Fri, 24 Feb 2023 20:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501571.773390; Fri, 24 Feb 2023 20:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVelz-00052l-Ea; Fri, 24 Feb 2023 20:34:31 +0000 Received: by outflank-mailman (input) for mailman id 501571; Fri, 24 Feb 2023 20:34:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVely-00052f-3J for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 20:34:30 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fc75805-b482-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 21:34:26 +0100 (CET) Received: from mail-mw2nam12lp2047.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 15:34:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5603.namprd03.prod.outlook.com (2603:10b6:208:29b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 20:34:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 20:34:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fc75805-b482-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677270866; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=QRujyF0JhVHzl3GY5yu72FcWYlEWv2Lil7clkS54Ypo=; b=GXk9AnTjaz1ZqM8vrs7Y5PW5DSWtIWMC5tf2ks5ypvfJxH/+zxc9UNbE wbGG+Vztn5HNKsp7lWVNxMkS9DR2R6jPbS9y9sSkjsUb0YceKYd0oRdk6 96vD/Q2WXyWDhK/BlGVczXni24T3xY6i0CgZkbOlZxvhNO9IHniWAn3RQ k=; X-IronPort-RemoteIP: 104.47.66.47 X-IronPort-MID: 98874056 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:kJmllqOwA7kQwZrvrR2dlsFynXyQoLVcMsEvi/4bfWQNrUohhTYHy 2QeXmvUPPiINGP2eIgjOdvj9BsDvMDRzIcxHAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5ABmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0uV2X0thr /VBFCkQRQnAmPKS5OiqFfY506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/Rxvze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6fzXynAN9MfFG+3uFninaV7T06NDE5C1Tn+tCnqkK3RfsKf iT4/QJr98De7neDRMTnTRS8p3KDoRc0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJuuPC4awh9zxXDTvm TaDqXFkg61J1ZJUkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshXZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:mN+J+69KNRrEUenr/+Ruk+DxI+orL9Y04lQ7vn2ZKCYlEfBw8v rFoB1173TJYVoqNU3I+urhBEDjex3hHPdOiOEs1NGZMDUO01HIEGgN1+Tf6gylNyf+8NRc26 AlWK5jD9f9ZGIK7/rS0U2VGdcn+tmI9+SUiePGyn9xQWhRGsRd0zs= X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="98874056" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTXF8CX/a2TkkEeYnWhKJTNRfR9boGD6P0py9KcYlwooRuIc/9DRu8kDH2Mj8TnfhIRloqJ0Ft7ZD4id6CfYnkRmIbuzV8qqvjHtWL5J+DzF+LFs3H5Xsi02oofcXxAUM4OHC4ZPBuHQZyF24ck/Dlp4vJ5E39eCYi/jiSjMJxkky2E/4TkgHOFdzaXLNGaR65FpcOgqtvwwz6wKG0kjmmyyJM5pjmzs1PK4ahK6U8i8tiei6O0k8CyEpqnC/bOXL5Z0loXVmKLFfCQ4fLUBjwWeYfECXbQGin/FSkx1sEGjL468ioGpa8sgLONjyfwKAT4++6TPZghCjCh362CaXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QRujyF0JhVHzl3GY5yu72FcWYlEWv2Lil7clkS54Ypo=; b=lnKEc9d7lZvadZrrkHLnWm+QjjGFTndTmA0GrNOUpCDP564iDYcwYHV3IF+Cb5eJQFOw8tcbJO2slENyrCsVZ8aWmkcqRygqJ2Ec1dJgBNY7sc/CD2uqHhk16I3qs+iZwdVXlGoBxOBGYBCnRpnnrno028GheCoWRQmdCxVxAnHgGMBE7gZgGpu4zNWifxhRGrBDqy3oA8VkBWH7uuFQy7LRROVttDmWDnAlvkHISTiwaaMonXXDhNIYskatlOLa1yrfW7/ru1GuWFm9ZCZluM7VIIzAL3H+zgVWKkRjn7h65JkA47l0YX2HxwpgfBPbaPPYKVd4Pdx37q4KaYrKZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QRujyF0JhVHzl3GY5yu72FcWYlEWv2Lil7clkS54Ypo=; b=bljaBeZ4HN5S7/QWeKk7n1B1S5Z4njvGAp+Ycwdoa1EatBPdl53GrzkfrrNmSXBjVucA9mH0m5WZQVD3o/UljPdQYmirrcXR0ztL5B9OeMGdmnzRa+ILPgFgbAb/o1V//C8c5gL42dfpdHkx504lomK2Gu3Qs5nVJWDLOTxX5I0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6dcd2528-3ee4-6fba-b1b2-41fb1a552033@citrix.com> Date: Fri, 24 Feb 2023 20:34:13 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 05/14] x86/svm: move nestedsvm declarations used only by svm code to private header Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-6-burzalodowa@gmail.com> <2c6f4132-9c75-767d-1b98-dca1527c2b58@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0152.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5603:EE_ X-MS-Office365-Filtering-Correlation-Id: ab7ee8a2-f300-4317-5e74-08db16a6816e X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MiIZu2Tx8rotexr8Vf8e6BZkgLw8xFt8iP8v/ENPx2yleZAa21cjHN4LdFVnKoLwv2Wv786HWJScYe/La7K1QCeRc38Xfg70HwJ3CrT4KcSDVrGueJ5T0gs6pB35wQb/XWe+OEbmRzfPA7OOtnCYzAEhSx2XLRIwCvaOq41BT1KNt8+98B898zWfuphN0Hnk/dkI03UrJMg6NpZRYFvEL6qLIrjOULADeNphc5tBFiVhvMbZ8lAP9nBFCxnciuBgTs1kkeDGcTeKqbJE1UfTqIpHtAVxhIATW3ajpE9J0/vKAztFN/0v2R9ht3EyKS/k5Hyci6fHFiTYt096VIy2p7MhModBVzFypXfKMElWO6LnITX08JhRE8rI/a6dZB0tgAxaFdx97h0SFarWZGLc+9tXoqvd+UvvbdTXKFzISqHz3xhYeLoUkcmticB0PB8DhRI6I44Gfj1EYsdLIWoVKkJZYhkMnZ9F5/HIDIa+1qz9B8RuCcQkfPqRpRoLgzfA31pk1dPMscOe1zu85078U+n79ivuBxbT4PrsimifZDr4zvv6HH17fsXJjHzeknrqwJ1YH9GMUQOETWb75Fen46rPnXcNICLNeGqNyUOyEMaU19CRqLiQr9LfVklRaqyaYZb0I0BKNpxALZvaPjxFhEehmTa0o8J7wXF0Ir7wh1OZDLhsXPzK1EgMONEUhBNUPI5Z9VvXPFgoevRLMu9c0S3+2j8mE7R6Z8SbbUgDJH0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199018)(31696002)(2906002)(82960400001)(38100700002)(86362001)(31686004)(2616005)(6486002)(53546011)(478600001)(4326008)(26005)(36756003)(186003)(66476007)(66556008)(8676002)(83380400001)(54906003)(316002)(66946007)(41300700001)(6512007)(6666004)(6506007)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVRSTnl1Y3luSUdiaDFBNzZFcXd4anpiUVNGdGp4UTVHOHF2djRVVmJuWGYy?= =?utf-8?B?ZVJETytlQTBCTlhmY0UwQTlxa1JrM0pNekE5ZnFzT21iSmtpYTIxclNZTWxo?= =?utf-8?B?Ynl2ZEF6Z2NEU0Nvdm13TmVkUkpUK2dxMzBDNTlETnF4VzF6d2hmK0Nhdml0?= =?utf-8?B?VkMvaHNPRVlSV0p3NUxRUS9PWmFiV25KVEtRSHlZY2kyMlJTWW50R2JMbm1P?= =?utf-8?B?L1FjYUN5VGZjcStKMEVMNHZQcitjcEJyR1VxWWdDUUk2RjdPMWxRQUlDenNK?= =?utf-8?B?LzBKRE1nNkhXT0ZvSE15bk5SWGg5SVAvT2lyTmdJV1p6Wm1DSmxYR2dIOS9t?= =?utf-8?B?RUdUOFBCc3BUbGdsMVd6SUVFTm5VUTRBeEduMHloMlZRa3Z4cDFJSmYyeHhh?= =?utf-8?B?WDNDSGo4K1E0Z054cHptUmlNSjF1RDdLc3RRUTBEVXgxdkFmSnhpUzV6eXhn?= =?utf-8?B?Y3Z4c3c2OUpudERudytZdkpJalNNd1Q1Rmt3WTF3ZkZvVzZUMlRnZUZqd3NX?= =?utf-8?B?eWlYWmlzTkVUNVNaZjFHc3RCTGcySHl2OC9SeDh4NzlrZjlMQXAvQnV0N0hG?= =?utf-8?B?YjNSa1NqOU5udUNOUXlYdzg4cUNCQUdDU0hCblhBVDdlWU9ZWkRtM1JZZUE2?= =?utf-8?B?SEQyR2F6cFBzTWJPYXRWY1hNYkEyREtiRUhHZVVIeldRSDd3Qmhub3hxT2pT?= =?utf-8?B?MmRJOTh2WjM5bGd2emhlTmIxMkROYkRpc29wWGFoYkM3LzdydG1VRVAwR0VS?= =?utf-8?B?T2VsNXhHeGY4cHd0L1poUUpuMzFoSTdHN3p0NWtHTEI5b3VwYkxUdFZqQk9r?= =?utf-8?B?bTAyaTRIZHEwUjMxNENzZnlxOFlnYkhUeVRZV1gzTDdTMGJjVkpQNjdNVlZz?= =?utf-8?B?d2Y4S0doWHM1WEp4TTc0NnRYQkZLQXRBUGMrck5hZmlUcHVEdVhscFFtanRD?= =?utf-8?B?VGV0L1VGZncxaVRRcVUvekt1aGJmZEJnL3ZHZlVhdDN4ZGVMTHJsMXNqdC9l?= =?utf-8?B?M2VicGVGMTYwcmNiRFl5eUR6ZE8vZlN1TjIxd3VIZVErTUdOdHkyYUQxNU9M?= =?utf-8?B?cmtHTjNrRXpGbDk5bTZCRC8vSXlFZ0FlY2hvbVBEMm1ZMmE3N0k5VWhldWZw?= =?utf-8?B?OWx5RUMvSUdLdDBycFN0NUtGdm5KRng1S2tpRnh2L2JPRVU4ck9FSUl4QkRO?= =?utf-8?B?ZFFvUlFBZWlZT1ltTG1mem9lYWFqVTRKbVZqT3dVdzJCWHpGZmlPNUpEaTIr?= =?utf-8?B?SXpYbEFCcjQyZ1BvczFUbDdXYldyZ05ZV3crbnVYU0o2ZmNTOHBnWW9Vd0tz?= =?utf-8?B?YzJQcFV3djhoRS8xdERiREduRGg4RkwyTWpjdGVIVng5R05uZnBUYkhpNCtk?= =?utf-8?B?N0NVWHZCV29VZU0vTzRyWmQ0d1ppbDlMMVBrdDk4Z2k0SUFqWWl0eEtwelUw?= =?utf-8?B?aTZtUXhkNE5YQlU1MC84SEVqZzF5TUpzZXhxT1I1eVBIM3lBcWNYM1NYNm02?= =?utf-8?B?Wm9oSkJaNC9hcTYwYldyR25aVkZvZWpMM3dpQkREOEZyNTgwajJqT2VxRTFu?= =?utf-8?B?dHRkSHV4M1YrT1VvOTBGYzY2K2FjeEw1SlQzVFBtK1dLSWw4WE9RNWlIdnFj?= =?utf-8?B?c0V2VXM4VElBd3VESGMvbDVHQnErbWsyWEhQNFNURGc0eGludUdRR0dFd2xB?= =?utf-8?B?R2JNa1JPMDZlelNLTU5HMlRoRVBCdlY4c1doMjMzei9CcHNMVVlqMWJsVUp5?= =?utf-8?B?cU94Z1FCU0dHNVNmLzNLQmI1aHpkQjY3MDFaaHA2UkQ4WkY3UUJucU5WRUUr?= =?utf-8?B?Y3VSV3hxY1Z6blRiTkFQQTYxZUNDclhoMm5pZ2xJc0tuTzZIVVhxVS9KZ3lt?= =?utf-8?B?dHllSFNBV0VjYWlsMGZ3RlRSbVAybkNraXlwRDF5UTdub003anMycFdJcEJW?= =?utf-8?B?dXF6aTdrcmtkRHZYNnBwNHBzNW8zV0QxSXk2cFg5Y1pRcFEzS2ZzM1R0WUFj?= =?utf-8?B?Wm9ObkkzN1E2Z01GQ1hUbW4vVC9IbzZPRjJoNkoxZVBNVkVsQXo3WEltdmk1?= =?utf-8?B?QXg3dkhYeHpUVUNQamxNTkpWM0RQSE9sUUdqN2RCckdCZWI4OEt0THF5Mm1h?= =?utf-8?B?QnA3MitwVjYzUSs0MGhaNFhybWg0bTNOOTU0WVlNNW5FWUxjVHNSNERoSGJz?= =?utf-8?B?RHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /3mnID6HtVigER+ddIyEjBuWo7rV5CYC2nSgheX3UwghATf8E3lKej39A3OT7874Dth1+P3Y8xj4sZqcsB6XiIcc6SakfMf53KQWuE1F8t2XbE2/LzxRYrxw20qDfXFw2wiTxgHpb2mRFSZ4drU65f9B3TJE9bOibbF+63NyKNEPGemb6grpWqCzmOJ7T6Y8eO8VWVKmrNEh1cYD686BTEiqmpP9sKYihpMmruiKQgjz/B4LRZKyr4jA479FiJifYMLVB7INKu97mqLME4f6ARTbjexvVc6fYcXL/PDlRy//p5m1XprtjsZ5Ov2gnGqyI+gKJvpOTHC8oCnwddqbWGWg1+RvqtVOxqd8rR1fPBry1C4z52l3vZ2almse2y/pgktgx936XCFhzfmOXeBy4n/lVI97tyZyCK8eb0tm93RPnfFIWHRa2Gdzk349tsVRxniTfSpZUc2YOt34niD28xd6N3CDZ6YpZjWenT6AJgbJaNcHI0DvO3vS1si5acz2G7iearpkoz1+ooejm8rSixNtyyFwfhPbEDVazJ6aPwwjlvDbbTQH5N6VmF9eCJLsRp3n/RA27XzFEA8BWrlGSVypRiGfp4eV7BZGjII0SLZI+KbOxtrDvD6ywrepsdijJtZKd/mfxSjz8q3A6+joTjn7Azy2Y3Vf4USW3IqlgtM89MgSpmbDddg9XG6irDC0VkAjCeKyCDajI3uB/DpGAW0gA9fh1AcjVxDOIxzjK53mvjnsy17dhNuWI2cTe7y8e/yNDcMdRKxm9lHFUhUq73tKbMIBCVJplzvZ3nkTJGIQ4Ty19Fo8tUlWQBnHLXJALE4mkNRdeM4zLOOZvmi1qe/2/HANCNeUZhGIV9EFoQ4= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab7ee8a2-f300-4317-5e74-08db16a6816e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 20:34:19.9151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RrCy+OQJ6cZollD3gg/s65/R9KvQW6d7UTIIqhvuvQe2MN+lK74mbYf0L9sMDMAeVFC3YkfWJgmQsZOc+FC7kct3OsGPacv4fZsr34VOfHs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5603 On 24/02/2023 8:28 pm, Xenia Ragiadakou wrote: > > On 2/24/23 22:12, Andrew Cooper wrote: >> On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: >>> diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h >>> b/xen/arch/x86/hvm/svm/nestedhvm.h >>> new file mode 100644 >>> index 0000000000..43245e13de >>> --- /dev/null >>> +++ b/xen/arch/x86/hvm/svm/nestedhvm.h >>> @@ -0,0 +1,77 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * nestedsvm.h: Nested Virtualization >>> + * >>> + * Copyright (c) 2011, Advanced Micro Devices, Inc >>> + */ >>> + >>> +#ifndef __X86_HVM_SVM_NESTEDHVM_PRIV_H__ >>> +#define __X86_HVM_SVM_NESTEDHVM_PRIV_H__ >>> + >>> +#include >>> +#include >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +/* SVM specific intblk types, cannot be an enum because gcc 4.5 >>> complains */ >>> +/* GIF cleared */ >>> +#define hvm_intblk_svm_gif      hvm_intblk_arch >> >> I know you're just moving code, but I simply don't believe this comment. >> >> This additional delta seems to compile fine: >> >> diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c >> index dbb0022190a8..111b10673cf4 100644 >> --- a/xen/arch/x86/hvm/svm/intr.c >> +++ b/xen/arch/x86/hvm/svm/intr.c >> @@ -154,7 +154,7 @@ void svm_intr_assist(void) >>               return; >>             intblk = hvm_interrupt_blocked(v, intack); >> -        if ( intblk == hvm_intblk_svm_gif ) >> +        if ( intblk == hvm_intblk_arch ) /* GIF */ >>           { >>               ASSERT(nestedhvm_enabled(v->domain)); >>               return; >> diff --git a/xen/arch/x86/hvm/svm/nestedhvm.h >> b/xen/arch/x86/hvm/svm/nestedhvm.h >> index 43245e13deb7..c7747daae24a 100644 >> --- a/xen/arch/x86/hvm/svm/nestedhvm.h >> +++ b/xen/arch/x86/hvm/svm/nestedhvm.h >> @@ -16,10 +16,6 @@ >>   #include >>   #include >>   -/* SVM specific intblk types, cannot be an enum because gcc 4.5 >> complains */ >> -/* GIF cleared */ >> -#define hvm_intblk_svm_gif      hvm_intblk_arch >> - >>   #define vcpu_nestedsvm(v) (vcpu_nestedhvm(v).u.nsvm) >>     /* True when l1 guest enabled SVM in EFER */ >> diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c >> b/xen/arch/x86/hvm/svm/nestedsvm.c >> index 92316c6624ce..1794eb2105be 100644 >> --- a/xen/arch/x86/hvm/svm/nestedsvm.c >> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c >> @@ -1247,7 +1247,7 @@ enum hvm_intblk cf_check nsvm_intr_blocked(struct >> vcpu *v) >>       ASSERT(nestedhvm_enabled(v->domain)); >>         if ( !nestedsvm_gif_isset(v) ) >> -        return hvm_intblk_svm_gif; >> +        return hvm_intblk_arch; >>         if ( nestedhvm_vcpu_in_guestmode(v) ) >>       { >> >> >> but the first hunk demonstrates an error in the original logic. >> Architecturally, GIF can become set for SKINIT, and in systems where SVM >> isn't available. >> >> I'm unsure whether its better to fix this up in this patch, or defer it >> for later. > > I think this change merits its own patch. Yeah, it probably does. Seeing as you've reviewed my two alt patches, I'll commit some more as I've already resolved the conflicts around adjacent headers. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 21:01:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 21:01:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501576.773399 (Exim 4.92) (envelope-from ) id 1pVfBp-0001OH-MW; Fri, 24 Feb 2023 21:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501576.773399; Fri, 24 Feb 2023 21:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfBp-0001OA-JF; Fri, 24 Feb 2023 21:01:13 +0000 Received: by outflank-mailman (input) for mailman id 501576; Fri, 24 Feb 2023 21:01:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfBn-0001O4-7H for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 21:01:11 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a66a23b-b486-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 22:01:07 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31OHhrd0013916; Fri, 24 Feb 2023 21:00:49 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ntnf3p6e0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Feb 2023 21:00:48 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31OJRJfe017909; Fri, 24 Feb 2023 21:00:47 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ntn4a8x58-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Feb 2023 21:00:47 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by SN7PR10MB6306.namprd10.prod.outlook.com (2603:10b6:806:272::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.7; Fri, 24 Feb 2023 21:00:45 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6156.011; Fri, 24 Feb 2023 21:00:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a66a23b-b486-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : message-id : date : to : cc : references : from : subject : in-reply-to : mime-version; s=corp-2022-7-12; bh=vOy8hyoDklmMCHfsfyOOAR4DHQhdsA9Rm1ZTeHKciwQ=; b=Mqc/efwvPzqVZF3LG91gxwN4rtCNrUavcW+4Ye1g/F2k2It1k7KYpiO9uESrLmd9Zupi IJbqWdtMkMCKuAFHxEypx1/rUBB/8fRN7zUr7obk9VYE5dfx0kCqfaziBOlWpdX8K2T6 yUORg59st/2GJhLyZKWVJ+wTCDbgUlh5sgYHFSA3Y+/IpeyzCKD3oAJN55DO2QCs/YEZ KHoRUJ7ZufHCOTDW5Cua7hUU5UATQp40KrnZOOCRBvSECSGwir3Xt2CTmPYHRjaYvbIn r7QqGRPXPhKz+M4ZkICIaCuzHAuS8FkYRmSM/i2BlTIfj3ehuaqNBiGZr9CyygO1VZyv ow== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GOHIc2pcFDJSlp/HX4QCNJU9g4fJp3VEjJhHnMtPYNwImc7O98HE2ezcHlmTj4W7BNtTGMezhHRZ+gqmr3NjaEjOKHPj9fl0AB5eGKmIllJCDEy68dpHMMM8CyjHicxhZXV8Wqm4mQ5zbzSSf/yV9I5EGhlXZjM10C1fBmW3/LO0GEcWG/jgCumNmQDRXgcAJ878UGecr4kzxR8JUHbG73dKxlCkNN4NaL32QAfK0hEbcPtC7S3kO4zfflEkpMoLDCG6gmO7RCtPWMnj9jYuap67z8C9Tmcn30lLaVqTmFg1HE5Y+JM32IQZ/yum+tSA3bnyexIgFUWcYKTGmreUmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vOy8hyoDklmMCHfsfyOOAR4DHQhdsA9Rm1ZTeHKciwQ=; b=c9aoe/D3yttUeNw5Kl0MG3IIrwh2mRSB66ecZ2P01QLzbi8GriUvqWSxpG8qpXBP0xvGapguhT5gizL/xON3qjvXf1w15xgdE2Em2CPGsqJIhnxxFGpheUR0slUUUzvjIYf9bkrQE7bt6CzlNDo8P2ydzXodUdTwZ9yBqabiIaaf0ZQKPzs4YoPkQ5Yo/j1E2mt+eVU1m+xbiX8xZbpIzp2g/xXNX2WMoxFvunprtX4tYt/mxrd9I6CluVM0DPfe72UeBQusDyZHZ0JsmncSGA706WD9EKCgqNM6nqu1GkLuaLoyVfRdoHnm5VUvY618gJ/NUl1saV1p+CWiFe+NXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOy8hyoDklmMCHfsfyOOAR4DHQhdsA9Rm1ZTeHKciwQ=; b=IgnfMxoxeqTY3qKmEZVWI7QJNZ2lDQv7MnJitGd/jsU+YUPnNAO8vaL/WX1gTS4mfbwfpLJj18hgGdP983IJUFizhXwyDlTqTJ4Kmaxbsl3Bq7F+t5Kfyh0Crl+cdY2qf3Cj5IOfVu4bfpbH3ty42nmrJ0Llg+LEqM4HudWfobM= Content-Type: multipart/alternative; boundary="------------uotFtvk1TJ01T7YycLlyAdqY" Message-ID: Date: Fri, 24 Feb 2023 16:00:41 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> From: Boris Ostrovsky Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain In-Reply-To: <20230223093243.1180-6-jgross@suse.com> X-ClientProxiedBy: BL6PEPF00013DFC.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1001:0:21) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|SN7PR10MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: e5315b1b-3504-4f62-7559-08db16aa324c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DDbngg3yay68QbKCVmIhheTuzjAVnlid/6E4H/LeSEHeLZet45j37ae09slk09tNAD8fX/B89YRs/OBaVtSRK8R5DhdJinX7rYreRwGwcR2rR7yw5v0WjFx9JHVZLfBQbZzkc0J086i/q7uwCs80aHI6k0fLGSXxl4XTOEup+9g6CvN5i7f544L+lw2J9MHkitfob8yXr4tq/cmV+tmSP71mhoujSrbrV/+JUxy8ohf/xhAaYQ2Llg99RSqRnASYC0lpF55h0PWPuQGEQcCe5XbgP3XnMbhTlozcUTWNlOIbu1d1sL2PNJEQaEFWK49f0MQxVZ0JSXCuccouppgIbG9+/WI/3DQrLwAGpLe1QRtpvoj1dACD0Ab+pJir7ggFTUF8pUZHQl6kLjEYjCO0DKv4OwlJdKl29LQUqEPEgRyhZzoBBl07T/q9c8HwZjvaIt1V4VS6ZvHMcNEX9Qh7sjzqeeai+ae1T8saZb4Wj7q+sSAyf6RopVtm/XNvD8syChaWMgCr6zebrG/NFYHaMrRaTKVShkegv5GR+pKHMfeqdYNwpjNWYtsuckAJ18JeGQUEELH9pmHncww56qm1qcB0En+ffNRQOUGtekv54m30N+9ibAFgI3JG8s/aAx5F5Q/a2CatJ3D4Kf5o3QDkP9rFbKpxx+VNOkL+3rqNBgvaPmKAAPNHTWoD5eAHSBhe0jMAn758HYUw9w7Gak+nlZR+7JWyn62wvzmyRhOV5xU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199018)(31686004)(44832011)(86362001)(31696002)(2906002)(38100700002)(6486002)(478600001)(53546011)(33964004)(26005)(186003)(36756003)(6512007)(66556008)(66476007)(54906003)(41300700001)(4326008)(66946007)(2616005)(6506007)(6666004)(8936002)(8676002)(316002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjhPNEhyK0VUVDZKYzRPYmRRN1ROMlRWbFJRK0RENG9JVFpMYWZGMTRGMUZG?= =?utf-8?B?WmRDTHZXYUxVTVJlS1FTMld1U0lzMXg3YW9GUHBJSmRWcGo1OE5Xbk4vOHkz?= =?utf-8?B?eS93OHB6M1FXRXJqK1dYdmdlRlF6UWt4K2hoMDJuMFhoNHBvaTVQcnBQYTRX?= =?utf-8?B?ekpOQ3V4QzdubUxLZHlycUVzOWo0cEoyWGs1U2pGRUR1eVkrMERsLzdmZ0VS?= =?utf-8?B?NUNEcnlpYm9TZXBBQVREUCsxNFR3b2xLUTR3Q2dKdlF1ZndJM1l6MnNRMVdr?= =?utf-8?B?WGlzTS9TTmNydFZUM0lIQkRDcS9qbTZYdmoraVdjWnY1VTNuSUF1elc5YmJu?= =?utf-8?B?S3R1U081M0pFcHdiSGJ5SzNaa2p2MGJMbVVxNXVSTDR2QjJQdGVCbVFlR1lL?= =?utf-8?B?NGhaUUcxMjdabkRDU2EraFJraktLRzJMTXFmR2JIWDFkenZ2UEZmaHk4bWNt?= =?utf-8?B?NUpLLzFyQ0xqUkd1SUxIT05Rb2dUbURPMVpsSkR1L0JrSWVsK0pJYmRaRWJk?= =?utf-8?B?VVJlK3g3ZFR3NHI0NnI5MnpieFVqdDB5dzROTVlVMW5lcmtZcjhYbDVVRnI1?= =?utf-8?B?SjBoempaaHZaWHVKN0w1T1N2TzFtOElxZkRDQUc4bTZnbXBKWjRSYUpJQ0hC?= =?utf-8?B?YXBhdVgwKzBlb0VGUGJNa2tvTXp1UWQ5emp4TW5uWEltelRwU0hDUWR6OWor?= =?utf-8?B?RXdtREE5OElSMEZlSUZuZXpRWXNaUFZrb255ekJzZ1VOMXFnbHRJZkRNT1pV?= =?utf-8?B?SE9zRTFROHp1VnBpOEtjeEo1VVVYM0RuVFhQWGdvZXlQd0ZNOEZUUjlJb1gr?= =?utf-8?B?SlVGdkRUeENXQ2tJUS92TWx2M2xZNGdZSHlBdDlQN1NkbngwY2dUNXdZTlZI?= =?utf-8?B?Z3pQVGV4THNScW52N0Y4Sm5MU3JrM1FvTmxDWVo0MU1VR1N3VFY1c0NZeDNR?= =?utf-8?B?YjlyNkZyaDA5clhoZVpyK2V6Mm1ycmFDL2dMTm11YXBPREpiM3dMKzNjRFRM?= =?utf-8?B?Q3BJcDErakYxL0orb1ArdTFZQUt5UHZIR2o4ZG9zQUdHeGkrbVRQZlNHOFMv?= =?utf-8?B?RnBoMFdrK21ndmc5cjlNWll5dmVDVWVvVGxPSnczV05EMC81UHlqWE1keXIw?= =?utf-8?B?VEptcEdPUjFNNzhqaytZc21PZ0IvcThNaGU4bzZOY3lkRmRRYkRSQmJUYzll?= =?utf-8?B?di9yUUlETDVDb0R3NkVWb3lpMVVsanVrTDkzaDRYdzBrckovbUV0YzJ5UTR0?= =?utf-8?B?RDlNMUc4Y0pJMDNtc2p2UDRrek9halEwSTlFTjM3VGl4UjZUdFFIZWM1aXBa?= =?utf-8?B?RVlLUGxaakg2UmNRQWdTejZ4MFZma1lwZFJUc0NvMXFmV2xFRy96ZS9nbFhT?= =?utf-8?B?NXVXdmRMZ1pWRVBGaUNtaVdGbWh1NUkyU0xXRkxrUlhjQnRtY2x6dFFjaDd1?= =?utf-8?B?Vkhhc25BdzlTcC9Ka2ZIWVg4eTFjbWpTZUtzNi9tbUs4aVgwUVBXbUdVUjV4?= =?utf-8?B?L1VNUEw0bWJJdlBnNTJvK1ZRYjNJUUlwdFpmWHRaRTQyaUI5ajFsRjJ5TU01?= =?utf-8?B?bUpaQnlmK1Q3UW1HNmxqV3hqQW5TOHJzeEttTmZ2cGpXdmtTYVprNGUyZFlP?= =?utf-8?B?dEhyTzRmWHlwREVOU3kyOE9ENmpTSituRTlacFFZQ3RFMjRwNzc3L0EyODJX?= =?utf-8?B?bVNYWnhmYTdBTFUvNklPcWlVUE00WC9zc0l5OHJDMGhoOXRDVWU0dVlOMDRL?= =?utf-8?B?R0lIT2R2eld3c3Rub1JvUEY1Tkwxd2ovakxGSVVJbnJWanRjdXVCcHdoYmZM?= =?utf-8?B?akI0Zy8xcWMwaWU5M3g5Q0ZjN3JJSFJRbUY0dmVQdWYxclVRRldtaWZYbXRj?= =?utf-8?B?TDUvWDJwSVFoODdQNkpjUlBZeW44cm1QaVFaUE5LcFdqNUR1VUZlVkZDT240?= =?utf-8?B?bmxLL0lKeFl4dkJMbTdzVXFZMGp4ajUwam9IRlRiMElwRFlCOTVsVytSMmdV?= =?utf-8?B?eFN6VytRTkdwYklDMUxBcFJpWUZ6bjRiODcrb0w5SmVLd0tWSnNlLytRWTBu?= =?utf-8?B?eDFXaWZQS3gwN2c2OTNCMjJtL2w5YjVaL2U5S0dDTS9IWTRzSE9Wdlc2TCtz?= =?utf-8?B?NnFGSS9MVUxvSXFvYXlDWElDbWJPekFoY1NoTk0wZkNMcHRjclJlaVZzUDY3?= =?utf-8?B?RkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Mk40a2VaeWtMUVNVL2ZQMWJqNCtXZE9XY1kyWHhucWo1TWpKWlJyTXF3cElz?= =?utf-8?B?NWY1K3VtVTJlL0ltVldzMzlZMmYvZ3Y1YjQ3Q1ZrVzdidWJRMWRMQ2hPVWpM?= =?utf-8?B?UVBUbVlYNDlPaUhkbzh2VllvT0RNWmVCbXBMMkFETmRoNjI1SWpLaEsrZGI2?= =?utf-8?B?MnNRL2EzUEt0KzZEd0tHOXNDb1RiZUxPUzNpZHBqbE1ac0Flb3lsZmMzMk81?= =?utf-8?B?TVpPaHlXUEJ4NmtaVHRyNW51ZjBPQ2FkVnMzME9pR3lkc3RZd2prSVhXVWhV?= =?utf-8?B?WkV5Sno3M1g5Vk96VjhsdHlRMjZQZU9oY1hoaXljWGN6VDYrZlhrZm9LdFIr?= =?utf-8?B?YjhyckJzTUlSQVJzNTdBc0xtcklmUkNMS1lSQ1hFek9RZXRSWG1Uc1pXTTZx?= =?utf-8?B?S3BxdjVtVFV0ZUE4KzRtai9hdG9EZWpmMmVWUlo5WG1kWFRmYzYvblZnNzF1?= =?utf-8?B?cnRNWEc2bFV2eGNRT0dLNlhGMlpUT2xyM2JyZ0NUNXBrT3JRMllPaG1hbFQ1?= =?utf-8?B?V1hUSGR4T1VWaDU0QWJ5eFdFWlR1VmFVUTh5NHowelVWMXlvdHJJTFFsUExa?= =?utf-8?B?dmhhd3ZVLzVpOEJuRkM5cmZGUktqa0Y4MVhtZFFZc0tGSFJCbU5qMlpkQmQ3?= =?utf-8?B?eFIvZmdOejdGc1BTQitHNlU4eFpnaGJnRitVOG0rMDFBeURjLzN3TkVlK1Js?= =?utf-8?B?M3NSZndpeEF6Vzd1QVpZVUFRd3VUZE5Zd0l2M3o5MnowcVNaWm01ajYyRmt6?= =?utf-8?B?ajJ6b3VlSXJjU0N3a1FpTi9DLzh3RmJoN2NnUmtjK1VDYVZRUldPZmtsOXlE?= =?utf-8?B?Q2VDVlQ0eVF4NEdCejBxcUNuT21XanBqUTNySEd0WnVlb3FiUWpvWHNqd2Fz?= =?utf-8?B?RU9PTStza1hCYUZURmhvM2dwdGx1VFFNOC9NMXBLYXpRSkhEZUZDT25UYm5k?= =?utf-8?B?QmpGUHpidWVaR0V4Wm45Ti9SQkUxcXRyczIrODRYQmFpNUNFWFZWdzFnRWR1?= =?utf-8?B?SzRaUVVyb3FSVTBoOWpMQlFjSlYwZVFYMk1BcVMreExrV2gxckZrUXV1c09r?= =?utf-8?B?aDlpMWRuc09QamhiL09FNjYzZjNvRExLYzU0TkJQRmZwbjdycVVOWitSK3Nt?= =?utf-8?B?QjQ2MHpyeHVOVUt3YW9UakRZeENCaFdFZlRhOFNubFFWeDdLM2xqNUJNYXc0?= =?utf-8?B?ckl6OWVjN0RCeFF0ZlpnSHh6dm8zZk5GR050a0cvZUZzTlJNeThTaTY0cXBX?= =?utf-8?B?UHJ2MWgvSkliTDVFYmJlTlBSa0lmaDY1TmdRNWdiV3RucVBVK0NWQ1pvL0Q5?= =?utf-8?B?SU93dnZUQmNoZ05BSkxMcWZvbGtaeGtjcnRtUlRXV2ZMb2pWelNzOFJGUmNR?= =?utf-8?B?aDFUb0RxVkUweWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5315b1b-3504-4f62-7559-08db16aa324c X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 21:00:44.8586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xjB88uS0vXjeEM0401Nz1x2cQ/ydsaXUutLTZLfBKYcRlw7BqAT0yVTGQGQh8btKx+mTjXFor7ItLdXQtfohTYr9WSvJ7Re1wT2pJ1UIzoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6306 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-24_16,2023-02-24_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302240167 X-Proofpoint-GUID: 49OyB_PtiI9uC9bpHgjiHA5PuqX_GZt3 X-Proofpoint-ORIG-GUID: 49OyB_PtiI9uC9bpHgjiHA5PuqX_GZt3 --------------uotFtvk1TJ01T7YycLlyAdqY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/23/23 4:32 AM, Juergen Gross wrote: > + > + for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { > + op.u.read_memtype.reg = reg; > + if (HYPERVISOR_platform_op(&op)) > + break; If we fail on the first iteration, do we still want to mark MTRRs are enabled/set in mtrr_overwrite_state()? -boris > + > + /* > + * Only called in dom0, which has all RAM PFNs mapped at > + * RAM MFNs, and all PCI space etc. is identity mapped. > + * This means we can treat MFN == PFN regarding MTTR settings. > + */ > + var[reg].base_lo = op.u.read_memtype.type; > + var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT; > + var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT); > + mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1); > + mask &= (1UL << width) - 1; > + if (mask) > + mask |= 1 << 11; > + var[reg].mask_lo = mask; > + var[reg].mask_hi = mask >> 32; > + } > + > + mtrr_overwrite_state(var, reg, MTRR_TYPE_UNCACHABLE); > +#endif > +} --------------uotFtvk1TJ01T7YycLlyAdqY Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2/23/23 4:32 AM, Juergen Gross wrote:
+
+	for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) {
+		op.u.read_memtype.reg = reg;
+		if (HYPERVISOR_platform_op(&op))
+			break;


If we fail on the first iteration, do we still want to mark MTRRs are enabled/set in mtrr_overwrite_state()?


-boris


+
+		/*
+		 * Only called in dom0, which has all RAM PFNs mapped at
+		 * RAM MFNs, and all PCI space etc. is identity mapped.
+		 * This means we can treat MFN == PFN regarding MTTR settings.
+		 */
+		var[reg].base_lo = op.u.read_memtype.type;
+		var[reg].base_lo |= op.u.read_memtype.mfn << PAGE_SHIFT;
+		var[reg].base_hi = op.u.read_memtype.mfn >> (32 - PAGE_SHIFT);
+		mask = ~((op.u.read_memtype.nr_mfns << PAGE_SHIFT) - 1);
+		mask &= (1UL << width) - 1;
+		if (mask)
+			mask |= 1 << 11;
+		var[reg].mask_lo = mask;
+		var[reg].mask_hi = mask >> 32;
+	}
+
+	mtrr_overwrite_state(var, reg, MTRR_TYPE_UNCACHABLE);
+#endif
+}
--------------uotFtvk1TJ01T7YycLlyAdqY-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 21:07:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 21:07:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501582.773409 (Exim 4.92) (envelope-from ) id 1pVfHS-00026I-Fa; Fri, 24 Feb 2023 21:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501582.773409; Fri, 24 Feb 2023 21:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfHS-00026B-Cr; Fri, 24 Feb 2023 21:07:02 +0000 Received: by outflank-mailman (input) for mailman id 501582; Fri, 24 Feb 2023 21:07:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfHR-000265-8Q for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 21:07:01 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2af96e2b-b487-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 22:06:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2af96e2b-b487-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677272817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EkflLGL5Iq06WiyTlOwBMTCMQw+4i7UVOQ5l5q9ecsg=; b=cs9Saw5aPVPDmDY2ILlrsYYc2h5VZR/WMyfADWId0jRb+aVbJPzfmEy/ N1PecRHTp44NUGR4M5rLjDsfnpZpsu/9XlmugPLuss78P6HZQPujfh2qX l0QgTYmIlNI6QwztN5lLQ96EbyfOGKq4kQKSfxIzWcPZPe+rYLP1lGOQE 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97854733 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:dXTAt6tIWft0F/36kytapTs2wufnVE5eMUV32f8akzHdYApBsoF/q tZmKTuCPfnZMWfyLopyOYiw9x4E6MeEzocxQAc5rSowEyND+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEyyFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcBQidkvAgOuN+Z2ZDeJPotwDKZTPM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WxRepEiYuuwc5G/LwRYq+LPsLMDUapqBQsA9ckOw9 z2WojimWUpy2Nq3lxqJqWirovDzjSbwebJPF+SfpvRGjwjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O88Q5RyJy6HUyx2EHWVCRTlEAPQsqdUkTDgt2 liWlvvmADVutPueTnf1y1uPhWrsY25PdzZEPHJaC1JfuLEPvb3fkDqXavl7S+2yh+bMNhO3y BOutAg72pEc2JtjO7qAwXjLhDelp57sRwEz5xnKUm/N0j6VdLJJdKTztwGFsK8owJKxCwDY4 SNaw5T2APUmV8nlqcCbfAka8FhFDd6hOSaUv1NgFoJJG9+Fqy/6JtA4DN2TyS5U3ic4ld3BO hK7VeB5vsU70J6WgUhfMuqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/5gY 8nAL5f1UytFYUiC8NZRb71AuYLHOwhknT+DLXwF50nPPUWiiI69Fu5ebQrmghER56KYugTFm +uzxOPToyizpNbWO3GNmaZKdABiEJTOLcyuwyChXrLZc1UO9aBII6O5/I7NjKQ1w/QLxr+Xp yvVt40x4AOXuEAr4D6iMhhLAI4Dl74l9BrX4QRE0Y6U5kUe IronPort-HdrOrdr: A9a23:RISJnKFWga3zzLjWpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97854733" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Xenia Ragiadakou Subject: [PATCH v3 05.5/14] x86/svm: Decouple types in struct nestedsvm Date: Fri, 24 Feb 2023 21:06:16 +0000 Message-ID: <20230224210616.2818727-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230224185010.3692754-6-burzalodowa@gmail.com> References: <20230224185010.3692754-6-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain struct nestedvm uses mostly plain integer types, except for virt_ext_t which is a union wrapping two bitfield names. But the nested virt logic only ever deals with it as full opaque register. Switch it to being a plain uint64_t, allowing us to hide even more of the SVM internal infrastructure. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Xenia Ragiadakou This allows virt_ext_t to move out of the public vmcb.h along with all other vmcb types. --- xen/arch/x86/hvm/svm/nestedsvm.c | 4 ++-- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 92316c6624ce..153a37f2f227 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -164,7 +164,7 @@ int cf_check nsvm_vcpu_reset(struct vcpu *v) svm->ns_exception_intercepts = 0; svm->ns_general1_intercepts = 0; svm->ns_general2_intercepts = 0; - svm->ns_virt_ext.bytes = 0; + svm->ns_virt_ext = 0; svm->ns_hap_enabled = 0; svm->ns_vmcb_guestcr3 = 0; @@ -526,7 +526,7 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) /* LBR and other virtualization */ if ( !clean.lbr ) - svm->ns_virt_ext = ns_vmcb->virt_ext; + svm->ns_virt_ext = ns_vmcb->virt_ext.bytes; n2vmcb->virt_ext.bytes = n1vmcb->virt_ext.bytes | ns_vmcb->virt_ext.bytes; diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 94d45d2e8d47..184248bbd7c5 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -44,7 +44,7 @@ struct nestedsvm { uint32_t ns_general2_intercepts; /* Cached real lbr and other virtual extentions of the l2 guest */ - virt_ext_t ns_virt_ext; + uint64_t ns_virt_ext; /* Cached real MSR permission bitmaps of the l2 guest */ unsigned long *ns_cached_msrpm; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Fri Feb 24 21:33:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 21:33:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501587.773419 (Exim 4.92) (envelope-from ) id 1pVfh7-0006qN-IM; Fri, 24 Feb 2023 21:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501587.773419; Fri, 24 Feb 2023 21:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfh7-0006qG-Fh; Fri, 24 Feb 2023 21:33:33 +0000 Received: by outflank-mailman (input) for mailman id 501587; Fri, 24 Feb 2023 21:33:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVfh6-0006qA-1i for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 21:33:32 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e043097e-b48a-11ed-88bb-e56d68cac8db; Fri, 24 Feb 2023 22:33:29 +0100 (CET) Received: from mail-dm3nam02lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Feb 2023 16:33:25 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SN7PR03MB7130.namprd03.prod.outlook.com (2603:10b6:806:32c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 21:33:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.021; Fri, 24 Feb 2023 21:33:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e043097e-b48a-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677274410; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=d5Su5P1+VSQFCaK7xzz2jg71qjinsOyXOTwnal9daHU=; b=cfT9omLJhyVi2D7SDdbR7swbBpaTB9o1/5RFugd5g5O0z6QWkiH+X02L qWkIpzQKNX7JNGqHhshjLSgMI8kKwtZjYiqppmKDn5sso3c8P25JMEpyY O61JhqDjF4BU6cOWIDCdD0jzZaLzak04aqJGA6muYmzlurexFlOT6gliu A=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 97300687 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:/BspgK38hdfjaS7XKPbD5T1wkn2cJEfYwER7XKvMYLTBsI5bpz1Sz jcWWW+BPPzZYWSge4p0bI+0oRwH6J6Ey9JkHQRrpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkOagQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfAWNA3 rseeAo3VyukueH1kbLrRLVTiZF2RCXrFNt3VnBI6xj8VaxjbbWYBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvS6PkGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHygANpMROLQGvhC2VyVwGpNVz4qcgW9/N+njWCvGNxgN BlBksYphe1onKCxdfH3QgeqqXqDshkDUvJfFuQ77EeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5ty8bniJE+iFTIVNkLOKyoiJvzEDL5w TGPpQA/gakeiYgA0KDT1VPKnTOq4ITIRwgd5wPLU2bj5QR8DLNJfKSt4FnfqPpFd4CQSwHbu GBew5TCqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meK0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:j+heI6DI4e9FCXPlHelc55DYdb4zR+YMi2TDt3oddfU1SL3+qy nKpp4mPHDP5wr5NEtPpTnEAtjifZq+z+8Q3WByB9eftWDd0QPFEGgh1/qB/9SJIUbDH4VmpM JdmsZFaeEZDTJB/LrHCAvTKade/DFQmprY+9s3zB1WPHBXg7kL1XYeNu4CeHcGPjWvA/ACZe Ohz/sCnRWMU1INYP+2A3EUNtKz2uEixPrdEGY77wdM0nj0sQ+V X-IronPort-AV: E=Sophos;i="5.97,325,1669093200"; d="scan'208";a="97300687" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mkr1EQx6w8p3g4RLfyn5hgqeI/SwQZtKQe3zxpVYgKaSO6uRldy/SQIgIqs482e0g7ijRrRnk4C2jgVIFxV5JZEnyBjiyK7Ide/cnKYDxEpckTtUHxR7bolkj3QSnb966gIsrUkcyU9UYgFGK+vQtJF/6chJY8bIXggg3X+cSP/6HC+4VxdxXPbd8InOCfMqgpMNHAvvRLE6zttTJRe/zseB+65lvncTJ3jhTWVp58K7dOCgldQ5NQC9pGBwGppIrhsnVIQzih8WTv885aKgUvPiVVjLKx4fTGJU94OU4eEoaNicAq3yq3tgwBxCUANFOn1C8ZvZJzKKFuMNyV9pLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5Su5P1+VSQFCaK7xzz2jg71qjinsOyXOTwnal9daHU=; b=G/ebgzuYVeT7FOyhFPBm+BxHlYEYIUXmoKdKUdEctMbstQJa/9LLUZo2IkFI/Q8ONxG8rW/lP/vYOOU35np+iGVVBeyJWIQ37FD188J4IHwY7JmeJTMYY1nF1w3zR+4g2NRkEpiIrAZLdAyBQnqvkFOddhsxUl9DMSMtNM6PzapGyExo2llgGE5f1elrfYGcqU3jOrwmmdr2UgP5gYiZIl+6PWls1yjGeudAzDG6nmpgWHkfed8aVKg8UYMBhA87Co77i4hZ0FycD2UYlh0dObJ0xcbRerrl5GexJ1Y23GM4evLobKJ2hOFcud3ePzVgaCRJMzJiAsDuCrRpRI4HAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d5Su5P1+VSQFCaK7xzz2jg71qjinsOyXOTwnal9daHU=; b=rlMsi6VlvFxaWBgZDWoohcDadkG9agNSdLEn15Vdv0CCDN4aQGik2/1+SmxJUli4FedU9j4W2ASFF3ERdneQjHZiO4IywAeW7lYXY9NUI2wCF+NJyz4FuwMDA+fFYCciTcifr3pUUJJ/iivvWb7k3c9TThNS39BOS620zz1bL7E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> Date: Fri, 24 Feb 2023 21:33:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> In-Reply-To: <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0157.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SN7PR03MB7130:EE_ X-MS-Office365-Filtering-Correlation-Id: c9c17136-b919-4fc9-cb71-08db16aec068 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mzdjr6g/EisBmjrJnUU4b6FPP2sLD02qVCtuzHLjr4nh7IYpgpTHk1bKzoYG3OJ9XOPML6Vb+6dBq59KHMSKbOs7l45yMVIESS5m8cNIFVfjqx0Nlr+UvPYCb9UILco42oGEZf4cT2anjHYvsEFvD51LHIsrLWbH1PJZEdqGuDlMasrrbdH6dUYerKakXf6Hl4PhZCs/Jh3KW5ahA5hVhl0sNZT0uKrzntji9blEuy6dXJGYDuOo7hRMxmJC5Hw1i6weYdW0/QNQ0R35jhS84NZAcsFhLkg/lwBQCrFMzWM64hsNOkQ9rsZ59oVb/UklaZAqWw50nri/E+S3BSzjcJpX7/28FJ/8rn1BkqbFsvfpEXkUapS9CmTfMgD8gQJhc+rUQw9f41FzCO5nXtoYR00z7AKxvCCFh31wVV9SnMJQWLgNaWilwwKLrMr5zgBLR8XtGz1OLIbUiH8ssHUFQYR0wwWD7k1D6+kor8eHWItvypD74y/tkqncvH0pcdVzBR+4wbNEWdoseZrcCXw7LlxoF/OMOGK2Ln6T6xuRe2LP+5E3OK35Ak+sm/uTtXz4BWntaH4UYp98QG1x94wQNOkVZ9Zil5n6M7+AynMnz75Z2GbjqzpU1BQUWByhoaXY54l7XcK0CdXfuipC8urGPb37JwwGrCLkUhKS0WZoJ4agLOKRgSj2xKKblpGZ7+mBidbkNA/LOculrEsjYQZ0CmFxexPC8XawepLbWdQ/gss= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(451199018)(316002)(54906003)(6486002)(66946007)(8936002)(38100700002)(41300700001)(66556008)(8676002)(4326008)(5660300002)(6512007)(66476007)(478600001)(186003)(6506007)(6666004)(83380400001)(26005)(53546011)(36756003)(2906002)(2616005)(82960400001)(31686004)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djEzKzk1WE1RK2JhbzJqY09KSnpadW1Rd0luYWx6SVdQYkpTVmNzZ2xGWVJB?= =?utf-8?B?TUYzUXpBSjBMZlpNWnBlUzNibzJnUkFuMnhSakJXUlRmKzlISzBzd2d5VW8r?= =?utf-8?B?M2tCOWk0OHZJZ1U4T29DM1o0WHV2dnpkVVZVK0RYNm9YSUU0Vm53eE14K214?= =?utf-8?B?U3djL2pLWmpkY3RVT2loRklwWStJbnNZNHBNN1lNM1hpeTkrQ2FkNHRTOHJi?= =?utf-8?B?SkRoeWlVSVpWdkY0TzhoSDhTNWlEcUEyTXQvYXRRZUNDb1JtdWtTY1AzUC9C?= =?utf-8?B?YkYrVTRWZytkL0hZN1h2V3FPa256RDNiQzUreXY2OEtCZFpiL3NHQWNIWlJE?= =?utf-8?B?V2s3Yk00Y1doY0k1dnNUalhENVdxandwSEU1b2hzN2kyamd1bVZNdnowRFhr?= =?utf-8?B?eE4ydG1GS1JCQkxkZEl5bnYwQTNQWHNIQXAzOWtYU3duSHdKakcxMFZPcG5F?= =?utf-8?B?QURKZG42Tkg2MWlpUk50UUJMMzh1bTY3N3hFcUVZYTlRRmNyKzE1aU1tT0dZ?= =?utf-8?B?M1MxTHN4SC9VcFFDTjg3SldSUlFUaVVLQmxINU81L2JYek5tVlMrZVU0cnpG?= =?utf-8?B?Q3pZaENyZld3WXhBcjZicEFkRmxJZy9EY09qWlFqNXdvLzFoekhZTG9rRnFP?= =?utf-8?B?Nmk0ME5teXNEbXpXeEtVaDkwNnBleUNLK0FvT3ZMY0lRK1BjOHhYY2d3Rk1V?= =?utf-8?B?VjcrbTI4T2NDZE9hNVRsa1BOektkaVpKNWwycUxlZ3kyZVpwNDBRMkdWclFC?= =?utf-8?B?MDR2Z2thWVpjVXUxSi9JcEVQdGZOR0FSSHkwc3RWSUMzT2YvMHNKQnlWSWZB?= =?utf-8?B?MzJScGVoMDU3M3hmNTJJcjdxa3FUcVRGRUVPQ0hsR3NodXhhMUQ1SHdsdFlN?= =?utf-8?B?dXQrUUQvdjhGV0hYcUx0cCtqb053dWZDV2FnR1dEbkRoOUVlM3VaMHRvY2JL?= =?utf-8?B?dzdOOXJkMVo5Tnd3TFBUczF5OWs5OG02M2N5MjRkK21nVGZqZktOUitlUmJE?= =?utf-8?B?aG9DTUFNdmtIbVB3WUJ1eGxyMVNBZ1g1ODA5Z2lIWWtLZWU1Q2FoRjI5YTNl?= =?utf-8?B?L2dSOFVLT3BWVlNST2daM1Q2UzBPYWhGNm15aGU3M0pXTU53N0dSUXRFUlNG?= =?utf-8?B?TVNQeFZEUU1pMlNxMExIQmpGOE9WZnFGRWEzUnFsN1VleVl3L0NGWDlLRmhn?= =?utf-8?B?MmlHWGpFbGZjZDZoVzBkS05RSDRQVEFsZnc3UzBydm1rM0VlTWhOaHZlT0VM?= =?utf-8?B?VGQ4K3lKSmlycTQ5U2dZTU45T0IrVjRrNGtHSGJxc3RQNnVjWVRiS054Q0xx?= =?utf-8?B?NmNHZHNpTXRITmFzNytCK29UMWo4M2sybXVjNGlpNmk1M2lqVXJlekFYSjBX?= =?utf-8?B?QTJmeWNrb2FCVzVxWUJwbUZva0lKRk9YQlhiQTRDaXhoRUhNWCsybjlKVVBh?= =?utf-8?B?Q3ErY0RpcnhQYUFIbFFZTGV2UzhlZTVtWmdndS81Z0t6VjliSjNmWDRrNitx?= =?utf-8?B?K0lJNFZJdDFJWmE3OUxsK282WFhzV29JbEFwbXJOUWZxZUxZL0dveFRGQk5B?= =?utf-8?B?bUdHaGRVYW1JM0NwOVFrYlkxRk9BcjRsTUI1cCtPRElaODJvY1ZXTHQrOExk?= =?utf-8?B?RlprdC9aN3BUMkRYYU9qS0xlWk9UTE41Vm5TY0xmNzZyUGtyMFQ5RlpUdC9H?= =?utf-8?B?amhhODBIY2NjeGRxUGhiM0lQdEh3ZUN4NWhKZDBSNmU0WDBBdXpIbVBpUThB?= =?utf-8?B?dFdIVGs2MSs3TldGR0YzOUxQOHIxRFhHU2J3Q0JZdDRmd0ozRHdzTzJld3Rn?= =?utf-8?B?YjR0b1FscU82WlAwNUJESjFNNEUxQWczRXl1a1E2SHZNQk9FeDk2RVRUaWtp?= =?utf-8?B?MzllWmpuN0kvckRSUjJyRVJlNUJXbFJmcHc5UEQ0QkJ1YVlOeE5QVVNUOC96?= =?utf-8?B?RzV5TCtwaG52alJiN3cyRlgxaWdrVDlIaHhkL3lpRE9LZ0hkMm5wa2w5V2lH?= =?utf-8?B?dEVuNXh5amRPWFNFazF0N3ZSWVVBY0toMWFpUkdGS3N5amtqSnZkamdZUVZs?= =?utf-8?B?S1QxSHFIN2JVei8zaGprWkYySzByWjYxdXBkYXhtbXFiaUxIMzFLN2VYQytZ?= =?utf-8?B?akF4Z1dINzJYU0NjVm9QTHNlYW1jaVprTVpMRUZVN3ZDWmVTLzZQTW9icllU?= =?utf-8?B?M0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UZkmxKhv64Ijnldor02OjKkBtXQ+iIL/ePtdpi2LrWBqN7Bp9IsDWJDYmAj8sdMOa4TeGSANV4g1OA+QYAhiKQVraH6yufY+TNKKBB7qghNW0i/fostF9CGKaP6ezV0VMX9NICuh7tMwfRlUL0gWi8ESOPt+s9G5PvDA4C+esjQt8ClcCd45RCDKr+Gzxz3Tz94EBHfrIlQ6Hx9R8b6SZ6LY4gmM9GObGizmR0sghukICW5a77RE1qKoZJfnIYusmMJAxu10mNED0UEMWZxuiVlVzuZIUMEjvrw7FvNqt5vm7sDLzVEYJb72O4CUZI/Q/ANptJEjh8PbwFU9ItteoTIhnW8sWtQ2G6QrSOeTWWY7rhjGXCSWb72c7vhQXJY2Iatowx+cNhi+It3HI5OaViCSxAoXSfz67gXLpBL6140J+bolYcV6qPf4a8AqjdqwVaM+Ifo+L8olT540vNZjEiOuYR/CR0CEzU7tE91iJfUGLemOp3NBo+jf4gvk30LkkkmKXF5ghb9OlmCBuCQnOju2gtGFB6nAHCf86X/FKBDKcM+ab1K0If/qOqrb6+MkAz9EU19cHcBK93Tx0Bb1MgQeqRtuB9YoMbFiiyvZHHvXde3uarov6uz0yRAgSAePfE4IV2LfiUFi//Qr58VjJM2HQ+GbXdOHLylDMlT4d1MeTomiK0m1YzrQT27S/xWdG7D7mVddSa60VhEE7VymrCrikCp/vbsttFg9Xbv2oRZ3MHSEJXf1woNkZ1r1UMGcyqP6+EYYxKgaXackRySE38AvsNRELLuS7Hw/Bz6VHbRRXU3eR+fOQPIiGk1jFg3Aazv11KUQgvFgG5oYR98uPaC1UeL8R9oggXKpaAWkp4/FtPjicoWJ/l/GuV9IVvjX X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9c17136-b919-4fc9-cb71-08db16aec068 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 21:33:21.4395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hc0geAOlqWbr9HjtwuJwusKBFyU7WbJGVTHMuUQSX7WHB9qUjh34vdG2rV9EYBVbS1rfwhJyHc8MO4HgeQ5jaimerXuWSXkR8mRaBehtZhs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR03MB7130 On 24/02/2023 8:08 pm, Xenia Ragiadakou wrote: > > On 2/24/23 21:29, Andrew Cooper wrote: >> On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote: >>> There are more detailed per-patch changesets. >>> >>> Xenia Ragiadakou (14): >>>    x86/svm: move declarations used only by svm code from svm.h to >>> private >>>      header >>>    x86/svm: make asid.h private >>>    x86/svm: delete header asm/hvm/svm/intr.h >> >> Thankyou for this work.  I've acked and committed patches 1 and 3. >> >> Note that you had one hunk in patch 5 (whitespace correction in >> svm_invlpga) that obviously should have been in patch 1, so I've >> moved it. > > Thanks, I missed that  ... > >> >> Looking at asid.h, I still can't bare to keep it even in that state, so >> I've constructed an alternative which I'll email out in a moment. > > I 'm also in favor of less headers. I've committed as far as the nestedhvm move.  At that point, I've sent out a small patch to try and help decouple later changes. But I think we want to change tact slightly at this point, so I'm not going to do any further tweaking on commit. Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, updating the non-SVM include paths as we go.  Probably best to chain-include the other svm/hvm/svm/*.h headers temporarily, so we've only got one tree-wide cleanup of the external include paths. Quick tangent - I will be making all of that cpu_has_svm_* infrastructure disappear by moving it into the normal CPUID handling, but I've not had sufficient time to finish that yet. Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and disappear (after my decoupling patch has gone in). After that, hvm/svm/vmcb.h can be cleanly split in half.  struct svm_{domain,vcpu} can move sideways into hvm/svm.h (with a forward declaration of vmcb_struct), as can the svm msr intercept declarations.  Everything else can move to being a private vmcb.h Finally your svmdebug.h can come at the end, pretty much in the same shape it is now.  One thing to say is that right now, you've left enum vmcb_sync_state public, but it's type is already decoupled by virtue of struct svm_vcpu having a uint8_t field rather than an enum field. And I think that cleanly gets rid of the entire asm/hvm/svm/* dir, which is a great position to get to. Beyond that, you will want to clean up the hvm msr intercept handling as hvm_funcs, which I think will decouple the vpmu files from svm/vmx specifically, but that will want to be a separate series. How does this sound? Thanks, ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Feb 24 22:24:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 22:24:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501596.773429 (Exim 4.92) (envelope-from ) id 1pVgUO-00061Q-An; Fri, 24 Feb 2023 22:24:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501596.773429; Fri, 24 Feb 2023 22:24:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgUO-00061J-89; Fri, 24 Feb 2023 22:24:28 +0000 Received: by outflank-mailman (input) for mailman id 501596; Fri, 24 Feb 2023 22:24:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgUN-000614-3S; Fri, 24 Feb 2023 22:24:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgUM-0003c0-Vm; Fri, 24 Feb 2023 22:24:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgUM-0000lH-Hu; Fri, 24 Feb 2023 22:24:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVgUM-0007KD-HN; Fri, 24 Feb 2023 22:24:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rcz1Yg4101kd3kXWB466jXNmktqNd6N1oPM7xnoMm+E=; b=o6A9A5JiX1FbfoBV8IZP7P7DSe ZyuHis58jghBnFfZomrFDhQS8fhltEupcPOwj2qr/Q5b5lrpAzPiyNZhFLCNf6l1c0IiRu2AaTzb/ a1JzCBkiBcxwJ8QS+KlhtnU3npXbQqCSysuv91yv6EqYEXqxtdinmQMONhkhy0+Qt1MA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 178315: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 X-Osstest-Versions-That: libvirt=110d209263022c6029e398116154562518e4a474 From: osstest service owner Date: Fri, 24 Feb 2023 22:24:26 +0000 flight 178315 libvirt real [real] flight 178389 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178315/ http://logs.test-lab.xenproject.org/osstest/logs/178389/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 178389-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt 6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 baseline version: libvirt 110d209263022c6029e398116154562518e4a474 Last test of basis 178089 2023-02-22 04:20:19 Z 2 days Testing same since 178202 2023-02-23 04:18:58 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Fedora Weblate Translation Jiri Denemark Laine Stump Peter Krempa Stefano Brivio Temuri Doghonadze Weblate jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 110d209263..6af048339f 6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Feb 24 22:55:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 22:55:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501606.773440 (Exim 4.92) (envelope-from ) id 1pVgyI-0002Tc-OW; Fri, 24 Feb 2023 22:55:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501606.773440; Fri, 24 Feb 2023 22:55:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgyI-0002TV-Ll; Fri, 24 Feb 2023 22:55:22 +0000 Received: by outflank-mailman (input) for mailman id 501606; Fri, 24 Feb 2023 22:55:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVgyG-0002TO-J9 for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 22:55:21 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a25df9e-b496-11ed-a82a-c9ca1d2f71af; Fri, 24 Feb 2023 23:55:13 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1171C32001FC; Fri, 24 Feb 2023 17:55:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 24 Feb 2023 17:55:08 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Feb 2023 17:55:06 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a25df9e-b496-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677279307; x= 1677365707; bh=r6mRCtJbpT5pH/gblfSbXLBdrg/beZ0d2UEnWnlbKoM=; b=n b3qvZpEAGDh313g5eN4kb52xk0TUbDKJS7/DFp3sf3/f/P5g0FC/BE/p+ap4HXGQ ste3+rh7ux4RXNNlSO/WA18bvJpe9yZANft74zlQ9rswHGH1Y7osMJ0OGIn1F+4i SsUZSEDZejdAmEUFCGVRCOplGQnVQaBsix8JHJJvhy/MF+8eHPTPxSivBLRTI12X FYai4EvhShR6ck17VIulSbQStoRMjfOrnpxrCEUR/5cmp5B5LtQuXQa1TOuuSWS/ CQ5ujN6Z1FPIf0KM0iWRreB9cv4WNhWrds1hnV3xP9dIrdT9YQB4+XdIHIvwfVuw wMoAMAuuuaIo2f/Pc0v3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677279307; x=1677365707; bh=r6mRCtJbpT5pH/gblfSbXLBdrg/b eZ0d2UEnWnlbKoM=; b=iAceGtl9sMXi2gYyRduMD6uEKPwktBBffr7dRrqFa3/I Oot1eFer9CJ6aX09MYs2Z+chAPz5BUe3phlUA9k9hD8lbDW2o+WTdltKaZ6bi+Fc 2j9nKG82Q8QuZCyurzgnTvw+smdjOTOyWlOYP/qEKQhyNLySLsEFeXzFB0/xiKZx 4LIsmJYGk/p2+artgCWSOiENlZBy/VLw1NTEtJoWvSRgzvXGB82c/pVF6o+P3fII v7tD87qvJx2UksQARulVPNr8fIVyVYeUlrlwsHIt3mwBr9g1nVChcGre41QTqsWX YA+3q8rHKV4XVB5DEq+MwqimNpjTucH0Rps4ZdVzcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepveffgeduudffveeiteegvdefuedt ledugefgjeehudehueeiuedtfeevkeeuhfeknecuffhomhgrihhnpeiilhhisgdrnhgvth enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeguvghm ihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 24 Feb 2023 17:55:01 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// Message-ID: References: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> <8c4aa332-07ee-e91a-50f1-ced9e36db2a1@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oGO/5wPBSPi5N4Jr" Content-Disposition: inline In-Reply-To: <8c4aa332-07ee-e91a-50f1-ced9e36db2a1@suse.com> --oGO/5wPBSPi5N4Jr Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 24 Feb 2023 17:55:01 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote: > On 19.02.2023 03:46, Demi Marie Obenour wrote: > > --- a/stubdom/configure > > +++ b/stubdom/configure > > @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > ZLIB_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - ZLIB_URL=3D"http://www.zlib.net" > > + ZLIB_URL=3D"https://www.zlib.net" > > fi >=20 > In v3 you said that this URL can't be used anymore for the version we're > trying to fetch (which I can confirm). Leaving aside the question of why > stubdom was never updated in that regard, what use is it to update URL > (without even mentioning the aspect in the description) in such a case? > (I haven't gone through any of the other URLs again, so there may well > be more similar cases.) Main advantage is that it will fail securely rather than downloading whatever random code an MITM attacker put in there. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --oGO/5wPBSPi5N4Jr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmP5QEkACgkQsoi1X/+c IsGqbBAAq32mtEi4QdTDBCgsz//16HrrG3NsPsHCsxfQkMHdFcGHzWRH1upZr3Ik RiAUgKAFQ7G94BuzLGxUre8wiQAwh3rgen8AM+/6xl9Oa86zXuDj1afLb+waLGMh JT6RgCprF6ez4xeBnP5dQU+rVUDv/+MG5v1djZctn5rplWEhMZ0Bb8ON8XqYluen XGqamyum4ya1wjwxATCD3OQlScl42sMGoatIQLXRCydFtSPwVpjihvtggqFm9GW6 bzDpnUhHVc8bImLavpCGb1etTZt04mmUSyOjXeht0XSTFuPhx3vjWj4nxksCw/PL YVUj3HUg11XH97U7gSFHTwtwhLczDSDWqPl/4fCiE4VB5lJP2jzGH4WiwoHPcMtY 1Memjv7dX85zFSS9EkB0OfKXE5tNm3P5/8I8V5t8Fw1lc28Ik4BPge4SFbykMR+s NVSw2esdxNOMeYZWfR9Z25hOKjE59Q/feffbDzmo9QSHRMkheAehakPhnC3wUasa 2B6YMjUHyVQMSqdJ4lT3K8jAbWUqYdahC0g8KcdtK/cTwW/YQpsl3wdB2e0FCGlL zb8bRPnZMPYHDs9P4gsG5cobfnyKWA1zbMbsZt6SjfV3J019sAiZtIhIrOT94F1H KpSzMNhThu3DTGk9IpDR497qJHGT6/cMxB3vx8WsqRCAAzC+bFs= =2DgU -----END PGP SIGNATURE----- --oGO/5wPBSPi5N4Jr-- From xen-devel-bounces@lists.xenproject.org Fri Feb 24 23:03:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 23:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501616.773449 (Exim 4.92) (envelope-from ) id 1pVh5u-0004R8-HP; Fri, 24 Feb 2023 23:03:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501616.773449; Fri, 24 Feb 2023 23:03:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVh5u-0004R1-EJ; Fri, 24 Feb 2023 23:03:14 +0000 Received: by outflank-mailman (input) for mailman id 501616; Fri, 24 Feb 2023 23:03:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVh5s-0004Qo-9K; Fri, 24 Feb 2023 23:03:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVh5s-0004SA-7T; Fri, 24 Feb 2023 23:03:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVh5r-0002Gj-RF; Fri, 24 Feb 2023 23:03:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVh5r-0003w1-Qn; Fri, 24 Feb 2023 23:03:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d2xRcga2iINC8iXlphnFvwjcrx2iOlTWyRWWAQEVgL4=; b=XF305qrBW2xKx7CAiFzh7oHzXa dOSQSifLpfCrVRZW/32/kBRH89qdjNUxyedAuAdkRYKGPa5wAsgSfo9Q1xG9Omr3cW1zm43dP7klh hLw1awhl3eemnMYFXVZkLXUJ5xtPfjhzThku+Tan4ZhOzGt+wInVEhjsBZ/vnbsT52k0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178391: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=608f85a1818697156b72ace4913a17c8178a0ef5 X-Osstest-Versions-That: xen=7b66792ea7f77fb9e587e1e9c530a7c869eecba1 From: osstest service owner Date: Fri, 24 Feb 2023 23:03:11 +0000 flight 178391 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178391/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 608f85a1818697156b72ace4913a17c8178a0ef5 baseline version: xen 7b66792ea7f77fb9e587e1e9c530a7c869eecba1 Last test of basis 178376 2023-02-24 18:03:34 Z 0 days Testing same since 178391 2023-02-24 21:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 7b66792ea7..608f85a181 608f85a1818697156b72ace4913a17c8178a0ef5 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Feb 24 23:39:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 24 Feb 2023 23:39:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501626.773460 (Exim 4.92) (envelope-from ) id 1pVhf7-0001Fu-DY; Fri, 24 Feb 2023 23:39:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501626.773460; Fri, 24 Feb 2023 23:39:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVhf7-0001Fn-9e; Fri, 24 Feb 2023 23:39:37 +0000 Received: by outflank-mailman (input) for mailman id 501626; Fri, 24 Feb 2023 23:39:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVhf6-0001Fh-Lt for xen-devel@lists.xenproject.org; Fri, 24 Feb 2023 23:39:36 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7dd50d2a-b49c-11ed-a82a-c9ca1d2f71af; Sat, 25 Feb 2023 00:39:34 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id ck15so3850933edb.0 for ; Fri, 24 Feb 2023 15:39:33 -0800 (PST) Received: from [192.168.1.93] (adsl-185.109.242.225.tellas.gr. [109.242.225.185]) by smtp.gmail.com with ESMTPSA id p22-20020a1709061b5600b008cca31606a8sm137145ejg.51.2023.02.24.15.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 15:39:32 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dd50d2a-b49c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B68Sep32+JKax6LMqOVftT1OIdWZERFDZhh8bffld0o=; b=GOXf6X05etoByxIIU9IgJwUYRWF4VJgPYFsRb/sRffY29QCTVJGIwI6mVCbyBUIw2h dqhQHRElUyqKbQ+JJGPWudp4L3nfyAwdGPNrwmcmqWgYXOiAyoL/ZC4SZ62Fba+IdKoo 6Ah3i9En0yAjf4BAIPzPDUu65tSaZyoqwXdtrh9Kxh6ylHQ5sEUdlX+KDG7H87nPj0PT WR1bi6JBNJw2VeoB/6J7waalfO1QTsi2wJwU1uoHosdJ8+41rP1NzWTBz6YKYIHSyrh/ N5CnzOu12jDv0DadRSB7VYx+M3CJAsCW1y4P7YNSZw7oQC9wBlXQ1CtzmBrXacD6MC3u XeXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B68Sep32+JKax6LMqOVftT1OIdWZERFDZhh8bffld0o=; b=WitEHQNCk3QWRpAZlnAW7bB4hHt2H93DG+/mIELWgb5k/lbHV5sRpB1+AGtQYgPoQt jUmYZ7yAhiqueqQc3X1n8BlIVHGqtcGwLFSUyq5BPPvI9XB3TQy3caw9RxBaKvFHSL3Q tuyzr5QXIgbUY6lfvvyHPZbCkYU97LaNbqWkF45EEMte/pSemFo2nH3ExujETaSWxsZK WLxE/89nJHMu7+0eYVfrUW8FlMqN58iAWcw1P04w7A2noOBAmhUPkj7BEZ3o95pRbS9t sUhMw5++0mda0xa2kD9PSW9I48Jz6q1NGcVYx4Yp4JcNkqpvE9/iJg4+0tBS9u+yi9WM /K6w== X-Gm-Message-State: AO0yUKWTR1l1pOwcZT/H8SRh8v21dj9SlU4A2jtV83EsQ5NwbthMJpLl zn6zPAsSYipCcsGv6ZvYriw= X-Google-Smtp-Source: AK7set/JTCHOeX9QHcXqLwpEIukOtycUMO3fXCpccaOuRG4dL8YP7Yw9yAG7uuD36hINJOPHWk6q4g== X-Received: by 2002:a17:906:c312:b0:88a:7037:855e with SMTP id s18-20020a170906c31200b0088a7037855emr26353966ejz.9.1677281973209; Fri, 24 Feb 2023 15:39:33 -0800 (PST) Message-ID: Date: Sat, 25 Feb 2023 01:39:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> From: Xenia Ragiadakou In-Reply-To: <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/24/23 23:33, Andrew Cooper wrote: > On 24/02/2023 8:08 pm, Xenia Ragiadakou wrote: >> >> On 2/24/23 21:29, Andrew Cooper wrote: >>> On 24/02/2023 6:49 pm, Xenia Ragiadakou wrote: >>>> There are more detailed per-patch changesets. >>>> >>>> Xenia Ragiadakou (14): >>>>    x86/svm: move declarations used only by svm code from svm.h to >>>> private >>>>      header >>>>    x86/svm: make asid.h private >>>>    x86/svm: delete header asm/hvm/svm/intr.h >>> >>> Thankyou for this work.  I've acked and committed patches 1 and 3. >>> >>> Note that you had one hunk in patch 5 (whitespace correction in >>> svm_invlpga) that obviously should have been in patch 1, so I've >>> moved it. >> >> Thanks, I missed that  ... >> >>> >>> Looking at asid.h, I still can't bare to keep it even in that state, so >>> I've constructed an alternative which I'll email out in a moment. >> >> I 'm also in favor of less headers. > > I've committed as far as the nestedhvm move.  At that point, I've sent > out a small patch to try and help decouple later changes. > > But I think we want to change tact slightly at this point, so I'm not > going to do any further tweaking on commit. > > Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, > updating the non-SVM include paths as we go.  Probably best to > chain-include the other svm/hvm/svm/*.h headers temporarily, so we've > only got one tree-wide cleanup of the external include paths. > > Quick tangent - I will be making all of that cpu_has_svm_* > infrastructure disappear by moving it into the normal CPUID handling, > but I've not had sufficient time to finish that yet. > > Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and > disappear (after my decoupling patch has gone in). > > After that, hvm/svm/vmcb.h can be cleanly split in half.  struct > svm_{domain,vcpu} can move sideways into hvm/svm.h (with a forward > declaration of vmcb_struct), as can the svm msr intercept declarations. > Everything else can move to being a private vmcb.h > > Finally your svmdebug.h can come at the end, pretty much in the same > shape it is now.  One thing to say is that right now, you've left enum > vmcb_sync_state public, but it's type is already decoupled by virtue of > struct svm_vcpu having a uint8_t field rather than an enum field. > > And I think that cleanly gets rid of the entire asm/hvm/svm/* dir, which > is a great position to get to. > > > Beyond that, you will want to clean up the hvm msr intercept handling as > hvm_funcs, which I think will decouple the vpmu files from svm/vmx > specifically, but that will want to be a separate series. > > How does this sound? Thanks for the review. I think it sounds good. The last part i.e the hvm msr intercept handling as hvm_funcs, I have it already I just didn't have the chance to send it yet (because the changes affect {svm,vmx}.h). I will rebase and send it on Monday for review to verify that we are on the same page. > > Thanks, > > ~Andrew -- Xenia From xen-devel-bounces@lists.xenproject.org Sat Feb 25 03:05:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 03:05:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501633.773470 (Exim 4.92) (envelope-from ) id 1pVksV-0004g9-GW; Sat, 25 Feb 2023 03:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501633.773470; Sat, 25 Feb 2023 03:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVksV-0004g1-CA; Sat, 25 Feb 2023 03:05:39 +0000 Received: by outflank-mailman (input) for mailman id 501633; Sat, 25 Feb 2023 03:05:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVksU-0004fr-3o; Sat, 25 Feb 2023 03:05:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVksU-0000gY-0j; Sat, 25 Feb 2023 03:05:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVksT-0007nY-Je; Sat, 25 Feb 2023 03:05:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVksT-00066M-JC; Sat, 25 Feb 2023 03:05:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BDT+vTWf2FZ+e8uUiFeUkTzr+WmqzM6gN7pik383c44=; b=cCcn43zXYPxhR9seH+2yHwfqb2 NQ7Xi/gVOsjRkOWtHzaCG+Uv503W7OgDWporCAj01cHpmGrkuCZMet/gBfkpYXIoHVzdTSQ0yapZE gasI04ZeXliv16fgLgHDBG8QUgUMkHoIGJMhOhSHfGedxDJ05+aPBNU/IVID3hymKIIc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178320: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=d2980d8d826554fa6981d621e569a453787472f8 X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Sat, 25 Feb 2023 03:05:37 +0000 flight 178320 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178320/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux d2980d8d826554fa6981d621e569a453787472f8 baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 3 days Failing since 178093 2023-02-22 05:02:47 Z 2 days 5 attempts Testing same since 178320 2023-02-24 05:28:00 Z 0 days 1 attempts ------------------------------------------------------------ 1426 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 150477 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 25 06:25:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 06:25:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501648.773480 (Exim 4.92) (envelope-from ) id 1pVnzZ-00006u-Ao; Sat, 25 Feb 2023 06:25:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501648.773480; Sat, 25 Feb 2023 06:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVnzZ-00006j-7N; Sat, 25 Feb 2023 06:25:09 +0000 Received: by outflank-mailman (input) for mailman id 501648; Sat, 25 Feb 2023 06:25:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVnzY-00006Y-5F; Sat, 25 Feb 2023 06:25:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVnzY-0005vG-1s; Sat, 25 Feb 2023 06:25:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVnzX-0004OI-NT; Sat, 25 Feb 2023 06:25:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVnzX-0004CG-Mv; Sat, 25 Feb 2023 06:25:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TLXe9FkMKC0BZdGXs7h5PCCk5JtebmNHtteUAUh54NM=; b=FylxKO2vbmZvBGMT40K0CsO/YX xvfyQp58GMTaM6mkjDRJ5mgXD6368L6GkzL9BAL9eDjxBdmel1PzLeDT1jaZP/kx2JJ0PmAplXOd4 pVDCtIk7iLa9AaXjNAtlEwUolXUsgaSANo7VIQ+bFXOlhnQE7xv/Sirs9Dpf384ffG4U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178355: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=91d4d9506a4e8906253d1280bd5a1f39668fad64 X-Osstest-Versions-That: xen=91d4d9506a4e8906253d1280bd5a1f39668fad64 From: osstest service owner Date: Sat, 25 Feb 2023 06:25:07 +0000 flight 178355 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178355/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-shadow 7 xen-install fail in 178260 pass in 178355 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 178260 pass in 178355 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 178260 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178260 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178260 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178260 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178260 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178260 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178260 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 178260 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178260 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178260 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178260 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 91d4d9506a4e8906253d1280bd5a1f39668fad64 baseline version: xen 91d4d9506a4e8906253d1280bd5a1f39668fad64 Last test of basis 178355 2023-02-24 13:12:55 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Feb 25 10:07:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 10:07:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501689.773490 (Exim 4.92) (envelope-from ) id 1pVrSo-0006hs-AY; Sat, 25 Feb 2023 10:07:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501689.773490; Sat, 25 Feb 2023 10:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVrSo-0006hl-5P; Sat, 25 Feb 2023 10:07:34 +0000 Received: by outflank-mailman (input) for mailman id 501689; Sat, 25 Feb 2023 10:07:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVrSn-0006hb-Ez; Sat, 25 Feb 2023 10:07:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVrSn-00032Y-B5; Sat, 25 Feb 2023 10:07:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVrSm-0000IL-SE; Sat, 25 Feb 2023 10:07:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVrSm-0007GT-Rg; Sat, 25 Feb 2023 10:07:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I+dMVTgtl0T2Iivh7sA+MBUcMO3UXLWk8D8hhhnjTHk=; b=DlHLXbkg7CX0Mr4v4P85qvYI4l RT0xoOwmIbZ5BpjnLHzAaYLcxkVm5f+roJLNBxR00mrDbT0xXIJtGZbIVTnZwg4gRyoG7WUP/MPmR qt/kZpsSIteBaSSiYsBAZGNmeoLwnWQqLKyPpPzv1dfXFxwVRLjzXQU5gBkx6+NxcpqE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 178378: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm::broken:regression xen-4.16-testing:build-arm64:xen-build:fail:regression xen-4.16-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:host-install(5):broken:heisenbug xen-4.16-testing:test-amd64-amd64-libvirt-vhd:leak-check/check:fail:heisenbug xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-4.16-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=0802504627453a54b1ab408b6e9dc8b5c561172d X-Osstest-Versions-That: xen=d4e286db89d80c862b4a24bf971dd71008c8b53e From: osstest service owner Date: Sat, 25 Feb 2023 10:07:32 +0000 flight 178378 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178378/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken in 178275 build-arm64 6 xen-build fail in 178275 REGR. vs. 177405 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 5 host-install(5) broken in 178275 pass in 178378 test-amd64-amd64-libvirt-vhd 22 leak-check/check fail pass in 178275 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 178275 n/a build-arm64-libvirt 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 178275 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 178275 n/a test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 177405 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177405 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177405 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 0802504627453a54b1ab408b6e9dc8b5c561172d baseline version: xen d4e286db89d80c862b4a24bf971dd71008c8b53e Last test of basis 177405 2023-02-15 16:37:16 Z 9 days Testing same since 178138 2023-02-22 14:37:31 Z 2 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm broken Not pushing. ------------------------------------------------------------ commit 0802504627453a54b1ab408b6e9dc8b5c561172d Author: Anthony PERARD Date: Tue Feb 21 16:55:38 2023 +0000 automation: Remove clang-8 from Debian unstable container First, apt complain that it isn't the right way to add keys anymore, but hopefully that's just a warning. Second, we can't install clang-8: The following packages have unmet dependencies: clang-8 : Depends: libstdc++-8-dev but it is not installable Depends: libgcc-8-dev but it is not installable Depends: libobjc-8-dev but it is not installable Recommends: llvm-8-dev but it is not going to be installed Recommends: libomp-8-dev but it is not going to be installed libllvm8 : Depends: libffi7 (>= 3.3~20180313) but it is not installable E: Unable to correct problems, you have held broken packages. clang on Debian unstable is now version 14.0.6. Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper (cherry picked from commit a6b1e2b80fe2053b1c9c9843fb086a668513ea36) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Feb 25 11:33:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 11:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501716.773499 (Exim 4.92) (envelope-from ) id 1pVsnp-00030r-Ly; Sat, 25 Feb 2023 11:33:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501716.773499; Sat, 25 Feb 2023 11:33:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVsnp-00030k-JI; Sat, 25 Feb 2023 11:33:21 +0000 Received: by outflank-mailman (input) for mailman id 501716; Sat, 25 Feb 2023 11:33:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVsno-00030a-Cl; Sat, 25 Feb 2023 11:33:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVsno-0004wK-9N; Sat, 25 Feb 2023 11:33:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVsnn-00033G-Nw; Sat, 25 Feb 2023 11:33:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVsnn-0007Aj-NW; Sat, 25 Feb 2023 11:33:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KxXCRMJHa61WW1fvbQE3Tq0ap29xeWPh5IBGyLQ+LVw=; b=tBTWQSdWY1PQmGAvrf2U2Bagkx g1FH4TkDpUYeaFED4z1rzt/QUmfr0SzeVuOcyNZYyxAB5eyqYaAlGfTRibuaDfzcxZPolSGKqQ0N8 7rvDa+PB6S369Af5TonBRm/rm5PaaJh5KdyRj3/aHI2Ivkrx0AG7e55M1xyvoDr3iwWE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 178422: regressions - trouble: blocked/fail/pass/starved X-Osstest-Failures: libvirt:build-arm64-pvops:kernel-build:fail:regression libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=e66469095d4a6dafc7e482894321e1e10c734e54 X-Osstest-Versions-That: libvirt=6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 From: osstest service owner Date: Sat, 25 Feb 2023 11:33:19 +0000 flight 178422 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/178422/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 178315 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 178315 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt e66469095d4a6dafc7e482894321e1e10c734e54 baseline version: libvirt 6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 Last test of basis 178315 2023-02-24 04:20:20 Z 1 days Testing same since 178422 2023-02-25 04:20:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Yuri Chornoivan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e66469095d4a6dafc7e482894321e1e10c734e54 Author: Yuri Chornoivan Date: Thu Feb 23 18:20:29 2023 +0100 Translated using Weblate (Ukrainian) Currently translated at 100.0% (10416 of 10416 strings) Translation: libvirt/libvirt Translate-URL: https://translate.fedoraproject.org/projects/libvirt/libvirt/uk/ Co-authored-by: Yuri Chornoivan Signed-off-by: Yuri Chornoivan From xen-devel-bounces@lists.xenproject.org Sat Feb 25 14:55:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 14:55:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501768.773513 (Exim 4.92) (envelope-from ) id 1pVvxP-0005zL-3e; Sat, 25 Feb 2023 14:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501768.773513; Sat, 25 Feb 2023 14:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVvxP-0005zE-0T; Sat, 25 Feb 2023 14:55:27 +0000 Received: by outflank-mailman (input) for mailman id 501768; Sat, 25 Feb 2023 14:55:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVvxM-0005z5-Mt for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 14:55:25 +0000 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d3dbf59-b51c-11ed-88bb-e56d68cac8db; Sat, 25 Feb 2023 15:55:21 +0100 (CET) Received: from [192.168.2.94] (unknown [109.252.117.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 417C96602FB5; Sat, 25 Feb 2023 14:55:20 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d3dbf59-b51c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677336921; bh=GPaYuR5Gy6chLlPOIU2JZ+7K9lpjG/p10DVFCLmE4vI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MU5VbcbfC0QusKjWBXD79gAq7WtPDI4jCbUCX37OTtNCxYhAzQRsMdIYvIcZQnliX kIXwP//+YsQHnEJ/oLmaSftzRZ5vlhn0Sl6QZGQnajq7AWz9XL5xsNgzfzNW9E9hEc jHjE6VR8vCGBK70YCdNZB05GYvJhsWDy5DEoqGR+AfJnYZbfnw7Uo//Y2gbPd4Ty4+ r9RcLrILyKrWv0bNT/hMD3YY3ggV6IoYPPEULvRmjAqyhO/vuV3x36tTCTapKf+zuS sEc4uW51ZoPz/NIiC8l7jCYmwaAKotiLFVU+N8roRIoJIfYJ0kIQBG39ssTUoizeoK rzYbb8McmO57g== Message-ID: <4cb50dcb-b877-9602-3802-d651eea57b89@collabora.com> Date: Sat, 25 Feb 2023 17:55:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] drm/virtio: Pass correct device to dma_sync_sgtable_for_device() Content-Language: en-US To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Juergen Gross , Stefano Stabellini References: <20230224153450.526222-1-olekstysh@gmail.com> From: Dmitry Osipenko In-Reply-To: <20230224153450.526222-1-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/24/23 18:34, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > The "vdev->dev.parent" should be used instead of "vdev->dev" as a device > for which to perform the DMA operation in both > virtio_gpu_cmd_transfer_to_host_2d(3d). > > Because the virtio-gpu device "vdev->dev" doesn't really have DMA OPS > assigned to it, but parent (virtio-pci or virtio-mmio) device > "vdev->dev.parent" has. The more, the sgtable in question the code is > trying to sync here was mapped for the parent device (by using its DMA OPS) > previously at: > virtio_gpu_object_shmem_init()->drm_gem_shmem_get_pages_sgt()-> > dma_map_sgtable(), so should be synced here for the same parent device. > > Fixes: b5c9ed70d1a9 ("drm/virtio: Improve DMA API usage for shmem BOs") > Signed-off-by: Oleksandr Tyshchenko > --- > This patch fixes the following issue when running on top of Xen with > CONFIG_XEN_VIRTIO=y (patch was only tested in Xen environment (ARM64 guest) > w/ and w/o using Xen grants for virtio): > > [ 0.830235] [drm] pci: virtio-gpu-pci detected at 0000:00:03.0 > [ 0.832078] [drm] features: +virgl +edid -resource_blob -host_visible > [ 0.832084] [drm] features: -context_init > [ 0.837320] [drm] number of scanouts: 1 > [ 0.837460] [drm] number of cap sets: 2 > [ 0.904372] [drm] cap set 0: id 1, max-version 1, max-size 308 > [ 0.905399] [drm] cap set 1: id 2, max-version 2, max-size 696 > [ 0.907202] [drm] Initialized virtio_gpu 0.1.0 0 for 0000:00:03.0 on minor 0 > [ 0.927241] virtio-pci 0000:00:03.0: [drm] drm_plane_enable_fb_damage_clips() not called > [ 0.927279] Unable to handle kernel paging request at virtual address ffffffffc0053000 > [ 0.927284] Mem abort info: > [ 0.927286] ESR = 0x0000000096000144 > [ 0.927289] EC = 0x25: DABT (current EL), IL = 32 bits > [ 0.927293] SET = 0, FnV = 0 > [ 0.927295] EA = 0, S1PTW = 0 > [ 0.927298] FSC = 0x04: level 0 translation fault > [ 0.927301] Data abort info: > [ 0.927303] ISV = 0, ISS = 0x00000144 > [ 0.927305] CM = 1, WnR = 1 > [ 0.927308] swapper pgtable: 4k pages, 48-bit VAs, pgdp=000000004127f000 > [ 0.927312] [ffffffffc0053000] pgd=0000000000000000, p4d=0000000000000000 > [ 0.927323] Internal error: Oops: 0000000096000144 [#1] PREEMPT SMP > [ 0.927329] Modules linked in: > [ 0.927336] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 6.2.0-rc4-yocto-standard #1 > [ 0.927343] Hardware name: XENVM-4.18 (DT) > [ 0.927346] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 0.927352] pc : dcache_clean_poc+0x20/0x38 > [ 0.927370] lr : arch_sync_dma_for_device+0x24/0x30 > [ 0.927379] sp : ffff80000972b3e0 > [ 0.927381] x29: ffff80000972b3e0 x28: ffff000001aa8a00 x27: 0000000000000000 > [ 0.927389] x26: 0000000000000000 x25: ffff000002815010 x24: 0000000000000000 > [ 0.927396] x23: ffff8000090f9078 x22: 0000000000000001 x21: 0000000000000002 > [ 0.927403] x20: ffff000002b6b580 x19: 8000000000053000 x18: ffffffffffffffff > [ 0.927410] x17: 0000000000000000 x16: 0000000000000000 x15: ffff80000963b94e > [ 0.927416] x14: 0000000000000001 x13: ffff80000963b93b x12: 64615f616d645f67 > [ 0.927423] x11: ffff800009513110 x10: 000000000000000a x9 : ffff80000972b360 > [ 0.927430] x8 : ffff8000095130c8 x7 : ffff80000972b150 x6 : 000000000000000c > [ 0.927436] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 000000000000003f > [ 0.927443] x2 : 0000000000000040 x1 : ffffffffc0067000 x0 : ffffffffc0053000 > [ 0.927450] Call trace: > [ 0.927452] dcache_clean_poc+0x20/0x38 > [ 0.927459] dma_direct_sync_sg_for_device+0x124/0x130 > [ 0.927466] dma_sync_sg_for_device+0x64/0xd0 > [ 0.927475] virtio_gpu_cmd_transfer_to_host_2d+0x10c/0x110 > [ 0.927483] virtio_gpu_primary_plane_update+0x340/0x3d0 > [ 0.927490] drm_atomic_helper_commit_planes+0xe8/0x20c > [ 0.927497] drm_atomic_helper_commit_tail+0x54/0xa0 > [ 0.927503] commit_tail+0x160/0x190 > [ 0.927507] drm_atomic_helper_commit+0x16c/0x180 > [ 0.927513] drm_atomic_commit+0xa8/0xe0 > [ 0.927521] drm_client_modeset_commit_atomic+0x200/0x260 > [ 0.927529] drm_client_modeset_commit_locked+0x5c/0x1a0 > [ 0.927536] drm_client_modeset_commit+0x30/0x60 > [ 0.927540] drm_fb_helper_set_par+0xc8/0x120 > [ 0.927548] fbcon_init+0x3b8/0x510 > [ 0.927557] visual_init+0xb4/0x104 > [ 0.927565] do_bind_con_driver.isra.0+0x1c4/0x394 > [ 0.927572] do_take_over_console+0x144/0x1fc > [ 0.927577] do_fbcon_takeover+0x6c/0xe4 > [ 0.927583] fbcon_fb_registered+0x1e4/0x1f0 > [ 0.927588] register_framebuffer+0x214/0x310 > [ 0.927592] __drm_fb_helper_initial_config_and_unlock+0x33c/0x540 > [ 0.927599] drm_fb_helper_initial_config+0x4c/0x60 > [ 0.927604] drm_fbdev_client_hotplug+0xc4/0x150 > [ 0.927609] drm_fbdev_generic_setup+0x90/0x154 > [ 0.927614] virtio_gpu_probe+0xc8/0x16c > [ 0.927621] virtio_dev_probe+0x19c/0x240 > [ 0.927629] really_probe+0xbc/0x2dc > [ 0.927637] __driver_probe_device+0x78/0xe0 > [ 0.927641] driver_probe_device+0xd8/0x160 > [ 0.927645] __driver_attach+0x94/0x19c > [ 0.927649] bus_for_each_dev+0x70/0xd0 > [ 0.927656] driver_attach+0x24/0x30 > [ 0.927660] bus_add_driver+0x154/0x20c > [ 0.927664] driver_register+0x78/0x130 > [ 0.927670] register_virtio_driver+0x24/0x3c > [ 0.927675] virtio_gpu_driver_init+0x18/0x24 > [ 0.927684] do_one_initcall+0x50/0x1d0 > [ 0.927691] kernel_init_freeable+0x210/0x27c > [ 0.927699] kernel_init+0x24/0x12c > [ 0.927707] ret_from_fork+0x10/0x20 > [ 0.927716] Code: d2800082 9ac32042 d1000443 8a230000 (d50b7a20) > [ 0.927721] ---[ end trace 0000000000000000 ]--- > [ 0.927728] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b > [ 0.927732] SMP: stopping secondary CPUs > [ 0.927791] Kernel Offset: disabled > [ 0.927794] CPU features: 0x80000,41058100,0000421b > [ 0.927799] Memory Limit: none > [ 1.015063] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- > --- > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index a04a9b20896d..1778a2081fd6 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -604,7 +604,7 @@ void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev, > bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev); > > if (virtio_gpu_is_shmem(bo) && use_dma_api) > - dma_sync_sgtable_for_device(&vgdev->vdev->dev, > + dma_sync_sgtable_for_device(vgdev->vdev->dev.parent, > bo->base.sgt, DMA_TO_DEVICE); > > cmd_p = virtio_gpu_alloc_cmd(vgdev, &vbuf, sizeof(*cmd_p)); > @@ -1026,7 +1026,7 @@ void virtio_gpu_cmd_transfer_to_host_3d(struct virtio_gpu_device *vgdev, > bool use_dma_api = !virtio_has_dma_quirk(vgdev->vdev); > > if (virtio_gpu_is_shmem(bo) && use_dma_api) > - dma_sync_sgtable_for_device(&vgdev->vdev->dev, > + dma_sync_sgtable_for_device(vgdev->vdev->dev.parent, > bo->base.sgt, DMA_TO_DEVICE); > > cmd_p = virtio_gpu_alloc_cmd(vgdev, &vbuf, sizeof(*cmd_p)); Indeed, it's only the vgpu drm device that was moved to use the pci parent device. On x86 the vdev always has dma-ops, also virtio_has_dma_quirk=true for modern Qemu. So I didn't test this code path and apparently it's only testable on Xen, which is good to know. Reviewed-by: Dmitry Osipenko -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Sat Feb 25 16:41:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 16:41:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501777.773523 (Exim 4.92) (envelope-from ) id 1pVxbo-0004tC-Kg; Sat, 25 Feb 2023 16:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501777.773523; Sat, 25 Feb 2023 16:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxbo-0004t5-Gq; Sat, 25 Feb 2023 16:41:16 +0000 Received: by outflank-mailman (input) for mailman id 501777; Sat, 25 Feb 2023 16:41:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxbm-0004sv-Lk; Sat, 25 Feb 2023 16:41:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxbm-00048Q-Il; Sat, 25 Feb 2023 16:41:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxbm-0004dy-6o; Sat, 25 Feb 2023 16:41:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pVxbm-00079J-6S; Sat, 25 Feb 2023 16:41:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=47F3Qn7OJvW/NsTIxXh5N7CmER642gMz/VS7Fpg2JxM=; b=0wDpkwRtiH3XNzcjFijP5kZEnR 7ci2F2AH7jJUbkQ9Jf6hkZ5iJmRt/nx6s66pPI+oCEnQcwWA/CnvN0izAJbd/JUfj5bsSOJLGLC1c fQck2cwkcZZ2McBPvJdjRqcjUWMoA8xkSU/NlyroFQMNr+XgyAU++mE15nb1x0cwmbwU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178416: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-coresched-amd64-xl::broken:regression linux-linus:test-amd64-coresched-amd64-xl:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-stop:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=595fa4e313fee3c0b69c10bbed6fffb803237306 X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Sat, 25 Feb 2023 16:41:14 +0000 flight 178416 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-coresched-amd64-xl 5 host-install(5) broken REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 17 guest-stop fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 595fa4e313fee3c0b69c10bbed6fffb803237306 baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 3 days Failing since 178093 2023-02-22 05:02:47 Z 3 days 6 attempts Testing same since 178416 2023-02-25 03:11:02 Z 0 days 1 attempts ------------------------------------------------------------ 1654 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl broken test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-coresched-amd64-xl broken broken-step test-amd64-coresched-amd64-xl host-install(5) Not pushing. (No revision log; it would be 179904 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Feb 25 16:42:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 16:42:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501785.773532 (Exim 4.92) (envelope-from ) id 1pVxd3-0005Tu-2Q; Sat, 25 Feb 2023 16:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501785.773532; Sat, 25 Feb 2023 16:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxd2-0005Tn-W6; Sat, 25 Feb 2023 16:42:32 +0000 Received: by outflank-mailman (input) for mailman id 501785; Sat, 25 Feb 2023 16:42:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxd1-0005Tf-Vm for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 16:42:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxd0-00049j-Tq; Sat, 25 Feb 2023 16:42:30 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVxd0-0002gT-OD; Sat, 25 Feb 2023 16:42:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=zBYlJBA1NLaIn0qaYHm2AZKC1IEtjOOvmQucoWd7Kc8=; b=rg7oF/KkUt9fUuYmqZGC1+05KO 61uA7WUqxVq4tKfPoD5lG2uDRZ4SJ+FxBTDkePL/2WKNUOMj+W5MgyAtdrqcibAzgFFVhjf9xt+LB 6802QHtqDYUosUUUD4c1u0IWG0O8SiHqqxnF3JoY87MTX5lKmGG30YveW6P8jmiWio9A=; Message-ID: <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> Date: Sat, 25 Feb 2023 16:42:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Wei Liu References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> From: Julien Grall Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME In-Reply-To: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: > A large part of the content of the bug.h is repeated among all > architectures, so it was decided to create a new config > CONFIG_GENERIC_BUG_FRAME. > > The version of from x86 was taken as the base version. > > The patch introduces the following stuff: > * common bug.h header > * generic implementation of do_bug_frame > * new config CONFIG_GENERIC_BUG_FRAME > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > * Add debugger_trap_fatal() to do_bug_frame(). It simplifies usage of > do_bug_frame() for x86 so making handle_bug_frame() and find_bug_frame() > not needed anymore. > * Update do_bug_frame() to return -EINVAL if something goes wrong; otherwise > id of bug_frame > * Update _ASM_BUGFRAME_TEXT to make it more portable. > * Drop unnecessary comments. > * define stub value for TRAP_invalid_op in case if wasn't defined in > arch-specific folders. > --- > Changes in V2: > - Switch to x86 implementation as generic as it is more compact > ( at least from the point of view of bug frame structure ). > - Rename CONFIG_GENERIC_DO_BUG_FRAME to CONFIG_GENERIC_BUG_FRAME. > - Change the macro bug_loc(b) to avoid the need for a cast: > #define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > - Rename BUG_FRAME_STUFF to BUG_FRAME_STRUCT > - Make macros related to bug frame structure more generic. > - Introduce BUG_INSTR and MODIFIER to make _ASM_BUGFRAME_TEXT reusable > between x86 and RISC-V. > - Rework do_bug_frame() and introduce find_bug_frame() and handle_bug_frame() > functions to make it reusable by x86. > - code style fixes > --- > xen/common/Kconfig | 3 + > xen/common/Makefile | 1 + > xen/common/bug.c | 109 ++++++++++++++++++++++++++++++ > xen/include/xen/bug.h | 150 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 263 insertions(+) > create mode 100644 xen/common/bug.c > create mode 100644 xen/include/xen/bug.h > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index f1ea3199c8..b226323537 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -28,6 +28,9 @@ config ALTERNATIVE_CALL > config ARCH_MAP_DOMAIN_PAGE > bool > > +config GENERIC_BUG_FRAME > + bool > + > config HAS_ALTERNATIVE > bool > > diff --git a/xen/common/Makefile b/xen/common/Makefile > index bbd75b4be6..46049eac35 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_ARGO) += argo.o > obj-y += bitmap.o > +obj-$(CONFIG_GENERIC_BUG_FRAME) += bug.o > obj-$(CONFIG_HYPFS_CONFIG) += config_data.o > obj-$(CONFIG_CORE_PARKING) += core_parking.o > obj-y += cpu.o > diff --git a/xen/common/bug.c b/xen/common/bug.c > new file mode 100644 > index 0000000000..f81724fc9b > --- /dev/null > +++ b/xen/common/bug.c > @@ -0,0 +1,109 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +/* Set default value for TRAP_invalid_op as it is defined only for X86 now */ > +#ifndef TRAP_invalid_op > +#define TRAP_invalid_op 0 > +#endif It feels to me that this value should be defined in the else part in xen/debugger.h. > + > +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc) I would suggest to document what this function is meant to return. AFAUI, it would return a negative value in case of an error otherwise the bug type. > +{ > + const struct bug_frame *bug = NULL; > + const struct virtual_region *region; > + const char *prefix = "", *filename, *predicate; > + unsigned long fixup; > + unsigned int id = BUGFRAME_NR, lineno; > + > + region = find_text_region(pc); > + if ( region ) NIT: If you invert the condition here, then you can reduce the indention by one below. > + { > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + const struct bug_frame *b; > + unsigned int i; You compare this against n_bugs which is a size_t. So, this wants to be a size_t. > + > + for ( i = 0, b = region->frame[id].bugs; > + i < region->frame[id].n_bugs; b++, i++ ) > + { > + if ( bug_loc(b) == pc ) > + { > + bug = b; > + goto found; > + } > + } > + } > + } > + > + found: > + if ( !bug ) > + return -EINVAL; > + > + if ( id == BUGFRAME_run_fn ) > + { > +#ifdef BUG_FN_REG > + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; AFAIU, this is necessary so Arm can use the generic do_bug_frame(). I was under the impression that RISC-V and Arm had the similar issue with %c. It seems like you managed to resolve it on RISC-V, so can we fully switch Arm to the generic implementation of bug? > +#else > + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); > +#endif > + > + fn(regs); > + > + return id; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_ptr(bug); > + if ( !is_kernel(filename) && !is_patch(filename) ) > + return -EINVAL; > + fixup = strlen(filename); > + if ( fixup > 50 ) > + { > + filename += fixup - 47; > + prefix = "..."; > + } > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); > + show_execution_state(regs); > + > + return id; > + > + case BUGFRAME_bug: > + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); > + > + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) > + return id; > + > + show_execution_state(regs); > + panic("Xen BUG at %s%s:%d\n", prefix, filename, lineno); > + > + case BUGFRAME_assert: > + /* ASSERT: decode the predicate string pointer. */ > + predicate = bug_msg(bug); > + if ( !is_kernel(predicate) && !is_patch(predicate) ) > + predicate = ""; > + > + printk("Assertion '%s' failed at %s%s:%d\n", > + predicate, prefix, filename, lineno); > + > + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) > + return id; > + > + show_execution_state(regs); > + panic("Assertion '%s' failed at %s%s:%d\n", > + predicate, prefix, filename, lineno); > + } > + > + return id; > +} > diff --git a/xen/include/xen/bug.h b/xen/include/xen/bug.h > new file mode 100644 > index 0000000000..4b18cfa69c > --- /dev/null > +++ b/xen/include/xen/bug.h > @@ -0,0 +1,150 @@ > +#ifndef __XEN_BUG_H__ > +#define __XEN_BUG_H__ > + > +#define BUG_DISP_WIDTH 24 > +#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > +#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > + > +#define BUGFRAME_run_fn 0 > +#define BUGFRAME_warn 1 > +#define BUGFRAME_bug 2 > +#define BUGFRAME_assert 3 > + > +#define BUGFRAME_NR 4 > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#include errno.h doesn't look to be used within this here. So is it necessary to import it? > +#include Why is this necessary to include in the header? > +#include You don't seem to use __stringify in this header. So is this necessary? > + > +#ifndef BUG_FRAME_STRUCT > + > +struct bug_frame { > + signed int loc_disp:BUG_DISP_WIDTH; > + unsigned int line_hi:BUG_LINE_HI_WIDTH; > + signed int ptr_disp:BUG_DISP_WIDTH; > + unsigned int line_lo:BUG_LINE_LO_WIDTH; > + signed int msg_disp[]; > +}; > + > +#endif /* BUG_FRAME_STRUCT */ > + > +#ifndef bug_loc > +#define bug_loc(b) ((unsigned long)(b) + (b)->loc_disp) > +#endif > + > +#ifndef bug_ptr > +#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) > +#endif > + > +#ifndef bug_line > +#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ > + ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ > + BUG_LINE_LO_WIDTH) + \ > + (((b)->line_lo + ((b)->ptr_disp < 0)) & \ > + ((1 << BUG_LINE_LO_WIDTH) - 1))) > +#endif > + > +#ifndef bug_msg > +#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) > +#endif For all the macro above, it feels wrong to me to allow an architecture to override them if the default BUG_FRAME_STRUCT. It would also feels wrong to me that if the default BUG_FRAME_STRUCT is not used to still partially rely on the generic version of the helper.\ So I would suggest to move them in the #ifndef BUG_FRAME_STRUCT and drop the #ifndef . > + > +#ifndef BUG_ASM_CONST > +#define BUG_ASM_CONST "" > +#endif This line is a bit misterious to me. Would you be able to outline why an architecture would override this? > + > +#if !defined(_ASM_BUGFRAME_TEXT) || !defined(_ASM_BUGFRAME_INFO) > + > +#define _ASM_BUGFRAME_TEXT(second_frame) \ > + ".Lbug%=:"BUG_INSTR"\n" \ > + " .pushsection .bug_frames.%"BUG_ASM_CONST"[bf_type], \"a\", %%progbits\n" \ > + " .p2align 2\n" \ > + ".Lfrm%=:\n" \ > + " .long (.Lbug%= - .Lfrm%=) + %"BUG_ASM_CONST"[bf_line_hi]\n" \ > + " .long (%"BUG_ASM_CONST"[bf_ptr] - .Lfrm%=) + %"BUG_ASM_CONST"[bf_line_lo]\n"\ > + " .if " #second_frame "\n" \ > + " .long 0, %"BUG_ASM_CONST"[bf_msg] - .Lfrm%=\n" \ > + " .endif\n" \ > + " .popsection\n" > + > +#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > + [bf_type] "i" (type), \ > + [bf_ptr] "i" (ptr), \ > + [bf_msg] "i" (msg), \ > + [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ > + << BUG_DISP_WIDTH), \ > + [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) > + > +#endif /* _ASM_BUGFRAME_TEXT || _ASM_BUGFRAME_INFO */ > + > +#ifndef BUG_FRAME > + > +#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ > + BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ > + BUILD_BUG_ON((type) >= BUGFRAME_NR); \ > + asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ > + :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ > +} while (0) > + > +#endif > + > +#ifndef run_in_exception_handler > + > +/* > + * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, > + * and use a real static inline here to get proper type checking of fn(). > + */ > +#define run_in_exception_handler(fn) \ > + do { \ > + (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ > + BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ > + } while ( 0 ) > + > +#endif /* run_in_exception_handler */ > + > +#ifndef WARN > +#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) > +#endif > + > +#ifndef BUG > +#define BUG() do { \ > + BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ > + unreachable(); \ > +} while (0) > +#endif > + > +#ifndef assert_failed > +#define assert_failed(msg) do { \ > + BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ > + unreachable(); \ > +} while (0) > +#endif > + > +#ifdef CONFIG_GENERIC_BUG_FRAME > + > +struct cpu_user_regs; > + > +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc); > + > +#endif /* CONFIG_GENERIC_BUG_FRAME */ > + > +extern const struct bug_frame __start_bug_frames[], > + __stop_bug_frames_0[], > + __stop_bug_frames_1[], > + __stop_bug_frames_2[], > + __stop_bug_frames_3[]; > + > +#endif /* !__ASSEMBLY__ */ > + > +#endif /* __XEN_BUG_H__ */ > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 16:47:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 16:47:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501790.773543 (Exim 4.92) (envelope-from ) id 1pVxhl-00068z-Kj; Sat, 25 Feb 2023 16:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501790.773543; Sat, 25 Feb 2023 16:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxhl-00068s-HZ; Sat, 25 Feb 2023 16:47:25 +0000 Received: by outflank-mailman (input) for mailman id 501790; Sat, 25 Feb 2023 16:47:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxhl-00068m-2N for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 16:47:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxhj-0004G8-JU; Sat, 25 Feb 2023 16:47:23 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVxhj-0002ub-D6; Sat, 25 Feb 2023 16:47:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=t1wX7JafYQ1v/6etPxbCgSpxNr++juIZFmc5pU5b214=; b=cRq0JmJD6+o9sNLvxO7KV2lCtM gAR45IZ0xBbLXjS3vKcPcfkczoqkE/QuSgkGIV+6pWRrHIxhcN/9E/l+7EqWJtTq2M/VpX23sB3ZQ 1cs7/vbyw0BCWE1h8w7kuyEWLV4qXNN+bSk+A2pq/B94DsoqLlMgyK6wZGLtmzkruB4Q=; Message-ID: <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> Date: Sat, 25 Feb 2023 16:47:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 2/4] xen: change to To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> From: Julien Grall In-Reply-To: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: > Since the generic version of bug.h stuff was introduced use > instead of unnecessary > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > * Update patch 2 not to break compilation: move some parts from patches 3 and 4 > to patch 2: > * move some generic parts from to > * add define BUG_FRAME_STRUCT in ARM's > --- > Changes in V2: > * Put [PATCH v1 4/4] xen: change to as second patch, > update the patch to change all to among the whole project > to not break build. > * Update the commit message. > --- > xen/arch/arm/include/asm/bug.h | 19 +++---------------- > xen/arch/arm/include/asm/div64.h | 2 +- > xen/arch/arm/vgic/vgic-v2.c | 2 +- > xen/arch/arm/vgic/vgic.c | 2 +- > xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- > xen/arch/x86/include/asm/asm_defns.h | 2 +- > xen/arch/x86/include/asm/bug.h | 19 ++----------------- > xen/drivers/cpufreq/cpufreq.c | 2 +- > xen/include/xen/lib.h | 2 +- > 9 files changed, 12 insertions(+), 40 deletions(-) > > diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h > index f4088d0913..cacaf014ab 100644 > --- a/xen/arch/arm/include/asm/bug.h > +++ b/xen/arch/arm/include/asm/bug.h > @@ -1,6 +1,8 @@ > #ifndef __ARM_BUG_H__ > #define __ARM_BUG_H__ > > +#include You are not adding new code in bug.h, so can you explain why this is now necessary? > + > #if defined(CONFIG_ARM_32) > # include > #elif defined(CONFIG_ARM_64) > @@ -9,9 +11,7 @@ > # error "unknown ARM variant" > #endif > > -#define BUG_DISP_WIDTH 24 > -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) Even if the values are the same as the one you defined in the common bug.h, it doesn't feel right to remove them as long as... > +#define BUG_FRAME_STRUCT the arch is defining BUG_FRAME_STRUCT. So I would say the generic one should be defined within BUG_FRAME_STRUCT. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 16:49:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 16:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501794.773553 (Exim 4.92) (envelope-from ) id 1pVxjY-00076v-0K; Sat, 25 Feb 2023 16:49:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501794.773553; Sat, 25 Feb 2023 16:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxjX-00076o-Ty; Sat, 25 Feb 2023 16:49:15 +0000 Received: by outflank-mailman (input) for mailman id 501794; Sat, 25 Feb 2023 16:49:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxjX-00076i-6m for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 16:49:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxjW-0004IB-Ky; Sat, 25 Feb 2023 16:49:14 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVxjW-0002w5-Fn; Sat, 25 Feb 2023 16:49:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=scvV+1qPNTIcjEH+FOHsFTwHlFli9wheXqx+sCdBL9g=; b=zU9jvI+jCDh1kuXj26EuXWIQdt 4yiTQQlFkfCl/Si1pZcWeN1Zy2aZm8OzuycKsuBTMkih2HsegU/vrWaPS5S4nKWV49vJOgUCLtVR+ 7+hWqZ6DvqKzC/grgV1o2HVEqqwlNYJdyec9aQfYT0BX8UH9Ix+p7QUwvRaruNWJtroA=; Message-ID: Date: Sat, 25 Feb 2023 16:49:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksii, On 24/02/2023 11:31, Oleksii Kurochko wrote: > The following changes were made: > * make GENERIC_BUG_FRAME mandatory for ARM I have asked in patch #1 but will ask it again because I think this should be recorded in the commit message. Can you outline why it is not possible to completely switch to the generic version? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 17:05:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 17:05:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501815.773563 (Exim 4.92) (envelope-from ) id 1pVxyu-0001WT-BX; Sat, 25 Feb 2023 17:05:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501815.773563; Sat, 25 Feb 2023 17:05:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxyu-0001WM-8j; Sat, 25 Feb 2023 17:05:08 +0000 Received: by outflank-mailman (input) for mailman id 501815; Sat, 25 Feb 2023 17:05:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxyt-0001WG-4h for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 17:05:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVxys-0004cT-Hq; Sat, 25 Feb 2023 17:05:06 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVxys-0000PO-C4; Sat, 25 Feb 2023 17:05:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=ToKuXvN+MLavtIaVPHGL4aJSFfhrxeHwMVpbdLjZeA4=; b=5AWEe19cksB1e0cA3c1CdaJskT onaREs5EGnEbUvVl6i1CoSlXZ8Wru8RD861ubAmvcSLvBm1jn9U2vnFV4N3GrSL6MHLYWQiYcbQ+Y VCUUi3liXK5JddUZWrshVOCSC4J+zOSevJ+OxFEPr8VlhOl38qse17Nd2IwGHDIiWKOQ=; Message-ID: Date: Sat, 25 Feb 2023 17:05:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h From: Julien Grall To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/02/2023 16:49, Julien Grall wrote: > Hi Oleksii, > > On 24/02/2023 11:31, Oleksii Kurochko wrote: >> The following changes were made: >> * make GENERIC_BUG_FRAME mandatory for ARM > > I have asked in patch #1 but will ask it again because I think this > should be recorded in the commit message. Can you outline why it is not > possible to completely switch to the generic version? I have just tried to remove it on arm64 and it seems to work. This was only tested with GCC 10 though. But given the generic version is not not using the %c modifier, then I wouldn't expect any issue. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 17:53:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 17:53:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501826.773573 (Exim 4.92) (envelope-from ) id 1pVyjL-0000EN-TL; Sat, 25 Feb 2023 17:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501826.773573; Sat, 25 Feb 2023 17:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyjL-0000EG-QL; Sat, 25 Feb 2023 17:53:07 +0000 Received: by outflank-mailman (input) for mailman id 501826; Sat, 25 Feb 2023 17:53:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyjL-0000EA-12 for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 17:53:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyjK-0005kr-C5; Sat, 25 Feb 2023 17:53:06 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVyjK-00024W-2O; Sat, 25 Feb 2023 17:53:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=JEFiM2K6exuMEs/6AcCfS5dqBplMhSpN3XSGJ2LUGtI=; b=ZyeUiYW0bH0/slMPs54W+k6P/n SsM7ZmtYkhHI4NsVcnqOIZMMi04pgtAQ8f9U4251hlOA7QG1bifcJ9YYNQTdKGpBEi6GvfwCW9Qve RvbhNVVrGpIwBh8i6cwphmV6wtT28CN6Lf+wYTfZ9OGBdU79R9zr+oKkOP2ih6MzVyIg=; Message-ID: Date: Sat, 25 Feb 2023 17:53:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: From: Julien Grall Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksii, On 24/02/2023 15:06, Oleksii Kurochko wrote: > Mostly the code for setup_initial_pages was taken from Bobby's > repo except for the following changes: > * Use only a minimal part of the code enough to enable MMU > * rename {_}setup_initial_pagetables functions > * add writable argument for _setup_initial_pagetables to have > an opportunity to make some sections read-only > * update setup_initial_pagetables function to make some sections > read-only > * change the order of _setup_inital_pagetables() > in setup_initial_pagetable(): > * first it is called for text, init, rodata sections > * after call it for ranges [link_addr_start : link_addr_end] and > [load_addr_start : load_addr_end] > Before it was done first for the ranges and after for sections but > in that case read-only status will be equal to 'true' and > as sections' addresses can/are inside the ranges the read-only status > won't be updated for them as it was set up before. > > Origin: https://gitlab.com/xen-on-risc-v/xen/-/tree/riscv-rebase 4af165b468af > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/Makefile | 1 + > xen/arch/riscv/include/asm/mm.h | 9 ++ > xen/arch/riscv/include/asm/page.h | 90 ++++++++++++ > xen/arch/riscv/mm.c | 223 ++++++++++++++++++++++++++++++ > 4 files changed, 323 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/mm.h > create mode 100644 xen/arch/riscv/include/asm/page.h > create mode 100644 xen/arch/riscv/mm.c > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 443f6bf15f..956ceb02df 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,5 +1,6 @@ > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-y += entry.o > +obj-y += mm.o > obj-$(CONFIG_RISCV_64) += riscv64/ > obj-y += sbi.o > obj-y += setup.o > diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h > new file mode 100644 > index 0000000000..fc1866b1d8 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/mm.h > @@ -0,0 +1,9 @@ > +#ifndef _ASM_RISCV_MM_H > +#define _ASM_RISCV_MM_H > + > +void setup_initial_pagetables(unsigned long load_addr_start, > + unsigned long load_addr_end, > + unsigned long linker_addr_start, > + unsigned long linker_addr_end); > + > +#endif /* _ASM_RISCV_MM_H */ > diff --git a/xen/arch/riscv/include/asm/page.h b/xen/arch/riscv/include/asm/page.h > new file mode 100644 > index 0000000000..fabbe1305f > --- /dev/null > +++ b/xen/arch/riscv/include/asm/page.h > @@ -0,0 +1,90 @@ > +#ifndef _ASM_RISCV_PAGE_H > +#define _ASM_RISCV_PAGE_H > + > +#include > +#include > + > +#define PAGE_ENTRIES 512 NIT: AFAIU, the number here is based on ... > +#define VPN_BITS (9) ... this. So I would suggest to define PAGE_ENTRIES using VPN_BITS. > +#define VPN_MASK ((unsigned long)((1 << VPN_BITS) - 1)) NIT: Use 1UL and you can avoid the cast. > + > +#ifdef CONFIG_RISCV_64 > +/* L3 index Bit[47:39] */ > +#define THIRD_SHIFT (39) > +#define THIRD_MASK (VPN_MASK << THIRD_SHIFT) > +/* L2 index Bit[38:30] */ > +#define SECOND_SHIFT (30) > +#define SECOND_MASK (VPN_MASK << SECOND_SHIFT) > +/* L1 index Bit[29:21] */ > +#define FIRST_SHIFT (21) > +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) > +/* L0 index Bit[20:12] */ > +#define ZEROETH_SHIFT (12) > +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) On Arm, we are trying to phase out ZEROETH_* and co because the name is too generic. Instead, we now introduce a generic macro that take a level and then compute the mask/shift (see XEN_PT_LEVEL_*). You should be able to do in RISC-V and reduce the amount of defines introduced. > + > +#else // CONFIG_RISCV_32 Coding style: comments in Xen are using /* ... */ > + > +/* L1 index Bit[31:22] */ > +#define FIRST_SHIFT (22) > +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) > + > +/* L0 index Bit[21:12] */ > +#define ZEROETH_SHIFT (12) > +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) > +#endif > + > +#define THIRD_SIZE (1 << THIRD_SHIFT) > +#define THIRD_MAP_MASK (~(THIRD_SIZE - 1)) > +#define SECOND_SIZE (1 << SECOND_SHIFT) > +#define SECOND_MAP_MASK (~(SECOND_SIZE - 1)) > +#define FIRST_SIZE (1 << FIRST_SHIFT) > +#define FIRST_MAP_MASK (~(FIRST_SIZE - 1)) > +#define ZEROETH_SIZE (1 << ZEROETH_SHIFT) > +#define ZEROETH_MAP_MASK (~(ZEROETH_SIZE - 1)) > + > +#define PTE_SHIFT 10 > + > +#define PTE_VALID BIT(0, UL) > +#define PTE_READABLE BIT(1, UL) > +#define PTE_WRITABLE BIT(2, UL) > +#define PTE_EXECUTABLE BIT(3, UL) > +#define PTE_USER BIT(4, UL) > +#define PTE_GLOBAL BIT(5, UL) > +#define PTE_ACCESSED BIT(6, UL) > +#define PTE_DIRTY BIT(7, UL) > +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) > + > +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE | PTE_EXECUTABLE) We should avoid vulnerable default flags. So this should either be RW or RX. > +#define PTE_TABLE (PTE_VALID) > + > +/* Calculate the offsets into the pagetables for a given VA */ > +#define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT) > +#define first_linear_offset(va) ((va) >> FIRST_SHIFT) > +#define second_linear_offset(va) ((va) >> SECOND_SHIFT) > +#define third_linear_offset(va) ((va) >> THIRD_SHIFT) > + > +#define pagetable_zeroeth_index(va) zeroeth_linear_offset((va) & ZEROETH_MASK) > +#define pagetable_first_index(va) first_linear_offset((va) & FIRST_MASK) > +#define pagetable_second_index(va) second_linear_offset((va) & SECOND_MASK) > +#define pagetable_third_index(va) third_linear_offset((va) & THIRD_MASK) > + > +/* Page Table entry */ > +typedef struct { > + uint64_t pte; > +} pte_t; > + > +/* Shift the VPN[x] or PPN[x] fields of a virtual or physical address > + * to become the shifted PPN[x] fields of a page table entry */ > +#define addr_to_ppn(x) (((x) >> PAGE_SHIFT) << PTE_SHIFT) > + > +static inline pte_t paddr_to_pte(unsigned long paddr) > +{ > + return (pte_t) { .pte = addr_to_ppn(paddr) }; > +} > + > +static inline bool pte_is_valid(pte_t *p) > +{ > + return p->pte & PTE_VALID; > +} > + > +#endif /* _ASM_RISCV_PAGE_H */ > diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c > new file mode 100644 > index 0000000000..6e172376eb > --- /dev/null > +++ b/xen/arch/riscv/mm.c > @@ -0,0 +1,223 @@ > +#include > +#include > + > +#include > +#include > +#include > + > +/* > + * xen_second_pagetable is indexed with the VPN[2] page table entry field > + * xen_first_pagetable is accessed from the VPN[1] page table entry field > + * xen_zeroeth_pagetable is accessed from the VPN[0] page table entry field > + */ > +pte_t xen_second_pagetable[PAGE_ENTRIES] __attribute__((__aligned__(PAGE_SIZE))); > +static pte_t xen_first_pagetable[PAGE_ENTRIES] > + __attribute__((__aligned__(PAGE_SIZE))); > +static pte_t xen_zeroeth_pagetable[PAGE_ENTRIES] > + __attribute__((__aligned__(PAGE_SIZE))); > + > +extern unsigned long _stext; > +extern unsigned long _etext; > +extern unsigned long __init_begin; > +extern unsigned long __init_end; > +extern unsigned long _srodata; > +extern unsigned long _erodata; > + > +paddr_t phys_offset; This is defined, set but not used. > + > +#define resolve_early_addr(x) \ This helper seems to behave the same wasy as linker_addr(). So any reason to not use it? I will make this assumption this can be used and not comment on the implement of resolve_early_addr(). > + ({ \ > + unsigned long * __##x; \ > + if ( load_addr_start <= x && x < load_addr_end ) \ > + __##x = (unsigned long *)x; \ > + else \ > + __##x = (unsigned long *)(x + load_addr_start - linker_addr_start); \ > + __##x; \ > + }) > + > +static void __init clear_pagetables(unsigned long load_addr_start, > + unsigned long load_addr_end, > + unsigned long linker_addr_start, > + unsigned long linker_addr_end) > +{ > + unsigned long *p; > + unsigned long page; > + unsigned long i; > + > + page = (unsigned long)&xen_second_pagetable[0]; > + > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_second_pagetable); i++ ) The entries in xen_second_pagetable are a pte_t (uint64_t). But ... > + { > + p[i] = 0ULL; ... the type here will be unsigned long. So you may not fully zero the page-table on 32-bit architecture. Therefore you want to define as pte_t. That said, given the page table will be part of BSS, you should not need to zero again assuming you clear BSS before hand. If you clear afterwards, then you *must* move them out of BSS. The same applies for xen_{first, zeroeth}_pagetable below. > + } > + > + page = (unsigned long)&xen_first_pagetable[0]; > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_first_pagetable); i++ ) > + { > + p[i] = 0ULL; > + } > + > + page = (unsigned long)&xen_zeroeth_pagetable[0]; > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_zeroeth_pagetable); i++ ) > + { > + p[i] = 0ULL; > + } > +} > + > +/* > + * WARNING: load_addr() and linker_addr() are to be called only when the MMU is > + * disabled and only when executed by the primary CPU. They cannot refer to > + * any global variable or functions. I find interesting you are saying when _setup_initial_pagetables() is called from setup_initial_pagetables(). Would you be able to explain how this is different? > + */ > + > +/* > + * Convert an addressed layed out at link time to the address where it was loaded Typo: s/addressed/address/ ? > + * by the bootloader. > + */ Looking at the implementation, you seem to consider that any address not in the range [linker_addr_start, linker_addr_end[ will have a 1:1 mappings. I am not sure this is what you want. So I would consider to throw an error if such address is passed. > +#define load_addr(linker_address) \ > + ({ \ > + unsigned long __linker_address = (unsigned long)(linker_address); \ > + if ( linker_addr_start <= __linker_address && \ > + __linker_address < linker_addr_end ) \ > + { \ > + __linker_address = \ > + __linker_address - linker_addr_start + load_addr_start; \ > + } \ > + __linker_address; \ > + }) > + > +/* Convert boot-time Xen address from where it was loaded by the boot loader to the address it was layed out > + * at link-time. > + */ Coding style: The first line is too long and multi-line comments look like: /* * Foo * Bar */ > +#define linker_addr(load_address) \ Same remark as for load_addr() above. > + ({ \ > + unsigned long __load_address = (unsigned long)(load_address); \ > + if ( load_addr_start <= __load_address && \ > + __load_address < load_addr_end ) \ > + { \ > + __load_address = \ > + __load_address - load_addr_start + linker_addr_start; \ > + } \ > + __load_address; \ > + }) > + > +static void __attribute__((section(".entry"))) > +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t *zeroeth, Can this be named to setup_initial_mapping() so this is clearer and avoid the one '_' different with the function below. > + unsigned long map_start, > + unsigned long map_end, > + unsigned long pa_start, > + bool writable) What about the executable bit? > +{ > + unsigned long page_addr; > + unsigned long index2; > + unsigned long index1; > + unsigned long index0; index* could be defined in the loop below. > + > + /* align start addresses */ > + map_start &= ZEROETH_MAP_MASK; > + pa_start &= ZEROETH_MAP_MASK; Hmmm... I would actually expect the address to be properly aligned and therefore not require an alignment here. Otherwise, this raise the question of what happen if you have region using the same page? > + > + page_addr = map_start; > + while ( page_addr < map_end ) Looking at the loop, it looks like you are assuming that the region will never cross a boundary of a page-table (either L0, L1, L2). I am not convinced you can make such assumption (see below). But if you really want to make such assumption then you should add some guard (either BUILD_BUG_ON(), ASSERT(), proper check) in your code to avoid any surprise in the future. > + { > + index2 = pagetable_second_index(page_addr); > + index1 = pagetable_first_index(page_addr); > + index0 = pagetable_zeroeth_index(page_addr); > + > + /* Setup level2 table */ > + second[index2] = paddr_to_pte((unsigned long)first); > + second[index2].pte |= PTE_TABLE; > + > + /* Setup level1 table */ > + first[index1] = paddr_to_pte((unsigned long)zeroeth); > + first[index1].pte |= PTE_TABLE; > + > + /* Setup level0 table */ > + if ( !pte_is_valid(&zeroeth[index0]) ) Can you explain why you are checking !pte_is_valid() for the L0 entry but not the other? > + { > + /* Update level0 table */ > + zeroeth[index0] = paddr_to_pte((page_addr - map_start) + pa_start); > + zeroeth[index0].pte |= PTE_LEAF_DEFAULT; > + zeroeth[index0].pte &= ~((!writable) ? PTE_WRITABLE : 0); Looking at the default value, it would mean that a non-writable mapping is automatically executable. This seems wrong for the section is not meant to be executable (like rodata). > + } > + > + /* Point to next page */ > + page_addr += ZEROETH_SIZE; > + } > +} > + > +/* > + * setup_initial_pagetables: > + * > + * 1) Build the page tables for Xen that map the following: > + * 1.1) The physical location of Xen (where the bootloader loaded it) > + * 1.2) The link-time location of Xen (where the linker expected Xen's > + * addresses to be) > + * 2) Load the page table into the SATP and enable the MMU > + */ > +void __attribute__((section(".entry"))) I couldn't find a section ".entry" in the linker. > +setup_initial_pagetables(unsigned long load_addr_start, > + unsigned long load_addr_end, > + unsigned long linker_addr_start, > + unsigned long linker_addr_end) > +{ > + pte_t *second; > + pte_t *first; > + pte_t *zeroeth; > + > + clear_pagetables(load_addr_start, load_addr_end, > + linker_addr_start, linker_addr_end); > + > + /* Get the addresses where the page tables were loaded */ > + second = (pte_t *)load_addr(&xen_second_pagetable); > + first = (pte_t *)load_addr(&xen_first_pagetable); > + zeroeth = (pte_t *)load_addr(&xen_zeroeth_pagetable); I would consider to embed the type cast in load_addr() so you are adding some type safety within your code. > + > + /* > + * Create a mapping from Xen's link-time addresses to where they were actually loaded. This is line is way long than 80 characters. Please make sure to wrap it 80 characters. > + */ > + _setup_initial_pagetables(second, first, zeroeth, > + linker_addr(&_stext), > + linker_addr(&_etext), > + load_addr(&_stext), > + false); > + _setup_initial_pagetables(second, first, zeroeth, > + linker_addr(&__init_begin), > + linker_addr(&__init_end), > + load_addr(&__init_begin), > + true); > + _setup_initial_pagetables(second, first, zeroeth, > + linker_addr(&_srodata), > + linker_addr(&_erodata), > + load_addr(&_srodata), > + false); > + _setup_initial_pagetables(second, first, zeroeth, > + linker_addr_start, > + linker_addr_end, > + load_addr_start, > + true); Where do you guarantee that Xen will always fit in an L0 table and the start address is aligned to the size of an L0 table? > + > + /* > + * Create a mapping of the load time address range to... the load time address range. Same about the line length here. > + * This mapping is used at boot time only. > + */ > + _setup_initial_pagetables(second, first, zeroeth, This can only work if Xen is loaded at its linked address. So you need a separate set of L0, L1 tables for the identity mapping. That said, this would not be sufficient because: 1) Xen may not be loaded at a 2M boundary (you can control with U-boot, but not with EFI). So this may cross a boundary and therefore need multiple pages. 2) The load region may overlap the link address While I think it would be good to handle those cases from the start, I would understand why are not easy to solve. So I think the minimum is to throw some errors if you are in a case you can't support. > + load_addr_start, > + load_addr_end, > + load_addr_start, > + true); > + > + /* Ensure page table writes precede loading the SATP */ > + asm volatile("sfence.vma"); > + > + /* Enable the MMU and load the new pagetable for Xen */ > + csr_write(CSR_SATP, > + (load_addr(xen_second_pagetable) >> PAGE_SHIFT) | SATP_MODE_SV39 << SATP_MODE_SHIFT); IHMO, it would make sense to introduce within the series the code to jump off the identity mapping and then remove it. > + > + phys_offset = load_addr_start - linker_addr_start; > + > + return; > +} Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 18:05:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 18:05:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501835.773584 (Exim 4.92) (envelope-from ) id 1pVyvJ-0002K6-52; Sat, 25 Feb 2023 18:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501835.773584; Sat, 25 Feb 2023 18:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyvJ-0002Jz-0Z; Sat, 25 Feb 2023 18:05:29 +0000 Received: by outflank-mailman (input) for mailman id 501835; Sat, 25 Feb 2023 18:05:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyvI-0002Jt-0U for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 18:05:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pVyvH-00066S-Jv; Sat, 25 Feb 2023 18:05:27 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVyvH-0002l8-Ch; Sat, 25 Feb 2023 18:05:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=G3XbD2sOaausKVXx4uTdHeB8R2lPYFsrZpXbi5D8oz8=; b=139EUDpWnj0uP/e/XlmgH71Ea8 dw3eSrRPAC7QPTRE49q6MyTQXEv9JbZ9412XwWYDwOfTRrFjr9kbE6cRnGOcM1q/2g7sv8sxNqoin ieStXck2Sx4X778PdwtHs2UdIE/6iBjPqBzINlJUmb/+Om1jUjdZDZgPoPKSDjUJcU1o=; Message-ID: <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> Date: Sat, 25 Feb 2023 18:05:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 To: Oleksii Kurochko , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> From: Julien Grall Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables In-Reply-To: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 24/02/2023 15:06, Oleksii Kurochko wrote: > Calculate load and linker linker image addresses and > setup initial pagetables. > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/setup.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index b7cd438a1d..f69bc278bb 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,9 +1,11 @@ > #include > #include > #include > +#include > > #include > #include > +#include > #include > > /* Xen stack for bringing up the first CPU. */ > @@ -43,6 +45,11 @@ static void __init disable_fpu(void) > > void __init noreturn start_xen(void) > { > + unsigned long load_start = (unsigned long)start; > + unsigned long load_end = load_start + (unsigned long)(_end - _start); I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote it can't use global variable/function. But here... you are using them. So how is this different? > + unsigned long linker_start = (unsigned long)_start; > + unsigned long linker_end = (unsigned long)_end; I am a bit confused with how you define the start/end for both the linker and load. In one you use _start and the other _end. Both are fixed at compile time, so I assume the values will be a linked address rather than the load address. So how is this meant to how? Furthermore, I would expect linker_start and load_start to point to the same symbol (the only different is one store the virtual address whereas the other the physical address). But here you are technically using two different symbol. Can you explain why? > + > /* > * The following things are passed by bootloader: > * a0 -> hart_id > @@ -65,6 +72,10 @@ void __init noreturn start_xen(void) > > test_macros_from_bug_h(); > > + setup_initial_pagetables(load_start, load_end, linker_start, linker_end); Shouldn't this happen earlier in start_xen()? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Feb 25 19:59:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 19:59:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501844.773593 (Exim 4.92) (envelope-from ) id 1pW0hj-00019r-Eb; Sat, 25 Feb 2023 19:59:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501844.773593; Sat, 25 Feb 2023 19:59:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW0hj-00019k-AU; Sat, 25 Feb 2023 19:59:35 +0000 Received: by outflank-mailman (input) for mailman id 501844; Sat, 25 Feb 2023 19:59:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW0hh-00019a-QO; Sat, 25 Feb 2023 19:59:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW0hh-0000DJ-NL; Sat, 25 Feb 2023 19:59:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW0hh-0001OG-GF; Sat, 25 Feb 2023 19:59:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pW0hh-0002Gk-Fl; Sat, 25 Feb 2023 19:59:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dxU+f6Web/x4w7jsi9JkudZsYVtlsuVs+JcI3wr4sz0=; b=K9g4d96SZEW6SZkESFOReXU3j1 5AAK/ivq+XSOXa3vV91nSoxzd6TfTmNV9N8kdUdhBQZHrCI9xeRM2sh8DLQjMc1X2KPeSDGThEDb1 L/BIw29063htlZ0WjMR3EJAOV8nMWqiWZPk0A5gyJt24lU1/OFhxio9KV4I1gKtY1thw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178432: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=608f85a1818697156b72ace4913a17c8178a0ef5 X-Osstest-Versions-That: xen=91d4d9506a4e8906253d1280bd5a1f39668fad64 From: osstest service owner Date: Sat, 25 Feb 2023 19:59:33 +0000 flight 178432 xen-unstable real [real] flight 178483 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178432/ http://logs.test-lab.xenproject.org/osstest/logs/178483/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 178483 pass in 178432 test-amd64-i386-pair 10 xen-install/src_host fail pass in 178483-retest test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 178483-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178355 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178355 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178355 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178355 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178355 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178355 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178355 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178355 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178355 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a version targeted for testing: xen 608f85a1818697156b72ace4913a17c8178a0ef5 baseline version: xen 91d4d9506a4e8906253d1280bd5a1f39668fad64 Last test of basis 178355 2023-02-24 13:12:55 Z 1 days Testing same since 178432 2023-02-25 06:27:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Bertrand Marquis Jan Beulich Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 91d4d9506a..608f85a181 608f85a1818697156b72ace4913a17c8178a0ef5 -> master From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:37:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:37:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501868.773677 (Exim 4.92) (envelope-from ) id 1pW1Ic-0007gT-Dw; Sat, 25 Feb 2023 20:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501868.773677; Sat, 25 Feb 2023 20:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ic-0007gH-A2; Sat, 25 Feb 2023 20:37:42 +0000 Received: by outflank-mailman (input) for mailman id 501868; Sat, 25 Feb 2023 20:37:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ib-0007PG-34 for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:37:41 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3eb0e9ef-b54c-11ed-88bb-e56d68cac8db; Sat, 25 Feb 2023 21:37:40 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0E00932007E8; Sat, 25 Feb 2023 15:37:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 25 Feb 2023 15:37:38 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:36 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3eb0e9ef-b54c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357457; x=1677443857; bh=+fUifg3+9Sx5Ngno/T4jBLJLFOiv4d2p9UY Hj/k/F/0=; b=GjRCenfuZRaTxh3/zFIbA1iNlWi0h98bXO8KvuU3ykmRm5LDtpX CyDxnMRpJwkmdZ9R7xRbanMxhMet/qiCsM8W77O869bbnd0U14AvT6JHqgsbIa1A Q16ikHtslrSEHkxnWwWaUV8BPAdkk4MpULCvfrkkukQ8i+DQ4syERJvqechE/UzG RcBfm370/G1d1wwc+pSeW8LWaR7ex+XV01aTjCSYZKpvHdIgrdzACm2y5Ws4rSxS 5/Xjhx/dqI5l9+mghmaXjH58opK87fp37G+IU4bD4thckxXFDvzCCNYnPN50+ZcQ Fw0UoB6Vg3lZfQ1h4Zvne+J6yPB+aq1Nfqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357457; x=1677443857; bh=+fUifg3+9Sx5N gno/T4jBLJLFOiv4d2p9UYHj/k/F/0=; b=jd7yvf37WWvrzLms1i7Wte/TCopwN k6FBV7CB2uMy6ZXqdilcLHpI3JiixfCxaHwdVFwaPi6Hq3pIlZpGlXzG1QA+14lb ZJ61P/HsTmItCSjGhWDlCcSPhTxNAh6lEAMenFnW0VEM0ABfd4qLRwFUiYV6XQe/ WVlB3ULfpvDayE3WI8Fl2lmf04VfY046epmo5MBTlu3SwVOTxqh4fPswBenwA6/o tKOKl8qVsuUKBsjZEizV8BJ0vg15dtSpBW+NjE5uuu2Yy6zgFHLOV+EpNUeMN5Em Dx0XZYx5eYz6KhgjsYAGlfvbJv5OnjOwOL7thrcUr0ZxepUZb3luA41tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuefgffeihefhffelkeehffeljeeu teeihfeiudejgeeufffhheeugfekhfeiffeinecuffhomhgrihhnpeigvghnrdhorhhgpd igvghnphhrohhjvggtthdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH v5 1/5] Use HTTPS for all xenbits.xen.org Git repos Date: Sat, 25 Feb 2023 15:37:11 -0500 Message-Id: <9cb98cb9aaca22bbc88de9fd8cbd7f9463b4d425.1677356813.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports for all xenbits.xen.org Git repositories. It was generated with the following shell script: git ls-files -z | xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' All altered links have been tested and are known to work. Signed-off-by: Demi Marie Obenour --- Config.mk | 18 +++++------------- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- scripts/get_maintainer.pl | 2 +- 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/Config.mk b/Config.mk index 10eb443b17d85381b2d1e2282f8965c3e99767e0..75f1975e5e78af44d36c2372cba6e89b425267a5 100644 --- a/Config.mk +++ b/Config.mk @@ -215,19 +215,11 @@ ifneq (,$(QEMU_TAG)) QEMU_TRADITIONAL_REVISION ?= $(QEMU_TAG) endif -ifeq ($(GIT_HTTP),y) -OVMF_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/ovmf.git -QEMU_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/qemu-xen.git -QEMU_TRADITIONAL_URL ?= http://xenbits.xen.org/git-http/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/seabios.git -MINIOS_UPSTREAM_URL ?= http://xenbits.xen.org/git-http/mini-os.git -else -OVMF_UPSTREAM_URL ?= git://xenbits.xen.org/ovmf.git -QEMU_UPSTREAM_URL ?= git://xenbits.xen.org/qemu-xen.git -QEMU_TRADITIONAL_URL ?= git://xenbits.xen.org/qemu-xen-traditional.git -SEABIOS_UPSTREAM_URL ?= git://xenbits.xen.org/seabios.git -MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git -endif +OVMF_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/ovmf.git +QEMU_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/qemu-xen.git +QEMU_TRADITIONAL_URL ?= https://xenbits.xen.org/git-http/qemu-xen-traditional.git +SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git +MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc index d38e4ce074b399946aecdaedb4cb6fe5b8043b66..a94fb57eb568e85a25c93bf6a988f123d4e48443 100644 --- a/docs/misc/livepatch.pandoc +++ b/docs/misc/livepatch.pandoc @@ -993,7 +993,7 @@ The design of that is not discussed in this design. This is implemented in a seperate tool which lives in a seperate GIT repo. -Currently it resides at git://xenbits.xen.org/livepatch-build-tools.git +Currently it resides at https://xenbits.xen.org/git-http/livepatch-build-tools.git ### Exception tables and symbol tables growth diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index 8f80d61d2f1aa9e63da9b1e61b77a67c826efe6f..7826419dad563a3b70c3c97fc4c0fb5339bd58e9 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -271,7 +271,7 @@ Hi all, Xen X.Y rcZ is tagged. You can check that out from xen.git: -git://xenbits.xen.org/xen.git X.Y.0-rcZ +https://xenbits.xen.org/git-http/xen.git X.Y.0-rcZ For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/X.Y.0-rcZ/xen-X.Y.0-rcZ.tar.gz diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 48e07370e8d462ced70a1de13ec8134b4eed65ba..cf629cdf3c44e4abe67214378c49a3a9d858d9b5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -1457,7 +1457,7 @@ sub vcs_exists { warn("$P: No supported VCS found. Add --nogit to options?\n"); warn("Using a git repository produces better results.\n"); warn("Try latest git repository using:\n"); - warn("git clone git://xenbits.xen.org/xen.git\n"); + warn("git clone https://xenbits.xen.org/git-http/xen.git\n"); $printed_novcs = 1; } return 0; -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:37:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:37:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501867.773666 (Exim 4.92) (envelope-from ) id 1pW1IV-0007PT-2F; Sat, 25 Feb 2023 20:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501867.773666; Sat, 25 Feb 2023 20:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1IU-0007PM-Va; Sat, 25 Feb 2023 20:37:34 +0000 Received: by outflank-mailman (input) for mailman id 501867; Sat, 25 Feb 2023 20:37:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1IT-0007PG-41 for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:37:33 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37a18c7e-b54c-11ed-88bb-e56d68cac8db; Sat, 25 Feb 2023 21:37:30 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 27EDA32004AE; Sat, 25 Feb 2023 15:37:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 25 Feb 2023 15:37:26 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:23 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37a18c7e-b54c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357444; x=1677443844; bh=O4/IZ+LuGJRHMvCUTkXEoOEx+FGHNfoNKJ2 om9c4VdI=; b=p4aDnP7hxbRCNULXC4DzXv88OAYlhDVPgE9EVhuOV21Kiv9sDeV 5HMuOC2Z0uDkqvIaNtgjd+ny56W6xXBp8m3ETEz64zhe+umkX2R7PSJADMzcliY5 iuag9poAMqs0dxmpCyeGrcvx5XXGcmD12jcO4oFYTxw4UwkETjekidSuPqW23W6T 69JlPwPxMd6AMsFrkMEp3+AdifgcSErpW5zxUqGD6Q91JyWcFCxEIQ83plVAZZD6 SFLHWC0R4hlwpm5yUUbHE9p9yWyi3pr6PxbB1BU32GF1j0VLybM9ACxR/JGQYf0e ucJwBsQbQDHPsYIVctJ7D8qKnTKJb5sitTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357444; x=1677443844; bh=O4/IZ+LuGJRHM vCUTkXEoOEx+FGHNfoNKJ2om9c4VdI=; b=KZmEalqhO1cvpS90Baj8dKWVZLual pHZv799zyBj4NtiFiW8WrhJPskGlBGySAbOVe5ghvu3KfL9HXCyTY0KhUHRacImI H89+kEU1/hcsSK/fTU584jCdqIBIRZl7+xo+5aDsGC3+bC1pDA5cwNbm69SAOMS4 HlIha9NX8ZBpDC4dmw6A+IkBwPJVPEoGi18+qjuS8BTQ+UP4MYGKIBRNeylknC7U 1W5Ngt6CPGVuBQXFA/a1FJB9uoGAyrTrm1Fppl8c/Ohsq8Lq1humz5buBLv3nspB FD7X4Y9Oupo3aCgILdZWjYQi/g1NOePZXENNA+RiTUB2f0/J5kUAR9tHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptefhhfdtkefhkefgjeduffehuedt gfduveejiedvffdvgeevledttdegvefhueegnecuffhomhgrihhnpeigvghnrdhorhhgpd gtohhnfhhighdrmhhknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall , Anthony PERARD , Samuel Thibault , Doug Goldstein Subject: [PATCH v5 0/5] Stop using insecure transports Date: Sat, 25 Feb 2023 15:37:10 -0500 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. Changes since v4: - Remove known-broken links entirely. They only mislead users into believing the code can be obtained there when it cannot. Changes since v3: - Drop patch 4, which is an unrelated removal of unused code. - Do not fail with an error if one tries to build the I/O emulator, vTPM, or vTPM manager stubdomains and passes --enable-extfiles. The user may have provided alternate download URLs via environment variables. Changes since v2: - Drop patches 5 and 6, which changed links not used by automated tools. These patches are the least urgent and hardest to review. - Ensure that no links are broken, and fail with an error instead of trying to use links that *are* broken. Demi Marie Obenour (5): Use HTTPS for all xenbits.xen.org Git repos Change remaining xenbits.xen.org links to HTTPS Build system: Do not try to use broken links Build system: Replace git:// and http:// with https:// Automation and CI: Replace git:// and http:// with https:// Config.mk | 20 ++++--------- README | 4 +-- automation/build/debian/stretch-llvm-8.list | 4 +-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- docs/misc/livepatch.pandoc | 2 +- docs/process/xen-release-management.pandoc | 2 +- m4/stubdom.m4 | 5 ++-- scripts/get_maintainer.pl | 2 +- stubdom/configure | 33 ++++++--------------- stubdom/configure.ac | 18 +++++------ tools/firmware/etherboot/Makefile | 6 +--- tools/misc/mkrpm | 2 +- 12 files changed, 37 insertions(+), 63 deletions(-) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:37:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:37:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501870.773687 (Exim 4.92) (envelope-from ) id 1pW1Ik-0007zt-L7; Sat, 25 Feb 2023 20:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501870.773687; Sat, 25 Feb 2023 20:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ik-0007zk-Hw; Sat, 25 Feb 2023 20:37:50 +0000 Received: by outflank-mailman (input) for mailman id 501870; Sat, 25 Feb 2023 20:37:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ij-0007yc-Oh for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:37:49 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4162fbfc-b54c-11ed-a82a-c9ca1d2f71af; Sat, 25 Feb 2023 21:37:48 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 67C5E5C009D; Sat, 25 Feb 2023 15:37:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 25 Feb 2023 15:37:43 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:41 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4162fbfc-b54c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357463; x=1677443863; bh=DLRFynjeQ7h4Iqriku9OW2YC9py/QqyZn5H hylUDGk4=; b=Tis2+b/6AIiQ1NA/82TuNQnJfHqUecgC6ERoIGxnyOzHDpuRazo 2vnA9m0GuMWjjB6WeREqIJaymDHrshqceKTOsNCZWkcG4e9gKfM4zvIBK2137PC5 QA+pOQ08wqbEWYc8L38ydflFFzebLFpYto9ZPxtziCjpnZSqFn3w3LW6DE6Fa69D FG3Z8rO73KboK4CtJ3urBwvcoibTbDtmcFWufFevyDuEse4zXUEJUGj8ouLZEPKB g5fEXmpPt3ZtCcNx9FYjpjadX/z4yl0zKnCmz05r28Pc6dfhF1sFstcpH10Jfde6 VQ9w0EC6M7xmKxZnV/mgrlB7dKleklsp+Kw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357463; x=1677443863; bh=DLRFynjeQ7h4I qriku9OW2YC9py/QqyZn5HhylUDGk4=; b=I7VtMLO6MqopveuFt8AQ6r462eTti qCQMelgBYgJRgGNjKIt8+bN1rqGzJkp7P6jjo8yAxjqgePrbcx4reXyXDm+y9ZdN 7hA74nd2wJEFNNZnF6bQkABMUlgCTBGTJt3ia6qPViccwIKTqXwb1lHy//ihga8N 5Xbi/JHhu8PsYcrg4kctcheknQup7bXhDXoF2ptUWnvJaMZafPbAsfeOmUcxP+K1 WdED7UlylDimE8wtLF78BUwob+sES9wrEMwA6Q1FDec1cvbWrIt+ONrbjNsLc/Mg UsujPeQitaoku4K7mBfmUZ1fvm07CRd01KGdMKTXXSgZ1Fahnjw+gzzgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdeutddvfedtgeejfeehjefffedv tddvkefhgefgueegjefhveevueegtdfhkeehnecuffhomhgrihhnpeigvghnphhrohhjvg gtthdrohhrghdpgigvnhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrd gtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS Date: Sat, 25 Feb 2023 15:37:12 -0500 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Also fix an old xenbits.xenproject.org link. Signed-off-by: Demi Marie Obenour --- Config.mk | 2 +- tools/misc/mkrpm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Config.mk b/Config.mk index 75f1975e5e78af44d36c2372cba6e89b425267a5..b2bef45b059976d5a6320eabada6073004eb22ee 100644 --- a/Config.mk +++ b/Config.mk @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles # All the files at that location were downloaded from elsewhere on # the internet. The original download URL is preserved as a comment # near the place in the Xen Makefiles where the file is used. diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm index 68819b2d739cea5491b53f9b944ee2bd20d92c2b..548db4b5da2691547438df5d7d58e5b4c3bd90d0 100644 --- a/tools/misc/mkrpm +++ b/tools/misc/mkrpm @@ -34,7 +34,7 @@ Version: $version Release: $release License: GPL Group: System/Hypervisor -URL: http://xenbits.xenproject.org/xen.git +URL: https://xenbits.xen.org/git-http/xen.git BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root %define _binary_payload w1.gzdio -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:37:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:37:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501871.773691 (Exim 4.92) (envelope-from ) id 1pW1Ik-00082W-V1; Sat, 25 Feb 2023 20:37:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501871.773691; Sat, 25 Feb 2023 20:37:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ik-00081i-Pj; Sat, 25 Feb 2023 20:37:50 +0000 Received: by outflank-mailman (input) for mailman id 501871; Sat, 25 Feb 2023 20:37:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Ij-0007PG-Lf for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:37:49 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43e179d2-b54c-11ed-88bb-e56d68cac8db; Sat, 25 Feb 2023 21:37:49 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 1C2263200201; Sat, 25 Feb 2023 15:37:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 25 Feb 2023 15:37:47 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:46 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43e179d2-b54c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357466; x=1677443866; bh=FZjY6VSlLEVa0awh+ywsTVIuCBsoJnJElTE 5z586qAs=; b=gqVpRUc6sxtBQeu4DDxHSq2nLLyhQth028RTnrTm0Ql0aul1hHs KnwVzThu9LAB4GuMtjVHP3W5wYM2BXOu6uyoCHRp59g8Wm58QF7Ln8/VPKq0w272 HLTun8Z7+ffm6MBr5G4WIp6liOBkhwfHO1PGSdsr7MFKctYm4ZV+WkPYrLWcYW30 rmd4FFGTU5qXmDUYwl8y7atl/NKZhhQ0vJLQxXLKFEpUzeK0PaEJXSWO6d2ZvJVn QHOnPEoZ1bsGDW01T4vRFXBPCJrzgTLw2geu59GxTysaaCs2cFY5zn6cBGPOsfOB L2lQ4J797EYA52cTCUi4kxG/pztMxzvLIgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357466; x=1677443866; bh=FZjY6VSlLEVa0 awh+ywsTVIuCBsoJnJElTE5z586qAs=; b=IQNhbDoNb8lCii53GsOYZjWCAo7tP ylT3BrAYO7ilfm76HeQP0S5quLj0inbjMHDwPN8yaKbh91+xrWBx1Z9NcYeTFTGl QMMKK9ytqp8MK6H7Je+m99l3j0xGmETyP/F7z9f0WgWJ/VDi3VhWW8AkeejlwlY7 UFDP5zdA/KDE1G8F2jeaJAxh0KVBO25HJFElcfmhpRCveLAKK0EZuzLilCUJJgJn roYYS1qaYySfVv4FTDm0iPRJoOQW6fSc3c3+h5BnRy9vBXxblVZUc7uqZqM8mBZO QiJkAA5nGqJQKDyLBEk0nMvd2syhHWiDcQATv2nHMH582RHHdqzgbp8Mg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepheehgefghfdvieduuddthefhhfeu gffhjedtgedvhfetheehgeduieegjeekfeetnecuffhomhgrihhnpeiilhhisgdrnhgvth dpphholhgrrhhsshhlrdhorhhgpdgsvghrlhhiohhsrdguvgdpkhgvrhhnvghlrdhorhhg pdhrvgguhhgrthdrtghomhdpghhnuhdrohhrghdpihhnrhhirgdrfhhrpdhgmhhplhhisg drohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm peguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Samuel Thibault , Wei Liu , Anthony PERARD Subject: [PATCH v5 3/5] Build system: Do not try to use broken links Date: Sat, 25 Feb 2023 15:37:13 -0500 Message-Id: <8122a5118079b87904724d61859880cc3672be06.1677356813.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The upstream URLs for zlib, PolarSSL, and the TPM emulator do not work anymore, so do not attempt to use them. Signed-off-by: Demi Marie Obenour --- m4/stubdom.m4 | 5 +++-- stubdom/configure | 21 +++------------------ stubdom/configure.ac | 6 +++--- 3 files changed, 9 insertions(+), 23 deletions(-) diff --git a/m4/stubdom.m4 b/m4/stubdom.m4 index 6aa488b8e229dabbe107cfe115b5f2ac7e5ae824..26f10595d1c1250b1dc8a5be626142325e8d4673 100644 --- a/m4/stubdom.m4 +++ b/m4/stubdom.m4 @@ -78,10 +78,11 @@ done AC_DEFUN([AX_STUBDOM_LIB], [ AC_ARG_VAR([$1_URL], [Download url for $2]) AS_IF([test "x$$1_URL" = "x"], [ - AS_IF([test "x$extfiles" = "xy"], + m4_if([$#],[3],[$1_URL=\@S|@\@{:@XEN_EXTFILES_URL\@:}@], + [$#],[4],[AS_IF([test "x$extfiles" = "xy"], [$1_URL=\@S|@\@{:@XEN_EXTFILES_URL\@:}@], [$1_URL="$4"]) - ]) +],[m4_fatal([AX_STUBDOM_LIB expects 3 or 4 arguments, not $#])])]) $1_VERSION="$3" AC_SUBST($1_URL) AC_SUBST($1_VERSION) diff --git a/stubdom/configure b/stubdom/configure index b8bffceafdd46181e26a79b85405aefb8bc3ff7d..4ea95baa9192f3b319349ac2a14a3055a21ce705 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3532,12 +3532,7 @@ fi if test "x$ZLIB_URL" = "x"; then : - if test "x$extfiles" = "xy"; then : - ZLIB_URL=\$\(XEN_EXTFILES_URL\) -else - ZLIB_URL="http://www.zlib.net" -fi - + ZLIB_URL=\$\(XEN_EXTFILES_URL\) fi ZLIB_VERSION="1.2.3" @@ -3633,12 +3628,7 @@ GMP_VERSION="4.3.2" if test "x$POLARSSL_URL" = "x"; then : - if test "x$extfiles" = "xy"; then : - POLARSSL_URL=\$\(XEN_EXTFILES_URL\) -else - POLARSSL_URL="http://polarssl.org/code/releases" -fi - + POLARSSL_URL=\$\(XEN_EXTFILES_URL\) fi POLARSSL_VERSION="1.1.4" @@ -3648,12 +3638,7 @@ POLARSSL_VERSION="1.1.4" if test "x$TPMEMU_URL" = "x"; then : - if test "x$extfiles" = "xy"; then : - TPMEMU_URL=\$\(XEN_EXTFILES_URL\) -else - TPMEMU_URL="http://download.berlios.de/tpm-emulator" -fi - + TPMEMU_URL=\$\(XEN_EXTFILES_URL\) fi TPMEMU_VERSION="0.7.4" diff --git a/stubdom/configure.ac b/stubdom/configure.ac index e20d99edac0da88098f4806333edde9f31dbc1a7..c648b1602c227ed5fe63b9fbdf3fa52fd2e1654b 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -55,15 +55,15 @@ AC_PROG_INSTALL AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup -AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3], [http://www.zlib.net]) +AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3]) AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) -AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4], [http://polarssl.org/code/releases]) -AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4], [http://download.berlios.de/tpm-emulator]) +AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4]) +AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4]) #These stubdoms should be enabled if the dependent one is AX_STUBDOM_AUTO_DEPENDS([vtpmmgr], [vtpm]) -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:37:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:37:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501874.773706 (Exim 4.92) (envelope-from ) id 1pW1Is-0000LY-6r; Sat, 25 Feb 2023 20:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501874.773706; Sat, 25 Feb 2023 20:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Is-0000LP-3a; Sat, 25 Feb 2023 20:37:58 +0000 Received: by outflank-mailman (input) for mailman id 501874; Sat, 25 Feb 2023 20:37:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Iq-0007yc-Ov for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:37:56 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4778e5b4-b54c-11ed-a82a-c9ca1d2f71af; Sat, 25 Feb 2023 21:37:55 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1F2353200201; Sat, 25 Feb 2023 15:37:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 25 Feb 2023 15:37:53 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:52 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4778e5b4-b54c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357472; x=1677443872; bh=eE9rMkFJ8SK3XCHPmE4xntol477kdYevv8F tOH7Fe3I=; b=lyoz5gWVWeiiUc9rXtuLY6HQZk+S71tzEU5vht4aAPID/MtcUjh ni2VxOvFbRVXFE13LTvx7BF8M3DpvI+aPJs17J0yZu3JcInyKUgf/V5WMnrJOOJb ljMxH66EqTZtD9o6GDyr9fQRdspuh2b/tz7SaUeJUHgkClYETBCtIvj7Fqvu/Cbc F9XYESLX9cppZWSb34IHJqy1Tq0JmFkIlrX4q7yZXthZtfKODOljpRDcfZ+SCHzO lphOtzVYaS+Hpbzp2x+jL9g01kAtdbsnjjtpFwaYPmkMJNXpgQ0kqAw5lM3qZxUo xLDgx8qXDlkQs1Ur4I2Cr6J/mtqSsumAIDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357472; x=1677443872; bh=eE9rMkFJ8SK3X CHPmE4xntol477kdYevv8FtOH7Fe3I=; b=a5d9p7LzmKi+Oo2B82T/0f6CIyjC5 Lt08s1uRrJjJTbF/qoE/MKcIHiCoL8tcAwwpPfQcceLzUj8a+OzoaQaJdLUuWJ3B jLQ2lSgqAseUDQlCeFg8cd0gQOzaGLZMKeWXOdj5I7ZbgGI7Lbx8ntkss6XYSLHP esAPLQZifeLXlLvRe+HY6e/CxqpQQ3jzmd2EnJrELeTDM8xR/Isxr0KypiSQKQzC 2+0HVNiB3905fg+oDf4DIP3hkSPPBZjIwWbAKSEVihmIaHSgn/jLLrINZFNGJD1a Km4W/rzrw8Xoj6CvarMxdtP3aAF9sYIrwbc+xh5a2k0TAMp+CvJrw9z0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepuedtueeutedtfefgkedtueefteeu ffdvuedtudekkedvhffgfffhheefgeeutdejnecuffhomhgrihhnpehkvghrnhgvlhdroh hrghdprhgvughhrghtrdgtohhmpdhsohhurhgtvgifrghrvgdrohhrghdpghhnuhdrohhr ghdpihhnrhhirgdrfhhrpdhgmhhplhhisgdrohhrghdpihhpgigvrdhorhhgpdhgihhthh husgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Samuel Thibault , Wei Liu , Anthony PERARD Subject: [PATCH v5 4/5] Build system: Replace git:// and http:// with https:// Date: Sat, 25 Feb 2023 15:37:14 -0500 Message-Id: <85a65c8c5cbd7cab3b9eb57aed27a59443c7a6ff.1677356813.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in the build system. Some URLs returned 301 or 302 redirects, so I replaced them with the URLs that were redirected to. Signed-off-by: Demi Marie Obenour --- stubdom/configure | 12 ++++++------ stubdom/configure.ac | 12 ++++++------ tools/firmware/etherboot/Makefile | 6 +----- 3 files changed, 13 insertions(+), 17 deletions(-) diff --git a/stubdom/configure b/stubdom/configure index 4ea95baa9192f3b319349ac2a14a3055a21ce705..540e9cd331888449b0e24c1aa974bc22c5bcab54 100755 --- a/stubdom/configure +++ b/stubdom/configure @@ -3545,7 +3545,7 @@ if test "x$LIBPCI_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LIBPCI_URL=\$\(XEN_EXTFILES_URL\) else - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" + LIBPCI_URL="https://mirrors.edge.kernel.org/pub/software/utils/pciutils" fi fi @@ -3560,7 +3560,7 @@ if test "x$NEWLIB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : NEWLIB_URL=\$\(XEN_EXTFILES_URL\) else - NEWLIB_URL="ftp://sources.redhat.com/pub/newlib" + NEWLIB_URL="https://sourceware.org/ftp/newlib" fi fi @@ -3575,7 +3575,7 @@ if test "x$LWIP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : LWIP_URL=\$\(XEN_EXTFILES_URL\) else - LWIP_URL="http://download.savannah.gnu.org/releases/lwip" + LWIP_URL="https://download.savannah.gnu.org/releases/lwip" fi fi @@ -3590,7 +3590,7 @@ if test "x$GRUB_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GRUB_URL=\$\(XEN_EXTFILES_URL\) else - GRUB_URL="http://alpha.gnu.org/gnu/grub" + GRUB_URL="https://alpha.gnu.org/gnu/grub" fi fi @@ -3602,7 +3602,7 @@ GRUB_VERSION="0.97" if test "x$OCAML_URL" = "x"; then : - OCAML_URL="http://caml.inria.fr/pub/distrib/ocaml-4.02" + OCAML_URL="https://caml.inria.fr/pub/distrib/ocaml-4.02" fi OCAML_VERSION="4.02.0" @@ -3616,7 +3616,7 @@ if test "x$GMP_URL" = "x"; then : if test "x$extfiles" = "xy"; then : GMP_URL=\$\(XEN_EXTFILES_URL\) else - GMP_URL="ftp://ftp.gmplib.org/pub/gmp-4.3.2" + GMP_URL="https://gmplib.org/download/gmp/archive" fi fi diff --git a/stubdom/configure.ac b/stubdom/configure.ac index c648b1602c227ed5fe63b9fbdf3fa52fd2e1654b..471e371e14a82aedc10314c95bcaf39ce9f89f90 100644 --- a/stubdom/configure.ac +++ b/stubdom/configure.ac @@ -56,12 +56,12 @@ AX_DEPENDS_PATH_PROG([vtpm], [CMAKE], [cmake]) # Stubdom libraries version and url setup AX_STUBDOM_LIB([ZLIB], [zlib], [1.2.3]) -AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [http://www.kernel.org/pub/software/utils/pciutils]) -AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [ftp://sources.redhat.com/pub/newlib]) -AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [http://download.savannah.gnu.org/releases/lwip]) -AX_STUBDOM_LIB([GRUB], [grub], [0.97], [http://alpha.gnu.org/gnu/grub]) -AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [http://caml.inria.fr/pub/distrib/ocaml-4.02]) -AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [ftp://ftp.gmplib.org/pub/gmp-4.3.2]) +AX_STUBDOM_LIB([LIBPCI], [libpci], [2.2.9], [https://mirrors.edge.kernel.org/pub/software/utils/pciutils]) +AX_STUBDOM_LIB([NEWLIB], [newlib], [1.16.0], [https://sourceware.org/ftp/newlib]) +AX_STUBDOM_LIB([LWIP], [lwip], [1.3.0], [https://download.savannah.gnu.org/releases/lwip]) +AX_STUBDOM_LIB([GRUB], [grub], [0.97], [https://alpha.gnu.org/gnu/grub]) +AX_STUBDOM_LIB_NOEXT([OCAML], [ocaml], [4.02.0], [https://caml.inria.fr/pub/distrib/ocaml-4.02]) +AX_STUBDOM_LIB([GMP], [libgmp], [4.3.2], [https://gmplib.org/download/gmp/archive]) AX_STUBDOM_LIB([POLARSSL], [polarssl], [1.1.4]) AX_STUBDOM_LIB([TPMEMU], [berlios tpm emulator], [0.7.4]) diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile index 4bc3633ba3d67ff9f52a9cb7923afea73c861da9..6ab9e5bc6b4cc750f2e802128fbc71e9150397b1 100644 --- a/tools/firmware/etherboot/Makefile +++ b/tools/firmware/etherboot/Makefile @@ -4,11 +4,7 @@ XEN_ROOT = $(CURDIR)/../../.. include $(XEN_ROOT)/tools/Rules.mk include Config -ifeq ($(GIT_HTTP),y) -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git -else -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git -endif +IPXE_GIT_URL ?= https://github.com/ipxe/ipxe.git # put an updated tar.gz on xenbits after changes to this variable IPXE_GIT_TAG := 3c040ad387099483102708bb1839110bc788cefb -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 20:38:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 20:38:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501880.773717 (Exim 4.92) (envelope-from ) id 1pW1Iw-0000nL-Jh; Sat, 25 Feb 2023 20:38:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501880.773717; Sat, 25 Feb 2023 20:38:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Iw-0000nA-Fw; Sat, 25 Feb 2023 20:38:02 +0000 Received: by outflank-mailman (input) for mailman id 501880; Sat, 25 Feb 2023 20:38:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW1Iv-0007yc-Kw for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 20:38:01 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a402e81-b54c-11ed-a82a-c9ca1d2f71af; Sat, 25 Feb 2023 21:37:59 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 806CA320027A; Sat, 25 Feb 2023 15:37:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 25 Feb 2023 15:37:58 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 15:37:56 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a402e81-b54c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677357477; x=1677443877; bh=aeHQ0E9NgzibaZKiBNAkgq+kKk4grLArxug vf6LHwOg=; b=D6N1DVw74iEbjkNOvY2tQon8e7KjPb/cJNu/aVwlZ75ZCzkiLW0 2+94ASDCQZSRTD5JQcUX7H5YouCHLbFdqwct3iLrFezVQxcJSx1htoSFTadmszec KLU/gwAV3M0KZOa8QwuB6WEeplmPzpLUJ9/Sa+EZTv7bJ6RgjsR456KaB9wGTb+j hvWbcewzbLcwxs8K5F6JAwkXNPXhDmsI+jJkj243AjQ2x4/wHYRDUTK8KlviwJZB kW1z5mevFOuJSomWpXudNqjrl+oxNhJvvK/62jpchQRKKDPlUF4fgTq0eaY7zqVL Mjna/9HruhbeoyJ9rPmgRN4sgw2U0vtLLmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677357477; x=1677443877; bh=aeHQ0E9Ngziba ZKiBNAkgq+kKk4grLArxugvf6LHwOg=; b=m0jDBj19PfIQ6V2R7GErPlwkEJzi8 dpTq9O4poS7zCXRu9SFMWC5Fc2KrvID8OhrSMIB+7Z0nmQFgJuV1LHZzWkMr6Efv MJUY1LZhMYKOkHsmuelUSPeY2Yq4lAgGZHXwbjUHvkzV9BgD+UIqrb9KMvWe1/O7 4B9pzA+CvnCWzkjIOPUygFkqRuPfWTNmsTPbehNlkl4z7bQKywA8YYQtKRi835Mf NpidjeSZDhiIpecFBTpTTo+w3EyOmvcGacNMqzqq+wJilmRqEntQd614QTs0ksM6 FU5oppYRWjRSd68lKtpAvRN2SbORB3KTdAyFTe3nz035OAmSz76ayoJdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepteffheeiudduhefhffeigfegiedv leehhfdtvdduhffhudelkeefvdduueejkeevnecuffhomhgrihhnpehphihthhhonhdroh hrghdpihhnthgvlhdrtghomhdplhhlvhhmrdhorhhgpdguvggsihgrnhdrohhrghdprghl phhinhgvlhhinhhugidrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgt ohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: xen-devel@lists.xenproject.org Cc: Demi Marie Obenour , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein Subject: [PATCH v5 5/5] Automation and CI: Replace git:// and http:// with https:// Date: Sat, 25 Feb 2023 15:37:15 -0500 Message-Id: <8ca85b30b903512fc07e95cf4e07ea4b0623ba99.1677356813.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Obtaining code over an insecure transport is a terrible idea for blatently obvious reasons. Even for non-executable data, insecure transports are considered deprecated. This patch enforces the use of secure transports in automation and CI. All URLs are known to work. Signed-off-by: Demi Marie Obenour --- README | 4 ++-- automation/build/debian/stretch-llvm-8.list | 4 ++-- automation/scripts/qemu-smoke-dom0-arm32.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README b/README index 755b3d8eaf8f7a58a945b7594e68a3fe455a7bdf..f8cc426f78d690f37e013242e81d4e440556c330 100644 --- a/README +++ b/README @@ -181,7 +181,7 @@ Python Runtime Libraries Various tools, such as pygrub, have the following runtime dependencies: * Python 2.6 or later. - URL: http://www.python.org/ + URL: https://www.python.org/ Debian: python Note that the build system expects `python` to be available. If your system @@ -197,7 +197,7 @@ Intel(R) Trusted Execution Technology Support Intel's technology for safer computing, Intel(R) Trusted Execution Technology (Intel(R) TXT), defines platform-level enhancements that provide the building blocks for creating trusted platforms. For more information, see -http://www.intel.com/technology/security/. +https://www.intel.com/technology/security/. Intel(R) TXT support is provided by the Trusted Boot (tboot) module in conjunction with minimal logic in the Xen hypervisor. diff --git a/automation/build/debian/stretch-llvm-8.list b/automation/build/debian/stretch-llvm-8.list index 09fe843fb2a31ae38f752d7c8c71cf97f5b14513..590001ca81e826ab624ba9185423adf4b0c51a21 100644 --- a/automation/build/debian/stretch-llvm-8.list +++ b/automation/build/debian/stretch-llvm-8.list @@ -1,3 +1,3 @@ # Strech LLVM 8 repos -deb http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main -deb-src http://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main +deb-src https://apt.llvm.org/stretch/ llvm-toolchain-stretch-8 main diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 98e4d481f65c2b29ac935ddf6247132ddf94fa1d..950ad3a0daa63d66fc8647c0a390ff59c2f22b1a 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -4,7 +4,7 @@ set -ex cd binaries # Use the kernel from Debian -curl --fail --silent --show-error --location --output vmlinuz http://http.us.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz +curl --fail --silent --show-error --location --output vmlinuz https://ftp.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz # Use a tiny initrd based on busybox from Alpine Linux curl --fail --silent --show-error --location --output initrd.tar.gz https://dl-cdn.alpinelinux.org/alpine/v3.15/releases/armhf/alpine-minirootfs-3.15.1-armhf.tar.gz -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Feb 25 22:15:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 22:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501911.773727 (Exim 4.92) (envelope-from ) id 1pW2pQ-0007Kr-Kt; Sat, 25 Feb 2023 22:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501911.773727; Sat, 25 Feb 2023 22:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW2pQ-0007Kk-HF; Sat, 25 Feb 2023 22:15:40 +0000 Received: by outflank-mailman (input) for mailman id 501911; Sat, 25 Feb 2023 22:15:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW2pP-0007Ka-2x; Sat, 25 Feb 2023 22:15:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW2pO-0003XM-W1; Sat, 25 Feb 2023 22:15:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW2pO-0004Wi-Hv; Sat, 25 Feb 2023 22:15:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pW2pO-0003Br-HU; Sat, 25 Feb 2023 22:15:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2Do3/NnuwxCGG98A+f71j9fm3mL5M1VfsO3tznCguc0=; b=ZUZW3pbtk1btG4fnN0ckt+cutm xlffQ0v+xkwsHpbPi4r3uGCgjSPlRih2EUbnLxN6ivNJGsxlryBFNYKBItoA78bn4AXy1vdx442if Xg8OdFXmWLLAnPX7xrDBReg+v6KahusvtQZnMgwK7lTruC60NUv2by++NcNvB3ymM3Cg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 178448: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-libvirt-vhd:leak-check/check:fail:heisenbug xen-4.16-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:build-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-4.16-testing:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=0802504627453a54b1ab408b6e9dc8b5c561172d X-Osstest-Versions-That: xen=d4e286db89d80c862b4a24bf971dd71008c8b53e From: osstest service owner Date: Sat, 25 Feb 2023 22:15:38 +0000 flight 178448 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/178448/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 22 leak-check/check fail in 178378 pass in 178448 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 178378 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail blocked in 177405 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 177405 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 177405 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 177405 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 177405 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 0802504627453a54b1ab408b6e9dc8b5c561172d baseline version: xen d4e286db89d80c862b4a24bf971dd71008c8b53e Last test of basis 177405 2023-02-15 16:37:16 Z 10 days Testing same since 178138 2023-02-22 14:37:31 Z 3 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d4e286db89..0802504627 0802504627453a54b1ab408b6e9dc8b5c561172d -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Sat Feb 25 22:34:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 22:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501918.773741 (Exim 4.92) (envelope-from ) id 1pW37v-00028S-9S; Sat, 25 Feb 2023 22:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501918.773741; Sat, 25 Feb 2023 22:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW37v-00028L-6f; Sat, 25 Feb 2023 22:34:47 +0000 Received: by outflank-mailman (input) for mailman id 501918; Sat, 25 Feb 2023 22:34:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW37t-00028F-Vp for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 22:34:46 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97797c50-b55c-11ed-a82a-c9ca1d2f71af; Sat, 25 Feb 2023 23:34:41 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2FB7C3200406; Sat, 25 Feb 2023 17:34:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 25 Feb 2023 17:34:39 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 17:34:35 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97797c50-b55c-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677364477; x= 1677450877; bh=7v+mVSaUogTR4LaZGmtUp+PNoO6ejkwg7ygkfKv6bnE=; b=a 3OOPAxRl2gjqieXppUJAwHroj6xt7gtxuWm9qbiYuV3gmECpKvTNBg2Eqo+Lk37K Yof+ATraPyi2YN84W7pj/QN26B1I4xAVyqm0QmJSn+6fDFi/VSPmf9s2gInqNQ18 s0PnCLO80Q6uHwD2GpP1s8SKX/oHlwuuMDpwp1NeDAHonynRSe8NCcAqEkVF6WYH LLxfTa/LHGxYeADWTr+KsGGLheMVndSPep5NrVT14nFQ7U8fVWhh3g8BO+MmjQOC mRGsjbsk/PERWtBQyG+hF6KgmWxwiIvxsh7vMzejOdq8SO5zy19mdBZT4qe0t5DO 1ySPsRiy35lItQVQ7bZAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677364477; x=1677450877; bh=7v+mVSaUogTR4LaZGmtUp+PNoO6e jkwg7ygkfKv6bnE=; b=NH3D/Fk1U1oYG903zMkFkKrj7Jlu92PcqrU3g9nu6HnV Is2AieaBFsjMYU/U5uSExe4ReeyEu6rXr2dImdgP6HVfKGZzXXzKrJEWMc/QhG5Z 8bTx863UM1fQUkOzw0XSjTwJuvUYS5z/bsY2zeGnB+ifYDXYa1TZZxW27gqccUlP eOLZG6y1p9koYjD6E3l4mM5941/sJEO6r3e8TP0Fn+Z9OX1VVdusFbndz4gL6yIZ OhtIoLm6B/aWdrzgVmwmk3j2I6yJAmOwJTWuqaalrcHDkXM+YsrN9FGIW+DQ/6Kw JIAizmqQ3Q90/x9U40lVgQYib3uG2jLmGEMLGo9HLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekiedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedu ueejvedvkefghffhhfelvdeileelteekgfetvedvteehhfdtvdfftefhudevhfenucffoh hmrghinhepgigvnhdrohhrghdpghhithhlrggsrdgtohhmnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sat, 25 Feb 2023 23:34:32 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour , Anthony PERARD Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH v5 1/5] Use HTTPS for all xenbits.xen.org Git repos Message-ID: References: <9cb98cb9aaca22bbc88de9fd8cbd7f9463b4d425.1677356813.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OQEc90r8F6o86KWP" Content-Disposition: inline In-Reply-To: <9cb98cb9aaca22bbc88de9fd8cbd7f9463b4d425.1677356813.git.demi@invisiblethingslab.com> --OQEc90r8F6o86KWP Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sat, 25 Feb 2023 23:34:32 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Demi Marie Obenour , Anthony PERARD Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH v5 1/5] Use HTTPS for all xenbits.xen.org Git repos On Sat, Feb 25, 2023 at 03:37:11PM -0500, Demi Marie Obenour wrote: > Obtaining code over an insecure transport is a terrible idea for > blatently obvious reasons. Even for non-executable data, insecure > transports are considered deprecated. >=20 > This patch enforces the use of secure transports for all xenbits.xen.org > Git repositories. It was generated with the following shell script: >=20 > git ls-files -z | > xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xe= n\.org/git-http)/@https://xenbits.xen.org/git-http/@g' >=20 > All altered links have been tested and are known to work. >=20 > Signed-off-by: Demi Marie Obenour It seems expired Lets Encrypt root issue applies to few other containers too: - archlinux:current: https://gitlab.com/xen-project/patchew/xen/-/jobs/3834= 739751 - debian:stretch-i386: https://gitlab.com/xen-project/patchew/xen/-/jobs/38= 34739762 - debian:unstable-i386: https://gitlab.com/xen-project/patchew/xen/-/jobs/3= 834739771 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --OQEc90r8F6o86KWP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmP6jPgACgkQ24/THMrX 1yy3awf/R8jwooCP+vntktqjuEURX8e/N5uGXYyl7nd6QmB4+0ggMM51GLL0zU7c +jeewAxiYrwlh8/yq6vYC/jKOALAHOLePwAoKQmF/vGZFjYzzmGWrVYpwCY/S/Cn vbMdvRimxYh7rdk19WiDptqGt5uq6d8pQL2bT7aLXTjS/7R6/7qhzL6y6x/GVvfL gz3qHJ2IElqFRuG8CR2FDXn17YMmI7VRqgo76NC74VUciEjAkoaYSjxVtjacbZRY 3XN6au3oije9lvFYYvyYwMegoQzDZctsO8WpN4HuDdOa1Tsut82R07yIUeyZNh6y s55wRmogUyPIW1wYovtXKtF0cGLp/Q== =uewn -----END PGP SIGNATURE----- --OQEc90r8F6o86KWP-- From xen-devel-bounces@lists.xenproject.org Sat Feb 25 23:57:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 25 Feb 2023 23:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501932.773750 (Exim 4.92) (envelope-from ) id 1pW4Pf-0004xu-5x; Sat, 25 Feb 2023 23:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501932.773750; Sat, 25 Feb 2023 23:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW4Pf-0004xn-3V; Sat, 25 Feb 2023 23:57:11 +0000 Received: by outflank-mailman (input) for mailman id 501932; Sat, 25 Feb 2023 23:57:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW4Pd-0004xh-NT for xen-devel@lists.xenproject.org; Sat, 25 Feb 2023 23:57:10 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17cb61ed-b568-11ed-a82a-c9ca1d2f71af; Sun, 26 Feb 2023 00:57:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2D1EF320039A; Sat, 25 Feb 2023 18:56:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 25 Feb 2023 18:56:58 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 18:56:56 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17cb61ed-b568-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677369417; x=1677455817; bh=ATk4fq3+AQja6Jtyo3H0DPDhoSBSuRwkbdu GLRWnAag=; b=d3UCh+lW6n5iy2p8C1E0XF6Ivb5EuXbguz04KaLVMZ4262/n1Om B+MZDp3M3ZZwI9RFRMFJqQTnHqBP2vAUCqeE2SsapyOaEMdTuanRYtpsqrO1Fnnn 6Um0uw9r9/PMq0Ml05w3+f2LpfOSrjkklIrcIVVc6lrj1nQeyOlex5TPiqr32bUE Lo8jEcvpOErG++BTdcMWeXkWWZCJhTJGMCy4sdfI6fCZaxKiyfwbkM6uRkvdDEnx 7C/f/GdQJaCohCPvcq3J21T2ILX1H7nzGlQ07FNhFfWnQc99CSU+1ZSYfQByptzg VgO9VNVfX5FenavSXpS2bpTIECdA8rlzafA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677369417; x=1677455817; bh=ATk4fq3+AQja6 Jtyo3H0DPDhoSBSuRwkbduGLRWnAag=; b=a2r3aEdO7stg01910B0jJGdbKkhJ3 I5TW4nhCZ8VyxGsmQ92i/Oo2SjjGj2nLXlwMb/eUVL4iJF8YBAanv+fUCks1AeBQ tLr8wVKzftPkIwluERUBoRjI+L1tQ63JM74G/1dt5YVoWgAKLpgAiDw7cjIcdjdr m4rlW36BbclRrM5IlwlrWtnBOC4loK9vq6WJqRN+ipeVl2xH3tlvex2r2Ne7H4TE 8kiQu20TIk4TFsveJXnluSMOqJAsvTZgvdciFvkUKxirKf76oRRwH9uM4wC/Zn9o am0NF3LPDhoN6ckU/irZ3qJxnDyqk9fOaDDxRr7KoGdEKlxRQM/kSK3Xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekjedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveet ffehjedtkefggfdvfeeihfdvffdtueejgfeliefgffekffehfeffhfefheenucffohhmrg hinheplhgushdrshgsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] Drop ELF notes from non-EFI binary too Date: Sun, 26 Feb 2023 00:56:42 +0100 Message-Id: <20230225235642.38880-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The ELF is repacked from from 64bit to 32bit. With CET-related notes, which use 64bit fields, this results in 32bit binary with corrupted notes. Drop them all (except build-id and PVH note retained explicitly). Suggested-by: Jan Beulich Signed-off-by: Marek Marczykowski-Górecki --- xen/arch/x86/xen.lds.S | 7 ------- 1 file changed, 7 deletions(-) diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 8930e14fc40e..f0831bd677e7 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -192,13 +192,6 @@ SECTIONS #endif #endif -#ifndef EFI - /* Retain these just for the purpose of possible analysis tools. */ - DECL_SECTION(.note) { - *(.note.*) - } PHDR(note) PHDR(text) -#endif - _erodata = .; . = ALIGN(SECTION_ALIGN); -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Sun Feb 26 00:08:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 00:08:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501938.773760 (Exim 4.92) (envelope-from ) id 1pW4au-0007UN-AQ; Sun, 26 Feb 2023 00:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501938.773760; Sun, 26 Feb 2023 00:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW4au-0007UG-7j; Sun, 26 Feb 2023 00:08:48 +0000 Received: by outflank-mailman (input) for mailman id 501938; Sun, 26 Feb 2023 00:08:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW4as-0007UA-E7 for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 00:08:46 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id baba950a-b569-11ed-a82a-c9ca1d2f71af; Sun, 26 Feb 2023 01:08:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4C2A532007F9; Sat, 25 Feb 2023 19:08:41 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 25 Feb 2023 19:08:41 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Feb 2023 19:08:39 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: baba950a-b569-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1677370120; x=1677456520; bh=LWTRQZlIxQllNCp/p4NuqNsedjPsD/Uso/p VE7vaMqQ=; b=UJjo87DVRtIO45jiBoR0AwpnvHHVJdSBecyhZtCWWALbnydgCrZ 9bTkWP66AgxPnoFmlTcyE4uuriPULiWjO5ZBO+wfsaQlT1RRzt+26Mw67U1r/sBR 2vl7VEerihyHYxcL0XS+80OMFZJu141SEcMcVznj1uk/kw+Ok/eexcS6Xv+AQr+H 1yx3YjYGhRGXkKW5/krRPG4rsup6SNRA1HpK4CeNL8ilklzp5/jZah2fLDvwlkx+ NqJf7jJwrY1/1G/jJ1MX7i8KLVqlB87X/EjsDvDJE8xwLIR0WpdAEWvBSJj4K7HI JBlQn7kV+KoKWdBElD6M4F59Kjsauh/Wf2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677370120; x=1677456520; bh=LWTRQZlIxQllN Cp/p4NuqNsedjPsD/Uso/pVE7vaMqQ=; b=UCmM6XUihAzzUHEvPzo+594F9kmdK WR+kPNkq6EditAlYglAHk75PnOAl+o2bRkP/Xcv024wmgqwdS/cFFsXVP+yX4ap6 uhhoPfu5hzlyZeD16Zfm9cyENd8Mf/GjhlpboB/OisSSAWSe7N62VgBxxGdycQN2 jQVIJcfj0p1UeR4fxBPQdfN0+xXbb2pyJ+V+1Y5MB+cMPdxfecV+WjiW5UrxiqjG HYQERYm7+hnjhOzXOwq3kwuEqLroIZBcds3wC6UEGRJ8dw6Luc38UYEdp35VorkQ rZwoSDeuz8ILGshDWYCwrqMpseYY/lT2gIAbenCfvnxgFQ9LWbS8h8L9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekjedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelkefh udelteelleelteetveeffeetffekteetjeehlefggeekleeghefhtdehvdenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device Date: Sun, 26 Feb 2023 01:08:22 +0100 Message-Id: <20230226000822.42384-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the scope for IGD's IOMMU contains additional device that doesn't actually exist, iommu=no-igfx would not disable that IOMMU. In this particular case (Thinkpad x230) it included 00:02.1, but there is no such device on this platform. Consider only existing devices for "gfx only" check. Signed-off-by: Marek Marczykowski-Górecki --- I have looked at existence check acpi_parse_one_drhd(), but re-using that one wouldn't work for two reasons: - gfx_only logic is very much tied to acpi_parse_dev_scope() - pci_device_detect() in acpi_parse_one_drhd() is skipped in case of (implicit or explicit) iommu=force --- xen/drivers/passthrough/vtd/dmar.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 78c8bad1515a..3b5e152901b9 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -396,6 +396,7 @@ static int __init acpi_parse_dev_scope( igd_drhd_address = drhd->address; if ( gfx_only && + pci_device_detect(seg, bus, path->dev, path->fn) && pci_conf_read8(PCI_SBDF(seg, bus, path->dev, path->fn), PCI_CLASS_DEVICE + 1) != 0x03 /* PCI_BASE_CLASS_DISPLAY */ ) -- 2.39.2 From xen-devel-bounces@lists.xenproject.org Sun Feb 26 04:50:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 04:50:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501946.773771 (Exim 4.92) (envelope-from ) id 1pW8zb-000392-Mb; Sun, 26 Feb 2023 04:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501946.773771; Sun, 26 Feb 2023 04:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW8zb-00038u-Gv; Sun, 26 Feb 2023 04:50:35 +0000 Received: by outflank-mailman (input) for mailman id 501946; Sun, 26 Feb 2023 04:50:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW8za-00038k-9g; Sun, 26 Feb 2023 04:50:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW8za-0003fG-5Q; Sun, 26 Feb 2023 04:50:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pW8zZ-0008RW-RN; Sun, 26 Feb 2023 04:50:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pW8zZ-0005nQ-Qt; Sun, 26 Feb 2023 04:50:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Yi2D3Z8/d2XuDlFyzmMHMQVJNzMvIWy/kV4rWrunGRk=; b=fppap8q196xN8YAIeFue6aAJRB GT4OBqEQbMQpfjKEFp6zf2iU33foy8LMy+CNbh8biGV2uSS5NikqcOCaInVLiRPMWA8VbCm4CJNq6 0/dsp4io3A0m0rDgnXKn6xZbXkxUpXj+WNVFTsHUJ7O/TqbCMXLxJS6zAPag3U59JMP8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 178453: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:build-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-5.4:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=69f65d442efe5eb3c1ee8adec251b918c1b0090a X-Osstest-Versions-That: linux=64121e2adf7d6fe2e684eec09ec9b9986d951d42 From: osstest service owner Date: Sun, 26 Feb 2023 04:50:33 +0000 flight 178453 linux-5.4 real [real] flight 178522 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178453/ http://logs.test-lab.xenproject.org/osstest/logs/178522/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail pass in 178522-retest Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 178125 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178125 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178125 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178125 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178125 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178125 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178125 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178125 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178125 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178125 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 69f65d442efe5eb3c1ee8adec251b918c1b0090a baseline version: linux 64121e2adf7d6fe2e684eec09ec9b9986d951d42 Last test of basis 178125 2023-02-22 12:17:26 Z 3 days Testing same since 178453 2023-02-25 11:13:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexei Starovoitov Bitterblue Smith Camelia Groza Christoph Hellwig Daniel Borkmann # BPF bits Dave Hansen David S. Miller Fedor Pchelkin Florian Fainelli Geert Uytterhoeven Greg Kroah-Hartman Guenter Roeck Jakub Kicinski Jason A. Donenfeld Jim Mattson Jimmy Assarsson Johannes Berg John Stultz Kalle Valo Kees Cook Linus Torvalds Linux Kernel Functional Testing Lucas Stach Lukas Wunner Marc Kleine-Budde Marek Szyprowski Ovidiu Panait Pavel Skripkin Sasha Levin Sean Anderson Sean Christopherson Shuah Khan Slade Watkins Sudip Mukherjee Thomas Gleixner Vladimir Oltean Zheng Wang Zhenyu Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 64121e2adf7d..69f65d442efe 69f65d442efe5eb3c1ee8adec251b918c1b0090a -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sun Feb 26 08:15:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 08:15:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501960.773781 (Exim 4.92) (envelope-from ) id 1pWCBC-0005pa-Md; Sun, 26 Feb 2023 08:14:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501960.773781; Sun, 26 Feb 2023 08:14:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWCBC-0005pT-JE; Sun, 26 Feb 2023 08:14:46 +0000 Received: by outflank-mailman (input) for mailman id 501960; Sun, 26 Feb 2023 08:14:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWCBB-0005pJ-Ds; Sun, 26 Feb 2023 08:14:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWCBB-0000r0-Af; Sun, 26 Feb 2023 08:14:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWCBA-0000nt-VS; Sun, 26 Feb 2023 08:14:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWCBA-0001cO-V1; Sun, 26 Feb 2023 08:14:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nnDmtHddAWq9GybJoU45wg6PiFiAX9YanRn3bq8tnuE=; b=IaOk66++QvsjQitOULGhSzDOQI 2ztg07wEuhnOoigeBH1HezdKLAqGZGPehTUpx65ykCLAAqr5QhIFRxO1Lj7XxbikiVYWMQEsc1FXS 7UdvL5gPvM64aIov0eH6oVnPxAQ+SAHpmbhYSBTXvpNzzKcSIkQdVcxfXc+St/gkyah0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178479: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=489fa31ea873282b41046d412ec741f93946fc2d X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Sun, 26 Feb 2023 08:14:44 +0000 flight 178479 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178479/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 489fa31ea873282b41046d412ec741f93946fc2d baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 4 days Failing since 178093 2023-02-22 05:02:47 Z 4 days 7 attempts Testing same since 178479 2023-02-25 17:14:09 Z 0 days 1 attempts ------------------------------------------------------------ 1656 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 180377 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 26 10:29:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 10:29:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.501992.773791 (Exim 4.92) (envelope-from ) id 1pWEHd-00074g-2x; Sun, 26 Feb 2023 10:29:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 501992.773791; Sun, 26 Feb 2023 10:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWEHc-00074Z-WE; Sun, 26 Feb 2023 10:29:33 +0000 Received: by outflank-mailman (input) for mailman id 501992; Sun, 26 Feb 2023 10:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWEHb-00074T-GB for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 10:29:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWEHb-000406-1W; Sun, 26 Feb 2023 10:29:31 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWEHa-0000NN-QR; Sun, 26 Feb 2023 10:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7v/OfU/FvMoHcl2tSrE1Us0M0HisqmSs/LOs3Z2N6tE=; b=1dh4kpqvo/m3GCw7up7N3Ys2Sv D51m79QAHP0wbx6inezWQiMP8dsIx+3C75tAzhLeYhLZcU3lgLQEcuieD6l0IQ03w8p41GQA0Jfit Penu4wcCyMct8U4aCaE4q/lfyf+4pFC36kItYpM3Ta4fioXmqA3aCAFZkbY/UFTXncKI=; Message-ID: Date: Sun, 26 Feb 2023 10:29:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v5 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Luca Fancellu , "michal.orzel@amd.com" , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230127195508.2786-1-julien@xen.org> <20230127195508.2786-4-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 28/01/2023 04:54, Henry Wang wrote: >> -----Original Message----- >> Subject: [PATCH v5 3/5] xen/arm64: mm: Introduce helpers to >> prepare/enable/disable the identity mapping >> >> From: Julien Grall >> >> In follow-up patches we will need to have part of Xen identity mapped in >> order to safely switch the TTBR. >> >> On some platform, the identity mapping may have to start at 0. If we always >> keep the identity region mapped, NULL pointer dereference would lead to >> access to valid mapping. >> >> It would be possible to relocate Xen to avoid clashing with address 0. >> However the identity mapping is only meant to be used in very limited >> places. Therefore it would be better to keep the identity region invalid >> for most of the time. >> >> Two new external helpers are introduced: >> - arch_setup_page_tables() will setup the page-tables so it is >> easy to create the mapping afterwards. >> - update_identity_mapping() will create/remove the identity mapping >> >> Signed-off-by: Julien Grall > > Reviewed-by: Henry Wang > With some nits below that can definitely be fixed on commit. I need to resend a new version of this patch. So I will fix them at the same time and... > > Tested on FVP in Arm64 mode, so: > Tested-by: Henry Wang .. didn't keep these tags. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 26 11:56:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 11:56:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502034.773818 (Exim 4.92) (envelope-from ) id 1pWFdz-0003CQ-Nl; Sun, 26 Feb 2023 11:56:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502034.773818; Sun, 26 Feb 2023 11:56:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFdz-0003CJ-Jk; Sun, 26 Feb 2023 11:56:43 +0000 Received: by outflank-mailman (input) for mailman id 502034; Sun, 26 Feb 2023 11:56:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFdy-0003CD-Au for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 11:56:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFdw-00060P-5x; Sun, 26 Feb 2023 11:56:40 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWFdv-0003gx-VN; Sun, 26 Feb 2023 11:56:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=o6WW3lH/spdAbZ3Oah5HD+VM6LWMHeURqc+HEeH0LeQ=; b=YxHvZA5OB069JOzn0/D37PuF2R R7FxpeaLaQI4VkD3LFrg1WvgooRCdR6IrdIiR0yUfnjQwuZ0R9qzJvNVArEkpAjvYO+HQ6tSBajUm JwD39EZ4P4tSf9gAG4DSaT9SV6DRHCU+1wFL8CXoJBxddcT7LN4fnSWVA4UnHUuso0G4=; Message-ID: <4840a055-723c-5f72-b3c1-0c9d72c4d413@xen.org> Date: Sun, 26 Feb 2023 11:56:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 1/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Paul Durrant , George Dunlap References: <20230209230020.52695-1-julien@xen.org> <20230209230020.52695-2-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Anthony, On 23/02/2023 11:22, Anthony PERARD wrote: > On Thu, Feb 09, 2023 at 11:00:15PM +0000, Julien Grall wrote: >> This is replacing the below pattern with the SPDX tag GPL-2.0 in > > The "GPL-2.0" identifier is actually deprecated: > https://spdx.org/licenses/GPL-2.0.html I hadn't realized that. It looks like there are many use of GPL-2.0 within Xen and LICENSES/GPL-2.0 doesn't mention the deprecation. I will add a patch to update LICENSES/GPL-2.0 and respin this series to switch to... > We should use "GPL-2.0-only" instead. ... GPL-2.0-only. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 26 12:01:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 12:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502042.773828 (Exim 4.92) (envelope-from ) id 1pWFiE-00057A-KV; Sun, 26 Feb 2023 12:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502042.773828; Sun, 26 Feb 2023 12:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFiE-000573-HF; Sun, 26 Feb 2023 12:01:06 +0000 Received: by outflank-mailman (input) for mailman id 502042; Sun, 26 Feb 2023 12:01:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFiD-00056t-Hj for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 12:01:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWFiC-000687-Bh; Sun, 26 Feb 2023 12:01:04 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWFiC-0003xx-4a; Sun, 26 Feb 2023 12:01:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wcq4fTWULUwiaOJ314uKBfDBPwSIOpXT1RYMg1KoHVY=; b=oNr0qSjWs7TWP4xRw4pHPNUSVj IQ6elewHsy77Uvh3UtUFnCa6A9P6XLfkDAsoKF/z6UcA6gUfwZ5qIfAvNwaeQMaaCSOWK9fUaEN6E aZQB2mJX50xgpycaRF2mgoV1WZCS5msUL55PvV8wsub3CNVyrM0nPS15A3FM6/T41J2o=; Message-ID: <7e16908b-4caa-b076-f3cf-b68c1d3dc766@xen.org> Date: Sun, 26 Feb 2023 12:01:02 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 2/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.c (part 2) To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, demi@invisiblethingslab.com, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , George Dunlap , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Tim Deegan References: <20230209230020.52695-1-julien@xen.org> <20230209230020.52695-3-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Anthony, On 23/02/2023 11:23, Anthony PERARD wrote: > On Thu, Feb 09, 2023 at 11:00:16PM +0000, Julien Grall wrote: >> This is replacing the below pattern with the SPDX tag GPL-2.0 in >> xen/arch/x86/*.c: >> >> * This program is free software; you can redistribute it and/or modify >> * it under the terms of the GNU General Public License as published by >> * the Free Software Foundation; either version 2 of the License, or >> * (at your option) any later version. > > This boilerplate allow to use newer version of the GPL license, the > identifier for that is "GPL-2.0-or-later". Whoops! I will switch to GPL-2.0-or-later. > https://spdx.org/licenses/GPL-2.0-or-later.html > >> * This program is distributed in the hope that it will be useful, >> * but WITHOUT ANY WARRANTY; without even the implied warranty of >> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> * GNU General Public License for more details. >> * >> * You should have received a copy of the GNU General Public License >> * along with this program; If not, see . Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Feb 26 12:41:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 12:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502071.773837 (Exim 4.92) (envelope-from ) id 1pWGLX-0002aB-LQ; Sun, 26 Feb 2023 12:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502071.773837; Sun, 26 Feb 2023 12:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWGLX-0002a4-Ih; Sun, 26 Feb 2023 12:41:43 +0000 Received: by outflank-mailman (input) for mailman id 502071; Sun, 26 Feb 2023 12:41:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWGLW-0002Zu-5J; Sun, 26 Feb 2023 12:41:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWGLW-0007BT-1Z; Sun, 26 Feb 2023 12:41:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWGLV-00072W-Kg; Sun, 26 Feb 2023 12:41:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWGLV-0003nn-KH; Sun, 26 Feb 2023 12:41:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=luKc/oqpcfgL9zUVN3D8vGlh1zxSr+HX1wwl5YtSifY=; b=XNNVsqwdZgtNJb2xYoJFAVTLC2 uPhHyENlNhd0VNYy7Epnx3OuJmNCoSeX/Eeud60kFPBXPJoeqmPpvtbpgw5vINsY5dqoXpCaQaAdo rk36PAy6/er+KW/D5tT5kBhxJDVRVblkoqBuaqiECom4MRIUvEtsPo3A1zDRzPwaHYFs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178515: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=608f85a1818697156b72ace4913a17c8178a0ef5 X-Osstest-Versions-That: xen=608f85a1818697156b72ace4913a17c8178a0ef5 From: osstest service owner Date: Sun, 26 Feb 2023 12:41:41 +0000 flight 178515 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178515/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 10 xen-install/src_host fail in 178432 pass in 178515 test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 178432 pass in 178515 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 178432 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 178432 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178432 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178432 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178432 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178432 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178432 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178432 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178432 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178432 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178432 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 3 hosts-allocate starved in 178432 n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved in 178432 n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved in 178432 n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved in 178432 n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved in 178432 n/a build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 608f85a1818697156b72ace4913a17c8178a0ef5 baseline version: xen 608f85a1818697156b72ace4913a17c8178a0ef5 Last test of basis 178515 2023-02-26 01:54:15 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Feb 26 14:37:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 14:37:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502085.773848 (Exim 4.92) (envelope-from ) id 1pWI9i-0000aT-4w; Sun, 26 Feb 2023 14:37:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502085.773848; Sun, 26 Feb 2023 14:37:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWI9i-0000aM-2B; Sun, 26 Feb 2023 14:37:38 +0000 Received: by outflank-mailman (input) for mailman id 502085; Sun, 26 Feb 2023 14:37:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWI9h-0000aC-7I; Sun, 26 Feb 2023 14:37:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWI9h-0001cN-4f; Sun, 26 Feb 2023 14:37:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWI9g-0001C9-Qt; Sun, 26 Feb 2023 14:37:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWI9g-0003GW-QQ; Sun, 26 Feb 2023 14:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dPWgPkapjHmNZ2XvwpJPlXtnTO3RjL2gMh9N926W2tY=; b=bXGIdRvIvKCEQRPq5HgHNNrbYR 9uKwsezYGbgSGriOSEaCoRugU/q6IKqnsNyxTrJSGHOXgpoza8SMnjmhuV8GnzlFCuB4PuV+Lxw1k 2VzFonuIjXRHtqo8R+QGEvDQjrwi7T9MymbL6thgzUw4phxmEeabyZTftKUUxIK5PRl8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 178527: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-arm64-arm64-libvirt-qcow2:guest-start/debian.repeat:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=e66469095d4a6dafc7e482894321e1e10c734e54 X-Osstest-Versions-That: libvirt=6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 From: osstest service owner Date: Sun, 26 Feb 2023 14:37:36 +0000 flight 178527 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/178527/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-qcow2 17 guest-start/debian.repeat fail like 178202 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt e66469095d4a6dafc7e482894321e1e10c734e54 baseline version: libvirt 6af048339fe6b22fb25cf62f7ec4d1bddb7ad1d6 Last test of basis 178315 2023-02-24 04:20:20 Z 2 days Testing same since 178422 2023-02-25 04:20:14 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Yuri Chornoivan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 6af048339f..e66469095d e66469095d4a6dafc7e482894321e1e10c734e54 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Feb 26 16:34:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 16:34:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502140.773857 (Exim 4.92) (envelope-from ) id 1pWJyy-0000Nl-Gf; Sun, 26 Feb 2023 16:34:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502140.773857; Sun, 26 Feb 2023 16:34:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWJyy-0000Ne-E2; Sun, 26 Feb 2023 16:34:40 +0000 Received: by outflank-mailman (input) for mailman id 502140; Sun, 26 Feb 2023 16:34:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWJyx-0000NY-1v for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 16:34:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 741226eb-b5f3-11ed-88bb-e56d68cac8db; Sun, 26 Feb 2023 17:34:36 +0100 (CET) Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-502-IvdbNkHKMUSM67kUTHewYg-1; Sun, 26 Feb 2023 11:34:33 -0500 Received: by mail-qt1-f200.google.com with SMTP id t22-20020ac86a16000000b003bd1c0f74cfso1707385qtr.20 for ; Sun, 26 Feb 2023 08:34:33 -0800 (PST) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g2-20020ac870c2000000b003b868cdc689sm3171728qtp.5.2023.02.26.08.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 08:34:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 741226eb-b5f3-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677429274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AORosMQj3A7DS3Nk/fBRbnzvD4PblGqGAWvsizAa8P8=; b=YGm/6kgWz96USy3U4u6R1DAy+r5k4X5KptyHlfg4RMRhII/dzqs6SNm0VR/B/Rki6vnul2 qCi+AHD8bAncyzpTn1FLa4qEv0Y3iBZQD6zPvf86/7qXdYfebqb7uyIvP+pZuGUUkkubLb sciEHqg04dMuTm2T8ZrM+IBrw3mVO0Y= X-MC-Unique: IvdbNkHKMUSM67kUTHewYg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AORosMQj3A7DS3Nk/fBRbnzvD4PblGqGAWvsizAa8P8=; b=yh2+LzXKEnbU47Qu8cjPR9mLscf1noggoQ3frSo2fhyXiZKlLfQXTnr1csy/eRaBzO V8OwUl+6oukrkO4SdnsWbPAgCd5Sg+589zezXYnN7vyue33L/9X/D3voCRRFTUN7B0fI FFbQrkMkSlBcRXy/zxgQlv8FrrXT26TlcHAvG48nIJ9VF+n7UDlHyC4Ds5XbwBf3hjpH 6NIwRiXH6NhsvkHTPHTqvax0p2dXP+UcIo5l0fOIXUU+Ki+AEqVmX2eaw+rR6A4he9Sl LFmPoMQJ2MvTu5VGLqhD3qPfd9DDY9LZuA0IIhmfX/tPJAofFfpRlMoksTEtIP1Ch9N3 AbbA== X-Gm-Message-State: AO0yUKV/hiARJxZYeOCbvlYrYG6Dpn8biEAnmtKFhavi3t2SJzsypxho +RtY6yMgK/uoFhyMDmq8wUi/IcucljTaEUFJhjkxq4bepJHJh0AZvoo6eU7WUKiymhPb4iofpMt 8vFMHZC5Dy2YCbTearb+ob7ul6W0= X-Received: by 2002:ac8:4e84:0:b0:3bf:d9a9:25fb with SMTP id 4-20020ac84e84000000b003bfd9a925fbmr876277qtp.10.1677429272650; Sun, 26 Feb 2023 08:34:32 -0800 (PST) X-Google-Smtp-Source: AK7set87gS29lQpRvxFPSHfdfKAfctYcKloYbTI3zUudY16bh9F5kOGQv9rhoki2m/9HRW6el0/hNQ== X-Received: by 2002:ac8:4e84:0:b0:3bf:d9a9:25fb with SMTP id 4-20020ac84e84000000b003bfd9a925fbmr876253qtp.10.1677429272361; Sun, 26 Feb 2023 08:34:32 -0800 (PST) From: Tom Rix To: wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] xen-netback: remove unused variables pending_idx and index Date: Sun, 26 Feb 2023 11:34:29 -0500 Message-Id: <20230226163429.2351600-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit building with gcc and W=1 reports drivers/net/xen-netback/netback.c:886:21: error: variable ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] 886 | u16 pending_idx; | ^~~~~~~~~~~ pending_idx is not used so remove it. Since index was only used to set pending_idx, remove index as well. Signed-off-by: Tom Rix --- drivers/net/xen-netback/netback.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index bf627af723bf..1b42676ca141 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -883,11 +883,9 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, struct xen_netif_tx_request txfrags[XEN_NETBK_LEGACY_SLOTS_MAX]; struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX-1]; unsigned int extra_count; - u16 pending_idx; RING_IDX idx; int work_to_do; unsigned int data_len; - pending_ring_idx_t index; if (queue->tx.sring->req_prod - queue->tx.req_cons > XEN_NETIF_TX_RING_SIZE) { @@ -983,9 +981,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue, break; } - index = pending_index(queue->pending_cons); - pending_idx = queue->pending_ring[index]; - if (ret >= XEN_NETBK_LEGACY_SLOTS_MAX - 1 && data_len < txreq.size) data_len = txreq.size; -- 2.27.0 From xen-devel-bounces@lists.xenproject.org Sun Feb 26 20:30:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 20:30:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502159.773867 (Exim 4.92) (envelope-from ) id 1pWNed-0005Of-CU; Sun, 26 Feb 2023 20:29:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502159.773867; Sun, 26 Feb 2023 20:29:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWNed-0005OY-9Y; Sun, 26 Feb 2023 20:29:55 +0000 Received: by outflank-mailman (input) for mailman id 502159; Sun, 26 Feb 2023 20:29:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWNeb-0005OO-Q6; Sun, 26 Feb 2023 20:29:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWNeb-0001WR-OH; Sun, 26 Feb 2023 20:29:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWNeb-0000Up-Es; Sun, 26 Feb 2023 20:29:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWNeb-0002sK-ES; Sun, 26 Feb 2023 20:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IcS7uy4+UYl0ycInJE2uCR7iVuPoUNsdSfPSdhkakYs=; b=KSJ045eRiEXmT8A4hZkXJMNeeJ Qbd3CfOa9MzE9Ae2rt5UHEHcS9oObGpQcuAeySrB25Pc3bKMQY9Bh3x8pYhcKit70MtdYcpuQbjdx te3M/kuSi3bCz7l9ms5Rb5TAMR6z7gwQ3HynyLpXmE+5qoVoYlzkCNfUgUOvFRP8deWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178544: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-stop:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Sun, 26 Feb 2023 20:29:53 +0000 flight 178544 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178544/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 17 guest-stop fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 5 days Failing since 178093 2023-02-22 05:02:47 Z 4 days 8 attempts Testing same since 178544 2023-02-26 08:19:12 Z 0 days 1 attempts ------------------------------------------------------------ 1803 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 204883 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Feb 26 23:50:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 26 Feb 2023 23:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502168.773878 (Exim 4.92) (envelope-from ) id 1pWQmx-0006jq-Io; Sun, 26 Feb 2023 23:50:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502168.773878; Sun, 26 Feb 2023 23:50:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWQmx-0006jj-G5; Sun, 26 Feb 2023 23:50:43 +0000 Received: by outflank-mailman (input) for mailman id 502168; Sun, 26 Feb 2023 23:50:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWQmw-0006jd-45 for xen-devel@lists.xenproject.org; Sun, 26 Feb 2023 23:50:42 +0000 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ef36cda-b630-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 00:50:39 +0100 (CET) Received: from [192.168.2.206] (109-252-117-89.nat.spd-mgts.ru [109.252.117.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 187D86602DCD; Sun, 26 Feb 2023 23:50:37 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ef36cda-b630-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1677455438; bh=JYRpxATqvkNno1FwoBgptX7gQvro7kbdKaoh02c9VEQ=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=TqSCfmh49xkDbtgdLhYXyECizYrDVzOlSc4QBhUnSkdoQBHhIiPRhn8+7lHI9/9li e8HZpOK/Mo6d2omwCQIfEe5i7lLxY7GKYfFKKTdInzjMwboFn9AXcDn0KGQf64Vf8A Uv0b10EbzFkgDzRcxhD08xlEmcbpLo8Lnr5aO/rkyJqqjvkoFRhZ8eht4eo6Nwi0dC /IkZJm1mntY20f3yi75AZkKIuYm+OgpIrU7k+uxVssus+JfPaOq4a72cuHFHlA2VAP IuV7JW/2gw/aYpwuuv/nYTRBrrJ5S355O2kkcBhW4kpTmr7mezO+JGiV2Eq+8hnz7G 02drfzM2+WNlw== Message-ID: <32f2442d-9150-0288-499c-9206084d8732@collabora.com> Date: Mon, 27 Feb 2023 02:50:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] drm/virtio: Pass correct device to dma_sync_sgtable_for_device() From: Dmitry Osipenko To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Cc: Oleksandr Tyshchenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Juergen Gross , Stefano Stabellini References: <20230224153450.526222-1-olekstysh@gmail.com> <4cb50dcb-b877-9602-3802-d651eea57b89@collabora.com> Content-Language: en-US In-Reply-To: <4cb50dcb-b877-9602-3802-d651eea57b89@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/25/23 17:55, Dmitry Osipenko wrote: > On 2/24/23 18:34, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> The "vdev->dev.parent" should be used instead of "vdev->dev" as a device >> for which to perform the DMA operation in both >> virtio_gpu_cmd_transfer_to_host_2d(3d). >> >> Because the virtio-gpu device "vdev->dev" doesn't really have DMA OPS >> assigned to it, but parent (virtio-pci or virtio-mmio) device >> "vdev->dev.parent" has. The more, the sgtable in question the code is >> trying to sync here was mapped for the parent device (by using its DMA OPS) >> previously at: >> virtio_gpu_object_shmem_init()->drm_gem_shmem_get_pages_sgt()-> >> dma_map_sgtable(), so should be synced here for the same parent device. >> >> Fixes: b5c9ed70d1a9 ("drm/virtio: Improve DMA API usage for shmem BOs") >> Signed-off-by: Oleksandr Tyshchenko >> --- ... > Indeed, it's only the vgpu drm device that was moved to use the pci > parent device. On x86 the vdev always has dma-ops, also > virtio_has_dma_quirk=true for modern Qemu. So I didn't test this code > path and apparently it's only testable on Xen, which is good to know. > > Reviewed-by: Dmitry Osipenko Applied to misc-fixes -- Best regards, Dmitry From xen-devel-bounces@lists.xenproject.org Mon Feb 27 03:12:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 03:12:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502180.773888 (Exim 4.92) (envelope-from ) id 1pWTvV-0006ac-NJ; Mon, 27 Feb 2023 03:11:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502180.773888; Mon, 27 Feb 2023 03:11:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWTvV-0006aV-JS; Mon, 27 Feb 2023 03:11:45 +0000 Received: by outflank-mailman (input) for mailman id 502180; Mon, 27 Feb 2023 03:11:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWTvU-0006aL-F8; Mon, 27 Feb 2023 03:11:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWTvU-0001mc-DH; Mon, 27 Feb 2023 03:11:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWTvU-0001wL-5E; Mon, 27 Feb 2023 03:11:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWTvU-0008G8-4k; Mon, 27 Feb 2023 03:11:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NkftKO2HMES+PPsKO5GbF3NAXnhc+UuwFdn/mQx8QIQ=; b=CgKwOsH6EF432ydmHDRtUbghoD K9ei6XpgaiAYW/k+g4KYSUbcVpIYfldlq8JR5HRId8zam7XhEUPtCGA5n6kxYT4WkOk3l/YcN6cpV 3BAsBepToXqrjXVs6JD0T5/N3QbvoTIcgxz3D5J+wZjjVQFoYZnfiF1uE8q8Ee3NUj7U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178595: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-stop:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f3a2439f20d918930cc4ae8f76fe1c1afd26958f X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Mon, 27 Feb 2023 03:11:44 +0000 flight 178595 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178595/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 17 guest-stop fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f3a2439f20d918930cc4ae8f76fe1c1afd26958f baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 5 days Failing since 178093 2023-02-22 05:02:47 Z 4 days 9 attempts Testing same since 178595 2023-02-26 20:42:37 Z 0 days 1 attempts ------------------------------------------------------------ 1866 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 214011 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:12:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:12:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502213.773897 (Exim 4.92) (envelope-from ) id 1pWXgK-0003v4-U3; Mon, 27 Feb 2023 07:12:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502213.773897; Mon, 27 Feb 2023 07:12:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWXgK-0003ux-RP; Mon, 27 Feb 2023 07:12:20 +0000 Received: by outflank-mailman (input) for mailman id 502213; Mon, 27 Feb 2023 07:12:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWXgI-0003up-Os for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:12:18 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 113c92ec-b66e-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 08:12:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B423E1F8D9; Mon, 27 Feb 2023 07:12:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72C4713912; Mon, 27 Feb 2023 07:12:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Q82PGtBX/GMvEwAAMHmgww (envelope-from ); Mon, 27 Feb 2023 07:12:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 113c92ec-b66e-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677481936; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HrnKxVaut6r2CDXXVOLh3BVxvIQd87Rgz8HeOc9Ihog=; b=XarnUwPi8XWpYFfE6Gv/laLV6++lwZ1otC8r0d3wg87x3jFJjPXGvkHNOEHXAULCQY5QX8 4bFVFwrdpin9/bp0oe7+KCEGal9rsFcRsRa9P2EMDQNQaCfk3Z1RCvhB/YB1rN7ej2bc01 j9xdD1PECarFVXxCbdeIcR0JtRHc+7Q= Message-ID: <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> Date: Mon, 27 Feb 2023 08:12:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain Content-Language: en-US To: Boris Ostrovsky , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------FFhz6EPCdS2w65o3ZOx2Fueq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------FFhz6EPCdS2w65o3ZOx2Fueq Content-Type: multipart/mixed; boundary="------------3AbvFZgihGkaTRnWYQWVXIY1"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Message-ID: <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> In-Reply-To: --------------3AbvFZgihGkaTRnWYQWVXIY1 Content-Type: multipart/mixed; boundary="------------is035BEUsBjXegdxGlJ800sJ" --------------is035BEUsBjXegdxGlJ800sJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDIuMjMgMjI6MDAsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IE9uIDIv MjMvMjMgNDozMiBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+ICsNCj4+ICsJZm9yIChy ZWcgPSAwOyByZWcgPCBNVFJSX01BWF9WQVJfUkFOR0VTOyByZWcrKykgew0KPj4gKwkJb3Au dS5yZWFkX21lbXR5cGUucmVnID0gcmVnOw0KPj4gKwkJaWYgKEhZUEVSVklTT1JfcGxhdGZv cm1fb3AoJm9wKSkNCj4+ICsJCQlicmVhazsNCj4gDQo+IA0KPiBJZiB3ZSBmYWlsIG9uIHRo ZSBmaXJzdCBpdGVyYXRpb24sIGRvIHdlIHN0aWxsIHdhbnQgdG8gbWFyayBNVFJScyBhcmUg DQo+IGVuYWJsZWQvc2V0IGluIG10cnJfb3ZlcndyaXRlX3N0YXRlKCk/DQoNCkhtbSwgZ29v ZCBpZGVhLg0KDQpJIHRoaW5rIHdlIHNob3VsZCBqdXN0IGRyb3AgdGhlIGNhbGwgb2YgbXRy cl9vdmVyd3JpdGVfc3RhdGUoKSBpbiB0aGlzDQpjYXNlLg0KDQoNCkp1ZXJnZW4NCg0K --------------is035BEUsBjXegdxGlJ800sJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------is035BEUsBjXegdxGlJ800sJ-- --------------3AbvFZgihGkaTRnWYQWVXIY1-- --------------FFhz6EPCdS2w65o3ZOx2Fueq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8V9AFAwAAAAAACgkQsN6d1ii/Ey+G Mgf9H5XiC1lDgClmPf2qn1uk/Tyz0nK83qR4lCovObg3Rros66mM9e0pM3ybs/Qn03T1sHbpQyCp 9lo20ytE6JStlCP/tZ1/L4cYXXvxSo4tImy7Q4Tg2Pr7+czIrBCUKv/KeqL2XIrLRKcSj2T4fVlO z4wrEZEgFFZhJDKt33QKJ9GaniukeTOrJ8/iM2VtA2QV2BIKVZYFHCxd2lGR9pFQ98i9SghpoVW6 c95mhqVdAuqYSVXBqLtqqg8gE1AdTVxRMQkqmXMoYZS2gCVA4MwZTAGOysv6Nh/i08PVb2Oakqrv A9r3kpaUStEP7GxVYAm3Z5xW+9sGjCEy1H/YyUQ8eg== =m39Q -----END PGP SIGNATURE----- --------------FFhz6EPCdS2w65o3ZOx2Fueq-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:57:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502218.773914 (Exim 4.92) (envelope-from ) id 1pWYNa-00017w-K8; Mon, 27 Feb 2023 07:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502218.773914; Mon, 27 Feb 2023 07:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNa-000154-Ef; Mon, 27 Feb 2023 07:57:02 +0000 Received: by outflank-mailman (input) for mailman id 502218; Mon, 27 Feb 2023 07:57:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNZ-0000zz-Lb for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:57:01 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50592f13-b674-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 08:57:00 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id ec43so21964294edb.8 for ; Sun, 26 Feb 2023 23:57:00 -0800 (PST) Received: from uni.router.wind (adsl-209.109.242.226.tellas.gr. [109.242.226.209]) by smtp.googlemail.com with ESMTPSA id b23-20020a50ccd7000000b0049ef70a2894sm2788272edj.38.2023.02.26.23.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 23:56:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50592f13-b674-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pnLzBk1wGHculJohEmqu0NjSNnMRtRwNM1eASmcyK7g=; b=XpIwuJxkvMyIxXOrltJKdUm3iZn63kgkpjcD+ADaAvqH7jhlg5gOI7M44LeTbWoYTz NAsJmfgDMVnY9LXB5A2VKokOkIKxEjFZ5VtSWOXa7ht0DHPEFTxApGg9XqLO/I6a5eyk wNdrRI8WiM0jFIqlDaXvCeq2W/qkGQ3G1xyAgEB6n/A+wFCMaF8qGcOR/WBOGs2omKCS aWjAFKGv2IXWsCxyR/M0AO1lUHj/454e+qezdGA7DfbIx5vwg/lIL/szuG/lYUQuWUBD nsU6lNJqq0cCAlDIaloM+a0SiiJJRBgBGoMxE6sgPmg1bvrnBH821XPM3TjSX2htVE1t f9mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pnLzBk1wGHculJohEmqu0NjSNnMRtRwNM1eASmcyK7g=; b=8Ixu5N92oRY1V09pK6OrUeSAUU39IHa3UQzQ7h88Cd8MWEUu/KlfufDPGtUK+K+TL3 ir0wg2toGJTxn41QCKeIqLf2k3sy8RLCQkdqkpeG/S9+iTGFutSERkfv3yRPKWjt4rx5 BTvQripn/W/43K9olZzKzrtyLVW9Qy3oUYNHDVfCbni8P3+jD96Rm7mCJXiRce19W30c nOZBslPi+8Qct/7fDBsb/Tj1uAgNzXH/XvQ6OpuwZUtA2IQQxaXPVC6Dp3ltku/tKNqe RVWo4uGl4RYbUeAIDQg14+bXqWpJjdBon9/18YfWlxUXX1KWOcbuw175n9o4dANZ1fqq HE7Q== X-Gm-Message-State: AO0yUKVkeUhaawbS0MMhMiLqnAc6cvR/UzoV5uF3p3bs4zjXwUg8hhgS YkYLaOLuzfnN8kxJIi7kU9/pa+JIi7mU2Q== X-Google-Smtp-Source: AK7set9bGy/1HtlnFiZuZBv3paHLqzPWNlh8gUpseIREAC0+E5QaeISn+/4aHvSrRaJP/iEeWMSubQ== X-Received: by 2002:a05:6402:e04:b0:4ac:d90e:92b with SMTP id h4-20020a0564020e0400b004acd90e092bmr9246366edh.10.1677484619198; Sun, 26 Feb 2023 23:56:59 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 1/4] x86/vpmu: rename {svm,vmx}_vpmu_initialise to {amd,core2}_vpmu_initialise Date: Mon, 27 Feb 2023 09:56:49 +0200 Message-Id: <20230227075652.3782973-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230227075652.3782973-1-burzalodowa@gmail.com> References: <20230227075652.3782973-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PMU virtualization is not dependent on the hardware virtualization support. Rename {svm,vmx}_vpmu_initialise to {amd,core2}_vpmu_initialise because the {svm,vmx} prefix is misleading. Take the opportunity to remove the also misleading comment stating that vpmu is specific to hvm guests, and correct the filename. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/vpmu_amd.c | 6 +++--- xen/arch/x86/cpu/vpmu_intel.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 58794a16f0..9df739aa3f 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -1,5 +1,5 @@ /* - * vpmu.c: PMU virtualization for HVM domain. + * vpmu_amd.c: AMD specific PMU virtualization. * * Copyright (c) 2010, Advanced Micro Devices, Inc. * Parts of this code are Copyright (c) 2007, Intel Corporation @@ -480,7 +480,7 @@ static void cf_check amd_vpmu_dump(const struct vcpu *v) } } -static int cf_check svm_vpmu_initialise(struct vcpu *v) +static int cf_check amd_vpmu_initialise(struct vcpu *v) { struct xen_pmu_amd_ctxt *ctxt; struct vpmu_struct *vpmu = vcpu_vpmu(v); @@ -527,7 +527,7 @@ static int cf_check amd_allocate_context(struct vcpu *v) #endif static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { - .initialise = svm_vpmu_initialise, + .initialise = amd_vpmu_initialise, .do_wrmsr = amd_vpmu_do_wrmsr, .do_rdmsr = amd_vpmu_do_rdmsr, .do_interrupt = amd_vpmu_do_interrupt, diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index a8df52579d..bcfa187a14 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -1,5 +1,5 @@ /* - * vpmu_core2.c: CORE 2 specific PMU virtualization for HVM domain. + * vpmu_intel.c: CORE 2 specific PMU virtualization. * * Copyright (c) 2007, Intel Corporation. * @@ -833,7 +833,7 @@ static void cf_check core2_vpmu_destroy(struct vcpu *v) vpmu_clear(vpmu); } -static int cf_check vmx_vpmu_initialise(struct vcpu *v) +static int cf_check core2_vpmu_initialise(struct vcpu *v) { struct vpmu_struct *vpmu = vcpu_vpmu(v); u64 msr_content; @@ -898,7 +898,7 @@ static int cf_check vmx_vpmu_initialise(struct vcpu *v) } static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = { - .initialise = vmx_vpmu_initialise, + .initialise = core2_vpmu_initialise, .do_wrmsr = core2_vpmu_do_wrmsr, .do_rdmsr = core2_vpmu_do_rdmsr, .do_interrupt = core2_vpmu_do_interrupt, -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:57:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:57:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502217.773907 (Exim 4.92) (envelope-from ) id 1pWYNa-00010C-5B; Mon, 27 Feb 2023 07:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502217.773907; Mon, 27 Feb 2023 07:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNa-000105-2B; Mon, 27 Feb 2023 07:57:02 +0000 Received: by outflank-mailman (input) for mailman id 502217; Mon, 27 Feb 2023 07:57:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNY-0000zt-6v for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:57:00 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4eff32ef-b674-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 08:56:58 +0100 (CET) Received: by mail-ed1-x52a.google.com with SMTP id f13so21995817edz.6 for ; Sun, 26 Feb 2023 23:56:57 -0800 (PST) Received: from uni.router.wind (adsl-209.109.242.226.tellas.gr. [109.242.226.209]) by smtp.googlemail.com with ESMTPSA id b23-20020a50ccd7000000b0049ef70a2894sm2788272edj.38.2023.02.26.23.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 23:56:56 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eff32ef-b674-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ID3uCYe2CWd6ty/xP8fK1sRL4RZVuw6YXfqE73AmGHE=; b=lzcSMnzQSPwHPIODtMBUcEDWE3+j2ENhwalXivVO/WF/BsWJuUHzao4LcO10IvnWdo az+aEAl4gjKHjdM90Z1/4bLd7aKJhhDW5B+pC1f31bk3EhH+BhqcHsicmDiNPGNKUoVG n+6qfRj9XyOvOgR7JIp7m1b4nIiHGjjXnrRHJfGhqGqfAhf/IS9/ya02KE6+o7l2X6+Z 4fIoZCUuqnMTUf1NbLbCBIbg63HenTvngcAphBCDawYc56gZyrfw0OR1k1qJg4pe2QMB e+tlY3TFlqTTpsdzRiL/9zCkzwcAX7wM2G4GgklV1QbLWCuyBmiiBgxhiVSEZWTYmxzW /Dqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ID3uCYe2CWd6ty/xP8fK1sRL4RZVuw6YXfqE73AmGHE=; b=gRjX6YMV5hZ/akYYDIpl04vrHeKTdJzIIRXCRYeN7NCWEaVQ1pPpUt6Mltob94zsek wvYaoJr1SUVEmoI7ZLKFrziPOhPh7H4s/vGyvWdMjyfJbGhRoVVYS4ozXefuZcFcKaAg anHcBIrvb0P3aDyYsBtCRHA+ZarT9HcTjye4g8v/dE4rhMmZzpcMHFC2T+gipZ3VZmB8 n0lpMZLfJoKK65st+aCassIyHAzdL4v/rZl8yqhzNQ1DL7/S+ZuA/kq5jqywX5pPxmfP iR67ilFmsKY0OblWAMaYTPWGmVrUPHKqAWem8jqF8Yhj0kNPFKQBsmyqJDUWjfloHQQr znOA== X-Gm-Message-State: AO0yUKX3TQgQkk/yvCFAB4zDSB7RnHOctFPQ0/PTdG5RvRXgSisfCMLl WUVqngcIGggUcsdk8y5jlAnIAaSpf2L3mw== X-Google-Smtp-Source: AK7set9+Xj6VJG0F/kjblsG7ak+w3VAIbj1pgTaWG/2/Hvva6lazWOkhZYukvjSUZBulucYDp+XCpg== X-Received: by 2002:a17:906:494c:b0:879:6abe:915e with SMTP id f12-20020a170906494c00b008796abe915emr34353076ejt.69.1677484616861; Sun, 26 Feb 2023 23:56:56 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 0/4] hvm: add hvm_funcs hooks for msr intercept handling Date: Mon, 27 Feb 2023 09:56:48 +0200 Message-Id: <20230227075652.3782973-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series aims to make the msr intercept handling, performed in vpmu code, virtualization technology agnostic. It creates a common interface for setting/clearing the msr intercepts and then add hooks to the corresponding hvm_funcs table to be able to call the svm/vmx specific handlers through a generic hvm wrapper function. Xenia Ragiadakou (4): x86/vpmu: rename {svm,vmx}_vpmu_initialise to {amd,core2}_vpmu_initialise x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() x86/vmx: replace enum vmx_msr_intercept_type with the msr access flags x86/hvm: create hvm_funcs for {svm,vmx}_{set,clear}_msr_intercept() xen/arch/x86/cpu/vpmu_amd.c | 15 ++--- xen/arch/x86/cpu/vpmu_intel.c | 30 +++++----- xen/arch/x86/hvm/svm/svm.c | 80 ++++++++++++++++--------- xen/arch/x86/hvm/vmx/vmcs.c | 38 ++++++------ xen/arch/x86/hvm/vmx/vmx.c | 46 +++++++------- xen/arch/x86/include/asm/hvm/hvm.h | 32 ++++++++++ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 13 ++-- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 14 +---- 8 files changed, 156 insertions(+), 112 deletions(-) -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:57:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:57:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502219.773928 (Exim 4.92) (envelope-from ) id 1pWYNc-0001VA-SO; Mon, 27 Feb 2023 07:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502219.773928; Mon, 27 Feb 2023 07:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNc-0001V3-O9; Mon, 27 Feb 2023 07:57:04 +0000 Received: by outflank-mailman (input) for mailman id 502219; Mon, 27 Feb 2023 07:57:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNb-0000zz-8w for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:57:03 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51caa822-b674-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 08:57:02 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id h16so21938235edz.10 for ; Sun, 26 Feb 2023 23:57:02 -0800 (PST) Received: from uni.router.wind (adsl-209.109.242.226.tellas.gr. [109.242.226.209]) by smtp.googlemail.com with ESMTPSA id b23-20020a50ccd7000000b0049ef70a2894sm2788272edj.38.2023.02.26.23.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 23:57:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51caa822-b674-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J/HLnBgL78z3g+xd6PxPHvHY0SFIgTSI0bcDcphjSqs=; b=J7ipBAzCwMCWW6J14s4QbKNAkMUrWhe1/KfqjxlYg+addcysszeDILiWeMKEVAT4lQ wwdZsvddtwkXNeiMDFTQG4Zs2DeSrS/+rFEIdonM68g1Cs2Pb3ffryHJMqBKw3qt/FZN Aj05ns7rGIMShV3ujr6HN7agVN/jM2gx8l4lzAo/22kawFGuzmXX6mQiSn/B6toi1XUe 7SccLwdJBeTxrTUGYAEi8JgoYHfZUyCu7J3d5QBuM/AUxZx4nBLvJ2YaGzv0I865Dr23 uPoqJ3YvGWVszQA3OAhO0HixmHCHh7JgpuO5Sn37ytvZvevVdzVgGbFdwKgPY2MjZvqn iDTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J/HLnBgL78z3g+xd6PxPHvHY0SFIgTSI0bcDcphjSqs=; b=RWKItBz/TKyNQiTDXmfxwLOBtZ0xgUiq3+MXoPrMVZVa7xBDkCJUX04qAzDWnzRMIb KpEBEU58qA+WtHnJVv3Ig54xPGUH9GxaJAipqwJ4rJmTc53pa33EDjQ99OYVx9O7dTF+ Lg0/uTpAj0raLr7NCV0eN+8bhCQfFc5L1hCNftsdgGTCQQYx4cmnzAZ+6zSopQAGNrMr YVIf0H7vEYsTyZghff3qIUdFt1RVbGDpmz7YfUAlt+LvDs06pqUTObmmj1BfF+4v3RE1 huB2H0wdDhn/eLRa6ZIKPhbTwET5WFteyvcowb2n1bdHFWBmZVLXR6/yaDKBzAnOxomc 5Hdg== X-Gm-Message-State: AO0yUKUDXgixntefHe6Xh20o5+gouBvDUbgvgm+8GV1wxBfS6erP1Yte +J8g1OowXRJXdjqXKpjOYhtmrsATQN0gWA== X-Google-Smtp-Source: AK7set+W0JPaC06MNtxzOhoJq8s+ldBdHuhqSAWapm9BTZZdL/x5N8263P+Gj7kHNraT+RX8upnZow== X-Received: by 2002:aa7:cccc:0:b0:4ac:b308:d732 with SMTP id y12-20020aa7cccc000000b004acb308d732mr24509991edt.18.1677484621678; Sun, 26 Feb 2023 23:57:01 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Date: Mon, 27 Feb 2023 09:56:50 +0200 Message-Id: <20230227075652.3782973-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230227075652.3782973-1-burzalodowa@gmail.com> References: <20230227075652.3782973-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This change aims to render the control interface of MSR intercepts identical between SVM and VMX code, so that the control of the MSR intercept in common code can be done through an hvm_funcs callback. Create two new functions: - svm_set_msr_intercept(), enables interception of read/write accesses to the corresponding MSR, by setting the corresponding read/write bits in the MSRPM based on the flags - svm_clear_msr_intercept(), disables interception of read/write accesses to the corresponding MSR, by clearing the corresponding read/write bits in the MSRPM based on the flags More specifically: - if flag is MSR_R, the functions {set,clear} the MSRPM bit that controls read access to the MSR - if flag is MSR_W, the functions {set,clear} the MSRPM bit that controls write access to the MSR - if flag is MSR_RW, the functions {set,clear} both MSRPM bits Place the definitions of the flags in asm/hvm/hvm.h because there is the intention to be used by VMX code as well. Remove svm_intercept_msr() and MSR_INTERCEPT_* definitions, and use the new functions and flags instead. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/vpmu_amd.c | 9 +-- xen/arch/x86/hvm/svm/svm.c | 80 ++++++++++++++++--------- xen/arch/x86/include/asm/hvm/hvm.h | 4 ++ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 13 ++-- 4 files changed, 66 insertions(+), 40 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 9df739aa3f..ed6706959e 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -165,8 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) for ( i = 0; i < num_counters; i++ ) { - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_NONE); - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_WRITE); + svm_clear_msr_intercept(v, counters[i], MSR_RW); + svm_set_msr_intercept(v, ctrls[i], MSR_W); + svm_clear_msr_intercept(v, ctrls[i], MSR_R); } msr_bitmap_on(vpmu); @@ -179,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) for ( i = 0; i < num_counters; i++ ) { - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_RW); - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_RW); + svm_set_msr_intercept(v, counters[i], MSR_RW); + svm_set_msr_intercept(v, ctrls[i], MSR_RW); } msr_bitmap_off(vpmu); diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index a43bcf2e92..eb144272f4 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -288,23 +288,34 @@ svm_msrbit(unsigned long *msr_bitmap, uint32_t msr) return msr_bit; } -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int flags) +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) { - unsigned long *msr_bit; - const struct domain *d = v->domain; + unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); + + if ( msr_bit == NULL ) + return; - msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); - BUG_ON(msr_bit == NULL); msr &= 0x1fff; - if ( flags & MSR_INTERCEPT_READ ) + if ( flags & MSR_R ) __set_bit(msr * 2, msr_bit); - else if ( !monitored_msr(d, msr) ) - __clear_bit(msr * 2, msr_bit); - - if ( flags & MSR_INTERCEPT_WRITE ) + if ( flags & MSR_W ) __set_bit(msr * 2 + 1, msr_bit); - else if ( !monitored_msr(d, msr) ) +} + +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags) +{ + unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); + + if ( msr_bit == NULL ) + return; + + if ( monitored_msr(v->domain, msr) ) + return; + + if ( flags & MSR_R ) + __clear_bit(msr * 2, msr_bit); + if ( flags & MSR_W ) __clear_bit(msr * 2 + 1, msr_bit); } @@ -312,8 +323,10 @@ static void cf_check svm_enable_msr_interception(struct domain *d, uint32_t msr) { struct vcpu *v; - for_each_vcpu ( d, v ) - svm_intercept_msr(v, msr, MSR_INTERCEPT_WRITE); + for_each_vcpu ( d, v ) { + svm_set_msr_intercept(v, msr, MSR_W); + svm_clear_msr_intercept(v, msr, MSR_R); + } } static void svm_save_dr(struct vcpu *v) @@ -330,10 +343,10 @@ static void svm_save_dr(struct vcpu *v) if ( v->domain->arch.cpuid->extd.dbext ) { - svm_intercept_msr(v, MSR_AMD64_DR0_ADDRESS_MASK, MSR_INTERCEPT_RW); - svm_intercept_msr(v, MSR_AMD64_DR1_ADDRESS_MASK, MSR_INTERCEPT_RW); - svm_intercept_msr(v, MSR_AMD64_DR2_ADDRESS_MASK, MSR_INTERCEPT_RW); - svm_intercept_msr(v, MSR_AMD64_DR3_ADDRESS_MASK, MSR_INTERCEPT_RW); + svm_set_msr_intercept(v, MSR_AMD64_DR0_ADDRESS_MASK, MSR_RW); + svm_set_msr_intercept(v, MSR_AMD64_DR1_ADDRESS_MASK, MSR_RW); + svm_set_msr_intercept(v, MSR_AMD64_DR2_ADDRESS_MASK, MSR_RW); + svm_set_msr_intercept(v, MSR_AMD64_DR3_ADDRESS_MASK, MSR_RW); rdmsrl(MSR_AMD64_DR0_ADDRESS_MASK, v->arch.msrs->dr_mask[0]); rdmsrl(MSR_AMD64_DR1_ADDRESS_MASK, v->arch.msrs->dr_mask[1]); @@ -361,10 +374,10 @@ static void __restore_debug_registers(struct vmcb_struct *vmcb, struct vcpu *v) if ( v->domain->arch.cpuid->extd.dbext ) { - svm_intercept_msr(v, MSR_AMD64_DR0_ADDRESS_MASK, MSR_INTERCEPT_NONE); - svm_intercept_msr(v, MSR_AMD64_DR1_ADDRESS_MASK, MSR_INTERCEPT_NONE); - svm_intercept_msr(v, MSR_AMD64_DR2_ADDRESS_MASK, MSR_INTERCEPT_NONE); - svm_intercept_msr(v, MSR_AMD64_DR3_ADDRESS_MASK, MSR_INTERCEPT_NONE); + svm_clear_msr_intercept(v, MSR_AMD64_DR0_ADDRESS_MASK, MSR_RW); + svm_clear_msr_intercept(v, MSR_AMD64_DR1_ADDRESS_MASK, MSR_RW); + svm_clear_msr_intercept(v, MSR_AMD64_DR2_ADDRESS_MASK, MSR_RW); + svm_clear_msr_intercept(v, MSR_AMD64_DR3_ADDRESS_MASK, MSR_RW); wrmsrl(MSR_AMD64_DR0_ADDRESS_MASK, v->arch.msrs->dr_mask[0]); wrmsrl(MSR_AMD64_DR1_ADDRESS_MASK, v->arch.msrs->dr_mask[1]); @@ -595,22 +608,31 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) vmcb_set_exception_intercepts(vmcb, bitmap); /* Give access to MSR_SPEC_CTRL if the guest has been told about it. */ - svm_intercept_msr(v, MSR_SPEC_CTRL, - cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); + if ( cp->extd.ibrs ) + svm_clear_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); + else + svm_set_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); /* * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest * setting and avoid having to perform a rdmsr on vmexit to get the guest * setting even if VIRT_SSBD is offered to Xen itself. */ - svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL, - cp->extd.virt_ssbd && cpu_has_virt_ssbd && - !cpu_has_amd_ssbd ? - MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW); + if ( cp->extd.virt_ssbd && cpu_has_virt_ssbd && !cpu_has_amd_ssbd ) + { + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_W); + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_R); + } + else + { + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); + } /* Give access to MSR_PRED_CMD if the guest has been told about it. */ - svm_intercept_msr(v, MSR_PRED_CMD, - cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); + if ( cp->extd.ibpb ) + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); + else + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); } void svm_sync_vmcb(struct vcpu *v, enum vmcb_sync_state new_state) diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 43d3fc2498..f853e2f3e8 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -261,6 +261,10 @@ extern struct hvm_function_table hvm_funcs; extern bool_t hvm_enabled; extern s8 hvm_port80_allowed; +#define MSR_R BIT(0, U) +#define MSR_W BIT(1, U) +#define MSR_RW (MSR_W | MSR_R) + extern const struct hvm_function_table *start_svm(void); extern const struct hvm_function_table *start_vmx(void); diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index e87728fa81..ed2e55e5cf 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); void setup_vmcb_dump(void); -#define MSR_INTERCEPT_NONE 0 -#define MSR_INTERCEPT_READ 1 -#define MSR_INTERCEPT_WRITE 2 -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); +#define svm_disable_intercept_for_msr(v, msr) \ + svm_clear_msr_intercept((v), (msr), MSR_RW) +#define svm_enable_intercept_for_msr(v, msr) \ + svm_set_intercept_msr((v), (msr), MSR_RW) /* * VMCB accessor functions. -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:57:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:57:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502220.773938 (Exim 4.92) (envelope-from ) id 1pWYNh-0001oC-4Z; Mon, 27 Feb 2023 07:57:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502220.773938; Mon, 27 Feb 2023 07:57:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNh-0001o1-1F; Mon, 27 Feb 2023 07:57:09 +0000 Received: by outflank-mailman (input) for mailman id 502220; Mon, 27 Feb 2023 07:57:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNf-0000zt-81 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:57:07 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5353a6b3-b674-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 08:57:05 +0100 (CET) Received: by mail-ed1-x531.google.com with SMTP id cq23so22126117edb.1 for ; Sun, 26 Feb 2023 23:57:05 -0800 (PST) Received: from uni.router.wind (adsl-209.109.242.226.tellas.gr. [109.242.226.209]) by smtp.googlemail.com with ESMTPSA id b23-20020a50ccd7000000b0049ef70a2894sm2788272edj.38.2023.02.26.23.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 23:57:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5353a6b3-b674-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=62fJGVZ50pgC5Zj0lapAQX8/jn38WZfFE90N46rhqOc=; b=aeopOVF+ZmTM9E1XSIg18EmWxLfPTk6K/Zo8lH97FqBN4mxKZ9nhlE6xRx4Ch29nPT /20cPln2vSqnzPXVmUZXVge4IjKXCha/UR2tPxR2t9lxurOwF8ewtWFauKr+4dnWwFH6 5BFQ18Srn/Av6C+VgelkgNvtR6XZYiARrD+dnswZm6t3G4bqsA+coUhv+vNS4CCdhg76 FFIr4YictVrBJn+OCAST1Wz4kePyiANoCCaZ6QMiLmFcwBHiUzaiInfz49bF7EAoyFq6 G5p50jV8fzt8oW1bIMwY/e/sLc6xKuXxvnpv+GDfYuXVBK+3nL6vTUXSJ98+gz5YSn4B nfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=62fJGVZ50pgC5Zj0lapAQX8/jn38WZfFE90N46rhqOc=; b=BRRIYzzJgaAkpdGCRsneK2PByF8ijquiyR+fUVPZQ6KEa38yZSvL73YO4Mm8NItWSf lNNVpM/saWN2Zf2Mmp0llar9qFdX9IR21yVx5BCI5d6ucWK3ACWbPFrY3eTOByqodWnr Mvis68EUdsDmZNru6t2d3bt7Y8XroNJYhryJP7Q+qNQOamogqVt8YB2zgziyues3Muw+ TlD4ftfgDAz+FtYPQXaKbY6VpECJqVjshhsHnk9gz0Y7YDtinztESqCOn0TpWMt9nIj+ YLnq8uRtuXv3OV2wtyuiYKwIgJzbIvGmGPmYNCvBZBU+L//lB3QOSXrsJP7DtyJOBD98 rrzQ== X-Gm-Message-State: AO0yUKW4P8+BQLcxypiy1pV7C9jPdmk2oWseQuYEz0TPo6vLNRIoGwm0 24HbHgU5ygjB2sMpNCIAAWwbP1fguFAryQ== X-Google-Smtp-Source: AK7set++sPj47cXU0KyOEHvdPqoq+vL31REQK7S1la89qbPs5Slr4kKrDXazFIwBa/iQHf6X7Cnlyg== X-Received: by 2002:a05:6402:60d:b0:4ad:7c30:259a with SMTP id n13-20020a056402060d00b004ad7c30259amr24302872edv.2.1677484624048; Sun, 26 Feb 2023 23:57:04 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/4] x86/vmx: replace enum vmx_msr_intercept_type with the msr access flags Date: Mon, 27 Feb 2023 09:56:51 +0200 Message-Id: <20230227075652.3782973-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230227075652.3782973-1-burzalodowa@gmail.com> References: <20230227075652.3782973-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace enum vmx_msr_intercept_type with the msr access flags, defined in hvm.h, so that the functions {svm,vmx}_{set,clear}_msr_intercept() share the same prototype. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/vpmu_intel.c | 24 +++++++------- xen/arch/x86/hvm/vmx/vmcs.c | 38 ++++++++++----------- xen/arch/x86/hvm/vmx/vmx.c | 44 ++++++++++++------------- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 14 ++------ 4 files changed, 54 insertions(+), 66 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index bcfa187a14..bd91c79a36 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -230,22 +230,22 @@ static void core2_vpmu_set_msr_bitmap(struct vcpu *v) /* Allow Read/Write PMU Counters MSR Directly. */ for ( i = 0; i < fixed_pmc_cnt; i++ ) - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); for ( i = 0; i < arch_pmc_cnt; i++ ) { - vmx_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); if ( full_width_write ) - vmx_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); } /* Allow Read PMU Non-global Controls Directly. */ for ( i = 0; i < arch_pmc_cnt; i++ ) - vmx_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), VMX_MSR_R); + vmx_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, VMX_MSR_R); - vmx_clear_msr_intercept(v, MSR_IA32_DS_AREA, VMX_MSR_R); + vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); + vmx_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); } static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) @@ -253,21 +253,21 @@ static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) unsigned int i; for ( i = 0; i < fixed_pmc_cnt; i++ ) - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); for ( i = 0; i < arch_pmc_cnt; i++ ) { - vmx_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); if ( full_width_write ) - vmx_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); } for ( i = 0; i < arch_pmc_cnt; i++ ) - vmx_set_msr_intercept(v, MSR_P6_EVNTSEL(i), VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_IA32_DS_AREA, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); + vmx_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); } static inline void __core2_vpmu_save(struct vcpu *v) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index ed71ecfb62..22c12509d5 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -902,8 +902,7 @@ static void vmx_set_host_env(struct vcpu *v) (unsigned long)&get_cpu_info()->guest_cpu_user_regs.error_code); } -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, - enum vmx_msr_intercept_type type) +void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type) { struct vmx_msr_bitmap *msr_bitmap = v->arch.hvm.vmx.msr_bitmap; struct domain *d = v->domain; @@ -917,25 +916,24 @@ void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, if ( msr <= 0x1fff ) { - if ( type & VMX_MSR_R ) + if ( type & MSR_R ) clear_bit(msr, msr_bitmap->read_low); - if ( type & VMX_MSR_W ) + if ( type & MSR_W ) clear_bit(msr, msr_bitmap->write_low); } else if ( (msr >= 0xc0000000) && (msr <= 0xc0001fff) ) { msr &= 0x1fff; - if ( type & VMX_MSR_R ) + if ( type & MSR_R ) clear_bit(msr, msr_bitmap->read_high); - if ( type & VMX_MSR_W ) + if ( type & MSR_W ) clear_bit(msr, msr_bitmap->write_high); } else ASSERT(!"MSR out of range for interception\n"); } -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, - enum vmx_msr_intercept_type type) +void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type) { struct vmx_msr_bitmap *msr_bitmap = v->arch.hvm.vmx.msr_bitmap; @@ -945,17 +943,17 @@ void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, if ( msr <= 0x1fff ) { - if ( type & VMX_MSR_R ) + if ( type & MSR_R ) set_bit(msr, msr_bitmap->read_low); - if ( type & VMX_MSR_W ) + if ( type & MSR_W ) set_bit(msr, msr_bitmap->write_low); } else if ( (msr >= 0xc0000000) && (msr <= 0xc0001fff) ) { msr &= 0x1fff; - if ( type & VMX_MSR_R ) + if ( type & MSR_R ) set_bit(msr, msr_bitmap->read_high); - if ( type & VMX_MSR_W ) + if ( type & MSR_W ) set_bit(msr, msr_bitmap->write_high); } else @@ -1162,17 +1160,17 @@ static int construct_vmcs(struct vcpu *v) v->arch.hvm.vmx.msr_bitmap = msr_bitmap; __vmwrite(MSR_BITMAP, virt_to_maddr(msr_bitmap)); - vmx_clear_msr_intercept(v, MSR_FS_BASE, VMX_MSR_RW); - vmx_clear_msr_intercept(v, MSR_GS_BASE, VMX_MSR_RW); - vmx_clear_msr_intercept(v, MSR_SHADOW_GS_BASE, VMX_MSR_RW); - vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_CS, VMX_MSR_RW); - vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_ESP, VMX_MSR_RW); - vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_EIP, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_FS_BASE, MSR_RW); + vmx_clear_msr_intercept(v, MSR_GS_BASE, MSR_RW); + vmx_clear_msr_intercept(v, MSR_SHADOW_GS_BASE, MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_CS, MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_ESP, MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_SYSENTER_EIP, MSR_RW); if ( paging_mode_hap(d) && (!is_iommu_enabled(d) || iommu_snoop) ) - vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, MSR_RW); if ( (vmexit_ctl & VM_EXIT_CLEAR_BNDCFGS) && (vmentry_ctl & VM_ENTRY_LOAD_BNDCFGS) ) - vmx_clear_msr_intercept(v, MSR_IA32_BNDCFGS, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_BNDCFGS, MSR_RW); } /* I/O access bitmap. */ diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 0ec33bcc18..87c47c002c 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -802,7 +802,7 @@ static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) */ if ( cp->feat.ibrsb ) { - vmx_clear_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); rc = vmx_add_guest_msr(v, MSR_SPEC_CTRL, 0); if ( rc ) @@ -810,7 +810,7 @@ static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) } else { - vmx_set_msr_intercept(v, MSR_SPEC_CTRL, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); rc = vmx_del_msr(v, MSR_SPEC_CTRL, VMX_MSR_GUEST); if ( rc && rc != -ESRCH ) @@ -820,20 +820,20 @@ static void cf_check vmx_cpuid_policy_changed(struct vcpu *v) /* MSR_PRED_CMD is safe to pass through if the guest knows about it. */ if ( cp->feat.ibrsb || cp->extd.ibpb ) - vmx_clear_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_PRED_CMD, MSR_RW); else - vmx_set_msr_intercept(v, MSR_PRED_CMD, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_PRED_CMD, MSR_RW); /* MSR_FLUSH_CMD is safe to pass through if the guest knows about it. */ if ( cp->feat.l1d_flush ) - vmx_clear_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_FLUSH_CMD, MSR_RW); else - vmx_set_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_FLUSH_CMD, MSR_RW); if ( cp->feat.pks ) - vmx_clear_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_PKRS, MSR_RW); else - vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_PKRS, MSR_RW); out: vmx_vmcs_exit(v); @@ -1429,7 +1429,7 @@ static void cf_check vmx_handle_cd(struct vcpu *v, unsigned long value) vmx_get_guest_pat(v, pat); vmx_set_guest_pat(v, uc_pat); - vmx_set_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + vmx_set_msr_intercept(v, MSR_IA32_CR_PAT, MSR_RW); wbinvd(); /* flush possibly polluted cache */ hvm_asid_flush_vcpu(v); /* invalidate memory type cached in TLB */ @@ -1440,7 +1440,7 @@ static void cf_check vmx_handle_cd(struct vcpu *v, unsigned long value) v->arch.hvm.cache_mode = NORMAL_CACHE_MODE; vmx_set_guest_pat(v, *pat); if ( !is_iommu_enabled(v->domain) || iommu_snoop ) - vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, VMX_MSR_RW); + vmx_clear_msr_intercept(v, MSR_IA32_CR_PAT, MSR_RW); hvm_asid_flush_vcpu(v); /* no need to flush cache */ } } @@ -1906,9 +1906,9 @@ static void cf_check vmx_update_guest_efer(struct vcpu *v) * into hardware, clear the read intercept to avoid unnecessary VMExits. */ if ( guest_efer == v->arch.hvm.guest_efer ) - vmx_clear_msr_intercept(v, MSR_EFER, VMX_MSR_R); + vmx_clear_msr_intercept(v, MSR_EFER, MSR_R); else - vmx_set_msr_intercept(v, MSR_EFER, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_EFER, MSR_R); } void nvmx_enqueue_n2_exceptions(struct vcpu *v, @@ -2335,7 +2335,7 @@ static void cf_check vmx_enable_msr_interception(struct domain *d, uint32_t msr) struct vcpu *v; for_each_vcpu ( d, v ) - vmx_set_msr_intercept(v, msr, VMX_MSR_W); + vmx_set_msr_intercept(v, msr, MSR_W); } static void cf_check vmx_vcpu_update_eptp(struct vcpu *v) @@ -3502,17 +3502,17 @@ void cf_check vmx_vlapic_msr_changed(struct vcpu *v) { for ( msr = MSR_X2APIC_FIRST; msr <= MSR_X2APIC_LAST; msr++ ) - vmx_clear_msr_intercept(v, msr, VMX_MSR_R); + vmx_clear_msr_intercept(v, msr, MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R); - vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_PPR, MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, MSR_R); + vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, MSR_R); } if ( cpu_has_vmx_virtual_intr_delivery ) { - vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, VMX_MSR_W); - vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_TPR, MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_EOI, MSR_W); + vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, MSR_W); } } else @@ -3523,7 +3523,7 @@ void cf_check vmx_vlapic_msr_changed(struct vcpu *v) SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) for ( msr = MSR_X2APIC_FIRST; msr <= MSR_X2APIC_LAST; msr++ ) - vmx_set_msr_intercept(v, msr, VMX_MSR_RW); + vmx_set_msr_intercept(v, msr, MSR_RW); vmx_update_secondary_exec_control(v); vmx_vmcs_exit(v); @@ -3659,7 +3659,7 @@ static int cf_check vmx_msr_write_intercept( return X86EMUL_OKAY; } - vmx_clear_msr_intercept(v, lbr->base + i, VMX_MSR_RW); + vmx_clear_msr_intercept(v, lbr->base + i, MSR_RW); } } diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 0a84e74478..e08c506be5 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -644,18 +644,8 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, return 0; } - -/* MSR intercept bitmap infrastructure. */ -enum vmx_msr_intercept_type { - VMX_MSR_R = 1, - VMX_MSR_W = 2, - VMX_MSR_RW = VMX_MSR_R | VMX_MSR_W, -}; - -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, - enum vmx_msr_intercept_type type); -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, - enum vmx_msr_intercept_type type); +void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type); +void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type); void vmx_vmcs_switch(paddr_t from, paddr_t to); void vmx_set_eoi_exit_bitmap(struct vcpu *v, u8 vector); void vmx_clear_eoi_exit_bitmap(struct vcpu *v, u8 vector); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 07:57:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 07:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502221.773948 (Exim 4.92) (envelope-from ) id 1pWYNi-00025H-GT; Mon, 27 Feb 2023 07:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502221.773948; Mon, 27 Feb 2023 07:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNi-000256-D6; Mon, 27 Feb 2023 07:57:10 +0000 Received: by outflank-mailman (input) for mailman id 502221; Mon, 27 Feb 2023 07:57:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYNh-0000zt-RF for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 07:57:10 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55088ff7-b674-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 08:57:07 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id o15so19516482edr.13 for ; Sun, 26 Feb 2023 23:57:07 -0800 (PST) Received: from uni.router.wind (adsl-209.109.242.226.tellas.gr. [109.242.226.209]) by smtp.googlemail.com with ESMTPSA id b23-20020a50ccd7000000b0049ef70a2894sm2788272edj.38.2023.02.26.23.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 23:57:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55088ff7-b674-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kfd+upXaSlLKmbg4zugpjT75X2tZR4wPNkKQmCXr5iI=; b=lYjSUSdLDHn6VAmtg9ODvuSTjLpwHlp0BYYmCBAS6F56mkwSGEvJ+ZOIB3DXdcvjRt LaqJZAmXmCqTg0FI/6+3sZ0uM7PWyd7cynyehETs9yQyBIM9lS/PfGM56/i3QIcHBAH6 so0ufqMnkXIr7VQU96WM7ZA2oBr/qmeE6LjZNT3+HxNESd1sOUB4qB+JTUwVdJhfzUMn BBP8eATGk4hk29ZVfGu8aP7wVWWjnqxQcEfclWqZgxTKFuDoXfQ6QhPCKQIJQVuFq142 UyIBFyIKRF4lAi+mpEZfuQZvmwMLigTairKZnaCy6VtgvrQcXBWvC2XflZ0FQMAhUzhP PK6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kfd+upXaSlLKmbg4zugpjT75X2tZR4wPNkKQmCXr5iI=; b=wTB3cpNguhxXwXEUJ9fWZFB1ViC+uORJ7K6GHlSzf352cioAGv1STyVVGXPspYIbvf Rs9jRIqIlGcrU9cXNbKzlSXl0QMwgPC6wkrFieBxckX3QXIdsr0wIUBmO0mfbLVZha8d MpnWLX3xCkjlxkubR0J60XcY+HAmw8dhbTVVwMp7wYPbFQYtwn34AOtWU3Apq9qmxY1M QYf31PDk1JdqMgxsL1PTlx0uBqnEF0Yz+Yr2bMACzKIpaQhMHJFP7bs4ZUDKyB2BcZk/ S2OZq8Yx8srtpJgnJycIZmjZasmzRr7YWWbggo5z57i8dS0yPU4NxJW/Tj1HFQIHEH4U wcmA== X-Gm-Message-State: AO0yUKUJx1igYSycycl/PwMW4txvZlGyKWL9i9gai6UkLU8WebBIrTH6 n6i14ErGBzOLalKau0zzpkCZzDU74X1vWg== X-Google-Smtp-Source: AK7set+XRzjKrDAJ1gyPWG0oFLRCggpXfNaFq0J9FhzdyGfvANCaUg7NBW/IBn9IwWPWIzT07gnO+A== X-Received: by 2002:aa7:d705:0:b0:4ac:89b:b605 with SMTP id t5-20020aa7d705000000b004ac089bb605mr25859620edq.22.1677484627312; Sun, 26 Feb 2023 23:57:07 -0800 (PST) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH 4/4] x86/hvm: create hvm_funcs for {svm,vmx}_{set,clear}_msr_intercept() Date: Mon, 27 Feb 2023 09:56:52 +0200 Message-Id: <20230227075652.3782973-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230227075652.3782973-1-burzalodowa@gmail.com> References: <20230227075652.3782973-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add hvm_funcs hooks for {set,clear}_msr_intercept() for controlling the msr intercept in common vpmu code. No functional change intended. Signed-off-by: Xenia Ragiadakou --- xen/arch/x86/cpu/vpmu_amd.c | 10 ++++----- xen/arch/x86/cpu/vpmu_intel.c | 24 ++++++++++----------- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/hvm/vmx/vmcs.c | 4 ++-- xen/arch/x86/hvm/vmx/vmx.c | 2 ++ xen/arch/x86/include/asm/hvm/hvm.h | 28 +++++++++++++++++++++++++ xen/arch/x86/include/asm/hvm/svm/vmcb.h | 4 ++-- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++-- 8 files changed, 55 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index ed6706959e..a306297a69 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -165,9 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) for ( i = 0; i < num_counters; i++ ) { - svm_clear_msr_intercept(v, counters[i], MSR_RW); - svm_set_msr_intercept(v, ctrls[i], MSR_W); - svm_clear_msr_intercept(v, ctrls[i], MSR_R); + hvm_clear_msr_intercept(v, counters[i], MSR_RW); + hvm_set_msr_intercept(v, ctrls[i], MSR_W); + hvm_clear_msr_intercept(v, ctrls[i], MSR_R); } msr_bitmap_on(vpmu); @@ -180,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) for ( i = 0; i < num_counters; i++ ) { - svm_set_msr_intercept(v, counters[i], MSR_RW); - svm_set_msr_intercept(v, ctrls[i], MSR_RW); + hvm_set_msr_intercept(v, counters[i], MSR_RW); + hvm_set_msr_intercept(v, ctrls[i], MSR_RW); } msr_bitmap_off(vpmu); diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index bd91c79a36..46ae38a326 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -230,22 +230,22 @@ static void core2_vpmu_set_msr_bitmap(struct vcpu *v) /* Allow Read/Write PMU Counters MSR Directly. */ for ( i = 0; i < fixed_pmc_cnt; i++ ) - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); for ( i = 0; i < arch_pmc_cnt; i++ ) { - vmx_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); + hvm_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); if ( full_width_write ) - vmx_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); + hvm_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); } /* Allow Read PMU Non-global Controls Directly. */ for ( i = 0; i < arch_pmc_cnt; i++ ) - vmx_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); + hvm_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); - vmx_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); + hvm_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); } static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) @@ -253,21 +253,21 @@ static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) unsigned int i; for ( i = 0; i < fixed_pmc_cnt; i++ ) - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); for ( i = 0; i < arch_pmc_cnt; i++ ) { - vmx_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); + hvm_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); if ( full_width_write ) - vmx_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); + hvm_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); } for ( i = 0; i < arch_pmc_cnt; i++ ) - vmx_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); + hvm_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); - vmx_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); + hvm_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); } static inline void __core2_vpmu_save(struct vcpu *v) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index eb144272f4..e54dc08e8a 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -288,7 +288,7 @@ svm_msrbit(unsigned long *msr_bitmap, uint32_t msr) return msr_bit; } -void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) +void cf_check svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) { unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); @@ -303,7 +303,7 @@ void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) __set_bit(msr * 2 + 1, msr_bit); } -void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags) +void cf_check svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags) { unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 22c12509d5..3d0022f392 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -902,7 +902,7 @@ static void vmx_set_host_env(struct vcpu *v) (unsigned long)&get_cpu_info()->guest_cpu_user_regs.error_code); } -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type) +void cf_check vmx_clear_msr_intercept(struct vcpu *v, uint32_t msr, int type) { struct vmx_msr_bitmap *msr_bitmap = v->arch.hvm.vmx.msr_bitmap; struct domain *d = v->domain; @@ -933,7 +933,7 @@ void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type) ASSERT(!"MSR out of range for interception\n"); } -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type) +void cf_check vmx_set_msr_intercept(struct vcpu *v, uint32_t msr, int type) { struct vmx_msr_bitmap *msr_bitmap = v->arch.hvm.vmx.msr_bitmap; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 87c47c002c..d3f2b3add4 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2765,6 +2765,8 @@ static struct hvm_function_table __initdata_cf_clobber vmx_function_table = { .nhvm_domain_relinquish_resources = nvmx_domain_relinquish_resources, .update_vlapic_mode = vmx_vlapic_msr_changed, .nhvm_hap_walk_L1_p2m = nvmx_hap_walk_L1_p2m, + .set_msr_intercept = vmx_set_msr_intercept, + .clear_msr_intercept = vmx_clear_msr_intercept, .enable_msr_interception = vmx_enable_msr_interception, .altp2m_vcpu_update_p2m = vmx_vcpu_update_eptp, .altp2m_vcpu_update_vmfunc_ve = vmx_vcpu_update_vmfunc_ve, diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index f853e2f3e8..dd9aa42d0a 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -224,6 +224,8 @@ struct hvm_function_table { paddr_t *L1_gpa, unsigned int *page_order, uint8_t *p2m_acc, struct npfec npfec); + void (*set_msr_intercept)(struct vcpu *v, uint32_t msr, int flags); + void (*clear_msr_intercept)(struct vcpu *v, uint32_t msr, int flags); void (*enable_msr_interception)(struct domain *d, uint32_t msr); /* Alternate p2m */ @@ -658,6 +660,20 @@ static inline int nhvm_hap_walk_L1_p2m( v, L2_gpa, L1_gpa, page_order, p2m_acc, npfec); } +static inline void hvm_set_msr_intercept(struct vcpu *v, uint32_t msr, + int flags) +{ + if ( hvm_funcs.set_msr_intercept ) + alternative_vcall(hvm_funcs.set_msr_intercept, v, msr, flags); +} + +static inline void hvm_clear_msr_intercept(struct vcpu *v, uint32_t msr, + int flags) +{ + if ( hvm_funcs.clear_msr_intercept ) + alternative_vcall(hvm_funcs.clear_msr_intercept, v, msr, flags); +} + static inline void hvm_enable_msr_interception(struct domain *d, uint32_t msr) { alternative_vcall(hvm_funcs.enable_msr_interception, d, msr); @@ -916,6 +932,18 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) ASSERT_UNREACHABLE(); } +static inline void hvm_set_msr_intercept(struct vcpu *v, uint32_t msr, + int flags) +{ + ASSERT_UNREACHABLE(); +} + +static inline void hvm_clear_msr_intercept(struct vcpu *v, uint32_t msr, + int flags) +{ + ASSERT_UNREACHABLE(); +} + #define is_viridian_domain(d) ((void)(d), false) #define is_viridian_vcpu(v) ((void)(v), false) #define has_viridian_time_ref_count(d) ((void)(d), false) diff --git a/xen/arch/x86/include/asm/hvm/svm/vmcb.h b/xen/arch/x86/include/asm/hvm/svm/vmcb.h index ed2e55e5cf..dbe8ba89cc 100644 --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h @@ -585,8 +585,8 @@ void svm_destroy_vmcb(struct vcpu *v); void setup_vmcb_dump(void); -void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); -void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); +void cf_check svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); +void cf_check svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); #define svm_disable_intercept_for_msr(v, msr) \ svm_clear_msr_intercept((v), (msr), MSR_RW) #define svm_enable_intercept_for_msr(v, msr) \ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index e08c506be5..f2880c8122 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -644,8 +644,8 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, return 0; } -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type); -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type); +void cf_check vmx_clear_msr_intercept(struct vcpu *v, uint32_t msr, int type); +void cf_check vmx_set_msr_intercept(struct vcpu *v, uint32_t msr, int type); void vmx_vmcs_switch(paddr_t from, paddr_t to); void vmx_set_eoi_exit_bitmap(struct vcpu *v, u8 vector); void vmx_clear_eoi_exit_bitmap(struct vcpu *v, u8 vector); -- 2.37.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 08:26:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 08:26:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502253.773958 (Exim 4.92) (envelope-from ) id 1pWYpG-00085C-48; Mon, 27 Feb 2023 08:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502253.773958; Mon, 27 Feb 2023 08:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYpG-000855-1J; Mon, 27 Feb 2023 08:25:38 +0000 Received: by outflank-mailman (input) for mailman id 502253; Mon, 27 Feb 2023 08:25:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYpE-00084z-0W for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 08:25:36 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e3c592f-b678-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 09:25:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8094.eurprd04.prod.outlook.com (2603:10a6:102:1c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 08:25:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 08:25:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e3c592f-b678-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AwnAhwEEnhFb76I7BwZf9s6xyExVNndeAvydKlIHMi9+5EqMfsb+gjZ3s6CLJaIuFBiZBRB+d0dT5k9eI1YUtMonkSUEEE031Usx15AU7UA5lNGtHv5V+hP0tu2fD24bxRQr0ZNLGQ+9CVTE9adTmFhn+i6yu7N4gu9zc+oif/lkORHxClc5TVo93PfS6agiO6dHt+3TJSbZLC0ncL0zTQHH9q+1hZ7cGtSX0FYANCS0XdqESiHHmPRyuSKhv1jm72quu2Dbo63R0WFAIXqIq9tnMxDwZ1YIVDWGF1NtFUC1R38yIBGYTALY+DT1iDTBFRN0CrrGyROvLdR9VgVBRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sfyl7/Y7lDf78h9hLB+9Q/6fx14q15njNB5cRcJb5/w=; b=CrZTGAyP4gl8uf7NTLiR4dAjRU5JbzmIIh5RER6woA8QKqKOa6KyxHYExlK+IJlPrZE02kpyuWzRak54F2KZpwUPqazFAh1KqnKFIKTJDCDyJYu+yL+wW83+XDJE0b/28jxIAyC4QHffvvZ1iGXvCJ7XO1q7yV1z3P1XqfOAqZWGybT2TT3T7bajnMgiuT7vRii7HKJFh/KR/SZtRQTAni0mtuo7L84hZ+vbOCxcgTq2rDM+GBtb1Ikv+7IksJZod+D/V3JeVXb1fYH5US12YVqvc8S1rBWPEcK1ETg+UAT26HoEKQc5PlvwMkQapVV0rrQZr0371mdVVHGF//cbIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sfyl7/Y7lDf78h9hLB+9Q/6fx14q15njNB5cRcJb5/w=; b=kOmSdqyN6jufJfpgWwr2U50fsOVLv+OHf+Prd+Zxah8FU1GNWOvNnZlfRcQtCrZiYh3B4Xe/NLC/aVmwx3zY1W7xReH2NTyS23iKeSyMGNENhbN0bw0kvuWcoZAUOswKnOt9GM57LwoWVl+sj+R09ElOwUPVyNccWIWfaY00NHE+QcgdHtQRc2bgpafGEeu6PeIknczpRQzNQoF5AIHs1Q5Tcp9XG1voV96pHfzs5cgUlsmtQLDB1NnM1iXi3TysmniXAxp87Rb692iS1DHwTyZyy9oWsLz/lOrROKEVg4ozf7UndDsBSsdyUw/bV42v0OeM1DoKiKQTSxHCUWP1ug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <30b906ef-9c93-afec-14f5-4623cd24b273@suse.com> Date: Mon, 27 Feb 2023 09:25:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org References: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> <8c4aa332-07ee-e91a-50f1-ced9e36db2a1@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0170.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8094:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f661f18-538b-4b01-9d90-08db189c3132 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0xLRazXPDRCVS6k2qC4lPChd2XIjGD67oAvxlXMEyXLAIJO5oARK+6xhc2Ljm8DHMRMqK7umlyVXPnvFojffpbsewVDN2zUQsUpUE9PvuGZAlsHAUzmzU05qytS/9rrYzRdlyGEAIz4+yP7kdPIJF+Ck+4xk9SGITQFTkwTWXFHhGnoGphCH6Hnm23J5wgT/At7wtgE4T8m6vhsP6Ct1OWHQ3a3JjBqPN1oTnTPX1UthnaMr5MA2tkInYquz6ToM/C/3bA+n/bjbr2jTYT9HvuZ+L6ZcDB2TW0pZq64NdjFe13BQCGGG+HO6H3iYdUzlPffroGS+Pwz0FFJ70NtQObSWdQwSnXPudUTaIg1BPT5TZ6zO17vrKNzG7RutGKs8BN4vHoOhWYQgJqSxhuig6bSnRU6U7OMKe1zvMWnUlHEDzzMuVLmfehy8/NTERjJlkJtxORrUI2Zz2imnOR12Yr41RWZrhfjz04kjHg2ASqkzSZA94UuM3eQBImy9yijavsbMfIEZKJCnPEkHhuR2a6uMf/lIVQ7JOXY/DosFlEymGmYvvZqJQVcHP4WX+775APD8u7EZ2Qj+rgRoKeN5HUoWuWdL9RGS2o5jdhMPYH2lJ2wWKMImGYBBQ0Jx6T7mHXY/14vHtBjtARYA+t//0T7oF6ffvKWoRpYfhAyYK6MnUM53DfS1MFB55syef2VkFLGJih2OYBb2VdiWrfsyuA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199018)(36756003)(5660300002)(8936002)(7416002)(6506007)(6512007)(53546011)(38100700002)(83380400001)(26005)(186003)(2616005)(86362001)(31696002)(316002)(41300700001)(66946007)(54906003)(66476007)(4326008)(66556008)(6916009)(8676002)(478600001)(6486002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW9pcXB0Nk1qQnFFNy9rUFViRjJmSlFMSHZVR3RyYXVmOHR4Z3dKMTI2K2VQ?= =?utf-8?B?MHRlaG1QNG8xeDdrdkd1TmtFODEyeDZVSExUeVZYSXNoNGUzQk9CM21ZaC8z?= =?utf-8?B?ZGlIMzhHUG93OHV5OVhYVk9TWmw5bFhadWZ4K3oyaURGUmZkaVYwTTJSbGY3?= =?utf-8?B?TW9aOGFNeEpwMmhKR1orMlYrWkFLOUpjMjV4RC9hZ0k3bFVaRDRHZURraitM?= =?utf-8?B?QmQ5MTRnNlE5VFEvMFZMdjdqN2EzcnZLYXBLNTFveFk1S29ZUDEzU3JZaHJn?= =?utf-8?B?Zm5PN0pYQ2UrenM2NXR3M1c5cmtWSStvazFpWE5pSnNKUnJKdCtVVi9ETU1l?= =?utf-8?B?cU5JMGNobVlsZWxXTkMrVmljbHF1WFpMK0VvVW9KaVpUMzYzZzQ0bGU0MWI2?= =?utf-8?B?VlM4dXl6Y05zZUxGYmVwYTFtVHFyM0FHY1Y3c0RTbk9DbUZLNnl6RWZ0R2kz?= =?utf-8?B?V2x2cFhUNTVSOTFOc05OS2RMMG1iSkgrVmJTNE0vOVpWWHBBdER3c3ZxVFJD?= =?utf-8?B?ais3ejJoVnhwdlNuZXlaeFpUZFdJaXYzckMwaExpU2k0SktreDJIb0dJRTd5?= =?utf-8?B?NkkyYXRjeVh5aE1vYTlsR0F1TzEzUEg5SzM5NmcwVXFoZmkwYmdXc0pnRHI3?= =?utf-8?B?L2pZM05KaExVeno3UTYxVVJ5eTJpY09uNG9GaHJid1JXamVITDA5Y2orcDJh?= =?utf-8?B?QkQzQmVHZUpYdXpQQWFtaDByU2xxTXhvTHNKTHhxQzlqTXVFL2ZkSThaN3VC?= =?utf-8?B?cDRZRHNjWjdYT1prR015Zi9VZ0cwaTk5RXpnanYvRktwWkkraHBELytVdlgz?= =?utf-8?B?U093US9GQjE4czZXQ0FVLzgrUDJLNkxSWGV6T1R4ZGZRejhIYTRZb3ZoSE41?= =?utf-8?B?Vk1IOFZpZE5RWEx3SVQ4YWVhdC9DMWlSUUdVa2VkL1hyNVhBQ1FKMFFCOVNN?= =?utf-8?B?aGdkNUlqcUJtZm5RTXV2UUlKMUgyRmx4S0lPQkJBam5DaWZTNlZRM20raEVQ?= =?utf-8?B?VGJxQzlxandPS2FSRHllaUJJbmlMZ1hPQTJsMEh1ODB1cVJINE43UnlENVZW?= =?utf-8?B?NStlNWFyS1BhbjM0cVFFdUhJWGdycDJnKy80VHFYVEN2R2xyMjg4OG9iV0hi?= =?utf-8?B?UzRnUm4yRFNPVjh3VEhicFd4bGc3cnhjTUxXbG9sTmRaY3lwb2tEcmVZaitV?= =?utf-8?B?MGY0ZEpETXQwd21BUFY2M3B3cmFLdmdrUS9WczNncEwvZnVYa2NvbWMybDNC?= =?utf-8?B?eVB0elBDN24zdFpKZXlFdnZqQjF2ZGh0alloaDBIY1dON2loR1ZWS3pWVWQ5?= =?utf-8?B?L1lvNmUyZWlNOUpEOFp1NGVXK3Zxd28wZ3c0anZJYUtTNWg2Snk2OW1xY29r?= =?utf-8?B?QnlSd1JlNEZ2a284QUN6bG9Zem1JZGluWXhCREhzZDh4Z3Q2eWN4MS9lM0NQ?= =?utf-8?B?SXNaVjEyN1ZKc1k1bUNSOXpzenRDeW9peTIrSEJtYmQ5ZXhlWi8zb1pWVXFl?= =?utf-8?B?ZXRUNDFWQUN2czd1ZVJZbkZ5WTNFWUIvZHFYYzBzUXhJSElYTUNwaVpzNDNI?= =?utf-8?B?dHFOdzZDSEpJRFQ2Vmp2SXN3eXlQWEljazN3dElTMFVxV2t6UGtacHZvN3M3?= =?utf-8?B?ODhnMmU4RzJEZVhHWks2cmsraCtZdDBkTFFITnRuck85UG9sRk9USWc2R2RO?= =?utf-8?B?YnNwdHdiOFhGTU1FVW1JM3J0YVZnQUFUY3JvcXdHNlZ0UGpxQUM4dmpYZWtE?= =?utf-8?B?ZnNDQXRFZktUck90aHB0TzFRb3MxTWkrY2FhL2ZuNytCK2xuN3Vha0pxSTFD?= =?utf-8?B?U3BLdjFCUjQzUXltZTkrSm9NWlRvODYrMTRpWEVKOG51RjllWHFRaVorMFJu?= =?utf-8?B?RUJjNHJ2c2RDelIwbTg4R2lQSXRLb1ZQVktLK1NLZGhETitmcVdzR3c4dWxJ?= =?utf-8?B?NHlaSjFuN2pjemFOcDRQTktZRzhTWWJWcGM2eUJwdHVqQUllMjlxd2cxMEdZ?= =?utf-8?B?ZTFocG1pa29UZUsydTg2SktBRmt3c0lPU1ZvODFkdm9nemRMcFNrcEdRa1pS?= =?utf-8?B?dFU5Mlk1cnZ3b3pwd080a2YwaGZwU0pKZXZUMENzU2V2bUdqcERaN0UxWG1B?= =?utf-8?Q?WoyTg8sX/a33xqXqWrnNNmnMM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f661f18-538b-4b01-9d90-08db189c3132 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 08:25:32.7266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XuIOllO1SNQb+6rEifm2R+KdOa8/LUc9bN74t4/PpS/ljOVd2Xi0IJ6P1rZe+2al5mmqEo6UGL0wXtrjqObRng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8094 On 24.02.2023 23:55, Demi Marie Obenour wrote: > On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote: >> On 19.02.2023 03:46, Demi Marie Obenour wrote: >>> --- a/stubdom/configure >>> +++ b/stubdom/configure >>> @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" = "x"; then : >>> if test "x$extfiles" = "xy"; then : >>> ZLIB_URL=\$\(XEN_EXTFILES_URL\) >>> else >>> - ZLIB_URL="http://www.zlib.net" >>> + ZLIB_URL="https://www.zlib.net" >>> fi >> >> In v3 you said that this URL can't be used anymore for the version we're >> trying to fetch (which I can confirm). Leaving aside the question of why >> stubdom was never updated in that regard, what use is it to update URL >> (without even mentioning the aspect in the description) in such a case? >> (I haven't gone through any of the other URLs again, so there may well >> be more similar cases.) > > Main advantage is that it will fail securely rather than downloading > whatever random code an MITM attacker put in there. As said before (and implied here): At the very least you need to mention the aspect in the description. But then wouldn't things be failing equally securely if no (non-working) URL was put in place, or one which is guaranteed to yield an error but makes obvious that no real URL is meant? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 08:29:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 08:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502257.773968 (Exim 4.92) (envelope-from ) id 1pWYt4-0000Vw-Kd; Mon, 27 Feb 2023 08:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502257.773968; Mon, 27 Feb 2023 08:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYt4-0000Vp-HI; Mon, 27 Feb 2023 08:29:34 +0000 Received: by outflank-mailman (input) for mailman id 502257; Mon, 27 Feb 2023 08:29:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYt3-0000Vj-5v for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 08:29:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db78914e-b678-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 09:29:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 08B23219E9; Mon, 27 Feb 2023 08:29:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B169013A43; Mon, 27 Feb 2023 08:29:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MVyIKepp/GNJOAAAMHmgww (envelope-from ); Mon, 27 Feb 2023 08:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db78914e-b678-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677486571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94d+MxmPoJb4+Q2TGJQjnS7ST674rFseImevc/csRBY=; b=eKktAwg5P+jt+s57UaDY4da/wjL/jcBwPfX8K6wtKyaUvxdBQJYCL8WJ8JnOq7wuy7MTTM 7LDfxMM8qxl6Guuztcm1c2I+LZgwlwsL1BObu972dc/+vOiZy4BYG0AjDPXS9aIUZnT0ig lSAYoCjbZxSImUm+wOxspFLngP6TWS8= Message-ID: Date: Mon, 27 Feb 2023 09:29:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and index Content-Language: en-US To: Tom Rix , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230226163429.2351600-1-trix@redhat.com> From: Juergen Gross In-Reply-To: <20230226163429.2351600-1-trix@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------OkfDc060i77ItM0rXRTMchNL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------OkfDc060i77ItM0rXRTMchNL Content-Type: multipart/mixed; boundary="------------raDtPFfI0jd0xZRsd3ztGYmg"; protected-headers="v1" From: Juergen Gross To: Tom Rix , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and index References: <20230226163429.2351600-1-trix@redhat.com> In-Reply-To: <20230226163429.2351600-1-trix@redhat.com> --------------raDtPFfI0jd0xZRsd3ztGYmg Content-Type: multipart/mixed; boundary="------------WswNWS6AXr0AlqNVcgpIdz0Q" --------------WswNWS6AXr0AlqNVcgpIdz0Q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDIuMjMgMTc6MzQsIFRvbSBSaXggd3JvdGU6DQo+IGJ1aWxkaW5nIHdpdGggZ2Nj IGFuZCBXPTEgcmVwb3J0cw0KPiBkcml2ZXJzL25ldC94ZW4tbmV0YmFjay9uZXRiYWNrLmM6 ODg2OjIxOiBlcnJvcjogdmFyaWFibGUNCj4gICAg4oCYcGVuZGluZ19pZHjigJkgc2V0IGJ1 dCBub3QgdXNlZCBbLVdlcnJvcj11bnVzZWQtYnV0LXNldC12YXJpYWJsZV0NCj4gICAgODg2 IHwgICAgICAgICAgICAgICAgIHUxNiBwZW5kaW5nX2lkeDsNCj4gICAgICAgIHwgICAgICAg ICAgICAgICAgICAgICBefn5+fn5+fn5+fg0KPiANCj4gcGVuZGluZ19pZHggaXMgbm90IHVz ZWQgc28gcmVtb3ZlIGl0LiAgU2luY2UgaW5kZXggd2FzIG9ubHkNCj4gdXNlZCB0byBzZXQg cGVuZGluZ19pZHgsIHJlbW92ZSBpbmRleCBhcyB3ZWxsLg0KPiANCj4gU2lnbmVkLW9mZi1i eTogVG9tIFJpeCA8dHJpeEByZWRoYXQuY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg0K --------------WswNWS6AXr0AlqNVcgpIdz0Q Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WswNWS6AXr0AlqNVcgpIdz0Q-- --------------raDtPFfI0jd0xZRsd3ztGYmg-- --------------OkfDc060i77ItM0rXRTMchNL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8aeoFAwAAAAAACgkQsN6d1ii/Ey/3 1wf/cHgHTwEvMmGQWUwEoPDOEKv5h+oG/SVBjnAKwI4iHHUuH/10cmg5eno363lVgBjFwpbn2r0q 7VhfWK0hARtIrS0/f3jAlXWWCaPbprbLkkl+BNhAAqbjwJskxfCzfc+WZ7NjrDgF9Y+uoJKmHTwe 2biV511StPIzc6/vhOK+tmQxqEfRk76jBmN4Rp5DPLghJpp2fY+byPU7KDVXedUTUQ0f1wr2qIpB eObWn8TNixmChAfarLNH9sUZdhbxtVLwOf8kZf3jU3LQb2BU/9TtvyMMC+4CiNPEzNi0CayzgNrY I3rzQNGOrVyR/Ip3HpRUeE71kwJgZEjpRQmBlT2XXA== =T5v7 -----END PGP SIGNATURE----- --------------OkfDc060i77ItM0rXRTMchNL-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 08:36:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 08:36:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502263.773978 (Exim 4.92) (envelope-from ) id 1pWYzD-00023H-HN; Mon, 27 Feb 2023 08:35:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502263.773978; Mon, 27 Feb 2023 08:35:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYzD-00023A-Cl; Mon, 27 Feb 2023 08:35:55 +0000 Received: by outflank-mailman (input) for mailman id 502263; Mon, 27 Feb 2023 08:35:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYzC-000234-4J for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 08:35:54 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe12::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bef75953-b679-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 09:35:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7658.eurprd04.prod.outlook.com (2603:10a6:10:20d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 08:35:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 08:35:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bef75953-b679-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rh89IzMG7tFF7htOQb5tIrEwwsLc7hX1OMqK8lU9j52R10QOMZW4UWd1t06dNcF8ixPR8CUg40g8UmSiQKHjQQLojYCApQOCvpxB7YkYgp8N47azooUQtTikDgmi/hERIorQhRkxVxQpnz9Bxlnw3OGM+sgYXQlgmZcUuBrIMmSMfMprWZyUIng8pmjpr5HjNBr7GtPsTLg5VuuvtnwdUMgBMG0UdrP76M72YX7I5LvBOHaB6ueJ6gRmy4i5pty3eSEEcMToIXLo/7W6SMbbfEqI2eya5FCFUqyV8fa0Qu+XjXsalHK0v087RYZEva27U+ZFN4mhxs1uBmpjqBZjwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJsCtXs2A9QpQpcRy3pfyH7G3HrZXceaoj8HKqm1iII=; b=VkKMvn25UakVFZ7Er8dUctcaBtOZ+zxbvEySXlfMUBzt/qZfbch84Lv9i970oJlmSJYcYwpcPVr0k8wBcyccDO1TUiQyFrQzT/QcbpejkbfVa0C1A+n2NTCQ5leyT7BEbjJ0MI7DYH1bpnu/Z8fyf+RQnEU4sYRkAaEvtHBeJL2yOLsIhI+dGGy7u7xn2MYokxFi6MlXiKmQYQENYGq+JqnzLTSSG2l+WrZigoLQsT/TabLx8RNsuT4sjsrKmwkdCVNIZQtzWdrA3KXzytC7tBM9mwUbOMhZN1hr2JX5z9/9p4v1mBH65W+rGfxAr9NajftkflTiiQXht1yAIjVvJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJsCtXs2A9QpQpcRy3pfyH7G3HrZXceaoj8HKqm1iII=; b=o7OgGN/B/R/RH73BlPhKNXOs6w8pjmEJoQ6a/7vk69E0dRWNyaOdmmAUVBUfXZwJp/CWBc4r6t2NMkJ2JApwY0g9m9+ga0PtquufzdQtfX091qgIAcyl3jiKjITqgl1lx0vfyEdHwJtZ1MNRy/KruwEd76e1Af2fsKKbPhSwURU4y/ibjJvvAksbN5N/Sj59fjvb6aqI2VjHK2vgLsG3I1wxaQI9FFhl0LJp9JvUQWMT4K7ivbZ7sXs3WeuQ0mChwNSa969hNCa5yR9BLd77VrjEi+3eo1qXPQePpOuAtdS2Gs4s6BLKSGVNHb8JMSuo6KvsDghFLxpWpSKen71/aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 09:35:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7658:EE_ X-MS-Office365-Filtering-Correlation-Id: 60158f85-6b36-4106-ca7a-08db189da271 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IlTB6JxvsjDyJT/JKUNw3cFVN48txs/jVPurmfB3ueKJZ/fetO97rjWEnwpeibOV1whi96qTdjVxhEf5OCySf3Q5KzP69fR4Lje9WzTYGngWRAz+krlLCG0CENnMl+fA0cB3jvWndB3YqOKA2XAgWCzTgjflbCyZncnykEMpNbcT6BB1/Y9YPR4dJiyNdc5yRyGeo7Z/EprMUIc3p7skve3OPgeLpvQT/S6Rwvyb4AALEpPaGdX+ZaAZWHx/kV8L6+ShZ2frH8wCtqbAYAdx/60b1sLJbJPoN8WAW342vlIzDs4D4nnS14eCdx5eQFZWejhaDvCA9uGjSbvdV3zylEF/h9Hkl9qYcS7zq9d4raGmuBBMLzmDL0FH7wg2g0Jz9YArboh3P7sCuhr/06QJGE/Y7Vcfm0c8Ee5T1erp7w/Jlnlx78625IhR2cy0bDIXUUQlP33vW/JEUVmua+RIDHp6VHJFxTX7adLLtLJGVSruj3HlRHYFMlOipmxwlg/zn0bOpWT6pxTETYHF8zGeMG7MI6TviQZYN2enLtjVzsMDMeY5ooNAUeeiiiiqHs3klmMzYVWf6JiDgmA6xjmt0LWruVLcM9U5taLs5K837MLQVpUdrugayrFcQdHLfMy0Nlpwa/VUFVg3Sk24q1kwfiXgIWJPtvQOdw1NS7haHbn4JE5xyLBssMuJZ6miMIR/uK7wBl8Uv0sTd1INN0QJFEJ0f3t4+xiv+YhOr78A7zrCcTprts6Jlt7OBRs782imwiv+zbC6iwVAufjw/jWnzw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(396003)(376002)(136003)(366004)(451199018)(5660300002)(41300700001)(83380400001)(66476007)(66946007)(66556008)(4326008)(8676002)(6916009)(38100700002)(36756003)(2906002)(31696002)(86362001)(8936002)(2616005)(966005)(6486002)(478600001)(66574015)(54906003)(53546011)(186003)(26005)(316002)(6506007)(31686004)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck15ZEh1RW43OWJob21oNUJIbkdaTiszblRGNzF3dzZ5bms1V0xPNzNYcWVH?= =?utf-8?B?OThtajFNTk1HSnhJdVUxc1R6K3BqZDFGNzgvbDRJajFMemZGRVNqMzI1Ukgy?= =?utf-8?B?dTR1WHFvbzJPVmNoY0ZuZURhbWRiYVhJQkhiZExDQzgrK210ZmFwdysxMXNC?= =?utf-8?B?TXZ1V3BEb1lOT3hRcFEvR0NtY3VFeWpRRDZiOFZFWmNHNG5VaXdoaVBzWWdP?= =?utf-8?B?aUlCRm1meXZaVEFpMER0S09LdEkyRWtZOW0wbUhwRnJVTC9tSjczYVNQVTJx?= =?utf-8?B?TE5kbTRpTWQ3R01udUZsVHNiaGhpdkVmNFh3TTF3emtwK042MDRVdnNISjl4?= =?utf-8?B?bmp2cVU0MFE0NXNDeTYySUxRRUFuQXJwZ1J6ZUxyMmkrODdqSnlHLzlCSmV3?= =?utf-8?B?MFBSMXJpYVR4RkZRc2hkTWpnb25YODZFQWNQeXdvbEw5RzFYa2V3WFUra2V0?= =?utf-8?B?SlRQMVJXSFNza1ByYkFsYllneFM4cHZRSUl2di9XeUVOVjNxMGx3UjdpL1cz?= =?utf-8?B?cTlIbGgvUFZlYlRDeVlJNUl3S2xhNExSUmVNVW9iN1BTQVBuak9QTDRacmNz?= =?utf-8?B?dEVUSlNHQlhxbnhZekFUajcra2hOOU1VN09lTTJiS3lxT05zRzJYZ2ZDU1hw?= =?utf-8?B?WDZsajBLNCs5Q01HNG1CQVFzaHFseHJmZjFGQ3dYa1FNc3NBZStIQjY3eGxu?= =?utf-8?B?RlJrR0sxTnFzUFZXVXdJdFVTSHVKQ0JoRW5IWUFjaGpiV2lESmYrR3NhaFRm?= =?utf-8?B?K2lPdVA1UGE0cnJKZ29vUi9iWENlWCtaMm90TVBtMzd6TlJTczFJNlVYbkpj?= =?utf-8?B?ekZZWUpIWFZrSUFoODc0ZzVETGdQeTNMNkRwaWhJNHFWYklnTUxxVU1KWHNi?= =?utf-8?B?OGtKeHV5ZW5ldHY0Ti9MbE9mZk9ueUVaVnBGdDlrdHQ5MnlOTkE5Mm9lQ0dw?= =?utf-8?B?ajJvblpDZUt1MEF5TkFFZU9xZm1hazdnUnZGTFREcE51d0IwaEh2aDhzaWxR?= =?utf-8?B?U0tZaVBndlAyMmdGZzRlNmRJSHZkL0FQeVVQcTd1VWp1RUloUCtHajFHdTU3?= =?utf-8?B?RzNzTG9WQnlCRGtkOHljMGFyYU43WmZ1MWJ6TStzTzZaRHRob1A3anFoRUF5?= =?utf-8?B?QVZSZVJDZHNWUFRRaUhpMDZndmUxZWJTaUtVdExoaEdSWHdOb3NVc0N1V0tD?= =?utf-8?B?QlI3UXlsMmxvZStEK2U4V2hWWWJNTnNaLzF6UHdYTDl6WmZsQnJLd3ltaW54?= =?utf-8?B?M0FYMG9zVkJ4dkkrSVBCd2FoT2h3TCtZeTFNQXhLVVNlUDc2VjJnR1psUWtX?= =?utf-8?B?cVZNUW5ua1YwSWMxNm9wcURwN0t3TkJtK0xuL2FLa2V4R0xSYzBzVERKYmdI?= =?utf-8?B?aFk3N2g0MThDTm9NOGFtRUlTUzFHUW9GNXhRZCt3c3Q2SUZRZTBaN3lOdkNH?= =?utf-8?B?YllqTXlkc1QyRkxxL0RLVkRqOGlPdUxuN0phZHl1b0xRaWwvdGxTTlcyN244?= =?utf-8?B?QndJQW5FSHFaelF4M2xDaVdZV2NMbi9ySTMwMmExaDdzZDdXTjdGUmJqdFZD?= =?utf-8?B?TzBRdk5aSERaYy9iYVoycjFIL3E4WUVFOVhsTDZXVVdWZEY3c2tEd2doTFph?= =?utf-8?B?TEc2eksvSm8yOUFib3lJUDg4T2cxaFNjNzZGNStJUlJRaDhPcWtNemY5b3pF?= =?utf-8?B?NVkxTVZMalc3UnBCYkF4WTBCMU5aYThGTUd1dm5nejJENmtsZVJJOXRqSEk1?= =?utf-8?B?bmE3NCtsV3JUSG1RRmRiaHRaZmRaWW45TWlpSjZ4b250Y1hHSW8yU2tnblYw?= =?utf-8?B?UVpwN0pySTU1NWFVUjUwWUJ2Ri9YS05rbWVZaEl3OTVOMG50Ui83N3RzREVr?= =?utf-8?B?di9DaTM4QVhucDlFWEZadlZOU3A2eHBiY2hscVc2NlI5YWZ1WHBGRTZ4ZVRV?= =?utf-8?B?M3JLRGhFS1hmV2lycXF4SldTK1lRVTNlSWFsSUc4U2JsTTcwSUV2VG9tQTVU?= =?utf-8?B?VTZHcHIxYWNpOWRwRWV5aTNORWpBRmRjRmZFQTl1T09JVjVLYS9wcmpzOHVv?= =?utf-8?B?TzFjSHBVQWlUdEJhQm9HVUlwUnQ2YmFWMTg1Tm55WjJtdUJVd3RjVDU1TG9j?= =?utf-8?Q?h81QMx5R18THk+60UoSL1qulR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60158f85-6b36-4106-ca7a-08db189da271 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 08:35:51.8605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kBHzw2Qg8Mv/Ndw63ZyzcqENOM0PRVG6VVaZVYIjXdLFZs69Tonj5BdiIxiwmeIcyqdowRHD+S3lbUjVRnsAjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7658 On 25.02.2023 21:37, Demi Marie Obenour wrote: > --- a/Config.mk > +++ b/Config.mk > @@ -191,7 +191,7 @@ APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i)) > EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all > EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables > > -XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles > +XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles > # All the files at that location were downloaded from elsewhere on > # the internet. The original download URL is preserved as a comment > # near the place in the Xen Makefiles where the file is used. > diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm > index 68819b2d739cea5491b53f9b944ee2bd20d92c2b..548db4b5da2691547438df5d7d58e5b4c3bd90d0 100644 > --- a/tools/misc/mkrpm > +++ b/tools/misc/mkrpm > @@ -34,7 +34,7 @@ Version: $version > Release: $release > License: GPL > Group: System/Hypervisor > -URL: http://xenbits.xenproject.org/xen.git > +URL: https://xenbits.xen.org/git-http/xen.git Please can you not lose "project" from the URL? That's the more modern form, after all. In fact, since you're touching the other URL above anyway, I wonder if it wouldn't be a good idea to insert "project" there as well. With at least the former adjustment (which I suppose can be done while committing, as long as you agree) Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 08:42:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 08:42:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502267.773988 (Exim 4.92) (envelope-from ) id 1pWZ5a-0003lo-62; Mon, 27 Feb 2023 08:42:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502267.773988; Mon, 27 Feb 2023 08:42:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZ5a-0003lh-3R; Mon, 27 Feb 2023 08:42:30 +0000 Received: by outflank-mailman (input) for mailman id 502267; Mon, 27 Feb 2023 08:42:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZ5Z-0003lI-2U for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 08:42:29 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20615.outbound.protection.outlook.com [2a01:111:f400:fe13::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9a9ddc6-b67a-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 09:42:27 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9424.eurprd04.prod.outlook.com (2603:10a6:102:2b2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Mon, 27 Feb 2023 08:42:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 08:42:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9a9ddc6-b67a-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgZ2xIuOPh4ru3/pDSog9t5zIxrL9OZTbiTB4AfciRgelIsjqjcLw7T31raqWHERJqEzplAKlnN+PLJ6+M0Q0zRZ6E5Fx2JHaXr/qKC2JwhK/atvfeXaQe5KTLDN2Az2A+6AUbTJK4VHCuul5n/y0pTQzZIUgNQxkgHkvAPJVww0b02XYLhKeTLJKDlFhbhIq0ptsamb0FyAvKljg+9FClhGOfSKQoLgdgCSjgi9MfwtQ9qPe7gY1A+hNxFUonJ+zdovxTHIAtcxZHxoBJR7chgmpBfvFmftEeTGJu17MmtAdfrODAbloUc6k4E6P8T5rIt+Mht/HyUU70VUDWbSCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gnqYGSXYntkhgVXCRW0NUps+KP9tf5XVkWsUniAf6rw=; b=eHRUIKv9zjVJq9UioYUZs4Q1KiluIwHbbeo83ZKC4P5mfO+FJGz7S+eRETDrakMQwtEFXwvFLEJQjHeb1yupjoU7T/V0PUvp/yUxzEyw4AOd0qqOUb6z3pi4puxesCQEQaHbsvG09C4NL376/6SmeMinAtiSh48gkFcyAHc6xIU512tajgkxQPq8JuZDBmWrWUCCZAH9dog/+5307Dwj0n2IqaawIsaDHFOP0OddCocApQyHTsoEB/Y2nxwBplGPXVcP698bcnJBSf8vRUOBO3n2MiNCjolkD5M0ZBGGOy0Q961qeUE1kWLmNb6+vq9WmsWMSvfpqmEt9fOwTKXF5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gnqYGSXYntkhgVXCRW0NUps+KP9tf5XVkWsUniAf6rw=; b=XLK755Z8nxXUEUDxzYumJwu+pEIGy0/qcAW3QackZr7DuKY1C9fulskh6RNus00lK5Dsg7XPFFez2KHV4eigBMPuAveiEE7qIB5aDeqR6M8E1KGVmWwxmqVlOcs40OCGJ6I6qZlR/0K8x+SXq9+RuARu7q/G/3dlz0jWtMqQARQ0+kSdItPxnXOZFEOtAPdj+y4RltUAYiI3kFiYolQcBa9jLvxNEQ8ma4QFt9Snkmmo264bjIIioKLF+5JuelLNTdDnXZhayCzOfyoKX/EmZ6i/TjsZxa2REOFGYAnrO7DOu70CtaTUKV5fCIqnpI6GP3Jdgrh3//z/h8+mysy7Bg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a66c333-51e8-6e82-9bfb-10d52164e96e@suse.com> Date: Mon, 27 Feb 2023 09:42:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5 4/5] Build system: Replace git:// and http:// with https:// Content-Language: en-US To: Demi Marie Obenour Cc: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Samuel Thibault , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <85a65c8c5cbd7cab3b9eb57aed27a59443c7a6ff.1677356813.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <85a65c8c5cbd7cab3b9eb57aed27a59443c7a6ff.1677356813.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c604a67-bca0-4ff7-b833-08db189e8c86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JQOZe8qblVEaWynUD84kUVLiW6TOpLhdzt7Klp+oSTVB00WLOVJm9a60nd8bhhFdR9z/00NSKVrNp7l3bql7r3X3kMSdBhnIXR/1U8/bx5VoyYcBCMj5Ac7iY680UwX9GSWUvj8eT0KNfsBP7ElusuSxT1X8yHFUTeoNqmeLpMCS7PV0ZQuBmooQfqfr2VbtNS7vV5Grt8c46gKQGmz522JAkFaAe99JrXUnFZwaK3l5t+bOINuaQzWFySZk3zcSZxaJbNiMe36e+PGHr82DwD1xPvgZK5h3jL5+Nb29TIUf1B/hBcoYm+zVYgd6DjyqA2rtVPEb9CnoFMqMlXXPyDSsJfmAxmPPWIkdaOK3VUy6E0pILM94Mhm6ga7P0gl0cAkIAsffKc7b+cV1oJ6iZ3wkZB91eblll9LxNohHWKTjSevb9UabTkz3p8Zt/Ox2P5aFdSRqh3Q4+N1YlPCW0VuGZqQ/ny4IBBkDTjmDJPerIq2YxmInW+M12EPX61g1uG2xJTkMXaifxPp0d1HelYs3kYkNW5zm9cveYshv8S/qJ7gvYxbD8ohFPZTy9EKRoDmWEVFMf/T9xv6S5jP1Yr1cK6qwVcsGEoEaUbJTBHm4IDGSdHAOIAdWV4Jy1DAO7BUoLg9pk4i/b6A4JBE6tszGIA4CrZ5ODH6MvQZBn78uVjKo5ihdkpsNNUw6gVmxjSZV0KyBl5qY3o7GpmZTy7JFcdZiUOVzEXDKVVZAgJ6LCNsae0UJGXct7RFY8sCy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(346002)(39860400002)(376002)(396003)(451199018)(31686004)(4744005)(2906002)(86362001)(38100700002)(31696002)(6486002)(966005)(6512007)(8676002)(26005)(186003)(53546011)(36756003)(478600001)(54906003)(19273905006)(66476007)(83380400001)(6506007)(66946007)(6916009)(41300700001)(316002)(66556008)(4326008)(2616005)(8936002)(5660300002)(45980500001)(43740500002)(563064011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFRrQ3pHSGlvOFFpZVFrUXpRTFM0RTFHR3V1MjduR0NLQjB4QXA2dWJGT2Jj?= =?utf-8?B?SC9qT0h5SnUxQTJhOFcwZ1VWcVNZMHI3Y29FZSs0aTltOEhHRVF1TDNMY3hW?= =?utf-8?B?c2N3OVpPYll4elp2S0hoaG5sM1YwOGYrbXc5bUJ0SkRib3dINkNtMEVKVUVY?= =?utf-8?B?WGdtV2lIL1VtMkRUVXJ1VkptcHR0V0VXanVpQXFjZFdCeDFyWDM1b1hUT2I4?= =?utf-8?B?eENhRGhJY2VkZ25mZkRhdmlkazJmd2hCUjBMZ25LbGR2RFRVZ2lBUEQza1pJ?= =?utf-8?B?WjNKZkxjSUluRnhwL3BjWXE0K3JackFFVTBXZUxYMzgvdkl2KzNqTURKbDJK?= =?utf-8?B?UnhkWnJYVWFqMTlYV2JRTzA5c1J2dHZyVUZTK2tvNlY1RjhSdU92QllMK1Nm?= =?utf-8?B?RGZmRnEwMkJFdDViYnlNMVl2NXQyYTAvYTAyd1VzejAvWmVVSjRuYVNDUkFM?= =?utf-8?B?a2tvYW54YXliUUxQM0hFZktwS1R3QTd0bVgwRkdDWWxzRGxxQkVuU3NLUGli?= =?utf-8?B?K2xFQWgxeXpEVVpqL0x2V21VYmw5NG9SdC9rVnpBVzNHTGlqeXFCNGxVQkR0?= =?utf-8?B?bjA4NmZDRFgwWlFzZkw3SytvSFZScGxvYi9ta0dINmNiWE56MldtejdxdkY5?= =?utf-8?B?VHRHNzAybzl4alRHNGovM2xNbHNTeW1aV3N6T3hraWJoRUl6T3FMeTFtaEZH?= =?utf-8?B?LzlDekI1MEl5b0pZZjdiV3FiZ2pEVEdrYy8wclc0MlkxS0M4RG5qTDJ4b1FE?= =?utf-8?B?aVdGSUlKVm02RmQyZXdISnZXU0JmbmdOTSt3QmJJUkNWZmZkWFZubHZnR1Ar?= =?utf-8?B?RkNqeXVjZ1Z5eEpLVFVnc0hXU1ZxM2Q0UzA4LzdZVDVMNDRsdVp2bnVwTGZG?= =?utf-8?B?Zk9xZis3OVlkTHdSTG1qWFk3Y21wZks2cDZtT1ZscDEwM0pqdEhDQm96SEJS?= =?utf-8?B?ZUxQbzdCRzJSOHJ0ay9uams2SU9YekpsYVFHN0M4QmFUcWs3RmZtcVhEVi9v?= =?utf-8?B?NkprejF4TFZxM1MwVnBkM29lbFdQNXk5OG41OG1STHA3WTZkQjR3cnBDUTVN?= =?utf-8?B?OXQ1VVRiRHVQNWpGZnNXb0lwUE1OVXdkTlo2NVlIRm11N0FHdjBCbjl4YmJ5?= =?utf-8?B?ODYxN1FPSmxtYnVXRjNGQjlJTzgzb3Z6bUdFdXR5dTErMUUrVVNlMzQ3Y21Z?= =?utf-8?B?S2VXbmVETnM4aWJhRWRwRmVXRU1oSjNucHZSZEZURFBBNXI1Ump4Z2R5N0tz?= =?utf-8?B?VXdIRFZTYXlYUmp3RWNaQU9RN3JLYmg2OHFvVVBGUWVNem8vM1YyNVlMM2Zn?= =?utf-8?B?RjRiL1owK0FVRGhvbm5NNWRRcjNxM3d0RE5ocnVGTFJlS1ZDRWozcDF6SW9u?= =?utf-8?B?TVM5eFYrRFZiMlBGVVdqbWx4RFpBeTgxTlVKWHRsOHl6RHJ1Mko2ZjJxT0hp?= =?utf-8?B?RWI1QUZ5MGc5M2Y0ZElLNHZCakJubi95SFhrRWFDckRrMVdjR0VvbTYwYXc3?= =?utf-8?B?Rkg5Q3psR1lXNldmR3hsb1dFU0hwcmJNU0RKc05reEpneXFhQlNtaDQrcFNX?= =?utf-8?B?V1laRTdDcklhQ2NWdnNLeS9kZTZKekorV2hUOE50TzErOWlINlhHd0NLUmMx?= =?utf-8?B?dFJTME5KbGh5aHN0MEdJUVFRWGdKd0oxRkY4UkVNS3pkQWx6RjlweHZDeTRa?= =?utf-8?B?ZmdsR1VnOG9teHpHek5rM25TWCtVTDBKejFsc0UwTEhsVW5CVnd2Mm5LTW45?= =?utf-8?B?QjhTcmp6STVWTmRtaDZEcFR0Z2tnQ294eUJsZEdHRE16QnU4Z1NkUm5nZjBZ?= =?utf-8?B?bEc0ZnlhVWsxWDM4RnZYdTB1emMranQvNHEzQzVOS1NMUWxVTXd0TXJhQXIw?= =?utf-8?B?N0dCc0t6aWVKTkVyc1cvYVllb2pjQWFFbElYMVNNM012TTAvY2JBaWg1N1Jp?= =?utf-8?B?NGd0N2lyL0dtUEFjVkYrc0dHNFdBRmlJOWJVckRFdlBkTlBsYmZEdmZkTlN6?= =?utf-8?B?dUUzZ3d5YVgxbjlFeU9WZWdaVUtEVFhFSVVLVXJxb1R0WCsrREo5WFl5WUZU?= =?utf-8?B?ZUYyK1NabWtVSVM1K3JVQmhjcXl0N241RVBHWmJ2Zmg3WHZsTkFtUzJYTlBR?= =?utf-8?Q?c5RBb+wpyq9izhi60fzcg7mVW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c604a67-bca0-4ff7-b833-08db189e8c86 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 08:42:24.6314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3q19I+tdUStZYEscH5plEfAJ1oug2N159XHbFBpkFcq3o61O1EZDSm2Zr0Ch5eq4FLCKmJBhztAA/kAlFMoDCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9424 On 25.02.2023 21:37, Demi Marie Obenour wrote: > --- a/stubdom/configure > +++ b/stubdom/configure > @@ -3545,7 +3545,7 @@ if test "x$LIBPCI_URL" = "x"; then : > if test "x$extfiles" = "xy"; then : > LIBPCI_URL=\$\(XEN_EXTFILES_URL\) > else > - LIBPCI_URL="http://www.kernel.org/pub/software/utils/pciutils" > + LIBPCI_URL="https://mirrors.edge.kernel.org/pub/software/utils/pciutils" > fi Simply replacing https:// in the original URL does work. Why did you alter it beyond that? Yes, either access leads to the URL you specify, but that forwarding (or however it's implemented) may change down the road (and it could, aiui, even be dependent upon where in the world the access is coming from). In any event, here and below, any adjustment beyond what the title says wants explaining in the description. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 08:52:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 08:52:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502273.773998 (Exim 4.92) (envelope-from ) id 1pWZEt-0005X6-20; Mon, 27 Feb 2023 08:52:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502273.773998; Mon, 27 Feb 2023 08:52:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZEs-0005Wz-VY; Mon, 27 Feb 2023 08:52:06 +0000 Received: by outflank-mailman (input) for mailman id 502273; Mon, 27 Feb 2023 08:52:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZEr-0005Wt-9T for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 08:52:05 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01f77183-b67c-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 09:52:04 +0100 (CET) Received: by mail-ed1-x52c.google.com with SMTP id s26so22433048edw.11 for ; Mon, 27 Feb 2023 00:52:04 -0800 (PST) Received: from [192.168.1.93] ([188.73.239.185]) by smtp.gmail.com with ESMTPSA id ml12-20020a170906cc0c00b008b1fc59a22esm2959801ejb.65.2023.02.27.00.52.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 00:52:03 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01f77183-b67c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oWa+q1jNuttV60i7FGHAfquXZh1ICfAvONgpeNS7hVQ=; b=IhKdYtfXPNJzTVTNl7v6hn8v0lTjSAIkpvIPbYtJCQMs4YWOXOWp3/mHaWxNJ6rYZj n7u4fciKJ/xwY0uhSMFJjep7PGp9stNzybEGcT9BUAHRmxKrtq306R9VMBM4dWbobWR8 7dp1XjxUN1LcYbEiT9m307NogtscPirF1ERzfC8W6sVn6zpps4RurbZ26So/bZ4CL1zp VcwT6ez0xk1XmobnrcCiRW18r1RhB5UXi0FG2aRduULeoooxfyrN/EWIqN7f549qGlSA 7ig3FyPvKsXhqVbheXB0LbXAb/KdvtIZEVRzR8FA3gXvJKXuDysKna0KIIvAX3LC8nkZ 0Wig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oWa+q1jNuttV60i7FGHAfquXZh1ICfAvONgpeNS7hVQ=; b=jpFKK48f2m/CRAQpHl69AY4yHSpqUCQDxalhxE/Svp17o19HEpL5sOp7OcEhTRXnoE bWeY9w3EQJ+nlA0zK3MiX/+K89hFHTYv6xiSgBSs2oS6s7ZYnKdxhliaweMYE721Lc3s Ev+vUBmLuXHCeiB7QtvUpgyaWBwPzZIKOMj/h/wRD3lDyAQ1tWQEAKxcZw/EWg4RcyJw tYXmNzsRv9RDHI+9KZWLXRgoERSN6VEJMBpTvIvAoc6r6TOwO77m4oZAH0rb3nntdWnd 9hV/vCq4J/LfmnrtwlZRs/b895NwxC4UEABUEj1qJmNIrif9Vf0oZf7eSlOyt1expuhI tegw== X-Gm-Message-State: AO0yUKXrBl/4+4fwTQvwRqkJ41g/AALH6QhshUj7WlapY3gn1EOtHy5B GE8LoefrmRKxRiUyPX3VTTNPm9uvqr4= X-Google-Smtp-Source: AK7set+cYym4Mr1awaXrWhJwTJguF5MYmZDsueAaJQ8ZRL4sov/Nu+J34xNbeR9FY8WTJbx34hPnyA== X-Received: by 2002:a17:907:2099:b0:8a9:fa2f:e440 with SMTP id pv25-20020a170907209900b008a9fa2fe440mr31225122ejb.55.1677487924007; Mon, 27 Feb 2023 00:52:04 -0800 (PST) Message-ID: <709fef03-4263-861b-3ccd-44e3706b5fb3@gmail.com> Date: Mon, 27 Feb 2023 10:52:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 05.5/14] x86/svm: Decouple types in struct nestedsvm Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: Jan Beulich References: <20230224185010.3692754-6-burzalodowa@gmail.com> <20230224210616.2818727-1-andrew.cooper3@citrix.com> From: Xenia Ragiadakou In-Reply-To: <20230224210616.2818727-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/23 23:06, Andrew Cooper wrote: > struct nestedvm uses mostly plain integer types, except for virt_ext_t which > is a union wrapping two bitfield names. But the nested virt logic only ever > deals with it as full opaque register. > > Switch it to being a plain uint64_t, allowing us to hide even more of the SVM > internal infrastructure. > > Signed-off-by: Andrew Cooper Reviewed-by: Xenia Ragiadakou -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Feb 27 09:17:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 09:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502278.774008 (Exim 4.92) (envelope-from ) id 1pWZdb-0000DK-20; Mon, 27 Feb 2023 09:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502278.774008; Mon, 27 Feb 2023 09:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZda-0000DD-Va; Mon, 27 Feb 2023 09:17:38 +0000 Received: by outflank-mailman (input) for mailman id 502278; Mon, 27 Feb 2023 09:17:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZda-0000D7-8z for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 09:17:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7d00::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92be7024-b67f-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 10:17:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8296.eurprd04.prod.outlook.com (2603:10a6:20b:3f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 09:17:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:17:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92be7024-b67f-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7vIUuAETdJhprn60R/Mo4Mi9t2L5LbqOb7HvCCk7dh/dO4lcjP1U2zLy0gd+RKnUbuFACJC9Y/fNCgy0mLO6hnN/tWc2jyadTDRQJC5u+jnaLc0S8cuZxpqtsWRNxMkzhbHn+1L5K9P9xSA7GeDryyoFTbIAaDFoFgC1DVjUQs4e9cH/EngaG/Ddf3A2HS0ce8Xbvyk8qHqQzKD7xOPnUVC/l1NPEQlAS9n2xjmc35JRtuzcAXnZa64mWkkT+F+DgS+iKhtfpgR9d5Ly7Dgbwrlx3qADMToNT1LF6E98Yd8HD8442Uy54zQ26Yqvz63C9L/KDYiFS9aMvO5mCmayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j3qglYFZaUD1bDSZZCZB0gxJ7jhLbH3ufQj9cipEW30=; b=OZVYHZZXO/Tm4kYOwGSlcV643MoUiXL1mg6EuyC5eiq6nMPv1C3xhYJwWOGc81yoCHFtSZhYSX8LjPXXzc7IHIfr5k9hkKYYkthMrz+PB+HKMe38rIsLfoCNI20lGKeW08mFH9g0PoauO35u34BNscaDdQ/inRx8xsFNKuKw6CV1vVAFYieG25AIHx9SodW66tBbVj/P0ZbscN/MzLT86y8G8B0cboEwpxo5Vs/76b+bVxBJ3/ACwSGJKD43NwnqaXcH+13OmFzadsnCF0GE+UKJHCYpqDGB4VWaS03oRkfr/h1+xHCxul+/GEtluXFpZD+3G8f7hsVZ3R4jpr7MCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j3qglYFZaUD1bDSZZCZB0gxJ7jhLbH3ufQj9cipEW30=; b=t/G00kqDD3oDZiWRFuLsWL0y5n033Lfd94EMtYImHMKPyOmHIYeRvn6Ie0EcdgyV4y3p2FMyWDO5e/ycdkQWwZ7ZiLMrxB3L44S8leIl9B7JupgtHRRZ8E/SzPTRgOsrYZ5gFAlczD0bF+KQwEdGnkfq2u7Ub4HDxx3wPGlejzhBNRXUAWAgSJiQGGxaq1/LQ1JpAC+81hNa2ahYRbg0B2rNc+VNkoGsMNrZZUFPk9QhXksjGGH152ScsiSuM2mqxR92n8v28erXBw8cx8CNgEBJWaG5feQAEKL9SSGaIheBB28idZsQObtYzk8ARMWJWf37pi9RVwp2o6yMwKQfMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <738ca749-2abb-6ab4-db8f-81ff41f4de16@suse.com> Date: Mon, 27 Feb 2023 10:17:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8296:EE_ X-MS-Office365-Filtering-Correlation-Id: fc039140-67b4-4a35-906c-08db18a37584 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hzjVrVxqLpFmwwr9ti7Xc+7UAl2vT9PV7xuQO8kr6dfYbK35613OjL94MmN/uCQN1fn1rSG3gPzFKgP3tCzC7pHLC3eTPmx2aPOlXh3CPr4gnl3YNhyEz5eSy7wE+LyuKhm/DIGKOgqVTjA/lC4P5lSVe3nrx7jsJFmNzIOp4pYbnKLgkT0m6kmB6Z8wb0fHV2z34AX2aSSIlf0kodkH2tYFRworTvIsC3g9I13jt9t1z5O/6GcFtRTzqmWh1NzHsR6yrBLyMHLzaPbAESYsqktV9hzL3zDyR6psf6MeFqZw098EWwucbh4HI2JZUXyssKg/XgpRj5eNeLywYBKOs0OVocIyhA449bbkBAcyIpWuYAVm5JIwuepW8B5pgOK8TVAexsbG3eXzGVNEKibbqs77CjNZ5Ggyn6dJDAWylusfV/dB1KNi66xtfeATUIywwv0o2YZcxY9i/Mbo0ozlBOV5FF4++hpa4qOn119uO7NWAxhtxH1hUKvcx8TIzUThfO0MWVNnkF7fmynSyBK8kORw64rpUcCb/CPMnC1EV9Y3bCYWINrsIm1/UIYYLF0LpoCoXYtj05TXGeqCGeOqiPm/MmW2udtHFu2iOr/bIiC20r3AiLi4I8xuKQQBLdxgi4K1jICGJp26gyZkjC9NBAfoP1PcfHJfH/63WxY3cRe42ikT74yphlUl27AD7A44aMfy5BHSernOdaN/aNNcbw7ifHcP9ZVywBdHOBE/USs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(39860400002)(346002)(376002)(396003)(451199018)(53546011)(186003)(26005)(4326008)(66946007)(6916009)(8676002)(66476007)(66556008)(478600001)(54906003)(31696002)(316002)(86362001)(6512007)(6506007)(6486002)(8936002)(5660300002)(41300700001)(38100700002)(36756003)(2906002)(2616005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0VySWFiTHl4dlFWTC9KWWFmK0pua295UnVaR0s1d2FGUk9jRzFvUGhMMGVC?= =?utf-8?B?dnZVbXp0b1dZdEI4VHA1VmxENnNHSG9iL2k3SnJ5blAzNS9yeU1Cd2R0ZC8v?= =?utf-8?B?OWxzcFJQTnRWWjVadEx5dlhyVTZVMWI0VTc4UHMzTEhxQVJEc242S3VMclB6?= =?utf-8?B?VVJzY1lxV1AwUjhNQzlJOEEyWEVSR0lIVlUvRDB6c09Ud1hsS3hwYTFIWFhs?= =?utf-8?B?RzEzWlpXVmwzNUVoV3Rmb1VpMkswcmVNT2Fnak5lNUF5T29wWHYwSUdwZ2lt?= =?utf-8?B?cXNROFgvRXFOWEUxakVtdmMzYUJ6RkNsMGMwQTdiVHZmaEFSdWhpanJZTVg4?= =?utf-8?B?QVlaRTN3OWlDTkYyZ3NtbFZDcmd2QTBEMXhDWE90dkEvT0lyeTdLZ1gwWW9y?= =?utf-8?B?dVM4QTVERXhzUnAzZzUxd1RZc01MNkY5aG9ZLzlaRWttRy83K1YraFZvMmE5?= =?utf-8?B?ODRZZnhLVExkZUJEVUJLQ09lTHFkektwYnF3MmY4Q0t0d2Q0RGdKOGhTQTkx?= =?utf-8?B?YVpNdjZFRG1pSThtSnRNZHJwV01wbnR1SmhJbnFHbWJUY2RkRXZFVUVyQjc4?= =?utf-8?B?bGdHUWhEU2NkTW9uRHgxVHFQV3ZLR2N5dVhHQ3RCa284NVNkVEU1TTFqcTlP?= =?utf-8?B?Qm53dTNuc0FvSFA3bWZWbERQcEd3aUFyZVlwZ3RJQ0ZMOE00MURLSHd4ZnZk?= =?utf-8?B?MkxXUUxTeUJad0FWcy80aGtzYkJaeDI5bzNjakdqOHBDeGFxZXVaY0RTNDlz?= =?utf-8?B?WnVPdDVOaVVqZlNZVTVPbGFOWDZpbXBXVzh6bThFVG9kZ0lweTJVbm82cXpK?= =?utf-8?B?aVk5KzZvdzFQcHlJcS84WS9DeFpRYUdEdWFYSUFWZDlialhPRDg0MTRWcEVE?= =?utf-8?B?bUhudXVPWlVpcTZWY1Rhb1VIVFBlaWg1V0NKcDVjMW1tUG1iUnMwVU1oTnpu?= =?utf-8?B?U21TaVBSTHJPWTVPeExzYUZjbzMvQVdjUTFQYmJ4V1JxQTF2VEgvdGlrR2kr?= =?utf-8?B?WStncnFaRnF1b1FyWWpveW5wamh4NnFjS2dURkJqT3d3TWI1Q0pkdEpBMHht?= =?utf-8?B?S0w3NnBrdnh2WDZkd080TmdBcEdYSXprc0YyZmRsRmEzdzhEc2FHTmR4NTly?= =?utf-8?B?T0NvbEZQQVBiaUZDYStLOHRlOVAzR2dqN0xQN0pQMTU4cTVJSkFrUzVQRWw0?= =?utf-8?B?aUwwQ2JaaFBWYlBmR1ErZzF5Wk1GQUM4clBQQXBSS1l0UEgxcWM2c1VNTnFq?= =?utf-8?B?SHUwVE5lRkNQVDZ4VHcvaXZ6c2xzWUFwQ3NNK0RZYjFDRm4vaVpDb2NuK1Bk?= =?utf-8?B?ZnNvOExDSUFYL1A4Y3djRG5EbWlXRWtxU2hORnJSVlFodjY1dlhOVlUyeHR4?= =?utf-8?B?SzArOHdzYWxtTnNjSGZmTUUrdU4xR2h2cis3SkppbmdzRGh6UlMwVkFBanc1?= =?utf-8?B?TVM5VkE0VDV0cmY0RE9hZzBPdDBMYnZKT3EzYVdIQjdkNlpFT2krT3hMS1B2?= =?utf-8?B?akVkdmdGb2pjdFEwbXRDOUdRYnR5V1RZWWNob1NsbUlxVmR5cnNpZjVMYXdp?= =?utf-8?B?R3Y1YWNtcm5Sc1B5TVpKL3UrN1NNY0xoV3RHdjFHREZtN3lQcDRFS1AraTQx?= =?utf-8?B?ZktQQjdKbTdkUy9Ed0hTUmhlTnpWR0d1WGVMVTFXMXZac1pTbkhFeEx1REoz?= =?utf-8?B?OGNIcXM3cW1iaEVqN2pRaHNJRm9TVlZEdGpudlR2OUpWVit2ZnBIcW1YZy9a?= =?utf-8?B?L1BpRjVTYlF1VHM5RW5FN1IxYnA0T3lCSlh5aFB4U1VkZVkyZDJEVForVUY5?= =?utf-8?B?WEJ0RjNRN3Q5Nng1SkRiS3NpZ21FTTRzdHZQMHJha1BzV1pnY1VPVERhb2lz?= =?utf-8?B?SncvL1l4WFREYkZIMFVMYVIvbnZDZ3RCa1JpakJ4VkZxcWwrY2R6ekpOR3pW?= =?utf-8?B?TlVPTXVQeSt4RTQzZFVvYlRPNTJlUXpUVXlEcndtMG1HU1JnRkVINmd6RnVv?= =?utf-8?B?Y0ZHYnprZm0rd0pTb3BSMDdPR1FmZkltYnlSL0JnOFZyTFplMmpjamw2V2xk?= =?utf-8?B?SHBFcXQzdFZra0MzOXZnMDRkQm1iN3Z6cElUSWZGZUE2eVNJVUVhekRjd1FN?= =?utf-8?Q?xfq++ez4ipG1s4hCj8VjOQDb4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc039140-67b4-4a35-906c-08db18a37584 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 09:17:33.5758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SvhhjsvHGswUN05+oUV8SIJVQET2A+NHMNf58ZmmNBbbLzsJBWjT5QckXKmaWGtA63iiAo3lPShibIg/XmbYxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8296 On 24.02.2023 17:36, Oleksii wrote: > On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote: >> On 24.02.2023 15:48, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko >>> --- >>>  xen/arch/riscv/setup.c | 12 ++++++++++++ >>>  1 file changed, 12 insertions(+) >>> >>> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c >>> index b3f8b10f71..154bf3a0bc 100644 >>> --- a/xen/arch/riscv/setup.c >>> +++ b/xen/arch/riscv/setup.c >>> @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) >>>   >>>  void __init noreturn start_xen(void) >>>  { >>> +    /* >>> +     * The following things are passed by bootloader: >>> +     *   a0 -> hart_id >>> +     *   a1 -> dtb_base >>> +    */ >>> +    register unsigned long hart_id  asm("a0"); >>> +    register unsigned long dtb_base asm("a1"); >>> + >>> +    asm volatile( "mv %0, a0" : "=r" (hart_id) ); >>> + >>> +    asm volatile( "mv %0, a1" : "=r" (dtb_base) ); >> >> Are you sure this (a) works and (b) is what you want? You're >> inserting > Oh, yeah... it should be: > unsigned long hart_id; > unsigned long dtb_base; As per below - no, I don't think so. I continue to think these want to be function parameters. > I did experiments with 'register' and 'asm()' and after rebase of my > internal branches git backed these changes... > > Sorry for that I have to double check patches next time. > > It looks like it works only because the variables aren't used anywhere. >> "mov a0, a0" and "mov a1, a1". I suppose as long as the two local >> variables aren't used further down in the function, the compiler will >> be able to recognize both registers as dead, and hence use them for >> argument passing to later functions that you call. But I would expect >> that to break once you actually consume either of the variables. >> >> Fundamentally I think this is the kind of thing you want do to in >> assembly. However, in the specific case here, can't you simply have >> >> void __init noreturn start_xen(unsigned long hard_id, >>                                unsigned long dtb_base) >> { >>     ... >> >> and all is going to be fine, without any asm()? > One of the things that I would like to do is to not use an assembler as > much as possible. And as we have C environment ready after a few > assembly instructions in head.S I thought it would be OK to do it in C > code somewhere at the start so someone/sonething doesn't alter register > a0 and a1. Avoiding assembly code where possible if of course appreciated, because generally C code is easier to maintain. But of course this can only be done if things can be expressed correctly. And you need to keep in mind that asm() statements also are assembly code, just lower volume. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 09:33:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 09:33:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502284.774018 (Exim 4.92) (envelope-from ) id 1pWZsI-0003EB-H0; Mon, 27 Feb 2023 09:32:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502284.774018; Mon, 27 Feb 2023 09:32:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZsI-0003E4-Cr; Mon, 27 Feb 2023 09:32:50 +0000 Received: by outflank-mailman (input) for mailman id 502284; Mon, 27 Feb 2023 09:32:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZsH-0003Dx-3N for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 09:32:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7d00::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b207a4bd-b681-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 10:32:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7074.eurprd04.prod.outlook.com (2603:10a6:208:196::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 09:32:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:32:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b207a4bd-b681-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8HSRNBd+Qr0a5sGxEjh/qwCWIxXJMCSbhLofr/ManDWgrQU6TWFRYlRf+h+H+l1Kd7FWpUwylnY5pGUzdNLZd5MUJWUE0YtSGH4sqyRGGZ2SrEvayEqRXx/vF+Rz2GSfj307dQXIbLxiEN6cTu+aIFVHZ+QbupLCFMDJUo8G2NoQpEdoIdQWn9Bsf/iTcJJKW1hWWExLZRBuHLRg612545sVMs/vMLfbSaGA2eyWpxdQGp4BQLXNfV6rFMMyGrpIdPz+0qzHHuAGdzb3Ilk7GglyJabmwze6F/8GGDOwJ6bBGUZr49hs7DONUND9fkhlH7rahvCgPUHnATm55S+HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5ffp6F9IPk1FbEmZH7GKlo8A+ZG0iRmDad5ylZU8Eg=; b=grxfojkaQCnwKfDHyNtg0qTbAYksTEOg5on6YvcvB+sjGxHgRln8HnyuwR6N4zzJT1JS+226xhc26alZvS1d8/3pLAeVInjqM5f3ci16lClSA9kdeDK8f2iEnkhH4cMGXkQSlzt+mDy4cZZYi5s4dYN1RZgxOW1bFKhZHIONEud2XyywCVaE5GTW2nK2PV6ToiU8v4eJV43cNM0hd+FcFesd1FElYFs0udBO6hR4b0Yz1yQ8gS54SpcPYbQ4S4vhZ6I0U0FpbZlDJNoN9GZPQgRmfGuxOIqLMtAGpe6OWMRU50gBKZyzIIEKDjq31X6eXeMBHvhSf4GOpav/1+Cm9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5ffp6F9IPk1FbEmZH7GKlo8A+ZG0iRmDad5ylZU8Eg=; b=Q2GVqgh5rUUVxoE3FnhKudwLr7vJhV9joHYfYww1cipHswoDgP+qK16TOetHuuO3Z+m5/CdWEhll2p2fsJy+izEyTWb71+vxU564VmNPp2k/qYlEVqIPB6uxrV1FcuKPmCVz/qkTsPjn6AAEpz6h0jQe55miRE2IijYVY7oRXkCJbV8UGJQjHMZoUtTIiEN7d5Ltmkl8cQRZVQilIP6g2oi74fxdQPd9GNFwnHwxMdF1TaacvJW/HCEFz9qfMNaicwvW6mrzaZ8hpf7r97lagKYxnSTO7iNBoVcF8ydSJmh9mYMqbz4Vj6UPF6K+erujGFuom33La7Y73l73n5VGEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 10:32:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7074:EE_ X-MS-Office365-Filtering-Correlation-Id: 3421349a-3273-43c6-63e5-08db18a594eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TbwA37je5xBIJEP39DV5riuOv80SuQqn6J67SkHkn4cZ5Mr6xGoL9BpiKKNUV7rs0Jd3YGPaNliSjmkZn4bkBoXrK03UYJpmwF8hcHS9D/QhKADWq0JjK/LIYdYKzuy5Bxr61qfrVrHu0rS2BuEOj0pvtr1DNuvZBLJIhgXezXac21c23n61dh3BShO5y8b4i7y3IF0XVkx5jagFDAhE+ms11Oa06TghJh+iVaUnUl9xtmNc9NcINv3iYlLevxKwLCPXzVvimfmwB0S+clqZpG13PAJ3HRrTCykf621YPGur7qdiQ7+GbUeEQOtGhF02cBdBrLdQkJ1+yXyd+bnUpNPFPwJjH2VEc+UDlhZ7CfdceOegQsv9zzfGlmTnLkGdjCU9+K7BjubP76DyQS6im4j4GViqrug6IbAXJewQhbNDsjjkAx3wORToQbg/auLbG/yI6lvKiULNbnHGeuBcaa8+U+9v8a1x8L8oSrWoprNmjlI46kiuBmCXEFX2FcWzZ59HuG+X6M9e8vutMJxenIY/6yWWgssllsMRSLgLpzHw11kpfgKTLmqIqMKs6+CreCjx/wvUqeBZ9kfDYfDIS/SAJu7kGwSt/Lu8RaYTsgHQoRR9TZI8czr4q+8WwId+5+mE3GMGM7RZTLjNnYg+WBMkRuZiav9PN+fSJwuAOSApT4jH2nRXejFu05UNOJZOEXObBKajzTimZyJwJiUDU1wuIPKLgM0xfqZwSvh1vMY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(376002)(39860400002)(136003)(451199018)(66899018)(31696002)(86362001)(36756003)(38100700002)(8936002)(2906002)(5660300002)(4744005)(66946007)(4326008)(66556008)(66476007)(8676002)(41300700001)(6916009)(54906003)(31686004)(186003)(26005)(6512007)(316002)(2616005)(6486002)(478600001)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnFleGNHbzBObEQrYnVhV3ZaVEllZUxEMW93VXB1M0Zwdis5UXAwdUM4Rm95?= =?utf-8?B?UE9odEJJOTloOWJ2a1hqWTBSMU50bGx4WUlmY0RxRk15ZU1UYmdXbHo2OHNH?= =?utf-8?B?Y1MvRmhDWlZNUlVMeXM2cDlkVTdDNEdtbUxvaHVWdDh3ZkF0QUl1YkEydGZY?= =?utf-8?B?d2g4TGlDZGlGeVBtdlR5cWZiZTBFN1E0M283VzV2WDNlSDZHODBrcVJFYlVa?= =?utf-8?B?WnQwSCtSdUczcUtaVFhGaDc5RkNQWmpKVHBHOEdFWFhDbkJuRlhyQWk1MURx?= =?utf-8?B?aHlaazRtYnY4MDhqYU9jd3FHREhKWlNNZVk1QnJITDBOYyt6citoY0RRUUhq?= =?utf-8?B?NkFwVDkvTVcyQm9hOENFVTdoL0pzWWJvVk44TDRZQnRXQWd1QjBsamNIZlFG?= =?utf-8?B?cnVPRkk5VFJveHY4UkZIaFBIUjVqTU1MOTQzTE9uZ0x0d1lSRFIwaExOZ1Z5?= =?utf-8?B?ZmVWYW93Zm9STHpRd0YvUXRzM1hmZzVaVVpYSzBrOFZDc2lNZ0lwL3ZhZEtz?= =?utf-8?B?UnBEM2xSVjk2VTl3TTFoQzErdHlyOTRnQnQzQ0hrMWFMenpXNlhiR29vQ0pZ?= =?utf-8?B?cUxxVUVHcWlSaXBWZDBaVDFyOG5OVVJHNkM0UGUwMUhtdlczdXJPRHVLbFov?= =?utf-8?B?QU0zSFhrcU5ISDhzVHgyWmNmOFRpY0N5L3krdUFqU2RHcDhBMXdadS9Va3ps?= =?utf-8?B?ZFBkOStkcXZxaktuM1l0QzI4eHRWSkN1VDNoWUl6NThkeVdKTkYvWUxQR09q?= =?utf-8?B?UHNQMWkweExlWkRWUE9yb201VGIxclVPUFQrL216aWlzVzZwZG84Z2lLRDFs?= =?utf-8?B?Uno5bWY2OXJETXlqTGpSSkJrNy84MGYrNktKNEZlTkJuOTFFZUtGWU5ySTJQ?= =?utf-8?B?ektMeW1kSUVsNXpGck40R2doa1VJVm1TREI1d3IwRmZjUXJXVW8wcitYYjJv?= =?utf-8?B?OEpnQjlDd1VLRmxvZnpDVllqSC9aN09oeUFQY2JzMExFTkpDM3RTL1QycHkx?= =?utf-8?B?QnFYa0Uvc1ptSnRnNzVaaUNFK0RZWnI3RitSeDE5OVRmWUNaRGNTcXhLa0c2?= =?utf-8?B?SlJ3Wnk1RjhsRDRzcUhPTlQ4SUVCYUVXbWF6c2hzazUzRzAvc1h6SWJMQ09z?= =?utf-8?B?L05yeUx1NXVrL0lUcWtQSUEwdStDclRDY0FycXhXYnlxd1VkU1pWckJteXRZ?= =?utf-8?B?K0w2QVdHekI5Vko2WFRZWE9ReWZhSERFSW5tcjhjZUo3V1puOWl4Q0RYZEJq?= =?utf-8?B?TnYyK01tUHMydzlsQmlsRDlsRDZ5bGRrMjlSVmJrckZTb0lVd1RvTEEvTU5l?= =?utf-8?B?Lytha3ZkdXRWdmwyNVcyTWV6VDAvNUtUam9CMm5XZm1SdUk1dW1oeHZMTk4z?= =?utf-8?B?ZVR6eCtxNnlybGJ1TUJNNDZrVndLTVlxdmYvZ002ZWk0T1JoQk14eTNEaWlQ?= =?utf-8?B?bUJ5K2E2dmFEeDhNQTA2bnBubFNWYk8yYmM3bitOTEo2WG9QcDVQd3VmeW5X?= =?utf-8?B?NzN4NCs0Tk1sL2RlYzBPZ1BEN3RRdUE4TXhTZm1Ra05LM1Y4SSswcU1qVVJu?= =?utf-8?B?ZFE5b2t6YlVJTWhCTXlnaGJtTFBaV0dFWnpyT3dpZ3ZNQVVjdHNGWlJma2NC?= =?utf-8?B?dmdkQ3N3cWFNM2JrZFNIWFpCNnN5ZThJNmNTQk5FTlFGeWhxN1hibFZCdldG?= =?utf-8?B?NzBwQkRheXVuazk0V01nU0t2Z2YwM0lMMnh1bE5xbU5nWlUxVzBscUpNc0w5?= =?utf-8?B?ZHdCWDZzZ1pMQlBhUzNia0EvSlpzc3ZLazBWV1B3L2JQMUNCUG11YmlEUTNi?= =?utf-8?B?SDVRbVRxRGdWRGtzaVZkbWZNS3k3Q2hHOGRlR05nZEtDTUVPbXRkeDBFNDZV?= =?utf-8?B?UjdXS0VlTEFYdmNHMHdiN1M0SEYwMU1odXRRM3Z3UU4wUzVFeDNQQTJEY1NK?= =?utf-8?B?TUVsQVd2UzRCS2RYZTNlbEx3UnhIV282ZXp6YTIxVlY4MkR2L1ptYUl5aUNF?= =?utf-8?B?RS9VREJNR3dYRlpwRlpQM0ZxSWtuTnczMSswdkVwZ3QyU0RtdklNVTdhR1VC?= =?utf-8?B?aUxkMVVQYnQxUXRnMjZVMWUwYXQvMFRFcCswVzlxN05SMHdoYWRPWjdHamxq?= =?utf-8?Q?kCmD790qc6mk9gxK399xrwF5Q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3421349a-3273-43c6-63e5-08db18a594eb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 09:32:45.1900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BcV4yYzt1sz7Erp5TgXLHMiOGJuCPPfZrI4w57fb1Z3k5Qe7+i1rDjtApx7C/onCA5PCQwcmqc2I+B9VK5mljQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7074 There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct Xen's idea of its own memory layout"). For what's left, switch to "unsigned char" as here we're not dealing with strings of any kind. Signed-off-by: Jan Beulich --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -305,7 +305,7 @@ void __init discard_initial_images(void) initial_images = NULL; } -extern char __init_begin[], __init_end[], __bss_start[], __bss_end[]; +extern unsigned char __init_begin[], __init_end[]; static void __init init_idle_domain(void) { From xen-devel-bounces@lists.xenproject.org Mon Feb 27 09:35:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 09:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502289.774028 (Exim 4.92) (envelope-from ) id 1pWZuY-0003lx-TM; Mon, 27 Feb 2023 09:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502289.774028; Mon, 27 Feb 2023 09:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZuY-0003lq-Q9; Mon, 27 Feb 2023 09:35:10 +0000 Received: by outflank-mailman (input) for mailman id 502289; Mon, 27 Feb 2023 09:35:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZuX-0003lg-I6; Mon, 27 Feb 2023 09:35:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZuX-0003TP-FX; Mon, 27 Feb 2023 09:35:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWZuX-0008G2-3W; Mon, 27 Feb 2023 09:35:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWZuX-0005mw-32; Mon, 27 Feb 2023 09:35:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UoMItNHBvSGs0gIrftBF1PKE09PdxJiFLjjHhxfU8YI=; b=uTy+F9HzLb3VJRDYeKdNAOZoO/ Vw/GA8LjULiAfxJ2pJJGAujiyWrATx/pIdykCgsPoZ9qquG1adiKf2hVHrhzQN7Wt9/OAxKzHzUVE ob+MSysyficoB9saiK6isMsFbmumqRr1KxegnjDtrswKE78IRjGRN+miF0+Ho1o2zG7s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178616: tolerable trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=608f85a1818697156b72ace4913a17c8178a0ef5 X-Osstest-Versions-That: xen=608f85a1818697156b72ace4913a17c8178a0ef5 From: osstest service owner Date: Mon, 27 Feb 2023 09:35:09 +0000 flight 178616 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178616/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 178515 pass in 178616 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail pass in 178515 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail pass in 178515 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 178515 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 178515 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 178515 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178515 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178515 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178515 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178515 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178515 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178515 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 178515 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178515 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178515 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178515 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 608f85a1818697156b72ace4913a17c8178a0ef5 baseline version: xen 608f85a1818697156b72ace4913a17c8178a0ef5 Last test of basis 178616 2023-02-27 01:53:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Feb 27 09:49:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 09:49:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502302.774038 (Exim 4.92) (envelope-from ) id 1pWa7h-0005i4-6k; Mon, 27 Feb 2023 09:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502302.774038; Mon, 27 Feb 2023 09:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWa7h-0005hx-3e; Mon, 27 Feb 2023 09:48:45 +0000 Received: by outflank-mailman (input) for mailman id 502302; Mon, 27 Feb 2023 09:48:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWa7f-0005hr-Ok for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 09:48:43 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7e1b::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea3a6d7c-b683-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 10:48:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7670.eurprd04.prod.outlook.com (2603:10a6:20b:297::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 09:48:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 09:48:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea3a6d7c-b683-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P505AlOBxAB57DU9dHrS9aNWBKS0Lgwy/S/bj9/X9SvNDk8rfn397IfrCALXYWU6Ytl181iZQRl0g1IdxsBMGecetoCJ6FS4Ck0PrnUAiQ5fn7F1DN5GR1mwuVlFUskM3GhEl5suRiVnTyajWb0o5LZpbLznL9Tl6E97x70+pPRZjWv3qfVayL2lkKjOffycQdyoZQGseik64oyBVYIbkKKusE5o0oSGC9zsz1IdE39w5TCKQFuWxClWVoPBj0m0+EOAoZhk7IltC9dbfTAfIu7UOtCQkSXIWvG5t7JWy3PNfobnMP0p9xPpb6UkHmJeYSR99GDWM66HssrGB1uLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ANIU0mCSskEWJqWB9z93SEg/ilIHCOVGSXM2jh3Gsxs=; b=BaNGoO12sTbCD/Mvb+XG6AMgphQuArAbQyeJPrYhmHofNiK42187rL+3gFMuriK+X3U2T4EDapmJh/xFmQdYvoqOVSMJLab+IZFHbCNIvstMQcV7eM2imUdBjGwvzevAEwvD2UoWtTOy2J8a5SOZ6xFlrOS0id966IoViCJ3PSC4q0u3ES6zVGSGPBMNLhQHHFfKD1dBqgJnAm5g6vUM/IPIvzLY1DhQYz5BsrnUabzl+lfMleyWkKL3/TReC/HO8QFCILXc64wIiICuYUEte1wnLNKjwIaHoSw16HzFJKiXhlfwMrOkczEkD6AKyGl/IZfnI40vqJPji1+/i52E1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ANIU0mCSskEWJqWB9z93SEg/ilIHCOVGSXM2jh3Gsxs=; b=gdILGTIobmOTHtNqe1Zd169ZiJBPJ85WZKhks4GlZwsyuX+8KFKhuFr6jniZx2vECGoOT5BlwISS5DwRvfFollyqKxVjoHNxICp0hr3GNeXVHwukHk8j5c79v8DkR6hdCgF6+lpKqbAD3GaOBpnTauXhicwQdVze96Q4TvSSMk80PHyCT2FGBVd95UfGyj1oAMnwQd+Fn6a+qpJz4CFlBQP2jyYKgDA5AjbkVJCPgSjRlKggOrkNYd6nmcdNO7uHt3Id2p8k1JD7/LD+Po/TgwKYEyUJYYCdz3vDkvoFW+gZYq8dfDn9PWd1vIpTruLEIgPbTYsCQBVWhtix06biQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55f05814-76cb-3dce-309a-6b734edba280@suse.com> Date: Mon, 27 Feb 2023 10:48:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Julien Grall , Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> From: Jan Beulich In-Reply-To: <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7670:EE_ X-MS-Office365-Filtering-Correlation-Id: 48997c41-107e-4655-873a-08db18a7cd5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oH8Hjbrl8Dv1B2gbEeSdmQVr7weohNarTbDC73ahGB59/8653RO3kzuqCSvMH4XKkopSN+Ry/pkX4IG70wuAP17rxx92/L1AfWZ47ByRNsHPTqBroS5mH+OQkf2AhSO+36XizZ0rpBKwU9+75pwWFmnRO8VEZSxqlOveG966Gwbz5mU4FXZYDM+1or8VBekJX1VXVJKNz5j2eO+CDs92z81zlC2Oag5urlSYBMPBwNCM2VDq9kplJza60sYtxYbzXS/IkCpN26WVrIkg881gY8tFgmkX4egoibbvFQT8RcGlHDpW0l1ZZhL1Fzb6/xF4DDKtVuqx4MobLBW150PkxA33nsnq3p3ZNRA3xP3oFUpptIGnPOr8CUumAHUdNf3GWwoH1lN8SUCwf/KPmBgdxcrFNWxSK7SWZxdC2jCwcz2EnArNtmMC5YzPqKuVoTt9p9l6y0Xd5IuVeLvuSz1llcoxwkVj3z8WoTgSw2vZ0CP+TWFSAu1FYQlIWwA0RXODbMMd9xg2cjzAuXlXbnN63n8Wprmfz6oPLYPNisEW7H6bA8nMQba2himojb6xI9Fb/vH0saVjH/WOZkC4wWPPz4mpDz5SQg+mL7wYrE2AtweOkkV0gzgQoS4GF3Tb4f18G4DESLNBmg367WDFdHiGewYG+2veeFMHmHOT/DLNHq5PgrBF6CqoLSWYWiTTLYte0z+gmqdpt62TO34ycLoG/2N3RFELM75ImwZT/irYqR/3v4DF2CJPnHVeY4uuobSP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(136003)(366004)(396003)(39860400002)(451199018)(54906003)(110136005)(8936002)(316002)(8676002)(36756003)(186003)(26005)(4744005)(478600001)(53546011)(6486002)(86362001)(966005)(6512007)(6506007)(2906002)(31696002)(2616005)(38100700002)(5660300002)(66946007)(4326008)(66556008)(66476007)(31686004)(41300700001)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVl1N2owU2ZBdFBUSk94SG1LMndNR3JvaHhLQTVvaUIrN2YwSXp0Z1B6RVQz?= =?utf-8?B?TUNuRU9XVkx3dmthVWtXQUxMYlVSeExHVnhDelFrNHAyQTJZbWNBNkNhNFhx?= =?utf-8?B?OXZ2NkdSNUlHL3gyNjNLK0t5N2tmQlFpT0tDRTRZVDQ5RmZWWE4yOGFOT2tq?= =?utf-8?B?bUJsSVNDTjR3UzQ5ZDVCRnQ0amgvUDZxeGpTWGxKYS84ZlF2dis2N2o0NzN6?= =?utf-8?B?a3lxLzF3TmZzdE5XYkZaUnl0MDE1WVFjTmduMElhOWgzZXFQKzg5aWQwSURn?= =?utf-8?B?OFFGczNsSHJQR3pOT2F4SGFUMksvbEx3UVd2QWJaNXhlWEsyUGgrSVY0VGp6?= =?utf-8?B?Zm5EVmZiaVc3L1Q2dXBTUDJLcUNSVXE5c1BHMUw4Z1pmc0tmNzFBYVZHeDVB?= =?utf-8?B?RGhzM2JTWVBPNm5KaVNIeWtxbWR6UnNRTXFEc0ZjaDh2ZmFCTzdETXI3QlRW?= =?utf-8?B?L3ZRVnJUVnRhWE9MdjB2OWhsSTVWbDBsTzN6a2lCYnpQUzRjeHgwUU55bHht?= =?utf-8?B?VzZYQkJBRHd3OU9Bbnd3VUFzL21xRlkvajViMDRtRDB3MHdNdk5rQWVHQ283?= =?utf-8?B?SENUd041NDZvaTBKdXVmN2dDRU5tTnFjVHo0cW00SDhXdDc2SlRUN1Rpdzcv?= =?utf-8?B?QSs5eUxkYXY2VnMvLzZYQytlZHM5dDdiMDF3OUlncnVyUkE0Q0VmT0cvcHhv?= =?utf-8?B?SkVneVJCQzIxZ3R6cmpoYmFuR1ovYUhML1AyK2NaNjZ3bGRUNGYvK3p6bS94?= =?utf-8?B?SnlBSHVsVFhEb1JyVnlFM3JSaXhTdEZKaTBCN0grbGY0dUpsclJPTmNKaGRW?= =?utf-8?B?cTBpU245dnovanNPTThkYTJVOFVob0lvRTYwS0crQmFIT0h0NXFGSHJDYkNK?= =?utf-8?B?bkJ1OEYrMlJsa1I0b3RhZERnQ3ViSnhlNExRRzREc1lIWGUyU01idFVKRlJM?= =?utf-8?B?SUJrOGY5TTRUREoyaUJSY3Q2Q2JON1FrYVFQVzMzOHRVVjNnUWlHSmJLbTZP?= =?utf-8?B?aTQ3cnI1ckNXTEVQb3JNRlpBaEF3aUw2T3NDc25UVXJtblkzU3VPN24vZ1da?= =?utf-8?B?ZVJpSjJhWWUzaytvOUpWVytpNUFDOHFuMW5ENXpzSlVlYlVleVNPenIyWklV?= =?utf-8?B?VEVuQ2s5dHc2ZDkrd2NOb2FsSXdWbDUzSlloODNQdm8xWjlUTS9tSXE2YnZh?= =?utf-8?B?NnpQNHgrSjBhQ2d6TDI2UzR3VEEzZktpdDN0UTNRZXA1ay96MzYwd2Qrcjlq?= =?utf-8?B?OVZTakkwSzZsZU9naEhUK1JSTDBQUlRNWjkzSGV3MmJtMXRIWGgwd2FISS92?= =?utf-8?B?TGxNaXB1eFNNQVExQTJpdzk0YzMrRXcxdkFsK2NxMThhL2tlTEN1b3REWmFW?= =?utf-8?B?WCtwU1FlRURCTVhqUjhuZ09KajExQlVQcnJhVG5qRDBTeHJpWjlaYk95M2Ew?= =?utf-8?B?UXNIdkFwU1JacEl6cnJaQzZSWTlsN1U5bTkzRTNvTTJaRkFWL0pBUnBiT2o5?= =?utf-8?B?ZFlhZUlhWDhYa2x2ODRoUmRmM1F3b0JEWHNHblN5VlV6Tk83U1ExMEZkcWpC?= =?utf-8?B?VGMyTjBSWkJIRWJlRm5HQllYVjZxMjJGSEE3UzlPVTZnMDB6TFhkTHRXVyth?= =?utf-8?B?YzgwOWw5TG5MV2w1NWFqYVVOR1ZUZ0Frek51d2VYdkVqN3NmcHAzZUxkL090?= =?utf-8?B?M2R0Mjl6YU5DbkRHWTNHYnpvbnNaODkrMHN1QWR4UFdPMGxjQmlSZXVmdEJz?= =?utf-8?B?aDFvMDNVdEpYR1RqOGhGdDMyNzk4YnlZNTVtRzFraVVWd2xPZDhZdGM3RkNt?= =?utf-8?B?SjB3eHQyUjFUa1JNc1VNdDBxbTgrd2pRM0dQK2QrVlUwb1ZrYldnd0FHQTFr?= =?utf-8?B?WENVN1pUTmZKUkJlTkZEY2x5bWxsaWY4L3p5MndnSVlFdEkvdmFzRG5NS3lk?= =?utf-8?B?U3dDbW15QWh3am10dzJaRUQ0RHh0cDlWcUV4UWtGRXdlb1ZlMkl4MWZUa2xZ?= =?utf-8?B?U2hYbnNtK09jZkUwcDg5Q01oeWlBS3RYak5lK3ZueUkwRXRSenh0Ym02M1ZH?= =?utf-8?B?SVpYcmVENk5PY01aQ1lPM3hiazdkZ0R6cmZFODZoS2I0d2VVaUVaNklDcG1q?= =?utf-8?Q?Qe/+kW/8pFkA8CJhKs67dPB+z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48997c41-107e-4655-873a-08db18a7cd5a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 09:48:38.8486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fp0eySW8jorXtvLRWOu0SLIxobjP+1hWx1c8UFxl5EumFh4gKObovPW7SM91PvRnm8RzgZTZCTV4lrgWxZRnTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7670 On 25.02.2023 17:42, Julien Grall wrote: > On 24/02/2023 11:31, Oleksii Kurochko wrote: >> --- /dev/null >> +++ b/xen/common/bug.c >> @@ -0,0 +1,109 @@ >> +#include >> +#include >> +#include >> +#include >> +#include > +#include >> +#include >> +#include >> + >> +#include >> + >> +/* Set default value for TRAP_invalid_op as it is defined only for X86 now */ >> +#ifndef TRAP_invalid_op >> +#define TRAP_invalid_op 0 >> +#endif > > It feels to me that this value should be defined in the else part in > xen/debugger.h. I guess with [1] it won't be as straightforward anymore ... Jan [1] https://lists.xen.org/archives/html/xen-devel/2023-02/msg01026.html From xen-devel-bounces@lists.xenproject.org Mon Feb 27 09:53:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 09:53:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502311.774052 (Exim 4.92) (envelope-from ) id 1pWaCL-0007UO-Bq; Mon, 27 Feb 2023 09:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502311.774052; Mon, 27 Feb 2023 09:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaCL-0007UH-99; Mon, 27 Feb 2023 09:53:33 +0000 Received: by outflank-mailman (input) for mailman id 502311; Mon, 27 Feb 2023 09:53:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaCK-0007TY-5x for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 09:53:32 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20603.outbound.protection.outlook.com [2a01:111:f400:fe5b::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96a1ab08-b684-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 10:53:30 +0100 (CET) Received: from CY5PR22CA0073.namprd22.prod.outlook.com (2603:10b6:930:80::21) by SA0PR12MB7478.namprd12.prod.outlook.com (2603:10b6:806:24b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 09:53:28 +0000 Received: from CY4PEPF0000C966.namprd02.prod.outlook.com (2603:10b6:930:80:cafe::47) by CY5PR22CA0073.outlook.office365.com (2603:10b6:930:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 09:53:27 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C966.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 09:53:27 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 03:53:25 -0600 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 01:53:25 -0800 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 27 Feb 2023 03:53:23 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96a1ab08-b684-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JzfSAjUq57C8AQhc6Ozxo/ljipf1vX4jmazdbiToaqzIkw5Pt4VGh83n3kkGVKU6uI6RNENwdyf+TKz6IBVc5T9DQvNEnkU3PNqdIGrPGpHXoABA5Eyaiw/DNsIAAuHY6u78mdu/98TvLbq+vOmG/8m2qBxBrTLrY1t19rRZ2ptd5NKyMdcgF6e9QU664/Fk4cgsMm8laoYMdq6/PBWQIKff4D5LY4s4rBPm6bPGTzFGEEM70p6xDPsnjAa4SvOEiO6wPXLWs/vJBrUvRoveGP0wUqu/7TKWsaAPsoPT52u6+9OlWp0slj5xGVUnWMIBZnKbQS3uvORSQe1CrceKgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8+aGyjPFZtYlmEZJ6BhqQiZTpCZjQwGAzAQyCFGUhQI=; b=mmeF1V70sAEUeZa+v7byMkhmLRZzfD0lHZGY8E5CWyY+Cdz5VOeIzqwaSsFdFuvB8PnOBhRhY7XLQKU9tkZJSlaCNtR7hL9DwPQbyGz42U3lNNOn/pfEiaGRoxzKWebrRLcygVq3wzwyUd+jefEJkSVCKiImrnf9Qfnte4296FOZUe+AQLJBKp4J1Y/+aPWeA9DkFHHoiNOyWZegfv8ruWE0bfFlEX+nR+azj6nAWlQ6n02UuBOKjab7gNjAxSPXU4CU2JZ78MrFP3jfGWFTHBCd1WNDse4pUvRqLX23lOzjK6NWP6t83Pju32kKXogGscuBa8obesK4dr7ft1bRsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8+aGyjPFZtYlmEZJ6BhqQiZTpCZjQwGAzAQyCFGUhQI=; b=Al88jI1uD2r0Nwe+E09HKrBwzc70jMnOupL/UtVT7PBFlb5eAtCYz2ZnLy1RKKJFYs5EigDKN62zhhQ6g99Mw0HYG50xpHewDw54IqcifmC78Ma5+6Mhy5LXzeUcosfrRocKgoWDfAdkEoLGuq8psYc71IrsHJ2HzKyTm2V8ERA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [PATCH] build: add crypto/ to SUBDIRS Date: Mon, 27 Feb 2023 10:53:15 +0100 Message-ID: <20230227095315.6483-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C966:EE_|SA0PR12MB7478:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cdfdc62-3317-4c62-093a-08db18a8796b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rW5JjVL58UuLPQqP8YSTmZKOn8Umr+w9EiRT/c2O/j+oTRtGgJgZKTQPyXzZvET9wpw9l6zCIu2F1kQl+Uikh6fxQ8dg7NnlQuLIFdkS10fdftTyE3L0KzDmEvXrHPdD27rMServejuCet+Xeiqsr2EWuH5xUxHJX6Ze7ywBoKY+EruN281i8DAgRI0AHPmVNoPh4e6CuuQ9yvHoWTFUoyJRuS5Bpdcg48fIP4zIhpXxUc/RMOdmAJ1zx1MQIZ/AzENPcj7EvmxxKdacHF0xJQVQ7oDHgtPP5iyBxXPB116FHvduKUntG6g82mm3BWnVcOg7Zx5imNOprISumnUUi63RP1T7ktTaEkU1MohRvNjUVNbdmefjOvpcI9pJvGvQZ5j77RYeAUoknb+hY9M3OwOZalWYlYqWjy5hH/HQlxnAHQQN6TayoMMWBEGy9L4LMTS/ScmtIt82sYNnR7eMBNbg+MuPf42+SaFQ9oePSEAiVNAHNKA9AoMEa0lnApso2JV+mZ8kaOdTOS81/ddRzc4BLsshpOizkYi+7mzkU/493Qp8Ke/c9TI3jMAs0CtPqlSWfjBQspMlJJL+FoD5q+1Hjt5M7DV9TEMVP/z79+ISFsAgeB49zMbX1W3Rca8KN52Jkl551o4/h0DkcGg55NZIq4/lx9M/lkV0yz2+9v1yecugaI5+8a1gSjCOBmBETQkrz7b1PxXdaNenWcJ+GICoZ1XZjPKjBZu73VyQ3Z4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199018)(40470700004)(36840700001)(46966006)(2906002)(44832011)(1076003)(5660300002)(8936002)(36756003)(4744005)(41300700001)(54906003)(40460700003)(70206006)(70586007)(316002)(86362001)(40480700001)(4326008)(6916009)(8676002)(356005)(478600001)(82740400003)(6666004)(81166007)(36860700001)(82310400005)(26005)(186003)(2616005)(336012)(47076005)(426003)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 09:53:27.2593 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5cdfdc62-3317-4c62-093a-08db18a8796b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C966.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7478 This is done so that the crypto/ source files are listed in all_sources and thus taken into account for cscope,tags,... targets. Signed-off-by: Michal Orzel --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index 2d55bb9401f4..27a2034b593e 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test define all_sources ( find include -type f -name '*.h' -print; \ find $(SUBDIRS) -type f -name '*.[chS]' -print ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:07:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:07:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502321.774061 (Exim 4.92) (envelope-from ) id 1pWaP5-00010T-C6; Mon, 27 Feb 2023 10:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502321.774061; Mon, 27 Feb 2023 10:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaP5-00010M-9W; Mon, 27 Feb 2023 10:06:43 +0000 Received: by outflank-mailman (input) for mailman id 502321; Mon, 27 Feb 2023 10:06:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaP3-00010G-RX for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:06:41 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d612dcd-b686-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 11:06:39 +0100 (CET) Received: by mail-lj1-x22f.google.com with SMTP id j17so5793355ljq.11 for ; Mon, 27 Feb 2023 02:06:39 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id e6-20020a05651c038600b002934ebf2f6asm670115ljp.73.2023.02.27.02.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 02:06:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d612dcd-b686-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=treUYICgArfcv5NTJiKLwtwiypW1saXfGPcvwV2iSdo=; b=e3aEZriyaz3dBeUeg86QJHeawQVzj4/T94bs4iwpzE4lkqAO8bt1cqEC3bsupVWX/c ugbk7P6FByR197BoogVHPxBYnhwUgh7G4oQFLmOZP6ioKIcxE0YVxAw+xr+ybJ0LWNHo pVIaKk3pfbppg8NyqfSEuZ6VL138WdbLwIPJ7l20V6dX0AxN/ON5Db9K46cN/J08sa1P 3Qc33ZLkUk/qFjnkYoQowU+RhF4bXkjA/zr05eSRKFSLVAmWFWI1pGHUgFV6djJGMkl7 SFkSrIsosKTQk6kjxtL2H+gLwBbNpZeA9ZrQU5Zfgh5WM9EYhcAz0EUDIaYaDJ7gp7wB BBDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=treUYICgArfcv5NTJiKLwtwiypW1saXfGPcvwV2iSdo=; b=M1csQG/1b1V0+7Ba+GbRamvGNgKTueupF9NNUGAotoOwdzBwraGLWzjyEmm7WM729F kqoiXYH4uRBugkRXgCaa2+jQnGJsXG1V7U/dpD2CaxW/pUXZqMrPwY7WgDm5EkRUX15/ Euv8yO7ChCfC/RDCt5GA1/3FnK5OqSJzy+2RGXY2g+AJyg85K/8kmAWKyN3a/aLLETkN x3ghtax43NKRDOkBvs1TGcRuBXJycoGHM6fxk0tgaiWNl06uTnbs/+1KrzfTlTc5PZnD gKD1ikDwTu9fp4XkFcESETpVxSymMG7t35NgqJlaR2DHi+fG458OkzluFfJJ4klx5DJ4 u7wA== X-Gm-Message-State: AO0yUKWzSdwvPLjkVTwBV9aWJjFcMXv6YMjXiz3J0RFeVmNER5Y1i8fx NNAzU6G91PL3f+PatzSOTsE= X-Google-Smtp-Source: AK7set9r5yiRGC8mrV6z8MG9ev1gGTlXmjtzc/yAP3xIoQmrP+DVo7ZRTg6FDNUIfBi/m76qm6b/qw== X-Received: by 2002:a05:651c:211b:b0:295:9d32:a673 with SMTP id a27-20020a05651c211b00b002959d32a673mr6801088ljq.3.1677492398947; Mon, 27 Feb 2023 02:06:38 -0800 (PST) Message-ID: <76fba853b0997db19b62839f2d2b1280c9820ffb.camel@gmail.com> Subject: Re: [PATCH] xen/riscv: init bss section From: Oleksii To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 27 Feb 2023 12:06:37 +0200 In-Reply-To: <349f4817-ab12-b648-a0d7-76ed4aaafc74@citrix.com> References: <134bf758ecd93deffc6623605a8c020a17f64be8.1677249688.git.oleksii.kurochko@gmail.com> <349f4817-ab12-b648-a0d7-76ed4aaafc74@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Fri, 2023-02-24 at 16:55 +0000, Andrew Cooper wrote: > On 24/02/2023 2:48 pm, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0xen/arch/riscv/setup.c | 14 ++++++++++++++ > > =C2=A01 file changed, 14 insertions(+) > >=20 > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > index 154bf3a0bc..593bb471a4 100644 > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -24,6 +24,18 @@ static void test_macros_from_bug_h(void) > > =C2=A0=C2=A0=C2=A0=C2=A0 early_printk("WARN is most likely working\n"); > > =C2=A0} > > =C2=A0 > > +static void __init init_bss(void) > > +{ > > +=C2=A0=C2=A0=C2=A0 extern char __bss_start; > > +=C2=A0=C2=A0=C2=A0 extern char __bss_end; > > +=C2=A0=C2=A0=C2=A0 char *bss =3D &__bss_start; > > + > > +=C2=A0=C2=A0=C2=A0 while ( bss < &__bss_end ) { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *bss =3D 0; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bss++; > > +=C2=A0=C2=A0=C2=A0 } > > +} > > + > > =C2=A0void __init noreturn start_xen(void) > > =C2=A0{ > > =C2=A0=C2=A0=C2=A0=C2=A0 /* > > @@ -38,6 +50,8 @@ void __init noreturn start_xen(void) > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a1" : "=3Dr" (dtb_base) = ); > > =C2=A0 > > +=C2=A0=C2=A0=C2=A0 init_bss(); > > + > > =C2=A0=C2=A0=C2=A0=C2=A0 early_printk("Hello from C env\n"); > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0 trap_init(); >=20 > Zeroing the BSS needs to one of the earliest thing you do.=C2=A0 It reall= y > does need to be before entering C, and needs to be as close to the > start > of head.S as you can reasonably make it. >=20 > I'd put it even before loading sp in start. >=20 > Even like this, there are various things the compiler might do behind > your back which expect a) the BSS to already be zeroed, and b) not > change value unexpectedly. >=20 >=20 > Also, note: >=20 > arch/riscv/xen.lds.S-143-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 . =3D= ALIGN(POINTER_ALIGN); > arch/riscv/xen.lds.S:144:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 __bss= _end =3D .; >=20 > The POINTER_ALIGN there is specifically so you can depend on > __bss_{start,end} being suitably aligned to use a register-width > store, > rather than using byte stores, which in 64bit means you've got 8x > fewer > iterations. Thanks for the comments. I'll take them into account in the next version of the patch. >=20 > ~Andrew ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:10:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502326.774072 (Exim 4.92) (envelope-from ) id 1pWaSS-0002gx-RM; Mon, 27 Feb 2023 10:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502326.774072; Mon, 27 Feb 2023 10:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaSS-0002gq-OE; Mon, 27 Feb 2023 10:10:12 +0000 Received: by outflank-mailman (input) for mailman id 502326; Mon, 27 Feb 2023 10:10:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWaSR-0002gd-5h for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:10:11 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20627.outbound.protection.outlook.com [2a01:111:f400:fe1a::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9e93188-b686-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 11:10:09 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7121.eurprd04.prod.outlook.com (2603:10a6:208:19a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 10:10:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 10:10:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9e93188-b686-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCBuojq9wpKDjs69h2BJPNokmRkX9GZCDI9XDlmRJMbKmo7vvl0OKPeiSxOcUJTNTY5zJX1YpcZNY7+jTyj284AqHo2Nab3d8H/3/WUs77P/G/o66Qdzl3z2dT4WgmAY4SScP0hTVj2p0a4u378grNWRMKAligVPp16uQ5Y4IK2uYVr5CJYV71JATf3aNBaMEdmPrZdwPNv3E1xJT70qFr2U0vot9hLOoS4/xQmnb5fFkkc9nuVdSuUADjwUD3uop7bA1cdb+SEm6Isz8ZHfsqDXVoJkP5fU1wmKJoL/yphiQGDlcVsJvwW4cgpUymRY7+FHX2wEVpYTtaPO5gK2CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rya8ckti/z1muuzqQprH8wpyD6pFZgRxIBnQYYpvtvk=; b=FPyjaSSE+8pJ5nKELarDZKtpL281d9GuQ+6sIC6QjruqhOWLLUfTilUPd1/+j7EXTDn6f/8g6tndmh5JrxKd/8DWqVHyuzffHEX/vMB9afCy1myurK0BeYg48JINwy0a1zDYLgIrk5ZRKNDJxuHnn6SNvd0ce64IzeB+2t3ncCgOQPfQHPhm3emGEJPFcxZMOvuuzRg5RE8EMjNikc/oQDErgm6usHljwgOzuwT64GJIJV2Lp0lrNTsaufj21irCwMOkD65tJmDlSi8NsBrd7M/Y88A/dHzYPAfygO5vlAe2ngw12bcXBTDUirM7Q2YwxYUCXAEdzLjWnk/DcokGFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rya8ckti/z1muuzqQprH8wpyD6pFZgRxIBnQYYpvtvk=; b=RIbFXTKnc2j5hhlbyBVKs3LEe17t7iiPPbPjc/2onqQk7b2nPb7La+EDT8B+BmbRcuvHhQtQtKZaPzF/1PJWIqG3MsIpM54SpdcK9uejjbt7Ad9Y8Xrvkyrbdf7qYvBhgPlPZMO9J4/wSb6Tq3dbiHB5pgtizsTNkm1uPZ/RyewNhmGEEyIG2M4Lu9F6uNSEkUr0IvhQ2WKOOs4FDq8qFLSo8W3RbDVrEGomSN6v5TqYDHByhQ8ITqb9SqwuMCtv7SnupXOFOrJ899jIGwksrvwE0LsE0FoV/1we5EcHnymfDW0IHypPMCRqaSYvKEbbTnhiPD+DqWCdge8zfqlT5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 11:10:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> From: Jan Beulich In-Reply-To: <20230227095315.6483-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB7121:EE_ X-MS-Office365-Filtering-Correlation-Id: 35755093-9fb9-4f52-c516-08db18aaccda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UmJFO40bHICAwh/OqWUBigByDIZG2u10zYh0a+xyakwRoWNcYk830fZjxeby/we7I33Sw5oGuDqRRtyAUiZibvcwLSJ5T0NPJ6NJJc3xa5z0LWd+/hQJjxwgK4nsd4iCsKao4nPcnqemfhAW/4kAku5icoutER3CtNFN6LHWjJ1eshu44UauvyMYTbSXIIQPtIMkjIeZnFeNEz2y4VgaCg8apUETs8EufYmPJR+gNKdqqE0ciQ1WQ+nrH6uYULcZt5nKkkNv3sIlzICz9XTLULwvP4+AYXQ8voK9HRfsB0guFVYqmg4VBETlysi1GBvUnaQwg35Ixap8dvrP2vomcm5irarKlBXqDGZWdKIqmgGZ4bm1SozdMVHYIxzl/VTLvAjynyjBZX8gZF+S0aT0z4nIEeHJZI1sbrRw+uAhJoq6x1FojYl9TlhwXacUqq0bPU9F7FfPs3y2iKkKKhROpXrRa1+fnNFCblPDCRqV316AEKUykB57R1G2TsOcRDcMznW0bKn9mAHcSKkvEMhPr1sMMJBpm0+8GXhuPAdymNvqcZVDoC2r+ihj0qAgCXof8aWgF1KKt5tkedrtZF4pytQBYvZnq3lpQPhjyew2UxqUYyL3gFez0l7jADLOcWlRFf5SX3ahimZtnn6pHRTrN+5gOwsv3jBY4DYoeNSfsmsTyEBGnt+bVJc9dV9w7jKv94lrhUnE4dvOPMeZ36GszY0hoUbA4Yja6BaY27qyS1I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199018)(6512007)(6506007)(26005)(186003)(53546011)(41300700001)(6486002)(36756003)(31696002)(86362001)(8676002)(66476007)(66556008)(66946007)(4326008)(6916009)(478600001)(54906003)(2616005)(31686004)(316002)(5660300002)(38100700002)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZmVktnKy8xVURNYVZMTktNVmZ4OGFDNjRvN3BKRnpaeTBUZEZpakFkc3ZN?= =?utf-8?B?elJka2VDWUFMc2lMSDZ5b3VBYnF6TWVaUzdJRnJTdjdFc0I1ek9rYk50R1Bl?= =?utf-8?B?QmpmbzM1Ykw3T1BDb3NqOHdjUXk3V3FsR3FJM1dIZW1PWWVKV3o3cjRiTWxh?= =?utf-8?B?d2RwOVhBdTRocTdiK3ptQ0dpcitMN1dVcnhpNGdFZ2UveHpQcWpDZWpsOVps?= =?utf-8?B?L28vY1FBYzZ4MG9XbkNseVFRcks2Sy9zMW9BbDZJQ1JXbVBTQjJRZTNyOFRx?= =?utf-8?B?L05QeGVLRFZ3cWZuNlVQU2wvOU1TaUo0Qy9lVnpqSzZNWGxNRXQzSWcwRXNi?= =?utf-8?B?b1IwVFNyNnpEV0hueGI3YzdvaldldS9Lem1Xd3RIdTZsaEZ3T01FVHNlUmRk?= =?utf-8?B?NWlXUkJpc3ZpTVFtRGY2Y2phdUpCbVdJZ2pBdVFzS2FLWFlyN0doeEkwbEUz?= =?utf-8?B?ancyWTR6N3M3S3hiOXI0aTRHeFVBUGU2cGhHRVdINlNGUXJURjJZTWJqOGNY?= =?utf-8?B?TFZYbXdzcGU2S0tjUTFVU2R1K3Z5MGRXZHV4aTlUTUlHekdXcWJNZkZLM29S?= =?utf-8?B?ZVBzeVp2UnRQL3E2Y3BsT0N0WVJySnJia1hXNGpxcFlQd3d6ZGZzbVBMZG80?= =?utf-8?B?Ym5DZXZ1OGEyczhXMXdSeVhjQmVJY3F5ajZLSXJKanhGYkxrUk9FWnhBTjUy?= =?utf-8?B?UzZlZVRuNkE1SUwxTDJrVzE3aVZRYXBmWEpuRnZEbUxvZUdEV2lMcWE0bWox?= =?utf-8?B?N2VIdGlhTjNUOFJCSEtvM1RjUkVzQTFSb2lBSDNUamtjeGdpdXJBQkd1YzQx?= =?utf-8?B?WDRiMFptcDliNjFWQXR5V09mOS9uR3p1NThZbkYrellaamZvYjA1RHRFc3V2?= =?utf-8?B?ODIyREZUNlgxSTBjT2ZCTkRUUTVwTGxtYVhGUDNKWG41THBtOTVGRzFEZWty?= =?utf-8?B?c0dMaU5RMitobE9ic0tIdW83VjRwcEZjakp1QTNGN09ZK3BVd2hkMklMN2Nr?= =?utf-8?B?ZG9oM0VaSEdQM3lhTWtIMVR5WTlVVGVxQ0RweWJMZmR6YXlSV2FWN0hhZHZQ?= =?utf-8?B?RXBDNTljTUZ4MWpzVFdGbk80Wml1ODZjektkbDVMZEovbFpIaFliSVo4cWMx?= =?utf-8?B?U3Z1NExxakNmYTk5ZG5VSXpRR0JtSzl4bUMwcnIvKzh2VlBPakxIN2xQRFFC?= =?utf-8?B?dUpYWlZoV3B2ZGVtN2NWemt5dEhtdjJmTEE4VkR3bzJvdVk1YzJEM01nSzla?= =?utf-8?B?OUdlUFozdjJOL1RCSitWQnZKNDZFS3JkeUUycm1MVUR1aFZyMWJybFZ0V2Jj?= =?utf-8?B?Z3RkcDRFZ2QzVkRheFFNdEtZRE4zMFNNdDltMkpxbDBReXc4SG9CZWFxei9Y?= =?utf-8?B?dGNvNy9GL3IwOTY3THZqUXd3RnE4dnlIQ2JmejhVN3EveTNNaFdWSHZDSDVC?= =?utf-8?B?NmdCTHo5SnJ1NGNZVGQ3NVFCQ2tQSFJCUjlqbzJqdWIxL3ovNUQzWnNUbDk0?= =?utf-8?B?aDJpR2pXeDEyMWErWExTREVYb3Y0WU9POFFHcG1XekNwQXorbHA1bGl0Qm1y?= =?utf-8?B?SERpV3BPNzJlTVNIVVpGbWhkNVdlQjNDSDNzSlp0SklIcktSY0FKOFVuMlVs?= =?utf-8?B?Um5QcmdBVFAwaG0wVXVLT0ErUTExT2VKZEZNdEJpTWtyTzJ3R1VQcEF1cjZH?= =?utf-8?B?K3hjQkp1YnM0TnlYQXk0cFJuMmNNNmdVY1JZYVpLZlQxclF3cFdVVFJjcFlS?= =?utf-8?B?VFNpdjlmZ1M1dE1lbzVheFAvY1l4OG5uRG51TDZKbnVDbnMxbU9WOTJ2bEZD?= =?utf-8?B?UGRkYzZzT0V5Q0prOEpxVGFoV3FMZlArZTBQeVUyaWU2Rkd4dlZvK09wN1lP?= =?utf-8?B?WVBCbjJWNWtaak9MZUxJdTVwR0Zuc1ZZeDRaN3NmWGZsYnhWazVZbGhqNlNu?= =?utf-8?B?QlZUazh4YjZtNVBRc1ZsOWZFUkg0cGExR2cxeDRzbUdBYjVqVk1Pbjcrdk5C?= =?utf-8?B?ZTVZZnhJckMrZmd2Zm9Xd2FCTzRGOE8wTVlHY3VJekljTnMrVENFcW1sK044?= =?utf-8?B?eE5mc1pVdEFOUDUyRXJ3Q1RuTk1Oa2R6cVBDQ1ViTFRvRzZvZndseUtYUHFV?= =?utf-8?Q?FENgipjK+ywQLeadz4FrRwr2G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35755093-9fb9-4f52-c516-08db18aaccda X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:10:06.7359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /4M+xmCS4xzQCScbVfnJ0Gs+10N+dDaqeSb0z6Z844t+hAD2VVXDG3Y0q6/rkvXfSa1TByTWJigcuiyyK0YqAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7121 On 27.02.2023 10:53, Michal Orzel wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE > $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h > $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ > > -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test > +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test > define all_sources > ( find include -type f -name '*.h' -print; \ > find $(SUBDIRS) -type f -name '*.[chS]' -print ) As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo also only be included when selected (or at the very least only when an arch might select it, which afaics is possible on x86 only right now). It would also help if in the description you made explicit that SUBDIRS isn't used for anything else (the name, after all, is pretty generic). Which actually points at an issue: I suppose the variable would actually better be used elsewhere as well, e.g. in the _clean: rule and perhaps also in the setting of ALL_OBJS-y. (That'll require splitting the variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which has caused crypto to be missing from SUBDIRS. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:28:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502335.774082 (Exim 4.92) (envelope-from ) id 1pWakE-0004fy-Ft; Mon, 27 Feb 2023 10:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502335.774082; Mon, 27 Feb 2023 10:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWakE-0004fr-C1; Mon, 27 Feb 2023 10:28:34 +0000 Received: by outflank-mailman (input) for mailman id 502335; Mon, 27 Feb 2023 10:28:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWakC-0004fl-Bx for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:28:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a2457e9-b689-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 11:28:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8631.eurprd04.prod.outlook.com (2603:10a6:10:2de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 10:28:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 10:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a2457e9-b689-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqulIReHECLUFgreDXBVhDPwpL/bxAo3R9d38gI7Z84XKQw/ULD8ovys6ehk6jTw7gHwWm8vueoJvD3lt/RmDNv2rU+chaMwqZEmAZ25jSMWFA5/33bkBYZjkrFAJh8w7Gg5v+jSuZIwuKXkgQRrXW0P5AInLwtreP4DPMKHr6vzMi/YPp37SgYqZv5aplupTAgU05kV+xJTJ7a5KRXph1pm9GL02EqvUBHWmIO5CsNUQzFFag2/3gukPykMuaBDg9fPPU2uD8T6dK0q+QYOsPVkEjFqzDOEy6FXge+J3K3AOrrVUtYmraMaT2ZSBNetLJXqU1b9lEx1GaZXjZ7z1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xemvVeuHKZ4/0l9nmKQQeEDDCxZXPRnuijuLdkSoXkY=; b=naeLn9uRGH8OcNAYGozOjJYi5teDUxjIIImWGhepay+9/K67JUzTEHJ7BOAiWu5mVOWWafdKFPCJI5TuunT4vbE/HmXM0UkkXGurHvTKPGhAZjpB+PNA0LfjnRAdeh/h9CB+12yxRkVJVMC0AZiUSZtsS7H0cv3nb9IkokrIwkECRm29f3AXA5TZHL2ui09za2W+hH59l/gQZdUFrb4gTHh63grZcPjG0qoiG/pEQi19bKfAvrHzzREtwuSrt4NbFtjcn0IcMHPrMG5lvOow27pIwSATMxeSSFTIAU5MVbU0J1XbyB7e7yaDzK8tyNseZfRd1G8liejfCwG8Ctlrpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xemvVeuHKZ4/0l9nmKQQeEDDCxZXPRnuijuLdkSoXkY=; b=FOjKPl2YByrB60yuQDEUqm0zxNDZy/BnWj1FPFQs7/u9XJb8E1zWJs/wfSwzaycwpol6wetnlucsM0mzjE0P3XCgFwCbC0vSJKd3wJvFI3GlpmJ5UB4YK2wmbMe9ItIVKwH1ea2LDCA80Ql88T7AoP1dfYCLBeZotGlbnkmL3CZShuArCA+iQui/XbvhL3sKDUXxrAuiOtH7ymZ7Ft6igbxUV93V8Pw9vfMLI6ZCqWKZwBaRYVpPGIugrCCYav3Syah9wh5RpE1ZBPy3hYLqMgiQrXWODVjaG0eoih45JBEfmy+l0jeF/NbNRZFmTxtM+Dl8wl24xuhQJ4RbLVcXBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9fbbfa17-821f-8c9e-376e-911481a1988b@suse.com> Date: Mon, 27 Feb 2023 11:28:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Drop ELF notes from non-EFI binary too Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230225235642.38880-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20230225235642.38880-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8631:EE_ X-MS-Office365-Filtering-Correlation-Id: bd059842-3b53-4a44-3af8-08db18ad5d71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QXcS9EMsQ9cSIulD0fy1V6Fc81OMrC60i/sFiY3g8We67nFd3wtAPqn0o/SdgZK+F2WB4xLHEjaEgdJV/rjXMzvCO/Fa2XzEiwpvv0/8V8vin9LzL4LDzyUAH4T4GO/G2MGjCdQgzD1GbBYJ4uuwKxPRooowJfFT7OyLrcYLc+iWT+DsYuVPtY7lnVuDRhGYYqfTY9cFrFDnLlkj5pHuN32hhTJkWTPoJ8W4UDhI/HQeRqJGRod9qdeS0/HbR9F3QMcC+f+axcXpxImqQBRjpi/keQ0Bs4Z466hiCAIeRAyC6Vt8EmyrjVs03rYJBK7hhL5LN+wQP/waQKPUPc8nPv41UY7ytkmBlo5/8KiYrxU8rFsgNsVDWXgdFUUp/V7btrMOp+BM9FcHPMpQ2LZqB9GAiN4Csv5Rqf95a3KRhctvsU9qYJkOBmpD+KalvONnrRYPp6oS0koSHig8o7lD08InUPnl5RWiGpJRaWGxKiv2lTDKoIPZDLoov2IZjWwvEDfK/X6ZKi/4m1sPEAJx8OD4pvdjmUQyPjctm/O0n1LZBsAzchgmTkukRH63zGvWtzYKgvGXJgr5/RYY7WmiF7ibS+5eKTE+FQrc4AdQuehAf0fJMdV6cj3HWC7+hpSn/X4ocZu2FcKDScV6V/QKdtyN8uDtX+8vG3oZPTK+d30bEpj4UXMVMLEqYa2QDDCFCf8Rx6/Kts9Cs9sOyH1AHYnCpN2iSLNm8JCjBE1ilCo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199018)(8936002)(2906002)(5660300002)(31686004)(41300700001)(66476007)(66946007)(66556008)(4326008)(6916009)(8676002)(316002)(54906003)(478600001)(6486002)(26005)(6512007)(186003)(53546011)(6506007)(2616005)(86362001)(36756003)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHV4ZGV2U2pzNWtqZ2RYWnE2ZkwzTGRrS1h3bkhVenk0bGNZSHprbnB5blZG?= =?utf-8?B?L1dkeXJsenhxM29Za1VFdHgyaXg1eGJJZFEzaVlXZzh2T3hDR1k2bk1rWDR1?= =?utf-8?B?UzhaQnd2SC9KV3RiWUYxTE5YU0owVisyQWt3TGY5K29DdG5KR216ekx4TE4x?= =?utf-8?B?aHJHdEplTWgwWHVmcEFuS2MrcXlrdkpNUGcrWG5zL0ptWmdMUUlEVVNKbGlS?= =?utf-8?B?QXR6ODN0UFl0Q3kwTy9iMXBOVzUxWjlMbHZIUDhxSjROVHZVYW9YQTk4M0RT?= =?utf-8?B?bEFCZHF1V1hOMmU2M21CbDU1S3JMSll4NXZjTWlXUDdOK2R4eURIQ1JOQlBK?= =?utf-8?B?VTFWdmRqNU1lc2FyNCtUKzVJSW8xRmdET1IzZVpTV3R6S1paTnlyUWRMZWVt?= =?utf-8?B?Um5QazRoK0tpR3FDT1EzN3lxZ0dXbWMxWmx0MkRIcG5VejlLY0gxc2tZTzkz?= =?utf-8?B?SWxFMno3eTQ1elFSZmVGNEdJYkJNTGN6dHQ1UTQ3dnpaNnRWL3RHU0IzTTBl?= =?utf-8?B?K1dBYjdPNzg1ZHFseTZlcE0ydVFIVGFBUDNPbkkvOWlYTmlscVBxMWE5cDNT?= =?utf-8?B?VExxUmhENENuYW9JazV2RWx2ak9VTnpMYkZwNFNWbDlUZlJJYkZwWXhBRWRo?= =?utf-8?B?UUFTN1JHUUdmNXY3bS9YTjV1N3E0cnBTQWdrdW0wOVgvM1BTN1kzZEVxZ3o2?= =?utf-8?B?TllWWGlLTGp0Nk5RZnN1ME4ySS9NK2t1ckZIS2NIaVJLWmJNSlkwQlNYMlg2?= =?utf-8?B?dXRTUkpkWXNHa2ova2UxT2oyblNLeU9SbDFRbjlPMlNNZzcwL2hDTnh0dXdF?= =?utf-8?B?bFRnVE8zZXk1ZzFVSzRuUHhIKzJDSmxXRlFvbmhkNG1jYWFlOURpR2dvVmg0?= =?utf-8?B?ZU5nNW14VXdRMmZFelVLWEEzYm5wYXN4M2ZLSklqcEZOSmNFOER4UDBSNDFn?= =?utf-8?B?ZndqejZDNWhibmFJOHJBOG5TaXdHK1Q0SjR6dFFPeHhHcC9PcGRoL2pqZ3Fx?= =?utf-8?B?TzF6bFlOeUluYTIyZVZ2STNvUHI0bm5Dejd4VVRvdzNYS2FLT3R6YlpOU29h?= =?utf-8?B?QmdVREx0QndXdzg0VENXUDFONjh3Mk5YQ0VNa2N3VVdYZ2IzdGZrM2NvTGFZ?= =?utf-8?B?bXhaSlJMcmswSnR0SlRIY2gycUxLVkIxWnZrSkpLa09aU1NtOEgrTlVwRGt3?= =?utf-8?B?TnZTYWZzUXVLL3RWUVBOcHJyNHVhM2VxbGZwY08rS0E4Q2ZtK3NlaENyNFM1?= =?utf-8?B?R1haVHlkWDAzdE94REZueGpjV2xyK1hzbUlTSnIwQzFKL2NnbVorU3p5Q3I0?= =?utf-8?B?c095WUFEdWJnU1lCbFh2Zm94MUJVZlJEK2Z5REt3QVRvNFpNQ1UrdFMyWmhL?= =?utf-8?B?MWRsTjFGdCtxVFNNNlVvQnJMRkxrMDFYendOQ2RSL2xaUkswbmtZWGVmT0lH?= =?utf-8?B?dWY4T0dMTGJzYVRhQ1VGWkZPdDRzTjNkWi9PS1pTdytyYjNLR2VzaWxSNU1N?= =?utf-8?B?ZDh4ZmVXZDVTamt5OTAvRG5pUWkwejQ5aGE1R3B5Y2NJZWlwZURoZVVYb2x1?= =?utf-8?B?T3NORmlZVGkyeXZVSEFLenI5WUZleHRyQnJBdnhLeGg2UllMdWpzMVF2d3FP?= =?utf-8?B?bUloaHFTSDV0cTZaN3pHTzdWVXRiTUsrb3IySmFWZVdOVkRSeVp1M1JLdGd1?= =?utf-8?B?SiswM2F4MWdjZGt3UHZ3L1ZsYzljL0RzOTFHeVdGUkVuSjRLMmhJdTlSb3Fq?= =?utf-8?B?amJUVEkwVnUvdXRKWXJqRFE2TlpKajdKdjZ5TVRUYXhkLy9lMnlpSzJRT2U2?= =?utf-8?B?MmVlQkFTNmhTVjB0TDVQVGwrYVplVndPTlRCdExXTTdJL1pBZjB0emV1bTdD?= =?utf-8?B?bFF6azg4QnF6TktDODJnVk1yeXc1eityVUN1NjQ2QXVRWTMwd2c1MklhR2dr?= =?utf-8?B?M1RzY1N5V0dFUWpZbjZIQ0oxZzdpSVAxc25PZW1NN1NTRHo4My9neGhqai9n?= =?utf-8?B?NE9Ib1RIN0JqY3BsVlFVdURQK25UaVpudTNQQTUwaDh5bFlISks0ZzZSUFNj?= =?utf-8?B?d1VTN1A1ejRwL0xFQTJtNXFDT1NWU0ZIamI1RGdoaC8rUmhNdXVDY3A5NFlo?= =?utf-8?Q?ntxp5uH5kbhxnBDLA5DcFYU1o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd059842-3b53-4a44-3af8-08db18ad5d71 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:28:28.0886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q85rndYDbrjHMZyVuc06nKA5oGSLPsVr+aZorhbib3JR4ScZxOvPiRUfue0egV5z50pJq6/vTZah8aO+pFZEMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8631 On 26.02.2023 00:56, Marek Marczykowski-Górecki wrote: > The ELF is repacked from from 64bit to 32bit. With CET-related notes, > which use 64bit fields, this results in 32bit binary with corrupted > notes. Drop them all (except build-id and PVH note retained > explicitly). > > Suggested-by: Jan Beulich Perhaps a misunderstanding: Yes, I did suggest this as a possibility, but I didn't really mean we actually do so. At the very least not without further clarifying what the cons of doing so are. The notes, after all, are actually valid in xen-syms; they become bogus in the course of mkelf32's processing. > --- a/xen/arch/x86/xen.lds.S > +++ b/xen/arch/x86/xen.lds.S > @@ -192,13 +192,6 @@ SECTIONS > #endif > #endif > > -#ifndef EFI > - /* Retain these just for the purpose of possible analysis tools. */ > - DECL_SECTION(.note) { > - *(.note.*) > - } PHDR(note) PHDR(text) > -#endif > - > _erodata = .; > > . = ALIGN(SECTION_ALIGN); Is this sufficient? .note.* isn't part of DISCARD_SECTIONS except for xen.efi. I would expect it needs to move there from DISCARD_EFI_SECTIONS. Otherwise, aiui, the linker's orphan section placement will kick in. Yet at that point you'd also affect Arm and RISC-V (which, interestingly, don't place .note.* anywhere at all right now, afaics). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:37:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:37:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502342.774092 (Exim 4.92) (envelope-from ) id 1pWasH-0006Sb-9e; Mon, 27 Feb 2023 10:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502342.774092; Mon, 27 Feb 2023 10:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWasH-0006SU-6n; Mon, 27 Feb 2023 10:36:53 +0000 Received: by outflank-mailman (input) for mailman id 502342; Mon, 27 Feb 2023 10:36:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWasG-0006SO-5C for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:36:52 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4887a17-b68a-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 11:36:50 +0100 (CET) Received: by mail-wm1-x32e.google.com with SMTP id m14-20020a7bce0e000000b003e00c739ce4so3502648wmc.5 for ; Mon, 27 Feb 2023 02:36:50 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id iv16-20020a05600c549000b003e0238d9101sm9525650wmb.31.2023.02.27.02.36.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2023 02:36:49 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4887a17-b68a-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=a8pB/BCHGRqVaLWNW4zGNZH93WiFNX3eE2S7y7D/bYY=; b=VOo/rP1ba4GwSb6W954ILkbAMxmWKcJZM25yr5NX29v3ujDNfh60QWCyUJrBbLti0P boZXsL55hEJ/VWXE70R+7cAB6ASAJ9wm+uaL6djM1KhLYN2Uxmo9PNN4JE9ghvRdRFdp 7usQExGCWon/aOrafPMxOpvMXO5nWu0ywDxSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8pB/BCHGRqVaLWNW4zGNZH93WiFNX3eE2S7y7D/bYY=; b=Bz7+5IF8dtDvuSRLQ0q80lubuslBBqfNysBA4BBBSlHogEjzZC8S8Lmy6rQ64amyRW saLA3PFiVrtuGn7zAqhqbEoiZgYx+07LA9kOzbVQWPJQBaYrKAXkhWc/j2pJ/S4lJ9O3 xXfAnP2QWK0snU7eLzfG1V4pdSUAfNHngcKRpKk61hqSzY1n0wxtOB3ARvCPfWDH3aoA 1H2MOO6qqJw8tAUYDfAaQ3N/s8oKUn4WVEw8gTl00UDuM18lAxjY/yiIQiQe/ylnSKsC 36uMX6YGG+XoqEPwsnHNngbJxt9RMofytJvlJuiyiaVLQfXPrLaVnaMWrsUehR+rRf/k bbzA== X-Gm-Message-State: AO0yUKXcZBYAIDDK0NlX7pccgJGsteW44pfc2Zu8hz1bhprnN9KfpdAg k1kMagMxKqEBZEIDwKCa/aJgQx7cGukiWSf1 X-Google-Smtp-Source: AK7set8sDMia5Y+6XWxLJDMwaWjcTomucsdmg5mcO+u0zHPzcWMganhS2iKrfeQ/16OZBhG36BFUGg== X-Received: by 2002:a05:600c:34cb:b0:3eb:a4e:a2b2 with SMTP id d11-20020a05600c34cb00b003eb0a4ea2b2mr8913567wmq.4.1677494209629; Mon, 27 Feb 2023 02:36:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak From: Edwin Torok In-Reply-To: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> Date: Mon, 27 Feb 2023 10:36:38 +0000 Cc: =?utf-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Juergen Gross Content-Transfer-Encoding: quoted-printable Message-Id: <050C988E-3E83-4F1C-87AE-9B221B04EB81@cloud.com> References: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> To: Andrew Cooper X-Mailer: Apple Mail (2.3731.300.101.1.3) > On 24 Feb 2023, at 14:56, Andrew Cooper = wrote: >=20 > On 24/02/2023 1:36 pm, Edwin T=C3=B6r=C3=B6k wrote: >> From: Edwin T=C3=B6r=C3=B6k >>=20 >> Prior to bd7a29c3d0 'out' would've always been executed and memory >> freed, but that commit changed it such that it returns early and = leaks. >>=20 >> Found using gcc 12.2.1 `-fanalyzer`: >> ``` >> xg_core_x86.c: In function =E2=80=98xc_core_arch_map_p2m_tree_rw=E2=80=99= : >> xg_core_x86.c:300:5: error: leak of =E2=80=98p2m_frame_list_list=E2=80=99= [CWE-401] [-Werror=3Danalyzer-malloc-leak] >> 300 | return p2m_frame_list; >> | ^~~~~~ >> =E2=80=98xc_core_arch_map_p2m_writable=E2=80=99: events 1-2 >> | >> | 378 | xc_core_arch_map_p2m_writable(xc_interface *xch, struct = domain_info_context *dinfo, xc_dominfo_t *info, >> | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> | | | >> | | (1) entry to =E2=80=98xc_core_arch_map_p2m_writable=E2=80=99= >> |...... >> | 381 | return xc_core_arch_map_p2m_rw(xch, dinfo, info, = live_shinfo, live_p2m, 1); >> | | = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> | | | >> | | (2) calling =E2=80=98xc_core_arch_map_p2m_rw=E2=80= =99 from =E2=80=98xc_core_arch_map_p2m_writable=E2=80=99 >> | >> +--> =E2=80=98xc_core_arch_map_p2m_rw=E2=80=99: events 3-10 >> | >> | 319 | xc_core_arch_map_p2m_rw(xc_interface *xch, struct = domain_info_context *dinfo, xc_dominfo_t *info, >> | | ^~~~~~~~~~~~~~~~~~~~~~~ >> | | | >> | | (3) entry to =E2=80=98xc_core_arch_map_p2m_rw=E2=80=99= >> |...... >> | 328 | if ( xc_domain_nr_gpfns(xch, info->domid, = &dinfo->p2m_size) < 0 ) >> | | ~ >> | | | >> | | (4) following =E2=80=98false=E2=80=99 = branch... >> |...... >> | 334 | if ( dinfo->p2m_size < info->nr_pages ) >> | | ~~ ~ >> | | | | >> | | | (6) following =E2=80=98false=E2=80=99 = branch... >> | | (5) ...to here >> |...... >> | 340 | p2m_cr3 =3D GET_FIELD(live_shinfo, = arch.p2m_cr3, dinfo->guest_width); >> | | ~~~~~~~ >> | | | >> | | (7) ...to here >> | 341 | >> | 342 | p2m_frame_list =3D p2m_cr3 ? = xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) >> | | = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ >> | 343 | : = xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); >> | | = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> | | | | >> | | | (9) ...to here >> | | | (10) calling = =E2=80=98xc_core_arch_map_p2m_tree_rw=E2=80=99 from = =E2=80=98xc_core_arch_map_p2m_rw=E2=80=99 >> | | (8) following = =E2=80=98false=E2=80=99 branch... >> | >> +--> =E2=80=98xc_core_arch_map_p2m_tree_rw=E2=80=99: events = 11-24 >> | >> | 228 | xc_core_arch_map_p2m_tree_rw(xc_interface = *xch, struct domain_info_context *dinfo, >> | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> | | | >> | | (11) entry to = =E2=80=98xc_core_arch_map_p2m_tree_rw=E2=80=99 >> |...... >> | 245 | if ( !live_p2m_frame_list_list ) >> | | ~ >> | | | >> | | (12) following =E2=80=98false=E2=80=99= branch (when =E2=80=98live_p2m_frame_list_list=E2=80=99 is non-NULL)... >> |...... >> | 252 | if ( !(p2m_frame_list_list =3D = malloc(PAGE_SIZE)) ) >> | | ~~ ~ = ~~~~~~~~~~~~~~~~~ >> | | | | | >> | | | | (14) = allocated here >> | | | (15) assuming = =E2=80=98p2m_frame_list_list=E2=80=99 is non-NULL >> | | | (16) following =E2=80=98false=E2=80=99= branch (when =E2=80=98p2m_frame_list_list=E2=80=99 is non-NULL)... >> | | (13) ...to here >> |...... >> | 257 | memcpy(p2m_frame_list_list, = live_p2m_frame_list_list, PAGE_SIZE); >> | | ~~~~~~ >> | | | >> | | (17) ...to here >> |...... >> | 266 | else if ( dinfo->guest_width < = sizeof(unsigned long) ) >> | | ~ >> | | | >> | | (18) following =E2=80=98false=E2=80= =99 branch... >> |...... >> | 270 | live_p2m_frame_list =3D >> | | ~~~~~~~~~~~~~~~~~~~ >> | | | >> | | (19) ...to here >> |...... >> | 275 | if ( !live_p2m_frame_list ) >> | | ~ >> | | | >> | | (20) following =E2=80=98false=E2=80=99= branch (when =E2=80=98live_p2m_frame_list=E2=80=99 is non-NULL)... >> |...... >> | 282 | if ( !(p2m_frame_list =3D = malloc(P2M_TOOLS_FL_SIZE)) ) >> | | ~~ ~ >> | | | | >> | | | (22) following =E2=80=98false=E2=80=99= branch (when =E2=80=98p2m_frame_list=E2=80=99 is non-NULL)... >> | | (21) ...to here >> |...... >> | 287 | memset(p2m_frame_list, 0, = P2M_TOOLS_FL_SIZE); >> | | ~~~~~~ >> | | | >> | | (23) ...to here >> |...... >> | 300 | return p2m_frame_list; >> | | ~~~~~~ >> | | | >> | | (24) =E2=80=98p2m_frame_list_list=E2=80=99= leaks here; was allocated at (14) >> | >> ``` >> Fixes: bd7a29c3d0 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to = support linear p2m table") >>=20 >> Signed-off-by: Edwin T=C3=B6r=C3=B6k >> --- >> tools/libs/guest/xg_core_x86.c | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/tools/libs/guest/xg_core_x86.c = b/tools/libs/guest/xg_core_x86.c >> index 61106b98b8..69929879d7 100644 >> --- a/tools/libs/guest/xg_core_x86.c >> +++ b/tools/libs/guest/xg_core_x86.c >> @@ -297,6 +297,8 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, = struct domain_info_context *dinf >>=20 >> dinfo->p2m_frames =3D P2M_FL_ENTRIES; >>=20 >> + free(p2m_frame_list_list); >> + >> return p2m_frame_list; >>=20 >> out: >=20 > I agree there are problems here, but I think they're larger still. = The > live_p2m_frame_list_list and live_p2m_frame_list foreign mappings are > leaked too on the success path. I thought the goal of that function was to create the mapping (judging = by its name), but looking at its caller there is another = map_foreign_pages there, so there is indeed a leak (-fanalyzer won't be able to spot these unless = we figure out a way to put some attributs on these map and unmap to = teach it that they are alloc/free pairs). Pushed updated commits here (top 2): leak-fixes = Before posting a V2 I'll try it out on an actual machine though, just to = check that we don't have a double-free instead now. Thanks, --Edwin >=20 > I think this is the necessary fix: >=20 > ~Andrew >=20 > ----8<---- >=20 > diff --git a/tools/libs/guest/xg_core_x86.c = b/tools/libs/guest/xg_core_x86.c > index 61106b98b877..c5e4542ccccc 100644 > --- a/tools/libs/guest/xg_core_x86.c > +++ b/tools/libs/guest/xg_core_x86.c > @@ -229,11 +229,11 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, > struct domain_info_context *dinf > uint32_t dom, shared_info_any_t = *live_shinfo) > { > /* Double and single indirect references to the live P2M table */ > - xen_pfn_t *live_p2m_frame_list_list; > + xen_pfn_t *live_p2m_frame_list_list =3D NULL; > xen_pfn_t *live_p2m_frame_list =3D NULL; > /* Copies of the above. */ > xen_pfn_t *p2m_frame_list_list =3D NULL; > - xen_pfn_t *p2m_frame_list; > + xen_pfn_t *p2m_frame_list =3D NULL; > =20 > int err; > int i; > @@ -297,8 +297,6 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, > struct domain_info_context *dinf > =20 > dinfo->p2m_frames =3D P2M_FL_ENTRIES; > =20 > - return p2m_frame_list; > - > out: > err =3D errno; > =20 > @@ -312,7 +310,7 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, > struct domain_info_context *dinf > =20 > errno =3D err; > =20 > - return NULL; > + return p2m_frame_list; > } > =20 > static int >=20 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:47:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:47:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502348.774102 (Exim 4.92) (envelope-from ) id 1pWb20-0008HR-7D; Mon, 27 Feb 2023 10:46:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502348.774102; Mon, 27 Feb 2023 10:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWb20-0008HK-4Z; Mon, 27 Feb 2023 10:46:56 +0000 Received: by outflank-mailman (input) for mailman id 502348; Mon, 27 Feb 2023 10:46:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWb1y-0008HE-UX for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:46:55 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0628.outbound.protection.outlook.com [2a01:111:f400:fe1f::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b7a0b0e-b68c-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 11:46:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8742.eurprd04.prod.outlook.com (2603:10a6:10:2e0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 10:46:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 10:46:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b7a0b0e-b68c-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmdSjd/tl8Li714jTZ1Zo92GSPmnUzoFrLqDOyY2SkQT5QDJHdX7nRV2RYxpDMwIWqsv3onCLMzdXTJ2je6J6KwtwdYxNm6n+GsMawZdo9nrV20Fol9wCbwdEJwmJpgZHPvx6Dss0gRxM4pqRyL99hNEntlbRp5NfKms79AKDjicjKpDYCOnv6qkcAFQXO1vqfLTPNu4Rd2y2TBtmEoduZuOHrRJ+6eZZfQT0QtH4BfJl23sFOQgQpJ+Yr7W1ysNXs4WD11FmJKD2+lt2TFirJ7qaWUy20pW2OA4r5EQRo0sTjpxYO43ppQ+6nH+eJW5pWnmHLLGGqm9R17SRSAbFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oE41pJpNyFuLR2pR7p7MmSNHYwgMf2SNOMpvUGq9vis=; b=VBsiDATK1fYCQocknlV/pjo1fUZJy0wE55gtkDyasXKD+H6VbVLyyQR9SnGpSUJEqDktmJ+qTMTQ5uvF1sohLjlsdpmDXpkSKiJvOnbBJKrbJObLMa89/xs73pBUd/0sRn9hogOVCbVxu7h//UepvgTcS/jEPOYcaelZaE1VfCRXJfIxqUUTBqYNxflXzUk5YXyWqNuqEykK7DhF4UgKmXkh7nmkPSWzn/AJ5ES4J8nIakAErXmv4u1s66fHJcvyhxs3bezucnbL5WzPewKteogAADRpkRnbwtpls9M1yqKH0dNavqHfaMfuZT048CuRWqbhODaY+2Rf/PjcWiQEjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oE41pJpNyFuLR2pR7p7MmSNHYwgMf2SNOMpvUGq9vis=; b=ozdpsH5UBq0WEyAgxPwFWN1NwsW6Vl0T5fEo4sJajykJGg0RSZEFjA3GMzBfkePOIOYfSYQCLUxxAT4Vhcy4cIByxUycVszA7bjZO0Gl3Jb8J3UX2K/Vkn/GmeRZJo+j9zISvhM7fJuE2a1pAJrE3BoB4NgAlkY4ih3BETsuoYly9QGiDcwbSh8NPpYpxvLBO4G+dTpCTFrLcy59/dd7m8yEpot9H1JnAF6UPLCOh2z1oOTyFyolyW8EoPKkyy3nF1tPHAwkirAoC/uMObkihsCG6qL29708zwBDAQf4/UreK8kfPdofMpkWA1X/eGDVnJz74HTKuxtOPa5U4//ypw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 11:46:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> From: Jan Beulich In-Reply-To: <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8742:EE_ X-MS-Office365-Filtering-Correlation-Id: 44f77c4f-4a9f-45ef-fa81-08db18afee85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OtkTP71EX1gXQEqfLthwgUxhs1parQRMSiVVztYKhwBeiSZQN05xYL61NuE+RfAUoky4yg0vDdoOXgR5di1DaqkSlXYZqI3vLL4K4A6qNMaB64fOfNKL0A2KeSt75icbq8KdCArwCbwxYC7ap/G0lQcIx2X8RcIVPK9ywuIUSe/AWGA5lKSywyHLuoyWiA6GGtVdADvL91yTbo8QbiwlMvjlFxrzJBkN+PyL4brovymiPl7tTRCLxcVI3Vu8ANPwWh6nTU/GTHGtuPJi5/jCB5qee/dfHggZE8QXbtVXhtJRBPEJLO/NI4ej0Yp2jhf387bpHceJ5HjJNgkhDSOn7mH9gzcN2xTA07/iliFxkOO+NXiGk5Pt1KkqZgDxcTUEGUO0kjvGIlqRaAcOpIUhZW0uB+tcuk8TfDC9DYW6P+6lvyAV1yq08Pw4AuzeOTsyH8/2V2D6vDFPf3UgDtfDsTgJ6/DkoutAphixG9/1I1PTEDz3+4KRhGkIazpwKkEUVWy8wK5zn0AbFaDt8qSAdLn0KBdxvR5XGrFFbQHMKpLwXAGIZ13Ss9uNKvcfSBwU/bjjycb/DrfIIw5QFLjaHEYOR64+O0leixTeFnDf1ru+gOCllf1RACj9YDQdSObY91fJE2ycW4PTMohwB900JZHEODoMXrv2f6lH/KqwVb6xoRg1zEIT0ngT4kicHvnFJ+ElrtGtpipzSRmA5CaaPaOzT8Rj8kvttA+9ccYk6kc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199018)(4326008)(31686004)(6916009)(66946007)(66476007)(66556008)(41300700001)(54906003)(316002)(36756003)(6512007)(8676002)(8936002)(38100700002)(5660300002)(31696002)(86362001)(478600001)(53546011)(186003)(26005)(2906002)(2616005)(6486002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkNmbXZ2NGdLOXpETFE1N1FGWGZYNFJ4Wkp4S1F1NERlbU1CWWMvQXlLMWZ4?= =?utf-8?B?Zy85WThSK1B0OUhVanZMWEhTNW0ybStMOVczRStKNi9WV2VOZmNmYkRzS00r?= =?utf-8?B?N3ZwNW5kVUZ0cjd5NDdWelpqNlZZeTVOTW5PenhkbkZFclFTVi8ydGNJdGt6?= =?utf-8?B?L0x2L2lvcU1WQjViWnhQTXdBWGR0cTU3R2JOS2lLK2I4T2FkZjlkK0locGRC?= =?utf-8?B?ZjdvTlVYWVlFc0lLTFZEMmkvd0lmRUJLQytjNFlERW9DekhvUTdCRVBiZ0pZ?= =?utf-8?B?ZVEyT0wxM0dZZnR6Vnk0SlhLN3czVEUvL2xsZHM2YmhEYklrdnYvbi9YNzVj?= =?utf-8?B?NVNrV3gxOVlWUWxpaEVRSFp5Z2JpN3pPa21EVW1wZExhOG8yNU9FcGZXUXNq?= =?utf-8?B?UzB0c2FncFVmaFBWUUo0ZHZ3U29RWVB6Z1V6d0d5WHIybXdVR0QzNnFsbGd1?= =?utf-8?B?MjJnOTJSNTBrTkpldnUrcTUvTDJKU0NYWkFRV1VjdWhUTnhDbittamk5SXNP?= =?utf-8?B?WG9MRW1HdnpHTWNXbEJSM1NTdmZZTzVqdUJwNUZLTW9YZEhENVo0K2pqQjlm?= =?utf-8?B?UmU4Tk4weE9xQ1RkK2dNQkdhYTBQN0xlTUZwL21UekVLU3M3QVZxYWpKUi9I?= =?utf-8?B?bk9JUFJKc2lTN0dTNDU5K1BaU0w2RGw3UHBwa3UxQnhoeWlKcFpGU2FZeHF6?= =?utf-8?B?YSs0NDFlbkJGOS92KzVHUExsY044MTNaQkJYb2NXRjVRTWw1NHd3TkYxMzJa?= =?utf-8?B?MzlHSkh5c2hDd3BVNndDWE9KT3o1VDAzczhJZ2ErTG1EVFlEOEsxS1J5VjNZ?= =?utf-8?B?TnVZaHhZMjUzcUZMYzZpNXBxc09yenN4bDJIMUxkbS84em9jaU9mck5HS1M2?= =?utf-8?B?WEZtRkJxYlNjUEQwbW5lMjY0aFQ0VHNOR3VCN0YyK2Iwc1NHT0pOakxrcmw2?= =?utf-8?B?clVoUjFHNUdUVDVmSkZhTkl1T1lFQ0dkSGN2V0VaQUtOazliUVpIc1VrdWYx?= =?utf-8?B?SEppUWxLamE4OFZqYmxPeGx3WG1qYnBaT0sxRzQ1bXlVanZDV1ljOEwvWmdV?= =?utf-8?B?UUlOL2hJWUtzazdGeURVTWJnL2xaNTZBUXRIdk1ZZGRwQzd1bzhUcjljYnJl?= =?utf-8?B?KzZwZ2laRUUybEdhRHozZndSckptU2w4bGVXQ1dOQjJLa2pzdWlibUV4OHlH?= =?utf-8?B?M0RwSkZYME5EdnRWUmhmcXZIeitJK1ljTlJKNnQ3VnF3akxRNnU2ZjhOeHFQ?= =?utf-8?B?bjc5NlB6SEhnbWphdko4RnJqNk80RUtSMmZ2ekRzY1F0QmVuOVBJcTdDUnhV?= =?utf-8?B?V2JBaHB0dU52Z3lwU2wreFlsWktyWTdzb0F5akhJQTE3RDhRS0p2UEJCRk5a?= =?utf-8?B?Zlo0RmF3YjE1TkdpNXZTV1pjbDN3cmU0VlZCTktSa2lPQXBld05uOU5KMk0x?= =?utf-8?B?V1BNN2VGMys1ZDdrREtjdGRFRmJqNDltR3lDSDdkb0RsWGN3U1BEaGc4UW5a?= =?utf-8?B?NDZoa1pIT1NTUmNmdk8rNmloKzk0RnNUYWExbDVlRWM2UUMwZWhyeDJ6VjJl?= =?utf-8?B?NGdYSStCSld1Yy9IaHBsUnRkZFJUUjEvWmd4ZzZ1UlB1c3JIMmtnTzlZZ0Uw?= =?utf-8?B?dEgzRzFHaERDR28zVkhISzFZTlZXdVJid0VCekM1VFVoaDBKT2hyeDUrajNQ?= =?utf-8?B?Z28zRHZabDBpczhiUjZTNXFVSkdFaDBjTGs0SHB0ZVZhS3F3L2Vqc3ZaM3Fl?= =?utf-8?B?Rm1jc01DZWFhb0dId3VOdXJBd0k4N3I2WStPelpaWkh5VXp4UGIxR1FHTktG?= =?utf-8?B?N2t4V1Q4YkhWVW1PYVVnUjJDejZLQVdYMWlOcmh3TjFjWmFrbXJhcXBXeEN6?= =?utf-8?B?OGhsa1dMUWpaZFg3UHRidG84UjhPckVYYU54bFBxZ3hxS2tJOEh2NjdjZ3B6?= =?utf-8?B?K2UrVk1Ydnl2WkVXS2JlWlZZWWlEYVFaUlhWcG9CR0JHV0w2KzVVOGV0K2R2?= =?utf-8?B?RlcrNGxidWRxZDVZVDE0RU16RlVMNThLTkM5b2pRR3pPZ2E1ckxTdDdkRHY3?= =?utf-8?B?QVdMU2xabTJlR2dZYjRsZ1ZIRzlzNEpmSHRIaFJmVEhtczJzSGgvNlg4d2cr?= =?utf-8?Q?KWR42YYeHlkBiTeXfMuQAAVVp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44f77c4f-4a9f-45ef-fa81-08db18afee85 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:46:50.6439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0XIWnMTOkXU0fmSS3myXAUQpYO64RmCRlGgPH3RyDoLS3UITwanTx3B5mTaBYMCranOoLr28FR5fNz/4CUJjTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8742 On 24.02.2023 22:33, Andrew Cooper wrote: > But I think we want to change tact slightly at this point, so I'm not > going to do any further tweaking on commit. > > Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, > updating the non-SVM include paths as we go.  Probably best to > chain-include the other svm/hvm/svm/*.h headers temporarily, so we've > only got one tree-wide cleanup of the external include paths. > > Quick tangent - I will be making all of that cpu_has_svm_* > infrastructure disappear by moving it into the normal CPUID handling, > but I've not had sufficient time to finish that yet. > > Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and > disappear (after my decoupling patch has gone in). Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? The latter doesn't use anything from the former, does it? And it also doesn't include it right now. Since nested is still far from being properly functional, and since most guests don't use it, I'd rather see struct nestedvcpu's union to become a union of two pointers, which get space allocated only for nested-enabled guests. Yet it's only the use there which makes it necessary to globally expose the struct right now. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 10:47:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 10:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502355.774112 (Exim 4.92) (envelope-from ) id 1pWb2t-0000QZ-Jo; Mon, 27 Feb 2023 10:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502355.774112; Mon, 27 Feb 2023 10:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWb2t-0000QS-GQ; Mon, 27 Feb 2023 10:47:51 +0000 Received: by outflank-mailman (input) for mailman id 502355; Mon, 27 Feb 2023 10:47:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWb2r-000080-AH for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 10:47:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b4bf055-b68c-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 11:47:47 +0100 (CET) Received: from mail-bn8nam04lp2043.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 05:47:44 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5941.namprd03.prod.outlook.com (2603:10b6:510:34::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 10:47:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 10:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b4bf055-b68c-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677494867; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=YsQyEKRRbfhV8Oz0ceHjsFMUvyKbHIOA4B/3kRCs+Oc=; b=iQF/qFu4dmdM0mQan3LcOQk1Q68SZJeEyuutBzHse+3868ym8qvCAE4D RkWPb8o7S8UMv8qFdRuPsqIRXIdmISpSNEhQSmF3AVCwRxMT0hfEKP8bt Zt4D7QdQpxFjrvtCi8pnp8H/pwcMrDo1ZNTBUWRJfBUhHxvZrEPtMQRJK g=; X-IronPort-RemoteIP: 104.47.74.43 X-IronPort-MID: 98666362 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Cs10X6qZxpuOgnXjtniXVpgyd7deBmIsZBIvgKrLsJaIsI4StFCzt garIBmEM/3YYDDxLdEgYN6+/UtQv5WByIdmSAM+q3o3HytE95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSZNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAHcndiud2OGu+pWYb8xjp/h/IdH0N5xK7xmMzRmBZRonabbqZv2WoPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+SrbIG9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzoqKA02wPJroAVIBo1Z2GL/MiHsV6VRIJme 04wx20oiLdnoSRHSfG4BXVUukWstAMGSdNUFOE99wilxa/d4gLfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaEQo/IHIGZCQEZRAY+NSlq4Y25i8jVf5mGa+xy9fzSTf5x mjWqDBk3+lIy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:ownjWa6XUtg9BPKNdAPXwMrXdLJyesId70hD6qkXc20yTiX4rb HIoB1/73TJYVkqKRMdcLy7V5VoIkmslqKdg7NxAV7KZmCP0geVxepZjbcKrQePJ8VSndQx6U /mGJIObOEZ2TNB/KPH3DU= X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98666362" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CeowLBv7zGmH7eLS9yk75lJOLwSHox5WmTpuIE855qIjUPn6dw93jZU5crjf1/XkBftc5uSa0vBnnQLyNmEEie/YsbS1f9VXFfa+nx/uTAypzrDRnxguT0ROSQ0rn3CdtulKjH8UvU2gE4RmJBhaHoHcEKd7Eefwx05LP03q49hmVTMqSdrtVPFS6w7BuUcti9wYtYB9p4rdoqSL71n8oOadZ+5Bbb7ojY8YktleCIt8kr5y7Hc5Iw7Gh4qmXNTnAGArs3MXofdrkHb/+hVdEtho1rLmHrjHh6VaZoZ3usigBNIYYB5CvywVThaQbnC/GNrJz5usYqq0m4JUJacMNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsQyEKRRbfhV8Oz0ceHjsFMUvyKbHIOA4B/3kRCs+Oc=; b=P6NDDuYdhPY61gvbTXP/XzIAbGzQiKI5wPtC7BFd6242HQbQx77rxLpLro6aeODKFgMssOAuZLIoM0G2+5CMr9T5zrcc5+n8dBh4AtT7px7/nP5ovuFaw0BTOocV5N1/Soe3t7BUQIlfQHRUINTAfwz4+SPjN7hOUnEP35mQGPU0IZjiJQqZdotNxfvEdaNasoKArY9+xW226mdXzpok0nN2GBXGfL59Qb0yDgXjAxoL0bM7xeVOViMZEIGB4ZJfgNzmrGoZNHF72VZGtBIbU+f1zYO32VieYTFMfHmWOxCVJWgOpKOUAXDtdHndg9iMdhFJz3GZVgK1BSL8DRw0hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YsQyEKRRbfhV8Oz0ceHjsFMUvyKbHIOA4B/3kRCs+Oc=; b=QhHVkRjNE9qqjrn38rmq7kPsSG0G0jo67KEUDAaOY78u+ywm1NjCI/Z3CyWS3jY0ceD8CeTXBH32gMeVmcoB2+fcfq8jmDBIDj7BFSzxdIW0oS7CJdm321Ef7lvRdmTmMJU3uMWiIDWtCVV9dr2xT4y5VwfdwIAoEATTga+omjg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3e8b2f68-e620-770b-e44e-b273f0da74e7@citrix.com> Date: Mon, 27 Feb 2023 10:47:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 05.5/14] x86/svm: Decouple types in struct nestedsvm Content-Language: en-GB To: Xenia Ragiadakou , Xen-devel Cc: Jan Beulich References: <20230224185010.3692754-6-burzalodowa@gmail.com> <20230224210616.2818727-1-andrew.cooper3@citrix.com> <709fef03-4263-861b-3ccd-44e3706b5fb3@gmail.com> In-Reply-To: <709fef03-4263-861b-3ccd-44e3706b5fb3@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0099.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::15) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB5941:EE_ X-MS-Office365-Filtering-Correlation-Id: b0c98f53-b908-4985-d1ad-08db18b00d0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cRQa37rrjwpIJDjNlsRw5I9pLZkOp+k6RrqGA++bS7CBgU49VOjPj5sU4BJrNecrjjj6gaCU7bq1Es797rtZDAGVijCX0uMHqB7JLeTe32snsNJX0wtgmxkWw+ZDovbTMrWsfgw3Zu5nstweM+r3DtYp7xfnclECHpv6D4aBlV0uGg+CCBZ/Wl0qaOdZO5h3wMw49xtQ5WLp3N6v11IL8nOhF1T1/9FHFZu8NlLx7mAKkg5s8STwIxWO7iHSxtDDp1bTHLZLUt/0pUMN89Br9ztA3j/2OrTy0ypH+OgVE1uQ3wmHsz/MtWRG+uFBpltZV/6QgMFhQLwl+CCv4C2i8f4yxvEl+A8j1CIGAlVwHzLAWQnZMe8wZ8vNdlv3mRnA9ihXjZIpZTI68dhx/Uup4HLxbzjrnDxvh9X0c8DU7qc88rVvrVeiHCDkjZUX+EA14xXuz7TJyCvjVIujkNIUKE9EyQHNXxC21CFo3Q9ttj/PqPvHH0Cxy3c0qOHrwCYLmWFWvt0ur++wu7CK+RpR3sSTvxPhDyXo6RMEN4c233kgwmS4OjE1dpuRgKE2Ahxq+cFP2fQoLUotdw0Mwwa8GTfiOPbIejnKjqFtzNw7xiTmr/ffsOXLXTY68I3WM4ukKlXrrV43hHgeit6cvl97/ulOKq1Y3WiQm015xXo5xkFfgGIqeTyV2ryqK62xhaipEoem0EIsySQyTyZmeXq3RuiOweT7rUJhag40wly1gfY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(396003)(376002)(366004)(346002)(451199018)(36756003)(316002)(110136005)(6486002)(5660300002)(478600001)(2906002)(8936002)(66556008)(66946007)(66476007)(4744005)(8676002)(4326008)(41300700001)(82960400001)(31696002)(86362001)(38100700002)(6512007)(26005)(6506007)(53546011)(83380400001)(6666004)(186003)(2616005)(66899018)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjRSK0lBQm5UOFdERk1wNThQelNFaDNMMVBvRnlXa3p1TDU1ZU9KNHpZUkk1?= =?utf-8?B?ZEFVcUR4cEVIeGlJem0vQ09sU2c3MWJBOVZUVUVYNTk4Q1Fqak9GR2VkdnNm?= =?utf-8?B?QythazlWaFYzazIyQlNzaE1ZM0VXNGs5bUdEQ25HWE1aVmREVitHeS9TeEJQ?= =?utf-8?B?bFpyNnpndFBxQUFHVDNqZmh2bHF1RU5za0hSUUVaNTRZZ1lVeDBMQU03QTBm?= =?utf-8?B?cnRtaUFELy9GbFNkbVc2T2JMc0IrUHQ2eFBNb1J0YkozK29XLzI4cVA5SzBB?= =?utf-8?B?bWxVaDVabHlVcElrVEFtRFcrei9GNmRhUzlxa3BzQUdoNFpPWmZRa05RczdF?= =?utf-8?B?TmFBUTlEUzRGc1RsWjZ5ZGZEWUN4OGRWS3NJSDE4ajBQZmNHc001dGgzNUxH?= =?utf-8?B?cDA4OUFva0REbUpoWjE5TVh5bmRTS09hUmlNUjQxWHI1SkEwRDkvQTRTV0Zz?= =?utf-8?B?Yy9DYW9vWVQvcjQxL3UrQ01xUUVaa2lFNis1RXBjS0MweHZabENobE1uZUhh?= =?utf-8?B?QVJ5cU5KK0NYMEM5bnBKQ3ozTEFkbVlGcGpQajB6VVVvUTZmcmdXbk1oQTBl?= =?utf-8?B?N1FKcEc3K0cvUXNNQnMxdTJ6SDBsRE5wa0F2TDI4K0x1ZGdBTjFvbzU4Q3hQ?= =?utf-8?B?enRwOVYzUnEweWJuL0xmQUl2L2VqYjA1d1VrVk1ienZMMlJEb1hhTCtqZHR3?= =?utf-8?B?YXB3SjA0Q29RVFowREdHODVWNUhNM242MzgzZU0vUkw2T0ZzeWExem1SNW1y?= =?utf-8?B?c1JncTJ0cEIyNXoySGV2bEp6dXNXdkdmc1pON0E3ZW51cGQ5TXBBcUZ4L1JI?= =?utf-8?B?czhLR0hrMHZNdExSNDd0YTdqcHVzMWJlM3dNTUxWOC9ScmhYb2owRmlGaCsw?= =?utf-8?B?RDg1d0dLZGcyRXRWVURRZGd6T2ZwNWhSd3JJYVBLczhoS1YxNnlwbTVMV0pP?= =?utf-8?B?NG1mTTIwTFJ4dkp3cjkxS0hSZXVNdzNrYnI3aTdrdDNTVjFRQlgzeGxDT2I0?= =?utf-8?B?Z3lOWUpBbVV2NitkejdRNjJXMTk0Y0FDVkZRc1NMZXRlNnZaV1p4eVhVWHdv?= =?utf-8?B?d214eVdhdzdMZHhHcDhlVUliRkxDQUxjVnowMWx6dEg3MFducGQ5MTZ2SnVF?= =?utf-8?B?aERBa0ZlQXM5WVhsL3lMK3JjOElDNjZUcG1OUk5mMXBCUWFxeXdrN2pnRlFz?= =?utf-8?B?ZDlJOGdqWXpYRFhSZnhVSGdNUzVZQ0pKRW9MYnlFZjVlOHJ4dHNPc0g3ajNG?= =?utf-8?B?dUMwanR4ZVBZOVVQUW9KWHRmaFQrSnRlRm1HZHBCK2wwNFFSMy9iLzhEQXQx?= =?utf-8?B?UTZyd096YVJmMFhzanBJUXptQlArVzkvMk0zNHVpc0pYakpWSlZURDFCcE05?= =?utf-8?B?MjNydUVFRTZRWEl1QWdXdmM2WTlJbGJmZVA4VmJDM1FadHpSQmtNZng5MGtm?= =?utf-8?B?ekk3WVhDM2c1cDVEeDhFL2RRenRRcGlUeGQ3TlFzTzR2NzJJNGpGNzhEMDBx?= =?utf-8?B?UXBTWXhvZHFOK0xjVHplN0dOaEZTZmkrdWFrOEVVNE1DaVpFS3J2SUl4UVBo?= =?utf-8?B?OW0xcXV3c3JYQ0xkaUNTUnNOa0lNdEtqcHpuRGsrRWo3a1RPSldKYWtWWVdR?= =?utf-8?B?R1JyamtlYjkxaFFjSStqZGErMlNWOVRIajRvRXVwWGVvcDFTNjBHNFByLzlC?= =?utf-8?B?TGxaSStlQkhWZ3R4Q2RZaTQ1WDhqWXdmbjNSaTk1WDB6NWwvdXlCMll3NXM4?= =?utf-8?B?SG0xRldtam1TbVdWVTdBSHU0WmhyQ01hNTBtdmgvdkMrQ2h0WEgvaGp4RG10?= =?utf-8?B?K3FBeDJMZytoVStuYnlrRytBQzRXalRJVWkya0hYVHJTdHVDbHYrZ1JSNkRJ?= =?utf-8?B?SWYvSHFiUGpDMDhpYkVoekNuRUZzOGZGUG0yUm5pdjZ0UE9mZGd1dThRZ3JP?= =?utf-8?B?WTIxcWhoWUYwNG9CeTIrc3AyaUR3bnVEMFhxRG5rVGZSNTh0ZWhwdktZQm5s?= =?utf-8?B?OG5pT3BTSjVJSW45U1pLa2tyVG83aktXQ082RVhvZmVvcjN2RHM1S2R1dVV4?= =?utf-8?B?QmdWT1ZDZFpPQ3l2dHJ4YmFVYzFTTUFybkFPSmlPM3RPaGhsRy9YSHpHLytF?= =?utf-8?B?b0xEK0FRbEdHWEF0UjZwbXZRWGZWY1VNcHgzalBpK0V0cVFjb2FFcjdFWnhl?= =?utf-8?B?ZXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jEB51g+l0LClv7loEarg0JT456H9Unp9HvclWKMeHmsuwWdTimD5WGyXgUDTg/MWTYyLo0T7mo6Z522587K8MAnYgrMNKFlfUrW89yj8IthulcOZsky9Qw9XhO9ZTscsXE2uBiGH5G7NvwTdA0kszSDVlFpJ3UzW1TW60kGjtv3UqonAklLzQY3DmsTFmnAkL4qrB7R01kLFnkUMvrPRDz8NeJiihC2Klse6fYa1yIeEkJSFDkmTtUxU15hdZ58oo06ygfPeIN8bZhPEJzpW969uwWcqw45d/p557HKgiS8KAm23yAPXBzz6BFY86Pe36R5yKMYG9mj/NUhYiKs/khkpB6kMwN+L1LdqWiyxvDMu0oEVLz37Oh18lCA7M5awVjWGVtX/h1p5jUcPQ91WJk8hKuX+i3AnHaHCucS0yMYi0u5XQqlc+DDHKWwHdex0fav62bfuQryHf9CLBAU1jpjEpIr7g1+4G4zZ4DKXgKi6VdIcxP6zRpt/GCpgsdm7ma7XC/SqsQ0v4Bw5xmBIsqOyUxd0xR/ihgJnEqMeecNrJyEFFN/JoYnnnTbav4H4O9yeFZ7r80Ly7t94WZfVZrUj5+BaH5KvrBiayrn/EKXxSfpPJwm5Fz5c5bxep9Z92aOLpfsKwkuip7/CZjoV/W3FKvXhovakhe77N7aX/K+rF/IIY0Ygrz4bLzxNcCAsN3T6eFQw0Z3uQpIC5pQu6r83aItPg/bSVTTGlR8lFri5vf5xTA7azFGJa2taytFdkZhr/otQIGsKZ2C6iPuiEotbYGfHSlx+hmWgQnJ7o8A6JEGL76nD5bLaQfLAnTe81fSU353xlYMRTwNdmiV8yQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0c98f53-b908-4985-d1ad-08db18b00d0c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 10:47:41.8124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yCnt22rXDEYycb4dxPA0tJZnSTaiK/r6hQABsVzybsNJXRwPg5ru5z0DmTdfRB4wtazHfZCuHS9e+E38mPILZO0p5tlHXFx2UW1ICfxwaqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5941 On 27/02/2023 8:52 am, Xenia Ragiadakou wrote: > > On 2/24/23 23:06, Andrew Cooper wrote: >> struct nestedvm uses mostly plain integer types, except for >> virt_ext_t which >> is a union wrapping two bitfield names.  But the nested virt logic >> only ever >> deals with it as full opaque register. >> >> Switch it to being a plain uint64_t, allowing us to hide even more of >> the SVM >> internal infrastructure. >> >> Signed-off-by: Andrew Cooper > > Reviewed-by: Xenia Ragiadakou > On second thoughts, the fact that this patch compiles means its a write-only variable. Lemme experiment quickly with an alternate patch. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:11:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:11:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502369.774129 (Exim 4.92) (envelope-from ) id 1pWbPR-0004ly-Oq; Mon, 27 Feb 2023 11:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502369.774129; Mon, 27 Feb 2023 11:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPR-0004lC-Hf; Mon, 27 Feb 2023 11:11:09 +0000 Received: by outflank-mailman (input) for mailman id 502369; Mon, 27 Feb 2023 11:11:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPP-0004iF-Q8 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:11:07 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d2912c1-b68f-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:11:05 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-74-DJ-jRS76Mjy4jXphQxQ3Uw-1; Mon, 27 Feb 2023 06:11:01 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 996A7101A521; Mon, 27 Feb 2023 11:11:00 +0000 (UTC) Received: from thuth.com (unknown [10.45.227.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 348B440C6EC4; Mon, 27 Feb 2023 11:10:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d2912c1-b68f-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677496264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KioUJTM1KSsfU9iQtLnRn1SvfePLH+pSeG29+t/WJ4c=; b=foGPiIr6kX+diJGlxiVLlXqr+CVhEjSZywLo57EbubDu1CkSavZz034YU81YT9aiLEcuSm MoGg55Di95uZLtfIieoIPeLlvGe/5JumY1lych27hrvUcUdIZrx4yn/qxHTWTcTuRpDXY4 uVAwJQkgHhfvXU4JS4dUfREfdEMCraY= X-MC-Unique: DJ-jRS76Mjy4jXphQxQ3Uw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell , Daniel Berrange , Paolo Bonzini Cc: Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: [PATCH 2/2] docs/about: Deprecate 32-bit arm hosts and qemu-system-arm Date: Mon, 27 Feb 2023 12:10:50 +0100 Message-Id: <20230227111050.54083-3-thuth@redhat.com> In-Reply-To: <20230227111050.54083-1-thuth@redhat.com> References: <20230227111050.54083-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 qemu-system-aarch64 is a proper superset of qemu-system-arm, and the latter was mainly still required for 32-bit KVM support. But this 32-bit KVM arm support has been dropped in the Linux kernel a couple of years ago already,so we don't really need qemu-system-arm anymore, thus deprecated it now. Additionally, it's quite unlikely that anybody is still running full system emulation on a 32-bit arm host nowadays. All recent strong arm host machines should support 64-bit now, so we also deprecate the 32-bit hosts here to finally save some precious minutes in our CI. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 98517f5187..a52e45b570 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,23 @@ QEMU will soon drop the support for 32-bit x86 host systems and the ``qemu-system-i386`` binary. Use ``qemu-system-x86_64`` (which is a proper superset of ``qemu-system-i386``) on a 64-bit host machine instead. +System emulation on 32-bit arm hosts and ``qemu-system-arm`` (since 8.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +``qemu-system-aarch64`` is a proper superset of ``qemu-system-arm``. The +latter was mainly a requirement for running KVM on 32-bit arm hosts, but +this 32-bit KVM support has been removed some years ago already (see: +https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=541ad0150ca4 +). Thus the QEMU project will drop the ``qemu-system-arm`` binary in a +future release -- use ``qemu-system-aarch64`` instead. + +Since you need a strong host machine for running full system emulation, +and all recent strong hosts support 64-bit anyway, the QEMU project +also deprecates the support for running any system emulation on 32-bit +arm hosts in general. Use 64-bit arm hosts for system emulation instead. +(Note: "user" mode emulation continuous to be supported on 32-bit arm +hosts, too) + QEMU API (QAPI) events ---------------------- -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:11:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:11:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502370.774142 (Exim 4.92) (envelope-from ) id 1pWbPS-0005CH-V0; Mon, 27 Feb 2023 11:11:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502370.774142; Mon, 27 Feb 2023 11:11:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPS-0005CA-Qb; Mon, 27 Feb 2023 11:11:10 +0000 Received: by outflank-mailman (input) for mailman id 502370; Mon, 27 Feb 2023 11:11:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPR-0004j5-OK for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:11:09 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a0d826a-b68f-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:11:00 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-6-3BnZ8YXjO9i2G0RP3ALa-A-1; Mon, 27 Feb 2023 06:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3AD063848C27; Mon, 27 Feb 2023 11:10:55 +0000 (UTC) Received: from thuth.com (unknown [10.45.227.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id B36A740C6EC4; Mon, 27 Feb 2023 11:10:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a0d826a-b68f-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677496259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HqNrPaN6lC01QUipjdhuAjHY1FZrvMej85mjtvyYQtg=; b=C2VTv2wVMq/cu3Q4HjP0F05LIC9SLwoBqLFgJRKWOCyONeGLbvwlvU+Y3ACS/Sgri93zZo a7JVSgyPg9cze58z3+LSPHx7MC2IEZvv9XPu5P0sU/DTZVLUcLX71F25iRqMSf9SZ86l0b DQ+ZOPnkODcArZ+9B8nvGK5SRHhRsco= X-MC-Unique: 3BnZ8YXjO9i2G0RP3ALa-A-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell , Daniel Berrange , Paolo Bonzini Cc: Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts Date: Mon, 27 Feb 2023 12:10:48 +0100 Message-Id: <20230227111050.54083-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. qemu-system-i386 and qemu-system-arm are not really required anymore, since nobody uses KVM on the corresponding systems for production anymore, and the -x86_64 and -arch64 variants are a proper superset of those binaries. So it's time to deprecate them and the corresponding 32-bit host environments now. This is a follow-up patch series from the previous discussion here: https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.com/ where people still mentioned that there is still interest in certain support for 32-bit host hardware. But as far as I could see, there is no real need for 32-bit host support for system emulation on x86 and arm anymore, so it should be fine if we drop these host environments now (these are also the two architectures that contribute the most to the long test times in our CI, so we would benefit a lot by dropping those). Thomas Huth (2): docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 docs/about: Deprecate 32-bit arm hosts and qemu-system-arm docs/about/deprecated.rst | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:11:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:11:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502368.774122 (Exim 4.92) (envelope-from ) id 1pWbPR-0004iX-DA; Mon, 27 Feb 2023 11:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502368.774122; Mon, 27 Feb 2023 11:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPR-0004iQ-AH; Mon, 27 Feb 2023 11:11:09 +0000 Received: by outflank-mailman (input) for mailman id 502368; Mon, 27 Feb 2023 11:11:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbPP-0004iF-5D for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:11:07 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a8590d1-b68f-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:11:01 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-482-gGMehePCNs6EjNRatlKlsA-1; Mon, 27 Feb 2023 06:10:58 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E28DB3C10682; Mon, 27 Feb 2023 11:10:57 +0000 (UTC) Received: from thuth.com (unknown [10.45.227.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FFFB40C6EC4; Mon, 27 Feb 2023 11:10:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a8590d1-b68f-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677496260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wU7XSs59OHmkrBANt2Ig03ayelNixYK5a46ZpJhqPYA=; b=eB8rZMdcY4idh1C/q/bns7ACAMitDj67PhQY2i+UpniN9YNzvn3ct6ugBMLH6ke/j9nCpZ ef2pVmhO/TupQ32r8bIkhDhV9aLT+pQywihxheT80Eev0YDW0jcpdDHz7H1CMIc0BCk/Lm 7nzMq2RoR8BohFh9HsDQ1LlrZdl37BU= X-MC-Unique: gGMehePCNs6EjNRatlKlsA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell , Daniel Berrange , Paolo Bonzini Cc: Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Date: Mon, 27 Feb 2023 12:10:49 +0100 Message-Id: <20230227111050.54083-2-thuth@redhat.com> In-Reply-To: <20230227111050.54083-1-thuth@redhat.com> References: <20230227111050.54083-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Hardly anybody still uses 32-bit x86 hosts today, so we should start deprecating them to finally have less test efforts. With regards to 32-bit KVM support in the x86 Linux kernel, the developers confirmed that they do not need a recent qemu-system-i386 binary here: https://lore.kernel.org/kvm/Y%2ffkTs5ajFy0hP1U@google.com/ Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 15084f7bea..98517f5187 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -196,6 +196,19 @@ CI coverage support may bitrot away before the deprecation process completes. The little endian variants of MIPS (both 32 and 64 bit) are still a supported host architecture. +32-bit x86 hosts and ``qemu-system-i386`` (since 8.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Testing 32-bit x86 host OS support takes a lot of precious time during the +QEMU contiguous integration tests, and considering that most OS vendors +stopped shipping 32-bit variants of their x86 OS distributions and most +x86 hardware from the past >10 years is capable of 64-bit, keeping the +32-bit support alive is an inadequate burden for the QEMU project. Thus +QEMU will soon drop the support for 32-bit x86 host systems and the +``qemu-system-i386`` binary. Use ``qemu-system-x86_64`` (which is a proper +superset of ``qemu-system-i386``) on a 64-bit host machine instead. + + QEMU API (QAPI) events ---------------------- -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:15:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502380.774151 (Exim 4.92) (envelope-from ) id 1pWbTj-0006PS-G7; Mon, 27 Feb 2023 11:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502380.774151; Mon, 27 Feb 2023 11:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbTj-0006PL-DT; Mon, 27 Feb 2023 11:15:35 +0000 Received: by outflank-mailman (input) for mailman id 502380; Mon, 27 Feb 2023 11:15:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbTi-0006PB-1F for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:15:34 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b61ca33-b690-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:15:32 +0100 (CET) Received: from mail-dm6nam11lp2169.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 06:15:22 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7107.namprd03.prod.outlook.com (2603:10b6:510:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Mon, 27 Feb 2023 11:15:20 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:15:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b61ca33-b690-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677496532; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=DpYrF7KSDbPhTXNaRG0ucQqP6OoQ/tRzexX94YTas9I=; b=O1Eh+DLrysv6BukcG+L7O5OfYtnlpoRb43FWw7pdYU45W2dDEvyOF5Iy KKOYh46JEE0eGMLGWcG1IvRnnKNUOR8Maqxy/lAGnkaz603U1gWRed0qJ yKrnFeQmTFmADSb7pNIrKqpAhUqcyNDHkoCCkA7YashYJsGOj//o8hqy5 Q=; X-IronPort-RemoteIP: 104.47.57.169 X-IronPort-MID: 98571148 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lzju4amsmd8Ns2sbG7bxEbbo5gxoJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWX2iBMvyKYzP0Kop1PoW/9kMO65DXxtVjSwBkqStkRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7auaVA8w5ARkPqgR5gCGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 f8HJD5TMRq7vL+R44vkTMJmhOMlPNa+aevzulk4pd3YJdAPZMmaBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVM3iea8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDRODnr6c20DV/wERLLxwIBGCfsMCk1G+ldcNlI E8x3wgH+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3Oc0WDps0 FaKltHoADVHsbuJRHbb/bCRxRuxNDYUKykeZCYCZQoD/9Tn5oo0i3rnRMt5AqexidHyBjjYz DWDrSx4jLIW5eYb2qP+8V3ZjjaEopnSUhVz9gjRRnii7A5yeMiifYPA1LTAxfNJLYLcQlzfu nEBwpGa9LpXU8DLkzGRSuIQGr3v/+yCLDDXnV9oGd8m6iip/HmgO4tX5VmSOXtUDyrNQhexC Ge7hO+bzMM70KeCBUOvX7+MNg== IronPort-HdrOrdr: A9a23:Fd2v46379c5xjoafgdmmKAqjBIwkLtp133Aq2lEZdPU1SK2lfq WV954mPHDP+VUssR0b9OxoQZPwJ080lqQa3WByB9uftWDd0QOVxOsL1/qa/9SKIULDH4BmtZ uJf8BFeb/N5VUTt7ec3OGze+xQpeVu/8iT9IPj80s= X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98571148" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KNS7E4YU48t1apDzRCvXyhK+qmAx+c55+qfKBQqqux9PR8WpYuor9G5c8bNSdqNA5iIcbo7T3Ds1weWPGRlfojJDRv8Zkq9x3J1pVBJXihfERT8a+trNY6EN0iOvD9A1AsbPJkhglJ1vHJAU+rAa0m9jGBKBZIMUDQ9WaRXMpXOeJWsFwFfDrfkzWJ9bcsgFwQsO9YRsUeCL8NUZ906Tv5NpE3G7gZWVPFCYAU/Xm36Z6BwrEoRS8ZumExGsFxjW0iQOwPiLapv8lzPEFUGmABN/f38phIGGKG9sBhC+ezp5sPOad+mUJK+qz/WdQP9GIoYBGwlcR5vmRJKlfEJ1jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DpYrF7KSDbPhTXNaRG0ucQqP6OoQ/tRzexX94YTas9I=; b=eSpQalusTYnEiJTdjndoz8+ZRCBR89/oRrCbNXJwWdCWS85jE5u33i1N+eANWseMwKzKx0U3xeNiDQyjU46zYOmOKB2TttFSQWJby28D8goz4m9ZjmRDRjWAWFq4I6DIOoJqEwIGdShomua7F6ptU4cXMVqaf3iPbPym3OEfjam3KBqIF7FnRInQ+stpMkeey3D5UiG0CLESb9Y0lnKEhTldKfpk/q/15rWYCE4/8VTCUPiADkOJ5Xg6J1DCIFJX+bQLPX/8tr2DQ8eFZY+HNlEoqtKJfK/L778qcBO7gzwuPTEuieRtuWPIgJ4cwyotkRWPQ+OotXAmyI1jFl0aBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DpYrF7KSDbPhTXNaRG0ucQqP6OoQ/tRzexX94YTas9I=; b=d1zJftwUNqSn/Dc/3iNv5cTbsD8ee/2FTJbaWdrUWa/6kv6koOxm11QDLiEnzhHzSfdUdtCF12TnTlXc/3IXMy32Ql8dWJhj+kpdS2GjZdL17aR0HDfe/6H8HcRjsLF7nK0Cb69N/1WiQeGV2tWZ3ypTwAA02nMja2G8aU6dmFU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> Date: Mon, 27 Feb 2023 11:15:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0186.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7107:EE_ X-MS-Office365-Filtering-Correlation-Id: 4116d862-5bfc-486e-85da-08db18b3e9b7 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5UWHxYUbvRkuNqFKmUxGB30SQm3S0jjIzfs2ab9+aqLn/Ep1Pm8oFGf6h9E9jslCtRP0br3O1kKJq9VTDzjsQvuaSkYDIF16lLUdl7xrO5APMtlLO9FvUgJyNnBHsROEqIeFS53hSFiNEr4V86dRy5PAHBPf4+XzuhWDXIn2NKcL/wRagqgJnsGm3jCDwJHdAQV4BPl725DgOFRjbhBEUvn9YTdyeVKHCssEnrb30gZQAtn1+EYOOML9SWTGKKYGlLcjZURe0T1EI5ircVpnlDiwz/N9AOgkgr3R+NWb+4M0JkLrwIv2TlMhQmWxL2hm4X8i5YXQpZl8OBuKpX+NQz30o5Qb/kcNuolo1vMpwXOQBm17yDuWEanWWEPYtE8mGgJnRWIjnhcE9KacHzzzlKh1/ywu03wRAee+Fw7z0bFeiP4N73Aea1U2btGU58thekGtcCWRdLmK5Sn+rNxdwVcfb9DtqzLKyd//OJTGyE94XtsrJhr5A++hH5tt9oJG2uVWzhGqLsJqyNkBQU9eVc0WXer4SFc9PhIRKDJalsn6fjVbUu18Vxdox3lYyNtORPsrtFLwmlkmNEUZWMoZoVgRDS45XjzwNCzsN3QHom4+/Yt5cW+6RVmTcDUqaIl+DmdEwD1QBrj4v83Yg+T3lDL3MpZuvCg2tYjKQ9WXhh8rujnGk/NIKxBKEYl+WoJRbOKn47Ebm2H5Ooq1dVAwevyxL91Cw8dW21Y7S7rHCm4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199018)(8936002)(8676002)(6916009)(41300700001)(31686004)(5660300002)(66946007)(4326008)(66556008)(66476007)(38100700002)(2906002)(82960400001)(316002)(36756003)(54906003)(478600001)(6486002)(26005)(186003)(2616005)(86362001)(31696002)(6506007)(6512007)(6666004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVNWbytFQUxUNmlid3lINXRyQ1VHRWNBd2lXM20yb1BDbDVrOEVrdkNnZ0RP?= =?utf-8?B?SE1lN01FUDJNOVN0N2FDb29UTXd1RmxIcTlGQXQyTTVmYnU5dnZxSUtselhl?= =?utf-8?B?QTlGTGpuZTZvd011STFhL1YxRk1UaFc2M1VnUWxaUlc3WlNwWDFSNFBCbUxU?= =?utf-8?B?SjVheWxqaXhQL2MzUWVxUWx2WXJJN1BTeURiNUN4b1Axd3NCaVVkVzBnMjlM?= =?utf-8?B?eUZ3R0NmUG9UbFF2UU5xeUhFTGJIOSsyVGFveGsreWFqNW5uTERuZml2VHVz?= =?utf-8?B?K25LeUNIMDQ1QWFjRUhTa1NmcERDekd3QktXdEYwbHR6OTNtdGxibW81TnpH?= =?utf-8?B?S1dhVTAyS01md0ZlOU0zWm5idVFBVkNzdmg0clhDQWpqM1l4Zlc4NnhLZzlR?= =?utf-8?B?WEc5WDdJYkdMSUJnZjdVa3loZUovNHFOdWkyRHhDcExKTklxdlhyNExKek00?= =?utf-8?B?S29NUENqaU1ZOURZb0dpS0Jac1MrWDVpVEhiZDBaS1o5U0xtSWt1T2lVUXgr?= =?utf-8?B?R1VPUmU0RTBTQmhqMTR1WGR3TW1DQXlFWmIvMmFKb25oZmV5NGJUQlAwcWMy?= =?utf-8?B?MTVtV2hzdUd6UFpCUWZkVEVnZzdWSXIvVkVMMnQ5WU5XdGZZcGFPdlgwMk9L?= =?utf-8?B?MlgzM1g0M2t2WGdRMitNbHZtdGFRUVN3UzZjYXJQWW4vTnUzYU4vSS82TlVU?= =?utf-8?B?WGh0bjhhRUZnUVkxRDQ0MWlwUEFOdlBWTUY1c3ZaZnVVOUJreFFBa0JuREZX?= =?utf-8?B?YWs1ZjY1eGZScUFIMHhWVmt4d0g4d0IrMzdqSjVDUitTcWY3NGRtS1VGL3JE?= =?utf-8?B?RnJUVWZ2UnZFcmwvamo1eGRPQVl0aFlWUFVBZDhURHRPUXA5NEY1SGROVSsx?= =?utf-8?B?VU1oaUEwUTVHMURFMlFtV0g4OTlhbU84SnJSamxKanQ0ZzliZ2czSnlWTERF?= =?utf-8?B?LzU0ZmFsYnh4TEFCc25sNnhNbzE1ZnRjNXpnRlBVTit3dW04R1ZqWkUxZmRE?= =?utf-8?B?ZFpPUTBNdG5VTzVYK1BBUVpVN1NQL2tITlVuMWFBWmVaOW1Ba21BTWFpU054?= =?utf-8?B?YlFjYTAzemFXdjgvUU9uRW5oSUFsdjBKdTQ0aHFvYXdLTnpBZjVZTUdTTzkr?= =?utf-8?B?dXhRYjhHOVZ5ZG5NZHNLYndyR2FYeEJ1NE1pcVh4SmVLd0Q3K1BwZXdEWWNz?= =?utf-8?B?V295em54RGpHUjE0TFplYkVLQkFSZTBhREs4ZDNPZjZPNDhuM2tXUVhCdUtC?= =?utf-8?B?UlM5OVBvTEFZRkJuWUxiR09Jd0FYUnp0MDdXZEp3MVZSNjBneVk1MklKTGZq?= =?utf-8?B?NzVyejNRSjRHVVIwanJFUG55NnNIRmt4VXNjOFI2QldaUzl1akQvcTdXNFQ5?= =?utf-8?B?NHZwY2VTb00rZGdRNHhOMWdWbWhJL1FuSDlUQzhUY3JybGp6cnpZaEN5YXB4?= =?utf-8?B?YU03eld0MG9sMytLQjI1djBXOHZXWmN4Y2hscVd1N0RmdXZsajFWNlZwMUY0?= =?utf-8?B?SkxjdURTNWlrdzFlRG84dDl0UDYxSG5oWGdUZkQwZUVNa2c0SVVrRXdOWll6?= =?utf-8?B?eVA0M2t3OERUNCtlVzdOb1ZqRjd3TGIrUlhYbW5VZ1pLSWlzK09RSEpqeXJJ?= =?utf-8?B?SlFnZ3ZQeGc2TjZYTDNuSUc3eExUV1piTEdmekI4UDFjM2x1VExwOG9TTk8z?= =?utf-8?B?eHFuNVo2QVVORzY0YWpoZnNSYWZZdXJ2cTcvN1hLcWFVVmRaQ2o2a2dXeFZp?= =?utf-8?B?OEhBR1RxYjF4WS9YMjlFVE1JWVA0MWw3T2NlR0dFd0pMdWNhWVRGd3JoNHRB?= =?utf-8?B?QjdEaUNTUjZtUE9oOWREajdSUSs2Umc2Q0pCL1pDZy9seDIyYnN1ZWJwTFpt?= =?utf-8?B?dmNySW5USW9NWjAwUCtDQjkvZFFMNmRXQ1NSLzdRVVJERWNNa0pXdVlxemJw?= =?utf-8?B?RXdTOXBvSTdDR1dKWU92UEdSd01ST2JEZVRaQzBKZXVCZ0FHRHpFNnhreFRn?= =?utf-8?B?OVZyMjFxZExnTFFVRnZyZXM3K2VxQVZwSUR6Y3BDUjF1a1ZmbDlHaUQweFFR?= =?utf-8?B?dkNEMnNtTkdacFJ4ZEF1UFl3UnE1NTJvai80R3puVXdPcWxLR1VyMkRNL0Za?= =?utf-8?B?SmpLNzB0NjdLUUJDLzl5c2ZXTHpPSHpqL01pZlBxR01Wdm9GREZtOGZ6RzMx?= =?utf-8?B?anc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sLH7Km/6BZYgLnJdW5qWkVRPAitbIMQbNhZ8YCZJnj5G5mnoBIa/cffRnlFl4LTijZ4uA2OeJKFECCHgn60lW/7aPhUAvgLf7DhP8htFrLccSVaVWW+EFHFNY4kChYNcdM6tX1ANW3ZQFI8BMxx7OzvZWuYPZYzo9GEPQFIQ/MnZE2CJggbBTcExoeXWsTV1vEWg1kgvWkkrgaA5W5VS9IcLjTzSpWeFZsy7sx7NSZoiuV4HdUCxmVr8FU2llPO7N4MybwUVs9VYWTOwjhXN2vIs6p1ZB7i2i/P+S9b50nb4qxkusTOFn8jCH42RsVSCUJkEvvw+8E6VM4A/rLP7Qy2fsbh+Qf7nzL6oRqrlKXzLF7bsrhCrA89+W41Q0qDbWdd7elm15UDui9KPah401X2NjFBFIYTz4WeYPYOuDw1FCuIOpYXWzLaThLzHxvfUOqVkjKA2Nak8Zf027WQrxlP6J1ircQ3soFXjX9mwJeE2w/xl8T6ldLjNaFGKqCCckXw4M3ZM4Rm+4bnAMpKuX/pe3dRDbNwkaLuEE3R6Vn71JNVPF+PZ8d9gb48dQmR2rM/H4/DLdpmEK/+w9eNFuj4gzJn7EKdm/723ntYCjmPBfa5GDfiEa3VFaxRljg0QB/B2JckEoY+FpGGO6ewSoCleeylM99t67haAB1wdmcWIA6z9pSOFl4X1BGvC9xSOymtYWsDMEydnaq0UWFeSlIxVLCkOfkDxO+ICxFKmhIz1mscj48y90/U6ppBXYEFYtru6vRe/dFZzMB9h0iCHY0CvTo/gkltbn+CDcvORlXit8KB/BznY66g5qH4scKfgYts8qceS4ELk9o/AG1GnXIKgUdWtN3amlT5F+QcjfAhWN+dVjAWtkfzyN8MFYVSw X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4116d862-5bfc-486e-85da-08db18b3e9b7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:15:20.5044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gIzU2hv8Apfb4hoB8J4uOKAU4QOoiOzeg+GRb9P3LSEZizfo2d2zCGWUTjakdi5UuYgc/WXrpbgDOOc28u8tmBK5KOS7Nyr6MUJBWFCz3Q0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7107 On 27/02/2023 10:46 am, Jan Beulich wrote: > On 24.02.2023 22:33, Andrew Cooper wrote: >> But I think we want to change tact slightly at this point, so I'm not >> going to do any further tweaking on commit. >> >> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >> updating the non-SVM include paths as we go.  Probably best to >> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >> only got one tree-wide cleanup of the external include paths. >> >> Quick tangent - I will be making all of that cpu_has_svm_* >> infrastructure disappear by moving it into the normal CPUID handling, >> but I've not had sufficient time to finish that yet. >> >> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >> disappear (after my decoupling patch has gone in). > Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? > The latter doesn't use anything from the former, does it? It's about what else uses them. hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always included in tandem. nestedsvm is literally just one struct now, and no subsystem ought to have multiple headers when one will do. The resulting "unified" svm.h will have very little in it, but everything in it (including nestedsvm) should be there. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:19:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502390.774161 (Exim 4.92) (envelope-from ) id 1pWbXo-0007OX-4d; Mon, 27 Feb 2023 11:19:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502390.774161; Mon, 27 Feb 2023 11:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbXo-0007OQ-20; Mon, 27 Feb 2023 11:19:48 +0000 Received: by outflank-mailman (input) for mailman id 502390; Mon, 27 Feb 2023 11:19:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbXl-0007OK-TA for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:19:46 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a344c77a-b690-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:19:44 +0100 (CET) Received: by mail-lf1-x12d.google.com with SMTP id s20so8017121lfb.11 for ; Mon, 27 Feb 2023 03:19:44 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id w26-20020ac2599a000000b004db513b0175sm864612lfn.136.2023.02.27.03.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 03:19:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a344c77a-b690-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Ayrn8/LFsotyDDm6Z/Mc8ba9pVXgViWhZp7UVN9PO7U=; b=GCFMDRjSxgzyWqu0g4WF3zELZK+FjaBRvJQbwmJoS0ze/6dK77xupZlSqfs+QRnaYx viR67roWblF4dzBCU2h+Ks4zUpWCwKryAu93r857ZpVYQJi3euaP7aYOdy1cAuHyo/lL 7R4f0GJOONaWDuZwmIyBQrYyvWUrhuyLYpi0U7f5YXPIQ8FPTf7ettDD732AcNgarXzP +DMx7B+hS8Rkd+jhkPuI/H+xrTUYdVvZ+928JhvJnGqdfETJ9Tv4QIuYm+FUEWUK7nYG JnHpr7XeWFmsDNkE789iXx1xRmpSXbUJlI6Q6RvVoZ4zeY4GDGl31ACq2ACWpieaSJtk aNZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ayrn8/LFsotyDDm6Z/Mc8ba9pVXgViWhZp7UVN9PO7U=; b=nxYv+zsjJqdJrGKaE7hecQD3Kl0mvotsaFyKS7YO4o02KVF5zbPdtHoDo7cR8IYSyR lA6lfiCELBfemvAs0ZpBxjvt78oETmp52mmrbqo63WWFv8XNb5mlkw13R/Zstw1V+RdG vmuKsij9hCBm3oOQYWhZWUW1jZaDE5rkLmrNoQEtnRo2J01rBAQJcJFerq9in7yw9zMi 3cFqX4zccL6qaaYKXm0l0S/NnHv+N7WTaHx+wwaHBBYm79mnT8caosw9/wp5c/mgKIUe 7tS1j8+FneABSt4ITAMtAL4tAI5zheBs/YtqOq2rItid/szkk0UrJh+jpV4UvfDxBL6U CjPQ== X-Gm-Message-State: AO0yUKVetZYwC9tqX5mDbBwGtcABDVlQtTTFCwsiYeB0ijSxpCdvGkW/ UuKAWcbd/xrRoABcYjG0Y44= X-Google-Smtp-Source: AK7set+7m6NuoGN63ZVZEziJpo4StueTbu/SGUzmQDG/RISR6dshCfMqvf9cr/2hK7ayC5e/yz/63g== X-Received: by 2002:a19:c20e:0:b0:4e0:a426:6ddc with SMTP id l14-20020a19c20e000000b004e0a4266ddcmr567579lfc.0.1677496784321; Mon, 27 Feb 2023 03:19:44 -0800 (PST) Message-ID: Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Mon, 27 Feb 2023 13:19:42 +0200 In-Reply-To: <738ca749-2abb-6ab4-db8f-81ff41f4de16@suse.com> References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> <738ca749-2abb-6ab4-db8f-81ff41f4de16@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-27 at 10:17 +0100, Jan Beulich wrote: > On 24.02.2023 17:36, Oleksii wrote: > > On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote: > > > On 24.02.2023 15:48, Oleksii Kurochko wrote: > > > > Signed-off-by: Oleksii Kurochko > > > > --- > > > > =C2=A0xen/arch/riscv/setup.c | 12 ++++++++++++ > > > > =C2=A01 file changed, 12 insertions(+) > > > >=20 > > > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > > > index b3f8b10f71..154bf3a0bc 100644 > > > > --- a/xen/arch/riscv/setup.c > > > > +++ b/xen/arch/riscv/setup.c > > > > @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) > > > > =C2=A0 > > > > =C2=A0void __init noreturn start_xen(void) > > > > =C2=A0{ > > > > +=C2=A0=C2=A0=C2=A0 /* > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * The following things are passed by boot= loader: > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a0 -> hart_id > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a1 -> dtb_base > > > > +=C2=A0=C2=A0=C2=A0 */ > > > > +=C2=A0=C2=A0=C2=A0 register unsigned long hart_id=C2=A0 asm("a0"); > > > > +=C2=A0=C2=A0=C2=A0 register unsigned long dtb_base asm("a1"); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a0" : "=3Dr" (hart_id) ); > > > > + > > > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a1" : "=3Dr" (dtb_base) )= ; > > >=20 > > > Are you sure this (a) works and (b) is what you want? You're > > > inserting > > Oh, yeah... it should be: > > =C2=A0 unsigned long hart_id; > > =C2=A0 unsigned long dtb_base; >=20 > As per below - no, I don't think so. I continue to think these want > to be function parameters. >=20 > > I did experiments with 'register' and 'asm()' and after rebase of > > my > > internal branches git backed these changes... > >=20 > > Sorry for that I have to double check patches next time. > >=20 > > It looks like it works only because the variables aren't used > > anywhere. > > > "mov a0, a0" and "mov a1, a1". I suppose as long as the two local > > > variables aren't used further down in the function, the compiler > > > will > > > be able to recognize both registers as dead, and hence use them > > > for > > > argument passing to later functions that you call. But I would > > > expect > > > that to break once you actually consume either of the variables. > > >=20 > > > Fundamentally I think this is the kind of thing you want do to in > > > assembly. However, in the specific case here, can't you simply > > > have > > >=20 > > > void __init noreturn start_xen(unsigned long hard_id, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long dtb_base) > > > { > > > =C2=A0=C2=A0=C2=A0 ... > > >=20 > > > and all is going to be fine, without any asm()? > > One of the things that I would like to do is to not use an > > assembler as > > much as possible. And as we have C environment ready after a few > > assembly instructions in head.S I thought it would be OK to do it > > in C > > code somewhere at the start so someone/sonething doesn't alter > > register > > a0 and a1. >=20 > Avoiding assembly code where possible if of course appreciated, > because > generally C code is easier to maintain. But of course this can only > be > done if things can be expressed correctly. And you need to keep in > mind > that asm() statements also are assembly code, just lower volume. >=20 Let's get hard_id and dtb_base in head.S and pass them as arguments of start_xen() function as you mentioned before. I'll update the patch and send new version. > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:28:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:28:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502396.774171 (Exim 4.92) (envelope-from ) id 1pWbfp-0000Rg-Ux; Mon, 27 Feb 2023 11:28:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502396.774171; Mon, 27 Feb 2023 11:28:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbfp-0000RZ-SG; Mon, 27 Feb 2023 11:28:05 +0000 Received: by outflank-mailman (input) for mailman id 502396; Mon, 27 Feb 2023 11:28:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbfo-0000RT-SQ for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:28:04 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cba94f27-b691-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:28:03 +0100 (CET) Received: from mail-co1nam11lp2174.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 06:28:01 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB4966.namprd03.prod.outlook.com (2603:10b6:a03:1eb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 11:27:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:27:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cba94f27-b691-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677497283; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=wm/NFo3BAu17msknJ+L9gDTeuE0IRHMZnnrjelXuSUo=; b=bvcIoQhixhHJMcb84TviN5gw8u/u8t9uVLyQXZWLAFQq7h8s2v+LojP0 ym2szo2vJ0K4T/OBfrxcKZe6CzHTxjnzwXOKSMuRv8GdwzwzvQaiZ6aOq JjOffPviPcaSu5sOKB2RBRgXgpMBrf9PWJNuQHzOEzsIbl17ToPb2ao3d A=; X-IronPort-RemoteIP: 104.47.56.174 X-IronPort-MID: 98572584 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:HCGpkavJ2CS+43l2cB2puGPLzefnVHRfMUV32f8akzHdYApBsoF/q tZmKWqHb6zbYGWmf9AgO4uw9E4O6MDVzYRnS1A6+ShmRHhD+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj51v0gnRkPaoQ5AWEyCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOCsBYC+Oq7+P/5GrRekwgMMGa/nyM9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4a9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzoq6Ew3Q3ProAVIBoHTkKWosa/tn+VBO1ED F0Rxi0nsJFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ4iUvJR9M6Saqt1ISqRXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodu51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:CYPdLKMSW2yJlsBcTvyjsMiBIKoaSvp033AB3UoZc20zTiX+ra yTdZUguiMc7Qx7ZJhOo7690cW7IE80l6QFgrX5TI3DYOCOggLBRuxfBODZsl/d8kPFh4pg/J YlX69iCMDhSXhW5PyKhjVQyuxQpeW6zA== X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98572584" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UdGfksjbm47aAfROJUaranqtIQTDs66aGzbVoxeosr58SuX0WBaCqq+Z+caq8AgpOxFZvpsPESWUl3vN0qUOjC3jvGjcXlrNoGI/I/bHK1k/vwp1xvvKVA6kfuSCBdTqbGuiBq0D8GG0wjoD8VQk0PksPzyshtmkrZ0Az1vkIoNUDn9ngd1usCZgAHHf7YU6eFOmppVb7GWjzvhZsLu2h8J5LBTQv0RxjoeA9UcgDjHiYYM0RkDV6UQPE+RjrLQNfnfreL2UM16s05AIeXFg07CXFOHgVBtKig96rujH5Yk3TJTrO4KNjqzF2vqhXq7dSdOMapCWQotgvIngxZWJIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wm/NFo3BAu17msknJ+L9gDTeuE0IRHMZnnrjelXuSUo=; b=LVq8JCcILmijtVszTCBOEnsx71Od6e/htl783PKoMGHYp7DTIc3PaeI8OOdONhOJOBUGf9Co7haX1AekjZPLhaI+dQxpLakLVmo6fdpzGg1/IcLIrpBn/XIA8q+DPQfGRL7vMSLp0rSip/DY86dbUX+EoEcwXolCZLvOMr9vXg3he8ETQruy9W3p22syqsv/Wfmtcgk9gLSbX0zbl/6i1+ojP7sLgqcMijN2AwXf+bUvYmxhTQP1+WKjEDK5psg1hqxj614wpc4O1Wc+ebsdpK2YHGNdDJELRNsaQMuHUmiXEtqSGoiKFhVh3P1aM0XnFHh6O+xvpcqiC0IWTlj0zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wm/NFo3BAu17msknJ+L9gDTeuE0IRHMZnnrjelXuSUo=; b=Y2DDg0FV/4sP8qhno8VK0eThtbMUmXpvNSm8SQ/wtOg+YodeNmAgJVl3LFHeJtYUjCcIMhJM7Uq/U+PNE0PyGquyOoYSk9KmGyXHdVnjujWd3fX+uuVHwtXdflCermolTLt/Sb9GAxItAoq5rWtMXSWSRH5C3lw3gr85OG8vpRo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <35de356c-0ed0-fa23-5cd6-c13c534a3ca0@citrix.com> Date: Mon, 27 Feb 2023 11:27:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[] Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0466.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB4966:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ef73321-4af0-4db9-8fd2-08db18b5ad43 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u8fw8s5ARVfTil50sK8kVCk1s5BKEG++AGcnNgJa+Ity/GUEpgk4IsUHvatreL8cyciomwB8Sclqb2wqYKfHJKQxNxsw3hAdbngHfgBYdPEiSEeK7GqgRU0gDSKp7ufFUCaHoghTPbzH0mkZXm0lgljq/A1orqdAmwXca6+QFaEoXLDXuq19kJSwviRDMcbg+atXvPpjaRatF82rH+3gXgMABdWAbgYsWlWJF1pZSwIElvw93g2Z0IWIKOZt+SFVS6J37DK/y7gTg+nkiNAjDJv09JTjJLr/YJ6v5/cH+b/B5a91ZSVO/M9TGwJKQhUkhmLMjJ/69eBBVZ498WsqQW/AsoKT3eSjPJaPkg+a4UtsKN2gbrPmZ8Hrz1jMcjDnhLDV0LQ5qKeN7oF7oIyYD8iZV3VmKM89AvHG876tb7bHDGmQN1eOMiWpZcij+G4gqPkJDAfEL+GqxT9hGszAfQqY4xlrJCrTtTC9JRWUgVRJfLHEB8bNP4QqteTJaf+0DVP7D7M7UQyhDoW5hpeaRuTE7waalaopjiCl0/S+9V0LcWLvGJ8HjP43IxR8Y42U27cTHfFvlW6cyMw83kn8Ic5DU/sC+/GBg93ifIJ9czfDJK6GGmCuxerhzFdOAQEuLToJrW86DXB87ik3Q9RhnIp8y6rANbvUuaq7f6DaWCX7GkCOT7+8rKGM0Uxkl19Bhi8ykY3EBILbrpxwnM7uDxXy5+m16acKcGNDmqRZsss= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199018)(38100700002)(2906002)(82960400001)(31686004)(4744005)(66899018)(5660300002)(8936002)(2616005)(66946007)(316002)(6486002)(86362001)(66476007)(66556008)(6512007)(8676002)(53546011)(6506007)(4326008)(186003)(26005)(478600001)(54906003)(110136005)(36756003)(31696002)(107886003)(6666004)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUg5M1VTZ2pJSWpZSXFSczl2U3RicHk3OVZwL3pVNWNkVHByWElKL0Z3SXl2?= =?utf-8?B?M1JlR2dOUEc1QzcweEpaMDRCUzdlMnYzYlZzci9WeUo2bC9OazdHM0NPY0kz?= =?utf-8?B?L1VZR2JhcVpBbDc0OVVOR1pJcExEV2hDdDdGNyswc3NhMzhmUEFPUnVuT0cw?= =?utf-8?B?MHJ3WXRnSHlsN1k0ZCtUS25QWjlvWm82K3NlVGo0bFRRTnJWTGcyejVHUTc3?= =?utf-8?B?SUl4YVR4ZEJTSENaMG05OFFac2xadU1nbkhmSUlvdWNoT1ZqVGE4T1pvcldo?= =?utf-8?B?azZvZDlQak9CaGFoUlEwYjB2T09pRlhTRDRwVjUwbHRCc2NGbkl2SlBVT1lK?= =?utf-8?B?amFKTHJVSGRGQjRMSDBjNWk3eEhtb3pFRnJsbEVlNWpMRGQwc2NFU0RSVC9K?= =?utf-8?B?eWVIdCtOUDdtQVZlaENUQnVvaHdqRUtjUy84NHE0NWRVZ2lyUDcvcmZhZDRi?= =?utf-8?B?ek50VHovWXNxSGVoYjd2Y213bmllZStReW12bnFZZXNIZEtNM1Vka0pXUk5t?= =?utf-8?B?aXNib2ZFUUozWTdZeERpekFHWktJS3lZSmFSanZoU0I4WGhvbTBVY3I1UFZE?= =?utf-8?B?c1B2eEdvdnRjbDZ5LzVHWVdmTElYQkk4MDNBV2QrZ3VUK25jWHFTMkZZYzIv?= =?utf-8?B?YXNFYmNvL3lTVG9xZEQ4OGd0dFpLSG80cVMxZGNSUm5vdjY5N0VFbU43bFpV?= =?utf-8?B?bmtERGhBU2RqNkpuM2pFSjBGbUEzZmpyRG5hYWFKcHlSUE1wRDVncmlzTEhw?= =?utf-8?B?Z2hEOWdnQnViUDBhNU9KQ2R5Z2lTSGl3MGNjakUrLyt4akc5OXIzQ3NtdWU1?= =?utf-8?B?K0laWFg5YUI3dWRXVHBtNjE0Nk94RkNGbEUwb1BMVFR2bjRETGx5L1RBZ3dX?= =?utf-8?B?QlpRS0V6RDlsNmtsVEkrbUVzUWFKcDVsbUM2cjIwZlhabnpOWlJvZ254LzBF?= =?utf-8?B?YitxcGQ4WUt6UEJjZWZtTmh3N3BhbUlHRjRvaml0WDgwamFiV2FKdjhKTTlv?= =?utf-8?B?c24wKzdpeDV0bHpzZC9EdzM2NDBkbGpzaGRwcHRqSWFEUUZQU1dxL0JTVE1Z?= =?utf-8?B?MlpEbEpaR09pVEVySWQ0STRmUC9Bb1hzNGtYSkJReElVUXdwTXdhT25lTWZx?= =?utf-8?B?ZUYyWkZZMlQ1TmJ1TXczK2E4N2F5aTRvZDR2UWo2V0o0QUJOUU1zazRsbmNO?= =?utf-8?B?T2QzZVhob25WWFJueGdIaEU0ZzR6WFdhSmdsZlJqWnhjK0crWHZhRGc4Y1Uw?= =?utf-8?B?K1o2ak5DeUFrblREbFU1cFlmT1k0Z01LTUIvWVJtMmJqcG1kUGgxSXllRjFt?= =?utf-8?B?SmNuelc5V0Q3aDM0c2lMaDRYVG1LcGNOZG9vblJqcmV5aXdMbTlqT3IwTGMx?= =?utf-8?B?NGVlQUQrTjVXeEhEYkJaL1FXaWxXSnR4N0Z6TDBHdEFLY2dYWVNRUTU3ZndU?= =?utf-8?B?Y0VQNjJMVFNSOGJZVEFxekN6T3FSUEZ3aVpZWC9hN1hsS3k1L1B6aHB3L3l5?= =?utf-8?B?endHM3k2ZW1NTzltSWNUWW1CeTRuS2Z2QXcyLzJiNVkvM00rc0EvRXl6UGt2?= =?utf-8?B?cGMxV3cvWjFFTnFndzlFczlXcCs2clF2SVZCZ3Q2b0QzMU5wRU8rQlFYaXcy?= =?utf-8?B?d1RWWmp4cCtpclQyVExndVZ3TTVCYlk3NlIyclZyeURFck1yZE1jdFJzejhY?= =?utf-8?B?bWg0OFJYdE1HZ2JsaXF0RFg1QkJXOXJYbUxUSmpaTFJ5SFk1dnUzK0R5cW1D?= =?utf-8?B?RU55QzVqWEZuZVBWVkJUam1VaEIzbnl1MDVOOWg2UGJWajlXNllzbTdPT3E3?= =?utf-8?B?MDFVRGJVNDE3SHQ2cnRBa1dCZnVnTWpwQ3dPNVJ4ZE9Ja0oyVGQ2eUxJVGY3?= =?utf-8?B?eGVodGdGa0k4b0RDLzI5TEZkcWtPYW5VYU9kTFhEU0FlWm1FVnBzWEhDWW5H?= =?utf-8?B?YmZQQjg3Q2N5TDI5Q1JYMzN4aVd6eUUxa0NkYkpXbGM3Q0dralB2aGp5cnJ0?= =?utf-8?B?K1ZNUFF5VXFMUFpkTnhhNEZXd3hRbVAvTnJudnVqUm1jcWsvVW5MVkVCWHRy?= =?utf-8?B?cVg4eXVPODZ2b1pCdS9SMGhuTElhbld1RktOWTFnR0MvSVUrbVRLNmNSRXZm?= =?utf-8?B?Y0VsVytlczNYMThyMU5Ka2lpbDNSMmtiOXRaaXk3dGs0S25lNHdnRm1OWmJP?= =?utf-8?B?WHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7FDtgBOpCuDPq0+Tioo9kx5Vq9G250GWUheOBM1klU2pMnPC6Ojpq5laN9anlgS3+QDMKmtZIkvn9ap/PFgkaFAC+MNmPBexMiOSNcwstY6sexmVXRkS7L6+wVadOlkIWqaXlbasY0cL+5jJXPIJ3NId/ESAlpfczHgISqtq2orxyF2gwwRYAYl+62SVhV3GQjl+GPWuk7ZKZ2ySbNOJmDbg7n3aEoUgKkDqQikBR9ljaB+1E6R2JJxjr3YO8PJu2lC3tOSen4m+tu/jT66+4limBldWdFzpuePb2Mm1MQpWvoNVUz47Zo1/BGo+/3SXJyKlIWw67xls/GLXtX2nFJdjUHi2omYewnZlvi/23RP3dzbHptZNiJRniXfOvqq0Y8XrNfJ10iXHvPkGPXa3l1HOQ0P3zWKL67bSSH7D9LYM49hpslxIkytYVktlviboyyCDg55eFLTB6T1eYQ2dWbX4cK5loUkBA8gR1KnRj8kOZJEkq4B/IOz27NSlKh0ptO8smvPYIphznkcFOfa50DOmzyDV8Q/reRQhek0rqGSiwBdBBgwi5TyCOEusJYx0+IuiZ8h7K2gM4H98i+89Xm6yjeFp5Vzvm6nZXHUilh+mkKhLhR2bXtqm3rv5aeYruFqtoIQNVfEcEjvuF3efSs3sgIuiZRaO2DD/PGT0qIECmYxOKbrumAY8fW/OSl1ZVkQY92jWkouJeqv9vUS1A8MmxKk2yfABlbatF/Y0kuYeikMiA/yh7cLsw94LodMeUDDw4gvxgr/J7S6bHqvHLxYqVASXhfLfd0QC4h6OxwecNZsTsvSrU+eK+En56UpDSmTH5XZrSpNLPrXwyuEv/A== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef73321-4af0-4db9-8fd2-08db18b5ad43 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:27:58.0902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ch9BszX3oIuS6BRzJShKq8nEZK/m60UZKD4WOxc9TZY/xTyqILBU5LQmuIn8gJ8vaBBLMTylekyUGz1fIWcEPTd5GVSSoKLW7GsSPTCsp4g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4966 On 27/02/2023 9:32 am, Jan Beulich wrote: > There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct > Xen's idea of its own memory layout"). For what's left, switch to > "unsigned char" as here we're not dealing with strings of any kind. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:34:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502411.774182 (Exim 4.92) (envelope-from ) id 1pWblU-0002Cw-Kh; Mon, 27 Feb 2023 11:33:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502411.774182; Mon, 27 Feb 2023 11:33:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWblU-0002Cp-Ga; Mon, 27 Feb 2023 11:33:56 +0000 Received: by outflank-mailman (input) for mailman id 502411; Mon, 27 Feb 2023 11:33:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWblT-0002Cj-0H for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:33:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7d00::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9af6d54b-b692-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:33:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8848.eurprd04.prod.outlook.com (2603:10a6:102:20f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 11:33:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:33:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9af6d54b-b692-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFivdKEJZ5AFlxfR8F6almcCFbw91Zxhd3iDeyFVKUlDdfDlfDWalutR/GLAJZeqgFd7xMKl4FD8IdnrRrez5rwMnuvRufKmGGTr//W9UmaSsArkRyXUQzWxtkXhxESWEEyDoRtJd+ub3C4StGCFaZ57nQHc/5dce//li+F0BJytNH1JLduCc+vb2FaiqemCSZSzgWAQyOwYeC2GTynLByBSdyA9S7UWQy8j1gniXDOPAOZrH7NsaGfsuCeHcNV5N/CC77QbG4gEQYVn0M0adKvbYdIvfU47X7FfAYezg+23npZtCwOpo46hpN6T6+/O9FgiXjG6jhHtOXE9eRf5PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g+bNr4gg661ozvSa8Wp8fouuL/YidAmxpC494vqn6nI=; b=TvJ/GeEp14RlneJmeyDAyuaZhzUwIE187+Iz0MCRqLyiBQMD0lwnl/tDP1Mbe23y7+/mPafF1jQFEO4hUUC2xv24R2Sh0Vs4D6+5Oo2j8B9+SSyycUuCPbXDK3h+hjNUNzZ0/0q6qoT9k/7q0UYLXW7ls3vFgrrdtcoo6etyjgWFQ43TIFmnmUv12cIttZCXcwZ6VS0brZ9v+mwe5h4Bycs/dlnptw6R3AeTSYFUITzApNagQ8/9IRbyawpGwfePCr5kE+AzphVVRz1zooMtjGl9mWn7roo88Mz1fvFzzR2rvGlcIDJx24citNPC00VhAYoZ5N4ZarGVZ3B3AFSeIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g+bNr4gg661ozvSa8Wp8fouuL/YidAmxpC494vqn6nI=; b=EOGQTcjAGmh0VvY1oW2n+TWPyDOVGXYyqAmrcLpvm3H5TiCz97wngwfcjiBNaNAFGp6jjkQwi0iPKccnImE3xa1y1hMd6pHKDB0Pd9NbrvhJa5Ga3Dy4U/zU+mwinDAZKQAsWOdKMLdBGk6J1HhQuox8KSV+mrLrZpi3JcqErHpgkdvsmB4PSE0VnUXHCfpwVAzMdox2/jSM5ekXraE0Tmo4Zu81TdaEbCVjmwCffu6ojGEj7VzSHGA4jhoPyeNXLs7jJIQ4HmfAk1+Kwcfu5CrlEs7ymwkIZdTGlH4Rkl9u5b8MtEjV9qemb4jkn2kspEtP6+6G9dSgY8Kko+9oTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> Date: Mon, 27 Feb 2023 12:33:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> From: Jan Beulich In-Reply-To: <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0207.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8848:EE_ X-MS-Office365-Filtering-Correlation-Id: abe70091-2a3a-446c-3846-08db18b67dd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y/tL+WfHZ26acMI2sUK6scazHfXXg/9Cqqetg4eD4XqjUi/L00wquMJn3qFvRQ5NulEd6PZaaIgCKEO5Qid8b+skdFGcuGlSsyNT3Ofls6Xcqft6cZRt5WnpZa6KiG20HeuTYg2utQRRSVDd7aVzp4oMdaXqK24kFcfE7aplfZ5quf8XTT1z8AmBXntZGlkr1MG+lO4mz1ZAW5gCfaOEJPBzz5JvrR296/4WkCO5S3NcLre4VD2I/ZocSUvg279v/vdxhJG9bCNOy35JM12GJ1xD66luXBgon3x2ntWR+DUIk7gv95Zul3jjXATOP3iCEcl0cS/oxmque1W5EK74ZusOpilhj2fgmFA7dwg9Zy8A3PZXWHZdyaQuMvje0oG/LjE/X2WLMYQreMVfoCvR68QX6IXLIQELWD0zGLpIPs+3fFt1dU1ZRl32+ZJLDw9GMVrr6Fe+4rwyplSwj52EkxirVtNq+4y5AQHTunkpKQv92U8xNXV6vPwao8BcGDdhEJSPiuN03c3fBMINWnCmjJKaivAE2TnfFUeF+dvOjmFhXQGYU9sPCXbBVJcBfl59jWaWFNNGQBtqFHDoTYXYWhABJYpWmLtPW/0jM16eX7HI+NF/v7iNPGyNteOtwlbEjDLn/UsjidEq8fLHJCdFbsucrP2OMHZxXudnY0B2SYVY2ntuM2V3KQMwdMGdRULIHFRIu9yWcFMc1xRXsBXxQTze/IRM9YtGtPt+tYkPYPA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(39860400002)(396003)(366004)(136003)(451199018)(5660300002)(36756003)(86362001)(31696002)(8936002)(478600001)(2616005)(6486002)(186003)(8676002)(53546011)(6506007)(6512007)(66946007)(26005)(66476007)(38100700002)(66556008)(41300700001)(4326008)(6916009)(54906003)(316002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVBreU1obzJsM0NzOTRLdFFqWHpZaldzL3JGdnZMNk12QTNiVUxOeTNONFRL?= =?utf-8?B?TVN0UVRDZkRVbjE2aDhNMTNVelJmTWZpNk1ZUEZMaW1zN2hpUWd3Y1phME82?= =?utf-8?B?QkNnb21IUzlzY3JuQUhNdkFnQVBvUEFML2drenJia2NjU09XR2xoU2tiblRU?= =?utf-8?B?OVVHd3ZyN1lUT054Nk9uNUpOUDhnLzhLVytSNVN1U1A2VmZ4UkVyS2pMampE?= =?utf-8?B?Z1NHOEFCdWVseUFzNGI1SmRHTjNqT0dHY3l6Smhuc2JqNVlBanBFT2R5WXR3?= =?utf-8?B?Q0FoU2NUaUlNdHdqcWxsWmc4emtzalZCTWc5emUvWVYyc3NWa2ZXdkszV3A0?= =?utf-8?B?d01SQ3h2SnBsK2JmbDFaNjg2ZDRjR1ROQkppMFRFT0puYnlnVmF5bnJSL2hH?= =?utf-8?B?bGpRaUd2YzBtVEF5c2U3L0plWFN6eVhCekx4cVJ1MElubzh1TFJvTlNTOERm?= =?utf-8?B?QUhDQitTdElSVGozekVuSzFWSjN5VVc3NitqdzN5clBEMjY4NXFSZituWGov?= =?utf-8?B?TkFSNjJLT2lEOG9FUGdCRzN0WjAvbkJPUzFySFVTY1k5SVIxa1pqU3dFUEd4?= =?utf-8?B?VXVlZTN4alQ5R3VqOFpaRUxHYTBKQ3hlT3JHMFJGd2EzSGozeUZaRUJOOC9i?= =?utf-8?B?MmlGRm1CM3pyVGU0cXJyZGhWSEFDTXkvL0FCbUdvSExDNEJFNklPdFJWVnZV?= =?utf-8?B?Q0FVSzh5b3VJRXRJUWl5clBCNHlTMlZrTElWblB4M0F3RDVFNTMvRlRHS0Jv?= =?utf-8?B?MWhKcThpM29CK3M0L1FUR3RIeEZNbU91NU8zNldKOWFURU1qVkdYZzB2Wm9k?= =?utf-8?B?THFyU3ZwZElNRHB0WUViOEFlalFoa1FKUUpNMTJHbS80TVovcW9scEEwbm8z?= =?utf-8?B?NFpoaitNYzRHQWF1N1IyTGN2Uml5MDFtNlVZK3lVMlJUMUxKYW02M2pkbkFD?= =?utf-8?B?MHBJUDhDNDVpTjRvUFpzeEpZVExmMm9ySEZiREkzZThvUHRGQXkzZU8vTVZw?= =?utf-8?B?WmhYU3JTS2xWbFUyblYwcnMxbjAxeFpjLzNJdFFQRTlrZkpuWDAxODQ4bXlJ?= =?utf-8?B?OEhYKzlYRytia21MVHpQcTlnR2l2SlhuMFJDOXRCYVZxczhCRnV2UGNDMVdL?= =?utf-8?B?cjMwQTNIaHRPdjgyQ3dpbU1jRU1YcWpGVE0vakxnbDZ2OTZSeUg2WXBDR3RO?= =?utf-8?B?bGc4ZE1KSWNMK1IxNFk3Uml4SFNxTG52WGIzaml1dnVMZ3NwUGNvZ0dRd1lC?= =?utf-8?B?ZmRMWjVDV1lMNGxVdFR1dGFtQTN1NUhETExVMXRHeE5KT1pvMWJkLzBCcEU0?= =?utf-8?B?bi8yMmR0YmJwQ1pxeWlCS1N2bXFVb09waVVWUU5MK3FOMFdUUTNHcE5jT0Y4?= =?utf-8?B?SlF0dVFYZTZsK0tweU5oL29ha1R5ZGRDS1pyT2xUOVJKSUVwdGIyMUJWbUlo?= =?utf-8?B?SzhxUXhyelJKVkIxeVZVVlVtM2JocXo2d0dYK3VldG1sRTBBaWo1dmQwdDR6?= =?utf-8?B?NGp0WmhlZDJPRW5RSFhsVmRwZDh6bTlaaEFjZmtab29HUTErYmQ3QSswYW9m?= =?utf-8?B?akNpb0VacUpTQ05rOW9pbldyOHhXamllU1JwTk5maXVlOXRManYrZlR2T3lv?= =?utf-8?B?Mko3YUhLL3pHdGtVeUFuMzdQeENySzJwYzExU1VTVVl1NXJsU2tZZVovZjZ4?= =?utf-8?B?UHdqZXZQVkF0NWw2SWF5Tk5vaURqOGNRT2NHelp4NGhGZG1rK2JYTGpMQkUr?= =?utf-8?B?QkdCdGJXdEFUcVA3eWIybkNFTmhvWTRSaWhCREZLL2dPZVV1c0NjTVlvTXhp?= =?utf-8?B?TlJvZnhVdFd0NjZNTEI2NjJsK05pSE5IUTV5RDZ3TWIvRkxDVU1ZR2tuV1U4?= =?utf-8?B?bUNNNmJBSG11K1lkL2JkWDVBcHJ6U2lRRUVLWWo3NTU0YlU2OFRDUkV4ZGdC?= =?utf-8?B?bG05YzNCaVpwdWxCSmhPczZuOU5lV3gzc1JFRHVMZDZLRTJlYWR0WTAraEpq?= =?utf-8?B?NEhuUitjdWNBQTNvdWZKSFdBM3lIVzdteGtQNFpPSlVnZCtvektrRW0wZ0JL?= =?utf-8?B?ZkxjbGRETE1UUGxsTVZZRHN4YUpxYjRHV1ZrR2J3RFVZUFppeG56eitXZXRy?= =?utf-8?Q?gv5KbqaOOWyEuvXapMva1XejW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abe70091-2a3a-446c-3846-08db18b67dd5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:33:47.8703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: heF+t5wt70c1ARvAuLkEMrBP9lYrygXTbVPEa97mxk+xEF1Aahe1e+Nspp15IbY/h90fzSBu4Tv1Knfa8NYf+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8848 On 27.02.2023 12:15, Andrew Cooper wrote: > On 27/02/2023 10:46 am, Jan Beulich wrote: >> On 24.02.2023 22:33, Andrew Cooper wrote: >>> But I think we want to change tact slightly at this point, so I'm not >>> going to do any further tweaking on commit. >>> >>> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >>> updating the non-SVM include paths as we go.  Probably best to >>> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >>> only got one tree-wide cleanup of the external include paths. >>> >>> Quick tangent - I will be making all of that cpu_has_svm_* >>> infrastructure disappear by moving it into the normal CPUID handling, >>> but I've not had sufficient time to finish that yet. >>> >>> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >>> disappear (after my decoupling patch has gone in). >> Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? >> The latter doesn't use anything from the former, does it? > > It's about what else uses them. > > hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always > included in tandem. Well, yes, that's how things are today. But can you explain to me why hvm_vcpu has to know nestedsvm's layout? If the field was a pointer, a forward decl of that struct would suffice, and any entity in the rest of Xen not caring about struct nestedsvm would no longer see it (and hence also no longer be re-built if a change is made there). > nestedsvm is literally just one struct now, and no subsystem ought to > have multiple headers when one will do. When one will do, yes. Removing build dependencies is a good reason to have separate headers, though. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:36:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:36:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502418.774191 (Exim 4.92) (envelope-from ) id 1pWbnn-0002qp-5S; Mon, 27 Feb 2023 11:36:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502418.774191; Mon, 27 Feb 2023 11:36:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbnn-0002qi-2g; Mon, 27 Feb 2023 11:36:19 +0000 Received: by outflank-mailman (input) for mailman id 502418; Mon, 27 Feb 2023 11:36:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbnl-0002qb-4F for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:36:17 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef4072fe-b692-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:36:13 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef4072fe-b692-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677497772; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qdPqHjY3LWjug/jN//1EYqFhHat/Uu2KeZ7O9A4yG38=; b=VWCRoKmAHo5PIJwJbeBIaOF87zpOweDuf/5cmiL2dPuqy5M5C7ZhR+y+ h+h538oYcPm6k2riU2k9wzKg0ChgGmiBAwO4L9ZKDFFPdwW9Otyinl54L dOgeR8DN+hrf6nuf2RWgj9NL5NaUU/6bqcWfTogTfs4u2IKt/V9mhA7Cs 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98051109 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:4F0bBa5QpM1NU5XuFfXySgxRtCDHchMFZxGqfqrLsTDasY5as4F+v moYWDuBPfmPYmanfo8nbNnl/BhT7cWAm9dnTQE9q3syHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR4weH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz dE2dnNKNw64gfOn67uWVPBSg8g6BZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9zxbA+ zufpzWR7hcyc/2g7Ry0032QudT+nB7hW6BVEpyBz6s/6LGU7jNKU0BHPbehmtGph0j7V99BJ kg8/is1sbN05EGtVsP6XRCzvDiDpBF0c/h6HvA+6QqN4rHJ+AvfDW8BJhZLdcY0vcsxSTs13 3eGmtroAXpkt7j9dJ6G3u7K93XoY3FTdDJcI3ZeFmPp/uUPvqkLozyRDZE6DpWzn8zeEBzu2 g6PoDEX0uB7YdEw6423+lXOgjSJr5fPTxIo6gi/Yl9J/j+Vd6b+OdX2tAGzAeJoad/AEwLf5 CRsd922trhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iQsI2CBj Kz741k5CHpv0JyCPMdKj3qZUZhC8EQZPY2NugroRtRPeINtUwSM4TtjY0Wdt0i0zhdzzfphZ cnLIJjyZZr/NUiA5GDrL9rxLJdxnnxurY8tbcyTI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A P4GX/ZmPy53CbWkCgGOqN57ELz/BSRjbXwAg5ANJ7Hrz8sPMD1JNsI9Npt6IdE6xPgKzruSl px/M2cBoGfCabT8AV3iQhhehHnHAv6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:RZ+vVKMT9YanL8BcTy3155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBHpTnyAtjlfZq6z+8J3WBxB8bZYOCCggeVxe5ZnOjfKlHbalXDH6tmpN xdmstFeaPN5DpB7foSiTPQe7hA/DDEytHQuQ639QYTcegAUdAE0+4WMHf9LqQ7fnglOXJvf6 Dsmvav6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iYsKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6d2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCqlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0BjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXd WGNPusqsq+TGnqLkww5gJUsZyRtzUIb127q3E5y4OoO2M8pgE786MarPZv7EvouqhNCaWs3N 60QZiApIs+P/P+UpgNdNvpYfHHflAlEii8R156Z26XX506Bw== X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98051109" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Xenia Ragiadakou Subject: [PATCH v2] x86/svm: Decouple types in struct nestedsvm Date: Mon, 27 Feb 2023 11:35:33 +0000 Message-ID: <20230227113533.2848119-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain struct nestedvm uses mostly plain integer types, except for virt_ext_t which is a union wrapping two bitfield names. However, it turns out that this is a write-only variable. Delete it, allowing us to drop the include of vmcb.h Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Xenia Ragiadakou v2: * Delete the variable entirely. This probably means that nested lbr/vmloadsave is broken, but that wouldn't be a surprise at all. --- xen/arch/x86/hvm/svm/nestedsvm.c | 5 ----- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 5 ----- 2 files changed, 10 deletions(-) diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c index 92316c6624ce..63ed9fc248e1 100644 --- a/xen/arch/x86/hvm/svm/nestedsvm.c +++ b/xen/arch/x86/hvm/svm/nestedsvm.c @@ -164,7 +164,6 @@ int cf_check nsvm_vcpu_reset(struct vcpu *v) svm->ns_exception_intercepts = 0; svm->ns_general1_intercepts = 0; svm->ns_general2_intercepts = 0; - svm->ns_virt_ext.bytes = 0; svm->ns_hap_enabled = 0; svm->ns_vmcb_guestcr3 = 0; @@ -524,10 +523,6 @@ static int nsvm_vmcb_prepare4vmrun(struct vcpu *v, struct cpu_user_regs *regs) /* Pending Interrupts */ n2vmcb->event_inj = ns_vmcb->event_inj; - /* LBR and other virtualization */ - if ( !clean.lbr ) - svm->ns_virt_ext = ns_vmcb->virt_ext; - n2vmcb->virt_ext.bytes = n1vmcb->virt_ext.bytes | ns_vmcb->virt_ext.bytes; diff --git a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h index 94d45d2e8d47..230f818df80c 100644 --- a/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h +++ b/xen/arch/x86/include/asm/hvm/svm/nestedsvm.h @@ -20,8 +20,6 @@ #include -#include - struct nestedsvm { bool ns_gif; uint64_t ns_msr_hsavepa; /* MSR HSAVE_PA value */ @@ -43,9 +41,6 @@ struct nestedsvm { uint32_t ns_general1_intercepts; uint32_t ns_general2_intercepts; - /* Cached real lbr and other virtual extentions of the l2 guest */ - virt_ext_t ns_virt_ext; - /* Cached real MSR permission bitmaps of the l2 guest */ unsigned long *ns_cached_msrpm; /* Merged MSR permission bitmap */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:38:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:38:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502422.774202 (Exim 4.92) (envelope-from ) id 1pWbpD-0003P1-Gv; Mon, 27 Feb 2023 11:37:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502422.774202; Mon, 27 Feb 2023 11:37:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbpD-0003Ou-D3; Mon, 27 Feb 2023 11:37:47 +0000 Received: by outflank-mailman (input) for mailman id 502422; Mon, 27 Feb 2023 11:37:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbpB-0003Om-FZ for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:37:45 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 252a35c4-b693-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:37:42 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8848.eurprd04.prod.outlook.com (2603:10a6:102:20f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 11:37:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:37:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 252a35c4-b693-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vln2oZ3RBmSAfr3DTsZ8Er6I8zzgSi82ZsZraJkb3oS+0pTSG0z+sSSrKtiW98cs1SnZmk8f8uoYq8RQLvfzofeHISesj6+Qeo6YHeC9MI+YrGVIxxQZQhm7WQk0vNgCseiZF+E3W02yJfVfCXKhw2AjzjTVP0N+koIeib7dBdJRZqCbCCorO/Xl0Asa5NWC1iPorMf3iTtmpnPs9q9s3F5HIj35dsIryli6IyIS/4g/MKL8XPuR4sPSUmaQu+odGBT9FcfMDOGsVyAIS/DVeNfKoNGdvlqhWEKs5Y17NnJJ9Kb6/pe8pWyyZemUfvb9Lr+Q+3cgxN8ohdwvVd8jOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BQZ5OxcuxGGRwsg8x801OSGwa9GnNVXFz8qA+yDdbpM=; b=QsKJMP/SqvbAaYHLYv2geDmSM8Md6SjtPNKsf3U61JWKuXAp4yjPmi4qbiuurnzqY0EnUZqw5QDcggWFc0kqO1/cs9ce4q4CNnzC+nkQHUXGMf0xYTK+7IvDfRWWoSLJBPuNWjS2WacvGe24P1GHtnOY2GayPqEnYICvq8PVciiSvR1k6sm9E30ZRO6Jhy+2uxPhyF0GvmHXcmIEl4sQca6EOh3DXbVrY5BWNXQ2Mhpcqq0gYf9w4sRHg9F4qWJ/UWiu9Hnf5ISjHBO2WUNB48hmNLwLLV3Ahm66I9oqtfiC1vYGmsW2tx+8fhOmlLFXyQrLcA0gq2iJJLQOkCRFiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BQZ5OxcuxGGRwsg8x801OSGwa9GnNVXFz8qA+yDdbpM=; b=gWd7SqlMMx8W8SqP59RCINGEFud0zB92hUt6PaEewJkVF/uq9qJHom026L0BLpI0qgfAvbLC7pQRoIrXeytuP8bOivZMtFqIWNfY+NjwrR+4sKKtaebZWGEUuSO2UWwqbZ7CdMomoQ2KYrJ6UZ/c1mXV+n8R6xLy1lpn+ed4kMQQKQXsA2J+8m+w+wJ+ZbjCh6fPjKHTktxcZgSshHkFL1XteocvWGiN6SnDct6rRHsimRVNZaccDflyRyqWOPhv89qhrDh8YTyAB93NOFpPyTmSnLqmFV94lzk2quxb4e1JKS0T+WVG3KTty8ucGmreI6d8g/wOeL5y7l/c81aNjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 12:37:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> <738ca749-2abb-6ab4-db8f-81ff41f4de16@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8848:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c77616f-e029-4bb5-9798-08db18b6f833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZWrMxtrkD7KQHhW3zA9j2FoABZQSe5fFXO6QW9aL/gbvCxOlCe9Zx+8nwh8tzsUfOYJ6kStKUme9OXOzCgrSwVycoXY1OR3tmSaEi4HuZspnY6cBIekfLDQfhYa2A9yx03LDD8ye7vNEMituoK9lubFV5yDG0Nh+2jjts6wUqdihzDwkT6I1QCa2o84xwLGidZnAbmTxAtkoW8ZJbRY1lTwkElKFhj+6pQ0f5QZBSWv1ammihJy/WhbQGjFe7C/yZwLeVQZpUxcNpvzYQpv3f0kJGf/xmyY9hg1u56vaqmMAYJkg4f2sfLFEL39xc6mXS8yKyIEXLEdhfo0MyoV4qen3Gx7t5cHV95FCoDb4MJqRKG2i7ei/EhMbS1LsBjTR6BLVL54YKG7Bf2PR4ZJ9AZYWdOhH0FJCIgJ/b9Yd00OWE3kRLG18Dvrmm6NCv1ZerTviMghI3hwMJyUapMulH6JKFDj4H/WHsQOrb4/lUnBsJAxKQJDhH6b7Nt6AMPVmZWdQ3CqEP34BCbSXlyn7FqNAJNuA5G2Lp9/TCrtsmzVgZC5jYm3IMzoHTabf9UdKNY0rCRWi4AMuvmobDsCrtQOgI4ZK1hGaOYyGHcphpnwGWISeTj70g6M8JuiFAntM1IvB3NEKjZW12sJwq23JGnodQB9rPKyzKQ5W+9VoJbSYxAraEapLjYTb03eCb76rBeUZoYtpsURTnSzU7QqfbUK6XNubIKT6a8x7vi+hTEY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199018)(316002)(31686004)(2906002)(36756003)(5660300002)(8936002)(31696002)(86362001)(53546011)(6506007)(6512007)(66946007)(26005)(66476007)(186003)(8676002)(6916009)(4326008)(54906003)(66556008)(38100700002)(41300700001)(2616005)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFtTnhld3RockhoZmFJcWNONlBMaWVZdFJsSzZvZGd2SnpBeHJreTFuNmhI?= =?utf-8?B?OURsVDNJakl0czh4ek5iNWNRSnNHYjZJQlowLzY1K0ZIWFYxdU41MDRsMVN2?= =?utf-8?B?S1hUREQ4YU84anpva3FGVnM2SWpFbk5XL3lheHIydzk0RjZwaFJrL2hmWXVS?= =?utf-8?B?eXdsSUlTeXRsNnpiRXM5a2RJMDgvWGlJaXVCTWp6M0tqa09ZSnZ5bTJYZXo0?= =?utf-8?B?Yy83Sm5FYUo5S3VkcTFaZ05TRUt0QjNSdXpPdEx6cjNlVk81QW40RktsY29a?= =?utf-8?B?RUN5bmlmQ0hZa3VsVzlnSng0UHh5Z3ZNVEl3bkxsVzYyWUM2cjJ5WUlwZmtl?= =?utf-8?B?bjFJYStGWDE0ZEJHbVo5TjZuVExLMzJEMGlFOHZZdXUrd0IzNGs4U3Z0eXdj?= =?utf-8?B?N3NNQXhZTDVvSWplTU96WHFadkZuTEZoWG51OGxXVzBvbndmb1dDVjJyQ2dO?= =?utf-8?B?ckJyV0tPZkhHbUZCQXJOc0VhV2M5NzVCNmdHSVdDWEY5eWNaeWFjNmIxa2pw?= =?utf-8?B?Vmk2YnlBZi9jMXRlRXo2ckZxZXd0R2NyMFZSeWE2MEkrdTM1YldkemsvUEE5?= =?utf-8?B?SHRHV1AzbHpGSEtraWVkWmx4UlBmWVlOTTNYWm1VRHBIZ1N3SXpIcmNoOWM3?= =?utf-8?B?QWtnWXlETW1HSzBHK21PTXI1S3BNZ1VnRkp5SnJSbVdsWmt4OTJEb2xYaWpq?= =?utf-8?B?TFJGL3gwOVdtWE1XN1cyTVdXKy81cWNNSnRseCt1djZnM2tsak5NSmxubFlP?= =?utf-8?B?WGZwV1Q5UXlEdU92NzBtMk5OSGYyUzB1dW55Qmlpb20wVjNUNEYyU3JsZVVy?= =?utf-8?B?cU00aEdxYm9RaFJQdmhsK0hLTUowNmJDRGhrWFRJRmFkaldDK2NnUFVhai9R?= =?utf-8?B?VzJQZVFmdXppdGU4NjZ0bkhXSEZ2dFhZcVFQMWdydy85Q1lsTXRidGd6VkVX?= =?utf-8?B?ZkhMNnJjN3ZibHprOTFjWllhTlVpY1lzejh5L0dEQ1JYNjlHNWlnOEF5OVhh?= =?utf-8?B?cHBHc1JDQlc2bk13UjcrMFRGRXlYaVVyR1p4RnNGM0w5RFVjWmp0NG1Xeld4?= =?utf-8?B?cmJTZ2EwQ3FZWEJ1bUFreVR3SUh5c1djbE1uRlByaFdsMGpoS21RRUk3YWVh?= =?utf-8?B?YnJIRnBsRUFINTNhaGVDN1ZGZGM4SzZUNFQ3VmwrY1pHbTlUa2dBREliTGlN?= =?utf-8?B?dklTZ3ZTSm03a29SbUJjNzJaMXpSWis2cjFzNmMybEJlSFY4eC9TYmI5RGNY?= =?utf-8?B?MWtwdktzaDlQNEdVOUJCZjNhcDdpUkZxVzBVOVBhaFdVRmVpYXg0a0xSV3ow?= =?utf-8?B?QmZVU2lhVFJmbnZUSFRLc2tXc0VqdkhYR3o5OWRqMzhuYWYrNkgrYlFSanRB?= =?utf-8?B?STRGdEQ1WUNyZkxJT1ZJMFBKeUFKU3pFa1d1QXZ5QXRId3ZuUVF0Q2JGVE9L?= =?utf-8?B?bFBxM0UxV0xiWWZ0VXZDZ2cxYjY5enB6WjZqTG9WZG14NlpQZGVxc0MreGpr?= =?utf-8?B?VWlqdnBsd2gxWDNYUTgyTU1iUkVNQ1h6NmFpTnJuK05vSEFySUp0TDlaNjUw?= =?utf-8?B?QUlyam1YbXJxNlNIVEFPWXVCTE8xbGtPUVArUmI1UU9FeCtvR1NVQXh4RUhq?= =?utf-8?B?c0tGeVF3eDhlN0lBb29vTTUrZVhpQUI2blc5elB0enhITUMxak4rVXVBUnha?= =?utf-8?B?SzMwWHdlallTNXZBb3F0Nk5BR2JkUm5Fa3F1TnVoRUhXM0syb1FuSXFCSzBm?= =?utf-8?B?d0RFQTY4VVBudjF0VGZORjBWVEtodXVFNGIzaitLbkl3TlhpNDNRMXVtOHl6?= =?utf-8?B?dFd4eWRreDY4cHpnclhCWThTZHlSUGxpZGp5ekRmNlVwVnRYSjRqZ0pXTXZY?= =?utf-8?B?SUx5TUluanpvV3RjOUc3RUNMYnIzMzI5NTVkL21kbEVwV0t4YTlLbXdJNCty?= =?utf-8?B?MWl3UFpQdFpCNHVNREZrR0taVG1ZdFk1WVp2a0pBRUg4WXc1N09oREl2dERv?= =?utf-8?B?S1VtclRwMkxUN3VzbWJmd0pQSFJYaDdOeWFBY1BSY3BNaVhmRlVOZVowZEJF?= =?utf-8?B?RDBWNThSZWxRRzRVZys2VGIwZHFHVy9Fc3ZTYldZMUdhaDNBUit1VnIycEFT?= =?utf-8?Q?ZTMI0McTvaTu2XBfOVc3ppILf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c77616f-e029-4bb5-9798-08db18b6f833 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:37:13.1708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bg7laC00IdZ/XXngpECK+vOc1vMi8KkSPORUQMS2tYaK9qKEczlIiuvrkqpwDtOtKOVZC3NFvnO8H6YvTQyXrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8848 On 27.02.2023 12:19, Oleksii wrote: > On Mon, 2023-02-27 at 10:17 +0100, Jan Beulich wrote: >> On 24.02.2023 17:36, Oleksii wrote: >>> On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote: >>>> On 24.02.2023 15:48, Oleksii Kurochko wrote: >>>>> Signed-off-by: Oleksii Kurochko >>>>> --- >>>>>  xen/arch/riscv/setup.c | 12 ++++++++++++ >>>>>  1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c >>>>> index b3f8b10f71..154bf3a0bc 100644 >>>>> --- a/xen/arch/riscv/setup.c >>>>> +++ b/xen/arch/riscv/setup.c >>>>> @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) >>>>>   >>>>>  void __init noreturn start_xen(void) >>>>>  { >>>>> +    /* >>>>> +     * The following things are passed by bootloader: >>>>> +     *   a0 -> hart_id >>>>> +     *   a1 -> dtb_base >>>>> +    */ >>>>> +    register unsigned long hart_id  asm("a0"); >>>>> +    register unsigned long dtb_base asm("a1"); >>>>> + >>>>> +    asm volatile( "mv %0, a0" : "=r" (hart_id) ); >>>>> + >>>>> +    asm volatile( "mv %0, a1" : "=r" (dtb_base) ); >>>> >>>> Are you sure this (a) works and (b) is what you want? You're >>>> inserting >>> Oh, yeah... it should be: >>>   unsigned long hart_id; >>>   unsigned long dtb_base; >> >> As per below - no, I don't think so. I continue to think these want >> to be function parameters. >> >>> I did experiments with 'register' and 'asm()' and after rebase of >>> my >>> internal branches git backed these changes... >>> >>> Sorry for that I have to double check patches next time. >>> >>> It looks like it works only because the variables aren't used >>> anywhere. >>>> "mov a0, a0" and "mov a1, a1". I suppose as long as the two local >>>> variables aren't used further down in the function, the compiler >>>> will >>>> be able to recognize both registers as dead, and hence use them >>>> for >>>> argument passing to later functions that you call. But I would >>>> expect >>>> that to break once you actually consume either of the variables. >>>> >>>> Fundamentally I think this is the kind of thing you want do to in >>>> assembly. However, in the specific case here, can't you simply >>>> have >>>> >>>> void __init noreturn start_xen(unsigned long hard_id, >>>>                                unsigned long dtb_base) >>>> { >>>>     ... >>>> >>>> and all is going to be fine, without any asm()? >>> One of the things that I would like to do is to not use an >>> assembler as >>> much as possible. And as we have C environment ready after a few >>> assembly instructions in head.S I thought it would be OK to do it >>> in C >>> code somewhere at the start so someone/sonething doesn't alter >>> register >>> a0 and a1. >> >> Avoiding assembly code where possible if of course appreciated, >> because >> generally C code is easier to maintain. But of course this can only >> be >> done if things can be expressed correctly. And you need to keep in >> mind >> that asm() statements also are assembly code, just lower volume. >> > Let's get hard_id and dtb_base in head.S and pass them as arguments of > start_xen() function as you mentioned before. Still looks like a misunderstanding to me. Aiui a0 and a1 are the registers to hold first and second function arguments each. If firmware places the two values in these two registers, then start_xen(), with the adjusted declaration, will fit the purpose without any assembly code. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:42:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:42:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502426.774212 (Exim 4.92) (envelope-from ) id 1pWbtC-00058p-0u; Mon, 27 Feb 2023 11:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502426.774212; Mon, 27 Feb 2023 11:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbtB-00058i-Sv; Mon, 27 Feb 2023 11:41:53 +0000 Received: by outflank-mailman (input) for mailman id 502426; Mon, 27 Feb 2023 11:41:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbtB-00058c-A0 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:41:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7d00::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b93ee075-b693-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:41:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 11:41:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:41:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b93ee075-b693-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPnC9nF5hQ5i9twhN/481DN1AuXSkx2NpX11NIW44zIKi19Sq3FBPIoh7xZ54oj31Jw2vT/ew37BrtzjkBJP3uoroCqH6XB7ap/jI30X+mCQCyfRAu6nzHSoEbaVtCnWFfnicdOOJVJhTtt1FcO98Je8MZqKq6dQk0NNPs6f0Em5ISTuS/J6Lk0lI7h1hKaeSGV7sCcdRH/8TrPIfmj7eEYaZHmtaUlDpiqjM2gL729jP7lw7BjSH/EjOhlhQW32GiYX/0ngLFpgPS2qNhUJj9ZBK+RP6jX9Fe9WYXxzS9UPI8W19qJBpO26LRuFwfaNmhSlFWehG2w7HEb9ixIJKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SqyxAaHyjYnZId1R023Dey35QLGxvmBHDMcwCyDHp1c=; b=eKlEA+ro09eywfuztMzH+cCUQ4RWYRCVPpWR2iPmbAxIxK6P4bHoTW7Jz3iz/k2TYUmcQY4uCnwQIntUuHag/NnGSHeKSAQ9s764lzbqEBHl7IHjr7zPQO3FfMYxVKHDiYWsn4IMHwBkcxHb2xMZz07mvSphHjrd715hmrqcHj39p3VFqNUf7M6NI7Ueo/9O2cuku0XqvZRvuutLE28szYElP9QYkFgEBb0gwUgToZnLf1p+4hbxUtvq+9HvoAqIMbEPhqGTvRWKQphxdFoZfap2DAJugGyS38VG2pu58laih1cxVaHacpY4d1x5j8oGqz70CpByKaUI4x+47Qg42g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SqyxAaHyjYnZId1R023Dey35QLGxvmBHDMcwCyDHp1c=; b=Wa4r6A47r8fAxHa0h7aBw/orQgbrRrf1qZIQ/VqM7fPOmc2LYf2buY7i2hMN/CIDWa4QbnriyToisG3big0yC3nVsEWriRnc4VUKXtvq1cIlyo+ThdQIV76F/qExFtNu9SyX56f3IIxYihPTX2vWY/qzbrHu2UIw5Ty83SqpIDpozfGspBviLkB5casoQk1iP+Vxiy2djExdcvEpV6zGGaeNu7GcboZzKHZDndEXbp6mr7WxAYr8MrIxCoxHCFae1I467zMZyDzxnlNzsSEZhk52JRwzrtr6HcawrPqW+i1Llx2itrKC5IKPZvP8FPbp0NZtTlFRTKhDVZ+Bi70BoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 12:41:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] x86/svm: Decouple types in struct nestedsvm Content-Language: en-US To: Andrew Cooper Cc: Xenia Ragiadakou , Xen-devel References: <20230227113533.2848119-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230227113533.2848119-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8633:EE_ X-MS-Office365-Filtering-Correlation-Id: b57f2e1f-21d3-4b2b-96d4-08db18b79c77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LxaaZRzTk0YCBv6aS0Isw+Z4nKw4gRr1pSZfNrgcM/6ww/BnLqSYo1Y6EpdKNFzdhivl475JVLK17j7DbufI/Dbd5H4i57uTUS7xl45LRoXi1vkkpHDt7wlCZD6fqW9CtXyRfzmjQliE1E0INA2hy6CpTaW0CFoQjurLhN5s2pT/U5yPEtr9H6fiyVcE5sSITU6gSrkEyqg8kuTcy9HaBSR3cjNADtSABTreuvDKxmOZrhWMAPeaNnkqKBJqpASLMt+K7B7yLeeCtoPD7VT9svuceSRhtLvI4AvMfuf8srNpnrL6XMpQ3Dl38IYqim8FM2NydfVPz6ZobAUpzXM+uktav3V253MJfK4x4Rwqnv/ysPKYahkMxnsd1XATxmWiYmYNmLS1F6AgwTAID2GKjP+SLoX5syaHETFGfZijWEoqu+ScD/PnLFKB2FtcrKYrRrQzjlyf059I+uOkNHuHjo5a+dSeNeDWmfpsnsOXv6p3uM9sDiPgBvy+VkiKEwN/Nuw9/i9PlGdHwTrMo1xR9sTG24xXruyH5Fjnf3WRZ0yoju3CqTSlKAj5I2cClhyA4aZaOkR0XWZF7LkH4tDqMIbiCWnRetJoPQaPZs4XY+YymgjEFUEiCyaltxB7OHSxTlfl+rCymHQ9fyHgXBM5xp8cTlbj1t8pS8VghYW01HYy4zu+hClvwGE6z+qnchJZBAkfDVjdzGZDaQS1w+OX4NPMqUgVJShWUujr8TfQM+M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199018)(36756003)(6506007)(6512007)(6486002)(53546011)(66476007)(2616005)(26005)(186003)(316002)(54906003)(41300700001)(8676002)(66946007)(4326008)(66556008)(4744005)(2906002)(6916009)(8936002)(38100700002)(86362001)(31696002)(478600001)(5660300002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzZELzlwd0R6ZDlyOW5uY1R0SVZmTHNNMTFQNDhCR2RaQWk3S25IbmhNamV5?= =?utf-8?B?ZXRqNXZkU3p6dEF3M1RBU0hKWitPb2htM2Z2Yy8rMEFseDZpWm81Qjcybmwr?= =?utf-8?B?QXVMQXVlOVFsekhCZ0EyeDd6ZkwycUQwZUpmVk9naVFEclZ0MGZnYnpFOSs1?= =?utf-8?B?SnZoZmJ5NXRBdkk1U2VkRUNLa0V2UmI3MHRiRzdvbEFHNFo3K01RRDZXY25V?= =?utf-8?B?WDI5NFVGQ2NLOXZRK1FJWHY1S2NWUUVvQWkweW9ram1wNW82Slo2ZUVjVWFp?= =?utf-8?B?MFF0UzBBdWp3U05jNzZscG9ibmx6NGpEUEhOWW8zc3J3ZFBEWEdVZC94Q250?= =?utf-8?B?cnBiOW1SQ2E5d0FuQ0ZSdWU1ZncrQ3dGOUhVWW9tdWlUWEprV0MzTWl6Ym5P?= =?utf-8?B?c2RhN1UrSGZFTGNTUGJwRUdyNUJaMlRvbDZaRGhORjVqcVdXV0VRSkU4cThQ?= =?utf-8?B?cWV3NXdlZ1FSU1FicFdYKzQ3ZERISWNLbnhSaWllV0RlRG96WDBJeWtPREpY?= =?utf-8?B?K1JlQS9ZRFNIMk9pQjN1SnArUXJ6SkNoSDRtMXRrWjR5aTJQVEpoYlhuR0Yy?= =?utf-8?B?cTNiTlcvWUN4d3dmMk4rKzFGdkQ3T1k2UzhuVWszWkZJTEVUdnF3cEZXVDNm?= =?utf-8?B?TGRzVjkrT2UvNThFa1d2SFIrc1dDam1KM0dvamZadlBNRWZFWXp2VXkvOGlT?= =?utf-8?B?ZXk1SjZWWk0rZTB3VjMycFJjU25ERkt4VC95S2pxaGtPRWltb0pLbzlvd3Nt?= =?utf-8?B?Mk1yUTQzNldiZ243ZzJNUHlYem1iL2R5ckN5SUd0alBNbnJieFFvcDR2N2JS?= =?utf-8?B?Z0cvTG1yRmRJRG5jQVRXeVNVNnZvSk1ocElsZk5LVWM1dG0ya1Y0RlBkV1hG?= =?utf-8?B?MXdsYVZlNHh6R3FxemdMWHlOZ1lXMlhLbnFjdkUwU3oxcU9CeTVsOGJZQldi?= =?utf-8?B?TUtBSnFLWllBUUxJbXNQN1VSMHQ0clhNcFpRdm50OC8vY1VRcTlHb2pFc1Nh?= =?utf-8?B?SFhaYzZ2azMrMi9UTE44bW85TDNCckZOcmRYbW4ydHdPTTRHRFVVc2xsVWIv?= =?utf-8?B?OFM2YXJnbUN0SFl2WGxPTnhvQ1prN3F3ZmhIdzMvNXFId3lJNlZEcENKN2Ir?= =?utf-8?B?R01ZMW5YWDlCTytzSnZ5K1hicHorVldUMnFoR0ZTbis1UFVzQkZKK2JzNlhB?= =?utf-8?B?RDhhYTNhcFNCb1dFZkJ6NDNSWXVobDBKbWxpVW5nN3Z6WXlMbTM4UkNDeE16?= =?utf-8?B?SXpiOE51TlJkUmdkWW9BcU1oaVh5aGRpd3NXb2JaTG1malNsb2RZdzRzVm82?= =?utf-8?B?aHRsK1d1ZlZGd0Vhd3J3OHBGOUh6OTVvTE9wbUZhYVQ2dElnSGx5cmR6STJ4?= =?utf-8?B?dUpDMWgrbnNLTElwc1FTTEV5Nmhhc1B2SC94SDRWaGR2MmtTYmpnL1NDNHFa?= =?utf-8?B?SU5pbmVLb3F2WjFyaXpkc1JBbkh0RlJKRjlvTnBKUWZUbG91MnVnZzZwQndE?= =?utf-8?B?MDJOUnVPc3IvWlpzdXdUN3lwS0x6SEMwcDJLekQ0aVFPdjFIMjIwa2tNU3ZJ?= =?utf-8?B?aTg0RmN0SE1qYjRRWVpuVXkrZ05SK2lPZkJRUUFZYml0Q0M1T3pjeGRtZ3h0?= =?utf-8?B?MTNtbTRrOEh0YVhGV3d2RWVPL3plMm5Zbnc3L2h1eDJ6M3NUWDRHMkVuYUFO?= =?utf-8?B?TzZpOG92UTBkb01hK0ZuZCtPREtoamhUWHhKREtkL1pXOVdsT0lYdnNTcXd0?= =?utf-8?B?dlBSblg5V0JCbVdZeTBsWXRibENmNnRYclJBRUFNWGt6bXJUOTF5TURnWkIy?= =?utf-8?B?cThJZVVOemtJbTBwTXpHK1JFeitjeGROSGRWYmw0UXhwY29GMTRnZ3N1RWJV?= =?utf-8?B?NjdxVC9DQkIzS25nUDV4NmVtOG1XRXNvUjEyWDJDRk4zaGFkVWZkR0hJT3VS?= =?utf-8?B?REFXdEhYVk1mMWRQU3pCYnF3VVB2N2JkTTQzVnozc0VrOWUybm1oaURwR3o5?= =?utf-8?B?ODNRKzhGWFhZQTlIUU1HbUh1SHNnM0Npd0tZRmdvaXhvUGpVUzltWlRZVTho?= =?utf-8?B?MVZpbVlWTnhqVXhLdjdMVnlBWTl4UnFjUFQxUFZES2pNQTFUNzhDMUZSVGZX?= =?utf-8?Q?J54mnDQ39JVTz0iDMHReuQEd4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b57f2e1f-21d3-4b2b-96d4-08db18b79c77 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:41:48.7315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AcObehTLuoU7/CZYnheGKbIjlTLHzO5gV1K2kirTW5zJhHsqsGrJr2xZwcIPA0IuP/sUvXXc18w3ZEUC9ePQqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 On 27.02.2023 12:35, Andrew Cooper wrote: > struct nestedvm uses mostly plain integer types, except for virt_ext_t which > is a union wrapping two bitfield names. > > However, it turns out that this is a write-only variable. Delete it, allowing > us to drop the include of vmcb.h > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Xenia Ragiadakou > > v2: > * Delete the variable entirely. > > This probably means that nested lbr/vmloadsave is broken, but that wouldn't be > a surprise at all. Well, yes, short of figuring out what's missing this is probably the least bad option: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:45:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:45:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502432.774221 (Exim 4.92) (envelope-from ) id 1pWbwI-0005m5-HK; Mon, 27 Feb 2023 11:45:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502432.774221; Mon, 27 Feb 2023 11:45:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbwI-0005ly-EU; Mon, 27 Feb 2023 11:45:06 +0000 Received: by outflank-mailman (input) for mailman id 502432; Mon, 27 Feb 2023 11:45:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbwH-0005ls-E2 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:45:05 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2ac7008d-b694-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:45:03 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 06:44:59 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6434.namprd03.prod.outlook.com (2603:10b6:806:1c1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 11:44:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 11:44:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ac7008d-b694-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677498303; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=PLYPO+K+PZYmlc4wnkp4s8nj5lDx2gVX19lZzf5OGwY=; b=cUDqKhmFC+HCXiaCAQgTJdfHVlbSqPv3xa2mzcCUzftl5N426dkfIQ0O 1s2l2EN6r278/PL0SPZ+KmwtiyVaCQXMm2QGHPTpi7D2ZQZebVBzR4Ruz gk+jJVRReZi76uzzjbo+M0VOwzNomP7Svf3d4j16JEQiUXVys1tjfU4hs w=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 98051954 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:RI4K+Kw7MYakmBOt1RB6t+cAxyrEfRIJ4+MujC+fZmUNrF6WrkUDy mMaWTyAPfmJNmSkKtp+YYjl/UgD65XdmIU1TQc/qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UwHUMja4mtC5QRkP68T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWBp0 vMoKCIGVzXd3/vpmoD4etld2+12eaEHPKtH0p1h5RfwKK9/BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVIhuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCNpPTezlqpaGhnWLzG9CBxs4cWK1uKGU2wniGMBEM HEtr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLe/hyLD2wDQjleYfQpscY3QXoh0 Vrht8PkA3ljvaOYTVqZ96yItnWiNC4NN2gAaCQYCwwf7LHeTJobixvOSpNpFv6zh9isQDXom WnU/G45mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 RDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:esflJaEV7TzQBXUYpLqE7MeALOsnbusQ8zAXPidKJSC9E/b2qy nKpp8mPHDP5gr5NEtApTnjAtjifZqsz/5ICOAqVN/JMTUO01HYTr2Kg7GSpwHIKmnT8fNcyL clU4UWMqyWMbGit7ee3DWF X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98051954" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXvhfaRGFwBCSHFQiF9YQK4JCXDS97oxchCpVODSDx4ySOD2yphMvle99HMW4Se2r9W0l8gWnl20eO43SAEw05nYvV6piPGUsOfIo43ZG3jxXx8LCwlVyAyRLNBe3r5SC94gRll7Z6JxXXxLzrvVH1tf+UtikFXmMumm1h4y3AHYseOmdVJifSYmSIooYnTEyQd2hQOtv0sTBeMap5IruALJFqeVYD8p66zOOMQlXGXgGh70R29nEeZkEq7NjrG9hUfMdfAMOycICjH8H/cx3cDijylE6dh1gT8jwXYw0ePIrD9AWROLEjrrF+554BY5StmWo4/YTvS226aHmJnISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBw3KyrQmvkshusC9L5CMRs+YOmuvKEumuAIUYK7BYA=; b=AZ8aLExKHVpHOYvAU32GeVwGTnYsKrzsnmXKbXDPLe6SyYP6l7Hztfrhrwg5bAzvLIwYQI5IjnfO1jlTKGF2e+38ANGugRl0UG3mKCeOtm7ylGD7co1lEQH3d0zHOuvy1ufocQeZFqWg1bnylb8Z67dVbA6FYon0QYzN87fzDwTn57ScOcQPxbJbAmU09h88HF6BeKEBPBF9IlNO0yXRALUNIcG29GBvTAnAk3mZVBmeJSYNIEV1U6gTOsubzeiqpvQwDgd9xKBKt6xaliUEDj35gXhWVvo+/1ND98UtecCj7boyw300LPszYQHAAXNZBmBfkGq6eXgzMqHAt8Jxbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBw3KyrQmvkshusC9L5CMRs+YOmuvKEumuAIUYK7BYA=; b=UlIDtDJrQ0HPIHDqUqC+ifQ6pxchOkAQtEvZELv3lLyO8YAGsCs9+ggdQLvZ5zCAOu4NPS4hYhx1rj7QXzC0tG7YNnM7FhHeow7KMMtrsuGEBTpsB0bHvEPx3/EJQXgU1dHEhRCeqx3gc2qtb0Mpb27V/KvQtoaHOWpsTTWMnJo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 27 Feb 2023 11:44:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2] x86/svm: Decouple types in struct nestedsvm Content-Language: en-GB To: Jan Beulich Cc: Xenia Ragiadakou , Xen-devel References: <20230227113533.2848119-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0069.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6434:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e3e497b-fde7-482e-ee7f-08db18b80be6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYls0KK5OraoILXZOmqoAe9BwNpu1HtxaPrZVrpFEDFERjXSXIt20PcHGQBTkD8fQRGo4hZyMumlny0fRqvQrxfCyULKBj97oRXGyI12WtODYny9c/FelFbaCB8u6cACnmvmwUvTNPyOzKEVRr2zlE5RskzS2H3Gr/qV81l8JXbVwVu4feAMytwhJHIk6Jo+ckgMp8XY2cImqyZzglPM4hDA/WmL2bbQXgReNRv6wh386ZKpzsyi9PRryrK7g7PnhDrJ7gDWnkAPzKt7NXgr7GuPTL8jm7HRqSLuxknlEL7ScPaL9gV65gPR6WqBCxhjaoJhBBYJnrw/giz+COuOMJyKTWbzIVLiUNXiCx2WRybZw9h+ZrOZPjL+6PYdT4wHRVPovawDAZVAjPFb3ApSNNR5Za0cEMfb3yHugpKGqJjmww6kyTygyDNwRYHbL0phupBODzCjZfHB5Eitk/9Vhqyoq+lv+u0yMiWzz16I+LPCO1UqNhvJbmhOIeXXoR0Mx4OtUOre2ne6huTndHIbghybs5lA6FIXiwRppIhrILwgJ+3cFC8bryxxOEdcseBgpj3qwPEtMx4wF4j+goCkv4Meil0x7YkQDHxqy9NAPQaGqBQXOfCSqKIgCZ05l16JDaclYRqmTuqntRxKjL+j/7YrseaaURtDRf9Kzur2Dvmaw85eyX6M0Nyx1LkPQzqUuAjRIUO+DhRGtgTxPd/CH7XIrCePYPQ6H/GacON5g00= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(451199018)(66946007)(2616005)(6486002)(86362001)(316002)(66476007)(66556008)(31696002)(36756003)(6666004)(478600001)(6916009)(54906003)(41300700001)(6512007)(53546011)(8676002)(6506007)(186003)(4326008)(26005)(2906002)(82960400001)(31686004)(38100700002)(8936002)(4744005)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFFvKy8rdU1hbkRQODA4WVZ4YkQ2aFJSRWMzQllCbElMRUF4WkFTSHN5NjhV?= =?utf-8?B?TEEzNTFIUTYwMG9zYjJKQk9Jb3VsTmd5cDkwWkMyeng2b3JnS083ZWxBZGk0?= =?utf-8?B?VzJtVmYyUW5tekhNTlNJWHJFQTN4OC9VakFtWlZ1K3VnMzR4ajJiY0FBZ040?= =?utf-8?B?cWxsMElTa0FyUndGTFgwOWE2a2hrb2RVU0FDamVnUTAyZHJhN3MvYjZBOHJO?= =?utf-8?B?blNoN3oyaVBtdUFvL2JtRmRzd1JPQlpabUlRVE94UTRHYzl3UXpZWWxYNm1w?= =?utf-8?B?NkZqRTdFek5jWlVmcSsyckppRVlxa205NnpielpmbmlDTkNYNjVGNEZtRFZV?= =?utf-8?B?WFVlRFVpWittdGQrd1c2TXIxT0hZTnJpQklEaEFpOHJ5aE9qTEhDU2FycGVT?= =?utf-8?B?R2kzQUt4WHAxT2thNk1BQ2VBdVU2UzlpMFlxTlJUSS9XOG9NZEpIQ2IrbVdH?= =?utf-8?B?SHRPelgwQXVmeFcxYW9WbmZFa0FIakZ5NHE5K3d6dTJtMFFJRlhGSDI0VXBa?= =?utf-8?B?NUNNaGgveHdaemtaVnY3TnkvTDF4L1lXNVNHNHRVR255NlVBQVp2OTQ3VDNu?= =?utf-8?B?SmJKR0NyS0ttKzh5QjREWmVXS3FTR2lwcWErQ2UxNjVaWmdlN2c3RnBibVBn?= =?utf-8?B?Um9aK00zdDVUZG1HdXVIOG9vbmZ5QVRrdEVxRkZjOHBmd0toWlloWk5OQnh5?= =?utf-8?B?RURBVXIwVDZ3R1NYUFVpNEVPTTc1QzEwYk91OE9TSFFUZVhxRWJnTWJZcUhF?= =?utf-8?B?bUMxQmREVVBvSTBjdGZQcjVlbklNYTMrcGNCVjZudkpVbGlLMHBYcEZPcVlh?= =?utf-8?B?UkplK0pmREl3RVdLTHJsLzZyWUJISDlMVFdyUGlXOVVJRk9PMWZvaTdkdE1m?= =?utf-8?B?c2RteEVqN1BvbjBGZFhOSWtGTjFhbkJzaXZpOFlza1pxVU1hTy91RVdpdTZX?= =?utf-8?B?djB5TEFDV0NGOGFqeDJiUmo5VW8zbUhVWkJoT2pITGhJeUZ6eWM2T2hEbTBM?= =?utf-8?B?V1ZSaUt2djhPbUdzTG8wdEF6NnovdmxoRTRSMitwdWQyd2RIc2xjS0djOWRy?= =?utf-8?B?Q240Tk9RTWtRMWIzTGRUcEh4bmtYeHpZYU1HVjBjWW9aWmJKeXNYMzNMQnI4?= =?utf-8?B?Zm01cmlxVUYxdGpzc01ISm8xTFdlaks4dmJGNHhCdGJnODFOK1grUFVRYTNQ?= =?utf-8?B?OWtQQ2RVazd2YTFFaG5lcGQwNVljVXhjTmd1Zis2aUtRMnpFUS81Y3JEVUJh?= =?utf-8?B?eGJIQlE3S2RqVGdPMVAvV2tKa0pUZEJ0VzhpTHh3SE8yamNkRXJ4MW40NnFI?= =?utf-8?B?eXRqdndKSXdGanVGSUErZU82ZWdrWHpPODNsY2VqMmxBalE4ejY5SG1UaHBt?= =?utf-8?B?cVQyc2pmVVpRMEFiU3Y0ZXNHNWY5UWpRVDl2VCs2b2R5VHkyN2tZRFJRYnZz?= =?utf-8?B?djgyS2N2eU5BQ2pxN0UzaUV1dXV4UTRpZHdVdWFlUmh4MTkrUmtGZWZSNERI?= =?utf-8?B?Y1pyZEdzbldOV0ZrU1V3NUVaUnQ4K3k3VmFFZnd1NmxlL3Fza1Z0cy9DTVkz?= =?utf-8?B?NGpPWWJTY1ZSN3BUNFNhbXJsNVFzTEp3SnFiRU54WnNLU0UzYnhUaXo2R3hT?= =?utf-8?B?TndYc3hqVWdBamEvaTIvakUzeUk2Ry8xK1dFUnlYVWI3M1FHU3I5Sm9iRGFT?= =?utf-8?B?YjA1MzNXZitLQm1MWTd4bkNLd2lHZmtXblBPRXI0YWFOUFd5NWEvdGhCUWhY?= =?utf-8?B?MmJOQi85TDBIK3Bmak9FdCtxNmRncEpYR0J5MndHWm5ESUcvM3c5UVl6Yk1Z?= =?utf-8?B?UnFVcUJKdFRLK2YyN2lHc2FwVHF5WEdPQnlabk1CR2xlSnltUDFXRUpxZ0o3?= =?utf-8?B?UnJ0T2VwbjA1MzltdmtCQm4xSUxmc0lIZ3JQTjRoUEFmN3Q5UDNHZG9ZT0NR?= =?utf-8?B?UjMwYU96UTVLMEhzM1FlRUdPR293K3g3dDRDUzNHd1NTdzRWT1pIMEIvK0Nk?= =?utf-8?B?elBDSjN6RzdlTWZkWGNQZE03MGVNYmNuemZQcWNFWWptZXk5Q3ZBMU5jeU5M?= =?utf-8?B?RS9XbEt4TlFnNDBZdUU0dTRpRVZnRnJVOGh6NjY1cmVWczZwdVpWVmtMb3hz?= =?utf-8?B?TmJqL0lMZUkvNWpTcWgweXdocXViT3lIRDZueWNoZ2EyRzRwWHNwcEVFOEdi?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TzaATgD+LwEAx9SqxlBhrATYl/F8+dkjLOuJcyUEXKs84LvdUpvqIb47CkDpxST5fnn9vDDaGePLNa79UTDFuxUIKX/cudYicQ31PCCJtoNEuqzhkVvGy7mXCLqJuhNaMsLQc64JLzHgyS/RnlJDf0lP/I7MFyyPFVmq1KiG9wyLN//yUuWAPCdl+NboDBms+iQwi/qbDp4LJ4wueow0EM7WxwQ9mTJHNggRwtVdlopaTbWjKUgpfEOXUfPLIIL5YIV5KYqYkfovFSvLJWRsewKhmyKs5dx5eAaV0wMtKVOUKBhk947nuWisU8lFPsM2DYachrK1QKE2f3Bnt/5qek80NTO05mkIx/SigvGG+xckZBDpQcyLnY3hWUaPDfuDE5qHudLL0BBpsYv5Ri64vvyBqmmZP2MwzimEKAmQHqOVWiKuauM3ZadI71wiFOZNMQ4LDuxSnQi5JGPveKcq6Doj45Nifle2JfXTrGr8HFqghCEYhjsWzU4pR4TG4ycB6R8N/f78g+c5AWoUAi+zz7jHbH2UZrCA0P/+ty3n/3xXZqzX6F87uaPZYgnwFsV62ilQcu+l6CVXifpWIN2GC5Hub4nd5iN0ETGfG5o5cwDmEpHKgdpglDl4EKbm+avJeH/KSSaEU+GhZUWF7sXkO2w4tjpTNoNHOY0afX0zbmzxkwLsAAIxjS5YS9lInWNjbinWuQ4tkJPuvzDfKuunTqmHa88PuFtYHUDqtiYo2xu7UfyMsyYCBV/gwUseT1DRzPPwseyubSUrMp+IRSQzQx4X1ymT48qWX0RXZVts5T8EdTaR5bo2yfKIPh1ChQ04/mNkthWm4WPJp/W1OlKBqg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e3e497b-fde7-482e-ee7f-08db18b80be6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 11:44:55.8133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LTyO2RelGqy5wPybUXLJZu84BO2idijxPagbQGTTT0yqtT0NjfQiT5SXbNnyzY4WgJM38LB9FS5xRHI+eCSFQFAJDGwqRe2HSSFa2Yf+Q3M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6434 On 27/02/2023 11:41 am, Jan Beulich wrote: > On 27.02.2023 12:35, Andrew Cooper wrote: >> struct nestedvm uses mostly plain integer types, except for virt_ext_t which >> is a union wrapping two bitfield names. >> >> However, it turns out that this is a write-only variable. Delete it, allowing >> us to drop the include of vmcb.h >> >> Signed-off-by: Andrew Cooper >> --- >> CC: Jan Beulich >> CC: Xenia Ragiadakou >> >> v2: >> * Delete the variable entirely. >> >> This probably means that nested lbr/vmloadsave is broken, but that wouldn't be >> a surprise at all. > Well, yes, short of figuring out what's missing this is probably the least > bad option: > Reviewed-by: Jan Beulich Thanks. I'm pretty certain a working version of nested virt won't need this cached information like this at all.  I'm pretty sure it's buggy not to be referencing the appropriate one of the 3 relevant VMCBs. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:47:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:47:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502436.774231 (Exim 4.92) (envelope-from ) id 1pWbyt-0006N9-Ul; Mon, 27 Feb 2023 11:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502436.774231; Mon, 27 Feb 2023 11:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbyt-0006N2-S0; Mon, 27 Feb 2023 11:47:47 +0000 Received: by outflank-mailman (input) for mailman id 502436; Mon, 27 Feb 2023 11:47:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWbys-0006Mv-7e for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:47:46 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b18b0c3-b694-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 12:47:43 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 04F925C0113 for ; Mon, 27 Feb 2023 06:47:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 27 Feb 2023 06:47:42 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 27 Feb 2023 06:47:40 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b18b0c3-b694-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1677498462; x=1677584862; bh=yV4MrXXUxU 9IU8DWFk78q7mVFHt7RwX9jjJngnV2xlk=; b=jf95fAWQqAG9eEShUWQAa17MGt vXN8QutZtU9JT42u8xrWnUZUe8hyufFJl6vuRCZWiYgvz/rKCqEPBEkQ1uFs4Akb zVXAXEjZ/KWJ57IsTlqgl5LxxBSPBiCwTduLbfargdmGt6Vgz+djEl7jMpOI2uMb wZ7Df3p8fV4upGUKaIM2wfZ4WNuRCihiP0HHVka8CDLyCtrKO6AVVHc/aECa4YVP TXlRuNReuMxpY1GcztS6jPv5+uVb4euNH0dLWEWKqm9dpqhiIUaCobqoOq/6UN+I fY08zQ5glwcvUDYwxKdvuxtaCw9sJg57h6G45y5OtGbo71vmqx73C2ecBnuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677498462; x= 1677584862; bh=yV4MrXXUxU9IU8DWFk78q7mVFHt7RwX9jjJngnV2xlk=; b=c IkW0A7ZcD/KJHDq1nhzEkqkZDvWShbr+OjqU9z3mFxDqfNoBe56ofxnfiEs/CaAn AAM4JVPXQLCCi/9H8IbHJ1VIQiaKhS8C5tbInbmBxo7OAnKJvghOf3f/lP5eGu2L Al+oeUcesnhzcgMMK6M5jRHbiSGUKdt1l/zem1/8eN0ZkGW808ras+veuGOZ+Dn5 Mz8nX2G/C0RyCuORAKGX9yt6VaOb01tf55rBmFGe9UYpXQ5GToqhmj9n/hGsY5h1 17HkY92TUIHA1ArCSkwPmijpd0tl2+E9rPxlW5b8YY2/iWLPXASYrrXbgOPeTEuZ 8vOXMJfCLagetGRCHm2gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeltddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggvffhufgtsehgtderredttd ejnecuhfhrohhmpefuihhmohhnucfirghishgvrhcuoehsihhmohhnsehinhhvihhsihgs lhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepfedvfedtueevve euffekueekheefgfetgfekgfevvefhteetieejieevledutefhnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhimhhonhesihhnvhhishhisg hlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <9051e484-b128-715a-9253-48af8e47bb9d@invisiblethingslab.com> Date: Mon, 27 Feb 2023 12:48:03 +0100 MIME-Version: 1.0 Content-Language: en-US To: xen-devel From: Simon Gaiser Subject: S0ix support in Xen Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------QrAJXv57Ra6xEPnOyKXrq10Q" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------QrAJXv57Ra6xEPnOyKXrq10Q Content-Type: multipart/mixed; boundary="------------GnLahEIS1gQSpvTceurb00Oy"; protected-headers="v1" From: Simon Gaiser To: xen-devel Message-ID: <9051e484-b128-715a-9253-48af8e47bb9d@invisiblethingslab.com> Subject: S0ix support in Xen --------------GnLahEIS1gQSpvTceurb00Oy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I have been looking into using S0ix with Xen. On systems with with 11th gen (Tiger Lake) Intel mobile CPUs or newer this is often the only supported suspend method, thus we want to support it in Qubes OS. Below a summary of my current understanding of what's needed (and known unknowns). I would appreciate some feedback (what's missing, preferred solutions, etc.). Note this topic is much above my previous experience with Xen and x86 power management internals, so sorry if I'm missing things that are obvious to you. PIT timer: During some previous private discussion it was mentioned that the PIT timer that Xen initializes for IO-APIC testing prevents S0ix residency and therefore that part needs to be reworked. But if I'm reading the current code correctly Xen can already use the HPET timer instead, either with an automatic fallback if PIT is unavailable or by forcing it via hpet=3Dlegacy-replacement=3D1. Looking at the rest I think= the PIT isn't used if Xen finds another clocksource. Did I miss something? mwait idle driver: While mwait-idle.c share a lot of code with Linux's intel_idle.c and the imported code seems to have been updated (for example for Alder Lake) it only supports the CPUs with hardcoded cstates. Linux's code also has a code path to read the cstate config from ACPI if the driver doesn't has a hard coded config for the model. This is needed for example for Tiger Lake. For my current testing I added the values the Linux code reads from ACPI by hand. But that's of course no proper solution. How should this be handled in Xen (IIUC some ACPI things are handled by Xen and some by dom0)? The debugging code in xen/arch/x86/acpi/cpu_idle.c (and maybe other places) need to learn about deeper package C states, for example for Tiger Lake. In general having the power management debugging available that you have under plain Linux through /sys/kernel/debug/pmc_core, etc. would be nice. Some things are as easy as allowing some dom0 to read some MSRs. But didn't looked into it further, some functions might also be required more complex integration (like extending xenpm's functionality). I'm not sure yet is what else in Xen needs to learn about S0ix. Running domains need to be halted, that can be handled by the toolstack. What other Xen internal things need to be aware of S0ix? Like avoiding unnecessary timer wakeups or similar. That's currently my biggest unknown and it would be great if someone with more insight and overview could give some hints here. On my test system (NUC11TNHi5, Tiger Lake) I haven't seen it reaching cstates lower PC7 with Xen (so it can of course not reach S0ix residency). With plain Linux I got it working on that system although it was rather fiddly and probably something is fishy on the firmware side. After seeing it very occasionally not working under plain Linux I have installed a newer firmware version. With that Xen currently doesn't wake up after triggering s2idle in dom0. I'm currently looking into that and will follow up if I have more details on that part. Thanks, Simon --------------GnLahEIS1gQSpvTceurb00Oy-- --------------QrAJXv57Ra6xEPnOyKXrq10Q Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmP8mHUACgkQkO9xfO/x ly+OTw//Ttuj24tsus8Vf2WApd6pfTZtp2AfbMwl5OmmvAz85tUaxmocrLNBnAPd yu3QtPj2HzFPk3mneV/798S/LaoRz0P6k0sO/30cNabd3Jl3wz7MmlBb+06NK/33 hIYWO1uQe4DfN1DWy5gWZkKZz2wSbvQeTXMPF7ANlRb478Na0GCA1d02JOFWJoLk jB5RcFk4a30rmM/I7MUsO9uinfAj+nc+h7Hu5L8s7Y/etVhjbg3RE2Mjp9Y87fID Kb80XMHFs8BMZSmyV0pRNthMx09Zwv20O89rooqy8WbdrU6IVPjjyxPVUVax3DvQ nRZREwO1ib5TTn9IsiWPe87I1OG8/QRilmFQBdHqIfPlf9S7o+K4fR1hSqOlv2DM rnnCyFwntE6UPpvKwnhFS/gT7EavMk7o/yhCrQ3eDSJf7hA9D8/j/NrIK8EfKC0P AFSnoT/BKNLXzPIUhsBqvqvHAwqbnwcRoTkX5eoyUvXDeRkVlmARdl0BHvqclfum 0Ik5XNNiIoyZwUtT8iVjjsgP9dbC9C15mNlLtbeNYKwZ2/Vm+zldYfOdMhniajay 2tJw1yJaPokYaTC0Mmfbx66P6x7u5fDFst5hCWTQ51jEBFsT/2CP5kyzWr8Vj+XU X8bU5vu6G5jrzV2plOjBgqyxpjukCrDw4tk9yagM+90+SF5JDQ8= =fmDO -----END PGP SIGNATURE----- --------------QrAJXv57Ra6xEPnOyKXrq10Q-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 11:50:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 11:50:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502442.774241 (Exim 4.92) (envelope-from ) id 1pWc1P-00084m-As; Mon, 27 Feb 2023 11:50:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502442.774241; Mon, 27 Feb 2023 11:50:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWc1P-00084f-89; Mon, 27 Feb 2023 11:50:23 +0000 Received: by outflank-mailman (input) for mailman id 502442; Mon, 27 Feb 2023 11:50:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWc1O-00084V-2i for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 11:50:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e90da18f-b694-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 12:50:20 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611--S0vocKJPE6OuEDYgPwYzA-1; Mon, 27 Feb 2023 06:50:16 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A983185CBE0; Mon, 27 Feb 2023 11:50:15 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47033140EBF4; Mon, 27 Feb 2023 11:50:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e90da18f-b694-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677498619; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dygdNjOBh/f7cSHZKBYj9epAgNeJlw1ARAk1Xkm8Jpw=; b=BJvDBHl5jl4W0s+HI0NSbot4kwCEUIHj6X4i/7CrDZEkEiXrFHBkTgEBJIVy1iPqeN0AL5 ajygKRH1pIeI8A86M1VYCzV5zjQ7p5ZBZ6nEYAC10zZCve7ee54vk8Tb0EIGwaGrQ6OW2x T1vLRf6fToDMPuUHG1jSc0ltbNmZZzI= X-MC-Unique: -S0vocKJPE6OuEDYgPwYzA-1 Date: Mon, 27 Feb 2023 11:50:07 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230227111050.54083-2-thuth@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote: > Hardly anybody still uses 32-bit x86 hosts today, so we should > start deprecating them to finally have less test efforts. > With regards to 32-bit KVM support in the x86 Linux kernel, > the developers confirmed that they do not need a recent > qemu-system-i386 binary here: > > https://lore.kernel.org/kvm/Y%2ffkTs5ajFy0hP1U@google.com/ > > Signed-off-by: Thomas Huth > --- > docs/about/deprecated.rst | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 15084f7bea..98517f5187 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -196,6 +196,19 @@ CI coverage support may bitrot away before the deprecation process > completes. The little endian variants of MIPS (both 32 and 64 bit) are > still a supported host architecture. > > +32-bit x86 hosts and ``qemu-system-i386`` (since 8.0) > +''''''''''''''''''''''''''''''''''''''''''''''''''''' > + > +Testing 32-bit x86 host OS support takes a lot of precious time during the > +QEMU contiguous integration tests, and considering that most OS vendors > +stopped shipping 32-bit variants of their x86 OS distributions and most > +x86 hardware from the past >10 years is capable of 64-bit, keeping the > +32-bit support alive is an inadequate burden for the QEMU project. Thus > +QEMU will soon drop the support for 32-bit x86 host systems and the > +``qemu-system-i386`` binary. Use ``qemu-system-x86_64`` (which is a proper > +superset of ``qemu-system-i386``) on a 64-bit host machine instead. I feel like we should have separate deprecation entries for the i686 host support, and for qemu-system-i386 emulator binary, as although they're related they are independant features with differing impact. eg removing qemu-system-i386 affects all host architectures, not merely 32-bit x86 host, so I think we can explain the impact more clearly if we separate them. How about something like.... 32-bit x86 hosts '''''''''''''''' Support for 32-bit x86 host deployments is increasingly uncommon in mainstream Linux distributions given the widespread availability of 64-bit x86 hardware. The QEMU project no longer considers 32-bit x86 support to be an effective use of its limited resources, and thus intends to discontinue it. Current users of QEMU on 32-bit x86 hosts should either continue using existing releases of QEMU, with the caveat that they will no longer get security fixes, or migrate to a 64-bit platform which remains capable of running 32-bit guests if needed. ``qemu-system-i386`` binary removal ''''''''''''''''''''''''''''''''''' The ``qemu-system-x86_64`` binary can be used to run 32-bit guests by selecting a 32-bit CPU model, including KVM support on x86_64 hosts. Once support for the 32-bit x86 host platform is discontinued, the ``qemu-system-i386`` binary will be redundant. Current users are recommended to reconfigure their systems to use the ``qemu-system-x86_64`` binary. Same point for the next patch about 32-bit arm vs qemu-system-arm binary. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:07:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502449.774251 (Exim 4.92) (envelope-from ) id 1pWcHm-0001ci-Sd; Mon, 27 Feb 2023 12:07:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502449.774251; Mon, 27 Feb 2023 12:07:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcHm-0001cb-Pk; Mon, 27 Feb 2023 12:07:18 +0000 Received: by outflank-mailman (input) for mailman id 502449; Mon, 27 Feb 2023 12:07:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcHl-0001cV-Oz for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:07:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45840c19-b697-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:07:15 +0100 (CET) Received: from mail-dm6nam10lp2107.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 07:07:06 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB4966.namprd03.prod.outlook.com (2603:10b6:a03:1eb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:07:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:07:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45840c19-b697-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677499635; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=S/P61n0rVmytk8bPQrEsRCkW6IAaRnRdSI2H7puELhI=; b=EDz0WvsuirdbrwLHP4l7OWwEDFMJ9Q/JY6q7KvXReFxyn4pGAOfYYn2d 47iI4F1vm3jeklKMnSPXMhdIDV9chghBCXLB0TtTUHUgp0aFnkFRC7NE1 8v1GFERja3JuAy1Ly7nglUkxfOKHX4BWnci6fcQSvuwsx/QsJmTBzUeTL k=; X-IronPort-RemoteIP: 104.47.58.107 X-IronPort-MID: 98054114 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:i/eQDq+fspG6LMs4dXy1DrUDaX+TJUtcMsCJ2f8bNWPcYEJGY0x3m mpJCG+AMvaMa2qgfd4iaN+y9UkGvpDcmIRrHVM9rX08E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oU5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklSr ac9IR0IVimKiri0+recUtNmlv0aeZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdJKSeHhr6ICbFu7mlU0JRgYFkOAqNqdhVySAfQYN k0q9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOttIwAzoj1 VaLntbgLT1prLCRD3ma89+8rj6sOC5TMW4LYwcFSxcI55/op4RbphjSVMRqFKm5icL8MT71y jGO6iM5gt07ncMNkqm2413DqzatvYTSCB444B3NWWCo5R8/Y5SqD7FE8nDe5PdEaYqcEF+Iu SFcn9DEtbhRS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysIjHOPFBNGtZNKXr8= IronPort-HdrOrdr: A9a23:QpM/jqjCWBcOT/ilq8ga/GwECnBQXxl23DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3IwerwRZVoMkmsiaKdgLNhd4tKOTON2VdAQ7sSlLcKrweQeREWs9Qtr5 uIEJIOReEYb2IK9foSiTPQe71MoKjlzEnrv5ak854Hd3APV0gU1XYeNu/tKDwQeOApP+tdKL Osou584xawc3Ueacq2QlEDQuj4vtXO0L72fBIcABYjyQ+WyRel8qTzHRS01goXF2on+8ZszU H11yjCoomzufCyzRHRk0fV8pRtgdPkjvdTGcCWjcARCzP0ziKlfp5oVbGutC085Muv9FEput /RpApIBbU+11rhOkWO5Tf90Qjp1zgjr1X4z0WDvHflqcvlABonFston+tiA1rkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooEAljfUYgxVkIMsjgf5q3M8iFXFuYdI99RHBmcQa+S 5VfYbhDcNtABGnhrbizy9SKZKXLy0O91y9Mzc/U4SuokZrdTZCvgUl7f1ap2wH8p0lTZlC+q DrDoRE/Ys+FPM+XOZFH+EGTtKwCmvRBTT2EEzXD2jGOcg8SinwQ7ie2sRp2AmnFaZ4vacaid DPVkhVunU1fF+rAcqS3IdT+hSIW2mlWy/xo/surqSRl4eMM4YDCxfzPmwGgo+lubESE8fbU/ G8NNZfBOLiN3LnHcJM0xflU5dfJHECWIlN0+xLEG6ms4bOMMnnp+bbePHcKP7kFislQHr2Bj 8GUCLoLMtN40i3UjvzgQTXWXnqZkvjlKgAWJTy7qwW0swAJ4dMug8ahRCw4dyKMyRLtugscE 53MNrc49eGTKmNjBP1BklSS2hg5xxukcXdultx1Hw3GlKxdrofodeYYGwX3HycPxN0Us/aeT Qv/2hKxQ== X-IronPort-AV: E=Sophos;i="5.97,331,1669093200"; d="scan'208";a="98054114" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8U43ObtPwQWrVA+SadAFJh/AoXoPE3vebIeHCA/euoVbPQgSbv+SQwIniATuLoXHwJdfnlO0VOBFT0aUODVLrGlMb721vbR1NWci1a5ryDztqks7BxdORg8FjpUErrfi35yXig4B0Yu+aWBPYRubB/9/APK8n7NJ9ox10u1SbaufauAyzO/huB7TkKniKrl2WIVG0kGiq6oqpFXzFU3SVKAEawS22M/F8hgU/xgbMryKGlU3jVxQtdgsp4VpVLCDSFWWf4Ju0U1R5qxXyvUmdI8PMEC6wI75V9MJ8PZWlTzwexr4bTCniD+0M5O32yndZmT9ZK5PgSRXf8n6XGx3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/P61n0rVmytk8bPQrEsRCkW6IAaRnRdSI2H7puELhI=; b=D324dFMBubcEDVU2p4P0lcElXa0LJpvaHYQJVrNzIJx1IrXhg9Trrwx+lgi5ntx84Jk5TWcI6r9gphyGbC/P2KEsN4u+/ciRV16F6MF2tABuPaxPKu7xl9Ba6mne7MjNVraviim4nEiDYgsjeqTxuFaeNUw29McUGUw3xMtOGBb37d/3g0bYbnv7qGzSXFpygR3dyXjLTMR5PzmpK6O+32+4GKKg3C6MAP8mYWxQ4u09lmnLE5vtgk4Nzw01VAAcgbDZ1eAP899+cVbDBCRwXf52GuX4JNcgXr5DKfygaTcQxgOUttIoRDwf7LemIMZY02S1kaeYNvm9HKJ87NMbxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/P61n0rVmytk8bPQrEsRCkW6IAaRnRdSI2H7puELhI=; b=uuzIUTcSDLQWGt6ChMTTq/v4ONxXRqQ65IweoXkJOC765IgF0qeQGUdo3mxm2QSN9nhRVw2O3zbECyD0v2ff6Ducv21jFJ5j1vOru01u7Nng01/YMN/NJ06o5JUnzRpuM8dJR5/FjpPOIrwoR9DnC6wCuP+XJOS4m6jPocuKiOw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <18b9b99e-1d93-73d8-f9b8-873f44287c5c@citrix.com> Date: Mon, 27 Feb 2023 12:06:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> In-Reply-To: <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P265CA0026.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB4966:EE_ X-MS-Office365-Filtering-Correlation-Id: 67fb5561-cbef-425b-c64e-08db18bb22b4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p6kOMV+KjwfnZXcnbtkTZUTnSNSev2DrWQWZBzTXdZ1SzLqo4gul/hLaQFYo791bNTAYSw0Y88dM6/mcpL0BjA/R29YL9du/AtPmB3n8+O+869rXJT1L+ige6orynC4uK0Npe5u7ToBxWLpRXCJV0xz90TUhd/NyEVKGhTjQmI7hzBQ49n4vAmOQI6Gx2SRrp0U8Kiv7SclmjXrS633LvZKU+UEdCTu65NC9tJVRf+8mYFiW49dg0jICnKs9s5maLoC5CSydNVugfrUx0Mm7WQyJSCJDnaSRIj+0w4lZIbvg+nLLRVE//pxiLcWGEs2ZuFZGXzHl//5HCfMbh3II1GDlUZqHvbATEhlt9jbM/o6EC1OyJRc1NRei1Of2UA9lypiAZVmikQYxRjeAn+IYTjVcg6TvZ4iSRdulrJdECfmg4cnGaIcfTIrmGdSOqHgq4Uguy9y12SZp0ga3DuFNTztKNA6rbb7MmE1d2MZ1naGdymjKlZUlTPkil+fO2UCz9g46tA545yu6C3zZzZ/KmKkRjWmvS+2a5jOq8MsKGd9/dYAmZF6E6WNN0ID1kc17wFGYTO/scMBCpRJREXkNgaYirRRunL4NKzPZxDtZ7DxjjKrPfkfI5R6YrKdZm6/iicwGowxyTGUrXJqHTFxBsU6iB27Y49tCZfgaxDtbohO8mPQLksRpaE2etPvypTaTgvUesd3nLMLExwWtkYc5Kr3ALOwR3jL0ZIDFGpGJnB0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199018)(66946007)(2616005)(6486002)(86362001)(316002)(66476007)(66556008)(31696002)(36756003)(6666004)(478600001)(54906003)(41300700001)(6506007)(53546011)(8676002)(6512007)(26005)(6916009)(186003)(4326008)(2906002)(82960400001)(31686004)(38100700002)(8936002)(66899018)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmtxREd1TW9zd09VNGJDMWM3VlVzWkErdTFyZkZKdFhFakx6U0YwV1VmUk91?= =?utf-8?B?NjZCMzVjdWhSSi8vcmdNZTFQaEVZblR0ZjZEVktLRTVtamhFUk9SWUNDZGtI?= =?utf-8?B?VCs5WE4zZVFJRzMzcUY4YzVCbzlJZUQySDh6M2s0elBvV1lyS3NRbHBObVNJ?= =?utf-8?B?UTF0MUx2dHd2ZXY5anVoVXZKeVArUkMwdytLRk9FMHd1b1dDb3ZuampDRm5r?= =?utf-8?B?aExFS2w4WEorS1JyTm9LZ2I0WFZDa2NLNVI0WEVXd016ZEpLdmxVT3UzS1hY?= =?utf-8?B?YWt0WXJvN2Uzb2o5S2MvYk82ZW1WcUZCemY1L1hXbWJHaml6UVdYeU1ZVmxO?= =?utf-8?B?TDc5QVh0RUVvbzcrUWxGNGNIUC9VUU1ZbGtic0ZFVVdUdUVzUHo4Q2J5Sm04?= =?utf-8?B?aCtwbnNuMnQrT04zRzdJUGVRZXZoZS9vbk94Vk9YRlpVTHFiSzc4Zk0yc1dT?= =?utf-8?B?eTBnbmQ1TmZaaXZDa3M2Y0V4VEhPaVNhRVMwY1owZTF2TXBxUDM5K1RqNnNa?= =?utf-8?B?U0FUMlg1L1RZVk1ZVDlMK3prMWt3NUpTeWVKNzJma2w3OHlodHRKN3V2Vm9G?= =?utf-8?B?Ui85dVpta0p5N2lWOEhFUmtJeDdwUDBmTjlJY2JPZ3VDMW54b1Nsd1VtaUR4?= =?utf-8?B?Q053TjU3NGNLR1dDczdvRDJMVTRReGFuTzB3NElZaXRJekxpbklzQU5zMFQz?= =?utf-8?B?MUJadEJUK2h0T0ltR25Tb0hCMGxrVHJZclo5RWFhS25ialJwYmdRRWsxaDFS?= =?utf-8?B?aXR5Z1pLcWZyYm4xMllWZE5XYzZQTVlzNm1yMWZXMFZtRTh5SkZrYUtZQXlF?= =?utf-8?B?SUlvcnQ2R1hUOWNTTzE2TmZ5UDVaWWpmcHQ1RHJXQTVkUW5aWFVUZFlLUEZJ?= =?utf-8?B?OW9EZzdTZWFtNzlNWlZ4ekc1RlprbG1aSGZQSHRXd0RJaVRVZnczOHlPZVVs?= =?utf-8?B?Tkpjb1A0QVJsNDRwa0s0TVJUeWdqZWJzQ2R4aVNUNXVGY2tnaEtsSVIrNnU5?= =?utf-8?B?cHhVUDYvSDZTbHlTcDBQRkNRUFlRK09BL1lyTXR4cTVvUDArRUZvQURsSnVi?= =?utf-8?B?R3Y4M1Y0MTFNNFVsa3lJdE1zdWs4ZXNwWExrZm1zMk5TeEFFUmFiRFpsVmJI?= =?utf-8?B?eUt1dHFlOTZmVlVOS1dvaWgxVnNYaGQyWWhsT0tHdkRObGVnRlJSVzEyaldk?= =?utf-8?B?bTBrb2UwRG9YOUpoN29QUXJVRGZzbFg0N09zV3BJR1AzSWwrb0llZmdrcjFy?= =?utf-8?B?NDZncVlXaTcxaDJ0Q25HUFFUcUZaSUtQVzVxbHFXb1doYTkzNzFHbHg2bllr?= =?utf-8?B?QkpqMHc4M3hYajdHckdqejEzendXTUpHWk93MVJVb1ZWQW04dHdvVWF5TkFj?= =?utf-8?B?Wk56VDlwa3BQYXM5WmNEUFUwcDBWd0lRZjZ1dWxhL0xwU2g5L3dZQmZFT3Z6?= =?utf-8?B?RnF4Vy8raXZXSWl6cksrUnFFMkUzdFNDc0ozTlJ4T0h6R1QvM21kSmE2bTNP?= =?utf-8?B?ZWxqN3YrL09uM3U2c1pERTFkWmM0T1MxOFIrUFIra0p1YmFzV3NVOTN5cUlr?= =?utf-8?B?YlFDMk1MWEpQVmpPT2R4aWR0eUZ3MUFONHdKUEFFTkpkR0p4YjBMZWpUVFZz?= =?utf-8?B?N1dJWFBteU04VmdBMkhmS3BjR05DNzV1aDVacGxWUWRkQnZxZlBSVEtPMjBF?= =?utf-8?B?YTFvNjFacmF0MXFPbFZCbHNRZHBJdThHZXlJVGZCdndSV3BCVzhCOVBGblNG?= =?utf-8?B?THIrSEVUdGxzVmpjN0NkcWljZWgzbmw0ZHpiazNSR3V1cVdBM0Q4L0pCWGtr?= =?utf-8?B?NHhHQ1l5SEZDTnVvZVFiSWplTTJjKzRJeXh2dVFHTzZxbTdBZERhYTRrUng1?= =?utf-8?B?Nmpkd0ZhaFdGM2hEOWNyb2VZaDdFd2prV2wwL09ETmFOZUpPOVRybDRZK2ky?= =?utf-8?B?aXJnZ1BMNHQrdEtIOEo1cnZjVXlwQURMdTRYZjhNV3pFWGZ1KzZYeTFjOTNp?= =?utf-8?B?U01qbXlNc2hid0luamFGVEdwN1kyaEl6V0NObUlvL1VYdUZ0azhWOFhLT3RM?= =?utf-8?B?WmlsQmlqT09RZ0dyZFNVWnNFUUVWc2krRjl4dGhuT2JINHBvUEllaC9TY2hS?= =?utf-8?B?ZWhRR2p4cUdQU0NqRjI1d3FlV2t4eXg1Tk9GZDZtRlh4Y3ZPcTg5Vmh3WWtl?= =?utf-8?B?OHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IxE6xtHXHB/aMVFIsrq3Z4PMSzec1tG2+cyKS1sXNhPCaOltjV6J85NK1JrL8wBrh4jAeMoWcsGzYyhiEi71cJCxpmlwGC4XqIdWCN7UJheU0lAjysMt+EbhceS55QA1MDOBINbr8sBcUSRm2X76vZdXYf5Q7z3VUd/i/GUZ8YAXIbfMBNmfBI5vurlXzoeD9mvWxgYj5TDWU+BxrEXgcIVe8OXKSg/Tod6FjfRspnN0/ehb88uMBLTB0n1zfcDa5JiQMmpF6UMFae+YWaNuUCG/T3uU0CBU2MzdVMOq2OhpBChXKFDP0xAGeVJSuaDPQpr47vbmmqFYfR0wYihjMx9uGGrqJA7t9mQfFZ8gHSVFq8Zs6B33u5ilmzsbW7s9PSYpJ0iH3jLW3RaxTECnvuwaW0ow8Ps7297HeoGGiPggUDBC9G8vbUnBH//aDIl+meziWiJTx3E0DLwL4xb3ATDag6BL1D+Fvkbs+wzt4PGoS5pN2VO0BM6joS6v2uxkydS7II5SknE+OskOqHTaKQ9rBz9ZkJDYXgGCFC4+YS4TAQ62oRkhyOt05DvFJmLy+Y9aY1YPNbe8NJAQuMAOr2wT0tbHPGEwMjpPsYYKOm3GJ4qvStWh2EL4iZsa6VXmsWf4QnOrsPUTRxCWjf++JgI8fWZuvKDYmRI/duUxEZpk49zGDeMy85A34GYFt5fKYZaX9tUBLvLhSBcZB3ZKNa77/kkXwuEBJ872yAth2OLWP223QZHtn+WF+JSXmdu2ku7voiDl0W7VyLfwsRbKMzgqtn59UtphGL/hXbnXVVR3LG3g3G0ZPPTc1U9lk/IpymU0OVXHCEXQziiyVfXo1G+Th7ooNRKx1KNZq07rKm8SPbfhVC1ZYO4/kAem4/cZ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67fb5561-cbef-425b-c64e-08db18bb22b4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:07:02.7027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +YAPCVsulrYQ2DehuksCNxdcOTN7QLn7pSyd2BJlATAI9zHLz7u3XOQq2pRaNC6kyCr1FeUe7xF1EqvqAqKV229coO5cCFGsc73oEUC4QOc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4966 On 27/02/2023 11:33 am, Jan Beulich wrote: > On 27.02.2023 12:15, Andrew Cooper wrote: >> On 27/02/2023 10:46 am, Jan Beulich wrote: >>> On 24.02.2023 22:33, Andrew Cooper wrote: >>>> But I think we want to change tact slightly at this point, so I'm not >>>> going to do any further tweaking on commit. >>>> >>>> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >>>> updating the non-SVM include paths as we go.  Probably best to >>>> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >>>> only got one tree-wide cleanup of the external include paths. >>>> >>>> Quick tangent - I will be making all of that cpu_has_svm_* >>>> infrastructure disappear by moving it into the normal CPUID handling, >>>> but I've not had sufficient time to finish that yet. >>>> >>>> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >>>> disappear (after my decoupling patch has gone in). >>> Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? >>> The latter doesn't use anything from the former, does it? >> It's about what else uses them. >> >> hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always >> included in tandem. > Well, yes, that's how things are today. But can you explain to me why > hvm_vcpu has to know nestedsvm's layout? Because it's part of the same single memory allocation. > If the field was a pointer, > a forward decl of that struct would suffice, and any entity in the > rest of Xen not caring about struct nestedsvm would no longer see it > (and hence also no longer be re-built if a change is made there). Yes, you could hide it as a pointer.  The cost of doing so is an unnecessary extra memory allocation, and extra pointer handling on create/destroy, not to mention extra pointer chasing in memory during use. >> nestedsvm is literally just one struct now, and no subsystem ought to >> have multiple headers when one will do. > When one will do, yes. Removing build dependencies is a good reason > to have separate headers, though. Its not the only only option, and an #ifdef CONFIG_NESTED_VIRT inside the struct would be an equally acceptable way of doing this which wouldn't involve making an extra memory allocation. Everything you've posed here is way out of scope for Xenia's series.  You are welcome to try and make the changes in the future if you want, but you're going to have a uphill battle trying to justify it as a sensible move. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:10:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502455.774262 (Exim 4.92) (envelope-from ) id 1pWcKV-0003Dx-B6; Mon, 27 Feb 2023 12:10:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502455.774262; Mon, 27 Feb 2023 12:10:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKV-0003Dq-63; Mon, 27 Feb 2023 12:10:07 +0000 Received: by outflank-mailman (input) for mailman id 502455; Mon, 27 Feb 2023 12:10:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKT-00039C-Mi for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:10:05 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab26c7ab-b697-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:10:04 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B094219F8; Mon, 27 Feb 2023 12:10:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F27B113912; Mon, 27 Feb 2023 12:10:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q56yOZud/GO4NAAAMHmgww (envelope-from ); Mon, 27 Feb 2023 12:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab26c7ab-b697-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677499804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FKQ4wSkV6NqwsSD0A/qTcE4myzNk8m5bjzR93rMoRBo=; b=Bcax36SKxgmeziiLRFTXcamj16oGQ9+iOWFWcqcpkcwQkn4PR+YtAlZJBOLmmzQY3vgDCq yoH3YlNvA77/JeOg1Zz9D0syDRhhmlL6dzVNtWvRSxvIKDC+OjB3qIXdKcV9e0wqvZrJKo 0gAGeU8NrPKqFFrejSEDmVOTwpU1WRo= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH 0/3] tools: use xen-tools/libs.h for common definitions Date: Mon, 27 Feb 2023 13:09:54 +0100 Message-Id: <20230227120957.10037-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some macros defined multiple times in tools. Use only xen-tools/libs.h for defining those macros and drop the copies. Juergen Gross (3): tools: add container_of() macro to xen-tools/libs.h tools: get rid of additional min() and max() definitions tools: add offsetof() to xen-tools/libs.h tools/firmware/hvmloader/util.h | 11 ++--------- tools/firmware/include/stddef.h | 4 ++-- tools/include/xen-tools/libs.h | 8 ++++++++ tools/libfsimage/Rules.mk | 2 ++ tools/libfsimage/xfs/fsys_xfs.c | 4 +--- tools/libs/vchan/init.c | 7 +------ tools/tests/vhpet/emul.h | 14 -------------- tools/tests/vpci/emul.h | 22 +--------------------- tools/tests/x86_emulator/x86-emulate.h | 5 ----- tools/xenstore/list.h | 6 ++---- 10 files changed, 19 insertions(+), 64 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:10:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502456.774272 (Exim 4.92) (envelope-from ) id 1pWcKa-0003Zc-Gb; Mon, 27 Feb 2023 12:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502456.774272; Mon, 27 Feb 2023 12:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKa-0003ZV-DA; Mon, 27 Feb 2023 12:10:12 +0000 Received: by outflank-mailman (input) for mailman id 502456; Mon, 27 Feb 2023 12:10:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKY-00039C-TG for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:10:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae5d68ee-b697-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:10:10 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E49FA1FD63; Mon, 27 Feb 2023 12:10:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA54813912; Mon, 27 Feb 2023 12:10:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rQ1OKKGd/GPeNAAAMHmgww (envelope-from ); Mon, 27 Feb 2023 12:10:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae5d68ee-b697-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677499809; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ie1ECZIy0vs3ZjCA8d3JTPcaE1XIqDwSIQ7h6WLxykU=; b=ChPKJbdiSyCpbkH3pPsThXCZB/GMcMpnBKMWxXxnY62nXuG1Z3i1/UZk3b/YX1z5h0wqzH CUnbSMUt3x4fr9Mjn8JorgFtDrYsJVuf9+YmEVDbu1x9k0IVhaIzdGJnsNoJuDyLKWz7tJ LqxHNftYfpfzbwRVDVcksWtxZIv4VjQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH 1/3] tools: add container_of() macro to xen-tools/libs.h Date: Mon, 27 Feb 2023 13:09:55 +0100 Message-Id: <20230227120957.10037-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227120957.10037-1-jgross@suse.com> References: <20230227120957.10037-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having 4 identical copies of the definition of a container_of() macro in different tools header files, add that macro to xen-tools/libs.h and use that instead. Delete the other copies of that macro. Signed-off-by: Juergen Gross --- There is a similar macro CONTAINER_OF() defined in tools/include/xentoolcore_internal.h, which allows to not only use a type for the 2nd parameter, but a variable, too. I'd like to get rid of that macro as well, but there are lots of use cases especially in libxl. Any thoughts regarding that macro? I could either: - don't touch it at all - enhance container_of() like CONTAINER_OF() and replace all use cases of CONTAINER_OF() with container_of() - replace the few CONTAINER_OF() users outside libxl with container_of() and define CONTAINER_OF() in e.g. libxl_internal.h - replace all CONTAINER_OF() use cases with container_of(), including the change from (.., var, ..) to (.., type, ...). Signed-off-by: Juergen Gross --- tools/include/xen-tools/libs.h | 4 ++++ tools/tests/vhpet/emul.h | 3 --- tools/tests/vpci/emul.h | 6 +----- tools/tests/x86_emulator/x86-emulate.h | 5 ----- tools/xenstore/list.h | 6 ++---- 5 files changed, 7 insertions(+), 17 deletions(-) diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h index bafc90e2f6..3672486daa 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/libs.h @@ -67,4 +67,8 @@ #define __must_check __attribute__((__warn_unused_result__)) #endif +#define container_of(ptr, type, member) ({ \ + typeof( ((type *)0)->member ) *__mptr = (ptr); \ + (type *)( (char *)__mptr - offsetof(type,member) );}) + #endif /* __XEN_TOOLS_LIBS__ */ diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index b022cc0eab..7db47c5beb 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -125,9 +125,6 @@ enum #define max_t(type, x, y) \ ({ type __x = (x); type __y = (y); __x > __y ? __x : __y; }) #define offsetof(t, m) ((unsigned long )&((t *)0)->m) -#define container_of(ptr, type, member) ({ \ - typeof( ((type *)0)->member ) *__mptr = (ptr); \ - (type *)( (char *)__mptr - offsetof(type,member) ); }) struct domain; diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index f03e3a56d1..237edb4e95 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -27,11 +27,7 @@ #include #include -#define container_of(ptr, type, member) ({ \ - typeof(((type *)0)->member) *mptr = (ptr); \ - \ - (type *)((char *)mptr - offsetof(type, member)); \ -}) +#include #define smp_wmb() #define prefetch(x) __builtin_prefetch(x) diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h index 18ae40d017..0849c07dbc 100644 --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -56,11 +56,6 @@ #define cf_check /* No Control Flow Integriy checking */ -#define container_of(ptr, type, member) ({ \ - typeof(((type *)0)->member) *mptr__ = (ptr); \ - (type *)((char *)mptr__ - offsetof(type, member)); \ -}) - #define AC_(n,t) (n##t) #define _AC(n,t) AC_(n,t) diff --git a/tools/xenstore/list.h b/tools/xenstore/list.h index b17d13e0ec..1f469eafaf 100644 --- a/tools/xenstore/list.h +++ b/tools/xenstore/list.h @@ -3,6 +3,8 @@ /* Taken from Linux kernel code, but de-kernelized for userspace. */ #include +#include + #undef LIST_HEAD_INIT #undef LIST_HEAD #undef INIT_LIST_HEAD @@ -15,10 +17,6 @@ #define LIST_POISON1 ((void *) 0x00100100) #define LIST_POISON2 ((void *) 0x00200200) -#define container_of(ptr, type, member) ({ \ - typeof( ((type *)0)->member ) *__mptr = (ptr); \ - (type *)( (char *)__mptr - offsetof(type,member) );}) - /* * Simple doubly linked list implementation. * -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:10:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:10:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502457.774282 (Exim 4.92) (envelope-from ) id 1pWcKf-0003uK-Of; Mon, 27 Feb 2023 12:10:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502457.774282; Mon, 27 Feb 2023 12:10:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKf-0003uC-La; Mon, 27 Feb 2023 12:10:17 +0000 Received: by outflank-mailman (input) for mailman id 502457; Mon, 27 Feb 2023 12:10:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKe-00039C-9P for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:10:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1b7b076-b697-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:10:15 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8BDB81FD63; Mon, 27 Feb 2023 12:10:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 548CD13A43; Mon, 27 Feb 2023 12:10:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cDthE6ed/GMSNQAAMHmgww (envelope-from ); Mon, 27 Feb 2023 12:10:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1b7b076-b697-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677499815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irti9dshWtZl+rE8Uu5A3Tbf4UdOJi+qh8/ebGpIp0U=; b=DsyqlgXcZ7ed7Hc7tySnhQwhCl6MMs9AABtkrZAlSlTTICyulBdNwRc2124BqIzP0D7Rv/ 1KJyNg7tmEdmYEb108GN/hwTTlU5C0weSCyQ498JNvdxzyfGQuT1X6LMqR78F1WCsttUwr aNpiljEnp93D/vapXOIsAbB84dzTzks= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD Subject: [PATCH 2/3] tools: get rid of additional min() and max() definitions Date: Mon, 27 Feb 2023 13:09:56 +0100 Message-Id: <20230227120957.10037-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227120957.10037-1-jgross@suse.com> References: <20230227120957.10037-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Defining min(), min_t(), max() and max_t() at other places than xen-tools/libs.h isn't needed, as the definitions in said header can be used instead. Same applies to BUILD_BUG_ON() in hvmloader. Signed-off-by: Juergen Gross --- tools/firmware/hvmloader/util.h | 8 ++------ tools/libs/vchan/init.c | 3 +-- tools/tests/vhpet/emul.h | 11 +---------- tools/tests/vpci/emul.h | 16 ---------------- 4 files changed, 4 insertions(+), 34 deletions(-) diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index 8d95eab28a..69afcc6daa 100644 --- a/tools/firmware/hvmloader/util.h +++ b/tools/firmware/hvmloader/util.h @@ -9,6 +9,8 @@ #include #include "e820.h" +#include + /* Request un-prefixed values from errno.h. */ #define XEN_ERRNO(name, value) name = value, enum { @@ -41,12 +43,6 @@ void __assert_failed(const char *assertion, const char *file, int line) void __bug(const char *file, int line) __attribute__((noreturn)); #define BUG() __bug(__FILE__, __LINE__) #define BUG_ON(p) do { if (p) BUG(); } while (0) -#define BUILD_BUG_ON(p) ((void)sizeof(char[1 - 2 * !!(p)])) - -#define min_t(type,x,y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) -#define max_t(type,x,y) \ - ({ type __x = (x); type __y = (y); __x > __y ? __x: __y; }) #define MB(mb) (mb##ULL << 20) #define GB(gb) (gb##ULL << 30) diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98..ea2d7f2c54 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -45,6 +45,7 @@ #include #include #include +#include #include "vchan.h" @@ -72,8 +73,6 @@ #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) #endif -#define max(a,b) ((a > b) ? a : b) - static int init_gnt_srv(struct libxenvchan *ctrl, int domain) { int pages_left = ctrl->read.order >= PAGE_SHIFT ? 1 << (ctrl->read.order - PAGE_SHIFT) : 0; diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index 7db47c5beb..efd04ed313 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -114,16 +114,7 @@ enum TASKLET_SOFTIRQ, NR_COMMON_SOFTIRQS }; -/* - * ..and if you can't take the strict - * types, you can specify one yourself. - * - * Or not use min/max at all, of course. - */ -#define min_t(type, x, y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; }) -#define max_t(type, x, y) \ - ({ type __x = (x); type __y = (y); __x > __y ? __x : __y; }) + #define offsetof(t, m) ((unsigned long )&((t *)0)->m) struct domain; diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index 237edb4e95..bf3cef5586 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -106,22 +106,6 @@ typedef union { #define BUG() assert(0) #define ASSERT_UNREACHABLE() assert(0) -#define min(x, y) ({ \ - const typeof(x) tx = (x); \ - const typeof(y) ty = (y); \ - \ - (void) (&tx == &ty); \ - tx < ty ? tx : ty; \ -}) - -#define max(x, y) ({ \ - const typeof(x) tx = (x); \ - const typeof(y) ty = (y); \ - \ - (void) (&tx == &ty); \ - tx > ty ? tx : ty; \ -}) - #endif /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:10:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:10:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502461.774292 (Exim 4.92) (envelope-from ) id 1pWcKl-0004Jv-64; Mon, 27 Feb 2023 12:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502461.774292; Mon, 27 Feb 2023 12:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKl-0004Jl-37; Mon, 27 Feb 2023 12:10:23 +0000 Received: by outflank-mailman (input) for mailman id 502461; Mon, 27 Feb 2023 12:10:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcKk-00039C-1h for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:10:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5150e23-b697-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:10:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 352D5219F4; Mon, 27 Feb 2023 12:10:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2CFD13A43; Mon, 27 Feb 2023 12:10:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eOUWOqyd/GMtNQAAMHmgww (envelope-from ); Mon, 27 Feb 2023 12:10:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5150e23-b697-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677499821; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGDTryXA/fAzaKK5uzbhHS2WMaHPYkQlraK/zFukITQ=; b=ktEbKrX7zS6S6jjNsOHtDjW+Yjfy7KrBBqH0J7LVRf782Ms0e5pckmG4oOnpA9EgjvrmLe ZBozM4YbPwZp7CGu8jCAJPWIGaVnj8/s0qnVa7QkIXMBsSOJlZcXV5n72cXCHaeLERNd9O 26fISx2GyB68ZvLZpNFF9+rESgbDCio= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD Subject: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Date: Mon, 27 Feb 2023 13:09:57 +0100 Message-Id: <20230227120957.10037-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227120957.10037-1-jgross@suse.com> References: <20230227120957.10037-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having multiple files defining offsetof(), add the definition to tools/include/xen-tools/libs.h. Signed-off-by: Juergen Gross --- tools/firmware/hvmloader/util.h | 3 --- tools/firmware/include/stddef.h | 4 ++-- tools/include/xen-tools/libs.h | 4 ++++ tools/libfsimage/Rules.mk | 2 ++ tools/libfsimage/xfs/fsys_xfs.c | 4 +--- tools/libs/vchan/init.c | 4 ---- tools/tests/vhpet/emul.h | 2 -- 7 files changed, 9 insertions(+), 14 deletions(-) diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index 69afcc6daa..668ee74f3c 100644 --- a/tools/firmware/hvmloader/util.h +++ b/tools/firmware/hvmloader/util.h @@ -30,9 +30,6 @@ enum { #define SEL_DATA32 0x0020 #define SEL_CODE64 0x0028 -#undef offsetof -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) - #undef NULL #define NULL ((void*)0) diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h index c7f974608a..926ae12fa5 100644 --- a/tools/firmware/include/stddef.h +++ b/tools/firmware/include/stddef.h @@ -1,10 +1,10 @@ #ifndef _STDDEF_H_ #define _STDDEF_H_ +#include + typedef __SIZE_TYPE__ size_t; #define NULL ((void*)0) -#define offsetof(t, m) __builtin_offsetof(t, m) - #endif diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/libs.h index 3672486daa..c222aa5bb0 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/libs.h @@ -71,4 +71,8 @@ typeof( ((type *)0)->member ) *__mptr = (ptr); \ (type *)( (char *)__mptr - offsetof(type,member) );}) +#ifndef offsetof +#define offsetof(a, b) __builtin_offsetof(a, b) +#endif + #endif /* __XEN_TOOLS_LIBS__ */ diff --git a/tools/libfsimage/Rules.mk b/tools/libfsimage/Rules.mk index cf37d6cb0d..85674f2379 100644 --- a/tools/libfsimage/Rules.mk +++ b/tools/libfsimage/Rules.mk @@ -3,6 +3,8 @@ include $(XEN_ROOT)/tools/libfsimage/common.mk FSLIB = fsimage.so TARGETS += $(FSLIB) +CFLAGS += $(CFLAGS_xeninclude) + .PHONY: all all: $(TARGETS) diff --git a/tools/libfsimage/xfs/fsys_xfs.c b/tools/libfsimage/xfs/fsys_xfs.c index d735a88e55..4c0cde9777 100644 --- a/tools/libfsimage/xfs/fsys_xfs.c +++ b/tools/libfsimage/xfs/fsys_xfs.c @@ -19,6 +19,7 @@ #include #include "xfs.h" +#include #define MAX_LINK_COUNT 8 @@ -182,9 +183,6 @@ fsb2daddr (xfs_fsblock_t fsbno) (xfs_agblock_t)(fsbno & mask32lo(xfs.agblklog))); } -#undef offsetof -#define offsetof(t,m) ((size_t)&(((t *)0)->m)) - static inline int btroot_maxrecs (fsi_file_t *ffi) { diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index ea2d7f2c54..9c0c5ca0c5 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -69,10 +69,6 @@ #define MAX_RING_SHIFT 20 #define MAX_RING_SIZE (1 << MAX_RING_SHIFT) -#ifndef offsetof -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) -#endif - static int init_gnt_srv(struct libxenvchan *ctrl, int domain) { int pages_left = ctrl->read.order >= PAGE_SHIFT ? 1 << (ctrl->read.order - PAGE_SHIFT) : 0; diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index efd04ed313..2eeefa7098 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -115,8 +115,6 @@ enum NR_COMMON_SOFTIRQS }; -#define offsetof(t, m) ((unsigned long )&((t *)0)->m) - struct domain; struct vcpu -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:12:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502474.774302 (Exim 4.92) (envelope-from ) id 1pWcMR-0005bf-Ia; Mon, 27 Feb 2023 12:12:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502474.774302; Mon, 27 Feb 2023 12:12:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcMR-0005bY-Fm; Mon, 27 Feb 2023 12:12:07 +0000 Received: by outflank-mailman (input) for mailman id 502474; Mon, 27 Feb 2023 12:12:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcMQ-0005bM-8H for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:12:06 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20621.outbound.protection.outlook.com [2a01:111:f400:fe1a::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0b274a6-b697-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:12:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB7125.eurprd04.prod.outlook.com (2603:10a6:20b:121::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 12:11:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:11:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0b274a6-b697-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pv3sgtoJf4z0ggwr6+S0Ih2LrjPrsFyr3KWqcqPg77PlnAnzeONCfArgYgAyywrjjvbsxwvbOqbKQD8lBwMli6zCR+Xl/6hde0wwP/r1J3NEflstEhYbTo98ntiIm9R6zvebqsj1H9uE5ZbZ1BpB1pOEZ8oIb7vRrqSaEg8SynCz7jQKSONSqcVGJFDMKsebcPc0KfKkpF35JvMfrUPwt4gt9py1CUVthLx2+PvqmuEJ69bCGpmxc7lTvXOqUIpGUVcZJkbzHq1ckcV+u1YR8ioaw09+alM0k6mJPfuxIHGNt5vUcr9+/4Ee+jpPtQGNIoOFDjvK6CP+1xMG0QpIiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5oH3J1hc6CerhB80sZEz7ZsZZe1n75oa2tpTtMP1qaA=; b=AXLobwo47ZNonZQf5KrstYOyUpc9dZ6DbdTZ0bhDsJWVp6nHDB/+0JfU4+fh1tfQnHdaYen7tTWsvRz3AU5s6W4M79m7jQOsbjuEzNlCuEr6mlLAnff1E+MAMIEXMSC6iobEGS5EcbC/QTasRQyBjjL5sjhoVuOXIl6yYEDoFE9SKowPL7njeiKjNrETHmQVQNp1Xz01GRxNYqHebLznkQ3Lj3Pu/x3kVBy2D2UECGUwPHUyiykR7FpK5IKJHHEouYRegN1zzFXG59ZTtiuN5S6iJ3oV8mVc5cAy5FOmFzpYyzUPLB+PItGEehXb7vHeKn1aXB8TXeNO7HPx35Osog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5oH3J1hc6CerhB80sZEz7ZsZZe1n75oa2tpTtMP1qaA=; b=STsy973bI0dj8hJ2vxgks+Ea5f5QTOfqBNccQvmBPq1s3qujlFw+jrQGZlKeYtQqc/PGo5bXTuMO1SzIhcBUIABHV04GgVEFfxipcgIaWq52+CM7awuHFFXva7xjH7x11ZTioQYup9NXe6Cmrksn8kLYdcWIQ5swUZ8fo5sGJVahTP51iB/DuOgouYZiYDV+v+3wK0ohhI1FOq8Y3jLBlIglgmQKYdhUcq1Z8zfIMKA1imGhb0fVC/sEeg1q5iFBIsMv8SyAZ6L34w2PN/+rJEJ1IfRFi/vKPww6GcsiDtFqGcUcWH+2naYhj6NS/leVFqAFNlhwbN9H5FNiO7B53A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 13:11:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: S0ix support in Xen Content-Language: en-US To: Simon Gaiser References: <9051e484-b128-715a-9253-48af8e47bb9d@invisiblethingslab.com> Cc: xen-devel From: Jan Beulich In-Reply-To: <9051e484-b128-715a-9253-48af8e47bb9d@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB7125:EE_ X-MS-Office365-Filtering-Correlation-Id: 459f9d73-a703-46f0-a42b-08db18bbd398 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QpzS/HVsIRmzGXw4RcK87AHrN2HPaugw7P3EHpYvyHCFIk/2J50LDLQz7uQe5k45P543Y4I4vlTRYQJZWv54UGFxnkmNrzCpHhDikA3hndaEhuYdiXuq51C0HeA6Db55dxKtDGG+LewpJrnodZvBNgxD+aLa0898AyJU9W9hc1lNa/vbJtvbg8lTOloR+ad2tMtTgn+q62FzSsXrpeXI9WXv1gSB6BOrd9cmKKQ/S8AUJLfhm9EX92XD/MdZF7KWtGj0vevw354/TegooFzXG/ENrHdEOsyvLdur+ZSGO7d3/iQfSo0NGGroX3/zcZIYLRNyFQgsPm4u9Km4tfGJ6Lqw42IXHVTPa3s5MlH7GiXHwwobwjerDmFygE128OfiG2RyrMPtqt1nTyJszVDELEmJYjgGaBTXKI/KjlImZlboKcxk4cjHYBDcpq1tNvfp8eYq9ZgkLSSfnjsxuvMqO/vLnvNvGbkPnsaVq9hlHeMkI6SKQUEZ03ARqr6gcJ/7jxnQqDAPNaORXux3wkSYCDCcquf3Nl9oczZrNK83H2MY2UJ4m5AaQPphfK5lbGKs2HgK2AKqzOwfWI1Ytrd+wDGEwzq0QTNWUs8sb0k6sjGbeXiIYt6cC98yTxWAs9qe8f55nOKCFvbIsw1v7iFit5XjDJTPQXdvvEwBGuoUPcVKzAe7zWO7RnHGT4moyNIfrIlY8AOBDMJdWSKH8Z3UPl1B967LDGE54YapFIF9Zr6M5TWJGxbHrrbxiogyctyv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(39850400004)(346002)(376002)(396003)(136003)(451199018)(6916009)(41300700001)(4326008)(2906002)(8936002)(66556008)(31696002)(66946007)(66476007)(8676002)(38100700002)(86362001)(36756003)(316002)(478600001)(6506007)(53546011)(26005)(186003)(6512007)(5660300002)(31686004)(6486002)(2616005)(83380400001)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkQ3SnMrOXp3VmhZZHFTZHorN21BdUljSkNFZ1hPamFmTXF1RmJsQXlFYWYv?= =?utf-8?B?Y0pHVUZLMnk0eFhna0tBM2RRSzRYTVhvVTAzMDg0T25DdGhETnpTOWtuT2k3?= =?utf-8?B?U1c4VnUrMHJuVktHd2UyL2hWOXZtRWJXQmtkQkN0SFRkUFE2RFdlMmd3dzBv?= =?utf-8?B?TzlRaXlvd3h6eERCbWI5V1NXRS9hdnZEL1VxOVpZejVKbzJpQU15MVhlY1Fa?= =?utf-8?B?MzRHRllKbzdmdDkwa2VLeHYzM2Y4aTRlRktJNE51M3lVcUw3UmgwT1VycitG?= =?utf-8?B?R281cUlGRUsvQk1HVS9TaGxmemdvMDhWNDVSNy81Q3p6RjJIcTFDV2NxL2pr?= =?utf-8?B?WkVRTlU4d3VvK3RNMkhDWjY1MXlDc2dJK0o4U3BnRnNQNlplSEx6MGVYWTNP?= =?utf-8?B?M0x1djRmZzMycDdXQXJmTnQvN3BGdGl0RTFTSzhaTlV5OVYrd1NOaFNiM0JN?= =?utf-8?B?Skk5MktQeXFOMFd0WHpoQ2NwdVNwNWxLaXBJUXNTZXVMOFgwM0Q4L1ArNDEz?= =?utf-8?B?a0M1TGtQbXJpNlAzREcvdXpnTjMrVEJQeUlhckx2c2sxb2FZTFYrWXdQbEdt?= =?utf-8?B?aU5OTXIwTTh0M04zcWU3NDhDdXpKQ1c1WEdqTldSMmdXZXVpTHNndWo1anpH?= =?utf-8?B?SmpnZHV5YnJqVjlGd0ZTMTA4S09ZZlhldjBxVnB3MkVqM3JkcEpwOXczOUNu?= =?utf-8?B?NkpRZWI2aUt1RG5HbkZ0RVFORDZxejZjV3NOUnhyYkszL202YVdCSzhyNCth?= =?utf-8?B?NWVBVllNRFplVlZjWlZ2N0dXY1FZaGtpdW0xVFpOdHZBV0xPbnpUaXVBMjRS?= =?utf-8?B?RjRQcytTeFdkNjFtTmtYcEZsdFA1eWJVditkYXRyakdOTmVCN1JjWkFOU3VP?= =?utf-8?B?WndlejhMbG05VkZvMnVhczgzUVFpaFVwNWt3RFN0T21ualBVd1Z6NTNqWUpp?= =?utf-8?B?dlJCVU1ZRC9JZGtRT2QzNVlyT2tNV3FFcEJrSEpTVGNIcXd5Y01yOGROeVF1?= =?utf-8?B?a3Bjd2NCS2QwUEhEM2cvcVptKzZxYlo4dmlYcnpSa1Z3ajkvOU9jQnRFSWNt?= =?utf-8?B?Z3MwS1hrbGVCOXd4TlZxNGxkM1laaXlQdHNyZG85U3pGWlBvL3NHMkI2WktW?= =?utf-8?B?bzF1d054czZYZ0pMNHBBSUp4YythYTRuQkZhWDBOL09xbVlUcmhuM0dxR0M1?= =?utf-8?B?dUVLWDdRVkEzYjVXWnFOSGNlNXJIbDZWUUZsS1NXWmVDOUZYbU9HY051VmRr?= =?utf-8?B?emlGUCtsWUpMeVlOMlJCek5mWExOVS83V1Q5U2RqT2V3ZnhxTUlIWTVCOWpx?= =?utf-8?B?WkVjSVFzQXVnZVdBSGFPZS9uK1BWcnhTUVZMWWlNbnprNE9LTFVOQmhFV2I3?= =?utf-8?B?R200OE5TbzhuSlNqVE00R3A1NFVmYkx2NDhqTkdNelNoc3Focm0rRytJeTlh?= =?utf-8?B?cWR6LzRrdlhaeTkrSWY3a2drZy8yUG1PZ1hsZktWN2ZZM3FwLzR1VHZmTWxr?= =?utf-8?B?V1R3OWJFS3Y3a1h4TkFmNUFiVllJRGVGWExKVTRhRmRPa2hMcit4bWhDOEhV?= =?utf-8?B?L2tpOHllNXpwWDZaTlBtZ3VUM0QxUlE1N0NrZFVNR0REd3R2TnJYWm1wU1Bo?= =?utf-8?B?eHhIbUQ2TDcxVjdJTXJwYTRXbTdhanVmSG5FWjFIeklQd2tjaElDV1NHOWxQ?= =?utf-8?B?T2VGU0xOaGFsVkYrM2hBNnZVUzJoMHZpT3dIWk1xdUhEL2pmMzRkSXVRcnhj?= =?utf-8?B?UTZnRWNockxnb2xJUFJnYXdNYlN6TGxRQllSQTBWR3R1bUtwWDZ6WVRUM0Jv?= =?utf-8?B?Q294N01hNGhsaU13UDkxejVZbFNaaFkrYzFYMU5GbWs1L3BsdE9WUW5RNE1w?= =?utf-8?B?MjhXNmtOVmZscWk4ZXpEMUtCTzBHU0dGL0xRK2N4QUNubitPSnBOV1JRSDJo?= =?utf-8?B?RlFTeFBVQXJLKzdRaWlDSmoyaHVLRzM2WnEyUzJzMENZSXJjUk1uUXVadmR0?= =?utf-8?B?K01ldmdHU1hRL3FxWU5KYVc2VUpNcGh0VlN3V1JMMUYxQlZ1YXdqRXFBYU85?= =?utf-8?B?cU1JcDA0ZnREemY5bE15ZTYwSTl3ejYwekR0QmYrT0EvZWI0VGV6OGpiUFAr?= =?utf-8?Q?ZZDEXyNx1oiLA7NWBHsHuK8BR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 459f9d73-a703-46f0-a42b-08db18bbd398 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:11:59.1941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KRnq/gNaYPR8gaYNCwGu9LNhd6hxCMcHIPsbILUCI3OIwCVyJN6CrmnUOJvIbL/+5/bvaAnUxPPid1VFTxYVQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7125 On 27.02.2023 12:48, Simon Gaiser wrote: > PIT timer: During some previous private discussion it was mentioned that > the PIT timer that Xen initializes for IO-APIC testing prevents S0ix > residency and therefore that part needs to be reworked. But if I'm > reading the current code correctly Xen can already use the HPET timer > instead, either with an automatic fallback if PIT is unavailable or by > forcing it via hpet=legacy-replacement=1. Looking at the rest I think > the PIT isn't used if Xen finds another clocksource. Did I miss > something? I think the concern was with calibrating the APIC clock against PIT, but as you say that connection has been cut. So I think there's no prereq work left there; Andrew may prove me wrong, though. > mwait idle driver: While mwait-idle.c share a lot of code with Linux's > intel_idle.c and the imported code seems to have been updated (for > example for Alder Lake) it only supports the CPUs with hardcoded > cstates. Linux's code also has a code path to read the cstate config > from ACPI if the driver doesn't has a hard coded config for the model. > This is needed for example for Tiger Lake. For my current testing I > added the values the Linux code reads from ACPI by hand. But that's of > course no proper solution. How should this be handled in Xen (IIUC some > ACPI things are handled by Xen and some by dom0)? Well, there's first of all some lack of understanding on my part: It hasn't become clear to me why Linux now has two CPU idle drivers consuming ACPI data (intel_idle and the purely ACPI-based one). If two are really needed, then I guess mwait-idle would need extending to also consume data passed up from Dom0, just like the ACPI-only driver in Xen does (and which doesn't do anything until such data was supplied). > I'm not sure yet is what else in Xen needs to learn about S0ix. Running > domains need to be halted, that can be handled by the toolstack. What > other Xen internal things need to be aware of S0ix? Like avoiding > unnecessary timer wakeups or similar. That's currently my biggest > unknown and it would be great if someone with more insight and overview > could give some hints here. I didn't think the higher-level-software side of things was different from S3. Instead I thought it's merely a matter of different interaction with hardware that's needed (which, as per above, includes avoiding certain things, i.e. in particular the PIT). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:14:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:14:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502478.774312 (Exim 4.92) (envelope-from ) id 1pWcOB-0006Ae-Tz; Mon, 27 Feb 2023 12:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502478.774312; Mon, 27 Feb 2023 12:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcOB-0006AX-RA; Mon, 27 Feb 2023 12:13:55 +0000 Received: by outflank-mailman (input) for mailman id 502478; Mon, 27 Feb 2023 12:13:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcOA-0006AP-7B for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:13:54 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32b7e844-b698-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:13:52 +0100 (CET) Received: by mail-lj1-x233.google.com with SMTP id z5so6193193ljc.8 for ; Mon, 27 Feb 2023 04:13:52 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id b15-20020a2e988f000000b0029599744c02sm711861ljj.75.2023.02.27.04.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 04:13:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32b7e844-b698-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=9lNsBql8aioKtLfiL9IaOFFrgzEWLfErMQPcFuOlMa0=; b=WCJ3JEr4kRlN1Qhj2STHJ44/uFHZooDxOtULn+JaTQeNf/YadR9xhDuqENa21IjKZR +nIRLk3JaEmK/4DjnOJgkPP9uNEk3za3JaRfmU03xvL6nCAmJ3Wx1XPaZmnrbw3HAWgX vUrEo1riNgX9BvolGh5C0tzV+4OeWId1atQZAQqXkD43TOG9yRHHbvScH4Ret9+k4u47 8bc470S11bnFsPbCzdi27yWr3R/fGdbpMoXQYBEtZ6iGA46PXMjKBNfBupUqutdas7OO br7HANgo7xyqEhxErrIoED7YIm4f03Y+yFugU5inkuTuWapxBjN+FW7CZ+PYvBJsfCY3 3MQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9lNsBql8aioKtLfiL9IaOFFrgzEWLfErMQPcFuOlMa0=; b=jd9XOTvc2Hf+UxDhui5PXzb5ViJ9Z2PiENKnhcL4/PcF8VbTDByCtff+n4qlXh4BmO AhV5ya2KhRFpQ03EjUyrzH07vEGknyl09NVgefB+LBljybK6/qKrEMSORSk04Uvj15Eh q3yROyYfvmJwDnH7lqSjcg2r05y0d6ywwBjcj/XkIJz6PkDoYUkjemLsmRtfW5XDL/4k CSIbiuWc0XcaoqLMfVEJ+271gaeQAbrdChC6bLH1XEA6A5oMyMlUp/M/i6tecVR/15so XnikHRaz6ihikdxHt4WpCtJHLP3FWc0YJDtLxg0N3GInRuFLJcMxf7g5lc5BDR4W3+7U 3pzw== X-Gm-Message-State: AO0yUKV4FSYRvKOYg3R0gLG3q8uw3gOsd0plXzzUcpn3p/sSV1BC0+ZD 61+TqF9cjXEJ8IkLRp7QFQc= X-Google-Smtp-Source: AK7set/kMbU9Q7XYd8aNpw23ZRqLlSp9+UmQDM46LWoaTF+sw2C9o/dGeZiAKii5Sbp+gt5TQI6hVQ== X-Received: by 2002:a2e:8e84:0:b0:295:a3a6:614 with SMTP id z4-20020a2e8e84000000b00295a3a60614mr3755855ljk.12.1677500031464; Mon, 27 Feb 2023 04:13:51 -0800 (PST) Message-ID: <19c2c6f283e9f220fa54d9c08a911aa3d3f530ef.camel@gmail.com> Subject: Re: [PATCH] xen/riscv: read hart_id and dtb_base passed by bootloader From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Mon, 27 Feb 2023 14:13:49 +0200 In-Reply-To: References: <94d722dea114defa2a5efe29e6511829f0c54b41.1677249592.git.oleksii.kurochko@gmail.com> <738ca749-2abb-6ab4-db8f-81ff41f4de16@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-27 at 12:37 +0100, Jan Beulich wrote: > On 27.02.2023 12:19, Oleksii wrote: > > On Mon, 2023-02-27 at 10:17 +0100, Jan Beulich wrote: > > > On 24.02.2023 17:36, Oleksii wrote: > > > > On Fri, 2023-02-24 at 16:04 +0100, Jan Beulich wrote: > > > > > On 24.02.2023 15:48, Oleksii Kurochko wrote: > > > > > > Signed-off-by: Oleksii Kurochko > > > > > > > > > > > > --- > > > > > > =C2=A0xen/arch/riscv/setup.c | 12 ++++++++++++ > > > > > > =C2=A01 file changed, 12 insertions(+) > > > > > >=20 > > > > > > diff --git a/xen/arch/riscv/setup.c > > > > > > b/xen/arch/riscv/setup.c > > > > > > index b3f8b10f71..154bf3a0bc 100644 > > > > > > --- a/xen/arch/riscv/setup.c > > > > > > +++ b/xen/arch/riscv/setup.c > > > > > > @@ -26,6 +26,18 @@ static void test_macros_from_bug_h(void) > > > > > > =C2=A0 > > > > > > =C2=A0void __init noreturn start_xen(void) > > > > > > =C2=A0{ > > > > > > +=C2=A0=C2=A0=C2=A0 /* > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 * The following things are passed by = bootloader: > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a0 -> hart_id > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a1 -> dtb_base > > > > > > +=C2=A0=C2=A0=C2=A0 */ > > > > > > +=C2=A0=C2=A0=C2=A0 register unsigned long hart_id=C2=A0 asm("a= 0"); > > > > > > +=C2=A0=C2=A0=C2=A0 register unsigned long dtb_base asm("a1"); > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a0" : "=3Dr" (hart_id= ) ); > > > > > > + > > > > > > +=C2=A0=C2=A0=C2=A0 asm volatile( "mv %0, a1" : "=3Dr" (dtb_bas= e) ); > > > > >=20 > > > > > Are you sure this (a) works and (b) is what you want? You're > > > > > inserting > > > > Oh, yeah... it should be: > > > > =C2=A0 unsigned long hart_id; > > > > =C2=A0 unsigned long dtb_base; > > >=20 > > > As per below - no, I don't think so. I continue to think these > > > want > > > to be function parameters. > > >=20 > > > > I did experiments with 'register' and 'asm()' and after rebase > > > > of > > > > my > > > > internal branches git backed these changes... > > > >=20 > > > > Sorry for that I have to double check patches next time. > > > >=20 > > > > It looks like it works only because the variables aren't used > > > > anywhere. > > > > > "mov a0, a0" and "mov a1, a1". I suppose as long as the two > > > > > local > > > > > variables aren't used further down in the function, the > > > > > compiler > > > > > will > > > > > be able to recognize both registers as dead, and hence use > > > > > them > > > > > for > > > > > argument passing to later functions that you call. But I > > > > > would > > > > > expect > > > > > that to break once you actually consume either of the > > > > > variables. > > > > >=20 > > > > > Fundamentally I think this is the kind of thing you want do > > > > > to in > > > > > assembly. However, in the specific case here, can't you > > > > > simply > > > > > have > > > > >=20 > > > > > void __init noreturn start_xen(unsigned long hard_id, > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long dtb_base) > > > > > { > > > > > =C2=A0=C2=A0=C2=A0 ... > > > > >=20 > > > > > and all is going to be fine, without any asm()? > > > > One of the things that I would like to do is to not use an > > > > assembler as > > > > much as possible. And as we have C environment ready after a > > > > few > > > > assembly instructions in head.S I thought it would be OK to do > > > > it > > > > in C > > > > code somewhere at the start so someone/sonething doesn't alter > > > > register > > > > a0 and a1. > > >=20 > > > Avoiding assembly code where possible if of course appreciated, > > > because > > > generally C code is easier to maintain. But of course this can > > > only > > > be > > > done if things can be expressed correctly. And you need to keep > > > in > > > mind > > > that asm() statements also are assembly code, just lower volume. > > >=20 > > Let's get hard_id and dtb_base in head.S and pass them as arguments > > of > > start_xen() function as you mentioned before. >=20 > Still looks like a misunderstanding to me. Aiui a0 and a1 are the > registers to hold first and second function arguments each. If > firmware places the two values in these two registers, then > start_xen(), with the adjusted declaration, will fit the purpose > without any assembly code. >=20 It will work for the code we have now, but it will be more save to save registers a0 and a1 to some variables and pass them to start_xen() as arguments as they can be changed by something before the start_xen() call in the future. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:17:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:17:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502483.774321 (Exim 4.92) (envelope-from ) id 1pWcRR-0006mp-C0; Mon, 27 Feb 2023 12:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502483.774321; Mon, 27 Feb 2023 12:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcRR-0006mi-94; Mon, 27 Feb 2023 12:17:17 +0000 Received: by outflank-mailman (input) for mailman id 502483; Mon, 27 Feb 2023 12:17:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcRQ-0006mc-5Q for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:17:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7e1a::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab7e4347-b698-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:17:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8074.eurprd04.prod.outlook.com (2603:10a6:10:24a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:17:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:17:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab7e4347-b698-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ln+1PI7CHLob1AflkE8/AmVVQGrBqDvmNFpPvmPekmoorLJ3FTBQb9rvXMEjr7QXgnhdSTX4pGifW0a+p7by/kdOahQulhaZulXm1RLN5LN212dTOR4BfQ10wC7TIcISQ4/lE4OQXFm3eNBxj65qfXhLAI2Seae/fqjlw+f2xtFaZ771CqY4qPCmSti0mH6ZSb4kopgR6IyarclUBAd5Hzw9Wvii/rvtD7X4Zs1L2/S1fNrCevEhO+QWZCEMfCIPkhbE0solszUhQQqNlmj75bE54guKNl6+OfZdKgF4ayEUdXv3y8PfodvlGQM+MGJSVsWJEsEYVffwhwF3dRdC0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b4y1Fdn6C5vngabLpwtHHHEOotk460qslV729UxlBs0=; b=K3wGcEzLqa31YNo4zAFCwZKFlgMJZxQktA6dbTzszwalVxWR4dFJYugsXtpG0FUbiRubgmRgApQRsmsYObb5ygjVbOAzvYMRiV+6AhDLq5MshyD4BSii++sh/6eYbH6ew9fjdttAL8e2gFUtjf3dgeNo6SIgDY1KM05Uh41DOcrY2/ZIvLHHXXWWEg0D5kHivppx8yPfJvLRXe5ciwqaZIJMS4G3wC3fLNCe91BUxhZQZWF3prgT6L9k+DGLS61bLGbs8qI9m4HvizMSj/4Hq4EkNpnMubg7RB7BSlsNrMtnkqlbIXf51ClZ2Llg34BT6Y5XryZAS8ngX99xQaa0Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4y1Fdn6C5vngabLpwtHHHEOotk460qslV729UxlBs0=; b=v/P0z24xNv2cIZQx4qFVBlzR5wvJK7k4a/88VUsmwzZXtDw2owJWN73R6x4zUxwR24+qIYyAxIugFxgiJMZD0S/tar5gA6UtLWbm8clwMm6JZqQEASeI43+knh2lj56Gtja7+gy1v8BMxwqnFPYczZiIVN5OM4VRJgBpo4fl1o57x7Wt1CXR6U5F8+mCrEji44acqe9/nc/X/Pezs6G2COkU22Ks1061eiKtEENuY07MjcRf8lG+otV/91dor7D4J6bhsak3ogKNJxQs+zfd+61s3yGcQeuM2Fj7UWuQJkDd0Nz+64zNCUz7FQ7sfjA5ft2LuaEW2SgBm0+PTBgIVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <60252bef-c732-b061-8ec0-c4022eb41255@suse.com> Date: Mon, 27 Feb 2023 13:17:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> <18b9b99e-1d93-73d8-f9b8-873f44287c5c@citrix.com> From: Jan Beulich In-Reply-To: <18b9b99e-1d93-73d8-f9b8-873f44287c5c@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8074:EE_ X-MS-Office365-Filtering-Correlation-Id: f7a839ac-5ed1-41c9-c7f0-08db18bc8dcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Up318CLvM0Da25FBX5etIqnCqV1u34Hb9ShpjhSf3XVI+xZ8PKwYmVcHuKVf0s+cXT4d+RRu1TcAJwCOBK5UGnRAXOWQiGX4rlbYG2AymrqWag/qyuc/2hN6AS4MgVLM7ozsHco8HLPuAlzlyYvA/6o7VxrJo7mI8UDqY54aiPORGUgU4abb3AnW9hrSn2WTRAKkSEW+nFhHOZObCylCJ3XUhdMbx1FfyDetMeSloxxJMkBSFizbBuo2z4jfPe/t5xjeLs21GmiTHtAeVxpa6IB84OycPv4zmhyV809KQibqY0Ux0d7U7DxKkmrg7pf7wF7iXwgw8HGJxzr4krMB7Jb2YUhVKfHSiwxtHRmWi7ut/S2Jw99Xka8yMdcS2661UjP6C1md2bc76q8cyBm+pCMDn5Hp1k+cWrT6wkkt19FMeoKxB79Ktb5G9bU8EPT17HUe2G1CAPQ+/atk6g9rxtjs0H5gijK5axbUbXnYvIBbUA/hXONYpYhFUiJhvx0MULdmRKWaAPi+tYYUho1v13RwgNrWgJrsZ92FO0cWo+uxvPS1T60LN0zWd0GL7X9Ak/HsQB4e0xDcRmLX376/M6/U2+12jWg3qYc06+bMuVR0y6/FZmkFDQNPjuD+/8TFgUBiG0Ka4qThJn275sdjsOZ3aJhykqkIFazt7OuFBIy9nJFnHWYUlIFFa+VMIV7Y611RtpmVRgXa+XKp7vMByPs8xZOBIEyqCt7fhewthq8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(136003)(346002)(366004)(39860400002)(451199018)(31686004)(316002)(36756003)(54906003)(86362001)(31696002)(38100700002)(83380400001)(6506007)(53546011)(26005)(6512007)(186003)(2616005)(8936002)(2906002)(6486002)(5660300002)(478600001)(41300700001)(6916009)(4326008)(8676002)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkNQOFJPUGN3eWpGMW5Wc0V2d0kwaks3SjNTbHo4cVRnNkhhYXROVGQwck1X?= =?utf-8?B?eXF6WDJHYWhXb29QbDJwZDRHOWJ4VXB6ZHZzbnZTV2J5OE1ZczZDL2FLdFow?= =?utf-8?B?VktOSnFTckxkTTNraEtRZEJ0Wmc2QVllRDl2VWNBd3hVQzVUbFBrVVZjWmJi?= =?utf-8?B?SjFac1hGa29OYWZybGN0YllRcVduRXJJUG02S2tRZnEyU0tUQkxNR1puMjNW?= =?utf-8?B?T1BzWmlhb0o3bWpnb2ZhVEg4aDVRMEdOcmRyYVhUUWtmbDZ6UXhaOTQzVm9x?= =?utf-8?B?UTFTeWozNDlMM1NEVHRqcncxNjJBYlBqM05hT1liVHN6c2RNQXJBNUM2dlVN?= =?utf-8?B?eVgwY3hpcVEvL3lWVk42bnl2aGhYdDFIOFFaVjA0N2NYcHpQMTZwdlpiSm5V?= =?utf-8?B?b0JZU2k1TWZqaUZTQ0xpWWZETjUzTUlWK1QzbFlEenMwVkdiYkpwTE55YXVj?= =?utf-8?B?ZzFGT25VdTh4QnBkTm95RXovVWhJbHd5elJWWmpCaDRER0xLemJsNEczOE8v?= =?utf-8?B?UFRWcjgzOWNHYUxPMlpFeERaOW4vTVhudFVZTm4xdm9COTFUWk5DanlQc01a?= =?utf-8?B?VTcxL1JKT0xsV0hab1djTjd4M1lOM0oySlJPT0xYMG1sU3p6R1RETWFGSzhL?= =?utf-8?B?RWlocHdmK3p5MFU1WmZqazR5Q29nVmF6M3JuQXJ5bXM4cFpoRldxb2tXQm1h?= =?utf-8?B?ZWtNaHJRdEkwc0NNcEgrbGE0WC9yeWt0bXZsU21aS3lBYkpuV0s1NXJkUFJa?= =?utf-8?B?S1FpVW1SRVN3T3E5NWNGU2tSVGZYdEZSUkphekVlaXY3OHNldG9hTGtSV09L?= =?utf-8?B?SFdmeFpFQi9POTJYOWMvM1ZobDFSSktZd3FhVkVKMlVrQjNObWNkZ0FkYlZu?= =?utf-8?B?N29sNlcwSFA4MnNCbG1ETWMvOU9VRVE4MHo1V3IyenZpc2szVkJYRDYvZitU?= =?utf-8?B?SGJ3ZDdYamkyWnNPY0hiMHFGcWJlTnRpQzU5Zjlxd0JEbUV5RGJPdEZvMmlp?= =?utf-8?B?VjdvZ2IxWkt3TFQwRVh6YkVOWkQ0aUdPaDk0aDdTVmVENDIrOS9pR0Q2NFZG?= =?utf-8?B?bEJ0aGg1NHdQaXFwS3ZMLzBFWjZzZ2ZpYzFRQXpqMFZtU0hqQTdWendyVTZw?= =?utf-8?B?SXQzOWFxWEtRb1ZEN0ZXdkpIT21aa3FrbkFwRXZiZWhUc0tjOWdWOXlBT04z?= =?utf-8?B?dXR5cjZ2aTNhQnJSSEgwaE5sVWNBd0IxWFJLNkV2WVBFWncrNG11N051U1Ev?= =?utf-8?B?blMwZGFGT09nQU5IWmRLUVQ0YzZOeFJOTXJYL2dIdHFvS2o1dG5QNVhBbzFU?= =?utf-8?B?MXc1eTJkekM1eGMxMlVhS2ZMblJ4SURCUjErWXFna1p3SnhUa3orWEwrYTdF?= =?utf-8?B?aE1QOWlodGtNVCt3YU9zbmtwd0pqZnhRKytjejNXZFl3eDQ4Wm5PQWRPdkRX?= =?utf-8?B?YStwaEh6cWtySU5vWUpkWExCVEEyL0U2TUwrYnlmUm9ydFcrenhRN2hJc1ln?= =?utf-8?B?RXdGM3R2L0JIRU5FSmJZUmp1bk1qN25QakRMSHNOeHJYZTlodEJVb0ZjMDYx?= =?utf-8?B?VExzZjgxWk5lV3h3TEtpSG1SdnJYczlDbGl5cjV5VGZlcW84djhmMGdKTGdF?= =?utf-8?B?Q3MyVkFKL2poKzJ3Rlc4cnlGVGU4ZG1aSzI5QVFSUDhPbE9qOE5zSFozR2Ja?= =?utf-8?B?TDczVmlDNDlnNmVyZmRUZGJ6WXV3U2p4Q3hHNERWMERVaEc5WEJ3R0VQOFRo?= =?utf-8?B?blNVZzZhUjhwM3hDR0hQMGJReDIyeitQcmNncUtOSzI4dEdGa0tuNTJrR0Zp?= =?utf-8?B?S3RXVEszQzRSemhlNU9Bb0NDWjNFRE9pU2gxNWJZWGtFQ29DcG1QRWxmeDBr?= =?utf-8?B?YTJSbXpWK0VOY1pQRkNCbUJmU0RmOHVJMGtWQmxlcXBmYkZyUktjS05JN2Zy?= =?utf-8?B?WW5KbldVQzRaSlpsY1JhdUFjSFUxdGtjczY3dEZWTGVaMnQ5Q3BXcDk2UDdI?= =?utf-8?B?K09MVHJhSUJQWDBuNUFwNDF5Z1dtVUQwZGZYSUI4ZDRUYWRPY1NwZDZzZnpt?= =?utf-8?B?ZHU2a3VVTzV6Wmp3OUt2OE5LMkxhNWlaaEZaWGtxSFhFOWgwRkJFSFltRVAy?= =?utf-8?Q?XJqwDCUxD09N6GQrRNu9U8NTs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7a839ac-5ed1-41c9-c7f0-08db18bc8dcf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:17:11.8929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QTBluK9QvONMpJpHDFNYIMHQ4bBFasZbEWJk31nkQpaRBdHijyUdQtzdHi8qHeQ7J5aUWvpLRuFCrrlv+5hnIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8074 On 27.02.2023 13:06, Andrew Cooper wrote: > On 27/02/2023 11:33 am, Jan Beulich wrote: >> On 27.02.2023 12:15, Andrew Cooper wrote: >>> On 27/02/2023 10:46 am, Jan Beulich wrote: >>>> On 24.02.2023 22:33, Andrew Cooper wrote: >>>>> But I think we want to change tact slightly at this point, so I'm not >>>>> going to do any further tweaking on commit. >>>>> >>>>> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >>>>> updating the non-SVM include paths as we go.  Probably best to >>>>> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >>>>> only got one tree-wide cleanup of the external include paths. >>>>> >>>>> Quick tangent - I will be making all of that cpu_has_svm_* >>>>> infrastructure disappear by moving it into the normal CPUID handling, >>>>> but I've not had sufficient time to finish that yet. >>>>> >>>>> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >>>>> disappear (after my decoupling patch has gone in). >>>> Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? >>>> The latter doesn't use anything from the former, does it? >>> It's about what else uses them. >>> >>> hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always >>> included in tandem. >> Well, yes, that's how things are today. But can you explain to me why >> hvm_vcpu has to know nestedsvm's layout? > > Because it's part of the same single memory allocation. Which keeps growing, and sooner or later we'll need to find something again to split off, so we won't exceed a page in size. The nested structures would, to me, look to be prime candidates for such. >> If the field was a pointer, >> a forward decl of that struct would suffice, and any entity in the >> rest of Xen not caring about struct nestedsvm would no longer see it >> (and hence also no longer be re-built if a change is made there). > > Yes, you could hide it as a pointer.  The cost of doing so is an > unnecessary extra memory allocation, and extra pointer handling on > create/destroy, not to mention extra pointer chasing in memory during use. > >>> nestedsvm is literally just one struct now, and no subsystem ought to >>> have multiple headers when one will do. >> When one will do, yes. Removing build dependencies is a good reason >> to have separate headers, though. > > Its not the only only option, and an #ifdef CONFIG_NESTED_VIRT inside > the struct would be an equally acceptable way of doing this which > wouldn't involve making an extra memory allocation. That would make it a build-time decision, but then on NESTED_VIRT=y hypervisors there might still be guests not meaning to use that functionality, and for quite some time that may actually be a majority. > Everything you've posed here is way out of scope for Xenia's series.  There was never an intention to extend the scope of the work she's doing. Instead I was trying to limit the scope by suggesting to avoid a piece of rework which later may want undoing. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:31:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:31:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502496.774332 (Exim 4.92) (envelope-from ) id 1pWcf0-0001Q2-KD; Mon, 27 Feb 2023 12:31:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502496.774332; Mon, 27 Feb 2023 12:31:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcf0-0001Pv-Ha; Mon, 27 Feb 2023 12:31:18 +0000 Received: by outflank-mailman (input) for mailman id 502496; Mon, 27 Feb 2023 12:31:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcey-0001Po-GD for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:31:16 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0606.outbound.protection.outlook.com [2a01:111:f400:fe0c::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a0529c80-b69a-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:31:15 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6848.eurprd04.prod.outlook.com (2603:10a6:803:13c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:31:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:31:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0529c80-b69a-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1qlpLZ8rEyz9DB8byEOguHhF7THqyGQw2PK5OJLNqAbWcsiAWlc5TF4e+AHaiI+mXezD/MWZD/Ppynlo/Es4BldacBsrvKJQLp1XFbw6aLCZFdYdpG16o5cX/1B2x8oCqnkveno9lk5T17FRfMNjD7S/FO1cfbWmrEFq79nJHj4O7hZLMyuzim77LS/DNzwjbt5m38Hj0DOn40a/U6M/EUrYE+/dugmqksB39mZ6pVCAIdFAdf8PmodHiX1owSgaxxszOwDbPNwXhZqRKdykvgpdwcDVtsO9yWCwxQvHF5wqjxZ8SE4zzo+5yd/oHaprdv594yk00U/o8UhFecDXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HV7PqWQSzHcfNqI/zrUSn1mT7H2bAdoGk7sR4Shd2oA=; b=R7p5YXnCP4Vg22ZkRhqbqgu7f2Tx+1Vr+SeF717x+kfloLF0/Cclk4O1zS32P1rhASyoPHm54r2ts8j5Ur3RaUr2c1uBHtG5odOsCIOs1/eBwg44xxjuAx5sjaAm2W/ATb50u3zs7CDqklyEwY4wxPmU1TBTUzntdq38x0o4JPZAxB6uuLXCJ8yYBnww2nI0tGfT2hj0YTb1MeM0g4CJWunYraV8P7g5oq4lLQOBcXvbVEXQcRMChIu5mm1fYMXgp+rVndv5xbGgCnVAkXPA2fj62PVgwtw48F6DJa9iw72qr4qL18rog9LeRvFO2HRC2/VHXahGhYRWs41cziXN7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HV7PqWQSzHcfNqI/zrUSn1mT7H2bAdoGk7sR4Shd2oA=; b=HJaKiOtA/IQsL5JDNQbxfX3i8faoeO4AUmWemxEsZ9dzapYYy4uWk/f0sljW+HCy1ZXX4KimBRsxxDaIISviKMQRXwSlPxFrOFev6IfN280VUmXg/6nXdKF9TnorUmvUFTP9Cl7Gy8geO7iyguHEXZZEeGKCfFE3d+Hln6/2srjVPIgo63nKb4+Im+MuXQUHdozLg1wQl8uFtYzW/OM5taXOIRqKg7XIjyKWccqFrXWeIWaDHe4P8a7M1BiHXWqhJrLChSaIykUGrP2cnjN0V4AZlX3dPCOgbSUoB+iKD/BTA7nCPZEfGz99/9IehRPB1YP1lxYrPWFHJ2qCxD/KfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> Date: Mon, 27 Feb 2023 13:31:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230227120957.10037-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6848:EE_ X-MS-Office365-Filtering-Correlation-Id: 18ad1304-38ce-4d7b-c154-08db18be8283 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ozHfvPq+NgEB3u6eGwFn58Qwk0Y+w1pIFpCC5ZQv5KM0VFdDew660t+PREqoMjLr/a3WmWpqzcYqomV3OaL9nauE8906XVicqwOLslFgE9kDyuNopee0titobF4lbVcC8bqWTzKYhKbq9i83wjEwiVU9aPA94sMApHPJxv474WDoeB5JLnjc0oqyqlsbTp2zGBz+QyLZPH9gKhZouDlHHk4vEz7TqKudSc1fTELlLXpkk820PZH2eGrfg06eU6LJRuRbvbHZdaHIzTHmx8GuXB979r1WWIfggTqNETk2oBin2etxO7ni4uvObI9MnEIYburcN8ZsUzgWKJOWxkEnidAvKK2kgWY0ZmY+4wGj2qxGrWzViwXMIorGLXK9CXHVI+ryOFwTYf6mHi4+y3Q4dyXHvwtSHGeZe/NtPI3wKt02FZQt46yAazVIM+H/XF3s96ZaYpYI092mheWuqh/PFazCfTGTxQwOHi42cQ/vO7ow8caj2zeVntMzq8u2uKvnmCIqvnUuoEHfOmfAjxxWfmCyEkFsHoDJ1/4e6VLmUdJAFKMLUR4+RuzY1XmSYVo+YjPpYCn9G9SiNTYPuLd0dRBStAQwfwiWv+kNX3kT0AL0tgWnksE7Z2aHDy8PdKd8kE9cml9SMCSvP396y7DFrO2J0IT69MG8xAvGgEklUiMm0CTPXOGWYEWIeNW2zwdVyQxNH867tukU0DTJxcyCb9co4uyluOOFaXyRLHe9cX0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(346002)(39850400004)(376002)(451199018)(316002)(37006003)(2906002)(31686004)(31696002)(6862004)(36756003)(5660300002)(4744005)(8936002)(86362001)(66946007)(6512007)(6506007)(53546011)(26005)(186003)(4326008)(8676002)(66476007)(54906003)(6636002)(38100700002)(66556008)(41300700001)(2616005)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHlQVkp0TUdBc0RIdlJwNHA1RTBzWjllZWlHUVRXdWNjalBFcjNXSGo1aUNv?= =?utf-8?B?QUhpQk4zeWZzVi80UFJzVVVqTzJ1UkFSSlc4bzQybkVGTzF3VXpiempFYnEr?= =?utf-8?B?QTBKeGoxbUpKUlpGK3dCb3V5bnJWS043akR1MXR2UnRETjFjOStPOHBPY3NC?= =?utf-8?B?RVJkL1p4dEhhWXY4aERsOStGbFFZcy96VjJvTDZHMXhhUjU4bVRZYjNvQ1Uz?= =?utf-8?B?TElRSGk3ZThHdWc1VGdJS2hQT1NWMGw5UVhIWERtQ3NlTTZQRUNJMkJmQkxW?= =?utf-8?B?S2FvamVJSmZNZFcrK2hydUhGQmU1Um4vVUwwZ3d2TEs0dW5oQjlDQzhhTU11?= =?utf-8?B?Skp0SjcvbkVkWkw2eVUrWDh0ZkxOT1pzQ3J1QUVFcEFtTzN3Z08rQWZyMito?= =?utf-8?B?eWZ3M295ci94TXlZMTNvbHVPRVZndll1WWhYcDlURFBkY2J3SWxVQ2ZHbmxT?= =?utf-8?B?M3JjZUhOMXMyeGFSRXo3NDZJM1BQWXJ5eTJIazdieDZkZTdLRXVhdnVjTTI4?= =?utf-8?B?TVk2Y2V2RTVTUVh6ZEd4L3lyQmM3RDZrU1VnZ3JwMktsZ0FhVEtXRkpONldj?= =?utf-8?B?a0d6K1hWbWpYT3ZZUGZMMGJJTEFva3oyY3JZRGtESHZ1d2Z6UVVFbHUyR0xM?= =?utf-8?B?T1pudW9Jcy8zU2RDUVpiVWdIS3I2elI5UEdYWXVDVDBmeDUzcEtOaVgrVTlM?= =?utf-8?B?eGozTG1MOXBYaHhKVWhIcDQ5YjcyeXZxS05KWVhrQUE4V1NpMHJQbTBJWHhE?= =?utf-8?B?ckovZ21Ybk1CdnVIaXJ4VHFqckJWMHhjUGtMN0xXaFZLL0hXQ2RXTC9vVjdx?= =?utf-8?B?djRYMTB6RHN3ajgyNlJxZHNHNHpoYmErVWhXRVN2dldQc2taQVJDVWxUb3lM?= =?utf-8?B?YXd2L0hXbDlYNDVMakF2S0d3TFhhaFBDZzlkanhJU3ZRT0ZaM1VXdEo2L05K?= =?utf-8?B?NlROYUxwR1cxY0xuc0h1OUJ6Q1VjbW5RZ0srWnMxeU5CTFNnK3dHNWpncllK?= =?utf-8?B?alRPQ1ExT1BvbnBEejRRQlNzdTZUNks1WDJpZUIwM1F3YlYwVURKVTBLdzh5?= =?utf-8?B?bEVMbmdWcldVZm1NekRJQkNpTS9qSlJsQmx0a1hCUU40cHVuNjZxclhCYkJm?= =?utf-8?B?Mmt6a1ltN2Fzb3pHbVo1bWgzalRHUzFFL1JGVHY3SXVDbWVzTGppTGlPd2tR?= =?utf-8?B?cngySDNydzhOVjR1MVA1WWZDTTRGVWtpRWxEZjNybWhzYndJZmUwOGFyV2xs?= =?utf-8?B?Vm9teWlaTXlITWhmbGJvMm1yOWhXVUpVRFBOSFJHUlJ4bzJPZk84Sm5kaGFI?= =?utf-8?B?WE9iT0V6a0RUUWt6d3hOdkVWYkhmOWd0cUlISjNpeU5QTE02RytZa2VTejBv?= =?utf-8?B?T1BEbit6N0M3Y01PMG05aFR5eWRyd1F1dEhlMUMxV2hwNDVsaWs4N1NQUXpG?= =?utf-8?B?QzJTTkJmbHQvWU5FemFEN3hvVC9TalJxSzB5Vk9xdG9sdFFEVithczI4UDR6?= =?utf-8?B?ZWlzNlNSTDJtaktqdFkzRlAvUGNVOUVzeXI0VE5mWC9KQzI2SmwvU3dhbStK?= =?utf-8?B?SDFNU0hkWXE4L1RPek1WVjFvMFhsUXJHTjNVUG15UFJXZ29FTWlKT3JtMnh1?= =?utf-8?B?bnRSMGY4dlBmbG11UHJ6SWM1MlVuRGRkdjBEY3l6TVRYNEJKcVh2elpmeUx3?= =?utf-8?B?QWlydHpKMld4UWs0WHhLU1ZXeG5XTFJBUTVSWDR3YmlIcHVtQXFhYTFBbm5h?= =?utf-8?B?dWw0a09yY21KQzBHWDA2RUR5eDhEbFdubStTbVFQUEdlU2R2eDZGeWQ4UDNq?= =?utf-8?B?VDl3M3gwaExHajQ3NTkrcThHZVJCK2JNZVdjU2dEQTNvWFBTVUNvRlZHTGVt?= =?utf-8?B?eWZMdDZYZTRHNFczVFVtU09yOXJCSTFrcllNclRpNVk3MXFJa1lkQnhXZ0xT?= =?utf-8?B?REkxeC9EcTNMQllNOGtZY3hVZThta0EySXkydmNKTEIyRFhaVFpjeGQwcE1E?= =?utf-8?B?OVRRM2VnajJSQXV5cnczOXQ0eVVGVlFxbUFpU01OQ0d6U1pzT3NrQWtLa0FG?= =?utf-8?B?Y09RZThLaXdvMk9VZUNyRVNPOFBXbXlHZ3hEclJadzE5WDFIT1dqcWh4SEsx?= =?utf-8?Q?WJ6aXpje44E8pRu4pTted96ze?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18ad1304-38ce-4d7b-c154-08db18be8283 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:31:11.7145 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1YW5QoBw4LLTV05ZBAKfGlQylvHZ573oB8ocKN6zO/tnsfnij95TtYJof96N8IGUufPjo7IdjP3yw2GAed+/Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6848 On 27.02.2023 13:09, Juergen Gross wrote: > --- a/tools/firmware/hvmloader/util.h > +++ b/tools/firmware/hvmloader/util.h > @@ -30,9 +30,6 @@ enum { > #define SEL_DATA32 0x0020 > #define SEL_CODE64 0x0028 > > -#undef offsetof > -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) > - > #undef NULL > #define NULL ((void*)0) > > diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h > index c7f974608a..926ae12fa5 100644 > --- a/tools/firmware/include/stddef.h > +++ b/tools/firmware/include/stddef.h > @@ -1,10 +1,10 @@ > #ifndef _STDDEF_H_ > #define _STDDEF_H_ > > +#include I'm not convinced firmware/ files can validly include this header. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:34:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:34:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502500.774342 (Exim 4.92) (envelope-from ) id 1pWciA-000201-4d; Mon, 27 Feb 2023 12:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502500.774342; Mon, 27 Feb 2023 12:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWciA-0001zu-1a; Mon, 27 Feb 2023 12:34:34 +0000 Received: by outflank-mailman (input) for mailman id 502500; Mon, 27 Feb 2023 12:34:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWci9-0001zo-2X for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:34:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15cd0b57-b69b-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 13:34:32 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B1BA81FD63; Mon, 27 Feb 2023 12:34:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BF2913A43; Mon, 27 Feb 2023 12:34:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bA3QHFej/GNRRQAAMHmgww (envelope-from ); Mon, 27 Feb 2023 12:34:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15cd0b57-b69b-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677501271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EQtS2CvPLO4bZlv8n7hFzPJd0jivW3NjQsa4viiIQTY=; b=CfG6v9wAI9BP0HIhNC/9wVE7kOimnT7UFEJrsM6ipqhCeYsRyL654kAy8QjyMxGBDOA+aN xUa5rtaS6iJUh/4p9MlKXnGUL+zEPS/kbHuQoilbedg6HKHtOmkoBdD6z5XpWS2JKS3uR6 DLlwgnnWU5UCtKoWIjfa1al8y/+tSlg= Message-ID: <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> Date: Mon, 27 Feb 2023 13:34:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> From: Juergen Gross In-Reply-To: <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------B3NoBSFE4FL0IJ91z7tB9Tdq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------B3NoBSFE4FL0IJ91z7tB9Tdq Content-Type: multipart/mixed; boundary="------------USKo6oDw0vBDCvh5HHhPMgun"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Message-ID: <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> In-Reply-To: <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> --------------USKo6oDw0vBDCvh5HHhPMgun Content-Type: multipart/mixed; boundary="------------5cM26yWlPgej9SkUmRZGQ1Nw" --------------5cM26yWlPgej9SkUmRZGQ1Nw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDIuMjMgMTM6MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNy4wMi4yMDIz IDEzOjA5LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEvdG9vbHMvZmlybXdhcmUv aHZtbG9hZGVyL3V0aWwuaA0KPj4gKysrIGIvdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL3V0 aWwuaA0KPj4gQEAgLTMwLDkgKzMwLDYgQEAgZW51bSB7DQo+PiAgICNkZWZpbmUgU0VMX0RB VEEzMiAgICAgICAgICAweDAwMjANCj4+ICAgI2RlZmluZSBTRUxfQ09ERTY0ICAgICAgICAg IDB4MDAyOA0KPj4gICANCj4+IC0jdW5kZWYgb2Zmc2V0b2YNCj4+IC0jZGVmaW5lIG9mZnNl dG9mKHQsIG0pICgodW5zaWduZWQgbG9uZykmKCh0ICopMCktPm0pDQo+PiAtDQo+PiAgICN1 bmRlZiBOVUxMDQo+PiAgICNkZWZpbmUgTlVMTCAoKHZvaWQqKTApDQo+PiAgIA0KPj4gZGlm ZiAtLWdpdCBhL3Rvb2xzL2Zpcm13YXJlL2luY2x1ZGUvc3RkZGVmLmggYi90b29scy9maXJt d2FyZS9pbmNsdWRlL3N0ZGRlZi5oDQo+PiBpbmRleCBjN2Y5NzQ2MDhhLi45MjZhZTEyZmE1 IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvZmlybXdhcmUvaW5jbHVkZS9zdGRkZWYuaA0KPj4g KysrIGIvdG9vbHMvZmlybXdhcmUvaW5jbHVkZS9zdGRkZWYuaA0KPj4gQEAgLTEsMTAgKzEs MTAgQEANCj4+ICAgI2lmbmRlZiBfU1REREVGX0hfDQo+PiAgICNkZWZpbmUgX1NURERFRl9I Xw0KPj4gICANCj4+ICsjaW5jbHVkZSA8eGVuLXRvb2xzL2xpYnMuaD4NCj4gDQo+IEknbSBu b3QgY29udmluY2VkIGZpcm13YXJlLyBmaWxlcyBjYW4gdmFsaWRseSBpbmNsdWRlIHRoaXMg aGVhZGVyLg0KDQpUaGlzIGZpbGUgb25seSBjb250YWlucyBtYWNyb3Mgd2hpY2ggZG9uJ3Qg Y2FsbCBhbnkgZXh0ZXJuYWwgZnVuY3Rpb25zLg0KDQpXb3VsZCB5b3UgYmUgZmluZSB3aXRo IG1lIGFkZGluZyBhIHJlbGF0ZWQgY29tbWVudCB0byBpdD8NCg0KDQpKdWVyZ2VuDQoNCg== --------------5cM26yWlPgej9SkUmRZGQ1Nw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5cM26yWlPgej9SkUmRZGQ1Nw-- --------------USKo6oDw0vBDCvh5HHhPMgun-- --------------B3NoBSFE4FL0IJ91z7tB9Tdq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8o1cFAwAAAAAACgkQsN6d1ii/Ey+l rwf/awPF65Z8Pyr3ckfDvyJz+f6rPTUnAZTJLnvnrxiEg782R5zWMJZucbbSnyJCFP5ujIkc38f0 be7Sc1QW6gZREoT2h6xRy020sYZ4LTpjR0wYPb5JlsHqNhRfkg2E7rcPut9q8iGCGA4DxbDNaH44 d/OSTdRcbFBrKWIgZNl0wY75BP1C34Suk+w/MRpsJzbZv/ZrzCKjliwWIOVve+EZUzj3CXF3i75n ydsWcdKcWpEUI12c45GTZxdf3IIQUDIG792Apv2Bu8m1tQy6wDZDTV2v+75YmxbXpnpGyGFiEL7S K7mVz95GkWrvH11Ff1vWCYl3YerDWGGHqhW/L9Z9OA== =zBkh -----END PGP SIGNATURE----- --------------B3NoBSFE4FL0IJ91z7tB9Tdq-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:44:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502508.774352 (Exim 4.92) (envelope-from ) id 1pWcrB-0003nP-2I; Mon, 27 Feb 2023 12:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502508.774352; Mon, 27 Feb 2023 12:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcrA-0003nI-UP; Mon, 27 Feb 2023 12:43:52 +0000 Received: by outflank-mailman (input) for mailman id 502508; Mon, 27 Feb 2023 12:43:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcr9-0003nC-DX for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:43:51 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20610.outbound.protection.outlook.com [2a01:111:f400:fe13::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60b1c5a7-b69c-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:43:48 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8900.eurprd04.prod.outlook.com (2603:10a6:20b:42f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:43:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:43:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60b1c5a7-b69c-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThhvA1leYAi6cNI6nEY/lrsGeSU38wVxbQJ7/qsnLhV9PUYufEFj8NUxETkWxTifpPB8qQuzdRb9dbRIDgt0Jlfrln07lnBv1RYN0lwTy1KzTCyoFXo4dWncXgUBWYEtehJMrXmDXZtDbUYzaUBFbol5bJ9eubZEBp+uRgLmtGBJIsHVlTUTAsEHmMw6Vx5DUSvvb+k4yFm+0mupzKex396jM3JR3ZhEsHtnsmweoEuPRqwRCRa5CdKpdxEai13/5c9lU0KnietUX2RT8sm/ieF92QjPTCj0Yr+UHDY8kut4c2o3XGTgjpd7O871oHDwcN5k1QNcliTMuVS2q3/ijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0kF9jI8hKrUSJfgXViDlmp1tkP4Wv2f6t3kdegWPjQ=; b=YXVOzT6DipW/ss1Omg4UU/DpGMBgWOMUvIxybHMDWXyhYl5VXbUBxcyei8rNlA/F0SsoQrzwJWv416G9LDQTMKU8bvfthZlEN87jm9HAd2kIX+qNuiMGXSQFdQlyVPFHbEJQyjoNjCZ5NGz8b1BRhJR5zCmx1V6x4LdcM8K2CjwroJITN/hQB/OyLiLYJbLYrr6PVfurj9gHaSO26EER7PLUe0JqBvy6w71XD1Fd7BZsYfUocgLQU/4DKKWVvbI6udogd7LjqIgUCmoWVDJN1gxJJgtRrQO27Pbs4oEWFifz8Sm9EArCcyyJiu57NFF6+gWgC96V834gltLn/tfRGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0kF9jI8hKrUSJfgXViDlmp1tkP4Wv2f6t3kdegWPjQ=; b=E3aPtzkOWvQZmiCAZm/G/Cy2tUdYHQmguccpo2X84YqtYDNVvvRuxPorDa5YpkcX2UW4jS1WwzExDvg8BTC2EzXVEplIzSyFQrm03zkdRTkykKE8lKJKnDTuatX6+VPdrOFhbNoQ4Vw7ypqX/96HcFh8WEHc6QKJMkcGGBb2OpDC7p4Y5eHDjQePOrFIo1ktF1+KK1zVB6niT7D8nYox8t1OPkVJd5KeZqA9JauqnR3lQYOQdPdcop3AGLS6Ih+qceod77+b/6n6mInJhXy//BeEmPuitptQxjf2RJcIl/ARssdsJQ3gEALzdmuc/+Wt2VwibX2WJ2qc4hYCmfPPVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 13:43:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> From: Jan Beulich In-Reply-To: <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8900:EE_ X-MS-Office365-Filtering-Correlation-Id: 33724d6f-ca40-4085-f3a5-08db18c043f5 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xnbmBrjhFfAzs13T0GZfWXNBAMy8Ny4HV+0UFRPKhrHGTVfYCeU3DD4+i7RCMExpkLXGO/ZdHMEkBSzkM1wvMM6brXviyASk7oaInDk+FJ1TZXjvI8+ujsVw/gOgPU2eWaK6HQkP/3fTgZ10H0pWcX6p07lh/EY7T8o+NMmUTuguJ7YeDPzo6ghXGn/vXy3IKwVIqGelXU3G9+/8YnBeIutcAF2LOUmD/rL/QyMj0zkqw4AsBJ0Z8ieyCqiBpeUEUV1qGXZ+q4756oTbgGuk/rdyRIfIzx9a80aJtFvmFL4jul277L7bOEfmy+vMX5Yd2WCYL0HlqekzvsR8SE3u5Tv89JLs7gedF+0Oq3I7KJ38fjMZSHjpGVHdA/x5zk8LgO2jN21on/LrcUKaYEYYyqk+sDzmHrdoU73Ig39Zb8azRTnMWSmFHjRl0+19iACuXSx8wr3CHVP/WiVvONBZHiMWMN6z2kXyYkGg7c/UTNxDW4Z+zxLCMNBnoN7Q5t0+NjlG66Nd6c4DDceAeSsRI6b4m00RxmEsBKWLT/ysKRSMxEgoq44kBuLjHX83rzwUr3A1Grwedp+yIGA3go1EM4z0f3ww+d2zkdJ1KGwYrleFhZJOIg5Ng+XB8gX3KI+kHNMWERvQHE+IKI46eVFYyzKjMAEyVym6ulJI/vm/0R8Wfxv2zsrMLnM+uGfxh4AVCKWlPv++7B9S8GeGV62Ia0SxCQ4K/8DwHgfO3eJKqqg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199018)(31686004)(2616005)(6486002)(37006003)(316002)(36756003)(86362001)(31696002)(54906003)(6636002)(186003)(2906002)(5660300002)(8676002)(4326008)(66556008)(66476007)(8936002)(41300700001)(66946007)(6512007)(53546011)(478600001)(26005)(6862004)(6506007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWxGaC80ZGJOVzhrZG1sWFRMRHpYRytHUmMwMnhUNE94dG4vUU5Xd09OeDN5?= =?utf-8?B?elk5Rkh3bFI3VzVLWWdjQ2syTTJ3WFdsK1pqbUsvRkZZSUpvdk1COW5sRzFa?= =?utf-8?B?RFRnazYvSTRzZi80c2lCQzBGMFphdDUwVld4Q0VLUmE5NlRmcnA3WFZDMEsv?= =?utf-8?B?VE5pWUVjL0w0ZjNXMXJLYW4va0lnWTB0NGE1STRqcmx4MlU4dTVvLzBIZ2VD?= =?utf-8?B?VUkvMXJ4Uk1nR1pIQ3dNNWRrcFI2enY2clJmb1RPaGd1OFFkaTQ1UnR5N3R0?= =?utf-8?B?V0pVMFF6a3FVOXBuZlpCQ0V6SkhwVzMzcGx1S210WkFUNlVjeVhIcmh0QXE0?= =?utf-8?B?THZQWXhDQ2FOaENoQTB0UkdtSkFDTjFsRjk4Nyt2OEVRT05ndm9FTXBabmR5?= =?utf-8?B?ZnNUallBeUxYWXUyaDVmUmdwaVpsaFdUL052cU1ZQWoxY0lmZjlvMHVNVU5B?= =?utf-8?B?cTVlVjV2eE9vWEtra0UwcDJrbUQzaDVqaHdjMUo3Mkx3Y0FLQ0poU3hEUCs1?= =?utf-8?B?Z2VEMm5ZMHV1aHRsbHl1YXUrUGZkY2YvV2prNnBCbTVrcndWUmozb29aMjQv?= =?utf-8?B?cG12YW5BT3NSSlcxRGZMZjRpUWFWVGxoNkhGWmlucTRPQWVDWmVDV3U1NjFi?= =?utf-8?B?MHZCQ1hqcWFQeC9sMnFwbEVIOFluNHM3eGxYcWsveDJTc0h1M0N3UXQ5ZVBB?= =?utf-8?B?aituVFBLQ2RCQnUyYTBoeUZHMWhEek5PUFVnMDFGeXpPQTBja1MxNXdTMzVz?= =?utf-8?B?b3Z0OVlQNG1CVVVhUnA5WnBwRndZSWVoSWZmQ2Z3dmJ4TlhoR3ZsaW9NaTha?= =?utf-8?B?NjljbVg1L2h3NzdHWWcrZCtCcUowWHp0MS9CVzZpc3phWVFCbGtsbE5xZ291?= =?utf-8?B?elBtSjI4Yk5Uc3dLVkFGOU1mdURkc1hSRVJPSkhPN2RkWWJabkQ5bHdxLzdi?= =?utf-8?B?QlRSNTBFSVFSaWxsYjc1SVRlRkJMNnV3eWI5UjhPMkZKTExUeUYyOHNjWjBV?= =?utf-8?B?bTBBTHBteFdCbEtDMEFzWTJKbExnZ3kwYzZKY0NhU01VVFRUNzl4dUpYaWhK?= =?utf-8?B?WHhFVFFpTDNSMHZMMHhibzgydVZzNmVTL2poTGlmVkJ4Z0Y5Y0l5SWovODlD?= =?utf-8?B?NEd3Q3Q4V0F1eks3UWQ5WVZzWVRkdlBOMG5IYzlVYXRLYi9CYmRZclYzVmFP?= =?utf-8?B?eGZ4bkhUR1hFTWUxcGpUOGhBR1dhQzNBMit6NkZ2R0pEQU9hVmFocWZHUy9O?= =?utf-8?B?L0J2cm1yN3hBSE5WbktVVTEvV2wvZWFJMEJLbUdadmszbTBuZFFJc20zSjB4?= =?utf-8?B?UEZCeHFGWFNuc0ViSFhGM3BMWlRTbnd4cVhtaWVVVmgxOXQ3U2E4T0tYbjZ2?= =?utf-8?B?WFhJcnF4UUZQTmF6YzI5V3JZMURJLzIzZmtoTWVmTVl5b1FCRHlTYjZJRnlX?= =?utf-8?B?elZQNmo4WEE2elFmeHZWcUgxcXdKREZvZXFQWFo2NlErNFpKU1F4WWpENFJP?= =?utf-8?B?QVN2bFpjUXhGYnAvaTR0eTQzdXh6VG9JZkxJeTh1cjBQTzd2YVhYZ210N0RV?= =?utf-8?B?R3dIc0prbGZoWkRDcGFHMjA1UkloUmxtK1EwdGdhWW1tWXQyMTVKL0hWZGpU?= =?utf-8?B?c0UwOXpGVVZnM3grSzcyMk5PSkNvdFBOTjlmOXFENHRBQWhJU1lmMSs3K3Jn?= =?utf-8?B?RzR3eUdrOWZFTHprU05DRFZQMkdiVUZWS0FoY1B2VXIrQUhZZkVsTTA3UlNu?= =?utf-8?B?MGlxMEU5N3hmS0FMaWpyYlBja0ZDZU9TY3ZYM3VsL2o3MmVUV0M2V2EyWTg3?= =?utf-8?B?UHRwVGU4YzVUakM5UHVlNGZQbGhLNkNpUlZQSEN6UEJhVm9ibk9lK1V4YU40?= =?utf-8?B?V3NCeHZ0ZTJjdE1lR052S200aUw3SWk1czE2UEJENDg3Y0hueW9JVCtOa0tI?= =?utf-8?B?aE9Ba0hLcDRHbldZR20wUG9zNG55ZmpjYWJ4K1dqRlBXdVptd3NCeVpzTXNm?= =?utf-8?B?Uzl4Uy95aUI4OExKOW9kS3hqOXVBZTE1dkNWWm1FbjJCdlhjK3dLLzJKNTlz?= =?utf-8?B?UlpHYjRMZVVoVUowMVRqbEMxcDRmbDlteE9penZ3WmNHUFM0SndzQ1I5M3hX?= =?utf-8?Q?9xOKkhFEakydHQeZfkGjV8OQm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33724d6f-ca40-4085-f3a5-08db18c043f5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:43:45.7911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: //hcn+xenzzu6Z2gbuipmTin3ARtzRNGXbBreJpD5hy5ts4MWwnIYjLxOdDdWWdcaf2sduKxgGuycgO/++XYxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8900 On 27.02.2023 13:34, Juergen Gross wrote: > On 27.02.23 13:31, Jan Beulich wrote: >> On 27.02.2023 13:09, Juergen Gross wrote: >>> --- a/tools/firmware/hvmloader/util.h >>> +++ b/tools/firmware/hvmloader/util.h >>> @@ -30,9 +30,6 @@ enum { >>> #define SEL_DATA32 0x0020 >>> #define SEL_CODE64 0x0028 >>> >>> -#undef offsetof >>> -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) >>> - >>> #undef NULL >>> #define NULL ((void*)0) >>> >>> diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h >>> index c7f974608a..926ae12fa5 100644 >>> --- a/tools/firmware/include/stddef.h >>> +++ b/tools/firmware/include/stddef.h >>> @@ -1,10 +1,10 @@ >>> #ifndef _STDDEF_H_ >>> #define _STDDEF_H_ >>> >>> +#include >> >> I'm not convinced firmware/ files can validly include this header. > > This file only contains macros which don't call any external functions. > > Would you be fine with me adding a related comment to it? If it was to be usable like this, that would be a prereq, but personally I don't view this as sufficient. The environment code runs in that lives under firmware/ is simply different (hvmloader, for example, is 32-bit no matter that the toolstack would normally be 64-bit), so to me it feels like setting up a trap for ourselves. If Andrew or Roger are fully convinced this is a good move, I won't be standing in the way ... Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:49:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:49:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502516.774362 (Exim 4.92) (envelope-from ) id 1pWcwX-0004nL-PA; Mon, 27 Feb 2023 12:49:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502516.774362; Mon, 27 Feb 2023 12:49:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcwX-0004nE-Lt; Mon, 27 Feb 2023 12:49:25 +0000 Received: by outflank-mailman (input) for mailman id 502516; Mon, 27 Feb 2023 12:49:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcwW-0004n8-5a for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:49:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2840c840-b69d-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:49:22 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7664.eurprd04.prod.outlook.com (2603:10a6:102:f1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:48:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:48:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2840c840-b69d-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMSghBQdzAHlr7GroQifEUC3AZJhlJkWRwrBGkFu1tX9E+X+GdPd0bf5sWQgAWslRsOtcy7y2pISj9oR+9hTsFO0vHUvzZSMT/4qHKy/Zqh75hnULXIK+OYeLuOArzvw2/Wsi+gCdrxxfwMv33F9v+hylzwxdGi54L3p3Jt2u7Ya/Rtogs+vI99523uwt/HwMwkxSu2aRw8QSTlu1XbnoN6E/3rxnw4/3Uevyc9CsNDGDXK91x0xeD9Ob51P+gA6e1TcGS/woY+i/kfEcPGcHkQgvuuR1Tg8NgCrXJIOgrcLfb4dyvPuZE+47iSZ3iRy8IZaVZj8Ua2gyHyxTknveg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYNd/vAu8FAcVq62/90gUoPBlMUzk97g8RuZyolsCmc=; b=Q1reB2I1QqnNi2NNaN8pxmXQTk33x4Mo17w2eaoZDSnKmpFA6zklYAHVwCl3cz4Os3F3zP0Njs+XXLz5m60IJQAv12XmsBPA6WUQ/Jbihw+BlnNgz/irdB069IE10/qLH6hnlvfuj7QdMjMUph6YazKq316cAORwOu6lbHB+nPd/j+EVrWxG1JAKnuwtv08tFFOphRZ2+W5F4iIEdU23iIMQD2okICsm95H5KH4fpom59lGZ3oUI5m7FQ62ajElvnIwM84D4rUiMiYgyHbnldT9RpvkHtylzz5zGpLnE5tFqirrnNV6Kjl4XOGrgnPuQH9hOFY6KwaU1qG/xXq7Bjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYNd/vAu8FAcVq62/90gUoPBlMUzk97g8RuZyolsCmc=; b=3U9VZL93MKK44IMJ0OP2wCziB3klIKkVTCoSUrntyML5QVyvYWB+2rYKl6eIoLkmdGd03e7mnVpUZofyXidNh+GQltE6VJ27fzhcmvm1sRCNFCYCgh4kJFaxC5QrOF+XadeK/7IoHnmxn7ZpQ/TQS5jv3iv52kvz0HfnftvSY1USWwIAV+nff6rdKj8M+KY3sumlcZISnZHDXGpaJPcu7ibj8A2f+g8NxVXahv4zKsrdQEQdoknsXY8/mWaqeXs6qcalx0nVU90Px3E3zSH13x2pJM7bMu4fdlNFvmxmxoQA5HfGib6ob8NWXmFtxo8ug8MQLdEvgGxSryVpX7oq6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2fb6e5ad-9e25-9c63-7f01-8a3d55297cf7@suse.com> Date: Mon, 27 Feb 2023 13:48:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 1/5] xen/riscv: introduce decode_cause() stuff Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <397e6741438a8b125dc53945a74a58246fac4faf.1677237653.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <397e6741438a8b125dc53945a74a58246fac4faf.1677237653.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB7664:EE_ X-MS-Office365-Filtering-Correlation-Id: aa5e0c6a-9204-4c77-65ec-08db18c0fb07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C4ymB1zpHlxVa02qLichoy2q7wLl85JX3wAe4C026R9iGNIlcfRhqRp5JHmq9aSkEjuD0HCrTac/chGMbamqBqTvEsz/f2+gseu2bLnTWJVrzcig79lHXuA2x8xcv3q0HG6u2YHHsLkMZ94ogZuLxPCD2J26GUlXZzZ3yxcmyuS1SEUMBxOdG50QnbgyBS9lh0AB+fr1sRojl4rKIZsHpK0G3ZV72OhikpVEIkoeb0mbcIhQQdU0/yeGBJ0QiMQekS1ARqDwJ+kwnUX2dOpfqj3I7ohc+ES8tE2CAxzoaj1XrPlns8K3g1z2rOtjT6yQeZs9IDIFVU6okhfRieH99ls8gJM59qdikZ38o7+h8ybIEuGsvsKlGu9pJw4Gwl/Aeu90dzq/X+sgeA5m2D6m4EyogSlP82kPk24HcdaLZ1w8ZBGBk7gb/xzhveM0TtzWQT2XWcHiUs68nQlh3f3F5AAjKUZ/2tMhfO1SOCOtgmO80Y6MjK8kvIL95lYZONuCR5POBCut5MvDe9x6FhN0R3LP31uE7CR+m8H3jRtkplAKYrdzXRe2p3Ld2UMbKJ162MPfhJjt9x6y9oIPSUM8LkxH5YkbIiB6twkP7msVDDS8Ru6V6c6vxeljVNZFO6ItcQ7VRsjyNQUwAG+Q+viVrvlNt7ds11YdF+FVDs0IjvHbcUaj5Hu7y69z4jJhLcBwHS/SgZBdvRyt7827dtC3tA273LSnLMaYNgfn57Xok9s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199018)(2906002)(31686004)(66476007)(5660300002)(8936002)(36756003)(41300700001)(66946007)(54906003)(31696002)(316002)(86362001)(4326008)(6486002)(66556008)(6916009)(478600001)(8676002)(38100700002)(6506007)(53546011)(6512007)(186003)(26005)(2616005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFJzTWxURWt0L3NpOEdHbm5YQUREM0hlQzhmdElGZXdOWFM5RWRFOEUxUTNz?= =?utf-8?B?Tkt0bEMxUUpjSzNiY1krbXNxUEdpU2Rvd2d6LzUvcHI0L3pDWjdBOXgxeVdT?= =?utf-8?B?RXNRaTZIZjArS2NMZG1FN3ZTaTJWNTNPUmpydWYxZEFCdHNOczRJcmZIWTc0?= =?utf-8?B?NkJlQVh3dWx4WDFOU0pYTUZsSTEvejd0WWVjWGozV0FOTGNPbnFZT3V6SWRJ?= =?utf-8?B?UnBMZlpEOGxFVndaMDdkR2dXL0owdTh4UEkyV2dUejY5alZ5emNQMjlWeG5j?= =?utf-8?B?a2l1SWoyTTF2QWh6ZGpFRitEdmsybm5rQkdFaTJNSTZVTzBCZjNnWDlVN3RE?= =?utf-8?B?QjJuUTF0YzJvRVZWUkVvL3ZZVWNZZXNOU3pseG9zdjdoa1pNbTR5WnErNlVX?= =?utf-8?B?Um1meE9xKzNlNUxzaEtYcG1YU1pyTFZRSGxxcTI4SDFyOCtyczFmd1prdzNm?= =?utf-8?B?M0FRS2hhTkFZUEVPSU8rQ3dZV1VqRlNJNGtYdEo5ZUtCZkpYWjF3Vk9QMzNT?= =?utf-8?B?RlhpeU1wSFcxbS9UNVU2KzU5czg2bzVnTlVQaDg0RVR0MjU0ZkVBdDdmRnlp?= =?utf-8?B?VFp6ejhNdTU3S3hjN3J6UlB2TWJ0MWsrSWZCRHZhcHFaUE9qUEVzTnZzVEZT?= =?utf-8?B?UWx1OGFnOVkwWlFsTG5rWXlJR3kwTURDQUZmbDZDdGt3c1V1TmFmeEpsSmxm?= =?utf-8?B?WUtYVjJzSGs4anZCSklybjd2Ti9iSEdXRytRaXVEZU1qbGdYbmZsL1N6SlZ1?= =?utf-8?B?aDJKclpGM1AvTm9BSU5aLy83dkMzRkM2bE5ZL3VyU2ppbWlDSy9JRllrL2Ru?= =?utf-8?B?V2oyRm9ZdEplQzZaT1k3cTFrbzNONm5EUjJESTFzRjlOSjYwZGRnMGxOdFpK?= =?utf-8?B?TlpVdG5aSTZBTEU3czJMQlltbnF6MkFoUTBnVDZ6VGRwUCtCbGtiSGJzUlg2?= =?utf-8?B?VEw0Rnh2SnZUV1RCUU9jTm05MjlLcEp4THJneEcrUnN6SThwb0IrOU1EOEhz?= =?utf-8?B?WGlKWi9wRG9IZk8ybzBWRkpMNlhGSkozSFR3ZWx4UGFOL0kyVjVCUUs0ZHBO?= =?utf-8?B?Q0NkUGU2VHMvZEhtSDlnRHZJbXJVT3JnUllUb0ZPQ1RlWWdmSUN6bG10YXJI?= =?utf-8?B?aHZJOEV4TFFUMjBZcDBQanJGUDdUQndmMHlXUXhrZE4zZzBsZDdyVllxdUc0?= =?utf-8?B?Z3VFZWtnR2hoNUZlSzZJRnNGMExIZWZ1ZHI0RGJqVSs5d1pCaEZVeTBzZzlJ?= =?utf-8?B?SVFOOHZXQnhnTHhocmpSVThWY3A0L0lQSFcrVDg0dS9RUHFQblBjdFRvT3dp?= =?utf-8?B?RVcxQ3ZSRHVRWG56cEo0OXBDMExXNnpDSTVlMWoxRWZRaWlaZWszOERraG1T?= =?utf-8?B?MzUwcFNzb1JSTEtvcDZqMUxvNm82WTlnY1V2NUNWN0RrNHJhS1QyTEJtRWZE?= =?utf-8?B?Wk9hdS9xRkptSVJjWFVveENzeVhSbzdVS2VjeXVyZ2E2NW1EUzl1OWI4Vjkv?= =?utf-8?B?NDgybStYM2paV3gweE05b0FLWTBBV0hReWNPOCsyOUJXL1hkMnlPWStEcUhC?= =?utf-8?B?TjBadXUzUUpHS0VnczhOSjF5OXR5Q1dWb2srMFdjbm9odm9SelNVa3lZcTFa?= =?utf-8?B?Rkg0NkZKZTNkMFRQSXp1cnFHY3BiQ21zaThzdDBPOEdlaGwrRzUvNTJESVJq?= =?utf-8?B?NjZwVkczejM5V3owdXRSamJib2hiYThMTE9ZdHRMSmg2bW9ZRDArRE5wR3po?= =?utf-8?B?UGhReis2TE5kOHpiU1hqK1k5aWk2N3dmSXF4YlZyem1ucWRjR3BIckZNbGxs?= =?utf-8?B?WDV6VzBoWndkVEFCQTNKNnAzMVY4cWEvc2lQdFIrRDFrbjMxTkJCa1pEclpi?= =?utf-8?B?bzZRUU8veFNNZGdDeDhSRjJwR1VBdzdITG1UN0VHeVZuenA2QkE0cmlJYTJH?= =?utf-8?B?cXFTdHo4T1I0U2pRSUpQRm5DbHZyUGRmSUZnQXJBUGxSNEd0eEJ4d0NtUm8y?= =?utf-8?B?M2hxMzhadG1vWllqQmxsVjcvUEpYSktkbXVmOUdMK2lIRFhvczhkNlRvbnp5?= =?utf-8?B?R3RQb2FIWXVDY09DK2hnTjRjdGdQM3RWVUk2N3JqY0JieVErVGFKL0hQRWFn?= =?utf-8?Q?Miwvihh6Y7fLJPe0O8G/+h2M/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa5e0c6a-9204-4c77-65ec-08db18c0fb07 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:48:52.8504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6aPU81B1a/crrWD8CdqsPxducSChBkku6Zq1/5FYYZpMeC7Y+W/hLWt7MrIg/AOsOpr5k/muywmG15DyHgB8zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7664 On 24.02.2023 12:35, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/traps.c > +++ b/xen/arch/riscv/traps.c > @@ -4,10 +4,95 @@ > * > * RISC-V Trap handlers > */ > + > +#include I couldn't spot anything in the file which would require this inclusion. > +#include > + > +#include > +#include > #include > #include > > -void do_trap(struct cpu_user_regs *cpu_regs) > +static const char *decode_trap_cause(unsigned long cause) > +{ > + static const char *const trap_causes[] = { > + [CAUSE_MISALIGNED_FETCH] = "Instruction Address Misaligned", > + [CAUSE_FETCH_ACCESS] = "Instruction Access Fault", > + [CAUSE_ILLEGAL_INSTRUCTION] = "Illegal Instruction", > + [CAUSE_BREAKPOINT] = "Breakpoint", > + [CAUSE_MISALIGNED_LOAD] = "Load Address Misaligned", > + [CAUSE_LOAD_ACCESS] = "Load Access Fault", > + [CAUSE_MISALIGNED_STORE] = "Store/AMO Address Misaligned", > + [CAUSE_STORE_ACCESS] = "Store/AMO Access Fault", > + [CAUSE_USER_ECALL] = "Environment Call from U-Mode", > + [CAUSE_SUPERVISOR_ECALL] = "Environment Call from S-Mode", > + [CAUSE_MACHINE_ECALL] = "Environment Call from M-Mode", > + [CAUSE_FETCH_PAGE_FAULT] = "Instruction Page Fault", > + [CAUSE_LOAD_PAGE_FAULT] = "Load Page Fault", > + [CAUSE_STORE_PAGE_FAULT] = "Store/AMO Page Fault", > + [CAUSE_FETCH_GUEST_PAGE_FAULT] = "Instruction Guest Page Fault", > + [CAUSE_LOAD_GUEST_PAGE_FAULT] = "Load Guest Page Fault", > + [CAUSE_VIRTUAL_INST_FAULT] = "Virtualized Instruction Fault", > + [CAUSE_STORE_GUEST_PAGE_FAULT] = "Guest Store/AMO Page Fault", > + }; > + > + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) > + return trap_causes[cause]; > + return "UNKNOWN"; > +} > + > +const char *decode_reserved_interrupt_cause(unsigned long irq_cause) For any non-static function that you add you will need a declaration in a header, which the defining C file then includes. I understand that during initial bringup functions without (external) callers may want to (temporarily) exist, but briefly clarifying what the future expectation regarding external uses might help. Any function that's not expected to gain external callers should be static. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 12:50:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 12:50:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502521.774372 (Exim 4.92) (envelope-from ) id 1pWcxk-00069s-2c; Mon, 27 Feb 2023 12:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502521.774372; Mon, 27 Feb 2023 12:50:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcxj-00069l-VS; Mon, 27 Feb 2023 12:50:39 +0000 Received: by outflank-mailman (input) for mailman id 502521; Mon, 27 Feb 2023 12:50:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWcxh-00069S-Sv for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:50:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20630.outbound.protection.outlook.com [2a01:111:f400:7e1a::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54306c4f-b69d-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:50:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8900.eurprd04.prod.outlook.com (2603:10a6:20b:42f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:50:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:50:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54306c4f-b69d-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzOoGP09TyknkK86hONgnd3WusulZfODsiaskFohOrtwqHJzgUlKelJ/4TeUn/8rgr83Db+jP8pAV1Sx2LqhgWMeFD9rkMaHuHXgg8EMHo6t3xpXhTcqF+b1akPv/WBQJ4b8fq3hpMUwou8tFMoCmdfkmmrZo4ImD7rMi8rOxvw30Du2Gk2C9uZ2jn4sDYFT9K1dNM2o8l9gZTMo8QAZ1HQOt2iyWPwy6NcLRYpu6qnoh023fTBl82zzQmnutKkRNdNc/5DChQ9M+xPt4QWNTxq/nbL3Jg8mLKUrukL8gwanRyKR8H87x7jEgl/nbvIMIt2OvjV9WOyWHBMpyhqkKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MY8LEK2B6hlb+oj2c9Iw4wZ82eXPqpeP2A9YpklpZLw=; b=fO7S76DqNvwnxUKjhNKZBZy8KkSv1vQBC8zr4BeJTGyZN3Y9JlXwWIJUjoJvFCHEkpo3iGC9F4w/GMIswnxA2u/fiDAnAwYH0mZahCHNtxcWCIDelk+q4ivnnXV89HSRAunSDak4a911IW7vOwZt7o7dTg+tSMPLIo5Fh1NYAStYZBCWLMBd2j7CITBU0CL5CJg1YBhN2Wn9vtXVG/rGEmSuXbL0Oy1tlBZp2yrJU9wJ5UitS+ZBGbLdC8mDy+HgpWlsEaNS08TjL5x+O8GVJ60D2BQUYS3r8vOJa4knmoyDTS6Jqeg+0PE3TvxVDrtawXPWe37DAab9iPVjUXX4vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MY8LEK2B6hlb+oj2c9Iw4wZ82eXPqpeP2A9YpklpZLw=; b=MLlGapuaCpBeq6kmyoLkcr+dP7//WoyKN8H1HI86NS/+eN1n1/NJ3N9DBd+ASzX3vWKbd2fOG1IFlSHTa/tp97WpxgaDX50/dHmWbUdPBQKXCtuLm/wdoWq+gNIUZZ7s2PO/jDo1CRVWNXt0HU2VLI44mpimiSeLM2uzh8mKGif4/+ttWzm9sJb375tfbhlHfW4jOkq5fwqnLioItFm/aIxT1EfGebZwRqwsssaGb7NyVpI+wHFdPuojgc+H2ULvS73hOZDEPacuZkUUuswC9zjN3vHp4ju1yzA255VotBXqbId3PMRF2pzB0rV5woqtEt6oJMHlDznSkzAE5SnjoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 13:50:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/5] xen/riscv: introduce trap_init() Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8900:EE_ X-MS-Office365-Filtering-Correlation-Id: dab56dff-c3fe-48e7-9ca2-08db18c1378f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b0AwPWnkb5DdG1AH/Se/hBLKeWgTBw3oAx8Kq7BnkrnjlCz3x0MMe7mCUQtbibltntumn/GUBhGpM+ddmm3WXx7bvnw2fuQT6q3flNH79pz6bI6g2DqookAk5uXnXEbEAhbzYI6Z5IvgLbruA3fzZA7uBpVJqO9eBv8hOJw8YVVYeFSybt5vZ6HiPScaO16JF1eVvChUc2Q5fL+tJHVsZv27jr/Jk5+S9KJtXb1aWwm9vp/d4oH4xCXOgqCl7IiJJRqDkPEstRwFP5W+rEYDgIRF5T+Ed4520uXYnyjAEmXJGCbDmIo9sG/seftkGlpRS5LNYe5zxgyulbf4qiKKIlRME/qRC8Pejd3Pt3y9Vuk4KvD5LRqg36Dz3GZIHlOkQ8lSfT/lcIt0NT5SLDTB+0Hekkbe5LTO+8DAyYvS1G/9ycOkJEJ+b3Xtm0c1e+oiGWCKAob8/S+ubcNMwT/DgZA2GTHkg0wYifpsgIB5iGlO/p1TvWOE4pzedsdKj6NsSP0OW8Rn/baojzI8vCQv8k0LlEhK/B8mDWgtM1sVIRfCL7sKuyxj0P2sHaTRzA9HOtMClaQYNzh0gqLrSUCdtEiV20/EUX6rxCBFV5IXmJLYG+Zdovr4EEnyACC+qk5tc/KcjGsspOrnlbVdO4+WiqulVxK+Hb9WemQKJ79RUgdUDFfGt4UBAmUA8AVHcPGWyWFKmqVVff5tOglpbVkTz60TEe6DBvfd0jaiR3H6uts= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199018)(186003)(38100700002)(83380400001)(8936002)(6916009)(4326008)(66556008)(66476007)(66946007)(41300700001)(2906002)(4744005)(8676002)(5660300002)(6506007)(6512007)(26005)(53546011)(478600001)(6486002)(2616005)(316002)(36756003)(86362001)(31696002)(54906003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDhFNEtvV1NTV1hwRUc4cmVHOUt6U2oxOUVIRFNPaDZFTjFjWWZoL1Jyb05w?= =?utf-8?B?V2UyWFhTT1dXSWoxSEZuS3AzeEQvd2tDQTJPdDdRNDN5RWV4YUo2Mk9tRGho?= =?utf-8?B?K0VXekVVV1pGekhRMGVqVE9kd1cxd0VrSTJnNERnWExmb1VpV3FRbTZMenpn?= =?utf-8?B?eXVTRnI3d0xYcGVDNlR2aHI0ZGd0bGZFRDEvUU5teFlBd3dUcDJOYktTSU8z?= =?utf-8?B?bVBIWEl4TWczT0JnTXVNb1dGWnlVcGNja083ODNVSTMweG1BREdxT2dhNy9t?= =?utf-8?B?WWhjMEI5WFcyUWxyM01zTzR0Unp0SVZTUHo5UWhYeUo2RmExUlZkajNGVEd0?= =?utf-8?B?cFJLR1VKd0lsc2dlcTh1KzI2enUyYUZXUDVLMmxzNmlMeDl1VzhERnoxQTZy?= =?utf-8?B?N25McmE5c2EwTGhqRG9pZE81VFozb1NHS0c1N2RjL0UwREo3bUxNdlBDU0J5?= =?utf-8?B?ODVYUXBVZ0hzNDZqa2ZKZzFyemk2aGp6a2JiTnpJQkxNYjdRQ1BVUHpxbzJu?= =?utf-8?B?eHIremlEcTI3NHhNNVZPQUxQWlNRV0VCODU4RjJzRHI3VkgvWmpZZ05pOUs0?= =?utf-8?B?Z0hBSmNURlQ2bUhRbmZaM09MV1dQaWtwbU5tQlRiL2UzSmgrWGhiVytsYTU0?= =?utf-8?B?a01LazhKUFBMU1hZdkt0Qm5sQ0xqTUFzeE1EQ1VUcy9GK2gyb0JFWkhmZ3NF?= =?utf-8?B?WVVqVzhxRnJBb2p1MzBTeGt5VkMyTG9tT2M1NUgvR1R3empmUnFpcXJiSEt3?= =?utf-8?B?UXlxZy82emxYc0hFMmZnb3FtNFk5eVZUMXdJODEycm5sdTYrSGsyVlgxTXI4?= =?utf-8?B?OVpYTDRWajJWeFUwd05Xbi9ObWw0bkhCVUtTc0tkU1pqcG9RTFgwR1diVENW?= =?utf-8?B?L21PVVlzSmdWa2dzYkppRVVTeTNhSmxQMno2NTM1d1ZBQStzYVluanBvMk82?= =?utf-8?B?anpIN2NyQ2hqR3FyZlpmaytyVW1pKzM2QkEzNXlVT3lFZFNxaEdWOGo0a05C?= =?utf-8?B?M1pJV09GYVZrdzloR002SlZBS2NBd0RDbzlTSjhTN29HTGdDWEk5amFMTlpF?= =?utf-8?B?dmRoMVJJZ0x5djBsYzVWQ2ZXK0hLWGwwVFFsbGN0ZHpicUw3MzFyZnU1czV3?= =?utf-8?B?dkFKYW1WcEhiVlhwazZJd29uMldBbU1wTDBVakhLMDNsdWZOeUcvdXRmT2hz?= =?utf-8?B?UndISEQ3STZKek1QaUxZQ0Jvbm9oQUNRRlIzVVhvN282bjVtQnJPaXpBbHQ3?= =?utf-8?B?NUlXNFFxSzBWd3lVZlpiUzlEUmVZekl5cjFIWU9RbHBVY0UxVS96NHhldEJ1?= =?utf-8?B?MjR0OENBRFd2elArcE1hRWJZOXl6QnM0Z1o1U3l5cGZ4NU5TM05SYjVhZGpv?= =?utf-8?B?bHlhYjVIek5hc0JlOWQwQ3QvYkZBU3dDK0lWL09BUGNOMjBWbXJSZHJXeU5U?= =?utf-8?B?Y0lrNm1WYlptMnc3N1Q1U2h4eENtUTRLRWdjVzFkT0UrVmVnbUhaQWg1UWxN?= =?utf-8?B?ZWpKZEJCcnpiWkpmRG5KRWdldGFMV2ZtUnNtaXhaYWNncGJWcG5BRVNYQUFW?= =?utf-8?B?L0hmMWVRTjdHeWw3Y2NoMHZHb1kwaGFoVVBRUURxMzROWDJCMXhxeTZ1ZXdp?= =?utf-8?B?WCtYY2l2Ui80cFA0WWQyV1ZVcmtobExVdWxUYkhZclliY1ZYUjA2eTJUdXp1?= =?utf-8?B?Q1VTUFR3TnNHQ1BPVnBmTXcvSHpkTnU1Z2ZKQWhpQmpEU1dOTkdyOGNFcWFH?= =?utf-8?B?SmprQzNxNGp5ZVFiYnY4a1p0TmYwZldmSUkyMm9qN0tROWJqeHY0Y3hGd1JR?= =?utf-8?B?MmJ0emF0U1d6KzRuaU9PQXVIajRrOEtvM2Iwc281RmlSeEt4Q05YZnVpRENP?= =?utf-8?B?eFRTY3N5QjVRb1Y5VHNPR0VEWFVJMkJQQUFaT0ZCeGh3endLMENNcFg0aGM1?= =?utf-8?B?K3FiQkRPVHZUbElnT0RnS1A0ZVk4OHVpZEpROXhWZnBNWnZkOHNOWVFveVZx?= =?utf-8?B?K3RkTlhuLytUbHoyWjVRTW5UZCtFU2ZhdTk2YkJZTkN0emhGWGFKQ2ViQXRi?= =?utf-8?B?cjlGeWUxNXlyalVRd1NycEM5MXhuN2hGaHJMS3gvRHhTRHFJQ3FZbWQwcXVD?= =?utf-8?Q?ZEHCFqQsZyop6lTRYbAuJy5Qq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dab56dff-c3fe-48e7-9ca2-08db18c1378f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:50:34.4064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SyTC2tLFGmZrfqPJvQSzdlCj7sAzee4BdwVM0oE+P7TNLbGYdqdUSY2Qv76uxNtX2l8YapGT6RxZLAx2qFbMOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8900 On 24.02.2023 12:35, Oleksii Kurochko wrote: > @@ -11,6 +13,8 @@ void __init noreturn start_xen(void) > { > early_printk("Hello from C env\n"); > > + trap_init(); > + > for ( ;; ) > asm volatile ("wfi"); Along the lines of what Andrew has said there - it's hard to see how this can come (both code flow and patch ordering wise) ahead of clearing .bss. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:00:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502525.774382 (Exim 4.92) (envelope-from ) id 1pWd6Z-000797-UN; Mon, 27 Feb 2023 12:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502525.774382; Mon, 27 Feb 2023 12:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWd6Z-000790-RY; Mon, 27 Feb 2023 12:59:47 +0000 Received: by outflank-mailman (input) for mailman id 502525; Mon, 27 Feb 2023 12:59:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWd6Y-00078u-Sh for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 12:59:46 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061a.outbound.protection.outlook.com [2a01:111:f400:fe13::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b0decbe-b69e-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 13:59:44 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8157.eurprd04.prod.outlook.com (2603:10a6:102:1cf::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 12:59:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 12:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b0decbe-b69e-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1DjpUu3XhQlQRL1rOcosIURm5PqZCZMcB85vGZ37GPi68dpLaXI7n9plRCZB6wtXU5LOprCk75Cvi/2pj3zBRL2gAoyhtOGEzG71E1JIX4bPhyGrfi1Di+h2guOS8rqX0+nDa3AjRMTCpVREa8CYs9pEoquOX3n7oBW9Ml275yhDaMLJ2230zWhuISgE6llaVZOpTNzH9oQHIzLS7TqGTSa5IUxZoRcieAG1cKbBfTWM3uFykYBNrJrlcJRKHKcVIQMHzpa+29R1C3g2Cr/wySRVmP6JDW3qYkaJZY3mI4HdJsE4ncH8StEcqMbMTpWFPjZwjwZwmvcNwFQb6wX5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+DXSdKd3X+qzOivtOx+KjZGsCNTdb+md9yZwlgSL4tg=; b=avJ8080/tnvj0AXax27gasA9ObU2V0OInpgTUJZIPYTrXHcZjZV8SHDDfnkmdMlYeMiRK9/ZN1/1yh5mA+6T3Ifr9914CKiB8jbyc7lCpZI/E+csvKluoGHNjaMmMF7yir9ItCe73yabAmznNrhhN+x3SYjPVUjTTgmg5MCSMHZKi49ImL1eHzXjxLL1odIQSEBhhpqrvI6H0TmF9ba2ExnojhQZwvoa4q8gR9tabVk3A2ofFSd9kAjL0FpEU1idGz8RxXgtmkx6s+MZkRwsKw3UMMhL2vGQPMIX3B4Ol8mcNK4iIpFD88NtxIlAVjsJyqDCkFfFpgvhqEkHTbET/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+DXSdKd3X+qzOivtOx+KjZGsCNTdb+md9yZwlgSL4tg=; b=gKduNm1gMkp1t+jrzI5Py8WuOkUvEJB6w8N3qbM8ECx1PgIPW8yxRrd6rDeB2JuBLIooeeL59u7EmDuoIgmAoSPPsgdrFS5zfv9Sf/u/dj2UolJZ+bGwmb842/vVKX1ejVlCUOpqu95GvbOSt56AiAkLO0d5lEfhLY7Gaw0zQBZ6+sBmRw2JgA0+dUPvCHWSoyKg3DvdIzH8VsKz2Oui/dzo9LT+gLd6k4uGtZWsZqO6K87NPPHKv54kPweQfsUiZdXD4WxOKcY1ICdR0jGCoaDHi8YrHnqs5ffOK5fGSqiyJ2/fRL/9gZ1MBJDd7KKUWkKAU+b0J6/TbkQwAJb5oA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 13:59:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/5] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Kurochko Cc: Julien Grall , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8157:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bf8ff11-a731-43df-65a6-08db18c27dee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MhonGME4Ofs7v+0NmnzECS2avaEkc2rQUBlFpOF9JI3gw5Ssyu4Z6YoYYgtYJfWzrTpKC/kDr3C/cuqCg4yDBVTWYjBnw5wybJsSk3NjVrXRcaDnEStNIrY82/dFERPpM5fRnODTdTaJxcelvIOkmRO/mv8JGQ2VFol0bSccueJ4BNnu44hHtl1n3dGpdlopU/KVa2M+dytAQvAsZ6dqvnKatoQ2ofn14EXksHo7pucCisL4Uc7Gc040kDPifgptEmxEjl8U9MlQd8HOqo5XUWC/ubDb4NF4+lMd9+K73Zq4hB6vh8qivaZStTALZygh8EzXBgNSZfBABvKHOb29B1w7CTqSAST3QOk7KYoZ5/YsE5kb0tl16Zlb0pEKYrmWOPwimOMhUPLTB2ElQ9xpJwkAGn05aQRplO7hUdpFrVekt1CX0KFkqJApnhE0BEietDKqxbv8Zw7RC7cbxb6Xk6K9RFo761ttPx+rEAIjAlj3sisLL59hcjFXJdK+BhH8GzrUVVfmG2UlL3bH8Vg9bc5V/eCgY28ffJ/LqOFJSzf5frhe04BU12vqzg94Lkhwums23ounRX3E1sGqh9vH8O9Awf08WWpd6NSHcDvLMOicZ37oVquakMnfGlnXyekiAsOrkhVxqQyvc+xhLLOtN1dUDsoPmME6GlHNWcOkpOkRjvsIMJXdhhPJD6PwF+5UzgPhcYm05Cbn48r4wyn5Tojadh10EA8p8uKyPnt9T8k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(376002)(39860400002)(396003)(136003)(366004)(451199018)(31686004)(2616005)(316002)(36756003)(86362001)(31696002)(54906003)(6486002)(186003)(5660300002)(8676002)(4326008)(66476007)(6916009)(8936002)(2906002)(66946007)(41300700001)(6506007)(478600001)(53546011)(26005)(6512007)(66556008)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2huMUJqZXd1QkRqN0N6eU4zd2ZQSmRGKzJGSUQySlRVYTlDeElPV1JnZ2RX?= =?utf-8?B?Ri95cFcvc09HVjlYczJUa2pLWUZyUUNNbWdIU0N1anV5SWg3Y3FMZnU2T2JV?= =?utf-8?B?dTJnMWJXNkNpK2x2aEttYWdCalF4V0x4eEsvTzBRUW84ZGpiTHlRZUlZMzBm?= =?utf-8?B?QS9FeFZ2WVBoYXdseG1uK1IxMGk1eUV2VGd6QkJJR2I2WVZiekpKcFhiQlBN?= =?utf-8?B?L0txcy9DR3RVN2U2dyswRUxnSTN5MlRBWk95Sm9BKy8zUHI4MGY4UmRwRDEw?= =?utf-8?B?L0k1b0xyMnBjWkJNK1BFSUpZRjhPZDQvSzVPRlZQWUNWTEZBZ1R1L08yS0hk?= =?utf-8?B?L0c4TGFEL3FQYytITUp4QVlYc1B3alBHaUIzS2tVWGk0bEJHcW1DMmU5aTYy?= =?utf-8?B?UjRhTWcxbGpkRXJLLzhiV1pXdjJIZDhHY25lVm53NTcxSmFkQ2dIcVR4S3ha?= =?utf-8?B?bGhFdVR1MjR1bFp5c2ZXN2k3Wnd1RElRUlhESmpYS1k0bjJ0TzNlQzFjUDgv?= =?utf-8?B?VHdxUHd3QTZMQS9NOGxWb1J6U1RXY0FEcG1sa2JLK2hNSk5oeU92N3VVVHMv?= =?utf-8?B?QkpVL0JPdHk1dkJQa1RvZnZMTHJxMHJ5UlozOXhuUUREZnU5WU02bzNYdlRD?= =?utf-8?B?SVREbVdXQ1h2ZTByM3ZYaTFLcTB5V0JiSlZwSjVXVGZubEt6WHVaRDhTcFRj?= =?utf-8?B?TzR6d3dkVTdJL1VIeERTWU5hQ1Q0c0xYd1BCU3pmYmdBR0lDTVptVEd4VXlR?= =?utf-8?B?a2JVM0xWR1d6MHZNbVNhNWN6V2lzZ1h5cXRzWVJlWTlQTFZZanErclFhckFh?= =?utf-8?B?bjB1NWFlcUVxMVZudGlaSmtnQUJBdlBDM2xPUGVwcVZyaUF3TkxSNXQ3OUM2?= =?utf-8?B?ZHJmZE50MnlXNWdkNXVFUEdwOXJoOFI0eGtOaWFlbmNuak10SXBFb3lzb0l5?= =?utf-8?B?aVVGT1h2bzlFdlNOVzJFUU45aUVBRHFpT0RraEs2eTl3YVFSNVdoN0pLMi8x?= =?utf-8?B?VTZtUVQrRFZCN3lwZEhhNVVOMFRSQTBPS1pSMlZLOVhPekdZZHk0d1c3ckow?= =?utf-8?B?TC8wSmlBMXVJR3VjZURqTEszRnNMQ2lGMm1OTlovOFMxb054NGRBMVFMbmlu?= =?utf-8?B?UFdhMXA3OFVBTGpjUjFRa3BOUnpqS0NDd3JkeTFGVVRVVEdrZ3JrOU9KYjY2?= =?utf-8?B?ZlRKTnJmQ3pZcTZmdS9RUWRVaXdHYVlZSHFpMmh4bVQwVmhTakNHMWFLVW5y?= =?utf-8?B?SW91amYvdmRZRjh6L1RWQlFZRzdxQ2ZJRUZYbXI3TFB5bk1rTXpvcmFKR0ZK?= =?utf-8?B?QW5lYnBGRVNOS1Y3cGwyd0tsUGp4UFRZRmMzbkNzb3oweTUwelZRbWxDTzFY?= =?utf-8?B?eWFVVXJlNjkxTjJVZXhDSXVOVEM3dVVvbHREZURWQmVDSC9JSkxQb09BYld2?= =?utf-8?B?bWI1bGhvS01xU2QxVGVNbWhId0ZOV0NHWTllbGd2bkc2L1dLTEYxZ3FzV0lG?= =?utf-8?B?SmpJQklETUJtV1JROEI0T21GT1BsaGNpSXlxQ0xWNnNncDdSUWhHSElDSlFh?= =?utf-8?B?YkVOUTFTTmIya2lqNWxVSWQyTzhrQ1UrYzRSMGJRVVYwN2NQaE5yeEJieDJ5?= =?utf-8?B?cTJUeXdzbkh0RG1HTGRPTGlPeU00ZG50NXdVUlVDNTN6K0N1QVBwZXQ3aWdQ?= =?utf-8?B?VFFsOG1xWjFDWXRsS2Zkb0EvNHEzdXhoZCtnVDU5MlF2TmcyUmRYOFpnRk1y?= =?utf-8?B?WUhUNmp2Tk1wTTRCR0JuMVFudjVqTGFtSTlFVzlMTHhhMUlCTmNTK2NMdS9w?= =?utf-8?B?U1pVbG91VnVtMWdNUjQ1MXVKcnp0dUNCNFgzbzBjRW9IT3FjT1BmZEJVclRU?= =?utf-8?B?MEw0MjBOT1VXdHN1UmVqR282U2t2SFJjSG9HMzJvLzZwNDlOUDcvYm50M09F?= =?utf-8?B?RHlDZmlBSDZiQWkySVBDV1R6bUNOWTlQbm1IYnNjNnBNZWdDLy9YSjJqNGht?= =?utf-8?B?NTlNV09PbGMrTHRkR0VYaytGeVkrTG5VR1N5K2d5dnByclZKRTVkVjFmZ3hj?= =?utf-8?B?ck1yV0FGSXZJaG1jL25jRjNUWmI2UnU5UDVMUmg0aFp0akEyUnJuSVovMzhP?= =?utf-8?Q?NOJKqk/0tNuEB+64o7FS9Ndsk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bf8ff11-a731-43df-65a6-08db18c27dee X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 12:59:41.9960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AZoDss82WMGpy6MaSViPdHDPNmZJ7UZ8NajuGDP7lXi6dHSiqyOxfcuA34akTTIq4dIotCTGAshXkxlfANZzVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8157 On 24.02.2023 12:35, Oleksii Kurochko wrote: > The patch introduces macros: BUG(), WARN(), run_in_exception(), > assert_failed. > > The implementation uses "ebreak" instruction in combination with > diffrent bug frame tables (for each type) which contains useful > information. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V4: > - Updates in RISC-V's : > * Add explanatory comment about why there is only defined for 32-bits length > instructions and 16/32-bits BUG_INSN_{16,32}. > * Change 'unsigned long' to 'unsigned int' inside GET_INSN_LENGTH(). > * Update declaration of is_valid_bugaddr(): switch return type from int to bool > and the argument from 'unsigned int' to 'vaddr'. > - Updates in RISC-V's traps.c: > * replace /xen and /asm includes > * update definition of is_valid_bugaddr():switch return type from int to bool > and the argument from 'unsigned int' to 'vaddr'. Code style inside function > was updated too. > * do_bug_frame() refactoring: > * local variables start and bug became 'const struct bug_frame' > * bug_frames[] array became 'static const struct bug_frame[] = ...' > * remove all casts > * remove unneeded comments and add an explanatory comment that the do_bug_frame() > will be switched to a generic one. > * do_trap() refactoring: > * read 16-bits value instead of 32-bits as compressed instruction can > be used and it might happen than only 16-bits may be accessible. > * code style updates > * re-use instr variable instead of re-reading instruction. > - Updates in setup.c: > * add blank line between xen/ and asm/ includes. > --- > Changes in V3: > - Rebase the patch "xen/riscv: introduce an implementation of macros > from " on top of patch series [introduce generic implementation > of macros from bug.h] > --- > Changes in V2: > - Remove __ in define namings > - Update run_in_exception_handler() with > register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); > - Remove bug_instr_t type and change it's usage to uint32_t > --- > xen/arch/riscv/include/asm/bug.h | 48 ++++++++++ > xen/arch/riscv/include/asm/processor.h | 2 + > xen/arch/riscv/setup.c | 1 + > xen/arch/riscv/traps.c | 125 +++++++++++++++++++++++++ > xen/arch/riscv/xen.lds.S | 10 ++ > 5 files changed, 186 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/bug.h > > diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h > new file mode 100644 > index 0000000000..67ade6f895 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bug.h > @@ -0,0 +1,48 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2012 Regents of the University of California > + * Copyright (C) 2021-2023 Vates > + * > + */ > +#ifndef _ASM_RISCV_BUG_H > +#define _ASM_RISCV_BUG_H > + > +#include > + > +#ifndef __ASSEMBLY__ This #ifndef contradicts the xen/types.h inclusion. Either the #include moves down below here, or the #ifndef goes away as pointless. This is because xen/types.h cannot be include in assembly files. > +#define BUG_INSTR "ebreak" > + > +/* > + * The base instruction set has a fixed length of 32-bit naturally aligned > + * instructions. > + * > + * There are extensions of variable length ( where each instruction can be > + * any number of 16-bit parcels in length ) but they aren't used in Xen > + * and Linux kernel ( where these definitions were taken from ). > + * > + * Compressed ISA is used now where the instruction length is 16 bit and > + * 'ebreak' instruction, in this case, can be either 16 or 32 bit ( > + * depending on if compressed ISA is used or not ) > + */ > +#define INSN_LENGTH_MASK _UL(0x3) > +#define INSN_LENGTH_32 _UL(0x3) > + > +#define BUG_INSN_32 _UL(0x00100073) /* ebreak */ > +#define BUG_INSN_16 _UL(0x9002) /* c.ebreak */ > +#define COMPRESSED_INSN_MASK _UL(0xffff) > + > +#define GET_INSN_LENGTH(insn) \ > +({ \ > + unsigned int len; \ > + len = ((insn & INSN_LENGTH_MASK) == INSN_LENGTH_32) ? \ > + 4UL : 2UL; \ Why the UL suffixes? > + len; \ > +}) And anyway - can't the whole macro be written without using any extension: #define GET_INSN_LENGTH(insn) \ (((insn) & INSN_LENGTH_MASK) == INSN_LENGTH_32 ? 4 : 2) \ ? (Note also that uses of macro parameters should be properly parenthesized.) > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -1,3 +1,4 @@ > +#include > #include > #include Why? Eventually this will be needed, I agree, but right now? > @@ -99,7 +100,131 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) > die(); > } > > +void show_execution_state(const struct cpu_user_regs *regs) > +{ > + early_printk("implement show_execution_state(regs)\n"); > +} > + > +/* > + * TODO: change early_printk's function to early_printk with format > + * when s(n)printf() will be added. > + * > + * Probably the TODO won't be needed as generic do_bug_frame() (at > + * least, for ARM and RISC-V) has been introduced and current > + * implementation will be replaced with generic one when panic(), > + * printk() and find_text_region() (virtual memory?) will be > + * ready/merged > + */ > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > +{ > + const struct bug_frame *start, *end; > + const struct bug_frame *bug = NULL; > + unsigned int id = 0; > + const char *filename, *predicate; > + int lineno; > + > + static const struct bug_frame* bug_frames[] = { > + &__start_bug_frames[0], > + &__stop_bug_frames_0[0], > + &__stop_bug_frames_1[0], > + &__stop_bug_frames_2[0], > + &__stop_bug_frames_3[0], > + }; > + > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + start = bug_frames[id]; > + end = bug_frames[id + 1]; > + > + while ( start != end ) > + { > + if ( (vaddr_t)bug_loc(start) == pc ) > + { > + bug = start; > + goto found; > + } > + > + start++; > + } > + } > + > + found: > + if ( bug == NULL ) > + return -ENOENT; > + > + if ( id == BUGFRAME_run_fn ) > + { > + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); > + > + fn(regs); > + > + goto end; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_ptr(bug); > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + early_printk("Xen WARN at "); > + early_printk(filename); > + early_printk("\n"); > + > + show_execution_state(regs); > + > + goto end; > + > + case BUGFRAME_bug: > + early_printk("Xen BUG at "); > + early_printk(filename); > + early_printk("\n"); > + > + show_execution_state(regs); > + early_printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + > + case BUGFRAME_assert: > + /* ASSERT: decode the predicate string pointer. */ > + predicate = bug_msg(bug); > + > + early_printk("Assertion \'"); > + early_printk(predicate); > + early_printk("\' failed at "); > + early_printk(filename); > + early_printk("\n"); > + > + show_execution_state(regs); > + early_printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + } > + > + return -EINVAL; > + > + end: > + return 0; > +} Wasn't the goal to use the generic do_bug_frame()? > +bool is_valid_bugaddr(vaddr_t insn) Why is insn of type vaddr_t? > +{ > + if ( (insn & INSN_LENGTH_MASK) == INSN_LENGTH_32 ) > + return ( insn == BUG_INSN_32 ); > + else > + return ( (insn & COMPRESSED_INSN_MASK) == BUG_INSN_16 ); Nit (style): The kind-of-operand to return is an expression. Hence you have stray blanks there immediately inside the parentheses. (This is unlike e.g. if(), where you've formatted things correctly.) > +} > + > void do_trap(struct cpu_user_regs *cpu_regs) > { > + register_t pc = cpu_regs->sepc; > + uint16_t instr = *(uint16_t *)pc; > + > + if ( is_valid_bugaddr(instr) ) { > + if ( !do_bug_frame(cpu_regs, cpu_regs->sepc) ) { Nit: Brace placement (twice). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:40:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502551.774392 (Exim 4.92) (envelope-from ) id 1pWdjU-0004MO-0k; Mon, 27 Feb 2023 13:40:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502551.774392; Mon, 27 Feb 2023 13:39:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdjT-0004MH-TS; Mon, 27 Feb 2023 13:39:59 +0000 Received: by outflank-mailman (input) for mailman id 502551; Mon, 27 Feb 2023 13:39:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdjT-0004M7-6r; Mon, 27 Feb 2023 13:39:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdjT-0000uA-4X; Mon, 27 Feb 2023 13:39:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdjS-0005CY-NE; Mon, 27 Feb 2023 13:39:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWdjS-0006Vh-Mg; Mon, 27 Feb 2023 13:39:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fUrs52RY4b3z5wQZKe611ErufgqhXFGlXJG6VZbk7v0=; b=wlnJU/sZ02fyWmP9To2LXBTaru Hp6BL01q5/3Dip2ROvkN/K/qC5Z2jbxa3VcpkEJj97xpLTd8GJo4dc6WZU7K0118bzFIabMmyMW/U fFyH6uW7HRhTY6WcYPMbfZ5hEmifbUNiNATYpSjK6cR7v8WpeyRlFViP+we7rJX93QSE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178623: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-stop:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-stop:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f3a2439f20d918930cc4ae8f76fe1c1afd26958f X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Mon, 27 Feb 2023 13:39:58 +0000 flight 178623 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178623/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl 17 guest-stop fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 17 guest-stop fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 17 guest-stop fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 17 guest-stop fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 178595 REGR. vs. 178042 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit1 14 guest-start fail in 178595 pass in 178623 test-arm64-arm64-xl 14 guest-start fail in 178595 pass in 178623 test-arm64-arm64-xl-credit2 14 guest-start fail in 178595 pass in 178623 test-arm64-arm64-xl-xsm 14 guest-start fail pass in 178595 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 178595 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 178595 never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f3a2439f20d918930cc4ae8f76fe1c1afd26958f baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 5 days Failing since 178093 2023-02-22 05:02:47 Z 5 days 10 attempts Testing same since 178595 2023-02-26 20:42:37 Z 0 days 2 attempts ------------------------------------------------------------ 1866 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 214011 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:42:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:42:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502557.774402 (Exim 4.92) (envelope-from ) id 1pWdli-0005jA-Ec; Mon, 27 Feb 2023 13:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502557.774402; Mon, 27 Feb 2023 13:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdli-0005j3-Bo; Mon, 27 Feb 2023 13:42:18 +0000 Received: by outflank-mailman (input) for mailman id 502557; Mon, 27 Feb 2023 13:42:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdlh-0005ix-2t for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 13:42:17 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2062d.outbound.protection.outlook.com [2a01:111:f400:7e8b::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8acd6ebb-b6a4-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 14:42:15 +0100 (CET) Received: from CY5PR15CA0083.namprd15.prod.outlook.com (2603:10b6:930:18::30) by DM8PR12MB5398.namprd12.prod.outlook.com (2603:10b6:8:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 13:42:12 +0000 Received: from CY4PEPF0000C96B.namprd02.prod.outlook.com (2603:10b6:930:18:cafe::71) by CY5PR15CA0083.outlook.office365.com (2603:10b6:930:18::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 13:42:12 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000C96B.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 13:42:11 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 07:42:09 -0600 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 07:42:09 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 27 Feb 2023 07:42:07 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8acd6ebb-b6a4-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzQP2pcYko89hxHY6my5NlweUNlSnk6V6QO/FYGPArOecwiTuJbyGR8LD7zmQ/hfeYT2XcVXHyspkDbZ6jz8mFUAux7AnAs7DFsn4xDlj6IIBJoaSw0oKwjYX0X0XTw5H2j7/utrAhxIvM4NliTOu7wS5ucc8gSF3HSnwnEu//6j/YoYku5ztIWIHztGciQDx4f+uDsliKIS7nVJFEw/GaszdYSL5qAjBFAejafGQ1i1PRPYsDiNZmmPTsNZSUyy63MULoLfCqYc3N17qAtaqsnHVlxPEi8IIk7JDpJJ7wJKFY2U7KWKD8+M5lbTDfBHqCgrc5G1ofH9R6o9z17ZwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XrtonYJ2cuephbMDtS+XJ/En2k8EI8+VTQdt7Wmajcc=; b=QRLbmuvrVWbNjUROZ+1F5ogdcqiKWZaEHsy+IByLcl7w/wXr9I98TmnLrn2ofaeu/bo+98VRHE8/g8LQ86O04uKLNA7s12bD2WxvrKJEEdFkkVj9M9chJxFtoXBa8qZ1MhuJI9AiNSj7L8YeOoVm5Hxygx3DRxcZqmCmVknLSv6A1CFj8NOKzVU5moAbVkgEmP/5B8qlSpiRRcJDxrKvk6+lscoAAKuDa42bz3/c1NrsiI3ZA1H0xcD4Z8dwsWA/nyKU5JPlGiLTiTanw6IzmIqswu9wyfT4fS7xAE14p/cPBmVPLrlvrPNO8ACXRgjrytxWivUTVO0msNr6Rjc2og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrtonYJ2cuephbMDtS+XJ/En2k8EI8+VTQdt7Wmajcc=; b=LIrJaEhSEka06a8J7vE8X5NisXR44I+gQuswCmmffyVe8DhHFqtj9jgPZZKFl6TU494PHujTYfgrkn6qR126Sd7oOXrDxyCVipzpc2VnuGhfrI/PJM8Dvr0uZpRRO6aeoYv7NFMgOn28DDAx0qfjtLrGMeOluSwXQ0TnrILda6s= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> Date: Mon, 27 Feb 2023 14:41:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , References: <20230227095315.6483-1-michal.orzel@amd.com> Content-Language: en-US From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C96B:EE_|DM8PR12MB5398:EE_ X-MS-Office365-Filtering-Correlation-Id: 9505a3b8-e0ca-4612-95fb-08db18c86dd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jsu9+vGqOdoo5xB42DlrVGD/POuiCANYz3dQwwOW2ssfxRCapk7p+vUK2ojGCn7Xmr1+UQgI/vqsTIQwY3lzfbGPOhFU4X7pyM3Twqe+j6DiRRlPRveN17zU+vrE7iLgc+5iTFwHc6iImgU0kxxEXbpO5SCxu3MDRPcr+IoJyx84Fd2dPOHk+CGlLXw+tpafxiH9UsEHuroAGo8DI/P1xFD8A/mjL9xpHExq93r4RUTbKon3fEW+YccNQ8LKw3Gx+9C633YZ/A1t4CwVcZgX+heQO3Woue2OjF4o1nhIzrb1GIL29uiyroc1vy7YB5057mDCMr8g4l4h6cheU6xdrMBRZm+Zr0sXf8i8+KEgj5A8qG5fZRr6EiioAAVS3+VStu+U3ryLYq0JBjVqmz0ku3ENu5SgqQ2+AdzAHR0ENaxizUmnjx0QFusTmBOORymU/iQYNTMq/0iZNpKn3z4q3TPoMo7r2cXyFdeZSDMPb11AGrg8xcDdj/moiCRdWQrkFEijfDgbLRlhicGmd2Bk5ZzaTjznIV+IHwHTXfEccMJgErOvAqMtjJ9dzRRbKTCE5KM9b2++6NRypP10bK/8lb8JHLmDdl/JdMkivPPKmPJeMkJOmtMOpeFxTlUy6yK0lvt9cuUxFgVLcuvoHT8aQ3s9Ed8lfrJ3n/q0aCAnhUfdsbW6JX+V3C5/PWKpSL1WL+0mdxu2dtnvfFv91JVcc+6mdlD4gnFmSiDFMPw7q21e87i5i45hN5vDpeykAgb0WUStbezRHNzQZ2D1aHeoHg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199018)(40470700004)(36840700001)(46966006)(40460700003)(186003)(81166007)(83380400001)(82740400003)(356005)(8936002)(6916009)(4326008)(70206006)(41300700001)(70586007)(2906002)(8676002)(5660300002)(36860700001)(44832011)(40480700001)(336012)(6666004)(426003)(26005)(47076005)(53546011)(478600001)(2616005)(316002)(16576012)(36756003)(82310400005)(86362001)(31696002)(54906003)(31686004)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 13:42:11.6875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9505a3b8-e0ca-4612-95fb-08db18c86dd0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C96B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5398 Hi Jan, On 27/02/2023 11:10, Jan Beulich wrote: > > > On 27.02.2023 10:53, Michal Orzel wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >> >> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >> define all_sources >> ( find include -type f -name '*.h' -print; \ >> find $(SUBDIRS) -type f -name '*.[chS]' -print ) > > As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo > also only be included when selected (or at the very least only when an > arch might select it, which afaics is possible on x86 only right now). > > It would also help if in the description you made explicit that SUBDIRS > isn't used for anything else (the name, after all, is pretty generic). > Which actually points at an issue: I suppose the variable would actually > better be used elsewhere as well, e.g. in the _clean: rule and perhaps > also in the setting of ALL_OBJS-y. (That'll require splitting the > variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and > $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which > has caused crypto to be missing from SUBDIRS. > I think what you wrote can be split into 2 parts: the part being a goal of this patch and the cleanup/improvements that would be beneficial but not related to this patch. The second part involves more code and there are parts to be discussed: 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the top of the Makefile (thus harder to make sure the linking order is correct). 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) but for all the existing architectures. I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken into account for the tags/csope generation. Would the following change be ok for that purpose? diff --git a/xen/Makefile b/xen/Makefile index 2d55bb9401f4..05bf301bd7ab 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test +SUBDIRS-$(CONFIG_CRYPTO) += crypto +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) + define all_sources ( find include -type f -name '*.h' -print; \ find $(SUBDIRS) -type f -name '*.[chS]' -print ) ~Michal From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:52:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:52:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502568.774412 (Exim 4.92) (envelope-from ) id 1pWdvj-0007bv-Kx; Mon, 27 Feb 2023 13:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502568.774412; Mon, 27 Feb 2023 13:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdvj-0007bo-ID; Mon, 27 Feb 2023 13:52:39 +0000 Received: by outflank-mailman (input) for mailman id 502568; Mon, 27 Feb 2023 13:52:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdvh-0007bi-QS for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 13:52:38 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fccef3e8-b6a5-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 14:52:35 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31RCWQG9029764; Mon, 27 Feb 2023 13:52:12 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nybakk5yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Feb 2023 13:52:12 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31RC2Uj7016044; Mon, 27 Feb 2023 13:52:11 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2169.outbound.protection.outlook.com [104.47.73.169]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ny8s5jaqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Feb 2023 13:52:11 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CH0PR10MB4859.namprd10.prod.outlook.com (2603:10b6:610:da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16; Mon, 27 Feb 2023 13:52:08 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::6800:e85a:3f21:6606%2]) with mapi id 15.20.6156.016; Mon, 27 Feb 2023 13:52:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fccef3e8-b6a5-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=fDej2tCL3b5mBA/Z3VfE428l6BGAdVB2dJAu5zMguR0=; b=W+zg4CtNv4+PJnAoYEvqq9UvLRABLBuL/u9FFmX41/zfOQ73mAWeOdkyMQdMCcptdj1O NLnQmEg62l1g1/QNG0k5F5Dwvt4w/s/SNfEFLnd/m+hXAU0eMcqUnryWPct8lay0MQaM bIf6yaVwvD7+OBenCKVOMeBJy3bdRElMYw4gte5UT5HjiyaXTE5tSYvcwGB4GNSbtWMp 4bg59Zq/GERBOVSN2zAzqCbcAVoGSihdV1ZERdCFmfvUn2JiJAz+D9kFkJtk5q5XGzru lChAPIfG0UJzS7L3HUXMCshS/uMYmXyYtguhtKxVzUJgzFVWQILerYLc+GeeW63QvvIH nQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKNMr1PjIR4oZrgO1a7VX8dETkLVAbIRLltKlCSi4xFDS0xAuFCRLUWLjTd1/aG2ToXTHqhUQ8IbHGRALBxuwQ7ReRft9/umu5LftKW++avTlGLH+lSmGsac2JT2fKlFhidFswYIb9lnG4SYJ+RziAOsB4gxCTLqskblemE0NfBn2Qt/s5EeSJDfOCdognpj6CMumIXBAjZE5wyKSF5Bq4ctdRILuvL2brofYeRTmQ5j3vIC4NSKELGf9FEIjcuSTRfW/pP8larTXrGf9Xc+jLKPKrL7RdRCy+3/qh53aXuBhfj1OsH1SmdhmFU8i98Y3f00mqLFJiY3LOCqcV/aZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fDej2tCL3b5mBA/Z3VfE428l6BGAdVB2dJAu5zMguR0=; b=B45zZidrb7kh/ZT8izIj0cEXeXzTJMIkmKgg7g8gjDbBvUnl/wnuUrL+EjL3tCPWIIkbFywNFd2OWGUOW6r4tbcBwgdlC0w5DBeU5dyskeyncU9A3EQRzYN5b/dFAQD+3LtFs/GVxxVsCkBsojdaXV23pmJLt2THH1DiDYd791wc+1NiOqDAcqGtsAoltHACkziouZ3MFvV+7YluVq1AAWMQP4vOpN1w4QWiR5iyR9oTaDIEB6JAM9cqPfcy8SOpy5zwPZp2DRwW8CY6sj4B81kiNcPXpE4ucoDaQSiaCuccKxPR8GZQTs79ZvEezufjTiM7RREW2efUOUMkqo50fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fDej2tCL3b5mBA/Z3VfE428l6BGAdVB2dJAu5zMguR0=; b=N1j0oJvk9py0l1IcyrXgqHAKboV8yHO4wtfwe75EZnKKpeaauaxGYawu0zr9EbyTqoTNgM384p+jaK4XL6R6huFx8ICv7O2gvk4mB4PCvEk2I8dkzcqSGqqudEiAXPXYgIftoFhKN72vSLcMeqCe2Rv0aDXOm6MXBEIWnMAHClY= Message-ID: <432bb9b3-959e-1074-c0e6-a65ac46e489e@oracle.com> Date: Mon, 27 Feb 2023 08:52:05 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain Content-Language: en-US To: Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> From: Boris Ostrovsky In-Reply-To: <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DM6PR02CA0157.namprd02.prod.outlook.com (2603:10b6:5:332::24) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5009:EE_|CH0PR10MB4859:EE_ X-MS-Office365-Filtering-Correlation-Id: 95e8505d-06b1-41e7-f3b7-08db18c9d157 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gSrxQWeAcRwYl2+YXu9i92/Jy+D+0WjDg5SocljZ7INHDTwkxc0zlXwG8jwHJtYXHJbmkkQvqa6prYPV2MbwqJdfafyfOIHWz4u2PKpC1WeIWyFecjsY3QaPY/bnG3TArvv8TDrU5u6OHFmsVcj1oRhM12AEk+0OO20GpkpMzLOdLw6zZz2K+3oHmxXA7wbroWBotyGtiX51s8MC6WbD7f5iHk26l9PePEdRrlqc8ESNkhNVq55TbTibDP1z5LRgBUqTsQypBDRmo+npexwscxHPQYuZYtdAdveI8UqLD4gDU6wDV3bztXMXQ4o0//BDh0Oo6OmXViuxSTZ8TL3arS0y0OgFWUA9+V4ZsLDz07Cjvty2qDA9RLCNfU4RpHZs522sY61bVq5oisDY8aB0q2ki528qEZ9j6JHypoj6Sg6hr/bK3fotp9IkeiLnMz1Vv99jGCZcDpC8DqOMga+GdiI81SFonmqcDuGvd0RsBqPcnKC1fAIybLdWccER+kU8w4oSIT6NkId1mavcswhWBEP7el9Ynt/w+KIHjGZw+48lejYel40Hg4ZoExtSRB8AzIZiIuA98F7P2VTbkwdc2Dzru1myoXrD3TVB9h1RQlH+U7nTpd0/dIzqb4GnEFLA4MqLbCyl9JXCs0odp9lvzwpJ7URSk9DJd8pdtxtt0nA10UJc6AbylcasE2e/RldXNa8ojBUEFfjnFVoXVP5MbiGJHybwuoVKj3VwS/tqIkc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199018)(478600001)(6486002)(2616005)(31686004)(54906003)(6506007)(6512007)(53546011)(186003)(26005)(316002)(6666004)(66476007)(66556008)(8676002)(66946007)(4326008)(41300700001)(5660300002)(4744005)(44832011)(8936002)(38100700002)(36756003)(31696002)(86362001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ni9rcFI1S3Rub0cxV0VXYTdjKzlrdE5LMXNybGluMEVBK3lnZGhQL2VFWVA3?= =?utf-8?B?c2NWRnY5VGNoLzNpZ3VmVnpDdlhuRmliTXNBYUNCVkR5SXpLcy9xZm40WXhS?= =?utf-8?B?NVllVys2VGtlQVV5cUN2R2hya1Z0RkdXM1VtdjNyZ2xUV2MyZUJIWThLUHJ0?= =?utf-8?B?c0luS1FFOVVOdVU5S1dNR3ZBa1Y1QzdhRVdTK3NldUdlRWV3WWNlMEswelZR?= =?utf-8?B?ak1IcWdpSU9DM0h0dndrUnhjd3lhK0FUK3VwelFCZWw3R0p6Y1c4MlF2REVQ?= =?utf-8?B?azg0b2FjK2VtN1VUUnh2Z3FpTUtCelhFcGprZEZONEpWZDArblBONFVHVGlN?= =?utf-8?B?Y3ZxcXpyRWtlK3hBOEQzQ1FoY1FzWGtCbGFvNVBIc2N3MWQ4dWJXYzlUa1Zp?= =?utf-8?B?N2loeUd0NXNiTFdaOUd6Ukc2SHRNQ3lqcHVFRFhKa3R1bjJSUFRIL2szaUhL?= =?utf-8?B?eWRiY2V3a1c3L3lqVGZvOExGNVNiN01odnlTdk5IRVBta1dkT1NPeVdXVzFs?= =?utf-8?B?bjJ0OVVRd2hzd1lXM3dkTmdrVW9icFN2YzN4TnI1YjJQUDRuWUJPSklLa0Jt?= =?utf-8?B?dHZqWUt6VTZDMEhVYis5Tjg5UFJ2UElmZmtRanVEMGlVcEdYZ0ttTWt3WU9O?= =?utf-8?B?QTBSVGFoYkVWSEYvd3VPaDg5eTJvVFhOeHp1aU1nVHNQSlF1Q3dHVDhhTm1C?= =?utf-8?B?NjNaRmNnaUJ6UFVKNWZudXc5RlZ0VE9qemE5dlBSQTVkcmJYNm4xZE5VbHl3?= =?utf-8?B?dVRxZ2NKWThuTnhFVUU0a0RLdWF2NDdsUHplU3BnTFR3bW1PSFcxS2tTOUpH?= =?utf-8?B?ZEFWYTUvMERjdFJFK1JpaVZpUEZ6QU9venJaMGswL0J3UU9sTE9VUjRMdThQ?= =?utf-8?B?dzF1b2l6aWZJWEdjOUloUXFaa1AvODFQQ2pPcW1OcXN5OSt3YSt1YXhGS08v?= =?utf-8?B?L0FpODFSdCtaY3U5NVR2RTByQUlIeC9UWUVzR3A3Q25pWjg4SHpyVGN5bThC?= =?utf-8?B?OHlXU1Jjc1ozUmVsdEdVWkJiY1FYQ1JrMmZ4WjJkUTlHeEJEeFJvVHg0OEJL?= =?utf-8?B?Wk56YmJJVGVyOGVpeno5ajV2WEFMT0NiY2M3WE42Y3JnOGtqclhOL2c5OG81?= =?utf-8?B?OTJmSGxYVUkrMTV6a0N3OE1SYjNBK3hqUlhkYUFCb1pCV29JVXl4WkJqMVE5?= =?utf-8?B?cHV4SVZhZ3BkdXJjVDNtYzRJYm9iblhZWi9SL2ZXTkVldktYOGQ3cGlsQ2hv?= =?utf-8?B?VktPN3JGUEMvQkdrdnJ2SGd1MktSY1V6bmowUEJuN2U2cHdvWEcxRDE0Y0dp?= =?utf-8?B?ZEgxY3R3SGdFVy9sdng2dkl6ak13U3FjdnVlR0xOTkZ1TStGTXkyWkxIMFhs?= =?utf-8?B?SmlNbTU4TWQ4dFJSZ0hZVVRCOENQRXhSbjNpRnJtaXh1YzdpNkt6RXVOVjhC?= =?utf-8?B?VUxJaUhrMFZnNFJBMjJhRkZKR1BFUVRSVGFuV04vWVpvQ1FDdExPTXU5UE1X?= =?utf-8?B?TXdyc0pnNDNrZ0xObUYrWXlsSHhvdzM0elV6bWhJYXU0dmlwSEkzZjljWEd4?= =?utf-8?B?SFVGNTQvcGVzMmdrYytsSzJ4N2YwakZ4bC94bUgrNUpEdWtlblExOEhqZ3Vq?= =?utf-8?B?bG93NzVxUEpCUHNNamcrQmxndnV6THplVXJzN1h4YndDNGJxek5sanlvSVBW?= =?utf-8?B?d3lleFNZdER6bmswTVpOSjcrN3F5blV2WlVrWXJTUUxITHI3cCtienBVTnJM?= =?utf-8?B?Sis5MlMzMCtadFZRWllZeDBRejB3dTZBQW90QXV6aVBUQU15ZkhvUXlnVi9L?= =?utf-8?B?NlRSdmFUMUhZTHVxMzJEUUgxWFNaSmVQTUx4TmlPVVJJeUwvOWhRNVM0Wm5p?= =?utf-8?B?Uis1ZjhQNUg2OUJWMStJUFA1V3RaRERsVTVlZklUVzZsbS9GSEo4OERHZkZS?= =?utf-8?B?MERqQ1ptUjVKVlNYbGQ5K2RGbzVkbkVBcFhJaU9xL0ZYL29LYXc0cS85ejg1?= =?utf-8?B?UkpLVUVVRFRoSXVDckpyaFA5bFowSVN0YndOd2t6dGNkZDJhVDdvMXRJQVRG?= =?utf-8?B?bW1zWW9qeDVHZk9YMHdqWDNsVXBwT0Y4ZHdDSXhZT1kvYVhxN2JaYmVXaG15?= =?utf-8?B?bU52bUtxc2l1UVFXMjduV1lBV1I2RkpTQU91Qmo2Q21tTm9ENGgxSTRRRml0?= =?utf-8?B?UWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Wk92cDEyalZLb21BNmQ5VHRZYWFyeTJhZWpuYVFpbHV6TmlvWmo3dkZWMlZy?= =?utf-8?B?akhHd0RDcHUvRFFQcDZRZWI4dGFCRTlmd2M3TjNRQzZvM2djVlJja1dHVXNB?= =?utf-8?B?eVM4TURFMGFZdjhWZFBqZ3F0TnlwRXRacXdyaXFvS2NwcXdoam5OY2hwbDIv?= =?utf-8?B?OG9OSG5taHd2L2x3cFJMYVJCZXFGTERCaklWOE5sUTJVYWo1WEhKU1dEaC9F?= =?utf-8?B?ejlFR0NtRE11eW95YTBmaWl4RGN5VllXN2UvQWtxUjdQdE1mV0FBWmoyamZ2?= =?utf-8?B?L1h4ODA4bUJESjAxNVpZNFlieVE0MnQyL2p3d2V6MXh5ZUFncVpsczNvTTlh?= =?utf-8?B?Z1MzV1VKTU0wRFh6Q2V3bUpLN1UwaCs2Z0VOTkxxYVh5QVdNbnZGaWxyOUFR?= =?utf-8?B?ZTRrViszY3ordnJDTkhsVFZ6dE5qck5wSmgxWHpaWW05NXVBVjI1U01wanFN?= =?utf-8?B?NFBTRzVmMS9jb2pMOFptNmNEQjg5MDk1eWNRcC8wOVNRUDFqYlBTaCtoVFRw?= =?utf-8?B?Zm5iSHI4WXlwYUhub2pDY2pObEhKSSt4S3RKdi9HcHZOVlNEV3RoN05Rc212?= =?utf-8?B?Sy95Rk45TkE2RDNnT0dUQ3k1UWZiM3NTTGo0L1A2TWNhdmlQL2YyeTBJKzAx?= =?utf-8?B?RTNzdUNQYUhhVEoxQktwbEhIY2JtcTF4WjRiN2p2enVDRW9FTHA4bWdtQVdq?= =?utf-8?B?dlg5ZzRpWU1TZ3JmcE1lYmNXOGJ1cmk2OEpBcjU3TWxuMUdDMnQ2TDNON2VU?= =?utf-8?B?UU9KUWl3ZXloTDZ2eXFtdmFrSyt4cjdNeGVudmxrTnhTdzdyMnpNY3hMcFY2?= =?utf-8?B?a2dSTm93VnBGd0FmRGNPcWlVWlN0eEIrYXpMOWhWalpXZkZSQkdRWjRhWXYv?= =?utf-8?B?anROYWwzZ1RVeDVmNjlVVUJYaFkvQ1VaekdJeVJPb1dUTXJJeGVNWkU3MUto?= =?utf-8?B?N0tiNnlFWXBlS2pNM3VMLzlmMG1tV2VzNkdxS1pvNitqckdSZjE5N2FBdkFC?= =?utf-8?B?YjhOSnVuSG0vV3lubXdQekRGTlZYdG9ENUdXLzMyRDBXeUhIbGZJaU91MjEr?= =?utf-8?B?MitDMHpZTHhFVDhQVXJjS0ZnSFBBRHkwaXJnYThjUHlhVElzZENFa0Y5SEQz?= =?utf-8?B?Q0lFUk9XREhHc3ZKT0FPZDdLK1JlT3ozV3lYV2ptcmxUV3N6OEtYTGNONUNS?= =?utf-8?B?SE9ZNHZZUkVjU3hJWGFlMzIrUVVPWExVVFNjbTVyV3Y1aDNKRHRuQ251dXNt?= =?utf-8?B?Vk9kTUFpdUtPQnZteVRYU2thQ3ZISWUzaE52d29MZllNV2EvU09FVWw4S0dV?= =?utf-8?B?c3VGUU1DRTc5V0xNVjFwQmNFSzhrWFRHY1VjVmx4QzNGNzQvSFVmNERydVRC?= =?utf-8?B?V1YreitBV2tReVE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95e8505d-06b1-41e7-f3b7-08db18c9d157 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 13:52:08.5095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kzz1dqRUnR+weRk+5NBNLNXpp2b/2owq1e9x94oeAMMhTGYFUdALiAV2vHGHmLpGrUB2D2c6uW83nBRp5o+BjveBpL1i28NQfJMV5ulTYug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4859 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-27_10,2023-02-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302270107 X-Proofpoint-GUID: NbPbCdiWhOAaKvYACRZ-q4hajz7RiJP4 X-Proofpoint-ORIG-GUID: NbPbCdiWhOAaKvYACRZ-q4hajz7RiJP4 On 2/27/23 2:12 AM, Juergen Gross wrote: > On 24.02.23 22:00, Boris Ostrovsky wrote: >> >> On 2/23/23 4:32 AM, Juergen Gross wrote: >>> + >>> +    for (reg = 0; reg < MTRR_MAX_VAR_RANGES; reg++) { >>> +        op.u.read_memtype.reg = reg; >>> +        if (HYPERVISOR_platform_op(&op)) >>> +            break; >> >> >> If we fail on the first iteration, do we still want to mark MTRRs are enabled/set in mtrr_overwrite_state()? > > Hmm, good idea. > > I think we should just drop the call of mtrr_overwrite_state() in this > case. TBH I am not sure what the right way is to handle errors here. What if the hypercall fails on second iteration? -boris From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:54:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502572.774422 (Exim 4.92) (envelope-from ) id 1pWdxo-0008At-1H; Mon, 27 Feb 2023 13:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502572.774422; Mon, 27 Feb 2023 13:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdxn-0008Am-Uc; Mon, 27 Feb 2023 13:54:47 +0000 Received: by outflank-mailman (input) for mailman id 502572; Mon, 27 Feb 2023 13:54:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdxn-0008AL-6B for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 13:54:47 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe13::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b069aab-b6a6-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 14:54:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8373.eurprd04.prod.outlook.com (2603:10a6:102:1bc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 13:54:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 13:54:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b069aab-b6a6-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ff+0nUxswsJEASUn/QdVmotprJ18bObfU6v+EVGQotkd48LjpmE/KZfISw9CjFAKNpGuiLheQzSBSexkiqyJA4fgT/uBM86k0R/hDVnnpsmQAt3loNeirV4BhrYFbLeHigH7lKJgi6SAmCP/Bfcdv+5TDxXVICTo8Nu4FQcb85TLagRaLbjr2sfa4dqibulNE3Y9VoFRq6nYLAlnkKDyxGwc9t3b979bcFUjfWGKMvnhSTLEp5SP1j7AK4jxX9MenNGcpByMiAsCZIKjzKH0HX5djxbRJtIkXyuZp6V5hspq3nslk+GgObdB2jTTp9O+No2EvJtWYBgVC2NenCJB+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TKnJh1XNJx81r6I1ikiYJP7tar3NQtoGAyJ9KWkExhg=; b=XldyR8hGfZKfeMAkl5Ph8sZm8a8HZTZUKlTXvNByF1GL+8KPhZDqQb4Jm/GkZVCGApaQ4GhVAqHByKaan/H7CwXvXTBYtsMSkzWlWcBhygeIzMqnxetmfZwAPjiMPJxe7xdgZJNEufzRvd/hWVZ44ZdstLqL5KHJ7sUY/dSrGLvsYdQLix+g9bx7riC3zgsVM5VYgRaURBMpo6ZSMhezwvCAV1BOwO7ehzkjbzrLgglBOTnZ2v3t+Goz0VGRAQdXY+Mh9rcxvSTi39DKUmQwtTHQWiDXZMSNLgj53jKw5HCa1ZX7yHKyRjQe/JKrum9OOW3JQHo/T1GSw7vbyNyCTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TKnJh1XNJx81r6I1ikiYJP7tar3NQtoGAyJ9KWkExhg=; b=XOSTa4ePFECVfsffBjfaQULti5kgbtpOsD3BnXKCzEs3U1GJfX3KZ243SP/zZBRINMQBvdsPqMWcSwQuqZxyPWVlt8fjZ6m/BUY686OrjxP8POaPuwEh9icRRarQynE+q925ju/HQVk90hb1+MgM/p+PDgLzRKzzu1HHTjyEdJN8Ny3ZPp47YKQQuR2F4sPK3OvqY5H6QLSD2UmN2GSW8w0xfcj7TdzfUNgfH+uM55+dLlH3jBdFYrDJTmrCaaqgLZZ6B4JJ+v52937p03L1X6Ef3OwGEEaR3AHZDeSlk5t6lDooDaCwIHE9Q3rtXuld39ew41Vh1UKXdZLnuYEzMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 14:54:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> From: Jan Beulich In-Reply-To: <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8373:EE_ X-MS-Office365-Filtering-Correlation-Id: a145a581-4bfb-44b1-99c8-08db18ca2e2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AwlZdYKKIr+h2nvP72E78NoRni3YrkZO6RBH4IQI84svqL+Fw0pChOXZS6THq70XDt9QtY1psP/K6bbX46Hxq0uKson3AZTv6b5N9diYAqSXdb37Lc88RoYNqLRp6h7gvABi1ECr0nGxqvfzvWduRRucURLDk0JMehkAB0uu+cyQXjLRc5lxyuyrOS+rsx1YYH6heu0QslqRU6nUVWH2O/dmHX0mI1RiWnvOnHpJ9LyW39zNDn1VVKptvHU3z/jFMRZYzEWPnKFwha+n77KC5HjuhRJwCQrVVShQ6LNNaYcBEEV7NwhuXoOKsGo6JgI4a40Mj49th8Plm+tXhCl1qN3xSZZ7KuZKawBEleYhboqc5RAtRji9UY4Nbc4gO0mUrmhXMHSohPer191ZYF1ah4qa2S3e4D9FBkLMM9ZpDusIS4hkXfprd3up7htxups4LtRkbBpTvhY+OZ5vpSRdJtuzTyKr4cxxPZYZb015glXmilS4BKD9ZdAjMWGwXTG957Nsa8101zNiLab1NZwWsi2Q1TUaxBLpJHfD6fDCfXWfVin7Mpxp+Mg6p0kappa2wG3FyVRUSA3XsYuMWacdF81QkgZ/Y5Qx4ewEDUE0UxL/C+iPr8+/zdiphhToObzolvJoBk4/IjSvW8nOvwvE9V6SP/EScrbygWtYqCo0v2m82FMyK5UBGWCLhETMCiKuEFzIqa3G4B/4k7PemcSwnU8g3t+V3TXFq9JybVwcNFg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199018)(31686004)(83380400001)(2906002)(2616005)(66946007)(478600001)(6916009)(8676002)(66476007)(66556008)(53546011)(4326008)(186003)(26005)(5660300002)(8936002)(36756003)(41300700001)(38100700002)(86362001)(6486002)(54906003)(6506007)(6512007)(316002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDFDTmJUeWJkZjM5dUowSEt4Qk5MOG4xTGJkT1FIc2F1T3NUS3dWbHI3U2lS?= =?utf-8?B?cUJYL2QrUzR6bThYbk1vQ2V3ZFowbE1pdTNRZmJBSkcreDFlaE43VUNGeXRp?= =?utf-8?B?cm04MU43eGVQdWVWR3dJOER6b05GRlVJTEpSUVNvYlpPVSsrRHVJWnBIWnlo?= =?utf-8?B?OVM0L2VpYzEzbGlnWS9SYjNQbG1LNUUyUWNBUVBzb3lTN3ZsU1dGMTZyNzUx?= =?utf-8?B?ZThHZGhnRUF6dnhEb3luajF0dUUvRUFUSzhJZ2xROVJYV0dGTWpxcnNhUHlN?= =?utf-8?B?SDlOcEtrUndwN0xleHJTUTRibXpzZlFBNmRiZGEvV2RweHQ2bnJqcWJtVDEz?= =?utf-8?B?TCtlb0dWOUpkSElnbjNCNEw2YlNmRitwcHZUSlZVU0lEYURRRjR0MkE5Z1lz?= =?utf-8?B?bEdINEYxanpjbXNLQjZ3UHhrcnlGdHYza2JocHpQOFdod0s0andYR014dkpU?= =?utf-8?B?V3d3dEVMUkhtcE5OTmdHTmxKUlAySy81UkgxNi96a2xRdWFvaTdUb3gwUy96?= =?utf-8?B?WGFkWW0rN3pFR1QzYVNldHVBYzBhK0JUdStUSE4veS9zRk90U0dubkpTMnov?= =?utf-8?B?TXBJbHc2T1kzazU2NDBLaEd5VnBwbkJSS0lVSUM2bzU4Nm9BTjExVUtrNFJl?= =?utf-8?B?Z1JqOGoxTDQwSS8vcUZDRGxHcGZTMGxuR1pKenU2SU9zZmFaVVE0Wnh2dnlQ?= =?utf-8?B?Q2E3TkU0M1dvYThKTmNscndnd2FrU0pwbmUxTVlQa1A5c2F3a0pGYXdNd3Nu?= =?utf-8?B?WmxUNE5RbmpQblQ1UTBIelZhTnBiVzd2L1p4NW5MeWQ1aWgxK2ErL2RzUUhK?= =?utf-8?B?UG9aeU1TRnVEUjRnRlhQY2NKNHQ0alp3UzlIRHcxZ1NPQ0w4Ky9ZVWRJd2RD?= =?utf-8?B?YUpRUDJKY2lRR2tHbzNLelJ1UHlscXZaNi9Mck9RTW5nVWV2WkROM01uR1dm?= =?utf-8?B?KzhySlJkR25DdFNBOHhzYVFvbmF5QzhoU0czU3lROTRrWk5LOTkxMElMbFQz?= =?utf-8?B?aWMzNEI0TVcyREFJQmZ2TDJVSzN2eC9VRGh4eFE1dEVNRnhFNlN6NGJBRXlF?= =?utf-8?B?ZzB0aW1rOGhveUFUajkrN2U0RmoxWlVjc0FObFA0T09XYmNEWUxsdE9iSjZV?= =?utf-8?B?U1Y0WEdrVHN1SVVFL2drNFRha2h1KzZMekp1aHpJdjhId0U2aCs3OENUSkk3?= =?utf-8?B?NmFoM2VzTXNCWXZXWVRMOURucTNqQ1JML2tpNDN1SjlPcTR2cW5YYXhvUlo1?= =?utf-8?B?NGQveUVhVWhLaDhKSDNubWs5Z0NhLzhOVU5Pc0RrWjZBcW04M241clhpMnJF?= =?utf-8?B?Z1M3S1dHOWxJYUxLYTB5UzYrek5pUDgrSnpPUFcxMncvdDlZVTBwVFZZczY5?= =?utf-8?B?WHU1ckVmNEovQVEvS2dOYzRhUmg0WXM1OWpubnlLY3BoTmcydWQ3d1VobmUw?= =?utf-8?B?OXZubU5RdVNSckxFUGhrelFRODBDdEJkdnFNRk11T1JVYnF0bExoeG5xcmhC?= =?utf-8?B?V3NTTUpDWTltZmFrWStiM1E4YUhxZk9FYmFZS0NMWlljRWFBM09MV1Z5T2dH?= =?utf-8?B?UytUVXlIQ01qUDlOcVZsSDBlc2FjNFdpTGxURk9MZVJUSG83UnZmNkNDQnl0?= =?utf-8?B?Y05vdUZyckZ4eUd0M05wT01ucFpsZnVTRGtsMEQ5WHF1M21tQ1VRdVVadU5J?= =?utf-8?B?M29VZ2J0TmhXVmVxRWI3N25rK1AzUmxxbFR1aG82aU54RmJwUWpDcHRHMEM5?= =?utf-8?B?QXRnQ1g0TjhyVHdSSWVNbFVQaCtNbjdEWXRzSGJXUWl6Wk9LUHhOSlQ1eVNT?= =?utf-8?B?VmtTQ1h3OVhvN3dGWmVsa3RpM3NKOVNLU29SQk5WYjJYWWJKb2ZOdFVtYkhl?= =?utf-8?B?VFNDMC9FMXVvUFpxRnl2bGJEdXhXZGJEckdzNFRRcTJUK05jUUQ0TENYNElz?= =?utf-8?B?QWZhRWczWWIrdTgycmt0T3VYUTNmeWh5ckl3SWpSV1REVFUrV09iTVJ5ZldJ?= =?utf-8?B?OGR5MnJrZzdndHM4d2Z0dHRxblU1ZERCTXlVcld2U0g3aUJObzlrb0RCazRB?= =?utf-8?B?S3RDYlhNTDZDUldQNjJLYzVJb0VvNUxaM1lPVzNmeHV1N0FWSjB0V2pQYTNU?= =?utf-8?Q?Our0tFEtX9FwVBT0U6FUh0Klk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a145a581-4bfb-44b1-99c8-08db18ca2e2f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 13:54:44.1795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4kLyHkmS5l8tcYBwqOBpsXLdmXRfdL4M6kJ3PZH/r9UIk9EWkK1z46OYeilAVFQDabM3ZMVK5kThbQWdxvEEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8373 On 27.02.2023 14:41, Michal Orzel wrote: > Hi Jan, > > On 27/02/2023 11:10, Jan Beulich wrote: >> >> >> On 27.02.2023 10:53, Michal Orzel wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>> >>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>> define all_sources >>> ( find include -type f -name '*.h' -print; \ >>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >> >> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >> also only be included when selected (or at the very least only when an >> arch might select it, which afaics is possible on x86 only right now). >> >> It would also help if in the description you made explicit that SUBDIRS >> isn't used for anything else (the name, after all, is pretty generic). >> Which actually points at an issue: I suppose the variable would actually >> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >> also in the setting of ALL_OBJS-y. (That'll require splitting the >> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >> has caused crypto to be missing from SUBDIRS. >> > I think what you wrote can be split into 2 parts: the part being a goal of this patch > and the cleanup/improvements that would be beneficial but not related to this patch. > The second part involves more code and there are parts to be discussed: > > 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir > that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters > for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of > SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), > need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the > top of the Makefile (thus harder to make sure the linking order is correct). > > 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? > Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. > Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why > not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) > but for all the existing architectures. I understand that the changes would be more involved, but I disagree with your "two parts" statement: If what I've outlined was already the case, your patch would not even exist (because crypto/ would already be taken care of wherever needed). > I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken > into account for the tags/csope generation. Would the following change be ok for that purpose? > > diff --git a/xen/Makefile b/xen/Makefile > index 2d55bb9401f4..05bf301bd7ab 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE > $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h > $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ > > -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test > +SUBDIRS-$(CONFIG_CRYPTO) += crypto > +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) > + > define all_sources > ( find include -type f -name '*.h' -print; \ > find $(SUBDIRS) -type f -name '*.[chS]' -print ) The fact that, afaict, this won't do is related to the outline I gave. You've referred yourself to need-config. Most if not all of the goals SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. Hence your change above is effectively a no-op, because CONFIG_CRYPTO will simply be unset in the common case. Therefore if an easy change is wanted, the original version of it would be it. An intermediate approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. But neither would preclude the same issue from being introduced again, when a new subdir appears. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 13:56:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 13:56:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502576.774432 (Exim 4.92) (envelope-from ) id 1pWdzF-0000Ka-CK; Mon, 27 Feb 2023 13:56:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502576.774432; Mon, 27 Feb 2023 13:56:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdzF-0000KT-9S; Mon, 27 Feb 2023 13:56:17 +0000 Received: by outflank-mailman (input) for mailman id 502576; Mon, 27 Feb 2023 13:56:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWdzD-0000KK-VZ for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 13:56:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ec56a8c-b6a6-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 14:56:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F8461FD63; Mon, 27 Feb 2023 13:56:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0C05013912; Mon, 27 Feb 2023 13:56:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fwykAXy2/GOgdgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 13:56:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ec56a8c-b6a6-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677506172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RfQNYah8x5Y0NPIXsAytRMg7OoSg/dSA9feq5QKA7Dc=; b=g0kSGKQSIXWApLzSk10vcrDrvHUVa2w0ERnXx8KDUWxm8g8t7bq9IPguB6R/sDFUG0Nlwy cLTaiMJQGw7sC1HbCozbl0KGKh+tChRfX8AiOEQMDX/w7Q1nDcGYgCSZ3Gy1590icu+pn+ NRlpaZ8//x6A+4KT7C9KidAfgNkUG58= Message-ID: Date: Mon, 27 Feb 2023 14:56:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain Content-Language: en-US To: Boris Ostrovsky , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> <432bb9b3-959e-1074-c0e6-a65ac46e489e@oracle.com> From: Juergen Gross In-Reply-To: <432bb9b3-959e-1074-c0e6-a65ac46e489e@oracle.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ZzdaRHHSqC803kjDf1XRY09o" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ZzdaRHHSqC803kjDf1XRY09o Content-Type: multipart/mixed; boundary="------------YSFPn3OWBWPbjfHDzaYXpC5l"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH v3 05/12] x86/xen: set MTRR state when running as Xen PV initial domain References: <20230223093243.1180-1-jgross@suse.com> <20230223093243.1180-6-jgross@suse.com> <58248946-f0ad-ae3b-57a6-f7c15fd35198@suse.com> <432bb9b3-959e-1074-c0e6-a65ac46e489e@oracle.com> In-Reply-To: <432bb9b3-959e-1074-c0e6-a65ac46e489e@oracle.com> --------------YSFPn3OWBWPbjfHDzaYXpC5l Content-Type: multipart/mixed; boundary="------------M8wUK980ffJONh0gz0OEMY0o" --------------M8wUK980ffJONh0gz0OEMY0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDIuMjMgMTQ6NTIsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IA0KPiBP biAyLzI3LzIzIDI6MTIgQU0sIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBPbiAyNC4wMi4y MyAyMjowMCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPj4+DQo+Pj4gT24gMi8yMy8yMyA0 OjMyIEFNLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+PiArDQo+Pj4+ICvCoMKgwqAgZm9y IChyZWcgPSAwOyByZWcgPCBNVFJSX01BWF9WQVJfUkFOR0VTOyByZWcrKykgew0KPj4+PiAr wqDCoMKgwqDCoMKgwqAgb3AudS5yZWFkX21lbXR5cGUucmVnID0gcmVnOw0KPj4+PiArwqDC oMKgwqDCoMKgwqAgaWYgKEhZUEVSVklTT1JfcGxhdGZvcm1fb3AoJm9wKSkNCj4+Pj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7DQo+Pj4NCj4+Pg0KPj4+IElmIHdlIGZhaWwg b24gdGhlIGZpcnN0IGl0ZXJhdGlvbiwgZG8gd2Ugc3RpbGwgd2FudCB0byBtYXJrIE1UUlJz IGFyZSANCj4+PiBlbmFibGVkL3NldCBpbiBtdHJyX292ZXJ3cml0ZV9zdGF0ZSgpPw0KPj4N Cj4+IEhtbSwgZ29vZCBpZGVhLg0KPj4NCj4+IEkgdGhpbmsgd2Ugc2hvdWxkIGp1c3QgZHJv cCB0aGUgY2FsbCBvZiBtdHJyX292ZXJ3cml0ZV9zdGF0ZSgpIGluIHRoaXMNCj4+IGNhc2Uu DQo+IA0KPiANCj4gVEJIIEkgYW0gbm90IHN1cmUgd2hhdCB0aGUgcmlnaHQgd2F5IGlzIHRv IGhhbmRsZSBlcnJvcnMgaGVyZS4gV2hhdCBpZiB0aGUgDQo+IGh5cGVyY2FsbCBmYWlscyBv biBzZWNvbmQgaXRlcmF0aW9uPw0KDQpUaGUgbWFpbiByZWFzb24gd291bGQgYmUgdGhhdCBv bmx5IG9uZSB2YXJpYWJsZSBNVFJSIGlzIGF2YWlsYWJsZS4NCg0KSXRzIG5vdCBhcyBpZiB0 aGVyZSBhcmUgdmVyeSBjb21wbGljYXRlZCBzY2VuYXJpb3MgbGVhZGluZyB0byBmYWlsdXJl cyBoZXJlLg0KDQpFaXRoZXIgdGhlIGludGVyZmFjZSBpcyB1c2FibGUgYW5kIHRoZW4gaXQg d2lsbCB3b3JrLCBvciBpdCBpc24ndCB1c2FibGUNCmFuZCB3ZSBjYW4gZmFsbCBiYWNrIHRv IHRvZGF5J3MgaGFuZGxpbmcgYnkgaWdub3JpbmcgTVRSUnMuDQoNCg0KSnVlcmdlbg0K --------------M8wUK980ffJONh0gz0OEMY0o Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------M8wUK980ffJONh0gz0OEMY0o-- --------------YSFPn3OWBWPbjfHDzaYXpC5l-- --------------ZzdaRHHSqC803kjDf1XRY09o Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8tnsFAwAAAAAACgkQsN6d1ii/Ey8v iQgAlJoeaKt/LI90VYkZC1QZshksoLiwmJjvgIlzPpJcTyr2t1jcVThoxBXCu+G86q5edXawKoEi AK8kX2P/JsBNmD/SgYLHWiGqALNMStlj/cwZ3d6wEpc0icbrkU/tQq/OdEgMCdO5YT1VqUVSd/2R 3/rVbnOPA8E8Hjso9zWMfQu7LmWwMQKbhOJB8MRiXNc41qMvKKw1eWrgX/o1CKx+6j44XTgmS/5o /fpi0WT1yP3iP+RsfzDncJPKdWtN4O0liTQaEmjC7khj9hY8Ekr+3dibTtRfx5Ru39chYLOTLFJR jwA2lASmK0TmYnp4VpEmkiQjj2yU5Kl0l4rF5NOOaw== =kPIV -----END PGP SIGNATURE----- --------------ZzdaRHHSqC803kjDf1XRY09o-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:07:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502584.774442 (Exim 4.92) (envelope-from ) id 1pWe9m-0002J8-GD; Mon, 27 Feb 2023 14:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502584.774442; Mon, 27 Feb 2023 14:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWe9m-0002J1-Cm; Mon, 27 Feb 2023 14:07:10 +0000 Received: by outflank-mailman (input) for mailman id 502584; Mon, 27 Feb 2023 14:07:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWe9k-0002Iv-T3 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:07:08 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03859232-b6a8-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:07:06 +0100 (CET) Received: from mail-dm6nam12lp2171.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 09:06:41 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6455.namprd03.prod.outlook.com (2603:10b6:a03:38d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:06:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03859232-b6a8-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677506826; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=b/brqdb80fQ8mAmyxDqU90MXjTIzpot+C2CyTNTTdPI=; b=d3VOaF9x66k/h/n4epZJMsLXh7JE6B6PbHJRazgDvB4c/mk82P0hGwJj 80AXJghT1gQMSnzjDIO5x4heDt++VIE2FgceQL9lMK9up9PpI14vwJ8sA NzxY6VOZqqm9sjnXDdFJh8A7S4KESq8bASez4gSevdVgSU2608cnPOtKg M=; X-IronPort-RemoteIP: 104.47.59.171 X-IronPort-MID: 98069583 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0MJlZK4sxP6ZSrEg8W5iwwxRtATGchMFZxGqfqrLsTDasY5as4F+v jFJWWmPPKmPazTzeop/bo239RlTsJTSx9M3SQFprHs8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPaoR4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5ms vcaNCkUYy+6odmV27WZE+VH15sxM5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+GF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNCTOPpq64x6LGV7jMeAhk1U3SZmujniEifcM9DF UFM4zV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8ywSWHG8fVRZadccr8sQxQFQCy Vuhj97vQzt1v9W9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJuuPC4awh9zxXD31n TaDqXFkg61J1JFSkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshTVflhSATlrD0xIYyU IronPort-HdrOrdr: A9a23:BEsQsauZvrY00VU3RO+Yo/vT7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,332,1673931600"; d="scan'208";a="98069583" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CPOuiwOrdXJWyVDOviYSTosXzMZEkBj5K3Rgat78EjN497dHJseL1Xam8+ckgacBo3g4abzHPTxZiZPLf6Tb5gWWMst3YfpKlk1hHZ2itK3RKZOoMpSngT5RXRBak2qyIbyPr78+BG5FYs+ib6km8mtzNS0ZYf6Epphn086b35+96avuDNiB1ZRxN10jkigGRwybpn69zXehjmPVQD9AY4eDJZXlllRh0biyOERoOOTTeYqfLd5QF8+0db8jApWpQ1rr3vnsHBbIauHgenkd2Sdc0Qnmh/Q0l34Ec95CAHvY0QeRfBC+uug3rZNenIXVYsCSsny4+UChnVqGJ3BeKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eDX2vW/r4HnF9lH5pLnNT+JaIccwT2rRSEbYnFJS6Jg=; b=U1yBqiGDy6Pwm7zQ/gMfDTyKE7Xcf6If0MGemavXsOEwRrBF/sKPSLJ8UFz2pzxsQRJlNSbFjkZa691ouMD8FA/UzGBTdi5QnhCvdtr1f99uk5yhxQ5OpDQQULoYcObxmlRkuwDAzA9lMhEdOZF6CFAnHW5P5Qi4xNZYKTlG9MecLHwHjJDQmlXbiTntAWdG/CXcEHi1ifdObO3CPLZofggyzZDka7wV4l21Ac7VkzdyrHk3bPK5eZaxj5nsHtUh5ZD0u47l3hSfV0JjmNfydL79ZWKS9DIsc1gzI0zL1SwOrZ4uH9VRXjPnC0iYHEGgndxDGoSvUqRJ/GJLoIE2Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDX2vW/r4HnF9lH5pLnNT+JaIccwT2rRSEbYnFJS6Jg=; b=VxDV8+srirg7eCyEx2KpLmGsP/f97aB+Tb20w54/0uszSpFNnfBB6buRkMuh5FrX0WlLT5gXRhV4LYq1FSMruU4q3M7+2cI2M2VZepUZuCKChCrMSEKS1arpyuG7S8LX1okjI8KYINMxqsxCbZIJLm3bHJktY6K2EV1g+AQd5q8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> Date: Mon, 27 Feb 2023 14:06:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-GB To: Jan Beulich , Juergen Gross Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0239.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB6455:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d502cc8-62d2-47fe-dac4-08db18cbd798 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDv5N3STOfgogB5D6WiNunICG4Kmltxc1OOxRMkc7NtUGpREP8xObMPsR3G1IGvlpb9DRl5rDAl5zWD9o5vw4c4sp8r/19VlTDRvEsfc70ItWywYNpL4NWAkt+PMVTGhAJXb23vEIk7j7359HNt9HLmjrUMDv/Udxlw75EQjOZdcttKR0/5SGtBE6q6tZm3qDsCear/crV/0SGPAY6Y4+UmhkJYfMs9rw+YpT7QvVBquielcVUp2ncSWTwU+Kx2XZltw4IqbiYDCCIRR7d4SbE/bJF9EVJiIxXsILOy++O7dku3qPfHPH46DVx5Y/x3otZvUzR+3pf9RgFF1yUr/hEKXzt+e9hx4wdr2vKhFJ2S5pc87pPGc3doIp2lhIlOPQVM/T07B38R59t/DWuI0Z/sJ76op6LJfPwcyjtnjgVF/qlnEnJS/VUXkiu5YdtdLLJMn+X13pn61xwJslgs+YhJms70tZ08F2dPpr10Z4Zde0Qv66IWmT98SxjNhSiSmWcR07eTl+NJJIDCCIw3f8zbS9u4jnx5D3cM772XAitlls2FszYQsMbW/k/vCyZgYeCMY6aOoR4bAoNpQDFp5VKfjVgGgt2zGLVqB5GOk8puQLIydnB+XFu4UObB+frRDzwsS3WCskmS8v/TJKLy8mF4ELKUrgs8xXmGjktB8IqD3YaUDltxINwZF04+ixJgBco5nAWUVGSZRLhoy2uaz2hPlAZHAYVdFGgJEpTFdEnM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199018)(36756003)(54906003)(110136005)(316002)(6666004)(6486002)(66476007)(2616005)(478600001)(53546011)(6506007)(6512007)(186003)(26005)(8936002)(41300700001)(86362001)(31696002)(5660300002)(66946007)(2906002)(66556008)(8676002)(38100700002)(4326008)(82960400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SU1mUlArd0F5Wmc2L0lnWGxPY3lrMGFhYTgxelJ1TDhvT0pldEJHSE1NQm5H?= =?utf-8?B?K1U2R1JoT3owclFmbGxhZ1FqNlAyTE1kS0l4d1ZVaEs2VG9FL1VjREtBZTZT?= =?utf-8?B?NTh3Zm9Vb1RkS3A1RG9WdGFBcFZWYlNkUW5POXhzQU9RT0wxT3hwdUlpTVdI?= =?utf-8?B?ZU5MRnBUVnFlT2xhdFlaUHZUWXNyTG1EWVA5WjUvNjlDS28xUVlRMk8rdjU2?= =?utf-8?B?UUZ4SHNNYzNoYUI2RStMalMyVWJjaDJMSG14ZXhJZmtlZWUwK1plQ0dtQU42?= =?utf-8?B?Z0pQaGlVY3p2SEpzNFZuWnozV0xoM0tiTFBURVYzdTEwV3V4WmR6R3NxSlZ1?= =?utf-8?B?TkxYbXlKZWtYaWJMTS9Talk3TitNUmFMWjlocWdGOWdGYWd2MHVScmh0cWpZ?= =?utf-8?B?L2dCWFg3SUwyQ1RBNzF0Uks3VGlQUEZLdlVpMnh5MUFReFZyV2FMaFRwQ3Er?= =?utf-8?B?NXBLMXBCSytyeTVDZXBXZGVzVHliNUptTUgwZVJvbTRYMFF4ZGVxb3UxVDRB?= =?utf-8?B?RHhMRUR2NXBxL2dxZlFlaGFrZ0pwYnBBZWw4M3NmUTkzSmg4d3hiZFRqUXln?= =?utf-8?B?dWFJeWlLdXZtM2hVa3FSbVpGSkh4Z0QwaG1UOHl4a1J6ejFLWjZMZjYwWjhx?= =?utf-8?B?Rk9vNUJLTnR3OStYa1hYdU15SEYyeU9MczczTEVyVkExQUpJaHVoZ2prUVJs?= =?utf-8?B?T3ZOdTM5R2VvMG9TMFAxY1hySjhSQVo5Yy8veUc4T1NMaWIwUWlGYUZsVWZp?= =?utf-8?B?dGFHdlROVVJ4ZDE4a0wyRHRWdy8rRit3VWFyVjRwZFhEKzRmOVpGSFVvN1R1?= =?utf-8?B?bWRUbmZrSzlmTXBIMDdidkI5dzN2Um0yUzFJMTdjd2hwQ0M0U211VTRVa3d1?= =?utf-8?B?SDBhRk54RmZZanl6ODYxY2RCbGRVRjlRSmtuWXhkY2xXbzRFVmJOMVRDS2FD?= =?utf-8?B?UVAvS2hLaXhaTVlRK1V0cTVuWmxLVWp4V2g4V01uMTFkRVN5ZEN0WldXTGFr?= =?utf-8?B?cHp4NkJBeDN1N3NINTFEbFlSU2x4bXBEZG8xTHJEMmh3cEJTWWhiUWhiY245?= =?utf-8?B?MFlqNnRtWnozWEtHZVo3aStubHo2SkFBdzNIYzNPSk0vaHd3emhoS1dmd0Ru?= =?utf-8?B?Rzc3dFMwM2k2NXE3dmFKRzZZYVoycitCNndrTklvWkp6Mm5qekNqWHJTNE9L?= =?utf-8?B?d0VuOHBpbmdzYWRvYlVXYk90d1VVV3habmx0VjhhN2RMcThPR3B6bHRPWnVQ?= =?utf-8?B?ZmpOeGtTVk01ZjZXNFY5R25keUxvNE5UZGc1amEzenhaY2VrbTZXYkNBTDhH?= =?utf-8?B?aUZIcXFUckxWSlp1U3FWU253NUZnK3ZwYmNiSGlFWlgwR1JwMHlobkdac2FI?= =?utf-8?B?L0thU3duUW4yMG12ZDAxT1drN1MwSWFDNnVqRTJHWGdyOUhLYW93L3hURW5i?= =?utf-8?B?bG4zWS9JM3UvY04yWUxYSGl2aTJrMkxNWHVyNU9yUjd3dHp2bm81RGltK0Zx?= =?utf-8?B?Q3J1NlpKL3J1VFBybDBSczdyN2NKbzNRL05LMmNabDN0OVJXRzVJOW05Q3Ro?= =?utf-8?B?M2RUZ0RDR0xod2hzRzIwVG9rYXN2cWZRaTZqY2pkYzNyaVRLZHhkUTJsbFdu?= =?utf-8?B?bUpsWmovOGhETDNoNmZPQURJYXJjWkREbVJvb0pKSm9CU2tBc3BuL29nNU80?= =?utf-8?B?ODdBRDcycCtRdDZ4UmczaUU3Ly9XbXl2OWc3YWdiTVZGUFVrdTF1STRuV0Vx?= =?utf-8?B?aDJHcldrcitwYjVOckczblk3aFR5c0svSmNQS1ZTbjhBbUFGNG9RTGJJWVI3?= =?utf-8?B?anBzOVN0d3RzUXUycnJlQytDclozY2xlOUlLNUZaby80OFZWbW8wbWYvRUdR?= =?utf-8?B?LzJXNzlGZ1FxN01RV2wyaDhCOGdSZVl6OVZjSDhpbzFXU1ZRZU5FRjUreUNK?= =?utf-8?B?Rm0zamV5Ty9GKzI1WVVvc05VWDFFQ0E4SFRqYWhqK0NSeXdYNVBFTWhRd2lz?= =?utf-8?B?aVVSUGhNdnl2ZlhzVjBDbWVkS0w1emdJaWMxYjlwOU4rN3dueFlIcnlLa0FB?= =?utf-8?B?VnhJamhWSXVmZ2FFRkpBalpDTGFCL3Z3dFlaY0xucnhubG4xWWs2eFRxVjlq?= =?utf-8?B?TEE0S1Z1cDlzSGtmOFhaRXpNYWl6UEFud3VFa2lKaFlXNUx2eUtYTDVEL0x2?= =?utf-8?B?QkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5VgnvCgCziUrE/amiyLF+bmnnz78QpuV3fXFsq5L9DEa/vIDEW+K1WuXhG9EUPNajlpP3oSwSxZEwvADGr+sLYvTTcpl1okv8ZS2+MlixjZLnLKe1OqnnGo/Ku8lKHB+Y/2x4b7kaHMw9kkGQkd+I5YoqWwji6HTqrpExkm4GApzcRmPqAOGhg1/Jx0IFR/O4m6Gdk+jROZd4zjas+0NF3QvBGLOg5CrUQnOdKQp1grSPn86hYkR9CwB9smIcFwzIWEclTHv2PoDsSgaVuJ4c+fHtpBagYgq1yveSzllOM90xT4nUKABfGEX7e4nVqFhQg2hM6OXBMHzBcVF/jcsV5DDjqp4+wOWoRbk6MMbAgeGszVl6l2j21zBeD8cB3EiBLgJfGqqF92zASqaMtYNzyP+aDjwMOD7Ty3qRDk/sDuGxDL+VDqvShDmx1n0TMHX5Q0Bu1xUjyLg4Ep29vqtVnI3ev6pq2/4Cu3BvLIquX+9c18mF30cp5zsrfSEreip0kEoG7SsW+CS1uBG2HdlC6ac06AolOYBOrUgPwrduKBQMYsXO6mXNBrkJCVWjRHXL72RBkHtKBrY9TIPBxVDZXJld/tHbLeUlZ8/E57gvnMJG370IIAH7fTDp1kKKYuSClqfeH3As0rq/vjCRj4iWvE7QJ3e7xvdqDa79Pv/uYKeRMurZF/vgZpSrMRfSxkKC28Iwzawcs1zZrotrurmXq++huYzxBPOCqmMLJEa9rU9UypZwdt7aLvAZZG2gaNH8W25q84mtOVnC3yh9OehZTT0c6gAzV7m81tiCURix6rvOiTVPzqik0sgeLP+8nA2 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d502cc8-62d2-47fe-dac4-08db18cbd798 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:06:38.5571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VQnx37y5IqDFktuUx2B7xgCQIC5KZgqeMTUEysDQ/cHYRpERhZm4UQ4FSXdFOIBiR+Xy3qVZPcI7QDFnZTmV2JMCcuZlBUpMFUXgR137WPg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6455 On 27/02/2023 12:43 pm, Jan Beulich wrote: > On 27.02.2023 13:34, Juergen Gross wrote: >> On 27.02.23 13:31, Jan Beulich wrote: >>> On 27.02.2023 13:09, Juergen Gross wrote: >>>> --- a/tools/firmware/hvmloader/util.h >>>> +++ b/tools/firmware/hvmloader/util.h >>>> @@ -30,9 +30,6 @@ enum { >>>> #define SEL_DATA32 0x0020 >>>> #define SEL_CODE64 0x0028 >>>> >>>> -#undef offsetof >>>> -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) >>>> - >>>> #undef NULL >>>> #define NULL ((void*)0) >>>> >>>> diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h >>>> index c7f974608a..926ae12fa5 100644 >>>> --- a/tools/firmware/include/stddef.h >>>> +++ b/tools/firmware/include/stddef.h >>>> @@ -1,10 +1,10 @@ >>>> #ifndef _STDDEF_H_ >>>> #define _STDDEF_H_ >>>> >>>> +#include >>> I'm not convinced firmware/ files can validly include this header. >> This file only contains macros which don't call any external functions. >> >> Would you be fine with me adding a related comment to it? > If it was to be usable like this, that would be a prereq, but personally > I don't view this as sufficient. The environment code runs in that lives > under firmware/ is simply different (hvmloader, for example, is 32-bit > no matter that the toolstack would normally be 64-bit), so to me it > feels like setting up a trap for ourselves. If Andrew or Roger are fully > convinced this is a good move, I won't be standing in the way ... We still support 32bit builds of the toolstack on multiple architectures, so I don't see bitness as an argument against. I am slightly uneasy adding a header like this, but it really is only common macros and I don't see how it could possibly change from that given the existing uses.  OTOH, removing things like the problematic definition of offsetof() is an improvement. I'd probably tentatively ack this patch, seeing as it is a minor improvlement, but I think there's a middle option too.  Rename libs.h to macros.h or common-macros.h?  IMO that would be something that's far more obviously safe to include into firmware/, and something rather more descriptive at all of its include sites. Thoughts? ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:10:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502593.774452 (Exim 4.92) (envelope-from ) id 1pWeCt-00041u-UB; Mon, 27 Feb 2023 14:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502593.774452; Mon, 27 Feb 2023 14:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeCt-00041n-RZ; Mon, 27 Feb 2023 14:10:23 +0000 Received: by outflank-mailman (input) for mailman id 502593; Mon, 27 Feb 2023 14:10:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeCs-00041h-8i for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:10:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7860901a-b6a8-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:10:21 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 881961FD63; Mon, 27 Feb 2023 14:10:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4CB1A13912; Mon, 27 Feb 2023 14:10:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id v3coEcy5/GPTfgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 14:10:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7860901a-b6a8-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677507020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wEskT/EQiXxFO9rrM0C+jXOFLRO2wLZnir9+Rn7dIcI=; b=sWJWW8mhNgMN5b1jF/35gVkTbsg2Uv4AhdN69Rlh9sYRgnf9EzzHlAt1qujdZfmWt/ad3f BbfOvm87ha2sxkpRWvcWTlM4Jw6RrvqMYKr93nGdvSr3+YsxfJQYiqQahGBPBkyzblxihY aVw53CL0zE4g6Iwx8wb5M4uEsVcL1KU= Message-ID: <18c102d3-7f19-9774-370e-654c7b0b727a@suse.com> Date: Mon, 27 Feb 2023 15:10:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-US To: Andrew Cooper , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> From: Juergen Gross In-Reply-To: <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------SZq1cpJCjn23uZP0tz7Axc27" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------SZq1cpJCjn23uZP0tz7Axc27 Content-Type: multipart/mixed; boundary="------------XEftNcsfbB6L18k10llmbvUx"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Message-ID: <18c102d3-7f19-9774-370e-654c7b0b727a@suse.com> Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> In-Reply-To: <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> --------------XEftNcsfbB6L18k10llmbvUx Content-Type: multipart/mixed; boundary="------------jQd72Luk2Z0w2LdC4ILYnJ0v" --------------jQd72Luk2Z0w2LdC4ILYnJ0v Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjcuMDIuMjMgMTU6MDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDI3LzAyLzIw MjMgMTI6NDMgcG0sIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMjcuMDIuMjAyMyAxMzoz NCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+PiBPbiAyNy4wMi4yMyAxMzozMSwgSmFuIEJl dWxpY2ggd3JvdGU6DQo+Pj4+IE9uIDI3LjAyLjIwMjMgMTM6MDksIEp1ZXJnZW4gR3Jvc3Mg d3JvdGU6DQo+Pj4+PiAtLS0gYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvdXRpbC5oDQo+ Pj4+PiArKysgYi90b29scy9maXJtd2FyZS9odm1sb2FkZXIvdXRpbC5oDQo+Pj4+PiBAQCAt MzAsOSArMzAsNiBAQCBlbnVtIHsNCj4+Pj4+ICAgICNkZWZpbmUgU0VMX0RBVEEzMiAgICAg ICAgICAweDAwMjANCj4+Pj4+ICAgICNkZWZpbmUgU0VMX0NPREU2NCAgICAgICAgICAweDAw MjgNCj4+Pj4+ICAgIA0KPj4+Pj4gLSN1bmRlZiBvZmZzZXRvZg0KPj4+Pj4gLSNkZWZpbmUg b2Zmc2V0b2YodCwgbSkgKCh1bnNpZ25lZCBsb25nKSYoKHQgKikwKS0+bSkNCj4+Pj4+IC0N Cj4+Pj4+ICAgICN1bmRlZiBOVUxMDQo+Pj4+PiAgICAjZGVmaW5lIE5VTEwgKCh2b2lkKikw KQ0KPj4+Pj4gICAgDQo+Pj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvZmlybXdhcmUvaW5jbHVk ZS9zdGRkZWYuaCBiL3Rvb2xzL2Zpcm13YXJlL2luY2x1ZGUvc3RkZGVmLmgNCj4+Pj4+IGlu ZGV4IGM3Zjk3NDYwOGEuLjkyNmFlMTJmYTUgMTAwNjQ0DQo+Pj4+PiAtLS0gYS90b29scy9m aXJtd2FyZS9pbmNsdWRlL3N0ZGRlZi5oDQo+Pj4+PiArKysgYi90b29scy9maXJtd2FyZS9p bmNsdWRlL3N0ZGRlZi5oDQo+Pj4+PiBAQCAtMSwxMCArMSwxMCBAQA0KPj4+Pj4gICAgI2lm bmRlZiBfU1REREVGX0hfDQo+Pj4+PiAgICAjZGVmaW5lIF9TVERERUZfSF8NCj4+Pj4+ICAg IA0KPj4+Pj4gKyNpbmNsdWRlIDx4ZW4tdG9vbHMvbGlicy5oPg0KPj4+PiBJJ20gbm90IGNv bnZpbmNlZCBmaXJtd2FyZS8gZmlsZXMgY2FuIHZhbGlkbHkgaW5jbHVkZSB0aGlzIGhlYWRl ci4NCj4+PiBUaGlzIGZpbGUgb25seSBjb250YWlucyBtYWNyb3Mgd2hpY2ggZG9uJ3QgY2Fs bCBhbnkgZXh0ZXJuYWwgZnVuY3Rpb25zLg0KPj4+DQo+Pj4gV291bGQgeW91IGJlIGZpbmUg d2l0aCBtZSBhZGRpbmcgYSByZWxhdGVkIGNvbW1lbnQgdG8gaXQ/DQo+PiBJZiBpdCB3YXMg dG8gYmUgdXNhYmxlIGxpa2UgdGhpcywgdGhhdCB3b3VsZCBiZSBhIHByZXJlcSwgYnV0IHBl cnNvbmFsbHkNCj4+IEkgZG9uJ3QgdmlldyB0aGlzIGFzIHN1ZmZpY2llbnQuIFRoZSBlbnZp cm9ubWVudCBjb2RlIHJ1bnMgaW4gdGhhdCBsaXZlcw0KPj4gdW5kZXIgZmlybXdhcmUvIGlz IHNpbXBseSBkaWZmZXJlbnQgKGh2bWxvYWRlciwgZm9yIGV4YW1wbGUsIGlzIDMyLWJpdA0K Pj4gbm8gbWF0dGVyIHRoYXQgdGhlIHRvb2xzdGFjayB3b3VsZCBub3JtYWxseSBiZSA2NC1i aXQpLCBzbyB0byBtZSBpdA0KPj4gZmVlbHMgbGlrZSBzZXR0aW5nIHVwIGEgdHJhcCBmb3Ig b3Vyc2VsdmVzLiBJZiBBbmRyZXcgb3IgUm9nZXIgYXJlIGZ1bGx5DQo+PiBjb252aW5jZWQg dGhpcyBpcyBhIGdvb2QgbW92ZSwgSSB3b24ndCBiZSBzdGFuZGluZyBpbiB0aGUgd2F5IC4u Lg0KPiANCj4gV2Ugc3RpbGwgc3VwcG9ydCAzMmJpdCBidWlsZHMgb2YgdGhlIHRvb2xzdGFj ayBvbiBtdWx0aXBsZQ0KPiBhcmNoaXRlY3R1cmVzLCBzbyBJIGRvbid0IHNlZSBiaXRuZXNz IGFzIGFuIGFyZ3VtZW50IGFnYWluc3QuDQo+IA0KPiBJIGFtIHNsaWdodGx5IHVuZWFzeSBh ZGRpbmcgYSBoZWFkZXIgbGlrZSB0aGlzLCBidXQgaXQgcmVhbGx5IGlzIG9ubHkNCj4gY29t bW9uIG1hY3JvcyBhbmQgSSBkb24ndCBzZWUgaG93IGl0IGNvdWxkIHBvc3NpYmx5IGNoYW5n ZSBmcm9tIHRoYXQNCj4gZ2l2ZW4gdGhlIGV4aXN0aW5nIHVzZXMuwqAgT1RPSCwgcmVtb3Zp bmcgdGhpbmdzIGxpa2UgdGhlIHByb2JsZW1hdGljDQo+IGRlZmluaXRpb24gb2Ygb2Zmc2V0 b2YoKSBpcyBhbiBpbXByb3ZlbWVudC4NCj4gDQo+IEknZCBwcm9iYWJseSB0ZW50YXRpdmVs eSBhY2sgdGhpcyBwYXRjaCwgc2VlaW5nIGFzIGl0IGlzIGEgbWlub3INCj4gaW1wcm92bGVt ZW50LCBidXQgSSB0aGluayB0aGVyZSdzIGEgbWlkZGxlIG9wdGlvbiB0b28uwqAgUmVuYW1l IGxpYnMuaCB0bw0KPiBtYWNyb3MuaCBvciBjb21tb24tbWFjcm9zLmg/wqAgSU1PIHRoYXQg d291bGQgYmUgc29tZXRoaW5nIHRoYXQncyBmYXINCj4gbW9yZSBvYnZpb3VzbHkgc2FmZSB0 byBpbmNsdWRlIGludG8gZmlybXdhcmUvLCBhbmQgc29tZXRoaW5nIHJhdGhlciBtb3JlDQo+ IGRlc2NyaXB0aXZlIGF0IGFsbCBvZiBpdHMgaW5jbHVkZSBzaXRlcy4NCj4gDQo+IFRob3Vn aHRzPw0KDQpJJ20gZmluZSB3aXRoIHRoYXQuDQoNCk15IHByZWZlcmVuY2Ugd291bGQgYmUg ImNvbW1vbi1tYWNyb3MuaCIuDQoNCg0KSnVlcmdlbg0KDQo= --------------jQd72Luk2Z0w2LdC4ILYnJ0v Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------jQd72Luk2Z0w2LdC4ILYnJ0v-- --------------XEftNcsfbB6L18k10llmbvUx-- --------------SZq1cpJCjn23uZP0tz7Axc27 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8ucsFAwAAAAAACgkQsN6d1ii/Ey/E 2Qf9HqUP0vC5pMiEMvV4y6msqqh4B9sU1QQnsPOfrjeb4EfavAu6ClrCuN5VsGa2BWOGxJPbEpAH T3FVDoEVN380UPtaN5r/kTAkDzDNEg2yv5gDoaO0udstptVxg5RnDiAwxnaulFsMMZplv/HQXGka GCiyYei9IXb1nyQl8VXXya9d7d/yqL0UT4HQeNSdn7wHXOy6JQ0ZDLiupidub+idXPE22aLzNmlc JmGkdCPQYoFSG73338ANDy8EbSYoFjxBx2OUr/GIrYArxh7qVHsNhbvNr3AZDNUQgoI/EvmP+TZ/ wGF72fb07JN+T9QL7Qy/ttYrpy9ml357HVXUNzzykA== =D3eL -----END PGP SIGNATURE----- --------------SZq1cpJCjn23uZP0tz7Axc27-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:12:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502597.774462 (Exim 4.92) (envelope-from ) id 1pWeF8-0004bQ-AY; Mon, 27 Feb 2023 14:12:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502597.774462; Mon, 27 Feb 2023 14:12:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeF8-0004bJ-6s; Mon, 27 Feb 2023 14:12:42 +0000 Received: by outflank-mailman (input) for mailman id 502597; Mon, 27 Feb 2023 14:12:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeF6-0004bD-BK for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:12:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7e1a::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca17dedd-b6a8-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 15:12:38 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7941.eurprd04.prod.outlook.com (2603:10a6:20b:2a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:12:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:12:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca17dedd-b6a8-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vg9npoC7ScTv/fZCCxnHmB5YgU+nK+JS1kmCVBiUl96+L0L798vdy9uVO2umSuwLp9AZhf4P3aoxpTkl4525D8Y06ItOGuM7AXS07vAhsEAj3r3wZmQuqmvJcSUah30gBu0sL2QtI0UZIVbq8OhqEyMzTkAi3L1drEm93cHxXSzLpqHcvq+HInNPDaPaGobCfj+i+DUSvhmRIyajXa9Zo9/FMB1LcCxGD/2f788n3aebXtIp/mWfEHd82VOKc3AoVJjEb40foWjNxrFGqNzH+ClJ5gEnanxkN9l6T3CLXZcliEeRfy9ehcFk2BUJE9QPg8tJNdxXxpIsS0Y0qJ6/4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WQ91IXZhrrx8D3X41KN6MM1VzZYrwKvYfNIp7BnIAt0=; b=Ewf1qV8EL5hkH/Illq4y8AuW9StEH+pUEPFjWPFs4bvUuwX1TQGZFtCO2NbwcC4jqsy5+Xsaa0+3ZiFFj4f0yMNtgLe+Z/p6MyNxPPWvPxW7/UtacpcYejizUYt0r33AO0N/xRK9nZvwTPZMXszyzbAUCpZfztkhEeVPPltl2Xa0HtVnSrrJ6uBYuTWDqOOQhexQGrgPktXqTcjYPTqJG+Vp2B+XvSu41UITjH8A0Llk4eYxGabsnS992iI4vwGj1wEzjEDoR6kJk/N2bIESyWXgAm8S5Xk6+ghxDF4YAdcKSDgYW0JP5qJECkjmvDa+8IXcYOYYhp/4XpLDhd1V0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQ91IXZhrrx8D3X41KN6MM1VzZYrwKvYfNIp7BnIAt0=; b=JrCbX/hc/Xqj4BFTYytbaoJTBcr6Dt6ZlscEgC2uJUhelJc8mwhuVGRdg3gIrIkVPepFIjJ6Q4MOxb1AxfemYAd3HnL++zX1EdCvnUledbFn/2rb8Xw942gWYzzpeYZXvHtXZ7/SIBypabTMvGqQT8hZ1eCbzdl520A1NUEvtzuZ+Sxi2qZxM9kwnwHddelIpzUvMwUDXuY63GeZN1jIG7JyPedj4vxSgX//C0eCE4xUMQyqGOicSK8Ohr//JNdj7JZ2zgUyuv48gCiJO0XYDh9uB+5LITM3WWSX1ncog5JV+dpMeJHyryZOIT/FvfQTcELMudD3qKltWoBXdP7MJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e933169-a5a6-08b3-aae3-8ebef988fb8a@suse.com> Date: Mon, 27 Feb 2023 15:12:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-US To: Andrew Cooper , Juergen Gross Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> From: Jan Beulich In-Reply-To: <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7941:EE_ X-MS-Office365-Filtering-Correlation-Id: 043223cf-e31b-4817-bafd-08db18ccad67 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VkJS7bVRZrluhw8qCIAG4NycxbxFiJZYgrbjiPe5wZyUlrQ/o7zOdZmGgex8Y79/oE1ET6XhRttEDiMqPJh+ufUDdnQiRzUzBHj70YDmBLcCGUeaRrn4K3+uFDpOnwNieG13hWDfjBL71bu3pnMIv6ynMncs0y05ffcNsiOzj7S30nOmtBmLtWQeo7Es9FFNFQryZMUR5Ys93Igwg3UI7kDJva8nOfbruVE4wbW9/QxXG0O2cD+ICqAGPWssxnd4Tk2P0nqJRHf1UmxPYiMWD2fBTxG8jMHr49njBDw2CsTwC7rA+9N3dl/m0gsII8ALbd1UriBrrN3Mdr3j0HVUTMzBCISdaOBoCB3u+yTxtWtR5IRFmgoewy4+aojalFo4wnJ/wyfe4MVTf2k0WBSc42kGVfG4Fya+xw9yugC1WdcxHTLDahTqhoW3SY9zdTDDM7lf+we+QBkAI1jknf64bgTmPTPOlB3Q0O+zQVA7A/HFoavVIDkmY1ogZsrFFHp0FEYeBIjBRj90HMix1e7OXS6EX1+aW2ak3QBuEfIr2uBTmohnThB0n9BZF6ohDlk2w5i/2QXjFEYZri4eBe58P8mDXaJyOc++aqxgxUSLGts+3wJIqn4XVmNSj1SkekoUo4FafejoQSvT3CMS7q4A8lJMJaKzSf2aVb326u3Nhp/CX5g60jZE/dNBxNFOEOByeZOERGk9+WAZQ/SMJJ13I6kQiEeNmecaFiycRamHyf0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199018)(8936002)(2906002)(5660300002)(31686004)(41300700001)(66476007)(66556008)(66946007)(4326008)(8676002)(316002)(110136005)(6636002)(54906003)(478600001)(6486002)(26005)(186003)(6512007)(53546011)(6506007)(2616005)(86362001)(36756003)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE05UmtXZm12eHF5YjlMNzlGeEgxdE5RaWVTTTJ0OGtZQVBtMGdabEZCdjBB?= =?utf-8?B?NWRaS1VSV2ZOdTN0S3BkOW16NDZtdHc4NWdTOVI1WW9md3N3Nmo0dlIvNFVD?= =?utf-8?B?NDRqemQvSWxqZDNTeDNkQnUxM1kvN1Y2am9XNk9zZmhuUUR0SThsakpTZUxD?= =?utf-8?B?VEt5OCtXcmVVS0NOdVZPT0RaQXRpTUsvTVdrMWhnMllZMmNBN3Q5YThUVy9k?= =?utf-8?B?WHIydkY0MXR1TFNBdjkrbXUwZlZJUGh4Y2ViUmg2dUJLT296YUp6N3ZtUFV5?= =?utf-8?B?K1hpQXRjTUhQSTBPQ1ZrbmpPZWhNZnlxNmZJd1h5TnRaZ3U0Wnh6RkthelhZ?= =?utf-8?B?ZVdWRW92Qit4QXpkT3Rhc2VXSU40UkU0emFOdkJLSVNib2E0a3R2TnIzWDZS?= =?utf-8?B?WDNiekVLRThYQ2I5cXlIS1ZKc01OTm5GazNiV0k2R3Jkc3AxcHI4dzF4aUdu?= =?utf-8?B?czhxL3lFaDRJMGpWMVdaaWlJeUZPQlZnZjZDbGpTekRQVHFKUlErMnlYa2U0?= =?utf-8?B?QzZvSWxqQnZ5a0lVU1F4SktWckpZQmZIamxuekhXdFhYaUNtM2RzYUNXSmVm?= =?utf-8?B?ZEhxV3BRdzl1d0MvVjFxeTY5SytzajQrZEpaajRMTUdvZkhWOG4wNElxNHdj?= =?utf-8?B?K2Q3QllnMUtzSm5JNXV1czREV3BMNWMxNjVJYW5GQ0hwWHdDQnYrR1BUdEdx?= =?utf-8?B?cVRnWDFKK2xkMHl3Y0hFaFVPYldFSkRjcE9NWUsvVFU2WWg3Wk81S01HUVVw?= =?utf-8?B?YkFMSGEzWjRhN0UwRWY3cWdRT2N5Q0Q1djJzaEZRUDN1NlVCMk5lZmR0YjdS?= =?utf-8?B?b1F6ak5tZTc2Sk5ZbWt6bzFLcFdGZkMxcUpJcTZ5bEZWbDJCWW4rY1dDMEt5?= =?utf-8?B?VzdwM0dmdHpDZ2xCc1N0Q0xTcXFXQlIzY1RzdEViVFdwcGh4K1V6TUNjZ1Rx?= =?utf-8?B?ckUwQUFESmE5U09wMVlLUGRBc0VpVzRmcnRBMHcyUldqbHY3U25NRUM1N2Zm?= =?utf-8?B?Skh1U1doS01TdS9hWUhJdnZpdDlpcTZtNW1VcWYwSlVzVVdwbHgwdWdMaVc4?= =?utf-8?B?TFJBVzNwR3puYXV3L1dFamR0dENxNHNZTW00cU9hcGUvdXdTM1RleGhocHRo?= =?utf-8?B?YWI0bGpnTU0rTHdkZGt5ZG1Dd3Q3TDkwQzAvZ0I1OVJpVVZyNFdscWtuWEk4?= =?utf-8?B?Vkxrb0tEU2F3cXBZZ0NSSU5Hazhld09vN3V5dmFpcS9EajRMUnR4b3MrMFVZ?= =?utf-8?B?aWtLUjBwOHozeUl6clF1c212ajVQbWVJK1oyaWlZVEJoelVFZjc1ejhUa0NJ?= =?utf-8?B?TEdoNkh4M2NiQVZBcDBENjQvZHg0OC8zSllGWEtWMWoyQ2dROXgyWUdZSWt2?= =?utf-8?B?dVVURUw2UHRrN2J6WG0ySjE3MDNnS2YzOFFZTWJaM1FYSFpzTERxdWlPalY4?= =?utf-8?B?WEg4UGcxZDROTitYaWlUZ0JoVDhOY1FsZnBVYWpVYkc5bzJiQXhuQmh0VEZC?= =?utf-8?B?aHFBZDY1NU1TdVRaeWZRenFsdG0wRmlzbHNnUEI0c1ZFZW5BK0tkZVFUSkFN?= =?utf-8?B?TEJKVE1aMndFd2dsVGlyNzRQQTFNUmpxbVVSN0I5K081NENyT1BHVU9NRmpj?= =?utf-8?B?eUJEckZOelRISTBUMVMvTUdVMXN1bjlWY2ZNTzd6ZWd2RTlQbDFOUURrMmdP?= =?utf-8?B?aWNpM0x2V2hBRy9vc3pvTmFnTVFjb3cyU1Y2aXlEVEJjbzQzL3pZZWJFOG1F?= =?utf-8?B?L24wVmRGcGRxTXB5cFdVRDI2T0M5Y2FSWjJ5RHNoTVlNSDZvNmJlUG9tLzM3?= =?utf-8?B?R1YvNUNUSFUxekVqckVaekVkQ1N0OUpaTGt0eGtiOUh5K0lkS2tTNlYvbGZt?= =?utf-8?B?eEtXRTFYeHVzWlpZR1pQU0JsbDh2TGptOVd3YkwzMjRhblN4Q0xwVjVibEs1?= =?utf-8?B?ZTR1TnlOb0x4RkxMZGRkVVZ5dG9mbTI3VjNYQnlGWXRlTVZnOFR5ekJySXl1?= =?utf-8?B?NDlUVWU5UDF3NEswN1dldXMyZDNXbG02QlZsejlnVm9iK2k0VGhPaElmSmFz?= =?utf-8?B?SGlJQTEraVdkTndwRTZiZmNxQnM2N3dWKzRGUWNoYlNkUFdFa2V1dEJpak8x?= =?utf-8?Q?IJWqisnwyidRojT13hsGd6a1a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 043223cf-e31b-4817-bafd-08db18ccad67 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:12:36.5802 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HggwvHDGoxmo5BYxEzM0WFVPgXSlmHE2dIIhTiwn0szcmLSHLgByfTArOlWlwEmzme7YJM/ZfxsvTVR5Kda6Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7941 On 27.02.2023 15:06, Andrew Cooper wrote: > On 27/02/2023 12:43 pm, Jan Beulich wrote: >> On 27.02.2023 13:34, Juergen Gross wrote: >>> On 27.02.23 13:31, Jan Beulich wrote: >>>> On 27.02.2023 13:09, Juergen Gross wrote: >>>>> --- a/tools/firmware/hvmloader/util.h >>>>> +++ b/tools/firmware/hvmloader/util.h >>>>> @@ -30,9 +30,6 @@ enum { >>>>> #define SEL_DATA32 0x0020 >>>>> #define SEL_CODE64 0x0028 >>>>> >>>>> -#undef offsetof >>>>> -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) >>>>> - >>>>> #undef NULL >>>>> #define NULL ((void*)0) >>>>> >>>>> diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h >>>>> index c7f974608a..926ae12fa5 100644 >>>>> --- a/tools/firmware/include/stddef.h >>>>> +++ b/tools/firmware/include/stddef.h >>>>> @@ -1,10 +1,10 @@ >>>>> #ifndef _STDDEF_H_ >>>>> #define _STDDEF_H_ >>>>> >>>>> +#include >>>> I'm not convinced firmware/ files can validly include this header. >>> This file only contains macros which don't call any external functions. >>> >>> Would you be fine with me adding a related comment to it? >> If it was to be usable like this, that would be a prereq, but personally >> I don't view this as sufficient. The environment code runs in that lives >> under firmware/ is simply different (hvmloader, for example, is 32-bit >> no matter that the toolstack would normally be 64-bit), so to me it >> feels like setting up a trap for ourselves. If Andrew or Roger are fully >> convinced this is a good move, I won't be standing in the way ... > > We still support 32bit builds of the toolstack on multiple > architectures, so I don't see bitness as an argument against. Bitness by itself wasn't the argument. Mixed bitness is what concerns me. > I am slightly uneasy adding a header like this, but it really is only > common macros and I don't see how it could possibly change from that > given the existing uses.  OTOH, removing things like the problematic > definition of offsetof() is an improvement. > > I'd probably tentatively ack this patch, seeing as it is a minor > improvlement, but I think there's a middle option too.  Rename libs.h to > macros.h or common-macros.h?  IMO that would be something that's far > more obviously safe to include into firmware/, and something rather more > descriptive at all of its include sites. > > Thoughts? Maybe. One fundamental requirement would need to be made prominently visible in such a header: It has to be entirely self-contained, i.e. it may in particular not gain any dependencies on configure's output. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:17:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:17:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502604.774472 (Exim 4.92) (envelope-from ) id 1pWeJe-0005HV-W8; Mon, 27 Feb 2023 14:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502604.774472; Mon, 27 Feb 2023 14:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeJe-0005HO-T7; Mon, 27 Feb 2023 14:17:22 +0000 Received: by outflank-mailman (input) for mailman id 502604; Mon, 27 Feb 2023 14:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeJd-0005HI-My for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:17:21 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 704c6f68-b6a9-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 15:17:18 +0100 (CET) Received: from mail-bn1nam02lp2042.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 09:17:11 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5014.namprd03.prod.outlook.com (2603:10b6:a03:1e6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:17:08 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:17:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 704c6f68-b6a9-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677507438; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=g8ZBbL6Zz79uxG8s769cQPheHMYZrBcW2zzJk2q67NE=; b=dYJATMAdcnLodYUDu5fZUCa43Z0gwEHUpcU/X5XdNAWHu2vlsq7AVYQ9 77muE4PgIYWb8wHQKR75a+DgNXmueehQISUoJjJUvxX2F3kUC4UIpfzNl c0/2C4uyu5625onfimK0n6PzOGyVz1cBp5n5S+dUUWK3dLFMYgjawh/QP Y=; X-IronPort-RemoteIP: 104.47.51.42 X-IronPort-MID: 101110974 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6nlmP67X7Tu+DjEsEOguowxRtAXGchMFZxGqfqrLsTDasY5as4F+v jYWWWGFbvnZNzOkKNpwbIrl8xlUuZ/WytRhTlQ6qX1nHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPaoR4weE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 rsfKQ4QSRu/msmyyayjYLQvh/5gM5y+VG8fkikIITDxK98DGcqGaYOToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OlUotitABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdpLTeTgp6E26LGV7i8eGEY/cH64ndfjjg2lcupzL U8w4hN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8ywSWHG8fVRZadccr8sQxQFQCy Vuhj97vQzt1v9W9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJuuPC4awh9zxXDv2m jaDqXBkg61J1ZJRkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshUZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:zuOauKOm/WP4vsBcT+b255DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjzjSWE8wr4WBkb6LK90dq7MAnhHP9OkMAs1NiZLW7bUQeTTL2KqLGSuwEIeBeOvtK1t5 0QFZSWYeeYZTMR46fHCUuDYq8dKbK8gfmVbJLlvhNQpHZRGsRdBmlCe2WmO3wzYDMDKYsyFZ Ka6MYCjz28eU4PZsD+KmgZU/PFr9jrkoujRRIdHRYo5CSHkDvtsdfBYlKl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ+37P449QkN7BzMIGIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmR0Xue iJhy1lE9V46nvXcG3wiwDqwRPc3DEn7GKn4UOEgFP4yPaJCA4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn93d7VTBtn/3DE7kbK0NRjwUC3Y7FuKIO5nrZvv3+9161wXh4S3bpXUd WGyvusocq+P2nqK0wx9VMfveBEFk5DYituBHJy9/C94nxuh3Z+wFIfxMsD2lk91L9VcegD28 30dp1ykrdAV8kXar84Itwgb4+YNkzhKCi8d157BzzcZfo60rb22sbKyaRw6+ewdJMSypwu3J zHTVNDrGY3P1njEMuUwfRwg2TwqUiGLEbQI/tllu1Ek6y5QKCuPTyISVgoncflq/IDAtfDU/ L2PJ5NGffsIWbnBI4MhmTFKu9vAGhbVNdQtscwWlqIrM6OIor2tvbDePKWILb2Cz4rVm72H3 NGVjnuI8dL6FytRxbD8W/scmKofla68YN7EaDc8eRWwI8RNpdUugxQkli97tHjE0wwjkX3Rj oPHFrKqNLLmYDtxxe204xAAGsiMnpo X-IronPort-AV: E=Sophos;i="5.98,332,1673931600"; d="scan'208";a="101110974" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ik2WYiAo8gD+Bcs+j0ef38uU4N7HXr9K3n9mrUsrGbpkkT1BxzWyNE1mS+UK7SMjAnL/HSddW769YxngJf1D+0M2sz4dBUMKqDS1Xka2MpgbOWfwi2YhpkcyJwCULeTrxXDQxQbBynEhcGoLjjnX8Jl8hbj70Y6xYcrdF8LhhMnroWSgApSZTA7py1p/fOi1CH/45n6fdUNTNPKmMd6brr2tbVttNy1OJS9CwROg7DBWLZUfcohXY8kk6gnCwu0qloNOkqdVCpjjZ7hhIJdeq1OzLmhBme2O5/4XOLaprHA/WPXxEU5gGVFUjg5pNIuHoQBrJml2taGKy2QNesz6pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ueNVcfBc8YyM5ix0ulceWEu3ffLjDMdmh/rKYiuR8Qo=; b=C6yoCAZE5LOeS7EAO44AxS1X0GxW22sAKBd6Fzx2OnmJRQRW8dB1lT23IiW11zMUA36mHWuVs6QZ3eHcnVje1bDkY3VqJ1Zz0tcPNaWJqwZEpHlmXeUZPq43tKsONz7k93FzLU89wlY2rIf3IXeNWmuxo7QjHT+RTPryQFlHntG0/DRbCLi5+pK0Q62wQiRhx2wUUgxkCsDoIZLtZ2g02Q5XyUyRN+ss10lvZ1nVZJhIUuwscJxpp4zCEe+tXBx4xWlfVDDeZauUepn/rt5iXT7D0bjMDCMR453a1lqg9igjb0x+xprlKk9rQVDID/vwOn0O5whQkrK7aY3xy6b8GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ueNVcfBc8YyM5ix0ulceWEu3ffLjDMdmh/rKYiuR8Qo=; b=nfK6sq6qyuGqSANUKW7IreaCq2WGQepYwIxUbbUonIchcc3ni8VJWShHphXTQN/6weT2R//taFh/SgDtzE6XqCZf+QXTgr2OOaSZKbXbDH91EOfeGJqPl0m8v4o0W4WI2sIkpr77W0mf4Iw4VjvGJxq8+nVcblK7V6ndEmiJOd0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <0f00449f-ab65-62cc-03c3-8f53b5f1251d@citrix.com> Date: Mon, 27 Feb 2023 14:17:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h Content-Language: en-GB To: Jan Beulich , Juergen Gross Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227120957.10037-1-jgross@suse.com> <20230227120957.10037-4-jgross@suse.com> <8865a525-b55d-9b4f-ad2c-fe1f70afd0ba@suse.com> <809b25b3-1e8e-43ee-dc3a-1a54a938c9f7@suse.com> <6a888edc-0b5b-117d-a216-ff28ad7bdc41@citrix.com> <0e933169-a5a6-08b3-aae3-8ebef988fb8a@suse.com> In-Reply-To: <0e933169-a5a6-08b3-aae3-8ebef988fb8a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0293.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5014:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d926dd1-5a0b-4577-0fda-08db18cd4f4b X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yFio+re+Odx6wtTUu049JzWxymdV0gdTyi0Jb8u60dMOb4RrFaMXMdQRHe5QlVbfbjWAERSlGabfYkyk3YdXZtEQCeu5wASNjoxYgzqETTaBa2JO+qq2xKO8EkL8T4t1hsauNVtxppKfxBRsHi917+mSm5Mo9iOipOOcuqMJnue832Yg4vfWoR2TgTn+omkrpzVpNrZzYjAjLD6oyL/hDpSvMdMCWpEO2yEm+OhpNchdes2joZAiiBeyVjcX1fQa56S1njD3vVfkF5gAQL/9e0FMPbeb0kV2brYuw+rWO494BvLbyBO6LxT93YHR9LA+GrWd/F6PeyekXASCVT+wepDvmyiC1Wm87GihjzDRwtvzZtqtVVGyQndhpD7pZGkBJVoL+JUXYjZYQYeDZZfERvYpO5IViXyAlhvED31xUk3664ZxChSN5W0RV1gBbdvTLDAut2Gbsf3tlifo2K3fBmih7QJShjPQyt0EsIXou1lo1o6a68RM/IzZUbSZYHEFufdTxDSIdjgdIgCpO0VPyfBLQr17lzKfXP37D36Jg1ugJ4CWlaNoQXfivgRWDzA/kD83msiiJcDx/HGd+a3wKccFtDT64970Yhuz2EB1jYFgBgCfrITU1HliM6CtvkkHRgPMIWmrGW/Qcwt9gEI0zxh7eFFOudCc6mqOk00BlYMCS0kzmXwPhlTrwCg/CUPioFvgCIFRHg5hTtHYr8eBXBf3fzLbHp3xx0n5QBkdhrU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(451199018)(316002)(82960400001)(2906002)(31686004)(31696002)(36756003)(5660300002)(8936002)(86362001)(53546011)(6506007)(6512007)(66946007)(26005)(186003)(66476007)(4326008)(110136005)(8676002)(54906003)(66556008)(38100700002)(41300700001)(2616005)(478600001)(6486002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkw5TkNhVE9oUitRUlVvZXJKLzZKeUlvdVNsOVpYZjhQOElIRXFZNkl3NzlD?= =?utf-8?B?czByc0lTS3dRbXJhVVgrMWlCNnlBM3VJNTVoOUwrTEQwcUpjY1VhZjFQRE5x?= =?utf-8?B?UlE0NDNhM3BvMzB3Skl5ZTBBWG9heXc3NkxqQTFtei9tY05KQ0ZiMjdab3cz?= =?utf-8?B?bjczNWdKTzlmYkVLd1JZeGs2NUxaVUxBcUh0Z1NIcmNTYmpIK2FhTWZHRTFH?= =?utf-8?B?a2xwb241MlFZT2o3RWJDWnF0OFEyelFaSkEzeTkvbWRYVzFtRWVveVA3SlVM?= =?utf-8?B?MWRpRVovY2dIcnRublkrWjZsYXQ4c1B3Y25pOVJyRFljb2xFTTRSK05Nd21J?= =?utf-8?B?ZnFQZmE1SWxhWEczdnNaVXV6a2Z0RnMvblI1UHA0ZWtsK3JtQ0xVS1E0RVQw?= =?utf-8?B?OFY1ME42cDNWamVZV0krOVg0TkdtMWhlTWtWaEFMSlpadU5sSUxaZUNrQ1Ba?= =?utf-8?B?TmlUa3ExREQ3TmxhVmtXZW5CUCtrSnhsdVJoTkM1UzlmMGM5NTFYNm05LzNw?= =?utf-8?B?SHF0bXFyc3VIc2RBRGxOdndGVHoyV3diUnpFNHY3REQrQXNaNGowNmFSd2Nk?= =?utf-8?B?YjVrVDcwL1dlbnZzQWlkOTRvaW11dWo1N2g0RWh3QUdYNlBxbFd6UTMzOVlW?= =?utf-8?B?blRIcjhRc1ZScGwvbGxIRXlFdjdKLzZmckxlREFQdUFoOXltWFFSTkRWNUtw?= =?utf-8?B?enBkN2NodGROdmRhYWhOTHRDbWhNbkZrcS80QlFiTlFLaWtCUFJ0ZVhCV2NV?= =?utf-8?B?N3Z6cWR3Z2tGYkdZWG4xQ0xhNk9zczZlT2s4RXpUVlNNcUIySEt5MWhZNURO?= =?utf-8?B?WThzUU4wOUtoK0N6NU9yenptTFU2emc4RTBHN0cvaFF4NXhWdjhBZkk5ZG9z?= =?utf-8?B?MU14eWcxNnd3QXVaMm1EQW9Bd29mVTFvZE9YT2xVOHpxWnlHK3pFcnorMWRQ?= =?utf-8?B?dzJMUUl1Szg4NWNjRWNWWG5qeU40YmY2dncrcnRVM1QrckRwZWtLTEo3Z2dr?= =?utf-8?B?Z2QrU05JaTFNOFd0YnBVUGF3ZG5la1pWWlh6NEQ1RTNQNm1qeXovWUZ5L0VD?= =?utf-8?B?SnpWbzdxTjZRVkNXZG9BZXJQcGQvSU9yNmN0YjZnc3NqK1daclFHbzJmbytB?= =?utf-8?B?blVqTU5UMkpiV1I5dHdubFB5aTFlOE1raWsxSDdWbnRXQjNBTEowZXdvbUJN?= =?utf-8?B?Z3o4dnBCbElFdFIySWdlQ0xxSTcydEtDS0xiMzBmWWNSTXZyaTRBQk5nTUpp?= =?utf-8?B?SEZTYXlOaUM2Sms5Vkl0M3U3TzVtR3ZkOHB4ajBUL0IydlZIZnB6aWozdDJo?= =?utf-8?B?M1dNalVlY29yUjRhWHcwMWd1NW1rdXRncjFaSFBvVnhHcWtmN3lIQUpUTkcx?= =?utf-8?B?V1JQSTlsSVdId09VV09MTlVZZ1I2Unp3eHRpY3UwWXRTYWw3N2ZwU1ZPZzJz?= =?utf-8?B?WTYydnhZS0IraGJUOGl0QjVqRVNkRW9ZckRUT2pieVBTSWptaVNSaWFWdWV2?= =?utf-8?B?TUtwL2ErTUtNM2RXR1M0Z3h0TzFvblQ5SVJxSC9nRUp5MFBMeXdVVlFyYjJE?= =?utf-8?B?VmdxeWVMNisyL3dNRzhoR0UrSFAyOXFDZEhQNjJ4TjZ6QXcybWR4WndHOTk5?= =?utf-8?B?Mjk3c1JkT1UxZVF4TXhMaEFQT3ZBYlQrNzQxeEIyS2FxV2oxaFRjdlQzOCtr?= =?utf-8?B?cU90cGhuQTJieFhVTEVtN1FzUS9LM2Qxd2RML0JoQWFpTG16NmxNYVdBd1J5?= =?utf-8?B?VFFpRUFRYVM2UWVRZHNWMW5vaWV2b3JEMUFjQldBTm1pSFhGSlpnNVYwa3d4?= =?utf-8?B?Z1NJNlBVU3d5QU0yWGUrZGR2S3krc2UvSzc1MFRXVGN4eXFaclJUaUpVdVNJ?= =?utf-8?B?VExWZjc4RmhqOXNuOVdDcFRwQTJRRUd5aDRTZGhjWkF6QkxOR2loNmsyM0Vq?= =?utf-8?B?THhzczZ5L0NXSkhRcEl3VlJtSy9zTHRPempKaDNsMmEwUUNRQ2kwRmpRR2Nw?= =?utf-8?B?aG01UzhmY1U4Q3RFbTVldlNkNE4waW9kZXFhME5LZElKYVd4d2pKRHFiaGN4?= =?utf-8?B?WjBkWHF6ZGx5cG1sWkp6YXF2TmtZZWxFNis1aXZhb1Z6TUFKbUU3UXZBOEhk?= =?utf-8?B?VWJEYTNwelJLVmNmQllhK0Z4NktXL0FYQWJackNuMlZ0Mzd6NldBWnczZEl4?= =?utf-8?B?OFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: McK8BgwuTz+2DE1FtpRD/vxB2qoTfmSZbvW5cOgPtbNPeEoIhssGUc0fWGUju9jqI3t5naGFPDXxq3oDQtwbEyfU6VgFPN4sbj92dNym+sx0y0dls4QDgE2leMTVK4z9HtKXtnqDcrExTqdHPjG39UB16a4nfOXc+3/8u5bZU+2hXc7tG8BsYXXR2XWgMz02BCVngG5IzQk3iSXQPmUajaQHnSRw/wYouEAyhOorbqTlaTNVRofPnCl6v1E4L7OPZ1PBZN7GcpbAv1rvGPtWWva+8XqzQ2wneo/VsCArTAmfPaYp66ac7ZeQ11SR9mfY8udueqXVwKxPtRmmtSw+myjiV3cpf54p5r9L3yvg2rn7e5cSugavEgs6YMCncr1m9bQpuD1uqAyhe9gG4uvx2pX79RfaBy7Vhrw0bx9HJ+bhJ1bQAAsHknjZyW7d/szwhg9ikgoWF/2/j7L0NV5yz61gP3yTvQDwvJU0my8ekeaqAHoH2LD23V4oOSg6NURrBOhd3pCZWWQXllrKkqn8m2qm7ZdEIW6hbcCSRrzDAsDaehHQHx71mPPC5kJ2G+T/3Whg25VtB4B2ah48ZyL6hG0MkdPamyJooY2kXDvzEzqQ/Qq1L93rtY2fUvX54rdaXWXoqKC27mFFb2BZ/27Uzn04Nhel9eTkFvBU5iJfWE8DCl0Ts1TX0X5Ofpf3bsOS7srHE5QLTW7wg5G+gYp0WNh9il10cCRU4l9Bk95/S+K3UUlkWnnbI5yLi5rl1qe2GUXzsKAyVUJgJpEPGVnMPuwVaBkaMVYPzZWH02J0feej+WPdyMONYKBG2HbAkSq4 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d926dd1-5a0b-4577-0fda-08db18cd4f4b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:17:08.3238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pOqBhz6umJPVf2KCgDOffJHHpgJbazxJ42faqXPeJ6G/gpkE5+Y3+TPdgHGRO8HAbn+g+RoJ9uW1zuIbbecRcKzFbTZQQ0LdXbzYo5bZZow= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5014 On 27/02/2023 2:12 pm, Jan Beulich wrote: > On 27.02.2023 15:06, Andrew Cooper wrote: >> On 27/02/2023 12:43 pm, Jan Beulich wrote: >>> On 27.02.2023 13:34, Juergen Gross wrote: >>>> On 27.02.23 13:31, Jan Beulich wrote: >>>>> On 27.02.2023 13:09, Juergen Gross wrote: >>>>>> --- a/tools/firmware/hvmloader/util.h >>>>>> +++ b/tools/firmware/hvmloader/util.h >>>>>> @@ -30,9 +30,6 @@ enum { >>>>>> #define SEL_DATA32 0x0020 >>>>>> #define SEL_CODE64 0x0028 >>>>>> >>>>>> -#undef offsetof >>>>>> -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) >>>>>> - >>>>>> #undef NULL >>>>>> #define NULL ((void*)0) >>>>>> >>>>>> diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h >>>>>> index c7f974608a..926ae12fa5 100644 >>>>>> --- a/tools/firmware/include/stddef.h >>>>>> +++ b/tools/firmware/include/stddef.h >>>>>> @@ -1,10 +1,10 @@ >>>>>> #ifndef _STDDEF_H_ >>>>>> #define _STDDEF_H_ >>>>>> >>>>>> +#include >>>>> I'm not convinced firmware/ files can validly include this header. >>>> This file only contains macros which don't call any external functions. >>>> >>>> Would you be fine with me adding a related comment to it? >>> If it was to be usable like this, that would be a prereq, but personally >>> I don't view this as sufficient. The environment code runs in that lives >>> under firmware/ is simply different (hvmloader, for example, is 32-bit >>> no matter that the toolstack would normally be 64-bit), so to me it >>> feels like setting up a trap for ourselves. If Andrew or Roger are fully >>> convinced this is a good move, I won't be standing in the way ... >> We still support 32bit builds of the toolstack on multiple >> architectures, so I don't see bitness as an argument against. > Bitness by itself wasn't the argument. Mixed bitness is what concerns > me. I still don't see how that would matter.  The bitness would always be consistent inside a single translation. > >> I am slightly uneasy adding a header like this, but it really is only >> common macros and I don't see how it could possibly change from that >> given the existing uses.  OTOH, removing things like the problematic >> definition of offsetof() is an improvement. >> >> I'd probably tentatively ack this patch, seeing as it is a minor >> improvlement, but I think there's a middle option too.  Rename libs.h to >> macros.h or common-macros.h?  IMO that would be something that's far >> more obviously safe to include into firmware/, and something rather more >> descriptive at all of its include sites. >> >> Thoughts? > Maybe. One fundamental requirement would need to be made prominently > visible in such a header: It has to be entirely self-contained, i.e. > it may in particular not gain any dependencies on configure's output. That's a reasonable restriction IMO.  Again, I don't see how we'd ever come to violate that in the future, given the current use here. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:24:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:24:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502612.774482 (Exim 4.92) (envelope-from ) id 1pWePy-00072U-ME; Mon, 27 Feb 2023 14:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502612.774482; Mon, 27 Feb 2023 14:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWePy-00072N-Io; Mon, 27 Feb 2023 14:23:54 +0000 Received: by outflank-mailman (input) for mailman id 502612; Mon, 27 Feb 2023 14:23:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWePx-00072H-7y for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:23:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1a::615]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bc6f9f9-b6aa-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:23:52 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9462.eurprd04.prod.outlook.com (2603:10a6:102:2aa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 14:23:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:23:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bc6f9f9-b6aa-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cRqgx5AiC7NWjylDihW6brX46N72TWHpbKc1C7CFxWvDhZ0uel1Ddtucq0TqpPq8La7gCE2SOc+vDA0+MaCb1s7W/0N+QyOjRWxxZQxjUkALOlanKpBhHtW5wwKdYp/+zS2I+Y6Y+GWAzL0Vf0qI0XMAvmEzQ4gNbsHpcZnkaBJmzW7N78pLuLJJC5cEcuVbFiAPF55dGE4FYVs8ai3sV46jYTk2/xrghXEZ3MerlaqXeXxChs6SCw68hA+Bee1tduPUvpcoEdad/iQRMTherNcknipY7LAJTr+B1wYzy+Uc5CUKsXxM278VevK00M5gnPSnu8KpTdJrD+XRkYuv2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XgQhi4mb1Zub5UW11TNvO2om2Z5qAhHfSodVJzg5RiM=; b=YHTcZUgImsFHkbXQUT40Etovpvu8teGc5hiL/z9qeeL4q+Bhzz087yOG7LePSptjmBkzEyqC0ZEhUvEO7rtzdieLPb63RBtha9IANnavddDn9Zi86Pz3LR9e9ihsp5zJKNMGNCNw1kNPyftn5J3BoPGpzCDA3vbh/yP3Y72hGJlGKDWypu+xXdOGRIuskOnLvptPn4SA2RRAMpHBGRk2K3cK8uIwYBQe/HmgmtQD3nkh3i34qmIvT0g71amkLKljIdbXpJyMKCffOc2YCr+bTupLR0ezUn+Vy5Npza32dDZDFRZXPX16XwKIY0fKOOJZkJ2VsSjs85L8Oqgam15sDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XgQhi4mb1Zub5UW11TNvO2om2Z5qAhHfSodVJzg5RiM=; b=1uyq9zt6hRgC0B8kXS19xrcMAKknLxYxJyulFrY9cK4vtRRzLD6VJlk62a6pNtzbTGjYG6cNLEAi6AzzgmS7mWtBIhClmrQGpghxbOK5WJSemebr4VAilY0aBdjPdkkic1Cy2nYaAt/TwtAuK+dOPhpNVaee8TYKNLTcWDKqP7WxXxmVjs4gT/NxaPMMhz1DvM7OJ0k5sBcmrlM1vV0jh9ZIHEFYzTaPFzBLS8nI0bWbDXWCrwIZyFJYBKMWp/agoQ2nHT/H691gb5NeCIHZsJOfjFU+yTHNSRW2xj1kjrMJRK9rSlK+WPkHk+mZApPeUZfttDQdf3yaWFa58EY1+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 15:23:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9462:EE_ X-MS-Office365-Filtering-Correlation-Id: a7a55f0e-e95d-44f9-25c8-08db18ce3ef7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1TTLo5SEiGPRMm9AnfW10VB67bi9U63EBZSS2hTk5jC4lJFX/OvxiDnQOq4cpq7RSdJRgifiixZ8m6sYvKJkRz8+zIkyrwalJPwvMj0oSm6b+yqisrcApe3eLtbebkYaV0dWnf7ZvsFEJBZnnkEW4BpHVAuTyFUAa3xxqDOfeGGC1GXtGeV6gJwT+bLn080qkpVAqzQt5Isrk1w+9DUIXFcyTw/sm5rJebrp359Me8fyBGOd7FGLFaFMdwTs6JaesRIOnoYa+qKQIzPk+yeOy02JqTqnfSFRFJ5KXc9uJKEMRjdcocu74wAPvh59yoqgHe34ojUz6ujRexva2VppFesoUXJfOyYa+upXSP2fyzRmYCwf1PADYoYhSUjZ1CcA7101Xm2mkUEykvh9R3xeJbNX0ulPDY32L2GK0uoDNxjh0E8lS/U6sLqwZz+bplQbhe3Xt/lGDBjdpJYFy/kalxvyeVzjyLB7l2Ck5e21rXz7j8JZaBOoZTmY9jm0me9H5hVSM/0KZShkZ+jbxqYH918s6JXQYQNxu78WiTIGTv9U7gRxuMRJx/hIqJb1gNN6XAkruY4wjiNCLT2as274LmF5C35aTTXQkwjA0Pcov6Dw90X/H0gkd/IHTmj7bsT3MRoePCwCMDXgZ7/ihFHKtFGc+t0yIOPCc7gXaf0iRK0ePSFgOLGeTdMHefXpeO0o3vGP6h/NaGf3sFJajYsIBDEUxJxD7upTJZY7IifKO8npz3y8u/o/SNcg63KZccif X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199018)(8936002)(31686004)(2616005)(2906002)(5660300002)(38100700002)(41300700001)(6512007)(6506007)(66476007)(66946007)(66556008)(4326008)(53546011)(8676002)(478600001)(26005)(186003)(6916009)(54906003)(316002)(6486002)(31696002)(36756003)(86362001)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2JNOXphYTNwZ3prcU0xbGNCZmx2WWVTcUxyNHVtejVaSGFzRlU1L01Wak9p?= =?utf-8?B?U2VLWlNPQzhPQWIxdUdkV3FvaGlCelpCUUVmWEx3dmJQRXlZcjJCN1Vndzky?= =?utf-8?B?LzdmRDBqaGd6d1JkUDNBUlFwTUpkaWgwM3FkeVR1R0VmNHdnS1U3R3h0NjM5?= =?utf-8?B?M1BTZkR3MjhYUFlIbVVZZDVEV21FdWUvK1A4RVlYamRId3VqUSs2b044N2ZK?= =?utf-8?B?NVlqUkhWb1JNL0x5YzV5eXQzU2xPbGZIMEJnb3FBcGlsYXdhdFRyS3c5TXp2?= =?utf-8?B?a2hEcjJGTFN3eGxrVEhqdElZU0lVRnIxN01kUDVJRFRiU3F1YjN0SnZEbXRI?= =?utf-8?B?NmlleXpsQ1FVL1VENThld2J4a2dFNHNkTEIwUnA5cUgwSmNUb0lHVW4rSU5n?= =?utf-8?B?Q2VDN21Gc2pqRW1oR0hkcjBHbmpCSlFILy9ZeEZBWnBuc2tvd0d1azJtbk00?= =?utf-8?B?OHJ2QWtUWWZ4M3RIaFNJWWVTT3Rweis0S3dWdWQ2V1gxbjNVc0hyRmlaZzVT?= =?utf-8?B?dnpSQWJrUDZRQjJBaDBUeG8vdVE5K3lqZWlwUThZTWVNMzN6RlJ0YmtRMUJH?= =?utf-8?B?a1dnWkovMUp0MWRPWDJqb21zYmZmSzZGOUZxSDFtdnhiMWtYMGxEMUdrcmdK?= =?utf-8?B?V3A3VCtqWGtVVWdzTjlWckJoczh6eU14azlxMEVpbXpHdmRrQUFjSU1hSG0r?= =?utf-8?B?TUw0cTYrenpQdmpkeXMyNjZGeHdwWEJZK3NtekxheFhIaDhHQTljc3VkU2Vl?= =?utf-8?B?K3ZZbUJTSHpidi95cm8ybTZWcWlpeXJZQmNRZkUrNUdMVktTbVhKZzVsYlVU?= =?utf-8?B?NEszME9uWFVQVHRKeHVYYUVTRVRRT3psQmZIREhaRk16ZzFTU3Y4eG1HSEd3?= =?utf-8?B?SS94ZmxBUUhoWW8xTzhJMXBGZDFhbjFLNkZTWkg4K0dnQVMrM0ZmdlFwMjVj?= =?utf-8?B?OFV4eVlhejhBSFdwdmhSNXg4c1JJQ1ltVWFjaEdEQXJMTE42N2lKb3UwUEw4?= =?utf-8?B?MXhwTE05OVBHV0xUQVRlYVR3ait0eXg2cGlYRmd0c3B5N1RCdTE1T2FxM0xq?= =?utf-8?B?Z0ZLL0dWREtIcUJTekh3aDB1TzRiaC84ZjZ1L3FZVkhrSHBaUDJ1VzRUdGVs?= =?utf-8?B?S2FBVGJKeEtrb1ZYY2lYTm5MRnZYSDcwRnVDankrdlY4UDRIMVZtdjZKbnk3?= =?utf-8?B?WWVna0Q3cGtJVU1pMUhhRWFVc0xWWGxXRFlOanZORU1wWUkyN0ZQQndQUU5T?= =?utf-8?B?UmR3M3h6ZFdObUxKMmcyMzJYcUxscTIzWStKdXl6d083NUt0MTNVdXpBRXUz?= =?utf-8?B?VHF1OXdyRXFjQzR4NjhyTG94TDdSaFpBY2phS21xbHVBVHcwY3BzZmNSaFpQ?= =?utf-8?B?N2JFV0JXS2gwL2NPOUpvT3l3YzI4cFcvSHZPa0hYNlUvenlNbFBSdmhWWjVE?= =?utf-8?B?Z3NBaTJaaFo4ZE1haFZSSFdQVjdpSTRVLzdxeFhDN1B0ampSTEhVa1RNdzM4?= =?utf-8?B?MnIwZkJYQ1RyUmdaOU95VG5yU2R6dk00T1U1aE1KcXpSV29vTzZkYXVnR1Fz?= =?utf-8?B?Qmt5anc5NnEyeXlSZ21LSE1iWXFQbVpPWHIwUTVvdXdHU2cxcDFwN1Z6U08x?= =?utf-8?B?dnJVRGJSc2NMYVN5VHZFMEtjQmptRzBicjlBTy9IT1ptb09jNG9EOTJTcDdi?= =?utf-8?B?VlRZM0hJQ1V6NGdObnlXMWVHNys2dExPZDVQZWdvY1VUbVorZjZTRkx2YmVo?= =?utf-8?B?cS9NbVFEM21ZZmtzUnVIWjRqTm45TGZzQjhvWUZadyszbTlFUHd3dFdXRFdS?= =?utf-8?B?QlBIVm5OMHZGWEFqR3lMTkdZSnZZbkVFSWRySnp2dWNqY3hFUnRuRzVyTVVU?= =?utf-8?B?U0o4WUZzUFUzNVk5TkIyUVc1dnMwTENEV1l5M2pnaVFmZUZKcHpJa1lzZXVE?= =?utf-8?B?S2dEcmpTZiswQ0JEWG9TVnZrbWx3eElVQnYyclhvUDg0alF1Z05KL0N5aWxw?= =?utf-8?B?VytSZTVWQzIrcmdKSS9QMWxJYWRSTXdYbmVBMXZ1TkczR01yakxhTTI3YVVN?= =?utf-8?B?dkl2NVhvUHhnazFETzVVTDRwRFNOTlhQMTJLdks5VFZwbUdBeVpJc2dXYWZW?= =?utf-8?Q?XSAeU07jdoXNsS3A79gTr29yP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7a55f0e-e95d-44f9-25c8-08db18ce3ef7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:23:50.4896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2t+LrVnCWu6/B6RZKDQHAVDhjq05XljJWajKZmmpswTFBkKgit0ucYpR1Yy1vkFKAAhkezaAhZY2pzWmAoS6tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9462 On 24.02.2023 12:31, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/common/bug.c > @@ -0,0 +1,109 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +/* Set default value for TRAP_invalid_op as it is defined only for X86 now */ > +#ifndef TRAP_invalid_op > +#define TRAP_invalid_op 0 > +#endif > + > +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long pc) > +{ > + const struct bug_frame *bug = NULL; > + const struct virtual_region *region; > + const char *prefix = "", *filename, *predicate; > + unsigned long fixup; > + unsigned int id = BUGFRAME_NR, lineno; > + > + region = find_text_region(pc); > + if ( region ) > + { > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + const struct bug_frame *b; > + unsigned int i; > + > + for ( i = 0, b = region->frame[id].bugs; > + i < region->frame[id].n_bugs; b++, i++ ) > + { > + if ( bug_loc(b) == pc ) > + { > + bug = b; > + goto found; > + } > + } > + } > + } > + > + found: > + if ( !bug ) > + return -EINVAL; > + > + if ( id == BUGFRAME_run_fn ) > + { > +#ifdef BUG_FN_REG > + void (*fn)(const struct cpu_user_regs *) = (void *)regs->BUG_FN_REG; > +#else > + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); > +#endif > + > + fn(regs); > + > + return id; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_ptr(bug); > + if ( !is_kernel(filename) && !is_patch(filename) ) > + return -EINVAL; > + fixup = strlen(filename); > + if ( fixup > 50 ) > + { > + filename += fixup - 47; > + prefix = "..."; > + } > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); > + show_execution_state(regs); > + > + return id; > + > + case BUGFRAME_bug: > + printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); > + > + if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) TRAP_invalid_op is, as said, about to disappear on x86 as well. I think this construct wants abstracting by another asm/bug.h provided macro (taking just regs). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:26:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502616.774492 (Exim 4.92) (envelope-from ) id 1pWeSu-0007dw-3L; Mon, 27 Feb 2023 14:26:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502616.774492; Mon, 27 Feb 2023 14:26:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeSu-0007dp-0S; Mon, 27 Feb 2023 14:26:56 +0000 Received: by outflank-mailman (input) for mailman id 502616; Mon, 27 Feb 2023 14:26:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeSs-0007dj-EI for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:26:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c5e345e5-b6aa-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 15:26:51 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5e345e5-b6aa-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677508011; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Nqe5M8Fw7D9UvEhjRjGprOZkTn/f+LyKBIvp7RmZr7M=; b=Tr9j+g4eTf99G8jjcq4ks0AMEcoKNiNxbEkxe0BY4r5c6FRhI07cmHan rYjIWf7wyvTN/hD+l3g9XyI9J3pYOcgwTbCxlrjpaimu5ENO2VK7NpeJm Wzl3LooDlFSkq7/IjQm/EQ1zllilpz9PEUnjurmHiEAxHv0NMGoRE9rN1 o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97515573 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:H1aTdKN5TnOshtvvrR0Dl8FynXyQoLVcMsEvi/4bfWQNrUpwhWRTz TAaXT/Qb/rfNzf1fN0gb9zi8kNU68OHytMyTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tC5ANmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sRPXVkNp PUmEQEEXCuYhN/r7OugdvY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUo3VGJwIwxnDz o7A10T3Hy4Ta9bH8ieY9yO227LttjvVALtHQdVU8dY12QbOlwT/EiY+UFKhpPCjh02WWtRBK lcV8C4jsagz8kOwStD3GRa/pRasshMZWvJRFfM78wCHzqfI4wefCXMARzQHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTS0OQBYB4tLjiJoulR+JRdFmeIa3k9n0FDfY0 z2M6i8kiN07ltUX3q+2+VTGhTOEpZXTSAMxoALNUQqN8QdRdIOjIYuy5jDz7vFGNo+VCEaAu HssnNKX5+QDS5qKkUSlSf0ABriz696ZMTfXhhhkGJxJyti20yf9J8YKumg4fRo3dJ9eIlcFf XM/pytz3MNrfyqjU5ZGarCKEMcXkIS5Duj6A6W8gsV1XrB9cwqO/SdLbEGW3nzwnEVErZzTK at3Yu73Uy9EVP0PIC6eAr5EjOR1nnxWKXb7H8iT8vix7VaJiJd5o58hOUDGUO025bjsTO79o 4cGbJviJ/myvYTDjsjrHWw7dw9iwZsTX8qeRylrmgmrc2Jb9JkJUaO5/F/YU9UNc15pvunJ5 GqhfURT1UDyg3bKQS3TNC88NOixAcgv/CxlVcDJAbpP8yJ+CbtDEY9FL8dnFVXZ3LALIQFIo wktJJzbX6UnpsXv8DUBd5jtxLGOhzzy7T9iyxGNOWBlF7Y5HlyhxzMRVle3nMX4Jnbt5JRWT nzJ/l+zfKfvsCw+VZ+LOK/ylg7g1ZXf8corN3b1zhBoUB2E2OBXx+bZ15fb/+lkxc3/+wan IronPort-HdrOrdr: A9a23:J9zEy620cTGKcgMaWLP0oQqjBVJyeYIsimQD101hICG9Lfbzqy n+pp8mPEHP4Ar5AEtQ/+xpOMG7IU80hqQFmLX5XI3SKzUO3VHEEGgM1/qH/9SNIUPDH41mpN FdmspFebrN5DFB5KqU3ODSKadC/DDzytHMuQ6o9QYOcegFUcBdxjY8LjzePlx9RQFAC5Z8Po Gb/NB7qz2pfmlSRtinB1EeNtKz7+HjpdbDW1orFhQn4A6BgXeD87jhCSWV2R8YTndm3aoiy2 7YiAb0j5/T+M1TiyWsnVM73a4m1OcJ+eEzS/Bkv/JlZwkExDzYKriJEIfyxAzd6Nvfk2rC1u O86ivIdv4DkU/5byW7pwDg1BLn1ytr43j+yUWAiX+musDhQikmYvAx976xXyGpm3bIhusMo5 5jziacrd5aHBnAlCPy65zBUAxrjFO9pT4nnfQIh3JSXIMCYPsJxLZviH99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlONQ1QEuMaSzz9K9UoJuncw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosMYad0FI46MLqK46z2MGzx2U6pUCva/fs8Sg/wQrbMkckI2N0= X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="97515573" Date: Mon, 27 Feb 2023 14:26:31 +0000 From: Anthony PERARD To: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= CC: Demi Marie Obenour , , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , "Ross Lagerwall" Subject: Re: [PATCH v5 1/5] Use HTTPS for all xenbits.xen.org Git repos Message-ID: References: <9cb98cb9aaca22bbc88de9fd8cbd7f9463b4d425.1677356813.git.demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Feb 25, 2023 at 11:34:32PM +0100, Marek Marczykowski-Grecki wrote: > On Sat, Feb 25, 2023 at 03:37:11PM -0500, Demi Marie Obenour wrote: > > Obtaining code over an insecure transport is a terrible idea for > > blatently obvious reasons. Even for non-executable data, insecure > > transports are considered deprecated. > > > > This patch enforces the use of secure transports for all xenbits.xen.org > > Git repositories. It was generated with the following shell script: > > > > git ls-files -z | > > xargs -0 -- sed -Ei -- 's@(git://xenbits\.xen\.org|http://xenbits\.xen\.org/git-http)/@https://xenbits.xen.org/git-http/@g' > > > > All altered links have been tested and are known to work. > > > > Signed-off-by: Demi Marie Obenour > > It seems expired Lets Encrypt root issue applies to few other containers > too: Yes, I haven't finished rebuilding all containers needed to be rebuilt. I've mostly took care of fixing dockerfiles for those needed to change. Cheers, > - archlinux:current: https://gitlab.com/xen-project/patchew/xen/-/jobs/3834739751 > - debian:stretch-i386: https://gitlab.com/xen-project/patchew/xen/-/jobs/3834739762 > - debian:unstable-i386: https://gitlab.com/xen-project/patchew/xen/-/jobs/3834739771 -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:30:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:30:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502627.774502 (Exim 4.92) (envelope-from ) id 1pWeWN-00011J-L0; Mon, 27 Feb 2023 14:30:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502627.774502; Mon, 27 Feb 2023 14:30:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeWN-00011C-ID; Mon, 27 Feb 2023 14:30:31 +0000 Received: by outflank-mailman (input) for mailman id 502627; Mon, 27 Feb 2023 14:30:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeWM-000116-28 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:30:30 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4850fe4b-b6ab-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:30:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9636.eurprd04.prod.outlook.com (2603:10a6:10:320::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Mon, 27 Feb 2023 14:29:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:29:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4850fe4b-b6ab-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=my9L38EIr5XyOfzwAweXEdhCwUty8EwZLHVCflCT/Mmiz5VE3xtMCCCkVJY7avmPpHMpY5bphVeABlG1EHvn52ibTQcqzxeI42dXxVXI5nFQkfM/BQYdNNNLgEqIz8IWkTPEpFcM3mi1FGTkLDEC8YA21BQ2X+XoR73700yRVMlpPLlPh8n5zc9PSMusA/t7oapmz+Mmkn/v8UH3+sg+NjB0T5eAvCFxxwQXzsTzL5pqhXH5/rEsfhb/Hl95wC3QJk+S0aJ5QffFmT/olwmPZ3G5nSPtEaWIYzm67yvSk27bZ/w/rzwyK8pQc9TnRu7TndppBg8Ezw70ZvkmQqIZoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8Zed6N2stI86YmYnkXPep1D1Ny6NPk7wNNmHzXRReg=; b=B97/0j3Li3+gclWQBCe0A9GGSZ3FBQ8osgdb7OdsNurYutrhGsnGyixE/Kv7BZ0PB3AD+0XBnhSreAVDZzEFi3T4REL3Jb2L6TDd+tvw2gI0EYhP4D3izjB+z1XkcANEt2s71DvdlnzGDetvyu6VDMj1vuYrxgdCPwh7fuISHdkUovBo61RpXsLciFHk/2VpGIdHB9XeJQMh6H5hu+7TuJpHW3yBGlHOcuogncNz6nwkbD3EgfNjjDImMFH9RvVqzn/h5cNKa0O9yP7eLS+vr3xbFE03nSUAqL8KKujNY7QEuoBtrQpl61SzClatLjBkTcqy1LZXPOFXVf7XPfPzRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8Zed6N2stI86YmYnkXPep1D1Ny6NPk7wNNmHzXRReg=; b=O4iUQSNL8+JJV7yNuCG3gnS3ZMq652mfQ87a8amyS4NGaxfJcO9uqQMJaQ5CKHKChaP7IC9enZk7OtL1q3k6DhPqdkC4ZEtaZqAYxjIL1/KR6IeL95YmWOUKpFJbVoJygvsm0gcT/wzpCFvuMdFXVl5ylJcO9Z4PU5jXWwJa5C5iwRC5iRATGURE0JvWScjCvg02UA/tINj2aV4reYqe5NbMILIkaERCpFCUKxQScyjmlA/tnFGk/5tWyz4+TaMppCwh9CTnM5E7hcpT4TpV7MExplRNZBwsKi0cjbeW4MLYtZ1ac4MD2U1NEAKkUp3+n3CQtCFm6Wkvvjj+GcRB8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6b6fa456-4653-4fc0-d777-985ee217954f@suse.com> Date: Mon, 27 Feb 2023 15:29:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/4] xen: change to Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9636:EE_ X-MS-Office365-Filtering-Correlation-Id: a35ee977-8f91-425f-c1c8-08db18cf18e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lhr1ahwuvc/wOuHK9rQmxbob/1XRakzK1dm8cz6v43uRbOhuI1hDp2f4ARkdG7gbADmQ7D3ySNiHXXpiYNXeNyoOz3AAL3dxE8DyKDh61mDORGkfMZpnHc0+UOO2PrclbJw27Mrq2pgKkbcb7PeulWWsUWCyTSv9SUqpBqve5Tgd7HGeiOJtQ7QZwa9B9Ub4gerFHMgBOxDuRFLPRzNk+t/I0VqGokDJT3B0XdwjpUu2PCNihKeHPbkNeRV07g8sSxAGyibSwH5fxwbcb2nqXVNr5+xRGXOZ5qCiBRBogON86WVrC4ocwYVwz8XOtEKRliTUwca2K+SGWMsu7wd1Lyw4VCFLTmPVsKe4tZRN6B0gXb4vqSXn/+T02bv2s1p77SNK/xF+sOJsnj4kKsuATWVdMBQTI74X6qXK7P4R0/RrfFfYzJyl/2f3GAnJ/8htjMRnOIBQDxPgcIamPNyx6zVTe4vyrVzqFwAgFuV53TsDap/apkIpd9chvIZCtaCI99j5n9umOq/4YBPNjr/wfqdr2Tr7mec7vt1dem3CdWWhY/gP780iBhqR6VQ2zxAfwPJY4x0OFLqpdmswqQrAi+3BBYDEx/5FouvPjG6XFDL4+xF8N0huGVzHGz9CTOSH5MRYAq8kXAyIs+ERSk91nhPGViKYp1z0Bkgq1pplDVD5u5Cqh012tvEg3qkgWIIH5qFllgD0DWC9Fr8GrLQIUI1XnO/DYhJVC5INy24MB14= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199018)(7416002)(38100700002)(86362001)(36756003)(2906002)(5660300002)(8936002)(66946007)(31696002)(8676002)(6512007)(53546011)(186003)(6506007)(26005)(4326008)(2616005)(316002)(6916009)(54906003)(6486002)(478600001)(66476007)(66556008)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHlTNkpIalp0TGRuZEVhd21oL2ZmWVhrVkJRazdxWDBtc2xYamFoYi9SQVhX?= =?utf-8?B?a3IvdFgrV084Q2NZQmtKaE14YnI3T1MvZ01nOGl5WWZzeCtYS0E4QjFvR29h?= =?utf-8?B?L2NKd0s1VjFiOFBVdzdVdE9VTVVoMS9meGQzbFByRDZYbWtKMks4eExWdDJM?= =?utf-8?B?MWJKaGlPYkExdUxOUnRQZnBaZ2k4OWVXUnhQV0M3c3pFWndSZHZiSGtBazFn?= =?utf-8?B?MHVncWNrOUNsRzRCTzFpZzc1aGszRUMzd1dvRzBGOWF4R1BleC8xcGs4WGlI?= =?utf-8?B?bXo4ZGs0NWJZcnhLK1ljTjdCb3hYSXdMK0pIN0tmUUtRMU9LeTJYY3R1ZWph?= =?utf-8?B?d3NYNW1lSnJTc2l3alIvZXZkRDZwYjhObWN5eUNsallpS0pjVnl3VnFYYVor?= =?utf-8?B?Ti9lOUVHTHNSSTBndUdROVZndjE1MEFWL2c0ZjVSM1pjLytyMGxkbHNWRDNr?= =?utf-8?B?ckU3amdSb2lKMkVtM1BHVlpZL0F2WFdmNC9IRzZhMHJFQlVZVnhkRDI1MkpH?= =?utf-8?B?MnNjQ09sK20wcU5iRmFqbDlFWUlaMWNNSER5cGNCZ3FGMmVmVCt4N1gvYmsy?= =?utf-8?B?RVNKMUlqNkxJS21uQ09na0FRM1JOQmtHa085VVVjUlYvUDhvQmR3Zi8wMm9H?= =?utf-8?B?Y05EUXRYM04xMVlndUJ4THFJUU9mSVRyZkh6K1Iya3pkWVhzTjdBZ1V2RlBF?= =?utf-8?B?TnYzV3ZWbFE2TmFBVHBndHVMTEp6eDFETmdxQjQvR1dZQVp3dnl3LzFVZ0NU?= =?utf-8?B?R3FxcVhVWnVGNGQ2YU1USE1KVjNpbktQV2hRWGkzL1VLQUovbEpyV0ZYWU1l?= =?utf-8?B?andJWFVLRXdha21vWUZGMXFyZHJSZWtqcjkzT2c1d3V4bUh2Y1ptS3M1ZXJr?= =?utf-8?B?ZWFWd0NnNWZaQXBOLysrSXZoWm5FN1I4TmlsWjhmblJMeXVvNE5ZZjBxekZR?= =?utf-8?B?TWZ2dWhMeHgybGxvWTZtRjJtZkRmTTdTaHVwYWdicUx6YlBCWDBRTTQ0UVkv?= =?utf-8?B?emxoL0cxVk95SWYrOHBmcEFJZFFUSnZKdkpCZFFRWWlZcWdKTmJOZHBhR3NJ?= =?utf-8?B?bTdOeTgvWkgvMmhkUXlFWm5zM24rNHFIaG9BTGVSVTR2a0FzRjBzVVJMRVlo?= =?utf-8?B?WElKTEowcUVFNnJndVlpUG1HU1psY1pTWTlDY21mZFQwR2RXaTBmbUZJc3kx?= =?utf-8?B?VWVPWXMzWitVY3FMUzI3WUZIbkZMTTVLbnN3U3VnOE9rd1E1azZsNndRaktF?= =?utf-8?B?b3JvVTVTZ0p2b2ZUSzgxQ1ViZnVuU1Y5NlViOXA0K2NzTW9DMENHRmRjZnJC?= =?utf-8?B?dy9tNTFvcm0reFBuOWFpU20yWUFBcnNlMVR4RzdvdTJVcTRLZTR6L01CQ3A3?= =?utf-8?B?MFNnNjNZeEJKcFRMT2J1N01LZ2hWQkRiUDRHV1ZwZG5JcTlHYjdGSjNYaTJM?= =?utf-8?B?NEkzRkM5UlNKRklPQlNrUUdabGNIaFVXejVheGlUMVZsZ1pzK051MnR1V1VT?= =?utf-8?B?azdrcjlncmtHV2pYeW1CRXYyTENwMElxYVhVNE5tUDVUSXU5YkFXZmxmWWpZ?= =?utf-8?B?MG9UTW1ycTUyQkRTeVVwNE9uRGFUQ0kyYVVteFJIZzdpeFdrNGo3N0gyZU9k?= =?utf-8?B?L2YwNGxZMEw3Ri82MU95TTRLNm50RG0rUzhLcVNRSXp2Y2R5ODkzcXhuWk1i?= =?utf-8?B?Z0xCblhnaHZTcCtsVjY0ak0wQzJoQ052WWRJbmowMGI4aWVsdWY0VlROaHMx?= =?utf-8?B?WFNJWFZ4SW15eVhyMlNlWW1CeGNOV0p5cUtMRGZsV3MwanE0NEluNmRGTXJz?= =?utf-8?B?U1N2NCtmcXFodDY5L3RkblVHU2YrUkNPT1lJcTYxZHRudDYwWFV2N2x1Nk1S?= =?utf-8?B?NldCY2dLMmdpQnRheFltaEJ6eldQSnJCTEFkVm9aRitETDVhdlJuWExoc3pk?= =?utf-8?B?QUxFRWMvcjdhbWg0dzNnRFJRczgyT3puWkQ2Z0lXUzhVT01SUnJFMm9raU4y?= =?utf-8?B?WEx3U3FMbnBCQUdyakNMVXVsU3U5UDlRRjlNSHUyQytXZ2J1alZBeUh2RkRB?= =?utf-8?B?Sy9WY3dXdHNtRXVLWGVUdVVtS0h5azIxc0xzSUhDUWZsR2NtVXJTYTRUNGU1?= =?utf-8?Q?uoI5HKnuHXnn81fpwYWj9eBC+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a35ee977-8f91-425f-c1c8-08db18cf18e1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:29:55.9989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ofola8TpTsJ4J46lU4hWeq7j2ns4iYrl31hUhw+r7tWt/AiInSBmyvKrm9v+OlFRrWsNab5mg5pN9GnkBFt+zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9636 On 24.02.2023 12:31, Oleksii Kurochko wrote: > Since the generic version of bug.h stuff was introduced use > instead of unnecessary You keep saying "unnecessary" here, but that's not really correct. Including asm/bug.h alone simply becomes meaningless. So how about "... instead of now useless (in isolation) "? > --- a/xen/arch/x86/include/asm/bug.h > +++ b/xen/arch/x86/include/asm/bug.h > @@ -1,19 +1,10 @@ > #ifndef __X86_BUG_H__ > #define __X86_BUG_H__ > > -#define BUG_DISP_WIDTH 24 > -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > - > -#define BUGFRAME_run_fn 0 > -#define BUGFRAME_warn 1 > -#define BUGFRAME_bug 2 > -#define BUGFRAME_assert 3 > - > -#define BUGFRAME_NR 4 > - > #ifndef __ASSEMBLY__ > > +#define BUG_FRAME_STRUCT > + > struct bug_frame { > signed int loc_disp:BUG_DISP_WIDTH; > unsigned int line_hi:BUG_LINE_HI_WIDTH; Why would x86 continue to define its own bug_frame (and other items)? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:42:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:42:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502636.774511 (Exim 4.92) (envelope-from ) id 1pWeiF-0002rq-Oh; Mon, 27 Feb 2023 14:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502636.774511; Mon, 27 Feb 2023 14:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeiF-0002rj-Lb; Mon, 27 Feb 2023 14:42:47 +0000 Received: by outflank-mailman (input) for mailman id 502636; Mon, 27 Feb 2023 14:42:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeiE-0002rc-S2 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:42:46 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff0f6469-b6ac-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:42:45 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9ADAD1FD63; Mon, 27 Feb 2023 14:42:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 680D613A43; Mon, 27 Feb 2023 14:42:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RvraF2TB/GNvEQAAMHmgww (envelope-from ); Mon, 27 Feb 2023 14:42:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff0f6469-b6ac-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677508964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7jnC/y8sUyMQRpD8F/O8MAJVgEiQA55aTtgYW9nlfAM=; b=NGnfT4exCDcCNK3CUFMTufWyEKTA7HD8ZKWToW826fPGM6H65VJqEzeMfrNl6qwuCOucBE BoCMotRscP/kYmOI/VFpfNryXB0qaGvMy6t73bok34rlDoCaWDH10IrKY1AsUzJPcq7Stp FcCqWja93t2KBysI3qQALcLWWbCIfaA= Message-ID: Date: Mon, 27 Feb 2023 15:42:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak Content-Language: en-US To: Andrew Cooper , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Wei Liu , Anthony PERARD References: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> From: Juergen Gross In-Reply-To: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------lG5LLdFxeTuZNkobmkr0L9We" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------lG5LLdFxeTuZNkobmkr0L9We Content-Type: multipart/mixed; boundary="------------s2aY4R0exeysJz46M2zlBE26"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak References: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> In-Reply-To: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> --------------s2aY4R0exeysJz46M2zlBE26 Content-Type: multipart/mixed; boundary="------------0Vo2frdym0Dl1sh7hxjWb4LU" --------------0Vo2frdym0Dl1sh7hxjWb4LU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjQuMDIuMjMgMTU6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDI0LzAyLzIw MjMgMTozNiBwbSwgRWR3aW4gVMO2csO2ayB3cm90ZToNCj4+IEZyb206IEVkd2luIFTDtnLD tmsgPGVkd2luLnRvcm9rQGNsb3VkLmNvbT4NCj4+DQo+PiBQcmlvciB0byBiZDdhMjljM2Qw ICdvdXQnIHdvdWxkJ3ZlIGFsd2F5cyBiZWVuIGV4ZWN1dGVkIGFuZCBtZW1vcnkNCj4+IGZy ZWVkLCBidXQgdGhhdCBjb21taXQgY2hhbmdlZCBpdCBzdWNoIHRoYXQgaXQgcmV0dXJucyBl YXJseSBhbmQgbGVha3MuDQo+Pg0KPj4gRm91bmQgdXNpbmcgZ2NjIDEyLjIuMSBgLWZhbmFs eXplcmA6DQo+PiBgYGANCj4+IHhnX2NvcmVfeDg2LmM6IEluIGZ1bmN0aW9uIOKAmHhjX2Nv cmVfYXJjaF9tYXBfcDJtX3RyZWVfcnfigJk6DQo+PiB4Z19jb3JlX3g4Ni5jOjMwMDo1OiBl cnJvcjogbGVhayBvZiDigJhwMm1fZnJhbWVfbGlzdF9saXN04oCZIFtDV0UtNDAxXSBbLVdl cnJvcj1hbmFseXplci1tYWxsb2MtbGVha10NCj4+ICAgIDMwMCB8ICAgICByZXR1cm4gcDJt X2ZyYW1lX2xpc3Q7DQo+PiAgICAgICAgfCAgICAgXn5+fn5+DQo+PiAgICDigJh4Y19jb3Jl X2FyY2hfbWFwX3AybV93cml0YWJsZeKAmTogZXZlbnRzIDEtMg0KPj4gICAgICB8DQo+PiAg ICAgIHwgIDM3OCB8IHhjX2NvcmVfYXJjaF9tYXBfcDJtX3dyaXRhYmxlKHhjX2ludGVyZmFj ZSAqeGNoLCBzdHJ1Y3QgZG9tYWluX2luZm9fY29udGV4dCAqZGluZm8sIHhjX2RvbWluZm9f dCAqaW5mbywNCj4+ICAgICAgfCAgICAgIHwgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn4NCj4+ICAgICAgfCAgICAgIHwgfA0KPj4gICAgICB8ICAgICAgfCAoMSkgZW50cnkgdG8g 4oCYeGNfY29yZV9hcmNoX21hcF9wMm1fd3JpdGFibGXigJkNCj4+ICAgICAgfC4uLi4uLg0K Pj4gICAgICB8ICAzODEgfCAgICAgcmV0dXJuIHhjX2NvcmVfYXJjaF9tYXBfcDJtX3J3KHhj aCwgZGluZm8sIGluZm8sIGxpdmVfc2hpbmZvLCBsaXZlX3AybSwgMSk7DQo+PiAgICAgIHwg ICAgICB8ICAgICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fg0KPj4gICAgICB8ICAgICAgfCAgICAg ICAgICAgIHwNCj4+ICAgICAgfCAgICAgIHwgICAgICAgICAgICAoMikgY2FsbGluZyDigJh4 Y19jb3JlX2FyY2hfbWFwX3AybV9yd+KAmSBmcm9tIOKAmHhjX2NvcmVfYXJjaF9tYXBfcDJt X3dyaXRhYmxl4oCZDQo+PiAgICAgIHwNCj4+ICAgICAgKy0tPiDigJh4Y19jb3JlX2FyY2hf bWFwX3AybV9yd+KAmTogZXZlbnRzIDMtMTANCj4+ICAgICAgICAgICAgIHwNCj4+ICAgICAg ICAgICAgIHwgIDMxOSB8IHhjX2NvcmVfYXJjaF9tYXBfcDJtX3J3KHhjX2ludGVyZmFjZSAq eGNoLCBzdHJ1Y3QgZG9tYWluX2luZm9fY29udGV4dCAqZGluZm8sIHhjX2RvbWluZm9fdCAq aW5mbywNCj4+ICAgICAgICAgICAgIHwgICAgICB8IF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ DQo+PiAgICAgICAgICAgICB8ICAgICAgfCB8DQo+PiAgICAgICAgICAgICB8ICAgICAgfCAo MykgZW50cnkgdG8g4oCYeGNfY29yZV9hcmNoX21hcF9wMm1fcnfigJkNCj4+ICAgICAgICAg ICAgIHwuLi4uLi4NCj4+ICAgICAgICAgICAgIHwgIDMyOCB8ICAgICBpZiAoIHhjX2RvbWFp bl9ucl9ncGZucyh4Y2gsIGluZm8tPmRvbWlkLCAmZGluZm8tPnAybV9zaXplKSA8IDAgKQ0K Pj4gICAgICAgICAgICAgfCAgICAgIHwgICAgICAgIH4NCj4+ICAgICAgICAgICAgIHwgICAg ICB8ICAgICAgICB8DQo+PiAgICAgICAgICAgICB8ICAgICAgfCAgICAgICAgKDQpIGZvbGxv d2luZyDigJhmYWxzZeKAmSBicmFuY2guLi4NCj4+ICAgICAgICAgICAgIHwuLi4uLi4NCj4+ ICAgICAgICAgICAgIHwgIDMzNCB8ICAgICBpZiAoIGRpbmZvLT5wMm1fc2l6ZSA8IGluZm8t Pm5yX3BhZ2VzICApDQo+PiAgICAgICAgICAgICB8ICAgICAgfCAgICAgfn4gfg0KPj4gICAg ICAgICAgICAgfCAgICAgIHwgICAgIHwgIHwNCj4+ICAgICAgICAgICAgIHwgICAgICB8ICAg ICB8ICAoNikgZm9sbG93aW5nIOKAmGZhbHNl4oCZIGJyYW5jaC4uLg0KPj4gICAgICAgICAg ICAgfCAgICAgIHwgICAgICg1KSAuLi50byBoZXJlDQo+PiAgICAgICAgICAgICB8Li4uLi4u DQo+PiAgICAgICAgICAgICB8ICAzNDAgfCAgICAgcDJtX2NyMyA9IEdFVF9GSUVMRChsaXZl X3NoaW5mbywgYXJjaC5wMm1fY3IzLCBkaW5mby0+Z3Vlc3Rfd2lkdGgpOw0KPj4gICAgICAg ICAgICAgfCAgICAgIHwgICAgIH5+fn5+fn4NCj4+ICAgICAgICAgICAgIHwgICAgICB8ICAg ICB8DQo+PiAgICAgICAgICAgICB8ICAgICAgfCAgICAgKDcpIC4uLnRvIGhlcmUNCj4+ICAg ICAgICAgICAgIHwgIDM0MSB8DQo+PiAgICAgICAgICAgICB8ICAzNDIgfCAgICAgcDJtX2Zy YW1lX2xpc3QgPSBwMm1fY3IzID8geGNfY29yZV9hcmNoX21hcF9wMm1fbGlzdF9ydyh4Y2gs IGRpbmZvLCBkb20sIGxpdmVfc2hpbmZvLCBwMm1fY3IzKQ0KPj4gICAgICAgICAgICAgfCAg ICAgIHwgICAgICAgICAgICAgICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4NCj4+ ICAgICAgICAgICAgIHwgIDM0MyB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiB4 Y19jb3JlX2FyY2hfbWFwX3AybV90cmVlX3J3KHhjaCwgZGluZm8sIGRvbSwgbGl2ZV9zaGlu Zm8pOw0KPj4gICAgICAgICAgICAgfCAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn4NCj4+ICAgICAgICAgICAgIHwgICAgICB8ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCB8DQo+PiAgICAgICAgICAgICB8ICAgICAgfCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgKDkpIC4uLnRvIGhlcmUNCj4+ICAgICAgICAgICAgIHwgICAg ICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAoMTApIGNhbGxpbmcg4oCYeGNf Y29yZV9hcmNoX21hcF9wMm1fdHJlZV9yd+KAmSBmcm9tIOKAmHhjX2NvcmVfYXJjaF9tYXBf cDJtX3J34oCZDQo+PiAgICAgICAgICAgICB8ICAgICAgfCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICg4KSBmb2xsb3dpbmcg4oCYZmFsc2XigJkgYnJhbmNoLi4uDQo+PiAgICAg ICAgICAgICB8DQo+PiAgICAgICAgICAgICArLS0+IOKAmHhjX2NvcmVfYXJjaF9tYXBfcDJt X3RyZWVfcnfigJk6IGV2ZW50cyAxMS0yNA0KPj4gICAgICAgICAgICAgICAgICAgIHwNCj4+ ICAgICAgICAgICAgICAgICAgICB8ICAyMjggfCB4Y19jb3JlX2FyY2hfbWFwX3AybV90cmVl X3J3KHhjX2ludGVyZmFjZSAqeGNoLCBzdHJ1Y3QgZG9tYWluX2luZm9fY29udGV4dCAqZGlu Zm8sDQo+PiAgICAgICAgICAgICAgICAgICAgfCAgICAgIHwgXn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fg0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAgICB8IHwNCj4+ICAgICAg ICAgICAgICAgICAgICB8ICAgICAgfCAoMTEpIGVudHJ5IHRvIOKAmHhjX2NvcmVfYXJjaF9t YXBfcDJtX3RyZWVfcnfigJkNCj4+ICAgICAgICAgICAgICAgICAgICB8Li4uLi4uDQo+PiAg ICAgICAgICAgICAgICAgICAgfCAgMjQ1IHwgICAgIGlmICggIWxpdmVfcDJtX2ZyYW1lX2xp c3RfbGlzdCApDQo+PiAgICAgICAgICAgICAgICAgICAgfCAgICAgIHwgICAgICAgIH4NCj4+ ICAgICAgICAgICAgICAgICAgICB8ICAgICAgfCAgICAgICAgfA0KPj4gICAgICAgICAgICAg ICAgICAgIHwgICAgICB8ICAgICAgICAoMTIpIGZvbGxvd2luZyDigJhmYWxzZeKAmSBicmFu Y2ggKHdoZW4g4oCYbGl2ZV9wMm1fZnJhbWVfbGlzdF9saXN04oCZIGlzIG5vbi1OVUxMKS4u Lg0KPj4gICAgICAgICAgICAgICAgICAgIHwuLi4uLi4NCj4+ICAgICAgICAgICAgICAgICAg ICB8ICAyNTIgfCAgICAgaWYgKCAhKHAybV9mcmFtZV9saXN0X2xpc3QgPSBtYWxsb2MoUEFH RV9TSVpFKSkgKQ0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAgICB8ICAgICB+fiB+ICAg ICAgICAgICAgICAgICAgICAgICAgIH5+fn5+fn5+fn5+fn5+fn5+DQo+PiAgICAgICAgICAg ICAgICAgICAgfCAgICAgIHwgICAgIHwgIHwgICAgICAgICAgICAgICAgICAgICAgICAgfA0K Pj4gICAgICAgICAgICAgICAgICAgIHwgICAgICB8ICAgICB8ICB8ICAgICAgICAgICAgICAg ICAgICAgICAgICgxNCkgYWxsb2NhdGVkIGhlcmUNCj4+ICAgICAgICAgICAgICAgICAgICB8 ICAgICAgfCAgICAgfCAgKDE1KSBhc3N1bWluZyDigJhwMm1fZnJhbWVfbGlzdF9saXN04oCZ IGlzIG5vbi1OVUxMDQo+PiAgICAgICAgICAgICAgICAgICAgfCAgICAgIHwgICAgIHwgICgx NikgZm9sbG93aW5nIOKAmGZhbHNl4oCZIGJyYW5jaCAod2hlbiDigJhwMm1fZnJhbWVfbGlz dF9saXN04oCZIGlzIG5vbi1OVUxMKS4uLg0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAg ICB8ICAgICAoMTMpIC4uLnRvIGhlcmUNCj4+ICAgICAgICAgICAgICAgICAgICB8Li4uLi4u DQo+PiAgICAgICAgICAgICAgICAgICAgfCAgMjU3IHwgICAgIG1lbWNweShwMm1fZnJhbWVf bGlzdF9saXN0LCBsaXZlX3AybV9mcmFtZV9saXN0X2xpc3QsIFBBR0VfU0laRSk7DQo+PiAg ICAgICAgICAgICAgICAgICAgfCAgICAgIHwgICAgIH5+fn5+fg0KPj4gICAgICAgICAgICAg ICAgICAgIHwgICAgICB8ICAgICB8DQo+PiAgICAgICAgICAgICAgICAgICAgfCAgICAgIHwg ICAgICgxNykgLi4udG8gaGVyZQ0KPj4gICAgICAgICAgICAgICAgICAgIHwuLi4uLi4NCj4+ ICAgICAgICAgICAgICAgICAgICB8ICAyNjYgfCAgICAgZWxzZSBpZiAoIGRpbmZvLT5ndWVz dF93aWR0aCA8IHNpemVvZih1bnNpZ25lZCBsb25nKSApDQo+PiAgICAgICAgICAgICAgICAg ICAgfCAgICAgIHwgICAgICAgICAgICAgfg0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAg ICB8ICAgICAgICAgICAgIHwNCj4+ICAgICAgICAgICAgICAgICAgICB8ICAgICAgfCAgICAg ICAgICAgICAoMTgpIGZvbGxvd2luZyDigJhmYWxzZeKAmSBicmFuY2guLi4NCj4+ICAgICAg ICAgICAgICAgICAgICB8Li4uLi4uDQo+PiAgICAgICAgICAgICAgICAgICAgfCAgMjcwIHwg ICAgIGxpdmVfcDJtX2ZyYW1lX2xpc3QgPQ0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAg ICB8ICAgICB+fn5+fn5+fn5+fn5+fn5+fn5+DQo+PiAgICAgICAgICAgICAgICAgICAgfCAg ICAgIHwgICAgIHwNCj4+ICAgICAgICAgICAgICAgICAgICB8ICAgICAgfCAgICAgKDE5KSAu Li50byBoZXJlDQo+PiAgICAgICAgICAgICAgICAgICAgfC4uLi4uLg0KPj4gICAgICAgICAg ICAgICAgICAgIHwgIDI3NSB8ICAgICBpZiAoICFsaXZlX3AybV9mcmFtZV9saXN0ICkNCj4+ ICAgICAgICAgICAgICAgICAgICB8ICAgICAgfCAgICAgICAgfg0KPj4gICAgICAgICAgICAg ICAgICAgIHwgICAgICB8ICAgICAgICB8DQo+PiAgICAgICAgICAgICAgICAgICAgfCAgICAg IHwgICAgICAgICgyMCkgZm9sbG93aW5nIOKAmGZhbHNl4oCZIGJyYW5jaCAod2hlbiDigJhs aXZlX3AybV9mcmFtZV9saXN04oCZIGlzIG5vbi1OVUxMKS4uLg0KPj4gICAgICAgICAgICAg ICAgICAgIHwuLi4uLi4NCj4+ICAgICAgICAgICAgICAgICAgICB8ICAyODIgfCAgICAgaWYg KCAhKHAybV9mcmFtZV9saXN0ID0gbWFsbG9jKFAyTV9UT09MU19GTF9TSVpFKSkgKQ0KPj4g ICAgICAgICAgICAgICAgICAgIHwgICAgICB8ICAgICB+fiB+DQo+PiAgICAgICAgICAgICAg ICAgICAgfCAgICAgIHwgICAgIHwgIHwNCj4+ICAgICAgICAgICAgICAgICAgICB8ICAgICAg fCAgICAgfCAgKDIyKSBmb2xsb3dpbmcg4oCYZmFsc2XigJkgYnJhbmNoICh3aGVuIOKAmHAy bV9mcmFtZV9saXN04oCZIGlzIG5vbi1OVUxMKS4uLg0KPj4gICAgICAgICAgICAgICAgICAg IHwgICAgICB8ICAgICAoMjEpIC4uLnRvIGhlcmUNCj4+ICAgICAgICAgICAgICAgICAgICB8 Li4uLi4uDQo+PiAgICAgICAgICAgICAgICAgICAgfCAgMjg3IHwgICAgIG1lbXNldChwMm1f ZnJhbWVfbGlzdCwgMCwgUDJNX1RPT0xTX0ZMX1NJWkUpOw0KPj4gICAgICAgICAgICAgICAg ICAgIHwgICAgICB8ICAgICB+fn5+fn4NCj4+ICAgICAgICAgICAgICAgICAgICB8ICAgICAg fCAgICAgfA0KPj4gICAgICAgICAgICAgICAgICAgIHwgICAgICB8ICAgICAoMjMpIC4uLnRv IGhlcmUNCj4+ICAgICAgICAgICAgICAgICAgICB8Li4uLi4uDQo+PiAgICAgICAgICAgICAg ICAgICAgfCAgMzAwIHwgICAgIHJldHVybiBwMm1fZnJhbWVfbGlzdDsNCj4+ICAgICAgICAg ICAgICAgICAgICB8ICAgICAgfCAgICAgfn5+fn5+DQo+PiAgICAgICAgICAgICAgICAgICAg fCAgICAgIHwgICAgIHwNCj4+ICAgICAgICAgICAgICAgICAgICB8ICAgICAgfCAgICAgKDI0 KSDigJhwMm1fZnJhbWVfbGlzdF9saXN04oCZIGxlYWtzIGhlcmU7IHdhcyBhbGxvY2F0ZWQg YXQgKDE0KQ0KPj4gICAgICAgICAgICAgICAgICAgIHwNCj4+IGBgYA0KPj4gRml4ZXM6IGJk N2EyOWMzZDAgKCJ0b29scy9saWJzL2N0cmw6IGZpeCB4Y19jb3JlX2FyY2hfbWFwX3AybSgp IHRvIHN1cHBvcnQgbGluZWFyIHAybSB0YWJsZSIpDQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTog RWR3aW4gVMO2csO2ayA8ZWR3aW4udG9yb2tAY2xvdWQuY29tPg0KPj4gLS0tDQo+PiAgIHRv b2xzL2xpYnMvZ3Vlc3QveGdfY29yZV94ODYuYyB8IDIgKysNCj4+ICAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2d1 ZXN0L3hnX2NvcmVfeDg2LmMgYi90b29scy9saWJzL2d1ZXN0L3hnX2NvcmVfeDg2LmMNCj4+ IGluZGV4IDYxMTA2Yjk4YjguLjY5OTI5ODc5ZDcgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9s aWJzL2d1ZXN0L3hnX2NvcmVfeDg2LmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvZ3Vlc3QveGdf Y29yZV94ODYuYw0KPj4gQEAgLTI5Nyw2ICsyOTcsOCBAQCB4Y19jb3JlX2FyY2hfbWFwX3Ay bV90cmVlX3J3KHhjX2ludGVyZmFjZSAqeGNoLCBzdHJ1Y3QgZG9tYWluX2luZm9fY29udGV4 dCAqZGluZg0KPj4gICANCj4+ICAgICAgIGRpbmZvLT5wMm1fZnJhbWVzID0gUDJNX0ZMX0VO VFJJRVM7DQo+PiAgIA0KPj4gKyAgICBmcmVlKHAybV9mcmFtZV9saXN0X2xpc3QpOw0KPj4g Kw0KPj4gICAgICAgcmV0dXJuIHAybV9mcmFtZV9saXN0Ow0KPj4gICANCj4+ICAgIG91dDoN Cj4gDQo+IEkgYWdyZWUgdGhlcmUgYXJlIHByb2JsZW1zIGhlcmUsIGJ1dCBJIHRoaW5rIHRo ZXkncmUgbGFyZ2VyIHN0aWxsLsKgIFRoZQ0KPiBsaXZlX3AybV9mcmFtZV9saXN0X2xpc3Qg YW5kIGxpdmVfcDJtX2ZyYW1lX2xpc3QgZm9yZWlnbiBtYXBwaW5ncyBhcmUNCj4gbGVha2Vk IHRvbyBvbiB0aGUgc3VjY2VzcyBwYXRoLg0KPiANCj4gSSB0aGluayB0aGlzIGlzIHRoZSBu ZWNlc3NhcnkgZml4Og0KDQpZZXMsIEkgYWdyZWUuDQoNCj4gDQo+IH5BbmRyZXcNCj4gDQo+ IC0tLS04PC0tLS0NCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2d1ZXN0L3hnX2Nv cmVfeDg2LmMgYi90b29scy9saWJzL2d1ZXN0L3hnX2NvcmVfeDg2LmMNCj4gaW5kZXggNjEx MDZiOThiODc3Li5jNWU0NTQyY2NjY2MgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2xpYnMvZ3Vl c3QveGdfY29yZV94ODYuYw0KPiArKysgYi90b29scy9saWJzL2d1ZXN0L3hnX2NvcmVfeDg2 LmMNCj4gQEAgLTIyOSwxMSArMjI5LDExIEBAIHhjX2NvcmVfYXJjaF9tYXBfcDJtX3RyZWVf cncoeGNfaW50ZXJmYWNlICp4Y2gsDQo+IHN0cnVjdCBkb21haW5faW5mb19jb250ZXh0ICpk aW5mDQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHVpbnQzMl90IGRvbSwgc2hhcmVkX2luZm9fYW55X3QgKmxpdmVfc2hp bmZvKQ0KPiAgwqB7DQo+ICDCoMKgwqDCoCAvKiBEb3VibGUgYW5kIHNpbmdsZSBpbmRpcmVj dCByZWZlcmVuY2VzIHRvIHRoZSBsaXZlIFAyTSB0YWJsZSAqLw0KPiAtwqDCoMKgIHhlbl9w Zm5fdCAqbGl2ZV9wMm1fZnJhbWVfbGlzdF9saXN0Ow0KPiArwqDCoMKgIHhlbl9wZm5fdCAq bGl2ZV9wMm1fZnJhbWVfbGlzdF9saXN0ID0gTlVMTDsNCj4gIMKgwqDCoMKgIHhlbl9wZm5f dCAqbGl2ZV9wMm1fZnJhbWVfbGlzdCA9IE5VTEw7DQo+ICDCoMKgwqDCoCAvKiBDb3BpZXMg b2YgdGhlIGFib3ZlLiAqLw0KPiAgwqDCoMKgwqAgeGVuX3Bmbl90ICpwMm1fZnJhbWVfbGlz dF9saXN0ID0gTlVMTDsNCj4gLcKgwqDCoCB4ZW5fcGZuX3QgKnAybV9mcmFtZV9saXN0Ow0K PiArwqDCoMKgIHhlbl9wZm5fdCAqcDJtX2ZyYW1lX2xpc3QgPSBOVUxMOw0KPiAgIA0KPiAg wqDCoMKgwqAgaW50IGVycjsNCj4gIMKgwqDCoMKgIGludCBpOw0KPiBAQCAtMjk3LDggKzI5 Nyw2IEBAIHhjX2NvcmVfYXJjaF9tYXBfcDJtX3RyZWVfcncoeGNfaW50ZXJmYWNlICp4Y2gs DQo+IHN0cnVjdCBkb21haW5faW5mb19jb250ZXh0ICpkaW5mDQo+ICAgDQo+ICDCoMKgwqDC oCBkaW5mby0+cDJtX2ZyYW1lcyA9IFAyTV9GTF9FTlRSSUVTOw0KPiAgIA0KPiAtwqDCoMKg IHJldHVybiBwMm1fZnJhbWVfbGlzdDsNCj4gLQ0KPiAgwqAgb3V0Og0KPiAgwqDCoMKgwqAg ZXJyID0gZXJybm87DQo+ICAgDQo+IEBAIC0zMTIsNyArMzEwLDcgQEAgeGNfY29yZV9hcmNo X21hcF9wMm1fdHJlZV9ydyh4Y19pbnRlcmZhY2UgKnhjaCwNCj4gc3RydWN0IGRvbWFpbl9p bmZvX2NvbnRleHQgKmRpbmYNCj4gICANCj4gIMKgwqDCoMKgIGVycm5vID0gZXJyOw0KPiAg IA0KPiAtwqDCoMKgIHJldHVybiBOVUxMOw0KPiArwqDCoMKgIHJldHVybiBwMm1fZnJhbWVf bGlzdDsNCj4gIMKgfQ0KPiAgIA0KPiAgwqBzdGF0aWMgaW50DQo+IA0KDQpJbiBjYXNlIHRo aXMgZml4IGlzIHRha2VuLCBteQ0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPg0KDQpjYW4gYmUgYWRkZWQuDQoNCg0KSnVlcmdlbg0K --------------0Vo2frdym0Dl1sh7hxjWb4LU Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0Vo2frdym0Dl1sh7hxjWb4LU-- --------------s2aY4R0exeysJz46M2zlBE26-- --------------lG5LLdFxeTuZNkobmkr0L9We Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmP8wWMFAwAAAAAACgkQsN6d1ii/Ey+V WQf/YnVEJvrkI8kJ2YjYWmmYWbsXp0gmNgufCmNU0a3VAZQGEF8/oq09ROrjU/qY2ldXNR0r6CYf BKlgLfc6+B8l2QlgLNb0juUWfnt0l1Hr+nKTVB+DN5lyyAfYiD6TkCd84ppfUxcOzuKBQa1SRn7t mcmCH14qVP+xbB1d3hwzB5nEYFCkcu2qdB32/GqpR1Rf8RXQi1Z4En2x/cP/Kum6FigcVdQPEKHR buE5XvvNHqEloyf5ykmx5GEk3plDd0olLI93oNhvOtjocAdjF21wbDW+ltdzkxwcy/xRLAyGrbmM VyAzkqKn78tFk2SAk5CbRC8O2Jlau7QkcJhvjNuXWA== =ht6a -----END PGP SIGNATURE----- --------------lG5LLdFxeTuZNkobmkr0L9We-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:43:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:43:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502638.774522 (Exim 4.92) (envelope-from ) id 1pWeib-0003H3-7f; Mon, 27 Feb 2023 14:43:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502638.774522; Mon, 27 Feb 2023 14:43:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeib-0003Gw-3Y; Mon, 27 Feb 2023 14:43:09 +0000 Received: by outflank-mailman (input) for mailman id 502638; Mon, 27 Feb 2023 14:43:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeiZ-0003F8-Kx; Mon, 27 Feb 2023 14:43:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeiZ-0002TI-JX; Mon, 27 Feb 2023 14:43:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeiZ-0006gU-9h; Mon, 27 Feb 2023 14:43:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWeiZ-0000mJ-9D; Mon, 27 Feb 2023 14:43:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ezC0/KVWrMCkYpHUtqDJ1Tk2awQ8YT3MD68P92rueI8=; b=czaEmfD5hhCYc0aElHQRDF7/xZ m1qPie0Pjd2DacylEfapDsU1pVNUL/PCOibUv96zV31lHU/eNE3nQ4YHOyOPrFU6hFMjl7L34qh8T ilgWUHQldiEst5c5/mMQ3lz5G5zTaSWS4/cRfqIa4cnNyuB9jNfHBc/szEruHZ09MpSU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178663: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c X-Osstest-Versions-That: xen=608f85a1818697156b72ace4913a17c8178a0ef5 From: osstest service owner Date: Mon, 27 Feb 2023 14:43:07 +0000 flight 178663 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178663/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c baseline version: xen 608f85a1818697156b72ace4913a17c8178a0ef5 Last test of basis 178391 2023-02-24 21:00:27 Z 2 days Testing same since 178663 2023-02-27 13:03:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 608f85a181..4d6df4ec75 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:46:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:46:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502648.774532 (Exim 4.92) (envelope-from ) id 1pWelq-00046e-Md; Mon, 27 Feb 2023 14:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502648.774532; Mon, 27 Feb 2023 14:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWelq-00046X-Jq; Mon, 27 Feb 2023 14:46:30 +0000 Received: by outflank-mailman (input) for mailman id 502648; Mon, 27 Feb 2023 14:46:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWelp-00046R-9B for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:46:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1a::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83eb2c91-b6ad-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:46:28 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6896.eurprd04.prod.outlook.com (2603:10a6:803:12e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:46:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:46:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83eb2c91-b6ad-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YLEWDkXW58jvYvdyDFxA+tgP1Wlm9dgE/wEUsRTDZLvP5M7LrGpq6obV+0ev9rKRA72Q1OFUqDbWbNadpc6ZCrjqaV8H0aDRrrZM+yHW60NqDFCG295qBpxBqAi+HyHuuA4ICF5ChGexa8DpEQVt6kgaCtYMZFr7117L7scykk1LgLrMoILRyQ9wEwV7OTFyxFhoeuhOBGTnjqORUlSp0rlF33ozSAt8sRXIugUbV2pfzmEf5b2+8s41IYGiHu9m5dSjszFcWoKeVy60z+g0S08ltL8TjcWfpbVniIEuESIYOMo81u0FjQtnzRILOr/sCytv7Ok6y1ngHTW29Fn3cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jdkh2oAG5nnCXQvMNmwAI6pYV0dsGBMjdClv8mL+7Ss=; b=WjTE3jrcXpBB3P3nd4aa89EM/buT5YcdqGvJAIfwPZ2iHUWa8ykrkTVVcRkaJ6Ze3HtywjWS4UWSxPAb06VO1IWDAapqkwC4eAgRmQgyvdHVbcHhSojgZedlO4sTA01w9xMeKoD2JEz0HGqOqfRDZakRe1pQZUvTo4wggIE7j1s3ePlNf9gKWwyCEvgLzcFwTApRwwVc0QvR5/KbksV9548Xd1ahWhUtbMPwAy0VhrRwIv06Oqcc0j3DM99NusBYPQ5m7/FERbF+gZIyyDx2Ao7OBa+RdCc9pcXmY+5ZZfFDoriUrP1GdNWHo42Ixbgw0Zq9tE28jcOXqsQmwO2f6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jdkh2oAG5nnCXQvMNmwAI6pYV0dsGBMjdClv8mL+7Ss=; b=uQZFTNwBCfIV4DRhSwGdNXtn3NBKL5z1bEK1/f6PADFtagYl2U/B8i4GRpCucpwuOpmh1CSyE3lRgNumnKsY1kJjPg7KXb93nNKdFWUnQOsuEt0+Ji3vcGEMm17+TUpJWY7a83uHNUD0LkOvS7O49Zq8I6KGAU1857ktH/Bs0NtZAWuNlOa3BzR3S1radTcnfTNNYEvue4Tavx7qHAVQEr6+2OH+VG1GjQZvzbuKBQXbl8rj9d8ET+IOE3yGFhH8os/mq5IzwXgDGuxi0Yl7GQ+WI4eRjzEW2m4K2nzT1PHPzLMiC63sTEbtoNBKvpJ2ww0D/iwsEk3JfE5JLhk/mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <90ec98cc-e416-05c3-f507-5e4b2b7f937d@suse.com> Date: Mon, 27 Feb 2023 15:46:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 4/4] xen/x86: switch x86 to use generic implemetation of bug.h Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <38bb75b9add8655288347aa4df1394450e4e10c9.1677233393.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <38bb75b9add8655288347aa4df1394450e4e10c9.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6896:EE_ X-MS-Office365-Filtering-Correlation-Id: 673ce911-51db-4e3a-7d88-08db18d1673a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RzGKpwSJzo1d1YZk2SGYbIahAzg1fmkQR+2zNl/9IozDyXa94DUTZspGxHlFnuVERxhBKBpRTIkHooNUmf7TxEmX3/mwtKzIFu8rYisp1/L78s8MeldKjG0H6nfe/E+pLZjc62hJgFddpyDDbRzpgX5kaNZ6SzUnxtqNmHkzhrJzVp/L9jLKq4L9NfMchv8saOLVwF2UQAvdM0HfQet/nnMfSKixJyAugR1XZVsDHjHK0MLL99mFqsVBkn47QWrHhspRmW3tnjJd9oQxZfH5779sjxqFv5NLjq679MNk+sXZxmARUTj52n9Gk+ki5tr8Bn68IIwxsBpMY9qTqSALwJCwPADmPMRUWFxw6f6ZGNhJUW9Jqbc3ndFY3PHGjFfgCcG1nMnE3rpq+R3jO155QK/ikXBrZAN+x+AGy7HVryRESNjM31I3jfSkCxjyGH+v95cZ/YqnDt/aYosP+M964hoC4fYTTGTWRfcBgW+C11JBg0nNmdd7mmKOXC2ObHE4BxhoCFjNQawutp8yujV1X2kMc8dXCyFKGCCXzv3j3/DycMrF5tH1vwnu7BXEBwj13YxzRSd6Wi8Wl8x+0IsgIztnd1wIEI4uhX7jxd5sl5nuli268ACMfmprcwAxOdCm5Wz5lBgmLzVLF3Voxkty9lLDWSPMceXEwlxWQeAVhf9KuoCWx4zFTkv+Kw0L11EyHw22MMSA9+f2nmDHaYsnx9p+dtnVqPfRNtOXAz4J/haW1bEyOXqJN9uKE8HLBqP8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(346002)(39850400004)(376002)(451199018)(316002)(2906002)(31686004)(31696002)(36756003)(5660300002)(8936002)(86362001)(6512007)(6506007)(66946007)(186003)(26005)(8676002)(6916009)(66476007)(4326008)(54906003)(66556008)(38100700002)(53546011)(41300700001)(2616005)(83380400001)(478600001)(6486002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEZhcjd0MWFJWlp2RXNsT2JvYytJRDR0Z2huN1BERW9GYm8zZG44SnRZZ1pq?= =?utf-8?B?b3hjL3pUekMzL3VETkN0M3JUNDB1bDFLR0p0aitpZG5NQ2hmSjBVOHpTQ0Jz?= =?utf-8?B?UkdNQTJGcUpqNUVNT21BVHhacGhDVmJnb3luVE9PajAvckhQRkwvYTkyeGhm?= =?utf-8?B?NFNkZGpERThtdmNDUndKdkc2djlrR1crZWtERVBZZVhPdGdhOFpJQlZpSnVW?= =?utf-8?B?M3F0a0VHVGluMkNRU2hOV1ZTU1NzYWVNSE96OXhWTUhsbkZ1bVQycWdDaE9w?= =?utf-8?B?dHdhc2hzbkV3Tm1aY0ZaWDVBaGdIVmZBSDQrUDV0YllpcUYzL284UjNWeGxQ?= =?utf-8?B?bHMzWm84YTU0YUZUMXd0MXBiRWw2cXNGRHNqZzVkVDJhclpVSmlrS1VUcXc1?= =?utf-8?B?VWpCNzVYS0E3dG5MeDRvUmhqMVAzNzE2VTRkbS9DQUlpRCs1ekpEbDFHVXFP?= =?utf-8?B?WEEwa3RLcU5JZWdWSHgxeEJTOU9uN25aRi9UOXpJbS96TFNKVStMZHNLQUlJ?= =?utf-8?B?T0wzc0I2MWJtVnh1WDJoWkRJbjVRaEdmN3NvOG1GbVNzWGkxampLdWhrTnRr?= =?utf-8?B?aXNtZkpPQkZoUkdVWDdaV0VsVk9VemJmRS9JSWFxQ0FmRktEM0VaNHNpa1hP?= =?utf-8?B?b1h2Q1dYUGd4UDFsbFEyemFnT2psMnlmT2owei9rMjI1elA4bTBLUjk1RnBS?= =?utf-8?B?UjNQaDFydmxpZUdWMmI1alZSVk9jeUJsVzZ6TUl1KzJJak91R3lvU3pTQjRF?= =?utf-8?B?bUw2bkpvamM0MTRlbjdleDduRUEwM1l6WFZQSXpwZTRkaVJmbjA0cDFzK3d1?= =?utf-8?B?Q3N6UWlzQ2ZhWkNYZ29JTnQya1M2a0E2S005VkZMbG9vcWhhcmlvcXB3ZXNo?= =?utf-8?B?RXZmV1VkbEgway9VVHJPMS9HTEVoZWJudTF4QUUzRlQydjE2T0ZYUGt4SU9h?= =?utf-8?B?ckRubUdyOS9TZnArMkIwbkYyNEdjLzBZeU5sQ08ydm43N1huVSsvNzAzaHln?= =?utf-8?B?eitRMnFhclAwVERSZXFhL1hQanVxNWVPSCtXaFVvZk92TmFTSHpMTWpvcWJM?= =?utf-8?B?clRtRkZsS3I5aFhZeGZFOXp4Z2dzbFVBRG1Pb0ZTbHlpQjhCQ09id0Jvb2xS?= =?utf-8?B?bm9rZXp6aGxhSzBPbEl5dnI4aGw1ZkxQZTFLVy9hZlJRbzRpMERPZStjOHZo?= =?utf-8?B?Q3dCNE9UbDFRSlU5aWZ0TDZIRFRVb0dIMm1tWmtnZUk0M21LZTV3T0RwT3oy?= =?utf-8?B?VERXV1pvTHBFaWdSaU5EZk00d1g1UThnRDlCa2Z6cjZvSmxMeEcvdVIwRkJm?= =?utf-8?B?ZjVWMzhpMzhUaDRWMTFweS8xUnVZNVFGOFE2WlI0Z3FtUzNGRmd3UWRSS0Rx?= =?utf-8?B?OHlpZlpoR3QyQ2VpRmRHN0pwVnlHWEhXdDZERmY5UXVFd0pUczhTQTJ0a29z?= =?utf-8?B?R1hBcThTajBVSDA3aUh3S0xpZ1lzU3d4eFlRTVRxbDBYS0xMZWVoN0ppcVRt?= =?utf-8?B?d2h4dmFkeGNKSm8zVDV2UThOd2lGSmVtV0ZTaUI1TUtqNEhHSTc1cGUrSkNk?= =?utf-8?B?dk9jZ0h3cU9ocmlIYUczbWVnQzlqOUtCL1lpbXljM0txWnBtMVdNVHdPUUxm?= =?utf-8?B?eTJWdUJuWDU1cTVZQ0syWlRsN1ZGQkM3NEVObWFqS3FSbDlHWHNSV1JiaStt?= =?utf-8?B?alpBUTFvN0dSNEltclVwb0JvdWF4T0JBNThnVWthV0lWUzNWcW9uRXdxcUZN?= =?utf-8?B?UkQxUUtXSHAwQnk3YUdMTVRmNmViWW43RUhvWFB6R3VTL2EwaHZYMUdkN3Z2?= =?utf-8?B?aHFveHZydjYxTHpIZkJKcWNDOW40MWFwVnFockExZ1hlTld5VWNNU0kya2E2?= =?utf-8?B?bjF4clhNVndyY3FSNHFKcHBJaDQ4OUVrK3RtQmRVR1hEazJLWmtHK0JTZTNR?= =?utf-8?B?VndxL1VPYys2empaMlZlN29zNmpxU1I3RzQ0UEljUDIvaHl4V1FsRG1pdUo3?= =?utf-8?B?L2ZxOTYyTzBSQ1EyeEZTMmNRc1JTamc5Y2lZMUFzWko4V3lCaXdZNktYVmk5?= =?utf-8?B?ekVZOVczSDJKY3pRT2tPT1Y5QmxxcFVVdUd4dWpwRzhLaEhraEMwbW5abGd5?= =?utf-8?Q?aPiGTWnmuDYTB7w9/j+GnQnVp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 673ce911-51db-4e3a-7d88-08db18d1673a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:46:26.3268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DzMGWu6g2bnvCrCSy7iSV0yfCBnlr3MupONbQkvUNzp7hqpvH/rhtNEXSPNEY3Cq+OnkMIWPPzZzc8zTgyOSsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6896 On 24.02.2023 12:31, Oleksii Kurochko wrote: > The following changes were made: > * Make GENERIC_BUG_FRAME mandatory for X86 > * Update asm/bug.h using generic implementation in > * Change prototype of debugger_trap_fatal() in asm/debugger.h > to align it with generic prototype in . > * Update do_invalid_op using generic do_bug_frame() > > Signed-off-by: Oleksii Kurochko Hmm, there's the question of where to draw the boundary between patch 2 and the one here. Personally I'd say the earlier patch should drop everything that becomes redundant there. I can see the more minimalistic earlier change as viable, but then the description there needs to say why things are being kept which - in principle - could be dropped. > --- a/xen/arch/x86/include/asm/bug.h > +++ b/xen/arch/x86/include/asm/bug.h > @@ -3,75 +3,10 @@ > > #ifndef __ASSEMBLY__ > > -#define BUG_FRAME_STRUCT > +#define BUG_INSTR "ud2" > +#define BUG_ASM_CONST "c" > > -struct bug_frame { > - signed int loc_disp:BUG_DISP_WIDTH; > - unsigned int line_hi:BUG_LINE_HI_WIDTH; > - signed int ptr_disp:BUG_DISP_WIDTH; > - unsigned int line_lo:BUG_LINE_LO_WIDTH; > - signed int msg_disp[]; > -}; > - > -#define bug_loc(b) ((const void *)(b) + (b)->loc_disp) > -#define bug_ptr(b) ((const void *)(b) + (b)->ptr_disp) > -#define bug_line(b) (((((b)->line_hi + ((b)->loc_disp < 0)) & \ > - ((1 << BUG_LINE_HI_WIDTH) - 1)) << \ > - BUG_LINE_LO_WIDTH) + \ > - (((b)->line_lo + ((b)->ptr_disp < 0)) & \ > - ((1 << BUG_LINE_LO_WIDTH) - 1))) > -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp[1]) > - > -#define _ASM_BUGFRAME_TEXT(second_frame) \ > - ".Lbug%=: ud2\n" \ > - ".pushsection .bug_frames.%c[bf_type], \"a\", @progbits\n" \ > - ".p2align 2\n" \ > - ".Lfrm%=:\n" \ > - ".long (.Lbug%= - .Lfrm%=) + %c[bf_line_hi]\n" \ > - ".long (%c[bf_ptr] - .Lfrm%=) + %c[bf_line_lo]\n" \ > - ".if " #second_frame "\n" \ > - ".long 0, %c[bf_msg] - .Lfrm%=\n" \ > - ".endif\n" \ > - ".popsection\n" \ > - > -#define _ASM_BUGFRAME_INFO(type, line, ptr, msg) \ > - [bf_type] "i" (type), \ > - [bf_ptr] "i" (ptr), \ > - [bf_msg] "i" (msg), \ > - [bf_line_lo] "i" ((line & ((1 << BUG_LINE_LO_WIDTH) - 1)) \ > - << BUG_DISP_WIDTH), \ > - [bf_line_hi] "i" (((line) >> BUG_LINE_LO_WIDTH) << BUG_DISP_WIDTH) > - > -#define BUG_FRAME(type, line, ptr, second_frame, msg) do { \ > - BUILD_BUG_ON((line) >> (BUG_LINE_LO_WIDTH + BUG_LINE_HI_WIDTH)); \ > - BUILD_BUG_ON((type) >= BUGFRAME_NR); \ > - asm volatile ( _ASM_BUGFRAME_TEXT(second_frame) \ > - :: _ASM_BUGFRAME_INFO(type, line, ptr, msg) ); \ > -} while (0) > - > - > -#define WARN() BUG_FRAME(BUGFRAME_warn, __LINE__, __FILE__, 0, NULL) > -#define BUG() do { \ > - BUG_FRAME(BUGFRAME_bug, __LINE__, __FILE__, 0, NULL); \ > - unreachable(); \ > -} while (0) > - > -/* > - * TODO: untangle header dependences, break BUILD_BUG_ON() out of xen/lib.h, > - * and use a real static inline here to get proper type checking of fn(). > - */ > -#define run_in_exception_handler(fn) \ > - do { \ > - (void)((fn) == (void (*)(struct cpu_user_regs *))NULL); \ > - BUG_FRAME(BUGFRAME_run_fn, 0, fn, 0, NULL); \ > - } while ( 0 ) > - > -#define assert_failed(msg) do { \ > - BUG_FRAME(BUGFRAME_assert, __LINE__, __FILE__, 1, msg); \ > - unreachable(); \ > -} while (0) > - > -#else /* !__ASSEMBLY__ */ > +#else While for new #ifdef-ary such comments can reasonably be omitted when the blocks are short, I'd recommend keeping existing comments (except in extreme cases) in the interest of reduced code churn. In the case here, considering that ... > @@ -113,6 +48,6 @@ struct bug_frame { > #define ASSERT_FAILED(msg) \ > BUG_FRAME BUGFRAME_assert, __LINE__, __FILE__, 1, msg > > -#endif /* !__ASSEMBLY__ */ > +#endif /* __ASSEMBLY__ */ ... you keep (but alter - please don't) the comment on the #endif, that's even more so a reason to also keep the comment on #else. > --- a/xen/arch/x86/include/asm/debugger.h > +++ b/xen/arch/x86/include/asm/debugger.h > @@ -14,9 +14,9 @@ > > /* Returns true if GDB handled the trap, or it is surviveable. */ > static inline bool debugger_trap_fatal( > - unsigned int vector, struct cpu_user_regs *regs) > + unsigned int vector, const struct cpu_user_regs *regs) > { > - int rc = __trap_to_gdb(regs, vector); > + int rc = __trap_to_gdb((struct cpu_user_regs *)regs, vector); I view casts in general as risky and hence preferable to avoid. Casting away const-ness is particularly problematic. I guess the least bad option is to drop const from the do_bug_frame()'s parameter again in patch 1. However, for a fatal trap (assuming that really _is_ fatal, i.e. execution cannot continue), not allowing register state to be altered makes kind of sense. So I wonder whether we couldn't push the casting into the gdbstub functions. But quite likely that's going to be too intrusive for re-work like you do here. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:46:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502650.774542 (Exim 4.92) (envelope-from ) id 1pWem7-0004VS-UK; Mon, 27 Feb 2023 14:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502650.774542; Mon, 27 Feb 2023 14:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWem7-0004VL-RQ; Mon, 27 Feb 2023 14:46:47 +0000 Received: by outflank-mailman (input) for mailman id 502650; Mon, 27 Feb 2023 14:46:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWem6-0004Ql-Jz for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:46:46 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20601.outbound.protection.outlook.com [2a01:111:f400:7e83::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a715ff6-b6ad-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 15:46:40 +0100 (CET) Received: from BN9P222CA0020.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::25) by MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 14:46:36 +0000 Received: from BN8NAM11FT005.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10c:cafe::b3) by BN9P222CA0020.outlook.office365.com (2603:10b6:408:10c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 14:46:36 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT005.mail.protection.outlook.com (10.13.176.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 14:46:36 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 08:46:35 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 27 Feb 2023 08:46:34 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a715ff6-b6ad-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h513patHevOVVsikYkSTPL9llwCBJ7Vm+1VMwE31de89s1ombciXtgbLXnmTc2IOBkG7LvGMmYF9NpWgHgPZJ1OAa5EHSmb+KrFMAomG5u7Q0mfgnB0VYGztp8K2Bx5P2AWxaziP+feVk/rJtP1Q4qRWQ9yEgggZkv0jMI2q4HPNu3M/+TW2Tfrz9XCemwx9ihbZ6ASIzRbCTibwMq1Uf839SG6K/HYOIwRkqDNz5y3HwQvU4d0D9HM2rfFS5hpplAKRVfai+yZynhhVssZBS6unBuL8ss9GFHp14vbf6seULHGElyraOSn21WRCMQyYB4hdy9qqtGJVigUSJeSuCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M8dh507pGMYHxnf6lKuc6a4Vv1vbjkxjg77QAZ51vcU=; b=mRszAGoAirkh2hTo/VYIIQfv82XxhVTMFMxeT0sN5sfr7+PHwxkpUZzeacfWhEKAEvfOyEkIQ2pqK9tq8NnEW4jkhPMma/kQTouAb9cCctAeOWSsxRWYhsoLFEFBnCBoHNhqzyMXY5ny2N296elR7/qUpqbAfYBSKEvJv6pW+XXy+csKZchPX74aFwZOOFjAtAvsvwaAihu8LQiA64uYxDB6P134PO2Cjyy7h52ndcARTKfsMIRv0riqw9bqaDB9077toVI6AQM9KBRjqRIX1Vj5/mubTwmjUfHDqiMnzMJ5BgWBNvz+EsrUH80Zcro3bIBQjpB47QELSQdYANfSzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M8dh507pGMYHxnf6lKuc6a4Vv1vbjkxjg77QAZ51vcU=; b=XvRRR+WvP54czRkhustQ/f3NLhncNYxU6XPcRJrlmvUDnuuXN5E6oD2fwfHRXhtKmReT8wvozWM8x9itNIk1Hk7K+q2aNJSdNZuE2DJsywkdjjmzQNuh0q7XxEiWsR5mTmLUVdMdtMyDHE9T2q877b/r1fEdLBaIidVRbVcUk6Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Mon, 27 Feb 2023 15:46:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT005:EE_|MN2PR12MB4301:EE_ X-MS-Office365-Filtering-Correlation-Id: ef5bf30b-c48d-4ec5-39c2-08db18d16d3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ju0Js9mEPV+g/1W2UBrEkHAh7PavoXSLragB5McX+EO88ZCNm+epKc1b99odVEs35kjjKG8q5qSRh3ot/MnvXKYJfAWPjqavCbHTCm1lSfJDjjHmljjh2pgTj3vgtsMSA/fO2aynqn/L/wv+kFX6MhinRwGsqmfgflcv5hjr2vPKmndz+q8+8pVYdPq7GKyyUeuIoy9evZoT3EUOz4wk52rxht5+x8Vllik8OJ5FlCjKBgDQWgTssXycvofVJKPV3+cFiq38BbJBPNQHhJR07CB2YnjkghvqRlxSej9Qs6ViHAiqch8tifKJ17/V4jFviA9CZ3H5b4gaL5COfZSw2XiFoMEKG1qSPKDg3Y0GKLOhMP6M50Ruoawo3Eb+Ec4ByrkSKhq+attP6ZYP8iWKaWKpGyDwAVvDGYM5S8CV1gbiBI7njRHw9eHwijJhdec4vzqMMY8f0iJMHFb8gEjZuhifz5QNbTMU5TVzEMaSh1IefAofRs4D2WTRMLWk0w/Ct4Tz8JRhqSZ9wd2um6/7tACbfO6OpDyKBBMdJZaZk6nZKPk+f03N8pqmQhFf6O419ktB/OsBL58bVkMJewygtx6+J6KehoYALRVfUosZkutQdhJvPRYvD7u7ypgmiT69TMu5pphI8olWTcwy7hOdeb4F6LkOMRB2g88NGXwy4G3fXrJwAAOtjn2UU6Z40xSAe/lHmX7ENWODGlNtWhpSWXyg54fU/fTgvAhHWa2uvprjnGnOf13mrZhEzUa7+Bftfj+M9NWQZp79eTXm9s+YUg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(136003)(396003)(376002)(451199018)(40470700004)(36840700001)(46966006)(4326008)(70586007)(70206006)(31686004)(6916009)(83380400001)(426003)(36860700001)(41300700001)(47076005)(82740400003)(336012)(54906003)(316002)(36756003)(8676002)(81166007)(16576012)(8936002)(5660300002)(44832011)(356005)(86362001)(478600001)(53546011)(186003)(26005)(40460700003)(31696002)(82310400005)(2906002)(40480700001)(2616005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:46:36.2770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef5bf30b-c48d-4ec5-39c2-08db18d16d3e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT005.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4301 On 27/02/2023 14:54, Jan Beulich wrote: > > > On 27.02.2023 14:41, Michal Orzel wrote: >> Hi Jan, >> >> On 27/02/2023 11:10, Jan Beulich wrote: >>> >>> >>> On 27.02.2023 10:53, Michal Orzel wrote: >>>> --- a/xen/Makefile >>>> +++ b/xen/Makefile >>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>> >>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>> define all_sources >>>> ( find include -type f -name '*.h' -print; \ >>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>> >>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>> also only be included when selected (or at the very least only when an >>> arch might select it, which afaics is possible on x86 only right now). >>> >>> It would also help if in the description you made explicit that SUBDIRS >>> isn't used for anything else (the name, after all, is pretty generic). >>> Which actually points at an issue: I suppose the variable would actually >>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>> has caused crypto to be missing from SUBDIRS. >>> >> I think what you wrote can be split into 2 parts: the part being a goal of this patch >> and the cleanup/improvements that would be beneficial but not related to this patch. >> The second part involves more code and there are parts to be discussed: >> >> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >> top of the Makefile (thus harder to make sure the linking order is correct). >> >> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >> but for all the existing architectures. > > I understand that the changes would be more involved, but I disagree with > your "two parts" statement: If what I've outlined was already the case, > your patch would not even exist (because crypto/ would already be taken > care of wherever needed). > >> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >> into account for the tags/csope generation. Would the following change be ok for that purpose? >> >> diff --git a/xen/Makefile b/xen/Makefile >> index 2d55bb9401f4..05bf301bd7ab 100644 >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >> >> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >> + >> define all_sources >> ( find include -type f -name '*.h' -print; \ >> find $(SUBDIRS) -type f -name '*.[chS]' -print ) > > The fact that, afaict, this won't do is related to the outline I gave. > You've referred yourself to need-config. Most if not all of the goals > SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. > Hence your change above is effectively a no-op, because CONFIG_CRYPTO > will simply be unset in the common case. Therefore if an easy change is > wanted, the original version of it would be it. An intermediate > approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. > But neither would preclude the same issue from being introduced again, > when a new subdir appears. I understand your concerns. However, I cannot see how your suggested changes e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. They would reduce the repetitions (hence I called them cleanup/improvements) but as we want to keep tags,cscope,clean as no-dot-config targets, we would still not be able to use: SUBDIRS-$(CONFIG_CRYPTO) += crypto and use it in all_sources (because as you pointed out, it will be a no-op). Also, why do we care so much about guarding crypto/ if we take into account so many architecture/config dependent files for tags/cscope (e.g. in drivers, lib/x86, etc.)? If these are no-dot-config targets, then we should take everything, apart from really big directories like arch/ ones. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:49:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:49:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502658.774552 (Exim 4.92) (envelope-from ) id 1pWeoE-0005J5-FO; Mon, 27 Feb 2023 14:48:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502658.774552; Mon, 27 Feb 2023 14:48:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeoE-0005Iy-BU; Mon, 27 Feb 2023 14:48:58 +0000 Received: by outflank-mailman (input) for mailman id 502658; Mon, 27 Feb 2023 14:48:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWeoC-0005Is-Q3 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:48:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7d00::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbcad65b-b6ad-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 15:48:55 +0100 (CET) Received: from AM6PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:20b:6e::34) by AS2PR08MB9692.eurprd08.prod.outlook.com (2603:10a6:20b:604::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.26; Mon, 27 Feb 2023 14:48:53 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::77) by AM6PR02CA0021.outlook.office365.com (2603:10a6:20b:6e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 14:48:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 14:48:53 +0000 Received: ("Tessian outbound b29c0599cbc9:v135"); Mon, 27 Feb 2023 14:48:53 +0000 Received: from 490f95cec287.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D94D4280-329E-4C8F-B0F8-095C37A75250.1; Mon, 27 Feb 2023 14:48:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 490f95cec287.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 27 Feb 2023 14:48:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VE1PR08MB5647.eurprd08.prod.outlook.com (2603:10a6:800:1b2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:48:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:48:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbcad65b-b6ad-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xgk1oCjyVY9ja+3zfXTQLFhzrjUGIMb5fwkTK2FrSNs=; b=E7GW98x8OH9oQ4YPEwAeuX3qxp4q9A7unxq39sqinxKDJEc6sLpDcS0c+6MOErHaBEYbITVKBholsN5/TJxF1ppy3TUoFcjejh7CeiV43yhUDMxxbF1uO8qx7VNTZsmmYM/h2bCf+4CQQsXDH8zOc96dj88KO2O9/de/dSZjKG8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 235306aadbd222af X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PkDMUxxlRvpWMq4TOF7zpK1gbazjcFBwivixZ2/iuP/h7nqRKAWoPUq9AS+MlLPMjbWk57u1fYzg9GjjVGUGy3oAH49vLdN6pr7RDO4Gfgk9TVSN4wxBi3zi8zpWnH1FMTtjujit7HlAtWgpbnCi7wUzHkh5ty+y7IGS+kI/Hbs0IYLmkcz4gnEgkKIGVvV1NWPKzZWXbHjmApTIFf9eVDquxPv+n+Yuf0M/2dD15QyEgu185fDixgULtfrj0uQb4NKv7W10BnSyaam7DT1uuWTR7XXnOc5HisnjUKI3Gka6FAyPwGKC87iRrnObG0CFbeyx2ySmqZDcKydMQMZMrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xgk1oCjyVY9ja+3zfXTQLFhzrjUGIMb5fwkTK2FrSNs=; b=AUvQi8VSK4bgdiy038IPKZyDOoxPzVMy3b+aLlM6NnsoaimMwyYLRKzzcH4uEL1Lxtk9ccVbzCb+E4yervaL5Y7Wp2fp/IhpPAQDp+F3DVAjtpxp1Ryh21BG/bJHc6IfnoO0SjZTGEqqIE+ZdE+HaQUsLgJWzop9Gw4rJfdgrxU0yEh9QOpjbp8CryLr9uFG5G49Qyl832aVK4RryYZByDTWtOdyDf7jFZZvIASloGFhhTmE2ggSPrh34d4BppgaSqkCAlUO/lywKrxHSIlTl5qPNx+E9exUa0hgKb7+1icKbUNDRdIugRBOVa9lWzq1Gv0Wz9zkXF06v+u9kRsXlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xgk1oCjyVY9ja+3zfXTQLFhzrjUGIMb5fwkTK2FrSNs=; b=E7GW98x8OH9oQ4YPEwAeuX3qxp4q9A7unxq39sqinxKDJEc6sLpDcS0c+6MOErHaBEYbITVKBholsN5/TJxF1ppy3TUoFcjejh7CeiV43yhUDMxxbF1uO8qx7VNTZsmmYM/h2bCf+4CQQsXDH8zOc96dj88KO2O9/de/dSZjKG8= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET Thread-Topic: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET Thread-Index: AQHZRtMaqQfE5Y/rpE6cfyFi/Dbnk67i53QA Date: Mon, 27 Feb 2023 14:48:39 +0000 Message-ID: References: <82e4e0c3ac1614822fddd90336c22e6fad5b485e.1677079672.git.jens.wiklander@linaro.org> In-Reply-To: <82e4e0c3ac1614822fddd90336c22e6fad5b485e.1677079672.git.jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|VE1PR08MB5647:EE_|AM7EUR03FT055:EE_|AS2PR08MB9692:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ed2b639-f4f4-47fa-f246-08db18d1bee1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Nd431pvPVXG/i13vyx0Pj8Kc1ugKzFk3SKAbiOU8V92sO+fcoZzEME+Rf2um1/k26ah13YKL+3mdo9VuOnHiRHvSDk/agDAnLUtg0H6Oq/pArgQZpxAJKvNPQ+Ae+sYu5G52ftrKblXiPxOGokqmOh3DcHtex5b5pB9zfQqp6aMAf0+gUlwZTOpruZ1k3i1Ve5BR93xTdk9OsrcGUl3wdkdC32S7iwvNzx6KJ0dA+ef2iWDkLvndJUDulyF2AURKltb3qgVMx4YxaRNwXrKJdOgBeh/cwj3sNaCLSGzCQ7Z1q4jL41Xl7r4d49g3yOtVJkyPlaTBvRPWQr9bRPE3I6NHO3UeQQoFgEXX2kotY5JWy/cloC6FaeW3raLu53yZyTobx5kU+fAe95/ygysOmEdvdObC7C9O5+dRwdX4T8kn54eZG3CXDe/4OG0RjR8OGTwRhIt4nr+vm7ORfEUaEiCeOWBrV+d0+8ui6S6zcH2ukTEnteP7+urMt3XmUSe+uYXG+s7Ux8qEF/SeLUwtktD2NfNaUXQXvXsQ9abkVyEt9n+a2o/c35blBAHdtKmyhlT3t0D5IviPz3nfd9ylMZQEEpOkAe3kXZEuCpqA2m5Y+1n4/8SUzFfJZIe6CjwmFmyf3NCQOsMinlWUwtJAuBlvutrI9qn+arZ9+i0ssNcyajYlZRkfXgQGd4LwerqL0TRvvbc62atjyyre7srz/DCxjchAfk3DMt/4orZJlXM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(396003)(39850400004)(366004)(346002)(451199018)(36756003)(8936002)(5660300002)(6512007)(6506007)(53546011)(38100700002)(316002)(122000001)(83380400001)(26005)(186003)(2616005)(86362001)(33656002)(54906003)(91956017)(66946007)(76116006)(66476007)(41300700001)(6916009)(66446008)(66556008)(4326008)(8676002)(64756008)(478600001)(71200400001)(6486002)(38070700005)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <419C19DCA2DF5A46B6477A5BC15E4D4B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5647 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aacb6945-68b3-4da4-5c96-08db18d1b689 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iGPco0Tv3i5T8IqIsJ2wlzusZnIvoJP5px31Mu/OOSwGr8b77HL5RSff6ZJG4cbSE0rfyXKwWApm381k5/v6oAE7bweQ03U0L+m3HHjKowFWwm70kdtSd/J/6QFrOKk5KrkC0VHjHbvqq4419xDji0g4CU07SKy2TJFo48GYbC5bUIO8notZGqwcom/64TqMRGaiQTg1/4y8Rz63jB20tS7cCeZp4YUMl2KaAlnv/MVqgyeeFMbWomAuapx7gSzapMURm8qaSSfU7YWycoUf4xwWc63jQjp7T9JFCyGIvNt6tx6yucTxSJvJ8tRXONeHO89Re/b7rKLjNw6RvuZwM6KaP8DMQtcDi4FzADkc1YtYrA+gfa4RqsjTNJyaYyHrtb0wEGVv8yV5xIwTOxX1JqRe2jCTkOUsdbFvojI95QfRXfeI1VIJ3Sz0Y+uoASQhQxU7hK32p47m8ZBI46E5I44iLT1e0zYfHIlsVRiFpu5nf5/mmh8rDkPZS+x7/zzGVPeL6vC5eQoq533mzZgAgYa/KECNZr/cjrOkY9xRlIj1YCseIOOKWLuA9DZ+Fw8ayfHi2tulExqrlYdcpBRfQBx8EHs9Nxvqd/d2RdKtmgyqlbXLlZyCs7mW3kQmZj9t7qAG71dASUFq9YvfFkeMGYa3Le8bkoIObRTVHkEQv7GiHmNSkXuQ8wy+H+//X+L9H37PWG5tgKl92XfwWB2SEA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39850400004)(136003)(346002)(376002)(396003)(451199018)(36840700001)(46966006)(40470700004)(83380400001)(6506007)(40460700003)(36756003)(36860700001)(86362001)(6862004)(8936002)(82740400003)(81166007)(47076005)(356005)(5660300002)(40480700001)(82310400005)(33656002)(478600001)(336012)(2616005)(26005)(6512007)(6486002)(53546011)(70206006)(4326008)(8676002)(2906002)(70586007)(316002)(186003)(41300700001)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:48:53.2298 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed2b639-f4f4-47fa-f246-08db18d1bee1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9692 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > Adds support for the FF-A function FFA_ID_GET to return the ID of the > calling client. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 8b0b80ce1ff5..463fd7730573 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -167,6 +167,12 @@ static bool ffa_get_version(uint32_t *vers) > return true; > } >=20 > +static uint16_t get_vm_id(const struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > static void set_regs(struct cpu_user_regs *regs, register_t v0, register_= t v1, > register_t v2, register_t v3, register_t v4, registe= r_t v5, > register_t v6, register_t v7) > @@ -181,6 +187,12 @@ static void set_regs(struct cpu_user_regs *regs, reg= ister_t v0, register_t v1, > set_user_reg(regs, 7, v7); > } >=20 > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > static void handle_version(struct cpu_user_regs *regs) > { > struct domain *d =3D current->domain; > @@ -210,6 +222,9 @@ static bool ffa_handle_call(struct cpu_user_regs *reg= s) > case FFA_VERSION: > handle_version(regs); > return true; > + case FFA_ID_GET: > + set_regs_success(regs, get_vm_id(d), 0); > + return true; >=20 > default: > gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); > @@ -221,7 +236,11 @@ static int ffa_domain_init(struct domain *d) > { > struct ffa_ctx *ctx; >=20 > - if ( !ffa_version ) > + /* > + * We can't use that last possible domain ID or get_vm_id() would c= ause > + * an overflow. > + */ > + if ( !ffa_version || d->domain_id =3D=3D UINT16_MAX) > return -ENODEV; In reality the overflow could only happen if this is called by the IDLE dom= ain right now. Anyway this could change and this is making the code more robust at no real= cost. I would just suggest here to return a different error code like ERANGE for = example to prevent missing ENODEV with other cases not related to FFA not being availa= ble. Cheers Bertrand >=20 > ctx =3D xzalloc(struct ffa_ctx); > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 14:49:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 14:49:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502672.774562 (Exim 4.92) (envelope-from ) id 1pWepB-00069R-P8; Mon, 27 Feb 2023 14:49:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502672.774562; Mon, 27 Feb 2023 14:49:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWepB-00069K-MI; Mon, 27 Feb 2023 14:49:57 +0000 Received: by outflank-mailman (input) for mailman id 502672; Mon, 27 Feb 2023 14:49:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWepB-00069E-5F for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 14:49:57 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc6b907a-b6ad-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 15:49:53 +0100 (CET) Received: from mail-dm6nam10lp2108.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 09:49:31 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6052.namprd03.prod.outlook.com (2603:10b6:610:bf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 14:49:14 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 14:49:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc6b907a-b6ad-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677509393; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=iY4MRneShEdl09YptamtBOd+4nAdAUzUI3hqOx8TSnI=; b=drxHuMXPANluVEXH4UrcOTKc4A7+K50G7b6P5ze+F2/ZZ4rwSKgduG2D 7LKeFiQb6SR83r0Xtpn0/CHNq9bWyQZ+bhjbg0RUtfXZ5icQrVi00RgIg IV/K5opOO53ep31bm8go8I6Na2ZCvjLYz1OUycitiDxWTybdzlUmbASMt Q=; X-IronPort-RemoteIP: 104.47.58.108 X-IronPort-MID: 98697399 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9BTA8aI9x4F26OLAFE+R6pQlxSXFcZb7ZxGr2PjKsXjdYENSgTEGy GsZDGGCOvqCM2b3KYh2O4Sz80gH6sWGytJrTwVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA5AZhPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5RDD1S5 P01AQoLdzKq3KWEzKC6Ws1F05FLwMnDZOvzu1lG5BSAVbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGLnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHOlCd1JRezQGvhCgVKS+lY6LwYsaVqi+aCXmEK+R8tYJ BlBksYphe1onKCxdfH/UAe/u2WspQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHvbGKSHTb6rCOqjCaMiwSMGNEbigBJSMa5/HzrYd1iQjAJuuPC4awh9zxXD31n TaDqXFmg61J1JZbkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshXVMzlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:/Q2e06lgUTnC7d2hrQ1l2HYVL7vpDfIp3DAbv31ZSRFFG/Fw5P re+cjztCWE7Ar5PUtKpTnuAtjnfZqiz+8X3WB8B9uftWrd1ldATrsSj7cKqgeIc0fDH4Vmup uIHZISNDQlNzlHZc2T2njeLz5XrePmzJyV X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="98697399" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKlC4Kz2GNlwcrVE0EzJk07NMm5b3vHM1Y1qzDy35f98vCKrh7pCY4A47cf7yWQajpZGs8s3QLsBXI2V2ueJeviS6i/xugbaTvAGXA8K3yJo4AMyCd0fBl3NlLjTds9QCP3ahEEunokQ5Wv6SiPxXedCpmYthRJKKA+As9ujIntRW/dpL5hI2FnY9NfoD3H5oyil1II9+VgIDySrEwBJD4y76ocytGUkta7om5Vbi7Ir60N+e1975zTgbYulKfG8a6JyY/VpLbZHn1XdbiQ5FnijV+8C6VxCbw6d6CylXpqOp9+XHafDb/xCbuJnKuo3gAF+B2Xr9Sl0PO45IdEWBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iY4MRneShEdl09YptamtBOd+4nAdAUzUI3hqOx8TSnI=; b=N50nCkxifC2PiontIPc/q0qBzNSHTPNaNHnNve47LowRlM0tJUhW7I5GQah4EICSxSNVoRKmRqJVvWQikpNvqn3875sSvqXzSf8+dKGljiakKR9HKLXiwBBfPuCd5kR55QJnbB4AofGd70Uo2GWs65EF2mT6Vfs+kO8WdEqcFFsFRZIuod7d9khFoRL3hnAiucS4+a0ya+W8sMG8YgoZW1hXFNh52CKoEOg280wNqcFYOaVhm35Zt0AkyqRAf8jpAmWruImaxSUyGjSU61klcl+BE+nwnFn/3srxkBQMO1rTKs+L7Mcd55JSY13tFpTCFsc9vHwiQEMWTEdjUf1SEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iY4MRneShEdl09YptamtBOd+4nAdAUzUI3hqOx8TSnI=; b=MgKXVVFkLVV3Mc+CCurba6UJanH41TqmN41B9N0PupIArZm/0k4xYXLDzAoB7TvHhBeAZZSNbUpzacmBY5kd7ypiacIlsLboGscvkPgnF3yo3hQq0LL+wT405k45rpNdvRuKYhy9C1OiSmzsvzoNXDTQC3FiZ8hzRtC/7d2Nd40= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <01313963-0cdf-e681-b0d7-9d0e756ea6a2@citrix.com> Date: Mon, 27 Feb 2023 14:49:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v1 1/2] xc_core_arch_map_p2m_tree_rw: fix memory leak Content-Language: en-GB To: Juergen Gross , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , xen-devel@lists.xenproject.org Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Wei Liu , Anthony PERARD References: <12b656b2-76d5-2ce6-9548-5ee8e57451ae@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0488.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::13) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CH0PR03MB6052:EE_ X-MS-Office365-Filtering-Correlation-Id: 648169a4-31c3-4c88-91d2-08db18d1cb79 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PsrjJZBSRRPHzWdtAleWQN9fnj+byDku+VVXprYmKkcGOHpFY6zUvpze9u/ptJk06bWgcEAXjSfQF57U/221dCgQEJns76mQ6lv65SgdX4uEPalftMZJ8PAUDYOZHNIyQZwR1yV0HoulVY30FGqqYWC9bRtPRinky2kBpxe9p+/BBjJypTzwPf6Grpf3yvddLC/RDpncf2UqZfWmBt9ADKStZCZOvLpIDxQL/CYa1Qxt+OQ5O4cmWRSRUpjQCCktYfzmTJIino5P8HvbyC93fupKVHIYSEQ3SkToGj/qPwp2IsaVbb80nliHVxy9mlgz7zpUM1bPS0lwSQMgWmyhEzf8FNzUSdDSfh86rsqF5n2MFlP2503ymbt//5v+RHVYenlOVRGHBU+9N9aQuc7qDDexViYFg4B6rTO+0VbCbIuQaZiEwqGp449/9wqunRhgNLBPgoafzsI5S0M/09MU368cWLiN0zXZHPvLditAqetLDXutGRIEfvL8fJPlLTK8+WrMWC8aypV3Wxc6steo4E3EvfgaHSvLYnLeuyMjFZnTWhH8TpBAggPOEu52fH/nB71jCwiz2H6RCJFiqHb2KBSKgA3Hhc1QonLnph7CJcoTvKeULJk0z1WHLlA5W8WoFZuYlJ1QleIlG5mb1OHwp+5iaPgQh7do86y9oDRhP1m2kzgS8FIIByyobNjNhWymIaeNqa+lyoOlIF18XRFjUoAMPaG4tUCHV8ZzJyTqwmLpBqmnkM6pULBR+Y640+IBtpj+e3IPwhKD6RaKuO1pTw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(366004)(376002)(346002)(136003)(396003)(451199018)(36756003)(110136005)(316002)(54906003)(6486002)(5660300002)(2906002)(8936002)(478600001)(66556008)(66946007)(66476007)(8676002)(4326008)(41300700001)(82960400001)(31696002)(86362001)(38100700002)(6512007)(26005)(107886003)(53546011)(6506007)(6666004)(186003)(2616005)(66574015)(31686004)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1Zjelp6eTdzbjdnQlB2SGQ0TSthVmpRR09Tam05M1B2OU50WWZUeloxeUVW?= =?utf-8?B?c24ycm01Q3VRYzJqZnlneFdpNzFzMkl3QVpTZkxHYUhXREdwQWROV2pJdk52?= =?utf-8?B?UkFOVUgrenh4aWJwZXJIRXpuUzBPOXUyYkVEUk5CZFBqNHhiejJZZTJlMk9K?= =?utf-8?B?eHJwQ09zUFdWelZYbU51MHZ6Zk5FRHVDbUtMTEZRZnV2K0RyODBvL3lTNDJl?= =?utf-8?B?N2FveEU3YS9pQWZRT0wwS1k0SXc0NVJNcEZBY2tsZ3lTRXh0MDJtNjVlK3Fh?= =?utf-8?B?eWRKWTdkeVBYdUswR1d4MHExWlVybVViUE9nZmtmKzJVSzY0RE1KUjhXYnFD?= =?utf-8?B?QUpLenFvZkJidTRzTFl5SjloQXFFd0lNakxYS2FaU2pJalpDTWsxSG5NZ3ll?= =?utf-8?B?d21OYjNGWjdHRHFvYzhyTXAyNEpyakovcnNrRk1mMEg3NHBjSlZkUEtWdWph?= =?utf-8?B?SlJ1NGVJZFJsMUloak11UTh4cE80OUZtMTIrSkdCL2JpU0E3V1NhUEdKbCtu?= =?utf-8?B?ZWJQR3h6VkxlZUlFQzduaHZCMWxDc3daeUhLQlF2Z2xZVGJDN2hySkNDaEFo?= =?utf-8?B?Q0tmcjcrUUM0YmJoNFVsRDQyV2FwM0JyMlJIYnlKMHBMd0hiaTVpSjhZdkNl?= =?utf-8?B?R2o2RW84OXhnR2thK3pLQjBRbFVtOHRvV1ZpMjgwMTJDeEw1T2JvcFJIbDFC?= =?utf-8?B?dDdZSFZ5bUd4bkpkV0Y4YmNVMG93UElrQlNyZEJGQXcveW5IYVdxTVZybk5Y?= =?utf-8?B?b1huTUFyT24zSGpFbG56UjBaM0ZsalJNVmVzSjdCYTBtNUMxQXNDUHdBTjE5?= =?utf-8?B?b1ZxeHlKL1Z3MHo1WjJ2TUc3ejRwQVdnaTNKUTZzK2dNbjV2QmVYRFFBNzR1?= =?utf-8?B?TlFQb1A2YTZ0eU9IbitJQWVhcTY3VlAwSXlBOTlpRXcvekpyYnBFV1dyUVQy?= =?utf-8?B?RTdhWmluUEdjdDZBSnBGZk41ZUgrSFd5LytoVXlTWk9RU3NacFJaWXVRQ3VF?= =?utf-8?B?MXhqWVB2K1FSRDRZbS80NDZKV1BzZUo3NDJMMHU0OThwMEhYYW5UYllWZVVZ?= =?utf-8?B?K3FZQWxZQitmV0hIUjhhV2xCSjVoVlNGdGZjMm5SSkZtZHdXWGVOOGZVVjJC?= =?utf-8?B?T3p0em1IWVdqelZyczdFYWlwZ3diNjJ1S3luaVBKMjhwRzVzK2xGMy9hdGdC?= =?utf-8?B?bTRiMGN6UjU5SDdwTGRtWHYxRytlTDRMVSt3MVN4VE11bUtNMy9iVDhnQ0Ex?= =?utf-8?B?czVyWmZCUkp3dU5UOGlBUzBtY2dGdThnNHAxQWVTTmxNczJCTld1VTdIUTdi?= =?utf-8?B?bjJrb0Y0di9zZE5hWFZtaDdFSi9HMnRaRnMvZHkwcVRJME5GNElJdFVXOEJL?= =?utf-8?B?MVJmNVJRcWQwdjV4UXVHVUhYV3MzUUxaSlgzeDJKSjJFYnR0ZzBudnJUejlK?= =?utf-8?B?ZE9LbmphVzlyUmh3bmZRa1l2amlKaTNzZzVhVmtQZVFTTGhJKzlTTmRwbjgz?= =?utf-8?B?VjZSWWtCbDU4RGhZYTEwcHliK0J6ZjkrdGkva3NDUnZwbllPNjZvWW1GZUMv?= =?utf-8?B?aXVnZ0xoT2VPWEJVczNQcm4vSVJ6aGRUWGgvdWVWZ2NSTzVIc2JUb09VL2lW?= =?utf-8?B?cU5RMThxYmd3UFJ1VzVwa2FVTVp5MTlyZENVQmw1c2JjRVRVL2p4d3B2Q2Q5?= =?utf-8?B?eS9rbTg5ZGFjdzhZR1hvRmFKK3IzZTJrbThJY09qbWQ3dy9XUGtCekpaV0ZZ?= =?utf-8?B?NnVNRUJWWGd3TTJvd09sS2F5K1FJZzlsWjVNblcwbng3SUVjMXpUYm01Tlda?= =?utf-8?B?QjFiRDZSRUc0SmdsV3JtSC9zUVBMMEQzYmJiNWtlNUsvQnU1d2Z3ZzMrVlYw?= =?utf-8?B?dk5jODErcndvT3VubnRiUnZ2STlJQ2dRSlhnUWJBL2ZNZGo1OU9NOVpGS3Qz?= =?utf-8?B?djhwY0FNMEM2S3RyRFZ6eXpLUEhrNlo3ekdOTVdodnp0RFRPMWc1eGx3TUhP?= =?utf-8?B?S2E4d3BXRFRrRDNvWVpRNFNMbmV5VUJGamtVN0tKR0RLMC9tMzlpSGtZUXRQ?= =?utf-8?B?aGQraDF6MCtyQ0QzR3BuU3kwaUtrUFlxV3d5UzBYM3U3V1lGNU44KzVjV09B?= =?utf-8?B?Q1h5Wk9zZTVBZjYyTmdFdjh5b1RPcmJ3dlVlY01PN0dkRGdFMDN2ZUdpbFhu?= =?utf-8?B?clE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: j25bI4ygAPN5sLv0ml61VJXZDQ4rQbJUJBSjvvyvMcourPUnE9FMhqm31yc0ykS2eB9QDpRua/GWBCGc1vqW82L0gab9e7+vId8ATnLclC67sSDWe8xfVV70jhuwsDtDSxtvdsnhy9ip2wcmOllTp5W9Q4/ExYrwLIVLjcvkJJTUkCtP2bcTbwtKN8UP530U0PkMkjjw9+qCDqmI0VeuzMjvRjHxj4Lc81Wg6yESaGTMccmW2io2P0U/03pWBRgOK5qO3laAIRVLDFCXtMxPtdBBCM0y1FFx5tnNR0lKJx7iq6xGjcHUMiYuuPhz5GnDPzxv8fB/hrszFK1wF7wUymHAFN1UYwMkhI/q80MAqIk9aIQNn7gDaQrCyu6ATugtAJqBLd4RDXdp9H8dmfISDhvmtswtqjQkCy4XIhFONTIg6OXO5OcZF74a1xXcp6FpN88Nf2sFW1z9+ahxu3ITLUtp1mAQD3nfIQ3TfH/GMvpOrwf3+Dx3P4UijFo8dQsmWd4g53a4hUP8oObq+bpKyzqtCh+pY39LGsHAWNAHxU7Fms2wWzlky8vRFKhU3HYVNgnmZJ+HHcUoz+kLi6yinMffAM+ld4uDNcoK+DorueYt9af2Y9UTB2VH0Sy5jny7v7mmUWQatEnXjBZkiQK54RoDEAPL9s3RDrF1zN0S4BJrZ9xna4LyYPCGO1sIiDBFBu3KUVG0/UORa2DmlvqCU82H/uT20oUZ5TbP8MeNx0n0rAxCUK43dAryUOsGfClckOFZCLC+QWzqdDk6TGH6ad5VVnyt1fhAHZZ9U3115AHswrbApta2wATGsAGbTG5SNSD3x5OU83i3MOXpAwVnc0OLhObJpPfnE8x9NQWrhnM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 648169a4-31c3-4c88-91d2-08db18d1cb79 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 14:49:14.4968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TXJsVP6US8IdsHFVoLJqPjHw+smX/+iqFkt37YFyrZoIGH0zBqX+a7L67GWzGBqyF3g2TuVDi4TPUKSYGRG/Ac8Ioy7hHMBlxKY8DAHx3qo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6052 On 27/02/2023 2:42 pm, Juergen Gross wrote: > On 24.02.23 15:56, Andrew Cooper wrote: >> On 24/02/2023 1:36 pm, Edwin Török wrote: >>> From: Edwin Török >>> >>> Prior to bd7a29c3d0 'out' would've always been executed and memory >>> freed, but that commit changed it such that it returns early and leaks. >>> >>> Found using gcc 12.2.1 `-fanalyzer`: >>> ``` >>> xg_core_x86.c: In function ‘xc_core_arch_map_p2m_tree_rw’: >>> xg_core_x86.c:300:5: error: leak of ‘p2m_frame_list_list’ [CWE-401] >>> [-Werror=analyzer-malloc-leak] >>>    300 |     return p2m_frame_list; >>>        |     ^~~~~~ >>>    ‘xc_core_arch_map_p2m_writable’: events 1-2 >>>      | >>>      |  378 | xc_core_arch_map_p2m_writable(xc_interface *xch, >>> struct domain_info_context *dinfo, xc_dominfo_t *info, >>>      |      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>      |      | | >>>      |      | (1) entry to ‘xc_core_arch_map_p2m_writable’ >>>      |...... >>>      |  381 |     return xc_core_arch_map_p2m_rw(xch, dinfo, info, >>> live_shinfo, live_p2m, 1); >>>      |      |            >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>      |      |            | >>>      |      |            (2) calling ‘xc_core_arch_map_p2m_rw’ from >>> ‘xc_core_arch_map_p2m_writable’ >>>      | >>>      +--> ‘xc_core_arch_map_p2m_rw’: events 3-10 >>>             | >>>             |  319 | xc_core_arch_map_p2m_rw(xc_interface *xch, >>> struct domain_info_context *dinfo, xc_dominfo_t *info, >>>             |      | ^~~~~~~~~~~~~~~~~~~~~~~ >>>             |      | | >>>             |      | (3) entry to ‘xc_core_arch_map_p2m_rw’ >>>             |...... >>>             |  328 |     if ( xc_domain_nr_gpfns(xch, info->domid, >>> &dinfo->p2m_size) < 0 ) >>>             |      |        ~ >>>             |      |        | >>>             |      |        (4) following ‘false’ branch... >>>             |...... >>>             |  334 |     if ( dinfo->p2m_size < info->nr_pages  ) >>>             |      |     ~~ ~ >>>             |      |     |  | >>>             |      |     |  (6) following ‘false’ branch... >>>             |      |     (5) ...to here >>>             |...... >>>             |  340 |     p2m_cr3 = GET_FIELD(live_shinfo, >>> arch.p2m_cr3, dinfo->guest_width); >>>             |      |     ~~~~~~~ >>>             |      |     | >>>             |      |     (7) ...to here >>>             |  341 | >>>             |  342 |     p2m_frame_list = p2m_cr3 ? >>> xc_core_arch_map_p2m_list_rw(xch, dinfo, dom, live_shinfo, p2m_cr3) >>>             |      |                      >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>             |  343 |                              : >>> xc_core_arch_map_p2m_tree_rw(xch, dinfo, dom, live_shinfo); >>>             |      |                              >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>             |      |                              | | >>>             |      |                              | (9) ...to here >>>             |      |                              | (10) calling >>> ‘xc_core_arch_map_p2m_tree_rw’ from ‘xc_core_arch_map_p2m_rw’ >>>             |      |                              (8) following >>> ‘false’ branch... >>>             | >>>             +--> ‘xc_core_arch_map_p2m_tree_rw’: events 11-24 >>>                    | >>>                    |  228 | >>> xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct >>> domain_info_context *dinfo, >>>                    |      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>                    |      | | >>>                    |      | (11) entry to >>> ‘xc_core_arch_map_p2m_tree_rw’ >>>                    |...... >>>                    |  245 |     if ( !live_p2m_frame_list_list ) >>>                    |      |        ~ >>>                    |      |        | >>>                    |      |        (12) following ‘false’ branch >>> (when ‘live_p2m_frame_list_list’ is non-NULL)... >>>                    |...... >>>                    |  252 |     if ( !(p2m_frame_list_list = >>> malloc(PAGE_SIZE)) ) >>>                    |      |     ~~ ~                         >>> ~~~~~~~~~~~~~~~~~ >>>                    |      |     |  |                         | >>>                    |      |     |  |                         (14) >>> allocated here >>>                    |      |     |  (15) assuming >>> ‘p2m_frame_list_list’ is non-NULL >>>                    |      |     |  (16) following ‘false’ branch >>> (when ‘p2m_frame_list_list’ is non-NULL)... >>>                    |      |     (13) ...to here >>>                    |...... >>>                    |  257 |     memcpy(p2m_frame_list_list, >>> live_p2m_frame_list_list, PAGE_SIZE); >>>                    |      |     ~~~~~~ >>>                    |      |     | >>>                    |      |     (17) ...to here >>>                    |...... >>>                    |  266 |     else if ( dinfo->guest_width < >>> sizeof(unsigned long) ) >>>                    |      |             ~ >>>                    |      |             | >>>                    |      |             (18) following ‘false’ >>> branch... >>>                    |...... >>>                    |  270 |     live_p2m_frame_list = >>>                    |      |     ~~~~~~~~~~~~~~~~~~~ >>>                    |      |     | >>>                    |      |     (19) ...to here >>>                    |...... >>>                    |  275 |     if ( !live_p2m_frame_list ) >>>                    |      |        ~ >>>                    |      |        | >>>                    |      |        (20) following ‘false’ branch >>> (when ‘live_p2m_frame_list’ is non-NULL)... >>>                    |...... >>>                    |  282 |     if ( !(p2m_frame_list = >>> malloc(P2M_TOOLS_FL_SIZE)) ) >>>                    |      |     ~~ ~ >>>                    |      |     |  | >>>                    |      |     |  (22) following ‘false’ branch >>> (when ‘p2m_frame_list’ is non-NULL)... >>>                    |      |     (21) ...to here >>>                    |...... >>>                    |  287 |     memset(p2m_frame_list, 0, >>> P2M_TOOLS_FL_SIZE); >>>                    |      |     ~~~~~~ >>>                    |      |     | >>>                    |      |     (23) ...to here >>>                    |...... >>>                    |  300 |     return p2m_frame_list; >>>                    |      |     ~~~~~~ >>>                    |      |     | >>>                    |      |     (24) ‘p2m_frame_list_list’ leaks >>> here; was allocated at (14) >>>                    | >>> ``` >>> Fixes: bd7a29c3d0 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to >>> support linear p2m table") >>> >>> Signed-off-by: Edwin Török >>> --- >>>   tools/libs/guest/xg_core_x86.c | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/tools/libs/guest/xg_core_x86.c >>> b/tools/libs/guest/xg_core_x86.c >>> index 61106b98b8..69929879d7 100644 >>> --- a/tools/libs/guest/xg_core_x86.c >>> +++ b/tools/libs/guest/xg_core_x86.c >>> @@ -297,6 +297,8 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, >>> struct domain_info_context *dinf >>>         dinfo->p2m_frames = P2M_FL_ENTRIES; >>>   +    free(p2m_frame_list_list); >>> + >>>       return p2m_frame_list; >>>      out: >> >> I agree there are problems here, but I think they're larger still.  The >> live_p2m_frame_list_list and live_p2m_frame_list foreign mappings are >> leaked too on the success path. >> >> I think this is the necessary fix: > > Yes, I agree. > >> >> ~Andrew >> >> ----8<---- >> >> diff --git a/tools/libs/guest/xg_core_x86.c >> b/tools/libs/guest/xg_core_x86.c >> index 61106b98b877..c5e4542ccccc 100644 >> --- a/tools/libs/guest/xg_core_x86.c >> +++ b/tools/libs/guest/xg_core_x86.c >> @@ -229,11 +229,11 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, >> struct domain_info_context *dinf >>                                uint32_t dom, shared_info_any_t >> *live_shinfo) >>   { >>       /* Double and single indirect references to the live P2M table */ >> -    xen_pfn_t *live_p2m_frame_list_list; >> +    xen_pfn_t *live_p2m_frame_list_list = NULL; >>       xen_pfn_t *live_p2m_frame_list = NULL; >>       /* Copies of the above. */ >>       xen_pfn_t *p2m_frame_list_list = NULL; >> -    xen_pfn_t *p2m_frame_list; >> +    xen_pfn_t *p2m_frame_list = NULL; >>         int err; >>       int i; >> @@ -297,8 +297,6 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, >> struct domain_info_context *dinf >>         dinfo->p2m_frames = P2M_FL_ENTRIES; >>   -    return p2m_frame_list; >> - >>    out: >>       err = errno; >>   @@ -312,7 +310,7 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, >> struct domain_info_context *dinf >>         errno = err; >>   -    return NULL; >> +    return p2m_frame_list; >>   } >>     static int >> > > In case this fix is taken, my > > Reviewed-by: Juergen Gross > > can be added. Thanks.  I'll write a full patch and post it, with appropriate tags, and also include it in my commit sweep. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502679.774571 (Exim 4.92) (envelope-from ) id 1pWezC-0000Ut-RX; Mon, 27 Feb 2023 15:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502679.774571; Mon, 27 Feb 2023 15:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWezC-0000Um-Om; Mon, 27 Feb 2023 15:00:18 +0000 Received: by outflank-mailman (input) for mailman id 502679; Mon, 27 Feb 2023 15:00:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWezB-0000Ua-6F for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:00:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWezA-0002ok-Oe; Mon, 27 Feb 2023 15:00:16 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.16.186]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWezA-0000zL-Iu; Mon, 27 Feb 2023 15:00:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vuqz0qJecfZ5v27tzPKQ+H8bB3dJlRoHVMU7F/+nZXM=; b=g5UKFuwGbHLIt4e5N1v5hb4zve BlTS4FVxeMDDwH3i5aG8c2DIDuLLiNv36N3dS9PCRqyA6Qaq8eW4GFQA3p6YKtWJ4m5oo/AfCQ1HK Qw10v8Q6l9jAQiaLoG0C7T2SzOwkLSf1eJYGD+KfdV9sILtVQ8c5LEY4LlZ3DtTjaaW4=; Message-ID: <42827e14-8daa-66ed-328a-92940dc98a95@xen.org> Date: Mon, 27 Feb 2023 15:00:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET Content-Language: en-US To: Bertrand Marquis , Jens Wiklander Cc: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini References: <82e4e0c3ac1614822fddd90336c22e6fad5b485e.1677079672.git.jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 27/02/2023 14:48, Bertrand Marquis wrote: >> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: >> >> Adds support for the FF-A function FFA_ID_GET to return the ID of the >> calling client. >> >> Signed-off-by: Jens Wiklander >> --- >> xen/arch/arm/tee/ffa.c | 21 ++++++++++++++++++++- >> 1 file changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c >> index 8b0b80ce1ff5..463fd7730573 100644 >> --- a/xen/arch/arm/tee/ffa.c >> +++ b/xen/arch/arm/tee/ffa.c >> @@ -167,6 +167,12 @@ static bool ffa_get_version(uint32_t *vers) >> return true; >> } >> >> +static uint16_t get_vm_id(const struct domain *d) >> +{ >> + /* +1 since 0 is reserved for the hypervisor in FF-A */ >> + return d->domain_id + 1; >> +} >> + >> static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, >> register_t v2, register_t v3, register_t v4, register_t v5, >> register_t v6, register_t v7) >> @@ -181,6 +187,12 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, >> set_user_reg(regs, 7, v7); >> } >> >> +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, >> + uint32_t w3) >> +{ >> + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); >> +} >> + >> static void handle_version(struct cpu_user_regs *regs) >> { >> struct domain *d = current->domain; >> @@ -210,6 +222,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) >> case FFA_VERSION: >> handle_version(regs); >> return true; >> + case FFA_ID_GET: >> + set_regs_success(regs, get_vm_id(d), 0); >> + return true; >> >> default: >> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); >> @@ -221,7 +236,11 @@ static int ffa_domain_init(struct domain *d) >> { >> struct ffa_ctx *ctx; >> >> - if ( !ffa_version ) >> + /* >> + * We can't use that last possible domain ID or get_vm_id() would cause >> + * an overflow. >> + */ >> + if ( !ffa_version || d->domain_id == UINT16_MAX) >> return -ENODEV; > > In reality the overflow could only happen if this is called by the IDLE domain right now. > Anyway this could change and this is making the code more robust at no real cost. > > I would just suggest here to return a different error code like ERANGE for example to > prevent missing ENODEV with other cases not related to FFA not being available. +1. I would also like to suggest to use >= rather than == in case we decide to support more than 16-bit domid. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:00:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502680.774581 (Exim 4.92) (envelope-from ) id 1pWezM-0000lF-3s; Mon, 27 Feb 2023 15:00:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502680.774581; Mon, 27 Feb 2023 15:00:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWezM-0000l8-0g; Mon, 27 Feb 2023 15:00:28 +0000 Received: by outflank-mailman (input) for mailman id 502680; Mon, 27 Feb 2023 15:00:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWezK-0000kp-SZ for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:00:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7d00::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75d58f42-b6af-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:00:24 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9194.eurprd04.prod.outlook.com (2603:10a6:10:2f9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:00:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:00:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75d58f42-b6af-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRC5qHIioGtzUqXVRIwn2yvnb82hDVzM7S0siVnGz77pjCx69x1mXE7MmcVk2xI6avWjk9ZZHv4nzqi/oco8h7HahHS0c4WdqT1EXDhEdvL1bdpqvXKLDAPauAhgY2paR23X7LaHSSiWl9sHWR9XNCrRE9CXDl/qhSuxZXjnqIkO2CcfSdpklzOytecjOTZGvZ5JM1PDhDHqapXDJNFY3bh71JDqFbEd8+Ds2vb3sJ+7gKVLc6PRpaD8/BCchfu4lUy5bUBLqrAxyA95XcKN6TfV2VjuluLFDhCZ8UvW5h3oy6svvjD4kHV3e3yHq2mnBC6rZB08oF94LM7ZbhDbWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OszXZPctgpmr94+qLqKPiPURi8jAc9g+E/ezLbDIm4=; b=CsTLui51g3vEulYMhH0vdYdrbWvihGAZg+OEh5WeSUcpupdhdv0n0nIaTuV1uErZld7888JuVcuu45iwOT/Gn2Vd2ku8GnZzdnBFlxBkSSRSTMTQ3J0c7x4RwrnwFvznDKvrDl6CHYUo1Gx22Er4h3L+V4iDgqcBctLRZ6Jv041eAjPzWIwggs1JKx5VIg7Kn+All6AZqG3nN+/SgKyXVqofjwYbCCLg39N59RaELdX0lQmG4X70mur/Bzu14VSIeKobDt47ouJ4U/YM1hqGS7DFncLKSlunJQCNhakGA4yedEWvx57QOECxFGmmNOeQMC92m2y0AmKaXTCun3PiKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3OszXZPctgpmr94+qLqKPiPURi8jAc9g+E/ezLbDIm4=; b=l2K0lFI3yySyr+mFSTA4BnaS3E7awn8PdHWaIXc16AAC+aw85zyX4sHigpdzdi7xQYklj2D0fpx6WQeHpPYcibZjgFlunHJUR0c0Frgm+7MTV9SqcOrJZ79UPXwk2oUw+hb/ZU4KHyoxyK3+hLkjTH5BgfIK5Yuul4nI/4MMaIi20SCSjDl3RO2xPHpudwHHak9MIK3lNU6BxthRf5bTFv/zROYBCU7zxEt2/YFe8ZqYhgi3sYARF3jJA7P8WLjOdAMdvFAAv1LVdKT+rN0btK5E5vp02MounKBRyPk+4bs86By1mfpkTmCyVveMcSRVov0jSCcvUQJZKMyihyylBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> Date: Mon, 27 Feb 2023 16:00:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB9194:EE_ X-MS-Office365-Filtering-Correlation-Id: 56b89852-4104-4587-5001-08db18d358d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lxbsg4dmprx2mQTXHiYWrFIk42BLzIStmoOuSG2ZGzNzX8Z9AmR4yr49qr2ziUwmiEIC8kMx2rLSdVh3oRkd1e+Bj3krA9AJ3kl6KeIJRaU06TXBysokv67h85ip8CekJZovIjpns8pyJQmrhLwA9df+401js+LuJuurAwwTSZrl/znVvqq0QQ4bADKZKop6CDRmSywCQQJabnz5vbHYv8OP6Oahx/2daypWHmvSJIN9497ouzaGt5fGY6V8+GcYpljRZ5Sw/BQvwEoQB8/BTn48X70MrMTToXSNYLLEnHfSM+UQXmJa8UowWBHjwPKJWTKMpwoonToUTCYNH3wVsGn3NidYvz7rQ0UnowLvPN4i41iG22uISLDGEQl8ntSshcD4tGrCkDTyrqhj0iGQkURJMCayIICz7PJxY1eIyjuGVfgCB3fWuie+eiWxpIQDiMAafSbIjHgRcPiUH6/GYomUQb049gYGbLJ09azhEbZP2KUhDskXJ1IgeZgJumth9WRbMbSEDtoM4PIyqq5xGguyOvuVfYriIaoqveirUOXIGswFFfsvTjhkypVQ66jU7sby4B7DZpkkgPewEOry5UAquNLBPBGQClv3kPbwZoeGerLlQStAiFFRaz+kD9qmYPx5u43dQEY+5VGcV9ZfS84JFLdxyAdnItB5Rqua+fnfbV3OJ1JdIhRFAqupTG9YCSjTPh3YJndkiW+OOHotnVnrnnAh9OwF5zUkuk6zHGQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199018)(4326008)(41300700001)(66476007)(66556008)(66946007)(83380400001)(8676002)(6916009)(38100700002)(36756003)(2906002)(31696002)(86362001)(5660300002)(8936002)(2616005)(6486002)(478600001)(53546011)(6506007)(54906003)(186003)(6512007)(26005)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RC9CVDVJa3NGM0k5TStQUG5kRTJQakxPeWNJQ2ZoMEVrZlZnalE2VEUvRUw1?= =?utf-8?B?SXl5bm1YVlE5NTR3UHEzSkZYckRvM1JuM2RPdTdGMzRwVk0veEN0dnZ2VytK?= =?utf-8?B?Q2hmOW5PczIwYXdSVjJpWGVnSllPRVRrby9jOHQwM3duVFlock5sOXlpWGRk?= =?utf-8?B?R0VzNnkveFRqWnRkbHMwVTdmL2lkQ2dtNFVUK050eGxxVXZ0bW42emcyN1or?= =?utf-8?B?WmVPWFNYMFNjektZeHNtak5CYVBzWlphNHhSTUdUN1lYOU1vUEU3YWF5cEtH?= =?utf-8?B?blJmb2ZEbUlxc0FBRFg3eUVDT2UxR2hRYlA0VUl6MVl5Sk5OUlREVFFndS85?= =?utf-8?B?VTlROTRvY2k5bm1DcUZWWHpnSDdGT2FNTzBOMjEzSU54cnZhNGc1MnozOCtZ?= =?utf-8?B?MVhIelV4a2lpdGljNEhNbU5hdFJIZ0VuQUc2STlUZXo0K0k3TEQ4NjNmUWsx?= =?utf-8?B?UVdFWWpzSmJ5T1lWOUVTN1FVcnUzaFJ5SmNPZy9Yc2kyZXhPT3FMc2ovbmRJ?= =?utf-8?B?aTB5b1pTeHFiS0Jld1BzOGlFVHpueUNjaWZiTkxIZ3M1NUVZeXlkajJTMTZV?= =?utf-8?B?Vkc0cllNS05EdnhXQUJXWERmbkh2RndpL0FHTitHMkl0U1NiL2t5NTRZYUJL?= =?utf-8?B?dmpsc0tYbk1DaXVQdGYwS0tYemVoRUEvMi9OakpaYVFrWTM4dXRFVTdEMGlY?= =?utf-8?B?Nk4wTW9aSU1RQzBFbXpLcGJQREFHMDMxL0ZBajBrRjlYcWwzYUtTN0hWT05M?= =?utf-8?B?WGFNNzNHbUVSV2F6dmhrQlAwWi9IbUJZMG1XWStTL0lIdmNIYjQzQVE3cFFq?= =?utf-8?B?TEZhV21jZzJUdGhkRFZYQUY4TkhVVlJya3d4ak5lUENtOHR3ZHNId1ZHYkRF?= =?utf-8?B?T0Q1NXlhM0Q1K0tRNyt1VlRuc0l6NkM5ZmRpbVY3RktDbHF5WThHZlUxbzZp?= =?utf-8?B?Vk1URjJ0RmdWS1FYTzc5ZElZTkZucW5vejE1MGo3aHlHRVZzUlJreU5BTjRo?= =?utf-8?B?NUVmRExsOHFOVkNqa0w2QzYxNVljN2gydDNOYmRCcThSSGcyYjlwT21zcHZq?= =?utf-8?B?ek16b29PdE9Bd1VFNjd5WExKMk5OOTBnQmxFOGZLNUdGY0tXWkRzbmpacEdm?= =?utf-8?B?NHkreERMaEpQbktXVWdzdHY3V25UaW1ETnl1TlNwMWJUVEZkQWF0YmRaZ3c5?= =?utf-8?B?RFZ2K1liMEJDYURtejNpcjlpS3J3bjVkNmMrK0poR095bTN6SWRDS3g5NWZX?= =?utf-8?B?ZkpPOWlzM1BUVENwYVpVYjhrQWFmeDdPTDUrby9MRjQ4QVd1Um5ia0s4L1lw?= =?utf-8?B?ZVYvK0V2Ky9vT1JXRUNsbElIdDY0N2MwZkZpcXpkbnhPUjFyVUFid29zdGZv?= =?utf-8?B?RGpQWmlSblhlbkR0R1VxV1Q1cFJvdlVTb002MTIrRE5mc0EvcHRRUCtkUGlD?= =?utf-8?B?SVNDT2hLN3ROM2R0R00yR1JwaG5LNVprRUR2VEtjYVhheFRmSk40T3NPMFMv?= =?utf-8?B?UVRLSUt1ZitIY3hwcncyQjF0WXZMcUZ6SUZWUTcra25kWHZWNlpSOThHUlJ2?= =?utf-8?B?djAwZU1JZXNudHJsN2JibUszRk52QUFvaE9tNG1WQkRBdTA5OXlXc1BhcEJG?= =?utf-8?B?dVlyYWlFd3ZzYk1Kdis4cWlEazNQS0kxNTFxUzFUQ29qWFpSaHhNZ1lNZUlF?= =?utf-8?B?aC95OUk2b3ZmSnZ5TUxONlRzcUJrZFFRMmFWeFdoSmMvN1JObDNkMUZ0UUdC?= =?utf-8?B?QVNCeEsxR2s1T251cHB4OHA4S003ZnZvbXFhMnJnYmNBenFySS93cEV3YmM0?= =?utf-8?B?MGVPZEJ2UkdUNHhOMWtqNDZKSnFIT3NwSHNKMUlUN0dFNEsrUlRjbWRLN0N4?= =?utf-8?B?YmhqaVE1NHc0OG9zVWFNWFZFRE02S2VaRWNpczRLT24zbVgrdnBGcEJPOWRG?= =?utf-8?B?SjJCS29FQUI0Wk9MQVN0eGFWUmtnMXI4ZG9ZWHRLejR5Qk0yZW1yZVpjc05W?= =?utf-8?B?ai9sek9VcndCRmdKS2FzdjFqcGQ0OUkzbjB0cUFPSTR1bkk0aDU0YlJQdjlI?= =?utf-8?B?Wk9Cam1UOFptUlJJSFpvR0UxZ3NHQTF2VXdwTkhXalBoQ2d3dFZFQjlLc25W?= =?utf-8?Q?8F4zdKY8AcjQX+2rnIN4vdgJ2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56b89852-4104-4587-5001-08db18d358d9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:00:21.2891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sorgwzm0yPvzzIixwFuBUv8HXdPCgZGGet+JeNtRiL5wwreoYrFA20XnDf6BD2KBRuV51eFj4Mb0ldUT3ft4Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9194 On 27.02.2023 15:46, Michal Orzel wrote: > On 27/02/2023 14:54, Jan Beulich wrote: >> On 27.02.2023 14:41, Michal Orzel wrote: >>> On 27/02/2023 11:10, Jan Beulich wrote: >>>> On 27.02.2023 10:53, Michal Orzel wrote: >>>>> --- a/xen/Makefile >>>>> +++ b/xen/Makefile >>>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>> >>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>>> define all_sources >>>>> ( find include -type f -name '*.h' -print; \ >>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>> >>>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>>> also only be included when selected (or at the very least only when an >>>> arch might select it, which afaics is possible on x86 only right now). >>>> >>>> It would also help if in the description you made explicit that SUBDIRS >>>> isn't used for anything else (the name, after all, is pretty generic). >>>> Which actually points at an issue: I suppose the variable would actually >>>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>>> has caused crypto to be missing from SUBDIRS. >>>> >>> I think what you wrote can be split into 2 parts: the part being a goal of this patch >>> and the cleanup/improvements that would be beneficial but not related to this patch. >>> The second part involves more code and there are parts to be discussed: >>> >>> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >>> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >>> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >>> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >>> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >>> top of the Makefile (thus harder to make sure the linking order is correct). >>> >>> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >>> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >>> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >>> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >>> but for all the existing architectures. >> >> I understand that the changes would be more involved, but I disagree with >> your "two parts" statement: If what I've outlined was already the case, >> your patch would not even exist (because crypto/ would already be taken >> care of wherever needed). >> >>> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >>> into account for the tags/csope generation. Would the following change be ok for that purpose? >>> >>> diff --git a/xen/Makefile b/xen/Makefile >>> index 2d55bb9401f4..05bf301bd7ab 100644 >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>> >>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >>> + >>> define all_sources >>> ( find include -type f -name '*.h' -print; \ >>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >> >> The fact that, afaict, this won't do is related to the outline I gave. >> You've referred yourself to need-config. Most if not all of the goals >> SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. >> Hence your change above is effectively a no-op, because CONFIG_CRYPTO >> will simply be unset in the common case. Therefore if an easy change is >> wanted, the original version of it would be it. An intermediate >> approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. >> But neither would preclude the same issue from being introduced again, >> when a new subdir appears. > I understand your concerns. However, I cannot see how your suggested changes > e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. > They would reduce the repetitions (hence I called them cleanup/improvements) > but as we want to keep tags,cscope,clean as no-dot-config targets, I, for one, didn't take this is a goal (perhaps for clean, but there ... > we would still not be able to use: > SUBDIRS-$(CONFIG_CRYPTO) += crypto > and use it in all_sources (because as you pointed out, it will be a no-op). ... the problem is obvious to solve, as outlined before). > Also, why do we care so much about guarding crypto/ if we take into account > so many architecture/config dependent files for tags/cscope (e.g. in drivers, > lib/x86, etc.)? Good question, which I'm afraid I have to answer with asking back: > If these are no-dot-config targets, then we should take everything, apart > from really big directories like arch/ ones. Why is arch/ other than arch/$(TARGET_ARCH) to be ignored? And if it is, why would crypto, used by only x86, not be ignored? As always I'd prefer firm rules, not arbitrary and/or fuzzy boundaries. Furthermore, considering e.g. cscope: Personally I view it as actively wrong to constrain it to just one arch. That'll lead to mistakes as soon as you want to make any cross-arch or even tree-wide change. Hence it would probably want treating just like clean. I can't comment on the various tags (case-insensitive) goals, as I don't know what they're about. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:03:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:03:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502687.774591 (Exim 4.92) (envelope-from ) id 1pWf1z-0001bx-JA; Mon, 27 Feb 2023 15:03:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502687.774591; Mon, 27 Feb 2023 15:03:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWf1z-0001bq-GH; Mon, 27 Feb 2023 15:03:11 +0000 Received: by outflank-mailman (input) for mailman id 502687; Mon, 27 Feb 2023 15:03:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWf1x-0001bg-GO for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:03:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d5d33d67-b6af-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:03:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5d33d67-b6af-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677510186; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rrL3Wu2IJ8sfJxppcHVkKMnrvdeQ+P9GKvNTiTI6A64=; b=GY+1FOpjY35ERl016x4GnZbDjlUtn3sT5PJRqZbg76QSDIEV5XJs2aVP jquWzCn0/bloKehvP7baN1y6OfGN7ZnRMMH//7Ve1tiHkaJ/5c+9sJryY V1/rg5d0BCAQyGmHkozwMEnjaRvaNXWtJ+hKorAZJor/AlR4j3AqcU4YJ 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97521943 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:pFmJd63q1cTKnOnyD/bD5dBxkn2cJEfYwER7XKvMYLTBsI5bpzMFm GQbWWvSaP6DY2P2eo8gb97joBsCu8OAz9A3TFE+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gZkOqgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfIUtW0 fdENxw2UyuOoMG4zbGLW7NBv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFJoIxB/J+ jmuE2LRIw4WaoWH+xO/7WuLosDurXz8AJIyLejtnhJtqALKnTFCYPEMbnO5ruO+kVWWQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6k6nMsF2AbLoZ87YlvGGJsj wXS9z/0OdBxmJ2/UVaWqqi4lg6JNA82I2IBVT5eYDJQtrEPv7oPph7IS99iFou8gdv0BSz8z li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBd7fb1UwYnY1RfHNEghBHFbyFb28GBkkeC9U3j8sIFcFm nP7twJL/4N0N3C3d6JxaI/ZI510kve8Toq5CKCFMIQmjn1NmOivpnwGWKJt9zq1zBhEfV8XZ f93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcmT8vhT6pLHPCT9Ye5cYDOzghURsPvsTPP9r 4wOaKNnCnx3DIXDX8Ug2dJKdA1acCViWMGeRg4+XrfrHzeK0VoJU5f5qY7NsaQ4z/Q9ejvgl p1lZnJl9Q== IronPort-HdrOrdr: A9a23:8Rz1+6lY7d91x4LZcLpVGhsTWV3pDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="97521943" From: Andrew Cooper To: Xen-devel CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Juergen Gross Subject: [PATCH] libs/guest: Fix resource leaks in xc_core_arch_map_p2m_tree_rw() Date: Mon, 27 Feb 2023 15:00:57 +0000 Message-ID: <20230227150057.2858898-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Edwin, with the help of GCC's -fanalyzer, identified that p2m_frame_list_list gets leaked. What fanalyzer can't see is that the live_p2m_frame_list_list and live_p2m_frame_list foreign mappings are leaked too. Rework the logic so the out path is executed unconditionally, which cleans up all the intermediate allocations/mappings appropriately. Fixes: bd7a29c3d0b9 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") Reported-by: Edwin Török Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross --- tools/libs/guest/xg_core_x86.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/libs/guest/xg_core_x86.c b/tools/libs/guest/xg_core_x86.c index 61106b98b877..c5e4542ccccc 100644 --- a/tools/libs/guest/xg_core_x86.c +++ b/tools/libs/guest/xg_core_x86.c @@ -229,11 +229,11 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf uint32_t dom, shared_info_any_t *live_shinfo) { /* Double and single indirect references to the live P2M table */ - xen_pfn_t *live_p2m_frame_list_list; + xen_pfn_t *live_p2m_frame_list_list = NULL; xen_pfn_t *live_p2m_frame_list = NULL; /* Copies of the above. */ xen_pfn_t *p2m_frame_list_list = NULL; - xen_pfn_t *p2m_frame_list; + xen_pfn_t *p2m_frame_list = NULL; int err; int i; @@ -297,8 +297,6 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf dinfo->p2m_frames = P2M_FL_ENTRIES; - return p2m_frame_list; - out: err = errno; @@ -312,7 +310,7 @@ xc_core_arch_map_p2m_tree_rw(xc_interface *xch, struct domain_info_context *dinf errno = err; - return NULL; + return p2m_frame_list; } static int -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:12:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:12:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502699.774601 (Exim 4.92) (envelope-from ) id 1pWfB8-0003RP-Ee; Mon, 27 Feb 2023 15:12:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502699.774601; Mon, 27 Feb 2023 15:12:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfB8-0003RI-Bw; Mon, 27 Feb 2023 15:12:38 +0000 Received: by outflank-mailman (input) for mailman id 502699; Mon, 27 Feb 2023 15:12:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfB7-0003RC-Al for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:12:37 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2074.outbound.protection.outlook.com [40.107.7.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a54d616-b6b1-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:12:35 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7033.eurprd04.prod.outlook.com (2603:10a6:10:125::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.28; Mon, 27 Feb 2023 15:12:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a54d616-b6b1-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gzXTup+AiO2r3seL0Sj6MPcr9JKeFEo+XHKYmqAcfYSU2DtrYI9tIcYRVrYMffyjsD3zL7F70KxmKI1/9IrppqRC7ZrCt/P10c27jZ+H2CGMwc2E3Zh+tc9RkPndMr3IrMEo91WFPhwCTHjCzKDTKYqoDdhCytWeVauPbz0LfgT8wlolnGo7ZLr9vLE1jjGLYmkfwivJ1t97FtXZG5y7TUrB0JNebgOutTDCDc6rfhoei95vZPEfqL6uCp0p/23PpK7AF1WSFBsKBRPejxLQoWpWN2QTI9LowUDI/li6pRsI9iM/NOfU7Jqg1pyrEvLvUTacigesafb+0HxXyDPtoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=thipQ+7g6tRxAePPGRBmtb4i0eicBgj4YL/e3xZ826o=; b=WgFDNe0l1pOvR7JLU4wBXv8Vw51RpVwMckZZ3nHcIxpfTFiaSXm9RzOpshzy/k6CHMyFqwN4qoqPOnGTWWelGR8Wiv5mganQZ67aS6vRAwmNY8LCs8TLYWWD1zp5kC6ghvSRKm4UV+IvUnd5tCieG6Rsgq0C9Qxbdp16m4pPY2Bo3Mb1AkNjiMt+HelxGJ3xhow9WuqDwbXiTrNdNOPHzpu26XEJfRoodyXk1yXWnmxouDUAl7xuYfjuoOXWrBJnLv+bCL1lv9Myydhnb39d1vBUxD1YLeLRRrqfKXRGCCWlK78nyRW+sH5Ml7p4Z04EtsN/+HGRS04O9aPZTt38HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=thipQ+7g6tRxAePPGRBmtb4i0eicBgj4YL/e3xZ826o=; b=bvU7ZTiYjlsBBrhSCE1qiGK3AFjo8/VBTcAVnqUZvI42deTrb0D8/6v6CSH1M0h36YL1b8nUv6MhVq3otnRQ8we7N/XHBI/qmpCulpXBvSDs0AvmuV/Y3cjISoU/2ek/6YBhUVTkPFiDjbSHdyU7YObJJx0i4WAJBhUItyKxuLiMj4ER9jIQG+cAeL/ZGFcoc3BjAEQNzNSNutu7tX3B3t3TtIOjEOwUMu2uhIY6OCfXfK0hY5bVfzHCt6x/5CXENXw/TxIlAUrYUBY1f0b2vS2Ngm9fbaI6J/l3u1OqRWilWhLsCfN5vih29kVtHd8UwG2k+EpzSrneEpnQAJpmKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 16:12:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7033:EE_ X-MS-Office365-Filtering-Correlation-Id: 3eb505af-308f-4776-5353-08db18d4fccd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J3QgeegCp+8F1soHV5DSTSYroMBVNa4gg6y8+wj8A3J5YFGaSyxCVaxbn31pjGy5DLn0q4sNtdCwp2ztddKsC4WSJxJ2hVGZC9Bvii490d0R0diedWN2RWYax7YDt+fmDhLqzQGJJrOyuG8iI00hQJ/TR4ij2719K3VfoW7HQqEcGdfqy08YigtM5Lr3+zMcekYdMTdWa6j9Eqw0zn64TL9xzxQPanKeGuN6///Cxv0A9MULO4F/w6g5Z8RnuKY6us/JnbSOdUcQLviU28WtcN1Mn5qEatoq2SE1qNEJRGBbeLjkq6VBqAoJ5EiYhsALlsp40kjn/8n1pVgVakE9Z3bUnz2xIKy698paeXFlhA3zkqJ3QaohE/fjpjRdRVBYM/9ln8HZBnHgY11teggKDg+odh7CI7Gk/eETVDpznkwwb72unakFYOXPJSuEHe4KnEqZgGM7Lh1BI5PW69sObhuMYiLqUdYpQ/7INe/LHp96vowU0712hhufm+AgBn4HAENt108eU5QYjI/rf4wl3wy003C93CBTWXiGHfiunbFmF7T+2fT15aRYott7fv2iT8DLRIguZ2AfLsQt5JPKljxR+t/qTKch3lpnteA6oaQ58U0G3Hg2u0vbykip7P2cRPM6xrye0MM4X+Us22Otm4E6YMOGdc5G3jV0aPYAjf+dpksH3MbVThWIDMJDXqch2EUr2Rjjdw9kpSiFrpm9Wyeo3s4jHSsPK8pX+lpYqsM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(39860400002)(346002)(376002)(451199018)(36756003)(8936002)(5660300002)(66476007)(6506007)(53546011)(6512007)(38100700002)(26005)(83380400001)(186003)(2616005)(86362001)(31696002)(41300700001)(54906003)(66946007)(316002)(4326008)(66556008)(6916009)(8676002)(6486002)(478600001)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm0yazVzekJ4ejhicGxkTkk3YlUvM29LVm1UbG1MUHJScnlmMGdzWmRJZE9G?= =?utf-8?B?QmdnZXI1Ui9UT0I3RVFOeHVSRVdmeW9pdUFuUlVER0tXOVhiZVdWY0h3SGVZ?= =?utf-8?B?OGVaUzlXYk9iaGpUMkR5aU9EOTFrNWE3V2gycWdNVDdhUU5LK0hadk9uNHBq?= =?utf-8?B?V3JUdW92NjQ1N2oycHBoNlE0eHVNK2JwSUh5dU5LYmxVWkprSERIYVNlbXhw?= =?utf-8?B?NGRVR1FxZG1ZbXdGR2h1VDA4Nmd6dHVPZDdjZDRHZENWVGJQWk9RYXZCWWY3?= =?utf-8?B?bE50SGVUOGJObGxmTldrYVd4MVdvSlNORVZmOXQrNVBRMW5iR01KaVkweTQ2?= =?utf-8?B?Z2lFMktxOVRWOWhTSjkxYmNIa0xuTzg4QTV1M0t1N2ZXZUdMbEd4WFVLbGVz?= =?utf-8?B?VEhIdCs2SGJodmFtdjJIS0tmaVhtRmxJNkg2alh4azBGOHNJcVRJNS9DMXR2?= =?utf-8?B?c0hlampnV0pLRHZhT1pocnhUOEl1VmVuUFQ4RTJjQm1Qd25iVWh6WmNXZjU5?= =?utf-8?B?VStGY1FleEt5a3FOaiszdENDWERUV1ZsbkFyRE9LdUNLVi9wMTB6RjFrMmFO?= =?utf-8?B?dnJnZnhGS2YrZzd2YW53SGN3cFc0TkpZUHZQN2crWWVlYWlrcnprdjJDMlRp?= =?utf-8?B?QU9uVFZCWmpmVHB3WWxuZTcwRkxJN0JkdEpZSGdNVzhqTHU3eHdBWkEzSysx?= =?utf-8?B?bmdMZW9CQXR6ekp3U2ZTN0tXRHNZUWZKZ1hRREd5VVFqbnNlMHVyb3Ztclh2?= =?utf-8?B?RnkxNHh6U01GbnNHK1FqWm4vVlcrZGhTQUQxNC9RQjVINFNnbjViNis5VFRh?= =?utf-8?B?UEd0akw5Vno5ZGFVRlF1ZjA0RWZHTFBxdWNiTU1FSW1rVEMyeVB2MGhDUlcv?= =?utf-8?B?cjBpQ1FzRGNmY3YrVDFTMWFQVGE1YjlaeHQyYUliK0U3VjFUZ2w2aW9KTmRm?= =?utf-8?B?SjJtSFN6T0d6UXRTVzV6cmZIRkdVbTYrQmVXN2h6VENDQVQ4a1BUVjVORUNl?= =?utf-8?B?T3NmWThhVkRTNUpoNk5SeWlKeDg4SHh5UnBocGZTUUJLQmFyZVBnVFlOclht?= =?utf-8?B?S0MxbzFVNllZSnROVTYrczZIOE5PZ2U0ZklOajdVa21ISXNzNzdRQmJJLzZ5?= =?utf-8?B?cFpYRUg3YzhxblVmQVVYR3dNUnNzZXVFL01jaktISFRuaGRmM3hUcVByR1d2?= =?utf-8?B?Wk82STNzeFFuOVFqaitJL3pUR1VoeUhVNHVVWGhKWUc4WUJXK21vQVFPWTBt?= =?utf-8?B?WjlkM2UwTEMrMXh5U2N1dHBJZ3lYRkErSU9PTHhjV0NKaEp1bXVpSHZEdnd0?= =?utf-8?B?NFpIa3lBbmlGejgxLzNRdWYwczVpTXhuQTRHVUlma1Z1OFFmVUFTNHpYK0JG?= =?utf-8?B?ck5CQzcrQ05BVzlVUzhhejhOcG1SUDJxaDE5QldUV0FOQVhldTBUcCswYjhR?= =?utf-8?B?VzJwdXJYSS9KREZBdzZNUjZLOWloS0ZTWnhkWkNwaGppUldJU3B0VE9CVTlS?= =?utf-8?B?OXRuZzNiS0hFL0RNRndhMkxOVjVOYWhSTHpqckJ4WGR1czBLMUdrcDZNWXdB?= =?utf-8?B?RzJVbC9YT0wreVNOaU9JbkhGZlg2L0YxOHZwZmJJeWsvemxobCttRHdCQ3hG?= =?utf-8?B?dmxkRUNEbVNTRHJGc3BZSW5ycDRSNVpqYlpPQUlsbWN4SDFPK3M3QTFxY2U5?= =?utf-8?B?eVdZTllRd1NWS0RiUTRaMVppdDltWElpVmsrMng2QnRTU2NGYmRlSmZSS2lV?= =?utf-8?B?WWVxUkd5S3hhTWdCNHFpa0x4VGhpUmdGYnQ5bW9uTGdpQnBtTGxpVHlidG81?= =?utf-8?B?QlJaTkkyb1N0N0FFWUtyYitmM2pQU09PTno5RWdlaTBJY1JLRHc3L1R3dnlh?= =?utf-8?B?U293Rzg1SE1YMW1PUVJpWE1COGtBRHQ0ei9xU2Q2VXF2Y2k4bGQwZUMzQ3NO?= =?utf-8?B?c2hMTHc0QUI4Z0l0emZGUkZEZ2hNT2dBN2k0VWNrYU53Mk1MYUEzdEthenda?= =?utf-8?B?azN0V1l1WHZGeExOQU9OS013TkJlVkFMNlNIdjBoWm5tc2dhSmdZNnZLMlBT?= =?utf-8?B?Q1NPbXhvNGhzZ1N6N0ZERTdSU2l4VU1rbE1WSFp6Y1ZDMU1TUDkyYk1ReVcv?= =?utf-8?Q?GHTWtgSZbt2S5gKYe/L/WLZEr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb505af-308f-4776-5353-08db18d4fccd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:12:05.8692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6XHINMP3T8QIoQ0A6C8v7mpg9u13qZfenHLXWQmtUHxSInHgS7zLwjvuoltW+rJH97RLas/T23Xl8OI95Y4FAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7033 On 24.02.2023 16:06, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/page.h > @@ -0,0 +1,90 @@ > +#ifndef _ASM_RISCV_PAGE_H > +#define _ASM_RISCV_PAGE_H > + > +#include > +#include > + > +#define PAGE_ENTRIES 512 > +#define VPN_BITS (9) > +#define VPN_MASK ((unsigned long)((1 << VPN_BITS) - 1)) > + > +#ifdef CONFIG_RISCV_64 > +/* L3 index Bit[47:39] */ > +#define THIRD_SHIFT (39) > +#define THIRD_MASK (VPN_MASK << THIRD_SHIFT) > +/* L2 index Bit[38:30] */ > +#define SECOND_SHIFT (30) > +#define SECOND_MASK (VPN_MASK << SECOND_SHIFT) > +/* L1 index Bit[29:21] */ > +#define FIRST_SHIFT (21) > +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) > +/* L0 index Bit[20:12] */ > +#define ZEROETH_SHIFT (12) > +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) > + > +#else // CONFIG_RISCV_32 > + > +/* L1 index Bit[31:22] */ > +#define FIRST_SHIFT (22) > +#define FIRST_MASK (VPN_MASK << FIRST_SHIFT) > + > +/* L0 index Bit[21:12] */ > +#define ZEROETH_SHIFT (12) > +#define ZEROETH_MASK (VPN_MASK << ZEROETH_SHIFT) > +#endif > + > +#define THIRD_SIZE (1 << THIRD_SHIFT) > +#define THIRD_MAP_MASK (~(THIRD_SIZE - 1)) > +#define SECOND_SIZE (1 << SECOND_SHIFT) > +#define SECOND_MAP_MASK (~(SECOND_SIZE - 1)) > +#define FIRST_SIZE (1 << FIRST_SHIFT) > +#define FIRST_MAP_MASK (~(FIRST_SIZE - 1)) > +#define ZEROETH_SIZE (1 << ZEROETH_SHIFT) > +#define ZEROETH_MAP_MASK (~(ZEROETH_SIZE - 1)) > + > +#define PTE_SHIFT 10 > + > +#define PTE_VALID BIT(0, UL) > +#define PTE_READABLE BIT(1, UL) > +#define PTE_WRITABLE BIT(2, UL) > +#define PTE_EXECUTABLE BIT(3, UL) > +#define PTE_USER BIT(4, UL) > +#define PTE_GLOBAL BIT(5, UL) > +#define PTE_ACCESSED BIT(6, UL) > +#define PTE_DIRTY BIT(7, UL) > +#define PTE_RSW (BIT(8, UL) | BIT(9, UL)) > + > +#define PTE_LEAF_DEFAULT (PTE_VALID | PTE_READABLE | PTE_WRITABLE | PTE_EXECUTABLE) > +#define PTE_TABLE (PTE_VALID) > + > +/* Calculate the offsets into the pagetables for a given VA */ > +#define zeroeth_linear_offset(va) ((va) >> ZEROETH_SHIFT) > +#define first_linear_offset(va) ((va) >> FIRST_SHIFT) > +#define second_linear_offset(va) ((va) >> SECOND_SHIFT) > +#define third_linear_offset(va) ((va) >> THIRD_SHIFT) > + > +#define pagetable_zeroeth_index(va) zeroeth_linear_offset((va) & ZEROETH_MASK) > +#define pagetable_first_index(va) first_linear_offset((va) & FIRST_MASK) > +#define pagetable_second_index(va) second_linear_offset((va) & SECOND_MASK) > +#define pagetable_third_index(va) third_linear_offset((va) & THIRD_MASK) > + > +/* Page Table entry */ > +typedef struct { > + uint64_t pte; > +} pte_t; > + > +/* Shift the VPN[x] or PPN[x] fields of a virtual or physical address > + * to become the shifted PPN[x] fields of a page table entry */ > +#define addr_to_ppn(x) (((x) >> PAGE_SHIFT) << PTE_SHIFT) > + > +static inline pte_t paddr_to_pte(unsigned long paddr) > +{ > + return (pte_t) { .pte = addr_to_ppn(paddr) }; > +} > + > +static inline bool pte_is_valid(pte_t *p) Btw - const whenever possible please, especially in such basic helpers. > --- /dev/null > +++ b/xen/arch/riscv/mm.c > @@ -0,0 +1,223 @@ > +#include > +#include > + > +#include > +#include > +#include > + > +/* > + * xen_second_pagetable is indexed with the VPN[2] page table entry field > + * xen_first_pagetable is accessed from the VPN[1] page table entry field > + * xen_zeroeth_pagetable is accessed from the VPN[0] page table entry field > + */ > +pte_t xen_second_pagetable[PAGE_ENTRIES] __attribute__((__aligned__(PAGE_SIZE))); static? > +static pte_t xen_first_pagetable[PAGE_ENTRIES] > + __attribute__((__aligned__(PAGE_SIZE))); > +static pte_t xen_zeroeth_pagetable[PAGE_ENTRIES] > + __attribute__((__aligned__(PAGE_SIZE))); Please use __aligned() instead of open-coding it. You also may want to specifiy the section here explicitly, as .bss.page_aligned (as we do elsewhere). > +extern unsigned long _stext; > +extern unsigned long _etext; > +extern unsigned long __init_begin; > +extern unsigned long __init_end; > +extern unsigned long _srodata; > +extern unsigned long _erodata; Please use kernel.h and drop then colliding declarations. For what's left please use array types, as suggested elsewhere already. > +paddr_t phys_offset; > + > +#define resolve_early_addr(x) \ > + ({ \ > + unsigned long * __##x; \ > + if ( load_addr_start <= x && x < load_addr_end ) \ Nit: Mismatched indentation. > + __##x = (unsigned long *)x; \ > + else \ > + __##x = (unsigned long *)(x + load_addr_start - linker_addr_start); \ > + __##x; \ > + }) > + > +static void __init clear_pagetables(unsigned long load_addr_start, > + unsigned long load_addr_end, > + unsigned long linker_addr_start, > + unsigned long linker_addr_end) Nit (style): Indentation. > +{ > + unsigned long *p; > + unsigned long page; > + unsigned long i; > + > + page = (unsigned long)&xen_second_pagetable[0]; > + > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_second_pagetable); i++ ) > + { > + p[i] = 0ULL; > + } We typically omit braces around single-statement bodies. Here, though: Why do you do this in the first place? These static arrays all start out zero-initialized anyway (from when you clear .bss). Plus even if they didn't - why not memset()? > + page = (unsigned long)&xen_first_pagetable[0]; > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_first_pagetable); i++ ) > + { > + p[i] = 0ULL; > + } > + > + page = (unsigned long)&xen_zeroeth_pagetable[0]; > + p = resolve_early_addr(page); > + for ( i = 0; i < ARRAY_SIZE(xen_zeroeth_pagetable); i++ ) > + { > + p[i] = 0ULL; > + } > +} > + > +/* > + * WARNING: load_addr() and linker_addr() are to be called only when the MMU is > + * disabled and only when executed by the primary CPU. They cannot refer to > + * any global variable or functions. > + */ > + > +/* > + * Convert an addressed layed out at link time to the address where it was loaded > + * by the bootloader. > + */ > +#define load_addr(linker_address) \ > + ({ \ > + unsigned long __linker_address = (unsigned long)(linker_address); \ > + if ( linker_addr_start <= __linker_address && \ > + __linker_address < linker_addr_end ) \ > + { \ > + __linker_address = \ > + __linker_address - linker_addr_start + load_addr_start; \ > + } \ > + __linker_address; \ > + }) > + > +/* Convert boot-time Xen address from where it was loaded by the boot loader to the address it was layed out > + * at link-time. > + */ > +#define linker_addr(load_address) \ > + ({ \ > + unsigned long __load_address = (unsigned long)(load_address); \ > + if ( load_addr_start <= __load_address && \ > + __load_address < load_addr_end ) \ > + { \ > + __load_address = \ > + __load_address - load_addr_start + linker_addr_start; \ > + } \ > + __load_address; \ > + }) > + > +static void __attribute__((section(".entry"))) > +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t *zeroeth, Why the special section (also again further down)? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:18:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502705.774612 (Exim 4.92) (envelope-from ) id 1pWfGL-00047J-5R; Mon, 27 Feb 2023 15:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502705.774612; Mon, 27 Feb 2023 15:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfGL-00047C-1r; Mon, 27 Feb 2023 15:18:01 +0000 Received: by outflank-mailman (input) for mailman id 502705; Mon, 27 Feb 2023 15:18:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfGK-000476-8l for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:18:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0609.outbound.protection.outlook.com [2a01:111:f400:fe1f::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea76a294-b6b1-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:17:58 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7366.eurprd04.prod.outlook.com (2603:10a6:10:1a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 15:17:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:17:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea76a294-b6b1-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bmK5I2NYSBs8OrQU33MZT0AArXPRagj2VmdMsMEVgL5r42UeFYAStIJ3UOU22/YOi2AIr8Q6D/z1NGQ/naSfT3BMwGkdtMA93p9l+JnS98bNiAOG8dVReAW3j2IHKZQlUH3t43ZATCB1fPNIv7PyUKWzCdCfmMQVBxCCAnYpVMFQtkHXpXt5yhdiz6tHk3NW+GcpzFUJ3dom/0IMfX6ZFrtiFbneBJiw1ntQY6ZrMEl/O9+3C6yl9d/58JGWuVMpCzUXEMSl7JoOvkryeYxCUaEX7NorLcdWNhaHS3RIKE+O38ELVFu4vIp0wv/khLRlX7ztMcuXFQdCLTKmmKJCuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59Fgne/iInyIhaI5N3irYGC1XaNEqmK7l8NM5DvEm3E=; b=VTNEvFI7YJCWKTHJn7uZ1VgGsTUEDUrPYMZXw50KZPRAQiiZvYMrJx1UMcCySVGYBmWbiACRT1RYA6FdukZoV7vBWsPgkRThTREbez1L37QEpeNdbxJIA+hBlRxid7FsEp6aIZCFg2eqvRruPMgHvseSmKcadhiWd1vGhKzc3Be1ZP2FnVESAN5AsOgmjWHTr44onbUp2ZL/xThIdKFcwHZCs1Hjcs4ih67t5X7mF+a/QszK5axeTM0TfIiUEm/iHOxeW8r7kNGjKvvAWoZ7jZKCtnJ8zEPvs2VtJAlyZHMCJe0u7iMR90iA8dAbeQznu0ER9YwRGPbWZMN3vJBe0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=59Fgne/iInyIhaI5N3irYGC1XaNEqmK7l8NM5DvEm3E=; b=KH56M5TI5Yj7jfRQ+k35YmPcTp9sd/blRyQ+l6QuxGSb3SwjwQ1QXvBb1WdPapih41+NavaHUadtbDoKPmWTUII1qYT2qxqmgP1ghC5Mf9MYQwYTR1UaUJQh5QN2G1M2RwJkxMX6KsFhm1UTOmSrP9Kc4POpDHRiHhtIpRpnfVHAqro5xYWxRG+Nzk1vju4BTyi8OdI0+6hB6rIqxmVgMCrZMjbtu+85d7HqkDJ9xSsP5hmPiv8ZGDP1jdiOhRvGWWe1hsBQBuwgbepL09yfKiIvwuhA7HJBV71+ZJiOWP+RbVcj48/MCJf9EOCNishsuXDPijyy9DsRYDhtHpnazQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 16:17:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko , xen-devel@lists.xenproject.org References: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> From: Jan Beulich In-Reply-To: <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7366:EE_ X-MS-Office365-Filtering-Correlation-Id: 64a8cd3a-f27b-41dd-af7b-08db18d5ccf7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VzZ1z6MdrOZ6WAKh4oePjDb28YQkz63xLMibaiG8DumvU28f/dlpGCpCjBYK7GYZ+6Le8JP7JxHBMlHGspGjOBUrtjDNjh8bmHC6RrErHyaayGASxSmy58XhUYHtPVHrCBm1G2bCnlcCVLpss0YLLETk18nJTrnln/pDztd1/KdW/w2kEXG8le1M7a53Yr6c1CwZT906betIqNJZiu9xBs9wHEnGWOxATMqLRWjmKgA/KfcK1P+tfuhwvjlVnVq9sOEjioMIQu4h9TwvpRA4O10UvT0UKTV/oFklP5zxUwgtwrO2ORunHCod5lNPzaerZIKrJTMzOw7HS13cR1rGp5Yz2TYTl3MvUJmhRyNmbeg2mkohQr0REx47wlGifvVRh3BmJuAQqH748cWbIYqrZIc+sxpjLJh3Rz2kpbwiTkxODf7z5l7R5f9i4Q+BUXqf1MgB/uIIop4EDyQ/fIHXMZFKHLZsO0XVArDWMziD/sLFGGpi8r8ifra9I4sLuN0WVQFFkdVX82aGiIvILhEAKzS8HXbvpjpyrFJRESrjFPS/zJX9KuOv5eeKKrVTfU62gzha8XzwLQJC3GyiHEiivfTROKNKQGSji9XL37a24AU1eylqpGjjm7xAJQ8/MX05Dro0Z2S2jFv59cxL27lpX+byMIBvy5BNrZl/TpYHAAZqwVgzRmdUMqqLxQ8q7z2BHoumFyABR+rPb7SDy5GLJUWN93qf1PESfSMwjhfJTgw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(396003)(39850400004)(346002)(366004)(451199018)(8936002)(54906003)(6512007)(36756003)(8676002)(316002)(4744005)(53546011)(186003)(26005)(478600001)(31696002)(86362001)(6486002)(6506007)(2616005)(38100700002)(5660300002)(2906002)(4326008)(66556008)(66946007)(66476007)(6916009)(31686004)(83380400001)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0FlbEliaFowSkw5em80SVF5V2Z0cmRSL3kxaUNVcUFLaVY2YmhkZVNrRits?= =?utf-8?B?UDRLNkkrYUFMU29FbWpvM2trRXBUaGd5MnMvWWdlZzNXZWJFWmVnODhiYTNP?= =?utf-8?B?OEpUY2gwbWlqVlgzcFZTNDhYQXVDaTVGVjJsa0U4UDdibzZUS0RnZ1M4WXUr?= =?utf-8?B?Q1hnMzQxVndsRWdZMGlZTURRaHlEWFlQNWtXTStiMCtZZjBJNkJlZmhSSXFz?= =?utf-8?B?a2RHZ0RlYnl4c3JuMUhObS9ORDBtQ216b2ZFMllVYm5jSStlS09hTDBGNUJq?= =?utf-8?B?bXNjTDZad096TnpHQzk2OHdEZ1psL1FhNVc0Q05aMzY3NndPajE2SkR5dk1M?= =?utf-8?B?N0pNaUdSWnU3YVgycVlucHhLaXFaR1Qzc0JEaCtUSzBlbnFxVGZDYUU2K3pP?= =?utf-8?B?K0dtU0txU0U2ZUpZSUNMMlBPQjN1L1JzNi9zRHRMbnk2QjV0Q2czV0tQN1Uz?= =?utf-8?B?eHdrSWFZSHNsTVVmWm1IanY0MUljQkl5czFYZUphZG40L29jYnlSdWZjakRX?= =?utf-8?B?d2xueXZ0UENldGVMZndZdVI5VWZOc1dTa3JoT2hobTlmV0F4ZUt5RldSUlc5?= =?utf-8?B?elFiUUtRNnhTUmZxNTUxaWtqU0xQUUp4cmV4Z3dZLzFsVG9KNjJyM2grVzkw?= =?utf-8?B?T0V3bW9JdFVWRXlFVE9XWkU0dEFNbzRaUDhVREVObjh3bVFQeUErOE0rc0V5?= =?utf-8?B?cmE4dExHc3g5ek5pRU1uTEpYQ2xZOER5dEtxLzFhdWVJVkgyVmtFQnJjTVhq?= =?utf-8?B?UFNkcXBUc2E1M3BiamZ6c3pGdFdqUGxWWDdIbWZ2dGpVSS9udkw5UllqNmc2?= =?utf-8?B?dHhPYklGeG9OZjFzcWkxWHdmc2ZsTjRVTEpET1BwVkEwN0djRVpHNS85eEI1?= =?utf-8?B?UDhsdnhEQW5pZzV4TzZaRGdFaDZYOTV3MnVTenJGb0dnbDFoRHFCNmFaYUJF?= =?utf-8?B?cmNlRE9DR0NQeDl0Rk1DamNvSHRJY2o2aXhZWFhCeTJWRHFMak8va0laNmhY?= =?utf-8?B?M2IzUUk2czlmWEpvUGJuWkFtWllJMk5aM1lzemxrVUNzZUVFWiswN3lGOGFN?= =?utf-8?B?WWZKTGZSbmdtanNuOGxURVFhYjM4aWdPTVRvczBhUC9EZXQ0Y1BDekFhWVZz?= =?utf-8?B?UFhjMmJoNzA1TFF4dUFCSzZjOXhIQ3RnRGtDYXhETFVUR1Q0ZFYya25odlo0?= =?utf-8?B?cFY3Z3RQUFF6R1JOQTRsYnAvUDRBTWZRYVkxbUFaOEV6Zytpdjg4TWdZVTNT?= =?utf-8?B?ZHVtc3JLZXdPY05WQUw3TDlaSWUyQ1dvT095T1I1cGFSQVpMOUJPVjlMTU5N?= =?utf-8?B?ME5qUUNMbXB4WDVNR3ZJcXdIanYzMUdsNmNZT0lpK3A1SmJWc2JENUt4bDVj?= =?utf-8?B?QlF3ZmRtRHNXVDNaNCtGRDFlMGxTUTJrZkZsNTRJL3JKTHQrTkludFgxaytD?= =?utf-8?B?RHhCeWxJZFpuYnIvcG9YVkRYNWZiZHgvdFlBWndCeXNsMTYvdUtMdExTb3BO?= =?utf-8?B?a2MxWC9XRGNSck1LSHlXTmNIWXZkMWtSRy9iTEFCQksweFM3dGE1cW4xRGRy?= =?utf-8?B?YnpYTVlodlErQ1dpUVY5YW01eTc0Rld4cmtHUGRmdmxIQ0lyT2QrYkNVb2Ew?= =?utf-8?B?N0VzcWFhaWJPZW9KR0VXS3lkUVUwVTE2MXZDS2pwSzAya2g0L1RnS1RsWmhn?= =?utf-8?B?ZXZFaDF6WUdBa0p4cTVzbjJVVVBkREZ0Y1lBMkIrYVJKYUZoOU9UQUFwcWE3?= =?utf-8?B?RFcvRCtHdDljWHhhU1ArN2VYakFzMDZDbHNMZUs3QnA1OGdaVEFZa3pDcnNk?= =?utf-8?B?aGxjNEl0N3dENVk0T3NWbGxZb2RkMkRQZkJOdUhZUGxnaE5kTEhhYXV4STY5?= =?utf-8?B?RVRKajFmeDlRRW1GdUcrSUFxVnFET1JIZ0kyZnl1dWZESUZPbDNOeFE2MkRv?= =?utf-8?B?dWpYZ3NlVEc2NTE3d3RUK3g0YVVXaDdMd2Y2SzBxL0g2MkhRc0s4Z0dKeXEr?= =?utf-8?B?cXRReGJEaDAzRUlNS2NJOGNYckVDZDk5UkZXWGdScFMyTVhvQkxPMXVVMkkw?= =?utf-8?B?MDhRdEpIb1NDNHVaWGZ0a0pYQWdXQmgyZU04Y3RDRElJM3JSV1p0b2RPZXov?= =?utf-8?Q?YBN1AjrFtHWkxgTqwZ/YnxvrS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64a8cd3a-f27b-41dd-af7b-08db18d5ccf7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:17:55.0817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +4ON1Ai6hpeNe3OSY8yZQrVSOeRJXIuObjGPkw0JImNUt+IMXzPaMqnGc4EJQfc8hLs+Z5IFGnFAYaH1vksE7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7366 On 25.02.2023 19:05, Julien Grall wrote: > On 24/02/2023 15:06, Oleksii Kurochko wrote: >> @@ -43,6 +45,11 @@ static void __init disable_fpu(void) >> >> void __init noreturn start_xen(void) >> { >> + unsigned long load_start = (unsigned long)start; >> + unsigned long load_end = load_start + (unsigned long)(_end - _start); > > I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote > it can't use global variable/function. But here... you are using them. > So how is this different? I guess "use" means "access" (i.e. call a function or read/write a variable). I suppose it does not mean "take the address of". Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:20:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:20:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502716.774622 (Exim 4.92) (envelope-from ) id 1pWfIJ-0005JM-HU; Mon, 27 Feb 2023 15:20:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502716.774622; Mon, 27 Feb 2023 15:20:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfIJ-0005Ic-Dn; Mon, 27 Feb 2023 15:20:03 +0000 Received: by outflank-mailman (input) for mailman id 502716; Mon, 27 Feb 2023 15:20:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfIH-00052m-Tv for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:20:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2073.outbound.protection.outlook.com [40.107.13.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33179330-b6b2-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:19:59 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7101.eurprd04.prod.outlook.com (2603:10a6:800:12e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:19:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:19:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33179330-b6b2-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpUI80c6wyG8P9po8PoSKsSR6nqlsIV4VLfVRf0xN+3kTZQeBp2uS7lZChpZKaARqdcbFi2x0ixYt/PxQskMnES810djB4d3GPu1zi0Gtdn+yCWJboPHCqjmqLHLAoMpgkjt7OKX3+06cGc14DV2naWalPEhWX8E3+ob0fcvWCJfzE0tgOqo5xHhhM2xHJMuKsBgCTei+YCa5/q651Zo/Q9jkg2ck9K1ZEIyneeDGJXrhSUNR35teKHYDSEyXc2LsXidV2ZOLiHpwPQZPIuHAAB9MPlg+/6R2x2Dmx25DpG0OK1E491Jy2YDRPxmFvwyw/Zqs/jRsBLXKf3+kfvpHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SuU/FIvvPOZbW+8xr9unHNx2CZukdMGge2w3DZNDZY=; b=kRBgyEpZjuMDc0gM/njQGWQwHTz9jkseDA+51xQMUJscJpy6gmbzmwO0GEKxSKUWi7US6F2hLxc/hH3MmKBSLSgj6abJoKZP3g4XicWz6k9QoITgCUMTdsAHdGJgnBkjvx6LFCTqZvbrPdgzCG6XBBi+ls7Pt1rQAJaC+vXePg2DH32z3fchf7W2oSQB4ssiE7qxQDN91aYTyJtWFAxZMS97MslhPMM2KyoZ2iaGUCv29bDgMhk1SmV2TNI72PxXhh65VVtEvisQykJ4eS16MI0d2SsUxtZTeZTc496Yl5Yy1Cpqw81eqYREJxJwHU7COHLNWvRG1ktUCUYToZaw6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8SuU/FIvvPOZbW+8xr9unHNx2CZukdMGge2w3DZNDZY=; b=2wnAuYNExjLzuckwNgmYRI3eOj4bribYKjoOm0T9xcwR3lU0AOjEo/dpebglmdRRbem5Mab70tkrmiftrwSeo4yqRqjQXrfddeWqiVcLUyMzC0dVtVyg7B4r8xIhlZfOzn/v7srUZPdDCsKF4w2ieAUHc+AxYxA+jtJ6EFt5hbwOeQPQXJBKQIwtjG3ID9EDhvU0vC/GqOs3fipydc0f2zdEREqj2a+E7FZx7zIwf5j64wBl8vUbLPizMleBjVbpR+kmABQZNPRXV9FPLGzzCYNggrFlHbaVSFpFbxve6VTeIhT5Pemkqul0TSuQ2KJ2oA3YakLJIWhi2OtGDwjhZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 16:19:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Content-Language: en-US From: Jan Beulich To: Oleksii Kurochko Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB7101:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c6a80d2-01a7-4222-2b48-08db18d605de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fok70gFPJuSvDDRjOLiaOr3WTw4tRKjU0olMP3H3erNo3BPecrEjU3+xqAIeKLEqLgBcptGd1pSXelNBGGJhkeDse7JDcqW0F0kG0cbn1kvAgR6+aGg18US+vjn68qNaXJs4hgojykaoYNnaSGpCboVhUxw8MvGGnk3crYHd7TsFj04zITHukvIwyg2MvfTZtuu7mMT1YZZWikmnG9cfsFoWL7T4TfMPG5aK1afLspprh+tjpgb1/N92U8M+WRrBsdrX4VK4hztV1Vt5SHiDqCRmUY2Nc8dsMb5Br3kb/onXmb2VyTG0NW5lyg01GYiE3Notld4YpSCkr5X6WYkjlXmDtS6vNqE2T9ARqgkcl/l41WpD3lg058H2UIASEimEBX7VCDR3AI0uSvVaBrCeZandptM6Xcz0LqQajGu54iqcbrRlUX/Yy1wUXttscNHg4VzNNhRs2yx8cKMwsfqb0tRqTtucIVY/IQqzwItYZuEkjUIW20DeOlIvH3YHaRMlhEPMXL8Cwfk9e4LPt6wy4OL1gKDwxo+nHPuWGjmXVL0g3iCBURyM2ZHL6TqkRrfKixDNr96h/mEDsgmU6Z9L+NX3LZM3pbm8YFv24+AmB9fcLaACcpfQp7ypa0fpzeB4kJ4ozpbViT9+AjXUBp9ynI5SwN/GW79955PYVwK3RI3n90A0MLFTY2XErPglBEiC2l1a71KMdfOnemul/V2TzO4ANd2ZbMWsBe/Ls0BJWlo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(376002)(39850400004)(366004)(136003)(451199018)(26005)(6512007)(186003)(53546011)(6506007)(86362001)(36756003)(38100700002)(31696002)(2616005)(41300700001)(66946007)(66556008)(66476007)(4326008)(6916009)(8676002)(2906002)(8936002)(4744005)(31686004)(5660300002)(6486002)(54906003)(316002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGhvZnVwQjlkV3Z6OE9SbFlobXd4YlVMTmdNa2E0WEtXQTg5eXpPZlZFckt4?= =?utf-8?B?UlZ5M2xiYTlEUW9yWEVGcGp2Y3FKT0R3bGZ1Z3czc2ZXQUJvL0tuWDVLMi9I?= =?utf-8?B?cFlVMUxYdzh6aCtjbElGS3dvdjZDQkNCZ0M2ckpVQWtPd0hqRXRSUEdCK0kx?= =?utf-8?B?TGliZlJMMGt5cUxjb3NNMXRCek1Bb0d6NWc4cnhmck1GdEVxbHIrekZVMThR?= =?utf-8?B?Ums1Um1abDRCUXNZSGdJUFlhRXlMT0FiamlRY0V1aTVXelBWZUp0RXU5Q05y?= =?utf-8?B?QllUd2pFVlRtcWk0MkhKZzk1ekdGMVF1YXNPY1NRV2RvbnZFSzlIa0MvSXBk?= =?utf-8?B?aUI2dGdqTnlLTEtKN2V4ck0rM0M1VUo0TEFOc2NidkNZekY2c3JONVQ2VG1H?= =?utf-8?B?ay9BZUpWR1dJWlJDMUZoT0hiWWpOZk01SlljTlJKOURFOUtiUVZYR2ZtTFhL?= =?utf-8?B?dytnN1RRZTlXTXV1N1dTTTZpdFlzUk9FcVh1blM1TDdlUmllVlJOdlh6NXBQ?= =?utf-8?B?dDBBMWdsbll3QnRQaEFkd2E3OFgwZ3JzR2RpVEhEUHBLbnRFa0RZdFlFVFZs?= =?utf-8?B?SWtxYS9aWFRkV2hROTBRS1ZibHZGWW5hLzJtZUlYaHNuM1d2QkhyYXpUNWVE?= =?utf-8?B?MWV0Yk9tc1VZTmhZR25CK2NiNTVXdkhjVmhDVFBVSU9jUDdVQnhFWTFISERU?= =?utf-8?B?Vjd1RFdRUjY1cVNzVm50enlqMEQxZUxMTVA5OW54aUhDdjFkRWJ5TGIrNEZW?= =?utf-8?B?NDc0MDIrdTBQam1iOGpRVlVUT1lPdnUyVU1KMGJTbnczazFwMCs2OC8vSHQ5?= =?utf-8?B?N0d0d3UzVldWUGVGQ25pQnZOWFVnSVZmaGp2cmZJRFAxMGdSZVNnQjVPM2JZ?= =?utf-8?B?YVRMOE5GdVhsWTMvY3RaRUx1M0h6QkxlOWVDZVlvblRIS0RIMjlzdWxYM3RD?= =?utf-8?B?T1RSN0xsREtyNnFyOUNCdEhESGNvVzNaa21jSk9wT1c2TU92NXp6K2F2NzBj?= =?utf-8?B?elVOSVRhendOc2lDT25rKzZYMXVqbFRCeEZUQnRwRk9TZTBNOEx2bS96Yzdk?= =?utf-8?B?KzFraEp3K2xlUGdYMTBKNTA4UU5KanM0UEhNUHhQNTcvTTQwMW1INmEwYVRo?= =?utf-8?B?c0dhR3FFU1lJMjVTNUtIMWU4c01RdFNDT0JIMGxwWTZMVUtlanlzT2NjbFp6?= =?utf-8?B?VHdsU05udUxsY2tWRjBYMTUwU1Z5T2p5Rk5zdVZnUVEyb1A5emZzMng5TGt1?= =?utf-8?B?K1JUZzUzcmFWMjVSM2RGcC9nQzQwRU5Zb0lIeGVkbHg4VjB3TTlGSmVpMkU0?= =?utf-8?B?QTd1bVRVN1NpUCtzOXgxSVB5bDlVRlU3aVJuamFpUkFsQVN3Q1A3WThuVzF6?= =?utf-8?B?Z3VzWEJ4UG9MaDdTT2hmRFBCaGdHNGt4OWdlaWsxaGFkWVNPUU1DbDdZSHFv?= =?utf-8?B?bmVobEVOOHI2YitaNWsxTCsrYkRGakcrZ3QvWmFoSjFhNlpwOGdvNm9IcDYw?= =?utf-8?B?MGNBQW41eVdwTjJUWE12ZmduL1BwbFdpM2hzUWR1SC9jTDArblptaFFHR1M1?= =?utf-8?B?Smc4eVFjY1RHUUVrWUgvbTJFM0NaWjFkdk1vTUJBV2w1aitRQzVhc0FRVWxx?= =?utf-8?B?RFpSc1JxWC9GUWxxZzB0WEZ5cXU2MlpvQStFOW9JN1JJUXFVWHNlVEVrNXd1?= =?utf-8?B?bXBpT2NSZXdqUHNvZmdFY3pUY0lsbEIyeWVBRzg1dkI3ZFVLNW44ejJpR2tm?= =?utf-8?B?SDBhakt6cDRIcytBT0dsWlF1MEZRRmhLZDlMeXh6dXJQOXZoYzgveDNHSmlL?= =?utf-8?B?OU5KdzAyZXVxbXZTL29Sa2diUWxxN3VHS3RTcWtvZ3BqUEp6bTIwOHl1aUJ6?= =?utf-8?B?M2QydktOWGtySjhkU055UzVmRTFPTVVoQkp2NEZmZFZkTzNlcDAwNldTZC90?= =?utf-8?B?VUxFc2paRS9FRERCT0VnNnJBbEkwcnhXakdBOFNYNGN2ZHVuU3AzQTB5RUhE?= =?utf-8?B?N1crTVpzZlRsc1JMekxDNGJOd2lrZ0hkdTBnU0lSZjFkU3FlaDZsR0V3bDRy?= =?utf-8?B?b3d1WUU0SitCbXZNZ3hoRGtraDNQZUxRbVg0ejZqNTBQU1RLMUpCZDZCSFJM?= =?utf-8?Q?FHfOxJqhGUZd42kNJ90WWt9uT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c6a80d2-01a7-4222-2b48-08db18d605de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:19:31.3101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CDCQWo7sQQHGGm+hcSShnv+fdaPyxaXA+f1YYeTa4UTyi+NHmcTvBmeiILYL4XjJjqyQ4KtNudbs8I1jSCj2Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7101 On 27.02.2023 16:12, Jan Beulich wrote: > On 24.02.2023 16:06, Oleksii Kurochko wrote: >> +static void __attribute__((section(".entry"))) >> +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t *zeroeth, > > Why the special section (also again further down)? Looking at patch 2 it occurred to me that you probably mean __init here. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:22:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502720.774632 (Exim 4.92) (envelope-from ) id 1pWfKG-0006Og-Ud; Mon, 27 Feb 2023 15:22:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502720.774632; Mon, 27 Feb 2023 15:22:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfKG-0006OZ-RR; Mon, 27 Feb 2023 15:22:04 +0000 Received: by outflank-mailman (input) for mailman id 502720; Mon, 27 Feb 2023 15:22:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfKF-0006OR-Bn for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:22:03 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20623.outbound.protection.outlook.com [2a01:111:f400:7e8b::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a03b385-b6b2-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:21:59 +0100 (CET) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CY8PR12MB8364.namprd12.prod.outlook.com (2603:10b6:930:7f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:21:56 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::a3a7:87d9:60f1:7eb1%5]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 15:21:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a03b385-b6b2-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U934M+V+ZqHi5s4LT3yfweRqqeL5ALftYdTwoeVrquDSR9YKTwB4EGuhvzTld6muwl1JjHGLRwNd8qq3UGEoswpyMolWxWieWrKh4gvZ/BOFiof2UX5OG27d8j6a7DBPg6NveWVaFjyVGMJlkHt9GsEBQICvWf4nQEXgZFzKI3ceZKtsEV7EIgu5CI130j0LksdlvgvQjZYtjSMzuWt23FgkPQZxwvcUSm5qXRVpHH2yhLfN+rlNxP0opHSZpfjGzhltZoa7E67jEk+Qf1Y4He4Eg/tbHQfLIFBYFi+BYJR01voNE5WL5jJIl/IqUct/lO2Wt3wcZ3Sm7v6R+rHZAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vaofaRcuDmWk446/aa0nRbDHDcPSmYOANyw8eJroMBQ=; b=dvYVUSVkvTJdQmXrSUD52+3IHeii6WTGQMslsiwdnHT1nS0EClQdPLi+ccAdAozemMwrop1tmRFFVGQ93gpW6HoCXLCp+K3NRyLyTRfEbFj4XSr1QIbJ+ra2StHjhMVA3/ZQ7GpQNRs3Wsf0oGTx4B7AQd++z7mxVnX/OybsGjT2N1tMk7ei7Kf2JZcui/OPX9DX2N91fh97nEuGA9P9RJGRG3M8fmEVtDejfxvDPe5eOU+8H16sX9TFvDQ5YlEqw016I9Q9/4mB7gYi56LWiAWwBR2W/KwvLpPhqlMhTeYsBMgVyqXN45Jp6Aiq8dUdQX0MdT3FbPVzbA5DnZ79IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vaofaRcuDmWk446/aa0nRbDHDcPSmYOANyw8eJroMBQ=; b=XRgfP03ZCbD7khm1dJnVyXbcihQGREDfBPeiyTRPg3A/IGJJXR69KCR75bQW7ogvLybX94Is9WAFxYjdE5t1X+dnvz107483q0odYgTV4kYqgWAOAJjFL+UAaF5+c65eRE/fwYMtXclYptrAa3vVJ5iyRBLwnUM1X2K4DksKLwU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <6450eb68-f953-9921-50f2-d873dfc7e761@amd.com> Date: Mon, 27 Feb 2023 15:21:48 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [XEN v3 6/9] xen/arm: Introduce choice to enable 64/32 bit physical addressing To: Julien Grall , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefano.stabellini@amd.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, wl@xen.org, rahul.singh@arm.com References: <20230208120529.22313-1-ayan.kumar.halder@amd.com> <20230208120529.22313-7-ayan.kumar.halder@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0253.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::6) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CY8PR12MB8364:EE_ X-MS-Office365-Filtering-Correlation-Id: 94751b0a-c6e9-4c55-d854-08db18d65bf4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EDGp5IswmIgsw2kQHvYSPHN+v6FYsEuQY25qR2pejMtM0vXbo0VtH/3L5cip/0PPz+CN4QX+A5UI1BYuYL1R0YLaUf934BV39JKs498lClcFlGq6m2ws3oOfP0lazJ5ZnWOo1sr7p/eHPJsqxVBwBpVciMJ4d91hS6DQIRdUWjMYHzIW+0DbmJnCq+9piV5uxgTMP48YVB+Z6i29vWHxUIoFn5JNHKI4hloR9HMBRbm2RBmc/wymV+Oe5xNWMYikseFYabWil8DKAzfH8vWtwVJmp6uewKZFrjdnKS4babCYMpfFHQ1MQ0/Jk0OWFJKiaWXKZJUD5h98IcDiKTDv5Nxorf5ZnxTKWmEFcvy/Bbxf+ks9ASOIMGjSMow7mzY6RHZCECYtKI66OhKZ4PrDdP6j6iApuVtxYgzzmOe1I2IifleUujQqyQrmsS3A1+7rnH4OmC476v48t+f4L0TAo6YYex4VXrE8lFt0fdsIv/o00Xd9d+yUTKI9JG8aH0S69ATt/PDOBur/5d1IBt/LU3HZgQwql8BwZC3m4phXe9QFDNW+b71M4STyS/tbdRoZAzKM0L3nOLwZ8NT2cBAipiVr5EGmqKxf3oHfDOPl1CI39mjL0L0YnF+BOHgTY5pL4voBzPNX4rYUkV6aGj5gTDOtHdJojoohhQ5XUjSeFfr6yBMmK4+EWwURAuS+mBVjKQhQ0LdAxHnLPGuasRGTfzQ8+oEGaR+lZR8n8fYvfvw3/qUIkAP4x0z9WEZGxtsn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199018)(4326008)(41300700001)(66476007)(83380400001)(66556008)(66946007)(8676002)(38100700002)(36756003)(2906002)(31696002)(7416002)(5660300002)(8936002)(30864003)(2616005)(6486002)(478600001)(110136005)(6506007)(31686004)(6512007)(6666004)(316002)(186003)(53546011)(26005)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzQ4NzBDSitEdVNTQ0FST0NrZ3MzR3RlczBSRzNsL1RYd0lXOFFhNWJ4L3Jy?= =?utf-8?B?eXhEVFJzc3VRcjhQNlcxemtIbzA1ZkhmVEIydkEzQ2xoTm16SUxZM01zbWZm?= =?utf-8?B?N21mOVdvN0JXUDQ3aGpUeVAvV2trQ3FMOEUrelpKc0RrRW1CNU45R3FhNTF3?= =?utf-8?B?Ly8vanYwaTErMENRTGM2aFVUdTJXQU5va2JCZFhBWWNqUk5xZlBHbVRIWEpt?= =?utf-8?B?NWE2NjB5NHNUSGV1aUFXNWtLajNFemNHanE3eU41MDU5SjhDOWtRWU1mMUZ1?= =?utf-8?B?MHNqRzlKSlg3SWNIK3pvYWNjdSs1ZjF3K3VMVWZ3ZFphZW9PWEFrSEFyamFw?= =?utf-8?B?S1I4eVNOVkRKTVVobkhEcmlRb09tUlRzcWdaaWtxQ1dFKzRBaFR0MVZlRVNq?= =?utf-8?B?bmJBR0xNMDExODEvbGJ0MENPQkF0UDFiWnppK3hmbGVpNC9CQkJDTzI0QTRr?= =?utf-8?B?ajlLS3BwVEc0RzkyZzBBRmFSamxBTWNKbFdFK0JWS0MvbFRZd3Zjb0RqNFVk?= =?utf-8?B?dDFOUUE0MDA3dS92UHJpYUxCODR0WWNDd2FpMUQ2NlRkYWlOSVdrNDg5NXBU?= =?utf-8?B?RzJMZ3EreUM1RGJjTjBiOEwrYzE3Q3oxTHRCYWNNdHFnc25FTjdpdlNiVmpE?= =?utf-8?B?MXF5OXVscG9RemltS2dZTW5hRWRNUXppR0dvM1dqRWNDT2RaamFPOG1DWE9T?= =?utf-8?B?eHdVTzBGaWZsRVgremVVMVIyczg4ZW5uN0d5S01OSTFFMno5ZEd3TjdZTVMr?= =?utf-8?B?Nlh5ZlUxeXhNWUUvUko2TEtEZURLbjMyMkllVzlwL0xJOHROMzFjMTZaa05j?= =?utf-8?B?NUxMZVlKRVIrOERxSTAvOTIwK29PR0JId0xLTk9lekIzQ2hjYitvM3JXSVNG?= =?utf-8?B?QzJEbzVVTitobUl1Z01hR2lGRFJqN1hZSlQ3czlHamhqVTJBWVFnZVRhMWVG?= =?utf-8?B?a2xBZXVMMWsrcStSZnVycmZjaG5VRHBSUUxYWDhGbXZZWm1XYjZkQlI0ckpJ?= =?utf-8?B?YVF0ZC9GTWJOMzJZajAwNG9iaFdoYUdSSEt6aTFxV2JURmZQUFlXWGw1YnVX?= =?utf-8?B?T3F2TVRacy9jRll4NWxiajI5ZU1SN1VDRmlreGxXY3cwSzJjRHVTUmliM0hF?= =?utf-8?B?N0hzQU1pLzFWTlNIbHB5d0tUNHlqL2lMK2dyWlVIZmxrbWw2bE90bnYvcStU?= =?utf-8?B?NmlOdThweHF4Ykdva3VWYlM0eFdOWlNNczdHaE9jNkFoZktiN3RrQTRUZFBE?= =?utf-8?B?TjZ0S3JPcHIzNEVxM0ZNc3ZkSzBNMnVqUkszTnBxTE0vell5Y1F3QnRXU0oy?= =?utf-8?B?Q3FuTGhYcmZ2eFRPMTloQkR4YVdJcjJBR2I1YjhzRC9mTFJzYWhZVHE0TEl2?= =?utf-8?B?UWkwcUVLM1JPbGNmL1lZU2RTQVdwV3h6NEs2NC9mYStBV1MwaDl3cmtNa09U?= =?utf-8?B?K2FCd0NweXhRcUtSd2V4ZFBMamtZN2JFbk5MbDFZSCtXeDNwYURRaG5QSUdT?= =?utf-8?B?RmlkYldyTVdPNVJtcGlwV3ZrUW9aTXlsVzBWSUV4WHRqMFZmQ0F2Z3VGcTBM?= =?utf-8?B?OEpLR0dOS1VldFRQbVZjQlUyY2YzQ3lRTENUb0l0YkgxaStvNzdFcFg1b3Vp?= =?utf-8?B?eXpmenNSb3RFRkNBZWo3azNQdFhYVi90bnNJZEJYeXJnMUNOczVrTWFubWVP?= =?utf-8?B?Z2VmOEE4MGhyKzZCL1lUWVA3T0lDUFFjNGQxT0ZoWDFBeGRseFlvZDlaR3BJ?= =?utf-8?B?ZU9Db1pTckplVFhnUGZLWHVZWnJYMUNnOWNFZC9TUkFNQk9yVks3N3h2MGgr?= =?utf-8?B?ajk4c3NkVGQ4c2ZCbmFnRmR3M0hYZ0d2SkNKeW1Oc3FBVDVnYjk2ZWFTVWtM?= =?utf-8?B?UENaWHJ3NUdlU0FpRUc0L20zRS9QYnJMZjBuNWRMV1RxeUNUQmY2MlFCTUtX?= =?utf-8?B?L0xveFhqV2JVdnJZODR6d1phdTJKbjNyc0pac0hjT1VxSmg4TmZoSUpMSGM1?= =?utf-8?B?cGdrVVgxK1B1VHRzMkxIdloycmJKVjBqei9xTGNCNHJQOTZnaWUyR0pyeDlq?= =?utf-8?B?M3c5cjJiQXE1eUgyc29ycXVwKzIyWWw5MFJ3cXRLWFRxSGJaUUkwbkQzNStJ?= =?utf-8?Q?NUaRd//KhIZvknLMZKR2AStX3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94751b0a-c6e9-4c55-d854-08db18d65bf4 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:21:55.1491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PnKUw7kICozLG6+Yv47/4kTmLyHJGKKuz+RRNrXXiU4XsFUf9gVivbIbJIw5n83idI3q/Y437UpaLdGdpgkjyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8364 On 11/02/2023 10:01, Julien Grall wrote: > Hi Ayan, Hi Julien, I need some clarification. > > On 08/02/2023 12:05, Ayan Kumar Halder wrote: >> Some Arm based hardware platforms which does not support LPAE >> (eg Cortex-R52), uses 32 bit physical addresses. >> Also, users may choose to use 32 bits to represent physical addresses >> for optimization. >> >> To support the above use cases, we have introduced arch independent >> configs to choose if the physical address can be represented using >> 32 bits (PHYS_ADDR_32) or 64 bits (PHYS_ADDR_64). >> For now only ARM_32 provides support to enable 32 bit physical >> addressing. >> >> Signed-off-by: Ayan Kumar Halder >> --- >> >> Changes from - >> v1 - 1. Extracted from "[XEN v1 8/9] xen/arm: Other adaptations >> required to support 32bit paddr". >> >> v2 - 1. Introduced Kconfig choice. ARM_64 can select PHYS_ADDR_64 >> only whereas >> ARM_32 can select PHYS_ADDR_32 or PHYS_ADDR_64. >> 2. For CONFIG_ARM_PA_32, paddr_t is defined as 'unsigned long'. >> >> (Jan,Julien please let me know if I understood your suggestion about >> Kconfig correctly). >> >>   xen/arch/Kconfig                     | 12 +++++++++++ >>   xen/arch/arm/Kconfig                 | 31 ++++++++++++++++++++++++++++ >>   xen/arch/arm/include/asm/page-bits.h |  2 ++ >>   xen/arch/arm/include/asm/types.h     |  6 ++++++ >>   4 files changed, 51 insertions(+) >> >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >> index 7028f7b74f..1eff312b51 100644 >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -1,6 +1,18 @@ >>   config 64BIT >>       bool >>   +config PHYS_ADDR_32 >> +    bool >> +    help >> +      Select this option if the physical addresses can be >> represented by >> +      32 bits. >> + >> +config PHYS_ADDR_64 >> +    bool >> +    help >> +      Select this option if the physical addresses can be represented >> +      64 bits. >> + > So you likely don't want to allow the user to select them directly > (IOW remove the help section). However, I don't see any code using it. > Did you actually intended to use PHYS_ADDR_{32, 64} in the code? > >>   config NR_CPUS >>       int "Maximum number of CPUs" >>       range 1 4095 >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 239d3aed3c..0955891e86 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -18,6 +18,37 @@ config ARM >>       select HAS_PDX >>       select HAS_PMAP >>       select IOMMU_FORCE_PT_SHARE >> +    choice > > I think this is a bit odd that this choice is part of CONFIG_ARM. It > would be better it is separate. You can do that by removing one > indentation. > >> +        bool "Representative width for any physical address (default >> 64bit)" >> +        optional >> +        ---help--- >> +          You may want to specify the width to represent the physical >> +          address space. >> +          By default, the physical addresses are represented using >> +          64 bits. >> + >> +          However in certain platforms, the physical addresses may be >> +          represented using 32 bits. >> +          Also, the user may decide that the physical addresses can be >> +          represented using 32 bits for a given SoC. In those cases, >> +          user may want to enable 32 bit physical address for >> +          optimization. >> +          For now, we have enabled this choice for ARM_32 only. >> + >> +        config ARM_PA_64 >> +            select PHYS_ADDR_64 >> +            bool "Select 64 bits to represent physical address" >> +            ---help--- >> +              Use 64 bits to represent physical address. >> + >> +        config ARM_PA_32 >> +            select PHYS_ADDR_32 >> +            depends on ARM_32 >> +            bool "Select 32 bits to represent physical address" >> +            ---help--- >> +              Use 32 bits to represent physical address. > > As I wrote in v2, I think this is a bit odd to ask the user what would > be the width of paddr_t. It is also not scalable if we decide in the > future to define different PADDR_BITS (i.e. 48, 40, 36, 32). > > So it would be better to allow the user to define PADDR_BITS that can > then be translated by Xen to which ever paddr_t is suitable. > > Something like: > > choice >    prompt: "Physical address space size" if ARM_32 >    default ARM_PA_48 if ARM_64 >    default AMR_PA_40 if ARM_32 >    help >      ... > > config ARM_PA_BITS_32 >    bool "32-bit" >    help >        XXX Add help here to explain the benefits of using 32-bit. > >    select PHYS_ADDR_T_32 >    depends on ARM_32 > > config ARM_PA_BITS_40 >    bool "40-bit" >    select PHYS_ADDR_T_64 >    depends on ARM_32 > > config ARM_PA_BITS_48 >    bool "40-bit" >    select PHYS_ADDR_T_64 >    depends on ARM_48 > endchoice > > config PADDR_BITS >    int >    default 32 if ARM_PA_BITS_32 >    default 40 if ARM_PA_BITS_40 >    default 48 if ARM_PA_BITS_48 > > With this approach, there would be no structural change in the Kconfig > if we wanted to support 32/40-bit on Arm64. > >> + >> +    endchoice >>     config ARCH_DEFCONFIG >>       string >> diff --git a/xen/arch/arm/include/asm/page-bits.h >> b/xen/arch/arm/include/asm/page-bits.h >> index 5d6477e599..8f4dcebcfd 100644 >> --- a/xen/arch/arm/include/asm/page-bits.h >> +++ b/xen/arch/arm/include/asm/page-bits.h >> @@ -5,6 +5,8 @@ >>     #ifdef CONFIG_ARM_64 >>   #define PADDR_BITS              48 >> +#elif CONFIG_ARM_PA_32 >> +#define PADDR_BITS              32 >>   #else >>   #define PADDR_BITS              40 >>   #endif > > With what I suggested above. This would be replaced with: > > #define PADDR_BITS CONFIG_PADDR_BITS > >> diff --git a/xen/arch/arm/include/asm/types.h >> b/xen/arch/arm/include/asm/types.h >> index e218ed77bd..26144bc87e 100644 >> --- a/xen/arch/arm/include/asm/types.h >> +++ b/xen/arch/arm/include/asm/types.h >> @@ -34,9 +34,15 @@ typedef signed long long s64; >>   typedef unsigned long long u64; >>   typedef u32 vaddr_t; >>   #define PRIvaddr PRIx32 >> +#if defined(CONFIG_ARM_PA_32) > > And this could be replaced with > #ifdef CONFIG_PHY_ADDR_T_32 > > I would also consider to add the following in mm.c > > BUILD_BUG_ON((sizeof(paddr_t) * 8) < PADDR_BITS); > > This is to make sure that the PADDR_BITS will always fit in paddr_t. > >> +typedef unsigned long paddr_t; >> +#define INVALID_PADDR (~0UL) >> +#define PRIpaddr "08lx" >> +#else >>   typedef u64 paddr_t; >>   #define INVALID_PADDR (~0ULL) >>   #define PRIpaddr "016llx" >> +#endif >>   typedef u32 register_t; >>   #define PRIregister "08x" >>   #elif defined (CONFIG_ARM_64) > > Cheers, I have followed your approach with some modifications. Let me know if it makes sense. Subject: [PATCH] xen/arm: Introduce choice to enable 64/32 bit physical  addressing Some Arm based hardware platforms which does not support LPAE (eg Cortex-R52), uses 32 bit physical addresses. Also, users may choose to use 32 bits to represent physical addresses for optimization. To support the above use cases, we have introduced arch independent configs to choose if the physical address can be represented using 32 bits (PHYS_ADDR_T_32) or 64 bits (PHYS_ADDR_T_64). For now only ARM_32 provides support to enable 32 bit physical addressing. When PHYS_ADDR_T_32 is defined, PADDR_BITS is set to 32. When PHYS_ADDR_T_64 is defined with ARM_32, PADDR_BITS is set to 40. When PHYS_ADDR_T_64 is defined with ARM_64, PADDR_BITS is set to 48. The last two is same as the current configuration used today on Xen. Signed-off-by: Ayan Kumar Halder ---  xen/arch/Kconfig                     |  6 ++++  xen/arch/arm/Kconfig                 | 41 ++++++++++++++++++++++++++--  xen/arch/arm/include/asm/page-bits.h |  6 +---  xen/arch/arm/include/asm/types.h     |  6 ++++  xen/arch/arm/mm.c                    |  1 +  5 files changed, 53 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index 7028f7b74f..89096c77a4 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -1,6 +1,12 @@  config 64BIT     bool +config PHYS_ADDR_T_32 +   bool + +config PHYS_ADDR_T_64 +   bool +  config NR_CPUS     int "Maximum number of CPUs"     range 1 4095 diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 239d3aed3c..b23ee56376 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -2,6 +2,7 @@ config ARM_32     def_bool y     depends on "$(ARCH)" = "arm32"     select ARCH_MAP_DOMAIN_PAGE +   select PHYS_ADDR_T_64  config ARM_64     def_bool y @@ -9,6 +10,7 @@ config ARM_64     select 64BIT     select ARM_EFI     select HAS_FAST_MULTIPLY +   select PHYS_ADDR_T_64  config ARM     def_bool y @@ -19,13 +21,48 @@ config ARM     select HAS_PMAP     select IOMMU_FORCE_PT_SHARE +menu "Architecture Features" + +choice +   prompt "Physical address space size" if ARM_32 +   default ARM_PA_BITS_48 if ARM_64 +   default ARM_PA_BITS_40 if ARM_32 +   help +     User can choose to represent the width of physical address. This can +     sometimes help in optimizing the size of image when user chooses a +     smaller size to present physical address. + +config ARM_PA_BITS_32 +   bool "32-bit" +   help +     On platforms where any physical address can be represented within 32 bits +     , user should choose this option. This will help is reduced size of the +     binary. +   select PHYS_ADDR_T_32 +   depends on ARM_32 + +config ARM_PA_BITS_40 +   bool "40-bit" +   depends on ARM_32 + +config ARM_PA_BITS_48 +   bool "40-bit" +   depends on ARM_48 +endchoice + +config PADDR_BITS +   int +   default 32 if ARM_PA_BITS_32 || PHYS_ADDR_T_32 +   default 40 if ARM_PA_BITS_40 || (PHYS_ADDR_T_64 && ARM_32) +   default 48 if ARM_PA_BITS_48 || (PHYS_ADDR_T_64 && ARM_64) /* * The reason for this '||' condition is that ARM_PA_BITS_32, ARM_PA_BITS_40 or ARM_PA_BITS_48 aren't visible for ARM_64. * We don't want PADDR_BITS to be undefined in ARM_64. Thus, we have added the || condition. * We could also remove ARM_PA_BITS_32, ARM_PA_BITS_40, ARM_PA_BITS_48 (from the || ), but have kept for documentation sake. * Let me know if you want it to be removed. */ +  config ARCH_DEFCONFIG     string     default "arch/arm/configs/arm32_defconfig" if ARM_32     default "arch/arm/configs/arm64_defconfig" if ARM_64 -menu "Architecture Features" -  source "arch/Kconfig"  config ACPI diff --git a/xen/arch/arm/include/asm/page-bits.h b/xen/arch/arm/include/asm/page-bits.h index 5d6477e599..deb381ceeb 100644 --- a/xen/arch/arm/include/asm/page-bits.h +++ b/xen/arch/arm/include/asm/page-bits.h @@ -3,10 +3,6 @@  #define PAGE_SHIFT              12 -#ifdef CONFIG_ARM_64 -#define PADDR_BITS              48 -#else -#define PADDR_BITS              40 -#endif +#define PADDR_BITS              CONFIG_PADDR_BITS  #endif /* __ARM_PAGE_SHIFT_H__ */ diff --git a/xen/arch/arm/include/asm/types.h b/xen/arch/arm/include/asm/types.h index e218ed77bd..56d27af162 100644 --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -34,9 +34,15 @@ typedef signed long long s64;  typedef unsigned long long u64;  typedef u32 vaddr_t;  #define PRIvaddr PRIx32 +#if defined(PHYS_ADDR_T_32) +typedef unsigned long paddr_t; +#define INVALID_PADDR (~0UL) +#define PRIpaddr "08lx" +#else  typedef u64 paddr_t;  #define INVALID_PADDR (~0ULL)  #define PRIpaddr "016llx" +#endif  typedef u32 register_t;  #define PRIregister "08x"  #elif defined (CONFIG_ARM_64) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index b99806af99..d8b43ef38c 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -690,6 +690,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)      const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32);      int rc; +    BUILD_BUG_ON((sizeof(paddr_t) * 8) < PADDR_BITS);      BUILD_BUG_ON(sizeof(struct page_info) != PAGE_INFO_SIZE);      if ( frametable_size > FRAMETABLE_SIZE ) -- 69,1          68% - Ayan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:25:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502726.774642 (Exim 4.92) (envelope-from ) id 1pWfNj-00074Q-KA; Mon, 27 Feb 2023 15:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502726.774642; Mon, 27 Feb 2023 15:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfNj-00074J-HN; Mon, 27 Feb 2023 15:25:39 +0000 Received: by outflank-mailman (input) for mailman id 502726; Mon, 27 Feb 2023 15:25:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfNi-00074D-JU for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:25:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062c.outbound.protection.outlook.com [2a01:111:f400:fe1f::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc569073-b6b2-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:25:37 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9589.eurprd04.prod.outlook.com (2603:10a6:102:265::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:25:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:25:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc569073-b6b2-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9ScSJwsNlZRLG5jbjlPR3I0KF4o73pclXpyVwBekoSqNgC+8CmN9CYYRWqyAGIdTd6EpH6Ntld9+SeleMeCuW3T3SILWx8bBytrCNnjygSylkQcv1Yh+eHevQEY/uqXujIPzX2P/m7MAyHp3p9pZ7KGrqgd1NjqZIBrxVoBrF8ObmwGbqwjhkDyx0NXRQfWY2dwWIjfDn41lBZz9Pt5DucLHBPijeRQNDE43DwThNmsKJmX2uSsRKStDUL6L5dCQ6V093bM+KvLOyAbQlv6HeghuJI0N5vwPdEGcFQWJsgBIFD6h3uTKkgsd3AzhuPhCV+hPhwT6+cFG1e7caDRLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5vXTwSreSMlnb91MRRfmR+e3Nq9kvvrXKqilsHyd0M=; b=SGmpm+6VyWddq5ANo/ZrZh0UxUYuPVqECn6l9stmWFGlMFmNPWX/QLLv2OpLO5l3OBuStbG4cwK3x0H64Pze6BEFi5JWfZzWHcmGG7PdUfatPVHj/cM/fLnzOuEjL4wuiimxvaHuvJZYjcyDhp6SuEKafxmiXP8Cs0pTuBNwNJf6N6eHoF6VOnBLq70XhMZbc/dyj/PnLdzPJBLJ2cumV/1af2HbxDI1e8lzZU/KLGZR6ECPyNH9OxIJ6wAMeOVb6IwvXfFZ3Fa4+Ci0mJZ3u6w5reRjC747OFRjrr3lZfv2+LkBMOQPUv+POR8wXcsKNjGG0gEa/tpjJjWJra2Ltg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d5vXTwSreSMlnb91MRRfmR+e3Nq9kvvrXKqilsHyd0M=; b=NDqWxa2Dw6u9ugvDYNYqfp0hP5qHpQkfQbpcAubGCnLC7q8JCOR+V507xZ1vGGIjuMueUDJ9J7zmfsbavXsBucSJ0VLIkxuK941HOOc6jJC2ynvFShdjeex7BiACYaE7wQWeWWEn85PtDm6UsuM+2MHN9pXdf3uqBhSazqOJzFC6AGZEclFeV0hKkFkswfe4MSLWCXD8Bu7IeRUws2DwzrvwM9wwfPpHK7sdpbplpNVPt9yS5kOpWUN+p1/yfpQ5HmOU0M/NXXdkvSw4XfRG+otsR7BbknXzPEM+AdOofQpO8w0qpHBVSoYiWkkjnLFsT8kV4LFfBH2EXJ3j8kx9Kw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 27 Feb 2023 16:25:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230224185010.3692754-11-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0099.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9589:EE_ X-MS-Office365-Filtering-Correlation-Id: 97669d35-d398-4b1e-1a0a-08db18d6dfb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8vZondBI12CmNSNN32Xz6TzWM95oA7zebg4QC/03jiZAmzWL7Zvx95n9VK7BVEQ6mQvwvQvsu1m3lG3oiF5Hrp3fI8EJSV1CxwiLoNKNTAAPEMSQVuG1/JNdT9Cda2aLNCpQCUVWlUaqZvxifvWfL8DELdI9uDUiXSQbcA4Vhj/KmtA9iLzhjJqP3kVgbWvMEoG/cT/Y9ZlK6V0qQJYu5ZswXAoWFWG+5iyyfltXMDCF9MfPbipj64Yu0sxXFFp1dOUZtv7z1u+Ei9wZaqrACHWAAQr9f4FQ4IV0hHpnkw814fAmSm1X1uIPa63Krk0Fff0b9SCueeafvKwXLAHwFe/f8cxy9QbsbnrHlr9vksw6uzUS/PeOQyB4kuDTxdG0ofDl/HaFADGMQnYsGeaH7brwuN6YjCmGk9yByhG0DmPvXEMOQfgyrUFpbbVbFdmDf/rld0HKxxOXAkT1XKzMH3AlCr/0/8qY1xvv7G8ChfGJTHPDuhL2NAZDoq8fYz/e0nHbUEcqwUMKqWmAsVBeAacYBuLitTk4R1xUKe1SwwxZzFz3seWBR5ANRKmzt6VOGUe+WsiFV6104jcKzcSEOZJOTsU2XIBwa/RNWWZHsi4X5AXwVkIMx5UCx/Q9qhQsXCtlIxEAxLgVvdJ2FqTOD6tG5F3bQNWOimbEdMW2xXb4FvzQaw55j3FXlrygYazGjmqS+Oxy3b5wAce8Khqq/hij8RJUMO17o32UWboJ0wE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199018)(36756003)(8936002)(5660300002)(4744005)(41300700001)(53546011)(6506007)(6512007)(38100700002)(186003)(26005)(2616005)(31696002)(86362001)(4326008)(54906003)(66946007)(66476007)(316002)(8676002)(66556008)(6916009)(478600001)(6486002)(31686004)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXgrSWRkdmNSRVFBUlF6RFg2YzZScW9YODlDem9qb2xtQkZVOFNpek42Rm1z?= =?utf-8?B?cGtlblI0ME5paGdBWXVWdittUHkwOW81bXpjdDFENUIrb3RGb2FHTU1MdHdR?= =?utf-8?B?Q0VyYms1U3o2ZkJDWlExbHBZM3dRcHBHMkhTb1Zib3Ezb3V3TlVmRzA5WEpw?= =?utf-8?B?WnhDc2VMdVFIOVdsZXRYbldySXNOTlZ3R0lwbS84T0RKbXFmdk1oQlZHNGlX?= =?utf-8?B?aXduUU9SQ0RIcjFKdC8rVDRHZkFVZ3RwamxXMDVjVVBtYTVKa2cvZTBzMzBy?= =?utf-8?B?YXhMTG01cTNCUWZJYkdEdlpHK240WU9wcVNJa1pVdzlWc2UyQzlsdmQzTHVo?= =?utf-8?B?ZVBWc3hnR29hR2RMaGEyUGJhK3paanQwc0V0M0dVZGtzZWNES25FU2Z1NXVW?= =?utf-8?B?OTlHVmpYMzE5bGhIVnVPbERaTjVZRHlWQW1PU04rcFVRaUt1NGgyM1JOc2RJ?= =?utf-8?B?Z1VsNUp2dTlXNEtZeE5LVkhielZpMUN3ZlBMUy9XajhUcnhDdVUzUTlkZDda?= =?utf-8?B?LzRLK2xYOENnK3hMQVBkUThkeVdYcWFPWlJjczJySjNJSGw2QzYrMUxrellB?= =?utf-8?B?LzhLNENZVG1XYjlhclZZN2ltVDFqeWNHZkhNQ1M0SkZxZDRiYThtY1AzWDZV?= =?utf-8?B?TjVaYmdmUnU2TVF0NHhZVUdkbldQb3RTT3I5c2hOQVgxWm9nSXRNcUtlSWlD?= =?utf-8?B?OTNicDArRDVZdG5vMVp1b0ZERUJOQVdPQWR1a0s3ME4yNFRBdUxDUXFBTDBl?= =?utf-8?B?cUxnU25SMi9ZVmtyRUROTzdlaGMyTVJxMVJYc2ErMk16T0hHQ1M1ZDRXb0xv?= =?utf-8?B?eEJJT3IwZk8yVzY3WHF1MG8yaC84TjdKZmNBSVU0TWtzNlVIak1zdXpVM1pp?= =?utf-8?B?R09qTFpOWEY1TXVHd1FJU3pPUEF1RWJnN0luYTVYSnpNUnkwS3Rocy9OSG4v?= =?utf-8?B?WkllaXBqdDZmS29zb01OMjhyNlRrNEFQdm1DaGVHODcrcEI2T0dJZTNJRXd5?= =?utf-8?B?K1dRemFpTlo2eUVEWjVjWlFmcUZqVktlVmlEenNXT2pzMDVQYjhzUkNuTU1p?= =?utf-8?B?bG1QSGs3c2hHQlgwbjNmcnVNZnM5ZXJrRG4xcGtBM3ltNmcyc2ZDNmxWVmhz?= =?utf-8?B?ajNtNmwvRnNRMEc3K3NDRHFWanRTUGNsNWQ2TERjdmRqbHU5TXZwK0I1QlN0?= =?utf-8?B?SmNqUEhTVXdxbkJDb0lsNmNhM25GMkt2NXFBRGM1VGR3THdrZEYvKzdiKzZV?= =?utf-8?B?TVdtc1BKd1Nla2g2eFRnSGg5UUNHa0VEdVJFcDJKQlFYcFFWYVBpV0ZrLzJZ?= =?utf-8?B?UjRYLzRybEY2bW5JOWF5K3hsZEw1VysxV3lLZ08rVnU4alBEejBrVEFJbk5O?= =?utf-8?B?aTh5T1JKY3B4bDJPSEVkTm5yQ1p5aFpkV29SczdzNEFKUEtxdUtTU2F1NWJn?= =?utf-8?B?YWxqSFo4VDJ5VlREdkE5L2d3QytQVFhpbW1vNFAwNUE5cEhmUTdXbXNNaDg2?= =?utf-8?B?aHVFSnBzNjBlYnRNTUp6dU1DYzBRVjlBUHZIOEhTMzA2TFZDdEdDQmEvK0Y1?= =?utf-8?B?UStsU0xFYzhoenJYWlpGVm80blNUSldJc0k5aExCcXFVcHpVRndwUGJnVjgr?= =?utf-8?B?S1ZKQ0Q0N2JaTUVLdFFKTkxtVWM3QkRIbVoxNm5JbmcwdkRSZXQvd3VPZTJq?= =?utf-8?B?SEkrcHA1RDlMSW5OOEpXdlVMMW1sSmVUMzRlcUdjb2FTT2JNTWVnajZpNHIw?= =?utf-8?B?YzI1LzRIbkNyZGVKQVdQRlkyajV2STNZQlJmWEh0emdVNjgwR1dYaUxtRXFT?= =?utf-8?B?K1hib0VIckFOMHhWc2N0dGoxRnlrZXd6MUxaTjRZYytKdEYyaUVGL1c3eXQy?= =?utf-8?B?NjJHd2VtLzlPUFJyenl4MnZlSnh3L2ErWE1iL1ZwYzNrRytSM1V4SitOSU9H?= =?utf-8?B?TEo1bUtrSkdtK1RFWGJYSFBUYXp0NzNnbmlLbC83TnQ3TTl4M1R1NkducGxB?= =?utf-8?B?Z2t2d0hLK3ZHSkRrUUJvdWFIVkJ0QURMRlBSU2RTQXNWdmV3SVpJZDkrY1M0?= =?utf-8?B?bC8xeVhST0l3UmNCenNTbWVRaHd5Undjdm05cTNXU2h6SkZwaWtoSEh5UDdm?= =?utf-8?Q?feNOWxj51MLgEmN7AfHz89aWk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97669d35-d398-4b1e-1a0a-08db18d6dfb3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:25:35.9900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9JplXotGjIbJGTTrQgYEAN4/SGYXhCf3qa3kDKLzsTM2/Va5jUWQyTdNpn3yc6X9JlDtO6PiJxq2dyubF+xyQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9589 On 24.02.2023 19:50, Xenia Ragiadakou wrote: > --- /dev/null > +++ b/xen/arch/x86/hvm/vmx/pi.h > @@ -0,0 +1,78 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * pi.h: VMX Posted Interrupts > + * > + * Copyright (c) 2004, Intel Corporation. > + */ > + > +#ifndef __X86_HVM_VMX_PI_PRIV_H__ > +#define __X86_HVM_VMX_PI_PRIV_H__ I can see that you need something to disambiguate the two vmx.h. But here you don't need the PRIV infix, do you? Even in the private vmx.h I'd like to ask to consider e.g. __VMX_H__ as the guard (and then __PI_H__ here), rather than one which doesn't really match the filename. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:28:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:28:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502731.774652 (Exim 4.92) (envelope-from ) id 1pWfQX-0007dc-1V; Mon, 27 Feb 2023 15:28:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502731.774652; Mon, 27 Feb 2023 15:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfQW-0007dV-Us; Mon, 27 Feb 2023 15:28:32 +0000 Received: by outflank-mailman (input) for mailman id 502731; Mon, 27 Feb 2023 15:28:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfQV-0007dP-AE for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:28:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20617.outbound.protection.outlook.com [2a01:111:f400:fe1a::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 633f0975-b6b3-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:28:30 +0100 (CET) Received: from DB7PR05CA0064.eurprd05.prod.outlook.com (2603:10a6:10:2e::41) by DB9PR08MB9515.eurprd08.prod.outlook.com (2603:10a6:10:453::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:28:28 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::e1) by DB7PR05CA0064.outlook.office365.com (2603:10a6:10:2e::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 15:28:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 15:28:27 +0000 Received: ("Tessian outbound f2a8d6d66d12:v135"); Mon, 27 Feb 2023 15:28:27 +0000 Received: from b90d4dd5a4bb.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 94692B98-C7EB-4501-B8AF-3A6FA2B0B16D.1; Mon, 27 Feb 2023 15:28:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b90d4dd5a4bb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 27 Feb 2023 15:28:21 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB10052.eurprd08.prod.outlook.com (2603:10a6:800:1c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 15:28:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:28:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 633f0975-b6b3-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taEqrWMYx0Z6ltSjrgtuw7LMOV9CfxxvRL41mw8DV9Q=; b=pD8BnwcBgxkNpUHc6m9gksfm9wbNAVd5f7SCSb3ERiAlfCj+FCXk2iO5R5CSCwHYqHOd9WSEsIbJXow5sc/coR43S6R8WK8QYpQ0o9ELWIXpAC2A0cQPzCDpYq6S7I/gnaIsxm3ACUgmSbLB/J7I1sM7iwVx3rCDW/oV310j220= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0d9ea05c3a565df5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mieZk3pw7zZcEN1h8LBymmQGw7pT1Bw4RZwhBifbccMQ9ecxiDD9B/9xoHUv6jbT+g9IVwHZcBwq9GdLEZ+vhhROLzkisGpmwDtH6QwEbeNqZG5UZM8lReWeQ2osuhxMq0SWHljvLc8k4JWBhgvqQQtzfBrsanAcUSxCTU0cfQCmcFLsMxc8xFoRV761WJeYuUM9ma9zdJcZzKUFdbiCSEvwrO47HcOrRAEYPaDaDbOxwAOAdYF7i4qyeIC1+lz3vLNihe7xq4ynatA7Nbod8oiEqy7vUTydMnSe9D2Mrpr/f9hAxUxyKfOF6sCT0xWR7sYiCBmg2J72/8AcI6GxeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=taEqrWMYx0Z6ltSjrgtuw7LMOV9CfxxvRL41mw8DV9Q=; b=RdMJI9BmrXmrd4kk/zgkCmkciMn5RsMZN+8X0a+M1T9FCTEj8/WGNp6dgs1N69zpU3hNW7+ptYrk0Ntl1O0PiftzPBJfq02IaoytjmBI4u5cZplv+fFVRAPVUzRL1Cqvr6fkFWlTreSjQZTSO7cbaqvaqwnFiSy3F+1TNoevjrDatL/cE9Ytu5aEYFBykGvgqMCO+rQ3QCpRE8kotXHD0tOZWNiIqhkAHHxDvwFioh13hFrUv9DYogb/SwnAGPBkP3W47Fj97PsZCvj8Hr8ELpEWjKSyPVxz46h/W2gHTLjtx2jkpdMkRfEmydDxlNawrJNbFOA71QVGGCSBJIt68w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taEqrWMYx0Z6ltSjrgtuw7LMOV9CfxxvRL41mw8DV9Q=; b=pD8BnwcBgxkNpUHc6m9gksfm9wbNAVd5f7SCSb3ERiAlfCj+FCXk2iO5R5CSCwHYqHOd9WSEsIbJXow5sc/coR43S6R8WK8QYpQ0o9ELWIXpAC2A0cQPzCDpYq6S7I/gnaIsxm3ACUgmSbLB/J7I1sM7iwVx3rCDW/oV310j220= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 10/20] xen/arm: ffa: add direct request support Thread-Topic: [XEN PATCH v7 10/20] xen/arm: ffa: add direct request support Thread-Index: AQHZRtMbYfucWbm5fkaW7bEI3lX4ea7i8oGA Date: Mon, 27 Feb 2023 15:28:11 +0000 Message-ID: References: <3332563e64568b2ffd236b1f428c27aa4cdf9790.1677079672.git.jens.wiklander@linaro.org> In-Reply-To: <3332563e64568b2ffd236b1f428c27aa4cdf9790.1677079672.git.jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|VI1PR08MB10052:EE_|DBAEUR03FT031:EE_|DB9PR08MB9515:EE_ X-MS-Office365-Filtering-Correlation-Id: cbe9b386-7f50-432e-9136-08db18d7463e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x68pHiqojGdvCLbhnwyxC5uZMbNQJFX6OltnGxdShE1CbdMdZhfBpqc/IYJ4O1JcgGXliV+SJth9kJiOBbyCND/gQE06GJyXwNIZxtuAC8QAcGpePSvytkxSkKdKCYy4XnEvlAYSQjnEdBpROqyPQtgTR5wSfzahth2jKBagLhaWnVKvieyXaPLovZ+DJLne5QYHFcLu9fhnt3faeNGaJwcmz+YnOAH6vmeXKmAGu63QDPgp0E7BPPkIqX67t9QceD1IoVLVcQAK5mYG5FbFN04yxb8h7KH3gUJgSotuO47iVjqQbgA85+ted7D3w94RGhKSlD4E8WsgtqjWJEGjZm60mQXaixM/T8YQDtzD617vBUGCWbFcvdFYKP/E1OQEE5uiaWbM9R2g8ZxHL15LpwSX71Fvd/yiFFBCftZuW94WY30Tp/uqT/jhe3aORAJ7fJZqI8AmBXD7BIDC5pwKPFbDTmuCDtpGZIbRGGrqqWmgrU+r9AnV7JFlL8knv0D+GRC38SYqT7EJFW9wwVVgVYRdwn4ZrIGWkh+LQWHInvwNQ7WXseOsFyLPME77nwS/++kSbzsiL1QaHio/7Cjo9SUCrHxQzN67JoTXwZIu3w/1bSmiGUqeD/TyAZWAosoWCes/ZQUQXf/lq1O9lkk/n3Wwch+HuCmfDeQie32MJgaj2zvdrh0xKuN+J4mOKlnlcP8Akhu6QrAjEJ32pP0c7ckr4YPZiYjX6lv3uKWvrjI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(366004)(346002)(39850400004)(376002)(451199018)(186003)(38100700002)(2906002)(122000001)(38070700005)(83380400001)(41300700001)(66946007)(6916009)(76116006)(8936002)(4326008)(8676002)(66556008)(6512007)(91956017)(66446008)(71200400001)(66476007)(2616005)(53546011)(478600001)(6506007)(64756008)(5660300002)(26005)(6486002)(33656002)(54906003)(86362001)(36756003)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5F0A54116FBDB34EBF9BD5CE47BAB3A5@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10052 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5041fbd7-d817-428b-eb3f-08db18d73c71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 92B9bEYv8wQA+bzeWppGGYoqpwQ5MVQCp9eqQovKdkO8TwmWcNUMsGEK6ak7eExNK5t4V0xC+8LC11qjcToQrClyRhvXpe5rsPiuhiyNi0tLTlket9XCFLl0O9R07K7pyELPWZeXr5f9ySoZVAO42mI9VxiRP6CDE5ic52IYll9kHtQqW6l95eMfYMKjse0Mgei4+XrYZeW6SWSkzmXpYn2fLmNRIXMOSzkjjvGvVRJSsqaGVUnlXgGoPamMHu1tKXq2FlU0OmsC8MPSYbTnWqh/tMbVxW4cNRSVufSMtJzWdFzERw5e5aSl/Sxylb/hLO7FuZoAvrCTKn3sCJficaC8fgB9li4mr2DpfNOFdfSLYnVhKJn1hwOPPyMFNeMWzLV0CDUNMzxoZjFpZQb4S1LJo4MRVw8aYZswWZmishtqAQJU3jKr4MCHb5NrdtDlNk2ITqwXLTFOtxiwn+TT3nSxlDRyjTygmiR3R1BzPTseK0ObmC+xy7bqmYg7YeZTSdRXgRO+Y9SyLlXowgQu/XOh+tjHlHRKcRzgkbl1g20Uv/RhMQXVk8L/SU/LWNaMb9t0K/dC/EOd94EWjNgILC5LO6DKBGWFwvLDCksqvbtBKTUpLy3ieGkHHFNbpcYdMV0Cvs34VrJsOy8spZ2S1VWnGZk0waCrJP2yPBHDJXwIjS+qjRqNuEpj0nNfND7jol6X8jZv61B4ubnOTFoNog== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(36756003)(6862004)(8936002)(5660300002)(41300700001)(36860700001)(53546011)(6506007)(6512007)(82310400005)(82740400003)(81166007)(336012)(47076005)(83380400001)(186003)(26005)(2616005)(40480700001)(86362001)(4326008)(33656002)(54906003)(40460700003)(70206006)(70586007)(316002)(8676002)(478600001)(356005)(6486002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:28:27.8441 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbe9b386-7f50-432e-9136-08db18d7463e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9515 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > Adds support for sending a FF-A direct request. Checks that the SP also > supports handling a 32-bit direct request. 64-bit direct requests are > not used by the mediator itself so there is not need to check for that. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 119 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 119 insertions(+) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 463fd7730573..a5d8a12635b6 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -142,6 +142,7 @@ >=20 > struct ffa_ctx { > uint32_t guest_vers; > + bool interrupted; This is added and set here for one special error code but is never used. I would suggest to introduce this when there will be an action based on it. > }; >=20 > /* Negotiated FF-A version to use with the SPMC */ > @@ -167,6 +168,55 @@ static bool ffa_get_version(uint32_t *vers) > return true; > } >=20 > +static int32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_simple_call(uint32_t fid, register_t a1, register_t a= 2, > + register_t a3, register_t a4) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D fid, > + .a1 =3D a1, > + .a2 =3D a2, > + .a3 =3D a3, > + .a4 =3D a4, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_features(uint32_t id) > +{ > + return ffa_simple_call(FFA_FEATURES, id, 0, 0, 0); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + uint32_t ret =3D ffa_features(id); > + > + if (ret) > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id)= ; It might be useful here to actually print the error code. Are we sure that all errors actually mean not supported ? > + > + return !ret; > +} > + > static uint16_t get_vm_id(const struct domain *d) > { > /* +1 since 0 is reserved for the hypervisor in FF-A */ > @@ -208,6 +258,66 @@ static void handle_version(struct cpu_user_regs *reg= s) > set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > } >=20 > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint3= 2_t fid) > +{ > + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; > + struct arm_smccc_1_2_regs resp =3D { }; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.tee; > + uint32_t src_dst; > + uint64_t mask; > + > + if ( smccc_is_conv_64(fid) ) > + mask =3D GENMASK_ULL(63, 0); > + else > + mask =3D GENMASK_ULL(31, 0); > + > + src_dst =3D get_user_reg(regs, 1); > + if ( (src_dst >> 16) !=3D get_vm_id(d) ) > + { > + resp.a0 =3D FFA_ERROR; > + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + arg.a1 =3D src_dst; > + arg.a2 =3D get_user_reg(regs, 2) & mask; > + arg.a3 =3D get_user_reg(regs, 3) & mask; > + arg.a4 =3D get_user_reg(regs, 4) & mask; > + arg.a5 =3D get_user_reg(regs, 5) & mask; > + arg.a6 =3D get_user_reg(regs, 6) & mask; > + arg.a7 =3D get_user_reg(regs, 7) & mask; > + > + while ( true ) > + { > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_INTERRUPT: > + ctx->interrupted =3D true; > + goto out; > + case FFA_ERROR: > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + case FFA_MSG_SEND_DIRECT_RESP_32: > + case FFA_MSG_SEND_DIRECT_RESP_64: > + goto out; > + default: > + /* Bad fid, report back. */ > + memset(&arg, 0, sizeof(arg)); > + arg.a0 =3D FFA_ERROR; > + arg.a1 =3D src_dst; > + arg.a2 =3D FFA_RET_NOT_SUPPORTED; > + continue; There is a potential infinite loop here and i do not understand why this needs to be done. Here if something is returning a value that you do not understand you send back an ERROR to it. I do not find in the spec where this is supposed to be done. Can you explain a bit here ? > + } > + } > + > +out: > + set_regs(regs, resp.a0, resp.a1 & mask, resp.a2 & mask, resp.a3 & ma= sk, > + resp.a4 & mask, resp.a5 & mask, resp.a6 & mask, resp.a7 & m= ask); > +} > + > static bool ffa_handle_call(struct cpu_user_regs *regs) > { > uint32_t fid =3D get_user_reg(regs, 0); > @@ -225,6 +335,12 @@ static bool ffa_handle_call(struct cpu_user_regs *re= gs) > case FFA_ID_GET: > set_regs_success(regs, get_vm_id(d), 0); > return true; > + case FFA_MSG_SEND_DIRECT_REQ_32: > +#ifdef CONFIG_ARM_64 > + case FFA_MSG_SEND_DIRECT_REQ_64: > +#endif > + handle_msg_send_direct_req(regs, fid); > + return true; >=20 > default: > gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); > @@ -310,6 +426,9 @@ static bool ffa_probe(void) > printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > major_vers, minor_vers); >=20 > + if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > + return false; One could not need this feature and here this will make everything unavaila= ble instead. Why not just reporting back the unsupported error to clients using unsuppor= ted interfaces ? Cheers Bertrand > + > ffa_version =3D vers; >=20 > return true; > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:37:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502737.774661 (Exim 4.92) (envelope-from ) id 1pWfYY-00010l-RL; Mon, 27 Feb 2023 15:36:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502737.774661; Mon, 27 Feb 2023 15:36:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfYY-00010e-Oj; Mon, 27 Feb 2023 15:36:50 +0000 Received: by outflank-mailman (input) for mailman id 502737; Mon, 27 Feb 2023 15:36:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfYX-00010Y-C0 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:36:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfYT-0003aE-9L; Mon, 27 Feb 2023 15:36:45 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.16.186]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWfYT-0002Yl-2s; Mon, 27 Feb 2023 15:36:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7q/y7XlNtwRnQWHCQw8XE7k+5iwVeEnMHYGAdftZyP8=; b=Jwjmg7LfehTwEyanMrXVtyh2xr gmdTeziu2WAU00l0u1r+yDZ/mPY5RG5g4crlUSkjFZ/35f8HEPP8TK2dOL/KsUISXaRady/brAAa5 qtWFkoQDytoTB6LIYAr9Ft9qrih95ihVZhvW38pSZHEWt8lfAecy3r50X03WTR+oVRyY=; Message-ID: <368cc6d8-04b4-03a9-9f95-600b564c92d1@xen.org> Date: Mon, 27 Feb 2023 15:36:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis , Oleksii Kurochko , xen-devel@lists.xenproject.org References: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/02/2023 15:17, Jan Beulich wrote: > On 25.02.2023 19:05, Julien Grall wrote: >> On 24/02/2023 15:06, Oleksii Kurochko wrote: >>> @@ -43,6 +45,11 @@ static void __init disable_fpu(void) >>> >>> void __init noreturn start_xen(void) >>> { >>> + unsigned long load_start = (unsigned long)start; >>> + unsigned long load_end = load_start + (unsigned long)(_end - _start); >> >> I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote >> it can't use global variable/function. But here... you are using them. >> So how is this different? > > I guess "use" means "access" (i.e. call a function or read/write a > variable). I suppose it does not mean "take the address of". If so, then I don't understand why we need to pass linker_start, linker_end in parameters for setup_initial_pages(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:42:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502743.774671 (Exim 4.92) (envelope-from ) id 1pWfdW-0002oG-H7; Mon, 27 Feb 2023 15:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502743.774671; Mon, 27 Feb 2023 15:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdW-0002o9-Eb; Mon, 27 Feb 2023 15:41:58 +0000 Received: by outflank-mailman (input) for mailman id 502743; Mon, 27 Feb 2023 15:41:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdV-0002o3-Re for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:41:57 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43fa06df-b6b5-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:41:56 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2E0921FD65; Mon, 27 Feb 2023 15:41:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A9AB913912; Mon, 27 Feb 2023 15:41:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Q4jtJ0PP/GN/LgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 15:41:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43fa06df-b6b5-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677512516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=I6z0kEMv/XhfT7nP05fQMWCjqMhyG4b4PAsCLSVXNKU=; b=GWk/ZLmaEYpN4aiIpK09KMI4RTJ1aGEKqmHWMBUmviOXK4jeJaAYMqEsJtYWAOljIB6JPE 1LQWPu+XjWL3r32ECG4JcwdGTmQ/SxQLJTlfEK22KDxsCRFrUGsK0Rl0yipzIruX38iYU1 8KX+5E3zChtIRdnz3h1s3R2i/FMGPVw= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Julien Grall , George Dunlap Subject: [PATCH v2 0/4] tools: use xen-tools/libs.h for common definitions Date: Mon, 27 Feb 2023 16:41:49 +0100 Message-Id: <20230227154153.31080-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are some macros defined multiple times in tools. Use only a single header file for defining those macros and drop the copies. V2: - add patch 1 (Andrew Cooper) Juergen Gross (4): tools: rename xen-tools/libs.h file to common-macros.h tools: add container_of() macro to xen-tools/common-macros.h tools: get rid of additional min() and max() definitions tools: add offsetof() to xen-tools/common-macros.h tools/console/daemon/io.c | 2 +- tools/firmware/hvmloader/util.h | 11 ++-------- tools/firmware/include/stddef.h | 4 ++-- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 2 +- .../xen-tools/{libs.h => common-macros.h} | 22 ++++++++++++++++--- tools/libfsimage/Rules.mk | 2 ++ tools/libfsimage/xfs/fsys_xfs.c | 4 +--- tools/libs/call/buffer.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_sr_common.c | 2 +- tools/libs/light/libxl_internal.h | 2 +- tools/libs/light/libxl_psr.c | 2 +- tools/libs/stat/xenstat_linux.c | 2 +- tools/libs/vchan/init.c | 7 +----- tools/misc/xen-access.c | 2 +- tools/misc/xen-cpuid.c | 2 +- tools/misc/xen-diag.c | 2 +- tools/misc/xen-hptool.c | 2 +- tools/misc/xen-livepatch.c | 2 +- tools/misc/xen-mfndump.c | 2 +- tools/misc/xenpm.c | 2 +- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- tools/tests/cpu-policy/test-cpu-policy.c | 2 +- .../paging-mempool/test-paging-mempool.c | 2 +- tools/tests/resource/test-resource.c | 2 +- tools/tests/tsx/test-tsx.c | 2 +- tools/tests/vhpet/emul.h | 16 +------------- tools/tests/vpci/emul.h | 22 +------------------ tools/tests/x86_emulator/x86-emulate.h | 7 +----- tools/tests/xenstore/test-xenstore.c | 2 +- tools/xenstore/list.h | 6 ++--- tools/xenstore/utils.h | 2 +- tools/xentrace/analyze.h | 2 +- tools/xl/xl_cmdtable.c | 2 +- xen/lib/x86/private.h | 2 +- 46 files changed, 68 insertions(+), 105 deletions(-) rename tools/include/xen-tools/{libs.h => common-macros.h} (74%) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:42:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:42:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502744.774682 (Exim 4.92) (envelope-from ) id 1pWfde-00035P-Oo; Mon, 27 Feb 2023 15:42:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502744.774682; Mon, 27 Feb 2023 15:42:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfde-00035I-Ld; Mon, 27 Feb 2023 15:42:06 +0000 Received: by outflank-mailman (input) for mailman id 502744; Mon, 27 Feb 2023 15:42:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfde-00034v-2I for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:42:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4766f902-b6b5-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:42:02 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13C95219E1; Mon, 27 Feb 2023 15:42:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99AFE13912; Mon, 27 Feb 2023 15:42:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id C/ZPJEnP/GOLLgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 15:42:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4766f902-b6b5-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677512522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jnk/7wu8wbdXtKZRHkZW+NZ4KlZpKHkQVohbC1DIgv0=; b=QCMlVF7uNQIJ83PcyoZRnK5QTvKRVRz2QkS6CDipWzhty8znCfD9btjxhl1tmTcKHDcvEk 2CezFzw6d3hM07kw8F4tgsk0bpaB8pbZ34+v6sG23NEQuSoy+AiFMc/OGtVLyrAC4n3Eql 2j/T5hou3g5ySazQRtpOXm5pFgCKOg4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Julien Grall , George Dunlap Subject: [PATCH v2 1/4] tools: rename xen-tools/libs.h file to common-macros.h Date: Mon, 27 Feb 2023 16:41:50 +0100 Message-Id: <20230227154153.31080-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227154153.31080-1-jgross@suse.com> References: <20230227154153.31080-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to better reflect the contents of the header and to make it more appropriate to use it for different runtime environments like programs, libraries, and firmware, rename the libs.h include file to common-macros.h. Additionally ad a comment pointing out the need to be self-contained. Suggested-by: Andrew Cooper Signed-off-by: Juergen Gross --- V2: - new patch --- tools/console/daemon/io.c | 2 +- tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 2 +- .../include/xen-tools/{libs.h => common-macros.h} | 14 +++++++++++--- tools/libs/call/buffer.c | 2 +- tools/libs/ctrl/xc_pm.c | 2 +- tools/libs/ctrl/xc_private.h | 2 +- tools/libs/foreignmemory/linux.c | 2 +- tools/libs/gnttab/freebsd.c | 2 +- tools/libs/gnttab/linux.c | 2 +- tools/libs/guest/xg_core_arm.c | 2 +- tools/libs/guest/xg_cpuid_x86.c | 2 +- tools/libs/guest/xg_dom_arm.c | 2 +- tools/libs/guest/xg_dom_bzimageloader.c | 2 +- tools/libs/guest/xg_dom_x86.c | 2 +- tools/libs/guest/xg_sr_common.c | 2 +- tools/libs/light/libxl_internal.h | 2 +- tools/libs/light/libxl_psr.c | 2 +- tools/libs/stat/xenstat_linux.c | 2 +- tools/misc/xen-access.c | 2 +- tools/misc/xen-cpuid.c | 2 +- tools/misc/xen-diag.c | 2 +- tools/misc/xen-hptool.c | 2 +- tools/misc/xen-livepatch.c | 2 +- tools/misc/xen-mfndump.c | 2 +- tools/misc/xenpm.c | 2 +- tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- tools/python/xen/lowlevel/xc/xc.c | 2 +- tools/tests/cpu-policy/test-cpu-policy.c | 2 +- tools/tests/paging-mempool/test-paging-mempool.c | 2 +- tools/tests/resource/test-resource.c | 2 +- tools/tests/tsx/test-tsx.c | 2 +- tools/tests/vhpet/emul.h | 2 +- tools/tests/x86_emulator/x86-emulate.h | 2 +- tools/tests/xenstore/test-xenstore.c | 2 +- tools/xenstore/utils.h | 2 +- tools/xentrace/analyze.h | 2 +- tools/xl/xl_cmdtable.c | 2 +- xen/lib/x86/private.h | 2 +- 39 files changed, 49 insertions(+), 41 deletions(-) rename tools/include/xen-tools/{libs.h => common-macros.h} (83%) diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c index 682c1f4008..6bfe96715b 100644 --- a/tools/console/daemon/io.c +++ b/tools/console/daemon/io.c @@ -50,7 +50,7 @@ #include #include #endif -#include +#include /* Each 10 bits takes ~ 3 digits, plus one, plus one for nul terminator. */ #define MAX_STRLEN(x) ((sizeof(x) * CHAR_BIT + CHAR_BIT-1) / 10 * 3 + 2) diff --git a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c index 79a849a044..7d0f274c6c 100644 --- a/tools/fuzz/cpu-policy/afl-policy-fuzzer.c +++ b/tools/fuzz/cpu-policy/afl-policy-fuzzer.c @@ -8,7 +8,7 @@ #include -#include +#include #include #include #include diff --git a/tools/include/xen-tools/libs.h b/tools/include/xen-tools/common-macros.h similarity index 83% rename from tools/include/xen-tools/libs.h rename to tools/include/xen-tools/common-macros.h index bafc90e2f6..f39cd96008 100644 --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/common-macros.h @@ -1,5 +1,13 @@ -#ifndef __XEN_TOOLS_LIBS__ -#define __XEN_TOOLS_LIBS__ +#ifndef __XEN_TOOLS_COMMON_MACROS__ +#define __XEN_TOOLS_COMMON_MACROS__ + +/* + * Caution: + * + * This header must be completely self-contained. There are no external + * references to variables or functions allowed, as the file might be included + * for different runtime environments, such as firmware or normal programs. + */ #ifndef BUILD_BUG_ON #if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) @@ -67,4 +75,4 @@ #define __must_check __attribute__((__warn_unused_result__)) #endif -#endif /* __XEN_TOOLS_LIBS__ */ +#endif /* __XEN_TOOLS_COMMON_MACROS__ */ diff --git a/tools/libs/call/buffer.c b/tools/libs/call/buffer.c index 085674d882..2579b8c719 100644 --- a/tools/libs/call/buffer.c +++ b/tools/libs/call/buffer.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include "private.h" diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 76d7eb7f26..c3a9864bf7 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -21,7 +21,7 @@ #include #include "xc_private.h" -#include +#include /* * Get PM statistic info diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index ed960c6f30..80dc464c93 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -39,7 +39,7 @@ #include -#include +#include #if defined(HAVE_VALGRIND_MEMCHECK_H) && !defined(NDEBUG) && !defined(__MINIOS__) /* Compile in Valgrind client requests? */ diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c index 9062117407..12f959765a 100644 --- a/tools/libs/foreignmemory/linux.c +++ b/tools/libs/foreignmemory/linux.c @@ -25,7 +25,7 @@ #include #include -#include +#include #include "private.h" diff --git a/tools/libs/gnttab/freebsd.c b/tools/libs/gnttab/freebsd.c index e42ac3fbf3..d69d928a16 100644 --- a/tools/libs/gnttab/freebsd.c +++ b/tools/libs/gnttab/freebsd.c @@ -31,7 +31,7 @@ #include #include -#include +#include #include "private.h" diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c index 5628fd5719..7286c1d4fe 100644 --- a/tools/libs/gnttab/linux.c +++ b/tools/libs/gnttab/linux.c @@ -33,7 +33,7 @@ #include #include -#include +#include #include "private.h" diff --git a/tools/libs/guest/xg_core_arm.c b/tools/libs/guest/xg_core_arm.c index aaabd07558..de30cf0c31 100644 --- a/tools/libs/guest/xg_core_arm.c +++ b/tools/libs/guest/xg_core_arm.c @@ -19,7 +19,7 @@ #include "xc_private.h" #include "xg_core.h" -#include +#include int xc_core_arch_gpfn_may_present(struct xc_core_arch_context *arch_ctxt, diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c index 57f81eb0a0..4542878bbe 100644 --- a/tools/libs/guest/xg_cpuid_x86.c +++ b/tools/libs/guest/xg_cpuid_x86.c @@ -24,7 +24,7 @@ #include #include "xg_private.h" #include -#include +#include enum { #define XEN_CPUFEATURE(name, value) X86_FEATURE_##name = value, diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c index 5e3b76355e..d616dccbd6 100644 --- a/tools/libs/guest/xg_dom_arm.c +++ b/tools/libs/guest/xg_dom_arm.c @@ -21,7 +21,7 @@ #include #include -#include +#include #include "xg_private.h" diff --git a/tools/libs/guest/xg_dom_bzimageloader.c b/tools/libs/guest/xg_dom_bzimageloader.c index 764ddbb43e..c6ee6d83e7 100644 --- a/tools/libs/guest/xg_dom_bzimageloader.c +++ b/tools/libs/guest/xg_dom_bzimageloader.c @@ -34,7 +34,7 @@ #include "xg_private.h" #include "xg_dom_decompress.h" -#include +#include #ifndef __MINIOS__ diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c index 9328fbf804..811d176488 100644 --- a/tools/libs/guest/xg_dom_x86.c +++ b/tools/libs/guest/xg_dom_x86.c @@ -35,7 +35,7 @@ #include #include -#include +#include #include "xg_private.h" #include "xenctrl.h" diff --git a/tools/libs/guest/xg_sr_common.c b/tools/libs/guest/xg_sr_common.c index 17567ab133..7ccdc3b1f6 100644 --- a/tools/libs/guest/xg_sr_common.c +++ b/tools/libs/guest/xg_sr_common.c @@ -2,7 +2,7 @@ #include "xg_sr_common.h" -#include +#include static const char *const dhdr_types[] = { diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index ad982d691a..5244fde623 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -58,7 +58,7 @@ #include #include -#include +#include #include "xentoollog.h" diff --git a/tools/libs/light/libxl_psr.c b/tools/libs/light/libxl_psr.c index 9ced7d1715..712a55a73d 100644 --- a/tools/libs/light/libxl_psr.c +++ b/tools/libs/light/libxl_psr.c @@ -16,7 +16,7 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" -#include +#include #define IA32_QM_CTR_ERROR_MASK (0x3ul << 62) diff --git a/tools/libs/stat/xenstat_linux.c b/tools/libs/stat/xenstat_linux.c index ebcd65f24a..05d0b07553 100644 --- a/tools/libs/stat/xenstat_linux.c +++ b/tools/libs/stat/xenstat_linux.c @@ -30,7 +30,7 @@ #include #include #include -#include +#include #include "xenstat_priv.h" diff --git a/tools/misc/xen-access.c b/tools/misc/xen-access.c index 0731c20b83..4097eebe6f 100644 --- a/tools/misc/xen-access.c +++ b/tools/misc/xen-access.c @@ -43,7 +43,7 @@ #include #include -#include +#include #if defined(__arm__) || defined(__aarch64__) #include diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index 3ab820571d..8cf6a5ecfe 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -10,7 +10,7 @@ #include #include -#include +#include static uint32_t nr_features; diff --git a/tools/misc/xen-diag.c b/tools/misc/xen-diag.c index 4778914820..cd0c2c1fc6 100644 --- a/tools/misc/xen-diag.c +++ b/tools/misc/xen-diag.c @@ -11,7 +11,7 @@ #include #include -#include +#include static xc_interface *xch; diff --git a/tools/misc/xen-hptool.c b/tools/misc/xen-hptool.c index 7f17f24942..6d6aec8bad 100644 --- a/tools/misc/xen-hptool.c +++ b/tools/misc/xen-hptool.c @@ -5,7 +5,7 @@ #include #include #include -#include +#include static xc_interface *xch; diff --git a/tools/misc/xen-livepatch.c b/tools/misc/xen-livepatch.c index 16a4a47ab7..5bf9d9a32b 100644 --- a/tools/misc/xen-livepatch.c +++ b/tools/misc/xen-livepatch.c @@ -15,7 +15,7 @@ #include #include -#include +#include static xc_interface *xch; diff --git a/tools/misc/xen-mfndump.c b/tools/misc/xen-mfndump.c index 62121bd241..b32c95e262 100644 --- a/tools/misc/xen-mfndump.c +++ b/tools/misc/xen-mfndump.c @@ -8,7 +8,7 @@ #include #include -#include +#include #define M2P_SIZE(_m) ROUNDUP(((_m) * sizeof(xen_pfn_t)), 21) #define is_mapped(pfn_type) (!((pfn_type) & 0x80000000UL)) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 4f8cde690a..1bb6187e56 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -28,7 +28,7 @@ #include #include -#include +#include #define MAX_PKG_RESIDENCIES 12 #define MAX_CORE_RESIDENCIES 8 diff --git a/tools/ocaml/libs/mmap/xenmmap_stubs.c b/tools/ocaml/libs/mmap/xenmmap_stubs.c index d623ad390e..c85b1fcce7 100644 --- a/tools/ocaml/libs/mmap/xenmmap_stubs.c +++ b/tools/ocaml/libs/mmap/xenmmap_stubs.c @@ -21,7 +21,7 @@ #include #include "mmap_stubs.h" -#include +#include #include #include diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index ed1cbafdb4..6ec9ed6d1e 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -33,7 +33,7 @@ #define XC_WANT_COMPAT_MAP_FOREIGN_API #include #include -#include +#include #include "mmap_stubs.h" diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c index cfb2734a99..224671bc02 100644 --- a/tools/python/xen/lowlevel/xc/xc.c +++ b/tools/python/xen/lowlevel/xc/xc.c @@ -22,7 +22,7 @@ #include #include -#include +#include /* Needed for Python versions earlier than 2.3. */ #ifndef PyMODINIT_FUNC diff --git a/tools/tests/cpu-policy/test-cpu-policy.c b/tools/tests/cpu-policy/test-cpu-policy.c index ed450a0997..d3f24fd6d2 100644 --- a/tools/tests/cpu-policy/test-cpu-policy.c +++ b/tools/tests/cpu-policy/test-cpu-policy.c @@ -7,7 +7,7 @@ #include #include -#include +#include #include #include #include diff --git a/tools/tests/paging-mempool/test-paging-mempool.c b/tools/tests/paging-mempool/test-paging-mempool.c index b2dfe9b074..1ebc13455a 100644 --- a/tools/tests/paging-mempool/test-paging-mempool.c +++ b/tools/tests/paging-mempool/test-paging-mempool.c @@ -8,7 +8,7 @@ #include #include #include -#include +#include static unsigned int nr_failures; #define fail(fmt, ...) \ diff --git a/tools/tests/resource/test-resource.c b/tools/tests/resource/test-resource.c index 0a950072f9..7ae88ea348 100644 --- a/tools/tests/resource/test-resource.c +++ b/tools/tests/resource/test-resource.c @@ -7,7 +7,7 @@ #include #include #include -#include +#include static unsigned int nr_failures; #define fail(fmt, ...) \ diff --git a/tools/tests/tsx/test-tsx.c b/tools/tests/tsx/test-tsx.c index f11e8c54e0..d6d98c299b 100644 --- a/tools/tests/tsx/test-tsx.c +++ b/tools/tests/tsx/test-tsx.c @@ -28,7 +28,7 @@ #include #include -#include +#include #include "xg_private.h" diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index b022cc0eab..dfeb10f74e 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -24,7 +24,7 @@ #include "hpet.h" -#include +#include #define NR_CPUS 8 diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h index 18ae40d017..46d4e43cea 100644 --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -39,7 +39,7 @@ #include #include -#include +#include #define BUG() abort() #define ASSERT assert diff --git a/tools/tests/xenstore/test-xenstore.c b/tools/tests/xenstore/test-xenstore.c index d3574b3fa2..d491dac53b 100644 --- a/tools/tests/xenstore/test-xenstore.c +++ b/tools/tests/xenstore/test-xenstore.c @@ -31,7 +31,7 @@ #include #include -#include +#include #define TEST_PATH "xenstore-test" #define WRITE_BUFFERS_N 10 diff --git a/tools/xenstore/utils.h b/tools/xenstore/utils.h index 9d012b97c1..028ecb9d7a 100644 --- a/tools/xenstore/utils.h +++ b/tools/xenstore/utils.h @@ -5,7 +5,7 @@ #include #include -#include +#include #include "xenstore_lib.h" diff --git a/tools/xentrace/analyze.h b/tools/xentrace/analyze.h index f9d98d8da4..6fefa19639 100644 --- a/tools/xentrace/analyze.h +++ b/tools/xentrace/analyze.h @@ -3,7 +3,7 @@ #include -#include +#include #define TRC_GEN_MAIN 0 #define TRC_SCHED_MAIN 1 diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 35182ca196..ccf4d83584 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -15,7 +15,7 @@ #include #include -#include +#include #include "xl.h" diff --git a/xen/lib/x86/private.h b/xen/lib/x86/private.h index 2d53bd3ced..60bb82a400 100644 --- a/xen/lib/x86/private.h +++ b/xen/lib/x86/private.h @@ -26,7 +26,7 @@ #include #include -#include +#include static inline bool test_bit(unsigned int bit, const void *vaddr) { -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:42:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:42:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502745.774692 (Exim 4.92) (envelope-from ) id 1pWfdi-0003Mu-2A; Mon, 27 Feb 2023 15:42:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502745.774692; Mon, 27 Feb 2023 15:42:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdh-0003Mn-V6; Mon, 27 Feb 2023 15:42:09 +0000 Received: by outflank-mailman (input) for mailman id 502745; Mon, 27 Feb 2023 15:42:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdg-0002o3-Iz for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:42:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ac2dfa5-b6b5-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:42:07 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B14B0219ED; Mon, 27 Feb 2023 15:42:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 763B513912; Mon, 27 Feb 2023 15:42:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6Z+QG0/P/GOaLgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 15:42:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ac2dfa5-b6b5-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677512527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmPvDiKPc8fkjb5bC8ZuNmcnqo6DotzNARfC8zrr0bE=; b=B1Y3ANN2XOIZx+NtezMI3FnOUMphvlhyjY1K7T2VbEO58d5c726lbJ7HoOR8whOw27IPkd m84zhstbNKatlWsxs4tlIeYcgYIVK+H/N1SDUogv7EeKHkFj6S9hjHjizqZsx6k06AasaS 41zvzcF7i/k+uNHIt80d5W4NbG+Dw6Q= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH v2 2/4] tools: add container_of() macro to xen-tools/common-macros.h Date: Mon, 27 Feb 2023 16:41:51 +0100 Message-Id: <20230227154153.31080-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227154153.31080-1-jgross@suse.com> References: <20230227154153.31080-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having 4 identical copies of the definition of a container_of() macro in different tools header files, add that macro to xen-tools/common-macros.h and use that instead. Delete the other copies of that macro. Signed-off-by: Juergen Gross --- There is a similar macro CONTAINER_OF() defined in tools/include/xentoolcore_internal.h, which allows to not only use a type for the 2nd parameter, but a variable, too. I'd like to get rid of that macro as well, but there are lots of use cases especially in libxl. Any thoughts regarding that macro? I could either: - don't touch it at all - enhance container_of() like CONTAINER_OF() and replace all use cases of CONTAINER_OF() with container_of() - replace the few CONTAINER_OF() users outside libxl with container_of() and define CONTAINER_OF() in e.g. libxl_internal.h - replace all CONTAINER_OF() use cases with container_of(), including the change from (.., var, ..) to (.., type, ...). Signed-off-by: Juergen Gross --- tools/include/xen-tools/common-macros.h | 4 ++++ tools/tests/vhpet/emul.h | 3 --- tools/tests/vpci/emul.h | 6 +----- tools/tests/x86_emulator/x86-emulate.h | 5 ----- tools/xenstore/list.h | 6 ++---- 5 files changed, 7 insertions(+), 17 deletions(-) diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h index f39cd96008..3e73b33c91 100644 --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -75,4 +75,8 @@ #define __must_check __attribute__((__warn_unused_result__)) #endif +#define container_of(ptr, type, member) ({ \ + typeof( ((type *)0)->member ) *__mptr = (ptr); \ + (type *)( (char *)__mptr - offsetof(type,member) );}) + #endif /* __XEN_TOOLS_COMMON_MACROS__ */ diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index dfeb10f74e..610641ab0c 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -125,9 +125,6 @@ enum #define max_t(type, x, y) \ ({ type __x = (x); type __y = (y); __x > __y ? __x : __y; }) #define offsetof(t, m) ((unsigned long )&((t *)0)->m) -#define container_of(ptr, type, member) ({ \ - typeof( ((type *)0)->member ) *__mptr = (ptr); \ - (type *)( (char *)__mptr - offsetof(type,member) ); }) struct domain; diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index f03e3a56d1..7169a2ea02 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -27,11 +27,7 @@ #include #include -#define container_of(ptr, type, member) ({ \ - typeof(((type *)0)->member) *mptr = (ptr); \ - \ - (type *)((char *)mptr - offsetof(type, member)); \ -}) +#include #define smp_wmb() #define prefetch(x) __builtin_prefetch(x) diff --git a/tools/tests/x86_emulator/x86-emulate.h b/tools/tests/x86_emulator/x86-emulate.h index 46d4e43cea..1af986f78d 100644 --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -56,11 +56,6 @@ #define cf_check /* No Control Flow Integriy checking */ -#define container_of(ptr, type, member) ({ \ - typeof(((type *)0)->member) *mptr__ = (ptr); \ - (type *)((char *)mptr__ - offsetof(type, member)); \ -}) - #define AC_(n,t) (n##t) #define _AC(n,t) AC_(n,t) diff --git a/tools/xenstore/list.h b/tools/xenstore/list.h index b17d13e0ec..a464a38b61 100644 --- a/tools/xenstore/list.h +++ b/tools/xenstore/list.h @@ -3,6 +3,8 @@ /* Taken from Linux kernel code, but de-kernelized for userspace. */ #include +#include + #undef LIST_HEAD_INIT #undef LIST_HEAD #undef INIT_LIST_HEAD @@ -15,10 +17,6 @@ #define LIST_POISON1 ((void *) 0x00100100) #define LIST_POISON2 ((void *) 0x00200200) -#define container_of(ptr, type, member) ({ \ - typeof( ((type *)0)->member ) *__mptr = (ptr); \ - (type *)( (char *)__mptr - offsetof(type,member) );}) - /* * Simple doubly linked list implementation. * -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:42:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:42:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502747.774701 (Exim 4.92) (envelope-from ) id 1pWfdp-0003ox-Fo; Mon, 27 Feb 2023 15:42:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502747.774701; Mon, 27 Feb 2023 15:42:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdp-0003oq-CY; Mon, 27 Feb 2023 15:42:17 +0000 Received: by outflank-mailman (input) for mailman id 502747; Mon, 27 Feb 2023 15:42:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdn-00034v-KP for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:42:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e1b024a-b6b5-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:42:13 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 54C3E1FD63; Mon, 27 Feb 2023 15:42:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C60C13912; Mon, 27 Feb 2023 15:42:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /XSRBVXP/GOiLgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 15:42:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e1b024a-b6b5-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677512533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B1c6Zfhki+3SKicBGrekaC400lL1q73+u27gT8K2e1I=; b=ToNLji9L1Vcxn1NbOwijP6BP0hp0B0QRVgwFHq1qvKvwqOpH36YtV+L6dl3BlXDhv99iqA eLnLPGBfSCyRjcAmDIKAIL7YybmcAjT/k1QVk24E3bHjjhyyOYHfxQBNmM+jUCtbVDJg91 S0cRYrIrnz8n4GwDFISgh0j5QM/ripA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD Subject: [PATCH v2 3/4] tools: get rid of additional min() and max() definitions Date: Mon, 27 Feb 2023 16:41:52 +0100 Message-Id: <20230227154153.31080-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227154153.31080-1-jgross@suse.com> References: <20230227154153.31080-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Defining min(), min_t(), max() and max_t() at other places than xen-tools/common-macros.h isn't needed, as the definitions in said header can be used instead. Same applies to BUILD_BUG_ON() in hvmloader. Signed-off-by: Juergen Gross --- tools/firmware/hvmloader/util.h | 8 ++------ tools/libs/vchan/init.c | 3 +-- tools/tests/vhpet/emul.h | 11 +---------- tools/tests/vpci/emul.h | 16 ---------------- 4 files changed, 4 insertions(+), 34 deletions(-) diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index 8d95eab28a..e04990ee97 100644 --- a/tools/firmware/hvmloader/util.h +++ b/tools/firmware/hvmloader/util.h @@ -9,6 +9,8 @@ #include #include "e820.h" +#include + /* Request un-prefixed values from errno.h. */ #define XEN_ERRNO(name, value) name = value, enum { @@ -41,12 +43,6 @@ void __assert_failed(const char *assertion, const char *file, int line) void __bug(const char *file, int line) __attribute__((noreturn)); #define BUG() __bug(__FILE__, __LINE__) #define BUG_ON(p) do { if (p) BUG(); } while (0) -#define BUILD_BUG_ON(p) ((void)sizeof(char[1 - 2 * !!(p)])) - -#define min_t(type,x,y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) -#define max_t(type,x,y) \ - ({ type __x = (x); type __y = (y); __x > __y ? __x: __y; }) #define MB(mb) (mb##ULL << 20) #define GB(gb) (gb##ULL << 30) diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98..021e1f29e1 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -45,6 +45,7 @@ #include #include #include +#include #include "vchan.h" @@ -72,8 +73,6 @@ #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) #endif -#define max(a,b) ((a > b) ? a : b) - static int init_gnt_srv(struct libxenvchan *ctrl, int domain) { int pages_left = ctrl->read.order >= PAGE_SHIFT ? 1 << (ctrl->read.order - PAGE_SHIFT) : 0; diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index 610641ab0c..6af880cd43 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -114,16 +114,7 @@ enum TASKLET_SOFTIRQ, NR_COMMON_SOFTIRQS }; -/* - * ..and if you can't take the strict - * types, you can specify one yourself. - * - * Or not use min/max at all, of course. - */ -#define min_t(type, x, y) \ - ({ type __x = (x); type __y = (y); __x < __y ? __x : __y; }) -#define max_t(type, x, y) \ - ({ type __x = (x); type __y = (y); __x > __y ? __x : __y; }) + #define offsetof(t, m) ((unsigned long )&((t *)0)->m) struct domain; diff --git a/tools/tests/vpci/emul.h b/tools/tests/vpci/emul.h index 7169a2ea02..8c5bcadd5f 100644 --- a/tools/tests/vpci/emul.h +++ b/tools/tests/vpci/emul.h @@ -106,22 +106,6 @@ typedef union { #define BUG() assert(0) #define ASSERT_UNREACHABLE() assert(0) -#define min(x, y) ({ \ - const typeof(x) tx = (x); \ - const typeof(y) ty = (y); \ - \ - (void) (&tx == &ty); \ - tx < ty ? tx : ty; \ -}) - -#define max(x, y) ({ \ - const typeof(x) tx = (x); \ - const typeof(y) ty = (y); \ - \ - (void) (&tx == &ty); \ - tx > ty ? tx : ty; \ -}) - #endif /* -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:42:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:42:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502751.774712 (Exim 4.92) (envelope-from ) id 1pWfdt-0004Bx-Nw; Mon, 27 Feb 2023 15:42:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502751.774712; Mon, 27 Feb 2023 15:42:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfdt-0004Bq-KN; Mon, 27 Feb 2023 15:42:21 +0000 Received: by outflank-mailman (input) for mailman id 502751; Mon, 27 Feb 2023 15:42:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfds-00034v-To for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:42:21 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 517cd902-b6b5-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:42:19 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 00CA91FD63; Mon, 27 Feb 2023 15:42:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BFEFC13912; Mon, 27 Feb 2023 15:42:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gfKoLVrP/GOwLgAAMHmgww (envelope-from ); Mon, 27 Feb 2023 15:42:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 517cd902-b6b5-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1677512539; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4YWfk5My0zrpM/pObahciTKOWepQnXUCCFFrc1nZeeQ=; b=YpcS6Y5moX0AY9fwb7/NHlagQD0CqMilkF98tapMM6nsaeTDfo3PuN8aeSqbvO4FnWw/aw yJyJFVRTOCFtWKHphvf+LaqTPWAIFB33Wox6U9pyqk8Fd6i+vY7ofUN88jSBkdR7h0XOxY P84fqA8k4sUG5QYVL1nlmpoKbJ72WWY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD Subject: [PATCH v2 4/4] tools: add offsetof() to xen-tools/common-macros.h Date: Mon, 27 Feb 2023 16:41:53 +0100 Message-Id: <20230227154153.31080-5-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230227154153.31080-1-jgross@suse.com> References: <20230227154153.31080-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of having multiple files defining offsetof(), add the definition to tools/include/xen-tools/common-macros.h. Signed-off-by: Juergen Gross --- tools/firmware/hvmloader/util.h | 3 --- tools/firmware/include/stddef.h | 4 ++-- tools/include/xen-tools/common-macros.h | 4 ++++ tools/libfsimage/Rules.mk | 2 ++ tools/libfsimage/xfs/fsys_xfs.c | 4 +--- tools/libs/vchan/init.c | 4 ---- tools/tests/vhpet/emul.h | 2 -- 7 files changed, 9 insertions(+), 14 deletions(-) diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index e04990ee97..7249773eeb 100644 --- a/tools/firmware/hvmloader/util.h +++ b/tools/firmware/hvmloader/util.h @@ -30,9 +30,6 @@ enum { #define SEL_DATA32 0x0020 #define SEL_CODE64 0x0028 -#undef offsetof -#define offsetof(t, m) ((unsigned long)&((t *)0)->m) - #undef NULL #define NULL ((void*)0) diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h index c7f974608a..0afb426a6d 100644 --- a/tools/firmware/include/stddef.h +++ b/tools/firmware/include/stddef.h @@ -1,10 +1,10 @@ #ifndef _STDDEF_H_ #define _STDDEF_H_ +#include + typedef __SIZE_TYPE__ size_t; #define NULL ((void*)0) -#define offsetof(t, m) __builtin_offsetof(t, m) - #endif diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h index 3e73b33c91..15399e9b88 100644 --- a/tools/include/xen-tools/common-macros.h +++ b/tools/include/xen-tools/common-macros.h @@ -79,4 +79,8 @@ typeof( ((type *)0)->member ) *__mptr = (ptr); \ (type *)( (char *)__mptr - offsetof(type,member) );}) +#ifndef offsetof +#define offsetof(a, b) __builtin_offsetof(a, b) +#endif + #endif /* __XEN_TOOLS_COMMON_MACROS__ */ diff --git a/tools/libfsimage/Rules.mk b/tools/libfsimage/Rules.mk index cf37d6cb0d..85674f2379 100644 --- a/tools/libfsimage/Rules.mk +++ b/tools/libfsimage/Rules.mk @@ -3,6 +3,8 @@ include $(XEN_ROOT)/tools/libfsimage/common.mk FSLIB = fsimage.so TARGETS += $(FSLIB) +CFLAGS += $(CFLAGS_xeninclude) + .PHONY: all all: $(TARGETS) diff --git a/tools/libfsimage/xfs/fsys_xfs.c b/tools/libfsimage/xfs/fsys_xfs.c index d735a88e55..f562daaef0 100644 --- a/tools/libfsimage/xfs/fsys_xfs.c +++ b/tools/libfsimage/xfs/fsys_xfs.c @@ -19,6 +19,7 @@ #include #include "xfs.h" +#include #define MAX_LINK_COUNT 8 @@ -182,9 +183,6 @@ fsb2daddr (xfs_fsblock_t fsbno) (xfs_agblock_t)(fsbno & mask32lo(xfs.agblklog))); } -#undef offsetof -#define offsetof(t,m) ((size_t)&(((t *)0)->m)) - static inline int btroot_maxrecs (fsi_file_t *ffi) { diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 021e1f29e1..ad4cc66d2c 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -69,10 +69,6 @@ #define MAX_RING_SHIFT 20 #define MAX_RING_SIZE (1 << MAX_RING_SHIFT) -#ifndef offsetof -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) -#endif - static int init_gnt_srv(struct libxenvchan *ctrl, int domain) { int pages_left = ctrl->read.order >= PAGE_SHIFT ? 1 << (ctrl->read.order - PAGE_SHIFT) : 0; diff --git a/tools/tests/vhpet/emul.h b/tools/tests/vhpet/emul.h index 6af880cd43..7b3ee88fb5 100644 --- a/tools/tests/vhpet/emul.h +++ b/tools/tests/vhpet/emul.h @@ -115,8 +115,6 @@ enum NR_COMMON_SOFTIRQS }; -#define offsetof(t, m) ((unsigned long )&((t *)0)->m) - struct domain; struct vcpu -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:47:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:47:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502765.774721 (Exim 4.92) (envelope-from ) id 1pWfiN-0005h2-DA; Mon, 27 Feb 2023 15:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502765.774721; Mon, 27 Feb 2023 15:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfiN-0005gv-A5; Mon, 27 Feb 2023 15:46:59 +0000 Received: by outflank-mailman (input) for mailman id 502765; Mon, 27 Feb 2023 15:46:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfiM-0005gp-5J for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:46:58 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2062a.outbound.protection.outlook.com [2a01:111:f400:7e8d::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f35dd334-b6b5-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:46:52 +0100 (CET) Received: from MW2PR2101CA0030.namprd21.prod.outlook.com (2603:10b6:302:1::43) by DS7PR12MB6336.namprd12.prod.outlook.com (2603:10b6:8:93::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 15:46:48 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::c) by MW2PR2101CA0030.outlook.office365.com (2603:10b6:302:1::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.5 via Frontend Transport; Mon, 27 Feb 2023 15:46:48 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 15:46:47 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 27 Feb 2023 09:46:47 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Mon, 27 Feb 2023 09:46:45 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f35dd334-b6b5-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jARA5KDC2DwF8lZzsZjJ3+apjUJyU0EAraMXGG2KZWi2iU1g4PhQVk7i7TxigUtsfLNpgkRAMN4ixcU4sPEv7nifoeZBpNKjFfWVDOTfhrGgB/hxUHlpuaMNgE1J7EFsDUt4HolFCengEwosPLOgSy42qplWTt3onM/KtZVpfDGVPHeK+SQc8m39zP57fcLZH8rnVUS4j0edFFDPDBhCAzarENZn2jkJfBUE3rnMEmm+G/K8ncykjvwE8aW6duAIhvfbJuUyEDGdPgqnnMaUUYrF5zbUY2lTVrzJ752RNDAa0t6AtmMcnRbb7ZFbrArzItdYeRdxjQBHHVHCWM+/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UegLqUVi7X4YGd75r7Ft+ClTUA0e4GIvo53W1Zoz/iw=; b=F4fuOhproJeUDFWs0uG9PaU2pDYdGg9ewe98UjRbqxPzwqBYi8vw4f3nhgULDTubbb0faDKEeZzhKzebA+YHW7MF+u7pFemtxbR474Aml6nniL6D0GWkxukXH6pZB423vI49ke8nqBvDbffHyl70Xgnq0trOGIuE+wfZk3RN4u/gT4enq5q3HXGfWniadjrhu2i49aAT5Yiyg1FYQvvzoPs1TaYeag8rkKfrhLx1A40vHAGlSyP0XnlCQC7Kswat6e7veZHZj32SK8StK//jNrMs+wpcjx16UK2aKZRQAu+RzzgMgIIP0n9S5ZsHdDvAsuH+jJ4wmSJWgYKIbmnelw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UegLqUVi7X4YGd75r7Ft+ClTUA0e4GIvo53W1Zoz/iw=; b=YNy7hgOVGIczd8412k+anQvM5JZhpagzhNqaQRtqlBTINuh67p5Q/sV0aBe7jPCFhXW90zzsEFaSBrQ6It0yAJiZ+gXALwaB4eGQqcbUerA4m//Mr8ldGvsi+QTPqRSi9C2JC2wVtTcIgTWhFh+tETC44VojAwnbdZMkoayZZt8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Mon, 27 Feb 2023 16:46:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> From: Michal Orzel In-Reply-To: <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|DS7PR12MB6336:EE_ X-MS-Office365-Filtering-Correlation-Id: f2c16c5b-639f-40db-1b13-08db18d9d5f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5ipC+LVejiYO2VDW+cDQnf8gIC6wtF3NQqSP8CMFwXGsrjJSzaw9Sa5zjZ5T5tYMSpcBkfcZVsQeNt+L9aBscq9EbcOfJBQovl5GcaqsPDw9vyMeDPNp4ZcxQcyGHWNqhlOXO3LAkV9wvNRKdJlU+0vlOFsDMl0LEWLgxhTSeg02gRGRqkHCpZJWmunagjQbA9M9cCNhxh1dH16gv1R7A4QM71ksB9bG7l1RLe0PgXpwfs3jG2IFHCiJoaB+LC6e0MszMWUdWDsvTCi4KmedDwIn00vzuOPnHFCybeFq+GRpZ60YkEQH/DkAW/Nr+5kvghbeIDPqiot5/rlFOjW9P/J1FCu9Mj5haoQaeiYnYYc7uholhh11N+/mWXfYed3YCJXi81iAsFPlHYHDOYrsybOEiCGwViqjY8DcT4reT3sbZKgjvZybtfC/cRrgJ6WIvI9n/ruok7WT98Hm8lDT+4P+/55UZVkxlzUBPIQ63G78TpUou4eL3z3bGZkageYd76y2o7P2kUdvaYonBkthOI7v5IBBwH4ESxyUnGk09n0NYU2JRCe9PoGXHLirwq+XbDnnp6ot4/CzcVnEx4jZVKniMRQ/4guMdDmCGRAxYyO3l0JeXlyjC9abcEPYY3lXjywYgVhTABoUdeBgIcvpiYnDku73OPaHylFudQXtY/XJ98/t/VRajx6xC7IxXjktZTz15LFSMQ7gPRjyALz0QcIVIo/mR8Ai307injmMqN+4dk/JLKmC3LbGErc4vlOYxhpMn/CkKOiRobeXK8+EJA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199018)(46966006)(36840700001)(40470700004)(66899018)(31686004)(47076005)(336012)(426003)(83380400001)(2906002)(36756003)(31696002)(44832011)(86362001)(26005)(41300700001)(54906003)(53546011)(82310400005)(8936002)(478600001)(36860700001)(81166007)(16576012)(186003)(2616005)(356005)(40480700001)(4326008)(5660300002)(8676002)(316002)(40460700003)(6916009)(82740400003)(70206006)(70586007)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:46:47.8271 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2c16c5b-639f-40db-1b13-08db18d9d5f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6336 On 27/02/2023 16:00, Jan Beulich wrote: > > > On 27.02.2023 15:46, Michal Orzel wrote: >> On 27/02/2023 14:54, Jan Beulich wrote: >>> On 27.02.2023 14:41, Michal Orzel wrote: >>>> On 27/02/2023 11:10, Jan Beulich wrote: >>>>> On 27.02.2023 10:53, Michal Orzel wrote: >>>>>> --- a/xen/Makefile >>>>>> +++ b/xen/Makefile >>>>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>> >>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>>>> define all_sources >>>>>> ( find include -type f -name '*.h' -print; \ >>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>> >>>>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>>>> also only be included when selected (or at the very least only when an >>>>> arch might select it, which afaics is possible on x86 only right now). >>>>> >>>>> It would also help if in the description you made explicit that SUBDIRS >>>>> isn't used for anything else (the name, after all, is pretty generic). >>>>> Which actually points at an issue: I suppose the variable would actually >>>>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>>>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>>>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>>>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>>>> has caused crypto to be missing from SUBDIRS. >>>>> >>>> I think what you wrote can be split into 2 parts: the part being a goal of this patch >>>> and the cleanup/improvements that would be beneficial but not related to this patch. >>>> The second part involves more code and there are parts to be discussed: >>>> >>>> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >>>> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >>>> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >>>> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >>>> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >>>> top of the Makefile (thus harder to make sure the linking order is correct). >>>> >>>> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >>>> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >>>> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >>>> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >>>> but for all the existing architectures. >>> >>> I understand that the changes would be more involved, but I disagree with >>> your "two parts" statement: If what I've outlined was already the case, >>> your patch would not even exist (because crypto/ would already be taken >>> care of wherever needed). >>> >>>> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >>>> into account for the tags/csope generation. Would the following change be ok for that purpose? >>>> >>>> diff --git a/xen/Makefile b/xen/Makefile >>>> index 2d55bb9401f4..05bf301bd7ab 100644 >>>> --- a/xen/Makefile >>>> +++ b/xen/Makefile >>>> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>> >>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >>>> + >>>> define all_sources >>>> ( find include -type f -name '*.h' -print; \ >>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>> >>> The fact that, afaict, this won't do is related to the outline I gave. >>> You've referred yourself to need-config. Most if not all of the goals >>> SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. >>> Hence your change above is effectively a no-op, because CONFIG_CRYPTO >>> will simply be unset in the common case. Therefore if an easy change is >>> wanted, the original version of it would be it. An intermediate >>> approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. >>> But neither would preclude the same issue from being introduced again, >>> when a new subdir appears. >> I understand your concerns. However, I cannot see how your suggested changes >> e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. >> They would reduce the repetitions (hence I called them cleanup/improvements) >> but as we want to keep tags,cscope,clean as no-dot-config targets, > > I, for one, didn't take this is a goal (perhaps for clean, but there ... So you would suggest to make these targets (except clean) .config dependent? > >> we would still not be able to use: >> SUBDIRS-$(CONFIG_CRYPTO) += crypto >> and use it in all_sources (because as you pointed out, it will be a no-op). > > ... the problem is obvious to solve, as outlined before). > >> Also, why do we care so much about guarding crypto/ if we take into account >> so many architecture/config dependent files for tags/cscope (e.g. in drivers, >> lib/x86, etc.)? > > Good question, which I'm afraid I have to answer with asking back: > >> If these are no-dot-config targets, then we should take everything, apart >> from really big directories like arch/ ones. > > Why is arch/ other than arch/$(TARGET_ARCH) to be ignored? And if it is, > why would crypto, used by only x86, not be ignored? As always I'd prefer > firm rules, not arbitrary and/or fuzzy boundaries. > > Furthermore, considering e.g. cscope: Personally I view it as actively > wrong to constrain it to just one arch. That'll lead to mistakes as > soon as you want to make any cross-arch or even tree-wide change. Hence > it would probably want treating just like clean. I can't comment on the > various tags (case-insensitive) goals, as I don't know what they're > about. The useful thing about generating tags/cscope per-arch is that you can limit the number of findings. Each symbol leads to one definition and not to multiple ones. But this is still not ideal solution because doing this per-arch and not per-config leads to inconsistency. Also, as you wrote, sometimes it is useful to have all the symbols loaded when doing tree-wide changes. So in ideal world we should have an option to use approach or another. I reckon this is why Linux has a separate script for that which allows to set all-arch/per-arch, config-dependent/config-independent. Anyway, I do not have any ready-made solution for this problem. The only benefit of this patch would be that the symbols for crypto/ would be visible in cscope/tags (TBOOT uses the crypto functions but there are no definitions present which may be suprising for people using ctags). But I can understand if you do not want to take this patch in, due to all the observations above. ~Michal From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:47:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:47:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502766.774732 (Exim 4.92) (envelope-from ) id 1pWfiT-0005xg-Lv; Mon, 27 Feb 2023 15:47:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502766.774732; Mon, 27 Feb 2023 15:47:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfiT-0005xZ-Is; Mon, 27 Feb 2023 15:47:05 +0000 Received: by outflank-mailman (input) for mailman id 502766; Mon, 27 Feb 2023 15:47:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfiR-0005wd-Ps for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:47:03 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060f.outbound.protection.outlook.com [2a01:111:f400:fe02::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9d696f4-b6b5-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:47:02 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8128.eurprd04.prod.outlook.com (2603:10a6:102:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:46:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9d696f4-b6b5-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z0xIqCqE6T+i1NMqLsj1GfS5oudO0IaK6f2NVKvCFYW1xnjZVizm8VlPwhxYn3i7PvpknHkgAp47TS60L6cvew7s1sz/MqNB2yFqzujMai74R0PesnhAuitaXeyLgAIJAWttlpUrnjrsrsu4G6aQBfYsSrlU18y6hwBp8Lg/7JW0LBNxiHoBBrBqe59uSGxQEjTppl+GfH4aIhEfDf+uZYkhTotZGhn3be3ZtqLL2Plp57q/uWdmheM5q0BBIQremue0puU4zgNsYh3w9gXj4vayNmNFsrr9VvCKiI7Lf9I/szyo/NwlNzWQEO7cvFZ85/Qdt1pOJCUG+69Iib7+Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7YbGiYWv+P9C0eRLhAqkKHFJfP7o6o+fdLZsgVcBByc=; b=eF3AhDwYdRGN63XDc163X5gF2Q+vdTx3759ibH6yrNNtzA4LyctCFjXFaXVnJk2OBnMjccPnwW2kg1QLnTPnkf1YhqPeeFGcxuza/9g89IyotaK0mmTzOJfhgZgjSjuLKInAMguMXiNZBoY5mK7dYZ3N0Q22TtsFtgl5kOuqKf+eIa0vdPnS/CevRzXUxHdQrsYDiNFD3awT3jk6tzm7T42aIVcCiFOELfftoP64Bi+23+G+yYs3l4+dkrkwLQusqPKkcVCzyYlO0GXSG4E4t/YnNzTuHObbRDw53roEWp0AQb9+OE4OeQ8k3azMxSpXRqUYj+nR4/969369P5Vi6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7YbGiYWv+P9C0eRLhAqkKHFJfP7o6o+fdLZsgVcBByc=; b=sThRqXb/6mCJ+2g/KPvrHsXz7b/U4O/5wHl1LYTs0+doqwgO9srnSuPrgOcAUnDNyo99ZqjjYveLJS4VnvfTf5fUo4xZSdixf1gZdtA/Kll6irni5IehNUfSaJL03zXpFoaXEXw7JpSIblTPcDIcr1OxZoQkJ+0LNvxlSz2ElXbyzirpRmXH5iZPXM36s+/RUtHXOf+xYWeKIuxSjZYOi01Jv6D2Jc3DDa+qEQokx99eaf9V0gdqomXlTfAOi7AxWICMHdVkPBGQixZS+IszFrFCcZ5uJMcK/x4wE09k1+MlU0AZFXpM1q/uhQTwAtFKOC94heGmyWnX19GhDYmvJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <07780c4a-48ff-9c63-9f73-39d8e272a6bd@suse.com> Date: Mon, 27 Feb 2023 16:46:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 1/4] tools: rename xen-tools/libs.h file to common-macros.h Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Anthony PERARD , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Julien Grall , George Dunlap , xen-devel@lists.xenproject.org References: <20230227154153.31080-1-jgross@suse.com> <20230227154153.31080-2-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230227154153.31080-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8128:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a4e58a7-c81b-4ef0-d0ec-08db18d9dcc9 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rYPcKApRWgNcIbr7jZ3hIoEqRQFTCOWBXWKsVr4BYO370+JebKIr8zQ/d4Elc34a29jB9NMpV2T8ex39Kpzecp/T4UmWCRjeJdKK+GuWG6ygg+z0IGFRGhX584r1VflXeY0lZvoOBwqFj/nrweJk/vkHzs7HgX0ZsdK4Fm9vlqjv+wQhrIUjEjADYEuJz3o78h5OcEoxDA0THdTK5tkhX8KoARo0aFNg2I9qZgjSouIn5KVvB3x6AC6UGNbFVvpME4QVd1rQrkcmPO4MqdA6d1d36kc2S56ZoMdru0L8ThUghh+QVXP4QE4hQMZhxICyP3VXn/AaWAzpYbJzZeqHIKETfvh4ipQACKPvdvHkWuArC2meValN6LqA+CKS1IkYxcK7OHKey59v3tR/OAVSgCT9dOI0UDhr9MiRZUAGW5dnCQWDSRztdQ/qu6egiNXsaOw3guBG+jmnvrliQqPwmCUfKcvSRVb62OPQJKehEJ153gDLGeveuhHm+GTM4e5jZnhRFQyl+k4ktJOoWIjUVs+0L8/C/83YaCVJ1eY3O79imZezI4OAq2ngx7DU5ofJ9/J9CGjvToM0+rUJfNB1/w2LHbrNKEGhDS/DgffKodlIRlPYAj9oYh1dU0ZDJoL4jatoei28iSGY9NmdYJ9YhYTHCbOp/dEGWY2+FnJjpjzR1XgFcKIKYxyhBwc2lhrGhqUft6sIKJm+RO/T0Ouid4vhcvMq9Pf4ZTntzrdQxF8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(39860400002)(376002)(366004)(136003)(451199018)(5660300002)(7416002)(36756003)(4744005)(86362001)(8936002)(6862004)(31696002)(478600001)(2616005)(6486002)(186003)(26005)(53546011)(6512007)(66946007)(66556008)(38100700002)(41300700001)(54906003)(6506007)(66476007)(4326008)(6636002)(8676002)(316002)(37006003)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlgzalBVU3lkZ0xSdTJvcHVBVDdHeitGazVSeXVIN1NETW1WdVFzOTFZN2xa?= =?utf-8?B?djR5UEpnV1hrWkViVXV1UWgxa1dKZGV3Y2hDb0VoVHI5RE1zYXFxTG5PY0lN?= =?utf-8?B?UEJCb1AyS0hRMDRFYlNteWFPZW4wUjN0dUlBc0gzSWVuWDVlYlRuSDkzb01q?= =?utf-8?B?MWgrYjZBd2hRdHlQY0RtSkJDQnZEbTl4OExSbHJkQ0p2SDh0Zzd5RHZ5U1or?= =?utf-8?B?V2pDMDUwY3FCSUJNQWpudjM1R0pGRk05Z0h2WGhDL2E3cVRxdVQzQnpmQml2?= =?utf-8?B?aUpUOEV1UERTdTBuM2p6bDh0RUk1enhnVkJTdU1BK0JiTVg0dUF1TDRBWTdq?= =?utf-8?B?OEw4WXpxNHVnME9GVmp4c3hqNE5DUnJsZVVLVDlVTHZhaDNHRFRnVmdmYXZt?= =?utf-8?B?ekkxNmVzNmJxcDFOT2JOdlcxRmdRT0pCUlVObC9HTnp6WGptc0UzbW9oUnIr?= =?utf-8?B?WFRhaDEva1BncUl4bWg5U0I2SDVLcTRWaVpodzVwcDhUTk9sWHVVSGVWTGlt?= =?utf-8?B?YllUdU82YjhlVkJ6cXkxenM1Zkp0Z1pQM0FLbVRaTE1pcXlaZ0hiK1pBR0s1?= =?utf-8?B?alkrelFGZW4yVUs1QVRpTHZpRHU2WEtuQnk3N095Z2dmVlc5YzBmamNBc0RG?= =?utf-8?B?M0pOOHBTWGtTaU1FdkV2K2pEQlZ4clBRUHVaeXVJZE9MbmRGTkdDa0VGWWJp?= =?utf-8?B?Z2wwVy8zU3l1S2dpcFpOQ3BPaGlxWkJJdzdBZ0wzZWVheEhVWlgrQjBjVU9J?= =?utf-8?B?M2pRNkNQOHpWYXJGanFTMmdTU25GWktVdFA5RldQNWhXZjlvWS9iRHorcXJl?= =?utf-8?B?L2RTUXpVUXhINyt2dzlUazRXMWxDT3p3QkFoWmlkeFpOaUdxUXY2TnFDYjlk?= =?utf-8?B?dS9lZzdIbG1jK3JZQmpRMnFSQ2J4dmVZMW1nMFNmMDhnRDI1MGJwN3NJVXo2?= =?utf-8?B?Tnl0SHBzQ2p0Y3AvcHlYWjZUWjhUZC81MG04NzlNZG9RcFN1Y3FYeTgwcXM0?= =?utf-8?B?SVljTWltTUxiRlNkVTNjL2ZoejZFUHJrSkNqMVY2aFhFbENQeHhWeVFRY0ZV?= =?utf-8?B?OElpUDNTRVFpa05Lb0s4TldmdDE0VTlJNGRZN0p5R1ZQV01sYkVXeC9yWkkr?= =?utf-8?B?dnA1bktWZUdWdkN3bnc4RmFzL1lLRnBpUVBNclhnRHpCcG9LV2hxb1E3blBK?= =?utf-8?B?MHVpWkFCaFhzeGhwZHdnQXl4MGRvY1M2T3k2U09ZbEFacEhNTER2dlNrazN1?= =?utf-8?B?V1R2UnZBcUc3dVQ4Z0xBV0pQWEVDbkQyM2UzQ0hiMmhock9DQzBoQTRCenkz?= =?utf-8?B?ZktXQ05SNHQrekRkbEZod3RyZWFhaGEwTjZnVjRjR1pQWXIzZzdmem9BaVZh?= =?utf-8?B?cWExZDFZdjhWVXludVFRdlRERW5PZDB1d212dkd5YkphZzNxenQ2azlOZzNF?= =?utf-8?B?S3RkMDZTZWNyTjkycWhhSmVrQldZdHN5Tzd2dytub1pYSG5CcDBUSkh1MXpq?= =?utf-8?B?dmN6ckN0OStmWlJpaGc2V1dQRzZwa3QxMWJjcGloSXp0TWNvRmNrR3g4dzRu?= =?utf-8?B?RlNTRFlvQU84R3UvRzI3N1FrWTRFZmdhL3lvVXltcDlPYVB3anE5cFVwNC9y?= =?utf-8?B?OXZacXFhWW4rQjlUM0hrNDR5QVdZeDkvb24zMzh0WGt2elNxcUZSVW1qM0Uz?= =?utf-8?B?SW9QL1R2OGJzZDhFK01Hb1JWOHE5cVR3NU16dHg2YmpGUEtLcWRmdzBxVnQv?= =?utf-8?B?dEZJTUlBMExCM2MyV0pZTWtzdzUrVVZETmFnTjBWUWtqV2pIekhrT2grcG1a?= =?utf-8?B?Z0s4WVB5QStGWFFjOXdHSGRYOHdxYkdpLzQyOEd3YnYzWHB3Y0NucWxnc0h5?= =?utf-8?B?VTEwYnNVNjY5N2Z0ZlREaVJFTm1BYlJUUlc3RjFhckl3NzcwK05rL0xGVCth?= =?utf-8?B?Mm1ZdVdlNGhGMWVmaWVwK2JrNHVINFRpbjNIV01tWjNKZjc4b0lHd2RISWdj?= =?utf-8?B?NmoxQ09hdWlrZk9MU29TZDZtcjhFVkVRellaWEx4NlhXRFBRQTFPSnZaby9t?= =?utf-8?B?Y0dUa05XS3E4V1ZBampOa0ZFVlc0YkxMS01KY1dXQlZyU1FJYk1JeTg1cTVJ?= =?utf-8?Q?c9T8MfIYAXLpcwIQfoyv7MIDp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4e58a7-c81b-4ef0-d0ec-08db18d9dcc9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:46:59.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XimhzQD52w0OcERZGY9lf1s4tG+NX+qhGfLLVGAqjvcDm+AA/nPBvEKoeofZrAEHyd+uKiZOalPL2xDM0xSJlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8128 On 27.02.2023 16:41, Juergen Gross wrote: > --- a/tools/include/xen-tools/libs.h > +++ b/tools/include/xen-tools/common-macros.h > @@ -1,5 +1,13 @@ > -#ifndef __XEN_TOOLS_LIBS__ > -#define __XEN_TOOLS_LIBS__ > +#ifndef __XEN_TOOLS_COMMON_MACROS__ > +#define __XEN_TOOLS_COMMON_MACROS__ > + > +/* > + * Caution: > + * > + * This header must be completely self-contained. There are no external > + * references to variables or functions allowed, as the file might be included > + * for different runtime environments, such as firmware or normal programs. > + */ May I ask to go a tiny step further: s/normal/target and build host/ or something alike? Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:53:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502775.774741 (Exim 4.92) (envelope-from ) id 1pWfon-00085F-IL; Mon, 27 Feb 2023 15:53:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502775.774741; Mon, 27 Feb 2023 15:53:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfon-000858-FP; Mon, 27 Feb 2023 15:53:37 +0000 Received: by outflank-mailman (input) for mailman id 502775; Mon, 27 Feb 2023 15:53:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfol-000850-J2 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:53:35 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe12::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e3fecd58-b6b6-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 16:53:34 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9189.eurprd04.prod.outlook.com (2603:10a6:20b:44c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:53:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:53:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3fecd58-b6b6-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EfZv7X5g+Fv3HOsWTGQYTN0quJ4tdsDOzPYTqqZd/ceK8aut1Eg9uIlfYivtumlN3EgVZS4kvbfE56x0g4ik/dyAthMOrODqH0JfrqJykGJrPcHxwYPpU9Ovc0fuTYrKhCyaW8Ib+ytixogfeFYiePpBNhPag/XbUVEhD0uHKNi55g+8YTYKV0xn5rW679Br5mjhfxiww1xqrWHgwXSlFQ7iRauD8du/ImJtugYhZnmWaADRZqpEgSZGvh3wbL7jWKCxPUElCHPZLCQ9Uy0HO51SrBS32ALZ4D0Or/Hdglo4cb1B3uQMdFXd6gwXMEL7xb+CkIhhmYmRIzS2WUP7cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wVQD94cnUTwXOOQ99Y0VOWY/TTwyQj+vYJVQrzsYpOs=; b=h6fH44AVpKQN8ry2W/k++2ZD6vUX+T/CcfZqgpPjTh1KJKbJflIl7TPTWuk8p2ws5hr8fffRtRwctFO8bJ6PyDc8tB3mlUN8S2kBPW8k+AOX2zGucukprvaxq1PJtulQlegVJv0Vhnl6i3nBxHB0kqT5o9Jp0OtDshtnojwNzmlghLRVbmclBHNsBGGbrW2XSBKrUhWpm+TrhSVE4THSi7VYXUBo3PwbJwCA0im0a3aWvm+lFTCXXBpev8TyPYBMaxAgaY1Eqdm2WHMNC5lJLeHCHakNjUYXqhqcpz0wQYQhqAOXhcV/xx5o/tdRYXOyRWAKqYJpb5ZlHdRrem1AkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wVQD94cnUTwXOOQ99Y0VOWY/TTwyQj+vYJVQrzsYpOs=; b=NPG5bNGDXYPBGZ4HCkc2ivXoyG0L71iB3UbcRrfU6LffiO6pyaM417RvGUwkfNqvYsrcCNtfjR3fUrWuHzDoZP7iWkvWoBh0pUAcUkTe+bw3dN5lKM7UO620iV1s/AIdG7ZGS3gRmW2R3hlph1+hgjhvKm3HX9U/nuMGFRScgId6eoOkeK08T3Z7tU6nsR4KfTbpzS6V0MS7otRsypYvkfNYZ+vZ1M6RwmWcXnojV9ToghgpXHeugOfTi2ix1icFLHPyKU0b9I+8H++FTcUjmbAd1iC11okfh94XR9ftMStscMUQxDOr3UBAfMxOdRkAOpyVXRcXghSH0BQMzFQ31w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8a0a2cb9-17e9-31c3-5876-cdfcc669ddc4@suse.com> Date: Mon, 27 Feb 2023 16:53:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 4/4] tools: add offsetof() to xen-tools/common-macros.h Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <20230227154153.31080-1-jgross@suse.com> <20230227154153.31080-5-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230227154153.31080-5-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB9189:EE_ X-MS-Office365-Filtering-Correlation-Id: fdb37785-ecdc-461f-dec5-08db18dac728 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lVkcxZDKdiqbW0zaUgz9/bWxd1O8ECHZz6iNyg7/JlGINB07hLjSlaenh2h76Fx6M7TU4fesP1PwARbbGNR605YtOlMbkjci4QdHaowUPlHZgSlcb7+xTszDTRVs3brsI6BYhhQ90DGEq5ifnUZeE70WDAd9PUtZOi89IYzyKzaC8gXf1lVbn0YrmpA2XPCtaqVvustrqC89tV3Noq1dCNWcFnm0Of25pEb8aJrECSa3tqjvLYh1ZIv+iEv9sp7olyeMkFiE9ni1QUKJSh/oYFxwBP0IaWo6lABqU3nqGsecwtljKCl66zdke6ABpenIFH3t97RuwSLzqvwWYT2mJmrBiqgS8q7auwz0dhLhs1qELXF8E0AsnE02fSDqB0FwILmFKGsUc6aywPMyYYwBzbtOFxA1qyTpbEi44KzNPp5Vnk1EDgMmtTlHtMwrL1x/4lVV2rywYHuIIjJJA8yTNceFwFOVi2/Ks0JWsO2S9f+DX895XEBsgd2HMVZpzzI3voYfnJ5ewZX1kEP5yRk//kNuQhPvCmb94NkDMzjj9Y6mlKpYgS59OaG2xveLYT0GOYPSmBAmr4SsXwfG8quYBHFDlsL5bFBEJbGaxZVynO0AamIeAA+3WVP1YBH7/8eBZhBq6LY2u1efnZklDd6ZsNarwxYSmd4ssbFFweB6xmdAiCq2eMPp12zFrRFBnsYOIl/OrI0iktNxdgqLBDz5cU7ZaIwEfxeqoGPJI48rons= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199018)(66946007)(2616005)(86362001)(6486002)(37006003)(316002)(66476007)(66556008)(31696002)(36756003)(6636002)(478600001)(54906003)(41300700001)(6506007)(8676002)(26005)(53546011)(6512007)(186003)(4326008)(2906002)(31686004)(38100700002)(8936002)(6862004)(4744005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0xFNGl6TlVEN3UrbCtaUjRXa2R0YlorNEdwdEkvcnlYYmJNNXBpUTByZWRX?= =?utf-8?B?cHZXVDhiTmNCMG8xL1dPZWtCWDhTY2pBR0NsZnZCZVNMNXhvTHZjMXk1UWFt?= =?utf-8?B?T1FadnczQ2d5eHB4dkZnUXlYUjZyc1JQRklHYVhjUWJqVjNZb25aaEZrTDZM?= =?utf-8?B?NDIwYUoxc0JsV2tDNmQxWTIwbDRMc1F5Lytqb04xUzhBdE9FOG1FOTdhckl4?= =?utf-8?B?UTc3UHp3M2Z3TGVIRFh6aVFEM2dGQnRiVERoM0NKYlZHNis4T1BTN1VvTDdM?= =?utf-8?B?aWpOeExkd05RKy9DMU9JV3BHc3JEZUZlQnVkdnRYRk9ycWZCT3YvaHpFby9q?= =?utf-8?B?ZkVXOEl6WDg5R2hkT1NxKzQ3RWE4R1pSbFMybU55dVQxWStnUmk4VkVNNjhx?= =?utf-8?B?SzRPaFd2akl4YzVYbmliOFl0Mi8yTFJpSS8yU3lhMnFYdTZLejNWSnEzWGYv?= =?utf-8?B?bTcvQTV2WFNIcEwvdUdoVzhsejB4TjQ0QzFTNHByQy9KNEVEUmJuTUYwQUgw?= =?utf-8?B?WUpOalVjVXlyRFRoMWJ3U3dZMjI1TTlQMlpjUy83T2lrZlZudWZmQnRiTVRz?= =?utf-8?B?MWgrd3E5VWUvVjJMQnliVE0rM3dLK3RWUzFDY3ltKzJVUUlRbk0zSzlYMEwr?= =?utf-8?B?ZHB2SEc0VUlDR1Jqbk4vdmRXcXVlRU0xY20weU02bjNvQXFvZldVa1o1ZkRj?= =?utf-8?B?ZmNPb1AzS2JKUHJZUklvSE5MbkhZYnEybU51SldBdE4zcTgzNEQxODcrdytK?= =?utf-8?B?K3hXNWxJc2F1MHpQK3JmMS9WU04xWEtDNHZBRjR1dVYyQWErMFZ2MHdGR20v?= =?utf-8?B?SUV3SkJEZ0hLaGpxdktKSGtWblhMck9VU0NXeTJWbHlpeS9LVGMydkNERzRN?= =?utf-8?B?NUlhdUVpUHZuVzFQWnJmYUxBOS84bDhCaHRLclRtOWFXdktMWEUwbXVWakJ6?= =?utf-8?B?Rkc3UFQzY3Bvb2s4aGk2NklKNG5WZzNsVENnNVYycTAxL0EyaFYrQ0E5azVK?= =?utf-8?B?MTRXaFFXS0JkNlZUUVBsVTdpVkxkYU54L3BqTDlGWmphRWlNZ2xNelU2WWdL?= =?utf-8?B?ZkhNODZaZEdhSVZDWHUyUXlwcnFKRGJDck9pdlhhdlFQZ1owZUVZeHFEdG1s?= =?utf-8?B?cnI4TTRNSWVRZU1xeTd0bkdqcWxCTTZlMEZ4MzhmYTRFM0tQZGtFR2hvT1J6?= =?utf-8?B?aUozUkYzWEI4cTJDTlVVRENWZXlkZjJjODUvK0hGUlRVdFMwV0tZdXVTM2RZ?= =?utf-8?B?K2Vrelg1KzNLUGVqWmZHcElGcE9CUlpHc3NJSWJqZ0xmMzRRaUFpWnBLQkV5?= =?utf-8?B?RkJVODladHl5WmpYbVFNQkVNMVhoc3hrbDNKL3NuVDB6WndhUjYyMmZvMnF0?= =?utf-8?B?QkpQaC9lVDEwVktFMnJxcG5lQnQwM0h0bDBaWWtSRlBGNVQzOG15MDNKb1J5?= =?utf-8?B?cmRIMzlIdmw1V05rWElJbUJGUkpSWEhydUFsRDloYjByY3pnZ3dnd3ZIUzJY?= =?utf-8?B?UDRlbUt6b0JIN1lxd3ROSkcrVldieWZYbFdweFFlM0MvYjFyMTdsei9XeS9t?= =?utf-8?B?enJuNFNkKzRrNVRWMHhJMHF0a0NXM2gzRGdxUUxlTWYzejRDUXhmZVFGK1lR?= =?utf-8?B?a0E4d1RIcWIyTHVoTzlIb2FOc2NTaUZaYTFpR01UdnNsU2tpakdVY2lmelQw?= =?utf-8?B?bkdHRkg3azczSWVQY1NxZVNGQ0s1dktJSjdHY0NuRUhsNEQ1Wmhwa2VzV0la?= =?utf-8?B?VE5GZ3dLbXg1MXpTV2MzekN6T2FqRnJKT2ZiVkVTVzA2bi9Rb3BpZEdMcDR5?= =?utf-8?B?WW5mZzdSTHRmNzRyNjVKUlJ5SU8zNW1IbVFFa25EOS9HU3ExMFpVeXJiUlJQ?= =?utf-8?B?ZGhmWlhZVHVSSisxNDhYbHFoa2lqQzQ5S3IwU3JVSmhJYllmWUszclM1QmpV?= =?utf-8?B?bjhvK05zanJ2WThqWjNER2hXcHRvNmJkbFZKeFN1dlROVWJFN2NpdHBtS2FO?= =?utf-8?B?SEJYcXZVdFhqcGxqdjIrbVlIcmtnbWg3QVRPeGFzbVVOOHNDRUZKSTJtOWZi?= =?utf-8?B?RGtoM3dydWJ3TkJ0WjBCUnREa1dvUWtZU0VuRUZYOUdCK2diNXZ5a0tYRk1I?= =?utf-8?Q?TnX+ZPzdYhzfLwyyGjiGa3VSo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdb37785-ecdc-461f-dec5-08db18dac728 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:53:32.7744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8QVb8JbuFbDinh8Tf6rQnYQdc3/IKZRyfFvwsf3KTHyj/8KUBxpZAiKGbfG5yyTDGuALmsj1jz9JuTiMi3UkbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9189 On 27.02.2023 16:41, Juergen Gross wrote: > --- a/tools/firmware/include/stddef.h > +++ b/tools/firmware/include/stddef.h > @@ -1,10 +1,10 @@ > #ifndef _STDDEF_H_ > #define _STDDEF_H_ > > +#include > + > typedef __SIZE_TYPE__ size_t; > > #define NULL ((void*)0) > > -#define offsetof(t, m) __builtin_offsetof(t, m) > - > #endif The C standard is pretty specific about what a header of this name may or (in particular here) may not define. You add much more to the name space than just the replacement offsetof(). If this was a header used by an individual component, this might be fine. But this header is meant to serve all components under firmware/ which care to include it. At present that's hvmloader (which we control, so we can arrange for it to be free of collisions) and rombios (which we do not really control, and which people also may not build routinely anymore). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 15:57:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 15:57:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502779.774751 (Exim 4.92) (envelope-from ) id 1pWfsI-0000H1-15; Mon, 27 Feb 2023 15:57:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502779.774751; Mon, 27 Feb 2023 15:57:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfsH-0000Gp-UH; Mon, 27 Feb 2023 15:57:13 +0000 Received: by outflank-mailman (input) for mailman id 502779; Mon, 27 Feb 2023 15:57:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfsG-0000Gj-QI for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 15:57:12 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on060a.outbound.protection.outlook.com [2a01:111:f400:fe02::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64850661-b6b7-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 16:57:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8240.eurprd04.prod.outlook.com (2603:10a6:102:1c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 15:57:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 15:57:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64850661-b6b7-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hf/uk4NvgnE9PgpQajEL/WG9rwd8tMehaApCQ8UnPi/jj9NrpRLtTFBzDb1D/4R3v3/aFzp+Ye0X8jVoIr501uq/Aq1anFUm00oihaYzipNhAOUrdS+93hYEBvxUSESjxuO+dZ1+VuELpPW2sRuHR3kxJXO2uPMyaPIJQ6TKBhMRphV1rlCY/jOxCk/wl4ivEhySuBQddCUGAuO5oF44L/uoIAf+jFcVY4gnJAnyXTjaq5r552byvxtRYtc53M69ZYVTUlUkT/vyZ+vDumrTDu0TVHg3fJI4GmThbQrs9dLvP6KAYjuMmMFnnM1PCryncfVo9RWWnRsl4YM8Px6CQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vL3JnhR6L2AZnifGyU/UOU3YKEc+mOlXcQYx2vMJA5w=; b=Sua3XsnkeOy4acHLcSFkdXwL21ZuJllFZ/6iepwKrlw0IF89cUSx//PuA0lIECevRu6pz1w8Gq3QhThKB873R7Y6aWw4AbC/q3Qcb5W5YfADR0CFJo9SYjITCQm9We5ViQ+hXyzppDJZNpYalcUKg1blJgundPjrhSfPCSa/jpQxcLFuoootq/jDczuOhEOTOf1w0Cy52+Q1/bxTwtnvmOFX75HeZuMS/a5fFqz2VOSUmG9pGRnAcgdgQChaVaTMwqYoG6ZJQHmdRT0Bcx49WtoBFdZHg9zrZ8wWG/vL+DEkdqv9vyFEvYPzj603R5znWmtkhU4RRojoTKEm7IxfIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vL3JnhR6L2AZnifGyU/UOU3YKEc+mOlXcQYx2vMJA5w=; b=Irmq+p0gweqTs/5euAUICTfP0kaESavSay0+guTBOrsgtTV5jyLX1HRbHCClLdhb5/p/Rzz0Eryt8KdhHX07p2BBQunyOc7fD1gQd85t8EC4eDwZDfdiz4K8oOqVD4mJALJKj1b0KsHx1jCFQS3lEQoCD6fY+e19/xyJOhbWbB4g+ngBeT+buuCRz9PSxRrjHj/R+wInrGo9i/N5W5iC7t0/0+EMUDmMhzwNIfQLZd+oiVPOqioD1ZppGmjz36hSgIgZSvKcZ3SAOb/goBmuPh1NyPuv8hXyC+S8Me9Q39kCao7sE2l77DcnMlEZm8OVh0I+DfPnkiZAnQ1SAe9pyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> Date: Mon, 27 Feb 2023 16:57:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8240:EE_ X-MS-Office365-Filtering-Correlation-Id: b9d0e288-c4ba-44ac-66e0-08db18db4786 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7oJkB35ngaUpLpVgiTNXhpgsirVw/BugUYJyIunv0QLAqJxxMQ8O8o3xQO7g5yUwzgFzX095EuDAPSkgHwbrQnZE5XKChWjCMbINisEtR4+plyuq3v+d6A/McGqfwIX9B5K1xlV+cS6Oj8ja8nBrj9gHEaO1YvHs3otGGSVfXFsUwpv2pQYNhDHRhJ7ZDLVbIVzn73oeOlHH3czJ6WYKKH7ICXD8+w7DoRImOXRNm88lIcFkdlzh92Xq+K6uhqy8G9qan0pwe7yU+ShYOGQuGGw/5KWEJtYemibL94iMRKuwO0KVnLHQYzQL15v/RXcXy3fQjPQiWHSzOoBJ/Y8LOVF0w/Q+syFPzeH+5apvmdyFczbzDQVUV7UU2cak3JL2HP1Tv6ILlp0EMzu37rQad61EMZZ5ap73j2/kQBZqxiTNzhj7zgmMM70gp2U6obaRlLOi7SG3nbr1Y7/HuINTTB3BZnnOTbBT2dZDdnwAMsAGkTAGPiISvlmZfuz6tZcDIV0vW8Z0zK8hraeuXEJd5xdnVpO6218d3DDIKS4DLNp+0oK91/qBVoTd8OEYEVO5MljxBHAiL6clFLNS8QZkGpd/4uVug5GhcXiXDMvT+ca4YAMQx05RrB3qTyUX0VaRXCt8nqdFJsDCKlsmKIeAb66FC9VJKpSnz4fO1Ws4hsdIUAVSSkQQoF/biDfyT1GecyIm2/hh+jFRiVPzfK27CJdVZ8nObAUKFtsWQs+hitY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199018)(478600001)(6486002)(2616005)(66899018)(54906003)(186003)(31686004)(26005)(53546011)(316002)(6512007)(6506007)(6916009)(66556008)(66946007)(66476007)(83380400001)(8676002)(4326008)(41300700001)(5660300002)(8936002)(38100700002)(86362001)(31696002)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0h3aUJvdnczVW80ZzBoOERneUtHOXpoZnpoeHRPQlpId0Nab3Rsd3c3V0xq?= =?utf-8?B?OXp2b0lYRmI0WXlDSTA0SnJJM1NYNlk3QVZUM1A1L2tRRGhvZENRbUZtMmpM?= =?utf-8?B?eDFraDdXa1JYY1BKTXBKZjRSS2hrclJXSzV0TWJ0KzQzS3YrazFXdCttRTIy?= =?utf-8?B?dCsyb0VDQ1BVdzZRMzdFNnB3RlBvVEZwb003Wjk5NW8xWXJGN25BQktGOVdL?= =?utf-8?B?Uk9VbTRSemt0SnVCMmZTaWl1c1JwWTFBMngrbmY1VkprbjBtOVVMTHZvWjlJ?= =?utf-8?B?SHMzb01YbEQ5emd6SjMya0FQaElhVjFRMXRQZ1NjalRHZzk2dDBZRWRnWlU5?= =?utf-8?B?b0tIaFhoblZaOER3QTlma2QvbHJYN25USmczYTYwTTNSUVcySHlMeVFBbHVh?= =?utf-8?B?T3FZak82SVBJVE8xN0VPYzdRWTdPUWtNWmJwdlZZTE9LSDhYQXhqYTA1Y2or?= =?utf-8?B?bmV6NjRFTFF0Undyb01GZXA5SldNQ0xUWGdkbEw4MWlEM1RGRzRTUjl6bTNl?= =?utf-8?B?QXVDdlBPWitWai93OXVUQ2NPQVRrNFlYWFh6bUdqR0NrS0o2ZkNJQTN3RERm?= =?utf-8?B?NmthK3Qxa2pzMzdvTDlwR2pOS2lQUjJpNVhmRGd0T0ozRW5yNFllTkZKam1w?= =?utf-8?B?MUc2RmZRY252b2w2OU5Qc2JPUk11VnFzZmlVMEpnQXcrN09GZ0R0a2N2YTla?= =?utf-8?B?dXpFNzVrQml5c2NmTlVyVDV5RkpyUjZkeHBGSjcwUDFOL2htQ3BhbFl0QlIr?= =?utf-8?B?QmF0QTQwOTJRcStDTVIvUkFHbWlnZ3ZMc29PajBOWm56eGpnZ3FMQ2VDdThj?= =?utf-8?B?djlGNE9mdTk1U1kwM2lMNXZ3dUFQbTNtTG9MQkJVTTY5dXZrbTNqMUV4RDBS?= =?utf-8?B?OUhLOG15MmNiSjVYQXo2M2ppSDBNYWYzd2xVZ1dnR08xSzZIdU9oTWE2cFZK?= =?utf-8?B?S2E2YXRuU0MyTytPY0FTNE5VTlNCczFHbnEyT3k4dFplZHI2Sy9zcUdTZzRj?= =?utf-8?B?Y1JqMjlVN05nZEV6alkrWU55Y3NLT1E3K3prbjNpRzc5YWEzUTBsRHNnWW9q?= =?utf-8?B?YkpvVUpjR3UrMnYwMXcxNUY1MW1ZVGlkMVFKaU5XUk9nSGhZc1k4NzdNVWxM?= =?utf-8?B?SHJLZFdkcVZsVUxMMDgxd3haSkR6S3N2dHhCejNhVWtsbTF6RWN2QjdSWUEw?= =?utf-8?B?OFppNmpqNmd4US9DdkJheFpWbit6SXZGNkRDbThVRXZLTi9SOHRjcHpKOEJH?= =?utf-8?B?K0tGQlJzQ05vNnlnZytjVktVajFBQnJDWlNqa1JUZ3VEMVdVU3lZMTA1bE1D?= =?utf-8?B?ZEJabDZQVVpnOE5STWFNdFRacjdEcW1qMDBkU3lrQkpqL1d4TFZ4ZDFSUnow?= =?utf-8?B?Y1V4a1J4ZlZzd0VaaVBVRXp2VlJXd0UzUCtQV2k0MkhmbnRpU250dmZZUFB1?= =?utf-8?B?bzVvckdISkw1cWJVVytNMWdPc0pKcGhESVlWZVdOWGw2dkR2elJkVk1vUEY2?= =?utf-8?B?Mm9ad3JxUEhBTXhyYUMwLzhKREhLeGVyTnpJdGtQNjdpNXRrUzdKM011Rml6?= =?utf-8?B?U2VoaHRtMkw5Z0VtRElEV2pSSDEwbWNkMVFoVVlveld6SzJxOFNDdjJvZFpi?= =?utf-8?B?WUF6MmlMZlBLUjI1ZW1qZnpxUGJ6RGNxY3VIbGl2bWlXUmZ3cHlMUTJkSUlU?= =?utf-8?B?YjM3b3Rkbzk4MFV5V2FLTFBZd2s2Q05Dak9yMDc2ekFCemFGWVRJcDRvRmhS?= =?utf-8?B?VFFMRDg4NG1FdlpoMUtFa285NitldTkrN1NCN3ZDZmxtcFYweVNoQXNTQ1VD?= =?utf-8?B?NCtDTFMzd3hZcm5Ebi9QNEY0dDFLNmlEc3owbGd4aFV3UVBEc1d0TnBMU3Jk?= =?utf-8?B?Q2Z6ZlJpM21DZURidUd0cHJRRmw2T083RjJVRy9jdkNHb2lEQkU2TEZZWXla?= =?utf-8?B?eFN4N2xhZlpOMXBHd1oyM2lnNHNGUFhyR0NlSklHR0JPR08xOGNOcVNXL3Mv?= =?utf-8?B?N3hQc3NTcUUzelZLSjZIUDI1dVdobVVleHFrUyt1bEZEOU5Qd1ZTYmlBenFF?= =?utf-8?B?SWJHWno0MzZwMUlHekYxMmFnNGxEQVdrWVA2MWtnM3VxaUlMa1dyZnpmR1Jj?= =?utf-8?Q?jePzXnWsuOsNKaEU8usTnrx3C?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9d0e288-c4ba-44ac-66e0-08db18db4786 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 15:57:08.1514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zgW20m1+RMWYpLHOZxdpKNmwIW0rcr9pwTZlsBeIis01a2qGnNuniIVyGf089FkBYcGWWtUEymNR4eiIET9YTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8240 On 27.02.2023 16:46, Michal Orzel wrote: > On 27/02/2023 16:00, Jan Beulich wrote: >> On 27.02.2023 15:46, Michal Orzel wrote: >>> On 27/02/2023 14:54, Jan Beulich wrote: >>>> On 27.02.2023 14:41, Michal Orzel wrote: >>>>> On 27/02/2023 11:10, Jan Beulich wrote: >>>>>> On 27.02.2023 10:53, Michal Orzel wrote: >>>>>>> --- a/xen/Makefile >>>>>>> +++ b/xen/Makefile >>>>>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>>> >>>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>>>>> define all_sources >>>>>>> ( find include -type f -name '*.h' -print; \ >>>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>>> >>>>>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>>>>> also only be included when selected (or at the very least only when an >>>>>> arch might select it, which afaics is possible on x86 only right now). >>>>>> >>>>>> It would also help if in the description you made explicit that SUBDIRS >>>>>> isn't used for anything else (the name, after all, is pretty generic). >>>>>> Which actually points at an issue: I suppose the variable would actually >>>>>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>>>>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>>>>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>>>>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>>>>> has caused crypto to be missing from SUBDIRS. >>>>>> >>>>> I think what you wrote can be split into 2 parts: the part being a goal of this patch >>>>> and the cleanup/improvements that would be beneficial but not related to this patch. >>>>> The second part involves more code and there are parts to be discussed: >>>>> >>>>> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >>>>> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >>>>> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >>>>> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >>>>> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >>>>> top of the Makefile (thus harder to make sure the linking order is correct). >>>>> >>>>> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >>>>> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >>>>> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >>>>> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >>>>> but for all the existing architectures. >>>> >>>> I understand that the changes would be more involved, but I disagree with >>>> your "two parts" statement: If what I've outlined was already the case, >>>> your patch would not even exist (because crypto/ would already be taken >>>> care of wherever needed). >>>> >>>>> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >>>>> into account for the tags/csope generation. Would the following change be ok for that purpose? >>>>> >>>>> diff --git a/xen/Makefile b/xen/Makefile >>>>> index 2d55bb9401f4..05bf301bd7ab 100644 >>>>> --- a/xen/Makefile >>>>> +++ b/xen/Makefile >>>>> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>> >>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >>>>> + >>>>> define all_sources >>>>> ( find include -type f -name '*.h' -print; \ >>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>> >>>> The fact that, afaict, this won't do is related to the outline I gave. >>>> You've referred yourself to need-config. Most if not all of the goals >>>> SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. >>>> Hence your change above is effectively a no-op, because CONFIG_CRYPTO >>>> will simply be unset in the common case. Therefore if an easy change is >>>> wanted, the original version of it would be it. An intermediate >>>> approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. >>>> But neither would preclude the same issue from being introduced again, >>>> when a new subdir appears. >>> I understand your concerns. However, I cannot see how your suggested changes >>> e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. >>> They would reduce the repetitions (hence I called them cleanup/improvements) >>> but as we want to keep tags,cscope,clean as no-dot-config targets, >> >> I, for one, didn't take this is a goal (perhaps for clean, but there ... > So you would suggest to make these targets (except clean) .config dependent? > > >> >>> we would still not be able to use: >>> SUBDIRS-$(CONFIG_CRYPTO) += crypto >>> and use it in all_sources (because as you pointed out, it will be a no-op). >> >> ... the problem is obvious to solve, as outlined before). >> >>> Also, why do we care so much about guarding crypto/ if we take into account >>> so many architecture/config dependent files for tags/cscope (e.g. in drivers, >>> lib/x86, etc.)? >> >> Good question, which I'm afraid I have to answer with asking back: >> >>> If these are no-dot-config targets, then we should take everything, apart >>> from really big directories like arch/ ones. >> >> Why is arch/ other than arch/$(TARGET_ARCH) to be ignored? And if it is, >> why would crypto, used by only x86, not be ignored? As always I'd prefer >> firm rules, not arbitrary and/or fuzzy boundaries. >> >> Furthermore, considering e.g. cscope: Personally I view it as actively >> wrong to constrain it to just one arch. That'll lead to mistakes as >> soon as you want to make any cross-arch or even tree-wide change. Hence >> it would probably want treating just like clean. I can't comment on the >> various tags (case-insensitive) goals, as I don't know what they're >> about. > The useful thing about generating tags/cscope per-arch is that you can limit > the number of findings. Each symbol leads to one definition and not to multiple > ones. But this is still not ideal solution because doing this per-arch > and not per-config leads to inconsistency. Also, as you wrote, sometimes it is useful > to have all the symbols loaded when doing tree-wide changes. So in ideal world we should > have an option to use approach or another. I reckon this is why Linux > has a separate script for that which allows to set all-arch/per-arch, config-dependent/config-independent. > > Anyway, I do not have any ready-made solution for this problem. > The only benefit of this patch would be that the symbols for crypto/ would be visible > in cscope/tags (TBOOT uses the crypto functions but there are no definitions present > which may be suprising for people using ctags). > But I can understand if you do not want to take this patch in, due to all the observations above. Well, I'm not outright opposed. But I definitely want to hear another maintainer's view before deciding. Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:00:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:00:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502784.774772 (Exim 4.92) (envelope-from ) id 1pWfvV-0002sG-Rs; Mon, 27 Feb 2023 16:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502784.774772; Mon, 27 Feb 2023 16:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfvV-0002s9-OG; Mon, 27 Feb 2023 16:00:33 +0000 Received: by outflank-mailman (input) for mailman id 502784; Mon, 27 Feb 2023 16:00:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfvU-0002rP-JV for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:00:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1a::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dc863254-b6b7-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 17:00:31 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8384.eurprd04.prod.outlook.com (2603:10a6:20b:3e8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 16:00:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:00:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc863254-b6b7-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TD8AyEayYP/RevqFmyOkFBe+GB/+zG94o9TTiotgr56t6a2h6CQ92sfxnPJaONcZJ9tDAPHySXOoOYDAeLstdKohadaFkOMsdblLxSp7xR2uXOQrgZbrzs4VU/mg7qpUCuPfp4o43D0ZOU4iZUFDeuZLnKOEnQlZgABEU9se9PNuxYXxpXx9sZW/PTos17VI8N800NEhGUSkeun0/ryDuKtzcnZylU7JwJmVnGiF72EVhZfORXP3uX7o7A0syTBLAu2wFVuSvHpGXZl9Fl/1W7BUuxLHnYGPew8WgQB7ZmqCRnHLu+NhELAKiH6zaYYXDC60dOGeZx3ph6scqgqpQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E23m5Vmg+4oyUe+vKWdNsLUd01dKxYwmE6iWbQ5p+rA=; b=XX49h2YlkDL5p/VNr6Pte3Fq1nEUjE0zrw2fExmws/6+QVHJxOqA742lE83LZ8P/DzAOQOW1+CYHsT1LC/CvstLBSOHRn029PfeCMnNGhvT5sIV2VWQmcyq98x7QgSGSKfDJB0X3P4J4vvbtvui8Dljm1Y4+fIWkzRJrwP+TJOvjWNon1UYkoIAWCYWjUYLXqTVvekvF5oFMDLdj5T+l6d7e5uDSLqwJTBtjIN0GJy4KaZkaGPxZp4Oyl8V02A+lOqxuY9VK2jRIb2Vol8bab0Sjvfz5ptmEZxO9LYjBRR0yQ563ocf/fvbu1TxtQSU1l4MJZPhkoKgHgivyYNbD5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E23m5Vmg+4oyUe+vKWdNsLUd01dKxYwmE6iWbQ5p+rA=; b=SsEIcaO2FYvoTiVmspl2+9JJFCMSlrKaAmUzc6MDRO362NGwcqnpqveS/01QO1odTV9gSUW7AAG5JB+GIGWbhN7pn1pqZmM0o9qKwUOpal+gr7xlUx+OxJPm/kru4A5khluR4ksdEJ48rhoj1wCEzVxxfxL+mxDEddWhqXZz8oKU0xL4ht2q4Zk6Pau0L+3Gm2SOaIGRDujvTqAh9LCgrRxCsvM4fZ/lTUBluI4nnjp1viXcyZ5KmxZi18qkgNRO5s8xL3I6qUCYoYyY0gCDU5w4vRIKQ+2mwDmRrpid2uf8K+kb+8SwktZdTxyI0zrnmfNTphFaYSSxZRpqAyjJaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <770b5faa-dec6-f531-7bbb-ec125366f6ca@suse.com> Date: Mon, 27 Feb 2023 17:00:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US From: Jan Beulich To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> In-Reply-To: <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8384:EE_ X-MS-Office365-Filtering-Correlation-Id: 4aa4543a-bfc4-4b54-9de9-08db18dbc000 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D+t3bqGkLNmk+gqGUTWGiOxEDYpcMTPyy4mcGFSPqQsqiMMVCUb8kjL+ZLCFAaZtl+WlyiNt2CipwY1HVYvZyCCTGnN6komcBI7EErkjFxNtOOrkbnBu4+0AzVRV/BG45DsGx0iAiu5a/EDhksx5xi5PomU5HwuiDPip4JFVhKjzJCIKhYam+ReUkAPk2gc7WdhLHp8hZtZIXBefifhfc6i8oL1JKOZr4uHBPexw89/PKlCOd+4lN3+oOB4Y34VmEngwv5kntWBAJByNy9Q3rt01cHg9MoJKvkFQQCTafVZuFh6qJetEqqae7bjGNSFnqXu02t7op1hzzPY3+BvLlnXT6tHdxzJXHYXpu5UnkQZcJVo9g/JrO6k2hgFVM6BagpaUD8I/1nv67nCAKbZK5TRmRoTP8aeby2yxQidQgJhggwfBBBnmRhFlbrlgl7f/WCKvjiQsX488ewywMw0Z/VXFMgw8WXD/ZiqkwsORHS5NtsA+HGzf30RlHz0dO8FT7erO/9WbbMXr2cPNjsDpixkeK3xWaGw7JAzyrpE720Vswhzw4wwIXkGJj6a5Bgctc0pGPPfD6nJpPm0wMv+7u3bg4gVM1YnvyASuJm0slrFVyEICWTMTTcABToEQT8OPom03NKCFkgtCoNxu6K2/FCCvD9PE4altbNpH2E5f3fK0rOS+/ZMgA28g/ZiAFKgQ+OrMQ7fXOHdKLmS7+lN/WDibIWG2CbW1KPbzVjgL7R0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199018)(2906002)(31686004)(8936002)(5660300002)(36756003)(4744005)(66476007)(6916009)(66946007)(54906003)(316002)(86362001)(41300700001)(6486002)(31696002)(4326008)(8676002)(66556008)(478600001)(6512007)(38100700002)(6506007)(53546011)(26005)(186003)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXhENUZzQUQzYVN5bDZUZTZVbmdwdEFDM0V6V1NnMWd4dnZSMEZKTm9HbGU1?= =?utf-8?B?cVplUE1GalU2RTR2MnlrMk44aUV0YkJiTHBhUHBjSDZuMlVHMVVHOG9WRUJh?= =?utf-8?B?N1pESDlsNW10OGlqSnY4RjJuMlRMR0srbTBZWjlCVG9CdDd6S1hPR2tqMnpP?= =?utf-8?B?VERwN2g4bEpIaU5rZ2p0RjR6SktNaVhaQmE5dTlyUjk3WFhJU1dhZEJTMU9q?= =?utf-8?B?SzJMM0k0alZrSXdkUm92SVBCcFE1ZFkzMnJSZEZ0ZzlUZEVZL2NvdDFNL3Yx?= =?utf-8?B?bHAxMGRCUEpidGFFODdjeVlxZzRoTTFNVmQrRjFNRnNoeGdXbnZkYmZMdDNm?= =?utf-8?B?TFc3NGNRZXNjb3lvMmFDNndzZk0xYUNiZ2I4RVhnSEpFWDVtb1lrQTZWOUlr?= =?utf-8?B?WlVsaTJNekNwL29rUzZZS1NCSzVPU0QybVFEZ3I5M0g3YWpKTE5nVGxhck85?= =?utf-8?B?c3BhdTNQaHZKa0M3Ry8zKzE4cGV0SXFiUU5TWk9obHI3UkVJT1FrdnMyTmhU?= =?utf-8?B?Rm84eTUxR3I4OHJyNkNEc3dwQUdyeUZmemROTm1GV0tCVnZKcXJUcUczeEo0?= =?utf-8?B?dkZjVGJhQ2c0RDJhOE9rSFJxTmVlbmRPSlM1WTgrMGs5QlJzOEltZUM3a1NS?= =?utf-8?B?dU9NU0ZMTklQenJ0cW9QRWxBNTFnRm1WbHlUL2VIZ001aWNYZmh2cnN3RHpG?= =?utf-8?B?MFJGRHplWlhhUjU0NWg2NG8wSHY1U1FQMXhnUUg5cm84TVJlbHVkekljdU5N?= =?utf-8?B?NlJ2blJ0SmtKMU91TVlKTnhLcWFmY2M1RjF4dzFPeitFK1ZFTjhhODZFSUxu?= =?utf-8?B?cEsxM3hvUUZzaVg5U09lRTVGTU1GWC9QaG8yZzN5aC9jaFl3STR6V2M4d2Rr?= =?utf-8?B?TnFzL25vRWNFYkZSelhmcDhDLzFBYUtBSWdtajFQWldMRjlXbEg2K0RNcVlh?= =?utf-8?B?VFkwU0JZK2ErYkZ2eGN6dVE1RHAzdlBlMlM1UDlDRGtrR2s5U3J2QllVQVor?= =?utf-8?B?MTIybkVZbUs5dVY4RUg1K2k0OUxMQTdFSUVtTWJTZWJyTmYzVTdvdS9aWDBN?= =?utf-8?B?ZkdoMWJTVWI2M0ZTNjJ0eEJxSHJ6SGRKMC90dElrSGhrYVk5ZjFONktTUVRm?= =?utf-8?B?MTdENGoyN2RjTUtYeVh3enp2dkoxenprKzRGejlDenZTTkY4ZDNZbFZjTS9R?= =?utf-8?B?eGVJQXQzT1cyd1d0MFdiZk13OEQ1cXpDRE4wNlF5M3o1Q3d4MkZrcUdRSDgy?= =?utf-8?B?T0dBeDlSZnd1ZnIrTGt3c3dMZzhXc2FyRnpUTmRWc0MvR3BNMHNDZzBVeWRJ?= =?utf-8?B?cUFuVmxuR3A2S0VKQlFvN1FuK1ZzMlJCT0VIbG1rdW9VSVNEeVVEc3dNNWpi?= =?utf-8?B?RWc1MEhVRkFzTDU0OXk0UkVkWlBFV3JSRmNXcmRuQ2Nlb3NQNUJMTW5SdU01?= =?utf-8?B?RjI4TlBlQVRWa0l6V1BiNDlXVHVLeTJxeE1vR3dPbTRVT2lFRm1CY25xU0w0?= =?utf-8?B?OHJ4bkt2dUJwbHl5cENhL2M3RTQ5TGJEUXBMN3d3UnhPcG9oNWM5UWl5Y0x4?= =?utf-8?B?YWU0UHA5a3RHWXFneTdMQ1NKZ2RPK2E0dnBDZXNQRGF6MlUxYlFjU25SQXRy?= =?utf-8?B?blM0SHNyNE53MG9DUTBtTThnWlFjRC9WY1hYY3pMYjJMa0VFVU43Nkdsckg0?= =?utf-8?B?OFVrbUJEbEg5N2VtZngrZXBydnVRVEtCSXhtZ05zTVVQb2VwVTV0YXdWUUlr?= =?utf-8?B?U092aE1XdW5mZU8wZVdmMitKOXNWV29KRUppUG5yNkFHcGVYeENIUzZpa1Jv?= =?utf-8?B?Wmx3MVArZmFJTmxKYnJlQm9mdWkraFAyR1hwQmhabWVrODBKbDByZTF2b1lO?= =?utf-8?B?SDVLdGZCeXRDeUpkZlU0S1NRcTRQZ0djelZGMVhuOGhXWk9KOGQ4N01JVDFt?= =?utf-8?B?cXlGNlpnMTBPKzllRllqcGNiMzhHM2d5Z3ZBL084dUpMdEVGcC9kK3ZiSjNq?= =?utf-8?B?NEFzNjM4RHoyRUxEbzdVNW8rZkhEeEllSE1VQ2dOd081SU1UbnZ2RDFyaU5a?= =?utf-8?B?ZXdoc0t2UW9kRjJkZk9NQW9GdEhjbEZwd1U3dmdFTnpPN21tL2JuWUd2aGZa?= =?utf-8?Q?632ABewbiTmHUAbIK3z7ZtY/i?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa4543a-bfc4-4b54-9de9-08db18dbc000 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:00:30.2789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mho7R2zZUwpzo9p8MdEnS2SZME9fQogUq4LKuS4vsZeUAekMg2gqm6YVaIUPUV+ncgqksl5pP9igJ31aFO2ZpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8384 On 27.02.2023 16:57, Jan Beulich wrote: > Well, I'm not outright opposed. But I definitely want to hear another > maintainer's view before deciding. Oh, and I should have added: If to be taken, the description would need extending to explain why the simple route is taken here, and why it is deemed okay to consider crypto for as little or as much as is, in the eventual final version, going to be covered in the final version (i.e. in the version as submitted it would want clarifying why it is okay to include for Arm despite being unused there). Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:00:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:00:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502783.774762 (Exim 4.92) (envelope-from ) id 1pWfvM-0002VW-FC; Mon, 27 Feb 2023 16:00:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502783.774762; Mon, 27 Feb 2023 16:00:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfvM-0002VP-By; Mon, 27 Feb 2023 16:00:24 +0000 Received: by outflank-mailman (input) for mailman id 502783; Mon, 27 Feb 2023 16:00:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWfvL-0002VJ-Ei for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:00:23 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d5a3974c-b6b7-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 17:00:21 +0100 (CET) Received: from mail-mw2nam04lp2169.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 11:00:04 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6172.namprd03.prod.outlook.com (2603:10b6:408:101::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 16:00:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:00:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5a3974c-b6b7-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677513621; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=OdOt2fnNbDtBDMpTKBItze1GjIcvpdOsug2CPIU5SRM=; b=AfuzCZiLxvjr9yyYRf8RI0vdqT2Q8U0a0BDIqzRWcduVbk6bVH0+96uB q1459mMRG7Pmpzt83wwjkvtIKd/Bd0tCJlVWBKLVEkpogTU485aj1HzVZ xgynMXdCCHbuiUM0PR4ogPDkSb+RRAiOmOID6teoErTORY6IhYx0TB5KP 8=; X-IronPort-RemoteIP: 104.47.73.169 X-IronPort-MID: 97531915 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LDaJi6DPtXtU7hVW/8Hiw5YqxClBgxIJ4kV8jS/XYbTApDonhTNSz WROUGrSOKmJNDT3co8latjlpkkOsZ+EnN5nQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4GlC4QRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpOQwAUZO9 uAhMjEAVQG4h+jr+5GCRbw57igjBJGD0II3nFhFlW2cKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxuvTm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QwHiiCdtPfFG+3u40jV3LyGoyMl45a1K/r+SIsgmTePsKf iT4/QJr98De7neDRMTnTRS8p3KDoRc0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCA8PGSpDC7OykQJEcDYzMJSU0O5NyLiII+kBPJCMpiGaidj9vpFDW2y DePxAA8jbgOic8A142g4EvKxTmro/DhUQod9gjRGGW/4WtEiJWNYoWp7R3e8qxGJYPBEl2Z5 iFayo6Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBO hC7Vd95jHOLAEaXUA== IronPort-HdrOrdr: A9a23:XeuVv6s3HV4XBdW5SGK4LiLI7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="97531915" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b/DYLAyC0pS3FnpiLvJMsDLuZ3KYPp66huEGhvMM4+8Vzd9qqRwN1uN2IkSvJP+hznrkisQ+M2XFcxDQCjuFT2Q1lNUed+dCSljDZ4ZR2khN5lfrppeI4lba6VlyDXoND9CDiFBQtd030O8eRb4T38WfFRkwo/uoB0aOFjip2qs7GmWmK01oB5OmgSRdhzcLflxGbi+7uEKwcSOPbU9lq5nvboRjIEvvStZLWWCaNGoBH8d7TmkCCqDf/RHJBXl+k1rub2UrZSqswEAlkU3J8g/C0Cx8M+CBRqXFimQi/K2HplgxS+OhFaTFWvyM1e62GHOTEND3YyNlNRvQYjL36g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OdOt2fnNbDtBDMpTKBItze1GjIcvpdOsug2CPIU5SRM=; b=WKd13sJ9W9cwm+ylcMmU5ZwIGxM0U33FmY5cnnFAouhtqXRDvgQ21xbhP+dUZwgJ3jm1LWprmgdgPcaFdA0Bpont40Uo/ItM01SvxlKeEVtllNTo8STAlR5FelIU2I346nWYXcuO4epZARd7YWlxdApFM2oRVH0KYM5ruDHaOgceWQ8OsWXFgHLAOyPAulbE8V+bxy8wMHOual8a6qOQ841t1aTHOEuL/3JjWCKlsxiyXwe9295ga3dRKlvAlL81rqBv/eM1Ylva7/c4LSLXrYs/O8FxtKwkwEldGJuJ1LF+AQzXDjODcQOQRbaC/sWQK6HAcFqnlZdkeyPSyeHxvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OdOt2fnNbDtBDMpTKBItze1GjIcvpdOsug2CPIU5SRM=; b=JbmtbnA+PqqZmEIxfSinvdc2pnEu0E12DqkUKWKMkWHpvIG8BEJkQA49JHAc8O6QWrgIMqcqA8gC+gQquF03lxnUp9LMklIoJL5BnFgUWWgArUji4ZbANX/zxviRlZUQBPcSQtHw24fUZde8x3o7I/KtYKkHuAQrmZm4A3GMERE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 27 Feb 2023 15:59:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 08/14] x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-9-burzalodowa@gmail.com> In-Reply-To: <20230224185010.3692754-9-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0064.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6172:EE_ X-MS-Office365-Filtering-Correlation-Id: a692bbbf-6aaa-4201-9d5b-08db18dbaeff X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7e/16IDnMZ1uTl9KlIRUUOXfaAwnX9AT8khJnBbVaQYEJfqOCn6ilqkB1wijTp8ozCnLvK1yqrCiakZnpJMXbr7pgYm7t54BvjkGGNbeBwlhnGN+fhu4vUpKBBfvjDvAPyoM5wQA/MWGbkaL27TsPkLhMZtDXDNbf/aHTTq2jlr3wRrhF+MC2Q5eC8lTwg7f3LZjJiR2zFtAX0T5CA0ICtCpB8rdGTmr8TqNo/C6m/hJZNAYbhEzIT3l75x6ArmMTEZJviJV7Y3us85R8CVypUgGGLKL+greKLZyfS+34OGkGJ63ME3f47J0Ok+pBN310JFmfxM/UGCVj703Q+Kj0p33BeI4kSGGvovtAKEaInUmaAqr7flR82qI7DsGPgwkmYfEqOcpE8W/Go6yTdBPKtfCo3cuIZZRlIekkQWt+it8RC5ddvu2HNhgySOleSccyIwYn6c2DGW2AdoNfp7KB3pEeuKECCfwD4dtuMJqUuV6cFPEQmYhw6G+cfNrhJu1Ki7hiuLsSVXiQpVeZ97WwutxQi/eCEO77Xf1E0g1w/VWNSIKydumZnoHIjIlSwoEpSP4YntwWUbnXcGoGFprZL9xex2LJdzOvn5t9fYnwM2JLu67i57xZoJ6i+gYFzEeBD1Ola+B/Vn1bNTcVB2ledeyEPEChEo+xYRLH84kggamaCTyMPhPBjPY6KCDKwSBheEAXkj52P7N5scO7pE27Ib81GH7RSmwJkpON7T0z5Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199018)(316002)(82960400001)(2906002)(31686004)(31696002)(36756003)(4744005)(5660300002)(8936002)(86362001)(53546011)(6506007)(6512007)(66946007)(26005)(186003)(66476007)(66556008)(4326008)(8676002)(54906003)(38100700002)(41300700001)(2616005)(478600001)(83380400001)(6486002)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emFVdW44dHM0SzBUK092M0VYeElsVDZwTVJQMmd1b3VMRDRqNUZ6SC9JZG5O?= =?utf-8?B?aDB2T1VRUWFOV0FzQVNzcEZwbDN5VjRGa3B5WXNWellsYXd3eEZpWTMwZDRH?= =?utf-8?B?MGpndThrc0VCRENHZXBwTGlTdzM2anlLMCtsdnl1YWNaQTlwL2NaajlJOFlP?= =?utf-8?B?U045UTR2RVo4SW92WktwV04vaDJOVGlodHZ1NU1YNFFVMjlXOVdIeU5FMkhx?= =?utf-8?B?bU1hUTgzOUZqMldmdEpLQ1JDWTBVRXhRcE5JaGluNU04VHBHQ3RZaGZIL29v?= =?utf-8?B?NUxjTldMNS9tdDZRK1RLUlUvSnRBMEF4UElsTmRrZkh2TlBBbmJDNnE0czBM?= =?utf-8?B?QlNybTRtN3NDT1pLeFhuK0FCbXZrVWw3L3JKWHp3YUxjcUFWTmRTR2k0ZkVh?= =?utf-8?B?YnpjTGJ2dmdYM0tpV2NDanB1a2Zqc0VPanBabE91dmRBQzgzbnJ4VURvWlNr?= =?utf-8?B?blMxY1VQN3ZlMWwvZ05JNlZwdTFZVERmQ3h6TmJZbUFIb2FySHRncjI4cXBF?= =?utf-8?B?RmdjVEd0UmhQUzEvVDBvdG8vYk5FQzFMc3FuT0YyQTg5R0NkNitaczBRM1ZN?= =?utf-8?B?UGw1UTEvR09UM0h6RnUzWS9DVm1sdWxQdVJKRlMzWnNFdUNqWFlEcitLL1pp?= =?utf-8?B?V245QW1ZbUx5a2J3a2NPNTg2NHRqWHY4VFUwdnZPK1k3aTgwbHRLWVlUMFhP?= =?utf-8?B?YU5YeFJia2lyWjdRblY3VzdtdmtyQTFoejc3ZDljSzJyUjAwOEdQclM0WXEw?= =?utf-8?B?clN4bXpOZ0FKc1hoVW5BcUROM2ZzbndpR2dpSHFoeGpWWStIWlA2eHRRTFdv?= =?utf-8?B?TFIwUHozV3FoUENlRFMwbGFFS2pWWE4walVrWjNRTnZmK1FoWSszVHRDUmFS?= =?utf-8?B?aWNkZTdZR1dpa0VSYnBFOHRjREk1eFFidEZiMmEzZEt2WHE2Wkh5a1BwOHJ4?= =?utf-8?B?d29lc282MWUrNEErdXpha1NTMDYrNHlKWmhpTVlzbmpPTjRnbGNPcG15ZzRO?= =?utf-8?B?WnRTZFZ1d1VvMGgxcTdIREdmKythM24ybnM0aDB5dkxIT21xR2lEZnNIL3Mr?= =?utf-8?B?UFFxUkh3Uk1CSVlxbnJLVFJYUjRCZ3hqWjljeEllWmIyZk5XcEp0SXRhekZZ?= =?utf-8?B?ZUdWUXVOdFpxNEdrN28rWWp4blhNaFJZQkgyRmYwUUxDanVabEpJYXlLa0tR?= =?utf-8?B?N1Q1MXY5Q1dkNDRra082QktCWmdzRWpkVkNTTGRnTW5UQUFlTFYzUDJzY1By?= =?utf-8?B?VkdtcGdxV3duVEgxejVmUWVhOE1pZmF3Sk1MeXNvby9aVjBNNUptZmVlZysw?= =?utf-8?B?cDFSdXlDd0JoRzhqZ2doSU5LdzRVb29EUlZNbmlHSDI2Ump2RnI0ZlQ4Qjcr?= =?utf-8?B?SnNUM05iR0ViNUpqNHl6L0xnWkhNVUhmQmU3WXlXbnE0bnNTc3dLYVlHSVNK?= =?utf-8?B?czd1K2JFakN1am05blMxaGxRT3pvMXlZNHBVcnNqTlRLMVZsemdEYWNOQmtN?= =?utf-8?B?aUgxdHR5RWVXRHdCZzdXR05vUkNTdWVBRDRoZklLN3RPSXRzUVlmakYxNS8y?= =?utf-8?B?RzlnaTBRczdTWm52Rk0wczFQcFVXeUIrTzcxSWUvbDVRVHJXRlZzMTZzZWdF?= =?utf-8?B?U2F1K2FtQlV6RUhjSjBEcEtwbmZadHNQV2R0WVpLNEtlMVBId05GQlJ0QU9Z?= =?utf-8?B?R0NxODNHUTNhRnJLbWpEZTM2ZnVZWWRnOWpwL20rR28rYXRxby9kTmloaWls?= =?utf-8?B?TTZIRlJBZkdGVGlKSUJBbG5MWWQzWWgvdkE2UUY3TFc0NjFSTWVnWmVQMGtQ?= =?utf-8?B?QTErdmduK1ZSU0ZBMkMzMVZENDY4eEtSVVcwQ1JBZ01yQTFvcUVIekhQR3V1?= =?utf-8?B?M3ZNY1BvWVJBUDgxaGhmMEliMXl0QjE1a2ZrU0xKOW9NZC83WlhNakhxbW1R?= =?utf-8?B?T2IzSDNRL0VySlE1cFFuUUwreUxZeittbk1nR3lQQUQvRkQxRVVKcDlhV0Iw?= =?utf-8?B?WWYrUW5MRjhrcjFNTG9Nc1pJNDJBVDNHUUplaUs4OEFadmVkNnZOWXFDelpx?= =?utf-8?B?d2tuK01FWWpUUTcyamFZcUJuV2pJM1VDeXEvNGFXS2MzUjhRSWVFMDBpQVVq?= =?utf-8?B?Y0JiK01aTGdHYTlBa1dZelpkUmlCeGp1TmRRT2ZMb0JGWXRPN0hrS1Z1SmtX?= =?utf-8?B?blE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZEcg+AhV2lztC5vqOvDcomCzQ9Z32CcqORdFMSLHohSFLBGnVUgxLG4LzcglGesEdd31XWL8bWiS/zJ9Ezz/iG4017MtB7YKxjKF0xViP8B989v/5P3JmkGVt9BNZw8HjqT8XwHZN4lxHGVXQwByVLS3x++adgD4cNQTPdl0/tFvHbJu+1Zt/tWaQ09nWbY57vQyZT72b2drQ7tFzr1kz2gAf7SuuggmyFA8hmUvtCRbpMcECtx4dEbx5y2dnXvkV4ByqxAFAUlf/EukK106BwlTHU09OvnD9MUEssP1xTPVLlVYyTNBLbauxTfFj/sfbJXGxC1Nc5VCl7OB41JTFo9eL1Zr2qQgO7a28x+QSE3XJm6tFC0iU5BUSA3QVH21KYNWRHErYhSPYEn9Gsd3u1gM2NucL3I0Mg8nsEh8KpBbzGBxC6zt4H0cgRgbZO09VEqnuIN2FktSFcLDwBHsae7I0AC0dDn8mMQNji2ohrDxZ1+2rz1jBIkrtHs7SyZDMbo1xRoC8+o+d81Zy07JWzUZNyQOLLF+kE02SYxqUZdI2Ijj6CLL2DPLeHJ1ydQKT4jpegoPhrs4Xfmw0zCW0+YbJm7M/cfcH3kO6r73xLPwFsN3ZeHQN3RfYTEOYe/+nuvwr3DwFpoBu+qfYoimEY0IML89KLfDXyf+23t9G6H9BRnKhZnV1MBsP6e0GVFakBdM4177uUis2HTK2g+DbTo/oMiUwp5Wvyoduc+uUtuRLT9TjFZSZD9FTJt7omp0fWDybtkcR2DSMMEe5+0Fk9gCS5dKFera8Fi03ZkYs1QOph1dI6UTg7pDYXRu4PNZ4Th72f+nvI4bhKfLdb/9vg9c8dX0BzjiHe5Kvh0U727825oUR8uE8Opjp+q1xpSf X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a692bbbf-6aaa-4201-9d5b-08db18dbaeff X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:00:01.9698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b9Z1lJM/9zGA8PNy/3WIWjob8XFmfNFyHXcYEt+w0qNThwDev9a5oFwxRuS7g1CAldoA8q4IjbX9wfE91rV7/YFwLwcPrPTMEzg//ZdpTcg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6172 On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: > Move vmx_update_debug_state() in vmcs.c because it is used only in this > file and limit its scope to this file by declaring it static and removing > its declaration from vmx.h. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:05:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:05:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502793.774782 (Exim 4.92) (envelope-from ) id 1pWg0a-0003rU-Em; Mon, 27 Feb 2023 16:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502793.774782; Mon, 27 Feb 2023 16:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWg0a-0003rN-C0; Mon, 27 Feb 2023 16:05:48 +0000 Received: by outflank-mailman (input) for mailman id 502793; Mon, 27 Feb 2023 16:05:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWg0Z-0003rH-4t for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:05:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062f.outbound.protection.outlook.com [2a01:111:f400:fe0e::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97e6e38b-b6b8-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 17:05:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7770.eurprd04.prod.outlook.com (2603:10a6:10:1ed::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 16:05:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:05:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97e6e38b-b6b8-11ed-88bb-e56d68cac8db ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DLc6IGC/hiiU13nKGESaSyDezwgDcnpuNFOQ4AM2/3amAripBeonXbQPw1y1y6WtuQv/4wlGGdqxOfA76R5RbrMTV8FU9ytG/mUAfTyFFepqRkQckAsIqHt7HXgsQvi2i+6SaFEFT5iFQVg6xvlr4Z9lwbElLl+cpcIDTn6hkri4c1cooJl7XELA+BMVE2Lynk4zDOAoD7Bx260isHbAXNg2z7PpCtndggwqE9hBaLfpaHiKo9l8exYX2qoVAhqbpdqWkHiTkJV9xN4h24q0aMeP3xvgagI1goDPfnRaEOFgk086sqtULW9p8obsdxR5K8ptwQ++ehaV1WQ0rP4pKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mSloe7PXr4WtUOMrAadpl21PcVK2Xy6Z7hqkFumGLaQ=; b=SrvqHcnBbGWJvln9Cd88I+qEz/GfLabYS3mnlupHfkZtIWKJCDf42WiDuW3w9vMuAm1uY0ffj+2w1RomSsA78ViJmY3/0wXUU3VJZplJyBmp4RMm/9t9Lp/evig88+vjWxB60JszY9cSkVM+Ypv/Nm/6iv81J9cJIY7lY8SLelb3KfiuVfCD+Sv5JkRHTUALXV0iYQYuvEX5DzVZj+3FV/9qCErNRRB9Zx2NgZ2qYCTU2oFMeKxiC+AKBJSutFZfuTIw6zaVXHhDkKPY5Nf3JTPIalyjSxDSpVfRA9WgfomK55GxMymgUll8NvktoQyp9tYdSLvuLfh7bL3oFKenBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSloe7PXr4WtUOMrAadpl21PcVK2Xy6Z7hqkFumGLaQ=; b=tjv8PrW5+MgugYMf0qpGdobU8ztxdnBJ/IXKJV4juzo0897en9tuwcJwBY+nSjcItQjcGENfIMte12pZ5CPyO8/zGGMyjVd3KSlX0OUZw0H4UqmI8/j3bsZJGzdMHXTX8qmZD4RCnGKA7V71DcDtR7BOE2F2/t2waS/gOfx8HhI7GST0c0MY29OyrxNK/U90OI9AMSPOUUvdpR2lYYWm/E+DB4IVqlLuldF/tQB9MPeAQ8SDn5Um4HlifymgPkmyCRYWqSe7gJftrjOd+BG8dyQiJn12Lfkmrsw5bNkKEaZx/kJhdeDX+NCWBYauV1e6soSMfRx/7MKApaIf8BhSkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20713a67-0ba0-37bc-24a2-7bbecd284f44@suse.com> Date: Mon, 27 Feb 2023 17:05:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v5] x86/ucode/AMD: late load the patch on every logical thread Content-Language: en-US To: Sergey Dyasli Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Wei Liu References: <20230223173924.11815-1-sergey.dyasli@citrix.com> From: Jan Beulich In-Reply-To: <20230223173924.11815-1-sergey.dyasli@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7770:EE_ X-MS-Office365-Filtering-Correlation-Id: cdcebc07-6019-4373-087d-08db18dc7ab6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uetvf4ox3OTBPJrx+lhumJA2KegvF6KWwBWFiidNfhEl138KVvvpe1iN5UhPmPZvHxPGPDi+4xJcNtEMcGTPPD6348fhHYl70XBEPAhBhSoKBi/1Yd/2FBiDl+TjQwET+uqWWbAbVtj0dLeefvP4MxNjowzq01xQmb61KO5m9SITo9XTsKUWLW4q7CO2Quh8WkfGmQm6af49vLSamx5EkvST8IgVLwqh2t+26AiMIPG9OIDipGb0UKC81H/r5Dumf5dgIsF+xBHOfsnkOj8+tfUwYewq4/iawAgC5nMfjBtwAnOxmxmmBzFS6efXweb47VXILTtf2kBdN5X08jLkrkLxMeZEZIBbcw3PplpacGseLlXRRN+SljKony55BeUl+k5nA6LYxMx8aVvJDN1xdcCwAckc4vFTyTU0cuAGu4S/sBjnBYPwp6cUTqk1tY38fg9kt5BIMZRxJkJooR2QkXIHIRT/zJSy7PIIC//+OB49I/5/L+gGvc3rViqw96TSGYIP02SoyWB4+I4vt+b7LgrygRUhoM6sratKnyitO+tpXCu8Ts8jM7Qo07p1C7bgsceGO4KW3w7ihf6PcFijkhsxBv5aHlw99TT+ZFs4sH5Xq+QoaevwHIUpHF4bJo+RWLIM1NctOg0d4FK24yvPmd8/KIUUFFOKm00LXXnoFbD6QTM8jvLgQl9INXGeYDJ3z4b5Rg8JGkdGMF6DQHzqEz9UVJbc9TrByMUiwigF8HU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(186003)(26005)(38100700002)(66476007)(66946007)(8936002)(6916009)(41300700001)(4326008)(66556008)(5660300002)(2906002)(6506007)(8676002)(4744005)(2616005)(478600001)(6512007)(53546011)(6486002)(31696002)(36756003)(316002)(86362001)(54906003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0VDVDlTa2N0VFJLdTVTM3QzZmttdkVaY3Z1N1VUeWRrOFFRd1JvckY3TXNJ?= =?utf-8?B?cWtPdWR1SFhmNVBXNk5yaVZ0aGFhN1ZGMHdWb2liSTVNVU9yVVovblR1eFZ1?= =?utf-8?B?N1hObmlzZ2prUkRKdWhXTW1RdHNWUGRqZlExTzhETXpvdnI1ZFlFTmFFbEJQ?= =?utf-8?B?blQ4eVcwUmc0dWFxYWY4RmxzUmJ6QVhQUnkreXI3RnZiaGR0YkVkdUpnTDNL?= =?utf-8?B?c1FWM1g0dm1sNVhJSDVGL1dUdGMwL0twVkRQV21Mc29GcFVoRWZmaXg4Y1RB?= =?utf-8?B?U25lOS8xa3ZVbUhxV0dUdjNBZUcwWkR0cUkwM2tNOWNpcHVmOE9NZEFGYk5z?= =?utf-8?B?MUkrUlZheTFUaWQxWkNCaDRRcExWRUhRaisxa3NJUFl5TDJLdVk4QUVOMWlC?= =?utf-8?B?TTFDc2xTMHFCZUxFNW9TMURNR0pPbTh2K1g3WmU0dFBBL3NZZU5tdlB4UUdY?= =?utf-8?B?T2VwT3M3RGpaS29rZ3FuaHVJT3VEdHhhSS9hSkJIVzgvWTRjVEJSYzJvRWw2?= =?utf-8?B?SExSOVdLV2JBeStydU5kbXhkNkhQTHBwSXVhMm1EMk5zc2I1RTFXTWlpZFdR?= =?utf-8?B?UExsR3RnV1hub0svTHM1TXNZZFBOWkxzVHVvMXBuRXFlNmVURzRBK1J2R2xr?= =?utf-8?B?RmkyNFpVdXFFTy9ucGpmRWZSMzNUaEIwais3TUcvTUVYWGNXMytqNzRORmxK?= =?utf-8?B?dnRiVWlpcjR1S2xldWFEb0VNbUxUU1QwQnA2VUczWFZXRitLek9RTlpyR2hQ?= =?utf-8?B?UkdyQTBObzk4bXFVT1RGazk0QW9iM21SN0RMKzYyWkFuNjQ5eDZDWFdsYzlH?= =?utf-8?B?TzNzUXBwTVRvdWJoMU1PU01ONzN4U2Z1MVZ6YklyOTZRSW1leWpDQ3NVak5W?= =?utf-8?B?OVdKUVNYaVpIVThwQ0JhTEdiaGdEK1QxQlV1dWlvYkVpMmhxbnpWME96MUVR?= =?utf-8?B?dEZ5ejUrVDNrYzJCMUZtaWxjZ3o0N0FHdmE2aU1EV1YyUC9zVks4M20yMEFw?= =?utf-8?B?OHpzL08vbE9XbXJXV2x0UXNHeXpvWHNhU2diZ2RNamc2SUNFOERmSVZuUG9Z?= =?utf-8?B?ZkNKRi9aWFlUeVoveTJYd09WUEJHMmNEOTlJbzM3bGJHZUtkNUZkcTZGcVRB?= =?utf-8?B?bkdibmNCVng5eHlEOFh0eFZFWHE3empzaDZkTzhIQU5ZNUpGc25QbDlLRktD?= =?utf-8?B?OTkyNG43MTZxcDlaQ0RQSytJeHc4dW45T1JRbkFmdnc2UlZHVEwwKzQxMW9h?= =?utf-8?B?VkNHeldmM050UTFiR3NXZVBPMXNQa2RMQkNLNVViOTdocUtRZlhQOE1HT0ll?= =?utf-8?B?cHhac2pLMzJaY2ZuaUdWYm13b1I0dzdGS0I3RGZ2RzJhem1GekQ5Z2VpRVY5?= =?utf-8?B?MWJxU1l5bjdJQVBQbkNtdnRBRFBGZUwzVnNPck1kbHN5QjJSaWJMTU1WWkJt?= =?utf-8?B?ei9vK0lKU2gzakh1eFRGd3hSWml4d2k0MTNkUk92OVpZZ0R3MjZtcUNoSVps?= =?utf-8?B?ZW5mUzJBMWlzY0VmUWNwOHFMYTh4NzFoUGpyQUtmUUdCZE1tKytjRzBNUEFD?= =?utf-8?B?bzdCZWprUXdNYm1IZlZkYzNGODYvSnRuNjFBWDNYdldIK1FubFdvUlFaS0tr?= =?utf-8?B?azlWdUtTZDZjdkRtRHdjcEZWb3k1L1dNRzl5TFN3L3JITGVKZnV4WDQ1czFq?= =?utf-8?B?eU5BWTZVVVdiUXZJaDNQOHB6K2dMN2Zyb2lYWm9DeERMWnNKWm9TRC9OT2dG?= =?utf-8?B?NENCRzJDbUhqUU9NeStTZkp0dDg5M04vN3JnVWtWc3B3TWZrWjQzbDNEb3Uw?= =?utf-8?B?V1VObkhGdmZlZno0WFNuVXZVQm5BNERIenh2SDc1U3NGVWxRTnFkTnh3bkFH?= =?utf-8?B?YkdaRXpBNXVmUTRYcDg0VXBlcDJad3lZUlhzVHFQby9WT0U5RnZvL0VSRkhz?= =?utf-8?B?TmIwc1ludmZhMzJuWlB6dWxDeDRxSTFVN0JBOGZHU2NxODUxTGc0WGF3cW1R?= =?utf-8?B?c201V3VWeklKcXpWK3pSckRTbjVzS1NpTkhWdVUvb2xiaDZPSmlNSzdCcnZz?= =?utf-8?B?bkJveUkxRWthaVhBSXAzNTN5clZHTVRydjZyQXZCZzJqQlhZL0dkdk90cmRn?= =?utf-8?Q?atxIkgbVOm9UWrbhY4rPX90BX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdcebc07-6019-4373-087d-08db18dc7ab6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:05:43.5710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LYWc3/d/dgK43xpCMAXI5CSGcP8q8XoDSqEsdERGwIfgyH00dAm2+kR4kR7fGr+Qt5xzPZHMZ3gr1T9CtfVehQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7770 On 23.02.2023 18:39, Sergey Dyasli wrote: > Currently late ucode loading is performed only on the first core of CPU > siblings. But according to the latest recommendation from AMD, late > ucode loading should happen on every logical thread/core on AMD CPUs. > > To achieve that, introduce is_cpu_primary() helper which will consider > every logical cpu as "primary" when running on AMD CPUs. Also include > Hygon in the check for future-proofing. > > Signed-off-by: Sergey Dyasli Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:24:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:24:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502802.774792 (Exim 4.92) (envelope-from ) id 1pWgI7-000743-RI; Mon, 27 Feb 2023 16:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502802.774792; Mon, 27 Feb 2023 16:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgI7-00073w-Oi; Mon, 27 Feb 2023 16:23:55 +0000 Received: by outflank-mailman (input) for mailman id 502802; Mon, 27 Feb 2023 16:23:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgI5-00073q-Sj for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:23:54 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1dee41cd-b6bb-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 17:23:51 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 3062B5C00D5; Mon, 27 Feb 2023 11:23:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 27 Feb 2023 11:23:49 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Feb 2023 11:23:46 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dee41cd-b6bb-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677515029; x= 1677601429; bh=TT98fbPrsAnVgTTz/U2A9TwwJ3y9+jei+vvXNtF5ooI=; b=g nnoenF7mnMgy2S84lpP+RGMzzkDDPJwqVKi2XhFNv9/mzZyDdWnQRIVJeF+9xLsj JaPO0DRCExIoa6W40ELMGX2xx4QlocqUsoUrBoRW1ASEjjUDJV5lhL+bHCnb0V/q lMKVVFuTGHlcF28KlzLs31tc/5Kb71i43Yex1B+xDOkzas/sD4nYkh4ZgJXcqSyX Hkv0eR8ywjubxTEm7tGfoc1LPRT8SHPLxYt4/gCC6Z6HyXGZ/OElEohsxiAjC46b CJTZOFAvxuprQdri3ODZ3RAJkrbMBNBdMwmkTXNWAAiJddpwjZQX2oYhiUzVqd1b 9YrHBkJ1HN6slQMPlH3VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677515029; x=1677601429; bh=TT98fbPrsAnVgTTz/U2A9TwwJ3y9 +jei+vvXNtF5ooI=; b=lkCNkY+GzcPOxmC/UAzhRoNN8lCQQirbG6vD0PK67Bag n+wAs2frXwumVTfUoH8zkl6DFSJnkm71XM1xFlwCiLQBhnZO3sAEmASepZrsgoLK MGU4EH4YQ3EZKYwGd9MyR7Weo5WtnTeMG9jhQXlbVVzSKoLYRuCVsOt9woFd3glY KNAtbWkpVfWNRbRcni9K2T4izgbh0UnvNhCffh5ur7B44oBy2VstGZwSTsBAhp7N pIrSxBi048xYJd5jvi60ANeB5OK/aGmpzdhfKx23TipeWW2eVkUhBIwWZnoh1XsS Tcx1MgOt5injwpJzopxqkUpMRzYkUOAk0fiddry+dg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeltddgkeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 27 Feb 2023 17:23:43 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , Julien Grall , George Dunlap Subject: Re: [PATCH v2 1/4] tools: rename xen-tools/libs.h file to common-macros.h Message-ID: References: <20230227154153.31080-1-jgross@suse.com> <20230227154153.31080-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6PMJ75IG6KqTb/H3" Content-Disposition: inline In-Reply-To: <20230227154153.31080-2-jgross@suse.com> --6PMJ75IG6KqTb/H3 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Feb 2023 17:23:43 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , Julien Grall , George Dunlap Subject: Re: [PATCH v2 1/4] tools: rename xen-tools/libs.h file to common-macros.h On Mon, Feb 27, 2023 at 04:41:50PM +0100, Juergen Gross wrote: > In order to better reflect the contents of the header and to make it > more appropriate to use it for different runtime environments like > programs, libraries, and firmware, rename the libs.h include file to > common-macros.h. Additionally ad a comment pointing out the need to be > self-contained. >=20 > Suggested-by: Andrew Cooper > Signed-off-by: Juergen Gross > --- > V2: > - new patch > --- For this (assuming header rename itself will be acked): > tools/python/xen/lowlevel/xc/xc.c | 2 +- Acked-by: Marek Marczykowski-G=C3=B3recki --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --6PMJ75IG6KqTb/H3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmP82Q8ACgkQ24/THMrX 1yy1bAf+N1xPbmUjnZ3RvdvXrrZ01d5p92WNW8nmd8/V6lR86RiU99LrfFTpIah3 tRqSsqxUjGxFVEpMju/Un7abBfK1pJ4n7Qy/Lri5vdRiL8qVQvUG/E3dVCLUVv8r hIGXqqF5iF9Am32hOM26cZj4VrxvuMoiI1+Sn3RHA7nM634dR7cX7qfxmHqdnL6S ouII4lDBeCJqi50QFEtXsb2JR6qAJtO0l/cetAoNRb/IIRSZURGIP7fkXnxyf6GG VhbsXZ8QcZ9rAghbbH9SBqIzvxyuv6uBwcJmIFODQtc6PepMcrJjiRFiAgDUD++x 3/YMnNNNRL6sCF2yVLcHMoiryLVRbQ== =cJ0k -----END PGP SIGNATURE----- --6PMJ75IG6KqTb/H3-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:26:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:26:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502808.774803 (Exim 4.92) (envelope-from ) id 1pWgKN-0007fJ-8h; Mon, 27 Feb 2023 16:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502808.774803; Mon, 27 Feb 2023 16:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgKN-0007fC-4K; Mon, 27 Feb 2023 16:26:15 +0000 Received: by outflank-mailman (input) for mailman id 502808; Mon, 27 Feb 2023 16:26:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgKL-0007f4-Td for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:26:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71d24385-b6bb-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 17:26:12 +0100 (CET) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 11:26:08 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5074.namprd03.prod.outlook.com (2603:10b6:408:78::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 16:26:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:26:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71d24385-b6bb-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677515171; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=huTvSwUKfOwTf7t8DEP9EfMBDbC7pL9uxHpeZTUXJPE=; b=TlDkiIi+JR5segb44DHz/6DbI34ok5OzRbNGZpWLT+iH8iZ+4JG18nuW QhB3wlVcjGmkdjb91Fm5S2Ltq5uLnFYoJzsF2u/D1ejz8wC+xmudLGdaX orTSOQx4zWBzvV/TjOLZQXAppXq1LrTi+jQE77nce74DWHnLeyl0G9GmZ Q=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 97536623 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Yw9Q3qPELVKnOXTvrR1LlsFynXyQoLVcMsEvi/4bfWQNrUoj1WYOz DRLXGyDM62IMGf2edF1bNzi90gGsJDUy9I1HQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tC5ANmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vowKFxrr fMZExIyKSjdldyz7ZzgbOY506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzG7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QwHilBthJfFG+3vd4qQSy9mwWMx4bBGu9ndXntnG8UOsKf iT4/QJr98De7neDRMTnTRS8p3KDoRc0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCA8PGSpDC7OykQJEcDYzMJSU0O5NyLiII+kBPJCMpiGaidj9vpFDW2y DePxAA8jbgOic8A142g4EvKxTmro/DhUQod9gjRGGW/4WtEiJWNYoWp7R3e8qxGJYPAFF2Z5 iBYwo6Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBO yc/ZSs5CEdvAUaX IronPort-HdrOrdr: A9a23:bL3YvaB2NzBtDCvlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="97536623" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKQhWDUkIQw2EoWPe0A7EC76Q/DIdMshT1d6mpA5vXfB8xAwe5wMkOcc3A8Z1qBGQzr2/4FbP/iM8HGCWzz6Y2/qsAkaz0ULPxuZWGgwGHD2SxiCjjejGqN/UG8/2SnveF5epxVkV2AyNr7OC4gLT9tOZi4aCoLmX8cSsRGQuHKimZGAqhzXB4cD/22wldAQjNG54Hh1jYdV70FuiN/VKV30vidZprBjtyieznPjlj7EI07JAMGQU2neQu+Mp+b7uZpPlIZQlwWuNlFqxfHVkBYXsZcG0M4PowX8x0ajrSMVxvos0IAAoOLQFNhFsSkJlABD+oMAWM4ZckO8gW+Q2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=huTvSwUKfOwTf7t8DEP9EfMBDbC7pL9uxHpeZTUXJPE=; b=R5FLQP+476DaAG25OqOn4ZovNGibD1ve42OPY9Ao20IEThAHZCIymqPUzI1f9m32mvzJVbJEeaFTRq2JdrZobdPPEvhjjqX1wMI+Lx3O71qrTXuueMwAhdahpR+15SJP2Pan9+Ck0voD7PMT7ZEJ+PtrWRxNofnPLvRRv95T7H4fEuLFXjJYb7tBfDbRid3xpXk/qrKvx2EY4LrvMmdFwb43mCbI20BwPfc/dF7q4f4beDEAI71CuWU2Nclh+CSXU9oyxOaRWBzuSCD6kk+g+TD2amDu/Kjkxa62Lqg3kFqDZ2ULk8XDVNudnoPaFnUeDlgeRQbQ+jhU/HSViH8qYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=huTvSwUKfOwTf7t8DEP9EfMBDbC7pL9uxHpeZTUXJPE=; b=mc4zJMyTThv+ppY/cmXagWQ9m2jIpT74tXvUSCsxpVYJro1SQTWlO9Ajay2KyDIrfZxc8AevopiT6mF5vgRRhLSa8dll1Y28peIm+A7a9a3oAX8IeSOgCvDaQBEFAnVDrdZRNeepEkMwRwx9nb+NRF47A709P8IfZa+eP8F58Mw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <12849cea-58af-e13f-89ab-a7e9d4200df8@citrix.com> Date: Mon, 27 Feb 2023 16:26:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-GB To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> In-Reply-To: <20230224185010.3692754-11-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0477.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN8PR03MB5074:EE_ X-MS-Office365-Filtering-Correlation-Id: d7c9e842-454d-47dd-3dc3-08db18df53dd X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C8IEXWdR1uCxC0FBFHlWDIZhCgk0C8Sqdr2XGXl117gzS8+L/aTQolV2SjMRmRpzpykzIssddPmW6rV4XjCn6UMsUg4ppkpdA+7HV6nS1MapcJ6pwTTfBulJJsgM4eMFXGnXo6SnghAALsc8iI72cW1jhFDXxL1U5rNtrl2MwYPo6CuuB55xJ7svvublB/OUcUbpdxQ7esv3btu92yvKvLtVJ0rXjeO8m+rRqxmLsLTSroLA4yVWsh4d3XgyH9ek5sNifedFU777GfJikYPjdL2vzKKR+U+TbZ9+xbB5MPPTVWSiOKEUn/01nwee342hMGvavhtwf2WfZtM7MfaKnRZUfvGkivQIzHDhJ9dJHTaJw6xImvBSmA66WuE9vNez6qeKtsjl+0F5AJBo7TMsggL3lWvmzgucqLJ6Y99i2WhO0vceT1gTWO6NLtJKCfEAdP7XEccG+nXeAQG+7noPRhVF2vsvxSp7mQB16j/tYz7N6C9gHIMzIRF8DEHPy85TUlzvDMSBZpi8xUvPy1v8jTLm6UqznRLiOELPClGXovUuW65TxVvgxiobnX7bR8D3WZh82au7MVgTyIpJBDYGbsnpcR7Kjb09FR67Zz0iKNqXFZx4dW95vbBt2I83pD6m2PvdwsC+zk6izd35ReQPdMyiwF4/Sbsf6V+hc+CL2mTbmvy+dlGKAW8XcvgZfjFvr04sMFmP8BgYZYK188/wY4RwvTMqLw7+Wu7LaaLIy44= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199018)(31686004)(54906003)(316002)(36756003)(31696002)(86362001)(38100700002)(82960400001)(6666004)(53546011)(6506007)(83380400001)(186003)(2616005)(6512007)(26005)(5660300002)(8936002)(478600001)(2906002)(6486002)(4326008)(41300700001)(8676002)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qys1ZFlMNmV3cVErQXBWVEVna0Y5TnRvVTd2ZkszWS83ZTN0cmx3ZXZxSDhy?= =?utf-8?B?eW54TnZPdWZ5Um9CUkdpL1ZEZk9JYmdYSTJHdkZ0Q1JzdWZFajRRQmczRU5I?= =?utf-8?B?enU3WDBKR1d1bnNEazEwbEdKc2R4Q25GdkpkUUV0WlBmR0RvZm5uNDJ0SWM1?= =?utf-8?B?UXZuTEFwZTdESUE1c3dJTmJnS2o4NC9OelpkanFpUlZqRThmcFRXR2cxUVo1?= =?utf-8?B?aWZ1dmg0bkdPdUMzRjlwTXNzWmg1NXdneGJzOUpKZ1dUQTgzWE4zY3oxWHpB?= =?utf-8?B?aWNXSk8zY3lHNmoxR0FJeWdqZDlSTklycS9BaDhmNXYzaksyU2kyTlZvSHpZ?= =?utf-8?B?UmFGS28rcDBISE12VkVJeHhMKzBRNWtIVW8zVmNKVVcxWG1TN0FFNnRZUmFN?= =?utf-8?B?NkNIbTZrT2tDbFZRM3RleXRBLzF5dS81M1pud0RWNVlIZ2FmRURqUVpWS1FQ?= =?utf-8?B?aEU5L3Y4OVk2djgxSW9uL2lXbDN4OWMzWHprQXFveS9YdjgvQStVM0QxWmxT?= =?utf-8?B?SGZaN2VqY2NpZjBPRXkyeC9PVVY3dXhKZC9VSUlSVmJmU2lBLzRtVndqdCt1?= =?utf-8?B?d3RJOEtqOTRvRG9CUG9uNmxQMUJFajg4UVV0VmZXS212c2lvSW9BeFF1UW16?= =?utf-8?B?SW5VYnhJUFJNRG0rdjFWblVRK3p4d1NrbzNzMzJDUGlJZ1ZiTkhSN1IwOUNk?= =?utf-8?B?MDBMbTVQUkJHZVc3dThNME1RVUZIaWIwOUl3d3lzaHNoL09RNkpTK2VTbEFX?= =?utf-8?B?cWsyczRRaFNyUjlhL1c5a3NsUFBqWmwwL1NLVUV4bnc5RHUweHpxOHZVcWFn?= =?utf-8?B?cHFIUjlIWnB4a0lPSkErQ01XY2VqaVpURFJ1bG9iYVNBUTh0T2poZGJGaVdw?= =?utf-8?B?d0JxTnBDZjJrZFh2dHgrVUpuait5dC9Va05MOEl5Z2dwVEtZSHArT3p1akJN?= =?utf-8?B?bnY2RkVzK3Btb0h0MFlkbHMwaHFoTnJvMDVtd1hLdEpqTGVKQzh3dkV6SjM4?= =?utf-8?B?Z0RNa0NQS2JOM0xzdU5TR0tPRnQzWmxJdENGYmIzaDZpWnpEdkdhdjJCWUsv?= =?utf-8?B?OWtBdFlJdG1tWFgybThlMS8vM2h2WklTL1pSZmNlTzFNWDMxSlNrSmQ0MFlL?= =?utf-8?B?a0JHaTlFeVU5b2RITWdSR2Q4TmV2aUdSNkFqcHZrM2xmR2VFelh4RzZYMXM0?= =?utf-8?B?VXlVa0JGY0JtNk1ZaTc0MTdkS2hyUFFCMGtqejh5WHlDTGVQTzZxZTdpb01S?= =?utf-8?B?KzM2NGFIa1lCaHR4OFdUdU5sTjY5Q1RlV0FoZEFSS29lNDhBOVJvczBpVjFQ?= =?utf-8?B?RUtURGw5eXluOVV5SmJVc2xQMVNVL2pFMmo0NkM1L2krTURmS2FONnhtcFZo?= =?utf-8?B?Sk9CTUZZWEExRXhkRTFGZ2ZIQzkxYzk4WEFDMzRHbDY2cUVpOVJFYXlVSVpI?= =?utf-8?B?cno4c2h4aW5hOWdldCswQ2IvOUdKcnFZUjgxUXI5Y1ZFY3hZemF6OXFQZkts?= =?utf-8?B?Mzh3SVd1Mm9YZ0JOdHBkOE16QTdQcklmQ2NmVWhsdVpSMGZQbjBZcy9vaHRX?= =?utf-8?B?Y1FrUXh3MXQyTmJyeVhTM1MzUGx4VzNUTVFRZUtDQ0xna0d3MVRZU2dwODNU?= =?utf-8?B?ZjlDZjZFbW1zNTdsZEc3RUhmY3BqYVkzeHZjcmdZS09kWGVJbDVPc3M4M0pv?= =?utf-8?B?YzBkNXhsU2NFdG02UHd4dXBDUVM0b1ZsK0hCbVhxaDBDSXdoQWdIbnpLZ1Zz?= =?utf-8?B?SytDL09VYWFWYU1yd1p3S0UvSmpYSTZibXQ1dnZVc3lEYjlYNGhsdC9VNGow?= =?utf-8?B?cSt1RXJqWUErRW1mSURMY3hEeU1FaE5xdkh5T05BalVXMmk3dEUwSnNWb09C?= =?utf-8?B?VDBPK3FFMUFHMjRIYzZjZWVzbjZ4bHJBUThMd3ZubnVNdHdNV2ZYRUp6N01T?= =?utf-8?B?aytZdEZ0RDRaRk01ZCtvYzU1ZlVheVdlUmsyc0NXaDVZalhMckg2UHZFTzdo?= =?utf-8?B?WThaUmIzMjBNNjUzQTl5SUttVWpFdWVtVWNkN1FscTZ1RklsY2RJMTFEWUha?= =?utf-8?B?VzVqOVNSZStoeVBtYjU5LzdMUnNUeFNtWVdzKzlYS3ZTdG9yeGFMQnI1RUt6?= =?utf-8?B?UU1JcVg3ZmJKMUZ1ZzhEdGZycHE3bVB1Z3BsWGl0ZVdjVlR3KzFzejBVaTRU?= =?utf-8?B?Unc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1/6beiqJgpzIMj4ZMv9Cf0rpk71UvCYo6DfoLgdFT91yEKH/MBKMqC774WlJyOxmkFhrotr/QG6g1vKwEOpSbrcm81mzUo2X52CxOjp7//uXP+AVRYqb4aqUTcMBlpNOBZtixDn7zqf8RC8mFKvHH/gWKp0RlW5McoTNpw3lT/M7TMfDuHaTNz9EURdEH3SEdRzt/T/to9QsaCJYx0x0QsHyW5CxdIjarlIgvSk16PtgY+71Opu74vHWCieCHyuLG4ki1cPEZvmL+TPSoDgl1YT5urufrfG+bXI35uHd5h53X1c7k7SrAoyt/dbTaqXKvFMjhcZNfqJinVHs6AUV9cj2wt0xk2SDEO7X9EMM4kAzHb3jmAqJ0ZRcetlVvFQ7JKt77+RFOlPJMffBl6stftYCp+BI/zLRUk6DOZh/Hd/N6iL2EpEXywiYLbu+Bk2Tgan+NlVmdNBXNf++nGw5Nb0HS3bNG+yJWlQVdxc/yn4TlVUVegNtSsZXt5rdgk3OpKozKrKbjyEFWsGTTDai8qrDEFUbn7ny5jNa0bteQBq0PTJM+MFZ0d+0GLmDPXyTA3rzpAAaAqHn3aDgAxioomX0kn5XglgkDDOhoM4r3jQoK3TmLwhtZNmTKGEzkPm92u/NvxW/BrqCPr/b/VozXM192U8X8XJpG+XBcg3DrxDjx3a5vb1Kn49foH2DPsLJuORP1zVHhWyLMBppMlMSoTQi+wj8r2uuXTCr67gqeac69H6qhTDzzqIuEmiuVhDHZVN2Rk+WVfVBabcKa6eBeRQBrjjViaTXeS8zwqyNaRw8zT5gQ2+L3ijAB+6EpvY1IZED2UIkWnD2R03NnCE7deDmEROOwLMOj7Ez94km2FkFutJ/GxU5CvgAUJ9K8699 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7c9e842-454d-47dd-3dc3-08db18df53dd X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:26:06.9495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pf/3/lopF0zGffANOi0ZaakT5eBQN3+mmQrpOjKTubLLYgqAT8SZGbw6Csm8HaDoSIAVrWbzArJ8o2PpxKiEUhOLUL8b7UdEP13VN4f6o64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5074 On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: > Create two new private headers in arch/x86/hvm/vmx called vmx.h and pi.h. > Move all the definitions and declarations that are used solely by vmx code > into the private vmx.h, apart from the ones related to posted interrupts that > are moved into pi.h. > > EPT related declarations and definitions stay in asm/hvm/vmx/vmx.h because > they are used in arch/x86/mm and drivers/passthrough/vtd. > > Also, __vmread(), used in arch/x86/cpu, and consequently the opcodes stay in > asm/hvm/vmx/vmx.h. Every time I read the vpmu code, I get increasingly sad. That is dangerously unsafe, and comes with a chance of exploding completely. That __vmread() is in NMI context, which means `current` isn't safe to deference (we might hit in the middle of a context switch), and more generally there's no guarantee that the loaded VMCS is the one associated with `current` (we might hit in the middle of a remote VMCS access). vpmu is generally not supported, and BTS needs further custom enablement because it is only useable with a custom bus analyser. The __vmread() needs deleting - its absolutely not safe to say. I'm tempted to hardwire the return 0, and punt the problem to whomever next uses BTS. Alternatively, MSR_DBGCTL needs wiring into the hvm_get_reg() infrastructure, but I'm not convinced this will actually work in either of the two problem cases above, hence preferring the previous option. Thoughts? ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:42:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:42:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502817.774812 (Exim 4.92) (envelope-from ) id 1pWgZy-0002Sy-MX; Mon, 27 Feb 2023 16:42:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502817.774812; Mon, 27 Feb 2023 16:42:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgZy-0002Sr-JS; Mon, 27 Feb 2023 16:42:22 +0000 Received: by outflank-mailman (input) for mailman id 502817; Mon, 27 Feb 2023 16:42:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgZx-0002Sk-0V for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:42:21 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2161cf3-b6bd-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 17:42:19 +0100 (CET) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 11:41:48 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB5982.namprd03.prod.outlook.com (2603:10b6:5:389::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 16:41:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:41:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2161cf3-b6bd-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677516139; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Wb/H+wRXn5fAOMPkpALEF5sGp4DfgYIxSPs3wNeJDrw=; b=FOzlzbOPHy66oaJ92OERlLvV6fXkxBfbYOdHlSR0HDNdRcZxSco3agpO QjCw9ZGQbOKFAZ6dD2plOI/BUjC8ERohZEp+vyrqa1zr2wRTyDl9l4RJy m8QLXlOEhqwmPJN1ONOMPDXm/8eKwDJlAMfF8ytK4JzbKlx+VUqkodCRs U=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 98097041 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:o+NV1KkzZbrDeweZLfNtmEfo5gxpJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcDTiDM/2MZGP3Lo93b4yx9kwHuZPVxtBlGwdupH89HyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aSaVA8w5ARkPqgR5gCGzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aQ+Om8mSxSDvf6/nI2JGsxLjZ8DLta+aevzulk4pd3YJdAPZMmZBo/stZpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3iea9WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDROXpqaY22TV/wERCLzAPfny/r8Khg2G/W45jK EwR2jox+P1aGEuDC4OVsweDiHSZpAwVX91cFPIzwA6Iw6vQpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRuwJC5TK2YBbC0FSAIt4t//rYV1hRXKJv5gHbC0iJvpGDj26 zGMsCU6wb4UiKYj1a+24FTGiDKEvYXSQ0g+4QC/dn2hxhN0YsiifYPA1LTAxfNJLYLcRF/Ru nEBwpKa9LpXU8HLkzGRSuIQGr3v/+yCLDDXnV9oGd8m6iip/HmgO4tX5VmSOXtUDyrNQhexC Ge7hO+bzMYIVJd2Rcebu76MNvk= IronPort-HdrOrdr: A9a23:HSHjOKrvhoW2J7aDZ6x+P6caV5s2LNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwOE80hqQFhbX5Wo3SITUO2VHYVr2KiLGP/9SOIVycygcw79 YGT0E6MqyKMbEYt7eF3ODbKbYdKbC8mcjH5Ns2jU0dNT2CA5sQkDuRYTzrd3GeKjM2Y6bRWK DshPau8FGbCAgqh4mAdzE4t6+pnay4qLvWJTo9QzI34giHij2lrJb8Dhijxx8bFx9f3Ls49m DBsgrhooGuqeuyxBPw33Laq80+oqqs9vJzQOi3zuQFIDTljQilIKxnRr25pTgw5M2/9Vowl9 HIghE4e+B+8WnYcG2ZqQbknyPgzDEtwXn/zkLwuwqvneXJABYBT+ZRj4NQdRXUr2ImodFHya pOm0aUrYBeAx/slDn0o4GgbWAhqmOE5V4Z1cIDhX1WVoUTLJdXsIwk5UtQVLMNBjjz5owLGP RnSOvc+PFVW1WHaG2xhBgl/PWcGlAIWjuWSEkLvcKYlxBQgXBC1kMdgPcSm38RnahNPKVs1q DhCOBFhbtORsgZYeZWH+EaW/a6DWTLXFblLH+SCU6PLtBGB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMy12oFR+BylehT9Yd3U8LAd23FFgMy4eFKyWhfzDGzG0vHQ7cn3O/erGM paY/ltcrjexWiHI/c84+SxYegVFZAkarxnhj8KYSP+niv1EPybigX6SoekGFO/K0dsZkrPRl 0+YRPUGOJsqmiWZ16QummlZ5qqQD2xwa5N X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="98097041" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2jbLP/FxK3p+7DutisZq3ynZqrR1C0dM1wWQL5FckLf6kXaSP7a4ihjhXGVCN/bJtqq2DV/teAGzqBjfNX0JrNysYA+OHBYYTu9rqnP0UNJW1x58THN5PuBTfnHiSIWH8Cx+OtDXSICjod1522EnCiM8T9S5xbjEYUuKxbC8lY4HeiHEqDeXBzUle7ZuGq1dnW3i5ZJsL1Bi4HcMmfKTsa+IJyVvdgbRlCS9hCSctJ+DYX5msHL3Gim6ufcTcl4wTF/O4iW4wvGqwiYQNskO7LR9bny1Cl3USMEnhY2/XnGKb4x89fqA/qOBjMhOwagOY/2gZPZ8VHmaTxn/7vLQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wb/H+wRXn5fAOMPkpALEF5sGp4DfgYIxSPs3wNeJDrw=; b=KC1tzldYJc+sGFHEt2Wen+n640UR2ZqBBvf6qx1rm605nJwGXb03foJpdXk99HC/hd0+uAZ5MkvdqkYGu071M14xoV/PhTARqWu2NdNyMyRV/j658el49TJU1WvbUzDthA3kqDJ053yDiewRp4UKgjKhIF71irMxtD/DH9UkJyo3nUpTrbDN0heqIuZEddN0nbuUdWDfrBF9byG9vj659loNqYg+4OH+J6RL3v10WS+jLpO3a/GHPjCaiHqSthCj1YjLn0BQXnyla9E4t/v/nxcQZ7TYtAjHq8Z/I+fLA5vorrQmYPiouclQ4rdE55E7Hl8WwQm8Tjucfo6aAQYA5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wb/H+wRXn5fAOMPkpALEF5sGp4DfgYIxSPs3wNeJDrw=; b=kZBWSUAYPveaE9U+4Hdz1JASkIilhHLbzs7AkZ+XUqRr1JEzsAioUYSikih5PB+AK/o3kQ3ml0Qkoo0WzCUwizzcPfSgpCUy9OZFq433eu2GDMx4MEfCAK+CBMWvDmGYczdh6/XL7/dmXgJ4y9Y3SRlWNPwvVBsS2QFjFoLrhoI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 27 Feb 2023 16:41:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-GB From: Andrew Cooper To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Jun Nakajima , Kevin Tian , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> <12849cea-58af-e13f-89ab-a7e9d4200df8@citrix.com> In-Reply-To: <12849cea-58af-e13f-89ab-a7e9d4200df8@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0122.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB5982:EE_ X-MS-Office365-Filtering-Correlation-Id: 71b03c3a-0ed6-4ff4-1189-08db18e1839d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VMtccGgabSmWC4U1IKyiv3qJFDXHjHdft7zc9uw26+zeADQY5zHSUtkWFAGTJK8wikjVx0AOIdXxQD1asHr8a/aN381+Q59IdVomfWn/1hY78DhdW2PrU+4Cq3oKZJeSq01uKsiB6hfTUPTu+XCsSvI90SLfEQGzvonw+UIDzohHeDLEJaWfTXjwOzrpeGh+oKZB400OnzzFMD89xP6gAQwmMB/eCP+zQZkQCz1G3aF+gI+drpsX18Ir+GAasdbD5zqaxUDzy01JhPIZKewoyN7Ny9vz2fpr3E4Mk+LBza5D9Q2WsXjvUkVPFYVK0Qbu1ucTbir0dZdFiap1rucD3NMAyS4Q0zbbnpYGowk1ZtoMiyXx5/4vYoDXg3jie7rIDSj7Wf28DCItxtEbbXs6EzEadkYJ3C3GGA5ycLHnmzULOoBkEXDW1KKD/XCXHSeG5Gtz6ivkQJk7PAkBmDY3E+Tzi82azYLFH/+NvvmbuoUe8j43nGOW2jKO8A60UhBd8eb56NyJJ6CY6q4hsa6TpArkwOPx6WvwyB0Ix/neZAX6iGUFmbVu4tZEMSIR9s5LlIx3sjZuEA5kDNgnddXtZryEs43N0F5kw/h4zyxJt6c4+2LJR9kzqjmADp/dcab+MihgI/oLh5ZWgAcRf5Rnu0G8RiOA2JL75RSs6VGUehfrtyV1hCJpPPO2VwA2pdoV3NF/MFSWeSHUZVuGqlD1N3zksuZ6K4y4BVLwu/e1KgQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199018)(2616005)(478600001)(6486002)(316002)(31686004)(186003)(6506007)(6512007)(54906003)(6666004)(26005)(53546011)(83380400001)(8676002)(66946007)(4326008)(66556008)(66476007)(41300700001)(5660300002)(8936002)(38100700002)(36756003)(82960400001)(86362001)(31696002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFJVZGRETHB1Z1I1S2RFVXBXU1Fnd2NEdjJ1R3dZTDhEdWZWTXlSNmRtTEMx?= =?utf-8?B?RGNIcWlZVG5QSkowdkxiY251bDIxa3Q5ODJ2eUo0MU9YeEVVMHF3QnV2MGp4?= =?utf-8?B?Q3BHSWZ2dFR5SkxJR2hZV3FPYkZ2bUlzTWdaNk5PVVlrUmtDWExGKytJUi9V?= =?utf-8?B?UUwxaUt3TXRFYkQ0VFVMTWp3NUlpNllqa1R5aWx4bHUzSkxoQXhyNlcreE1x?= =?utf-8?B?Zzh6NVRNR2RFNnN6VDNNQXYrbHR5RnlhQXdXdlJYbExMN1VqQVgydmhueDJO?= =?utf-8?B?VDdaRUVJL0gyTFlYc1VhSkxoZ0FoWU41NWFzTE5XVGs4ZERENWc3STdYbnNP?= =?utf-8?B?UGVnbUVISUVmV2krcUNHMHBWVDU5Z051UnJTdDRHN0NmNVZPK2Eyd2NzSmVJ?= =?utf-8?B?RlpudGxIakE4OEdrSkhlRGdZZVZlSEk5elhFeHlSOEJmc0x5a1IySGQ2eUQ5?= =?utf-8?B?aDR2SnIwUFAwT3o0c1FrTHlQWTNDY1ZaZ2ZLNm5yVlVyQjc0bmVNTjlhbTEy?= =?utf-8?B?c2dQcnA0dElBS3N4emhFanJxQW5PRjZubXBoQjlKTkYvbEdCWGczZTNoandr?= =?utf-8?B?RHh2TVVXNkdxVHpIUGVEK2VheU1ta0F3c0p5R2IzWHJoTDVobkl2OWdwZnVT?= =?utf-8?B?ZFZ5RGlZWDdrRzQzU2JQcnZqZEpIQ3Fid08wZWxSSEhsdk85bUxhSW5GT0pD?= =?utf-8?B?dDlocnJydzNPbXdhUWtRbmpiTHZkZ1Q4UURYME5MZzhkWEwxQ2xBUTU3MWN1?= =?utf-8?B?djBVQ00vWVk0dkxUakpVTkhXZXZZZFdMdk12MGFkcFZjL05Ya3RDNk1Qdnk3?= =?utf-8?B?eFNUcXBva0RJektHYWhuQi9HM3dNQW1KaWlxNXJNS0RlWXNxOWg4ay9uM0RN?= =?utf-8?B?NDRYUUFjNXVEa0lvUEZqNENXcGJKd3hnajNYMTRzMHBLaTlidXVGRWFxc0FT?= =?utf-8?B?UkwzYk1NbGpFSU1rMFROK1NEbjloRlVSRVBJeU03TEVvYWN1ZzNCaG1odnlR?= =?utf-8?B?NFNwdFRydmtjeW4zV3RkUjA2U1RnMERMbHIvZVFtTFVMMzdWZ3hpeHU1SmdB?= =?utf-8?B?aG1zR01HZ3dDM1EvazBrODhzdlFIWHhIOU9aQUhwamhoRlVpWmNITTh1MWdk?= =?utf-8?B?bm5XYnp1aUJxTXNMNHBOU0tGZHREeDZ6aFNjRXpSYlBiNm5DVE9sQVB5TUlE?= =?utf-8?B?VXRLMjJuSjh4VVJ3UEU3MFRiRVVrQlFyMDlqdWh3bEpHdzJ1SVg2OE5LVnNU?= =?utf-8?B?QnR0U0dHSDlQT25lQmRibExNUm9ZVG40TnVxd1ZhdUdvOXorYmdaMDVDT0Nr?= =?utf-8?B?UlNaRUZ0dDloL2tQNjQ3eGF5R1FmTzRHL1RKNWRJSGdCS253RjdXVmtlamdp?= =?utf-8?B?UjdMNU4zMW1ZOFczbHlURHdHWHIzYUtBeEtuSzFiYWNXNytFNUlPUjRSMTZp?= =?utf-8?B?anhJY0d6ckNmeVp1TkhPN0svR3JpYXMyZ25PQUIxMU9ab3ptbmttc1hJejZY?= =?utf-8?B?aFMyNzd2a2tBaE0xbmZmMCtpVEF1aDdTYjQyWkxOV1ZTTVZMYlVpZDNMTlFw?= =?utf-8?B?RCtOOUlWcnVWVFlJL0RNVGtTR1dTMTJRanZySWZpaDIvdTFKUSs0S0VBMkdN?= =?utf-8?B?V2ZyQU05WWtUaW9KVmlJbllPYzNwbTBrR1MwcjY0MVJKbEhONjJpa0xwU3E2?= =?utf-8?B?U0FzbWdOekI3MTFaSzZzdUc5L1puQ0hOUHV4VXFrcDBQdFZnWlZwcnk0US9U?= =?utf-8?B?UmM0UnIvb1IwS1hKTllGckFBT29RMUdtY25ocWhpbXVacUZWcytwcFhsQStO?= =?utf-8?B?UmhiVWJXYnZ0RmkybkVxNXNoT3NDV1c2ZStSZFhpeUtOdjJrcGYxb0d2WG1q?= =?utf-8?B?T3Y4VWNLOFladENtZGYvUnNWZHRGVTN3MDZiZzU5c2MxdHFvbHBRZzFqbG5o?= =?utf-8?B?VTV3WmxJZnR2NFJpMGNrU0dRYlpSN0wrVWtLRmdDb1E1WVBFY0k0VHFrVHBP?= =?utf-8?B?S3phWklLQ0NUdER1bkI2VDlEQzZGa2RiaUhsYjlXYWgwci9GM0JXMll6aEg3?= =?utf-8?B?dnRiVk5nTFU0WG5DWkZpV1l3ZjdMTlZpdmh5dmpMUFcvVVY0UDM4RDFiaFZU?= =?utf-8?B?YlM1aWZrcDRaYWVMTFpPKzBXR3luYmcybUsza3kwZVVJL1NWY2FrNlZNRity?= =?utf-8?B?eFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0GkQuqdIylunUBjdu8cwtGcuyB2zS1CI4MIHAWQiG7SghtRH0b2XHJQ1mjhnvLVRhPdMc4vU0pND0TzawpAg3izbAQ63BHwwYYGu3ynGNCKoNfRI0WhTaxGoPPlb4j1wLb5Wb7JhCztQuotFXuGbeaZkSLzia7ncEwbF3najG2phtjpqqYJOqC+V0cAoL3gpgNEWmURhsD/m+cMwiIDCXRSLH/eWS6AFDzbj6ivoQhgppsMhnpnCRngUDYiXTHkWfM0vEzHLej5Bqc2SBM2rAEyqozS3p5Q12HP7iqJKaLCBG3CkZ8cyiGt6auVMOUEq810SLUvOQLRn0BNpUOjbOtzoSLW/OUfck051WZXB0YIKL28sWkXIu+szsIyyuOjl75jgwHwce5hdDFHclNG1md3fI4kWJkN6Ik8Y6Vu4g2FDObrKx6vEaOEOkt1Y/2I7qkgXJQrIGPUc3403P+LY8FLmEO0xTJEpQw/QMGWJZ18qsB9gqdz7Ofo3VcpRMkKZftXsYf4O+h+GGeG1+UjTU/baxD9vClVTBX8CLgG1i0XrblWhaWiK1Md1cpw//1kDwz982bXCOaf6G/gaYV+ASlEJEo79h5FRC7YNR2eEgAzsOOGzd5euG28Hq0lOeIXmpKd9Qmjh5L2K6ynzsirzD3K+BWoBh/GmPLqduNx575fvur3wfpYg/BEeM5NEG7VTG9rlGzKitPSVmnHC1xOe9jXGRKieQM7OO+sLPazhTkIJmlTgsxv13xlC95CirKRVuVAGduiY82ERPs/p2qfNZCq9lpBh2k+lcf63uTRsGNO7+tVCMZMMA28YUq6AIygPsfxAnnIbKvZzHd+aVq72UHkqlOYqsqStYJHyfK1SgZE7fMHP2tjk+VD4D6kCVlNE X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71b03c3a-0ed6-4ff4-1189-08db18e1839d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:41:46.0374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3GYq+k3a4VUkYCEVhcpoaeIZh/pqQwhlC1F8JCVjzYE0gVN9m2NCjfld61IsriirXkVW+V0hEXQgJRoOai0qEEp596hy3Uw6j7jJ4bHRd40= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB5982 On 27/02/2023 4:26 pm, Andrew Cooper wrote: > On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: >> Create two new private headers in arch/x86/hvm/vmx called vmx.h and pi.h. >> Move all the definitions and declarations that are used solely by vmx code >> into the private vmx.h, apart from the ones related to posted interrupts that >> are moved into pi.h. >> >> EPT related declarations and definitions stay in asm/hvm/vmx/vmx.h because >> they are used in arch/x86/mm and drivers/passthrough/vtd. >> >> Also, __vmread(), used in arch/x86/cpu, and consequently the opcodes stay in >> asm/hvm/vmx/vmx.h. > Every time I read the vpmu code, I get increasingly sad. > > That is dangerously unsafe, and comes with a chance of exploding completely. > > That __vmread() is in NMI context, which means `current` isn't safe to > deference (we might hit in the middle of a context switch), and more > generally there's no guarantee that the loaded VMCS is the one > associated with `current` (we might hit in the middle of a remote VMCS > access). > > vpmu is generally not supported, and BTS needs further custom enablement > because it is only useable with a custom bus analyser. > > > The __vmread() needs deleting - its absolutely not safe to say. to stay* > > I'm tempted to hardwire the return 0, and punt the problem to whomever > next uses BTS. > > Alternatively, MSR_DBGCTL needs wiring into the hvm_get_reg() > infrastructure, but I'm not convinced this will actually work in either > of the two problem cases above, hence preferring the previous option. > > Thoughts? > > ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:52:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502822.774822 (Exim 4.92) (envelope-from ) id 1pWgk6-0004J2-Mh; Mon, 27 Feb 2023 16:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502822.774822; Mon, 27 Feb 2023 16:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgk6-0004Iv-I4; Mon, 27 Feb 2023 16:52:50 +0000 Received: by outflank-mailman (input) for mailman id 502822; Mon, 27 Feb 2023 16:52:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgk4-0004Im-7p for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:52:48 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27adf7b1-b6bf-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 17:52:44 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id n2so9346498lfb.12 for ; Mon, 27 Feb 2023 08:52:44 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id d13-20020a05651221cd00b004db2b111bf3sm960073lft.21.2023.02.27.08.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:52:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27adf7b1-b6bf-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=KwJsQyxIb5KnY18DxB3AUagY47WqcQdOBCCPO+/CiUw=; b=PHZgsRFwf/48FChyfhOWOeOv69t7N3PMuXkrlLGX0hu8VaA0C2TPAc4K6SKTu6+GgW Ig7dvfaZrQmdwKMi3h0LaPNuhGye8Wc4k1E/gRuZ/6lKnJoJk7Lw7RSMEOaDwu/9EClh Cvlnq8DHzl6OvgG1YC9n447saB2SEUjGXFASaNvvBe3/nwF2mzkEbBcpB8mDzh4FQTxl SEK09V3sQe7pEmzqo0z/xJrVMXu+DV/1tPbc1mKWZPH6Mg+KeqQiCkBdcwc5Kc1ch5s8 luUjqrIaDmOZvofjK5iON9f7fPqJ76omyYEn+dy6oBI6aZbA89AQqbnYGAef8P1Su9W9 UZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KwJsQyxIb5KnY18DxB3AUagY47WqcQdOBCCPO+/CiUw=; b=gCsDf0n4FS7awbyQYYokHru3cSCtgDL8PTPN//2yOLD/v3WT93/+tNDtmo2nrq7dO1 9kwMqbIB060pwC37XMp4y8VhxRXvw1ywnZli1cbxVsmek7iK7fQaMOKVDYir6/mxSe5u y11D2kmrGaEZYbUHl8rsPiatFxI+LCuuDOJt6SvCpL3tpSaPI/kswAhDkU8Y4U4DTtVa d+8Uv/nd8XFCoAvYfR5igFBUbYgqdxX5u6e7vsYIl0GqVuzmTMxt0Gt1DZv8Ld+KjSfM ZCXco+Vf0Z2ztPDBAkOMCnMWeV1KIlijNRZThBfIrhllJT+D/p10ENQoXoQAj7L6PKE/ tgiQ== X-Gm-Message-State: AO0yUKU08l2UqRJjwLG1tpACciVeYEKMgF0+PABMlStK1f+CShMbWoGR alDRU4ZnfvwAEtMoB8aUIUM= X-Google-Smtp-Source: AK7set9vl4D6ST9vxby9Fyd7gDeNDgHU4yfyvM9nouKxlTPYkfIvdOcNsTvYg4pZnvs3tXaF57WWwg== X-Received: by 2002:ac2:488f:0:b0:4d8:71dd:5c5e with SMTP id x15-20020ac2488f000000b004d871dd5c5emr7342021lfc.37.1677516763094; Mon, 27 Feb 2023 08:52:43 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 27 Feb 2023 18:52:41 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 T24gU2F0LCAyMDIzLTAyLTI1IGF0IDE3OjUzICswMDAwLCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4g SGkgT2xla3NpaSwKPiAKPiBPbiAyNC8wMi8yMDIzIDE1OjA2LCBPbGVrc2lpIEt1cm9jaGtvIHdy b3RlOgo+ID4gTW9zdGx5IHRoZSBjb2RlIGZvciBzZXR1cF9pbml0aWFsX3BhZ2VzIHdhcyB0YWtl biBmcm9tIEJvYmJ5J3MKPiA+IHJlcG8gZXhjZXB0IGZvciB0aGUgZm9sbG93aW5nIGNoYW5nZXM6 Cj4gPiAqIFVzZSBvbmx5IGEgbWluaW1hbCBwYXJ0IG9mIHRoZSBjb2RlIGVub3VnaCB0byBlbmFi bGUgTU1VCj4gPiAqIHJlbmFtZSB7X31zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMgZnVuY3Rpb25z Cj4gPiAqIGFkZCB3cml0YWJsZSBhcmd1bWVudCBmb3IgX3NldHVwX2luaXRpYWxfcGFnZXRhYmxl cyB0byBoYXZlCj4gPiDCoMKgIGFuIG9wcG9ydHVuaXR5IHRvIG1ha2Ugc29tZSBzZWN0aW9ucyBy ZWFkLW9ubHkKPiA+ICogdXBkYXRlIHNldHVwX2luaXRpYWxfcGFnZXRhYmxlcyBmdW5jdGlvbiB0 byBtYWtlIHNvbWUgc2VjdGlvbnMKPiA+IMKgwqAgcmVhZC1vbmx5Cj4gPiAqIGNoYW5nZSB0aGUg b3JkZXIgb2YgX3NldHVwX2luaXRhbF9wYWdldGFibGVzKCkKPiA+IMKgwqAgaW4gc2V0dXBfaW5p dGlhbF9wYWdldGFibGUoKToKPiA+IMKgwqAgKiBmaXJzdCBpdCBpcyBjYWxsZWQgZm9yIHRleHQs IGluaXQsIHJvZGF0YSBzZWN0aW9ucwo+ID4gwqDCoCAqIGFmdGVyIGNhbGwgaXQgZm9yIHJhbmdl cyBbbGlua19hZGRyX3N0YXJ0IDogbGlua19hZGRyX2VuZF0gYW5kCj4gPiDCoMKgwqDCoCBbbG9h ZF9hZGRyX3N0YXJ0IDogbG9hZF9hZGRyX2VuZF0KPiA+IMKgwqAgQmVmb3JlIGl0IHdhcyBkb25l IGZpcnN0IGZvciB0aGUgcmFuZ2VzIGFuZCBhZnRlciBmb3Igc2VjdGlvbnMKPiA+IGJ1dAo+ID4g wqDCoCBpbiB0aGF0IGNhc2UgcmVhZC1vbmx5IHN0YXR1cyB3aWxsIGJlIGVxdWFsIHRvICd0cnVl JyBhbmQKPiA+IMKgwqAgYXMgc2VjdGlvbnMnIGFkZHJlc3Nlc8KgIGNhbi9hcmUgaW5zaWRlIHRo ZSByYW5nZXMgdGhlIHJlYWQtb25seQo+ID4gc3RhdHVzCj4gPiDCoMKgIHdvbid0IGJlIHVwZGF0 ZWQgZm9yIHRoZW0gYXMgaXQgd2FzIHNldCB1cCBiZWZvcmUuCj4gPiAKPiA+IE9yaWdpbjoKPiA+ IGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tb24tcmlzYy12L3hlbi8tL3RyZWUvcmlzY3YtcmViYXNl wqA0YWYxNjViNDY4Cj4gPiBhZgo+ID4gU2lnbmVkLW9mZi1ieTogT2xla3NpaSBLdXJvY2hrbyA8 b2xla3NpaS5rdXJvY2hrb0BnbWFpbC5jb20+Cj4gPiAtLS0KPiA+IMKgIHhlbi9hcmNoL3Jpc2N2 L01ha2VmaWxlwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqAgMSArCj4gPiDCoCB4ZW4vYXJjaC9y aXNjdi9pbmNsdWRlL2FzbS9tbS5owqDCoCB8wqDCoCA5ICsrCj4gPiDCoCB4ZW4vYXJjaC9yaXNj di9pbmNsdWRlL2FzbS9wYWdlLmggfMKgIDkwICsrKysrKysrKysrKwo+ID4gwqAgeGVuL2FyY2gv cmlzY3YvbW0uY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAyMjMKPiA+ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwo+ID4gwqAgNCBmaWxlcyBjaGFuZ2VkLCAzMjMgaW5zZXJ0 aW9ucygrKQo+ID4gwqAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL3Jpc2N2L2luY2x1ZGUv YXNtL21tLmgKPiA+IMKgIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9yaXNjdi9pbmNsdWRl L2FzbS9wYWdlLmgKPiA+IMKgIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9yaXNjdi9tbS5j Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9yaXNjdi9NYWtlZmlsZSBiL3hlbi9hcmNo L3Jpc2N2L01ha2VmaWxlCj4gPiBpbmRleCA0NDNmNmJmMTVmLi45NTZjZWIwMmRmIDEwMDY0NAo+ ID4gLS0tIGEveGVuL2FyY2gvcmlzY3YvTWFrZWZpbGUKPiA+ICsrKyBiL3hlbi9hcmNoL3Jpc2N2 L01ha2VmaWxlCj4gPiBAQCAtMSw1ICsxLDYgQEAKPiA+IMKgIG9iai0kKENPTkZJR19FQVJMWV9Q UklOVEspICs9IGVhcmx5X3ByaW50ay5vCj4gPiDCoCBvYmoteSArPSBlbnRyeS5vCj4gPiArb2Jq LXkgKz0gbW0ubwo+ID4gwqAgb2JqLSQoQ09ORklHX1JJU0NWXzY0KSArPSByaXNjdjY0Lwo+ID4g wqAgb2JqLXkgKz0gc2JpLm8KPiA+IMKgIG9iai15ICs9IHNldHVwLm8KPiA+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9tbS5oCj4gPiBiL3hlbi9hcmNoL3Jpc2N2L2lu Y2x1ZGUvYXNtL21tLmgKPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAw MDAwLi5mYzE4NjZiMWQ4Cj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi94ZW4vYXJjaC9yaXNj di9pbmNsdWRlL2FzbS9tbS5oCj4gPiBAQCAtMCwwICsxLDkgQEAKPiA+ICsjaWZuZGVmIF9BU01f UklTQ1ZfTU1fSAo+ID4gKyNkZWZpbmUgX0FTTV9SSVNDVl9NTV9ICj4gPiArCj4gPiArdm9pZCBz ZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXModW5zaWduZWQgbG9uZyBsb2FkX2FkZHJfc3RhcnQsCj4g PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCB1bnNpZ25lZCBsb25nIGxvYWRfYWRkcl9lbmQsCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGxp bmtlcl9hZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBsaW5rZXJfYWRkcl9lbmQpOwo+ ID4gKwo+ID4gKyNlbmRpZiAvKiBfQVNNX1JJU0NWX01NX0ggKi8KPiA+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9wYWdlLmgKPiA+IGIveGVuL2FyY2gvcmlzY3YvaW5j bHVkZS9hc20vcGFnZS5oCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5kZXggMDAwMDAw MDAwMC4uZmFiYmUxMzA1Zgo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIveGVuL2FyY2gvcmlz Y3YvaW5jbHVkZS9hc20vcGFnZS5oCj4gPiBAQCAtMCwwICsxLDkwIEBACj4gPiArI2lmbmRlZiBf QVNNX1JJU0NWX1BBR0VfSAo+ID4gKyNkZWZpbmUgX0FTTV9SSVNDVl9QQUdFX0gKPiA+ICsKPiA+ ICsjaW5jbHVkZSA8eGVuL2NvbnN0Lmg+Cj4gPiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ID4g Kwo+ID4gKyNkZWZpbmUgUEFHRV9FTlRSSUVTwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA1MTIKPiAK PiBOSVQ6IEFGQUlVLCB0aGUgbnVtYmVyIGhlcmUgaXMgYmFzZWQgb24gLi4uCj4gCj4gPiArI2Rl ZmluZSBWUE5fQklUU8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoOSkKPiAKPiAuLi4g dGhpcy4gU28gSSB3b3VsZCBzdWdnZXN0IHRvIGRlZmluZSBQQUdFX0VOVFJJRVMgdXNpbmcgVlBO X0JJVFMuClN1cmUuIEl0IHNob3VsZCBiZSBkZWZpbmVkIHVzaW5nIFZQTl9CSVRTLiBUaGFua3Mu Cj4gCj4gPiArI2RlZmluZSBWUE5fTUFTS8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo KHVuc2lnbmVkIGxvbmcpKCgxIDw8IFZQTl9CSVRTKSAtCj4gPiAxKSkKPiBOSVQ6IFVzZSAxVUwg YW5kIHlvdSBjYW4gYXZvaWQgdGhlIGNhc3QuClRoYW5rcy4gSSdsbCB1cGRhdGUgdGhhdCBpbiB0 aGUgbmV4dCB2ZXJzaW9uIG9mIHBhdGNoIHNlcmllcy4KPiAKPiA+ICsKPiA+ICsjaWZkZWYgQ09O RklHX1JJU0NWXzY0Cj4gPiArLyogTDMgaW5kZXggQml0WzQ3OjM5XSAqLwo+ID4gKyNkZWZpbmUg VEhJUkRfU0hJRlTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKDM5KQo+ID4gKyNkZWZpbmUgVEhJ UkRfTUFTS8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChWUE5fTUFTSyA8PCBUSElSRF9TSElG VCkKPiA+ICsvKiBMMiBpbmRleCBCaXRbMzg6MzBdICovCj4gPiArI2RlZmluZSBTRUNPTkRfU0hJ RlTCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgzMCkKPiA+ICsjZGVmaW5lIFNFQ09ORF9NQVNLwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIChWUE5fTUFTSyA8PCBTRUNPTkRfU0hJRlQpCj4gPiArLyog TDEgaW5kZXggQml0WzI5OjIxXSAqLwo+ID4gKyNkZWZpbmUgRklSU1RfU0hJRlTCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKDIxKQo+ID4gKyNkZWZpbmUgRklSU1RfTUFTS8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIChWUE5fTUFTSyA8PCBGSVJTVF9TSElGVCkKPiA+ICsvKiBMMCBpbmRleCBC aXRbMjA6MTJdICovCj4gPiArI2RlZmluZSBaRVJPRVRIX1NISUZUwqDCoMKgwqDCoMKgwqDCoMKg wqAgKDEyKQo+ID4gKyNkZWZpbmUgWkVST0VUSF9NQVNLwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo VlBOX01BU0sgPDwgWkVST0VUSF9TSElGVCkKPiAKPiBPbiBBcm0sIHdlIGFyZSB0cnlpbmcgdG8g cGhhc2Ugb3V0IFpFUk9FVEhfKiBhbmQgY28gYmVjYXVzZSB0aGUgbmFtZQo+IGlzIAo+IHRvbyBn ZW5lcmljLiBJbnN0ZWFkLCB3ZSBub3cgaW50cm9kdWNlIGEgZ2VuZXJpYyBtYWNybyB0aGF0IHRh a2UgYQo+IGxldmVsIAo+IGFuZCB0aGVuIGNvbXB1dGUgdGhlIG1hc2svc2hpZnQgKHNlZSBYRU5f UFRfTEVWRUxfKikuCj4gCj4gWW91IHNob3VsZCBiZSBhYmxlIHRvIGRvIGluIFJJU0MtViBhbmQg cmVkdWNlIHRoZSBhbW91bnQgb2YgZGVmaW5lcyAKPiBpbnRyb2R1Y2VkLgpUaGFua3MuIEknbGwg bG9vayBhdCBYRU5fUFRfTEVWRUxfKi4gSSdsbCByZS1yZWFkIEFuZHJldydzIGNvbW1lbnQgYnV0 CmFzIGZhciBhcyBJIHVuZGVyc3RhbmQgYWZ0ZXIgcXVpY2sgcmVhZGluZyB3ZSBjYW4gcmVtb3Zl IG1vc3RseSB0aGF0Lgo+IAo+ID4gKwo+ID4gKyNlbHNlIC8vIENPTkZJR19SSVNDVl8zMgo+IAo+ IENvZGluZyBzdHlsZTogY29tbWVudHMgaW4gWGVuIGFyZSB1c2luZyAvKiAuLi4gKi8KPiAKPiA+ ICsKPiA+ICsvKiBMMSBpbmRleCBCaXRbMzE6MjJdICovCj4gPiArI2RlZmluZSBGSVJTVF9TSElG VMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoMjIpCj4gPiArI2RlZmluZSBGSVJTVF9NQVNLwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKFZQTl9NQVNLIDw8IEZJUlNUX1NISUZUKQo+ID4gKwo+ ID4gKy8qIEwwIGluZGV4IEJpdFsyMToxMl0gKi8KPiA+ICsjZGVmaW5lIFpFUk9FVEhfU0hJRlTC oMKgwqDCoMKgwqDCoMKgwqDCoCAoMTIpCj4gPiArI2RlZmluZSBaRVJPRVRIX01BU0vCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIChWUE5fTUFTSyA8PCBaRVJPRVRIX1NISUZUKQo+ID4gKyNlbmRpZgo+ ID4gKwo+ID4gKyNkZWZpbmUgVEhJUkRfU0laRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgx IDw8IFRISVJEX1NISUZUKQo+ID4gKyNkZWZpbmUgVEhJUkRfTUFQX01BU0vCoMKgwqDCoMKgwqDC oMKgwqAgKH4oVEhJUkRfU0laRSAtIDEpKQo+ID4gKyNkZWZpbmUgU0VDT05EX1NJWkXCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKDEgPDwgU0VDT05EX1NISUZUKQo+ID4gKyNkZWZpbmUgU0VDT05E X01BUF9NQVNLwqDCoMKgwqDCoMKgwqDCoCAofihTRUNPTkRfU0laRSAtIDEpKQo+ID4gKyNkZWZp bmUgRklSU1RfU0laRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgxIDw8IEZJUlNUX1NISUZU KQo+ID4gKyNkZWZpbmUgRklSU1RfTUFQX01BU0vCoMKgwqDCoMKgwqDCoMKgwqAgKH4oRklSU1Rf U0laRSAtIDEpKQo+ID4gKyNkZWZpbmUgWkVST0VUSF9TSVpFwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoMSA8PCBaRVJPRVRIX1NISUZUKQo+ID4gKyNkZWZpbmUgWkVST0VUSF9NQVBfTUFTS8KgwqDC oMKgwqDCoMKgICh+KFpFUk9FVEhfU0laRSAtIDEpKQo+ID4gKwo+ID4gKyNkZWZpbmUgUFRFX1NI SUZUwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAxMAo+ID4gKwo+ID4gKyNkZWZpbmUgUFRF X1ZBTElEwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCSVQoMCwgVUwpCj4gPiArI2RlZmlu ZSBQVEVfUkVBREFCTEXCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJJVCgxLCBVTCkKPiA+ICsjZGVm aW5lIFBURV9XUklUQUJMRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgQklUKDIsIFVMKQo+ID4gKyNk ZWZpbmUgUFRFX0VYRUNVVEFCTEXCoMKgwqDCoMKgwqDCoMKgwqAgQklUKDMsIFVMKQo+ID4gKyNk ZWZpbmUgUFRFX1VTRVLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgQklUKDQsIFVMKQo+ ID4gKyNkZWZpbmUgUFRFX0dMT0JBTMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJJVCg1LCBV TCkKPiA+ICsjZGVmaW5lIFBURV9BQ0NFU1NFRMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgQklUKDYs IFVMKQo+ID4gKyNkZWZpbmUgUFRFX0RJUlRZwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBC SVQoNywgVUwpCj4gPiArI2RlZmluZSBQVEVfUlNXwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgKEJJVCg4LCBVTCkgfCBCSVQoOSwgVUwpKQo+ID4gKwo+ID4gKyNkZWZpbmUgUFRFX0xF QUZfREVGQVVMVMKgwqDCoMKgwqDCoMKgIChQVEVfVkFMSUQgfCBQVEVfUkVBREFCTEUgfAo+ID4g UFRFX1dSSVRBQkxFIHwgUFRFX0VYRUNVVEFCTEUpCj4gCj4gV2Ugc2hvdWxkIGF2b2lkIHZ1bG5l cmFibGUgZGVmYXVsdCBmbGFncy4gU28gdGhpcyBzaG91bGQgZWl0aGVyIGJlIFJXCj4gb3IgUlgu ClRoYW5rcy4gSSdsbCB0YWtlIGl0IGludG8gYWNjb3VudC4KPiAKPiA+ICsjZGVmaW5lIFBURV9U QUJMRcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKFBURV9WQUxJRCkKPiA+ICsKPiA+ICsv KiBDYWxjdWxhdGUgdGhlIG9mZnNldHMgaW50byB0aGUgcGFnZXRhYmxlcyBmb3IgYSBnaXZlbiBW QSAqLwo+ID4gKyNkZWZpbmUgemVyb2V0aF9saW5lYXJfb2Zmc2V0KHZhKcKgwqAgKCh2YSkgPj4g WkVST0VUSF9TSElGVCkKPiA+ICsjZGVmaW5lIGZpcnN0X2xpbmVhcl9vZmZzZXQodmEpwqDCoMKg wqAgKCh2YSkgPj4gRklSU1RfU0hJRlQpCj4gPiArI2RlZmluZSBzZWNvbmRfbGluZWFyX29mZnNl dCh2YSnCoMKgwqAgKCh2YSkgPj4gU0VDT05EX1NISUZUKQo+ID4gKyNkZWZpbmUgdGhpcmRfbGlu ZWFyX29mZnNldCh2YSnCoMKgwqDCoCAoKHZhKSA+PiBUSElSRF9TSElGVCkKPiA+ICsKPiA+ICsj ZGVmaW5lIHBhZ2V0YWJsZV96ZXJvZXRoX2luZGV4KHZhKSB6ZXJvZXRoX2xpbmVhcl9vZmZzZXQo KHZhKSAmCj4gPiBaRVJPRVRIX01BU0spCj4gPiArI2RlZmluZSBwYWdldGFibGVfZmlyc3RfaW5k ZXgodmEpwqDCoCBmaXJzdF9saW5lYXJfb2Zmc2V0KCh2YSkgJgo+ID4gRklSU1RfTUFTSykKPiA+ ICsjZGVmaW5lIHBhZ2V0YWJsZV9zZWNvbmRfaW5kZXgodmEpwqAgc2Vjb25kX2xpbmVhcl9vZmZz ZXQoKHZhKSAmCj4gPiBTRUNPTkRfTUFTSykKPiA+ICsjZGVmaW5lIHBhZ2V0YWJsZV90aGlyZF9p bmRleCh2YSnCoMKgIHRoaXJkX2xpbmVhcl9vZmZzZXQoKHZhKSAmCj4gPiBUSElSRF9NQVNLKQo+ ID4gKwo+ID4gKy8qIFBhZ2UgVGFibGUgZW50cnkgKi8KPiA+ICt0eXBlZGVmIHN0cnVjdCB7Cj4g PiArwqDCoMKgIHVpbnQ2NF90IHB0ZTsKPiA+ICt9IHB0ZV90Owo+ID4gKwo+ID4gKy8qIFNoaWZ0 IHRoZSBWUE5beF0gb3IgUFBOW3hdIGZpZWxkcyBvZiBhIHZpcnR1YWwgb3IgcGh5c2ljYWwKPiA+ IGFkZHJlc3MKPiA+ICsgKiB0byBiZWNvbWUgdGhlIHNoaWZ0ZWQgUFBOW3hdIGZpZWxkcyBvZiBh IHBhZ2UgdGFibGUgZW50cnkgKi8KPiA+ICsjZGVmaW5lIGFkZHJfdG9fcHBuKHgpICgoKHgpID4+ IFBBR0VfU0hJRlQpIDw8IFBURV9TSElGVCkKPiA+ICsKPiA+ICtzdGF0aWMgaW5saW5lIHB0ZV90 IHBhZGRyX3RvX3B0ZSh1bnNpZ25lZCBsb25nIHBhZGRyKQo+ID4gK3sKPiA+ICvCoMKgwqAgcmV0 dXJuIChwdGVfdCkgeyAucHRlID0gYWRkcl90b19wcG4ocGFkZHIpIH07Cj4gPiArfQo+ID4gKwo+ ID4gK3N0YXRpYyBpbmxpbmUgYm9vbCBwdGVfaXNfdmFsaWQocHRlX3QgKnApCj4gPiArewo+ID4g K8KgwqDCoCByZXR1cm4gcC0+cHRlICYgUFRFX1ZBTElEOwo+ID4gK30KPiA+ICsKPiA+ICsjZW5k aWYgLyogX0FTTV9SSVNDVl9QQUdFX0ggKi8KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9yaXNj di9tbS5jIGIveGVuL2FyY2gvcmlzY3YvbW0uYwo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ IGluZGV4IDAwMDAwMDAwMDAuLjZlMTcyMzc2ZWIKPiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBi L3hlbi9hcmNoL3Jpc2N2L21tLmMKPiA+IEBAIC0wLDAgKzEsMjIzIEBACj4gPiArI2luY2x1ZGUg PHhlbi9pbml0Lmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9saWIuaD4KPiA+ICsKPiA+ICsjaW5jbHVk ZSA8YXNtL2Nzci5oPgo+ID4gKyNpbmNsdWRlIDxhc20vbW0uaD4KPiA+ICsjaW5jbHVkZSA8YXNt L3BhZ2UuaD4KPiA+ICsKPiA+ICsvKgo+ID4gKyAqIHhlbl9zZWNvbmRfcGFnZXRhYmxlIGlzIGlu ZGV4ZWQgd2l0aCB0aGUgVlBOWzJdIHBhZ2UgdGFibGUKPiA+IGVudHJ5IGZpZWxkCj4gPiArICog eGVuX2ZpcnN0X3BhZ2V0YWJsZSBpcyBhY2Nlc3NlZCBmcm9tIHRoZSBWUE5bMV0gcGFnZSB0YWJs ZQo+ID4gZW50cnkgZmllbGQKPiA+ICsgKiB4ZW5femVyb2V0aF9wYWdldGFibGUgaXMgYWNjZXNz ZWQgZnJvbSB0aGUgVlBOWzBdIHBhZ2UgdGFibGUKPiA+IGVudHJ5IGZpZWxkCj4gPiArICovCj4g PiArcHRlX3QgeGVuX3NlY29uZF9wYWdldGFibGVbUEFHRV9FTlRSSUVTXQo+ID4gX19hdHRyaWJ1 dGVfXygoX19hbGlnbmVkX18oUEFHRV9TSVpFKSkpOwo+ID4gK3N0YXRpYyBwdGVfdCB4ZW5fZmly c3RfcGFnZXRhYmxlW1BBR0VfRU5UUklFU10KPiA+ICvCoMKgwqAgX19hdHRyaWJ1dGVfXygoX19h bGlnbmVkX18oUEFHRV9TSVpFKSkpOwo+ID4gK3N0YXRpYyBwdGVfdCB4ZW5femVyb2V0aF9wYWdl dGFibGVbUEFHRV9FTlRSSUVTXQo+ID4gK8KgwqDCoCBfX2F0dHJpYnV0ZV9fKChfX2FsaWduZWRf XyhQQUdFX1NJWkUpKSk7Cj4gPiArCj4gPiArZXh0ZXJuIHVuc2lnbmVkIGxvbmcgX3N0ZXh0Owo+ ID4gK2V4dGVybiB1bnNpZ25lZCBsb25nIF9ldGV4dDsKPiA+ICtleHRlcm4gdW5zaWduZWQgbG9u ZyBfX2luaXRfYmVnaW47Cj4gPiArZXh0ZXJuIHVuc2lnbmVkIGxvbmcgX19pbml0X2VuZDsKPiA+ ICtleHRlcm4gdW5zaWduZWQgbG9uZyBfc3JvZGF0YTsKPiA+ICtleHRlcm4gdW5zaWduZWQgbG9u ZyBfZXJvZGF0YTsKPiA+ICsKPiA+ICtwYWRkcl90IHBoeXNfb2Zmc2V0Owo+IAo+IFRoaXMgaXMg ZGVmaW5lZCwgc2V0IGJ1dCBub3QgdXNlZC4KPiAKPiA+ICsKPiA+ICsjZGVmaW5lIHJlc29sdmVf ZWFybHlfYWRkcih4KSBcCj4gCj4gVGhpcyBoZWxwZXIgc2VlbXMgdG8gYmVoYXZlIHRoZSBzYW1l IHdhc3kgYXMgbGlua2VyX2FkZHIoKS4gU28gYW55IAo+IHJlYXNvbiB0byBub3QgdXNlIGl0Pwps aW5rZXJfYWRkcigpIHNjcmlwdCBjYW4gYmUgdXNlZCBpbnN0ZWFkLiBJdCBsb29rcyBJIG1pc3Nl ZCBzb21ldGhpbmcKYmVmb3JlIGFuZCBpdCBpcyBzcGlsbGVkIG91dCBpbnRvIHR3byBlcXVhbCBt YWNyb3MuCj4gCj4gSSB3aWxsIG1ha2UgdGhpcyBhc3N1bXB0aW9uIHRoaXMgY2FuIGJlIHVzZWQg YW5kIG5vdCBjb21tZW50IG9uIHRoZSAKPiBpbXBsZW1lbnQgb2YgcmVzb2x2ZV9lYXJseV9hZGRy KCkuCj4gCj4gPiArwqDCoMKgCj4gPiAoe8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqDCoMKgwqDC oMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyAqCj4gPiBfXyMjeDvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDC oMKgIGlmICggbG9hZF9hZGRyX3N0YXJ0IDw9IHggJiYgeCA8IGxvYWRfYWRkcl9lbmQKPiA+ICnC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIF9fIyN4ID0gKHVuc2lnbmVkIGxvbmcKPiA+ICopeDvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqAKPiA+IGVsc2XCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAKPiA+IMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9fIyN4ID0gKHVu c2lnbmVkIGxvbmcgKikoeCArIGxvYWRfYWRkcl9zdGFydCAtCj4gPiBsaW5rZXJfYWRkcl9zdGFy dCk7IFwKPiA+ICvCoMKgwqDCoMKgwqDCoAo+ID4gX18jI3g7wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqDCoMKg IFwKPiA+ICvCoMKgwqDCoCB9KQo+ID4gKwo+ID4gK3N0YXRpYyB2b2lkIF9faW5pdCBjbGVhcl9w YWdldGFibGVzKHVuc2lnbmVkIGxvbmcgbG9hZF9hZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGxv bmcgbG9hZF9hZGRyX2VuZCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGxpbmtlcl9hZGRyX3N0YXJ0LAo+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHVuc2lnbmVkIGxvbmcgbGlua2VyX2FkZHJfZW5kKQo+ID4gK3sKPiA+ICvCoMKgwqAgdW5z aWduZWQgbG9uZyAqcDsKPiA+ICvCoMKgwqAgdW5zaWduZWQgbG9uZyBwYWdlOwo+ID4gK8KgwqDC oCB1bnNpZ25lZCBsb25nIGk7Cj4gPiArCj4gPiArwqDCoMKgIHBhZ2UgPSAodW5zaWduZWQgbG9u ZykmeGVuX3NlY29uZF9wYWdldGFibGVbMF07Cj4gPiArCj4gPiArwqDCoMKgIHAgPSByZXNvbHZl X2Vhcmx5X2FkZHIocGFnZSk7Cj4gPiArwqDCoMKgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0la RSh4ZW5fc2Vjb25kX3BhZ2V0YWJsZSk7IGkrKyApCj4gCj4gVGhlIGVudHJpZXMgaW4geGVuX3Nl Y29uZF9wYWdldGFibGUgYXJlIGEgcHRlX3QgKHVpbnQ2NF90KS4gQnV0IC4uLgo+IAo+ID4gK8Kg wqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqAgcFtpXSA9IDBVTEw7Cj4gCj4gLi4uIHRoZSB0eXBl IGhlcmUgd2lsbCBiZSB1bnNpZ25lZCBsb25nLiBTbyB5b3UgbWF5IG5vdCBmdWxseSB6ZXJvCj4g dGhlIAo+IHBhZ2UtdGFibGUgb24gMzItYml0IGFyY2hpdGVjdHVyZS4gVGhlcmVmb3JlIHlvdSB3 YW50IHRvIGRlZmluZSBhcwo+IHB0ZV90Lgo+IAo+IFRoYXQgc2FpZCwgZ2l2ZW4gdGhlIHBhZ2Ug dGFibGUgd2lsbCBiZSBwYXJ0IG9mIEJTUywgeW91IHNob3VsZCBub3QKPiBuZWVkIAo+IHRvIHpl cm8gYWdhaW4gYXNzdW1pbmcgeW91IGNsZWFyIEJTUyBiZWZvcmUgaGFuZC4KPiAKPiBJZiB5b3Ug Y2xlYXIgYWZ0ZXJ3YXJkcywgdGhlbiB5b3UgKm11c3QqIG1vdmUgdGhlbSBvdXQgb2YgQlNTLgo+ IAo+IFRoZSBzYW1lIGFwcGxpZXMgZm9yIHhlbl97Zmlyc3QsIHplcm9ldGh9X3BhZ2V0YWJsZSBi ZWxvdy4KSSBkaWRuJ3QgaGF2ZSBpbml0aWFsaXplZCBwYWdlIHRhYmxlcyBzbyB0aGF0IGlzIHdo eSBJIG5lZWRlZApjbGVhcl9wYWdldGFibGVzKCkgYnV0IEkgdGhpbmsgeW91IGFyZSByaWdodCBh bmQgY2xlYXJfcGFnZXRhYmxlcyBjYW4KYmUgcmVtb3ZlZCBhdCBhbGwgYXMgcGFnZSB0YWJsZXMg d2lsbCBiZSBpbml0aWFsaXplZCBkdXJpbmcgQlNTCmluaXRpYWxpemF0aW9uLgo+IAo+ID4gK8Kg wqDCoCB9Cj4gPiArCj4gPiArwqDCoMKgIHBhZ2UgPSAodW5zaWduZWQgbG9uZykmeGVuX2ZpcnN0 X3BhZ2V0YWJsZVswXTsKPiA+ICvCoMKgwqAgcCA9IHJlc29sdmVfZWFybHlfYWRkcihwYWdlKTsK PiA+ICvCoMKgwqAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHhlbl9maXJzdF9wYWdldGFi bGUpOyBpKysgKQo+ID4gK8KgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqAgcFtpXSA9IDBVTEw7 Cj4gPiArwqDCoMKgIH0KPiA+ICsKPiA+ICvCoMKgwqAgcGFnZSA9ICh1bnNpZ25lZCBsb25nKSZ4 ZW5femVyb2V0aF9wYWdldGFibGVbMF07Cj4gPiArwqDCoMKgIHAgPSByZXNvbHZlX2Vhcmx5X2Fk ZHIocGFnZSk7Cj4gPiArwqDCoMKgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0laRSh4ZW5femVy b2V0aF9wYWdldGFibGUpOyBpKysgKQo+ID4gK8KgwqDCoCB7Cj4gPiArwqDCoMKgwqDCoMKgwqAg cFtpXSA9IDBVTEw7Cj4gPiArwqDCoMKgIH0KPiA+ICt9Cj4gPiArCj4gPiArLyoKPiA+ICsgKiBX QVJOSU5HOiBsb2FkX2FkZHIoKSBhbmQgbGlua2VyX2FkZHIoKSBhcmUgdG8gYmUgY2FsbGVkIG9u bHkKPiA+IHdoZW4gdGhlIE1NVSBpcwo+ID4gKyAqIGRpc2FibGVkIGFuZCBvbmx5IHdoZW4gZXhl Y3V0ZWQgYnkgdGhlIHByaW1hcnkgQ1BVLsKgIFRoZXkKPiA+IGNhbm5vdCByZWZlciB0bwo+ID4g KyAqIGFueSBnbG9iYWwgdmFyaWFibGUgb3IgZnVuY3Rpb25zLgo+IAo+IEkgZmluZCBpbnRlcmVz dGluZyB5b3UgYXJlIHNheWluZyB3aGVuIF9zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMoKSBpcwo+ IGNhbGxlZCBmcm9tIHNldHVwX2luaXRpYWxfcGFnZXRhYmxlcygpLiBXb3VsZCB5b3UgYmUgYWJs ZSB0byBleHBsYWluCj4gaG93IAo+IHRoaXMgaXMgZGlmZmVyZW50PwpJIGFtIG5vdCBzdXJlIHRo YXQgSSB1bmRlcnN0YW5kIHlvdXIgcXVlc3Rpb24gY29ycmVjdGx5IGJ1dApfc2V0dXBfaW5pdGlh bF9wYWdldGFibGVzKCkgd2FzIGludHJvZHVjZWQgdG8gbWFwIHNvbWUgYWRkcmVzc2VzIHdpdGgK d3JpdGUvcmVhZCBmbGFnLiBQcm9iYWJseSBJIGhhdmUgdG8gcmVuYW1lIGl0IHRvIHNvbWV0aGlu ZyB0aGF0IGlzIG1vcmUKY2xlYXIuCj4gCj4gPiArICovCj4gPiArCj4gPiArLyoKPiA+ICsgKiBD b252ZXJ0IGFuIGFkZHJlc3NlZCBsYXllZCBvdXQgYXQgbGluayB0aW1lIHRvIHRoZSBhZGRyZXNz Cj4gPiB3aGVyZSBpdCB3YXMgbG9hZGVkCj4gCj4gVHlwbzogcy9hZGRyZXNzZWQvYWRkcmVzcy8g PwpZZXMsIGl0IHNob3VsZCBiZSBhZGRyZXNzLiBhbmQgJ2xheWVkIG91dCcgc2hvdWxkIGJlIGNo YW5nZWQgdG8gJ2xhaWQKb3V0Jy4uLgo+IAo+ID4gKyAqIGJ5IHRoZSBib290bG9hZGVyLgo+ID4g KyAqLwo+IAo+IExvb2tpbmcgYXQgdGhlIGltcGxlbWVudGF0aW9uLCB5b3Ugc2VlbSB0byBjb25z aWRlciB0aGF0IGFueSBhZGRyZXNzCj4gbm90IAo+IGluIHRoZSByYW5nZSBbbGlua2VyX2FkZHJf c3RhcnQsIGxpbmtlcl9hZGRyX2VuZFsgd2lsbCBoYXZlIGEgMToxCj4gbWFwcGluZ3MuCj4gCj4g SSBhbSBub3Qgc3VyZSB0aGlzIGlzIHdoYXQgeW91IHdhbnQuIFNvIEkgd291bGQgY29uc2lkZXIg dG8gdGhyb3cgYW4gCj4gZXJyb3IgaWYgc3VjaCBhZGRyZXNzIGlzIHBhc3NlZC4KSSB0aG91Z2h0 IHRoYXQgYXQgdGhpcyBzdGFnZSBhbmQgaWYgbm8gcmVsb2NhdGlvbiB3YXMgZG9uZSBpdCBpcyAx OjEKZXhjZXB0IHRoZSBjYXNlIHdoZW4gbG9hZF9hZGRyX3N0YXJ0ICE9IGxpbmtlcl9hZGRyX3N0 YXJ0LgoKCj4gCj4gPiArI2RlZmluZQo+ID4gbG9hZF9hZGRyKGxpbmtlcl9hZGRyZXNzKcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gwqDCoMKgIFwKPiA+ICvCoMKgwqAKPiA+ICh7wqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoAo+ID4gwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgIHVu c2lnbmVkIGxvbmcgX19saW5rZXJfYWRkcmVzcyA9ICh1bnNpZ25lZAo+ID4gbG9uZykobGlua2Vy X2FkZHJlc3MpO8KgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgIGlmICggbGlua2VyX2Fk ZHJfc3RhcnQgPD0gX19saW5rZXJfYWRkcmVzcwo+ID4gJibCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBfX2xpbmtlcl9hZGRyZXNzIDwgbGlua2VyX2FkZHJfZW5kCj4gPiApwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKg wqDCoMKgwqDCoAo+ID4ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gwqDCoMKgIFwKPiA+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIF9fbGlua2VyX2FkZHJlc3MKPiA+ID3CoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBfX2xpbmtlcl9hZGRyZXNzIC0gbGlua2VyX2FkZHJfc3RhcnQgKwo+ID4gbG9hZF9hZGRy X3N0YXJ0O8KgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoAo+ID4gfcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoAo+ID4gwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoAo+ID4gX19saW5rZXJf YWRkcmVzczvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDC oMKgwqAgXAo+ID4gK8KgwqDCoCB9KQo+ID4gKwo+ID4gKy8qIENvbnZlcnQgYm9vdC10aW1lIFhl biBhZGRyZXNzIGZyb20gd2hlcmUgaXQgd2FzIGxvYWRlZCBieSB0aGUKPiA+IGJvb3QgbG9hZGVy IHRvIHRoZSBhZGRyZXNzIGl0IHdhcyBsYXllZCBvdXQKPiA+ICsgKiBhdCBsaW5rLXRpbWUuCj4g PiArICovCj4gCj4gQ29kaW5nIHN0eWxlOiBUaGUgZmlyc3QgbGluZSBpcyB0b28gbG9uZyBhbmQg bXVsdGktbGluZSBjb21tZW50cyBsb29rCj4gbGlrZToKPiAKPiAvKgo+IMKgICogRm9vCj4gwqAg KiBCYXIKPiDCoCAqLwo+IAo+ID4gKyNkZWZpbmUKPiA+IGxpbmtlcl9hZGRyKGxvYWRfYWRkcmVz cynCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqDCoCBcCj4gCj4gU2FtZSByZW1h cmsgYXMgZm9yIGxvYWRfYWRkcigpIGFib3ZlLgo+IAo+ID4gK8KgwqDCoAo+ID4gKHvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgCj4gPiDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqAgdW5zaWdu ZWQgbG9uZyBfX2xvYWRfYWRkcmVzcyA9ICh1bnNpZ25lZAo+ID4gbG9uZykobG9hZF9hZGRyZXNz KTvCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgIGlmICggbG9hZF9hZGRy X3N0YXJ0IDw9IF9fbG9hZF9hZGRyZXNzCj4gPiAmJsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgX19sb2FkX2FkZHJlc3MgPCBsb2FkX2FkZHJfZW5kCj4gPiApwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ ID4gK8KgwqDCoMKgwqDCoMKgCj4gPiB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKgwqAgXAo+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19sb2FkX2FkZHJlc3MKPiA+ID3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgX19sb2FkX2FkZHJlc3MgLSBsb2FkX2FkZHJfc3RhcnQgKwo+ID4gbGlu a2VyX2FkZHJfc3RhcnQ7wqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoAo+ ID4gfcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gwqDCoMKgIFwKPiA+ICvCoMKgwqDCoMKgwqDCoAo+ ID4gX19sb2FkX2FkZHJlc3M7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAKPiA+IMKgwqDCoCBcCj4gPiArwqDCoMKgIH0pCj4gPiArCj4gPiArc3RhdGljIHZv aWQgX19hdHRyaWJ1dGVfXygoc2VjdGlvbigiLmVudHJ5IikpKQo+ID4gK19zZXR1cF9pbml0aWFs X3BhZ2V0YWJsZXMocHRlX3QgKnNlY29uZCwgcHRlX3QgKmZpcnN0LCBwdGVfdAo+ID4gKnplcm9l dGgsCj4gQ2FuIHRoaXMgYmUgbmFtZWQgdG8gc2V0dXBfaW5pdGlhbF9tYXBwaW5nKCkgc28gdGhp cyBpcyBjbGVhcmVyIGFuZCAKPiBhdm9pZCB0aGUgb25lICdfJyBkaWZmZXJlbnQgd2l0aCB0aGUg ZnVuY3Rpb24gYmVsb3cuClN1cmUuIEl0IHdpbGwgYmUgYmV0dGVyLgo+IAo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIG1h cF9zdGFydCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgdW5zaWduZWQgbG9uZyBtYXBfZW5kLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIHBhX3N0YXJ0LAo+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBib29sIHdyaXRh YmxlKQo+IAo+IFdoYXQgYWJvdXQgdGhlIGV4ZWN1dGFibGUgYml0PwpJdCdzIGFsd2F5cyBleGVj dXRhYmxlLi4uIEJ1dCBhcyB5b3UgbWVudGlvbmVkIGFib3ZlIFBURV9MRUFGX0RFRkFVTFQKc2hv dWxkIGJlIGVpdGhlciBSWCBvciBSVy4KSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0byBhZGQgZmxh Z3MgaW5zdGVhZCBvZiB3cml0YWJsZS4KPiAKPiA+ICt7Cj4gPiArwqDCoMKgIHVuc2lnbmVkIGxv bmcgcGFnZV9hZGRyOwo+ID4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIGluZGV4MjsKPiA+ICvCoMKg wqAgdW5zaWduZWQgbG9uZyBpbmRleDE7Cj4gPiArwqDCoMKgIHVuc2lnbmVkIGxvbmcgaW5kZXgw Owo+IAo+IGluZGV4KiBjb3VsZCBiZSBkZWZpbmVkIGluIHRoZSBsb29wIGJlbG93LgpJdCBjb3Vs ZC4gQnV0IEkgYW0gY3VyaW91cyB3aHkgaXQgaXMgYmV0dGVyPwo+IAo+ID4gKwo+ID4gK8KgwqDC oCAvKiBhbGlnbiBzdGFydCBhZGRyZXNzZXMgKi8KPiA+ICvCoMKgwqAgbWFwX3N0YXJ0ICY9IFpF Uk9FVEhfTUFQX01BU0s7Cj4gPiArwqDCoMKgIHBhX3N0YXJ0ICY9IFpFUk9FVEhfTUFQX01BU0s7 Cj4gCj4gSG1tbS4uLiBJIHdvdWxkIGFjdHVhbGx5IGV4cGVjdCB0aGUgYWRkcmVzcyB0byBiZSBw cm9wZXJseSBhbGlnbmVkCj4gYW5kIAo+IHRoZXJlZm9yZSBub3QgcmVxdWlyZSBhbiBhbGlnbm1l bnQgaGVyZS4KPiAKPiBPdGhlcndpc2UsIHRoaXMgcmFpc2UgdGhlIHF1ZXN0aW9uIG9mIHdoYXQg aGFwcGVuIGlmIHlvdSBoYXZlIHJlZ2lvbiAKPiB1c2luZyB0aGUgc2FtZSBwYWdlPwpUaGF0IG1h cF9zdGFydCAmPSAgWkVST0VUSF9NQVBfTUFTSyBpcyBuZWVkZWQgdG8gcGFnZSBudW1iZXIgb2Yg YWRkcmVzcwp3L28gcGFnZSBvZmZzZXQuCgo+IAo+ID4gKwo+ID4gK8KgwqDCoCBwYWdlX2FkZHIg PSBtYXBfc3RhcnQ7Cj4gPiArwqDCoMKgIHdoaWxlICggcGFnZV9hZGRyIDwgbWFwX2VuZCApCj4g Cj4gTG9va2luZyBhdCB0aGUgbG9vcCwgaXQgbG9va3MgbGlrZSB5b3UgYXJlIGFzc3VtaW5nIHRo YXQgdGhlIHJlZ2lvbgo+IHdpbGwgCj4gbmV2ZXIgY3Jvc3MgYSBib3VuZGFyeSBvZiBhIHBhZ2Ut dGFibGUgKGVpdGhlciBMMCwgTDEsIEwyKS4gSSBhbSBub3QgCj4gY29udmluY2VkIHlvdSBjYW4g bWFrZSBzdWNoIGFzc3VtcHRpb24gKHNlZSBiZWxvdykuCj4gCj4gQnV0IGlmIHlvdSByZWFsbHkg d2FudCB0byBtYWtlIHN1Y2ggYXNzdW1wdGlvbiB0aGVuIHlvdSBzaG91bGQgYWRkCj4gc29tZSAK PiBndWFyZCAoZWl0aGVyIEJVSUxEX0JVR19PTigpLCBBU1NFUlQoKSwgcHJvcGVyIGNoZWNrKSBp biB5b3VyIGNvZGUgdG8KPiBhdm9pZCBhbnkgc3VycHJpc2UgaW4gdGhlIGZ1dHVyZS4KSSBhbSBu b3Qgc3VyZSB0aGF0IEkgZnVsbHkgdW5kZXJzdGFuZCB3aGF0IGlzIHRoZSBwcm9ibGVtIGhlcmUu ClRoZSBhZGRyZXNzIGlzIGFsaWduZWQgb24gKDE8PDEyKSBib3VuZGFyeSBhbmQgZWFjaCBpdGVh cmF0aW9uIGlzCm1hcHBlZCAoMTw8MTIpIHBhZ2Ugc28gYWxsIGxvb2tzIGZpbmUgb3IgSSBtaXN1 bmRlcnN0b29kIHlvdS4KPiAKPiA+ICvCoMKgwqAgewo+ID4gK8KgwqDCoMKgwqDCoMKgIGluZGV4 MiA9IHBhZ2V0YWJsZV9zZWNvbmRfaW5kZXgocGFnZV9hZGRyKTsKPiA+ICvCoMKgwqDCoMKgwqDC oCBpbmRleDEgPSBwYWdldGFibGVfZmlyc3RfaW5kZXgocGFnZV9hZGRyKTsKPiA+ICvCoMKgwqDC oMKgwqDCoCBpbmRleDAgPSBwYWdldGFibGVfemVyb2V0aF9pbmRleChwYWdlX2FkZHIpOwo+ID4g Kwo+ID4gK8KgwqDCoMKgwqDCoMKgIC8qIFNldHVwIGxldmVsMiB0YWJsZSAqLwo+ID4gK8KgwqDC oMKgwqDCoMKgIHNlY29uZFtpbmRleDJdID0gcGFkZHJfdG9fcHRlKCh1bnNpZ25lZCBsb25nKWZp cnN0KTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBzZWNvbmRbaW5kZXgyXS5wdGUgfD0gUFRFX1RBQkxF Owo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIC8qIFNldHVwIGxldmVsMSB0YWJsZSAqLwo+ID4g K8KgwqDCoMKgwqDCoMKgIGZpcnN0W2luZGV4MV0gPSBwYWRkcl90b19wdGUoKHVuc2lnbmVkIGxv bmcpemVyb2V0aCk7Cj4gPiArwqDCoMKgwqDCoMKgwqAgZmlyc3RbaW5kZXgxXS5wdGUgfD0gUFRF X1RBQkxFOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIC8qIFNldHVwIGxldmVsMCB0YWJsZSAq Lwo+ID4gK8KgwqDCoMKgwqDCoMKgIGlmICggIXB0ZV9pc192YWxpZCgmemVyb2V0aFtpbmRleDBd KSApCj4gCj4gQ2FuIHlvdSBleHBsYWluIHdoeSB5b3UgYXJlIGNoZWNraW5nICFwdGVfaXNfdmFs aWQoKSBmb3IgdGhlIEwwIGVudHJ5Cj4gYnV0IG5vdCB0aGUgb3RoZXI/Ck15IG1pc3Rha2UgaXQg c2hvdWxkIGJlIGNoZWNrZWQgZm9yIGVhY2ggbGV2ZWwuCj4gCj4gPiArwqDCoMKgwqDCoMKgwqAg ewo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogVXBkYXRlIGxldmVsMCB0YWJsZSAqLwo+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgemVyb2V0aFtpbmRleDBdID0gcGFkZHJfdG9fcHRl KChwYWdlX2FkZHIgLSBtYXBfc3RhcnQpCj4gPiArIHBhX3N0YXJ0KTsKPiA+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHplcm9ldGhbaW5kZXgwXS5wdGUgfD0gUFRFX0xFQUZfREVGQVVMVDsKPiA+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHplcm9ldGhbaW5kZXgwXS5wdGUgJj0gfigoIXdyaXRh YmxlKSA/IFBURV9XUklUQUJMRSA6Cj4gPiAwKTsKPiAKPiBMb29raW5nIGF0IHRoZSBkZWZhdWx0 IHZhbHVlLCBpdCB3b3VsZCBtZWFuIHRoYXQgYSBub24td3JpdGFibGUKPiBtYXBwaW5nIAo+IGlz IGF1dG9tYXRpY2FsbHkgZXhlY3V0YWJsZS4gVGhpcyBzZWVtcyB3cm9uZyBmb3IgdGhlIHNlY3Rp b24gaXMgbm90IAo+IG1lYW50IHRvIGJlIGV4ZWN1dGFibGUgKGxpa2Ugcm9kYXRhKS4KWWVzLCB5 b3UgYXJlIHJpZ2h0LiBJJ2xsIHJlb3dyayBzZXR1cF9pbml0aWFsX21hcHBpbmcoKSB0byBwYXNz IGZsYWdzCmluc3RlYWQgb2Ygd3JpdGUvcmVhZCAtIG9ubHkgZmxhZy4KPiAKPiA+ICvCoMKgwqDC oMKgwqDCoCB9Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqAgLyogUG9pbnQgdG8gbmV4dCBwYWdl ICovCj4gPiArwqDCoMKgwqDCoMKgwqAgcGFnZV9hZGRyICs9IFpFUk9FVEhfU0laRTsKPiA+ICvC oMKgwqAgfQo+ID4gK30KPiA+ICsKPiA+ICsvKgo+ID4gKyAqIHNldHVwX2luaXRpYWxfcGFnZXRh YmxlczoKPiA+ICsgKgo+ID4gKyAqIDEpIEJ1aWxkIHRoZSBwYWdlIHRhYmxlcyBmb3IgWGVuIHRo YXQgbWFwIHRoZSBmb2xsb3dpbmc6Cj4gPiArICrCoMKgIDEuMSnCoCBUaGUgcGh5c2ljYWwgbG9j YXRpb24gb2YgWGVuICh3aGVyZSB0aGUgYm9vdGxvYWRlcgo+ID4gbG9hZGVkIGl0KQo+ID4gKyAq wqDCoCAxLjIpwqAgVGhlIGxpbmstdGltZSBsb2NhdGlvbiBvZiBYZW4gKHdoZXJlIHRoZSBsaW5r ZXIKPiA+IGV4cGVjdGVkIFhlbidzCj4gPiArICrCoMKgwqDCoMKgwqDCoMKgIGFkZHJlc3NlcyB0 byBiZSkKPiA+ICsgKiAyKSBMb2FkIHRoZSBwYWdlIHRhYmxlIGludG8gdGhlIFNBVFAgYW5kIGVu YWJsZSB0aGUgTU1VCj4gPiArICovCj4gPiArdm9pZCBfX2F0dHJpYnV0ZV9fKChzZWN0aW9uKCIu ZW50cnkiKSkpCj4gCj4gSSBjb3VsZG4ndCBmaW5kIGEgc2VjdGlvbiAiLmVudHJ5IiBpbiB0aGUg bGlua2VyLgo+IAo+ID4gK3NldHVwX2luaXRpYWxfcGFnZXRhYmxlcyh1bnNpZ25lZCBsb25nIGxv YWRfYWRkcl9zdGFydCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgdW5zaWduZWQgbG9uZyBsb2FkX2FkZHJfZW5kLAo+ID4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGxpbmtl cl9hZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGxpbmtlcl9hZGRyX2VuZCkKPiA+ICt7Cj4gPiArwqDC oMKgIHB0ZV90ICpzZWNvbmQ7Cj4gPiArwqDCoMKgIHB0ZV90ICpmaXJzdDsKPiA+ICvCoMKgwqAg cHRlX3QgKnplcm9ldGg7Cj4gPiArCj4gPiArwqDCoMKgIGNsZWFyX3BhZ2V0YWJsZXMobG9hZF9h ZGRyX3N0YXJ0LCBsb2FkX2FkZHJfZW5kLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgbGlua2VyX2FkZHJfc3RhcnQsIGxpbmtlcl9hZGRyX2VuZCk7Cj4gPiAr Cj4gPiArwqDCoMKgIC8qIEdldCB0aGUgYWRkcmVzc2VzIHdoZXJlIHRoZSBwYWdlIHRhYmxlcyB3 ZXJlIGxvYWRlZCAqLwo+ID4gK8KgwqDCoCBzZWNvbmTCoCA9IChwdGVfdCAqKWxvYWRfYWRkcigm eGVuX3NlY29uZF9wYWdldGFibGUpOwo+ID4gK8KgwqDCoCBmaXJzdMKgwqAgPSAocHRlX3QgKils b2FkX2FkZHIoJnhlbl9maXJzdF9wYWdldGFibGUpOwo+ID4gK8KgwqDCoCB6ZXJvZXRoID0gKHB0 ZV90ICopbG9hZF9hZGRyKCZ4ZW5femVyb2V0aF9wYWdldGFibGUpOwo+IAo+IEkgd291bGQgY29u c2lkZXIgdG8gZW1iZWQgdGhlIHR5cGUgY2FzdCBpbiBsb2FkX2FkZHIoKSBzbyB5b3UgYXJlCj4g YWRkaW5nIAo+IHNvbWUgdHlwZSBzYWZldHkgd2l0aGluIHlvdXIgY29kZS4KRGVmaW5pdGVseSBp dCB3aWxsIGJlIGJldHRlciBidXQgc2V0dXBfaW5pdGlhbF9tYXBwaW5nKCkgdXNlcyAndW5zaWdu ZWQKbG9uZycgZm9yIHBhc3NpbmcgYWRkcmVzcyB0aGF0IHNob3VsZCBiZSBtYXBwZWQuCj4gCj4g PiArCj4gPiArwqDCoMKgIC8qCj4gPiArwqDCoMKgwqAgKiBDcmVhdGUgYSBtYXBwaW5nIGZyb20g WGVuJ3MgbGluay10aW1lIGFkZHJlc3NlcyB0byB3aGVyZQo+ID4gdGhleSB3ZXJlIGFjdHVhbGx5 IGxvYWRlZC4KPiAKPiBUaGlzIGlzIGxpbmUgaXMgd2F5IGxvbmcgdGhhbiA4MCBjaGFyYWN0ZXJz LiBQbGVhc2UgbWFrZSBzdXJlIHRvIHdyYXAKPiBpdCAKPiA4MCBjaGFyYWN0ZXJzLgo+IAo+ID4g K8KgwqDCoMKgICovCj4gPiArwqDCoMKgIF9zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMoc2Vjb25k LCBmaXJzdCwgemVyb2V0aCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGxpbmtlcl9hZGRyKCZfc3RleHQpLAo+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGlu a2VyX2FkZHIoJl9ldGV4dCksCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsb2FkX2FkZHIoJl9zdGV4dCksCj4gPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmYWxz ZSk7Cj4gPiArwqDCoMKgIF9zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMoc2Vjb25kLCBmaXJzdCwg emVyb2V0aCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGxpbmtlcl9hZGRyKCZfX2luaXRfYmVnaW4pLAo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGlua2Vy X2FkZHIoJl9faW5pdF9lbmQpLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbG9hZF9hZGRyKCZfX2luaXRfYmVnaW4pLAo+ID4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgdHJ1ZSk7Cj4gPiArwqDCoMKgIF9zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMoc2Vjb25kLCBm aXJzdCwgemVyb2V0aCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGxpbmtlcl9hZGRyKCZfc3JvZGF0YSksCj4gPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsaW5r ZXJfYWRkcigmX2Vyb2RhdGEpLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbG9hZF9hZGRyKCZfc3JvZGF0YSksCj4gPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBm YWxzZSk7Cj4gPiArwqDCoMKgIF9zZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMoc2Vjb25kLCBmaXJz dCwgemVyb2V0aCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGxpbmtlcl9hZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGlua2VyX2FkZHJf ZW5kLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgbG9hZF9hZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdHJ1ZSk7Cj4gCj4gV2hlcmUgZG8g eW91IGd1YXJhbnRlZSB0aGF0IFhlbiB3aWxsIGFsd2F5cyBmaXQgaW4gYW4gTDAgdGFibGUgYW5k Cj4gdGhlIAo+IHN0YXJ0IGFkZHJlc3MgaXMgYWxpZ25lZCB0byB0aGUgc2l6ZSBvZiBhbiBMMCB0 YWJsZT8KSSBkb24ndCBndWFyYW50ZWUgdGhhdCBpdCBmaXQgaW4gYW4gTDAgdGFibGUgYnV0IHRo ZSBzdGFydCBhZGRyZXNzIGlzCmFsaWduZWQgdG8gdGhlIHNpemUgb2YgdGhlIEwwIHRhYmxlIGF0 IHRoZSBzdGFydC4KPiAKPiA+ICsKPiA+ICvCoMKgwqAgLyoKPiA+ICvCoMKgwqDCoCAqIENyZWF0 ZSBhIG1hcHBpbmcgb2YgdGhlIGxvYWQgdGltZSBhZGRyZXNzIHJhbmdlIHRvLi4uIHRoZQo+ID4g bG9hZCB0aW1lIGFkZHJlc3MgcmFuZ2UuCj4gCj4gU2FtZSBhYm91dCB0aGUgbGluZSBsZW5ndGgg aGVyZS4KPiAKPiA+ICvCoMKgwqDCoCAqIFRoaXMgbWFwcGluZyBpcyB1c2VkIGF0IGJvb3QgdGlt ZSBvbmx5Lgo+ID4gK8KgwqDCoMKgICovCj4gPiArwqDCoMKgIF9zZXR1cF9pbml0aWFsX3BhZ2V0 YWJsZXMoc2Vjb25kLCBmaXJzdCwgemVyb2V0aCwKPiAKPiBUaGlzIGNhbiBvbmx5IHdvcmsgaWYg WGVuIGlzIGxvYWRlZCBhdCBpdHMgbGlua2VkIGFkZHJlc3MuIFNvIHlvdQo+IG5lZWQgYSAKPiBz ZXBhcmF0ZSBzZXQgb2YgTDAsIEwxIHRhYmxlcyBmb3IgdGhlIGlkZW50aXR5IG1hcHBpbmcuCj4g Cj4gVGhhdCBzYWlkLCB0aGlzIHdvdWxkIG5vdCBiZSBzdWZmaWNpZW50IGJlY2F1c2U6Cj4gwqDC oCAxKSBYZW4gbWF5IG5vdCBiZSBsb2FkZWQgYXQgYSAyTSBib3VuZGFyeSAoeW91IGNhbiBjb250 cm9sIHdpdGggCj4gVS1ib290LCBidXQgbm90IHdpdGggRUZJKS4gU28gdGhpcyBtYXkgY3Jvc3Mg YSBib3VuZGFyeSBhbmQgdGhlcmVmb3JlCj4gbmVlZCBtdWx0aXBsZSBwYWdlcy4KPiDCoMKgIDIp IFRoZSBsb2FkIHJlZ2lvbiBtYXkgb3ZlcmxhcCB0aGUgbGluayBhZGRyZXNzCj4gCj4gV2hpbGUg SSB0aGluayBpdCB3b3VsZCBiZSBnb29kIHRvIGhhbmRsZSB0aG9zZSBjYXNlcyBmcm9tIHRoZSBz dGFydCwKPiBJIAo+IHdvdWxkIHVuZGVyc3RhbmQgd2h5IGFyZSBub3QgZWFzeSB0byBzb2x2ZS4g U28gSSB0aGluayB0aGUgbWluaW11bSBpcwo+IHRvIAo+IHRocm93IHNvbWUgZXJyb3JzIGlmIHlv dSBhcmUgaW4gYSBjYXNlIHlvdSBjYW4ndCBzdXBwb3J0LgpEbyB5b3UgbWVhbiB0byB0aHJvdyBz b21lIGVycm9yIGluIGxvYWRfYWRkcigpL2xpbmtkZXJfYWRkcigpPwo+IAo+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbG9hZF9h ZGRyX3N0YXJ0LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgbG9hZF9hZGRyX2VuZCwKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGxvYWRfYWRkcl9zdGFydCwK PiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHRydWUpOyA+ICsKPiA+ICvCoMKgwqAgLyogRW5zdXJlIHBhZ2UgdGFibGUgd3JpdGVz IHByZWNlZGUgbG9hZGluZyB0aGUgU0FUUCAqLwo+ID4gK8KgwqDCoCBhc20gdm9sYXRpbGUoInNm ZW5jZS52bWEiKTsKPiA+ICsKPiA+ICvCoMKgwqAgLyogRW5hYmxlIHRoZSBNTVUgYW5kIGxvYWQg dGhlIG5ldyBwYWdldGFibGUgZm9yIFhlbiAqLwo+ID4gK8KgwqDCoCBjc3Jfd3JpdGUoQ1NSX1NB VFAsCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxvYWRfYWRkcih4ZW5fc2Vjb25k X3BhZ2V0YWJsZSkgPj4gUEFHRV9TSElGVCkgfAo+ID4gU0FUUF9NT0RFX1NWMzkgPDwgU0FUUF9N T0RFX1NISUZUKTsKPiAKPiBJSE1PLCBpdCB3b3VsZCBtYWtlIHNlbnNlIHRvIGludHJvZHVjZSB3 aXRoaW4gdGhlIHNlcmllcyB0aGUgY29kZSB0byAKPiBqdW1wIG9mZiB0aGUgaWRlbnRpdHkgbWFw cGluZyBhbmQgdGhlbiByZW1vdmUgaXQuClByb2JhYmx5IEkgaGF2ZSB0byBzcGVuZCBtb3JlIHRp bWUgdG8gdW5kZXJzdGFuZCBpZGVudGl0eSBtYXBwaW5nIGJ1dAppdCBsb29rcyBsaWtlIGN1cnJl bnQgIG9uZSBSSVNDLVYgcG9ydCBmcm9tIEJvYmJ5J3MgZG9lc24ndCBqdW1wIG9mZgphbmQgcmVt b3ZlIHRoZSBpZGVudGl0eSBtYXBwaW5nLgo+IAo+ID4gKwo+ID4gK8KgwqDCoCBwaHlzX29mZnNl dCA9IGxvYWRfYWRkcl9zdGFydCAtIGxpbmtlcl9hZGRyX3N0YXJ0Owo+ID4gKwo+ID4gK8KgwqDC oCByZXR1cm47Cj4gPiArfQo+IAo+IENoZWVycywKPiAKfiBPbGVrc2lpCg== From xen-devel-bounces@lists.xenproject.org Mon Feb 27 16:56:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 16:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502829.774832 (Exim 4.92) (envelope-from ) id 1pWgnH-0004yV-7x; Mon, 27 Feb 2023 16:56:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502829.774832; Mon, 27 Feb 2023 16:56:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgnH-0004yO-41; Mon, 27 Feb 2023 16:56:07 +0000 Received: by outflank-mailman (input) for mailman id 502829; Mon, 27 Feb 2023 16:56:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWgnG-0004yG-Dz for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 16:56:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ec5ee76-b6bf-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 17:56:04 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8641.eurprd04.prod.outlook.com (2603:10a6:20b:428::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 16:55:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 16:55:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ec5ee76-b6bf-11ed-a82a-c9ca1d2f71af ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cA8WQKWUgoLB54fKstOXVAzWhEb+2Z5KgBcBMMuSIGu7+xsiDHRSAM99PiJZi781Ul9g02ahtst4xA4ZlPu6MgL3d7Fzsd9qGQZAgNSYZhC4uKUJL+23EIixidIR8r9pQlHYDUN/gaYRB5t6lIie77fT9Nati/JFqnFRQO9Qk73UGQ7Z7J5OCQ2mX2V3TnjWpGOl0iAFu39ey/42ctj6k05ZiZY2f9vlkXSE59vFOH9DNED8FXTDtXVR9CGU2Reox+xUKoLdsQl27ouiSgnpQO3fs1nkPTpbxJfrT5q2sVKImOSuttC2EJioZKW5s6kQCdqGwRgcPoFAGCsCPE7otg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0J3ewT9MFOG2BqMeY/Msa0rH9hQug4Apo/qJD+XOAF8=; b=B3MjriUBWvm3En64ggj1lH0BLwkc+avphNkhpkqIDSb+gE8x9GhR9UK92AQZSXZ2OLDUrXPyDnRcaArmjxXZZAr8oKhVIIKoHThz6GcnMvHwQNCWzP6Mqu9K2CvaZiMzT/+3PQXN9fiVHifLb6bbolE1orLOKNsGsVjFSTCsdmuukZdChI/GRYTrKtPn4aOyTy6yALidg+Tu5MezIhaaAPR5qKX733ZkI4gD2SikRKEe5jg7vqyB6iuZdg7HK8j0Edw1YvS+UKpo4cDltFxnV9ODu888aJBDi//NFV2q017MoyUbcn3y/qgccBg5Ol/2UnNlIK6AalBdgSuZthFLVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0J3ewT9MFOG2BqMeY/Msa0rH9hQug4Apo/qJD+XOAF8=; b=wdIVj+plSPcpUx53SrMERzJ6FV4szQVL2G8DBJYjZBNjL/SCkBPKljdpBP/gwt3MnOXbbGOP1vDtwZ/1zkLW2d7Hfm2Ykwa+eD0KScYU8/mxlohGJityRseOYh+kexYOJT/vBvrUCFLN9Cv3Qm12w03+ULCeRoypHcq1glr+iGoZjN196O8XdSwUueCyejytT3GT7LlEKd7LObFvf0oE5RdI4a1oRSQuQs2MnP1rN7jg3Ialmosgvq7XjPrVjJA2kzpwJy2K4UDJK1zEhpPnPRCeupKe1xQfVELBg0NIMYIsZmybpqZqJAStHwGB6MpTsSY7d/429fn0/HAncxWkdA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0914b98c-0813-d28b-d150-c26d0c37a132@suse.com> Date: Mon, 27 Feb 2023 17:55:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Kevin Tian , xen-devel@lists.xenproject.org References: <20230226000822.42384-1-marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <20230226000822.42384-1-marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8641:EE_ X-MS-Office365-Filtering-Correlation-Id: a8684822-a424-488f-0cca-08db18e37103 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dlyTyBtZiJEEmVuVjHtjLJtuCjv8cXmOn7eAlGLLYBftHHULXT0BWfI9u0i0ApFBDtFhCViGd1F/hMh5EyFNXlej3+8Wp3TVkhXDuHoWT5PH3JoJxcKJmiXli8ka6E6dUOqUUHJNoKXVGYvwbjJeFx0QRcgMxdlTJLqa9EaBLYMylpWFhObI8QKuPfYp8cbykaIN33XdaohcES42po0QuRyfH/jS4B/GvpTbw6XFFBdj27e+n9lc97+4N23ir9AaJ5WFpdnMmitU3HhUeq3RbF/CmPoetg57II/FfS6CZywam31WdSWxn610wmDTsVu52N3OSB7G5J3vaJB1e19Va60+mQWSWiR+UU3AQ4BoZcvudhgugTEf9QJroX9z6mIo6l4m4RNPKNr8tSeZCOLxy0oRZhrFGWu10ectxh0uk8mxmEiF1DcoetvWVAQO2fjBnVY0ytacHUZpTYFekPsP34szs8gZvV6Ec094bpSBGG+iNL0HeE63TL2o5yMXuMT+yqDL4M5MR+9vN/bEbGxWK8wuY7T0Nes9H7xVCi2SeBvMFEvSXTS5EvKCg5mLIldXr2PKoT0+AWTOKHvocDVL91Tp8w2kf2ZpORpNi4smzYLhi4dzGbTcxojRStShzzgpfOqxpi1skLuqK8+yqO37/Uv+FQ/UNDSgMPUMaNC9RVnO9uLUHIFPSS+0wOqSdYbxg0+4QOFMUb7kL5yd2SFyBSX9KdjuwUIlfGIQFz2xH5k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199018)(66899018)(31686004)(2616005)(316002)(36756003)(31696002)(86362001)(6486002)(186003)(8676002)(5660300002)(2906002)(66556008)(8936002)(6512007)(66476007)(4326008)(66946007)(41300700001)(478600001)(53546011)(66574015)(6506007)(6916009)(26005)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG5lcDRrV0tkVlJGbUJ1TnMrNlgzOVI1Q2xTVXpnMDFybnEyT0JqTFJGZGh6?= =?utf-8?B?QUp2RGVlVUxTbEI4SUZCV3lpekhDcTNkUS8vdTdTeVZRcC9hQnZKM1M3b3lR?= =?utf-8?B?RDFXZ0Y4RUtzaUN6c3NaR0p3dnZaZWRiVDZ0TnQweEgzclBUd3I4TU5ET3RO?= =?utf-8?B?Q3F6T3g0S2VxdytWQnU1WDZHcmh2ZFNhUlhDZmk3Vmk3S2RHL0wxTXJ5aW1P?= =?utf-8?B?U2pUZjc5aGUrUUExVE1ZclE0bU9zR1R6Qjl6ZkZuWUJVMGN0Y0wwTHByNFVF?= =?utf-8?B?cmZxNW95WWxDdVFTYjZ1QVlsUGs2Zk9BY0N1T0ViOTVkaEp2NVN2S0M4QTNh?= =?utf-8?B?RSs0QXVHbTVTODM3VDFDQmdrT1pnQWlzRlRHQTVMVlE3RXl0UXFmeDFXeFRo?= =?utf-8?B?dHpwcFpxamdjVkNVeU9oVm5DdDlERHR1bTNGQXNEZEJrZ0hrbnUvbUk5ejFV?= =?utf-8?B?SkV4RCtiTVNiWW5VRzY1aWVieSt5eFdMenBZQ0FHTlJNeElmVXBxV21TaTQ0?= =?utf-8?B?QlRGSUFsUm9hUFF3K09vd0s4d0JQMFRMVDgrQ0NIRDdHUWdYT1ZwVDA4Sm8y?= =?utf-8?B?ZFI4aUlrWmNlNmxhMEE2c1hxeGJpYTFCWS92aVZyNUoxRDdmait4SlNLRDhL?= =?utf-8?B?VkUvRkhRb012U2craTIvQ2xJdTlMMG1GT0hhcFdveGZzeW52NlV1RkZmU1FU?= =?utf-8?B?ME5wS2pCcDZLcnpRTEI4cjk2djJNMHJxTXJUR0xvajlWQWRsVDZjNytSSUV2?= =?utf-8?B?aC95NVd1OCtxU05CWHNtbkp6Rm8wYjRjVkJsNkwrRWIyN21BTmtJazdzbDdh?= =?utf-8?B?M3VIQVRUZGg1OVhNZ0tSeU13Y1I1a1FOcjNQWkJ3TUtMY3VMa2lCUVc4M0dB?= =?utf-8?B?NGVFOHJnQjg2MDd2NWJGQ21FdUh4MVNLMWw5ZDFvVjI5MC9JbEVKN0toRHBE?= =?utf-8?B?a2VKWTlKQWR5S0U5elNNRnNlK1FVa3lLWXlPWHV6a2lQY0t3Y3ZEQ2pPS0s4?= =?utf-8?B?K0YwM0VMQ2JLaENnbHQzUjVXbGptQTh2eGtNRVMyb3ZXSUx4b2tKeDFoOXdG?= =?utf-8?B?ekxXSlFnY0lKVldWdXJkQjZxVjk3SHkzYzQzYXhuZmNjMmFocnRtdmsyUjFu?= =?utf-8?B?SE03Q0hRdHpnS0s0T1IzRGNrTGJDaW0ya2g2dUpFRWhhQWdNK0E2K2tUUzRT?= =?utf-8?B?YmJRWkUrQXFjZ0l1OVlZdExWOEhBanpRWkE2Nkdta0hOait6czBTcWs2Z0tD?= =?utf-8?B?SUZtRWRGNTBDbnFReGxZWkNYdE40V0R3WGxFNzlUVkxKWDMvYUdKWlRwb1RR?= =?utf-8?B?dnJ2RmE5U05zSU5meXFGOUJOWHQ0ZUMyS1ZXVmFGWEhJT2M4ZVdwbDh6UmQ5?= =?utf-8?B?Nmw4clBUcTRvbTNFZWhtSXE4ZFV1VkY0d0ZhSytNR1llRXp5cTN5OGROUUlW?= =?utf-8?B?eHQ5NEIrUnpadnVCWnZtZTlLYlpEa2FpRk5kMGRETTBRbXFKWHorUDIwcDQr?= =?utf-8?B?bTB0b1dFdHNCVUJOVU1mTGNXTFRYcllBb3NVa1U4eWFWcitsc1pSNWIrdko5?= =?utf-8?B?MXluVW1qNEpra1Roa215dnhwbXFOdG43ZXNKd1FZcVk5YjV2WTRTS0ZySUZS?= =?utf-8?B?RnRxT3ZEMjNvQ3d5T3RMZWFWTTdYWDUvdU5ONmFaN012K1VpTlpZYlNWWUxw?= =?utf-8?B?WlIwU3B2Qy9YNFArQlk5dVdoK2NxUXFnOGg4eDNaR2tuSUxnK2Y3eGJyUmM1?= =?utf-8?B?byttK0JZVzdaTHBoeG43cXlya3hndEFxbVluMnpxdDgyVFdvQVYyc1lhYVhF?= =?utf-8?B?YjdkQ2hQQUpRSXpTR3oyMWZlaHBDcWVhOU9ENkE4Vk9NWStHZHdmbUZvcnM1?= =?utf-8?B?TVoyOVg2a1NhUUQ3VzBITlBjK3djSmNTYjlXdDZQUWJTQ3lOT2VuQ0k2em5a?= =?utf-8?B?Nlh1cVBxUzFRdnc5ZndrTm45c3A0M000bUp1NWtVNzdCaTFMYWorWE5Id2o4?= =?utf-8?B?VTRXN29IU3RSS0hRZlFUSy85WEdPdXF4a0JuMG9qenZNVzZIOWtLYmJPcEtj?= =?utf-8?B?RHVaYXpXOWkvWGZVSmhlSGkxdHVGa1BrS1pjZ0lqdXJkdHAxaTE4YVp3Zy9u?= =?utf-8?Q?efCEBlBmZN92vzc7PEfkT5X1P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8684822-a424-488f-0cca-08db18e37103 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 16:55:33.7756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQoPYPu/oLMYYmprILMfJGV+A46UARSXNXz1KNFqtf3c393qA0nILMrT1ZTBXNEjLBQBqi6lQISD6VIqy2cYEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8641 On 26.02.2023 01:08, Marek Marczykowski-Górecki wrote: > If the scope for IGD's IOMMU contains additional device that doesn't > actually exist, iommu=no-igfx would not disable that IOMMU. In this > particular case (Thinkpad x230) it included > 00:02.1, but there is no such device on this platform. > Consider only existing devices for "gfx only" check. > Hmm, perhaps Fixes: 2d7f191b392e ('VT-d: generalize and correct "iommu=no-igfx" handling') ? > Signed-off-by: Marek Marczykowski-Górecki > --- > I have looked at existence check acpi_parse_one_drhd(), but re-using > that one wouldn't work for two reasons: > - gfx_only logic is very much tied to acpi_parse_dev_scope() I think this one could be dealt with, but ... > - pci_device_detect() in acpi_parse_one_drhd() is skipped in case of > (implicit or explicit) iommu=force ... I agree this is a good reason to put the check in acpi_parse_dev_scope(). > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthrough/vtd/dmar.c > @@ -396,6 +396,7 @@ static int __init acpi_parse_dev_scope( > igd_drhd_address = drhd->address; > > if ( gfx_only && > + pci_device_detect(seg, bus, path->dev, path->fn) && > pci_conf_read8(PCI_SBDF(seg, bus, path->dev, path->fn), > PCI_CLASS_DEVICE + 1) != 0x03 > /* PCI_BASE_CLASS_DISPLAY */ ) If we're adding an existence check, then maybe better in the surrounding if(): Setting igd_drhd_address when there's not really a device at the designated address isn't very sensible either. (In fact I think I'm going to alter the inner part of that if() again as well.) Jan From xen-devel-bounces@lists.xenproject.org Mon Feb 27 17:17:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 17:17:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502835.774842 (Exim 4.92) (envelope-from ) id 1pWh7a-00088g-WE; Mon, 27 Feb 2023 17:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502835.774842; Mon, 27 Feb 2023 17:17:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWh7a-00088Z-SO; Mon, 27 Feb 2023 17:17:06 +0000 Received: by outflank-mailman (input) for mailman id 502835; Mon, 27 Feb 2023 17:17:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWh7a-00088T-1A for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 17:17:06 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d780928-b6c2-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 18:17:03 +0100 (CET) Received: by mail-lj1-x22e.google.com with SMTP id z42so7197282ljq.13 for ; Mon, 27 Feb 2023 09:17:03 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id b15-20020a2e988f000000b0029599744c02sm806368ljj.75.2023.02.27.09.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 09:17:02 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d780928-b6c2-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ZmBDKNUPDF5/6k02WURTwKtK8hP0cnZH3gnLZ0vsKqY=; b=fTfmiGmNowgJdmHo9aHhG8N03I6wPkruq3KKaZIjVUVlRmxYXoogeotwuPknvk4+Lg G8fZEmYEKW7x/kUosVYRYD5Xc7FL67baY0jhQqYXK5ShHOa+No9VSfEEIe5XumRIudfe xaRi6MCgvq42KKicsYtHieWKhLgF9Pa0P7LgJFdBnUpgLvWwk1lwD5lTKj1FLG0iI7+h +7XOYIZj/qx1fOXQCQftVW4zBqQNVXmB6ZEPxHgssyEysBKpUmB7BFqw2J/iSRdWXHFn dHrnzB4AryQorTlfoRnllprREu+fr9NhYXHQrRzYyOdZlcS93ROStliL/MkUz7czProX pgXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZmBDKNUPDF5/6k02WURTwKtK8hP0cnZH3gnLZ0vsKqY=; b=3Pwdwi8rweOY/XuFpFWQd5RKmesxiE7vHWZsFztG+WVDlt9QNhqATBr+XJ2sJ+IjFx KL/3hZygNO6+CoeB+zp9akqxpnlApw6Qu9HbUt9Fz8bXQLruDfg1z3zYPEN1SP+fH9yj Cu+y90pvfK5EAt6AEYJpU7xXkrX8cS8SlL42MiJJy9YaqCk63BSdce6PS4ugjJwZUVKK FFVuRdYN9zbeYoI//85dz4RBzm8E6b/H0dAFreTUu5n7Lb3jsGmzP+cuG0JHzj3lWbMg V1sqlBKL6EYZAmSpxWQXbi9YLiHTzyIL1HN6BIDpeGB7vkOq2xqnofJfcLSlAt13f9GW 7khw== X-Gm-Message-State: AO0yUKXSuVVbO46yo6oj5IqffnkCMZYQkHDzGXQW4Qqh+VO8ejqFCpeO h6174H3CFHU9c7mOVH7ok1Q= X-Google-Smtp-Source: AK7set9Z86gIV1i4uNaiNwfHMGoLQvnGDSzsCJTAzKzAbTTJN1UGsYFujB4c3piXRIG93SsRh/iVYw== X-Received: by 2002:a2e:1414:0:b0:293:4b96:1b6b with SMTP id u20-20020a2e1414000000b002934b961b6bmr8789797ljd.25.1677518222778; Mon, 27 Feb 2023 09:17:02 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis Date: Mon, 27 Feb 2023 19:17:01 +0200 In-Reply-To: <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> References: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Sat, 2023-02-25 at 18:05 +0000, Julien Grall wrote: > Hi, >=20 > On 24/02/2023 15:06, Oleksii Kurochko wrote: > > Calculate load and linker linker image addresses and > > setup initial pagetables. > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > =C2=A0 xen/arch/riscv/setup.c | 11 +++++++++++ > > =C2=A0 1 file changed, 11 insertions(+) > >=20 > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > > index b7cd438a1d..f69bc278bb 100644 > > --- a/xen/arch/riscv/setup.c > > +++ b/xen/arch/riscv/setup.c > > @@ -1,9 +1,11 @@ > > =C2=A0 #include > > =C2=A0 #include > > =C2=A0 #include > > +#include > > =C2=A0=20 > > =C2=A0 #include > > =C2=A0 #include > > +#include > > =C2=A0 #include > > =C2=A0=20 > > =C2=A0 /* Xen stack for bringing up the first CPU. */ > > @@ -43,6 +45,11 @@ static void __init disable_fpu(void) > > =C2=A0=20 > > =C2=A0 void __init noreturn start_xen(void) > > =C2=A0 { > > +=C2=A0=C2=A0=C2=A0 unsigned long load_start=C2=A0=C2=A0=C2=A0 =3D (uns= igned long)start; > > +=C2=A0=C2=A0=C2=A0 unsigned long load_end=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 =3D load_start + (unsigned > > long)(_end - _start); >=20 > I am a bit puzzled, on top of load_addr() and linker_addr(), you > wrote=20 > it can't use global variable/function. But here... you are using > them.=20 > So how is this different? I don't use load_addr() and linker_addr() macros here. >=20 > > +=C2=A0=C2=A0=C2=A0 unsigned long linker_start=C2=A0 =3D (unsigned long= )_start; > > +=C2=A0=C2=A0=C2=A0 unsigned long linker_end=C2=A0=C2=A0=C2=A0 =3D (uns= igned long)_end; >=20 > I am a bit confused with how you define the start/end for both the=20 > linker and load. In one you use _start and the other _end. >=20 > Both are fixed at compile time, so I assume the values will be a > linked=20 > address rather than the load address. So how is this meant to how? >=20 _start, _end - it is label from linker script so I use them to define linker_start and linker_end addresses. load_start is defined as an address of start() function from head.S and load_end is the load_start + the size (_end - _start) > Furthermore, I would expect linker_start and load_start to point to > the=20 > same symbol (the only different is one store the virtual address > whereas=20 > the other the physical address). But here you are technically using > two=20 > different symbol. Can you explain why? It is used to make identity mapping for the range [load_addr, load_end] and [linker_addr, linker_end]. It was done so because in Bobby's patches in the linker script XEN_VIRT_START is defined as _AT(vaddr_t,0x00200000) but bootloader loads Xen at 0x80200000 and so in this case loadr_addr !=3D linker_addr. But I have changed XEN_VIRT_START to 0x8020...00 so they are equal now. >=20 > > + > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * The following things are passed = by bootloader: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *=C2=A0=C2=A0 a0 -> hart_id > > @@ -65,6 +72,10 @@ void __init noreturn start_xen(void) > > =C2=A0=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 test_macros_from_bug_h(); > > =C2=A0=20 > > +=C2=A0=C2=A0=C2=A0 setup_initial_pagetables(load_start, load_end, link= er_start, > > linker_end); >=20 > Shouldn't this happen earlier in start_xen()? It can. If to be honest I don't know if it should. I added at the end only because it was the last thing I worked on... >=20 > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Mon Feb 27 17:36:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 17:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502842.774852 (Exim 4.92) (envelope-from ) id 1pWhQL-0002rV-HT; Mon, 27 Feb 2023 17:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502842.774852; Mon, 27 Feb 2023 17:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhQL-0002rO-EW; Mon, 27 Feb 2023 17:36:29 +0000 Received: by outflank-mailman (input) for mailman id 502842; Mon, 27 Feb 2023 17:36:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhQJ-0002rI-W2 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 17:36:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhQJ-0006rY-Di; Mon, 27 Feb 2023 17:36:27 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.16.186]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWhQJ-0005Jc-3r; Mon, 27 Feb 2023 17:36:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dho0XloKh1//pn/ArxdTM71Bv2vfHZJjCwAdFErs5rw=; b=0nF9RGKju6c8r8y1wTV/nMvZ14 SvfbozGZ6c/9eIwtDPAa1ngkCq42IDpZo0S5yazea+6daR+v6SCykaqdwtlchmk86e7opTnd9ZtVn XiJblheB2mBFqUWgXGa+TGCUztGHpyIzCQ8ZlIqhJOym8YHvhmEg7NItyiNIbZ0sqrfk=; Message-ID: <98d45f93-b611-1016-45b5-3d7487af261f@xen.org> Date: Mon, 27 Feb 2023 17:36:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleksii, On 27/02/2023 16:52, Oleksii wrote: > On Sat, 2023-02-25 at 17:53 +0000, Julien Grall wrote: >>> +/* >>> + * WARNING: load_addr() and linker_addr() are to be called only >>> when the MMU is >>> + * disabled and only when executed by the primary CPU.  They >>> cannot refer to >>> + * any global variable or functions. >> >> I find interesting you are saying when _setup_initial_pagetables() is >> called from setup_initial_pagetables(). Would you be able to explain >> how >> this is different? > I am not sure that I understand your question correctly but > _setup_initial_pagetables() was introduced to map some addresses with > write/read flag. Probably I have to rename it to something that is more > clear. So the comment suggests that you code cannot refer to global functions/variables when the MMU is off. So I have multiple questions: * Why only global? IOW, why static would be OK? * setup_initial_pagetables() has a call to _setup_initial_pagetables() (IOW referring to another function). Why is it fine? * You have code in the next patch referring to global variables (mainly _start and _end). How is this different? >> >>> + */ >>> + >>> +/* >>> + * Convert an addressed layed out at link time to the address >>> where it was loaded >> >> Typo: s/addressed/address/ ? > Yes, it should be address. and 'layed out' should be changed to 'laid > out'... >> >>> + * by the bootloader. >>> + */ >> >> Looking at the implementation, you seem to consider that any address >> not >> in the range [linker_addr_start, linker_addr_end[ will have a 1:1 >> mappings. >> >> I am not sure this is what you want. So I would consider to throw an >> error if such address is passed. > I thought that at this stage and if no relocation was done it is 1:1 > except the case when load_addr_start != linker_addr_start. The problem is what you try to map one to one may clash with the linked region for Xen. So it is not always possible to map the region 1:1. Therefore, I don't see any use for the else part here. > > >> >>> +#define >>> load_addr(linker_address) >>>     \ >>> + >>> ({ >>>         \ >>> +        unsigned long __linker_address = (unsigned >>> long)(linker_address);      \ >>> +        if ( linker_addr_start <= __linker_address >>> &&                          \ >>> +            __linker_address < linker_addr_end >>> )                               \ >>> + >>> { >>>     \ >>> +            __linker_address >>> =                                                 \ >>> +                __linker_address - linker_addr_start + >>> load_addr_start;        \ >>> + >>> } >>>     \ >>> + >>> __linker_address; >>>     \ >>> +    }) >>> + >>> +/* Convert boot-time Xen address from where it was loaded by the >>> boot loader to the address it was layed out >>> + * at link-time. >>> + */ >> >> Coding style: The first line is too long and multi-line comments look >> like: >> >> /* >>   * Foo >>   * Bar >>   */ >> >>> +#define >>> linker_addr(load_address) >>>     \ >> >> Same remark as for load_addr() above. >> >>> + >>> ({ >>>         \ >>> +        unsigned long __load_address = (unsigned >>> long)(load_address);          \ >>> +        if ( load_addr_start <= __load_address >>> &&                              \ >>> +            __load_address < load_addr_end >>> )                                   \ >>> + >>> { >>>     \ >>> +            __load_address >>> =                                                   \ >>> +                __load_address - load_addr_start + >>> linker_addr_start;          \ >>> + >>> } >>>     \ >>> + >>> __load_address; >>>     \ >>> +    }) >>> + >>> +static void __attribute__((section(".entry"))) >>> +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t >>> *zeroeth, >> Can this be named to setup_initial_mapping() so this is clearer and >> avoid the one '_' different with the function below. > Sure. It will be better. >> >>> +                         unsigned long map_start, >>> +                         unsigned long map_end, >>> +                         unsigned long pa_start, >>> +                         bool writable) >> >> What about the executable bit? > It's always executable... But as you mentioned above PTE_LEAF_DEFAULT > should be either RX or RW. > I think it makes sense to add flags instead of writable. >> >>> +{ >>> +    unsigned long page_addr; >>> +    unsigned long index2; >>> +    unsigned long index1; >>> +    unsigned long index0; >> >> index* could be defined in the loop below. > It could. But I am curious why it is better? >> >>> + >>> +    /* align start addresses */ >>> +    map_start &= ZEROETH_MAP_MASK; >>> +    pa_start &= ZEROETH_MAP_MASK; >> >> Hmmm... I would actually expect the address to be properly aligned >> and >> therefore not require an alignment here. >> >> Otherwise, this raise the question of what happen if you have region >> using the same page? > That map_start &= ZEROETH_MAP_MASK is needed to page number of address > w/o page offset. My point is why would the page offset be non-zero? >> >>> + >>> +    page_addr = map_start; >>> +    while ( page_addr < map_end ) >> >> Looking at the loop, it looks like you are assuming that the region >> will >> never cross a boundary of a page-table (either L0, L1, L2). I am not >> convinced you can make such assumption (see below). >> >> But if you really want to make such assumption then you should add >> some >> guard (either BUILD_BUG_ON(), ASSERT(), proper check) in your code to >> avoid any surprise in the future. > I am not sure that I fully understand what is the problem here. > The address is aligned on (1<<12) boundary and each itearation is > mapped (1<<12) page so all looks fine or I misunderstood you. Let's take an example, imagine the region you want to map is 4MB. AFAICT, you are only passing one L0 page-table. So your code will end up to overwrite the previous entries in the zeroeth page-table and then add another link in the L1 page-table. >> >>> +    { >>> +        index2 = pagetable_second_index(page_addr); >>> +        index1 = pagetable_first_index(page_addr); >>> +        index0 = pagetable_zeroeth_index(page_addr); >>> + >>> +        /* Setup level2 table */ >>> +        second[index2] = paddr_to_pte((unsigned long)first); >>> +        second[index2].pte |= PTE_TABLE; >>> + >>> +        /* Setup level1 table */ >>> +        first[index1] = paddr_to_pte((unsigned long)zeroeth); >>> +        first[index1].pte |= PTE_TABLE; >>> + >>> +        /* Setup level0 table */ >>> +        if ( !pte_is_valid(&zeroeth[index0]) ) >> >> Can you explain why you are checking !pte_is_valid() for the L0 entry >> but not the other? > My mistake it should be checked for each level. In which case, shouldn't you return an error if the entry is always valid? >> >>> +        { >>> +            /* Update level0 table */ >>> +            zeroeth[index0] = paddr_to_pte((page_addr - map_start) >>> + pa_start); >>> +            zeroeth[index0].pte |= PTE_LEAF_DEFAULT; >>> +            zeroeth[index0].pte &= ~((!writable) ? PTE_WRITABLE : >>> 0); >> >> Looking at the default value, it would mean that a non-writable >> mapping >> is automatically executable. This seems wrong for the section is not >> meant to be executable (like rodata). > Yes, you are right. I'll reowrk setup_initial_mapping() to pass flags > instead of write/read - only flag. >> >>> +        } >>> + >>> +        /* Point to next page */ >>> +        page_addr += ZEROETH_SIZE; >>> +    } >>> +} >>> + >>> +/* >>> + * setup_initial_pagetables: >>> + * >>> + * 1) Build the page tables for Xen that map the following: >>> + *   1.1)  The physical location of Xen (where the bootloader >>> loaded it) >>> + *   1.2)  The link-time location of Xen (where the linker >>> expected Xen's >>> + *         addresses to be) >>> + * 2) Load the page table into the SATP and enable the MMU >>> + */ >>> +void __attribute__((section(".entry"))) >> >> I couldn't find a section ".entry" in the linker. >> >>> +setup_initial_pagetables(unsigned long load_addr_start, >>> +                         unsigned long load_addr_end, >>> +                         unsigned long linker_addr_start, >>> +                         unsigned long linker_addr_end) >>> +{ >>> +    pte_t *second; >>> +    pte_t *first; >>> +    pte_t *zeroeth; >>> + >>> +    clear_pagetables(load_addr_start, load_addr_end, >>> +                     linker_addr_start, linker_addr_end); >>> + >>> +    /* Get the addresses where the page tables were loaded */ >>> +    second  = (pte_t *)load_addr(&xen_second_pagetable); >>> +    first   = (pte_t *)load_addr(&xen_first_pagetable); >>> +    zeroeth = (pte_t *)load_addr(&xen_zeroeth_pagetable); >> >> I would consider to embed the type cast in load_addr() so you are >> adding >> some type safety within your code. > Definitely it will be better but setup_initial_mapping() uses 'unsigned > long' for passing address that should be mapped. One possibility would be to introduce a new wrapper for the typesafety. Anyway, it is not essential for now. Let's at least get the logic correct first :). >> >>> + >>> +    /* >>> +     * Create a mapping from Xen's link-time addresses to where >>> they were actually loaded. >> >> This is line is way long than 80 characters. Please make sure to wrap >> it >> 80 characters. >> >>> +     */ >>> +    _setup_initial_pagetables(second, first, zeroeth, >>> +                              linker_addr(&_stext), >>> +                              linker_addr(&_etext), >>> +                              load_addr(&_stext), >>> +                              false); >>> +    _setup_initial_pagetables(second, first, zeroeth, >>> +                              linker_addr(&__init_begin), >>> +                              linker_addr(&__init_end), >>> +                              load_addr(&__init_begin), >>> +                              true); >>> +    _setup_initial_pagetables(second, first, zeroeth, >>> +                              linker_addr(&_srodata), >>> +                              linker_addr(&_erodata), >>> +                              load_addr(&_srodata), >>> +                              false); >>> +    _setup_initial_pagetables(second, first, zeroeth, >>> +                              linker_addr_start, >>> +                              linker_addr_end, >>> +                              load_addr_start, >>> +                              true); >> >> Where do you guarantee that Xen will always fit in an L0 table and >> the >> start address is aligned to the size of an L0 table? > I don't guarantee that it fit in an L0 table but the start address is > aligned to the size of the L0 table at the start. Then it should be fixed. >> >>> + >>> +    /* >>> +     * Create a mapping of the load time address range to... the >>> load time address range. >> >> Same about the line length here. >> >>> +     * This mapping is used at boot time only. >>> +     */ >>> +    _setup_initial_pagetables(second, first, zeroeth, >> >> This can only work if Xen is loaded at its linked address. So you >> need a >> separate set of L0, L1 tables for the identity mapping. >> >> That said, this would not be sufficient because: >>    1) Xen may not be loaded at a 2M boundary (you can control with >> U-boot, but not with EFI). So this may cross a boundary and therefore >> need multiple pages. >>    2) The load region may overlap the link address >> >> While I think it would be good to handle those cases from the start, >> I >> would understand why are not easy to solve. So I think the minimum is >> to >> throw some errors if you are in a case you can't support. > Do you mean to throw some error in load_addr()/linkder_addr()? In this case, I meant to check if load_addr != linker_addr, then throw an error. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 27 17:45:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 17:45:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502850.774862 (Exim 4.92) (envelope-from ) id 1pWhZF-0004lq-Ia; Mon, 27 Feb 2023 17:45:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502850.774862; Mon, 27 Feb 2023 17:45:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhZF-0004lj-Fm; Mon, 27 Feb 2023 17:45:41 +0000 Received: by outflank-mailman (input) for mailman id 502850; Mon, 27 Feb 2023 17:45:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhZE-0004ld-MY for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 17:45:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWhZD-0007Bw-Rp; Mon, 27 Feb 2023 17:45:39 +0000 Received: from 54-240-197-233.amazon.com ([54.240.197.233] helo=[192.168.16.186]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWhZD-0005tx-JL; Mon, 27 Feb 2023 17:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ccwLrDinQxsJbM8K67Ij8jF2IqygExBdiA3E33b/zyA=; b=yxOGkmVckt6juhLN9GCGKIEQYW TMIBsuWNDw6HyQMJjLNLTi6SYl+lJA9IN9IsHvvM59kmrDT5raqO936OH6wBImO+N6UIUkdmWxX9v jsyMtpykZwWjYPY1Qwyv/0NAO4aE+zm78tz+hI8X67J8UeW/DglC8lYGdxw5OjFIAMyQ=; Message-ID: Date: Mon, 27 Feb 2023 17:45:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bob Eshleman , Alistair Francis , Connor Davis References: <83444f8f90cf2adf431762d919ba958a25ff8ce4.1677250203.git.oleksii.kurochko@gmail.com> <52072f1b-0cf8-a218-eefc-a8c1b4cecf43@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 27/02/2023 17:17, Oleksii wrote: > On Sat, 2023-02-25 at 18:05 +0000, Julien Grall wrote: >> Hi, >> >> On 24/02/2023 15:06, Oleksii Kurochko wrote: >>> Calculate load and linker linker image addresses and >>> setup initial pagetables. >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>>   xen/arch/riscv/setup.c | 11 +++++++++++ >>>   1 file changed, 11 insertions(+) >>> >>> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c >>> index b7cd438a1d..f69bc278bb 100644 >>> --- a/xen/arch/riscv/setup.c >>> +++ b/xen/arch/riscv/setup.c >>> @@ -1,9 +1,11 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>> >>>   #include >>>   #include >>> +#include >>>   #include >>> >>>   /* Xen stack for bringing up the first CPU. */ >>> @@ -43,6 +45,11 @@ static void __init disable_fpu(void) >>> >>>   void __init noreturn start_xen(void) >>>   { >>> +    unsigned long load_start    = (unsigned long)start; >>> +    unsigned long load_end      = load_start + (unsigned >>> long)(_end - _start); >> >> I am a bit puzzled, on top of load_addr() and linker_addr(), you >> wrote >> it can't use global variable/function. But here... you are using >> them. >> So how is this different? > I don't use load_addr() and linker_addr() macros here. I understand that. But my comment was related to: /* * WARNING: load_addr() and linker_addr() are to be called only when the MMU is * disabled and only when executed by the primary CPU. They cannot refer to * any global variable or functions. */ _start and _end are global variables. So why can you use them here but not there? If you could use them in load_addr() then you could simplify a lot your logic. >> >>> +    unsigned long linker_start  = (unsigned long)_start; >>> +    unsigned long linker_end    = (unsigned long)_end; >> >> I am a bit confused with how you define the start/end for both the >> linker and load. In one you use _start and the other _end. >> >> Both are fixed at compile time, so I assume the values will be a >> linked >> address rather than the load address. So how is this meant to how? >> > _start, _end - it is label from linker script so I use them to define > linker_start and linker_end addresses. > > load_start is defined as an address of start() function from head.S and > load_end is the load_start + the size (_end - _start) I think you misunderstood my comment. I understand what the variables are for. But I don't understand the computation because Xen could be loaded at a different address than the runtime address. > >> Furthermore, I would expect linker_start and load_start to point to >> the >> same symbol (the only different is one store the virtual address >> whereas >> the other the physical address). But here you are technically using >> two >> different symbol. Can you explain why? > It is used to make identity mapping for the range [load_addr, load_end] > and [linker_addr, linker_end]. It was done so because in Bobby's > patches in the linker script XEN_VIRT_START is defined as > _AT(vaddr_t,0x00200000) but bootloader loads Xen at 0x80200000 and so > in this case loadr_addr != linker_addr. > But I have changed XEN_VIRT_START to 0x8020...00 so they are equal now. So this will be broken as soon as this code will be tested on an hardware where there is no RAM at 0x8020...00. I would strongly recommend for you to test your code with XEN_VIRT_START != load address. >> >>> + >>>       /* >>>        * The following things are passed by bootloader: >>>        *   a0 -> hart_id >>> @@ -65,6 +72,10 @@ void __init noreturn start_xen(void) >>> >>>       test_macros_from_bug_h(); >>> >>> +    setup_initial_pagetables(load_start, load_end, linker_start, >>> linker_end); >> >> Shouldn't this happen earlier in start_xen()? > It can. If to be honest I don't know if it should. I added at the end > only because it was the last thing I worked on... I think we should enable the MMU and switch to the runtime mapping as early as possible. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Feb 27 18:39:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 18:39:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502858.774871 (Exim 4.92) (envelope-from ) id 1pWiOk-0003YA-Ev; Mon, 27 Feb 2023 18:38:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502858.774871; Mon, 27 Feb 2023 18:38:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWiOk-0003Xp-C2; Mon, 27 Feb 2023 18:38:54 +0000 Received: by outflank-mailman (input) for mailman id 502858; Mon, 27 Feb 2023 18:38:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWiOj-0003Xj-6x for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 18:38:53 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9a8bee6-b6cd-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 19:38:50 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-ZBZqiBNHN0mYplCPChLFgg-1; Mon, 27 Feb 2023 13:38:45 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF4533823A02; Mon, 27 Feb 2023 18:38:44 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 464B5C15BAD; Mon, 27 Feb 2023 18:38:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9a8bee6-b6cd-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677523128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=SWMomstYXFyZNSPGsc1edKoA4SVgbmaaZjlg916u2cs=; b=XrN6BQFh5BuTy8DO4dCwSWuYL7/mCWC6gmEw7tpA9rLX5TqE2MrZSji/USw7iq/RTpA+yG hexdHKjQ0VC+PbhewM3H8Etf7vpeBRpYi15dabvRKRgXsj+YfOhbm57TMIVlLOhWEImhJc qx6sAvQXLX1+KFUy/lqFo0Tz30pucvE= X-MC-Unique: ZBZqiBNHN0mYplCPChLFgg-1 Date: Mon, 27 Feb 2023 18:38:39 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230227111050.54083-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230227111050.54083-1-thuth@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 On Mon, Feb 27, 2023 at 12:10:48PM +0100, Thomas Huth wrote: > We're struggling quite badly with our CI minutes on the shared > gitlab runners, so we urgently need to think of ways to cut down > our supported build and target environments. qemu-system-i386 and > qemu-system-arm are not really required anymore, since nobody uses > KVM on the corresponding systems for production anymore, and the > -x86_64 and -arch64 variants are a proper superset of those binaries. > So it's time to deprecate them and the corresponding 32-bit host > environments now. > > This is a follow-up patch series from the previous discussion here: > > https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.com/ > > where people still mentioned that there is still interest in certain > support for 32-bit host hardware. But as far as I could see, there is > no real need for 32-bit host support for system emulation on x86 and > arm anymore, so it should be fine if we drop these host environments > now (these are also the two architectures that contribute the most to > the long test times in our CI, so we would benefit a lot by dropping > those). Your description here is a little ambiguous about what's being proposed. When you say dropping 32-bit host support do you mean just for the system emulator binaries, or for QEMU entirely ? And when the deprecation period is passed, are you proposing to actively prevent 32-bit builds, or merely stopping CI testing and leave 32-bit builds still working if people want them ? With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Mon Feb 27 18:46:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 18:46:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502862.774882 (Exim 4.92) (envelope-from ) id 1pWiVu-0005MP-61; Mon, 27 Feb 2023 18:46:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502862.774882; Mon, 27 Feb 2023 18:46:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWiVu-0005MI-2o; Mon, 27 Feb 2023 18:46:18 +0000 Received: by outflank-mailman (input) for mailman id 502862; Mon, 27 Feb 2023 18:46:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWiVt-0005MB-2P for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 18:46:17 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 017b9e58-b6cf-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 19:46:14 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 06D3C320029B; Mon, 27 Feb 2023 13:46:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 27 Feb 2023 13:46:10 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Feb 2023 13:46:08 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 017b9e58-b6cf-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677523569; x= 1677609969; bh=I9yZfPovLr2nND0lDAG9JxWqeWCllW3loIVg9zVOhS0=; b=H HsM3E58QWWfvsUvnUVkiaOixBIoKc3RiVMZFpQdD81KRCeELt1teCpOqfR0SYZyO XG46uO6WIpYpmLzAUKUkjRfTlY8HP50Rv5+BEpX/dLvCjE3CO+9tcf7x/pkAOD29 flP8BEawETU+Ie/NgH687G2mKdjr/j8yIHTzlt4I/si80/wazqMt8rPQv8yuZyax EEtUwdx3Ok+R+1gLSMII+rtPUgW7VjBs9hmnPymEuv3FumCHxkFDTcBynFHmiLPc GnvUrlDwR2bTmcnJeazxxynpGguOby74n3RGLDfO/SiXhCHyKWLrhE22Yz8WO724 m0D7xoWA4Gk8VEmkwqVhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677523569; x=1677609969; bh=I9yZfPovLr2nND0lDAG9JxWqeWCl lW3loIVg9zVOhS0=; b=HqYIRR/G+/A5W7GaGPyj7mXA/e2ICftZHF9GnY6nmBI4 FmUoBJIGBAL9RpTSGswtSf7rkEFssFeLuWHsXs7fgU4mudTz+opzQSS8BjKhTWHe GROlQK+PTJEvEmPbueAvphRFvlEbKSg9lRsEeXe2PM+1Jg90i/0RwAT4kjmHakVg p7wSVGovA3dH6//l09X6QD7b6XyY/R1abk6pFnWJuQpEPzZvnqljKFrv5UDyjPjh e/P7YSGsshB9ArvDg6gDQEwWkDRhqxsZoZ9vGGpD3LfJ7so0/8zgpCKgRhOS0Jfq qo3h2lE/OaiKCxBGcQgui86ZY1eZVt7C5rWv6IHJvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeltddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejgeegvdeluedttedtffeiueeg ueeiuefhvedvteetvedtgfeuhfefjeegleelheenucffohhmrghinhepgigvnhdrohhrgh dpgigvnhhprhhojhgvtghtrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsg drtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 27 Feb 2023 13:46:05 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PJiz44JW7X/YJje1" Content-Disposition: inline In-Reply-To: --PJiz44JW7X/YJje1 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Feb 2023 13:46:05 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 2/5] Change remaining xenbits.xen.org links to HTTPS On Mon, Feb 27, 2023 at 09:35:51AM +0100, Jan Beulich wrote: > On 25.02.2023 21:37, Demi Marie Obenour wrote: > > --- a/Config.mk > > +++ b/Config.mk > > @@ -191,7 +191,7 @@ APPEND_CFLAGS +=3D $(foreach i, $(APPEND_INCLUDES),= -I$(i)) > > EMBEDDED_EXTRA_CFLAGS :=3D -fno-pie -fno-stack-protector -fno-stack-pr= otector-all > > EMBEDDED_EXTRA_CFLAGS +=3D -fno-exceptions -fno-asynchronous-unwind-ta= bles > > =20 > > -XEN_EXTFILES_URL ?=3D http://xenbits.xen.org/xen-extfiles > > +XEN_EXTFILES_URL ?=3D https://xenbits.xen.org/xen-extfiles > > # All the files at that location were downloaded from elsewhere on > > # the internet. The original download URL is preserved as a comment > > # near the place in the Xen Makefiles where the file is used. > > diff --git a/tools/misc/mkrpm b/tools/misc/mkrpm > > index 68819b2d739cea5491b53f9b944ee2bd20d92c2b..548db4b5da2691547438df5= d7d58e5b4c3bd90d0 100644 > > --- a/tools/misc/mkrpm > > +++ b/tools/misc/mkrpm > > @@ -34,7 +34,7 @@ Version: $version > > Release: $release > > License: GPL > > Group: System/Hypervisor > > -URL: http://xenbits.xenproject.org/xen.git > > +URL: https://xenbits.xen.org/git-http/xen.git >=20 > Please can you not lose "project" from the URL? That's the more modern > form, after all. In fact, since you're touching the other URL above > anyway, I wonder if it wouldn't be a good idea to insert "project" > there as well. With at least the former adjustment (which I suppose > can be done while committing, as long as you agree) > Acked-by: Jan Beulich I=E2=80=99m fine with either or both of those adjustments. I was not aware= that https://xenbits.xen.org is an alias for https://xenbits.xenproject.org. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --PJiz44JW7X/YJje1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmP8+m8ACgkQsoi1X/+c IsGzAw//UYkI/gzsVxRKpK2U6g/sZZOKtRO6oZUCQsr/6+f04xnJzKw3/lAgtI0X YAzFbKq7UXCpflzwYB9Bwpbwd4MKFG3/wO8Pz1rLa1TiowNL/NPVBCiIv2AbS3Nf pmRA2WkVzIJ5bL6QR3MyMp6veaQJHjG0CYu883Xii137I/asWY1I/rVBNHsQn/Fr cLgZiOL6hxsmYr1qJaglyqSNHzRgA95AZg7pzHES146BAj6MuzUDCv0gmnmEsiUe +iCmrRQlBTv7qEz4ksw2T4q6TCg0rdFy1BAPrkd59ZfHkrn5A19hIX/unawij3yr U/0GxTNGe4khuiKn0PY+9IDJbM5o53YSu+3m7Es2FeMofRQxowChUoqB6RATHsLO rd9nzusn0jGQuHTNk44E0qguOvCTdzOWa921jO/zvWwBe0UPbFeAWcdgl1dDrVQG afsZ8Q4pct1Quilb96L6C7EVJNOGve4DntOQFtWvJ/MrKnGQbjdOw5q4QwEirnOd ZKif5td74usFjKOiZU8wHFSqgdv1G1CjRcGFV9aQH2L47UkCXsbtJeLEHg+et26X WecF744+CoYw6Hc32grQ6l4ITLYucH7ItryK82cKR3LF/u02PhMnHUF0iGNZDrV2 NEc+JZnzNn3SX9ODwWmtePxdVWkzMivj4jZW5IOeu/m6rXJnFaU= =PUzj -----END PGP SIGNATURE----- --PJiz44JW7X/YJje1-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 19:43:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 19:43:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502872.774891 (Exim 4.92) (envelope-from ) id 1pWjPI-0005Bg-BV; Mon, 27 Feb 2023 19:43:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502872.774891; Mon, 27 Feb 2023 19:43:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjPI-0005BZ-8p; Mon, 27 Feb 2023 19:43:32 +0000 Received: by outflank-mailman (input) for mailman id 502872; Mon, 27 Feb 2023 19:43:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjPH-0005BT-4F for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 19:43:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id febb149b-b6d6-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 20:43:26 +0100 (CET) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 14:43:17 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6000.namprd03.prod.outlook.com (2603:10b6:5:38b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 19:43:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 19:43:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: febb149b-b6d6-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677527006; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=47hrV022imjNL9At+nLTGFZCNqOEN0PDuu0mk4P+w08=; b=f0SBLCX0wzGEG7UFGhV5VbiP64jX7zp32WnJj1vlHezr31l7CQzU02c8 6uGMP8W6zgW+QdsE9yNqpXes8XkE+iwptyOJxryKgdLLVoqb2+7zz7Fw7 z+CTRSUba6asS6vWEhyNMC1ZLxt6RIR4khzSPyHIiD5t7XHDNfF+Wg9Zu E=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 101163551 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ghROsa0+8XkRN88SpfbD5e5wkn2cJEfYwER7XKvMYLTBsI5bpzVSy DQWUG+HO62ONDT8e493Ot7k8ktT68eEnYVhSgA+pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gZkOqgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfBTgez e0jAggxUBGsuseu/J+lS/NjmZF2RCXrFNt3VnBI6xj8VKxja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvi6Kk1IZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjAdtMT+Dlr5aGhnW8/XUVMzgnVmKnuNSBtXeVZPNvN 3Ubr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YW2Z3qeZq3W1Iyd9BW0fYS4JSyMV7t+lp5s85i8jVf5mGa+xy9fzSTf5x mnQqDBk3upNy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg= IronPort-HdrOrdr: A9a23:5GDFq6CbTIuLncPlHeiisseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U4ssHFJo7C90dq7MAjhHP9OkMEs1NiZLW3bUQeTQr2KqLGSugEIeBeOvdK1t5 0QFJSWYeeYZTQUsS+52njfLz9K+qjlzEncv5a6854bd3AJV0gP1WZEIzfeNnczaBhNBJI/Gp bZzs1bpwC4cXBSQtWnCmIDV+3jocSOsJ79exYJCzMu9QHL1FqTmfPHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+5g7A23TV55F2nsKk7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO OJjwYrPsx15X+UVHqyuwHR1w7p1ytrw2P+yHeD6EGT7vDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7ApiLg/NLFPisa2HZc4EBS0NL7vUYvErf2W4Uh77D3O3klVavoKRiKqLzP1t MeSP00qswmNm9yJEqpxFWHiObcI0jbWC32DnTq8/blrwR+jTR3yVAVy9cYmWpF/JUhS4Nc7+ CBKahwkqpSJ/VmGp6VKd1xNPdfMFa9NS7kISaXOxDqBasHM3XCp9r+56g0/vijfNgNwIEpkJ rMXVtEvSpqEnieQPGmzdlO6FTAUW+9VTPixoVX4IV4oKT1QP7uPTeYQF4jnsO8q7EUA9HdWf y0JJVKasWTW1fGCMJMxUnzSpNSIX4RXIkcvcs6QUuHpobRJojjpoXgAYTuzXrWYEUZs0/Ecw o+tWLIVbp9B2iQKwHFqQmUXW/xcUri+p81GLTG/oEoufgwCrE= X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="101163551" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5RycFx9unkv3Lqwb8ABzHNJE/Y+4f06BbPA0M7U+9Dkt7DrTxW48toki7/qRguO69k+zPL9Ez+CLAid67l2epplYqKIFj8ZEgF6Vp5DvHB7Ew8PMBhrfqcJx0vRXnQ7EF1hXHI7zMvDLf2snNHqEcRQ294GR6d/Wpet5zlZPn5CdXcaCPV3WvxFKO0kKHEq6VfAJwvfFsjDRjVkSbTMNbfvhczWw0ywXfC535gqcGDR8qZc0vXkPDaHY/E0lMW+gl33Ju9abW5uPMoNSVRRFX2Vyg6dRi5dJJtrPLvh40rnlTyrzwubC0dnqDK5tBIWmDoOK9n6PIH2IgF/SXnbqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47hrV022imjNL9At+nLTGFZCNqOEN0PDuu0mk4P+w08=; b=ZieN6+VSLI/Boa1uaEVNdCpvbfwPOycjMhS/H81k8ZdSh3XyPAQGXYIsQaNWcYB+N6kwfWZ1QAjoklXWKxIeNR2pj5YgfxSAmMTBSh+rmWqC4Z0UkFkbxcha6PlA5vFvakgtSH4R8O//H+zK6Pd08DJiqP0YV7+C60Z4KOtThn0MJwXMk3eG7lRGSwoODTMJwP8BLrkWXd2Tce7PHY8THpvZt7N+BVQewRo9w0iVEZ63r+nY5Uq1xyR6XX0zkYx3Ahkn81/i4/AD6Jy8orXXrdYQ9EC7LcS+PYu512yQzSNLCX9RsDCfNNY862kxE080YTOdOPZFEFhGFVvJs9EwVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47hrV022imjNL9At+nLTGFZCNqOEN0PDuu0mk4P+w08=; b=GdxgunQFW8hCWeHou8zbI37+FpdrsVts9q2Fw+o6BNJQb9merJFDf9l6y4p4G5GI33hBZg49fsRo+1bXZ6qPNnzuj+yHZeS/yOyjZxhlJCVz4l9CTsZSV4Pqav8w65uJa9L94YO04h8+/K1bOj0s2DFdLJPcljxUpyD/w+Uygck= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3ca0416c-0d16-1345-0d42-6c66759e477a@citrix.com> Date: Mon, 27 Feb 2023 19:43:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [PATCH v2] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com> In-Reply-To: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0205.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6000:EE_ X-MS-Office365-Filtering-Correlation-Id: d8046875-9300-46fe-5f70-08db18fadc4c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O9GOUOAI3lIy4yyDv4tKcr4UsdWo2MhtdEmhR8qH46ZiziyFCnSeqPpgDHk82irQ870oVdz5WpcpHXz8yvXFo2wjAcPUvBkfYl6uDTs35ZjSZsrAcbTmVdV7bz+aeb2bTjBnVi5Y5mnQyP3nGkb2/56KfPRuyfeJpr6WV+w2w1htUhb3m2LSjG40i/f0Z5pRE30ZevMomEc+Lh1+ZfuQhVIUmey2EteoWiv8DjlRtaQvY4tYSBM6pTYrOfweowVWQR4t+gl/aM7fVY6IYxaKmgMgDhAcz9g5RWp/PuAfKsSe2RQNAIeLTZPvLRTZ9xBAebWOnYkMCk8qxq6PjmgE+jdQF0LebgneeacgRs598HG6lRQGHD/P8xMBLBEhoNhIkXZ1dd/6Yc95SDMnBuNQVPVAYTxT1C8ohMyb1EOB/o7gvT1/sQE43s4vZz5H7Dyn9WkbqpZioz5MMDrzgSt65UyRI5zo4lXpPE05V30fc4s8pmaI6I7jmRH0jGmmboJqTzazKvC656BzXBZOLZo74GBKbNCVFFFi9pI93dKoEqgEONQJ9zSk8YEFhZYCbkAZZvc9FiWpQBzGoDwkdq60MgbPnC3vpjFjXBNiV4kdMNqvQTKCHRnGgtAMhMuoXmisKdxqE9YHF2MkrJK/ysyQbzWawKlNrEp8paq1+V1L3z/Or2aQquzI4rWVBwSsdbESKFL8NwkFctmGSucRVxgp1WsLi9bNWvp4tsAPywDtHZU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(346002)(396003)(376002)(39860400002)(451199018)(31686004)(83380400001)(316002)(54906003)(110136005)(36756003)(82960400001)(4326008)(38100700002)(8676002)(6506007)(53546011)(186003)(2616005)(6512007)(26005)(6666004)(6486002)(5660300002)(86362001)(31696002)(66556008)(66946007)(478600001)(66476007)(8936002)(2906002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTg5N3kyT09zOU8yckRDOCtlWFFOa0F6T0g1b1ZnTGdVSFZBSnB2QU1vRnRy?= =?utf-8?B?OUlScjBTbFNaQzIxeVNBaEEvY2F4ZXJMWXEyeHptbDVuaXcvQ21DL3pCQzRY?= =?utf-8?B?ZE5zenBTc0N2SG0wWnBNWXAxRVNKamIwY2Uya1MyQmFaZllSYVZGbFV6K2ZP?= =?utf-8?B?amIyNDRNTjQzNzNweGtBUW9Yb3BLalpJUjVqWUI0SXFwdG0vMjZVZGl6NVhX?= =?utf-8?B?Y1QwT3dnREpUWm9MTzk2SmVOeFBWRDgwbTQ5VU9wakdLZGV0Sk9LakVwRkc4?= =?utf-8?B?alpFVWFzd3NTMGY5UkFtYWFWVldrTCsvWndGVXh5enlVdEVneERWa3kyVHJi?= =?utf-8?B?ekVTVmZXaGFNWlJOeG5ObERZTGtBWnJ3U1V4bHFyNmRUZ1F4UDE0bmlydzM5?= =?utf-8?B?MXpxTjR3eFZabTB1bjVTUlV6QStBYTlTOFBPYit3QWZ1eDNBYXpPQi9KL0J2?= =?utf-8?B?L0VqdGtCVHhVbTMrVUZlRG0rTDlKaU0yU3lBemppWkhDYUZFTTBmcWEySXNJ?= =?utf-8?B?VWJtZDJhbndEbFZ3aEtzN254ZDdURm90OUxrY1NUN1YxYktKWmFiTDlRR3Mr?= =?utf-8?B?b3RidUZHY1EzdlV0MTRmZVRuem9GNjJ0cVViQVdPQTA4MXJBWDlZczhsMlla?= =?utf-8?B?bVJlcE1vb05HbmtmZ25hdGhlb2dCM1pzQjVBQkpOenJBbkNTbnhLTVRmOHBT?= =?utf-8?B?VW55T0dWK3RMTzJEcTNlMWcvdU1nbm4wei94bXFrTkVpY2JPRlpWSVc5SXZL?= =?utf-8?B?U0NlTENRQ3JocVpuaFVZR1BnNktWZHZUTm51akpBYURFd2svd3hUNWFZZ0tz?= =?utf-8?B?Qm5jTjUxSW8zMjg5TEowQ0Z5K3ZLVExuVUFBRytReGgzeENIdmFFeHEycjk4?= =?utf-8?B?MnkwWEJaTU96Y0x1eGxJZWNIcXVGWGJQR1c3VmV4Tm9mOHQ3NWVEczdsL1gx?= =?utf-8?B?U0FnZWliSEVNdFoxbkNEcjdTUkI1eHpFdzJlQmZkZW14UnRtdkZoSDhTSVhn?= =?utf-8?B?dUhJcDRzZ0dKZ2lWMDFSc3lFRm1sQWNWaVBFVUVCb1M2TWNNQ0RjMTgzanRW?= =?utf-8?B?LzVHajRTeGVQQmN3eGk5RDVKWG85UHU5akVnb3V1QzB2ZEJIREZZMUcxcHY2?= =?utf-8?B?dUJxb3l0aTZIY1JUMGg0UVpRcnZFU1c2N1NLV0dzOWpyT2VyMWJCS1B1dGZr?= =?utf-8?B?UjZLV2tYWEg0aHl1R3RPSEw1c20xeG5ZNXVqMVZCNHA5K2krYm00T0Q2Rjk5?= =?utf-8?B?YmcwM3J0aEx1QjRVeXp4eG9HOU9uaThRK2NMdmpqTTJpV28xNDRFMWN2OEEv?= =?utf-8?B?Z3dmMU5TVmt5MWYxdnRhWDVqMWtiSStobTV2RjlvYjJMUkQwTFZpMlRjVlE0?= =?utf-8?B?M2I1bWhUN3grNjNIaW1KaW4zVm9NbTRlK3BHRnBud3g0c1l0eWh3dld4bTIr?= =?utf-8?B?ZTVrZE9QM0N6ZWI4OG1jaEdNeTFMOHdjbjNXcTVVRGRSOURPNjRLam91OWhj?= =?utf-8?B?T2h2R2d1L1NtWGMzUGs4dk56c0JJSWdFWWd4Vi83MTduWU1zbSsyVlZ0bGNz?= =?utf-8?B?TzB1YVpmWjBlQTFhclBVQWpPMlpVcm1COE5KWXBBc3hQR1FJUjJ2MGdZdDJa?= =?utf-8?B?eFVZc1B5K0F2VGhxblJVZEJvVFE2M3Q4UXhiMktpMVRETForZVN4QjVTeWJW?= =?utf-8?B?bkJRVDROUDUvbERGbkN0V2xkallGRnRBVWh2SUNHNUZJaVlEU2N0YVcxMnZQ?= =?utf-8?B?clQ1Um5kUk9nMDBJV1lGMFBlTlZpT1krVjNic056V2swdVBWYjlpT3h1V1pq?= =?utf-8?B?OFRxM0owQVN4ZnBkR2hJbXRtaWw2Vk8rRXREdWhpenBlcTVoRUxveDZYaWZt?= =?utf-8?B?Y042aVBQdXdDN1BUblVmL0tNeW11TDBEM2lqZ0hGN1dpMkx2RlNvdG1JU2Zm?= =?utf-8?B?TlBDdzg3bVZTZEdHcmtyT1RpeFJzNHZ3SGFWanVObWRxUm1mTDl1a2s2TFE4?= =?utf-8?B?d0F0ekhnYStUbTZGWkswOTlvVmZmck5wL3VnZXk0dFg1ZjdtdzBDb3h5VSs5?= =?utf-8?B?QmNPeHo1TG1pRldESitRbyttR1ZoT3A2MitkdjJqQk04dnU1R29kbHpRTTNW?= =?utf-8?B?NmdaVHNvZjRpV3U4bzQ3cjFyVDlCL1hZd1M5cjh6Nkcwd1dNQmpXRDdJL1Jw?= =?utf-8?B?Ync9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Y+ekATqXQqlLBz/XcE4Zx4L1/Snk7n9sAV8GjM087AT/cSPdHI9nZ9IC1rvpnrg6JqzkboSV1VnGdNFr5MJPpKVb//9KkGjhEHRMWS/eNCtySEcVE+12Cvf/1tbhn6fN/Ydl49kAIbJtr2HTaXnd6oVs+lquvynd2ufGlpGL10Dqw5PYjFyN6e4MUq9nKJcqcf2SwUrw87iJCw0bLTZDnrwJquJxxDFWT0SYVw7iAcyY5fU9WEfWdOSBBqVera5TLpcBkXZDFHLimO08qxasr99trC5vgoJbAhcTMRvbc/Z3A4d6sfgGnFjl2xTZSVPZVyK3M+7HL6m2CkoGfrY50VT2m5LKYQJM3qH0ShqR3qsVIWO8aBmg1GZn8LTFlRAuwogtAwpo3Q3nG9eBWGMTrZenY5vKc/iQorMx44L4dwOml7bgSc5XfvYK19yyTKhD3lU4VnuSFdfPDLKheLYaRo5ilX0G2OIgVuMMV9g1NsaV9Fd+cyR2P78zGfhO2hy6GQxfQYcfOTJdmNe9xlJguLOGpO4OC3l11zShIEAEXk59Y2P5jfr5oCyyhrUXSi1CsZsqFcQ0m1Cvp77juWi42hVRXir9hDAW7olBkmNZu4yB+XIsXD2F5zcqWvJRncf2Yme+mkh48SUwX2GZkzdf9s83F0d//y1xTF9/NQ4x8NqVHsHLwG2pY6xKKeT4ToooEFFdRYL9rmGIIjOKXuiOP7WY0wpi8YDcjvwroAYOWY5F+7Au2x6Vom/+jC2J/C3O4aTQb/pqp/Ot6dhFCBArOGrD94X9ePjF3UMm1B9RjOakeup9kfBWNGiXjI3cBr1W X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8046875-9300-46fe-5f70-08db18fadc4c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 19:43:12.3846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TqDPax2+b2s0go3U0W1keLs+ndG1iNh6P5GNcCUlbnO1UCLY9YhtxYb+Vf02xr3otMlmO6gxQVXz5Qw3p6TeIeXVZ54RwX2HOuuYDi1Th5s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6000 On 09/09/2022 3:30 pm, Jan Beulich wrote: > Gcc12 takes issue with core_parking_remove()'s > >    for ( ; i < cur_idle_nums; ++i ) >        core_parking_cpunum[i] = core_parking_cpunum[i + 1]; > > complaining that the right hand side array access is past the bounds of > 1. Clearly the compiler can't know that cur_idle_nums can only ever be > zero in this case (as the sole CPU cannot be parked). > > Arrange for core_parking.c's contents to not be needed altogether, and > then disable its building when NR_CPUS == 1. > > Signed-off-by: Jan Beulich > --- > v2: Disable building of core_parking.c altogether. > > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -10,7 +10,7 @@ config X86 >     select ALTERNATIVE_CALL >     select ARCH_MAP_DOMAIN_PAGE >     select ARCH_SUPPORTS_INT128 > -    select CORE_PARKING > +    select CORE_PARKING if NR_CPUS > 1 The appropriate change is: diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6a7825f4ba3c..2a5c3304e2b0 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -10,7 +10,7 @@ config X86         select ALTERNATIVE_CALL         select ARCH_MAP_DOMAIN_PAGE         select ARCH_SUPPORTS_INT128 -       select CORE_PARKING +       imply CORE_PARKING         select HAS_ALTERNATIVE         select HAS_COMPAT         select HAS_CPUFREQ diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8eb..855c843113e3 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -10,6 +10,7 @@ config COMPAT    config CORE_PARKING         bool +       depends on NR_CPUS > 1    config GRANT_TABLE         bool "Grant table support" if EXPERT The core parking code really does malfunction with NR_CPUS == 1, so really does need a hard dependency. It turns out our version of Kbuild does understand the imply keyword, which is the right way to spell "I want this feature unless something else happens to rule it out". As noted in the kbuild docs, select should only be used for immutable properties (this arch has $X), whereas imply should be used for all "I want $Y".  Most places we use select ought to use imply instead. >     select HAS_ALTERNATIVE >     select HAS_COMPAT >     select HAS_CPUFREQ > --- a/xen/arch/x86/platform_hypercall.c > +++ b/xen/arch/x86/platform_hypercall.c > @@ -727,12 +727,17 @@ ret_t do_platform_op( >         case XEN_CORE_PARKING_SET: >             idle_nums = min_t(uint32_t, >                     op->u.core_parking.idle_nums, num_present_cpus() - > 1); > -            ret = continue_hypercall_on_cpu( > -                    0, core_parking_helper, (void *)(unsigned > long)idle_nums); > +            if ( CONFIG_NR_CPUS > 1 ) > +                ret = continue_hypercall_on_cpu( > +                        0, core_parking_helper, > +                        (void *)(unsigned long)idle_nums); > +            else if ( idle_nums ) > +                ret = -EINVAL; >             break; > >         case XEN_CORE_PARKING_GET: > -            op->u.core_parking.idle_nums = get_cur_idle_nums(); > +            op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 > +                                           ? get_cur_idle_nums() : 0; These don't look right. If the core parking feature isn't available, it should uniformly fail, not report success on the get side and fail on the set side. >             ret = __copy_field_to_guest(u_xenpf_op, op, u.core_parking) ? >                   -EFAULT : 0; >             break; > --- a/xen/arch/x86/sysctl.c > +++ b/xen/arch/x86/sysctl.c > @@ -157,7 +157,7 @@ long arch_do_sysctl( >         long (*fn)(void *); >         void *hcpu; > > -        switch ( op ) > +        switch ( op | -(CONFIG_NR_CPUS == 1) ) Extending what Julien has said... We use this pattern exactly twice, and I would probably ack a patch disallowing it in the coding style. Its a trick that is too clever for its own good.  To anyone who hasn't encountered it, its straight obfuscation, and even I, who knows how the trick works, still has to reverse engineer the expression every single time to figure out which way it ends up resolving. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 19:51:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 19:51:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502880.774902 (Exim 4.92) (envelope-from ) id 1pWjX6-00074b-9O; Mon, 27 Feb 2023 19:51:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502880.774902; Mon, 27 Feb 2023 19:51:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjX6-00074U-6L; Mon, 27 Feb 2023 19:51:36 +0000 Received: by outflank-mailman (input) for mailman id 502880; Mon, 27 Feb 2023 19:51:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjX4-000748-S4 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 19:51:34 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 220f6080-b6d8-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 20:51:33 +0100 (CET) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Feb 2023 14:51:28 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5818.namprd03.prod.outlook.com (2603:10b6:806:119::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Mon, 27 Feb 2023 19:51:23 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Mon, 27 Feb 2023 19:51:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 220f6080-b6d8-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677527493; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=M1to9aRY6q6+ihjbE1wXGsg7foa49JBm9ylY9Csrzio=; b=JYTjMA4YLoy8ryRbdTuz1Wk4r1bGUWWKoFpQsQUq/IIB0aHhIqWfjqPG Z1w3J9Gn0eNuD8LsymPSCf898IATo5PtlGI7kIFOrIiA7nxkgQp/0sS5e 5Niu1UJ5VUw2jyHn82gYA9UqCwDmVCWIzPcCere0FOmROhFh9PuV/7Ted g=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 98121982 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:b7dDjKIvzGGPccN1FE+R45QlxSXFcZb7ZxGr2PjKsXjdYENS32YFz WUcWz3UOfuLZWb3LtogaYW2901V7JeDx4IySQplqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPTwP9TlK6q4mhA5AZhPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5QHlBTr qwbGQsGYyuArdyK2YKjSbZF05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMlmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHOiAttDROfQGvhCmgysmmU/CCYsS1K7mNaclXSses9tE hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9UQAXMGsDaCksXQYDpd75r+kOYgnnS99iFOu5i4PzEDSpm jSS9nFh3fMUkNIB0Li98RbfmTWwq5PVTwkzoALKQmai6QA/b4mgD2C11WXmAT97BN7xZjG8U LIswqByMMhm4UmxqRGw IronPort-HdrOrdr: A9a23:5b1FRKrxXswKM1Il3enyTWoaV5uML9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssSkb6Ku90KnpewK4yXcH2/hqAV7CZnishILMFu9fBOTZskTd8kHFh41gPM RbAuJD4b/LfCBHZK/BiWHSebdB/DDuytHtuQ609QYIcegeUdAH0+4PMHf9LqQZfnglObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUSzpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZfcI5p4dYOxY/ouW3TRYzWTFcRcsnq5zXMISdSUmRgXeR /30lUd1opImjbslyqO0GbQMkHboUoTAjnZuBilaDLY0LLEbSN/BMxbiY1DdBzFr0ImodFnya pOm3mUrpxNEHr77VLADvXzJmVXf3CP0A0fuP9Wi2YaXZoVabdXo4Ba9ERJEI0YFCa/7Iw8Cu FhAMzV+f4TKDqhHjjkl3gqxMbpUmU4Hx+ATERHssuJ0yJOlHQ8y0cD3sQQknoJ6Zp4QZhZ4O bPNLhuidh1P4YrRLM4AP1ETdq8C2TLTx6JOGWOIU7/HKVCIH7Jo46f2sRB2Mi6PJgTiJcikp XIV11V8WQ7fk7oBMWUmIdG6RDAWiG8Wi7xwsZV69x4t9THNcvW2O24OSITeueb0oYi65fgKo mO0bptco/eEVc= X-IronPort-AV: E=Sophos;i="5.98,219,1673931600"; d="scan'208";a="98121982" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gVqHMaBWMGg108a4EjvAlO9ZV6i70yzh3REPoH/F4FVokB6uShxk2ZchX0vO8HSFlaYJffPe4Azazy56eZqo6CyGcVKblyjVc3MGi7wo9Ci8rvKg1PW3N1/FtNI0GioFFI6K5vpdxGnQEJ2Df0ZG8pVgqDsHs+0E90Ka9R4jxYEYWLsifZLQvGIHsBmD6WUavS3KEZltTtbl45D+VqdTU35p4QDUNk631LCMgjJDAA1SDF4Lj5b8DL+9gPJSLBEV19+lH1/Bxc00QvGyd/fblfqzwcpVRoxFww8dUGE+UkjRz5lmZ4TMJ/jMyHFzvWzHpVXbGMvJAP7WgyF9/e/xkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M1to9aRY6q6+ihjbE1wXGsg7foa49JBm9ylY9Csrzio=; b=J1TLNHFggS1Hqectb8yVixUNsItKlRYFOXBUf0gFtSSQJZQ9OZmX+q36XsSBkcRHg0ZzVwu8KPOIX3bTMXjpleAarixECfPuKJ0uck4J2PImqFGOMGTvLGu6pSgPfMGDzCLCbhivhTGyxvlyFaYcBHUQGABXbr9Bh5ULMFdb0eHzbklfWalk4rWrZw3PESuQDGpP+TkIvpwx2UMglzRrNrNLRxTN17YbfUiQIakWdWz/QVZk5v5kiFPOFiDXW6mO4I3IWQVfhhJfOrufbVbPlg8cR57gFU39CAqJqsjHdLMl15f49EIW9phCBPThixkd/4rEyNL4CWalGMitwlxI8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M1to9aRY6q6+ihjbE1wXGsg7foa49JBm9ylY9Csrzio=; b=EEnY7ZfFsE9ZPlZfO5Q83CyCO/iepvE1Ghn6YxQlLDdgricSQz6cPj7HTe+eyBu4Ldv46S0HbVxR9JP5WApZ0GCQeqht3Yp3E0N0av5Ok5tHrQ1rWC1Sm00tc0nlDs2cupBqdz1HDKXVdRaMBOkfSCq/gPDLzJhLIcaP/RbC6ao= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5feae090-89b2-2c99-06d3-5735088ca41d@citrix.com> Date: Mon, 27 Feb 2023 19:51:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-GB From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com> <3ca0416c-0d16-1345-0d42-6c66759e477a@citrix.com> In-Reply-To: <3ca0416c-0d16-1345-0d42-6c66759e477a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5818:EE_ X-MS-Office365-Filtering-Correlation-Id: 03c3e73f-9d95-4dd4-a5f8-08db18fc00e3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nXuPGf/SK0pmG7l7nC9a1ZrZ1HReS2noQQXQ8MxSBwxH7r2cxLVLJxtEoAOu16rDlPJ8pO7BQ2MFTJwVz8mXk9nivBSuoEnZ3eS1NhaPhnKr2JzM/1NWge2yvoWdq3YSnmPMpulZZRJwEHjc/dhUBpMdCL742dQ+56guUXTUsgjAOJezura5aYWhH5MS198j4tnxztYIeSShc8HV3qTUmzKgmlAruHTrch1Mt9Xo3MPcec4Y3b65do77ININsRGI7ScY982qVoY9ekynY9rtykawOh05ci3giG2LtiMTWO50/GsHbXNLOFDD/d94HnnUULyjCE6oOmpzjeNI0g3oHsjaGu18P5FHWL3HAvBWwtTf34xqbcIAIttBgkKdTKdCAaTonkJm8QPxQ7oFX+iQUWUTJA0l87raV/fS2Gon/a8B1pc6QiqKGeOHPAHwYkybb0yzM9q8729XFVS2kcHvdaPU405I5zg7UfbJQv1m6mDFHbrdxY/NjsybwmnLre25S0xFVdF4/ZKLdzRdQbAxFTIXNS3kKCpFc6xdOyrZe8vFtg5gtQTVS8PN/zWKO4jPGrm6XDyTnZVNkON2ry/L5W/z5izHL98DEZfHpvHYEh4xDNMFAcr2vnnYBWB5NzwQaw8ZSNsif/okgERSice4tn6djOs/lOKFNTQrv1yu+qmVbooDBDpOIii/UwCzPEVOGw3kcxxiuXyR4eXwtDc9xBgPz7s3XHxQX8uh6sgFsx0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(451199018)(186003)(2906002)(38100700002)(82960400001)(83380400001)(8936002)(66476007)(41300700001)(8676002)(66556008)(4326008)(5660300002)(66946007)(53546011)(6512007)(478600001)(6506007)(6666004)(26005)(2616005)(316002)(36756003)(110136005)(54906003)(31696002)(86362001)(31686004)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWdwUWk2RlAraUljOW9xMi9WOXRjU21NUS8xRGlLMjltNldzUUlZWFlyUGVn?= =?utf-8?B?T1Nzdm9oeUhoNnl0bkZnWWdmL2o4cm5ibTJyNFlYY2REQXQ1ZlEvSHZpNzJl?= =?utf-8?B?ekw1NVdJUWhEMVhDeUFrU2ZTdG1kMHE4dnNtdC84RTlKNnRtaTNpWFVmRmJB?= =?utf-8?B?WWl5bUtXMUNlaGlXRkZpODZuTEpyQWRST2xpMWdsYm5GVEJqd3dZaVYvMm9P?= =?utf-8?B?WnRoOUNtcTMxUlkwUldyNGZFdE1UQ3RjNHFCMWF6Uy80dFAvc3p2cGRPQWFD?= =?utf-8?B?dGZnVFIzOCtwTDd3enpGUWhKV3JiT1pleTR6bEFWOHdpS0FTWG9Eam4xa1Mz?= =?utf-8?B?ZjEvYS9mb05WaHRLbml5OUhPSlYxQkpiVEVCejhIbzNnWXhFVDQxUjFvOHUr?= =?utf-8?B?MHhmSDR5cDJsWWpVYUUyVDVIbVZ5SGpOOUQzSFUrdGgyeDdRT3lzZFVNR0RL?= =?utf-8?B?NTlVcUFYTkM3VHMvY0ZtTGhPMjRGZy85MmNsd1FsWHZvU2Fvd2c2QlVjVm4y?= =?utf-8?B?dkx1TzgxUDF5MjdHUWowS0Q5SVlPMjhXeHcwR1BTT2lVMXJoOE81cW96Smwx?= =?utf-8?B?YU1uaGFYdHdHWldyVElXTEh2a3FPaHRLcTVoQ2RRZkFUb0JNUnhPMnVoaHUw?= =?utf-8?B?SzNCOHlwTEdsZkR6Z1F1cHlnajR6NGVINHNhalM2MDByK2VqQXA2TmJzeUMz?= =?utf-8?B?QUZkaWQzZVhwM3BSQlBKN2FZdkNRNVBKckRjU01pVXoybUNzUXlMUEROVGI3?= =?utf-8?B?RWExTjZMQ2c0a0h0SG9uNnJvQXNDck5kTU5SS3RVcVM2ZFZ1UlJvbUpjN3hs?= =?utf-8?B?OEx4Q2NFU3dka0ZoTWZMWU5JaDl4SFhpZ3p4enlwcmQ4ZFloU3M1YXFoNWFR?= =?utf-8?B?VkMrZnIwN2Y2VGxDR2dUYXNOTG5BUDY5RmFMdWlDd1h0a21oM3pyZzZjUTdZ?= =?utf-8?B?aUJuZUx0Ynl5cFRzRDhhSlRxNnBBVGVPSHR2NUF0VlJoTEJSb21UV1lkVDdD?= =?utf-8?B?NVVHak9jZWF1S214dXVDUSs2RzIwQW13UmlJVDRGNDBPL1NTOWRYYk5vSDdM?= =?utf-8?B?UEoyVzBZVHNHMnMwd3VyQTU1QmtkS2lOMU9RRVdKUWh1cCs3K0NXc0UrdzNk?= =?utf-8?B?YXJzZzFoMHRqK1dWdy8wSlhaWDJjN1BwdVdsdW5lakwxN0czL2s2VnpERGlR?= =?utf-8?B?ajE5UVViVnhXMEU5TDk1VG9vUHA0S3Qzb210cEVuQWU2YTJFVDlzcXNGVXpr?= =?utf-8?B?N0V2c1ZGRzlQR3hCL1FzRk9wNStuci90akVkSko3WmtOWTNOb01TbHpRVWFK?= =?utf-8?B?Nk9tSXFoWU13Y3VMVkFOZXlmRzJYUWVoRTNZREFVTjZwc293NzdFeU41UE5p?= =?utf-8?B?RnF2VzEwZDFsZy92QkViQTBQeWpmRzRpZFJtN1NTd1FwSWQzbTRERGZHWjFt?= =?utf-8?B?WDByN00rd082UFk2U3VGRUZiTE5EM29yYmVsaDg1YlhCTForcEY4UEpSKzdE?= =?utf-8?B?b2V4aitvQTVvWjVHVlNxcU5uZnFNbTlRS0hNZmFLcFBGbEhjMUtoMnZ2akIy?= =?utf-8?B?U0ltL1M1b2ticVF0eVd2T3dEbmxndDJySFNTd1B4ZG9tTDhmZDhKaGMwVjNz?= =?utf-8?B?ZVlIYTRnam10VCs0cnhmT3ZlcTVCSlRWR21RWmgwbXlYdUdGWjh3NXg4d09K?= =?utf-8?B?SEQyQTdLSXN3aXpheWdCbnczdmtmZUZPTjFvY0wxMk4vaFpHL0E0VktKRS9l?= =?utf-8?B?UHhyMEFxd3JNL1NyZTgxa09seE1TUzhLYU5qVG5xeWxoMDRCWGRtUGhtRkhx?= =?utf-8?B?bk12T1FxVTFTY3dEYnZCWDd5cE05V1pzUkMwdUo2Mk1WdTJXRU1BRG1qYXdk?= =?utf-8?B?bGYwQ1Eyam0vRFVoblNhMzhMdEZHbTB0MjAxb2xxTmFLbDNxd1dITDlYNDBK?= =?utf-8?B?bFZxR0VGdEpYVTkvcXJkb2VTcld4YURPWG40SDdwSFVsMThjd1RlMTVqalpn?= =?utf-8?B?ZFJ0cGNSTmd3S3BaYlJwVWcvNkpPNC9SODN4bFZOWWdxOWpUTDZDQUxYVzR6?= =?utf-8?B?bS9LcE5TWXFrNTMrSlZlWm5VenB2Z1pPcmx3ZldPT2NRSE9LOFNOdE1HZklw?= =?utf-8?B?cmx6UHRsUXU5TlFXaTBLMWxVeXNmU0hUa1FBY3g1c2RJdEdRUmFNd01QcU5X?= =?utf-8?B?akE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +9Ua3T1AL5huGe23qXgGog4T/5DFrGsOWE9kVD9vXVLxNbsuFwhkQ1ohp++cVC0kfAI8rxM8tKTGl8fSES+h1lvfZ+YMfVq+WbfZRSx78N4tWOXHJhS3w0PbDYTgjJLxEdb6RkrySBwFiMrIGPcH/8IdCRrQeES5PVyoyPe3Wya5wbrlVYlRhVsAER8QL5yOn0z8QocIzDwF+5KdKEu3Q66Jwb2efYSFJMPwOkQ+I8ezSxZ3Cl2/efH1BVq6fJpGLz2Ik74B6Zq647Bj0du2huA4sfjKUX/b3BEZDy2K2yYBc1bq6KUDjTemo/dND0V33g/jXfX1/UPzAKTIPg4n6AoBWpH64B///T+thBo4KpUrQbpyczkg5P/8m7jv8guYtZve4ukrQRHMBUZ794IrKImlftRm2qjz8sbsrdUnsrktlrlLkSkt9lICdrA0G/8KQV4WCbKgCzdZGCOIqNXuDknVlVaweRBThbLwUD69/Sw/JsFvf6ENpP9tUvN4jQLvXBPpQEVjI6lCfDBlDFQZIn+dHBh2RSBreq70XqkbwTpe91a+6xJtn9doz64saDivPEtG333DY8gmWj013OXK+RucVg/gDR9nuXBtf6Etq3mn+XhTsrAJ4f/LVSxkJGBLPHudqGLfwO9OdY4bIUVsqBhUSBNX760Ein7eAiTPbL1x1cPAz+fKxFlVW2dswNuHQLXcGj8EQ5KU1r4wXvyaNt1holrQJyKrSq7UZOh4lOpFjONkSQoQ8WbagzpN6jhmCKipux9/uhZX4CDPRgwtuSVdXFFQJr4fLydyiNER1TEededETdD0aXgnuT+WU2tx X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03c3e73f-9d95-4dd4-a5f8-08db18fc00e3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 19:51:23.1770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9/CLA/BoEbZdRfKVYKnxcSkKyVSiV83SCpdcz+qPPflspFLBpgBMJ6U0TI2V3DQf/LR3uqlQIA+9Rnp0brjrRFu/fuUqxX8jZ5FZM/pKMVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5818 On 27/02/2023 7:43 pm, Andrew Cooper wrote: > On 09/09/2022 3:30 pm, Jan Beulich wrote: >>     select HAS_ALTERNATIVE >>     select HAS_COMPAT >>     select HAS_CPUFREQ >> --- a/xen/arch/x86/platform_hypercall.c >> +++ b/xen/arch/x86/platform_hypercall.c >> @@ -727,12 +727,17 @@ ret_t do_platform_op( >>         case XEN_CORE_PARKING_SET: >>             idle_nums = min_t(uint32_t, >>                     op->u.core_parking.idle_nums, num_present_cpus() - >> 1); >> -            ret = continue_hypercall_on_cpu( >> -                    0, core_parking_helper, (void *)(unsigned >> long)idle_nums); >> +            if ( CONFIG_NR_CPUS > 1 ) >> +                ret = continue_hypercall_on_cpu( >> +                        0, core_parking_helper, >> +                        (void *)(unsigned long)idle_nums); >> +            else if ( idle_nums ) >> +                ret = -EINVAL; >>             break; >> >>         case XEN_CORE_PARKING_GET: >> -            op->u.core_parking.idle_nums = get_cur_idle_nums(); >> +            op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 >> +                                           ? get_cur_idle_nums() : 0; > These don't look right. > > If the core parking feature isn't available, it should uniformly fail, > not report success on the get side and fail on the set side. Huh, and in extra fun. It turns out we've had core parking unconditionally disabled in XenServer for ~9 years now. It looks at the idleness of dom0 and starts taking CPUs offline, even when the VMs are busy. I don't see how this functionality can ever have worked suitably...  I think there's a good argument to be made for having it user selectable, and frankly, off-by-default. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Feb 27 20:13:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 20:13:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502888.774912 (Exim 4.92) (envelope-from ) id 1pWjry-0001q6-39; Mon, 27 Feb 2023 20:13:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502888.774912; Mon, 27 Feb 2023 20:13:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjry-0001pz-00; Mon, 27 Feb 2023 20:13:10 +0000 Received: by outflank-mailman (input) for mailman id 502888; Mon, 27 Feb 2023 20:13:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjrw-0001pr-Dy for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 20:13:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 24f75107-b6db-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 21:13:06 +0100 (CET) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-202-u5E_gQLHOpukMUDnOQ9W9A-1; Mon, 27 Feb 2023 15:13:01 -0500 Received: by mail-ed1-f69.google.com with SMTP id cy28-20020a0564021c9c00b004acc6cf6322so10120182edb.18 for ; Mon, 27 Feb 2023 12:13:01 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id v29-20020a50a45d000000b004af70dcce7esm3516370edb.40.2023.02.27.12.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 12:12:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24f75107-b6db-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677528785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nXo6S0IXEpM+6py6VQyWASTHuOuAAX4yGyZNHQtCjPw=; b=Jh0e87RCm6MS8qiDKRUHNF63siOyfCgawt2e0yHlqTNmO2K78AyvRFS1e/1GyvlZVASv0/ m4+NRjlqGiPaYNZ0GGW1oJOab3TJVqFAe94TTs6PANbrAoVIBlMj/hBdd78aX7r3W38mMM jrYwH2aa0XALfcpGaXxB2b/uuApEcnc= X-MC-Unique: u5E_gQLHOpukMUDnOQ9W9A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nXo6S0IXEpM+6py6VQyWASTHuOuAAX4yGyZNHQtCjPw=; b=yvQXdmLJR3RlfIkA/g/Cu0Vhqg8MHIOnGmsKbEN0S/ROxHfa77Ll3lRrNtTX5i+e7q zpZ4kCyMl9sVxE88Svcpu8Op8i133oM8yh8QjLps2v2LkYynVw9gf9LWKX08VVQwFUkI CvxuOsqZbniKVlfKbZXyy+hEa0EyHTnQaHLQG2d58cOdotP6icOPIiIfbS4p8AsIrm8X 4I49vgkZ2xTQAzq/J+ujGtR0k001PXT/najIufYduXcdZ1kJifd28jsKKJrjs6OOdJ/G inAOzYY7KO5r8JPj3bhQH70GbNs+ThSAVikmdMAB6rp+EZZjHO1l/dNLtTrxsXoWjVFy XnUA== X-Gm-Message-State: AO0yUKUMTZd63TgT1lrEigFW6JIW1kXhXwraO5SKhEpcbwvaXjSJ+NTw Z8aiz5xLDED8pbEdtA4ORzakEWsQq1iA+wxrDpg1CtLKwdrgZuJaBTzzHtJNwhUN8sqCBmC3ZAs tDQviZYZYNkG4v+CYMCQcqH+5ucs= X-Received: by 2002:aa7:d5d9:0:b0:4aa:a1d4:bbd4 with SMTP id d25-20020aa7d5d9000000b004aaa1d4bbd4mr795781eds.42.1677528780646; Mon, 27 Feb 2023 12:13:00 -0800 (PST) X-Google-Smtp-Source: AK7set/s65ko7k8eMliaBLSgcdKtqsDe7q45PYpAz8p7fZUIE9CJak+If2OjVIOVHy1F3DAavKzVwg== X-Received: by 2002:aa7:d5d9:0:b0:4aa:a1d4:bbd4 with SMTP id d25-20020aa7d5d9000000b004aaa1d4bbd4mr795759eds.42.1677528780354; Mon, 27 Feb 2023 12:13:00 -0800 (PST) Date: Mon, 27 Feb 2023 15:12:55 -0500 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230227150858-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang wrote: > I feel like we should have separate deprecation entries for the > i686 host support, and for qemu-system-i386 emulator binary, as > although they're related they are independant features with > differing impact. eg removing qemu-system-i386 affects all > host architectures, not merely 32-bit x86 host, so I think we > can explain the impact more clearly if we separate them. Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is a superset. Removing support for building on 32 bit systems seems like a pity - it's one of a small number of ways to run 64 bit binaries on 32 bit systems, and the maintainance overhead is quite small. In fact, keeping this support around forces correct use of posix APIs such as e.g. PRIx64 which makes the code base more future-proof. -- MST From xen-devel-bounces@lists.xenproject.org Mon Feb 27 20:18:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 20:18:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502892.774921 (Exim 4.92) (envelope-from ) id 1pWjxB-0002S8-MO; Mon, 27 Feb 2023 20:18:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502892.774921; Mon, 27 Feb 2023 20:18:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjxB-0002S1-Jt; Mon, 27 Feb 2023 20:18:33 +0000 Received: by outflank-mailman (input) for mailman id 502892; Mon, 27 Feb 2023 20:18:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjxA-0002Rv-GH for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 20:18:32 +0000 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4adb6cb-b6db-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 21:18:30 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1D2A7320090E; Mon, 27 Feb 2023 15:18:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 27 Feb 2023 15:18:25 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Feb 2023 15:18:23 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4adb6cb-b6db-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677529104; x= 1677615504; bh=x7aGqY8gPLzJgS9VysO3Ue+/pXy28GvA8fCE+P0d5Ls=; b=L N67Btts4UqOGWjZgZtDuTLSR80hciA0+jRKERlmcFo5fZI6+S4y/sXjhT06OYd/p 0QqSuMyl49JOrpN0N07hd+5DsnZrZqGAdEEQ3/x5pfZ+MSLvhGuN/4IAHl8N4GUp wFe3aE5rc2abUXTOLxlevQ6h5O6AWh09quiTBUw/l80CF5SQhkJf9HO1pBDgH6oe VoZ1462JE3G7ombtRBmtRbsD0btv5rbKSwNFg7DbwIQydkYmncY5X49NBSgng9wE T+XgTIaLvQSnfRLyhDKUSZV4INO3fQnz4luir/756/wcrauLxAqbKhDMpUynlJ7f fD174FSQbDHBCOwmWmdug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677529104; x=1677615504; bh=x7aGqY8gPLzJgS9VysO3Ue+/pXy2 8GvA8fCE+P0d5Ls=; b=qB68H20lNLFB2fbOv2z5FySupgdcivXaykcIGDrcobah XiqXAR3ehoPukuxc4+dOnttje8mjssIg8vj/sMlzIr1O+IVqYeg7pAnEH9ZfLi4c WDQAS7Jc9ECJgVzQbxKMMfYeSO65CJD/z3tS7tsGT9vMj7iAabM7k8M+D8kjYiuz 2psGqID4g+OVlfLSI6zTb355CPuJpp8F9f4/gnGS7kynj9bnAAr7CcAUK+J2j+IJ m0Ln5xm91KGwmgM14vQsK1XMK+/rP7QF4DmMjeRSuPoK7aI2TYHzwQ7ELC5e3hrn bGBWHlZBuen21/k1ulR/H9s8vChIrZ2h/taYGok5ng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeltddgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeevtedugeffuddtteduheeuudet geeiteetudelvdehvdevueegheffleeludeuvdenucffohhmrghinhepiihlihgsrdhnvg htpdigvghnphhrohhjvggtthdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhlrg gsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 27 Feb 2023 15:18:17 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// Message-ID: References: <944d212b0047339e4c15f7f85d74ff7fbfe96912.1676750305.git.demi@invisiblethingslab.com> <8c4aa332-07ee-e91a-50f1-ced9e36db2a1@suse.com> <30b906ef-9c93-afec-14f5-4623cd24b273@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="58F2n6kLmm88isut" Content-Disposition: inline In-Reply-To: <30b906ef-9c93-afec-14f5-4623cd24b273@suse.com> --58F2n6kLmm88isut Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Feb 2023 15:18:17 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Samuel Thibault , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 2/3] Build system: Replace git:// and http:// with https:// On Mon, Feb 27, 2023 at 09:25:32AM +0100, Jan Beulich wrote: > On 24.02.2023 23:55, Demi Marie Obenour wrote: > > On Tue, Feb 21, 2023 at 11:07:58AM +0100, Jan Beulich wrote: > >> On 19.02.2023 03:46, Demi Marie Obenour wrote: > >>> --- a/stubdom/configure > >>> +++ b/stubdom/configure > >>> @@ -3535,7 +3535,7 @@ if test "x$ZLIB_URL" =3D "x"; then : > >>> if test "x$extfiles" =3D "xy"; then : > >>> ZLIB_URL=3D\$\(XEN_EXTFILES_URL\) > >>> else > >>> - ZLIB_URL=3D"http://www.zlib.net" > >>> + ZLIB_URL=3D"https://www.zlib.net" > >>> fi > >> > >> In v3 you said that this URL can't be used anymore for the version we'= re > >> trying to fetch (which I can confirm). Leaving aside the question of w= hy > >> stubdom was never updated in that regard, what use is it to update URL > >> (without even mentioning the aspect in the description) in such a case? > >> (I haven't gone through any of the other URLs again, so there may well > >> be more similar cases.) > >=20 > > Main advantage is that it will fail securely rather than downloading > > whatever random code an MITM attacker put in there. >=20 > As said before (and implied here): At the very least you need to mention > the aspect in the description. But then wouldn't things be failing equally > securely if no (non-working) URL was put in place, or one which is > guaranteed to yield an error but makes obvious that no real URL is meant? https://lists.xenproject.org/archives/html/xen-devel/2023-02/msg01439.html ("[PATCH v5 3/5] Build system: Do not try to use broken links") does exactly that. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --58F2n6kLmm88isut Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmP9EA4ACgkQsoi1X/+c IsFKaRAAwAVy+udQtgDHARiqxEpkHI+DXnmdfbdS89hpcC/A3e5WGdEJoV77n2dY ERynxouXwjTcKBYphScI0uUp6SIwEe9Y8/IeJGdEvE/riF6yiNX+0IGS4yzXV7O7 zWRlS22uU6pQI9XHyQPeJiPdRBADOJJ18MctqmXAmyMilNmjt4DutvGmm9AP72tO Mkn1t2L/xbxCpMyMoub7V0nXTdZ/Y3hQHOspFcpqS3rZ2XmlX4wnWUjxWwKtx/47 9uPTxe1bjBtIfTDFSfq9a8ZqQc+TaPIiq6JZTO7gL3ngDJDJZJT/yEwLk4wz16c4 IrVvAlNPap4Y1OVw3AABDNPHfji9QbU18JqaDViutv2eAas2gF38VIztSatHlGcU Ffjjr1SdZL5vsBhbILzZwsFhBsVCLzXq3AIVKQDOoQYbzDpFk1f7dYJCgRu0y6Zi eNHSFhOJ8g8OyWIQlOrE8E40trawPgEpZ2MGA7nrgcCaWI8Qo0UVWjBb45AsPr2y IK/WCkEWHeqY/XUh3qs2Fo5FGsM+EScpZwIuKTAXJIiEBGBlM16xTDwCMRXO0bnR 5nU1Rxd5aa3FuLohjpKVWo7mQ0yJS3k4gYtPuPjudJe3we5F6RmkT9q3Tltm+4ZZ 1Re1BZCyQnwiqfDIiohQrSm1wrm/5UpTlA1lGvs7edR7F4Hd+7I= =EWb3 -----END PGP SIGNATURE----- --58F2n6kLmm88isut-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 20:21:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 20:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502903.774932 (Exim 4.92) (envelope-from ) id 1pWjzx-0004D8-7m; Mon, 27 Feb 2023 20:21:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502903.774932; Mon, 27 Feb 2023 20:21:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjzx-0004D1-4t; Mon, 27 Feb 2023 20:21:25 +0000 Received: by outflank-mailman (input) for mailman id 502903; Mon, 27 Feb 2023 20:21:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWjzw-0004Cv-6n for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 20:21:24 +0000 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [2607:f8b0:4864:20::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d1f84fe-b6dc-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 21:21:23 +0100 (CET) Received: by mail-pl1-x629.google.com with SMTP id h8so4756526plf.10 for ; Mon, 27 Feb 2023 12:21:22 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id ik14-20020a170902ab0e00b0019ab3308554sm5011860plb.85.2023.02.27.12.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 12:21:20 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d1f84fe-b6dc-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wskDLqCCVfxDrvu5Vcz06wMz/jzQoFbqV3jXEJeYoyI=; b=eq570Uk7nUf0H+E1ibMnyXd+duQPVSIXFSVpO8tz2fL005OZ44CTxh56oXPJ6AbnWr tcx8DpYLJ3za6vqFmAvo+mTVedTOqzojcNep+S6SRdN7XHn/ZTqV4dYVdMxuk3af/zCB ZzdM1h2KCMoR7P5PwOLwnxWpCCaFOPFUoJHKbbHSCRrMTH2XRDow4S8ousW6L3VujFm/ zTSoaAKkyRJC7Qe3cqgdcgfwJ7+R6tE6DXk/+St4jhIDHext8GlpJTMXfh+8H792pEBs 3eK7uwdqAlvh4GlFPSKnuuv0zO3PJHbVMbJnznxqcg9LPjgjdY0QlMG9NzMIK5a43Fq3 imLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wskDLqCCVfxDrvu5Vcz06wMz/jzQoFbqV3jXEJeYoyI=; b=tZ6uCYpsanmhD1ozXjPxTVkFhEtbIHlJNMBvcXVYrRkWI8uY0WBLP7vRdabwV7VvzS +GHtvV93r5R3RuJXWDy0jsFHI4bWOTRX6rqGH87sDW9cvpBDup7WHPYDLxLvJ7AIu+pf 40Xt+Lhu010hcrX5p5Ph3VKIr+Ti3oEnjVC6vfwmZfkVRjM4QJoOoXSjB876VTbtfWuB 5q0TG8uwNJ2d+reDVT7yOaqOaeS0D66iwGqBZBh0XPZ6r3vdK/hmcoYbXpnrhiLBldHd /CmJf4g0RCAl0IC+5vce9JG/gxWLUZQHKbKVyBXqe4tp14zZ1+garxKC7KGx7yT+YqLr jztg== X-Gm-Message-State: AO0yUKV0ttzi6FtjJI9h3RJyhHxg2YPcEDyjcDfL2afzls47QxP29oOx jdR1z8TyrUI5Zk3tD6Hy0I/u1w== X-Google-Smtp-Source: AK7set8ikfBIt7vwSk8VIe8f/SB+uBUUEM7nzc8hrLDES0Uq//JkcsqoknN07S6lfqP3UuhLjdVoFQ== X-Received: by 2002:a17:902:c401:b0:19d:297:f30b with SMTP id k1-20020a170902c40100b0019d0297f30bmr245159plk.19.1677529281526; Mon, 27 Feb 2023 12:21:21 -0800 (PST) Message-ID: Date: Mon, 27 Feb 2023 10:21:14 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Content-Language: en-US To: "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> From: Richard Henderson In-Reply-To: <20230227150858-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/27/23 10:12, Michael S. Tsirkin wrote: > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >> I feel like we should have separate deprecation entries for the >> i686 host support, and for qemu-system-i386 emulator binary, as >> although they're related they are independant features with >> differing impact. eg removing qemu-system-i386 affects all >> host architectures, not merely 32-bit x86 host, so I think we >> can explain the impact more clearly if we separate them. > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > a superset. > > Removing support for building on 32 bit systems seems like a pity - it's > one of a small number of ways to run 64 bit binaries on 32 bit systems, > and the maintainance overhead is quite small. It's not that small. It only works for single-threaded system mode. It silently does not honor atomicity for user-only mode, which is perhaps worse not working at all. r~ From xen-devel-bounces@lists.xenproject.org Mon Feb 27 20:26:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 20:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502909.774941 (Exim 4.92) (envelope-from ) id 1pWk4U-0004t3-Tb; Mon, 27 Feb 2023 20:26:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502909.774941; Mon, 27 Feb 2023 20:26:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWk4U-0004sw-Qy; Mon, 27 Feb 2023 20:26:06 +0000 Received: by outflank-mailman (input) for mailman id 502909; Mon, 27 Feb 2023 20:26:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWk4S-0004sq-RI for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 20:26:04 +0000 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [2607:f8b0:4864:20::643]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f239e204-b6dc-11ed-a82a-c9ca1d2f71af; Mon, 27 Feb 2023 21:26:00 +0100 (CET) Received: by mail-pl1-x643.google.com with SMTP id u5so4670770plq.7 for ; Mon, 27 Feb 2023 12:26:00 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id u13-20020a170902714d00b00198e7d97171sm4989806plm.128.2023.02.27.12.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 12:25:58 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f239e204-b6dc-11ed-a82a-c9ca1d2f71af DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BDeTj+J/22nMN720Gd3H2ETn00LmeBnchjc/wTnuog4=; b=EAObgI2qw74QHK+8hCkJz8AvIZZmBITIs/sYHA2Qlf0q57YpW/Dr7gUvwprNjgNAnn +tZotGe5/JI1mPTPCJRpK+sqr0VoxX5Fku22esRricaGbqDFSpqFRXKVIgNYAn9GkliW Oe9Dd22bF8X6W/0QHVVxzkPE/gHx6X2a8hxSBtmETuGQy4yQwP3yCW0Mo8hDvw6jVxbV Y2vIwM86mBNextdY4sttG0Wg+S3PF5SIwSirMluiN6LKsNGk1lNme2RkHCwC52QuLArf e9Xg5/aHPVqv6xyuWlZ0ByeYLl2EhBxOKbUv7CiCsssKfSyeLgGpXX5AfBheNrx1RH5D QWIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BDeTj+J/22nMN720Gd3H2ETn00LmeBnchjc/wTnuog4=; b=PennLqvE4rFun+K7tZ6pxQg+LuIFl1Hi2K6781tbRhr/TJ6QHdKeQPBE0rNjCz2g9X J7kA1TsMdz+PfIVa+pjoeET1pXEnDUqztR+25X5chfocE3Azcx3ladSlzkLLvrq9PVF6 TLLBeQI23vIW+5v6PIRL5okzOqJOeMrYxEFMEv4uBEWe3dVh0Mog5VHjhAYtvptOqEbo D+D8rinQ/o4fD2iDa3+k+Z5Z/vTaEqH3ksWBSnbOJvrMBnRNYJvWG5+R8mY3GNkyFqOG eq0XW/ssUE+fGTwqlQEXtk8GqBPRUAyBKHu6cLUXsftWF3oouuJp7VwOaBOT3jPWHjo/ xHug== X-Gm-Message-State: AO0yUKWr38HcWlZnOVcRYHmb0v/PnfbTAWic9GTwrjsjftMva84jKisA H7R5byYzbLCPl0JGtffJSY/9ISfVzvOZQmNNtJBB9g== X-Google-Smtp-Source: AK7set+Ks0aC8CRh4CLuUfbNCHNObCKFD90fNX9o+WEpCa8NNy9bsMTnaB8yMj6nDUaS4c+izcebqA== X-Received: by 2002:a17:902:820d:b0:19c:d505:cdba with SMTP id x13-20020a170902820d00b0019cd505cdbamr66339pln.62.1677529558562; Mon, 27 Feb 2023 12:25:58 -0800 (PST) Message-ID: Date: Mon, 27 Feb 2023 10:25:53 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/27/23 01:50, Daniel P. Berrangé wrote: > On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote: >> Hardly anybody still uses 32-bit x86 hosts today, so we should >> start deprecating them to finally have less test efforts. >> With regards to 32-bit KVM support in the x86 Linux kernel, >> the developers confirmed that they do not need a recent >> qemu-system-i386 binary here: >> >> https://lore.kernel.org/kvm/Y%2ffkTs5ajFy0hP1U@google.com/ >> >> Signed-off-by: Thomas Huth >> --- >> docs/about/deprecated.rst | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >> index 15084f7bea..98517f5187 100644 >> --- a/docs/about/deprecated.rst >> +++ b/docs/about/deprecated.rst >> @@ -196,6 +196,19 @@ CI coverage support may bitrot away before the deprecation process >> completes. The little endian variants of MIPS (both 32 and 64 bit) are >> still a supported host architecture. >> >> +32-bit x86 hosts and ``qemu-system-i386`` (since 8.0) >> +''''''''''''''''''''''''''''''''''''''''''''''''''''' >> + >> +Testing 32-bit x86 host OS support takes a lot of precious time during the >> +QEMU contiguous integration tests, and considering that most OS vendors >> +stopped shipping 32-bit variants of their x86 OS distributions and most >> +x86 hardware from the past >10 years is capable of 64-bit, keeping the >> +32-bit support alive is an inadequate burden for the QEMU project. Thus >> +QEMU will soon drop the support for 32-bit x86 host systems and the >> +``qemu-system-i386`` binary. Use ``qemu-system-x86_64`` (which is a proper >> +superset of ``qemu-system-i386``) on a 64-bit host machine instead. > > I feel like we should have separate deprecation entries for the > i686 host support, and for qemu-system-i386 emulator binary, as > although they're related they are independant features with > differing impact. Agreed. > 32-bit x86 hosts > '''''''''''''''' > > Support for 32-bit x86 host deployments is increasingly uncommon in > mainstream Linux distributions given the widespread availability of > 64-bit x86 hardware. The QEMU project no longer considers 32-bit > x86 support to be an effective use of its limited resources, and > thus intends to discontinue it. > > Current users of QEMU on 32-bit x86 hosts should either continue > using existing releases of QEMU, with the caveat that they will > no longer get security fixes, or migrate to a 64-bit platform > which remains capable of running 32-bit guests if needed. Ack. > > ``qemu-system-i386`` binary removal > ''''''''''''''''''''''''''''''''''' > > The ``qemu-system-x86_64`` binary can be used to run 32-bit guests > by selecting a 32-bit CPU model, including KVM support on x86_64 > hosts. Once support for the 32-bit x86 host platform is discontinued, > the ``qemu-system-i386`` binary will be redundant. Missing "kvm" in this last sentence? It is otherwise untrue for tcg. > Current users are > recommended to reconfigure their systems to use the ``qemu-system-x86_64`` > binary. Ack. > Same point for the next patch about 32-bit arm vs qemu-system-arm > binary. Ack. r~ From xen-devel-bounces@lists.xenproject.org Mon Feb 27 20:54:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 20:54:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502918.774952 (Exim 4.92) (envelope-from ) id 1pWkVG-0000om-2x; Mon, 27 Feb 2023 20:53:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502918.774952; Mon, 27 Feb 2023 20:53:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkVG-0000of-0G; Mon, 27 Feb 2023 20:53:46 +0000 Received: by outflank-mailman (input) for mailman id 502918; Mon, 27 Feb 2023 20:53:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkVF-0000oZ-CT for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 20:53:45 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d072bb6e-b6e0-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 21:53:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 12FD732002FB; Mon, 27 Feb 2023 15:53:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 27 Feb 2023 15:53:39 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Feb 2023 15:53:37 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d072bb6e-b6e0-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1677531218; x= 1677617618; bh=RVavUoNX4EDZuLj6Sm5XmnX0jbm/NN++mhcZCvWhnP4=; b=H 5ekDTUKhz1V8Bxbkt3JIDn7yFY8Sz3Oa5sNWFuia12SB5cVVSbFbR+J29Y0i4Qd4 IO5z6MkaqgUQwZEU/HXHBmqIJPglKdsnfpPQSyvAu+JboS4rt4POa0/e998o7VFK 6/C1VTDD+qwCW7diGpGYVnuXYip9Bovwd+l88LAWtxL4rrFb78cw06ogzDdki+Hq 5In/R4JeV/kP6ppA40wFOw9nFTW8yd4+3pXCF2toP9hQgb5gLF7Q69smDO+0kuYF LOo++tO48QqR0FwYZqstQAIf6BArJux+pjtVfVqyMDdi53i0nNrhNbGvhv8y7G3T iixzePzrguudJT/R8JkWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677531218; x=1677617618; bh=RVavUoNX4EDZuLj6Sm5XmnX0jbm/ NN++mhcZCvWhnP4=; b=MB8HyW+sjWTtHj0ONpqQ4+UHlKI7L8G4/U/1JaeOvOCr 4ecHIiQTr/hQcFiEn1BHoFBQRxy4dQNb5qxZwrqjZr/zNn2xu5aDZdZjpARFIMbO 17hAl5TEwFpxFiKbAoRcum0y07m047idTM407bL/lNxahqjboJkXkVdwLb4+O4pa AkwAKQR/4IiYAUFJhfeaqiFe5eb4oKNumiZj7zFWQlb3og4fxvfO3xMKYqJIoB/W KZ2S28w7380BNNoLW1rm2Cv5JeIOgO7mhhPehAzASjcqQDIUeFI7ACa/M/wBeZAe UaCvCZw/hfpfKRYIkwKmEbAgCHTA1q6+d6nkNR63DQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeltddgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekteegiefhteehffegvdeggeej udelleeltdffveevtdetfeejuefgieeuhfeuleenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 27 Feb 2023 15:53:32 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Samuel Thibault , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 4/5] Build system: Replace git:// and http:// with https:// Message-ID: References: <85a65c8c5cbd7cab3b9eb57aed27a59443c7a6ff.1677356813.git.demi@invisiblethingslab.com> <5a66c333-51e8-6e82-9bfb-10d52164e96e@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xOCM4c90/6pTg/XH" Content-Disposition: inline In-Reply-To: <5a66c333-51e8-6e82-9bfb-10d52164e96e@suse.com> --xOCM4c90/6pTg/XH Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Feb 2023 15:53:32 -0500 From: Demi Marie Obenour To: Jan Beulich Cc: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , Samuel Thibault , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org Subject: Re: [PATCH v5 4/5] Build system: Replace git:// and http:// with https:// On Mon, Feb 27, 2023 at 09:42:24AM +0100, Jan Beulich wrote: > On 25.02.2023 21:37, Demi Marie Obenour wrote: > > --- a/stubdom/configure > > +++ b/stubdom/configure > > @@ -3545,7 +3545,7 @@ if test "x$LIBPCI_URL" =3D "x"; then : > > if test "x$extfiles" =3D "xy"; then : > > LIBPCI_URL=3D\$\(XEN_EXTFILES_URL\) > > else > > - LIBPCI_URL=3D"http://www.kernel.org/pub/software/utils/pciutils" > > + LIBPCI_URL=3D"https://mirrors.edge.kernel.org/pub/software/utils/pci= utils" > > fi >=20 > Simply replacing https:// in the original URL does work. Why did you alter > it beyond that? Yes, either access leads to the URL you specify, but that > forwarding (or however it's implemented) may change down the road (and it > could, aiui, even be dependent upon where in the world the access is comi= ng > from). In any event, here and below, any adjustment beyond what the title > says wants explaining in the description. >=20 > Jan $ curl --head --fail https://www.kernel.org/pub/software/utils/pciutils= /pciutils-2.2.9.tar.bz2 HTTP/1.1 301 Moved Permanently Server: nginx Date: Mon, 27 Feb 2023 20:46:38 GMT Content-Type: text/html Content-Length: 162 Connection: keep-alive Location: https://mirrors.edge.kernel.org/pub/software/utils/pciutils/p= ciutils-2.2.9.tar.bz2 X-Frame-Options: DENY X-Content-Type-Options: nosniff Strict-Transport-Security: max-age=3D15768001 Referrer-Policy: same-origin Content-Security-Policy: default-src 'self'; img-src https: data: This means that all future requests should be made to https://mirrors.edge.kernel.org/pub/software/utils/pciutils/pciutils-2.2.9.= tar.bz2 as per the HTTP standard. If this were a temporary redirect you would be correct, but it is not. See: > Some URLS returned 301 or 302 redirects, so I replaced them with the > URLs that were redirected to. =66rom the commit message. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --xOCM4c90/6pTg/XH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmP9GFAACgkQsoi1X/+c IsF9exAAhwb2DoNSJMQw+TI/tTwtLGbq79bgkeM+j03cLhC9q11NPp+zgagICuM7 UNmh6rMdKdmIdBpvGr4FHvUYwmXZeX60JzNc2Xc98KgjQ4l+KClCKQ7/TP80ccz1 Z6iv9DKu3fatGCsGyiXU3G3T3wNku26GtMcvc+8jK62RcXORVjq12moyh1hFxx/J OYpCiZdaY8X3Qf+bOqXijBn81LjbLWt0+781gXNk76RaedTGmWs5gVNsxVrdIQak MQBB2JIjq3oPuHJzhihO868bgLsjzUhy+uSY/3mDsg3dm6bNIgWvQB3S0tfg+MaO ErVdEqNRThpxy61zEHSFAZK4doPQQ1yqyvksqRNg5kGnEoKW/c/54b82eddHwDJH f2h4iPgO5Fa9vhWVPKQoK8dhKq4bW8uzl/sfr4rpf0UtgTqcZoUyBmXb2IdWVFSt PVOE/6SVDg2xfI8roUQWLvHZPZ+G2a4w+J1QRBd+7yX/ugkDM+27yKSLe6mjM9FV zG5qKXDg73/iTbv9p2Jk6WeSFtL8tn7KHZZwyhXzrtTN5dpa9KkIFnSVYZG1riJH ry/FWe0k1oFCua0XQ7N0/or24TIsqNvJ6MmTBzy+WdTF7VXRW32+aYr+gdixVBXj 6VS4oQ9qCxC7knU48rTa3v79909vuGu/WpZ6z36gs+M19FSwnX8= =7ykJ -----END PGP SIGNATURE----- --xOCM4c90/6pTg/XH-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 21:02:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 21:02:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502925.774962 (Exim 4.92) (envelope-from ) id 1pWkdw-0002gW-Vu; Mon, 27 Feb 2023 21:02:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502925.774962; Mon, 27 Feb 2023 21:02:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkdw-0002gP-Sp; Mon, 27 Feb 2023 21:02:44 +0000 Received: by outflank-mailman (input) for mailman id 502925; Mon, 27 Feb 2023 21:02:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkdw-0002gF-7f; Mon, 27 Feb 2023 21:02:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkdw-0003UH-4b; Mon, 27 Feb 2023 21:02:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkdv-0003oX-Ue; Mon, 27 Feb 2023 21:02:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWkdv-00016o-UF; Mon, 27 Feb 2023 21:02:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rRNi4ep498uoNIstEY9ReJY/NB7RrysDw/yLrMbS5xw=; b=eo2vs+rErjd1rtozZA3FY0XURG 0J8PVC0rSIdNC+IEUen+ypSg8jf5OXNQV8fZTSaOjsk+vgkfLufqe9ZMxp6Bl71z6UF8zsmtd6bop 4x/fEQrkq3jZ0Gg34n2JRWPxz5Tmwb+VbOUfECBbHrvJHl9+3SUYoZnoyHdxonjnRYCU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178690: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=49b1cb27413034c81023d1faf7af43690e87291a X-Osstest-Versions-That: xen=4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c From: osstest service owner Date: Mon, 27 Feb 2023 21:02:43 +0000 flight 178690 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178690/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 49b1cb27413034c81023d1faf7af43690e87291a baseline version: xen 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c Last test of basis 178663 2023-02-27 13:03:21 Z 0 days Testing same since 178690 2023-02-27 19:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Edwin Török Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4d6df4ec75..49b1cb2741 49b1cb27413034c81023d1faf7af43690e87291a -> smoke From xen-devel-bounces@lists.xenproject.org Mon Feb 27 21:08:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 21:08:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502931.774971 (Exim 4.92) (envelope-from ) id 1pWkjF-0003KT-Jn; Mon, 27 Feb 2023 21:08:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502931.774971; Mon, 27 Feb 2023 21:08:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkjF-0003KM-H6; Mon, 27 Feb 2023 21:08:13 +0000 Received: by outflank-mailman (input) for mailman id 502931; Mon, 27 Feb 2023 21:08:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWkjE-0003KE-2x for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 21:08:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d70907f3-b6e2-11ed-88bb-e56d68cac8db; Mon, 27 Feb 2023 22:08:10 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4190DB80DA3; Mon, 27 Feb 2023 21:08:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E86EC433EF; Mon, 27 Feb 2023 21:08:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d70907f3-b6e2-11ed-88bb-e56d68cac8db DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677532089; bh=z7jgl+rkzbV8KLibn061z5BMzWghZWTEtb8c76rL5+c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tsLYIVpnB5VzwpJvD8j5HupGyxmO15mKOyj531PWV9ML98aEByIbz3BgmtPsYilPC Eh002xOxTb64AJA3R1fhhjoLe5eK2liStRJtWGGmBZtpssTMesJKMWYEPuevoTkTOb +enuKs09srrNzCJFpOMnvppRsB3W4DwgKWH0uxWuJiiqG1EVQPWvXGGl9SUV6BuLxP fOrohygvn62qiAoo7zGCMNVGeNE1TnyMIUtL9nMzl4Yk/554zBLFPWRsbQ4V8QQVfR zOQSMREgWw8Fk8o7DO4jLTRMSI+rPjYvmUjoERGiBApwYjGsLlfY6vlsh9tHCN5Det Xg6RdFI8Hs5Tw== Date: Mon, 27 Feb 2023 13:08:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Xen-devel , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis , Anthony PERARD , Stefano Stabellini , Michal Orzel , Doug Goldstein Subject: Re: [PATCH] CI: Simplify RISCV smoke testing In-Reply-To: <20230224153721.2623760-1-andrew.cooper3@citrix.com> Message-ID: References: <20230224153721.2623760-1-andrew.cooper3@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 24 Feb 2023, Andrew Cooper wrote: > Use a single fairly generic string as the "all done" message to look for, > which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature > is added. > > Signed-off-by: Andrew Cooper Acked-by: Stefano Stabellini > --- > CC: Oleksii Kurochko > CC: Bob Eshleman > CC: Alistair Francis > CC: Connor Davis > CC: Anthony PERARD > CC: Stefano Stabellini > CC: Michal Orzel > CC: Doug Goldstein > > I considered "All set up and nowhere to go" but it's probably a little niche. > --- > automation/scripts/qemu-smoke-riscv64.sh | 2 +- > xen/arch/riscv/setup.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh > index e0f06360bc43..4008191302f9 100755 > --- a/automation/scripts/qemu-smoke-riscv64.sh > +++ b/automation/scripts/qemu-smoke-riscv64.sh > @@ -16,5 +16,5 @@ qemu-system-riscv64 \ > |& tee smoke.serial > > set -e > -(grep -q "Hello from C env" smoke.serial) || exit 1 > +(grep -q "All set up" smoke.serial) || exit 1 > exit 0 > diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c > index d09ffe1454a4..1c87899e8e90 100644 > --- a/xen/arch/riscv/setup.c > +++ b/xen/arch/riscv/setup.c > @@ -11,6 +11,7 @@ void __init noreturn start_xen(void) > { > early_printk("Hello from C env\n"); > > + early_printk("All set up\n"); > for ( ;; ) > asm volatile ("wfi"); > > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Mon Feb 27 21:42:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 21:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502935.774982 (Exim 4.92) (envelope-from ) id 1pWlGB-0000UJ-8A; Mon, 27 Feb 2023 21:42:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502935.774982; Mon, 27 Feb 2023 21:42:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlGB-0000UC-5H; Mon, 27 Feb 2023 21:42:15 +0000 Received: by outflank-mailman (input) for mailman id 502935; Mon, 27 Feb 2023 21:42:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlGA-0000U6-1b for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 21:42:14 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97cc0427-b6e7-11ed-9684-2f268f93b82a; Mon, 27 Feb 2023 22:42:13 +0100 (CET) Received: by mail-lf1-x12a.google.com with SMTP id f41so10418352lfv.13 for ; Mon, 27 Feb 2023 13:42:11 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97cc0427-b6e7-11ed-9684-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ZF1KE9+P2rqU4dEjFWUCi5yBy445vBS0PStIV3/w0No=; b=R//sTUGol+MFuvT+rSqrAIt4DmcX7QqFKKREm7PQrvwIiI1iY+Wqa4bH7SJwDK/lA4 x86Osq0G6eb6/cYHpDo1Gvb8c4LcS1un4gmWFBc7sDZT+eMP+0+bnonWLfHkoa0GwmEl VwUCJJhUFNU3gkEc2/6FBWlnsRA7hW4h/HmFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZF1KE9+P2rqU4dEjFWUCi5yBy445vBS0PStIV3/w0No=; b=cPjCPvzaJHC13eaoumzXwibiExvbugLIKE32tVtpA39iuFBhapCZAFDHh5hwkW7JYr qdoCYN9Fkl720q2ROTeIvlhCh6ouYKjm6p0KK5DJOQC09we4O4Oi3AzRR0q7imZTczLr 05FVzUu4FFJaGwESnD6Z4uzLM8bWhOR5dPfDhNWjvr+9EMDUht5l2uC0f+A1cFcm/76s fG/U8Ull74j5xd7xq/x3AIV3n2Mos6Xs5nUVfGC09lXohqNu0uPNMwV4zFAiya35vFrt 4BErdTHaihiwSf30Rjz0HGEXWbdLtrgkBaaTMhVY/NlszqpLCaTjRaNGWU47+fpxm7Vk tcxw== X-Gm-Message-State: AO0yUKW6UmRdq+iMaLixkGmJd/6AIiVWojkdlVvuluDwD2/DVfBZ2w20 gFDRl+wj3YtJLG+03S2E91vAV0f/uryP++0TTQN4FF4wM2iyY7cA X-Google-Smtp-Source: AK7set9WtBYIPkxDDvsjd7UN0sBDMX7f6gOYY7RgTWrG+htcP9j4IHCJrt2WiJ1gK3kjrzv88N0aGrXoSldc3YMm3QQ= X-Received: by 2002:ac2:51ba:0:b0:4d5:ca32:68a3 with SMTP id f26-20020ac251ba000000b004d5ca3268a3mr11997lfk.8.1677534130921; Mon, 27 Feb 2023 13:42:10 -0800 (PST) MIME-Version: 1.0 From: George Dunlap Date: Mon, 27 Feb 2023 21:41:59 +0000 Message-ID: Subject: [ANNOUNCE] Call for agenda items for 3 March Community Call @ 1600 UTC To: Xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , Paul Durrant , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?UTF-8?Q?Piotr_Kr=C3=B3l?= , Brendan Kerrigan , insurgo@riseup.net, Oleksandr Andrushchenko , Oleksandr Tyshchenko , Scott Davis , Anthony PERARD , Michal Orzel , Marc Ungeschikts , Zhiming Shen , Xenia Ragiadakou , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLSGVucnkgV2FuZw==?= , Per Bilse , Samuel Verschelde , Andrei Semenov , Yann Dirson , =?UTF-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLTHVjYSBGYW5jZWxsdQ==?= , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= Content-Type: multipart/alternative; boundary="000000000000f8fb3705f5b559e4" --000000000000f8fb3705f5b559e4 Content-Type: text/plain; charset="UTF-8" Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/6pAe-+J05tY4OGg2sOobRrhO/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the previous meeting otherwise, the call is on the 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a provisional agenda * To allow time to switch between meetings, we'll plan on starting the agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the sign-up-sheet at https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Best Regards George == Dial-in Information == ## Meeting time 16:00 - 17:00 UTC Further International meeting times: https://www.timeanddate.com/worldclock/meetingdetails.html?year=2023&month=3&day=2&hour=16&min=0&sec=0&p1=1234&p2=37&p3=224&p4=179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=XenProjectCommunityCall --000000000000f8fb3705f5b559e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi all,

The proposed agenda is in https://cryptpa= d.fr/pad/#/2/pad/edit/6pAe-+J05tY4OGg2sOobRrhO/=C2=A0and you can edit t= o add items.=C2=A0 Alternatively, you can reply to this mail directly.
<= /p>

Agenda items appreciated a few days before the call: please put your = name besides items if you edit the document.

Note the following a= dministrative conventions for the call:
* Unless, agreed in the previous= meeting otherwise, the call is on the 1st Thursday of each month at 1600 B= ritish Time (either GMT or BST)
* I usually send out a meeting reminder = a few days before with a provisional agenda

* To allow time to sw= itch between meetings, we'll plan on starting the agenda at 16:05 sharp= .=C2=A0 Aim to join by 16:03 if possible to allocate time to sort out techn= ical difficulties &c

* If you want to be CC'ed please add or = remove yourself from the sign-up-sheet at=C2=A0https://cryptpad.fr/pad/#/2/= pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Best Regards
George
=


=3D=3D Dial-in Information =3D=3D
## Meeting time
1= 6:00 - 17:00 UTC
Further International meeting times:=C2=A0https= ://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2023&month= =3D3&day=3D2&hour=3D16&min=3D0&sec=3D0&p1=3D1234&p2= =3D37&p3=3D224&p4=3D179


## Dial in details
Web= :=C2=A0https://meet= .jit.si/XenProjectCommunityCall

Dial-in info and pin can be f= ound here:

https://meet.jit.si/static/dialInInfo.html?= room=3DXenProjectCommunityCall

--000000000000f8fb3705f5b559e4-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:05:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:05:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502942.774992 (Exim 4.92) (envelope-from ) id 1pWlch-0003js-7G; Mon, 27 Feb 2023 22:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502942.774992; Mon, 27 Feb 2023 22:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlch-0003jl-4S; Mon, 27 Feb 2023 22:05:31 +0000 Received: by outflank-mailman (input) for mailman id 502942; Mon, 27 Feb 2023 22:05:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlcg-0003jf-2I for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:05:30 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6bf0180-b6ea-11ed-a550-8520e6686977; Mon, 27 Feb 2023 23:05:26 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1B6FB80D58; Mon, 27 Feb 2023 22:05:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDF47C433EF; Mon, 27 Feb 2023 22:05:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6bf0180-b6ea-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677535524; bh=+rOG6DHHJyZvzF2YGmfRc1bru4uKI8IUS93JX+4DHX0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=t+7b4g4wtQkYmw2yoO5piyDt1UxgztLQCPpwfU4hpmYrcHs/2k1qWRxAyC7+x2WUo EwvaLUUtJhdJ85dCHA2DYjqkcNsnnoCsbbSgzKKKulgtEOxM9L9jFN+DfdfOkcwyHy JcHUDkhKhLZ9gNDJ7bT64ksTy44sEgNhFCAg3S/j7pVFr13c/PuhPYnnUVVriPFAMg jaGkdyMi2ajFd+nbXjxInkursVYot4+CsXFCG/FPXVKMhuF6qHy64+YqMxe4hzKM3d HC6lxdQcGc2MgATqK52ZYkya/WEHJshy9SlSsus1XOyTdWTQmF6vC2p9AXu5D9blCv jmQSzTFtPdfFg== Date: Mon, 27 Feb 2023 14:05:22 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Pavel Zhukov cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: Re: [ImageBuilder][PATCH] uboot-script-gen: Add virtio loader In-Reply-To: <20230221113035.5899-1-pavel@zhukoff.net> Message-ID: References: <20230221113035.5899-1-pavel@zhukoff.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 21 Feb 2023, Pavel Zhukov wrote: > uboot supports virtio-blk drives and can load kernel image from it. > Adding option to use '-t virtio' for loading image from virtio device > > Signed-off-by: Pavel Zhukov Reviewed-by: Stefano Stabellini > --- > README.md | 14 +++++++------- > scripts/uboot-script-gen | 3 +++ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/README.md b/README.md > index cb0cb13..64e62cd 100644 > --- a/README.md > +++ b/README.md > @@ -267,9 +267,9 @@ Where:\ > -d specifies the "root" directory (paths in the config file are relative > to it), this is not a working directory (any output file locations > are specified in the config and any temporary files are in /tmp)\ > --t specifies the u-boot command to load the binaries. "tftp", "sd", "usb" > - and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1" > - and "load scsi 0:1", but actually any arbitrary command can be used, > +-t specifies the u-boot command to load the binaries. "tftp", "sd", "usb", "virtio" > + and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1", > + "virtio load 0:1" and "load scsi 0:1", but actually any arbitrary command can be used, > for instance -t "fatload" is valid. The only special commands are: > fit, which generates a FIT image using a script, and fit_std, which > produces a standard style of fit image without a script, but has > @@ -339,10 +339,10 @@ Where:\ > -o specifies the output disk image file name\ > -a specifies whether the disk image size is to be aligned to the nearest > power of two\ > --t specifies the u-boot command to load the binaries. "tftp", "sd", "usb" > - and "scsi" are shorthands for "tftpb", "load mmc 0:1", "fatload usb 0:1" > - and "load scsi 0:1", but actually any arbitrary command can be used, > - for instance -t "fatload" is valid. > +-t specifies the u-boot command to load the binaries. "tftp", "sd", "usb", > + "virtio" and "scsi" are shorthands for "tftpb", "load mmc 0:1", > + "fatload usb 0:1", "load virtio 0:1" and "load scsi 0:1", but actually > + any arbitrary command can be used, for instance -t "fatload" is valid. > > > disk\_image supports these additional parameters on the config file: > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 7e5cc08..f07e334 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -1025,6 +1025,9 @@ while getopts ":c:t:d:ho:k:u:fp:" opt; do > sd ) > load_opt="load mmc 0:1" > ;; > + virtio ) > + load_opt="load virtio 0:1" > + ;; > usb ) > load_opt="fatload usb 0:1" > ;; > -- > 2.39.1 > From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:20:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:20:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502947.775002 (Exim 4.92) (envelope-from ) id 1pWlqg-0005xy-Fz; Mon, 27 Feb 2023 22:19:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502947.775002; Mon, 27 Feb 2023 22:19:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlqg-0005xr-Ch; Mon, 27 Feb 2023 22:19:58 +0000 Received: by outflank-mailman (input) for mailman id 502947; Mon, 27 Feb 2023 22:19:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlqf-0005xl-Tc for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:19:57 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dbfe2363-b6ec-11ed-a550-8520e6686977; Mon, 27 Feb 2023 23:19:55 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3528B60A16; Mon, 27 Feb 2023 22:19:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE56CC433D2; Mon, 27 Feb 2023 22:19:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbfe2363-b6ec-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677536392; bh=0xaBgoYEfb3JLn0g9cNw3Cj0C6Ya8NC9jJbSdXrxv6Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=l3+ZdqG5s3e6vJK8YHqMSTcwOG5hDx/VZIyy8CRGj6uGBDI+AIhkvdnaBc49qEVLd Zl4D015eSdPZ4SwgWbA3rsTymqRBcNhsNfCrywPQn/7GREH03JIfu/eBIVMDjHcoGo xejfiAJ/Cf1QpUq2tNb83uuxTDBp45tTnumYYslW2Dw4u98GB2m+BnJ1x9EuplIUEu EbByTNrZsMp6RqotrM4Kn96CdONxe/hM0zYJkDhEI8yrHzwo8ZgMJNKy0IrcEokUde u5aFSiHhLtWzCpCO3BBqOsuKz2QMkdFOIuYy8hmOyzqxaid9It9fd4AeKkcXY9pJys JksTZzTQxFcgg== Date: Mon, 27 Feb 2023 14:19:49 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Stefano Stabellini , Jan Beulich , Wei Chen , Bertrand Marquis , Andrew Cooper , George Dunlap , Michal Orzel , Wei Liu , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [PATCH 2/2] xen/misra: add entries to exclude-list.json In-Reply-To: <80D0D2C7-AA0A-490D-85E5-0CA3F5EECF34@arm.com> Message-ID: References: <20230214085635.3170962-1-luca.fancellu@arm.com> <20230214085635.3170962-3-luca.fancellu@arm.com> <14a4bccd-f316-fca9-a04d-5bd639307e9b@suse.com> <340CAA3C-DC15-4826-9022-0348BB3CE6C9@arm.com> <80D0D2C7-AA0A-490D-85E5-0CA3F5EECF34@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1934655835-1677536392=:3680" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1934655835-1677536392=:3680 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 24 Feb 2023, Luca Fancellu wrote: > Hi Stefano, > > >> Hi Jan, > >> > >> my personal opinion is that we can’t handle them for files that needs to be kept > >> in sync from an external source, because we can’t justify findings or tag false > >> positives, if we are lucky we might fix the non compliances but even in that case > >> there might be times when the fix goes through and cases where the fix is objected > >> by the maintainers just because their project is not following the MISRA standard. > >> > >> On our side, what we can do is track these files and from time to time check that > >> they are still eligible to backport, because when they are not anymore we could > >> just port them to Xen coding style and start doing direct changes. > >> > >> > >> @Stefano/@Bertrand/@Julien thanks for your effort on the list, yesterday morning > >> I’ve also had a look on the Michal’s file list and I’ve tracked down the origin, here > >> my findings, maybe we could merge your list with mine? > > > > Yes to merge the two lists, but I think we should keep only items that we > > actually need for the sake of having a cleaner baseline. So I would only > > add things we need today to reduce the noise on cppcheck results > > (excluding 20.7 and also excluding unusedStructMember which I think we > > should probably stop scanning with cppcheck altogether). > > Yes I thought about excluding unusedStructMember, I see there are a lot of findings on x86 > which are not real findings, it’s just that the tool has not the complete picture. > > Here the ways are two: > 1) exclude globally unusedStructMember > 2) exclude unusedStructMember only on some selected files (available only on cppcheck) > this requires some work to add a field to this list, like “cppcheck-error-exclude” and a list, > comma separated, of error-id to be suppressed from the corresponding file. For now, I would exclude globally > Regarding the list, I merged your list with mine (and Michal’s work) to create a complete list, > I think it’s better to have it complete because all those files are external and even if today we don’t > have findings for some of these files, we could have some in the future, and since we know today > that we can’t do direct changes to them, in my opinion it’s better to list them now instead of forgetting > them later. > > I left out for now these files to start a discussion for them, because I think they should be included in > the analysis: > > common/symbols-dummy.c: > this file accepts direct changes, cppcheck complains about misra-c2012-8.4 but I think it is right, also > Coverity complains about the same findings, they can be fixed adding declarations on symbols.h I think > and removing the declarations from symbol.c module > > common/version.c: > Apart from unusedStructMember, cppcheck is confused only on 2 findings that compares one local symbol > and one linker defined symbol, could we have just one tag to suppress those two findings instead of removing > completely the file? This file is under our control, so we could push changes. > > include/xen/lib.h: > Findings are from the bsearch function, which is derived from Linux, but I can see the codestyle is the Xen style > and it seems (I might be wrong) that it has diverged from Linux, so we might do changes and fix the findings that > are correct, void* arithmetic is working because gcc make it work assigning a sizeof of 1, using char* pointers we > have the same result without having the undefined behaviour (correct me if I am wrong). > > include/xen/sort.h: > Also this one is derived from Linux, but seems that we converted it to our coding style and we can do direct changes, > the same reasoning about void* pointers arithmetic applies here. > > > What are your thoughts? I am good with this > Here the merged list, capturing also Jan comments: > > { > "version": "1.0", > "content": [ > { > "rel_path": "arch/arm/arm64/cpufeature.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/arm/arm64/insn.c", > "comment": "Imported on Linux" > }, > { > "rel_path": "arch/arm/arm64/lib/find_next_bit.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/acpi/boot.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/acpi/cpu_idle.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/acpi/cpufreq/cpufreq.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/acpi/cpuidle_menu.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/acpi/lib.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/amd.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/centaur.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/common.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/hygon.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/intel.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/intel_cacheinfo.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/mcheck/non-fatal.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/mtrr/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/cpu/mwait-idle.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/delay.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/dmi_scan.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/mpparse.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/srat.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/time.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "arch/x86/x86_64/mmconf-fam10h.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/bitmap.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/bunzip2.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/earlycpio.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/inflate.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/libfdt/*", > "comment": "External library" > }, > { > "rel_path": "common/livepatch_elf.c", > "comment" : "Not in scope initially as it generates many violations and it is not enabled in safety configurations" > }, > { > "rel_path": "common/lzo.c", > "comment" : "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/lz4/decompress.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/radix-tree.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/ubsan/ubsan.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/un*.c", > "comment": "unlz4.c implementation by Yann Collet, the others un* are from Linux, ignore for now" > }, > { > "rel_path": "common/xz/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "common/zstd/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "crypto/*", > "comment": "Origin is external and documented in crypto/README.source" > }, > { > "rel_path": "drivers/acpi/apei/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/hwregs.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/numa.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/osl.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/tables.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/tables/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/acpi/utilities/*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "drivers/video/font_*", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "lib/list-sort.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "lib/rbtree.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "lib/xxhash*.c", > "comment": "Imported from Linux, ignore for now" > }, > { > "rel_path": "xsm/flask/*", > "comment" : "Not in scope initially as it generates many violations and it is not enabled in safety configurations" > } > ] > } > > > --8323329-1934655835-1677536392=:3680-- From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:27:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:27:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502951.775011 (Exim 4.92) (envelope-from ) id 1pWlxW-0007Qx-7s; Mon, 27 Feb 2023 22:27:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502951.775011; Mon, 27 Feb 2023 22:27:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlxW-0007Qq-4a; Mon, 27 Feb 2023 22:27:02 +0000 Received: by outflank-mailman (input) for mailman id 502951; Mon, 27 Feb 2023 22:27:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlxU-0007Qg-Vx; Mon, 27 Feb 2023 22:27:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlxU-0005OH-Tb; Mon, 27 Feb 2023 22:27:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWlxU-0006Km-JZ; Mon, 27 Feb 2023 22:27:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWlxU-0000U4-J9; Mon, 27 Feb 2023 22:27:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lHB/fy6c/iltdIMi4CTVesj48CxhpiM8V2dEXX9v3Rs=; b=0cMdpyoVHu1pnqYOqht3FHZPcZ ypJ25uxpVVMNecLuoGSlr3UXbwuZBYIYZU/l1dS04miv/GHVjRcIb9/HMeH+qJum+DF0sAjSj+t7g RC8wj5NSxzzo087wSRFPJmzuggeVeX6YUwkCgZPoS88S7BbkHI0rLU4a53Emrbv0xUwQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178669: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-xl:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-stop:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-stop:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit1:guest-stop:fail:heisenbug linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=f3a2439f20d918930cc4ae8f76fe1c1afd26958f X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Mon, 27 Feb 2023 22:27:00 +0000 flight 178669 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178669/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 178595 REGR. vs. 178042 test-arm64-arm64-xl 17 guest-stop fail in 178623 REGR. vs. 178042 test-arm64-arm64-xl-credit2 17 guest-stop fail in 178623 REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 17 guest-stop fail in 178623 REGR. vs. 178042 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit1 14 guest-start fail in 178595 pass in 178669 test-arm64-arm64-xl-credit1 17 guest-stop fail in 178623 pass in 178669 test-arm64-arm64-xl-thunderx 14 guest-start fail in 178623 pass in 178669 test-arm64-arm64-xl-xsm 14 guest-start fail pass in 178595 test-arm64-arm64-xl 14 guest-start fail pass in 178623 test-arm64-arm64-xl-credit2 14 guest-start fail pass in 178623 test-arm64-arm64-libvirt-xsm 14 guest-start fail pass in 178623 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-amd64-amd64-examine 4 memdisk-try-append fail blocked in 178042 test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 178595 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 178595 never pass test-arm64-arm64-xl 15 migrate-support-check fail in 178623 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 178623 never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 178623 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 178623 never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 178623 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 178623 never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux f3a2439f20d918930cc4ae8f76fe1c1afd26958f baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 6 days Failing since 178093 2023-02-22 05:02:47 Z 5 days 11 attempts Testing same since 178595 2023-02-26 20:42:37 Z 1 days 3 attempts ------------------------------------------------------------ 1866 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 214011 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:31:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:31:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502959.775022 (Exim 4.92) (envelope-from ) id 1pWm23-0000re-1j; Mon, 27 Feb 2023 22:31:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502959.775022; Mon, 27 Feb 2023 22:31:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm22-0000rX-Tb; Mon, 27 Feb 2023 22:31:42 +0000 Received: by outflank-mailman (input) for mailman id 502959; Mon, 27 Feb 2023 22:31:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm21-0000rM-BH for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:31:41 +0000 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ef011ee-b6ee-11ed-a550-8520e6686977; Mon, 27 Feb 2023 23:31:38 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:31:16 -0800 Received: from leonqu-mobl1.amr.corp.intel.com (HELO rpedgeco-desk.amr.corp.intel.com) ([10.209.72.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:31:15 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ef011ee-b6ee-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677537098; x=1709073098; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=h3g9dfsaSYOQw9Djcf7aO6npKOb7bN/WODuQBbF8SE0=; b=UohwRZyMt5jHpGvmzcjT/9r1WsmhmngxM5CQcdKhDLYw3lPvkOaqOAB4 Lobbb2sp00Ed4/N/L6MyT83TqOak49CFR4rTDI8aAYwMF0q5hTi/1SjBJ 1trB6wUlKlhljkiqS5sIeciTEY0fD7uSfPcVNasfTKTz+iOAFGp/N3bfS lvCWSmEKZ4AEscYsgzHgpSE0Jsp8uAxn7UTp+orzuhp5rUA4DuT3b0dKv W38SCcfnC29I8ibZ1Iu4w7up2mz8IYiLAAydzNje9pu/1Yo4e/NqDytZ9 SOW6QIriqgNP8pmGK5vUO3n5KqhJORqQMqRrVI7aQo06oQbBVwruzbSgM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="313657267" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="313657267" X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="848024459" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="848024459" From: Rick Edgecombe To: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v7 11/41] mm: Introduce pte_mkwrite_kernel() Date: Mon, 27 Feb 2023 14:29:27 -0800 Message-Id: <20230227222957.24501-12-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230227222957.24501-1-rick.p.edgecombe@intel.com> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The x86 Control-flow Enforcement Technology (CET) feature includes a new type of memory called shadow stack. This shadow stack memory has some unusual properties, which requires some core mm changes to function properly. One of these changes is to allow for pte_mkwrite() to create different types of writable memory (the existing conventionally writable type and also the new shadow stack type). Future patches will convert pte_mkwrite() to take a VMA in order to facilitate this, however there are places in the kernel where pte_mkwrite() is called outside of the context of a VMA. These are for kernel memory. So create a new variant called pte_mkwrite_kernel() and switch the kernel users over to it. Have pte_mkwrite() and pte_mkwrite_kernel() be the same for now. Future patches will introduce changes to make pte_mkwrite() take a VMA. Only do this for architectures that need it because they call pte_mkwrite() in arch code without an associated VMA. Since it will only currently be used in arch code, so do not include it in arch_pgtable_helpers.rst. Cc: linux-doc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: xen-devel@lists.xenproject.org Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Tested-by: Pengfei Xu Tested-by: John Allen Tested-by: Kees Cook Acked-by: Mike Rapoport (IBM) Acked-by: David Hildenbrand Reviewed-by: Kees Cook Suggested-by: David Hildenbrand Signed-off-by: Rick Edgecombe --- Hi Non-x86 Arch’s, x86 has a feature that allows for the creation of a special type of writable memory (shadow stack) that is only writable in limited specific ways. Previously, changes were proposed to core MM code to teach it to decide when to create normally writable memory or the special shadow stack writable memory, but David Hildenbrand suggested[0] to change pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be moved into x86 code. Since pXX_mkwrite() is defined in every arch, it requires some tree-wide changes. So that is why you are seeing some patches out of a big x86 series pop up in your arch mailing list. There is no functional change. After this refactor, the shadow stack series goes on to use the arch helpers to push shadow stack memory details inside arch/x86. Testing was just 0-day build testing. Hopefully that is enough context. Thanks! [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com/#t v6: - New patch --- arch/arm64/include/asm/pgtable.h | 7 ++++++- arch/arm64/mm/trans_pgd.c | 4 ++-- arch/s390/include/asm/pgtable.h | 7 ++++++- arch/s390/mm/pageattr.c | 2 +- arch/x86/include/asm/pgtable.h | 7 ++++++- arch/x86/xen/mmu_pv.c | 2 +- 6 files changed, 22 insertions(+), 7 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index b6ba466e2e8a..cccf8885792e 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -180,13 +180,18 @@ static inline pmd_t set_pmd_bit(pmd_t pmd, pgprot_t prot) return pmd; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { pte = set_pte_bit(pte, __pgprot(PTE_WRITE)); pte = clear_pte_bit(pte, __pgprot(PTE_RDONLY)); return pte; } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkclean(pte_t pte) { pte = clear_pte_bit(pte, __pgprot(PTE_DIRTY)); diff --git a/arch/arm64/mm/trans_pgd.c b/arch/arm64/mm/trans_pgd.c index 4ea2eefbc053..5c07e68d80ea 100644 --- a/arch/arm64/mm/trans_pgd.c +++ b/arch/arm64/mm/trans_pgd.c @@ -40,7 +40,7 @@ static void _copy_pte(pte_t *dst_ptep, pte_t *src_ptep, unsigned long addr) * read only (code, rodata). Clear the RDONLY bit from * the temporary mappings we use during restore. */ - set_pte(dst_ptep, pte_mkwrite(pte)); + set_pte(dst_ptep, pte_mkwrite_kernel(pte)); } else if (debug_pagealloc_enabled() && !pte_none(pte)) { /* * debug_pagealloc will removed the PTE_VALID bit if @@ -53,7 +53,7 @@ static void _copy_pte(pte_t *dst_ptep, pte_t *src_ptep, unsigned long addr) */ BUG_ON(!pfn_valid(pte_pfn(pte))); - set_pte(dst_ptep, pte_mkpresent(pte_mkwrite(pte))); + set_pte(dst_ptep, pte_mkpresent(pte_mkwrite_kernel(pte))); } } diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 2c70b4d1263d..d4943f2d3f00 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -1005,7 +1005,7 @@ static inline pte_t pte_wrprotect(pte_t pte) return set_pte_bit(pte, __pgprot(_PAGE_PROTECT)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { pte = set_pte_bit(pte, __pgprot(_PAGE_WRITE)); if (pte_val(pte) & _PAGE_DIRTY) @@ -1013,6 +1013,11 @@ static inline pte_t pte_mkwrite(pte_t pte) return pte; } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkclean(pte_t pte) { pte = clear_pte_bit(pte, __pgprot(_PAGE_DIRTY)); diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c index 85195c18b2e8..4ee5fe5caa23 100644 --- a/arch/s390/mm/pageattr.c +++ b/arch/s390/mm/pageattr.c @@ -96,7 +96,7 @@ static int walk_pte_level(pmd_t *pmdp, unsigned long addr, unsigned long end, if (flags & SET_MEMORY_RO) new = pte_wrprotect(new); else if (flags & SET_MEMORY_RW) - new = pte_mkwrite(pte_mkdirty(new)); + new = pte_mkwrite_kernel(pte_mkdirty(new)); if (flags & SET_MEMORY_NX) new = set_pte_bit(new, __pgprot(_PAGE_NOEXEC)); else if (flags & SET_MEMORY_X) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 56eea96502c6..3607f2572f9e 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -364,11 +364,16 @@ static inline pte_t pte_mkyoung(pte_t pte) return pte_set_flags(pte, _PAGE_ACCESSED); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite_kernel(pte_t pte) { return pte_set_flags(pte, _PAGE_RW); } +static inline pte_t pte_mkwrite(pte_t pte) +{ + return pte_mkwrite_kernel(pte); +} + static inline pte_t pte_mkhuge(pte_t pte) { return pte_set_flags(pte, _PAGE_PSE); diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index ee29fb558f2e..a23f04243c19 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -150,7 +150,7 @@ void make_lowmem_page_readwrite(void *vaddr) if (pte == NULL) return; /* vaddr missing */ - ptev = pte_mkwrite(*pte); + ptev = pte_mkwrite_kernel(*pte); if (HYPERVISOR_update_va_mapping(address, ptev, 0)) BUG(); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:31:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:31:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502960.775032 (Exim 4.92) (envelope-from ) id 1pWm27-00017X-81; Mon, 27 Feb 2023 22:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502960.775032; Mon, 27 Feb 2023 22:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm27-00017O-53; Mon, 27 Feb 2023 22:31:47 +0000 Received: by outflank-mailman (input) for mailman id 502960; Mon, 27 Feb 2023 22:31:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm24-0000rM-S7 for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:31:45 +0000 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 819b0e79-b6ee-11ed-a550-8520e6686977; Mon, 27 Feb 2023 23:31:41 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:31:22 -0800 Received: from leonqu-mobl1.amr.corp.intel.com (HELO rpedgeco-desk.amr.corp.intel.com) ([10.209.72.19]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:31:16 -0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 819b0e79-b6ee-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677537101; x=1709073101; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jtLiGLS5ozXsIx63+p41sv5RK32EOGBRgxF7nrBF+NQ=; b=Gd++Ss6FzJgVgLN+e7b1/Qj/XCssBYw8HMemTiMAFCDT2I0YJjp+vXfj s3DuuFNSVTpwLhkOWNYB+Y7YfxXN4B/SE0pdCLezc0JQLQ3T+lzThgBtU mkyCpB9DX90G2IhFoUFaNjYqmLhpj9ZRi8/rueexwktdAMpr6dgbAE9Lu PrYhte6wFSJjeai4GZl6L055aLyn62Amjzl2y3ZyYT6PTBuFgpwNgvqYo wxzY9fM3mUgsRwFi/wbkZYaJxv95pKLxzYOHUKkAwPzDnJMFDzWKyhDP7 aP9hiIs+a73LZ0xEvgu+kdcIC/f6A1j9OMWHD/lZ0J6P1KefdAOmxUr8D Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="313657337" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="313657337" X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="848024498" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="848024498" From: Rick Edgecombe To: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, debug@rivosinc.com Cc: rick.p.edgecombe@intel.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: [PATCH v7 13/41] mm: Make pte_mkwrite() take a VMA Date: Mon, 27 Feb 2023 14:29:29 -0800 Message-Id: <20230227222957.24501-14-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230227222957.24501-1-rick.p.edgecombe@intel.com> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The x86 Control-flow Enforcement Technology (CET) feature includes a new type of memory called shadow stack. This shadow stack memory has some unusual properties, which requires some core mm changes to function properly. One of these unusual properties is that shadow stack memory is writable, but only in limited ways. These limits are applied via a specific PTE bit combination. Nevertheless, the memory is writable, and core mm code will need to apply the writable permissions in the typical paths that call pte_mkwrite(). In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting that they are special shadow stack flavor of writable memory. So make pte_mkwrite() take a VMA, so that the x86 implementation of it can know to create regular writable memory or shadow stack memory. Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). No functional change. Cc: linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-alpha@vger.kernel.org Cc: linux-snps-arc@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-csky@vger.kernel.org Cc: linux-hexagon@vger.kernel.org Cc: linux-ia64@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-m68k@lists.linux-m68k.org Cc: Michal Simek Cc: Dinh Nguyen Cc: linux-mips@vger.kernel.org Cc: linux-openrisc@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: sparclinux@vger.kernel.org Cc: linux-um@lists.infradead.org Cc: xen-devel@lists.xenproject.org Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Tested-by: Pengfei Xu Tested-by: John Allen Tested-by: Kees Cook Acked-by: Mike Rapoport (IBM) Acked-by: Michael Ellerman Acked-by: David Hildenbrand Reviewed-by: Kees Cook Suggested-by: David Hildenbrand Signed-off-by: Rick Edgecombe --- Hi Non-x86 Arch’s, x86 has a feature that allows for the creation of a special type of writable memory (shadow stack) that is only writable in limited specific ways. Previously, changes were proposed to core MM code to teach it to decide when to create normally writable memory or the special shadow stack writable memory, but David Hildenbrand suggested[0] to change pXX_mkwrite() to take a VMA, so awareness of shadow stack memory can be moved into x86 code. Since pXX_mkwrite() is defined in every arch, it requires some tree-wide changes. So that is why you are seeing some patches out of a big x86 series pop up in your arch mailing list. There is no functional change. After this refactor, the shadow stack series goes on to use the arch helpers to push shadow stack memory details inside arch/x86. Testing was just 0-day build testing. Hopefully that is enough context. Thanks! [0] https://lore.kernel.org/lkml/0e29a2d0-08d8-bcd6-ff26-4bea0e4037b0@redhat.com/#t v6: - New patch --- Documentation/mm/arch_pgtable_helpers.rst | 9 ++++++--- arch/alpha/include/asm/pgtable.h | 6 +++++- arch/arc/include/asm/hugepage.h | 2 +- arch/arc/include/asm/pgtable-bits-arcv2.h | 7 ++++++- arch/arm/include/asm/pgtable-3level.h | 7 ++++++- arch/arm/include/asm/pgtable.h | 2 +- arch/arm64/include/asm/pgtable.h | 4 ++-- arch/csky/include/asm/pgtable.h | 2 +- arch/hexagon/include/asm/pgtable.h | 2 +- arch/ia64/include/asm/pgtable.h | 2 +- arch/loongarch/include/asm/pgtable.h | 4 ++-- arch/m68k/include/asm/mcf_pgtable.h | 2 +- arch/m68k/include/asm/motorola_pgtable.h | 6 +++++- arch/m68k/include/asm/sun3_pgtable.h | 6 +++++- arch/microblaze/include/asm/pgtable.h | 2 +- arch/mips/include/asm/pgtable.h | 6 +++--- arch/nios2/include/asm/pgtable.h | 2 +- arch/openrisc/include/asm/pgtable.h | 2 +- arch/parisc/include/asm/pgtable.h | 6 +++++- arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +- arch/powerpc/include/asm/book3s/64/pgtable.h | 4 ++-- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/32/pte-8xx.h | 2 +- arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- arch/riscv/include/asm/pgtable.h | 6 +++--- arch/s390/include/asm/hugetlb.h | 4 ++-- arch/s390/include/asm/pgtable.h | 4 ++-- arch/sh/include/asm/pgtable_32.h | 10 ++++++++-- arch/sparc/include/asm/pgtable_32.h | 2 +- arch/sparc/include/asm/pgtable_64.h | 6 +++--- arch/um/include/asm/pgtable.h | 2 +- arch/x86/include/asm/pgtable.h | 6 ++++-- arch/xtensa/include/asm/pgtable.h | 2 +- include/asm-generic/hugetlb.h | 4 ++-- include/linux/mm.h | 2 +- mm/debug_vm_pgtable.c | 16 ++++++++-------- mm/huge_memory.c | 6 +++--- mm/hugetlb.c | 4 ++-- mm/memory.c | 4 ++-- mm/migrate_device.c | 2 +- mm/mprotect.c | 2 +- mm/userfaultfd.c | 2 +- 42 files changed, 106 insertions(+), 69 deletions(-) diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst index 30d9a09f01f4..78ac3ff2fe1d 100644 --- a/Documentation/mm/arch_pgtable_helpers.rst +++ b/Documentation/mm/arch_pgtable_helpers.rst @@ -46,7 +46,8 @@ PTE Page Table Helpers +---------------------------+--------------------------------------------------+ | pte_mkclean | Creates a clean PTE | +---------------------------+--------------------------------------------------+ -| pte_mkwrite | Creates a writable PTE | +| pte_mkwrite | Creates a writable PTE of the type specified by | +| | the VMA. | +---------------------------+--------------------------------------------------+ | pte_wrprotect | Creates a write protected PTE | +---------------------------+--------------------------------------------------+ @@ -118,7 +119,8 @@ PMD Page Table Helpers +---------------------------+--------------------------------------------------+ | pmd_mkclean | Creates a clean PMD | +---------------------------+--------------------------------------------------+ -| pmd_mkwrite | Creates a writable PMD | +| pmd_mkwrite | Creates a writable PMD of the type specified by | +| | the VMA. | +---------------------------+--------------------------------------------------+ | pmd_wrprotect | Creates a write protected PMD | +---------------------------+--------------------------------------------------+ @@ -222,7 +224,8 @@ HugeTLB Page Table Helpers +---------------------------+--------------------------------------------------+ | huge_pte_mkdirty | Creates a dirty HugeTLB | +---------------------------+--------------------------------------------------+ -| huge_pte_mkwrite | Creates a writable HugeTLB | +| huge_pte_mkwrite | Creates a writable HugeTLB of the type specified | +| | by the VMA. | +---------------------------+--------------------------------------------------+ | huge_pte_wrprotect | Creates a write protected HugeTLB | +---------------------------+--------------------------------------------------+ diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h index ba43cb841d19..fb5d207c2a89 100644 --- a/arch/alpha/include/asm/pgtable.h +++ b/arch/alpha/include/asm/pgtable.h @@ -256,9 +256,13 @@ extern inline int pte_young(pte_t pte) { return pte_val(pte) & _PAGE_ACCESSED; extern inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) |= _PAGE_FOW; return pte; } extern inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~(__DIRTY_BITS); return pte; } extern inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~(__ACCESS_BITS); return pte; } -extern inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) &= ~_PAGE_FOW; return pte; } extern inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= __DIRTY_BITS; return pte; } extern inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= __ACCESS_BITS; return pte; } +extern inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) &= ~_PAGE_FOW; + return pte; +} /* * The smp_rmb() in the following functions are required to order the load of diff --git a/arch/arc/include/asm/hugepage.h b/arch/arc/include/asm/hugepage.h index 5001b796fb8d..223a96967188 100644 --- a/arch/arc/include/asm/hugepage.h +++ b/arch/arc/include/asm/hugepage.h @@ -21,7 +21,7 @@ static inline pmd_t pte_pmd(pte_t pte) } #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) diff --git a/arch/arc/include/asm/pgtable-bits-arcv2.h b/arch/arc/include/asm/pgtable-bits-arcv2.h index 6e9f8ca6d6a1..a5b8bc955015 100644 --- a/arch/arc/include/asm/pgtable-bits-arcv2.h +++ b/arch/arc/include/asm/pgtable-bits-arcv2.h @@ -87,7 +87,6 @@ PTE_BIT_FUNC(mknotpresent, &= ~(_PAGE_PRESENT)); PTE_BIT_FUNC(wrprotect, &= ~(_PAGE_WRITE)); -PTE_BIT_FUNC(mkwrite, |= (_PAGE_WRITE)); PTE_BIT_FUNC(mkclean, &= ~(_PAGE_DIRTY)); PTE_BIT_FUNC(mkdirty, |= (_PAGE_DIRTY)); PTE_BIT_FUNC(mkold, &= ~(_PAGE_ACCESSED)); @@ -95,6 +94,12 @@ PTE_BIT_FUNC(mkyoung, |= (_PAGE_ACCESSED)); PTE_BIT_FUNC(mkspecial, |= (_PAGE_SPECIAL)); PTE_BIT_FUNC(mkhuge, |= (_PAGE_HW_SZ)); +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= (_PAGE_WRITE); + return pte; +} + static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) { return __pte((pte_val(pte) & _PAGE_CHG_MASK) | pgprot_val(newprot)); diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h index 106049791500..df071a807610 100644 --- a/arch/arm/include/asm/pgtable-3level.h +++ b/arch/arm/include/asm/pgtable-3level.h @@ -202,11 +202,16 @@ static inline pmd_t pmd_##fn(pmd_t pmd) { pmd_val(pmd) op; return pmd; } PMD_BIT_FUNC(wrprotect, |= L_PMD_SECT_RDONLY); PMD_BIT_FUNC(mkold, &= ~PMD_SECT_AF); -PMD_BIT_FUNC(mkwrite, &= ~L_PMD_SECT_RDONLY); PMD_BIT_FUNC(mkdirty, |= L_PMD_SECT_DIRTY); PMD_BIT_FUNC(mkclean, &= ~L_PMD_SECT_DIRTY); PMD_BIT_FUNC(mkyoung, |= PMD_SECT_AF); +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) +{ + pmd_val(pmd) |= L_PMD_SECT_RDONLY; + return pmd; +} + #define pmd_mkhuge(pmd) (__pmd(pmd_val(pmd) & ~PMD_TABLE_BIT)) #define pmd_pfn(pmd) (((pmd_val(pmd) & PMD_MASK) & PHYS_MASK) >> PAGE_SHIFT) diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h index a58ccbb406ad..39ad1ae1308d 100644 --- a/arch/arm/include/asm/pgtable.h +++ b/arch/arm/include/asm/pgtable.h @@ -227,7 +227,7 @@ static inline pte_t pte_wrprotect(pte_t pte) return set_pte_bit(pte, __pgprot(L_PTE_RDONLY)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return clear_pte_bit(pte, __pgprot(L_PTE_RDONLY)); } diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index cccf8885792e..913bf370f74a 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -187,7 +187,7 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -492,7 +492,7 @@ static inline int pmd_trans_huge(pmd_t pmd) #define pmd_cont(pmd) pte_cont(pmd_pte(pmd)) #define pmd_wrprotect(pmd) pte_pmd(pte_wrprotect(pmd_pte(pmd))) #define pmd_mkold(pmd) pte_pmd(pte_mkold(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) diff --git a/arch/csky/include/asm/pgtable.h b/arch/csky/include/asm/pgtable.h index d4042495febc..c2f92c991e37 100644 --- a/arch/csky/include/asm/pgtable.h +++ b/arch/csky/include/asm/pgtable.h @@ -176,7 +176,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h index 59393613d086..14ab9c789c0e 100644 --- a/arch/hexagon/include/asm/pgtable.h +++ b/arch/hexagon/include/asm/pgtable.h @@ -300,7 +300,7 @@ static inline pte_t pte_wrprotect(pte_t pte) } /* pte_mkwrite - mark page as writable */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/ia64/include/asm/pgtable.h b/arch/ia64/include/asm/pgtable.h index 21c97e31a28a..f879dd626da6 100644 --- a/arch/ia64/include/asm/pgtable.h +++ b/arch/ia64/include/asm/pgtable.h @@ -268,7 +268,7 @@ ia64_phys_addr_valid (unsigned long addr) * access rights: */ #define pte_wrprotect(pte) (__pte(pte_val(pte) & ~_PAGE_AR_RW)) -#define pte_mkwrite(pte) (__pte(pte_val(pte) | _PAGE_AR_RW)) +#define pte_mkwrite(pte, vma) (__pte(pte_val(pte) | _PAGE_AR_RW)) #define pte_mkold(pte) (__pte(pte_val(pte) & ~_PAGE_A)) #define pte_mkyoung(pte) (__pte(pte_val(pte) | _PAGE_A)) #define pte_mkclean(pte) (__pte(pte_val(pte) & ~_PAGE_D)) diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/include/asm/pgtable.h index d28fb9dbec59..ebf645f40298 100644 --- a/arch/loongarch/include/asm/pgtable.h +++ b/arch/loongarch/include/asm/pgtable.h @@ -390,7 +390,7 @@ static inline pte_t pte_mkdirty(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) @@ -490,7 +490,7 @@ static inline int pmd_write(pmd_t pmd) return !!(pmd_val(pmd) & _PAGE_WRITE); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pmd_val(pmd) |= _PAGE_WRITE; if (pmd_val(pmd) & _PAGE_MODIFIED) diff --git a/arch/m68k/include/asm/mcf_pgtable.h b/arch/m68k/include/asm/mcf_pgtable.h index 13741c1245e1..37d77e055016 100644 --- a/arch/m68k/include/asm/mcf_pgtable.h +++ b/arch/m68k/include/asm/mcf_pgtable.h @@ -211,7 +211,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= CF_PAGE_WRITABLE; return pte; diff --git a/arch/m68k/include/asm/motorola_pgtable.h b/arch/m68k/include/asm/motorola_pgtable.h index ec0dc19ab834..c4e8eb76286d 100644 --- a/arch/m68k/include/asm/motorola_pgtable.h +++ b/arch/m68k/include/asm/motorola_pgtable.h @@ -155,7 +155,6 @@ static inline int pte_young(pte_t pte) { return pte_val(pte) & _PAGE_ACCESSED; static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) |= _PAGE_RONLY; return pte; } static inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~_PAGE_DIRTY; return pte; } static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~_PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) &= ~_PAGE_RONLY; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } static inline pte_t pte_mknocache(pte_t pte) @@ -168,6 +167,11 @@ static inline pte_t pte_mkcache(pte_t pte) pte_val(pte) = (pte_val(pte) & _CACHEMASK040) | m68k_supervisor_cachemode; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) &= ~_PAGE_RONLY; + return pte; +} #define swapper_pg_dir kernel_pg_dir extern pgd_t kernel_pg_dir[128]; diff --git a/arch/m68k/include/asm/sun3_pgtable.h b/arch/m68k/include/asm/sun3_pgtable.h index e582b0484a55..2a06bea51a1e 100644 --- a/arch/m68k/include/asm/sun3_pgtable.h +++ b/arch/m68k/include/asm/sun3_pgtable.h @@ -143,10 +143,14 @@ static inline int pte_young(pte_t pte) { return pte_val(pte) & SUN3_PAGE_ACCESS static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_WRITEABLE; return pte; } static inline pte_t pte_mkclean(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_MODIFIED; return pte; } static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~SUN3_PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) |= SUN3_PAGE_WRITEABLE; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= SUN3_PAGE_MODIFIED; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= SUN3_PAGE_ACCESSED; return pte; } static inline pte_t pte_mknocache(pte_t pte) { pte_val(pte) |= SUN3_PAGE_NOCACHE; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= SUN3_PAGE_WRITEABLE; + return pte; +} // use this version when caches work... //static inline pte_t pte_mkcache(pte_t pte) { pte_val(pte) &= SUN3_PAGE_NOCACHE; return pte; } // until then, use: diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h index d1b8272abcd9..5b83e82f8d7e 100644 --- a/arch/microblaze/include/asm/pgtable.h +++ b/arch/microblaze/include/asm/pgtable.h @@ -266,7 +266,7 @@ static inline pte_t pte_mkread(pte_t pte) \ { pte_val(pte) |= _PAGE_USER; return pte; } static inline pte_t pte_mkexec(pte_t pte) \ { pte_val(pte) |= _PAGE_USER | _PAGE_EXEC; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) \ +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) \ { pte_val(pte) |= _PAGE_RW; return pte; } static inline pte_t pte_mkdirty(pte_t pte) \ { pte_val(pte) |= _PAGE_DIRTY; return pte; } diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h index 791389bf3c12..06efd567144a 100644 --- a/arch/mips/include/asm/pgtable.h +++ b/arch/mips/include/asm/pgtable.h @@ -309,7 +309,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte.pte_low |= _PAGE_WRITE; if (pte.pte_low & _PAGE_MODIFIED) { @@ -364,7 +364,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; if (pte_val(pte) & _PAGE_MODIFIED) @@ -626,7 +626,7 @@ static inline pmd_t pmd_wrprotect(pmd_t pmd) return pmd; } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pmd_val(pmd) |= _PAGE_WRITE; if (pmd_val(pmd) & _PAGE_MODIFIED) diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h index 0f5c2564e9f5..edd458518e0e 100644 --- a/arch/nios2/include/asm/pgtable.h +++ b/arch/nios2/include/asm/pgtable.h @@ -129,7 +129,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/openrisc/include/asm/pgtable.h b/arch/openrisc/include/asm/pgtable.h index 3eb9b9555d0d..fd40aec189d1 100644 --- a/arch/openrisc/include/asm/pgtable.h +++ b/arch/openrisc/include/asm/pgtable.h @@ -250,7 +250,7 @@ static inline pte_t pte_mkold(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITE; return pte; diff --git a/arch/parisc/include/asm/pgtable.h b/arch/parisc/include/asm/pgtable.h index e2950f5db7c9..89f62137e67f 100644 --- a/arch/parisc/include/asm/pgtable.h +++ b/arch/parisc/include/asm/pgtable.h @@ -331,8 +331,12 @@ static inline pte_t pte_mkold(pte_t pte) { pte_val(pte) &= ~_PAGE_ACCESSED; retu static inline pte_t pte_wrprotect(pte_t pte) { pte_val(pte) &= ~_PAGE_WRITE; return pte; } static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) { pte_val(pte) |= _PAGE_WRITE; return pte; } static inline pte_t pte_mkspecial(pte_t pte) { pte_val(pte) |= _PAGE_SPECIAL; return pte; } +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) +{ + pte_val(pte) |= _PAGE_WRITE; + return pte; +} /* * Huge pte definitions. diff --git a/arch/powerpc/include/asm/book3s/32/pgtable.h b/arch/powerpc/include/asm/book3s/32/pgtable.h index 7bf1fe7297c6..10d9a1d2aca9 100644 --- a/arch/powerpc/include/asm/book3s/32/pgtable.h +++ b/arch/powerpc/include/asm/book3s/32/pgtable.h @@ -498,7 +498,7 @@ static inline pte_t pte_mkpte(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index 4acc9690f599..be0636522d36 100644 --- a/arch/powerpc/include/asm/book3s/64/pgtable.h +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h @@ -600,7 +600,7 @@ static inline pte_t pte_mkexec(pte_t pte) return __pte_raw(pte_raw(pte) | cpu_to_be64(_PAGE_EXEC)); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { /* * write implies read, hence set both @@ -1071,7 +1071,7 @@ static inline pte_t *pmdp_ptep(pmd_t *pmd) #define pmd_mkdirty(pmd) pte_pmd(pte_mkdirty(pmd_pte(pmd))) #define pmd_mkclean(pmd) pte_pmd(pte_mkclean(pmd_pte(pmd))) #define pmd_mkyoung(pmd) pte_pmd(pte_mkyoung(pmd_pte(pmd))) -#define pmd_mkwrite(pmd) pte_pmd(pte_mkwrite(pmd_pte(pmd))) +#define pmd_mkwrite(pmd, vma) pte_pmd(pte_mkwrite(pmd_pte(pmd), (vma))) #ifdef CONFIG_HAVE_ARCH_SOFT_DIRTY #define pmd_soft_dirty(pmd) pte_soft_dirty(pmd_pte(pmd)) diff --git a/arch/powerpc/include/asm/nohash/32/pgtable.h b/arch/powerpc/include/asm/nohash/32/pgtable.h index fec56d965f00..7bfbcb9ba55b 100644 --- a/arch/powerpc/include/asm/nohash/32/pgtable.h +++ b/arch/powerpc/include/asm/nohash/32/pgtable.h @@ -171,7 +171,7 @@ void unmap_kernel_page(unsigned long va); do { pte_update(mm, addr, ptep, ~0, 0, 0); } while (0) #ifndef pte_mkwrite -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/powerpc/include/asm/nohash/32/pte-8xx.h b/arch/powerpc/include/asm/nohash/32/pte-8xx.h index 1a89ebdc3acc..f32450eb270a 100644 --- a/arch/powerpc/include/asm/nohash/32/pte-8xx.h +++ b/arch/powerpc/include/asm/nohash/32/pte-8xx.h @@ -101,7 +101,7 @@ static inline int pte_write(pte_t pte) #define pte_write pte_write -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) & ~_PAGE_RO); } diff --git a/arch/powerpc/include/asm/nohash/64/pgtable.h b/arch/powerpc/include/asm/nohash/64/pgtable.h index 287e25864ffa..589009555877 100644 --- a/arch/powerpc/include/asm/nohash/64/pgtable.h +++ b/arch/powerpc/include/asm/nohash/64/pgtable.h @@ -85,7 +85,7 @@ #ifndef __ASSEMBLY__ /* pte_clear moved to later in this file */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_RW); } diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h index d8d8de0ded99..fed1b81fbe07 100644 --- a/arch/riscv/include/asm/pgtable.h +++ b/arch/riscv/include/asm/pgtable.h @@ -338,7 +338,7 @@ static inline pte_t pte_wrprotect(pte_t pte) /* static inline pte_t pte_mkread(pte_t pte) */ -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | _PAGE_WRITE); } @@ -624,9 +624,9 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return pte_pmd(pte_mkyoung(pmd_pte(pmd))); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { - return pte_pmd(pte_mkwrite(pmd_pte(pmd))); + return pte_pmd(pte_mkwrite(pmd_pte(pmd), vma)); } static inline pmd_t pmd_wrprotect(pmd_t pmd) diff --git a/arch/s390/include/asm/hugetlb.h b/arch/s390/include/asm/hugetlb.h index ccdbccfde148..558f7eef9c4d 100644 --- a/arch/s390/include/asm/hugetlb.h +++ b/arch/s390/include/asm/hugetlb.h @@ -102,9 +102,9 @@ static inline int huge_pte_dirty(pte_t pte) return pte_dirty(pte); } -static inline pte_t huge_pte_mkwrite(pte_t pte) +static inline pte_t huge_pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { - return pte_mkwrite(pte); + return pte_mkwrite(pte, vma); } static inline pte_t huge_pte_mkdirty(pte_t pte) diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index deeb918cae1d..8f2c743da0eb 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -1013,7 +1013,7 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -1499,7 +1499,7 @@ static inline pmd_t pmd_mkwrite_kernel(pmd_t pmd) return pmd; } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { return pmd_mkwrite_kernel(pmd); } diff --git a/arch/sh/include/asm/pgtable_32.h b/arch/sh/include/asm/pgtable_32.h index 21952b094650..9f2dcb9eafc8 100644 --- a/arch/sh/include/asm/pgtable_32.h +++ b/arch/sh/include/asm/pgtable_32.h @@ -351,6 +351,12 @@ static inline void set_pte(pte_t *ptep, pte_t pte) #define PTE_BIT_FUNC(h,fn,op) \ static inline pte_t pte_##fn(pte_t pte) { pte.pte_##h op; return pte; } +#define PTE_BIT_FUNC_VMA(h,fn,op) \ +static inline pte_t pte_##fn(pte_t pte, struct vm_area_struct *vma) \ +{ \ + pte.pte_##h op; \ + return pte; \ +} #ifdef CONFIG_X2TLB /* @@ -359,11 +365,11 @@ static inline pte_t pte_##fn(pte_t pte) { pte.pte_##h op; return pte; } * kernel permissions), we attempt to couple them a bit more sanely here. */ PTE_BIT_FUNC(high, wrprotect, &= ~(_PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE)); -PTE_BIT_FUNC(high, mkwrite, |= _PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE); +PTE_BIT_FUNC_VMA(high, mkwrite, |= _PAGE_EXT_USER_WRITE | _PAGE_EXT_KERN_WRITE); PTE_BIT_FUNC(high, mkhuge, |= _PAGE_SZHUGE); #else PTE_BIT_FUNC(low, wrprotect, &= ~_PAGE_RW); -PTE_BIT_FUNC(low, mkwrite, |= _PAGE_RW); +PTE_BIT_FUNC_VMA(low, mkwrite, |= _PAGE_RW); PTE_BIT_FUNC(low, mkhuge, |= _PAGE_SZHUGE); #endif diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h index d4330e3c57a6..3e8836179456 100644 --- a/arch/sparc/include/asm/pgtable_32.h +++ b/arch/sparc/include/asm/pgtable_32.h @@ -241,7 +241,7 @@ static inline pte_t pte_mkold(pte_t pte) return __pte(pte_val(pte) & ~SRMMU_REF); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return __pte(pte_val(pte) | SRMMU_WRITE); } diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h index 2dc8d4641734..c5cd5c03f557 100644 --- a/arch/sparc/include/asm/pgtable_64.h +++ b/arch/sparc/include/asm/pgtable_64.h @@ -466,7 +466,7 @@ static inline pte_t pte_mkclean(pte_t pte) return __pte(val); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { unsigned long val = pte_val(pte), mask; @@ -756,11 +756,11 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return __pmd(pte_val(pte)); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { pte_t pte = __pte(pmd_val(pmd)); - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); return __pmd(pte_val(pte)); } diff --git a/arch/um/include/asm/pgtable.h b/arch/um/include/asm/pgtable.h index a70d1618eb35..963479c133b7 100644 --- a/arch/um/include/asm/pgtable.h +++ b/arch/um/include/asm/pgtable.h @@ -207,7 +207,7 @@ static inline pte_t pte_mkyoung(pte_t pte) return(pte); } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { if (unlikely(pte_get_bits(pte, _PAGE_RW))) return pte; diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 3607f2572f9e..66c514808276 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -369,7 +369,9 @@ static inline pte_t pte_mkwrite_kernel(pte_t pte) return pte_set_flags(pte, _PAGE_RW); } -static inline pte_t pte_mkwrite(pte_t pte) +struct vm_area_struct; + +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { return pte_mkwrite_kernel(pte); } @@ -470,7 +472,7 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return pmd_set_flags(pmd, _PAGE_ACCESSED); } -static inline pmd_t pmd_mkwrite(pmd_t pmd) +static inline pmd_t pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { return pmd_set_flags(pmd, _PAGE_RW); } diff --git a/arch/xtensa/include/asm/pgtable.h b/arch/xtensa/include/asm/pgtable.h index fc7a14884c6c..d72632d9c53c 100644 --- a/arch/xtensa/include/asm/pgtable.h +++ b/arch/xtensa/include/asm/pgtable.h @@ -262,7 +262,7 @@ static inline pte_t pte_mkdirty(pte_t pte) { pte_val(pte) |= _PAGE_DIRTY; return pte; } static inline pte_t pte_mkyoung(pte_t pte) { pte_val(pte) |= _PAGE_ACCESSED; return pte; } -static inline pte_t pte_mkwrite(pte_t pte) +static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { pte_val(pte) |= _PAGE_WRITABLE; return pte; } #define pgprot_noncached(prot) \ diff --git a/include/asm-generic/hugetlb.h b/include/asm-generic/hugetlb.h index d7f6335d3999..e86c830728de 100644 --- a/include/asm-generic/hugetlb.h +++ b/include/asm-generic/hugetlb.h @@ -20,9 +20,9 @@ static inline unsigned long huge_pte_dirty(pte_t pte) return pte_dirty(pte); } -static inline pte_t huge_pte_mkwrite(pte_t pte) +static inline pte_t huge_pte_mkwrite(pte_t pte, struct vm_area_struct *vma) { - return pte_mkwrite(pte); + return pte_mkwrite(pte, vma); } #ifndef __HAVE_ARCH_HUGE_PTE_WRPROTECT diff --git a/include/linux/mm.h b/include/linux/mm.h index 1f79667824eb..af652444fbba 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1163,7 +1163,7 @@ void free_compound_page(struct page *page); static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) { if (likely(vma->vm_flags & VM_WRITE)) - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); return pte; } diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index af59cc7bd307..7bc5592900bc 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -109,10 +109,10 @@ static void __init pte_basic_tests(struct pgtable_debug_args *args, int idx) WARN_ON(!pte_same(pte, pte)); WARN_ON(!pte_young(pte_mkyoung(pte_mkold(pte)))); WARN_ON(!pte_dirty(pte_mkdirty(pte_mkclean(pte)))); - WARN_ON(!pte_write(pte_mkwrite(pte_wrprotect(pte)))); + WARN_ON(!pte_write(pte_mkwrite(pte_wrprotect(pte), args->vma))); WARN_ON(pte_young(pte_mkold(pte_mkyoung(pte)))); WARN_ON(pte_dirty(pte_mkclean(pte_mkdirty(pte)))); - WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte)))); + WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte, args->vma)))); WARN_ON(pte_dirty(pte_wrprotect(pte_mkclean(pte)))); WARN_ON(!pte_dirty(pte_wrprotect(pte_mkdirty(pte)))); } @@ -153,7 +153,7 @@ static void __init pte_advanced_tests(struct pgtable_debug_args *args) pte = pte_mkclean(pte); set_pte_at(args->mm, args->vaddr, args->ptep, pte); flush_dcache_page(page); - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, args->vma); pte = pte_mkdirty(pte); ptep_set_access_flags(args->vma, args->vaddr, args->ptep, pte, 1); pte = ptep_get(args->ptep); @@ -199,10 +199,10 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx) WARN_ON(!pmd_same(pmd, pmd)); WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd)))); WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd)))); - WARN_ON(!pmd_write(pmd_mkwrite(pmd_wrprotect(pmd)))); + WARN_ON(!pmd_write(pmd_mkwrite(pmd_wrprotect(pmd), args->vma))); WARN_ON(pmd_young(pmd_mkold(pmd_mkyoung(pmd)))); WARN_ON(pmd_dirty(pmd_mkclean(pmd_mkdirty(pmd)))); - WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd)))); + WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd, args->vma)))); WARN_ON(pmd_dirty(pmd_wrprotect(pmd_mkclean(pmd)))); WARN_ON(!pmd_dirty(pmd_wrprotect(pmd_mkdirty(pmd)))); /* @@ -253,7 +253,7 @@ static void __init pmd_advanced_tests(struct pgtable_debug_args *args) pmd = pmd_mkclean(pmd); set_pmd_at(args->mm, vaddr, args->pmdp, pmd); flush_dcache_page(page); - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, args->vma); pmd = pmd_mkdirty(pmd); pmdp_set_access_flags(args->vma, vaddr, args->pmdp, pmd, 1); pmd = READ_ONCE(*args->pmdp); @@ -928,8 +928,8 @@ static void __init hugetlb_basic_tests(struct pgtable_debug_args *args) pte = mk_huge_pte(page, args->page_prot); WARN_ON(!huge_pte_dirty(huge_pte_mkdirty(pte))); - WARN_ON(!huge_pte_write(huge_pte_mkwrite(huge_pte_wrprotect(pte)))); - WARN_ON(huge_pte_write(huge_pte_wrprotect(huge_pte_mkwrite(pte)))); + WARN_ON(!huge_pte_write(huge_pte_mkwrite(huge_pte_wrprotect(pte), args->vma))); + WARN_ON(huge_pte_write(huge_pte_wrprotect(huge_pte_mkwrite(pte, args->vma)))); #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB pte = pfn_pte(args->fixed_pmd_pfn, args->page_prot); diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 4fc43859e59a..aaf815838144 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -555,7 +555,7 @@ __setup("transparent_hugepage=", setup_transparent_hugepage); pmd_t maybe_pmd_mkwrite(pmd_t pmd, struct vm_area_struct *vma) { if (likely(vma->vm_flags & VM_WRITE)) - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, vma); return pmd; } @@ -1580,7 +1580,7 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) pmd = pmd_modify(oldpmd, vma->vm_page_prot); pmd = pmd_mkyoung(pmd); if (writable) - pmd = pmd_mkwrite(pmd); + pmd = pmd_mkwrite(pmd, vma); set_pmd_at(vma->vm_mm, haddr, vmf->pmd, pmd); update_mmu_cache_pmd(vma, vmf->address, vmf->pmd); spin_unlock(vmf->ptl); @@ -1926,7 +1926,7 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, /* See change_pte_range(). */ if ((cp_flags & MM_CP_TRY_CHANGE_WRITABLE) && !pmd_write(entry) && can_change_pmd_writable(vma, addr, entry)) - entry = pmd_mkwrite(entry); + entry = pmd_mkwrite(entry, vma); ret = HPAGE_PMD_NR; set_pmd_at(mm, addr, pmd, entry); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 07abcb6eb203..6af471bdcff8 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4900,7 +4900,7 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page, if (writable) { entry = huge_pte_mkwrite(huge_pte_mkdirty(mk_huge_pte(page, - vma->vm_page_prot))); + vma->vm_page_prot)), vma); } else { entry = huge_pte_wrprotect(mk_huge_pte(page, vma->vm_page_prot)); @@ -4916,7 +4916,7 @@ static void set_huge_ptep_writable(struct vm_area_struct *vma, { pte_t entry; - entry = huge_pte_mkwrite(huge_pte_mkdirty(huge_ptep_get(ptep))); + entry = huge_pte_mkwrite(huge_pte_mkdirty(huge_ptep_get(ptep)), vma); if (huge_ptep_set_access_flags(vma, address, ptep, entry, 1)) update_mmu_cache(vma, address, ptep); } diff --git a/mm/memory.c b/mm/memory.c index f456f3b5049c..d0972d2d6f36 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4067,7 +4067,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) entry = mk_pte(&folio->page, vma->vm_page_prot); entry = pte_sw_mkyoung(entry); if (vma->vm_flags & VM_WRITE) - entry = pte_mkwrite(pte_mkdirty(entry)); + entry = pte_mkwrite(pte_mkdirty(entry), vma); vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, &vmf->ptl); @@ -4755,7 +4755,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) pte = pte_modify(old_pte, vma->vm_page_prot); pte = pte_mkyoung(pte); if (writable) - pte = pte_mkwrite(pte); + pte = pte_mkwrite(pte, vma); ptep_modify_prot_commit(vma, vmf->address, vmf->pte, old_pte, pte); update_mmu_cache(vma, vmf->address, vmf->pte); pte_unmap_unlock(vmf->pte, vmf->ptl); diff --git a/mm/migrate_device.c b/mm/migrate_device.c index d30c9de60b0d..df3f5e9d5f76 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -646,7 +646,7 @@ static void migrate_vma_insert_page(struct migrate_vma *migrate, } entry = mk_pte(page, vma->vm_page_prot); if (vma->vm_flags & VM_WRITE) - entry = pte_mkwrite(pte_mkdirty(entry)); + entry = pte_mkwrite(pte_mkdirty(entry), vma); } ptep = pte_offset_map_lock(mm, pmdp, addr, &ptl); diff --git a/mm/mprotect.c b/mm/mprotect.c index 1d4843c97c2a..381163a41e88 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -198,7 +198,7 @@ static long change_pte_range(struct mmu_gather *tlb, if ((cp_flags & MM_CP_TRY_CHANGE_WRITABLE) && !pte_write(ptent) && can_change_pte_writable(vma, addr, ptent)) - ptent = pte_mkwrite(ptent); + ptent = pte_mkwrite(ptent, vma); ptep_modify_prot_commit(vma, addr, pte, oldpte, ptent); if (pte_needs_flush(oldpte, ptent)) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 53c3d916ff66..3db6f87c0aca 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -75,7 +75,7 @@ int mfill_atomic_install_pte(struct mm_struct *dst_mm, pmd_t *dst_pmd, if (page_in_cache && !vm_shared) writable = false; if (writable) - _dst_pte = pte_mkwrite(_dst_pte); + _dst_pte = pte_mkwrite(_dst_pte, dst_vma); if (wp_copy) _dst_pte = pte_mkuffd_wp(_dst_pte); -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:32:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:32:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502969.775041 (Exim 4.92) (envelope-from ) id 1pWm2b-0001to-Lp; Mon, 27 Feb 2023 22:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502969.775041; Mon, 27 Feb 2023 22:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm2b-0001th-J4; Mon, 27 Feb 2023 22:32:17 +0000 Received: by outflank-mailman (input) for mailman id 502969; Mon, 27 Feb 2023 22:32:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWm2a-0001mc-5B for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:32:16 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 960448b1-b6ee-11ed-9685-2f268f93b82a; Mon, 27 Feb 2023 23:32:15 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id l7-20020a05600c4f0700b003e79fa98ce1so4761806wmq.2 for ; Mon, 27 Feb 2023 14:32:15 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id 7-20020a05600c028700b003dc47d458cdsm10091307wmk.15.2023.02.27.14.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 14:32:14 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 960448b1-b6ee-11ed-9685-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ofek98SXwJV2M6Yf6K+LdTUVNT4BwXDI3q6LCsUjAbM=; b=mvOH5L0O5VrDuqOkJOneTHF0kZjSFhkuqYqGYY1b3iDRgoS25+AjZMG/Sbr5+PT3cH eNVT811nI0dgMwuHj2PnFqPQdJQf+ZmaRS9u7MpvRQUD6goztJc7aYuRh2AbH2JjJueE YEHRp5Ng1EZrCF67kMuU7nZ1JRLnL8vZFP6rBDITyO2KP9iAuQL5zr3+VLXmlXT4ubra weEsjWLbVI4YP5Jhmbdi6U8LLRgCrqoMGjf12zrPfHW98Ncuslo0F4Nd1oa8iss3ReSS t184TWHoXYgOHbSQ3Mv2nTRA1ZLys135PxQwHvrQytH8vuhsRspz5Ik8LZQAAzjn1wdi l1Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ofek98SXwJV2M6Yf6K+LdTUVNT4BwXDI3q6LCsUjAbM=; b=mUoapPjYlFg7aqXdCg7zDzMwkBcykQMkYUX8X5plvOWSaCMZBt+WMLr+TFtPZZpiXF /dUROCDtZ85DTZ+IwImiySuq65LoyUwaqrRDJHRSHG5VWUipI+6ARS40DWPjDgoLfaKw +V3EaoyzHiUlr4p9WA+77S+32mqG/T07hIcvg+yUQGzZ0oR+EwDeBD2zKEAWXXU/7hSQ hb7l8/lQJQzi1c7bL77V0xHfQdYjVN55KBFEFMs+H9J3yo9lz+ZcbaUICRtcuIO1Zglg gz1n9l8qFJxJZ3mb6LPgSQDMzC3jVo8b2pL+nD1gCKXOV8lsCzSt5QtqNPLJpN62hRLm dI7g== X-Gm-Message-State: AO0yUKXjryqCNY1t7jbw5PInNMq6+hlCYSADG2SnYJKD0fYT4fmSGAto T5Gq7SwED8ukv+EDb5CW4u/Ziw== X-Google-Smtp-Source: AK7set9s3SslHAqqicd2niVRMhwWH/QJ3T9n5pd3LtY4pHcbw8/iWqLGlwcnuR5R+JDLd9iTy2Ht0w== X-Received: by 2002:a05:600c:4f45:b0:3e2:24a0:ba26 with SMTP id m5-20020a05600c4f4500b003e224a0ba26mr482035wmq.16.1677537134886; Mon, 27 Feb 2023 14:32:14 -0800 (PST) Message-ID: <77b8545c-4f2a-b389-2811-47d2d48940d9@linaro.org> Date: Mon, 27 Feb 2023 23:32:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Content-Language: en-US To: "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230227150858-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/2/23 21:12, Michael S. Tsirkin wrote: > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >> I feel like we should have separate deprecation entries for the >> i686 host support, and for qemu-system-i386 emulator binary, as >> although they're related they are independant features with >> differing impact. eg removing qemu-system-i386 affects all >> host architectures, not merely 32-bit x86 host, so I think we >> can explain the impact more clearly if we separate them. > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > a superset. Doesn't qemu-system-i386 start the CPU in a different mode that qemu-system-x86_64? Last time we discussed it, we mention adding -32 and -64 CLI flags to maintain compat, and IIRC this flag would add boot code to switch the CPU in 32-b. But then maybe I misunderstood. Thomas said, "CPUs must start in the same mode they start in HW". > Removing support for building on 32 bit systems seems like a pity - it's > one of a small number of ways to run 64 bit binaries on 32 bit systems, > and the maintainance overhead is quite small. > > In fact, keeping this support around forces correct use of > posix APIs such as e.g. PRIx64 which makes the code base > more future-proof. > From xen-devel-bounces@lists.xenproject.org Mon Feb 27 22:48:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 22:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502974.775052 (Exim 4.92) (envelope-from ) id 1pWmIU-0003x8-1t; Mon, 27 Feb 2023 22:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502974.775052; Mon, 27 Feb 2023 22:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWmIT-0003x1-Uz; Mon, 27 Feb 2023 22:48:41 +0000 Received: by outflank-mailman (input) for mailman id 502974; Mon, 27 Feb 2023 22:48:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWmIS-0003wv-HL for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 22:48:40 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id df813511-b6f0-11ed-a550-8520e6686977; Mon, 27 Feb 2023 23:48:38 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 67758B80DC5; Mon, 27 Feb 2023 22:48:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69F8BC433D2; Mon, 27 Feb 2023 22:48:35 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df813511-b6f0-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677538116; bh=hRktmfAmZkwVdjFyjizrJlsqcCs1N4kdnbLwS3QO1D0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=l5dLTb2LuDZfP7to7pVmx6nw4b/YokW7jPBekeAWleesBHvpLdiokEf4HMagbN5E6 S79aWfMD+nCndTUNIDBjXNhjGXOOonNocJqWCIh3hlQ9/A+/+uOEf6hSeos/kXWCXg FoIVUTc+J6aCXspNgnDvfu6a9L2pnKmFoLq5SnK9BGLpsO9jReW9Vwtfiizfxt+jjM kQN5M9OZp9WLktxtWMKctMngYh2xdD/in6BFJM08mPeCZoJwJ/sagVMqimH+UEnsDA 5/tr+Xh0ZkMjElilsvhtwD4VQWcflFphYLFjt8baGMUi8mDwD/jJWi3SGl2ejmdzE/ 0+yb+OAT3PY3g== Date: Mon, 27 Feb 2023 14:48:33 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v3] automation: Add container and build jobs to run cppcheck analysis In-Reply-To: <20230224101700.9032-1-michal.orzel@amd.com> Message-ID: References: <20230224101700.9032-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 24 Feb 2023, Michal Orzel wrote: > Add a debian container with cppcheck installation routine inside, > capable of performing cppcheck analysis on Xen-only build including > cross-builds for arm32 and x86_64. > > Populate build jobs making use of that container to run cppcheck > analysis to produce a text report (xen-cppcheck.txt) containing the list > of all the findings. > > This patch does not aim at performing any sort of bisection. Cppcheck is > imperfect and for now, our goal is to at least be aware of its reports, > so that we can compare them with the ones produced by better tools and > to be able to see how these reports change as a result of further > infrastructure improvements (e.g. exception list, rules exclusion). > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > Changes in v3: > - use multi-stage build to reduce the size of container > - drop Stefano Rb as a result of dockefile changes > > Changes in v2: > - use arm64 container instead of x86 to make pipeline faster > - explicitly set HYPERVISOR_ONLY=y for cppcheck jobs > --- > .../build/debian/unstable-cppcheck.dockerfile | 53 +++++++++++++++++++ > automation/gitlab-ci/build.yaml | 43 +++++++++++++++ > automation/scripts/build | 11 +++- > 3 files changed, 106 insertions(+), 1 deletion(-) > create mode 100644 automation/build/debian/unstable-cppcheck.dockerfile > > diff --git a/automation/build/debian/unstable-cppcheck.dockerfile b/automation/build/debian/unstable-cppcheck.dockerfile > new file mode 100644 > index 000000000000..adc192cea645 > --- /dev/null > +++ b/automation/build/debian/unstable-cppcheck.dockerfile > @@ -0,0 +1,53 @@ > +FROM arm64v8/debian:unstable AS builder > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV CPPCHECK_VERSION=2.7 > +ENV USER root > + > +# dependencies for cppcheck build > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + curl \ > + build-essential \ > + python-is-python3 \ > + libpcre3-dev > + > +RUN mkdir /build > +WORKDIR /build > + > +# cppcheck release build (see cppcheck readme.md) > +RUN curl -fsSLO https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \ > + tar xvzf "$CPPCHECK_VERSION".tar.gz && \ > + cd cppcheck-"$CPPCHECK_VERSION" && \ > + make install -j$(nproc) \ > + MATCHCOMPILER=yes \ > + FILESDIR=/usr/share/cppcheck \ > + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare -Wno-unused-function" > + > +FROM arm64v8/debian:unstable > +COPY --from=builder /usr/bin/cppcheck /usr/bin/cppcheck > +COPY --from=builder /usr/share/cppcheck /usr/share/cppcheck > + > +LABEL maintainer.name="The Xen Project" \ > + maintainer.email="xen-devel@lists.xenproject.org" > + > +ENV DEBIAN_FRONTEND=noninteractive > +ENV USER root > + > +RUN mkdir /build > +WORKDIR /build > + > +# dependencies for cppcheck analysis including Xen-only build/cross-build > +RUN apt-get update && \ > + apt-get --quiet --yes install \ > + build-essential \ > + python-is-python3 \ > + libpcre3-dev \ > + flex \ > + bison \ > + gcc-arm-linux-gnueabihf \ > + gcc-x86-64-linux-gnu \ > + && \ > + apt-get autoremove -y && \ > + apt-get clean && \ > + rm -rf /var/lib/apt/lists* /tmp/* /var/tmp/* > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml > index 22ce1c45e7cd..0835b7a65190 100644 > --- a/automation/gitlab-ci/build.yaml > +++ b/automation/gitlab-ci/build.yaml > @@ -7,6 +7,7 @@ > paths: > - binaries/ > - xen-config > + - xen-cppcheck.txt > - '*.log' > - '*/*.log' > when: always > @@ -199,6 +200,23 @@ > variables: > <<: *gcc > > +.x86-64-cross-build-tmpl: > + <<: *build > + variables: > + XEN_TARGET_ARCH: x86_64 > + tags: > + - arm64 > + > +.x86-64-cross-build: > + extends: .x86-64-cross-build-tmpl > + variables: > + debug: n > + > +.gcc-x86-64-cross-build: > + extends: .x86-64-cross-build > + variables: > + <<: *gcc > + > # Jobs below this line > > archlinux-gcc: > @@ -679,6 +697,31 @@ archlinux-current-gcc-riscv64-debug-randconfig: > EXTRA_FIXED_RANDCONFIG: > CONFIG_COVERAGE=n > > +# Cppcheck analysis jobs > + > +debian-unstable-gcc-cppcheck: > + extends: .gcc-x86-64-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/x86_64-linux-gnu- > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > +debian-unstable-gcc-arm32-cppcheck: > + extends: .gcc-arm32-cross-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CROSS_COMPILE: /usr/bin/arm-linux-gnueabihf- > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > +debian-unstable-gcc-arm64-cppcheck: > + extends: .gcc-arm64-build > + variables: > + CONTAINER: debian:unstable-cppcheck > + CPPCHECK: y > + HYPERVISOR_ONLY: y > + > ## Test artifacts common > > .test-jobs-artifact-common: > diff --git a/automation/scripts/build b/automation/scripts/build > index f2f5e55bc04f..7d1b19c4250d 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -38,7 +38,16 @@ cp xen/.config xen-config > # Directory for the artefacts to be dumped into > mkdir binaries > > -if [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > +if [[ "${CPPCHECK}" == "y" ]] && [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > + # Cppcheck analysis invokes Xen-only build. > + # Known limitation: cppcheck generates inconsistent reports when running > + # in parallel mode, therefore do not specify -j. > + xen/scripts/xen-analysis.py --run-cppcheck --cppcheck-misra > + > + # Preserve artefacts > + cp xen/xen binaries/xen > + cp xen/cppcheck-report/xen-cppcheck.txt xen-cppcheck.txt > +elif [[ "${HYPERVISOR_ONLY}" == "y" ]]; then > # Xen-only build > make -j$(nproc) xen > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Feb 27 23:35:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 27 Feb 2023 23:35:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502979.775062 (Exim 4.92) (envelope-from ) id 1pWn1U-0002Pc-FK; Mon, 27 Feb 2023 23:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502979.775062; Mon, 27 Feb 2023 23:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWn1U-0002PV-Bj; Mon, 27 Feb 2023 23:35:12 +0000 Received: by outflank-mailman (input) for mailman id 502979; Mon, 27 Feb 2023 23:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWn1T-0002PM-5q for xen-devel@lists.xenproject.org; Mon, 27 Feb 2023 23:35:11 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d941f02-b6f7-11ed-a550-8520e6686977; Tue, 28 Feb 2023 00:35:06 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA771B80DBF; Mon, 27 Feb 2023 23:35:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A5CC433EF; Mon, 27 Feb 2023 23:35:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d941f02-b6f7-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677540904; bh=1utzo10uAmMF/26nJZf2EhfUMs6ZWXfW3bGazBQ+oR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IxDESo6p78DEc2xrjH44dO6Rvu5BFSD0/YufMoLBkYiH3Wu3V3+RT4qYjhaBUfSfb 3qFFCl+FooJHouSg+7fBZzbwvUNrdBlc6z3SfLs+5AJz1ishoJTAl2g485oPAmsFmv e+h5kLIqQ0yYrb8pcKm/0nzBKwD+5WtPKulU6eXlEDfr7w6SH7tvqWuEi9+ICr5J3x pCum5p60LUbPrrp+xYYN92NvSf8iibCjb/OEYFxdZ3/qrZWjJkSsqHOKqLReltQIEH KXsUvU2h8sPbNFuBtlOqdW+mMeldD3xyDMzBTIiAX1yRpy88RQeGjHMK/SoQXU1N7Z zIDz4AMZ9eg6Q== Date: Mon, 27 Feb 2023 15:35:03 -0800 From: Jakub Kicinski To: Tom Rix Cc: Juergen Gross , wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and index Message-ID: <20230227153503.3bc54eaf@kernel.org> In-Reply-To: References: <20230226163429.2351600-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 27 Feb 2023 09:29:30 +0100 Juergen Gross wrote: > On 26.02.23 17:34, Tom Rix wrote: > > building with gcc and W=3D1 reports > > drivers/net/xen-netback/netback.c:886:21: error: variable > > =E2=80=98pending_idx=E2=80=99 set but not used [-Werror=3Dunused-but= -set-variable] > > 886 | u16 pending_idx; > > | ^~~~~~~~~~~ > >=20 > > pending_idx is not used so remove it. Since index was only > > used to set pending_idx, remove index as well. > >=20 > > Signed-off-by: Tom Rix =20 >=20 > Reviewed-by: Juergen Gross Applied, thanks! From xen-devel-bounces@lists.xenproject.org Tue Feb 28 00:46:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 00:46:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502986.775071 (Exim 4.92) (envelope-from ) id 1pWo8g-00041f-Na; Tue, 28 Feb 2023 00:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502986.775071; Tue, 28 Feb 2023 00:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWo8g-00041Y-Kw; Tue, 28 Feb 2023 00:46:42 +0000 Received: by outflank-mailman (input) for mailman id 502986; Tue, 28 Feb 2023 00:46:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWo8e-00041N-Vl for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 00:46:41 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bcd4d06-b701-11ed-9689-2f268f93b82a; Tue, 28 Feb 2023 01:46:38 +0100 (CET) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8EDD4B80DD6; Tue, 28 Feb 2023 00:46:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4A1A5C433D2; Tue, 28 Feb 2023 00:46:36 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 29902E1CF31; Tue, 28 Feb 2023 00:46:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bcd4d06-b701-11ed-9689-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677545196; bh=bwOp4yx50VaNVXym63VvR5fZ9BdHxXUqyY+m544YWks=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=YxPm8N3ab3cZpy5YrbfoDNAjYJQuo4IGt6Gy1eCb8mGB3+xd78v9Fg+z6M51hlF/X 2bQkOiCVqR+FS/3g2jF78ht/6YMNWjO1Fxip6D0fKTv/BPRUp+/an8tlj6AVMLI+gR IDFk8+emzDuiO/R5Cyf2JDAw1Ig2r/XLWXisPn9ooTqvpLlechPB58Vg+xfZ3DqX7L 601gFyyCclePHqR5sNpSJ8V7olJPmb5aJq0WQLTQa79lJl0hUfSTAQHQkcg4xtuvD2 GvC3rDtSj/jIjcW8qiiKHcJnJlXDbGLC5Uc5vLw/dAhtu1SgjD3cR/LRmbHBdXXVi+ x05PP8BFuYX1A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and index From: patchwork-bot+netdevbpf@kernel.org Message-Id: <167754519616.16363.18059153345889882200.git-patchwork-notify@kernel.org> Date: Tue, 28 Feb 2023 00:46:36 +0000 References: <20230226163429.2351600-1-trix@redhat.com> In-Reply-To: <20230226163429.2351600-1-trix@redhat.com> To: Tom Rix Cc: wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sun, 26 Feb 2023 11:34:29 -0500 you wrote: > building with gcc and W=1 reports > drivers/net/xen-netback/netback.c:886:21: error: variable > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] > 886 | u16 pending_idx; > | ^~~~~~~~~~~ > > pending_idx is not used so remove it. Since index was only > used to set pending_idx, remove index as well. > > [...] Here is the summary with links: - xen-netback: remove unused variables pending_idx and index https://git.kernel.org/netdev/net-next/c/ccf8f7d71424 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Tue Feb 28 00:58:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 00:58:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502990.775081 (Exim 4.92) (envelope-from ) id 1pWoKQ-0005rF-Qk; Tue, 28 Feb 2023 00:58:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502990.775081; Tue, 28 Feb 2023 00:58:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWoKQ-0005r8-OD; Tue, 28 Feb 2023 00:58:50 +0000 Received: by outflank-mailman (input) for mailman id 502990; Tue, 28 Feb 2023 00:58:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWoKP-0005qy-Dx; Tue, 28 Feb 2023 00:58:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWoKP-0000rZ-Bc; Tue, 28 Feb 2023 00:58:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWoKP-0002Mi-5A; Tue, 28 Feb 2023 00:58:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWoKP-0001di-4f; Tue, 28 Feb 2023 00:58:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NZAAoDpQ2Yy6x52yjuH0imn85rW2eX1MaHl1NaPrGCY=; b=gy5ZWuEQ9lqPO5jo0dEhvpCDvA 3NE0ltw1cZ9rZ06hx+kFSZoL8Tr7eCRaH5DVrD5Nb1BHNMzQAEP+/xumlera1AEqrOhZOBJWaSVpg dxklZE3y0MOp3lo5hH00lZeQq8qaCJikvnaHHoU67K2J8yEVoZbnsLiKyFtG0X6Y4Hyk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178708: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=bfc3780f23ded229f42a2565783e21c32083bbfd X-Osstest-Versions-That: xen=49b1cb27413034c81023d1faf7af43690e87291a From: osstest service owner Date: Tue, 28 Feb 2023 00:58:49 +0000 flight 178708 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178708/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen bfc3780f23ded229f42a2565783e21c32083bbfd baseline version: xen 49b1cb27413034c81023d1faf7af43690e87291a Last test of basis 178690 2023-02-27 19:01:55 Z 0 days Testing same since 178708 2023-02-27 23:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 49b1cb2741..bfc3780f23 bfc3780f23ded229f42a2565783e21c32083bbfd -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 28 02:39:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 02:39:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.502996.775092 (Exim 4.92) (envelope-from ) id 1pWptY-0001ER-Ud; Tue, 28 Feb 2023 02:39:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 502996.775092; Tue, 28 Feb 2023 02:39:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWptY-0001EJ-PS; Tue, 28 Feb 2023 02:39:12 +0000 Received: by outflank-mailman (input) for mailman id 502996; Tue, 28 Feb 2023 02:39:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWptY-0001E9-4g; Tue, 28 Feb 2023 02:39:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWptY-0001v9-1g; Tue, 28 Feb 2023 02:39:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWptX-0004e6-K0; Tue, 28 Feb 2023 02:39:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWptX-0006ZL-JY; Tue, 28 Feb 2023 02:39:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tzc9PWHjdxNJJqgsSHFcC9yaK27cxaos6fOefEIskGc=; b=fuoLWLdngC1fZdEYDFc+DGkB+J Fb8rcs+NjbWveyb2HoMFdokE4r1KqJfUwcb+WnwUldy6sSwKe1gUhpFkLt5S+c2izpvsVdJwwBzpM hvxeAW09KlCCzuOzpURJMAJNNCj1XZQpan65yi3s21yt4lupUD2ILbzVH3uyFsoSTSds=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178673: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c X-Osstest-Versions-That: xen=608f85a1818697156b72ace4913a17c8178a0ef5 From: osstest service owner Date: Tue, 28 Feb 2023 02:39:11 +0000 flight 178673 xen-unstable real [real] flight 178720 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/178673/ http://logs.test-lab.xenproject.org/osstest/logs/178720/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail REGR. vs. 178515 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail like 178616 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178616 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178616 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178616 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178616 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178616 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c baseline version: xen 608f85a1818697156b72ace4913a17c8178a0ef5 Last test of basis 178616 2023-02-27 01:53:22 Z 1 days Testing same since 178673 2023-02-27 15:09:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c Author: Jan Beulich Date: Mon Feb 27 13:37:27 2023 +0100 x86/setup: drop stale declarations of __bss_{start,end}[] There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct Xen's idea of its own memory layout"). For what's left, switch to "unsigned char" as here we're not dealing with strings of any kind. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit db3897746cf8a0b77b13c589897237867800b023 Author: Jan Beulich Date: Mon Feb 27 13:36:58 2023 +0100 x86/shadow: drop dead code from HVM-only sh_page_fault() pieces The shadow_mode_refcounts() check immediately ahead of the "emulate" label renders redundant two subsequent is_hvm_domain() checks (the latter of which was already redundant with the former). Also guest_mode() checks are pointless when we already know we're dealing with a HVM domain. Finally style-adjust a comment which otherwise would be fully visible as patch context anyway. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 1950d8c351c3dd2ba9e4cc283ec91cb580824fd4 Author: Jan Beulich Date: Mon Feb 27 13:36:01 2023 +0100 x86/shadow: mark more of sh_page_fault() HVM-only The types p2m_is_readonly() checks for aren't applicable to PV; specifically get_gfn() won't ever return any such type for PV domains. Extend the HVM-conditional block of code, also past the subsequent HVM- only if(). This way the "emulate_readonly" also becomes unreachable when !HVM, so move the conditional there upwards as well. Noticing the earlier shadow_mode_refcounts() check, move it up even further, right after that check. With that, the "done" label also needs marking as potentially unused. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 4e8205f4fdb9a043170439c9c63542ddff816849 Author: Jan Beulich Date: Mon Feb 27 13:34:30 2023 +0100 x86/shadow: move dm-mmio handling code in sh_page_fault() Do away with the partly mis-named "mmio" label there, which really is only about emulated MMIO. Move the code to the place where the sole "goto" was. Re-order steps slightly: Assertion first, perfc increment outside of the locked region, and "gpa" calculation closer to the first use of the variable. Also make the HVM conditional cover the entire if(), as p2m_mmio_dm isn't applicable to PV; specifically get_gfn() won't ever return this type for PV domains. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Feb 28 06:44:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 06:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503011.775114 (Exim 4.92) (envelope-from ) id 1pWtj5-0000IV-Am; Tue, 28 Feb 2023 06:44:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503011.775114; Tue, 28 Feb 2023 06:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWtj5-0000IO-80; Tue, 28 Feb 2023 06:44:39 +0000 Received: by outflank-mailman (input) for mailman id 503011; Tue, 28 Feb 2023 06:44:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWtj4-0000II-3z for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 06:44:38 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a3485d7-b733-11ed-a550-8520e6686977; Tue, 28 Feb 2023 07:44:34 +0100 (CET) Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31S6BWbQ026040 for ; Tue, 28 Feb 2023 06:44:29 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nyb7wned6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Feb 2023 06:44:29 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31S5vF9C029242 for ; Tue, 28 Feb 2023 06:44:25 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ny8scdsdv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Feb 2023 06:44:25 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) by IA1PR10MB7214.namprd10.prod.outlook.com (2603:10b6:208:3f3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16; Tue, 28 Feb 2023 06:44:23 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988]) by BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988%3]) with mapi id 15.20.6156.014; Tue, 28 Feb 2023 06:44:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a3485d7-b733-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : from : subject : cc : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=fgvHt5SuU9nY5xgzbhsJbr2Vu067gE/yZqnquXFHFpU=; b=TmDfbHZ9YLJB1O/BJHkeb5KE79P2LzXznV/UzHSxAdO6ONfAnujyyrLXizD5g4vVm3EE +IqelPaaagq3o+wuqXmy4P8LTqwaGSopMVtIca44FFtZh41frwrE4Y0bXLCkgwujs3D0 Uia2+jrxy/l9tJGKXn7quu40yVt7ILoONYxGc18TUG6caUCKLRhv1fwujSRALbrUP6Y/ 94liVtiBiHAHT3exZCFerkxewoqdS3MSwe/4uc6Ms05CCAlc6JKYfegtatS3GlaqOUw0 LX9gaUxNBJtJRYb6yH5l/VOUytI55kzz+dzbdmGP4YGC6lkEUPvkGy/PK3rrOynwEqoU kg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/2dmsmvOGvddiI8UQXG3MFFqOBg6f4hjr3gCFjp+gxUjd3OQDdKrXOgcvWv/jplNUAGZABGRPEypLeGY7I8FmfMCpqf+K+msmyQQSR5ueYCg6DFx9JOiMHuqWVEs6tNvfMbXNH9y3NX9bbtklGrKmJQb89+9haE5nxy/hnCBY82SdIn8/7lSMVPT5kdIIwqsJd7bf58GVDntsD6JZetRYdbmW0kM5fpfUFzCe+r3yZ08ZQ9LaRIr4i42vy6P47mpVztu/lz9U9Li+LqzSby+XmtUII04nHOAGW8ySMwtpsuTY1t02cH5YWG9HoxzqnW41t52qDKr7QzpJlJZaO4pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fgvHt5SuU9nY5xgzbhsJbr2Vu067gE/yZqnquXFHFpU=; b=T3qNZbAhNiWVycF9UAwcdmTR9DpscWGpYHieALJUneq8bBRFMkbwLUnKR5h5qtK9QUkXJ6vArZH/V82hgQ9VQoT5dBGyU0NEokgbQhTTuUSVRH0Si6Tt3w842dLqjfxt3S3C+k7JBMRqX242cLB+pNK/mFsQr4zV/Vgr4XEveVC9uIqCt9R6C1VN+RO2r5Q+A6xlzPMRzLMBqbjwNxqXFnOsNDVIeeIUegBxHf0Ss+Ip2kOyHdq9jH0gFMo1E4mLcUhQXCb/dFNV5p7xLfgPKXcKHUqCH6IvRj+wibKWgMMQ/sdK0D7RLjkEi3MZ9+Zjb41rBc61HW9M6GZfuUxuTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgvHt5SuU9nY5xgzbhsJbr2Vu067gE/yZqnquXFHFpU=; b=GqSfc+eciXtJNbNaTfJ8qLvFY7gbvNsWVK92h+yKIU3T1/t/ZRvw1rOgdwAxC9S+lwQfCK9lYgS6k1Mhuh2aT5wKanMLDDNUKIPBlGy1JyhomNLugcdFWXSZWmig2VRj3uq8met/osd/T/xqCZmhEbW4U0zmTHOAjTHUVQILTE8= Message-ID: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> Date: Mon, 27 Feb 2023 22:44:19 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: xen-devel@lists.xenproject.org Content-Language: en-US From: Joe Jin Subject: Is xl vcpu-set broken Cc: Boris Ostrovsky Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BY5PR16CA0002.namprd16.prod.outlook.com (2603:10b6:a03:1a0::15) To BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3160:EE_|IA1PR10MB7214:EE_ X-MS-Office365-Filtering-Correlation-Id: 1428af61-c4b1-47b5-44a3-08db195739ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qg07FUM8mLSd013a8svRo8RtxR3fvpxZBirGJ6mFUR/6km95MvPrBnzv6lDvOg75FMl+GmWPxcxa3466gLHVzFNxwvKepC9UrAitASe18IAyzMJ2sipd6LcHoKi6MW5O9ySnwbwVlmay4KSK7jwqxEAsULz0Rw2+R4ZuvWiqYQQ3KGg1AQbBl9+Bfe3BbrfO9u9o63xUweV7WZw2Q6HkEKpsJiuFaOz2/7EE/x3o2NmE1lnnN9ZDiJ39obrb2lAfZ0iGdd1ggyA4/fec8JmsnWeeSnzXP6wA10KH3+UTlBbxlOL/EjYNigzu9oCMro/4sGpa2UC5EDGE0+iDv/TX9YhyyvUKEfrcAp0QhZ9J/yLb/HZ4YL+uTc7E5HhYvz2bII8nC616/r7SKVQrgFWjlIySJ3430Nr9m9ONzPN74Vfowy+l1A2HzKAI+ajXwbTmWF17ujTgQ0eFdbLBV/vDl0yLfNhr+4xocdtlPxxexCFLtg/IOiplWtOlT9V5bNydSz3gatbhxgAj5abejui5rY20Jp33TM1F8LMIuLihoE/L/Ms2vCYaioXrvEhQpshyp3MREijr/6VHCZW0CM3U+XUk1dZYx0py3yr0BGjPMtIblHrC0p6ucI3ZvfzZHEHsjs09HFbmgwQ/QzYsBuowA+AqI/IU6lEMqo5HWfCXrevDa/KgNQlYUlT2c0C5e/6MjA+XBU828nSThbQg+W6sjUlvNlqeUXmzTH8ofIYEL2U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3160.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(346002)(136003)(366004)(376002)(451199018)(31686004)(31696002)(86362001)(36756003)(41300700001)(66556008)(66476007)(66946007)(5660300002)(8936002)(6916009)(4326008)(8676002)(44832011)(2906002)(3480700007)(38100700002)(6666004)(107886003)(6486002)(478600001)(316002)(83380400001)(2616005)(186003)(6512007)(6506007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djRYL0JUL2QyM1FSdUM4Sm5LRkFHWVBmVWwzS1VSRVBueHZZc2tPaGhER2lk?= =?utf-8?B?dk1McEFNQVZIbEViUGdsbnprNUh5Nm1lclplMUlOYkZ6NTgwcS9TelZPaGk4?= =?utf-8?B?Uk55dGhMdEhhNnBTaVRqcnJVMXc1eXpCN21TeWNpMDZLRVBhNHlCVUQzaExJ?= =?utf-8?B?K2JsbjFkK0RFdkpLQVg4b0Jya3V4TWxJZVcvRFdNZlRpdE5NamQwTzVKbFZi?= =?utf-8?B?SDBST0k5TXBOZVhUakx4UitVeFRpTlJwd2pCMWhDN1FTcWt2YXV6OUt0SFBx?= =?utf-8?B?QWtFKzNYdHByS2JaT1d4QTE1K0ZiaDVudlZCSm5qVjZhNTVBeEdiZVhaeWRL?= =?utf-8?B?c2QrajVlNXRpbWNKbU8wOS8rMVhmSVZqSi84NG1DNVBHV1lDMHBpSHFaSzhZ?= =?utf-8?B?QUZQSGFkTDNuTzBEbUtFeWE0ZHliSEFlY1lTdmlCOXdOK243NnFqZHVYY2cr?= =?utf-8?B?U0hMVzE2V0R3VjQ3WkhnQUszVjFkSE5EQUVBd2VEOGxWRDdxbXBHdVp5SWZ3?= =?utf-8?B?NGEyeDFnYk1ENWQzYjlObVlzYlVCOUFHSXhRTXZYbnlRTVhLYVdJYitXV3Vx?= =?utf-8?B?M3cySEpheWNiZHZ0bmtwbGRMSElRWnNSZUsvc2hSaW4xWHVXTVJlQW5WWGlX?= =?utf-8?B?UlNYNEJhZ1NyN2w3TVNmRHBFLzRoK1R6VE82NVptdi9wZnZ5cTBoNnlHNGFG?= =?utf-8?B?WFhBcmxIczkxbEhBUXJZeWdXbksxcjhob3dJYXU5UmZCblRUbzdYRG1RNm1I?= =?utf-8?B?RTJ2TGZ1dHhBbS8yYVZOOVAzTW9iZlM3TEwxSzN0d1FJTlBZdzlTY2Rqa2Vh?= =?utf-8?B?cyt2R0JnZzFranFvaE95eHBobFhhaERrVEhSVGRVblpXUkFaL2hqVUV5K0Yy?= =?utf-8?B?ZTFuaXJtVnR6cnZGZ08wK3lGallhUlNEY1RBaXBPdFBSOTkzb2R4dHpOUmFs?= =?utf-8?B?TDR4QVF1SXRlQ0ZScHBFQlhkT25WOWlxU1Nzdis4NVpWN2ZxTzhaenczNzdn?= =?utf-8?B?ZFBIc2piU29ERUpWaExyWFhBNXhEQ2pHOWNrbTJRU1dYMnZkRkhMVFYvVFRY?= =?utf-8?B?emx3ajhqbXM3RG1VZHRiUzExWTJXd3FuMHFhUFM1eVVqRjI1WWJCYnZIWVI3?= =?utf-8?B?c1NHdEdZNXd3SGp2NFh4YUt6ZHFML29meTZKYUluY3g1d21SUmJUeDBRM2Ey?= =?utf-8?B?UDhSZkhEaFhYaHpsVHRGTVdNNDlRTHV4SUZ4OXlmTEtvR2w3MUNmcDV6eUx3?= =?utf-8?B?dlljWlFKbm0yUGxFNHNTY1lyQzg0WDlpa1Z6MzJVSjhVNXFneU13V1V6eDE2?= =?utf-8?B?dGE4OENKUVJhRU5qU0RGbzlPRnB1YlFOWjlsU3ozbTBTN2pzTVhENGVNLzVu?= =?utf-8?B?Vm43SDIyMWdtUGdpbnU5N3lCUlFtNkJwR3VUKzF3VzVVUnVhNjVDY05ZWkpN?= =?utf-8?B?dTBlbHdZNGF6c1RKTWFJRzZLS3hKdFAwallrSUZ1djBFV1h2RUpzQVlESy9I?= =?utf-8?B?MkErajVDRG1wTHE0V0hkQUhhTm4yeFdmUzliVWZEZEk3V1BVbzZCOEZ3d1dS?= =?utf-8?B?dzJJWjY5cllUTlM0RjdPQkR2azVnUmZwOHJMRWhKb3ZDNmNLSFlKZFhwVmRr?= =?utf-8?B?UWRJN3IwZ2hla1BNZlZlV01LWWl3aHVEUHQ2NzkydmpxTFpidGF4R2FTcHBJ?= =?utf-8?B?aHFiNm5jTVhWaXcxcGc4M1libThkNDJsVG41MkM4ckY0cFczSW9DNHpNSHl2?= =?utf-8?B?WkdWdWlsTzlIcGpvaEhiU2FYTWhyTHVKR1hUVFJhaXFpSjZkN3RUNnM2QkE4?= =?utf-8?B?R2J1V3UyZnh1TktpL2Q2elZndVhaa09CYWRnQ2d0RG9PYkl2RFd1OTV0VGhC?= =?utf-8?B?MlZLcXdZSGk3RWNTU3d5TEtPMFRESkprcVdQY2UrZUk2Y1RGWFczYkRMaHdW?= =?utf-8?B?aHIxZExBTnFLRjVqdVhSc2NDaUlDRjRhcm5TdXJja05hbjB3VjlyUEx2cElx?= =?utf-8?B?UFVZc1BYYkhJQzZnczBsejBqQTQ0YmY3ZlV0T3JKb3FOTXhGeGpOOTlxTkxr?= =?utf-8?B?Q1g4bG5HY1lDZkVOUFJPcFpRS1NDakNtWTF3VkV5TkIwcitHbEllNktaclRP?= =?utf-8?Q?vePlTumm+rl6wpIwnRM65fBS1?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jPLMHcIb0BUk6aUbGjWYBdwQSy0yeF599XWIxfyVpVdlfX5bKeVjthB8LZax/svqEfkA1osvtccEopJYoMy1fadYeyvW5qpt5VpAGAjeF0KttTip1prMJtiZ4tcXJxcQs0yr3QEWI06V/vN9eqCaEJy0+/D6PkA9dUuihWWPpGtYEV6zNq0Cehmp39EjqUCXmnuyE4ejrtRWFtUbNfm3TaS/JGYCheDnn8lujrLxFcrkCP1/dlcsqepGu/vEeK5JCYIisY2cNGbO/jTnngNEnkO/2AEOq0BO08SSaIhUJUnF4xJ2bCacYcFA1D+QlQacrssE2dibrMKcCFNJwHvhi7xOArCbZsF4KyjKqcgN2Uo1FXDqNP3M/4vloZ+8xYjXK4xk0LzWpERWLsTia+H/lM69uo6YnmWb75cXtk9YkFbQmQkMSH4fJP4PmSphSCeKIWdo3ek2u1D5azMheS4Zy467KH/nCqq0Rjx+fKUuA9X3E+7huHDA4sA0Y//0Axwwo5GAdenx61ryHp1Ba62KVyTWVeZfnQVARD/FdZX0AODAL3C007kbrNSKu1ir/RJR520ZRP9ADNI1YAL9Qmffc0cq4BPJy6VZcRfQu+23m2h105dUNbN1R65UxpEAmAq6y1ECx+cllm1AGFo4YrXmoEKPWR9QvSPAW27SJlt5A9ZB7b8s91tUPnhxw5EzbT/T8w0adNp51Zqs/ZCSE+ZIV3Pw2DlgO7GtAt+mAWr3ubYkaoCf9tNpXcvD6T7TMyJ4KUWUtxwSMRYW9+5jirjlgg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1428af61-c4b1-47b5-44a3-08db195739ca X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3160.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 06:44:22.7182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ateciH/A2tMSjBDGon3AiennN8xqHVYOzYImgcY4z0OCTUpp1jQZPEomyT/SSsYshBi559Lqr9Igd38GBucaig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7214 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-28_03,2023-02-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=781 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280051 X-Proofpoint-GUID: ZqEF0LjRKMiz9TtqgoA1FdZvjuOXq13z X-Proofpoint-ORIG-GUID: ZqEF0LjRKMiz9TtqgoA1FdZvjuOXq13z Hi, We encountered a vcpu-set issue on old xen, when I tried to confirm if xen upstream xen has the same issue I find neither my upstream build nor ubuntu 22.04 xen-hypervisor-4.16 work. I can add vcpus(8->16) to my guest but I can not reduce vcpu number: root@ubuntu2204:~/vm# xl list Name                                        ID   Mem VCPUs    State    Time(s) Domain-0                                     0 255424    32     r-----     991.9 testvm                                       1   4088    16     -b----      94.6 root@ubuntu2204:~/vm# xl vcpu-set testvm 8 root@ubuntu2204:~/vm# xl list Name                                        ID   Mem VCPUs    State    Time(s) Domain-0                                     0 255424    32     r-----     998.5 testvm                                       1   4088    16     -b----      97.3 After xl vcpu-set, xenstore showed online cpu number reduced to 8: /local/domain/1/vm = "/vm/aa109ea0-2fde-4712-81d8-75f73bd73715" /local/domain/1/name = "testvm" /local/domain/1/cpu = "" /local/domain/1/cpu/0 = "" /local/domain/1/cpu/0/availability = "online" /local/domain/1/cpu/1 = "" /local/domain/1/cpu/1/availability = "online" /local/domain/1/cpu/2 = "" /local/domain/1/cpu/2/availability = "online" /local/domain/1/cpu/3 = "" /local/domain/1/cpu/3/availability = "online" /local/domain/1/cpu/4 = "" /local/domain/1/cpu/4/availability = "online" /local/domain/1/cpu/5 = "" /local/domain/1/cpu/5/availability = "online" /local/domain/1/cpu/6 = "" /local/domain/1/cpu/6/availability = "online" /local/domain/1/cpu/7 = "" /local/domain/1/cpu/7/availability = "online" /local/domain/1/cpu/8 = "" /local/domain/1/cpu/8/availability = "offline" /local/domain/1/cpu/9 = "" /local/domain/1/cpu/9/availability = "offline" /local/domain/1/cpu/10 = "" /local/domain/1/cpu/10/availability = "offline" /local/domain/1/cpu/11 = "" /local/domain/1/cpu/11/availability = "offline" /local/domain/1/cpu/12 = "" /local/domain/1/cpu/12/availability = "offline" /local/domain/1/cpu/13 = "" /local/domain/1/cpu/13/availability = "offline" /local/domain/1/cpu/14 = "" /local/domain/1/cpu/14/availability = "offline" /local/domain/1/cpu/15 = "" /local/domain/1/cpu/15/availability = "offline" /local/domain/1/cpu/16 = "" /local/domain/1/cpu/16/availability = "offline" But guest did not received any offline events at all. >From source code my understand is for cpu online, libxl will send device_add to qemu to trigger vcpu add, for cpu offline, it still rely on xenstore, is this correct? anything can block cpu scale down? Appreciate for any suggestions! Thanks, Joe From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:10:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503015.775124 (Exim 4.92) (envelope-from ) id 1pWu7c-0003px-Ap; Tue, 28 Feb 2023 07:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503015.775124; Tue, 28 Feb 2023 07:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWu7c-0003pq-81; Tue, 28 Feb 2023 07:10:00 +0000 Received: by outflank-mailman (input) for mailman id 503015; Tue, 28 Feb 2023 07:09:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWu7b-0003pk-Cy for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:09:59 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7afbe88-b736-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:09:56 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id eg37so35661950edb.12 for ; Mon, 27 Feb 2023 23:09:56 -0800 (PST) Received: from [192.168.1.93] (adsl-6.109.242.139.tellas.gr. [109.242.139.6]) by smtp.gmail.com with ESMTPSA id n28-20020a50935c000000b004b025c19c6esm3988581eda.93.2023.02.27.23.09.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:09:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7afbe88-b736-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9kcdWo72CyQpKeC8omblHGRf5bJTr2FSqOiMv6HT/F0=; b=MclWZjuVwFqFhRe+0Sky/ZvnZ6DaibSYE1JrSEgXzxRN4jt2L8R+jR1q+E0EIOO7kp 0HYAA23o2F/ZsACy2o73JrTH5hPCJgrl73Flv89FDrDSsrN5i6Civg2pZMoXUo+ugFyT +wGtfTq5BngeASqaCDGG+rsHiIlC0YMLMPeEpRCgo8R7irOWaYrQV5gBmvSIdNqzejP5 z1BcwaSsPFW3g/Kt9ul3fSHGCC/lbuN/5e3xccEQ6+LN05/jATcPbVCBNmTKGBtCInXt g6hXdZuAODQ0SHrJetlg2WQH+Ut1Al3DhSQVoQOs8uw0okDoDJsfDVpvKirlMEmZQNVw 9H9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9kcdWo72CyQpKeC8omblHGRf5bJTr2FSqOiMv6HT/F0=; b=OIVLQuhgR6VbkX3ios2EBZ1noPHOSxzGmzKmD6rD5z5g0cYpl/DlsChj7u6YKbJ/T6 kveLh1DQXgfKSzZ4KAMYOdcUzAzsl/+LZVAJeJp0yYS1rzSXgBAum+qykk1gOT40zBKD wqNtUAGku96heOGrGCKnkoeJwi18W/rygLeeJDpYjfYbNlRQrzV9FnErshoLCQ6bTDHY jn2pQXVBhaMLMtOLo0jHU6VTV6yghINTUoJGN8eiMVu5rAVuKXQqVdPvRwDNlEV0uMrm DobLW79I2JDonuF7ALNFA044addYHyBRUTYdgE6Rs2N8ZaPRvwN+wYsUBo1AZLUSBGU1 ibRQ== X-Gm-Message-State: AO0yUKWFfSG04UgKo9gBIlVeRWVyaSHOPQJSSjBtuw0ZQXIjCt/RqZMF cGOmTUiTP+da0ooFgVu8r5I= X-Google-Smtp-Source: AK7set+6yPkM+PnAukftDkoPAAsS684UhwJnuYYf02TmwnHXUguVhFaXEZYE3uTM/XKyjP4JpsfuhQ== X-Received: by 2002:aa7:c90c:0:b0:4aa:b63f:a0e with SMTP id b12-20020aa7c90c000000b004aab63f0a0emr2176173edt.17.1677568195624; Mon, 27 Feb 2023 23:09:55 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 09:09:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> <18b9b99e-1d93-73d8-f9b8-873f44287c5c@citrix.com> <60252bef-c732-b061-8ec0-c4022eb41255@suse.com> From: Xenia Ragiadakou In-Reply-To: <60252bef-c732-b061-8ec0-c4022eb41255@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/27/23 14:17, Jan Beulich wrote: > On 27.02.2023 13:06, Andrew Cooper wrote: >> On 27/02/2023 11:33 am, Jan Beulich wrote: >>> On 27.02.2023 12:15, Andrew Cooper wrote: >>>> On 27/02/2023 10:46 am, Jan Beulich wrote: >>>>> On 24.02.2023 22:33, Andrew Cooper wrote: >>>>>> But I think we want to change tact slightly at this point, so I'm not >>>>>> going to do any further tweaking on commit. >>>>>> >>>>>> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >>>>>> updating the non-SVM include paths as we go.  Probably best to >>>>>> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >>>>>> only got one tree-wide cleanup of the external include paths. >>>>>> >>>>>> Quick tangent - I will be making all of that cpu_has_svm_* >>>>>> infrastructure disappear by moving it into the normal CPUID handling, >>>>>> but I've not had sufficient time to finish that yet. >>>>>> >>>>>> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >>>>>> disappear (after my decoupling patch has gone in). >>>>> Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? >>>>> The latter doesn't use anything from the former, does it? >>>> It's about what else uses them. >>>> >>>> hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always >>>> included in tandem. >>> Well, yes, that's how things are today. But can you explain to me why >>> hvm_vcpu has to know nestedsvm's layout? >> >> Because it's part of the same single memory allocation. > > Which keeps growing, and sooner or later we'll need to find something > again to split off, so we won't exceed a page in size. The nested > structures would, to me, look to be prime candidates for such. > >>> If the field was a pointer, >>> a forward decl of that struct would suffice, and any entity in the >>> rest of Xen not caring about struct nestedsvm would no longer see it >>> (and hence also no longer be re-built if a change is made there). >> >> Yes, you could hide it as a pointer.  The cost of doing so is an >> unnecessary extra memory allocation, and extra pointer handling on >> create/destroy, not to mention extra pointer chasing in memory during use. >> >>>> nestedsvm is literally just one struct now, and no subsystem ought to >>>> have multiple headers when one will do. >>> When one will do, yes. Removing build dependencies is a good reason >>> to have separate headers, though. >> >> Its not the only only option, and an #ifdef CONFIG_NESTED_VIRT inside >> the struct would be an equally acceptable way of doing this which >> wouldn't involve making an extra memory allocation. > > That would make it a build-time decision, but then on NESTED_VIRT=y > hypervisors there might still be guests not meaning to use that > functionality, and for quite some time that may actually be a majority. > >> Everything you've posed here is way out of scope for Xenia's series. > > There was never an intention to extend the scope of the work she's doing. > Instead I was trying to limit the scope by suggesting to avoid a piece > of rework which later may want undoing. Can I suggest to leave hvm/svm/svm.h and hvm/svm/nestedsvm.h separate for now? > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:12:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:12:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503020.775133 (Exim 4.92) (envelope-from ) id 1pWu9N-0005EE-Mn; Tue, 28 Feb 2023 07:11:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503020.775133; Tue, 28 Feb 2023 07:11:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWu9N-0005E7-JS; Tue, 28 Feb 2023 07:11:49 +0000 Received: by outflank-mailman (input) for mailman id 503020; Tue, 28 Feb 2023 07:11:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWu9M-0005E1-Fq for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:11:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1a::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28fb3299-b737-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:11:46 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8100.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 07:11:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 07:11:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28fb3299-b737-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkzkNtcYAez02vzsJS5gMOr/VxLTwh+PzWSn+G3m7fGeZ/ipCXT4lihd7TcWzmkZf3Hx/5uAgsXyFC5d8R3brAgz4Ku4c1Q4Lgq3aXGOvJeHDXEGIWt3yyoVtal+yhZfCYAY1VWQeGCCvQXXeReDFMTGqe8bigsMjKuexETPupztFcNmGOVwf5Idx82wD1mOzQqxJTDYz8YiPeLQTrdgrsv2E84wwjUZR1Vkf0fjW+O4OYWZpyB4blwr3PGCLF/MCzZ03Ik5L+imF34Aunqn738px1B3PKjLTLcjM647ibLWFnR5CfSVK58Vjy62H6pxOd7ejPf2soWYuYL9pZZKqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=irgS3X6svl5E0MP5sT240RbMxpC8oY26rhK0rgNmK1w=; b=DYuL4mqG8iFQfJJ+p7W5Sq78ir+FShHfA21JUbuaDM61CNmS0n0fr/QAkXKoH0Wbf8xW+9KvafOvNkn/xm+5ihG+pAoflAL0/wojcWBXeFqIBPPLYpoFWQE/oxiQ7kwM+VFYAvpP6X+a8UxnCU4DNBxUKz7SBdFMdmpAzVPvIMFhG9vw6tWKy7kCVQOftK4PiDYvmLuszMVX3B6fJQX9XeMafhBkmafgtnC762pJqVbJlOV6AIjzgM6VVj0QhK+QYTPJJ+Ut56NqbCyyTbqTQ1JWNnkcO9MIVM5ZCt1rYqqVoKrvKg+cji2mcigmbsjMlegXgBuSaXDYaCLkKQn4uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=irgS3X6svl5E0MP5sT240RbMxpC8oY26rhK0rgNmK1w=; b=FEVa1MY9x1C/feO8EgTAftX93XO5GErb42LqJg36h4PMJxB7I1uz4b28WL6Vfy+3TLxczbxWL+efRIgfJ2njMt3H3bAPVRnbfCTS1QfRvrHuD9nhU5aOd1DhYT1PXAY2GGU6bFSJ26zyPeZJ8EQV5VXhKm0o2k0ICLLvAeyp2e2ldYKNXeN+7HZIIpIrxIEXJNZF4/EV7T344OZMiKTw6J6GtTbKC830/SIbaO7sOht39mHGkBSG7PKiIykS1GA1j7SZDlOw1hThAyER2jL64xZWkAfKLZJ5bEQboY1RToRJ6xhxvAL++gsZTBF4C1+Q7axgYizNz1w6LOvkyCtClA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <491961e2-f9a3-2bd5-e757-a094577ed068@suse.com> Date: Tue, 28 Feb 2023 08:11:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 00/14] x86/hvm: {svm,vmx} {c,h} cleanup Content-Language: en-US To: Xenia Ragiadakou Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org, Andrew Cooper References: <20230224185010.3692754-1-burzalodowa@gmail.com> <8745c599-bf9f-1eec-739f-3d42920dc546@gmail.com> <989903f7-4ea0-a1d8-923f-efb84c70ba21@citrix.com> <2fec6c39-f73c-719b-7bc9-02e1ec3f195b@citrix.com> <5e623eaa-ce32-e3ac-2089-68bf8125b5db@suse.com> <18b9b99e-1d93-73d8-f9b8-873f44287c5c@citrix.com> <60252bef-c732-b061-8ec0-c4022eb41255@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0202.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8100:EE_ X-MS-Office365-Filtering-Correlation-Id: 77f569d1-1839-4910-596a-08db195b0bcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YegcFONXKq94VS/cOpATMHOcR70XATY2m6lN7qj7yrun4vTYcSgvD1NYDWojA/rfb5eI2KPPVexEYHnel1Hi/UxumG3fm50Pqz5oT3QlzsIDpfgIuXHXaq3MXR9G3kH2U/9m+8EQ2F7hMHGAhYV683a5zzc+BDSEC0wu7v3F/oSfeD1YvMqtTSR6J9VhJnusxjRFf9utF4WOAfAHlUeqb0G6JYIpe58MO3LuEJaGc0nyrG0YkXvbWQ66M3K0Vw3x2LVAAam0sCfv1L7p2OhQ3rdexUfY+Crj/CzYm2x90KKlXXtfwIq2ysoaH5l3GYx2V5nJvvhPhp0X3Edol8GmEGWiSXDFX5r9D0kTolWtdq4c5wQpnEoMiBbjMpncssxz8LHnU17eTdQixQi5iJk5vMc27xIwecrrZOj45qYDqKSr/rHoOIpp3YQURKRYAEN5aT1i38cc6zVK1sFYJW0GKizeiEDuySA1nbRKu/x6eP2TFHPrfXVScH+sP5cz5nh1nI6P3p9vjbVi1JcyCUjX6eZ9cL/zXyK7bouYu7MohR75y01hF4n+QewdjxYKhF+s1s2oCV03BDPZVzmR49YZc6BJPaVVMRSQwklYkWKvtTQZu/Osd20G27BIAC97Rd28cZwRRL0oHIM55N2zhFl47u4l/JA4A8WBLhAoOVOaxMYHvO8E3UceqSw36dvvi4hIXD7sC62YMY1Pp4Adb1Sn4tLYWXfIfmQcw0Rn/1XVs9c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199018)(31686004)(86362001)(36756003)(41300700001)(66556008)(66476007)(66946007)(5660300002)(8936002)(31696002)(6916009)(4326008)(8676002)(2906002)(38100700002)(6486002)(478600001)(54906003)(316002)(83380400001)(26005)(2616005)(186003)(53546011)(6506007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODRKTy9yaFZobS9YeklQVXZ0d2NsajZVdU9qUHhQZXpzc2FKM1R2bzJxUDlM?= =?utf-8?B?d0NETEFaQ1BORjcyN0l1M2V1aGJUS3pmZ2FwRGlFNDFpSnFNeXljK3RaTU5v?= =?utf-8?B?VlQvaE5qdWh3NWxCN1U5R3F3RTYvZEJKbXphdGw1cjhNQWl4ZXllWStFTU5T?= =?utf-8?B?b0hzUm1OOUJJKzhhV0FQeFpYaFEvcld6MmxNeXVTMUNPczFZTE9ic3BIcjky?= =?utf-8?B?cW14bW84Uy9yVm43Z2lDUVQzeVI1TDlZWHpqL0xURnh6SFZkWTBPN0V1TzFT?= =?utf-8?B?RTJlWC9KN1haTVd2SXRoeDBEdHp0TVV0Yjgxb0g2UTVZVFJST0JXK0QyQWVZ?= =?utf-8?B?U3llVnFJN2ZIS0pMamJGaHNCaVI5QnVlcWJMWU9JOFZMTWpYUlFDRk1Fb1VK?= =?utf-8?B?KzV1VXNlM0lpU21MZlBlcFA1YU5XaU9KK2pFdzZCUlBKekJ1TWdnUzRMTkQ3?= =?utf-8?B?L25zQVNmV0lnTzUrUllMMVg5LzdvbG9oakR5ME1ldEZKN1hseFloWWZFaGo1?= =?utf-8?B?UzcwRmUrcmtJcEtvYlQydERhYlFPS0ZNdis4RmxLTUU0RlQ4cUZWRHRTdGp4?= =?utf-8?B?a1IzVU02SklQdDU4amNZM1g0ZG10S2ZHd3JXZlM5d1dDVG53OGlMVm9ZdlNq?= =?utf-8?B?VnEyeU5EUmJPdmJtd0dZU1lWL21VNUthTWpJM1JaSHI1Q0tTSW1uWjNBRjh5?= =?utf-8?B?Y2IweVZiNXBPY0xKS3dhM0JGOWhRbTcrekpnMzZ3SEkrS0hHcGVtMmJQU05m?= =?utf-8?B?bjE4VHZLUTF2V3JtOTU3bWdaeVgwUHR5ckpncWlnamRLamx6Tk51aXg3cnJq?= =?utf-8?B?Qm5peEYvZitKd1BwMlNBeE9HWWthdWJmQWN6Rk1HTFErOG4vYWFsK0h6V1hQ?= =?utf-8?B?a3lZRVJjNGQxNGMwbnNCOStJbzJ2RW83R043WTdFVEIyVE1RWVhTU2lyMjFW?= =?utf-8?B?QWFWRFY1VkJFbUx2dWdnSVlTVGg1RWhpdzROVXMyQmpTNTg3TTM3bmZhQW9X?= =?utf-8?B?TlJaOUV1YkdIdGhmMVdydGRFeS9RaXpBdWZIRnB0T20wY1BqRk94cW9oWmRC?= =?utf-8?B?cHFiREdMTWI5eVg5Q2NhU2FqT1VCS1BGZVVCRlcvS3pRNjhON0N2UlRUZjh5?= =?utf-8?B?TFFLUVhveTRUeU5pbEt4NkNMVm1CVkhRNGpDL3NVNFlqdmhqL3VlTklQZEVw?= =?utf-8?B?Q3Nwc3UzTFRSak9kZ1NjR3lkU3hWSG9TRm11cGh2VUc5MWpQKzBGSlNaNlNO?= =?utf-8?B?N2dEVW5OWDZrOW9yeEZhTENEbEthSUUxL1ZiK0pGcE40NXlFeHJUQ2w3dWxr?= =?utf-8?B?bTUvL3ZkQi9EU0VFSEo1SlE3eWRibk56RW9sZU5VbFJPMm5RYmdqYS9VOStm?= =?utf-8?B?QSthT1U4ejNJbUFpM2ZvQ2J1SDVNNTNSM2tFV2kydWRyNEw4OTVBU2ZlZ1FF?= =?utf-8?B?KytkZTJiaUxKYlFNV3BxdGZwZVZ6T21QRVRuYVl1SDVOalloWUlPSlhRbXUw?= =?utf-8?B?aG5GRDNETitWM0R3ODRhYy9TSzZob2gxK3g1Y2ROYTN5MGtYR1VXYjNIeVkr?= =?utf-8?B?eGtIM3lINDJpN0c4R0ZTdWFnd21DZ283OWw1STRzR2IrT0JqbEF5MXNlM05V?= =?utf-8?B?SzI4eFNMNSt4ZGk1eDdyU3EvQjhOeFZINDBDMU94SElOaytab3pjcjhrNlJY?= =?utf-8?B?ZnN0OCtRVDYrZVE3R1VOWCtPWUt3VEdCeXBvMzBBbXJYOFF0YXl6VlRWYVN5?= =?utf-8?B?UHdxK0dPaFplQmIwcWxhQysweU9mOUFCdm1TVlJzdXpGWFVDbTZBUkJ0T3F3?= =?utf-8?B?RFRodjJIeStYMkFHT2VENmVyYU05UUdIMWlaUndXWUw2UWlveUpZQUhBeEhS?= =?utf-8?B?TXRSTW5LNWpqOE5DbmlKMHhNdzZXQ1p5Ky9aSXlPT1lmMnJBY2hDMTZBRXhH?= =?utf-8?B?WTByK3B5WkdJdC9PTTJuTFp2VCtxemtvZWVRSXFaOTdoTDZabXcxdmNucjIw?= =?utf-8?B?aWhKK3ErRzFKUDZlU0FxUXpmaHRDcTFoQVAvSmdITmR2RER2N2t5UHRzd1dL?= =?utf-8?B?WFpDT0N0c09sMktwWUNvMVdYMTVEc2ZmMkRRSkJzV1dZQk42SEN1S05sOHRF?= =?utf-8?Q?CQI1qU8v6GvMXE8C9JPKo4xxj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77f569d1-1839-4910-596a-08db195b0bcf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 07:11:43.7350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f51f91Iyp5lCmG7l8Hrc2/LLlnu86MIlpuII97azZcB0M6W8UOT6CEdOwQ+EPu/auXk4EJw4EZk+B5wEjbVYWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8100 On 28.02.2023 08:09, Xenia Ragiadakou wrote: > > On 2/27/23 14:17, Jan Beulich wrote: >> On 27.02.2023 13:06, Andrew Cooper wrote: >>> On 27/02/2023 11:33 am, Jan Beulich wrote: >>>> On 27.02.2023 12:15, Andrew Cooper wrote: >>>>> On 27/02/2023 10:46 am, Jan Beulich wrote: >>>>>> On 24.02.2023 22:33, Andrew Cooper wrote: >>>>>>> But I think we want to change tact slightly at this point, so I'm not >>>>>>> going to do any further tweaking on commit. >>>>>>> >>>>>>> Next, I think we want to rename asm/hvm/svm/svm.h to asm/hvm/svm.h, >>>>>>> updating the non-SVM include paths as we go.  Probably best to >>>>>>> chain-include the other svm/hvm/svm/*.h headers temporarily, so we've >>>>>>> only got one tree-wide cleanup of the external include paths. >>>>>>> >>>>>>> Quick tangent - I will be making all of that cpu_has_svm_* >>>>>>> infrastructure disappear by moving it into the normal CPUID handling, >>>>>>> but I've not had sufficient time to finish that yet. >>>>>>> >>>>>>> Next, hvm/svm/nestedsvm.h can merge straight into hvm/svm.h, and >>>>>>> disappear (after my decoupling patch has gone in). >>>>>> Why would you want to fold hvm/svm/nestedsvm.h into hvm/svm/svm.h? >>>>>> The latter doesn't use anything from the former, does it? >>>>> It's about what else uses them. >>>>> >>>>> hvm_vcpu needs both svm_vcpu and nestedsvm, so both headers are always >>>>> included in tandem. >>>> Well, yes, that's how things are today. But can you explain to me why >>>> hvm_vcpu has to know nestedsvm's layout? >>> >>> Because it's part of the same single memory allocation. >> >> Which keeps growing, and sooner or later we'll need to find something >> again to split off, so we won't exceed a page in size. The nested >> structures would, to me, look to be prime candidates for such. >> >>>> If the field was a pointer, >>>> a forward decl of that struct would suffice, and any entity in the >>>> rest of Xen not caring about struct nestedsvm would no longer see it >>>> (and hence also no longer be re-built if a change is made there). >>> >>> Yes, you could hide it as a pointer.  The cost of doing so is an >>> unnecessary extra memory allocation, and extra pointer handling on >>> create/destroy, not to mention extra pointer chasing in memory during use. >>> >>>>> nestedsvm is literally just one struct now, and no subsystem ought to >>>>> have multiple headers when one will do. >>>> When one will do, yes. Removing build dependencies is a good reason >>>> to have separate headers, though. >>> >>> Its not the only only option, and an #ifdef CONFIG_NESTED_VIRT inside >>> the struct would be an equally acceptable way of doing this which >>> wouldn't involve making an extra memory allocation. >> >> That would make it a build-time decision, but then on NESTED_VIRT=y >> hypervisors there might still be guests not meaning to use that >> functionality, and for quite some time that may actually be a majority. >> >>> Everything you've posed here is way out of scope for Xenia's series. >> >> There was never an intention to extend the scope of the work she's doing. >> Instead I was trying to limit the scope by suggesting to avoid a piece >> of rework which later may want undoing. > > Can I suggest to leave hvm/svm/svm.h and hvm/svm/nestedsvm.h separate > for now? As per before - that's my preference. It'll be Andrew who you would need to convince, as he did suggest the folding. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:16:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503026.775144 (Exim 4.92) (envelope-from ) id 1pWuE6-0005ul-BO; Tue, 28 Feb 2023 07:16:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503026.775144; Tue, 28 Feb 2023 07:16:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuE6-0005ue-83; Tue, 28 Feb 2023 07:16:42 +0000 Received: by outflank-mailman (input) for mailman id 503026; Tue, 28 Feb 2023 07:16:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuE5-0005uT-1q for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:16:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0604.outbound.protection.outlook.com [2a01:111:f400:fe0e::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d72c2d14-b737-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:16:39 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9625.eurprd04.prod.outlook.com (2603:10a6:10:308::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Tue, 28 Feb 2023 07:16:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 07:16:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d72c2d14-b737-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ju6x2amSfSt4WY0/co2en5XjuqiId7SK7Xt3RElDTfsizhYuxKE+yISRKNV/nmD0poC5RkxoD+8Xc+s+rmBxLRL9D8sZoCO1WTVx0CnymAkgsxmVrp3GOOPQgm1UGdIgPjdU8olPVB/eDeZ5AsL+2KKymG9fUanpSKbd67NYLhj/E47fqV6aslINXnvWiWG7Jgo5oUdd0V/vUkRuy2SwhRL0hcUC9k0HN9s62uuNwzoTdLw4Htb6o9ltmrWKz28pD+Td66QfMdJ3wGMlxZCsF3/SVPfPdPNIe4yCZPs9bAhipZd0ECfIFEmW4jlb8/7I3x7OaGyonz1uIHAM3XkfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mu2CFQ4HgF3EX88DAtfBNvYiNId3X68cby2T5ixRBnA=; b=kbVyCBslbdXGpUbGwjVtfvfal9tDvN/BN9O1XgEmBC15bzrikuCGdBVaESJ3WkYVrRU91itJXLAI8I47NwIiof5v4KB4BK0VnktkeDkdma/qy2/iGnY6KELWTkZvx619kqCUM2g3oa4UNAidFdjK7V4cZyoY3aPFOSb1kW82JDKrXFRy3FDqFeYBS8D6l/m8vMserCXTjqIyUoakqQgM8wbAF5vYjgRkyqZPsCegJszFdoFrvBrV+d8+ewOK2bVB63fvuEf/J8y7PMIOdPBFQl/4/WB/waUvba/xwKPYByE9pPdB8RRCQP3ROPYl1kS0LMHIdvkNagAiAb95gFTBwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mu2CFQ4HgF3EX88DAtfBNvYiNId3X68cby2T5ixRBnA=; b=ciLibconxNCll342GD5Arkm3VPTogeLwc9qWBIjixoa02kqYFFb0HsQRHqj+ed2wKvDsXnUy768yeInNoaOwAtClcKwZ4KCrHn7nl8wRZD7zp40plx/8VrgffkfpPCCpHY/ZDO6UADyTf3IQDdvwLnS24ZtxlJ2eWsl1UungH5zmxLUQkF9AuWNdXkLd2i658LWmnQ5jDLYEViZELpFiyVPUjW3IIbe8qzi3Eja56Kik361Qc4rJr+9PBmAb8HBAvYSQHYZTIEu5dlOx30nKMnAcoPPbY9yJRTVFKEkhS1UO33clGZ+jgC/u6pEzcHlGN7Lk/JGqGlb7n9rK4BY4rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 08:16:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [ANNOUNCE] Call for agenda items for 3 March Community Call @ 1600 UTC Content-Language: en-US To: George Dunlap References: Cc: Xen-devel From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9625:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ce393ce-b552-4526-7fb4-08db195bba75 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MoGT+o8vsvOrRXWhnIgpa+exhaqndBPzP87kJJrCEMkBzX3n50We9whsWTME9ucYu0DNGzM+kEZpwAsqZL3KzIPx9LVSwLu5mf3vt+WiAG6vn+3RU6btRsaLH4SZJsKK6dLMb+Tq8usK4NJJHpCQKEGTvmN+MeCU+kh06KLsTbh1oKHnblZQSX69/emA0mGjxuUtmv+3tGFrhcWrAtHRqZET0NZYOqL42rDtUrbWmf2KehFV42yn/zLgyiKZqBMApwgsOThoVlcg58NTgoDw5fQ0v27qo1v6usbOhir4ycutjOZcy+9MzKLj+asqdeHOhqhd+Rf5cokCJQkpO3ybJWKKSj6Ivc/ZORNe7G6K95XH78kP9HLOMbykjJqAA5DBGzlJQCzOZaPS9esxZY5vGYFGlt2aekwGFpl3qmFEmEFzKVIJsZ4Hu7kZB1wcBkfntWulFx3trgGJBOwRM7/MyqzC+29vvLnK4RhTZsrhUZ0w10duI+zKGJadtoSptGQL5dJ9QZLLOjJ7266KUM2MmF0QI6l86s72OppDNkARIT7mrmJUTNBBimfw0dLdU73Ww4lxmqyeOATdIYZ56tfhYzqUoCXhX7e5UhFJLX/cLHyz4vBaUgbr2pJTLdVZgHFLq2R5MFsMR+r8dz9s2N0UW/TiLUQ5HK+RM6Ajntf/EzvHE8cWMHfKoAbmO/M5ZV5DQkL0prszpY8TOxA1WVeyLe81GykSxS4z/PVww7/G6lM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(346002)(396003)(376002)(366004)(39860400002)(451199018)(36756003)(2906002)(86362001)(31696002)(4744005)(38100700002)(83380400001)(2616005)(6486002)(316002)(478600001)(53546011)(6512007)(26005)(6506007)(186003)(6916009)(8676002)(4326008)(8936002)(5660300002)(41300700001)(66476007)(66556008)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWtUeUdibW1GbXRyZElkUkFoNHEvNFR5S0JxVVpHaGhEdWZpVEw5cmU0cTBS?= =?utf-8?B?dUkrT2tYQ0Y3bWNmcWlNMGVYekNLTTU0dEt3UWZLVGhqRm1xNEI0WlR0dkE5?= =?utf-8?B?dURkZFhmNG9mdFc0VVEzQVNmK3pFanJDbGpVNTkyTHdGMVZqZncxbndTWmpp?= =?utf-8?B?M1BoNEkwam9ibWJFbXA5WEowZHFjdUo2b1JtbnYxNi84T2R2dmtjalNIZmQ5?= =?utf-8?B?MTlvQWh6MUxlOW5xcTZMbmtLaUI0TTlnQ1dkOUptUk9CVE5QQmRIQjNnckFS?= =?utf-8?B?WlNWdVRUSTV5RzhyVEVWYVg0QW45RmRENWZ0amhtLzl6alBLLy9BMkRsWW4v?= =?utf-8?B?WElacW42cW1GSlRtbkNRUDk4ZVY1RTVqampnSkJZcXRKeVozc3VJSTJYcVA5?= =?utf-8?B?SkExSGQ2REc1c2VYOUdEYjNZRWtFdTRVdVIxWkowd2hveFFPa0lXZU5haGFH?= =?utf-8?B?MlM1NmZSQXFwY0Z3YWI4VmIya2MvVG0zazdtcDdVSGpkMVpjZDd2UWVQc0hC?= =?utf-8?B?emtTVUQvZ3J5Uk1yZDdzMjA5akNYVHhQamNrVDY2Z3pPRzh2alFpeWxyb0pM?= =?utf-8?B?ZFZsa3VNeFI3aUg4eUhCSThOY0p4SmYrWjBuRXNmYTlzRXE1R3cxMDRMdGxM?= =?utf-8?B?TkNEVXMxbEc0RWxGVlN0bnloY3piVEFFME5nQUN4cDg5Z2dLYVhsL3FVNitk?= =?utf-8?B?U09VWFQzbk1PWjBhNFVmZWpwaUcxWUJiQ3RMNFFLODFyZEU4NzhtaWNFTnRr?= =?utf-8?B?TGZibTRXL1hucDNUTFdJbTlobmxnM25rd2VXdW1ESTRIcmh3cXRUbnhvUnNO?= =?utf-8?B?cGVoZXZ5MjNkVnFkNy9hUVhVL09VU1lPNDRzQnZLVDYyZDV3Yjd3TkhQR3lL?= =?utf-8?B?R0dsRHJscEFsL2ZsdGsrd2daRzRYZjZMTjBtUFFyMHo0V2dUQWl5Y0lQelQ4?= =?utf-8?B?a1QyWFpHdzk0dHFHNEtoNHhpSlJ6dENPbDB6Z1ludkhTenE1RUF0NlJPRlB3?= =?utf-8?B?YU1TVWhJYmw2UWsxVStUZWFrSzlKNkh6T2lBcFFjSCtvTTJLb1hMdExSZGlj?= =?utf-8?B?RFRBbEQ1RGoyRkowYW1JNkpyYVZEdnFCOGtQSC8veGgra1VLN0RRMUROQTZX?= =?utf-8?B?cFJqVzNvcDMzR1lDYnE2VUhZVjdmV0dTM05heElXREsyOEZuUVhhOWpKM241?= =?utf-8?B?L2Q5cmhRUW5ra0haOVFXZzhRWmsxbXFqa25meXZ6SXNwYW9IM3FvUEE4UE84?= =?utf-8?B?WGYybUtzUkJqN2xSNkV4UXlNSW0rM1BsQW83Szkxa05QKzA0ZlpjcGh5S3JC?= =?utf-8?B?ZTh4bWtXOHREMVBBdTl5U2x3UldXeTE2eWM4ckFLdkZMVlMxUE44WG51KzBr?= =?utf-8?B?RFlTOXdvT3lqNlBtdDY3STRsZkdRQjlhZXJzWC9LdmxuRnRlcmNqM3N3eVM1?= =?utf-8?B?aDdib1RwaEpzeTZtRG9BQW4wQ3J4MlZlVTFoSC9DSHhJMjNkMys3bGNRR3Z2?= =?utf-8?B?UW5LR3hVQWh3c1ppaTRlaVdVVXZyYm5NbWdRcVZnMGlnUTY2K2R2OElyZ0pB?= =?utf-8?B?K2h5ZWZCTEVsVXlLT3pMUHp6azVTcGZ4UnY1akpRdUp1U3kxanZkU2E0akQ0?= =?utf-8?B?emw4NWQrbmtxS3dpYzhyNWcxYXVzY3lFRkptV3ZxUytBTW1zeUNkYzl2OFp6?= =?utf-8?B?c0FUK05wVmE5WXFWTWdVUFFhMU9TL3dTQm1QYk5SOGw0TER1QTJjbTh2amc3?= =?utf-8?B?cHlnWThFYXBIT2hTV3dIQ0I3UEtYNXg5b3N6OTJINytUMXFOcmNsV3plRGFZ?= =?utf-8?B?RGxPTEhpWkVDUlBuYXNJRzNCOGdaS1lpcU9SODZlZW5CUDRQMEFTVUREQ29z?= =?utf-8?B?dXpSakw3WnBuU0JpLzB0MzROSGJxbGR1M0dhd2NHak5hbVd1NFd1TVk3Rk11?= =?utf-8?B?UmF0Zk1HbzhGaCtXYVdiSUlWVG1BQnEzVklqZVBrU2s2ZUJhdGFZZlFZY1RE?= =?utf-8?B?NU5TU3FsWVk2M0NTNkZCa1RDbHlrUW9oTy9DRTR4aExDSm0ydXBUd3VPY3hK?= =?utf-8?B?N0xSRHNPVGVoMUMraXdYb1pxSFJsL2JUMjJQemZLRGttSEtIa0NoMXhGcERM?= =?utf-8?Q?NXFpxo1hyRKYh4PduRYgwc0t3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ce393ce-b552-4526-7fb4-08db195bba75 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 07:16:36.5756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FRs9ESKgut9xxv9h52SuWZJemHxjVgNGfMUN8KtH0OdqIkl9KIhprg5FGaXcfEBDQn6eFXAl9ZMqxRfEBq+EAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9625 On 27.02.2023 22:41, George Dunlap wrote: > Note the following administrative conventions for the call: > * Unless, agreed in the previous meeting otherwise, the call is on the 1st > Thursday of each month at 1600 British Time (either GMT or BST) Since nothing else was said, I suppose the title is off by one and it's Thursday March 2nd? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:37:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:37:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503035.775154 (Exim 4.92) (envelope-from ) id 1pWuXU-0000dn-Vi; Tue, 28 Feb 2023 07:36:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503035.775154; Tue, 28 Feb 2023 07:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuXU-0000dg-Rs; Tue, 28 Feb 2023 07:36:44 +0000 Received: by outflank-mailman (input) for mailman id 503035; Tue, 28 Feb 2023 07:36:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuXT-0000dH-LP for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:36:43 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a56fe6fa-b73a-11ed-9692-2f268f93b82a; Tue, 28 Feb 2023 08:36:43 +0100 (CET) Received: by mail-ed1-x535.google.com with SMTP id ee7so36144953edb.2 for ; Mon, 27 Feb 2023 23:36:42 -0800 (PST) Received: from [192.168.1.93] ([188.73.239.246]) by smtp.gmail.com with ESMTPSA id mr23-20020a170907829700b008e4584e7235sm4159032ejc.47.2023.02.27.23.36.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:36:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a56fe6fa-b73a-11ed-9692-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k57jYmzHS9xrNAcC+LLAL6tesNF0rYli3x3ytjqn3A8=; b=PtbVrLLvAGFbGG8X3RUsHExwXCbtcqwFHTS4BYLGaBxgpS5kQARza5aPsqw5wKw8pd G45yCd0dx8a1pSrDZO7POe2Fmb2WdYaB9shCw07ViNZulki3qeTLNyIz+kItTtSfcSU4 u7UNdxsE70DFJnQEycXiqc+pCxWXTtfES8/4+qs4bg1KYh4YPeKVGxFh8/utekoMQmHb 97XmvWAGqF1ZO+9ikOs0K9yZA0YR8cZy7Hcae4Hd5VxL0EBn053T55VpMYxebt/xtiCJ CIS4dvlNcXnU5pkJbgkHA7laF9C+fKnGph0HMZMaWY4mhaWl8kjFR3cQtm4ouLy9hjCu JEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k57jYmzHS9xrNAcC+LLAL6tesNF0rYli3x3ytjqn3A8=; b=uMTPEfVjn0JER7xmdrf4LSu0a2ONEYc7QqfbjLjPk/Hq6Se3eUUTrw/SYPmSB79wCe t4gb8IeOggNuLuxLuC+Ri3IAc2/7T4wlUd5ST4kWTQ5mw+YkX0v2BiH6fB41Pfr5Rh0c SPx5SjGo0VquACLSuW36nTaccp7VovpSHhfFonOpmXfQLl9L3hTfRZxxARCqPoCOl4f1 6Uidytd0D/PiuLHyzjEWCoBDPL9SzfyhOYJLY+gz1t1WRtJF5M9roDbui61ZCJfp5cw7 CqAKb+b2ItLBpPIx3BGv3zmahqm63hUZWjPON4YHxNJtJNhV9JyR2Berkbj0qxnRmxOX idZA== X-Gm-Message-State: AO0yUKVrtINmJGP1UVbZ7rpyuqq95AnFc3fgdiggwqYeDMFRQrm4ikvN 25R47HBLaN8jyg5FbrCKUGpQwlNfftM= X-Google-Smtp-Source: AK7set84DJVOUlEQml6OWW3Pq7/CIDIR6glGhXOPn/9bwwDV6a1sqqMPUm+BVzhub1Ol8Yk0kEOHaw== X-Received: by 2002:a17:906:c206:b0:877:a3c4:807b with SMTP id d6-20020a170906c20600b00877a3c4807bmr1362570ejz.68.1677569802188; Mon, 27 Feb 2023 23:36:42 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 09:36:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/23 17:25, Jan Beulich wrote: > On 24.02.2023 19:50, Xenia Ragiadakou wrote: >> --- /dev/null >> +++ b/xen/arch/x86/hvm/vmx/pi.h >> @@ -0,0 +1,78 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * pi.h: VMX Posted Interrupts >> + * >> + * Copyright (c) 2004, Intel Corporation. >> + */ >> + >> +#ifndef __X86_HVM_VMX_PI_PRIV_H__ >> +#define __X86_HVM_VMX_PI_PRIV_H__ > > I can see that you need something to disambiguate the two vmx.h. But > here you don't need the PRIV infix, do you? Even in the private vmx.h > I'd like to ask to consider e.g. __VMX_H__ as the guard (and then > __PI_H__ here), rather than one which doesn't really match the > filename. I do agree that adding _PRIV_ is off target. For the purpose of disambiguation, the header guards need to conform to a well specified pattern guaranteed not to be used for anything else. For that reason I would suggest the guard to include the path, not just the file name. In any case, the pattern that is used to generate the header guards should be mentioned in the coding style doc. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:40:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:40:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503040.775164 (Exim 4.92) (envelope-from ) id 1pWuaf-0001YM-DP; Tue, 28 Feb 2023 07:40:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503040.775164; Tue, 28 Feb 2023 07:40:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuaf-0001YF-AW; Tue, 28 Feb 2023 07:40:01 +0000 Received: by outflank-mailman (input) for mailman id 503040; Tue, 28 Feb 2023 07:40:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuae-0001Y9-8U for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:40:00 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 190285f5-b73b-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:39:57 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-408-3X0mIeh5O9mz_oSP3tGy3g-1; Tue, 28 Feb 2023 02:39:53 -0500 Received: by mail-wm1-f71.google.com with SMTP id y16-20020a1c4b10000000b003dd1b5d2a36so217219wma.1 for ; Mon, 27 Feb 2023 23:39:53 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id q8-20020a1cf308000000b003e11ad0750csm11789964wmq.47.2023.02.27.23.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:39:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 190285f5-b73b-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677569996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V4CuH1aIrAL4IShJibOpzwPQfte5RpGoDNGh1Yknmno=; b=JeW3zSARbpL/LOXECSSRX8Um90vKTbfJsLmll6SRYVKljCRuou2qKxmxLBKY5y0Wy5zkUp FLccIpynoePuh6LkQFXs3Q1OrF+d4NXjFoEgKw2WKCBGevX9vkDW37JAtH3gMi9eeyLbXr WWDZfPC32XuUHN9y3f+SxG0NI9sDcOQ= X-MC-Unique: 3X0mIeh5O9mz_oSP3tGy3g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V4CuH1aIrAL4IShJibOpzwPQfte5RpGoDNGh1Yknmno=; b=OJoG915b5OIL6ihpn2i8EbyBhvjGpyjckqoYttTlc37x/6QcbOl0tp2YNzHsnKKW5Q MQUctr3heJESD8ZTvnSVlD6DQ3zCDRH8f/c+fqZDrd9sup1aBZO/0nXQ+ys+io2nJ6kq QVb1w76TsjmutCXjQQYxDQqWCLFNESayLr/IsqTPV+g/0YSu8iI7MEi5Z/Z/K1shNKPJ CdZmrm0+n4ExPje+a46XtBuEfQAiToTSPWz7eYynxqc4i/B8ODrB7bqu3RbdoohB4jTX Axdknffm+uxHqj/PraMUw3ODU4O1k0o9q4DlijtM0V/UpGNsvnUbVdsFB848oSEjRp76 xZrg== X-Gm-Message-State: AO0yUKUXOMlmmOJLlaNOEabeIRtam1G3FdoB+IwDjfSYEvjkXT2ripYE dBmzupEVRopmvR58BwSofoLmDoVsrGq6TCTPVGTXluqptBjbNTu2z0zzJDrcVwmij2+XEFCm0K0 iqiz0oHpu9wP3HTgzrVBSb0krbfc= X-Received: by 2002:a05:600c:491d:b0:3dc:d5c:76d9 with SMTP id f29-20020a05600c491d00b003dc0d5c76d9mr1710995wmp.0.1677569992209; Mon, 27 Feb 2023 23:39:52 -0800 (PST) X-Google-Smtp-Source: AK7set/njPCmiXr23K7e76Er7M0HjsF+J1fmqdaUA9M/AOTPF1jtLXZ21lNSyv2Efwi4f6fqXtK/Ag== X-Received: by 2002:a05:600c:491d:b0:3dc:d5c:76d9 with SMTP id f29-20020a05600c491d00b003dc0d5c76d9mr1710980wmp.0.1677569991934; Mon, 27 Feb 2023 23:39:51 -0800 (PST) Message-ID: <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> Date: Tue, 28 Feb 2023 08:39:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> From: Thomas Huth Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/02/2023 19.38, Daniel P. Berrangé wrote: > On Mon, Feb 27, 2023 at 12:10:48PM +0100, Thomas Huth wrote: >> We're struggling quite badly with our CI minutes on the shared >> gitlab runners, so we urgently need to think of ways to cut down >> our supported build and target environments. qemu-system-i386 and >> qemu-system-arm are not really required anymore, since nobody uses >> KVM on the corresponding systems for production anymore, and the >> -x86_64 and -arch64 variants are a proper superset of those binaries. >> So it's time to deprecate them and the corresponding 32-bit host >> environments now. >> >> This is a follow-up patch series from the previous discussion here: >> >> https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.com/ >> >> where people still mentioned that there is still interest in certain >> support for 32-bit host hardware. But as far as I could see, there is >> no real need for 32-bit host support for system emulation on x86 and >> arm anymore, so it should be fine if we drop these host environments >> now (these are also the two architectures that contribute the most to >> the long test times in our CI, so we would benefit a lot by dropping >> those). > > Your description here is a little ambiguous about what's being > proposed. When you say dropping 32-bit host support do you mean > just for the system emulator binaries, or for QEMU entirely ? Just for system emulation. Some people said that user emulation still might be useful for some 32-bit environments. > And when the deprecation period is passed, are you proposing > to actively prevent 32-bit builds, or merely stopping CI testing > and leave 32-bit builds still working if people want them ? CI is the main pain point, so that's the most important thing. So whether we throw a warning or a hard error while configuring the build, I don't care too much. Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:44:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503045.775173 (Exim 4.92) (envelope-from ) id 1pWueY-0002xh-UO; Tue, 28 Feb 2023 07:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503045.775173; Tue, 28 Feb 2023 07:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWueY-0002xa-Rk; Tue, 28 Feb 2023 07:44:02 +0000 Received: by outflank-mailman (input) for mailman id 503045; Tue, 28 Feb 2023 07:44:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWueX-0002xU-1Y for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:44:01 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8e456d4-b73b-11ed-9692-2f268f93b82a; Tue, 28 Feb 2023 08:43:59 +0100 (CET) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-350-1ajUmizlMvGUUSbEiXjCCA-1; Tue, 28 Feb 2023 02:43:50 -0500 Received: by mail-wr1-f71.google.com with SMTP id a7-20020a056000188700b002c53d342406so1295303wri.2 for ; Mon, 27 Feb 2023 23:43:50 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id u17-20020adff891000000b002c553e061fdsm8954445wrp.112.2023.02.27.23.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:43:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8e456d4-b73b-11ed-9692-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677570237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ufREbMFBsFQIjAxMK7Naz6Z2bm0FVGjZtzY/hZNym1g=; b=WWpDVZv7yevNEqNsT0rYeJ97394JgcwpTDLS2fodOXqMetC+8IOHLPoCrZi6qIYw5IYdFF Y1pN3eC0FLyqJaIU5/jyaahFybZF8mK8Ej8RvYYObtxb6y8MBsyTaxsP9QcDshR/7P5aCr 8FZbnlokfyD8fS+pQvEK64MsI9aarUo= X-MC-Unique: 1ajUmizlMvGUUSbEiXjCCA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ufREbMFBsFQIjAxMK7Naz6Z2bm0FVGjZtzY/hZNym1g=; b=aArVLVlm/I2yDy6qAmCQCGv4NdqKgFJT/SaKzHz+SgwsYmkKhFykk3tyo0s91SdwhL AmM4B2YGTZvYXNvOD61A2v0nXQ8P7qRGBgB1h3SoSao0LFw5PRWnaboh2lr7bXQPbNw+ ey/uZIhUarePpDSlUL2o9Z6k75NYrAw7Lk6Tzx+E0tHkcm1w6Qrbtet8ibX5BlnjSaiB MfqoMha/GTQAmu6QQjkvZhCFn+pUe2tPvdXB2V9krkbGY7JuY3wWAL1C/Tn1ZBHCmdQE 4K+U3ppOV/FQRSKv3T/Ut5MRRKXSPjErWKnsrCQqCQJXmSSkGhrxPJctGOKagi52flFl isJw== X-Gm-Message-State: AO0yUKXpAnhw4ViV0NQUnAUXVu35vzTSa9WESIo95gXYkzdeLP42TZhw 37BFnmymHBl1mJxuhleaggwfLkQMuuSQhVIxPX9CWB/7CIn6BljBuKusgHxVk+h14ge/24ckk06 z5NtQ43zPA/LSpWsx+/+N1dshR9M= X-Received: by 2002:a5d:424a:0:b0:2ca:d5dc:bba4 with SMTP id s10-20020a5d424a000000b002cad5dcbba4mr1466419wrr.59.1677570229808; Mon, 27 Feb 2023 23:43:49 -0800 (PST) X-Google-Smtp-Source: AK7set/+OC6jQRznL8bCi2fp/4ORQCK/tSgqjWzf1oQTF69+WhcSUvxgOLNifCcD01s1iI5r3TuvcQ== X-Received: by 2002:a5d:424a:0:b0:2ca:d5dc:bba4 with SMTP id s10-20020a5d424a000000b002cad5dcbba4mr1466399wrr.59.1677570229519; Mon, 27 Feb 2023 23:43:49 -0800 (PST) Message-ID: <2979548a-59f9-744f-70a7-d0fd00be0a2a@redhat.com> Date: Tue, 28 Feb 2023 08:43:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <77b8545c-4f2a-b389-2811-47d2d48940d9@linaro.org> From: Thomas Huth In-Reply-To: <77b8545c-4f2a-b389-2811-47d2d48940d9@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/02/2023 23.32, Philippe Mathieu-Daudé wrote: > On 27/2/23 21:12, Michael S. Tsirkin wrote: >> On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >>> I feel like we should have separate deprecation entries for the >>> i686 host support, and for qemu-system-i386 emulator binary, as >>> although they're related they are independant features with >>> differing impact. eg removing qemu-system-i386 affects all >>> host architectures, not merely 32-bit x86 host, so I think we >>> can explain the impact more clearly if we separate them. >> >> Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is >> a superset. > > Doesn't qemu-system-i386 start the CPU in a different mode that > qemu-system-x86_64? Last time we discussed it, we mention adding > -32 and -64 CLI flags to maintain compat, and IIRC this flag would > add boot code to switch the CPU in 32-b. But then maybe I misunderstood. > Thomas said, "CPUs must start in the same mode they start in HW". No, I think you misunderstood something here. x86 CPUs always start in 16-bit mode, as far as I know, and the firmware / OS then has to switch to 32-bit or 64-bit mode as desired. Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:48:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503050.775184 (Exim 4.92) (envelope-from ) id 1pWuiG-0003ZH-EZ; Tue, 28 Feb 2023 07:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503050.775184; Tue, 28 Feb 2023 07:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuiG-0003ZA-AZ; Tue, 28 Feb 2023 07:47:52 +0000 Received: by outflank-mailman (input) for mailman id 503050; Tue, 28 Feb 2023 07:47:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuiE-0003Z4-HH for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:47:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 310b9300-b73c-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:47:47 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9589.eurprd04.prod.outlook.com (2603:10a6:102:265::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 07:47:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 07:47:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 310b9300-b73c-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGoEEMMlOLCR8iis6atl8yW3/0EBhYG6czWVV8h5s81ayWMPEJP24EJZ4E/p7vN3/Wnz4d1e7ztkqBwGR53OvlKB4Y91HWhhog5HscrJvQM8Ki3Zx3IYQtEwi5oSk4PZ/bsWhJGqimBoQFiH46H2yziFwOSKDfiGhgK4u5BXwDHmkIM/2yPuzRgogcn4bocwzZxs8r8rNWrVZrbTmHvhqKFMOngaf0hJuqk0igonhuB1mwsKPjaWmmOOhHi4CNRzz3m0rCa1lg3/94F6ZZBuU/HkIMSziyXMOQkjcPN5wRY5iCzKrihrr6YmtdSqw+2G0LYq07YiWgtlQU6p442t6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KNnsOQiKAvQXcsiEcmuTGgXBtv+6KrlSKkhh+8Zlcc0=; b=P6NCrcVbAdcT9VXgSmnBNyA7bDLAGQCdV8j92xJf06lEoE31ZMp07BhjeXuQvocPHwfXzWruAOZ7o47zK/POEHvE3HOUs7p0POWGvzNncQf/bBgu/RtlOMOpAB0tMnCDJjXKHQJT/b/l8+qyZl+V/RLSbVDKBKlfEqGNzsl1p493FYdkqbqS4UqyVjWotjXKWMpEbPO6hkVgErEPHxDj1I25u7XQjPOW+Bf2TEJNXyOMmXTdOcvLTqSPZ+IhBR0/vvCo6awd39yMzjT0GJJNwzkdK2cnB7QTkU2kVJR9GukwgBtp3RAGbEmdU9y4Nj7OU9wxE2+SOMJkJZF9BxL84A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KNnsOQiKAvQXcsiEcmuTGgXBtv+6KrlSKkhh+8Zlcc0=; b=rQGu+zhnAm24Hbjn6YGEXLeYQWUsMfV0bqNGhM6l85NmD7YKG4Lzveh/JyrwYz3Zcgw9Vfsc5v6zt+ryg2Y1883uSg9RFFzuF+7MGuAqJ1ZAx8iMZS1Zqi3DWb4Uhle/XjKl/0boPnoGM0lrBlHXJU1Q+cqJ436xcB+bApq72e5J6g/GBqeejIvT20XuTLfilZajcWgzRWLkiIuqreKWg0ovf6bjDRqioAOA0EPMd5yJGgSpLnfJVBGZsm/CY7lUecSMy+nBDUzGC/4LQAs8T6lH7p2+ZhAX+dWwVml7JUbOqRCSFO0LEV/LYef6PxOllNipNRXjZDV46fOszShqzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <863cd6ac-eb77-92bd-6584-1eace36e5dd5@suse.com> Date: Tue, 28 Feb 2023 08:47:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-US To: Andrew Cooper Cc: Jun Nakajima , Kevin Tian , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org, Xenia Ragiadakou References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> <12849cea-58af-e13f-89ab-a7e9d4200df8@citrix.com> From: Jan Beulich In-Reply-To: <12849cea-58af-e13f-89ab-a7e9d4200df8@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9589:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a0e8f6a-2723-4bbf-5fc5-08db19600316 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FfZFCiibqlmpLvknt8LUwY66xoNCWp2osP6LxLvW9KoTTtxnqa02H1FMbLsb6UV+j6qIV1WYgKvI2K1pXZ0Bpz73XXTeIcFq5LAB8fmjALUorKiXRw+xnRjS/PAPo4Kumf2XAU+DYf1Qr7+MdskaaIRvq3SpwtJmTPvqEbH3ns068XHIQ3WV/D5QnpT6cMIVqStSDDe3QrSzhMiNzC335n+EEN8ys0O6FvuOrc9rJ0EnBP9zdEkmcQj4cALFeozoxrtkUke4H1uSDFmY1gPXFQqQbNnSEd0M4StCYDkzcBKZwnG8kAt38+cZXuDTHnJr5Yx3Pi/GOC1vreH25LGler47gc7Zm2dak3HDTYw4Aekjw2Nn3gWGIPwFucuxTvpsZeKTUJPHJwWA+TBR0Ir+21MB9D5qTNqO0Y7CZUeh+VxQAfyg4v0asAPePmc8x/wW3EKMAFjB8m8StNkimwEZXW2qzfTAhs3fCHRxaaLxO175Iz0+etHdznb8oF9xSy8RmUz4uzVCf+svbcFdRN+oixYdxPSYZn+1D1OoPF5slVFipt3Kks0z7eoLdkWD263ZJMeutJ/pyvTo4V6vQ0sZh0VF+ESYKUpZmUUVbUb9jqZeiGTuMtJwNlj82TdTBfI/RzSP0RnKU8MBq13qhg2ajhK06rpPqaEI5j0zhLPO1c9+/3VGTCSydwHrjOnUHRNj2ktSf3W90U40dFXUFGwh9RVo+OqJlB9oKWaaX5Z4k68= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199018)(36756003)(2616005)(53546011)(26005)(186003)(38100700002)(8936002)(31696002)(41300700001)(8676002)(86362001)(66946007)(66556008)(66476007)(4326008)(6916009)(83380400001)(478600001)(316002)(5660300002)(54906003)(2906002)(6486002)(6512007)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGpxMXF6VU5wd0dvcitFOFdhODdLdkI5S2hKMUFlc1IwRmFHck10RTk0MXJM?= =?utf-8?B?VU5YS2JKSXNwSHJwdytUb0p1RFRVbXczU2IvNi9qTkphMnVqQ040ZnZiaG5o?= =?utf-8?B?eEhBeSt6TmJnUmZlVGVpOWYzRjlGeVVKTm1FRmxXR0Erd2FKdll0L3dmWGtX?= =?utf-8?B?T0Zxd3ZhL2llOWpsNU5HWUJIbUE1eVFvcWJZQXRIeDNTcFhLNkpBLyt3YllQ?= =?utf-8?B?b2Q1cVBWeEI5S1JtZmFrODRMNnlQbVl6dVBhWkFiNmord1hrUUlPc3hDUWZn?= =?utf-8?B?Z3hmbzdpdmJhc0FGVnZ1dnpvNDdzNG43RE9BM1JkeU5wVWt1ZVpDbFlGWW9y?= =?utf-8?B?UTladG80alNwNS9WdVdIeXQ1aTRXK0ppQURRNnRLa0hUTjcvWjV3T3RQeHgr?= =?utf-8?B?ZHdMNW45Snp3QkJaY1RCYThzU3VvTDNJSHlGQXZ5d2s5Nlpld0VoL0lyRlBj?= =?utf-8?B?SW81Tnpud21HL0swRGdDNlFBZTQ5YjVNeEhVLy9SY0o3TTdSeGlhUk9JVURv?= =?utf-8?B?VGo5cCthbXVVbDJTUWJvNUlxZzZ2ZmkvMkVHUGxZSFJGbHQ0ekxGU1d4MG9w?= =?utf-8?B?V1IwM2t0R1JZMk9vK3dRQis1YnM5VGRZNXJ5STVXMkdFR0hQQVRRY29kS0c2?= =?utf-8?B?VlNoWTlEZXNaWlNXWFNOMUQvVnJZMGJjWDEwcmdwamdsZ2NoSzQxdGRLRkgv?= =?utf-8?B?bkRzcmtNd3V5TzJMQnRQd3VBaldXbitwaitmMFJUcFVnQk82a2VObWJTdmNQ?= =?utf-8?B?QXZWcklxcjB1Nk9mK0VFU2w3VG5zOTIxWWtLYUFRZUhXS3FiOGpTMDdzQ1Bk?= =?utf-8?B?RHBYMWtKeXhKZXMyTVp3Q3l6b1pWK0RtODIvK0FDSlduUFNuU1VkOWJmbnNs?= =?utf-8?B?R3ZnVUF5YnZ0U3RJcDdhMVJXaStYblJuVjlLNDE4Q2tmUm15L1V4MFRaSTBF?= =?utf-8?B?VTgwQjQyVnYrVU82NkxUR1J6MVo0RDJYRWJYbmZyWmlib3l4Zmp5ZUJzS1NR?= =?utf-8?B?K291QlYrL1hPTHNUVmN1QnFZeVUxbElLcGMzZURkTFRySXdzU1NGQmo5cVc0?= =?utf-8?B?SVMwK2wyVWkxdURKbXdRWFdhUGlITVpMWmlxZUhKNXBGdkswVXpFR3NvaW84?= =?utf-8?B?ODZ6VXY0ZlFNMzJRK3pIcElRN3FNd0gzOFJGemFCRzlBODk5amo4ZkRNc2dJ?= =?utf-8?B?V21NbFBpNDVScmRPMkcwUEZxSGJ3T3BpMUlpRE4rODVDYlR1dHNkaU4yN3JC?= =?utf-8?B?T2twaTVkSlZ3L000Y2twN0RaTkpQcUFWRDJ3NU83M0lkUlRjbjZYWDJEa2Y3?= =?utf-8?B?V0hBMFJnWTlxZ01LRituY1daMjhrMUd1eUthOWtBb3BDanJKRWxNNXVjVjZD?= =?utf-8?B?ZXIxZDN2aHZnZzY3VDBYMU5rZjdBWG1Lem8rWXA5WFMydFN0eHlNc2JlQUFP?= =?utf-8?B?ck02bTFzZHZKbVQ3Tm92amUvcHdNUlc2T0FndVJVb0d0SG9KejlIcVltc2RN?= =?utf-8?B?U0duUkRvYkxiZG5zNzhOeHFZQ1ZIb2RHRkZyZitzRzBjSncvajNQYnhsR0Vx?= =?utf-8?B?S1VxMnJ0NTc1VEVna3ZEZ2ZSZk9Tc3hZTG9mNUZzZlVUa0F2cUEyTHd2Q2xH?= =?utf-8?B?N3VGN0tmaGVKKzdueFhCL1I3RE1pa1dTK3JqR0xUWThXSGI3UFRlKzErKzJz?= =?utf-8?B?SmVDd3lBUVBRQWV0VWdlclU1Tlo4N0VFNno0QVdJejBEYWx3SUpoVWxuekpD?= =?utf-8?B?aFhzSGVpZE1jS1E5VHFVLzkxYzhTSk9CYzlvUjE3YWRMdFpnL2sxSTRkYzIv?= =?utf-8?B?YmVCcTNRQ3dOdy9sVGJmMnJLeUdPdkVqWVVaZUoweVNXQmpDL0NMSDJPalll?= =?utf-8?B?UGM4SEY2VE9BWE1uQVIvTmNKRWdSUGZKWmV2dDFXRlUwSXNFSy85NVMzdDNz?= =?utf-8?B?dmNyamJzS0JTd3VrR3RNOG1RbDNnWFlTdHJUUXNkK3hyNTJHdFRoRVJOMkM4?= =?utf-8?B?SlpoY08xOC85czJQOW5Rdmk5QWVad0JXSG5xNmVzWm9zUTkvSFplMWVDcm1P?= =?utf-8?B?OVNHS0pqbE1ESmhRWW1rcEc4T3ZoeTY0SDJUaW9aVEdid2R3bkkwZ0VSZkNC?= =?utf-8?Q?I97QGx0810Z2TRv0g7JjZU5y9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a0e8f6a-2723-4bbf-5fc5-08db19600316 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 07:47:16.5066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oDZ7pk6JtjKDLz0SnyW+MX8IEQ2og4PYoupaZh/8TAwpmppVaecESe8i1EHKcP+HBu928witkbkQsMgezGZ7/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9589 On 27.02.2023 17:26, Andrew Cooper wrote: > On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote: >> Create two new private headers in arch/x86/hvm/vmx called vmx.h and pi.h. >> Move all the definitions and declarations that are used solely by vmx code >> into the private vmx.h, apart from the ones related to posted interrupts that >> are moved into pi.h. >> >> EPT related declarations and definitions stay in asm/hvm/vmx/vmx.h because >> they are used in arch/x86/mm and drivers/passthrough/vtd. >> >> Also, __vmread(), used in arch/x86/cpu, and consequently the opcodes stay in >> asm/hvm/vmx/vmx.h. > > Every time I read the vpmu code, I get increasingly sad. > > That is dangerously unsafe, and comes with a chance of exploding completely. > > That __vmread() is in NMI context, which means `current` isn't safe to > deference (we might hit in the middle of a context switch), and more > generally there's no guarantee that the loaded VMCS is the one > associated with `current` (we might hit in the middle of a remote VMCS > access). Are you mixing up oprofile (using NMI) and vPMU (using an ordinary vectored interrupt)? Or am I overlooking a vPMU mode of operation where NMI could be used (i.e. other than apic_intr_init()'s calling of set_direct_apic_vector() and other than pmu_interrupt() invoking vpmu_do_interrupt() /after/ acking the IRQ at the LAPIC)? Jan > vpmu is generally not supported, and BTS needs further custom enablement > because it is only useable with a custom bus analyser. > > > The __vmread() needs deleting - its absolutely not safe to say. > > I'm tempted to hardwire the return 0, and punt the problem to whomever > next uses BTS. > > Alternatively, MSR_DBGCTL needs wiring into the hvm_get_reg() > infrastructure, but I'm not convinced this will actually work in either > of the two problem cases above, hence preferring the previous option. > > Thoughts? > > ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:49:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503057.775194 (Exim 4.92) (envelope-from ) id 1pWuje-0004Qr-Sn; Tue, 28 Feb 2023 07:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503057.775194; Tue, 28 Feb 2023 07:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuje-0004QK-Px; Tue, 28 Feb 2023 07:49:18 +0000 Received: by outflank-mailman (input) for mailman id 503057; Tue, 28 Feb 2023 07:49:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuje-0004Na-8D for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:49:18 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65b48419-b73c-11ed-a550-8520e6686977; Tue, 28 Feb 2023 08:49:16 +0100 (CET) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-649-7KtwQ4vlPKyPno3V31Z4dA-1; Tue, 28 Feb 2023 02:49:12 -0500 Received: by mail-wr1-f72.google.com with SMTP id k6-20020adfc706000000b002c716981a1fso1296575wrg.1 for ; Mon, 27 Feb 2023 23:49:12 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id l16-20020a5d6690000000b002c559626a50sm8844011wru.13.2023.02.27.23.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:49:10 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65b48419-b73c-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677570554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZiUfsADUzruFZXpDB4J4uXPtM0A/YxNLYWsjw+1AOZ4=; b=AqMs+jXASDuvRsYLsm9vBqXOpqG+VFdEHzoQWsyAx9ppo20el6MZPJi2oqcm5zOHvklxTJ JR1DwG/YdOGeblzPz+bTZG8Tr7ioz5y6C4unb237VaoNBsqbmwDJ121XAsUpX3b2brnbQi yOp/YY9d1h7FLuQVvueYPO3CVNHHqYE= X-MC-Unique: 7KtwQ4vlPKyPno3V31Z4dA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZiUfsADUzruFZXpDB4J4uXPtM0A/YxNLYWsjw+1AOZ4=; b=gYPm+5zvQlQW/cjn4ETBzPR+SgIfeKeqT8X4btrFC4lt08AKtpcjwStRBDd/poiYda X36NlFZnW2hBznm163UEhrzjIcoCaWQmhuWv5UH1paLf2aqUCEY7rtX0hz8eOnjVE4D4 7osxB1G8Vtag5qqu7m1L3aR+Oj+oCr/CTVY/Kn8zFoL1x0VMSBU5lG1bNhplMnDteuCw GsBt6Lk5vPIZFGvgHbj92J8UnudMRhnOw/eUDQwXa3jUxpAFSmEvhg7N1YwoJDpFKJoh Koyut1C0HiIXB3sHpR4uhP1ZPsuy/JrM1Y7czi1YjpM8pQ6RyJQuC5e11t5Y1Y2MwaTD gF7Q== X-Gm-Message-State: AO0yUKWl28RdNoKuzHWd/pPxaVq6FVHq1fk64DGkRT0vGc21oLrJzdPv Itmka9qsXxhk13R56fFpdfbvuuE+PvexRC/X8ob+IGMJZ9fmOQOvqVudQpJ3GmvTtl6NgPUfWXy /0UwegATR+1LxcBraTiuopwhZpMI= X-Received: by 2002:a05:600c:3b26:b0:3ea:f05b:50cc with SMTP id m38-20020a05600c3b2600b003eaf05b50ccmr1676002wms.8.1677570551837; Mon, 27 Feb 2023 23:49:11 -0800 (PST) X-Google-Smtp-Source: AK7set9+Lj7WQrfp82VEPq525cyJkv1tNUqBhsPtcg5W6a+r1jgDEKuIymCq/mXAXSpAaDp6fX67sQ== X-Received: by 2002:a05:600c:3b26:b0:3ea:f05b:50cc with SMTP id m38-20020a05600c3b2600b003eaf05b50ccmr1675985wms.8.1677570551536; Mon, 27 Feb 2023 23:49:11 -0800 (PST) Message-ID: <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> Date: Tue, 28 Feb 2023 08:49:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 To: "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> From: Thomas Huth In-Reply-To: <20230227150858-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/02/2023 21.12, Michael S. Tsirkin wrote: > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >> I feel like we should have separate deprecation entries for the >> i686 host support, and for qemu-system-i386 emulator binary, as >> although they're related they are independant features with >> differing impact. eg removing qemu-system-i386 affects all >> host architectures, not merely 32-bit x86 host, so I think we >> can explain the impact more clearly if we separate them. > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > a superset. > > Removing support for building on 32 bit systems seems like a pity - it's > one of a small number of ways to run 64 bit binaries on 32 bit systems, > and the maintainance overhead is quite small. Note: We're talking about 32-bit *x86* hosts here. Do you really think that someone is still using QEMU usermode emulation to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! > In fact, keeping this support around forces correct use of > posix APIs such as e.g. PRIx64 which makes the code base > more future-proof. If you're concerned about PRIx64 and friends: We still continue to do compile testing with 32-bit MIPS cross-compilers and Windows 32-bit cross-compilers for now. The only thing we'd lose is the 32-bit "make check" run in the CI. Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 07:53:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 07:53:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503062.775203 (Exim 4.92) (envelope-from ) id 1pWunI-0005wp-CU; Tue, 28 Feb 2023 07:53:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503062.775203; Tue, 28 Feb 2023 07:53:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWunI-0005wi-98; Tue, 28 Feb 2023 07:53:04 +0000 Received: by outflank-mailman (input) for mailman id 503062; Tue, 28 Feb 2023 07:53:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWunG-0005wc-T7 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 07:53:02 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea01a4ad-b73c-11ed-9692-2f268f93b82a; Tue, 28 Feb 2023 08:53:01 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-644-aF2V_V0GOjqs99Dc86b5Tw-1; Tue, 28 Feb 2023 02:52:53 -0500 Received: by mail-wm1-f71.google.com with SMTP id k26-20020a05600c0b5a00b003dfe4bae099so3957838wmr.0 for ; Mon, 27 Feb 2023 23:52:52 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id d10-20020a05600c3aca00b003eb369abd92sm10529537wms.2.2023.02.27.23.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 23:52:50 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea01a4ad-b73c-11ed-9692-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677570776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RR2BvpBOXOzqZ7NvVjkZwdvjAhudEm7tI8s4OdXgmN4=; b=RqqToOBbZyxU/AuQ+lyNqrIMl1Dh/X/bAjRiK42UX3RI+9C+hFgozpFZh7293r3G3hOVrU 1vkMWc2mt0yjRVnePDqF29Vxb6kWVofign4zA0mmoQfR2mLDQmPrul4yKpcJddz4p189xE OvVrH/eFcXkcLJtJ2AjRabNq96owx0g= X-MC-Unique: aF2V_V0GOjqs99Dc86b5Tw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RR2BvpBOXOzqZ7NvVjkZwdvjAhudEm7tI8s4OdXgmN4=; b=CkuuBd7LuNZTbP8n4Ltl8fH+05rgDxCZyEZX4Udn+fxcqddwS52A+T7UbLvnXSrqYA DZHFepKHzSxEm1wEGADhq1vju1E61S1Q9hMZ7dMT88ePksGEfGJH6M6MKZa/Q1lPnlpG WQpnDranM0YPT0RGPE+M6D/n31fDLWDkLWxIRAk3JO5/xQJ1eGJ76m1Ve1e/iboRqjGk AtE6ZM0lergCQz/j53Vx+8EIVuskgp9RsfvmPpnPzCiLOVnG3Z3zGUjKWMPvQxOl1Lmy 4HZBjK7q8IoJ4a4jYHPutllMNLECf01n6TMQQ0PjLlg3OIQKcwXYKRN5CwQCDgdDu6pi QQFg== X-Gm-Message-State: AO0yUKXkyLwjkj1rjNZ6n9NzkQgest/nN6GRXlA5ZQ+hdnr+zWLQTtOg KUjeAPUu8w4YO0IKRApvMpZGLlF0epoGFN9878WegGgVQfvFfuYpxe5IZbS9fEMbENaEkljOSBN gY+z41WnOPXyCZszq9psHhvd78rA= X-Received: by 2002:a05:600c:4f45:b0:3e2:24a0:ba26 with SMTP id m5-20020a05600c4f4500b003e224a0ba26mr1281587wmq.16.1677570771142; Mon, 27 Feb 2023 23:52:51 -0800 (PST) X-Google-Smtp-Source: AK7set+ci1F5345rugsjKD5i5qcI5nYxBh17WE97j1xttoOVVrF5Kg3psWnYfbVkr8cqSXw8dyl8Yg== X-Received: by 2002:a05:600c:4f45:b0:3e2:24a0:ba26 with SMTP id m5-20020a05600c4f4500b003e224a0ba26mr1281570wmq.16.1677570770820; Mon, 27 Feb 2023 23:52:50 -0800 (PST) Message-ID: <697e536d-eb65-32d9-279f-b2e6ab5e718a@redhat.com> Date: Tue, 28 Feb 2023 08:52:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 To: Richard Henderson , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> From: Thomas Huth In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/02/2023 21.25, Richard Henderson wrote: > On 2/27/23 01:50, Daniel P. Berrangé wrote: >> On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote: >>> Hardly anybody still uses 32-bit x86 hosts today, so we should >>> start deprecating them to finally have less test efforts. >>> With regards to 32-bit KVM support in the x86 Linux kernel, >>> the developers confirmed that they do not need a recent >>> qemu-system-i386 binary here: >>> >>>   https://lore.kernel.org/kvm/Y%2ffkTs5ajFy0hP1U@google.com/ >>> >>> Signed-off-by: Thomas Huth >>> --- >>>   docs/about/deprecated.rst | 13 +++++++++++++ >>>   1 file changed, 13 insertions(+) >>> >>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >>> index 15084f7bea..98517f5187 100644 >>> --- a/docs/about/deprecated.rst >>> +++ b/docs/about/deprecated.rst >>> @@ -196,6 +196,19 @@ CI coverage support may bitrot away before the >>> deprecation process >>>   completes. The little endian variants of MIPS (both 32 and 64 bit) are >>>   still a supported host architecture. >>> +32-bit x86 hosts and ``qemu-system-i386`` (since 8.0) >>> +''''''''''''''''''''''''''''''''''''''''''''''''''''' >>> + >>> +Testing 32-bit x86 host OS support takes a lot of precious time during the >>> +QEMU contiguous integration tests, and considering that most OS vendors >>> +stopped shipping 32-bit variants of their x86 OS distributions and most >>> +x86 hardware from the past >10 years is capable of 64-bit, keeping the >>> +32-bit support alive is an inadequate burden for the QEMU project. Thus >>> +QEMU will soon drop the support for 32-bit x86 host systems and the >>> +``qemu-system-i386`` binary. Use ``qemu-system-x86_64`` (which is a proper >>> +superset of ``qemu-system-i386``) on a 64-bit host machine instead. >> >> I feel like we should have separate deprecation entries for the >> i686 host support, and for qemu-system-i386 emulator binary, as >> although they're related they are independant features with >> differing impact. > > Agreed. OK, fair, I'll rework my patch according to your suggestion, Daniel. >> 32-bit x86 hosts >> '''''''''''''''' >> >> Support for 32-bit x86 host deployments is increasingly uncommon in >> mainstream Linux distributions given the widespread availability of >> 64-bit x86 hardware. The QEMU project no longer considers 32-bit >> x86 support to be an effective use of its limited resources, and >> thus intends to discontinue it. >> >> Current users of QEMU on 32-bit x86 hosts should either continue >> using existing releases of QEMU, with the caveat that they will >> no longer get security fixes, or migrate to a 64-bit platform >> which remains capable of running 32-bit guests if needed. > Ack. > >> >> ``qemu-system-i386`` binary removal >> ''''''''''''''''''''''''''''''''''' >> >> The ``qemu-system-x86_64`` binary can be used to run 32-bit guests >> by selecting a 32-bit CPU model, including KVM support on x86_64 >> hosts. Once support for the 32-bit x86 host platform is discontinued, >> the ``qemu-system-i386`` binary will be redundant. > > Missing "kvm" in this last sentence?  It is otherwise untrue for tcg. I assume that Daniel only thought of 32-bit x86 hosts here, but indeed, it's untrue for non-x86 32-bit hosts. So this really should refer to KVM on 32-bit x86 hosts instead. I'll rephrase it in v2. Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:06:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:06:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503073.775214 (Exim 4.92) (envelope-from ) id 1pWuzq-0008OW-Rg; Tue, 28 Feb 2023 08:06:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503073.775214; Tue, 28 Feb 2023 08:06:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuzq-0008OP-Ns; Tue, 28 Feb 2023 08:06:02 +0000 Received: by outflank-mailman (input) for mailman id 503073; Tue, 28 Feb 2023 08:06:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWuzp-0008OH-A3 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:06:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062d.outbound.protection.outlook.com [2a01:111:f400:7e1b::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcd84ecb-b73e-11ed-9692-2f268f93b82a; Tue, 28 Feb 2023 09:06:00 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9222.eurprd04.prod.outlook.com (2603:10a6:102:2a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 08:05:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 08:05:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcd84ecb-b73e-11ed-9692-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djpdxQGO6nqURVHb8OnVqpIjdGvrAcXifJ1GI8rz/aXeDCe3Dq6XfyFW1oSt96DD6siafFT2upe1Uli8rCY8wWybQtLIUvu6p532SYFT45OVzJH05xBNSNtLYnmLWQJqQaR61xLbalZdYY8FZ6J4b8tAkAtP29uwrRnCiwURQ9ccwmU7vvTVYprKp43g4nBkot9PQRNCCSkIh2HIUwaNA8MKkm3jSrRNFmis18/8cfOETl/5jkEsCJXTBZDIqhCt6v9Xpdy42xmhJ411CL4NvEioFZDtkSDU2Kkkp4kY6vmng/89fcLZWwl1LrFHqRLppAMdzp3aSIOlYh4ptu37Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ViZO164QXL7VhNXQ52sU14Q8GwFpea/e/CMUIxCpHME=; b=g1bwVU3UlAdXGjJ6B7vPSvy9qv7RkkJRoKXp5WFud+HNklx5FfYXN7/vguuezrZ5skF6wK+XO+w2b/FVrvx+uDcSC+BPqvAz3YimQlS56eVtN6SQFB95yvu0Siaapys8DqPLiQIBjK8lQ3MI/t3TEe8zaFPIFSotr1sjPX1hpMzZw3wQcdmZjmkWzsU6JPC+j1SV9+n3AqnhAhP8rk2B4n9gYiqazud1vfGOTtjubqyMo3nTOYI0Z2kM4EJRDzj0j6UeNxqpnkoxHsJIGJCnORPkKA38bEl8vBnkmaoRE7avapw64cnbuZJWnfnwDMrf3xmSyk4dgmIxssZZ0hIxWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ViZO164QXL7VhNXQ52sU14Q8GwFpea/e/CMUIxCpHME=; b=BlGDlvHPoqB/MoLr/x0tsVDDdU4lNZGGoyzjkvIHGplu5hVFwFN6kVDNicXZzCp43D8JtUJnHHinKG2vVMHwvxJzX82EUH9rvELBj1A8tFT7arEAb1/w5SpWbvZol4OmY5iHpjD1Jbgt5ue2TWuuv1V/nyy1KF/sk93uEHX4VImFw/gq5aexfPS2ORn0UJGDbiesOQAB9wBk8xKxhA6f7hTE677o+SLIy8WNzNw7Ay0DVDBrJApMqWvglEAOfFaWiUCzCiCvzSWWeWfigGyuByV5WvEPlco3PZWaeYV4Znoqj0vfxbdzchIHyU0sJeNXJYNziOeb4ed4sj2QNUDZbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3dac350b-58f5-1407-15a1-5e38de017248@suse.com> Date: Tue, 28 Feb 2023 09:05:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230224185010.3692754-1-burzalodowa@gmail.com> <20230224185010.3692754-11-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9222:EE_ X-MS-Office365-Filtering-Correlation-Id: c2e26744-ee45-4bb0-a4ff-08db19629ff7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mygwOhURDQjQWRwTKlY6sWAZIZ8niDjN6mL4bR/Vnur/57eEGjy4upDbt+HuypVZRKWETnAI4na9WqHw7Qz29hA6WMRP72TBlpC3xe0UYtHiLBB/YJiSkJH2+z28jUd1g2kJrzTbMPyM06DHRHLJqcxr/tGaJZRzSpuVBGXuRnjMkKtjLK9RJTpJ6Nos3AKCKA52OawO5lv7QBTLxRJrEcsFD7sLB98QUGhC8XmkWy7/S9k6Zq21UmPhEggx0KNDfJp/jrzzRiKo9AxRYMkmhJ6qanCP+zTjnok1yc9hIjzX2dzTtnpfrvdRSNztUsL8X9Dnh2zRLELxD08xeiYgrXLtMcIgkCI4PSJaRMw7OWCvlQYUamv+YR2Pt6HCpEC9baYUBf+FUVm1WV25JVo/gJaxumRjaq0eqJiDT9nfzkxP+e4nSE3E3RrzBFbVM1yWAGM386zzqxkbF8y/WMvHHwYO0RbZMuS6X/fbXVCEaCqWm0YUuEnNmPWx5SSimQT6YN2RqHCDS2uszfWW8O+HkwD8BSkq3dogYFZ3GSXuvejwSoOPsJnFLvdxRKLBmKMn6X+oG+EBrwzyCoq+DZLt8NKg5fCXb8LVr478MZHN6gcZ4CeoCNC4sV8gpQRf8xe767vkJg0Nn6yYI+3q8KYKBIrN8+swMsFeIe5OcMCBaROsqzUjscd/9/J1JvsQYgEnIMkbf3cVvZUGYFmbNIT3ijxlXMGdqVAY4+yapWslgnQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199018)(31686004)(8676002)(54906003)(316002)(66556008)(66946007)(66476007)(41300700001)(6916009)(36756003)(31696002)(86362001)(38100700002)(4326008)(186003)(26005)(53546011)(6486002)(6506007)(6512007)(2906002)(5660300002)(8936002)(478600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlF4OFhqRFpWRmVqKys2Mk13aTEyRFJBNVRUT2lzMXhTcy9BMkMyenJBNUp2?= =?utf-8?B?ZGdPQzJUcTRVWXJaREU3L2EybWdhT0ZpalRGb0ZEQm1yN25kZ3J2YlRCeU5j?= =?utf-8?B?NkcwbWhueFJ3Ui9xM3dEL2V3ck5rS1NuSnNpVlBvWTBEZEdyR3NyQnRnWVAr?= =?utf-8?B?ZGt2YWwrQnkyWmV0SmxiMFlzdlhmTlRITCtFVmU1aVFDMEVIT090L1U4aVMw?= =?utf-8?B?QXl4MmZzUWljaE5ZS05oMXRTUU95MG13YmV2UzFtaEJSWFp4R3RBcS8wVmdF?= =?utf-8?B?dHhQOU5hSkdiVlRZT3F4cE1pWXRPNUJIU0FhdlhFRnMzNlB0SW9ERzBOVzVl?= =?utf-8?B?U2NjNk5PL1lQRTBXdnRVZzlaWWdYR1BqaDhQcG9KKzdQNTRXYzU5clczcEtr?= =?utf-8?B?OUJQWHA2eEp0V3NMWjJLL2IyL1I0Nm9JV1FONElTQTdhQzZ6TjBHVk9kc2dl?= =?utf-8?B?ZE43K3pIMWdrd0ZLcVIwUFBHY0s5d2JDbzBjV3dLRlNXV3d4L2ljWmtpWTdu?= =?utf-8?B?RmFJWnZFeTIyN0hsdlp1NTQrWGNHTThzMFhpbEU0MWZRUFRVTkJTcHFOQUZl?= =?utf-8?B?WGNKQkUwSThJMU4yekRhaWFSUFlLM25mQmlUYVFhSnFlL3p5cjdwaXB1YUFD?= =?utf-8?B?OUt3a0tySjFzbjBpcU9XU01kRWxpbmQ3R3A2TUZtek8zdlBMM3kzYTdqNHF0?= =?utf-8?B?REMzejVpNkUxbVRBOGltMHZTcytiamM2YnBUV2pITGp3c3RROXJEZEZVWHF1?= =?utf-8?B?MWN2M0dDU3VuNElxdUFTMFo1c2J3NkpjN1MvMG5maUtrZ2lHZkQzakhHNjBK?= =?utf-8?B?Z3dzVkR3WW44d1N4VEMvSXQ0ZnhBUzhubHBvemR6QkZyZnBEMkZqNGRaM2Ni?= =?utf-8?B?UnpDblBBZU9VNDVweEhnSWJKQzdSQUpYSXBOdWVRRlV3aFBPd1kxK3dUZEJY?= =?utf-8?B?OWc1YjV3L05YVTVPUFdHVkFrK3BzajNldldLZGtZWE5BeWk0SEFkRlY4ZmZh?= =?utf-8?B?c3VzQXJ5dTRMV00xNUc4cGJRaDN6dHVyb3RMWTRNbWVZOEN4NkMxd1VqZWwr?= =?utf-8?B?NVFCbVVMelovQUVOQURCQWtyS0s3ZU5USzBiQ1gwZ2Y5NE85bExZRVN1VnlY?= =?utf-8?B?SWxRbXowanlHdEVuY2ttNTEvRnlWVHhuZ2ZHWmE5THdKdHZkRzlmeE80WFdH?= =?utf-8?B?T3d3QW90NTNNWXE4RXJBbnFXczU2bmNKQ09tWjhvM1hKNTZhK3BFMU1hUzFa?= =?utf-8?B?VWVuQUhsYzgzUCt4VWFSbXpvUUdRcHhrRjI1TGljY1RQL3VaWS9mTW93Smov?= =?utf-8?B?QkhtYlRmZ2pXTFlXalQyelBNUElPRlM3L2k5MWUxdDVzZ0tHemZJaFYxU2FG?= =?utf-8?B?aGxnQTY1TkNCeHpjbE9uWVQ2NkJTUDcwNGQxODBBVW5QREtVenUxL2ttSGZz?= =?utf-8?B?MkdwdjlMckVlV1hsL3ZQQ3JLR2lKNWRMSkwzV1EyV3hJUjU5MTNwaXNOaGYr?= =?utf-8?B?VEN4RnpXNmh5ZHg1U2lnNFB5Skl2ZU95RzRJVjNqMUFTNmVsbmI3aHRybGFi?= =?utf-8?B?NFo4R3ExSVpIbkZmMGJDaHozTTdpcFUvNHluVFoxdW9mdC9qeDVqS3krRldt?= =?utf-8?B?K0lFc1p3dlVwVU9VTU1JL1RuRHFVTGp5YU5LQ2JzUmszN0V4b0U5TStNOGRD?= =?utf-8?B?U05xZkRwSkNucC8wMDRuUlhvZjlweXZMTXZMWjRSMmtIc1J2NHQzblowV1dY?= =?utf-8?B?OUJ6QkRINTZrdVA0RFgrQWM3ZG5WemFtNWdNTS95WlJ6bnY4QTluREtJWkNt?= =?utf-8?B?YjBZcEJBaGs4MUFwZzAyUEV1SlBtKzF1U0hjZ2Y1WG5sUnhjbGNMT3J0VGM2?= =?utf-8?B?SyttazBlM2FmQ1JrTWl1NmVROWljMS8wd1AwRmNuRjJGVHhlZTRnR2IySng2?= =?utf-8?B?b1ptYTFEVWc4ZExkVEQwNDkvWlZnN04ybzZnTHJ6R3NWSWVFNURKQzVHN29U?= =?utf-8?B?aGdtQ0E4cEU4c3g2TGtSNG03UkFpUGRYcVVIR2xiR0FjM25Ea3JIdzVDa0Fk?= =?utf-8?B?SWdIVGNoV0JKdENiL1gyQWhMWllIQ0I1S2xmc2tlcGdvbWdVUXpwcnBvZjNK?= =?utf-8?Q?JinLHMyzWo0kUYSwr0MCrUt5r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2e26744-ee45-4bb0-a4ff-08db19629ff7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 08:05:58.5603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oiyCSMXcHHKJbcshahDxfp7xoWyAonr/rwltJdScyqJfXceFlxTt/fcTmMy3JP2Fuz6GUummBaAbIrm4HE3FEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9222 On 28.02.2023 08:36, Xenia Ragiadakou wrote: > > On 2/27/23 17:25, Jan Beulich wrote: >> On 24.02.2023 19:50, Xenia Ragiadakou wrote: >>> --- /dev/null >>> +++ b/xen/arch/x86/hvm/vmx/pi.h >>> @@ -0,0 +1,78 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * pi.h: VMX Posted Interrupts >>> + * >>> + * Copyright (c) 2004, Intel Corporation. >>> + */ >>> + >>> +#ifndef __X86_HVM_VMX_PI_PRIV_H__ >>> +#define __X86_HVM_VMX_PI_PRIV_H__ >> >> I can see that you need something to disambiguate the two vmx.h. But >> here you don't need the PRIV infix, do you? Even in the private vmx.h >> I'd like to ask to consider e.g. __VMX_H__ as the guard (and then >> __PI_H__ here), rather than one which doesn't really match the >> filename. > > I do agree that adding _PRIV_ is off target. > For the purpose of disambiguation, the header guards need to conform to > a well specified pattern guaranteed not to be used for anything else. > For that reason I would suggest the guard to include the path, not just > the file name. But as we see the path can be ambiguous, unless all non-private headers had an "INCLUDE" infix. Hence my proposal would be no path at all for private headers, and path (as we frequently but perhaps not consistently have it) for non-private ones. > In any case, the pattern that is used to generate the header guards > should be mentioned in the coding style doc. Perhaps. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:08:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:08:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503077.775224 (Exim 4.92) (envelope-from ) id 1pWv2A-0000aC-7G; Tue, 28 Feb 2023 08:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503077.775224; Tue, 28 Feb 2023 08:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWv2A-0000a5-40; Tue, 28 Feb 2023 08:08:26 +0000 Received: by outflank-mailman (input) for mailman id 503077; Tue, 28 Feb 2023 08:08:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWv29-0000Zt-BQ for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:08:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 12aec3b9-b73f-11ed-9692-2f268f93b82a; Tue, 28 Feb 2023 09:08:24 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A512FC14; Tue, 28 Feb 2023 00:09:06 -0800 (PST) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C84E23F67D; Tue, 28 Feb 2023 00:08:22 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12aec3b9-b73f-11ed-9692-2f268f93b82a From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] xen/arm: check max_init_domid validity Date: Tue, 28 Feb 2023 08:08:10 +0000 Message-Id: <0cf2013e5e6018cae300c39fb65ed526eac5c35c.1677511937.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Before trying to create a dom0less guest, check that max_init_domid increment will generate a valid domain ID, lower than DOMID_FIRST_RESERVED. Signed-off-by: Bertrand Marquis --- xen/arch/arm/domain_build.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index edca23b986d2..9707eb7b1bb1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3879,6 +3879,9 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( (max_init_domid + 1) >= DOMID_FIRST_RESERVED ) + panic("No more domain IDs available\n"); + if ( dt_find_property(node, "xen,static-mem", NULL) ) flags |= CDF_staticmem; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:15:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503084.775234 (Exim 4.92) (envelope-from ) id 1pWv8p-0002TI-TA; Tue, 28 Feb 2023 08:15:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503084.775234; Tue, 28 Feb 2023 08:15:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWv8p-0002TB-QX; Tue, 28 Feb 2023 08:15:19 +0000 Received: by outflank-mailman (input) for mailman id 503084; Tue, 28 Feb 2023 08:15:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWv8o-0002Sz-QU for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:15:19 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20617.outbound.protection.outlook.com [2a01:111:f400:7ea9::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05c6afb6-b740-11ed-a550-8520e6686977; Tue, 28 Feb 2023 09:15:13 +0100 (CET) Received: from MW4PR04CA0333.namprd04.prod.outlook.com (2603:10b6:303:8a::8) by BN9PR12MB5195.namprd12.prod.outlook.com (2603:10b6:408:11c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.24; Tue, 28 Feb 2023 08:15:09 +0000 Received: from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::6c) by MW4PR04CA0333.outlook.office365.com (2603:10b6:303:8a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 08:15:09 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 08:15:09 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 28 Feb 2023 02:14:56 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 28 Feb 2023 02:14:55 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05c6afb6-b740-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nt10MwKHejSzDPp5QKuiUzopI+yAVMTAfETsU8CL+AI7+ADLPZoQFJEAEGGhiIPucocH/2p2OqFTqdXwAiMU8QTCOD6xUSnnpID4bRmuik46X3JhDr2R9/IxXX7t9pXWl62/7pT3JDYrQMUzrW+PkkwhyPIm5+8IRKfvkbhlkrKeQ6O21xDgd0Q7an7Z2eK5IT455bOwO+eZmFopHPEZJ4vcx37PD2dvhKSGP6nWejFyyAwOVKGkFkwOYHvq4AoUd3Wmle4dxSv4fGiAd/oC2coXX84kL5xpntdlGf2UEG5xp4TfnCCJiWPWUpKe9PRYVA3606+KMBjD6xrSB47cCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OV3ul5N1h/b+uCyR4nrTlIq0iHWqeS2wnOiFiisqZe4=; b=MC73u7K75KB60w8f3e4XHu4PPwgn2kxCNxYSJj6U8cZrLG5gp9QNOyXH6J8Oe27qf/CeR6ZRriymMjdMUHB7BUK9VVNpegzezYZZdVvyu3Sj9UUmDyK08/wgCZgDT5jP/9Stt6vJ9M5iU1srLVOemxeVGz8BOqu7Nc/wtsgruKOvLYptbQD/Lf7KN8KL5kO9WJ3H2XPDsK+2MXbSvnPnl9Yd/zDyq1IRz31Y35Cx6Avm/6QAvJiI03JMRZA3FZsTTMB/ELcYJ3Hsx1tIeNx7DGnaI8OFbTao+9Fzw8AkvAAsyF0LYmRrTjK8AkE3Z7xDtH4fzJDciTmzsYDNMNSqeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OV3ul5N1h/b+uCyR4nrTlIq0iHWqeS2wnOiFiisqZe4=; b=psgwuK1sMqwtEM2VNHgd8GnZzdiNhoAE+9aemlALpO6mB9CcgeBS4zrF9wXI5ZEEcvTYvBVvpthbyGS1jRQ8E7r3HR6jcOOPpGM14m8pGAhNKGe0PIGlcZ0bLQ2mkKHm/Ph/4UK2xqzUDEMmvuL4cAtpMVliAjQxxNCXjjysZTo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <5d2890c9-d78b-69af-fec3-dace8723ea24@amd.com> Date: Tue, 28 Feb 2023 09:14:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Jan Beulich CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> From: Michal Orzel In-Reply-To: <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT012:EE_|BN9PR12MB5195:EE_ X-MS-Office365-Filtering-Correlation-Id: e1537b03-7071-49e7-b1d0-08db1963e85f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BtKkPpK4FJbYD0DZrryI7SzdK769+YMm0FuW/xScC9E8+UN6svuOO/Xtbny6Ae6J468wqP8svimt/bUfv6BL0EWMMWBtQxrKZ8bZHZv/fQBw1BbLWQ+11vUj9wpA3b3BH2kc7zD0Clh2KOPj0Y8rIQRv24P2HquASm0A5240BXQwweAtBldmsDobGzeZixIbhVtx1WicEYYzU67wUTYBT24QbByw5sNYFgBJ1uEM3Jxo3j5DR2ZN5PlfTUuL3TuiV7uXHimLl/iyck5WufwHg7rUzonZpSWol5kproNc1wPHBxgbNxssnHDwkE5KQmJFOFCXZXgOQDgvdcBoEmuaPJmGE388INFor4SpYW7w65qs5CZvKWTB8P+XYsq/7CccXjd4l1ftdrpuJOP7GCvESz3km52M5zEN/btcVyT3cciHoyQQnT62OgZJeynT2x+zJnmlVB7NbwjkG2R78drstyqsgz5l/d5H6NCitw+sMp+tmztkNHsbzkJsFV0hZS8BIt2iD5oroZvtabgzWzVY6dPJ1G/6XLKCIAy+y58ZuS3lmqZiQ4EnZWRZXJl1mRI+pafCGGtrVKufeMBTBeGXgYclK+xLyQ0cGiXAZGl0bpOWFBEk8QhhIl9mr3h4zZ5oqAvshgwsJrmR/u90dEurCgrhZoUIONckxipTb00ZQLC3P6Ws1BHh+w3hDNqjAQZ2DcLDku0kXnlTC9ums6MrBOQ73Zm0aDL43Vty1RY0b8Pr1BnCeIQTonF/kg4duk8o1BU4vn/A9Poo0gN72CYtnA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(39860400002)(396003)(346002)(451199018)(46966006)(40470700004)(36840700001)(6916009)(70586007)(36860700001)(82740400003)(336012)(316002)(83380400001)(40460700003)(16576012)(4326008)(54906003)(86362001)(70206006)(31696002)(426003)(26005)(31686004)(36756003)(81166007)(8676002)(53546011)(478600001)(186003)(6666004)(356005)(8936002)(44832011)(2906002)(47076005)(40480700001)(66899018)(5660300002)(41300700001)(82310400005)(2616005)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 08:15:09.2537 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e1537b03-7071-49e7-b1d0-08db1963e85f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5195 On 27/02/2023 16:57, Jan Beulich wrote: > > > On 27.02.2023 16:46, Michal Orzel wrote: >> On 27/02/2023 16:00, Jan Beulich wrote: >>> On 27.02.2023 15:46, Michal Orzel wrote: >>>> On 27/02/2023 14:54, Jan Beulich wrote: >>>>> On 27.02.2023 14:41, Michal Orzel wrote: >>>>>> On 27/02/2023 11:10, Jan Beulich wrote: >>>>>>> On 27.02.2023 10:53, Michal Orzel wrote: >>>>>>>> --- a/xen/Makefile >>>>>>>> +++ b/xen/Makefile >>>>>>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>>>> >>>>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>>>>>> define all_sources >>>>>>>> ( find include -type f -name '*.h' -print; \ >>>>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>>>> >>>>>>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>>>>>> also only be included when selected (or at the very least only when an >>>>>>> arch might select it, which afaics is possible on x86 only right now). >>>>>>> >>>>>>> It would also help if in the description you made explicit that SUBDIRS >>>>>>> isn't used for anything else (the name, after all, is pretty generic). >>>>>>> Which actually points at an issue: I suppose the variable would actually >>>>>>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>>>>>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>>>>>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>>>>>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>>>>>> has caused crypto to be missing from SUBDIRS. >>>>>>> >>>>>> I think what you wrote can be split into 2 parts: the part being a goal of this patch >>>>>> and the cleanup/improvements that would be beneficial but not related to this patch. >>>>>> The second part involves more code and there are parts to be discussed: >>>>>> >>>>>> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >>>>>> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >>>>>> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >>>>>> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >>>>>> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >>>>>> top of the Makefile (thus harder to make sure the linking order is correct). >>>>>> >>>>>> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >>>>>> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >>>>>> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >>>>>> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >>>>>> but for all the existing architectures. >>>>> >>>>> I understand that the changes would be more involved, but I disagree with >>>>> your "two parts" statement: If what I've outlined was already the case, >>>>> your patch would not even exist (because crypto/ would already be taken >>>>> care of wherever needed). >>>>> >>>>>> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >>>>>> into account for the tags/csope generation. Would the following change be ok for that purpose? >>>>>> >>>>>> diff --git a/xen/Makefile b/xen/Makefile >>>>>> index 2d55bb9401f4..05bf301bd7ab 100644 >>>>>> --- a/xen/Makefile >>>>>> +++ b/xen/Makefile >>>>>> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>> >>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >>>>>> + >>>>>> define all_sources >>>>>> ( find include -type f -name '*.h' -print; \ >>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>> >>>>> The fact that, afaict, this won't do is related to the outline I gave. >>>>> You've referred yourself to need-config. Most if not all of the goals >>>>> SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. >>>>> Hence your change above is effectively a no-op, because CONFIG_CRYPTO >>>>> will simply be unset in the common case. Therefore if an easy change is >>>>> wanted, the original version of it would be it. An intermediate >>>>> approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. >>>>> But neither would preclude the same issue from being introduced again, >>>>> when a new subdir appears. >>>> I understand your concerns. However, I cannot see how your suggested changes >>>> e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. >>>> They would reduce the repetitions (hence I called them cleanup/improvements) >>>> but as we want to keep tags,cscope,clean as no-dot-config targets, >>> >>> I, for one, didn't take this is a goal (perhaps for clean, but there ... >> So you would suggest to make these targets (except clean) .config dependent? >> >> >>> >>>> we would still not be able to use: >>>> SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>> and use it in all_sources (because as you pointed out, it will be a no-op). >>> >>> ... the problem is obvious to solve, as outlined before). >>> >>>> Also, why do we care so much about guarding crypto/ if we take into account >>>> so many architecture/config dependent files for tags/cscope (e.g. in drivers, >>>> lib/x86, etc.)? >>> >>> Good question, which I'm afraid I have to answer with asking back: >>> >>>> If these are no-dot-config targets, then we should take everything, apart >>>> from really big directories like arch/ ones. >>> >>> Why is arch/ other than arch/$(TARGET_ARCH) to be ignored? And if it is, >>> why would crypto, used by only x86, not be ignored? As always I'd prefer >>> firm rules, not arbitrary and/or fuzzy boundaries. >>> >>> Furthermore, considering e.g. cscope: Personally I view it as actively >>> wrong to constrain it to just one arch. That'll lead to mistakes as >>> soon as you want to make any cross-arch or even tree-wide change. Hence >>> it would probably want treating just like clean. I can't comment on the >>> various tags (case-insensitive) goals, as I don't know what they're >>> about. >> The useful thing about generating tags/cscope per-arch is that you can limit >> the number of findings. Each symbol leads to one definition and not to multiple >> ones. But this is still not ideal solution because doing this per-arch >> and not per-config leads to inconsistency. Also, as you wrote, sometimes it is useful >> to have all the symbols loaded when doing tree-wide changes. So in ideal world we should >> have an option to use approach or another. I reckon this is why Linux >> has a separate script for that which allows to set all-arch/per-arch, config-dependent/config-independent. >> >> Anyway, I do not have any ready-made solution for this problem. >> The only benefit of this patch would be that the symbols for crypto/ would be visible >> in cscope/tags (TBOOT uses the crypto functions but there are no definitions present >> which may be suprising for people using ctags). >> But I can understand if you do not want to take this patch in, due to all the observations above. > > Well, I'm not outright opposed. But I definitely want to hear another > maintainer's view before deciding. While waiting for other maintainers vote, I would like to propose an intermediate approach that would at least result in unified approach (related to what you wrote about constraints): In general, there are 2 *main* approaches when dealing with code indexing. The first is a "tree-wide" approach, where we do not take Kconfig into account. The second is a "config-aware" approach, where we take into account Kconfig options. At the moment, in Xen, the approach taken is not uniform because we take all the directories into account except arch/ where we take only $(TARGET_ARCH) into indexing. This makes it difficult to reason about. What is the rule then - how big is the directory? The intermediate solution is to switch for now to "tree-wide" approach by modifying the SUBDIRS from: SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test to: SUBDIRS = xsm arch common drivers lib test crypto This way, the approach is clear for everyone and we do not make any exceptions. Also the name of SUBDIRS and all_sources makes sense as they are read as "global" by default as oppose to e.g. "all_compiled_sources". In the future, we can then add support for "config-aware" approach by taking into account Kconfig which involes more code. Benefits: - clear approach, no fuzzy boundaries - all in - crypto can be included right away as well as any new subdir without requiring to fix the infrastructure first ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:19:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:19:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503090.775244 (Exim 4.92) (envelope-from ) id 1pWvCu-0003Tf-Iq; Tue, 28 Feb 2023 08:19:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503090.775244; Tue, 28 Feb 2023 08:19:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvCu-0003TY-FD; Tue, 28 Feb 2023 08:19:32 +0000 Received: by outflank-mailman (input) for mailman id 503090; Tue, 28 Feb 2023 08:19:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvCt-0003TS-44 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:19:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9eba5be0-b740-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 09:19:30 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-401-NX_PNXipPje3JThgadRm4g-1; Tue, 28 Feb 2023 03:19:26 -0500 Received: by mail-wm1-f70.google.com with SMTP id t1-20020a7bc3c1000000b003dfe223de49so6563821wmj.5 for ; Tue, 28 Feb 2023 00:19:26 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c1d8f00b003e20970175dsm15603198wms.32.2023.02.28.00.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 00:19:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eba5be0-b740-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677572368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0hz5AGTBN9eryZg3nZeMjxA9itLfbrKU7K0S/m+pqIE=; b=hwVriYqOXDLEmq9D9ciyHLXTVf3PDLwysYlGbMx5IUuw0DIfCluUvSqUe7EmMEtYk95OA2 WX8yDbc0r3D6hgW7frVtd3w+9C8eVJRVauj6mOkuMxRsRgJx/cVgCfkRrhPQh4yqX7MPHY eQD98/Zj7NAhFbtVgke0uly04sGqWxc= X-MC-Unique: NX_PNXipPje3JThgadRm4g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677572365; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0hz5AGTBN9eryZg3nZeMjxA9itLfbrKU7K0S/m+pqIE=; b=gnqL3QjbDZqMsTDg4oUshwKeXigOtgFwJIGWqHXVYbFOHdRAka8XG8dbumqfOIwvks EH+R3YMfY1kz5C9i/ezaeSA3dJexAMKUe2V4B2PLT9X51LBFe4h/rvvNXKHR7ZsmSuNv ocHFiHeVRoh3xmbs6aoz/2Hs+bpD8zVSCqcHsXjJuc+u3TJOS3ICZJOfBCAZqYhjmm3+ io4Hm/F6os1qDAS+2oZiHY8FHLLH/q6LSy+LPaC6fkCOWRnJiQ2y3oymy/EGd1R/RUOc eJRrFekTfTEyirBIqcza6jkPuNUvws54Tw9fLlS3cIwC+vHGDZbsQICQZq8+ZKvuA7DX CKAA== X-Gm-Message-State: AO0yUKViU0CzufAqXTf+RElGEaaRlpQNHf66nyQpNma8kGcr5VXA08bh jYzvV7ZS7KfW30dyTC71/ZMLxFOhf5y2YPylbwOcXy6MjCjFhGXz+rGq7XguRmXj7/0Pz6Wu8yi cUoQzYNlnvfqAWI9+lLlzQPa97GA= X-Received: by 2002:a05:600c:18a2:b0:3eb:4162:7352 with SMTP id x34-20020a05600c18a200b003eb41627352mr1641543wmp.23.1677572365489; Tue, 28 Feb 2023 00:19:25 -0800 (PST) X-Google-Smtp-Source: AK7set8MhRkZ82bCO1bCO62bz1qOyJGqKvLzP3Zce+ps0g0WYqtWG4J8YWNdNhuZ9T91hDRDN92U1Q== X-Received: by 2002:a05:600c:18a2:b0:3eb:4162:7352 with SMTP id x34-20020a05600c18a200b003eb41627352mr1641531wmp.23.1677572365194; Tue, 28 Feb 2023 00:19:25 -0800 (PST) Date: Tue, 28 Feb 2023 03:19:20 -0500 From: "Michael S. Tsirkin" To: Thomas Huth Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228031026-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> MIME-Version: 1.0 In-Reply-To: <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang wrote: > > > I feel like we should have separate deprecation entries for the > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > although they're related they are independant features with > > > differing impact. eg removing qemu-system-i386 affects all > > > host architectures, not merely 32-bit x86 host, so I think we > > > can explain the impact more clearly if we separate them. > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > a superset. > > > > Removing support for building on 32 bit systems seems like a pity - it's > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > and the maintainance overhead is quite small. > > Note: We're talking about 32-bit *x86* hosts here. Do you really think that > someone is still using QEMU usermode emulation > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! I don't know - why x86 specifically? One can build a 32 bit binary on any host. I think 32 bit x86 environments are just more common in the cloud. > > In fact, keeping this support around forces correct use of > > posix APIs such as e.g. PRIx64 which makes the code base > > more future-proof. > > If you're concerned about PRIx64 and friends: We still continue to do > compile testing with 32-bit MIPS cross-compilers and Windows 32-bit > cross-compilers for now. The only thing we'd lose is the 32-bit "make check" > run in the CI. > > Thomas Yes - fundamentally 32 bit does not seem that different from e.g. windows builds - we presumably support these but AFAIK CI does not test these. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:26:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:26:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503095.775254 (Exim 4.92) (envelope-from ) id 1pWvIw-0004xx-8E; Tue, 28 Feb 2023 08:25:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503095.775254; Tue, 28 Feb 2023 08:25:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvIw-0004xq-4f; Tue, 28 Feb 2023 08:25:46 +0000 Received: by outflank-mailman (input) for mailman id 503095; Tue, 28 Feb 2023 08:25:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvIu-0004xg-Fq for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:25:44 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20609.outbound.protection.outlook.com [2a01:111:f400:7eaf::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7de0af48-b741-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 09:25:43 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8233.eurprd04.prod.outlook.com (2603:10a6:10:24b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20; Tue, 28 Feb 2023 08:25:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 08:25:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7de0af48-b741-11ed-9693-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/sn4/eRH2JOIZTR3Gm0WstoVWIxGt7dJNlaYHjfRBu4ZW9hRFyBdbyKqGXhjkQF1z7nFTba6HbZ6gcDApj38U+48IEUtTROcG5I+vq66q3VhccG9cSJHLAazpGx7/59LMH9uCZJboelFbXGSk8GCr49yoTCj2836MPq2npfg7jWFqKSfcE7K4cUC6K9uxm8aeUyuTqt2MpH+N7OK6j3jlYJYms1eLL0Qi+T1q62C+wnHogLslNOuTvyukCgFrcvhbHJd8+U5yOQWs4wwocwZU0dK4CSIub2qWqh+yUvaEY3khB9yqAwQYBFVS983nVlMtaG31plu3Pp0AQCMK0geQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5cHhUllAWzizlBTNqM3PpXr8BBp+/9MKKVyIqA7v+Yc=; b=Jb3gOf9MuhuhFkmZe296fzzejOdDGs0E70szWwx1dJn+KFo9Q19MaFk06mwajdJdPVDy9CRFNQIukDAZGHL1pZTo4yb4l3Fp53ZlyN9MjyO65yMNjf4BvSgR7coOi7aA1AcCkEWHxLkaMjVeTABAvpJHjhaK9qyfaax5KPW2Wh752U+HXZzSV8m7lU4CRvMmoz5L5lg+qJyP6NUg6xIiPy3AqaynvCc3yALFqvw3rgpMC6I/YREHrsFiLaHPVu2vMxK5aFbgGmQuP/nfDhVfCZHihLtjQ+W3Lgeb6w84bJ9lNwBhMIJc/f0EdcNRLSvDMOErASYHtr8DVHiLZXkPzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5cHhUllAWzizlBTNqM3PpXr8BBp+/9MKKVyIqA7v+Yc=; b=jhXigrtse95Q0bF0YyqwevlwQF7atrwGXOx0XuAfkBnzqG9paKP0ipGrFRTUykhS6Sh7xFV7hmfp6AV3qxyIFjxhoXwCV4mtMGAF3c43W4gB6/Zbi9B+Q+RqJtECjRZyH22/1DZPUNxCBqzyicKGkvhU+EVcVyUFvo6t0SfE0kIb+IBcP4ukjq+1dZihxy/W7z+9fYUwcIxAXSbgRlN5zzQFZzvUxGIuAsMp8xir5E86OJwxJlWIfeRcCs9FDU1bejfXdPz1MtFmnh4yPPbv7DjUQ3sXc6R0EAOFgactQObNgLRpJ70qdMNRcX0MYTwSw8SJajLDOaVjLqPHnySEow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <874a28ac-3ae4-a6c6-c230-570be3672441@suse.com> Date: Tue, 28 Feb 2023 09:25:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] build: add crypto/ to SUBDIRS Content-Language: en-US To: Michal Orzel Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230227095315.6483-1-michal.orzel@amd.com> <113d8d74-19a6-85da-8b89-1a21bf95960e@amd.com> <8bb1d032-639b-d6f4-28f7-2f5e5fbcbf4e@suse.com> <23af7286-fc1a-d495-d5af-a137dbc66898@suse.com> <5d2890c9-d78b-69af-fec3-dace8723ea24@amd.com> From: Jan Beulich In-Reply-To: <5d2890c9-d78b-69af-fec3-dace8723ea24@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8233:EE_ X-MS-Office365-Filtering-Correlation-Id: d3d7d5cc-ff56-4c19-4784-08db196560cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1450xiH66ATGIF5NgNue0Xhr15mWiebe3b1bBg3z4Y8530jEaHUj3hJUR9P3NPM1iipIjzEH8hcUaEUAfe6687sO13m7IvwcJOv27sG/UBRxZSOfPIDusd15NMrSLFwxQVP0VUgngEHG2GVSKCrcuqSyr+hydIrR5pTuSoOpmRECCRJrJGfStC35krQDHeYPhKO0AJFqzMzbqb7ggbyb9MnpH8QZcAByCgmp+wqSnpVUU7nl/Xbijqny/2Xwc4urgrnxvateS9BidHTQiUeuujFGZA0e0IBMNALVN2Z8GnW5MWhP2xTBLBPI99YSXvgPxs4j5zA18wEJRfsLRcN/rrWzHLLTz+JRoHqTjxiFbCy2ZqfjlWWAMcjKPZwolZYnRwR5gIGyRmN9L9IJGXtKSlxqeahOyG1zl5HUK4m8vEAeoCEt5z/M0ucesq/vfbjsexEUWfnBQD4M3linjdbv0CvwTLz+5gAAH3DxEhVXiTGypOXGA9qtQVxzZqSoemPHyPYA3nke9KKAbEUBaLu56MBS6OhhJDI1GstPKd892R5ou4UIcFnQ3Rhxn725Lx5RRgSx0/m9YSckZf5m95Tb27MonrUBhXkvmZsDj4qeQFOF1tmwiVz54PBS3Lo96SClOykcWG/bGH5aNtE+TJOwKzdHejd6YKc2BXTg1jpEfR9v97/kELSjJeM1HhUruZIOFxdhZskY/nrcxDeEbhPXp0TxRBrSf2bS0AVNHPR4p7c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199018)(31696002)(86362001)(6506007)(26005)(6916009)(36756003)(186003)(53546011)(4326008)(8936002)(66476007)(2616005)(66946007)(6512007)(41300700001)(5660300002)(54906003)(83380400001)(6486002)(38100700002)(66556008)(8676002)(478600001)(2906002)(316002)(6666004)(66899018)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDlCOEIxVUlrZFVKK00zamJmZ0d2VHVRMFJnamNqNUdCQ0o3dmRSbzhjcDNY?= =?utf-8?B?Ky82bVRxTFQrOTZ0eXdrVFpYTGIyeWJQYmxDZlM1a2NYTllrOE5USW91UkdM?= =?utf-8?B?T3VzVzlJLzJUS05SWEtrWk9qcFB3emFZZXpqS0tNVHlmM21rYm5XRDYyd3l3?= =?utf-8?B?ZktOWXhjcmVqNkFBRXRKSGRyLzE0bjVaT0RKV3FzM3NVc2ZXMTdXeEFsUDI1?= =?utf-8?B?dzdydXBGcWp3WUNkUXZGZC9FMHhOS1pnSUNRMGFtNmFpZzYxWDArd3BPTEVq?= =?utf-8?B?aDZTUisrK3FlcklGRGxOaDlxZTcrV1N1R1ljam9WWC9XakE0M0ZOcVF5enQ4?= =?utf-8?B?RUw5aEp6cDNnY0NvVGhKQ3ZUeXl4THlGVFdlRndLbzJVb3pOano3cVd0YXZN?= =?utf-8?B?U3duMktUa1NXYWNvaldKUXZFQkhTQ2xnY2NtWjRUWlNsR3cxZDZtK0krQVVr?= =?utf-8?B?ck9jNWNlRHN0NHdNck1oU21XRkVvNS8vam9yMUxoQTJYNFlTUHVIazFPdzlB?= =?utf-8?B?QVVhTis0NExCMWZRdnIxNHZTb1N0S2RIMnVXTWJzcHgrOXNabTZIb0RjYW1H?= =?utf-8?B?NGN4WWsrd3RyTjQwYWUzaUJwSDIrQ0U3cDRPMlZTWHM0TFBHL2pCdkM5dGZP?= =?utf-8?B?eC94ZWVxQnRLdUhOaXptZUh3K1daaE9CWFhFQjVCdHZQZlRWM0QxaTNDcHFv?= =?utf-8?B?YnJuaFB3b2pDOERncUljMktTTEhlWlAwMXp5VFRhUlBGUkg3WE5LeFFzZ2g0?= =?utf-8?B?am1ZWGRhOVlvb1JHZUE4c1Q0OWtNL3YrSHRPbzc1RXJBRjZPMEREd2N6R09r?= =?utf-8?B?UDk0MmV5YWVGNkRXYVpkT0NvRnU2YW13NThJSzZ0c2hiV0dVOXE1d2NPZEZk?= =?utf-8?B?SmRjMmUzaTNGd3VteFFlbFhXNzZ1VHlqcHJ4S3pISG94Qzk3OHVZZGJlc0RE?= =?utf-8?B?aTVRRitZampFR3NOaEZnQ2E0M292Q1hLanhsYjhJTEdMMmVoTCtnSzdIb2Ns?= =?utf-8?B?LzJoVncwVmF3ZnF5Nm5NMU16QzhST3pIVm9iK3pjREZyTk1lTzFKZGJjV1Qr?= =?utf-8?B?d1hPTk5ldko4RzhyQS9yRnpiT21yRWVLQThOMngvemZrbGJPRUNHK2xybVZp?= =?utf-8?B?QnlLdHVObytacmliVk5TaVpweEZiZitKMkIyR2txeThBL0E4Q2ZTU01nNlhv?= =?utf-8?B?dXQ3N3Z2NndJaUNLUzlIdnhOZHBJVWpJY0VyZTFMZC9qVWd1TGVibXNmcDAy?= =?utf-8?B?VkR2bWhhdFZIOW1PWkFrcGZPdEVNN3Jad2JOUVRzblYvUi9rTzd3YUFQLy9q?= =?utf-8?B?Zm5YQWYwSXY5ZCtPK3FuWW5ZUTFKU05JRFcxMEJZbHd3d3MrcDBROXRqeHFX?= =?utf-8?B?SFZuRVFkMGZJd0Jkd1IxRWluYmJQaUlMZ0lnbmVlYWJXaGptS3p4NW1oZ2xG?= =?utf-8?B?UTNEZ0hSM2xpdjVuRjdKaVNqTGY5M1ZkS2dxSllzckpzZnAyakpDQnAxZk84?= =?utf-8?B?eHJXT0pBZkduZHI5dzNvV3hnUUduTzFJUFdwYndMVitCdDBLbWdKcmxUb21R?= =?utf-8?B?VGFIQldoa2lkYXZOOGZOYllCZWNRSytYbDh0YUpZR01ybG1pT0puZkh6NTNX?= =?utf-8?B?VVRYSCt3cm1Kb0NFMFUzcG80YnMrbytka1F0VGNYZXpMS1cxWkphZ2hmNDY2?= =?utf-8?B?OFd6QTh2b0krM3BWU01RcDBXRDVoQUhDb2NEWWRMRnZWaWx1TlhTL2U4ckRq?= =?utf-8?B?dzRIdWh2SmE0S2xSbzhNektBaU5RcW5rblNjU3J6N1NMRFFrSHQ1WFk5TUFN?= =?utf-8?B?YWJGRmw3aGdOMkNJNkZJMGdlVWhKTDJtNytwM29uc1pZbFFHaTVhUXRSaUdi?= =?utf-8?B?RlFqSHc1RUo3anFNSEpjKzZVcU9qMUx1aEQzdWtQNWtteHVyb3ZJOGZpSDQ2?= =?utf-8?B?Ujl3YVVDRnAydG1vQi92MGhtY1Vxd3VpeEVLN1pwenVOc0Z6cDJoNkFXbVFY?= =?utf-8?B?dGphYUVWLzQ2MlFFWnFYZHAwelZGN21qYmNrL3lOV2sraW4wdk9Eemc0WjQ2?= =?utf-8?B?K3NhelR6N3F6VkRPMnZMend1bjlSZEk2Uy9KYWZvbzNEWlRVMjBXRTI5RGN6?= =?utf-8?Q?av5Z8hHqFY+2iMAGNU0JlxozV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3d7d5cc-ff56-4c19-4784-08db196560cb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 08:25:41.1414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jQP6zE1hpEltRD0UE1wSyfOocB0H9h4lisbF1oITPJZKVtlQPAwUshEDHU43dBk9wV2LbDhIMO7ZcZ8uEHGQUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8233 On 28.02.2023 09:14, Michal Orzel wrote: > > > On 27/02/2023 16:57, Jan Beulich wrote: >> >> >> On 27.02.2023 16:46, Michal Orzel wrote: >>> On 27/02/2023 16:00, Jan Beulich wrote: >>>> On 27.02.2023 15:46, Michal Orzel wrote: >>>>> On 27/02/2023 14:54, Jan Beulich wrote: >>>>>> On 27.02.2023 14:41, Michal Orzel wrote: >>>>>>> On 27/02/2023 11:10, Jan Beulich wrote: >>>>>>>> On 27.02.2023 10:53, Michal Orzel wrote: >>>>>>>>> --- a/xen/Makefile >>>>>>>>> +++ b/xen/Makefile >>>>>>>>> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE >>>>>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>>>>> >>>>>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test >>>>>>>>> define all_sources >>>>>>>>> ( find include -type f -name '*.h' -print; \ >>>>>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>>>>> >>>>>>>> As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo >>>>>>>> also only be included when selected (or at the very least only when an >>>>>>>> arch might select it, which afaics is possible on x86 only right now). >>>>>>>> >>>>>>>> It would also help if in the description you made explicit that SUBDIRS >>>>>>>> isn't used for anything else (the name, after all, is pretty generic). >>>>>>>> Which actually points at an issue: I suppose the variable would actually >>>>>>>> better be used elsewhere as well, e.g. in the _clean: rule and perhaps >>>>>>>> also in the setting of ALL_OBJS-y. (That'll require splitting the >>>>>>>> variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and >>>>>>>> $(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which >>>>>>>> has caused crypto to be missing from SUBDIRS. >>>>>>>> >>>>>>> I think what you wrote can be split into 2 parts: the part being a goal of this patch >>>>>>> and the cleanup/improvements that would be beneficial but not related to this patch. >>>>>>> The second part involves more code and there are parts to be discussed: >>>>>>> >>>>>>> 1) If we decide to create ALL_OBJS-y from SUBDIRS, then we would need to carve out test/ dir >>>>>>> that is not part of ALL_OBJS-y and add it to SUBDIRS later on. Also, the order of ALL_OBJS-y matters >>>>>>> for linking, so we would need to transfer the responsibility to SUBDIRS. The natural placement of >>>>>>> SUBDIRS (including SUBDIRS-y, etc.) would be right above ALL_OBJS-y. However, when doing clean (next point), >>>>>>> need-config is set to n and SUBDIRS would be empty. This means it would need to be defined somewhere at the >>>>>>> top of the Makefile (thus harder to make sure the linking order is correct). >>>>>>> >>>>>>> 2) If we deicide to use SUBDIRS for _clean rule, then we would need some foreach loop, right? >>>>>>> Apart from that, there are other directories that are not part of SUBDIRS i.e. include/, tools/. >>>>>>> Together with SUBDIRS variable, it would create confusion (these dirs are also sub-directories, so why >>>>>>> not having them listed in this variable?). Also, I can see that we do clean not only for $(TARGET_ARCH) >>>>>>> but for all the existing architectures. >>>>>> >>>>>> I understand that the changes would be more involved, but I disagree with >>>>>> your "two parts" statement: If what I've outlined was already the case, >>>>>> your patch would not even exist (because crypto/ would already be taken >>>>>> care of wherever needed). >>>>>> >>>>>>> I would prefer to stick for now to the goal of this patch which is to add crypto/ so that it is taken >>>>>>> into account for the tags/csope generation. Would the following change be ok for that purpose? >>>>>>> >>>>>>> diff --git a/xen/Makefile b/xen/Makefile >>>>>>> index 2d55bb9401f4..05bf301bd7ab 100644 >>>>>>> --- a/xen/Makefile >>>>>>> +++ b/xen/Makefile >>>>>>> @@ -589,7 +589,9 @@ $(TARGET): outputmakefile FORCE >>>>>>> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h >>>>>>> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)' 'ALL_LIBS=$(ALL_LIBS-y)' $@ >>>>>>> >>>>>>> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test >>>>>>> +SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>>>>> +SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test $(SUBDIRS-y) >>>>>>> + >>>>>>> define all_sources >>>>>>> ( find include -type f -name '*.h' -print; \ >>>>>>> find $(SUBDIRS) -type f -name '*.[chS]' -print ) >>>>>> >>>>>> The fact that, afaict, this won't do is related to the outline I gave. >>>>>> You've referred yourself to need-config. Most if not all of the goals >>>>>> SUBDIRS is (currently) relevant for are listed in no-dot-config-targets. >>>>>> Hence your change above is effectively a no-op, because CONFIG_CRYPTO >>>>>> will simply be unset in the common case. Therefore if an easy change is >>>>>> wanted, the original version of it would be it. An intermediate >>>>>> approach might be to add crypto to SUBDIRS only when TARGET_ARCH=x86. >>>>>> But neither would preclude the same issue from being introduced again, >>>>>> when a new subdir appears. >>>>> I understand your concerns. However, I cannot see how your suggested changes >>>>> e.g. making use of SUBDIRS in ALL_OBJS and _clean would solve our issue. >>>>> They would reduce the repetitions (hence I called them cleanup/improvements) >>>>> but as we want to keep tags,cscope,clean as no-dot-config targets, >>>> >>>> I, for one, didn't take this is a goal (perhaps for clean, but there ... >>> So you would suggest to make these targets (except clean) .config dependent? >>> >>> >>>> >>>>> we would still not be able to use: >>>>> SUBDIRS-$(CONFIG_CRYPTO) += crypto >>>>> and use it in all_sources (because as you pointed out, it will be a no-op). >>>> >>>> ... the problem is obvious to solve, as outlined before). >>>> >>>>> Also, why do we care so much about guarding crypto/ if we take into account >>>>> so many architecture/config dependent files for tags/cscope (e.g. in drivers, >>>>> lib/x86, etc.)? >>>> >>>> Good question, which I'm afraid I have to answer with asking back: >>>> >>>>> If these are no-dot-config targets, then we should take everything, apart >>>>> from really big directories like arch/ ones. >>>> >>>> Why is arch/ other than arch/$(TARGET_ARCH) to be ignored? And if it is, >>>> why would crypto, used by only x86, not be ignored? As always I'd prefer >>>> firm rules, not arbitrary and/or fuzzy boundaries. >>>> >>>> Furthermore, considering e.g. cscope: Personally I view it as actively >>>> wrong to constrain it to just one arch. That'll lead to mistakes as >>>> soon as you want to make any cross-arch or even tree-wide change. Hence >>>> it would probably want treating just like clean. I can't comment on the >>>> various tags (case-insensitive) goals, as I don't know what they're >>>> about. >>> The useful thing about generating tags/cscope per-arch is that you can limit >>> the number of findings. Each symbol leads to one definition and not to multiple >>> ones. But this is still not ideal solution because doing this per-arch >>> and not per-config leads to inconsistency. Also, as you wrote, sometimes it is useful >>> to have all the symbols loaded when doing tree-wide changes. So in ideal world we should >>> have an option to use approach or another. I reckon this is why Linux >>> has a separate script for that which allows to set all-arch/per-arch, config-dependent/config-independent. >>> >>> Anyway, I do not have any ready-made solution for this problem. >>> The only benefit of this patch would be that the symbols for crypto/ would be visible >>> in cscope/tags (TBOOT uses the crypto functions but there are no definitions present >>> which may be suprising for people using ctags). >>> But I can understand if you do not want to take this patch in, due to all the observations above. >> >> Well, I'm not outright opposed. But I definitely want to hear another >> maintainer's view before deciding. > > While waiting for other maintainers vote, I would like to propose an intermediate approach > that would at least result in unified approach (related to what you wrote about constraints): > > In general, there are 2 *main* approaches when dealing with code indexing. > The first is a "tree-wide" approach, where we do not take Kconfig into account. > The second is a "config-aware" approach, where we take into account Kconfig options. > > At the moment, in Xen, the approach taken is not uniform because we take all the directories > into account except arch/ where we take only $(TARGET_ARCH) into indexing. This makes it difficult > to reason about. What is the rule then - how big is the directory? > > The intermediate solution is to switch for now to "tree-wide" approach by modifying the SUBDIRS > from: > SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test > to: > SUBDIRS = xsm arch common drivers lib test crypto > > This way, the approach is clear for everyone and we do not make any exceptions. Also the name of > SUBDIRS and all_sources makes sense as they are read as "global" by default as oppose to e.g. "all_compiled_sources". > In the future, we can then add support for "config-aware" approach by taking into account Kconfig which involes > more code. > > Benefits: > - clear approach, no fuzzy boundaries - all in > - crypto can be included right away as well as any new subdir without requiring to fix the infrastructure first I'm okay with that proposal (albeit if you make a patch, please have "crypto" at least ahead of "test"), but it'll need agreement by people actually using any of the affected make goals. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:30:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:30:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503108.775264 (Exim 4.92) (envelope-from ) id 1pWvNg-0006mY-SX; Tue, 28 Feb 2023 08:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503108.775264; Tue, 28 Feb 2023 08:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvNg-0006mR-Pl; Tue, 28 Feb 2023 08:30:40 +0000 Received: by outflank-mailman (input) for mailman id 503108; Tue, 28 Feb 2023 08:30:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvNe-0006mL-R1 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:30:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2cd2aa99-b742-11ed-a550-8520e6686977; Tue, 28 Feb 2023 09:30:36 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7697.eurprd04.prod.outlook.com (2603:10a6:20b:2d6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 08:30:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 08:30:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cd2aa99-b742-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpmXQOg07UfoaNStzobtvmhaw5PzWmNgAObeoA8PWn25pwMhuM6l35M7Pk0LEwLRTe5tGRuf7/VR6j42GaiiMcKeRgHm2BxgoJmnR+K3XMPJVMeI6+Wl/qQAbePDqidG9G5v2aPf81KIHjCxX+sS3X0pwrWcrOcTdMc8UxUWVfaQTnYueo0ziwv1qBsl2Ty1z1dBWm+5HNlW3nnNdF7W4ewX1GqEUMSNge2hyS2HV7mvJlxPjm420Ldp5vyy7dTW5y9C3tQyAxcedRKfXvF+p7++x9UgQXG+ds6igTMSF5UCUkesEQ+LbDS2mcJrkOzpZQNHNnSWWfQZABfcbJVMzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iwf21ZBreCLvl8McYUksuSerg7uKP6mlEmgasvp9ifQ=; b=EzY52TvSjhXhDj2zTvwBI4R+i9Na5M9YsC0y1dWYv5LCECHxH+qpxInyOPjz8Kv0jAajkJeUHIjX1c2Ye+0HomUVLd3zZQAg35T5b8kzpg3RESb0G0R3DBeNLFzVGaCJWQlZhFENDbw4Lsbte0k7ah1PSobzbwVgZE8C6PuKEDESnlaZEMTpuqk6XHRa2OjWWkbUePkmkPoJy0ZBtabUGGkOLHCpKQXm3m9ZtS0tal/UuZsWdl3KXziesnvD43EebZIQFOWehlbg4IGhUYxRYaxjZ+bXTOJDZegYcglgXnzdAUHKuvVwKJzK2jYmKPafBJIJNYRVVdO9nFUE6I18+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwf21ZBreCLvl8McYUksuSerg7uKP6mlEmgasvp9ifQ=; b=To3qr9kxPpkn+d+kYv3U28jE9F5BeoQvSvGtCySGF8hzek1+MsWPEnchnE8iy2uMgR053Dmg5rVkAtqJKIc9LyTkX7vWpjiqnuQUWDWeHgey1Ahrdwad59EoKniJR3mGwb9ETAXGVwm9gf0oU7dJkS1y+8maulISRKIbB1qOMOj8toUgDDH4FleM7ZPTOeF9tOJG+hsL82HUh0qbMQAoRQkrG9YGdch1fyBM4106jQkhDF8+0gf5aR0HKPIYjNhCInwtNfTdy6xF/ODpPp/mhET112JtpSQMavjSS1OwqcQq6BW1ARr36KetY4vRKV0Jar40oGdAwXpFjJ8EY9Z1fQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 09:30:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] core-parking: fix build with gcc12 and NR_CPUS=1 Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , "xen-devel@lists.xenproject.org" References: <3e72f386-7afa-84a5-54c5-14d17609dac7@suse.com> <3ca0416c-0d16-1345-0d42-6c66759e477a@citrix.com> From: Jan Beulich In-Reply-To: <3ca0416c-0d16-1345-0d42-6c66759e477a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7697:EE_ X-MS-Office365-Filtering-Correlation-Id: a0c4e4e9-a6c0-412e-ae12-08db1965ff65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ufnsolse4lmln8KlCowRv2xzCh0RnPY2d64OLLsIHb6KpK12NR5Mhrqrk3u+C/wHNYE96GifpLqgH3RQCUVVnuLaFiQT9AOhkBWoK7NbCr1+ismcBJJRFzqIszaFbaABTIvAxjRruGjRU3ipNc2J3QWEX/bxELu6dxdiiiNabPlAP2wvJLk3V76aixxy8p2qprLbGiYVa/Ly84QYJps2msHfnRwLIYqyhPfw5SOVP0IYu5zlCdbdkYgOXCROUAq1dQv7ht9NGZlMsQg9+nh0Q1nrAfUf9GUwF7gaeqg8tN1iqTxYzKvNplxMQM/4OzVyybqXybsHRS6Slf6w4p3XZYyDOxXBeLCEFRFbJXtTvqfP6BopM94rIxg8UJ3S3SqL7GO+2beEAdqfpBgH0ToFijk/UmYRYXwJ6+Izqebz2A4GCBt40cJt8u0MxDm813WgEa+3EPiNX4CfyzdOvMeZtklnIFlUGAgGnDrLDP8OZ5nHgQZkK7ujHjhrftC5PcVF1L1l4H1t1XVtupNChRskYLobHri1v8q++IM/mgGvNI8bPRUUcRHGz8FQ+sHl1zbxSXZ0Bh4Lsq9YYhHdtk6eaiX5UDGyw/4ZkaLhqwuAOIuIgeNJIL7wlQqeG8dhAQWQxZq1LGoEaCrr5QVg3AmOjf7EAqcUk5Ws4heBJWIGT6mre1nHLjP0IBEb7PlUVU5SGbjU75RloPsFhwKhQSCM9CQtI28PJE4e6V0qO6eoJ/g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199018)(31686004)(86362001)(36756003)(66476007)(66946007)(66556008)(41300700001)(8676002)(5660300002)(8936002)(6916009)(4326008)(2906002)(31696002)(38100700002)(6486002)(478600001)(54906003)(316002)(83380400001)(26005)(2616005)(186003)(53546011)(6512007)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzZPUFZ0UHNUK3lPSTl6TFRwcE1aNjFZaG1TVkkyZzdaYUkxU2Q0bkJ0Yk1q?= =?utf-8?B?aGVnTEV3L3lHUDFKMXppbWoybkcrZy92VWx2bWlXR1JWWHd3UjExM3lWL2x4?= =?utf-8?B?c0VveG14YmJkcE8welh3VElZQ2FRTWdzTUZRaUtpcGF2V2JrRzBEeFVNOUth?= =?utf-8?B?dVZhQXBtQmo1MXBxWUwySFRLWDZxZ1R4Z1BjQ05NcDQxUXpXTmJ5eVl4YkdX?= =?utf-8?B?OFo2a1VuUVlDbXdWVjBYNGlnRWNzRllQamlEV1dBUFkxSlA4ZGZ2eUlEZGZy?= =?utf-8?B?bGt1LzhYQWpBcElDNmZ3bWNUUmlubmxiWVBLcHZDRGJpVngwREZlbjJtUmZL?= =?utf-8?B?WjJiRkptSk56VHBnWjdqKzYvbFl4YnEzcEJUdUZFemV3bmJoTnZOeFY4aDZw?= =?utf-8?B?bjdoTC84YnlUTHZtL1ozaDNzSUxqMDExR2dMMDRybk9oRDNKWWlYdHNkdGdL?= =?utf-8?B?cThDNjN6Ylo5d1IzMyt6cEZXOXJVbUI3aDBwWEFwUFZXTG50eTVvUTU2elU1?= =?utf-8?B?dWhEVW5MY2crYWpIYmY1eUtZSFB6QTc2TUxuTU5wNVhSZCtKcDQ1SFl0ZEU2?= =?utf-8?B?aFZhUVJaYlBUQWhYMnVZUnZ6aEV0RTIwc1MxcmFlWkQ3dS9MaE5sMHoyYVoy?= =?utf-8?B?dEQ0WTBIU1diNTRwSG5VOWRzSlRwdmtDZjErNzlEU05wQXBGVkQvZGVNTjRk?= =?utf-8?B?NWlPMDhaZ2dSZVVEa1NncFFTMHREb2tNaEpsRDVZQVd6cUMzNE1rbjNEOEZS?= =?utf-8?B?elpheXpvZjhuL1F3WHJSSG5jV2hXM0NNNVZYcDVHZ2dKaXc5ck9HK0lFM1d2?= =?utf-8?B?L0NsOXYvQjdRdUx6WUtVbTlBWFN3TkU2TUMrTW8wVlRDQmMrMHBrdkdMSmxz?= =?utf-8?B?c21LTE1CTlVHSEFUVnVGOHRUZ003YVlpcllUbTIzOXpZY25FcTFlS09YckJs?= =?utf-8?B?WHlRT0dYNFRjWERvOFNENjFKU3NmTnNWaUY1UmI4NFJqR3RhQ1lhcEZvb00y?= =?utf-8?B?eFl3YXk5ZHFXUHFrYkprM3UxNjdLUldMalc3VU9lVnR1RGxqemI4ZGdyUGM3?= =?utf-8?B?WmhrSUYrNndzOVZDdnpjczRsWm16Q2dsTGc1WUllQmNtT1JhSmlFcURqYUtX?= =?utf-8?B?NWZYSzYweXhCOFdDQlVyTGczeXEwcXpteVNSMTVhV05xTHRwUDBreTJyTUdq?= =?utf-8?B?cDhJZGtuUUtpZENuNzNrNWFnd0dlcXU3WjZ2ZHlMY0p6UTdyYzdaT3dOTUxp?= =?utf-8?B?bHRxWkpGbjlOQTZOVGEzQk1ta0NkSFlxaTVoZ2hCdS9sbWlQb1JpMHNITEV5?= =?utf-8?B?Zk9sRkVSTDNhR0cvb3BpVENmYjk5NXliVWg5SjFPMU5wQTRCMG9qZHRCWFRr?= =?utf-8?B?Y1N5ek12dHdmejRSN1N0YVlCYUJhcFB1c2U3OUFMNjFZREVHQkZwNWIzUXpl?= =?utf-8?B?WVQraXovMkQ5b1hyb2NROGFzQUhmKzJmUlZYZ1dNeU9XckZiR1VkUXJweHZo?= =?utf-8?B?Y1l6NjBqR21rWGZLS0JWS29DbkkySnJIVFJkYXNBL3pDQkIweTBqbjArTUdM?= =?utf-8?B?dzNzQWQ4M2ZrQUQvL2wyVzQ3QXIxR2JxcEFla0xBY3g0Z0hNNEhkMFArRllw?= =?utf-8?B?eC9VelRxRk52UHh4OUJLWjZ2ZFUyRFI5bWYyMEtSMzdqck0vV3RHVHZnZnJz?= =?utf-8?B?eEdSNlNDekwxSHVzK0RjLzRNU1lZV2tJaVZHSGV2T0hTbE9EeTJUU2hPcW5B?= =?utf-8?B?NFR0RnVLQkx4RmNqaFQ0ZlpJcGZveVd0L3JEVFQzRFo0YVpySFA4UnlhUnpy?= =?utf-8?B?N0o5bGlRYUFxRzJWZms1Z29mcXowZDUzc2s2MnhsY2c5clpacTArTStJaUdT?= =?utf-8?B?QzRvdFZqdWEvRUdHaXloQXA5Y0N1QlhJelkrTTFlRjNKL3ZueXhxbklwSjFE?= =?utf-8?B?UlRSMGhyeUt2MlBNWHNmdC96UlJHNUZ0a1FyYmV1cU1wQmROVzNmbnB4b1ov?= =?utf-8?B?elkvdFA0YVlGOHRoKy80VThYTUtVSVdZRk5SckdoOEN6aHZqWkQwVUdIVC9N?= =?utf-8?B?Qkh2a3FzaGZiSmMwTmRzUFB5MFNvZHhOR2o0MGpidnIrcHlEUzIwdElZWEVu?= =?utf-8?Q?BdqXajeZW7zjXfkzT+E3GGGVk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0c4e4e9-a6c0-412e-ae12-08db1965ff65 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 08:30:07.1708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vIlbJ/WJ81HYBHK3fixUnuePME84HVOUEd5WzrCfb0hW6yRgbX0DLKsugLpEh71eInZoOt420UufRrPHwb4big== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7697 On 27.02.2023 20:43, Andrew Cooper wrote: > On 09/09/2022 3:30 pm, Jan Beulich wrote: >> Gcc12 takes issue with core_parking_remove()'s >> >>    for ( ; i < cur_idle_nums; ++i ) >>        core_parking_cpunum[i] = core_parking_cpunum[i + 1]; >> >> complaining that the right hand side array access is past the bounds of >> 1. Clearly the compiler can't know that cur_idle_nums can only ever be >> zero in this case (as the sole CPU cannot be parked). >> >> Arrange for core_parking.c's contents to not be needed altogether, and >> then disable its building when NR_CPUS == 1. >> >> Signed-off-by: Jan Beulich >> --- >> v2: Disable building of core_parking.c altogether. >> >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -10,7 +10,7 @@ config X86 >>     select ALTERNATIVE_CALL >>     select ARCH_MAP_DOMAIN_PAGE >>     select ARCH_SUPPORTS_INT128 >> -    select CORE_PARKING >> +    select CORE_PARKING if NR_CPUS > 1 > > The appropriate change is: > > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 6a7825f4ba3c..2a5c3304e2b0 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -10,7 +10,7 @@ config X86 >         select ALTERNATIVE_CALL >         select ARCH_MAP_DOMAIN_PAGE >         select ARCH_SUPPORTS_INT128 > -       select CORE_PARKING > +       imply CORE_PARKING >         select HAS_ALTERNATIVE >         select HAS_COMPAT >         select HAS_CPUFREQ > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index f1ea3199c8eb..855c843113e3 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -10,6 +10,7 @@ config COMPAT >   >  config CORE_PARKING >         bool > +       depends on NR_CPUS > 1 >   >  config GRANT_TABLE >         bool "Grant table support" if EXPERT > > > The core parking code really does malfunction with NR_CPUS == 1, so > really does need a hard dependency. > > It turns out our version of Kbuild does understand the imply keyword, > which is the right way to spell "I want this feature unless something > else happens to rule it out". I've switched to that; as said in the private discussion we had, I simply didn't know of "imply"; I've never come across a use so far in Linux. But ... > As noted in the kbuild docs, select should only be used for immutable > properties (this arch has $X), whereas imply should be used for all "I > want $Y".  Most places we use select ought to use imply instead. ... I agree that's what we want to use here and likely a several other places. >> --- a/xen/arch/x86/platform_hypercall.c >> +++ b/xen/arch/x86/platform_hypercall.c >> @@ -727,12 +727,17 @@ ret_t do_platform_op( >>         case XEN_CORE_PARKING_SET: >>             idle_nums = min_t(uint32_t, >>                     op->u.core_parking.idle_nums, num_present_cpus() - >> 1); >> -            ret = continue_hypercall_on_cpu( >> -                    0, core_parking_helper, (void *)(unsigned >> long)idle_nums); >> +            if ( CONFIG_NR_CPUS > 1 ) >> +                ret = continue_hypercall_on_cpu( >> +                        0, core_parking_helper, >> +                        (void *)(unsigned long)idle_nums); >> +            else if ( idle_nums ) >> +                ret = -EINVAL; >>             break; >> >>         case XEN_CORE_PARKING_GET: >> -            op->u.core_parking.idle_nums = get_cur_idle_nums(); >> +            op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 >> +                                           ? get_cur_idle_nums() : 0; > > These don't look right. > > If the core parking feature isn't available, it should uniformly fail, > not report success on the get side and fail on the set side. I disagree. There's no reason to report failure when we can fulfill a request. Note also that "set" doesn't unconditionally fail either the way I've coded it. Both are so people won't have to special case single-CPU environment higher up the call stack. >> --- a/xen/arch/x86/sysctl.c >> +++ b/xen/arch/x86/sysctl.c >> @@ -157,7 +157,7 @@ long arch_do_sysctl( >>         long (*fn)(void *); >>         void *hcpu; >> >> -        switch ( op ) >> +        switch ( op | -(CONFIG_NR_CPUS == 1) ) > > Extending what Julien has said... > > We use this pattern exactly twice, and I would probably ack a patch > disallowing it in the coding style. > > Its a trick that is too clever for its own good.  To anyone who hasn't > encountered it, its straight obfuscation, and even I, who knows how the > trick works, still has to reverse engineer the expression every single > time to figure out which way it ends up resolving. Well, I've replaced it then. Will send a v3 in due course. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:41:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503121.775274 (Exim 4.92) (envelope-from ) id 1pWvYL-0000KB-0x; Tue, 28 Feb 2023 08:41:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503121.775274; Tue, 28 Feb 2023 08:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvYK-0000K4-UK; Tue, 28 Feb 2023 08:41:40 +0000 Received: by outflank-mailman (input) for mailman id 503121; Tue, 28 Feb 2023 08:41:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvYK-0000Ju-8s; Tue, 28 Feb 2023 08:41:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvYK-00033i-6z; Tue, 28 Feb 2023 08:41:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvYJ-0002RY-QT; Tue, 28 Feb 2023 08:41:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWvYJ-0000kV-Q4; Tue, 28 Feb 2023 08:41:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2hBGkzcYYQO6zCBN3ZC0R/Jp7Ox8bbCSZHUzT8ikKfc=; b=CJsXwpyiDYOl9Djw5GidkyTy0H 3Cia2W73rrVbfMJxM/Q+YncqlAq/wf4OtFDxv4UZnKDjSZZuJWECPLwkTGnbftJXWh9ceOybHawI8 9ZEufE7KRW2WPFOu5YK7m9cGhRMre4rtr6sff6Od/5OAD5hXToMojVF+JiUvtzTPGsOc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 178706: regressions - trouble: fail/pass/starved X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:guest-start:fail:regression linux-linus:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-vhd:debian-di-install:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-examine:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking linux-linus:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking linux-linus:build-armhf-libvirt:build-check(1):starved:nonblocking linux-linus:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: linux=5ca26d6039a6b42341f7f5cc8d10d30ca1561a7b X-Osstest-Versions-That: linux=3f0b0903fde584a7398f82fc00bf4f8138610b87 From: osstest service owner Date: Tue, 28 Feb 2023 08:41:39 +0000 flight 178706 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/178706/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 178042 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 178042 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-thunderx 14 guest-start fail REGR. vs. 178042 test-arm64-arm64-xl 18 guest-start/debian.repeat fail REGR. vs. 178042 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-examine 8 reboot fail REGR. vs. 178042 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 178042 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 178042 test-arm64-arm64-xl-vhd 12 debian-di-install fail REGR. vs. 178042 test-arm64-arm64-libvirt-raw 12 debian-di-install fail REGR. vs. 178042 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 178042 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf-libvirt 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: linux 5ca26d6039a6b42341f7f5cc8d10d30ca1561a7b baseline version: linux 3f0b0903fde584a7398f82fc00bf4f8138610b87 Last test of basis 178042 2023-02-21 17:44:43 Z 6 days Failing since 178093 2023-02-22 05:02:47 Z 6 days 12 attempts Testing same since 178706 2023-02-27 22:43:54 Z 0 days 1 attempts ------------------------------------------------------------ 1919 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl fail test-armhf-armhf-xl starved test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm fail test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt starved test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw starved test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd starved ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 221002 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Feb 28 08:49:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 08:49:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503129.775284 (Exim 4.92) (envelope-from ) id 1pWvg2-0001Lm-RK; Tue, 28 Feb 2023 08:49:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503129.775284; Tue, 28 Feb 2023 08:49:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvg2-0001Lf-O1; Tue, 28 Feb 2023 08:49:38 +0000 Received: by outflank-mailman (input) for mailman id 503129; Tue, 28 Feb 2023 08:49:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvg1-0001LX-Bw for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:49:37 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d22c0628-b744-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 09:49:35 +0100 (CET) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Feb 2023 03:49:24 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5485.namprd03.prod.outlook.com (2603:10b6:a03:28a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 08:49:22 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.027; Tue, 28 Feb 2023 08:49:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d22c0628-b744-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677574175; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=A6UROjBR2d9qS/fSSn8vkPUByq9vxpu2ZFlMxm4T3aw=; b=A/zKOV456CeIso/JrvKiSPM0qKGeh1G5m8QxowwuEqSboXG4RzkGn2R8 NxPWmoavtaCFjGxyOqsBvy6dPoBHvg+n+MnkI8EcKhh+O6RM6hpn3UoKM MyEhtX0Ykoly5wg6Xms2UYMPwKVYZkA3sZIlqEs7ExdsA0nVrtPmpGorX Y=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 101234488 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iip4taps0YX8Mz5+UQDuc8pEbfBeBmIkZBIvgKrLsJaIsI4StFCzt garIBmEbPiOYTb1f4hxOY2//EwPvMCHmtJlHFNo+S5gEiJEo5uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WNwUmAWP6gR5weEzSlNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACE8NB+ylfKz+bO+bftH3ehgNcLAAIxK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSFEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhrqcw2wHPljx75Bs+bgfljMC3tBeHdOluL kAm1AgKv6os3Rn+JjX6d1jiyJKehTYeXNcWEew8wAaXw6HQ7kCSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaMy8PLHREYjQYVwwb+NryiIYphxnLQ5BoF6vdszHuMTT5w jTPpi5ugbwW1JcPz//iowCBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:CvXpQ6nMkozb8KgXe9PeAiIommfpDfLo3DAbv31ZSRFFG/Fw9/ rCoB17726QtN91YhsdcL+7V5VoLUmzyXcX2/hyAV7BZmnbUQKTRekP0WKL+Vbd8kbFh41gPM lbEpSXCLfLfCJHZcSR2njELz73quP3jJxBho3lvghQpRkBUdAF0+/gYDzranGfQmN9dP0EPa vZ3OVrjRy6d08aa8yqb0N1JNQq97Xw5fTbiQdtPW9f1DWz X-IronPort-AV: E=Sophos;i="5.98,221,1673931600"; d="scan'208";a="101234488" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSpeb6g+SXwcrBqBkWpjaem0gkpik49KU45eqYjiaPpXDPsC40Hgd/1CLoAYm/ej6amjuTc71O8847EcPpRHHoQHrbs8MRxhgxBQTNfXdcQ2VDWKJE3UXqD4Yxl/tKSF7EGxc5LCFaW/Kx6+O3irbhAen67sjSviX7AGMTogDMbuI9LvDdM8Pn6kkuzmbiLyPfA9foKt9vUeSYujlYE4B6YgEeqJ0MrQdOZuKVvR+Ed4e89L2xXV47aWzaS/1Y51RJrkgonmWEujOGJ36TdEidr5Qnb5Beh94qZLDIbJdAKzI5Z1OCFfJDUwh+kHSFmkerk4nx9iiSLCWwSQBmLsmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6UROjBR2d9qS/fSSn8vkPUByq9vxpu2ZFlMxm4T3aw=; b=VEWRcP7h1yh66TN8iP/I85ucmYJZ4VAVru7QDBqZnSw66h8W9rqY3J/nqJwm6wDg9iAGBu6e1O7gwj1HlEd1V06osl164w3g51e5DbmHY5q6Ch1lOfyYD8D+Jv43JIVEJfTabgbjQdwl2FTopRS8cAJ+lO1i7rJJjQGHhvZI32M6h72Y7ZNrBXu+8LN3FsHW5PVxoETzWG8QntNpLnN1ROelm/QRhcEO1EvcqFjK3ldrPaYXxdAD/xRbNGSHUk9/3KuXIThfl1PApU7l7q9l1iVi2JmiZqqtSfTSIdjZOo/GDO0tYCrz0wO0r8PqEohaNJFb7+GIqse/x+/UWHDPkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A6UROjBR2d9qS/fSSn8vkPUByq9vxpu2ZFlMxm4T3aw=; b=GDsGjLGrdeGXDezU4euEsg45fyKkK2ZNPzAR17C7cjbdu3p7ejx5uGi2QX+jQ1SuZx9ie/O8tLuWKUS94Ki63Ll8ET5YoBUr3eMouhARl/tBDzWn0eQQmumsnfu4eA2HifJrt/JYSW04GFMLGck++WGOxdHJKLpJu2Lg65oMz+g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <77fd3c1e-603c-ad46-c518-3b5b3311e9f9@citrix.com> Date: Tue, 28 Feb 2023 08:49:16 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: Is xl vcpu-set broken Content-Language: en-GB To: Joe Jin , xen-devel@lists.xenproject.org Cc: Boris Ostrovsky References: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> From: Andrew Cooper In-Reply-To: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0435.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5485:EE_ X-MS-Office365-Filtering-Correlation-Id: 36accaa7-ca41-44a2-3b15-08db1968afcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eJEkm/q9hrfdlO9q949Xcdq8lYgN7oHVwUjjeHxxykdrLQy2uYcb0VJjiFgicWJ0qF4GKy54nCdG5Vrk8729iS15VNktLqngRzxNPsethpLD0WfrnwfS7alt5sgKBXnOYxsM7Vk2lO8BpSwBeS1upNyXAQIn5YMkwGsif2O9Al7ZCHR26l1PkOiQ/f5vBs3Kjw1KIu2KM+nfk99LUt9LuZNwgWctGvWYbaisgbMrJvntWu8nX69v9hCVCVBaMQJLtByRW8kv3MSftpov+V+FXR6omWagFjbRh1P3Sj1nu6RCPLSSGQul+Lhv8yIx0iNH609f9lJhTPVejetbMa3cGxHZpldz+00vhL0rJdAC5bWGTK07JIK3hEQKzTkMUW7BN1YF4+uyLH/OKdcY7ahyi5geuFm0vic+yaurM5STqaPIN/kyxoLZhv397UVTw/F+xNHj0akzf8aIVC2RLrE/gIDqd6bXfXdiVTqUYyimsuaud2+0MYyriHQE/AXdoTrZBJ33FLu+YPpDfCAcbZib6ykD8J0ZKFOj3GADupND2emh3o6kZiJml2M18z1/0444s/4pnT+ADarMDBN21vrb2vrE8Fgo9cUkVIZybjEwRMQayWhonJMHXW/HZf1OJv/ZAfRGD+FlYa5CRPeteA9Zo441nCrlV1a2QoETAX1DMMNFb725mGNFbXjEyoR4pN8ZG8ukKEEvtD1866CMMkibcv4ius204e9oZXKFsVBHoZM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(31686004)(86362001)(36756003)(41300700001)(66556008)(66476007)(66946007)(5660300002)(8936002)(4326008)(8676002)(31696002)(2906002)(82960400001)(3480700007)(38100700002)(6666004)(6486002)(478600001)(316002)(83380400001)(2616005)(186003)(26005)(53546011)(6512007)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVRhdDVqZTJ1TWJycnRtcTlFU3dIaUdjRlV2aCs3ZXlRbWh0L2Y3Tnlsc0x1?= =?utf-8?B?ZTRKbjV0QldiNFNUeGRGSjhiWWVDdE9vVEN6ME1udDdoQ2xLM0dUZXNBVE90?= =?utf-8?B?QVVvdGJ1cFFTRmNmZ3ZyYkpRcE1wSDVhVTR0OXBncDJjMnFRcHZPTXhNc1RT?= =?utf-8?B?RmptYWJTeTNoMzdhT0xlM0haUExXMDRtandVNW9ldVNhZTN3NW1DaWI4dzhh?= =?utf-8?B?MzF4Z0JlU0Rab3JVcEZScFI4MVdJTVRRWTF0UGdyU0syOEdxTVhqRnZTS0xO?= =?utf-8?B?WUZyRjlhR1RnenhNNmI2UmFCM2Nzd1krMHpDV056YWxJT2VYTUg0NE10VGFq?= =?utf-8?B?QkVqMUQ1YWtjaXhlSVUyaDdCVzZvYlNQZ1VHMWRTWUdDWWNOYk5CdDhOQmRu?= =?utf-8?B?YWtEZjhGbXgyREk2WGN4cTY5ZnlhZlRVVGpSRlZGVnZkMy9sZjhJTS8yNTFy?= =?utf-8?B?eUdVVDdTNGxUdUtPTWZxLzNaTjhGclU5TEVycjZFUlpvNjliby9GQjM3WjMz?= =?utf-8?B?TzVCR1pueE5haEJrck9vbTYrbWdyeU1JR3kxZURRQkNrKy9VUmljY1AwTER5?= =?utf-8?B?cU14U1BKTGhibTZqd2tWOTQ3SWJhOEsyTDI4Y2JOaHJyMjRER3hCK0pIcHYr?= =?utf-8?B?c3VGOGhiWTBZZkEwcHJMVTNvamN5TzZRWkFLdlk4QVNJRWxiL09YMllXd0xB?= =?utf-8?B?K2pvUVNsSWdmT08zRmtBVVRibUxWd0U4WjBybXJNREVvbS9tNWwwUlVBMExj?= =?utf-8?B?TGNhM2NxVHptSVdFM3JlMFJaenUzZlNiQzA5ZkdZVEZZUkVKOXE3WHp2azAz?= =?utf-8?B?UC83SnltT3hoaDZmVkJ3SGREMzB0bGZFUXVCWFNPY3NEMzFBci9kRk0weDZw?= =?utf-8?B?aGVRWjJ6R2lFN3VEUHRtUU5idWlUd052R1BOUUgzZjMvK2NMSGFZOEhmb1k5?= =?utf-8?B?S1dkWkpNNFNNVFV5RzJZR1hmNDZLQmQxSGh0ZzNoNmd0MGtMODVqc1lTeTNq?= =?utf-8?B?bmhRc3crNGR4Mm9jQW9SWk4xTDlKSFl4NFE1bGEzWnRZdlVkd29DVDZGVExC?= =?utf-8?B?cmc1NnNwcWo5dE5iZXZKWVQxd0RHWW9qRHJidkNScXBxaG14R2RBbTBPa0RJ?= =?utf-8?B?REo1bm82aTFva0lpQ21naG5Ja2U1MWRsVXhmczBOV2FsMnAzTzY2RVZ5RTJI?= =?utf-8?B?dnBjek1MVnZ1cXhxQU1COFJvTGNaQVhmbmZ2bmJ3RjYrL2YxZDl5ZVF5ZHV0?= =?utf-8?B?c3ljbzA4U3J5Sk9TYlNVN1RpUXdveUY1ZHYxMzVWd3V5cHpYMXE5K29vdldQ?= =?utf-8?B?NE55RmZNb1NSVklMVnpia0NwODIrZ3l0VlRkTnBmYjQ2T1gveWk5WnJMM3Fy?= =?utf-8?B?MHZVbVJuallnai82clQweEIzeE9sdDB3bFY3ZElGTHBoQjYyK2FraUNlV1VQ?= =?utf-8?B?N2RiSlZUa3ZwNnMzL0loUktwdllXbzlUZ1d5ZDBKWm93d1JsS0JuL3M0dnpz?= =?utf-8?B?akNrU1p0VVpETXB4RHA4UnNpNGJjM0JjUGRJTE5HUitHbUMrMFVDa0lZZ3FU?= =?utf-8?B?TXpmMkw3TlRIQkNRR2p3Z2VvOTBYejZlcHk3dGxVQlFsOE1TZ2pZMWtYWi8v?= =?utf-8?B?VjUycm1OVnRvZnlQWHJKTUV4UHFFaXZqVFpwVVJFZ0lrdWZXeXY5SXRYVHhP?= =?utf-8?B?VXg1Wm5paUQ3YjJNMlpuNGRGa2pGQlRrclVWNDE3c0dLV2JsUEIvTEhJdWV2?= =?utf-8?B?ZWM1eGlTb3dnc0lLcTVQU29lZVFlWGVONnJmL0lqbytWRzZrVHhENXBUaGw4?= =?utf-8?B?UzA3QTRkenpoZVZvUjZONGVEUjJvdWNuZEprRFVteWtQY2JtTWYxbWFDNFor?= =?utf-8?B?VGgvV284emRpMjcvQWI5aXJjbFdzejRUK1FXWWQwclBKMXlsRW82MVF2VkJS?= =?utf-8?B?NHhxNW1NYVNVWVJqMkdQTjcxek1kTmJ5UzN1RVBWLzdRY1ljZlowOWNHNHpw?= =?utf-8?B?QUJXYlFQVGk3R1AzYm80dm9GaDNPWkErU2R6V08vV2M1QmpTWG9XaS9vWkFY?= =?utf-8?B?SWQxd0lQVEpPa0RFZ0V1bUFEV1BKUUhaUUdmL014NXNYZDZ3eVdLVDdkdFlI?= =?utf-8?B?N2RlNGF4cUlQZndqeC94aTBGWWlicElTU3ZSOEpYQ2pTKzVmcm04aVJlR3ZJ?= =?utf-8?B?Wmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Tc0XqbSlZGavS7Zza96IZrdZpd38pH9UbL1DRZZclZRbPi1eFLRSb6kvD3lP1aKUWpUqK1YBIOaXTyvHjP5RTmULDnLDQ48CIkpne1y1g/I3KLmAqRcul50ABCBPq02FYMOn0MMabeW4yVWLNJ/iip7Mjm/6bLkM3uh/dqKxLkuJLOZ1D+d0Jd63g5C143AmKuQWFpj2OOIi3NlSV+dcuDtBLRAcLGZnWSCAU70yJA4pjWj6q6rg8t6UewjZwmmkW8U686u6uTJw6pBEMS3msQBUjeaMyp0kV3FRUqg1JTq9CqjtzzB3tTuEjTnmaixf++u5LI1n2EqpFCWTY0WBeWfN6uD4TxhbhaISFXQgdsGvaRRSzoL3NfhjqwqpkT8lvxsbFA/ReivuALAntUnb4TqXOK4izy4DG8Eb9AUJZYEW2pOM03Hkqj7jXAyoRb8bCgqbIuCxkLP2aEsFkd0DOLLMlYNxMK1nu0gMpkhfLd2h4QYh/BN9O/KwDIkRsSz+QS6X8TFyxnU77qUO7aUlpGg0+MuP3B2DrAIMQol+LmmsqzrBPzMzvxmLFqiKS6BG9ApFuhy0ifpZUUByGDHYJhG+lPZJZpJNLw/a57d3XE17fdD020S5wML6E+nmRIKfpMyBqO4GtdTll+kyvX55vKYp97Wev3mUALAw3/sKBctrsYofYf76QrTMz75WwKrD/4cxxLVHrjh7vyNnxl4NcHRc38IwmBMiPLj+QeOTR3iFs9uzSrDskFCfWzUokQoXvbb+3Zyz9kbbWb6U+w8FlOSHFl7MpKhbtmH5BVTm0F4C+k5tDNqtsyqx9myl3MYg X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36accaa7-ca41-44a2-3b15-08db1968afcf X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 08:49:22.2756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tyoZTISM3R+z6e3DRgllK6IZ1wweiNzL2IzaiHHEeLWQb4SbW/hLeOVb6x1ypHe4LRu4nyLBZkdA+31HkPQr4uf0Y854C+4rLnw7SliGl3w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5485 On 28/02/2023 6:44 am, Joe Jin wrote: > Hi, > > We encountered a vcpu-set issue on old xen, when I tried to confirm > if xen upstream xen has the same issue I find neither my upstream build > nor ubuntu 22.04 xen-hypervisor-4.16 work. > > I can add vcpus(8->16) to my guest but I can not reduce vcpu number: > > root@ubuntu2204:~/vm# xl list > Name                                        ID   Mem VCPUs    State    Time(s) > Domain-0                                     0 255424    32     r-----     991.9 > testvm                                       1   4088    16     -b----      94.6 > root@ubuntu2204:~/vm# xl vcpu-set testvm 8 > root@ubuntu2204:~/vm# xl list > Name                                        ID   Mem VCPUs    State    Time(s) > Domain-0                                     0 255424    32     r-----     998.5 > testvm                                       1   4088    16     -b----      97.3 > > After xl vcpu-set, xenstore showed online cpu number reduced to 8: > > /local/domain/1/vm = "/vm/aa109ea0-2fde-4712-81d8-75f73bd73715" > /local/domain/1/name = "testvm" > /local/domain/1/cpu = "" > /local/domain/1/cpu/0 = "" > /local/domain/1/cpu/0/availability = "online" > /local/domain/1/cpu/1 = "" > /local/domain/1/cpu/1/availability = "online" > /local/domain/1/cpu/2 = "" > /local/domain/1/cpu/2/availability = "online" > /local/domain/1/cpu/3 = "" > /local/domain/1/cpu/3/availability = "online" > /local/domain/1/cpu/4 = "" > /local/domain/1/cpu/4/availability = "online" > /local/domain/1/cpu/5 = "" > /local/domain/1/cpu/5/availability = "online" > /local/domain/1/cpu/6 = "" > /local/domain/1/cpu/6/availability = "online" > /local/domain/1/cpu/7 = "" > /local/domain/1/cpu/7/availability = "online" > /local/domain/1/cpu/8 = "" > /local/domain/1/cpu/8/availability = "offline" > /local/domain/1/cpu/9 = "" > /local/domain/1/cpu/9/availability = "offline" > /local/domain/1/cpu/10 = "" > /local/domain/1/cpu/10/availability = "offline" > /local/domain/1/cpu/11 = "" > /local/domain/1/cpu/11/availability = "offline" > /local/domain/1/cpu/12 = "" > /local/domain/1/cpu/12/availability = "offline" > /local/domain/1/cpu/13 = "" > /local/domain/1/cpu/13/availability = "offline" > /local/domain/1/cpu/14 = "" > /local/domain/1/cpu/14/availability = "offline" > /local/domain/1/cpu/15 = "" > /local/domain/1/cpu/15/availability = "offline" > /local/domain/1/cpu/16 = "" > /local/domain/1/cpu/16/availability = "offline" > > But guest did not received any offline events at all. > > From source code my understand is for cpu online, libxl will > send device_add to qemu to trigger vcpu add, for cpu offline, > it still rely on xenstore, is this correct? anything can block > cpu scale down? > > Appreciate for any suggestions! Your mention of Qemu suggests this is an HVM guest.  Can you confirm? ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:00:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503137.775294 (Exim 4.92) (envelope-from ) id 1pWvq2-0003Hw-T9; Tue, 28 Feb 2023 08:59:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503137.775294; Tue, 28 Feb 2023 08:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvq2-0003Hp-Q9; Tue, 28 Feb 2023 08:59:58 +0000 Received: by outflank-mailman (input) for mailman id 503137; Tue, 28 Feb 2023 08:59:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvq1-0003Hh-Gb for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 08:59:57 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 444c6785-b746-11ed-a550-8520e6686977; Tue, 28 Feb 2023 09:59:55 +0100 (CET) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-JdkdCTXaPuyBe5pGTO3r-A-1; Tue, 28 Feb 2023 03:59:50 -0500 Received: by mail-ed1-f71.google.com with SMTP id c1-20020a0564021f8100b004acbe232c03so12665203edc.9 for ; Tue, 28 Feb 2023 00:59:50 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id ha14-20020a170906a88e00b008c405ebc32esm4229508ejb.28.2023.02.28.00.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 00:59:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 444c6785-b746-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677574793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gh14Q5XVK57GCqNInt9dvGWviONbEUABlkLCEvFo+1A=; b=AaVUWEiihEs1K2QiNVXGFjjsoiK+3Tm6kFC7fiZ3f1lNi1RQ4CUlkEQpRif//e6/AC+KjP 3K00v5ewZzibU0pRoaRCPfWWQkQtiUQ1Fsb8unpJD2H1EMzuuy/oKLiKiKz7POW8CsasVc xT4PxaVNmtxmFC6qv9Z3uWC4B6DdYww= X-MC-Unique: JdkdCTXaPuyBe5pGTO3r-A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677574789; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gh14Q5XVK57GCqNInt9dvGWviONbEUABlkLCEvFo+1A=; b=mL0GxDhTICz/XaWs+SS21LXSHHRPVWNn3cXqGZeuf0ECZWBVpq4Ap/n/HtgwN3v6Vo Ol7A8TAhtAEDdvmpw2z76ua44TPSnobDT3BMADycBM4LlccD2upvtn34HGMm8n1E0TPM HnBcHw8LVnJdnbQdf0p6+ZZ1i9xe9GKTnPB9YbdvCC843WSy9JaG/luxNHEm3o8rpWOt Sn05s0TXdqfENNZEZbquV+qub7f4dvvj3yTAYgMD5jJR4qrdhtVpQM4mnFkMeJ2QVChK Eiic7gK+jSeUrEWBEQX6Y15qjZjKv2C7SgkDvTL2tJNGyPi0o8Q+DqHGP0m07oAjU/cd TrxQ== X-Gm-Message-State: AO0yUKXihplNSxrJrH1+iO/6tvP327LFmNmVzzT7tzKkEkoJ+dqdjWaS UqzxX5Fs71+oJM+XPgcP5QlcH3xR9oxoDGAYrDIavZWBVod58jsS8MbN+BgQsDowWu9egyiVJ6z AXEyB99gPHwujw5Cwh/oxfStI7Ds= X-Received: by 2002:a17:906:264d:b0:8b1:79d0:bc58 with SMTP id i13-20020a170906264d00b008b179d0bc58mr1697110ejc.16.1677574789519; Tue, 28 Feb 2023 00:59:49 -0800 (PST) X-Google-Smtp-Source: AK7set+fUW5AwCYmimNt17fLi6VkNVMvM8T0LSvQi1PwptV14D5OBhXq8nQB0YakRdPxskPQaBqfcQ== X-Received: by 2002:a17:906:264d:b0:8b1:79d0:bc58 with SMTP id i13-20020a170906264d00b008b179d0bc58mr1697089ejc.16.1677574789259; Tue, 28 Feb 2023 00:59:49 -0800 (PST) Date: Tue, 28 Feb 2023 03:59:44 -0500 From: "Michael S. Tsirkin" To: Richard Henderson Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228035917-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: > On 2/27/23 10:12, Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang wrote: > > > I feel like we should have separate deprecation entries for the > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > although they're related they are independant features with > > > differing impact. eg removing qemu-system-i386 affects all > > > host architectures, not merely 32-bit x86 host, so I think we > > > can explain the impact more clearly if we separate them. > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > a superset. > > > > Removing support for building on 32 bit systems seems like a pity - it's > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > and the maintainance overhead is quite small. > > It's not that small. It only works for single-threaded system mode. It > silently does not honor atomicity for user-only mode, which is perhaps worse > not working at all. We should probably block multi-threading on 32 bit then. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:00:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503138.775303 (Exim 4.92) (envelope-from ) id 1pWvqA-0004Cu-43; Tue, 28 Feb 2023 09:00:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503138.775303; Tue, 28 Feb 2023 09:00:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvqA-0004CL-1C; Tue, 28 Feb 2023 09:00:06 +0000 Received: by outflank-mailman (input) for mailman id 503138; Tue, 28 Feb 2023 09:00:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvq8-0003qW-3n for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:00:04 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 489738b9-b746-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 10:00:02 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-unzHq4k8NrGaRGqkhunq0A-1; Tue, 28 Feb 2023 03:59:57 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02EC9299E747; Tue, 28 Feb 2023 08:59:57 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CEF2A2026D4B; Tue, 28 Feb 2023 08:59:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 489738b9-b746-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677574800; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EF5YmrVTXup8974t3suecxHHmZbvsS2aqdc5XTi5Ek=; b=TFeIbr+E02sglU+6eQ+p6KSHvdM5aYW4bedHT0OcqZKOtR1hC+1NHWfE+0GjpXmVHRvjz1 2Eb1a2h1QJVXRKEv86gGUxbxXA523Ge25/H3KfwQIpB6gPdDIXOTrtzlKOu2OVFf1jxnOM lqCiYcFSpX7y58/0PeQ9ybuXUywj1Jc= X-MC-Unique: unzHq4k8NrGaRGqkhunq0A-1 Date: Tue, 28 Feb 2023 08:59:52 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230228031026-mutt-send-email-mst@kernel.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: > > > > I feel like we should have separate deprecation entries for the > > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > > although they're related they are independant features with > > > > differing impact. eg removing qemu-system-i386 affects all > > > > host architectures, not merely 32-bit x86 host, so I think we > > > > can explain the impact more clearly if we separate them. > > > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > > a superset. > > > > > > Removing support for building on 32 bit systems seems like a pity - it's > > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > > and the maintainance overhead is quite small. > > > > Note: We're talking about 32-bit *x86* hosts here. Do you really think that > > someone is still using QEMU usermode emulation > > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! > > I don't know - why x86 specifically? One can build a 32 bit binary on any host. > I think 32 bit x86 environments are just more common in the cloud. Can you point to anything that backs up that assertion. Clouds I've seen always give you a 64-bit environment, and many OS no longer even ship 32-bit installable media. I would be surprised if 32-bit is above very very low single digits usage compared to x86_64. > > > In fact, keeping this support around forces correct use of > > > posix APIs such as e.g. PRIx64 which makes the code base > > > more future-proof. > > > > If you're concerned about PRIx64 and friends: We still continue to do > > compile testing with 32-bit MIPS cross-compilers and Windows 32-bit > > cross-compilers for now. The only thing we'd lose is the 32-bit "make check" > > run in the CI. > > > > Thomas > > Yes - fundamentally 32 bit does not seem that different from e.g. > windows builds - we presumably support these but AFAIK CI does not > test these. We do compile test windows in CI via mingw, and we also do build and unit tests via msys. Even Windows has dropped 32-bit support though, and so the only reason we keep 32-bit Windows around is because of Windows 10. Once a Windows 12 comes along, we'll not need to support 32-bit Windows either. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:00:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503144.775313 (Exim 4.92) (envelope-from ) id 1pWvqg-000588-Dg; Tue, 28 Feb 2023 09:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503144.775313; Tue, 28 Feb 2023 09:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvqg-000580-Aw; Tue, 28 Feb 2023 09:00:38 +0000 Received: by outflank-mailman (input) for mailman id 503144; Tue, 28 Feb 2023 09:00:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvqf-0003qW-M8 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:00:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d74129c-b746-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 10:00:37 +0100 (CET) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-582-vnwjeYscO8mY6XgsvzEq0w-1; Tue, 28 Feb 2023 04:00:33 -0500 Received: by mail-ed1-f72.google.com with SMTP id fi8-20020a056402550800b004a26cc7f6cbso12837925edb.4 for ; Tue, 28 Feb 2023 01:00:33 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id gg16-20020a170906e29000b008d044ede804sm4189754ejb.163.2023.02.28.01.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 01:00:31 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d74129c-b746-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677574835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRtxoAuLpdApFzU8iSpQxKbbqyyyhWT3y9LXsZFTdMo=; b=U+DS6koPBEwRqWRD7IriCWBo1WzOm0fLEpBRhhqUd/WKuc/s9ohfN/WwpCkF8pUd/0hYN5 43JF58VRSpJdo0IanoD3glkscSzrACMAH5JTFJMTCI1BFlqCRlhVC7yJM8GhkpwavUmkBu pOQ7BmKituFyUdMVDzA/g06CWwe+8Ns= X-MC-Unique: vnwjeYscO8mY6XgsvzEq0w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677574832; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xRtxoAuLpdApFzU8iSpQxKbbqyyyhWT3y9LXsZFTdMo=; b=29pK7276PbAxrlPQCYMtGhznGyPzjt7os4JRZf6AK6mfvq0EgP0OAbeuTeJ4d1x6N7 asnys8AybrKk7Po7YLnTa43NRt8Q4doVJolxdjIkVf+kq2M5OfIKkTmIMWSfosoYPpNh ma9R7dzQYDfWhKULLeMKGvZ/z5fLvd8/BvL+favJF2d3YvGN2019oIImPospxBYyQHes 1U1I2v7rkv9qoPciQ7ausochYPcconWz/QsQHh1Oczf6ioJS6g45li46iV+IBMFO5x4A v9DVmLTZf1OOjOlIpSKlfnSBr5oHdh5A9kMHOxuhMkI696HtWIz8EBMGG44X4u9ajy4u l2Sg== X-Gm-Message-State: AO0yUKXj2CqacgvJc2PGEXsG//7azserficVY9Z864cmaxxxd8runb1E JDv3D1MxgNm8uuQBDBt82JIQL9FHTdcxmNFGFn7iBJMXrMTKJC96c7HV8Vdu21Zlif+oS1mr4Ar gV3mR2ty79vWI4JBDaWZtrcGkQdM= X-Received: by 2002:a17:906:9e11:b0:88b:a30:25f0 with SMTP id fp17-20020a1709069e1100b0088b0a3025f0mr1283987ejc.32.1677574832261; Tue, 28 Feb 2023 01:00:32 -0800 (PST) X-Google-Smtp-Source: AK7set/J1+Ld8LsWEB2TwMozBSOMY+fwEhTxfYILgVCVw7dPM0D6ohU2PzN3oITfWaroDadG9uKo1w== X-Received: by 2002:a17:906:9e11:b0:88b:a30:25f0 with SMTP id fp17-20020a1709069e1100b0088b0a3025f0mr1283970ejc.32.1677574831962; Tue, 28 Feb 2023 01:00:31 -0800 (PST) Date: Tue, 28 Feb 2023 04:00:27 -0500 From: "Michael S. Tsirkin" To: Richard Henderson Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228035958-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: > > Removing support for building on 32 bit systems seems like a pity - it's > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > and the maintainance overhead is quite small. > > It's not that small. Meaning there are lots of ways to run 64 bit binaries on 32 bit systems? -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:02:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:02:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503151.775324 (Exim 4.92) (envelope-from ) id 1pWvs0-0005lN-OD; Tue, 28 Feb 2023 09:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503151.775324; Tue, 28 Feb 2023 09:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvs0-0005lG-LY; Tue, 28 Feb 2023 09:02:00 +0000 Received: by outflank-mailman (input) for mailman id 503151; Tue, 28 Feb 2023 09:01:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvrz-0005lA-F6 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:01:59 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d1d61c8-b746-11ed-a550-8520e6686977; Tue, 28 Feb 2023 10:01:57 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-g2TUK-noP6SPVJBc0lV8-g-1; Tue, 28 Feb 2023 04:01:52 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5BD4877CA3; Tue, 28 Feb 2023 09:01:51 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D219E2026D4B; Tue, 28 Feb 2023 09:01:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d1d61c8-b746-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677574915; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6vrEM3/+CLVFY3tVeIf9d5TLFCA708VKaeYPHG45Hc=; b=GKQ0xxxiOzBZJ+bS6NrM1f1lxJ0fulkjOGoO6Rh8ZvWY5B25XsowCpF6zDThG0N+Frpa9J /AibhNjp1UkSKpDdQs5Wr6p9g3Bukoa3GvDnli8GweGwZmWyPlSC1xg1wejhblwyiHsXgb HkAStYuSaELYQpDdFex43Gdohkq9nYE= X-MC-Unique: g2TUK-noP6SPVJBc0lV8-g-1 Date: Tue, 28 Feb 2023 09:01:46 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230227111050.54083-1-thuth@redhat.com> <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 On Tue, Feb 28, 2023 at 08:39:49AM +0100, Thomas Huth wrote: > On 27/02/2023 19.38, Daniel P. Berrangé wrote: > > On Mon, Feb 27, 2023 at 12:10:48PM +0100, Thomas Huth wrote: > > > We're struggling quite badly with our CI minutes on the shared > > > gitlab runners, so we urgently need to think of ways to cut down > > > our supported build and target environments. qemu-system-i386 and > > > qemu-system-arm are not really required anymore, since nobody uses > > > KVM on the corresponding systems for production anymore, and the > > > -x86_64 and -arch64 variants are a proper superset of those binaries. > > > So it's time to deprecate them and the corresponding 32-bit host > > > environments now. > > > > > > This is a follow-up patch series from the previous discussion here: > > > > > > https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.com/ > > > > > > where people still mentioned that there is still interest in certain > > > support for 32-bit host hardware. But as far as I could see, there is > > > no real need for 32-bit host support for system emulation on x86 and > > > arm anymore, so it should be fine if we drop these host environments > > > now (these are also the two architectures that contribute the most to > > > the long test times in our CI, so we would benefit a lot by dropping > > > those). > > > > Your description here is a little ambiguous about what's being > > proposed. When you say dropping 32-bit host support do you mean > > just for the system emulator binaries, or for QEMU entirely ? > > Just for system emulation. Some people said that user emulation still might > be useful for some 32-bit environments. > > > And when the deprecation period is passed, are you proposing > > to actively prevent 32-bit builds, or merely stopping CI testing > > and leave 32-bit builds still working if people want them ? > > CI is the main pain point, so that's the most important thing. So whether we > throw a warning or a hard error while configuring the build, I don't care > too much. If we're merely wanting to drop CI support, we can do that any time and deprecation is not required/expected. We should only be using deprecation where we're explicitly intending that the code will cease to work. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:04:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503155.775333 (Exim 4.92) (envelope-from ) id 1pWvto-0006N8-3y; Tue, 28 Feb 2023 09:03:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503155.775333; Tue, 28 Feb 2023 09:03:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvto-0006N1-1B; Tue, 28 Feb 2023 09:03:52 +0000 Received: by outflank-mailman (input) for mailman id 503155; Tue, 28 Feb 2023 09:03:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvtm-0006Mv-Lf for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:03:50 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d069d368-b746-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 10:03:50 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-248-GS236xGyNei3cmJAoFzW3A-1; Tue, 28 Feb 2023 04:03:45 -0500 Received: by mail-wm1-f71.google.com with SMTP id u19-20020a05600c00d300b003eb24ce58ceso3368550wmm.9 for ; Tue, 28 Feb 2023 01:03:45 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id bi13-20020a05600c3d8d00b003e204fdb160sm15217479wmb.3.2023.02.28.01.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 01:03:43 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d069d368-b746-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677575028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mo3Ix7HhvRTB/uL9iGxje7SInRQ3/WqLFw5P2OgDP1c=; b=GbRvBvRbHmX6Pu2QNFfZu4BkPIKoUF4RTBBtHXjPJ8YtuZwOovQJyh4mhAT+GHkOxO7Q03 6FkGw2PhzJ43mbo7eazEgnfmkHiKVihpHOeImc+ELj+nrb7W7Wmz67JdDIfiv00+inmckm BFwGaQ0oFAiICGslOQVXKnuDA1Li60Q= X-MC-Unique: GS236xGyNei3cmJAoFzW3A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677575024; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mo3Ix7HhvRTB/uL9iGxje7SInRQ3/WqLFw5P2OgDP1c=; b=jr6uaKnTPW0MJ4BvSBIFpWPxYqr5LJjHY3zqa8HiWqZnVWpRjWDOPO615V1z7VB0u/ u+KdxtQofU7wOPTywywPz/OxSwR2HROnisbWDdHeqdrYDozwsRb03dTE2oHjMY1q98Vb zjNQDcVKiGYWEipBgT9qaTv4+pF7iPhCCSTEH08CXMxxx8VY/gdvkWxnqn63OnsVCEQb YX+S9OJcwUsV0yQTmzqNhPC6Qt5fBvaeZleWqKqz2Je0kEeLVONDhYPDYvnt4Lu9uRBn cTQcwKKLnNjjXdmsy41a/LkbWXgV6343djYUqegJYShjc7d5OvU4MjV3xLNOXGzpDO8r 045A== X-Gm-Message-State: AO0yUKVKBCrEWOQ5D+y688tkVJ92n3yn6fgUIIP4tdl1AIuOgy9td1Eb iBig+dFsYxUwSFaqhxGRxNlYPrgpdUGxVtBaKwBvBqInXuKjm/nAnvygC1LdFsBRz4Y7Zyqx+Dh Eggqo7tjnnjLU+sK4KKNYZpJwXJs= X-Received: by 2002:a05:600c:4aa8:b0:3eb:3947:41ea with SMTP id b40-20020a05600c4aa800b003eb394741eamr1323189wmp.37.1677575024176; Tue, 28 Feb 2023 01:03:44 -0800 (PST) X-Google-Smtp-Source: AK7set+8SxD5nvNj4eV/WkOWGobg8EUZ1L7PKKhyad8zHqSvg6kV07EAi8Li74NHX7YpKP3bxvWK1g== X-Received: by 2002:a05:600c:4aa8:b0:3eb:3947:41ea with SMTP id b40-20020a05600c4aa800b003eb394741eamr1323163wmp.37.1677575023825; Tue, 28 Feb 2023 01:03:43 -0800 (PST) Date: Tue, 28 Feb 2023 04:03:39 -0500 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228040115-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Feb 28, 2023 at 08:59:52AM +0000, Daniel P. Berrang wrote: > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang wrote: > > > > > I feel like we should have separate deprecation entries for the > > > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > > > although they're related they are independant features with > > > > > differing impact. eg removing qemu-system-i386 affects all > > > > > host architectures, not merely 32-bit x86 host, so I think we > > > > > can explain the impact more clearly if we separate them. > > > > > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > > > a superset. > > > > > > > > Removing support for building on 32 bit systems seems like a pity - it's > > > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > > > and the maintainance overhead is quite small. > > > > > > Note: We're talking about 32-bit *x86* hosts here. Do you really think that > > > someone is still using QEMU usermode emulation > > > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! > > > > I don't know - why x86 specifically? One can build a 32 bit binary on any host. > > I think 32 bit x86 environments are just more common in the cloud. > > Can you point to anything that backs up that assertion. Clouds I've > seen always give you a 64-bit environment, and many OS no longer > even ship 32-bit installable media. Sorry about being unclear. I meant that it seems easier to run CI in the cloud in a 32 bit x64 environment than get a 32 bit ARM environment. > I would be surprised if 32-bit > is above very very low single digits usage compared to x86_64. Absolutely. > > > > In fact, keeping this support around forces correct use of > > > > posix APIs such as e.g. PRIx64 which makes the code base > > > > more future-proof. > > > > > > If you're concerned about PRIx64 and friends: We still continue to do > > > compile testing with 32-bit MIPS cross-compilers and Windows 32-bit > > > cross-compilers for now. The only thing we'd lose is the 32-bit "make check" > > > run in the CI. > > > > > > Thomas > > > > Yes - fundamentally 32 bit does not seem that different from e.g. > > windows builds - we presumably support these but AFAIK CI does not > > test these. > > We do compile test windows in CI via mingw, and we also do build > and unit tests via msys. > > Even Windows has dropped 32-bit support though, and so the only > reason we keep 32-bit Windows around is because of Windows 10. > Once a Windows 12 comes along, we'll not need to support 32-bit > Windows either. > > With regards, > Daniel Or maybe we'll just rely on WSL. > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:09:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503162.775344 (Exim 4.92) (envelope-from ) id 1pWvyf-00075j-Qj; Tue, 28 Feb 2023 09:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503162.775344; Tue, 28 Feb 2023 09:08:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvyf-00075c-O3; Tue, 28 Feb 2023 09:08:53 +0000 Received: by outflank-mailman (input) for mailman id 503162; Tue, 28 Feb 2023 09:08:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWvye-00075W-Aw for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:08:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7d00::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 83b7e336-b747-11ed-a550-8520e6686977; Tue, 28 Feb 2023 10:08:50 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6912.eurprd04.prod.outlook.com (2603:10a6:803:134::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 09:08:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 09:08:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83b7e336-b747-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FmWiKKEaai+6MbYtAZB49tWVz0RLkdRkdEGHO3LEREHa/HPL4IvX8FdEQnz6P/dPC8C892lf1jjoWVEe4YjKg+aCGKgcDdn2SUY+dK7Y8Hg85hpFb94EAwV+xl8fJr/unZbzf8GIGV4GsYHPJmboFz5TOSomXqzNXCl8uIEdNa49qI/8CgOquyfUnLv4nmi10eUpZEZUlPWKiByZ6c0HDk3XWRSeYmWb6hFfgOfl4IbGkwefEwkKDErrtyUf3YtrCJsgrsz99+QCQ0hIGazknZNhGRw2DYPtBHaUZsbqT6d6C1SkpEZ3sOqsuEHq5qFOvaenCXW5TGytUBdAfpnQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9re3QZsju2Hvu85/uQgjvpi6KNtyr011Ea0rEBRmpHs=; b=Wdrro/si4B76djCSi9CMi6psrOJBqs89zQwCkshe8C8AJjXUXVTboBTBUY26vQurhfaE43DB0LqjTa4Qd5QjwYOVVKsfQaGh01xvo+MhTFJZ+BtBPUXLGf140JWpuGtyvJzWWMYQEYhvnbe/mHaU8J7V+dmCrJmGOfXWzKtigLcnSpfOuoQbXdXYeIjTv2nxcOEYhtyN5OJ4/dhySZeOBI4vOjezuT+gW67AHca3Y6LqCwW6Roo9PsxrtYge4Xg8QbQ/TP9miU+M21zE011rrG4pTohchhMziLw3/V1I2VmRuuiMJpcsa84soLq9md8x2/9RiiB8jjZo2yeyrD5PbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9re3QZsju2Hvu85/uQgjvpi6KNtyr011Ea0rEBRmpHs=; b=JlJvlGTvns2m+q8cBKIq0Ya/+ZHa8ahMDcAJGHr6vS3d4PZqcONJmq+DioY4YwuHE0LfMJksoW/gNfP8HQPcRZzO/PJu5WmhjxWLTBcCL3rnNhWYNKpHO/DiWvPyevY+dmfhsLiO+sKwodlCnFyj9JHD9ZC7Q5jrzg1ZLZSjMWkNleSy25lXSlqT00PLu0yJ7C4Nd0fBx7FN2zwxrPJpcJ0RomkSQnVxYObV2D1Hlh4XiNH/DAZayWXgIupK0QFWb78CXX1ujmKHmQJNKoujVWsurYM6HGKyub29HDjnNT07XO340x/MfqXOlaOWi92B1z3mv6t2JYFn3JwgIulrzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <46721d04-508a-9d63-2af8-5ece857ed54b@suse.com> Date: Tue, 28 Feb 2023 10:08:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Jan Beulich Subject: [PATCH v3] core-parking: fix build with gcc12 and NR_CPUS=1 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6912:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f24c758-2d2d-49cb-1073-08db196b6444 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wnhfCZD+bd6ZNIjMj3BCX1/ahDHoYFL+Zp0Ln1fHyRpg0iMr/vzfx448HYaa54OWD71zSldfNYr/6pnT4gEKzifa24uYuxA5sWowP5d3Nmj4QS4GYemuQUwx7h6R/uTNcB1UG4iD6iDGUuP+qwwsJ2Ra8PJB1WB5klUBiF045iPufY95C1geeMNFy1OkMqZ0VVpOYUemDmaKr7wJ/5VYkTM0dUBGKJS4lyi+eOjldcO/nF/Yve28sMy3H42ngbkgTl1NlGuMEZSUEAM7YXnPqGXikHqAviGTLy4H+WVL6mQTeFp98Y79NjwnoBKysrc4VBdj2tDmXLc7yWyKewZ6/eQrXEZCBVNi67KGoPVWH0BEuHxSJ7sp3EG6aN/8urham7w0yX3ygjDKzRfC2tgQN+LOntd8/EB8xT04NvoTX/YPTTu6BVowtHG9xa0Hc3MH6ueN5Mx9O16s91TQGKZBggTCcd84utKWlfyAqiCqgudk1OFUJEIslLxbu59g9HjAF1+LtlMipeD36vJ2qoZbhDyaJfdYTzI2jBp2fxiJKRm+xbBbMUwSOJC/nguUtEtZYf6A4WC2g8Xtf91g6t6bd1MW1x4QQZ57yMe+7alH8ZF6fhBNNZznrphRF+iXOL8o/Q1JOvmh+aI2Y26OZEP3PMwIKlFmzkx3ebZsVufl6FcKIgDnctyDR6Yg+/3CbdW3KXN6JSOHU9gtJMK08fHhXBu58jbsP19/F+h/SONzEf4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(366004)(376002)(396003)(346002)(451199018)(54906003)(86362001)(316002)(6512007)(2906002)(26005)(31686004)(186003)(478600001)(6486002)(41300700001)(31696002)(5660300002)(8676002)(6916009)(8936002)(4326008)(66476007)(66556008)(66946007)(2616005)(6506007)(83380400001)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2JVbTRyREhGWmNvZUJVekhnYlNGMkwyaHJjc04yRGJucVFyb3lnYXBocFBN?= =?utf-8?B?R0RxRWE4T2tsNElFaWR2U29RVk5ITUtDZndIZDc1Nzc4R1dlNTRPUVRtMTI1?= =?utf-8?B?cHJYSDJYRGNOZjB0bnVpb0xCNE9UcW1YQjVIZW5WaTZ5YXJ1Z0plRlJQODls?= =?utf-8?B?NTB3Q3pCMFBibGN2Nmx1NzJHdTIvc1BKRDBVMUhlMVA5eFk1N1puSWtNaHVp?= =?utf-8?B?eCs2YnlESUVFTnpHN0prS2lLSkRoNmlTMnZ5YTVmeFZaKzZmbzRpSG45YlVn?= =?utf-8?B?ZHlYU0R4cjFSYVJ3ZHFwbm50VWd0Ynorak5mWUtaVSs3MWFNS00rVDcvN3I5?= =?utf-8?B?NzlRS1NTSS90V0N4YW1sTXdhRTFsaFQ3REg3RVBGQzJBUktxeHFFQno3czg0?= =?utf-8?B?cFUyOFVCRXdOdCsxTWI5YkQ4c2I5eGVsZ3BxbkN3cmpCL2tUYVZFd1QxbVE5?= =?utf-8?B?L1A4ekl3eXpUNXZLTWhjQVU4RzY0K3Vha1JlajNHUFA2eW43M1VqYmZQTXRI?= =?utf-8?B?eWd1TXJLd2dRejRMNWt3eWFtd2Q3c3BuUjdqMWZ2RnVLZ1I2NXdqMmdnN040?= =?utf-8?B?UWxXTm1CVGNmQnJvRG9sL0VVZUorQmFUdm5iQzR3MStRUFljRjBUN3JTMC9H?= =?utf-8?B?YW1PR0RZdjRNSWtGa0FsYi9ENnBpQTNTOFpLcDAvaGdhc1R3T0JXZzNhM3kz?= =?utf-8?B?M0xTMk55L2JXVy9WZHlKUGZydHhRdUJqYk5QUlJkUVRDMVZLTGhaaEh5bGUy?= =?utf-8?B?U1c5UXlPaXRRY3Y5MTRoK0EzVnZxNDVrbzRRdkQyZ3MwLy9LMk5RMklMSWdl?= =?utf-8?B?Qk5WemttZnlXWm5xblkycmpjS2dBMG1TNzRCR3JRU3phU3ZMa2hkVGZMYlB0?= =?utf-8?B?UFExenhMLzA0djE3MEpFNUJxMWpVckVlUzFCaEh3NzRGNEpWaDcvRmdQQzhs?= =?utf-8?B?Vk15ZS9rNnhHWEo4NGlSYkNUZVN6RjJTTVJlZVM0blJscXVKWkptaWo4dlZV?= =?utf-8?B?bzBFS3MrQWhodFF2TDd1Z29tbjh2ZGpQMEJLck9mSTdJWTJ5MFZ4SHN3UXdF?= =?utf-8?B?ajlld1JKVVZ1ZkhrNWNCUlBiWTZLdkFBUXA1dkJ3c3duWDIzMjdNSFFvOXFQ?= =?utf-8?B?YU5SbnRiVk9qdWZuYTJLeE90SDB4eUJSVVFBTU9yMG9jTkdLTTcycnI0dy96?= =?utf-8?B?Y00yVDBmZGsyYkRSK2dmT2owU3FwU1R3d0VUNkFUY3lIUVdJQmZkRWJIcjBG?= =?utf-8?B?RndrVWJxVE9sclhIa3JCd3NCczdSUjF6aW9GQmlUdXdSNTBnM0VPVFVtRkxT?= =?utf-8?B?QWNQbVhtcmlqWWhTcVNjSVpyamVUR0VRRHZCVEpYSmNJdFVuZ1RFYTA5RXlR?= =?utf-8?B?QlZjb3pQR3ZWVi8vNEp1eGpxalFLR2ptaCtyUUJaK3h5YVFVUHpsTTc3Rjd4?= =?utf-8?B?bzdEVWRJcGtGRElHZXFwSTBWeCtvVDMwa1FhQmthZXZWK2VNRGd0Zk8yN1lw?= =?utf-8?B?ZENWVlBaT2ViZ3BaNHZxYzZ2SnNzSjVPcFptTkJUWlNYcHgzSkFrVVFwSThU?= =?utf-8?B?U0ljR0k1cnlURlNpSHZ5OGdtdjUvT3k2K3dqMVcyWjBhMHUyeW0wMmpxZG9o?= =?utf-8?B?V1BQUFhXcHlSdmlCU1JROVRZUVB0anRWb0lEbitFSXhmNlJpR04xd29QdDRs?= =?utf-8?B?NzdORmRPVFRveU0reDlvR21yVjM2TlFYeWNUaFJnUHdJdFA2M0Zqd25MK1B5?= =?utf-8?B?NEtiYXo1R1ZpTzhyUDB0YmZ6cWxXalVzeUc4b1h1MkVkRlRVNFd6RFZ0cG5X?= =?utf-8?B?NnQ2YUk1azBxUDkrWitGQWFBR01Da003cVJZZnFCMXlIUnZ6SlN0cFhPUkdw?= =?utf-8?B?ZkFjUEx1RDJYUDVRRVVkU1pXMmEwaTZvcmlJTyszTWwyVXpBOXNPUy85b1gw?= =?utf-8?B?UU1Hci9NTG9xSi9wdzRwdWN6bWMvQzRNb2VwTzZPdHFuQ0hhTkxzWThIOXhu?= =?utf-8?B?VTVYRTJMbHBQRkQ4R1paWHpvZXZ6b1NBakQwRi9TbGg2ZHFUUCtsbTVCL3c0?= =?utf-8?B?UGU4ZmJ3STROMVkwY0Y3d2NNOFRCMUhCaFd6SklXWVBuaFNUM1k4NDEzc0Zt?= =?utf-8?Q?y8P0ejnsOgoV8a2k0Tz5nMz4o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f24c758-2d2d-49cb-1073-08db196b6444 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 09:08:43.9309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ikH+OT2jR1MONpDkXvrE8ypTXbK1UDvU9MGBxtFgDuCMU6BUuy1VXvyNffxGrlavl1VX4Ve1M9kwbkt0K0ky+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6912 Gcc12 takes issue with core_parking_remove()'s for ( ; i < cur_idle_nums; ++i ) core_parking_cpunum[i] = core_parking_cpunum[i + 1]; complaining that the right hand side array access is past the bounds of 1. Clearly the compiler can't know that cur_idle_nums can only ever be zero in this case (as the sole CPU cannot be parked). Arrange for core_parking.c's contents to not be needed altogether, and then disable its building when NR_CPUS == 1. Signed-off-by: Jan Beulich --- v3: Use "imply" and "depends on" in Kconfig. Adjust the arch_do_sysctl() change. v2: Disable building of core_parking.c altogether. --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -10,7 +10,7 @@ config X86 select ALTERNATIVE_CALL select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 - select CORE_PARKING + imply CORE_PARKING select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -727,12 +727,17 @@ ret_t do_platform_op( case XEN_CORE_PARKING_SET: idle_nums = min_t(uint32_t, op->u.core_parking.idle_nums, num_present_cpus() - 1); - ret = continue_hypercall_on_cpu( - 0, core_parking_helper, (void *)(unsigned long)idle_nums); + if ( CONFIG_NR_CPUS > 1 ) + ret = continue_hypercall_on_cpu( + 0, core_parking_helper, + (void *)(unsigned long)idle_nums); + else if ( idle_nums ) + ret = -EINVAL; break; case XEN_CORE_PARKING_GET: - op->u.core_parking.idle_nums = get_cur_idle_nums(); + op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 + ? get_cur_idle_nums() : 0; ret = __copy_field_to_guest(u_xenpf_op, op, u.core_parking) ? -EFAULT : 0; break; --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -152,6 +152,10 @@ long arch_do_sysctl( long (*fn)(void *); void *hcpu; + if ( CONFIG_NR_CPUS <= 1 ) + /* Mimic behavior of the functions otherwise invoked. */ + return op != XEN_SYSCTL_CPU_HOTPLUG_OFFLINE ? 0 : -EINVAL; + switch ( op ) { case XEN_SYSCTL_CPU_HOTPLUG_ONLINE: --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -10,6 +10,7 @@ config COMPAT config CORE_PARKING bool + depends on NR_CPUS > 1 config GRANT_TABLE bool "Grant table support" if EXPERT From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:15:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:15:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503167.775354 (Exim 4.92) (envelope-from ) id 1pWw4k-0000S6-FF; Tue, 28 Feb 2023 09:15:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503167.775354; Tue, 28 Feb 2023 09:15:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWw4k-0000Rz-Cg; Tue, 28 Feb 2023 09:15:10 +0000 Received: by outflank-mailman (input) for mailman id 503167; Tue, 28 Feb 2023 09:15:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWw4i-0000Rt-Tw for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:15:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 642124ac-b748-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 10:15:07 +0100 (CET) Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-590-Xbme9yDUMYa30xqJX0RqNg-1; Tue, 28 Feb 2023 04:15:02 -0500 Received: by mail-qv1-f71.google.com with SMTP id m1-20020a05621402a100b004bb706b3a27so4836053qvv.20 for ; Tue, 28 Feb 2023 01:15:02 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id y24-20020ac87058000000b003b0766cd169sm6367904qtm.2.2023.02.28.01.14.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 01:15:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 642124ac-b748-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677575705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtPWLZOeXu1C5NyaeaHanhZFNS29T87n43afAPxa5So=; b=httV4BllPPKMInj7e88Q3xDUPDixQQWajVa4Zer9QoRAhUI4JTtLoSPHWiJX0j8ywVkPXr VMARaMe9FNjgPVzpiNNralqupwWgpRfTwzoj+5h2X51T2vSpdh1w3HROWZmYqOZhb0CbiU V3hNxcv1g7I4relENUmxtOHT21KE15U= X-MC-Unique: Xbme9yDUMYa30xqJX0RqNg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NtPWLZOeXu1C5NyaeaHanhZFNS29T87n43afAPxa5So=; b=ULlAqoontjzyRSdv2k4s2UTzw1Q8i2eMnbabbr7HyloKVQ3pTJzME4U7ktvwVa4b+7 qmUaF79OSLpTyBfYNiCcqBEod8jHdfa1kRbQfR//NG5W1QbvApkQcMsLHVw+8zQbFdES Hv5uPczZFrqU8W8HLTrgZ0VxMUn0lacOWZAT8l/rm2EXVs89ty6ZcK8E9ZB5kEX7VLgv ikgvuwBllOVvpq7E1mFEzGc2OkrMnO0W0P903MBpdDJmW92fn9UD3c8Ks6nEtgbK1imD ZlLiS2IAmIe5GAkdecHOPG1HCEg3dkHwMp7CW+D8QmI+exJYPc4eVY0QJclR0mlQsmTJ qJrg== X-Gm-Message-State: AO0yUKU5/rjWynq5fZJBuQZCDHSUPfclo39r5XAxFlBUcYrCFrhe5+dc b9fvQI094FmkiR1eiUZ9LVGmIML+xSXClY6GKHPjU3FWnKtIhZkg0KD5Ah64F3g9pFmsgvDgQDx tGlcAoPUqnoWEa9CcOaXL8k6LabY= X-Received: by 2002:a05:622a:1aa0:b0:3bf:e4da:2367 with SMTP id s32-20020a05622a1aa000b003bfe4da2367mr4024644qtc.3.1677575701899; Tue, 28 Feb 2023 01:15:01 -0800 (PST) X-Google-Smtp-Source: AK7set+tlULtl5hsjg8wm7tkSWgo9aPXWHB0qpTqsH249PIqNMrW49odQ2jTi+8oJFuSxDyLBqorgg== X-Received: by 2002:a05:622a:1aa0:b0:3bf:e4da:2367 with SMTP id s32-20020a05622a1aa000b003bfe4da2367mr4024622qtc.3.1677575701703; Tue, 28 Feb 2023 01:15:01 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 10:14:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 To: "Michael S. Tsirkin" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> From: Thomas Huth In-Reply-To: <20230228040115-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/02/2023 10.03, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 08:59:52AM +0000, Daniel P. Berrangé wrote: >> On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: >>> On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: >>>> On 27/02/2023 21.12, Michael S. Tsirkin wrote: >>>>> On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >>>>>> I feel like we should have separate deprecation entries for the >>>>>> i686 host support, and for qemu-system-i386 emulator binary, as >>>>>> although they're related they are independant features with >>>>>> differing impact. eg removing qemu-system-i386 affects all >>>>>> host architectures, not merely 32-bit x86 host, so I think we >>>>>> can explain the impact more clearly if we separate them. >>>>> >>>>> Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is >>>>> a superset. >>>>> >>>>> Removing support for building on 32 bit systems seems like a pity - it's >>>>> one of a small number of ways to run 64 bit binaries on 32 bit systems, >>>>> and the maintainance overhead is quite small. >>>> >>>> Note: We're talking about 32-bit *x86* hosts here. Do you really think that >>>> someone is still using QEMU usermode emulation >>>> to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! >>> >>> I don't know - why x86 specifically? One can build a 32 bit binary on any host. >>> I think 32 bit x86 environments are just more common in the cloud. >> >> Can you point to anything that backs up that assertion. Clouds I've >> seen always give you a 64-bit environment, and many OS no longer >> even ship 32-bit installable media. > > Sorry about being unclear. I meant that it seems easier to run CI in the > cloud in a 32 bit x64 environment than get a 32 bit ARM environment. It's still doable ... but for how much longer? We're currently depending on Fedora, but they also slowly drop more and more support for this environment, see e.g.: https://www.theregister.com/2022/03/10/fedora_inches_closer_to_dropping/ Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:37:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503176.775365 (Exim 4.92) (envelope-from ) id 1pWwQQ-0003dH-7o; Tue, 28 Feb 2023 09:37:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503176.775365; Tue, 28 Feb 2023 09:37:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwQQ-0003dA-3G; Tue, 28 Feb 2023 09:37:34 +0000 Received: by outflank-mailman (input) for mailman id 503176; Tue, 28 Feb 2023 09:37:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwQP-0003d4-Ie for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:37:33 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2077.outbound.protection.outlook.com [40.107.7.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85e193ff-b74b-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 10:37:32 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8813.eurprd04.prod.outlook.com (2603:10a6:102:20c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Tue, 28 Feb 2023 09:37:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 09:37:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85e193ff-b74b-11ed-9693-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXysbhGFEtcux0JuE3hzT1Y/GVNZpfrVrosEIfndCbQuyCD/RFvojIxRr2+uZrP1Wr9dMk5eaxBo4PmIMmeXHk4oqwaRWEEs84ot4iPAjwIAu4WTxbck6lhkILrLGElnw9iM3B2BsjataqoZyM9CKmDyfwO+kbQ3JRdx9St+qQnL+Pt31HT98YZqegpPoxpIbniRP3u3evIzu1uQTYwr+7Itxur+u/VtHRd/zISsa46gmqEiQm/OL0VogttA/BnFkTX6uQDca7JKlPeRgXsrUt/ouvKRq7kowEwh6jZjTAstw5V8AoQQfFjIatX4bom8BLeeZGSiBGU7WUhAbzHzBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DUo9hhtsh2qK0R5RTd8vtESoDn0BCRVKKsPk5hb6YAM=; b=MFBcYj538PBUMHOJ/gbV6TA3cw6cSaINGBrfhXz4QvFyebdS4KFFrMNun9epGJPNpdylnoYSOdLekRQwpm56+ybGHqFvk0uy770MkvZ/zvzw5DYoyT0W3bf/AzOFSKcQ4J0nWnO/5MdIkz/9sZyPENtjZ2FCF7JHw0WgwS4OzJB8lV6iHzpDNe2o4uhIyhKc7p3WksqornISSL/+grchSJ4YYN7JqTBjRG3HOXc9VKJCj9EMfGrAVY1q3HRVoaD09aZ0LO9d7N1Qqvd0NxZHaTjO8Yet9VwURX2nXOO9QJ1G/hlak9RJcHRuWip4+nPDkIiyr5ZUtpKaZI/TpHHxdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DUo9hhtsh2qK0R5RTd8vtESoDn0BCRVKKsPk5hb6YAM=; b=an1z6gC4BgjlLD0l8RHCDBCqTV6cbflhpwaTtgbQf33D/fVbMllKUaRp28YlHM7S0/Jl3MkAeRGvPaKLtuF312XtZo/OJoQ3AbFS1PU8OdB//hTQyLrq0CeKWO6IGfnxAhEmZ2i6QR3Yg8a9zTBHgCS9mmFEViMIGOSV/3Ca2b4rl0ud69DnF83U2Lw6Bj7sE8RNNe4wB4KTdjxISUfEWavuctgKaSMphTpZbU3oAbtuR85B3Nn9mUOVn6ixpFUdKskq4x0khx9P857syhDRnmmqfELhReFmfZi3ScJwGgDNNeooSDtDX0VRiN2VBJaZp3VnlSbPZ4T7gEC+An+Dyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <467c21e0-e41f-3d52-f5e0-8bcc70bfc923@suse.com> Date: Tue, 28 Feb 2023 10:37:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Is xl vcpu-set broken Content-Language: en-US To: Joe Jin , Anthony Perard Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org References: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> From: Jan Beulich In-Reply-To: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8813:EE_ X-MS-Office365-Filtering-Correlation-Id: ded17739-3d99-47c2-937a-08db196f58ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QJcKQI5Wx/ke7tN0zDWvIzAdncTyvjp0tZpBtaoeZPN2+8Teplarhc/7VHQZXvguQ5fyFfxfWsENhLVNf5tIZqfXW3Y7rRMuMzYtPTVRqmpiHF7QOHLqQmN3ObmwLabbsaoVZQBQCd1OOxOVvi3HQHeM5qKMjMcZ5Z/BjPodvXasGRfBOAYbVH9CcCVG3XupRgUsixj5fY+OKTtmp9+CJjUA09UTfu8+kVP9fNz8r5dA9nas+Kq/ySuz01AN2zOEfRg7hSx+sws4/H1tCYC1Po77LItAdGNgPegMeMDi/3q8PP5vBopP0GWSDkAjnfMcpBCzKWW6a8tx6CLe9wxMAudV0b8gXEnYo1r4wESnN07YDrFHhk7zBo/E2vb46CsNxSwyLzdLJhpod05SLEQik/QfxHHEX7REI7J7eKMtKNHo3RUsKRQ+XrKZCv8+BPgYnIOyk8gZGkRt7y0B+P9/pAUWOe4GpHWmGUrFZN0BeQ7akyxowreW1NrBAfcB0UPKKJbq73WHkYl7SkLZQcxE6vqzMOk7z/Iuh81O6GGbQXWku6TzKDZ28m2a9xjLlZV5GmrWDcgot/uTlgFBkR1QK6MLKAvhLRGPlsNYFjlgPhJVCGWsW1qEM+DbieJ6B1JAHQB0n8nV6rYXlQpQfF2F49YCkgswqiEB4YYMWMERfkxNiu7GNiqEXU6+eTSMIrGU6h/uwIUxD3FaOST0oWeDRsqo94nPaf+vhSgfaAo7VCE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(396003)(346002)(39860400002)(376002)(451199018)(3480700007)(316002)(2906002)(31686004)(36756003)(8936002)(5660300002)(86362001)(31696002)(53546011)(66946007)(186003)(26005)(6512007)(66556008)(66476007)(6506007)(4326008)(8676002)(110136005)(41300700001)(38100700002)(2616005)(83380400001)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFk2dDl3SHNmeHNtZW10QVhJSmpWbEg0YmFXQmVGaHh0SWJyZEtOanFvSDhI?= =?utf-8?B?UVAyUHdsSzhTaEJnWGN6NW9GZ1VvTFFsZmQ4Nm0yVHdaYm5JK3BqdlhCTnMz?= =?utf-8?B?bjFWaFlCcTRXL2k0RUZDeDdFTEFaWGtKR3kxNEJuR3JFNVgzVzVHbEZLci94?= =?utf-8?B?REFsa2dwOGFRL0xXMGdGTWQ0QkhLVlA3bmk2RXFNY3VUM1doMWdIbWRxMjFy?= =?utf-8?B?N3UvVVUrQjVKN0ZHRUlBQnBmK2ZlYW01eXRmYStnUTJOam1HWGtFdWhObXdF?= =?utf-8?B?R3RYbWo3ZERPS2EzVFVzMDFNeGRhQnpLN1lWMm43cmJ6SXJVWFAyZVFmU0lW?= =?utf-8?B?c0dHMDluSFFVSU5tcHFGckpqOWM1T2JYMzRnQW1IWERGb2pBMFl2Y21aYlFx?= =?utf-8?B?emhjcytLY2ZqT2g3SE5sd1YxS0FZY0p4d28veDluZTRHQUxKVjVwKzZRcGdF?= =?utf-8?B?U25vRHRZblgxeHE4cnpsU3Z4MTlzaldCUTFDNzhzbmdvZDRJZnh2L1JUamYr?= =?utf-8?B?dW5tWXpYOGs0UldCazVxdjNNQ0JJNnpqUnkvYnpjUVgvSFY3cndnSEgybEtp?= =?utf-8?B?M0hSbjl4R3ZySFJZa1RrZTJ6TFppenJqOHA4UmN0TXpJNlA0RTRMRm0rZG5K?= =?utf-8?B?UlRPR0M2NENNSEtpbE1LWGkxbHg3K1lYZVczY0s1TUxQNXJQS2lvSi85cXRo?= =?utf-8?B?eVQ2WHE2R3dncTZHMDRuTFIvTDRSUkVBRGF5MGdRcUJ0bXNHWlB2MzRGWnpP?= =?utf-8?B?d3FSaUdPSGpGMUJnU1R3UWtJRkJLMkR0NWZYSGZoVm8xMG8xUEpUN2J3bDF5?= =?utf-8?B?T0prWmk5WWlBUE5pSXRkYXBYVUF4THBpZ3YwYks4Q1RRUXBEMjVFUkdqREJQ?= =?utf-8?B?OHhxUTBWTTNzYTJ5am5xaWM3WUdOQ2tBeDllNWFvNDBod3VkaFNDN0crbUpH?= =?utf-8?B?U3dNRkJQR0pTVVhtUWRuTWtNWHZqU3VSRE02K0ptZmpldWx4L1c4UUlYMUlM?= =?utf-8?B?UE40Yllhc1JQaEExTHJjUGt6NGIya2hmWmtSVGNLd0NUSmxNUHcyckhuYzZZ?= =?utf-8?B?OWJ1L3ZiTC9iaG16U2JwUU5qVWM4MGZjTE9qaTdiR3lUajRZWXMvZlFsNy9a?= =?utf-8?B?dlVmb0VUSkxHbC9YRVRvUlQ5a3NpVXJYMXpMUjhJUGtZMGhvWi9YTzhxcWdV?= =?utf-8?B?eGR4ZUY0SWxYeFFZN3g2MFZLcU5LMEc4YWhqUlE5d1VuajN2R1ZRWnlaZ21Y?= =?utf-8?B?QStObmEveEtmd1FqekV0SlMvR2I5alh0bzRQYkY0b2hBUHY4UHJRWjBSWGtX?= =?utf-8?B?ZW91R3REV2lsMWNqdUFCQzR3K3NYMVF1S2RjelY1QkRKaVM1d2IrSHlnR3RG?= =?utf-8?B?eUZMOGdzR1FCQ0J4S0VQUkdIWmpnSllIS1lRdXVjTHBBR2x2Njgrd0NHd1NI?= =?utf-8?B?SDFJUFR1Q1FFemRkSmgydVc5aW1mRTZna0prY0hpU2ltNEtLWVprY0FsVTFY?= =?utf-8?B?bEdFYXVHQUxZcW9LWHMzR2dsYmlxMXYzZmx5Z0Yxa0RjRXdMRStxUHRKZHVx?= =?utf-8?B?QnlRaGF2Yk02eXByZ3JQQ2g0cU9SRm1vN0RyNTlTMXB6NWJUSHV4dmFDSlRF?= =?utf-8?B?Nkx2b29LeVllRmd0eFp1L2lGVXJQRGJLNTRVWHNKUGQ3ZDB0dm80dEladjBU?= =?utf-8?B?ejQ4a2VqU2hUSjlSRHNzejRHdUtkQTBNV0pRVDZ0czZkMXhZMmZCb0M5SWlv?= =?utf-8?B?a1ArQ2lHZitLeEJUemJDR3dGU2UwODZWZ1hLN2ZMV0FCWWFleTVWNmZMZDlz?= =?utf-8?B?ZVNEYmJpWDJDNm01K1R1NDFxc2c4SStxc3FoL3JVWnJWSVVvQkNNZVk0NGl2?= =?utf-8?B?WnpvS0s3MEJFeHZHeE5NMm83OXNROUkzR3o2OTljV0RocEQwNkp5SnBFejFV?= =?utf-8?B?K2tDWHZTOWJMTkQzbG5DK3o3S0JodUZpS0tiNUZSaERMUW1neGtHOU1MTll0?= =?utf-8?B?Q0g5YU5VTWpabDNMdk5BOXUrQlkxSHE4ZUl2NHRoU2JzNXNkenpzU1dkUkVt?= =?utf-8?B?TXk2bG9xdGgybHNaTU1mMWNobDBsNEl0M0lxNXExVlVYYlV5WFg3cklVNWRG?= =?utf-8?Q?sVM8qHu2edkV0JJ+LLU+4UFm/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ded17739-3d99-47c2-937a-08db196f58ab X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 09:37:02.4479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w6O3OGrrMhawSgcSWgUBfgHRVfPtiMB9X4Wb0uTfb44zieRlmTDzPFsZlDo8/krTxAQwAT2XPcnSTP1FBPH3yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8813 On 28.02.2023 07:44, Joe Jin wrote: > Hi, > > We encountered a vcpu-set issue on old xen, when I tried to confirm > if xen upstream xen has the same issue I find neither my upstream build > nor ubuntu 22.04 xen-hypervisor-4.16 work. > > I can add vcpus(8->16) to my guest but I can not reduce vcpu number: > > root@ubuntu2204:~/vm# xl list > Name                                        ID   Mem VCPUs    State    Time(s) > Domain-0                                     0 255424    32     r-----     991.9 > testvm                                       1   4088    16     -b----      94.6 > root@ubuntu2204:~/vm# xl vcpu-set testvm 8 > root@ubuntu2204:~/vm# xl list > Name                                        ID   Mem VCPUs    State    Time(s) > Domain-0                                     0 255424    32     r-----     998.5 > testvm                                       1   4088    16     -b----      97.3 > > After xl vcpu-set, xenstore showed online cpu number reduced to 8: > > /local/domain/1/vm = "/vm/aa109ea0-2fde-4712-81d8-75f73bd73715" > /local/domain/1/name = "testvm" > /local/domain/1/cpu = "" > /local/domain/1/cpu/0 = "" > /local/domain/1/cpu/0/availability = "online" > /local/domain/1/cpu/1 = "" > /local/domain/1/cpu/1/availability = "online" > /local/domain/1/cpu/2 = "" > /local/domain/1/cpu/2/availability = "online" > /local/domain/1/cpu/3 = "" > /local/domain/1/cpu/3/availability = "online" > /local/domain/1/cpu/4 = "" > /local/domain/1/cpu/4/availability = "online" > /local/domain/1/cpu/5 = "" > /local/domain/1/cpu/5/availability = "online" > /local/domain/1/cpu/6 = "" > /local/domain/1/cpu/6/availability = "online" > /local/domain/1/cpu/7 = "" > /local/domain/1/cpu/7/availability = "online" > /local/domain/1/cpu/8 = "" > /local/domain/1/cpu/8/availability = "offline" > /local/domain/1/cpu/9 = "" > /local/domain/1/cpu/9/availability = "offline" > /local/domain/1/cpu/10 = "" > /local/domain/1/cpu/10/availability = "offline" > /local/domain/1/cpu/11 = "" > /local/domain/1/cpu/11/availability = "offline" > /local/domain/1/cpu/12 = "" > /local/domain/1/cpu/12/availability = "offline" > /local/domain/1/cpu/13 = "" > /local/domain/1/cpu/13/availability = "offline" > /local/domain/1/cpu/14 = "" > /local/domain/1/cpu/14/availability = "offline" > /local/domain/1/cpu/15 = "" > /local/domain/1/cpu/15/availability = "offline" > /local/domain/1/cpu/16 = "" > /local/domain/1/cpu/16/availability = "offline" > > But guest did not received any offline events at all. > > From source code my understand is for cpu online, libxl will > send device_add to qemu to trigger vcpu add, for cpu offline, > it still rely on xenstore, is this correct? Judging from the DSDT we provide, offlining looks to also be intended to go the ACPI way. Whereas libxl only ever sends "device_add" commands to qemu, afaics (or "cpu-add" for older qemu). Anthony - do you have any insight what the intentions here are? > anything can block cpu scale down? Nothing as far as I'm aware. But if done the xenbus way, the guest needs to watch the respective node. Yet on x86 that's done in upstream Linux only for PV and PVH (see setup_vcpu_hotplug_event()); as per Andrew's question the assumption here looks to be that you're asking about a HVM guest, though. And of course it can't be blindly enabled there, as the "online" operation should not be handled there in that case (or else there'll be colliding onlining requests from ACPI and xenbus). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:41:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:41:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503184.775374 (Exim 4.92) (envelope-from ) id 1pWwTt-0005SF-Nv; Tue, 28 Feb 2023 09:41:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503184.775374; Tue, 28 Feb 2023 09:41:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwTt-0005S8-LC; Tue, 28 Feb 2023 09:41:09 +0000 Received: by outflank-mailman (input) for mailman id 503184; Tue, 28 Feb 2023 09:41:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwTs-0005S2-Sl for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:41:08 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 055e84d4-b74c-11ed-a550-8520e6686977; Tue, 28 Feb 2023 10:41:06 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-90-IJDVr2aTPt6RuBqSL0DiIA-1; Tue, 28 Feb 2023 04:41:01 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF4002805588; Tue, 28 Feb 2023 09:41:00 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0344F492B12; Tue, 28 Feb 2023 09:40:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 055e84d4-b74c-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677577265; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iPwT6LbI6vnTr+kaV/WT6dv1nv2LsgKfksaLe2/+5Co=; b=hsLTtTQAhDQy1yu5BfbfJzpv7Om1OXzeumCgK/F2Eph4VHixwnbf8koc9A9QPQ8WLw7k2+ dApqrzGcERJZgFIrVGBNpa5MDoG7p8CdvW7npwPUe5n2dIdVKmLxbczDvlsat8iqRPmyEQ HOdERHQsPZZME8AWYOhEOrauDE/qiXE= X-MC-Unique: IJDVr2aTPt6RuBqSL0DiIA-1 Date: Tue, 28 Feb 2023 09:40:49 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: "Michael S. Tsirkin" , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: > On 28/02/2023 10.03, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 08:59:52AM +0000, Daniel P. Berrangé wrote: > > > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > > > > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > > > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > > > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: > > > > > > > I feel like we should have separate deprecation entries for the > > > > > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > > > > > although they're related they are independant features with > > > > > > > differing impact. eg removing qemu-system-i386 affects all > > > > > > > host architectures, not merely 32-bit x86 host, so I think we > > > > > > > can explain the impact more clearly if we separate them. > > > > > > > > > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > > > > > a superset. > > > > > > > > > > > > Removing support for building on 32 bit systems seems like a pity - it's > > > > > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > > > > > and the maintainance overhead is quite small. > > > > > > > > > > Note: We're talking about 32-bit *x86* hosts here. Do you really think that > > > > > someone is still using QEMU usermode emulation > > > > > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! > > > > > > > > I don't know - why x86 specifically? One can build a 32 bit binary on any host. > > > > I think 32 bit x86 environments are just more common in the cloud. > > > > > > Can you point to anything that backs up that assertion. Clouds I've > > > seen always give you a 64-bit environment, and many OS no longer > > > even ship 32-bit installable media. > > > > Sorry about being unclear. I meant that it seems easier to run CI in the > > cloud in a 32 bit x64 environment than get a 32 bit ARM environment. > > It's still doable ... but for how much longer? We're currently depending on > Fedora, but they also slowly drop more and more support for this > environment, see e.g.: FWIW, we should cull our fedora-i386-cross.docker dockerfile and replace it with a debian i686 dockerfile generated by lcitool. There's no compelling reason why i686 should be different from all our other cross builds which are based on Debian. The Debian lcitool generated container would have access to a wider range of deps than our hand written Fedora one. > https://www.theregister.com/2022/03/10/fedora_inches_closer_to_dropping/ With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Tue Feb 28 09:52:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 09:52:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503193.775388 (Exim 4.92) (envelope-from ) id 1pWweI-0007MW-Of; Tue, 28 Feb 2023 09:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503193.775388; Tue, 28 Feb 2023 09:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWweI-0007MP-LW; Tue, 28 Feb 2023 09:51:54 +0000 Received: by outflank-mailman (input) for mailman id 503193; Tue, 28 Feb 2023 09:51:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWweH-0007M5-LG for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 09:51:53 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0617.outbound.protection.outlook.com [2a01:111:f400:fe1f::617]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85f01fff-b74d-11ed-a550-8520e6686977; Tue, 28 Feb 2023 10:51:51 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7846.eurprd04.prod.outlook.com (2603:10a6:20b:2a0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 09:51:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 09:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85f01fff-b74d-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtlhpHPrV79o3YLAdv2k8BVo5reblpiAg6ep61gfjvHgfToahqHD7eWgwWp1nmcSFudaV89t3zkt2Y7cE4u3jBqauBHb3SCdIDHNv2+0Lo3J1ErNzEe8q+TNMWAjKUxJZsS8RNYwEWTvcyGnAZQx2EKaqAy3QV8JTHcVR5ZnFWGWHwGVLRSLSxzxl4bReIVxFTHvGJSoQVDEabRxsAvHlosojQSD+78MX2dc+JC/Ix9QgFxD/FKjEW6SUjLv42p2PeSwAlNmGuRwD2OJOMUI4Mwzw6tdePmLnEqKcgC1PyMGU5KKqDj0nnCcWMvSCLeMPhhG1pHIBNHbuMkh5C0m8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pdlyHaH4pBbO9XFUj7diphk7rtBCqFO2Dob1yEyk74=; b=Ul0wC7jWKvzkXwqQFZn6Nboc5muU96GNJ/Ncj5LwqfSzsu+PhoNn8qzS8GJKzii1xzNKTD3IQzXdSURPW8dKTjjoQdukaHLcj0jG/HyHbq2KQsSzICVpgwtplniCC0vH+6DDnCmmnlV9kedKWwtKZ7oKm7v0UN4MMb78p4yy2fJovzcZkJDnC9H8p8oIiXhjaKyLGSLEKhxBFfNoLjRJwMxYeE+t0b/yExivsXymB+0OtRelAYVdIdoSczn3EPQqnZaJBR+8ChJY4higZb01cYMJx1zp7Whbhlmz6a9PKivSVPhSaZfTdLARItmT3kralP7w4m8r06qrmrd2K8MnOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/pdlyHaH4pBbO9XFUj7diphk7rtBCqFO2Dob1yEyk74=; b=LCv7IqpAWp1lmBMhx2wOVDRPsLjOXek5Mxtp/adedIlHD4Ast4lCUZ8bwJKciExeic6djWwqO1FLxbPUrQvjt42tKR7ApfHe2jVcixw0lscB8enG82gqpIIBSuUczLIBeCf1uiyBPy6LSWezuhIUyAEXvBgZTYQiqptooO+7mv9PhkT9VY72gOgdmSf8SQW8wXVAxNUxs6pWmCrWQ+mxCcDTxng55rv2WssmFjh8QXoNNqJAmPY0a1oOJFrY4pguM5xxVgVgo19HphyBuGFp+Ctu9IPIsCTKMBxcn3NQNPZsU8rfHz43w8ndJ8VgQ90XPIC/8aehTdFV4lKIhpW0KQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52cdcad9-cd21-1132-ca9f-ba8092d649a8@suse.com> Date: Tue, 28 Feb 2023 10:51:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Kevin Tian , Marek Marczykowski From: Jan Beulich Subject: [PATCH] VT-d: constrain IGD check Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7846:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c7f81c6-c96e-4ce4-cad8-08db19716911 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ttg4PrNIGf+6c7vSlIBs91uvL9qhidGG6kYlO3rxb+3NPeBuH6/hqi2zd6V6zO2pm7IbsffnVvENE6Zl1S1mm7HzvK72VbiVl674Ryz6DvQyIgyqnmsOUe2zg+HtyuviCjqywHG9/Td532tjMSOmLHUA44tzwOXg08FaA/jRYZf9wZP1VFS+EtjDkvP/U1QL/Grb8DQVQjdKZDQBzxd4+2WzlkzhEJA9Tf4fRqXM57veOJoIeC4OwfJ8V95yDrVCK6SJ0Sku5qwMmBzK3oNK5LrfMu4ZsAzXi92GUBLq05vKvuqvcyvhAiCBZCiEDHxdVbUo/BGMkKvDiPgRsLBeeJ/RDwmb44+gjpMMA4hmgmy9ISWGbm7MzwY6yY8c7byZtLC1uSj3cJGdL/aTmvZs7tF2+FKQDWTxnCaZ2X/cf/vw9a7LLYdaEhzwhRULs1pjTMdLzscw6HKRQjcjuuh9EHrNeR8fy6vfbcBxWVoEN7NOSOdD6yWlKLWDhEdnlco0ZDbSWHrpkGx1Y+5qVQHrCdu5Ylyqtvno5SmM+WoCEZwNzC3v5OvKKWnp2HQ+BU+hyPViyV9cZO8E+fU/9+fzx93NbDmvPrY13Y4+V0r0Hwfxp9syAPO/IlIo5NQrPSwJYoYa6kMljJaKrHKgd5qOPnInzCgIxlubnF+wu54kmfLWbcgmBGJdXCmnAaeqFjCSA/vQ/FMSvlhpVRobtffVVniZDL6sHq97X+Qo6SreJAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199018)(36756003)(2616005)(26005)(186003)(478600001)(38100700002)(8936002)(41300700001)(6916009)(66556008)(66476007)(86362001)(31696002)(66946007)(8676002)(4326008)(316002)(54906003)(6486002)(2906002)(31686004)(5660300002)(6506007)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkVKT294VURXczQ5YzliR0Z2d1V2cjJMOFhjR1ROSzdDcTlZZGN2N3JtdTlj?= =?utf-8?B?azFyUVdLMGxIUVlIVHJFdXd2MkZ4Mjg1eE85cGNQTnBiTGVBMFVjOEZPNmtG?= =?utf-8?B?UmxmaVAwTVJZQmk2RlQ4R09BbitaSHIvY0NwZitiZHVidlVvdmpiclFTREhs?= =?utf-8?B?a2wxdUJYQzN5akhCaFpPRlpJekNKMjE5czFyWUFQTlc0a1FQeEtFU25UY0Vx?= =?utf-8?B?eEh6UHRQWDZyT3lNU0JDUzcyMi9rVG9OL0Q1Wmx6cmlTRTFUbkpYa1NhVW5E?= =?utf-8?B?ZnNwTEtsZE1oVEZRTlc5aHlXSDRyMzUydFZDMEw2NUJnTi9NbEgyQTRVWkNo?= =?utf-8?B?K2Z2b2VsRVJCTTZQdi9pd1llWHJTc3kxdm1mTmV1ZUQ5V0VFVXVIODE1R3Jt?= =?utf-8?B?QzVDKy9VQ0Qrbm9rZFNCKzBLWUtCM1lYMzZCQytRYThzSWUwelpDVjZYN0R1?= =?utf-8?B?ZHBkY1ROYWZSOHFTRGhJckJaWkQ1NXJvcFlzWEl3ZFIzTW1Kb1dtM1BEY21U?= =?utf-8?B?WW93a3RSVFdtd3hVenRqandIRjZEMjFmS2dEdy95c2ZMaFJhcG1ieTk0dWxR?= =?utf-8?B?Wng4SWpPbDRMQ0czeFp5Uzg0Znd2YlRzKzRha04vYldnZFlQcG9VV0pkUjFO?= =?utf-8?B?SE1EUUVJZENPRVFNUkJUazVxeXJvU1FSZ2dkaGtwWUNqSXRnSjNHS1dBTko3?= =?utf-8?B?cGpGQTNvY0tpeHZUdy9WdFBtcXg2YzlxY01QeVVVUzhkRmVWb08xYjA2YlIv?= =?utf-8?B?dkJPN3k4V2FCSi9XTzJ2MXF4bTZKeG9qMjFWMVRoUHNwNXh0TzJvR1pnL3lp?= =?utf-8?B?S2MyUmliOHEvREFvY3d1L1gzbUtoS2ZuYzBHWXM0dS9RMGVvM0JJUjVoSDVR?= =?utf-8?B?Y3UrYTk5dU9vaXFPc1FtYzhSeDVwSm1DZnV6eGRMWUdVM3BERFhtSW9pOUtF?= =?utf-8?B?YWVjRXdYdjdxL1pua2NKVUlxR2dTTDUwZTlZQi8rbitBZjFwUGtMWDZINDV3?= =?utf-8?B?WTJhMUVjSTI5Tm9vYXl4WnNndzl0T2hRUnZqQ2dESnhZVldwRjdNa2srT2V5?= =?utf-8?B?b2UzempmQ1IwMFVPRTRqc0ltZ3RFZlRHQ1Npa1Uzbk85bjFreWsvSWcxVDA4?= =?utf-8?B?c3BOemoyeGdsU1pXdDZ5RFRic2crWVlibkJTa2tMUld0L2ZIb29lR2M2bDR3?= =?utf-8?B?dktUUnNKb2RwVjlwTEJROW5zbU1xNlBtKzJhTTRUK09PV3YrL3ZxNFpjRkhO?= =?utf-8?B?OTVnTjBScThBbzVvelNiODhpVGxBRGVNKzhqTFJ1dXh5c1FOVDF3WEhxRm10?= =?utf-8?B?ZkNpZ0w0QzVoSEFLdUwvRTZvRk11RDR0RjdzdUJIcjFXMEZ4eTVYQ1lJdGNn?= =?utf-8?B?TEJ6elp0UzlmZmQ3NFlsNUNZRXZBSWdBYStmZFBkN1YvdmxPbnlUZkxhemNk?= =?utf-8?B?YWFUYXl1SFVoUDV5d0V5WUE4eGRUOWtDajNZRUxUT2xMZDZ6NkQyM2g1OWtm?= =?utf-8?B?cTMvUVJEVXcwaW1IVWpoeHZFZWdKRCthTHJYMzZoTFlqN0lWUnNUdEpqME8z?= =?utf-8?B?TWVLU1J0TGZ0M1NwVGlIYXhpMm16WmpiYStTNGlnbXEvN3pxdHlsSmlmRDJW?= =?utf-8?B?MERqNnRNazlZYlVHTEc0UmFoVDJUaXJIUGRJTjV0Q1JJQXY2NldwRHlick8y?= =?utf-8?B?OU5xc3hnUjJ2YmRqR000VlVwTFdLTnMwNzlaTjNyM1pPMytwNGVhemhhNXNT?= =?utf-8?B?dkkvL1V2SmpWdkEzYmJBUjFPVUlOU0huZy9ENHB5eGNsUTZaa0JXRUJiRThh?= =?utf-8?B?KzFYSDlwOWZvRGg2VWFpbnVsWkJKeFIzRDgwS2ZMbTg3MmRpMGROUkc3VWs3?= =?utf-8?B?dUtSMDc2U1ArQXhrUlcyR0RwOU5JRDg2ZG14bks5cnNEQ2ZWMTlNQ0d1Vm1m?= =?utf-8?B?dkd4RHgwNkNLN0l4RVVvUGNUVks5QlAzM0p2OCszeGhTdU4yaXRYRlRIaXht?= =?utf-8?B?djd6L1N4aldqN3FWSDVZV0drdDBhN0V3SzV1cXVQN2l4QWVPTHk2OFF4TEt3?= =?utf-8?B?RzlpSlYrQUc4aXJhd1l3QnhQWkZWR0VXU0lOWWcweW1OL3ZtbjJ5MUZoakgx?= =?utf-8?Q?EQ+ysLtgJI7bIX8yABrVY9Erx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c7f81c6-c96e-4ce4-cad8-08db19716911 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 09:51:48.9548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qJEJeWxJsXbSoMbiaoB4nJiUFm4FRR3juc1OgX/BKtl0VKN+Wq+Wt0BL2UyUR2u6yrGqEELg9qG62OH7AVSXGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7846 Marking a DRHD as controlling an IGD isn't very sensible without checking that at the very least it's a graphics device that lives at 0000:00:02.0. Re-use the reading of the class-code to control both the clearing of "gfx_only" and the setting of "igd_drhd_address". Signed-off-by: Jan Beulich --- This way we also read the class code when we don't really need it, but I think that's tolerable, and the simpler logic is preferable. The more that with Marek's proposed patch, adjusted as suggested, we'd read vendor and device IDs unconditionally for all devices (enumerated for a DRHD) anyway. --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -391,15 +391,12 @@ static int __init acpi_parse_dev_scope( if ( drhd ) { - if ( (seg == 0) && (bus == 0) && (path->dev == 2) && - (path->fn == 0) ) - igd_drhd_address = drhd->address; - - if ( gfx_only && - pci_conf_read8(PCI_SBDF(seg, bus, path->dev, path->fn), + if ( pci_conf_read8(PCI_SBDF(seg, bus, path->dev, path->fn), PCI_CLASS_DEVICE + 1) != 0x03 /* PCI_BASE_CLASS_DISPLAY */ ) gfx_only = false; + else if ( !seg && !bus && path->dev == 2 && !path->fn ) + igd_drhd_address = drhd->address; } break; From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:11:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:11:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503208.775398 (Exim 4.92) (envelope-from ) id 1pWwxK-00029I-CW; Tue, 28 Feb 2023 10:11:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503208.775398; Tue, 28 Feb 2023 10:11:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwxK-00029B-9V; Tue, 28 Feb 2023 10:11:34 +0000 Received: by outflank-mailman (input) for mailman id 503208; Tue, 28 Feb 2023 10:11:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWwxI-000295-Jh for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:11:32 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43f663b2-b750-11ed-a550-8520e6686977; Tue, 28 Feb 2023 11:11:29 +0100 (CET) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-595-09S_Es5xONijalfTxXXmWA-1; Tue, 28 Feb 2023 05:11:26 -0500 Received: by mail-ed1-f70.google.com with SMTP id ck7-20020a0564021c0700b004a25d8d7593so13182481edb.0 for ; Tue, 28 Feb 2023 02:11:26 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id gg4-20020a170906e28400b008b1779ba3c1sm4349246ejb.115.2023.02.28.02.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 02:11:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43f663b2-b750-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677579088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VUsHXm3vGD11b06eHDzEiEyoV6j+i/reAk8OksRIJe4=; b=bA4isbCU9jAQEoDGGyJAKam3z8rsLjVp0nFnkACCRZdKUa+CAOkxeBbILHbifTpFiuEr0v 2dLFxY3UGUKlHHxpUcQyxodio1pey6HdFIC/In55VtI/akhuVE1UVULpp5P4rzk7f9iVex HdhcJwz7kwxojW88KaJzu1VQX0kfDiM= X-MC-Unique: 09S_Es5xONijalfTxXXmWA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677579085; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VUsHXm3vGD11b06eHDzEiEyoV6j+i/reAk8OksRIJe4=; b=r6ZNVv4m6I4mQzok9wlfQjQocmBQ4XDF+Axnkr6aalSTziJJfcCwZ2GKDsbZoZt2BD e/ry9aOrOfxoYODGakD6yd9EgHkBpkju14OpqmEqD3hfDDJVLmo56Y9RTV7XQ6T1W18e ju3H8xQccxVePb6JhbmLkPpfwAGDJ6HALneKdNG4folEPiZa08V40mIRq0g3gb8rDZmq YOsTOPxByr111cfMxY+/mIoAjMJCxEZXI0lEtU1G+MxZGGDlEShDYMuciKevInV03kAU 3w4WwVgwIm1h7Nf+OYU0ld+SiSA2zFCPjKSIPeHZMI2GJttQL+rN46yyZdqaGtjvnTzL M3Gw== X-Gm-Message-State: AO0yUKUPgbMlHu5X4mEd39O0k7xohfz5BVIk6D4MXVUuTN5e9Qt7s9y6 nUSXrYAliVqLSmdB+uAyIXGIhxLwqebfQa+HQFAK7ck/i1FwYv/h5qjL79SC8VgSRlAzhFQ1uEX 6B4Wqu3fX/yVBfwpY3+cXIWzgR2s= X-Received: by 2002:a17:907:cb81:b0:8b0:fbd1:1a61 with SMTP id un1-20020a170907cb8100b008b0fbd11a61mr2776590ejc.52.1677579085708; Tue, 28 Feb 2023 02:11:25 -0800 (PST) X-Google-Smtp-Source: AK7set8xTF/bnD+AxesQL3OArWO5MlnXAcPheJM7sgj7/8nBceO+OQxCu+BpM+tstcL3jw1NyHbFqQ== X-Received: by 2002:a17:907:cb81:b0:8b0:fbd1:1a61 with SMTP id un1-20020a170907cb8100b008b0fbd11a61mr2776557ejc.52.1677579085382; Tue, 28 Feb 2023 02:11:25 -0800 (PST) Date: Tue, 28 Feb 2023 05:11:20 -0500 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Thomas Huth , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228050908-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Feb 28, 2023 at 09:40:49AM +0000, Daniel P. Berrang wrote: > On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: > > On 28/02/2023 10.03, Michael S. Tsirkin wrote: > > > On Tue, Feb 28, 2023 at 08:59:52AM +0000, Daniel P. Berrang wrote: > > > > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: > > > > > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: > > > > > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: > > > > > > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang wrote: > > > > > > > > I feel like we should have separate deprecation entries for the > > > > > > > > i686 host support, and for qemu-system-i386 emulator binary, as > > > > > > > > although they're related they are independant features with > > > > > > > > differing impact. eg removing qemu-system-i386 affects all > > > > > > > > host architectures, not merely 32-bit x86 host, so I think we > > > > > > > > can explain the impact more clearly if we separate them. > > > > > > > > > > > > > > Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is > > > > > > > a superset. > > > > > > > > > > > > > > Removing support for building on 32 bit systems seems like a pity - it's > > > > > > > one of a small number of ways to run 64 bit binaries on 32 bit systems, > > > > > > > and the maintainance overhead is quite small. > > > > > > > > > > > > Note: We're talking about 32-bit *x86* hosts here. Do you really think that > > > > > > someone is still using QEMU usermode emulation > > > > > > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd be very surprised! > > > > > > > > > > I don't know - why x86 specifically? One can build a 32 bit binary on any host. > > > > > I think 32 bit x86 environments are just more common in the cloud. > > > > > > > > Can you point to anything that backs up that assertion. Clouds I've > > > > seen always give you a 64-bit environment, and many OS no longer > > > > even ship 32-bit installable media. > > > > > > Sorry about being unclear. I meant that it seems easier to run CI in the > > > cloud in a 32 bit x64 environment than get a 32 bit ARM environment. > > > > It's still doable ... but for how much longer? We're currently depending on > > Fedora, but they also slowly drop more and more support for this > > environment, see e.g.: > > FWIW, we should cull our fedora-i386-cross.docker dockerfile and > replace it with a debian i686 dockerfile generated by lcitool. > There's no compelling reason why i686 should be different from > all our other cross builds which are based on Debian. The Debian > lcitool generated container would have access to a wider range > of deps than our hand written Fedora one. > > > https://www.theregister.com/2022/03/10/fedora_inches_closer_to_dropping/ > > With regards, > Daniel ... and is closer to where 32 bit is likely to be deployed which is systems like e.g. raspberry pi os which until recently was only 32 bit. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:24:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:24:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503216.775408 (Exim 4.92) (envelope-from ) id 1pWxA4-000401-Hp; Tue, 28 Feb 2023 10:24:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503216.775408; Tue, 28 Feb 2023 10:24:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxA4-0003zu-Ek; Tue, 28 Feb 2023 10:24:44 +0000 Received: by outflank-mailman (input) for mailman id 503216; Tue, 28 Feb 2023 10:24:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxA4-0003zo-23 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:24:44 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c1e1017-b752-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 11:24:42 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c1e1017-b752-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677579881; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=9XvZtlxH5GfF+AFGiSjc3odNHkgkPlPvaXMY6RXprKo=; b=NAPBx4T9o5SFQmQTnyv+u/gRoWSDNn3WTZsiVe/71OGBL7VihOBOc4qe kKDpk6KNkMb8vlgZXKuXwNnxlBl+yO4I4u6ycA/xrJbbs4UsnCmlM/z1+ YjB2GXBqg5mB+grWFPJnlDrz2rjAlJIXBiF7PF3NTpUngWJ0RUm2JaxXv c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 98730083 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:vSojrK/lzSnbegvQ8RLyDrUDTH6TJUtcMsCJ2f8bNWPcYEJGY0x3x mIXWWmBO67YZTb2Kttxa9jn9kpXuJ6En99hHFY/+Xg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmP6ob5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk0 NkRdGs2YCzaiti/7IO+RsdBl5saeZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0EzhnD/ jqWpAwVBDk7btGYkTOG+U6R3NDIliLDAqEAS7eno6sCbFq7mTVIVUx+uUGAifuzh1O6WtlfA 1cJ4Sdopq83nGSpSdS7XRy+iHmetxUYVpxbFOhSwAuK0KvPpQGCGnIDUCVCefQhrsY9QTFs3 ViM9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLiIgrgwjGVNpLDK+/hdqzEjb1q w1mtwBn2e9V15RSkfzmoxae2WnESoX1ohAdzCDyVz7+1Q1FPYOfbqCZ7FT1wOcfFdPMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1HszDaJz9zq3+KTJrU3YE cbzTCpUJSxGYZmLNRLvLwvn7Zclxzol2UTYTo3hwhKs3NK2PSDKFupfagrWMrFlvctoRTk5F P4FaqO3J+h3CrWiMkE7D6ZIRbz1EZTLLc+v8JEGHgJyCgFnBHsgG5fsLUAJIuRYc1Buvr6Qp BmVAxYIoGcTcFWbcW1mnFg/MuKwNXu+xFpnVRER0aGAgCF6MN31t/dCJvPav9APrYRe8BK9d NFdE+3oPxiFYm2vF+g1BXUlkLFfSQ== IronPort-HdrOrdr: A9a23:1znaP6/06VvgkLQlYzduk+D6I+orL9Y04lQ7vn2ZKCY7TiX8ra uTdZsgpHrJYVoqNE3I5+rhBEDwex3hHPdOiOF9AV7hZniEhIKGFvAE0WKI+Vzd8kPFh4xg/J tBN45jFdb3EV92tsri5hKkeuxQuOVviJrY4ds31B1WPGdXgkxbnn5E4o33KCdLeDU= X-IronPort-AV: E=Sophos;i="5.98,221,1673931600"; d="scan'208";a="98730083" Date: Tue, 28 Feb 2023 10:24:35 +0000 From: Anthony PERARD To: Jan Beulich CC: Joe Jin , Boris Ostrovsky , Subject: Re: Is xl vcpu-set broken Message-ID: References: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> <467c21e0-e41f-3d52-f5e0-8bcc70bfc923@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <467c21e0-e41f-3d52-f5e0-8bcc70bfc923@suse.com> On Tue, Feb 28, 2023 at 10:37:00AM +0100, Jan Beulich wrote: > On 28.02.2023 07:44, Joe Jin wrote: > > We encountered a vcpu-set issue on old xen, when I tried to confirm > > if xen upstream xen has the same issue I find neither my upstream build > > nor ubuntu 22.04 xen-hypervisor-4.16 work. > > > > I can add vcpus(8->16) to my guest but I can not reduce vcpu number: > > > > root@ubuntu2204:~/vm# xl list > > Name ID Mem VCPUs State Time(s) > > Domain-0 0 255424 32 r----- 991.9 > > testvm 1 4088 16 -b---- 94.6 > > root@ubuntu2204:~/vm# xl vcpu-set testvm 8 > > root@ubuntu2204:~/vm# xl list > > Name ID Mem VCPUs State Time(s) > > Domain-0 0 255424 32 r----- 998.5 > > testvm 1 4088 16 -b---- 97.3 > > > > After xl vcpu-set, xenstore showed online cpu number reduced to 8: [...] > > > > But guest did not received any offline events at all. > > > > From source code my understand is for cpu online, libxl will > > send device_add to qemu to trigger vcpu add, for cpu offline, > > it still rely on xenstore, is this correct? > > Judging from the DSDT we provide, offlining looks to also be intended to > go the ACPI way. Whereas libxl only ever sends "device_add" commands to > qemu, afaics (or "cpu-add" for older qemu). Anthony - do you have any > insight what the intentions here are? The intention is to one day implement cpu offline in QEMU upstream for HVM guest, I don't think that's ever been done so far. As we use device_add for cpu hotplug, we would probably do device_del for hot-unplug, so qemu would still have to send the appropriate even to the guest. Someone will have to figure out if "device_del" works with a Xen guest, doc here: https://www.qemu.org/docs/master/system/cpu-hotplug.html#vcpu-hot-unplug Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:31:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503222.775418 (Exim 4.92) (envelope-from ) id 1pWxGC-0005rH-BM; Tue, 28 Feb 2023 10:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503222.775418; Tue, 28 Feb 2023 10:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxGC-0005rA-8Y; Tue, 28 Feb 2023 10:31:04 +0000 Received: by outflank-mailman (input) for mailman id 503222; Tue, 28 Feb 2023 10:31:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxGA-0005r4-VU for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:31:03 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id febe4694-b752-11ed-a550-8520e6686977; Tue, 28 Feb 2023 11:31:00 +0100 (CET) Received: by mail-lj1-x231.google.com with SMTP id f16so9630224ljq.10 for ; Tue, 28 Feb 2023 02:31:00 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id b28-20020a05651c033c00b002947028ae7csm1132356ljp.72.2023.02.28.02.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 02:30:59 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: febe4694-b752-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=R9s7fnqgePtqWJ7qc7BcwaGOakPxblytLMey93ztBk0=; b=XaXKaO41glMOigeY1OIkkBejuQYc6sV9t8ovZgfRVyl3TQvlVEsRZfYGfYHo6u0yqe S7L37x0pqKtVf0i+39bploFhMTCCDjGvV6umauFfsusjvGfcNytNlcxWWEcw+cqO7bh5 0rpHbuwaz0RqythGPRDKlaWEmW5bYbfHqypXc3R8zdMVneUYx+mSvycOwDFZ8ubjfokg SFiyLxSd0pJ/lpPnIMTRZ10WtZGbcahV+7aMKTdUBdwpXqAqYz3Lbc8KxPR9aBbhh5Cd kPw50wWXDLLv1Z6zdMHQabuzoYRqt8zYEGuUIgAG7xpy2AIHThSMiVd4iFGyPKCN26PG i1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R9s7fnqgePtqWJ7qc7BcwaGOakPxblytLMey93ztBk0=; b=2HhQmvjvyXbseM4N9NRYXxnz2V7lzt42fwSeP3sjKL9C7pSaxgR0iyLWcKXtOXyGpm EtmbUU5LXwfB9O8O00d8nE7s0gXMa308sVM49dpbXpnp/ZZOo40RicermsS8b6ML6+bG Wz3T/JeWmCoXakzuguCpTM1YMtYSb9hbe9DhBOwVGaQz21KAiGzZHVu+1SEhDrz33gYn idjEyQT3ec3MLWMllTFz0Rbba4d9NZmG+zFt4mRd3ZPhtnnK6HwbP7VXau8qPX0ilydU D0FLdBFiLz0Nfyz78BuK8WizEn0IEPJsDLM3bQIQWPnf7DICdMVg62A9PVQV/PxEXSnN L46g== X-Gm-Message-State: AO0yUKW3C502ibVB1PC1o7u/Y7Z2PC+FAbGv0WzHasL5TnzrvxcduAdg 9QxOQ0nYxa+gWpwgsu4q0I4= X-Google-Smtp-Source: AK7set/OMNpz1pE7SCF9PRP6SmN1T4NKTyBlCrYuvaVsPvFK7ya7hhi8k0HXhCkc4VB6xvn2hsgsDQ== X-Received: by 2002:a2e:86d9:0:b0:295:a3a9:a3e4 with SMTP id n25-20020a2e86d9000000b00295a3a9a3e4mr737811ljj.45.1677580260151; Tue, 28 Feb 2023 02:31:00 -0800 (PST) Message-ID: <507c5449a56ce5cf5758bef967d511bf545d8405.camel@gmail.com> Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 28 Feb 2023 12:30:57 +0200 In-Reply-To: References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 T24gTW9uLCAyMDIzLTAyLTI3IGF0IDE1OjIzICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAyNC4wMi4yMDIzIDEyOjMxLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ID4gLS0tIC9kZXYv bnVsbAo+ID4gKysrIGIveGVuL2NvbW1vbi9idWcuYwo+ID4gQEAgLTAsMCArMSwxMDkgQEAKPiA+ ICsjaW5jbHVkZSA8eGVuL2J1Zy5oPgo+ID4gKyNpbmNsdWRlIDx4ZW4vZGVidWdnZXIuaD4KPiA+ ICsjaW5jbHVkZSA8eGVuL2Vycm5vLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9rZXJuZWwuaD4KPiA+ ICsjaW5jbHVkZSA8eGVuL2xpdmVwYXRjaC5oPgo+ID4gKyNpbmNsdWRlIDx4ZW4vc3RyaW5nLmg+ Cj4gPiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPgo+ID4gKyNpbmNsdWRlIDx4ZW4vdmlydHVhbF9y ZWdpb24uaD4KPiA+ICsKPiA+ICsjaW5jbHVkZSA8YXNtL3Byb2Nlc3Nvci5oPgo+ID4gKwo+ID4g Ky8qIFNldCBkZWZhdWx0IHZhbHVlIGZvciBUUkFQX2ludmFsaWRfb3AgYXMgaXQgaXMgZGVmaW5l ZCBvbmx5IGZvcgo+ID4gWDg2IG5vdyAqLwo+ID4gKyNpZm5kZWYgVFJBUF9pbnZhbGlkX29wCj4g PiArI2RlZmluZSBUUkFQX2ludmFsaWRfb3AgMAo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gK2ludCBk b19idWdfZnJhbWUoY29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MsIHVuc2lnbmVkIGxv bmcKPiA+IHBjKQo+ID4gK3sKPiA+ICvCoMKgwqAgY29uc3Qgc3RydWN0IGJ1Z19mcmFtZSAqYnVn ID0gTlVMTDsKPiA+ICvCoMKgwqAgY29uc3Qgc3RydWN0IHZpcnR1YWxfcmVnaW9uICpyZWdpb247 Cj4gPiArwqDCoMKgIGNvbnN0IGNoYXIgKnByZWZpeCA9ICIiLCAqZmlsZW5hbWUsICpwcmVkaWNh dGU7Cj4gPiArwqDCoMKgIHVuc2lnbmVkIGxvbmcgZml4dXA7Cj4gPiArwqDCoMKgIHVuc2lnbmVk IGludCBpZCA9IEJVR0ZSQU1FX05SLCBsaW5lbm87Cj4gPiArCj4gPiArwqDCoMKgIHJlZ2lvbiA9 IGZpbmRfdGV4dF9yZWdpb24ocGMpOwo+ID4gK8KgwqDCoCBpZiAoIHJlZ2lvbiApCj4gPiArwqDC oMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoCBmb3IgKCBpZCA9IDA7IGlkIDwgQlVHRlJBTUVfTlI7 IGlkKysgKQo+ID4gK8KgwqDCoMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGNvbnN0IHN0cnVjdCBidWdfZnJhbWUgKmI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1 bnNpZ25lZCBpbnQgaTsKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZvciAoIGkg PSAwLCBiID0gcmVnaW9uLT5mcmFtZVtpZF0uYnVnczsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGkgPCByZWdpb24tPmZyYW1lW2lkXS5uX2J1Z3M7IGIrKywgaSsrICkK PiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgaWYgKCBidWdfbG9jKGIpID09IHBjICkKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgewo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGJ1ZyA9IGI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290 byBmb3VuZDsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQo+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqAgfQo+ID4gK8KgwqDCoMKgwqDCoMKgIH0KPiA+ICvCoMKgwqAgfQo+ ID4gKwo+ID4gKyBmb3VuZDoKPiA+ICvCoMKgwqAgaWYgKCAhYnVnICkKPiA+ICvCoMKgwqDCoMKg wqDCoCByZXR1cm4gLUVJTlZBTDsKPiA+ICsKPiA+ICvCoMKgwqAgaWYgKCBpZCA9PSBCVUdGUkFN RV9ydW5fZm4gKQo+ID4gK8KgwqDCoCB7Cj4gPiArI2lmZGVmIEJVR19GTl9SRUcKPiA+ICvCoMKg wqDCoMKgwqDCoCB2b2lkICgqZm4pKGNvbnN0IHN0cnVjdCBjcHVfdXNlcl9yZWdzICopID0gKHZv aWQgKilyZWdzLQo+ID4gPkJVR19GTl9SRUc7Cj4gPiArI2Vsc2UKPiA+ICvCoMKgwqDCoMKgwqDC oCB2b2lkICgqZm4pKGNvbnN0IHN0cnVjdCBjcHVfdXNlcl9yZWdzICopID0gYnVnX3B0cihidWcp Owo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIGZuKHJlZ3MpOwo+ID4gKwo+ ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBpZDsKPiA+ICvCoMKgwqAgfQo+ID4gKwo+ID4gK8Kg wqDCoCAvKiBXQVJOLCBCVUcgb3IgQVNTRVJUOiBkZWNvZGUgdGhlIGZpbGVuYW1lIHBvaW50ZXIg YW5kIGxpbmUKPiA+IG51bWJlci4gKi8KPiA+ICvCoMKgwqAgZmlsZW5hbWUgPSBidWdfcHRyKGJ1 Zyk7Cj4gPiArwqDCoMKgIGlmICggIWlzX2tlcm5lbChmaWxlbmFtZSkgJiYgIWlzX3BhdGNoKGZp bGVuYW1lKSApCj4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArwqDCoMKg IGZpeHVwID0gc3RybGVuKGZpbGVuYW1lKTsKPiA+ICvCoMKgwqAgaWYgKCBmaXh1cCA+IDUwICkK PiA+ICvCoMKgwqAgewo+ID4gK8KgwqDCoMKgwqDCoMKgIGZpbGVuYW1lICs9IGZpeHVwIC0gNDc7 Cj4gPiArwqDCoMKgwqDCoMKgwqAgcHJlZml4ID0gIi4uLiI7Cj4gPiArwqDCoMKgIH0KPiA+ICvC oMKgwqAgbGluZW5vID0gYnVnX2xpbmUoYnVnKTsKPiA+ICsKPiA+ICvCoMKgwqAgc3dpdGNoICgg aWQgKQo+ID4gK8KgwqDCoCB7Cj4gPiArwqDCoMKgIGNhc2UgQlVHRlJBTUVfd2FybjoKPiA+ICvC oMKgwqDCoMKgwqDCoCBwcmludGsoIlhlbiBXQVJOIGF0ICVzJXM6JWRcbiIsIHByZWZpeCwgZmls ZW5hbWUsIGxpbmVubyk7Cj4gPiArwqDCoMKgwqDCoMKgwqAgc2hvd19leGVjdXRpb25fc3RhdGUo cmVncyk7Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGlkOwo+ID4gKwo+ID4gK8Kg wqDCoCBjYXNlIEJVR0ZSQU1FX2J1ZzoKPiA+ICvCoMKgwqDCoMKgwqDCoCBwcmludGsoIlhlbiBC VUcgYXQgJXMlczolZFxuIiwgcHJlZml4LCBmaWxlbmFtZSwgbGluZW5vKTsKPiA+ICsKPiA+ICvC oMKgwqDCoMKgwqDCoCBpZiAoIGRlYnVnZ2VyX3RyYXBfZmF0YWwoVFJBUF9pbnZhbGlkX29wLCBy ZWdzKSApCj4gCj4gVFJBUF9pbnZhbGlkX29wIGlzLCBhcyBzYWlkLCBhYm91dCB0byBkaXNhcHBl YXIgb24geDg2IGFzIHdlbGwuIEkKPiB0aGluawo+IHRoaXMgY29uc3RydWN0IHdhbnRzIGFic3Ry YWN0aW5nIGJ5IGFub3RoZXIgYXNtL2J1Zy5oIHByb3ZpZGVkIG1hY3JvCj4gKHRha2luZyBqdXN0 IHJlZ3MpLgo+IApUaGFua3MgZm9yIHRoZSBsaW5rLgoKTmljZSBpZGVhIHRvIGFic3RyYWN0ICdk ZWJ1Z2dlcl90cmFwX2ZhdGFsKFRSQVBfaW52YWxpZF9vcCwgcmVncyknLgpBY3R1YWxseSB3ZSBo YXZlIHRvIG9wdGlvbnMgaGVyZToKMS4gQXMgeW91IHByb3Bvc2VkIGFic3RyYWN0IGluIDxhc20v YnVnLmg+OgogICB4ODY6ICAjZGVmaW5lIERFQlVHX1RSQVBfRkFUQUwocmVncykgZGVidWdnZXJf dHJhcF9mYXRhbChYODZfRVhDX0dQLApyZWdzKQogICBBUk06ICNkZWZpbmUgREVCVUdfVFJBUF9G QVRBTChyZWdzKSAwCiAgIFJJU0MtVjogI2RlZmluZSBERUJVR19UUkFQX0ZBVEFMKHJlZ3MpIDAK ICBGb3IgQVJNIGFuZCBSSVNDLVYgaXQgZG9lc24ndCB1c2Ugc28gd2UgY2FuIHNraXAgdGhlIGNo ZWNrIGlmICgKREVCVUdfVFJBUF9GQVRBTCApLgoKMi4gQWJzdHJhY3Qgb25seSBUUkFQX2ludmFs aWRfb3AgaW4gPGFzbS9idWcuaD4KICB4ODY6ICNkZWZpbmUgVFJBUF9pbnZhbHVkX29wIFg4Nl9F WENfR1AKICBSSVNDLVY6ICNkZWZpbmUgVFJBUF9pbnZhbGlkX29wIDAKICBBUk46ICNkZWZpbmUg VFJBUF9pbnZhbGlkX29wIDAKICAKICBJIGFtIG5vdCBzdXJlIGlmIHdlIGhhdmUgdG8gcHJvdmlk ZSByZWFsIGludmFsaWQgb3Bjb2RlcyBmb3IgUklTQy1WCmFuZCBBUk0gYXMgaXQgbG9va3MgbGlr ZSBkZWJ1Z190cmFwX2ZhdGFsKCkgaXNuJ3QgdXNlZCBpbiBBUk0mUklTQy1WCm5vdy4KCkNvdWxk IHlvdSBwbGVhc2Ugc3VnZ2VzdCB3aGljaCBvbmUgb3B0aW9uIGlzIGJldHRlcj8KCn4gT2xla3Np aQoKICAKCj4gSmFuCgo= From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:36:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503228.775428 (Exim 4.92) (envelope-from ) id 1pWxL6-0006UR-UA; Tue, 28 Feb 2023 10:36:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503228.775428; Tue, 28 Feb 2023 10:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxL6-0006UK-RI; Tue, 28 Feb 2023 10:36:08 +0000 Received: by outflank-mailman (input) for mailman id 503228; Tue, 28 Feb 2023 10:36:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxL4-0006UB-RD for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:36:06 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2d48e1f-b753-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 11:36:03 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id az36so6072119wmb.1 for ; Tue, 28 Feb 2023 02:36:02 -0800 (PST) Received: from smtpclient.apple (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id z14-20020a05600c220e00b003e11f280b8bsm15403749wml.44.2023.02.28.02.36.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2023 02:36:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2d48e1f-b753-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JGLeblcmBGk6y9bwTMPY/mk+Czph7mN7rCy0DyVYDaE=; b=i03uKIFbFYWJvXc2k4z/o10JO/BiIoq6vgfPGXO6QVcGD/MVt91WalMRNj3HVlThRL ijNhvJfGhihKdF/gUkBKU5c23zCcab5v31ZWfuYl2ekCCWx78VSsg/SmF/dP645usu/Q QrMNNUvstfBRtCW2A24YiHbjohs5+o66y32UE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGLeblcmBGk6y9bwTMPY/mk+Czph7mN7rCy0DyVYDaE=; b=VssJLxKzo/N+baJFmsAFxcjuuhisJ3Fey1xJjn2KB3Sr5w+KFL4swTCjpQ6/dxdRxZ tOzEjjuvpXT7liPBs0xy+oY8bwGc1i9vIUr8HG+PnNFD3H0h/YHm0sakG/awoHzpfwzY LqZ1wyUqxwtwS9/FJTS9c3RWf0NTbn3ZmwBTXGTaM3vOFBIJkprOzyLgKE/FXtiThz+Z oGFE+vLh82ndzABTyGTMV2sDqWrRorT3HvhAsmXYx40Heg55LWUnAhp2CkVLAtwzqdHZ v0BIFSX6Mn/t5nIAKYAABRYdgl3sufRKLpseaui+L0Q61bIB1NDSHrsmTc44mG1OpIMP wcGg== X-Gm-Message-State: AO0yUKWfhdgUfRVAfCxDbRv1S3QVi4aOWirPHCRiZ+x3kiu8Sq1uDZ7G /vNUJXeNHUZSFGbHXp3NEyTuyQ== X-Google-Smtp-Source: AK7set/++YXjnoLEdpNkP63TFAJbWOuJARn1sXAItRDt640/wHjWUMN/85rQox53hLw1g41p/05VJg== X-Received: by 2002:a05:600c:1652:b0:3eb:399d:ab18 with SMTP id o18-20020a05600c165200b003eb399dab18mr1682758wmn.35.1677580562277; Tue, 28 Feb 2023 02:36:02 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v2 0/4] tools: use xen-tools/libs.h for common definitions From: Christian Lindig In-Reply-To: <20230227154153.31080-1-jgross@suse.com> Date: Tue, 28 Feb 2023 10:36:00 +0000 Cc: Xen-devel , Wei Liu , Anthony PERARD , Jan Beulich , Andrew Cooper , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Konrad Rzeszutek Wilk , Ross Lagerwall , Christian Lindig , David Scott , =?utf-8?Q?Marek_Marczykowski-G=C3=B3recki?= , Julien Grall , George Dunlap Content-Transfer-Encoding: 7bit Message-Id: References: <20230227154153.31080-1-jgross@suse.com> To: Juergen Gross X-Mailer: Apple Mail (2.3696.120.41.1.1) > On 27 Feb 2023, at 15:41, Juergen Gross wrote: > > There are some macros defined multiple times in tools. Use only > a single header file for defining those macros and drop the copies. > > V2: > - add patch 1 (Andrew Cooper) > > Juergen Gross (4): > tools: rename xen-tools/libs.h file to common-macros.h > tools: add container_of() macro to xen-tools/common-macros.h > tools: get rid of additional min() and max() definitions > tools: add offsetof() to xen-tools/common-macros.h > > tools/console/daemon/io.c | 2 +- > tools/firmware/hvmloader/util.h | 11 ++-------- > tools/firmware/include/stddef.h | 4 ++-- > tools/fuzz/cpu-policy/afl-policy-fuzzer.c | 2 +- > .../xen-tools/{libs.h => common-macros.h} | 22 ++++++++++++++++--- > tools/libfsimage/Rules.mk | 2 ++ > tools/libfsimage/xfs/fsys_xfs.c | 4 +--- > tools/libs/call/buffer.c | 2 +- > tools/libs/ctrl/xc_pm.c | 2 +- > tools/libs/ctrl/xc_private.h | 2 +- > tools/libs/foreignmemory/linux.c | 2 +- > tools/libs/gnttab/freebsd.c | 2 +- > tools/libs/gnttab/linux.c | 2 +- > tools/libs/guest/xg_core_arm.c | 2 +- > tools/libs/guest/xg_cpuid_x86.c | 2 +- > tools/libs/guest/xg_dom_arm.c | 2 +- > tools/libs/guest/xg_dom_bzimageloader.c | 2 +- > tools/libs/guest/xg_dom_x86.c | 2 +- > tools/libs/guest/xg_sr_common.c | 2 +- > tools/libs/light/libxl_internal.h | 2 +- > tools/libs/light/libxl_psr.c | 2 +- > tools/libs/stat/xenstat_linux.c | 2 +- > tools/libs/vchan/init.c | 7 +----- > tools/misc/xen-access.c | 2 +- > tools/misc/xen-cpuid.c | 2 +- > tools/misc/xen-diag.c | 2 +- > tools/misc/xen-hptool.c | 2 +- > tools/misc/xen-livepatch.c | 2 +- > tools/misc/xen-mfndump.c | 2 +- > tools/misc/xenpm.c | 2 +- > tools/ocaml/libs/mmap/xenmmap_stubs.c | 2 +- > tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- > tools/python/xen/lowlevel/xc/xc.c | 2 +- > tools/tests/cpu-policy/test-cpu-policy.c | 2 +- > .../paging-mempool/test-paging-mempool.c | 2 +- > tools/tests/resource/test-resource.c | 2 +- > tools/tests/tsx/test-tsx.c | 2 +- > tools/tests/vhpet/emul.h | 16 +------------- > tools/tests/vpci/emul.h | 22 +------------------ > tools/tests/x86_emulator/x86-emulate.h | 7 +----- > tools/tests/xenstore/test-xenstore.c | 2 +- > tools/xenstore/list.h | 6 ++--- > tools/xenstore/utils.h | 2 +- > tools/xentrace/analyze.h | 2 +- > tools/xl/xl_cmdtable.c | 2 +- > xen/lib/x86/private.h | 2 +- > 46 files changed, 68 insertions(+), 105 deletions(-) > rename tools/include/xen-tools/{libs.h => common-macros.h} (74%) > > -- > 2.35.3 > Acked-by: Christian Lindig From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:40:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:40:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503232.775438 (Exim 4.92) (envelope-from ) id 1pWxOf-0007Po-CK; Tue, 28 Feb 2023 10:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503232.775438; Tue, 28 Feb 2023 10:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxOf-0007Ph-9f; Tue, 28 Feb 2023 10:39:49 +0000 Received: by outflank-mailman (input) for mailman id 503232; Tue, 28 Feb 2023 10:39:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxOe-0007Pb-1F for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:39:48 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 37e30e76-b754-11ed-9693-2f268f93b82a; Tue, 28 Feb 2023 11:39:47 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-lf9JwHrrNxiA7gTzVlLOEg-1; Tue, 28 Feb 2023 05:39:42 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D422A293248C; Tue, 28 Feb 2023 10:39:40 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91E7E2026D68; Tue, 28 Feb 2023 10:39:40 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7BCBB21E6A1F; Tue, 28 Feb 2023 11:39:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37e30e76-b754-11ed-9693-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677580785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NJr1v+Fg3X7rjMTnlf2Bt1V+Ic/mzwck/Xt/BL3vIn0=; b=cijT/e+3xZ3lTiNxfmvQZjdIC/q7uuhlMhJZ7clSjoMRUaItlVTUXbkwfHp/N9Cu3PfTNW PkKIfaARYi2eeUrIydFuZOzWb5edBAXAAkbeNzELnrvsd+OAyjmMZnWCq/dQLrhuWqEqU2 12fjMmuZ8uDfD6+ZdezVPSQo2//Gq84= X-MC-Unique: lf9JwHrrNxiA7gTzVlLOEg-1 From: Markus Armbruster To: "Michael S. Tsirkin" Cc: Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Thomas Huth , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> Date: Tue, 28 Feb 2023 11:39:39 +0100 In-Reply-To: <20230228050908-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 28 Feb 2023 05:11:20 -0500") Message-ID: <87cz5uhy50.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 "Michael S. Tsirkin" writes: > On Tue, Feb 28, 2023 at 09:40:49AM +0000, Daniel P. Berrang=C3=A9 wrote: >> On Tue, Feb 28, 2023 at 10:14:52AM +0100, Thomas Huth wrote: >> > On 28/02/2023 10.03, Michael S. Tsirkin wrote: >> > > On Tue, Feb 28, 2023 at 08:59:52AM +0000, Daniel P. Berrang=C3=A9 wr= ote: >> > > > On Tue, Feb 28, 2023 at 03:19:20AM -0500, Michael S. Tsirkin wrote: >> > > > > On Tue, Feb 28, 2023 at 08:49:09AM +0100, Thomas Huth wrote: >> > > > > > On 27/02/2023 21.12, Michael S. Tsirkin wrote: >> > > > > > > On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrang= =C3=A9 wrote: >> > > > > > > > I feel like we should have separate deprecation entries fo= r the >> > > > > > > > i686 host support, and for qemu-system-i386 emulator binar= y, as >> > > > > > > > although they're related they are independant features with >> > > > > > > > differing impact. eg removing qemu-system-i386 affects all >> > > > > > > > host architectures, not merely 32-bit x86 host, so I think= we >> > > > > > > > can explain the impact more clearly if we separate them. >> > > > > > >=20 >> > > > > > > Removing qemu-system-i386 seems ok to me - I think qemu-syst= em-x86_64 is >> > > > > > > a superset. >> > > > > > >=20 >> > > > > > > Removing support for building on 32 bit systems seems like a= pity - it's >> > > > > > > one of a small number of ways to run 64 bit binaries on 32 b= it systems, >> > > > > > > and the maintainance overhead is quite small. >> > > > > >=20 >> > > > > > Note: We're talking about 32-bit *x86* hosts here. Do you real= ly think that >> > > > > > someone is still using QEMU usermode emulation >> > > > > > to run 64-bit binaries on a 32-bit x86 host?? ... If so, I'd b= e very surprised! >> > > > >=20 >> > > > > I don't know - why x86 specifically? One can build a 32 bit bina= ry on any host. >> > > > > I think 32 bit x86 environments are just more common in the clou= d. >> > > >=20 >> > > > Can you point to anything that backs up that assertion. Clouds I've >> > > > seen always give you a 64-bit environment, and many OS no longer >> > > > even ship 32-bit installable media. >> > >=20 >> > > Sorry about being unclear. I meant that it seems easier to run CI in= the >> > > cloud in a 32 bit x64 environment than get a 32 bit ARM environment. >> >=20 >> > It's still doable ... but for how much longer? We're currently dependi= ng on >> > Fedora, but they also slowly drop more and more support for this >> > environment, see e.g.: >>=20 >> FWIW, we should cull our fedora-i386-cross.docker dockerfile and >> replace it with a debian i686 dockerfile generated by lcitool. >> There's no compelling reason why i686 should be different from >> all our other cross builds which are based on Debian. The Debian >> lcitool generated container would have access to a wider range >> of deps than our hand written Fedora one. >>=20 >> > https://www.theregister.com/2022/03/10/fedora_inches_closer_to_droppi= ng/ >>=20 >> With regards, >> Daniel > > ... and is closer to where 32 bit is likely to be deployed which is > systems like e.g. raspberry pi os which until recently was only > 32 bit. 32 bit ARM. How is that an argument for continued maintenance of 32 bit x86? If the argument goes like "32 bit x86 is easier to test in CI", then I don't buy it. Testing 64 bit ARM + 32 bit x86 does not magically replace testing 32 bit ARM. The question to answer: Is 32 bit x86 worth its upkeep? Two sub-questions: 1. Is it worth the human attention? 2. Is it worth (scarce!) CI minutes? I want to see an argument for benefits justifying the costs. A benefit like "somebody out there might still want to use it" I'd value at zero. From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:42:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:42:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503236.775448 (Exim 4.92) (envelope-from ) id 1pWxRD-0000N4-Q3; Tue, 28 Feb 2023 10:42:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503236.775448; Tue, 28 Feb 2023 10:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxRD-0000Mx-N4; Tue, 28 Feb 2023 10:42:27 +0000 Received: by outflank-mailman (input) for mailman id 503236; Tue, 28 Feb 2023 10:42:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxRC-0000Mr-Sw for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:42:27 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0c::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95b21a71-b754-11ed-a550-8520e6686977; Tue, 28 Feb 2023 11:42:24 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8158.eurprd04.prod.outlook.com (2603:10a6:102:1c3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 10:42:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 10:42:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95b21a71-b754-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVrdxL1cWt21PDu7GsabqAyhDDQCe7Lf6fG1t9kqhYlYrNQogsYqdju60GVhHmpAP3QyLYT6/cTTtp69KQ0UGrhwcxZhjCymH7RycoAzpDAPfeK4Z+g5DLKpKdO/J/bCY7jycILzWR1C3EzyL/YyF6pNbH6bgFLuSaxDdyC27P5L7pIvYsa8jM0UYfaoEigxsbGARX22A0QgAGXKJENvEIWzLPbOQWyR01xwldQf8LnwhPGoeAxCECiOiCQxSiiSX3HOTVH7+4Q31o1FRY/vFcCu3HdsEDIS5Q7Y5fzrDPNV3AE8e2U04BuQr6q6k3Y8Ys3DwMefUp3ZUomrEO5WEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pfztsu1l5t88RbWV5BtA/ZRRTZ4ub6kpIsf2gMuFMT0=; b=aWWngwaZk9D52xFxgQq+UFl/0Jx2vVAD8fnBss2yGCuIAyGtyUHzYPeiwMFi1B6Ipa0rzmQq2CtsaD1eYJAYYDhkvB+tza4eOXt0n8RRAanAPfdUPIEMP0J1YcbJtLRAEzlwc5KZH8e6E9WaOvRZN2AQfUW2qsfGeJObJSd2YM54qi5q9w/PKERrNogEIMP00hhaC062DLWIz18hnSL8J4ASMQXzyi1SZS58e0e/EmxY9baAjdo0/DR8dLf9VXoLgjKSTLKssJu0xyZZp6yAsuecUj5en7Eiez97D+qSJM6HPO2xgyR89ROMTijvzST/s/tMliEn0p0CJnKdooxA6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pfztsu1l5t88RbWV5BtA/ZRRTZ4ub6kpIsf2gMuFMT0=; b=zjBozS+TPPRyPYpPUdI4H7Mh0a581KLq0ZZZ0V3/D0o9mr1jULvObfyAaHaLZh5mn7hS6tKdjfk4us1fhw6m30BFCiShDNVvkN7RsI7df5x+NcrRKd/mRjqsQgphS/zY1Zc7wK5sk8DIK6oLCZ8OnKhiFtFIzoakIo0wXWNGdoLdgRdAn29rFdBh/xFvygzidUtasJ/kAIxX1+RD0cTg+6Motol29AFWPqVb3lySuj4RSMBFrNNcr4NsAAwqAbv02S2o/oj3OzNCbl5VN5bPLpRlge2WUO/jPjispEvlCW1HdnBL7Sco7ABZQLk0iVwFdqLmyKSEssKpy6aBbRqIwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9b66ee51-17c3-0f8e-0fc2-4ff083952e9d@suse.com> Date: Tue, 28 Feb 2023 11:42:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> <507c5449a56ce5cf5758bef967d511bf545d8405.camel@gmail.com> From: Jan Beulich In-Reply-To: <507c5449a56ce5cf5758bef967d511bf545d8405.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8158:EE_ X-MS-Office365-Filtering-Correlation-Id: ef367217-2020-4203-917a-08db197878c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S181fOti6hqV6cbN9ZU21dvbYuRTQncjakSb2xV6GfJkX8ys0dD6EMKUhzuTdWuqEOJ6vPebwD1308RRFqIo2DhsNAu7uZ6qGDAjtOsPn6iVX2Mvd4sInOZbmImxIg1ZI1fgQ93+UrauY0fLa1T63xkncIssGKgZa4mnjp4Eses2+iS9kFn9ZParJIW4t/3md3ZVhmFdIZnzk9U51bHcQ2uGvvp/EvuzUfdrWBKGMNWlcvQYft5cm31piVauholTlFvJ3c5QTWwkNu5spB+qrKfJjlUP9soqKYyoy8Ky97Zio+cW4f2lnGthEWEt12XmoixuZqp6kf5hxJ/MRuZvDNLPYJ9xl9uJ0hTK1528mxkUeJcgkIHol6jHd3ZtMCC+mRMNb+A3xwlTliaRKwKl7pBFYTY4Hr24CkSRtkOz8m+HP7HFIW+HRNMEovq1rwue2x0Vdw81LX5KYsx5vP22oLD5WN1Ls0tQFBoazwh5+R4YDiJhXwBd3aKuqC/+pwFN+qGotS7RMjQZdM6YojFIQmdond4WRTxZHbaqgYcHAja1H6V1pfYQCigNjXk3F06HlJWliuT2kO9I3Uz4JRWZhV2yfDT0R4dNMzM7ws8PwoWnUwxMIydWjAH1BwE9uncIuBSESu5GB7WejFmRs3lv8mBWH/lWEYC9yPBrkUg1jER2Ib8QZYeD/P7lg3qLb89ggPhlLFSQvjM7DBgQ+ohE/nrGEKhALAlHEXXY3/RE94uTO/N8V/YCwJ6Zy/DNe7/Z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(366004)(346002)(39860400002)(396003)(376002)(451199018)(54906003)(8936002)(31696002)(86362001)(5660300002)(6486002)(316002)(41300700001)(38100700002)(4326008)(66946007)(66476007)(66556008)(8676002)(6916009)(36756003)(6512007)(2906002)(2616005)(66899018)(31686004)(53546011)(6506007)(186003)(26005)(478600001)(41533002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFJRQXBRWG5JK0tDMm9RWHdHd2NIbHJGYWJQTnpONW4rc0N0RjFSM253K0xU?= =?utf-8?B?NE5sbkg0Y2FaWDB0ZUtGSjh6YllYVldNRm9rbE5BcXJvcmVybDFqRGhKNGc1?= =?utf-8?B?a1kvRVJVZHY4b3VMWi90UDgzS3NOdmtjNG5SZE4zenlXWHZZdUpZNXNJdnRE?= =?utf-8?B?bnJHcVU1LzdUMmtSOFo1WllBU0Fzdyt0SUcrNW1pbExGbS9DbG9MSE9xU1Jp?= =?utf-8?B?RXlMNjNBWEY4Ym5EK0Y0NEdZWWZqZ3lRckhkRWRaZmxyZFhQSUVRSHEramds?= =?utf-8?B?OWxjblp2Q1pZWHgyeVFacGdCOUgzd0dsUGI1QXpsblp5UjltOFhXL244YS95?= =?utf-8?B?OXdXZkFRb0Jwd3F0MkJXZThpTzlDZG1YcGhjNUNmWVZob0h1dlhjWVUxUG5i?= =?utf-8?B?MEQ1dHdUQ3o1a2tmT0kwL052aTJXRDNhczJZMUZGVVh3U1oxa1JobndZS0xY?= =?utf-8?B?cUZnWlpoMmNxODBsbHNhdEdBa0hDRis3dW92Z1EyQ1dKRytPWGx1ckxIcTNF?= =?utf-8?B?RXQ2c2tvRndIS0hKRkRRU2IyQlR5YllHdWxTWjdWR3AxRm1iamZTUEhvcVFJ?= =?utf-8?B?MlZsekczTlFqSEhCbzg2RkhWbjRXNDJPZW1GWU1RTWxtQnROODltVU84bUhE?= =?utf-8?B?aDZMU2tBZnptdWoyeCthd0ZWS1NENkRMd2tKK0tBZEJrUTM1Ynlyd2phRmF4?= =?utf-8?B?emkzOXJwSms4c2ZLQ0o2TVhiWEIzV1Z0TDI2aHlybHVYVzJMTUNQUW9UUXYr?= =?utf-8?B?WHROVEtwMElBMkxkR002TFlvdC9wenBFUEd2MlZUMVQrUWN4dmZPa1NrSEMx?= =?utf-8?B?bkgrcUtDa3h6anp6cFozeFVXRmxZd20zVitHQUZLdWFBV2tKME15TzlVbUNW?= =?utf-8?B?ZkJZMTBqSCtzbTFFK3hER21rYkNmTkh0QlJLVm5MRXA1ZEh6L1ZuNTVHbjFJ?= =?utf-8?B?S1hmaWxYSzB3UU56bEg4UE9UM2l0N0NFaGRKdkttWWNET3M1QXNzR3J1ZFhF?= =?utf-8?B?WldQSFRCbklrRDVSL2pBTzNUUjUxZDJPMnZwSGo2Z2FHdFl2eUxVWDhPa1ZR?= =?utf-8?B?bGd0V0ZMQi9iRFQ2NlhuZFJialYyUTFsOXRJMW1ISm1nRU45RU1vNDc1anlU?= =?utf-8?B?UnE0TnZEV0U0OHg4bUJQRmxJeTJDajBPYnVRUG9UOXZQWitLRStrMUxQTUd4?= =?utf-8?B?cUFpQ1BYd1B6UXc4cW1lNGpsbkQzNEk3SXFsdXJwOFRCUUNMYnQ2YVdnNFFo?= =?utf-8?B?dzhOWHlja2tCMmg1dDRocDN6Zi9tV0FnZmNudmZCditneUp3QmIwRUw1bmF6?= =?utf-8?B?TXBaSTdmaEswSUd6Q2grQ0RQY1BUTVpBSmN1TGlYZ1FVajg2M0ZlcUpTY0ti?= =?utf-8?B?WUtMdXFGN1FpeFFiY2hrdnUvYXkvbHcyUEZhTzRMaXFZSWsxWklnVU5mNG9J?= =?utf-8?B?aVd2UVUyM2VwcmlVR0E2Q0ZDM0xabHlSeE9rSUdBY3V6aXhSdkV4RG5HZzZS?= =?utf-8?B?UW1Vd25vL3pRN0R5T1NlcWQrWW5VMFQydHlTcS84ZTYwd3ArYkFvV2IxUUhF?= =?utf-8?B?U0RFeEM3ODhrU3E0MGJMNGl1T0M3ZkpzRDZkc1dFY1VnQ0NON2x6SVdWMnVB?= =?utf-8?B?cW85SXhlNmk4NFFkUTd1NUM1ZDRmcG5ITEZJTnpxSUx3RGdnTllNc0JFc0ls?= =?utf-8?B?MmljemNJNXhlbVNuMlpwbjBRcnFrT0hIZkhETXM5WGFnQXdwVHFmQU5xeUUw?= =?utf-8?B?LzVnREI4aVRFWnZkUUVZb2VJbS9JNUxxWFc3Qlozbi84SGwxVlozWUlFNG1K?= =?utf-8?B?bFpuMFNZUEVkOVlXY0pkMjVYNmt3SUU0Y1ZwN2RsK3EzZ2VHNS9ndmlERGsr?= =?utf-8?B?RnUzVXVlUUMvUUVDTjBqSWpqVERUYURPR09FcGRKMW1Vbk9HRXlZOFJwQW9a?= =?utf-8?B?VytiKy9Ta0lHWE1wNUk4dTZyblViZHl5bm5Ec0RueFNZbkUvMGIzamhOV0E4?= =?utf-8?B?aU45eEFDc3JjODJLYjNPUnNrd0ZYa2xKWElUZUdpVjRoeFdZZW5HYWkvMy8w?= =?utf-8?B?ZHhvY2M0YTZZdDhzcVgrNjl1bnhlcSt6a3VyWlhMdW8weGlyTFhYVmlvV1FF?= =?utf-8?Q?Z4Bsp0bq7XASiR0Fcs1uX+0XD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef367217-2020-4203-917a-08db197878c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 10:42:21.8097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ym/HeyKGHyAlh9eSWzY8qQePXSUDVa8c9uQ1uYfRlQHFmvWFD00WEpSq2FNk40FDaDcGdVWERhnvEhFyDULmuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8158 On 28.02.2023 11:30, Oleksii wrote: > On Mon, 2023-02-27 at 15:23 +0100, Jan Beulich wrote: >> On 24.02.2023 12:31, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/common/bug.c >>> @@ -0,0 +1,109 @@ >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +/* Set default value for TRAP_invalid_op as it is defined only for >>> X86 now */ >>> +#ifndef TRAP_invalid_op >>> +#define TRAP_invalid_op 0 >>> +#endif >>> + >>> +int do_bug_frame(const struct cpu_user_regs *regs, unsigned long >>> pc) >>> +{ >>> +    const struct bug_frame *bug = NULL; >>> +    const struct virtual_region *region; >>> +    const char *prefix = "", *filename, *predicate; >>> +    unsigned long fixup; >>> +    unsigned int id = BUGFRAME_NR, lineno; >>> + >>> +    region = find_text_region(pc); >>> +    if ( region ) >>> +    { >>> +        for ( id = 0; id < BUGFRAME_NR; id++ ) >>> +        { >>> +            const struct bug_frame *b; >>> +            unsigned int i; >>> + >>> +            for ( i = 0, b = region->frame[id].bugs; >>> +                  i < region->frame[id].n_bugs; b++, i++ ) >>> +            { >>> +                if ( bug_loc(b) == pc ) >>> +                { >>> +                    bug = b; >>> +                    goto found; >>> +                } >>> +            } >>> +        } >>> +    } >>> + >>> + found: >>> +    if ( !bug ) >>> +        return -EINVAL; >>> + >>> +    if ( id == BUGFRAME_run_fn ) >>> +    { >>> +#ifdef BUG_FN_REG >>> +        void (*fn)(const struct cpu_user_regs *) = (void *)regs- >>>> BUG_FN_REG; >>> +#else >>> +        void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); >>> +#endif >>> + >>> +        fn(regs); >>> + >>> +        return id; >>> +    } >>> + >>> +    /* WARN, BUG or ASSERT: decode the filename pointer and line >>> number. */ >>> +    filename = bug_ptr(bug); >>> +    if ( !is_kernel(filename) && !is_patch(filename) ) >>> +        return -EINVAL; >>> +    fixup = strlen(filename); >>> +    if ( fixup > 50 ) >>> +    { >>> +        filename += fixup - 47; >>> +        prefix = "..."; >>> +    } >>> +    lineno = bug_line(bug); >>> + >>> +    switch ( id ) >>> +    { >>> +    case BUGFRAME_warn: >>> +        printk("Xen WARN at %s%s:%d\n", prefix, filename, lineno); >>> +        show_execution_state(regs); >>> + >>> +        return id; >>> + >>> +    case BUGFRAME_bug: >>> +        printk("Xen BUG at %s%s:%d\n", prefix, filename, lineno); >>> + >>> +        if ( debugger_trap_fatal(TRAP_invalid_op, regs) ) >> >> TRAP_invalid_op is, as said, about to disappear on x86 as well. I >> think >> this construct wants abstracting by another asm/bug.h provided macro >> (taking just regs). >> > Thanks for the link. > > Nice idea to abstract 'debugger_trap_fatal(TRAP_invalid_op, regs)'. > Actually we have to options here: > 1. As you proposed abstract in : > x86: #define DEBUG_TRAP_FATAL(regs) debugger_trap_fatal(X86_EXC_GP, > regs) > ARM: #define DEBUG_TRAP_FATAL(regs) 0 > RISC-V: #define DEBUG_TRAP_FATAL(regs) 0 > For ARM and RISC-V it doesn't use so we can skip the check if ( > DEBUG_TRAP_FATAL ). > > 2. Abstract only TRAP_invalid_op in > x86: #define TRAP_invalud_op X86_EXC_GP > RISC-V: #define TRAP_invalid_op 0 > ARN: #define TRAP_invalid_op 0 > > I am not sure if we have to provide real invalid opcodes for RISC-V > and ARM as it looks like debug_trap_fatal() isn't used in ARM&RISC-V > now. > > Could you please suggest which one option is better? I don't view 2 as a viable option. How an arch deals with invalid opcodes is entirely arch-specific (including the naming). As to 1 - since we want this solely for bug.c, I'd prefer if the wrapper macro's name would start with BUG_, e.g. BUG_DEBUGGER_TRAP_FATAL() or BUG_TRAP_FATAL() or just BUG_FATAL(). Further adding ARCH_ may also be wanted by other maintainers (I'm neither pro nor con there). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 10:52:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 10:52:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503242.775458 (Exim 4.92) (envelope-from ) id 1pWxaM-0002Hb-RU; Tue, 28 Feb 2023 10:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503242.775458; Tue, 28 Feb 2023 10:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxaM-0002HU-OJ; Tue, 28 Feb 2023 10:51:54 +0000 Received: by outflank-mailman (input) for mailman id 503242; Tue, 28 Feb 2023 10:51:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxaL-0002HO-AC for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 10:51:53 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7590541-b755-11ed-a550-8520e6686977; Tue, 28 Feb 2023 11:51:50 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-259-VmCFpQZtN6y7_lMqE39ELw-1; Tue, 28 Feb 2023 05:51:48 -0500 Received: by mail-wm1-f69.google.com with SMTP id x18-20020a1c7c12000000b003e1e7d3cf9fso6735859wmc.3 for ; Tue, 28 Feb 2023 02:51:48 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id 13-20020a05600c020d00b003dc1d668866sm15589805wmi.10.2023.02.28.02.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 02:51:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7590541-b755-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677581509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TIARw/Eg/FHCbkTqHcE3f9NxhqHaLUkccjhqbNiCijE=; b=c3F+tksk3HY/zISIbUWNOP3IvpOgZgua9PY8CkgAFTWCpqTNwb6pzWxdbs+eTWhk2Dp9J1 LDd/4lqwBLM+keI4k5vhpAkousMXo8jsAZo2LcrYsmZjmU8M8nl1dcWwQ2xxoKrRAyRvgu AL8p0p4yl7Xdkd/MKcLO2pJN6zpQhm4= X-MC-Unique: VmCFpQZtN6y7_lMqE39ELw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677581507; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TIARw/Eg/FHCbkTqHcE3f9NxhqHaLUkccjhqbNiCijE=; b=Y+R44rWTTW4JjGNHEr0KCkAlR0pPfca2M2dRku5Xzd5Ilp9iPRwSaZpRXdH69J+r/V X3OvVHXP742gk9Hmfsr/h4CnVgfXeP5RAxgpmE6lcEEzcflDDRUGdsLMFbkyu2pB0a46 qlmFKU+RVIr0hVV7HzZpm8xB6G/AhN9tX720xoBysDViGTQKXgR5VP5+737QZvFGbtTZ rWkv4hxgXG+nKKNzkUDKRLSaCu2eOCM1W/MglYyAuYwsf9DzwcVZ0kg8Z0/wR1abrzYq /l0OMzGWky9p2QcjWhnDsQSGqHg9u6Dq1jyUVHBRMCWrnTZYIIglLKZ85nNYL5jpYJEQ 2VJg== X-Gm-Message-State: AO0yUKVlU3CHCkdxEX+BN/M3SR1TZKYzU6QlHbanW2f6AdasRh8OmXp+ xwp56vIZ2QCs/5mjlDw0c/pF5Za9KUPBwXgl1P5jBXB3ViEH+5hDyahfp4xlIV0oyymVs7TABgn s8XlUeAwt0WFRYW+eLrNVvcgNjy4= X-Received: by 2002:a05:600c:331b:b0:3df:fbd5:690 with SMTP id q27-20020a05600c331b00b003dffbd50690mr1723654wmp.17.1677581507231; Tue, 28 Feb 2023 02:51:47 -0800 (PST) X-Google-Smtp-Source: AK7set8cQlDBvAlJdAHtDjB/GY2t5VT2TFTWjVV6lyCTysKtoQJ8w5SKvyN5sJMgC80hVK24t3HvYw== X-Received: by 2002:a05:600c:331b:b0:3df:fbd5:690 with SMTP id q27-20020a05600c331b00b003dffbd50690mr1723636wmp.17.1677581506970; Tue, 28 Feb 2023 02:51:46 -0800 (PST) Date: Tue, 28 Feb 2023 05:51:41 -0500 From: "Michael S. Tsirkin" To: Markus Armbruster Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228055016-mutt-send-email-mst@kernel.org> References: <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87cz5uhy50.fsf@pond.sub.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > The question to answer: Is 32 bit x86 worth its upkeep? Two > sub-questions: 1. Is it worth the human attention? 2. Is it worth > (scarce!) CI minutes? 3. Is it worth arguing about? -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:11:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503248.775467 (Exim 4.92) (envelope-from ) id 1pWxsq-0005Po-E2; Tue, 28 Feb 2023 11:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503248.775467; Tue, 28 Feb 2023 11:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxsq-0005Ph-An; Tue, 28 Feb 2023 11:11:00 +0000 Received: by outflank-mailman (input) for mailman id 503248; Tue, 28 Feb 2023 11:10:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxso-0005Pb-Tx for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:10:59 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20607.outbound.protection.outlook.com [2a01:111:f400:7e88::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 903c288c-b758-11ed-a550-8520e6686977; Tue, 28 Feb 2023 12:10:53 +0100 (CET) Received: from BN0PR07CA0023.namprd07.prod.outlook.com (2603:10b6:408:141::6) by DM4PR12MB8451.namprd12.prod.outlook.com (2603:10b6:8:182::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Tue, 28 Feb 2023 11:10:50 +0000 Received: from BN8NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::c) by BN0PR07CA0023.outlook.office365.com (2603:10b6:408:141::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 11:10:50 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT090.mail.protection.outlook.com (10.13.177.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 11:10:50 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 28 Feb 2023 05:10:49 -0600 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 28 Feb 2023 05:10:48 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 903c288c-b758-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IXLqBoG0z/uAV9TPAxFxQrNC+WenpnIBq0ay40RZmelw6Lyji2E/jBh3qDRW2Gdwiblu9tHAUOBS4KwuIi3ypi46KrifrzuUuzTkvW0ShwZmvMvWGhbzKI+O0swBVkYTPSPgTP2KfnWOdUXSQ0OcdWmzx/1/rU7tgirRqT6fOXV8f4Dyk4QE1jL+aiEZ+7IhB38OX9Rkin2qq5ya/4seyLUvj/ZPKeHSLAjSMOBQqeqJz/W/OTOOgfzf4hTIuC+eFBtabfFKbj/y57h5zwx4c/qKMTlmrG8rPd4uL8WlLlXT/Sp82Kara9TbhdRPu6UUjACRT8KQOc0b/gVGfprIRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vlUMh6B6jAvgKlcVcmtBYCCvYf1PJVMVHdIdhhSF/Z8=; b=QOQKVPoxnlAs6Tw/Z000T6ARqrle/9q8Erxg6lkpUycGyai/CVrq1L/VZhAHYWwue6LtZC94YwjOdUe32OB6erEoTvWuXvrRtBQy0O5AediJKBfoWY1TGTHxIkV/ZV4ISSp9PXB6OkVvkyTlA46apZWKUt2cN/VOtGi4K+HUi5afl1MOO3opGkk8TSenMOX8c0xLb4ylrzmiuTBHSqD1qSn0uqlPQNz4lMjts1+LK7t1QXoA5oRHvnBEhPiJ6y2UV4HSm3R/wuDThp4R/OQmrCgavwJdCVUUbkW+dwJIHfGVBqvwf1Ud5Rt+pHU7zphDrjT1inNP4LQJ+ZoRODBcyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vlUMh6B6jAvgKlcVcmtBYCCvYf1PJVMVHdIdhhSF/Z8=; b=GWfqzAhdRD1HtPYctkPkOUhheZNQlJXCHOhbFrZqYtTsJwG8lRjoF9NBay4QQ8pzAd0UxlAozajrsjws59iawmtHzJ+wfberjOZqhidoI81rwSMe3ND21PszOs7gX9iERfBhxM9JiraqrD6Rj+EAE8MuksnulS0Yl51WUmfXZzY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <15c427ed-c452-a0d7-078e-58f040dcd9b4@amd.com> Date: Tue, 28 Feb 2023 12:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] xen/arm: check max_init_domid validity Content-Language: en-US To: Bertrand Marquis , CC: Stefano Stabellini , Julien Grall , Volodymyr Babchuk References: <0cf2013e5e6018cae300c39fb65ed526eac5c35c.1677511937.git.bertrand.marquis@arm.com> From: Michal Orzel In-Reply-To: <0cf2013e5e6018cae300c39fb65ed526eac5c35c.1677511937.git.bertrand.marquis@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT090:EE_|DM4PR12MB8451:EE_ X-MS-Office365-Filtering-Correlation-Id: e5d9af49-0819-4426-1cad-08db197c7324 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S116uJ4ooo8PaPzcZOpDq3iRMmrkEWjqSvYVKyvBAzV5oN+AZvUvS2MLBRtc20h7m6K0mxPWLMg5aq8LdU73NU77uZrPScHU1mdF1kvnvP9ZKYPBX/vjQCEeRc7adxG0Zb3ymS6+FYuRekmhsAPW/pai4bPAspZdNeSKycZc2J7BR3sbvblg5NprDt4d6njxICr4XQLFvIyibOgiPsK+PbmY2aoIUY74+O2TlMgZu+USpebrOYQ/6UF0/BGFNFx69bNEw9/UWiqHNMWtH+395ElvR+r3WLGHBMvmzw8aO1vfjN1CIJ9qoontM5SvuLSowgfTjYEUw/tjjBHO41cifx88uJ/dLbZaRkGzwoF/DZuETipUl3mAo5QkVPPWIYQ6LW8DfVX9P4pMX69MaJsrn2QwCzCU0ylXDHa8y8ZS8vh2TSZ8qUw4t7fFY7+EdeTQYYN8ZN2HNq/0caiJqSkq445hDLfsce2n7ErnYiYShE+ueALLymq9XQWDBP/pjoYOnYX3zNMYp7Ck8JWjKhuk2/8zL6/sUSXtNRnQ868rH+EcI+G001A6wUrZfMUolVVyLabHOx2yVPcvoKpUbYwHq+3kfFeLEiqVqb/1I8DaPY/KObriBBB/62frqqIYU2Yc/1s44DJpfblpa4+9Ws1TDAOpYcI9ykcrxY8Ko1xvi1dvC9vVheCqCO0JhjiFf44nPsyQFayv+lLJbw41OlhOdILqmyhZn6/5VHabxkN7PzNELlQ1uI1W25YO7qQlGDYOfLvWL0INzNTT7Tmjck+1Jg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199018)(46966006)(40470700004)(36840700001)(426003)(2906002)(36860700001)(31686004)(44832011)(82310400005)(81166007)(5660300002)(8936002)(47076005)(336012)(2616005)(16576012)(356005)(86362001)(40480700001)(316002)(4326008)(53546011)(26005)(82740400003)(186003)(8676002)(41300700001)(54906003)(110136005)(478600001)(70586007)(31696002)(36756003)(70206006)(40460700003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 11:10:50.0974 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5d9af49-0819-4426-1cad-08db197c7324 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8451 Hi Bertrand, On 28/02/2023 09:08, Bertrand Marquis wrote: > > > Before trying to create a dom0less guest, check that max_init_domid > increment will generate a valid domain ID, lower than > DOMID_FIRST_RESERVED. > > Signed-off-by: Bertrand Marquis > --- > xen/arch/arm/domain_build.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index edca23b986d2..9707eb7b1bb1 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3879,6 +3879,9 @@ void __init create_domUs(void) > if ( !dt_device_is_compatible(node, "xen,domain") ) > continue; > > + if ( (max_init_domid + 1) >= DOMID_FIRST_RESERVED ) > + panic("No more domain IDs available\n"); Here are some of my thoughts: 1. The check if domid is >= DOMID_FIRST_RESERVED is used in quite a lot of places in the Xen code. We might want to introduce a global function for that purpose instead of repeating this check all over the codebase. 2. This check is something that could be moved to be generic. At the moment we do have an ASSERT with is_system_domain in domain_create. I know domain_create can be called for domids in special range so this would need to be thought through. 3. The placement of this check at the top of the function before starting to parse dt properties might be problematic in the future if we decide to allow specifying static domids for dom0less domUs. In a static configuration, most of the time, we do not have xenstore (either because of lack of xenstore support or because of lack of dom0). AFAIKT, in Xen a domain can get to know its domid only through xenstore (DOMID_SELF is not working in all the cases). Also, in a static configuration, it makes the life of an integrator easy to know all the domids upfront to easily set up some communication, grant tables, etc. Let me know your thoughts. ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:12:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503252.775478 (Exim 4.92) (envelope-from ) id 1pWxuQ-0005x7-OM; Tue, 28 Feb 2023 11:12:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503252.775478; Tue, 28 Feb 2023 11:12:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxuQ-0005x0-LZ; Tue, 28 Feb 2023 11:12:38 +0000 Received: by outflank-mailman (input) for mailman id 503252; Tue, 28 Feb 2023 11:12:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWxuO-0005wl-Pn for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:12:37 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cbe3f3f3-b758-11ed-a550-8520e6686977; Tue, 28 Feb 2023 12:12:34 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-563-kK4wtX-AOEiLkAIiud-KSQ-1; Tue, 28 Feb 2023 06:12:30 -0500 Received: by mail-wm1-f72.google.com with SMTP id p22-20020a7bcc96000000b003e2036a1516so6752173wma.7 for ; Tue, 28 Feb 2023 03:12:30 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-75.web.vodafone.de. [109.43.177.75]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003e876122dc1sm16604362wmq.47.2023.02.28.03.12.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 03:12:29 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbe3f3f3-b758-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677582752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wpQuPL8c90Bf1pFHe7Ri8yXfJ5L7MD+vOWGStm2xqk0=; b=F6t7KpQnECisySRDgBCX/Z1BCyqu3ed6TZAJapLDgZiRYRj8SGK6auTes4H/xusNaZG1lN 9/d37ZLQWOrNWvXfHJ/G5JBGQnNuZm7YLuRZKbqpug/+p1nujw+N+ENU7fCE6UkQUtF5FF gS7ABRpeOHW65VfWO7JBsamjgm+3hy4= X-MC-Unique: kK4wtX-AOEiLkAIiud-KSQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpQuPL8c90Bf1pFHe7Ri8yXfJ5L7MD+vOWGStm2xqk0=; b=ywDKBzGZVk+rVMFnUeduqxOZhOpC/2nLYQmfsE55NOJFqxjY3CLHPL8tJCf5KnBnYD YKhW8hERr8CxMXFTvfFAa3PuwogEZVh5zXwN1R0+qFnO7J5qavwTTAn2i9koD3+tL9XI uObYPHaRFKg5rR5ghJNOelXWlLNXaEgsbBR4zo65sQHFlpRiCHWVCkMSOl0KR2SlpN26 O4V/X0Q/ot/lRiYxCKle+l9VjO0UQyYRSCkezn85R1V4XJkhav7AFBhrcxU4S8S+rHlH D0m0lF60pO3Ln/uOVOx7y1Sg3RoSGNjGUuBxB+Acrc3xDYQd8UG/wdYb0rZUsnrm92xl Y+Tg== X-Gm-Message-State: AO0yUKXcrMarVtBzR0sV0uPNoq4dCpiY+sv8fYzvUv8rbDRcD6XumnRE OXqasC7426Utwp/Z1ma4sdeSm8+gHbRpabu5nbw/66mr3p/BYBVE/LVfxoXCiz00Ki1wf6XiSpE za8PN1prq6DVREZ5Gw3Uqqdujt7I= X-Received: by 2002:a5d:6b0e:0:b0:2c7:a39:6e30 with SMTP id v14-20020a5d6b0e000000b002c70a396e30mr2049939wrw.38.1677582749883; Tue, 28 Feb 2023 03:12:29 -0800 (PST) X-Google-Smtp-Source: AK7set9oI/QD/RgvVvZBifmeDs/yaRHSeI1eCXGJYICkxBr0U4eDOUrIAvE9ljzr41EoyMJbhF+aig== X-Received: by 2002:a5d:6b0e:0:b0:2c7:a39:6e30 with SMTP id v14-20020a5d6b0e000000b002c70a396e30mr2049919wrw.38.1677582749642; Tue, 28 Feb 2023 03:12:29 -0800 (PST) Message-ID: <072a7502-6061-12b2-f778-736c6a8f5912@redhat.com> Date: Tue, 28 Feb 2023 12:12:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: "Michael S. Tsirkin" , Markus Armbruster Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> <20230228055016-mutt-send-email-mst@kernel.org> From: Thomas Huth Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 In-Reply-To: <20230228055016-mutt-send-email-mst@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/02/2023 11.51, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: >> The question to answer: Is 32 bit x86 worth its upkeep? Two >> sub-questions: 1. Is it worth the human attention? 2. Is it worth >> (scarce!) CI minutes? > > 3. Is it worth arguing about? You are aware of the problems we're currently struggeling with, aren't you? Darn, we're having *SEVERE* problems with the CI, the QEMU project ran out of CI minutes for the second time this year, and you ask whether it's worth arguing about??? You're not serious with this question, are you? Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:24:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:24:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503258.775488 (Exim 4.92) (envelope-from ) id 1pWy5e-0007pX-N9; Tue, 28 Feb 2023 11:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503258.775488; Tue, 28 Feb 2023 11:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWy5e-0007pQ-K8; Tue, 28 Feb 2023 11:24:14 +0000 Received: by outflank-mailman (input) for mailman id 503258; Tue, 28 Feb 2023 11:24:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWy5c-0007pK-Ox for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:24:12 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c1a07cd-b75a-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 12:24:11 +0100 (CET) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-642-NyJScZV7OvaOCD4NWlqdmQ-1; Tue, 28 Feb 2023 06:24:08 -0500 Received: by mail-wm1-f72.google.com with SMTP id s18-20020a7bc392000000b003deaf780ab6so4129592wmj.4 for ; Tue, 28 Feb 2023 03:24:08 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id i13-20020a1c540d000000b003db06224953sm12401771wmb.41.2023.02.28.03.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 03:24:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c1a07cd-b75a-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677583450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPt18yMFBhgEWcyFKRvmzxmC7YZWJirJ75g/XkJWVsg=; b=BkQXwGdzbZF7Ur7AANLRRr+QWwW1OHQR2nW1Vgk5a5JIUSdMPgeTNzG98NUtP3k+HbOFfI 67jhmhwcRZDZtZufzs3aObGCWX8JoAjIyr/DdZcws63PGVodZTwHknpK44Uem3kj8h6EXR t6/k75E1XuB19tI0E47Ql/07i49uWz0= X-MC-Unique: NyJScZV7OvaOCD4NWlqdmQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677583447; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cPt18yMFBhgEWcyFKRvmzxmC7YZWJirJ75g/XkJWVsg=; b=zA9A0bV4NhvDRfpNtMsFEdGpL6XElE2dA1DxE2dY4hYrh/iQfDuMcmhQ/Lp8PWzM5M ueHjuHg5tx56Njn+MkvI16P3GZNkYX8OoZQwUPaikjc1pUUvNR8eQMke27rVaraHd68c OYwWJH5sG6mWv8msc3Lg6hIBan1x/2+w0NHzb+fN6Kv8tlDHDdEmbvkC8OWwD8SdAa80 P4spcS9PDdF7s8WYQOAd7bjopxjBxAlcu3quqkD0MLYpnZtrpm3gV7KBcIz4FizCweAz X62RcMruFOLolEwZDRuW/dXpBp+kr5v1YJ75DUu+Z9QtLDRvgBqLRAnFiM9r/pQ2WwSM 96Gg== X-Gm-Message-State: AO0yUKUGnCuB456k1bUO4RpGun6ugbMO7NSCO884JVC5fJqYneI6dAK5 nsMt7VwUZIcrVshB69TBHUP1Q5qnKGKn/QHZcuRa5QCmXLL3lSNOPAA37gZ/achJNDGyALk70Sl rFn2imibybMvMzgNCPTE/+fFivPg= X-Received: by 2002:a05:600c:4507:b0:3eb:2b88:a69a with SMTP id t7-20020a05600c450700b003eb2b88a69amr1863547wmo.14.1677583447614; Tue, 28 Feb 2023 03:24:07 -0800 (PST) X-Google-Smtp-Source: AK7set9T5ZkS4VbZWkKkMQx04lsVjTlgvyWwH8VrH3B39Ebim23eqhBX9ts8ZVRgNNp1IV6iBjuM7Q== X-Received: by 2002:a05:600c:4507:b0:3eb:2b88:a69a with SMTP id t7-20020a05600c450700b003eb2b88a69amr1863526wmo.14.1677583447355; Tue, 28 Feb 2023 03:24:07 -0800 (PST) Date: Tue, 28 Feb 2023 06:24:02 -0500 From: "Michael S. Tsirkin" To: Thomas Huth Cc: Markus Armbruster , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228061853-mutt-send-email-mst@kernel.org> References: <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> <20230228055016-mutt-send-email-mst@kernel.org> <072a7502-6061-12b2-f778-736c6a8f5912@redhat.com> MIME-Version: 1.0 In-Reply-To: <072a7502-6061-12b2-f778-736c6a8f5912@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2023 at 12:12:22PM +0100, Thomas Huth wrote: > On 28/02/2023 11.51, Michael S. Tsirkin wrote: > > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > > > The question to answer: Is 32 bit x86 worth its upkeep? Two > > > sub-questions: 1. Is it worth the human attention? 2. Is it worth > > > (scarce!) CI minutes? > > > > 3. Is it worth arguing about? > > You are aware of the problems we're currently struggeling with, aren't you? > Darn, we're having *SEVERE* problems with the CI, the QEMU project ran out > of CI minutes for the second time this year, and you ask whether it's worth > arguing about??? You're not serious with this question, are you? > > Thomas Yah just couldn't resist. How many minutes do we use per month btw? -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:27:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:27:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503262.775498 (Exim 4.92) (envelope-from ) id 1pWy9C-0008Qv-6J; Tue, 28 Feb 2023 11:27:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503262.775498; Tue, 28 Feb 2023 11:27:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWy9C-0008Qo-3Q; Tue, 28 Feb 2023 11:27:54 +0000 Received: by outflank-mailman (input) for mailman id 503262; Tue, 28 Feb 2023 11:27:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWy9B-0008Qi-G4 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:27:53 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efd90aaa-b75a-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 12:27:52 +0100 (CET) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-2t4bR2lEM160Ab5hxW9V_Q-1; Tue, 28 Feb 2023 06:27:49 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 370BA18A64E0; Tue, 28 Feb 2023 11:27:49 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA5A9404BEC5; Tue, 28 Feb 2023 11:27:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efd90aaa-b75a-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677583671; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=4suh5lAbunuzTA9D1mz35nLVNbBw0W9grJdGWlluzWI=; b=R1tvVJAwh0i9LsxFmfOnrVA5nU8+FNqZInNqesyUI49pJAy1xtWc8+MyfQSj0Fjrwb61Ic VhjV6SNsLWyNJDfWUvWbdR8Hwfrby44ECdavywer34+0MWu1QLJyrQPbc3N1+jkgzlq0VP 9+5CNsi9rfweFNMFYX+ilmQdoeLd+/0= X-MC-Unique: 2t4bR2lEM160Ab5hxW9V_Q-1 Date: Tue, 28 Feb 2023 11:27:44 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Cc: Thomas Huth , Markus Armbruster , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> <20230228055016-mutt-send-email-mst@kernel.org> <072a7502-6061-12b2-f778-736c6a8f5912@redhat.com> <20230228061853-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230228061853-mutt-send-email-mst@kernel.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 On Tue, Feb 28, 2023 at 06:24:02AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 28, 2023 at 12:12:22PM +0100, Thomas Huth wrote: > > On 28/02/2023 11.51, Michael S. Tsirkin wrote: > > > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: > > > > The question to answer: Is 32 bit x86 worth its upkeep? Two > > > > sub-questions: 1. Is it worth the human attention? 2. Is it worth > > > > (scarce!) CI minutes? > > > > > > 3. Is it worth arguing about? > > > > You are aware of the problems we're currently struggeling with, aren't you? > > Darn, we're having *SEVERE* problems with the CI, the QEMU project ran out > > of CI minutes for the second time this year, and you ask whether it's worth > > arguing about??? You're not serious with this question, are you? > > > > Thomas > > Yah just couldn't resist. How many minutes do we use per month btw? 100,000 wall clock minutes lasted about 2+1/2 weeks this month, and similar in Jan too. Last year we were managing to get through the whole month on 100,000, but we got backlogged with merges due to the xmas / new year shutdown, and catching up is exhausting our allowance too quickly, as well as natural growth in amount of stuff we're testing per job. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:34:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:34:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503269.775507 (Exim 4.92) (envelope-from ) id 1pWyFb-0001rn-1a; Tue, 28 Feb 2023 11:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503269.775507; Tue, 28 Feb 2023 11:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyFa-0001rg-VA; Tue, 28 Feb 2023 11:34:30 +0000 Received: by outflank-mailman (input) for mailman id 503269; Tue, 28 Feb 2023 11:34:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyFa-0001rZ-4j for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:34:30 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db72f1b2-b75b-11ed-a550-8520e6686977; Tue, 28 Feb 2023 12:34:27 +0100 (CET) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-194-bbFmldvKOiqrsXzc0gvEGA-1; Tue, 28 Feb 2023 06:34:22 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 225A9299E74A; Tue, 28 Feb 2023 11:34:22 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCF83C15BAD; Tue, 28 Feb 2023 11:34:21 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B2C1621E6A1F; Tue, 28 Feb 2023 12:34:19 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db72f1b2-b75b-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677584066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AOcFKXrfEoubHIMAnm01Q+sO2KA1vvwDvQy3bHM/ev4=; b=IiwYsLG2Jqhs60Qu5mOj8gqddDPEkEv0fYlV6Vm6lwxI0yu/NoDmM/u+I6gDQc5cI7mHR7 GYFl1TzjUcQaEM5SewbRdDE5B7RpVNQa9l4LLlG0AK+/6OzDQqc75A0osRjujEgvSx2XO3 i4F/P+CihSSSatFNPgEUT1SxFXquNTs= X-MC-Unique: bbFmldvKOiqrsXzc0gvEGA-1 From: Markus Armbruster To: "Michael S. Tsirkin" Cc: Markus Armbruster , Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9?= , Thomas Huth , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 References: <20230227150858-mutt-send-email-mst@kernel.org> <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> <20230228055016-mutt-send-email-mst@kernel.org> Date: Tue, 28 Feb 2023 12:34:19 +0100 In-Reply-To: <20230228055016-mutt-send-email-mst@kernel.org> (Michael S. Tsirkin's message of "Tue, 28 Feb 2023 05:51:41 -0500") Message-ID: <87h6v6gh1g.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 "Michael S. Tsirkin" writes: > On Tue, Feb 28, 2023 at 11:39:39AM +0100, Markus Armbruster wrote: >> The question to answer: Is 32 bit x86 worth its upkeep? Two >> sub-questions: 1. Is it worth the human attention? 2. Is it worth >> (scarce!) CI minutes? > > 3. Is it worth arguing about? If it's not worth arguing, then we merge Thomas's patch. From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:46:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:46:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503297.775518 (Exim 4.92) (envelope-from ) id 1pWyQb-0003mn-3C; Tue, 28 Feb 2023 11:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503297.775518; Tue, 28 Feb 2023 11:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyQa-0003mg-WA; Tue, 28 Feb 2023 11:45:52 +0000 Received: by outflank-mailman (input) for mailman id 503297; Tue, 28 Feb 2023 11:45:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyQZ-0003ma-7x for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:45:51 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70ea5226-b75d-11ed-a550-8520e6686977; Tue, 28 Feb 2023 12:45:48 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-147-zIc_6bwwPlG02ejcKylEJA-1; Tue, 28 Feb 2023 06:45:43 -0500 Received: by mail-wm1-f69.google.com with SMTP id e17-20020a05600c219100b003e21fa60ec1so4160454wme.2 for ; Tue, 28 Feb 2023 03:45:43 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id q5-20020adff505000000b002c70a0e2cd0sm9735429wro.101.2023.02.28.03.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 03:45:41 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70ea5226-b75d-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677584747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bpIC6p+UT+rHFct1wlfMFpw0g6TQL7FZQoQ34DKLJ2E=; b=GHp8c86vuLXFSmMRvYCaSE9hXHiikhhQf2LubHTvZIrsqh1iBMFTx0jgv0XfV/TmyT9p3/ 3YdX8t2ZYPB/ElnsAYrIpxmoD3qxSjAtSaEoH04HCI3HS5EPzS/IFaFY4mEr+l4GxL3SnI /ToyPzmVVaLcyAB7/tjvvfGxFIitptE= X-MC-Unique: zIc_6bwwPlG02ejcKylEJA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677584742; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bpIC6p+UT+rHFct1wlfMFpw0g6TQL7FZQoQ34DKLJ2E=; b=YwsAffsQbr6KB6xrAxuVLGD5eeZUptiA/IZblJWeJDfVDcKB934pFT+9Lg6gnV/LIV 1VYtNu+yddj2b2MwyAMqzEv0WTzuYFBRIKT/vtAYlK0ODOD2EvYxci7luoTGdwH9QQFq f8goHFhyv4DOaMlhNkSV0Wu/nKBtWNtvB52rtCQZvsRAkXrWi3WdZC/gn0CeDxj/o24X aXeq4TKdBzw8+GMjmNAbvhy0Uqvr3GzumltY2if6x2XglvFjYbdeBTeykOmcwRhsrgR8 2ITHR4XeED0JHCk5dZcynmXlKR3SEkCCfQ6qdZbEPIdJMdXPFP+M2I+0foBCA07/RH1f 4R/A== X-Gm-Message-State: AO0yUKWHKHuTjvaVUgFActbgPYLEsbgDJEEuPSWCiiQCydzFc73GFOXO qncxmBq5Ivj5OXZMPrM11NaNO3YQ+wjTnhafQPnXDiJrJaWetxi8ME14S76+N/BkH38a4QRIuxt BFToLEKeReSrJHjQZK2GhP+U1+QI= X-Received: by 2002:a5d:558d:0:b0:2c7:694:aa18 with SMTP id i13-20020a5d558d000000b002c70694aa18mr1645851wrv.15.1677584742661; Tue, 28 Feb 2023 03:45:42 -0800 (PST) X-Google-Smtp-Source: AK7set+48ZPIQtY97ItwCko/7jlopFQGD3BDNuOTQkv4JN9Zc5UzfllSrQJsmeRBXNl/Z16nZ9kf+Q== X-Received: by 2002:a5d:558d:0:b0:2c7:694:aa18 with SMTP id i13-20020a5d558d000000b002c70694aa18mr1645837wrv.15.1677584742358; Tue, 28 Feb 2023 03:45:42 -0800 (PST) Date: Tue, 28 Feb 2023 06:45:37 -0500 From: "Michael S. Tsirkin" To: Markus Armbruster Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Thomas Huth , Peter Maydell , libvir-list@redhat.com, Richard Henderson , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Reinoud Zandijk , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , Maxim Levitsky , Alex =?iso-8859-1?Q?Benn=E9e?= Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Message-ID: <20230228064105-mutt-send-email-mst@kernel.org> References: <84d7d3e5-0da2-7506-44a7-047ebfcfc4da@redhat.com> <20230228031026-mutt-send-email-mst@kernel.org> <20230228040115-mutt-send-email-mst@kernel.org> <20230228050908-mutt-send-email-mst@kernel.org> <87cz5uhy50.fsf@pond.sub.org> <20230228055016-mutt-send-email-mst@kernel.org> <87h6v6gh1g.fsf@pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87h6v6gh1g.fsf@pond.sub.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2023 at 12:34:19PM +0100, Markus Armbruster wrote: > If it's not worth arguing, then we merge Thomas's patch. I don't mind but it's just a doc patch isn't it? If what we want to do is to stop doing make check on a 32 bit container and just to do make then let's patch the relevant yaml. I'd ack this, easy. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 11:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 11:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503301.775528 (Exim 4.92) (envelope-from ) id 1pWyRn-0004JM-EH; Tue, 28 Feb 2023 11:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503301.775528; Tue, 28 Feb 2023 11:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyRn-0004JF-9e; Tue, 28 Feb 2023 11:47:07 +0000 Received: by outflank-mailman (input) for mailman id 503301; Tue, 28 Feb 2023 11:47:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWyRl-0004J4-Ic for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 11:47:05 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e974491-b75d-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 12:47:04 +0100 (CET) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-185-QdWUnX42MhqW4g7QYVcPDg-1; Tue, 28 Feb 2023 06:46:59 -0500 Received: by mail-wm1-f69.google.com with SMTP id l20-20020a05600c1d1400b003e10d3e1c23so6797429wms.1 for ; Tue, 28 Feb 2023 03:46:59 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id z22-20020a1c4c16000000b003e206cc7237sm15096859wmf.24.2023.02.28.03.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 03:46:57 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e974491-b75d-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677584823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0nS0+RyN/H1npg0C1JIbWHZZ4SfeTHMMRyD4io5maU0=; b=LZcVtMTMbi7uCv+Ju068nGDwPtVKjKa7RDG5cJudDyRFYDc2nbSXlrtPd4xPstYmyvYqZ0 EGlYk3AItHQ3UTeHElaweZWmyc5J3x2/OzZE3H3Q0//EW/1mZ2bSXeQlIiWOgVxGKyye/N z9ZNSEKsDn/K263Fr9H2p6nT13G6ZqY= X-MC-Unique: QdWUnX42MhqW4g7QYVcPDg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677584818; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0nS0+RyN/H1npg0C1JIbWHZZ4SfeTHMMRyD4io5maU0=; b=5rrzPJrduvyZ6UjlksAtFwQRilWbb5vv5KgfTosH9g3zRfeDuskALFqcWV5W7CVz5s gQC2DiUk9CCctwxQwbKyhpwTBfFrhVGzfeDv2hwJ26C6Ii49UtoH9s99oD9q7LEJKtzl mNFBJYxQVfzi8p4hYHBt3BM8acNmlD6afPI2AGrIRIXCU0PAbdLnIvTB1ADFCopDd0Ba Jd/QZxJRhaalXqoXqJ+ncuQshP51PX+IcExa4RuleA9xamjdwmCAx+Mwue4Mnp60hpT9 KZXLS0Sa/xmJTzAZZxSBYDnLRSzJRjOj5hxi57ZPfoC78jtMaYPvX4MDpq/67wAGtH2+ jiCw== X-Gm-Message-State: AO0yUKXjGt+E3jF0R+1IYsEzJgFEPM1P69Vmu3T1VP11xFsZXMvwcWRV BK/xuXVlZGNx49d2evL8UUE7Jg7SeR6ZnWLeX/FaCHCto5oe2IPv00wP073cN1kDeVw/mdl2G4u 1dYPIMuFmyepS8my6LodTgo0hwX0= X-Received: by 2002:a05:600c:3d8f:b0:3e2:d3:b2b6 with SMTP id bi15-20020a05600c3d8f00b003e200d3b2b6mr2040466wmb.14.1677584818556; Tue, 28 Feb 2023 03:46:58 -0800 (PST) X-Google-Smtp-Source: AK7set9ukiJbDLLjbemAixbK8z9WCSaGKL85GygHLoDtlbZPMi8Ymp2kS5Em1Gh+o1UHoeYLychN2Q== X-Received: by 2002:a05:600c:3d8f:b0:3e2:d3:b2b6 with SMTP id bi15-20020a05600c3d8f00b003e200d3b2b6mr2040437wmb.14.1677584818147; Tue, 28 Feb 2023 03:46:58 -0800 (PST) Date: Tue, 28 Feb 2023 06:46:54 -0500 From: "Michael S. Tsirkin" To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts Message-ID: <20230228064623-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Feb 28, 2023 at 09:01:46AM +0000, Daniel P. Berrang wrote: > If we're merely wanting to drop CI support, we can do that any time and > deprecation is not required/expected. We should only be using deprecation > where we're explicitly intending that the code will cease to work. Good point, IMO. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:26:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503317.775538 (Exim 4.92) (envelope-from ) id 1pWz46-0001li-KW; Tue, 28 Feb 2023 12:26:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503317.775538; Tue, 28 Feb 2023 12:26:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWz46-0001lb-Hn; Tue, 28 Feb 2023 12:26:42 +0000 Received: by outflank-mailman (input) for mailman id 503317; Tue, 28 Feb 2023 12:26:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWz45-0001lV-LX for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 12:26:41 +0000 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [2a00:1450:4864:20::435]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 272105e2-b763-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 13:26:40 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id g3so648607wri.6 for ; Tue, 28 Feb 2023 04:26:40 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id c18-20020adfed92000000b002c54c9bd71fsm9920712wro.93.2023.02.28.04.26.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 04:26:38 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 272105e2-b763-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cu+nvG5w9sWCWl9GYD0stdG9tMSCSHPgD7RGc1i2YRA=; b=K3wluKxcE/rCvWqOkwXeehlmYRMbEq8RyljUSJLktvXWQYzvfV0JVuxh7sEjOItHLy zkB0bDfg1w0blyu7O79patbUxjElHTkQWl4dXxYhVt8U8TUSLz+j6ddCyrJhS7m5cNCn JLxtUFnp8BSUDvt4S4Tw2zxaHnbV4XxV4VEVqJ/d+Y8YmSoKUc7w/Eb9CcXJEnBvBW/A surEgKqpwer9fNgWwtsETr6+JOUrM+n0f+qX5qRY93yOvzTIh3pBSxNrOBcD3EKmU40Z QzGrVYDctK5UF7fdvl4Q/aoN9YBMtUH8C7ppyKj5Xnqt7NAR6KHA4YfeOrcVsxTwOU7s Czbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cu+nvG5w9sWCWl9GYD0stdG9tMSCSHPgD7RGc1i2YRA=; b=s6sZ/YnkEe9gF47KfF8eXndDItZgWe7jTics2NzxZPOxzEgNordHadWPIke+tIXDRM MEYy4OUvHL+49aGirZYlA8YWJaINc0p8Jvl1yJWRlHgAhBD4JpFlqYnaxSckhacWgq2r UvMZAD+qSI1GoUt8qjiDBbq+eqN3TFMQmltvhrV+VedW+mXCTtEMmcedR9qgGPm9IZ1N 4VjW65OR8g2CIlkOC9dPEG+bF9XDBWXRhtfQBaCM3Kwoo8N0PZLiMjJf0PpNkxkm+ADk bXkBQ4tdJLFBYQXtODIMu27xTPeNwMaQ0zdz4dSHGuK4KLhhvBvTwlE5yEVbzb+prrZU Deww== X-Gm-Message-State: AO0yUKUlqVuT8oqZqVkCnnOcr/sfDdO7rpJw11cPshu5sIG/exHyA6K2 kPNunTUrI6U3aw1+qAtoYyifvA== X-Google-Smtp-Source: AK7set/FeEH3SMp+xTRs7KN0rO4ziPX4ZU/IYrCCDHUXsFss9SGulRgXPV/twaTftMt+Opk3ZZcv+w== X-Received: by 2002:adf:f405:0:b0:2c7:2cf4:baff with SMTP id g5-20020adff405000000b002c72cf4baffmr2283941wro.70.1677587199717; Tue, 28 Feb 2023 04:26:39 -0800 (PST) Message-ID: <084ec45e-944c-32a5-163f-d2fe5666d3c9@linaro.org> Date: Tue, 28 Feb 2023 13:26:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Content-Language: en-US To: "Michael S. Tsirkin" , Richard Henderson Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <20230228035917-mutt-send-email-mst@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230228035917-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/2/23 09:59, Michael S. Tsirkin wrote: > On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: >> On 2/27/23 10:12, Michael S. Tsirkin wrote: >>> On Mon, Feb 27, 2023 at 11:50:07AM +0000, Daniel P. Berrangé wrote: >>>> I feel like we should have separate deprecation entries for the >>>> i686 host support, and for qemu-system-i386 emulator binary, as >>>> although they're related they are independant features with >>>> differing impact. eg removing qemu-system-i386 affects all >>>> host architectures, not merely 32-bit x86 host, so I think we >>>> can explain the impact more clearly if we separate them. >>> >>> Removing qemu-system-i386 seems ok to me - I think qemu-system-x86_64 is >>> a superset. >>> >>> Removing support for building on 32 bit systems seems like a pity - it's >>> one of a small number of ways to run 64 bit binaries on 32 bit systems, >>> and the maintainance overhead is quite small. >> >> It's not that small. It only works for single-threaded system mode. It >> silently does not honor atomicity for user-only mode, which is perhaps worse >> not working at all. Will the same occur with 64-bit hosts when we introduce a 128-bit target? If so, there is no much code we'll be able to drop, > We should probably block multi-threading on 32 bit then. so this sound a user experience fix. From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:35:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:35:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503321.775548 (Exim 4.92) (envelope-from ) id 1pWzC5-0003Yb-E7; Tue, 28 Feb 2023 12:34:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503321.775548; Tue, 28 Feb 2023 12:34:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzC5-0003YU-BK; Tue, 28 Feb 2023 12:34:57 +0000 Received: by outflank-mailman (input) for mailman id 503321; Tue, 28 Feb 2023 12:34:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzC4-0003YO-2B for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 12:34:56 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062f.outbound.protection.outlook.com [2a01:111:f400:fe1a::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ca5a30e-b764-11ed-a550-8520e6686977; Tue, 28 Feb 2023 13:34:53 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8884.eurprd04.prod.outlook.com (2603:10a6:20b:42f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 12:34:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 12:34:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ca5a30e-b764-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FZi6ftKGaHcnNH4jgXTwSKejPQX60Mm/upBFHHeOtwyR8T/C9efABzahkTYT2OMlQECa2+5u1cJkz5Q0orpYqwfsyy7P8vBTWfTbFBGpHoEiXDASUIZ7buZwHHqgI+fzl6SyAToGUYk/qP7LRaxRCCIeQ1v9arWRP2EKN4FcsR1rpLlU3M2ygn7tjo6XNTFxU6pyIIAKwHzD/JcoBUE3mNTa2T9PZ/g0b1pt/v0iD0Y4IYWs/Eaq9y7YCIAXTlSA4kK314MrqCnuJnvxRv5956PIMVl6H0LT/FxojjLRramniZwoGtWJQ8A0YsX3SkAPPryomwpTm4tC4tS5ZeQtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PHoImyOEH3Jag1SAWKnN+mf8f1/U72ET2yhEoZDlipk=; b=EZDhDWs45MwtDSG8qRve4D6gsPp11PpZkJIA1YUFOqWP9NzWDzRs0AxxLGXE2H9O+A1/cVDuH/sIwr8UOQnpwHXMxv6AvHt+JBY/mSfyFuhjtiKFnq142PU8zWZiA8zniFRoGXvedL76qmJu8WxAcYzPSIAuGhVLXsty+Caz6ASL5FDhp8qiRfjJQ65IUDBG3E7NAuEWF6z29PgZEWYwovp5psjv+7ljWs49+5xeVV4CkshlXaufSnJcqeyO1abOlZKU9T3vGGFWf43ysZYGTh6XFAtk8Bu5isio4KxXZOXpabvZCGg4HSsPktGuaA8OEfMmjAKGSPkvpjZ3cxYRNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PHoImyOEH3Jag1SAWKnN+mf8f1/U72ET2yhEoZDlipk=; b=1MrRi78+nv9g+dpxv1KVPoBB0vl2jWoux7qmPEkd3q81/ZjV1PtiNmCtc7Iw3/gvitigboL2vtIkh3rimqnybF8Hr0Y5m5cLy5+SOUuM2TJ8REYV387O5I6AGpAkdapauVCCslOOQB4EzyENxTXoaxE/QvYLOFQU9kWJQBmkN/h7l35zJnru97MecKepRyy+I+7m1CRquimV54tatqZo2kiK/SSYY0g1vwDVSGqjeqhoCW1jZAe2d+jyRyG7IlLBGy7C0V6zixyQpoB6y/ucrsEDtup3C1K/8nCOHVROzOQDKVwk4e9F3m42AJ2VTz7M9YUxoPPQYzl6dcg/t5pKrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a2ee9fa-df29-6665-771a-970c00c58838@suse.com> Date: Tue, 28 Feb 2023 13:34:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Jan Beulich Subject: [PATCH v4] core-parking: fix build with gcc12 and NR_CPUS=1 To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8884:EE_ X-MS-Office365-Filtering-Correlation-Id: 65fb8b88-0d86-46a8-ec3b-08db19882fe7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PtFSZY39xHPl280gScyWgi65WwkHMXH42dtHnqBCu2OYBZ3P4oDzCH3HYjATXXCwRK+/T46a+DiZKGTbQfzEVYFrsowxkW9HLJUnUi1JWgTylDfY8847zOiIazK0PXma1Vvit+AvITq/uM3DeGevFA0O+xNLQ1czIZ5DwgCEjDTy28HJfxsTUtnNfDTxSaOi8AwpJxwTQO9cY7zl6UBQbdVt14x4qAkckMkOMzy07Edn5notig0zqfw/paZhLGK6DH03Ua+qH7AVZmbvagwEuhFd8zc42Kj419eawKH84/073b9L9EBAu6UhFz1Gpz2NumVQwuWGsxybIHpriDF3HLAZxUDmKRSE7HMiG33CsOQWZO7NNXTO/st9WB2e+3+yV/OD6b6sfjGi/nYJ86p34SFBx+SKrHKlfWEy7ch+H6V7FXlx3YZGAPhbPtYLNRJtLVBtUvtRIK3m1xHeJCQZG4EyEaftJV6j8vurjJjUJYYuXy1vhsmSf2tcxqVuMMbeiBPPSfMQXA5WUN8eIq/fUniEeDp4c8mDfaEfZ+pIwv82Z3LbJUUpLDpN2NNku3Zb8i+D7JQLDUebyH9rejg2m7FFRw3+yGnCnIST5v6u1agI4wC7y23V8BLIjQ4tm13t0/oJFmnlsFZUFA1Nw3BliKujFHSp07vNbNwaGHb0bYQQ6pvJEjlOQeDJZqIzzNpOPv/dAgebVoQ0hIDijEWM+TBLbXFZJ82D+eUuk/KC2Xc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(136003)(39860400002)(346002)(396003)(451199018)(31686004)(83380400001)(316002)(54906003)(36756003)(4326008)(6916009)(38100700002)(8676002)(6512007)(2616005)(478600001)(6506007)(6486002)(186003)(31696002)(66556008)(66946007)(66476007)(5660300002)(86362001)(2906002)(26005)(8936002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjJEbE9VM2QyQkt3aDIzcS9aRldNaEhoVjJIOExNL2ZWSWhpcFlKMVoyem1Z?= =?utf-8?B?ZlNzVkg5R2E3T2lVeXBvWUFaamZlQXhsSjRTSkkwS3R4UHJuZUVySFlIcVY2?= =?utf-8?B?a1hYbUFyVkwrWHd6SHY4bzlLeTNjd0xuOTVSbFNFREFIK1gvZ2lDak9xWE0v?= =?utf-8?B?RTd4ZC9TZzRCYXpGVlVqb1RqUmNackUyWDlKZjBzV1FmS0czNWJSSFlqSnRu?= =?utf-8?B?Yy9BTzdjME9rNnNOMFYrTiswajdSZHNQNlZPL3RORG9uYUhUUzBlbXFtcUFH?= =?utf-8?B?a1V0TVBXc2dEU01uUjBQd0xRVTVmSU9yc2VJczczMUpNa2gzZ3JJSk5kY3p5?= =?utf-8?B?TGExKzN6SUJlU3gxM1VhbnptMXExRzhYR2pSbHVOTFlQbmwydTZacGROWEpu?= =?utf-8?B?ZnEvcjhCRmlXNTI0cXZZV2llWDh2OE82cjVTcFJ2dzRjbUJZL1ViS1hjOUd1?= =?utf-8?B?dXcyTndaNEFvWHF4NTlneU5wMmZVKzhmK3k1MmtoWllrV3F6ODNzem13dXFL?= =?utf-8?B?RTVRd1Via2JmSGc3NWpxaWlxaVliUVQxSEtKQWpXYm9aK0hFOHVLdjhTM0pW?= =?utf-8?B?dnVHZzFHMTFkRnBKN1Q5d2F6NGVEN0IrL3B1YmdJUjJPL0FOcnRDSjBRcEtM?= =?utf-8?B?MVVEb1NYU1IvNDY4TDNTZ1k0eTdDZ3NBeHBYWUl5dkkvU0xCQW14ZWQxbS9V?= =?utf-8?B?RXNXUUorNURZbCtMYTljRU8zSnppZytSTEE1TVZsTDd3WVF2LzV4MmNkUzhC?= =?utf-8?B?L213SWI2VWx2YTVZUTFnVUxqaURzR1ExaUhRZVJFQVlBSWdZL00rc1dNVTkx?= =?utf-8?B?RlF2eHAyWkFZditzTDhybTQvbTZFVEwzL2RWWjRqbHRmTGFzR2pWdXArajF2?= =?utf-8?B?VXJ2SHZDcTZtSE9HN3MzZy9OMWtQWUtOb0J0OGNFTEtUUk54UjU2VkdwMFFL?= =?utf-8?B?QzkwaXRZYmN0S2U1WnNkOFh0bUxzZmdNbjZ0V0ZFZGlGQklCMU5pL1hITEVH?= =?utf-8?B?bms1Qzh3dTR5OHJObTFHeGtzSW5uVGFMVnR1TDMvci9BaTAvL1I1QjBHSmJw?= =?utf-8?B?V1IrWXA3aUNGQm42UzNtaERIS3l6anRZUnZpMHIvZWcxSGNrSHdrWXVlaXY5?= =?utf-8?B?QlRmcXlwRU8waG1VUWVDd29lWXJpZFJ6THlFZEJtWVhreWV6SG5IdTRyRjh6?= =?utf-8?B?SHJ2Smo4R3FVTFdZWVIyYjZzMWVaQkVZYXhESGttNWVhMGdFNHlyMjlwajlK?= =?utf-8?B?Yi9FdXZWNERkYThhcmtsdlpHNDU2emwybjZBdFEyTC83ZGxua0pVU2RmR1RS?= =?utf-8?B?cDFZU3dVNnZ1dG1ESGlTM0Z5L2ZUS0lTSjhOUzhCMkdsRkJUOVZPNTFFSVhV?= =?utf-8?B?Q1RCa0ZYOXdta2xtZGVQUnZJUEF1MEJIWmtGeFRMTDhLQmhpNEFRdkNZTUJs?= =?utf-8?B?UlhXTGVZbkJMYS9sZzVBc0VQSVhPUmttY1lvYTVtT2VuNUJGUjYwS0hmaUY5?= =?utf-8?B?ZFI2Q2RaeEJSNkprNmp4cDd5Wm5Kc1p3cERvdzRLbzBLdTQ5K2w3RzBqUmFi?= =?utf-8?B?andZRmpyZ3ZQQmdkSmErb2dtK2x4TnBhUkc4WEJOdVpNOWNwTytMWW5UV3VI?= =?utf-8?B?cXZWY3pqMU0wU1Qvb1RDc0hndFh5a0xOdHRwTjVZNEIvOWZFcEJobTVRSTZr?= =?utf-8?B?bnBiNWw3K2VEZGNYbDZnTWZQdlVTTDY3Zm9GMzQzNkoyT2pTcFRQL2ppa2JL?= =?utf-8?B?UU9QU2toZ0NMbk9nOXh6SDhBbDNDS2ZIM2NYeWl6c3FnYk0ydU01ZXB4cS95?= =?utf-8?B?Z2VZWVBPVUFPSnQ2UUdiZW9NbVB2dGFhbDZ0ZjZVQXYyY3B3clAyWFBPTmJC?= =?utf-8?B?ZmpQdjAvU3c0cjkzYXp5emZvbEk0YUdkQmFYK21jem04SjkyTytPRW83bjhL?= =?utf-8?B?ZHZac09POE1zcEhLQWk3dkdZcnQySE1BK1V3VUhtczlSNjM2ZTBtWDVRYlVp?= =?utf-8?B?ZGRyN2QvVERyNzE1L2cybmErcWc4Vy91UjAzUkZScFFxRGxhMVU3QWdFMFpo?= =?utf-8?B?MTJ5Q3BxaGw4bS9oR01GL3h1OEdrU0k5bEl1NEdDclIwUEVBNHVrZ2VnbEtk?= =?utf-8?Q?1xrKCbepoQNRc8AfOg3TcJkb1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65fb8b88-0d86-46a8-ec3b-08db19882fe7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 12:34:51.5063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RejPLGW8Z8cco/2Myq4gt0cWI5HR2y9ewZuTzf+Znym4DsfRsoXN3qNZrbaSQ832s8YnSz5XXMMyNsrm+D5b3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8884 Gcc12 takes issue with core_parking_remove()'s for ( ; i < cur_idle_nums; ++i ) core_parking_cpunum[i] = core_parking_cpunum[i + 1]; complaining that the right hand side array access is past the bounds of 1. Clearly the compiler can't know that cur_idle_nums can only ever be zero in this case (as the sole CPU cannot be parked). Arrange for core_parking.c's contents to not be needed altogether, and then disable its building when NR_CPUS == 1. Signed-off-by: Jan Beulich --- v4: Restrict the arch_do_sysctl() change. v3: Use "imply" and "depends on" in Kconfig. Adjust the arch_do_sysctl() change. v2: Disable building of core_parking.c altogether. --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -10,7 +10,7 @@ config X86 select ALTERNATIVE_CALL select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 - select CORE_PARKING + imply CORE_PARKING select HAS_ALTERNATIVE select HAS_COMPAT select HAS_CPUFREQ --- a/xen/arch/x86/platform_hypercall.c +++ b/xen/arch/x86/platform_hypercall.c @@ -727,12 +727,17 @@ ret_t do_platform_op( case XEN_CORE_PARKING_SET: idle_nums = min_t(uint32_t, op->u.core_parking.idle_nums, num_present_cpus() - 1); - ret = continue_hypercall_on_cpu( - 0, core_parking_helper, (void *)(unsigned long)idle_nums); + if ( CONFIG_NR_CPUS > 1 ) + ret = continue_hypercall_on_cpu( + 0, core_parking_helper, + (void *)(unsigned long)idle_nums); + else if ( idle_nums ) + ret = -EINVAL; break; case XEN_CORE_PARKING_GET: - op->u.core_parking.idle_nums = get_cur_idle_nums(); + op->u.core_parking.idle_nums = CONFIG_NR_CPUS > 1 + ? get_cur_idle_nums() : 0; ret = __copy_field_to_guest(u_xenpf_op, op, u.core_parking) ? -EFAULT : 0; break; --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -178,6 +178,9 @@ long arch_do_sysctl( ret = -EBUSY; break; } + if ( CONFIG_NR_CPUS <= 1 ) + /* Mimic behavior of smt_up_down_helper(). */ + return 0; plug = op == XEN_SYSCTL_CPU_HOTPLUG_SMT_ENABLE; fn = smt_up_down_helper; hcpu = _p(plug); --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -10,6 +10,7 @@ config COMPAT config CORE_PARKING bool + depends on NR_CPUS > 1 config GRANT_TABLE bool "Grant table support" if EXPERT From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:39:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:39:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503326.775557 (Exim 4.92) (envelope-from ) id 1pWzFy-0004Fl-Uk; Tue, 28 Feb 2023 12:38:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503326.775557; Tue, 28 Feb 2023 12:38:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzFy-0004Fe-S3; Tue, 28 Feb 2023 12:38:58 +0000 Received: by outflank-mailman (input) for mailman id 503326; Tue, 28 Feb 2023 12:38:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzFx-0004BO-15 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 12:38:57 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dd9b0f51-b764-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 13:38:56 +0100 (CET) Received: by mail-lf1-x131.google.com with SMTP id m7so12948183lfj.8 for ; Tue, 28 Feb 2023 04:38:56 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id u15-20020ac24c2f000000b004d863fa8681sm1314849lfq.173.2023.02.28.04.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 04:38:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd9b0f51-b764-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xNJvH0eJn3IyuWFVpPtxQEwz8b5SHgd1l7W6efLmLs0=; b=fYXz1RY3ClCZnHXkTcXLziPFUfRTGJVGeocI3zHDx310pI0I/wL71KRPXvPy2bWMJS s/rZPVd4G8cglTTcgavt9HLjRNX7kUsPA6Dt0nplymjyFjLMMDMbMVBO1f8i0WfmTaxV pUDps0wzqxpm6pUGDPmAKBuRgakaG5RegrHFo4VOmXF4bYO9/FIWkyG+m2hauflYfvuk Yun3t5xmyA0nPKJh+fnK6cyUmJKrzmRn/A0lbJqU9N2HXUhp3ngaLr0aC6H5iyXirjnB GbNYZ8KLfQdOM5s9dej0ri7vOqHrQ/dBtnvfwaUT8uZuRo0X+vRomYcAOlkME7SVzuXh jfaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xNJvH0eJn3IyuWFVpPtxQEwz8b5SHgd1l7W6efLmLs0=; b=L+kpvDI4gHFLEMoQgpuP1SqJohFjIaWFjBEtkSZ/jl0NMeQ4+N3MRGeHmIKJvkNN7T 5PPPpcS+O6qa3vJwmRa/DN26DDdXd89TRJ+8KsKBHXkSE370rkIaTtZ1RyZL8D1vDWxm ZrmjmuHTJXwXh0S8I4nkWTXOgj4P8SVuitrPatWYcJ3DwKo+GqQCmjzXkAYvY7pmOHJt 5lTX6JIl1bVosXaK6eYgU0K35FsSqBSKn6VkZM9qs+qNzyqljyWH4DjvCE6c0fuBjMul sfEM61fVU67KcykEzhDfKoXEm6iocW6gSvSNoBeymGj7BbFa9c11pCjduA3OdJVMP7Hd fUMA== X-Gm-Message-State: AO0yUKXkP3NR2eAdwT3KM3dJDuuFKEMk5GNl4njPQLf+eN87HdXKxWzd ooHZ0mxKTejL+gc/rUetN3U= X-Google-Smtp-Source: AK7set84iPbVDf0DTkNNPz8iqyXRMkfTvr6hXvIWkk+ynLEHv19F6To2JXG3611+kbfs6sBvdhaL4w== X-Received: by 2002:ac2:4e66:0:b0:4dc:4e1e:ebfc with SMTP id y6-20020ac24e66000000b004dc4e1eebfcmr543243lfs.62.1677587935446; Tue, 28 Feb 2023 04:38:55 -0800 (PST) Message-ID: <319ddd67bca2291afe7f27cba3cf8eb4e1307747.camel@gmail.com> Subject: Re: [PATCH v3 2/4] xen: change to From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Roger Pau =?ISO-8859-1?Q?Monn=E9?= Date: Tue, 28 Feb 2023 14:38:53 +0200 In-Reply-To: <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi Julien, On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: > Hi Oleksii, >=20 > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > Since the generic version of bug.h stuff was introduced use > > > > instead of unnecessary > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > > =C2=A0 * Update patch 2 not to break compilation: move some parts from > > patches 3 and 4 > > =C2=A0=C2=A0=C2=A0 to patch 2: > > =C2=A0=C2=A0=C2=A0 * move some generic parts from to > > =C2=A0=C2=A0=C2=A0 * add define BUG_FRAME_STRUCT in ARM's > > --- > > Changes in V2: > > =C2=A0 * Put [PATCH v1 4/4] xen: change to as > > second patch, > > =C2=A0=C2=A0=C2=A0 update the patch to change all to among > > the whole project > > =C2=A0=C2=A0=C2=A0 to not break build. > > =C2=A0 * Update the commit message. > > --- > > =C2=A0 xen/arch/arm/include/asm/bug.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 19 +++---------------- > > =C2=A0 xen/arch/arm/include/asm/div64.h=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= 2 +- > > =C2=A0 xen/arch/arm/vgic/vgic-v2.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/arm/vgic/vgic.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/acpi/cpufreq/cpufreq.c=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/include/asm/asm_defns.h |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/include/asm/bug.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 19 ++----------------- > > =C2=A0 xen/drivers/cpufreq/cpufreq.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/include/xen/lib.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 9 files changed, 12 insertions(+), 40 deletions(-) > >=20 > > diff --git a/xen/arch/arm/include/asm/bug.h > > b/xen/arch/arm/include/asm/bug.h > > index f4088d0913..cacaf014ab 100644 > > --- a/xen/arch/arm/include/asm/bug.h > > +++ b/xen/arch/arm/include/asm/bug.h > > @@ -1,6 +1,8 @@ > > =C2=A0 #ifndef __ARM_BUG_H__ > > =C2=A0 #define __ARM_BUG_H__ > > =C2=A0=20 > > +#include >=20 > You are not adding new code in bug.h, so can you explain why this is > now=20 > necessary? >=20 > > + > > =C2=A0 #if defined(CONFIG_ARM_32) > > =C2=A0 # include > > =C2=A0 #elif defined(CONFIG_ARM_64) > > @@ -9,9 +11,7 @@ > > =C2=A0 # error "unknown ARM variant" > > =C2=A0 #endif > > =C2=A0=20 > > -#define BUG_DISP_WIDTH=C2=A0=C2=A0=C2=A0 24 > > -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > > -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >=20 > Even if the values are the same as the one you defined in the common=20 > bug.h, it doesn't feel right to remove them as long as... >=20 > > +#define BUG_FRAME_STRUCT >=20 > the arch is defining BUG_FRAME_STRUCT. So I would say the generic one > should be defined within BUG_FRAME_STRUCT. >=20 One of the reason BUG_DISP_WIDTH, BUG_LINE_* were removed is that they don't use in ARM at all... But generally I agree that it should be part of "#ifndef BUG_FRAME_STRUCT" as it is=C2=A0'struct bug_frame is dependent on it and these defines look 'struct bug_frame' specific. I'll update that in new version of the patch. > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:49:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:49:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503332.775567 (Exim 4.92) (envelope-from ) id 1pWzPb-000642-RJ; Tue, 28 Feb 2023 12:48:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503332.775567; Tue, 28 Feb 2023 12:48:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzPb-00063t-ON; Tue, 28 Feb 2023 12:48:55 +0000 Received: by outflank-mailman (input) for mailman id 503332; Tue, 28 Feb 2023 12:48:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzPa-0005zR-7q for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 12:48:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7d00::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4197e80b-b766-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 13:48:54 +0100 (CET) Received: from DB8PR06CA0008.eurprd06.prod.outlook.com (2603:10a6:10:100::21) by DBAPR08MB5592.eurprd08.prod.outlook.com (2603:10a6:10:1a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 12:48:50 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::43) by DB8PR06CA0008.outlook.office365.com (2603:10a6:10:100::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 12:48:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 12:48:49 +0000 Received: ("Tessian outbound c2bcb4c18c29:v135"); Tue, 28 Feb 2023 12:48:49 +0000 Received: from 6ef96cb99e7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 71DC350D-FEC3-4F17-BDB1-481558D593B0.1; Tue, 28 Feb 2023 12:48:42 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6ef96cb99e7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Feb 2023 12:48:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU0PR08MB8301.eurprd08.prod.outlook.com (2603:10a6:10:40f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 12:48:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 12:48:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4197e80b-b766-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cSfSJaQlVvT4XH7JtAFqHsJc7TufrDdXZ9LPhMAnd4c=; b=g6jZ1HAKLjk/s2evNR6i5F87XBme+dkgbELgBIP/LCdQcD77/YtCjYc6uFJSrXClPkz5u7YepyZyeBIDK17FJOgeTf0YPIRXFpeeMsbuU6bhSh5u7g24+sR3ccenaA/OAbQQd4QyRwYWI0wWQUa3xP5lgTuVWi1Vw9T80KBFtdE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8644626f020b8967 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RE3zxZD/wWWPxheukBtA4w3GadYj2v9qkIkyIGvJAwHnDPAZ5PlwXf6NPZXM1DPgR8yv/gHGYwlRJI+fEy1e1CpLXkV++i8bJOzZRJDVJn0NKODLvmr7tNxV/oSDhlAy3BxA0Xd9+3xWKWiF9fQW7UnKK3F2x1L1fEVH5FifJJfSB+jJB+Aq1ueDCU3foP5wJPa9tXG46iM/Q64NXQ/NXM1oeEotMIZjBOlO1Z3hGT7GBzhxmrq6c5gZ7qAcNTZTEySEtH6VrvtfwGTA3HegD/7okmLFp573EmQi9XGpteiRbhuBFTzY2joo07SWFDTxDK+PedTpp8bIc4p3Brwa2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cSfSJaQlVvT4XH7JtAFqHsJc7TufrDdXZ9LPhMAnd4c=; b=NiLHLZB/vgrPg4eEzCoi+NExY1RxyeWzNb6BnQz1LYRoXSKRUhan8i3QEGPL3QvohG4jemiia37JRc6HHrakKWovw36v1enr1m8bldP55aJbCroKHKZGV9+V2RDVxLCHHVfJgnqVkgnSRBM9wUh0Iaqzc1Ls+1b49vDA5Ol8yRBHm32mN/dC+kguAN7wGNGiW44QcQmIzN4TbEy2q1TbbbilSdfk9Qd8JrH9uXxHykvPvXsHR7/B6g94egRUiQVxF7WeC3E2U4M4DWgxyfQ/7AI6lpXhodq0LclapenZUTjfx4yS2JwyYAGBCGbie/GitQciFefolUWxCq1wCyhcUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cSfSJaQlVvT4XH7JtAFqHsJc7TufrDdXZ9LPhMAnd4c=; b=g6jZ1HAKLjk/s2evNR6i5F87XBme+dkgbELgBIP/LCdQcD77/YtCjYc6uFJSrXClPkz5u7YepyZyeBIDK17FJOgeTf0YPIRXFpeeMsbuU6bhSh5u7g24+sR3ccenaA/OAbQQd4QyRwYWI0wWQUa3xP5lgTuVWi1Vw9T80KBFtdE= From: Bertrand Marquis To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: check max_init_domid validity Thread-Topic: [PATCH] xen/arm: check max_init_domid validity Thread-Index: AQHZS0viJcxXSoqTp0W5BFLJDCsX267kNAcAgAAbRAA= Date: Tue, 28 Feb 2023 12:48:34 +0000 Message-ID: <4752ADE7-3E2A-4AAC-8023-3DFA2964CEF6@arm.com> References: <0cf2013e5e6018cae300c39fb65ed526eac5c35c.1677511937.git.bertrand.marquis@arm.com> <15c427ed-c452-a0d7-078e-58f040dcd9b4@amd.com> In-Reply-To: <15c427ed-c452-a0d7-078e-58f040dcd9b4@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|DU0PR08MB8301:EE_|DBAEUR03FT043:EE_|DBAPR08MB5592:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b0ffdf6-02dc-41ad-cb29-08db198a237e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8E5kBnoXlH2Es0N7wt3VnpFr8WnfmdCWKcQCRz83KuRlKVAIr/b3JH4cuv1QCsurgAkLZg6cSA8mM9rJ3XpB+d4WTcSnZGG5Z0LOWgx42L2Aef9uZf8NMQ01W6RWl+Wgpx4ZgaFZpluj2FC4VuxUrlbaa5o0AXzUqLERHfZ9bPz/l611DbTFY8VJVTlcA2OVg/lVEaXO5xX5Vo7gJ5YzDEtREm30tDYl1Q7d9cuzIuioJlQlJTRk5t/CVQRTBcDzSEF8FvSCh4G+XKKdl7wXsGx02fGzrzIZvFnq4cJZwXjeu5dHJ8uUUmGNMeDq57igKkQV/xrSqchxF9e4UpsRxEohEZMJRCsrrghFaCmab4LTeMJlN9GdxF6WcDCakqRuj7TDSovUskMs2MMbS4jskpTXWHjMRVu3c+p6fEFeHyfLExKdjGVSJQvzYD2w9SK//yXAnLOcrVZo6iIImIEtbpeAdrRQ8BKZl3cmXRALRSIreDyc/G5bsv3zFh2nHB4Ynhqo84GHX0Y2NKfCIwxYVYzGso5b4iIJSzem7nXA2N8NTWDq+7JdHybjqWli5EeeLhzaPyg7c7g4/0xVSqMaOUXUViKYJg8SCsHp3rsrxG3s7envTqdLBhunk0KaSLoWtZxT8gWCe8CMaMFeu5nsuiC5xwbjeQMJlS2EO1/ORDN54NIndv+mVACd1+sAu5Uc/xAwsW+Mn+k7b1hgZMuohZ49p0NHwtW/Dvm3mpQI0+g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199018)(2616005)(36756003)(53546011)(186003)(26005)(122000001)(38100700002)(8936002)(41300700001)(91956017)(4326008)(66556008)(66476007)(66446008)(64756008)(86362001)(66946007)(6916009)(5660300002)(8676002)(76116006)(478600001)(38070700005)(316002)(33656002)(54906003)(6486002)(2906002)(6506007)(6512007)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <12A6C682E03CD241A505A9B96CEDD1B8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8301 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 297d5c5b-bcc2-456a-d7f1-08db198a1ad5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uQvXMYBe3DICoy2PwVwBtMfXmE4aqSSnyGoMGxJJJ79PJ5lfgSWhJT6uQSjkDZZPxZ6mkIq3jfSVNWkvYnYlbgssiepLXZgXEFPs1ygWtjZbb4eSAWiRRuKF4E2Jwv7qX53H3ImiCJIrZuuY/3gxROXggv55Yk4I8/3ZkJdTEJCvkAq4JSm0iORbH0uoPFmXEw/LRecozfTYdF/W+YuJr/QrkrSVf9Pvr/xODJ7L6WX2JI7/5+RnQvBNUffMK6ciXW7XWtW2V3T1YxVR0alEJfCiVWnmTEjUtibp5tOcbNbiSpqSmEazxN6U/vmKKeDbQblU5wdRZMqs/OQCKEsCp3Q9fn+nuRFLKk9V7f7DHOjtUzOUM0FHsYw1FV5CQDklXU/0XN+8mvY3v3nF7SoTXgf5vCeUr32nMOIFh3drydYWET4yphY3XTo0lqKkD7Dr+MjO1VDLAyuZmwYZfrjxp0P1h2Zbc+QC5x3Q3d6ygsySSdpTtsbf8S7fDLue4pbY6W6fiQEySNn3S7DSGGKWrnXDJ8qOp4QOLVB3RJfOLrLCUURdFjbjX7W3QtqYoNv+3RchWiV+zpdSpRdfWOby+APNP0Ar+MN2vYnmZRSyjff/tfGBYO4QlKn71aSU91LLPn1BXhKwbC9QEbDtizT91OieNAv6DExjxdrmGo8yW7jL4no/sx6bXBjMYL6ipzB1HTk3ucdgCceNjN9Ylu2a8g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199018)(46966006)(40470700004)(36840700001)(47076005)(336012)(2616005)(36756003)(26005)(478600001)(186003)(81166007)(82740400003)(8936002)(6862004)(356005)(41300700001)(40480700001)(40460700003)(4326008)(70206006)(86362001)(70586007)(8676002)(53546011)(82310400005)(316002)(33656002)(54906003)(6486002)(2906002)(107886003)(36860700001)(5660300002)(6506007)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 12:48:49.4594 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0ffdf6-02dc-41ad-cb29-08db198a237e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5592 Hi MIchal, > On 28 Feb 2023, at 12:10, Michal Orzel wrote: >=20 > Hi Bertrand, >=20 > On 28/02/2023 09:08, Bertrand Marquis wrote: >>=20 >>=20 >> Before trying to create a dom0less guest, check that max_init_domid >> increment will generate a valid domain ID, lower than >> DOMID_FIRST_RESERVED. >>=20 >> Signed-off-by: Bertrand Marquis >> --- >> xen/arch/arm/domain_build.c | 3 +++ >> 1 file changed, 3 insertions(+) >>=20 >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index edca23b986d2..9707eb7b1bb1 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3879,6 +3879,9 @@ void __init create_domUs(void) >> if ( !dt_device_is_compatible(node, "xen,domain") ) >> continue; >>=20 >> + if ( (max_init_domid + 1) >=3D DOMID_FIRST_RESERVED ) >> + panic("No more domain IDs available\n"); > Here are some of my thoughts: > 1. The check if domid is >=3D DOMID_FIRST_RESERVED is used in quite a lot= of > places in the Xen code. We might want to introduce a global function for = that purpose > instead of repeating this check all over the codebase. We could introduce something but looking at the code i think that the first= thing to do would be to use is_system_domain where possible (ie when there is a domain = structure) and then cleanup a bit domctl.c where there are some double check of DOMID_FIRST_RESERVED (in the hypercall code and in is_free_domid). Once that is done, there would be a lot less usage of this. >=20 > 2. This check is something that could be moved to be generic. At the mome= nt we do have > an ASSERT with is_system_domain in domain_create. I know domain_create ca= n be called for > domids in special range so this would need to be thought through. I do not think that domain_create is the right place to have this check as = it is correct to call it to create system domains. >=20 > 3. The placement of this check at the top of the function before starting= to parse dt properties > might be problematic in the future if we decide to allow specifying stati= c domids for dom0less domUs. > In a static configuration, most of the time, we do not have xenstore (eit= her because of lack of xenstore > support or because of lack of dom0). AFAIKT, in Xen a domain can get to k= now its domid only through xenstore > (DOMID_SELF is not working in all the cases). Also, in a static configura= tion, it makes the life of an integrator > easy to know all the domids upfront to easily set up some communication, = grant tables, etc. Right now the idea is to fail as early as possible to prevent doing any ope= ration that is not needed. Having a way to statically define the dom id in configuration does make sen= se and the check will have to be modified once the support for this will be added. >=20 > Let me know your thoughts. There is some improvement possible in the overall code but the goal here is= just to solve a possible issue so this patch could be merged and other changes could be done in a following patch = if wanted. Cheers Bertrand >=20 > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:52:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503339.775578 (Exim 4.92) (envelope-from ) id 1pWzTI-0007oP-Ef; Tue, 28 Feb 2023 12:52:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503339.775578; Tue, 28 Feb 2023 12:52:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzTI-0007oI-BW; Tue, 28 Feb 2023 12:52:44 +0000 Received: by outflank-mailman (input) for mailman id 503339; Tue, 28 Feb 2023 12:52:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzTH-0007o8-10; Tue, 28 Feb 2023 12:52:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzTG-0000i4-Ug; Tue, 28 Feb 2023 12:52:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzTG-0000Xu-HX; Tue, 28 Feb 2023 12:52:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pWzTG-00076v-H2; Tue, 28 Feb 2023 12:52:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BFOgKVIoX9N2+KgaJyVJVQWXxuvDTjljsSTGnMrozcw=; b=a1txpWa3fUunPYxwgAPrcSaroH ECqwkpl2URPpthhFhmju4gR4TJFyaIfkHiwLiJME774k9hwP8PueIw5IsgPWlxe46FJCfZSB0nt84 IsYIAdZ8NqJ3bTBNlXdMLNsO11rw6bbJY+WAHNP89YOTprEWC9PDCx57F+cybIDSc3IY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 178726: regressions - trouble: broken/fail/pass/starved X-Osstest-Failures: xen-unstable:test-amd64-coresched-amd64-xl::broken:regression xen-unstable:test-amd64-coresched-amd64-xl:host-install(5):broken:regression xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate/x10:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:build-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):starved:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):starved:nonblocking xen-unstable:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=bfc3780f23ded229f42a2565783e21c32083bbfd X-Osstest-Versions-That: xen=608f85a1818697156b72ace4913a17c8178a0ef5 From: osstest service owner Date: Tue, 28 Feb 2023 12:52:42 +0000 flight 178726 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/178726/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-coresched-amd64-xl 5 host-install(5) broken REGR. vs. 178616 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 178616 test-amd64-amd64-qemuu-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 178616 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 178616 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 178616 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 178616 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 178616 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 178616 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 178616 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 178616 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 178616 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-examine 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-xl 1 build-check(1) starved n/a test-armhf-armhf-xl-credit1 1 build-check(1) starved n/a test-armhf-armhf-xl-credit2 1 build-check(1) starved n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) starved n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) starved n/a test-armhf-armhf-xl-rtds 1 build-check(1) starved n/a test-armhf-armhf-xl-vhd 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen bfc3780f23ded229f42a2565783e21c32083bbfd baseline version: xen 608f85a1818697156b72ace4913a17c8178a0ef5 Last test of basis 178616 2023-02-27 01:53:22 Z 1 days Failing since 178673 2023-02-27 15:09:21 Z 0 days 2 attempts Testing same since 178726 2023-02-28 02:47:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Edwin Török Jan Beulich Michal Orzel Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl broken test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-armhf-armhf-xl-cubietruck starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine starved test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-coresched-amd64-xl broken broken-step test-amd64-coresched-amd64-xl host-install(5) Not pushing. ------------------------------------------------------------ commit bfc3780f23ded229f42a2565783e21c32083bbfd Author: Michal Orzel Date: Mon Feb 27 14:12:35 2023 -0800 automation: Add container and build jobs to run cppcheck analysis Add a debian container with cppcheck installation routine inside, capable of performing cppcheck analysis on Xen-only build including cross-builds for arm32 and x86_64. Populate build jobs making use of that container to run cppcheck analysis to produce a text report (xen-cppcheck.txt) containing the list of all the findings. This patch does not aim at performing any sort of bisection. Cppcheck is imperfect and for now, our goal is to at least be aware of its reports, so that we can compare them with the ones produced by better tools and to be able to see how these reports change as a result of further infrastructure improvements (e.g. exception list, rules exclusion). Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini commit 6342f96689a5a112c3becedbccecef681e010b5d Author: Stefano Stabellini Date: Fri Feb 17 16:07:47 2023 -0800 automation: expand arm32 dom0 test adding xl domain creation As part of the arm32 dom0 test, also create a simple domU using xl. To do that, we need the toolstack installed in the dom0 rootfs. We switch to using the kernel and rootfs built by the Yocto arm32 job. Remove the PCI node from the host device tree: it is unused but causes a Linux hang at boot. Use xen-watchdog to trigger the domU creation for convience (/etc/local.d is not handled by rootfs.) Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel commit a0c3b87a764bcbd433f5f248c5ae2e2ca60a1321 Author: Stefano Stabellini Date: Fri Feb 17 16:07:46 2023 -0800 automation: add binaries/ to artifacts for Yocto arm32 job Copy the build output of Yocto builds to binaries/ for the arm32 target, and export binaries/ among the jobs artifacts so that they can be reused by other jobs. Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel commit adfb590ec384f92a4b5aebb111af25abbd1e026e Author: Stefano Stabellini Date: Fri Feb 17 16:07:45 2023 -0800 automation: move yocto jobs to build stage We are going to use artifacts produced by the Yocto builds in test jobs. Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel commit 49b1cb27413034c81023d1faf7af43690e87291a Author: Xenia Ragiadakou Date: Fri Feb 24 20:50:08 2023 +0200 x86/vmx: declare nvmx_enqueue_n2_exceptions() static Reduce the scope of nvmx_enqueue_n2_exceptions() to static because it is used only in this file. Take the opportunity to remove a trailing space. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich Acked-by: Andrew Cooper commit fdc25bd5da5e69e57286c97685ce9f862510253b Author: Xenia Ragiadakou Date: Fri Feb 24 20:50:04 2023 +0200 x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static Move vmx_update_debug_state() in vmcs.c because it is used only in this file and limit its scope to this file by declaring it static and removing its declaration from vmx.h. No functional change intended. Signed-off-by: Xenia Ragiadakou Acked-by: Andrew Cooper commit 275d13184cfa52ebe4336ed66526ce93716adbe0 Author: Edwin Török Date: Fri Feb 24 13:03:44 2023 +0000 libs/guest: Fix leak on realloc failure in backup_ptes() From `man 2 realloc`: If realloc() fails, the original block is left untouched; it is not freed or moved. Found using GCC -fanalyzer: | 184 | backup->entries = realloc(backup->entries, | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | | | | | (91) when ‘realloc’ fails | | | (92) ‘old_ptes.entries’ leaks here; was allocated at (44) | | (90) ...to here Signed-off-by: Edwin Török Acked-by: Andrew Cooper commit 1868d7f22660c8980bd0a7e53f044467e8b63bb5 Author: Andrew Cooper Date: Mon Feb 27 14:51:20 2023 +0000 libs/guest: Fix resource leaks in xc_core_arch_map_p2m_tree_rw() Edwin, with the help of GCC's -fanalyzer, identified that p2m_frame_list_list gets leaked. What fanalyzer can't see is that the live_p2m_frame_list_list and live_p2m_frame_list foreign mappings are leaked too. Rework the logic so the out path is executed unconditionally, which cleans up all the intermediate allocations/mappings appropriately. Fixes: bd7a29c3d0b9 ("tools/libs/ctrl: fix xc_core_arch_map_p2m() to support linear p2m table") Reported-by: Edwin Török Signed-off-by: Andrew Cooper Reviewed-by: Juergen Gross commit 35b3208a741f182ad95ad252944a82f4899f3816 Author: Andrew Cooper Date: Fri Feb 24 15:29:01 2023 +0000 CI: Simplify RISCV smoke testing Use a single fairly generic string as the "all done" message to look for, which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature is added. Signed-off-by: Andrew Cooper Reviewed-by: Oleksii Kurochko commit 5f74a1a198a986c566a11a1873ecc1b3c703789f Author: Andrew Cooper Date: Fri Feb 24 20:58:25 2023 +0000 x86/svm: Decouple types in struct nestedsvm struct nestedvm uses mostly plain integer types, except for virt_ext_t which is a union wrapping two bitfield names. However, it turns out that this is a write-only variable. Delete it, allowing us to drop the include of vmcb.h Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 4d6df4ec7544d7c912ffab6b6edb4cbefaa01f4c Author: Jan Beulich Date: Mon Feb 27 13:37:27 2023 +0100 x86/setup: drop stale declarations of __bss_{start,end}[] There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct Xen's idea of its own memory layout"). For what's left, switch to "unsigned char" as here we're not dealing with strings of any kind. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit db3897746cf8a0b77b13c589897237867800b023 Author: Jan Beulich Date: Mon Feb 27 13:36:58 2023 +0100 x86/shadow: drop dead code from HVM-only sh_page_fault() pieces The shadow_mode_refcounts() check immediately ahead of the "emulate" label renders redundant two subsequent is_hvm_domain() checks (the latter of which was already redundant with the former). Also guest_mode() checks are pointless when we already know we're dealing with a HVM domain. Finally style-adjust a comment which otherwise would be fully visible as patch context anyway. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 1950d8c351c3dd2ba9e4cc283ec91cb580824fd4 Author: Jan Beulich Date: Mon Feb 27 13:36:01 2023 +0100 x86/shadow: mark more of sh_page_fault() HVM-only The types p2m_is_readonly() checks for aren't applicable to PV; specifically get_gfn() won't ever return any such type for PV domains. Extend the HVM-conditional block of code, also past the subsequent HVM- only if(). This way the "emulate_readonly" also becomes unreachable when !HVM, so move the conditional there upwards as well. Noticing the earlier shadow_mode_refcounts() check, move it up even further, right after that check. With that, the "done" label also needs marking as potentially unused. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 4e8205f4fdb9a043170439c9c63542ddff816849 Author: Jan Beulich Date: Mon Feb 27 13:34:30 2023 +0100 x86/shadow: move dm-mmio handling code in sh_page_fault() Do away with the partly mis-named "mmio" label there, which really is only about emulated MMIO. Move the code to the place where the sole "goto" was. Re-order steps slightly: Assertion first, perfc increment outside of the locked region, and "gpa" calculation closer to the first use of the variable. Also make the HVM conditional cover the entire if(), as p2m_mmio_dm isn't applicable to PV; specifically get_gfn() won't ever return this type for PV domains. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Feb 28 12:57:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 12:57:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503348.775588 (Exim 4.92) (envelope-from ) id 1pWzY1-0008Ub-4o; Tue, 28 Feb 2023 12:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503348.775588; Tue, 28 Feb 2023 12:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzY1-0008UU-1L; Tue, 28 Feb 2023 12:57:37 +0000 Received: by outflank-mailman (input) for mailman id 503348; Tue, 28 Feb 2023 12:57:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzXz-0008UO-OY for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 12:57:35 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061f.outbound.protection.outlook.com [2a01:111:f400:fe1f::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78893f93-b767-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 13:57:35 +0100 (CET) Received: from DB6PR0601CA0048.eurprd06.prod.outlook.com (2603:10a6:4:17::34) by GV2PR08MB9423.eurprd08.prod.outlook.com (2603:10a6:150:dd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 12:57:32 +0000 Received: from DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:17:cafe::15) by DB6PR0601CA0048.outlook.office365.com (2603:10a6:4:17::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 12:57:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT053.mail.protection.outlook.com (100.127.142.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 12:57:31 +0000 Received: ("Tessian outbound b29c0599cbc9:v135"); Tue, 28 Feb 2023 12:57:31 +0000 Received: from f1e808978662.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FF432D7E-C6FC-4D63-BD90-AF9847918E53.1; Tue, 28 Feb 2023 12:57:24 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f1e808978662.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Feb 2023 12:57:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM8PR08MB5684.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 12:57:21 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 12:57:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78893f93-b767-11ed-9694-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzsDT6n6OBEenB1hhMvUVY+Y5fvDRTwBhH2fvsNQME0=; b=gWndlW01Wnif5FFGcB3hIjHaOOU/wVGTjMq5ruOEn138iwb7Vvda4LEAOfMSe5uyEt9pSnX9Zz1rPm+BeuQ/pb7xFzyfKbsx2x79B3D3huIv0r7ybppgSR/WkOV0qiEg+dj4Rghnd0zq73qlpufvD+nDjcFx1naEaHo/jV3nM44= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9b294b88b84848db X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CTWcum98rMsLxIEeoCFzG3rMvutifIl5RIa2eb5RBbEuHiXnwvi7pZyHzfMiz8at7uj+ttZ+7bz3ivFZ/1+FR59N6jGaDSaxa1Yj1OD/3L+hmhGg/IbF5jjOmyrqlox4yd69sKxFEom3OfWdPlYvbXYDAcTIa7d36IPb3CStvmuGAcXCpblnIJJF0zGy3bya3KY3JL+x66jWxGErIppWZABk/LE6xF+2RIatLnUIMCdG+uhk9+ZJ86c8SZmQgaE0wNkhWv3O7zqlTIQjdyjMMB4PFhDz5yv926PsUwawl/S7aj15Jkl1Qx6xpkqrEo9iJS7i4RSUFsQKRYF3+lHFMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QzsDT6n6OBEenB1hhMvUVY+Y5fvDRTwBhH2fvsNQME0=; b=PIk6awVkLG6eojf94vmuCYKlLNM4De2G9xSMK0k3PbUBv9zqeiR0zPTJCdDpi0MpF6CiYwddGZyKF16P03bPuyM6Q9OImOCR0O0QC0VEqFzRW/Pm+s1o3v5CH2mRFVdsdAWbk/BNAHEF1hZMmY0xpQjRhcNxFyFV1UKFSCM+G6OJfTWh3LQ2PH65Cs3UrckYdo6ho6FEIEgdGjgi3CW9/S9kDsVF5qI9zRLWa9P8F7JiZCknyhhCoo11eK18FU6KJLiWHmjNL1VWeo2fQY/z9IqYokUmW91O/NNZLng5xcjfy8gtgWeRhJ9mvAQQL5dkxmGpZqdhXzQzcUBFgLISfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QzsDT6n6OBEenB1hhMvUVY+Y5fvDRTwBhH2fvsNQME0=; b=gWndlW01Wnif5FFGcB3hIjHaOOU/wVGTjMq5ruOEn138iwb7Vvda4LEAOfMSe5uyEt9pSnX9Zz1rPm+BeuQ/pb7xFzyfKbsx2x79B3D3huIv0r7ybppgSR/WkOV0qiEg+dj4Rghnd0zq73qlpufvD+nDjcFx1naEaHo/jV3nM44= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 11/20] xen/arm: ffa: map SPMC rx/tx buffers Thread-Topic: [XEN PATCH v7 11/20] xen/arm: ffa: map SPMC rx/tx buffers Thread-Index: AQHZRtMejEsJsgt3902OVIzV3uFpCq7kWrAA Date: Tue, 28 Feb 2023 12:57:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AM8PR08MB5684:EE_|DBAEUR03FT053:EE_|GV2PR08MB9423:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c5e1670-5fd8-430c-6bf2-08db198b5ac2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MhpePjLEcEY0F2m1kK0qccJD8ZyX41lHbGxidMaIfOksuoyC1h4sKeFgjCNPNj8vP6JuLTgP84YH5w6fxWacMOSPA8V4hPCGg578XiOOyj/XR+BeMOSVoR/Uy4lDuSa6mrt1Y3gRDnfp7f6EdfnT3+l02wBPZaxzY0QgSfT/h0TM47DvKqen846a4kUwVcPhYfZVluli4Pam+S8rLEdjUY5bQNgsiSv4GB5NnQRf5ViqwfexuTC+pupaYiiYuiMvo7EdChG3sEO8BXCZJtHc4SC1nHtMpz/h/zI/lcElx1sJ5n8V2HC7fhGdo9qezMfOU4QMkWh+nlCpTyjqYG1uO033/o37VcMDwpGFO9dhuzvJkWjMWIEPQIp3GTOQxqeFVNXCjynOTo/bc62cIRZw4V+iDfWLq0f2AH2altoNkcdIP48k22ebN6pxDe1vKA3ZB9FYU0SmhWMyHzGSrO70V8QejBQ8+rp+ikFyRNqSZpIToF2Rbz3CGxfbLFpH8iwJrdyYKLytbd0uCph/1YNe6msKi4Gx//cWRpYkLMnEN7vdGOFGxFmzphv7QKdcAt4mEPcBwx0kA4bta3fkAY1UcHRuiLN1Qleeblyv9yMCQb2goxs/KyA/sicGAQkRxq0KKL3bcezGw90oolwe5DfQUY24a0IsP4N7jCPx/q92Nmxd0y9FtWmCug62Vf1YsjC+beMsRrJkFh20btEyYL3uzvZLkG3W4oCzlYY33hJwXB0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(451199018)(2616005)(36756003)(53546011)(186003)(26005)(122000001)(38100700002)(8936002)(41300700001)(91956017)(83380400001)(4326008)(66556008)(66476007)(66446008)(64756008)(86362001)(66946007)(6916009)(5660300002)(8676002)(76116006)(478600001)(38070700005)(316002)(33656002)(54906003)(6486002)(2906002)(6506007)(6512007)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5684 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b8a0f77c-ebaa-4845-30ee-08db198b5461 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0NrPb/HSFxzOh8HcgE9xcswVxBM/IQa6gnPNduhfMBvDnNyKyExe0izJNwa0uRa87rf57HWB2IglAzvmZInEtQpmBekr57tgCHI0KfJl8DGeaRYjTFiEPAsXc2B1eqaB5xKtLVFhHGrTVi7+YUPTZUsW75rBWy5WQaHRaV+D/gXvwdVQxBcXnDWF6OGA6vGHgr3nKX/KWCfC9JRqZCM+gtV9UA6E2vgr2RwEGUqY//A/oEwS9VvoqmKMzA+qK/V2QcXXCo/An0sbFjh9nL9x9gOU5VI5QSI0ewNICqY0kniQPHMeNbA9DUkLBNscFahgI0uMi84O0gaP/aEmiLfoOGX9lf4kYDyzChHiZ++EAYuQa1Pk0OcGuYR9wk8bIe+GNLvY0T9uzDm4/dO2Zxvpff4/MT72sAsgGosZCo1xYZ8DKTAvGHmx26YVaT236Xnhx9vBs2rC2J7deY19iR69Pso3Vn8lj+iZK3hiXq1/J/PDHlpzy41xByUNDU662xWehxBYkcrcaUzRGN4K7i/lFAlQp7ALXC+EyUdsKij8/sGl4ZsI6NntIPZRSykteIuaVgsse7nLvOUSKMU85Vm48ddPT24+Afz00xbeR9ihXUh/ozRGLz6VnhemjFK/VgiTJdIdkdY87nAh74Po02SjeuGKEv9F0PZkvOdVwYxuyy8vPhUKnl40xVYp3enQ2fcvAYAZkic91RaPdfC1MZVLlg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(39860400002)(346002)(136003)(451199018)(46966006)(40470700004)(36840700001)(36756003)(86362001)(33656002)(40480700001)(70206006)(8676002)(5660300002)(4326008)(41300700001)(8936002)(6862004)(2906002)(356005)(82740400003)(81166007)(36860700001)(6486002)(478600001)(54906003)(316002)(70586007)(82310400005)(186003)(83380400001)(47076005)(2616005)(40460700003)(6512007)(336012)(26005)(53546011)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 12:57:31.6740 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c5e1670-5fd8-430c-6bf2-08db198b5ac2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9423 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > When initializing the FF-A mediator map the RX and TX buffers shared with > the SPMC. >=20 > These buffer are later used to to transmit data that cannot be passed in > registers only. >=20 > Adds a check that the SP supports the needed FF-A features > FFA_RXTX_MAP_64 / FFA_RXTX_MAP_32 and FFA_RXTX_UNMAP. In 64-bit mode we > must use FFA_RXTX_MAP_64 since registers are used to transmit the > physical addresses of the RX/TX buffers. Right now, FFA on 32bit would only work correctly if LPAE is not used and o= nly addresses under 4G are used by Xen and by guests as addresses are transferred through= a single register. I think that we need for now to only enable FFA support on 64bit as the lim= itations we=20 would need to enforce on 32bit are complex and the use case for FFA on 32bi= t platforms is not that obvious now. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 57 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 56 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index a5d8a12635b6..07dd5c36d54b 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -148,6 +148,15 @@ struct ffa_ctx { > /* Negotiated FF-A version to use with the SPMC */ > static uint32_t ffa_version __ro_after_init; >=20 > +/* > + * Our rx/tx buffers shared with the SPMC. > + * > + * ffa_page_count is the number of pages used in each of these buffers. > + */ > +static void *ffa_rx __read_mostly; > +static void *ffa_tx __read_mostly; > +static unsigned int ffa_page_count __read_mostly; > + > static bool ffa_get_version(uint32_t *vers) > { > const struct arm_smccc_1_2_regs arg =3D { > @@ -217,6 +226,17 @@ static bool check_mandatory_feature(uint32_t id) > return !ret; > } >=20 > +static int32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > + uint32_t page_count) Using register_t type here is doing an implicit cast when called and on 32bit this might later remove part of the address. This function must take paddr_t as parameters. > +{ > + uint32_t fid =3D FFA_RXTX_MAP_32; > + > + if ( IS_ENABLED(CONFIG_ARM_64) ) > + fid =3D FFA_RXTX_MAP_64; > + > + return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); simple call might not be suitable on 32bits due to the conversion. As said earlier, it would make more sense to disable FFA on 32bit and put some comments/build_bug_on in the code in places where there would be something to fix. > +} > + > static uint16_t get_vm_id(const struct domain *d) > { > /* +1 since 0 is reserved for the hypervisor in FF-A */ > @@ -384,6 +404,7 @@ static int ffa_relinquish_resources(struct domain *d) > static bool ffa_probe(void) > { > uint32_t vers; > + int e; > unsigned int major_vers; > unsigned int minor_vers; >=20 > @@ -426,12 +447,46 @@ static bool ffa_probe(void) > printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > major_vers, minor_vers); >=20 > - if ( !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > + if ( > +#ifdef CONFIG_ARM_64 > + !check_mandatory_feature(FFA_RXTX_MAP_64) || > +#endif > +#ifdef CONFIG_ARM_32 > + !check_mandatory_feature(FFA_RXTX_MAP_32) || > +#endif > + !check_mandatory_feature(FFA_RXTX_UNMAP) || > + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > return false; >=20 > + ffa_rx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_rx ) > + return false; > + > + ffa_tx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_tx ) > + goto err_free_ffa_rx; > + > + e =3D ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", e); > + goto err_free_ffa_tx; > + } > + ffa_page_count =3D 1; ffa_page_count is a constant here and is not used to do the allocation or passed as parameter to ffa_rxtx_map. Do you expect this value to be modified ? how ? Please set it first and use it for allocation and as parameter to rxtx_map = so that a modification of the value would only have to be done in one place. Please use a define if this is a constant. As it is a global variable, does the parameter to rxtx_map make sense ? Cheers Bertrand > ffa_version =3D vers; >=20 > return true; > + > +err_free_ffa_tx: > + free_xenheap_pages(ffa_tx, 0); > + ffa_tx =3D NULL; > +err_free_ffa_rx: > + free_xenheap_pages(ffa_rx, 0); > + ffa_rx =3D NULL; > + ffa_page_count =3D 0; > + ffa_version =3D 0; > + > + return false; > } >=20 > static const struct tee_mediator_ops ffa_ops =3D > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 13:07:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 13:07:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503352.775598 (Exim 4.92) (envelope-from ) id 1pWzhF-0001vc-0w; Tue, 28 Feb 2023 13:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503352.775598; Tue, 28 Feb 2023 13:07:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzhE-0001vV-UQ; Tue, 28 Feb 2023 13:07:08 +0000 Received: by outflank-mailman (input) for mailman id 503352; Tue, 28 Feb 2023 13:07:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzhD-0001vP-Fq for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 13:07:07 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc60d56a-b768-11ed-a550-8520e6686977; Tue, 28 Feb 2023 14:07:05 +0100 (CET) Received: by mail-lf1-x136.google.com with SMTP id r27so13052105lfe.10 for ; Tue, 28 Feb 2023 05:07:05 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id z22-20020ac25df6000000b0049c29389b98sm1328575lfq.151.2023.02.28.05.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 05:07:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc60d56a-b768-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Zbu3uOYcqV6B5B018G+P6OrukBE5mSo5Fb0sDScl+oU=; b=OolWCfZXbYQL3UsQiMY6SF9g2OOR93dFFlD493DBgHxpqeioq6Sxggdyppndu99a2R aLcGvI9Wq2e5ySLipMwLUgelWVHcbh2AUvxWbfXQ1RVnD/Lvf3mk5C8d28agtcjqLr5u UJs1wMm3Q0b7xz2d4jeXfjQ9yEajf1TeGKIcw/ydnmn4ATou2yH92iwCvZiv0tg1KeJq pF5kf6qchaQ1n7EqRmZnZIKnmQ81nS07npl3STiEBZFJF3jQpw1NP9PkVNoMReI9+E2x M9jw6mUXergbKewN4qQYkryrw+xdJzLDqLz4M2f3AeYbbm62v8DpnrVbxRDViAczMhIO JDmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Zbu3uOYcqV6B5B018G+P6OrukBE5mSo5Fb0sDScl+oU=; b=fiyvYMwb3YKY5ODOFecPHrKq2zMC+Bj1rvTzP9jmppyctRwKggSMgwWkpI4ppuxRIp +z5awR4p+FmvniBNPg4Tsdq7AjHnBR+GnCwoA65ovLHh9o2yB3fI2yqoNT+/vcCQdHM8 /bK+NAR3qJIQ0NK3wFQ7fBC4R2e5MOazpF5ThXaKV77ZIDwRis73av1kS9XI+9tVNNUA HzRERAjz0Ugo9dEKb6y+2bZdl4J9tyuk/Pupfwk5aNDk3sc0qs6+Xic2frz8AImGtOLp RXlUotMlTBBtxTsBkAfYVrdbFD2yz/3yAwPXmiInZny3uTqiNDcpHgzlMHVOEIdkN+CG xBXA== X-Gm-Message-State: AO0yUKWVkROj6JNzHu+fFCrVhjIQ87GQBEoPx8PvAqVy48nE7gDQlvl8 rfx2TPBQBbzggA2e7ACt8k8= X-Google-Smtp-Source: AK7set9AvsaGHK+zibc9ozpdcufhEBtXkpPNeLH4GhM3y9QIl27L75jMwTMoUx40gJ4zk6LH6RsckA== X-Received: by 2002:ac2:442e:0:b0:4d8:7f17:d0e9 with SMTP id w14-20020ac2442e000000b004d87f17d0e9mr640657lfl.14.1677589624612; Tue, 28 Feb 2023 05:07:04 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 2/4] xen: change to From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Roger Pau =?ISO-8859-1?Q?Monn=E9?= Date: Tue, 28 Feb 2023 15:07:02 +0200 In-Reply-To: <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: > Hi Oleksii, >=20 > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > Since the generic version of bug.h stuff was introduced use > > > > instead of unnecessary > >=20 > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > > =C2=A0 * Update patch 2 not to break compilation: move some parts from > > patches 3 and 4 > > =C2=A0=C2=A0=C2=A0 to patch 2: > > =C2=A0=C2=A0=C2=A0 * move some generic parts from to > > =C2=A0=C2=A0=C2=A0 * add define BUG_FRAME_STRUCT in ARM's > > --- > > Changes in V2: > > =C2=A0 * Put [PATCH v1 4/4] xen: change to as > > second patch, > > =C2=A0=C2=A0=C2=A0 update the patch to change all to among > > the whole project > > =C2=A0=C2=A0=C2=A0 to not break build. > > =C2=A0 * Update the commit message. > > --- > > =C2=A0 xen/arch/arm/include/asm/bug.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 19 +++---------------- > > =C2=A0 xen/arch/arm/include/asm/div64.h=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= 2 +- > > =C2=A0 xen/arch/arm/vgic/vgic-v2.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/arm/vgic/vgic.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/acpi/cpufreq/cpufreq.c=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/include/asm/asm_defns.h |=C2=A0 2 +- > > =C2=A0 xen/arch/x86/include/asm/bug.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 | 19 ++----------------- > > =C2=A0 xen/drivers/cpufreq/cpufreq.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 xen/include/xen/lib.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- > > =C2=A0 9 files changed, 12 insertions(+), 40 deletions(-) > >=20 > > diff --git a/xen/arch/arm/include/asm/bug.h > > b/xen/arch/arm/include/asm/bug.h > > index f4088d0913..cacaf014ab 100644 > > --- a/xen/arch/arm/include/asm/bug.h > > +++ b/xen/arch/arm/include/asm/bug.h > > @@ -1,6 +1,8 @@ > > =C2=A0 #ifndef __ARM_BUG_H__ > > =C2=A0 #define __ARM_BUG_H__ > > =C2=A0=20 > > +#include >=20 > You are not adding new code in bug.h, so can you explain why this is > now=20 > necessary? I am not adding new code but inside 'struct bug_frame' there are uint16_t and uint32_t which are defined in . And after was changed to it started to complain on these types. >=20 > > + > > =C2=A0 #if defined(CONFIG_ARM_32) > > =C2=A0 # include > > =C2=A0 #elif defined(CONFIG_ARM_64) > > @@ -9,9 +11,7 @@ > > =C2=A0 # error "unknown ARM variant" > > =C2=A0 #endif > > =C2=A0=20 > > -#define BUG_DISP_WIDTH=C2=A0=C2=A0=C2=A0 24 > > -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > > -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >=20 > Even if the values are the same as the one you defined in the common=20 > bug.h, it doesn't feel right to remove them as long as... >=20 > > +#define BUG_FRAME_STRUCT >=20 > the arch is defining BUG_FRAME_STRUCT. So I would say the generic one > should be defined within BUG_FRAME_STRUCT. One of the reason BUG_DISP_WIDTH, BUG_LINE_* were removed is that they don't use in ARM at all... But generally I agree that it should be part of "#ifndef BUG_FRAME_STRUCT" as it is 'struct bug_frame is dependent on it and these defines look 'struct bug_frame' specific. I'll update that in new version of the patch. >=20 > Cheers, >=20 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 13:14:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 13:14:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503357.775608 (Exim 4.92) (envelope-from ) id 1pWzo3-0003iD-Nt; Tue, 28 Feb 2023 13:14:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503357.775608; Tue, 28 Feb 2023 13:14:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzo3-0003i6-L4; Tue, 28 Feb 2023 13:14:11 +0000 Received: by outflank-mailman (input) for mailman id 503357; Tue, 28 Feb 2023 13:14:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pWzo2-0003i0-0M for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 13:14:10 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c85b50e9-b769-11ed-a550-8520e6686977; Tue, 28 Feb 2023 14:14:08 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id i28so383331lfv.0 for ; Tue, 28 Feb 2023 05:14:08 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id w11-20020ac254ab000000b004d865c781eesm1330635lfk.24.2023.02.28.05.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 05:14:07 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c85b50e9-b769-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=dlqoj5iWe/oymfTsrc7Y15VaXrPpCoFoudHuwzCUec8=; b=pSzV1nvihnA16L0BU9lHsSZxkHzox9uTTnR/5YuoPcqx4Zxqw3tgQdDQfXPbxq99TZ j2rvJuvtwUDQESzQ4KNnObj83DPuLDIaFpCy2amUlRpyidvUb8OKP2lfns3uuL4J5s7W XGzWI9l/LMILjnaOP+xXWzVDUHrI+5TwFZf95QFTBaTulHx1gphAFLnjYqiZryh+cbRg iBVuzvPbNYuHyIfsEBgEgnRh9WO9UxZazzxDfYYm2yyXbudNvP1kI990uU6l/R3IWB9z Adt9YC7Qd7Y9eka+flWXXOT4Upnd8xusYEDgFSkpVlYQAr6FwTbopF6C6ec285o3ILOy xw/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dlqoj5iWe/oymfTsrc7Y15VaXrPpCoFoudHuwzCUec8=; b=e2eOf4GzSFFvolz+F2LD65LYhFYo2dxeHZNT6N5waElGdzGfIIWMhvVvyLYRqHajwH yr6VBVmHWRBvYh5bmdJmJ7TZwXBbH7bL0WnrqLUwhILIgEFMj8alFJorXFCHgF1YnqOB D69hega3xvcenM3EtQr9Hzqde/L7csncbAJiqOVwRiVHWAgXwaYuSJcDa+Prv+W/x3HD v/CtZv/06rcvWdsLNchvBN3bGS86hqW4BAQrkseHxViD7ixsHDkkmZ3xlcVkIn4YKYJL OW5cd+R6dprRo25S3SP/PhKbOzaMKl+mmmhbOFKXm94GMFctGT7L4JRpo3rP+vjYxJEr ux8A== X-Gm-Message-State: AO0yUKUsXA6l9pw63cMkvlatmjnQVw8GyDxVo6NdRT87GspWDjYmHqpB UK1gNGga976rTmnz1pTcUOA= X-Google-Smtp-Source: AK7set+jqzIhN4nr8IDnoB6h8WoJSPOyCb/dN2aeyQRrGZ7PhlrzHgvMw2MIYGjJ9cg+AgRmUsOn0w== X-Received: by 2002:a05:6512:3404:b0:4dd:9931:c4f6 with SMTP id i4-20020a056512340400b004dd9931c4f6mr1019471lfr.16.1677590047338; Tue, 28 Feb 2023 05:14:07 -0800 (PST) Message-ID: <9fb7bf20384778ddbe16030cfece3dcb942d0612.camel@gmail.com> Subject: Re: [PATCH v3 2/4] xen: change to From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , xen-devel@lists.xenproject.org Date: Tue, 28 Feb 2023 15:14:05 +0200 In-Reply-To: <6b6fa456-4653-4fc0-d777-985ee217954f@suse.com> References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <6b6fa456-4653-4fc0-d777-985ee217954f@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Mon, 2023-02-27 at 15:29 +0100, Jan Beulich wrote: > On 24.02.2023 12:31, Oleksii Kurochko wrote: > > Since the generic version of bug.h stuff was introduced use > > > > instead of unnecessary >=20 > You keep saying "unnecessary" here, but that's not really correct. > Including asm/bug.h alone simply becomes meaningless. So how about > "... instead of now useless (in isolation) "? >=20 > > --- a/xen/arch/x86/include/asm/bug.h > > +++ b/xen/arch/x86/include/asm/bug.h > > @@ -1,19 +1,10 @@ > > =C2=A0#ifndef __X86_BUG_H__ > > =C2=A0#define __X86_BUG_H__ > > =C2=A0 > > -#define BUG_DISP_WIDTH=C2=A0=C2=A0=C2=A0 24 > > -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) > > -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) > > - > > -#define BUGFRAME_run_fn 0 > > -#define BUGFRAME_warn=C2=A0=C2=A0 1 > > -#define BUGFRAME_bug=C2=A0=C2=A0=C2=A0 2 > > -#define BUGFRAME_assert 3 > > - > > -#define BUGFRAME_NR=C2=A0=C2=A0=C2=A0=C2=A0 4 > > - > > =C2=A0#ifndef __ASSEMBLY__ > > =C2=A0 > > +#define BUG_FRAME_STRUCT > > + > > =C2=A0struct bug_frame { > > =C2=A0=C2=A0=C2=A0=C2=A0 signed int loc_disp:BUG_DISP_WIDTH; > > =C2=A0=C2=A0=C2=A0=C2=A0 unsigned int line_hi:BUG_LINE_HI_WIDTH; >=20 > Why would x86 continue to define its own bug_frame (and other items)? >=20 Because x86 will be switched to generic one in the following patches of the patch series and right now it defines only BUG_FRAME_STRUCT which means that it will not use generic one implemetation now. The idea of the patch was to rename to with minimal required changes to keep Xen compilable. And I am going to back: -#define BUG_DISP_WIDTH 24 -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) for the same reason as in ARM. these defines are related to 'stuct bug_frame' so should go with it. These defines will be removed when an architecture will be switched to generic implementation. > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 28 13:31:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 13:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503368.775618 (Exim 4.92) (envelope-from ) id 1pX04C-0006t8-8e; Tue, 28 Feb 2023 13:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503368.775618; Tue, 28 Feb 2023 13:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX04C-0006t1-5l; Tue, 28 Feb 2023 13:30:52 +0000 Received: by outflank-mailman (input) for mailman id 503368; Tue, 28 Feb 2023 13:30:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX04A-0006sv-Oj for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 13:30:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2047.outbound.protection.outlook.com [40.107.7.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d1547cc-b76c-11ed-9694-2f268f93b82a; Tue, 28 Feb 2023 14:30:49 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7947.eurprd04.prod.outlook.com (2603:10a6:10:1f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 13:30:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 13:30:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d1547cc-b76c-11ed-9694-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQN+DZuZ+MSAClP4sUpFG6AoRHrKKaVkqTaKQrtQWwQI/9uvkPq9Z8vOy5aIspBD/k7m+JAfGNnldwEKCGR8HqjX9GVVpRn+YcL4LjXI0q419PlWIFvFysu4ctehYUtx7bV12/OpDxUzv7veYd2hyCAu6b/Aj9PLHvwQw1wDCUJX+9Ij0d0C8y+9KcSz/ImNI6bYwzqvTSjjIrY9Q3yni3vz4JJ5N9iKznoX4hDoDFT12fXiVzU7VNsnJ+FMAqkMDtY7x0mAGlKBQ5FM/TP5pyv2tJZ375yG96tUfa4EZrfYrpiJKx82PIxAsSmxMCX9mWuZ2KIesYvN0jILfCrXnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=akQIpc+pcGoR44L4zVN4vbvumJooUlhCV2CPJgRI9B4=; b=AzdkrvUt92uSctgQfpoB5nurH9WwMS2dRTcZVT+K7OkSSwiao6z/YilDTuHJPgvBYdmpTNgWXiHUaxm3tlEeRVfCsQREBnZvCoHNWfrXoFGq70j3JzZ4i8B+IOmT3dZbsaoMD4BmehZWTsnFjn4WpYrC2yfwebBafPLW8KWJKlIYEu2j4+T2D98rAtvhFeCYod/fc/SmGCHdpQOmmM9JkanryJMjXykh3xLob3yAI9rIAagrp2NtkSXQd1yMBRHcMUEAcM412Y+qk9rbFp3Kp1Eu35Y3przUJ+61tpa1llEkyqOoZasc14ii5MKVfzKV4/u+WxEobh0FN0STW6Q3qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=akQIpc+pcGoR44L4zVN4vbvumJooUlhCV2CPJgRI9B4=; b=ytWVk8E/UaXLFVazlnayDyPKadVUFVE+LU+AEwNisY9y+BZtDssB8YcTjuez+DmWFlRP7I3dch/aEdjnHQbwxmBxGDWzkOABx7VRmoU/047oe9NW/tmPgi0TBk8Skpn8OeqnktN7Vzl74fIkUgSPHNvgoR7S1bI/8lSMLuLN4zhL9lX3KrXaZgUlDW2wR7a3ZTEeYD5oZERK0syBS8JuM+LYJRo9wCCJdsRIQ3jqTvkXO2TxnA4VGb9gMK3jG1PE6eCzXMqxa4j9NObXgIHeDr7hYv9JTni5YKv35hMGInp1pYf7IHv+sDY/tcxoaRFP/v/EEFgOV6ibqQCiy2Pm2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <58615dc6-0d89-bbcf-acce-73a5cd943cc4@suse.com> Date: Tue, 28 Feb 2023 14:30:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/4] xen: change to Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , xen-devel@lists.xenproject.org References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7947:EE_ X-MS-Office365-Filtering-Correlation-Id: 542765d7-2142-4c88-7433-08db198fef54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kIm8vjlF/rKQe/gMQZtBxbfGQNXLdE9NLLHieK74/fJeGD3LjdB/u4s2bvbR4+5tJXJlORnsoOsyQzxYKd34yMLZpOqEOfvT7mCI3GOHD0wS4rWfyU6wVj7hFHbmMb/ebTE5NxXuxoY8yTgKiqKDaqOZK0LAqwwyKr//74tvPqBgrZXs+4vxe0hCnwo3T+MLoy4v57aIt4eR6FYvPgvLYAL9Ty+HvU6I5xm9ESIR1lWbFNxa0QgV5Bqm6ZfCn2Kf/3tzkG1Z9l2vSvWu8G/5V1wev+nptXZyiZaOi/92S8ZJu/DdmfRIAV6GVbl1rJTB++/cyyhDaaT5mXW0J5ZGcnLPahOuP+DXKrTUKKaxKhs/DBtbx9N96hg72yOAI6iVBXn1umpGc3SNz11fFqbMhb91QcFlWOF5TRLm2k3F6cyPtLU2HeDMk3FWQWnf2cxW8UVy6pgvnl5F6aRbidl/zSQ6mN7WuetkPKYyPEpQEkCB1QZIZAN6XBma9aiaEe8sD/LNzmw7UJQFkhV2nGv9fN0RgCmSSozObOSY197q35C/OlPz+HwIxwzDVSqsEupeFCA42XU3JAmAKlb8IwTw8EVTh4cadWwZ8GfRmSMUqYzqQUpKQAJq4Au2Xh5ZxKtbgC7NoJXEfj89u8UuRd74j/1S+qqnEVYJFmsSdYmlbMrKD7LHqF12eoNq5IyMNprz7taddZDDspYhteVDGmoP6ySlI/7KqMXc1BUc6+tippQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(136003)(39860400002)(346002)(396003)(451199018)(31686004)(316002)(54906003)(36756003)(4326008)(6916009)(38100700002)(8676002)(6512007)(2616005)(478600001)(6506007)(6486002)(186003)(31696002)(66556008)(7416002)(66946007)(66476007)(4744005)(5660300002)(53546011)(86362001)(2906002)(26005)(8936002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzZRc0dIMlZYVTFRTGUvajNDeVpYd1g1b1hQUFBpelF3L1o2cktCZVJlVHlh?= =?utf-8?B?ZlR0dDRjYkxROG15TEtIWW84REVzOVRydUN2MzFRQ2prb1NJbWk5T0huVTZ5?= =?utf-8?B?elg4UFFOdGprYU16RS9ESVZMNjRQSG1qVkRyMEdqdGV6YllweW5PVkZnK1FB?= =?utf-8?B?NjNpbTczemtleU1iSGRYaklXeHYxbU1tQm5Cc3lPWkIrMVplMWR2eWw2UWs4?= =?utf-8?B?YytVL2Q5RkUvWWNWUCtJUER4REgrbEhOZkhEUFN2eHpuY1BTVUFlSFFBSmFK?= =?utf-8?B?eHFFa3ZEZDJPL2lCWUsxdVBOdGs3VUtVT3B3STlGYW40aHIwQXBPWXlyTmt6?= =?utf-8?B?NEJ1Q0FtTHBQNE13MGlXTmFpdFh6RzIySVFHTGV1S2xMQUN0bWRpcUoyL0pP?= =?utf-8?B?VzJ4djJhdTYxR0VBUDVSeDJZZGpEQkxzWlVuOThiZTVxZ2tlVjB4QWlXYTRZ?= =?utf-8?B?RXRZRUZvRnFFWlBCUVp3L2RLbE9OQWw0RDk4czlBVk1mUStWazdyQS9FWmpk?= =?utf-8?B?dzNqOVBYSnlwMEo0MGF0ZnV4MEZWSVhpMWlzZStBK1plZThpZlR3WXgzOEM5?= =?utf-8?B?SEVVUDg5UVNXaC9PZUJ4enV4ME9BaExpZTEwbUNGbWRSQVpod2tvS3Mrb1Rt?= =?utf-8?B?NW1Bbm01N3J6MExwVisrZXhkS2NxSUJpd3dEV1FPaDE4eFNvL20zTGNJMVJY?= =?utf-8?B?Y1NvRzNiR1Bkb0dNVjFybFErSDh6R1lJaDJJTjVuS29wWG1GamhBSHRScFJh?= =?utf-8?B?dk5HRkNTQ1JJQTdPdnczNHVtdHFGUC93b0RHbVpVZGRTSWRJdlgwbnNLdStP?= =?utf-8?B?OUE5OE5wbVQ0aElmaG53R2Y0TGtabU10c0Z0UFVuMjh4b3k3a1dwOENadm1x?= =?utf-8?B?dXUrMis3VDZjZ1RWYkpabXFmVWMwOXN6ZVI5c295TDJ6dU02ODZYaUpGSVVl?= =?utf-8?B?b3gxSXZINjJTRWEybW1zcUhaUmsvZTlWSXJnaXdlRDdPNnhGaFFKS000NDhX?= =?utf-8?B?U0VjU3R0c05wQWpUbUVOci9ERG5PcjJtTFFyRFpTV3doaEczNlArTXFCcDQ4?= =?utf-8?B?cmNKR2FDNDk0OUt4Vlp5cmRrdE5NUnRzdFR0a3RNNnhUU1FZempGbnRuVXNZ?= =?utf-8?B?aHlUcE11VkJnM2g2WmExamVDdnVCazNwWStQNEdmUjlHRU5hRGxoSVNUZ2Za?= =?utf-8?B?WGVDLzdiNHY0bld2ZHdMQVBRRTFLNGRNandsSXJ3MmExYVJLK2ZRdUVOODF4?= =?utf-8?B?SFpMTTU1NnFKbU1vOXZlR0FzY3IzczZUTyt6RDAvYnlONGREeTlNU2xjTzJQ?= =?utf-8?B?WkRPeXdUSUlYdE1XZzNoUUl2S0U0SGdGTWdGS1lkLzNIdXlTdUNCYUIwSXpF?= =?utf-8?B?bGNxWFUvN25yekU5bDdsQzl0YUFzM3RYSnlqRE9uN2hnZStaelcrYkc5Tyt2?= =?utf-8?B?OVNHL0UrT0IzeG0vby81Mk5sVXc3VDZQZDN5M1ZDZXdXR3Fja3JWeklUVWpH?= =?utf-8?B?eU1DV0xRdnJRM045aUYzRStqRFAyTkQyRGwzYVJHMnZlKzJMOXZ3UHNydlVx?= =?utf-8?B?YmhYeHpKSWs5OWVBZW9YZWZ1RWFkRXZGaUpNb2l1dGpHQlhKMnNzZy9ta1pG?= =?utf-8?B?c3hhUW9DanR2Sk55RmoyNFBScm1QN0orbU15U1lZUUk5Y28zbnV1WHlRQnBJ?= =?utf-8?B?Y3I2akZBN2dLcE9va3NDdU5EZzdrWFcrU09LWWZCeXNWUDZZZ09PRDB6dDF0?= =?utf-8?B?VkJhNkFtaDBSaVJPNjl1RnR0ZlFJZVd3N0xKR1JreXNOdUhVNCttdkJPWXNl?= =?utf-8?B?NVBVaXUrMUg3cjFCNmN6TzlkOXNvYStPYWxXVEkvam41REw3ZVJBcmZZSmpw?= =?utf-8?B?TFJNTFRsQk1CcHpjbFBLVWY1RjJPZEZsWlcxSzJISUF5UHJmdjVodExUU2ha?= =?utf-8?B?QWZ5Uldra0NoRkNFazZBY1BaNU9uRFJJeDRyeTV2Z2pKZk9ieDZVOTE5UE1U?= =?utf-8?B?MXMrKzMrYlNtZ3dEaVhTbzh1UDAxOGwwNXNkem00UTE3YStvSElxaFpTbW9z?= =?utf-8?B?aWVSNjlBTmhXZkRjY2ZXdGxIVHRTM2FSZkg2eFhWUnJIekI0eHhEK2V6UldV?= =?utf-8?Q?7uyCOr0jGpbbIoGOQ1EUJi+vQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 542765d7-2142-4c88-7433-08db198fef54 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 13:30:19.0926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8k2zo14fJlxfXUgEF98GaMFasmABoLhOmirmMlbVKGR8dBuE5C5AB0AOQwhl76PObjlDe0B5Wk5h2Q+Jxi6RCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7947 On 28.02.2023 14:07, Oleksii wrote: > On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: >> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,8 @@ >>>   #ifndef __ARM_BUG_H__ >>>   #define __ARM_BUG_H__ >>>   >>> +#include >> >> You are not adding new code in bug.h, so can you explain why this is >> now >> necessary? > I am not adding new code but inside 'struct bug_frame' there are > uint16_t and uint32_t which are defined in . > > And after was changed to it started to complain > on these types. Wouldn't xen/bug.h want to include xen/types.h anyway, and then clearly before including asm/bug.h? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 13:55:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 13:55:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503379.775628 (Exim 4.92) (envelope-from ) id 1pX0RM-0001jS-63; Tue, 28 Feb 2023 13:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503379.775628; Tue, 28 Feb 2023 13:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0RM-0001jL-3N; Tue, 28 Feb 2023 13:54:48 +0000 Received: by outflank-mailman (input) for mailman id 503379; Tue, 28 Feb 2023 13:54:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0RL-0001iw-AQ for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 13:54:47 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20621.outbound.protection.outlook.com [2a01:111:f400:fe1a::621]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74b054cd-b76f-11ed-a550-8520e6686977; Tue, 28 Feb 2023 14:54:45 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7245.eurprd04.prod.outlook.com (2603:10a6:800:1b1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 13:54:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 13:54:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74b054cd-b76f-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNLIEmuF1R4GPCQ6EQ5M1sy7wuc+dziS9H/OCSExMpRrYsRNe+JB4ck0uvSTOxvfeQmsCbAAkeju9Xj7VbfmrFYLuwC7DPmCGByHdHOMGVraB24K21Ji5COXfLIo0H9bV63bTkCw0M0JV2tESSYU/5stMJw8ophy4CK1cP3SzHtBIdjYQDUSLRU/r9gEqqmHsJodHkbIRgm+B0j3lyH2QeqQg7jHxIamD/ZnIgWZwhjCf56RmhHj3fAzivIOglendSfNLft8QhMMDPKxwMj/x+lTeHTMB9VO1QP0YmIHWuF4jNYlyEtrBnBHMBZU/3kp2uO8/RdHi9jQ7wBK4fZ6fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gykwv65k3Yffqhsud5qsfwAdbPu/bgdZv7XtGsphVcU=; b=eFHvYIsV97569V/a1ao0N4uutu04iy2mRzi0IMlV0vH0Af0IppHjuG1lp7UZ2FvSQinzHWgHVNisbsnfObJhp2rLADKiY7MJV972TMBXyqYW8MRJ0ngo9Qw8SRHMz7E4dknr/H4tlqgQX4FC/pHL9FpeqTw4nixQLORj3wRUJYqcDJ3dn93BmdEDoBRrAIeuzXF7vAyPL/j4J1wOdl/mvQqWUH+2RtxPH8SaqwCUnZTTrmq8kLEWgngZYgO7mJ6WodYPDf1lgKGLuNXDKMm9Jhca/HPEwSeKg/Mk6qYUt9p4JKkC1WhOECbiFH+W4dV5Ju5Ud0Z/y/3fG6gKkPu72Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gykwv65k3Yffqhsud5qsfwAdbPu/bgdZv7XtGsphVcU=; b=EFP+h+5nfsMt74FxUgYnPzeVZp/4F+X9qRJ0PUZiWRwnMccBRLX+D+zxVHdtZ4/M+JGeYT1LckbJogz8r5ZdXcXiYe5uQkP4C5wjfTwZ00L0iuNZDkRwso6claFRwzXW2IuwpZrSL3tCApYZPPr2DBr0CEt0CiGysav/priLUV/oKJM/NVKNVGssM3AXsZjMa5Bm1d0d0oixH7VQ6BEnnjtGktqbZfRh7SLZMcPU83RHe5pt5WIPkRAdBArwmjkuoYG3Zhw7kfMDZw96qOe1qksiTEXyIlh4kvNkzqDcLX453q0W9+VvnulaDxcfg7Yxab7NTdLphKK7Krg5QSpqlw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <75987896-01d8-b706-4405-0b248498ec34@suse.com> Date: Tue, 28 Feb 2023 14:54:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/4] x86/vpmu: rename {svm,vmx}_vpmu_initialise to {amd,core2}_vpmu_initialise Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230227075652.3782973-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7245:EE_ X-MS-Office365-Filtering-Correlation-Id: a98a3a25-1a25-4cac-613a-08db199356ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KTY5qSHeuApbxrlgrscu+fhtITouID3+emQdbw0dPX/yakFoOf9VmzYgGxun91MHeXKsJ94opNA30zSPBnqMMiYH3qSWWi2EDxLIXOgtx4F05IrM7+O/3+ZYZd9ZjtnkFbxuo2VEiQhE/pjxmooMlPyO5eLV/FopplBmSOGbeQMswP4/N5raKibAaUaue2+tzMS5UyJraVkXIrmlph+Za85h4s1i2ttSSxLIoWpC6UUhQ0Hf1qFGUidXEmnrqh+D1u75lnLGpZk1qrDUE2lEZk5lbJCyGF+w4F17vJr1JoZCXdspoq83qy2V4bvTxlmyBo4YmlIoVpKH/DkJqc8Dq2RM2fgrzrmWjkidoIUUHosniT0qF3wLHZKOHWR4l9LDgje+wlZJRdi3A6/W5Mo5hHFKtM5+tqk/T8MRvNs5j3ny7JW8IRFsEByHQl8IuGz+ELSbGBNlGGTNRDJVsrhD8nS8/jRn0TVlkq5LkF2tYQ5eyF1sEaJPPD2u/pOhdn4qgklDyLKhCCp3hvMmZFo0K/3wjLYKykO4OEU+rWQsrqbkdxSYerr7d/73wBbnXBLrQoPkVCDt3yD1h8Z0IQi/zhKx3xlObcG9UFadXcjVyyFmuPL5IqjSCSt7bcpfQAmdmlIGzqtUJ9m9YWWQm6D1TLLVi8eYVY/9Bu3yEDhd1M7xaoY/x9DZ93K+dP7bpouREvK56O24Sbv36cZRbyONok3MOQdjqvj6HdPE8NUiW1o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199018)(54906003)(86362001)(4744005)(6486002)(316002)(31686004)(478600001)(31696002)(53546011)(2906002)(186003)(41300700001)(6506007)(26005)(8936002)(83380400001)(5660300002)(66476007)(2616005)(6512007)(36756003)(38100700002)(8676002)(66946007)(66556008)(6916009)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MW9BWHltcDB6KzE2WHhidHhBZFB0bGJ5ZkJzSnlKb2FhOGtjOWJxWnQ1QU42?= =?utf-8?B?UWhaVk5oaGhaS1BJNHpXeFJBemlzOEJ2Nk8zNGtYOTgwZ09kcW95M3JCUjV3?= =?utf-8?B?aUg1TE1sSDdmRHJSL1FBaXdJcnA0TkR1TGhlT3lrTlM1cHUxZzN6RE5BbkJa?= =?utf-8?B?bnNYUXBrNWZOWVllMUxGcVd3QnJPMjZhdnJQZ3NTbTU4L3FxTHlWNkhUZFVB?= =?utf-8?B?MkM1YTNxaElTOHNkNEg2dW9PVkVVaGtpQUhjK1lWcVk2ZUdWQkRzWEhXd2l3?= =?utf-8?B?cGlnbXpMV2pvWDJva1NUM3hvcm04bFZWYm4ycHFKWm50Z2xzMFBReU5NVWd4?= =?utf-8?B?SkhQbjBjdXQ5YVFtbmp6LzdZUXpWcEFVci9sZC9hb240Y0RmT2MxQ0lKL0xh?= =?utf-8?B?VWw1aHlMNzZpbUpUUlZ6cVhnV2RBRjAySFFsV00zMUx6Sk94emZCSDhkNEJT?= =?utf-8?B?d2VLWVhmNVMzTENkbzlFTlRuMnphNjhPNXNFb2VLcit1UEFTN29yR0hpeXh5?= =?utf-8?B?eWplN2FPK2s2anVSVlZ0OFVveU5GdUNXdUkyMWtSZXBXeUhJZnM3dTIwVUFK?= =?utf-8?B?NTBveHkxU3p0R054bDFaSDJOZld4TXg1TVJiWCttbGZuZURFNEdYMU9venFB?= =?utf-8?B?Z2JqRXJvOWF5Wkxaelp6OG5qSHJ2YXNadldWSHU5NzNNVE9PQW8yaFFxM0Fx?= =?utf-8?B?SUJzSTZnamNUUkRFTEJvOTZ0ZTJhT1J5Zys1cmQ5V0xKVmZBcEVJMUpGMzFi?= =?utf-8?B?dWJZdnBUTktpcEhuOGpvUGxqSFhzbGVZeHd2RWMxQllUellab0w2TGJEeDdn?= =?utf-8?B?bmhzRDltTnFaNUl6RVlRVkQvYk05aFREVGZBMWxvT0hwVUtGWjV3aG5CQ0o5?= =?utf-8?B?L0xyV3gwV0NXcVJJUnFQeTJiczVuTlZ1aVhqbWJvV0dVK05NS09OSkhrdVI2?= =?utf-8?B?ZzBtcGJadkx2TVRpbEYxOGgyUUtJT080K2lmYlJjQWgzaTNYRzIwM3p0Rk45?= =?utf-8?B?dGpqTHh2aDhNQlJWVTBIbFkvcjFlSVQzU04xN2dJMzIvRGpxaGxqS2psUlRF?= =?utf-8?B?L0MycjR5V24vV3doOGNqZjZIbTEyOTFhVHR4M1RvZ2dUalgrSGc4eU1ZSUg3?= =?utf-8?B?Nk5QS09iUGtqbjRVcEFNZ09XU0s2d3FnUEp2UmRUNUQ5N05sM1N1bWNUZkND?= =?utf-8?B?OFhDTFQrSnN3c0wrd2c5OCtGQTAxS1FjUnBzQ1RZVGcwdVZpKzdvOC9NOXRo?= =?utf-8?B?OFRxMEtpUjRmU01BT0FhK2QxbkxyWE9OOVg5T2lZTDNKeXNVM0NEUDJFOVVE?= =?utf-8?B?d2RzK0FXQldFc2JDcWlTekVkZlBzK0RzOHNHL1N3cVprTTNOeWF6Q2V5Z3ow?= =?utf-8?B?ZlYwc0M5alNscDFIUW9ISFdzYW12VFJqK3NuSm5aTmJrd3Jmd2ZheUV5dFA1?= =?utf-8?B?S0RmU3B6RkRsdDYvaGp5Tjh0MWI2K2FkTG1QRURXcVVHMVRaeWJMZlhKa1pQ?= =?utf-8?B?ZndJMnFDOXREZmZmSHRFdm11dStwTXd5a3UxbVN1ajBzWWhmT0N1MVlzVndz?= =?utf-8?B?U2Q3MDhldEwrcjF6U3ZzQTY5cURQa2FPZTlqNEN1VGU5YVRlczVrZjh4ejRL?= =?utf-8?B?TzBmdVZKa0NCTEFlQVMveXdMODVzVDgvOGpQZFl4NG04QitmbFVDTXJJWGQ0?= =?utf-8?B?dy9kd1NVT2pGQnZ1NFhiOFRNRlpVK2x4KzFzUkh6aVNYNkJQRXZucGE2YTN2?= =?utf-8?B?TTlSM1k3YzRacXFlcUtmMmJMK0tKVmVBNmJiOTlhZStrYWJyRlhZRlF2LzBO?= =?utf-8?B?UkFZc3R5WndSU1A2WG9PNS9jL2FzZ1hMeGN0MnhGRkRnYVBjNjB3MExVdjF4?= =?utf-8?B?Ym9YR2NNOU1xMzJnVjQ5OUZJNjRjT1FlMDgzc3RaVE16bTlSRDVacmUrRm9M?= =?utf-8?B?bktvamY1bHNxYjdTTkdzTjMrVHNhL0QwYTRjdnEvZnJKbnE3UjBOVHlaZ3hB?= =?utf-8?B?NXlKM21HV2RWSXB3MkxBUm1TYmZJMzZpYzBTNjQwM29tcnlIRWVabDhLakRP?= =?utf-8?B?bTV6aUlwdTRpcE1XODZXZW43VStWVGJXdi8zek15TGN6dWRHdURWZUJUOEMz?= =?utf-8?Q?vpTv9q5Bm8C0loZp2zcJVeB9E?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a98a3a25-1a25-4cac-613a-08db199356ed X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 13:54:41.4216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9byzr0MHXk8jGqxid9nE2uSnjTJZeUaWv/GfHTDiESwwmt4c2KKoeNRkTxnxZOr3K5VUR0eqPbES1xd29aKDiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7245 On 27.02.2023 08:56, Xenia Ragiadakou wrote: > PMU virtualization is not dependent on the hardware virtualization support. > Rename {svm,vmx}_vpmu_initialise to {amd,core2}_vpmu_initialise because > the {svm,vmx} prefix is misleading. > > Take the opportunity to remove the also misleading comment stating that > vpmu is specific to hvm guests, and correct the filename. > > No functional change intended. > > Signed-off-by: Xenia Ragiadakou Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:05:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503384.775637 (Exim 4.92) (envelope-from ) id 1pX0bC-0003gY-2y; Tue, 28 Feb 2023 14:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503384.775637; Tue, 28 Feb 2023 14:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0bC-0003gR-09; Tue, 28 Feb 2023 14:04:58 +0000 Received: by outflank-mailman (input) for mailman id 503384; Tue, 28 Feb 2023 14:04:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0bA-0003gL-Ji for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:04:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0b9-0002MQ-4E; Tue, 28 Feb 2023 14:04:55 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[192.168.12.216]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pX0b8-0006sm-U3; Tue, 28 Feb 2023 14:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9bdTtz8ajUjFXClJC1OngUeqd7zfvR7ia3k1e8SbcWE=; b=vo9ABfVyqM7FAv+xJqB6j/9OWd ufS3DiXBSkdFS7RGdvVLvsic27S6p5u8YZGKRwO9qczvISyiXQWuc04qvF8pw/VKn+xQqlaO0w1Ff t2jBx+gov2ZI3tbB6UIdUcGavvyjxuhRyoHFPGIdv4ckj+o9GZhstO/dMVGp2CmJmG5I=; Message-ID: Date: Tue, 28 Feb 2023 14:04:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/4] xen: change to Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> <319ddd67bca2291afe7f27cba3cf8eb4e1307747.camel@gmail.com> From: Julien Grall In-Reply-To: <319ddd67bca2291afe7f27cba3cf8eb4e1307747.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/02/2023 12:38, Oleksii wrote: > Hi Julien, Hi, > On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: >> Hi Oleksii, >> >> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>> Since the generic version of bug.h stuff was introduced use >>> >>> instead of unnecessary >>> >>> Signed-off-by: Oleksii Kurochko >>> --- >>> Changes in V3: >>>   * Update patch 2 not to break compilation: move some parts from >>> patches 3 and 4 >>>     to patch 2: >>>     * move some generic parts from to >>>     * add define BUG_FRAME_STRUCT in ARM's >>> --- >>> Changes in V2: >>>   * Put [PATCH v1 4/4] xen: change to as >>> second patch, >>>     update the patch to change all to among >>> the whole project >>>     to not break build. >>>   * Update the commit message. >>> --- >>>   xen/arch/arm/include/asm/bug.h       | 19 +++---------------- >>>   xen/arch/arm/include/asm/div64.h     |  2 +- >>>   xen/arch/arm/vgic/vgic-v2.c          |  2 +- >>>   xen/arch/arm/vgic/vgic.c             |  2 +- >>>   xen/arch/x86/acpi/cpufreq/cpufreq.c  |  2 +- >>>   xen/arch/x86/include/asm/asm_defns.h |  2 +- >>>   xen/arch/x86/include/asm/bug.h       | 19 ++----------------- >>>   xen/drivers/cpufreq/cpufreq.c        |  2 +- >>>   xen/include/xen/lib.h                |  2 +- >>>   9 files changed, 12 insertions(+), 40 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/bug.h >>> b/xen/arch/arm/include/asm/bug.h >>> index f4088d0913..cacaf014ab 100644 >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,8 @@ >>>   #ifndef __ARM_BUG_H__ >>>   #define __ARM_BUG_H__ >>> >>> +#include >> >> You are not adding new code in bug.h, so can you explain why this is >> now >> necessary? >> >>> + >>>   #if defined(CONFIG_ARM_32) >>>   # include >>>   #elif defined(CONFIG_ARM_64) >>> @@ -9,9 +11,7 @@ >>>   # error "unknown ARM variant" >>>   #endif >>> >>> -#define BUG_DISP_WIDTH    24 >>> -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH) >>> -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH) >> >> Even if the values are the same as the one you defined in the common >> bug.h, it doesn't feel right to remove them as long as... >> >>> +#define BUG_FRAME_STRUCT >> >> the arch is defining BUG_FRAME_STRUCT. So I would say the generic one >> should be defined within BUG_FRAME_STRUCT. >> > One of the reason BUG_DISP_WIDTH, BUG_LINE_* were removed is that they > don't use in ARM at all... Hmmm ok. But this sort of things should have been documented in the commit message even thought it doesn't feel this is related to what the patch is doing. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503389.775648 (Exim 4.92) (envelope-from ) id 1pX0nc-0005cP-60; Tue, 28 Feb 2023 14:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503389.775648; Tue, 28 Feb 2023 14:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0nc-0005cI-3L; Tue, 28 Feb 2023 14:17:48 +0000 Received: by outflank-mailman (input) for mailman id 503389; Tue, 28 Feb 2023 14:17:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0na-0005bu-Pd for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:17:46 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ab1acedc-b772-11ed-a550-8520e6686977; Tue, 28 Feb 2023 15:17:44 +0100 (CET) Received: by mail-wr1-x42d.google.com with SMTP id e37so7444513wri.10 for ; Tue, 28 Feb 2023 06:17:44 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab1acedc-b772-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lh7KWnQCnU0Xy11ERAph7q0T0htYbN4VPL78n+lioss=; b=XINu/uhsOJAR39CS67rUqmJs/rhFSfkCX8HqvT63CTx6mHONjE9le76h8tDNBoE8XP QfWKinWYzqxkHUe8jjDTBx+ER48Z+9RH4TEIbG3bpR1omN+vgaCMR5fDLfpFIcuDgBme +Ub9xwPgmZVhYJxCdwDLde5/4rl5y2SAA9f1ueHxLFp4NPNvsa+I9V15fT+vO/rBE/K5 sUlXjuqCPy8vPRqKRKp9AJxqvr3iKHiIkdKYXKnkfKHs899uG6BagQa3cjLQSkxhv7TQ zY59pg8/s7WXBlq4OFoyQyLkxiiILhlOG1LyBLXd9XvkY/FhHGILTB94brBSupekT6vw 3gAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lh7KWnQCnU0Xy11ERAph7q0T0htYbN4VPL78n+lioss=; b=TpPFLBvsmdCVqyxTk+w+VRaNXUrKUsX07TDTYB3apehTLaMaThq/Qj5hkjCJCJtIwZ wPAvx063pfm/Ctau7npmgqQJ65l6InLVNthWSxx3igIlGdGdGiL8tF08nF/UXNAW3CDz kYsn8oPNs/86ghRGqAHdWJ+7jljAGjidIUH+bztBh0ARZA/psVUvJ3K8eAL/Vn56AXqU O6GGJGwaw2IHvn8rOusAOO6qnWnBVZrEIysRgez4y3PTfZHl+Nk0gHsZNPmLZ/pbb1GQ gLC81veJ2CIJU9hlZ++RtKHAwL46IwcFiNAgXiLA2zfI6xY2NuFX0CxYFWlblbxT22Mk ml7Q== X-Gm-Message-State: AO0yUKX7aS9X3pa2oG0RkDEOFO62v7UImOPs+4kwzvfVLfFkFiY8vGFF mk5hDsaS+pU2UC2VXdRJveEkFUJLDcXhh+rzSzk/3g== X-Google-Smtp-Source: AK7set9ALWNnTzuE5yynXOxHXNX7V1XLJWiXHtwYThD2yDLqXza4mUi6fIfw5+bRR+gu6z25mV7pZMUVLrZVnIoNlFI= X-Received: by 2002:a5d:63c6:0:b0:2c9:bd6e:83c0 with SMTP id c6-20020a5d63c6000000b002c9bd6e83c0mr534828wrw.3.1677593863893; Tue, 28 Feb 2023 06:17:43 -0800 (PST) MIME-Version: 1.0 References: <6c0ef5d2174bfa8c25aeb94395160ab9d863b63a.1677079672.git.jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Tue, 28 Feb 2023 15:17:33 +0100 Message-ID: Subject: Re: [XEN PATCH v7 08/20] xen/arm: ffa: note dependency on 4k pages To: Bertrand Marquis Cc: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Content-Type: text/plain; charset="UTF-8" Hi Bertrand, On Fri, Feb 24, 2023 at 4:27 PM Bertrand Marquis wrote: > > HI Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds a BUILD_BUG_ON() to assert the dependency on 4k pages in the FF-A > > mediator. > > > > Signed-off-by: Jens Wiklander > > NIT: I would s/note/enforce/ in the title: > xen/arm: ffa: enforce 4k pages OK, I'll fix it. Thanks, Jens > > Reviewed-by: Bertrand Marquis > > Cheers > Bertrand > > > --- > > xen/arch/arm/tee/ffa.c | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > > index d04bac9cc47f..8b0b80ce1ff5 100644 > > --- a/xen/arch/arm/tee/ffa.c > > +++ b/xen/arch/arm/tee/ffa.c > > @@ -56,6 +56,16 @@ > > #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \ > > FFA_MY_VERSION_MINOR) > > > > +/* > > + * The FF-A specification explicitly works with 4K pages as a measure of > > + * memory size, for example, FFA_RXTX_MAP takes one parameter "RX/TX page > > + * count" which is the number of contiguous 4K pages allocated. Xen may use > > + * a different page size depending on the configuration to avoid confusion > > + * with PAGE_SIZE use a special define when it's a page size as in the FF-A > > + * specification. > > + */ > > +#define FFA_PAGE_SIZE SZ_4K > > + > > /* Framework direct request/response */ > > #define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > > #define FFA_MSG_TYPE_MASK 0xFFU; > > @@ -242,6 +252,17 @@ static bool ffa_probe(void) > > unsigned int major_vers; > > unsigned int minor_vers; > > > > + /* > > + * FF-A often works in units of 4K pages and currently it's assumed > > + * that we can map memory using that granularity. See also the comment > > + * above the FFA_PAGE_SIZE define. > > + * > > + * It is possible to support a PAGE_SIZE larger than 4K in Xen, but > > + * until that is fully handled in this code make sure that we only use > > + * 4K page sizes. > > + */ > > + BUILD_BUG_ON(PAGE_SIZE != FFA_PAGE_SIZE); > > + > > /* > > * psci_init_smccc() updates this value with what's reported by EL-3 > > * or secure world. > > -- > > 2.34.1 > > > From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503394.775657 (Exim 4.92) (envelope-from ) id 1pX0od-0006Cs-KZ; Tue, 28 Feb 2023 14:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503394.775657; Tue, 28 Feb 2023 14:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0od-0006Cl-Hr; Tue, 28 Feb 2023 14:18:51 +0000 Received: by outflank-mailman (input) for mailman id 503394; Tue, 28 Feb 2023 14:18:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0oc-0006Cb-Ch for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:18:50 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d12818b2-b772-11ed-a550-8520e6686977; Tue, 28 Feb 2023 15:18:48 +0100 (CET) Received: by mail-wm1-x32a.google.com with SMTP id l7-20020a05600c4f0700b003e79fa98ce1so5974308wmq.2 for ; Tue, 28 Feb 2023 06:18:48 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d12818b2-b772-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s+ekqBER0OZIQJK/rifnO8+K5Gv3JnO/QqzguiwJQR8=; b=vCc3ypjBwpKyt+odXIrAHGY9Z74C63Ld7q+XZDT9Ye1gpK73glFZcBRKhYIV2QGWsB y1kMqdY87+Sgin3paMBWp/5/wGZ8lDpiEV18kBMIIKN3oTxjCYHhI4lczWDfeKGfQ2hx vz5G1DwMHVkVvTmVaRo8IflAtPu6WGdlZhm2NalGnFrjRp9UAbZt9Qsa39MwdELWsv9q pMWHIK7nNH5RgxXqR7asvpqLKwqZk4zT+svy3fjxFyb2H4xdcxoEhRswBhPsHR1AB2px pJegrBUzZQkQfe6vCHwkprDX7B4MzPtTep6NUjYCetFcUAX4TqgHTuGl6fKo0Vo8yXlu Ft0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s+ekqBER0OZIQJK/rifnO8+K5Gv3JnO/QqzguiwJQR8=; b=NFpWO1vN8OXLEDgmeyo/mEw0fj6DjVfZno+q+GpgSZkAjh/BI4w66ri9qZzTrEFyG7 SVddMN0uNSZVurgoioQQFWIbS1QhZPI2UnFs9359giayFJ+MX4awvctM0hVrwyOb+NeL cZwkpE1GIOE8Hp+iuJMayDVjw543dStGFQvaYdtFH0Y87lVqmxP9XV2aYqmdNPuv8z8g RNSJ6P3zkZLpUcfP7m/yLX8ln0FBL1gzTGYAixsuR2qbgiAn1PsgDmZll2+WZrT0bEFM hgX+XEL9oVO8OLSSgxG6lzTXN13mpiBNTEOqOrM22hCn6Q0hfK3NV4ZOJLbRXW+wQyPp wyaw== X-Gm-Message-State: AO0yUKU9PMxbOSoCuPKn8NZS2/fuZeB5k0tV+UlzSfeeEYx+Q8dP9ng6 w1ABbVq7X14eLauHUNywT9genWpr5oIOcRXJUxUzoQ== X-Google-Smtp-Source: AK7set8XMJT5Qvonbc4oLViypw+cMqo6N4makMAu0K8a07GWP3VC4dr+60EcI7v3OyV1Apg8vuoMseAzr/2L50IbTYw= X-Received: by 2002:a05:600c:4f4d:b0:3df:97a1:75e2 with SMTP id m13-20020a05600c4f4d00b003df97a175e2mr823357wmq.4.1677593927792; Tue, 28 Feb 2023 06:18:47 -0800 (PST) MIME-Version: 1.0 References: <82e4e0c3ac1614822fddd90336c22e6fad5b485e.1677079672.git.jens.wiklander@linaro.org> <42827e14-8daa-66ed-328a-92940dc98a95@xen.org> In-Reply-To: <42827e14-8daa-66ed-328a-92940dc98a95@xen.org> From: Jens Wiklander Date: Tue, 28 Feb 2023 15:18:37 +0100 Message-ID: Subject: Re: [XEN PATCH v7 09/20] xen/arm: ffa: add support for FFA_ID_GET To: Julien Grall Cc: Bertrand Marquis , Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Hi, On Mon, Feb 27, 2023 at 4:00 PM Julien Grall wrote: > > Hi, > > On 27/02/2023 14:48, Bertrand Marquis wrote: > >> On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > >> > >> Adds support for the FF-A function FFA_ID_GET to return the ID of the > >> calling client. > >> > >> Signed-off-by: Jens Wiklander > >> --- > >> xen/arch/arm/tee/ffa.c | 21 ++++++++++++++++++++- > >> 1 file changed, 20 insertions(+), 1 deletion(-) > >> > >> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > >> index 8b0b80ce1ff5..463fd7730573 100644 > >> --- a/xen/arch/arm/tee/ffa.c > >> +++ b/xen/arch/arm/tee/ffa.c > >> @@ -167,6 +167,12 @@ static bool ffa_get_version(uint32_t *vers) > >> return true; > >> } > >> > >> +static uint16_t get_vm_id(const struct domain *d) > >> +{ > >> + /* +1 since 0 is reserved for the hypervisor in FF-A */ > >> + return d->domain_id + 1; > >> +} > >> + > >> static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > >> register_t v2, register_t v3, register_t v4, register_t v5, > >> register_t v6, register_t v7) > >> @@ -181,6 +187,12 @@ static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > >> set_user_reg(regs, 7, v7); > >> } > >> > >> +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > >> + uint32_t w3) > >> +{ > >> + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > >> +} > >> + > >> static void handle_version(struct cpu_user_regs *regs) > >> { > >> struct domain *d = current->domain; > >> @@ -210,6 +222,9 @@ static bool ffa_handle_call(struct cpu_user_regs *regs) > >> case FFA_VERSION: > >> handle_version(regs); > >> return true; > >> + case FFA_ID_GET: > >> + set_regs_success(regs, get_vm_id(d), 0); > >> + return true; > >> > >> default: > >> gprintk(XENLOG_ERR, "ffa: unhandled fid 0x%x\n", fid); > >> @@ -221,7 +236,11 @@ static int ffa_domain_init(struct domain *d) > >> { > >> struct ffa_ctx *ctx; > >> > >> - if ( !ffa_version ) > >> + /* > >> + * We can't use that last possible domain ID or get_vm_id() would cause > >> + * an overflow. > >> + */ > >> + if ( !ffa_version || d->domain_id == UINT16_MAX) > >> return -ENODEV; > > > > In reality the overflow could only happen if this is called by the IDLE domain right now. > > Anyway this could change and this is making the code more robust at no real cost. > > > > I would just suggest here to return a different error code like ERANGE for example to > > prevent missing ENODEV with other cases not related to FFA not being available. > > +1. I would also like to suggest to use >= rather than == in case we > decide to support more than 16-bit domid. Makes sense, I'll fix it. Thanks, Jens > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:20:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503399.775668 (Exim 4.92) (envelope-from ) id 1pX0qF-0007yo-Vz; Tue, 28 Feb 2023 14:20:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503399.775668; Tue, 28 Feb 2023 14:20:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0qF-0007yh-St; Tue, 28 Feb 2023 14:20:31 +0000 Received: by outflank-mailman (input) for mailman id 503399; Tue, 28 Feb 2023 14:20:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX0qE-0007xt-Kv for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:20:30 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20619.outbound.protection.outlook.com [2a01:111:f400:7eaf::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0da62a22-b773-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 15:20:30 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by GV1PR04MB9120.eurprd04.prod.outlook.com (2603:10a6:150:27::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 14:20:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 14:20:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0da62a22-b773-11ed-9695-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSC3BSRkap1o151+zZP13BSk+/oZmNjRJk64+KYFPyecMncciDOxyVlnP7tBT2ihtKO/NmKyfZOX8gbCEUTC4GJjC9PdGy8uD6UBD69P3nPHSh8vponZpB8gb4ZKaFWBgH2E9dWT8HA6M0M7bUcMZstS0NTlG973hAjfXjjClYkbW9xkTKf5HXROxE5Mrii7QaJepGYnHU6RCg/zG5PIWIzY7CyNXg9qQ6gg2izp3wc4+N9HLR3w4f3d7Ba1vDG1hiZk6lWm9ybmq9dOA6e6/1E/4fuJ2oN/D1gClBKl04nVT3rKd2gH0DP1jjGL1JmcI4k9RJDMHkcUArbzI/V+gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uVVvDQntc9q315EaDSRyD/80w51FevqWqxKqEXf8RQY=; b=QzGtmjj3Xre/rVVm46QBYcMlkJdhnSfHuUvN9SI0PmX1BkMTchHFOfGFJPqVv0EicLvuZwJmDf80Jed/zL1CSeKTQ/2B2tk/zL2KBosT1tF5UeMvZzyecP1ZJ+rU8RXTbK1LsvKym9LCav1GdQQvuFuboe5PQeWwAK9xjGq4hrVNtgPF2hNmyfM2UWedPmegqyW8jO1ct/e5HCy5BmFs1GTLxJ9KIjIQzHkYbIxWzhk54+RQ+ontqIDNB4E5LOKwR78VelbJ35a48Ex7b0TYmWHRdyr3N8qdbDXfDLW3H4DEIMqYrLGXp4uWnRl/j+JLZpAWx42uZKsTGkMIFAEHOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVVvDQntc9q315EaDSRyD/80w51FevqWqxKqEXf8RQY=; b=a011LjkdeoQNuTpZELEguiet2BXm2WiNJBK3AzbLoPEicU7k3W74mjtmTTzs4LXiNU8Mu98tymmecBg2+4oyn8em+m6uVuVh3evvmTnql0ZvziedtQ+FeyBcgzsN0hnRcJg6he48q2MMmsDOtGgP7SMc9dCtIADHo3j1YXRD0ORL4vOyWumFQc90DChElYWivp65/Bh/lEZpa45xpUH3pV22gk2oXDCT/TQOygwzLyFxLz/HDLPizLwxhPHsly7+tozu0TEI/ZfqndiF4MLw/xj9GCV1ocRQjJz4PRj9bGPPiEpA8w/kM1CLoLrd8Pf+lO8HDv4WIO+Ow+mVCLljhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 15:20:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230227075652.3782973-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|GV1PR04MB9120:EE_ X-MS-Office365-Filtering-Correlation-Id: 3580b1f7-4174-457a-986f-08db1996f099 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 86tobA+56FQgW7FtGfSDMbI5URI71suZizyAvHrjG6ylga4C1TAufPvwhWio0whfzvOyuXWS94XZ7nTG7XRf8hHY/srPm5KNnnC5/5gicnnStiVcI7Jh8FWeeoTBe7Nnf2BCuqdm5A1zw78B7xVH2+HO79tPI5BgSW1MOQQG1PrZQnnol9wkm7AJJ1gqiD31mWF8kVzKTpWlO+3d6ndOjSiy33abCE383XVYZLoeh/eelSiE+jhrBIt8o7F1Lf3jJ7yyAmGmdvsCOs8P7jXIKtlEB5wySLVVRJUE01cZ56ldxQsdSWPpYK8yt883NJ9GNrlvXdyplCwTKcFceWD1qCvbGHZ67ARCR1C1ZsKrYVLxhh6qz95zoFw0TjGaI5zxXZ2cwgl4mqNy/gz4TtPs1Qk96vYyfQfzsg2C/OCkwEGRbFBLFkGyzRy/ueXdrJVoQ4NECTrKgvDgW4sVLKkeCXgUoQunpikKQQzpJ4b5UgjwRzoft0bZ8sjcQH6ny/GYnbG153ryhOqddIQiZNhDIbvpdwmh06pqx428tn8Po/L/OUbQ2PbQKOOmISl81dBnorRNzJoi4bWOUv2SdCkRxcIB5eMJ+yOYjEb62plVIC1Igzpu4JQ8wXt4ytpcX+Nfd65KY5vPTykiAh07oQEw1niKOMUOiWZ+EtQSoOzA9XHoZRuc+KSar1E8nSz6MyjFBY6KQdioWmDVAAYH6vne01op0Vrmmeln+sjqa5Ud1Qo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(136003)(396003)(366004)(376002)(451199018)(6512007)(186003)(26005)(478600001)(6486002)(316002)(66556008)(66946007)(66899018)(4326008)(66476007)(83380400001)(53546011)(6916009)(8676002)(6506007)(54906003)(31686004)(2616005)(41300700001)(8936002)(5660300002)(38100700002)(2906002)(36756003)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHRXRmtCVVlIQmp5dmJwR3duZ2lBZXpId0dJYkxvRk5KUlZCYmxUd1Z2UTFm?= =?utf-8?B?TldIMWhZQ05zMkYxKzlJUUdyZ2REeEJveUp6YlVFQll6WjM1Y0FaK3dGamFl?= =?utf-8?B?RW9ybkx2bzFzNHk1K2ltVFF5M2EyWmJBa2JnalZDZjJwRHR6Z0ZiWEwvd21Q?= =?utf-8?B?OFhDUjFtdTNhYkRxSVhmYVQ0ZzV5ZmhaTFVUTVprWFZ3aWVJNHVpdmZZRWZG?= =?utf-8?B?S01SMUFTdy9WQlJ2eVdQdVNtcU9Qa1JpNlJpK3IxZ0ZjL1B2NE1IZG5od3Bp?= =?utf-8?B?ZWVMOHZ4VWpQWllVY2ZtWVpTN0F2dU14cU53ZlhxdkJjWnhjdmM4dGdJeDlo?= =?utf-8?B?UWZaR3FPM1d1MDJvMWY4ZDg2YTJlOHRZS01HblZOMTluR3pyMmRYTzRCZVhO?= =?utf-8?B?d1N4S2dKa2pmTFJVOVZQWXJrUkxQQ2pMZjF3TnpxVG5OeDFlMm9DUDd3QnRU?= =?utf-8?B?ZFJ4dndoTGJqVkdEMXlLUlBMUVNUTE9pNkoyZ2V6NnV2dGlpWlpGWVZrKzQ4?= =?utf-8?B?a3lxbHdUelJCRGRHM3ZUc0FvWlk5NUU2VVBhV255Rk9SWXhrRFgwVVE5Smgw?= =?utf-8?B?L3dMNDFMdnQxWFJ1TU9DZlVjTUl4Sjczc1RLdkUxMlB1WlJlWkhyblNFWFJT?= =?utf-8?B?dW5aKzUxTlpYMDdidmNKVkNPbUgzemRGc2V5QlJlNjBaMm1UbGdZaForQmFp?= =?utf-8?B?UUVKUEh3d0cvbDloQldmQjNYbTUvOGVkQkZLYVZLUHdUbHF5d3dCSjlxZFpK?= =?utf-8?B?eEVFUkQxOUpjWnZnVGZrbTl5RWR3MDJTbjlvTEdPeXRMRHRuK3BiTVg2SDZZ?= =?utf-8?B?TEJkNUFZSlNWTmZlNTV5WFFJenVXaThkM21odUVSVlZHOVFiaStFelVTcmZw?= =?utf-8?B?SmRUeXFkUWJvbHpZUDdvNnV1MTdoQzMySWxRQ0xpaU4zZ1lDdlRCUjFLMXZU?= =?utf-8?B?S2hpcXNMcU9zalEyZFMwTHBESnEvV0hJN0lmKzRJTlF0Wll5S0NoYis5b0tH?= =?utf-8?B?a2U2WGNxRXN0TUxNYnpwcTdCZE93WS9rQzgxajBqWnJ0YlNac2N6YjRrYURa?= =?utf-8?B?cDZWOTFNWkFPM3hIQ0FJdVhKd2lPZGN4ZnptSy91Rktzb1JLaGpyei9jazMw?= =?utf-8?B?K0w1SUl5S2syMXNGT29XMFBHREc4V0dnNHhQN0xabVhES0hrbnRsMlRXclNJ?= =?utf-8?B?M1A0OEFHSmlJWEJsS0xsSXovemdHbUt3TnlLWHFVc1FkT1FJWGp6djFRbFZm?= =?utf-8?B?aUNXUGJ0am9qaHJ6NTNyajJib1RldTVCdGh1SnY1cjg4MURhWHhCVEZPZlpw?= =?utf-8?B?UW8ra1lycXVJNmNKVlVCVDJJeDF3RjZvSE9OSmw0a0xJN1FNUHRQbUVKaUFW?= =?utf-8?B?Mmk4SldGTFhZM3gzdDdUbHpJcnRCNVRVYWp1Slh0S0VFTEg2NGVESmJjN3Vt?= =?utf-8?B?QWdnckZMSitLaVY2T2x5U1M1TW93L1JUMFBTUVR3eTkxRERxV2JJamttbUF3?= =?utf-8?B?VnVNckZabHEwRnM2d0pvZ0dsa21STUNBSEFEaEZSVkpxQXE5TVRMT05FR01I?= =?utf-8?B?YkFlVzdUanh1YjZsZlUyWkRkV2FpVm1rTnpYcCtpeUQwZHlVMGhxUWtQeU9y?= =?utf-8?B?a3NSYWpRUVdRUm40L2VvM3NOc0FTTHJWMlZVRlBiUlJtaE9McHA4ZWJndjUz?= =?utf-8?B?dEtkYTE1WFlFcDVlaGY0dlZqa1NaQnBVS2F5U1dXQ0I1QVNOUVRhMlUwTmkz?= =?utf-8?B?eEU5SDZRYnhTeGZGRkYxUHZ4bVlIVk1yU3VkOFFtWkl5emE2RTdaWkYrbDQw?= =?utf-8?B?YnMybHhyRFpEYjBGTWZGVXpmTXFwZXdUVFpOejFINVd1YW0xN0tqK1ZnNFlk?= =?utf-8?B?NHp6ZVBHQ0h4dDlVNys1WFB2eXY1RVNSNUlab0pIVWdRODU2RUtuZVNPMW11?= =?utf-8?B?cXJ4REhNQ0lmT2hVNkNJbnhTYWpyQTN4Rmg3SDJoMmtTRUZ6MTZWdElZYkls?= =?utf-8?B?SkdITHNNeElQSjdsYmFaQ2ptTHFaalUvRkI0dmFCL3hJT1V4L1VzQXJsc1Qx?= =?utf-8?B?RkE1UFc5VUNwa0w5NUtjWnM4S2REWnZiYzE5S2VXUlhPNE1PRUFmQk44T2Rs?= =?utf-8?Q?6GkFY+vZCkhmxO3l3DK1hTeya?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3580b1f7-4174-457a-986f-08db1996f099 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 14:20:27.6537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vmHKuGwiIJw60BCx0ESKzLf18HdSaVpXswz48YDWFnjvdarfTvyefup54gBzngB4q4Si4RczbkdObx03LwkCbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9120 On 27.02.2023 08:56, Xenia Ragiadakou wrote: > This change aims to render the control interface of MSR intercepts identical > between SVM and VMX code, so that the control of the MSR intercept in common > code can be done through an hvm_funcs callback. > > Create two new functions: > - svm_set_msr_intercept(), enables interception of read/write accesses to the > corresponding MSR, by setting the corresponding read/write bits in the MSRPM > based on the flags > - svm_clear_msr_intercept(), disables interception of read/write accesses to > the corresponding MSR, by clearing the corresponding read/write bits in the > MSRPM based on the flags In how far is VMX'es present model better than SVM's? They both have pros and cons, depending on the specific use. I'm not asking to do it the other way around (at least not yet), I'd merely like to understand why we're going to gain two new hooks (if I'm not mistaken) when we could also get away with just one. > --- a/xen/arch/x86/cpu/vpmu_amd.c > +++ b/xen/arch/x86/cpu/vpmu_amd.c > @@ -165,8 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) > > for ( i = 0; i < num_counters; i++ ) > { > - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_NONE); > - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_WRITE); > + svm_clear_msr_intercept(v, counters[i], MSR_RW); > + svm_set_msr_intercept(v, ctrls[i], MSR_W); > + svm_clear_msr_intercept(v, ctrls[i], MSR_R); > } > > msr_bitmap_on(vpmu); > @@ -179,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) > > for ( i = 0; i < num_counters; i++ ) > { > - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_RW); > - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_RW); > + svm_set_msr_intercept(v, counters[i], MSR_RW); > + svm_set_msr_intercept(v, ctrls[i], MSR_RW); > } This, aiui, restores back original state (I question the condition that the caller uses, though, but that's a separate issue). Therefore is the single "set" in the earlier function actually needed? > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -288,23 +288,34 @@ svm_msrbit(unsigned long *msr_bitmap, uint32_t msr) > return msr_bit; > } > > -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int flags) > +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) Can the last parameter become "unsigned int", please? > { > - unsigned long *msr_bit; > - const struct domain *d = v->domain; > + unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); > + > + if ( msr_bit == NULL ) > + return; > > - msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); > - BUG_ON(msr_bit == NULL); The conversion from BUG_ON() to "return" needs explanation; I don't see why that's warranted here. From all I can tell the case is impossible due to the way construct_vmcb() works, and hence BUG_ON() is appropriate (and personally I would also be fine with no check at all, provided I'm not overlooking anything). > @@ -312,8 +323,10 @@ static void cf_check svm_enable_msr_interception(struct domain *d, uint32_t msr) > { > struct vcpu *v; > > - for_each_vcpu ( d, v ) > - svm_intercept_msr(v, msr, MSR_INTERCEPT_WRITE); > + for_each_vcpu ( d, v ) { Nit: Brace placement. > @@ -595,22 +608,31 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) > vmcb_set_exception_intercepts(vmcb, bitmap); > > /* Give access to MSR_SPEC_CTRL if the guest has been told about it. */ > - svm_intercept_msr(v, MSR_SPEC_CTRL, > - cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); > + if ( cp->extd.ibrs ) > + svm_clear_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); > + else > + svm_set_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); > > /* > * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest > * setting and avoid having to perform a rdmsr on vmexit to get the guest > * setting even if VIRT_SSBD is offered to Xen itself. > */ > - svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL, > - cp->extd.virt_ssbd && cpu_has_virt_ssbd && > - !cpu_has_amd_ssbd ? > - MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW); > + if ( cp->extd.virt_ssbd && cpu_has_virt_ssbd && !cpu_has_amd_ssbd ) > + { > + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_W); > + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_R); > + } > + else > + { > + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); > + } Preferably omit the braces for "else" here, just like you do above and ... > /* Give access to MSR_PRED_CMD if the guest has been told about it. */ > - svm_intercept_msr(v, MSR_PRED_CMD, > - cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); > + if ( cp->extd.ibpb ) > + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); > + else > + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); ... here. > --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h > +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h > @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); > > void setup_vmcb_dump(void); > > -#define MSR_INTERCEPT_NONE 0 > -#define MSR_INTERCEPT_READ 1 > -#define MSR_INTERCEPT_WRITE 2 > -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) > -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); > -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) > -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) > +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); > +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); > +#define svm_disable_intercept_for_msr(v, msr) \ > + svm_clear_msr_intercept((v), (msr), MSR_RW) > +#define svm_enable_intercept_for_msr(v, msr) \ > + svm_set_intercept_msr((v), (msr), MSR_RW) Please avoid excess parentheses. Also could you clarify why you retain these shorthands when you don't use them in the conversion that you're doing (e.g. amd_vpmu_unset_msr_bitmap())? Are you intending them to go away down the road? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:32:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503405.775678 (Exim 4.92) (envelope-from ) id 1pX11S-0001TX-4r; Tue, 28 Feb 2023 14:32:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503405.775678; Tue, 28 Feb 2023 14:32:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX11S-0001TQ-0H; Tue, 28 Feb 2023 14:32:06 +0000 Received: by outflank-mailman (input) for mailman id 503405; Tue, 28 Feb 2023 14:32:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX11R-0001TK-3e for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:32:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa1a9817-b774-11ed-a550-8520e6686977; Tue, 28 Feb 2023 15:32:01 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8575.eurprd04.prod.outlook.com (2603:10a6:102:216::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Tue, 28 Feb 2023 14:31:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 14:31:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa1a9817-b774-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kY+XqersIbuYaYW81vcZpdQPnHfUeZNF6dM+mYggICYIAskaCpWKIlv4f9kUparAAYdDoDrO+t3gpAd/+6udMpfyK8JXXVCkcaMGZ3mRjW2rF/uBLapT0b0Fe54nDFJqmg+MI1WJXa3ZIINsyv9bC99OO29PRKkL5r32/UCbjEf7ClMQDHht1g9JJgF34rPKQVBVqWBRyGap2YDTMThvIcQSlH50t04A+LFlWgzJc0f0E65OxqEKf/ceyx8CzHrWPqqDz5d50adXc9IDC2D1WxHeZytyrJzg0jsXBKv72fpWmS3f2wDlO5apzAdU4Ps2dWb/gb0Q11gYu1bmWTnt4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pv4EdgUVDSm0rESOZB0VKrF8/u6rEpZrieWIiEu8SUE=; b=fgtUVxmu8AFTsvDOx7OHWsCENDaM80yNQ3qffNVeoBIBZgGlPpSJcQ3LXhf8WpFbTXeiOYgCT1D72ALvlMLnqQ9+Zb8yX3jrzyS7xb7tLxoKncxA6Vf9x8j2olYriXO8DowfdEI4JpKHir8nb+sWzDqhx0L8eDf5Z/xZ9Ous79IYhs9X+/HDtKVPjfEC5q9X0YH8dd+uSqB1fQZ5FJIKYgajBrwNCHrdiUum8F/XM7W3mbteFTdnC3VLyMwBBS7ppi1gPiu8kQOPKenmpGczy8q30Vqyeqq0EUWEmzIySNB0ODfaJAHU5uurG1Oyzsz6u3bZ/7Dtuib8nKaF1SrpoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pv4EdgUVDSm0rESOZB0VKrF8/u6rEpZrieWIiEu8SUE=; b=JJj9/fkLuhYU9gBuWcJbTliPRcKAWL8UC7iFU17GNDKA3YgFaEb2yPbwaEJah/DUzurcfSB/3LoyUPKKLYqCklTPWEKuIDP4duJYE2gLIhOvDs2BkDGPO2jk1LOOQ3V1nVARwUaT9XADDaKUQhEYhmDhdicI7gYDGlLeY31kiiqTBVHfShuJ+VWWueP59J/WD7HOua+BivDanKVVq4qzHREWSnWRxFFkMT30TUDb02UOx1r3fcaaoR3pREPcAHQd4BXR+txPqwBh3CoiaDwEhdA7j9xZARM2oBEtJdmp45KukZcO1wsgHF/NApJSpyKsipE3Fm5wPZ1ZTl/PDFrXfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 15:31:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/4] x86/vmx: replace enum vmx_msr_intercept_type with the msr access flags Content-Language: en-US To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-4-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230227075652.3782973-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8575:EE_ X-MS-Office365-Filtering-Correlation-Id: fbae1fb7-5dba-4667-d98b-08db19987d34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W4pw0bwi6fDZJ+Fk6tNCwAbWItE0V5Pn+yk1gGJQUkIxF1E67gAaxK4OpLGJjhiR1pNI5VK7BUSsvSXSPztfcQLkKGB+LbjAmxK7FyvZNo/n9ThXtulT+iWdVj+j4vUal2bsY3jAI+OjR/Pg+TymNhbIicdeHW2sGqSWF79exOPeYYLCRRKjKFTO83PhFI++WWhyYUEily7mJG1QbJu4kdL3Tgjmx2vqJAzAYpv+UC5a8L+d2BgmLg+PrpFveggrJuPjHZ+AX0UMk9cDIhIrn7qQgT+DgJkWe8D1x6murUNgAUZ45VWoieb12U9P1REhtAUk02+37QafpFTTLxW+AkDUuCFBPyTzc5A6FdjTY99J8vTn6RlF6HFz354uVX3XaUB5HOI16P80ykg9G8YePVepE7XR4cUDe980GYnZhQwx23fnKAUfPJcETjPumWqq10+gS2Jca0i8SorjjbQWzhdDNIOwxBRqH+0a+h4mRwwvIUl8GZZcPM4Hqf4lyOh2rAaUHgg4RhbFVn5w6XPW+RfFtbIIKxbSGDvxamH+bawQ9OwlxdleAV79o1G2o3nLjEy3yOslHu4jwjqLL9pkoG7uXfFpRv3yASMcmMzOWp22U4ltcjBcdHsXIz8z3hzLhTvQi0S0fOOQaKizkIhVWqV7YZhf6PVxsTWh41CKzyb8f8qoxVeIjDYzu7QpCWqpNpNICe+Thseo+RAEOG1CgDN6xEiRnOpJkv8kslknInk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(136003)(346002)(366004)(39860400002)(451199018)(31686004)(316002)(36756003)(54906003)(86362001)(31696002)(186003)(38100700002)(26005)(6506007)(53546011)(6512007)(2616005)(2906002)(8936002)(478600001)(6486002)(41300700001)(4326008)(6916009)(5660300002)(4744005)(66556008)(8676002)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L01xUWJMa01RTUV1RHN2b1BRS2o0YkFtU0FvMjk1ZkdGZ1loZ1NtNGgxcFVS?= =?utf-8?B?TURQTDNwb3RQb3JwSllDL2JoSmQ1c0lyQmJZZ0dBbmhvUkJ4bnFkVmRBREwy?= =?utf-8?B?Y2Q3SVprbGFabmhhbVcvLy9GSHY0eXF3eE54V1NjT1h0UjV3OE5waHpDaW9N?= =?utf-8?B?c0dTZkhlNWNpVnRFemZiN1JlUjF0Y2d4NUxkMDN1LzZmY3BMK1YrVVlaVG9X?= =?utf-8?B?R1lhRE96YmFqWFBIVmp5VDYrMmJxbklrSzlMSEZLREpacTVRak1zUi9sSUFY?= =?utf-8?B?OU9vL090YnVud1ZkcWloRk1uN0s2YzNnc2dhSkVickdYUnl0TFNMVzNNRitZ?= =?utf-8?B?N0JEcFpQRTFOWHFmNTNobE80QjVrcHZGaW9yRmY3eERlZExhaGRnUVRJVDVa?= =?utf-8?B?cUxzT2pUQ0hJekg1SHRnemZJakc0bVFFMWgzMFE0TmdVWGVHOUF4WVVDNDg2?= =?utf-8?B?U3VPbzd5T2FjNDU1azA3akVFQmdJeGJibzIyZXREUzlRL2J2b1BaenBWVzQ3?= =?utf-8?B?TWh4R1VGVUNvbVFQSHo0TlNCdm1pOEcwdWhFcWhEUU44enNmS1E0U1E2MDlJ?= =?utf-8?B?SDVMR1I5Z1hscEpNczdMbG5zL0xYanByN0QxcFg5M05Ba3p1Wk5tOWo0SHJw?= =?utf-8?B?K2dkcVRwRjQ3VjZHczFSZzlIejA1VDRSMmtwVzI2SWJvZHIyZ05wODZWUElL?= =?utf-8?B?VjI3d1IrajdhS1RlWjlxSGlsc204SGFQdERwMzA4bWZVam1BbitUV3F4eFdC?= =?utf-8?B?dk9sMFBsMytqbGJic3B1S1NxWDFXK0RvL1drZ20rVlZxRWMyejlDd0Jrb2F5?= =?utf-8?B?YkVjeWRyZzlON2xLUHRPeTFMbEpZa0NyN2xIeGlXYktjM1c2WnVJOEp6RlQ4?= =?utf-8?B?bWVTRlUvNldpOS8xRHVIUHl1RlJ1bzJ4M0YvblpldHNQSDUyZWx4dDF6NlB5?= =?utf-8?B?ekRTelBYVjE0VHNYN2V5azRrcEx5bHJOTFhUN3BSSWhVdE12ZTJzdUVqcXQ2?= =?utf-8?B?YlFES1YyanE4bzZTMlRhQnVQTkJEQTJRRUEzV0Nqa3YyQW0xVnkydTg1bDlo?= =?utf-8?B?OWtIYUhzeUUzeEIyZXRsVGdVaEMxcHArRmlyOTVPbXM0by9CRjB6NkRTMXlx?= =?utf-8?B?T1N5aXZPM1QvdEpUNlhoYmhXcGtjYVRpa0dvMDB2VktoanlBMWx6dUptTkZZ?= =?utf-8?B?cVpiNlEzSUFuQlZaSUxyOVBNRnFJRkhCa1Ryb0d3R3RQQ1Q0QzU0dXA5N2xZ?= =?utf-8?B?cVRPeng5MDNEekdXVlpDNDBpMnJwQnhhWHBuRzkvNUlNNGUzTlZSNnM5bjZn?= =?utf-8?B?QU1BVzhuZlRnc1Y1eUNVM2ViZjFYY2dSc3lLdkR4WVJ5QkRNS2V2SXM3cUNp?= =?utf-8?B?Y3NDeGdqeU16TU5QbU16RUlNOUNRZWtRSnV2K1MvQXFtMkNBbEQ2cHY1ZVBj?= =?utf-8?B?NklicVU5WFN0R3ZHWDZPQyt2Y2ZOSDRVYW9kbDM4NnFDWmZIcXFFMjdsNmhj?= =?utf-8?B?ZUM3NUE2czZmVVJXRDdnS0NhM0JHSlc0YVd3WFJWbzNrWGJIYVpIVngwN0xE?= =?utf-8?B?Q05oSUNjaDYzQnpiQzQrdWc5QmRvd0VreFN1UWFiWS85b0tMVDdram8rWDVs?= =?utf-8?B?ZjhoZDdUSTI2N3VSZWVObjZoRTVOT1ZFQ1JQNE00Sk1OV2xhVEJZYU5OUllN?= =?utf-8?B?ZzVOUnVDZFlWN1JRRnNHai8zaUNkMExWUU5tZkpyRkhPb0k4T1JOYnlCZXhk?= =?utf-8?B?ZkJMUnZmQWtjblUyK29HWGhGcmc3NzVXNUFMTkxncjVkdTVweVpYM3lKVjR3?= =?utf-8?B?eHRDYlRIaWV2OHp1RVMxNWlaaXpVREFhZmpZcHh3TlFmTHdzZGxMazl2S3M0?= =?utf-8?B?WjQ0TVlEOXdlaG9kaE1lVlRFR2hTZkNrMWk0SFRXd1R2TXlJZzdRWCtSUHpR?= =?utf-8?B?UHVkVXZZTEVtUDAyRDdvR0JHZWN3OTJiL2ltTTJEaEpxNTJCMHpObG9tQmFv?= =?utf-8?B?MURYNlMzT2ZnSzZNa2Q1RzBKN2JhWWFrTEV3TnB4OUpQbmJsNTZ1NU9yVUlN?= =?utf-8?B?ZWlqdmhGTG5YUXZ2RlRjaC9lVWdFK3htMjdDVDltRVdLVllxS1NkZ3BERUFw?= =?utf-8?Q?+wg3jr8hakfREhsPLVTZ61c+h?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbae1fb7-5dba-4667-d98b-08db19987d34 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 14:31:33.0489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PINDKjx/eFuy9c19U6Bt7d+E9EKoXoA/YtGWukw+LBjFpi0PDEf70wEesP+vHznwEzSvid9ovzN8fIp8V1tDUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8575 On 27.02.2023 08:56, Xenia Ragiadakou wrote: > --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > @@ -644,18 +644,8 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, > return 0; > } > > - > -/* MSR intercept bitmap infrastructure. */ > -enum vmx_msr_intercept_type { > - VMX_MSR_R = 1, > - VMX_MSR_W = 2, > - VMX_MSR_RW = VMX_MSR_R | VMX_MSR_W, > -}; > - > -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, > - enum vmx_msr_intercept_type type); > -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, > - enum vmx_msr_intercept_type type); > +void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type); > +void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type); unsigned int please again for the last parameter each. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:34:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:34:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503411.775688 (Exim 4.92) (envelope-from ) id 1pX140-000264-ML; Tue, 28 Feb 2023 14:34:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503411.775688; Tue, 28 Feb 2023 14:34:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX140-00025x-Hm; Tue, 28 Feb 2023 14:34:44 +0000 Received: by outflank-mailman (input) for mailman id 503411; Tue, 28 Feb 2023 14:34:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX13y-00025n-UY for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:34:42 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20609.outbound.protection.outlook.com [2a01:111:f400:fe13::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08f5ced3-b775-11ed-a550-8520e6686977; Tue, 28 Feb 2023 15:34:41 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9700.eurprd04.prod.outlook.com (2603:10a6:20b:473::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 14:34:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 14:34:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08f5ced3-b775-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eDyJ6CPbQS08bQEHNzBKn5mR/PvRp1pZ6rSLQorrGHZdi8B6Z7Qh3cK59T9LWC2ohd98a/jfQmlz2VPFN9gesCVJmD5oIj2lB9WixA/lcqJBpBtprhs1zl+mfV9NP615lCn+e0A6EZ286u10JTLh1cEJJ/WNzMfrW3phor2Zp+cCE9K6flO9tQyPwuD2ozJb1xF3WukLhpdojEsPYvh+35KknWoagUb0mqDgwJLpHHXwUo3oOa8O2oAp0ILCmVNH2LticQFYXZBaDcl03fonXS6/8ChZaOXld0UIwa8OfsL94SogDuFvb/oqY3jYe3VfK1YmJPgJHUKJj9PE9isvLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YfCRyZD09J7MF0fUTxIaYJx3kdGw88pi/ktRGnphkSo=; b=RU0riz5zH04PXWUZqgSRGPWcI0cxMA3CNFLNJdDbucjSGW8Q5+YowwGagJivD32SzP5KsNzMKyXVZrkZCvr3DdT7rKc3qpGKkqJ8HXIHBRyfnCQiMhV/4atLw2I5LcoB3I5c2a7ID6FG5D22+xbtRJCDYfuf3rJWWtf4YWqHvmmQhLEqT23SPWBHgZO9GW+/d47HObOxbcto7SgHrLwnrQw4b6ey/gN+cIrtVfRIsslBULDBRxF5cuLbbVa5fgVYfe36ZEc1DsOobaNVWi2wKZI5QHzMmMaTpNOT7yJTR6Wgo0Rn0VAWAkfVYzXkAQjwRzTxVgSh3UPAWNTNzLfHgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YfCRyZD09J7MF0fUTxIaYJx3kdGw88pi/ktRGnphkSo=; b=oMQyrC1i4kLcI2EdaC6R8vBKHhagRwr+UKiEOwRutkrCMszt8NmF2Kk7vvxnd7cbxnXG6Hc55ZgIS8xEQHYFY5+L5XsK8UhNN3QqJqWs5IrNPh/TVkGSbAADdpe6yb7kDr3aiSVVV8HAYxVWORfF5Q6QT8eOClQsE9cc8tp7xv0FHnbsCEtesZk4fDE70noBnROK2mXKYY31eIs+U0CwXUZge+iNny9rTBZf/0fpQ47fkdoluIcvlpY+OVpCXeI9VaYzAHpCAB3WUONl608EnhDXJcGnf+z9nADgpHHh6NTZ/zEzUblFKXTDeWumt3ajqzQaM1gwHNz9wTcOqOYypA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 15:34:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/4] x86/vmx: replace enum vmx_msr_intercept_type with the msr access flags Content-Language: en-US From: Jan Beulich To: Xenia Ragiadakou Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-4-burzalodowa@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS1PR04MB9700:EE_ X-MS-Office365-Filtering-Correlation-Id: 36bc513b-522a-41df-a4d0-08db1998ec36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 78bfqLksEiOtPSkaUcRiaZve1lZXjrYM/uxhHvqOlODDw3DN5ErJmdYxeIn5CdLUVxdFlWQPV+RluGa1uym3K1tSQMhUn/V6GMlIuuKdkjTOMB5wqNaHm/XOk0TK3u5J40InzDB3aVezvPR0C7qqzPVIFduqihHT0QTIlVB0WaecYNVsZmQg07dVE5aFVRDEv36OVy3OTNDda0Q0CoAwn1rFdx02y4mhvcEvqQg4AUmHbvjv4Efy/nHPhqnaBi/fj7AQ4MPkQ6RgiV0+E8yOTsysc6Ec7FYpXGTWAVTZX42bZkC3D2G5Wa+okmklHyEyID4CYttr4PtFoACRKJFYL1TerA+XmARF4xqwMZGqaC+ji1ck+NPPv0WzOATW9EQ3bWWdSbuhEvesJyCj3bCY1wzLs4r7aMclVyE7Rq/5vZlUkCkYRBVw9SeajPc9w0txgRuHUVTIHwoymM9uIRgv5bD6qcfM0hqAWyChVd9SoIxsfBylNUWIdefBSLeB9hGnyvPgXOCAueCQPoHdwb+CcBgU2KdQ1vSqelvpEfRoc++TgzjgHD22YURSD00y95WIPdjdim0y3TjlUMOiuAmfujao39TxgS7u/lT97LhE0zFSbGQU5omuQHpBVP5MQDuZzey7VTefjw1grZkrNjRTkQSgF3dECiPXd5y+5exiWy5onlRSnPW/+y5I3ts1cQbLtU96M9brUY8TGLFFJk5POpersJRV5IIl9YHU1EByqHc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199018)(54906003)(86362001)(6486002)(316002)(31686004)(478600001)(31696002)(53546011)(26005)(2906002)(41300700001)(186003)(8936002)(83380400001)(5660300002)(6506007)(2616005)(6512007)(38100700002)(36756003)(66556008)(4326008)(6916009)(8676002)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHkxc1pqNFkzcm8vM1B0QVA0bDkxRW1VT2UvajdKeW5Kb2dFdCtKME1QMTFT?= =?utf-8?B?eEFDdU4rNEJzdy8vWXB3LzdXQVltVkIwdDJZOTE2dy9OazRPUHZyTG93MmFO?= =?utf-8?B?Z1FESWpwVWk4QTY3NjRsQjhxVzU3YU8ranVRRnF4MXV6ZEdmNm11WDVhdnZl?= =?utf-8?B?VkRuUWZ6VkQramt1UzFMZWFRREZjeUNYSWVibGg1eWNhaDJsVXAwY1kzYzJN?= =?utf-8?B?ZEpWV2FIbzB5dU5YSFJGay9xRHNZb1JhWk1ONG5UWVhXOGZwOTNkRXVIanl2?= =?utf-8?B?RkZXQjBla1J0TE15ZVBGcldMQkpRejd3NDdSa0tKdW5Ga0RRU0V4NktKRU1X?= =?utf-8?B?WGtiQUJPSnRCaWxQTUkyWkx2eEczeGVneDRIemZGSTEwUGJVSTJqWTk3Nnpo?= =?utf-8?B?V2FSZmdBcDFxM1cwRUdVWkZkM3dnWWphZ3ViSS9DakFlTVE5TW9NakJuK0sv?= =?utf-8?B?NERGOXRFQkFWQ25wMWdHcEw0aGQvUTM2WXlTVldJeDFEa3dYNE03eHNQMlNW?= =?utf-8?B?OUlzOWdrM2xWNmlxSmlKOUU0cWFzZWxPdllxckRFdFE0M0I2c3ZqcjhkYnd3?= =?utf-8?B?UzRCQ0k1c0hSK2FraG9pNlhQWjNmTmV6NklSSk4yS0NwUzQ3R2JRK3BCU2xR?= =?utf-8?B?M2RmQ2YyZS8ybVRYQjY5d1hJRVJNVTVsTFVZcVNUeDI4WXRjN0R6dHZwcytm?= =?utf-8?B?UjllRjFqU29wQVg3UnRJVklRcVc4MWJHQ0hkZStvbEY3dW56d1BHeWRSdWd6?= =?utf-8?B?VEx0UzFYT2pVK0JRNG5Ta0t0RlhKWGNXSDhJemdGVVRRNkFaNmpLVDJnZGdi?= =?utf-8?B?RnNaMjlWTm5TUDlQSWE2dUEybTNQM0FUN1diU3JkZTZjWXFEcGcrakw0bVNh?= =?utf-8?B?VGZUN1hkZm5IT3Ixd3VrRVozd3ZoOVpJcVJZSzUwdXNaTG5Db2ZvZEU2Y1h6?= =?utf-8?B?REwwWWJMa2xFdkJ4Q0JUdnJIbHRjV3dydzZBUWNBYlFUTGFhT2VjR3E0TGdJ?= =?utf-8?B?WnhpNkpJZmE4dVJ3cmhDSjFSRHU5OGtoSTNpME9yQWlHcjM1WEtLUUovTHhr?= =?utf-8?B?Q3E2RXl6QlNCMTlwUWNNVWkrOThuOXJNTlpGa3gwSHkrdSswOFl1Q25BVnBk?= =?utf-8?B?WFRRZm5xZ2UreERCa2o5YUJIem9FVWFGWWlNZmhWUlBIcmZBeTdoUm5TdG9C?= =?utf-8?B?NGFjNXFBZWw0T1UzV21pc1ZMZ1VHalo3L1dPd0wyVy9XR05iajl4U2djUGUz?= =?utf-8?B?ZDcxYWFDcTZZa3F1M1lkbHoydnVOc1NVUXZLcnI1bTRCdjd1dUsvbGQxeTN0?= =?utf-8?B?cTNoY01QcGJSMXpsdUYreHlPTDh4dStERFN0RThwT3VxMjU0TmRUc3BSbVZz?= =?utf-8?B?UkNmODRmL04wNUZKb2dXeUdnY09qYU1KeHc0L1VUdlZiU29YZWFvRG1hbDNl?= =?utf-8?B?SkVZdGZ6TUIxZlhpUWpTUlZPdVdKdGVlS0lzSHpKbkhzeXh1Y3QzbGpZaUdO?= =?utf-8?B?dnRqVGR5SWM4YTlRS1pBWFVxQ3JuaVRaNElNU2g4TFp6Zk0zR0VydVdvaE83?= =?utf-8?B?WWpGcEpjd3p6dVJ0eVA5bURmeTYxdkw4a01WTFlYSFZHTDEvVWh4dVJqU0pz?= =?utf-8?B?RDdWY3htZythTGY2VExnR25RVjRFQzRTbW0xVWJkdE9TazJsa3dseWdJTjQ5?= =?utf-8?B?NzNEQTQ1NFEvZUI2eis5QUNXNXpUZFR2YTdyd281TDdpcG9Sc0pyWHBOQkw4?= =?utf-8?B?eWZHTW0xTlR5Mm9wT3o4Mm9oT0FFNFp4TVBQc0x6aDVxTmp0M1hVRWc3WGxY?= =?utf-8?B?emFDRk9waTJ5cFZLb1ZoVGRRM1p0dlRvSDVaMWJMeU9qVG43eEdKNENSN1lE?= =?utf-8?B?N2tvU3Nka3VIS1h6UFZON0NQWSsxQzFUaFAxaHp5a0VYNS96bm43SjYrZzZh?= =?utf-8?B?eFI2UVVwMFlFbFEwVVcyd3BSQ0k2NVVVamNWamltaW5JN005Y0VmUHd0TXdD?= =?utf-8?B?c0FDSk91WlZaeWd4UktENDNjRlJLdmJOZHJvYU1uMTU1MU5Kcm9TZGUxR0Ir?= =?utf-8?B?SkxlTE5MZ1ZCbnoyb3MzZWwzUUNXOXUwMU9pYWNHUXlSUllaRmoxMXZhNG9v?= =?utf-8?Q?aoxNDuW9TKn+YLT5rjubwI7ao?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36bc513b-522a-41df-a4d0-08db1998ec36 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 14:34:39.3034 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Km+i+hNHkJA1gjhZ9HCHFw4nGcCZpzD/Pb0UeFJXSgXa5OZVAYiN3bIzy2Dp+8RYIlZNIEsr7vd+0EbrciZnSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9700 On 28.02.2023 15:31, Jan Beulich wrote: > On 27.02.2023 08:56, Xenia Ragiadakou wrote: >> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >> @@ -644,18 +644,8 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, >> return 0; >> } >> >> - >> -/* MSR intercept bitmap infrastructure. */ >> -enum vmx_msr_intercept_type { >> - VMX_MSR_R = 1, >> - VMX_MSR_W = 2, >> - VMX_MSR_RW = VMX_MSR_R | VMX_MSR_W, >> -}; >> - >> -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, >> - enum vmx_msr_intercept_type type); >> -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, >> - enum vmx_msr_intercept_type type); >> +void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type); >> +void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type); > > unsigned int please again for the last parameter each. Oh, also, another remark here towards patch 2: Note how the middle parameter each is "unsigned int msr" here, when in SVM code you make it (kind of leave it) uint32_t. As per ./CODING_STYLE unsigned int is to be preferred; in any event both (and the eventual hook) want to agree. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 14:58:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 14:58:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503423.775698 (Exim 4.92) (envelope-from ) id 1pX1Qo-0005KX-Fy; Tue, 28 Feb 2023 14:58:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503423.775698; Tue, 28 Feb 2023 14:58:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1Qo-0005KQ-DB; Tue, 28 Feb 2023 14:58:18 +0000 Received: by outflank-mailman (input) for mailman id 503423; Tue, 28 Feb 2023 14:58:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1Qm-0005KK-U9 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 14:58:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20613.outbound.protection.outlook.com [2a01:111:f400:fe1a::613]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53944c42-b778-11ed-a550-8520e6686977; Tue, 28 Feb 2023 15:58:14 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS5PR04MB9875.eurprd04.prod.outlook.com (2603:10a6:20b:652::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20; Tue, 28 Feb 2023 14:58:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 14:58:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53944c42-b778-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JgHEE5U415W/qfOkw8em3sWbulikXJVZxIY4Y+AjgrE3HEmmc4HniPUDW2GKh7K2eroocvNd8LRcgl75Y/d/2UmFK6/KIlcOsd7Kkzxcho+mPYsfpogO6T6yUeTOEMw8vB+23Qg6lwWKQsxXW9G0GwYxGqYWEaDyZSOCTenLco5NCmA/YvY3tRBgZlUNp3uXMT/SI4XFM9VyNUTx0pjs53tb4ggwMQFHh2/4jE+lAHDPD1TMCicjTtgncJ/hvAQBpbJdbiMiZrq6U2U4qWwNVEQ4/lAE9WiAFtQ0GKJqk9xnLRcF/vT9tA4IeMBe4yJP/CAaRYzPfQDZLiURTr53SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDCubEl21OJh4mW3wa05ewPX+PuTGVFIYqXsHA1+OUM=; b=QzaewnYW+uYOnnhzGdxbFjiv0V3sNkvxR4pQHl5qaqLBcE1lLTqJLOJbWdDBEy5ngQk3DscyZvJc8+Sub6VbqxGPL/tdjVzjSUoqlp/N4RcNfKLBAeE7AiBquCJ49yt4tR0oBK7CrpXJ3iLb/OTg/64rbjK9vReh/Ye2YAuoZ7FBquwLOz+8t9eNn8Y99PLKati+LdgWKGAAL+UfwctnHhw7CLTQftnKonA+7Szcqo5BoJrXRk3MxGSphXHeJsRdO5BJ56uvLLwqDdKkeaVFQOFSriTL532tsbw2YiikGB6EqpsbyS70A1iaPOT5Efy5dLYSKfZSEjmECybWHKnxsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDCubEl21OJh4mW3wa05ewPX+PuTGVFIYqXsHA1+OUM=; b=Um5MEWzm5C8FQjtS1gff/qh6Eyhq4WMo+EvO/mn+R9BksH188UEXwQ8yfwMugDGs2QorDJMWszCHb7JERwL2tQ7WY37G6pEkxO9cu5/qyOdmPhJiJICWLe58UMsqtZdnFpk9+L2sO9+f/Od3NqcUBbHCMNjwvd2KeNib3Ko8TZbTkcAPOlTjGctiCyn9gZwjGXkCyV0sBgcZJWgFfAn6u46XVOElVEUm17ewSxlRqLeOFG9W5DMHiXodnvN3HLg31NF0agnZQR27J4FI3onHaRAOwn8BTjAnt+qaSXBxIzfiQVRyeYWYv+/G2ekCWRUl/I3Kp/+LStOoV3//TDylug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <732bbee0-24d3-f5e8-7353-b40a77c3ee2e@suse.com> Date: Tue, 28 Feb 2023 15:58:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/4] x86/hvm: create hvm_funcs for {svm,vmx}_{set,clear}_msr_intercept() Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-5-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20230227075652.3782973-5-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS5PR04MB9875:EE_ X-MS-Office365-Filtering-Correlation-Id: 8409ba6a-7706-483b-84bb-08db199c3677 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W8otldPPZOmSZHiWNIr+oj/ucvcfjlKjLW3vedBJC/3s1JhrsidYDeVYSm1xpDlgoVJcjEOqnqO9QNHdtTEmPyuGAfCPoddboU9X1HJDfcGIiPR9XcaGOJWdNYAW9JOAsfgTH3DO8j1hug8SJv+EVlq3bLZEjgMFWliajul9hmey8Fg/xNQBL3Z33MgywBLzUbknvZksfaK8y6zZy71JpZB/mnTbgeuqB3EIamI3u/8u68jUep1BgIl4Kmwb8LBwRaKcz5nXrD1VfHBhdDawbFP+VdqdDficWjPuzN2jZXS0t9tnWI05jDE8//OSU6h5aUZ0RSfkdm2JhpRZd/zERJtdP3d21EWqFlr1g3aEz+lIZD4XYNbdt48KoLflEylhhwm0xf8xDrIC/scT/Cq+rvGgmHrNrq0cuqgDwTcpKEAHGwGxwnOMNIoZg77bOQ9hYXuOVuwLQnYNO0suNk8nUUo/dUG08skjSh0BSMpTUR8JimILcZFlln3tHbbALp5MNjDU8UeA6ymu6gSJEzEyGbX+Wuz10jAao/dXQ3Fd75MAOULwfqzs0Y+5DDd+xvD+BZAETVQ5tjVwY9s9OLE3K/q6v9GapJ2d+REAGOFketZnf1nHd94DqOnfr/l65Z4xAgnUI3EYc9QF+JudcxpSTKzoHJ1i8F3xA4hsttk7Wxn5aRSm4B6aHD+X4CvRqDYadxp/LmglTqNec2lEJ41pJIxz9WhFG84TneyMmP35Fic= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199018)(36756003)(53546011)(6506007)(6512007)(6486002)(2616005)(31696002)(41300700001)(186003)(26005)(5660300002)(86362001)(66476007)(4326008)(8676002)(66946007)(2906002)(6916009)(66556008)(8936002)(38100700002)(478600001)(316002)(54906003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDRmOWpFWkhnMVJqRFJuRkxiMWR3R3FMeG9jYUE3WXJ0NWZSUGVsamI1OXli?= =?utf-8?B?eFFzZSs3eEM1K1psVUIyR041aXJBejZlcHV6WHRyYlJlZzh3N2xKY28rS0c3?= =?utf-8?B?QldnSlVTZUxpc3lNd0c5bExRbFlLRklrV0dPWGJTR0FHNVBNOEFPeFJEMXBj?= =?utf-8?B?dkVHTHdaNUhUZ1prSXgvaGVlQmUwQXN4TkR0eGUwV2tKTXlkTHNVQ3NEQTNi?= =?utf-8?B?Ny95UTJVYUt4MjdoWUdIc0hrV2o0Mkd0NXJucXBkb2RJZk1PTzMwM0JPSXpY?= =?utf-8?B?MGE1NVYwcEJVL005cUxTTkpFZzg4dG1tSk5YempJZmxxRmVsV1BQODlKVGNM?= =?utf-8?B?Tk9QamJrNEJoNmo1WHZOTEYrd05OYXlOejZFQmdwa2t0Ulg0REp4VFhnYkx4?= =?utf-8?B?QnYwY0hsYjA3ZGV3Q0lOWTJ1bGxLWFdGbGNDSGEvU0I0QXRWVjd3blgxUnpl?= =?utf-8?B?U3RhTGhzV1VxNWM4cXdyNTRPOUNvVkQ0aWdwR2w4aG9SazIyemFoZWY1MGpQ?= =?utf-8?B?eVlyRFJudXlwTllTZUtacU5adFFtN0tybmRCNmprRndMaytjdjVyZ3FlYit0?= =?utf-8?B?WFV2NkN0R29IZzdGOU9oVi8vVUpjNlVRd2Y4Tis3WVdmWUpiMFpVOTBYVHJo?= =?utf-8?B?QVZzSUdtN3N1RUZ5VFd1aDlnajYzbXVKak1pWkNHZkluOHZubkpxMnZHOFpN?= =?utf-8?B?WUw2WTJHRjJZYUozUzVPTkpackZrWmJlTVJXS2NFMllzRTBNVFpiR0JiK3Rk?= =?utf-8?B?enZTYm56a1hBbTRZRkQ5bnVyV0k2c2N1SnBQNzZlbEtvaUR0VC96MFpjdEd1?= =?utf-8?B?WUpNZjVLMk96K21oakdtNU5MZHo0YU5QZFl1R2w5cEg1TVBIUlVJOVdrR0pU?= =?utf-8?B?Mk1MSlpyQTZRckI3di8wN050R1RIMjE4anRPL09ldEZNdkFPeC81QnNpcHRI?= =?utf-8?B?dEZrZWQ1Uk5pVXEzSDNaVy8xSmMxSGhIQTFWMUxpa3VaTS9RVXRUYmRuUHFV?= =?utf-8?B?UGdROWYxek1ZSDR0b0d6WmY0eGNGR05pSHBiWkZwS2QxQXNnd3AySWx5ZzJp?= =?utf-8?B?MzVaZFhPbzJ6MDJDRS9IZHRCSkdLMGlXVXhBOXNrREpleGVRYWwwZmVjaWt5?= =?utf-8?B?Wnd0eUQ5NjFqRllEMzJXSVR0c3VkcGNYbFQ5TTAwVWRRaHZicXhxSGZDbFc3?= =?utf-8?B?R1dtWmhOQXRhQjRTY01lNzF6Y0VpZWZXLzN5cXMvblJ3Tndrc1ZFQ2xTT2VY?= =?utf-8?B?b2J4RWo0azVQdjBaekl3MjA4eUlBR0lRcmdJek1mRWZCTkNMVW1ZRTVQbjha?= =?utf-8?B?d3J2S3RHU2o4NVU4MmZUaGFqYnhtSkhWN3VFVHBlNGU3M1IzWklXNWk3ZGRo?= =?utf-8?B?MjVCZjVYUkNtcUhjUWw3LzJaUGNOdmMwQjUyRHV3bU04VGxrUzVPQ1BjSUdY?= =?utf-8?B?QmpSQzF1ZXJmTFdmZXdjbkJxNmFGTmt2Njk5eXNJSUp5ZTlUa3M4bDg0Rjhw?= =?utf-8?B?akxrMnJlbFJyYXhnenNtcFp4TDEzbklMVkoyRDM5L0NvSnVMTi9jc0Y1Ty9t?= =?utf-8?B?L1FWcHR1MEgvaGZHOGVNbUNscVV1M2RFVVFSQlQ3bGFhbHNoVmMwU2ZTLzkv?= =?utf-8?B?Z21IcXBuRHgxUjV6L1ZNbXNWMTYyNG1xUFBjNm1ndFJVdFhEMEE2WTQ3TjFN?= =?utf-8?B?UEd6KysyOHpyNVlMTlZPQVJiTncvbUw0bW5Yb3dPMmF2ZThYWTNTZUxKckdR?= =?utf-8?B?S2RxeUorNFN5S1VoN2N3a0tKZ2J6aGxUdmFFNHROcFdXY3hRdnZnbWphZUlS?= =?utf-8?B?VWtjdU12TlF0VGNGbXRxYVlKU0c4UDJ1NHF1VXNaQVZrcWVSejc4MmdGWE00?= =?utf-8?B?eThzQ0ZneTdKZnJCSzFCNEZJN2R0R1lDczNZUjRVZUdEMXVxVTR0dkplTU1p?= =?utf-8?B?YTBkN0o0dVluNVF4bXl2Tm4xa0tSOWZ4TXZKdWt3bXl4RGthRDRUejJKY285?= =?utf-8?B?RE5rTmI4M0RzQ2lEQkFlVWNKUTJheS8rcG5yVVNBV3RTS3VWVFdEK0N3R0Zj?= =?utf-8?B?ZzBjY2x1U2RUNWorVkFLRUZORk13NitPMjZJT21ZaWwyUzc5c3VlL0ZGQ1h3?= =?utf-8?Q?YbMZm1haT3jgGkiIcfuXsUIGM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8409ba6a-7706-483b-84bb-08db199c3677 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 14:58:12.3858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IAjA9hATDSFUvdSmmtUQmTkL+81mZNwXPJbMpqLnaqAFDPGUYXVT7kb2NrMBqD/rozkUMyS1hI5GfqwiCCJVHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9875 On 27.02.2023 08:56, Xenia Ragiadakou wrote: > Add hvm_funcs hooks for {set,clear}_msr_intercept() for controlling the msr > intercept in common vpmu code. What is this going to buy us? All calls ... > --- a/xen/arch/x86/cpu/vpmu_amd.c > +++ b/xen/arch/x86/cpu/vpmu_amd.c > @@ -165,9 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) > > for ( i = 0; i < num_counters; i++ ) > { > - svm_clear_msr_intercept(v, counters[i], MSR_RW); > - svm_set_msr_intercept(v, ctrls[i], MSR_W); > - svm_clear_msr_intercept(v, ctrls[i], MSR_R); > + hvm_clear_msr_intercept(v, counters[i], MSR_RW); > + hvm_set_msr_intercept(v, ctrls[i], MSR_W); > + hvm_clear_msr_intercept(v, ctrls[i], MSR_R); > } > > msr_bitmap_on(vpmu); > @@ -180,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) > > for ( i = 0; i < num_counters; i++ ) > { > - svm_set_msr_intercept(v, counters[i], MSR_RW); > - svm_set_msr_intercept(v, ctrls[i], MSR_RW); > + hvm_set_msr_intercept(v, counters[i], MSR_RW); > + hvm_set_msr_intercept(v, ctrls[i], MSR_RW); > } > > msr_bitmap_off(vpmu); ... here will got to the SVM functions anyway, while ... > --- a/xen/arch/x86/cpu/vpmu_intel.c > +++ b/xen/arch/x86/cpu/vpmu_intel.c > @@ -230,22 +230,22 @@ static void core2_vpmu_set_msr_bitmap(struct vcpu *v) > > /* Allow Read/Write PMU Counters MSR Directly. */ > for ( i = 0; i < fixed_pmc_cnt; i++ ) > - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); > + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); > > for ( i = 0; i < arch_pmc_cnt; i++ ) > { > - vmx_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); > + hvm_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); > > if ( full_width_write ) > - vmx_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); > + hvm_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); > } > > /* Allow Read PMU Non-global Controls Directly. */ > for ( i = 0; i < arch_pmc_cnt; i++ ) > - vmx_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); > + hvm_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); > > - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); > - vmx_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); > + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); > + hvm_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); > } > > static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) > @@ -253,21 +253,21 @@ static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) > unsigned int i; > > for ( i = 0; i < fixed_pmc_cnt; i++ ) > - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); > + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); > > for ( i = 0; i < arch_pmc_cnt; i++ ) > { > - vmx_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); > + hvm_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); > > if ( full_width_write ) > - vmx_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); > + hvm_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); > } > > for ( i = 0; i < arch_pmc_cnt; i++ ) > - vmx_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); > + hvm_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); > > - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); > - vmx_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); > + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); > + hvm_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); > } > > static inline void __core2_vpmu_save(struct vcpu *v) ... all calls here will go to VMX'es. For making either vpmu_.c build without that vendor's virtualization enabled, isn't it all it takes to have ... > @@ -916,6 +932,18 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) > ASSERT_UNREACHABLE(); > } > > +static inline void hvm_set_msr_intercept(struct vcpu *v, uint32_t msr, > + int flags) > +{ > + ASSERT_UNREACHABLE(); > +} > + > +static inline void hvm_clear_msr_intercept(struct vcpu *v, uint32_t msr, > + int flags) > +{ > + ASSERT_UNREACHABLE(); > +} ... respective SVM and VMX stubs in place instead? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:05:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:05:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503435.775708 (Exim 4.92) (envelope-from ) id 1pX1Xf-0007CT-8M; Tue, 28 Feb 2023 15:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503435.775708; Tue, 28 Feb 2023 15:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1Xf-0007CM-4G; Tue, 28 Feb 2023 15:05:23 +0000 Received: by outflank-mailman (input) for mailman id 503435; Tue, 28 Feb 2023 15:05:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1Xe-0007CG-1Y for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:05:22 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50c86d35-b779-11ed-a550-8520e6686977; Tue, 28 Feb 2023 16:05:19 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id i34so41255809eda.7 for ; Tue, 28 Feb 2023 07:05:19 -0800 (PST) Received: from [192.168.1.93] (adsl-150.109.242.227.tellas.gr. [109.242.227.150]) by smtp.gmail.com with ESMTPSA id x16-20020a170906441000b008d09b900614sm4536023ejo.80.2023.02.28.07.05.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 07:05:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50c86d35-b779-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RUmwbozT7YbHnyo7OEP0SEgOgg9ho/6ShyNhqhfcrbk=; b=VG8NrYoNYWEzJ3vhndNMWIZKN4pKrvqt8f+2msS+YfyKEXYGBBdT4BQ2fTlIOs/kfs EvLYT4iUJuTYqhxDc4NlUC2ZfdarJT/n2WHD5tBmE6Vc9fz1bjR1eckBE7LJCkJTP+Dx uAoXMR+jEuKx3XwLC94+67IQ3zFUduXes7XKAsichYcK/hupuxFR8ARr9b180lxBnMaS bmUuJA4C2OA9WOakRj0Z6x6buI++wsa3VJX0EBcUjZZ82pK7c3tqI5k2zt/Djr4BZSx9 K5ew5mlEfcDeiIbh3zj2YgPZ8x7NANuPjWCKyRQUUQgw4Xv3z8Iw1+ZYPzFVlONaci3J D5uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RUmwbozT7YbHnyo7OEP0SEgOgg9ho/6ShyNhqhfcrbk=; b=aFbepCA6Cqw4Jvm0ItEAR3BkvTtBkcfodXjAYVLJWmPJASFRC/uMY8EnSKY2CCd+P+ ZvRPkjojSNeATvaVEluhP/2PzOKTy/1v2DadIatKAXVxaUTHXNxfksfX5Vi+TJzqDj1o lJdqOi9SRHQHRl0E5ryVPbHn4MX3a9E9HseWIPAKXcwDU49bwmlySjIU+qAPtXo3SUMK 6NrUj/QGLESXWEDpD4ArNNlY52BJqbCC1Iz+an9e9XSGt51ESJfO2CpSwL3OnSVAHvo/ oJSC4rYeOURlWEjemZj+E6EsHLh37pc8xYdQ1EbnGmoAawpzSBAz4wBVtWjxl4sco/LF UfnQ== X-Gm-Message-State: AO0yUKVo9gcoyoXIMm8t3CHmxknAAz0HlmVVk6FEP070VMQUbn0pwY3z WVo8YSb9es5qepv3qLVn22U= X-Google-Smtp-Source: AK7set/zJ7bEh3HkyxuhljlAoeBNv9LOlZ2kKmv+wNE56dbhHeBQ+vw0N9nvbq8W7Hsh92BU84PLBg== X-Received: by 2002:a17:907:3f88:b0:8ae:6b88:e52d with SMTP id hr8-20020a1709073f8800b008ae6b88e52dmr14484928ejc.7.1677596718787; Tue, 28 Feb 2023 07:05:18 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 17:05:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 2/28/23 16:20, Jan Beulich wrote: > On 27.02.2023 08:56, Xenia Ragiadakou wrote: >> This change aims to render the control interface of MSR intercepts identical >> between SVM and VMX code, so that the control of the MSR intercept in common >> code can be done through an hvm_funcs callback. >> >> Create two new functions: >> - svm_set_msr_intercept(), enables interception of read/write accesses to the >> corresponding MSR, by setting the corresponding read/write bits in the MSRPM >> based on the flags >> - svm_clear_msr_intercept(), disables interception of read/write accesses to >> the corresponding MSR, by clearing the corresponding read/write bits in the >> MSRPM based on the flags > > In how far is VMX'es present model better than SVM's? They both have pros and > cons, depending on the specific use. I'm not asking to do it the other way > around (at least not yet), I'd merely like to understand why we're going to > gain two new hooks (if I'm not mistaken) when we could also get away with > just one. SVM approach always touches both read/write bits (either by setting or clearing them). I thought that using the SVM approach on VMX could be considered a functional change (because there are parts where VMX assumes that a bit is already set or cleared and does not touch it). > >> --- a/xen/arch/x86/cpu/vpmu_amd.c >> +++ b/xen/arch/x86/cpu/vpmu_amd.c >> @@ -165,8 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) >> >> for ( i = 0; i < num_counters; i++ ) >> { >> - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_NONE); >> - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_WRITE); >> + svm_clear_msr_intercept(v, counters[i], MSR_RW); >> + svm_set_msr_intercept(v, ctrls[i], MSR_W); >> + svm_clear_msr_intercept(v, ctrls[i], MSR_R); >> } >> >> msr_bitmap_on(vpmu); >> @@ -179,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) >> >> for ( i = 0; i < num_counters; i++ ) >> { >> - svm_intercept_msr(v, counters[i], MSR_INTERCEPT_RW); >> - svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_RW); >> + svm_set_msr_intercept(v, counters[i], MSR_RW); >> + svm_set_msr_intercept(v, ctrls[i], MSR_RW); >> } > > This, aiui, restores back original state (I question the condition that the > caller uses, though, but that's a separate issue). Therefore is the single > "set" in the earlier function actually needed? This is what the svm_intercept_msr(v, ctrls[i], MSR_INTERCEPT_WRITE) does, i.e it sets the WRITE and clears the READ. It is not needed if it is already set, but in my opinion the redundant parts should be removed in another patch. > >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -288,23 +288,34 @@ svm_msrbit(unsigned long *msr_bitmap, uint32_t msr) >> return msr_bit; >> } >> >> -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int flags) >> +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags) > > Can the last parameter become "unsigned int", please? > >> { >> - unsigned long *msr_bit; >> - const struct domain *d = v->domain; >> + unsigned long *msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); >> + >> + if ( msr_bit == NULL ) >> + return; >> >> - msr_bit = svm_msrbit(v->arch.hvm.svm.msrpm, msr); >> - BUG_ON(msr_bit == NULL); > > The conversion from BUG_ON() to "return" needs explanation; I don't see > why that's warranted here. From all I can tell the case is impossible > due to the way construct_vmcb() works, and hence BUG_ON() is appropriate > (and personally I would also be fine with no check at all, provided I'm > not overlooking anything). It was my mistake I should have not removed it. > >> @@ -312,8 +323,10 @@ static void cf_check svm_enable_msr_interception(struct domain *d, uint32_t msr) >> { >> struct vcpu *v; >> >> - for_each_vcpu ( d, v ) >> - svm_intercept_msr(v, msr, MSR_INTERCEPT_WRITE); >> + for_each_vcpu ( d, v ) { > > Nit: Brace placement. Sorry. I will fix. > >> @@ -595,22 +608,31 @@ static void cf_check svm_cpuid_policy_changed(struct vcpu *v) >> vmcb_set_exception_intercepts(vmcb, bitmap); >> >> /* Give access to MSR_SPEC_CTRL if the guest has been told about it. */ >> - svm_intercept_msr(v, MSR_SPEC_CTRL, >> - cp->extd.ibrs ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); >> + if ( cp->extd.ibrs ) >> + svm_clear_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); >> + else >> + svm_set_msr_intercept(v, MSR_SPEC_CTRL, MSR_RW); >> >> /* >> * Always trap write accesses to VIRT_SPEC_CTRL in order to cache the guest >> * setting and avoid having to perform a rdmsr on vmexit to get the guest >> * setting even if VIRT_SSBD is offered to Xen itself. >> */ >> - svm_intercept_msr(v, MSR_VIRT_SPEC_CTRL, >> - cp->extd.virt_ssbd && cpu_has_virt_ssbd && >> - !cpu_has_amd_ssbd ? >> - MSR_INTERCEPT_WRITE : MSR_INTERCEPT_RW); >> + if ( cp->extd.virt_ssbd && cpu_has_virt_ssbd && !cpu_has_amd_ssbd ) >> + { >> + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_W); >> + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_R); >> + } >> + else >> + { >> + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); >> + } > > Preferably omit the braces for "else" here, just like you do above and ... I added them for symmetry, since the first has. I find it easier to follow, personally. I can omit it. > >> /* Give access to MSR_PRED_CMD if the guest has been told about it. */ >> - svm_intercept_msr(v, MSR_PRED_CMD, >> - cp->extd.ibpb ? MSR_INTERCEPT_NONE : MSR_INTERCEPT_RW); >> + if ( cp->extd.ibpb ) >> + svm_clear_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); >> + else >> + svm_set_msr_intercept(v, MSR_VIRT_SPEC_CTRL, MSR_RW); > > ... here. > >> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >> @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); >> >> void setup_vmcb_dump(void); >> >> -#define MSR_INTERCEPT_NONE 0 >> -#define MSR_INTERCEPT_READ 1 >> -#define MSR_INTERCEPT_WRITE 2 >> -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) >> -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); >> -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) >> -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) >> +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >> +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >> +#define svm_disable_intercept_for_msr(v, msr) \ >> + svm_clear_msr_intercept((v), (msr), MSR_RW) >> +#define svm_enable_intercept_for_msr(v, msr) \ >> + svm_set_intercept_msr((v), (msr), MSR_RW) > > Please avoid excess parentheses. Also could you clarify why you retain > these shorthands when you don't use them in the conversion that you're > doing (e.g. ())? Are you intending them to go > away down the road? Ok. I did not understand the question. Which shorthands? > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:07:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503442.775717 (Exim 4.92) (envelope-from ) id 1pX1Za-0007nr-MX; Tue, 28 Feb 2023 15:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503442.775717; Tue, 28 Feb 2023 15:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1Za-0007nk-Jg; Tue, 28 Feb 2023 15:07:22 +0000 Received: by outflank-mailman (input) for mailman id 503442; Tue, 28 Feb 2023 15:07:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1ZZ-0007nX-EK for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:07:21 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 993b01c4-b779-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 16:07:20 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id d30so41347305eda.4 for ; Tue, 28 Feb 2023 07:07:20 -0800 (PST) Received: from [192.168.1.93] ([188.73.239.246]) by smtp.gmail.com with ESMTPSA id h11-20020a17090634cb00b008e36f9b2308sm4602113ejb.43.2023.02.28.07.07.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 07:07:19 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 993b01c4-b779-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jK06YMa7zlDhPqSW5oUxHX1w39uN0C+HqUUTiKN/nsM=; b=oNHppN0RyMGMuT7903lIZhzSpOaSH+80s4RVVPSLJiC0uLViblU4UF+q7mU46dv2Nj LKgB2AgQzZ5hhqKIH7GelhBEzOKZ0roJv90vNh4A0G7Kib/bCd9P48GXeiBvDKwvLphn 30Eqe+DpsnzYBYqQkfdW2M28lBqdmjMuAwa2UrFAnWddNToy6MmdFxHbqmb369JJDOS1 QiKUUsDAFHdYgrsw569RVc6N5bzf6rpMqrifRe4QbIfwLSQe3MAKU+NareA+VK5G5QXO s2ljhXQTcL4HCzsgduiNodZ8x2gkLHLSbPe7g9D6toYa2BLKzs/9UEq94tkrpPYZCZDx eNhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jK06YMa7zlDhPqSW5oUxHX1w39uN0C+HqUUTiKN/nsM=; b=B1g8x9aUWYWOo5C2+mLvIpph5gmTxUJBWqBnBCBpBXzl6iOOksN57qU980eVysWm6k ujwKdLMPWpQU4YbVCn0890BBn/YzWaDp1SECu+60lJNQLQpb+uScqADEc0IsF7bxYq44 SqzB3OGxRZx2L01EDAHGQnSFdL6XQkqJ1821e76b8xoR5Cve96XsEFF2vRnKF7JNg8ie Yy+XWE2b+GAXQiDNNQgJFYWq0Bla8Pnn1ySO3dxRM0JttaWLE8h8d+NTimNbbmOa//IY /Y+qs9OMhkmIsf1zdGmZ7oVfK36IxzcPmuqK6IsQRU+EY0NqIZddIwU3eSjI0kFrAWQN btCg== X-Gm-Message-State: AO0yUKV9MvPz3n9cIL1UaSaHGq87bPhxQNQnbVJYUG+6mv8TG0vUeBsu UDn6OnNZhRVrB3t1DT797iCY+glzzHY= X-Google-Smtp-Source: AK7set9lnKjsUg2OudHwFhWc4ZA6TJgCORl/hZ3KQgNST0B2MjoteQbX44rZL8zU0ZRNn4Z7yiq0eA== X-Received: by 2002:a17:906:c0cf:b0:8b1:812f:2578 with SMTP id bn15-20020a170906c0cf00b008b1812f2578mr3399387ejb.45.1677596840158; Tue, 28 Feb 2023 07:07:20 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 17:07:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/4] x86/vmx: replace enum vmx_msr_intercept_type with the msr access flags Content-Language: en-US To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-4-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/28/23 16:34, Jan Beulich wrote: > On 28.02.2023 15:31, Jan Beulich wrote: >> On 27.02.2023 08:56, Xenia Ragiadakou wrote: >>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h >>> @@ -644,18 +644,8 @@ static inline int vmx_write_guest_msr(struct vcpu *v, uint32_t msr, >>> return 0; >>> } >>> >>> - >>> -/* MSR intercept bitmap infrastructure. */ >>> -enum vmx_msr_intercept_type { >>> - VMX_MSR_R = 1, >>> - VMX_MSR_W = 2, >>> - VMX_MSR_RW = VMX_MSR_R | VMX_MSR_W, >>> -}; >>> - >>> -void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, >>> - enum vmx_msr_intercept_type type); >>> -void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, >>> - enum vmx_msr_intercept_type type); >>> +void vmx_clear_msr_intercept(struct vcpu *v, unsigned int msr, int type); >>> +void vmx_set_msr_intercept(struct vcpu *v, unsigned int msr, int type); >> >> unsigned int please again for the last parameter each. > > Oh, also, another remark here towards patch 2: Note how the middle parameter > each is "unsigned int msr" here, when in SVM code you make it (kind of leave > it) uint32_t. As per ./CODING_STYLE unsigned int is to be preferred; in any > event both (and the eventual hook) want to agree. Thx. I will fix and keep it in mind. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:09:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:09:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503451.775728 (Exim 4.92) (envelope-from ) id 1pX1bK-00005l-47; Tue, 28 Feb 2023 15:09:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503451.775728; Tue, 28 Feb 2023 15:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1bJ-00005e-W0; Tue, 28 Feb 2023 15:09:09 +0000 Received: by outflank-mailman (input) for mailman id 503451; Tue, 28 Feb 2023 15:09:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1bI-00005O-9n for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:09:08 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7999d38-b779-11ed-a550-8520e6686977; Tue, 28 Feb 2023 16:09:06 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id i28so904195lfv.0 for ; Tue, 28 Feb 2023 07:09:05 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id a6-20020ac25206000000b004dc4bb914c7sm1357750lfl.201.2023.02.28.07.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 07:09:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7999d38-b779-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Dm/zzJO/AZK8RXCT9sIWiD+OL/udz98OaMG8IJ3iN/w=; b=b0EfBBX4a7WhMIzXy8+ki0Q6Dv5w7wS5D/ked4yvj9mo+cuNs6A8nq0hQ4T3fzUd6n GMPH3f9sgY7OrPR3TaI+SoSN6gJpoou7Uy1oVfVo552g8AuFU/SapWKTeJIaRmz1X4k6 qNNDr1y3oNebI2NwzvQMwGIwjy4U0rVeQ098kPAGNlRfED27qluwuMiUvfQvJ1ntn9rD FdvP8GugYOQmD6icWR6fTymGD/+vS7PoT2Mt9pUHPJsP7LDnH0vb+W1YGPW5kMEIKk9c 1oJXEoWPmTc1S2G7nh+PDqZ6lyZ/PsLGJuKC145hHYiv/t1aj2HZVIut1pVlu+maOe0H u0VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dm/zzJO/AZK8RXCT9sIWiD+OL/udz98OaMG8IJ3iN/w=; b=NnCoSAE7Lz2MA/eYPdCaw/vgTPizsUud5m+YH3qpjVqQeemnOru6PDaUtQdSTnbER1 oi5vpco8pw49wCOdw+XkOdT3A6J1kT4ofX2w1gILFAXoz7W8569tMorzfcKg4uKcN0aK RPjxePT+UHqkMyYooKvEHcmVuhzZT/foAW2RGMrlRAIe3xbICt7lsypN0BJvjmTcqzHC DgZ+pN82lfDVfQ/XvJckqGq5+yJAhet7l1zaLa0iH6MhmRQvKKqOuBaQiepZskc12UsW jAqOxSyO4TDIPV+NQKm94YhGQ/7xjTsILg5XrXtpu6oL+s0XevECMeao9AJZU1tET0Xc g7XQ== X-Gm-Message-State: AO0yUKVwOlIJK+Pd+XZP9tP8DfoKyuGUVA7n7nWlZtDH/UjE3TS15Mw3 guzBzvW7kS0yYciCN3ftNfA= X-Google-Smtp-Source: AK7set81+BMaBNaeor6x+zTxK3aMjvBahX9fNWbLTGw8xLSgTaTU8OHwWXAqoToHUh8rlZW/AmRPkQ== X-Received: by 2002:ac2:46c8:0:b0:4db:3877:817a with SMTP id p8-20020ac246c8000000b004db3877817amr921002lfo.28.1677596944862; Tue, 28 Feb 2023 07:09:04 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk Date: Tue, 28 Feb 2023 17:09:03 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi Julien, On Sat, 2023-02-25 at 16:49 +0000, Julien Grall wrote: > Hi Oleksii, >=20 > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > The following changes were made: > > * make GENERIC_BUG_FRAME mandatory for ARM >=20 > I have asked in patch #1 but will ask it again because I think this=20 > should be recorded in the commit message. Can you outline why it is > not=20 > possible to completely switch to the generic version? I haven't tried to switch ARM too because of comment regarding 'i' in : /* * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the * flag but instead rely on the default value from the compiler). So the * easiest way to implement run_in_exception_handler() is to pass the to * be called function in a fixed register. */ #define run_in_exception_handler(fn) do { =20 \ So I decided to leave ARM implementation as is. But I'll try to switch it for the test and look at tests. If tests won't fail that I'll switch ARM to generic implementation too. >=20 > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:10:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:10:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503470.775738 (Exim 4.92) (envelope-from ) id 1pX1cU-0001hi-Cp; Tue, 28 Feb 2023 15:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503470.775738; Tue, 28 Feb 2023 15:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1cU-0001hb-9c; Tue, 28 Feb 2023 15:10:22 +0000 Received: by outflank-mailman (input) for mailman id 503470; Tue, 28 Feb 2023 15:10:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1cT-0001hR-2a for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:10:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7d00::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 034d257d-b77a-11ed-a550-8520e6686977; Tue, 28 Feb 2023 16:10:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 15:10:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 15:10:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 034d257d-b77a-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEiMzbP3g4K46tfuWAswrzAaUbN5c4313GzTeOoWW41vGlP+HL8SASWoJd2a9DHqBK+e3OgggHh1BwIPaCtRJ7YhTHqtL37RDxGS24ADVKXA+u+tuSDOg29GSQV9us6F4XTsCN/wccH2qLmOkq91e2SJgy3oL61MSlB8H9XJaTIf9QupY9TlhwLuXaiAzt60iAAm1+XGrIGxC1wOKxyboEBNVIPqGSOQo/19ZzBRCQI6Pl1Ly6Khsg9qzYNWMfGq/2xTb9smFuTMnIfRLz/qO7nSDqTzSzVlkeolZ+8dvJ6mcj/mGUT/xtggYENWahUlG44aGNpHNnguKowfqDcu4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bm4HmUsu75gjAfOtTSd8blTh8qdYLvsHQ9HjKt+lDGU=; b=mmPhf+fI4anJLloWmXiJ+xlUrhlHYydioGEsY4p+7MTRMStiNsvJfCdquXDEJA8ShUnJumzCnd8UA//vgca0kekHbQluLZasLMSrHHDnoFGj6jOSoA5BuvQf0SRosVqSDLOUUNZ6/DTq6BY0mJKSBoKt+XC/KwXmLnelgvQ9Y8Z8TKt/LBMv3s0IhkV5jD102aHBIY95ZSxMX1/uwMg/J4KYcspChFvRk5duVEQUfJeW/YtUD3Xmh/o3SLPP65FMFIzUXX9NXKXtYeg6RrJ/qWPBxDfrtQ1kZAcB6nG6O8cqjyAWh9AXER0C+LqQ8j/+pUSNXt1jV1lY2Ms7LkW9uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bm4HmUsu75gjAfOtTSd8blTh8qdYLvsHQ9HjKt+lDGU=; b=SEdDqYOjxTCrz+gXi21KF2F/0Cn88FeQYBDbarVi1Ez2Jc9pxOErd0WgA6mJMnUfOzTqaF3BmqeR0kGgsWGoO9/YcOr2DLcKe3APbSY1Dp88P+BBDdtng6devK9WMXuIVX4tvwOpdqlTVapbBPGd8SAuZkzuBW7HNBxdGusbhblWfSwMj6lmwxsT/id1xdqHXqw2dSvus2xoyi71r5pS5sayXhowL4FVq8N6+TWF58WtTTpy2VwsZkGIZanwZmMN/MRCgL7gDUpJRcO6FhKIBN3fU/2Tx5cn1PXP58+fgCWixBqYR/ygTsAGu3gBxkAroShZbMaT6j4L06/UgrfSTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 16:10:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8636:EE_ X-MS-Office365-Filtering-Correlation-Id: f16e1733-1dd6-41f0-6704-08db199de4ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UbwY50GfNBzXxZKADirZnEHlpfgW+L3mWdimnZCDEEBav1qJlNP7gtFmhZUC9I3hSXSFQjovejGrTPR6wAu8q8ta3M7rjZIx30LSKuaNK7/rKi0ECwa3wlwnLzIjOtf1estUqLqO7s8YrZTnT/oQ+l/WNiyjBil5AFnDCYonwY+3hLRMiQMi6IWTF90YM24y+QI0J707ueYjBkOCnbLx5P5J231ngbHcT5IGh95rzmEsFXyrOU87nLzbRgIynaoMgwcxUKKS3m75vmzpmZNyBDDPIpdqeDW0DbRbMzgp4mUjkDcgtombJ9QCfVxDYmMasl7nsyQf/4yDS1xPES6LSz/x3hKYIB9+SzRJbRBJ/Z4E8DzNaIM4QkhgaEcYxSTjrBde0bvjPkgwehHzIHwIrP77dOcSVjycFoRhV9ItsMn2UHC/ZDkQbDlrPgXv8FQCeUUfVwxgM0DDtdHTeygEmdT1d0c/0GhsKvoJbgZjwt+X9GYVfS+MEzSXarD00wWrj0IZLPVQyAdYJiVI2Bc2LQIm6q2JciNOLdSXSXlddMHpFgxXwMGqYvo124R/LKpe2jGT4AKyWN/QROALtk4dKUPn+GgQJzmECxrlw2+kAKM2DsX1x+h7DumVAMSHCFywEyj0GB93gcyDobjhQZVcz1TO3DusRgek+zv7tITAigpto6m2AlCtODB8U7tGfEnPTPB05nhv7ShclF5JOC3UfKAoy0cpKdtkb+JQ7fKdbWU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199018)(31686004)(6916009)(36756003)(8676002)(66556008)(8936002)(66946007)(2906002)(66476007)(5660300002)(41300700001)(4326008)(31696002)(86362001)(38100700002)(6486002)(316002)(478600001)(83380400001)(54906003)(6506007)(6512007)(2616005)(53546011)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjZrNHpwdkFsNjFxWmZmbnlYc2FXUmlFMHlMd1NjWU5DQVJoYVhMejZvOHdm?= =?utf-8?B?dmY5czNlVFhWODZZYUV5K2VaMDJoRExtQkJETlRzenJkZUxDLytrTitsYXdy?= =?utf-8?B?YTduc043dlBpcGk4TkhqUU1xTXI4OHp2bHQ2WmFUQ0dGN094czR2S2ptaUp4?= =?utf-8?B?c2dyR1ZBc3lUTFhkVWdzVHZsOGRDNkJEK3ZEc2VrZmVFUW92VmxwZWwySGc4?= =?utf-8?B?K28wR1NsYTRZc09VL210Rm5GRThVSlIweGtZUlNVYnZUK1BaVFVMZS81VUI3?= =?utf-8?B?TldpdnIwRndGWFVDTjZQZEJIcURXbEFnRzNKNHlGeXhJalhHZ1kzd3dNQ04x?= =?utf-8?B?YzRabDhTUFlhbFlWamplTGFyVk9UZmpSMnN2VHorb1daa2ZXSkI3MExRMjBL?= =?utf-8?B?ZVhZQkVpTkwrMVRnY2F0OG9vbjRyNk4xaEsxeG5LRnBVOS9FN1g4cncxSzBp?= =?utf-8?B?YTE5SnVTbFlDVnZORFB1K3N5eDZCbGdoTjYvSmliVnhDZlJIcXJEUytKUWkx?= =?utf-8?B?a1RIM2RsUlBtalN0VXdSbjkzdVNpeXZSZDNiZUdvN3BVNlJYSnhTNngvTm8r?= =?utf-8?B?UlZOdWIwZFZiRHNDamhJN0M0bUl0SEswVGxob1I2OTVUcDBQeUg4U3FCYXpU?= =?utf-8?B?Y1QyMm45d3NOK2tqSFJBRGkyR3RWTVFlYUFXVEZWOFJzNjZ5QkIrYlRTQlpS?= =?utf-8?B?VWx0Q0NOUzYwZEdZTzZEWmZMRzdyVkRXeE9YNlRmYjZnU0RXZDQyOG1hdUZv?= =?utf-8?B?dHhIN3ZhMGxxaTNzeXI4NnZROWNDdjUzeWZob0IyQWdRQUZtaWwrVVFZZXF0?= =?utf-8?B?V3liQ1dBaHhjMWJOazIxWmd2bHpya1VBcWNUd0RPZmpKa3N5UGZ2dWxBVU1r?= =?utf-8?B?dXNraWxycFpQMDI4NTZQalIzN3hWbGN0S001a09wYUFCR0NNVGZscGt2cC91?= =?utf-8?B?dTJYMXBzVXJ6UHpDUG5tMlF1eXM1dGZmR0NwdUVaS3F3K2RZZTFCRzFXTWNM?= =?utf-8?B?NW5wL1habWlHK05yNS9kTlY1SDYrU2FaMXZHWEhKMUpBL1VaUyt0ZllVRUJa?= =?utf-8?B?TmdTa042eFlsOE82ZzAzSW5venRxejRpeXdxcFhEclJENWlQd0xkUDF5WHNp?= =?utf-8?B?UjNBTGdGM0gyVzZ0Q29ZcklDQU53eTJsNmxmODRnOWJsNE4xRzlmK3ZQWU0y?= =?utf-8?B?VzRSRG1zU2kvdTA2a01YTXFON2FvcGZFVE92azhtcGlvQkZObDZ2S1VtZWJI?= =?utf-8?B?eDdTV0s0eUwycUpFQXRjaExCeHZFN1hqTmR4Y25uVVlLdFpnWWFUeFlVSGxz?= =?utf-8?B?L1lDSHl3RmhNY0ZiRDNzTTJya3lmTCtYVWo3QjUwTlZLVmh2K3p1RDYyMHU5?= =?utf-8?B?KzkrRnZlMGdoanh5K1hlT2gxM29ic2t6a2dtS1Z2bE5ucXlLSGc1UkJyWWpQ?= =?utf-8?B?UHFRME5IUng2VHhsZTFsSG5yWldkSHFUQzEzOWN0V1h2ZW55VmJTKzFtMHVm?= =?utf-8?B?bEc2U3pzRnJoaEl5d0V6OWRmK1ZGVFlWZ0VYS21PRHBUbTZuckl5Ui9zZW1Z?= =?utf-8?B?YmNLa2wvbWsyTUdGSUoyczRxU2xGN2VoSmpwSytXYjhTZm1mUkxxSEpBWEE2?= =?utf-8?B?a2VhL1o3NjlhdHJQTU05QUFhbkdNUHdmdjJQSXNrMXBJRW9WenhkZ2kyVGp2?= =?utf-8?B?RVdQZmZIamdyb2hHNGJtU210czFGcWFPQkRXL1BYUXNUUUVuWHMrQnVVNlk2?= =?utf-8?B?QUhuWEJnVEZ5SmZUNzhDelJQcXJ6aUhyYU0vejQzUUVBYUdGN0FFVjJVQnZl?= =?utf-8?B?UlRQTlh2QTZxRXMyRnYyeU9WNm43YVhPbEVwVUhZVFV5OGo0QURra2dMa3Zj?= =?utf-8?B?UTU2R0oyTnNLS0NTMzZ5N1FMelBXWTJmQzB2Q2NiUWZUMDNIakFIT0ZESHZY?= =?utf-8?B?UVRMRm01NTJoRG5pN01CRkZDSko2OUkzWWo1OFdhcnZjT3JvcEZjeXpON1ZO?= =?utf-8?B?aTQ5dUFZM2Fhd2hjajlWeEw5QW5sRVBlUFVmU2V6VDFNQS9nM3VnSENOR1JY?= =?utf-8?B?aStnaWRSQ251OUd4bEx2bTVwNEU2dk1haDRrZDVTVkluSHo4ZVNwSFEvSGpm?= =?utf-8?Q?78P197fhH/uhk3ZWUbd4OlmU+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f16e1733-1dd6-41f0-6704-08db199de4ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 15:10:14.5277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CkL8wws8JS7nndlLk8pnFoewNOCpMsp/uW90pNrA07pSbUaolQrC5JC05BxEHJJb2xd+rHqqzQQ6N8U90IeseA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636 On 28.02.2023 16:05, Xenia Ragiadakou wrote: > On 2/28/23 16:20, Jan Beulich wrote: >> On 27.02.2023 08:56, Xenia Ragiadakou wrote: >>> This change aims to render the control interface of MSR intercepts identical >>> between SVM and VMX code, so that the control of the MSR intercept in common >>> code can be done through an hvm_funcs callback. >>> >>> Create two new functions: >>> - svm_set_msr_intercept(), enables interception of read/write accesses to the >>> corresponding MSR, by setting the corresponding read/write bits in the MSRPM >>> based on the flags >>> - svm_clear_msr_intercept(), disables interception of read/write accesses to >>> the corresponding MSR, by clearing the corresponding read/write bits in the >>> MSRPM based on the flags >> >> In how far is VMX'es present model better than SVM's? They both have pros and >> cons, depending on the specific use. I'm not asking to do it the other way >> around (at least not yet), I'd merely like to understand why we're going to >> gain two new hooks (if I'm not mistaken) when we could also get away with >> just one. > > SVM approach always touches both read/write bits (either by setting or > clearing them). I thought that using the SVM approach on VMX could be > considered a functional change (because there are parts where VMX > assumes that a bit is already set or cleared and does not touch it). As per my comment on the last patch a question is whether both actually need to become uniform. But if they do, then the new model should imo be followed right away, and that VMX'es simply leaving bits alone when already in known state. >>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>> @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); >>> >>> void setup_vmcb_dump(void); >>> >>> -#define MSR_INTERCEPT_NONE 0 >>> -#define MSR_INTERCEPT_READ 1 >>> -#define MSR_INTERCEPT_WRITE 2 >>> -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) >>> -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); >>> -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) >>> -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) >>> +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>> +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>> +#define svm_disable_intercept_for_msr(v, msr) \ >>> + svm_clear_msr_intercept((v), (msr), MSR_RW) >>> +#define svm_enable_intercept_for_msr(v, msr) \ >>> + svm_set_intercept_msr((v), (msr), MSR_RW) >> >> Please avoid excess parentheses. Also could you clarify why you retain >> these shorthands when you don't use them in the conversion that you're >> doing (e.g. ())? Are you intending them to go >> away down the road? > > Ok. > I did not understand the question. Which shorthands? svm_disable_intercept_for_msr() and svm_enable_intercept_for_msr(). Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:18:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503474.775748 (Exim 4.92) (envelope-from ) id 1pX1jg-0002OE-5b; Tue, 28 Feb 2023 15:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503474.775748; Tue, 28 Feb 2023 15:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1jg-0002O7-2Q; Tue, 28 Feb 2023 15:17:48 +0000 Received: by outflank-mailman (input) for mailman id 503474; Tue, 28 Feb 2023 15:17:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1jf-0002O1-M4 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:17:47 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e2fd3be-b77b-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 16:17:46 +0100 (CET) Received: by mail-ed1-x529.google.com with SMTP id h16so41419203edz.10 for ; Tue, 28 Feb 2023 07:17:46 -0800 (PST) Received: from [192.168.1.93] (adsl-6.109.242.139.tellas.gr. [109.242.139.6]) by smtp.gmail.com with ESMTPSA id 13-20020a170906328d00b008def483cf79sm4516026ejw.168.2023.02.28.07.17.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 07:17:45 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e2fd3be-b77b-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gl/5X5VFlbYIWjZeUbXJ6WkNiv6V1nLY6UVlFnKIcrc=; b=Q1CmWmRYrNKLCt662iblWnR6DP/B5faxn56clA/NLlohfNRlbKnssl3uG5kSEOj7FZ LUOewKWggW4omFIy/9raz336BdTxsgdlu3g3Is2cLdcUNdCMgv/DUGdk6a4IbjPgu/8R 4dCvc6LklHUzLftnfCQ+pC9yPeqaYpz5ZzqdONeGtpoWzpSNBAGfOdsYjL/MX83NNDcO R7gsXXhrCgbkgi0CXag416zt9XKXZ/G0YTgRbbMOgARPcK6K+v3bhMO+uf1FYdaUWPK6 dxhsglvoe6UhvuRETqag5W1/taLxebkVN005qian8X44etKlxzSqmmwLLy4+sWeWW0QI XGnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gl/5X5VFlbYIWjZeUbXJ6WkNiv6V1nLY6UVlFnKIcrc=; b=DudUXEC6mGx3Gno48oST27kh4lDaH33uzRH17CVH9MNBJ9OP8S/PZ8y9frrQHOZW1S UfAZec/Y83jmsCTCno+kPoT0irFAlbKM/FllqnHGFxDUthSrqGMOxf9UgoQSCDut0F7e ikWrYZLPiF4cjJiNsZ+Ad0m5Fp4DgS9DGrlvzD6+IjqTVIMD2vwgbU5lKUyBYCuTmd/+ MCYOHHpzXChRPB0dS/z8L59q/rR4FLyUHi0tJVwllGjkEjYKVXj2qpLcby+XOpGHQ4JG /nQhjINwmuEF0vJdXsF9uVEEOybCIq1XWQAAhYzqfujUmnri7DsgUpOHfCmvleuCpAFH yXXQ== X-Gm-Message-State: AO0yUKW1AopFTQHFCf5K77APCY6g7Dw5GcmfApyTFMYtOKSKMecyKP2f RNNokwVFSSLcswHKZWU9ySM= X-Google-Smtp-Source: AK7set+L0rKxtfOdMb2E2jsMIYUnh3bgBE4P6e+3JgdPsGU9bRu1xmrknUSJpkLGXg9nTAgiqgQ86A== X-Received: by 2002:a17:906:1e4a:b0:88d:f759:15ae with SMTP id i10-20020a1709061e4a00b0088df75915aemr3370308ejj.42.1677597465956; Tue, 28 Feb 2023 07:17:45 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 17:17:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/28/23 17:10, Jan Beulich wrote: > On 28.02.2023 16:05, Xenia Ragiadakou wrote: >> On 2/28/23 16:20, Jan Beulich wrote: >>> On 27.02.2023 08:56, Xenia Ragiadakou wrote: >>>> This change aims to render the control interface of MSR intercepts identical >>>> between SVM and VMX code, so that the control of the MSR intercept in common >>>> code can be done through an hvm_funcs callback. >>>> >>>> Create two new functions: >>>> - svm_set_msr_intercept(), enables interception of read/write accesses to the >>>> corresponding MSR, by setting the corresponding read/write bits in the MSRPM >>>> based on the flags >>>> - svm_clear_msr_intercept(), disables interception of read/write accesses to >>>> the corresponding MSR, by clearing the corresponding read/write bits in the >>>> MSRPM based on the flags >>> >>> In how far is VMX'es present model better than SVM's? They both have pros and >>> cons, depending on the specific use. I'm not asking to do it the other way >>> around (at least not yet), I'd merely like to understand why we're going to >>> gain two new hooks (if I'm not mistaken) when we could also get away with >>> just one. >> >> SVM approach always touches both read/write bits (either by setting or >> clearing them). I thought that using the SVM approach on VMX could be >> considered a functional change (because there are parts where VMX >> assumes that a bit is already set or cleared and does not touch it). > > As per my comment on the last patch a question is whether both actually > need to become uniform. But if they do, then the new model should imo > be followed right away, and that VMX'es simply leaving bits alone when > already in known state. But the SVM implementation does not assume. I can do it and remove the no functional change part. > >>>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>> @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); >>>> >>>> void setup_vmcb_dump(void); >>>> >>>> -#define MSR_INTERCEPT_NONE 0 >>>> -#define MSR_INTERCEPT_READ 1 >>>> -#define MSR_INTERCEPT_WRITE 2 >>>> -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) >>>> -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); >>>> -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) >>>> -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) >>>> +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>>> +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>>> +#define svm_disable_intercept_for_msr(v, msr) \ >>>> + svm_clear_msr_intercept((v), (msr), MSR_RW) >>>> +#define svm_enable_intercept_for_msr(v, msr) \ >>>> + svm_set_intercept_msr((v), (msr), MSR_RW) >>> >>> Please avoid excess parentheses. Also could you clarify why you retain >>> these shorthands when you don't use them in the conversion that you're >>> doing (e.g. ())? Are you intending them to go >>> away down the road? >> >> Ok. >> I did not understand the question. Which shorthands? > > svm_disable_intercept_for_msr() and svm_enable_intercept_for_msr(). Are you suggesting to replace svm_{en,dis}able_intercept_for_msr() with svm_{ser,clear}_msr_intercept()? svm_disable_intercept_for_msr() is used in svm.c and vmcb.c. -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:25:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:25:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503483.775757 (Exim 4.92) (envelope-from ) id 1pX1qU-0004Ei-VX; Tue, 28 Feb 2023 15:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503483.775757; Tue, 28 Feb 2023 15:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1qU-0004Eb-Sr; Tue, 28 Feb 2023 15:24:50 +0000 Received: by outflank-mailman (input) for mailman id 503483; Tue, 28 Feb 2023 15:24:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1qT-0004E8-Rq; Tue, 28 Feb 2023 15:24:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1qR-0004Bo-TI; Tue, 28 Feb 2023 15:24:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX1qR-00057p-Jr; Tue, 28 Feb 2023 15:24:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pX1qR-0006UE-JN; Tue, 28 Feb 2023 15:24:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZLGAJeq2r2ERaPdfv3i4dp3VumT4XGyc5LpEXN7g3Bw=; b=RrToyUReXWLZEKXrO43XW58Bku PMWlRDNXE28yzuGEFryGZKffZzDPFfAhgGbHjp6ren6JDES7p59ol9YwUIkaYfdPkAA3O82K9m//3 Kmqjde9/Th2WwL25CoAw/UazLc7bsjKyvuCd0J2QgB6w4zqAfE+j8evocNlZ6EmavGDc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 178733: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: libvirt:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:build-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):starved:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):starved:nonblocking libvirt:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: libvirt=d427102fbd690cb2f43dbf33751cc5194a5b16ce X-Osstest-Versions-That: libvirt=e66469095d4a6dafc7e482894321e1e10c734e54 From: osstest service owner Date: Tue, 28 Feb 2023 15:24:47 +0000 flight 178733 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/178733/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 178422 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass build-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 1 build-check(1) starved n/a test-armhf-armhf-libvirt 1 build-check(1) starved n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: libvirt d427102fbd690cb2f43dbf33751cc5194a5b16ce baseline version: libvirt e66469095d4a6dafc7e482894321e1e10c734e54 Last test of basis 178527 2023-02-26 04:18:48 Z 2 days Testing same since 178733 2023-02-28 04:20:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik Temuri Doghonadze jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf starved build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt starved build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 starved test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git e66469095d..d427102fbd d427102fbd690cb2f43dbf33751cc5194a5b16ce -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:47:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:47:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503503.775768 (Exim 4.92) (envelope-from ) id 1pX2Cd-0007RD-RW; Tue, 28 Feb 2023 15:47:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503503.775768; Tue, 28 Feb 2023 15:47:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2Cd-0007R6-Of; Tue, 28 Feb 2023 15:47:43 +0000 Received: by outflank-mailman (input) for mailman id 503503; Tue, 28 Feb 2023 15:47:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2Cc-0007R0-4S for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:47:42 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3acd3364-b77f-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 16:47:40 +0100 (CET) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31SECwMW015599; Tue, 28 Feb 2023 15:47:37 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nybakpm4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Feb 2023 15:47:37 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31SFNQVp001108; Tue, 28 Feb 2023 15:47:36 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ny8s6qh4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Feb 2023 15:47:36 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) by BN0PR10MB5142.namprd10.prod.outlook.com (2603:10b6:408:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17; Tue, 28 Feb 2023 15:47:34 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988]) by BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988%3]) with mapi id 15.20.6156.014; Tue, 28 Feb 2023 15:47:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3acd3364-b77f-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=nHoTHSPKoUTNezGxBO1ya0A4TnSG78cWgEqdK33CDIM=; b=qQa/dJ+kQuf8Bm14lu6Ak07F2r/MItLm6GNJwDi3ypB3g0gbAldBEC60UaUNZFkqu6hh X/em97u95NNCkOo7B8wz2Seaq42ozbFFmyxZWBysA7XXBxPRjLMNqTUWUjNBBHFB0FL/ moMKtpkGE2/z0puQW899sgn1eSL7jCfFSvdlCH5RrGdXV/ZA4uts+VJRj/zLm83C2e9G iG3g26kVlvyg6qOb2vqFUWruqhVN0XbImwvZAiOESmYOL7Oyf4FQ3/W3PX4XrYjVs2j5 9mYSzi+hR/BAqzlkLtxCS/F1F0gUGFl3HEvd7xTRbJrhC+Pzf4b2Jcosm3GznzHmKres Hw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QR0/PxIwYfVa/dWAFcaPJO0NSH8DMfCehcf7Kzip1/dlzhMoC9fOWSJQSa8Wi+pAbPX+lOUoVmD+sQsUf8jhhiuMY3VzzDVRuRy5DLgpTZ0bgB5RWOmz4+duJfjuImIuFM++r5QICDrgRUeVXv/UyAQKs5TZjOEzyYKIB3vSyQnaN9AsP1KHjqVDIEXUiIj/G8Uj+Qhb/c6qDdMOSZMGN4YWWXUu1idC1BeLZWl8/bPF6ncpuOAjtJpTKGgvFhKiKD149j4H/6bpDAQE1+aiPy/et74Kf0wAzmqhRxdVIJ/UhKnBCRTA2tzr04gJ2ahvB95DQcmIvWtZQvNSN9kb9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nHoTHSPKoUTNezGxBO1ya0A4TnSG78cWgEqdK33CDIM=; b=h+7BdAoN8I7Za6QkJt+hT4tAMMqX+UC4cpKSxk+yUVRn+/9XD5WlJfZzFO0AA3Ze7pNte8CXwEarfrFUPnhVsI1+KofK3pYECgyUaRgeawLTelFLSbY5WUYzHwGljk6tLvyonfcM9/pUSVD0yGBjpO8E0Jij0oTpt8RUeGdgOqKxGrFGGij9jMMlvw0lS8LAhqkg6sje+tI5qdf+CU25FhPaEA/J+qeNpOVPwPJQokg4NaW48g9SVs0oyX0y753ktj48VFy9UQix3LNJKAr9khnaVEM6fg7kYVqQajiNiDzR2xqQME6zzkx4fzR/URMVhdTTjO5IKi/7xt0SojWnJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nHoTHSPKoUTNezGxBO1ya0A4TnSG78cWgEqdK33CDIM=; b=h76G2Sqjy0XFO8HQvkLCoRnDSKOitRs0oXc3YWfPJJCLBYsjd5ERCQWbn1YXRMge2GIchLKtR9LBSf6w89rnlG5kBUtqJySooH/MmVsN+Zg9k/Yv12ZTYf50UB/e7zH/mgaXPzS0Fp9FM3MPM3bT5Kj6fj8L9TTd1D79SMpXr1w= Message-ID: <87e0c07d-5e40-0855-6a9b-28239c9c66ec@oracle.com> Date: Tue, 28 Feb 2023 07:47:24 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Is xl vcpu-set broken Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Boris Ostrovsky References: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> <77fd3c1e-603c-ad46-c518-3b5b3311e9f9@citrix.com> From: Joe Jin In-Reply-To: <77fd3c1e-603c-ad46-c518-3b5b3311e9f9@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0472.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::28) To BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3160:EE_|BN0PR10MB5142:EE_ X-MS-Office365-Filtering-Correlation-Id: b65efcd4-bdea-4e12-bfec-08db19a31b41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tW6I9AvT4vJgKAzWFETIvfu0M3duB4f3DpCKqiI0HE8zd4gdYUGp6wyvSltE2HPY8m98UzeAx0q9uVAQS3+pXtjxv3PuP1AISkDIr4polH5v9eg/0LhFE17o4YOR8PpOvDSBWcCvMGmlPOM7sd1MGCd4w4XIezh+yCXPsslerzhy2kC72fLyqllMEm5jsF7waSXj7hIzzkyUenP8TVXXLBlHRQ9wHD+cfqe36VyYwrDuzUI+svKe1FppjUuLRIZFilATPJgpvd8EguvsI/e0PjMP/VCvAOJy3mCPtNTsu1mX7zKYqlw1qY1adaCvSIEID2j/JGc4daz8Kh0wUCKJJPp2LGM1zdT4Ad0LUnrUeeI3bU6HypSD/240762iOr45s0WFeu56huU01r6Thg0gibJzSrpWq/zcBal7OFtUCQUPoZAcRuRtSMvsFHoybf6RtdgMiREpVFl9elHshCeay7IEyXKcnBgcGbFOoTRAOAWcV31ymzAm4HO4zAKWIUv7/UknjsuJJfT7w/cu2bWOTIeZVoxXKHX7uHw9b9kSRvcAh/SA3/t6d428NRGh9N+9ACjwam1pjl4atA1CTe1GAfe9hBCHl1sKglO1Ds+XfFJDricLV2tW728NndU6kHRTbWJXPdXtb/wfKvyVOoHLS2oQN37Nnv4bBhNFT1FUYXq6YQZGwaIAVLOvAjnRqJPylyMHLHQ6Npvz/iljo7tAN3k0IQyeeuiIGjxux5MyFJg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3160.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199018)(2616005)(3480700007)(38100700002)(83380400001)(6486002)(36756003)(107886003)(2906002)(6666004)(6512007)(53546011)(6506007)(478600001)(86362001)(26005)(186003)(31696002)(44832011)(5660300002)(31686004)(316002)(8936002)(41300700001)(4326008)(8676002)(66476007)(66556008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXBidmg1SFVHd2RCNWFqZUh6L3hlN2owdSt3Y0hFNFA3eVU4QnA0d0dla29r?= =?utf-8?B?bFdrd1l6eVdxLy9EaytvUjQ5dHkzUFFRSUdxd1BGZkFrcWpDTHBEbVZiSExP?= =?utf-8?B?djVQWVkvblR2RjJqd2ltU1FzY2EyTFFEdDdqSDNXU3FXWDZIeXJ3WWc5ck1P?= =?utf-8?B?cXJMTUltd2dhdXNhNlZvc1JBci9sNnV5UWVXL0t3bGNaZzJudW9QNC9GOHh4?= =?utf-8?B?eGt3SDlFckM2cVNDbk1vTHV0S2N6N1Q2Z2ZpTTgySkg3TWJNMmlaRDdWanlk?= =?utf-8?B?WkJKYlcyalRMbXFLOHVRQTlqSUxYUjQrbC93eW10NmpqVEthNDVmZENQcmh6?= =?utf-8?B?dDYzazJ1ZGxLSUFnMkttclBOT3dFZjJhTVNUTzFuNEgxRGtuMUt4M1ZiaXNo?= =?utf-8?B?ZDZnNEFNem5LSXI0WFE1MUhLd2ZSRURTSUxRdDFBNUZTTFQ0TzNGUDFreXQz?= =?utf-8?B?WmwwcTF3Mkl3VGlyMUdYVDAxd3BQMHRoM3NnTGp0UXNTYlZFdzRndTRVN3JP?= =?utf-8?B?MHpSY3JvS3pOU3ZIaTlHaU1jbkVHZFc1UlQrTUFGQnYreWg2MWw3cW54Ti8y?= =?utf-8?B?QnpXTktTOFkzQUh1ZW5jeWNWcUowSlJKMnpPcUF5NHo2eks3RzM4OXI5STRn?= =?utf-8?B?SGtEdjlNM3RwYWxOR0NMcThIemZRZytPbTVpcktRZ0JYL09RWTltK1lYWkxr?= =?utf-8?B?SWMrTGRjMzM5bUNCU3hzYmdsdTM1UU1iUDRvQU5sWmJUTGF5bWY5LzNKbXpp?= =?utf-8?B?RTBKRXBKOTVhV0hWSmlvNUovZFlMejk1aGs0c2dpbW9xWk5GbGdTeHZzUlFa?= =?utf-8?B?bWtKMXRrNDVhTDhOa1IrOUdlQjIwVlZja1oxc255V3c2V01LNDk4S2RNdm40?= =?utf-8?B?cU1LR0VEWlpUNVBQSzArQml3ajQzLzJFOUxnSWtVbVJsNkErbkZqMmVDdlVQ?= =?utf-8?B?RHgzOHIvRW5JNFZkMmRML1h6VFlKS0RvR3gvbzRTZm0wWWVzNytENlEzdXE5?= =?utf-8?B?M3lhZXp0Wnp0NitLTHZ5SXFwUUt0TDM0R3UvRG5TZW5VY2dxY2U1K3REYmY5?= =?utf-8?B?ZjBhNFAxV2FkRW1ud0dxRnM5ZkJiRkJhTVRrOHdqSzdDT1IrMHBXOUYwWmpL?= =?utf-8?B?cjZha3dvWEdsVC9nNUhiUmMyRDNyNzk2aTRyc3h1UzBkN29YbDBFU2xtMnJK?= =?utf-8?B?OU1WVEZCaE10UGxRR2FLcFFEaWNzVW9YRHMvWjh6S0hpSUo1VEttcHdTMlg0?= =?utf-8?B?YXdzTmRHSlF3VlI4NEdROUhveEVDYkt5WEhkRjR2WFlJRDdVaUsxb0xENHlS?= =?utf-8?B?c2NyVkNQaUU5SDF2bE1JZ1UyMldtNFo2MTV6VWtFSWxmdHU5aGJoVW5RalY4?= =?utf-8?B?S3RHdFpZQ0t0cDFSY3hUYmMvTHA2TW1ZRjBpSnFoSG1DanJIbXlpVTIzQitI?= =?utf-8?B?aCtLbUw5WFBjcFluQVU5eW9CVTNBN1lJWWluWHBEYmNLUHkvS2VTcGcwZHpW?= =?utf-8?B?T2dJTm1mQ0dWSC82NVRLaTJyc0hxWjZvOGVkWU5yOUw2dGhmRDJmZi9oMDdF?= =?utf-8?B?WVpYMUNRQ3BjTnJ3OGtFeDBGRzFqY29XMU5PVXBSZ2xCc3E5MFBPdTdDQmkw?= =?utf-8?B?Ky9jRmJoR25JZG10WHFUTUFiRWo4VlVwejQvTXVSNXFDQnNhMHlUZ3BDNmRS?= =?utf-8?B?M0g1TlRXVHF5R1kwdTg0d1N5dlRXSDQwdFJFTkNPSEJyeXdvU3dVa2liVWRO?= =?utf-8?B?amhJQVlQZUpmRmhHb3FyN0ZrbENqWjNNMzROTmNYVW4xQVNwNytmQml2Vk93?= =?utf-8?B?UDhEUTc4YWFERUpCaWJUZ2JGMmdNOFlXaXljSEN0UEhvNllGK2M0UHEwY3V2?= =?utf-8?B?a0Z4ZHkrMzlKODVaY3dGc25mSUV4dVM2N1hVQVZFdkZ3TjJSRCtNNUlndkdq?= =?utf-8?B?ZGh6U2FGTzBFTXRPeHFtVW5Eb2Z4QjU1eHdzdGROekpBY0l6azU5RXJxUE5w?= =?utf-8?B?TEFveGdTWjJIbHNLQmpIZHJGUStVVzNMWDhEYWVsbE9QMlBFZzVqalBWMEoz?= =?utf-8?B?SXlOUUlheE1MS0F5MHJJNmRFR1dCbE4yVlFZNFNqeCthaU1OdFFGcG1TaXJU?= =?utf-8?Q?hcMSdla4K6+TnoKzFeGNUf+8L?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Q7hJ4StEUV5KLJF35xAzGbIGe1jTB/HJvRyM+yNKCSD64Atb2VjI7tQ25XioBwpnPNcb/Ujx6E7cZOuyvACAfg1m4CruohedNtiVzqXhwBHVvetOpmYu/a2G9EWVWyEEwVqmS59iBSO7RiaNd0EOQgVIwNreHDKUCVmIqt46TBNC3THMxE3XjdebJbBz7BeB8lx7th34VTlnI0gb7mvjf0jYjBCMVE7l1MsMA787h8y13eCwI0SMgQpwtrz5lk/7f72Y/OrCzoS0VPgD4KKHq571Wmz1AnhgK0/6khh/9cvnoh6lMh5pkcm2Pg+/l6pdcYrmIRN77pQ0/kA12+RqOndwv59SNRQ9rtFd8EYY+mFMcQqKxInY1YP4QCKM4+mJ4YKBRIm/01sUk6WufSB5MkgL6u6MYEr7/gWrYaNhMb/UrSZ5M+x4hC+YhZvuUOxB0RUBoc7GPXLXeE82clgGRcLFk2qsTINx2lR6Yu7KZF+pqapz2skebFHFhT+O9fwme0jZpscU6Nc3yNxePEV+ELSAVHXWrM7orsZ3gpbipIX+Pm6vJVH3MEovtDxuXCj5/TdSUdJCXskiGBTni6n3Pu0y07dHN2nD2AunLIS9VMjeD4QlNh7v79jc7Uq7HhHpKMV2S81jdMTfuiksI3owl5gJGe5ZrK4GAmv1uxy3vFpCMKpZhxIT4NpfRBv80acQSC3ZBh8H5T05pHDxMTKqnSq9J9zkcizbKVbYPoL+/87Q5xYDZ1j4ufdko7aECnl3gXgj2/5sg1pXz1uvOEDp8sdDIMn3JcLG/wF1WjBG0P3hrijJ2815lTn1zfVNeBwc X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b65efcd4-bdea-4e12-bfec-08db19a31b41 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3160.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 15:47:33.4151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nj3wx5jwHtT1v4aHbBH3aqXXUEEcj4PL7+7S9KYoL6dW+hG0IzXjShEvWHgWOwnY23H/cIL6995+LyhAWJgwww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5142 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-02-28_13,2023-02-28_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280129 X-Proofpoint-GUID: TnCX-Hj-UF4lfUYBxhzirBkuTin7Pef6 X-Proofpoint-ORIG-GUID: TnCX-Hj-UF4lfUYBxhzirBkuTin7Pef6 On 2/28/23 12:49 AM, Andrew Cooper wrote: > On 28/02/2023 6:44 am, Joe Jin wrote: >> Hi, >> >> We encountered a vcpu-set issue on old xen, when I tried to confirm >> if xen upstream xen has the same issue I find neither my upstream build >> nor ubuntu 22.04 xen-hypervisor-4.16 work. >> >> I can add vcpus(8->16) to my guest but I can not reduce vcpu number: >> >> root@ubuntu2204:~/vm# xl list >> Name                                        ID   Mem VCPUs    State    Time(s) >> Domain-0                                     0 255424    32     r-----     991.9 >> testvm                                       1   4088    16     -b----      94.6 >> root@ubuntu2204:~/vm# xl vcpu-set testvm 8 >> root@ubuntu2204:~/vm# xl list >> Name                                        ID   Mem VCPUs    State    Time(s) >> Domain-0                                     0 255424    32     r-----     998.5 >> testvm                                       1   4088    16     -b----      97.3 >> >> After xl vcpu-set, xenstore showed online cpu number reduced to 8: >> >> /local/domain/1/vm = "/vm/aa109ea0-2fde-4712-81d8-75f73bd73715" >> /local/domain/1/name = "testvm" >> /local/domain/1/cpu = "" >> /local/domain/1/cpu/0 = "" >> /local/domain/1/cpu/0/availability = "online" >> /local/domain/1/cpu/1 = "" >> /local/domain/1/cpu/1/availability = "online" >> /local/domain/1/cpu/2 = "" >> /local/domain/1/cpu/2/availability = "online" >> /local/domain/1/cpu/3 = "" >> /local/domain/1/cpu/3/availability = "online" >> /local/domain/1/cpu/4 = "" >> /local/domain/1/cpu/4/availability = "online" >> /local/domain/1/cpu/5 = "" >> /local/domain/1/cpu/5/availability = "online" >> /local/domain/1/cpu/6 = "" >> /local/domain/1/cpu/6/availability = "online" >> /local/domain/1/cpu/7 = "" >> /local/domain/1/cpu/7/availability = "online" >> /local/domain/1/cpu/8 = "" >> /local/domain/1/cpu/8/availability = "offline" >> /local/domain/1/cpu/9 = "" >> /local/domain/1/cpu/9/availability = "offline" >> /local/domain/1/cpu/10 = "" >> /local/domain/1/cpu/10/availability = "offline" >> /local/domain/1/cpu/11 = "" >> /local/domain/1/cpu/11/availability = "offline" >> /local/domain/1/cpu/12 = "" >> /local/domain/1/cpu/12/availability = "offline" >> /local/domain/1/cpu/13 = "" >> /local/domain/1/cpu/13/availability = "offline" >> /local/domain/1/cpu/14 = "" >> /local/domain/1/cpu/14/availability = "offline" >> /local/domain/1/cpu/15 = "" >> /local/domain/1/cpu/15/availability = "offline" >> /local/domain/1/cpu/16 = "" >> /local/domain/1/cpu/16/availability = "offline" >> >> But guest did not received any offline events at all. >> >> From source code my understand is for cpu online, libxl will >> send device_add to qemu to trigger vcpu add, for cpu offline, >> it still rely on xenstore, is this correct? anything can block >> cpu scale down? >> >> Appreciate for any suggestions! > Your mention of Qemu suggests this is an HVM guest.  Can you confirm? Yes it's HVM guest. Thanks, Joe From xen-devel-bounces@lists.xenproject.org Tue Feb 28 15:55:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 15:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503508.775778 (Exim 4.92) (envelope-from ) id 1pX2Jc-0000mo-KR; Tue, 28 Feb 2023 15:54:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503508.775778; Tue, 28 Feb 2023 15:54:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2Jc-0000mh-HY; Tue, 28 Feb 2023 15:54:56 +0000 Received: by outflank-mailman (input) for mailman id 503508; Tue, 28 Feb 2023 15:54:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2Jb-0000ma-Kk for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 15:54:55 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e0185cd-b780-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 16:54:55 +0100 (CET) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31SDwJ54028403; Tue, 28 Feb 2023 15:54:47 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nyb72ej26-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Feb 2023 15:54:47 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31SFKZT2032984; Tue, 28 Feb 2023 15:54:46 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2043.outbound.protection.outlook.com [104.47.57.43]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ny8s6yqae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Feb 2023 15:54:46 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) by SN7PR10MB6329.namprd10.prod.outlook.com (2603:10b6:806:273::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.14; Tue, 28 Feb 2023 15:54:44 +0000 Received: from BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988]) by BYAPR10MB3160.namprd10.prod.outlook.com ([fe80::d2c0:2a72:2c9:e988%3]) with mapi id 15.20.6156.014; Tue, 28 Feb 2023 15:54:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e0185cd-b780-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=YDm0Dstv38waI9rc4uGBTqJnw63Novhl3X7LOfMPgXU=; b=RCoDxcLU9ad4Z69bTJdyKFZxSWpjfbWHK5gNNvVRMrffezIBzxjoR+xNA7iQsyzq/cKQ 1jUdZAOvuPY/j0Qdbe+uNzj+tm9x98IVg+wvcCYPHILP9mpq+JCIniXnpqT3RG/hB0PD mmxIPHUvbJUF+UuoTQOsC/XpBsEJRafF+EeCKOKkN3XqQGIPV/xFuROleRUk+QeKv9VT 5W8wyszc+Kw6w/Pn+P3DHsP/mmngI2Rxt2FZ+NhUVbmoLToMsvjZpiKp6XMofUxSNvsL gIRcChA1fUuYO9l9kRE0kHDN0SlEl3WxmV/cn3ByoqwjZGxe+GjMtyqT5Sldo8eB1tZB /A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFj2x6VRrW6n/Wo+kaC9if07gfhBpoaJ1Br12uD2CvpEfQn0ErDH69y4XVyDK2dMvd7QByFxFLCMc+e1RX7Fu3HA7EImC8ujgiJ9Q9IIFmo7MqLuVF83MT5LuZeyp+Zg2BOluXiWLemVXurBeYLYidN0te2UBRhphZUm3twkNmiUGrVDdriD5KkuKfiM3PmpJrU8zllpJdeaDYtXehvKOB79V623gk6mW+7gPgDmPmZGj50F40pYRW6w9fKptpfq7UjcsjEuZXGkDOIe9fvsCNAn+bepRg7LKV32ITrnlG3KeO6op8A2zB9KPGbiSv/rdzYHI6pQ2QKM1aOAPSlqWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YDm0Dstv38waI9rc4uGBTqJnw63Novhl3X7LOfMPgXU=; b=djhMjcn/psWy/6zRukqKCE4FYjaGS4RrgfrMqKLpUUTGlEFYScHuGXuKLcyEBMXapiaMlraNnjEfbtdIbiqsL+pXCVY6WyV2AZ7WokPcaR1UG5jttVN06aibxkvvMEdR3U82t4L2t4BY5eFQnoFCoT2PN/ASaPmEZu7GvhVwMWxexxvV1fEWjiV+lHx+Gsnuw9mTcUtStPiyVtdcgu3BI8TuI3bsLisCNtQNsSSlhCaRaL7AU06wOl+N7RK5fPs4mnID2YnyxH0OooVx9T9exUMeJJMRf/rn8nAPy8iJYF3apeXVMEkxzySOPWBH0BmXN6tn8RM8lYmnwJXNYgm7Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YDm0Dstv38waI9rc4uGBTqJnw63Novhl3X7LOfMPgXU=; b=XM/WjsN8QxhzOnjOPQvgZ7yEbZh1gzAmv8IJc+ycZDaA4AGKggv3jxu8luzrOoGT0hDsj3O4JWzGgja898oBwMCp525kYguALZS88Bet+CYPLDuK+C9M6dK7P9tt5rhSPuXk5cbwY6F78ZwrHqvb7Fn66nOm7fCrQPJR1lY0boo= Message-ID: Date: Tue, 28 Feb 2023 07:54:41 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Is xl vcpu-set broken Content-Language: en-US To: Anthony PERARD , Jan Beulich Cc: Boris Ostrovsky , xen-devel@lists.xenproject.org References: <792d9693-7bb1-9143-064a-d3687b78415f@oracle.com> <467c21e0-e41f-3d52-f5e0-8bcc70bfc923@suse.com> From: Joe Jin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR06CA0045.namprd06.prod.outlook.com (2603:10b6:a03:14b::22) To BYAPR10MB3160.namprd10.prod.outlook.com (2603:10b6:a03:151::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3160:EE_|SN7PR10MB6329:EE_ X-MS-Office365-Filtering-Correlation-Id: 1205cba1-3d00-469a-5d5b-08db19a41c54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GE73ftP1bLAIQiw06iLfH2PB95xsS6g+g/MGF3eanpYfN3IKR6WOZR/AuxLwxCeSEdOlyK5akh2zRmI9Hi5GlV0aquWYCmyxX60Mh443BsWt/VlPNjZwk2SVIw8N7dJgmpmyxDujKMLt3CThoy3NZFBp6NpqeJIQAe1n6Gz0FzJ67pPzTodtE0MTSt2i2o5t1p56oel/Mx1Q3IR4L5StPepNLw5aafScxxO2ZbF2wEYaUJwogiV0Y3w2cmpH4dXdjzwaqco72vhkMa2f33Cek1ymtBmUiZrIUMu0Y9GT4fnVrukqtqczuh5fERBrZTsU/qd87309vWyvHFf7YMZk8P+RLzzF+oT2kszaK110GaW5QTrzBZtoBz9o+d1c1hrKN/Ifjc7f6CkxzDhFspsr2yDGq801CFbOy9u5c3O+mZC5YSNHyFcm14zNJCwODVYeUysiX5RAyptXm43ZKPT2U8iTrsZBcoOW6+LwtcKG5qyxyGZoQ6kXVn2edOTku6TuWF8/Od+Di7dywr1dPWPfxd8BdUjfVouABdeECw3peNBaNIGQ58dgj/heNeMlv34qUtSox5cTy5//uHTz02lqPRx3c/cjbU8UG0W5m6FU7Gne/WDrtr4HCERvFKet3V4BqjfXZzkqgs1OiQ5jrwJOv8zqzg73nFdX9TOoJbTZbVmSvYrkA5RfJltumeurce+wce3DQ9uL0DwrSLlc0T6YIEFr3NdF+8U3MwEjOhLrgl4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3160.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199018)(26005)(186003)(6512007)(6506007)(6666004)(3480700007)(53546011)(83380400001)(86362001)(36756003)(31696002)(38100700002)(2616005)(66476007)(5660300002)(66946007)(66556008)(4326008)(8676002)(44832011)(966005)(2906002)(8936002)(31686004)(6486002)(41300700001)(110136005)(478600001)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHZYWndrUzh3a0tjMEpIeE1UK0VFNWNjWDhnTHgxN1d1a0NERmx4ZTVNSW5W?= =?utf-8?B?NkZtNEJBRmdqN2JpM0YwbU1QVGVzdlRFc1VWZ0lyb3N6Rm9BYk5KWnRXQStl?= =?utf-8?B?dnI1VlVKcWtZeUxpcjRSZUJiZ3psZGRDOGkyanhTeWtUYlE3bWMxMzNJZ01R?= =?utf-8?B?V2EycXQzVEhDNURON3YvT0Fpc29tRzlneWhtQWQxc3NBZU1xZnBDU0VDYXB5?= =?utf-8?B?UHBJa3JXNmxTMmxxdS9nYjVFa3lFalVQODFPQ1pPZUpKN25nTGUzMmd2KzMr?= =?utf-8?B?TTMrZGtZUXNsYytJQVdlekp4QlY2c1AxZEZST0NjejBnSVV1ZnVnQWlEVEhG?= =?utf-8?B?enJTeTlrems0V0NVa2lrcVVNdVNXdDhkMWRWOEQ3RGFDbSs4b1FQdHFQcGIv?= =?utf-8?B?SCsrekhPMjVjVDRZc3FqaHJ3eHpzRFRkVkxkbVZZRHlvSllZcTlLQTFVODdn?= =?utf-8?B?Y2ZaTGJtU1RMNkYxUC96TzF3UU9YT2IwNUdTQTU0UnJkNEg5U3ZVbE84ZEE1?= =?utf-8?B?S3YxNXJqTXRFZlZGY3lCRUF2cXJSQnFNcXlYaE1GTlNIRzRkMG1GVDhFdytB?= =?utf-8?B?cjBhZXZuWENrNE5QZnJnTzk2aFJMZWd5ZlgrVEFQYkoxWnZlcTVtOGJYT1dP?= =?utf-8?B?UkUxWjFLZVdFQXJnc2wvM3FYd3MwbWVTVXdsWWVJTjhSZ2ttVDVqZURRcFg5?= =?utf-8?B?T2ZieXlOaEVaUjZXK3RQdDErMHp5SzdGRHE5Y001Vm1ucmM1SnlaY0N6ZWow?= =?utf-8?B?bURJSU0vd3JDZnQwbE1uNTVGZVQwL3NPYjhBTDBDb0FqVFppN3lIYkVIaEhi?= =?utf-8?B?Wm4yUGhLVFJoQk9wMnRMYitmVWZnZVFua1dWMGZxbEk4alVDeTBlWS9penV6?= =?utf-8?B?K3dmTVo3aHF3ZmpSWHMyMUZaUnl6MVlwRktQcGFrUUZXYVU3ODlZMEVzN25J?= =?utf-8?B?cENzZDl4U2NEa3h4UWN3T0dVREk2QlBKeHlNL2FkNUFpTU4yTGlnV3hadGZx?= =?utf-8?B?Ym5uOU00QS9XeDFoSkZxWXhqbzB4aUQ0d0NzTFhpVHNXRzNhL05sYjBJdnR5?= =?utf-8?B?d2NZc1kxR1JRN1FITkhsNVhLdHIvcjZ2ZXVqYUM1QVRBMnNPc1dhNFZJeXFi?= =?utf-8?B?Z3B4a29BQitxNytnaVVLNm5hNTEyWnlSUlVSaWljanl0ZjlsKzVqWi8xNEhm?= =?utf-8?B?RWFQYXdMQ1pDbWYrcTF0cVl6SHlWdmM2aHhlYnZzcW5udW5SQkh6cHFaR0tX?= =?utf-8?B?VDVQKzNkeFdwaHE4cFIwWHVMbVV4RnBsQ1RjNlJ0TDRwczc0UVRWSytZeHps?= =?utf-8?B?ZXBHQ0h2ZWUwZXVhdE91WFRBQThTOHNNemZjRzlFSVVOdXhIZmJmTHEyMm51?= =?utf-8?B?Mk15S3BwTFVzK0JSMTV4UWFFMEFsVFlxNk1ZZ1pwZm9NYXQ0MW1xaXAxaUlP?= =?utf-8?B?MkE4dUZOK2dSWVFsbll6WEpnWnRmYjVKTWErZW5YV21wemdYd1RBRmxNNVo2?= =?utf-8?B?cEVlVnlzNWtwTXYvem9oTDYvMDN2aTJPYnNHTnFIRFBuRkVmeC9kcU5uaTFv?= =?utf-8?B?R1A4cmEvRVpQNkVVMXZxRmU3NUVvb2JxenhiUXpsMDFSazFackVNbGM0MmE2?= =?utf-8?B?NkZIZm1wSmI3WmV0SEpIRzlEZXpRLzhHMmlJZmQxUk1hVFMrRklheWFNcFFG?= =?utf-8?B?MEtHbm96Rm1selA4NVp0aW9UaS9XTDd5dTM0bHVBdEs3WGhuWTB0VzFvMWo2?= =?utf-8?B?NGR5NEhTMVR5Q2loSFpIUFp5UStiQnhkdlN3Zy9jQnRGWTE3bU9PS3RPTm9x?= =?utf-8?B?a3ZxK1g3YU1wWDU0dmt6MXdad08rdHhCdkZaMHVjNldkVWlscGRScGtKbE1v?= =?utf-8?B?NHZ4VThSYjZNVXpWTjZOTU9qbTV2aUt0eTZKNmtzUTlxMUtyK0Q1VjQyQ3Rt?= =?utf-8?B?QkdXZjNYMkV5Uno5bjFMOXFyTU1DT28yQ2FWM3hxaTFsdEpUTzJhNzZnL2RK?= =?utf-8?B?d2lTTDliUTdMZFJPWXphN2ZrNW5JdkZqeXdCL01wZnZ5VHV5VUZURERRY0tu?= =?utf-8?B?b1BILzA2QzBzVGNUUnlJd05pSkpHUzhLUC9peVNXYmxvNStNdC95QVd4ajBn?= =?utf-8?Q?g5E73AoaxwN/5dO16jFg3JmT5?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UeWszz7kwUM1iLA0IKhq4lhHooYwfjrLa1jz/cq/OFicVcYoiBNYQEChKpsP8FdjzC/CLS98waR94zQgu3HK44wR7k/S/KLtPoRKDkYDml3Ww2CPi8tsTks8Os2aTItXary3o8+WJUqD+kyW9NWwzeqR10Ypn1FxHxXLxJUaWecXb1eRy/XvLxGZ1wzoUo53AZ87y/TklTaQv602FFBA6mSSx6/ZqNtsorXfhhI975d4OQjmuPsiKvDpg77245Bcb47mE34brQzURpqfsUXnRe17p17YrxFlJeYFDrO3dicHjeukGJI3C25KNd38KraBIi8np75nK/Lrxg98M9NCeOwsbY4v5i8gpMxgeS5UI0FI17si0PpzGNgHd2+QD0Z2fHwoXoeSplKOSAfAoCrZ1Ut19dhOwF6AbuLS3raIUcl1TqQIERNfwOV5La0wDrweDD8BvCiKDl7z5CbG+fv30gQhcadbsSHfUBTJF0Tpg0fOvpHeRhqHFtjwetFxjKNg1v/pqTiMXB1wtja2/7WyDKWzsSaIt2VpQWS7+FANFaCY2w/aImLBx7uDw/+ldWLozZpXzgUIWQHNZx7dMniXGFkAUpjyZBSqE1zVBOs3RUeD88BPH69tLZzq+KebZGtSRVC3jYOMi0qiCmZtfR8l2oTfSkq8Z3tQS70562haKhoXh+/5Z//48itvIM6cvoCL+1iH0AyLYkh0LrxS/uU3QaYgq1ySy06eV7y7nc1kd/sLvobDPLQC3P2+/pz5CyebB8FW7kDimRTjxigLMRzMJ+9BTdIwB1P0MO8aE+w6tHWO4iGUAaM+yqSmrT88gFRkweLtLZVOZ06GqK4Xlastew== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1205cba1-3d00-469a-5d5b-08db19a41c54 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3160.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 15:54:44.5397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5CKVPFe4OblvojF8o4LS+0I80vhBPlBGVROY4N95SbK+a5gXk6jPMXsafCca57UmnQxB8cMiaWbwX143z8b4+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6329 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-02-28_13,2023-02-28_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280131 X-Proofpoint-ORIG-GUID: j6FqLJ9nMB2yPHD1MLxzg82g8m8M9-vX X-Proofpoint-GUID: j6FqLJ9nMB2yPHD1MLxzg82g8m8M9-vX On 2/28/23 2:24 AM, Anthony PERARD wrote: > On Tue, Feb 28, 2023 at 10:37:00AM +0100, Jan Beulich wrote: >> On 28.02.2023 07:44, Joe Jin wrote: >>> We encountered a vcpu-set issue on old xen, when I tried to confirm >>> if xen upstream xen has the same issue I find neither my upstream build >>> nor ubuntu 22.04 xen-hypervisor-4.16 work. >>> >>> I can add vcpus(8->16) to my guest but I can not reduce vcpu number: >>> >>> root@ubuntu2204:~/vm# xl list >>> Name                                        ID   Mem VCPUs    State    Time(s) >>> Domain-0                                     0 255424    32     r-----     991.9 >>> testvm                                       1   4088    16     -b----      94.6 >>> root@ubuntu2204:~/vm# xl vcpu-set testvm 8 >>> root@ubuntu2204:~/vm# xl list >>> Name                                        ID   Mem VCPUs    State    Time(s) >>> Domain-0                                     0 255424    32     r-----     998.5 >>> testvm                                       1   4088    16     -b----      97.3 >>> >>> After xl vcpu-set, xenstore showed online cpu number reduced to 8: > [...] >>> But guest did not received any offline events at all. >>> >>> From source code my understand is for cpu online, libxl will >>> send device_add to qemu to trigger vcpu add, for cpu offline, >>> it still rely on xenstore, is this correct? >> Judging from the DSDT we provide, offlining looks to also be intended to >> go the ACPI way. Whereas libxl only ever sends "device_add" commands to >> qemu, afaics (or "cpu-add" for older qemu). Anthony - do you have any >> insight what the intentions here are? > The intention is to one day implement cpu offline in QEMU upstream for > HVM guest, I don't think that's ever been done so far. > > As we use device_add for cpu hotplug, we would probably do device_del > for hot-unplug, so qemu would still have to send the appropriate even to > the guest. Sounds like this still in TODO list but not of build or test env issue. > > Someone will have to figure out if "device_del" works with a Xen guest, > doc here: > https://www.qemu.org/docs/master/system/cpu-hotplug.html#vcpu-hot-unplug Tried QMP and looks it does not works: (QEMU) device_del id=cpu-5 {"error": {"class": "GenericError", "desc": "acpi: device unplug request for not supported device type: qemu32-i386-cpu"}} Thanks so much for your input! Cheers, Joe From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:01:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503518.775788 (Exim 4.92) (envelope-from ) id 1pX2PL-0003Ax-C8; Tue, 28 Feb 2023 16:00:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503518.775788; Tue, 28 Feb 2023 16:00:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2PL-0003Aq-9T; Tue, 28 Feb 2023 16:00:51 +0000 Received: by outflank-mailman (input) for mailman id 503518; Tue, 28 Feb 2023 16:00:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2PJ-0003Ak-78 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:00:49 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 113e42c4-b781-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 17:00:48 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id s22so13836841lfi.9 for ; Tue, 28 Feb 2023 08:00:48 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id i26-20020a056512007a00b004a0589786ddsm1390308lfo.69.2023.02.28.08.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 08:00:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 113e42c4-b781-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5oLrTsmo5DP2t57tNcUhgSb25T6lEvw2eBBMdK+tYaU=; b=XKfoCX+eUGGbN+xbdIfINzzCi99W/fpoFLa5n/nhfmy30+0h/QgBxp6LB8vf55uJpZ gpkwsUP4N+w64OOwEjIv79IGRfa++AS4bXtZUXIj03tdsRx9P/CSN7/KZ9eYrPIthMco c+EUmQg6hS9wCxMVBnRBp8NfE+9EBlXdX23Tty9T1gTwyEjTmOPKBpvCe/gzYDjxQh1v Q6nLWVSvTBaqFJtIxD5QX4QLNDPKejGnEIPiXG6mjchmi3Eoq0wdDResrrAKjNorw4/Z iDtI6TF+TXD7mV3lvjbrYjvQ/v3djrG/lYKiEYN9/wwhzikOk3Run7Y2McXVNcBMEAaZ ctXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5oLrTsmo5DP2t57tNcUhgSb25T6lEvw2eBBMdK+tYaU=; b=pVj5CQsCRY4MnWgUTkFs2siEUE9pVPabbpwK5YzMG6ybraEEozmVeS1AhHBaRgKujV wmoSt+w9IFIu6yCBTOHSENPkjC2V+INbL59cMNG6n3ZOWSA7SOdiwAN2Gpq/M2v7a5yG qHWFNyLXHQVSyJ7gJZnts4nk+y1C9v1f2X7wSake5cDn6W0RCeBj5XE7yNbx1zi5DbxE tXwH5SlnP1DpevGvw5kmE4C2deL7E9j5G28FdaVzzjuX83hn0Jh39diKQADeoECBTHF8 Mt4nvyXJMDL9XkU+26Z13WxAsKjhfAkpZoFbYoUb7JY4EVaEI9kNv0CszcIs0PHNGVk7 RfWA== X-Gm-Message-State: AO0yUKXxlZmDURX0JE0dwwlG1+Z9nMlGszl3ePEXg3tZ/jl+iSus3Pxe cR9PJh4s+4lMC619aVW1H18= X-Google-Smtp-Source: AK7set/jj9BW/DhnCWdL5AG6rwlgWIeb1rbSbCXrjgZX/CSpnyxXEtmwLFo1komzXlMosAhy4urTCw== X-Received: by 2002:ac2:4a79:0:b0:4db:3847:12f0 with SMTP id q25-20020ac24a79000000b004db384712f0mr985586lfp.50.1677600047870; Tue, 28 Feb 2023 08:00:47 -0800 (PST) Message-ID: <6ff1684cdea34004525e4931f00aa5a9c89b28a9.camel@gmail.com> Subject: Re: [PATCH v3 2/4] xen: change to From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Julien Grall , xen-devel@lists.xenproject.org Date: Tue, 28 Feb 2023 18:00:44 +0200 In-Reply-To: <58615dc6-0d89-bbcf-acce-73a5cd943cc4@suse.com> References: <19404db4a577e17dffef85a101449a507965be19.1677233393.git.oleksii.kurochko@gmail.com> <468d6130-739e-4b0e-44e7-5aab520a0cac@xen.org> <58615dc6-0d89-bbcf-acce-73a5cd943cc4@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-02-28 at 14:30 +0100, Jan Beulich wrote: > On 28.02.2023 14:07, Oleksii wrote: > > On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: > > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > > --- a/xen/arch/arm/include/asm/bug.h > > > > +++ b/xen/arch/arm/include/asm/bug.h > > > > @@ -1,6 +1,8 @@ > > > > =C2=A0 #ifndef __ARM_BUG_H__ > > > > =C2=A0 #define __ARM_BUG_H__ > > > > =C2=A0=20 > > > > +#include > > >=20 > > > You are not adding new code in bug.h, so can you explain why this > > > is > > > now=20 > > > necessary? > > I am not adding new code but inside 'struct bug_frame' there are > > uint16_t and uint32_t which are defined in . > >=20 > > And after was changed to it started to > > complain > > on these types. >=20 > Wouldn't xen/bug.h want to include xen/types.h anyway, and then > clearly > before including asm/bug.h? can be moved to but generic implementation doesn't use any specific from types. But probably you are right that it would be better move to ... >=20 > Jan ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:13:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503530.775797 (Exim 4.92) (envelope-from ) id 1pX2aq-00050L-EQ; Tue, 28 Feb 2023 16:12:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503530.775797; Tue, 28 Feb 2023 16:12:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2aq-00050E-BO; Tue, 28 Feb 2023 16:12:44 +0000 Received: by outflank-mailman (input) for mailman id 503530; Tue, 28 Feb 2023 16:12:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2ap-000504-OU; Tue, 28 Feb 2023 16:12:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2ap-0005wy-Ku; Tue, 28 Feb 2023 16:12:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2ap-0006yF-7g; Tue, 28 Feb 2023 16:12:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pX2ap-0007Y1-77; Tue, 28 Feb 2023 16:12:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6Y4SHHTbwS0IqZzusJiNPQStbh9Gy+ssQEFmc//5ipM=; b=kHPAbHPy33Dl18Va9Vp2vO3r1M s02Ok0RDykENF5ZYLM/bLR34fjKSPqN/TDAT5iV+c9JxIAdN5dfz+6gR1QtThImygF2I2R8Nf7Ljh 2Od1vhr1n067y3JUiE0I46rOckBUBsZZ+pTpwkhoGBfx9FPrEbXeHFwp9zDFu/svR0As=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178776: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=a4557f515fb002010b34b79102278ea03d6b31a3 X-Osstest-Versions-That: xen=bfc3780f23ded229f42a2565783e21c32083bbfd From: osstest service owner Date: Tue, 28 Feb 2023 16:12:43 +0000 flight 178776 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178776/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen a4557f515fb002010b34b79102278ea03d6b31a3 baseline version: xen bfc3780f23ded229f42a2565783e21c32083bbfd Last test of basis 178708 2023-02-27 23:00:25 Z 0 days Testing same since 178776 2023-02-28 14:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Demi Marie Obenour Jan Beulich Sergey Dyasli jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bfc3780f23..a4557f515f a4557f515fb002010b34b79102278ea03d6b31a3 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:15:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503536.775808 (Exim 4.92) (envelope-from ) id 1pX2d9-0005ZU-SY; Tue, 28 Feb 2023 16:15:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503536.775808; Tue, 28 Feb 2023 16:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2d9-0005ZL-P6; Tue, 28 Feb 2023 16:15:07 +0000 Received: by outflank-mailman (input) for mailman id 503536; Tue, 28 Feb 2023 16:15:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2d8-0005ZD-3k for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:15:06 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0eb6f2f1-b783-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:15:03 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6855.eurprd04.prod.outlook.com (2603:10a6:20b:dc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Tue, 28 Feb 2023 16:15:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:15:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0eb6f2f1-b783-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dim9laGC/9pIt9pns7GRv9Ay3C5aJ0ATnPG9BXp3laKO5KOmKtMwXvRTg05hSQb81Y7zPKi221GhIirMS4ARG9vIbWxDv3x1xgPIAGoaChzsF4sEKg2m35eZ2ld2N3se5fUp2xqOy0/14ossIELjKC1EEWG3CENaULCnYU71HB4LuDONBo1qu0kGmkTI8QuBddxffbuKdel6SDgOudJmxK5bD6OPEDqu37WkUMhZvj79xnbIyY94TGRvbIKpgf8rjEB1zUR2+YRa1uASzPFyzqPI5Ql8gwqropWtBVBFxTXiZsxNGLv3AUjwY/b3Gjed2iSEWJLlmhE1+pUybAqoRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tNp10086fur+oZYyp+BSwjOTKwUyAkJM+Eerv6MqBxw=; b=avE0qt7iuV3J1TTlDefzBsnbOHNy52IrWZGN5VE9LOLwYD95qEpAhQSuvTFYJ6aPOCTEyofHzlmIQN/bLV031lB9eRbW/01chLtH/ylFxlqhVrbxw0DqWpdK84VDIfk7Lal/lV6sGQ/mZBzF3F82snKGQEBAg2t8OpzBCr5EMvl21hkvyUZKUYVEIna+PWvSV/ap0d6U5hE7/5rm0zr7OxWzAOdbRAfe7yASUzvH4axOz2rHzzb6Xx7bWaoRP1O/Y/jlr25hrDYCmWsvRJQlLmNcbRYKgZVSqfwabJnNB39lw0QHZVXHYIvkHEFMz+yczdG1wx8OdeAkgb/sZjhNjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNp10086fur+oZYyp+BSwjOTKwUyAkJM+Eerv6MqBxw=; b=mpM/29Rb3z5lHBisHxDB/dc4Iv0plqcPYTeNy82jtrp9pmZKA/YReM4K7rYrr7syyYG4BF1VZNIVuX3EZPl6BxxKFeVIpC7RtOlnTI1IiEi1tbgopvuObgNS2rEjkXAWb0BELeiZ5uBXBsL/uBaTigry+6Cu0DDr9HC/mfjshZ77L2fs4qrPlnBurNdgwwhv1sZkd87ncHEjlTQniGtuDGY0Yd/m/M5lLvTUcPfekhgFjD9owk7OMuOoWc+LMwTxPDD0RB6XQAldNCThTX80mbjcsXZIv4TvfnsJiaFEci7VdGSnQ3JHexzMUCZgEXbSED+sglM8IEUnhyB8qGuOTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e2fe766-1560-0f44-047b-d914048ef34e@suse.com> Date: Tue, 28 Feb 2023 17:14:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/4] x86/svm: split svm_intercept_msr() into svm_{set,clear}_msr_intercept() Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-3-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6855:EE_ X-MS-Office365-Filtering-Correlation-Id: d7a85eaa-1376-48af-0fdc-08db19a6f18e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MOjUrtem6Kc8/N1TTVeeQpvWZgCvrvZibtlm/48sudhVZCAvVVCMdmfvLpYe7ctWYdT2gOSAVzfbXP6mQjOWXSVe3TYw4MSrPHYHS4K2aSrrA3b/OUt8RKr96xCuB0K0febVU2vcKgKP+3G+3ycnHRkmwW2YDGZCTeoyXfmlovFdfN1CMeusIplfaq1SMio387PLEBd5VR/gWkBqMHeoOOcuJl0AnNwoh6PLWb+mqNaHBXMhLJw3TTwGUJn87ySNVkIRA1XRCdLWnZSYrAE98+2ji8AGWwBsvqwrO9Nz9EsB674qhuDLxryE330MBdVXzAxZJrp2TrG3pvGyT+umpaYmyIHt+JbeJfysTQJbvdH+MadFPlf8zHaeRJIIeVtcvZdXUhFuNh+N5F4MjXSPU+IqmQecgCuUn335wtn07c+tQ0qeN7+dCdXD6uA8rFen8ENH8KZiF/T05RuA4azY4XF6sBL2SN3Hg3whTM1CJUmGguI1wJwcXIYht+tuXY9bLWjJySWa/EUqsfa4nYDgWj1+wMsmOY6qzto6Q61dYTvTEHAeeOL/I5y7D1yUuivlByDRdGS+ppKxMyke5ZJ7KgEl6ZPz7+iwAaDSARCvZKdPen142vt23CfodzlUncOt6Kmg9k5Cokn3Udm+ceN0bBjKBIHsgVfA4xtIzyWezl0vqNIzRkrqyit5NYSVMllJHMudo5Cw9/koDgBtYxHrphMEUtAmcOxhpXyDp+Hwdas= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199018)(5660300002)(36756003)(86362001)(8936002)(31696002)(66556008)(6486002)(478600001)(6512007)(4326008)(186003)(66946007)(26005)(53546011)(6916009)(6506007)(54906003)(2616005)(38100700002)(66476007)(8676002)(41300700001)(316002)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFlOWkNuYjZVcmhSd2tyaEJ2M1dwdXJkMjJ3S3ZjaXRrTTg4YTRUVDE0aE5E?= =?utf-8?B?TnlKTFl4UmRobkVCV1FlUGVWU2xZYU9mdHpwakdpd0oyYU9ONUI0aGpmSlhi?= =?utf-8?B?dG15TENzWS9GMzBBZDBIR0l6Ykc2RFdIODZIeHFTbCt1N2hLRmNwcjNIL1lU?= =?utf-8?B?clF0MGhlaloyYTl1VHhuajVCVHRUQkVnS3NZbFRobG55cWJNZi9wMUh1VG93?= =?utf-8?B?c1phVjBOaHFzTWFPWlFEV25XdGx6OFF1WHJXK2VjdmQ2bDhlemlLdXpMM2h3?= =?utf-8?B?ek9vQlFhQ2kzWjhYT0pDSDhMMlNJV2VLM3ZBYThPVzgwbndtS0dMbVovMUR2?= =?utf-8?B?RWFyRkdKd2gxL09YQlMzS2VCbUJyU2o1eGk1UjRMbDBHU1JRdTVYUzdhOVV2?= =?utf-8?B?SWNXYzZySzRiVUpUcE9Lb3RvUVpHeVgrR2xMZ3ZJWDNUWlpKRk5Qa2dvcGZj?= =?utf-8?B?SW1zQzh0bkx0bCtNV0tkbEJVby9QU25ldEhEbkFtZ05ZWEYreEtGWmYyeHRm?= =?utf-8?B?UzFRdXRoeWZJUFk2Y3RkRHhRUVFqWEgrWFhlSEltOVdUTXh0alV4ay9xSmpM?= =?utf-8?B?Z3l2SERIM0R3bXdhbUtEMDF4MXlwMFJnVCsvbEhpZUE3Qk5WQlMyWXl3b2JB?= =?utf-8?B?R2M0RjN0SWFzVFhFQTNKY2RuMFNWbGlOQjdxSzB0UlVFSzhER3MzRUFHMzZz?= =?utf-8?B?QjdSYVN5cEJzeFA5V1VZQ2lHTnVQVjlxeUdZRFFUNUZETjJjSVJjYWRidGNy?= =?utf-8?B?cjRaNWc5YTBJUUIwR2RvNGhFSDZYZjFqblhnNmlGQWlRaS9yUnZsanh2TzZ1?= =?utf-8?B?L1lSd005cFlWNnVJb251QkRJMkRiSzBFTEY0ekRGVmQwSGJmVGllclREcmx0?= =?utf-8?B?d01JRU1LSW9nVU45WnlXOGo5MnVmT2hDNWtOaTAvZkpjamZKcWg4dStFTkly?= =?utf-8?B?WmhvYmhZRkVvRE8rbE1hVGFSQ0dVNWppQ1lYNGlCMnlsaldmUW1XM2o2dEps?= =?utf-8?B?UEx1cDBHTFpLTXlrS3RIMCs4KzZKWmRNOHNRbnBaM216bnBYZzltOTduQUlJ?= =?utf-8?B?UlFSMjFSVWxldFdLVUR4YTBiYXVEVUEwa2M4Y09zOHVrVDV5Vjk4ODVaalc3?= =?utf-8?B?eHhDd3R1ZTlHVnlNZlRRemphckREaHFENGMwTjVqZ1paelRseEg5Q00zNWEx?= =?utf-8?B?TG5tTDdtZHRxdDREVkRIZUVrRStoOG9PckQ1VWIwWE5YdTV0STc1M2lwT05T?= =?utf-8?B?aGxpaElaVW50S3lQdHJaM21yTFBVOVRrQXd5RVYwRHlvbFN1YzcvSGRtVXFB?= =?utf-8?B?VHQ2bDRJdjdXRnlySmFPcEQzRVYyNUxsdy9DZ2lnZTJDdllXV3ZjVVM0QUIv?= =?utf-8?B?ZFJHa1FHM08yaXZLNHA3Vm1WZlArSGpYc2VxOG0vS3VVNDNKaUNaNnUyc3JW?= =?utf-8?B?eDBJcFFiQmlsYUhoSUkwdVBzdUZlemtGelYya3NjU1BsdnpjN1hRZlY3R0x5?= =?utf-8?B?Nnc5UlozRUlYZGhNUjA2UUtIUGVVcmtHTU5SRGs2Q1lla2hZcFdBWGlVVVlQ?= =?utf-8?B?M2p0dC8ydDJscGkwZ2U2KzJXVlBnQW9nWDlmS0NaUE1TaWFjaHpoQkR5SEtO?= =?utf-8?B?QzFiMlFQNkJhS3BSQmN5Y0ZqK1ppQlFlY29yM2d6MXhoaVNZZUthblhJazFJ?= =?utf-8?B?ZmpFVjBYRmREaWUwTDlVc0llYm1SOGxrM1lGQ2xKS1h2SXlJdG5QMlRqUk9w?= =?utf-8?B?TDBRYTRVQTRaZk9mMzYyZm9ueDRwL3NzSjg3MEl3L2wreUFmWXpvZlZEbFFz?= =?utf-8?B?eWZvNk9keXVEcnhSUDJYZVR3U1hSMVVSYjY4S0UrYnBpRnJ3SWJKeE5zY3Yx?= =?utf-8?B?b0hMV1YralVDS3g4NExJTGZiOFZleklTVUx3N1dCNG9sRzlERWdNaFllK0RI?= =?utf-8?B?RWlXWlRGa2xuekJOa2pHcU5aRFFyNHNrdE1FUzZuMThBRlQveDk5eVhLcUdL?= =?utf-8?B?R0tIa2dGeUxmb2MzdkpoSytlUXhRRThCR2lPSldENk8wZ2pOUWhXL1o4ZVFU?= =?utf-8?B?azFKQ2tQVDFaZ2FBZFhzVG5USUR0Z013L0ptLzcxQjZMK2tTRWFzcnZpZDU2?= =?utf-8?Q?aO++77qIHICATf9pWxXgwj4Sb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7a85eaa-1376-48af-0fdc-08db19a6f18e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:15:01.3598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BjkqMJXkE+AMuK7X/M2bQ0msGt2GaXnWwl7I3xdr2guMblApvAo7cnl0miTLFid+smKudVNp1LyORIDAds6uzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6855 On 28.02.2023 16:17, Xenia Ragiadakou wrote: > On 2/28/23 17:10, Jan Beulich wrote: >> On 28.02.2023 16:05, Xenia Ragiadakou wrote: >>> On 2/28/23 16:20, Jan Beulich wrote: >>>> On 27.02.2023 08:56, Xenia Ragiadakou wrote: >>>>> --- a/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>>> +++ b/xen/arch/x86/include/asm/hvm/svm/vmcb.h >>>>> @@ -585,13 +585,12 @@ void svm_destroy_vmcb(struct vcpu *v); >>>>> >>>>> void setup_vmcb_dump(void); >>>>> >>>>> -#define MSR_INTERCEPT_NONE 0 >>>>> -#define MSR_INTERCEPT_READ 1 >>>>> -#define MSR_INTERCEPT_WRITE 2 >>>>> -#define MSR_INTERCEPT_RW (MSR_INTERCEPT_WRITE | MSR_INTERCEPT_READ) >>>>> -void svm_intercept_msr(struct vcpu *v, uint32_t msr, int enable); >>>>> -#define svm_disable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_NONE) >>>>> -#define svm_enable_intercept_for_msr(v, msr) svm_intercept_msr((v), (msr), MSR_INTERCEPT_RW) >>>>> +void svm_set_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>>>> +void svm_clear_msr_intercept(struct vcpu *v, uint32_t msr, int flags); >>>>> +#define svm_disable_intercept_for_msr(v, msr) \ >>>>> + svm_clear_msr_intercept((v), (msr), MSR_RW) >>>>> +#define svm_enable_intercept_for_msr(v, msr) \ >>>>> + svm_set_intercept_msr((v), (msr), MSR_RW) >>>> >>>> Please avoid excess parentheses. Also could you clarify why you retain >>>> these shorthands when you don't use them in the conversion that you're >>>> doing (e.g. ())? Are you intending them to go >>>> away down the road? >>> >>> Ok. >>> I did not understand the question. Which shorthands? >> >> svm_disable_intercept_for_msr() and svm_enable_intercept_for_msr(). > > Are you suggesting to replace svm_{en,dis}able_intercept_for_msr() with > svm_{ser,clear}_msr_intercept()? svm_disable_intercept_for_msr() is > used in svm.c and vmcb.c. I'm suggesting one of two possible routes leading to consistent use: 1) drop the shorthands 2) retain the shorthands and don't ever open-code them Depending on which route we want to go either your code adjustments in this regard are fine, and only a remark would want adding that they're retained until remaining uses can be cleaned up, or you want to use them in your changes wherever possible. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:26:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:26:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503540.775817 (Exim 4.92) (envelope-from ) id 1pX2nd-0007RZ-RR; Tue, 28 Feb 2023 16:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503540.775817; Tue, 28 Feb 2023 16:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2nd-0007RS-Oq; Tue, 28 Feb 2023 16:25:57 +0000 Received: by outflank-mailman (input) for mailman id 503540; Tue, 28 Feb 2023 16:25:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2nc-0007RM-Vd for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:25:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0628.outbound.protection.outlook.com [2a01:111:f400:fe0c::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 937780c3-b784-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 17:25:56 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8927.eurprd04.prod.outlook.com (2603:10a6:102:20e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:25:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 937780c3-b784-11ed-9695-2f268f93b82a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bClawmdVHGwkLWm+8UekalbOv3obd/yzV7b2YzPIS43pheSASiMMZz9JAd/GKQep5hXbCyfdPnrjKYYo0L/vxazVeniYca3ULgu94MRCKZpFvqI9euxzt/9THRdIn8wQdSRxiNBA9HBtaI58lYdtig8Il1NrxPQhbuVMHdyRCrPHD8aF/5LwBGAVhehrPa6whRgOQc2r+KNkUTLhKvrgpFN6MyHlKMi8C7ODKSxYmBLJSktZLnWFWa04XpZ1PicOCyfkvT+Xw4FohBu+9n0/NKNA0o+3DBIMAhypbE9XpngApFvAUxCO9G+Fat6O+HIZO9mSkk/GfyNViMZ8mqAk9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BDTIOXCI/dacGdNJR6CsclTQLDidmYA3cnfhSAcWVcM=; b=B7X/zTeYgogPKA4Zl4dFZZ4J+PL8dYWM+RZdc/tOQAzy92qc9xJ1cUiXyX0OkjuqJTbK0SlTYcn6/NIPGsA3XtvNngF/y6jjUr6frnRThEuATioUwXfJX1hEnkbD/adXtfsNvhW3vflp9Q//7twMwXbDcx2uqBo9LNi5cpJ2iufZxYmpSoq8LEl3djEus7MlNTE++LvQgDKFmm7EaeScBzMB7I3nowgbKr00GMCoodu8WBdcu1Ti2XBWvvkDVTfHFP200ek1mPntz2xkLcR9OoOdRg9ICKqz4pZNg8jCEbQzVRsHQ97pOTcu2OMkwZuNsqu5Deq30Y6e3tEs1Cx5tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BDTIOXCI/dacGdNJR6CsclTQLDidmYA3cnfhSAcWVcM=; b=fZJg2gXt7JAcec6RLgDuNgnD5tmgopwreJOqWCujC+3em3S5Gx4rCjdFvOti60ZHUJha1IhwwER2amgr6ZVAsz1VZv77F6Njy09hlm1kxa6CLeTfCCQBM4q76tFTNX+DUmzf1tkCI+E7QO1gifvqIDYCnIIar1Fq1ObdsOvAsh6ud5FOVOZ7CvzcSfEXuC+B6wTU2RPJP8QTIUqW4vxQyynLEVvNcCutOJfHo64/kjZar2vHzaR504Yz60ipzokUng1TP8JopFiRh9LQs/2SzI2t+UOReoDenqM3h79zVDH6f5eXbhNwnwlY5w5IAJTVYOuyr9ntTOUyH9Xl1eAp8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8889daf4-cb6d-7a2d-1290-f89d5560408a@suse.com> Date: Tue, 28 Feb 2023 17:25:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 09/10] [RFC only] xen: iommu: remove last pcidevs_lock() calls in iommu Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Kevin Tian , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-10-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-10-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8927:EE_ X-MS-Office365-Filtering-Correlation-Id: 36c64598-9dc4-482f-36b8-08db19a8766c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9THzQsd1Y9hl4Fmwu3Ia/x15eBLMbHWjOP7g/Nl7h+j/b/Sga8pArhAXCGt4hXWdgrGf2otVCmW4qGRutd/lZL65Gh6GEL0j8WnbDOxwfnSgjV01592yqKUA+SBRNwf9rdWaVwUospbzIvibslbYzl2jfG2F3gsxv32m2pJiy973b8VSgzw2dtNWOuqELuQbiJyhqlpNlzO3Z+e5Y+ZWdLtcWcBGqzcSvI/D5MnmcjDY7nlxRht6+GOWleFvpOzo1uusjT9ZrWfl72by00NAmyEHoJxaWHoQPs5dNfxtJ9nWovC6MJXuKkQQnJItTqtz81F3O3cx73wUlb605K4m+MBBvoHl35p35IqwTVdb2k9b8cQoZIAJNSvZIjEj3PDJLlZWXMt5kwr15PzMjTpobUJtP4CE8Lv7+C4T/c2Q527qehYDlOqn2QmaWYP92owVmOGVuE8prUXhXsMDV7YN2/ARI//4goIzrZ087mJd6OYVeQ9CBVsRfPWE0lLTz7pw9ZQSgLxhc/eV33FGClgh9YUWuZJvcBXyl78mDnyYxrsBpk+P21c5VvcmKt/lqbCL/5nHgSPoH0Aws2wprLmn9xMx7+sLwx1dwgae5WQfB3bNpI4SBXZPkVf4monCY+Mbn+Ez3wltnj0QlqzmiGW+FxP3zYHI1qqW5Qno9xxBIDV8w3lHtYfgoJanGcjhNw04tCOywjh1m6AFCLbOO6hIFauLaV2BLblYXJjS4CgRWY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199018)(2906002)(6486002)(5660300002)(54906003)(31686004)(6506007)(6512007)(53546011)(186003)(26005)(36756003)(2616005)(66946007)(4326008)(6916009)(66556008)(86362001)(66476007)(8676002)(31696002)(316002)(478600001)(4744005)(83380400001)(38100700002)(41300700001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0V1U2tWOS9VWmJhNjc5SVlhYm5XMWQxUEIwREtlOHMwaWJvaEQrZUQwbkdV?= =?utf-8?B?Rm5NdTEyRmVuOGdud1hVNTdVWk1XMTBYVUtzMjZhdUVZd29MaFdrQ0oraEQ2?= =?utf-8?B?Qkg5YVNXaThJTTZpbnVYV3FpeGVOZWRoYStUcnhRNk5yZXBnSzUvWGF2d1hJ?= =?utf-8?B?Y1NuUFNLMnY0UG9BTXJWQi82L0ZoRWJmNzhRWEVyajNvTHZiM0l3VFM1OXJz?= =?utf-8?B?T3VsL0pCaEJ2TlR2dU43MDdCcXhNOWthNks4eG44eUdPOUQzVUxRbzRFWWFP?= =?utf-8?B?ZlN5M1laUnhXVzdLaW9WOW5aZ1lxYXJ0UnowVGR3NVkxaDNFMlFrN2d2bFpI?= =?utf-8?B?SlA4TG03RnJJd0V6emNpYUJ4Z0xPdDVLUk5rYmJNNU5DUmNMSlhDWkRuUnJG?= =?utf-8?B?N2JZL1hsYXhBeXVrUlhPblNTSUZvN3BsektKTG5UZ0ZtRkhqSXNabVovZ29o?= =?utf-8?B?VWZnNm81blYyVFV6bFVkODJER0l5dEkxNjlWa3F2bWEvMTNKS1JWc0tBR0JP?= =?utf-8?B?TVc4czcxV1pZS2hQTURvVmNoWDYrQmhqZTNBRm5oTzdVVGN4QkxVSHJZNlJ4?= =?utf-8?B?Tmc5Mi84SmtubzJzaGZvRktEVGxmRlRyaDlHWlF4OUZFYm5BZjRQM3N1a08w?= =?utf-8?B?a1lQR0h6RXpRTkRGbldvUnNyeUFFZXp4M3U4eUVtMWVqdHRRemFWRFVSMXNM?= =?utf-8?B?dWdzMC91MzVDbFZCZ3RWbDBOdi81OWVOMS9EUkFGdWNkc2tFckEyRVNBVm9P?= =?utf-8?B?U1dva2ptV0NLTnpXQ3RlNGord2hqelREOVlROTRIOUNJZEIwYTFQMUg3UEkz?= =?utf-8?B?WEcybDh0dFVwS1M0RWxCTnh5NHRWNS90R2JkRjZPZnBxbWlZendDV0IyU3ox?= =?utf-8?B?RVFhM1pKbDJ4Nk1YV1RIWjQwdGFRa1dMZGlHUDBCNTNYdUlOaUNIVUhobEtt?= =?utf-8?B?bHJiamlTZ1B0aDF3UFY4bEowSGF5b3prVjVtTGMzSkYwelpmVVZHQUxrTnQv?= =?utf-8?B?NFp3ZWdsRHFnR0UyZHM5WmdrVFhhc215VHZ0ZUM2U2VkeGpVOHVDSmg0Zm1N?= =?utf-8?B?dHRNWjUrbGdDdXlNTStreUJINkwyaHQ1QSt6d1ZSRytIMk92UXpGYmtNcyts?= =?utf-8?B?cWE4V21reDMxS3UvSkpWaFRJeitrMkRqZVZZOExWQWNCcU14TEVZWkp2VThW?= =?utf-8?B?TVJLQWZGSXNDWTl5MHFwTUlJNWNPOFd1Qkt6dEc1VThEajdPYmN4dEUvdXZ6?= =?utf-8?B?Q3RvcWJjM3NWTnUvOHMwYkJaMGpsaUdoNEtkRXN3ZDFuZkwxU3k4VVVhRE9O?= =?utf-8?B?N3NsU0FrUEtUZ29tRzkwMHIzRnRvSDZldDhPd3h6aG1uWUN4WjRIQUMwUENM?= =?utf-8?B?WnBJdkFCa0xFU2FqVnptZ3pJSzYwN0FjazQzbkkxL2IyZzBEZHNDUTh3aHFV?= =?utf-8?B?ZTVuVEF1Q2lGNHYxbk41Vm5IcENPSTlCNUxHYndidGovdUZRTUliV3NCOGFo?= =?utf-8?B?am5Na3Yyejh3WEpXckZoQ0k5c1N6ZStsMGMvVVJwWlYxdVJKODlLWlA4V0V4?= =?utf-8?B?ejQ1S093VXhQZlFYOGRWSlpPbTFkYzByaXNrbTZwVjE4RDZ0T2hMVjY3dEFy?= =?utf-8?B?cDhOSWhIM0pURHJ5c21SZTVyUjVPYWpVY2ZLSWVyVldNOW1aN05GRmVFaDE4?= =?utf-8?B?WUFLSjBzYngrZTBBR3ZVbHdrUU45dU95NlpQTDBSMkgvM1FhRHBFKzRxZmVi?= =?utf-8?B?b1NhWlBmVHNITmZTdTBUN1ZWK1d2Rm5SdlpGR1JmS3NUODJPdHhNdkZyQ2tp?= =?utf-8?B?UlhaUDNDRGx3YzBSbURBVU12TlA4MkprMzFqZTdVZDhObXF5eGpSTHJ0WFg0?= =?utf-8?B?NVpLVTlsZUhOOWpKNUpxZWtLZGJrT3ZDUThYS2ZUUFdDTi91SHkyckI0OFUz?= =?utf-8?B?TnVCSzNjaFpjR2JCeERDMTFiTDRGYTBOTTZqK21wS2F5N0dMd2tudWxaTXk3?= =?utf-8?B?TTE0RkltNWp4RVJUTGR1aUtCYzY4UWYxMjRlSWRTaWd5cVRCUGpjVjlyd0Fq?= =?utf-8?B?azhOZEt4anlOb1JQTk1uRitIV0NvY3R5M01PN1BDVElvdEYwOTZVRFRyVlFE?= =?utf-8?Q?eLxiAz6vXTG+N1fM3C1pzowsj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36c64598-9dc4-482f-36b8-08db19a8766c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:25:53.6623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qnpcB9zh8/ipydRFSeWtDb8hkL+b9arfKvuiyThqM9v3hTJk505plIW1aThINlAeV81RPBUeCpGj67IJy6g1xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8927 On 31.08.2022 16:11, Volodymyr Babchuk wrote: > There are number of cases where pcidevs_lock() is used to protect > something that is not related to PCI devices per se. > > Probably pcidev_lock in these places should be replaced with some > other lock. > > This patch is not intended to be merged and is present only to discuss > this use of pcidevs_lock() For all such instances it needs to be understood what (if anything) is being protected and how the same guarding can be achieved in the new model. Since I'm afraid that's simply stating the obvious, I guess I don't really understand what needs discussing here. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:28:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:28:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503546.775828 (Exim 4.92) (envelope-from ) id 1pX2pi-00083h-AU; Tue, 28 Feb 2023 16:28:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503546.775828; Tue, 28 Feb 2023 16:28:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2pi-00083a-7e; Tue, 28 Feb 2023 16:28:06 +0000 Received: by outflank-mailman (input) for mailman id 503546; Tue, 28 Feb 2023 16:28:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2pg-00083U-HV for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:28:04 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id defb932c-b784-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:28:02 +0100 (CET) Received: by mail-lf1-x12f.google.com with SMTP id f18so13991536lfa.3 for ; Tue, 28 Feb 2023 08:28:02 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id c17-20020ac244b1000000b004d42bbf6c82sm1380465lfm.105.2023.02.28.08.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 08:28:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: defb932c-b784-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=GDmqRt6BRoF6P7eRRBRNLbdMAd8VY87wVP3Vq4+lUGs=; b=FqoJedvuPLt3CcL4WYPMEhTvziMXI0+fXdhR0jFgSGBCXRNxOXE9jLxc17SE1hAhks sepW9nvjtReYh0cLWUn68x1zOzYAC8J8fpblCudnM8hH6EmEAoPrhsdd4aHntOIK7ZDW g0zkw7h60FpZoh2X7LENCa2XJL3MW4fQi438iIIjnd7nDwSbiA3YpXcBxe91FfOvcALP BxPXKceyyReZ7agL9x5cGjvrCu7lR8xGjyKRixYNq1aQFamRTsiz3CiSuDmh/A/qbO75 aJR6Vdxzd+nYg4KcaVTH0hytRI70niF2cCnA5ki5wFa7dz3Io+LNUuOLs6KseJPu+mE8 CpFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GDmqRt6BRoF6P7eRRBRNLbdMAd8VY87wVP3Vq4+lUGs=; b=vtseYitqv9SNvXGGvjTmee84goEeIJRejY1B93O5EaxIo3Q6IIVhDBSNW6N1LXZVGK pUcpZKx4dYoxSprjMGFp+tY154TQO2m/aTuGiU84g73kEuswJzNf4m4WymdgUsJigmxX fXQlU2kZQc9/qW69qSlkak8pcu2TTGZzl5Fzcln6rm/ujkfyfv3F0S93zqbeOomRd8Jl pjn5loqp193eL3HM6HOnO42LbbX4RG+HpF6plaRuX/M90KUTlO7rJHvBKbM+JzFPcBZQ 3S0FlkSaSsudSOkVA8NBS0zA7x2uznGRoCjZ6xvV1J6VJp7A5+2IOl1cq+/rxAwhcSzr WUZA== X-Gm-Message-State: AO0yUKW2HpPvfsL/J3LGZrmYWKjOOiF3poFat3vZ9ATYBNRuQaQ5KBG1 Y64gU19BukjZXPq1WXlMhxQ= X-Google-Smtp-Source: AK7set9jMdYxS13I/blira2KSDjCf2/s4BsC2aI0S5zb1pVz8MpupYeP3GfBbq0FeeVT64zJRQtcTA== X-Received: by 2002:ac2:4c3c:0:b0:4d8:4fd6:418a with SMTP id u28-20020ac24c3c000000b004d84fd6418amr828690lfq.6.1677601681805; Tue, 28 Feb 2023 08:28:01 -0800 (PST) Message-ID: <48e16f406cd85fea531c736f1f213038f8282613.camel@gmail.com> Subject: Re: [PATCH v3 4/4] xen/x86: switch x86 to use generic implemetation of bug.h From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 28 Feb 2023 18:28:00 +0200 In-Reply-To: <90ec98cc-e416-05c3-f507-5e4b2b7f937d@suse.com> References: <38bb75b9add8655288347aa4df1394450e4e10c9.1677233393.git.oleksii.kurochko@gmail.com> <90ec98cc-e416-05c3-f507-5e4b2b7f937d@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 T24gTW9uLCAyMDIzLTAyLTI3IGF0IDE1OjQ2ICswMTAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAyNC4wMi4yMDIzIDEyOjMxLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ID4gVGhlIGZvbGxv d2luZyBjaGFuZ2VzIHdlcmUgbWFkZToKPiA+ICogTWFrZSBHRU5FUklDX0JVR19GUkFNRSBtYW5k YXRvcnkgZm9yIFg4Ngo+ID4gKiBVcGRhdGUgYXNtL2J1Zy5oIHVzaW5nIGdlbmVyaWMgaW1wbGVt ZW50YXRpb24gaW4gPHhlbi9idWcuaD4KPiA+ICogQ2hhbmdlIHByb3RvdHlwZSBvZiBkZWJ1Z2dl cl90cmFwX2ZhdGFsKCkgaW4gYXNtL2RlYnVnZ2VyLmgKPiA+IMKgIHRvIGFsaWduIGl0IHdpdGgg Z2VuZXJpYyBwcm90b3R5cGUgaW4gPHhlbi9kZWJ1Z2dlci5oPi4KPiA+ICogVXBkYXRlIGRvX2lu dmFsaWRfb3AgdXNpbmcgZ2VuZXJpYyBkb19idWdfZnJhbWUoKQo+ID4gCj4gPiBTaWduZWQtb2Zm LWJ5OiBPbGVrc2lpIEt1cm9jaGtvIDxvbGVrc2lpLmt1cm9jaGtvQGdtYWlsLmNvbT4KPiAKPiBI bW0sIHRoZXJlJ3MgdGhlIHF1ZXN0aW9uIG9mIHdoZXJlIHRvIGRyYXcgdGhlIGJvdW5kYXJ5IGJl dHdlZW4gcGF0Y2gKPiAyCj4gYW5kIHRoZSBvbmUgaGVyZS4gUGVyc29uYWxseSBJJ2Qgc2F5IHRo ZSBlYXJsaWVyIHBhdGNoIHNob3VsZCBkcm9wCj4gZXZlcnl0aGluZyB0aGF0IGJlY29tZXMgcmVk dW5kYW50IHRoZXJlLiBJIGNhbiBzZWUgdGhlIG1vcmUKPiBtaW5pbWFsaXN0aWMKPiBlYXJsaWVy IGNoYW5nZSBhcyB2aWFibGUsIGJ1dCB0aGVuIHRoZSBkZXNjcmlwdGlvbiB0aGVyZSBuZWVkcyB0 byBzYXkKPiB3aHkgdGhpbmdzIGFyZSBiZWluZyBrZXB0IHdoaWNoIC0gaW4gcHJpbmNpcGxlIC0g Y291bGQgYmUgZHJvcHBlZC4KVGhlbiBJJ2xsIHVwZGF0ZSB0aGUgY29tbWVudCBtZXNzYWdlIGZv ciBwYXRjaCAyLgo+IAo+ID4gLS0tIGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2J1Zy5oCj4g PiArKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vYnVnLmgKPiA+IEBAIC0zLDc1ICszLDEw IEBACj4gPiDCoAo+ID4gwqAjaWZuZGVmIF9fQVNTRU1CTFlfXwo+ID4gwqAKPiA+IC0jZGVmaW5l IEJVR19GUkFNRV9TVFJVQ1QKPiA+ICsjZGVmaW5lIEJVR19JTlNUUsKgwqDCoMKgwqDCoCAidWQy Igo+ID4gKyNkZWZpbmUgQlVHX0FTTV9DT05TVMKgwqAgImMiCj4gPiDCoAo+ID4gLXN0cnVjdCBi dWdfZnJhbWUgewo+ID4gLcKgwqDCoCBzaWduZWQgaW50IGxvY19kaXNwOkJVR19ESVNQX1dJRFRI Owo+ID4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgbGluZV9oaTpCVUdfTElORV9ISV9XSURUSDsKPiA+ IC3CoMKgwqAgc2lnbmVkIGludCBwdHJfZGlzcDpCVUdfRElTUF9XSURUSDsKPiA+IC3CoMKgwqAg dW5zaWduZWQgaW50IGxpbmVfbG86QlVHX0xJTkVfTE9fV0lEVEg7Cj4gPiAtwqDCoMKgIHNpZ25l ZCBpbnQgbXNnX2Rpc3BbXTsKPiA+IC19Owo+ID4gLQo+ID4gLSNkZWZpbmUgYnVnX2xvYyhiKSAo KGNvbnN0IHZvaWQgKikoYikgKyAoYiktPmxvY19kaXNwKQo+ID4gLSNkZWZpbmUgYnVnX3B0cihi KSAoKGNvbnN0IHZvaWQgKikoYikgKyAoYiktPnB0cl9kaXNwKQo+ID4gLSNkZWZpbmUgYnVnX2xp bmUoYikgKCgoKChiKS0+bGluZV9oaSArICgoYiktPmxvY19kaXNwIDwgMCkpCj4gPiAmwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAoKDEgPDwgQlVHX0xJTkVfSElfV0lEVEgpIC0gMSkpCj4gPiA8 PMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgQlVHX0xJTkVfTE9fV0lEVEgpCj4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgKCgoYiktPmxpbmVfbG8gKyAoKGIpLT5wdHJfZGlzcCA8IDApKQo+ID4gJsKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKCgxIDw8IEJVR19MSU5FX0xPX1dJRFRIKSAtIDEpKSkKPiA+IC0jZGVm aW5lIGJ1Z19tc2coYikgKChjb25zdCBjaGFyICopKGIpICsgKGIpLT5tc2dfZGlzcFsxXSkKPiA+ IC0KPiA+IC0jZGVmaW5lCj4gPiBfQVNNX0JVR0ZSQU1FX1RFWFQoc2Vjb25kX2ZyYW1lKcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAKPiA+IMKgIFwKPiA+IC3CoMKgwqAgIi5MYnVnJT06Cj4gPiB1ZDJcbiLCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3C oMKgwqAgIi5wdXNoc2VjdGlvbiAuYnVnX2ZyYW1lcy4lY1tiZl90eXBlXSwgXCJhXCIsCj4gPiBA cHJvZ2JpdHNcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgIi5w MmFsaWduCj4gPiAyXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoAo+ID4gIi5MZnJtJT06XG4iwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqDCoMKg wqAgXAo+ID4gLcKgwqDCoCAiLmxvbmcgKC5MYnVnJT0gLSAuTGZybSU9KSArCj4gPiAlY1tiZl9s aW5lX2hpXVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgXAo+ID4gLcKgwqDCoCAiLmxvbmcgKCVjW2JmX3B0cl0gLSAuTGZybSU9KSArCj4gPiAl Y1tiZl9saW5lX2xvXVxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgXAo+ID4gLcKgwqDCoCAiLmlmICIgI3NlY29uZF9mcmFtZQo+ID4gIlxuIsKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoCAiLmxvbmcgMCwgJWNb YmZfbXNnXSAtCj4gPiAuTGZybSU9XG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKg wqAKPiA+ICIuZW5kaWZcbiLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAKPiA+IMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoAo+ID4gIi5wb3Bz ZWN0aW9uXG4iwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAK PiA+IMKgwqDCoMKgwqAgXAo+ID4gLQo+ID4gLSNkZWZpbmUgX0FTTV9CVUdGUkFNRV9JTkZPKHR5 cGUsIGxpbmUsIHB0ciwKPiA+IG1zZynCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgIFtiZl90eXBlXcKgwqDCoCAiaSIK PiA+ICh0eXBlKSzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4g LcKgwqDCoCBbYmZfcHRyXcKgwqDCoMKgICJpIgo+ID4gKHB0cikswqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLcKgwqDCoCBbYmZfbXNnXcKgwqDCoMKgICJp Igo+ID4gKG1zZykswqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ ID4gLcKgwqDCoCBbYmZfbGluZV9sb10gImkiICgobGluZSAmICgoMSA8PCBCVUdfTElORV9MT19X SURUSCkgLQo+ID4gMSkpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgPDwKPiA+IEJVR19ESVNQX1dJ RFRIKSzCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgW2JmX2xpbmVfaGldICJpIiAoKChsaW5l KSA+PiBCVUdfTElORV9MT19XSURUSCkgPDwKPiA+IEJVR19ESVNQX1dJRFRIKQo+ID4gLQo+ID4g LSNkZWZpbmUgQlVHX0ZSQU1FKHR5cGUsIGxpbmUsIHB0ciwgc2Vjb25kX2ZyYW1lLCBtc2cpIGRv Cj4gPiB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAg QlVJTERfQlVHX09OKChsaW5lKSA+PiAoQlVHX0xJTkVfTE9fV0lEVEggKwo+ID4gQlVHX0xJTkVf SElfV0lEVEgpKTvCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgQlVJTERfQlVHX09OKCh0 eXBlKSA+PQo+ID4gQlVHRlJBTUVfTlIpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgIGFz bSB2b2xhdGlsZSAoCj4gPiBfQVNNX0JVR0ZSQU1FX1RFWFQoc2Vjb25kX2ZyYW1lKcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOjogX0FTTV9CVUdGUkFNRV9JTkZPKHR5cGUs IGxpbmUsIHB0ciwgbXNnKQo+ID4gKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC19IHdo aWxlICgwKQo+ID4gLQo+ID4gLQo+ID4gLSNkZWZpbmUgV0FSTigpIEJVR19GUkFNRShCVUdGUkFN RV93YXJuLCBfX0xJTkVfXywgX19GSUxFX18sIDAsCj4gPiBOVUxMKQo+ID4gLSNkZWZpbmUgQlVH KCkgZG8ge8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAtwqDCoMKgIEJV R19GUkFNRShCVUdGUkFNRV9idWcswqAgX19MSU5FX18sIF9fRklMRV9fLCAwLCBOVUxMKTvCoMKg wqDCoMKgIFwKPiA+IC3CoMKgwqAgdW5yZWFjaGFibGUoKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgXAo+ID4gLX0gd2hpbGUgKDApCj4gPiAtCj4gPiAtLyoKPiA+IC0gKiBUT0RP OiB1bnRhbmdsZSBoZWFkZXIgZGVwZW5kZW5jZXMsIGJyZWFrIEJVSUxEX0JVR19PTigpIG91dCBv Zgo+ID4geGVuL2xpYi5oLAo+ID4gLSAqIGFuZCB1c2UgYSByZWFsIHN0YXRpYyBpbmxpbmUgaGVy ZSB0byBnZXQgcHJvcGVyIHR5cGUgY2hlY2tpbmcKPiA+IG9mIGZuKCkuCj4gPiAtICovCj4gPiAt I2RlZmluZSBydW5faW5fZXhjZXB0aW9uX2hhbmRsZXIoZm4pwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgZG8ge8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3C oMKgwqDCoMKgwqDCoCAodm9pZCkoKGZuKSA9PSAodm9pZCAoKikoc3RydWN0IGNwdV91c2VyX3Jl Z3MgKikpTlVMTCk7IFwKPiA+IC3CoMKgwqDCoMKgwqDCoCBCVUdfRlJBTUUoQlVHRlJBTUVfcnVu X2ZuLCAwLCBmbiwgMCwgTlVMTCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+IC3CoMKg wqAgfSB3aGlsZSAoIDAgKQo+ID4gLQo+ID4gLSNkZWZpbmUgYXNzZXJ0X2ZhaWxlZChtc2cpIGRv IHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKPiA+IC3CoMKgwqAgQlVHX0ZSQU1FKEJVR0ZSQU1FX2Fzc2VydCwgX19MSU5F X18sIF9fRklMRV9fLCAxLCBtc2cpO8KgwqDCoMKgIFwKPiA+IC3CoMKgwqAgdW5yZWFjaGFibGUo KTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gLX0gd2hpbGUgKDApCj4g PiAtCj4gPiAtI2Vsc2XCoCAvKiAhX19BU1NFTUJMWV9fICovCj4gPiArI2Vsc2UKPiAKPiBXaGls ZSBmb3IgbmV3ICNpZmRlZi1hcnkgc3VjaCBjb21tZW50cyBjYW4gcmVhc29uYWJseSBiZSBvbWl0 dGVkIHdoZW4KPiB0aGUgYmxvY2tzIGFyZSBzaG9ydCwgSSdkIHJlY29tbWVuZCBrZWVwaW5nIGV4 aXN0aW5nIGNvbW1lbnRzIChleGNlcHQKPiBpbiBleHRyZW1lIGNhc2VzKSBpbiB0aGUgaW50ZXJl c3Qgb2YgcmVkdWNlZCBjb2RlIGNodXJuLiBJbiB0aGUgY2FzZQo+IGhlcmUsIGNvbnNpZGVyaW5n IHRoYXQgLi4uCkdvdCBpdC4KPiAKPiA+IEBAIC0xMTMsNiArNDgsNiBAQCBzdHJ1Y3QgYnVnX2Zy YW1lIHsKPiA+IMKgI2RlZmluZSBBU1NFUlRfRkFJTEVEKG1zZynCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBc Cj4gPiDCoMKgwqDCoMKgIEJVR19GUkFNRSBCVUdGUkFNRV9hc3NlcnQsIF9fTElORV9fLCBfX0ZJ TEVfXywgMSwgbXNnCj4gPiDCoAo+ID4gLSNlbmRpZiAvKiAhX19BU1NFTUJMWV9fICovCj4gPiAr I2VuZGlmIC8qIF9fQVNTRU1CTFlfXyAqLwo+IAo+IC4uLiB5b3Uga2VlcCAoYnV0IGFsdGVyIC0g cGxlYXNlIGRvbid0KSB0aGUgY29tbWVudCBvbiB0aGUgI2VuZGlmLAo+IHRoYXQncyBldmVuIG1v cmUgc28gYSByZWFzb24gdG8gYWxzbyBrZWVwIHRoZSBjb21tZW50IG9uICNlbHNlLgo+IAo+ID4g LS0tIGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2RlYnVnZ2VyLmgKPiA+ICsrKyBiL3hlbi9h cmNoL3g4Ni9pbmNsdWRlL2FzbS9kZWJ1Z2dlci5oCj4gPiBAQCAtMTQsOSArMTQsOSBAQAo+ID4g wqAKPiA+IMKgLyogUmV0dXJucyB0cnVlIGlmIEdEQiBoYW5kbGVkIHRoZSB0cmFwLCBvciBpdCBp cyBzdXJ2aXZlYWJsZS4gKi8KPiA+IMKgc3RhdGljIGlubGluZSBib29sIGRlYnVnZ2VyX3RyYXBf ZmF0YWwoCj4gPiAtwqDCoMKgIHVuc2lnbmVkIGludCB2ZWN0b3IsIHN0cnVjdCBjcHVfdXNlcl9y ZWdzICpyZWdzKQo+ID4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgdmVjdG9yLCBjb25zdCBzdHJ1Y3Qg Y3B1X3VzZXJfcmVncyAqcmVncykKPiA+IMKgewo+ID4gLcKgwqDCoCBpbnQgcmMgPSBfX3RyYXBf dG9fZ2RiKHJlZ3MsIHZlY3Rvcik7Cj4gPiArwqDCoMKgIGludCByYyA9IF9fdHJhcF90b19nZGIo KHN0cnVjdCBjcHVfdXNlcl9yZWdzICopcmVncywgdmVjdG9yKTsKPiAKPiBJIHZpZXcgY2FzdHMg aW4gZ2VuZXJhbCBhcyByaXNreSBhbmQgaGVuY2UgcHJlZmVyYWJsZSB0byBhdm9pZC4KPiBDYXN0 aW5nCj4gYXdheSBjb25zdC1uZXNzIGlzIHBhcnRpY3VsYXJseSBwcm9ibGVtYXRpYy4gSSBndWVz cyB0aGUgbGVhc3QgYmFkCj4gb3B0aW9uIGlzIHRvIGRyb3AgY29uc3QgZnJvbSB0aGUgZG9fYnVn X2ZyYW1lKCkncyBwYXJhbWV0ZXIgYWdhaW4gaW4KPiBwYXRjaCAxLiBIb3dldmVyLCBmb3IgYSBm YXRhbCB0cmFwIChhc3N1bWluZyB0aGF0IHJlYWxseSBfaXNfIGZhdGFsLAo+IGkuZS4gZXhlY3V0 aW9uIGNhbm5vdCBjb250aW51ZSksIG5vdCBhbGxvd2luZyByZWdpc3RlciBzdGF0ZSB0byBiZQo+ IGFsdGVyZWQgbWFrZXMga2luZCBvZiBzZW5zZS4gU28gSSB3b25kZXIgd2hldGhlciB3ZSBjb3Vs ZG4ndCBwdXNoIHRoZQo+IGNhc3RpbmcgaW50byB0aGUgZ2Ric3R1YiBmdW5jdGlvbnMuIEJ1dCBx dWl0ZSBsaWtlbHkgdGhhdCdzIGdvaW5nIHRvCj4gYmUgdG9vIGludHJ1c2l2ZSBmb3IgcmUtd29y ayBsaWtlIHlvdSBkbyBoZXJlLgpJIGFtIG5vdCBzdXJlIHRoYXQgY2FzdGluZyBpbnNpZGUgdGhl IGdkYnN0dWIgZnVuY3Rpb25zIHdpbGwgaGVscCBhcwpkb19idWdfZnJhbWUoKSBjYWxscyBkZWJ1 Z2dlcl90cmFwX2ZhdGFsKCkgd2hpY2ggaGFzIGRlZmluZSByZWdzIAp3aXRob3V0IGNvbnN0LiBT byBpdCB3aWxsIHN0aWxsIGJlIGNvbXBpbGUgaXNzdWUgYXMgaW4gZG9fYnVnX2ZyYW1lKCkKcmVn cyBhcmUgZGVjbGFyZWQgYXMgY29uc3QuCgpTbyBpdCBsb29rcyBsaWtlIHRoZSBiZXN0IG9uZSBp c3N1ZSBub3cgd2lsbCBiZSBkcm9wIGNvbnN0IGZyb20gdGhlCmRvX2J1Z19mcmFtZSgpLi4uCj4g Cj4gSmFuCn4gT2xla3NpaQo= From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:32:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503552.775838 (Exim 4.92) (envelope-from ) id 1pX2ti-0001Os-SI; Tue, 28 Feb 2023 16:32:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503552.775838; Tue, 28 Feb 2023 16:32:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2ti-0001Ol-PM; Tue, 28 Feb 2023 16:32:14 +0000 Received: by outflank-mailman (input) for mailman id 503552; Tue, 28 Feb 2023 16:32:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2th-0001Of-1J for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:32:13 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062c.outbound.protection.outlook.com [2a01:111:f400:fe0c::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72db79f0-b785-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:32:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9588.eurprd04.prod.outlook.com (2603:10a6:10:31d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Tue, 28 Feb 2023 16:32:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72db79f0-b785-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lHphhbs4YK0m288vgSsbPji34Djulleyjv2M2rOtEdrHX3XAE8Dv8Znd3rDeqfjERvqc8HBbgt4tZTz+7BT+RuzCATaDsXR5vmt76bQqJ0gbHOddJsE9kwwbQbz8RDkR+8JrFFAv78KgtnKvBHfXhNr427MTPhrHY90ZcTnbO/KGB6jdHcdf9QFgs9Q1G0rrCLik4VR62PfB5+xzzu17KmDlPC+8404yvvJIMhZtXf7uR0M94CDaRMyLpoEmUUBNbF2ReJmcFMD1h22uED3vNpaOWS9kj17+RgjV82RW5SPkqpBzyES5E4Pst68xJlSphzGCfSTgY2ONzH5ZH7lElg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bYUVFIcS25dqJO08hhaGprZVW3JltPGrYCBaCpsQnG4=; b=MnQvc7f6Ki00Wwx25r4ruuLlOkk5Y2eJD/K70+LjU4CDTJoo0CY3EkSyevmUWhszZipIrkQNSqAKoCJdC6WGBDXZlC5IAJgrwWP1OPxD5eD1jalMjZJK/q3lGrXvbuqFez7aDdxtIQfufVLIv/tfV8vvJGGWMSnJxE72loYE6FpmUgx6GWdBuqMTy/vcjVXgzMF/S7ROB+qxCThqIXFnIA+iKlY5ilO/f3QNHEaKZuIimSpFFZnbcdrmVG5LaikEzSZOMOVoaKpLbuitIn5o3c1yvD3ly4jhZOJJUAMY4eWlJSc/+sNXYY50ge/JgoKVtpk5XioPPoz+fQCyjf7XTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bYUVFIcS25dqJO08hhaGprZVW3JltPGrYCBaCpsQnG4=; b=QtfESXX+tKq+WfkcvM6ZweSGrwyZB03EZs6gIYRfYjpRP2GmxSso5J1dUrDza2clM4v4oLjEd3Y1N9/exYcIFTKwk7Q0WxSnjwGaB0RBXGNNDq62No+XTm0Cmjr0xRBV5L53YqGK+il6BwxMk/99dbVVfNUXzlujOSDqZYEmwADRJ9+Ekdll6tWZkMJYiY0UpvhDaax/w0eHAq9ayJ4qbRYOc6GYkUD/u8vbQVBMfmeYXzc9IMiHms7e9dcQdgDImDbqp2R41SRfIGHc2OwZCoOJyXYckiNArkJgXrPa2jqwbAwpvITGW44/MFxYU/n1MkVZ6TJPPtl1jQPiNg24UA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <38c11152-2f35-8683-51fe-603828dd4963@suse.com> Date: Tue, 28 Feb 2023 17:32:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 02/10] xen: pci: add pci_seg->alldevs_lock Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-3-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-3-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU0PR04MB9588:EE_ X-MS-Office365-Filtering-Correlation-Id: 541a7e30-fd60-4502-2e4f-08db19a95546 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UymOdWjU+Gciz2Hp6UlEDkt4lVj8odamj0E82yKTP2F7A0pf1O+bC8+8tmSXGyEunVxLrDONSUkkbUClCUQ0eEEW3Vxlr2k60D5F9Mldz8Fz5f5a6Akqawp4ONdLAQH6EaVAw6XjLftSDZahULIkRS4xypft0GaviP19718KJ35ZcLP8kHSiqyF1Pitx/SD7oKFcuRGPDKLAGMBvsD5+osdrwaHpfqCg3k4tJ70QlI1vdpn5oyrf8KyVM0qPtQbketzIwJ7K0FRmlHOtRMk41jx1JkSRlCpBptBflaeJrJsBcSXDHDeWfSPG8ef8y8cw3DXCkoYvso0qyKjocIpSeRGWC4od93Ddju8jwpp9Rp/AYrIo4Msm5LPCCAEERMgwMSLIM6a5cNNPzgS26Q3po0kDOv+47K1J0OYR3OcunXjoi5WhbpVL+X1KK9ERtlu2cGELm8TyCDFB9JiEpJRfouyLsyYXKrrbKlE5JQhz8KwiTHVIx9XK90r3DJi3Rx2Q8DrwstuRy+sFCLlJAPfWVI25LJxm3AhX2KkJI3Af2/xpJdecu2T/2N/RvKog1NS14bH4/CQPJM13yEKFJNFeFNtQ60bWdT9ZBUArC7kn5cUqhxuGiDGH1WPvlGDU/gvDrv42td5ZGh0FpmQ5A9koyQRVuw2ZpS9sRqVO2abXVTx7NtYerKl7dKUQz4do2ZPuPtleG+OKZsoL0t2w+aPRg2bPwVQOtbpIB7sQsBC2Kf0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(366004)(39860400002)(136003)(346002)(451199018)(83380400001)(4744005)(8936002)(2616005)(31686004)(2906002)(5660300002)(38100700002)(41300700001)(8676002)(6512007)(6506007)(4326008)(66556008)(66476007)(66946007)(478600001)(6916009)(53546011)(26005)(186003)(316002)(6486002)(31696002)(54906003)(36756003)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkc4dU04MDU1VnkrZHREcGR3djk5dVgwRWk4cUxER3pLWmNHZUxtSHBjekpj?= =?utf-8?B?Z2U4NjhDUkxSelFxaUZNWlp4TDhCSlRaWmt5TTJMZXJTS1JIUVgyclFaOGxu?= =?utf-8?B?dlo4d1loeGkwR09LRVB5MHhyQlJhQWF0cWNya000TU9XMUNzTXNwbkZ1bThl?= =?utf-8?B?UVJDSzZ3VmNyM1k3WWhLanRNN0ZucUZBNVcyaGltQ2QrRTdhTVVLTkcwZmVG?= =?utf-8?B?cGk5UlJhRnRJU0tGVzM5L3NqR1ZZVlpmcG00YzBIcjBqdFJLS3M1MXMxMUYr?= =?utf-8?B?aDJCT3g2WW9rL3hER3EvUDBveC9pWmV0Rk5lLzVsbkZldTEyVzcxNTFYVElK?= =?utf-8?B?UVY4cHNnUkhQcERaWU1KVTdMajdKS09vbjBMcEMrRzVxL3BsWEFrQjk2aGY3?= =?utf-8?B?K25SYlNkVkNyZ0JkVkdSVlg3NDk4ekxqNDJZd0g2UnFZZm9qK1A5QllnN2tD?= =?utf-8?B?VEVsb0tmdzFNcWpLVEV4bi9qSG5mYlpvSmYxcmY2UUtkc3R5ZnEvM1Rna09V?= =?utf-8?B?MW16UmNoTzhiZXV4VjRyTlVIeWJqNXFENkNhak5TN01jcjV3VDlTaWpvNGtw?= =?utf-8?B?MzlqS3dmcXFJa295bmtOa1UySnIyVmZKaXhYb2hiRjhlQk9ZSVlvVEV4eU12?= =?utf-8?B?QXA2eVVsN2lGNVFQSys3ZnZ5ZFhiaUJzV3g0dWZKRGgzVmVwdXhiaG5TRWxm?= =?utf-8?B?RlQzWERyOStnaFBVUmpOU01IcVoyWER0cHRRM2tLSXU3ei9DNWxoWmJJZUxq?= =?utf-8?B?VFUwS0hYblIzbWdYamxGekZZZkgrZmhud0VabE1wZWw3bUYzVXU5cnFKcFgx?= =?utf-8?B?MzEvUTJPK2Rqa0FCc2ZzVVBielZob1V6MVdmMHFzT2piSWd1MTRnMmJFNmp6?= =?utf-8?B?amRFYmFGcFRBMWwvL0w5YVAwZTZlTlZINnpVR3YraisvZ2xVYTV1YmRhZFR0?= =?utf-8?B?VytMTGovazZkbDJiaU5PNTFLN3VUTWM1OHhlZ3l0elhwSk5CUjAwK2t6Kzlh?= =?utf-8?B?K0FIc0xCcHMxQSs0YmRKbCtoV3Q1T09sRXpYenovdmZFWis5cm92Y0xpMWMw?= =?utf-8?B?UGFLWXFoMWM3a3RJMU8wZXkvdTl0WDZsdEsxRitjRXh4VjdCQ0w0SmNIQ1VK?= =?utf-8?B?b1hMYjNncHhpT2lDanNUbzZFaDhnU21qUW5PZzBtNFdhQkh0QXpoa0QyUXlq?= =?utf-8?B?SWpEUDY4UkVxZHB3UFdJK0N5Q3hsZng2OTRsTFZyVFlTenNCY1lxSjF0SmFq?= =?utf-8?B?c3c0Qk1zRmhNRmhJTjdlUUx5RmZUUmN1T0Q5R3pkWENUQ2I0V0thU3BySmpY?= =?utf-8?B?SHBOMXhKSTJiL1p3bnlnTThMTVBKRVRvWU9OcmZESm96cjJ5Z0RtRENMMXVC?= =?utf-8?B?UHpLem5MVEJkR0ZxbnpuZHQwSUdUeFlVTGIveEp1NXZzNmMzQVJpaktQdURY?= =?utf-8?B?MTNKdWU3dnpvTTM5MnRrZ3dVQXlEdDJ3QkRuVlhaWFZxVE5QRG90USs4eXIr?= =?utf-8?B?SHFkSXQ4cjljY3dOUFRZWWFNbklzL2pRVllOSXJlZTArdHdydDlnMnpqNDAw?= =?utf-8?B?Nm9hbmtJRTg3U1RXZHBlYjhwS3V6bUtDaUxzWVlaaWtBc1ZzTHUzNVd4aVJj?= =?utf-8?B?aEl3SWJhYWM1M0FNUnhUcmV6VDdjNnlRT3g4M1RrNlFPbGsvK0dIVzJuTUJ4?= =?utf-8?B?SVArYjdjM3NzSkRwRVpLdWZ6cG5UQk5NV1o2bGk3c0tSdkFyVDNadWpnMHI3?= =?utf-8?B?YnpISnRwbGszbm91MWx6VythWjB2Uit2K2hzR2Vtc09QcnZLL3FScG9EQ1RO?= =?utf-8?B?OFU5ZjB1UlBNdWFSM2ZYOURoYlZoWnc5VTVaS3FwZHhyR3htTExVMitEUG92?= =?utf-8?B?N0J4NG9aV2FLOVcrSU9OMk9vSlJVUzBZTGNxWXZJaHdBYVZlMDlWRzYxSkRM?= =?utf-8?B?U3FYN2ZvbW9IcnVJWkEreGowMnBrNnlNVEtpRmd1aWFCRWVDdEhYbGlibWRv?= =?utf-8?B?RXlkZHdTWjd1b1dkK05HSUhFZmw5ay8zUWxCZFZHWUlSdVh6TWorR2tmS29i?= =?utf-8?B?STdNUTR1YndtcTZVZkw5UkZIVHRGNXZEa28vRWlUYkJsQTNVMkl3WmZ2UkRz?= =?utf-8?Q?RNcRwFNoBaiPTdG0K04Cv9+EM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 541a7e30-fd60-4502-2e4f-08db19a95546 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:32:07.6387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BMDDhuTcJ0VHG81Rm+eElI9lOQIwOzRJ6AldwYk762ZmoFeXMLG1mN6uvU86E5uWZOOgV5dJVxysZ1oKM26yoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9588 On 31.08.2022 16:10, Volodymyr Babchuk wrote: > This lock protects alldevs_list of struct pci_seg. As this, it should > be used when we are adding, removing on enumerating PCI devices > assigned to a PCI segment. > > Radix tree that stores PCI segment has own locking mechanism, also > pci_seg structures are only allocated and newer freed, so we need no > additional locking to access pci_seg structures. But we need a lock > that protects alldevs_list field. > > This enables more granular locking instead of one huge pcidevs_lock > that locks entire PCI subsystem. Please note that pcidevs_lock() is > still used, we are going to remove it in subsequent patches. Just a thought: To limit the scope of the steps taken, would it be a possibility (and useful) to move from the global to the per-segment lock, extending what this per-segment lock is actually protecting? And only then take further steps, as already done in later parts of this series? Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:36:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:36:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503556.775848 (Exim 4.92) (envelope-from ) id 1pX2xc-00020R-CI; Tue, 28 Feb 2023 16:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503556.775848; Tue, 28 Feb 2023 16:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2xc-00020K-9H; Tue, 28 Feb 2023 16:36:16 +0000 Received: by outflank-mailman (input) for mailman id 503556; Tue, 28 Feb 2023 16:36:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX2xb-00020E-42 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:36:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0c::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0343aebf-b786-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:36:13 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7844.eurprd04.prod.outlook.com (2603:10a6:20b:236::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:36:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0343aebf-b786-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grPMp6iRcIq4HvQkE+U20njA/7t5MokBG8v0YlcDBmhnkJX0hFJwjQkRdd/Pezmso77xQUVG9aLMaORrJ66/nN+xyivN1+YHLKMADHx46WTX04F05SZSpfmWxu+DfW48dtZxv8Cghn4EJ/iwgqi+Nn6u9+GJsuexmPgSftmiJuqjGB3YR+Jz3FL6Bsx/zFTdOF4g+LvNq7O8Of8m0WUd7aJ6eToIsXSZGpz7go5xbKS9sG3AYFLx1FWmqfwsUCEyXUIzJtozRLCDzb3G5VJFZVha9RUfnZWP9J6E+ZCZK0qhz2qiYEgOHwcXpFM3Z+9r5TUWoP4qRUX+DEgRHCrA9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ufMg31m+Q+V40XItPgiZFw9nmEaMZayuZQeNAbRETwg=; b=dpf2EB1k8HCyl62+66Ekr95Fhr9k4m/H3hQzgkcPVfMN5e7p3ee+Fuku1nZ+HOWuuv4RN1Gafikidh4YCPZkQfys7MD59Cwn+jNx1s0/6RLIGBrYOQIDaqJ98COgGJaJHRmn98BbxhC4bZWA6eDalysRhpybJKMunHVI/zdOJOFJZqE5jv7jLeaQHKKBmYUZ3HyaOrMFC86Vc10DJ5ixGL2LmmgkQw0BYVySwT3yJSn4Jw6+6JTzkHpkQ/XThfYnyd12sA8RS5pph0h9VyTbb05e8XHnsUzS1daNgiiRK2CctUY5Dsl6sxXys4XoAIn264zR8164t7qu55wbYBjgUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ufMg31m+Q+V40XItPgiZFw9nmEaMZayuZQeNAbRETwg=; b=SUTZM20AUoKYuLXEUISIZ7IgXkk7peWG3Xj/BFrK32JNbkdtWWFUnbeHDtnOIhPoY5ND5oFr2S17my4LhCeujHCy/t9QxJFH19Ek+dggnYMcXB2qc6YWbGeGaku3vC31z+Uc4NUbCLCK/GXaO0DYCt2DjRxOsIEUAY9Q5CyqL9ieiJujkz31Yg+S2E8kHdfzmR+ppqjD1Z2lbQAEcGOGrOAJvrqpxlcdZfBZ5X6h+qrQqy93im1Lw/Kt17MoOs5uIIb61Pa2LH3c9rU+dUW+JEta5mXzPXE+YVP28j/9bGPAuK6cK/c+jFj3i4yxSPnX0LF2n/7pMR27pQiSaDkj8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <89b27c44-5287-ab31-1fa2-46b9762da272@suse.com> Date: Tue, 28 Feb 2023 17:36:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 4/4] xen/x86: switch x86 to use generic implemetation of bug.h Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Stefano Stabellini , Gianluca Guida , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <38bb75b9add8655288347aa4df1394450e4e10c9.1677233393.git.oleksii.kurochko@gmail.com> <90ec98cc-e416-05c3-f507-5e4b2b7f937d@suse.com> <48e16f406cd85fea531c736f1f213038f8282613.camel@gmail.com> From: Jan Beulich In-Reply-To: <48e16f406cd85fea531c736f1f213038f8282613.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7844:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e5a8276-7916-4fbf-7997-08db19a9e61f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: elhNgVkgkH6qNamoZ77LGQ79a57KBxGA3TUGFt0nPUGYaOjXYndw9TsLnphWEJXflIPoW85E9/enrK6oFwYJM+neTGg9RgoJ4/dHvzb1S5D8/jL3x8CjTlZs8R0bCfjOGNzHk10/TvtWKXztRmVVlRbscXgESt3AI4K0Q+u0DG6g1Gb3IEGjjuoHVSMAGSocxJT8P42wO9Yno+obTIW7Ft3zSkjcImQKuNrrZPkJ5X+2+DEYFIjyDZUUbF0cq4CbFF8I2vSi1w6G8uKFz0V8ItcxkmYchZn24eHAXl+IGsKt4Q+ADDDHhveFfNOZPbvNYRCL5d5J2nEAiqQmQGg/t2usUb9XgGvV2XQ1wStDZiFCCvfJTJLVBWoEnTnXJKiGAI/TXDZbtCM+csqW+TLosVEisssMLQHowlMkrOw3r8MJ75cMKwg95wj/PI8GHqTPLp0V7EDv1bj7Rhz7XE40I489lqoRoSIw2+Pyg8TEjbj3RVOiZllELkl5KzucSBZ6selglOPyn6avq4wK0hpa7YF7OsfZdkAdy95pZjm+guVaV4DnhqUT+9o3qVjLlMpa9eLY0o4C6THUyuaIhUpNG+AZfTkRku85Lj5vJehj1q+5Y2j5MsZDF7Vfkndv6B2iqvS1yzqoaR9SbeN9fGEKHPfR3va/RDYfQsNF3kiXK0wPJJMoKpAMySUlaCPokjDbXnP0JSh/URvvxl+NHmXgjUTLXTDko4/s6HupmKjj/AkGICeG4v4Q63OVDgee2Ged X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199018)(41300700001)(8936002)(31686004)(5660300002)(2906002)(66946007)(8676002)(66556008)(6916009)(66476007)(4326008)(54906003)(83380400001)(316002)(478600001)(6486002)(6506007)(36756003)(186003)(6512007)(53546011)(26005)(86362001)(38100700002)(2616005)(31696002)(41533002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzBuM2E0WFBNN1h2L1hkQ3FZR1AwSmdMZXVVeGd6OUN4K1NId3B6N2V5bWhN?= =?utf-8?B?SytGYXExdmlRMVRUTHZ5V1c2a0FCcjV5VXFOTkFaOGl2Q21UcnpXcVE3Lys0?= =?utf-8?B?UTJsK1Z0cFhWSXh6VmRBRmRFSHVhbGhDMmVDVU16dU8rR1BSaDFSQ3orWjRs?= =?utf-8?B?UmVpbmpYVC84UHZZTFp2UjcrTytubEQ3aEZCd2h4NVgzVWluaElYL3JpZ3c2?= =?utf-8?B?U0F3VXdwTzkzdUNiUUVuN0gydTJBa1VIdW5oclF6YzlPLzFMYTlYS25SemJT?= =?utf-8?B?dkk4Y1BYdzl2YS83eWFGUjdNbmcybzM0QUFLYXdqMjJDeFB3aUZMZUIxZDhM?= =?utf-8?B?Ym1WcFRZM1RidjdtOHhKYTB3NWtnbzFPS215aVB2MU5aVC95YmFxdEIzdk5M?= =?utf-8?B?RWJRQjVDSmNKdlNCbHc1ZUxwbkR6QVcxQ0huOHZJS29IL3g0Y1UxNGVlWVd0?= =?utf-8?B?N1lpSkF5K0ZXZGFGREdxZjhpVWNCaUtGa3ZCVm5jcCtzK29PSERJd0RXVU4z?= =?utf-8?B?ckMvZWtuN1ByaC8yS0p3c0hUNS9PZWxGbEpnYTY5MUViYmZ0SURIK1ROR1Nl?= =?utf-8?B?TkdsOFo4RHIyWXJ6bU1wb1cxUzVZSmFWQjFkc1FoYWdkbStzVDYzMXJSYzNB?= =?utf-8?B?RnhWNm8rMTU0ZGRobXJ6Z2haUW9BdXo2RmVMY2FNZGhkV0F5RFIrWFZsL0tJ?= =?utf-8?B?dmtIaTRmdFU2TmM5OHFVOUhEcm5pUGRDVXVaQ2ZDcS9DQ2dsdnR1aEtMRy83?= =?utf-8?B?UDhJcldld0t6Y25Dem4zY0ZkczVPeWptUjhaNnNFWWZZWFQrYlROMFZWRWRj?= =?utf-8?B?aDJubUsxL1ZkM080N0RxRWhiVVdxUnltMEIyUW5jZ2FwTGFYaWgxRzhqaDRM?= =?utf-8?B?bFZhT3BQc2wyazVhemdRcHpsL0h0UFZTRUJlSm9wVE5qSkdoejU1eGxJQ0U4?= =?utf-8?B?UmRmazJleWlvTVIvREM5dDVheVI2R0VsRmoxd1pYWk1ad1FUcWhwWkNyUnpW?= =?utf-8?B?dzlkdlh5TU9QWklsaDhOYmhrM1RmU0VhNWVmYXE3aVdWejdyVmpWK0FYRGpa?= =?utf-8?B?QXEwb21oS0t3eXppTjdkNklRZG1KZmJGa1lQTk1yTS9FN2hPZUNWT0ViNjI3?= =?utf-8?B?QlE4dFBiVGZVSmNmb3lKelVoQVp1c0lCVU1qbWpFT3Q0WDRYc2Q0NHFDdmxZ?= =?utf-8?B?TlM5V0VaNTFpVDNydjI2WUpqd3BaY05xQWZ2MGVaNkZ0UjZRbnE4OERGWFVn?= =?utf-8?B?UTR5a1lvT3RLZERVVGdyMVA3RnlhWWZ4dDFDR1A3VVBiclhzMVdZenFQbzhB?= =?utf-8?B?eWxiN1NzeUFnS0szN3FNem85UGRmYXcvOVcvVE1MbWZrOERjMWlWaTEyQVR5?= =?utf-8?B?eU9aNGNQb1hETkhoQll5SUhCWlowN1V0a1VvVlBIVi9YSUtQRjY3eUVhR1d5?= =?utf-8?B?clFhcE56VVlEZXRkYlptTjN0ZDJKdDFsV3AvZkFYWEFyamNXY1VSZHBIYk84?= =?utf-8?B?TXh6Y05xSjdIVENwRnA1VWdoQk5iczNnekFFaXgyZkl5WGp6MWlWdnRuQzRM?= =?utf-8?B?VjhFclU4R0J6TUtjODBud1pBYXRZRjh3OEM5WEMzQWo0U1U4NXZya1lTdjRV?= =?utf-8?B?L1FTTldGTUNnOUg5SzU3elVwb1RPMTQ2ZkFKeDJqNCtqdXVwbHRMQlhUTEFM?= =?utf-8?B?VjNjYVZKZ2JwclNTQnRyTzJXTGoweFNxVXVUVGdTQlRCcThNdmw2dm16eTVn?= =?utf-8?B?aXRPTHJMckJ1L20raHdkOThqUXJuSlppZ0U2SHRpdkdUcFd5SDRCbENMZjVD?= =?utf-8?B?S1pBN3JpRVhRN0hwSDNnamRwNXJRRnEwSTRWNjh6Q3J0MmExV0hCV3hJelFC?= =?utf-8?B?TUp2Yis3cENzbmpyWFBsUlJiVjlMeEpzcHVjaEJZbC9rTzBoMGFLems1TUZ6?= =?utf-8?B?VmZTNDlpR0VBVFUyMzJDbGdObCt3bStVT2lOdis4MmVJYXBONm9odjhPay9w?= =?utf-8?B?SHcrZyswb0JqV25QenRaYm82NUd4VUYwaHdOU20xU3hWaUhteW8zYVB3NzNz?= =?utf-8?B?Nkc4YW9TZHlPaXdwWjZpRi80S2hralhQTmk2NmdPK3hBSFA3L3pxNERTS0ZE?= =?utf-8?Q?RtdRGzXHD4gs5vmrUI2kYEEjh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e5a8276-7916-4fbf-7997-08db19a9e61f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:36:10.5609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uZI7XnIHfPyXrAQCVl9AfhziCGxsv5itBr5I7wnnhuvUtPaiOU5jzTiht8HvjDcVktPRvVUnD4aQbJ+R237EfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7844 On 28.02.2023 17:28, Oleksii wrote: > On Mon, 2023-02-27 at 15:46 +0100, Jan Beulich wrote: >> On 24.02.2023 12:31, Oleksii Kurochko wrote: >>> --- a/xen/arch/x86/include/asm/debugger.h >>> +++ b/xen/arch/x86/include/asm/debugger.h >>> @@ -14,9 +14,9 @@ >>>   >>>  /* Returns true if GDB handled the trap, or it is surviveable. */ >>>  static inline bool debugger_trap_fatal( >>> -    unsigned int vector, struct cpu_user_regs *regs) >>> +    unsigned int vector, const struct cpu_user_regs *regs) >>>  { >>> -    int rc = __trap_to_gdb(regs, vector); >>> +    int rc = __trap_to_gdb((struct cpu_user_regs *)regs, vector); >> >> I view casts in general as risky and hence preferable to avoid. >> Casting >> away const-ness is particularly problematic. I guess the least bad >> option is to drop const from the do_bug_frame()'s parameter again in >> patch 1. However, for a fatal trap (assuming that really _is_ fatal, >> i.e. execution cannot continue), not allowing register state to be >> altered makes kind of sense. So I wonder whether we couldn't push the >> casting into the gdbstub functions. But quite likely that's going to >> be too intrusive for re-work like you do here. > I am not sure that casting inside the gdbstub functions will help as > do_bug_frame() calls debugger_trap_fatal() which has define regs > without const. So it will still be compile issue as in do_bug_frame() > regs are declared as const. Well, the idea was of course to propagate const further down, to cast it away only in restricted cases. But ... > So it looks like the best one issue now will be drop const from the > do_bug_frame()... ... looks like we're in agreement then about this being the better route for the time being. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:47:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503567.775858 (Exim 4.92) (envelope-from ) id 1pX38M-0003tv-Fz; Tue, 28 Feb 2023 16:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503567.775858; Tue, 28 Feb 2023 16:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX38M-0003to-DI; Tue, 28 Feb 2023 16:47:22 +0000 Received: by outflank-mailman (input) for mailman id 503567; Tue, 28 Feb 2023 16:47:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX38L-0003th-Kp for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:47:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9056640f-b787-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:47:19 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8241.eurprd04.prod.outlook.com (2603:10a6:20b:3e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:46:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:46:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9056640f-b787-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+z4NgV4rEY2ElrhhvtyQfajKANFOkYQ3/QQ1pU7+zsMEdVXk/oc8VkO1C79/uP8ps43/EHh8kxehb8Zzbd2DLU//7ELwH6gx8wSf2Pq0Yqc/2ZIQtO6+zZ4oikACFdpyQmFgDV0r5R+4b5aK0ONJbdWuNf0N6Zj5054aw7w5FeW3QnJg4WCjzilUOXrYw5U4xPFNnQigoPE+hrUHGVSu7bT73rwhaIy7v0ThJc3Mctlwzk3R0rkQDm+CjnAurJvnVfbOHFQfj+dGpmi0BzhYhbqjQtvfPrbBb+Y2Mjr3w9m0tD2rFvRHEo4jbzxjcKEtVIZ5manYn+AeOLipXpU6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TzpvViBomllkuPX4Trt/Kd+pJisKBei7ccIpP0lPBsk=; b=AafQX8F6iJS25X9BENA2DAath+00PfG2rUcqtHyIRtwyYeGAIGo82SCdUNaMSHqFu1z2LLG4IZmGesk2i6P2QiEaHWpe+1/PdSlM8sCm7KdMl6OejhR3dJFF0Icsp2QgWNVI8cIiiaUMq1VtgzBIShXh7F1/xwVXPNtbqIjl9OjVllFtEhp2Gb0wRybMrsaPBzduVaNxaUeVH0Z2p5FvbOVumK/aeQL68isvoACArmeLlHL3ChgkjQbHRiEdXVVMJOsAmuG5g21xtk35m3f6JClQjQF3GKAokgD5YnGj3R0qMegmuI6cxVsNMb3RaFyhbxBCKBEjSpFCsw3MprvT2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TzpvViBomllkuPX4Trt/Kd+pJisKBei7ccIpP0lPBsk=; b=pW/jEDljMaPPZzz4limLOTsr0y8nnx32vCQox99PT7ZFLJMDXmh4Tfclj2FFvF7P1kkAnfRcChDMfzEtZKihtF7JiKbGheAkWa5RVI8l+crqxVTtjF090VkCKVKHkW8IcjwYdu3cZjMo86XyA9doVCsuWDYwsYE8lMXFY+piyPkLkR6zJNtVFjmreUv2bOHzFs4wK+bvyx5Yt1TOtCSqUCSL7W6vd91iYZbj2hvfE0WWEPhWb3TOXJAHrvLofQLiH7z3KvkBwxVOZoZ21pzv5uXPfI0zADlQcqWuCfcGNeRtjHuhUWIEw5ETOMfaZyhzhIUOXatSiUIMEJ1RkDEUfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 17:46:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 07/10] xen: pci: add per-device locking Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-8-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-8-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8241:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e2c66ba-440d-411e-46b4-08db19ab636b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GGEfTgg45Zu1VADv5FFN4NQd/SG5bopaUqE5Pksfa1uLb1O1dZtMMHtPER4yzkxWrD4W1aJAGE2yPFe8OpumKpcp7D+Pt1xyNHWF4toIl5/6zhGY8/Qt4iT132Gyir2YUP7pLzhDTesGkKClFtVoswzDByZH/TwvPL694lTD5CU/61u7KDZPGw4txXwYauU863RG5G6FZQRxs4iK+WAnjIHltzV2fpN1ZpM6aDT98VPnH/oO8aQbqAbl8ue2C6wonH2jJpOS5SSmEHhw8J1Kz1ADqAZkmqh55tpPMoggLyuoI+7cM+iZh36XMRE/iHKqqZEALcxH+X00xNOxNOJKjiyu+vIkyOu2j6t6RU3wx8APDEr+T2i//2y+muUVBlsRBAAoPVCKUpeAOz/REksG1ePf4y7CvC+QTjeKvGqiErFR5XRAC1Ta9J83kqPMTFvfqrfl5wq7bYlSMo9RMvI1kNpozUt4bfOafcuaMAWJpE4qAYN4cbn/NM2OhOUpfS2IrmFDRPlbVIe0YnxStSkCP+aJBH5tFXUQRlwo+1+RcV5dHR7/c3YnEmROaIuoYEceiJsRqHP/8pGCImCg2juJw/TjEonbAIWJriuo7v5hAJaBaIUXNh9LsCkMZ3pHCAUDv6Xv9vQkzY/G9mbDI+hiN8GTfN2m5r8V2oHjKWAwqHfNlMB0I0gPHqdWNgjtv+TrwkWFwag91lzyWRPQORKq7abZOpEJnYT4jpdZVxrRUJ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(376002)(39860400002)(136003)(346002)(451199018)(8936002)(7416002)(5660300002)(31686004)(2906002)(41300700001)(6916009)(4326008)(2616005)(66476007)(66556008)(66946007)(8676002)(36756003)(31696002)(316002)(86362001)(54906003)(6486002)(26005)(186003)(478600001)(6512007)(6506007)(53546011)(83380400001)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmJSS3liTTUxaG5GZTVLWlNrQzZFQ0Jsc1N6YVg1VGY2QXVhUXpxN3VaZzA3?= =?utf-8?B?UmpMeDJkNkVKczBXVlZaa0J0M0ttUmtQUy9mdmhoNkkzVGRzWVJkQUJJc1Jz?= =?utf-8?B?UHg4ZXhOamgvWElyZTg2NzFOSWxJNURlemEvS1BKanYwVFRNK3pGZnhYN3lG?= =?utf-8?B?YnFhUFRHRHZGY05KRUp4VGRwQ2NlQWY1MWdPZUpCTCtUdExDcHJXbW8wWmV4?= =?utf-8?B?OVVzVUhLeHhBVTkzY2pac01NUWQ0RzdzUGxINDlNVmZsOE1jRnN5VE1ZdXE4?= =?utf-8?B?bFVLOVp1VzM5ZDFMb0g0RDVJSkl1VHRYMlFxa1JBOTB0Njhjcmlqbk93YTl6?= =?utf-8?B?Y2ZVRHRpQ1V2YWJyQVMxa2hlTXp4NE5BQ1NSR09STitOZGxXenROVmJCWFVV?= =?utf-8?B?cVZ2QUs5VE5RTDArUWUwU3l6NXc4OUxuc2Nxc2tPdWJTQTMvVm9KSklYaDFu?= =?utf-8?B?bzNyMGRaZ05pNTNIOEg4VG5iTFk1ZzE2R0N1VTFRL0xLeHR2K3U5NElZTWVw?= =?utf-8?B?YzhiRC9UZnV2OEJqYU0xRGhzcHhDSjBqV01uTjVjTW1vWHhXd2hLY3FpYjhv?= =?utf-8?B?QUs2MXJmNjMvdC9Ob2x1ZEhhZ2t5bTcxYnFMWUplMjJiek1vL3ptNkt3d3JH?= =?utf-8?B?SHBQSHlENExocUZqMGlLS1ZKaHBTVUx0UkxFdnhjdjJWWGE2cHdxckRtRGp2?= =?utf-8?B?U2dBTkplM1pwRTdralhLOU9tSVlpTXVFd0VyeEUyTW9pUU9FM1hGUzJ5L1kx?= =?utf-8?B?KzJtZURvaURtZ3lKVS9RRU9LOWc4VXFKYnJNbFQ1ZkZubmRZSTJjSmNIcVJa?= =?utf-8?B?em0wZHBtdXQ3SlUzSG5DamNKaDF2eTVKQngrS0I5bWU5T2FYMkNpTDg4ZlpD?= =?utf-8?B?a1R4OGdNVFA0NHBnanJWd0NWbkhidjVNMCtmWllEUm9GWTc5S0ErSHlYR3J0?= =?utf-8?B?dTFFcUNwa0ZGRVh1dzlJZ3pDaFZValh2YmdYY3FURXhrajBQTlZKZFcvSXdt?= =?utf-8?B?TVBid1A4dzVMejBFQ2s0T29yS2pYSktJd2I0b3h6ZkJqalRyLzZFN25jUGE0?= =?utf-8?B?cXFYVXBOWWJTb1Z3WVdjM0pRY1BLZmpHTXg0TnJpUVNWbUloZkJsZzNGZWZD?= =?utf-8?B?MFVKNDltRWViQmw2QVR5ZWFST0FJQUNTZStGeFZqR0NRV0xCb1BycklpSjRN?= =?utf-8?B?VW5DcS8rMzJIWlVCY09UN1FKMjh6enhUVTk0VEplTk9JUHQ4YmliRWM2VGdR?= =?utf-8?B?YTRpWlFka0VZL3pwZm16WjNHeFhDYXRqR3RncGx6SStoQ25zZnRVQ3RPcE92?= =?utf-8?B?a1pSaVFFM1hFZ2d2R2NteWtoSGxRQWprVkhBTXI2cmtlYVJodE0vMTlXTFB5?= =?utf-8?B?N2gybnZsK2x2TzRPZGwyODczdDRKZWlTTGhYUlB0blhwQWw3czRsOFl1NlBK?= =?utf-8?B?NG1XdEl6c0VxbGRvN1lxL3hYTks5blZqRmFZU2psYURVSWdBOG9SRjE0bDNO?= =?utf-8?B?RU1NbFJkRENqN1VEWGxMMzljWDUxd3BDK2lBU1hqdys3T2xMb3BWczFhOHNs?= =?utf-8?B?QmhzcmltMXIwSkhLbVZmYStHL2VNWWd4djBIcUlBYnVYcFBUQ2o4azVob1dQ?= =?utf-8?B?YkMvakNORjdzbEhaeStmRE1jWHk4ZzFnSFU0ZExieDZPUTh5Uk9xZS9RV3cw?= =?utf-8?B?YUdmcDBmSlFLNDMzdE1zMHFiNlgwNnpaSmpjMWhQT3NkMmVjemU3NDRiWmxr?= =?utf-8?B?YmFXM0trWXVaYS84bXl6NGI1cVBqVjJYK1V1eVR4bi9XamY5ZnJrUnZwVGky?= =?utf-8?B?Z2w4eVdmU2cvK3BVU0V5d2x3ZEVsQnJYK04rSzlab2ppQlN2V2orYTRnV2lF?= =?utf-8?B?SG9ZdEd4QXJqaGZwdjZMOVhHY2pvTHM1bnJQbXl5b1JuUXY2OVcvWEVBcFpu?= =?utf-8?B?VHVNWS9DWWNlTkl0ZEd5OEJmTk5lUFVmTFBqYW9PaWFZaVA3a2R6NkRNUmpJ?= =?utf-8?B?dmR3VG53UXkvTllsVkZkSjlRdUpUNksxZUJYbytuVUhCWVBPcVNBd2I4L2h3?= =?utf-8?B?VkJCNlErRGNCNktmR2FDRUtidFQ4MzVIZFZJQi9GRHZBVGJZdmhQYVFtVmI2?= =?utf-8?Q?CEnpny+aE9wbUUAECoHLzBlFG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e2c66ba-440d-411e-46b4-08db19ab636b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:46:50.3165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hH0Lox+EGHQ+1stUa4qgdlfI98cDs8pLhn7PJ9+VNZe5vftKVhbNwOjYlrxz3BFisoXdMkiUshhgKpqow30cmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8241 On 31.08.2022 16:11, Volodymyr Babchuk wrote: > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -203,10 +203,14 @@ static struct msi_desc *msixtbl_addr_to_desc( > > nr_entry = (addr - entry->gtable) / PCI_MSIX_ENTRY_SIZE; > > + pcidev_lock(entry->pdev); > list_for_each_entry( desc, &entry->pdev->msi_list, list ) > if ( desc->msi_attrib.type == PCI_CAP_ID_MSIX && > - desc->msi_attrib.entry_nr == nr_entry ) > + desc->msi_attrib.entry_nr == nr_entry ) { > + pcidev_unlock(entry->pdev); > return desc; This is a potentially problematic pattern: desc has a backlink to pdev, just like "entry" has. _If_ locking is required here (and the refcounting is insufficient), then it is questionable whether the lock can actually be dropped before returning. The idea with refcounting was, though, that entities holding a reference can be sure the pdev won't go away. But of course there's also the question what "access to device itself" (as stated in the description) does (or does not) constitute. I think it is pretty crucial that for every new lock it is spelled out clearly what it protects. Seeing the list iteration pattern here (and at least once below) another question is whether a lock like the one here may want to be a read/write one. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:49:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:49:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503581.775868 (Exim 4.92) (envelope-from ) id 1pX3Am-0004pG-TR; Tue, 28 Feb 2023 16:49:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503581.775868; Tue, 28 Feb 2023 16:49:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3Am-0004p9-Q7; Tue, 28 Feb 2023 16:49:52 +0000 Received: by outflank-mailman (input) for mailman id 503581; Tue, 28 Feb 2023 16:49:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3Al-0004p1-PV for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:49:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2082.outbound.protection.outlook.com [40.107.7.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea8c6e78-b787-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 17:49:50 +0100 (CET) Received: from AS9PR06CA0178.eurprd06.prod.outlook.com (2603:10a6:20b:45c::10) by AS8PR08MB6182.eurprd08.prod.outlook.com (2603:10a6:20b:291::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:49:20 +0000 Received: from AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::ac) by AS9PR06CA0178.outlook.office365.com (2603:10a6:20b:45c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 16:49:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT005.mail.protection.outlook.com (100.127.140.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Tue, 28 Feb 2023 16:49:19 +0000 Received: ("Tessian outbound 0df938784972:v135"); Tue, 28 Feb 2023 16:49:19 +0000 Received: from 5fb067a7ef68.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6319A176-F549-4FE4-A27D-799A6F26BEB1.1; Tue, 28 Feb 2023 16:49:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5fb067a7ef68.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Feb 2023 16:49:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS1PR08MB7588.eurprd08.prod.outlook.com (2603:10a6:20b:474::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 16:48:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::fca8:db36:98b:b1c4%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:48:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea8c6e78-b787-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/NC5urKF4GTsjw31+ZGs/Y9+76iPzb6eBC0Bz3PnOM=; b=EU8q/nnX0lHQQ4j0cdbirkp8LOm8XExRt76ILC/yZXEy1dvbnVlNlDCVUhb1n3RQNlPWR+HOFcQRhD2Z4BWpcc90J2WF89bAjK05ZYQLKQfWNCq8BjxZNjPOl3Khi0+fKRIE7kQ+4D7EVq/dDIt3j3nm0VHtXK87SVoE99ZkT6A= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 81fba1af3e5acb44 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSiV17bQgwZzil3nRq5hmRfWaUyLPXWru0bxfRKj1DOfig2uEeCw8TAdNKaeBIk8+0BsikB6+kzopzuietP1BL7HvwfhvIFlvP1YmEB7Yr8nHxyGz+w4uSFvF7gDbGrzxFOKrTayC4XjBxndw8Aq2HR3N6ubDQnI2+9Fa80eAHgwSCKPM5VokPAUZGaGh4byyt3jbpg9HFhcIGLQFdnxkjQol6qZc1ZdCQzI8BKN5m88CkB5eX8MSBft37084Ly4Ez82D3VSoa6M7HvKP4OOXh39xGBnfcyc3rvKlmgjzRU7oLS3fNGr1dMrh5E4qWkH+9Wk8igvzjm8b2q/ytYlKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/NC5urKF4GTsjw31+ZGs/Y9+76iPzb6eBC0Bz3PnOM=; b=ZMPzA5eEEP5SEtgyspV5x2ODTeezWTAm6Cn44yDnwCGk2tt7q+xWl9MHB7jeBukfyyw2GFlPP9hCQtNsfjzN+T7ZdAyaCndhKlIOKsgdn2c8U0b4IR4e5Un2U/iB4XI+PUPBeDuUgYI9luxDs0HJiRUxiQjbEBlcNSsx5lNUzeZ31z6Z1AKlBzXYpTXbeYDx9bEkg0qJ92MT/qs3Kw4EPgA7kYlf+kPYYz2RL57+fShJb4S2HXYPncT6VuOOtbnsGbXFjNVpj0R9cE3nAT/djmELZ5V+F7EIrWF7AYP3mw2DOyb7gqasIb5bk/ipHZQ5n9v8SM+xvUOfceT0BtHlrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/NC5urKF4GTsjw31+ZGs/Y9+76iPzb6eBC0Bz3PnOM=; b=EU8q/nnX0lHQQ4j0cdbirkp8LOm8XExRt76ILC/yZXEy1dvbnVlNlDCVUhb1n3RQNlPWR+HOFcQRhD2Z4BWpcc90J2WF89bAjK05ZYQLKQfWNCq8BjxZNjPOl3Khi0+fKRIE7kQ+4D7EVq/dDIt3j3nm0VHtXK87SVoE99ZkT6A= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Marc Bonnici , Achin Gupta , Volodymyr Babchuk , Stefano Stabellini , Julien Grall Subject: Re: [XEN PATCH v7 12/20] xen/arm: ffa: send guest events to Secure Partitions Thread-Topic: [XEN PATCH v7 12/20] xen/arm: ffa: send guest events to Secure Partitions Thread-Index: AQHZRtMbJTLQExtpBE6ThIQepjPcla7km2EA Date: Tue, 28 Feb 2023 16:48:52 +0000 Message-ID: <3DE2B127-8820-400A-86FC-3A38F40CADFD@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.400.51.1.1) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3784:EE_|AS1PR08MB7588:EE_|AM7EUR03FT005:EE_|AS8PR08MB6182:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dd045d3-74a4-4415-1b48-08db19abbc86 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lhnESxdzxHd/STIV+VF1H9qflEwE49eQSp1IpFkBzf057bwQlDMtE3Vf32pXHDgQ84zVWJ7JJ8p6N8ThUugCoL/5ntFvQH4T5pDPZ7PYEo0Qm83sjxnoU/hum406+8zVEE0cMsPWOVKDd3OPlYodjxv0adJP9cLYDpb0KvmlwTBz79EQ7jk56Zv1ug0cYhKoq/FYUxhlAjA0Z1phzuhdz1sFh/MaN1KM0D30CWVIUX6VRa/HEFTWm3ZQVXI6AI44sQ3IVyUKgwZ8XJtSFwXGaM95XQOXEz7G1SkHWR7sRdYdhZSDiN0E0HMd+waDrTOPQKtk+Ip1g+RqkdnOrQhWcyqJqQlOI+7fyCLLu5k2u0Ade+sQ31Ve8HPrn0YRR/5jK+Q+RXsYQaQe9AZvBE9KkCAv4Iqy50n5gM4rcXXNwJmY5txudcvcMJLFz5TBdUQi+d9vhdyyVYUaG25MWDR9d/fDj3dllbeTEb/Xcs41/YPcXCf9mERZMjobIHSnFLLmXbw+dZ4ZMJil7nEOMAHmz+7DBc2In3mTo+IwgjMQRPIGA6xPHs+Irfxh+h+nDAyWFwA246WM6mv+W7W5FgyBz0+Djs297sipVP+kfR0144slHswAhl55brairLmIMSkI8O0NB+QEsC6V3GjWQfl30UcM0tronNnSM1AU6GBFE4TeZfCeFxpzNJBvmVyBF2gquHjcCkJ6h72Ko66UWyXP+tt4h3uqBVIxVSAq5dsQODg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(451199018)(8936002)(36756003)(5660300002)(2906002)(41300700001)(6916009)(4326008)(2616005)(66556008)(76116006)(66446008)(66476007)(64756008)(8676002)(66946007)(86362001)(54906003)(316002)(91956017)(33656002)(6486002)(478600001)(6506007)(186003)(26005)(71200400001)(6666004)(6512007)(53546011)(38070700005)(83380400001)(38100700002)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <43D7C54B24131546B6316473AFF84135@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7588 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: df473e13-8595-42d6-8b68-08db19abac90 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5AfBAOEPKqHDVHXBbm1a5s9nqCWk/KD/JwJK92L09UcRj1mxJ7G0rO6y8YTZEa5NfWCQe065ySiUDwhDC6ESO0d19IGjgwI1d6u4fMkOcEqDwYcP0tljAL6A5Gkhdo+I6Dko8nOuNw6rMi+jjHcUYcWF904J/1wrtjZz9lwBtQVdswFsiJO4rDEOWDiBDpAZ8CJIjSevBYANmDwy1mWMCj4VAippdzmYv67p26ii6XxsMtz2wBR5dqVp35arYMqaaAKJlsOpm78R+SaEcw3jAryTFTAERDaRJhJUjkyPtQCXG9n4PpB6ak0QU5jmC2G4x2uAnbdDG1kEX3+D1/W04qaOwd8MKqAppfo4VZy75ASO6JMkqhj1mymTcNNvppiHac3+lnCnfPv1Gu91e1ofE11zrR4N3HF25Bvxhamo4v7GuXLMLO0ZGXUQj35qSKuGaBKdIANkFeWoGd1kEMa6EZFXTBsziWkp6SIVM+z6KKTAM/eBAjmaS+ZHxPS2d87wMdjNvlunhoZVigQA8t98pysPGou/WiSnQuWgk/j2SKRRy1PXIu9BbtdvUs4gqXxqaXuDhiUxSes+8AUVVnZ98eOP2sc/muzQR3zvCaKHVImLvlkzThDvt5KwO5w7WGpse1FPohtZMm006Dd+lRxXwyXeU3MptG1AjVKT8m8gyytGEHvi3rPFvdQ4h/4FNPb93LYrYa1qX6A+4AhiiHygBw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(46966006)(40470700004)(36840700001)(6512007)(186003)(26005)(53546011)(6506007)(336012)(2616005)(47076005)(2906002)(478600001)(82310400005)(83380400001)(54906003)(6666004)(36860700001)(316002)(82740400003)(81166007)(4326008)(70206006)(70586007)(36756003)(8676002)(356005)(41300700001)(40480700001)(40460700003)(86362001)(8936002)(6862004)(6486002)(5660300002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:49:19.5283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd045d3-74a4-4415-1b48-08db19abbc86 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6182 Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrot= e: >=20 > The FF-A specification defines framework messages sent as direct > requests when certain events occurs. For instance when a VM (guest) is > created or destroyed. Only SPs which have subscribed to these events > will receive them. An SP can subscribe to these messages in its > partition properties. >=20 > Adds a check that the SP supports the needed FF-A features > FFA_PARTITION_INFO_GET and FFA_RX_RELEASE. >=20 > The partition properties of each SP is retrieved with > FFA_PARTITION_INFO_GET which returns the information in our RX buffer. > Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the > caller (us), so once we're done with the buffer it must be released > using FFA_RX_RELEASE before another call can be made. >=20 > Signed-off-by: Jens Wiklander > --- > xen/arch/arm/tee/ffa.c | 191 ++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 190 insertions(+), 1 deletion(-) >=20 > diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c > index 07dd5c36d54b..f1b014b6c7f4 100644 > --- a/xen/arch/arm/tee/ffa.c > +++ b/xen/arch/arm/tee/ffa.c > @@ -140,6 +140,14 @@ > #define FFA_MSG_SEND 0x8400006EU > #define FFA_MSG_POLL 0x8400006AU >=20 > +/* Partition information descriptor */ > +struct ffa_partition_info_1_1 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > + uint8_t uuid[16]; > +}; > + > struct ffa_ctx { > uint32_t guest_vers; > bool interrupted; > @@ -148,6 +156,12 @@ struct ffa_ctx { > /* Negotiated FF-A version to use with the SPMC */ > static uint32_t ffa_version __ro_after_init; >=20 > +/* SPs subscribing to VM_CREATE and VM_DESTROYED events */ > +static uint16_t *subscr_vm_created __read_mostly; > +static unsigned int subscr_vm_created_count __read_mostly; In the spec the number is returned in w2 so you should utse uint32_t here. > +static uint16_t *subscr_vm_destroyed __read_mostly; > +static unsigned int subscr_vm_destroyed_count __read_mostly; Same here > + > /* > * Our rx/tx buffers shared with the SPMC. > * > @@ -237,6 +251,72 @@ static int32_t ffa_rxtx_map(register_t tx_addr, regi= ster_t rx_addr, > return ffa_simple_call(fid, tx_addr, rx_addr, page_count, 0); > } >=20 > +static int32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t= w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_PARTITION_INFO_GET, > + .a1 =3D w1, > + .a2 =3D w2, > + .a3 =3D w3, > + .a4 =3D w4, > + .a5 =3D w5, > + }; > + struct arm_smccc_1_2_regs resp; > + uint32_t ret; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + ret =3D get_ffa_ret_code(&resp); > + if ( !ret ) > + *count =3D resp.a2; > + > + return ret; > +} > + > +static int32_t ffa_rx_release(void) > +{ > + return ffa_simple_call(FFA_RX_RELEASE, 0, 0, 0, 0); > +} > + > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > + uint8_t msg) This function is actually only useable to send framework created/destroyed messages so the function name should be adapted to be less generic. ffa_send_vm_events ? unless you want to modify it later to send more framework messages ? > +{ > + uint32_t exp_resp =3D FFA_MSG_FLAG_FRAMEWORK; > + int32_t res; > + > + if ( msg =3D=3D FFA_MSG_SEND_VM_CREATED ) > + exp_resp |=3D FFA_MSG_RESP_VM_CREATED; > + else if ( msg =3D=3D FFA_MSG_SEND_VM_DESTROYED ) > + exp_resp |=3D FFA_MSG_RESP_VM_DESTROYED; > + else > + return FFA_RET_INVALID_PARAMETERS; > + > + do { > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MSG_SEND_DIRECT_REQ_32, > + .a1 =3D sp_id, > + .a2 =3D FFA_MSG_FLAG_FRAMEWORK | msg, > + .a5 =3D vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 !=3D FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 !=3D ex= p_resp ) > + { > + /* > + * This is an invalid response, likely due to some error in = the > + * implementation of the ABI. > + */ > + return FFA_RET_INVALID_PARAMETERS; > + } > + res =3D resp.a3; > + } while ( res =3D=3D FFA_RET_INTERRUPTED || res =3D=3D FFA_RET_RETRY= ); We might end up in an infinite loop here or increase interrupt response tim= e. In the general case we could return that code directly to the VM but here w= e are in the VM creation/destroy path so we cannot do that. Maybe in debug mode at least we should have a retry counter here for now with a print ? > + > + return res; > +} > + > static uint16_t get_vm_id(const struct domain *d) > { > /* +1 since 0 is reserved for the hypervisor in FF-A */ > @@ -371,6 +451,10 @@ static bool ffa_handle_call(struct cpu_user_regs *re= gs) > static int ffa_domain_init(struct domain *d) > { > struct ffa_ctx *ctx; > + unsigned int n; > + unsigned int m; > + unsigned int c_pos; > + int32_t res; >=20 > /* > * We can't use that last possible domain ID or get_vm_id() would ca= use > @@ -383,24 +467,121 @@ static int ffa_domain_init(struct domain *d) > if ( !ctx ) > return -ENOMEM; >=20 > + for ( n =3D 0; n < subscr_vm_created_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subscr_vm_created[n], get_vm_id(d= ), > + FFA_MSG_SEND_VM_CREATED); > + if ( res ) > + { > + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %= u to %u: res %d\n", > + get_vm_id(d), subscr_vm_created[n], res); in this function, get_vm_id(d) will not change so i would suggest to store = it in a local variable instead of calling get_vm_id each time. > + c_pos =3D n; > + goto err; > + } > + } > + > d->arch.tee =3D ctx; >=20 > return 0; > + > +err: > + /* Undo any already sent vm created messaged */ > + for ( n =3D 0; n < c_pos; n++ ) > + for ( m =3D 0; m < subscr_vm_destroyed_count; m++ ) > + if ( subscr_vm_destroyed[m] =3D=3D subscr_vm_created[n] ) > + ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id= (d), > + FFA_MSG_SEND_VM_DESTROYED); > + > + return -ENOMEM; The VM creation is not failing due to missing memory here. We need to find a better error code. Maybe ENOTCONN ? I am open to ideas here :-) > } >=20 > /* This function is supposed to undo what ffa_domain_init() has done */ > static int ffa_relinquish_resources(struct domain *d) > { > struct ffa_ctx *ctx =3D d->arch.tee; > + unsigned int n; > + int32_t res; >=20 > if ( !ctx ) > return 0; >=20 > + for ( n =3D 0; n < subscr_vm_destroyed_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subscr_vm_destroyed[n], get_vm_id= (d), > + FFA_MSG_SEND_VM_DESTROYED); > + > + if ( res ) > + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_i= d %u to %u: res %d\n", > + get_vm_id(d), subscr_vm_destroyed[n], res); > + } > + > XFREE(d->arch.tee); >=20 > return 0; > } >=20 > +static bool init_subscribers(void) > +{ > + struct ffa_partition_info_1_1 *fpi; > + bool ret =3D false; > + uint32_t count; > + int e; > + uint32_t n; > + uint32_t c_pos; > + uint32_t d_pos; > + > + if ( ffa_version < FFA_VERSION_1_1 ) > + return true; Correct me if i am wrong but on 1.0 version we cannot retrieve the count bu= t we could do the slow path and do a first loop on info_get until we get an e= rror ? > + > + e =3D ffa_partition_info_get(0, 0, 0, 0, 0, &count); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", e); > + goto out; > + } > + > + fpi =3D ffa_rx; > + subscr_vm_created_count =3D 0; > + subscr_vm_destroyed_count =3D 0; > + for ( n =3D 0; n < count; n++ ) > + { > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) > + subscr_vm_created_count++; > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) > + subscr_vm_destroyed_count++; > + } > + > + if ( subscr_vm_created_count ) > + subscr_vm_created =3D xzalloc_array(uint16_t, subscr_vm_created_= count); > + if ( subscr_vm_destroyed_count ) > + subscr_vm_destroyed =3D xzalloc_array(uint16_t, > + subscr_vm_destroyed_count); > + if ( (subscr_vm_created_count && !subscr_vm_created) || > + (subscr_vm_destroyed_count && !subscr_vm_destroyed) ) > + { > + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"= ); > + subscr_vm_created_count =3D 0; > + subscr_vm_destroyed_count =3D 0; > + XFREE(subscr_vm_created); > + XFREE(subscr_vm_destroyed); > + goto out; > + } > + > + for ( c_pos =3D 0, d_pos =3D 0, n =3D 0; n < count; n++ ) > + { > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) > + subscr_vm_created[c_pos++] =3D fpi[n].id; > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED= ) > + subscr_vm_destroyed[d_pos++] =3D fpi[n].id; > + } > + > + ret =3D true; > +out: > + ffa_rx_release(); > + > + return ret; > +} > + > static bool ffa_probe(void) > { > uint32_t vers; > @@ -447,7 +628,8 @@ static bool ffa_probe(void) > printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > major_vers, minor_vers); >=20 > - if ( > + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || > + !check_mandatory_feature(FFA_RX_RELEASE) || > #ifdef CONFIG_ARM_64 > !check_mandatory_feature(FFA_RXTX_MAP_64) || > #endif > @@ -475,6 +657,9 @@ static bool ffa_probe(void) > ffa_page_count =3D 1; > ffa_version =3D vers; >=20 > + if ( !init_subscribers() ) > + goto err_free_ffa_tx; > + > return true; >=20 > err_free_ffa_tx: > @@ -485,6 +670,10 @@ err_free_ffa_rx: > ffa_rx =3D NULL; > ffa_page_count =3D 0; > ffa_version =3D 0; > + XFREE(subscr_vm_created); > + subscr_vm_created_count =3D 0; > + XFREE(subscr_vm_destroyed); > + subscr_vm_destroyed_count =3D 0; >=20 > return false; > } > --=20 > 2.34.1 >=20 Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:52:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:52:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503587.775878 (Exim 4.92) (envelope-from ) id 1pX3D4-0006GL-Ev; Tue, 28 Feb 2023 16:52:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503587.775878; Tue, 28 Feb 2023 16:52:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3D4-0006GE-BT; Tue, 28 Feb 2023 16:52:14 +0000 Received: by outflank-mailman (input) for mailman id 503587; Tue, 28 Feb 2023 16:52:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3D2-0006G4-JY for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:52:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2084.outbound.protection.outlook.com [40.107.13.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3df5e04a-b788-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:52:10 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9355.eurprd04.prod.outlook.com (2603:10a6:10:36b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29; Tue, 28 Feb 2023 16:51:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 16:51:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df5e04a-b788-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdPRvwU24jibs6DUdCd/BQDqksp+j81JHLd0AoqZBHPM0SYO43l1kYflEnYVq6hI3SlDBA9yqlEzpW/YVYJXIqadMsI0DoKxh3w5EfEXm+ZjAn48OeWYZTVnhD+8C3hy4W+8PB6revbbOejcbzyAuD4b7sCbLqegmgLhe9pWBuoyK3MU6TXi9j61s1NsmTn4RJDWByR0siiZTv3fFBrBnldTRdeMU/5a5G3bQciuzV5GdU6SWDntFppkEk97Cd1A5zPT1CS+N2cwjMGghmFIV4HcdYp0X9oEPYYAxZktrF78r7pJ04i5VeR5wRR1AIf3laPzdQrNgubd2iyeXQBRGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8hqyLEJTtVAvew4f/pEMLzCvmFRMKYBiv3Hc/GeL7Q=; b=ktAeCpdt/tSlLQWmP2d1JPPzJIvHp/qyz51Og4m26P6uaEv7E6ux3Lz9xa7OCwvQa/PK/H3PvO9QGkucJzvolG6U8qcsD8RfjLix7XcWdtLUHx02kEWFaOWUNz5i3FcU39O5L1JPUTCgmaI1J/EHCABXWADWHdtGfn196R48bzMomboBT9EeV+ThYYMLEPGBsqo/ueCiFXTNiHLBgyR4waMLnxpza83v/V6ovJElV8ZMrEBnH28nEYLhkyU228YG57I3x2fBCKKkTD6RAMzlUq2rZwpe87Q18n3KPHXx2Fft5B1aqHnQw6UCouWBB5/YYi8gOnJZRNIf5CKNAHfofQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8hqyLEJTtVAvew4f/pEMLzCvmFRMKYBiv3Hc/GeL7Q=; b=O94k7GESOvzYKKdYTl7jIIiD12LWxQcwaOcwp/KLxWHx47ZG1Pk7aPuF9x7ZvcWSQsRxC+gshWcagtsafwKiUfODtZ22W7E+OjxxlKV6guQrakMnFh92d8NIEJh92iO9XFWoNIXSxS0QDbj+478YjnnaKd/EqQ2Kok9GGSrk+fRY5phPv10LTzX+AFZ2IlPWUZ8SL2tWh/w0vtRYSxn+O20VU5ht8zO6aj4s+Mhg4EheyvmKvhB5olHQ+LaV7yAsF9awih2SBnj+B1WAN65NyRbO77hAoD6fpZTCGeD5DL0+p1pJrxSFChGgWsiyxi2m8Bkkq0dBtdgNAYevpxEpbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 28 Feb 2023 17:51:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 08/10] xen: pci: remove pcidev_[un]lock[ed] calls Content-Language: en-US To: Stefano Stabellini , Volodymyr Babchuk Cc: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Paul Durrant , Kevin Tian References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-9-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB9355:EE_ X-MS-Office365-Filtering-Correlation-Id: e54f18d0-201e-4d45-29f9-08db19ac0eb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eA5g9i/OaCGhrx+eT69gRo0GAfm9C+iMGCaykitF/iiMDM+xq6UjGROdD/0teo5Q3lNgDzUJPdl4WE/h7hluIaIhjXsWbKH0S2EWDBc+omeULee8w3bvVhduHuhUmf3csELOq0fTw93vUSNVpWL2htviqAi7CBoNMlzm6jlW1MiRvneysfscVXq/Yc/vWYm8QAEX+0pp2bt+a5ta2ir8QxMizNrAGoid4de6ZH1SANn+cBJsb7wn2beMtWjx5wxk/6PAUyVIs0faIHuTo+JBaKtsv7I6UMZ1NvzbLpiRPk355OqXbMf05PcKyxFlGXzfYdENPfLoBDros46GlM2eIcIvljOLMAA8s2ApFD7lT5tNPRuyXMWTO3GL4Zx0Mas7F4XZdfxl4Dm2pNMGXXFtFU0KVUAHql9TUr9WRMOq+buCtisuZVxGoYi3Helse6SiSgTtd2Dp1nVPsTVryBXwNq4qkZ+y8aek9VSHTbzE18Xddxnl3+XltOnGSr/Ovn2QfpCGB6WvDsvg2Zm1IA9r175jW9pfd7l8lGEZxDLudXve6P9ubHQOGbhqn+93/bBAjPgOz0Z4N2k/pr7Ht027FeUoknmASxaNAAR0VZ9PrOAscGEnlI1eMWOnS6gMEXbustwR2kHL530i7V7DzNKMV4B0rr5/mFCKX8y46R6KfGWaCSfyp+tNUJU002cjx0/VMjhRes6HQG+YrTbDRjxFb2OVLOuNvH/PzO8uRouHuVU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199018)(86362001)(31696002)(316002)(31686004)(110136005)(2616005)(36756003)(54906003)(6486002)(186003)(2906002)(7416002)(8676002)(5660300002)(4326008)(41300700001)(66476007)(66946007)(8936002)(6512007)(66556008)(478600001)(53546011)(6506007)(6666004)(26005)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXZ5MkJXY2hrTmw0YUR0cytUY3pINTl6MW40WXpHTnBhbDMzMTB1aDFlQVp5?= =?utf-8?B?d2xVV3orekREbWtHN3JJN25FZWVsc0NQSFlaV2puLzNpSlZJSm9neFZUS3JK?= =?utf-8?B?cDlySzllQll2dG5uTC9QQkEyZG15aThpcDkxTmljU1V2R3J0NmRyT1lRRURk?= =?utf-8?B?UTlvL2gwV2RYcG9XRmw3NEpSZ29aeSt3NGw1Vm5EU0xLbE5HU1lyeHIzZ2NU?= =?utf-8?B?NzY2ZWlkU1MrR0x0Y1k3SmxndjZxN3JTWE1nZmFtSTZ5SXN2ekJUVXhNMSs3?= =?utf-8?B?eGdrMlEvTVE2Y3B1Q1BxckQwZEoveVNTT3YvQXRCRmpVOTBJai9TOW9HTWE5?= =?utf-8?B?alB5dDVrY1pyQmhWc3hScDFVN0xLZ2JzS1hDS0JQenM5ZXN4K0hreUlUZ2lG?= =?utf-8?B?Ky9FN1lGUXN1Ukc5b3pXNXVQam5kd2h1TElPZ1hHWlFUM2ZzZ3dhakp3RHZr?= =?utf-8?B?a1BEdWdDR1dOTzBCbDdKV21VZXhTVkpCb0ViNWNyQlpNRWYzcGlZRnZYcEVO?= =?utf-8?B?TVpPQ1NuZlVEa2docWg4V1g3Z2drRTRsRjJaSTVqcHBNbFRNR0hPZXYzTytl?= =?utf-8?B?RnJ5dmM5V05CL2poVi9YWTdGZFpBSFkxbC9SMEhOcFg2UjJBQ3djZSt4TmZJ?= =?utf-8?B?bFprdVBRUXM2eVJFRnljL3RkZ2kxTm0yUTZWczB4TTAxM01vUnptQ2FRRUtN?= =?utf-8?B?MmtVSmQrM05mdWhiRTFURS8vMW1yY0F0MnV5Qk93dnZiRGo2Lzl1MDVWbUhD?= =?utf-8?B?OG0vQVpvMElrUkJTZTRLdTB5YVovazI4Z0Z6L1JUMEYxYWFUOU9Rd0FxSDhw?= =?utf-8?B?Nmh5dkthVVZpTVp3dXU2d1F4YnZGOWNRdE1HZ1Z1c2V2c29LaEhIdGtyVnRZ?= =?utf-8?B?WHA4dW0zNnJWempIa1VXQkw1cFZEMTZjMytDaE1pUmFZL05xMGZ6T2M3Vm9R?= =?utf-8?B?TDJBOXhkeTQyK0dkeitZRVBnL3ZpMXROYTg4Qk9oVEgvSFVPeEdHS1BpejhZ?= =?utf-8?B?QSt3aFVrcEZzVHppR25GT3E0bFdCbklhQng0SnJQSmdicVM3RWpZZHpjMHhL?= =?utf-8?B?UDhhWktXd0hqZ0ZqRm9TZlZvQmZiTlhLTnlxZnhDcjBiajZYRjV3L1ZtbXBC?= =?utf-8?B?Zlk3dExnQm1Oc1doSXBlZUFWOTdoOGMwalI3VnlCd2JORnhwQUZYMHRVZ3M5?= =?utf-8?B?YXAyMUdaTkVscWRaYWJHODNBNmJEK2RhQTFvaXBEWjJlbm16Ym01YTB5VXdT?= =?utf-8?B?M0Rqb2JJbHpqNkZXZ21NTDhJRHYyZ1ltbldxZTlqWXJsYXVxcFY2b0JiZlZG?= =?utf-8?B?VlhGRkFVcC94akZtQjhRRGV2SmhTNWVLTGRoV1ZCMDlIM1BncFpCYzNTeWRt?= =?utf-8?B?WXBiNW5JbnpUNURTTTVHWDZleS9nV2tBSGNaS3Q4VHgrSW1nM3BQNmJJdlR3?= =?utf-8?B?akVuUlFrd2R2VVdSV21QQmM0NHZRUkxlVjJ4UHZPekpJY3YxM3FTd2ZDRVJ1?= =?utf-8?B?SVgzWUM4SjJic1U3VFEvMzVjaFVvMXh4bVg0OE1LSGJTU21tRGdMNzRVbFZ4?= =?utf-8?B?QkpjbkVTbnpJM25QKzQ2NENCTi9JSlA3Q0hwWm95WlVBV3ZOZWIxNzJUWnoz?= =?utf-8?B?WVBnOEduZFFKeHBEL2VlMzZrYWFGMlZ4dmVubVhlMXpDbS9XRXo2Mi9ITVhI?= =?utf-8?B?Rmp0eXZDVjJVaWlVTHZBeXNROW1kSzdoalU3cndHOGs4ei95eXhDREVhMitE?= =?utf-8?B?UnZDNnlUZ01tRnhJTnZuY0NTNmdTTkFQL2psVC9FZVRuT3JBRlUvQXRVTmFB?= =?utf-8?B?aUpRRmVaN2RVdVMxT2lyczNUTGtiSkRocTgwcmtKRmY4aE9UUU53MjFqZk5p?= =?utf-8?B?YjZrQVo4Ynp0MWE1Sit3MkZSVjJZc1dWUlpyQ3ZkZUFPTjVPV2pkdlJScEwz?= =?utf-8?B?NzQxQkRHSFNyZU1TOTdxeHlMOGlSZzJRZW01QzQ5NmUvdVB4WW9JZzcydVdI?= =?utf-8?B?cWY3UG1lOFlZVEZMelF3UzZZaUhVWThTR0lTVFI4MFNlckZTdHJEZjRINEZt?= =?utf-8?B?V00vUVozZUNQdVNJYTdFZzRSZlNsdHhoUkdtbWphc0J0K0RCNzY5RVo1aEtU?= =?utf-8?Q?TLbF3w8ar+SFsKYmzH5GogzbP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e54f18d0-201e-4d45-29f9-08db19ac0eb0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 16:51:37.6427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xkj6ueMkXzDyiHVbxQzR6WbvXaIR96B8jUH3I1Z226WOXWM/WaWglYxecBp1g8BMs+sDtVMglW98uSRqwUC7mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9355 On 28.01.2023 02:32, Stefano Stabellini wrote: > On Wed, 31 Aug 2022, Volodymyr Babchuk wrote: >> As pci devices are refcounted now and all list that store them are >> protected by separate locks, we can safely drop global pcidevs_lock. >> >> Signed-off-by: Volodymyr Babchuk > > Up until this patch this patch series introduces: > - d->pdevs_lock to protect d->pdev_list > - pci_seg->alldevs_lock to protect pci_seg->alldevs_list > - iommu->ats_list_lock to protect iommu->ats_devices > - pdev refcounting to detect a pdev in-use and when to free it > - pdev->lock to protect pdev->msi_list > > They cover a lot of ground. Are they collectively covering everything > pcidevs_lock() was protecting? > > deassign_device is not protected by pcidevs_lock anymore. > deassign_device accesses a number of pdev fields, including quarantine, > phantom_stride and fault.count. > > deassign_device could run at the same time as assign_device who sets > quarantine and other fields. > > It looks like assign_device, deassign_device, and other functions > accessing/modifying pdev fields should be protected by pdev->lock. > > In fact, I think it would be safer to make sure every place that > currently has a pcidevs_lock() gets a pdev->lock (unless there is a > d->pdevs_lock, pci_seg->alldevs_lock, iommu->ats_list_lock, or another > lock) ? Yes, I agree - there shouldn't be cases where lock uses are removed with neither replacement nor an explanation why the removal is safe. Which in turn suggests that a change like the one here likely needs doing in much smaller chunks. Grouping could possibly be based upon all touched instances having the same replacement or justification. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 16:58:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 16:58:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503591.775888 (Exim 4.92) (envelope-from ) id 1pX3Io-0006vr-1q; Tue, 28 Feb 2023 16:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503591.775888; Tue, 28 Feb 2023 16:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3In-0006vk-VH; Tue, 28 Feb 2023 16:58:09 +0000 Received: by outflank-mailman (input) for mailman id 503591; Tue, 28 Feb 2023 16:58:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3Il-0006ve-T4 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 16:58:07 +0000 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [2607:f8b0:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 101acc27-b789-11ed-a550-8520e6686977; Tue, 28 Feb 2023 17:58:03 +0100 (CET) Received: by mail-pl1-x62b.google.com with SMTP id n6so9728877plf.5 for ; Tue, 28 Feb 2023 08:58:03 -0800 (PST) Received: from [192.168.6.128] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id v24-20020a1709028d9800b0019a8597788csm6869085plo.0.2023.02.28.08.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 08:58:01 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 101acc27-b789-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZtMSoJo2/ZyjwdRWCBbepotffSNm+nwxVFjLTh+Tx08=; b=RWN+ArmRSoF3RqaIc/bG5HKYN8GqQFbTlJqpD8J7s/9B6QN61aZgGGWKFMc6a2g79w KJqn9iLRtx+zn11WIASPZu5yBM5TdDjbaGjTnL1SFAIEOHskGnjEjZeXpqPpy9V6n5p2 r7+V8NqjySksekWlWPSSL7e6ScTvYON2coS2z4TIxMT/XzGJFNARBJobI3wyA54tVTJy 4+NykP3xVNVLQ+bDSVh3IUKsGnLoIgjlbOtIeADpDK6klqd94TPH5PVodAtoJKkYqURo xk1ltaWPWxaGr1uf1su5Zt5E/T+lOxcnPBFwf8rxZx0hHx+VXAOHZ8qcAB7CIbnNZX91 1vSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZtMSoJo2/ZyjwdRWCBbepotffSNm+nwxVFjLTh+Tx08=; b=hC/AqIfp6BgGzD3BPnNdVYUgZjvvbJrWPP+OllkiMpYwN4F+bqQxaKpSPB4I8QcawE S3A2q7HQXcPY0qoIr3BnXX+LPSJ/QjBt+xLrPYgZESX/LncOA4+gC1vamMBN7IpIe2mD PuWtmgO0dUHwqqawl0lRFZObZMKrWprTjFEoqij+FALjRnnG3lml6SlD8xRYDR2uEpxx afeP6zaynWs4LRp/fkYvStqh+pXqy0QPp62EWRn+pNeFUJaru4mD1l4cTxrPTbtd4Z7G lzfLYF9WJLvjUod7pJH0/cm6Wdbl9+woaYuENgjS4OyMJ0gN2OtX2GPCnPHTjCOr1nkZ 4TVA== X-Gm-Message-State: AO0yUKWfVK3gZAOQFjxzWMcVIdxGH8p2QHB51cbWBCqlWqntaq5TAmRE b3f0M35jbUxy6/zE1hoX2HdJfg== X-Google-Smtp-Source: AK7set90WOEr4dwJPaDBIlNSyAUO8ngoVSxZiL6FRqc82zyAHJhoPcIuRFbTPM4j0T9hhlTBR6YUKg== X-Received: by 2002:a17:902:b08a:b0:19d:c9f:44f0 with SMTP id p10-20020a170902b08a00b0019d0c9f44f0mr2708127plr.32.1677603482070; Tue, 28 Feb 2023 08:58:02 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 06:57:56 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 Content-Language: en-US To: "Michael S. Tsirkin" Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <20230227111050.54083-2-thuth@redhat.com> <20230227150858-mutt-send-email-mst@kernel.org> <20230228035958-mutt-send-email-mst@kernel.org> From: Richard Henderson In-Reply-To: <20230228035958-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/23 23:00, Michael S. Tsirkin wrote: > On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: >>> Removing support for building on 32 bit systems seems like a pity - it's >>> one of a small number of ways to run 64 bit binaries on 32 bit systems, >>> and the maintainance overhead is quite small. >> >> It's not that small. > > Meaning there are lots of ways to run 64 bit binaries on 32 bit systems? No, meaning the maint overhead is large. r~ From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:06:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503596.775898 (Exim 4.92) (envelope-from ) id 1pX3R5-0000Lb-S5; Tue, 28 Feb 2023 17:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503596.775898; Tue, 28 Feb 2023 17:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3R5-0000LU-PH; Tue, 28 Feb 2023 17:06:43 +0000 Received: by outflank-mailman (input) for mailman id 503596; Tue, 28 Feb 2023 17:06:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3R4-0000LO-Ig for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:06:42 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20614.outbound.protection.outlook.com [2a01:111:f400:fe13::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 442a66b5-b78a-11ed-a550-8520e6686977; Tue, 28 Feb 2023 18:06:40 +0100 (CET) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7922.eurprd04.prod.outlook.com (2603:10a6:20b:249::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 17:06:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 17:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 442a66b5-b78a-11ed-a550-8520e6686977 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DmjeQHyZ5HqYzSGGgg5qnUJ0tlM/EnPOBhCjDFg25H0HxXlJ+vo/29GEl4vCWvl8uUv6LeLuGtENlgvtABwkICZk17N4vsGvpnnQH8avAde7MV0WU/6jd1LjUbwfovrvlhPQaM3ynBGXwxKOB4ewQnUo0qNLdoYTa84JBNt6aR66MreJ94xVILHx9RFmYNmWCjf8SgE2pjL09RcSunlGn1Q7PyC/Bs3LE31pSShZmFIoy1cBFrJc29/N4gTbfevBMSzpKpPrhsyygAurgI+Ws1agu7fN5eTWf/5QRc12WiSHBaHf6euBP1hkTYZA3CV0onyK4SOdFoU6lBO6S4zPNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AUwJSy2E/tJ9qFnJ2LTSzt8ak4265XZlhUlUeQR8tjE=; b=D1gDFYpiEAvraLfNGt3rM9Okf/mLyk+AE1KiT4bdxorAFvL+FahDnzo9fL7xD+dr2pIBp+DOw9CoSIXBoXXEG5eKCKWV0CuptDfijUf+bgyJ1sPTcqlmHw2X5jVt0X1FTuT2nf5XsFhzt7xQ+UkpARGsA2XUFlP29/8lzevzEEWYRsZ9vKTnSOyBM8oMies6aMY8pc4FBe3G5LJM9JkrliuGEi470KEn/VRKpyTXd7eBfMeSKMY4LSRmJyIJxMaOSN4c0pmMN/Dup1j4Fz9d18lUxMAJWWQC9AbX3fkmyi9BqAFZUNc36exbOHHbFhlXd0q3wGk4LBxOdIkuKd6UXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AUwJSy2E/tJ9qFnJ2LTSzt8ak4265XZlhUlUeQR8tjE=; b=S9/Ly0+wQRqevfMLfOdE744RHghOxhOfcpudPZMMKrol9KXETEoEBtT2cyw/RLbsAGUptuIXmg9DQbM8Z43r97U8vondwrjpZwKu0M+4RSyGekafMvoAElFfRmtyQJ/j9B1tclPF1m/ySpR8LFaGU80OWcFx/7W5g0tSu4wYPhfDJzwazlTDwrJluFEPlMKa16CNteSQW5evggowzIPOumMUUUzcahMEzixGuOoEiS2/9zZwDr29cE1L9e2wiLdYwM+TBhWN42sYUo1ZdCSAefWqXY869vKqaR7LyjDamdeV/v6CfRB4uKQDWkd4V4oQFhLA333h6tyBmcOOraEw3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <23d3cf82-3987-d5bc-7f71-48b573a47e6b@suse.com> Date: Tue, 28 Feb 2023 18:06:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 05/10] xen: pci: introduce reference counting for pdev Content-Language: en-US To: Volodymyr Babchuk Cc: Oleksandr Andrushchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Kevin Tian , "xen-devel@lists.xenproject.org" References: <20220831141040.13231-1-volodymyr_babchuk@epam.com> <20220831141040.13231-6-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220831141040.13231-6-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7922:EE_ X-MS-Office365-Filtering-Correlation-Id: d17c6ee3-0493-4a23-8224-08db19ae2775 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y+EfrDAHXRxZ/4Edp963jZ1GYtFEsUCXHSwx7a4KyhPvKeO3yLMnxY5yXTcTkolIi4RtW6PBdFVUFiOPn1P9prCcNM3Kf9L1MbN/g0ZsIirZxgX1k7DlJ1invJEz8UL2ubteCiod6wdIIck4ue/usB//IeTtKmllqHU5Dp03otZVh7UWJNU5vwKNX0y1pdgL1F6ADUvFMOCEogZtdlUSaX+gOzCCN+6dOMA2ixqLrzKWeE/rpmavX3gcR9r3RDtB43BsKldCMBoSVRGYw8mVU7t4qoualXGZ96zD7hPLUKuYOrzVxDItxywLBGhE1LctjQ539BKh0GbOhKMnR9k/X1E15cLskAlJCTj2kkNjtktBEJXuOS1JM64oB/FaCZUY0i9MOx+ijdMFzDpHlWufFXHebHeqh3XfywREB985h4yTQGukOZLfNvzdagMXbigD5VBwqOT2D328459ljs9Ss5akPoxROczvEc+ubXTOULqZCDrAfpfQewQxauhX9uusWx2PXvoDREFNiFBJHhuv5t49falTzxXpfEwVXpidBKWcEKft58hMClhZKTsv4tn0C3NObhhR8HS2abKrl6lxgk9BngVgJz1m+N3DZFJK3ZwwA0dV/dIAnZhOYu2X+9j72LbPIN1t3CWtHJCL7CbpljaRl8pJQXO0/DY7djovSdMtj5tTtVRADOtDqOtx7DCiuvt7HP2bwMJvpyBHlf/FNuBuMmNWQgRexNfdwJ1/bWE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(376002)(39860400002)(396003)(346002)(451199018)(7416002)(5660300002)(83380400001)(41300700001)(8936002)(26005)(6506007)(186003)(53546011)(2906002)(36756003)(2616005)(6916009)(66556008)(8676002)(66946007)(66476007)(4326008)(38100700002)(6512007)(31686004)(316002)(54906003)(86362001)(6486002)(478600001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVNBUUJoN2tOVDd1TVJ1VHNCdEdoZnljUFFzYlVWTE1UUldFeXZ1TmpCaTFp?= =?utf-8?B?YUxrc2xmM3F3L3FJN0w4RTE1NFdhN1J4ZlpBR055R050R0ZlbzdiRGJ3RXU5?= =?utf-8?B?V0J4TmU2TndBbWpZTHZDQWs3TUdZdEpScWNmOCtyRlVzNFBTN0RRdzZQTFJT?= =?utf-8?B?N25uUllDWkw3R2hWdWZWUzZaY2Vtck9ldmRPM2NyUGtLYy9BZFlGS2Z1bnh2?= =?utf-8?B?YVpVSXA2UzZscWxvejdUS3p2RnM4V1AwdzRiKzZKdGZMam1lY1R5NFFvdnhl?= =?utf-8?B?L3NRVFd6Nll2OUFuZWFrdHEyVHIzZndDTURRQ3RWRHBnaGwwVnNEQUxBZVV3?= =?utf-8?B?QjYvM3h3VDZrdmlLWFhkSkJNczhMd29CYUswSXBFc3MvK0tCaVRIM0htbFdU?= =?utf-8?B?cTdnWGpSTUdoNUFwbkxtZ3EvZTYzMW41bk42RzBKRTZjcFlCeFo3Nms3ZVFj?= =?utf-8?B?ZnZUWHR3M1llNzV0Wm1PczgwVFdha1ZjRmxrRGFIOWxlTEFkREdIK2ZlRlBl?= =?utf-8?B?dzJQV2szNVRUOTVWTkJUbXNTV216MmRxckdTeGZReVd0TjBWWUtYSkhDV1Ux?= =?utf-8?B?NGhwOVlaNlh3dGJjam9oeHRPUFhlUm44Mi9IMFZqZEtabnZwR0V2OFBJMXAw?= =?utf-8?B?SU5BT3FBM3R1TlFPQ2pTeWVTa0V4R1JmQlNuQmQ2Y294Q0VydVpBTjlOemZ4?= =?utf-8?B?bE0zaXEvNitJeGRZdFQxMGlZVDQ1ZVQwL3NrMm9GVUNNOWh1TEJQRVliS1Jz?= =?utf-8?B?NnpSSWtuUkhDU2lHLzYrWGlEajBnc2J5VmVNeUxoM0w3cjVCOVNiWkxrdXJE?= =?utf-8?B?UjE4dHRHNlF0MjFSbjVBYW9MOXNZWGpUYTI2VDZYYUFiSnFxSEkvdzlHK2R6?= =?utf-8?B?YUlUTERNUW5GclJxakdwMERhMFpFQ0s5NW1MSG9xWHIzTDR5ak9teDZKdUMy?= =?utf-8?B?TGN4eGhHeFZWVnREdVp1STAyM1ZKMFFZUld4bDl6RDZWMVVzMHJTZ1pSaDht?= =?utf-8?B?T0E4R0crdEcrM1RuRklJVEVDR2tzK1VjNStrQlZraUdrSitQRjluODUrY1ZO?= =?utf-8?B?MVRKbGozQmF2Z0pTMVFyVjg5Tjh3ekVSQkc1cXYvMTIrTG5MY21lYmttWTdY?= =?utf-8?B?eElaTE9VNUJiVmdLYlhXMjVmRkdSQk05VFRldzBSWUxwMHBTS3VqYXJrNkdC?= =?utf-8?B?b3p4K3pkMlMvYXNkNlBRUFBDUWw2L3Z6T3hLcS9nSTlBV0NpM1BnMnpnTjRP?= =?utf-8?B?Rk5TOVFCQ1BPQm9lSVp3MFduUlNldWRwNDc0QkZDdFpiMUpqMXorR0FsYXV3?= =?utf-8?B?K3VnTVJmVVMxRXp1eSs1WjZVWmoyRUJBNlFSbzRMTFpHL2g0ZVdTTEpnSnY1?= =?utf-8?B?Z2ZwRkE0My9Md2FzemhsWXBhYVJCaWwxYU1qRzhYdXgvc0RpV0RZOTJ2YjNo?= =?utf-8?B?WHJaaDAyTFVERFNlL2FuaE9sSVBlOVAyaXY3RnVGTC9icVpDVTFFa0hwU0c4?= =?utf-8?B?dThsWCtSbkFSNU5iZ3FPczhPYU9kWnFGeWFFUjZza2MxZFBJeTlVMUJnNmpq?= =?utf-8?B?QVovQzBGRWVEdnhyOGVHSWJmTTRCeHJHVWNIbDMzcHlOUEZQdFRCNy9na3cx?= =?utf-8?B?MzNmTUhib1ZvbGtJQ2lXd0lRYnMrVkNNSlRSSFhKck1xb3dKOGtPek1ZVyt2?= =?utf-8?B?Z09ENzdYK2FZV0xGaE5ENFU4RlZQdEQyMDducFpYTnBOUEFxYkNXcmNCazlJ?= =?utf-8?B?WVpjdXdPQnJIdllZYTF4S1dSTnJwcGN4TWtIekJPTGJVbjYreGR3cXl5SXhm?= =?utf-8?B?YTZXOGRqRzE1UmsvZmdiVHhIY0FsVGI1K0I4MStJWU4rUlVReEtXaURQQW10?= =?utf-8?B?OEk1MW4zU05lWW1xbG92T20rL25HS3BFVnVwZ3dlSktNb0wwTnJtc3lBWDA1?= =?utf-8?B?b3pNMTVXWDMybmJkb0lKeSs4NWM4RE9VTHE0MW9kMWdRcDdHalBOMzQ1elJs?= =?utf-8?B?M0tiTmQwY0dud3IweVo0SkMzQzVNNExJb0IyZG5lZzE4L1ZldnVKMjMwd2Fo?= =?utf-8?B?bnhEemp4ZkY3VTFGeUp2QThQaEw1UzdPb3BCMzRFanV5b0JGSUxDalIzYUhl?= =?utf-8?Q?AMq+AhGml5UaelHm7e1TPknge?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d17c6ee3-0493-4a23-8224-08db19ae2775 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 17:06:38.1479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oCqg/F3TBpJB3od70t4h4iVefviJC9DuhYl2ui6eboAz6q5czEAL6VlD8cxRIPTcHq2CoM22bMYNB47EJ/PSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7922 On 31.08.2022 16:11, Volodymyr Babchuk wrote: > Prior to this change, lifetime of pci_dev objects was protected by global > pcidevs_lock(). We are going to get if of this lock, so we need some > other mechanism to ensure that those objects will not disappear under > feet of code that access them. Reference counting is a good choice as > it provides easy to comprehend way to control object lifetime with > better granularity than global super lock. > > This patch adds two new helper functions: pcidev_get() and > pcidev_put(). pcidev_get() will increase reference counter, while > pcidev_put() will decrease it, destroying object when counter reaches > zero. > > pcidev_get() should be used only when you already have a valid pointer > to the object or you are holding lock that protects one of the > lists (domain, pseg or ats) that store pci_dev structs. > > pcidev_get() is rarely used directly, because there already are > functions that will provide valid pointer to pci_dev struct: > pci_get_pdev() and pci_get_real_pdev(). They will lock appropriate > list, find needed object and increase its reference counter before > returning to the caller. > > Naturally, pci_put() should be called after finishing working with a > received object. This is the reason why this patch have so many > pcidev_put()s and so little pcidev_get()s: existing calls to > pci_get_*() functions now will increase reference counter > automatically, we just need to decrease it back when we finished. > > This patch removes "const" qualifier from some pdev pointers because > pcidev_put() technically alters the contents of pci_dev structure. I wonder if you have so few "get"s because in some cases references would be needed, but aren't being obtained. As a rule of thumb I'd expect any entity storing a pointer in a long-lived data structure to obtain a ref first. And we have quite a few struct fields pointing to devices. I'd also expect a reference to be held when a device is e.g. put on a domain's list. This would then likely mean that for example in deassign_device() (or maybe pci_add_device()) you wouldn't drop the ref in the success case, but instead the ref would transfer to the domain the device is added to. > --- > > - Jan, can I add your Suggested-by tag? Sure, why not. Jan From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:21:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:21:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503602.775908 (Exim 4.92) (envelope-from ) id 1pX3fL-0003JD-2n; Tue, 28 Feb 2023 17:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503602.775908; Tue, 28 Feb 2023 17:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3fL-0003J6-0A; Tue, 28 Feb 2023 17:21:27 +0000 Received: by outflank-mailman (input) for mailman id 503602; Tue, 28 Feb 2023 17:21:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3fJ-0003IB-Tu for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:21:25 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52e9fc8c-b78c-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 18:21:23 +0100 (CET) Received: by mail-lf1-x12e.google.com with SMTP id i28so1443733lfv.0 for ; Tue, 28 Feb 2023 09:21:23 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id s16-20020ac25ff0000000b004cb3e97bff8sm1409793lfg.284.2023.02.28.09.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 09:21:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52e9fc8c-b78c-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RtlQ5muvjdD0FlQL2RYNDXzuLCtF6tEFzlHWSlX0cK4=; b=iAVEdVdS2/gSOBj93x18LcvF7jrAqyPqlDuqd6X3pJXvmGhvUTp661WsQHfG37+lQR xZ3EIRFNceCkTttnEWT+S68u/DyEM6egcwgdMZLkGpfkAsJC3NhpaJEmT7640xzKBIjJ no45QxL4rSeJ6LfAC7R4xElssvCoUOgbvjk8fSoPx3ykUQNc323CqyaaBVENvyHXaYU+ Y2gehdzGNUiif8tsX0XEaWukb3s9cbVlOUNZQauVpWRTWYareIb0c5jCjS56lBSPSR1P Ke+bIRI1LNoweM1eujdUU8PL8iPufCgLDzDwHNtg2ENpd1QVs0+Sd6aoejo+UlYKSgbx m9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RtlQ5muvjdD0FlQL2RYNDXzuLCtF6tEFzlHWSlX0cK4=; b=PO+BCFg2osIiRSaIRpdQGNgsKA0JhH6NuiYWCDgSTRwqADgxq+H7lhapkU6WUGtjGd r542eogVVW3ayuTjrHDv7ZIk45tUcUWI+U4E8dQKqN5+iMSQ7UiYWml20fNxurPfljbS NhXDBSvcLjeTRuAU6/7ZqceIcPtIu2ivhWXndOOAcNnEf3jvhq/i92xydF4Wjw8ddqPI g27Pbs8zMjvPAofo+YvaxSBiIrzCn5ahj8MgvAX8zcKWgmqBE4XGZPGo3z1emO48Sxjv duEjbhhvO0Wm5lf47RWbUGMRuCUJLzhyPZOemrvsrIaybHZR9Ig3VOX6zaZ7nMngrlQJ 0Uew== X-Gm-Message-State: AO0yUKVefHg/urABJGnJ5FcMRuVEL3Rzfh9YgevrsOlfrsA1+zxCwNZW ZF28Bug/X3HwwnQ5dFSGWEI= X-Google-Smtp-Source: AK7set/qT43gIq99eTrDUnPitzHdjj9fx2zlPfBmSCdb7rpy02yriCkLVmTeK+YoNzsIH3vrU7zb+g== X-Received: by 2002:a05:6512:1046:b0:4b6:e405:1027 with SMTP id c6-20020a056512104600b004b6e4051027mr1148408lfb.14.1677604882280; Tue, 28 Feb 2023 09:21:22 -0800 (PST) Message-ID: <6735859208c6dcb7320f89664ae298005f70827b.camel@gmail.com> Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk Date: Tue, 28 Feb 2023 19:21:17 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Hi Julien, On Sat, 2023-02-25 at 17:05 +0000, Julien Grall wrote: >=20 >=20 > On 25/02/2023 16:49, Julien Grall wrote: > > Hi Oleksii, > >=20 > > On 24/02/2023 11:31, Oleksii Kurochko wrote: > > > The following changes were made: > > > * make GENERIC_BUG_FRAME mandatory for ARM > >=20 > > I have asked in patch #1 but will ask it again because I think this > > should be recorded in the commit message. Can you outline why it is > > not=20 > > possible to completely switch to the generic version? >=20 > I have just tried to remove it on arm64 and it seems to work. This > was=20 > only tested with GCC 10 though. But given the generic version is not > not=20 > using the %c modifier, then I wouldn't expect any issue. >=20 > Cheers, >=20 I tried to switch ARM to generic implementation. Here is the patch: [1] diff --git a/xen/arch/arm/include/asm/bug.h b/xen/arch/arm/include/asm/bug.h index e6cc37e1d6..ffb0f569fc 100644 --- a/xen/arch/arm/include/asm/bug.h +++ b/xen/arch/arm/include/asm/bug.h @@ -1,8 +1,6 @@ #ifndef __ARM_BUG_H__ #define __ARM_BUG_H__ =20 -#include - #if defined(CONFIG_ARM_32) # include #elif defined(CONFIG_ARM_64) @@ -11,63 +9,7 @@ # error "unknown ARM variant" #endif =20 -#define BUG_FRAME_STRUCT - -struct bug_frame { - signed int loc_disp; /* Relative address to the bug address */ - signed int file_disp; /* Relative address to the filename */ - signed int msg_disp; /* Relative address to the predicate (for ASSERT) */ - uint16_t line; /* Line number */ - uint32_t pad0:16; /* Padding for 8-bytes align */ -}; - -#define bug_ptr(b) ((const void *)(b) + (b)->file_disp) -#define bug_line(b) ((b)->line) -#define bug_msg(b) ((const char *)(b) + (b)->msg_disp) - -/* Many versions of GCC doesn't support the asm %c parameter which would - * be preferable to this unpleasantness. We use mergeable string - * sections to avoid multiple copies of the string appearing in the - * Xen image. BUGFRAME_run_fn needs to be handled separately. - */ -#define BUG_FRAME(type, line, file, has_msg, msg) do { =20 \ - BUILD_BUG_ON((line) >> 16); =20 \ - BUILD_BUG_ON((type) >=3D BUGFRAME_NR); =20 \ - asm ("1:"BUG_INSTR"\n" =20 \ - ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" =20 \ - "2:\t.asciz " __stringify(file) "\n" =20 \ - "3:\n" =20 \ - ".if " #has_msg "\n" =20 \ - "\t.asciz " #msg "\n" =20 \ - ".endif\n" =20 \ - ".popsection\n" =20 \ - ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ - "4:\n" =20 \ - ".p2align 2\n" =20 \ - ".long (1b - 4b)\n" =20 \ - ".long (2b - 4b)\n" =20 \ - ".long (3b - 4b)\n" =20 \ - ".hword " __stringify(line) ", 0\n" =20 \ - ".popsection"); =20 \ -} while (0) - -/* - * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set the - * flag but instead rely on the default value from the compiler). So the - * easiest way to implement run_in_exception_handler() is to pass the to - * be called function in a fixed register. - */ -#define run_in_exception_handler(fn) do { =20 \ - asm ("mov " __stringify(BUG_FN_REG) ", %0\n" =20 \ - "1:"BUG_INSTR"\n" =20 \ - ".pushsection .bug_frames." __stringify(BUGFRAME_run_fn) "," \ - " \"a\", %%progbits\n" =20 \ - "2:\n" =20 \ - ".p2align 2\n" =20 \ - ".long (1b - 2b)\n" =20 \ - ".long 0, 0, 0\n" =20 \ - ".popsection" :: "r" (fn) : __stringify(BUG_FN_REG) ); =20 \ -} while (0) +#define BUG_ASM_CONST "c" =20 #endif /* __ARM_BUG_H__ */ ... (it will be merged with patch 3 if it is OK ) And looks like we can switch ARM to generic implementation as all tests passed: https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/791549396 The only issue is with yocto-arm: https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/791549396/failu= res But I am not sure that it is because of my patch Is this enough from a verification point of view? [1] https://gitlab.com/xen-project/people/olkur/xen/-/commit/5ff7a06e1d354e1e42= bde1c203f3cf05a3653ad6 https://gitlab.com/xen-project/people/olkur/xen/-/commit/5ff7a06e1d354e1e42= bde1c203f3cf05a3653ad6 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:21:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503604.775917 (Exim 4.92) (envelope-from ) id 1pX3fe-0003mR-F9; Tue, 28 Feb 2023 17:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503604.775917; Tue, 28 Feb 2023 17:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3fe-0003mK-CX; Tue, 28 Feb 2023 17:21:46 +0000 Received: by outflank-mailman (input) for mailman id 503604; Tue, 28 Feb 2023 17:21:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3fc-0003IB-Eq for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:21:44 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5eeb817b-b78c-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 18:21:43 +0100 (CET) Received: by mail-lj1-x22e.google.com with SMTP id z42so11037420ljq.13 for ; Tue, 28 Feb 2023 09:21:43 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id h24-20020a05651c125800b002958904dceesm1296094ljh.13.2023.02.28.09.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 09:21:42 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eeb817b-b78c-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=SZe9bOL2Rt/Ls+qvothBWJskKPaxYJQR8kGQbjFvucU=; b=acKiB++dEI+2DTOIIUrjShg7bzlkxfUAi0WRdtXuVqXEkv0RA8nQiZiwAsnr3rks5L //nL8TUKSiwTTUHqhjKRhrxuwtuZ6lGxy5oRyKnhu53d3WHuCITNr2StJaECllSfC1u5 sg8KVqSbQDCzJbbQiJPQmn/jwWDZd7f2DqAE4kj01AjJy7+89QlFbg+wZXKZG4eCeLPC I0yD1O+55WrJ4Jc6VS6InZg1TytXpHQ5E8lwovSCzIfaTMtLBi1nyfo1Bvk8XZBG75ht qAZUbHawDbWuIm7FjaxThgYlyCeW++AOA3BPqaqtrJBPCpz9xYIg/A2gP5YvxOpuubGP 66Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SZe9bOL2Rt/Ls+qvothBWJskKPaxYJQR8kGQbjFvucU=; b=QbFhfYAhBddQCueZMop7Ds3jNtZhwBHiGN4Agj/+XYsedisJRIXE+lk58Apyw2YPwS OUcKOC46ZWtyHal6ud2thS2qe5uuh5MJ/hnBS1zL1YY0QRhehSYaUbvqCL5Y06vFBQyG EsRoARgha6WuTmTtGR7ABPDS0qHz0YxRBP3IMMb4huUWzba+7nA3QdxNhPMC2LVQMt/o UbVJv5DmAbXHlwOdo9Vq2H3D4T/gs0rPR/XUVZMZ9OXpveto/BYhLA82dX1AkXBWft5A 1oWm7bGX59NX9oNEOXmOsNGUwEz1a+ixgi26cFMn6zYOrkfl2ns1opSWExfpXl82BOUg s8bg== X-Gm-Message-State: AO0yUKWB5k4QkTSJwlE8pzZTOKWd6SmYbMdJ3SyuEi7mazGBXJWR0c7s gt8Up3jjySfNhWZNvLjEJRg= X-Google-Smtp-Source: AK7set/Nu8CtO0/h+mgz+pEUmMz56QzfLTr8dGXkxSdEUEAtcgMg36lH+VBGlktXPShqHfuHH3IyAw== X-Received: by 2002:a2e:9b49:0:b0:293:4b61:265a with SMTP id o9-20020a2e9b49000000b002934b61265amr1086094ljj.49.1677604902802; Tue, 28 Feb 2023 09:21:42 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Wei Liu Date: Tue, 28 Feb 2023 19:21:40 +0200 In-Reply-To: <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 SGkgSnVsaWVuLAoKT24gU2F0LCAyMDIzLTAyLTI1IGF0IDE2OjQyICswMDAwLCBKdWxpZW4gR3Jh bGwgd3JvdGU6Cj4gSGkgT2xla3NpaSwKPiAKPiBPbiAyNC8wMi8yMDIzIDExOjMxLCBPbGVrc2lp IEt1cm9jaGtvIHdyb3RlOgo+ID4gQSBsYXJnZSBwYXJ0IG9mIHRoZSBjb250ZW50IG9mIHRoZSBi dWcuaCBpcyByZXBlYXRlZCBhbW9uZyBhbGwKPiA+IGFyY2hpdGVjdHVyZXMsIHNvIGl0IHdhcyBk ZWNpZGVkIHRvIGNyZWF0ZSBhIG5ldyBjb25maWcKPiA+IENPTkZJR19HRU5FUklDX0JVR19GUkFN RS4KPiA+IAo+ID4gVGhlIHZlcnNpb24gb2YgPGJ1Zy5oPiBmcm9tIHg4NiB3YXMgdGFrZW4gYXMg dGhlIGJhc2UgdmVyc2lvbi4KPiA+IAo+ID4gVGhlIHBhdGNoIGludHJvZHVjZXMgdGhlIGZvbGxv d2luZyBzdHVmZjoKPiA+IMKgwqAgKiBjb21tb24gYnVnLmggaGVhZGVyCj4gPiDCoMKgICogZ2Vu ZXJpYyBpbXBsZW1lbnRhdGlvbiBvZiBkb19idWdfZnJhbWUKPiA+IMKgwqAgKiBuZXcgY29uZmln IENPTkZJR19HRU5FUklDX0JVR19GUkFNRQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lp IEt1cm9jaGtvIDxvbGVrc2lpLmt1cm9jaGtvQGdtYWlsLmNvbT4KPiA+IC0tLQo+ID4gQ2hhbmdl cyBpbiBWMzoKPiA+IMKgICogQWRkIGRlYnVnZ2VyX3RyYXBfZmF0YWwoKSB0byBkb19idWdfZnJh bWUoKS4gSXQgc2ltcGxpZmllcwo+ID4gdXNhZ2Ugb2YKPiA+IMKgwqDCoCBkb19idWdfZnJhbWUo KSBmb3IgeDg2IHNvIG1ha2luZyBoYW5kbGVfYnVnX2ZyYW1lKCkgYW5kCj4gPiBmaW5kX2J1Z19m cmFtZSgpCj4gPiDCoMKgwqAgbm90IG5lZWRlZCBhbnltb3JlLgo+ID4gwqAgKiBVcGRhdGUgZG9f YnVnX2ZyYW1lKCkgdG8gcmV0dXJuIC1FSU5WQUwgaWYgc29tZXRoaW5nIGdvZXMKPiA+IHdyb25n OyBvdGhlcndpc2UKPiA+IMKgwqDCoCBpZCBvZiBidWdfZnJhbWUKPiA+IMKgICogVXBkYXRlIF9B U01fQlVHRlJBTUVfVEVYVCB0byBtYWtlIGl0IG1vcmUgcG9ydGFibGUuCj4gPiDCoCAqIERyb3Ag dW5uZWNlc3NhcnkgY29tbWVudHMuCj4gPiDCoCAqIGRlZmluZSBzdHViIHZhbHVlIGZvciBUUkFQ X2ludmFsaWRfb3AgaW4gY2FzZSBpZiB3YXNuJ3QgZGVmaW5lZAo+ID4gaW4KPiA+IMKgwqDCoCBh cmNoLXNwZWNpZmljIGZvbGRlcnMuCj4gPiAtLS0KPiA+IENoYW5nZXMgaW4gVjI6Cj4gPiDCoMKg IC0gU3dpdGNoIHRvIHg4NiBpbXBsZW1lbnRhdGlvbiBhcyBnZW5lcmljIGFzIGl0IGlzIG1vcmUg Y29tcGFjdAo+ID4gwqDCoMKgwqAgKCBhdCBsZWFzdCBmcm9tIHRoZSBwb2ludCBvZiB2aWV3IG9m IGJ1ZyBmcmFtZSBzdHJ1Y3R1cmUgKS4KPiA+IMKgwqAgLSBSZW5hbWUgQ09ORklHX0dFTkVSSUNf RE9fQlVHX0ZSQU1FIHRvCj4gPiBDT05GSUdfR0VORVJJQ19CVUdfRlJBTUUuCj4gPiDCoMKgIC0g Q2hhbmdlIHRoZSBtYWNybyBidWdfbG9jKGIpIHRvIGF2b2lkIHRoZSBuZWVkIGZvciBhIGNhc3Q6 Cj4gPiDCoMKgwqDCoCAjZGVmaW5lIGJ1Z19sb2MoYikgKCh1bnNpZ25lZCBsb25nKShiKSArIChi KS0+bG9jX2Rpc3ApCj4gPiDCoMKgIC0gUmVuYW1lIEJVR19GUkFNRV9TVFVGRiB0byBCVUdfRlJB TUVfU1RSVUNUCj4gPiDCoMKgIC0gTWFrZSBtYWNyb3MgcmVsYXRlZCB0byBidWcgZnJhbWUgc3Ry dWN0dXJlIG1vcmUgZ2VuZXJpYy4KPiA+IMKgwqAgLSBJbnRyb2R1Y2UgQlVHX0lOU1RSIGFuZCBN T0RJRklFUiB0byBtYWtlIF9BU01fQlVHRlJBTUVfVEVYVAo+ID4gcmV1c2FibGUKPiA+IMKgwqDC oMKgIGJldHdlZW4geDg2IGFuZCBSSVNDLVYuCj4gPiDCoMKgIC0gUmV3b3JrIGRvX2J1Z19mcmFt ZSgpIGFuZCBpbnRyb2R1Y2UgZmluZF9idWdfZnJhbWUoKSBhbmQKPiA+IGhhbmRsZV9idWdfZnJh bWUoKQo+ID4gwqDCoMKgwqAgZnVuY3Rpb25zIHRvIG1ha2UgaXQgcmV1c2FibGUgYnkgeDg2Lgo+ ID4gwqDCoCAtIGNvZGUgc3R5bGUgZml4ZXMKPiA+IC0tLQo+ID4gwqAgeGVuL2NvbW1vbi9LY29u ZmlnwqDCoMKgIHzCoMKgIDMgKwo+ID4gwqAgeGVuL2NvbW1vbi9NYWtlZmlsZcKgwqAgfMKgwqAg MSArCj4gPiDCoCB4ZW4vY29tbW9uL2J1Zy5jwqDCoMKgwqDCoCB8IDEwOSArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiA+IMKgIHhlbi9pbmNsdWRlL3hlbi9idWcuaCB8IDE1MAo+ID4g KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiDCoCA0IGZpbGVz IGNoYW5nZWQsIDI2MyBpbnNlcnRpb25zKCspCj4gPiDCoCBjcmVhdGUgbW9kZSAxMDA2NDQgeGVu L2NvbW1vbi9idWcuYwo+ID4gwqAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9pbmNsdWRlL3hlbi9i dWcuaAo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9LY29uZmlnIGIveGVuL2NvbW1v bi9LY29uZmlnCj4gPiBpbmRleCBmMWVhMzE5OWM4Li5iMjI2MzIzNTM3IDEwMDY0NAo+ID4gLS0t IGEveGVuL2NvbW1vbi9LY29uZmlnCj4gPiArKysgYi94ZW4vY29tbW9uL0tjb25maWcKPiA+IEBA IC0yOCw2ICsyOCw5IEBAIGNvbmZpZyBBTFRFUk5BVElWRV9DQUxMCj4gPiDCoCBjb25maWcgQVJD SF9NQVBfRE9NQUlOX1BBR0UKPiA+IMKgwqDCoMKgwqDCoMKgwqBib29sCj4gPiDCoCAKPiA+ICtj b25maWcgR0VORVJJQ19CVUdfRlJBTUUKPiA+ICvCoMKgwqDCoMKgwqDCoGJvb2wKPiA+ICsKPiA+ IMKgIGNvbmZpZyBIQVNfQUxURVJOQVRJVkUKPiA+IMKgwqDCoMKgwqDCoMKgwqBib29sCj4gPiDC oCAKPiA+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL01ha2VmaWxlIGIveGVuL2NvbW1vbi9NYWtl ZmlsZQo+ID4gaW5kZXggYmJkNzViNGJlNi4uNDYwNDllYWMzNSAxMDA2NDQKPiA+IC0tLSBhL3hl bi9jb21tb24vTWFrZWZpbGUKPiA+ICsrKyBiL3hlbi9jb21tb24vTWFrZWZpbGUKPiA+IEBAIC0x LDUgKzEsNiBAQAo+ID4gwqAgb2JqLSQoQ09ORklHX0FSR08pICs9IGFyZ28ubwo+ID4gwqAgb2Jq LXkgKz0gYml0bWFwLm8KPiA+ICtvYmotJChDT05GSUdfR0VORVJJQ19CVUdfRlJBTUUpICs9IGJ1 Zy5vCj4gPiDCoCBvYmotJChDT05GSUdfSFlQRlNfQ09ORklHKSArPSBjb25maWdfZGF0YS5vCj4g PiDCoCBvYmotJChDT05GSUdfQ09SRV9QQVJLSU5HKSArPSBjb3JlX3Bhcmtpbmcubwo+ID4gwqAg b2JqLXkgKz0gY3B1Lm8KPiA+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2J1Zy5jIGIveGVuL2Nv bW1vbi9idWcuYwo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4IDAwMDAwMDAwMDAu LmY4MTcyNGZjOWIKPiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL3hlbi9jb21tb24vYnVnLmMK PiA+IEBAIC0wLDAgKzEsMTA5IEBACj4gPiArI2luY2x1ZGUgPHhlbi9idWcuaD4KPiA+ICsjaW5j bHVkZSA8eGVuL2RlYnVnZ2VyLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9lcnJuby5oPgo+ID4gKyNp bmNsdWRlIDx4ZW4va2VybmVsLmg+Cj4gPiArI2luY2x1ZGUgPHhlbi9saXZlcGF0Y2guaD4gPiAr I2luY2x1ZGUgPHhlbi9zdHJpbmcuaD4KPiA+ICsjaW5jbHVkZSA8eGVuL3R5cGVzLmg+Cj4gPiAr I2luY2x1ZGUgPHhlbi92aXJ0dWFsX3JlZ2lvbi5oPgo+ID4gKwo+ID4gKyNpbmNsdWRlIDxhc20v cHJvY2Vzc29yLmg+Cj4gPiArCj4gPiArLyogU2V0IGRlZmF1bHQgdmFsdWUgZm9yIFRSQVBfaW52 YWxpZF9vcCBhcyBpdCBpcyBkZWZpbmVkIG9ubHkgZm9yCj4gPiBYODYgbm93ICovCj4gPiArI2lm bmRlZiBUUkFQX2ludmFsaWRfb3AKPiA+ICsjZGVmaW5lIFRSQVBfaW52YWxpZF9vcCAwCj4gPiAr I2VuZGlmCj4gCj4gSXQgZmVlbHMgdG8gbWUgdGhhdCB0aGlzIHZhbHVlIHNob3VsZCBiZSBkZWZp bmVkIGluIHRoZSBlbHNlIHBhcnQgaW4gCj4geGVuL2RlYnVnZ2VyLmguCkFzIGl0IHdhcyBkaXNz Y3Vzc2VkIGluIHRoZSBvdGhlciBlLW1haWwgWzFdIHRoZSBmb2xsb3dpbmcgd2lsbCBiZQppbnRy b2R1Y2VkIGluIDx4ZW4vYnVnLmg+CgojaWZuZGVmIEJVR19ERUJVR0dFUl9UUkFQX0ZBVEFMCiNk ZWZpbmUgQlVHX0RFQlVHR0VSX1RSQVBfRkFUQUwocmVncykgMAojZW5kaWYKCmFuZCByZS1kZWZp bmVkIGluIDxhc20vYnVnLmg+LgoKT2YgY291cnNlLCBkb19idWdfZnJhbWUoKSB3aWxsIGJlIHVw ZGF0ZWQgY29ycmVzcG9uZGluZ2x5IHRvIHVzZQpCVUdfREVCVUdHRVJfVFJBUF9GQVRBTC4KClsx XQpodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvOWI2NmVlNTEtMTdjMy0wZjhlLTBm YzItNGZmMDgzOTUyZTlkQHN1c2UuY29tLwo+IAo+ID4gKwo+ID4gK2ludCBkb19idWdfZnJhbWUo Y29uc3Qgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MsIHVuc2lnbmVkIGxvbmcKPiA+IHBjKQo+ IAo+IEkgd291bGQgc3VnZ2VzdCB0byBkb2N1bWVudCB3aGF0IHRoaXMgZnVuY3Rpb24gaXMgbWVh bnQgdG8gcmV0dXJuLiAKPiBBRkFVSSwgaXQgd291bGQgcmV0dXJuIGEgbmVnYXRpdmUgdmFsdWUg aW4gY2FzZSBvZiBhbiBlcnJvciBvdGhlcndpc2UKPiB0aGUgYnVnIHR5cGUuCnN1cmUuIGknbGwg YWRkZWQgaW4gdGhlIG5leHQgcGF0Y2ggdmVyc2lvbi4KPiAKPiA+ICt7Cj4gPiArwqDCoMKgIGNv bnN0IHN0cnVjdCBidWdfZnJhbWUgKmJ1ZyA9IE5VTEw7Cj4gPiArwqDCoMKgIGNvbnN0IHN0cnVj dCB2aXJ0dWFsX3JlZ2lvbiAqcmVnaW9uOwo+ID4gK8KgwqDCoCBjb25zdCBjaGFyICpwcmVmaXgg PSAiIiwgKmZpbGVuYW1lLCAqcHJlZGljYXRlOwo+ID4gK8KgwqDCoCB1bnNpZ25lZCBsb25nIGZp eHVwOwo+ID4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgaWQgPSBCVUdGUkFNRV9OUiwgbGluZW5vOwo+ ID4gKwo+ID4gK8KgwqDCoCByZWdpb24gPSBmaW5kX3RleHRfcmVnaW9uKHBjKTsKPiA+ICvCoMKg wqAgaWYgKCByZWdpb24gKQo+IAo+IE5JVDogSWYgeW91IGludmVydCB0aGUgY29uZGl0aW9uIGhl cmUsIHRoZW4geW91IGNhbiByZWR1Y2UgdGhlCj4gaW5kZW50aW9uIAo+IGJ5IG9uZSBiZWxvdy4K VGhhbmtzLiBpJ2xsIGFkZGVkIGluIHRoZSBuZXh0IHBhdGNoIHZlcnNpb24uCj4gCj4gPiArwqDC oMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoCBmb3IgKCBpZCA9IDA7IGlkIDwgQlVHRlJBTUVfTlI7 IGlkKysgKQo+ID4gK8KgwqDCoMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGNvbnN0IHN0cnVjdCBidWdfZnJhbWUgKmI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB1 bnNpZ25lZCBpbnQgaTsKPiAKPiBZb3UgY29tcGFyZSB0aGlzIGFnYWluc3Qgbl9idWdzIHdoaWNo IGlzIGEgc2l6ZV90LiBTbywgdGhpcyB3YW50cyB0bwo+IGJlIAo+IGEgc2l6ZV90LgpUaGlzIG9u ZSB3aWxsIGJlIHVwZGF0ZWQgdG9vLiBUaGFua3MuCj4gCj4gPiArCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBmb3IgKCBpID0gMCwgYiA9IHJlZ2lvbi0+ZnJhbWVbaWRdLmJ1Z3M7Cj4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpIDwgcmVnaW9uLT5mcmFtZVtpZF0u bl9idWdzOyBiKyssIGkrKyApCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB7Cj4gPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmICggYnVnX2xvYyhiKSA9PSBwYyApCj4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBidWcgPSBiOwo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGdvdG8gZm91bmQ7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIH0KPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+ICvCoMKgwqDCoMKgwqDC oCB9Cj4gPiArwqDCoMKgIH0KPiA+ICsKPiA+ICsgZm91bmQ6Cj4gPiArwqDCoMKgIGlmICggIWJ1 ZyApCj4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiArCj4gPiArwqDCoMKg IGlmICggaWQgPT0gQlVHRlJBTUVfcnVuX2ZuICkKPiA+ICvCoMKgwqAgewo+ID4gKyNpZmRlZiBC VUdfRk5fUkVHCj4gPiArwqDCoMKgwqDCoMKgwqAgdm9pZCAoKmZuKShjb25zdCBzdHJ1Y3QgY3B1 X3VzZXJfcmVncyAqKSA9ICh2b2lkICopcmVncy0KPiA+ID5CVUdfRk5fUkVHOwo+IAo+IEFGQUlV LCB0aGlzIGlzIG5lY2Vzc2FyeSBzbyBBcm0gY2FuIHVzZSB0aGUgZ2VuZXJpYyBkb19idWdfZnJh bWUoKS4KPiAKPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IFJJU0MtViBhbmQgQXJt IGhhZCB0aGUgc2ltaWxhciBpc3N1ZSAKPiB3aXRoICVjLiBJdCBzZWVtcyBsaWtlIHlvdSBtYW5h Z2VkIHRvIHJlc29sdmUgaXQgb24gUklTQy1WLCBzbyBjYW4gd2UKPiBmdWxseSBzd2l0Y2ggQXJt IHRvIHRoZSBnZW5lcmljIGltcGxlbWVudGF0aW9uIG9mIGJ1Zz8KSSB0cmllZCB0byBzd2l0Y2gg QVJNIHRvIGdlbmVyaWMgaW1wbGVtZW50YXRpb24uCgpIZXJlIGlzIHRoZSBwYXRjaDogWzFdCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYnVnLmgKYi94ZW4vYXJjaC9hcm0v aW5jbHVkZS9hc20vYnVnLmgKaW5kZXggZTZjYzM3ZTFkNi4uZmZiMGY1NjlmYyAxMDA2NDQKLS0t IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2J1Zy5oCisrKyBiL3hlbi9hcmNoL2FybS9pbmNs dWRlL2FzbS9idWcuaApAQCAtMSw4ICsxLDYgQEAKICNpZm5kZWYgX19BUk1fQlVHX0hfXwogI2Rl ZmluZSBfX0FSTV9CVUdfSF9fCiAKLSNpbmNsdWRlIDx4ZW4vdHlwZXMuaD4KLQogI2lmIGRlZmlu ZWQoQ09ORklHX0FSTV8zMikKICMgaW5jbHVkZSA8YXNtL2FybTMyL2J1Zy5oPgogI2VsaWYgZGVm aW5lZChDT05GSUdfQVJNXzY0KQpAQCAtMTEsNjMgKzksNyBAQAogIyBlcnJvciAidW5rbm93biBB Uk0gdmFyaWFudCIKICNlbmRpZgogCi0jZGVmaW5lIEJVR19GUkFNRV9TVFJVQ1QKLQotc3RydWN0 IGJ1Z19mcmFtZSB7Ci0gICAgc2lnbmVkIGludCBsb2NfZGlzcDsgICAgLyogUmVsYXRpdmUgYWRk cmVzcyB0byB0aGUgYnVnIGFkZHJlc3MgKi8KLSAgICBzaWduZWQgaW50IGZpbGVfZGlzcDsgICAv KiBSZWxhdGl2ZSBhZGRyZXNzIHRvIHRoZSBmaWxlbmFtZSAqLwotICAgIHNpZ25lZCBpbnQgbXNn X2Rpc3A7ICAgIC8qIFJlbGF0aXZlIGFkZHJlc3MgdG8gdGhlIHByZWRpY2F0ZSAoZm9yCkFTU0VS VCkgKi8KLSAgICB1aW50MTZfdCBsaW5lOyAgICAgICAgICAvKiBMaW5lIG51bWJlciAqLwotICAg IHVpbnQzMl90IHBhZDA6MTY7ICAgICAgIC8qIFBhZGRpbmcgZm9yIDgtYnl0ZXMgYWxpZ24gKi8K LX07Ci0KLSNkZWZpbmUgYnVnX3B0cihiKSAoKGNvbnN0IHZvaWQgKikoYikgKyAoYiktPmZpbGVf ZGlzcCkKLSNkZWZpbmUgYnVnX2xpbmUoYikgKChiKS0+bGluZSkKLSNkZWZpbmUgYnVnX21zZyhi KSAoKGNvbnN0IGNoYXIgKikoYikgKyAoYiktPm1zZ19kaXNwKQotCi0vKiBNYW55IHZlcnNpb25z IG9mIEdDQyBkb2Vzbid0IHN1cHBvcnQgdGhlIGFzbSAlYyBwYXJhbWV0ZXIgd2hpY2gKd291bGQK LSAqIGJlIHByZWZlcmFibGUgdG8gdGhpcyB1bnBsZWFzYW50bmVzcy4gV2UgdXNlIG1lcmdlYWJs ZSBzdHJpbmcKLSAqIHNlY3Rpb25zIHRvIGF2b2lkIG11bHRpcGxlIGNvcGllcyBvZiB0aGUgc3Ry aW5nIGFwcGVhcmluZyBpbiB0aGUKLSAqIFhlbiBpbWFnZS4gQlVHRlJBTUVfcnVuX2ZuIG5lZWRz IHRvIGJlIGhhbmRsZWQgc2VwYXJhdGVseS4KLSAqLwotI2RlZmluZSBCVUdfRlJBTUUodHlwZSwg bGluZSwgZmlsZSwgaGFzX21zZywgbXNnKSBkbyB7ICAgICAgICAgICAgICAgClwKLSAgICBCVUlM RF9CVUdfT04oKGxpbmUpID4+IDE2KTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIApcCi0gICAgQlVJTERfQlVHX09OKCh0eXBlKSA+PSBCVUdGUkFNRV9OUik7ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAKXAotICAgIGFzbSAoIjE6IkJVR19JTlNUUiJcbiIgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgClwKLSAgICAgICAgICIucHVzaHNl Y3Rpb24gLnJvZGF0YS5zdHIsIFwiYU1TXCIsICVwcm9nYml0cywgMVxuIiAgICAgICAgIApcCi0g ICAgICAgICAiMjpcdC5hc2NpeiAiIF9fc3RyaW5naWZ5KGZpbGUpICJcbiIgICAgICAgICAgICAg ICAgICAgICAgICAKXAotICAgICAgICAgIjM6XG4iICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgClwKLSAgICAgICAgICIuaWYgIiAjaGFzX21zZyAi XG4iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAi XHQuYXNjaXogIiAjbXNnICJcbiIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKXAotICAgICAgICAgIi5lbmRpZlxuIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgClwKLSAgICAgICAgICIucG9wc2VjdGlvblxuIiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAiLnB1c2hzZWN0 aW9uIC5idWdfZnJhbWVzLiIgX19zdHJpbmdpZnkodHlwZSkgIiwgXCJhXCIsCiVwcm9nYml0c1xu IlwKLSAgICAgICAgICI0OlxuIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAiLnAyYWxpZ24gMlxuIiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKXAotICAgICAgICAgIi5sb25nICgxYiAt IDRiKVxuIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgClwKLSAgICAg ICAgICIubG9uZyAoMmIgLSA0YilcbiIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIApcCi0gICAgICAgICAiLmxvbmcgKDNiIC0gNGIpXG4iICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKXAotICAgICAgICAgIi5od29yZCAiIF9fc3RyaW5naWZ5 KGxpbmUpICIsIDBcbiIgICAgICAgICAgICAgICAgICAgICAgICAgClwKLSAgICAgICAgICIucG9w c2VjdGlvbiIpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIApc Ci19IHdoaWxlICgwKQotCi0vKgotICogR0NDIHdpbGwgbm90IGFsbG93IHRvIHVzZSAiaSIgIHdo ZW4gUElFIGlzIGVuYWJsZWQgKFhlbiBkb2Vzbid0IHNldAp0aGUKLSAqIGZsYWcgYnV0IGluc3Rl YWQgcmVseSBvbiB0aGUgZGVmYXVsdCB2YWx1ZSBmcm9tIHRoZSBjb21waWxlcikuIFNvCnRoZQot ICogZWFzaWVzdCB3YXkgdG8gaW1wbGVtZW50IHJ1bl9pbl9leGNlcHRpb25faGFuZGxlcigpIGlz IHRvIHBhc3MgdGhlCnRvCi0gKiBiZSBjYWxsZWQgZnVuY3Rpb24gaW4gYSBmaXhlZCByZWdpc3Rl ci4KLSAqLwotI2RlZmluZSAgcnVuX2luX2V4Y2VwdGlvbl9oYW5kbGVyKGZuKSBkbyB7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgClwKLSAgICBhc20gKCJtb3YgIiBfX3N0cmluZ2lmeShCVUdf Rk5fUkVHKSAiLCAlMFxuIiAgICAgICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAiMToiQlVH X0lOU1RSIlxuIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKXAot ICAgICAgICAgIi5wdXNoc2VjdGlvbiAuYnVnX2ZyYW1lcy4iIF9fc3RyaW5naWZ5KEJVR0ZSQU1F X3J1bl9mbikgIiwiClwKLSAgICAgICAgICIgICAgICAgICAgICAgXCJhXCIsICUlcHJvZ2JpdHNc biIgICAgICAgICAgICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAiMjpcbiIgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKXAotICAgICAgICAg Ii5wMmFsaWduIDJcbiIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgClwKLSAgICAgICAgICIubG9uZyAoMWIgLSAyYilcbiIgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIApcCi0gICAgICAgICAiLmxvbmcgMCwgMCwgMFxuIiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKXAotICAgICAgICAgIi5wb3BzZWN0 aW9uIiA6OiAiciIgKGZuKSA6IF9fc3RyaW5naWZ5KEJVR19GTl9SRUcpICk7ICAgICAgClwKLX0g d2hpbGUgKDApCisjZGVmaW5lIEJVR19BU01fQ09OU1QgICAiYyIKIAogI2VuZGlmIC8qIF9fQVJN X0JVR19IX18gKi8KLi4uCihpdCB3aWxsIGJlIG1lcmdlZCB3aXRoIHBhdGNoIDMgaWYgaXQgaXMg T0sgKQoKQW5kIGxvb2tzIGxpa2Ugd2UgY2FuIHN3aXRjaCBBUk0gdG8gZ2VuZXJpYyBpbXBsZW1l bnRhdGlvbiBhcyBhbGwgdGVzdHMKcGFzc2VkOgpodHRwczovL2dpdGxhYi5jb20veGVuLXByb2pl Y3QvcGVvcGxlL29sa3VyL3hlbi8tL3BpcGVsaW5lcy83OTE1NDkzOTYKClRoZSBvbmx5IGlzc3Vl IGlzIHdpdGggeW9jdG8tYXJtOgpodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxl L29sa3VyL3hlbi8tL3BpcGVsaW5lcy83OTE1NDkzOTYvZmFpbHVyZXMKQnV0IEkgYW0gbm90IHN1 cmUgdGhhdCBpdCBpcyBiZWNhdXNlIG9mIG15IHBhdGNoCgpJcyB0aGlzIGVub3VnaCBmcm9tIGEg dmVyaWZpY2F0aW9uIHBvaW50IG9mIHZpZXc/CgpbMV0KaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1w cm9qZWN0L3Blb3BsZS9vbGt1ci94ZW4vLS9jb21taXQvNWZmN2EwNmUxZDM1NGUxZTQyYmRlMWMy MDNmM2NmMDVhMzY1M2FkNmh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvb2xr dXIveGVuLy0vY29tbWl0LzVmZjdhMDZlMWQzNTRlMWU0MmJkZTFjMjAzZjNjZjA1YTM2NTNhZDYK PiAKPiA+ICsjZWxzZQo+ID4gK8KgwqDCoMKgwqDCoMKgIHZvaWQgKCpmbikoY29uc3Qgc3RydWN0 IGNwdV91c2VyX3JlZ3MgKikgPSBidWdfcHRyKGJ1Zyk7Cj4gPiArI2VuZGlmCj4gPiArCj4gPiAr wqDCoMKgwqDCoMKgwqAgZm4ocmVncyk7Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJu IGlkOwo+ID4gK8KgwqDCoCB9Cj4gPiArCj4gPiArwqDCoMKgIC8qIFdBUk4sIEJVRyBvciBBU1NF UlQ6IGRlY29kZSB0aGUgZmlsZW5hbWUgcG9pbnRlciBhbmQgbGluZQo+ID4gbnVtYmVyLiAqLwo+ ID4gK8KgwqDCoCBmaWxlbmFtZSA9IGJ1Z19wdHIoYnVnKTsKPiA+ICvCoMKgwqAgaWYgKCAhaXNf a2VybmVsKGZpbGVuYW1lKSAmJiAhaXNfcGF0Y2goZmlsZW5hbWUpICkKPiA+ICvCoMKgwqDCoMKg wqDCoCByZXR1cm4gLUVJTlZBTDsKPiA+ICvCoMKgwqAgZml4dXAgPSBzdHJsZW4oZmlsZW5hbWUp Owo+ID4gK8KgwqDCoCBpZiAoIGZpeHVwID4gNTAgKQo+ID4gK8KgwqDCoCB7Cj4gPiArwqDCoMKg wqDCoMKgwqAgZmlsZW5hbWUgKz0gZml4dXAgLSA0NzsKPiA+ICvCoMKgwqDCoMKgwqDCoCBwcmVm aXggPSAiLi4uIjsKPiA+ICvCoMKgwqAgfQo+ID4gK8KgwqDCoCBsaW5lbm8gPSBidWdfbGluZShi dWcpOwo+ID4gKwo+ID4gK8KgwqDCoCBzd2l0Y2ggKCBpZCApCj4gPiArwqDCoMKgIHsKPiA+ICvC oMKgwqAgY2FzZSBCVUdGUkFNRV93YXJuOgo+ID4gK8KgwqDCoMKgwqDCoMKgIHByaW50aygiWGVu IFdBUk4gYXQgJXMlczolZFxuIiwgcHJlZml4LCBmaWxlbmFtZSwgbGluZW5vKTsKPiA+ICvCoMKg wqDCoMKgwqDCoCBzaG93X2V4ZWN1dGlvbl9zdGF0ZShyZWdzKTsKPiA+ICsKPiA+ICvCoMKgwqDC oMKgwqDCoCByZXR1cm4gaWQ7Cj4gPiArCj4gPiArwqDCoMKgIGNhc2UgQlVHRlJBTUVfYnVnOgo+ ID4gK8KgwqDCoMKgwqDCoMKgIHByaW50aygiWGVuIEJVRyBhdCAlcyVzOiVkXG4iLCBwcmVmaXgs IGZpbGVuYW1lLCBsaW5lbm8pOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIGlmICggZGVidWdn ZXJfdHJhcF9mYXRhbChUUkFQX2ludmFsaWRfb3AsIHJlZ3MpICkKPiA+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiBpZDsKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBzaG93X2V4ZWN1 dGlvbl9zdGF0ZShyZWdzKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBwYW5pYygiWGVuIEJVRyBhdCAl cyVzOiVkXG4iLCBwcmVmaXgsIGZpbGVuYW1lLCBsaW5lbm8pOwo+ID4gKwo+ID4gK8KgwqDCoCBj YXNlIEJVR0ZSQU1FX2Fzc2VydDoKPiA+ICvCoMKgwqDCoMKgwqDCoCAvKiBBU1NFUlQ6IGRlY29k ZSB0aGUgcHJlZGljYXRlIHN0cmluZyBwb2ludGVyLiAqLwo+ID4gK8KgwqDCoMKgwqDCoMKgIHBy ZWRpY2F0ZSA9IGJ1Z19tc2coYnVnKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBpZiAoICFpc19rZXJu ZWwocHJlZGljYXRlKSAmJiAhaXNfcGF0Y2gocHJlZGljYXRlKSApCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBwcmVkaWNhdGUgPSAiPHVua25vd24+IjsKPiA+ICsKPiA+ICvCoMKgwqDCoMKg wqDCoCBwcmludGsoIkFzc2VydGlvbiAnJXMnIGZhaWxlZCBhdCAlcyVzOiVkXG4iLAo+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJlZGljYXRlLCBwcmVmaXgsIGZpbGVuYW1lLCBs aW5lbm8pOwo+ID4gKwo+ID4gK8KgwqDCoMKgwqDCoMKgIGlmICggZGVidWdnZXJfdHJhcF9mYXRh bChUUkFQX2ludmFsaWRfb3AsIHJlZ3MpICkKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJl dHVybiBpZDsKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBzaG93X2V4ZWN1dGlvbl9zdGF0ZShy ZWdzKTsKPiA+ICvCoMKgwqDCoMKgwqDCoCBwYW5pYygiQXNzZXJ0aW9uICclcycgZmFpbGVkIGF0 ICVzJXM6JWRcbiIsCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJlZGljYXRlLCBw cmVmaXgsIGZpbGVuYW1lLCBsaW5lbm8pOwo+ID4gK8KgwqDCoCB9Cj4gPiArCj4gPiArwqDCoMKg IHJldHVybiBpZDsKPiA+ICt9Cj4gPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL2J1Zy5o IGIveGVuL2luY2x1ZGUveGVuL2J1Zy5oCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5k ZXggMDAwMDAwMDAwMC4uNGIxOGNmYTY5Ywo+ID4gLS0tIC9kZXYvbnVsbAo+ID4gKysrIGIveGVu L2luY2x1ZGUveGVuL2J1Zy5oCj4gPiBAQCAtMCwwICsxLDE1MCBAQAo+ID4gKyNpZm5kZWYgX19Y RU5fQlVHX0hfXwo+ID4gKyNkZWZpbmUgX19YRU5fQlVHX0hfXwo+ID4gKwo+ID4gKyNkZWZpbmUg QlVHX0RJU1BfV0lEVEjCoMKgwqAgMjQKPiA+ICsjZGVmaW5lIEJVR19MSU5FX0xPX1dJRFRIICgz MSAtIEJVR19ESVNQX1dJRFRIKQo+ID4gKyNkZWZpbmUgQlVHX0xJTkVfSElfV0lEVEggKDMxIC0g QlVHX0RJU1BfV0lEVEgpCj4gPiArCj4gPiArI2RlZmluZSBCVUdGUkFNRV9ydW5fZm4gMAo+ID4g KyNkZWZpbmUgQlVHRlJBTUVfd2FybsKgwqAgMQo+ID4gKyNkZWZpbmUgQlVHRlJBTUVfYnVnwqDC oMKgIDIKPiA+ICsjZGVmaW5lIEJVR0ZSQU1FX2Fzc2VydCAzCj4gPiArCj4gPiArI2RlZmluZSBC VUdGUkFNRV9OUsKgwqDCoMKgIDQKPiA+ICsKPiA+ICsjaW5jbHVkZSA8YXNtL2J1Zy5oPgo+ID4g Kwo+ID4gKyNpZm5kZWYgX19BU1NFTUJMWV9fCj4gPiArCj4gPiArI2luY2x1ZGUgPHhlbi9lcnJu by5oPgo+IAo+IGVycm5vLmggZG9lc24ndCBsb29rIHRvIGJlIHVzZWQgd2l0aGluIHRoaXMgaGVy ZS4gU28gaXMgaXQgbmVjZXNzYXJ5Cj4gdG8gCj4gaW1wb3J0IGl0Pwo+IAo+ID4gKyNpbmNsdWRl IDx4ZW4vbGliLmg+Cj4gCj4gV2h5IGlzIHRoaXMgbmVjZXNzYXJ5IHRvIGluY2x1ZGUgaW4gdGhl IGhlYWRlcj8KPiAKPiA+ICsjaW5jbHVkZSA8eGVuL3N0cmluZ2lmeS5oPgo+IAo+IFlvdSBkb24n dCBzZWVtIHRvIHVzZSBfX3N0cmluZ2lmeSBpbiB0aGlzIGhlYWRlci4gU28gaXMgdGhpcwo+IG5l Y2Vzc2FyeT8KVGhlIG1lbnRpb25lZCBoZWFkZXJzIHdpbGwgYmUgcmVtb3ZlZC4gVGhleSB3YXMg bmVlZGVkIHdoZW4gSSB0cmllZCB0bwp1c2UgQVJNIGltcGxlbWVudGF0aW9uIGFzIGdlbmVyaWMg b25lLgo+IAo+ID4gKwo+ID4gKyNpZm5kZWYgQlVHX0ZSQU1FX1NUUlVDVAo+ID4gKwo+ID4gK3N0 cnVjdCBidWdfZnJhbWUgewo+ID4gK8KgwqDCoCBzaWduZWQgaW50IGxvY19kaXNwOkJVR19ESVNQ X1dJRFRIOwo+ID4gK8KgwqDCoCB1bnNpZ25lZCBpbnQgbGluZV9oaTpCVUdfTElORV9ISV9XSURU SDsKPiA+ICvCoMKgwqAgc2lnbmVkIGludCBwdHJfZGlzcDpCVUdfRElTUF9XSURUSDsKPiA+ICvC oMKgwqAgdW5zaWduZWQgaW50IGxpbmVfbG86QlVHX0xJTkVfTE9fV0lEVEg7Cj4gPiArwqDCoMKg IHNpZ25lZCBpbnQgbXNnX2Rpc3BbXTsKPiA+ICt9Owo+ID4gKwo+ID4gKyNlbmRpZiAvKiBCVUdf RlJBTUVfU1RSVUNUICovCj4gPiArCj4gPiArI2lmbmRlZiBidWdfbG9jCj4gPiArI2RlZmluZSBi dWdfbG9jKGIpICgodW5zaWduZWQgbG9uZykoYikgKyAoYiktPmxvY19kaXNwKQo+ID4gKyNlbmRp Zgo+ID4gKwo+ID4gKyNpZm5kZWYgYnVnX3B0cgo+ID4gKyNkZWZpbmUgYnVnX3B0cihiKSAoKGNv bnN0IHZvaWQgKikoYikgKyAoYiktPnB0cl9kaXNwKQo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gKyNp Zm5kZWYgYnVnX2xpbmUKPiA+ICsjZGVmaW5lIGJ1Z19saW5lKGIpICgoKCgoYiktPmxpbmVfaGkg KyAoKGIpLT5sb2NfZGlzcCA8IDApKQo+ID4gJsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKCgx IDw8IEJVR19MSU5FX0hJX1dJRFRIKSAtIDEpKQo+ID4gPDzCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIEJVR19MSU5FX0xPX1dJRFRIKQo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoKGIpLT5saW5lX2xvICsgKChi KS0+cHRyX2Rpc3AgPCAwKSkKPiA+ICbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBc Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoMSA8PCBC VUdfTElORV9MT19XSURUSCkgLSAxKSkpCj4gPiArI2VuZGlmCj4gPiArCj4gPiArI2lmbmRlZiBi dWdfbXNnCj4gPiArI2RlZmluZSBidWdfbXNnKGIpICgoY29uc3QgY2hhciAqKShiKSArIChiKS0+ bXNnX2Rpc3BbMV0pCj4gPiArI2VuZGlmCj4gCj4gRm9yIGFsbCB0aGUgbWFjcm8gYWJvdmUsIGl0 IGZlZWxzIHdyb25nIHRvIG1lIHRvIGFsbG93IGFuCj4gYXJjaGl0ZWN0dXJlIAo+IHRvIG92ZXJy aWRlIHRoZW0gaWYgdGhlIGRlZmF1bHQgQlVHX0ZSQU1FX1NUUlVDVC4KPiAKPiBJdCB3b3VsZCBh bHNvIGZlZWxzIHdyb25nIHRvIG1lIHRoYXQgaWYgdGhlIGRlZmF1bHQgQlVHX0ZSQU1FX1NUUlVD VAo+IGlzIAo+IG5vdCB1c2VkIHRvIHN0aWxsIHBhcnRpYWxseSByZWx5IG9uIHRoZSBnZW5lcmlj IHZlcnNpb24gb2YgdGhlCj4gaGVscGVyLlwKPiAKPiBTbyBJIHdvdWxkIHN1Z2dlc3QgdG8gbW92 ZSB0aGVtIGluIHRoZSAjaWZuZGVmIEJVR19GUkFNRV9TVFJVQ1QgYW5kCj4gZHJvcCAKPiB0aGUg I2lmbmRlZiA8aGVscGVyPi4KQWdyZWUuIEknbGwgZG8gdGhhdCBpbiB0aGUgbmV4dCB2ZXJzaW9u IG9mIHRoZSBwYXRjaC4gVGhhbmtzLgo+IAo+ID4gKwo+ID4gKyNpZm5kZWYgQlVHX0FTTV9DT05T VAo+ID4gKyNkZWZpbmUgQlVHX0FTTV9DT05TVCAiIgo+ID4gKyNlbmRpZgo+IAo+IFRoaXMgbGlu ZSBpcyBhIGJpdCBtaXN0ZXJpb3VzIHRvIG1lLiBXb3VsZCB5b3UgYmUgYWJsZSB0byBvdXRsaW5l IHdoeQo+IGFuIAo+IGFyY2hpdGVjdHVyZSB3b3VsZCBvdmVycmlkZSB0aGlzPwpJdCBpcyBuZWVk ZWQgaW4gY2FzZSBpZiBjb21waWxlciBmb3IgYW4gYXJjaGl0ZWN0dXJlIGRvZXNuJ3QgaGF2ZQpw cm9wZXIgc3VwcG9ydCBvZiAnJWMnICggaXQgaXMgc28gZm9yIEFSTSAmIFJJU0MtViApCj4gCj4g PiArCj4gPiArI2lmICFkZWZpbmVkKF9BU01fQlVHRlJBTUVfVEVYVCkgfHwgIWRlZmluZWQoX0FT TV9CVUdGUkFNRV9JTkZPKQo+ID4gKwo+ID4gKyNkZWZpbmUKPiA+IF9BU01fQlVHRlJBTUVfVEVY VChzZWNvbmRfZnJhbWUpwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiAr wqDCoMKgCj4gPiAiLkxidWclPToiQlVHX0lOU1RSIlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgICLCoMKg IC5wdXNoc2VjdGlvbiAuYnVnX2ZyYW1lcy4lIkJVR19BU01fQ09OU1QiW2JmX3R5cGVdLCBcImFc IiwKPiA+ICUlcHJvZ2JpdHNcbiLCoMKgwqAgXAo+ID4gK8KgwqDCoCAiwqDCoCAucDJhbGlnbgo+ ID4gMlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAKPiA+IFwKPiA+ICvCoMKgwqAKPiA+ICIuTGZybSU9OlxuIsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCAiwqDCoCAubG9uZyAoLkxidWclPSAt IC5MZnJtJT0pICsKPiA+ICUiQlVHX0FTTV9DT05TVCJbYmZfbGluZV9oaV1cbiLCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgICLCoMKgIC5sb25nICglIkJVR19B U01fQ09OU1QiW2JmX3B0cl0gLSAuTGZybSU9KSArCj4gPiAlIkJVR19BU01fQ09OU1QiW2JmX2xp bmVfbG9dXG4iXAo+ID4gK8KgwqDCoCAiwqDCoCAuaWYgIiAjc2Vjb25kX2ZyYW1lCj4gPiAiXG4i wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKg wqAgIsKgwqAgLmxvbmcgMCwgJSJCVUdfQVNNX0NPTlNUIltiZl9tc2ddIC0KPiA+IC5MZnJtJT1c biLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ICvCoMKgwqAgIsKgwqAKPiA+IC5lbmRpZlxuIsKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiDCoMKgwqDCoMKgwqDC oMKgIFwKPiA+ICvCoMKgwqAgIsKgwqAgLnBvcHNlY3Rpb25cbiIKPiA+ICsKPiA+ICsjZGVmaW5l IF9BU01fQlVHRlJBTUVfSU5GTyh0eXBlLCBsaW5lLCBwdHIsCj4gPiBtc2cpwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDC oCBbYmZfdHlwZV3CoMKgwqAgImkiCj4gPiAodHlwZSkswqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgW2JmX3B0cl3CoMKgwqDCoCAiaSIKPiA+IChw dHIpLMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKg wqAgW2JmX21zZ13CoMKgwqDCoCAiaSIKPiA+IChtc2cpLMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgW2JmX2xpbmVfbG9dICJpIiAoKGxpbmUg JiAoKDEgPDwgQlVHX0xJTkVfTE9fV0lEVEgpIC0KPiA+IDEpKcKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIDw8Cj4gPiBCVUdfRElTUF9XSURUSCkswqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgIFti Zl9saW5lX2hpXSAiaSIgKCgobGluZSkgPj4gQlVHX0xJTkVfTE9fV0lEVEgpIDw8Cj4gPiBCVUdf RElTUF9XSURUSCkKPiA+ICsKPiA+ICsjZW5kaWYgLyogX0FTTV9CVUdGUkFNRV9URVhUIHx8IF9B U01fQlVHRlJBTUVfSU5GTyAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgQlVHX0ZSQU1FCj4gPiArCj4g PiArI2RlZmluZSBCVUdfRlJBTUUodHlwZSwgbGluZSwgcHRyLCBzZWNvbmRfZnJhbWUsIG1zZykg ZG8KPiA+IHvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDC oCBCVUlMRF9CVUdfT04oKGxpbmUpID4+IChCVUdfTElORV9MT19XSURUSCArCj4gPiBCVUdfTElO RV9ISV9XSURUSCkpO8KgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBCVUlMRF9CVUdfT04o KHR5cGUpID49Cj4gPiBCVUdGUkFNRV9OUik7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAg YXNtIHZvbGF0aWxlICgKPiA+IF9BU01fQlVHRlJBTUVfVEVYVChzZWNvbmRfZnJhbWUpwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA6OiBfQVNNX0JVR0ZSQU1FX0lORk8odHlw ZSwgbGluZSwgcHRyLCBtc2cpCj4gPiApO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK30g d2hpbGUgKDApCj4gPiArCj4gPiArI2VuZGlmCj4gPiArCj4gPiArI2lmbmRlZiBydW5faW5fZXhj ZXB0aW9uX2hhbmRsZXIKPiA+ICsKPiA+ICsvKgo+ID4gKyAqIFRPRE86IHVudGFuZ2xlIGhlYWRl ciBkZXBlbmRlbmNlcywgYnJlYWsgQlVJTERfQlVHX09OKCkgb3V0IG9mCj4gPiB4ZW4vbGliLmgs Cj4gPiArICogYW5kIHVzZSBhIHJlYWwgc3RhdGljIGlubGluZSBoZXJlIHRvIGdldCBwcm9wZXIg dHlwZSBjaGVja2luZwo+ID4gb2YgZm4oKS4KPiA+ICsgKi8KPiA+ICsjZGVmaW5lIHJ1bl9pbl9l eGNlcHRpb25faGFuZGxlcihmbinCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCBkbyB7wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoMKgwqDCoMKgICh2 b2lkKSgoZm4pID09ICh2b2lkICgqKShzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqKSlOVUxMKTsgXAo+ ID4gK8KgwqDCoMKgwqDCoMKgIEJVR19GUkFNRShCVUdGUkFNRV9ydW5fZm4sIDAsIGZuLCAwLCBO VUxMKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCB9IHdoaWxlICggMCAp Cj4gPiArCj4gPiArI2VuZGlmIC8qIHJ1bl9pbl9leGNlcHRpb25faGFuZGxlciAqLwo+ID4gKwo+ ID4gKyNpZm5kZWYgV0FSTgo+ID4gKyNkZWZpbmUgV0FSTigpIEJVR19GUkFNRShCVUdGUkFNRV93 YXJuLCBfX0xJTkVfXywgX19GSUxFX18sIDAsCj4gPiBOVUxMKQo+ID4gKyNlbmRpZgo+ID4gKwo+ ID4gKyNpZm5kZWYgQlVHCj4gPiArI2RlZmluZSBCVUcoKSBkbyB7wqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIFwKPiA+ICvCoMKgwqAgQlVHX0ZSQU1FKEJVR0ZSQU1FX2J1ZyzCoCBf X0xJTkVfXywgX19GSUxFX18sIDAsIE5VTEwpO8KgwqDCoMKgwqAgXAo+ID4gK8KgwqDCoCB1bnJl YWNoYWJsZSgpO8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArfSB3aGls ZSAoMCkKPiA+ICsjZW5kaWYKPiA+ICsKPiA+ICsjaWZuZGVmIGFzc2VydF9mYWlsZWQKPiA+ICsj ZGVmaW5lIGFzc2VydF9mYWlsZWQobXNnKSBkbyB7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4gPiArwqDCoMKgIEJVR19G UkFNRShCVUdGUkFNRV9hc3NlcnQsIF9fTElORV9fLCBfX0ZJTEVfXywgMSwgbXNnKTvCoMKgwqDC oCBcCj4gPiArwqDCoMKgIHVucmVhY2hhYmxlKCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIFwKPiA+ICt9IHdoaWxlICgwKQo+ID4gKyNlbmRpZgo+ID4gKwo+ID4gKyNpZmRlZiBD T05GSUdfR0VORVJJQ19CVUdfRlJBTUUKPiA+ICsKPiA+ICtzdHJ1Y3QgY3B1X3VzZXJfcmVnczsK PiA+ICsKPiA+ICtpbnQgZG9fYnVnX2ZyYW1lKGNvbnN0IHN0cnVjdCBjcHVfdXNlcl9yZWdzICpy ZWdzLCB1bnNpZ25lZCBsb25nCj4gPiBwYyk7Cj4gPiArCj4gPiArI2VuZGlmIC8qIENPTkZJR19H RU5FUklDX0JVR19GUkFNRSAqLwo+ID4gKwo+ID4gK2V4dGVybiBjb25zdCBzdHJ1Y3QgYnVnX2Zy YW1lIF9fc3RhcnRfYnVnX2ZyYW1lc1tdLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19zdG9wX2J1Z19mcmFtZXNfMFtdLAo+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgX19zdG9wX2J1Z19mcmFtZXNfMVtdLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19zdG9wX2J1Z19mcmFtZXNfMltd LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgX19zdG9wX2J1Z19mcmFtZXNfM1tdOwo+ID4gKwo+ID4gKyNlbmRpZiAvKiAhX19B U1NFTUJMWV9fICovCj4gPiArCj4gPiArI2VuZGlmIC8qIF9fWEVOX0JVR19IX18gKi8KPiA+ICsv Kgo+ID4gKyAqIExvY2FsIHZhcmlhYmxlczoKPiA+ICsgKiBtb2RlOiBDCj4gPiArICogYy1maWxl LXN0eWxlOiAiQlNEIgo+ID4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0Cj4gPiArICogaW5kZW50LXRh YnMtbW9kZTogbmlsCj4gPiArICogRW5kOgo+ID4gKyAqLwo+IAo+IENoZWVycywKPiAKfiBPbGVr c2lpCgo= From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:40:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503617.775928 (Exim 4.92) (envelope-from ) id 1pX3xO-0006hn-8R; Tue, 28 Feb 2023 17:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503617.775928; Tue, 28 Feb 2023 17:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xO-0006hf-3O; Tue, 28 Feb 2023 17:40:06 +0000 Received: by outflank-mailman (input) for mailman id 503617; Tue, 28 Feb 2023 17:40:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xN-0006WI-A2 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:40:05 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec0694bf-b78e-11ed-a550-8520e6686977; Tue, 28 Feb 2023 18:40:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec0694bf-b78e-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677606001; h=from:to:cc:subject:date:message-id:mime-version; bh=g4W4W/7oBB6pzfZ5TSnKR3UMeS8LA7gAF0KFTPw8wP0=; b=bK835yw6W4ueUsCBBTER/5PcyV5U04EXsYCjuxbd1wOhYDaKrR5cVSUe /OjTmllB6uaxKXJa+yLhGe/PgaX8ASQ/EcY1MhsUCEIxoTHXPm1+BiLGP szigVgvvSZcz9Y9+V6c1SDTVnlE4CySvxCqxNZMYkzg29NlkB9rZxFNze I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 101312542 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:fF1e36uPJCdC9QI5TEwoMPJw3ufnVJheMUV32f8akzHdYApBsoF/q tZmKWHXO/iLNmX3e9xxPtuwoEkPvpDRx4IyTgE5rSA9FXsR+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Fv0gnRkPaoQ5AWExyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBRMxPkGBruKP+42SU8Vtr8MofNLiM9ZK0p1g5Wmx4fcORJnCR+PB5MNC3Sd2jcdLdRrcT 5NHM3w1Nk2GOkARfA5NU/rSn8/x7pX7WyZVsl2YtOw78mHIyA1Z27nxKtvFPNeNQK25m27B/ judpj6kXkty2Nq3w2S/6kqnuM71ugzZcac2Jaa07PBQuQjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+8w5RyJy6HUyx2EHWVCRTlEAPQ5sOcmSDps0 UWG9/vrCiZoq6a9Um+G+/GfqjbaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx74j/luZSif/9pwqexWvx+N6QFFVdChjrsnyNwyBFNN+nToyR0mfy9NpBBYGSHkKIs y1R8ySB19wmAZaInS2LZewCGrC1+vqIWAHhbU5T84oJrGr0pSP6FWxEyHQnfRoybJ5YEdP8S BWL0T698qO/K5dDgUVfR4uqQ/onwqH7fTgOfqCFN4EeCnSdmeLuwc2PWaJy9zqw+KTPuftlU Xt+TSpLJSdyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXRMb1jtvLc/FSJo r6z0vdmLD0FDYXDjtT/q9ZPfTjm01BgbXwJlyCnXrHaeVc3cI3QI/TQ3akga+RYc1d9z4/1E oWGchYAkjLX3CSXQThmn1g/MNsDq74j9yNkVcHtVH70s0UejXGHt/9PJsZnLOJ8q4SOD5dcF pE4RilJOdwXIhyvxtjXRcOVQFBKHPhzuT+zAg== IronPort-HdrOrdr: A9a23:NGTD86FHnrBz6M0NpLqEFceALOsnbusQ8zAXPhZKOHhom62j+/ xG88536faZskdpZJhko6HnBEDiexzhHPxOkOws1OyZLWrbUQKTRelfBMnZowEIfReOlNK1+p 0QC5SWY+eAamSS4/yR3CCIV/48xdGc6qChgqP7x3dpCSVncbtp4Qs8KgvzKCNLbTgDLYc9HI CH5sJB4x6peXFSU9+yAWMMVfXCodqOtJ+OW3877k4cgzWzsQ== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="101312542" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v2 0/3] xen-ucode: print information about currently loaded ucode Date: Tue, 28 Feb 2023 17:39:29 +0000 Message-ID: <20230228173932.28510-1-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain I've split the patch into 3 parts. And now I'm using xenhypfs instead of introducing another platform op. That's my first attempt at xenhypfs and the patch itself is of RFC quality. Open questions are where to put the new code and if it's possible to come up with a better hypfs functions. Sergey Dyasli (3): xen/hypfs: add initial cpuinfo directory tools/xenctrl: add xc_get_cpu_version() tools/xen-ucode: print information about currently loaded ucode tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_misc.c | 20 ++++++++ tools/misc/Makefile | 2 +- tools/misc/xen-ucode.c | 97 +++++++++++++++++++++++++++++++++++++++ xen/arch/x86/cpu/common.c | 58 +++++++++++++++++++++++ 5 files changed, 177 insertions(+), 1 deletion(-) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:40:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503618.775938 (Exim 4.92) (envelope-from ) id 1pX3xQ-000764-Ea; Tue, 28 Feb 2023 17:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503618.775938; Tue, 28 Feb 2023 17:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xQ-00075v-B9; Tue, 28 Feb 2023 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 503618; Tue, 28 Feb 2023 17:40:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xP-0006sS-0Z for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:40:07 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef28cf96-b78e-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 18:40:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef28cf96-b78e-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677606005; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=kdC88fnrW3jwxtsuxpGeNQRlenhGudj0ts02zqy7nC0=; b=UIRFRGfdI5Bj1Qio7ep0z3zGvALT3C8U5fEaQdy26WAQnzhe0zUsyZxx D+v3LRoxyVw1nYxPTf6p6yFwe8fqGBqnQwju+OLR44eg4T9d2saUx/WOj EWtMohFvoKmvhfqNaDZMazxXLPWRKf7Dk8NjsCh0ofcTIPG+F616gnx3Y g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 97712737 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:aBlO+qOutWkswmPvrR1ql8FynXyQoLVcMsEvi/4bfWQNrUpw0zwDx zAbDGqEaKmINjf0ed90b9uzpkoCscTXxtZiTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tC5AxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0sVqX0NM1 fwCEgpOf0ujt9Oay7Krd8A506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLolkf2ni2i5fyxRs1aUjaE2/3LS3Ep6172F3N/9K4PVHJ8KxRnwS mTurnjgXhswZc6lxWTbqGCLivSWlATWYddHfFG/3qEz2wDCroAJMzUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Riy6GAkAUQzgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YXCA8raZqxuiNC5TKnUNDQcfVhcM6dTnpIA1jzrMQ8xlHarzicf6cQwc2 BjT8nJ43e9Ky5dWiePipwuvby+QSobhbRNrxAf3Xnif1EBoP66VVqCj6UjmxKMVRGqGdWWps H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDB0xWvvobwMFd 6M6Vel5wJZIdEWnYqZsC25aI5R7lPOwfTgJux29UzavXnSTXFXalM2NTRTKt4wIrKTLufBXB HtjWZzwZUv28Iw+pNZMe88T0KUw2gc1zn7JSJbwwnyPiOTBOyPPE+ZdbArSP4jVCZ9oRy2Pr r5i2zaikU0DAIUSnAGMmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mNscl3het/0NzI/gp yjtMnK0PXKj3RUr3y3WMCE8AF4uNL4jxU8G0dsEZg74iiVzMN30s8/ytfIfJNEayQCq9tYsJ 9FtRilKKq4npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:cVrne6ky+hi/320npnxreUI5IC3pDfIs3DAbv31ZSRFFG/Fxl6 iV88jztCWE7gr5N0tApTntAsS9qDbnhPxICOoqTNCftWvd2FdARbsKheCJ/9SjIVyaygc079 YFT0EUMrPN5DZB4foSmDPIcOod/A== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="97712737" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v2 3/3] tools/xen-ucode: print information about currently loaded ucode Date: Tue, 28 Feb 2023 17:39:32 +0000 Message-ID: <20230228173932.28510-4-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230228173932.28510-1-sergey.dyasli@citrix.com> References: <20230228173932.28510-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Add an option to xen-ucode tool to print the currently loaded ucode version and also print it during usage info. Print CPU signature and processor flags as well. The raw data comes from cpuinfo directory in xenhypfs and from XENPF_get_cpu_version platform op. Example output: Intel: Current CPU signature is: 06-55-04 (raw 0x50654) Current CPU microcode revision is: 0x2006e05 Current CPU processor flags are: 0x1 AMD: Current CPU signature is: fam19h (raw 0xa00f11) Current CPU microcode revision is: 0xa0011a8 Signed-off-by: Sergey Dyasli --- tools/misc/Makefile | 2 +- tools/misc/xen-ucode.c | 97 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 98 insertions(+), 1 deletion(-) diff --git a/tools/misc/Makefile b/tools/misc/Makefile index 1c6e1d6a04..e345ac76db 100644 --- a/tools/misc/Makefile +++ b/tools/misc/Makefile @@ -136,6 +136,6 @@ xencov: xencov.o $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS) xen-ucode: xen-ucode.o - $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(LDLIBS_libxenhypfs) $(APPEND_LDFLAGS) -include $(DEPS_INCLUDE) diff --git a/tools/misc/xen-ucode.c b/tools/misc/xen-ucode.c index ad32face2b..7e657689f4 100644 --- a/tools/misc/xen-ucode.c +++ b/tools/misc/xen-ucode.c @@ -11,6 +11,96 @@ #include #include #include +#include + +static const char intel_id[] = "GenuineIntel"; +static const char amd_id[] = "AuthenticAMD"; + +static const char sig_path[] = "/cpuinfo/cpu-signature"; +static const char rev_path[] = "/cpuinfo/microcode-revision"; +static const char pf_path[] = "/cpuinfo/processor-flags"; + +static int hypfs_read_uint(struct xenhypfs_handle *hdl, const char *path, + unsigned int *var) +{ + char *result; + result = xenhypfs_read(hdl, path); + if ( !result ) + return -1; + + errno = 0; + *var = strtol(result, NULL, 10); + if ( errno ) + return -1; + + return 0; +} + +static void show_curr_cpu(FILE *f) +{ + int ret; + struct xenhypfs_handle *hdl; + xc_interface *xch; + struct xenpf_pcpu_version cpu_ver = {0}; + bool intel = false, amd = false; + unsigned int cpu_signature, pf, ucode_revision; + + hdl = xenhypfs_open(NULL, 0); + if ( !hdl ) + return; + + xch = xc_interface_open(0, 0, 0); + if ( xch == NULL ) + return; + + ret = xc_get_cpu_version(xch, &cpu_ver); + if ( ret ) + return; + + if ( memcmp(cpu_ver.vendor_id, intel_id, + sizeof(cpu_ver.vendor_id)) == 0 ) + intel = true; + else if ( memcmp(cpu_ver.vendor_id, amd_id, + sizeof(cpu_ver.vendor_id)) == 0 ) + amd = true; + + if ( hypfs_read_uint(hdl, sig_path, &cpu_signature) != 0 ) + return; + + if ( hypfs_read_uint(hdl, rev_path, &ucode_revision) != 0 ) + return; + + if ( intel && hypfs_read_uint(hdl, pf_path, &pf) != 0 ) + return; + + /* + * Print signature in a form that allows to quickly identify which ucode + * blob to load, e.g.: + * + * Intel: /lib/firmware/intel-ucode/06-55-04 + * AMD: /lib/firmware/amd-ucode/microcode_amd_fam19h.bin + */ + if ( intel ) + { + fprintf(f, "Current CPU signature is: %02x-%02x-%02x (raw %#x)\n", + cpu_ver.family, cpu_ver.model, cpu_ver.stepping, + cpu_signature); + } + else if ( amd ) + { + fprintf(f, "Current CPU signature is: fam%xh (raw %#x)\n", + cpu_ver.family, cpu_signature); + } + + if ( intel || amd ) + fprintf(f, "Current CPU microcode revision is: %#x\n", ucode_revision); + + if ( intel ) + fprintf(f, "Current CPU processor flags are: %#x\n", pf); + + xc_interface_close(xch); + xenhypfs_close(hdl); +} int main(int argc, char *argv[]) { @@ -25,9 +115,16 @@ int main(int argc, char *argv[]) fprintf(stderr, "xen-ucode: Xen microcode updating tool\n" "Usage: %s \n", argv[0]); + show_curr_cpu(stderr); exit(2); } + if ( !strcmp(argv[1], "show-cpu-info") ) + { + show_curr_cpu(stdout); + return 0; + } + filename = argv[1]; fd = open(filename, O_RDONLY); if ( fd < 0 ) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:40:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503620.775952 (Exim 4.92) (envelope-from ) id 1pX3xR-0007I3-7z; Tue, 28 Feb 2023 17:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503620.775952; Tue, 28 Feb 2023 17:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xQ-0007HM-V1; Tue, 28 Feb 2023 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 503620; Tue, 28 Feb 2023 17:40:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xP-0006sS-HB for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:40:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efab59e6-b78e-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 18:40:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efab59e6-b78e-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677606006; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=U9Ac8kfawVwJyTiVqm0kbmJdZ36EQ83/TJ8nOn83CLs=; b=ZyNxqXQE7XpitWStBxkVZKonIsFUdM37MDIlrdvN2SBFWluioPjaLbbD mMLBEQvc2f1z7b1kTeeWunC3Fl1SPen+6a+XX31JDTh5tKK8xqdwhzl+/ OSLqPLps8GjhQAhsYrwS8JIwAoB18fF/ZIPLhsrgClKJOADd3k1cYJWsR Y=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 101312544 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:/ZIn368CLMgzU7CS/cvyDrUDTn6TJUtcMsCJ2f8bNWPcYEJGY0x3y jFLXDrUMqrZMzCnftxxad61pBlVvpGGy4JlHgc9/iE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI/1BjOkGlA5AdmP6ob5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklj1 sBIeTIkbim4uMuv7LOSTeI8nc0seZyD0IM34hmMzBncBPciB5vCX7/L9ZlT2zJYasJmRKiEI ZBDMHw2MUqGOkcUUrsUIMtWcOOAnXTlfDBJ7l6ErLEz4kDYzRBr0airO93QEjCPbZwNxx3B/ D+aowwVBDkYOd6+1WOr0UiWh/DCvBHwSbgKNpy3o6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZiFFQMwrsokxXzNC/ l2GhdTyHhR0raaYD3ma89+8ry62OCUTBX8PY2kDVwRty8L4vIg5gxbLT9BiOK24lNv4HXf32 T/ikcQlr+xN14hRjfz9pA2ZxWv2/fAlUzLZ+C36fV71vwFQZLeeWKWxxVny6v0QN4+WGwzpU Gc/p+CS6+UHDJeonSOLQfkQELzB28tpIAEwknY0QcB/qm3FF2qLONkJvWogfBsB3tMsI2eBX aPFhe9GCHa/1lOOZLQ/XY++At9CIUPIRYW8DaC8gjajj/FMmO67EMNGPxP4M4PFyhJEfUQD1 XCzIK6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+habQHUP7hlvf/VyOkwz zq4H5HXoyizrcWkOnWHmWLtBQtiwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ895m5Ytzgp ynnMmcBkQqXuJEyAVnSApyVQO+1DMkXQLNSFXBEAGtELFB4Odb+sfdOLMBoFVTlncQ6pcNJo zA+U53oKpxypv7volzxsbGVQFReSSmW IronPort-HdrOrdr: A9a23:U9KYOqvnPFYs4oODgEjJyNm+7skDi9V00zEX/kB9WHVpm5qj5q STdZUguSMc5wx9ZJhNo6H4BEDEewK7yXcX2+Ys1NWZLWzbUTCTXeJfBOLZqlXd8m/FltK1s5 0QEZSWJ+eAdWSS5vyKhzVQfexL/PC3tIi0gO/F1XdkSkVPY6FkqyN0EBySHEEzZAQuP/QEPa vZztdDryC7eXwRKuCyBnxAYvPKoMfCno/nZxlDJxNP0mizZGOTg4LHLw== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="101312544" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v2 2/3] tools/xenctrl: add xc_get_cpu_version() Date: Tue, 28 Feb 2023 17:39:31 +0000 Message-ID: <20230228173932.28510-3-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230228173932.28510-1-sergey.dyasli@citrix.com> References: <20230228173932.28510-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain As a wrapper for XENPF_get_cpu_version platform op. Signed-off-by: Sergey Dyasli --- tools/include/xenctrl.h | 1 + tools/libs/ctrl/xc_misc.c | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 23037874d3..8aa747dc2e 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1186,6 +1186,7 @@ int xc_physinfo(xc_interface *xch, xc_physinfo_t *info); int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo); int xc_microcode_update(xc_interface *xch, const void *buf, size_t len); +int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver); int xc_numainfo(xc_interface *xch, unsigned *max_nodes, xc_meminfo_t *meminfo, uint32_t *distance); int xc_pcitopoinfo(xc_interface *xch, unsigned num_devs, diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c index 265f15ec2d..f2f6e4348e 100644 --- a/tools/libs/ctrl/xc_misc.c +++ b/tools/libs/ctrl/xc_misc.c @@ -226,6 +226,26 @@ int xc_microcode_update(xc_interface *xch, const void *buf, size_t len) return ret; } +int xc_get_cpu_version(xc_interface *xch, struct xenpf_pcpu_version *cpu_ver) +{ + int ret; + DECLARE_PLATFORM_OP; + + if ( !xch || !cpu_ver ) + return -1; + + platform_op.cmd = XENPF_get_cpu_version; + platform_op.u.pcpu_version.xen_cpuid = cpu_ver->xen_cpuid; + + ret = do_platform_op(xch, &platform_op); + if ( ret != 0 ) + return ret; + + *cpu_ver = platform_op.u.pcpu_version; + + return 0; +} + int xc_cputopoinfo(xc_interface *xch, unsigned *max_cpus, xc_cputopo_t *cputopo) { -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:40:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503619.775943 (Exim 4.92) (envelope-from ) id 1pX3xQ-00079U-OY; Tue, 28 Feb 2023 17:40:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503619.775943; Tue, 28 Feb 2023 17:40:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xQ-00077z-JF; Tue, 28 Feb 2023 17:40:08 +0000 Received: by outflank-mailman (input) for mailman id 503619; Tue, 28 Feb 2023 17:40:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX3xO-0006WI-UU for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:40:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef57482e-b78e-11ed-a550-8520e6686977; Tue, 28 Feb 2023 18:40:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef57482e-b78e-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677606004; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=K+j4WJCkOxdn46mcun2tYyo0EwVo6CxR547z8EwP1Wk=; b=hn6936WubqsBfq8vtIBgAzKnMEEeh2lgvfdh5f80AB04KF9/BJxkFnDu O0MZBNcsZxNGFPMXji4GubKjDpiGwEwP26eUtdU1Z2U5ltaVggqa5jmC7 bOwQtima2Ap/2h+VCe2vCcNauQ2kayOE/Y0MClamKVYzYLbP0hepRhqvk s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 101312543 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:lP4rBKC5e5R+VhVW/+fjw5YqxClBgxIJ4kV8jS/XYbTApDklgjEOm GIeXWnQOf2LM2XyetAjYYzg/RkF6MfSz95hQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFu8pvlDs15K6p4GlC7gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw18VLUTBM3 PwhEw8kdzyCruW9kKmyRbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIIkzhuillz/zYjRDrFO9rqsr+WnDigd21dABNfKMIoXRHJ8Iwh3wS mTuwkHpJS0UCu6m2DvC1l2xrMqfxTrdR9dHfFG/3qEz2wDCroAJMzUUWkG8uuKRkVOlVpRUL El80igzqak/8mS7Q9+7WAe3yFafpQIVUddUF+w86SmOx7DS7gLfAXILJhZDYtE7sM49RRQxy 0SE2djuAFRHoLCTDH6Q6LqQhTezIjQOa38PYzceSgkI6MWlp5s85jrQSv5zHajzicf6cQwc2 BjT8nJ43e9Ky5dWiePipwuvby+QSobhYy0JtlTVd2Kc1TxQfaKkToujuUPS4qMVRGqGdWWps H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDB0xWvvobwMFd 6M6Vel5wJZIdEWnYqZsC25aI5R7lPOwfTgJux29UzavXnSTXFXalM2NTRTKt4wIrKTLufBXB HtjWZzwZUv28Iw+pNZMe88T0KUw2gc1zn7JSJbwwnyPiOTBOyPPE+ZdbArSP4jVCZ9oRy2Pr r5i2zaikU0DAIUSnAGMmWLsEbz6BSdiXs2nwyCmXuWCPhBnCAkc5wz5mNscl3het/0NzI/gp yjtMnK0PXKj3RUr3y3WMCE8AF4uNL4jxU8G0dsEZg74iiVzMN30s8/ytfIfJNEayQCq9tYsJ 9FtRilKKq4npujvk9jFUaTAkQ== IronPort-HdrOrdr: A9a23:M7EdZqvktGcXvi5gaOrui5S+7skDi9V00zEX/kB9WHVpm5qj5q STdZUguSMc5wx9ZJhNo6H4BEDEewK7yXcX2+Ys1NWZLWzbUTCTXeJfBOLZqlXd8m/FltK1s5 0QEZSWJ+eAdWSS5vyKhzVQfexL/PC3tIi0gO/F1XdkSkVPY6FkqyN0EBySHEEzZAQuP/QEPa vZztdDryC7eXwRKuCyBnxAYvPKoMfCno/nZxlDJxNP0mizZGOTg4LHLw== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="101312543" From: Sergey Dyasli To: CC: Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Sergey Dyasli Subject: [PATCH v2/RFC 1/3] xen/hypfs: add initial cpuinfo directory Date: Tue, 28 Feb 2023 17:39:30 +0000 Message-ID: <20230228173932.28510-2-sergey.dyasli@citrix.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230228173932.28510-1-sergey.dyasli@citrix.com> References: <20230228173932.28510-1-sergey.dyasli@citrix.com> MIME-Version: 1.0 Content-Type: text/plain Currently it's impossible to get CPU's microcode revision after late loading without looking into Xen logs which is not always convenient. Leverage xenhypfs to expose struct cpu_signature in a new cpuinfo dir. The tree structure is: / cpuinfo/ cpu-signature microcode-revision processor-flags The most useful bit is cpu microcode revision which will get updated after late ucode loading. Signed-off-by: Sergey Dyasli --- xen/arch/x86/cpu/common.c | 58 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 5ad347534a..aa864fdbab 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -1005,3 +1005,61 @@ const struct x86_cpu_id *x86_match_cpu(const struct x86_cpu_id table[]) } return NULL; } + +#ifdef CONFIG_HYPFS +#include +#include +#include + +static unsigned int cpu_signature; +static unsigned int processor_flags; +static unsigned int ucode_revision; + +int cf_check hypfs_read_cpusig( + const struct hypfs_entry *entry, XEN_GUEST_HANDLE_PARAM(void) uaddr) +{ + const struct hypfs_entry_leaf *l; + unsigned int size = entry->funcs->getsize(entry); + const struct cpu_signature *sig = &per_cpu(cpu_sig, + cpumask_first(&cpu_online_map)); + + l = container_of(entry, const struct hypfs_entry_leaf, e); + + cpu_signature = sig->sig; + processor_flags = sig->pf; + ucode_revision = sig->rev; + + return copy_to_guest(uaddr, l->u.content, size) ? -EFAULT : 0; +} + +const struct hypfs_funcs ucode_rev_funcs = { + .enter = hypfs_node_enter, + .exit = hypfs_node_exit, + .read = hypfs_read_cpusig, + .write = hypfs_write_deny, + .getsize = hypfs_getsize, + .findentry = hypfs_leaf_findentry, +}; + +static HYPFS_DIR_INIT(cpuinfo, "cpuinfo"); +static HYPFS_FIXEDSIZE_INIT(signature, XEN_HYPFS_TYPE_UINT, "cpu-signature", + cpu_signature, &ucode_rev_funcs, 0); +static HYPFS_FIXEDSIZE_INIT(pf, XEN_HYPFS_TYPE_UINT, "processor-flags", + processor_flags, &ucode_rev_funcs, 0); +static HYPFS_FIXEDSIZE_INIT(revision, XEN_HYPFS_TYPE_UINT, "microcode-revision", + ucode_revision, &ucode_rev_funcs, 0); + +static int __init cf_check cpuinfo_init(void) +{ + hypfs_add_dir(&hypfs_root, &cpuinfo, true); + hypfs_add_leaf(&cpuinfo, &signature, true); + + if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) + hypfs_add_leaf(&cpuinfo, &pf, true); + + hypfs_add_leaf(&cpuinfo, &revision, true); + + return 0; +} +__initcall(cpuinfo_init); +#endif /* CONFIG_HYPFS */ -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:49:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:49:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503642.775968 (Exim 4.92) (envelope-from ) id 1pX462-000180-Uh; Tue, 28 Feb 2023 17:49:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503642.775968; Tue, 28 Feb 2023 17:49:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX462-00017t-Qz; Tue, 28 Feb 2023 17:49:02 +0000 Received: by outflank-mailman (input) for mailman id 503642; Tue, 28 Feb 2023 17:49:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX460-00017j-QJ for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:49:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX460-0008DV-1U; Tue, 28 Feb 2023 17:49:00 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[192.168.12.216]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pX45z-0005WB-PJ; Tue, 28 Feb 2023 17:48:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=D0aPMIK7eB1gZTgJIWG/ri37Z8vUj9fxtEepC5SrDpM=; b=YupIBKniiEveDAG95KIuItm9rL 64b8SXeWSJDwDxXDhGAfDXPPg09W2xwo5uIXm5bkU5zJQL6fvJRE4BWiEwRpJmhDLbnyJHbZJksTW 6XTN5Qpa59UC8CU3FfiTBC3OGju16l6jgiM7DVpeOiujfXeoBu53PbndIF4E4d6C4at8=; Message-ID: <46e96dd9-bcb4-4569-b282-05c019cabcc3@xen.org> Date: Tue, 28 Feb 2023 17:48:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksii, On 28/02/2023 15:09, Oleksii wrote: > On Sat, 2023-02-25 at 16:49 +0000, Julien Grall wrote: >> Hi Oleksii, >> >> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>> The following changes were made: >>> * make GENERIC_BUG_FRAME mandatory for ARM >> >> I have asked in patch #1 but will ask it again because I think this >> should be recorded in the commit message. Can you outline why it is >> not >> possible to completely switch to the generic version? > I haven't tried to switch ARM too because of comment regarding 'i' in > : > /* > * GCC will not allow to use "i" when PIE is enabled (Xen doesn't set > the > * flag but instead rely on the default value from the compiler). So > the > * easiest way to implement run_in_exception_handler() is to pass the > to > * be called function in a fixed register. > */ I would expect this comment to be valid for any arch. So if there is a need to deal with PIE, then we would not be able to use "i" in the BUG frame. Note that we are now explicitly compiling Xen without PIE (see Config.mk). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 28 17:57:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 17:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503648.775978 (Exim 4.92) (envelope-from ) id 1pX4E0-0002xM-St; Tue, 28 Feb 2023 17:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503648.775978; Tue, 28 Feb 2023 17:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4E0-0002xF-QA; Tue, 28 Feb 2023 17:57:16 +0000 Received: by outflank-mailman (input) for mailman id 503648; Tue, 28 Feb 2023 17:57:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4Dz-0002x7-4v for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 17:57:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4Dy-0008N3-He; Tue, 28 Feb 2023 17:57:14 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[192.168.12.216]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pX4Dy-0005vG-BX; Tue, 28 Feb 2023 17:57:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=L3qVFr6CW0g5/aVBc47poeXu26DZd+3MnbF1a8CnmAk=; b=u5+439rjsKeU0iXaawFebrmXSs Z7SrAjLtNli9vNR7kggSUURIcSmT6OVQko9bdunMlqtzZ2XD904DDkX2EaCczl66ISeA10POSRi12 cSgWnHz+5+bLMRIxjOPREB8HnXKs7pUeO5Bp9KVIxcGUuH+BpfD3ksL0gamdIatU7yy4=; Message-ID: <75df5a86-5d64-d219-c25c-644748a88302@xen.org> Date: Tue, 28 Feb 2023 17:57:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , Bertrand Marquis , Volodymyr Babchuk References: <6735859208c6dcb7320f89664ae298005f70827b.camel@gmail.com> From: Julien Grall In-Reply-To: <6735859208c6dcb7320f89664ae298005f70827b.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/02/2023 17:21, Oleksii wrote: > Hi Julien, Hi Oleksii, > On Sat, 2023-02-25 at 17:05 +0000, Julien Grall wrote: >> >> >> On 25/02/2023 16:49, Julien Grall wrote: >>> Hi Oleksii, >>> >>> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>>> The following changes were made: >>>> * make GENERIC_BUG_FRAME mandatory for ARM >>> >>> I have asked in patch #1 but will ask it again because I think this >>> should be recorded in the commit message. Can you outline why it is >>> not >>> possible to completely switch to the generic version? >> >> I have just tried to remove it on arm64 and it seems to work. This >> was >> only tested with GCC 10 though. But given the generic version is not >> not >> using the %c modifier, then I wouldn't expect any issue. >> >> Cheers, >> > > I tried to switch ARM to generic implementation. > > Here is the patch: [1] This is similar to the patch I wrote to test with generic implementation on Arm (see my other reply). [...] > (it will be merged with patch 3 if it is OK ) > > And looks like we can switch ARM to generic implementation as all tests > passed: > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/791549396 Thanks for checking with the gitlab CI! > > The only issue is with yocto-arm: > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/791549396/failures > But I am not sure that it is because of my patch This looks unrelated to me. This is happening because there is a data abort before PSCI (used to reboot the platform) is properly setup. I think we should consider to only print once the error rather than every few iterations (not a request for you). That said, I am a bit puzzled why this issue is only happening in the Yocto test (the Debian one pass). Do you know if the test is passing in the normal CI? If yes, what other modifications did you do? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 28 18:01:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 18:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503654.775988 (Exim 4.92) (envelope-from ) id 1pX4Hq-0004nn-Ct; Tue, 28 Feb 2023 18:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503654.775988; Tue, 28 Feb 2023 18:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4Hq-0004ng-A9; Tue, 28 Feb 2023 18:01:14 +0000 Received: by outflank-mailman (input) for mailman id 503654; Tue, 28 Feb 2023 18:01:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4Ho-0004nY-M1 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 18:01:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4Hn-00006T-P6; Tue, 28 Feb 2023 18:01:11 +0000 Received: from 54-240-197-227.amazon.com ([54.240.197.227] helo=[192.168.12.216]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pX4Hn-0006B3-IZ; Tue, 28 Feb 2023 18:01:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=3UgDBcuYZzBJsRE5VwJpCU+X0WiKQph0t+dGM52vbbk=; b=pwqV0+KFzbrTCloKPnayJdqm7Q MtsiBb4ZPTWkdpjRypuVPtwhXWHoeg2PLQbH1I5hfyFOADQfNZK/P9HTQc6jLot+CZv7T6JRVRTxX ZFcfpmfQSbloq7sbthN5XhMFhywQpVzFoV2V++lNMp6FIspPvNy8wRejFLe6kcexWw/0=; Message-ID: Date: Tue, 28 Feb 2023 18:01:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME Content-Language: en-US To: Oleksii , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Wei Liu References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/02/2023 17:21, Oleksii wrote: > Hi Julien, Hi Oleksii, >>> + >>> +            for ( i = 0, b = region->frame[id].bugs; >>> +                  i < region->frame[id].n_bugs; b++, i++ ) >>> +            { >>> +                if ( bug_loc(b) == pc ) >>> +                { >>> +                    bug = b; >>> +                    goto found; >>> +                } >>> +            } >>> +        } >>> +    } >>> + >>> + found: >>> +    if ( !bug ) >>> +        return -EINVAL; >>> + >>> +    if ( id == BUGFRAME_run_fn ) >>> +    { >>> +#ifdef BUG_FN_REG >>> +        void (*fn)(const struct cpu_user_regs *) = (void *)regs- >>>> BUG_FN_REG; >> >> AFAIU, this is necessary so Arm can use the generic do_bug_frame(). >> >> I was under the impression that RISC-V and Arm had the similar issue >> with %c. It seems like you managed to resolve it on RISC-V, so can we >> fully switch Arm to the generic implementation of bug? > I tried to switch ARM to generic implementation. > > Here is the patch: [1] I have replied on the other thread. >>> +#ifndef BUG_ASM_CONST >>> +#define BUG_ASM_CONST "" >>> +#endif >> >> This line is a bit misterious to me. Would you be able to outline why >> an >> architecture would override this? > It is needed in case if compiler for an architecture doesn't have > proper support of '%c' ( it is so for ARM & RISC-V ) Hmmm.... Why can't x86 use the same version? IOW what's the benefits to differ on x86? Anyway, documentation is always good to have because it helps the reader/reviewer to understand how such decision was made. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Feb 28 18:17:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 18:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503659.775998 (Exim 4.92) (envelope-from ) id 1pX4XA-0006ht-MT; Tue, 28 Feb 2023 18:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503659.775998; Tue, 28 Feb 2023 18:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4XA-0006hm-JL; Tue, 28 Feb 2023 18:17:04 +0000 Received: by outflank-mailman (input) for mailman id 503659; Tue, 28 Feb 2023 18:17:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4X8-0006hf-V6 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 18:17:02 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17bbda0f-b794-11ed-9695-2f268f93b82a; Tue, 28 Feb 2023 19:17:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17bbda0f-b794-11ed-9695-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677608220; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=b8T+i+8za8gCu8VFptAzjxjhvNwzD5zK8ipbmxYf9AI=; b=X7/bSHQ4oR5yN3Z9qaUxeWhac2by67g7uLstuFT8XdaDpRBLskWLIDYr pAKFATdaSMyqQxg3Y8lE0pjooGSxFLjPtasv36/bBBeenj5ikKk4LB52m AZKWQD8m83SJMfaU8I5xuRX6z5sbQl24zJV+4Ge1YBWrHFGJQ0pqwBGBS 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 101318358 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:mpUoNqieuEPIgBe5ZBLB2yRfX161ehAKZh0ujC45NGQN5FlHY01je htvUDuAa63fYDH2edgjao+w9EIB7J+Dn4BhTFdvrX8zHnwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWi0N8klgZmP6sT5gWOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ6MTIBYjbfl9uz/7mUFqoy28ACd+jSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ judpjSiX0Fy2Nq39h+5rGKhtMr2myrdWbkDReeB3OdUnwjGroAUIEJPDgbqyRWjsWauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+Yz8g2Kx4Lf6hyVAWVCRTlEAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnop4thvrZ3JTdzVbI3ZZE01cuYKLTJwPYgznbM9hHKKT0s3MHA777 GzJ8nU6pu4ytJtev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWO0e+yzMUJVJdPUUOQS9PZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9gZ srBK5f0USdGWMyLKQZaoM9HjNcWKt0WnzuPFfgXMTz8uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivBnFSnCPq+Y7dAlaRUXX8Liq86S7gMbfeFs5cIzgYteNqY4cl3tNxPwFx7qYr yrmBSe1CjPX3BX6FOlDUVg7AJuHYHq1hStT0fAEVbpw50UeXA== IronPort-HdrOrdr: A9a23:LQfVm6H90vmgXN1fpLqEGceALOsnbusQ8zAXPhZKOHpom62j5q KTdZEgvnXJYVkqKQkdcK+7SdK9qB/nmKKdpLNwAV7AZniChILLFuBfBOLZqlXd8m/Fh41gPM FbH5SWY+efMbEVt6nHCQCDYqwd6ejCyqWhj+Wb43BxQRpycKF740NYJ2+gYylLbTgDP58wHp jZwsZcvTKvdTA2Q62AdwA4dtmGndjCnpCjXBIPA1oGxWC1/FSV1II= X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="101318358" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH] automation: Rework archlinux container Date: Tue, 28 Feb 2023 18:16:49 +0000 Message-ID: <20230228181649.51066-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Base image "archlinux/base" isn't available anymore, https://lists.archlinux.org/pipermail/arch-dev-public/2020-November/030181.html But instead of switching to archlinux/archlinux, we will use the official image from Docker. Main difference is that the first one is updated daily while the second is updated weekly. Also, as we will install the packages from "base-devel" anyway, switch to the "base-devel" tag. "dev86" package is now available from the main repo, no need for multilib repo anymore. It is recommended to initialise local signing key used by pacman, so let's do that. Replace "markdown" by "discount" as the former isn't available anymore and has been replaced by the later. Also, clean pacman's cache. Signed-off-by: Anthony PERARD --- Notes: Testing done here: https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/791402512 automation/build/archlinux/current.dockerfile | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/automation/build/archlinux/current.dockerfile b/automation/build/archlinux/current.dockerfile index d46fc9d9ca..13fb472d9e 100644 --- a/automation/build/archlinux/current.dockerfile +++ b/automation/build/archlinux/current.dockerfile @@ -1,16 +1,15 @@ -FROM archlinux/base +FROM archlinux:base-devel LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" -# Enable multilib repo, for dev86 package -RUN echo $'[multilib]\nInclude = /etc/pacman.d/mirrorlist' >> /etc/pacman.conf +RUN pacman-key --init RUN pacman -S --refresh --sysupgrade --noconfirm --noprogressbar --needed \ - base-devel \ bin86 \ bridge-utils \ bzip2 \ dev86 \ + discount \ dtc \ e2fsprogs \ ghostscript \ @@ -29,7 +28,6 @@ RUN pacman -S --refresh --sysupgrade --noconfirm --noprogressbar --needed \ libnl \ libpng \ libseccomp \ - markdown \ net-tools \ nss \ perl \ @@ -46,7 +44,8 @@ RUN pacman -S --refresh --sysupgrade --noconfirm --noprogressbar --needed \ wget \ xz \ yajl \ - zlib + zlib \ + && yes | pacman -S --clean --clean ENV PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Feb 28 18:23:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 18:23:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503668.776008 (Exim 4.92) (envelope-from ) id 1pX4cm-0008Tt-Ba; Tue, 28 Feb 2023 18:22:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503668.776008; Tue, 28 Feb 2023 18:22:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4cm-0008Tm-8X; Tue, 28 Feb 2023 18:22:52 +0000 Received: by outflank-mailman (input) for mailman id 503668; Tue, 28 Feb 2023 18:22:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4ck-0008Tg-Vi for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 18:22:50 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e614bcd4-b794-11ed-a550-8520e6686977; Tue, 28 Feb 2023 19:22:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e614bcd4-b794-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677608568; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jxy6VqGGgAbo5pReyA89z5N5RetTLCK9bUegkJqrGKc=; b=c17hCiQ4DM4SrkHj8rGQshcE40s4/YA5uV0Z2e4U4f6ITY3+XUGdwbfs gFDAxSwbtMqpaF0Sj9oCgmS6qBNMM8t/JysE3TpLiUGBw4UEXqx8apQ6U yUzjVa/E9ggwp3vXAe4KCz44319847kfb/VBFj+iRQ/qzNl6R0dYP7m/C Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 101319307 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:Qv32vqOsOpuVcaHvrR2Al8FynXyQoLVcMsEvi/4bfWQNrUp00GQHx 2sXWmnSOK2JYGT1fYtzO43k805Su5LXmoVlTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvLrRC9H5qyo42tC5AxmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0udHLT53z 8YcERxOVEu+3s3twYm+F/Y506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w2Nk+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUoXSHJ4Mzx3A+ Qoq+UzTBhAmD8eewAGp9yqumtbQsCn4A787QejQGvlC3wTImz175ActfUu2p7y1h1CzX/pbK lcI4Ww+oK4q7kupQ9LhGRqirxastRcGV91dO+Yz8g2Kx+zf5APxLnMfUjdLZdgitck3bT8nz FmEm5XuHzMHjVGOYSvDrPHO92r0YHVLazZYPkfoUDfp/fHikK1styj1Su9PU5Tus4TaQjDLx m2V+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKVBaJtsldzBO hW7VeZtCHh7bROXgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT+yzRJ2wPlja MvKGSpJMZr9If46pAdaus9HieN7rszA7Ti7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ5oUy2Mm +uzw/Cikk0FOMWnO3m/zGLmBQxSRZTNLcys+pM/my/qClYOJVzN/NeKmeNwJtw0xP8K/goKl 1nkMnJlJJPErSWvAW23hrpLMu6HsUpXxZ7jARERAA== IronPort-HdrOrdr: A9a23:+LgFGK4L+eo1pMEbiQPXwN3XdLJyesId70hD6qkXc203TiX4ra CTdZEgviMc5wx+ZJhRo7q90cW7LE80jKQFg7X5Xo3CYOCFghrMEGgK1+KL/9SKIULDH4BmuZ tdTw== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="101319307" From: Anthony PERARD To: CC: Andrew Cooper , Anthony PERARD , Doug Goldstein , "Stefano Stabellini" Subject: [XEN PATCH] automation: Always pull base image when building a container Date: Tue, 28 Feb 2023 18:22:26 +0000 Message-ID: <20230228182226.52201-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Ask docker to check if there's an update of the base image to avoid using an old container cached locally. Signed-off-by: Anthony PERARD --- automation/build/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/build/Makefile b/automation/build/Makefile index f1d56ce532..4df43b0407 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -16,7 +16,7 @@ help: include yocto/yocto.inc %: %.dockerfile ## Builds containers - $(DOCKER_CMD) build -t $(REGISTRY)/$(@D):$(@F) -f $< $( Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 18:26:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503672.776018 (Exim 4.92) (envelope-from ) id 1pX4fn-0000eu-Qr; Tue, 28 Feb 2023 18:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503672.776018; Tue, 28 Feb 2023 18:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4fn-0000en-Mn; Tue, 28 Feb 2023 18:25:59 +0000 Received: by outflank-mailman (input) for mailman id 503672; Tue, 28 Feb 2023 18:25:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX4fm-0000eh-Bh for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 18:25:58 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55d7012e-b795-11ed-a550-8520e6686977; Tue, 28 Feb 2023 19:25:55 +0100 (CET) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Feb 2023 13:25:52 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW5PR03MB7006.namprd03.prod.outlook.com (2603:10b6:303:1a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 18:25:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 18:25:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55d7012e-b795-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677608755; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=JRmP5cQzkhMr0IvDE09UaF4/GHUkfM+n1ExHHJe/zq8=; b=XXa7nFziy8vq0ATkslbPHBaluXAIvbOkbZOy+kGKoWQh2WB3ejDi0poA BvV2U298ityS3CSIpmT+EeVT6f3ifXbJqlaqxdYej26tCf9CbRpYZQdYf wSes7jAYio6adoz+l3cF4G58XGWQUGvfcROamtKz6UWhNO1kh6GPxifQe k=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 98803007 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:qnphN6x9vEkY+ucs8cR6t+cBxyrEfRIJ4+MujC+fZmUNrF6WrkVVm GQdDWuAbvuOa2fwfthwbd6+9BgEv5bWyN9hQAA9/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRkP6AT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWR80 fZHATI9UhCsq+uJnpaBeNVGmct2eaEHPKtH0p1h5RfwKK98BLrlE+DN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjWVlVMquFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuqCNJKT+XgqZaGhnWj4zIeVgYKbGCYrPq7tnGhe9EAA R0Lr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOv8YsSTsn/ lSAhd/uCHpkt7j9YWmG6r6eoDe2OC4UBWwPfykJSU0C+daLnW0ophfGT9ImGqjliNTwQGv02 2rT83N4gKgPh8kW0an95UrAnz+nupnOSEgy+xnTWWWmqAh+YeZJerCV1LQS1t4YRK7xc7VLl CFsdxS2hAzWMaywqQ== IronPort-HdrOrdr: A9a23:S8ncnqMZFnaBzsBcTvyjsMiBIKoaSvp033AB3UoZc20zTiX+ra yTdZUguiMc7Qx7ZJhOo7690cW7IE80l6QFgrX5TI3DYOCOggLBRuxfBODZsl/d8kPFh4pg/J YlX69iCMDhSXhW5PyKhjVQyuxQpeW6zA== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="98803007" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdZ8cLfDO8z4d+O1tT4Y3loUsjxoqRE8gof8PrJgb9MM1c/p462IR50IQ45QEz5q02dwBdm9UmdyyVq0v3udGs11UKIDK6JV3iSqJ5HWsguSe/nxK8qT01GtQ3RG9MxocU6XrWCJDDW29etrqtIWx0b3LIEPB3nWiqBXOI5KKBu6sDub43ViFHYJMOioWgp3s9q130DSFak2JFh62FZI7fAADxoCzgBT/Q7ZxHhVykzZ4XrZWfXoqeUP1ulSKvob/29WkRCX9a5VYw60+vXpIEAEsRGH+4UI9lvbzrfwYUssUl+v/uRdLyn8Pihisii8z4YSleq1+VJMFWkotWqV7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRmP5cQzkhMr0IvDE09UaF4/GHUkfM+n1ExHHJe/zq8=; b=J7lW0qFM7CeEBLX520lxHyS1GtH2EH2PGt22nfBJCxMcF+cPdbsxkGFFCwZzYql0wRgAK/wfqt+7RRHXwBNlIlsM6LRhKAMU7cmsRpP0jzf++XFKclutTpQNTLdwbfUK1QhK9zkMSfaOt37PMGOiUKVhCLWjN5UYnGrXyK5wZV31H2J0P3uyxgROiMvWZUdEVOicWfeJUVKQbyMycxr9AiwcKCGGHjFoWe8dLV9P0kY3/OicyjAvEku8Y6RmAQzr0VGy6LB5Dp8TLPYUmrW9zLjmCSoTF0mKEzvozF0SeauBALa3XNQkxcql690JGrgWWe1eM/lC5aaHHSAocfbcJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRmP5cQzkhMr0IvDE09UaF4/GHUkfM+n1ExHHJe/zq8=; b=A16hYfAvzYDjFmziWe/pHV8vCqJSKsOpF455Ard5oybUgwb0z1NmVBzUR34gr3ZPN3lKjWfYs51DGywBx/WqAFSRWRVRsg3td/A3AI8pA2eFeSrt0ZknOKiYmEm3Lw21g/200sNbZKe7NpjNPuGswviJ054ElvPlZzkBlvEfs9A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 28 Feb 2023 18:25:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH] automation: Always pull base image when building a container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230228182226.52201-1-anthony.perard@citrix.com> In-Reply-To: <20230228182226.52201-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::17) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW5PR03MB7006:EE_ X-MS-Office365-Filtering-Correlation-Id: d18cc5f6-86e8-4cb7-cc8b-08db19b93739 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VODLCyIB8017nNKdLvMp9BAL61S7DBHWnA+HB4gso5MrY6/vH0GFoR4CvmBJmDFpmRnL8lNGQl0rDXAEWZSO419cIwlkdOadu5HsyfIKNLIyHqRcyIZV+5Hzw0uEKpdXtqBq/qk97+O77DVJJ860Q7PmoBHiaZ58HeKvKrhds4bUhzoL7/v5gwVZj5Jx4SjfozKZZ0F6c0z8bN5HyKG9CogD6Pmhz3ghMbeknbHlUm2+4+8p5p3HA9AXpCRk4aLgUM4kJwzlElCMvv08/XOL4jTBK72dmzN2DOzOocnzoQFg3g7JCSPtaMugj5PXbP7nytm8aEBJg64dMKChXqgKafLDmtMIl6J6H0c+T7j15V5ec2a7cl+SQ/9lteuCI2zGODDOsNKmK/e2p1eXZkZLDIm1J1AJVMXpVJmw/YXNzIa5kqzO2W3Iwclw+ZMNtYfCmrKhWITzlTLDMhC0qK4JhhH6aFS3t2OJ1LE4sXW20tmsVM5OMTMjqwWp/G1KSvpSSE+b9E59p8nddaT2GAJzaXZ9icPqi9U+rdrAdoy+CipGYsNA/zVA/9dDJ1YitjXI9MytSx6ebJI3e0BwmsO7kNDfMcMrdghX9iONXlNk6WjqPTLVDVgpNdzDmK1N4/vMFF+dqXRrxUSZtVPZIXpE1eCQWrY4SgFMd5/MLQNSgLXHQrtLgivT5E6Po8jdn1jJ1C2BXl7f8aeXJ/h0mzjXv1RWjD7z9i9MHM6UK2OyDG8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(451199018)(316002)(4744005)(8676002)(86362001)(54906003)(2906002)(41300700001)(8936002)(66946007)(5660300002)(66476007)(66556008)(4326008)(31696002)(36756003)(2616005)(6666004)(6512007)(186003)(53546011)(6506007)(26005)(83380400001)(82960400001)(38100700002)(31686004)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2ZwYlRtSmxhbENHRE5BWldTK3BRUUQ3SW9ETHVuazZGbHdJZ3VKaEVTTi80?= =?utf-8?B?RTZob29ad0lhSXVBaVFaVVFoVDRpMDh3YU05Ym5taEtmZmVLb1VLLy9LUW5M?= =?utf-8?B?QitLMVRVS0lvTENXd2NNS3l5YkY1RDUyZlIwS0FadCtCN3lZUjBjWjh2MUsv?= =?utf-8?B?ZUMvdjZtMGIwNEUva1lnY0I5SnZCR1NaLzhYQzlpTnNyVDR3bjJZZEF4WEph?= =?utf-8?B?bzZWYUFleHpuVnZvWCtIVERyUVo4eUszUkhsbHQzcTRockFhTW9aMmRZREhP?= =?utf-8?B?cEFPK1U0SEFCRldkSDhMMlg3RnVHL3pWc1JRUW00V2RCYjdqSkF6QWFyOWly?= =?utf-8?B?ZE1hNzRzVHMwTUNwV0d6VmM5VklmVHR4VkQ0a3Fjeit0WkRIQzc4MXVaRkFD?= =?utf-8?B?eUZrWDYrdGs2bGEwVmZJdEx2MTA3MENkUTZwT09KUGdFU29BZGZHRVZ2RmJR?= =?utf-8?B?UDRRdzJsNGpvVG1ldzBZQWMwT1lEMEVDaXc0ZVl4VjlvNjBvbUh4eTBzQ05v?= =?utf-8?B?UE04THI1MFZJYWs4Z2NUWDZvQ0piY0l0K1UyR2l4TU8yaHRhTUNRWEYyMGhz?= =?utf-8?B?OVBoT1QwR25ZY2dteDJJUk1sZFhVNkJwa0tURW5jdGRFZVM5Tm1PQ1k5NlVy?= =?utf-8?B?QU8zeDFYQ09od09pSmw5SlhvZ0RLTlhydTNweU9Cb2Zwcmk4UFR4VEgycFFL?= =?utf-8?B?U2ZQQ042ZW84a2NDZlhwU1VGbnFrMUl6TzFCNU9zTTBRc0JpVCt6ZW5iWHVU?= =?utf-8?B?Y1M1b29HOURtK2x4SG9td1ppZnJlZCtYSkZGMlprMTZwNmt1dVo5aWpYYWo2?= =?utf-8?B?cElhc2NCOVAzKzJ3a1hucGdoSDFxM1VPS0dpaWtrVkpJSHViZ3lrK01hR1VT?= =?utf-8?B?M0dVV0tBdXRnaWswODZSRkh3VU1manZEcnk5a0FrWG1UVzF1dFNLRFo5UkdS?= =?utf-8?B?RVVjaUlGNlJLYXFFT2VJMys0YmlIZmN0VFlxMFNPd3N0b0dzVlgyUEkvYXBk?= =?utf-8?B?UTlHMHgra0s4VHlPTVpESlBVdll0c08wM1MvVTJpbUk2WmlyZHYxeTdIYThv?= =?utf-8?B?bXlzUFBTek51WFdyWHVxRFNUZkJaV1lIQ1E0ZlBIUEgyQTJFN2VmNVUyQWQ4?= =?utf-8?B?TVRkR1J4V1JvUkMyRnEveVRGbDdSN2NielRQZWowOGZvdkgzUzUzeXFpUXJF?= =?utf-8?B?ZnJKWCtrZWcxM0lvY1ltYS9EVG5KZjQ0ODRBT0xkMW45bTUxK3JHNzJJOUlH?= =?utf-8?B?OUoyUTd2Y3poQUJWdXNJVFNDc1pQb3AwRkx4QkljamptTXdIRXc3cHUrQXhG?= =?utf-8?B?V3RINTdWbGc3UXZBbVVmT0dzV0VwWVQ0VFhTaFljZFhsMFc2S2FlWmR0WXFI?= =?utf-8?B?dTh1WnFhQ1FKUFhMK3phbkRPSlRyKzEzK3pBU2hQMUJ2RVllM2hTTkFZRWRm?= =?utf-8?B?V1NQNXloL0JuM3RiejYwV1ZzdXdTQjNobmw5aE1MbUhPVHBleEJpVGZvUmtq?= =?utf-8?B?RUxPWnU2Q3VxOGhON1ZPNDNUSzY3ZGpmR1pVRVdObHRMUkhNQlJaQVdOWjdV?= =?utf-8?B?UWdwOHpQcUo4SFpFejVIeHNDRXc3ZTVMUDRzVnAwMHRtelRadUdxSXRDUkF2?= =?utf-8?B?RTBJWFJUenEzMVRjZWhhR3RKY1JZWEQ0K05kazFmR0kvajFpVzkvVFl5YVVn?= =?utf-8?B?VFBxSzhOZFk3QWRWekg5bVA3aEZ5anNCbEk0Z3dLYURIZXBaY1IxT28yREpC?= =?utf-8?B?ZFJXdUJIQUs3VXgyRDl5RE1GZWtvanRndkxVei80SlVaSWdvL1FWcStZR3Ft?= =?utf-8?B?cTlBT2EyNTd1bjdxTFV6NWZ6VklqMUtET2kvRHZEZFhwRW9ZbUJxUno1eGJ0?= =?utf-8?B?NGdnZHZSSEV6T3gya21yWDdrcm5veUtESm9HVHF4VUhOeWNqMTBzZ0FQb2J0?= =?utf-8?B?UExLZnlkZ0cybllvZDM1THFKaTBWYU9kVEp6SHh3WXZ6VVNrZGxHL1o1aUdh?= =?utf-8?B?aE5jVFNRdWFYQmRvRTJDNDV5VlFiTlEwbzB6Rk1ZWG1zalBuclpBRHlmTC9L?= =?utf-8?B?U01kV2NrYXF0THJjM2QxdFhxUGFNMHhoUkNtdmpVY3NVK0VhWHo0VTdLYXNq?= =?utf-8?B?MitKL2RIbllFMWgwVTRvT0VEMDRENEtYVit3M1ZvTmtGdEU2cDVSUHAyamU2?= =?utf-8?B?ckE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NYHIk/5+Nc7YOijo1Rz69Tgfeg3wVJM3HVX7cYJ0Fxd2cCqQoEoK5+68tgtbdRWeuNKzCU9Vi9jDP1/eIWMpdWCN7IiQtBhuthk9gGLsegWg38ZId8z9L0WRVLY5Dafg0GeYnvY0Re58TB+G1skUg56wJUDpVM7GIMCI8Sd+q+aT1Xk5uoVWjHJjMCHqZ031vD3zFXkHPgBJu4XLlvynBLCH0bQgixqf2EjeJ3gYononZg5nxt5PrI/20zfYkgQZldjMznQ5bnedE9r10gNEcB00HB6By2lNUoewlbOgRB0uqw7ytqtZfuLsQj41uzBMVPU10Ev8UooajXzKb0yZt67QWgyc5IGdZ4AURCa+G6k/p8cRiRk93LQGfhAduGX9tOwcdA5EQHVfFh1L0ZYREzqZ4Y/Uv1uZvsS8OGJDKERCDwCuQZ0sTOzPlZzFwq8vQXVZBT3N+Qm5r33Eos98/3Tkizn5YYFE2In2+9ACOV2EJWS/D4i/15weAoIAsF3r87j+4o7K6JKTCWLZts9QrmP/etVl1cx1G8W0hF6/8HXIqOTvQTvoJQJdoR5y8jB73sMW5PCAVjj9sytbfmV49SvV9+VREHyCBSXmfxIA66ND9iAwg+w2JCBwZ7XtmmcVv/yO2+jmUCWA1ajzAiNTMxmnQZwHAfUONLyLldJEvZ9R6PaaZga8u1qqhwjZ1f3UzBImiebk0ZQzsH0UnNcmMmggckaGsjQTkOcL2kcAPOKCEoVDxTykQqVbZMkJLrj5nUYxjOqwqPqjhNr1IZqJ5fWOd5g6GQsmme0gqiknFA5O90WNxHU7kqHYYqOYWcmn5KbosNynTHTZ6ZYX/rqBcQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d18cc5f6-86e8-4cb7-cc8b-08db19b93739 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:25:49.2985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Z8wCiWs1q3+ikSQG1sgFGceTtJftHfv7GxDGxEt06e0KuZRZm9eNPFeXzVuUNTy6aYFzxJKGrPrGYVWqeAujcpkFmsLTofBg4J6h+iKFvs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB7006 On 28/02/2023 6:22 pm, Anthony PERARD wrote: > Ask docker to check if there's an update of the base image to avoid > using an old container cached locally. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper I've lost count of how many times I've fallen over this. From xen-devel-bounces@lists.xenproject.org Tue Feb 28 18:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 18:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503685.776028 (Exim 4.92) (envelope-from ) id 1pX51l-0003rn-Pp; Tue, 28 Feb 2023 18:48:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503685.776028; Tue, 28 Feb 2023 18:48:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX51l-0003rg-NC; Tue, 28 Feb 2023 18:48:41 +0000 Received: by outflank-mailman (input) for mailman id 503685; Tue, 28 Feb 2023 18:48:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX51k-0003ra-Qg for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 18:48:40 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 81ddef8a-b798-11ed-a550-8520e6686977; Tue, 28 Feb 2023 19:48:37 +0100 (CET) Received: from mail-bn7nam10lp2107.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.107]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Feb 2023 13:48:34 -0500 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM8PR03MB6232.namprd03.prod.outlook.com (2603:10b6:8:3d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 18:48:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::8299:f95f:934b:29e8%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 18:48:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81ddef8a-b798-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1677610117; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZWnw15mymTWlfo9wIAG8xsZU+fVj5ivozqE0RAPdovc=; b=GHtdQTkk9g3iwLoKchLzcPGlfMMvN0XBHQlq4do47Wq89JdghHaPR4Vu Fd5Dgb/eWIPblKLg9zV5ZzJ9aY0BBerz9ARfBDJydAP5W1W+lZtO9eTG1 22olhi3genB2PCY/wiQit/7yaNPfl0VbOk2vgdjSmB+Ia6/+5XUMVEdUX Q=; X-IronPort-RemoteIP: 104.47.70.107 X-IronPort-MID: 99309684 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0jr1fa0TJIFlk4UKB/bD5eVwkn2cJEfYwER7XKvMYLTBsI5bpzACy mJJWz2HaPqJYmChKd9xatm18BsPu8XSm4JgS1ZppC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gZkNagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfCmQS+ fEADm0xUSuCo8yIh/G1F/Q3iZF2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFMZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKqA9pDSu3knhJsqBqfnmoPDTtNbGD4of27k3GOacBAe kNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQtvdU6QjEC3 VaTk9TkQzdotdW9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHeTJobixvOSpNpFvGzh9isQTXom WnS8245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp4 BDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:nIOiR6Hz65DSBYzbpLqEFceALOsnbusQ8zAXPiFKOGdom6mj/f xG88566faZskdpZJhCo7690cu7MBThHPdOiOF7AV7hZniFhILPFvAA0WKI+UyHJ8SRzJ8k6U 6iScRDIey1I159g8P3pCGgCtomztmB/OSBnP6b73oFd3AOV4hQqyl+DAifHglfXRBLApQ4E5 bZztNf4xqsPVwTbsygb0N1O9QrZeenqHsrW3E77tcciTWzsQ== X-IronPort-AV: E=Sophos;i="5.98,222,1673931600"; d="scan'208";a="99309684" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNCPfw0vRTlBwrTFPmIFe25SwCwpLVxWZ2/jkCAlFSzayw0j9tz1X20LlYEUzl7pNmM3RI+Z+YNMG8iWi52F9LJGVftKCviI5CpuC6iXh7bAlTHk7nCrqK195L7cGN4NuG2q5hSni2dgzF0C+E0BNUu9bCUlzCN2j6eOZMuJylHjk6Fh3ng64/jgGDDTx1ld96eRUhqFYEcMYpbV7I0nYC52DvrcjkbiqFQKG/U0lr1yoGfu2vPB1V5iGMwcP+bSyVAHr3GRsWlZ05WUJulmMgd0lc0YPpkMjxi6lnCdnxV0pUObhUvL/a7CzW2lArWyjdxzMDn1B4dY7CBSHzCqgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/nXjnTlPIJiarTABu89hdaYMD4884O9NphsqENywPOg=; b=X6P2rLqQ+VNPU/y6DJgn8+FrLk2wuz1Lq3TrS2gohKSj7f3TsAD2V+B0mCgq94I13AiSF+clYexzZXqHL4oOGmEkCHGlMOQEUyrytUjelKqQJqjf/H8JXEGY5qdBPWRVgZttI/RzyxSVwLzn39fYwsznHJjhNuz5uiEFUb8Y2fAYZ7uz5Xj1qR0GB3dSI/f48mDcY+O2vyBIAuuYKTIUbW7nt17LOc/Nyr1/KmXYwPM/FTnUqpS6xupf4o3gV/PQbykyEH7QLryWJmgIP9D7lFPFx7sEuBaruUSddC/9n5n1lNon1SLK9khfGftvnNg/HQGYBY/iU0CtIsQhuTSo0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/nXjnTlPIJiarTABu89hdaYMD4884O9NphsqENywPOg=; b=F0yUhv+BCYk88JSRGshQ5jFngN8nKd4kvGdaNyCi1MmwZ+ErN3/EVj4w9zesUhQZmf35Qc1CkzucxemcjYz2X3TrrIrVt8uPJyl3B4h+B7BbvUtIZcaRR2EnnkARMJiSOf3Rhn8eKjwjn5Wd1wM+2RpJJeSbb35zh9Y3A6Grxqw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <27e9e2bb-423c-8ad0-aaf0-351b756c6c40@citrix.com> Date: Tue, 28 Feb 2023 18:48:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: Andrew Cooper Subject: Re: [XEN PATCH] automation: Rework archlinux container Content-Language: en-GB To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20230228181649.51066-1-anthony.perard@citrix.com> In-Reply-To: <20230228181649.51066-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0373.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::25) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM8PR03MB6232:EE_ X-MS-Office365-Filtering-Correlation-Id: f0c3b1f3-dfef-4fe3-7f69-08db19bc639d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QyDn6H+0I3BXdH76rvmm3nE1GPB4YnyOTxaDPcPvlImsXIseCYryHzqSZWREFkg6Oo3En04uBesmzXtBmuZkVjw3/sAtTlnc9NAiu/0vOYEh31r9XGvQ1FvAK4MNRsSYhhrD0tOz1JWs7S2r7u5c/V91SndBjcrnB3H36N55ymDFIk4iiRHRIQ8UlbBlxdF7ny6w56PlyZj2+K0n0XDiu6u7G/XXfdndFnCvwOWnLpN0dWuzFfF5eOc84DaWSPml1sAJDTZJGBNjKf3xDkr8PdN69NHyaPI10ChjV1+z5eRRsYUOzeWXTbloCKVEIYx1NopXDyikI4L0ucRBKm0m40ojBGBtuZX05j98By4KDoc9e/yQDWHjVnrBromdDJP85g/PzM0GmCUmDyDJyT8qu5ZlpUGqHNWphHuqtJ6RDkJtmeShXwWEnLj4zEqVFI5tletuHTMq/0CGUpMULWnHcCFVbKR4Fn9z4xd+eOlNDpSSizyAh4+FT0e+qGwhKHGZMNqhBZ3YiwdTZ6hpL2QevCr+JoNE2LpKIZ63ZVYRTyzinXd+n2nqevqge2wv0VE9iTzi3BE1e5oz0HdqUPwJHQTdMRSdHq9mg/XnRI+5XsCco3j8cHohgNH+bIrHGhGWDYQZ5Q6Sstcf3sVKhIrDLtUnIKq/fgQXiCiZm0o+2d4QnI1smhIk3qTN5LdD4e4TAseOdytvXPEBuABSkkPCKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(451199018)(66899018)(36756003)(31696002)(86362001)(66946007)(66556008)(66476007)(41300700001)(8936002)(8676002)(5660300002)(2906002)(4744005)(82960400001)(38100700002)(4326008)(6666004)(6486002)(966005)(478600001)(54906003)(316002)(31686004)(83380400001)(186003)(2616005)(53546011)(6512007)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGtrb3VBZmkwSnQzeEZKQXdGczQzTTJJT0VvS0RnNkhtZGwwMjBudVcrNDR1?= =?utf-8?B?bWRRZlpBSCt0Uzdza1pVMFY4YmFtREJ3UW8zTGxLd1lQdjFFK0hqVlNxUFds?= =?utf-8?B?SHlnaEV5WWYzcTRSREJlR3FlcXFJRE1haFQ1MkEyU3V6MVNENzRGakMraWtS?= =?utf-8?B?RW5Zb1JFOFFKcWdHMDBhVUZOM25hMGloY3NJcndsUXZ6QTVON0pTQnVTWHhP?= =?utf-8?B?RFhJZFNocDhnNTFTbjFuc2FqdWNqdWY1eGFiRmZVYVg4dWw0NVBUeTdQVk5K?= =?utf-8?B?Mm92ZVdjUVpOMGZ2aFIvOGtmQlVlYm5aakgxMnIyM0NtYnhNdGNQQ1U0VmVv?= =?utf-8?B?Z0RKa01MdmRocDlFbGJGaHlhOGdHVHdPUzc3TFh1TTh2Q1g3dER0enFsOFUr?= =?utf-8?B?bWFaYTEwcldhSmJUMWl4ZGZ0L05lMTNYOEc3NE9qaU8vRTBWUFBKNzVWdHc4?= =?utf-8?B?cSsyMkQ2VFAwWmpIamllWXhGYks2MnlUK0V3bVI4T3JZVWNDN3ZkOHkvQk51?= =?utf-8?B?YmNDVDlwZytscEJGazZwdTRlL2J3OFZ0MkNhcE02RlI4K0lMYnhuTE9GWVMr?= =?utf-8?B?RHFFRHQzUmErOFFuRWN6NUk2QXRsRzF4Q1l6VzBXQkR5enFXMU1HRDM4azF4?= =?utf-8?B?SlZQQnNvclM1L2s3MEFPT3ZPTzA3aXNYejJhVDF2a284T1RKeGFHOHJlUXQ2?= =?utf-8?B?dVFXUU5VbEZaM1hnV0pyYnJuSndsNENNV0dnaC9VcDBPM1VrRWx2eEpwdFBj?= =?utf-8?B?OTEyb2tGOGg4YnBaTFZFcXF1bThjWFp6bmFpZ3JCZ1VxbzM5NjkwWklzQzAz?= =?utf-8?B?ZGYraWE0dTFucnp4QkFLempFVWVBNk9IODJMWkwwTVdjZWEwc3l0VnNoZy9s?= =?utf-8?B?TCtiS1hrRVhLMGlmeWExbjRhRmpMd1E2M2F2dVN3RFBCTmlSUXdxaElLd2FM?= =?utf-8?B?UXJkbDlQQ1hCbmVmL3Z6cHl2S1NyY1NFWUNReDluazJ3dVowZDlxMXA0N2Vh?= =?utf-8?B?d05OYnllR1lmb1RqT0s1VTVFeWM2K1BITWZINk5VRk5zL1B0Z2s5dnZ3dElh?= =?utf-8?B?dTBXOGFranNGSWpPRFFJcVk5aE14bm5FbkNIOG84R3pEZGhTeDI0VTJIYUM3?= =?utf-8?B?TDE1dE5CNXRreTBTd05XZE42ampGM1dtMGNxZmV1STJpUzgyb3VKMWRxbGZy?= =?utf-8?B?MmtyQUIvQ092MlJ2c2poaUcrdXVGVkY5MG9ZSEFmajVwMGdEQ2lOWlZEdURV?= =?utf-8?B?T1BsaWNYUGsxSnp5cjFSVVNrdmxIbisydGRESzFuTHloT2JPMnU2UWlRRVVy?= =?utf-8?B?RmQvTks3RFkrUHpuelpzZVRtS0JyT0R1NGJkT1o1aS9RWjUwbkpZQmRyLzcz?= =?utf-8?B?MndyUjJ1bHNEOUQ3RE1hbHl4d0ZQanhLUjlmTkV6aFhwUVNMc3V6REcyeVUr?= =?utf-8?B?RGJmNFVheGJqRDBlUE5zZGxFek54RjJmcWhkb2M3MFdzMVYrT3I4TTJPMWNn?= =?utf-8?B?RkJIOVlLdzFmSE1OdnJWYmxHVWRhZ2VOc2x6eThCWGN4b0ZUaFI2VlFZVFhj?= =?utf-8?B?OFBqTmdaNVVwQVpMMkZuY241eFpVejJNdXpjd0hHMnhyVi9XekUrV1NZVHhV?= =?utf-8?B?RHc5YnNWc0NVMXVvMEFIOGd0dUcySUdudHIreGx3bURPOEFPZjJUN3J0ZVBk?= =?utf-8?B?NWJKY0kvUkgvT0txNW9yRkc5SHpqNFo4VEV6aTBPUVROaE1DcTMyamd2REN6?= =?utf-8?B?VXZRUTE5M0FXSktxZTAyN21lZ3FWK2JKUnYrMFVibldMci9ZdlVaOExXR0JF?= =?utf-8?B?NVJnRmtGOC8zWTd2Q1grbExGNHBlT09Jc2EzN0RvRjlNeGF0dG9ickxyek55?= =?utf-8?B?d214dkhHMXNRZmdsWTdybXRTNzhKRFRIVFNsdEM4Rll6a2dUQXgyQ2dYTUZw?= =?utf-8?B?eGZEM0ptd1JlS2tibEtuV3QrYTExa0pQRDZocXJHc3F4Q0pzazM5UFBERlh4?= =?utf-8?B?b0dTS2hTR0tyZ0lNb2trb05IY2NCT3pGaVNmVngvb3U4aWhxLzBNNEg0NkxC?= =?utf-8?B?UkxVajAxRlRzeWJDaGhBdjBWa2V4MTRwYkZFSHQ0Y2NtZ0xGdWVwSmhkSjJw?= =?utf-8?B?OGJMN3Z4T0ZHem5jQU5DZFA0SmxRSjRENjBoQkFTV1RSbzFCZkV0ZC9TOWtl?= =?utf-8?B?Qmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KUgkeG4qlzhuEz5c+bw4CQIh/eSM/3yr99IBGqPIwLfxnAR3HuyTf9L3P+7Op9i3/z7DcVPLyX4n0RliTH4For4O9QwYHNAl57DMix39ZbG5Lb99VkaHRLe7laLLDWybjpv2sysMS1S7CNAkTIR/O6eIWS532LOutUud86F8W8qVKwPFf94ofDpxl83OzMprKD3WBenbFVp8Z7CmwQrMLlUx84nX/JZRDv+e5dTi8ALC+ziXEqKtz/kz9WknaIntwFlS13vE6qFdLGHUzh1GSBb60D2zZ+5TKi7Vt7ryXbmzplfXQEWceDU5jwnD3OZvj304S1IL4HLvlcEQcBeviGRpktERcmwQpvxnGbVCcdoE8+LoVx3/TzVF3iCHkk4N1FKZVqFLkljEcBguhOxWEBVjodosGq3KNnLcAXekJ9uJUVlbCgBVAmsOYLecJh7c0F/TNNeo0wV29Y0DO0wDa11TMovlNzN2n+oBCnYjV2Fg1anQwEWffgXsHNx0PcsV2EteBrKsM8Z0+hGgJv/zzDXXxEP7o4AV9PbCfa8hDozl/0H67DQURAbEusWofe5h5awW4yGrq9ZxTRe4nK618f2zKt2so7byE+crdt5tIJ8Dwcrgzy8FcTy5o08i6h8AHMBRwGCYe+gEJ48PWS03+xoehTq6udrTDFaBAFPw0LUN5jdg3G204Fae3FfRyyh5WLe+KIbkD2gR7w1JSkrfzZYBKZIcAjzzRCxTaEp9SK7FWBKRDA3AvFqHsvtNa2N4TpUV5rXybZwJkI9oAPI3g2zPtyuL9Z4GbASeSyMYGvaCMf90oFh/jhEDYRcGh4j6SE+whw/o9S1yvEzJXf2FLA== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0c3b1f3-dfef-4fe3-7f69-08db19bc639d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:48:32.1212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v5aORRPK0qhb/EBaVXrVvZvP/rdp51oAQpFCqyVwznD/7DqgI8XuKXFH1UpClIx98/m32NdiZGRDaqHeQYzPbln5BZQHHfjUcQeWxrAMBLY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR03MB6232 On 28/02/2023 6:16 pm, Anthony PERARD wrote: > Base image "archlinux/base" isn't available anymore, > https://lists.archlinux.org/pipermail/arch-dev-public/2020-November/030181.html > > But instead of switching to archlinux/archlinux, we will use the > official image from Docker. Main difference is that the first one is > updated daily while the second is updated weekly. > > Also, as we will install the packages from "base-devel" anyway, switch > to the "base-devel" tag. > > "dev86" package is now available from the main repo, no need for > multilib repo anymore. > > It is recommended to initialise local signing key used by pacman, so > let's do that. > > Replace "markdown" by "discount" as the former isn't available anymore > and has been replaced by the later. > > Also, clean pacman's cache. > > Signed-off-by: Anthony PERARD Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Feb 28 19:16:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 19:16:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503725.776038 (Exim 4.92) (envelope-from ) id 1pX5S1-0008Iy-Vl; Tue, 28 Feb 2023 19:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503725.776038; Tue, 28 Feb 2023 19:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX5S1-0008Ir-Si; Tue, 28 Feb 2023 19:15:49 +0000 Received: by outflank-mailman (input) for mailman id 503725; Tue, 28 Feb 2023 19:15:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX5Rz-0008Ih-SX; Tue, 28 Feb 2023 19:15:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX5Rz-0001vM-Pw; Tue, 28 Feb 2023 19:15:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX5Rz-0006sz-FC; Tue, 28 Feb 2023 19:15:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pX5Rz-00052N-Ej; Tue, 28 Feb 2023 19:15:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Iy25kCqUmRWMWkQfrrepvVtIBeTXhHrJ6GDEwLRTRho=; b=AuOEsl+nmLT9894OH/o2t6iv3C CzpkPSkcsIV97EO7di4HvQEZGgmGlrJxhVTQr6wxUQ1SDfn4XlhxktHSopz5kRWHkgozN5PMIHFXG l378lGNJKlbvJ2bpeJ9B4SUQud87m3nNUjAMrlgEhahoj6rTYEvcOFkbayaHT1Z4WZ5U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178789: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=976ae57b30d0e9432b51ca2ff408d8e52f40f280 X-Osstest-Versions-That: xen=a4557f515fb002010b34b79102278ea03d6b31a3 From: osstest service owner Date: Tue, 28 Feb 2023 19:15:47 +0000 flight 178789 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178789/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen 976ae57b30d0e9432b51ca2ff408d8e52f40f280 baseline version: xen a4557f515fb002010b34b79102278ea03d6b31a3 Last test of basis 178776 2023-02-28 14:00:26 Z 0 days Testing same since 178789 2023-02-28 17:01:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a4557f515f..976ae57b30 976ae57b30d0e9432b51ca2ff408d8e52f40f280 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Feb 28 20:05:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 20:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503738.776048 (Exim 4.92) (envelope-from ) id 1pX6E4-0006oD-OH; Tue, 28 Feb 2023 20:05:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503738.776048; Tue, 28 Feb 2023 20:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6E4-0006o6-Kz; Tue, 28 Feb 2023 20:05:28 +0000 Received: by outflank-mailman (input) for mailman id 503738; Tue, 28 Feb 2023 20:05:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6E3-0006o0-4a for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 20:05:27 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c7def7e-b7a3-11ed-9698-2f268f93b82a; Tue, 28 Feb 2023 21:05:25 +0100 (CET) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-44-L1Tq-5ugMsSVHB7n2BProg-1; Tue, 28 Feb 2023 15:05:20 -0500 Received: by mail-wm1-f70.google.com with SMTP id j32-20020a05600c1c2000b003e9bdf02c9fso7360745wms.6 for ; Tue, 28 Feb 2023 12:05:20 -0800 (PST) Received: from [192.168.8.100] (tmo-112-221.customers.d1-online.com. [80.187.112.221]) by smtp.gmail.com with ESMTPSA id c16-20020a05600c0ad000b003e214803343sm16622509wmr.46.2023.02.28.12.05.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 12:05:18 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c7def7e-b7a3-11ed-9698-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677614723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQd+QhpwRnF3wyVrQuuVP52v3cZ2QpqTThkyv4Fl8ik=; b=iujQtoOg/vphkJxwewKlF6Iu4LmW82xRr4skgeoBWVvqibnVw2LxCEcsyJqym3cbUYDMl4 u8SimHyaGZMAoJgevG8TW5QZZhdzJ90kAfQVpIasgt56o6HeYFF0ndRCGGkxhXdJt0QOAc KB0spX596PlgiCpQ1Lj0wYs3hQw/4n0= X-MC-Unique: L1Tq-5ugMsSVHB7n2BProg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nQd+QhpwRnF3wyVrQuuVP52v3cZ2QpqTThkyv4Fl8ik=; b=40pPAIQo/tA8Hmp3OAgwrbH1kA5lK9C2gajPDwFbX5Quc59ZDKLzi/tvYp482+lHys 0wcqv9I5tNHC9LiP2D7r4udRvUscMOHq+gNZ3kBElx8xghbataw6b9nZmS14X/fj3Ov4 6f3YJ0cit9StUhzk1jxw2eYsEKg/NkYui8etsIy0mBS/rtZpWVOhC5GNYHEmBQRMuQR/ bNnbW+o0g41CCedHMp7cIjeR85tVPSPet/y18y2++//jbJi7FXFDxc93+1lD/DBHYwVv 4xeo/2ECam54OmXHN5aOa6d2e9VQsV4CmGNrM/RMy4nqld5pDchxVESk7iTmU+vA5AR2 ISjg== X-Gm-Message-State: AO0yUKWuwYXY7kc8rAV1W5XZZQuk5c2YNvZXCqVzxOirWMPfv/ZocAnZ BuyCU3QEIXKDla6jge5Stpg2SzEZ4AThEouhMhyTlvRWdyi3IWjmTHLQd1GqGfzOnnX9+aSmZE2 OccRJorVlNxGcLhiXHmtE8n4sZiQ= X-Received: by 2002:adf:e945:0:b0:2c7:17a0:c6b5 with SMTP id m5-20020adfe945000000b002c717a0c6b5mr2892275wrn.34.1677614719637; Tue, 28 Feb 2023 12:05:19 -0800 (PST) X-Google-Smtp-Source: AK7set9MmF9eZGPOsdEoWMFU4L/R5a85Aqi1pG3SMRTtHFB4tUvsUD1H2dNf0t4BROa+7hwk1Y3Vhg== X-Received: by 2002:adf:e945:0:b0:2c7:17a0:c6b5 with SMTP id m5-20020adfe945000000b002c717a0c6b5mr2892258wrn.34.1677614719335; Tue, 28 Feb 2023 12:05:19 -0800 (PST) Message-ID: <99a83e65-273a-ea1b-e7d9-bbdd8ca32145@redhat.com> Date: Tue, 28 Feb 2023 21:05:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , "Michael S . Tsirkin" , Marcel Apfelbaum References: <20230227111050.54083-1-thuth@redhat.com> <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> From: Thomas Huth Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/02/2023 10.01, Daniel P. Berrangé wrote: > On Tue, Feb 28, 2023 at 08:39:49AM +0100, Thomas Huth wrote: >> On 27/02/2023 19.38, Daniel P. Berrangé wrote: >>> On Mon, Feb 27, 2023 at 12:10:48PM +0100, Thomas Huth wrote: >>>> We're struggling quite badly with our CI minutes on the shared >>>> gitlab runners, so we urgently need to think of ways to cut down >>>> our supported build and target environments. qemu-system-i386 and >>>> qemu-system-arm are not really required anymore, since nobody uses >>>> KVM on the corresponding systems for production anymore, and the >>>> -x86_64 and -arch64 variants are a proper superset of those binaries. >>>> So it's time to deprecate them and the corresponding 32-bit host >>>> environments now. >>>> >>>> This is a follow-up patch series from the previous discussion here: >>>> >>>> https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.com/ >>>> >>>> where people still mentioned that there is still interest in certain >>>> support for 32-bit host hardware. But as far as I could see, there is >>>> no real need for 32-bit host support for system emulation on x86 and >>>> arm anymore, so it should be fine if we drop these host environments >>>> now (these are also the two architectures that contribute the most to >>>> the long test times in our CI, so we would benefit a lot by dropping >>>> those). >>> >>> Your description here is a little ambiguous about what's being >>> proposed. When you say dropping 32-bit host support do you mean >>> just for the system emulator binaries, or for QEMU entirely ? >> >> Just for system emulation. Some people said that user emulation still might >> be useful for some 32-bit environments. >> >>> And when the deprecation period is passed, are you proposing >>> to actively prevent 32-bit builds, or merely stopping CI testing >>> and leave 32-bit builds still working if people want them ? >> >> CI is the main pain point, so that's the most important thing. So whether we >> throw a warning or a hard error while configuring the build, I don't care >> too much. > > If we're merely wanting to drop CI support, we can do that any time and > deprecation is not required/expected. We should only be using deprecation > where we're explicitly intending that the code will cease to work. Well, without CI, I assume that the code will bitrot quite fast (considering that there are continuous improvements to TCG, for example). And who's then still volunteering to fix bugs that have crept in months ago, for a host architecture that nobody really uses anymore? Clearly, 32-bit x86 host is pretty much dead nowadays, especially for programs like QEMU that need beefy host hardware. Why do we still waste our time with this? Thomas From xen-devel-bounces@lists.xenproject.org Tue Feb 28 20:14:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 20:14:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503750.776057 (Exim 4.92) (envelope-from ) id 1pX6MU-00009N-Iu; Tue, 28 Feb 2023 20:14:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503750.776057; Tue, 28 Feb 2023 20:14:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6MU-00009G-GA; Tue, 28 Feb 2023 20:14:10 +0000 Received: by outflank-mailman (input) for mailman id 503750; Tue, 28 Feb 2023 20:14:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6MT-000099-V5 for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 20:14:09 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7549725d-b7a4-11ed-9699-2f268f93b82a; Tue, 28 Feb 2023 21:14:09 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id o12so44978187edb.9 for ; Tue, 28 Feb 2023 12:14:08 -0800 (PST) Received: from [192.168.1.93] (adsl-150.109.242.227.tellas.gr. [109.242.227.150]) by smtp.gmail.com with ESMTPSA id gq23-20020a170906e25700b008e40853a712sm4912839ejb.97.2023.02.28.12.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 12:14:04 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7549725d-b7a4-11ed-9699-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R1dNmKfClY06Aa5L+h7HpDXRG5fzMVTrS1Rvpy2Yqh4=; b=hl972ajbGvEPkLN34AULA+v1WNk0v/BdgPH7qbhkUMvmUz7PU+0KuaZpplqEPniHjv j0l9M0g2vd9F//DN1NRHNVuitMocES15xba2wCJpDX5eYqdt/XrgTyNrcLI/FCVfi/9S Q3v4LcucnbpCrH8WrUKKgig79FTTJH1iMw1rcxZ5DnyeFtowmrXVAGMyNDT96YsSK5Ql qTjRjzvjE8/US6Fp2TvM6kWnwlyF5k2Ta27Cz4FP2Y1qHThLMImpo9CkqtQhVMLgc1eq mRHaXGegcTV3uGmSAbkJ9nr7rMG4Ag0ZAE9QckLv+HOMJIQ1Ln312d5dS/ytpHaWaT4d tVHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R1dNmKfClY06Aa5L+h7HpDXRG5fzMVTrS1Rvpy2Yqh4=; b=MKkUnISCacWWxDl8SW0ET7o12ewUNAGpeHprEy/DQZxuzTtadv6pKEWowHXo0Jr62f RysXxuVudPXKZmPLB3QILrcPEu0BHnucHIfuqLF8DVHnJzD73kXBsDk+6Q7k0DU0hIyJ qrlqtxtuDuUaECwx8xOpBagY+LMBCQdturKy0Fn7uzNjOrLPalfN2T2uBhH0tdmEdyFb QITO/ba79gqjHIgbG3kmph1LuPAbiKunKcxoNwdcoN3O1VqkmLOfngPdP5SiQGK0eUen KdGxB8YWA/Vwam5lTfJj6TdYD/aaKEMA0DtJYQChiLAPrXSJjTcIX/NJnfvM9uy+AJ8+ nEGg== X-Gm-Message-State: AO0yUKUGn4w84ZQeoJ9iXgsc5eHrDe8auUY/ZiqVIa7f2BMC63htrL9g LglcFjNZ5vvIaoQwIC4XlDo= X-Google-Smtp-Source: AK7set+B5IDQZveX9IAjKXZNyj7lFIDsDGoHllTaRdB1XGgOc1fMH4saK/BOV0zx7OnNtx7Ik4I6Xg== X-Received: by 2002:a17:907:c207:b0:8f6:dc49:337f with SMTP id ti7-20020a170907c20700b008f6dc49337fmr5616290ejc.43.1677615248334; Tue, 28 Feb 2023 12:14:08 -0800 (PST) Message-ID: Date: Tue, 28 Feb 2023 22:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 4/4] x86/hvm: create hvm_funcs for {svm,vmx}_{set,clear}_msr_intercept() Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , xen-devel@lists.xenproject.org References: <20230227075652.3782973-1-burzalodowa@gmail.com> <20230227075652.3782973-5-burzalodowa@gmail.com> <732bbee0-24d3-f5e8-7353-b40a77c3ee2e@suse.com> From: Xenia Ragiadakou In-Reply-To: <732bbee0-24d3-f5e8-7353-b40a77c3ee2e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/28/23 16:58, Jan Beulich wrote: > On 27.02.2023 08:56, Xenia Ragiadakou wrote: >> Add hvm_funcs hooks for {set,clear}_msr_intercept() for controlling the msr >> intercept in common vpmu code. > > What is this going to buy us? All calls ... > >> --- a/xen/arch/x86/cpu/vpmu_amd.c >> +++ b/xen/arch/x86/cpu/vpmu_amd.c >> @@ -165,9 +165,9 @@ static void amd_vpmu_set_msr_bitmap(struct vcpu *v) >> >> for ( i = 0; i < num_counters; i++ ) >> { >> - svm_clear_msr_intercept(v, counters[i], MSR_RW); >> - svm_set_msr_intercept(v, ctrls[i], MSR_W); >> - svm_clear_msr_intercept(v, ctrls[i], MSR_R); >> + hvm_clear_msr_intercept(v, counters[i], MSR_RW); >> + hvm_set_msr_intercept(v, ctrls[i], MSR_W); >> + hvm_clear_msr_intercept(v, ctrls[i], MSR_R); >> } >> >> msr_bitmap_on(vpmu); >> @@ -180,8 +180,8 @@ static void amd_vpmu_unset_msr_bitmap(struct vcpu *v) >> >> for ( i = 0; i < num_counters; i++ ) >> { >> - svm_set_msr_intercept(v, counters[i], MSR_RW); >> - svm_set_msr_intercept(v, ctrls[i], MSR_RW); >> + hvm_set_msr_intercept(v, counters[i], MSR_RW); >> + hvm_set_msr_intercept(v, ctrls[i], MSR_RW); >> } >> >> msr_bitmap_off(vpmu); > > ... here will got to the SVM functions anyway, while ... > >> --- a/xen/arch/x86/cpu/vpmu_intel.c >> +++ b/xen/arch/x86/cpu/vpmu_intel.c >> @@ -230,22 +230,22 @@ static void core2_vpmu_set_msr_bitmap(struct vcpu *v) >> >> /* Allow Read/Write PMU Counters MSR Directly. */ >> for ( i = 0; i < fixed_pmc_cnt; i++ ) >> - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); >> + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); >> >> for ( i = 0; i < arch_pmc_cnt; i++ ) >> { >> - vmx_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); >> + hvm_clear_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); >> >> if ( full_width_write ) >> - vmx_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); >> + hvm_clear_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); >> } >> >> /* Allow Read PMU Non-global Controls Directly. */ >> for ( i = 0; i < arch_pmc_cnt; i++ ) >> - vmx_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); >> + hvm_clear_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); >> >> - vmx_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); >> - vmx_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); >> + hvm_clear_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); >> + hvm_clear_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); >> } >> >> static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) >> @@ -253,21 +253,21 @@ static void core2_vpmu_unset_msr_bitmap(struct vcpu *v) >> unsigned int i; >> >> for ( i = 0; i < fixed_pmc_cnt; i++ ) >> - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); >> + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR0 + i, MSR_RW); >> >> for ( i = 0; i < arch_pmc_cnt; i++ ) >> { >> - vmx_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); >> + hvm_set_msr_intercept(v, MSR_IA32_PERFCTR0 + i, MSR_RW); >> >> if ( full_width_write ) >> - vmx_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); >> + hvm_set_msr_intercept(v, MSR_IA32_A_PERFCTR0 + i, MSR_RW); >> } >> >> for ( i = 0; i < arch_pmc_cnt; i++ ) >> - vmx_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); >> + hvm_set_msr_intercept(v, MSR_P6_EVNTSEL(i), MSR_R); >> >> - vmx_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); >> - vmx_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); >> + hvm_set_msr_intercept(v, MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_R); >> + hvm_set_msr_intercept(v, MSR_IA32_DS_AREA, MSR_R); >> } >> >> static inline void __core2_vpmu_save(struct vcpu *v) > > ... all calls here will go to VMX'es. For making either vpmu_.c > build without that vendor's virtualization enabled, isn't it all it > takes to have ... > >> @@ -916,6 +932,18 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) >> ASSERT_UNREACHABLE(); >> } >> >> +static inline void hvm_set_msr_intercept(struct vcpu *v, uint32_t msr, >> + int flags) >> +{ >> + ASSERT_UNREACHABLE(); >> +} >> + >> +static inline void hvm_clear_msr_intercept(struct vcpu *v, uint32_t msr, >> + int flags) >> +{ >> + ASSERT_UNREACHABLE(); >> +} > > ... respective SVM and VMX stubs in place instead? IMO it is more readable and they looked very good candidates for being abstracted because they are doing the same thing under both technologies. Are you suggesting that their usage in common code should be discouraged and should not be exported via the hvm_funcs interface? Or just that the amount of changes cannot be justified. IIUC Andrew also suggested to use hvm_funcs for msr intercept handling but I 'm not sure whether he had this or sth else in mind. -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Feb 28 20:25:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 20:25:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503764.776068 (Exim 4.92) (envelope-from ) id 1pX6Wx-00023g-O0; Tue, 28 Feb 2023 20:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503764.776068; Tue, 28 Feb 2023 20:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6Wx-00023Z-Kc; Tue, 28 Feb 2023 20:24:59 +0000 Received: by outflank-mailman (input) for mailman id 503764; Tue, 28 Feb 2023 20:24:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX6Ww-00023T-1x for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 20:24:58 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7dbd8a4-b7a5-11ed-9699-2f268f93b82a; Tue, 28 Feb 2023 21:24:57 +0100 (CET) Received: by mail-lj1-x235.google.com with SMTP id z42so11602174ljq.13 for ; Tue, 28 Feb 2023 12:24:57 -0800 (PST) Received: from [192.168.8.114] (46.204.108.203.nat.umts.dynamic.t-mobile.pl. [46.204.108.203]) by smtp.gmail.com with ESMTPSA id 187-20020a2e05c4000000b002934ba305f4sm1373719ljf.59.2023.02.28.12.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 12:24:55 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7dbd8a4-b7a5-11ed-9699-2f268f93b82a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677615896; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=BtKAsqFK1jdTJjTg5pLj9kExJOJA/4iCCLodEKrIEQA=; b=O5jpkwFn8oHP8BaBqYYv4++kh2wscvtvaNKYvyNDoJx6cqt0VqUjSbKiI9aOhQ3Ru1 7/RMf+42XJg/44LEsVOBdmy6BkkzA7VMNJl51cGeiVm7pYe/68e4JreDSpXoBXnHaFRP mxymVtKwlQKiGc/JVWTjRCZIoVzURQcAUTtQ7eyUSDsw8IA2Uoq3xneWook/UcDeuB84 om1wFqI9bwcxLLJt8mmbDJVbyKtnaUeXCdi0z2QBEm0ZkJhKDqH/9vl71UFfF9+4Wgi1 aHf7Yt1RRaq6opXV/vINpHLGxjOgOv793am6QXrV6bQHbj5b0F0hg+u/UrWQBlHDMWCo bfOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677615896; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BtKAsqFK1jdTJjTg5pLj9kExJOJA/4iCCLodEKrIEQA=; b=eYeFKERW5PCXpyb6XR78R6bOcaw2hEglhEVEde+E/21UBrOgW8eiH5olQjeYf20MIs sCE5HmUW3iv0+Sfkj1/s9Q/KFCSKVuls8CCmaea8sYSUtqIrdKnC2cm6h4xg66lbUvUa hfOuaHJM6uHMFXSskx24+4ZAvr+/L4Qx5k2Krv5VKgPy0jxJCZNfMKKfwsLB3BLcHOhy UX08ZUWgDREy801X08iOi8tRATlocjnJa/5/FJdxPBopKzpzi1tbF6mCPbthHiq+c8EY dJYeUTFa+5SIqa0EJUcEFj7tLtXpk6eCzAzd4ooehWBRyTOOJYK1mYtSO15V+97X92Qt WvJw== X-Gm-Message-State: AO0yUKUZpMWsR8Qxgjwsrk+PVi4ADkJ9xHtQc1wg0iJjibZMua/sqNvv NkfuZT5w9/KfI9BeekPr4hU= X-Google-Smtp-Source: AK7set+3Badz1PPgmqG464+EeXYWlVhhF+X12vUwcHAFCpHsB6gndwd6ibD88XNR7mEyzhcJrN2dXQ== X-Received: by 2002:a05:651c:19a9:b0:295:c56d:55b5 with SMTP id bx41-20020a05651c19a900b00295c56d55b5mr1509432ljb.38.1677615896480; Tue, 28 Feb 2023 12:24:56 -0800 (PST) Message-ID: Subject: Re: [PATCH v3 1/4] xen: introduce CONFIG_GENERIC_BUG_FRAME From: Oleksii To: Julien Grall , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Stefano Stabellini , Gianluca Guida , George Dunlap , Wei Liu Date: Tue, 28 Feb 2023 22:24:53 +0200 In-Reply-To: References: <932b0fd2a211d2d837d00e1bda87a84ad680fe7b.1677233393.git.oleksii.kurochko@gmail.com> <8734edd9-70eb-b2bd-8763-b7468d7caba3@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 On Tue, 2023-02-28 at 18:01 +0000, Julien Grall wrote: > On 28/02/2023 17:21, Oleksii wrote: > > Hi Julien, >=20 > Hi Oleksii, > > > > + > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= for ( i =3D 0, b =3D region->frame[id].bugs; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 i < region->frame[id].n_bugs; b++, i++= ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 if ( bug_loc(b) =3D=3D pc ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 { > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bug =3D b; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto found; > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 } > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= } > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > > > +=C2=A0=C2=A0=C2=A0 } > > > > + > > > > + found: > > > > +=C2=A0=C2=A0=C2=A0 if ( !bug ) > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EINVAL; > > > > + > > > > +=C2=A0=C2=A0=C2=A0 if ( id =3D=3D BUGFRAME_run_fn ) > > > > +=C2=A0=C2=A0=C2=A0 { > > > > +#ifdef BUG_FN_REG > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void (*fn)(const struct= cpu_user_regs *) =3D (void > > > > *)regs- > > > > > BUG_FN_REG; > > >=20 > > > AFAIU, this is necessary so Arm can use the generic > > > do_bug_frame(). > > >=20 > > > I was under the impression that RISC-V and Arm had the similar > > > issue > > > with %c. It seems like you managed to resolve it on RISC-V, so > > > can we > > > fully switch Arm to the generic implementation of bug? > > I tried to switch ARM to generic implementation. > >=20 > > Here is the patch: [1] >=20 > I have replied on the other thread. > > > > +#ifndef BUG_ASM_CONST > > > > +#define BUG_ASM_CONST "" > > > > +#endif > > >=20 > > > This line is a bit misterious to me. Would you be able to outline > > > why > > > an > > > architecture would override this? > > It is needed in case if compiler for an architecture doesn't have > > proper support of '%c' ( it is so for ARM & RISC-V ) >=20 > Hmmm.... Why can't x86 use the same version? IOW what's the benefits > to=20 > differ on x86? We can't use '%c' for all architectures because not all compiler supports '%c' fully for all architectures. There is no any benefits. In case of x86 it is needed to delete punctuation before immediate. I mean that immediate is passed as $1 ( or # i always missed with ARM ) and to drop $ it is used %c. >=20 > Anyway, documentation is always good to have because it helps the=20 > reader/reviewer to understand how such decision was made. I'll add the comment then before define. >=20 > Cheers, >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Feb 28 21:33:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 21:33:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503778.776078 (Exim 4.92) (envelope-from ) id 1pX7am-0002vj-MO; Tue, 28 Feb 2023 21:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503778.776078; Tue, 28 Feb 2023 21:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX7am-0002vc-JS; Tue, 28 Feb 2023 21:33:00 +0000 Received: by outflank-mailman (input) for mailman id 503778; Tue, 28 Feb 2023 21:32:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX7ak-0002vW-9R for xen-devel@lists.xenproject.org; Tue, 28 Feb 2023 21:32:58 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75291569-b7af-11ed-a550-8520e6686977; Tue, 28 Feb 2023 22:32:54 +0100 (CET) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-304-bV_qQ1ywMRWLi8AcHUkkow-1; Tue, 28 Feb 2023 16:32:50 -0500 Received: by mail-wm1-f71.google.com with SMTP id l16-20020a05600c1d1000b003e77552705cso4728984wms.7 for ; Tue, 28 Feb 2023 13:32:49 -0800 (PST) Received: from redhat.com ([2.52.141.194]) by smtp.gmail.com with ESMTPSA id w15-20020adfee4f000000b002be5bdbe40csm10742578wro.27.2023.02.28.13.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 13:32:47 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75291569-b7af-11ed-a550-8520e6686977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677619972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8Pc860YSulk9fikEVG+B4aKAm8X5/+wGLcWnCvldhAU=; b=ZEVBf1UwYtMW9eUpGkDrsmOMrmPUweSfGu0FrlJzw/V9vLtvmfWkpjmIutzVi6LeNhnkjg /njyLueejpLTeKJ3IXHIcE6aOBUj0oxIN0/O8zYaVujvZezKShF3dH6wNVr5KvWWYTthEw It2ABeWxaTaES+FKYKVEgu+wIjra1uY= X-MC-Unique: bV_qQ1ywMRWLi8AcHUkkow-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677619968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Pc860YSulk9fikEVG+B4aKAm8X5/+wGLcWnCvldhAU=; b=GrHroGHYewL//Vh5nDySKa6cM64tyIpX6pIoUj1VucY0JSW3mKb7wNapbI/5Y4xVes 14bjud2wCNhsqkrPhPVcSimF/aaEoC9S9um0cja0efvRsn3BRY3MVCP8ArYNlbrFZBm2 KNLCb6UnMRt5Wnljx1WkJvk/l5EBrfm3L4k96FJhO+zjL/LVuQJLaQ2Dza6wspnOmso+ XFWO9l5Duqt5zXZB27stQkxN7AbpRo5lwekzenmw4sUhhnJp/UREVzqK/F7guQyx6JK7 iPBODNNAUAC2YufjWGJ76xX7pb+mE0rpCMtfr7erIOkQacu0hEcm2lVy+SJdcAle4cd7 UCfQ== X-Gm-Message-State: AO0yUKXcBqpxy0vvnd4Ib792xOKreAjnVK6yrUn+a+ObuP14sH34QFcV XhKQI/7WEEELUVGic9a+WwF6zzGbBWy3YKVbFNSfvqZxQjFkPrGlJNoWLn2ZpRVgn6347TTkAz+ TQwltgzRpnh1RJeqtO3PoWwXo6Ng= X-Received: by 2002:a5d:67cc:0:b0:2c6:e827:21c1 with SMTP id n12-20020a5d67cc000000b002c6e82721c1mr3043369wrw.50.1677619968656; Tue, 28 Feb 2023 13:32:48 -0800 (PST) X-Google-Smtp-Source: AK7set+qz21qmC81CB8YlJDWkxwTaOAI0Hras+SGhZGbBgfG8gObN7oaGqTNlhYS4sY6pCkJX1a75w== X-Received: by 2002:a5d:67cc:0:b0:2c6:e827:21c1 with SMTP id n12-20020a5d67cc000000b002c6e82721c1mr3043357wrw.50.1677619968315; Tue, 28 Feb 2023 13:32:48 -0800 (PST) Date: Tue, 28 Feb 2023 16:32:43 -0500 From: "Michael S. Tsirkin" To: Thomas Huth Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-devel@nongnu.org, Peter Maydell , Paolo Bonzini , Markus Armbruster , Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-arm@nongnu.org, Maxim Levitsky , libvir-list@redhat.com, Richard Henderson , xen-devel@lists.xenproject.org, Reinoud Zandijk , Marcel Apfelbaum Subject: Re: [PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts Message-ID: <20230228162938-mutt-send-email-mst@kernel.org> References: <20230227111050.54083-1-thuth@redhat.com> <001bedba-b12f-4dd8-0866-7ccb9ce877d0@redhat.com> <99a83e65-273a-ea1b-e7d9-bbdd8ca32145@redhat.com> MIME-Version: 1.0 In-Reply-To: <99a83e65-273a-ea1b-e7d9-bbdd8ca32145@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 28, 2023 at 09:05:16PM +0100, Thomas Huth wrote: > Well, without CI, I assume that the code will bitrot quite fast (considering > that there are continuous improvements to TCG, for example). We have lots of hosts which we don't test with CI. They don't bitrot because people do testing before release. This is what RCs are for. We did releases before CI - it is a cost/benefit thing. -- MST From xen-devel-bounces@lists.xenproject.org Tue Feb 28 22:13:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 28 Feb 2023 22:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.503784.776087 (Exim 4.92) (envelope-from ) id 1pX8EA-00007M-Qy; Tue, 28 Feb 2023 22:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 503784.776087; Tue, 28 Feb 2023 22:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX8EA-00007F-O5; Tue, 28 Feb 2023 22:13:42 +0000 Received: by outflank-mailman (input) for mailman id 503784; Tue, 28 Feb 2023 22:13:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX8E9-000072-Nr; Tue, 28 Feb 2023 22:13:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX8E9-0006L0-L7; Tue, 28 Feb 2023 22:13:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pX8E9-0003VZ-Em; Tue, 28 Feb 2023 22:13:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1pX8E9-0003b7-EM; Tue, 28 Feb 2023 22:13:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vdqy/24/MEDp9nZRaVMF1+XTB1Q1AeAxvz9CDVj8U0c=; b=pJZjK7Eh3nVJQfHy/pr1PjvudM 6TRz8kK6Xddim9y5nY1w/vb6GTxLqPvm5Q6o79fpH2S0zuOeU3N93jYHqoAPUpHy4fAWVxwVrOtE1 KEXZzOQgUiNY5agNPmX6YtPOSn/bRy717u2CLSX2UzBELyBqXNzePRlBxqrfU/phEhpE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 178802: tolerable trouble: pass/starved - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:build-check(1):starved:nonblocking xen-unstable-smoke:build-armhf:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=b84fdf521b306cce64388fe57ee6c7c00f9d3e76 X-Osstest-Versions-That: xen=976ae57b30d0e9432b51ca2ff408d8e52f40f280 From: osstest service owner Date: Tue, 28 Feb 2023 22:13:41 +0000 flight 178802 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/178802/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 1 build-check(1) starved n/a build-armhf 2 hosts-allocate starved n/a version targeted for testing: xen b84fdf521b306cce64388fe57ee6c7c00f9d3e76 baseline version: xen 976ae57b30d0e9432b51ca2ff408d8e52f40f280 Last test of basis 178789 2023-02-28 17:01:55 Z 0 days Testing same since 178802 2023-02-28 20:01:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf starved build-amd64-libvirt pass test-armhf-armhf-xl starved test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 976ae57b30..b84fdf521b b84fdf521b306cce64388fe57ee6c7c00f9d3e76 -> smoke